support custom file name in gitea dump command

what
with this patch you can submit a custom nam for the backup file created by gitea dump.
gitea dump -f gitea-backup.zip

why
without this patch, when writing a backup script which stores my gitea dump off-site, i have to do some weird gymnastics to get the file gitea dump writes to disk because it generates a random file name with the current unix timestamp. like dump_file=$(ls -t|head -1) while being sure to be in an empty directory.
with this patch, i can just choose the file's name myself and move on encrypting and uploading it.
compatibility
this change should not affect anybody as the new parameter is optional and has a default value which does not change the known behavior of the binary.

Codecov Report

Merging #6474 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #6474      +/-   ##
=========================================
+ Coverage    39.4%   39.4%   +<.01%
=========================================
  Files         393     393
  Lines       53271   53271
=========================================
+ Hits        20992   20994       +2
+ Misses      29292   29290       -2
  Partials     2987    2987

Impacted Files
Coverage Δ

models/repo_list.go
67.89% <0%> (+1.05%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04d78b6...4130a02. Read the comment docs.

In my opinion, the default should remain the same with the timestamp, and the override should just override without giving the %d timestamp option.
If a user wants to override the filename, they should provide the exact name they want. If they need a timestamp, they can figure out how to generate it via shell.

that‘s how it works right now.
El 30 mar 2019, a la(s) 22:13, John Olheiser<EMAIL_ADDRESS>escribió:

In my opinion, the default should remain the same with the timestamp, and the override should just override without giving the %d timestamp option.
If a user wants to override the filename, they should provide the exact name they want. If they need a timestamp, they can figure out how to generate it via shell.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.


--copy-chunker-params in documentation but no longer available

Output of restic version
restic 0.16.5 (v0.16.5-0-gfe9f142b5) compiled with go1.22.4 on linux/amd64
What backend/service did you use to store the repository?
n/a
Problem description / Steps to reproduce
the documentation suggests to use --copy-chunker-params during copy, which isn't available in 0.16.5
restic -r /srv/restic-repo-copy init --from-repo /srv/restic-repo --copy-chunker-params
Expected behavior
either
restic -r /srv/restic-repo-copy init --from-repo /srv/restic-repo --copy-chunker-params
works or it should be removed from the documentation
Actual behavior
unknown flag: --copy-chunker-params
--copy-chunker-params is not listed in restic help copy
Did restic help you today? Did it make you happy in any way?
Yes 💓

I've just tested 0.16.5 and the latest master version and the following command works perfectly fine: ./restic -r newrepo init --from-repo testrepo --copy-chunker-params. We haven't changed anything about --copy-chunker-params since 0.16.5.
It looks like you're running an old version of restic.

--copy-chunker-params is not listed in restic help copy

I assume you meant restic help init?

It was indeed a misunderstanding on my part. I apparently read about half the doc and assumed the rest.


[Feature Request] Project Dependencies

Hi, thanks so much for this very nice tool. One thing that is missing is the ability to mark one task as dependent on another task. I think this is a fairly common feature and it can be quite useful as well. For example, I am imagining that you could have something like
11/2022-12/2022: Create Project Plan #Plan
2/2023-12/2023: Do project #after:Plan

and then you will get an arrow from the end of the "Create Project Plan" bar to the start of the "Do project" bar. Though I'm not sure how hard it would be to implement, I think it would be quite useful.

Yeah I was reading the documentation and didn’t see any mention of dependencies think it would be useful.


How to measure specific body parts?

Hello, how can I measure specific body parts like under bust for women? I know I can edit the code in the measurement definition but I don't have landmark indices for under bust part, how do you get landmarks indices?
Thanks.

The landmark indices are not exact unfortunately.
I defined the landmarks using indices from the SMPL body model by manually selecting points I believe should correspond to landmarks + combining with the landmarks from the SHAPY implementation (you can take a look under shapy/mesh-mesh-intersection/data).
A possible solution could be to use the CAESAR or similar datasets (which should contain scans, landmarks and SMPL bodies fitted to the scans) to determine where the landmarks should be on the SMPL body model by looking at where the ground truth landmarks are. Unfortunately I do not possess such a dataset.
The issue with this however, is the question of how exactly were the SMPL bodies fitted to the scans -- the process usually uses landmarks to do so. Nevertheless, the process usually uses more "important" landmarks, and not under-bust landmarks (for example), which means you should be able to infer those from the fitting.
Hope this makes sense.

Thanks


#495 Added RecipeExtraParams to SetupContext for simplifying Custom Setup

#495 issue asks for a setup wizard.
This PR replaces current setup view per a setup shape. In this way an user can override default setup shape with his own customized Setup shape adding the setup shape on a custom module enabled by default at startup.cs of the root project with services.AddOrchardCms("ModuleOrThemeOverridingSetupShape");.
This PR also changes SetupController and SetupService to help to be reused with other shapes that provides extras parameters for a setup recipe. For doing that it adds to SetupContext a property called RecipeExtraParams of type IDictionary<string, StringValues> where our custom controller will put Request.Form keys and values.

@sebastienros on last commit I've added a setup shape and passed to the recipe parameters all the key values in RequestForm, in that way anyone can override default shape for passing extra parameters to the recipe reusing existing controller.
For use cases where is ok to perform validation of extra parameters only in client side it is an useful feature.

A future improvement for this feature could be to add a shape alternate for the setup with the name of the recipe selected. When the user changes the recipe the reload would be forced to load any specific shape for the selected recipe.

Checks based on travis build fails on mac, but error doesn't seems to be related with nothing in this PR

The mac build on travis is always failing, independent from your PR

Please can you give me feedback related with this PR? Do you prefer I remove the hack done in setup shape for validation? What would be best solution in your opinión?   Do we need to agree on design of this feature before merging it? Do you want a demo?

Right now the setup recipes have to be in the Setup module. Maybe we should make this extensible and have the current recipes come from a CMS module. Something using DI could then resolve the IFile that give access to a list of recipes. This module would be part of the Default features.

Thank you for the review.
Till now I was using my own setup recipe stored in my custom module and it was detected without problems. I will check that it doesn't work as it did before when I rebase our branch o top of master.

Confirmed, setup recipes in other modules are loaded automatically by Orchard.

@sebastienros   said:

I took some time to look at the changes and the goals here. It's a good start I think. I can't see any better way than providing a custom shape for now in terms of extensibility. And i assume it doesn't force the final application to have theming, it's just for setup.

Yes, it is only for setup. You only need to override setup shape, not anything else.

Have you used this branch already and checked it worked as expected?
I tested it partially, I checked valid values were provided to the recipe.
But after hearing that you agree with this PR I'm going to test it in our web api project based on Orchard 2 to be sure everything fits properly. Till now in that project we had modified Orchard.Setup module view and controller to have a custom setup, so it will be a good test.

I'm able to override setup shape only if I put the custom setup shape in SafeMode theme and initializin OrchardCms with SafeMode module: services.AddOrchardCms("SafeMode");. But if I use a regular module it doesn't work. Is there a way of overriding a shape invoked in another module from a module that is not a theme?

I close this PR cause I didn't take into account that for returning posted data in postback when controller finds an error I need do things not very clean for binding those data on the setup shape controls. So the solution will be a bit hacky. It would be interesting me or other tries a less easy but more elegant approach based on https://github.com/OrchardCMS/Orchard2/issues/716


Added Confirmation Email Feature.

Added Token EmbeddedDocument to User and date fields (last login, created and updated)
Added Postmark to send email. Set new environment variable.

DO NOT MERGE.


minor changes to spark/README.md file to avoid

hick ups in first time setup of spark integration
Problem
👋 Thanks for opening a pull request! Please include a brief summary of the problem your change is trying to solve, or bug fix. If your change fixes a bug or you'd like to provide context on why you're making the change, please link the issue as follows:
Closes: #ISSUE-NUMBER
Solution
Please describe your change as it relates to the problem, or bug fix, as well as any dependencies. If your change requires a schema change, please describe the schema modification(s) and whether it's a backwards-incompatible or backwards-compatible change, then select one of the following:

Note: All schema changes require discussion. Please link the issue for context.

[ ] Your change modifies the core OpenLineage model
[ ] Your change modifies one or more OpenLineage facets

If you're contributing a new integration, please specify the scope of the integration and how/where it has been tested (e.g., Apache Spark integration supports S3 and GCS filesystem operations, tested with AWS EMR).
One-line summary:
Checklist

[ ] You've signed-off your work
[ ] Your pull request title follows our guidelines
[ ] Your changes are accompanied by tests (if relevant)
[ ] Your change contains a small diff and is self-contained
[ ] You've updated any relevant documentation (if relevant)
[ ] Your comment includes a one-liner for the changelog about the specific purpose of the change (if necessary)
[ ] You've versioned the core OpenLineage model or facets according to SchemaVer (if relevant)
[ ] You've added a header to source files (if relevant)

SPDX-License-Identifier: Apache-2.0
Copyright 2018-2023 contributors to the OpenLineage project

Codecov Report

Merging #2202 (aff087a) into main (782840b) will decrease coverage by 0.89%.
Report is 2 commits behind head on main.
The diff coverage is n/a.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
@@             Coverage Diff              @@
##               main    #2202      +/-   ##
============================================
- Coverage     80.98%   80.09%   -0.89%
  Complexity      125      125
============================================
  Files            90       85       -5
  Lines          3792     3623     -169
  Branches         33       33
============================================
- Hits           3071     2902     -169
  Misses          682      682
  Partials         39       39

see 5 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Refactor

This PR:
supports ternary operator. (and add tests.)
supports --debug and --trace command line option.
rename like VM2 -> VM, ObjectKind2 -> ObjectKind.
kill some unsafe codes.
fix codes for Rust 2018 edition-ready.

Circle CI failed...  I'll check it.

Circle CI passed.


MIDI message level interface design

I'm preparing to add midi mesage level interface to symusic, but it's not very clear yet how the interface should be designed.
So I thought I'd ask your opinion here @wrongbad

The first question is what level of detail do you need? Probably all the channel messages are in. Do you think anyone would want sysex, real-time or meta messages?
You probably want to offer a single array view of the event stream so users don't have to reconstruct timing. But then you need a way to present different message object. In tensormidi I used a super-set struct with multi-purpose fields, but that might not match the style of this project. Since you have a pointer-indirection array already, maybe you could have it hold multiple backends for different types, but present a single pointer / object sequence.

After thinking it over, I feel like I still haven't figured out what the usage scenario is for adding message level Api? For me, it's more of a debug tool that can be used to analyze if there are any errors when saving midi. I think it's important to analyze the possible usage scenarios to figure out what pattern to design it as.

Oh I see. In my case, I'm trying to model noteon/noteoff events causally, so I can condition the generation on a live stream (e.g. from a digital instrument).


Image component not invoking onError when the image uri is an empty string

React Native version: 0.61
Steps To Reproduce
The following code snippet wouldn't invoke onError event
export default class App extends React.Component {

  onImageError = () => {
    alert("Image failed to load");
  }

  render() {
    return (
      <View style={styles.container}>
        <Image source={{uri: ""}} onError={this.onImageError} />
      </View>
    );
  }
}

Describe what you expected to happen:
onError should be invoked since empty string is not a valid image url
Snack, code example, screenshot, or link to a repository:
https://snack.expo.io/@daniakash/image-component-issue

Thanks for reminding me. Let me check with the latest version...

No idea when this is going to be fixed...

Unfortunately, I'm unable to add labels to this issue for some reason... But yeah this issue still exists. I have updated the snack to work with latest expo sdk

Verified. This issue is fixed now xD 🎉

still facing the issue

still facing the issue

Same here.


[Feat]: Auto Commenting when an Issue is Closed

This feature aims to solve the problem of poor communication and lack of acknowledgment when issues are closed. By automatically commenting on closed issues, it ensures that contributors are informed about the closure and are thanked for their efforts. This helps maintain a positive and engaging community atmosphere, encouraging continued contributions and fostering good relationships between maintainers and contributors.

@Avdhesh-Varshney please assign me this issue

@Asymtode712 this project is not required non-code things. So, just focus on the code not on non-code things.


Setting coboleditor.parse_copybooks_for_references needed to get auto-completion of copybook vars?

Tested with the first the last 6.7 version:

coboleditor.parse_copybooks_for_references = false
complete workspace parsed for metadata (on startup)
starting to type a name of a variable brings up the matching variables fast
starting to type a name of a variable defined in a copybook doesn't come up

Second test

coboleditor.parse_copybooks_for_references = true
starting to type a name of a variable defined in a copybook then the matching variable is shown (but quite laggy)
coboleditor.parse_copybooks_for_references = false
reload window
starting to type a name of a variable defined in a copybook then the matching variable is not shown

Dumped metadata shows that the copybook is indexed and contains the requested variables
I think once the copybook is parsed and referenced in the source then all variable names should be available in auto-completion and always be read from the metadata (not from the file).
Note: the metadata for the copybook would also need to contain a reference to nested copybooks (haven't checked if this is the case yet).

The scanning of the programs/programs are done as independent files, irrespective of the parse copybooks settings.
This way, it can be used with the parse copybook settings when editing the file (so supplement the results).
The cached definition provider looks for symbols in a file and any copybook it references therefore parsing the copybook inline during the "file" cache will result in over scanning for no reason.
More importantly, the symbols, line numbers in the file cache are relative to the file, it has no ability to "nest" files.. ie: the store if symbol, line.. not symbol, line, file hence it was a bug that needed to be fixed.
export class COBOLSymbol {
    public symbol: string | undefined;
    public lnum: number | undefined;

    public constructor(symbol?: string, lineNumber?: number) {
        this.symbol = symbol;
        this.lnum = lineNumber;
    }

    // eslint-disable-next-line @typescript-eslint/no-explicit-any
    // eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types
    static fromJSON(d: any): COBOLSymbol {
        return Object.assign(new COBOLSymbol(), d);
    }
}`

More importantly, the symbols, line numbers in the file cache are relative to the file, it has no ability to "nest" files.. ie: the store if symbol, line.. not symbol, line, file hence it was a bug that needed to be fixed.

Should this be solved now? With version 6.8.5 I still have the same issue with the nested copybook setup (sample given in #218 with additional setting of coboleditor.copybookdirs.

Using parse_copybook_for_references allows you to see fields defined in a copybook.

Explained with the new 610.0 README:

If you want the extension to understand the contents of your copybook before you access them, then turn on the coboleditor.parse_copybooks_for_references setting.

So the answer to the initial question is: Yes, the setting coboleditor.parse_copybooks_for_references is needed to get auto-completion of copybook vars, even with full metadata-cache available.


Weather list example typo

Very minor but this threw me for a little while before I was able to spot the issue
I used the weather list example tile to while getting started with TileBoard.  My icons were not showing and assuming I did something dumb, went looking. After some time (and understanding what was going on in the example code) I realized the issue with the example code:
icon: "&sensor.dark_sky_icon_" + id + ".state",
Should be:
icon: "&sensor.dark_sky_icon_" + id + "d.state",
This brings it in line with all the other sensor references in the sample code and the icons appear perfectly.

The example was updated in https://github.com/resoai/TileBoard/pull/676 to use OpenWeatherMap so this is no longer relevant.


refactor secrets (tokens, certs, users) generation

we faced a lot of issues with rsync/synchronize related to authentication between nodes.
the idea is to create these secrets on the deployment machine

https://github.com/kubespray/setup-kubernetes/pull/139

Fixes with #140


[Doc] Update plugin versions for 24.10.0 [skip ci]

The PR is to update the plugin version to v24.10.0
Signed-off-by: liyuan<EMAIL_ADDRESS>

file #453 , merge this pr.


Smarter Cache Updating

We can use the GTFS Versions API to see when the new schedule comes into date, rather than just rebuilding the entire cache every 3 days.
https://api.at.govt.nz/v2/gtfs/versions

This is very important. Mostly because AT update their schedules a lot, and then Real-time stops working because it needs a cache rebuild.


Setting for not opening files on rename

When a file is renamed, it it automatically opened. In most cases I don't want to see or edit the contents of the file at that moment. However, to allow for that behavior I would suggest to add a setting to prevent it.

Oh wait I just realised what you're doing: you are renaming from the side bar, right? Maybe we are able to automatically detect that...

When a file is renamed, it it automatically opened.

Sublime Text does that as soon as you right click. All FileManager does after that is retarget the view.

Maybe we are able to automatically detect that...

I quickly looked, and I don't think that this is going to be possible. When you right click on a file in the side bar, it is automatically opened in this weird kind of state, which if I knew how to detect, I could then store and automatically close the view after the rename. But I don't :slightly_frowning_face:
And always closing the file after rename isn't a good option because when you rename from the control panel, you expect the file to stay open (adding a setting to always close after rename would also be bad).
So, since I don't see a way to get this to work, I'm going to close this for now. If anyone knows how to detect the file's weird state, please reopen, it should then be trivial to implement.


Updated: openvpn

${}

26bc19a0-d7b5-4755-9ddd-934d3adfd629

Newer version of openvpn (1.0) is now available in master. 97c8a5512307fb5e8eb9a2fb4403e8747f3d3822


database list in the dataset creation form is empty

A clear and concise description of what the bug is.
I installed Superset and connected the PostGres database to it, but the database list in the dataset creation form is empty and there is no database
https://pasteboard.co/gT0ocv1NjGDI.jpg
How to reproduce the bug

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected results
what you expected to happen.
Actual results
what actually happens.
Screenshots
If applicable, add screenshots to help explain your problem.
Environment
(please complete the following information):

browser type and version:
superset version: superset version
python version: python --version
node.js version: node -v
any feature flags active:

Checklist
Make sure to follow these steps before submitting your issue - thank you!

[ ] I have checked the superset logs for python stacktraces and included it here as text if there are any.
[ ] I have reproduced the issue with at least the latest released version of superset.
[ ] I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context
Add any other context about the problem here.

Hi there. I don't mean to be dismissive, but I'm going to close this since it doesn't include pertinent reproduction details. No version info, steps taken, and the screenshot seems to be long gone (I'd recommend just pasting the image into github itself). If you can provide more pertinent details to help us troubleshoot, we can re-open this. Or... perhaps it's not even an issue in newer versions of Superset, e.g. 2.0.x?


Add WIT parsing

Allows user to define an external plugin in a plugins WIT File
E.g. DemoApp1
interface demoapp2 {
    callintoplugin: func() -> string;
}

    fn helloworld() -> String {
        let barry = demoapp2::callintoplugin();
        format!("barry is {}", barry)
    }

The supervisor will then parse this WIT file, recognize the mention of an external service and it's function, mock it and run the plugin, should the plugin call the mocked function, the supervisor will initialize the foreign service and run it again.
Previous implementation of this required on hardcoded values, this is now dynamic.

I've messed up my rebasing on this branch, closing this PR in favour of #639


error codes are impossible to decipher

if wlan helper gives a error code it would be nice if there was a pdf or something like that. this should contain any error codes and what the error means

You can google that error code together with the function name. That will probably point you to a MSDN documentation page.

i checked the internet and there are no documents saying the error codes on the internet. i would not mind helping create a document with error codes and their meanings,

Can you paste your full error output from CMD here?

SetInterface error, error code = 1168
SetInterface error, error code = 5
these are 2 error codes i managed to recreate as you can see for a beginner it is very confusing. i feel that it would be better to create a pdf or txt file with all error that are possible and what they mean to help debugging

@advaithm you should use the latest version WlanHelper, the latest version will report the error message as well, see: https://github.com/nmap/nmap/issues/990#issuecomment-342884345

My network card is 'Intel WiFi6 AX200'. It goes into monitor mode with Tamosoft Commview for WiFi OR using kali linux, but when using wlanhelper (on windows 10) to change the interface mode to 'monitor' it gives an error:
C:\Windows\System32\Npcap>wlanhelper "Wi-Fi" mode monitor Error: SetWlanOperationMode::SetInterface error, error code = 50 (The request is not supported) Failure

@devilsnare007 it's usually because the Windows driver for your NIC doesn't implement the monitor mode.

@devilsnare007 it's usually because the Windows driver for your NIC doesn't implement the monitor mode.

forgive my ignorance, but if it is indeed a Windows driver issue - why would it work fine when using Commview (on Windows) OR perhaps Commview implements its own driver which npcap does not - in which case it indicates npcap's limitation and not necessarily a windows driver issue..

@devilsnare007 got it. Please send the issue to: https://github.com/nmap/npcap/issues then.


Padding on node table

I found changing this value was an option to fix the style:

Here is what it looks like if I change the first number in decimal from 7 to 4:

It seems the origin is defined by Semantic UI so I'm hesitant to change it. But I think it looks better when it all fits on a single line. Does the style issue occur for anyone else?

Then again every user will have their own screen-size.
So even if the padding was changed it's sure to flow to next line in some situations based on screen-size.

I have to use 70% zoom to be able to see what is on the page :D so it would be useful to make the button smaller

@emlun007 that sucks. Do you know how many pixels across your browser is?
I posted a fix that seems to help on screens between 1200px-1500px.
On my setup at least the problem was the Certname column was too wide.

I assume that this is fixed by #436 and therefore closing this issue. Please reopen if it is not.


Release 1.0.5 version

#155 (Removes upper bound for pyarrow) is already merged.
Can we release a new version of db-dtypes?

@tswast @parthea @chalmerlowe Can we do it?

Unfortunately the bot didn't pick #155 up due to the "chore" prefix. See: https://github.com/googleapis/release-please#release-please-bot-does-not-create-a-release-pr-why
I think our best option would be to send an empty PR detailing #155 as a deps:  prefix with git commit --allow-empty -m "deps: remove upper bound on pyarrow version"
@EugeneTorap Would you mind sending one if I forget?

Fixed by https://github.com/googleapis/python-db-dtypes-pandas/pull/163


Table is missing

Why I can't see any option for table?

Still that component is not created, would you like to help do it?

@luisDanielRoviraContreras I can help with that

@roonie007 If you want you can help in a somewhat easier component or with some existing ones, thanks for the contribution.

I can help you to do it.

It would be great the only thing is that this component is somewhat complicated if you want you can do something simpler to start and then this something like Collapse (Accordion) clear if you think you can do this component well forward and thank you very much

I have a basic table component created if you are interested in seeing it I can create a branch on my fork.

Of course no problem, this component is not done because I want it to have all the functionalities such as editable, add row, add colum, checked row, filter, pagination, remove row, disabled value, to be really functional and necessary

Mine is a basic table for displaying an array of objects. You can specify the headers, data source, and columns. Has built in functionality to display an edit and/or delete button. So it sounds like it is lacking a lot of the features you are looking for.

Well thank you very much for the contribution you are giving to Vuesax and the community

This is the las component I would need this framework to have in order to use it for my personal projects. Any progress on this?
For me, the minimum features should be:

Column sorting
Column filtering
Global search
Action buttons
Row selection for batch actions (checkboxes)
Pagination

This could be a good start point: https://vuematerial.io/components/table

Well for now I am in stabilizing all the components for support ssr and better accessibility as soon as I finish that I put in this component that really is important thanks to all

Added the vs-table component in the latest version, thank you very much
https://lusaxweb.github.io/vuesax/components/table.html#default


VM: implement tests from neo-vm repo

Canonical neoVM implementation has it's own tests in json format.
https://github.com/neo-project/neo-vm/tree/master/tests/neo-vm.Tests/Tests/OpCodes
We can try to use them to test our implementation too.

I think that's what is meant by the #196, so technically it's a duplicate. See also #286.


Provide Headers for Win2D

I realise that the metadata compiler will eventually be released but in the meantime could we have support for Win2D as this would be quite useful.

Thanks for the feedback. Win2D is a great API and we hope to provide support for it in a future update.

@kennykerr, any news regarding Win2D support?

@kennykerr we critically need headers for Win2D, is it possible to speed up providing headers?

Is this something the community could help with?

Has anything happened with this? I have seen mention that one can do surgery on a project to manually accomplish Win2D support (if one really knows what one is doing), but it would be so fine to just have the functionality available by the usual means.

I answered the question on Stack Overflow.

Thanks Kenny. I'll give that a try.


Issue 12647 - Lazy parameter evaluation should be marked as nothrow

https://issues.dlang.org/show_bug.cgi?id=12647

What is the status on this? This bug affects collectException as well :(

I'm porting Vibe.d to 2.067.This affects us as well.

Looks useful, what's the other problem?

Here:
https://issues.dlang.org/show_bug.cgi?id=12647
I read it was blocked by two other bugs, now they seem solved.
This bug affect me too.


Can't fly up using the jump key while gliding in creative mode after dying

I am unsure how exactly this works but sometimes if I die, I am unable to use the feature where you can fly up with the elytra using the jump key in creative mode. If I die in survival or adventure mode while gliding with an elytra with keepInventory on, it doesn't work anymore after respawning and going into creative mode. Relogging fixes it.
https://github.com/Wilyicaro/Legacy-Minecraft/assets/166852932/0571bd31-91c0-45c9-89e6-c58f6e83a684

This also seems to cause you to have Java's flying mechanics instead of the ones from LCE.

Fixed in version 1.6.4, thanks for reporting.


Remove hashmap in UniqueList classes

PR #96 introduced a hashmap for better lookup time when accessing elements by id. Remove this to keep the implementation simple.

If it works, it works. Let's just leave it for now.


Add steps on how to turn off tracing in graphQL

I'm excited to learn about the steps needed to disable otel tracing in GraphQL.
cc @arielvalentin

To elaborate here a bit we are missing docs on disabling or customizing instrumentation using environment variables. Right now, we only have it via configs.
https://opentelemetry.io/docs/languages/ruby/libraries/#overriding-configuration-for-specific-instrumentation-libraries

The RubyDocs has a snippet that we should include on opentelemetry.io: https://rubydoc.info/gems/opentelemetry-instrumentation-base/0.22.3/OpenTelemetry/Instrumentation/Base

The instrumention class establishes a convention for disabling an instrumentation by environment variable and local configuration. An instrumentation disabled by environment variable will take precedence over local config. The convention for environment variable name is the library name, upcased with '::' replaced by underscores, OPENTELEMETRY shortened to OTEL_LANG, and '_ENABLED' appended. For example: OTEL_RUBY_INSTRUMENTATION_SINATRA_ENABLED = false.

@robbkidd As you have motioned may times before... we need better tooling around documentation and options!

Would the updated doc resolve this kind issue?


Debug Assertion failed at /Users/bootywarrior/Downloads/fuzzilli-main/Sources/Fuzzilli/Core/ProgramBuilder.swift:513: Unexpected type encountered .integer | .object()

Running commands : swift run -c debug FuzzilliCli --profile=jsc --jobs=4 --consecutiveMutations=2 --engine=multi --corpus=markov --storagePath=/Users/bootywarrior/Desktop/Aggyfuzz --collectRuntimeTypes --importCorpusMerge=/Users/bootywarrior/Desktop/mergeddcorpus --overwrite /Users/bootywarrior/Downloads/Webkit/latest/WebKit/FuzzBuild/Debug/bin/jsc
Yields...

Fuzzer phase:                 Fuzzing (with MultiEngine)
Uptime:                       0d 0h 28m 1s
Total Samples:                19
Interesting Samples Found:    4799 (97.04% with runtime type information)
Last Interesting Sample:      0d 0h 0m 1s
Valid Samples Found:          4
Corpus Size:                  4799
Correctness Rate:             nan% (21.05%)
Timeout Rate:                 nan% (21.05%)
Crashes Found:                0
Timeouts Hit:                 4
Coverage:                     15.34%
Avg. program size:            nan
Avg. corpus program size:     35.89
Connected workers:            3
Execs / Second:               54.91
Fuzzer Overhead:              32.67%
Total Execs:                  73791
Type collection timeout rate: 5.00%
Type collection failure rate: 0.23%
[F4809D3F:Assert] Debug Assertion failed at /Users/bootywarrior/Downloads/fuzzilli-main/Sources/Fuzzilli/Core/ProgramBuilder.swift:513: Unexpected type encountered .integer | .object()

This is now fixed, generateVariable() no longer exists: https://github.com/googleprojectzero/fuzzilli/commit/e264abb403c3c63b713d20c8649f0840a59a08cd


Windows - Cursor move to next line if you press Enter

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Go to https://staging.new.expensify.com and log in with any account
Go to any conversation
Start typing the message and press Enter

Expected Result:
Message should be sent after press Enter
Actual Result:
Cursor move to next line if you press Enter
Workaround:
Unknown
Platform:

Where is this issue occurring?

Web/ Windows

Version Number: <IP_ADDRESS>
Reproducible in staging?: Yes
Reproducible in production?: Yes
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://user-images.githubusercontent.com/93399543/153694521-6ad03a2e-1604-4c7d-a092-e3cb970b44e9.mp4
https://user-images.githubusercontent.com/93399543/153694529-8d8c4f90-28fd-4365-9aa1-99f04f4de4f9.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause
Slack conversation:
View all open jobs on GitHub

Triggered auto assignment to @chiragsalian (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

Hmm i'm not able to reproduce this on staging or production. Are you still able to consistently reproduce this and are you sure the shift key was not held?

Friendly bump, any update to my question above @kbecciv? 🙂

@chiragsalian Yes, I am consistently reproduce this issue, no shift key was held for this action.

Hmm weird, I cannot reproduce. Anyway no worries i'll open it up to contributors that can test and figure out the problem.

Triggered auto assignment to @michaelhaxhiu (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

I also cannot reproduce this bug, and that's typically a mandetory step for me as a contributor manager before externally assigning this job.
In order to proceed, I think we need more context on how to reproduce this issue. I followed steps under "Action Performed" and whenever I hit enter it always sends the message exactly as expected.  @kbecciv sorry to ping you again but any chance you can try to add more context here?

@michaelhaxhiu I understand that you may have an issue reproducing the issue. It is not repro on MacOS. We have multiple users who are facing this and it seems to be Device specific.
E.g every user with ASUS laptop is able to see it.

@mvtglobally In any case Do those laptops have a touch screen?

@parasharrajat i can ask others, but my laptop has a touchscreen where I can repro the issue

Gotcha. Ok, I can see which PR caused it and why?
This is the culprit code https://github.com/Expensify/App/blob/6ef2e519d1ecf5b0e6db3f5498e24c7e50e9f21b/src/pages/home/report/ReportActionCompose.js#L343.
Although, the last commit is mine :smile_cat:. But this change was originally added https://github.com/Expensify/App/pull/7355 .
In Short, if a device has a touch screen Enter to submit shortcut is disabled. But I see that it can be irritating for touch screen laptop users who are not really using the touchscreen.

@michaelhaxhiu, did you post this job in upwork? If not please do. Looks like it's specific to touchscreen devices.
@parasharrajat, thanks for the find. I'm not sure if the last statement is a solution. Either way, can you explain where you'll be adding the code and what would it be for clarity. Additionally, I was curious if this is something you can test or not? Worst case we can still push out the fix and ask QA if it's been resolved.

I haven't proposed anything yet https://github.com/Expensify/App/issues/7715#issuecomment-1047280722 is an explanation of the root cause.
Propose.
I don't see any solution that allows us to detect that the user is using an external keyboard so we will have to detect that the user is on desktop.
Possible options.
2. dimensions check.
3. UserAgent check.
4. feature detection.
I will try to find a bulletproof solution for it.

Cool, thanks for clarifying. I'll bump this down to weekly since i don't feel like its a daily. If anyone disagrees feel free to bump it up.

@michaelhaxhiu, did you post this job in upwork? If not please do. Looks like it's specific to touchscreen devices.

done
https://www.upwork.com/jobs/~01e9d1a86d39175b4d

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (Exported)

Current assignee @chiragsalian is eligible for the Exported assigner, not assigning anyone new.

We could listen onkeyPress from TextView and inside the listener we can check if key pressed is Enter, and if yes, we will call the sendMessage() function

This is still open to proposals. I will try to get a solution if I have enough time to dig in.

Price doubled to $500.

Proposal
There is a solution that we can detect that touchable feature in window.
Ref: https://hacks.mozilla.org/2013/04/detecting-touch-its-the-why-not-the-how/

Add a condition that detects touch device or not.

const isTouchDevice = () => {
    return (('ontouchstart' in window) || (navigator.maxTouchPoints > 0) || (navigator.msMaxTouchPoints > 0));
}

Add more conditions in this line
https://github.com/Expensify/App/blob/6ef2e519d1ecf5b0e6db3f5498e24c7e50e9f21b/src/pages/home/report/ReportActionCompose.js#L343

if (!e || (VirtualKeyboard.shouldAssumeIsOpen() && !isTouchDevice())) {
   return;
}

Know issue that we could face an issue with the mobile browser which is ontouchstart also exist. So I would add functionality to detect it is mobile browser or not by userAgent.

function detectMobible() {
    const toMatch = [
        /Android/i,
        /webOS/i,
        /iPhone/i,
        /iPad/i,
        /iPod/i,
        /BlackBerry/i,
        /Windows Phone/i
    ];

    return toMatch.some((toMatchItem) => {
        return navigator.userAgent.match(toMatchItem);
    });
}

Demo
Before
https://user-images.githubusercontent.com/5449119/158053252-78cfbb90-8422-446a-a97a-8a850a3b8d69.mp4
After
https://user-images.githubusercontent.com/5449119/158053254-f709791f-0244-4c1d-9fb9-1c5c812679b4.mp4

I do not understand this proposal. VirtualKeyboard.shouldAssumeIsOpen() fallbacks to touch devices to assume if the virtual keyboard is open and you are adding another condition that reverses that.
On the other hand, userAgent matching is not a bulletproof technique. Let's use feature detection instead.

It already does that. Let's work on the other request first. Thanks.

Doubling price again, as we haven't seen a solution that solves the problem yet.

Doubling price again.

Doubling price again.

PROPOSAL
Changing:
https://github.com/Expensify/App/blob/fd0f83a2e557c9f6d1adcf5be6feb761cd9f40b4/src/libs/VirtualKeyboard/index.js#L16-L26
by:
function shouldAssumeIsOpen() {
    return isOpen();
}

Won't give us the expected behavior?
I didn't get why seeing user has a touchable device will assume kayboard is open.

@parasharrajat I think it won't work when we don't have the VirtualKeyboard API(it will return us null).
We currently use this logic:
 * As of January 2022, the VirtualKeyboard web API is not available in all browsers yet
 * If it is unavailable, we default to assuming that the virtual keyboard is open on touch-enabled devices.
 * See https://github.com/Expensify/App/issues/6767 for additional context.

But now we know assuming that the virtual keyboard is open on touch-enabled devices won't give us the expected behavior when we have a desktop working with touch-enabled.
There's no way we can know if user's device is either desktop or mobile unless using userAgent to check it:
I know using userAgent isn't the optimal solution but I think its our only alternative.
So in my updated proposal I think we should:
PROPOSAL
Create a function which will tell us if user isMobile only when we don't have the VirtualKeyboard API(instead of looking if device is touch-enabled):
function isMobile(){
     /Android|webOS|iPhone|iPad|iPod|BlackBerry|BB|PlayBook|IEMobile|Windows Phone|Silk|Opera Mini/i.test(navigator.userAgent))
}

Then we would have an updated shouldAssumeIsOpen() as follows:
function shouldAssumeIsOpen() {
    const isOpened = isOpen();
    return _.isNull(isOpened) ? isMobile() : isOpened;
}

This way, when we don't have the VirtualKeyboard API:
When isMobile = true we will return shouldAssumeIsOpen true
When isMobile = false we will return shouldAssumeIsOpent false
and it will give us the expected behavior.
*Also we will use this new function(isMobile) in other parts of the project when we need it like in this case we don't have others options.

Can we use Feature detection instead of User_agent check or dimensions check? Out of these, which one do you think is best and why?

Dimensions check - I think we can't use dimensions check because we are dealing with a big amount of possible screen sizes and in my opinion it doesn't make sense to use thoses values in order to know if the device uses a virtual keyboard.
We could have desktop devices with lower width than some tablets or ipads(which will use virtual keyboard) for example.

UserAgent check - That's the best solution given our cenario(when we can't use virtual keyboard check) in my opinion. We can specify the target devices and it will run as it should.

Feature detection - I think we already do feature detection everytime we can in this part of code, doesn't we? https://github.com/Expensify/App/blob/fd0f83a2e557c9f6d1adcf5be6feb761cd9f40b4/src/libs/VirtualKeyboard/index.js#L4-L14
When we check for the virtualKeyboard API we are discarding having to use userAgent check

https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Feature_detection says:
Feature detection involves working out whether a browser supports a certain block of code, and running different code depending on whether it does (or doesn't)
We are checking virtualKeyboard when the browser supports it, and using this new isMobile logic for when it doesn't.

I meant feature detection for detecting if a device is a desktop with an external keyboard.

Dimensions check

This was/is a testing method on a few CSS frameworks like bootstrap. But I feel like, it is going to be buggy.
At last, until we break anything for users that are using isOpen api, I am good with userAgent check. Could you please tell me the places where this is used and how will user solution worth it without breaking those?

I meant feature detection for detecting if a device is a desktop with an external keyboard.
Dimensions check
This was/is a testing method on a few CSS frameworks like bootstrap. But I feel like, it is going to be buggy.

As far as I could find, people count time and make assumptions based on time between KeyDown and KeyUp  to know if the keyboard is either real or virtual:
https://stackoverflow.com/questions/18880236/how-do-i-detect-hardware-keyboard-presence-with-javascript
I think it's hacky and more a workaround than achieving the desired solution and won't work everytime.
I still strongly think we should go with userAgent check.
So in my updated proposal:
PROPOSAL
in my solution we are going to create new folder/file within https://github.com/Expensify/App/tree/main/src/libs/
isMobile/index.js
with the content:
/**
 * Allows us to identify whether the platform is mobile.
 *
 * https://developer.mozilla.org/en-US/docs/Web/HTTP/Browser_detection_using_the_user_agent
 *
 * @returns {Boolean}
 */
 function isMobile(){
        return /Android|webOS|iPhone|iPad|iPod|BlackBerry|BB|PlayBook|IEMobile|Windows Phone|Silk|Opera Mini/i.test(navigator.userAgent);
}

export default isMobile;

And use it here instead of use canUseTouchScreen() https://github.com/Expensify/App/blob/fd0f83a2e557c9f6d1adcf5be6feb761cd9f40b4/src/libs/VirtualKeyboard/index.js#L16-L26
After changes:
/**
 * As of January 2022, the VirtualKeyboard web API is not available in all browsers yet
 * If it is unavailable, we default to assuming that the virtual keyboard is open on mobile devices.
 * See https://github.com/Expensify/App/issues/7715 for additional context.
 *
 * @returns {Boolean}
 */
function shouldAssumeIsOpen() {
    const isOpened = isOpen();
    return _.isNull(isOpened) ? isMobile() : isOpened;
}

At last, until we break anything for users that are using isOpen api, I am good with userAgent check. Could you please tell me the places where this is used and how will your solution work without breaking those?

What do you think about this?

What do you think about this?

Sorry I didn't get what you want...
If you mean where we will use it:
We will use it here:
https://github.com/Expensify/App/blob/6ef2e519d1ecf5b0e6db3f5498e24c7e50e9f21b/src/pages/home/report/ReportActionCompose.js#L342-L344
Instead of use canUseTouchScreen() and assume when canUseTouchScreen = true the device is mobile we will use the userAgent check to tell us when we are on mobile devices

ok. I think this mobile userAgent check is best suited for shouldAssumeIsOpen instead of canUseTouchScreen. IMO, isMobile should be moved to getBrowser lib.
Rest, I am fine with @mateusbra's approach to this problem https://github.com/Expensify/App/issues/7715#issuecomment-1097194870. I was waiting on a proposal with feature detection but there is no such API atm. And @mateusbra's reason for dimensions check seems valid.
cc: @chiragsalian
:ribbon: :eyes: :ribbon:  C+ reviewed

Proposal LGTM as well. Feel free to create the PR @mateusbra.

I submitted a proposal on Upwork, gonna rise a PR soon!

Hired - let's get this party started.

Issue not reproducible during KI retests. (First week)

Issue not reproducible during KI retests. (Second week)

PR deployed on PROD 4 days back.

Just a quick bud check -- so does that mean payment is due on Friday for @mateusbra, assuming no regressions between now & then.
Weird the GH title didn't update to add that 🤔

Yeah, Please update the title. It must be due to the wrong link format used on PR. Please update that as well if possible.

@parasharrajat can you apply for this job - https://www.upwork.com/jobs/~0112030d1e6d50fa17 for the C+ work

@mateusbra has been paid.

Issue not reproducible during KI retests. (Third week)

Ping for

@michaelhaxhiu

Waiting for you to accept job offer @parasharrajat 👍

Paid.


Console does not sanitize address config names

When creating an address in the console using camelCase, i.e. 'shardedTopic', the console does not seem to sanitize the 'name' field of the configmap that is created so that it is a legal OpenShift resource.
Moreover, the logs in the agent is confusing:
2018-02-19T08:37:47.530Z agent info Accepted incoming websocket connection
2018-02-19T08:37:47.542Z agent info GET /api/v1/namespaces/myproject/configmaps?labelSelector=type%3Daddress-plan => 200
2018-02-19T08:37:57.928Z agent info creating address {"address":"shardedTopic","type":"topic","plan":"sharded-topic"}
2018-02-19T08:37:57.944Z agent info POST /api/v1/namespaces/myproject/configmaps?labelSelector=type%3Daddress-plan => 422
2018-02-19T08:37:57.945Z agent info create_address succeeded

Here, it states create_address succeeded, when it is actually receiving a 422 from the OpenShift REST API.

@grs We should try to make the code in utils.js kubernetes_name and in java KubeUtil.sanitizeName do the same thing when creating kubernetes names.
For instance, I think the utils.js needs to handle names that start or end with '-'. The java code should be changed to create a qualifier as well.

@grs Actually, we should perhaps also sanitize not only the configmap name, but the 'name' field in the Address resource as well?


Issue Starting Timberborn from Thunderstore

Please help :)
log.txt

Wrong document, sorry!
LogOutput.log

mod work priority dont work, you have singleton issue that comes from that mod, if you disable it, it should start.


OIPA-2216

https://app.zenhub.com/workspaces/iaticloud-5b8e865bb2cc7b6c78ece322/issues/zimmerman-zimmerman/iati.cloud/2072
https://app.zenhub.com/workspaces/iaticloud-5b8e865bb2cc7b6c78ece322/issues/zimmerman-zimmerman/iati.cloud/2216

:tada: This PR is included in version 5.2.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Feature Request: Fargate based implementation

Currently the UI implementation is based on API gateway and it has proven pretty difficult to incorporate  our OIDC based authentication with parallel cluster UI. Application load balancer integration with cognito solves our use case but we need to somehow make the UI backend sit on fargate as ALB cannot target api gateway. Is it possible for us to get a simple container based implementation running a server.
I am not that well versed with Cognito  OIDC and api gateway integration. Is it possible for the parallellcluster UI backend to authenticate an unauthenticated user using Cognito + OIDC provider integration ?

Hi, thank you for writing to us.
A fargate based implementation is not in our roadmap unfortunately.
We have a public ECR registry with the PCUI container (the one that gets deployed by the Cloudformation 1-click link.
Here is the link, you can use the container directly for you customization in the infrastructure.
About Cognito, when you deploy PCUI you also get a Cognito user pool. You can access the user pool from the console in the same region in which you deployed PCUI and set up a federation to an external OIDC provider of you choice. Keep in mind this is not a use case we support at the moment, but I know there's a lot of resources to help you with this.
I hope this is helpful.


first_party_set updated

first_party_set update with my primary and associate url

Hello, thank you for your submission. In addition to the  errors noted in the comment above, please remove all of your edits to the SCHEMA.json file. Those changes are unnecessary and will cause issues with the process. You only need to make changes to first_party_sets.JSON.

@Prashanttiwari-htmedia -

Rollback SCHEMA.json and don't make any changes.
Change your  primary from "https://accounts.hindustantimes.com" to "https://hindustantimes.com"
Change associatedSites from  "https://mintgenie.livemint.com" to "https://livemint.com"
Upload the "first-party-set.json" file to both https://livemint.com/.well-known/first-party-set.json and https://hindustantimes.com/.well-known/first-party-set.json, ensuring that they are accessible to the public.

Gf

Gf

All checks are passed. Please review.

@Prashanttiwari-htmedia Your changes to first_party_sets.JSON look good. Thank you for working with us to make the necessary fixes! However, this PR still makes changes to SCHEMA.json - the current changes you have made would delete the required and dependentRequired fields of the first party set schema, which would cause significant problems in our process. As such, we cannot merge this branch until all changes to SCHEMA.json have been reverted.
An easy way to do this would be to call git checkout origin/main -- SCHEMA.json on your local branch, save, then commit and push to the remote.


⚠ Hartman Foundation has degraded performance

In 532c364, Hartman Foundation (https://gordonhartman.com/) experienced degraded performance:

HTTP code: 200
Response time: 2802 ms

Resolved: Hartman Foundation performance has improved in 9105dc1.

Resolved: Hartman Foundation performance has improved in 9105dc1.


URL shortener?

Should we use a URL shortener?
http://osmcha.mapbox.com/?filters={"reasons"%3A[{"label"%3A"Large building added by new user"%2C"value"%3A47}%2C{"label"%3A"Pokemon nest feature added by new user"%2C"value"%3A50}%2C{"label"%3A"Edit to city%2Ftown place"%2C"value"%3A46}%2C{"label"%3A"Profanity tag"%2C"value"%3A45}%2C{"label"%3A"Road mapped with a polygon"%2C"value"%3A51}%2C{"label"%3A"Waterbody added by new user"%2C"value"%3A49}%2C{"label"%3A"Large feature by new user"%2C"value"%3A52}%2C{"label"%3A"Major park name changed"%2C"value"%3A48}%2C{"label"%3A"Straight segment in feature"%2C"value"%3A53}%2C{"label"%3A"Wikitags deleted"%2C"value"%3A56}%2C{"label"%3A"Primary tag added to mature feature"%2C"value"%3A58}%2C{"label"%3A"Impossible angle in a highway"%2C"value"%3A70}%2C{"label"%3A"City%2Ftown changed type"%2C"value"%3A60}%2C{"label"%3A"New city%2Ftown created"%2C"value"%3A61}%2C{"label"%3A"Name of city%2Ftown changed"%2C"value"%3A62}%2C{"label"%3A"New user deleted a mature feature"%2C"value"%3A66}%2C{"label"%3A"New user added a footway"%2C"value"%3A67}%2C{"label"%3A"Trunk%2Fmotorway deleted by new user"%2C"value"%3A69}]%2C"checked"%3A[{"label"%3A"No"%2C"value"%3A"False"}]}
cc @kepta @ajithranka @batpad

When we have the AoI implemented in the frontend, the user can save the filter and a URL to share like http://osmcha.mapbox.com/aoi/<uuid>/

will open a new ticket when we start with AoIs.
Closing this for now.
cc @geohacker @willemarcel


Ensure the search pagination details are included in response

Fixes https://github.com/OperationCode/front-end/issues/1160

Code looks good but I'm unable to access the search endpoint. I'm getting the response:
{
  "apiVersion": "1.0",
  "errors": [
    {
      "algolia-failed": {
        "message": "Failed to get resources from Algolia"
      }
    }
  ],
  "status": "Server Error",
  "status_code": 500
}

I get this same response when I switch to main branch so it looks like something is wrong on my end. I ran the following code at the start of the night:
git fetch upstream fix-search-details
git checkout fix-search-details
make run

Ah yes, you need to get an Algolia API key in order to use it, and then put those values in the .env file. Sorry, I forgot to mention that.
Let's go ahead and get it merged because the Resources page is basically down right now. We'll test in staging before we go live

I've given approval but I'm not authorized to merge the PR.


update-prod-static non-zero exit status [latest git version]

Hi,
I've been running zulip based on the latest git for months without problem. Upon trying to update to the latest version in git, however, I receive the following error message:
Done in 12.83s.
Using cached node modules from /srv/zulip-npm-cache/c1ef21a7a0b819d4183e9aa89f6d4a853bba142b/node_modules
+ ./tools/setup/emoji/build_emoji
build_emoji: Using cached emojis from /srv/zulip-emoji-cache/886611495569f0c1e7785c79028d6f5adc44d6d0/emoji
+ ./scripts/setup/inline_email_css.py
+ ./tools/setup/generate_zulip_bots_static_files.py
+ ./tools/setup/build_pygments_data
+ ./tools/setup/build_timezone_values
+ ./tools/webpack --quiet

Error running a subcommand of ./tools/update-prod-static: ./tools/webpack --quiet
Actual error output for the subcommand is just above this.

Traceback (most recent call last):
  File "/home/zulip/deployments/2021-11-11-07-53-51/scripts/lib/upgrade-zulip-stage-2", line 218, in <module>
    subprocess.check_call(["./tools/update-prod-static"], preexec_fn=su_to_zulip)
  File "/usr/lib/python3.8/subprocess.py", line 364, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['./tools/update-prod-static']' returned non-zero exit status 1.

Any ideas?
The only other warning I can see is the following - not sure if this is related:
[3/4] Linking dependencies...
warning " ><EMAIL_ADDRESS>has incorrect peer dependency<EMAIL_ADDRESS>warning "swagger-parser ><EMAIL_ADDRESS>has unmet peer dependency "openapi-types@>=7".

This is likely an OOM issue.  Try stopping the server with stop-server and then repeating.

This is likely an OOM issue. Try stopping the server with stop-server and then repeating.

This worked, thanks a million.

Isn't the RAM detection for Webpack run already implemented, that automatically stops the server? Why does this happen in latest git version?

I was actually a bit surprised that this is (supposed to be) an OOM issue. I am running Zulip on a rather powerful machine with lots of memory. Does zulip require that many GB of RAM?

Does zulip require that many GB of RAM?

It's not the issue with the Zulip runtime requiring huge RAM. It is specifically that the Webpack operation to generate the static files that is consuming lots of RAM.

Yeah, the problem is that upgrade-zulip-from-git ends up compiling Zulip webapp frontend, and Webpack (the leading JavaScript build tool) hogs a ton of memory.
How much memory does your system have @andreas-bulling?  I would have expected the logic below to stop the server for you before running update-prod-static (and thus webpack).
    # Because `upgrade-zulip-from-git` needs to build static assets, it
    # is at risk of being OOM killed on systems with limited free RAM.
    mem_bytes = os.sysconf("SC_PAGE_SIZE") * os.sysconf("SC_PHYS_PAGES")
    mem_gib = mem_bytes / (1024.0 ** 3)  # e.g. 3.74

    # Ideally, we'd have 2 thresholds here, depending on whether the
    # system is running queue workers multithreaded or multiprocess.
    # See puppet/zulip/manifests/app_frontend_base.pp for background.
    if mem_gib < 3.8:
        logging.info("Shutting down server to build static assets on a low-RAM system.")
        shutdown_server()

    # Note: The fact that this is before we apply Puppet changes means
    # that we don't support adding new Puppet dependencies of
    # update-prod-static with the Git upgrade process.  But it'll fail
    # safely; this seems like a worthwhile tradeoff to minimize downtime.
    logging.info("Building static assets...")
    subprocess.check_call(["./tools/update-prod-static"], preexec_fn=su_to_zulip)

our server has 4GB - I deemed this "lots of memory" but it seems not ;)

OK @andersk FYI -- this appears to be another instance of Webpack apparently consuming enough memory to cause failures on systems with 4GiB of RAM.  Maybe we should just change that 3.8 to 4.2?


http: proxy error: unsupported protocol scheme ""

I have my proxy settings to only use httpcache for HTTP (not HTTPS) but I get this error when things like Dropbox try to use HTTPS:
2014/11/14 11:26:11 http: proxy error: unsupported protocol scheme ""
2014/11/14 11:26:11 <IP_ADDRESS> "CONNECT //client-lb.dropbox.com:443 HTTP/1.1" (Internal Server Error) 0 ←[33;1mSKIP←[0m 0

I suspect it's because it's using // instead of specifying a scheme?  Is this something httpcache should be able to handle?

Interesting, what's seems to be happening is that your HTTP proxy is still being used for HTTPS requests, but over HTTP. What operating system are you using and how have you configured the proxies?

Windows 8, I have it set to only use the proxy for HTTP and not for local addresses

Closing, as I can't reproduce.


Trying to get comparisons working in an #each loop

For the life of me, I cannot get comparison, or if, to work inside an each loop. I'm currently trying this:
<select name="creator" id="creator" required>
	<option value=""></option>
	{{#each users as |user|}}
	<option value="{{user._id}}"
	{{#is @root.project.creator._id ../user._id}}
	selected
	{{else}}
	1<EMAIL_ADDRESS>2 {{user._id}}
	{{/is}}
	>{{this.name}} </option>
	{{/each}}
</select>

In my comparison, on the right hand side, I tried @root.user._id, user._id, and what you see above. Nothing seems to work.
By the way, I know the {{else}} branch is creating invalid HTML, but I'm just using it to try to debug.

Hmm, I would have thought that user._id would work, as you mentioned. Have you tried using {{log .}} inside or outside the loop to see what's on the context?

I added it in my else block and it outputs nothing.

If it works outside of the block, that indicates that each isn't iterating over the users variable. that isn't getting populated somehow

Oh sorry if it wasn't clear. :) The each works perfectly. The drop down shows every existing user. It is the comparison that is failing, it never matches and outputs selected where it should.

Thanks for the clarification. Hmm.. with templates it's hard to debug without having the code in front of me, but what usually helps for me is to log out every variable, in every part of the loop, starting at the top.
First, maybe try creating a custom log helper too (fwiw I've been meaning to push up changes to the existing log helper, because it logs out the handlebars options, which makes it hard to see what's happening).
Something like:
function log() {
  var args = [].slice.call(arguments);
  args.pop() // get rid of hbs options
  console.log.apply(console, args);
}

The just log out all of the variables in each step and see where the comparison is breaking down:
{{log "user" user}}
{{log "user._id" user._id}}
{{log "../user._id" ../user._id}}
{{log<EMAIL_ADDRESS>@root.project.creator._id}}
<!-- here, I think "this" would be "user" since you're inside the each block, but I'm not sure -->
{{log "this.name" this.name}}

It might be that the is helper is failing for some reason, maybe the comparison is too strict?

Would "is" be using === maybe? As it stands, I first tried comparison with ==, it didn't work either.

Here is the code for is. It is doing ===

Well in theory - both are Mongo ID values, but - I don't know. I'll keep logging and let you know (may be delayed - giving a presentation in a bit and wifi is horrible here)

Hope this isn't holding up your presentation, anything I can do to help?

Oh no - heh sorry - totally different worlds. (preso on Apache Cordova, this work is a side project)

good! yeah let me know when/if you have more detail, happy to help.

So given I'm adding all the helpers from the lib directly into my Handlebars instance, how do I append the custom log function above? Currently I've got:
var exphbs = require('express-handlebars');
var helpers = require('handlebars-helpers')();
...
app.engine('handlebars', exphbs({
defaultLayout:'main',
helpers:helpers
}));
app.set('view engine', 'handlebars');

nm - just added it to hlpers before passing it to handlebars

The log helper helped a lot. This is now working:
			{{#each users as |user|}}
			<option value="{{user._id}}"
			{{#is @root.project.creator._id ._id}}
			selected
			{{else}}
			  else  {{log .}}
			{{/is}}

Specifically: ._id. I don't quite get that. I know "dot" represents the current user in the each, but the as part should make user work too.

Great! I wonder why user isn't working as expected, though. Oh, if you're curious, try @user, see if that works.

Nope, doesn't help. I assume you meant @user._id.

Either. It's odd that @user._id doesn't work, but ._id does... Since this should be @user (at least that's my understanding). In any case, sounds like you got it resolved?

Yep. Maybe this is something that could be added to the docs? Or to a FAQ (don't know if one exists). Otherwise, just close it and thank you again!

@cfjedimaster I'd be happy to, I'm not sure this was something related to this lib. I'm still confused as to why this !== user. It seems like the context is wrong there for some reason, since doing as |user| makes user available as @user and this inside the block scope.

Someone get the answer of this? because i have the same problem!!


[vm-repair] Adding repair-and-restore one command flow for fstab scripts

This checklist is used to make sure that common guidelines for a pull request are followed.

For new extensions:

[ ] My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

vm-repair

Please add test for the new feature and fix the CI.

@yanzhudd Thanks for reviewing. I made the changes suggested.


Add zh_HK locale

Hi, thanks for the PR! I don't think Chrome Web Store supports zh_HK locale currently, but it's good for the future nontheless. Could you also translate the strings in localizedStrings.json?


Edited Battleships to be compatible with qiskit 0.5.0

This addresses Issue #155 for the battleships in the games folder.
An additional change is to spin out the exclusively classical parts into a separate .py file. This gives the notebook a focus on the quantum, and the .py can also be used for further battleships variants.

I have been doing this on and off for a while, and it seems that @abbycross did some proof-reading in that time. I have now manually implemented Abby's changes in my version. So though git still sees a conflict, I think it is effectively resolved.

@quantumjim  Thanks! Let me see if I can resolve the conflict.

It seems there were a few more changes to be made, which I did. The conflict is now resolved.

Thanks! Just a small request: can you remove the version information at the bottom of the notebook. We do not need that anymore. I am going to remove the version from all notebooks.

This notebook will no longer work due to the recent changes to the remote simulators.
No simulators (local or remote) are currently working for me, so I am not yet able to create a new working version.

@quantumjim  @atilag is fixing the remote now. He will put together an qiskit update when he is done can you let us know if there is still errors in the remote. Sorry for the inconvenience and the names should be in steady state now for the remote.
For the local what error are you getting?

It's now back to a working version, so all is well once more.
@jaygambetta My local simulator issue is the same one someone else flagged up on the slack
https://qiskit.slack.com/archives/C7SJ0PJ5A/p1526501921000448
so @atilag is on it :)


Windows Named Pipe transport implementation

Note 7015aae seems to work:
PS E:\src\github.com\kolide\osquery-go> .\query.exe \\.\\pipe\\shell.em 'select * from time'
Got results:
osquery.ExtensionPluginResponse{map[string]string{"day":"21", "minutes":"0", "weekday":"Thursday", "timezone":"UTC", "unix_time":"1506016822", "seconds":"22", "year":"2017", "hour":"18", "local_time":"1506016822", "local_timezone":"UTC", "month":"9", "timestamp":"Thu Sep 21 18:00:22 2017 UTC", "datetime":"2017-09-21T18:00:22Z", "iso_8601":"2017-09-21T18:00:22Z"}}

Whereas the attempted refactoring a948e93 does not:
PS E:\src\github.com\kolide\osquery-go> go build .\examples\query
PS E:\src\github.com\kolide\osquery-go> .\query.exe \\.\\pipe\\shell.em 'select * from time'
returning length 0
Error communicating with osqueryd: Invalid data length

The latest commit simplifies things and also gets it working again.

All examples seem to be working now, with the exception of the autoloaded extensions (example_distributed, example_logger). It is not clear to me whether this is due to an issue with extension autoloading on windows (I suspect it is), or some problem with the code here.
Example output:
PS E:\src\github.com\kolide\osquery-go> C:\ProgramData\osquery\osqueryd\osqueryd.exe --pidfile=C:\ProgramData\osquery\osqueryd.pidfile --db_path C:\ProgramData\osquery\osquery.db --config_path=C:\ProgramData\osquery\osquery.conf --logger_path=C:\ProgramData\osquery\logs --verbose --extensions_autoload=.\extensions_windows.load --disable_distributed=false --distributed_plugin=example_distributed --extensions_timeout=3 --extensions_interval=3
I0922 16:58:24.127060  7076 process_ops.cpp:181] Unable to find environment variable (0): OSQUERY_WORKER
I0922 16:58:24.128614  7076 init.cpp:392] osquery initialized [version=2.7.0]
I0922 16:58:24.129511  7076 process_ops.cpp:181] Unable to find environment variable (203): OSQUERY_WORKER
I0922 16:58:24.239887  7076 system.cpp:322] Found stale process for osqueryd (1212)
I0922 16:58:24.240885  7076 system.cpp:357] Writing osqueryd pid (5284) to C:\ProgramData\osquery\osqueryd.pidfile
I0922 16:58:24.241822  7076 process_ops.cpp:181] Unable to find environment variable (203): OSQUERY_WORKER
I0922 16:58:24.256151  7076 process_ops.cpp:181] Unable to find environment variable (203): OSQUERY_EXTENSIONS
I0922 16:58:24.344974  5016 process_ops.cpp:181] Unable to find environment variable (203): OSQUERY_EXTENSIONS
I0922 16:58:24.350349  5016 watcher.cpp:513] osqueryd watcher (5284) executing worker (6280)
I0922 16:58:24.372860  7708 init.cpp:389] osquery worker initialized [watcher=5284]
I0922 16:58:24.376664  7708 rocksdb.cpp:214] Opening RocksDB handle: C:\ProgramData\osquery\osquery.db
I0922 16:58:24.440996  6664 interface.cpp:327] Extension manager service starting: \\.\pipe\osquery.em
I0922 16:58:24.486178  7708 process_ops.cpp:181] Unable to find environment variable (203): OSQUERY_EXTENSIONS
E0922 16:58:24.488234  7708 init.cpp:568] Cannot activate example_distributed distributed plugin: Unknown registry plugin: example_distributed
I0922 16:58:24.490846  6664 interface.cpp:89] Thrift message: TPipeServer ConnectNamedPipe GLE=errno = 995
I0922 16:58:24.490846  6664 interface.cpp:89] Thrift message: TServerTransport died: TPipeServer: client connection failed

(It looks like osquery does not wait for the distributed plugin to attempt to register before declaring that it cannot be found)

I'd like to merge this despite the issues with autoloading extensions. I don't think it's worth prioritizing those issues at the moment, but I also don't want to leave this PR hanging any longer.

I think that's a good idea @zwass. Let's just update the deps to use dep and ship it.


Use right-valued reference passing for TrackedMppDataPacketPtr

What problem does this PR solve?
Issue Number: ref #6302
Problem Summary:
What is changed and how it works?
Check List
Tests

[ ] Unit test
[ ] Integration test
[ ] Manual test (add detailed scripts or steps below)
[ ] No code

Side effects

[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Documentation

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Changes MySQL compatibility

Release note

None

/run-unit-test

/merge


Basic Execution Template could be cleaned up some

The stop For Loop is way too big. Wires seem to have too many bends. The second loop uses an odd way to stop. Comments could also be cleaner.

moved to templates
https://github.com/LabVIEW-DCAF/DCAF-Project-Templates/issues/47

second loop uses an odd way to stop.
The constant wired to the stop terminal is certainly not indicative of user code, but it keeps the template simple. Users may implement their own stop mechanism for the loop or remove the loop entirely.


contacts module for building complexes of disordered proteins

Please note in the commit a4d0a3d I have removed torsions output for intermolecular contacts as sometimes torsions cannot be calculated due to broken? chains.

@joaomcteixeira Thanks for the support! I just wanted to let you know that I've found 3,799,914 intramolecular contacts where the CA atoms are <= 6 A apart and the residues are > 5 apart. While only detecting 2988 intermolecular contacts where the CA atoms are <= 12 A apart within our database of 24003 PDB IDs.
I am now working on the building algorithm but realized we need a critical function of building disordered protein between two fixed points to continue with this project. This will be helpful also in other applications. Cheers :)

Some tips:

if you need to change a function or work to tweak it too much, it is okay to copy that function to a new one, tweak the new function, and have two functions (similar) in the code.
There are many broken chains in the PDB. In IDPCG, a function cleans that by identifying a break and splitting the structure into two. The chains are cleaned when we create the torsion database to build conformers. Sometimes the break happens near the terminals, while chains are split in two in other cases. For the torsion.json db, there's no worry about splitting the chains as long as when we calculate the torsions the chain is a whole peptide.
That critical function is really critical :wink:. It is the same as modeling loop flexibility without MD. Here's a crazy idea: draw a curve between two points in space; luckily, you could achieve that with a variation of this protocol. Curves should be somehow random and have the length of your desired IDR. Then, build the IDP chain by enforcing that a residue needs to be between some distance threshold of the drawn line.

Note: I will also be working on building "long" IDPs here as I require some functions in fldrs_helper.py. The basic idea is to have a user parameter (switch) --long and (input) --custom-long that has a similar input to resptm where the user will specify what residue ranges will be built as fragments. If --custom-long is not given, we divide the sequence into chunks where the maximum length is 200 AA and the last fragment can exceed by 50 AA.

Nice!
To build very long idps I suggest calculating the energy parameters on the fly instead of precalculating them as we currently do to avoid memory issues. At least that was my experience when I made the first prototypes.
Best!

Thanks for the heads up! I noticed that SLICEDICT_XMERS and GET_ADJ took especially long too, I might split up those calculations to save time (hopefully then I don't have to worry about modifying the energy function)


Numeric parsing: ensure params array is 0-indexed with no missing keys

Due to the way explode() is used in params parsing for numeric, the $parsed['params'] array is currently 1-indexed rather than 0-indexed.
In addition, if an empty param is filtered out, it leaves a "hole" in the index sequence.
ie. :server.name 001 Phergie3 :Welcome to the network becomes:
array(
  1 => 'Welcome to the network',
)

and :server.name 005 Phergie3 CHANMODES=b,k,l,nt  TOPICLEN=30 :are supported by this server becomes:
array(
  1 => 'CHANMODES=b,k,l,nt',
  3 => 'TOPICLEN=30',
  4 => 'are supported by this server',
)

This changeset re-indexes the params array to ensure the array keys are always sequential integers beginning at 0. With it, the second example above becomes:
array(
  0 => 'CHANMODES=b,k,l,nt',
  1 => 'TOPICLEN=30',
  2 => 'are supported by this server',
)

Comments needed, as this is a breaking change for any plugin that uses a parameter at a specific index when parsing a numeric. This was also the case with #14, and at the time, the plugins known to be affected were UserMode and OpsWorksDeployment.

The 1- vs 0-index quality was partly done intentionally so that indexes would correspond to ordinal argument numbers (i.e. 1 for the first argument, 2 for the second, etc.) to make referencing them in conversation easier.
I can see how filtering empty values making the keys non-sequential would be undesirable behavior, though, and I'm fine with that aspect of this change set. I agree changing the index start bears further discussion if we're going to commit to breaking any plugins currently reliant on that behavior.

array_combine(range(1, count($params)), $params)

perhaps...

:+1:

Ready for merging.


Event Request] codeunit 1535 "Approvals Mgmt." - Event for procedure ShowApprovalComments

Can we get the following events for the "Approvals Mgmt." Codeunit: OnShowApprovalComments
    local procedure ShowApprovalComments(Variant: Variant; WorkflowStepInstanceID: Guid)
 [...]
    begin
        RecRef.GetTable(Variant);

        case RecRef.Number of
            DATABASE::"Approval Entry":
                begin
                    ApprovalEntry := Variant;
                    RecRef.Get(ApprovalEntry."Record ID to Approve");
                    ApprovalCommentLine.SetRange("Table ID", RecRef.Number);
                    ApprovalCommentLine.SetRange("Record ID to Approve", ApprovalEntry."Record ID to Approve");
                end;
            DATABASE::"Purchase Header":
                begin
                    ApprovalCommentLine.SetRange("Table ID", RecRef.Number);
                    ApprovalCommentLine.SetRange("Record ID to Approve", RecRef.RecordId);
                    FindOpenApprovalEntryForCurrUser(ApprovalEntry, RecRef.RecordId);
                end;
            DATABASE::"Sales Header":
                begin
                    ApprovalCommentLine.SetRange("Table ID", RecRef.Number);
                    ApprovalCommentLine.SetRange("Record ID to Approve", RecRef.RecordId);
                    FindOpenApprovalEntryForCurrUser(ApprovalEntry, RecRef.RecordId);
                end;
            else begin

                    OnShowApprovalComments(RecRef, Variant, ApprovalCommentLine, IsHandled); ///NEW
                    if IsHandled then begin ///NEW

                        ApprovalCommentLine.SetRange("Table ID", RecRef.Number);
                        ApprovalCommentLine.SetRange("Record ID to Approve", RecRef.RecordId);
                        FindOpenApprovalEntryForCurrUser(ApprovalEntry, RecRef.RecordId);
                    end;
                end;
 end;

   [IntegrationEvent(false, false)]
    local procedure OnShowApprovalComments(RecRef: RecordRef; Variant: Variant; var ApprovalCommentLine: Record "Approval Comment Line"; var IsHandled: Boolean)
    begin
    end;

do you mean if not IsHandled? because one would expect that if it was handled, the subscriber set some other filters.

yes absolutely right, it should be if not IsHandled

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


[Question] User entity seeding

Hi,
is there a nice way to create a seeder to the User entities?
I mean using HasData() method.
When I try to do it I keep getting error that "The seed entity for entity type 'User' cannot be added because it has the navigation set."

Hi @cookiebutcher,
In this particular solution I am just using a generic NorthwindInitializer (see https://github.com/JasonGT/NorthwindTraders/tree/master/Northwind.Persistence).
Alternatively, Check out this article to learn more about HasData() - https://msdn.microsoft.com/en-us/magazine/mt829703.aspx.
Good luck.


jquery pnotify def file for 2.x

@lgrignon thank you for your contributions.
please remove jquery.pnotify/jquery.pnotify-1.x.d.ts.

Thanks for your reply. It should be ok now.

@DavidSichau could you review this PR?

@lgrignon thanks for your contributions.
Just a small remark: please do not change the indentation, as so it is very hard to see what you have actually changed.
@vvakame This PR looks OK for me.

Everything should be ok now.

@lgrignon thanks mate!
@DavidSichau thanks!


inst-alr3c-watch-tower BAD CPU 255 on OCI console log on boot

Weird error when instance was restarting- could be redherring
message said BAD CPU 255 then booted normally. Will keep issue open in case we see it again.

this shows up on most if not all of the console logs in the OCI UI


[Bug]: auto dark mode wrong behavior

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior

When system change to light/dark mode with VS Code running, extension will notify theme changed and pop up reload dialog; but after restart, the "config is changed" dialog will pop up again with change back to opposite theme.
When system change to light/dark mode without VS Code running, extension won't prompt change to light/dark mode.

Expected Behavior
A light/dark mode check after VS Code start up will help?
Steps To Reproduce

close vscode.
change system theme.
run vscode.

Environment
- OS: win11
- VSCode: newest release
- Extension: alot
- Theme: rosepine

Anything else?
{
"vscode_vibrancy.theme":"light",
"vscode_vibrancy.preferedLightTheme":"light",
"vscode_vibrancy.preferedDarkTheme":"dark",
"window.autoDetectColorScheme":true
}

The github theme is breaking too

The solarized dark + is broken.

Same here with Catppuccin Mocha. If I set the theme again it will work until I load a new folder, reload the workspace, or restart vscode, then it breaks again.

Same

Same issue here, the only workaround is downgrading the version on install.
Waiting for a fix

Apologies all, pushed some bad code, version .31 has the fix

Nice ! Thank you for your great extension !

The Vibrancy theme setting needs to be restored to what it was before as the previous value would've been lost, unfortunately

The Vibrancy theme setting needs to be restored to what it was before as the previous value would've been lost, unfortunately

Yup. Only issue. It seems that now the window control isn't working (cannot click on the maximize button and cannot snap the window on the sides)

Yup. Only issue. It seems that now the window control isn't working (cannot click on the maximize button and cannot snap the window on the sides)

If you’re on Windows, you may be encountering this bug: https://github.com/illixion/vscode-vibrancy-continued/issues/140


Cody solomon

Description

initial bridge table creation and back-end setup

Organization
Labs25_Bridges_Jessica - Trello
Review

[x] Have you added two reviewers to this pull request?
[x] Is this a work in process?
[x] Is this ready to be reviewed?

This branch was renamed to adhere to engineering standards.


Generated label with logo cannot be read

Even if I take your sample code, it does not work...
But it does work when logo is removed...

Thank you for noticing. I updated the example so it creates a valid QR code.
FYI: you can always change parameters like the error correction level, image size or logo size to make an image more readable and use the built-in validator if you want to guarantee a certain minimum level of readability.


chaoschickzip_fe4c4626

Add content:

[UT2004 SKIN] Ily

Submission log: https://unrealarchive.org/submit/#fe4c4626

Duplicate
https://unrealarchive.org/skins/unreal-tournament-2004/C/chaoschick_912991bd.html

Despite the similar name and the same model for a skin base, they are not duplicates. The one currently available on Unreal Archive is made by _Dua1ity, skin from this upload is made by Righ Click Production. More info in the related readme files from both archives.


Using network interface names to calculate machine UUID downsides

Hello!
I am afraid that current way of calculating machine UUID using network adapter information is not really usable, at least with Windows OS. For example, after updating from Windows 10 21H1 to 21H2 my machine reports different UUID, which should not happen, doesn't it? That machine has only one hardware ethernet adapter, but Java reports total of 30 network adapters. And, by the way, for some reason non of them has virtual flag set, which means that all of them, with exception of one loopback interface, are used for UUID calculation. Few of these interfaces are Hyper-V virtual adapters (they also do not have virtual flag set (!?!)), and I can filter them out by using HardwareBinder.denied() method, but there are still 23 other interfaces used by License3j for UUID calculation. Only one of these interfaces has hardware address, I don't know what are for all of other interfaces, but that is not something specific to my computer, every Windows computer has many network interfaces not visible by user in Network settings.
In addition to hardware address, License3j uses names of all of these interfaces for MD5 hash calculation and then for UUID value. That does not seem like good approach to me, because Windows apparently changes number and/or names of these interfaces from time to time. I would use just hardware address without interface names in that calculation. I am not an expert on this subject, but I don't see it as more secure if, in addition, names are used.

I will look at it in a few days.

Any update on this?

When you call the UUIDCalculator::getMachineId method you should have a UUIDCalculator instance. To create such an instance you should pass a Network.Interface.Selector object. This is a concrete, non-final, public class that gives you a lot of possibilities to filter the interfaces. If the method usable() returns true for a specific interface, then it will be included in the calculation, otherwise not.
The implementation in the class returns false if the interface is loop-back, virtual, or PPTP and it also checks two sets of strings using the strings as regular expressions and checking the names if they are allowed or denied. You can add individual strings to either of the sets calling javax0.license3j.hardware.Network.Interface.Selector::interfaceAllowed and interfaceAllowed::interfaceDenied.
I think that this gives enough flexibility, however, using Java OO features nothing stops you to extend the class javax0.license3j.hardware.Network.Interface.Selector and implement the functionality that you desire to select certain interface cards.


Feat precommit nbstripout

This is to follow #188

[ ] Closes #xxxx
[ ] Tests and/or performance benchmarks added
[ ] User visible changes (including notable bug fixes) are documented in whats-new.rst
[ ] New functions/methods are listed in api.rst or it's sub rsts?

Codecov Report

Merging #197 (fd76837) into develop (b86e4bb) will increase coverage by 1.77%.
The diff coverage is 92.50%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@             Coverage Diff             @@
##           develop     #197      +/-   ##
===========================================
+ Coverage    77.34%   79.11%   +1.77%
===========================================
  Files           50       51       +1
  Lines         6364     6402      +38
===========================================
+ Hits          4922     5065     +143
+ Misses        1442     1337     -105

Impacted Files
Coverage Δ

pywatershed/analysis/model_graph.py
11.01% <25.00%> (+0.58%)
:arrow_up:

pywatershed/parameters/starfit_parameters.py
28.12% <40.00%> (+2.31%)
:arrow_up:

pywatershed/hydrology/starfit.py
28.57% <75.00%> (ø)

pywatershed/utils/path.py
81.81% <81.81%> (ø)

pywatershed/base/parameters.py
90.00% <86.36%> (-3.11%)
:arrow_down:

pywatershed/hydrology/prms_groundwater.py
93.90% <88.46%> (ø)

pywatershed/hydrology/prms_snow.py
90.23% <88.46%> (ø)

pywatershed/hydrology/prms_canopy.py
80.32% <89.28%> (ø)

pywatershed/hydrology/prms_runoff.py
81.71% <89.65%> (ø)

pywatershed/base/conservative_process.py
90.00% <90.00%> (ø)

... and 22 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


required attribute not being placed on input

I am using the following markup to make my select.
<ui-select ng-model="myOb.statesj" id="states" required>
    <ui-select-match placeholder="Select a state...">{{$select.selected.codeDescription}}</ui-select-match>
    <ui-select-choices repeat="item.codeId as item in constants.states | filter: $select.search">

    </ui-select-choices>
</ui-select>

Which generates the following input:
<input type="text" autocomplete="off" tabindex="-1" class="form-control ui-select-search ng-pristine ng-untouched ng-valid ng-hide" placeholder="Select an state..." ng-model="$select.search" ng-show="$select.open">

However it does not trigger a error state when nothing is selected.

How to add required in input to validate on html5 submit event?