No errors thrown while build running in the console.

Current behavior

So, I've tried to use the fork-ts-checker-webpack-plugin in my project, but it doesn't throw any error even I put them for sure.
Expected behavior

Should throw errors if they are present in .ts|.tsx files processed by babel.
Steps to reproduce the issue

Example of the error to reproduce:
![error_image]: (https://i.ibb.co/r5HKHsv/Screen-Shot-2019-07-19-at-10-52-38-AM.png)
Everything is good on output anyway:
![output_image]: (https://i.ibb.co/94c2rFY/Screen-Shot-2019-07-19-at-10-54-18-AM.png)
Environment

fork-ts-checker-webpack-plugin: 1.4.3
typescript: 3.5.3
tslint: 5.18.0
webpack: 4.16.5
os: Mojave OS/Mac

That is just webpack output, the output of fork-ts-checker-webpack-plugin would be shown AFTER that. So my best guess is that it isnÄt running ? Can you share your webpack config?

@phryneas Hi!
Here is my minimal webpack config:
const webpack = require('webpack')
const path = require('path')
const HtmlWebpackPlugin = require('html-webpack-plugin')
const UglifyJsPlugin = require('uglifyjs-webpack-plugin')
const ForkTsCheckerWebpackPlugin = require('fork-ts-checker-webpack-plugin');
const { BundleAnalyzerPlugin } = require('webpack-bundle-analyzer')
const debug = require('debug')('app:webpack:config')

const prodMode = process.env.NODE_ENV === 'production'

// ------------------------------------
// Rules
// ------------------------------------
const rules = []

// JavaScript / JSON
rules.push(
  {
    test: /\.(js|jsx|ts|tsx)?$/,
    exclude: [/node_modules|bower_components/],
    loader: 'babel-loader',
    query: {
      presets: ['@babel/react', '@babel/env', '@babel/typescript'],
      plugins: ['@babel/proposal-class-properties', '@babel/plugin-transform-object-assign', '@babel/plugin-syntax-dynamic-import']
    }
  }
)

const createConfig = options => {
  const paths = options.utils_paths
  const __DEV__ = options.globals.__DEV__
  const __PROD__ = options.globals.__PROD__
  const __TEST__ = options.globals.__TEST__

  debug('Creating configuration.')
  const webpackConfig = {
    mode: __DEV__ ? 'development' : 'production',
    entry: paths.client('main'),
    name: 'client',
    target: 'web',
    devtool: options.compiler_devtool,
    optimization: {
      splitChunks: {
        chunks: 'all',
        minChunks: 2
      },
      minimizer: [
        new UglifyJsPlugin({
          uglifyOptions: {
            compress: {
              unused: true,
              dead_code: true,
              warnings: false
            }
          },
          sourceMap: true
        }),
        new OptimizeCSSAssetsPlugin({})
      ]
    },
    performance: {
      hints: false
    },
    resolve: {
      modules: [paths.client(), 'node_modules'],
      extensions: ['.ts', '.tsx', '.js', '.jsx', '.json']
    },
    module: {}
  }

  // ------------------------------------
  // Entry Points
  // ------------------------------------
  // recommneded by babel to use instead of babel-polifill
  const appEnterPrefixPlugins = [path.resolve(__dirname, '../node_modules/core-js/stable'), path.resolve(__dirname, '../node_modules/regenerator-runtime/runtime')];
  const appPath = paths.client('main')
  const appEntryPoint = [...appEnterPrefixPlugins, appPath];

  webpackConfig.entry = {
    app: __DEV__ ? appEntryPoint.concat(`webpack-hot-middleware/client?path=${options.compiler_public_path}__webpack_hmr`) : appEntryPoint
  };

  // ------------------------------------
  // Bundle externals
  // ------------------------------------
  webpackConfig.externals = {
    react: 'React',
    'react-dom': 'ReactDOM'
  }

  // ------------------------------------
  // Bundle Output
  // ------------------------------------
  webpackConfig.output = {
    filename: '[name].[hash].js',
    path: paths.dist(),
    publicPath: options.compiler_public_path
  }

  // ------------------------------------
  // Plugins
  // ------------------------------------
  webpackConfig.plugins = [
    new webpack.DefinePlugin(options.globals)
  ]

  if (__TEST__) {
    debug('Enable plugins for live testing (HMR, NoErrors).')
    webpackConfig.plugins.push(new BundleAnalyzerPlugin())
  } else if (__DEV__) {
    debug('Enable plugins for live development (HMR, NoErrors).')
    webpackConfig.plugins.push(
      new HtmlWebpackPlugin({
        template: paths.client('index.html'),
        filename: 'index.html',
        inject: 'body',
        minify: {
          collapseWhitespace: true
        },
        chunksSortMode: 'auto'
      }),
      new webpack.HotModuleReplacementPlugin(),
      new webpack.NoEmitOnErrorsPlugin(),
      new ForkTsCheckerWebpackPlugin({
        tsconfig: '../../tsconfig.json',
        tslint: '../../tslint.json'
      })
    )
  } else if (__PROD__) {
    debug('Enable plugins for production')
    webpackConfig.plugins.push(
      new HtmlWebpackPlugin({
        template: paths.client(options.template),
        filename: options.template,
        minify: false,
        inject: false,
        chunksSortMode: 'auto'
      })
    )
  }

  webpackConfig.module.rules = rules

  return webpackConfig
}

module.exports.rules = rules

module.exports = createConfig

@phryneas > would be shown AFTER that
The problem here is that it doesn't show any output after build at all.

@phryneas > would be shown AFTER that
The problem here is that it doesn't show any output after build at all.

Hmm.
Could you make sure that you are running from the __DEV__ mode and also please pass absolute paths to the plugin options instead of relative paths? That might help narrow it down a bit.

I'm having a similar issue, but i am still investigating to provide better input. However, here is my observation so far.
We are using ts-loader along with fork-ts-checker-webpack-plugin.
After introducing a compilation error, the error is not detected in a development mode but it it is detected in the production mode. The error output is missing in the development mode.
I suspect that in development mode the compilation on the main process is finishing faster than the type checker can do his work. The compilation is successfull, because in our case we use ts-loader with transpileOnly set to true.
Now in production mode webpack has a heavier load during compilation and so it probably takes longer and the type checker has a chance to complete his job and report the errors.
It's still just a quick guess deduced from a recent observation.  Maybe someone can confirm or disproof my suspicion.

without a reliable repro it's hard to help.  I suggest you take this setup here: https://github.com/TypeStrong/ts-loader/tree/master/examples/fork-ts-checker-webpack-plugin and try to reproduce the issue.

i understand but can not reproduce it in a small setup so far and can not share the current project. Our setup involves

thread-loader
ts-loader with happyPackMode: true (which sets implies transpileOnly: true)
and then ForkTsCheckerWebpackPlugin

However if i remove the thread-loader i get the output back again. According to @johnnyreilly  post it seems to not being needed since Webpack 4. So we leave it out for now.
I checked our CI history and compared the commits where the behaviour occured the first time. Noticeable dependency changes were

added<EMAIL_ADDRESS>added<EMAIL_ADDRESS>upgrade webpack 4.29.5 -> 4.32.2

But<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>did not receive any upgrade. Downgrading webpack did not fix the misbehaviour. So i checked changes in webpack config
Our old webpack config was exported as an object
module.exports = {
  // ...
}

the new config is exported as an array for parallel builds
module.exports = [{
  // ... monaco-editor web worker bundle
}, {
  // ... application bundle
}]

switching back to a single object export (just removing the monaco bundle) fixes the misbehaviour and the stats output and error log is back again.
As i said, i can not reproduce it in a small project. Tried to mimic the setup in https://github.com/TypeStrong/ts-loader/tree/master/examples/fork-ts-checker-webpack-plugin but had no lick so far.

In my case, I can't see plugin output on the first run, because console is cleared. So I see only build result, like "Ok. Ready at: localhost:8080" but errors go before this printing. So I can see them later when I change some files and rebuild triggered...

Also seeing this behavior. We recently cleaned up a ton of tslint warnings and I suspect the forked process is finished BEFORE the webpack process and the last process is winning the display.

Same issue.
Can fork-ts-checker-webpack-plugin be used with babel-loader. I don't use ts-loader.

Can fork-ts-checker-webpack-plugin be used with babel-loader? I don't use ts-loader.

It can - I'm using it with babel-loader.
Can you provide a reproducible?

My issue looks the same as @giniedp
I'm running an ejected create react app, and I found the issue is that react-dev-utils has a bunch of stuff that swallows this up. Specifically, in the start script, WebpackDevServerUtils.createCompiler has a useTypeScript option, which I had omitted because I previously used a different method of compiling TS. However, I can't just enable that because it uses its own, old version of this plugin, so it'll be tapping something that will never be emitted.
I haven't figured out exactly how to handle this. I'll see if any of the newer versions are more permissive in not swallowing errors. If that doesn't work, I'll either fork it, or I'll just remove it completely and use const compiler = webpack(config). It won't have all the pretty stuff, but I'm not sure how much I care.
Not sure if the issue is actually the same, but if you're running a custom build script you might want to  look into this.

@BiosBoy , @giniedp , @maksnester ,  @cmoad , @azizhk , @bfricka
Please try fork-ts-checker-webpack-plugin@alpha - I've published a new version which should resolve this issue 🚀
I will close this issue to clean-up the backlog. If this release didn't solve the issue, we can re-open this :)

I had the same problem when using version 5.0.1.
Then I changed the version to 1.0.0-alpha.10.It works fine.

The same error when using version 5.0.1.
It works fine when returning to version 4.1.6.

Having the same issue, running ts-loader and<EMAIL_ADDRESS>Seems to completely ignore it at all (output from speed measure);

ForkTsCheckerWebpackPlugin took 0 secs

I am having a similar issue. @Aaron-Bird I can confirm that downgrading to version 4.x works. Did you solve your problem? I am a bit stuck and trying to understand what is happening in version 5.x so that it does not break the build command.

Are people experiencing this issue using webpack 5?  I wonder if this is a common issue with webpack 5; there's something related logged against ts-loader: https://github.com/TypeStrong/ts-loader/issues/1204

I dived into changelogs to see what has happened between 4.x and 5.x and I found out, at least it started working in my case.
new ForkTsCheckerWebpackPlugin({
      issue: {
        scope: 'all',
      },
    }),

What is the most interesting I also checked version 6 alpha and they say that the issue.scope has been removed at all.
To summarize:
For 4.x:
new ForkTsCheckerWebpackPlugin()

For 5.x:
new ForkTsCheckerWebpackPlugin({
      issue: {
        scope: 'all',
      },
    }),

For 6.x:
new ForkTsCheckerWebpackPlugin()

I'm closing this as it's no longer an issue with the 6.0.0 version :)

Just adding this in case anyone comes across this like I did.
ForkTsCheckerWebpackPlugin won't work nicely with an output with speed-measure-webpack-plugin. For me to get the output showing up again I had to remove SMP or use it conditionally.

Just adding this in case anyone comes across this like I did.
ForkTsCheckerWebpackPlugin won't work nicely with an output with speed-measure-webpack-plugin. For me to get the output showing up again I had to remove SMP or use it conditionally.

Yeah, I just set async: false to the plugin, does the job:
new ForkTsCheckerWebpackPlugin({
  async: false,
}),


[UI] UI improvements in Exercise create/edit page

Checklist

[x] I tested all changes and all related features with different users (student, tutor, editor, instructor, admin) on the test server https://artemistest.ase.in.tum.de.
[x] Client: I added multiple screenshots/screencasts of my UI changes

Motivation and Context
improve the create/edit page for each exercise type, by making ui elements consistent and more obvious to the user
Description
For text/modelling/quiz/programming/ file upload exercise

Add space between different form group elements.
Increase the font and make it bold for headers of a section
Fix alignment for programming exercise.

Steps for Testing

Log in to Artemis
Navigate to Course Administration
Navigate to any of exercises.
Create/Edit any type of exercise.

Screenshots

Before

After

I have addressed the Codacy issues @krusche. The problem is that Codacy doesn't allow us to set styling to custom html-tags, however, the code was still working as expected.
One option as discussed with @MDK5 is to supply the custom config, that will filter out this check, however this seems like an another task on its own, which needs to be discussed and scheduled, therefore I applied another approach of using custom classes for the elements to avoid Codacy complains.

I found one more thing, that should be changed on the edit/create page:
the tooltip for the title is not completely visible, It should have the placement "right" or maybe "auto".

Also, but that is a matter of taste, the checkboxes for programming exercises could have less padding in between, this way, it does not look like as list of options you could check or not check. But that is discussable 😄

Thank you for the suggestions @lschlesinger
I incorporated both of them 👼


switch Facebook proofs to the desktop site

// Previously we would parse markup to extract the username and proof text.
// We had to switch to the desktop site to validate the usernames of people
// with the "no search engine scraping" Facebook privacy setting turned on.
// That in turn made it much harder to parse the markup we get, because
// what we want comes down in an embedded comment. However, because the
// desktop site (unlike the m-site) does not display comments or ads to
// logged-out users, we can do a simple string match on the whole page to
// find the proof text. We can't pull the author's username out of the
// page, but the desktop site (again, unlike the m-site) will not display a
// post of the author's username in the URL is wrong. It's possible there's
// some way I haven't thought of for other users to inject strings
// somewhere in this page, or break that URL->author relationship, and if
// so we'll need to change it.

r? @maxtaco

also r? @mlsteele


Solving the issue #125 and #135 ...

Everything Works Fine.
@Ijaiswalshivam
Please add the levels to the issues.

Export the Chat List Activity code to Chat Fragment.
Export User Profile(Logout feature) code to Profile Fragment.
Connect the Recycler view Properly.
@Qomfortzone are all the mentioned issues are fixed?

@Ijaiswalshivam
Yes Everything is fixed correctly


Design user structure and create appropriate schema.

Created schema for document with the following fields:

username
full_name
email
password
user_type
created_at


Type error with 'message' property

Describe the bug
When useQuery calls a function that throws an error, typescript refuses to let me write error: error.message to format my returned object.
To Reproduce
const search = async (id: string) => {
  try {
    const res = await api.post("/search/", id);
    return res.data;
  } catch (err) {
    throw new Error("error.search");
  }
};

const searchUser: UserService["searchUser"] = (id) => {
  const { data, error, isLoading } = useQuery(
    ["search", id],
    () => search(id),
    { enabled: false }
  );
  return {
    user: data && data.data,
    error: error.message, // typescript claims: Property 'message' does not exist on type 'unknown'
    loading: isLoading,
  };
};

Expected behavior
Being able to write error.message in order to return a specific error message while keeping typescript happy.
Desktop (please complete the following information):

OS: iOS]
Browser: chrome
Version: 22

since you can throw anything in JavaScript, even (e.g. throw 5) and react-query is agnostic about how you fetch your data, we cannot assume anything about the Error type. So it just defaults to unknown. You can do two things:

provide generics to useQuery:

useQuery<MyResultData, Error>(key, queryFn)

make a runtime check with instanceof that will narrow the type:

const { error } = useQuery(key, queryFn)
if (error instanceof Error) {
  error.message
}

I have used both ways in the past. With axios, I want to specify that I get an AxiosError anyways (which is a subclass of Error I think), so I use the first way to type useQuery. If I'm only interested in the "generic" error.message, I go for the instanceof check, because I need a check anyways (e.g. if (error) or if (status === 'error')), so I can just as well narrow the type with instanceof.

since you can throw anything in JavaScript, even (e.g. throw 5) and react-query is agnostic about how you fetch your data, we cannot assume anything about the Error type. So it just defaults to unknown. You can do two things:

provide generics to useQuery:

useQuery<MyResultData, Error>(key, queryFn)

make a runtime check with instanceof that will narrow the type:

const { error } = useQuery(key, queryFn)
if (error instanceof Error) {
  error.message
}

I have used both ways in the past. With axios, I want to specify that I get an AxiosError anyways (which is a subclass of Error I think), so I use the first way to type useQuery. If I'm only interested in the "generic" error.message, I go for the instanceof check, because I need a check anyways (e.g. if (error) or if (status === 'error')), so I can just as well narrow the type with instanceof.

I think this also describes it very well: https://stackoverflow.com/questions/45379959/narrowing-down-error-type-in-catch

I think this also describes it very well: https://stackoverflow.com/questions/45379959/narrowing-down-error-type-in-catch

Can I provide generics to global queries onError?
import { QueryClient, QueryClientProvider } from 'react-query';

const queryClient = new QueryClient({
  defaultOptions: {
    queries: {
      retry: false,
      onError: (err) => {
        console.log('global query onError', err.message); // Object is of type 'unknown'.
      }
    }
  }
});

Can I provide generics to global queries onError?
import { QueryClient, QueryClientProvider } from 'react-query';

const queryClient = new QueryClient({
  defaultOptions: {
    queries: {
      retry: false,
      onError: (err) => {
        console.log('global query onError', err.message); // Object is of type 'unknown'.
      }
    }
  }
});


Multi-gpu training?

Thank you for your work! And do your code support multi-gpu training?

Hi, I'm sorry that the current code is modified from Meta R-CNN, which does not support multi-gpu training.

Thank you for your reply~


chore(deps): allow WEKAPP tickets in lint

TL;DR
This change introduces an additional scope 'WEKAPP-\d+' to the PR title linting configuration in our GitHub workflow. This ensures that PR titles can include the WEKAPP identifier.
What changed?

Updated the lint_pr.yaml file to recognize and accept 'WEKAPP-\d+' as a valid scope in PR titles.

How to test?

Create a PR with 'WEKAPP-xxx' in the title and verify that the linting workflow does not flag it as invalid.

Why make this change?
This update is necessary to allow PRs that include WEKAPP identifiers in their title, facilitating better tracking and categorization of tasks related to the WEKAPP project.

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#291
#290  👈
#289
#288
#287
#286
#278
dev

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @sergeyberezansky and the rest of your teammates on  Graphite

Merge activity

Jul 31, 6:51 AM EDT: @sergeyberezansky started a stack merge that includes this pull request via Graphite.


Connection timed out

Command:
rdcp  -v source ip_addr:dest

Hi, thanks for the report! This can be that either the ssh control channel failed or the port used for RDMA file transfer was inaccessible, or that the two hosts can't talk via RDMA (test with e.g. ibv_rc_pingpong).
The RDMA connection happens on a random port in the 10000-19999 range, see https://github.com/kig/rdma-pipe/blob/master/rdcp#L90 - you can set that to a fixed port to work around it (but then you can run only one send at a time.)
You can test the connectivity by running rdrecv <port> <password> <target_filename> on the receiver, and rdsend <target_host> <port> <password> <source_filename> on the sender.
(This is what rdcp does, fwiw):
$ssh $ssh_flags $target_host rdrecv $verbose $port "$password" "$target_filename" &
$ssh $ssh_flags $source_host rdsend $verbose $rdma_target_host $port "$password" \< "$source_filename" &


Request to add manhwareader.com

Request to add a site

Description
Other site for manhwa or webtoons

Url to add
https://manhwareader.com/

I close it.
If you have any difficulties, do not hesitate to create a new issue.

Seems to redirect to https://hentaihand.com/

Seems to redirect to https://hentaihand.com/

Oh. A couple of days ago it worked as it should :-(

I am closing this issue.
If you still have questions, open a new one.
Thank )


Document problem summary html in user guide

I added a temporary section in: https://github.com/gradle/gradle/pull/31665


⚠ Bofrost.nl has degraded performance

In 1cc24ee, Bofrost.nl (https://www.bofrost.nl) experienced degraded performance:

HTTP code: 200
Response time: 984 ms

Resolved: Bofrost.nl performance has improved in c260a80.


Gather metrics for QoS

As a QoS backend developer I need standard data to be delivered for reporting purposes. As a Pillarbox developer I need to gather such data on device first so that I can send them later to the backend.
Acceptance criteria

Session, error and event information is extracted.
For each trivial values are extracted, otherwise dedicated implementation tasks have been created.
No need to have the data sent to the backend yet.

Hints
Format is discussed elsewhere.
Tasks

[ ] ...

videojs already provides an API for that. Just have a look at a possible presentation.


docs: websocket documentation

Issue Number: #480
Body

Summary by CodeRabbit

New Features

Added documentation on using Smart NgRX with WebSockets, including handling updates, creations, and deletions of records.

Enhancements

Updated the category assignment for the demo walkthrough documentation.
Renamed the constant CreatePage to ExistingSelectorsPage in the existing selectors documentation.

Chores

Upgraded package manager version from<EMAIL_ADDRESS>to<EMAIL_ADDRESS>

This is an experiment review for experiment mermaid_diagrams
Run ID: mermaid_diagrams/run_2024-09-20T10-59-17_v1-22-0-133-gbcf338da5-dirty
The benchmark review for this pull request can be found at https://github.com/sourcery-ai-experiments/SmartNgRX/pull/2.
This pull request was cloned from https://github.com/DaveMBush/SmartNgRX/pull/481. (Note: the URL is not a link to avoid triggering a notification on the original pull request.)

Experiment configuration
review_config:
  # User configuration for the review
  # - benchmark - use the user config from the benchmark reviews
  # - <value> - use the value directly
  user_review_config:
    enable_ai_review: true
    enable_rule_comments: false

    enable_complexity_comments: false
    enable_security_comments: false
    enable_tests_comments: false
    enable_comment_suggestions: false
    enable_functionality_review: false

    enable_pull_request_summary: false
    enable_review_guide: true

    enable_approvals: false

  ai_review_config:
    # The model responses to use for the experiment
    # - benchmark - use the model responses from the benchmark reviews
    # - llm - call the language model to generate responses
    model_responses:
      comments_model: benchmark
      comment_area_model: benchmark
      comment_validation_model: benchmark
      comment_suggestion_model: benchmark
      complexity_model: benchmark
      functionality_model: benchmark
      security_model: benchmark
      tests_model: benchmark
      pull_request_summary_model: benchmark
      review_guide_model: llm
      overall_comments_model: benchmark

# The pull request dataset to run the experiment on
pull_request_dataset:
- https://github.com/sourcery-ai/core/pull/4607
- https://github.com/sourcery-ai/core/pull/4631
- https://github.com/sourcery-ai/core/pull/4647
    # CodeRabbit examples:
- https://github.com/2lambda123/-Orange-OpenSource-oorobot/pull/15
- https://github.com/2lambda123/galaxyproject-galaxy/pull/12
- https://github.com/a0v0/avtoolz/pull/79
- https://github.com/adityask98/Hotaru/pull/10
- https://github.com/agdas/vscode/pull/2
- https://github.com/agluszak/hirschgarten/pull/2
- https://github.com/alexsnow348/insightface/pull/46
- https://github.com/alikuxac/utilities/pull/10
- https://github.com/AlphaDev87/timba-api/pull/49
- https://github.com/AngeloTadeucci/Maple2/pull/239
- https://github.com/AngeloTadeucci/Maple2.File/pull/36
- https://github.com/AngeloTadeucci/Maple2/pull/233
  # Examples where CodeRabbit does not generate diagrams
- https://github.com/baptisteArno/typebot.io/pull/1778
- https://github.com/btipling/foundations/pull/33
- https://github.com/btipling/foundations/pull/31
- https://github.com/chintu-777/jaeger/pull/1
- https://github.com/coji/remix-docs-ja/pull/55
- https://github.com/DaveMBush/SmartNgRX/pull/622
- https://github.com/DaveMBush/SmartNgRX/pull/481
- https://github.com/dkittle/party-connections/pull/6
- https://github.com/Drajad-Kusuma-Adi/onstudy-backend/pull/6
- https://github.com/imaami/libcanth/pull/2

# Questions to ask to label the review comments
review_comment_labels: []
# - label: correct
#   question: Is this comment correct?

# Benchmark reviews generated by running
#   python -m scripts.experiment benchmark <experiment_name>
benchmark_reviews:
- dataset_pull_request: https://github.com/sourcery-ai/core/pull/4607
  review_pull_request: https://github.com/sourcery-ai-experiments/core/pull/338
- dataset_pull_request: https://github.com/sourcery-ai/core/pull/4631
  review_pull_request: https://github.com/sourcery-ai-experiments/core/pull/339
- dataset_pull_request: https://github.com/sourcery-ai/core/pull/4647
  review_pull_request: https://github.com/sourcery-ai-experiments/core/pull/340
- dataset_pull_request: https://github.com/2lambda123/-Orange-OpenSource-oorobot/pull/15
  review_pull_request: https://github.com/sourcery-ai-experiments/-Orange-OpenSource-oorobot/pull/2
- dataset_pull_request: https://github.com/2lambda123/galaxyproject-galaxy/pull/12
  review_pull_request: https://github.com/sourcery-ai-experiments/galaxyproject-galaxy/pull/1
- dataset_pull_request: https://github.com/adityask98/Hotaru/pull/10
  review_pull_request: https://github.com/sourcery-ai-experiments/Hotaru/pull/2
- dataset_pull_request: https://github.com/agdas/vscode/pull/2
  review_pull_request: https://github.com/sourcery-ai-experiments/vscode/pull/3
- dataset_pull_request: https://github.com/agluszak/hirschgarten/pull/2
  review_pull_request: https://github.com/sourcery-ai-experiments/hirschgarten/pull/2
- dataset_pull_request: https://github.com/alikuxac/utilities/pull/10
  review_pull_request: https://github.com/sourcery-ai-experiments/utilities/pull/2
- dataset_pull_request: https://github.com/AlphaDev87/timba-api/pull/49
  review_pull_request: https://github.com/sourcery-ai-experiments/timba-api/pull/2
- dataset_pull_request: https://github.com/AngeloTadeucci/Maple2/pull/239
  review_pull_request: https://github.com/sourcery-ai-experiments/Maple2/pull/3
- dataset_pull_request: https://github.com/AngeloTadeucci/Maple2.File/pull/36
  review_pull_request: https://github.com/sourcery-ai-experiments/Maple2.File/pull/2
- dataset_pull_request: https://github.com/AngeloTadeucci/Maple2/pull/233
  review_pull_request: https://github.com/sourcery-ai-experiments/Maple2/pull/4
- dataset_pull_request: https://github.com/baptisteArno/typebot.io/pull/1778
  review_pull_request: https://github.com/sourcery-ai-experiments/typebot.io/pull/1
- dataset_pull_request: https://github.com/btipling/foundations/pull/33
  review_pull_request: https://github.com/sourcery-ai-experiments/foundations/pull/1
- dataset_pull_request: https://github.com/btipling/foundations/pull/31
  review_pull_request: https://github.com/sourcery-ai-experiments/foundations/pull/2
- dataset_pull_request: https://github.com/chintu-777/jaeger/pull/1
  review_pull_request: https://github.com/sourcery-ai-experiments/jaeger/pull/1
- dataset_pull_request: https://github.com/coji/remix-docs-ja/pull/55
  review_pull_request: https://github.com/sourcery-ai-experiments/remix-docs-ja/pull/1
- dataset_pull_request: https://github.com/DaveMBush/SmartNgRX/pull/622
  review_pull_request: https://github.com/sourcery-ai-experiments/SmartNgRX/pull/1
- dataset_pull_request: https://github.com/DaveMBush/SmartNgRX/pull/481
  review_pull_request: https://github.com/sourcery-ai-experiments/SmartNgRX/pull/2
- dataset_pull_request: https://github.com/dkittle/party-connections/pull/6
  review_pull_request: https://github.com/sourcery-ai-experiments/party-connections/pull/1
- dataset_pull_request: https://github.com/Drajad-Kusuma-Adi/onstudy-backend/pull/6
  review_pull_request: https://github.com/sourcery-ai-experiments/onstudy-backend/pull/1
- dataset_pull_request: https://github.com/imaami/libcanth/pull/2
  review_pull_request: https://github.com/sourcery-ai-experiments/libcanth/pull/1


Simple way to get bot to realize a message starts with someone mentioning the bot?

message.content.StartsWith("BotName") doesn't work, what's the easiest way to do this?

Discord.Commands has an extension method on IUserMessage called HasMentionPrefix().

Thanks, I will try over there and see if I can't get something working using your tip.


Dockerize PhantomJS to allow running tests from the teaspoon CLI

We have these lines from the .travis.yml:
 - mkdir travis-phantomjs
 - wget https://studentinsights-public.s3.amazonaws.com/phantomjs-2.1.1-linux-x86_64.tar.bz2 -O $PWD/travis-phantomjs/phantomjs-2.1.1-linux-x86_64.tar.bz2
 - tar -xvf $PWD/travis-phantomjs/phantomjs-2.1.1-linux-x86_64.tar.bz2 -C $PWD/travis-phantomjs
 - export PATH=$PWD/travis-phantomjs/phantomjs-2.1.1-linux-x86_64/bin:$PATH

and it would be nice if they were included in the Docker image somehow. (Put it in /bin?)

Ok, turns out that teaspoon runs fine when you're connected to the network. I was having weird Docker issues that were stopping it from accessing the network.
There would still be an advantage to doing this if we ever want to have Travis pull down our Docker image. But that is not very immediate.

Reopening because phantomjs unreliable downloading just made me upset again.


test all functions in cee-json

We will use cee-json more, it's important to write test cases to test all functions of cee-json.   We also need to get the test coverage report for our tests.

one way to test:

parse a json file in the JSON test suite
print out this json as a string
parse this string
print out the second json as the second string
the first string should be the same as the second string

We need to specially test the handling of utf8 encoding correctly.

I have looked at the implementation, cee_json_snprint didn't handle escaping correctly.   We can borrow the code for json_inject for this.

The following code does not work. It should, but not.
struct cee_list *l =  cee_list_mk (s, 0);
l = cee_list_append (l, e);

Please update with ETA

For this one, we need to test memory leak.

cee_json_object_set(st, result, "error", j1);
cee_json_object_set(st, result, "error", j2);  // this should overwrite j1, but it does not.

cee_json_object_set(st, result, "error", j1);
cee_json_object_set(st, result, "error", j2);  // this should overwrite j1, but it does not.

Can you please fix this one?  It's a logic bug in cee_json.

Ok, not sure what that function does but I'll see what I can do.

Ok, not sure what that function does but I'll see what I can do. Is it a cee_map bug?

I found the problem, I will fix this one.

Ok, not sure what that function does but I'll see what I can do. Is it a cee_map bug?

I found the problem, I will fix this one.
I have fixed this bug.


Does NetMF work with directed networks? If not, why?

ATT.

NetMF does not work with directed graph.
The main reason is that the assumption of unidrected graph is required in our proof. For example, if the graph is a directed one, it does not necessarily have a well-defined stationary distribution.


sass import issue

Wont build for me with googlefonts import.

hi @henriklundgren I think this bug is related to some dependency on our package dependency tree, trying to figure out right now

hi @henriklundgren it should be fixed now (c40508058433ba9a91a786fa7ac3c8779fcbbd1d)


UX to create entitity for a simulation

e.g. a person, family, titled_property.
This belongs to a user
child of #4

Implemented.
Needs more user friendly descriptions on the entities.
http://www.rules.nz/entities


Dates with time strings do not work properly

Originally reported by @alexandru-m-g in HXLStandard/hxl-proxy#244: demo link
This tries to use dates with non-ISO time strings attached (SQL database style), e.g. "2017-12-01 00:00:00" — may need to add special handling for those.
The problem is manifesting itself with the count filter, but may appear in all date handling.

With a date in the format YYYY-MM-DD hh:mm:ss, the Python date parser was reversing the month and day through some bizarre locale handling. Added SQL datetime as a special case in hxl.datatypes.normalise_date()
Testing OK for the change in the function. Will now test that the max() aggregation also works properly.

Deployed and tested in beta Proxy.
Confirmation link: https://beta.proxy.hxlstandard.org/data/edit?filter01=cut&cut-include-tags01=%23date%2Bstart-activity&filter02=count&count-type02-01=max&count-pattern02-01=%23date%2Bstart&count-header02-01=Count&count-column02-01=%23meta%2Bcount&url=https%3A%2F%2Fdocs.google.com%2Fspreadsheets%2Fd%2F1jvH0NwVnmasa_W7FeCe82Ygs-rEdn3sYev7222IB908%2Fedit%23gid%3D0


nix: bootstrap is broken

When trying to bootstrap F* using Nix, .#fstar-ocaml-snapshot fails to build, throwing the following error:
* Error 54 at /nix/store/4skgqa9fayjbaw5fklzp2prj5q27nag6-fstar-0806a005a879f256ff5af6736fbea4d45ea6f6ca/lib/fstar/prims.fst(477,30-477,31):
  - a is not equal to the expected type b
  - See also /nix/store/4skgqa9fayjbaw5fklzp2prj5q27nag6-fstar-0806a005a879f256ff5af6736fbea4d45ea6f6ca/lib/fstar/prims.fst(477,14-477,15)

Hi @pnmadelaine. This error happens if F* tries to check prims.fst in --MLish --lax mode: prims contains heterogeneous equality which is not properly typed in a simply typed system (which is roughly what MLish implements). Our makefiles currently make sure to not pass --MLish to any file in ulib, and only use it on compiler files, at least they should : ).
I'm not very familiar with Nix yet : ). Do you know where the F* call is coming from? Is Nix calling into the Makefiles?


Error while scanning gradle project using frogbot GitHub Reusable workflow 'panic: runtime error: invalid memory address or nil pointer dereference   [signal SIGSEGV: segmentation violation code=0x1 addr=0x18 pc=0xdcf2fd]'

Frogbot_errors.docx

@Rushekesh,
According to the documentation, Frogbot supports scanning pull requests for Gradle projects, but Repositories Scanning isn't yet supported for Gradle. This is a feature that's planned to be introduced during the next few weeks.
Frogbot's current behavior of throwing a panic when configured to scan a repository for a Gradle project should be fixed and replaced with a clear error message.

Hi @Rushekesh, Frogbot v2.11.0 has been released, and it will now throw an informative error instead of a panic. Thank you for reporting this issue.


OntoTrace query excludes search term when including parts

Simple input query with "include parts" selected doesn't return the search term. apparently this is due to 'part of' relation becoming non-reflexive recently.

RPhenoscape also returns incomplete results (e.g.,  query for entity: pelvic fin, taxon Teleostei including parts doesn't return pelvic fin in matrix). Should this be posted to kb-services instead?


language server fails to process empty types

we have the following type as we use type extensions for stitched scenarios:
type EmptyType @source(name: "EmptyType", schema: "local") {
}

the language server fails to process this:
Schema.graphql:1352:1
1351 |
1352 | }
     | ^
1353 |

thanks for reporting it here! so what you’re saying is that the LSP server crashes when you’re defining an object type with directives? is the file specified in graphql config schema entry?

thanks for reporting it here! so what you’re saying is that the LSP server crashes when you’re defining an object type with directives? is the file specified in graphql config schema entry?

the directive doesn't matter. but it looks like it's spec compliant to not allow empty types (types without fields)
https://github.com/graphql/graphql-spec/issues/568

the directive doesn't matter. but it looks like it's spec compliant to not allow empty types (types without fields)
https://github.com/graphql/graphql-spec/issues/568

yes I'm aware, this is why graphql-js fails to parse the schema file, however two things:

short term: we could have better error handling - in vscode we trap these exceptions, but for your language server implementation, is this a problem? I really need to work with the LSP outside of vscode and the browser more often!
mid term: we are working on improving the streaming parser to eventually build an entire GraphQLSchema for SDL validation, so it should be able to just skip over this type when building completion/validation/etc

yes I'm aware, this is why graphql-js fails to parse the schema file, however two things:

short term: we could have better error handling - in vscode we trap these exceptions, but for your language server implementation, is this a problem? I really need to work with the LSP outside of vscode and the browser more often!
mid term: we are working on improving the streaming parser to eventually build an entire GraphQLSchema for SDL validation, so it should be able to just skip over this type when building completion/validation/etc

I'm wrong, this shouldn't be happening, there was unnecessary graphql parse() added to getAutocompleteSuggestions which actually uses our own graphql-language-service-parser, which doesn't have these kinds of issues. this bug should be fixed now


Bug report Bizarre dataviewjs behavior with async code

What happened?
I was trying to get a file's contents within a dataview JS block but noticed some odd behavior. When trying to read the file asynchronously, the DVJS query resolves with the error below. This only happens when using await, but I was able to get around it using Promise.then(). See the JS for the version that works and the one that doesn't. Note that I tried using both dv.io.load() and app.vault.read()
Evaluation Error: SyntaxError: Unexpected end of input
    at DataviewInlineApi.eval (plugin:dataview:19667:21)
    at evalInContext (plugin:dataview:19668:7)
    at asyncEvalInContext (plugin:dataview:19675:16)
    at DataviewJSRenderer.render (plugin:dataview:19699:19)
    at DataviewJSRenderer.onload (plugin:dataview:19283:14)
    at DataviewJSRenderer.e.load (app://obsidian.md/app.js:1:730611)
    at t.e.addChild (app://obsidian.md/app.js:1:731035)
    at t.addChild (app://obsidian.md/app.js:1:1646061)
    at Object.addChild (app://obsidian.md/app.js:1:1645086)
    at DataviewApi.executeJs (plugin:dataview:20208:19)

DQL
No response
JS
const page = dv.pages('"pathToNote"')[0]
// THIS WORKS
dv.io.load(page.file.path).then(content => {
	console.log(content)
        ...
})
// THIS DOES NOT WORK
let content = await dv.io.load(page.file.path)

Dataview Version
0.5.42
Obsidian Version
0.15.9
OS
MacOS

Both variants seem to work when I replicate this locally - that error appears to be caused by a syntax error. Is there more to your query block?

Try the command standalone in the console to check as well.

Unfortunately not. I was getting the error with the exact syntax copy-pasted from above (except for the path). Was totally stumped about it. I'll try again just to be sure. Thank you for your quick response.


Running sinsp may fail to evaluate user name base on user id

Describe the bug
Running sinsp may fail to evaluate user name
This cause due to two main issues:

sinsp evaluating the user list just once on init phase, creating a user after the init phase will cause sinsp to fail evaluating the user name

sinsp user list is not working with container context, the user list is being evaluated by reading /etc/passwd file, using  getpwent/setpwent, however this file may be unique per container. ie reading this file in the context of the Sysdig container is not enough for build the user list, A possible solution may be having user list per container instead of per the whole system.

How to reproduce it
Running Sysdig cli from one container, and from a different container run "useradd newuser; su newuser -c "ls -l"
Expected behaviour
The user that run "ls -l" should be newuser and not ""
Screenshots
From 1 container

From sysdig

Hi @FedeDP,
Thanks for the response
When the Falco 0.32 is expected to be released?
You have mentioned a mechanism for internal events and gave example for "PPME_USER_ADDED"
I did not find the word PPME_USER_ADDED in this repo
could you explain to me how the internal events are working?

Hi @tzachiabo !
Falco 0.32 is the release after the next one; 0.31 will be released before around the end of january; then we can start working on new "big things", like this one (that while it does not seem that big, it indeed is, as it touches multiple areas) for the 0.32 release that it is expected for the end of May.
PPME_USER_ADDED is still not present, it is just an implementation idea! If you wish to see a similar mechanism, you should look for PPME_CONTAINER_JSON_2_E event: it is the internal event that is emitted when a new container is detected.
As you can imagine, this is essentially needed because all the dynamic state (ie: not the booting environment) must be propagated through events to allow dumped scap files to be able to rebuild the dynamic environment without worries.
Thus, events like "new user added" should be encapsulated in an event, emitted, and then managed internally updating the internal system view.
I hope I was able to explain myself :)

@tzachiabo i am writing just to let you know that this issue is currently in progress; i am quite ready to open the PR indeed!
We should still be on target for the 0.32.0 release :muscle:

Opened the PR ;)
https://github.com/falcosecurity/libs/pull/220
There is a limitation though: we are not able to fetch user/group information from containers; this means that for containers users/groups we will only be able to fetch uid/gid, but not user name, user home etc etc.
There is nothing we can do for that unfortunately.
All in all, at least we fix 2 issues:

dynamic users/groups support
we won't mix up users/groups between host and containers

@FedeDP Could you share with me why we can't user/group information?
As far as I understand. The data exists under /etc/passwd file under the scope of the container

Hi @FedeDP, I have seen your PR on this and it is amazing!
However, I think @tzachiabo is right, maybe there is a way to get the usernames from the /etc/passwd file inside the container. One way to do so is by inspecting the overlay filesystem to access that file: to try it, just add a user inside a container, then do cat /etc/mtab. Look for the overlay entry and in particular the upperdir. You will find something like /var/lib/docker/overlay2/544fc9eb63f4531c74e364f469795b6b4538e5ebaea32bf558f839997935c599/diff/. Then, you can navigate there from the host and you will find the file /etc/passwd that was modified inside the container.
This is just a random idea, I may be completely wrong, feel free to tell me what do you think! 🙂

Hi @loresuso ! Thanks for the tip!
Unfortunately, it seems i am not able to make it work using docker as normal user; perhaps you've got some more knowledge on this?
Moreover, each container runtime would possibly behave differently. The PR is already quite huge; i think that we can give this a shoot in a following PR.
WDYT?

Yeah, I agree with you. This is not an easy task, and different container runtimes can make it harder, even if I think that most runtimes use overlayfs under the hood. Let's give it a try once your PR got merged!


Integrate TorchTensorRt in order to increase speed during inference

🚀 Feature
Add a method like to_torchscript in lightgning.py that allow to convert a model in TorchTensorRT in order to increase performance
Motivation
Increase performance during inference
Proposal
    @torch.no_grad()
    def to_torch_tensorrt(
            self,
            example_inputs: Optional[Any] = None,
            enabled_precisions: Union ( torch.dtype , torch_tensorrt.dtype
            **kwargs,
    ) -> Union[ScriptModule, Dict[str, ScriptModule]]:
        mode = self.training

        # if no example inputs are provided, try to see if model has example_input_array set
        if example_inputs is None:
            if self.example_input_array is None:
                raise ValueError(
                    "Choosing method=`trace` requires either `example_inputs`"
                    " or `model.example_input_array` to be defined."
                )
            example_inputs = self.example_input_array

        # automatically send example inputs to the right device and use trace
        example_inputs = self._apply_batch_transfer_handler(example_inputs)
        trt_module = torch_tensorrt.compile(self.eval(),
                                           inputs=example_inputs,
                                           enabled_precisions=enabled_precision  # Run with FP16
                                           )
        self.train(mode)

        return trt_module

Additional context
A possible problem could be the dependencies because it depends on  CUDA, cuDNN and TensorRT as you can see https://nvidia.github.io/Torch-TensorRT/v1.0.0/tutorials/installation.html and some of these dependencies I think work only on Linux
cc @borda @carmocca @awaelchli @ninginthecloud @daniellepintz @rohitgr7

Recently PyTorch team integrated Torch-TensorRT into the Pytorch ecosystem. blog post
Any tips on how would one implement an export_trt to Trainer?

We could follow the pattern used by to_onnx: https://github.com/Lightning-AI/lightning/blob/0ca3b5aa1b16667cc2d006c3833f4953b5706e72/src/pytorch_lightning/core/module.py#L1798. Comparing it to the snippet in your linked blogpost, the advantage would be to automatically use self.example_input_array (if defined) and call the batch transfer hooks to apply any transformations (if defined).

@rohitgr7 Hi is there any progress on this? I want to do super fast GPU inference with my model trained in PyTorch Lightning. How do we convert it to TRT and will it speedup inference 2x or 4x? Thanks, Sam

@davodogster would you be interested to take it over and implementing it? :rabbit:

Hi @Borda ! Sorry, I am an applied data scientist and not a good developer so it may be a challenge for me.
Do you thinks it's easily possible for me to convert my lightning model (image segmentation, batch size >=8) to RensorRT for 3-5x speedup for inference?

Any update on this?


91 in database option for clustering connected components

Purpose of this PR is to abstract out the clustering logic and move the "get_connected_components" function into repository. For the postgres repository, the "get_connected_components" logic can be solved using the pgrouting library. This library extends postgres with network analysis tools.

Need to work on query for record linkage
"left" dataframe entities should only link to "right" dataframe entitites
also debug to make sure test script run_rl.py works as expected
TRUNCATE TABLE {settings.db.db_schema}.clusters;
INSERT INTO {settings.db.db_schema}.clusters (cluster, _index, _type)
SELECT
    component as cluster,
    node * -1 as _index,
    CASE
        WHEN node >= 0 THEN True
        ELSE False
    END as _type
FROM pgr_connectedComponents(
        'SELECT
            ROW_NUMBER() OVER (ORDER BY _index_l,_index_r) as id,
            _index_l as source,
            -1*_index_r as target,
            score as cost
        FROM {settings.db.db_schema}.scores'
    );
"""


Rich error display

@SylvainCorlay Do you have time to take a look at it? I cleaned the code as much as I could. Maybe you have some comments?


Add data provider discovery

New provider here
Duplicate Provider here
Multiple Providers here
Wrong URL here

@viktor-yakubiv I tried to cover all possible cases. You can find URLs in the PR comment.  I put state management into page and I am aware it should be somewhere else. However I would suggest to wait little bit and see how this projects goes. The state management will mostly depend on search.

@viktor-yakubiv I completely rewrote it. Feel free to check it. I assume we can do next iteration and merge it.


Avoid generating code for reserved fields and enumerated values.

This is my attempt to fix #87.
Code is still being generated for reserved, but this reduces most cases.

Thanks, @simonvandel!
@homunkulus r+

:pushpin: Commit 2c34e26 has been approved by japaric

:hourglass: Testing commit 2c34e26 with merge 2c34e26...

:sunny: Test successful - status-appveyor, status-travis
Approved by: japaric
Pushing 2c34e26126ec9f703e08b6e8d251fa178d086a1a to master...


[Enhancement] Full screen view - Align Favorite sign and Ratings to bottom right (next to info button)

Please remove the HEART button from the full screen center to information icon (i).
it is almost in the center of the frame and an EYE sore right now.
thanks

Implemented in 1.6


YoutubeDataApi().fetchVideoData(widget.videoId) & YoutubeDataApi().fetchPlayListVideos(widget.videoId)

[ERROR:flutter/runtime/dart_vm_initializer.cc(41)] Unhandled Exception: NoSuchMethodError: The method '[]' was called on null.
E/flutter ( 5273): Receiver: null
E/flutter ( 5273): Tried calling:
E/flutter ( 5273): #0      Object.noSuchMethod (dart:core-patch/object_patch.dart:38:5)
E/flutter ( 5273): #1      new VideoPage.fromMap (package:youtube_data_api/models/video_page.dart:47:167)
E/flutter ( 5273): #2      YoutubeDataApi.fetchVideoData (package:youtube_data_api/youtube_data_api.dart:435:28)
E/flutter ( 5273):
E/flutter ( 5273): #3      _VideoDetailPageState.showData (package:entertenment_hub/video_detail_page.dart:630:9)
E/flutter ( 5273):

Did you find a solution of this?

Yes, I created a PR.
Now I am working on a new project and I wonder why the PR hasn't been merged

I am facing this issue. Can someone please help me resolving it.

i got the issue when i gave video ids to this method but it did not get these videos by ids instead of this it gets related videos not the actual videos which ids i gave to this method.Any one help me to solve this


Bump doc-gen4 to v4.12.0

make doc succeeds. cc @AlexKontorovich

Oh, didn't noticed this before opening #195.
It seems you've not included the relevant dependencies in manifest though.

It seems you've not included the relevant dependencies in manifest though.

I think the workflow here is that make doc runs lake update to add it in CI: https://github.com/AlexKontorovich/PrimeNumberTheoremAnd/blob/main/Makefile#L14-L17. doc-gen4 hasn't been part of the committed manifest since March 13th (3bd7dfbd3878fb860a52404af469b1b434bf111d).

Oh, I see. Thank you for pointing that out.


Update quick-start.mdx

just a little spelling mistake
uou -> you

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


FSM: provide implementation of StateMachine with the "strict" change of state

It is common case scenario when you want to trigger state change only if current state is different than new one:
if (!mStateMachine.isInState(PlayerState.RUN)) {
    mStateMachine.changeState(PlayerState.RUN);
}

What's about to add some default implementaion of the state machine with this check to be available out of the box? Something like this:
public class StrictStateMachine<E> extends DefaultStateMachine<E> {

    /**
     * @see DefaultStateMachine#DefaultStateMachine(E)
     */
     public StrictStateMachine(E owner) {
        super(owner, null, null);
    }

    /**
     * @see DefaultStateMachine#DefaultStateMachine(E, State)
     */
    public StrictStateMachine(E owner, State<E> initialState) {
        super(owner, initialState, null);
    }

    /**
     * @see DefaultStateMachine#DefaultStateMachine(E, State, State)
     */
    public StrictStateMachine(E owner, State<E> initialState, State<E> globalState) {
        super(owner, initialState, globalState);
    }

    @Override
    public void changeState(State<E> newState) {
        if (!isInState(newState)) {
            super.changeState(newState);
        }
    }
}

I'd prefer to leave such a thing to developer's responsibility for these reasons:

usually in a FSM you want to block reentering only for some states, not for all
in case you need such a functionality the implementation is really simple
for consistency we should provide the same functionality for the StackStateMachine

Sounds reasonable and i agree that implementation is quite simple if someone need it.
Closing issue.


Super tiny optimization

May I make a suggestion, it seems that the is_enabled function is called many times inside the middleware, running the same regex over and over and over. You could easily save it as a local variable inside your middleware 'self'
https://github.com/ottoyiu/django-cors-headers/blob/master/corsheaders/middleware.py#L151

Also it could be a good idea to have the regex already pre compiled with re.compile.

This is a good idea, and more important now after #139 which allows users to write arbitrary code which will get called multiple times. For example, if they check against their database then we're forcing them to either make 4 identical queries per request, or implement their own caching.
Probably the best fix here is to actually cache a value on request that CORS is allowed, and then read that later in process_view and process_response.


Expose Time::MIN and Time::MAX

This PR exposes the internal max/min values for Time. These are useful for building ranges.

Can you elaborate on your use case? Even within this repository the values are used in very few locations, all of which could easily be replaced without issue.

Can you elaborate on your use case? Even within this repository the values are used in very few locations, all of which could easily be replaced without issue.

We have a scheduling app that accepts missing start and end times. To make computations easier, we replace these bounds with actual values, specifically Time::MIN and Time::MAX.

In that case, why wouldn't you want to be explicit about the exact value being added?

In that case, why wouldn't you want to be explicit about the exact value being added?

We are being explicit. By not specifying the range ends, you opt in to MIN as the minimum and MAX as the maximum. We could enforce using MIN instead of a missing lower bound, but for the upper bound, the problem is slightly more difficult as specifying an upper bound is dependent on the precision.
That said, we were able to workaround MIN/MAX by subtracting 1.nanosecond() from MIDNIGHT. If you're not convinced of this PR, maybe we can add some documentation about max bounds and how to achieve them (perhaps using the workaround just mentioned).

@jhpratt Gentle ping, could you please take a look? If you feel this PR isn't useful, please close.

I've decided that this would cause minimal confusion given that Ord is already implemented. However, MIDNIGHT already exists with identical semantics as MIN, so I'd like to avoid exposing that (I'll probably look into removing it). I would accept an update that makes MAX and only MAX public.


Added support for pulling data from stats nz and tests for the new functionality

Added support for pulling data from the Stats NZ data service:

[X] Make code change
[X] Update tests

[X] Update / create new tests
[X] Ensure these tests have the expected behavour
[X] Test locally and ensure tests are passing

[ ] Ensure tests passing on GH Actions
[ ] Update documentation

[X] Doc strings
[ ] Wiki

@Pooja3894 I think a code review is sufficient. I will make w=sure all tests are passing prior to merging.


HIP draft – state channel disputes

This HIP draft has been numbered and merged for discussion as HIP 56.
Please direct future questions & comments to the new tracking issue: #369
If you are one of the named authors, please include #369 in future pull requests to have them automatically merged.


build error if the project name has dash in it

using vscode I have created a function app with name "azdeployer-api". following your example I have created FunctionAppConfiguration.cs, a command DeployTemplateCommand.cs and a command handler DeployTemplateCommandHandler.cs.  It fails with below error
Unhandled Exception: FunctionMonkey.ConfigurationException: CS0116:A namespace cannot directly contain members such as fields or methods SourceFile([443..452))CS0116:A namespace cannot directly contain members such as fields or methods SourceFile([381..390))CS0116:A namespace cannot directly contain members such as fields or methods SourceFile([266..275))CS1514:{ expected SourceFile([438..439))CS1022:Type or namespace definition, or end-of-file expected SourceFile([454..455))CS1514:{ expected SourceFile([261..262))CS1022:Type or namespace definition, or end-of-file expected SourceFile([277..278))CS1514:{ expected SourceFile([376..377))CS1022:Type or namespace definition, or end-of-file expected SourceFile([392..393))
     at FunctionMonkey.Compiler.Implementation.AssemblyCompiler.CompileAssembly(IReadOnlyCollection`1 syntaxTrees, IReadOnlyCollection`1 externalAssemblyLocations, OpenApiOutputModel openApiOutputModel, String outputBinaryFolder, String outputAssemblyName, String assemblyNamespace, TargetEnum target)
     at FunctionMonkey.Compiler.Implementation.FunctionCompiler.Compile() in D:\wip\myOpenSource\functionMonkey\Source\FunctionMonkey.Compiler\Implementation\FunctionCompiler.cs:line 86
     at FunctionMonkey.Compiler.Program.Main(String[] args) in D:\wip\myOpenSource\functionMonkey\Source\FunctionMonkey.Compiler\Program.cs:line 47
  /var/folders/dq/_qnynrwx3470y8wzy4w63ll1px_yqt/T/tmpec9acaa42b4e4065a95663ef81367e2a.exec.cmd: line 2: 19711 Abort trap: 6           dotnet "/Users/rjanjya/.nuget/packages/functionmonkey.compiler/1.1.2/build/netstandard1.0/../../tools/netcoreapp2.1/FunctionMonkey.Compiler.dll" "/Users/rjanjya/repos/azdeployer-api/bin/Debug/netcoreapp2.1/bin/azdeployer-api.dll" --netcore21
/Users/rjanjya/.nuget/packages/functionmonkey.compiler/1.1.2/build/netstandard1.0/FunctionMonkey.Compiler.targets(21,5): error MSB3073: The command "dotnet "/Users/rjanjya/.nuget/packages/functionmonkey.compiler/1.1.2/build/netstandard1.0/../../tools/netcoreapp2.1/FunctionMonkey.Compiler.dll" "/Users/rjanjya/repos/azdeployer-api/bin/Debug/netcoreapp2.1/bin/azdeployer-api.dll" --netcore21" exited with code 134. [/Users/rjanjya/repos/azdeployer-api/azdeployer-api.csproj]

Build FAILED.

/Users/rjanjya/.nuget/packages/functionmonkey.compiler/1.1.2/build/netstandard1.0/FunctionMonkey.Compiler.targets(21,5): error MSB3073: The command "dotnet "/Users/rjanjya/.nuget/packages/functionmonkey.compiler/1.1.2/build/netstandard1.0/../../tools/netcoreapp2.1/FunctionMonkey.Compiler.dll" "/Users/rjanjya/repos/azdeployer-api/bin/Debug/netcoreapp2.1/bin/azdeployer-api.dll" --netcore21" exited with code 134. [/Users/rjanjya/repos/azdeployer-api/azdeployer-api.csproj]
    0 Warning(s)
    1 Error(s)

I also have that helloworld example from your blog which is working fine but not this one. Error message is also not helpful because I have namespaces, classes and methods created correctly.
skeptical about the name I have now created a new project without dash in its name . azdeployerapi. it has the same configuration, command and command handler files inside it. This one builds succesfully without any issue. so I guess having dash (-) in its name is causing a project not to build. Please look into it.

Thanks for reporting this - I think I might know what’s going on, I think its using the project name for a namespace in the generated code hence the confusing error message. I’ve got a new release going out tomorrow so I’ll aim to get a fix in that.
Thanks again!

awesome. Thanks for your great work!

I have exact the same problem here! When is expected to rollout a fix?

Working on this now - I'm hoping (and expecting!) to push out a new release over the weekend.

Addressed in v3.0.4-beta1. Thanks!


When deleting ResourceGroup and query for the operation status the status is null till completed

running this code yeild
val resourceManagementClient = ResourceManagementService.create(createConfiguration())
    resourceManagementClient.getResourceGroupsOperations.createOrUpdate("forDelete2", new ResourceGroup("eastus2"))
    val res = resourceManagementClient.getResourceGroupsOperations.beginDeleting("forDelete2")
    for(a <- 1 to 10) {
      val resp = resourceManagementClient.getLongRunningOperationStatus(res.getOperationStatusLink)
      if(resp.getStatus == null) println("null") else println(resp.getStatus.toString)
      Thread.sleep(6000)

    }

null
null
null
null
null
null
Succeeded
Succeeded
Succeeded
Succeeded

Interesting... we'll verify what the api is returning, but I'm guessing that the operation happens so quickly (after it starts), that any intermediate steps between started and succeeded are done within the 6 seconds.

This should be fixed in 1.0.0-beta1 & 1.0.0-beta2. Please verify.


Fix issue with escaped double quotes in CIM array

This PR aims to address https://github.com/microsoft/Microsoft365DSC/issues/5396 with nested quotes inside of a CIM array. Let's take the following input:
        IntuneMobileAppConfigurationPolicyIOS "IntuneMobileAppConfigurationPolicyIOS-Managed Devices - iOS"
        {
            # Shortened version, only relevant property left
            settings              = @("
                MSFT_appConfigurationSettingItem{
                    appConfigKeyType = 'stringType'
                    appConfigKeyValue = '[`"edge://flags`", `"edge://inspect`", `"edge://optimization-guide-internals`"]'
                    appConfigKey = 'URLBlocklist'
                }
            ");
        }

The issue here is that inside of the settings array with the CIM instance, there is another property named appConfigKeyValue. This is a string property that contains a sequence of characters and escaped double quotes. Those quotes were escaped from the Get-DSCBlock function, unnecessarily though. That aside, when converting that input using Convert-DSCStringParamToVariable to the final DSC string, it removes all double quotes. But here, we don't want that to happen, since they are an integral part of the appConfigKeyValue property.
The PR handles this issue by skipping escaped double quotes inside of the CIM array element and at the end, replacing the escaped version with one that does not have the escape character in it, so that the final output is equal to what was the input to Get-DSCBlock.

@NikCharlebois Ready for review. Got confirmation over in https://github.com/microsoft/Microsoft365DSC/issues/5396 that it now works.

@NikCharlebois Can you please take a look at this PR?

I have fixed a different issue yesterday, which is now in ReverseDSC but which looks very similar. Could you please check the issue with the most recent version of ReverseDSC?
FYI: I am working on another issue that was discovered yesterday. Will create a PR for that later, so any required additional changes I can include with this PR.

@ykuijs Unfortunately it's not fixed with your change. I just checked with the IntuneAppConfigurationDevicePolicy. The correct output should be:
Settings              = @(
    MSFT_MicrosoftGraphappConfigurationSettingItem{
        AppConfigKey = "URLBlocklist"
        AppConfigKeyType = "stringType"
        AppConfigKeyValue = "[`"edge://flags`", `"edge://inspect`", `"edge://optimization-guide-internals`"]"
    }
    MSFT_MicrosoftGraphappConfigurationSettingItem{
        AppConfigKey = "ManagedFavorites"
        AppConfigKeyType = "stringType"
        AppConfigKeyValue = "[{ `"toplevel_name`": `"My managed favorites folder`" }, { `"name`": `"Google`", `"url`": `"google.com`" }, { `"name`": `"Yahoo`", `"url`": `"yahoo.com`" }]"
    }
);

but instead, it is:
Settings              = @(
    MSFT_MicrosoftGraphappConfigurationSettingItem{
        AppConfigKey = "URLBlocklist"
        AppConfigKeyType = "stringType"
        AppConfigKeyValue = "["edge://flags`, `edge://inspect`, `edge://optimization-guide-internals`]`
    }
    MSFT_MicrosoftGraphappConfigurationSettingItem{
        AppConfigKey = "ManagedFavorites"
        AppConfigKeyType = "stringType"
        AppConfigKeyValue = "[{ "toplevel_name`: `My managed favorites folder` }, { `name`: `Google`, `url`: `google.com` }, { `name`: `Yahoo`, `url`: `yahoo.com` }]`
    }
);

In the incorrect export, backticks are set and the double quotes are removed, even at the end of the property (see AppConfigKeyValue). Do you want me to take a look at it? I also need to rebase my changes on yours, since I'm not sure if we both touched the same stuff.

We probably did. I just added a description of what my changes tried to accomplish here: https://github.com/microsoft/ReverseDSC/pull/41#issuecomment-2550645377

@ykuijs I've not being paying attention to these PRs since I'm currently testing AAD resources, but please remember that like I already explained before I rely on the way that the blueprints are exported, if you change something that was single quotes before and not it's double quotes or some similar change it will affect my product.

@ykuijs I've not being paying attention to these PRs since I'm currently testing AAD resources, but please remember that like I already explained before I rely on the way that the blueprints are exported, if you change something that was single quotes before and now it's double quotes or some similar change it will affect my product.

@ricmestre Oh yes, that is right. I totally forgot. My apologies for that!

@ykuijs I updated the PR to include your changes. Now it correctly escapes double quotes inside of a string property in a CIM instance. Example previously:
Settings              = @(
    MSFT_MicrosoftGraphappConfigurationSettingItem{
        AppConfigKey = "URLBlocklist"
        AppConfigKeyType = "stringType"
        AppConfigKeyValue = "["edge://flags`, `edge://inspect`, `edge://optimization-guide-internals`]`
    }
    MSFT_MicrosoftGraphappConfigurationSettingItem{
        AppConfigKey = "ManagedFavorites"
        AppConfigKeyType = "stringType"
        AppConfigKeyValue = "[{ "toplevel_name`: `My managed favorites folder` }, { `name`: `Google`, `url`: `google.com` }, { `name`: `Yahoo`, `url`: `yahoo.com` }]`
    }
);

And now:
Settings              = @(
    MSFT_MicrosoftGraphappConfigurationSettingItem{
        AppConfigKeyType = "stringType"
        AppConfigKey = "URLBlocklist"
        AppConfigKeyValue = "[`"edge://flags`", `"edge://inspect`", `"edge://optimization-guide-internals`"]"
    }
    MSFT_MicrosoftGraphappConfigurationSettingItem{
        AppConfigKeyType = "stringType"
        AppConfigKey = "ManagedFavorites"
        AppConfigKeyValue = "[{ `"toplevel_name`": `"My managed favorites folder`" }, { `"name`": `"Google`", `"url`": `"google.com`" }, { `"name`": `"Yahoo`", `"url`": `"yahoo.com`" }]"
    }
);

The second version compiles perfectly fine and has the correct visual representation.


Using with Rails main

We run rails main in our Gemfile and since this commit https://github.com/rails/mission_control-jobs/commit/83914ae561b59f3ed12f56c4b43be8668c91fa65 we've been unable to update because of the restricted Rails version number.
Is there any opposition to changing this to >= 7.1? Or is there another recommended way to use this with Rails main?

Ohh, yes, of course! Feel free to open a PR for that. That was an oversight on my part.

Dear @rosa , sorry to bother you again.
This issue arises again - as the main now targets "8.0.alpha". The >= 7.1 dependency that was added back by @trobrock , now still fails on a rails new --main application.
Can we fix this please?
All the best,
Johannes

@johannesschobel are you installing the gem from github? I don't believe my version restriction has been pushed to a new version of the gem yet.

Thank you very much @trobrock , you were right. The gem has not been released.
For everyone also stumbling upon this issue, the gem can be installed from GitHub via
gem "mission_control-jobs", github: "rails/mission_control-jobs"

in your Gemfile
All the best

Yes, sorry! I'm super behind on PRs on Mission Control Jobs 😳 Planning to dedicate a few hours this week to review/merge a few PRs that are ready and ship a new version.
Sorry and thanks for your patience 🙏


Normalize line endings

The development took place on Windows, Linux and MacOS, so there are some odd things with line endings (like in this diff or The Incident With CI).
What we need is to set up .gitattributes properly. I would like to set text eol=lf for *.kt and gradlew
This is to be done only after #58

will do it after milestone 1.2.0 is complete


feat(transformer/decorators): support method decorator and is not static

Current dependencies on/for this PR:

main

PR #2238   👈

This stack of pull requests is managed by Graphite.


Remove finely granulated metrics.

We introduced some very finely granulated metrics.
On using a commonly used monitoring backend, it can be easily overloaded with a huge amount of users and different actions on the OpenWhisk system.

PG5#97 looks good.


Add Lornsenschule Schleswig, Germany

My School has one problem: It has micrsoft emails. So I hope it is still possible to add it to the list. If not please give me a way to be able to have valid emails. (Also note: It is a German school so no edu emails for us)

PS: Our main Hompage is on lornsenschule.de and not on zsschleswig.onmicrodoft.com (only our emails are there)

@MTRNord It's no problem to host mail with Microsoft, the problem is that none of your school contacts (http://hp.lornsenschule.de/index.php/infos/kontaktdaten) are in the domain zsschleswig.onmicrodoft.com. Could you please provide us with a link to some document or webpage saying that zsschleswig.onmicrodoft.com is related to lornsenschule.de indeed? Thank you!

I will search/get one to provide you the needed proof

Would an Document (which is propably wrotten in German) be ok? (Would also be propably some sort of paper from my principal) @philipto

@MTRNord Yes, the document will be OK.

So the response from my school is: we should use lornsenschule.sh.lo-net2.de emails here (I will add an commit later) and I will get an document which proves it after my holidays (they and in january 2017)

Email domain is corrected now. I will send the Document as soon as I get it

So here is the Document. On it is written that it proves my personal school address but everyone at our school uses these email (every Student). I hope that this Document is enough.

@MTRNord Pull request merged. Thank you!

Thanks for the merge :D


chore: Set permissions for GitHub actions

Restrict the GitHub token permissions only to the required ones; this way, even if the attackers will succeed in compromising your workflow, they won’t be able to do much.

Included permissions for the action. https://github.com/ossf/scorecard/blob/main/docs/checks.md#token-permissions

https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#permissions
https://docs.github.com/en/actions/using-jobs/assigning-permissions-to-jobs
Keeping your GitHub Actions and workflows secure Part 1: Preventing pwn requests
Signed-off-by: naveen<EMAIL_ADDRESS>

@PageWriter-MSFT
Can you review the proposed changes? IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"

@ckittel or @josevarela - Could you review this?
Thanks!


Add ManageEngine Support

This PR adds support for ServiceDesk by ManageEngine

Hey, @ydbendasan! Thank you for the pull request.
I tried to test this but the interface looks completely different than the one in your screenshot. Are you using an older version of an on-premises installation of Service Desk?

Hi,
Yes that is possible, which version is the latest one? We upgraded it last year I believe.
I’m aware that we’ll be upgrading it next week to patch for the recent 0-day bugs.
Sent from my mobile device
On 8 Feb 2018, at 20:52, Thiago Duarte <notifications<EMAIL_ADDRESS>wrote:
Hey, @ydbendasanhttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fydbendasan&data=02|01||ac805801cc25420f479508d56f35dd78|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636537199489448866&sdata=Aru%2F4PN5alMJuFyCebXMraj4qNw%2BAO0kSnfNv0TwYtA%3D&reserved=0! Thank you for the pull request.
I tried to test this but the interface looks completely different than the one in your screenshot. Are you using an older version of an on-premises installation of Service Desk?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ftoggl%2Ftoggl-button%2Fpull%2F947%23issuecomment-364244630&data=02|01||ac805801cc25420f479508d56f35dd78|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636537199489448866&sdata=Wbu8WSf4tn1xIWP9uuB3URmlbWgANNAU1zYGoHeveSs%3D&reserved=0, or mute the threadhttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAAZNujPBYc-RB4MKmBw0pgcxyE3UXCEVks5tS16KgaJpZM4RPHwD&data=02|01||ac805801cc25420f479508d56f35dd78|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636537199489448866&sdata=i86DA60AcwPtmL6%2F%2FoKT%2BZ4eNMHZCwZ2sFgBPD1GZdw%3D&reserved=0.

This is how it looks like for me:

It seems that their new UI has been available since 2014, at least for their SaaS version (cloud-hosted by themselves).

hmm, it does look very different to what we have. How do you suggest we move forward with this? Essentially I'm trying to add the Toggl Button to the On-Premise version and I'm sure there are other On-Premise installations that would benefit from this version.

Our policy has been that in order to support any on-premises installation we also need to support the public version of the tool. You can wait until we (or somebody else) add an integration for the cloud version or you can do it yourself along with this PR.
Also - could you please squash your commits?

Thanks dooart,
I've added the new interface compatibility now, however I'm not quite sure how to squash my commits. I'm quite new to GitHub and git on the command line I'm afraid. Happy to squash if you can point me in the right direction.
I also read that when accepting a pull request, you can tick a box to squash all commits so maybe it is easier that way?

Thanks @ydbendasan! We'll review your PR soon. :)

Thanks @dooart !!
now that it's merged, when should we expect to see this in the Chrome Web Store?

We should release a new version within the next few days. :)

Hey, @ydbendasan! ManageEngine integration is now officially available in the latest version (v1.10.3)

Hey @dooart , yes I noticed and already installed and using it :)
this is my first open source contribution that has been accepted into a repo!!
Thanks again.


chore: explicitly declare used dependencies

Motivation
List all dependencies used by projects. yargs is used in utils, but not defined in the associated package.json.

yargs is used in utils, but not defined in the associated package.json.

not used by utils package, it explicitly just imports the types
https://github.com/ChainSafe/lodestar/blob/ae984f0f6079f78c2445f36ae2ac09c9e868197e/packages/utils/src/command.ts#L1
which are installed as dev dep
https://github.com/ChainSafe/lodestar/blob/ae984f0f6079f78c2445f36ae2ac09c9e868197e/packages/utils/package.json#L50
if anything we would just install the the types as dependency, or alternatively list it as a peer dependency. See https://github.com/ChainSafe/lodestar/pull/6441#discussion_r1492504070 why I went with just adding it as dev dependency.

Also if you look at packages/utils/lib/command.js, there is no reference to yargs anymore, it's not needed at runtime.

Hmm right, I was confused due to some error related to using yarn install --production. Looks like we are good.


Unable to send JSON as the body

Describe the bug
I'm trying to implement the watcher to call a Whatsapp API deployed locally, but since changedetection sends the JSON data inside "message" key the API refuses to accept.
Version
0.45.25
To Reproduce
Steps to reproduce the behavior:

On any watch go to edit > notifications
Set the URL to the API in Notification URL List
Set the JSON as required by the API in Notification Body
Click on Send Test Notification
Click on Notification Debug Logs

As it is being run on local environment, I am unable to share the watch
Expected behavior
The contents of JSON being sent as request body outside "message" key
Screenshots

Desktop (please complete the following information):

OS: Windows 11 22H2 Compilation 22621.3737
Browser Firefox
Version 124.0.2

Additional context
Add any other context about the problem here.

Resolved, passed the fixed options by url and only the message on body, e.g: json://mydockercontainer:3000/client/sendMessage/mysessionkey?:message=content&:contentType=string&:chatId=phonenumber%40c.us


add a check to see if the model is MySQL or Mongo collection

right now when implementing the relationship Many-to-Many with MySql, all is working but when trying to detach from the MySQL model an error
BadMethodCallException with message 'Call to undefined method App\Models\User::pull()'
is showing because that MySQL model is not a collection and can't use pull on it
so I added a check to see if the model is a mongo collection or not and then will call the pull method
similar issues: #2002

Hello,
Tests are failing. Please investigate and let us know.
Thanks!

Closing due to inactivity, feel free to reply here if you are still willing to fix failing tests.
Thanks!


Error: Transaction reverted: trying to deploy a contract whose code is too large

When I run this npx hardhat test ./test/Lottery.js, error occured:

There is no lottery.js in this repo. Are you using the hardhat-starter-kit?


Limitation on logging module

Compilation fails after a certain number (16 in my case though the size of the individual argument might matter) of arguments
Using SEGGER Embedded Studio - Nordic Edition and nRF Connect SDK
To Reproduce
Steps to reproduce the behavior:

In SES - Nordic Edition, open the nRF Connect SDK Template sample project for Zigbee
Edit zcl_general_commands.c  to include the following:
#include <logging/log.h>
LOG_MODULE_DECLARE(app)
Still in zcl_general_commands.c, edit zb_zcl_configure_reporting_handler() to include the following LOG_INF()

LOG_INF("Status of variables at this point"
"param=%d \n"
"cmd_info\n"
"|----addr_data.common_data \n"
"|    |----dst_addr=0x%04x \n"
"|    |----dst_endpoint=0x%02x \n"
"|    |----fc=0x%02x \n"
"|    |----source \n"
"|    |    |----addr_type=0x%02x \n"
"|    |    |----u \n"
"|    |         |----ieee_addr=0x%02x%02x%02x%02x%02x%02x%02x%02x \n"
"|    |         |----short_addr=0x%04x \n"
"|    |         |----src_id=0x%08x \n"
"|    |\n"
,param,
cmd_info->addr_data.common_data.dst_addr, cmd_info->addr_data.common_data.dst_endpoint,
cmd_info->addr_data.common_data.fc, cmd_info->addr_data.common_data.source.addr_type,
cmd_info->addr_data.common_data.source.u.ieee_addr[0], cmd_info->addr_data.common_data.source.u.ieee_addr[1],
cmd_info->addr_data.common_data.source.u.ieee_addr[2], cmd_info->addr_data.common_data.source.u.ieee_addr[3],
cmd_info->addr_data.common_data.source.u.ieee_addr[4], cmd_info->addr_data.common_data.source.u.ieee_addr[5],
cmd_info->addr_data.common_data.source.u.ieee_addr[6], cmd_info->addr_data.common_data.source.u.ieee_addr[7],
cmd_info->addr_data.common_data.source.u.short_addr,cmd_info->addr_data.common_data.source.u.src_id
);

Build project, note the absence of compilation errors.
Add "|    |----src_endpoint=0x%02x \n" and corresponding , cmd_info->addr_data.common_data.src_endpoint
Build project, SEGGER will output the following error

Compiling 'zcl_general_commands.c'
util_macro.h
util.h
log_msg.h
log_core.h
log.h
zcl_general_commands.c
In function 'zb_zcl_configure_reporting_handler':
'_LOG_INTERNAL_cmd_info' undeclared (first use in this function)
in definition of macro 'UTIL_PRIMITIVE_CAT'
in expansion of macro 'UTIL_CAT'
in expansion of macro 'Z_LOG_INTERNAL_X'
in expansion of macro 'Z_LOG_INTERNAL2'
in expansion of macro 'Z_LOG_INTERNAL'
in expansion of macro 'Z_LOG2'
in expansion of macro 'Z_LOG'
in expansion of macro 'LOG_INF'
each undeclared identifier is reported only once for each function it appears in
in definition of macro 'UTIL_PRIMITIVE_CAT'
in expansion of macro 'UTIL_CAT'
in expansion of macro 'Z_LOG_INTERNAL_X'
in expansion of macro 'Z_LOG_INTERNAL2'
in expansion of macro 'Z_LOG_INTERNAL'
in expansion of macro 'Z_LOG2'
in expansion of macro 'Z_LOG'
in expansion of macro 'LOG_INF'
Build failed `

Expected behavior
No compilation issues
Impact
Annoyance
Environment (please complete the following information):

OS: Linux
Toolchain: same as nRF Connect SDK

@Isaia-F thanks for reporting. This is the Zephyr Project and not Nordic's support site, so could you please first reproduce this with upstream, vanilla Zephyr and describe the steps here?

@Isaia-F this is the hard limitation in log v1 (up to 15 arguments) but logging v2 does not have this limitation. However, since macro is using compiler switch both version are compiled and using more than 15 arguments ends up in compilation failure.
I have fixed that in #40886 where i used preprocessor switch instead. If you want to use more than 15 arguments you need to swtich to version 2. This is done by setting CONFIG_LOG2_MODE_DEFERRED=y or CONFIG_LOG2_MODE_IMMEDIATE=y.

@nordic-krch i have attempted to set CONFIG_LOG2_MODE_DEFERRED via guiconfig but the problem appears to persist
In the .config file i see
# CONFIG_JWT is not set
CONFIG_LOG=y
# CONFIG_LOG_MODE_DEFERRED is not set
CONFIG_LOG2_MODE_DEFERRED=y
# CONFIG_LOG2_MODE_IMMEDIATE is not set
# CONFIG_LOG_MODE_IMMEDIATE is not set
# CONFIG_LOG_MODE_MINIMAL is not set
# CONFIG_LOG_FRONTEND is not set
CONFIG_LOG2=y
CONFIG_LOG_MINIMAL=y
but when i build the solution i still get the same error


Emacs calls doom incorrectly

Commands like SPC-h-r-r call the original doom with EMACS pointing to the original Emacs, which causes obscure issues. I patched doomemacs while debugging an issue I had to call my debugging utility instead of doom, here's the result:
Arguments: [
    "mole", # this is the argv[0]
    "/nix/store/09391jc8xazy2mrjhmca0xzblrmxm9iz-source/bin/doom", # this would be the argv[0]
    "sync",
    "-B",
    "-e",
]

Environment: {
    "DOOMDIR": "/Users/alice/.config/doom/",
    "DOOMLOCALDIR": "/Users/alice/.local/share/nix-doom/",
    "DOOMPROFILE": "nix",
    "DOOMPROFILELOADFILE": "/nix/store/r5xp99h6bs20cb5d3b49xk6jarnvj0d9-doom-profile/loader/init.el",
    "EMACS": "/nix/store/ysr370j2nylqbvwmnk2y3w2hfm0w09ky-emacs-pgtk-29.4/bin/emacs",
    "EMACSDIR": "/nix/store/09391jc8xazy2mrjhmca0xzblrmxm9iz-source/",
    "EMACSLOADPATH": "",
    "EMACSNATIVELOADPATH": "",
    "INSIDE_EMACS": "29.4,comint",
    "OLDPWD": "/nix/store/09391jc8xazy2mrjhmca0xzblrmxm9iz-source",
    "PATH": "/nix/store/wixmy825ga0mzv5ic5k7p471n8760c8b-mole-0.0.1/bin:/Users/alice/.nix-profile/bin:/run/current-system/sw/bin:/nix/var/nix/profiles/default/bin:/usr/local/bin:/usr/bin:/usr/sbin:/bin:/sbin",
    "PWD": "/nix/store/09391jc8xazy2mrjhmca0xzblrmxm9iz-source",
    # irrelevant variables omitted
}

Passing these EMACS and DOOMLOCALDIR to that doom executable is enough to reproduce the issue I had with SPC-h-r-r:
$ DOOMLOCALDIR=/Users/alice/.local/share/nix-doom/ EMACS=/nix/store/ysr370j2nylqbvwmnk2y3w2hfm0w09ky-emacs-pgtk-29.4/bin/emacs /nix/store/09391jc8xazy2mrjhmca0xzblrmxm9iz-source/bin/doom sync -B -e
- Using Emacs 29.4 @ /nix/store/ysr370j2nylqbvwmnk2y3w2hfm0w09ky-emacs-pgtk-29.4/bin/emacs
> Synchronizing "default" profile...
  x There was an unexpected runtime error
    Message: File is missing
    Details: ("Cannot open load file" "No such file or directory" "straight")
    Backtrace:
      (require straight)
      (nix-doom-skip-core-packages nil)
      (apply nix-doom-skip-core-packages nil)
      (doom-initialize-core-packages nil)
      (doom-initialize-packages)
      (doom-packages-ensure nil)
      (let ((doom-print-level (or nil doom-print-level)) (doom-print-indent ...
      (progn (let ((doom-print-level (or nil doom-print-level)) (doom-print-...
      (unwind-protect (progn (let ((doom-print-level (or nil doom-print-leve...
      (let ((noenvvar? (cdr (assq 'noenvvar? alist))) (update? (cdr (assq 'u...
      ((closure (t) (cli alist) (let ((noenvvar? (cdr (assq 'noenvvar? alist...
      (funcall (closure (t) (cli alist) (let ((noenvvar? (cdr (assq 'noenvva...
GNU Emacs     v29.4            nil
Doom core     v3.0.0-p
To add an exception for this directory, call:

        git config --global --add safe.directory /nix/store/09391jc8xazy2mrjhmca0xzblrmxm9iz-source
Doom modules  v24.11.0-pre     fatal: detected dubious ownership in repository at '/nix/store/09391jc8xazy2mrjhmca0xzblrmxm9iz-source'
To add an exception for this directory, call:

        git config --global --add safe.directory /nix/store/09391jc8xazy2mrjhmca0xzblrmxm9iz-source
    ! Wrote extended backtrace to ~/.local/share/nix-doom/state/logs/cli.doom.241103232114.98372.error
✓ Finished in 0.63710s

Note: /nix/store/09391jc8xazy2mrjhmca0xzblrmxm9iz-source/ is the doomSource and /nix/store/ysr370j2nylqbvwmnk2y3w2hfm0w09ky-emacs-pgtk-29.4/ is the original Emacs I use for programs.doom-emacs.emacs (pkgs.emacs29-pgtk)
Possible solution
Change --init-directory to a new directory (probably just a symlinkJoin) which would have the wrapped doom.

Couple of things going on here...
Question: what do you want/expect doom/reload (SPC h r r) to do?
In vanilla Doom, you'd usually use this to test changes you made in your (mutable) $DOOMDIR / doom-user-dir. But in our case, all relevant paths point into the store: the best you're likely to get is "reload your original configuration" (the one you built the running doom-emacs with).
Is that what you want / expect? I don't want to spend too much time trying to make this not error out if the end result isn't going to be useful, and if that is what you want I'd be inclined to override doom/reload with something that just reloads config.el files (both for Doom modules and your private config).
Background:
First, doom sync. In normal Doom, that would read your init.el and packages.el from your $DOOMDIR, install/update packages accordingly, and regenerate the profile init file.
This makes sense if your $DOOMDIR and profile init file are mutable, but in our case both of those live in the store. So the best case I'd expect is that doom sync does nothing, and although that is indeed what I'm getting, I suspect an error's getting swallowed. With our doom wrapper (which sets DOOMDIR and friends):
marienz@jian ~ > doom sync
- Using Emacs 29.4 @ /nix/store/jsxqmsj7v9xxni41xw87952xs29pvkvv-emacs-pgtk-29.4/bin/emacs
> Synchronizing "nix" profile...
  > Installing all packages for the first time (this may take a while)...
    - No packages need attention
  > Updating pinned packages...
    ✓ All 0 packages are up-to-date
  > Purging orphaned packages (for the emperor)...
    - Skipping builds
    - Skipping elpa packages
    - Skipping repos
    - Skipping regrafting
    - Skipping native bytecode
  > (Re)building profile in<EMAIL_ADDRESS>    > Deleting old init files...
✓ Finished in 1.23301s

Although it succeeded, strace shows it tried and failed to delete<EMAIL_ADDRESS>and with DEBUG=1 I get
  > (Re)building profile in<EMAIL_ADDRESS>    > Deleting old init files...
      - Deleting init.29.el...
      x There was an unexpected runtime error
        Message: File error
        Details: ("Removing old name" "Read-only file system"<EMAIL_ADDRESS>
after which it fails. The first half says "0 packages" because it's reading the packages.el Unstraightened generated, which is telling Doom not to package-manage anything (because we're doing that for it). That means a profile init file generated by Doom is going to be incomplete (we extend that step...), but fortunately it tries to write the incomplete profile to the store, which it can't.
Next, doom/reload. This runs doom sync in an environment set up by doom--if-compile, which sets EMACS using invocation-directory and invocation-name, which is supposed to get it "the same Emacs we're currently running". We're starting Emacs through a few layers of wrapper, the last one of which is the one from emacsWithPackages, which execs the underlying emacs (with a bunch of env vars like EMACSLOADPATH set, but those get unset during startup).
So at that point we break in the way you identified: that inner Emacs doesn't have the packages we added, so we fall over (the first one we hit being straight).
So we can try to fix that bit, but the absolute best case scenario is "doom sync does nothing, without failing".
The next bit doom/reload does is "reload your init.el from doom-user-dir, then reload user-init-file (which is the profile init file)". Both of those will be the original ones from the store, so they should load. But they won't do what the Doom documentation tells you doom/reload is for (apply changes made to your packages.el or similar files).
Something similar applies to doom/upgrade, the only other user of doom--if-compile. It'll re-execute the current Emacs, not any new one.

Couple of things going on here...
Question: what do you want/expect doom/reload (SPC h r r) to do?
In vanilla Doom, you'd usually use this to test changes you made in your (mutable) $DOOMDIR / doom-user-dir. But in our case, all relevant paths point into the store: the best you're likely to get is "reload your original configuration" (the one you built the running doom-emacs with).
Is that what you want / expect? I don't want to spend too much time trying to make this not error out if the end result isn't going to be useful, and if that is what you want I'd be inclined to override doom/reload with something that just reloads config.el files (both for Doom modules and your private config).

Right, forgot to mention that. I have been working on a patch that would make doom use ~/.config/doom/ instead which would be a symlink to the store, so I could switch to a new home-manager configuration without having to restart Emacs, but stumbled upon this issue.

I have been working on a patch that would make doom use ~/.config/doom/ instead which would be a symlink to the store

Ah, I think I see.
...but although I'm not sure yet whether you're going for "reload config.el from doom-user-dir" or "reload the whole profile init file", I think in both cases you still won't actually want to run doom sync to make that work (so I'm inclined to leave the bug in "running doom CLI from Emacs" alone, because the environment setup in doom--if-compile looks a bit fiddly, and the only users of that function use it for doom sync, which I still think won't work).
During normal startup (as you may have had to track down already), loading ~/.config/doom/config.el is handled by some code generated around here and added to the profile init file (user-init-file). If you're doing what I think you're doing, we may end up with "edit your config, switch to new home-manager configuration (which includes instantiating our doom-profile derivation because doomdir is an input, our equivalent of doom sync), maybe reload ~/.config/doom/init.el through a symlink, load the profile init file through a symlink". Which would be doom/reload with the doom sync skipped.
I think that'd work if you're just changing config.el, I'm not sure to what extent it'd work if you're changing packages.el / init.el... Might need to try and see. And although you could reload config.el more directly, your home-manager switch is going to have to reinstantiate doom-profile anyway, so I suspect you might as well reload its profile init file and have that reload config.el for you.
...does that sound right, or am I misunderstanding what you're reloading / symlinking?

Yep, seems to match my experience. I later figured out this process is way more convoluted than what I thought initially. Still, a better way to iterate on the configuration would be nice to have.

Still, a better way to iterate on the configuration would be nice to have.

Not sure how much better we can really do... when tinkering with my own config, I'm usually editing just config.el or some adjacent file (in which case I directly re-evaluate that file while iterating) or I'm enabling a new Doom module or adding a new package (in which case I need to rebuild and restart anyway to get the new dependencies).
It's nice that these emacsWithPackages and Doom profile instantiations are completely isolated from each other (so your running instance doesn't pull in some undefined mix of dependency versions if you upgrade while it's running, and you can run the old and new one in parallel), but it does have the downside that they're completely isolated from each other (so you more or less have to start that new instance, reloading in place gets complicated)...


Update to ungoogled-chromium 126.0.6478.61

Notes:

A submodule bump is made.
A patch refresh is made.
Rust is updated according to Chromium requirement.
LLVM is updated from 18.1.1 to 18.1.7
ThinLTO is disabled to solve __rust_alloc issue described in https://github.com/ungoogled-software/ungoogled-chromium/pull/2902#issuecomment-2161983232

Builds and runs fine locally.

Signed-off-by: Qian Qian "Cubik"<EMAIL_ADDRESS>

I get the error ERROR: File checksum does not match: /ungoogled-chromium-macos/build/download_cache/clang+llvm-18.1.7-x86-64-apple-darwin21.0.tar.xz when building

I get the error ERROR: File checksum does not match: /ungoogled-chromium-macos/build/download_cache/clang+llvm-18.1.7-x86-64-apple-darwin21.0.tar.xz when building

I'll take a look right now.

I get the error ERROR: File checksum does not match: /ungoogled-chromium-macos/build/download_cache/clang+llvm-18.1.7-x86-64-apple-darwin21.0.tar.xz when building

Should be fixed.

ThinLTO is disabled to solve __rust_alloc issue described

Haven't you conquered the problem yet? It it ready to merge as is?

ThinLTO is disabled to solve __rust_alloc issue described

Haven't you conquered the problem yet? It it ready to merge as is?

The problem is conquered. (PR is ready to be merged.)


indentation and statusCode

Currently logic for status can check startDate and endDate.
To simplify that on various clients we can just introduce another json field that will reflect status: [inprogress | finished | started] or use some http verbs as in comments. I will accept everything as long we will use some valid http1.1 statuses. Currently this may cause some clients to fail.


azerty not handled

Expected Behavior

robot.typeString("localhost")
should write localhost
Current Behavior

it writes locqlhost
Possible Solution

is the keyboard layout correctly handled ?
Steps to Reproduce (for bugs)

set your keyboard layout to azerty
run robot.typeString("localhost")
read locqlhost

Your Environment

RobotJS version: 0.4.7
Node.js version: 8.1.2
npm version: 5.0.3
Operating System: ubuntu 16.04

For some unknown reason, if I do
robot.keyToggle("backspace","down");
robot.keyToggle("backspace","up");

before the typeString, then it works as expected.

This issue has been closed because it has been inactive for > 240 days.
You may reopen this issue if it has been closed in error.


Crypto settings

This PR adds functionality to Syft to derive the crypto settings of a go executable.
It imports a library that scans the symbols and determines whether an executable contains the boring crypto module as well as the fipsonly module.

I was hesitant as well. I would have liked to have the reader functionality merged upstream, however, the upstream project hasn't changed much in a while and we don't have real time frame. My thoughts were that we could get this PR merged in syft and once the goversion changes got merged upstream we could pull them in.

@kzantow is right that we try to keep references to upstreams before forking. That being said, I would be OK with getting the functionality under the fork then create an issue for removing the fork and tracking the upstream PR there.