Fruniques data model / storage within pallet: spawn

Fruniques is a stateful pallet. It needs to store additional data to maintain various relationships and state. We need to design/build the data structure for this additional state, as described below.
There are a few NFT protocols in the Polkadot ecosystem: https://wiki.polkadot.network/docs/learn-nft
Of these, we should build to the Uniques  patterns. It is the implementation from Parity and I believe the most recent. It is the only one compatible with Statemint/Statemine. We can build to multiple protocols if it makes sense, but let's start with Uniques.
In addition to a regular Unique, a Frunique needs to store a reference to the parent, a different Unique. There also needs to be a heuristic for specifying if metadata is inherited from the parent or not. It seems like Metadata is a set of Key:Value pairs that can be assigned at the class level (a group or collection of NFTs) and at the instance level (a single NFT).
Here's the function set_attribute:
https://github.com/paritytech/substrate/blob/master/frame/uniques/src/lib.rs#L959
Let's map the cannabis lifecycle.

NOTE: the cannabis use case may be able to be implemented with a lighter weight protocol, but it seems like it might be handy to use the same structure

Seeds come from a vendor as a package with a count, e.g. 100 seeds in a bag. This bag is an InstanceId even though it actually contains 100 seeds.
Seeds that germinate get cubed; others are scrapped.
When a seed is cubed, it receives its own InstanceID (I've been calling this a spawn function) for the first time. The count of seeds that did germinate should be tracked, but not individually, and they are scrapped.
Successful cubed seeds become mother plants; perhaps through some iteration or trial/error to discover most productive mother(s).
Mother plants produce clones (and may produce flower directly).
The parent-->child relationship is well represented as a Directed Acyclic Graph, which is what we are building on chain.
Clones may be sold directly to clone buyers.
Clones produce flower, measured in weight. When flower is harvested, the weight values of the material are recorded as continuous value. So the InstanceId would map this specific bag of weed, and there would also be a data element for weight.

The sum of this continuous value for all peers should always equal the continuous value of the parent. This is a critical feature that maintains the economic hierarchy of the NFTs. Tax credits can be subdivided based on this continuous value, but just like the weed, none can be lost or compromised along the way. This feature - the NFT Rollup enables many use cases.

Flower gets tested, and results are implied across that entire harvest/mother?  The test results include a set of files and also a set of values. We need a structure to assign this data/metadata across the appropriate InstanceIds.
Flower is sold to dispensaries.

[ ] Research and prototype a pallet data storage mapping to hold the appropriate data to maintain the hierarchy and enforce the aggregation rules.

I move the information to docs/reviewpallets/fruniques


HMR update error when referencing imports

Related to #2, I found how to consistently reproduce the issue I was talking about.
With the same repository as before (https://github.com/innocenzi/define-options-issue-2), you can simply start the dev server, open the page in your browser, and save App.vue to trigger an HMR update. It will trigger the following error:

After that, subsequent refreshes will all trigger the error. Restarting the server fixes them. Unfortunately I don't have enough Vite knowledge to understand where this issue comes from. I just know it's triggered there: https://github.com/sxzz/unplugin-vue-define-options/blob/main/src/index.ts#L40

Could you please try latest version (now v0.2.2). I still can't reproduce this problem.

It appears that as of v0.2.2, the issue is gone! I'm very grateful for your help on this matter. Thank you ❤

Thanks for your feedback!


Add OLS action for deployments and jobs

Add "Ask OpenShift Lightspeed" actions for 2 additional Kubernetes resources (depoloyments and jobs) with the same functionality as the existing action for pods.
Also makes some style improvements to the info alert that explains the current prompt context.

/retest

/retest


Enhancing the movie card

It doesn't show which year movie was released
A start icon before the imdb rating would be nice :)
No need to show 9/10, just simple 9 with a star would look cool

Movie card with little description and simple star against number will look more attractive. will look more impressive.
I would Like to work on this issue under GSSOC'23.
could you please assign this issue to me.

@Muskan020 I raised this issue, why not assign it to me?

@sourabhsikarwar please assign it to me

As per the guidelines, a contributor can be assigned only with one issue. I'll assign you the next issue after your first successful PR. @Aryan123-rgb
You can still work on it. The PR will be reviewed on the first come first serve basis. Don't worry

@sourabhsikarwar I have created a pull request for this issue, please review it otherwise again there will be conflict with the master branch. Thank you :)
issue-96

I'd like to work upon this issue if this hasn't been done yet.Pls assign it to me

@bhoomikhurana the issue has been already fixed and the pr is under review. Feel free to take another issue. Thanks :)


Add custom help messages

Overview
Add custom help messages.
refer

Defining your own help: https://github.com/spf13/cobra/blob/main/user_guide.md#defining-your-own-help

Support kubectl plugin help message.


Switch to jovial_svg for faster rendering

Description
I switched your plugin to jovial_svg and generated SI files for it.
You can compare the speed using a CustomScrollView with all country flags in it.
Only res/si/ are loaded into assets of applications and SVGs used as source for
dart run jovial_svg:svg_to_si res/svg/*
Also I removed dependency on intl.
Can revert it, if you need it.
But I didn't find any dependency on it through your project.
Type of Change

[ ] ✨ New feature (non-breaking change which adds functionality)
[ ] 🛠 Bug fix (non-breaking change which fixes an issue)
[X] ❌ Breaking change (fix or feature that would cause existing functionality to change)
[ ] 🧹 Code refactor
[ ] ✅ Build configuration change
[ ] 📝 Documentation
[ ] 🗑 Chore

Thank you very much! I will take a look when I find some time 👍🏻

Take your time =)
You need an app with ListView or CustomScrollView with all countries to see the difference of performance.
I'm already using this modification in some of my project, and it turned to be the most performant solution for flags out there.


Support specifying JSON fixtures in oasis-net-runner

We should support passing a JSON document describing a network fixture to oasis-net-runner. Most of the needed stuff should already be there as the fixtures should already be JSON-serializable, we just need an I/O interface and CLI arguments.

Implemented.


C# Cloud Spanner to 80% code coverage

Runtime changes:

Fix for SpannerDbType.HashCode (bug for structs)
new SpannerParameterCollection.Clone along with usage in SpannerCommand.Clone
Code removal/cleanup
Removal of Precondition (inline single usage)
Remove duplicate code in synchronous OpenAsReadOnly
Remove duplicate functionality for GetOridinal/GetFieldIndexAsync (prefer one that caches in a dictionary)
Extra tests for
VolatileResourceManager
SpannerDataReader.Get[Type] methods
SpannerCommand
SpannerDbType
SpannerParameterCollection
SpannerParameter
SpannerProviderFactory
Fix for high stress test (retry needs to recreate the transaction).

LGTM. With these large PRs it's very difficult to see what has changed after addressing review comments. In the future, would it be possible to create new commits to address comments instead of amending the original?


Allow method return types to end with a digit

Syntax coloring fails if method return type ends with a digit. This pull request allows digits to be the last character in type-annotation.end regular expression.
Fixes https://github.com/Microsoft/TypeScript/issues/9444 and should be in line with the to-be-added numeric literal types https://github.com/Microsoft/TypeScript/pull/9407.

Hi @gcnew, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

@gcnew, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, MSBOT;

Sorry for the delay, this should be fixed now by https://github.com/Microsoft/TypeScript-TmLanguage/pull/257


Add how to give a user training rights?

This is done in the back-end. Do we want to include this in the documentation? It would go inside "walkthrough_administrator.md".

Indeed @FloChiff, I remember a discussion we had about eSc administrator interface. I think, since it's the usual Django admin interface, we decided that it was not relevant to document it extensively.
But, I agree that it could be mentioned in the administrator walkthrough. We could mention, for example:

that training rights are not given automatically
backend is django admin interface
maybe give a few tips? (rights terminology, groups, etc.) I don't know

As to have a question about "how to request training rights", I see in the "Train models walkthrough" that getting in touch with the administrator is already mentioned.

Why don't we put that in the FAQ like "How can we give the user training rights" ? Or do you think that it needs a true individual part ?


[SYSTEMML-2167] Support for nary rbind operation

what is here?

support for nary rbind operation
work in progress

what is my idea?

for every new row copy the whole row to the c[]

Refer to this link for build results (access rights to CI server needed):
https://sparktc.ibmcloud.com/jenkins/job/SystemML-PullRequestBuilder/2300/

RBind is actually not applicable to row-wise fusion because the rows from two or more inputs constitute different rows in the output. So unless we support a new column-wise template (for which I've not seen that many use cases) there is no need to add binary or n-ary rbind support.

closing this one. Thanks.


ConversationChain Validation Error

II'm using some variable data in my prompt, and sending that prompt to ConversationChain and there I'm getting some validation error.
what changes we can make it to work as expected?

In your memory function, you can define:

memory_key (the identifier for the memory)
input_key (the identifier for the 'human')
output_key (the identifier for the A.I.

It looks like your prompt's input_key: input does not match your memory's input_key: history.
You can either adjust your memory, like so:
memory = ConversationTokenBufferMemory(
    ...
    memory_key="chat_history_lines",
    input_key="input",
    ...
)

In your memory function, you can define:

memory_key (the identifier for the memory)
input_key (the identifier for the 'human')
output_key (the identifier for the A.I.

It looks like your prompt's input_key: input does not match your memory's input_key: history.
You can either adjust your memory, like so:
memory = ConversationTokenBufferMemory(
    ...
    memory_key="chat_history_lines",
    input_key="input",
    ...
)

yep, it is defined exactly the sameway. still it persists the same

I have same issue. I've digged the class to know about. I also use ChatPromptTemplate to create prompts with ChatOpenAI class.
I've noticed that the ConversationChain validator will collect all input keys from prompts but the validator refers only its input key and memory key.
Other words, how to add some keys that are hold on prompts to the ConversationChain class?
If the class accepts input keys as an array, I can adjust the keys to that I want.


BF: use ^ and consistent with other uses set for non-alphanumeric in a comment

since non-, regex should have ^
and place 0-9 first for consistency (complimentary to #1162 by @TheChymera )

I'm not entirely sure that this is how the sentence is supposed to be read, you remove all non-alphanumeric characters, and you are left with [0-9a-zA-Z].
I think those parentheses were simply there to demonstrate what this entry looks like, and not to rephrase the sentence in regex-jargon (in which case it would still not be very clear since [^0-9a-zA-Z] sounds like it you remove all the alphanumeric chars).


Configure install for datadog-agent-sysprobe

What does this PR do?
Adds the [Install] section to the datadog-agent-sysprobe Systemd unit file. This allows customers to enable the systemd unit file to start at host startup with 'systemctl enable datadog-agent-sysprobe.service'.
Motivation
Currently testing out the beta product and was running into issues getting the service to start after reboots and on new instance deploys. Turns out, without an [Install] section, systemd doesn't know how to 'enable' the service:
root@test01:~$ systemctl enable datadog-agent-sysprobe.service
The unit files have no installation config (WantedBy, RequiredBy, Also, Alias
settings in the [Install] section, and DefaultInstance for template units).
This means they are not meant to be enabled using systemctl.
Possible reasons for having this kind of units are:
1) A unit may be statically enabled by being symlinked from another unit's
   .wants/ or .requires/ directory.
2) A unit's purpose may be to act as a helper for some other unit which has
   a requirement dependency on it.
3) A unit may be started when needed via activation (socket, path, timer,
   D-Bus, udev, scripted systemctl call, ...).
4) In case of template units, the unit is meant to be enabled with some
   instance name specified.

I've chosen to simply mirror what is already setup for the following DataDog unit files:

https://github.com/DataDog/datadog-agent/blob/6.12.1/omnibus/config/templates/datadog-agent/systemd.process.service.erb#L17
https://github.com/DataDog/datadog-agent/blob/6.12.1/omnibus/config/templates/datadog-agent/systemd.service.erb#L17-L18
https://github.com/DataDog/datadog-agent/blob/6.12.1/omnibus/config/templates/datadog-agent/systemd.trace.service.erb#L17-L18

Additional Notes
I would actually love for someone on the DataDog to confirm if this can run independetly from the datadog-agent service itself. If not, it might make sense to have After= include datadog-agent.service

Actually, I think we might want to add BindsTo=datadog-agent.service as well here. Can someone from DataDog confirm that? If so I'll happily add it here.

Hi @jaredledvina, thanks for opening this PR and adding details on the purpose of the [Install] section.
This seems to have been addressed independently (and later) in https://github.com/DataDog/datadog-agent/pull/4591, so I'll go ahead and close this PR, I'm sorry we didn't review your PR in time.

Yep, that does the same thing and works. If you'd like the BindsTo directive, happy to PR that as well.


Lattice: Equivalence tolerance for connections

Scott Dakota — Today at 8:03 PM

[...]
Advanced feature request 2:
User settable threshold in cents for "dotted lines" meant to show near-equivalent interval spans. Example: any fif type interval that's within say 5 cents (user settable threshold) is then given a dotted connector line on the lattice depiction.

This might be related:
Scott Dakota — Yesterday at 10:01 PM

Single-chain parapyth GS with repetition of the pentatonics at 14/11:
GS(3/2 3/2 176/117 182/121)
CS: 5 7 12 17 29 46
This makes
1/1 9/8 14/11 3/2 22/13 2/1 parapyth pentatonic scales with just 13/11 and 14/11, and repeat-stamps again from each new 14/11.
Here is the core pentatonic scale, and this is an excellent working demonstration of how useful a "dotted lines for close analogies" function would be for sw3 lattice view.
From 9/8 to 22/13 is ~707c, and 22/13 to 14/11 is ~707c. If we had a slider for cents threshold for dotted lines, it could ordinarily be left at zero (no dotted lines), and then user set to however many cents threshold is needed case by case. A 6c threshold would show parapyth's full fifs chain.
[...] would dotted line function be difficult to add, or straightforward?


Fix date conversions

Added different date types and changed to use the system timezone in all conversions.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks for the PR


Default translation file

Hello, discovered recently a bug.
My project has default language set to lt - lithuanian. Once I installed the package I got messed up view without translation files. I think this package should set default translation file such as en. I fixed this problem by duplicating en translation folder and changing it to lt. Could I work on a fix for this?

@viktorasbuivydas  I believe this is a setting you could do in your app config, to select the fallback locale. If you have any other suggestions, please share.


Kraken project:create throws an exception

I executed the following:
as a root:
> composer create-project --prefer-dist kraken-php/kraken .
> php kraken.server
> php kraken server:ping
> php kraken project:create

the last command throws this:
Executing : project:create ... failure!
Response  : "fwrite(): send of 159 bytes failed with errno=32 Broken pipe" in /home/vagrant/github/epp-client/vendor/kraken-php/util/Isolate/Isolate.php:73
Reason    : Kraken\Throwable\Error\NoticeError

PHP 5.6.17 (cli) (built: Jan  9 2016 10:31:18)
Copyright (c) 1997-2015 The PHP Group
Zend Engine v2.6.0, Copyright (c) 1998-2015 Zend Technologies
Note that the following command works fine:
> php ./data/autorun/kraken.process undefined Main Main

Your help is appreciated. Thanks.

It seems like isolation mechanism did not spawn its subprocess. There is some things you can check / try :

Can you check if there are any errors in logs?
If not, what is the reason that sub-processed returned with fail ?
You could try to restore default data settings as something might be configured wrongly.
Does the Kraken have proper chmod set for data directory ?

Restart kraken.server helped me

This problem occurs due the same reasons as #49 .


[ZEPPELIN-4775]. Sometimes sql text is not highlighted

What is this PR for?
This PR is to fix the highlight issue. The root cause is in the magic parsing logic in frontend. This PR just move the magic logic from frontend to backend. So that we use the consistent parsing logic.
What type of PR is it?
[Bug Fix]
Todos

[ ] - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-4775

How should this be tested?

CI pass

Screenshots (if appropriate)
Before

After

Questions:

Does the licenses files need update? No
Is there breaking changes for older versions? No
Does this needs documentation? No

@alexott No test for this, it is pretty hard to test the highlight feature in frontend.

I meant for parsing on the server side, not for highlighting...

The server side test is already in. https://github.com/apache/zeppelin/blob/master/zeppelin-zengine/src/test/java/org/apache/zeppelin/notebook/ParagraphTextParserTest.java

great! thank you - I don't have any more comments


Fix tab bar regression of Atom v 0.172

I wasn't sure if the classes should be kept or if i only should use classnames (for backward compatibility). I decided to use the new custom elements
If you would like to only use classes, then this is the fix:
@pane-tab-selector: ~'.pane .tab-bar .tab .title';

Fixes: https://github.com/DanBrooker/file-icons/issues/104

Thanks


Removes GeoLiteCity database

We're not allowed to distribute this database.
Fixes: #6

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Scope out opportunities to simplify aind-data-schema

Some notes from poking around. This will be an ongoing comment:
acquisition.py

ProcessingSteps probably needs to be generalized for outside users, potentially moved out of this file

data_description.py

platform is currently internal
organizations list is pretty limited for outside users

Blocking this until next meeting about it

1st discussion about specific changes (9/27)
Simplifying procedures

Put them into a components file
Subject/Specimen procedures in different component files

Coordinates [breaking change]

There should be a SurgeryCoordinates class? List[that]
Attach angles
Atlas + transforms

Extensions

Make an extensions/aind/??

Instrument

Calibrations are deprecated, remove? Or replace with devices.Calibration. Talk to John + Adam

Value with Unit [breaking change]

Replaced them all with value and value_unit
Remove all XValue and take them out of models repo

Rig [breaking change]

Annotated Union instead of list of Optional

Idea: "people" should be abstracted out so that we're re-using the same class and set of information across all mentions of people? (e.g. evaluator in qc, and experimenter in other places)

Use annotated unions in rig and session to remove empty lists that confuse users.
create AIND specific validators in an AIND extension so WE can require fields that we don't expect external scientists to have.
remove the stimulus classes. These can maybe be in an extension. The goal really is for people to create their own dictionary that is consistent to a project/platform/whatever the right level is, but not for us to dictate or maintain those. (We might need to develop some tools to help people do this though)

Simplifications are going to be moved to a spec doc https://alleninstitute.sharepoint.com/:w:/r/sites/NeuralDynamics/_layouts/15/Doc.aspx?sourcedoc={E27B889D-27A1-4CC0-948C-10ADBE605654}&file=Data+Schema+2.0.docx&action=default&mobileredirect=true where we can continue the discussion, before breaking these out into tickets


add agreement to tos and privacy policy

Issue: https://github.com/omnistrate/saasbuilder/issues/121

@dudizimber will that block users till they mark the checkbox?

@dudizimber will that block users till they mark the checkbox?

There's no checkbox. Just mentions that if the user signs up, he agrees to the tos


make ErrTooManySPFRecords exported.

The error is useful outside the library, and this way it's easier to be checked for.

Thanks for the PR. I will merge the change right after I update required min. Go version in TravisCI :)

alright. I'll be opening a few more pull requests soon, I've fixed some syntax parsing fails and implemented the official test suite. it doesn't pass fully yet and I don't have enough time to fix them all, but it's a start.

Cool. Not sure if I understood correctly, but did you actually run tests defined in pyspf ? These are probably most comprehensive and contain all (most) of edge cases, collected over the years.
My goal was to actually run this lib against pyspf tests, but that will probably require some additional 'testing' framework. If this is what you had in mind I would be super happy to collaborate and/or merge code here!

yes. I've implemented custom parsing of the yaml test suite that is published. the multi-type fields where as annoying as you mentioned, but by implementing the Unmarshaler interface it was possible to handle it.


Update .tas.yml

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:

Your Message to Comment

Your Message to Comment


[Bug] AP won't start when ethernet cable is plugged in

The access point isn't launched when an ethernet cable is plugged into the Raspberry Pi.
My guess is that the network-online.target returns true as soon as the Ethernet interface gets an IP address from the external DHCP server.
It is worth noting that, there’s no issue if the ethernet cable is plugged in after the AP is launched.
My current solution is to unplug one end of the Ethernet cable before booting up the rover.

Could you please check if the issue occurs with the newest release?
Note that the configuration has been changed and now the WiFi and Ethernet interfaces are bridged on RPi by default.

I won't have the time to test this for quite a while. I've ended up using a netplan.io  custom config on all computers on the network. Far from ideal, but I needed a "quick" fix.

I'm unable to reproduce this issue on the newest release, so I'm closing this issue for now. If you run into this problem again, leave a comment and I'll reopen the issue.


Add Parseable output format

Add a 'parseable' output which outputs lines as
"<filename>:<linenumber>: <rule.id> <message>"

Add class ParseableFormatter
Add commandline option -p --parseable

Closes #41

Any comment on this? Feel free to reject if this is not something you would like :)

@jeanfred - sorry, this fell off my radar. Thanks for the friendly nudge. I've merged it now.

No worries − thanks for merging!


[Event Request] - PurchPost.Codeunit.al - OnPostUpdateOrderLineBeforeInitQtyToInvoice

We like to request the following Event:
Object: PurchPost.Codeunit.al
Where is the event placed:
procedure PostUpdateOrderLine
...
InitOutstanding();
                SetDefaultQtyBlank := PurchSetup."Default Qty. to Receive" = PurchSetup."Default Qty. to Receive"::Blank;
                OnPostUpdateOrderLineOnSetDefaultQtyBlank(PurchHeader, TempPurchLine, PurchSetup, SetDefaultQtyBlank);
                if WhseHandlingRequiredExternal(TempPurchLine) or SetDefaultQtyBlank then begin
                    if "Document Type" = "Document Type"::"Return Order" then begin
                        "Return Qty. to Ship" := 0;
                        "Return Qty. to Ship (Base)" := 0;
                    end else begin
                        "Qty. to Receive" := 0;
                        "Qty. to Receive (Base)" := 0;
                    end;
                    OnPostUpdateOrderLineBeforeInitQtyToInvoice(TempPurchLine, WhseShip, WhseReceive);
                    InitQtyToInvoice;
                end else begin
                    if "Document Type" = "Document Type"::"Return Order" then
                        InitQtyToShip
                    else
                        InitQtyToReceive2;
                end;
                SetDefaultQuantity;
                OnBeforePostUpdateOrderLineModifyTempLine(TempPurchLine, WhseShip, WhseReceive, SuppressCommit, PurchHeader);
                ModifyTempLine(TempPurchLine);
                OnAfterPostUpdateOrderLine(TempPurchLine, WhseShip, WhseReceive, SuppressCommit);
            until Next() = 0;
    end;
end;

local procedure UpdateQtyToInvoiceForOrder(PurchHeader: Record "Purchase Header"; var TempPurchLine: Record "Purchase Line" temporary)
var

Event Code:
[IntegrationEvent(false, false)]
local procedure OnPostUpdateOrderLineBeforeInitQtyToInvoice(var TempPurchaseLine: Record "Purchase Line" temporary; WhseShip: Boolean; WhseReceive: Boolean)
begin
end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


added Code for convert array into zig-zag fashion

@ValchanOficial please add my pull request

@ValchanOficial please add my pull request

I don't have permission to accept PRs in this repository


Could print iter's info in benchmark?

We can get summary msg after benchmark.
could print or save iteration's msg in benchmark?

measurements from all iterations are saved in the benchmark report (in values field)

measurements from all iterations are saved in the benchmark report (in values field)

@IlyasMoutawwakil
I use python API and only get benchmark.log.
Should I use cli?

I don't understand what you mean exactly, frim the python api, once you have benchmark_report you can access all values in benchmark_report.prefill.latency.values for example, or save the report with benchmark_report.save_json(...) and investigate the values https://huggingface.co/datasets/optimum-benchmark/cuda/blob/main/cuda_training_transformers_text-generation_openai-community/gpt2/benchmark_report.json#L21

I don't understand what you mean exactly.. from the python api, once you have benchmark_report you can access all values in benchmark_report.prefill.latency.values for example, or save the report with benchmark_report.save_json(...) and investigate the values https://huggingface.co/datasets/optimum-benchmark/cuda/blob/main/cuda_training_transformers_text-generation_openai-community/gpt2/benchmark_report.json#L21 or simply print the report object in your python environement.

Thanks for your explain.
I use the example code from readme. This code only generate benchmark.log in benchmark.
There is no documentation show that how to generate benchmark.json、benchmark_report.json and so on.
Maybe i should try to use .save_json to generate detailed msg and read more source code.

Yes sorry for that we still don't have proper documentation (help is most welcome), the library is mostly for internal use and super-users of the HF ecosystem as it builds upon a lot of its principles (push_to_hub, from_pretrained, save_pretrained).


message edit: Make "Quote and reply" add the content to your message if cursor in message edit.

I noticed this while reading the code for the quote-and-reply widget while working on #20071; we hardcore the location to add the content as the compose textarea.
I think a user would expect that if they're in the middle of editing a message and selected "Quote and reply" from the menus, we'd put the content in the active message edit box rather than opening the compose box to put it there.

@zulipbot claim

@timabbott In the case that multiple message edits are open, which should the quote-and-reply content be added to?

As per the issue description:

in the active message edit box

@alya Thanks for the response!
What makes a message edit box active vs inactive? Here is a screenshot of the circumstance I am referring to.

"message 1" and "message 2" both have edits open, but when the user clicks onto the message they want to quote-reply, neither edit box has focus, so I'm not sure which one we would consider "active".

Oof, you're right! Once the user clicks on the three-dot menu, we necessarily lose focus on the message editing box.
Probably the most recently focused edit box is usually the right one to choose, but I don't know how complicated that is from a code perspective. @timabbott what are your thoughts?

We might be able to prevent focus moving when clicking the 3-dot menu; that will be much simpler than remembering which one we were focused in most recently.

If we can do that, that would be great. Then I think it would be fine to put the quote into the compose box if the user doesn't have a message editing box selected.

Yes, I believed that we can prevent the default actions of clicking the 3-dot menu to avoid losing current focus.

@zulipbot claim


Allow to pass custom middlewares when applying routes

Something like:
require('./app/routers/product.router').applyRoutes(server, '/api/v1', [middleWareFunctions]);

Hi, thanks for the suggestion.
From what I understand, you'd like to have the middle ware functions be applied for every route defined in the Router instance?
I'll look into how to incorporate this feature into the component over the weekend. If you would like to provide an implementation, feel free to fork and create a pull request.

Thanks for your quick reply. I'd like to have a feature that allows applying middlewares for each route as well as Router instance level. That should be very helpful :) Appreciate your work, well done :)

Hi, I've created a branch called feature/middleware. Please take a look at the changes and let me know if this is what you were asking for.
Changes:

Added a method to Router called use

var router = new Router();
router.use(function (req, res, next) {
   req.user = 'bob';
   next();
});
router.get('/hello', function (req, res, next) {
   res.send('Hello ' + req.user);
   next();
});

router.get('/test', function (req, res, next) {
   res.send('Test ' + req.user);
   next();
});

router.applyRoutes(server);

// calling GET /hello  runs use middle ware first and then the routes middleware

Essentially the method behaves like the restify server use method for common middleware except it only applies the middleware to the registered routes for the router.
I'll need to add some tests and then cut a release.

@anhnt  I've merged the changes in. v0.3. It should be available in the NPM registry. Please let me know if you have any issues. Thanks.

Thanks @ukayani i will check and get back to you soon. Merry Christmas :)

Just tested and it worked great. Cheers

Cheers. Merry Christmas to you as well.


bugfix: select commands keep anchor position

Hey ArtudoDent, I know you haven't worked on this repo, so let me know if you are no longer interested in maintaining it and I will just use my fork!
Otherwise, this bugfix changes the commands to keep the original anchor position so that jump-and-select can be used to extend selections.
Both jump-and-select.jump{Forward,Backward}Select and jump-and-select.jump{Forward,Backward}SelectMultiMode commands set selection anchors as the current cursor position (selection.active position). This results in a bug where a current selection is overridden by these commands, which was particularly obvious with multimode creating a new selection for every jump made.
Before changes
https://github.com/ArturoDent/jump-and-select/assets/44491043/b0f1fd76-8a90-49ea-8669-ce0823ab0034
After Changes
https://github.com/ArturoDent/jump-and-select/assets/44491043/d9ae85a6-78f3-4b7f-824f-9d126b9d8296

+1 for this fix - Would be good to get this merged @ArturoDent, It's must more useful this way!
Thanks for the extension!

I just uploaded v0.5.0 which expands existing selections - in both directions with any commands.  So I incorporated your feature request.  I couldn't use the actual PR because I made a lot of changes to the extension along the way.
Let me know if the selection expansions work as you expect.  Thanks.


feat: update Next.js configuration and migrate to Sass module system

This pull request includes several updates to the configuration and dependencies of the project, as well as changes to the SCSS import syntax. The most important changes involve updating Next.js to the latest and greatest Next.JS 15, modifying the package.json dependencies, and changing the SCSS import statements to use the @use rule.
Configuration and Dependencies Updates:

package.json: Updated next to latest version 15.0.3, react and react-dom to version 19.0.0-rc-66855b96-20241106, and their respective type definitions to 19.0.0-rc.1.
next.config.mjs: Added sassOptions to silence deprecations for the legacy JS API.
package.json: Updated the dev script to use next dev --turbopack, significantly improving dev start times.

SCSS Import Syntax Changes:

src/once-ui/styles/index.scss: Changed all SCSS import statements from @import to @use.
src/once-ui/tokens/index.scss: Changed all SCSS import statements from @import to @use.
Changed all SCSS import statements from @import to @use.
Summary: Upgrades to Latest Next.JS 15 and removes Sass deprecations

@lorant-one

this is beyond amazing @lightyfr! there's a tiny issue caused by floating-ui not being compatible with the react 19 rc, so i need to install the packages with the legacy-peer-deps flag when using npm. this makes me a bit hesitant to merge it right away. i'll need to investigate when they plan to upgrade to the react rc.

@lorant-one Once floating-ui becomes compatible with react 19 rc, will this get merged?

yeah of course it will @lightyfr :)


[Bug]: Issues Spinning Up Notebooks as Admin

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
When spinning up a notebook for another user as an admin using the Impersonation inside the KFNBC page, you'll have issues or it will attach your (as the admin) storage to the other users Notebook.
I encountered this when trying to spin up a Notebook for another user to test Auto Scaling:

See downstream the ticket for more details. https://issues.redhat.com/browse/RHODS-5220
Expected Behavior
An Admin should be able to spin up a Notebook FOR this user without impacting the result of the spawning.
Steps To Reproduce
See the ticket https://issues.redhat.com/browse/RHODS-5220
Workaround (if any)
No response
OpenShift Infrastructure Version
No response
Openshift Version
No response
What browsers are you seeing the problem on?
No response
Open Data Hub Version
2.2

Relevant log output
No response

I believe this whole situation is also related to https://issues.redhat.com/browse/RHODS-5211

I'll be waiting for this PR: https://github.com/opendatahub-io/odh-dashboard/pull/587 before I make changes for this issue.


Added ttf2fnt.com to the list

Added ttf2fnt.com to the list
What's Changing and Why
Added ttf2fnt.com to the list of online font converters to make developers lives easier.
What else might be affected
Nothing
Tasks

[ ] Add tests
[x] Update Documentation
[ ] Update jimp.d.ts
[ ] Add SemVer Label

Published PR with canary version: 0.9.4-canary.845.627.0

:rocket: PR was released in v0.9.5 :rocket:


Move E2E tests to efficientgo/e2e

In order to provide a more comfortable and robust experience for out integration testing, this PR moves tests from using Bash to using the efficientgo/e2e Go framework. This applies to both metrics and logs test, as well running the setup locally (interactive test). Excludes moving load tests for now.

@ianbillett @periklis @onprem everything should be addressed now, PTAL when you get the chance, thank you :heart:

LGTM, one small nit though. Do you really format with tabs space of 2?

I'm not sure, I have my IDE set to use 4 space tabs for indentation, seems like it got changed on some files here, I fixed that. Thanks!


fix: avoid importing component code in nodes that have SSR disabled

closes https://github.com/sveltejs/kit/issues/12578
This PR makes it so that component code is only imported in nodes that have SSR enabled. It should make bundle sizes smaller for edge deployed apps that have SSR disabled since the component code will no longer be bundled if it's not used on the server.
TODO:

[ ] add a test that checks if a component is exported from the node?
[ ] changeset

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

[x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
[x] This message body should clearly illustrate what problems it solves.
[ ] Ideally, include a test that fails without this PR but passes with it.

Tests

[x] Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

[ ] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

[x] Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

preview: https://svelte-dev-git-preview-kit-13234-svelte.vercel.app/
this is an automated message


add print command to show compiled template

Fixes https://github.com/envato/stack_master/issues/140

sfn print deals with compile time parameters by prompting the user. stack_master has parameter files to avoid this behavior so I've opted to pull in compile time parameters from the parameter file.
stack_master print will work without any parameter file as long as there are no compile time parameters. If there are compile time parameters in the template that do not have default values then those values will need to be populated in the parameter file for the stack.

@patrobinson anything else needed here?

@viraptor this implements the same functionality you were working on. Can we use this PR instead?

I don't mind either version.
One difference I spotted is that this one always outputs json, but my version does {json,rb} -> json and yaml -> yaml.

Oh right we already merged that
@rbayerl sorry this was super-seeded by #245 which I'll release a new version for shortly.

:+1: works for me


sanity for txt report writer

Pull Request Test Coverage Report for Build 890610350

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+8.4%) to 90.307%

Totals

Change from base Build 890573946:
8.4%

Covered Lines:
1090

Relevant Lines:
1207

💛  - Coveralls

Pull Request Test Coverage Report for Build 890610350
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+8.4%) to 90.307%

Totals

Change from base Build 890573946:
8.4%

Covered Lines:
1090

Relevant Lines:
1207

💛  - Coveralls


Adjust scrollbar position gVim/GTK

This is to address the issue #8008 by adding GTK-specific implementation of gui_mch_get_scrollbar_xpadding() and gui_mch_get_scrollbar_ypadding() introduced by PR #6466.

Can someone check that this works?  Somehow I can't reproduce the problem, thus also can't check the fix.

@brammool  The effect could be seen easily while horizontally resizing gVim/GTK3 app window by small steps (less than one character cell width). If the total width is not divisible by &columns * screen_cell_width + scrollbar_width then there'll be thin "leftover" vertical space visible on the right. Currently it is right after the right scrollbar and belongs to the app window. After patch it moves in front of the right scrollbar thus extending textArea (and so it gets Normal background color but empty space, because of small width).
In GTK2 (and also Windows) build GVim only allows resizing the app by whole number of character cells, so the difference is visible only if the app window is maximized full-screen (and there's some leftover space that depends on screen resolution, font size, DPI scaling etc.).

@brammool @matveyt
Before this patch:

With this patch:


[ISSUE][CLOSED] Reduce # messages from bot, delete obsolete messages from bot.

 Issue by myungjoo-ham
Tuesday Jun 12, 2018 at 07:00 GMT
Originally opened as https://github.sec.samsung.net/STAR/TAOS-CI/issues/19

Issue summary
The current CI bot writes too many messages:
Please:

Reduce the number of messages from the bot
Delete obsolete bot-messages automatically.
Let's not add a comment like cibot: Thank you for posting issue #77. The person in charge will reply soon. It's not a useful information for our repo.

:octocat: cibot: Thank you for posting issue #36. The person in charge will reply soon.

 Comment by geunsik-lim
Friday Jun 22, 2018 at 00:39 GMT

Done partially. If we need to reduce # of CIBOT messages in the near future, we are going to do releated activity aggressively more. Please re-create or re-open issue if we need to to that.


Fix javadoc issues

Reviewer checklist

[ ] Ensure relevant issues are linked (description should include text like "Fixes #")
[ ] Ensure any appropriate documentation has been added or amended

Coverage remained the same at 99.625% when pulling 6543de2a695cc8eecf675ed32e4e1c8098d84abf on javadoc into 322b46fc448a6752fc59b43f97d1910c10c0fce1 on main.


node version update [stable] + minor UI updates

Issue + Solution:

All GitHub Actions will begin to run on Node16 (stable) instead of Node12 starting this summer. Hence, the changes contain updating node version of workflows to 16 from 14 to ensure it's operationality.

Besides, two packages have been updated to their latest!

Moreover, it was also lacking a few icons (Kotlin, Objective-C, Scala) which have been added.

Checklist:

[x] I have explained the need for this PR and the problem it solves
[x] I have explained the changes or the new features added to this PR

Signed-off-by: Pratyay Banerjee<EMAIL_ADDRESS>

@tudi2d lemme know your thoughts! :)

Thanks @Neilblaze - good catch & sorry for the late response!! Directly updated to v20 in #23 & updated node dependencies in #22. Closing this PR now.


help: Define "participate" for automatically following topics.

Fixes #27721.

Merged, thanks @alya!


Admin > Organizers > "Submit" not re-rendering

Description
Path: Admin > Organizers > "Add Other Admins Contact Info" Form
Clicking Submit button does not trigger render.

Input fields do not clear
"Current Organizers" table does not refresh

To Reproduce

Go to Admin (must be logged in)
Go to Organizers
Fill out input fields
Click "Submit"

Expected behavior
"Current Organizers" should refresh/re-render
Input fields should clear
System Info:

Device: MacBook Pro
OS: Mojave 10.14.3
Browser: Chrome
Version: 73.0.3683.86

Additional context
"Current Organizers" table refreshes, and input fields refresh when browser is refreshed.

Thanks for helping out, we have incorporated your changes into another pull request.


Azure CosmosDB Vector Search integration

Related Issues

fixes #issue-number

Proposed Changes:

How did you test it?

Notes for the reviewer

Checklist

I have read the contributors guidelines and the code of conduct
I have updated the related issue with new insights and changes
I added unit tests and updated the docstrings
I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test:.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

It seems that we can already use Azure CosmosDB via our existing integrations.
See https://haystack.deepset.ai/integrations/azure-cosmos-db.
I am closing the PR for the moment.


Cliffy prompt throwing "os error 6" at Windows 7

Running at Windows 7, the Cliffy prompt throws an "os error 6".
Perhaps the following issues may help:

https://github.com/denoland/deno/issues/5943
https://github.com/denoland/deno/issues/16195

Although the Deno issue is closed, this is happening with Deno 1.23.2+

Cliffy 0.25.2 fixed the error above.
Back to "os error 6" described in this issue on Windows 7, Deno 1.25.2 and Cliffy 0.25.2
Works with Windows 7, Deno 1.23.2, Cliffy 0.25.1

Abandoning Win 7


coloring shapes by categorical variable

This should fix multiple problems when coloring shapes, namely:
# data reading, preprocessing
sdata = sd.read_zarr("visium_associated_xenium_io.zarr")
sdata.table.obs["cluster"] = "a"
sdata.table.obs.loc[sdata.table.obs.array_row==1.0, "cluster"] = "b"
sdata.table.obs.loc[sdata.table.obs.array_row==47.0, "cluster"] = "c"
sdata.table.obs.cluster = sdata.table.obs.cluster.astype("category")

1 Incorrect legend coloring when using the groups argument:
sdata.pl.render_shapes('CytAssist_FFPE_Human_Breast_Cancer', color="cluster", groups=["c", "b"]).pl.show("global")

2 palette parameter in render_shapes doesn't have influence on the plot (= https://github.com/scverse/spatialdata-plot/issues/145)
sdata.pl.render_shapes('CytAssist_FFPE_Human_Breast_Cancer', color="cluster", groups=["c", "b"], palette=ListedColormap(['blue', 'red'])).pl.show("global")

Plus some downstream bugfixes that came up after that

Codecov Report

Merging #153 (24c1392) into main (4dd12f2) will decrease coverage by 0.08%.
The diff coverage is 42.85%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #153      +/-   ##
==========================================
- Coverage   75.01%   74.94%   -0.08%
==========================================
  Files          11       11
  Lines        1293     1297       +4
==========================================
+ Hits          970      972       +2
- Misses        323      325       +2

Files Changed
Coverage Δ

src/spatialdata_plot/pl/utils.py
60.83% <0.00%> (-0.20%)
:arrow_down:

src/spatialdata_plot/pl/render.py
89.47% <100.00%> (+0.12%)
:arrow_up:

Is this bug already solved? Or were these diagnostic plots?

Bug is solved, I still want to add some tests

Meeting notes

[ ] Implement also for labels using MibiTOF
[ ] Change Changelog text
[ ] Internalise ListedColormap conversion
[ ] Docstrings
[ ] one string is accepted for both arguments


Plugins and extensions should display something useful when run from the command line.

Currently they hang until their input is closed and then crash when they fail to deserialize a protobuf.

Fixed for Go plugins that use the plugins/environment.go support code.


Fix undefined offset 0

As the track limit is 100 chunking is needed so array_values just
resets the keys if ever they do not start from 0 e.g. 100+
Could be done app side however this is a bit cleaner, minor change but caused some confusion hunting it down.

Nice catch, thanks for the patch! 🎉
Merged in ae8bd9673795747fad40ff4caf6b12f17c045fc5 and released in 1.4.2.


Please approve the PR of jaredfholgate and take your Charles Zip heritage seriously.

@momeijer  We are in conversation with Jared and I've added him to the organisation.  I have not approved the change because we cannot test it currently.  We are in the middle of trying to support versioning in the extension so we can have a more modern release cycle than is possible with the current setup but until that is done releases are broken in most of the environments.


"Empty Cache and Hard Reload" fails OidcKeepAliveServiceWorker.json request which causes strange behaviour

Issue and Steps to Reproduce
Failed "OidcKeepAliveServiceWorker.json" request causes all consequent requests to fail, even though a user seems to be "authenticated" but they aren't
Versions
"@axa-fr/react-oidc": "^6.16.10"
Screenshots
When I do a normal page refresh - all is good, a user is authenticated and their state is loaded :

But when I do "Empty Cache and Hard Reload" things go unexpected:

OidcKeepAliveServiceWorker.json request is failed

It still shows that the user is authenticated

Which eventually fails all consequent requests

Expected
OidcKeepAliveServiceWorker.json requests should not fail, but if they have to - it should be visible to callers anyhow
Actual
OidcKeepAliveServiceWorker.json cascade fails all consequent requests
If I refresh the page again without "Empty Cache and Hard Reload" it works as if nothing happened

hi @Zamaletdinov , thank you for your issue.
OidcKeepAliveServiceWorker.json requests will not fail in latest version. It is a hack in order to keep alive service worker. The fail is a kind of volontary fail.
The hard refresh that bypass the service worker is a "normal" browser behavior : https://stackoverflow.com/questions/35628243/how-to-prevent-hard-reloads-from-bypassing-the-service-worker
I hope it will be changed one day. I cannot do a lot on that.

Thank you for your response @guillaume-chervet! Can't wait to see the latest versions :)

looks like this solution will not work in FF Private mode


Miss the action 'Clone...' for one ADLS Gen2/regular blob container

Storage Explorer Version: 1.30.0
Build Number: 20230613.2
Branch: main
Platform/OS: Windows 10/Linux Ubuntu 20.04/MacOS Ventura 13.4 (Apple M1 Pro)
Architecture: x64
How Found: From running test cases
Regression From: Previous release (1.30.0)
Steps to Reproduce

Expand one storage account -> Blob Containers.
Right click one blob container -> Observe the context menu.
Check whether there is an action 'Clone...'.

Expected Experience
There is an action 'Clone...'.

Actual Experience
There is no action 'Clone...'.

Verified this issue on the build main 20230614.1. Fixed. So, we are going to close it.


[WIP] ZEPPELIN-2986. Add hadoop-aws and hadoop-azure to zeppelin server

What is this PR for?
Trivial fix.
What type of PR is it?
[Improvement]
Todos

[ ] - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-2986

How should this be tested?

First time? Setup Travis CI as described on https://zeppelin.apache.org/contribution/contributions.html#continuous-integration
Strongly recommended: add automated unit tests for any new or changed behavior
Outline any manual steps to test the PR here.

Screenshots (if appropriate)
Questions:

Does the licenses files need update? No
Is there breaking changes for older versions? No
Does this needs documentation? No

notebook storage is in module zeppelin-zengine. Just found it has jar conflicts with the native azure and s3 storage. Will keep it pending for now.

Spark 2.3 has a spark-hadoop-cloud module which adds a set of dependencies on the hadoop cloud modules, throwing out all the transitive conflicting modules. Either pick that up or lift all the exclusion logic there to keep out things like: jackson, guava, joda-time which will only cause pain. Hadoop 2.9+ will move to a shaded aws JAR here.
Do be aware, hadoop-aws is very fussy about aws-SDK versions: that library is a moving target. You can't expect to change versions and not expect to have the code link, let alone run.

I agree this is going to be a huge moving target to include in the release of the project
Can this be just a list of steps people can follow? Dockerfile or actual Docker images people can use, instead?

bq. Can this be just a list of steps people can follow?
It's a very brittle list of steps. It's easier at build time as you already have your hadoop version fixed, the hadoop-aws and hadoop-azure poms give you the library versions they need. All you need is to add them and evict all conflict with the later stuff Spark has chosen. It's really hard to get this right.
The spark work adds a new optional module and profile to set this up. I'd recommend doing the same thing for now, using the code in spark's POMs to tell you what to exclude


Keep the same status with console & add run id  for pipelinerun custom resource

What is version of KubeSphere DevOps has the issue?
v3.3.1
How did you install the Kubernetes? Or what is the Kubernetes distribution?
kubekey
Describe this feature
# kubectl get pipelinerun -n starkxhqxb | grep stark-
stark-4z2zh    Pending     48m
stark-59zll    Pending     48m
stark-846zm    Running     127m
stark-8scb7    Running     127m
stark-l4kkf    Running     127m
stark-n7ckp    Failed      48m
stark-ngddd    Pending     36m
stark-p7kxm    Running     127m
stark-q9j9p    Running     128m

It is hard to match pipelinerun cr with run records in console.
Backend feature:

Add run id in pipeline cr.
Keep the same status between pipeline cr with run records in console.

Frontend feature:

Able to show run id for not running pipelinerun, if it has run id in pipelinerun cr

# kubectl get pipelinerun stark-q9j9p -n starkxhqxb -o yaml
apiVersion: devops.kubesphere.io/v1alpha3
kind: PipelineRun
metadata:
  annotations:
    devops.kubesphere.io/creator: admin
    devops.kubesphere.io/jenkins-pipelinerun-id: "14"
    devops.kubesphere.io/jenkins-pipelinerun-stages-status: "null"
    devops.kubesphere.io/jenkins-pipelinerun-status: "null"
  creationTimestamp: "2022-12-07T04:54:03Z"

Additional information
No response

https://github.com/kubesphere/ks-devops/pull/893

Backend 1 has been fixed in： https://github.com/kubesphere/ks-devops/pull/893
Backend 2 no need to change，use as：

Frontend 1 need to fix， @yazhouio


Fixed: Missing Parameters for deferredWampCRASigningBlock

In this issue #40 I described that I needed more information for the deferredWampCRASigningBlock.
I made some small adjustments to get them.

oh thanks, You've been quicker :)


Bump memory limits for go mod tidy check and otel agent builds

What does this PR do?
Bumps the required memory for go mod tidy check and otel agent build jobs.
Motivation
We're still getting OOM killed in these jobs due to some heavy dependencies.
Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

/merge


Make time_scale behave similarly to pause

time_scale is really useful for slo-mo in games, but making it global limits use cases severely. What I propose is to handle changing scale similar to pause, where user can select some nodes/branches to be excluded from slo mo goodness.

Seconded.

Yes, yes and three times yes. I second this motion too. An ease way to put some objects in slow motion even if they are influenced by the physics motor.
Any way if there's a way to achieve that I can't find it...

Duplicate of #6885?

Closing as duplicate, given that nobody responded...


refactor CustomIconButton and change desing in DeleteButton

SSIA

JaCoCo Code Coverage 77.34% :white_check_mark:

Class
Covered
Meta
Status

  Generated by :no_entry_sign: Danger

Snapshot diff report

File name
Image

PreviewConvertHistoryScreeContent-Dark-1_0_compare.png

PreviewConvertHistoryScreeContent-Light-1_0_compare.png

PreviewDragHandler-Dark-2_0_compare.png

PreviewDragHandler-Light-2_0_compare.png

PreviewInfoScreenContent-Dark-0_0_compare.png

PreviewInfoScreenContent-Light-0_0_compare.png


Demo Map Menus and Toolbars not showing

On opening DemoMap the expected Menus and Toolbars are not showing.
This occurs on current release and multiplie versions other versions. Trialled on debug bin version compiled on computer where all menus show but they still did not show. Any ideas on why?
Expected behaviour

Actual behaviour

Do you get any error messages? Please check the content of your plugin folders. Make sure the files that exist in your root folder do not get copied to the folders of your plugins.

I have resolved this issue. In case it helps others the issue was caused by Windows. If I run VS as admin then everything works as expected.

This should work without running VS on admin ,too.

Now that I have been able to successfully run as admin once I can now run without using Admin privileges.

I consider this resolved.


Update regression tests

The coverage increases a ton, but these are only regression tests to make sure the output of the methods is about what we expect. The tests don't deal with individual functions at this point.

Coverage increased (+44.58%) to 84.09% when pulling 19b96b14b6a1028c37690d64e7b0f77b55d0596a on test-update into b56d6eb5ec652b240d4aba574018c4f4bcb79906 on master.

Awesome!

The joy of regression tests...


feat(minifront): #1051: ibc in account selector

Closes #1051
Allows selecting user's account to IBC to.

One thing, in the meeting where we discussed this, it was brought up that we don't want to show the addresses here as the only trustworthy address is the one they'd see in the Keplr dialog box and this text could be confusing. Along those lines, can you remove "Here is your normal address" and below?

@grod220 Thanks for the noticing. I didn't read the issue correctly in the first place, just changed it


adjust some filemanager translations after review in UI

I dit not find somse stings to ajdust after review in UI, even sosme of them are present for context menu.

I guess you used translations provided by original filemanager from usermin/webmin?

Probably those are in filemin/lang?

will have a look at filemin/lang, if they are there I provide an update for filemin/lang to webmin.
Now my translation adjustments after reviewing in UI anre in this pull request.
Please merge.
Wish you a nice weekend

thanks for the tip found missing strings (and more) in filemin/lang and create a pull request for JC :-)

Thanks! :wink:


Update Dockerfile

This will get us ocaml-dockerfile 8.2.4 which is needed to fix Fedora 41.

Looks like a recent change broke ocaml-ci. Reported here: https://github.com/ocurrent/ocaml-ci/issues/984


tasaur_arrives

👷 Deploy Preview for rayko-research processing.

Name
Link

🔨 Latest commit
89b23b4f72dcbccf8328dfb7d8110638c78af5ae

🔍 Latest deploy log
https://app.netlify.com/sites/rayko-research/deploys/651b81209f119100089aece0


Direct COM1 to file to improve boot time.

Improve Boot Time on VirtualBox 6 (maybe others too?)
Boot time in VirtualBox 6 was taking 30m or so for the routing engine.
Found that the problem was related to COM1 not being connected to anything.
Connected it to a file, and now the light qfx boots in about a minute on my machine.
Made the change in all Vagrantfiles and tested to make sure it comes up.
This change only helps, hopefully a quick one to approve.

Hi @grigorenkoae was hoping you could take a look at this?  Thanks!

Closes #36

@trmccart would you mind to approve this?  It make Vagrant usable again for many OS X users.  Thank you.

@aburston can you try this on Windows please to be safe?  I tested all the Vagrantfiles on OSX.

@aburston can you try this on Windows please to be safe? I tested all the Vagrantfiles on OSX.

Will do, could you please assign this issue to me.

@aburston I don't have permission to do that.  Not sure who maintains this.  Activity seems a bit light.

@edwinpjacques looks like @trmccart is the person who last merged code, so we could ask him once I have tested this.

@aburston hold on, let me try another tweak to avoid having to write a log file at all.  The hard part is supporting Windows since I have to set the log file to NUL instead of /dev/null.  Should be doable though.

@edwinpjacques Don't try create files for the "National University of Lesotho", tried that doesn't work out well in windows.

@aburston I replaced the assignment of re_log with a conditional that works on OS X, Linux & should work fine on Windows.


[Feature] Rpc type for optimism_outputAtBlock

Component
rpc
Describe the feature you would like
Add a type for the output of optimism_outputAtBlock endpoint.
Additional context
No response

May I?

Certainly - we should be able to effectively copy this OutputResponse type https://github.com/paradigmxyz/reth/blob/c788b6a585bbbd7ed92aabc42cb612a6a804daff/crates/optimism/rpc/src/api.rs#L45-L54 over to a new output module in the rpc-types crate

Thank you for the reference!


Color should have a paint method like String

Duck typing and all that stuff.

Implemented in first-release branch.


Best way to update an installed version of a template?

Hi,
I'm looking for the best or correct way to update an installed version of a template? Let's say I installed v2.0.1, how do I update to v2.1.0?
Thank you,

@johnmerced maybe don't exist a correct way, but can you see this options:
https://github.com/vuejs-templates/pwa/issues/74
https://github.com/vuejs-templates/pwa/issues/48


Add support for ERA5 Reanalysis

Addresses #66

I wonder, do you have a master catalogue pointing at all of these resources that you are now able to load? I am thinking along the lines of https://github.com/pangeo-data/pangeo-datastore/blob/master/intake-catalogs/master.yaml - and note that that repo also has CI to ensure that all entries load OK, and renders the whole cat to a static webpage on mergers too.
(PS: I think you must have included notebook outputs, for the diff to be so large)

@martindurant, we don't have a master catalogue yet. We will eventually have a master catalogue for community datasets such as CMIP and CESM-LE. Thank you for the pointer to the pangeo datastore repo ( I wasn't aware of it). The continuous integration + Browsable website is really great. I will see if there's a possibility of adapting a  similar approach to our catalogues.

(PS: I think you must have included notebook outputs, for the diff to be so large)

I found the culprit to be this file:
https://github.com/andersy005/intake-esm/blob/3684f9329598f9eb0e841d0096fbfed27cfa3dd0/tests/era5_filelist.txt


Starting pipeline with both IR cameras fails on Android

Required Info

Camera Model
D435i

Firmware Version
<IP_ADDRESS>

Operating System & Version
MacOS

Kernel Version (Linux Only)
-

Platform
Android 10

SDK Version
2.34.0

Language
C++

Segment
VR

I'm attempting to start a pipeline that gets data from both IR cameras simultaneously.
I generate a config and start the pipeline as follows:
rs2::config config;
config.enable_stream(RS2_STREAM_INFRARED, 1, 640, 480, RS2_FORMAT_Y8, 30);
config.enable_stream(RS2_STREAM_INFRARED, 2, 640, 480, RS2_FORMAT_Y8, 30);

rs2::pipeline pipe;

pipe.start(config);

This works fine on Ubuntu 18.04 but generates the following error on Android:
E/libc++abi: terminating with uncaught exception of type rs2::error: Couldn't resolve requests

Is this a bug or not supported on Android?

The message "Couldn't resolve requests" may appear if the SDK is being asked to do something that is not supported or there is an error in the formatting of the statement that means the SDK cannot understand what it is being asked to do.
To access the left and right IR, I believe that you should be using the stream indexes 0 and 1 instead of 1 and 2.  It may be getting confused about being asked to access IR stream '2'.
Here is an example C++ script that accesses both left and right streams:
rs2::config cfg;
cfg.enable_stream(RS2_STREAM_INFRARED, 0);
cfg.enable_stream(RS2_STREAM_INFRARED, 1);
rs2::pipeline pipe;
pipe.start(cfg);

I've attempted using the code snipped you posted but it makes no difference to the outputted error.

Is the USB port on your Android device USB 3 or USB 3, please?

It's a USB 3.1 port according to the specification.

On a USB 2 connection with D435i, only the left IR is available.  I just tested my own D435i with the RealSense Viewer on a USB2 connection and confirmed to myself that I wasn't mis-remembering this.

It makes me wonder if your Android tablet is mis-identifying the D435i in its USB 3 port as a USB 2 device and so making right IR inaccessible to your program and triggering the "couldn't resolve request" message (as support for it is absent in USB2 mode).

I accessed a shell on the Android device and I think this indicates that it's connecting over USB 3:
DEVICE:/ # cat /sys/bus/usb/devices/3-1/manufacturer
Intel(R) RealSense(TM) Depth Camera 435i
DEVICE:/ # cat /sys/bus/usb/devices/3-1/version
 3.20

I'm not entirely sure of the best way to make sure of this on Android though.

There was a RealSense Android user who built the Capture app on their Android device to check the camera speed.
https://github.com/IntelRealSense/librealsense/issues/4091#issuecomment-502467123
I am off-shift now but will be back in 7 hours from the time of writing this and be happy to continue the support conversation if you require further assistance.  Good luck!

Hi @kudansam   Do you require further assistance, or is it okay to close this case now?   Thanks!

I couldn't get both cameras to work on Android, either running live from the camera or from a recorded rosbag file. Unfortunately I didn't have time to debug the library so had to move to another solution.

Ok, thank you very much for the update.  I will close this case then.  I'm sorry that you did not achieve the results that you were aiming for.


Rework UUIDUtils class

The methods in that class should not just throw a random exception but instead return an object (result: Result, uuid: UUID?) where Result is an enum that has values like SUCCESS, UNKNOWN_PLAYER, ERROR.

Nice rework, I always wanted to clear up this mess.


[Refactor] Rename fetch smartcontract data coordinator with provider suffix #4529

Closes #4529

@oa-s is this related only to NativeCryptoCurrencyBalanceProvider? or the rest too?

@oa-s the rest too. Generally. Let provider bring a fallback when we don’t have a better name.

@hboon pr is ready for review


Support passing multiple config files to compiler plugin

Fixes #6157

Warnings

:warning:
It looks like this PR contains functional changes without a corresponding test.

  Generated by :no_entry_sign: dangerJS against 72f8e59ca6735dd58e8b769e67dd96ea8065584c


Northwestern Fix

-Fixed logo to comply with the university’s guidelines
-fixed broken link for the university as well

Your branch is conflicting i cannot merge it. #35 seem to have the same changes so I'm going to merge it.
Thanks for the quick reaction though.

closed by #35


Bug: "Open in new window/tab" command is not working for tags in the sidebar

Description
"Open in a new tab" and "Open in a new Window" commands aren't working for Tags.
Steps To Reproduce

Right click on a tag in Tags Sidebar section
Select Open in new window/pane
See an error is displaying

Steps to fix

Commands should work properly

Files Version
Version <IP_ADDRESS> OS Version: 10.0.22621.521
Windows Version
Windows 11 Home 22H2 22621.521

Is this still an issue in v2.4?

Everything works fine!


Badge colors

The following changes since commit 3f71b63b80860bf25316ca0f453265d35503a537:
Merge pull request #104 from Code4HR/candidate-responses (2016-04-14 08:13:07 -0400)
are available in the git repository at:
https://github.com/ryayak1460/okcandidate.git badge-colors
for you to fetch changes up to 0c5a39060e3345e1d20e5b17379b1acba01d9445:
Include Docker and question updates (2016-04-14 11:27:00 -0400)

Ryan Y (2):
Change rating colour based on match percentage
Include Docker and question updates
.../js/components/atoms/CandidateMatchRating.jsx   |  15 ++-
.../components/atoms/CandidateMatchRatingSpec.js   | 111 +++++++++++++++++++++
2 files changed, 125 insertions(+), 1 deletion(-)
create mode 100644 test/frontend/components/atoms/CandidateMatchRatingSpec.js

Affects #106.

@ryayak1460 We recently decided to treat develop as staging and master as production.  Can you update your PR?


"애플리케이션 보안 그룹" need to change “Application security groups”

Module: LAB_04-Implement_Virtual_Networking.md
Lab/Demo: LAB04
Task: 03
Step: 00
Description of issue
"애플리케이션 보안 그룹" need to change “Application security groups”

Repro steps:

Hello contributor,
Thank you for your contribution! We are processing your suggestions and we will update you shortly.
Kind regards,
Microsoft Worldwide Learning Team


Support status subresource and ObservedGeneration.

Now that we have support for /status in both CRD and the dynamic client, we should use /status whenever it's available.
As of k8s 1.10, /status for CRD is behind an alpha feature gate, and is also optional on a per-CRD basis. If we neglect to use /status when it's available, our status update will be silently ignored. If we try to use /status when it's not available, our status update will fail. We should be able to tell whether /status is available for a given resource by looking at discovery, without requiring the user to configure anything on the Metacontroller side (they'll just enable /status in the CRD itself).
We should also set status.observedGeneration now that CRD is capable of incrementing metadata.generation (if the /status subresource is enabled for that CRD).
https://github.com/kstmp/metacontroller/blob/8c2b6730d8db89c5eba31bf180ebd9fbe93b3a5c/controller/composite/controller.go#L256-L271
Lastly, for controllers that support ObservedGeneration, we can consider an optimization to avoid syncing if the controller object is updated, but the spec hasn't changed (ObservedGeneration = Generation). For example, we currently might trigger a sync as a result of updating our own status.

Lastly, for controllers that support ObservedGeneration, we can consider an optimization to avoid syncing if the controller object is updated, but the spec hasn't changed (ObservedGeneration = Generation). For example, we currently might trigger a sync as a result of updating our own status.

What about comparing the ResourceVersion of the old and new objects to detect spec changes?

The ResourceVersion changes if anything in the object is updated, including metadata and status. Generation only changes if spec is updated; it's essentially a ResourceVersion scoped just to spec.

Another requirement for the design of this feature came up while talking to @danisla, and it applies both to CRDs and built-in resources that have /status subresources (like ReplicaSet).
If the hook response tries to set something in .status of a child object, we need to do one of two things if we know from API discovery info that the child resource supports /status:

If we choose to ignore the changes in .status, since updates there will be ignored on the main resource path anyway, we need to make sure ApplyUpdate() also ignores everything under .status (by reverting it after merging in the latest update). Otherwise, we will think we need to do an update, but the update will have no effect.

Or, if we choose to try to make the changes in .status actually work, we need to update them separately with UpdateStatus() instead of Update().

Historically, there was not much point to choosing option 2 because updating status on your child objects was considered an anti-pattern, as your changes would generally be clobbered by the child object's own controller anyway. However, there are now new patterns developing, such as Pod Ready++, where it does make sense to update the status of a child object.

@enisoc Thanks for the summary. For resolving this issue, I prefer option 1 (Pod Ready++ is not GA yet).


Provide parameter for retrying 404s automatically

The npm registry seems to suffer (at least in some geo-locations) of random 404s on package. This happens in Jenkins which affects everyone and also happens locally for me, from time to time.
Would be nice if this registry could provide a option to retry packages that gets 404s X times before actually trusting it.
Then we could start deploying npm-on-ipfs in the Jenkins infra.

https://github.com/ipfs/infrastructure/issues/432 will also need to be done

Hm, this feature is not blocked by having a S3 bucket right? We could still just have a large disk and things would work fine.

When npm was 500k packages it was estimated to need 3.5TB to mirror it.  It's now about 800k packages and 8TB in size.  Each worker can potentially be mirroring all of it, so it would have to be a very, very large disk.
Best just to set up the S3 bucket.

@achingbrain but we don't have to mirror the full npm registry, for the purpose of CI at least. It's only needed as a proxy for the packages we use in our projects. Don't know the full size of that but it won't be close to 8TB.

The idea is for it to watch skimdb.npmjs.com for updates to packages and eagerly fetch them, so it's going to be mirroring more stuff than just dependencies used by ipfs-related projects.
Even if that's turned off, we want it to be used by the public so predicting the size of the mirrored packages is hard.
I'd sleep better at night if it used a 'how-long-is-a-piece-of-string' sized storage engine than a disk on a server somewhere.

Released as 0.8.0 & deployed https://registry.js.ipfs.io/


tsc should halt on a wrong config file instead of start checking

Bug Report
I have a simple test case. I make an intentional error in tsconfig.json by providing

a fake path to the extends
or passing a wrong compilerOptions option.

But instead of expected halt with an appropriate error message, tsc is simply continuing to work! Rendering its output useless and confusing.
Without being properly configured, lots of includes obviously just stop working and produce dozens of errors which TSC displays BEFORE it alerts about your incorrect tsconfig.json — its primary source of instructions on how to operate.
I can't think about a single scenario when one would agree to get informed about some root problem on an N-th page among other (usually derived) errors. This must not work this way.
🔎 Search Terms
halt tsconfig error
🕗 Version & Regression Information
4.5.5
🙁 Actual behavior
tsc neither clearly complains nor halts on errors in tsconfig.json
🙂 Expected behavior
tsc must not proceed at all if tsconfig.json is wrong.

+1
Since the --showConfig flag actually renders the error it is unexpected that the compiler runs as if all is fine, even when e.g. it is unable to parse an extends option.


use integrated terminal on mingw/msys2

The integrated terminal is compatible with mingw/msys2. VS Code cpptools uses it and it's set in xmake-vscode for Linux already so it is maybe a good idea using it where possible.

Ok, BTW, If we use the integrated terminal, do we still need to set the gdb path?

Yes we do, this does not change that issue unfortunately.


Add functions to save and retrieve the peerStore to and from a db

Provide saving and loading capability to the raw Data of the peerStore to a db, using BoltDb
It is using the peerID as a key, and the Peer struct marshalled into JSON as a value
To visualize the database, you can use BoltDBWeb.

[x] PersistToDb()
[ ] LoadFromDb()

Regarding implementing the DB for the existing PeerMetrics, I think that it offers an interesting upgrade that will make the metrics a bit more organized and maintainable (right now, I'm just taking snapshots of the metrics and the peerstore every 12h).
At the moment, we have discovered around 25k Peers in the network, and the current optimization level of the memory keeps it under 3GB.

About the timing to introduce it as a feature in the crawler, I have few concerns:

First of all, it would imply checking the read/write speeds of the database. This way, we could ensure that updating information regarding a specific peer wouldn't slow down or even freeze the peer info update. Alternatively, a Peer cache could be implemented to complement the DB (which would mean a bit more work but is an optimal design).

Related to the first one, I have seen few comparisons between BoltDB and Badger, and it might be interesting to check the reading/writing ratio that we are expecting to choose wisely the most appropriated implementation (comparison post, thanks @kkhalil7 for the source)

We have to keep in mind the difference between the deeper analysis we can make with the analyzer python script and the light analysis we are currently exposing in the websites' dashboard. This script can be updated/upgraded with more features, but the DB shouldn't make the analysis too complex (from a data reading perspective).

Taking this into account, I would say that the workload level that we are experiencing should determine whether to do it now or later. Perhaps @kkhalil7 could be interested in keep working on it.
@alrevuelta How about linking this PR with the PeerMetrics refactoring one? Maybe it would be interesting to choose whether to keep the metrics in Memory or a given DB, just an idea, willing to know your point of view on the topic.

As commented in the description of the PR:

It is using the peerID as a key, and the Peer struct marshaled into JSON as a value

The idea of using the DB would be deprecating the actual sync.Map that keeps all the PeerStore in Memory. I would suggest replacing that sync.Map for DB interface described as:
BoltDB interface {
   ReadPeer()
   WritePeer()
   LoadOrWritePeer() ¿?
   ListPeers()
   DeletePeer()
}

So that the PeerStore would look like:
PeerStore {
   PeerDB -> (Bolt DB)
   PeerCount
   ConnectedPeers
   StartTime
   etc, etc
}

This could also be moved to a new storage?¿.go and had its own test units.
What do you guys @kkhalil7 @alrevuelta think about it, make sense?

Maybe we should implement first the same functions a sync.Map implements, so we don't have to change every instance of peerStore ?
These functions would be:
func (db *BoltDB) Delete(key interface{})
func (db *BoltDB) Load(key interface{}) (value interface{}, ok bool)
func (db *BoltDB) LoadAndDelete(key interface{}) (value interface{}, loaded bool)
func (db *BoltDB) LoadOrStore(key, value interface{}) (actual interface{}, loaded bool)
func (db *BoltDB) Range(f func(key, value interface{}) bool)
func (db *BoltDB) Store(key, value interface{})

And of course with the possibility of adding others

Makes sense to me

@alrevuelta How about linking this PR with the PeerMetrics refactoring one? Maybe it would be interesting to choose whether to keep the metrics in Memory or a given DB, just an idea, willing to know your point of view on the topic.

Maybe we can define a common interface for both the db and memory, so that they expose the same interface but implemented in a different way. Not sure why we would need both but its perhaps nice to have.

The idea of using the DB would be deprecating the actual sync.Map that keeps all the PeerStore in Memory. I would suggest replacing that sync.Map for DB interface described as:

BoltDB interface {
ReadPeer()
WritePeer()
LoadOrWritePeer() ¿?
ListPeers()
DeletePeer()
}

I really like this, and as @kkhalil7 suggest we can make it similar to what sync.Map offers. So that we have an interface with ReadPeer, WritePeer, DeletePeer that its implemented in two different ways. Using bolt db or using sync.map primitives.

moved PR to #25


multiple user features

fixes #730

Is it possible to add a test case for the multiple user feature scenario?


The predicted results in Output box is incomplete.

System Information (please complete the following information):

Windows OS: Windows-10-Enterprise-21H1
ML.Net Model Builder (Preview): <IP_ADDRESS>0201 (Main Branch)
Microsoft Visual Studio Enterprise 2019: 16.10.4
.Net: 5.0.302

Describe the bug

On which step of the process did you run into an issue: Output
Clear description of the problem: In Output box, the predicted value is incomplete for Value prediction and recommendation scenarios; no display predicted results for Image classification and Object detection scenarios

To Reproduce
Steps to reproduce the behavior:

Select Create a new project from the Visual Studio 2019 start window;
Choose the C# Console App (.NET Core) project template with .Net 5.0;
Add model builder by right click on the project;
Select Value prediction scenario to complete training;
Navigate to Evaluate page, click "Predict" button;
Looking at the Output box, found that only the label column (fare amount:) is displayed for the predicted value.

Expected behavior
In Output box, display the same predicted results (fare_amount: 16.31) as the Evaluate page.
Screenshots
If applicable, add screenshots to help explain your problem.
Value prediction:

Recommendation:

Additional context
For Image classification and Object detection scenarios, no print the predicted results in Output box, could you help to confirm if this is an issue?
Image classification:

Object detection:

Issue is not a priority. Closing for now. Console output is supplementary to the main UI experience.


Added the XAMPP topic

Please confirm this pull request meets the following requirements:

[x] I followed the contributing guidelines: https://github.com/github/explore/blob/main/CONTRIBUTING.md.
[x] I have no affiliation with the project I am suggesting (as a maintainer, creator, contractor, or employee).

Which change are you proposing?

[ ] Suggesting edits to an existing topic or collection
[x] Curating a new topic or collection
[ ] Something that does not neatly fit into the binary options above

Curating a new topic or collection

[x] I've formatted my changes as a new folder directory, named for the topic or collection as it appears in the URL on GitHub (e.g. https://github.com/topics/[NAME] or https://github.com/collections/[NAME])
[x] My folder contains a *.png image (if applicable) and index.md
[x] All required fields in my index.md conform to the Style Guide and API docs: https://github.com/github/explore/tree/main/docs

I think XAMPP should be added cause I think it is a good local server provider, features SQL databases and is overall a good thing for f.x PHP developers.

@smashwilson thanks for your suggestions!


Can we provide support for mdc

Is your enhancement request related to a problem? Please describe.
If we pass a tracing id in message header, is it possible to retrieve this info and put it into mdc, then all of log will see this id to solve some problems
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

It‘s not the duty of pulsar, you can do it by APM systems.

https://medium.com/asyncparadigm/logging-in-a-multithreaded-environment-and-with-completablefuture-construct-using-mdc-1c34c691cef0
maybe we can use this method to track one message flow

Making messages traceable is critical when all processing stages are asynchronous, and it would be even better to add metrics and statistics about cost time in each stage.

Did you try with a Interceptor that sets the MDC while receiving a message?


Add Instructions to README to Run on Real Device

@crugwiro @rlnsy Aidin wanted the instructions to run the project on a real device to be added to the readme. I added the mac instructions for running on an ios device. Can you guys verify these because it's been a while since I did this process from the beginning? Also have either of you ran the project on an android device and could add the instructions for that?

@cara-wong Thanks. I'll double check the ios process. I haven't ever tried running android. Can you verify it @crugwiro?

Also, these are *Mac instructions might be different on Windows.

@wynnset I tested this as well so if it works for you then it's ready to go.


Reenable simd neq.

SIMD Neq was disabled due to xsimd bug : https://github.com/xtensor-stack/xsimd/issues/805 . Re-enabling and moving to latest xsimd.

Can you also bring up the version of xsimd in internal repo?

@Yuhta Yes will import and test it out..


Incorrect import error is shown if to import prompt through chat import button

EPAM AI DIAL chat version
0.6.0
What happened?
Import attached file with a prompt through import button located on conversations panel -> "Import failed" error appears -> bug
epam_ai_dial_-_review_chat_prompt_4-8 (1).json
Note: if to export a prompt from DIAL and export it using conversation import -> "unsupported data format" error appears -> ok
QA: need to investigate the difference of structures and update our test cases accordingly
Expected result:

need to show correct error about unsupported formats;
Need to update the text of the error to be more specific. For example, "Import of prompts failed", "Import of conversations failed", "Import of prompts failed because of unsupported data format", "Import of conversations failed because of unsupported data format"

Confidential information

[X] I confirm that do not share any confidential information

Verified on STG successfully


classifier.classify() should return error when no match found

Classify() needs to implement a threshold mechanism for classify() errors. An error is a condition where the labels and probabilities are inconclusive, and a match cannot be obtained.
One way around this is by computing a priorProbabilities classification, and then comparing every getClassification result to the value of this priorProbabilities

What you describe seems more in line with application code and it is beyond what a classifier is or does.
But working out confidence levels on the predictions  is a direction ML packages are moving towards: http://scikit-learn.org/stable/modules/calibration.html
I'm retitling this and labeling a feature enhancement.


Better support for JSON files describing commands metadata

Improved JSON 'arguments' fallback in gencommand.py
Update generated command table from latest Redis
Support the output of redis utils/generate-commands-json.py
Update comments in gencommands.py about the JSON file format

Good comments about find_keys differences.

THanks. What abour "keynum"? It's the same difference. I didn't want to repeat the code logic in the comments though.

THanks. What abour "keynum"? It's the same difference. I didn't want to repeat the code logic in the comments though.

I think its fine with the added comments here.


Popover Weird Interactions

There's a few interactions with popovers that I'd like to list:

Hovering over a link in the backlinks section generates a popover modal, but contained within the backlinks section, as shown in the image below:

Popovers do not cover certain elements of the page, see below for images.
The callout icon is still shown, even though the popover is covering the callout section.

The below image shows the popover not covering the footer:

Point 2 could be a case of z-index getting confused(?)
Point 1 I'm not entirely sure how to fix this, and also I think it could be useful to have a way to disable popovers for certain sections of the page (like disabling them for backlinks, or disabling them for just Explore, etc.)

Problems have occurred since #906  was applied.

can you see if https://github.com/jackyzha0/quartz/commit/541b470cfc85c342ba8b7548d58d668b49d8dd85 fixes it?

Looks like the above commit fixed it! I'll close this ticket.

Looks like point 2 still is a problem (for me). I was able to just bump the callout icon back with z-index, but I'm not sure how to bump the footer back. This might just be a "me" issue though, seems like a transparency issue with the modal, or the background of the modal is totally transparent.

Can you provide a markdown reproduction? Seems to work on https://quartz.jzhao.xyz/features/callouts

Seems to be an issue the sidebar popovers, since the main middle section popovers work fine.

closed in https://github.com/jackyzha0/quartz/pull/1230


[spi_host] Request software/firmware controller chip select

Description
The chip select pin for the current spi host implementation does not support an easy way to independently assert or deassert the chip select pin in firmware. Right now, the spi host controls the chips select pin in hardware relative to transaction it is sending out.
It is common for the hardware interface layer for a spi host to expose controlling chip select behavior independently of transactions being sent. Here is an example from pigweed and another example from linux. Our own hil also assumes that chip select can be controlled independently. We may have a few workarounds, but we haven't fully confirmed their viability yet.
It would be beneficial if firmware could control the chip select output via register access, e.g. one bit for (hardware vs software control) and another bit for (software override high vs software override low).
@moidx @kupiakos @cfrantz  fyi

It would be beneficial if firmware could control the chip select output via register access, e.g. one bit for (hardware vs software control) and another bit for (software override high vs software override low).

The question here is how is it beneficial? Why does an override need to exist in the IP?
Just because there are APIs doesn't mean that there is a need to support a software override in the IP. I believe those APIs exist primarily for SPI controllers that don't have hardware CSB support (or that need to use a GPIO because their chip-select is not on a hardware-supported CSB pad).
Meanwhile, the IP already gives control of the timing of CSB relative to the transaction. For use cases, what is missing?

Perhaps we would be missing support for JESD252-style resets? Is that a critical use case? And are there others?

Our use case is a USB-SPIHost bridge over the USB debug connection to interact with the SPI bus that is connected to the OT chip. The USB host controls the data flow, and OT doesn't always know how many bytes will be in each logical SPI transaction (which consists of multiple USB packets). There are also clean up paths that need to de-assert chip select without sending a dummy packet either.

How difficult of a hardware change is this?
To my knowledge, we still haven't found a perfect work around to support our USB/SPI bridge protocol, but we may if we continue experimenting. I wouldn't rate this functionality at critical level, but I would rate it higher than nice-to-have for A1.
@kupiakos any thoughts about how needed this functionality is in A1 silicon, and how viable our current workarounds are in supporting out USB/SPI bridge?

This functionality is nice-to-have, and not necessary for A1. The refactors for our USB/SPI bridge are sufficient; they do have a code size impact for non-OpenTitan platforms.

It's a reversal of the dependency graph to require hardware to support features that can be abused for something that is not SPI transactions

I pretty fundamentally disagree here: hardware is designed in order to have firmware run on it, and having no way to override chip select strictly reduces the set of generically-designed firmware that can be ported to run on it.

We discussed this in the triage meeting and agreed that we cannot support this due to schedule constraints for M4. We'll create a feature request for future releases though.


The picture can't be parsed,Error Domain Code=10000

Hello,
I have a problem，The picture can't be parsed
this url can't be parsed: http://file-yrnd.17817.com/dev/54/1rMo716iTF3yFadhfsCmDnZVMFn/161879514868459870.jpg?size=400%3A352\u0026x-oss-process=style%2Ftest
error info : Error Domain Code=10000
but this url can be parsed :
http://file-yrnd.17817.com/dev/54/1rFDg2DcBqAqLHmb4ilTb9gd6ax/16185630508895122.jpg?size=900%3A1547\u0026x-oss-process=style%2Ftest

Your first link points to a webp image in fact.

It is not built-in supported on iOS until iOS 14. If you want to show it in any earlier versions, try to use a WebP plugin such as https://github.com/Yeatse/KingfisherWebP.
Check more in the related FAQ page.


Protocols broken in some cases

A deftype implementing a protocol found in the same assembly will render the assembly unloadable.
(ns cannotadd)

(defprotocol ITestProtocol
  (test-method [a]))

(deftype TestType []
  ITestProtocol
  (test-method [a] a))

This will successfully compile and emit a cannotadd.clj.dll assembly, but Mono will refuse to load it complaining that some types could not be loaded. Further inspection with different types and using
(.GetType (Assembly/Load "cannotadd.clj") "cannotadd.TestType")

shows that only types that implement a protocol defined in the same assembly seem to break.
The reasons are not clear to us. It seems to have something to do with the stub class generated for TestType. Removing it solves the problem, but type hinting suffers.

this is my least favorite so far

"type hinting suffers" means we resort to runtime reflection for almost everything


Added Blob.GetNoAlloc

Adding GetNoAlloc for blob API

Hi, thank you for your PR. We will review it as soon as possible.

Looks nice! Vianney, I let you merge and add anything (more tests?) you judge necessary.
Thank you for the PR @0xE0F.


Custom Superflat settings not transferred from bedrock

Chunker Version
1.4.0-main-86becbf
Input World Version
Bedrock 1.21.40
Output World Version
Java 1.21.3
Platform / Operating System
Windows 11
Issue Description
My bedrock world has custom superflat layers, and those layers are not being transferred to java edition, and just set to the defaults.

This currently isn't a feature of Chunker, the generation features change quite a bit over the history of Java / Bedrock and doesn't quite match in parity making it more complicated to implement, it's a consideration for the future but currently isn't planned.
**As a workaround: **
You can either make a new world with the layers you want and the same settings and copy over the level.dat or use an NBT editor like NBTExplorer to copy the "WorldGenSettings" tag.


feat: add multi-nonce support

Stack:

#429 ⬅
#428
#427
#426

⚠ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

This change is

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (spr/main/ba871431@76655eb). Learn more about missing BASE report.

Additional details and impacted files
@@                 Coverage Diff                  @@
##             spr/main/ba871431     #429   +/-   ##
====================================================
  Coverage                     ?   83.64%
====================================================
  Files                        ?       37
  Lines                        ?     1730
  Branches                     ?     1730
====================================================
  Hits                         ?     1447
  Misses                       ?      206
  Partials                     ?       77

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Update logo to square version to comply with OSI trademark (and remove outdated logos to avoid confusion)

Wasn’t able to fully test it, please check everyone. cc @bnvk @simonv3 @massonpj @evalica @grahamperrin @jdittrich @belenbarrospena :)
This is to comply with OSI guidelines as per https://github.com/opensourcedesign/events/issues/43#issuecomment-283807989, and using the square logo as proposed in https://github.com/opensourcedesign/organization/issues/68#issuecomment-293296056
I already changed it on https://twitter.com/opensrcdesign, https://github.com/opensourcedesign and https://opencollective.com/opensourcedesign, the forum at https://discourse.opensourcedesign.net/ uses the square logo too.
(Also, it would be great if the images related to the search-article could be moved to a subfolder so we only have the logos in the root images folder.)

@jdittrich for critical stuff like this in the future let’s ideally have some more people than one review it. :)

Missing from the Website:

the SVG in h1.brand-heading

.navbar-brand.page-scroll > .logo SVG

Yeah, it seems the opensourcedesign-logo.svg is linked for the frontpage at https://github.com/opensourcedesign/opensourcedesign.github.io/blob/master/index.html#L11 and the header at https://github.com/opensourcedesign/opensourcedesign.github.io/blob/master/_includes/header.html#L9
And on the page it gets included. Is anything required to build the page, or should it not be automatic after a push? cc @bnvk @simonv3 I assumed this doesn’t need any building because also the favicon and other things seem to work fine.

I think for some reason it's organized in an includes? It's referencing this file: https://github.com/opensourcedesign/opensourcedesign.github.io/blob/master/_includes/img/opensourcedesign-logo.svg
I can pull it down now and try to fix it, should fairly straightforward (famous last words).

PR here: https://github.com/opensourcedesign/opensourcedesign.github.io/pull/93