Introduce graph rewrite for mixture sub-graphs defined via IfElse Op

Closes #76.
Akin to #154, this PR introduces a node_rewriter for IfElse. Effectively, this builds on the recently added switch_mixture_replace to accommodate mixture sub-graphs as the same essence but defined with a different Op: IfElse. Below is an example of the new functionality.
import aesara.tensor as at
from aesara.ifelse import ifelse

from aeppl.joint_logprob import joint_logprob

srng = at.random.RandomStream(seed=2320)

I_rv = srng.bernoulli(0.5, name="I")
X_rv = srng.normal(-10, 0.1, name="X")
Y_rv = srng.normal(10, 0.1, name="Y")

Z_rv = ifelse(I_rv, X_rv, Y_rv)
Z_rv.name = "Z"

z_vv = Z_rv.clone()
i_vv = I_rv.clone()

logp = joint_logprob({Z_rv: z_vv, I_rv: i_vv})
print(logp.eval({z_vv: -10, i_vv: 0})) # 0.6904993773247732
print(logp.eval({z_vv: -10, i_vv: 1})) # -19999.309500622676

I added many tests; I used test_hetero_mixture_categorical for inspiration on what to cover. I have yet to do a thorough filtering on what exactly is needed. I seem to be running into issues with variable lifting, since computations are not exactly identical, making equal_computations to yield False. The reasons for failing tests can be more fundamental; I will look into this slowly.

Here are some notes regarding why some tests are failing. The discrepancy between graphs occur here:

The first inputs to MixtureRV can be NoneConst or TensorConstant{0}.
Discrepancy in component shapes (e.g. TensorConstant{(1,) of -10.0} vs. TensorConstant{-10.0}).

This comment would serve as a reminder on what I am stuck on before the upcoming meeting.

 I'm investigating one of my failing test cases and I probably have forgotten many details just due to time passing... Consider the following code.
srng = at.random.RandomStream(29833)

X_rv = srng.normal(loc=[10, 20], scale=0.1, size=(2,), name="X")
Y_rv = srng.normal(loc=[-10, -20], scale=0.1, size=(2,), name="Y")

I_rv = srng.bernoulli([0.9, 0.1], size=(2,), name="I")
i_vv = I_rv.clone()
i_vv.name = "i"

Z1_rv = at.switch(I_rv, X_rv, Y_rv)
z_vv = Z1_rv.clone()
z_vv.name = "z1"

fgraph, _, _ = construct_ir_fgraph({Z1_rv: z_vv, I_rv: i_vv})
aesara.dprint(fgraph.outputs[0])

yields
SpecifyShape [id A]
 |MixtureRV{indices_end_idx=2, out_dtype='float64', out_broadcastable=(False,)} [id B]
 | |TensorConstant{0} [id C]
 | |bernoulli_rv{0, (0,), int64, False}.1 [id D] 'I'
 | | |RandomGeneratorSharedVariable(<Generator(PCG64) at 0x16488AB20>) [id E]
 | | |TensorConstant{(1,) of 2} [id F]
 | | |TensorConstant{4} [id G]
 | | |TensorConstant{[0.9 0.1]} [id H]
 | |normal_rv{0, (0, 0), floatX, False}.1 [id I] 'X'
 | | |RandomGeneratorSharedVariable(<Generator(PCG64) at 0x1648899A0>) [id J]
 | | |TensorConstant{(1,) of 2} [id F]
 | | |TensorConstant{11} [id K]
 | | |TensorConstant{[10 20]} [id L]
 | | |TensorConstant{0.1} [id M]
 | |normal_rv{0, (0, 0), floatX, False}.1 [id N] 'Y'
 |   |RandomGeneratorSharedVariable(<Generator(PCG64) at 0x16488A340>) [id O]
 |   |TensorConstant{(1,) of 2} [id F]
 |   |TensorConstant{11} [id K]
 |   |TensorConstant{[-10 -20]} [id P]
 |   |TensorConstant{0.1} [id M]
 |TensorConstant{2} [id Q]
bernoulli_rv{0, (0,), int64, False}.1 [id D] 'I'

Where does the SpecifyShape Op come from? My understanding is that the switch_mixture_replace rewrite gets called and returns MixtureRV{indices_end_idx=2, out_dtype='float64', out_broadcastable=(False,)}.0 in this case, so the SpecifyShape Op must come from elsewhere...

Hey, thanks for revisiting the PR! Do you mean running the code on this PR branch? If I run your code snippet on main I get the following result:
Elemwise{switch,no_inplace} [id A]
 |bernoulli_rv{0, (0,), int64, False}.1 [id B] 'I'
 | |RandomGeneratorSharedVariable(<Generator(PCG64) at 0x7F0239D0E880>) [id C]
 | |TensorConstant{(1,) of 2} [id D]
 | |TensorConstant{4} [id E]
 | |TensorConstant{[0.9 0.1]} [id F]
 |normal_rv{0, (0, 0), floatX, False}.1 [id G] 'X'
 | |RandomGeneratorSharedVariable(<Generator(PCG64) at 0x7F023B681B60>) [id H]
 | |TensorConstant{(1,) of 2} [id D]
 | |TensorConstant{11} [id I]
 | |TensorConstant{[10 20]} [id J]
 | |TensorConstant{0.1} [id K]
 |normal_rv{0, (0, 0), floatX, False}.1 [id L] 'Y'
   |RandomGeneratorSharedVariable(<Generator(PCG64) at 0x7F0239D0DEE0>) [id M]
   |TensorConstant{(1,) of 2} [id D]
   |TensorConstant{11} [id I]
   |TensorConstant{[-10 -20]} [id N]
   |TensorConstant{0.1} [id K]

Hey, thanks for revisiting the PR! Do you mean running the code on this PR branch? If I run your code snippet on main I get the following result:

Yes, running the code on this branch! The graph rewrite for Switch mixtures on main does not work for non-scalar components...

Have you considered dispatching Switch and Ifelse in separate functions for now? It may make it easier to progress without breaking Switch so you always have a working point of comparison. (you can keep the tests together)

Yes, but I felt like that graph rewrite for both would be very similar. I can separate them as I work through them, for now...

You will also need to resolve the (small) merge conflict due to the new joint_logprob interface, but this should be easy.

Okay sounds good!

Yes, but I felt like that graph rewrite for both would be very similar. I can separate them as I work through them, for now...

They likely will, and we may want to merge them later. But I think it would be easier for you to move from one stable state to another, changing one thing at a time, and always keeping a reference implementation (Switch) working.

I just rebased my code. I am working on having Switch/IfElse-induced mixture subgraphs yield the same canonical (or IR? the graph obtained after running switch_mixture_replace) graph as if it were defined as a Subtensor. The SpecifyShape Op still comes up in the example above and I believe that I should modify my rewrite such that it does not show up. Is there a way to check what sequence of graph rewrites have been applied?

Of course: https://aesara.readthedocs.io/en/latest/extending/graph_rewriting.html#detailed-profiling-of-aesara-rewrites

Of course: https://aesara.readthedocs.io/en/latest/extending/graph_rewriting.html#detailed-profiling-of-aesara-rewrites.
Alternatively, you can add a breakpoint here, aesara.dprint(fgraph), note the index of the SpecifyShape node, then inspect the node using node = fgraph.toposort()[index] and then node.tag may contain information about the rewrite that created it.

There's also with aesara.config.change_flags(optimizer_verbose=True): ....  I use that a lot.

Adding to this, you can set any reasonable IDE up so when you run tests it will open a debugger console whenever it hits a breakpoint or fails. If you don't have that in place already, spend some time setting it up; it was a huge boost in my productivity.

Adding to this, you can set any reasonable IDE up so when you run tests it will open a debugger console whenever it hits a breakpoint or fails. If you don't have that in place already, spend some time setting it up; it was a huge boost in my productivity.

Thanks for the tip. I also saw your recent related tweet 😅
As for this PR, I am thinking that it's best to close it to 1) split the tasks into smaller sub-PRs (I felt like too much was going on at once) and 2) address some other issues that came up. As for the latter, I divided them into subsections below. Any guidance would be helpful...
Reworking switch_mixture_replace
Firstly, switch_mixture_replace isn't all correct... I only considered scalar indices and components. For instance, to make equal_computations yield True, I used a as_nontensor_scalar wrapper for indices which would not work in general.
https://github.com/aesara-devs/aeppl/blob/473c1e6c891188cab3b878798c8b47fbb471c14e/aeppl/mixture.py#L340-L342
SpecifyShape Op
The appearance of the SpecifyShape Op seems to be new... perhaps due to this recent addition to Aesara? Maybe a good first step would be to replace out_broadcastable in MixtureRV with the corresponding static shapes, if available. Would this be a good first step?
https://github.com/aesara-devs/aeppl/blob/473c1e6c891188cab3b878798c8b47fbb471c14e/aeppl/mixture.py#L180-L197
Mismatch in MixtureRV shapes generated by Switch vs. at.stack
With the hot fix replacing broadcastable with shape, the MixtureRV shapes seem to be different if they are generated by a Switch vs. Join. Is this because subtensors don't have static shape inference yet? That would be my guess (Aesara issue #922?), but I'm not sure. Below is an example that I created using this branch's additions.
import aesara.tensor as at
from aeppl.rewriting import construct_ir_fgraph
from aeppl.mixture import MixtureRV

srng = at.random.RandomStream(29833)

X_rv = srng.normal([10, 20], 0.1, size=(2,), name="X")
Y_rv = srng.normal([-10, -20], 0.1, size=(2,), name="Y")

I_rv = srng.bernoulli([0.99, 0.01], size=(2,), name="I")
i_vv = I_rv.clone()
i_vv.name = "i"

Z1_rv = at.switch(I_rv, X_rv, Y_rv)
z_vv = Z1_rv.clone()
z_vv.name = "z1"

fgraph, _, _ = construct_ir_fgraph({Z1_rv: z_vv, I_rv: i_vv})

assert isinstance(fgraph.outputs[0].owner.op, MixtureRV)
assert not hasattr(
    fgraph.outputs[0].tag, "test_value"
)  # aesara.config.compute_test_value == "off"
assert fgraph.outputs[0].name is None

Z1_rv.name = "Z1"

fgraph, _, _ = construct_ir_fgraph({Z1_rv: z_vv, I_rv: i_vv})

assert fgraph.outputs[0].name == "Z1-mixture"

# building the identical graph but with a stack to check that mixture computations are identical

Z2_rv = at.stack((X_rv, Y_rv))[I_rv]

fgraph2, _, _ = construct_ir_fgraph({Z2_rv: z_vv, I_rv: i_vv})

fgraph.outputs[0].type.shape # (2,)
fgraph2.outputs[0].type.shape # (None, None)

IfElse mixture subgraphs
Given that IfElse requires scalar conditions, maybe it would be good to start with them instead of refining switch-mixtures... Happy to hear any thoughts about these points above. I feel like there's a lot going on, and it can be challenging to address all at once (especially given that this is continuation from this summer's work...)

PRs that touch on core mechanisms in Aesara, or simply that implement big changes, can easily get frustrating. Breaking the problem down like you did is a great beginning. Do you mind if I keep it open and I come back to you later next week at least with some questions, maybe some insight?

PRs that touch on core mechanisms in Aesara, or simply that implement big changes, can easily get frustrating. Breaking the problem down like you did is a great reaction to this situation. Do you mind if I keep it open and I come back to you later next week at least with some questions, maybe some insight?

Of course, not a problem at all!

PRs that touch on core mechanisms in Aesara, or simply that implement big changes, can easily get frustrating. Breaking the problem down like you did is a great reaction to this situation. Do you mind if I keep it open and I come back to you later next week at least with some questions, maybe some insight?

@rlouf Just a quick update that @brandonwillard and I conversed recently, hence the recent force-push. The current focus is to ensure that the current mixture indexing operations via at.switch and at.stack match what NumPy would yield with np.where. For now, we leverage mixture_replace in constructing tests that should be passing and then further optimize the switch_mixture_replace rewrite. Afterwards, we can add the IfElse rewrite which should be similar to switch_mixture_replace but the different length of branch shapes (with same dimension) would need a bit of thought.

Glad to hear this is back on track!


Optimization signature

By trusting that the signature we just generated is valid, we can avoid gas usage by validating it right after generating it.

... so you can set order.owner to the address that you don't control. Still cannot figure out what that splitPercentage is about.

The splitPercentage is a local copy of the global value set in the LoopringProtocol.sol file.  A user can pay a miner a fixed fee or a margin split.

I am closing this and will reconfirm in a separate branch that the MARGIN_SPLIT_PERCENTAGE_BASE change makes a difference and resubmit if it does.


Prefetching doesn't work :(

Hey, thanks for contributing to Koel! To save time for both of us, please make sure these checkboxes are checked before submitting the issue:

[yup] You have read and followed closely the Wiki, Upgrade Guide, as well as Troubleshooting
[mhm] The issue has not been reported before
[i run linux] This is not a "how to install on Windows" or "why is my npm messed up" question
[you bet] You're a cool person

All checked? Now also make sure your issue

[sure thing] Is associated with a version. Or better yet, a commit. - 3.5.5 (git checkout)
[you bet] Is as detailed as possible (ahem... OS, browser, steps to reproduce, maybe?)
[x] Includes the error output if it's a bug/error report ("Whoops!" is not very helpful, you know)
[muy bien.] Is in English, 因为我不说中文。

So, prefetching doesn't work. I've been listening to an EP, and on my stellar 200 Mbps local Wi-Fi, Koel isn't prefetching the song, and playing the next song. Since my Wi-Fi is fast, music will not play for a second (500-1000ms), but I could imagine this being worse on a mobile network (Verizon)
OS on the server is Ubuntu Server 16.04.2 LTS. On the client side, Kubuntu 16.10, using Chrome 56.

Bit of an update, either time is flying by too quickly, or the prefetch delay is almost gone. Not sure which of the two it is, but...
I'll listen more closely.

Weird. It's working perfectly for me, Chrome 56, Mac.

Huh. I'll certainly pull up the network tab, and see what's going on.
I don't know if having another tab open causes an issue, but I'll try it in the foreground/background in Chrome.

So, as seen here, it appears as if Koel is prefetching the next song, but when the next song begins to play, Koel fetches the file again (for some reason), but there's still a delay between songs. I'm going to try and throttle Chrome, and truly see if prefetching is enabled.

Here's what I'm generally noticing. Koel indeed prefetches the song that's upcoming next, but after a song has ended, and it moves on to the next song, Koel again fetches the song, which is really odd. Anywhom, it's happened 100% of the time, when throttling Chrome down to "Good 4G".

Hmm. I'll take a look at this. Maybe there's a change in the API, or maybe the implementation is wrong from the beginning (which is unlikely). Thanks for the very detailed issue report!

No problem! Always happy to help. Also, I'm seeing some ERR_CONTENT_LENGTH_MISMATCH errors coming up in Chrome's network waterfall, when Koel is running in the background, so that's interesting.

Yeah, that's very normal.

Yes, it seems to be fetching twice for me, and there is delay between songs. I am running on Chrome 56 on Windows 8.

What streaming method are you guys using? x-sendfile and x-accel-redirect work for me. For php (default) looks like we need a way to cache the content streamed by PHP, which I don't know how to do.

Yes, I am running using php. Haven't gotten the chance to try x-sendfile and x-accel-redirect yet.

I'm using what's included with Koel (so I assume php).


Update create-failover-cluster.md

Certificate Backup Considerations after deploying AD Detached Cluster

Confirmed with product team, this is ready to publish.


About training on cifar100

Could you tell me how to train resnet18 from resnet 34 on cifar100?
And by the way,  do these operations only need to be done on the last layer of feature maps?

Hi @PilgrimMay,
The distillation is performed on the last layer.
We built the model of cifar100 on another codebase. Currently we have on plan to make it public because it uses some commercial code, i.e., the Bayesian search.
I would suggest using the  RepDistiller to develop the cifar100 model by following this repo.


GHDL plugin

Does it include support for VHDL using GHDL plugin?

Not at the moment, but we will look into the feasibility.


Any chance of Winrt Project Templates not specific  DirectX

I was very pleased to find winrt/cpp nuget package now available, and seems to work without need for winrt project side header includes.
But would be very nice to have winrt project template that is not specific to 3D all i could find were Directx winrt templates.
Currently i use a native win32 c++ project for winrt with project settings as per winrt  ReadMe doc
except now i use Nuget winrt instead of adding headers directly.
I am doing some work on uwp diagnostics /etw providers and my code compiles fine, but is failing but never returns ffrom deep inside winrt call at runtime, whilst registring logenabled event handler . (inti apartment call was fine code never returns from first event registration )
Again The short version of my question is Winrt project templates for non directx specific app
cheers

Providing project templates for UWP and Desktop apps using C++/WinRT is on our backlog. We'll get to them eventually. We have a lot of things we want to do. :)


Fix benchmark spec

references commit 3259b71a88fb8e72ee05797417990b0fa7498a25

Did you stop drinking coffee and started to c0de? :-)

My first exactly 50 commits were cafe, then I switched to c0de for the next 50 :)

Thanks!


TOMEE-2960 added basic github actions for tomee-7.1.x branch

testing jira...ignore me :)

testing jira...ignore me :)

please ignore, testing jira fix

please ignore, testing jira fix

Jira worklog test comment, please disregard.

Jira worklog test comment, please disregard.

On the master, we define an additional step
    steps:
    - uses: actions/checkout@v2
    - name: Set up JDK 1.8
      uses: actions/setup-java@v1
      with:
        java-version: '8'

to create a tmp directory and set it in the subsequent steps as java.io.tmpdir.
Question:

Do we need it here too?
Should we align the master workflow with this changes too? Separating the steps seems reasonable to me.

Really good questions @rzo1 .
The tmp directory in the github action I created on master was basically inherited form what I saw on buildbot: https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/1426

Do we need it here too?
I think we don't need it. My understanding is this was required in buildbot but now we are not using it on Jenkins and I don't think we need it on Github Actions.

Should we align the master workflow with this changes too?
Yes, I think we should remove this from master: https://github.com/apache/tomee/blob/master/.github/workflows/main.yml#L23-L24

Separating the steps seems reasonable to me.
I like it too, I'm familiar with Jenkins pipelines, and having the ability to see specific step when something went wrong is easier than trying to search within a unique file with a lot of data. To implement this approach on master will require to double-check the result we currently have when executing the profile created a couple of weeks ago that has been useful for TCK related work: -Pstyle,rat

On the master, we define an additional step
    steps:
    - uses: actions/checkout@v2
    - name: Set up JDK 1.8
      uses: actions/setup-java@v1
      with:
        java-version: '8'

to create a tmp directory and set it in the subsequent steps as java.io.tmpdir.
Question:

Do we need it here too?
Should we align the master workflow with this changes too? Separating the steps seems reasonable to me.

Really good questions @rzo1 .
The tmp directory in the github action I created on master was basically inherited form what I saw on buildbot: https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/1426

Do we need it here too?
I think we don't need it. My understanding is this was required in buildbot but now we are not using it on Jenkins and I don't think we need it on Github Actions.

Should we align the master workflow with this changes too?
Yes, I think we should remove this from master: https://github.com/apache/tomee/blob/master/.github/workflows/main.yml#L23-L24

Separating the steps seems reasonable to me.
I like it too, I'm familiar with Jenkins pipelines, and having the ability to see specific step when something went wrong is easier than trying to search within a unique file with a lot of data. To implement this approach on master will require to double-check the result we currently have when executing the profile created a couple of weeks ago that has been useful for TCK related work: -Pstyle,rat

Hi @rzo1 ,
As a follow up on this conversation, I opened https://github.com/apache/tomee/pull/758 to remove the tmp folder creation on master.  I tried to separate also the checkstyle, pmd and rat into individual steps but currently mvn checkstyle:check -Pstyle throws 288 Checkstyle violations because on master all the check seems to be now reviewed under -Pstyle,rat.
As for my next steps, I want to jump back to Jenkins CI to make sure we also have PR feedback from Jenkins because it seems the PR job is broken again https://ci-builds.apache.org/job/Tomee/job/Pull Requests/

Hi @rzo1 ,
As a follow up on this conversation, I opened https://github.com/apache/tomee/pull/758 to remove the tmp folder creation on master.  I tried to separate also the checkstyle, pmd and rat into individual steps but currently mvn checkstyle:check -Pstyle throws 288 Checkstyle violations because on master all the check seems to be now reviewed under -Pstyle,rat.
As for my next steps, I want to jump back to Jenkins CI to make sure we also have PR feedback from Jenkins because it seems the PR job is broken again https://ci-builds.apache.org/job/Tomee/job/Pull Requests/


Enable Testing standard checks like code coverage etc. to be a part of the build/release process

Desired Behavior
Please describe the new behavior stream-registry project should have.
Benefits
Please list the benefits of updating the stream-registry project
to have the new behavior. E.g.:

Builds more quickly
Enable compatibility with a new platform

@vinayakponangi, spotless plugin may help out here.
https://github.com/diffplug/spotless/tree/master/plugin-maven

@vinayakponangi can you put out a few details of what you are thinking about here from a dev perspective? Then maybe someone out there can pick this up and send us a PR.
@everyone if the community has ideas of what they'd like to see here, open for feedback.
This need not be something huge, just something to get started with.


feat(#129): Added HTTP metrics in Wall-API

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (ad7c3e2) 23.36% compared to head (a342e5d) 23.36%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #132   +/-   ##
=======================================
  Coverage   23.36%   23.36%
=======================================
  Files           9        9
  Lines         107      107
  Branches       15       15
=======================================
  Hits           25       25
  Misses         78       78
  Partials        4        4

Flag
Coverage Δ

wall-front
23.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


GPIO set (IDFGH-5552)

----------------------------- Delete below -----------------------------
Reminder: If your issue is a general question, starts similar to "How do I..", or is related to 3rd party development kits/libs, please discuss this on our community forum at https://esp32.com instead.
INSTRUCTIONS
Before submitting a new issue, please follow the checklist and try to find the answer.

[x] I have read the documentation ESP-IDF Programming Guide and the issue is not addressed there.
[x] I have updated my IDF branch (master or release) to the latest version and checked that the issue is present there.
[x] I have searched the issue tracker for a similar issue and not found a similar issue.

If the issue cannot be solved after the steps before, please follow these instructions so we can get the needed information to help you in a quick and effective fashion.

Fill in all the fields under Environment marked with [ ] by picking the correct option for you in each case and deleting the others.
Describe your problem.
Include debug logs from the "monitor" tool, or coredumps.
Providing as much information as possible under Other items if possible will help us locate and fix the problem.
Use Markdown (see formatting buttons above) and the Preview tab to check what the issue will look like.
Delete these instructions from the above to the below marker lines before submitting this issue.

IMPORTANT: If you do not follow these instructions and provide the necessary details, your issue may not be resolved.
----------------------------- Delete above -----------------------------
Environment

Development Kit:      [ESP32-Wrover-Kit|ESP32-DevKitC|ESP32-PICO-Kit|ESP32-LyraT|ESP32-LyraTD-MSC|none]
Kit version (for WroverKit/PicoKit/DevKitC): [v1|v2|v3|v4]
Module or chip used:  [ESP32-WROOM-32|ESP32-WROOM-32D|ESP32-WROOM-32U|ESP32-WROVER|ESP32-WROVER-I|ESP32-WROVER-B|ESP32-WROVER-IB|ESP32-SOLO-1|ESP32-PICO-D4|ESP32]
IDF version (run git describe --tags to find it):
// v3.2-dev-1148-g96cd3b75c
Build System:         [Make|CMake|idf.py]
Compiler version (run xtensa-esp32-elf-gcc --version to find it):
// 1.22.0-80-g6c4433a
Operating System:     [Windows|Linux|macOS]
(Windows only) environment type: [MSYS2 mingw32|ESP Command Prompt|Plain Command Prompt|PowerShell].
Using an IDE?: [No|Yes (please give details)]
Power Supply:         [USB|external 5V|external 3.3V|Battery]

Problem Description
//Detailed problem description goes here.
Expected Behavior
Actual Behavior
Steps to reproduce

step1
...

// If possible, attach a picture of your setup/wiring here.
Code to reproduce this issue
// the code should be wrapped in the ```cpp tag so that it will be displayed better.
#include "esp_log.h"

void app_main()
{

}

// If your code is longer than 30 lines, GIST is preferred.
Debug Logs
Debug log goes here, should contain the backtrace, as well as the reset source if it is a crash.
Please copy the plain text here for us to search the error log. Or attach the complete logs but leave the main part here if the log is *too* long.

Other items if possible

[ ] sdkconfig file (attach the sdkconfig file from your project folder)
[ ] elf file in the build folder (note this may contain all the code details and symbols of your project.)
[ ] coredump (This provides stacks of tasks.)

void app_main (void)
.....
gpio_config_t io_conf = {};
io_conf.intr_type = GPIO_PIN_INTR_DISABLE;
io_conf.mode = GPIO_MODE_OUTPUT;
io_conf.pin_bit_mask = GPIO_SEL_2 | GPIO_SEL_4 | GPIO_SEL_5 ;
io_conf.pull_down_en = 1;
io_conf.pull_up_en = 0;
gpio_config(&io_conf);
gpio_pad_select_gpio(GPIO_INOUTPUT_IO_1);
gpio_pad_select_gpio(GPIO_INOUTPUT_IO_2);
gpio_pad_select_gpio(GPIO_INOUTPUT_IO_3);

/* Set the GPIO pull mode */
gpio_set_pull_mode(GPIO_INOUTPUT_IO_1, GPIO_PULLDOWN_ONLY);
gpio_set_pull_mode(GPIO_INOUTPUT_IO_2, GPIO_PULLDOWN_ONLY);
gpio_set_pull_mode(GPIO_INOUTPUT_IO_3, GPIO_PULLDOWN_ONLY);

Output:
Slave starting in 3
Slave starting in 2
Slave starting in 1
␛[0;32mI (6301) gpio: GPIO[2]| InputEn: 0| OutputEn: 1| OpenDrain: 0| Pullup: 0| Pulldown: 1| Intr:0 ␛[0m
␛[0;32mI (6301) gpio: GPIO[4]| InputEn: 0| OutputEn: 1| OpenDrain: 0| Pullup: 0| Pulldown: 1| Intr:0 ␛[0m
␛[0;32mI (6301) gpio: GPIO[5]| InputEn: 0| OutputEn: 1| OpenDrain: 0| Pullup: 0| Pulldown: 1| Intr:0 ␛[0m
␛[0;31mE (6431) gpio: gpio_set_pull_mode(249): GPIO number error␛[0m
␛[0;32mI (6441) Device1: Driver installed␛[0m
␛[0;32mI (6441) Device1: Driver started␛[0m
Hi,
i configured almost everything are right but it seem the gpio_set_pull_mode always notifying error. I tried to look for this issue online but unsuccessful.
␛[0;31mE (6431) gpio: gpio_set_pull_mode(249): GPIO number error␛[0m
code running ok in order modules but only stage after bit_mask setting. What is wrong ? plz kindly help!

@jigsurfer Thanks for reporting. Would you please help provide more details as suggested in the issue template? Information like elf, sdk configuration, backtrace, log outputs, commit ID, hardware and etc. would help us debug further. Thanks.

@jigsurfer
[0;31mE (6431) gpio: gpio_set_pull_mode(249): GPIO number error␛[0m

Seems like you're getting a GPIO number error, meaning you're inputting an invalid GPIO number to gpio_set_pull_mode(). I suggest you double check that your GPIO_INOUTPUT_IO_X macros define to valid GPIOs. For specifics on valid GPIOs, see the GPIO_IS_VALID_GPIO macro here, or refer to the datasheet of the ESP32.
I don't think this is related to the GPIO driver so I'm closing this issue. Please feel free to reopen.


Ephemeral Keys

Implements #82

Add --temp-apikey option to generate an APIKey during startup
Prints the temporary key to the console like this:

D:\repos\github\dotnet-monitor-kelltrick [dev/pafenelo/ephemeralKeys]> D:\repos\github\dotnet-monitor-kelltrick\artifacts\bin\dotnet-monitor\Debug\netcoreapp3.1\dotnet-monitor.exe collect --temp-apikey
20:07:43 info: Microsoft.Diagnostics.Tools.Monitor.Startup[23]
      Generated one-time-use ApiKey for dotnet-monitor, use the following header for authorization:
      Authorization: MonitorApiKey DDcvBFMwz5zTQZIWkMQIAfwBvn270PTwgrvK/HReNrA=
20:07:43 warn: Microsoft.AspNetCore.Server.Kestrel[0]
      Overriding address(es) 'https://localhost:52323'. Binding to endpoints defined in UseKestrel() instead.

Add test hook to add commandline flag --temp-apikey, add test to exercise new test

@shirhatti can you take a look at the 2 user-visible strings here?

The new command line parameter is --temp-apikey
The log message is:

Generated one-time-use ApiKey for dotnet-monitor, use the following header for authorization:
Authorization: MonitorApiKey DDcvBFMwz5zTQZIWkMQIAfwBvn270PTwgrvK/HReNrA=

The log message is

Category/log level?

Also not a fan of "Microsoft.Diagnostics.Tools.Monitor.Startup". It probably warrants it's own category (or sub-category)?

I can't see an easy way of creating this log message it's own ILogger so it displays something nicer. This is probably something waiting for customer feedback on.


Kept a check in pattern matching for a mount of type loop

Signed-off-by: smriti<EMAIL_ADDRESS>For the mount type loop, I have put in a check to verify the mount point already exists in the system or not.
Description
This PR resolves issue - #10918
While iterating output of comman findmnt -rn for the mount of type loop  name of device is not included in the output. For example for a mount resource as following : -
mount "/var/www/mnt/disk3" do
  device "/mnt/public/hdat2cd_lite_71.iso"
  device_type :device
  options "loop"
  action %i{mount enable}
end

Once the mount action is performed, the output of findmnt -rn will be
/var/www/mnt/disk3 /dev/loop2 ext2 rw,relatime,seclabel
Hence in this case we cannot verify if the mount point exist by using this Regexp. where device_mount_regex is the name of device.
/\A#{Regexp.escape(real_mount_point)}\s+#{device_mount_regex}\s/
This makes mount resource non-idempotent in case of loop type mount and we get an error like this : -
[2021-01-21T19:57:25+00:00] TRACE: Special device 0 mounted as /var/www/mnt/disk1
[2021-01-21T19:57:25+00:00] TRACE: Found mount /mnt/public/hdat2cd_lite_71.iso to /var/www/mnt/disk3 in /etc/fstab
mount: /mnt/public/disk1.iso is already mounted

I made a change in one of the case check with regular expression as -
%r{\A#{Regexp.escape(real_mount_point)}\s+([/\w])+\s}
I introduced an if condition for options provided as loop or defaults and now the mount operation is idempotent. Output when mount is performed second time on the same directory is : -
  * mount[/var/www/mnt/disk3] action mount (up to date)
  * mount[/var/www/mnt/disk3] action enable (up to date)

Related Issue

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

[x] I have read the CONTRIBUTING document.
[x] I have run the pre-merge tests locally and they pass.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.
[x] All commits have been signed-off for the Developer Certificate of Origin.

This will need tests for this functionality so we don't introduce a regression later on.

later

What we probably need to do to really solve this issue is to look at the code in the request:
mount "/var/www/mnt/disk1" do
  device "/mnt/public/disk1.iso"
  device_type :device
  options 'loop'
  action [:mount, :enable]
end

We need to:

find something mounted to /var/www/mnt/disk1
validate that it is a /dev/loop* device
use losetup to find that /mnt/public/disk1.iso is associated with the /dev/loop in step 2
then set it as having been found

That will ensure that if someone mounts disk2.iso to /var/www/mnt/disk1 accidentally that we don't report that disk1.iso is mounted.
This should probably be a seperate conditional in the case statement that comes before the stuff dealing with the /proc issues that matches on the moutpoint and on /dev/loop* and then shell_out's to losetup to validatate the loopback device and the file in new_resource.device.

ok @tas50 I will check what could be missing.


feat(cli): add gitlab report format

Summary

This PR implements --reporter gitlab, which makes Biome output its findings in GitLabs Code Quality Report format (docs).
I had the need for this, googled a bit around, found https://github.com/biomejs/biome/discussions/128#discussioncomment-9378417, and decided to try implementing it myself.

Note that I have not that much experience with Rust, so if code does not conform to common Rust conventions, this is why. However, I'll happily implement any feedback.

Test Plan

Right now, I generated reports using a locally built version from this branch, and uploaded them to GitLab manually.
I'd also like to add automated unit tests, but I could need a little guidance here, this is my first time contributing, and again, not that familiar with the codebase or Rust.
The result of my manual tests can be seen in my demo repository on gitlab.com: https://gitlab.com/niclasvaneyk/biome-gitlab-code-quality-test/-/merge_requests/3

I generated a new Vite-based React App, setup Biome, and added a few issues
I generated the report.json file on main
I created a new branch, fixed a few issues, created new ones, and generated a new report.json

Now GitLab detects that a few issues are fixed by the MR, but also that it would generates new ones:

In theory, the results of the report are also used by GitLab in other places, but this would require a paid plan, which I don't have, so I cannot test them.
However, I manually checked, that e.g. the line numbers match up, so displaying the diagnostic messages inline with the code should also work correctly.
Other Implementations
I took some inspirations from other tools implementing the report. Especially using a set to ensure unique fingerprints was adapted from their code.

Ruff (also written in Rust) also provides first-party support for the GitLab format (relevant source code)
Eslint also has a pretty popular third-party package that implements the format (relevant source code)

For testing, I suggest creating a new file called reporter_gitlab.rs. You could copy this file: https://github.com/biomejs/biome/blob/main/crates/biome_cli/tests/cases/reporter_summary.rs
Of course, you would have to change the name of the functions and snapshot names, and the CLI command to --reporter=gitlab. The test will generate a snapshot, and you can check what it emits.

@ematipico  That looks exactly what I searched for, thanks! I'll mark this as ready once I'm done with the tests.

Hi @NiclasvanEyk, I rebase your PR. What's left in order to merge this new feature?

@ematipico Thanks for the rebase (and for reminding me this exists, I kind of forgot about this PR 🙈 ).
Right now, the snapshots do not look right to me, as the GitLab JSON report does not show up at all. I'll see how to include to have at least some tests, and then it could be merged.

@ematipico now everything works and the snapshots contain something useful. I switched from implementing Display to something similar to the gitlab reporter, where the biome console is used. I am not sure why, but the old approach did not show any output, so I tried a different one.

Thanks for the detailed review! I implemented some suggestions, and will revisit the approach as you mentioned. Will tag you once everything works.

@ematipico I think this is ready now. Similar to the github approach, I tried to move as much as possible into the display_gitlab.rs from biome_diagnostics.
However, the logic can not (at least to my understanding) completely moved inside a PrintGitLabDiagnostic struct, since the fmt method of biome_console::fmt::Display does not take a mutable reference to self. Therefore, the fmt method cannot have any side-effects, such as storing a reference to the new fingerprint. Since computing the fingerprints requires some information that is also required for building the GitLabDiagnostic struct which will eventually be serialized into JSON, I passed those in to prevent allocations of new Strings, etc.
I also adjusted e.g. the logic for computing line numbers to be more in line with the GitHub implementation.

@NiclasvanEyk Thank you for your contribution! After looking at the PR, I finally understood that gitlab expected a JSON as format, which wasn't clear at the beginning for me.
Refactor the code and avoid the custom printer for GitLab. I also fixed a couple of bugs, because the returned JSON wasn't valid (it had a trailing comma).
I also fixed the hasher by using a RwLock. This type is a valid resource when you need internal mutability, but you don't have a &mut self as the signature of your function.


Supply dynamic metadata

New Issue Checklist

[✓] Updated fastlane to the latest version
[✓] I have read the Contribution Guidelines

Issue Description
I am fetching metadata from an in-house API, and I need to pass it along to Google and iTunes. I was able to work out how to do so with iTunes using produce and deliver, but I'm struggling with Google Play. supply wants a path to a directory filled with metadata files, which I do not have. I could construct the directory dynamically before calling supply, but it seems much more straightforward to just pass the data to supply when calling it.
Is it possible to pass dynamic data to Google Play? Will there be a way soon? If not I guess I'll have to use Google's API client directly.
Configuration Files
Fastfile (see below):
platform :android do
  desc 'Push metadata to Google Play Store'
  desc 'Metadata will be pulled from the CMS'
  lane :decorate do |options|
    # `CMS` is a network client that fetches app information from a remote server
    details = CMS.play_store_details(options[:app_id])

    # `ROOT` is a Pathname pointing to the project root directory
    metadata = ROOT.join("fastlane/metadata/android/#{details.package_identifier}.json")

    metadata.dirname.mkpath
    metadata.write({
      language: details.locale,
      title: details.name,
      short_description: details.summary,
      full_description: details.description,
      video: nil
    }.to_json)

    supply(
      package_name: details.package_identifier,
      json_key: ROOT.join('fastlane/assets/json_key.json').to_s,

      # doesn't work. `:metadata_path` expects a directory
      metadata_path: metadata.path,

      skip_upload_apk: true,
      skip_upload_images: true,
      skip_upload_screenshots: true
    )
  end
end

Fastfile I'd like to use:
platform :android do
  desc 'Push metadata to Google Play Store'
  desc 'Metadata will be pulled from the CMS'
  lane :decorate do |options|
    # `CMS` is a network client that fetches app information from a remote server
    details = CMS.play_store_details(options[:app_id])

    supply(
      package_name: details.package_identifier,
      # `ROOT` is a Pathname pointing to the project root directory
      json_key: ROOT.join('fastlane/assets/json_key.json').to_s,

      metadata: {
        language: details.locale,
        title: details.name,
        short_description: details.summary,
        full_description: details.description,
        video: nil
      },

      skip_upload_apk: true,
      skip_upload_images: true,
      skip_upload_screenshots: true
    )
  end
end

Environment
fastlane version (run fastlane -v): 1.89.0
Do you use bundler to execute fastlane (i.e. bundle exec fastlane)? Yes
Do you use a Ruby environment manager (e.g. chruby, rbenv, rvm)? rbenv

Hi @ravinggenius, it isn't currently possible to provide the metadata directly to supply as you requested. At this time we don't have a plan to make that change, so for your use case, using the google api might be easier 👍

I poked around in Supply::Uploader, and it looks like it would be pretty easy to add support for a :metadata option. Would you be open to a pull request?

@ravinggenius Thanks for the suggestion. At this time we're not open to extending the functionality of supply in this way. Feel free to create a fork and add your desired behavior there. If there is a lot of interest from the community we could consider merging that behavior in the future 👍

Follow up: What about adding support for other data to supply? For instance synchronizing Content Ratings would be very useful for us.

@ravinggenius Please open a new PR to discuss 😄  I believe that content rating, if synchronized in the same manner as existing metadata, would be a valuable addition to supply 👍


Update Spacings

Your Image and Text are really close, my brain hates it so I fixed it for you :)

The lowercase in your "Bio" doesn't work with the rest of the website

Might as well update your Meta Tags while I'm at it

Changes look good to me! And yeah, if you want to go ahead and update the meta tags, I'm for it! I'll merge the changes then.

Go for it, all my commits are done


Feature request: Ignore tracking for request with DNT headers

Please allow goaccess to filter out requests with DNT set to 1, this allows goaccess to respect user privacy.
FYI: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/DNT

Do you know if it's logged on the access log somewhere?

I do not know, I was considering goaccess as an open source alternative to Netlify analytics

I'm guessing since they are hosting the site for you, they can track the DNT header that way. For goaccess to track this, it will require to interact with the client, i.e. JS.

You did not understand me correctly. No I am not using Netlify Analytics, I want same thing done by goaccess. I want to filter out requests with DND headers set to 1 with goaccess

I see. Once you get the DNT header logged into your access log, then goaccess should be able to parse that. This may give a hint if possible.

Can we support DNT filtering through this library(goaccess)?

goaccess parses the log, it's not in charge of logging data so it's up to the server and perhaps a library of sort to support dnt. if dnt is available within the log, then goaccess could show stats about it.

So please show stats about DNT

Feel free to use %v in your log-format to display them (assuming no vhost).


Observatory: links to top-level class (::) display as nothing

E.g., inbound-references of any script object.

9162166b54ffcf73edcc947d3f85c265ff77dc2a


[WM-1648] Remove target workflows

When running the branch locally, I am getting below error. Is it just my setup or something else?
Caused by: liquibase.exception.MigrationFailedException: Migration failed for change set changelog/changesets/20230123_remove_target_workflows.yaml::remove all target workflows::kpierre:
     Reason: liquibase.exception.DatabaseException: ERROR: update or delete on table "method_version" violates foreign key constraint "fk_run_set_method_version" on table "run_set"
  Detail: Key (method_version_id)=(20000000-0000-0000-0000-000000000001) is still referenced from table "run_set". [Failed SQL: (0) DELETE FROM public.method_version WHERE method_version_description = 'First version of target workflow 1']

When running the branch locally, I am getting below error. Is it just my setup or something else?
Caused by: liquibase.exception.MigrationFailedException: Migration failed for change set changelog/changesets/20230123_remove_target_workflows.yaml::remove all target workflows::kpierre:
     Reason: liquibase.exception.DatabaseException: ERROR: update or delete on table "method_version" violates foreign key constraint "fk_run_set_method_version" on table "run_set"
  Detail: Key (method_version_id)=(20000000-0000-0000-0000-000000000001) is still referenced from table "run_set". [Failed SQL: (0) DELETE FROM public.method_version WHERE method_version_description = 'First version of target workflow 1']

@salonishah11  Hm, out of curiosity, did you drop and then create your db before running bootRun? Sorry if that's a dumb question. I didn't see this on my end when I ran it.

No I didn't drop the database. My branch was up to date with main branch and then I pulled your branch and ran gradlew bootRun. @cjllanwarne would you be able to pull from main branch and then run this branch to see if you are seeing the same error as me?


New cards should be instantly added and put into edit mode (=blurred for others)

For distributed teams it is easier (imho) to add cards make them visible but blurred (=edit mode). Then the team turns them around at the same time. That was a feature some time ago.

I added a new option now to add multiple cards before showing to everyone.


ENH?: add write epochs function

I thought we had it already. ...
cc @agramfort

epochs.save ?
why do you need the write_epochs ? we have it for evoked to write multiple
evoked in one file.

For fieldtrip to make epochs writing easier / happen? AFAIK it is not yet supported. People repeated me ask me how to export their epochs from matlab. Was thinking also about this one.

I read that you want readers for fieldtrip epochs .mat files. Why not if
there format is quite stable in time.


Poorly-formed POSTs to /users never respond, kill the server?

I've been using POST /users with only a "display_name" or "email" field (no "password") to test to see if a username or email address is available before creating a new account.
At some point (not sure when) this seems to have slowed way way down, sometimes just timing out after a minute.
And I'm pretty sure if I do it enough the whole back end dies for a few minutes. I can't even load /commit_id.txt right now.

Looks like the slug validation on the identity group and the display_name case insensitive validations can run really slow. Some testing from local machine have them at 1.5s each.


Optional fields within Host config file always parsed as Nothing

Problem statement
Optional fields within a Host configuration file always pared as Nothing.
Steps to reproduce

make a host config file with some optional fields
2.submit a job to run on this host
3.from the log, the optional fields always Nothing even it's presented

Expected result
The fields should use the values within the Host config file
Actual result
Always set Nothing.
batchd version
Github master
Please specify whether you are using installation from hackage, or building source from github.
Built with the github master

Can't reproduce :/
If you have an example of config which loads incorrectly, feel free to reopen.


[T4A3][W14-B3] Ray Yan

Ready for review.

Accepting this PR without a review because another of your PRs for this tutorial was reviewed in detail.


HBASE-24446 Use EnvironmentEdgeManager to compute clock skew in Master

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m  0s
Docker mode activated.

-1 :x:
docker
13m 46s
Docker failed to build yetus/hbase:7cf97016b9.

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hbase/pull/1835

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1835/1/console

versions
git=2.17.1

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 31s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ branch-1 Compile Tests _

+1 :green_heart:
mvninstall
10m  0s
branch-1 passed

+1 :green_heart:
compile
0m 44s
branch-1 passed with JDK v1.8.0_252

+1 :green_heart:
compile
0m 49s
branch-1 passed with JDK v1.7.0_262

+1 :green_heart:
checkstyle
1m 54s
branch-1 passed

+1 :green_heart:
shadedjars
3m 22s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 48s
branch-1 passed with JDK v1.8.0_252

+1 :green_heart:
javadoc
0m 43s
branch-1 passed with JDK v1.7.0_262

+0 :ok:
spotbugs
3m 14s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
3m 10s
branch-1 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m  5s
the patch passed

+1 :green_heart:
compile
0m 45s
the patch passed with JDK v1.8.0_252

+1 :green_heart:
javac
0m 45s
the patch passed

+1 :green_heart:
compile
0m 47s
the patch passed with JDK v1.7.0_262

+1 :green_heart:
javac
0m 47s
the patch passed

-1 :x:
checkstyle
1m 48s
hbase-server: The patch generated 1 new + 40 unchanged - 1 fixed = 41 total (was 41)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
3m  6s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
5m 10s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2.

+1 :green_heart:
javadoc
0m 34s
the patch passed with JDK v1.8.0_252

+1 :green_heart:
javadoc
0m 43s
the patch passed with JDK v1.7.0_262

+1 :green_heart:
findbugs
3m  6s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
152m 20s
hbase-server in the patch passed.

+1 :green_heart:
asflicense
0m 32s
The patch does not generate ASF License warnings.

197m 52s

Subsystem
Report/Notes

Docker
Client=19.03.9 Server=19.03.9 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1835/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1835

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 9ca971d2f37f 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1835/out/precommit/personality/provided.sh

git revision
branch-1 / d889c7b

Default Java
1.7.0_262

Multi-JDK versions
/usr/lib/jvm/zulu-8-amd64:1.8.0_252 /usr/lib/jvm/zulu-7-amd64:1.7.0_262

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1835/2/artifact/out/diff-checkstyle-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1835/2/testReport/

Max. process+thread count
3822 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1835/2/console

versions
git=1.9.1 maven=3.0.5 findbugs=3.0.1

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@virajjasani  This is change for branch-1 . Please review

@apurtell

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 37s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ branch-1 Compile Tests _

+1 :green_heart:
mvninstall
9m 51s
branch-1 passed

+1 :green_heart:
compile
0m 39s
branch-1 passed with JDK v1.8.0_252

+1 :green_heart:
compile
0m 45s
branch-1 passed with JDK v1.7.0_262

+1 :green_heart:
checkstyle
1m 45s
branch-1 passed

+1 :green_heart:
shadedjars
3m  2s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 48s
branch-1 passed with JDK v1.8.0_252

+1 :green_heart:
javadoc
0m 40s
branch-1 passed with JDK v1.7.0_262

+0 :ok:
spotbugs
2m 59s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
2m 56s
branch-1 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 53s
the patch passed

+1 :green_heart:
compile
0m 40s
the patch passed with JDK v1.8.0_252

+1 :green_heart:
javac
0m 40s
the patch passed

+1 :green_heart:
compile
0m 45s
the patch passed with JDK v1.7.0_262

+1 :green_heart:
javac
0m 45s
the patch passed

+1 :green_heart:
checkstyle
1m 33s
hbase-server: The patch generated 0 new + 40 unchanged - 1 fixed = 40 total (was 41)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
2m 50s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
4m 33s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2.

+1 :green_heart:
javadoc
0m 31s
the patch passed with JDK v1.8.0_252

+1 :green_heart:
javadoc
0m 41s
the patch passed with JDK v1.7.0_262

+1 :green_heart:
findbugs
2m 49s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
125m 30s
hbase-server in the patch passed.

+1 :green_heart:
asflicense
0m 38s
The patch does not generate ASF License warnings.

166m 49s

Subsystem
Report/Notes

Docker
Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1835/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1835

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 225ed691a254 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1835/out/precommit/personality/provided.sh

git revision
branch-1 / 4118383

Default Java
1.7.0_262

Multi-JDK versions
/usr/lib/jvm/zulu-8-amd64:1.8.0_252 /usr/lib/jvm/zulu-7-amd64:1.7.0_262

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1835/3/testReport/

Max. process+thread count
4295 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1835/3/console

versions
git=1.9.1 maven=3.0.5 findbugs=3.0.1

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Belated +1


Allow to visit structure without instance.

Allow to visit structure member without instance.

This is a really nice PR. I like your proposed syntax, it fits very nicely with everything else, and it adds something pretty useful.
Before I merge it, I would like to:

Extend it also so that it works for the "intrusive" syntax, and the hana / boost::fusion compatibility headers. IIUC this only does it for the basic version. I think it will all work the same way but it would be nice to check that before the merge.
Possibly refactor it so that this visitation style is the "core", and the versions in which you have an instance are defined in terms of this one. It might be a little terser overall that way. (Actually this should happen after the merge.)
Add a blurb about this to the README.md
Run tests against two other projects that I have that use this code.

Thanks again.

Hi, after some manipulations to create json schema from structs, I found that
template struct Tag {};

v("a", Tag<int>{});

produces less template instantiations than
v("a", my_struct::a);

And visitor syntax is then simpler (no use of member pointer).

Hi,
I guess they both have merits, but the member pointer can be used to implement the other one, and not vice versa.
I have written applications in the past where I wanted to be able to get the member pointers and found that I couldn't and had to redo things, so I'm sort of inclined to keep the member pointer version somehow.
Also, I see what you mean about having more template instantiations, since the struct itself has to be a template parameter then each time the visitor is invoked, but I'm inclined to think that it still is not going to be enough to cause problems.
I'm going to think about it a bit.
I think hana does something similar to what you suggest with template <typename> struct type; in namespace hana, and uses these in various places for tag disptach. But I don't know any other libraries that do that.

Having something  similar to member method might be useful.
Instead of member pointer, for fusion, getter can be used, something like:
        //-----------------------------------------------------------------------------
        template <typename Index>
        struct MemberValueGetter {
            template <typename T>
            auto operator ()(T&& t) const
            {
                return boost::fusion::at<Index>(t);
            }
        };

        //-----------------------------------------------------------------------------
        template <typename V, typename T>
        class VisitorCallerWithoutInstanceWithGetter
        {
        public:
            explicit VisitorCallerWithoutInstanceWithGetter(V& v) : mVisitor(v) {}

            template <typename Index> void operator()(Index) const
            {
                using type = MemberType<T, Index>;
                mVisitor(GetMemberName<T, Index>(), Tag<type>{}, MemberValueGetter<Index>{});
            }

        private:
            V& mVisitor;
        };

    //-----------------------------------------------------------------------------
    // for
    // ```
    // struct S { int a; char c; std::string s;};
    // BOOST_FUSION_ADAPT_STRUCT(S, (int, a) (char, c) (std::string, s));
    // ```
    // `ApplyVisitorWithGetter<S>(v);` would be equivalent to:
    // ```
    // v("a", Tag<int>{}, GetterA);
    // v("c", Tag<char>{}, GetterC);
    // v("s", Tag<std::string>{}, GetterS);
    // ```
    template <typename T, typename V> void ApplyVisitorWithGetter(V&& v)
    {
        static_assert(is_visitable<T>::value, "BOOST_FUSION_ADAPT_STRUCT has not been called");

        details::VisitorCallerWithoutInstanceWithGetter<V&&, T> visitor{ v };
        boost::fusion::for_each(details::IndexSequence<T>(), visitor);
    }

Jarod42: I thought about a way to compromise on this.
So one way to accommodate both usages is, change the library so that it returns a "getter" function object instead of member pointer like you suggest.
But, the getter is also implicitly convertible to a member pointer.
This way old code is not broken, and the user can just select which type they want by changing the signature of the visitor appropriately.
And as you point out -- hana and fusion can be mostly compatible, since they both can give the getters at least. They still won't be able to give the member pointer but that's par for the course.
I don't think there's many situations where an implicit conversion like that would cause a problem, it's very rare that someone has a variable of member pointer type or a function that takes member pointers. Going to think about it some more though.

Hi Jarod42,
I merged several patches today so that the "getters" visitation, and the tag-dispatch for type visitation, are both supported.
Instead of apply_visitor without an instance, there are now three versions of it:
visit_types -- this passes const char *, type_c<T> when the member has type T
visit_accessors -- this passes const char *, []() { ... }, that is, an appropriate function object
visit_pointers -- this passes const char *, T S::* , as the original version.
The apply_visitor without an instance is now deprecated, and no longer documented, but it just calls visit_pointers as before to avoid breakage.
I have tested also that visit_accessors and visit_types does work, in the hana and fusion compat headers, with all tested compilers.
There are also now indexed getters, get_accessor<idx, S>(), and get_pointer<idx, S> which can grab the accessor object, or the member pointer, at a particular index in the list of fields.


dual pane interface

hello,
please consider adding a dual pan interface like midnight commander, double commander or cloudberry explorer.
thanks

Maybe in the future. At the moment no plans to implement it.


SIM logs are sent to STDOUT

Issue/Feature Description:
All logs for API request is spitted on the STDOUT
Why this issue to fixed / feature is needed(give scenarios or use cases):
Even though started the API server in background, all the logs are thrown on stdout.  If we specify log_file in the configuration the logs will not be thrown to stdout.
I have tested this by specifying log_file in conf .

@kumarashit , please verify and close.

Closing as per previous comment , please re open if required.


Remove version: TheDocumentFoundation.LibreOffice.LTS version <IP_ADDRESS>

EOL'd
Microsoft Reviewers: Open in CodeFlow

URL: https://download.documentfoundation.org/libreoffice/stable/7.6.7/win/x86/LibreOffice_7.6.7_Win_x86.msi
OK
(Automated message - build 911)

Hi @vikingnope,
This manifest has the highest version number for this package. Is it available from another location? (This might be in error if the version is switching from semantic to string, or string to semantic.)
(Automated response - build 886.)

URL: https://download.documentfoundation.org/libreoffice/stable/7.6.7/win/x86/LibreOffice_7.6.7_Win_x86.msi
OK
(Automated message - build 911)

EOL'd, see here: https://wiki.documentfoundation.org/ReleasePlan/7.6

This is an affirmative "No, it's not available anywhere else." Thank you.


Short solution needed: "Using multiIf in query" (clickhouse)

Please help us write most modern and shortest code solution for this issue:
Using multiIf in query (technology: clickhouse)
Fast way
Just write the code solution in the comments.
Prefered way

Create pull request with a new code file inside inbox folder.
Don't forget to use comments to make solution explained.
Link to this issue in comments of pull request.

Using multiIf in query


Feature addition - cursor following

smooth cursor following effect can be added to make the site more appealing, please assign this to me

custom cursor will make the site more appealing

go ahead @shalomrionafernandes


specs for Options and Session

These are the responsibilities I think we've agreed to, with a couple extra things.
Let's verify this is what we want.

Looks gtm although very generic ;)

@nadvolod yeah, this definitely isn't comprehensive, but even just looking at these should give us an idea of design requirements. I want for us to add to these and implement the "same things" in each of the bindings.


Routes transitions javascript hooks

Any way to add the javascript hooks to the <transition>?
<transition
  v-on:before-enter="beforeEnter"
  v-on:enter="enter"
  v-on:after-enter="afterEnter"
  v-on:enter-cancelled="enterCancelled"
  v-on:before-leave="beforeLeave"
  v-on:leave="leave"
  v-on:after-leave="afterLeave"
  v-on:leave-cancelled="leaveCancelled"
>
  <!-- ... -->
</transition>

Maybe we could simply add transition: { hooks: true } as a viable option in nuxt-config? And then add the same as above into <transition> (seems overkill to be able to name the hooks yourself).
Thing to watch out for though:
It’s also a good idea to explicitly add v-bind:css="false" for JavaScript-only transitions so that Vue can skip the CSS detection. This also prevents CSS rules from accidentally interfering with the transition.

Hi @PatrikLythell thanks for creating this issue, I thought about implementing it, it's now in the Roadmap for the 1.0.
I will try to find a nice way to implement it.

@PatrikLythell
It is now in the 0.9.0, the documentation is not updated yet but you can add the hooks like this:
nuxt.config.js:
module.exports = {
  transition: {
    beforeEnter () {
       // beforeEnter hook
    }
  }
}

It works also in the page components and the children components 👍
To disable CSS, juste like the documentation of Vue.js says, you can put css: false to disable CSS transitions.
You can see the list of keys & hooks here: https://vuejs.org/v2/api/#transition
appearClass, appearActiveClass, beforeAppear, appear and afterAppear are removed from the list because of the SSR feature of Nuxt.js.

@Atinux with 0.9.5 can't manage to trigger the event from nuxt.config.js, is this know bug?

Hi @vadimsg
It will be possible in the next release.
In the meantime, you can add the hooks in your layouts/default.vue.

FYI:
  transition: {     beforeEnter () {        // beforeEnter hook     }   }
This makes build fail "Module build failed: SyntaxError: Unexpected token, expected , (42:55)"
  transition: {     beforeEnter: function () {        console.log('beforeEnter');     }   }
And this works. Need to upgrade global webpack v? Or it's nuxt bug?

@vadimsg it's a known issue of serialize-javascript that we use for shorthand method definition: https://github.com/yahoo/serialize-javascript/issues/24
For the hooks definitions in nuxt.config.js, you have to use the ES2015 syntax:
...
transition: {
  beforeEnter: function () {
     console.log('beforeEnter');
  }
}
...

@Atinux  How should transitions within the same route be handled?
Example.  /post-1  coming from another route will transitiion
However if there are related posts within post-1 if I click on another post inside that page post-2 will not transition because technically is within the same page


ADD TrackerU web app Js

hello greetings fellas , I want to contribute a project that build on top of pure js HTML CSS
Project : TrackerU
Features :

get users location info: longitude &  latitude state country city
get users device info : os os type/version build info
detect ip is exposed or not
have a scale of venerability and for R&D purposes save users info
i want to contribute my small project , is there any way i could do that?

@mohdjameel2412 go for it!

already  pull requested from @mohammedjameel24
i did not use this account to register with GSSOC21 that's the reason i created a account with my GSSOC registered account
i apologies for confusions

Please merge my pull request @urvashi-code1255
Issue #370


Update CosmosDB Package and Cosmos Client to allow MS Learn Content 'npm install' to function correctly

As per discussion https://learn.microsoft.com/en-us/answers/questions/1183353/tls-exchange-fails-between-azure-cosmos-db-and-cli
The package requires and update and so does the syntax to create the db client otherwise the npm install command fails

@microsoft-github-policy-service agree [company="erikhjensen"]

Thank you for your PR. At this time, we are updating the entire repository so this will be updated as part of that effort.


Bug: Enter your seed window moves cursor position

"Enter your seed" form moves cursor position to the end of the text after any typing.
For example i typing: "125", after that, i moving cursor in position after 2 - "12|5", after that i typing 3 and 4, but i see 12354 instead of 12345 because cursor moves to the end position of text after any typing.
Please change it, beacause i cant type mnemonical passwords in this way.

Confirmed. I checked and this regression was introduced in https://github.com/atomiclabs/hyperdex/commit/33c4cef236fa9f24f8ddff16cc81f16ee16739eb.


Have a plan to support hadoop3.1.0

Such as the title , have a plan to support hadoop3.1.0

According to this  hadoop3.1.0 is not yet ready for production use.  We will work with Hadoop community to support higher version when the time is right.


Multiple playlists question

Question Checklist

[X] Updated Amplitude.js to the latest version
[X] I read the docs
[X] I searched for existing GitHub issues

Question Subject
Multiple playlist buttons

Question Description
Hi,
I'm musician and want to use several playlists players in the same page for my new website.
I start from the template, everythings is working properly with music and cover art except the playlist button that always opens the first player.
Can someone help me solve that?

Hi @siegfriedz . Do you have the second button scoped to your playlist? It should have an attribute of data-amplitude-playlist="" on it with the key of your playlist.

Closed due to inactivity


#37 | Add Pylint CI & unit tests

Add Pylint GitHub Actions CI.
https://github.com/actions/starter-workflows/blob/607f368/ci/pylint.yml

Decided docstring format:
"""
Summary line.

Extended description.

Parameters:
    param_1 (int): Description of param_1.
    param_2 (str): Description of param_2.

Returns:
    bool: Description of return value.

Raises:
    KeyError: raises an exception.
"""

Unit tests:
https://docs.python.org/3/library/unittest.html


Update Turkish Translations

chore(i18n): This commit enriches the application by integrating Turkish language support, enhancing accessibility and user experience for Turkish-speaking audiences. 🇹🇷

Thanks @hasanbeder 👍

We would accept a similar PR against the beta branch 👍 @hasanbeder


Off-the-shelf models

Add off-the-shelf machine learning models for a variety of NLP tasks that are trained on a large
training corpus, and get reasonably good performance.  E.g.:

POS Tagging
Tokenization
Parsing?
SRL
Chunking
NE detection

Migrated from http://code.google.com/p/nltk/issues/detail?id=210earlier comments
edloper said, at 2009-02-08T04:26:45.000Z:
Status update:
- Tagger & tokenizer: done and checked in.
- NE chunker: done but not checked in.
- NP chunker: still training the model.
ewan.klein said, at 2009-02-11T09:49:43.000Z:
Is there a target date for checking in the NE chunker? StevenBird1 said, at 2009-02-11T10:51:11.000Z:
please see r7581StevenBird1 said, at 2009-02-21T01:44:59.000Z:
Carried forward to 0.9.9
StevenBird1 said, at 2010-03-02T08:48:19.000Z:
The code for off-the-shelf models should live in the source repository, so it can be
inspected and updated.  E.g. how was the maxent tagger model used by NLTK's default
POS tagger (nltk.pos_tag) created?

I know this is an old issue but it's nice to keep track of state-of-code:
POS Tagger:  nltk.pos_tag with https://github.com/nltk/nltk/issues/1063 and http://stackoverflow.com/questions/30821188/python-nltk-pos-tag-not-returning-the-correct-part-of-speech-tag
Tokenization: nltk.word_tokenize , nltk.sent_tokenize (punkt). Support for more languages would be nice, e.g. CJK / Thai / Arabic segmenters.
NP/NE chunker:  nltk.ne_chunk but more can be done with nltk.tag.senna
Parsing / SRL: There's quite a few wrappers around nltk.sem and nltk.parse.


Exception when touching the screen with multiple fingers

Open any flutter_web app.
Tap the screen with two fingers simultaneously.
Notice exception being thrown in the console.

Potentially related to these?
https://github.com/flutter/flutter/issues/20517
https://github.com/flutter/flutter/issues/32132

@justinmc it appears that the issues you linked are for Flutter native (Android specifically). This issue is specific to the web.


Required Android layout attributes not set during generation

The required Android layout attributes layout_width and layout_height are not being set for a FlowLayoutPane with a Spacer during generation. Example:
package com.example.md2.sessiontest.views
    FlowLayoutPane sessionListPane (vertical ) {
        Label titleAbbreviation { text "Abbreviation" }
        TextInput abbreviation
        Label titleLabel { text "Title" }
        TextInput title
        Spacer
     }

The generated code for the Spacer is:
<TextView />
The app crashes with:
10-11 16:40:37.401: E/AndroidRuntime(429): FATAL EXCEPTION: main
10-11 16:40:37.401: E/AndroidRuntime(429): java.lang.RuntimeException: Unable to start activity ComponentInfo{com.example.md2.sessiontest.android/com.activenetwork.md2.sessiontest.android.controller.SessionListPaneActivity}: java.lang.RuntimeException: Binary XML file line #38: You must supply a layout_width attribute.

This requires manual fixing the generated code in order for the Android application to build and run.
Also, the graphical layout editor in Eclipse complains that
"sessionListPane" does not set the required layout_height attribute:
 (1) Set to "wrap_content"
 (2) Set to "match_parent"

(but the app builds and runs)

Android generator has been rebuild from scratch. Cleaning up open issues.


Is it possible to render directly in WGPU handle?

Specific Demand

Is it possible to render directly in WGPU handle?
Implement Suggestion

If we can directly render to WGPU element, this would be a great possibility for game industry to integrate their game and game engine with this GUI.

We were just discussing embedding Blitz (Dioxus' WGPU renderer) into other windows on the discord (discussion). Currently this is not possible, but it would definitely be a great feature to support in the future.
Here is a summary of the discussion:
Blitz needs to be more abstracted over async runtime and allow rendering outside of a window.
Tokio/Async runtime: We only use the channels and select macro from tokio, we could probably use a library that is not specific to tokio that support those two things. We do need some async runtime, but I think it should be fairly easy to be agnostic here.
Rendering/Viewports: Currently we only render to a window. We could be able to create an abstraction that would allow different options, but I think Tao or winit is still a good default to export. We need something that emits events that can be converted into Dioxus events (handled here https://github.com/DioxusLabs/blitz/blob/3ab3ed3ba76b2917c8bb885015ea81c4c8b28ea5/src/events.rs#L9) and has a window size.
The code that is related to the Tao window currently would need to be converted into something more like a viewport. It wouldn't be the window that the bevy app runs in, just something with a size inside of that window that the Blitz UI is rendered into that can capture events
You don't need direct access, but there needs to be a size so that layout can work, and events so that elements can respond to actions
For Blitz, my main concern is how this would effect the complexity of adding future features that could be more specific to the windowing library we mainly use. For example, first class support for keyboard shortcuts could be available in Tao, but not Bevy.
Something that could alleviate this is a more raw API for something like Bevy that supports rendering and events, but not more Tao specific features like shortcuts, taskbar, etc.
This is not a priority for me in the near future (I would like to develop widgets, more support for html elements+attributes, and accessibility integration first), but I would be happy to get someone started implementing this.

hey I'd like to see dioxus with bevy, but I'm fairly new with rust, but I've done Haskell and I work with web.
if someone can give me a bit of a pointer where to get started and an estimate how much work this feature needs I'd be willing to invest a bit of time to make it happen

Wry recently added support for embedding a webview into a raw window including a wgpu window: https://github.com/tauri-apps/wry/blob/dev/examples/wgpu.rs. Using that example to build support into dioxus would be much easier than getting blitz to a point where it can render most apps.
We currently use tao which is tauri's fork of winit. It sounds like tao does not plan to support this in the future https://github.com/tauri-apps/tao/issues/616. We could try switching to winit, but I don't know if we currently use any tao specific features. There is quite a bit of code in dioxus desktop related to winit, but the APIs are also very similar in some places

@epsilonhalbe take a look: https://github.com/JMS55/bevy_dioxus

For folks that want to render dioxus into a wgpu context, we now have a few options:

use blitz / dioxus-blitz: http://github.com/dioxusLabs/blitz
use bevy_dioxus: https://github.com/JMS55/bevy_dioxus

For folks looking for a native renderer not based on wgpu, check out:

freya http://github.com/marc2332/freya

As much as I want to close this issue, the underlying problem remains that dioxus-desktop in theory can render to wgpu, but in practice, that's a winit-only feature (AFAIK) and would require desktop jumping from tao to winit.


[Merge] terms with editors note

MONDO ID
Label
Potential term to merged with ID
Potential term to merged with label
Note
PR

MONDO:0000237
erysipeloid
MONDO:0006752
Erysipelothrix rhusiopathiae infectious disease'
Editor note: consider merging with parent
https://github.com/monarch-initiative/mondo/pull/5453

MONDO:0000561
spinocerebellar ataxia type 16
MONDO:0011694
spinocerebellar ataxia type 15/16'
Editor notes: Consider merging into 15/16
https://github.com/monarch-initiative/mondo/pull/5454

MONDO:0001524
globe disease
MONDO:0005328
eye disorder'
Editor note: Consider merging with parent
https://github.com/monarch-initiative/mondo/pull/5457

MONDO:0002454
thyroid adenoma
MONDO:0005032
follicular thyroid adenoma'
Editor note: consider merging with follicular thyroid adenoma
https://github.com/monarch-initiative/mondo/pull/5459

MONDO:0004721
liver neoplasm
MONDO:0024477
liver and intrahepatic bile duct neoplasm'
Editor note: consider merging with liver and intrahepatic bile duct neoplasm
https://github.com/monarch-initiative/mondo/pull/5460

MONDO:0004935
acquired carotenemia
MONDO:0021162
carotenemia
Editor note: consider merging into parent. An explicit acquired subclass was created for consistency with DO
https://github.com/monarch-initiative/mondo/pull/5876

MONDO:0005218
muscular disease
MONDO:0003939
muscle tissue disorder'
Editor note: consider merging with child
https://github.com/monarch-initiative/mondo/pull/5875

MONDO:0005410
acute graft vs. host disease
MONDO:0020546
acute graft versus host disease'
Editor note: consider merging with parent
done

MONDO:0007806
hypotrichosis 4
MONDO:0018631
Marie Unna hereditary hypotrichosis'
Editor note: consider merging into MUHH
https://github.com/monarch-initiative/mondo/pull/5877

MONDO:0011751
COPD, severe early onset
MONDO:0005002
chronic obstructive pulmonary disease'
Editor note: consider merging to parent
done

MONDO:0015077
adrenal/paraganglial tumor
MONDO:0021227
adrenal gland neoplasm'
Editor note: consider merging
done

MONDO:0016251
salivary gland type cancer of the breast
MONDO:0003185
adenoid cystic breast carcinoma'
Editor note: consider merging with mammary adenoid cystic carcinoma

MONDO:0016808
mitochondrial DNA depletion syndrome, hepatocerebral form
MONDO:0014943
mitochondrial DNA depletion syndrome 15 (hepatocerebral type);'
Editor note: consider merging with MONDO:0014943

MONDO:0018303
generalized isolated dystonia
MONDO:0000476
generalized dystonia'
Editor note: consider merging with generalized dystonia if no complex forms

MONDO:0018351
adenocarcinoma of penis
MONDO:0002653
Paget disease of the penis'
Editor note: consider merging with Paget disease of penis

MONDO:0018527
osteoclastic giant cell tumor of pancreas
MONDO:0006479
osteoclastic giant cell tumor of pancreas'
Editor note: consider merging with MONDO:0006479

MONDO:0021257
glomus jugulare neoplasm
MONDO:0021064
jugulotympanic paraganglioma'
Editor note: consider merging with jugulotympanic paraganglioma

MONDO:0021664
cervical aortic arch
MONDO:0017991
Takayasu arteritis'
Editor note: consider merging with MONDO:0017991

related to https://github.com/monarch-initiative/mondo/issues/3811

[x] Review MONDO:0011191	capillary infantile hemangioma- Editor note: consider merging or making class explicitly for inherited forms. Note also Orphanet equiv is obsolete

@sabrinatoro could you try to make slow progress on this each month or so?

I have Questions on why some of these were merged....

[ ] MONDO:0016251 was merged with MONDO:0003185 ?  The Orphanet term seems to be broader than the merged target
ORPHA:213557: Salivary gland type cancer of the breast
Def: "Salivary gland type cancer of the breast describes a group of uncommon neoplasms, usually seen in the salivary glands but occurring in the breast, with a variable clinicopathologic spectrum and divided into those with myoepithelial differentiation and those without. This group includes mammary adenoid cystic carcinoma, adenoid cystic carcinoma (see this term), mucoepidermoid carcinoma, acinic cell carcinoma, polymorphous low-grade adenocarcinoma and oncocytic carcinoma.
https://www.orpha.net/consor/cgi-bin/OC_Exp.php?Expert=213557
The merged term has NCI which is included in the Orphanet definition as one sub-type? https://ncithesaurus.nci.nih.gov/ncitbrowser/ConceptReport.jsp?dictionary=NCI_Thesaurus&ns=ncit&code=C5130

[ ] MONDO:0016808 with MONDO:0014943.
The Orphanet term seems broader than the one genetic subtype represented by OMIM 617156. Mitochondrial DNA depletion syndrome, hepatocerebral form is listed on Orphanet's site as a grouping term: https://www.orpha.net/consor/cgi-bin/OC_Exp.php?Expert=254871 And the OMIM Phenotypic series for Mito DNA depletion syndrome https://www.omim.org/phenotypicSeries/PS603041 has 4 different entries that list "hepatocerebral form" as part of OMIM's preferred name.

Working my way through some more of these cases that we were unable to map automatically... I am also wondering why MONDO:0011191 capillary infantile hemangioma and MONDO:0100300 hereditary capillary infantile hemangioma are separate concepts now? The only X-ref I am finding (in our download of the latest release) for MONDO:0011191 is UMLS C1865871, which is also where UMLS maps the OMIM and MeSH records on MONDO:0100300, so based on the mapping in UMLS, these are the same concept.
UMLS has C4317089 for "Infantile Hemangioma" based on the NCI term: C6645, which may be a more appropriate CUI for the infantile presentation that isn't necessarily heritable.

thanks, @kanems! I'll take a look at this asap and I can unmerge them if needed before the next release.
As always, I appreciate your careful eye on Mondo! 😃

Working my way through some more of these cases that we were unable to map automatically... I am also wondering why MONDO:0011191 capillary infantile hemangioma and MONDO:0100300 hereditary capillary infantile hemangioma are separate concepts now? The only X-ref I am finding (in our download of the latest release) for MONDO:0011191 is UMLS C1865871, which is also where UMLS maps the OMIM and MeSH records on MONDO:0100300, so based on the mapping in UMLS, these are the same concept. UMLS has C4317089 for "Infantile Hemangioma" based on the NCI term: C6645, which may be a more appropriate CUI for the infantile presentation that isn't necessarily heritable.

@kanems I will create  separate ticket to merge 'hereditary capillary infantile hemangioma' with 'capillary infantile hemangioma'.
Thanks!


Can't create environment API keys for AD user

Version: v1.0.0-rc4
Steps to Reproduce:

Authenticate using Active Directory
Log in as another user in separate browser
Go to API screen
Try to create an Environment API key

Results: Keeps getting added to the Account API key
Expected: Should be added as an Environment API key

Actual issue is it works for admin accounts but not for non-admin.

Version - master 3.27
Verified fixed


Aras Workflow Approval add-in available as installer?

Hi,
is the "Aras Workflow Approval add-in" also available as independed installer?
The Office Store is per default deactivated in our company, so I am not able to download and install any add-in. Only a manual installation of add-ins is possible at the moment (like Aras Office Connector add-in).
A installer (if technically possible) would high likely be a faster solution then starting discussions with the IT department about reactivating the store. :-)
Maybe it´s also possible to reactive the store but at the same time only allow the installation of some specific predefined add-ins. But I haven´t checked this option yet.
Thanks for your help again!
Best regards
Angela

Hi Eli,
I tried this feature last week with a colleague from IT.
After installation the Outlook of my colleague didn´t start up any more. So I am right now still banned for the Add-In store.
But I am patient. I will find a way to try this feature one day. :-)
Angela


Implement pushing/pulling whole directories instead of single file's

Please improve file pull/push commands with support of copying a whole directories recursively.
This is a much needed feature.
Thank you.

Duplicate of #1218


Remove extra characters

@weijiechai : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off


AVRO-2921 Additional Type Hints for avro.schema

Adds strict type hints for avro.schema.
Jira

[x] My PR addresses AVRO-2921 and references it in the PR title.
[x] Adds no dependency

Tests

[x] My PR is covered by and passes existing tests.

Commits

[x] My commits all reference Jira issues in their subject lines.
[x] In addition, my commits follow the guidelines from "How to write a good git commit message":

[x] Subject is separated from body by a blank line
[x] Subject is limited to 50 characters (not including Jira issue reference)
[x] Subject does not end with a period
[x] Subject uses the imperative mood ("add", not "adding")
[x] Body wraps at 72 characters
[x] Body explains "what" and "why", not "how"

Documentation

[x] Type hints are a form of documentation as well as being a static analysis tool.

Superseded by #2350


Bad response from server: (500 [error,list])

I tried to remove one torrent from my seedbox. Seedbox is having 6500 torrents. Everything was working fine except now and I am having above issue.
Bad response from server: (500 [error,list])

How do you think this issue is related to the installation script rtinst? From the point the script is finished and everything is set up correctly, the issue is likely elsewhere. I guess you get the error message in your browser? If so, can you see if rTorrent is running fine by connecting to it? I think this issue is related to ruTorrent and you should address your issue there. Otherwise, it could be rTorrent, and you should then address the issue there.


signup page with login page

The older Design was good but it is way too basic for today generation website so i have created a better website for the signup and login page too which will work simultaneously

I am starting with the new login signup page and im from hactober fest 2023

Hi there,
I'm interested in working on issue , I've looked into the details and I'm ready to contribute, as a part of my university's requirement to contribute to open source project. If there are any specific guidelines or additional information I should know about, please assign this to me.
Thanks for the opportunity to contribute!


Add navigation on Tikui

Seems to not be about the code because there is a 404 from codecov in the error. Maybe is it possible to launch the pipeline again ?


Vite Environment API - Cloudflare environment support

Vite 6 introduces the Environment API, which enables code to be run in custom environments. At Cloudflare, we are working with framework authors to integrate the Environment API and we are developing a plugin that creates a Cloudflare (workerd) environment. In combination, this will enable running server side code in the workerd runtime during local development, ensuring that development closely replicates production. This would replace the existing usage of getPlatformProxy that is currently used to simulate the Cloudflare platform in Node.js. In the future, a similar approach could be used to integrate other runtimes e.g. Deno, Bun etc.
This PR is a proof of concept of the approach and is intended for discussion and gathering feedback. It follows some initial discussion with @benmccann. A working example can be found at playgrounds/vite-cloudflare-environment.
I've tried to avoid changing the existing code as much as possible for now so that the main concepts are clear. The details of how it should fit into the SvelteKit codebase and integrate with the existing Adapter API are for discussion.
I've added comments to the new code and include an implementation summary below.
Implementation summary

A new kit.environments option has been added to the Svelte config where users can pass in the cloudflare environment provider factory function.
If the above option is provided, the factory function is used to create the plugin in packages/kit/src/exports/vite/index.js.
A new virtual module is created in packages/kit/src/exports/vite/index.js that exports the values (manifest etc.) required by the Server instance. This avoids using any Node.js specific APIs.
A new entrypoint file has been added at packages/kit/src/exports/vite/dev/cloudflare_entrypoint.js. This imports the above virtual module, creates the Server instance and calls server.respond to handle the Request and return a Response. It also adds the Cloudflare platform properties. As the code is executed in a workerd environment, these can be accessed directly.
In packages/kit/src/exports/vite/dev/index.js, if the environment exists, devEnv.api.getHandler is called with the above entrypoint file to create the request handler. This is used in place of the existing request handler.

Not implemented

The read function from $app/server can only be used in environments that support file system access so support for this has not been implemented. A possible scenario to consider is that users may deploy to Cloudflare but have pre-rendered routes that access the file system. These would need to be supported in development.
Inlining styles during SSR has not yet been implemented. The existing approach of collecting dependencies using vite.moduleGraph.getModuleByUrl would require communicating with the main process. This should be possible (e.g. using import.meta.hot) or there might be an alternative approach.

In addition to the Cloudflare environment described above, a Node.js environment has also been added. An example using this can be found in playgrounds/vite-node-environment. This could eventually be used as the default environment when kit.ssrEnvironment is not provided. This would mean that a single approach could be used, based on the entrypoint and virtual module convention, rather than maintaining two separate code paths.
I'm sure there will be loads of things I haven't considered so please take a look and let me know if you have any questions.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

[x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
[x] This message body should clearly illustrate what problems it solves.
[ ] Ideally, include a test that fails without this PR but passes with it.

Tests

[x] Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

[ ] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

[x] Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Our current abstraction for different environments is through adapters. My expectation would be that this was kept and no provider/environment specific code like packages/kit/src/exports/vite/dev/cloudflare_entrypoint.js was added to kit itself.
Instead the adapter initializer should return all things needed and kit wires it together with its own vite plugins.
It would not scale if we had to add extra code to kit itself for each new environment.
Things to keep in mind:

apps can use more than two environments, not just "client" and "server".
environments are not just for dev time, but also create different outputs
for platform specific apis, there is locals.platform, which might need namespacing unless we don't want to support one adapter that emits multiple environments
it must be environment agnostic so that netlify, vercel, deno, sst, tauri, electron, .... and any custom environment can be integrated just as easy

Our current abstraction for different environments is through adapters. My expectation would be that this was kept and no provider/environment specific code like packages/kit/src/exports/vite/dev/cloudflare_entrypoint.js was added to kit itself.
Instead the adapter initializer should return all things needed and kit wires it together with its own vite plugins. It would not scale if we had to add extra code to kit itself for each new environment.

Sure, that makes sense. I've added a sentence to clarify that this isn't a suggestion for the final implementation. I think it's worth first considering the changes that are needed to SvelteKit internals (primarily exposing the manifest etc. as a virtual module) and then thinking about the best way to integrate this and the options that are needed.

I've tried to avoid changing the existing code as much as possible for now so that the main concepts are clear. The details of how it should fit into the SvelteKit codebase and integrate with the existing Adapter API are for discussion.

I've been thinking about how this could be integrated with the existing adapter API, as @dominikg mentions. One option would be to add an additional getHandler property to adapters, which returns a request handler. This would create the handler by calling the getHandler function on the provided environment with the entrypoint file. That way any platform specific code would be kept out of kit. If this getHandler property exists on the adapter then the handler will be used in place of the default request handler in development. It would therefore have precedence over the emulate property.
It could look something like this:
/**
* @returns {Promise<(request: Request) => Promise<Response>>}
*/
async getHandler(environment) {
  return await environment.api.getHandler({
    entrypoint: path.join(__dirname, 'cloudflare_entrypoint.js')
  });
}

We would also need a way to provide the factory function that creates the environment plugin. This could be a createEnvironmentPlugin property like this:
/**
* @returns {import('vite').Plugin}
*/
createEnvironmentPlugin(environment_name, options) {
  return cloudflare(environment_name, options);
}

In order to support multiple environments per adapter, the properties could be objects rather than functions:
{
  // ...
  createEnvironmentPlugins: {
    ssr: (environment_name, options) => {
      return cloudflare(environment_name, options);
    }
  },
  getHandlers: {
    ssr: async (environment) => {
      return await environment.api.getHandler({
        entrypoint: path.join(__dirname, 'cloudflare_entrypoint.js')
      });
    }
  }
};

What are your thoughts? It would be great to come up with something that the other adapters will also be able to utilise.

One option would be to add an additional getHandler property to adapters, which returns a request handler.

I'd probably call it getDevHandler

In order to support multiple environments per adapter, the properties could be objects rather than functions

Hmm. So I guess the environments here could be things like 'node', 'edge', etc. (e.g. as used in adapter-vercel). The existing runtime is set on a per-route level. The environments are currently used closer to the server entry point though before we know which route we're processing, so I'm not quite sure how you would choose the appropriate environment. If you have just a single ssr environment things are fine. But once you're choosing an environment based on the route it would appear that things need to be restructured a bit from the current implementation in this PR if possible


Example for 7.1.0 is effectively useless

First of all thank you for your work on this gem!
I have an issue with the devise example for Rails 7.1.0, you will find it has:

Started a Rails app;
Added the gem;
Ran the installer and followed its instructions;
Nothing else.

There is no actual example on how the Gem is used at all within a basic application, instead it is only showing us what it looks like to have the gem installed.
This is effectively useless, and will waste the time of everyone who opens this example.

Thanks, that example is not something Devise / heartcombo is related with in any way, so if you feel like their Readme doesn't show enough steps to help someone get started, feel free to open an issue there.
If you feel like you can improve Devise's readme, PRs are welcome.

Hi @carlosantoniodasilva
The example is linked in the heartcombo/devise wiki, so it is related.
https://github.com/heartcombo/devise/wiki/Example-Applications

No need to promise, I just wanted to point that out. All the best!


[Bug]: Typescript error

Tremor Version
3.14.1
Link to minimal reproduction

Steps to reproduce
This error occurs right out of the box

What is expected?
No typescript errors upon fresh installation
What is actually happening?
after fresh install the error occurs when i build or compile with typescript checking
What browsers are you seeing the problem on?
Other
Any additional comments?
No response

Have you checked that you are using the workspace version of Typescript and not your IDE? And/or that your IDE TS version is sufficiently updated?

Hi @jptagorda, hard to pinpoint the issue. Have you tried what @thekidnamedkd has suggested?

@thekidnamedkd
My current Typescript version was 5.4.3

@thekidnamedkd
My current Typescript Version was 5.4.3


tuf kms key type is incorrect

tuf/kms.tf now defines an online key for root-signing (not used yet for either prod or staging but will be). This key is EC_SIGN_P384_SHA384 which does not match the current production keytype and is in fact incompatible with cosign.
We should use EC_SIGN_P256_SHA256: this is recommended by GCP and should match the production keytype

@haydentherapper I can handle this on monday if you don't do it by then.
I'm not totally sure what the right method is though.

changing only the algorithm likely just changes the "algorithm for next version of this key"
I think there's no way to manually trigger a new key version?
Does terraform create  a completely new key if I change tuf_key_name value and the algorithm?

https://github.com/sigstore/scaffolding/pull/949 for the fix. I think you can create a new key version resource to force a new version to be created in terraform.
The other option is to create a new key with a new name.