chore(dashboard): Add filter_scopes warning message for json metadata editor

SUMMARY
Since the existing dashboardState overwrite the filter_scopes directly by the UI state from the filter mapping menu, the filter_scopes changes made from json metadata editor can be lost.
https://github.com/apache/superset/blob/e438c967c9fd3452d8f5aa811a43bce6ae8ffbd2/superset-frontend/src/dashboard/actions/dashboardState.js#L385-L390
This commit adds the warning message of filter_scopes changes and then links to the filter mapping menu for the alternative.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
https://user-images.githubusercontent.com/1392866/191609445-a1756f32-c5a9-44cd-9200-8905f396cb28.mov
TESTING INSTRUCTIONS

Go to a dashboard
Click "edit" and "edit properties"
Click "advanced" to open json editor
check the warning message

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Required feature flags:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

Can we maybe just remove those unconfigurable fields from the JSON displayed to the users---and add them back before posting to the API?


A way to handle null byte better

Hi, we are using golex in prometheus instead of the previous hand-written parser and the performance benefit has been amazing.
But we need to support null-bytes \0 in the text being parsed. For example, we need to be able to parse <string>{<string>="<string-with-null-byte>"}
But because we use \0 for EOF, we are not able to do it. For example: <string>{<string>=" results in an infinite loop as we added \0 as a special character for that state here.
Do you have any ideas as to how we can handle null-byte better?
/cc @fabxc

Hi, we are using golex in prometheus instead of the previous hand-written parser and the performance benefit has been amazing.

Glad to hear! Do you have some numbers to share?

But we need to support null-bytes \0 in the text being parsed.

Maybe you can use the lex library and use character classes to map EOF to a character class of its own, like for example here. Feel free to ask me on things that are not documented clearly enough.
I haven't tried, but maybe in this case a simpler solution can work. Move this line so it becomes the last rule - they are considered in order of appearance. I'm not sure if it solves the issue, but at least it's easy to try it ;-)

Sorry for the late reply, let me explain it better:
So we are now allowing any number of \0 after the " (in ), for example a{b="a\0c"} and a{b="a\0\0c"} are both valid. Now take this string: a{b="d, after d is read, next() will always return 0 but the lexer tries to consume as many \0 so it keeps calling next() without terminating.
I think using classes would fix it and lex. RuneEOF is mapped to -1, but I think it would complicate it from the current system a fair bit. I did not have enough time to look at it today, but will take another look tomorrow and update here.

I kinda hacked it in for now :) Made sure that c.next() eats up the null-byte rather than expose it to the lexer/parser.
Ref: https://github.com/prometheus/prometheus/pull/2915/files#diff-04e1328eadf10e9e126988700965fc7f

I kinda hacked it in for now :) Made sure that c.next() eats up the null-byte rather than expose it to the lexer/parser.

If it's a correct solution then it's a good one ;-)
Later I realized that there's another possibility, provided you handle UTF-8 input. There are several bytes which can never legaly appear in UTF-8, like 0xFF and all other red cells in this table, so it's safe to remap EOF to one of those bytes. Unless you need to somehow continue processing input past any invalid UTF-8 sequence as well (compilers might do that, for example).

@Gouthamve  I see the PR is already merged, I assume there's nothing left to do here. Feel free to repoen if you think otherwise.


4.0.103 Angular4 - post-robot error

Description
Please provide a short description of the issue here, along with:

[X] All console logs during the time of the issue, especially error messages

I am using braintree-web + paypal-checkout on my Angular 4 website.
The paypal-checkout v4.0.95 worked fine, after I upgraded to v4.0.103 I am getting the follwoing errors:

After this the paypal integration seems to work, I am able to add payment methods most of the time, however this error did not occur before.
Steps to reproduce
Rendering the paypal button using paypal.Button.render.
Affected browsers

[X] Chrome
[X] Safari
[X] Firefox

I tested different versions and this error first appears in the version 4.0.100.
4.0.99 works fine.

I suspect this commit might be the cause: 8de8b834d4e652e553667403a225e36aa3faabee

Thanks for the report. I think I know the root cause. I'll try to get a fix for this out tomorrow.

Thanks a lot!

The fix is pushed and your issue should now be resolved -- please let me know if you still see the problem. Thanks!

This issue reappeared from the version 4.0.117 again @bluepnume

I'm also having this error, changing back to 4.0.113 resolved the issue for me

@AlanMenhennet  4.0.116 works fine for me, it broke from the version 4.0.117


Translation Updates Lab 02

Lab 6
名前 should be "First name"
Replacing these characters with "First name" for one specified location changes fields in many other locations. Be best to do this one edit into instructions themselves manually.

Hello contributor,
Thank you for your contribution! We are processing your suggestions and we will update you shortly.
Kind regards,
Microsoft Worldwide Learning Team

N/A as page has changed


Angular CLI taking lot of time to build Angular Application

🐞 Bug report
Command (mark with an x)

- [ ] new
- [x] build
- [ ] serve
- [ ] test
- [ ] e2e
- [ ] generate
- [ ] add
- [ ] update
- [ ] lint
- [ ] xi18n
- [ ] run
- [ ] config
- [ ] help
- [ ] version
- [ ] doc

Is this a regression?

 No
Description
 Angular CLI taking more than 15 minute to build Angular Application. Any way to speed up the build process keeping build preference same?
Below are the specifications of my application,
I am using following command to build my application ( Normal ng build --prod is throwing Javascript heap related error )

node --max_old_space_size=5048 ./node_modules/@angular/cli/bin/ng build --prod

Application is huge and it has following module, component counts,

🔬 Minimal Reproduction

🔥 Exception or Error

🌍 Your Environment

Angular CLI: 6.2.8
Node: 8.11.2
OS: darwin x64
Angular: 6.1.10
... animations, common, compiler, compiler-cli, core, forms
... http, language-service, platform-browser
... platform-browser-dynamic, router

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.6.8
@angular-devkit/build-angular     0.6.8
@angular-devkit/build-optimizer   0.6.8
@angular-devkit/core              0.6.8
@angular-devkit/schematics        0.8.8
@angular/cdk                      6.4.7
@angular/cli                      6.2.8
@angular/flex-layout              6.0.0-beta.18
@angular/material                 6.4.7
@ngtools/webpack                  6.0.8
@schematics/angular               0.8.8
@schematics/update                0.8.8
rxjs                              6.3.3
typescript                        2.7.2
webpack                           4.8.3

Anything else relevant?

Same thing here.
App is quite big and produces close to 200 chunks with:
node --max_old_space_size=12288 node_modules/@angular/cli/bin/ng build --prod --build-optimizer
Takes around 700s on an i7 3630qm with 16gB RAM.
Only 1 or 2 out of 8 available threads are consuming 100% CPU rest are mostly sub 10% usage.

Numerous improvements regarding memory usage and overall performance have been made since the 6.x and 7.x versions were released.  Please consider upgrading to the latest stable version of the Angular CLI (currently 8.3.22).  Upgrading Node.js to version 12 should provide performance benefits as well.
If problems persist after upgrading, please open a new issue detailing the issue.


Pr52

closes #52

Thank you for this pull request! Please check this document for how the Jenkins project handles pull requests.


f3d help is broken on Windows

Describe the bug
f3d --help on Git bash on Windows is displaying the key bindings weirdly.

To Reproduce
Steps to reproduce the behavior:

Launch a git bash terminal on Windows
Run f3d --help

System Information:

OS: Windows
GPU and GPU driver: RTX 2070

F3D Information
Paste the content of f3d --version:
f3d 1.2.1

F3D - A fast and minimalist 3D viewer
Version: 1.2.1
Build date: 2021-12-13 23:27:00
System: Windows-10.0.17763 AMD64
Compiler: MSVC 19.29.30137.0
RayTracing module: OFF
Exodus module: ON
OpenCASCADE module: 7.6.0 (no metadata)
Assimp module: 5.1.0
VTK version: 9.1.20211124 (build 20211124)

Copyright (C) 2019-2021 Kitware SAS.
Copyright (C) 2021-2022 Michael Migliore, Mathieu Westphal.
License BSD-3-Clause.
Written by Michael Migliore, Mathieu Westphal and Joachim Pouderoux.

yes

in the windows terminal, nothing is displayed in the terminal, only in the output window.

seems to be fixed on master.


Stage azure pipelines jobs and add test result aggregation

Summary
This commit reworks our azure pipelines CI flow to use resources more
responsibly. Previously we ran all the CI jobs at once which means we
took 9 jobs from are capacity all at once for each commit. This is
particularly wasteful if we end up running 9 jobs when one can tell us
it won't work. To improve this situation this commit makes the jobs run
in 2 stages. The first stage runs the python 3.5 tests on linux and
macOS first. These jobs also include the lint checker. If these jobs
both succeed then it will continue on to run tests on windows and python
3.6 and 3.7 for macOS and Linux.
At the same time this also adds test result reporting to all the test jobs.
Azure pipelines provides an interface to aggregate test results from
multiple test runs over time. To accomplish a small script is added to
tools/ to generate an xml file in the format azure understands from
the native subunit stream generated by stestr. We lose a little information
in this process but since this is baked into azure pipelines we are limited
to what they support.
Details and comments
This supersedes #1576

If you'd like to see the test data aggregation that this provides see:
https://dev.azure.com/qiskit-ci/qiskit-terra/_build/results?buildId=1448&view=ms.vss-test-web.build-test-results-tab
for the build level and:
https://dev.azure.com/qiskit-ci/qiskit-terra/_test/analytics?definitionId=1&contextType=build
for the overall


The wrong snapshot from Start a chat session

From
https://learn.microsoft.com/en-us/azure/cognitive-services/openai/chatgpt-quickstart?tabs=command-line&pivots=programming-language-studio#start-a-chat-session
The second picture is all the same with the first one. is this expected?
To me, the second picture should start with questions ""which models support 4K?"

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 4833a089-660d-364f-82a4-1fc26522b6ec
Version Independent ID: 2c415b16-f888-a44b-64d7-a9d1732dacb6
Content: Quickstart - Get started using ChatGPT (Preview) and GPT-4 (Preview) with Azure OpenAI Service - Azure OpenAI Service
Content Source: articles/cognitive-services/openai/chatgpt-quickstart.md
Service: cognitive-services
Sub-service: openai
GitHub Login: @mrbullwinkle
Microsoft Alias: mbullwin

@vipwlb
Thanks for your feedback! We will investigate and update as appropriate.

@mrbullwinkle
Could you please review add comments on this, update as appropriate.

@vipwlb
Thank you for bringing this to our attention.
I've delegated this to content author @mrbullwinkle, who will review it and offer their insightful opinions.

@vipwlb thanks for calling this out. The updated screenshot was already there, but the file path to the updated screenshot was incorrect. I have fixed the file path and the screenshot is now rendering as expected internally:

The change fixing this is merged and will go live this afternoon. Thanks for helping us to improve the docs!


fix(trace-agent): Add fleetcfgpath flag

What does this PR do?
Follow-up of https://github.com/DataDog/datadog-agent/pull/28067, there was a parameter missing for the trace agent run command.
Motivation
Same as https://github.com/DataDog/datadog-agent/pull/28067/s
Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

/merge


Refactoring and quality of life improvements

I hope you are doing well. I recently found your project, and think it has a lot of potential.
I made some refactoring and quality-of-life changes that I hope will make the code more maintainable and easier to work with. If you have any concerns about these changes or if any issues need to be addressed, please don't hesitate to let me know. I want to ensure that the project is as practical and functional as possible, and I'm happy to revert any changes that aren't meeting that goal or if you think that these changes wouldn't be as useful.
In the future, I would like to improve the stability of the extension. However, this will take more time and probably needs some more refactoring.
(85% of this text was generated by ChatGPT)

(85% of this text was generated by ChatGPT)

I should really start using ChatGPT to code. I'm still old school despite working with ChatGPT so much

Tested. It works well.

Thanks @acheong08 for this wonderful solution, and @kihayu for contributing.
@kihayu, if you don't mind me asking – what exactly did you workflow in creating this pull request look like? Do you have any tricks to share?

(85% of this text was generated by ChatGPT)

I should really start using ChatGPT to code. I'm still old school despite working with ChatGPT so much

I'm also new to using ChatGPT for coding. I think there was a misunderstanding. With the generated text I mean the description of the pr. The code was written by me.

Ah. That makes a lot more sense. The code is way too high quality to be by ChatGPT. Thank you so much for your contribution

Thanks @acheong08 for this wonderful solution, and @kihayu for contributing.
@kihayu, if you don't mind me asking – what exactly did your workflow in creating this pull request look like? Do you have any tricks to share?

No problem. I can share how I developed these features. This is quite similar to how I do it at work.

I created a branch and named it so, that the naming represents the main changes in what I did. Regarding the "feature/" prefix, search for "git branch naming conventions" and read about it. It will help to keep things a bit more organized.
After that I coded one feature at a time and tried to commit similar changes at once.
Then I tested everything, fixed bugs, and committed the changes. This step repeats as long as necessary.
At the end I created the PR and wrote a description. In the future, I will write down what changes happened in the code. This time it wouldn't make that much sense because the changes were only some refactoring and structure changes

I created a branch and named it so, that the naming represents the main changes in what I did. Regarding the "feature/" prefix, search for "git branch naming conventions" and read about it. It will help to keep things a bit more organized.

I will start doing that from now on. I have seen this style used in most large repos but never implemented it myself due to laziness.


Feature/notify draft object

Description
Each object would have a notification next to its title when there is any drafts been saved
Related issues
https://github.com/CSCfi/metadata-submitter-frontend/issues/107
Type of change

[x] New feature (non-breaking change which adds functionality)

Changes Made

Add a notification badge next to object title to count the saved drafts in each object
Change button Save to Submit object
Auto-saving time for draft changes from 5s to 60s
New button Save as Draft is added so the user can manually save a form as a draft object
Unit test for showing the correct number of saved drafts in each object

Testing

[x] Unit Tests
[x] Needs testing (start an issue or do a follow up PR about it)

Looks good to me as well pretty sure we need the #116 to clarify how we can use them.
Will merge as is


[Release-1.29] - Failure to read certificates and key files during k3s certificate rotate-ca

Backport fix for Failure to read certificates and key files during k3s certificate rotate-ca

#10689

##Environment Details
Reproduced using VERSION=v1.29.8+k3s1
Validated using COMMIT=0dfad66a35860c252c9547a682c37ec4dd293433
Infrastructure

[X] Cloud

Node(s) CPU architecture, OS, and version:
Linux 6.4.0-150600.23.17-default x86_64 GNU/Linux
PRETTY_NAME="SUSE Linux Enterprise Server 15 SP6"
Cluster Configuration:
NAME             STATUS   ROLES                       AGE     VERSION
ip-1-1-3-2       Ready    control-plane,etcd,master   4h11m   v1.29.8+k3s-0dfad66a

Config.yaml:
node-external-ip: <IP_ADDRESS>
token: YOUR_TOKEN_HERE
write-kubeconfig-mode: 644
debug: true
cluster-init: true

Reproduction

$ curl https://get.k3s.io --output install-"k3s".sh
$ sudo chmod +x install-"k3s".sh
$ sudo groupadd --system etcd && sudo useradd -s /sbin/nologin --system -g etcd etcd
$ sudo modprobe ip_vs_rr
$ sudo modprobe ip_vs_wrr
$ sudo modprobe ip_vs_sh
$ sudo printf "on_oovm.panic_on_oom=0 \nvm.overcommit_memory=1 \nkernel.panic=10 \nkernel.panic_ps=1 \nkernel.panic_on_oops=1 \n" > ~/60-rke2-cis.conf ~/90-kubelet.conf
$ sudo cp 90-kubelet.conf /etc/sysctl.d/
$ sudo systemctl restart systemd-sysctl
$ VERSION=v1.29.8+k3s1
$ sudo INSTALL_K3S_VERSION=$VERSION INSTALL_K3S_EXEC=server ./install-k3s.sh
$ sudo ls -lah /var/lib/rancher/k3s/server/tls/
$ sudo mkdir -p /opt/k3s/server/tls
$ openssl version | grep -qF 'OpenSSL 3' && OPENSSL_GENRSA_FLAGS=-traditional
$ sudo openssl genrsa ${OPENSSL_GENRSA_FLAGS:-} -out /opt/k3s/server/tls/service.key 2048
$ sudo cat /var/lib/rancher/k3s/server/tls/service.key >> /opt/k3s/server/tls/service.key
$ sudo ls /opt/k3s/server/tls/
$ sudo /usr/local/bin/k3s certificate rotate-ca --path=/opt/k3s/server
$ sudo journalctl -u k3s | grep -i 'certificate error'
$ sudo /usr/local/bin/k3s certificate rotate-ca --path=/opt/k3s/server --force
$ COMMIT=0dfad66a35860c252c9547a682c37ec4dd293433
$ sudo INSTALL_K3S_COMMIT=$COMMIT INSTALL_K3S_EXEC=server ./install-k3s.sh
$ sudo /usr/local/bin/k3s certificate rotate-ca --path=/opt/k3s/server

Results:
$ sudo /usr/local/bin/k3s certificate rotate-ca --path=/opt/k3s/server
WARN[0000] failed to read /opt/k3s/server/tls/server-ca.key
WARN[0000] failed to read /opt/k3s/server/tls/client-ca.crt
WARN[0000] failed to read /opt/k3s/server/tls/request-header-ca.crt
WARN[0000] failed to read /opt/k3s/server/tls/client-ca.key
WARN[0000] failed to read /opt/k3s/server/tls/request-header-ca.key
WARN[0000] failed to read /opt/k3s/server/tls/etcd/peer-ca.key
WARN[0000] failed to read /opt/k3s/server/tls/server-ca.crt
WARN[0000] failed to read /opt/k3s/server/tls/etcd/server-ca.crt
WARN[0000] failed to read /opt/k3s/server/tls/etcd/server-ca.key
WARN[0000] failed to read /opt/k3s/server/tls/etcd/peer-ca.crt
FATA[0000] see server log for details: Internal error occurred: certificate error ID 15326

$ sudo journalctl -u k3s | grep -i 'certificate error'
Sep 12 18:11:59 k3s[16973]: time="2024-09-12T18:11:59Z" level=error msg="certificate error ID 15326: failed to validate new CA certificates and keys: ETCDServerCA: new CA is self-signed, ETCDServerCAKey: new CA cert and key cannot be loaded as X590KeyPair: open /tmp/cacerts937781426/tls/etcd/server-ca.key: no such file or directory, ETCDPeerCA: new CA is self-signed, ETCDPeerCAKey: new CA cert and key cannot be loaded as X590KeyPair: open /tmp/cacerts937781426/tls/etcd/peer-ca.key: no such file or directory, ServerCA: new CA is self-signed, ServerCAKey: new CA cert and key cannot be loaded as X590KeyPair: open /tmp/cacerts937781426/tls/server-ca.key: no such file or directory, ClientCA: new CA is self-signed, ClientCAKey: new CA cert and key cannot be loaded as X590KeyPair: open /tmp/cacerts937781426/tls/client-ca.key: no such file or directory, RequestHeaderCA: new CA is self-signed, RequestHeaderCAKey: new CA cert and key cannot be loaded as X590KeyPair: open /tmp/cacerts937781426/tls/request-header-ca.key: no such file or directory"
Sep 12 18:11:59 k3s[16973]: time="2024-09-12T18:11:59Z" level=error msg="Sending HTTP 500 response to <IP_ADDRESS>:44526: certificate error ID 15326"

--force does seem to workaround this issue
$  sudo /usr/local/bin/k3s certificate rotate-ca --path=/opt/k3s/server --force
WARN[0000] failed to read /opt/k3s/server/tls/etcd/peer-ca.key
WARN[0000] failed to read /opt/k3s/server/tls/server-ca.key
WARN[0000] failed to read /opt/k3s/server/tls/client-ca.key
WARN[0000] failed to read /opt/k3s/server/tls/request-header-ca.key
WARN[0000] failed to read /opt/k3s/server/tls/etcd/peer-ca.crt
WARN[0000] failed to read /opt/k3s/server/tls/server-ca.crt
WARN[0000] failed to read /opt/k3s/server/tls/etcd/server-ca.crt
WARN[0000] failed to read /opt/k3s/server/tls/client-ca.crt
WARN[0000] failed to read /opt/k3s/server/tls/request-header-ca.crt
WARN[0000] failed to read /opt/k3s/server/tls/etcd/server-ca.key
certificates saved to datastore

$ COMMIT=0dfad66a35860c252c9547a682c37ec4dd293433
$ sudo INSTALL_K3S_COMMIT=$COMMIT INSTALL_K3S_EXEC=server ./install-k3s.sh
[INFO]  Using commit 0dfad66a35860c252c9547a682c37ec4dd293433 as release
[INFO]  Downloading hash https://k3s-ci-builds.s3.amazonaws.com/k3s-0dfad66a35860c252c9547a682c37ec4dd293433.sha256sum
[INFO]  Downloading binary https://k3s-ci-builds.s3.amazonaws.com/k3s-0dfad66a35860c252c9547a682c37ec4dd293433
[INFO]  Verifying binary download
[INFO]  Installing k3s to /usr/local/bin/k3s
[INFO]  Skipping installation of SELinux RPM
[INFO]  Skipping /usr/local/bin/kubectl symlink to k3s, already exists
[INFO]  Skipping /usr/local/bin/crictl symlink to k3s, already exists
[INFO]  Skipping /usr/local/bin/ctr symlink to k3s, already exists
[INFO]  Creating killall script /usr/local/bin/k3s-killall.sh
[INFO]  Creating uninstall script /usr/local/bin/k3s-uninstall.sh
[INFO]  env: Creating environment file /etc/systemd/system/k3s.service.env
[INFO]  systemd: Creating service file /etc/systemd/system/k3s.service
[INFO]  systemd: Enabling k3s unit
Created symlink /etc/systemd/system/multi-user.target.wants/k3s.service → /etc/systemd/system/k3s.service.
[INFO]  systemd: Starting k3s

$ sudo /usr/local/bin/k3s certificate rotate-ca --path=/opt/k3s/server
WARN[0000] failed to stat ETCDPeerCAKey: stat /opt/k3s/server/tls/etcd/peer-ca.key: no such file or directory
WARN[0000] failed to stat ClientCA: stat /opt/k3s/server/tls/client-ca.crt: no such file or directory
WARN[0000] failed to stat RequestHeaderCAKey: stat /opt/k3s/server/tls/request-header-ca.key: no such file or directory
WARN[0000] failed to stat ETCDPeerCA: stat /opt/k3s/server/tls/etcd/peer-ca.crt: no such file or directory
WARN[0000] failed to stat ServerCAKey: stat /opt/k3s/server/tls/server-ca.key: no such file or directory
WARN[0000] failed to stat ClientCAKey: stat /opt/k3s/server/tls/client-ca.key: no such file or directory
WARN[0000] failed to stat RequestHeaderCA: stat /opt/k3s/server/tls/request-header-ca.crt: no such file or directory
WARN[0000] failed to stat ETCDServerCAKey: stat /opt/k3s/server/tls/etcd/server-ca.key: no such file or directory
WARN[0000] failed to stat ETCDServerCA: stat /opt/k3s/server/tls/etcd/server-ca.crt: no such file or directory
WARN[0000] failed to stat ServerCA: stat /opt/k3s/server/tls/server-ca.crt: no such file or directory
certificates saved to datastore


dependencies: pinned SQLAlchemy-Utils

Coverage remained the same at 0.0% when pulling 1e1e12e9acecb3ceae9d5737f8fc79081c2c2614 on topless:pin-sql-alchemy-utils into 18d5e90d4ef758ac31a3939385074bd7ec9bbaab on inveniosoftware:v3.2.

Coverage remained the same at 0.0% when pulling 1e1e12e9acecb3ceae9d5737f8fc79081c2c2614 on topless:pin-sql-alchemy-utils into 18d5e90d4ef758ac31a3939385074bd7ec9bbaab on inveniosoftware:v3.2.

Coverage remained the same at 0.0% when pulling 1e1e12e9acecb3ceae9d5737f8fc79081c2c2614 on topless:pin-sql-alchemy-utils into 18d5e90d4ef758ac31a3939385074bd7ec9bbaab on inveniosoftware:v3.2.


Add nizamhawa's file

created a branch, created a file and made a commit, and opened a pull
request.

created a branch, created a file and made a commit, and opened a pull request


Don't round the tabs

I hate the rounded tab look. Doesn't mesh well with the Windows 10 UI.

The Windows 10 UI will be getting rounded controls and dialogs

Source?

Source?

The Win UI controls have been updated to have rounded corners, and this is under the guidance of the Fluent / Windows Design Team

Interesting. Personally it clashes with thr square UI box the terminal is contained in. But the UI still has a lot of bugs.

Windows 10 20H1 is where any Shell changes to window shapes etc will come, if they come.
Then there is Windows 10X which has an entirely new shell, as will the new XBoxes

thanks for the info

Seems addressed. Sorry, we're not changing the design of Windows.

VS Code doesn't round the tab bars, and I am still not convinced this governed by updates to the Win UI control changes  since I haven't seen any other software UI with tabs that have them as rounded as they are in the new terminal

microsoft/microsoft-ui-xaml/v2.2.190917002 and https://github.com/microsoft/microsoft-ui-xaml/v2.3.191007001-prerelease (the later of which we're using) both include multiple patches to round the corners for various UI elements. The long-term roadmap for Windows XAML UI elements is a shift towards more rounded corners. Just because other software hasn't yet ingested the absolutely latest bits doesn't mean that it's not a change that's coming.
@mdtauk might be able to pull up a WinUI roadmap, though I don't know where that lives.

Ok thank you very much. I suppose VS Code will incorporate some of these UI XAML elements in the future.

The new chromium Edge tabs are rounded, and the WinUI team is trying to converge on that design


Use of "adjacent sibling" with "universal selector" triggers performance issue in Chrome

Prerequisites

[X] I have searched for duplicate or closed issues
[X] I have validated any HTML to avoid common problems
[X] I have read the contributing guidelines

Describe the issue
The CSS selector legend + * was added in commit c51e9fa4ee8fe8020decec064803e686eb9e1dde to fix a wrapping bug for Bootstrap v5.
Unfortunately, Google Chrome will re-check the styles of every sibling element when:

the CSS selector legend + * is used; and
we insert an element into any existing container element

This means that using Bootstrap v5 and dynamic DOM updates can create a performance issue in Google Chrome. For example, when using React virtualization we may have thousands of elements in a container and then add/remove a few sibling elements on each scroll event. The legend + * selector causes Chrome to recalculate the styles of every element, not just the newly added ones. This happens even if our DOM contains no legend elements.
This issue has already been reported to Chromium as issue 1305839.
Reduced test cases
https://codepen.io/paharvey/pen/rNpaaGe
What operating system(s) are you seeing the problem on?
Windows
What browser(s) are you seeing the problem on?
Chrome
What version of Bootstrap are you using?
v5.1.3

Not too concerned with this, so closing as stale.

As a sidenote on the topic, one may try to use CSS containment on the added elements to mitigate the issue.

Sorry, but based on my reading I don't understand how CSS containment could mitigate the problem.
https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_containment


ruff not respecting python version on typing stub files?

I used mypy's stubgen to generate a .pyi file for a C extension module. Some functions return a tuple. It looks a bit like this.
from typing import Tuple

def get_sim_time() -> Tuple[int, int]: ...

My project's target-version = "py37", but I'm getting a UP006 error for not preferring the use of PEP585 annotations of tuple. This PEP wasn't accepted until Python 3.9.

Nvm, this was fixed in a newer version.

Never never mind. Tools be gaslighting me. This is still an issue. ruff version 0.1.9.

This looks intentional
https://github.com/astral-sh/ruff/blob/b0ae1199e8ccab439db91ec6aa78fa51f2f591bb/crates/ruff_linter/src/checkers/ast/analyze/expression.rs#L290-L298
From the documentation

This rule is enabled when targeting Python 3.9 or later (see:
[target-version]). By default, it's also enabled for earlier Python
versions if from __future__ import annotations is present, as
__future__ annotations are not evaluated at runtime. If your code relies
on runtime type annotations (either directly or via a library like
Pydantic), you can disable this behavior for Python versions prior to 3.9
by setting [pyupgrade.keep-runtime-typing] to true.

I believe stub files are always treated as using future annotation semantics?

Seems corroborated by https://github.com/astral-sh/ruff/issues/5649

Does this imply that all tools that might consume a stub file are required to support the future syntax, regardless of the version of Python they may be running on/assuming?

I see this.

Type stubs are syntactically valid Python 3.7 files with a .pyi suffix. The Python syntax used for type stubs is independent from the Python versions supported by the implementation, and from the Python version the type checker runs under (if any). Therefore, type stub authors should use the latest available syntax features in stubs (up to Python 3.7), even if the implementation supports older, pre-3.7 Python versions. Type checker authors are encouraged to support syntax features from post-3.7 Python versions, although type stub authors should not use such features if they wish to maintain compatibility with all type checkers.
For example, Python 3.7 added the async keyword (see PEP 492 [3]). Stub authors should use it to mark coroutines, even if the implementation still uses the @coroutine decorator. On the other hand, type stubs should not use the positional-only syntax from PEP 570 [7], introduced in Python 3.8, although type checker authors are encouraged to support it.
Stubs are treated as if from future import annotations is enabled. In particular, built-in generics, pipe union syntax (X | Y), and forward references can be used.

Specifically

On the other hand, type stubs should not use the positional-only syntax from PEP 570 [7], introduced in Python 3.8, although type checker authors are encouraged to support it.

This seems to imply that enforcing 3.9 syntax here is not correct unless the user says they are only support 3.9 and up.

That's a good question!

The Python syntax used for type stubs is independent from the Python versions supported by the implementation, and from the Python version the type checker runs under (if any).
...
Stubs are treated as if from future import annotations is enabled. In particular, built-in generics, pipe union syntax (X | Y), and forward references can be used.

These seem to support our behavior.

On the other hand, type stubs should not use the positional-only syntax from PEP 570 [7], introduced in Python 3.8, although type checker authors are encouraged to support it.

This is different. This is a new syntax for declaring parameters, i.e. the introduction of /, not a different type annotation. This would break the assumption:

Type stubs are syntactically valid Python 3.7 files with a .pyi suffix.

So why would mypy output typing.Tuple rather than tuple? And even if that goes against what was propounded above, why wouldn't implementation trump our interpretation?

To clarify, are you seeing any problem using tuple rather than typing.Tuple? Or you’re wondering why Mypy would output typing.Tuple, despite it accepting either?
(As an aside, many of
the quoted sections about seem to be about syntax, like the async keyword. This isn’t a question of syntax — it’s a question of semantics. And the Mypy docs make clear that you can use standard-library generics in type stubs.)

Well I guess this is an issue I should file with mypy to see if they have a reason for the madness. Otherwise I guess I'll just check it in and hope it doesn't break anything.

I think ruff's behaviour is correct here.
If mypy, pyright, or any other type checker is rejecting PEP-585 syntax in a stub file when you're running that type checker with --python-version=3.8 or lower, that's absolutely a bug with that type checker that you should file with them. We long ago agreed in the typing community that stub authors should be able to use newer typing idioms even if targeting older Python versions — since stubs are never executed at runtime, whether or not tuple is actually subscriptable at runtime is irrelevant in a stub file. (But note the caveat @zanieb mentioned in https://github.com/astral-sh/ruff/issues/9285#issuecomment-1869753453 w.r.t. new idioms that required changes to Python's grammar itself vs. those that didn't.)
We've enforced the use of PEP-585 idioms across all of typeshed for a long time now, and stubs in typeshed are tested with mypy, pyright and pytype in CI, across a matrix of all non-EOL Python versions. (While we don't test in CI with Pyre, Pyre also vendors typeshed's stubs.) If a type checker had issues with using this syntax in stub files when targeting older Python versions, I think we would have heard about it by now 🙂

Does this imply that all tools that might consume a stub file are required to support the future syntax, regardless of the version of Python they may be running on/assuming?

Yes, I think so

So why would mypy output typing.Tuple rather than tuple? This is the most recent mypy stubgen installed into a Python 3.11 environment.

That's great a missing stubgen feature: stubgen just hasn't been updated to output PEP-585 idioms yet. It doesn't reveal anything deep about how mypy understands the type.
I agree it would be great if stubgen automatically output stubs that conformed with typeshed's style guide; it would mean we'd have to rely less on autofixes in our typeshed CI :) it just needs someone to find the time to make a stubgen PR to implement it

👍 I agree with @AlexWaygood (and thank you for chiming in). I'm gonna close this as "working as intended".


JsonSurfer cannot parse boolean attributes

Given the following JSON
[{"a": true, "b": 1}, {"a": false, "b": 2}, {"a": false, "b": 3}]

and code
JsonSurferJackson.INSTANCE.collectAll(inputStream, "$[?(@.a==false)]")

JsonSurfer fails with
line 1:9 no viable alternative at input<EMAIL_ADDRESS>
org.antlr.v4.runtime.misc.ParseCancellationException
    at org.antlr.v4.runtime.BailErrorStrategy.recover(BailErrorStrategy.java:51)
    ...
Caused by: org.antlr.v4.runtime.NoViableAltException

Sorry, JsonSurfer currently supports only number and quoted string in the filter clause. I will try to implement it in the next release.

@wanglingsong thank you very much for the reply, any estimates when v1.4.4 can be released? i could really benefit from this feature.

@wanglingsong great stuff, thank you very much!


net: IP Fragmentation and checksum offload causes packet drops

Describe the bug
When IP fragmentation is enabled and if a driver support TCP/IP checksum offload then all packets will be dropped by the driver (or device) as checksum should be calculated before fragmentation and verified after re-assembly. This only works when fragmentation/re-assembly is also offloaded to driver.
To Reproduce
Steps to reproduce the behavior:

Enable either NET_IPV4_FRAGMENT or NET_IPV6_FRAGMENT
Choose a networking device with checksum offload support (I have used a downstream device)
net ping <IP> -s 1473 to trigger IP fragmentation
See error

Expected behavior
Offloaded ping should work. (Applicable for UDP/TCP as well)
Impact
Its a showstopper.
Logs and console output
NA
Environment (please complete the following information):

OS: Zephyr
Toolchain: Zephyr SDK
Downstream fork

Additional context
Linux has couple of solutions for this problem: See https://elixir.bootlin.com/linux/latest/source/include/linux/skbuff.h#L97

Per-packet checksum decision

Each packet has a field to indicate whether driver/HW has calculated the checksum or not, so, for this case Driver can mark as CHECKSUM_NONE to fallback to SW checksum

Leverage HW for payload

RX case: CHECKSUM_COMPLETE HW does a 1's complement checksum for the payload (as submitted to networking stack) and stack can use that to derive other checksums by basic arithmetic like deleting sub-checksums from the final one and finally fold it and verify
TX case: AFAIK, this is still a problem in Linux, as device would need to loop through all frags and update checksum in packet.

For now checksum offload is disabled when IP fragmentation is enabled, but we need to extend existing checksum capabilities in Zephyr to cope with such cases.

It's been a long time since I've read about/used this (back when it was called chimney support) but from memory there's also another case whereby the device supports offloaded checksums but the implementation is bad so it should not use it and continue to use software implementations, the prime name that comes to mind is realtek, so that is something to beware of with this also.

The first troubleshooting step in any networking packet drops is to disable checksum offload :), too many protocols/corner cases to handle.


Fix bugs in image initialization barriers

Description
This fixes a couple of bugs with the image barriers in Apply_InitialState:

The oldLayout in these barriers was incorrect in some cases. This has been changed to always transition from UNDEFINED, because these barriers immediately precede a write.
The depth/stencil aspects could have different reset requirements, which could cause a barrier to transition one of the aspects without the other--this is not allowed without the VK_KHR_separate_depth_stencil_layouts extension.

I think this change is fine but I'd like to ask something for clarification since this might be a source of other bugs if I'm mistaken: The intention with image layouts is that the code in Serialise_BeginCaptureFrame should restore all images to their layout at the start of the frame (even if they have garbage contents on first replay), and ensure that any images sitting in UNDEFINED or invalid layouts move to GENERAL instead. This should happen before the first initial contents apply.
Do you know why that isn't happening in the case you've seen where the images aren't in the right state for the first apply?

Let me look into this a little more. I think my mental model had Serialise_BeginCaptureFrame and Apply_InitialContents in the other order.
The bug was a read-only texture that had transitioned from an incorrect layout (SHADER_READ_ONLY vs UNDEFINED) before being initialized. This caused the copy of the initial contents to do nothing. Because it was read only, the optimizations suppressed the copies on later replays, so the image was never correctly initialized. It sounds like there might be an underlying issue in Serialise_BeginCaptureFrame that is just being hidden by this patch.

That's my possible concern (that there's a bug being hidden), and I can definitely believe there's a bug in the layout reset in Serialise_BeginCaptureFrame. I've fixed bugs there in the past because it has to handle both setting the initial frame-start layouts as well as restoring them again from whatever the layouts end up in at the end of replay (possibly partial, so not necessarily the layout at the end of the captured frame). There's some work done there to reduce the number of barriers so if RenderDoc's layout tracking mismatches with Vulkan's somehow then it would skip a barrier wrongly.
If you have a convenient way to repro the inciting bug again it'd be worth checking, even if this patch gets applied anyway as transitioning from undefined is likely more efficient at replay.

Ok, I figured out what was actually going on:

Serialise_BeginCaptureFrame does the correct transition (UNDEFINED -> SHADER_READ_ONLY);
Apply_InitialContents is called for the backing memory, clearing the memory and putting the image into a bad state;
Apply_InitialContents is called for the image, and the copy does nothing because of the image's bad state.

Transitioning from UNDEFINED before copying in the image contents puts the image back in a good state, and the copy works.
I think this PR does fix this problem, since it ensures that the image is actually in a valid TRANSFER_DST layout before copying. The only related issue I can think of is a memory reset that invalidates  an image, and that image is not re-initialized. However, it looks like this can't actually happen--the image branch of Apply_InitialState already checks the backing memory, and applies a full re-initialization of the image if the backing memory is re-initialized (vk_initstate.cpp:1567).
I think there are still some corner cases where we might want to track which (possibly aliased) resource bound to a memory region is currently valid--if that's an image, the backing memory should probably not be initialized (except possibly for PREINITIALIZED images); on the other hand, if the memory was most recently written through a buffer, then we should initialize the memory, but not initialize any images bound to the same memory. I think such a change might fit in with the work I'm doing on queue family tracking, but will take some time.

Ahh OK, that makes a lot of sense. I thought you'd run into a problem and the validation layers were complaining about a layout mismatch, but what you're describing is more subtle and at least doesn't indicate a layout-tracking bug which is good. Sorry to make you go digging to prove that the fix is OK!
Indeed this PR is good to merge as is, I agree that there may be other corner cases with resource aliasing but for the time being the existing 'reset image if underlying memory is reset' is enough.


Settings app crashes on ARM with latest Community Toolkit version

Microsoft PowerToys version
latest
Installation method
Dev build in Visual Studio
Running as admin
None
Area(s) with issue?
Settings
Steps to reproduce
Try open Settings app from PT tray
✔ Expected Behavior
Settings app opens and works correctly
❌ Actual Behavior
Settings app crashes on startup with
[21:32:45.9264781] [Error] App::App_UnhandledException
    Unhandled exception
Array dimensions exceeded supported range.
Inner exception:

Stack trace:
   at CommunityToolkit.WinUI.Controls.StaggeredLayout.MeasureOverride(VirtualizingLayoutContext context, Size availableSize)
   at Microsoft.UI.Xaml.Controls.VirtualizingLayout.Microsoft.UI.Xaml.Controls.IVirtualizingLayoutOverrides.MeasureOverride(VirtualizingLayoutContext context, Size availableSize)
   at ABI.Microsoft.UI.Xaml.Controls.IVirtualizingLayoutOverrides.Do_Abi_MeasureOverride_2(IntPtr thisPtr, IntPtr context, Size availableSize, Size* result)

Other Software
No response

Same stacktrace reported here https://github.com/CommunityToolkit/Windows/issues/509


Any reason to commit /node_modules?

Wondering if there is any reason to commit /node_modules?
If there is none, I can take care of that, let me know.

Yes, as described in the GitHub Actions docs: https://docs.github.com/en/free-pro-team@latest/actions/creating-actions/creating-a-javascript-action#commit-tag-and-push-your-action-to-github

From your terminal, commit your action.yml, index.js, node_modules, package.json, package-lock.json, and README.md files. If you added a .gitignore file that lists node_modules, you'll need to remove that line to commit the node_modules directory.

They do list one alternative (but I don't feel it's worth the effort with the small size of this proj):

As an alternative to checking in your node_modules directory you can use a tool called @vercel/ncc to compile your code and modules into one file used for distribution.

This is so the action is pre-built and can just be cloned and ran in your workflow.


Simple Vector can throw an error for get function

Found that the Simple Vector will run into compile errors if it is unable to get a an item from its list. The exact error has to do with comparing nullptr to a string (if you are using a string version)
Version: latest SimpleVector (Platformio Version && Library Manager)
This issue is being addressed

Issue has been patched.


Language selector in header is not working

Small UI bug. It used to work before (can't remember exactley when)
Overview of the problem

Description
The language selector on the header is not working.
Steps to Reproduce
-> login to the system
-> enter any page
-> click the language selector icon in the header (the flag)
-> not working.
Expected behavior
See above
Actual behavior
See above

@roy-zahor, I tested it here, works fine from mobile chrome
http://<IP_ADDRESS>/en/home

I don't see the original bug, but there is a problem in the npo page:
reproduction steps

login
click on "npo" link in header
change the language

expected

go to npo page in chosen language

actual

goes to login page

Fixed.


Do you follow SemVer? If yes, can you mention it in README/Changelog?

Most projects assume there is no SemVer when there is no explicit declaration. So kubeclient has ~> 1.0.4 as requirement for recursive-open-struct. This means I have to maintain a patch in debian to be able to install 1.1.0 version. If you state your semver compliance, I can ask kubeclient maintainer to relax the dependency to ~> 1.0.

Hey @pravi recursive-open-struct does follow semver. I will add a statement about it to the readme.


http2

https://www.rfc-editor.org/rfc/authors/rfc9113.html
https://github.com/grpc/grpc/blob/master/doc/PROTOCOL-HTTP2.md
https://bkubiak.github.io/grpc-raw-requests/

and due to the HTTP2 preface, the ABAP tcp client only works if frame size is 1 byte

As of Kernel 773 there is the parameter icm/HTTP/client/support_http2 (default value FALSE, as of Kernel 777: default value TRUE). But not sure when exactly http/2 is used. The http destination's options in SM59 allow only to choose between HTTP 1.0 and 1.1.

ref


python311Packages.python-roborock: 0.23.4 -> 0.23.6

Diff: https://github.com/humbertogontijo/python-roborock/compare/refs/tags/v0.23.4...v0.23.6
Changelog: https://github.com/humbertogontijo/python-roborock/blob/v0.23.6/CHANGELOG.md
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 236718 run on x86_64-linux 1

5 packages built:

home-assistant-component-tests.roborock
python310Packages.python-roborock
python310Packages.python-roborock.dist
python311Packages.python-roborock
python311Packages.python-roborock.dist


Introduce eBPF maps DumpHandler()

What does this PR do?
Introduce a webhook /debug/ebpf_maps aim to dump maps registered in the manager for debug purpose in production.
Motivation
We would like to know the internal state of the ebpf/agent when something look suspicious in production.
Additional Notes
We need this PR to be merged before this one :
Ebpf manager DumpHandler() support : https://github.com/DataDog/ebpf/pull/52 and https://github.com/DataDog/ebpf/pull/53
Describe how to test your changes
Dump all maps :
curl --unix-socket /opt/datadog-agent/run/sysprobe.sock http://localhost/debug/ebpf_maps
Dump specific maps
curl --unix-socket /opt/datadog-agent/run/sysprobe.sock http://localhost/debug/ebpf_maps?maps=conn_stats,conn_close_batch

Can we add a runtime debug command to hit this endpoint, similar to how the config command works? https://github.com/DataDog/datadog-agent/blob/main/cmd/system-probe/app/config.go#L29

I did a simple system-probe debug command that we can use for all debug endpoint, for example :
system-probe debug ebpf_maps?maps=conn_stats,conn_close_batch


"##[error]t is not iterable" after running audit-check

Do the checklist before filing an issue:

[x] Is this related to the actions-rs Actions?
If you think it's a problem related to Github Actions in general, use GitHub Community forum instead: https://github.community
[x] You've read the Contributing section about bugs reporting: https://github.com/actions-rs/.github/blob/master/CONTRIBUTING.md#reporting-bugs
[ ] Is this something you can debug and fix? Send a pull request! Bug fixes and documentation fixes are welcome.

Description
Starting very recently, audit-check began failing! You can see an example output here:
https://github.com/alex/csv-sql/pull/342/checks?check_run_id=650426469
Calling cargo-audit (JSON output)
  /usr/share/rust/.cargo/bin/cargo audit --json
  {"database":{"advisory-count":83,"last-commit":"4565a921dd2212cf4e68ad763b114648907e790d","last-updated":"2020-05-04T23:46:31Z"},"lockfile":{"dependency-count":66},"settings":{"target_arch":null,"target_os":null,"severity":null,"ignore":[],"informational_warnings":["unmaintained"],"package_scope":null},"vulnerabilities":{"found":false,"count":0,"list":[]},"warnings":{"unmaintained":[{"kind":"unmaintained","package":{"name":"term","version":"0.5.2","source":"registry+https://github.com/rust-lang/crates.io-index","checksum":"edd106a334b7657c10b7c540a0106114feadeb4dc314513e97df481d5d966f42","dependencies":[{"name":"byteorder","version":"1.3.4","source":"registry+https://github.com/rust-lang/crates.io-index"},{"name":"dirs","version":"1.0.5","source":null},{"name":"winapi","version":"0.3.8","source":"registry+https://github.com/rust-lang/crates.io-index"}],"replace":null},"advisory":{"id":"RUSTSEC-2018-0015","package":"term","title":"term is looking for a new maintainer","description":"The author of the `term` crate does not have time to maintain it and is looking\nfor a new maintainer.\n\nSome maintained alternatives you can potentially switch to instead, depending\non your needs:\n\n- [`crossterm`](https://github.com/crossterm-rs/crossterm)\n- [`termcolor`](https://crates.io/crates/termcolor)\n- [`yansi`](https://crates.io/crates/yansi)\n","date":"2018-11-19","aliases":[],"references":[],"collection":"crates","categories":[],"keywords":[],"cvss":null,"informational":"unmaintained","obsolete":false,"url":"https://github.com/Stebalien/term/issues/93","patched_versions":[],"unaffected_versions":[]},"versions":{"patched":[],"unaffected":["> 0.6.1"]}}]}}
No vulnerabilities were found
##[warning]undefined warnings found!
##[error]t is not iterable

Workflow code
      - uses: actions-rs/audit-check@v1
        with:
          token: ${{ secrets.GITHUB_TOKEN }}

Expected behavior
It doesn't error out :-)

Wild guess - cargo-audit had changed the output format once again, gonna investigate it

Quick update: cargo-audit definitely had changed, new Action release will be done tomorrow morning

New v1 version was just released, seems to be working correctly now.


Substream run not working with "," as a param

Running with the command :

substreams run -e ip:port prom_out -s  -t +1 -p prom_out="abcdefg,xyz"

Error: param "xyz" invalid, must be of the format: "module=value" or "imported:module=value"
on the other hand

substreams gui -e ip:port prom_out -s  -t +1 -p prom_out="abcdefg,xyz"

works fine

@emiliocramer Can you take a look

Apologies for any confusion caused by my previous example. Here is a revised version:
substreams run -e ip:port prom_out -s <block_number> -t +1 -p prom_out="abcdefg,xyz" (doesn't work)
substreams gui -e ip:port prom_out -s <block_number> -t +1 -p prom_out="abcdefg,xyz" (works)
the difference would be run and gui command.

Hey,
So the issue was just a lack of param handling on the GUI side of things. I've added the proper handling, and now both run and gui should fail with a comma in the param value string, just because the parsing of multiple value flags uses the comma as a delimiter. Example usage: map_params=abc,map_params2=xyz
Hope that clears things up


'date' as input field type produces 'Invalid type, expected date'

First: Thanks for this really cool and easy to use framework!
I would like to use a input field of type 'date' to support browser specific date picker implementations, but it always shows the error 'Invalid type, expected date' and i do not know where this comes from. If I insert an date input field manually and bind it with ng-model to a date object, it seems no problem.
I use the following schema
{
    type: "object",
    properties: {
        birthday: {
            type: "date"
        }
    }
}

form
[
    "*"
]

and configure the schemaFormProvider like this:
angular.module('schemaForm').config(['schemaFormProvider', 'schemaFormDecoratorsProvider', 'sfPathProvider',
    function (schemaFormProvider, schemaFormDecoratorsProvider, sfPathProvider) {
        var datepicker = function (name, schema, options) {
            if (schema.type === 'date') {
                var f = schemaFormProvider.stdFormObj(name, schema, options);
                f.key = options.path;
                f.type = 'date';
                options.lookup[sfPathProvider.stringify(options.path)] = f;
                return f;
            }
        };
        schemaFormProvider.defaults.date = [];
        schemaFormProvider.defaults.date.unshift(datepicker);
    }
]);

Could you tell me where I am going wrong?

Sounds like a validation error?  Ie, your decorator is creating a date input field that is throwing a date as a string on the model, but validation is expecting an actual js Date object on the model?  Make sure whatever date input being generated for that schema object is setup to add a date object on the model.  Generally date inputs will be of type string with format of datetime or something along those lines.  This will allow validation to not throw that error when the string of the date gets applied to the model.

The reason why i do not want to use input of type string is because it would not support the mobile browser specific implementation of date picker. But I think I found the reason why it is throwing a validation error. While validating, the function validateType(...) in the tv4.js is called, where the type of the validated data is determined. In my case the validated data is a js Date object, but is considered as of type object.
So to solve my issue, it changed some small things:
{
    type: "object",
    properties: {
        birthday: {
            type: "object", // object so it matches the type determined in tv4.js
            format: "date"
        }
    }
}

angular.module('schemaForm').config(['schemaFormProvider', 'schemaFormDecoratorsProvider', 'sfPathProvider',
    function (schemaFormProvider, schemaFormDecoratorsProvider, sfPathProvider) {
        var datepicker = function (name, schema, options) {
            if (schema.type === 'object' && schema.format === "date") {
                var f = schemaFormProvider.stdFormObj(name, schema, options);
                f.key = options.path;
                f.type = 'date';
                options.lookup[sfPathProvider.stringify(options.path)] = f;
                return f;
            }
        };
        schemaFormProvider.defaults.object = [];
        schemaFormProvider.defaults.object.unshift(datepicker);
    }
]);

Now the date from the input field is successfully saved in the model. I do not know if it is the final solution that I will use, but is is working for now.

How I fixed it was:
Add this conditional to the /angular-schema-form/src/services/validator.js around line 39
   // Date values
   if ( schema.type === 'string' && schema.format === 'date' ) {
       if ( value === null ) {
           value = undefined;
       } else {
           if ( typeof value.toISOString === 'function' ) {
               value = value.toISOString();
           }
       }
   }

@brianpkelley This fixes the issue, but introduces an issue with the validation. After you clear the field the validation sticks saying it's successful.

https://github.com/json-schema-form/angular-schema-form-material/issues/18
I don't recall the exact circumstances that led me to the solution I posted on the link above, but it may offer more help if needed.

@brianpkelley I'm having a hard time thinking it's best to solve this issue by adding a tv4 format and not adding a solution directly into ASF. It seems @Anthropic really favors your choice. But it seems like creating a decorator to resolve an issue isn't the right path, for something that is provided by default.
However, because I am using a decorator for my date fields ANYWAYS, I have chosen to implement your changes. While this does properly validate the date, with the exception of the validation message not applying the correct message as stated by @brianpkelley's solution in the other thread ema-form/angular-schema-form-material#18 (comment). It is expecting a valid of type object even if the field is not required and shows the field as invalid.

@krptodr I would love to come up with a solution to this that works for everyone, dates are a pain, I assume that's why Textalk made the original datepicker add-on for the library as a separate item. I would like to add a stable datepicker to the bootstrap repo and whatever changes are required here, ideally if there was a main datepicker as part of bootstrap (I don't use bootstrap much so I have never checked) it would be the preferred choice and any behaviour here would have to cater for that. It just isn't high on my TODO list so it wouldn't be for a while unless someone wants to make a PR with one.

Since json schema draft 4 does not support custom types AND has a pre defined string format known as date-time, maybe the best way to tackle this is to force conversion of date objects to strings prior to validation.


Julia: Update version 1 to point to version 1.5

Julia v1.5.0 was released on Aug. 1, 2020.
This changes the permalink for the version specifier "1", which means the latest 1.y.z.
cc: @ararslan

I don't really understand the CI failure here. Is there a spec/test or something we need to update as well?

The ghc version update has tripped the wire.
https://github.com/travis-ci/travis-build/pull/1930 will fix it.
We can ignore this error for the time being.

Okay, great. Can we merge and deploy this change?

Thank you for your quick response.


Dask drop(axis=1) hangs on large datasets

What happened:
After letting dask run for 18+ hours with 75gb memory and 35CPU's, it is unable to drop a column of a 650k x 50k purely numeric (float64) dataset.
What you expected to happen:
Column would drop in a reasonable amount of time.
Minimal Complete Verifiable Example:
Hard to provide complete example with a minimal dataset since the problem is one of scaling, but the code is:
        data = (da.read_csv(
            os.path.join(data_path, 'interim', file),
            assume_missing=True,
            header=1, # need this since calculating transpose adds one extra row, still need to figure out why as it doesn't happen on synthetic data
            sample=1000000, # May need to make this bigger
        ))

        for gene in data.columns:
            if gene not in unique:
                print(f'Dropping gene {gene}')
                data = data.drop(gene, axis=1)
                data = data.persist()

        data.to_csv(
            os.path.join(data_path, 'processed', f'{file[:-4]}.csv'),
            single_file=True,
            index=False,
        )

Anything else we need to know?:
This is running in a Docker container scheduled via Kubernetes to a compute node. If there is any info about the node you need, I can provide it.
However, when working with a smaller (189kx19k purely numeric float64) dataset, dropping 3k columns took only 16 hours.
Environment:
Hosted from PyTorch docker image with some packages installed on to.

Dask version: 2022.2.0
Python version: 3.7.11
Operating System: Linux/amd64
Install method (conda, pip, source): pip

Cluster Dump State:

Hi @jlehrer1, thanks for opening this issue! It seems this is more of a usage question rather than a feature or bug report and we encourage people to ask such questions on the Dask Discourse. Would you mind opening a discussion topic about this over there? If so, feel free to close this issue and we will continue the conversation on discourse.
From a quick look at your snippet, part of the issue may be calling persist within the for gene in data.columns loop. You might find these docs on best practices around using persist helpful as well.

@scharlottej13 Sure, I will. To me, this does seem like a bug, since the .persist() being called on each instance works when the length of the list of columns to drop is actually longer, but the dataset itself is smaller. It seems to me that the code hangs on larger datasets. Should I be setting the number of partitions manually?

@jlehrer1 Thanks for the note. It's generally not recommended to call persist inside a for-loop. In fact, we try to minimize calling persist because it triggers some computations in the background, which goes against the "lazy-evaluation" paradigm of Dask, and hence leads to poor performance. Does this make sense?
I'll go ahead and close this, looking forward to seeing you on Discourse, we can continue this discussion there!


Installing StashServer in Linux

Hi, I've been running stash in a docker container for a while without issue and would like to get stashserver running natively (Ubuntu Linux). I confess I know absolutely nothing about Rails, Angular, etc. but know my way around Linux pretty well.
I've successfully installed all the pre-reqs, bundles, and start the stash server (rails s) no problem. However, when I load the site in my web browser http://ipaddress:4000 an error page tells me there is a Migration pending. Here's the console output:
Started GET "/" for <IP_ADDRESS> at 2018-03-13 01:44:11 -0400
ActiveRecord::PendingMigrationError (
Migrations are pending. To resolve this issue, run:
        bin/rails db:migrate RAILS_ENV=development
):
According to the stacktrace, the following script had the issue:
activerecord (5.1.5) lib/active_record/migration.rb:576:in 'check_pending!'
So, I run the migration (bin/rails db:migrate RAILS_ENV=development) as suggested. The script creates the tables and everything seems to complete ok. I restart nginx, restart stash, and then pull up the stash site in my browser. Now my browser only displays a bit of json that says: {"errors":[{"message":"No query string was present"}]}
Any ideas what might be wrong? I'm sure it's something silly but I just don't know enough about Ruby to fix it myself. Thanks!

I have the same issue as above

Okay, so this project (StashApp/StashServer) is only the Rails app which includes no frontend code.  The {"errors":[{"message":"No query string was present"}]} message you are seeing is the GraphQL API responding.  It's not really meant to be viewed in the browser.
In order to get the UI working you'll need to clone or download the frontend files from https://github.com/StashApp/StashFrontend .  Once you have those files run the following commands from the project directory:
npm install gulp-cli -g (To install Gulp globally if you don't already have it)
npm install
npm install gulp
cd semantic
gulp build
cd ..
ng build --prod
That should (fingers crossed) build the frontend and place the files in the dist directory.  From there you can serve the generated files with nginx.  You might be able to place the files in the rails public directory, but I haven't tried that.
Another option is instead of ng build --prod run this command instead:
ng serve --disableHostCheck --host=<IP_ADDRESS>
That command will run the frontend in it's own server on port 4200.  This is what I do since it's good for development.
Hopefully this helps a bit and you can get the UI running.  I would really love to improve the user experience for getting this all set up, but I'm still unsure of the best way to handle that.  If you have any questions just let me know.

Also I forgot to mention you might want to take a look at the Dockerfile for the project.  It is kinda like the blueprint for what commands to run to get everything set up.  https://github.com/StashApp/StashServer/blob/master/Dockerfile

Thanks for all the help! Good info on the Dockerfile. I'll take a look at that.
I got the CSS to build with a couple of small changes to the source code. However, when I type in ng build --prod A window appears that looks like a text editor or something. Essentially, the screen clears and there is a large blank area where I can type in text. At the bottom of my console is the following
-----Mg: help                             (fundamental)----All-----------------------------------------
I press ctrl-Z a couple of times and it stops whatever is running. Any guidance would be appreciated!

By the way, I will continue to down everything I've done to get StashFrontEnd working in Ubuntu. Once I get everything working I'll update the documentation and create a pull request. I'll create another pull request that includes any bits of code I had to change to get things to compile cleanly.

Not sure what you were seeing when trying to build the frontend...  Here's some steps I just tried which worked for me: https://github.com/StashApp/StashServer/wiki/Ubuntu-17.10 .  There are still some issues though.  There is some sort of parsing error on the settings screen, so you don't see any feedback from any of the buttons on the screen (although the command still runs)

I finally had some time to look at this again. I was able to get the stashserver and the frontend to build running in both Ubuntu 17.10 and Ubuntu Mate 18.04 (beta). Fyi, Ubuntu 16.04 had a lot of issues when trying to build the frontend.
Thank you for all the help and a very cool program! I have a lot of notes regarding how to install things. How much help do you want with the documentation for the frontend and stashserver (if any)? I have notes on everything that needs to be done and could help you with that if you'd like.
As far as making it easier to install, could you just post the requirements (with a couple of one-liners install command) and release a zip file for linux and osx?

Ok, I've added some information on the wiki. I added some requirements to the Linux page for folks who installed more stripped down versions of Ubuntu. I've also added a Mac install section. I'll leave that to you to go through and test since that's what you run as your daily driver seemingly. I'll add some screenshots and how to use Stash when I have time. I'm pretty busy at the moment though. Finally, just so I understand, the "Clean" button just tidies things metadata up when you manually delete a scene from the database right?


Implementation of Backdoor Poisoning Attacks

Description
Generalized implementation of backdoor poisoning attacks with tests and edited notebook example. Fixes an issue with typing of BlackBoxPoisoningAttacks. First implementation of a BlackBoxPoisoningAttack in ART. Also fixed bug during initialization of BlackBoxAttack caused by using None as classifier.
This PR also adds some image manipulation capability to ART. This was done using the PIL package, which is now in requirements.txt (from test_requirements.txt). There has been a test image added to data/backdoors and it is published under an MIT License as a Bootstrap Icon.
Fixes #292
Type of change
Please check all relevant options.

[x] Bug fix (non-breaking)
[x] New feature (non-breaking)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] This change requires a documentation update

Testing
There are tests for each implemented image perturbation as well as failure modes. The tests for image perturbation functions ensures that if creates an effective backdoor. An effective backdoor has:
Tests include basic functionalities of each perturbation function and checks that outputs are compatible with training images.

[x] test_backdoor_pattern for the add_pattern_bd function
[x] test_backdoor_pixel for the add_pixel_bd function
[x] test_backdoor_image for the insert_image function
[x] test_image_failure_modes for testing failure modes of image perturbation functions
[x] test_multiple_perturbations for testing using multiple perturbation functions in the same attack

Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

@beat-buesser thanks for your review. I think I have addressed all of your concerns in my recent commits.

@ebubae Thank you! It looks good to me.


Jnxplus not compatible with nx 17

Hey,
I have tried to use jnxplus with the newest nx 17 version and it is failing (nx-maven).
graph-utils uses workspaceDataDirectory from nx cache-directory. This only exist in nx 19.
It would be nice to either dont use it or increase the minimal nx version listed in nx-maven readme to 19.

My idea is one version of nx should be compatible with a version of nx.
jnxplus 1.x.x is compatible with nx 19: https://github.com/khalilou88/jnxplus/issues/875
So jnxplus 2.x.x will be compatible for nx 20.
If you want to use nx 17, i can remove use of workspaceDataDirectory  in a specific version 0.x.x but maybe the graph has changes since version nx 17

it is fine. I asumed it is 17 compatible, because of the readme:
https://github.com/khalilou88/jnxplus/tree/main/packages/nx-maven
Only 17 is mentioned. Maybe update the readme to prevent confusion.

@khalilou88 yes, we are stil using nx 17. The 0.50.1 seems to work like a charm. Thank you.


How to trigger validation only just before of submitting

I am having serious problems to accomplish what I've say in the title, if I setValue onBlur, and use onSubmit, it sends the value before updating its state.
What I want to do is simple, I wanto to trigger the validation on the form only when the user press enter or use the button.
Any suggestion?

+1

+1

+1

+1

+1

+1

I ended up making my own higher order component that overrides the validate and showError methods.
Something like this:
const HOC = (FormComponent) =>
  React.createClass({
    displayName: 'FormComponent',

    propTypes: {
      disabled: PropTypes.bool,
    },

    mixins: [FormsyMixin],

    // Override formsy's showError because it returns true as soon as
    // the input is invalid (which for required fields is immediately)
    // Instead we return true if the field is invalid AND the form
    // has attempted to be submitted
    ourShowError() {
      return !this.props.disabled &&
        !this.isValid() &&
        (this.isFormSubmitted());
    },

    render() {
      return (
        <FormComponent
          setValidations={this.setValidations}
          setValue={this.setValue}
          resetValue={this.resetValue}
          getValue={this.getValue}
          hasValue={this.hasValue}
          getErrorMessage={this.getErrorMessage}
          getErrorMessages={this.getErrorMessages}
          isFormDisabled={this.isFormDisabled}
          isValid={this.isValid}
          isPristine={this.isPristine}
          isFormSubmitted={this.isFormSubmitted}
          isRequired={this.isRequired}
          showRequired={this.showRequired}
          showError={this.ourShowError}
          isValidValue={this.isValidValue}
          {...this.props}
        />
      );
    },
  });

export default HOC;

@fxfilmxf how do you use this HOC component, can you show me an example, thx

@achtan
...
import HOC from './yourHOC'

class MyComponent extends React.Component {
   fooBar() {
     this.props.getValue() # the HOC exposes it's functionality through this component's props
   }
}
export default HOC(MyComponent);

doesn't onValidSubmit do just that ? It should trigger validations before allow for submission.


Script initializing

Start formatting/ exploring approach the FINAL script

@hiroto-udagawa
We've more on from "starting", final script version 1 is well on it's way


phone1 and 2 Volte register failure after reboot docker of pc

my test steps as the below

Phone 1 call phone phone 2 successfully
reboot docket and pc
launch "source .env"
launch "docker-compose up"
phone 1/2 attach successfully
phone 1/2 enable "VoLTE"  and try to register IMS

step 6 )  is failure , i attached packet as the below , could you help check this ?
phone1 and 2 Volte register failure.zip

Can you make sure the PCRF's Diameter (Rx) connection to PCSCF is in Connected state or not? It needs to be in connected state in order for SIP register to work

Can you make sure the PCRF's Diameter (Rx) connection to PCSCF is in Connected state or not? It needs to be in connected state in order for SIP register to work

phone 1/2 enable "VoLTE" and try to register IMS

Do you mean you toggled the VoLTE on phone after the phones got attached successfully?

phone 1/2 enable "VoLTE" and try to register IMS

Do you mean you toggled the VoLTE on phone after the phones got attached successfully?

phone 1/2 enable "VoLTE" and try to register IMS

Do you mean you toggled the VoLTE on phone after the phones got attached successfully?

==> yes  , and i also try to enable "VoLTE" when phone bring up at the same time

phone 1/2 enable "VoLTE" and try to register IMS

Do you mean you toggled the VoLTE on phone after the phones got attached successfully?

==> yes  , and i also try to enable "VoLTE" when phone bring up at the same time

Can you make sure the PCRF's Diameter (Rx) connection to PCSCF is in Connected state or not? It needs to be in connected state in order for SIP register to work

==> i have no check this , could you teach me how to do ?
i just do "docker-compose up" after reboot pc

Can you make sure the PCRF's Diameter (Rx) connection to PCSCF is in Connected state or not? It needs to be in connected state in order for SIP register to work

==> i have no check this , could you teach me how to do ?
i just do "docker-compose up" after reboot pc

==> i have no check this , could you teach me how to do ?

You need to check the logs and its should say something like the following
[diam] INFO: CONNECTED TO 'pcscf.ims.mnc001.mcc001.3gppnetwork.org' (TCP,soc#14): (../lib/diameter/common/logger.c:108)
Can you send the output of below command?
docker ps

==> i have no check this , could you teach me how to do ?

You need to check the logs and its should say something like the following
[diam] INFO: CONNECTED TO 'pcscf.ims.mnc001.mcc001.3gppnetwork.org' (TCP,soc#14): (../lib/diameter/common/logger.c:108)
Can you send the output of below command?
docker ps

i don't know what happen ,but now i try to reinstall docker and open5gs to check if the phone can be registered

i don't know what happen ,but now i try to reinstall docker and open5gs to check if the phone can be registered

i can do "docker ps"

i can do "docker ps"

output's log:
log.txt
CONTAINER ID   IMAGE                  COMMAND                  CREATED       STATUS          PORTS                                                                                NAMES
c476f5cf3060   docker_open5gs_mme     "/bin/sh -c '/mnt/mm…"   3 hours ago   Up 46 minutes   2123/udp, 3868/sctp, 3868/tcp, 3868/udp, 5868/udp, 5868/sctp, 5868/tcp, <IP_ADDRESS>:36412->36412/sctp   mme
372e4ff32a03   docker_scscf           "/bin/sh -c '/mnt/sc…"   3 hours ago   Up 46 minutes   3870/tcp, 3870/udp, 6060/tcp, 6060/udp                                                              scscf
651e1969f919   docker_icscf           "/bin/sh -c '/mnt/ic…"   3 hours ago   Up 46 minutes   3869/tcp, 3869/udp, 4060/tcp, 4060/udp                                                              icscf
412b5e65b2d1   docker_open5gs_sgwc    "/bin/sh -c '/mnt/sg…"   3 hours ago   Up 46 minutes   2123/udp, 8805/udp                                                                                sgwc
5c568f675fa2   docker_open5gs_amf     "/bin/sh -c '/mnt/am…"   3 hours ago   Up 46 minutes   7777/tcp, <IP_ADDRESS>:38412->38412/sctp                                                                 amf
58e8a6c6a54f   docker_open5gs_sgwu    "/bin/sh -c '/mnt/sg…"   3 hours ago   Up 46 minutes   <IP_ADDRESS>:2152->2152/udp, 8805/udp                                                                    sgwu
e141bc594c85   docker_open5gs_upf     "/bin/sh -c '/mnt/up…"   3 hours ago   Up 46 minutes   2152/udp, 8805/udp                                                                                upf
fd3b2f1bcea8   docker_fhoss           "/bin/sh -c /mnt/fho…"   3 hours ago   Up 46 minutes   3868/tcp, 3868/udp, <IP_ADDRESS>:8080->8080/tcp                                                          fhoss
6a524d32f8c4   docker_open5gs_webui   "/bin/sh -c 'sleep 1…"   3 hours ago   Up 46 minutes   <IP_ADDRESS>:3000->3000/tcp                                                                              webui
89861de337ca   docker_open5gs_udr     "/bin/sh -c '/mnt/ud…"   3 hours ago   Up 46 minutes   7777/tcp                                                                                udr
4e297b2ddf49   docker_open5gs_pcrf    "/bin/sh -c '/mnt/pc…"   3 hours ago   Up 46 minutes   3868/sctp, 3868/tcp, 3868/udp, 5868/sctp, 5868/tcp, 5868/udp                                        pcrf
27f84a7835e5   docker_open5gs_hss     "/bin/sh -c '/mnt/hs…"   3 hours ago   Up 46 minutes   3868/sctp, 3868/tcp, 3868/udp, 5868/sctp, 5868/tcp, 5868/udp                                        hss
c1531df562fd   docker_open5gs_udm     "/bin/sh -c '/mnt/ud…"   3 hours ago   Up 46 minutes   7777/tcp                                                                                udm
46c6114b0198   docker_open5gs_ausf    "/bin/sh -c '/mnt/au…"   3 hours ago   Up 46 minutes   7777/tcp                                                                                ausf
583404fcf806   docker_open5gs_smf     "/bin/sh -c '/mnt/sm…"   3 hours ago   Up 46 minutes   2123/udp, 3868/sctp, 3868/tcp, 3868/udp, 5868/tcp, 5868/udp, 8805/udp, 5868/sctp, 7777/tcp          smf
43481649f71a   docker_dns             "/bin/sh -c '/mnt/dn…"   3 hours ago   Up 46 minutes   53/udp                                                                                dns
f06975a5d11f   docker_open5gs_nrf     "/bin/sh -c '/mnt/nr…"   3 hours ago   Up 46 minutes   7777/tcp                                                                                nrf
1426deefbfe1   docker_open5gs_mongo   "/bin/sh -c /mnt/mon…"   3 hours ago   Up 46 minutes   27017/tcp, 27017/udp                                                                                mongo
e70d5c6f9c08   docker_rtpengine       "/bin/sh -c /mnt/rtp…"   3 hours ago   Up 46 minutes   2223/udp, 49000-50000/udp                                                                           rtpengine
1b2b7962442c   docker_mysql           "/bin/sh -c /mysql_i…"   3 hours ago   Up 46 minutes   3306/tcp                                                                                mysql

output's log:
log.txt
CONTAINER ID   IMAGE                  COMMAND                  CREATED       STATUS          PORTS                                                                                NAMES
c476f5cf3060   docker_open5gs_mme     "/bin/sh -c '/mnt/mm…"   3 hours ago   Up 46 minutes   2123/udp, 3868/sctp, 3868/tcp, 3868/udp, 5868/udp, 5868/sctp, 5868/tcp, <IP_ADDRESS>:36412->36412/sctp   mme
372e4ff32a03   docker_scscf           "/bin/sh -c '/mnt/sc…"   3 hours ago   Up 46 minutes   3870/tcp, 3870/udp, 6060/tcp, 6060/udp                                                              scscf
651e1969f919   docker_icscf           "/bin/sh -c '/mnt/ic…"   3 hours ago   Up 46 minutes   3869/tcp, 3869/udp, 4060/tcp, 4060/udp                                                              icscf
412b5e65b2d1   docker_open5gs_sgwc    "/bin/sh -c '/mnt/sg…"   3 hours ago   Up 46 minutes   2123/udp, 8805/udp                                                                                sgwc
5c568f675fa2   docker_open5gs_amf     "/bin/sh -c '/mnt/am…"   3 hours ago   Up 46 minutes   7777/tcp, <IP_ADDRESS>:38412->38412/sctp                                                                 amf
58e8a6c6a54f   docker_open5gs_sgwu    "/bin/sh -c '/mnt/sg…"   3 hours ago   Up 46 minutes   <IP_ADDRESS>:2152->2152/udp, 8805/udp                                                                    sgwu
e141bc594c85   docker_open5gs_upf     "/bin/sh -c '/mnt/up…"   3 hours ago   Up 46 minutes   2152/udp, 8805/udp                                                                                upf
fd3b2f1bcea8   docker_fhoss           "/bin/sh -c /mnt/fho…"   3 hours ago   Up 46 minutes   3868/tcp, 3868/udp, <IP_ADDRESS>:8080->8080/tcp                                                          fhoss
6a524d32f8c4   docker_open5gs_webui   "/bin/sh -c 'sleep 1…"   3 hours ago   Up 46 minutes   <IP_ADDRESS>:3000->3000/tcp                                                                              webui
89861de337ca   docker_open5gs_udr     "/bin/sh -c '/mnt/ud…"   3 hours ago   Up 46 minutes   7777/tcp                                                                                udr
4e297b2ddf49   docker_open5gs_pcrf    "/bin/sh -c '/mnt/pc…"   3 hours ago   Up 46 minutes   3868/sctp, 3868/tcp, 3868/udp, 5868/sctp, 5868/tcp, 5868/udp                                        pcrf
27f84a7835e5   docker_open5gs_hss     "/bin/sh -c '/mnt/hs…"   3 hours ago   Up 46 minutes   3868/sctp, 3868/tcp, 3868/udp, 5868/sctp, 5868/tcp, 5868/udp                                        hss
c1531df562fd   docker_open5gs_udm     "/bin/sh -c '/mnt/ud…"   3 hours ago   Up 46 minutes   7777/tcp                                                                                udm
46c6114b0198   docker_open5gs_ausf    "/bin/sh -c '/mnt/au…"   3 hours ago   Up 46 minutes   7777/tcp                                                                                ausf
583404fcf806   docker_open5gs_smf     "/bin/sh -c '/mnt/sm…"   3 hours ago   Up 46 minutes   2123/udp, 3868/sctp, 3868/tcp, 3868/udp, 5868/tcp, 5868/udp, 8805/udp, 5868/sctp, 7777/tcp          smf
43481649f71a   docker_dns             "/bin/sh -c '/mnt/dn…"   3 hours ago   Up 46 minutes   53/udp                                                                                dns
f06975a5d11f   docker_open5gs_nrf     "/bin/sh -c '/mnt/nr…"   3 hours ago   Up 46 minutes   7777/tcp                                                                                nrf
1426deefbfe1   docker_open5gs_mongo   "/bin/sh -c /mnt/mon…"   3 hours ago   Up 46 minutes   27017/tcp, 27017/udp                                                                                mongo
e70d5c6f9c08   docker_rtpengine       "/bin/sh -c /mnt/rtp…"   3 hours ago   Up 46 minutes   2223/udp, 49000-50000/udp                                                                           rtpengine
1b2b7962442c   docker_mysql           "/bin/sh -c /mysql_i…"   3 hours ago   Up 46 minutes   3306/tcp                                                                                mysql

I dont see PCSCF running in above list of cotnainer, thats the reason you dont see SIP messages
I would recommend to do the following before you plan to restart the docker setup

Ensure the containers are not already running, if so bring them down as follows

docker-compose down

Wait for it and then execute docker-compose up

I dont see PCSCF running in above list of cotnainer, thats the reason you dont see SIP messages
I would recommend to do the following before you plan to restart the docker setup

Ensure the containers are not already running, if so bring them down as follows

docker-compose down

Wait for it and then execute docker-compose up

thank herlesupreeth ,
i follow your the above steps , now VoLTE is workd

thank herlesupreeth ,
i follow your the above steps , now VoLTE is workd


[Node.js SDK] Dialog prompt in bot.on('conversationUpdate') repeats itself in Web Chat

Bot Info

SDK Platform: Node.js
SDK Version: 3.14.0
Active Channels: Direct Line, Web Chat
Deployment Environment: Azure Bot Service, Azure App Service

Issue Description
I have a requirement to show greeting message and prompt for user when Web Chat appears first time. To implement this I am using code based on conversationUpdate activity as defined in code snippet below. The issue happens when user opens chat window first time: he sees greeting message once and then prompt with buttons to select an option, but when he selects any option, he sees prompt message second time again and only after second reply, code is executing correctly, which is NOT expected behaviour.
Code Example
'use strict';

const restify = require('restify');
const builder = require('botbuilder');

// Setup Restify Server
let server = restify.createServer();
server.listen(process.env.port || process.env.PORT || 3978, function () {
   console.log('%s listening to %s', server.name, server.url);
});

// Create chat connector for communicating with the Bot Framework Service
let connector = new builder.ChatConnector({
    appId: process.env.MicrosoftAppId,
    appPassword: process.env.MicrosoftAppPassword
});

// Listen for messages from users
server.post('/api/messages', connector.listen());

// Using in memory storage for test/dev purpose
let inMemoryStorage = new builder.MemoryBotStorage();

let bot = new builder.UniversalBot(connector, [
    function (session) {
        builder.Prompts.choice(session, "Please select your option?",
                                ["Option 1", "Option 2"], { listStyle: builder.ListStyle.button });
    },
    function(session, results) {
        if (results.response.index === 0) {
            session.send("You've selected option 1")
        } else {
            let msg = "You've selected option 2";
            session.endConversation(msg);
        }
    }
]).set('storage', inMemoryStorage);

bot.on('conversationUpdate', function (activity) {
    if (activity.membersAdded) {
        activity.membersAdded.forEach(function (identity) {
            if (identity.id === activity.address.bot.id) {
                var reply = new builder.Message()
                    .address(activity.address)
                    .text("Hi there!");
                bot.send(reply);
                bot.beginDialog(activity.address,'/');
            }
        });
    }
});

Reproduction Steps

Run the app with code above
Open Web Chat iframe
Test the dialog

Expected Behavior
Expected behaviour is when user sees prompt message from default dialog only once after greeting message.
Actual Results

Any ideas on that?

if (results.response.index === 0) {'...
there are 3 '=' signs, maybe this is the reason.

is this what you are expecting?
If yes, I replicated the same code you posted.

It works fine in Bot Emulator, but issue occurs in Web Chat.
С уважением,
Эмин Аскеров
2018-04-05 21:53 GMT+03:00 surya<EMAIL_ADDRESS>
[image: github]
https://user-images.githubusercontent.com/14793809/38385784-7481baf6-3930-11e8-9d1f-2f025776cac4.PNG
is this what you are expecting?
If yes, I replicated the same code you posted.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/BotBuilder/issues/4387#issuecomment-379040450,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ATAl4lsQ8hg8uWg6lpHD9c7nn9tXfQ29ks5tlmgtgaJpZM4TA9SU
.

I'm still investigating this issue, and have found that it's not just WebChat that has the error.  I tested this with a console app using DirectLine, and had the same problem occur with the repeat on the first set oif prompts, so this appears to be related to DirectLine itself.
I am continuing to troubleshoot and will advise as soon as I have a solution.

This is a known issue.  ConversationUpdate does not send enough information to construct the data bags, and as a result the dialog state is not persisted.  Please refer to the answer here for a workaround: https://github.com/Microsoft/BotBuilder/issues/4245

@easkerov, did @EricDahlvang's suggestion (#4245) help in resolving your issue?

@EricDahlvang @nodeomega it works as expected now with solution in #4245
Thank you so much!

@easkerov Excellent!  We can consider this issue closed, and if you run into any more issues, feel free to open a new request.


added task validation

added validation for process existence and parameter names

This is a nice addition. Thanks @nicolasbisurgi


Never show night icons

hey, great integration. but - I see only day icons, I can see that attributes for night are missing, shown only for day.
possible to add also night?

It relates to the fact that the reports from IMS don't have this granularity

Also - as you can read here the only night relevant icon is clear-night
I can try to add it but I think it's a hard work

that can be great! Thank you.
From what i saw - night rainy or night sunny also can be shown.


Promise.fromObject()

This is the same proposal as Promise.ownProperties(), but under a different name that feels natural and approachable (imo)
const {
  shape,
  color,
  mass,
} = await Promise.fromObject({
  shape: getShape(),
  color: getColor(),
  mass: getMass(),
});

Agreed! ownProperties is an incredibly wonky name.  It does solve a very niche concern (although, with OOP declining in popularity in JS, how many devs even know about the prototype chain?), but ...
JS features shouldn't be named after wonky concerns, they should be named to be easily understood by all programmers.

Which combinator semantics would that have - all, allSettled, race, or anySettled?

ownProperties doesn't really imply the combinator semantics either though, although this may be better discussed in another issue.


docs: Update cli command execution example

Changes:

Update cli command execution example

Types of changes
What types of changes does your code introduce?
Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] Documentation Update
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Other (please describe):

Testing
Requires testing

[ ] Yes
[x] No

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 25.49%. Comparing base (e3b138a) to head (d9fd53b).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #451      +/-   ##
===========================================
+ Coverage    25.45%   25.49%   +0.03%
===========================================
  Files          119      119
  Lines        18045    18045
===========================================
+ Hits          4594     4600       +6
+ Misses       12929    12926       -3
+ Partials       522      519       -3

Flag
Coverage Δ

unittests
25.49% <ø> (+0.03%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


"flutter attach --machine" provides a malformed VM Service URI

The wsUri printed when using flutter attach --machine appears to be malformed:
danny@Dannys-MacBook-Pro flutter_counter % flutter attach --machine -d iPhone --debug-url http://<IP_ADDRESS>:49606/h-O0daymeDM=/
[{"event":"daemon.connected","params":{"version":"0.6.1","pid":2769}}]
[{"event":"app.start","params":{"appId":"f0197a9d-8d92-40e6-839a-61d561321b8e","deviceId":"A1F0E6A3-DBEA-4CBE-BACE-3893023E5897","directory":null,"supportsRestart":true,"launchMode":"attach"}}]
[
	{
		"event": "app.debugPort",
		"params": {
			"appId": "f0197a9d-8d92-40e6-839a-61d561321b8e",
			"port": 49606,
	######## wsUri looks wrong here
			"wsUri": "ws://<IP_ADDRESS>:49606/h-O0daymeDM=/.,/ws",
			"baseUri": "file:///Users/danny/Library/Developer/CoreSimulator/Devices/A1F0E6A3-DBEA-4CBE-BACE-3893023E5897/data/Containers/Data/Application/B788D5FE-81AD-487E-9B95-8EA6357DFF65/tmp/flutter_counterFG3CJR/flutter_counter/"
		}
	}
]

The wsUri returned is ws://<IP_ADDRESS>:49606/h-O0daymeDM=/.,/ws but I would expect it to be ws://<IP_ADDRESS>:49606/h-O0daymeDM=/ws.

If you pass a ws://.../ws for --debug-uri you get the same behaviour. Though if you pass --no-dds you get slightly different results (correct results when passing a http root, but incorrect when passing the ws address):
// args
--debug-url  ws://<IP_ADDRESS>:51458/Xxj5fo0dHj0=/ws --no-dds
// wsUri
ws://<IP_ADDRESS>:51458/Xxj5fo0dHj0=/ws/ws

// args
--debug-url http://<IP_ADDRESS>:51458/Xxj5fo0dHj0= --no-dds
// wsUri
ws://<IP_ADDRESS>:51458/Xxj5fo0dHj0=/ws

@christopherfujino @bkonyi before I start trying to fix anything here, can we confirm what formats of URI should be supported here? I notice that a lot of the integration tests re only using port numbers (and --disable-auth-codes) which means they're not seeing any of this behaviour. I've started changing the tests to leave auth-codes enabled and just handle proper URIs instead of only port numbers for better coverage, but I want to be sure I'm making the right assumptions about what we need to pass for --debug-uri (I'm assuming that the output wsUri should always start ws:/ and end /ws).

@christopherfujino @bkonyi before I start trying to fix anything here, can we confirm what formats of URI should be supported here? I notice that a lot of the integration tests re only using port numbers (and --disable-auth-codes) which means they're not seeing any of this behaviour. I've started changing the tests to leave auth-codes enabled and just handle proper URIs instead of only port numbers for better coverage, but I want to be sure I'm making the right assumptions about what we need to pass for --debug-uri (I'm assuming that the output wsUri should always start ws:/ and end /ws).

Sorry, I can't be of much help here, I don't know how any of this works. Also, is this a recent regression? This seems like a pretty bad breakage.

This is not a recent regression.
It's happening because flutter_tools is trying to recover a DDS URI by parsing an error message returned in an exception (see https://github.com/flutter/flutter/blob/master/packages/flutter_tools/lib/src/base/dds.dart#L74)
The exception message adds a period after the URI (see https://github.com/dart-lang/sdk/blob/main/sdk/lib/vmservice/vmservice.dart#L274).  The message is also formatted in a JSON-like style with comma-delimited fields.
So the parser captures the ., suffix as part of the URI.

Ah, thanks! It looks like we should probably add a field to the exception (or a subclass of this exception) for the URI and then it won't need to be extracted from the message like this. I'll take a look, thanks!

@bkonyi I realised the code linked above is part of lib/vmservice/vmservice.dart and not inside DDS (and that the error is going over the JSON protocol) so it's not as simple as just changing the exception and adding a field.
Although, I'm curious why we need to extract the URL here. If there's already a DDS instance can't we use the original VM Service URL? It seems like we're doing that in DAP - we're handling the same exception, but just using the same URL:
https://github.com/dart-lang/sdk/blob/376886ed1da63f81196c72490830fafd954b87d5/pkg/dds/lib/src/dap/adapters/dart.dart#L618-L620
I'm not sure if the is a difference in requirements here, or whether maybe DAP isn't doing the correct thing?

If the VM service client is capable of handling redirects, using the VM service URI instead of the DDS URI works fine since the VM service will redirect requests from non-DDS clients to DDS.
However, if a web client like DevTools tries to make a websocket connection to the VM service directly when there's a DDS instance attached, the connection will fail since the dart:html WebSocket implementation doesn't follow redirects (and there's no way to tell it to follow them). I had originally intended for the DDS URI to be completely transparent to clients, having the VM service redirect requests to DDS, but this restriction made it impossible to rely on redirects which is why we need to output the DDS URI.

Yeah, we probably could do that. The exception is created here: https://github.com/dart-lang/sdk/blob/376886ed1da63f81196c72490830fafd954b87d5/pkg/dds/lib/src/dds_impl.dart#L214.
We don't do any processing of the exception in DDS right now, but it's something we could do.

Cool, lemme take a look. Thanks!

I have a fix at https://github.com/flutter/flutter/pull/119506. It makes two changes:

Use a new field on the exception that holds exactly the URI (this requires the existing DDS instance provided it so is not guaranteed since we don't know what version it is if we didn't spawn it)
If we have to fall back to parsing the exception text, we trim trailing fullstops