How to use personal access token for github?

As you've probably seen, github is enforcing an access token only policy where you cannot use the username/password combo with the url to access private repositories. Does capistrano have a method for it?

I've been searching everywhere for an approach that allows me to use the personal access token. Can't seem to find anything -- I'm receiving warnings that I cannot use username/password to deploy

The preferred method is to use the SSH access unless something strictly prevents it.
SSH has a concept of "Agent forwarding" which allows your SSH key (on your machine) to be made available to your servers during deploy time, so that the servers can "borrow" your access to clone private repositories (be that the main repo or the sub-repos you may have as modules, or gems, etc)
Is there some reason that SSH key access doesn't work for your set-up?

I actually did start on it yesterday, but didn't quite know how to fully set it up for capistrano....Does anyone have a mock deploy.rb/CapFile file with a tutorial video or article? I need to get this right, given that the system is being used in production for a large quantity of users

I'll share my capfile/deploy.rb next monday if need be.

If you're nervous about breaking production, you can follow this guide from GitHub https://docs.github.com/en/github/authenticating-to-github/connecting-to-github-with-ssh
Then you can perform these two (point five) checks:

Locally, git ls-remote <ssh url to your repo>
Locally run ssh-add -l and check that your key agent -lists at least one key
Run (all in one line) something like ssh -A<EMAIL_ADDRESS>git ls-remote <ssh url to your repo>

(this runs the same command as you, via the deploy user from your server.) This all gets pretty close to the fundamentals of what's going on when Capistrano runs a deploy this way.
Beware two things:

use of an agent, or not (ssh-add) will depend on your system, explore google. Also AgentForwarding is not enabled by default (security reasons) for SSH, hence the -A in ssh -A ..., in SSHKit it is enabled by default.
changing from an HTTP to an SSH remote URL will confuse likely Capistrano, you may need to remove the repository cache directory from the server. I felt like we addressed the root of this problem some years ago, but one can never be sure, occasionally issues still surface about it.


Need keyboard navigation order to match visual order of menu items

Bug, feature request, or proposal:
I need keyboard navigation order of dynamic menu items to match the visual order in which the items appear.
What is the expected behavior?
In the stackblitz example below, I expect the down arrow key to navigate in the order A-B-C-D-E.
What is the current behavior?
The navigation order is A-B-D-E-C.
What are the steps to reproduce?
https://angular-material2-issue-gxemkt.stackblitz.io
What is the use-case or motivation for changing an existing behavior?
We're trying to use mat-menu for a dynamically created menu and the last menu item, "Sign Out", is being highlighted first -- something we definitely don't want to appear as a default menu action. We anticipate that this won't be the only issue we'll run into if we keep going with mat-menu, as the stackblitz demo above shows. There appears to be no way we can take control of the navigation order to fix this problem.
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
Angular 6.0.2, Material 6.0.2, Windows 7, TypeScript 2.7.2, Chrome, Firefox, and IE.
Is there anything else we should know?

*ngFor also influences the keyboard order https://stackblitz.com/edit/angular-7kfy5f?file=app/menu-overview-example.html

Is there something that can be done about the PR? Can I do something to make it happen faster?
We are using a very ugly workaround in order to make this work, so it would be cool to have it work out of the box.

It's blocked because there's a project inside Google that the fix breaks, and it's somewhat tricky to change their app to not break with the fix applied.

Ok, thanks for the information! Is there an estimated time of arrival?

Since I haven't seen anyone mention a workaround, the workaround I've been using is to put *ngIf="true" on every menu item that isn't otherwise conditional.

@DanielHabenicht most of the team is temporarily redirected to work on ivy, so it might not be until ~Q3 this year

@calebegg Thanks for the way easier workaround! It also works for *ngFor
@jelbourn Thanks for the information, that lets us plan ahead.


chore: Merge integration changes into dev branch

Description

Let's move to integrate new features into the dev branch.
Additional information

N/A

Closed as we will be working off of the frontend_dev branch.


sap.ui.Device.resize: height and width are wrong

Dear UI5-Team,
in Chrome debugger, any phone, the values for height and width in sap.ui.Device.resize are wrong.
Inside a function that is attached to Device.resize.attachHandler(...) the values are right.
Can the resize values only be checked that way?
OpenUI5 version: 1.60.5

window.screen.width + height is what I was looking for


Fix VRSC -> VRODS slicing

The goodbeams_mask wasn't being sliced for VaryingResolutionOneDSpectrum.

Coverage remained the same at 77.891% when pulling fdc2ba2d1810f95d6b56cb054339f8903ba28738 on e-koch:vrsc_beams_slicing into 86894dc0e77f68b73b48d29927a476f839cd6f9b on radio-astro-tools:master.


Addresses fixed by board

The addresses are fixed by the ADDR8/EN pin on PCB, if daisy chaining them, ADDR1-ADDR8 must correspond the panels DIP switch position (which should be different than always 00000001). So the addr shift register needs to be filled and toggled once.
I already built a shift-register only pcb, but missed the current limit on VS and got the address problem too, as my last register is synced with the others. Will fix that in next revision.

I don't quite understand your issue here. Let's just explain my thoughts on this "address-problem" at flippie:
The address lines (as well as the FP2800A inputs) are 24V pulled-up logic lines. So to drive them in a very simple way would need just as NMOS to short the line to GND. By doing so, you have an inverting driver. That's why the modules connected via flippie, must have their address DIP-switches on the module inverted.
I've designed the ADDR8/EN line directly as an discrete output of the MCU to emulate a real kill-switch-like EN line. All other lines ADDR1-ADDR7 are driven by the shift-register.
So, there's no "address-problem" at flippie. It is working with multiple modules (tested).

Nah, missed that in the Readme... Nevermind. 128 Displays should be enough...


Feature Request: Export Particle Emitter

I really like the particle editor. It would be really valuable to be able to create particle effects using nunustudio, and then export them for use in my other threejs + SPE project.
How hard would it be to export the particle system settings as JSON?

Hi
I can add a dropdown option in the project explorer. But you would still need to manually add the import code to your external projects.
The code can be found at https://github.com/tentone/nunuStudio/blob/master/source/core/loaders/ObjectLoader.js
Thanks a lot for the suggestion.
Cheers


Split relative locktime error up

The relative module has a single general error type, we are moving away from this style to specific error types.
Split the relative::Error up into three error structs.
I forget the policy on public inner fields.

I went to move the relative::Height and Time types to units and discovered the general error type.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

-14 of 24 (41.67%)  changed or added relevant lines in 2 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.04%) to 84.189%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

bitcoin/src/blockdata/transaction.rs
0
4
0.0%

bitcoin/src/blockdata/locktime/relative.rs
10
20
50.0%

Files with Coverage Reduction
New Missed Lines
%

bitcoin/src/blockdata/locktime/relative.rs
2
72.27%

Totals

Change from base Build<PHONE_NUMBER>:
0.04%

Covered Lines:
19334

Relevant Lines:
22965

💛  - Coveralls

I was trying to pull out absolute before since you said it's hard, I assumed you're not going to do that soon. But got tangled in other things lately. Anyway, this PR doesn't conflict (yet?).

I hadn't tried to move any code out of the locktime modules, I said (at least I meant) that pow was hard. Moving Height and Time from both absolute and relative shouldn't be a problem once the errors are improved.

Only change in force push is improvement to the error message printed for two of the new errors.

Can this go in? We need this if we want to move the locktime types to units which is required to move ParseIntError yada yada yada

Changes in force push:

Made the error fields public and used name fields instead of tuple struct
Did not include non_exhaustive - I believe these errors, and the functions in relative module, are stable and won't need changing.
rebased to pick up #2488

Includes #2499 to get past CI, it would be really useful if we had a system that allowed ack'ing PRs that included some other PR so we didn't have to do the 2 day  ack,  re-base, re-ack, merge cycle.

Please note the new error types in this PR are not hider errors, are returned from functions that are stable, and therefore have public fields and do not use non_exhaustive.

FTR, if we want to stabilize sooner maybe we should just hide all errors entirely and we can go back and uncover (parts of) them later.

FTR, if we want to stabilize sooner maybe we should just hide all errors entirely and we can go back and uncover (parts of) them later.

I made both incompatible error types non_exhaustive

This should be Height to statically represent that the lock was height.

I"m not sure about this. If we do this (and similar change for Time) then then the errors become the same shape, opening up the debate about using same errors in different functions. Secondly the input is a LockTime so I think the error should be a LockTime so debuggers are looking at exactly the same thing. I don't feel strongly about either argument though.
Your comments did uncover that I was using the error incorrectly (for how I had meant it to be used) though which is interesting.

I made both incompatible error types non_exhaustive

That's not always sufficient.

If we do this (and similar change for Time) then then the errors become the same shape

Firstly, not really, they are mirrored (and we would need a third field to distinguish them). Secondly I think that being imprecise just to avoid the discussion is just lying to ourselves. If the discussion is not worth slowing down stabilization just make them opaque.

Secondly the input is a LockTime so I think the error should be a LockTime so debuggers are looking at exactly the same thing.

The concrete types imply the outer one, so IMO it still is the same thing.

Your comments did uncover that I was using the errors incorrectly

Cool!

Both unresolved comments are yours @Kixunil, I believe they are both resolved.

Rebase only, no other changes.

Note that a hidden discussion links to issue #2553 about renaming local variables inside some method.


(Idea/Suggestion) Config option to allow hoarder bug eggs to function outside.

If inside mobs are capable of spawning outside (idk if there are limitations), it would be interesting to allow hoarder bugs to spawn outside with a config. There is not much use other than to mess around with friends.

Because most AI breaks when outside, i do a check on if LethalEscape mod is present ti determine if i it can spawn outside.
So by installing Lethal Escape you will be able to enable eggs hatching outside

Awesome!


Remove no longer needed dependencies

I use dependency-check to find dependencies that are no longer needed.
I open an issue instead of an PR to pass on the knowledge of that useful too. I normally run those for commands:
dependency-check ./package.json --missing --no-dev
dependency-check ./package.json --unused --no-dev
dependency-check ./package.json --missing ./test/*
dependency-check ./package.json --unused ./test/*

I think this should be added to the lint step in https://github.com/ipfs/aegir instead of piecemeal to individual repos as it's very useful - do you fancy putting a PR together there?

Sadly you're so right. I'll do that this week.

As promised: https://github.com/ipfs/aegir/pull/309


Fix broken ingress template for redmine chart

Fix broken template when tls: true is set. This is the error you currently get:
Error: render error in "redmine/templates/ingress.yaml": template: redmine/templates/ingress.yaml:33:17: executing "redmine/templates/ingress.yaml" at <.Values.ingress.tls>: can't evaluate field ingress in type interface {}
Also NOTES.txt was not printing the URL, it was making reference to an older variable.

/ok-to-test
/lgtm


[Only-Test] master 2 weeks ago version : b3b261e

Proposed changes
Issue Number: close #xxx
Problem summary
Describe your changes.
Checklist(Required)

[ ] Does it affect the original behavior
[ ] Has unit tests been added
[ ] Has document been added or modified
[ ] Does it need to update dependencies
[ ] Is this PR support rollback (If NO, please explain WHY)

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 33.95 seconds
stream load tsv:          427 seconds loaded<PHONE_NUMBER>9 Bytes, about 167 MB/s
stream load json:         21 seconds loaded<PHONE_NUMBER> Bytes, about 107 MB/s
stream load orc:          59 seconds loaded<PHONE_NUMBER> Bytes, about 17 MB/s
stream load parquet:          31 seconds loaded 861443392 Bytes, about 26 MB/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230508232654_clickbench_pr_140510.html


chore: upgrade packages

A large upgrade to try and fix the issue with rollup

Hey @fargito, I fixed the issue in https://github.com/swarmion/swarmion/pull/510/commits/b64cf069bd75a9fec3b9cf0d2bdb558a1c377c95 by pinning the dependency. There was an issue because rollup was listed as a peerDependency of rollup-plugin-visualizer but we did not fix it in frontend/app/package.json.
WDYT?


HelloWorld failing deployment

When deploying the HelloWorld sample code, I get this error:
Step #2 - "build": Opting out: GOOGLE_ENTRYPOINT not set, no valid entrypoint in app.yaml and Procfile not found
Step #2 - "build": ======== Output<EMAIL_ADDRESS>========
Step #2 - "build": Opting in: always enabled
Step #2 - "build": ======== Results ========
Step #2 - "build": pass<EMAIL_ADDRESS>Step #2 - "build": fail<EMAIL_ADDRESS>Step #2 - "build": pass<EMAIL_ADDRESS>Step #2 - "build": Timer: Detector ran for 207.070549ms and ended at 2023-10-13T05:40:13Z
Step #2 - "build": ERROR: No buildpack groups passed detection.
Step #2 - "build": ERROR: Please check that you are running against the correct path.
Step #2 - "build": ERROR: failed to detect: no buildpacks participating
Finished Step #2 - "build"
ERROR
ERROR: build step 2 "us.gcr.io/gae-runtimes/buildpacks/google-gae-22/dotnet/builder:dotnet_20231009_RC00" failed: step exited with non-zero status: 20

When setting the entry point in app.yaml, I get 502 Bad Gateway:
runtime: aspnetcore
env: flex
entrypoint: "dotnet test.dll"

runtime_config:
  operating_system: ubuntu22

# This sample incurs costs to run on the App Engine flexible environment.
# The settings below are to reduce costs during testing and are not appropriate
# for production use. For more information, see:
# https://cloud.google.com/appengine/docs/flexible/dotnet/configuring-your-app-with-app-yaml
manual_scaling:
  instances: 1
resources:
  cpu: 1
  memory_gb: 0.5
  disk_size_gb: 10

env_variables:
  # The __ in My__Greeting will be translated to a : by ASP.NET.
  My__Greeting: Hello AppEngine!

Thanks for the report. Which directory are you running the deployment command from? It has to be the appengine/flexible/HelloWorld/HelloWorld.Sample/ directory.

Got it, I was doing this (which caused the issue):
# Build the project
dotnet publish -c Release

# Navigate to the publish folder
cd bin/Release/net6.0/publish/

# Deploy to App Engine
gcloud app deploy

If I just called gcloud app deploy in the directory you mention, it does work.  Thanks.

Happy to help. For .NET 6 and onwards, under the hood we take care of the publish step.


treewide: fix lints Arg to lib.optional is a list *Flags not a list

https://www.github.com/nix-community/nixpkgs-lint
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Why are we not rebuild 0 here?

This is missing some explanation - shouldn't these which add a list with a single element not keep lib.optional, but remove the surrounding list?

Why are we not rebuild 0 here?

I'll check later, at the nixos helsinki meet up rn.

Why are we not rebuild 0 here?

probably because some nix variables where turned into bash strings and the type of those changed?

This is missing some explanation - shouldn't these which add a list with a single element not keep lib.optional, but remove the surrounding list?

IMO doesn't really matter in the end. Removing the [] could cause a bigger diff because they are sometimes not on one line.

PS: Before anyone gets the idea to make a treewide PR to convert lib.optional to lib.optionals [ ]. Just don't there is no benefit and just noise which will crawl into many open PRs.

The rebuilds are due to fixing Arg to lib.optional is a list in the dependency attributes

The dependency choosing in mkDerivation does not work with nested lists https://github.com/NixOS/nixpkgs/blob/5402c1eef90778655da26212d78fe8d4611319df/pkgs/stdenv/generic/make-derivation.nix#L304

Fun. Maybe split out all the rebuild-0 bits and then just send the rest to staging?


Need to verify designatedWallet-requesterInd

All requests pass designatedWallet and requesterInd.
When the node receives a request, it should verify that designatedWallet is the address of m/0/${requesterInd} and ignore the request if this is not the case.

Example:
https://github.com/api3dao/airnode/blob/696ebad7207b02ffba9b85f2bb57430425c7cd32/packages/protocol/test/UserFlow.js#L240-L244

This will need to be done after templates have been applied, right? Short requests don't have requesterInd and designatedWallet until that point

Yes


fix image display in firefox browser

issue

/assing @sftim

/assign @sftim

I'd like an /lgtm from someone else before this merges.

@Arhell , thanks for this pull request. I am looking at the changes.
/hold

/unhold

/lgtm


Compare HTTP GET request with InfluxDB Data to make an alert

I want to make an HTTP Request (that returns JSON) and compare it to the stream/batch data (from influx) to make an alert.
Ex:
var current = batch
    |query('''
        SELECT last(value)
        FROM "super"."default".alive_status
        WHERE "type" = 'up'
    ''')
        .cron('10,25,40,55 * * * *')
        .period(1h)

var api = http
    |login('http://api.com')
        .data(' user:"user","pass:"pass" ')
    |get('http://api.com/getMe')

current
    |join(api)
        .as('current', 'api')
    |alert()
        .info(lambda: "current.last" < "api.average")
        .pagerDuty()

This is a possible example of what should be possible. Many people may want to compare data that's not persisted on influx, me included.

@siryur Have you looked at using a UDF? This will allow you to perform the HTTP request with full control over the transport, authentication, etc. You can also compare the data in which ever way suits you.
I think a general solution has value but it has some initial challenges to overcome in order to be generally useful. Some questions I have:

How does the JSON data get converted into fields tags etc? Do we force a specific JSON structure or just do a best effort?
How do you deal with the high latency adding a HTTP request would incur? For low throughput streams its probably not a problem but quickly I think you will find that you need to batch request to the API, which then means you need a way to describe batch parameters.
How do you parameterize the request so that you can retrieve relevant data? Aka make the request parameters dependent on the current data.

The answers to these question vary significantly by use case. For that reason I suggest using a UDF currently as it allows each implementation to handle their performance/data needs separately.

I understand UDF, but since GET's & POST's are "generic" requests for everybody, it will be nice to have that easy implementation on a tick-script.
About the questions you have (in my opinion):

How does the JSON data get converted into fields tags etc? Do we force a specific JSON structure or just do a best effort?

Forcing a specific JSON seems to me like a bit harsh to the user. Best effort is your thing ;)
(On Kapacitor develop side) When trying to convert data from string to "others", that will be a problem (but i'm not a Go expert, sooooo .....).

How do you deal with the high latency adding a HTTP request would incur? For low throughput streams its probably not a problem but quickly I think you will find that you need to batch request to the API, which then means you need a way to describe batch parameters.

It should be possible to set a timeout. When you don't receive an answer to the request you made you could use the last "cached" request to compare data. It would be great to cache that data untill next request. If you don't have any cached data ... (no great thought's about it)....

How do you parameterize the request so that you can retrieve relevant data? Aka make the request parameters dependent on the current data.

It would be great to parameterize the request with the current data ...

If you need help, just tell me ;)

@siryur  Can you provide a concrete example of the JSON returned from your endpoint and how that would be converted into Kapacitor points?

It would be great to parameterize the request with the current data ...

Could you provide an example of how this would work in TICKscript?

of course :)
var current = batch
    |query('''
        SELECT last(time),last(value), last(position)
        FROM "super"."default".alive_status
        WHERE "type" = 'up'
    ''')
        .cron('10,25,40,55 * * * *')
        .period(1h)

With this i could know:

last(time) = report time
last(value) = the number of users seen
last(position) = the last location

I always have users seen, except in 2 occasions: when the machine is broken, or the location is closed.
I can only know if the location is closed or not by making an API HTTP request.
Since I need to login to make the request......
POST: http://api.com/login
DATA: {"user": "myuser","password":"mypass"}
EXPECTED: {"message-type":200,"message":"ok"}
(Ex: If my last location was = "china")
GET: http://api.com/china
EXPECTED: {"name":"china","hours":[{"day":"Monday","open":28800,"close":72000},{"day":"Monday","open":28800,"close":75600},{"day":"Monday","open":36000,"close":79200}]}
After this, i want to make an alert if:

last(value) == 0 AND openHour > last(time) > closeHour (of that day)

I hope this is a good enough example :)

In your example what value does openHour have? Seems like it could be 28800, 28800 or 36000?

openHour = day of the week * 86400 + open
closeHour = day of the week * 86400 + close
time on my influx is the result of that equation already ...
Moday = 0
Tuesday = 1
Wednesday=2
Also it was suppose to be like:
{"day":"Monday","open":28800,"close":72000},{"day":"Tuesday","open":28800,"close":75600},{"day":"Wednesday","open":36000,"close":79200}

Thanks for the details.
Where  does this logic: openHour = day of the week * 86400 + open get defined?
Could you provide and example of how you think this might look using TICKscript?

time on my influx is the result of that equation already ...

This confused me, if you already have the result why are you making a GET request?
I am not sure I quite follow what you are trying to do yet.

openHour & closeHour & last(time) have the same logic...
the meaning of that logic is: they have the amount of seconds of the week, i'm counting that the week starts on Monday.
Examples:
00:01:00am Monday = 60
11:00:00am Monday = 39600
00:01:00am Wednesday = 172860
00:01:00am Saturday = 345660
01:01:00pm Saturday = 392460

This confused me, if you already have the result why are you making a GET request?

last(time) <--> this is the time of the last insertion on influx...
 You have your device writing data to a service and that service writes data every min to influx ... The question you want to know is if your machine is reporting or if is shutdown, because if it's shutdown it will report no data, but the service will report with no values... But you have a policy, Your machine has a downtime from 01:00am to 07:00am every-day (because everyone is sleeping), but your service is not... So it will report anyway...
So, you need to know if the report of no data is between that date where everyone is sleeping (and your machine is suposed to be shutdown) or your machine is supouse to be up and you get no data. (Imagine that you have always people inside your house using the network)
PS: In my case, this is a lot more complex than this... but i think this is a good example.

@siryur I think I understand what you are trying to do. And I still do not see how a generic solution would work here, there is lots of custom logic.
If I were you I would do one of the following:

Write all needed data to InfluxDB directly so that you do not have to look up extra data on demand. You don't have to write it to the same point, but rather could write it to a different measurement and join on the data. This way you avoid having to do any external GET requests.
Write a UDF, that can do all this custom logic on demand.

I would prefer the first option as it decouples your systems better as there is no hard dependency between Kapacitor and the HTTP endpoint. Seems like it would be simple to write a simple script to pull the data you need from the HTTP endpoint and write it to InfluxDB every hour, or what ever frequency you need. And if you don't want to store this data on disk then write it directly to Kapacitor instead.

I know there is a lot of custom logic...
For me the best solution is the second for 2 things: the amount of data i transfer to influx is huge so writing more things unnecessarily is not the right thing to do. Also, these values could be the same for years, writing these every time i need to write something is bad and duplicating info just seems pointless...
I'm going for the 2nd :)
But let's try a list for things to implement ?

Be able to login to the API (Ex: .login('http://testapi.test/auth','user','pass'))
Create custom URL depending on influx data (Ex: http://testapi.test/{"location"})
Do GET's and POST's (or others) to get the data needed
(help me complete this...)

And maybe you don't need to "understand" the data received. Let the user do it...
Since >90% of the API's return XML or JSON data, you can apply XPath or JSONPath to the result. With this, the user can do the path to make the if's and to say what to return ;)
Then you can go to each object attributes 1 by 1 and allow the user to use it ;)

Based on this discussion, a generic HTTP node represents a significant amount of work. And there are at least two workarounds that are not too difficult. As such I am going to mark this issue as a feature request + help wanted. If someone from the community wants to take a stab at this and submit a PR we can discuss it further then.
@siryur  Thanks for the good discussion.


Fix issue 380

Fix for https://github.com/aquasecurity/trivy-db/issues/380

Hi, do we have an ETA for when this will be ready? We have a pipeline dependent on this currently.
Thanks

@mpoindexter Do you have time? If not, we'll take it over.

Updated the PR to set the fix version to blank as requested

Thanks for your contribution!


[bug] fix chunk.choices[0].delta NoneType

Description
chunk.choices[0].delta could be NonType
./graphrag/query/llm/oai/chat_openai.py", line 185, in _agenerate
delta = chunk.choices[0].delta.content or ""  # type: ignore
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'content'
Related Issues
None
Proposed Changes
Check if chunk.choices[0].delta is None
if chunk.choices[0].delta is None :
_content = ""
else:
_content = chunk.choices[0].delta.content
delta = _content  or ""  # type: ignore## Checklist

[x] I have tested these changes locally.
[x] I have reviewed the code changes.
[ ] I have updated the documentation (if necessary).
[ ] I have added appropriate unit tests (if applicable).

Additional Notes

Hi @s106916
Took the liberty of editing your PR in favor of a more pythonic approach.
Thanks for your contribution!

@s106916
Once you accept the contributor license I can proceed to merge

@s106916 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
@microsoft-github-policy-service agree [company="{your company}"]

Options:

(default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.

@microsoft-github-policy-service agree

(when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.

@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement
Contribution License Agreement
This Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”), and conveys certain license rights to Microsoft Corporation and its affiliates (“Microsoft”) for Your contributions to Microsoft open source projects. This Agreement is effective as of the latest signature date below.

Definitions.
“Code” means the computer software code, whether in human-readable or machine-executable form,
that is delivered by You to Microsoft under this Agreement.
“Project” means any of the projects owned or managed by Microsoft and offered under a license
approved by the Open Source Initiative (www.opensource.org).
“Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any
Project, including but not limited to communication on electronic mailing lists, source code control
systems, and issue tracking systems that are managed by, or on behalf of, the Project for the purpose of
discussing and improving that Project, but excluding communication that is conspicuously marked or
otherwise designated in writing by You as “Not a Submission.”
“Submission” means the Code and any other copyrightable material Submitted by You, including any
associated comments and documentation.
Your Submission. You must agree to the terms of this Agreement before making a Submission to any
Project. This Agreement covers any and all Submissions that You, now or in the future (except as
described in Section 4 below), Submit to any Project.
Originality of Work. You represent that each of Your Submissions is entirely Your original work.
Should You wish to Submit materials that are not Your original work, You may Submit them separately
to the Project if You (a) retain all copyright and license information that was in the materials as You
received them, (b) in the description accompanying Your Submission, include the phrase “Submission
containing materials of a third party:” followed by the names of the third party and any licenses or other
restrictions of which You are aware, and (c) follow any other instructions in the Project’s written
guidelines concerning Submissions.
Your Employer. References to “employer” in this Agreement include Your employer or anyone else
for whom You are acting in making Your Submission, e.g. as a contractor, vendor, or agent. If Your
Submission is made in the course of Your work for an employer or Your employer has intellectual
property rights in Your Submission by contract or applicable law, You must secure permission from Your
employer to make the Submission before signing this Agreement. In that case, the term “You” in this
Agreement will refer to You and the employer collectively. If You change employers in the future and
desire to Submit additional Submissions for the new employer, then You agree to sign a new Agreement
and secure permission from the new employer before Submitting those Submissions.
Licenses.

Copyright License. You grant Microsoft, and those who receive the Submission directly or
indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license in the
Submission to reproduce, prepare derivative works of, publicly display, publicly perform, and distribute
the Submission and such derivative works, and to sublicense any or all of the foregoing rights to third
parties.
Patent License. You grant Microsoft, and those who receive the Submission directly or
indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license under
Your patent claims that are necessarily infringed by the Submission or the combination of the
Submission with the Project to which it was Submitted to make, have made, use, offer to sell, sell and
import or otherwise dispose of the Submission alone or with the Project.
Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement.
No additional licenses or rights whatsoever (including, without limitation, any implied licenses) are
granted by implication, exhaustion, estoppel or otherwise.

Representations and Warranties. You represent that You are legally entitled to grant the above
licenses. You represent that each of Your Submissions is entirely Your original work (except as You may
have disclosed under Section 3). You represent that You have secured permission from Your employer to
make the Submission in cases where Your Submission is made in the course of Your work for Your
employer or Your employer has intellectual property rights in Your Submission by contract or applicable
law. If You are signing this Agreement on behalf of Your employer, You represent and warrant that You
have the necessary authority to bind the listed employer to the obligations contained in this Agreement.
You are not expected to provide support for Your Submission, unless You choose to do so. UNLESS
REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE WARRANTIES
EXPRESSLY STATED IN SECTIONS 3, 4, AND 6, THE SUBMISSION PROVIDED UNDER THIS AGREEMENT IS
PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO, ANY WARRANTY OF
NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE.
Notice to Microsoft. You agree to notify Microsoft in writing of any facts or circumstances of which
You later become aware that would make Your representations in this Agreement inaccurate in any
respect.
Information about Submissions. You agree that contributions to Projects and information about
contributions may be maintained indefinitely and disclosed publicly, including Your name and other
information that You submit with Your Submission.
Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and
the parties consent to exclusive jurisdiction and venue in the federal courts sitting in King County,
Washington, unless no federal subject matter jurisdiction exists, in which case the parties consent to
exclusive jurisdiction and venue in the Superior Court of King County, Washington. The parties waive all
defenses of lack of personal jurisdiction and forum non-conveniens.
Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and
supersedes any and all prior agreements, understandings or communications, written or oral, between
the parties relating to the subject matter hereof. This Agreement may be assigned by Microsoft.

@microsoft-github-policy-service agree


bert

Description
(Brief description on what this PR is about)
Checklist
Essentials

[ ] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
[ ] Changes are complete (i.e. I finished coding on this PR)
[ ] All changes have test coverage
[ ] Code is well-documented

Changes

[ ] Feature1, tests, (and when applicable, API doc)
[ ] Feature2, tests, (and when applicable, API doc)

Comments

If this change is a backward incompatible change, why must this change be made.
Interesting edge cases to note here

cc @dmlc/gluon-nlp-team

on p3.16x
bpslaunch python run_pretraining.py --data \"~/data/data/*.train\" --raw  --max_seq_length 512 --num_steps 1000000 --comm_backend byteps --num_accumulated 4 --num_dataset_workers 2 --num_batch_workers 2 --seed 123

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@32e87d4). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master       #2   +/-   ##
=========================================
  Coverage          ?   83.87%
=========================================
  Files             ?       42
  Lines             ?     6314
  Branches          ?        0
=========================================
  Hits              ?     5296
  Misses            ?     1018
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32e87d4...0d316f6. Read the comment docs.


fix: improve handling of json objects in http provider

Related to #1265
Nested objects are supported and should be passed to the dump function.
providers:
  - id: 'https://example.com/generateTranslation'
    config:
      body:
        // highlight-start
        messages: '{{messages | dump}}'
        // highlight-end
        model: '{{model}}'
        translate: '{{language}}'

tests:
  - vars:
      // highlight-start
      messages:
        - role: 'user'
          content: 'foobar'
        - role: 'assistant'
          content: 'baz'
      // highlight-end
      model: 'gpt-4'
      language: 'French'

Note that any valid JSON string within body will be converted to a JSON object.

Flagged this as a breaking change in the merge because it converts JSON strings into JSON objects


[BUG]: Browser is autofocusing and IDE stuck

Describe the bug
Working with WebStorm and NextJS. After editing code and save, the browser refresh and focus it. I can't continue editing the code and I need to click back on the editor.
Even working like that, after few refresh it got stuck completely and the IDE is not responding.
To Reproduce
Create a NextJS project, open it with WebStorm, run the dev server and open in GBrowser. Try to edit any file that modify the webpage
Expected behavior
To not autofocus when refreshing the browser after saving a file
Screenshots
N/A
Desktop (please complete the following information):

OS: MacOS Sonoma
Browser: GBrowser
Version: 2024.1.17

Jetrbrains IDE (please complete the following information):

IDE: WebStorm
Version: 2024.1.5

Azure Devops organization details:
N/A
Additional context
N/A

I'm also experiencing the exact same thing in RustRover 2024.1.4, com.gafner.giv (2024.1.17). Opening the GBrowser Tool Window steals focus away from my editor windows and I can't really do anything.
If I close the GBrowser Tool Window, I get back control and can edit files again.

Hi @zotil an @DavidAntliff
Will debug this on the weekend and will keep you updated.

Same issue.
Actually running on the following, however, noticed the issue on previous stable versions as well:
RustRover 2024.2 EAP
Build #RR-242.21829.114, built on August 27, 2024
Runtime version: 21.0.3+13-b509.11 amd64 (JCEF 122.1.9)
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o.
Toolkit: sun.awt.X11.XToolkit
Linux 6.10.3-amd64
Current Desktop: GNOME


Issue 215 integrate flanksource yaml

Looks good, can we also add some docs into the Administrator Guide ?


Create avika-surana.json

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[ ] My change requires changes to the documentation.
[ ] I have updated the documentation accordingly.
[x] All new and existing tests passed.
[x] This PR does not contain plagiarized content.
[x] The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

make the required changes

@harshsingh32 whilst I am sure this is not your intention, your comment comes across as quite aggressive to the author. Also, I am not sure what value it adds. Please consider this for future comments when reviewing PRs.

We look forward to seeing your Profile on LinkFree, but as there is no recent activity from you to make the changes suggested I am going to close this pull request.
We hope you will raise a new pull request to create your Profile and when you do, you might want to take a look at the following Docs which will help with the suggested changes the maintainers have proposed:
Quickstart: https://linkfree.io/docs/quickstart
Editing your Profile: https://linkfree.io/docs/how-to-guides/editing


[BUG] Re4 remake crashes when I disable vsync ingame.

Initially worked fine (first launch), then started crashing at launch. I removed local_config.ini and it started to crash when disabling vsync in the main menu (before loading save). Disabled vsync in local_config.ini (AppVsync=0) crashes on launch as well.
Used the latest version from here https://github.com/praydog/REFramework-nightly/releases/ (re4)
re2_framework_log.txt

Also it crashes or freezes entire pc on exiting save menu even with vsync on.
re2_framework_log.txt


when including from react-web project, es6 syntax is not supported

Need to precompile before publishing as described in http://bit.ly/2tRViJ9

hmm as far as I understand this is for using on web browsers right? I've tested this before but it didn't seem to work, browsers restrict cross sites requests (CORS).

Didn't think of that. Thanks


Create Unit test for Optional contact info

Optional contact info
a) Name text field
b) Phone number field (Are there any requirements? accept only numbers, min and max characters - TBC )
c) Continue button

Thank you for creating this issue.
We are reviewing our approach to testing + will update the guidance around testing once that is completed.


ctop project is not maintained and is based on the image with 100+ vulnerabilities

I don't deny that there may be 100+ vulns in the image (I have not checked), but the project says it is actively maintained. From the README: Maintained by a third party
I cannot vouch for this third party, but they have a GitHub profile here:
https://github.com/azlux/

I don't deny that there may be 100+ vulns in the image (I have not checked), but the project says it is actively maintained.

This conversation was the motivation for this PR. git log does not look like actively maintained. Several opened PR waiting for comments or approvals.


Removes deprecated create stuff

Thank you for helping out! ✨
Before submitting a pull request, please make sure the you checked the following:

[x] Forked the repository and created your branch from master
[x] Make sure the tests pass! npm it in the repository root
[x] If you've fixed a bug or added code more tests are appreciated
[x] If you're adding a new command, removing an old command, or changing how a command works, please update the relevant documentation for the command (under the doc/ folder)
[ ] Summarize your changes in the changelog
[x] If you haven't already please complete the CLA

Learn more about contributing: https://arc.codes/intro/community

Payload down ~10KB. Minor, but every little bit helps!


Canal - Network Policy only works when both application are on same node

I am using a Kubernetes NetworkPolicy to allow my public nginx-ingress-controller to egress to all pods in all namespaces that have the labels ingress="true" and ingress-controller="public". But strangely it only works when the applications are on the same node as the nginx-ingress-controller
This issue seems related to #2898 or #2169
kind: NetworkPolicy
apiVersion: networking.k8s.io/v1
metadata:
  name: allow-all-traffic-to-public-web-apps
  namespace: public
spec:
  podSelector:
    matchLabels:
      app: "nginx-ingress"
      component: "controller"
      release: "public-nginx-ingress"
  policyTypes:
  - Egress
  egress:
  - to:
    - namespaceSelector: {}
      podSelector:
        matchLabels:
          ingress-controller: "public"
          allow-ingress: "true"

Expected Behavior
When I apply the network policy, regardless of the Kubernetes worker node, the policy should work.
Current Behavior
When I apply the network policy, it only works if the application that that the nginx-ingress-controller is connecting to is on same Kubernetes worker node.
Your Environment
$ kubectl version
Client Version: version.Info{Major:"1", Minor:"14", GitVersion:"v1.14.7", GitCommit:"8fca2ec50a6133511b771a11559e24191b1aa2b4", GitTreeState:"clean", BuildDate:"2019-09-18T14:47:22Z", GoVersion:"go1.12.9", Compiler:"gc", Platform:"windows/amd64"}
Server Version: version.Info{Major:"1", Minor:"16", GitVersion:"v1.16.2", GitCommit:"c97fe5036ef3df2967d086711e6c0c405941e14b", GitTreeState:"clean", BuildDate:"2019-10-15T19:09:08Z", GoVersion:"go1.12.10", Compiler:"gc", Platform:"linux/amd64"}

canal:
kubectl describe ds canal -n kube-system
Name:           canal
Selector:       k8s-app=canal
Node-Selector:  beta.kubernetes.io/os=linux
Labels:         k8s-app=canal
Annotations:    deprecated.daemonset.template.generation: 1
                kubectl.kubernetes.io/last-applied-configuration:
                  {"apiVersion":"apps/v1","kind":"DaemonSet","metadata":{"annotations":{},"labels":{"k8s-app":"canal"},"name":"canal","namespace":"kube-syst...
Desired Number of Nodes Scheduled: 3
Current Number of Nodes Scheduled: 3
Number of Nodes Scheduled with Up-to-date Pods: 3
Number of Nodes Scheduled with Available Pods: 3
Number of Nodes Misscheduled: 0
Pods Status:  3 Running / 0 Waiting / 0 Succeeded / 0 Failed
Pod Template:
  Labels:           k8s-app=canal
  Annotations:      scheduler.alpha.kubernetes.io/critical-pod:
  Service Account:  canal
  Init Containers:
   install-cni:
    Image:      calico/cni:v3.10.0
    Port:       <none>
    Host Port:  <none>
    Command:
      /install-cni.sh
    Environment:
      CNI_CONF_NAME:         10-canal.conflist
      CNI_NETWORK_CONFIG:    <set to the key 'cni_network_config' of config map 'canal-config'>  Optional: false
      KUBERNETES_NODE_NAME:   (v1:spec.nodeName)
      SLEEP:                 false
    Mounts:
      /host/etc/cni/net.d from cni-net-dir (rw)
      /host/opt/cni/bin from cni-bin-dir (rw)
   flexvol-driver:
    Image:        calico/pod2daemon-flexvol:v3.10.0
    Port:         <none>
    Host Port:    <none>
    Environment:  <none>
    Mounts:
      /host/driver from flexvol-driver-host (rw)
  Containers:
   calico-node:
    Image:      calico/node:v3.10.0
    Port:       <none>
    Host Port:  <none>
    Requests:
      cpu:      250m
    Liveness:   exec [/bin/calico-node -felix-live] delay=10s timeout=1s period=10s #success=1 #failure=6
    Readiness:  http-get http://localhost:9099/readiness delay=0s timeout=1s period=10s #success=1 #failure=3
    Environment:
      DATASTORE_TYPE:                     kubernetes
      USE_POD_CIDR:                       true
      WAIT_FOR_DATASTORE:                 true
      NODENAME:                            (v1:spec.nodeName)
      CALICO_NETWORKING_BACKEND:          none
      CLUSTER_TYPE:                       k8s,canal
      FELIX_IPTABLESREFRESHINTERVAL:      60
      IP:
      CALICO_IPV4POOL_CIDR:               <IP_ADDRESS>/16
      CALICO_DISABLE_FILE_LOGGING:        true
      FELIX_DEFAULTENDPOINTTOHOSTACTION:  ACCEPT
      FELIX_IPV6SUPPORT:                  false
      FELIX_LOGSEVERITYSCREEN:            info
      FELIX_HEALTHENABLED:                true
    Mounts:
      /lib/modules from lib-modules (ro)
      /run/xtables.lock from xtables-lock (rw)
      /var/lib/calico from var-lib-calico (rw)
      /var/run/calico from var-run-calico (rw)
      /var/run/nodeagent from policysync (rw)
   kube-flannel:
    Image:      quay.io/coreos/flannel:v0.11.0
    Port:       <none>
    Host Port:  <none>
    Command:
      /opt/bin/flanneld
      --ip-masq
      --kube-subnet-mgr
    Environment:
      POD_NAME:           (v1:metadata.name)
      POD_NAMESPACE:      (v1:metadata.namespace)
      FLANNELD_IFACE:    <set to the key 'canal_iface' of config map 'canal-config'>  Optional: false
      FLANNELD_IP_MASQ:  <set to the key 'masquerade' of config map 'canal-config'>   Optional: false
    Mounts:
      /etc/kube-flannel/ from flannel-cfg (rw)
      /run/xtables.lock from xtables-lock (rw)
  Volumes:
   lib-modules:
    Type:          HostPath (bare host directory volume)
    Path:          /lib/modules
    HostPathType:
   var-run-calico:
    Type:          HostPath (bare host directory volume)
    Path:          /var/run/calico
    HostPathType:
   var-lib-calico:
    Type:          HostPath (bare host directory volume)
    Path:          /var/lib/calico
    HostPathType:
   xtables-lock:
    Type:          HostPath (bare host directory volume)
    Path:          /run/xtables.lock
    HostPathType:  FileOrCreate
   flannel-cfg:
    Type:      ConfigMap (a volume populated by a ConfigMap)
    Name:      canal-config
    Optional:  false
   cni-bin-dir:
    Type:          HostPath (bare host directory volume)
    Path:          /opt/cni/bin
    HostPathType:
   cni-net-dir:
    Type:          HostPath (bare host directory volume)
    Path:          /etc/cni/net.d
    HostPathType:
   policysync:
    Type:          HostPath (bare host directory volume)
    Path:          /var/run/nodeagent
    HostPathType:  DirectoryOrCreate
   flexvol-driver-host:
    Type:          HostPath (bare host directory volume)
    Path:          /usr/libexec/kubernetes/kubelet-plugins/volume/exec/nodeagent~uds
    HostPathType:  DirectoryOrCreate
Events:
  Type    Reason            Age   From                  Message
  ----    ------            ----  ----                  -------
  Normal  SuccessfulCreate  14m   daemonset-controller  Created pod: canal-vrkbv

canal is working correctly. no crash or restarts
$ kubectl get pods -n kube-system -o wide
NAME                                     READY   STATUS    RESTARTS   AGE     IP            NODE             NOMINATED NODE   READINESS GATES
canal-9d5dl                              2/2     Running   0          2d19h   <IP_ADDRESS>   lxkubemaster01   <none>           <none>
canal-pxgnw                              2/2     Running   0          21h     <IP_ADDRESS>   lxkubenode01     <none>           <none>
canal-vrkbv                              2/2     Running   0          16m     <IP_ADDRESS>   lxkubenode02     <none>           <none>
coredns-6c5cb5bb5f-7mndq                 1/1     Running   0          2d19h   <IP_ADDRESS>   lxkubenode01     <none>           <none>
coredns-6c5cb5bb5f-fz49s                 1/1     Running   0          2d19h   <IP_ADDRESS>   lxkubenode02     <none>           <none>
etcd-lxkubemaster01                      1/1     Running   0          2d19h   <IP_ADDRESS>   lxkubemaster01   <none>           <none>
kube-apiserver-lxkubemaster01            1/1     Running   0          2d19h   <IP_ADDRESS>   lxkubemaster01   <none>           <none>
kube-controller-manager-lxkubemaster01   1/1     Running   2          2d19h   <IP_ADDRESS>   lxkubemaster01   <none>           <none>
kube-proxy-42mqr                         1/1     Running   0          2d19h   <IP_ADDRESS>   lxkubenode01     <none>           <none>
kube-proxy-7fr5z                         1/1     Running   0          2d19h   <IP_ADDRESS>   lxkubenode02     <none>           <none>
kube-proxy-grxwp                         1/1     Running   0          2d19h   <IP_ADDRESS>   lxkubemaster01   <none>           <none>
kube-scheduler-lxkubemaster01            1/1     Running   2          2d19h   <IP_ADDRESS>   lxkubemaster01   <none>           <none>

I am noticing a small difference in the iptabels from node 01 to node 02
lxkubenode02 is missing entry CNI portfwd requiring masquerade
lxkubenode01:~$ iptables --list POSTROUTING -n -t nat -v
Chain POSTROUTING (policy ACCEPT 67 packets, 5601 bytes)
 pkts bytes target     prot opt in     out     source               destination
 761K   73M cali-POSTROUTING  all  --  *      *       <IP_ADDRESS>/0            <IP_ADDRESS>/0            /* cali:O3lYWMrLQYEMJtB5 */
 761K   73M CNI-HOSTPORT-MASQ  all  --  *      *       <IP_ADDRESS>/0            <IP_ADDRESS>/0            /* CNI portfwd requiring masquerade */
3175K  289M KUBE-POSTROUTING  all  --  *      *       <IP_ADDRESS>/0            <IP_ADDRESS>/0            /* kubernetes postrouting rules */
 7099  939K RETURN     all  --  *      *       <IP_ADDRESS>/16        <IP_ADDRESS>/16
 103K 6182K MASQUERADE  all  --  *      *       <IP_ADDRESS>/16       !<IP_ADDRESS>/4
 148K 8857K RETURN     all  --  *      *      !<IP_ADDRESS>/16        <IP_ADDRESS>/24
    0     0 MASQUERADE  all  --  *      *      !<IP_ADDRESS>/16        <IP_ADDRESS>/16

lxkubenode02:~$ iptables --list POSTROUTING -n -t nat -v
Chain POSTROUTING (policy ACCEPT 90 packets, 8485 bytes)
 pkts bytes target     prot opt in     out     source               destination
3111K  285M cali-POSTROUTING  all  --  *      *       <IP_ADDRESS>/0            <IP_ADDRESS>/0            /* cali:O3lYWMrLQYEMJtB5 */
3121K  286M KUBE-POSTROUTING  all  --  *      *       <IP_ADDRESS>/0            <IP_ADDRESS>/0            /* kubernetes postrouting rules */
 6787  920K RETURN     all  --  *      *       <IP_ADDRESS>/16        <IP_ADDRESS>/16
 103K 6182K MASQUERADE  all  --  *      *       <IP_ADDRESS>/16       !<IP_ADDRESS>/4
 190K   11M RETURN     all  --  *      *      !<IP_ADDRESS>/16        <IP_ADDRESS>/24
    0     0 MASQUERADE  all  --  *      *      !<IP_ADDRESS>/16        <IP_ADDRESS>/16

I am using a global-deny-all rule:
apiVersion: projectcalico.org/v3
kind: GlobalNetworkPolicy
metadata:
  name: global-deny-all
spec:
  order: 2000
  types:
  - Ingress
  - Egress

  # Egress network rules
  egress:
  # Allow all egress traffic from kube-system to cluster internals
  - action: Allow
    source:
      namespaceSelector: name == 'kube-system'
    destination: {}

  # Allow egress DNS traffic from coredns to <IP_ADDRESS> (company internal dns server)
  - action: Allow
    protocol: UDP
    source:
      selector: k8s-app == 'kube-dns'
      namespaceSelector: name == 'kube-system'
    destination:
      nets:
        - <IP_ADDRESS>/32
      ports:
        - 53

  # Ingress network rules
  ingress:
  # Allow all ingress traffic from outside to the kube-system namespace.
  - action: Allow
    source: {}
    destination:
      namespaceSelector: name == 'kube-system'

I do not see any policy that would allow ingress to the pods that are suppose to be accepting traffic from the ingress controller. I'm surprised the traffic from the ingress controller is working locally. Is the ingress controller running as hostNetworked? If so then policy doesn't actually apply to it unless you've defined Host Endpoints for your nodes, and could explain why they are able to reach local pods.

The ingress controller is bound to the hostNetwork.

As I understand it, I have an egress policy which allows the ingress controller to connect to any pod in any namespace with the podLabels ingress-controller: "public"  and allow-ingress: "true". Therefor the ingress controller should be able to connect to the pods.

Like I mentioned, policy does not apply to hostNetworked pods so any policy written to select the ingress pod will not work.
Even with that said because you have a deny all policy that applies for ingress traffic, so you will need policy that applies to your destination pods that allows ingress to them.
Lets assume that your current (source) pod trying access your application is pod networked (not hostNetworked), even if you applied egress policy to your source pod, if your application pod has policy that denies ingress traffic (which your default deny does) then there must be explicit policy that allows ingress.
In other words, just because you've allowed pod A to send traffic to pod B, if pod B is not allowed to receive traffic from pod A then the communication is blocked.

I had a similar issue on RHEL 8 which was resolved when I rebootrapped the cluster with the latest canal.yaml from calico. Also, I added the FELIX_IPTABLESBACKEND to the canal daemonset container spec env list.
           # Set IPTABLE backend to auto
            - name: FELIX_IPTABLESBACKEND
              value: "auto"

But, I'm of the impression that auto is the default option for that configuration now.

Actually, it only worked temporarily and it stopped working now. I see the same network timeout issue when pods across nodes try to talk to each other. I think it stopped working after we restarted our nodes (VMs) for weekly maintenance.
I do suspect that the source IP is getting changed from the original pod's IP to a different IP when it reached the target node. I can get the pods to talk across nodes if I change the policy to use ipBlock of the podSubnet CIDR.
Desired Policy (not working)
# Allow all traffic between app-stack pods
apiVersion: networking.k8s.io/v1
kind: NetworkPolicy
metadata:
  name: app-stack-allow-all-interpod
  namespace: default
spec:
  podSelector:
    matchLabels:
      app.kubernetes.io/instance: app-stack
  policyTypes:
  - Ingress
  - Egress
  egress:
  - to:
    - podSelector:
        matchLabels:
          app.kubernetes.io/instance: app-stack
  ingress:
  - from:
    - podSelector:
        matchLabels:
          app.kubernetes.io/instance: app-stack

Working policy (using ipBlock)
# Allow all traffic between app-stack pods
apiVersion: networking.k8s.io/v1
kind: NetworkPolicy
metadata:
  name: app-stack-allow-all-interpod
  namespace: default
spec:
  podSelector:
    matchLabels:
      app.kubernetes.io/instance: app-stack
  policyTypes:
  - Ingress
  - Egress
  egress:
  - to:
    - podSelector:
        matchLabels:
          app.kubernetes.io/instance: app-stack
  ingress:
  - from:
    - ipBlock:
        cidr: <IP_ADDRESS>/16

And, I did confirm that both the pods have the label app.kubernetes.io/instance: app-stack
$ kubectl get pods -l app.kubernetes.io/instance=app-stack -owide
NAME                   READY   STATUS    RESTARTS   AGE    IP            NODE                   NOMINATED NODE   READINESS GATES
app-stack-db-sset-0   1/1     Running   0          154m   <IP_ADDRESS>   worker2.mydomain       <none>           <none>
app-stack-sset-0      0/1     Running   0          154m   <IP_ADDRESS>   worker3.mydomain       <none>           <none>

Can anyone help me troubleshoot this networking issue? Thanks

@tmjd I tried looking into the iptables packet as you suggested in issue #1923. When I diff`ed the packet count before and after, I got the below output:
< [0:0] -A cali-fw-calib2b14591c8c -m comment --comment "cali:SAb1o07tWVVNkA8R" -m conntrack --ctstate INVALID -j DROP
---
> [2:80] -A cali-fw-calib2b14591c8c -m comment --comment "cali:SAb1o07tWVVNkA8R" -m conntrack --ctstate INVALID -j DROP
48c48
< [2:80] -A cali-fw-cali2f5211f64be -m comment --comment "cali:zxne0U1qIO3lgFtH" -m conntrack --ctstate INVALID -j DROP
---
> [4:160] -A cali-fw-cali2f5211f64be -m comment --comment "cali:zxne0U1qIO3lgFtH" -m conntrack --ctstate INVALID -j DROP
53c53
< [0:0] -A cali-tw-cali467dcb24199 -m comment --comment "cali:xP8YZ83mJf8zUVRp" -m comment --comment "Drop if no policies passed packet" -m mark --mark 0x0/0x20000 -j DROP
---
> [3:180] -A cali-tw-cali467dcb24199 -m comment --comment "cali:xP8YZ83mJf8zUVRp" -m comment --comment "Drop if no policies passed packet" -m mark --mark 0x0/0x20000 -j DROP

I'm not sure how to decode this. Do you have guidance?

Reading through this, I think @tmjd's analysis is correct. Pods running with hostNetwork: true are not valid targets for network policy label selectors. You'll need to use host endpoints in order to apply to host-networked things.
My strong suspicion is that your egress policy is blocking the traffic because the host IP is not included in the egress policy selector. This is, unfortunately, working as intended. You'll need to use an exact IP / subnet in your selector, or use host endpoints to select nodes.


Provisioning of lambda function handler for dataset uploads

In order to initiate dataset processing for datasets that have gone through the 'local upload' route to our s3 bucket, we will need a lambda to listen for S3 upload events for this bucket and respond accordingly.
The lambda should parse the key name of the S3 object as follows:
s3://cellxgene-curation-submissions-{dev,staging,prod}/<collection_id>/<curator_tag>
Lambda function:

the curator tag is everything in the pseudo-path key after the second /.
the collection_id is determined by everything between the first and second /.
the handler function must check the given collection, as indicated by the collection_id in the key, to see if a dataset with curator_tag already exists. If so, the lambda must follow the current paradigm for [canceling processing of / deleting] a dataset that the v1 API uses.
the handler function must then initiate processing of the dataset

Temporarily moving this story to the backlog to maintain board hygiene.

ready for qa now?


Update to Debian 11

https://github.com/avsm/ocaml-dockerfile/pull/59

Pushed to live along with #127 for testing


qu2cu

Based on https://github.com/googlefonts/cu2qu/pull/29/files#diff-0ad9d3d850d1321d2e2abe961cabbef118134bb5c155ee65103968c8c2fe16acR274-R286

I was unable to locate the tests. Now we have cu2qu and qu2cu you could round trip things, perhaps cherry-picking cases where that works out with nice #s.

I was unable to locate the tests. Now we have cu2qu and qu2cu you could round trip things, perhaps cherry-picking cases where that works out with nice #s.

Yeah right now there's just a main that roundtrips. Will need tests indeed.

The algorithm is slow (O(n^3)). But for short segments that cu2qu generates it should not matter.

Later we can add quadratics_to_curve that takes multiple (joining) quadratic splines and converts them.

I think this is ready now. With tests.

I've rebased it on cubic-glyf branch, but that's only required for the cli, which is not tested. So can be rebased on main and merged.

can be rebased on main

Done.

Okay I'm finally happy with this.


Adding Animations

Is your feature request related to a problem? Please describe.
Adding animations will make the UI look more enhanced and attractive.
Describe the solution you'd like
I can Add animations to the Page on loading and scrolling just like in my portfolio website https://mhportfolio.vercel.app/. Please assign me this to add new feature.
Describe alternatives you've considered
Using vanilla CSS and animations library the feature can be implemented.
Additional context
you can visit my website https://mhportfolio.vercel.app/ and my open source contribution website https://www.devlabsstore.tech/ to see animations.
@SUGAM-ARORA

Merged


Refresh Token Not Working

Basically I've been using Reddit.NET without issues but of course my token expires within an hour so I give it a refresh token and it still ends up expiring. I have also tried the following example to no avail, instantly gives a 401.
            var reddit = new RedditClient('', '');             Console.WriteLine('Username: ' + reddit.Account.Me.Name);             Console.WriteLine('Cake Day: ' + reddit.Account.Me.Created.ToString('D'));

Closed the issue as it just kinda fixed itself


Front/Back channels randomly switch.

Has anyone had a issue where the Front channels will switch from playing on front speakers to the back speakers?  and vis versa.
THIS happens almost exclusively when playing videos or webvideo content.
Rather odd issue I've seen happen on a few machines I've used scream on. And the host machine still has the channels assigned and working correctly so it must be the windows scream driver?

Still a issue. Watching youtube video and audio will move around from rear to side to centre channels.  Seems to be exclusively a issue with video files or web video so far.  Games don't cause this issue.

I suspect that games don't trigger this behavior because many games will use as many audio channels as they can, while youtube is usually stereo or mono so doesn't use all your audio channels.


Rename all references of symbol to pair

We have two references to the asset code. In some places, we named it as pair and in other places are symbol.
We need to patronize this and change all references to pair
For example: https://github.com/rodrigo-brito/ninjabot/blob/9be8210d42a9dbb536e7a6a83f5357359fd604f6/download/download.go#L57

Hi, I might be able to take this on! For clarification, you want me to change all symbol to pair in the asset code?

Yes. Exaxtly.


fix:SELinux context not set crashes container

Following documented instructions for installation, using docker-compose (podman-compose) may result in the devlake container constantly crashing due to permissions on the .env
Closes #5474
⚠ Pre Checklist

Please complete ALL items in this checklist, and remove before submitting

[x] I have read through the Contributing Documentation.
[ ] I have added relevant tests.
[ ] I have added relevant documentation.
[x] I will add labels to the PR, such as pr-type/bug-fix, pr-type/feature-development, etc.

Summary
What does this PR do?
a modification to the docker-compose file to set the SELinux context on .env for
the devlake container
Does this close any open issues?
Closes #5474
Screenshots
None relevant
Other Information
First PR on this project. I hope I targetted the right file. Would appreciate insights, feedback and thanks for taking time to review

Hi @EliadCohen, thanks for the PR, we really appreciate it. However, we won't be able to merge this PR for two reasons: we're already in the process of getting rid of the .env file altogether and we don't officially support podman-compose. If the devlake container crashes under docker-compose, let us know and we'll look into it.
@klesh Feel free to correct me if I'm wrong.

Hi @EliadCohen, thanks for the PR, we really appreciate it. However, we won't be able to merge this PR for two reasons: we're already in the process of getting rid of the .env file altogether and we don't officially support podman-compose. If the devlake container crashes under docker-compose, let us know and we'll look into it.
@klesh Feel free to correct me if I'm wrong.

Yes, it does crash with docker-compose, see #5474
Good news about getting rid of the .env file though... maybe worth waiting on this

@EliadCohen Thanks for your contribution, adding a mount option for SELinuex seems legit to me according to the docker run document. I'm not familiar with SELinux, Would it affect users that are not using SELinux?
As @hezyin  said, we are getting rid of the .env file, so, I think we should do the following:

this PR should be merged into release-v0.17 instead of the main branch and devops/releases/lake-v0.17.0/docker-compose.yml should be updated too
remove this mount from docker-compose-dev.yml on the main branch

I'm on it, thanks!


The status bar flickers continuously

it is now updated also when it is not dirty, but that is not the problem, although it might make the effect worse, the status bar is now drawn with only an empty background for some frames (at least that is what it looks like), observed in windows7

Tried to apply gert-jan's COffscreenPaint solution to the status bar but the result is the status bar's regions do not get drawn anymore. (no flicker either though :)
class CMultiPaneStatusBarCtrlFlickerFree :					// CMultiPaneStatusBarCtrl replacement
public CMultiPaneStatusBarCtrlImpl,
public COffscreenPaint
{
public:
DECLARE_WND_SUPERCLASS(nullptr, CMultiPaneStatusBarCtrlImpl::GetWndClassName())
BEGIN_MSG_MAP(CMultiPaneStatusBarCtrlFlickerFree)
	CHAIN_MSG_MAP(COffscreenPaint<CMultiPaneStatusBarCtrlFlickerFree>)
END_MSG_MAP()

void DoPaint(CDCHandle dc, const RECT& rcClip) override
{
	dc.FillSolidRect(&rcClip, Colors::BackGround);
	DefWindowProc(WM_PAINT, reinterpret_cast<WPARAM>(dc.m_hDC), 0);
}

};

Ha,
Jouw aanpak is okee maar om onduidelijke redenen werkt dit niet voor een status bar…
Gert-Jan

On 12 Sep 2015, at 21:03, Jan Wilmans<EMAIL_ADDRESS>wrote:
Tried to apply gert-jan's COffscreenPaint solution to the status bar but the result is the status bar's regions do not get drawn anymore. (no flicker either though :)
class CMultiPaneStatusBarCtrlFlickerFree : // CMultiPaneStatusBarCtrl replacement
public CMultiPaneStatusBarCtrlImpl,
public COffscreenPaint
{
public:
DECLARE_WND_SUPERCLASS(nullptr, CMultiPaneStatusBarCtrlImpl::GetWndClassName())
BEGIN_MSG_MAP(CMultiPaneStatusBarCtrlFlickerFree)
CHAIN_MSG_MAP(COffscreenPaint)
END_MSG_MAP()
void DoPaint(CDCHandle dc, const RECT& rcClip) override
{
dc.FillSolidRect(&rcClip, Colors::BackGround);
DefWindowProc(WM_PAINT, reinterpret_cast(dc.m_hDC), 0);
}
};
—
Reply to this email directly or view it on GitHub https://github.com/djeedjay/DebugViewPP/issues/132#issuecomment-139809957.


Feat/add local qna pair

Hey, first of all cool project.
I'm not sure if you want this to be an online only project. I totally see where that comes in handy. I prefer to do the loading of the data myself, then sanitize it locally, make sure everything is as I want it, and then have it embedded. I guess the difference in approach is that I want to supply my own learning material, while the online approach is more about teaching the right public material.
My specific use case is the following: I'm looking to switch from a classic QnA bot to a LLM. That's why I added the option to add a local QnA pair.
I made a new method add_local, to make it clear that it's not a URL you're supposed to pass to the function. This might seem like it adds complexity now, but I think this split makes sense going forward. We're going to want to add more local options, for instance regular plain text. And then we could also consider adding local variants of the online stuff, maybe not videos but local pdf makes sense.
I hope you approve of my idea, and agree that this functionality is the right way to move forward. Thanks.

I want to add that the prompt engineering that I do using Q:... \nA:... is how openai does it if you select the Q&A preset in the playground.
I'm happy to change the chunk size. I just looked at what you used for a pdf and decided it should be smaller since QnA pairs are usually smaller than a PDF I'd say, but that's totally negotiable.

Fixed the mentioned issues. I also tested it again. Works.

Thank you @cachho . This is a great contribution.


(chore) switch to fork

Coverage remained the same at 100.0% when pulling 8390deb5a5db9cede1bd7903fa57f9455ceab7d2 on fork-etcd-o-r into 7f1485b59b8fb10f58e1d1300fe89f020dc620cb on master.

📦 2.3.2


Smoke-test rclone with --version instead of --help

Closes #121.

Codecov Report

Merging #122 (1c8793b) into master (fbd159a) will increase coverage by 0.27%.
The diff coverage is 72.72%.

@@            Coverage Diff             @@
##           master     #122      +/-   ##
==========================================
+ Coverage   67.63%   67.91%   +0.27%
==========================================
  Files           1        1
  Lines        1372     1390      +18
  Branches      304      308       +4
==========================================
+ Hits          928      944      +16
- Misses        357      358       +1
- Partials       87       88       +1

Impacted Files
Coverage Δ

src/datalad_installer.py
67.91% <72.72%> (+0.27%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbd159a...1c8793b. Read the comment docs.

Looks good and green . Let's also release for the rclone remote to take advantage of this. Thank you @jwodder !


test(projects): add browser step

This PR add a new step to browser tests that will start web-server and open browser. It will catch console.error() and errors that will be thrown:

Warnings

:warning:
There are no updates provided to CHANGELOG. Ensure there are no publicly visible changes introduced by this PR.

  Generated by :no_entry_sign: dangerJS


Imported Disk image is not removed from temp dir if cancel creation of VM

Describe the issue
I ran into an issue where I click cancel when creating a new VM after having imported a disk.   When I tried to create a new VM and import the same disk again I got a "... couldn’t be copied to “Images” because an item with the same name already exists." error.  This persisted after quitting and re-running UTM.
I knew that the disk image must have been copied somewhere so I used fs_usage to determine it had been copied to $TMPDIR/com.utmapp.UTM/Images.   Once I found that I could manually delete the image file.
The bug is that the image is not removed if the VM creation is canceled after the drive is imported (and not deleted prior to canceling.
Configuration

UTM Version: 2.0.28
OS Version: MacOS 11.4
Intel or Apple Silicon? : Apple Silicon

Thanks for creating this issue @Morac2 - I ran into this on my very first run of UTM on an M1 Mac mini. It crashed when I tried to add the Spice Tools, and I couldn't get going again without finding this image. Having zero experience with UTM, I wasn't sure where to look for it.


[Bug/Glitch]

Legacy4J Version
1.21 - 1.7
Mod Loader Version
Fabric 0.100.7 1.21
Bug/Glitch Occurrence Context
View bobbing stops working when Shaders are enabled through Iris
Crash Report
No response
What happened wrong?
The view bobbing would stop working if i turned on shaders, making the game seem like i was always in creative flying in third person and just look off in first.

This is known, and is unfixable in my part without removing the Flying View Rolling


feat: Added application templates

Description
This PR adds the required BE API for application templates. It gets templates from appsmith cloud services through REST API.
Fixes #10391 #10390 #10584
Type of change

New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Manually

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

/ok-to-test sha=43c9537


Panda logs

This works, but adds about an extra two seconds on SPI pandas since it tries to get all available logs. Should be optimized more

This works, but adds about an extra two seconds on SPI pandas since it tries to get all available logs. Should be optimized more

Not sure why this would only affect SPI pandas? And this doesn't seem to be the case. We've got good tests for the pandad startup time - https://github.com/commaai/openpilot/blob/master/selfdrive/boardd/tests/test_pandad.py

Oh I fixed that issue since that comment, seems like I forgot to merge this PR, I thought I did!


[azure-identity-cpp] publish version 1.3.0-beta.2

Update vcpkg ports for Azure SDK release. This release may contain multiple ports.

Please ignore this PR. Sorry for the noise. We'll figure out how to avoid unwanted PRs in the future.


Guide to setting environment variables in Kubeflow Pipelines

Setting environment variables is very common in container-based workflows. It is supported in Kubeflow Pipelines, but you have to dig through the code to find out how: https://github.com/kubeflow/pipelines/blob/8110de0419b943a0666fe8dc759fe70f7e0517cc/sdk/python/kfp/dsl/_container_op.py#L338
We should create a guide explaining how to do it.
Thanks to @DanSanche for suggesting this doc.

Hi thinking about taking this one. But would like som guidance, do you have any similare tutorials that I can see the structure, and where in the repository would be a good place to put the turotial?
Cheers
Johan

Hallo @JohanWork sure! Are you registered to take part in the doc sprint, or would you like to tackle this outside of the doc sprint?
You can find a guide to working in the doc sprint here:
https://github.com/kubeflow/website/wiki/Sprinter's-Guide
Make sure you're registered by filling out the registration form (link is on the above guide), so that we can send you all the details.
If you'd like to contribute outside the doc sprint, that's great too. Here's the guide to updating the docs:
https://github.com/kubeflow/website/blob/master/README.md
The code for this particular page should go in this section of the docs:
https://master.kubeflow.org/docs/pipelines/
I'll hand over to @joeliedtke to give further guidance, as he's the lead tech writer for Kubeflow Pipelines.

Hello,
I would recommend creating a guide like one of the following:

Build components and pipelines
Building lightweight components

I would recommend adding this doc to /docs/pipelines/sdk.
 Where possible, refer back to existing docs, such as Getting Started
What steps are required to do this, and if possible providing example code
If appropriate, the example code can be provided as a notebook or Python script as well as included in the doc, and saved in an examples repo. Please let me know if that would be useful in this case and I will recommend a location for the example code.

Please let me know if you have any questions. Thank you for thinking about taking this issue on!

Thansk! I am not registred for the doc-sprint my plane was to finish this during the sprint but the work came in between. So If some one wants to take this task feel free otherwise I will takle it ouside and create a tutorial!

@sarahmaddox I have started to work on it, to clarify. When I have been using env variables in Kubeflow piplines it has mostly been true kubernetes secrets is that the same thought as here, the process then normally is.

You create a secret (for example usernamen and password for a database)
You pass it in to the container in the pipline  through the  .add_env_variable

@JohanWork I'm not sure if the username/password is a typical use case. @Ark-kun can you add some clarity here?
In case they're useful, here are some examples from the SDK code:

https://github.com/kubeflow/pipelines/blob/master/sdk/python/kfp/dsl/_container_op.py#L128 (hello world)
https://github.com/kubeflow/pipelines/blob/master/sdk/python/kfp/dsl/_container_op.py#L1138

/cc @joeliedtke

Thanks for taking this one @JohanWork!
/assign @JohanWork
If you'd like to register for the doc sprint (link in previous comment) then we can still count this work as part of the doc sprint.

Realised now that something like the hello world would be a much easier example. Will do something like that @sarahmaddox.

Thanks @JohanWork! I also just realised that @rmgogogo may have good input on use cases too.


feat(theme): Add high contrast themes

Add high contrast light theme with AAA score.
Add high contrast dark theme with AAA score.
Add underline to .iui-anchor only on high contrast theme.
Updated theme-button.

Updated scenarios of demo pages that included the theme-button in the test results since these tests were already visually changing.

::selection opacity changed from opacity 4 to 5.
Add color.html demo page for testing contrast easily.

Muted positive, warning, negative text within overlay positive, warning, negative are not present in any of our UI components.  However primary IS present.
Muted primary text within primary overlay in light HC is failing, only know failure atm.

Demo.css changes:

Use CSS variables for <hr>.
Add overflow: overlay to test scrollbar above different background colors in color.html.

After #508 and #511 get merged, we also need to check two more things:

Contrast ratio should be at least 7:1 to meet WCAG AAA requirements (otherwise it's not really "high" contrast). 4.5:1 should be met in our normal themes.

https://www.w3.org/WAI/WCAG21/Understanding/contrast-enhanced.html
https://webaim.org/articles/contrast/#sc146
https://blog.prototypr.io/high-contrast-mode-ftw-bef74e097d1e

Should work with forced high contrast mode in Windows.

https://blogs.windows.com/msedgedev/2020/09/17/styling-for-windows-high-contrast-with-new-standards-for-forced-colors/
https://blog.khanacademy.org/making-websites-work-with-windows-high-contrast-mode/

After #508 and #511 get merged, we also need to check two more things:

Contrast ratio should be at least 7:1 to meet WCAG AAA requirements (otherwise it's not really "high" contrast). 4.5:1 should be met in our normal themes.

w3.org/WAI/WCAG21/Understanding/contrast-enhanced.html
webaim.org/articles/contrast/#sc146
blog.prototypr.io/high-contrast-mode-ftw-bef74e097d1e

Should work with forced high contrast mode in Windows.

blogs.windows.com/msedgedev/2020/09/17/styling-for-windows-high-contrast-with-new-standards-for-forced-colors
blog.khanacademy.org/making-websites-work-with-windows-high-contrast-mode

You can check page situation with Css Overview in Chrome dev tools.

Not sure how trustful it is, though...

Contrast ratio should be at least 7:1 to meet WCAG AAA requirements (otherwise it's not really "high" contrast). 4.5:1 should be met in our normal themes.

Our current light / dark themes do not meet WCAG AA.  The new high contrast light / dark theme meet WCAG AA but not AAA.  We could make these new themes the defaults since they do meet AA and then create new high contrast themes that meet AAA.

Contrast ratio should be at least 7:1 to meet WCAG AAA requirements (otherwise it's not really "high" contrast). 4.5:1 should be met in our normal themes.

As of right now all text, with 1 exception, is passing with AAA.  Same goes for important interface elements (border of checkboxes) and icons.

Should work with forced high contrast mode in Windows.

@media (forced-colors: active) is new to me.  I will look into if I can replicate this on macOS.  From what I'm seeing here this might be on a component by component basis.

@FlyersPh9 This looks a lot better! I tried to go through all components, and most places, it's passing AAA, but some of the hover/focus/active states are not.

Also, disabled/muted/placeholders are obviously failing. I know they are not required to pass AAA, but we might still want to increase the contrast a little bit because some of them are really hard to see.

The muted text is also used in footer, which has low visibility and is hard to even tell that it's made of links.
One more issue I did notice is that because the dark theme background is so... dark, all our shadows are lost.

This is also an issue with translucent backgrounds such as our tooltip where the boundary is lost.

So you might want to adjust some of the background colors a little bit, or add borders. https://twitter.com/steveschoger/status/1499780803550658567

Lines 396-408 seem to be overriding changes set above.
The placeholder text opacity is set to 5, and I'd like to try changing it to 4 for high contrast themes, but I'm not seeing the change.

Looks like it is meant to override the other stuff and it's not possible to add theme-specific values there. You could try moving the iui-text-color-placeholder from $cssVariables into each of the themes above.

I'm not sure how much we control of this, but the colors of many of the user icons don't pass AAA (or even AA). The color on the background or the (white) initials on the color.

Hmm, I'm not sure how we can best handle this.  Maybe we add a text-shadow only when high contrast is on?  Let me think on this for a little bit.

I don't know how well this would work, but you could add an overlay with box-shadow so that user icons are shaded with white for dark theme and black for light theme, and the text color should be black for dark theme (light icons) and white for light theme (dark icons). This does mess with the box-shadows already present though. I don't like the way this looks exactly - something is off with the text color, and I didn't get it working for the stacked lists, but something like this:

1st one has box-shadow: inset 0 0 0 200px rgb(255 255 255 / 50%); color: black; and 2nd one has box-shadow: inset 0 0 0 200px rgb(0 0 0 / 60%); in iui-initials. But with this method you have to make assumptions about how light/dark the color is initially.

I don't know how well this would work, but you could add an overlay with box-shadow so that user icons are shaded with white for dark theme and black for light theme, and the text color should be black for dark theme (light icons) and white for light theme (dark icons). This does mess with the box-shadows already present though. I don't like the way this looks exactly - something is off with the text color, and I didn't get it working for the stacked lists, but something like this:
1st one has box-shadow: inset 0 0 0 200px rgb(255 255 255 / 50%); color: black; and 2nd one has box-shadow: inset 0 0 0 200px rgb(0 0 0 / 60%); in iui-initials. But with this method you have to make assumptions about how light/dark the color is initially.

That's an interesting approach.  I vote that we let this PR pass as is and tackle both user icons and badge AAA scoring issues in separate PRs while working towards CSS 1.0.


client connecting and instantly disconnecting (Linux)

Description
Client connecting and instantly disconnecting, with error Client disconnected. Cause: Broken pipe (os error 32) in logs, client says 'server disconnected' (or something like that)
General Troubleshooting

[X] I carefully followed the instructions in the README and successfully completed the setup wizard
[X] I read the ALVR GitHub Wiki

Environment
Hardware
hw-probe
GPU Driver Version:
nvidia 555.58.02-2
Audio:
pipewire
Installation
ALVR Version:
v20.9.1
ALVR Settings File:
default, only added headset  host + IP
SteamVR Version:
beta 2.7.2 or stable 2.6.2 (both not working)
Install Type:

[ ] Packaged (exe, deb, rpm, etc)
[X] Portable (zip)
[ ] Source

OS Name and Version (winver on Windows or grep PRETTY_NAME /etc/os-release on most Linux distributions):
PRETTY_NAME="EndeavourOS"

tried to play with connection settings. When switching to TCP, headset and controllers tracking working (i can see that in steamVR display view), but image is just gray

after using fix from https://github.com/alvr-org/ALVR/wiki/Linux-Troubleshooting#fix everything works, idk if that was the primary issue, but i can't reproduce it now event with UDP


[test] Flip the default value of allowUnexpectedNotification

This is/was mostly useful for testing specific notification
interactions. Most new tests shouldn't need it, so remove the
boilerplate.

@swift-ci please test


Dropdown - initial value not selected

Expected Behavior
When dropdown is bound to a model which is intially set, and options are rendered via ng-repeat, I would expect that option that is corresponding to the initial value of model is pre-selected:

Actual Behavior
When model is initially set, there is nothing selected in the dropdown:

It is reproduced in the following codepen:
http://codepen.io/jjczopek/pen/VaKZJY
Steps to Reproduce Behavior
See above codepen.
@rolandoldengarm: I think you would know the best ;)

Yes, looks like a bug to me. Will work on it.

I've spent quite some time on it, but haven't been able to find a solution.
During link, the render function of ngModel is called and tries to retrieve the child elements to find the element with the given value. However, at that time the elements are not compiled yet.
I've tried different things, and fixed it partly. However, it's still not working when ng-repeat is used.
The demo is working as that one is not using ng-repeat.
See my branch here: https://github.com/rolandoldengarm/ng-officeuifabric/tree/issue-230
It's time for a fresh pair of eyes to have a look.

One workaround would be to pass the value using the title attribute. Since attributes are bound at the time of the execution of the postLink function you can use the value from the title attribute to update the selected item. I have a working solution in my fork @ https://github.com/waldekmastykarz/ng-officeuifabric/tree/issue-230. Looking forward to hear your thoughts on this approach.

That looks good to me, thanks. That was easy... Will you be able to add a test case, as I've added to proof it's working?
I can't clone your repo, as I've already cloned the main repo.
See here for the test case:
it('should be able to set initial value', inject(($compile: Function, $rootScope: ng.IRootScopeService) => {
        let $scope: any = $rootScope.$new();
        $scope.options = [
            { text: 'Option 1', value: 'Option1'},
            { text: 'Option 2', value: 'Option2'},
            { text: 'Option 3', value: 'Option3'},
            { text: 'Option 4', value: 'Option4'}
        ];
        $scope.selectedValue = 'Option2';
        let dropdown: JQuery = $compile('<uif-dropdown ng-model="selectedValue">' +
            '<uif-dropdown-option ng-repeat="o in options" value="{{o.value}}">{{o.text}}</uif-dropdown-option></uif-dropdown>')($scope);

        $scope.$digest();
        dropdown = jQuery(dropdown[0]);
        let title: JQuery = dropdown.find('span.ms-Dropdown-title');
        expect(title.text()).toBe('Option 2', 'Displayed text should be Option 2');
    }));

Will do that!

I've added the test. Do you mind checking it out @rolandoldengarm?

@waldekmastykarz I don't see a commit to that branch?
https://github.com/waldekmastykarz/ng-officeuifabric/commits/issue-230

I've amended the previous commit.

Ah :)
Yes, looks good to me!! Please submit a PR :)


Cuda Catchup

The cuda compiler is pretty far behind the metal compiler. It needs to be brought in line with metal and get mistral and llama running on it. This should be pretty straightforward.

[x] Unify fp32 and fp16 cuda compilers
[ ] Add special ops metal uses (ARange, Softmax, etc.)
[ ] Get mistral and llama working on cuda in fp32 and fp16
[ ] Remove custom cudarc fork
[ ] Drop down to a lower cudarc api level (needed for quantizations)

Cudarc fork now is just waiting on this pr: https://github.com/coreylowman/cudarc/pull/204

PR approved, now just waiting on a new release to crates.io

Cuda caught up


Silent Option now true by default

Thanks for working on this. You also need to update the readme.

GitHub tip: Always reference the issue you're fixing with a sentence like: Fixes #8

Hey!
Thanks for the feedback.
You're welcome, glad to help.

Thank you :)


[AutoPR network/resource-manager] Add new Nat Gateway resource

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/5579

(message created by the CI based on PR content)

Codecov Report

Merging #4815 into restapi_auto_network-march-release will decrease coverage by 0.02%.
The diff coverage is 28.57%.

@@                          Coverage Diff                           @@
##           restapi_auto_network-march-release    #4815      +/-   ##
======================================================================
- Coverage                               49.82%   49.79%   -0.03%
======================================================================
  Files                                    6223     6207      -16
  Lines                                  174840   174304     -536
======================================================================
- Hits                                    87113    86794     -319
+ Misses                                  87727    87510     -217

Impacted Files
Coverage Δ

...rk/azure/mgmt/network/network_management_client.py
21.06% <28.57%> (+0.02%)
:arrow_up:

...azure/mgmt/eventhub/v2017_04_01/models/__init__.py
58.82% <0%> (-12.85%)
:arrow_down:

...ervicebus/azure/mgmt/servicebus/models/__init__.py
58.44% <0%> (-10.88%)
:arrow_down:

...ces/azure/mgmt/recoveryservices/models/__init__.py
55.17% <0%> (-7.91%)
:arrow_down:

...-hdinsight/azure/mgmt/hdinsight/models/__init__.py
52.72% <0%> (-4.54%)
:arrow_down:

...t/recoveryservices/operations/vaults_operations.py
67.91% <0%> (-2.63%)
:arrow_down:

...rvices/operations/replication_usages_operations.py
94.11% <0%> (-0.48%)
:arrow_down:

...t/recoveryservices/operations/usages_operations.py
94.11% <0%> (-0.48%)
:arrow_down:

.../mgmt/recoveryservices/recovery_services_client.py
100% <0%> (ø)
:arrow_up:

...ebus/models/service_bus_management_client_enums.py
100% <0%> (ø)
:arrow_up:

... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b83683...935a56f. Read the comment docs.


sh -c of uname command prints out EBCDIC in ASCII build

osname.pl:
eval "chop (\$osname = `sh -c 'uname -nmsr 2>&1'`)";
print $osname;

perl osname.pl should print out the ASCII uname with the newline on the end dropped. It doesn't. This comes from GNU make testing system.
This does work:
eval "chop (\$osname = `uname -nmsr 2>&1`)";
print $osname;

Seems to be an issue with the tag of the STDERR fd.  Doing this makes it passes:
_TAG_REDIR_ERR= ./perl osname.pl
Looks likes there's double conversion at some point.   Also, by removing 2>&1, it passes.

you know more of perl than me now so transferring this over to you (hopefully fixed now?)

fixed awhile ago


Every time the value updates, cursor gets set to the end of the field

Describe the bug
Every time the value updates, cursor gets set to the end of the field.
To Reproduce
I'm using valtio as a state manager and mem_ai is a proxy store. I tried this with useState but didn't change the behavior.
<RichTextarea
  id="name"
  rows={1}
  autoHeight
  placeholder="Type something"
  style={{ width: "100%", resize: "none" }}
  value={mem_ai.values.name}
  onChange={(e) => {
    mem_ai.values.name = e.target.value
  }}
/>

Expected behavior
To be able to write to the field without feeling like I want to break the keyboard ;)
Platform:

OS: MacOS
Browser: Chrome
Version of this package: 0.24.4

Video:
https://github.com/inokawa/rich-textarea/assets/1594723/119f5fd0-0df2-4e57-ad05-b4b86ca33f0f

Could you make a reproduction?
https://inokawa.github.io/rich-textarea/?path=/story/basics-textarea--one-line-auto-height is very similar situation to you (without resize:none style and autoHeight prop) but it looks fine.

I just noticed that this is caused by valtio. When I update state in onChange, it works as expected. Earlier I first updated valtio which then updated the state through useEffect.
onChange={(e) => {
  // mem_ai.values.name = e.target.value
  setName(e.target.value)
}}

Probably should investigate why valtio is causing the component to behave like this because having to run updates to global state through an extra useState/useEffect step is not very optimal 🤔


twitter bots: Write internal config to separate file and merge twitter-bot and twitter-search-bot.

Fixes #88.
While writing this I've discoverd a few discrepancies in our twitter bots:

both twitter-bot and twitter-search-bot use the same config files zulip_twitterrc (and now, zulip_twitterrc_internal in the same directory. Should we name them differently?

the integration doc for our twitter bot doesn't mention that a bot user needs to be created and a .zuliprc file exported to ~/.zuliprc for the bots to function.

the integration doc talks only about twitter-search-bot. Should we add a sectino for twitter-bot?

the docstrings for both bots seem to be quite outdated, with unsupported arguments, and misleading names (--user-id is used for specifying the user name, even though user-id is a unique number assigned to a user by twitter).

Which of these qualify as follow-ups?

To be honest, it's not clear to me why we need 2 scripts, rather than an option within a single script.  So I think if we want to fix this properly, we should just merge the two and have a --search option.
What do you think?

@timabbott updated this with both of your suggestions (don't write the normal config file and merge both bots.) Sorry for the messed up diff view.

I merged the first commit (after fixing the write_state issue in it).  I'd love it if you can get someone else to look through this somewhat carefully since I'm kinda swamped (ideally, including testing it out in their dev environment!)

Any luck getting someone to test or review?  @eeshangarg do you have time?

I can review this one tonight! @timabbott :)
On Sep 12, 2017 7:20 AM, "Tim Abbott"<EMAIL_ADDRESS>wrote:

Any luck getting someone to test or review? @eeshangarg
https://github.com/eeshangarg do you have time?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/zulip/python-zulip-api/pull/89#issuecomment-328802705,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AG6nb1KlMz2PvNfmr1DLn6Ik3ap-m8aKks5shlPzgaJpZM4PASCa
.

@eeshangarg thanks for the review! I created #6259 a while ago for updating the docs, can be looked at once this is merged :)

Merged, thanks folks!


Create directory in both cases

Currently, get_dir doesn't create the directory if the value was specified in the config file, which will raise FileNotFoundError at the end of the dataset creation script.
This fixes that.
Also, you can use os.makedirs(dir_name, exist_ok=True).

Makes sense. Thanks for the update.