UI improvements

From @zsup on January 14, 2015 9:8
Just did a comprehensive review of the app to pull together a list of UI tweaks. Overall I'd say we're about 75% there; it needs a bunch of clean-up and polish, but the structure's there.
There are a few places where this diverges significantly from the spec (entire views are missing and replaced with pop ups), and I think what's done here is more confusing and more difficult to use. I'd like to see a flow that is more like what's described in the "Spark Mobile SDK Views" Google Doc.
Overall I saw a few patterns that should be fixed throughout the app:

In general we want more whitespace to make the whole thing feel simpler and easier to follow
Elements should be better centered, both horizontally and vertically
Text should be a little bigger so it's more readable, and should use the custom font throughout
We should avoid jargony terms like "SSID" that most people don't know, and instead use English. We should also use full sentences with punctuation rather than shorthand, which feels unprofessional to me. Tell a story instead of giving a list!

Here are a bunch of specific fixes:
Flash screen

[x] Should this exist?
[x] Button at the bottom should be ~10px taller
[x] Text in the button is not properly vertically centered
[x] Version number in the bottom corner should use the custom font
[x] The button should be 10% darkened when tapped

Create account

[x] Increase spacing both above and below the logo in the top section (but a bit more above)
[x] "Create {company} account" should also bolded like a header
[x] Text boxes should be vertically centered on the screen
[x] When I type in the text boxes, the text is aligned all the way to the left; it should be spaced out better (like the placeholder text is)
[x] I already have an account should be underlined but not bolded; will help it look like a link
[x] Text at the bottom should be aligned to the bottom of the screen
[x] All text should be in the custom font
[x] The button should be 10% darkened when tapped
[x] Clicking away from the text boxes should make the keyboard go away

Login

[x] "Login" should be bolded like a header and spaced like a header (closer to the top)
[x] Same general spacing and formatting changes from the previous screen
[x] After I hit 'Log in' the 'create account' view pops up for just a moment
[x] All text should be in the custom font

Get Ready

[x] Where is this page? Need to add it. There should be instructions for preparing the hardware before the user gets to the instructions they need to follow on the phone.

Set up instructions

[x] This page has diverged a lot from the spec, which was a lot simpler. This page is confusing. We need to eliminate content and make this more visual.

[x] Device icon should be spaced further from the topic

[x] This view has too much content on it, and so it's confusing. All of the 'troubleshooting' content should move on to the previous 'Get Ready' page, so this page should just be instructions (which should then be larger and more spaced out, whitespace please!)

[x] Take off the spinner, which is confusing here (because it makes the user think they should be just sitting around waiting for something to happen)

[ ] The 'log out' and 'cancel' buttons at the bottom in the same color are a bit confusing. can we make them two different colors?

[x] All text should be in the custom font

[x] In general, please revert the design of this page to better align with the spec: https://docs.google.com/a/spark.io/presentation/d/1WrIhPIoY2keRxlKurJDsF02_dAq8w5Zys0URCHsTwPE/edit#slide=id.g5539d65f3_017

Select network

[x] More whitespace around everything. Make the scrolling box smaller in exchange for more space around all of the elements.
[x] Heading at the beginning should be a larger font
[x] All text should be in the custom font
[x] Icons aren't rendering cleanly (they're jagged, not smooth curves)
[x] Sort networks alphabetically. I think. actually I'd love feedback on this, I find the current order confusing, and my Mac laptop sorts networks alphabetically, which feels like it makes sense to me
[ ] Multiple networks with the same SSID should be eliminated. You should only see one of each
[x] The scrolling box needs something around it to show that it's scrollable; a border or a background or something to separate it from the rest of the screen
[x] Button text should be bolded
[x] "Manual SSID" should instead say "Type network name manually"
[ ] Also, "Manual SSID" should actually do something :-)
[x] Scrolling box should be horizontally centered (it's too far to the right)

Connect to Network

[x] Doesn't exist at all, instead replaced by a pop-up. I don't like the pop-up because it doesn't provide us the option to make the Wi-Fi password unobscured (which will reduce fat finger issues). Let's make this its own view.

Connecting

[x] More whitespace around the whole top section
[x] Add punctuation to the top section (connecting to: and "This can take about a minute.")
[x] There shouldn't be a separate background on the checkboxes section, and the horizontal lines also feel like they're spaced wrong and shouldn't exist at all
[ ] Spinners should be smaller so they're not bigger than the check marks
[x] Error message for a failed connection should be in English. "Claiming" a device does not mean anything to the end user. In fact the error message shouldn't exist at all, and should be replaced by the view below.

Connection Failed

[x] Where is this view? Replaced with an error message, which is too brief and confusing. Please build out the view instead.

Success

[x] Unfortunately never saw it! Got an error message instead. Looking forward to seeing it though :-)

Copied from original issue: spark/mobile-sdk-ios#39

Thanks, great feedback!
Things to discuss:

Splash screen - removing, though it does appear as screen 00 in the presentation
Buttons turn darker when pressed - will fix further down the road since I need to subclass all setup UI elements and give them custom behaviour
We should prepare the assets for the 'looping video' in the 05 GET READY screen and 'process images' for 06 DICOVER DEVICE screen
Troubleshooting screen - I recommend we prepare a static/on-website mobile-friendly HTML file for that, and display it via webview
set up instructions - buttons cannot have different color - it does not comply with the UI guidelines we were given, right now buttons get their color from "elementBlackgroundColor" property in customization class. Do we want to define a new parameter for seconary element color? not sure..
Success - there's no custom screen for that. The connecting progress indicators all get a checkmark and the DONE button becomes enabled. Do we want a popup? A whole new view for that?
Manual SSID feature not ready yet, I know :smile:  maybe I'll remove the button for now till I add this feature
Create account - I did not underline the "already have an account" intentionally as I set 3 button types: 1. underlined text = open a webview with external content. 2. Bold - change screen. 3. The orange background one - App/setup action (not orange but elementBackgroundColor to be exact). Do we want to change that? We need to be consistent with the buttons
Also added/fixed - on signup/login screens email/password text fields now show a "next" button in the keyboard (instead of "return") which will activate next text field. Last one has a "go" button which will submit... nice
"After I hit 'Log in' the 'create account' view pops up for just a moment" - known issue, needs some code refactoring to the whole setup/signup/login process code. I'll start from the cosmetic things and then drill down to heavy stuff

More discussion:

Set up instructions - move the troubleshooting text to the GET READY screen. Doesn't feel right because this troubleshooting talks about the failure to find the wifi network in settings, while the troubleshooting in the GET READY screen is about, er, getting the device ready.
No activity indicator - should we other solution to reflect the app is "scanning" for the connection with the device?

Select network screen - Sort networks alphabetically - we discussed with @m-mcgowan and @towynlin that networks are sorted by signal strength. Strongest first. I think it does make more sense than alphabetically. (imagine your home wifi is called Zach and there's 35 networks around)

Select network screen - The scrolling box needs border - I can add it no prob but according to the "flat" design Apple UI follows that's not required and even discouraged. I can however make the scroller element always visible if that helps (default is no)

From @zsup on January 14, 2015 21:51
Will do my best to address the issues here in bold
Splash screen - removing, though it does appear as screen 00 in the presentation
What I envisioned as screen 00 is like what pops up in the Spark Core app, i.e. just an image/logo that disappears after a moment automatically, not something with a button that you step past.
Buttons turn darker when pressed - will fix further down the road since I need to subclass all setup UI elements and give them custom behaviour
Sounds good
We should prepare the assets for the 'looping video' in the 05 GET READY screen and 'process images' for 06 DICOVER DEVICE screen
Agreed. Let's put Christine in charge of this, I think she'd do a good job
Troubleshooting screen - I recommend we prepare a static/on-website mobile-friendly HTML file for that, and display it via webview
Ok, sounds reasonable. Do we need to spec out this view? What do you think are the most common ways people will get stuck?
set up instructions - buttons cannot have different color - it does not comply with the UI guidelines we were given, right now buttons get their color from "elementBlackgroundColor" property in customization class. Do we want to define a new parameter for seconary element color? not sure..
I think yes we should define a secondary element color, maybe for this app we just take a different shade of the yellow?
Success - there's no custom screen for that. The connecting progress indicators all get a checkmark and the DONE button becomes enabled. Do we want a popup? A whole new view for that?
I think we should have a whole view that looks like what's spec'ed, i.e. a big check mark in a circle. I know it seems silly but that's the kind of thing that makes people who are nervous about it not working calm down
Manual SSID feature not ready yet, I know :smile: maybe I'll remove the button for now till I add this feature
Yeah that's probably a good call :-)
Create account - I did not underline the "already have an account" intentionally as I set 3 button types: 1. underlined text = open a webview with external content. 2. Bold - change screen. 3. The orange background one - App/setup action (not orange but elementBackgroundColor to be exact). Do we want to change that? We need to be consistent with the buttons
Links should all either be underlined or look like buttons (i.e. colored background); bold is not something that typically means it's clickable. Follow the design guideline in the original Spark Core app here. I could be convinced that this should be a button instead, but it definitely shouldn't be bolded text
Also added/fixed - on signup/login screens email/password text fields now show a "next" button in the keyboard (instead of "return") which will activate next text field. Last one has a "go" button which will submit... nice
Cool
"After I hit 'Log in' the 'create account' view pops up for just a moment" - known issue, needs some code refactoring to the whole setup/signup/login process code. I'll start from the cosmetic things and then drill down to heavy stuff
Sounds good
Set up instructions - move the troubleshooting text to the GET READY screen. Doesn't feel right because this troubleshooting talks about the failure to find the wifi network in settings, while the troubleshooting in the GET READY screen is about, er, getting the device ready.
Yes but the text you have here isn't actually about troubleshooting, it's about defining what the state of the device should be before you start set-up. Therefore it should be shown the user before set-up begins. In other words, we need to explain to them to plug in the pigtail and wait for flashing blue before we go ahead with the set-up process.
No activity indicator - should we other solution to reflect the app is "scanning" for the connection with the device?
I don't think we need it, the user doesn't have to know it's scanning. Instead we need to visually explain to the user that as soon as they connect to the correct device, the screen will go away.

Select network screen - Sort networks alphabetically - we discussed with @m-mcgowan and @towynlin that networks are sorted by signal strength. Strongest first. I think it does make more sense than alphabetically. (imagine your home wifi is called Zach and there's 35 networks around)

Yeah but that's how my Macbook works and I like it (alphabetical). My phone does it by signal strength and I find it way annoying. Don't know what Windows and iOS do, but I think we should copy what others do here
Select network screen - The scrolling box needs border - I can add it no prob but according to the "flat" design Apple UI follows that's not required and even discouraged. I can however make the scroller element always visible if that helps (default is no)
We definitely need some way to let the user know that it's scrollable. If you have other suggestions for how to do that, I'm all ears! This is a good one to find examples of how other well-designed apps solve this problem.

Multiple networks with the same SSID should be eliminated. You should only see one of each - this is a firmware issue
Connection failed screen (10)- @zsup
Cannot be made to function as presented since the mobile device already disconnected from the photon device SSID so it cannot force a 'retry' or 'change password' scenario without re-doing the discovery part (show discover screen, ask user to switch Wi-Fis, etc).
In device discovery screen - cannot fit all content (header, product photo, texts, wifi button, troubleshooting button, logout/cancel and a video) on 3.5" iPhone.. think on maybe hiding product photo for displaying the video for few seconds. preferred solution should better be consistent for all screen sizes

From @towynlin on January 20, 2015 3:26
I think the firmware should continue to show all BSSIDs (including duplicate SSIDs), and the mobile app should de-dup the list for user display.
We will have to make the failure cases as smooth as possible for the end user. Probably there should be a timeout, after which we say something like, "Connection is taking longer than expected. Go to Wi-Fi settings again and choose the device's network again if it exists. If you don't see the device network, click here."

We should discuss the two possible failures - both give suboptimal user experience -

device should not be owned - app do not know if the device connected to the cloud or failed because it cannot poll the device list for the user (it wouldn't appear there anyway)
device should be owned by user - polling device list timeouts - now is the problem bad wifi credentials? or is the problem error in claiming process? how do you suggest user to solve it? (iphone no longer on soft AP wifi and probably can't connect to it either because device already switch to internet wifi and not broadcasting its SSID)

more stuff to discuss:

screen layouts for 3.5" devices
inability to put all content (with video) on the discovery screen with the product photo
error messages wording for each case
success/failure screen - what to show

The WiFi network name runs into the network security type (See attached image from my iPod touch). There's plenty of vertical space on this screen so I think it would look nice to drop the security type down one line and left-align it with the network name. Sound good?
I would like to help out and make this change but I am having an issue with Xcode. Not sure if I'm doing something wrong or if it's an issue with Xcode7. When I open setup.storyboard most of the screens look blank (see screenshot below). I don't see any of the subviews at all. Is this due to an Xcode setting or am I just looking in the wrong place? In all the iOS projects that I've worked on we do our navigation and view layout programmatically so I don't have much experience with storyboards.

Thanks for the will to help!
Go to the storyboard and select "Width Compact | Height Regular" (3 rectangles leftmost in a column) and you'll be able to see the setup screens

That worked. Thanks!

@idokleinman I've updated the constraints on the password entry view to fix the overlap issue that I mentioned above. This made the overall container view of that screen a bit taller.
With the container view being centered vertically I think it's getting pretty close to the point where the keyboard would cover up the "Hide Password" switch on an iPhone 4s. That got me thinking, why is the container view centered. It seems a bit odd to me that the setup process has a mix of views that are top aligned and vertical-center aligned. For example, the Select Network screen is top aligned and the Enter Password screen isn't. The transition feels a bit strange.
I changed the constraints on the Enter Password screen (as well as the Manual Network screen) to make them top aligned with the same top margin as the previous screen. What do you think? If you like it I'll submit a PR.

Sure, I have no objections,
just be sure to check all modified viewcontrollers on a 3.5" (iPhone 4S)
screen before submitting the PR.
Thanks!
On Mon, Nov 9, 2015 at 5:44 PM, Jordan S<EMAIL_ADDRESS>wrote:

@idokleinman https://github.com/idokleinman I've updated the
constraints on the password entry view to fix the overlap issue that I
mentioned above. This made the overall container view of that screen a bit
taller.
With the container view being centered vertically I think it's getting
pretty close to the point where the keyboard would cover up the "Hide
Password" switch on an iPhone 4s. That got me thinking, why is the
container view centered. It seems a bit odd to me that the setup process
has a mix of views that are top aligned and vertical-center aligned. For
example, the Select Network screen is top aligned and the Enter Password
screen isn't. The transition feels a bit strange.
I changed the constraints on the Enter Password screen (as well as the
Manual Network screen) to make them top aligned with the same top margin as
the previous screen. What do you think? If you like it I'll submit a PR.
https://cloud.githubusercontent.com/assets/390842/11051988/53bfac6e-8722-11e5-8ff5-d5cb7ab26163.PNG
https://cloud.githubusercontent.com/assets/390842/11051989/53c2081a-8722-11e5-8ddd-39f8a7bb6a9d.PNG
https://cloud.githubusercontent.com/assets/390842/11051990/53c31ab6-8722-11e5-8163-4e0157e95b1c.PNG
—
Reply to this email directly or view it on GitHub
https://github.com/spark/spark-setup-ios/issues/11#issuecomment-155256201
.

--
Regards,
Ido Kleinman | Lead mobile engineer
<EMAIL_ADDRESS><EMAIL_ADDRESS>|<PHONE_NUMBER> <//415.400.6389>


Scoop doesn't check if install failed

I can't install quite a few things from scoop at work.
Scoop still thinks the package installs even if it cannot download the archive.
$ scoop install conemu
Installing 'conemu' (19.01.08) [64bit]
The remote server returned an error: (403) Forbidden.
URL https://github.com/Maximus5/ConEmu/releases/download/v19.01.08/ConEmuPack.190108.7z is not valid

A642177@GBDA320331 MINGW64 ~
$ scoop list
Installed apps:

  7zip 18.06
  clink
  cmder
  cmder-full
  conemu
  consolez
  curl 7.63.0
  git
  git-with-openssh
  neovim
  sliksvn 1.9.7
  unzip

This is a known issue. install.ps1 has to be refactored a lot to fix this.
The current workaround is uninstalling and reinstalling the program.

Cheers, I shall close this then.

@stuaxo @Ash258 @lukesampson please re-open, this is still an issue.


[BUG] - Cannot delete tunnel entry

Describe the bug
Cannot delete tunnel inside the app. The tunnel entry is still listed after confirming the deletion.
Smartphone (please complete the following information):

Device: Chromecast with GoogleTV
Android Version: Android 12
App Version 3.3.5

To Reproduce
Steps to reproduce the behavior:

Go to tunnel
Click on the delete icon
Confirm deletion

I also just noticed Github has a 3.3.8 release but the Google Play Store is still on the 3.3.5 release a month later. Maybe this bug was picked up already? I can not confirm.

Hello! I'll look into this and see if it is resolved on a later version. If not, I'll fix it for the next release. Google has been making me jump through hoops and is not allowing me to release a new version. I am hoping this next release resolves the remaining items for the play store.

You can sideload the latest release from here or use F-Droid app store to get the latest. I've been using F-Droid to keep WG Tunnel updated. If you switch to F-Droid you may have to re-install. Just export your config and then import afterwards.
https://github.com/zaneschepke/wgtunnel/releases/tag/3.3.8

This was an issue 3.3.8 as well. I found the issue and it will be fixed in 3.3.9.

Closed with 3.3.9


UI - Enhance log details

Feature request
I as a user / developer would like to be in the position seeing in the Web-UI log

which logline belogs to which instance
the timestamp in my local time
plus I would like to be able to filter loglines for
instance, e.g. "My Hue Instance"
component, e.g. LEDDEVICE
log-level

which will help me in understanding what happens in hyperion, as well we track down error situations.
In case there is only one instance running, the instance information might be suppressed.
What problem does this feature solve?
see above.
What does the proposed API look like?
N/A
How should this be implemented in your opinion?
Mocku-up for illustration

This change request is linked to issue #910
Are you willing to work on this yourself?

Partially covered.
Closing for now.


Changes for issue #48 - to make ValidateSet work with string[]

This change is

Hi @johlju, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

Hi @johlju! Please add your change to the 'Unreleased' section of the README per the contributing guidelines

I have added the change to the 'Unreleased' section of the README. Missed that one.

Comments from Reviewable

a discussion (no related file):
I have added the change to the 'Unreleased' section of the README.

Comments from Reviewable

Reviewed 1 of 1 files at r1, 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

Comments from Reviewable


explicit channel auth scheme

closes #155
TODO

[ ] Once agreed on, update examples in all the channel types

Preview | Diff (doesn't show the changes in code snippets!)

I would suggest that you add an implementation guidance box, otherwise spec users will wonder why we are adding channel auth in the examples even though it has no mention in the spec.

That should be "zero, one or many" (I disagree with @csarvens way of describing, we have argued this previously, because there is no way to indicate that Subscription Service may not advertise this property at all and that would be OK). I would also suggest the property on Subscription Service be called authSchemes instead of channelAuthScheme for consistency with Notification Channels.

I would also suggest the property on Subscription Service be called authSchemes instead of channelAuthScheme for consistency with Notification Channels.

I think chanelAuthScheme is consistent with channelType, also having two different predicates only differ by final s could be confusing.

That should be "zero, one, or many"

If we want it always to be explicit it can't be zero, one of the examples uses None. In what scenarios would you see zero?

I think chanelAuthScheme is consistent with channelType, also having two different predicates only differ by final s could be confusing.

Plural indicates that a thing is an array. Not having an "s" is the inconsistent thing, imho.
I strongly disagree with your definition of consistency. AuthSchemes are only meaningful in the context of the channel, but is a general thing. channelType is called so because type is vague thing even when described in the context of a channel (and can be confused with other kinds of "types" like "data type") and that we explicitly define a "Channel Type" in the spec.

If we want it always to be explicit it can't be zero, one of the examples uses None. In what scenarios would you see zero?

You could conceivably have a channel that you need to subscribe to (one a server will create on request only), but is otherwise public and does not require authorization (not that I would recommend anyone make one, but consistency demands that we allow such a thing).
What I would concede is that if you specify the property, then zero entries makes no sense. But you should be able to skip specifying channelAuthScheme altogether in the above scenario.

I think requiring channelAuthScheme with at least one value encourages (more) complete and useful information. Just as specifying the type of the channel, its endpoint, features. Why wouldn't authentication scheme information be part of this? The only thing I can think of is that it is unknown (unprovided) to the DescriptionResource and that the values may change (for some reason).
As for singular/plural, singular suffices for RDF properties as atomic statements / arcs in graph.


Optional patterns returns a String with "undefined" as value when this pattern isn't set

This is a weird bug. When I npm install<EMAIL_ADDRESS>an optional pattern is returned as an String instead of not returning param at all. I think that this is a bundle bug, because I've cloned and npm linked RR4, built the files and it works proper.
Version
4.0.0-apha.5
Test Case
http://jsbin.com/toroxe/1/edit?html,js,console,output
Steps to reproduce
Create a Route with optional params. Ex.: <Match pattern="/param1/:param2?" component={Catalog} />, and access the /param1 route
Expected Behavior
Return just param1 as route parameter
Actual Behavior
param2 value is a String with undefined as content

This was fixed in #4064. However, that version isn't yet released on npm. You'll have to install and build locally until we can get that released.

We did a workaround to ignore those routes. Thx for the response


[Feature Request] Blacklist Item Filter/Advance Item Filter

Currently, the pneumatic tube filters have a hard time handling items with a lot of nbt variants. (i.e.  golden sword from a gold farm)
As such, I think we need either a blacklist (to specific insert all drops that are not suppose to be routed to other places) or advance filter that allows for specifying exact NBT match or otherwise.

I'm not sure how to distinguish between a datapack item that should always have nbt enabled (and in some cases specific nbt), vs normal items.


Support for checkra1n 0.12.0 beta

checkra1n has been updated to support iOS 14.1 and 14.2
Not sure you can update the checkra1n file in the zip with the arm64 one from their site though so would like some advice regarding that though.

0.12.0 support has already been added 👍
0.12.0 APK https://github.com/downthecrop/checkra1n-twrp/raw/master/app/release/app-release.apk
0.12.0 beta zips https://github.com/downthecrop/checkra1n-twrp/releases/tag/0.12.0


Can we talk about naming?

Why is it that the main install function is named Invoke-PSDepend instead of Install-BuildDependencies or something appropriate like that?

It's not really installing IMO... but I feel like Restore would fit well.
Naming is hard.

I guess I'm pretty confused about who and what you would use this for apart from build-time. Especially when you say it's not really installing.
What are you using it for?

Borrowed a lot from PSDeploy, thus, Invoke-PSDeploy became Invoke-PSDepend (couldn't come up with a reason to change it back then).
A few things I've used it for:

Dependencies for spot-solutions that might require packages, files from the web, repos, files from the file system, etc.
Above... along with option to save these to a .requirements folder, and add that to path/psmodulepath, etc.
Simplify instructions for co-workers - run invoke-psdepend, vs. you need XYZ various things from various sources, and the various questions that came with it
When working on a module, a quick way to pull in dependencies for a project I haven't published yet (probably not efficient to keep in line with the RequiredModules, but, it works)

For the most part, yeah, the end result is an install, but Invoke-PSDepend has some other things built in:

It has a super janky idea of letting dependency types handle install, test, and import as appropriate, each of which have a Install-Dependency esque command
By default it will look for and invoke files it finds matching '\.depend\.psd1$|.*requirements.psd1$'
Allows specifying arbitrary InputObject hashtables that equate to the content of a psd1
Allows filtering for specific tags
Allows specifying different actions, e.g. -Install, -Test, -Import
Allows overriding the Target for all dependencies (e.g. I might include a sane default in my dependency file, that others could override at runtime)

Basically... it's a convenient way to invoke psdepend : P
Cheers!

Invoke-PSDepend is very similar to how you execute other similar modules e.g., psake: Invoke-Psake, pester: Invoke-Pester, etc.

That doesn't make "invoke" a good verb. In fact, of these tools are doing it wrong, because they are all following Pester's anti-pattern approach to naming. Remember, Pester is the module that couldn't be bothered to follow verb-noun, and introduced Ruby-like syntax to PowerShell.
Invoke-PSDepend is only a good name if "Depend" is the name of a command or method.
Having said that, a year ago, I cared. Now, I don't. It's been badly named all this time, and nobody else cares (and I decided not to use it) so it doesn't matter.


[Profiler] No captured body (Symfony Client)

PHP version: 8.1.9
Description
I'm trying to communicate with an API that returns XML responses and I'm noticing that the Profiler doesn't contain the response or the request body (even though it's there).
How to reproduce
I have my client configured this way:
        client_name:
            factory: 'httplug.factory.symfony'
            http_methods_client: true
            plugins:
                - 'httplug.plugin.content_length'
                - 'httplug.plugin.redirect'
                - add_host:
                     host: 'https://endpoint.com'
                - header_defaults:
                      headers:
                          "Content-Type": 'application/xml'
                          "Accept": 'application/xml'

But I noticed it also seems to happen if you just do http_methods_client: true without any other config.
Possible Solution
No Clue something's not capturing the response right I'd wager.
Additional context

Here's a screentshot with an example request to a search engine:

Symfony version is 6.1.3

Ok update, turns out it's because the captured_body_length is 0 by default.
I'd suggest to either increase that or make a hint next to the (This message has no captured body) string.
Something like (This message has no captured body, this is either due to no available content or because the captured_body_length is set to 0)

thank you @KDederichs  for bringing up the suggestion. i was aware of the reason why you get "no captured body" but its much better if the message is self-explanatory.

👍
Thanks for adding it so quickly!


The proper way to extend UserManager

Assume I want to write a library that extends identity model with a new object called Organization.  It can look like this
public class Organization
{
    public string Id { get; set; }
    public string Name { get; set; }
    public string Address { get; set; }

    // Some other properties
}

A user can be a member of many organization.
The next step is to extend UserManager with some methods
AddUserToOrganizationAsync
RemoveUserFromOrganizationAsync
GetUserOrganizationsAsync

My question is: what is the proper way to implement these methods?

Should I invent a new class UserOgranizationInfo (analogue of UserLoginInfo)?

So the methods will look like
public class UserOgranizationInfo
{
    public string Id { get; set; }
    public string Name { get; set; }
}

public class MyUserManager<TUser> : UserManager<TUser> where TUser : class
{
    public Task AddUserToOrganizationAsync(TUser user, UserOrganizationInfo org);
    public Task RemoveUserFromOrganizationAsync(TUser user, UserOrganizationInfo org);
    public Task<IEnumerable<UserOrganazationInfo>>GetUserOrganizationsAsync(TUser user);
}

Or is it normal to use my entity type here?

So my UserManager will look like
public MyUserManager<TUser, TOrganization> : UserManager<TUser>
    where TUser : class, TOrganization : class
{
     // Other code

    public Task AddUserToOrganizationAsync(TUser user, TOrganization org);
    public Task RemoveUserFromOrganizationAsync(TUser user, TOrganization org);
    public Task<IEnumerable<TOrganazation>>GetUserOrganizationsAsync(TUser user);

    // Other code
}

Or even more simpler
public MyUserManager: UserManager<IdentityUser>
{
     // Other code

    public Task AddUserToOrganizationAsync(IdentityUseruser, Organization org);
    public Task RemoveUserFromOrganizationAsync(IdentityUseruser, Organization org);
    public Task<IEnumerable<Organazation>>GetUserOrganizationsAsync(IdentityUser user);

    // Other code
}

I think that the only purpose for the first case (with UserOrganizationInfo) is to support store that doesn't support Organizations at all. In this case it will be quite inconvenient to add dependency on Organization.
But if I know that my stores and my UserManager will always support Organizations the second way is ok, is it? Because the second way is much more convenient: we can get full organization info directly from the UserManager rather than from additional OrganizationManager class.
Am I right?

So the main guiding factor is whether you are building something more like a library for reuse in different situations, or if this is specific to your app.  If you don't envision reusing this for other organization types in the future, you don't need the extra generic complexity...
There's no clear right or wrong choice between your options, the tradeoffs are between extra work/complexity for some extensibility...

Thank you! I got it.


ng build AOT + lazy loading from different package

Bug Report or Feature Request (mark with an x)
- [x ] bug report -> please search issues before submitting
- [x ] feature request

Versions.

Windows 7 and MacOS
$ ng --version
@angular/cli: 1.0.0
node: 7.7.2
os: win32 x64
@angular/common: 4.0.2
@angular/compiler: 4.0.2
@angular/core: 4.0.2
@angular/forms: 4.0.2
@angular/http: 4.0.2
@angular/platform-browser: 4.0.2
@angular/platform-browser-dynamic: 4.0.2
@angular/router: 4.0.2
@angular/cli: 1.0.0
@angular/compiler-cli: 4.0.2
Repro steps.

Stack Overflow Question:
http://stackoverflow.com/questions/43441732/angular-2-error-when-ng-build-aot-lazy-loading-from-different-package
Sample Repo:
https://github.com/chorew/AngularSample
Running the app

clone the repo
npm install
npm run dev:library

const routes: Routes = [
{ path: 'library', loadChildren: '@myapp/library/src/index#ModuleAModule' } // lazy loading a module from a different package
];
The log given by the failure.

<EMAIL_ADDRESS>build C:\Users\Juan.Pablo\projects\POC\AngularSample\packages\main.app
> ng build --aot

Hash: dfaf89ef3b1bb2e81c75
Time: 6307ms
chunk    {0} polyfills.bundle.js, polyfills.bundle.js.map (polyfills) 158 kB {4} [initial] [rendered]
chunk    {1} main.bundle.js, main.bundle.js.map (main) 28.3 kB {3} [initial] [rendered]
chunk    {2} styles.bundle.js, styles.bundle.js.map (styles) 9.77 kB {4} [initial] [rendered]
chunk    {3} vendor.bundle.js, vendor.bundle.js.map (vendor) 1.37 MB [initial] [rendered]
chunk    {4} inline.bundle.js, inline.bundle.js.map (inline) 0 bytes [entry] [rendered]

ERROR in ./src/$$_gendir async
Module not found: Error: Can't resolve 'C:\Users\Juan.Pablo\projects\POC\AngularSample\packages\main.app\src\node_modules\@myapp\library\src\index.
d.ngfactory.ts' in 'C:\Users\Juan.Pablo\projects\POC\AngularSample\packages\main.app\src\$$_gendir'
 @ ./src/$$_gendir async
 @ ./~/<EMAIL_ADDRESS> @ ./src/main.ts
 @ multi ./src/main.ts

Notice how it is trying to find the lazy loaded module inside the main.app\src folder
App src path
C:\Users\Juan.Pablo\projects\POC\AngularSample\packages\main.app\src\
Lazy loaded from package
@myapp\library\src\index.d.ngfactory.ts

### Desired functionality.
<!--
What would like to see implemented?
What is the usecase?
-->

This is a sample app with 2 sub-packages.

packages/main.app
packages/library
the goal is to have a library package with different modules of the app
and have some specific modules lazy loaded.

The use case is to be able to load modules from different packages/repos developed by different teams and pull just the needed packages from npm to configure the routes.

const routes: Routes = [
  { path: 'library', loadChildren: '@myapp/library/src/index#ModuleAModule' }, // developed by Team A
  { path: 'anotherLibrary', loadChildren: '@myapp/anotherLibrary/src/index#ModuleAModule' } // developed by Team B
];

and so on.

### Mention any other details that might be useful.
<!-- Please include a link to the repo if this is related to an OSS project. -->

Main.app was generated with ng cli
Library package is custom project using ngc and gulp

@chorew i have same issue, with regular lazy loading.
angular-cli: v1.0
angular ver: 4.0.1

Same issue here. Lazy loading to a library packages works fine with JIT, not with AOT.

@hansl is this a bug or is there no support by design?

BTW this is still the case with CLI 1.0.4.

BTW this is still the case with CLI 1.0.6

BTW this is still the case with CLI 1.1.1

BTW this is still the case with "@ngtools/webpack": "^1.5.0"

@filipesilva is this not supported by design?
would you please clarify it? there is few question related to this topic in StackOverflow without an answer and it is confusing.

Hey guys, I had a similar issue and fixed it by upgrading angular version in package.json to 4.3.2. There was an angular issue similar to this and was solved. This worked for me, try it out.

@hansl can you chime in?

Hi everyone,
After some investigation and help from our compiler team, I was able to make progress to the point where it was working (see https://github.com/jpguevara/AngularSample/pull/2). The last issue was that the library needs to be published with Angular as a peer dependency. By modifying the node_modules manually I was able to make ng build --aot work.
So everything can be fixed by the library side, and using the library name instead of pointing to the index file directly. It does not even require the latest version of the CLI.
Closing this issue as working-as-intended.

Hi @hansl,
Thank you so much for some investigation in this problem.
If i use @angular/cli and do not eject the webpack config do i still have the possibility to change somewhere the behavior like you done in the sample app?


Bad URL in Tenable.io content solution manifest and package (documentation)

Describe the bug
The Tenable.io Solution for Microsoft Sentinel's template has a bad URL in the documentation. The bad URL is:

https://docs.tenable.com/tenableio/vulnerabilitymanagement/Content/Settings/GenerateAPIKey.htm

The correct URL is:

https://docs.tenable.com/tenableio/Content/Platform/Settings/MyAccount/GenerateAPIKey.htm

Please correct this in the package manifest and all relevant documentation. This apples to the Microsoft Sentinel Content Hub as well.
To Reproduce
Navigate to the URLs documented in the description, and observe the 404 error versus the appropriate data.
Expected behavior
URL's should be correct.
Screenshots
You shouldn't need screenshots, ;)
Desktop (please complete the following information):
Smartphone (please complete the following information):
These are not relevant, a bad URL is universally inaccessible on all platforms and permutations.

Closing the issue since the URL if fixed in PR and PR is merged.


Make HitBTC client order id main id, since this id is used by the API.

HitBTC uses the client order id for all API request. Therefore, after requesting an order it was impossible to do any other API requests with it, since not the client order id but the exchange id was returned. I updated the API such that now the id of an order can actually be used in the API requests that require an order id.

Instead of replacing the old code like this:

why don't you just add an else with your fix?

That would indeed work, but IMO is not a very nice solution. Because that means that everyone who uses the HitBTC API must use such a check. For example, I wrote the following code (and assumed it would work until I tested it on HitBTC):
trade_service.cancelOrder(order.getId())

You propose that I use the following code.
trade_service.cancelOrder(order instanceof HitbtcLimitOrder ? ((HitbtcLimitOrder)order).getClientOrderId() : order.getId())

Well this works, but it already looks very cluttered and I'm not supporting many exchanges yet. But if for every exchange that I want to support I have to change my code with an additional case, my code becomes quite unreadable.

I don't understand. You can cancel a Hitbtc order, just pass the clientOrderId though.

I recall a while ago we discussed making clientOrderId a top level concept in this library but the idea was very unpopular and the PR was rejected.  The compromise was to have bespoke order object for hitbtc that contained the extra field.  Take a look at HitbtcLimitOrder for example, it contains a cleintOrderId which you can use to pass through to methods like 'cancelOrder(...)

You can't put it in the HitbtcTradeServiceRaw, because the API as specified in TradeService is cancelOrder(String orderId). So, if you'd pass order.getId() into this method, it has no way of acquiring the client order id.
IMO, it would be logical if order.getId() returns the id that is used by the API (I don't care how the service calls it, e.g. even if they call it the clientId, I'd say it's the main id.)
An other option would be to add an additional method to TradeService: cancelOrder(LimitOrder order). In this case, the casting could be performed inside the trade service, but that would require changing the core API.

@npomfret If you consider that the best idea, I'll try to make a PR for that fix instead of this one.

You can't put it in the HitbtcTradeServiceRaw, because the API as specified in TradeService is cancelOrder(String orderId). So, if you'd pass order.getId() into this method, it has no way of acquiring the client order id

Can't you use cancelOrder(CancelOrderParams orderParams) instead?


JAMES-2656 - Add initial JPAMailRepository implementation

Here is an initial implementation of a JPAMailStore, which will hopefully suffice to make the JPA app work fully with a database, a big relief for everyone that migrated from 2.3.x and was shocked to discover they are forced to use file repositories ;-)
This is an initial implementation that is hopefully good enough to be useful, but still has room for improvement. After merging others can help incrementally improve on it as necessary. Specifically:

It passes MailRepositoryContract as suggested in JAMES-2656, except for two disabled tests (which are both also disabled in JDBCMailRepository, so it's no worse than that):

mailRepositoriesShouldBeURLIsolated seems to fail only because the mock Mail has no lastUpdated and state fields set - I'm not sure if these fields are supposed to be set and this is just a bug in the test object itself, or if it's a valid scenario that should be handled (allow nulls in these fields). I currently included also the fix for the test, but awaiting feedback on what the proper solution should be. When adding the two fields in the test, it passes.
shouldPreserveDsnParameters fails due to the same issue as with jdbc - because the attributes are not Java-serializeable. See below.

Future improvements:

The body is currently defined as a byte array, i.e. is held in memory. JPA supports streaming for a handful of databases. I suppose for those we can do something like what was done for JPAMailboxMessage/JPAStreamingMailboxMessage - have two subclasses, one with byte array and one with stream, and somehow configure which to use (I didn't see where that is configured).
The perRecipientHeaders field is currently Java-serialized into a byte array. I saw some other places migrated to using a string delimited by newlines, so that can be done here as well, but seems bad to re-implement it in every component... should be some main utility somewhere that does this in a standardised way, and all components including this one can just use it as a one-liner.
The message attributes are currently Java-serialized into a byte array. The Mail interface requires attribute values to be serializeable, but apparently James violated this contract when using DSN parameters, which is why the corresponding test fails. This should probably be fixed in the DSN implementation, since it violates the contract. In any case, I saw some other component moved to json serialization for the attributes, so maybe we can get that to work here as well (I gave it a shot but ran into issues so dropped it for now). Here too, better to have a centralized utility that takes care of everything instead of re-implementing in every component.
There are resource leak warnings in the console when running the tests. Not sure where they come from, though I see them also when running tests for other repository types, so I don't know if this is really an issue or a false alarm, or how important or not it is at this point.
It would have been nice to have a separate table per repository, but as far as I can tell, JPA doesn't support dynamic table names that way, so all the repos are in one table, with a column (indexed) specifying the repo name. No biggie.
I haven't worked with Guice or JPA before, so maybe I missed something. Would be great if someone in the know can give it a review to see if everything is configured and used correctly.
There may be room for other performance improvements if needed.
In addition to the contract tests, I ran a few manual tests, and it seems ok. Would be great if someone has a more realistic scenario or production server to run it on as a fuzz test to cover edge cases, concurrency, load, etc.

To summarise, although I detailed my thoughts and dilemmas regarding the implementation, the bottom line is that it's probably good enough for most scenarios and a good starting point for future contributions. It's the big first step that nobody took in a few years, and hopefully once merged it will be easier for other devs and users to improve upon.
Your thoughts?

One more thing - is there a tool and/or simple mailet configuration that migrates between different mail repository implementations? It would be useful to clearly document this and/or create a dedicated tool to ease migrations for existing users.

Here is an initial implementation of a JPAMailStore, which will hopefully suffice to make the JPA app work fully with a database, a big relief for everyone that migrated from 2.3.x and was shocked to discover they are forced to use file repositories ;-)

Thanks for tackling the issue!

The perRecipientHeaders field is currently Java-serialized into a byte array. I saw some other places migrated to using a string delimited by newlines, so that can be done here as well, but seems bad to re-implement it in every component... should be some main utility somewhere that does this in a standardised way, and all components including this one can just use it as a one-liner.

I would support such a refactoring :+1:

shouldPreserveDsnParameters fails due to the same issue as with jdbc - because the attributes are not Java-serializeable. See below.

mailet-api comes with a serialization utility. See what other implementations are doing:
https://github.com/apache/james-project/blob/8ba9871f61a0caa421061f7a8362354c758c8c8b/server/mailrepository/mailrepository-cassandra/src/main/java/org/apache/james/mailrepository/cassandra/CassandraMailRepositoryMailDaoV2.java#L278
TLDR: attributes now come with a handy toJson method.
Java serialization is hasardous and deserialization glitches can be exploited EG for arbitrary code execution. As a project we spent considerable amount of time and energy migrating away from java serialization.
As such I would prefer newly contributed code to stay clear from this pitfall.

There are resource leak warnings in the console when running the tests.

Harmless: mails created in tests are not well managed thus creating the warnings. We are decreasing the level of leak detection to avoid "spam". CF https://github.com/apache/james-project/pull/1170

Would be great if someone in the know can give it a review to see if everything is configured and used correctly.

That is my plan!

One more thing - is there a tool and/or simple mailet configuration that migrates between different mail repository implementations? It would be useful to clearly document this and/or create a dedicated tool to ease migrations for existing users.

Achievable via webadmin endpoint to reprocess emails. Reprocess eails from repo A into a mail processor that stores things in repoB. Feel free to experiment and document the process.
Best regards,
Benoit TELLIER

Thanks for the in-depth review and super-quick responses! It's really appreciated!
I think everything was addressed, the only thing remaining is the attributes serialization. I'm not sure what you were referring to in "mailet-api comes with a serialization utility", and the example in CassandraMailRepositoryMailDaoV2 seems to do some of its own serializing/deserializing, and there is another class with a modified copy&paste version of it as well. But both only take it as far as a Map, and that too needs to be serialized to the database somehow... as I mentioned initially, the serializations policy seems a bit patchy rather than a cohesive design and reusable implementation. I was hoping for something as simple as SerializationUtils.serialize just with strings :-)
What do you recommend to do at the moment with the JPA attributes?
(btw the serialization changes I didn't backport to jdbc repository so it won't break backwards compatibility with existing databases)

(btw the serialization changes I didn't backport to jdbc repository so it won't break backwards compatibility with existing databases)

Yes that's perfect we should avoid breaking changes.
I'll have a look somewhere this week at the attribute stuff.
Regards,
Benoit

ok, so just waiting for @chibenwa's answer regarding the attributes serialization. Anything else u need me to do?

ok, so just waiting for @chibenwa's answer regarding the attributes serialization. Anything else u need me to do?

The serialization seems the last piece of the puzzle so except for that, I think we are good :)

ok, so just waiting for @chibenwa's answer regarding the attributes serialization. Anything else u need me to do?

Yes I definitly put this high on the afternoon todo list!

Here is a little commit for JSON serialisation of mail attributes so that we get rid of Java serialisation.

oh thanks!
I thought we're going for a more generalized serialization solution rather than have this component implement the serialization on its own like other components do... but I suppose as long as the db format stays fixed it can be refactored later. Better ship it now than wait for a redesign :-)
Although, if we're doing it this way, might as well also replace the recipients headers serialization I made with JSON, no need to have two different serialization schemes here. I'll try to do it tomorrow, if you concur.

I added a couple of optimizations in a separate commit (removeAll direct query and json fields not lazy), then CI build failed for unrelated reasons (cassandra something), then rebased on current master.

Can I ask you to rebase one more time and put the JIRA in the commit messages as a prefix?
JAMES-2656 My message...
Also https://ci-builds.apache.org/job/james/job/ApacheJames/job/PR-1176/9/testReport/junit/org.apache.james.mailrepository.jpa/JPAMailRepositoryTest/storingAndRemovingMessagesConcurrentlyShouldLeadToConsistentResult_3_/
org.apache.james.mailrepository.jpa.JPAMailRepositoryTest.storingAndRemovingMessagesConcurrentlyShouldLeadToConsistentResult[3]

java.lang.RuntimeException: com.github.fge.lambdas.ThrownByLambdaException: javax.mail.MessagingException: Exception while removing message(s): Unable to obtain an object lock on "DELETE FROM APP.JAMES_MAIL_STORE WHERE EXISTS (SELECT 1 FROM APP.JAMES_MAIL_STORE t0 WHERE (t0.REPOSITORY_NAME = ? AND t0.MESSAGE_NAME IN (?)) AND (t0.MESSAGE_NAME = APP.JAMES_MAIL_STORE.MESSAGE_NAME AND t0.REPOSITORY_NAME = APP.JAMES_MAIL_STORE.REPOSITORY_NAME)) [java.lang.String]".;
  nested exception is:
 <openjpa-3.2.0-r6f721f6 nonfatal store error> org.apache.openjpa.persistence.OptimisticLockException: Unable to obtain an object lock on "DELETE FROM APP.JAMES_MAIL_STORE WHERE EXISTS (SELECT 1 FROM APP.JAMES_MAIL_STORE t0 WHERE (t0.REPOSITORY_NAME = ? AND t0.MESSAGE_NAME IN (?)) AND (t0.MESSAGE_NAME = APP.JAMES_MAIL_STORE.MESSAGE_NAME AND t0.REPOSITORY_NAME = APP.JAMES_MAIL_STORE.REPOSITORY_NAME)) [java.lang.String]".
FailedObject: DELETE FROM APP.JAMES_MAIL_STORE WHERE EXISTS (SELECT 1 FROM APP.JAMES_MAIL_STORE t0 WHERE (t0.REPOSITORY_NAME = ? AND t0.MESSAGE_NAME IN (?)) AND (t0.MESSAGE_NAME = APP.JAMES_MAIL_STORE.MESSAGE_NAME AND t0.REPOSITORY_NAME = APP.JAMES_MAIL_STORE.REPOSITORY_NAME)) [java.lang.String]

To my understanding the test is too violent... Maybe we could @Disable it for now?

Rebased again. I'm not sure what you mean about the prefix - I added it to the initial commit of the jpa repository implementation, do you want it on all the commits? or to squash all the related commits into one with this prefix? (excluding the commits with cleanup of other classes)

Ooops.... I was about to sqash but I see it's already merged :-)
btw is there an ETA for this release?
Regarding that log, I'm not convinced the problem is with the test, maybe it's a real concurrency bug. Requires some delving into locking in JPA and/or Derby. If there's someone experienced with this, it would be nice if they can have a look. Some wild guesses: maybe another index will help narrow the lock to specific rows, maybe add a specific remove-one query instead of the 'in' clause (but the issue will remain with collections, so not a full solution), maybe add a lock mode parameter to queries... need to figure it out. The biggest issue is that I can't reproduce it locally, so hard to investigate or test solutions.

oh it's all squashed into one, I intended to do the jpamailrepository separately in one commit and the file/jdbc/jpaurl cleanup in separate commits as they are. Too late I suppose.

btw is there an ETA for this release?

The main issue that remains to be fixed is IMO https://github.com/apache/james-project/pull/1185
Once merged I'd like to go for 1-2 weeks on internal production plateform and fully feel confident for a 3.8.0 release.
So ETA ~1month. Is this OK to you?

Sure, sounds like a good plan. Would be great to let it run in production for a bit.

Were there any issues found with this implementation? Is it ready for release?

Is there an ETA on the release that includes the JPAMailRepository?

When can we expect this to be released in any new or backported version?


Error ketika Host di Vercel

added 444 packages in 14s
80 packages are looking for funding
run npm fund for details

<EMAIL_ADDRESS>prepare
husky install
husky - Git hooks installed
<EMAIL_ADDRESS>build
tsc
Error: No Output Directory named "public" found after the Build completed. You can configure the Output Directory in your Project Settings.
Learn More: https://vercel.link/missing-public-directory

Vercel is the Frontend Cloud. Coba pakai host lain seperti Cyclic.sh atau vps.


A variable null pointer appears when running concurrently

It won't do this without adding the restriction code,I don't know why this happens, hope you can tell me why, thanks

Please post some code that we can run, not partially blurred screenshots. You didn't even provide the error message pointing to where the nil pointer appears.
I will reopen if you give me more info, and the issue is actually valid.


sgx_nfd: update to node-feature-discovery v0.7.0

rebased+force pushed

Codecov Report

Merging #522 (97d88e7) into master (b737fc9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #522   +/-   ##
=======================================
  Coverage   56.60%   56.60%
=======================================
  Files          31       31
  Lines        2097     2097
=======================================
  Hits         1187     1187
  Misses        838      838
  Partials       72       72

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b737fc9...97d88e7. Read the comment docs.


[FLINK-17635][docs][table sql / api] Add documentation about view support

What is the purpose of the change

We support Create/Drop/DESCRIBE view in 1.11. this pull request Add documentation about view support.

Brief change log

Add Create/Drop/DESCRIBE view section in SQL documentation
Translate corresponding Chinese documentation

Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): ( no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

I think it's better we can explain more about the behavior of dependencies maintaining, such as: does drop a table operation affect a existing view ? (see https://cwiki.apache.org/confluence/display/FLINK/FLIP-71%3A+E2E+View+support+in+FLINK+SQL)


Style for activated links

Is it possible to add style for activated links in the menu ?

Fixed, you can now use class .isAtive on


No F1 menu

Partially related to #6. There should be a menu that would allow the player to interact with the game mode, in terms of both customizing the character and accessing the variables.
The proposed tab layout is:

[x] Colors
[ ] Hat
[ ] Skin
[ ] Pets (highly unlikely)
[x] Game Settings (cvars, etc.)
[x] Credits

Some of the mentioned tabs have been implemented in https://github.com/NotMyWing/GarrysModAmongUs/commit/bb3f1c4825dcd2740bcd10a1d1942336e713c792.


Added support for Override/AppendUserAgent in iOS, matching cordova-i…

…os implementation

Does have the same issues as https://github.com/apache/cordova-plugin-inappbrowser/pull/94

I merged this into my own fork, for those who are interested. See https://github.com/initialxy/cordova-plugin-themeablebrowser/issues/193 For details


Add CLOCK_REALTIME to Posix

These patches add the CLOCK_REALTIME to the posix clock API. It uses the monotonic clock, but keeps an offset, which will be set with clock_settime().
Fixes #7764

Codecov Report

Merging #8652 into master will increase coverage by 0.01%.
The diff coverage is 80.64%.

@@            Coverage Diff             @@
##           master    #8652      +/-   ##
==========================================
+ Coverage   64.29%   64.31%   +0.01%
==========================================
  Files         440      440
  Lines       42093    42154      +61
  Branches     7046     7052       +6
==========================================
+ Hits        27065    27110      +45
- Misses      11828    11840      +12
- Partials     3200     3204       +4

Impacted Files
Coverage Δ

include/posix/time.h
100% <ø> (ø)
:arrow_up:

tests/posix/clock/src/main.c
91.66% <100%> (+15.19%)
:arrow_up:

lib/posix/clock.c
63.15% <61.29%> (-36.85%)
:arrow_down:

tests/posix/posix_checks/src/main.c
86.95% <0%> (-2.9%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9127c4b...4579327. Read the comment docs.

Are these changes ok with you @andyross ?

Test is fine, but the negative test in posix_checks would start failing (which tests for an unsupported clock). You could change the CLOCK_REALTIME there to something else then.

Are you referring to the check_timer_support checks? I see that this would change what is printed. Is there somewhere I'm not finding that checks what is printed?

@d3zd3z Hi, yep, the same check_timer_support. I believe this is the only place you'd need to change the value of POSIX_REALTIME, to another clock that is unsupported, to satisfy the negative test.

@nniranjhana It seems that everything is passing, so there doesn't appear to be anything that checks for this negative test. But, we now implement all of the clocks defined in include/posix/time.h. Are you suggesting we add another clock here just to test that it works with an invalid clock? Doesn't this kind of go against the Zephyr guideline of calls not checking for invalid arguments?

Yeah, not understanding the complaint.  If a test is failing because it requires that POSIX_REALTIME be unimplemented, then that's a bug in the test.  Though as @d3zd3z points out, no ztest assertions exist to fail, nor are there regexes in the sanitycheck yaml that are looking for what is printed.  @nniranjhana, what test exactly is failing?

@andyross @d3zd3z Yes, there's nothing wrong with this test, I was talking about the posix_checks test in tests/posix, but as you've pointed out, I will change that test. It does not require that POSIX_REALTIME be unimplemented, but was testing for an unsupported clock for code coverage purposes.


"The following file already exists" when extracting on windows

THe question is: Are the instructions only been tested on linux systems?
I downloaded armv6-rpi-linux-gnueabihf on windows 11, and trying to inzip it with winrar I get the error that the filt aleady exists. This must be a issue with the unzip process I believe.

The "double" files it sees are for example in x-tools\armv6-rpi-linux-gnueabihf\armv6-rpi-linux-gnueabihf\sysroot\usr\include\linux\netfilter  , the files that are named with Capital and non-capital letters for example xt_connmark.h and xt_CONNMARK.h, windows thinks the name is the same...
Then I tried using wget  on windows but I would rather not do it that way since windows's wget.exe command is not a PowerShell 'wget' command and it usually never works as intended:
PS C:\Users\basil\opt> ls
PS C:\Users\basil\opt> wget -O- https://github.com/tttapa/docker-arm-cross-toolchain/releases/latest/download/x-tools-armv6-rpi-linux-gnueabihf.tar.xz | tar xJ -C ~/opt
Invoke-WebRequest : A parameter cannot be found that matches parameter name 'O-'.
At line:1 char:6
+ wget -O- https://github.com/tttapa/docker-arm-cross-toolchain/release ...
+      ~~~
    + CategoryInfo          : InvalidArgument: (:) [Invoke-WebRequest], ParameterBindingException
    + FullyQualifiedErrorId : NamedParameterNotFound,Microsoft.PowerShell.Commands.InvokeWebRequestCommand

PS C:\Users\basil\opt> wget https://github.com/tttapa/docker-arm-cross-toolchain/releases/latest/download/x-tools-armv6-rpi-linux-gnueabihf.tar.xz | tar xJ -C ~/opt
tar.exe: Error opening archive: Failed to open '\\.\tape0'
PS C:\Users\basil\opt>

Managed to solve it.
I can unzip the file if I first make a empty folder and make its contents case sensitive as described here: https://stackoverflow.com/a/60448790/13294095

Are the instructions only been tested on linux systems?

Indeed, for the simple reason that the cross-compilers run on Linux and target Linux :)
IMHO, it is not worth it to set up a Linux cross-compilation environment on Windows. If for whatever reason you have to use Windows, you're much better off using WSL or Docker.


Allow caliptra-rtl merge commits / non-linear history

This is necessary to support retaining full commit history (and bidirectional merges) between the dev-msft and dev-google, and main branches.

Ugh, sorry, I fixed a typo right after you approved...
On Mon, Mar 27, 2023 at 11:47 AM Andres Lagar-Cavilla <
@.***> wrote:

@.**** approved this pull request.
—
Reply to this email directly, view it on GitHub
https://github.com/chipsalliance/Caliptra/pull/34#pullrequestreview-1359685683,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAHSUPWBH3WFC35GCOOPV6TW6HOC5ANCNFSM6AAAAAAWJQQHQE
.
You are receiving this because you authored the thread.Message ID:
@.***>

Kor might want to rebase now (camel case rename)


Upgrade lager

I have an issue when try to compile bec with my brand new profile on my laptop. with the following error.
src/bitbucket_http.erl:none: error in parse transform 'lager_transform'
However, after bumping up lager version, I could build bec again so I decide to create this PR.
I'm running this with OTP 24 (24.0.4)

Thanks! Sorry about the huuuuuuge wait.


Broken link in documentation

Describe the bug
Broken link in documentation for metadata ingestion
To Reproduce
Steps to reproduce the behavior:

Go to https://github.com/datahub-project/datahub/blob/master/metadata-ingestion/README.md
Click on example links - eg. https://github.com/datahub-project/datahub/blob/master/docs/generated/ingestion/sources/bigquery.md

Leads to 404

I tried also different branches
Expected behavior
Reach requested doc.
Context
I am looking to create a custom ingestion for datahub, i want to see an example of one written and working. For example BigQuery.
Any other links that can help will be much appriciated.

@thewizkid87 - thanks so much for calling this out! I just created a PR to fix those links: https://github.com/datahub-project/datahub/pull/7183
Once that gets merged and we confirm the links are looking good I'll close this PR

@chriscollins3456
Thank you :-) Will look in the commit

closing!


The input text is white

Description
The color of the text inside the main input is white. The text can be seen when highlighted as shown :-

OS :- MacOS Cataline (v10.15.2)

@dselman @DianaLease Are you able to reproduce it ?

Yes.

@dselman Shall I start working on this then ?

@dselman let me know your thoughts on this:-
ref #36


[W6.1d][W14-B3] Daniel Berzin Chua Yuan Siang

Added isMutating method to Command class, updated tests to match.

@danielbrzn
Comments given for your PR. Check and acknowledge and close the PR thereafter. Good job!


How I can control url generation?

I publish .dist/prod to GitHub Pages & get issue with relative links in images & anchors...

You need to add the base key containing the directory path where the files are on the server.
In your case this would be base: /simple-blog.
You can automate this for the server using e.g. A script which adds an env yaml file.
Example:
Create prod.yaml
Add line base: /simple-blog
Add script to package.json or a script file: nue build -p -e prod.yaml. This adds prod.yaml keys on top of site.yaml and overrides duplicate keys with values from env file
Maybe my repo (just a project idea at the moment) gives more insight, how you could do publishing with gh workflows, if you wanted to.

O thx @nobkd 👍🏻
Nue-editor… interesting! How it will be work? MD editor?

Yeah, mainly.
Sadly I'll be a bit low on time for longer...

I'll close this as done. If you experience some issue with it, please reopen or just comment :)


Tails (aka LUKS encrypted disk) message "Error when getting information for the file path/to/file: Structure needs cleaning

This issue (while did not had descriptions, just photos) was somewhat about tests intentionally trying to break things and already using very, very cheap USB sticks. So we could assume near worst cases scenarios.
Tails, while do allow to emergency shut down by removing the USB stick (and with this, it will even do memory cleaning to mitigate cold boot attacks) should be used only if the person really needs, not like every.
Another point is, if you USB stick is not very attached to your computer, try to not touch the cables when doing intense write to the disk or a few minutes after. Most USB sticks may tell the operational system that they acknowledge the write, but they still organizing the files.
The message to "this USB can be removed" is mroe explicitly if you are using a 2nd USB on tails and ask Tails to eject this 2nd USB. But if the USB is the Tails itself, still better you do normal shutdown.
What happens if you don't do it?
On this example, I guess 2 errors happened.

The USB was removed before give time to adjust the files
When using Tails on secure mode (note, the first partition is not written often, so what is likely to be damanged is the TailsData) allowed me to try fix the partition.

My recommendation is, if you is using tails to recover the data, don't go out to get a Coffee (e.g. stay in front of the computer untill it ends). I suppose that by geting out of the computer, Tails done a logout and maybe forced the recover process to stop in the middle. So I actually lost more folders than likely to be necessary.

Note that in this case, I already had a recent backup so I could afford do these tests. But if I did not had an backup an cared about the data, the ideal is before trying to recover the partition, do a RAW copy of the entire partition and then do the recovery process. Note that Tails all the time show the warnings.


config subscription: make grpc_mux_lib an extension

Commit Message: config subscription: make grpc_mux_lib an extension
Risk Level: Low
Testing: N/A
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A
My envoy deployment overrides extensions_build_config.bzl. After upgrading from v1.25 v1.27, we saw the following error when starting envoy
2023-08-16_06:40:39.05042 [2023-08-16 06:40:39.050][123041][critical][main] [external/envoy/source/server/server.cc:134] error initializing config 'config.yaml': envoy.config_mux.grpc_mux_factory not found

This PR makes grpc_mux_lib an extension so that we can include envoy.config_mux.grpc_mux_factory in our extensions_build_config.bzl, which resolves the error.

@adisuissa is OOO
/assign @kyessenov


Atlas engine should support user-customizable pixel shaders & the retro terminal effect

@lhecker we may also want a bug to track disabling atlas when shaders are requested, for 1.16


size reduction from 1.5 gig for emoji-data?

Right now including this package in a package.json requires checking out the entire emoji-data repo which has a large amount of history.  I know #28 discusses creating an npm package and there is https://www.npmjs.com/package/front-js-emoji by a 3rd party but not sure if a stop gap of not the full history was considered (so non sub-module).
This is even though the final build size is only 90 megs.

it's now on npm as emoji-js, without any images. My intention is to publish multiple image packages that you can install separately

that work is tracked here: https://github.com/iamcal/emoji-data/issues/84


add missing '$' to index.html

Codecov Report

Merging #3073 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #3073      +/-   ##
=========================================
+ Coverage    38.9%   38.9%   +<.01%
=========================================
  Files        1987    1987
  Lines       65827   65827
  Branches     9198    9198
=========================================
+ Hits        25610   25611       +1
- Misses      37611   37614       +3
+ Partials     2606    2602       -4

Impacted Files
Coverage Δ

...npoint/rpc/server/SimpleServerMessageListener.java
80% <0%> (-20%)
:arrow_down:

.../com/navercorp/pinpoint/rpc/packet/PongPacket.java
50% <0%> (-14.29%)
:arrow_down:

...om/navercorp/pinpoint/rpc/codec/PacketDecoder.java
68.67% <0%> (-7.23%)
:arrow_down:

...orp/pinpoint/rpc/server/DefaultPinpointServer.java
74.24% <0%> (-1.14%)
:arrow_down:

...point/rpc/client/DefaultPinpointClientHandler.java
71.29% <0%> (-0.31%)
:arrow_down:

...corp/pinpoint/rpc/stream/StreamChannelManager.java
72.41% <0%> (+1.72%)
:arrow_up:

...tor/metric/datasource/DefaultDataSourceMetric.java
78.78% <0%> (+3.03%)
:arrow_up:

...rp/pinpoint/rpc/server/PinpointServerAcceptor.java
77.57% <0%> (+4.24%)
:arrow_up:

...vercorp/pinpoint/rpc/packet/ServerClosePacket.java
68% <0%> (+16%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51c7203...d443db5. Read the comment docs.

👍


CDPSDX-3528; secure the communication on the hdfs. Therefore I added…

secure the communication on the hdfs. Therefore I added new values to the Role config. The new values are the rpc protection, and the encrypt data transfer.
Tested with cbd the new values set correctly.

@lnardai
based on the Chirs Royles comment on the JIRA ticket. These changes should be applied to datahubs and datalakes.

Could you fix up the commit message, looks like some typo after the ticket id.


500 error on organization page: error calling DescriptionHTML

Gitea Version
1.15.3
Operating System
Linux (NixOS)
Browser Version
Firefox 92.0
Can you reproduce the bug on the Gitea demo site?
No
Description
A user on my gitea instance reported that whenever they hit the "org" page for one organization they get a 500 error. I'm able to reproduce this. The error only occurs on 1 organization - all other organizations are viewable without any errors.
I imagine a select statement in one of the tables in the associated database could provide more relevant information, but I'm not sure which table(s) to select from.
Any help would be greatly appreciated.
Thank you.
Screenshots

Which database are you using?

Panic looks like it is coming from JSONUnmarshalHandleDoubleEncode in login_source.go. Although I'll poke at it once I get to a desktop where I can actually read the above logs on a larger screen than my phone.

Have you restored from a dump made by 1.14.3-1.14.6?

Please upgrade to 1.15.4 - there is a fix to prevent an NPE at that line introduced in #17137 but you will need to reapply the patch I've provided if you still get problems so we can get more logging.

Upgrading fixes the issue. Thanks to all for your help!


fix!: Declare webpack as the peer dependency

https://classic.yarnpkg.com/lang/en/docs/dependency-types/#toc-peerdependencies
Workaround of a Yarn Berry behavior, which makes the Webpack instance of pino-webpack-plugin is different to one of the project: https://github.com/yarnpkg/berry/issues/2401.
/Volumes/Dev/OSS/unm-js/.yarn/__virtual__/webpack-virtual-76a0caa910/0/cache/webpack-npm-5.75.0-ebca50e2e7-2bcc5f3c19.zip/node_modules/webpack/lib/javascript/JavascriptModulesPlugin.js:143
                        throw new TypeError(
                        ^

TypeError: The 'compilation' argument must be an instance of Compilation
    at getCompilationHooks (/Volumes/Dev/OSS/unm-js/.yarn/__virtual__/webpack-virtual-76a0caa910/0/cache/webpack-npm-5.75.0-ebca50e2e7-2bcc5f3c19.zip/node_modules/webpack/lib/javascript/JavascriptModulesPlugin.js:143:10)
    at /Volumes/Dev/OSS/unm-js/.yarn/__virtual__/webpack-virtual-76a0caa910/0/cache/webpack-npm-5.75.0-ebca50e2e7-2bcc5f3c19.zip/node_modules/webpack/lib/javascript/CommonJsChunkFormatPlugin.js:43:19
    at Hook.eval [as call] (eval at create (/Volumes/Dev/OSS/unm-js/.yarn/cache/tapable-npm-2.2.1-8cf5ff3039-3b7a1b4d86.zip/node_modules/tapable/lib/HookCodeFactory.js:19:10), <anonymous>:7:1)
    at Hook.CALL_DELEGATE [as _call] (/Volumes/Dev/OSS/unm-js/.yarn/cache/tapable-npm-2.2.1-8cf5ff3039-3b7a1b4d86.zip/node_modules/tapable/lib/Hook.js:14:14)
    at Compiler.newCompilation (/Volumes/Dev/OSS/unm-js/.yarn/__virtual__/webpack-virtual-da9352bce3/0/cache/webpack-npm-5.75.0-ebca50e2e7-2bcc5f3c19.zip/node_modules/webpack/lib/Compiler.js:1121:30)
    at /Volumes/Dev/OSS/unm-js/.yarn/__virtual__/webpack-virtual-da9352bce3/0/cache/webpack-npm-5.75.0-ebca50e2e7-2bcc5f3c19.zip/node_modules/webpack/lib/Compiler.js:1166:29
    at Hook.eval [as callAsync] (eval at create (/Volumes/Dev/OSS/unm-js/.yarn/cache/tapable-npm-2.2.1-8cf5ff3039-3b7a1b4d86.zip/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:6:1)
    at Hook.CALL_ASYNC_DELEGATE [as _callAsync] (/Volumes/Dev/OSS/unm-js/.yarn/cache/tapable-npm-2.2.1-8cf5ff3039-3b7a1b4d86.zip/node_modules/tapable/lib/Hook.js:18:14)
    at Compiler.compile (/Volumes/Dev/OSS/unm-js/.yarn/__virtual__/webpack-virtual-da9352bce3/0/cache/webpack-npm-5.75.0-ebca50e2e7-2bcc5f3c19.zip/node_modules/webpack/lib/Compiler.js:1161:28)
    at /Volumes/Dev/OSS/unm-js/.yarn/__virtual__/webpack-virtual-da9352bce3/0/cache/webpack-npm-5.75.0-ebca50e2e7-2bcc5f3c19.zip/node_modules/webpack/lib/Compiler.js:524:12

Node.js v19.1.0

Other projects also do this.

@pan93412 The change looks legit to me. Can you fix the workflow files so that webpack get installed in GitHub actions (and therefore the CI does not fail)?

https://github.com/pan93412/pino-webpack-plugin/actions/runs/4090313789 It seems working! cc @ShogunPanda


Encryption container

Support a single container output.

Add QZipWriter to Crypto class
Zip files into a single container
User can unzip manually or import the container file into Kryvos

Overview

Container mode which allows adding files
Use libarchive to read and produce container zip files
User can unzip manually or import the container file into Kryvos

UI changes

Container and batch mode view states in settings-- possibly dropping batch mode altogether
Open one container at a time -> new container action asks to save current container first
New container action
Add files to container action
Enable file selection in list view
Remove selected files from container action
Display files in container
Save container button instead of encrypt/decrypt


Add constructor/validation for Acknowledgement type

Pending this type being finalized.
Validation for it should be invoked in MsgAcknowledge. Opening issue to keep track.

For Admin Use

[ ] Not duplicate issue
[ ] Appropriate labels applied
[ ] Appropriate contributors tagged/assigned
[ ] Estimate provided

Also need to then add this validation into WriteAcknowledgement along with tests. Will add in-line TODO so it doesn't get missed

What exactly is the validation we should do here?
The Acknowledgement type in eureka is just a slice of slice of bytes, what kind of validation can be performed? @AdityaSripal @DimitrisJim

the only one I can currently think of is that the length of the acks must be one (as we do for payloads)


Feature: Matching interface with name

Introducing two properties to base interface:

identifier -- name or mac-address, default to name
profile-name: string

When identifier been set to mac-address, nmstate will not use
interface.name for NIC matching but use the interface.mac-address, The
interface.name will be used for profile-name when storing the network
configuration in backend.
The profile-name will be hide if it is equal to interface name.
Example on creating MAC based profile:
---
interfaces:
- name: wan0
  type: ethernet
  state: up
  identifier: mac-address
  mac-address: 1e:bd:23:e9:fb:94

You may delete above profile using name: wan0 or its real interface name.
Integration test cases included.

Investigating CI failure


(Re)Generating tests after initial generation is not updating the generated unit test class when using file scoped namespaces

When using the "Generate file scoped namespaces" config option, if you have previously generated unit tests for a class, it won't then subsequently update the generated tests in any situation. You can delete the generated test file, and generate again from scratch and it does pick up the changes.
Confirmed that it's working fine if you have "Generate file scoped namespaces" set to False.
Repro:

Have the Layout - Generate file scoped namespaces configuration option set to True

Create a new class:

public class Foo
{
    public Foo(string bar)
    {
        Bar = bar;
    }

    public string Bar { get; }
}

Right click -> Generate Tests for Type 'Foo' - generates the tests fine
Edit the class to add a 2nd ctor:

private object _woop;

public Foo(object woop)
{
    _woop = woop;
}

Shift+Right click a ctor -> "Regenerate test for all constructors..." - focus switches back to the previously generated unit tests, but no changes have been picked up - there is no test for the extra ctor. Same if you Shift+Right click the class and "Regenerate tests for type 'Foo'..."

Deleting the unit test file, and generating from scratch is fine and picks up both ctor's.
Console output from Unitvers shows:
Creating unit test project mapping for 'ExampleProject'.
Found target project 'ExampleProject.UnitTests'.
Adding required assets to target project...
Adding generated items to target project...
Generation complete.

Environment
Unitverse <IP_ADDRESS>
VS 2022 17.4.2
.NET 6.0
MSTest

Sorry about that and, as ever, thanks for the report :) PR incoming


chore: jx-demo-go to 0.0.2

chore: Promote jx-demo-go to version 0.0.2

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Promatic 4 - Bus scan fails

Hi Stephan,
Sorry for bothering you but i've managed to source the PCB you designed and flashed both the ESP8266 and the PIC16 with your code to get it up and running in combination with my Hormann Promatic 4 door.
When i connect the PCD to the Hormann BUS:

Initially nothing happens
After toggling dip switch 8 (bus scan):
The PCB is powered
ESP8266 connects to the network (can ping the device)
Lights on door start flahsing red/green rapidly (is supposed to happen on bus scan)
As soon as bus scan finishes PCB loses power

Seems to my like the PCB is not recognized by the bus scan hence powering down the bus.
What could go wrong..?

is the code not detecting the door?
Is my PIC16 not flash succesfully?
Something else?

any suggestions to point me in the right direction would be much appreciated
Thnx!

a promatic 4 has a different protocol (it's using plain modbus from what I understood), so that won't work with this variant for now.
I'm going to a friend in ~1 week to measure it with a scope/logic analyser, since it would be good to be able to do both variants of the protocol with the same device (with a different cable perhaps, depends on the pinout).
If successful I'll make a variant of the code which can do both, you can always contact me if you want follow-up on situation

Aaah that explains a lot!  I will keep in touch for sure! Thnx!

@thomasdupas
I am searching for a new garage door motor and haven't made up my mind yet.
It would be really nice if you could make your findings publicly available.

After a quick search i figured out that Hörmann offers an adapter called HAP1 HCP which makes it possible to connect old accessories (like the UAP1 which the PIC emulates) to new doors (like Promatic 4).
The old accessories are using version 1 of the HCP protocol whereas the new doors are using version 2 which isnt' compatible to version 1.
I found the following compatibility list: https://cdn.hoermann-cloud.de/fileadmin/_country/kataloge/pdf/hcp_kompatibilitaet.pdf

"progress", google revealed that someone already did some sniffing and has a working solution
https://github.com/hkiam/HCPBridge/blob/master/Investigation/ProtocolAnalyse.txt
What I find strange though, it wouldn't send distinct target states anymore, but more "button emulation"
for example:
0015: 02 17 10 70 00 03 01 02 10 00 00 00 00 00 00 00 00 00 00 6C 88 		<- Tor auf pressed
0015: 02 17 10 78 00 03 01 01 10 00 00 00 00 00 00 00 00 00 00 6F 4A 		<- Tor auf released
0015: 02 17 10 6C 00 03 01 02 20 00 00 00 00 00 00 00 00 00 00 9B 41        <- Tor zu pressed
0015: 02 17 10 78 00 03 01 01 20 00 00 00 00 00 00 00 00 00 00 90 4A 		<- Tor zu released
Sounds a bit odd to me why they wouldn't use the distinct states in the protocol for something like the UAP

"progress", google revealed that someone already did some sniffing and has a working solution https://github.com/hkiam/HCPBridge/blob/master/Investigation/ProtocolAnalyse.txt
What I find strange though, it wouldn't send distinct target states anymore, but more "button emulation" for example: 0015: 02 17 10 70 00 03 01 02 10 00 00 00 00 00 00 00 00 00 00 6C 88 <- Tor auf pressed 0015: 02 17 10 78 00 03 01 01 10 00 00 00 00 00 00 00 00 00 00 6F 4A <- Tor auf released
0015: 02 17 10 6C 00 03 01 02 20 00 00 00 00 00 00 00 00 00 00 9B 41 <- Tor zu pressed 0015: 02 17 10 78 00 03 01 01 20 00 00 00 00 00 00 00 00 00 00 90 4A <- Tor zu released
Sounds a bit odd to me why they wouldn't use the distinct states in the protocol for something like the UAP

Hi, did you ever finish the adaptation for ProMatic 4 series? Thanks


Calling setCenterViewController:closeAnimation:YES doesn't call oldCenterViewController's viewWillDisappaer

Appears to be the same or similar to this old bug.  Works fine when animation set to NO.
I changed the following on my local copy and everything seems to work so far:
if(oldCenterViewController){
        [oldCenterViewController willMoveToParentViewController:nil];
//Commented out the below if statements.
        //if(animated == NO){
            [oldCenterViewController beginAppearanceTransition:NO animated:NO];
        //}
        [oldCenterViewController.view removeFromSuperview];
        //if(animated == NO){
            [oldCenterViewController endAppearanceTransition];
        //}
        [oldCenterViewController removeFromParentViewController];
    }

Thanks for the great component!

I am having the same issue. Did the above to fix it. If I use the fullCloseAnimation version viewWillDisappear is called.


Migrating from neo4j-contrib chart

Hello,
I'm looking for documentation on how to migrate from the deprecated Neo4j-contrib chart to this chart. I've spent some time searching but I can't seem to find anything. Am I overlooking something?
Thank you!

https://neo4j.com/docs/operations-manual/5/kubernetes/maintenance/#_migrate_neo4j_from_the_labs_helm_charts_to_the_neo4j_helm_charts_offline


REST queries triggered by a change of active wallet should be debounced

If you switch wallets quickly (but not crazy quick, like 1 / 500ms) in the wallet sections, it will cause a too many request error
@fboucquez that's something I observed in #177, but that is true with current as well

is this still active @decentraliser ?

My understanding is that it will be worked on in the SDK side, if yes then
we can close
On Fri, May 1, 2020, 03:23 Grégory Saive<EMAIL_ADDRESS>wrote:

is this still active @decentraliser https://github.com/decentraliser ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/nemfoundation/symbol-desktop-wallet/issues/239#issuecomment-622054422,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AIWPBP7CCTQ54U2XYKZK7K3RPHFZJANCNFSM4MHQKAMQ
.


SCSS formatting inconsistently follows coding guidelines

I've noticed that in some spots, spaces aren't used before { or after : characters despite this being part of the CSS coding guidelines. I don't think it's that big of a deal, but it's confusing as a contributor as to whether I should conform my code to the rest of the document or to follow the guidelines. An example of this is #1725, where the stylesheet doesn't include spaces and if I followed the guidelines it would make the code inconsistent, so in this case I chose to actually not follow the guidelines.

Thanks! I think it would be nice to have automated checks like we have for Python/JS.
Happy to set this up on Drone/Travis if someone cleans up the code (and sets up a style checker).

Fixed in #1737


guake not autostarting in desktop deployment

Turns out guake will stupidly autodelete your ~/.config/autostart  launch file if not set in guakes preferences.  Simply renaming it to something other than guake.desktop will stop guake from doing this


Broken on 0.26

Because of this of course but going in to change React and Component to import from react isn't fixing it. I'm not sure of the use for _interopRequireDefault but it seems to be culprit as my error is pointing to babel-helpers

The project uses babel 5 whereas RN now uses babel 6 - that might be part of the issue you're seeing?

How to fix the babel issue?

just get replace all the _react-native2 references with React and do the things mentioned in the link I posted in the first comment:
 import React, { Component, PropTypes } from 'react';
 import { View } from 'react-native';`

that's what got me to issue #9

I am still having an issue with Babel.

me too...
ReferenceError: [BABEL] /Users/funk/Development/Projects/ReactZeroNotifications/node_modules/react-native-gesture-recognizers/lib/index.js: Using removed Babel 5 option: /Users/funk/Development/Projects/ReactZeroNotifications/node_modules/react-native-gesture-recognizers/.babelrc.stage - Check out the corresponding stage-x presets http://babeljs.io/docs/plugins/#presets

Guys, did someone solve it?

+1

+1

+1

This should be fixed with ed416620eaeb9f35a60d68d4b876b4f41f349d1f


How do I close the floaterm with keybinds?

Description
How do I close the terminal with keybinds?
Expected Behavior
I have set leader+t+c to close terminal and want it closed when pressing these
Actual Behavior
when running those the keystrokes just gets typed to terminal as text
Details

Environment

nvim --version output: NVIM v0.5.0-dev+1428-g997a9c879
Operating system: macOS 11.4
lspsaga commit:

I also had this question, since it's quite custom it would be worth documenting options or suggestions in the README.

which keymap bind you used?

I'm having the same issue. How does one close the floaterm once it's opened?


NetBox adding a single rack

I'm having a problem adding a single rack to my database, when I choose from the top menu --> Racks---> Add A Rack:  I get the following error:
<class 'django.db.utils.DataError'>
invalid input syntax for integer: "d"

I'm not sure what could cause that to happen. Have you made any modifications to the code base? If not, could you please enable debugging and post the full stack trace?

Closing due to inactivity.


Handle ttf:// format for symbols in mark symbolizers

This simply required not transforming to lowercase when writing SLD since the font name can contain uppercase characters, and these should be kept in order for GeoTools to be able to recognize the symbol.
The regexp to detect of a symbol is a font glyph was inspired by the one used in Geotools:
https://github.com/geotools/geotools/blob/b695b08d10499d3d670cfc94cda77de42134d1a0/modules/library/render/src/main/java/org/geotools/renderer/style/TTFMarkFactory.java#L68-L73

The failing CI does not seem to be based on your changes, as it also occurs on other repositories.

The failing CI does not seem to be based on your changes, as it also occurs on other repositories.

That was my conclusion as well. Please let me know if there is any change to be done!

There is currently a problem with a newer version of node (v.12.17 and v13.13) which leads to this fail. I just created an issue for that https://github.com/geostyler/geostyler-sld-parser/issues/279.
Long story short: we have to update some dependencies

Sry @jahow i think you have to rebase after fixing the CI with #280 :man_shrugging:

Looking better now!

@KaiVolland do you think this can be merged now? thanks! (sorry for pushing all of you so much haha)

Yes :)

Hi @KaiVolland , I've noticed that many geostyler packages (inc. the OL parser) were released as 2.1.0 in the past months but this one did not; it would be great if a similar release could be made for the SLD parser (otherwise we have to maintain a privately hosted build to benefit the TTF icon feature). Would that be possible? Thanks a lot in advance!

Hey @jahow.
Are you talking about the current master, or are there any features your a missing?

About the current master, yes.

 Thanks a lot!!


Use modern URL scheme for localhost static

Just a new syntax for handling static. Leftover from my Windows fixes. BTW, rtfd development version is now working on on this platform.

LGTM


[Win]TNB_Version_31 Particular Time Later this msg shows Continues

Bug Description
5-10 min later Continuously Display This msg
Steps to Reproduce
Steps to reproduce the behavior:

Install TNB Application 1.0.0-alpha.31
Manually Enter IP Address This <IP_ADDRESS>
See the right side top corner this msg "An Error Occurred When Getting Clean Status"

Expected behavior
msg not showing continuously
Actual behavior
this msg shows "An Error Occurred When Getting Clean Status"
Screenshots/Recordings
https://prnt.sc/vskm9r
OS and Browser

OS: Windows 10

closing for now, as i can't reproduce

closing for now, as i can't reproduce