Allow stdout/stderr colorization to be turned off

Add a new logging stanza option "colorizable", which allows you
to turn off the ANSI colorization of stdout or stderr logging
targets. Useful for running oragono under systemd with stock
journal+syslog logging - otherwise you get a lot of ANSI control
characters in your syslog.
Defaults to true, to retain backwards compatability.

Thanks very much for your patch!
I discussed this with @DanielOaks and I'm leaning towards stripping out the color stuff entirely; it adds a fair amount of complexity and it's not easy to get a color scheme that displays well in all terminals.
The other option I was considering was to auto-detect whether stdout/stderr is a tty (the coloring library we use already pulls in a tty detection library, but contrary to what I had believed, doesn't actually perform this check on non-Windows platforms). Then there would be a configurable color setting as in your patch, but if the value is unset, it would default to whether stdout/stderr is a tty.
Thoughts?

Either of those works for me. I don't want the color pretty much ever, but I also don't know who might find that useful or in what cases they might. As long as I've got a bit to flip to turn off color if there is, I'm entirely happy.
Please do give a close look at the method I used to get a default true value for the flag --- I haven't done much Go programming yet, and I think that's the general Go way of doing that, but someone with a bit more experience should give it a closer look.

I'm still considering, but the more I think about it, color seems primarily useful to people developing Oragono, not to operators/users. (I have an instance I run myself and I capture the log output with systemd-journald. I had always assumed that Oragono was detecting this and stripping the color codes, but as you point out, they're actually in there and I just need --output cat if I want to see them. But now that I have them, I don't think I will find them very useful.)
The pattern you're using seems good. Mostly what I've been doing is accepting the need for a postprocessing step, rather than trying to produce the final result in a single yaml.Unmarshal operation. For example, this is what I do for booleans:
https://github.com/oragono/oragono/blob/33fd75ae54411c6e9020942c3804736396dc8ef6/irc/config.go#L566
https://github.com/oragono/oragono/blob/33fd75ae54411c6e9020942c3804736396dc8ef6/irc/config.go#L1035
https://github.com/oragono/oragono/blob/33fd75ae54411c6e9020942c3804736396dc8ef6/irc/utils/args.go#L86
This has strengths and weaknesses. I like it better when (as in this case) the compiler is enforcing that the raw value can't be used directly (because unlike in C or C++, pointers don't have truth values). Your solution has this property as well. (When the raw and postprocessed results have the same type, e.g., []string, there's an annoying effect where the raw value has to be a public  / capitalized field, because otherwise it can't be unmarshalled at all, and conversely it's preferable [but not actually necessary] that the postprocessed value be private / lowercased, because otherwise someone could accidentally write a config file that populates it directly.)
A minor gotcha with defining custom UnmarshalYAML methods is that they won't be called at all if the field is not present, so it's necessary that the zero value of the type implement the desired default behavior (as it does in your case, but there are other settings where I find postprocessing more idiomatic).
Anyway, our LoadConfig function does a lot of very elaborate postprocessing, producing a *Config that is immutable after load and can be read using atomic.LoadPointer. This is very efficient on amd64 because the atomic load compiles down to a plain MOV instruction.

Closing this in favor of #940.


fixed typo in file (WSTRB instead of WUSER)

Thank you for your contribution. This was fixed in parallel development work.  Please let us know if some things are still pending.


API Key reset after Invoke-Pester

@Agazoth - I ran the tests from the cli and then did q to the model. I get this error.
It'd be optimal if the env is set to where it was before running tests. Something to keep in mind.
Workaround, run tests in a separate console.

@dfinke  fix provided - saving current key before test and resetting after test

Added s cmdlet to remove the AIProviderList and added that to the tests. Should be good now

worked!


Bump the version of json5 from 1.0.1 to 1.0.2

Signed-off-by: Ryan Liang<EMAIL_ADDRESS>Description
Bump the version of json5 from 1.0.1 to 1.0.2
Category
Maintenance
Issues Resolved

Relate https://github.com/opensearch-project/OpenSearch-Dashboards/issues/3148

Testing
[Please provide details of testing done: unit testing, integration testing and manual testing]
Check List

[ ] ~New functionality includes testing~
[ ] ~New functionality has been documented~
[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

This PR is blocked by the version update of 1.3.8. Once the version increment is done I will re-run the integ test.

@RyanL1997 It won't be fixed until the security plugin is incremented to 1.3.8 and added to the build manifest. This PR (https://github.com/opensearch-project/security/pull/2344) needs to be merged, but its currently blocked by failing plugin install workflow which is because the version increment is not being applied to all necessary files.

Closing this one, since the latest CVE fix for 1.3 branch has removed the json5 dependency: https://github.com/opensearch-project/security-dashboards-plugin/pull/1308


WIP Duplicate endpoints in the endpoint topology to account for NAT mapping.

Fixes #245

package endpoint is about everything related to the endpoint topology? If yes, let's move other things in there too, so we don't have this in-between state.

All good points; should have put a WIP tag on this.  I was considering adapting typetypetype/conntrack for this but it looks like too much work; we can do it in the future if necessary.

LGTM


Incompatible versions of aws-java-sdk-bundle: the bundled one and the one expected by hadoop-aws

I'm using Delta Sharing 0.5.1. Checking its lib folder, I found those JARs:
com.amazonaws.aws-java-sdk-bundle-1.12.189.jar
...
org.apache.hadoop.hadoop-aws-2.10.1.jar

According to this Maven Repo, this version 2.10.1 of "Apache Hadoop Amazon Web Services Support" requires "aws-java-sdk-bundle" 1.11.271 (released on Jan 27, 2018). However, in the list of JARs above, we can see the version 1.12.189 (released on Mar 30, 2022) was included. 4+ years difference!
I'm not professional on Java, but I think this incompatibility can cause problems further down the line.

We have S3 integration tests to make sure we don't touch any incompatible code path. It's working and we haven't seen any incompatible issues. Hence I'm closing this one. Feel free to reopen this one if you hit any real incompatible issues.


🩹  NICE-95 (zod) next-config/env.(client|server) [b]

[x] 🩹  NICE-95 zod for type checked env
[x] ♻  NICE-95 next-config/env.(client|server)

This pull request has been deployed to Vercel.

Latest commit:
956950f

✅ Preview:
https://jeromefitzgerald-qn9jo2fi8-jerome5.vercel.app

🔍 Inspect:
https://vercel.com/jerome/jeromefitzgerald/4EbgWDFhmsksewuqQZwzkniRGVv7

View Workflow Logs

This pull request has been deployed to Vercel.

Latest commit:
5c242f6

✅ Preview:
https://jeromefitzgerald-b6xf5gy8u-jerome5.vercel.app

🔍 Inspect:
https://vercel.com/jerome/jeromefitzgerald/AKvwFr9b9FsnR5knUzxhEAALrMB5

View Workflow Logs


Could not find implementations for the following rules... Error

Hi everybody,
Description
I just tried to setup codelyzer for my project and I ran into the following problem:

The component-selector and directive-selector produce the following error:

throw new Error(ERROR_MESSAGE);
        ^

Error:
            Could not find implementations for the following rules specified in the configuration:
            directive-selector
component-selector
            Try upgrading TSLint and/or ensuring that you have all necessary custom rules installed.
            If TSLint was recently upgraded, you may have old rules configured which need to be cleaned up.

    at Object.loadRules (/Users/jonathan/Projects/play/codelyzer-issue/node_modules/tslint/lib/ruleLoader.js:29:15)
    at Linter.lint (/Users/jonathan/Projects/play/codelyzer-issue/node_modules/tslint/lib/tslint.js:59:44)
    at processFile (/Users/jonathan/Projects/play/codelyzer-issue/node_modules/tslint/lib/tslint-cli.js:138:29)
    at /Users/jonathan/Projects/play/codelyzer-issue/node_modules/tslint/lib/tslint-cli.js:177:74
    at Array.forEach (native)
    at Object.<anonymous> (/Users/jonathan/Projects/play/codelyzer-issue/node_modules/tslint/lib/tslint-cli.js:177:41)
    at Module._compile (module.js:573:32)
    at Object.Module._extensions..js (module.js:582:10)
    at Module.load (module.js:490:32)
    at tryModuleLoad (module.js:449:12)

Reproduce
I prepared a minimal setup to reproduce the issue https://github.com/gruppjo/codelyzer-issue

Thanks for the detailed explanation of the issue you have! Yes, currently directive-selector and component-selector are in master but not yet published. You can use the configuration explained on npm. Good luck! Let me know if you have any other problems.

Oh. Wasn't aware of that. Sorry! And thanks for the swift response! :)


Support loading unwrapped schema.json file

It would be nice to support loading schema.json files that do not have the { "data": {}, "errors": [] } wrapper.
Other libraries support this by only passing introspectionResult.data if it exists.
While I do think this makes things a little more ambiguous, it seems nice to either implicitly support these files, or explicitly allow a user-configurable option to load non-wrapped introspection schemas. I would be curious to see if there is a good use case for wanting to write an error-result to a schema.json in the first place.
wdyt? I would be happy to send a PR for either.

Agree, let's move forward with this!

#53


Upgrading  FontAwesome to 5.7.2

Hello there,
I've been trying to upgrade the fontAwesome version to be able to utilize more icons. Is there any simple way to do this? Unfortunately, I have not been able to solve it by myself.
Thank you for your time.
Regards,
David

You'd need to get the relevant version number and associated SRI from CDNJS website and then update those details in the appropriate file: https://github.com/gcushen/hugo-academic/blob/master/data/assets.toml . For further support, post on the support forums.

Thank you. In case you want to update it in general, here's the required replacement. Regards.
[css.fontAwesome]
  version = "5.7.2"
  sri = "sha384-MTIz+PpCFMazCVo1SXqBcaPuVqnzoQVhp2GXI6EqlVTsseE3YdOZ6FyU/hsRp4uo"
  url = "https://cdnjs.cloudflare.com/ajax/libs/font-awesome/%s/css/all.css"


tpldata for array produces error

I have an array setup to provide a different title to different array elements in the form.  I get an error when trying to add more array elements than is defined in the tpldata (>2 in the case of this example).
Uncaught TypeError: Cannot read property 'bar' of undefined
{
  "schema": {
    "foo": {
      "type": "array",
      "items": {
        "type": "object",
        "properties": {
          "bar": {
            "type": "string"
          }
        }
      }
    }
  },
  "form": [
    {
      "type": "tabarray",
      "draggable": "false",
      "items": [
        {
          "type": "section",
          "legend": "{{value}}",
          "items": [
            {
              "key": "foo[].bar",
              "default": "computer",
              "valueInLegend": true,
              "title": "{{foo[].bar}}"
            }
          ]
        }
      ]
    }
  ],
  "tpldata": {
    "foo": [
      {
        "bar": "abc"
      },
      {
        "bar": "123"
      }
    ]
  }
}

That's true. It seems legit since jsonform doesn't know where to find the data and so can't access the bar item of null ...


Only send a dummy onPan when other gestures are detected

Make sure singleTap and pan gestures are not detected simultaneously

Closing this, including the fix in #1852


Auto save telegram batch join

Hi Carlos,
This PR addresses the issue where builders could join the batch Telegram group without having their information linked to our database. Now, builders sign a message with the latest batch number and the status candidate.
Therefor, I added a new environment variable: NEXT_PUBLIC_BATCH_NUMBER.
Please let me know your thoughts on the UI (with the correct wording). I went for the easiest option with just having a text displaying that the builder has to add his telegram name.
There would be other options:

Adding a button in the batch onboarding notification that opens the "Update Social" modal

Creating a separate modal specifically for adding the Telegram username

In the short video below, you can see the functionality in action:
https://github.com/user-attachments/assets/75c3d85e-17de-4471-9bcd-cb314419b9d6
Let me know what you think!

Changes applied
https://github.com/user-attachments/assets/58ed12b3-7768-4d48-b160-f56e02dd2e5e

@carletex changes implemented


Restic 0.6.0 onwards fails to run with legacy S3 repo

Output of restic version
FROM
restic 0.5.0 (v0.5.0-0-gf678c97)
compiled with go1.8 on linux/amd64
TO
restic 0.6.1
compiled with go1.8.3 on linux/amd64
How did you start restic exactly? (Include the complete command line)
./restic_0.6.1_linux_amd64 check
What backend/server/service did you use?
AWS S3
Expected behavior
To check the repo for errors
Actual behavior or output
unable to open repo at s3://s3.amazonaws.com/myrepo: ReadDir: invalid key name restic/key/, removing prefix restic/key/ yielded empty string
Steps to reproduce the behavior
Use restic 0.6.0 onwards on a 0.5.0 formatted S3 repo.
Do you have any idea what may have caused this?
Not sure. Maybe no longer allows using the legacy repo.
What have I tried
Compiled latest restic and attempted to run the migrate command on repo. Migrate produces the same error as above like all other commands.

Huh, thanks for leaving an issue, this is most likely a bug.
Can you please test again using the following syntax for the repository:
s3:s3.amazonaws.com/myrepo

Please report back, thanks!

Hi,
Still does the same error. I thought you might still support the legacy repo, at least for the migrate command so I raised the case. I did not originally use the --repo option as I set this as part of some environment variables but to be sure I have tried specifying it as well.
Tried this both with the latest release and also a binary compiled from master.
./restic --repo s3://s3.amazonaws.com/myrepo check
unable to open repo at s3://s3.amazonaws.com/myrepo: ReadDir: invalid key name restic/key/, removing prefix restic/key/ yielded empty string

Thanks fro trying, I'll have a look.

Could you please check if it works when you use the option -o s3.layout=s3legacy?

I'm unable to reproduce this issue. I've create a repo with 0.5.0 and then used 0.6.1 to access it (and also tried master), works for me. Any idea what's different for you?

Using the switch -o s3.layout=s3legacy does the trick. I did not spot this in the documentation so not sure if it is a new addition or not but it works and I can access the repo using a newer version now.

I'm glad that it works now, but somehow it seems layout detection is broken and I'd like to find out why. Could you please create a debug log (without using -o s3.layout)?

Ran the debug enabled version of restic on a legacy repo with the log attached. No switch used.
ID, Secret and Bucket names have been replaced with generic names for known reasons.
restic-debug-log.txt

I took a look at this, and I'm not able to reproduce it either.
From the attached debug log, it looks like s3 listobjects for prefix "restic/key/" is returning an entry that's exactly "restic/key/", which doesn't seem that odd to me, but I'm unable to get s3 to do the same thing for me.
I think the fix is to just ignore that entry instead of aborting. I can create a PR in a bit.


Session not persisting between requests

Well @ericdude4 , I must be doing something wrong.
When I click on a link from the initial page embedded in the app, the session does not persist.
Here is what I have in my router.ex
scope "/auth", MyAppWeb do
    pipe_through [:browser, :shopify_entrypoint]

    get "/", AuthController, :auth
    get "/install", AuthController, :install
  end

  scope "/", MyAppWeb do
    pipe_through [:browser, :shopify_session]

    get "/", EventController, :index
    resources "/events", EventController,
  end

Here is the initial response, from get '/auth'
[info] GET /auth
[debug] Processing with MyAppWeb.AuthController.auth/2
  Parameters: %{"hmac" => "ca98fc37c42fd5872397600e3dwerrf1c53556dab9f1b98d5f93e598162254", "locale" => "en", "session" => "54798671d0a9f8c3a59ereettc0cafd6c5438124bcfe8748107257f6198bfb04", "shop" => "someshop.myshopify.com", "timestamp" => "1590846273"}
  Pipelines: [:browser, :shopify_entrypoint]
--------------------[conn from Shopifex.Plug.ShopifyEntrypoint]-----------------------------------------
%Plug.Conn{
  adapter: {Plug.Cowboy.Conn, :...},
  assigns: %{},
  before_send: [#Function<0.78923111/1 in Plug.CSRFProtection.call/2>,
   #Function<2.86443083/1 in Phoenix.Controller.fetch_flash/2>,
   #Function<0.55231287/1 in Plug.Session.before_send/2>,
   #Function<0.93523768/1 in Plug.Telemetry.call/2>,
   #Function<0.2186795/1 in Phoenix.LiveReloader.before_send_inject_reloader/2>],
  body_params: %{},
  cookies: %{
    "_my_app_key" => "SFMyNTY.g3QAAAAA.ZmPHZTgugy2ORhhcf64qgRxfZdx8VyP-vzdrgvA"
  },
  halted: false,
  host: "feabaaa8c1bb.ngrok.io",
  method: "GET",
  owner: #PID<0.615.0>,
  params: %{
    "hmac" => "ca98fc37c42fd5872397600e3df9226121c53556dab9f1b98d5f93e598162254",
    "locale" => "en",
    "session" => "54798671d0a9f8c3a5945b638c0cafd6c5438124bcfe8748107257f6198bfb04",
    "shop" => "someshop.myshopify.com",
    "timestamp" => "1590846273"
  },
  path_info: ["auth"],
  path_params: %{},
  port: 80,
  private: %{
    AutomatoWeb.Router => {[], %{}},
    :phoenix_endpoint => MyAppWeb.Endpoint,
    :phoenix_flash => %{},
    :phoenix_format => "html",
    :phoenix_request_logger => {"request_logger", "request_logger"},
    :phoenix_router => MyAppWeb.Router,
    :plug_session => %{},
    :plug_session_fetch => :done
  },
  query_params: %{
    "hmac" => "ca98fc37c42fd5872397600e3df9226121c53556dab9f1b98d5f93e598162254",
    "locale" => "en",
    "session" => "54798671d0a9f8c3a5945b638c0cafd6c5438124bcfe8748107257f6198bfb04",
    "shop" => "someshop.myshopify.com",
    "timestamp" => "1590846273"
  },
  query_string: "hmac=ca98fc37c42fd5872397600e3df9226121c53556dab9f1brgergwergeg62254&locale=en&session=54798671d0a9f8c3a5945b638c0cafd6c5438124bcfe8748107257f6198bfb04&shop=someshop.myshopify.com&timestamp=1590846273",
  remote_ip: {127, 0, 0, 1},
  req_cookies: %{
    "_my_app_key" => "SFMyNTY.g3QAAAAA.ZmPHZTi7P6CkiR2ORhhcf64qgRxfZdx8VyP-vzdrgvA"
  },
  req_headers: [
    {"accept",
     "text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,image/apng,*/*;q=0.8,application/signed-exchange;v=b3;q=0.9"},
    {"accept-encoding", "gzip, deflate, br"},
    {"accept-language", "en-US,en;q=0.9,el;q=0.8,la;q=0.7"},
    {"cookie",
     "_automato_key=SFMyNTY.g3QAAAAA.ZmPHZTi7P6CkiR2ORhhcf64qgRxfZdx8VyP-vzdrgvA"},
    {"dnt", "1"},
    {"host", "feaegrc1bb.ngrok.io"},
    {"sec-fetch-dest", "iframe"},
    {"sec-fetch-mode", "navigate"},
    {"sec-fetch-site", "cross-site"},
    {"upgrade-insecure-requests", "1"},
    {"user-agent",
     "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/83.0.4103.61 Safari/537.36"},
    {"x-forwarded-for", "<IP_ADDRESS>"},
    {"x-forwarded-proto", "https"}
  ],
  request_path: "/auth",
  resp_body: nil,
  resp_cookies: %{},
  resp_headers: [
    {"cache-control", "max-age=0, private, must-revalidate"},
    {"x-request-id", "FhPSQmGujQPJ8MUAAADh"},
    {"x-xss-protection", "1; mode=block"},
    {"x-content-type-options", "nosniff"},
    {"x-download-options", "noopen"},
    {"x-permitted-cross-domain-policies", "none"},
    {"cross-origin-window-policy", "deny"}
  ],
  scheme: :http,
  script_name: [],
  secret_key_base: :...,
  state: :unset,
  status: nil
}
-------------------------------------------------------------
[debug] QUERY OK source="shops" db=16.6ms queue=1.5ms idle=598.7ms
SELECT s0."id", s0."access_token", s0."scopes", s0."url", s0."inserted_at", s0."updated_at" FROM "shops" AS s0 WHERE (s0."url" = $1) ["someshop.myshopify.com"]
[info] Sent 302 in 110ms
[info] GET /
[debug] Processing with MyAppWeb.EventController.index/2
  Parameters: %{}
  Pipelines: [:browser, :shopify_session]
******************Result of Phoenix.Controller.get_flash(conn, :shop) in Shopifex.Plug.ShopifySession .call***************
%MyAppWeb.ShopifyApp.Shop{
  __meta__: #Ecto.Schema.Metadata<:loaded, "shops">,
  access_token: "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",
  id: 8,
  inserted_at: ~N[2020-05-30 13:33:27],
  scopes: "write_inventory,write_products,read_orders",
  updated_at: ~N[2020-05-30 13:33:27],
  url: "someshop.myshopify.com"
}
[debug] QUERY OK source="events" db=1.7ms queue=1.1ms idle=1056.8ms
SELECT e0."id", e0."data", e0."topic", e0."inserted_at", e0."updated_at" FROM "events" AS e0 []
[info] Sent 200 in 38ms

And here is a subsequent request, which again gets redirected to /auth
[info] GET /events/new
[debug] Processing with MyAppWeb.EventController.new/2
  Parameters: %{}
  Pipelines: [:browser, :shopify_session]
****************Result of Phoenix.Controller.get_flash(conn, :shop) in Shopifex.Plug.ShopifySession .call*****************
nil
[info] Sent 302 in 656µs
[info] GET /auth
[debug] Processing with MyAppWeb.AuthController.auth/2
  Parameters: %{}
  Pipelines: [:browser, :shopify_entrypoint]
[info] Sent 200 in 447µs

Any help/info would be much appreciated.

Hi @arialblack14, Thanks for being my guinea pig for this package :)
I have resolved the issue, and updated the documentation. For you to fix this, simply change your :browser pipeline in router.ex to look like this:
  pipeline :browser do
    plug :accepts, ["html"]
    plug :fetch_session
    plug Shopifex.Plug.FetchFlash
    plug :protect_from_forgery
    plug :put_secure_browser_headers
    plug Shopifex.Plug.LoadInIframe
  end

Then run mix deps.update shopifex
Sorry about my lack of testing beforehand. I was able to get it working smoothly with this recent change. Thank you for your bug report.

Haha, glad I could help :)
Works great now! :metal: :metal:


[Add hover effect on Profile, Favourites, Log out]

Description
Under user logo I want to add hover effect on Profile, Favourites and Log Out to make it more attractive. Please assign me this task under GSSoC'23.
Screenshots
No response
Additional information
No response

Hey @narayan954 I want to handle this issue.... please assign me this

Description
Under user logo I want to add hover effect on Profile, Favourites and Log Out to make it more attractive. Please assign me this task under GSSoC'23.
Screenshots
No response
Additional information
No response

Hi @akshaysoni10 actually we're removing that option and moving completely to sidebar, so it's not much needed. But thanks for raising the issue

I'm closing this as not required right now


Added Emerald, Gold, and Iron blocks and ore

Simple implementation to allow creation of these ore and blocks.

Thanks!


docstring updated to indicate limits of axis_tilt

[Y] Adds docstring information from discussion in #1471
[Y] I am familiar with the contributing guidelines
[N] Tests added
[N] Updates entries in docs/sphinx/source/reference for API changes.
[N] Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
[Y] New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
[Y] Pull request is nearly complete and ready for detailed review.
[x] Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

@kanderso-nrel Added those additional references when axis_tilt is used as an input and also added myself to the list of contributors.  Thanks for the help!


⚠ Spryr has degraded performance

In b040a65, Spryr (https://spryr.com) experienced degraded performance:

HTTP code: 200
Response time: 22440 ms

Resolved: Spryr performance has improved in 9d68e4c after 7 minutes.


ComboBox  - Show all options after a value has been entered

Created from #3785
Update Combobox to show all options when a user activates it but it contains text already.

Discussed this with a11y, there is no issue from an a11y viewpoint but they don't see any issue with the current behaviour. That leaves the only question:
Should we built this into every example or make it more obvious as an option with a clear example?

Start by updating custom filtering example and docs, does not feel expensive to update other examples at same time but would decide that once we have a working example.


TweakDB, Overrides, RedHotScripts

Updated TweakDB implementation (faster initialization, flat reading, record creations, better compatibility with other TweakDB tools)
Fixed deadlocks for some overrides combinations
Added compatibility with scripts hot reload

Merged


Fixes #3420 fix checkstyle

Fixes https://github.com/apache/incubator-shardingsphere/pull/3420
fix checkstyle

Can you change the title first?

sorry...I have changed it.

@terrymanu @crecel ， Base64 is thread-safe. But this pr is invalid, the code style has been adjusted by pr#3428.


Fix Issue 7006 - Enabled pow to accept negative exponents for integrals

Why should negative exponents be allowed when you can't represent any of them as an integer?

@RazvanN7 IMHO, this one can be closed - the bug has been fixed in #7322

@RazvanN7 IMHO, this one can be closed - the bug has been fixed in #7322

@berni44 Thanks for the heads up.

@berni44 Thanks for the heads up.


deadlock due to cPickle not releasing GIL (again!)

A long time ago I tracked down a toil deadlock caused by attempting to unpickle a file as it is streamed from the job store. If a pickle file isn't created with cPickle.HIGHEST_PROTOCOL, cPickle (incorrectly) fails to release the GIL before starting a read. If the filestream buffer runs out during that read, the process will block forever, because the Python thread on the other end can't wake up to fill the buffer. We fixed this by always dumping with HIGHEST_PROTOCOL.
But just now, I found a deadlocked worker, and guess what it's doing?
gdb) bt
#0  0x00007fcdc5af26cd in read () at ../sysdeps/unix/syscall-template.S:81
#1  0x00007fcdc5a815a0 in _IO_new_file_underflow (fp=0x2791f80) at fileops.c:613
#2  0x00007fcdc5a8252e in __GI__IO_default_uflow (fp=0x2791f80) at genops.c:435
#3  0x00007fcdc5a78ace in _IO_getc (fp=0x2791f80) at getc.c:39
#4  0x000000000054177c in readline_file.57371 (self=0x7fcdc066ac50, s=0x7ffc94a13220) at ../Modules/cPickle.c:591
#5  0x000000000047a014 in load_global (self=0x7fcdc066ac50) at ../Modules/cPickle.c:4034
#6  load (self=0x7fcdc066ac50) at ../Modules/cPickle.c:4860
#7  0x0000000000524cdc in call_function (oparg=<optimized out>, pp_stack=0x7ffc94a13360) at ../Python/ceval.c:4004

(gdb) py-bt
#8 Frame 0x7fcdc0804830, for file /usr/local/lib/python2.7/dist-packages/toil/job.py, line 889, in _unpickle (cls=<type at remote 0x2215d00>, userModule=<module at remote 0x7fcdc0a71fa0>, fileHandle=<file at remote 0x7fcdc39769c0>, config=<Config(rescueJobsFrequency=3600, logLevel='DEBUG', maxMemory=9223372036854775807, jobStore='aws:us-west-2:cactus-jcarmstr-simmammals', defaultPreemptable=False, maxPreemptableServiceJobs=9223372036854775807, servicePollingInterval=60, workDir=None, stats=False, disableCaching=False, sseKey=None, nodeOptions=None, environment={}, minNodes=1, cleanWorkDir='always', maxCores=9223372036854775807, minPreemptableNodes=0, maxPreemptableNodes=0, maxDisk=9223372036854775807, scaleInterval=<float at remote 0x22e43f0>, deadlockWait=2000, preemptableNodeType=None, nodeType='m3.large', clusterStats=None, defaultCores=1, parasolMaxBatches=10000, cseKey=None, betaInertia=<float at remote 0x22e4438>, maxNodes=4, scale=1, writeLogs=None, badWorker=<float at remote 0x22e4480>, defaultDisk=21474...(truncated)
    runnable = unpickler.load()
#12 Frame 0x25df340, for file /usr/local/lib/python2.7/dist-packages/toil/job.py, line 865, in _loadJob (cls=<type at remote 0x2215d00>, command='_toil edd796f4-e1b3-45f7-b634-07e13fa102ab /venv/lib/python2.7/site-packages cactus.pipeline.cactus_workflow True', jobStore=<AWSJobStore(s3=<S3Connection(request_hook=None, num_retries=6, ca_certificates_file='/usr/local/lib/python2.7/dist-packages/boto/cacerts/cacerts.txt', _provider_type='aws', http_unretryable_exceptions=[<type at remote 0x22e27a0>], https_connection_factory=None, is_secure=True, protocol='https', port=443, _connection=(u's3-us-west-2.amazonaws.com', 443, True), _auth_handler=<HmacAuthV1Handler(_hmac_256=None, host=u's3-us-west-2.amazonaws.com', _hmac=<HMAC(digest_cons=<built-in function openssl_sha1>, outer=<_hashlib.HASH at remote 0x7fcdc191d490>, inner=<_hashlib.HASH at remote 0x7fcdc191d3f0>, digest_size=20L) at remote 0x7fcdc19b1ab8>, _provider=<Provider(acl_header='x-amz-acl', server_side_encryption_header='x-amz-server-side-encryption', copy_...(truncated)
    return cls._unpickle(userModule, fileHandle, jobStore.config)
#16 Frame 0x2066730, for file /usr/local/lib/python2.7/dist-packages/toil/worker.py, line 325, in main (sourcePath='/usr/local/lib/python2.7/dist-packages', setLogLevel=<function at remote 0x7fcdc3419410>, getTotalCpuTime=<function at remote 0x7fcdc2f8de60>, getTotalCpuTimeAndMemoryUsage=<function at remote 0x7fcdc2f8dde8>, Job=<type at remote 0x2215d00>, boto=<module at remote 0x7fcdc27410f8>, enable_metadata_credential_caching=<function at remote 0x7fcdc26a8050>, jobStoreLocator='aws:us-west-2:cactus-jcarmstr-simmammals', jobStoreID='75c14bc6-9a1e-4335-9272-391d83ae1b76', listOfJobs=["'CactusBarWrapper' 75c14bc6-9a1e-4335-9272-391d83ae1b76"], logFileByteReportLimit=0, fileHandle=<file at remote 0x7fcdc16c2150>, environment=<_Environ(data={'TERM': 'linux', 'PS1': '(venv) ${debian_chroot:+($debian_chroot)}\\u@\\h:\\w\\$ ', 'LESSCLOSE': '/usr/bin/lesspipe %s %s', 'SHLVL': '1', 'OLDPWD': '/cactus', 'HOSTNAME': 'ip-172-31-6-228.us-west-2.compute.internal', 'VIRTUAL_ENV': '/venv', 'LESSOPEN': '| /usr/bin/lesspipe %s'...(truncated)
    job = Job._loadJob(jobGraph.command, jobStore)
#20 Frame 0x7fcdc60ba218, for file /usr/local/bin/_toil_worker, line 11, in <module> ()
    sys.exit(main())

I just grepped through the code and it looks like there is a lot of stuff getting dumped without cPickle.HIGHEST_PROTOCOL. It's an easy fix, but is there a way we can add a check for this to CI, or monkey-patch cPickle or something? Otherwise, I think this will just keep recurring whenever anyone adds a new pickle dump.

@joelarmstrong good catch! This was re-introduced in https://github.com/BD2KGenomics/toil/pull/1340, I wasn't aware of the issues with using non-HIGHEST_PROTOCOL. Unfortunately, this issue isn't as simple as changing our protocols, since CWLWorkflow objects won't serialize properly with HIGHEST_PROTOCOL.
I'm also in favor of finding a more permanent solution, probably monkey-patching.

Whoops, I was remembering an earlier version of that PR - there are no more problems with serializing those objects so this should be a fairly easy fix!

Hmm, I'm actually still getting this. It's way less common now: I used to get it constantly, but it just happened today for the first time in weeks. I've checked to make reasonably certain I'm actually using the updated code through the entire pipeline, start to finish, on worker and leader nodes.
I wonder if using cPickle.HIGHEST_PROTOCOL isn't necessarily enough to guarantee that cPickle will dump a pickle that always uses the "bin" format? Hannes and I decided that would be sufficient years ago, but I can't remember what the logic was behind that. The stack trace indicates it's trying to use load_int, which doesn't release the GIL properly. IIRC load_binint does. I'll try to download this job pickle, and try to see exactly what int it's trying to load. Maybe it's related to some custom pickling code or something? I'll give an update tomorrow.
We could also admit defeat and just avoid unpickling from streams.
strace:
core@ip-172-31-43-192 ~ $ sudo strace -f -p 127185
Process 127185 attached with 2 threads
[pid 127446] futex(0x1806300, FUTEX_WAIT_PRIVATE, 0, NULL <unfinished ...>
[pid 127185] read(7, ^CProcess 127185 detached
 <detached ...>
Process 127446 detached

C stack:
#0  0x00007fb4f24356cd in read () at ../sysdeps/unix/syscall-template.S:81
#1  0x00007fb4f23c45a0 in _IO_new_file_underflow (fp=0x1d8ca70) at fileops.c:613
#2  0x00007fb4f23c552e in __GI__IO_default_uflow (fp=0x1d8ca70) at genops.c:435
#3  0x00007fb4f23bbace in _IO_getc (fp=0x1d8ca70) at getc.c:39
#4  0x000000000054177c in readline_file.57371 (self=0x7fb4ee33e410, s=0x7ffd42331900) at ../Modules/cPickle.c:591
#5  0x000000000052f928 in load_int.57597 (self=self@entry=0x7fb4ee33e410) at ../Modules/cPickle.c:3384
#6  0x0000000000479eaa in load (self=0x7fb4ee33e410) at ../Modules/cPickle.c:4743

Python stack:
#8 Frame 0x7fb4ed133a28, for file /usr/local/lib/python2.7/dist-packages/toil/job.py, line 895, in _unpickle (cls=<type at remote 0x18fc100>, userModule=<module at remote 0x7fb4ed3b5fd8>, fileHandle=<file at remote 0x7fb4f02bfc90>, config=<Config(rescueJobsFrequency=3600, logLevel='DEBUG', maxMemory=9223372036854775807, jobStore='aws:us-west-2:cactus-jcarmstr-hmrd-mr-pp2', defaultPreemptable=False, maxPreemptableServiceJobs=9223372036854775807, servicePollingInterval=60, workDir=None, stats=False, disableCaching=False, sseKey=None, nodeOptions=None, environment={}, minNodes=0, cleanWorkDir='always', maxCores=9223372036854775807, minPreemptableNodes=0, maxPreemptableNodes=20, maxDisk=9223372036854775807, scaleInterval=<float at remote 0x19bb7e0>, deadlockWait=2000, preemptableNodeType='c3.8xlarge:0.40', nodeType='r3.8xlarge', clusterStats=None, defaultCores=1, parasolMaxBatches=10000, cseKey=None, betaInertia=<float at remote 0x19bb828>, maxNodes=1, scale=1, writeLogs=None, badWorker=<float at remote 0x19bb870>, ...(truncated)
    runnable = unpickler.load()
#12 Frame 0x1cc54c0, for file /usr/local/lib/python2.7/dist-packages/toil/job.py, line 871, in _loadJob (cls=<type at remote 0x18fc100>, command='_toil 36955a09-7160-44e4-837e-738371b34a97 /venv/lib/python2.7/site-packages cactus.pipeline.cactus_workflow True', jobStore=<AWSJobStore(s3=<S3Connection(request_hook=None, num_retries=6, ca_certificates_file='/usr/local/lib/python2.7/dist-packages/boto/cacerts/cacerts.txt', _provider_type='aws', http_unretryable_exceptions=[<type at remote 0x19c6520>], https_connection_factory=None, is_secure=True, protocol='https', port=443, _connection=(u's3-us-west-2.amazonaws.com', 443, True), _auth_handler=<HmacAuthV1Handler(_hmac_256=None, host=u's3-us-west-2.amazonaws.com', _hmac=<HMAC(digest_cons=<built-in function openssl_sha1>, outer=<_hashlib.HASH at remote 0x7fb4ee2601c0>, inner=<_hashlib.HASH at remote 0x7fb4ee2604e0>, digest_size=20L) at remote 0x7fb4ee2f5ab8>, _provider=<Provider(acl_header='x-amz-acl', server_side_encryption_header='x-amz-server-side-encryption', copy_...(truncated)
    return cls._unpickle(userModule, fileHandle, jobStore.config)

That's not good, let me know what you discover.
Either way we solve this, IMO the fix should include a way to ensure we don't reintroduce the bug in the future. That might be harder if the solution is to abandon stream unpickling entirely.

Ah, crap, sorry, this is my bad--I didn't check the AWS large-jobs patch that we applied to our branch. It contains a cPickle.dumps without HIGHEST_PROTOCOL. That should've been the first thing I checked!
That said, it looks like the check_cpickle makefile target isn't catching it properly--the recursive grep call isn't quite right. Will submit a quick PR.


Changes towards modularity

changes in favor of explicit dependencies, i.e. require raphael and lodash
support of webpack work flow
include fixes of issues for latest lodash 4.0
build using webpack instead of preprocessor

@bramp this PR is ready to merge, please consider to merge it and publish the package on npm.

I would like to see this as well. Both removing the dependency and adding npm.

I agree. Very nice, modern setup.
Small addition, in devserver.js the static middleware must be placed after the webpack-middleware.
Otherwise you'll break up dev-mode, if there's a build\sequence-diagram.js on the disk.
So put
app.use(express.static(process.cwd()));

after:
app.use(require('webpack-dev-middleware')(compiler, {
    noInfo: true,
    publicPath: config.output.publicPath,
}));

app.use(require('webpack-hot-middleware')(compiler));

@wollnyst thanks for tip about dev-mode, fixed!

include fixes of issues for latest lodash 4.0

Would be great if you included this PR agnostic of the other changes, ref https://github.com/bramp/js-sequence-diagrams/issues/158

has this been effort been abandoned?


Reacting on GitHub events from a repository not containing brigade.js

Hi, thanks for maintaining this 👍
To react events from GitHub, brigade seems to require a brigade.js in the root of each GitHub repository. This is slightly problematic to me because then I need to copy-paste or maintain a set of exactly same brigade.js across various projects.
So, I'd wanted to prepare a "default" brigade.js which is used when the repository which has emitted a github/brigade event misses its own brigade.js, so that I don't need this copy-pasting.
However, as far as I understand, brigade's GitHub-integration as of today seems to not allow this use-case out-of-box as the GitHub gateway expects the repo emitted the event has a brigade.js in the repository root and there is not way to inject brigade.js from an another source.
It seems like I can write my own brigade gateway based on the brigade's default gh gateway, which would load a default brigade.js from perhaps a global k8s secret containing it rather than the repo corresponds to the event coming from the gh gateway.
// My understanding behind this idea is that I could create a k8s secret representing a build which accepts an arbitrary "Script" to be executed by brigade, right?
But anyway, would it make sense it to support this use-case in the default GitHub gateway included in brigade? If so, any guidance/suggestion on how we should design it/other related use-cases should be covered together/etc.?

@cjhpaul Not yet, at least on my side. Would you mind sharing your use-cases so that we can shape the design? Thanks.

@mumoshu I was just thinking of a brigade project not associated with a git repository. At this point, the only option is to include a script content in an event every time it's sent.

@cjhpaul Thanks for sharing. Yeah, seems like so. Does that option work for you?
In my use-case, what I need is a default brigade.js used when brigade-github-gateway misses a brigade.js in the git repo/commit corresponds to a webhook event.
Creating a custom github gateway which picks a default brigade.js and include it in every event would definitely work for me.
However, in my understanding, that's exactly how an "officialish" github-gateway with support for the default brigade.js would look like 😄


main to live

Docs Build status updates of commit 1fdd0d3:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Advertising/bingads-13/bulk-service/experiment.md
:bulb:Suggestion

Details

Advertising/bingads-13/campaign-management-service/conversiongoalcategory.md
:bulb:Suggestion

Details

Advertising/bingads-13/guides/authentication-oauth.md
:bulb:Suggestion

Details

Advertising/bingads-13/guides/labels.md
:bulb:Suggestion

Details

.openpublishing.publish.config.json
:white_check_mark:Succeeded

Advertising/bingads-13/bulk-service/account-filter-link-ad-extension.md
:white_check_mark:Succeeded

Advertising/bingads-13/bulk-service/account-structured-snippet-ad-extension.md
:white_check_mark:Succeeded

Advertising/bingads-13/bulk-service/ad-group-filter-link-ad-extension.md
:white_check_mark:Succeeded

Advertising/bingads-13/bulk-service/ad-group.md
:white_check_mark:Succeeded

Advertising/bingads-13/bulk-service/campaign-daytime-criterion.md
:white_check_mark:Succeeded

Advertising/bingads-13/bulk-service/campaign-filter-link-ad-extension.md
:white_check_mark:Succeeded

Advertising/bingads-13/bulk-service/combined-list.md
:white_check_mark:Succeeded

Advertising/bingads-13/bulk-service/downloadentity.md
:white_check_mark:Succeeded

Advertising/bingads-13/bulk-service/feed-item.md
:white_check_mark:Succeeded

Advertising/bingads-13/bulk-service/feed.md
:white_check_mark:Succeeded

Advertising/bingads-13/bulk-service/filter-link-ad-extension.md
:white_check_mark:Succeeded

Advertising/bingads-13/bulk-service/image.md
:white_check_mark:Succeeded

Advertising/bingads-13/bulk-service/offline-conversion.md
:white_check_mark:Succeeded

Advertising/bingads-13/bulk-service/structured-snippet-ad-extension.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addadextensions.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addadgroupcriterions.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addadgroups.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addads.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addaudiences.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addbudgets.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addcampaigncriterions.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addcampaigns.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addconversiongoals.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addexperiments.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addimportjobs.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addkeywords.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addlabels.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addlistitemstosharedlist.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addnegativekeywordstoentities.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addsharedentity.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/adduettags.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/adgroup.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/appealeditorialrejections.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/appinstallgoal.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/applyofflineconversionadjustments.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/applyofflineconversions.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/applyproductpartitionactions.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/campaign-management-data-objects.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/campaign-management-value-sets.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/combinationrule.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/combinedlist.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/conversiongoal.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/conversiongoaladditionalfield.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/daytimecriterion.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/deleteadextensions.md
:white_check_mark:Succeeded

This comment lists only the first 50 files in the pull request.

Advertising/bingads-13/bulk-service/experiment.md

Line 7, Column 14: [Suggestion-duplicate-descriptions] Attribute 'description' with value 'Defines an experiment where you split a campaign's budget and traffic, and then run an A/B test during a limited date range.' is duplicated in 'bingads-13/bulk-service/experiment.md(7,14)', 'bingads-13/campaign-management-service/experiment.md(7,14)'. NOTE: This Suggestion will become a Warning in late October, 2020.

Advertising/bingads-13/campaign-management-service/conversiongoalcategory.md

Line 7, Column 14: [Suggestion-duplicate-descriptions] Attribute 'description' with value 'Reserved.' is duplicated in 'bingads-13/campaign-management-service/adextensionheadertype.md(7,14)', 'bingads-13/campaign-management-service/conversiongoalcategory.md(7,14)'. NOTE: This Suggestion will become a Warning in late October, 2020.

Advertising/bingads-13/guides/authentication-oauth.md

Line 7, Column 14: [Suggestion-duplicate-descriptions] Attribute 'description' with value 'Authenticate for Bing Ads API using OAuth.' is duplicated in 'bingads-13/guides/authentication-oauth-live-connect.md(7,14)', 'bingads-13/guides/authentication-oauth.md(7,14)'. NOTE: This Suggestion will become a Warning in late October, 2020.

Advertising/bingads-13/guides/labels.md

Line 7, Column 14: [Suggestion-duplicate-descriptions] Attribute 'description' with value 'Labels let you organize campaigns, ad groups, ads, and keywords into groups based on whatever is important to you.' is duplicated in 'bingads-13/campaign-management-service/label.md(7,14)', 'bingads-13/guides/labels.md(7,14)'. NOTE: This Suggestion will become a Warning in late October, 2020.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


chore: add saved search/-es to PageOwnerType

The type of this PR is: Chore

Description
Add OwnerType.savedSearch and OwnerType.savedSearches to PageOwnerType

PR Checklist (tick all before merging)

[ ] If I've added a new file to the tree I've exported it from the common index.ts
[ ] I've added comments with examples for any new interfaces and ensured that they're in the docs
[x] No platform-specific terminology has been used outside of click and tap (platform is inferred by the DB storing events)

:rocket: PR was released in v4.40.0 :rocket:


Unreleased locks when Resque terminates using the loner option

Hi guys,
I've found an odd behaviour when using the loner option, where unreleased locks (without timeout) can be stuck in Redis after a process termination occurs while Resque is enqueueing a job (Heroku deploy environment).
After taking a look at the code, I guess the issue is that the lock is being acquired during a before_enqueue hook, which, during a process termination, can complete successfully while the actual Resque enqueue operation doesn't (it's not transactional from what I know). After this, no new process can actually enqueue a similar job for execution as the lock is already in Redis, and subsequent jobs of the same kind will be inhibited forever.
I was wondering if a possible strategy to handle this situation could be done using a two-phase process where an after_enqueue hook could be used to finally acquire the lock after the actual job enqueue operation completed.

Hey @tjsousa
I don't use loner myself, so its difficult for me to judge how this should be played out.
When the process is terminated and it gets 'stuck', do you know HOW its killed?
I'd love to see a PR on how this could be fixed :)
Or we can discuss it some more here and figure out a way together.

Hi
See my reply to another issue (which is pretty much the same behaviour you describe here):
https://github.com/lantins/resque-lock-timeout/issues/17
Hope that helps.

Thank you @edjames !
Although I have worked around this problem, it actually still persists. Looking at #17, my particular scenario does not use a hash as a parameter, so I'm not sure it has a common cause.
@lantins Answering your question, I know it happens when our app running in Heroku sends KILL signals to our Resque processes, although I wasn't able to pin-point the exact cause (as it only happens sometimes).

This reminds me of this issue: https://github.com/lantins/resque-retry/pull/61

@lantins, thanks to that share I was finally able to dedicate some time in replicating the issue and, in fact, was able to confirm the lack of lock removal in the case of a dirty exit (e.g. SIGKILL in the child job).
Using a similar approach, we can do the lock cleanup from the worker process through a on_failure hook.


Set Target to Min/Max value when progress is lower

When scrolling to fast on iPhone the objects not ready go all the way to max/min value.
So if progress < min we can set the target value to from and progress >= max we set the target value to to.
This solves the problem and makes the animation run smoothly.

Hello!
Thanks for the merge.
Can you please release this as an new update to nuget?


HDDS-10723. Trigger native check in more cases

What changes were proposed in this pull request?
native check should not be skipped for changes in:

root POM
dependencies
junit.sh

https://issues.apache.org/jira/browse/HDDS-10723
How was this patch tested?
Updated bats test.
CI:
https://github.com/adoroszlai/ozone/actions/runs/8764188350

Thanks @smengcl for the review.


Update android-apt version

Not an essential change but best to keep the documentation up-to-date.

I'm gonna check it and merge. Thx.
android-apt 1.7 released


👷 Try to simplify build.yml

For whatever reason, this one ran 30 min, the other PR only ran 22 min.


Test updates

This PR addresses #14.

I tweaked the added place tests to test the additional node for both Before and After.  While it doesn't test any additional code branches for Before, it's simpler to follow for both and seems like it makes enough sense to test on principle anyway.
This brings our dom module tests to very close to 100% coverage (all but branches are already there).  Woo!


learnyoumongo install errors

learnyoumongo displays errors (below) during install. Reran with sudo ... but still same errors.
Being a nuub it's largely gobbledy-gook to me.
learnyoumongo seems to run ok so soldiering on.
knik:~/workspace $ npm install learnyoumongo -g
npm WARN peerDependencies The peer dependency<EMAIL_ADDRESS>included from mongodb-core will no
npm WARN peerDependencies longer be automatically installed to fulfill the peerDependency
npm WARN peerDependencies in npm 3+. Your application will need to depend on it explicitly.
\
><EMAIL_ADDRESS>install /home/ubuntu/.nvm/versions/node/v4.1.1/lib/node_modules/learnyoumongo/node_modules/mongodb/node_modules/kerberos
> (node-gyp rebuild) || (exit 0)

make: Entering directory `/home/ubuntu/.nvm/versions/node/v4.1.1/lib/node_modules/learnyoumongo/node_modules/mongodb/node_modules/kerberos/build'
  CXX(target) Release/obj.target/kerberos/lib/kerberos.o
  CXX(target) Release/obj.target/kerberos/lib/worker.o
  CC(target) Release/obj.target/kerberos/lib/kerberosgss.o
../lib/kerberosgss.c:36:0: warning: ignoring #pragma clang diagnostic [-Wunknown-pragmas]
 #pragma clang diagnostic push
 ^
../lib/kerberosgss.c:37:0: warning: ignoring #pragma clang diagnostic [-Wunknown-pragmas]
 #pragma clang diagnostic ignored "-Wdeprecated-declarations"
 ^
../lib/kerberosgss.c: In function ‘authenticate_gss_client_wrap’:
../lib/kerberosgss.c:362:19: warning: variable ‘server_conf_flags’ set but not used [-Wunused-but-set-variable]
   char buf[4096], server_conf_flags;
                   ^
../lib/kerberosgss.c: At top level:
../lib/kerberosgss.c:930:0: warning: ignoring #pragma clang diagnostic [-Wunknown-pragmas]
 #pragma clang diagnostic pop
 ^
  CC(target) Release/obj.target/kerberos/lib/base64.o
  CXX(target) Release/obj.target/kerberos/lib/kerberos_context.o
  SOLINK_MODULE(target) Release/obj.target/kerberos.node
/usr/bin/ld: cannot find -lkrb5
/usr/bin/ld: cannot find -lgssapi_krb5
collect2: error: ld returned 1 exit status
make: *** [Release/obj.target/kerberos.node] Error 1
make: Leaving directory `/home/ubuntu/.nvm/versions/node/v4.1.1/lib/node_modules/learnyoumongo/node_modules/mongodb/node_modules/kerberos/build'
gyp ERR! build error
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/home/ubuntu/.nvm/versions/node/v4.1.1/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:270:23)
gyp ERR! stack     at emitTwo (events.js:87:13)
gyp ERR! stack     at ChildProcess.emit (events.js:172:7)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:200:12)
gyp ERR!    Despite all of the errors it still looks like it installed.
You're running on a local dev environment, rather than on C9?

I'm using C9.
I did say it seemed to be working so I was continuing.
All db's listed as (empty) except local, which doesn't have a parrots collection.
The original download instruction was to import the data perhaps? This isn't the place for another question, struggling forwards :)

learnyoumongo actually puts the collection in place only while you're running, the removes it as soon as its done.  You can run learnyoumongo test <scriptname> to run it under test conditions without the verify step, if I remember correctly.

This is normal behaviour for learnyoumongo and kerberos build errors are not uncommon and can be ignored unless you are using kerberos (most mongo DBs are not). Closing as not an issue. Further issues with learnyoumongo should be filed on their repo. Thanks and happy coding!

thanx for the feedback guys. Checked their issues and it seems this is up in the air atm.
FYI I've tried learnyoumongo with test, run and verify but no luck. There is also a suggestion of redoing steps 1 and 2 but no luck there either.


query tests: add max and min to segment metadata query results

because of https://github.com/druid-io/druid/pull/2208

:+1:


Could you add a transparent background option like this: let g:aurora_transparent = 'true'

Default terminal looks good to me

Using kitty...

Which kitty theme can make it transparent?

I think it comes with Kitty setup, not the color scheme

But the default setup seems can not make this theme transparent?
The background_opacity setup also will not effect the nvim theme transparency.
The author of Kitty mentioned here: https://github.com/dracula/vim/issues/284#issuecomment-1086532742:

In kitty the background color is made transparent if it is the same as the terminals background color. In alacritty, the background color is made transparent only if there is no background color set. In typical vim color themes, the normal background is set explicitly to a color instead of remaining unset (which is bad for performance, but that's another issue). So since the normal background is set, alacritty wont make it transparent, but kitty will, assuming the color is the same as the terminal's background color.

So how do you achieve the result of your screenshot is interesting.

Ok, I was wrong.
I have this in my setup
  vim.cmd("hi Normal guibg=NONE ctermbg=NONE") -- remove background
  vim.cmd("hi EndOfBuffer guibg=NONE ctermbg=NONE") -- remove background

Those will remove background. It was not kitty

@peleusj Would you check if latest version works for you?

Sorry for the delay.
It works perfect.
Thanks for your work!

And I hava a little problem.
Each cmp compeltion item's document is not transparent when colorscheme's transparent is on.
Not sure if it is setttings of colorscheme or cmp itself.

Not 100% sure, because my cmp popup is transparent.

Yes, I test again, it is transparent. May be it is the background color too black and I did not discover it.


Add husky pre-commit hook

This PR adds a Husky as promised here.
The hook runs tslint --fix against all staged files before allowing a commit to be processed (if tslint cannot fix the issues in the staged file then the commit will not proceed).
I initially could not get tests to run from the command line inside of the devcontainer. There are further changes required to get that part of the hook to run and I felt that stopping here and asking the question as to whether or not it is desirable to run the tests in the pre-commit hook would be the best way to proceed.
I looked into the contributing.md and did not see any need to mention the new hook. I have however added the prepare script to the devcontainer so that the hooks are installed after it is built. Again, happy to change if you see things differently 👍🏻.
LMK if you would like to see any changes or additions to this PR 👍🏻. Happy to raise a follow up to add the tests in, if desired.

I have managed to get the tests running headless from the command line inside the container using the recommendations for setting up a Gitlab CI. I am pretty sure that I could get test running in the pre-commit hook for both container and non-container dev.
@ryanluker WDYT? Is there enough value in me adding the test suite into the pre-commit hook?

@mattseddon Thanks for the PR on the pre-commit hook!
I am not sure if we want the tests to run with each commit as that might prove pretty long time wise eventually and reduce the developer feedback loop. I think the CICD run is good enough when someone opens up a PR. I also had to disable the tests for the linux CI pipeline as it had issues running in github actions 🤔. Your vscode link to the CI documentation might give us some insight into if we can re-enable linux CI testing though.
https://code.visualstudio.com/api/working-with-extensions/continuous-integration#gitlab-ci
https://github.com/ryanluker/vscode-coverage-gutters/runs/2214395226?check_suite_focus=true

@mattseddon Thanks for the PR on the pre-commit hook!
I am not sure if we want the tests to run with each commit as that might prove pretty long time wise eventually and reduce the developer feedback loop. I think the CICD run is good enough when someone opens up a PR. I also had to disable the tests for the linux CI pipeline as it had issues running in github actions 🤔. Your vscode link to the CI documentation might give us some insight into if we can re-enable linux CI testing though.
https://code.visualstudio.com/api/working-with-extensions/continuous-integration#gitlab-ci
https://github.com/ryanluker/vscode-coverage-gutters/runs/2214395226?check_suite_focus=true

@ryanluker no worries, I am happy to leave tests out of the hook.
I have pinned the new dependencies as requested.
I'll look into fixing up the linux test suite (devcontainer / CI/CD pipeline) next weekend 👍🏻.

@mattseddon Thanks a ton for the contributions!

@mattseddon Just used husky locally for a PR I am working on went well!
I needed to do a clean npm install though as husky tried to run in the prepare but it wasn't installed yet 🤔 .

@mattseddon Just used husky locally for a PR I am working on went well!
I needed to do a clean npm install though as husky tried to run in the prepare but it wasn't installed yet 🤔 .

😢 that's always the way with adding new dependencies. Sorry.

@mattseddon haha no need to feel sorry, I have had this happen at work a bit when adding new pre-commit type stuff so I was just wondering if it was expected.


Using this library for vanishing

Is it possible to make a vanish mod using this library that completely hides the player (see #26) but doesn't replace them with something else?
I ask because vanishing is pretty similar to disguising, and this library already lives in that space, so it wouldn't be too much of a scope increase if you do choose to start supporting it.

It's not really similar, it's pretty different and you can't really use it for that

It's not really similar, it's pretty different and you can't really use it for that

Curious; why is it not similar? Because only certain players have the vanished entity hidden?

You could disguise player as an "empty item", but there are better ways to handle vanishing imho.

You could disguise player as an "empty item", but there are better ways to handle vanishing imho.

Yeah, because people would still be able to see the empty item entity - it would still have a shadow iirc among other things.


Add init RTE on load option (false by default)

#95

Seems useful, could you

add documentation describing this option to README.md
remove the files changed in dist folder. See #98


Fix incorrect bookmark for "Thread Functions" in document "Process and Thread Functions"

@SweetIceLolly : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off


Not compatible with latest raylib

I stumbled across this library for a project I'm working on. It seems amazing for what I need (I'm trying to find an easy, simple graphics library for drawing lines and text). I didn't use plain raylib though because DrawTriangleStrip wasn't working, so I went ahead and set this up with the latest raylib.h.
The error:
......../raylibStuff/rturtle.c:2924:8: error: initializing 'Image' (aka 'struct Image') with an expression of incompatible type 'int'
Image image = LoadImage(filename);
^       ~~~~~~~~~~~~~~~~~~~
1 error generated

Not sure how your project is organized. It seems that rturtle.h or raylib.h is not found by the compiler while compiling rturtle.c.

Not sure how your project is organized. It seems that rturtle.h or raylib.h is not found by the compiler while compiling rturtle.c.


systemd::timer: fix before's argument to use the proper syntax

I was reading the code and vim wouldn't highlight that line properly...

What I'm also surprised about is that the unit tests didn't catch this.

I'm not up to date on how Puppet (and rspec) evaluates manifests theses days. I vaguely remember that at some point it stopped doing a random order to switch to the more natural top to bottom order. But maybe I am misremembering.

Yikes. We obviously has an acceptance test coverage problem.

The fixed will be included in the #317 release.

I recall that Puppet was case insensitive about some of these matters (pretty sure that was true for type aliases), but then not all tooling understands that. So it may be valid, but not the preferred style. Personally I think there should just be a single valid style and enforce that

I'm not up to date on how Puppet (and rspec) evaluates manifests theses days. I vaguely remember that at some point it stopped doing a random order to switch to the more natural top to bottom order. But maybe I am misremembering.

The ordering  parameter was removed in Puppet 6.0 and is now always top to bottom unless there's explicit ordering. That said, I'm fairly certain the implementation doesn't create actual relationships in the resource graph, so rspec puppet wouldn't see these. I'm guessing it's just a case insensitivity thing in Puppet.


Added AzureAttributes optional parameter to New-DatabricksCluster

This allows to create clusters with specific AzureAttributes, enabling among others, support for Spot Instances, and solving #166
Tests to cover this new feature were added as well.
Updated tests' cluster version to 7.3 LTS, instead of 5.5 that might be deprecated soon.

/azp run

Many thanks for this!


Record failure to find missing DOI

I went back and forth on how to accomplish the behavior that I think that want here. Ultimately I think that the list should continue to behave the way that it currently does and only show publications with doi_verified: false, and the DOI verification job should set the flag to false if the publication doesn't have a DOI and the job couldn't find one - that way, every publication that comes out of the automated DOI check should have the verified flag set to either true or false.

Yup, I agree.  This looks good, I just pushed up some rubocop fixes.  I'll merge when CI passes, thanks!


Swift 5.5.2 or Xcode 13.2 required for Concurrency backward compatibility

Which package(s) are showing incorrect data?

https://swiftpackageindex.com/chris-araman/AsyncCloudKit

Please explain what data is incorrect and what you expected to see
Swift's async/await concurrency keywords were introduced in Swift 5.5 (Xcode 13), but required the 2021 OS releases (macOS 12, iOS 15, etc.). Apple later released Swift 5.5.2 and Xcode 13.2 which brought backward compatibility to the 2019 OS releases (macOS 10.15, iOS 13, etc.).
AsyncCloudKit provides async extension methods for CloudKit. Its Package.swift declares support for macOS 10.15, iOS 13, etc. However, it requires Swift 5.5.2 (or Xcode 13.2) or later in order to build for those minimum targets. With Swift 5.5 (or Xcode 13), it can be compiled only for macOS 12, iOS 15, or later.
SwiftPackageIndex doesn't yet seem to build using Swift 5.5.2 or Xcode 13.2, so the compatibility report for AsyncCloudKit is empty.
I suspect the maintainers haven't yet found time to update to Xcode 13.2(.1), but I wanted to call out this issue specifically as it would affect any packages using Concurrency with platforms older than 2021.
If the problem relates to the compatibility matrix, does it apply to specific builds?
The problem applies to all builds on Apple platforms. Linux is not supported by AsyncCloudKit because CloudKit is not generally available on Linux.

I suspect the maintainers haven't yet found time to update to Xcode 13.2(.1), but I wanted to call out this issue specifically as it would affect any packages using Concurrency with platforms older than 2021.

Yes, indeed. The build system is currently using Xcode 13.1 and the swift:5.5 docker label to build packages.
Thanks for flagging this. The concurrency back port has created a bit of urgency for us to bump the Swift version once again.

Builder PR: https://gitlab.com/finestructure/swiftpackageindex-builder/-/merge_requests/87

Thanks!


Publish 01/21/2022, 10:30 AM

Docs Build status updates of commit df7b13e:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

skype/skype-ps/skype/Get-CsOnlineUser.md
:bulb:Suggestion
View (skype-ps)
Details

skype/skype-ps/skype/Get-CsOnlineDialInConferencingUser.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Get-CsOnlineVoiceUser.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Set-CsTeamsCallingPolicy.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Set-CsTenantFederationConfiguration.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Get-CsOnlineUser.md

Line 0, Column 0: [Suggestion: disallowed-html-tag - See documentation] HTML tag 'some-xml-string' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit be2504b:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

skype/skype-ps/skype/Get-CsOnlineUser.md
:bulb:Suggestion
View (skype-ps)
Details

exchange/exchange-ps/exchange/Set-TransportRule.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/exchange.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/mapping/serviceMapping.json
:white_check_mark:Succeeded

skype/skype-ps/skype/Get-CsOnlineDialInConferencingUser.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Get-CsOnlineVoiceUser.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Set-CsTeamsCallingPolicy.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Set-CsTenantFederationConfiguration.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Get-CsOnlineUser.md

Line 0, Column 0: [Suggestion: disallowed-html-tag - See documentation] HTML tag 'some-xml-string' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit e44734d:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

skype/skype-ps/skype/Get-CsOnlineUser.md
:bulb:Suggestion
View (skype-ps)
Details

exchange/exchange-ps/exchange/Set-TransportRule.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Start-HistoricalSearch.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/exchange.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/mapping/serviceMapping.json
:white_check_mark:Succeeded

skype/skype-ps/skype/Get-CsOnlineDialInConferencingUser.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Get-CsOnlineVoiceUser.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Set-CsTeamsCallingPolicy.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Set-CsTenantFederationConfiguration.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Get-CsOnlineUser.md

Line 0, Column 0: [Suggestion: disallowed-html-tag - See documentation] HTML tag 'some-xml-string' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 56e1b5c:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

skype/skype-ps/skype/Get-CsOnlineUser.md
:bulb:Suggestion
View (skype-ps)
Details

exchange/exchange-ps/exchange/Set-CalendarProcessing.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Set-TransportRule.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Start-HistoricalSearch.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/exchange.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/mapping/serviceMapping.json
:white_check_mark:Succeeded

skype/skype-ps/skype/Get-CsOnlineDialInConferencingUser.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Get-CsOnlineVoiceUser.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Set-CsTeamsCallingPolicy.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Set-CsTenantFederationConfiguration.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Get-CsOnlineUser.md

Line 0, Column 0: [Suggestion: disallowed-html-tag - See documentation] HTML tag 'some-xml-string' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


adding new access-status-list-element-badge css classes

References

Fixes #2402

Description
This PR adds CSS classes to access-status-badge component in order to make possible to differentiate access status based on the value itself.
Instructions for Reviewers
In order to test it you need to activate in your angular configuration:
# Item Config
item:
  showAccessStatuses: true

and for Items and Publications (if you use Entities), inspect the access status value, like: "Open Access" and you should see something like:
Open Access

List of changes in this PR:

We just changed the HTML part of the component and replace "." with "-" of the accessStatus value.

@artlowel I think I changed it in the way you suggested. I've also added an empty scss file, but without specifying anything. I think we all don't have a clear idea what access status should look like and you can confirm that on the issue discussion page (https://github.com/DSpace/dspace-angular/issues/2402).
We are currently working in a custom theme that will address this, when finished, if all agree, we can proposed it to be the default. It will be something like:

and

We are currently working in a custom theme that will address this, when finished, if all agree, we can proposed it to be the default. It will be something like:

and

I like the way that looks


dotnet watch does not reload views on disk

Describe the bug
When running 'dotnet watch run' on MacOSX views on disk doesn't get served when they are updated.
Have added this as suggested in other bug reports and stackoverflow replies without any luck.
I have no views compiled into a dll of any kind.
<PropertyGroup>
    <RazorCompileOnBuild>false</RazorCompileOnBuild>
    <RazorCompileOnPublish>false</RazorCompileOnPublish>
   <MvcRazorCompileOnPublish>false</MvcRazorCompileOnPublish>
</PropertyGroup>

To Reproduce
Steps to reproduce the behavior:

Using ASP.NET Core 2.2.104 on MacOSX 10.12.6

Expected behavior
To be able to see the updated views without having to restart the process

Same on Windows. I have to restart the debugger each time I update a view or a razor page. It's really time consuming.

In ASP.NET Core 2.2, the default behavior of razor and views is that .cshtml should be re-compiled at runtime without restarting the process. MVC has its own file watcher on *.cshtml files and should be refreshing views when the .cshtml changes. For this reason, dotnet-watch does not restart when *.cshtml files change.
cc @mkArtakMSFT @pranavkm

Starting in 3.0, runtime compilation is not enabled by default and we compile views and pages as part of the normal build. We should update all of our auto-build experiences to build .cshtml and .razor files by default, and then have some way for runtime compilation to disable auto-build for .cshtml if runtime compilation is enabled.

@natemcmaster correctly pointed out this is an issue with 2.2. In 2.2, runtime compilation works in tandem with build time compilation and these changes should get picked. However, you could give the file watcher an additional nudge by setting DOTNET_USE_POLLING_FILE_WATCHER in case the dotnet file watcher is having trouble. See https://github.com/aspnet/Mvc/issues/7028#issuecomment-342217586.

One more thing, if you want to customize the behavior of dotnet-watch to include *.cshtml files, you can do that by customizing your project file. See https://docs.microsoft.com/en-us/aspnet/core/tutorials/dotnet-watch?view=aspnetcore-2.2#customize-files-list-to-watch


Fixed exception being by NACL thrown due to seed encoding not being in bytes.

Codecov Report

Merging #121 into master will not change coverage.
The diff coverage is 0%.

@@          Coverage Diff          @@
##           master   #121   +/-   ##
=====================================
  Coverage      89%    89%
=====================================
  Files          15     15
  Lines         828    828
=====================================
  Hits          737    737
  Misses         91     91

Yup, I can do that. Just noticed a very silly thing, since bytes string is decoded using RawEncoder, behaviour is actually the same, but I think we should still keep it for consistency and to make it clear the types being passed if it makes sense. I will add the test

@excerebrose Thanks for adding the test. Did you want to add any other commits, or can we merge this pull request now?

You can merge it for this one. Thanks :)
On Fri, 9 Nov 2018, 7:57 pm Troy McConaghy<EMAIL_ADDRESS>wrote:

@excerebrose https://github.com/excerebrose Thanks for adding the test.
Did you want to add any other commits, or can we merge this pull request
now?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/bigchaindb/cryptoconditions/pull/121#issuecomment-437477563,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJ3MLItex6K0Fa05TCne_260KuoN5q8iks5utd4kgaJpZM4YWzp4
.


Detroit - Missing Label

Notes
listing.applicationProcess should be Application Details

QA Notes:
Start here: https://detroit-partners-dev.netlify.app/

Sign in and click "add a listing"
The tabs should look like the screenshot below:

LGTM


First Contribution by Linda Njau.

Name: Linda Njau.
Project Assigned: ESLint
Link to Governance model
GOVERNANCE MODEL OF ESLint.
The governance model of ESLint is based on a community-driven approach where anyone can contribute to the project in various ways, such as submitting code, participating in discussions, making suggestions, or providing moral support.
Based on the information available on ESLint's governance model, some of the core principles that can be deduced are:
Transparency: The governance model is designed to be transparent, which means that all decisions made by the ESLint team are documented and available for public scrutiny.
Community participation: The governance model encourages participation from the ESLint community. This means that contributors are welcome to voice their opinions and make suggestions for the future direction of the project.
Collaborative decision-making: Decisions are made collaboratively through a consensus-based approach. This means that all contributors have an equal say in decisions, and the team works to find a solution that is acceptable to everyone.
Maintainer accountability: Maintainers are held accountable for their decisions and actions. This means that if a maintainer makes a decision that is not in the best interest of the project, they can be held accountable by the community.
Technical excellence: The governance model prioritizes technical excellence. This means that decisions are made based on what is best for the project technically, rather than based on personal opinions or agendas.
Overall, ESLint's governance model prioritizes transparency, community participation, collaborative decision-making, maintainer accountability, and technical excellence.
PROJECT ROLES
1.Maintainers: They are responsible for the overall direction and development of the project, reviewing and merging pull requests, and managing releases.
2.Collaborators: They have write access to the project's codebase and assist maintainers with reviewing and merging pull requests.
3.Contributors: They are community members who contribute code, documentation, or other resources to the project.
4.Users: They are individuals or organizations who use ESLint in their projects and provide feedback to the project team.
DECISION-MAKING PROCESS
ESLint governance model uses a consensus-seeking decision-making process, which is similar to formal consensus but with the additional option of a fallback voting procedure if consensus appears unattainable during the deliberations. The fallback voting option is only exercised after all reasonable attempts to address concerns have been exhausted. When consensus is deemed unattainable, the presenter or the facilitator can choose the closing option of a fallback vote.
EASE OF FINDING THE GOVERNANCE MODEL.
Finding the ESLint governance model is relatively easy. The website has a header section with a link to Docs. Clicking on this link takes you to the project documentation. Under Contributing to ESLint in the side panel, there is a link to Governance. Although it takes a few minutes to locate, the documentation is clear, concise, and easy for anyone to understand.

@arliss-NF
Looking forward to your feedback.

@Linda-Njau
Hi Linda, thank you for your contribution! I'm so glad you were able to find the governance model with minimal effort. Great work, looking forward to seeing your second contribution.


Refactor: Update python dependencies parsing logic.

Refactor: Update python dependencies parsing logic. Removed testing dependencies columns.
https://openedx.atlassian.net/browse/BOM-2535
I have removed the pypi column because pypi_all shows the same stats.

This solves the immediate problem in BOM-2535, but is a regression from BOM-2478 in that it no longer has a way to identify just the production dependencies.  We don't really need to separate testing from development dependencies as far as I know, but it can be useful to have one list of just the production dependencies and another for all dependencies (production, testing, development, etc.)  If you can quickly add back the pypi check with just the production dependencies while keeping the new pypi_all check as you have it here, please do so.  Otherwise, let's merge this and ticket adding back the other check separately.


added keys to return values of from_texts redis method

In order to be able to delete the entries in the Redis database again, you need the keys/ids of the individual entries. These are already returned in the add_texts, but ignored in the from_texts.

since this seems like a pretty Redis specific change at the moment would it be better to just add a method to Redis (e.g. from_texts_return_keys) instead of changing base class signature?

Hey @dev2049 good point.
I've added the methods and reverted the signature of the base class.


Fix Docker for native: Keycloak and SQL databases

Fixes https://github.com/jhipster/generator-jhipster-quarkus/issues/251.

Closing in favor of #252.


ACL Question - Probably wrong place

Thanks for the acl update.
Is there a way to configure reading some topics and writing others.
Other than this (this works):

{
  "username": "test",
  "password": "test",
  "readonly": false,
  "topics": [
    "home/test/state/#"
  ]
},
{
  "username": "test",
  "password": "test",
  "readonly": true,
  "topics": [
    "home/test/command/#"
  ]
}

With the simple configuration you can do there it's not possible other than the way you are showing here, and I do not see a clean way of doing this not sure how many would need it 🤷♂

Another way you can do this is by using a custom configuration.
https://github.com/hassio-addons/addon-mqtt#custom-configuration


Merge develop to master

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.5 out of 6 committers have signed the CLA.:white_check_mark: vickenliu:white_check_mark: hejkerooo:white_check_mark: nadia-adila:white_check_mark: royki:white_check_mark: Timtech4u:x: kim-energywebYou have signed the CLA already but the status is still pending? Let us recheck it.


Update dependencies

Desired Outcome
Remove as many dependencies on gopkg.in/yaml.v3 older than 3.0.1 as possible.
Implemented Changes
Updates direct dependencies in bin/juxtaposer/go.mod and go.mod.
Connected Issue/Story
CyberArk internal issue: CONJSE-1376
Definition of Done
At least 1 todo must be completed in the sections below for the PR to be
merged.
Changelog

[X] The CHANGELOG has been updated, or
[ ] This PR does not include user-facing changes and doesn't require a
CHANGELOG update

Test coverage

[ ] This PR includes new unit and integration tests to go with the code
changes, or
[X] The changes in this PR do not require tests

Documentation

[ ] Docs (e.g. READMEs) were updated in this PR
[ ] A follow-up issue to update official docs has been filed here: insert issue ID
[X] This PR does not require updating any documentation

Behavior

[ ] This PR changes product behavior and has been reviewed by a PO, or
[ ] These changes are part of a larger initiative that will be reviewed later, or
[X] No behavior was changed with this PR

Security

[X] Security architect has reviewed the changes in this PR,
[ ] These changes are part of a larger initiative with a separate security review, or
[ ] There are no security aspects to these changes

Might as well wait on approving this - still need to add updates to conjur-authn-k8s-client and summon.


The title is Adonis Mail, i think i thouls be Adonis Antl. On github homepage

Title.

PR please? Issue will not help much


Fhevmjs fixes to work with local node

Tested with coprocessor, we need following adjustments:

types byte array must be made of one byte numbers, not more than 255, bit values like 2048 are too high, added encoding for fhevmjs type to node type enum
added 0x in front of input hex string to be sent as input payload

Added draft test with getting public key and encoding inputs, I think we might need to setup running container of the service to test the integration.
@immortal-tofu @jatZama

@david-zk when I said comment tests it was to make the CI pass :D Sorry if I wasn't clear enough :)


[Publishing] Youtube video Pub/Sub to BigTable template

Deck and transcript completed. Video creation needs to be started


Added OpenRA MiniYAML

@OpenRA uses its own niche YAML variant which causes problems. This adds support for it.
Description
The MiniYAML variant is older than the YAML standard, and it deviates a quite a bit. Most notably it uses tabs by default https://github.com/OpenRA/OpenRA/issues/2310 which GitHub started to mark as an error which leads to confusion. Attempts to change the file ending https://github.com/OpenRA/OpenRA/pull/13910 have failed. Using SaltStack .yaml turned out to be a workaround, but in https://github.com/OpenRA/OpenRA/pull/19850 we decided to fix this properly with our own parser.
Checklist:

[x] I am adding a new language.

[x] The extension of the new language is used in hundreds of repositories on GitHub.com.

Search results for each extension:

https://github.com/search?l=YAML&q=WorldInteractionController&type=Code

[x] I have included a real-world usage sample for all extensions added in this PR:

Sample source(s):

OpenRA Mod SDK MiniYAML
229Q.yaml

Sample license(s):

Public Domain
MIT

[x] I have included a syntax highlighting grammar: https://github-lightshow.herokuapp.com/?utf8=✓&scope=from-url&grammar_format=auto&grammar_url=https%3A%2F%2Fgithub.com%2FOpenRA%2Fatom-miniyaml%2Fblob%2Fmain%2Fgrammars%2Fminiyaml.cson&grammar_text=&code_source=from-url&code_url=https%3A%2F%2Fraw.githubusercontent.com%2FOpenRA%2FOpenRA%2Fbleed%2Fmods%2Fra%2Frules%2Fdefaults.yaml&code=
[x] I have updated the heuristics to distinguish my language from others using the same extension.

@lildude Looks good to merge to me. 👍


Request: Compatablility with Multi Token Status module

Is your feature request related to a problem? Please describe.
Compatibility with Multi Token Status so I can update the status for several tokens at once.
Describe the solution you'd like
Chain the wrapper for 'TokenHUD.prototype._onToggleEffect'? I'm basing this suggestion on the attached error below.
Describe alternatives you've considered
Author of Multi Token Status can do something?
Additional context
Here is a pic of the error

This isn't something I can reasonably do and have everything work. I already chain the wrapper if you toggle a non-CE, but if I chain while toggling a CE it causes the effect to be applied several times.


Getting Started silent on how to identify RBAC

In the Getting started it says "For a cluster that has RBAC enabled, use the following..." but it doesn't tell you how to find out if RBAC is enabled.

This issue has gone stale, we're on Knative now! Please reopen if still relevant.


DE - Validate Primary Health

Problem statement
Delaware requested that we validate Primary Health. They are concerned that the correct facilities were not being mapped to the correct locations in the HL7 messages.
What you need to know
Primary Health has a testing service that includes an application to assist in running testing at offsite locations. They will often be contracted by a company to run testing at a third party location. Example: a mcdonalds store wants to test all the employees. So they hire Primary to help with the testing. The testing is run at the hotel across the street. So the testing location is the hotel, the ordering facility is McDonalds and Primary is the test producer.
Another example that is more difficult. Quidel partners with Delaware Public Schools to run a school testing program. Quidel is running the test so they are the producer, the school is the testing location, but what facility is the ordering faciltiy?
Acceptance criteria

[ ] Determine facility mapping

Met with client and provided guidance on how to modify messages to contain information as expected by de-phd

Met with client and provided guidance on how to modify messages to contain information as expected by de-phd

Closing because we resolved on our part, we can create a new ticket if they contact us in the future.


Implement support for signbit

numba uses numpy implementation of signbit that is included in numpy RT library. However, numpy RT not available for omniscidb server.
Possible options:

implement signbit support using the signbit functions from math library
expose numpy RT to omniscidb server, it must not include any Python functions.bit.

The approach taken must be applicable for other functions that have similar implementations to signbit.

For ufuncs, we ought to replace the implementation on npy_mathimpl.py like we did for np.logaddexp and np.logaddexp2. The reason for this is that once the function is registered by Numba, it becomes impossible (without changing internals) to replace the implementation. So, on npy_mathimpl.py we change the implementation that Numba will use.
https://github.com/xnd-project/rbc/blob/8d576bddb5778f40f521ab1362b07112edae24f2/rbc/npy_mathimpl.py#L73-L85

For ufuncs, we ought to replace the implementation on npy_mathimpl.py ...

Does it break numba?

For ufuncs, we ought to replace the implementation on npy_mathimpl.py ...

Does it break numba?

No, but the NumPy implementation may be more precise than ours. For instance, consider the implementation for np.nextafter:
https://github.com/numpy/numpy/blob/6d4895cc9fe614cf3164891b1f502453312f64ca/numpy/core/src/npymath/ieee754.c.src#L400-L449

Closed by https://github.com/xnd-project/rbc/pull/154


rename fonts directory

Because Linux is case-sensitive
resources/fonts -> resources/Fonts

@mola can you send a PR?


Tool with only Descriptor and no Dockerfile leads to UI issue

Bug Report
Expected behaviour
Add a Dockstore.cwl to a repo, no Dockerfile.
Add as a Docker Hub tool with an arbitrary path on Docker hub leading to your legit repo.
Refresh, should be able to see Dockstore.cwl, a warning due to no Dockerfile
Actual behaviour
The Files tab displays no content at all.

I think it makes sense to display a warning if you try to view the Dockerfile when there isn't.
I don't think it makes sense to hide the Dockstore.cwl when the Dockerfile is absent.
I could be convinced that a warning for both could be displayed saying that the version is invalid, but the existing file should be displayed regardless

FYI, double check

Looks like this nowadays:

File is displayed even though version is invalid.  Warning about invalid version is displayed too.

Looks good on
DockstoreAPI - 1.5.0-beta.2
DockstoreUI - 2.2.0-beta.0


New version: Redisant.MQTTAssistant version <IP_ADDRESS>

Created by 🥟 Dumplings in workflow run #7726.

Log
Updated: <IP_ADDRESS> → <IP_ADDRESS>
Submitting WinGet manifests
Creating manifests
Uploading manifests and making commits
Creating a pull request

Microsoft Reviewers: Open in CodeFlow

Automatic Validation ended with:

No errors to post.

(Automated response - build 894.)

Automatic Validation ended with:
(Automated response - build 894.)


not working?

I just installed this, and when I click it it says to log in and visit my profile (pinterest.com/username) to start.  I've logged out of Pinterest and logged back in.  I'm on my profile.  But I can't seem to get the Pinback to recognize it.  I'm using Chrome.   Any suggestions?

Also, I've tried to install it in EDGE and it will not drag to the bookmarks bar.   It keeps the red circle with a line through it so it won't install.   So I can't test it on my other browser.

Hi! I'm having the same issue, any solution?
I get the message "Log in and visit your profile to start (pinterest.com/username)" on Chrome using macOS.

v0.4.0 should fix it: https://pinbackit.github.io/ 👍


Add data analysis file for scatter plot visualization

The scatter plot depicts the relationship between years of professional coding experience and yearly compensation.
Points in the plot are color-coded based on the developer type (e.g., frontend developer, backend developer) and styled according to the country of the respondent.
Enhanced visibility is achieved through larger markers and transparency settings, allowing for easier interpretation of overlapping data points.

@sanjay-kv, please review this PR and let me know if any changes are needed

@sanjay-kv could you please let me know when my PR is expected to be merged?


PBL-30305 Enable multiple JS files

@Katharine

I think instead of doing this, it would be preferable to move this sample file into the SDK.


initial ddd design

Hexagonal architecture has been discussed with @leandervdo but has been decided to be no suitable for a package like this. Closing this PR


Add pages for privacy and terms of service

Description
This PR adds a /pages folder to contain a set of pages like the About page, Privacy, and Terms. It also adds some color to make @NickEngmann happy.
Screenshots

👍 Let's follow up with the links in the README once the heroku app is ready for traffic.


More optional metadata fields?

Many satellite imagery providers use a lot of metadata fields, like azimuth angle, off-nadir / look angle, sun angle, local time of day, cloud cover, etc.
It could be useful to standardize those fields in some way, for interoperability. Perhaps make a fuller set of fields that providers could choose to use.

I like the idea of having a fuller set of suggested fields, especially when it comes to viewing or sun angles to encourage the same conventions (otherwise you have some sources using declination, some zenith, or even "look angle").
But we'd also want to support completely optional and unique provider/data fields as well.