npm publish?

/cc @wikimedia/services

Resolved: https://www.npmjs.com/package/elematch

Thanks

Pushed 0.3.0 with a small api change (.matchAll() -> .match()).


 IF YOU DO NOT FOLLOW THE FORMAT OR MAKE A GENERIC TOKEN REQUEST YOUR ISSUE WILL BE DELETED WITHOUT COMMENT
YOUR JUSTLIST MUST FOLLOW THE JSON SPECIFICATION
https://github.com/justswaporg/justlists/example.justlists.ts
Checklist

[x] I understand that this is not the place to request a token listing.
[x] I have tested that my JustList is compatible by pasting the URL into the add a list UI at justswap.org.
[x] I understand that filing an issue or adding liquidity does not guarantee addition to the justlists website.

Please provide the following information for your token.
JustList URL must be HTTPS.
JustList URL: http://communityinu.org/
JustList Name: Community Inu
Link to the official homepage of the JustList manager: https://www.facebook.com/adeel.siddique.12/

Sorry, your issue will be closed as you did not submit your information in the correct format.

Hello Jeff
Can you guide me regarding proper information ??

From: jeffwami @.>
Sent: Wednesday, November 10, 2021 9:14 AM
To: justswaporg/justlists @.>
Cc: addijee @.>; Author @.>
Subject: Re: [justswaporg/justlists] Add JustList: {JustList name} (Issue #2178)
Sorry, your issue will be closed as you did not submit your information in the correct format.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/justswaporg/justlists/issues/2178#issuecomment-964770289, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AWKTZAPDT6MA4L5FXZAEHK3ULHWQZANCNFSM5HVHR25A.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.


Team3 [1pt] Create basic structure for Dragons - Setup

Create a route and a view component. Use <NavLink /> for the page navigation links and style active class to indicate which section/page the user is currently on (underline active navigation link).
Create a directory for all Redux state slice files.

Kindly find the PR link for review here.


Exported shapefile faulty

We use geojson.io to convert geojson files into shapefiles. Unfortunately, recently this no longer works correctly if there is more than one polyline (or polygon) in the geojson. The exported shapefile can then no longer be opened in ArcMap/ArcGIS Pro. It also doesn't open correctly in QGIS.

this happened to me too

I'm unable to reproduce this with simple drawn features in geojson.io.  I did the same workflow for polygons and polylines:

draw two polygons/polylines on geojson.io
download as a shapefile
unzip, open in QGIS 3.22.9 (macos), no issues with import.

Can someone provide example geojson that is not exporting to shapefile correctly?

In QGIS (3.22.4) now I can also load the shapefile with two polygon/polyline features.
In ArcMap/ArcGISPro you get the error "Number of shapes does not match the number of table records".
If you check the shapefile on mapshaper.org you also get an error -> "Mismatched .dbf and .shp record count".
If yout draw one polygon/polyline on geojson.io there is no problem, but if you draw two or more polygons/polylines then you get the error.

I have this issue too. I suspect this is because the corresponding .dbf file doesn't match the attribute number in the shapefile itself. But QGIS doesn't have strict inspection on this so you can still open the file itself. If you try to open the attribute list in QGIS you will find it blank, which is not allowed in the first place according to ArcGIS.

I have experienced this issue too. Attached, you'll find two shapefiles. 1-square is perfectly fine, 2-square has the mismatch record count issue.
According to the dBASE file specification, the number of records is located at bytes 4-7. This is correct in both .dbf files.
This implies the bug could lie within the .shp file.
1-square.zip
2-suqraes.zip

fyi this is a problem with the shp-write library mapbox/shp-write#113


Sparse tiles in output from CZI scans

Background
I'm attempting to use ASHLAR 1.15.2 on a couple Zeiss (CZI) 5-channel whole slide images. However, the results are showing strange tiling issues, basically sparse tiles with no data in between. I'd love some advice to troubleshoot this issue, or, if this is due to a bug in ASHLAR, I'm happy to help investigate.
Also, while running ASHLAR, I received some warnings ("WARNING: Stage coordinates' measurement unit is undefined; assuming μm."), and I'm wondering if that's the issue, and if there is a workaround. I'd also appreciate any additional explanations about those warnings. Full console output below.
Image output
Here's the zoomed-out output from running two whole slide images (screen clip is from Fiji, which can barely handle this gigantic image):

And here I'm using much smaller exported ROIs from the same images (screen clip is from ZEN, blue for the first image's DAPI channel and red for the second image's DAPI channel, though all channels from each image are contained within those respective rectangles):

Console output
Here's the full console output of my ASHLAR run on the exported ROIs that yielded the second image above. Both images have 5 channels and their last channel is DAPI, so I entered --align-channel 4 to reference that DAPI channel using ASHLAR's 0-based indexing.
D:\ashlar\output2>ashlar "c:\temp\ashlar\data\4420-cropped.czi" "c:\temp\ashlar\data\4610-cropped.czi" --align-channel 4
Stitching and registering input images
Cycle 0:
reading c:\temp\ashlar\data\4420-cropped.czi
WARNING: Stage coordinates' measurement unit is undefined; assuming μm.
assembling thumbnail 12/12
quantifying alignment error 1000/1000
aligning edge 3/3
Cycle 1:
reading c:\temp\ashlar\data\4610-cropped.czi
WARNING: Stage coordinates' measurement unit is undefined; assuming μm.
assembling thumbnail 12/12
estimated cycle offset [y x] = [-97.6009913 -95.       ]
aligning tile 12/12

Merging tiles and writing to ashlar-output.ome.tif
Cycle 0:
Channel 0:
merging tile 12/12
Channel 1:
merging tile 12/12
Channel 2:
merging tile 12/12
Channel 3:
merging tile 12/12
Channel 4:
merging tile 12/12
Cycle 1:
Channel 0:
merging tile 12/12
Channel 1:
merging tile 12/12
Channel 2:
merging tile 12/12
Channel 3:
merging tile 12/12
Channel 4:
merging tile 12/12
Generating pyramid
Level 1 (8229 x 7367)
processing channel 10/10
Level 2 (4115 x 3684)
processing channel 10/10
Level 3 (2058 x 1842)
processing channel 10/10
Level 4 (1029 x 921)
processing channel 10/10
Level 5 (515 x 461)
processing channel 10/10

Thanks for any assistance on this matter. I'm just taking off on vacation so I won't be able to get to responses right away, but I'll follow up on Monday, May 23rd.

Thanks @PresageMicah for the detailed description - in our past experiences with CZI files, we needed to add the --flip-y flag to the ashlar call as different vendors place the origin of stage coordinate differently.

--flip-y flag

Thanks @Yu-AnChen for the quick response! I re-ran it with that flag and got the same problem, though I can see that the pattern is slightly different:

Thanks for the quick check. The other two parameters I would suggest trying are --filter-sigma 1 and -m 30 in addition to the --flip-y. For testing, you could have ashlar output only the DAPI channels, for example --output-channels 4
To put it all together
ashlar "c:\temp\ashlar\data\4420-cropped.czi" "c:\temp\ashlar\data\4610-cropped.czi" --align-channel 4 --output-channels 4 --flip-y --filter-sigma 1 -m 30

This closed issue (#92) is relevant.

Another possibility could be that there's a bug in reading pixel data through BioFormats - if you're able to share the CZI files with us (maybe send the download link to my or @jmuhlich's email) we'll inspect them.

Thanks @Yu-AnChen for reviewing our files and providing your insights over email. We're still narrowing it down, but I thought I'd summarize our conversation for anyone else encountering the same issue.
It doesn't seem to be a problem with corruption - every scan from this scanner that I have tested has this problem and they are all viewable in the ZEN viewer.
However, it does seem to be a problem with accessing the raw FOV data from the CZI scans, which ASHLAR needs instead of the autostitched mosaic generated by ZEN. I'm wondering if this is an issue with our particular scanner, or perhaps just our scanner configuration, and I'm reaching out to Zeiss support for more information.


Correct code formatting

We're in a total mess: tabs, spaces, inconsistent styles, or lack thereof.
After I merge in pdfbox2.0, I'm planning on running a code formatter on the entire codebase. IntelliJ IDEA's format is a good one.
What do you think @jeremybmerrill?

@jazzido: 👍  I only pretend to know Java, so whatever works... works for me. :)


Add support for dbt 1.7

I'm not too too in the know about how exactly this works but it appears that we don't yet support dbt 1.7 - just based on the folder structure I see in https://github.com/dbt-labs/dbt-jsonschema/tree/main/schemas.
dbt 1.7 is currently the latest version when creating new environments in dbt Cloud.

dude you're so right! long overdue -- lemme get the open PR merged into 1.6, then i can copy over that into 1.7, and we can tackle a few of the other issues that are specific to 1.7! thanks for the nudge


Facebook not working?

Hello, i was wondering how you get the facebook to work? I replaced the c_user,datr and xs. Is that all we have to do? Because i tried that and it hasen't been working

u also need to update the agario-client

How?

Delete the old one and replace it with this one.
Here's the link : https://github.com/pulviscriptor/agario-client

Still failed to get token and 10mass bots, do you have some accounts cookies for me to try new?

Are you getting the 10 mass bots and not the Facebook ones or are you not getting both of them ?

I get 10 mass, default bots, script is maken to skip the FAILED TO GET TOKEN ( i actually fix that issue)

sejo153 could you tell me how to do it?


always use "opencv2/cvconfig.h" instead of "cvconfig.h"

this is complementary PR to https://github.com/Itseez/opencv/pull/4059

ok, Maksim is already working on it


Prettier append a comma before bracket

I can see weird behavior when i use prettier with atom  some time like this.
function removeSmallest(numbers) {

  let lowest = numbers.reduce(
    (lowestNumber, currentValue, index) => {
      return lowestNumber.value <= currentValue
        ? lowestNumber
        : { value: currentValue, index: index };
    },

    { index: Infinity, value: 0 },   // when i save it append a comma right there after the litteral's object declaration
  );
  return numbers.filter((n, index) => index !== lowest.index);
}

I ' m use prettier 0.14.1 with atom on ubuntu

Thanks for the report! Trailing commas are also added for function calls. See https://github.com/jlongster/prettier/issues/266 for discussion around adding a more granular option.

ok thanks for the response


GetAccountId method gets the master account and not the current account

As part of my test I want to grab the account ID of the IAM user that is running the test.  However when I use  aws.GetAccountId(t) it returns the master account account ID and not the current account.
Below is the test:
accountID := aws.GetAccountId(t)
logGroupArn := terraform.Output(t, terraformOptions, "log_group_arn")

expectedLogGroupArn := "arn:aws:logs:eu-west-1:" + accountID + ":log-group:/aws/lambda/logGroup1-" + environment + ":*"

assert.Equal(t, expectedLogGroupArn, logGroupArn)

Result:
expected: "arn:aws:logs:eu-west-1:12345678:log-group:/aws/lambda/LogGroup1-environment-NXHqQX:*"
actual  : "arn:aws:logs:eu-west-1:87654321:log-group:/aws/lambda/LogGroup1-environment-NXHqQX:*"

note: environment is a uniqueID

That method calls get-caller-identity in STS, so it should return whatever user is authenticated for your tests. Try to compare it to running aws sts get-caller-identity with the AWS CLI.

Thanks Yevgeniy I will do some more digging as to why I am getting the master account and not the child account the IAM User is in.


Alchchemical Hydra Slayer Boss Attack Counter

Just like the Demonic Gorilla plugin. Have it count the attacks of the Hydra's Range and mage attacks. Every 3 attacks it switches to range or magic.

https://github.com/runelite/runelite/wiki/Rejected-or-Rolled-Back-Features

Aww okay


Update README.md

Bonnehomme > Bonhomme
(and thank you to show our work :) )

Oops! No problem, it was an awesome project!

Thank you, awesome thanks to matter :)

Kevin* Boudot.*
Lead Developer @BonhommeParis
kevinboudot.me
06 59 68 56 79 <0659685679>
linkedin https://www.linkedin.com/in/kevinboudot - twitter
https://twitter.com/kevinboudot
On Mon, Feb 1, 2016 at 12:00 PM, Liam<EMAIL_ADDRESS>wrote:

Oops! No problem, it was an awesome project!
—
Reply to this email directly or view it on GitHub
https://github.com/liabru/matter-js/pull/199#issuecomment-177915787.


introduce Event::new()

fixes #148

Could you make all of the functions that just wrap around new() #[inline]?

done


Merge file restore date not date of newest backup

When merging two backups I sometimes have the restore date of the older backup when importing into JWLibrary
Steps to reproduce the behavior:

Import two backups with different dates (one or more days apart) into JWLMerge
create merge file
import into JWLibray and see the restore date

Expected behavior
I wasn't entirely sure if this is a bug or a feature.
But in my opinion I'd expect the restore date of the newest of the backups
Desktop:

Windows version: Windows 10 Pro 20H2 19042.1466

Replicated also on windows 11. It happens everytime in my case

The date of the original backup shows the date of the last modification of the personal study notes.
So I'd expect the date in the merged backup to be the date of the newest modification date across all files to merge 🤔

Yes, I know what you mean. I'm just thinking when I create a backup in JWLibrary the last modified date is the date when I last changed a note or highlightes something. Not the date I created the backup 🤔
Thats why I'd excpect to show the latest addition or change of the notes in the merged files 😁
But I don't want to split hairs 😅 Main thing is that its not older that one of the backups that are merged


[DOCS]: add npm registry badge to readme

Describe the need
Add npm registry badge to readme. For example: https://badge.fury.io/for/js/gulp-intermediate2
Code of Conduct

[X] I agree to follow this project's Code of Conduct

https://shields.io/badges/npm-version


Changed method signatures to reduce allocations

I'm currently testing this out. It'll remain here for a bit before merging to master. README docs still need to be updated. Posting for review.
This incorporates the great work from https://github.com/pforemski (long enough ago that I'm embarrassed to say), here: https://github.com/kentik/patricia/pull/12, then takes it a bit further. The method signatures have changed, so this isn't backwards compatible, but the work required to make it so is easy, and the performance benefits make it worth it. I'll include upgrade instructions in the README.
Changes:

The Find methods now accept a slice to put results into.
Delete now accepts a slice to use as a buffer.
Removed always-nil error return values

Results on Intel(R) Core(TM) i9-8950HK CPU @ 2.90GHz:
OLD: BenchmarkFindTags-5                     	 3721257	       294.3 ns/op	     160 B/op	       6 allocs/op
NEW: BenchmarkFindTags-5                     	41273214	        28.12 ns/op	       0 B/op	       0 allocs/op

Of course, we're just moving the slice allocation outside the method, and these gains are only realized if you can reuse it for successive calls. For applications that can, this should make quite an improvement in performance.
For those unfamiliar with this repo, look in the template directory. All of the *_tree directories are generated from that code with make generate.

FYI - I'm going to rename these new methods, and put back the old names so the caller can choose between allocating and reusing, or just not worrying about it.


DwellStart and Line number

Hi,
I have handled DwellStart event and would need to know the line associated with Y coordination of the event args. How can I do that?
Regards,

02336ec356edec7c0cd086eda21ff5cf91c776c2


PointAnnotations not hidden when hiding corresponding label/series

Bug report
Point Annotations not hidden when series is hidden by clicking on graph
Codepen
https://codepen.io/Redirts/pen/ExjNyOa
Explanation

What is the behavior you expect? When I click on legend to hide, the annotation should be hidden
What is happening instead? Annotation is kept visible.
What error message are you getting? N/A

Seems fixed on current version

I have the same issue. You can find my codepen here https://codepen.io/ginajemy/pen/MWjvrEo. The issue isn't clear in Redirts codepen as it only contains one series, but when there are multiple series and we only hide one, the annotations on the hidden series are still visible.

+1

+1


Win11 bug report

Microsoft PowerToys version
<IP_ADDRESS>
Running as admin

[X] Yes

Area(s) with issue?
General
Steps to reproduce
Version: <IP_ADDRESS>
OS Version: Microsoft Windows NT 10.0.22000.0
IntPtr Length: 8
x64: True
Date: 2021/7/4 12:40:45
Exception:
System.Reflection.ReflectionTypeLoadException: Unable to load one or more of the requested types.
Method 'get_Name' in type 'Microsoft.Plugin.Calculator.Main' from assembly 'Microsoft.Plugin.Calculator, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null' does not have an implementation.
at System.Reflection.RuntimeModule.GetTypes(RuntimeModule module)
at System.Reflection.RuntimeModule.GetTypes()
at System.Reflection.Assembly.GetTypes()
at Wox.Plugin.PluginPair.CreatePluginInstance()
at Wox.Plugin.PluginPair.LoadPlugin()
at Wox.Plugin.PluginPair..ctor(PluginMetadata metadata)
at PowerLauncher.Plugin.PluginManager.<>c.<get_AllPlugins>b__7_1(PluginMetadata x)
at System.Linq.Enumerable.WhereSelectListIterator2.ToList()    at System.Linq.Enumerable.ToList[TSource](IEnumerable1 source)
at PowerLauncher.Plugin.PluginManager.get_AllPlugins()
at PowerLauncher.Plugin.PluginManager.GetPluginsForInterfaceT
at PowerLauncher.ViewModel.MainViewModel.RegisterResultsUpdatedEvent()
at PowerLauncher.ViewModel.MainViewModel..ctor(PowerToysRunSettings settings)
at PowerLauncher.App.<>c__DisplayClass13_0.b__0()
at Wox.Infrastructure.Stopwatch.Normal(String message, Action action)
at PowerLauncher.App.OnStartup(Object sender, StartupEventArgs e)
at System.Windows.Application.OnStartup(StartupEventArgs e)
at System.Windows.Application.<.ctor>b__1_0(Object unused)
at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Int32 numArgs)
at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Int32 numArgs, Delegate catchHandler)
System.TypeLoadException: Method 'get_Name' in type 'Microsoft.Plugin.Calculator.Main' from assembly 'Microsoft.Plugin.Calculator, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null' does not have an implementation.
✔ Expected Behavior
No response
❌ Actual Behavior
After I updated to Win11, this report shows every time I startup.
Other Software
No response

Issue is a duplicate
Thank you for your issue! We've linked your report against another issue #11916
Thanks for helping us to make PowerToys a better piece of software.

Duplicate of #11916

Hi @axiaoye ,
Would you mind navigating to C:\Program Files\PowerToys\modules\launcher\Plugins\ in Explorer and checking if there's a "Microsoft.Plugin.Calculator" folder inside?
That folder is likely there from older installs.
Would you mind uninstalling PowerToys and checking if that "Microsoft.Plugin.Calculator" is not deleted? Please let me know of this detail.
If it's still there, delete it manually and reinstall PowerToys.
Please let us know how that goes.


bridge-quickstart.sh fails with  This chart location is deprecated

When following steps as described:
git clone https://github.com/Microsoft/mindaro
cd mindaro
chmod +x ./bridge-quickstart.sh
./bridge-quickstart.sh -g MyResourceGroup -n MyAKS

I'm getting the following message as result:
helm install traefik ingress controller in bikeapp
Error: template: deprecation/templates/NOTES.txt:10:3: executing "deprecation/templates/NOTES.txt" at
*******************************************************
This chart location is deprecated. Learn more here:
https://helm.sh/blog/charts-repo-deprecation/
*******************************************************
error calling fail:
*******************************************************
* This chart location is deprecated. Learn more here: *
* https://helm.sh/blog/charts-repo-deprecation/       *
*******************************************************

seems like the wrong chart repo is being referenced.
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 25b96907-35cf-ff1f-d7ad-a231aa78418b
Version Independent ID: 620e59a0-5658-9a05-c177-8d0687656e2a
Content: Use Bridge to Kubernetes with Visual Studio
Content Source: docs/containers/bridge-to-kubernetes.md
Product: visual-studio-windows
Technology: vs-azure
GitHub Login: @ghogen
Microsoft Alias: ghogen

This has been addressed by the product team: https://github.com/microsoft/mindaro/commit/199b26ce8a40472a692be0113266b70365bc2648

In my case I also needed to remove:
--version 1.85.0

Just tested latest version and it worked for me. Thanks for fixing it!

Just tested latest version and it worked for me. Thanks for fixing it!


lists: Add query for being inside list

This is useful for e.g. button bars
Not sure what to call it, isList, hasList, inList?
	queries: {
		isList: editor => !!getListItem(editor, editor.value.startBlock)
	}

getListItem will then need a guard for undefined block

Or maybe one for UL and one for OL

I like inList. Maybe an argument for the type since the block type could be overridden? It could default to either.
editor.inList({ type: "unordered-list" })
editor.inList({ type: "ordered-list" })
editor.inList() // either

well - should the type be the one that is passed as the block type, or should it be the key of the block type? In my case, that would be 'UL' vs 'unordered_list'
Also, do we anticipate any other arguments ever? If not, maybe passing just the type as a string suffices; later on the argument type could still be detected if objects are needed.

It would be whatever you passed in as the block type, so 'UL' in your case.
Good question on other arguments, I'm not sure. Currently, wrapList currently takes an object with the type key. I'm not sure whether or not consistency with that is applicable. Personally, I like type: "unordered-list" in wrapList, but I could go either way with inList.

There are two semi-hardcoded list types, ordered and unordered, but there is no reason for that. How about accepting an array of block types that encode lists, defaulting to types: ['ordered-list', 'unordered-list'] (['UL', 'OL'] in my case). That way, we're not constrained by the arbitrary HTML limits (e.g. a sorted list type that orders the list by some property of the children).

I wonder if this could be accomplished by using the plugin more than once. In that case, the plugin would only have to handle one type. I chose to hard code it for now to keep it simpler, but it doesn't have to stay that way.

Why is there a list_item_child as well as a list_item? Is it to enforce the schema? In that case, it's like an internal node, which shouldn't be exposed to the user? But is it really necessary to enforce that schema?

It made it easier to make work out of the box. A list-item can have text and/or another list as children.  But Slate can't put a text node and a block node next to each other, so we need a block to hold the text if another list is in there. It's exposed to the user because you could just have that be a paragraph, or whatever else you want.

Since commands like wrapList etc take only the type, it would be more efficient to just accept the string type. I keep thinking of the poor VM that needs to create an object and GC it again just for that one string :)

I'm not too worried about the efficiency here. If there was a benchmark of a real world use case where it made a difference, then maybe we could change it for that reason. I'm open to changing it for other reasons, but probably further down the line.

I wonder if this could be accomplished by using the plugin more than once. In that case, the plugin would only have to handle one type. I chose to hard code it for now to keep it simpler, but it doesn't have to stay that way.

Hmm, but then there will be two inList queries, and the plugin won't know to keep the list when switching from one to another.

But Slate can't put a text node and a block node next to each other

Does Slate require each node to be a real DOM node? Maybe list_item could be just the block type but it just renders its children unchanged?
For the wrapList, I prefer reading wrapList('UL') versus wrapList({type: 'UL'}). Personal preference, I know, but it would be nice to be able to do that.

Good point about multiple queries. I personally don't have a use case for more than two list types right now, so I don't plan on adding it, but would be open to a PR for it if someone needs it.

Does Slate require each node to be a real DOM node?

I thought so, but I'm not sure. The slate attributes have to get put into the DOM somehow.
Regarding the wrapList command, the thought was that I'd add support for passing other attributes, like wrapList({ type: "UL", data: {}}). I don't think I'd be opposed to supporting both though as that mimics what slate does: https://docs.slatejs.org/slate-core/commands#wrapblock
It may be easier to discuss some of these things in separate issues.


Fix types in common field types for rule E2532

Issue #, if available:
Fix #412
Description of changes:

Fix common task variables for rule E2532

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Thanks, really fast work!


ci: Add Python 3.11 to testing

* Update setup-python action to v4.
* Add Python 3.11 to testing in CI.

@dguest this is ready for review.


Fix queue_unit_tests failure

We run ./queue_unit_tests in CI / as part of tests and it shows an error:
...
Test join_consumer_thread - OK (0)
Test join_consumer_replay_thread - OK (0)
Test enqueue - OK (0)
Test dequeue - OK (0)
Test read_head - OK (0)
Test consume - OK (0)
Test dequeue - OK (0)
Test read_head - OK (0)
Test dequeue - FAILED (0)
Test read_head_replay - OK (0)
BACKEND: Queue 0/0 deleted
Test delete_queue - OK (0)

[ ] fix return code of queue_unit_tests to reflect that individiual tests are failing
[ ] fix actual bug

No, I will include this change bundled with the fix to #79, which has the same exit code issue.


Fix user last_login field update

Fix to update the last_login field in auth_user table.

Any reason for this not being merged in?

Wouldn't it be better to send a signal to user_logged_in?

That is a much welcomed addition, but I would too use user_logged_in signal as @mscansian suggests.

it's april 10 is there any plans on it to be merged?

Wouldn't this update last_login every 5 minutes when a new access token is retrieved? I created a PR that will only update upon login (TokenObtainPairView).
update_last_login on TokenObtainPair #238

Ref #234 Create a signal instead. Seems likeanother PR is underway but slightly inactive.


Is it possible to use it with github without callback url?

We have our repos in github.com (privately) and the machine I want to try drone can't receive requests from the internet.
Is it possible to configure the permissions manually? I am admin in the github org, so I can do whatever on that end, but I'm not certain how to configure drone.
Thanks!

nevermind, I was sleepy, if I'm in the network I can set it to a private host


Support useref like blocks

To support parsing useref blocks ie.
<!-- build:css combined/style.css -->
regex could become:
var regex = /(\n?)([ \t]*)(<!--\s*build:(\w+(?:-\w+)*)\s+[^-]*\s*-->)\n?([\s\S]*?)\n?(<!--\s*endbuild\s*-->)\n?/ig;
I need html replacement to work aside useref.

@gunzip
I'm not sure about this one. The whole point of this plugin is not to work like useref and instead provide what i think is a better way of achieving this task. Plus what's the point in recreating some other library? If you need this particular syntax then why don't just use useref? Or if the syntax doesn't matter then why don't change it so gulp-html-replace can work with it? What's your use case?

My use case consist in

collecting assets list through useref
use gulp-rev generate a manifest
use gulp-html-replace to do some custom replacement using the generated manifest

if i could collect assets through gulp-html-replace this is not needed indeed.
If you think i't's an edge case feel free to close the issue anyway =)


Bug: Links resolved incorrectly when file not saved

Does this issue occur when all extensions are disabled?: Yes/No

Version: 1.77.3 (Universal)
Commit: 704ed70d4fd1c6bd6342c436f1ede30d1cff4710
Date: 2023-04-12T09:19:37.325Z
Electron: 19.1.11
Chromium: 102.0.5005.196
Node.js: 16.14.2
V8: <IP_ADDRESS>-electron.0
OS: Darwin x64 22.4.0
Sandboxed: No
TLDR: Links only resolved to their saved version and when changing a link without saving the link will point to the prior target!
Steps to Reproduce:

Make sure auto-save is not turned on
Create any file
Paste a link into the file, e.g. https://aws.amazon.com/ecs/
Save the file
Hold ctrl/cmd and click on the link. You will end up on https://aws.amazon.com/ecs/
Now change the link to https://aws.amazon.com/ebs/ BUT DO NOT SAVE THE FILE
Hold ctrl/cmd and click on the link. You will end up on https://aws.amazon.com/ecs/ but you would expect to end up on https://aws.amazon.com/ebs/ (note EBS)

I cannot reproduce.

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


macos-13-xlarge runners are being canceled at a high rate

Problem
About 50% of our iOS builds that use the macos-13-xlarge runner are being canceled with the error:
[Build and deploy iOS](https://github.com/Expensify/App/actions/runs/7032789006/job/19137288520)
The hosted runner encountered an error while running your job. (Error Type: Disconnect).

Solution
Fix it

Looks related: https://github.com/actions/runner-images/issues/7754

GitHub confirmed this was something on their side and they are looking into it

Been pretty quiet from GitHub support, I will bump them

No update from GitHub support

We got a work around from GitHub support, but I am not sure we are seeing the error anymore. Looking into it today.

GitHub says if we set --maxsockets on npm install it should help, but I am not sure we want to do so with all the runners not failing.

I'll look back into this

I think GitHub must have fixed it on their side, I haven't seen this happen in 2+ weeks.

Hi, not to be intrusive here, but it seems that this is a recurring issue here... have you considered giving FlyCI a try?

@kgantchev - Feel free to follow the proposal process, but no we haven't.

Going to see if macos-13-large helps, I believe xl might have been depreciated. This will still use intel CPUs as we don't want to use arm64.


Example pipelines

This PR contains:

Example pipelines to test the changes made to the Cloud-vision. plugin

Known Issues:
https://issues.cask.co/browse/PLUGIN-120
Errors in pipeline run on Sandbox environment only.
This PR goes with:
https://github.com/data-integrations/cloud-vision/pull/13

@googlebot I signed it!


Bad file descriptor when running tensorflow.python.keras.utils.data_utils._hash_file

Click to expand!
Issue Type
Bug
Have you reproduced the bug with TF nightly?
No
Source
binary
Tensorflow Version
2.10.0
Custom Code
Yes
OS Platform and Distribution
Ubuntu 22.04
Mobile device
No response
Python version
3.9
Bazel version
No response
GCC/Compiler version
No response
CUDA/cuDNN version
No response
GPU model and memory
No response
Current Behaviour?
Probably due to Nan or negative argument

Standalone code to reproduce the issue
import tensorflow as tf
import os
import numpy as np
from tensorflow.python.keras.utils import data_utils
try:
  arg_0 = True
  arg_1 = "nan"
  arg_2 = -0.3344762570580887
  out = data_utils._hash_file(arg_0,arg_1,arg_2,)
except Exception as e:
  print("Error:"+str(e))

### Relevant log output

```shell
2023-01-21 13:28:52.803828: I tensorflow/core/platform/cpu_feature_guard.cc:193] This TensorFlow binary is optimized with oneAPI Deep Neural Network Library (oneDNN) to use the following CPU instructions in performance-critical operations:  AVX2 FMA
To enable them in other operations, rebuild TensorFlow with the appropriate compiler flags.
2023-01-21 13:28:53.097843: E tensorflow/stream_executor/cuda/cuda_blas.cc:2981] Unable to register cuBLAS factory: Attempting to register factory for plugin cuBLAS when one has already been registered
2023-01-21 13:28:53.923396: W tensorflow/stream_executor/platform/default/dso_loader.cc:64] Could not load dynamic library 'libnvinfer.so.7'; dlerror: libnvinfer.so.7: cannot open shared object file: No such file or directory; LD_LIBRARY_PATH: :/lib/
2023-01-21 13:28:53.923579: W tensorflow/stream_executor/platform/default/dso_loader.cc:64] Could not load dynamic library 'libnvinfer_plugin.so.7'; dlerror: libnvinfer_plugin.so.7: cannot open shared object file: No such file or directory; LD_LIBRARY_PATH: :/lib/
2023-01-21 13:28:53.923589: W tensorflow/compiler/tf2tensorrt/utils/py_utils.cc:38] TF-TRT Warning: Cannot dlopen some TensorRT libraries. If you would like to use Nvidia GPU with TensorRT, please make sure the missing libraries mentioned above are installed properly.
Traceback (most recent call last):
  File "/media/nimashiri/SSD/testing_results/orion/tf-2.10.0/orion_bugs/tensorflow.python.keras.utils.data_utils._hash_file.py", line 9, in <module>
    out = data_utils._hash_file(arg_0,arg_1,arg_2,)
  File "/home/nimashiri/anaconda3/envs/tf-2.10/lib/python3.9/site-packages/tensorflow/python/keras/utils/data_utils.py", line 321, in _hash_file
    for chunk in iter(lambda: fpath_file.read(chunk_size), b''):
  File "/home/nimashiri/anaconda3/envs/tf-2.10/lib/python3.9/site-packages/tensorflow/python/keras/utils/data_utils.py", line 321, in <lambda>
    for chunk in iter(lambda: fpath_file.read(chunk_size), b''):
TypeError: argument should be integer or None, not 'float'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/media/nimashiri/SSD/testing_results/orion/tf-2.10.0/orion_bugs/tensorflow.python.keras.utils.data_utils._hash_file.py", line 11, in <module>
    print("Error:"+str(e))
OSError: [Errno 9] Bad file descriptor
Exception ignored in: <_io.TextIOWrapper name='<stdout>' mode='w' encoding='utf-8'>
OSError: [Errno 9] Bad file descriptor

</details>

Hi, @nimashiri
Apologize for the delay and I was able to replicate the issue without any error, for your reference I have added gist file and It seems like you're not passing expected arguments with expected datatypes as per the function definition because of that reason you're getting this error Bad file descriptor
I have also replicated on Ubuntu 22.04 with Tensorflow version==2.10 and it's working as expected if I'm passing correct arguments to the function and for your reference I have added screenshot below

if issue still persists please let us know ? or Could you please confirm if this issue is resolved for you ? Please feel free to close the issue if it is resolved ? Thank you!

Not a vuln


fix: crash issue when replayMap is undefined

Description
Fix the type of replayMap and accordingly modify the code to handle undefined cases.
Fixes https://github.com/appsmithorg/appsmith/issues/22514
Type of change

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions, so we can reproduce.
Please also list any relevant details for your test configuration.
Delete anything that is not important

Manual
Jest
Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:
Dev activity

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] PR is being merged under a feature flag

QA activity:

[ ] Test plan has been approved by relevant developers
[ ] Test plan has been peer reviewed by QA
[ ] Cypress test cases have been added and approved by either SDET or manual QA
[ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
[ ] Added Test Plan Approved label after reveiwing all Cypress test

/ok-to-test sha=a2c840d

/perf-test

/ci-merge-check


Prevent update on initial install

Hello,
Not sure if I am missing something here, but if I transfer an app to my phone and upload the same version of the app to ionic and then deploy that version, should the update happen after first run? I would have thought it would detect that they are the same version and not do the update. Seems a little odd as an end user to download an app just to have it update immediately.
My workflow is:
ionic upload
/* go into ionic dashboard and deploy uploaded version */
ionic run ios -cs --device

Thanks a lot!

This is a known issues that is being addressed in the next update.

Great, thanks for the update!

@microadam This has been addressed with the latest deploy updates.
If you're exact concern was during testing, each time you ionic run (installing the app on a device or emulator) any previous deploy will be ignored. If the deployed version is not the same as the one currently deployed via the dashboard, it will still need to download once before ignoring. This allows you to ignore initial deploys on the phone while developing locally but still allow you to test using deploys.
If you were more concerned about preventing an App Store version from automatically downloading an update, you can check out the docs for binary versioning.
Cheers :beers:

@ericb Thanks a lot. Still having issues with this though. On the latest versions of everything (service deploy, service core and plugin deploy).
I have created a new version of my app and set the config.xml to have version 0.1.0 as the version number. I have generated an IPA using ionic build ios and then exported an archive from xCode.
I have then done an ionic upload and edited my version on the ionic dashboard to have iOS binary version as 0.1.0. I have then deployed the app in the dashboard.
I have then installed the IPA on my phone and the first thing the app does is a version check, at which point it believes there is a new version and updates it. This is what I am trying to prevent.
Can you see if I am doing anything wrong in this flow?
Thanks a lot

@microadam You either aren't running the updated components (it can say the versions are up to date, but unless you correctly prepare the ios platform or remove and re-add the ios platform, the old components will still be in the build, even though the latest components are available), or the version isn't being set in the app correctly -- It will show the version labels in the xcode logs when it checks for updates. You can verify there.

Thanks a lot, removing and re-adding the platform solved it!


Changing a non-localized field on a versions-enabled collection resets localized fields to the default locale values

Link to reproduction
https://github.com/hdodov/payload/tree/bug-original-content-on-save
To Reproduce
Prerequisites:

Collection with versions and drafts enabled
One translatable and one untranslatable field

Reproduction:

Create an entry in the default locale
Fill in both the translatable and untranslatable fields
Switch over to the second locale
Change the translatable field to something else
Switch back to the default locale
Change the untranslatable field to something else
Switch to the second locale once again
Refresh the page
The translatable field on the second locale is reset to the value in the default locale

Describe the Bug
Changing untranslatable fields should not reset other fields to the default locale values.
I've demonstrated this in the following video:
https://github.com/payloadcms/payload/assets/5570098/7b531a24-14e7-4be4-8ad8-2c6f5310c3fe
In the video, I have:

Two locales: en and es
A Posts collection with two fields: content with localized: true and slug without localization

As per the reproduction steps, the following happens:

I create a post
In the English version, I set content to "english" and slug to "test"
In the Spanish version, I set content to "spanish"
In the English version, I set slug to "test another"
In the Spanish version, the content is reset to "english" upon refreshing the page, rather than remaining "spanish"

The issue appears to come from the versions functionality. Without versions and drafts enabled, I wasn't able to reproduce this.
Payload Version
1.10.0

@jmikrut I'm going to allow myself to tag you in because I think that's a pretty big issue, since content is getting lost.

Hey @hdodov—thanks for the issue report. We are on this immediately. Expect an answer back shortly!

Just letting you know that I updated Payload and the issue is resolved indeed. Thank you very much!


NOTE: NN.print()'s floating point precision, is inucurate at the last decimal digit.

This means that if you copy-paste the printed-weights from the serial output, into another neural-network, there's going to be some slight noise to the output (when you run it). This is a result of Serial.print(weights[i][j], DFLOAT_LEN); where DFLOAT_LEN is 7 but the print-function rounds it in a weirdly way.

I'm looking for sulution as of right now

Usually there will be something like -3.8190280 printed as -3.8190279

Like it's weird ngl

Wait... might not be this, the problem...

Whatever this is, causes the issue:
https://github.com/arduino/Arduino/blob/9d1302307528622ed5d1d2f838bbce1c85301f94/hardware/arduino/avr/cores/arduino/Print.cpp#L219
(Don't worry about the SD read\write [opposite] [str to float] i solved it using ATOL)


Add embedded video example

Embedded Video
Added _includes folder with iframe HTML template.
Video can be linked by using "{% include youtube.html id="enter the youtube ID here" %}"
Credit Christian Heilmann
Posted on September 14, 2022 here
An example video can be found at the bottom of this page: https://gregorywmorris.github.io/sample_page
folder:
_includes
youtube.html :
`

`

Hello sir, I can do this effectively so please assign this issue to me.

I have this resolved, I should probably submit a pull request.


schedule.every(2).mondays.do(job)

If I call schedule.every(2).monday.do(job), schedule returns an intervalError:
````raise IntervalError('Use mondays instead of monday')```
This would imply that schedule.every(2).mondays.do(job) is valid, however:
AttributeError: 'Job' object has no attribute 'mondays'
Is this an oversight, or is calling schedule.every(2).mondays.do(job) not supported by schedule?

Looks like anything outside of the interval 1 throws this exception but no *days appear to exist as properties of the class.
https://schedule.readthedocs.io/en/stable/api.html#schedule.Job

Let's be honest. This library has too many holes for it to be used for anything other than a cute daily scheduler. This is not just an oversight but a prove no one uses it for real projects.
This assertion makes no sense. You really want the thing to sound like english that you need to enforce the "s" at the end of every attribute?
I'm working on legacy code with this lib and I might just replace it with something else that actually works.

Agreed, we moved away from using this and simply built out our jobs to let K8s cron jobs handle this for us.
Not looking back.

Yes, scheduling a job every n mondays is not supported. You can read here in more details why.


QRDA3 Fix & HDS Update

These changes are targeted at issues #21 and #27. This branch is passing in Travis, and QRDA3 exports have been physically tested.

Good to merge.


Problem with rendering

I am trying to create a Q-learning agent  I am having a problem with rendering the environment. I want to render the environment every thousand episodes but due to env.reset() calling render internally the rendering is continuous and the training is so slow.

You are asking in the wrong project, could you make an issue https://github.com/farama-Foundation/gymnasium here with some example code to help understand your problem


Docusaurus URL with # does not always navigate to the correct anchor with external images in it

Have you read the Contributing Guidelines on issues?

[X] I have read the Contributing Guidelines on issues.

Prerequisites

[X] I'm using the latest version of Docusaurus.
[X] I have tried the npm run clear or yarn clear command.
[X] I have tried rm -rf node_modules yarn.lock package-lock.json and re-installing packages.
[X] I have tried creating a repro with https://new.docusaurus.io.
[ ] I have read the console error message carefully (if applicable).

Description
Hello! My name is Furkan from Appcircle CI/CD. Thanks for creating such a convenient tool that powers our documentation. We also open sourced our own documentation as well.
I've come across some slightly minor problem when there's an image on a documentation link, anchoring and referencing them is slightly off sometimes, especially when there are too many close anchors to each other, it gets noticeable pretty fast.
It happens on our documentation, https://docs.appcircle.io but I've also checked the https://docusaurus.io itself to check it happens and I noticed that it happens on a few pages with images on it. Docusaurus.io doesn't have that many images so it's harder to catch the issue there. I've added that in reproducible demo stage on a page I've found which has an image in it.
The context is, when there are lots of images and anchor link is on bottom of the images, it renders afterwards.
I've also checked the function that is responsible for scrolling with anchor, but I've found nothing wrong with it on sight.
Thank you for your consideration! Sorry that I won't be able to fix the issue myself.
Reproducible demo
StackBlitz Demo:
https://stackblitz.com/~/github.com/furkanarabaci/docusaurus-anchor-issue
From Official Appcircle Documentation:

Navigate here: https://docs.appcircle.io/updates/release-notes#-fixed-1
Find the last item on the list that starts with:

The case that selection of the adhoc auto device register

click the auto device register link
Observe the scroll behavior

Steps to reproduce

Create a page with images in it and an anchor (h2 or lower) below the images
Locally navigate to that page using e.g. /docs/start#anchor (make sure it's uncached)
Notice that the anchor is not properly aligned

Case 2: - Reload Deemed as invalid ✅
1. Go to a link with anchor in it
2. Scroll a bit down or up, doesn't matter
3. Reload or force reload the page,
4. Notice the scroll state sometimes aligns with anchor, but most of the time it doesn't
Expected behavior
The page to be scrolled properly to its anchor
Actual behavior
Notice that the anchor is not properly aligned on both cases. Case 1 is a guess game, most of the time it works but there are cases which it doesn't work
Your environment

Public source code: https://github.com/appcircleio/appcircle-docusaurus
Public site URL: https://appcircle.io
Docusaurus version used: 2.1.0 - 2.4.0 and 3.0.0 -> Persists on all
Environment name and version (e.g. Chrome 89, Node.js 16.4): NodeJS 16, 18. Edge version 119.0.2151.46, Safari version 17.1, Google Chrome 107.0.5304.63
Operating system and version (e.g. Ubuntu 20.04.2 LTS): MacOS, Windows

Self-service

[ ] I'd be willing to fix this bug myself.

Thanks

A few examples: docs.appcircle.io/distribute/apple-devices#automatically-adding-registered-devices-to-the-provisioning-profile docs.appcircle.io/distribute/create-or-select-a-distribution-profile#delete-a-distribution-profile

I can't reproduce any issue on those links.
Can you record a video and specify which browser you are using?
Can you provide a minimal open source repro using docusaurus.new?

Reproducible demo
docusaurus.io/docs/advanced/routing#generating-and-accessing-routes

That's a different bug, Mermaid diagrams are not rendered at build time but only on the client-side. This produces annoying layout shifts. This bug is tracked in https://github.com/facebook/docusaurus/issues/8299

There are two cases: Case 1: - Navigation

Go to a link with anchor in it (make sure it's uncached)
Notice that the anchor is not properly aligned

Case 2: - Reload

Go to a link with anchor in it
Scroll a bit down or up, doesn't matter
Reload or force reload the page,
Notice the scroll state sometimes aligns with anchor, but most of the time it doesn't

Please report the different cases independently and provide a link/repro so that we can investigate each case in isolation.
For each case please share at least a link, md source, screenshot or video
Note if you scroll then reload, the std browser behavior is not to scroll back to the url anchor but rather to restore the former scroll position.

@slorber Thank you for your reply. In that case, case 2 is already invalid. I didn't provide a reproducible demo because our documentation is open to the public and the code is open source. But I understand, for the sake of simplicity I'm going to create a new one and try the case there

@slorber Sorry for the late reply.
Upon further investigation, I was able to pinpoint the issue. The problem happens on our website (presumably on Docusaurus as well) if there's a local link with anchor e.g.
[Local Navigation](/seo#structured-content)

And since it is loaded right away, assumably due to image content it doesn't scroll properly to the anchor. I'll also try it on docusaurus.new for the sake of simplicity.
Also, should I edit the title&description to match the issue, because the correct issue is a bit more specific than I've provided.

@slorber Meanwhile, a reproducible example from our documentation:

Navigate here: https://docs.appcircle.io/updates/release-notes#-fixed-1
Find the last item on the list that starts with: The case that selection of the adhoc auto device register and click the auto device register link
Observe the scroll behavior

@slorber I've edited the issue with reproducible new.docusaurus demo, please take a look

Hi! This is working as intended. We match the default browser behavior of eagerly scrolling, and it will be very tricky to wait for images loading, because our default optimizations make images not load at all unless they scroll into view! If you want to avoid layout shifts caused by image loading, remember to add explicit width and height attributes that match your image's dimensions. This is the default behavior if you use the Markdown ![]() syntax; see https://github.com/facebook/docusaurus/pull/6339

Hi! This is working as intended. We match the default browser behavior of eagerly scrolling, and it will be very tricky to wait for images loading, because our default optimizations make images not load at all unless they scroll into view! If you want to avoid layout shifts caused by image loading, remember to add explicit width and height attributes that match your image's dimensions. This is the default behavior if you use the Markdown ![]() syntax; see #6339

I see, then it's better to determine width/height standard and style it with fixed dimensions will solve the problem at hand. Thank you!


add faq on models downloaded from hf

Closing for now as we have https://github.com/jmorganca/ollama/blob/main/docs/import.md. Thanks for the PR!


Custom history indicies

Issue #, if available:
Description of changes:
Added usage of custom history indicies provided through monitor's DataSources
CheckList:
[ ] Commits are signed per the DCO using --signoff
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Plz add tests for history indices usage verification at transport layer

Codecov Report

Merging #616 (1748ed4) into main (3c74744) will increase coverage by 0.10%.
The diff coverage is 78.57%.

@@             Coverage Diff              @@
##               main     #616      +/-   ##
============================================
+ Coverage     76.04%   76.14%   +0.10%
  Complexity      116      116
============================================
  Files           124      124
  Lines          6428     6451      +23
  Branches        932      942      +10
============================================
+ Hits           4888     4912      +24
+ Misses         1059     1053       -6
- Partials        481      486       +5

Impacted Files
Coverage Δ

...rting/transport/TransportAcknowledgeAlertAction.kt
79.56% <ø> (+0.15%)
:arrow_up:

...otlin/org/opensearch/alerting/alerts/AlertMover.kt
62.96% <66.66%> (-2.43%)
:arrow_down:

...lin/org/opensearch/alerting/alerts/AlertIndices.kt
70.41% <68.18%> (+0.90%)
:arrow_up:

...ain/kotlin/org/opensearch/alerting/AlertService.kt
78.50% <100.00%> (+0.30%)
:arrow_up:

...in/org/opensearch/alerting/MonitorRunnerService.kt
79.59% <100.00%> (ø)

...nationmigration/DestinationMigrationCoordinator.kt
61.70% <0.00%> (-4.26%)
:arrow_down:

.../kotlin/org/opensearch/alerting/core/JobSweeper.kt
73.68% <0.00%> (-0.48%)
:arrow_down:

...destinationmigration/DestinationConversionUtils.kt
70.00% <0.00%> (ø)

...rg/opensearch/alerting/BucketLevelMonitorRunner.kt
77.44% <0.00%> (+0.75%)
:arrow_up:

... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Check to see if vfkit is installed

Should be checking to see if we are using vfkit

In the code it looks like this is done?

@deboer-tim Yup it's done now! Although rudimentary, it's there. Closing.


Handling multiple users

Was looking to use this for a product with user accounts (not saving anything confidential), but I am thinking it is not suitable due to you defining the engine key and to load existing state at the application initialisation. If you have multiple users logging into the same machine you will not be able to load the correct data after they have logged in.
Or do you have suggestions on how to handle this scenario?

Your scenario is possible but requires some more details about how your going to structure your state tree. Without any further knowledge or detailed thinking there are two solutions popping in my head right now.
One state tree with a "pointer"
You could, for example, store everything in one state tree and use a "pointer" that's referring to the current one:
const state = {
    account: {
<EMAIL_ADDRESS>{ name: "Hans Peter" },
<EMAIL_ADDRESS>{ name: "Someone Else" }
    },
    currentUser<EMAIL_ADDRESS>};

To handle such a tree https://github.com/rackt/reselect might be a good companion :)
Create a custom engine
You're right that the key use by the engine is currently not changeable from the outside. But if you need this flexibility - just add it :)
Take a look at the localStorage engine for example. There you only need a new method roughly like setEngineKey(newKey) { key = newKey; } and a switch could look like:
// App Start
import createEngine from 'myLocalStorageEngine';
const engine = createEngine('initial-save-key');

const load = storage.createLoader(engine);
load(store);

// User Switch
engine.setEngineKey('something-else');
load(store)

But keep in mind that redux-storage merges the old with the new state tree! You might have to clear/reset the current user right before loading the other one!

Please close this issue if this does solve your question. If not, keep on asking :)

Thanks for the suggestions. I think I am going to need to code my own solution for this. Looking at the various redux storage packages they all seem to do the initial setup when creating the store. I need to load/create the external store after a user has logged in (probably around the same place a USER_LOGIN_SUCCESS action is dispatched once it receives a successful login response from the server).
I could probably have the saving part as middleware but the loading part would need to be in an action creator at the point where I have the logged in users details to use/define the correct external storage key.


Warn if non-selected frequency is high (#708)

Closes: #708
Related-Issue: #708
Projected-Results-Impact: none

Codecov Report
Base: 86.17% // Head: 93.82% // Increases project coverage by +7.64% :tada:

Coverage data is based on head (2408b7a) compared to base (f388e94).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #734      +/-   ##
==========================================
+ Coverage   86.17%   93.82%   +7.64%
==========================================
  Files         152       12     -140
  Lines       18920     4452   -14468
  Branches      383      383
==========================================
- Hits        16305     4177   -12128
+ Misses       2615      275    -2340

Flag
Coverage Δ

javascript
93.82% <ø> (ø)

python
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

beaconsite/forms.py

importer/apps.py

var_stats_qc/admin.py

regmaps/apps.py

svdbs/admin.py

hgmd/apps.py

beaconsite/views_api.py

genepanels/plugins.py

importer/rules.py

genepanels/models.py

... and 130 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


undefined local variable or method 'ckeditor5_assets'

I am following the installation steps for the gem as outlined, but I'm encountering an error stating that ckeditor5_assets is an undefined local variable or method. Additionally, when I create the ckeditor5.rb file in the initializer, I receive an error at /config/initializers/ckeditor5.rb:1:in <top (required)>': uninitialized constant CKEditor5 (NameError) 2024-11-05 18:11:13. Did you mean? Ckeditor. It appears that the gem is not loading properly. @Mati365
Can you please help.
Rails version: <IP_ADDRESS>
Ruby: 3

@dil-bparihar Try updating gem to 1.5.0


App crash when I take a screenshot

The app sometimes crashes or freezes after I take a screenshot of the screen

Doesn't seem to be happening on small Ipad


Document Repository class in repository.py

You can add any helper methods:)

I'll take it

Well done!


[WIP] Move Tests/ to root dir (so we can use swift test when we're swift package manager compatible)

Related to #696
Currently there's no watchOS test target. Was that an oversight? Should I create one?

You can't. It doesn't exist.

Oh wow 😂😂
I wonder when Apple will decide that watch apps deserve tests ;p

This works with a carthage install, but is completely broken when you're using Cocoapods, and since CI uses Cocoapods as well, CI seems to be broken.
Can anyone from @Moya/contributors who's familiar with Cocoapods update the tests to not break when installing through pod?

Might take a look at this soon. :)

Sounds awesome @BasThomas!
I tried rebasing, but I'm not sure what a lot of the changes on master have been.
Wasn't sure how to handle this conflict while rebasing

So I didn't finish the updating this branch. Do you know why those files were changed on master?
I'm around to fix the conflicts, or you can take a shot if you'd like

Hmm, just started "fresh" on this, but Xcode is complaining when moving the Tests directory into the root.

Not sure how to proceed :/

fresh as in pulling from master and manually redoing the work? If that's what you're thinking of doing, I can take the lead instead. I got it working before, so I can probably figure it out again.
Xcode looks as if it's expecting some source files and they're no longer there. Maybe you moved them in the filesystem without updating the xcodeproj?

@BasThomas I think I'm just going to redo this PR, that seems easier than managing all the rebase merge conflicts we're going to hit.
I'll do it later today

👍

Created #885 to continue this


Testing environment fixes

This PR makes a couple of changes in the testing environment of mata:

fixing examples to be compatible with the current version of mata
extension of the environment for the correctness checking
some minor structural changes

A question to consider is whether we want to include the correctness tests on a selected subset of automata to our CI at some point? I mean, so far it is fine, but later if someone starts using mata, we should minimize the probability of introducing bugs in the main branch.

I would include the correctness tests in our CI. It costs us nothing, yet it may save us some time in the future.
I have fixed examples in one of my PRs as well. The PR which will be merged second will have to resolve merge conflicts.

Sorry, for late review, I am OK with the PR, I like the proposed changes.

I do not require to include this in the CI/CD as suggested by @Adda0. While I think it should be included in the CI/CD, after my vacation I will be making some changes to build enviroment anyway, and in the process I will integrate this to CI/CD as well.
I am wondering if it would be usefull to have some macro (similar to catch) that would easily measure some parts of code. What do you think? Would you find it useful as well?
E.g.

TIMEIT("minimization", aut_min = Mata::Nfa::minimize(aut_min));

I do not require this in this PR, just raising question for some future PR.

Great! We should also have a discussion on the automata selection later (covering a lot of interesting cases, but not killing github servers).
That could be definitely useful, especially in the performance testing.

Ad 2. We have a similar thing in Z3 for logging, and we find that useful. We could probably make use of said timing macro here, too.

@vhavlena Is this PR ready for merge? If so, please let me know, and feel free to go through the ideas suggested in this PR and create issues from the suggestions you find useful for us. We can work on them in the future.

Yes, I think it is ready for merge. In the following work we should somehow integrate it inside CI/CD (and implement the TIMEIT as @tfiedor suggested).


Moderate Performance Issues Loading Scripts With v4.0 Beta 16 IDE On Linux

Godot version
v4.0.beta16.official [518b9e580]
System information
Linux Mint 21.1 Cinnamon 64Bit
Issue description
Hi,
Have moderate performance issues with v4.0 Beta 16 IDE on Linux.
Running Godot Engine v4.0 Beta 16 official Linux on below system:

Hyper-Custom ''JeZxLee'' Pro-Built Desktop
Desktop Code Name: ''Optimus Prime''
Genuine ''Linux Mint 21.1 Cinnamon 64Bit'' Linux
Corsair 750watt Modular Power Supply
GIGABYTE GA-970A-DS3P 2.0 AM3+ Motherboard
AMD FX 3.5GHz(4GHz Turbo) 8-Core CPU
Corsair 32GB DDR3 RAM Memory
nVidia GeForce GTX 970TT 4GB GDDR5 GPU
ADATA 1TB SSD Hard Drive(OS/Apps)
Western Digital 1TB HDD Hard Drive(Personal Data)

See steps to reproduce...
Thanks!
Jesse
Steps to reproduce

Load a Godot 4 project into Linux Beta 16 IDE
Click on different scripts in the scripts pane
(loading each individual script takes over 1 second?)

Minimal reproduction project
Not applicable

Please edit the issue title to mention that it's to do with scripts loading, otherwise it's liable to get closed by mistake as a duplicate of several other general 'Godot 4 feels slow' issues

How does this compare to previous betas. Have you had this issue before?

This is likely a duplicate of https://github.com/godotengine/godot/issues/71795 and/or https://github.com/godotengine/godot/issues/70869.

Please look over the project below:
https://github.com/BetaMaxHero/GDScript_Godot_4_T-Story
(above is an older release, but 99% similar to what we are using)

@Calinou I don't think it's a dupe of #71795, OP says it's to do with loading the scripts
@BetaMaxHero are there many scripts open (in the IDE list) at the same time?

I have all 8 scripts loaded in the scripts pane.
There is a 1-2 second delay switching scripts in the scripts pane.
It's not my high-spec Linux computer.
Linux IDE requires further optimization.

Linux IDE requires further optimization.

The rendering code is the exact same – Godot does not use OS-specific libraries for its UI. The most likely cause for the editor performing worse on Linux is that compositing on X11 is notoriously slow compared to Windows.
I recommend using a window manager that doesn't force compositing (such as KWin or Xfwm) and disable compositing while comparing performance with Windows. If this is not an option, enable fullscreen in the editor by pressing Shift + F11 (on both Windows and Linux).

Hi,
Sorry, but I am running Godot Engine v4.0 Beta 16 on Windows 11 Pro 64Bit now...
I have a hard deadline for releasing "Release Candidate 1".
Let me get this game out the door in about two weeks(or less), and I will revisit the performance issues on my Linux.
Thanks!
Jesse

"The most likely cause for the editor performing worse on Linux is that compositing on X11 is notoriously slow compared to Windows."

I don't agree - this desktop runs Doom(2016) at 1080P on "High" settings...

I don't agree - this desktop runs Doom(2016) at 1080P on "High" settings...

Fullscreen games suspend compositing, while the Godot editor is a windowed application (at least by default).

Ok, I'll revisit this in a couple of days - thank you!

Cloned: https://github.com/BetaMaxHero/GDScript_Godot_4_T-Story
Spent some time switching between tabs using HotSpot, seems like most of the time is spent parsing GDScript:

Here's the full callstack with the "top" time consumers when switching:

method
cycles:u

ScriptEditor::_script_selected(int)
32.8%

ScriptEditor::_go_to_tab(int)
32.8%

ScriptEditor::_update_members_overview()
27.8%

ScriptTextEditor::get_functions()
31.8%

GDScriptLanguage::validate(String const&, String const&, List<String, DefaultAllocator>, List<ScriptLanguage::ScriptError, DefaultAllocator>, List<ScriptLanguage::Warning, DefaultAllocator>, HashSet<int, HashMapHasherDefault, HashMapComparatorDefault >) const
31.8%

GDScriptParser::parse(String const&, String const&, bool)
32%

GDScriptParser::parse_program()
66.8%

GDScriptParser::parse_class_body(bool)
66.8%

void GDScriptParser::parse_class_memberGDScriptParser::FunctionNode(GDScriptParser::FunctionNode*(GDScriptParser::*)(), GDScriptParser::AnnotationInfo::TargetKind, String const&)
67%

GDScriptParser::parse_function()
66.6%

GDScriptParser::parse_suite(String const&, GDScriptParser::SuiteNode*, bool)
66.1%

GDScriptParser::parse_statement()
66.4%

GDScriptParser::parse_if(String const&)
52.9%

GDScriptParser::parse_expression(bool, bool)
37.8%

GDScriptParser::parse_precedence(GDScriptParser::Precedence, bool, bool)
52.1%

GDScriptParser::advance()
36%

GDScriptTokenizer::scan()
55.7%

GDScriptTokenizer::potential_identifier()
50.0%

TextServerAdvanced::is_confusable(String const&, Vector const&) const
48.2%

uspoof_getSkeleton_72_godot
40.8%

uspoof_getSkeletonUnicodeString_72_godot(USpoofChecker const*, unsigned int, icu_72_godot::UnicodeString const&, icu_72_godot::UnicodeString&, UErrorCode*)
37.4%

icu_72_godot::SpoofData::confusableLookup(int, icu_72_godot::UnicodeString&) const
25.4%

It seems ICU's is_confusable() implementation is taking a lot of time. cc @bruvzg


Request: Endpoint to edit Deviation

Hello,
Using the API can we edit the category, tags, and update the artist's comments?
This enables systematic organization and indexing of artwork.
Please consider the Added Value to post processing after uploading.
thanks,
coast

No plans for this in near future, sorry. You can update some stuff via the stash/submit but not category etc.


*: update raft engine

What problem does this PR solve?
Problem Summary:
To remove oudated dependency, especially spin, which has security issue.
Related changes

PR to update pingcap/docs/pingcap/docs-cn:
PR to update pingcap/tidb-ansible:
Need to cherry-pick to the release branch

Check List
Tests

Manual test (add detailed scripts or steps below)

Side effects

Performance regression

Consumes more CPU
Consumes more MEM

Breaking backward compatibility

Release note

No release note

/release

/run-integration-copr-test


[BUG] Package is incompatible with Vitest

Are you using the latest version of this library?

[X] I verified that the issue exists in the latest next-safe-action release

Is there an existing issue for this?

[X] I have searched the existing issues and found nothing that matches

Describe the bug
Importing anything from next-safe-action/hooks causes Vitest tests to crash due to how React is being imported in that file.
I don't fully understand how the module resolution works here so I cannot tell you exactly why this happens, but I do know that making the following change in the hooks.mjs file fixes the problem 👇
diff --git a/dist/hooks.mjs b/dist/hooks.mjs
index 636b65d50449fa41e913bb5bb632370f8f4f9df9..7f48d3c48278d76c36a73ae6bf99bed51ba5679b 100644
--- a/dist/hooks.mjs
+++ b/dist/hooks.mjs
@@ -3,7 +3,8 @@
 // src/hooks.ts
 import { isNotFoundError } from "next/dist/client/components/not-found.js";
 import { isRedirectError } from "next/dist/client/components/redirect.js";
-import { useCallback, useEffect, useOptimistic, useRef, useState, useTransition } from "react";
+import pkg from 'react';
+const { useCallback, useEffect, useOptimistic, useRef, useState, useTransition } = pkg;

That's a patch I've applied temporarily to fix the issue in my project.
Reproduction steps

Open https://stackblitz.com/edit/vitest-dev-vitest-6lgc1a?file=test%2Fbasic.test.tsx
See test fail
Comment out the 'next-safe-action/hooks' import and the useAction invocation further down
See test pass

Expected behavior
The test should pass without failing due to how React is being imported.
Reproduction example
https://stackblitz.com/edit/vitest-dev-vitest-6lgc1a?file=test%2Fbasic.test.tsx
Operating System
macOS
Library version
6.0.1
Additional context
No response

Hi @ludwigbacklund, thanks for opening this issue. I switched from React hooks named imports to a namespace import in the new beta version, that you can install it with:
npm i next-safe-action@beta

This should fix the problem with Vitest. Please let me know if everything works fine with the new release, if that's the case, I'll publish a new version in the stable channel soon. Thank you!

@TheEdoRan Thanks! It works 👍


RPI Flying Club

##Server name:

The name of the server or the club it is associated with.

RPI Flying Club
##Server link:

Link to the server. Feel free to also include links to an associated website and
social media accounts.

https://discord.gg/bjMzfjZ
Tags:

These are the tags that appear at the bottom of the server listing. These are not
linked to anything but are useful for users trying to find a server using Control-F.

Club, Flying, Aviation, Aerospace, Hobby, Enthusiast
Server description

The description of the server or the associated club.

The RPI Flying Club is a group of aviation enthusiasts who host a variety of events on and off campus! We do flying trips, attend air shows, host social and academic events, and host an annual ground school & flying lesson. No flying experience is required - all are welcome.

^ club logo

Added!


Intensive Care data from NICE

First of all thank you so much for the efforts! It was the best efforts on getting all the numbers together I saw and thank you for that.
Regarding the IC data from NICE... understand you said it was experimental but I noticed that it has stopped updating for 4 days. What's the plan on this? Is there temporary issues on getting the data, or is this dataset being deprecated?
thanks!

NICE changed a couple of things. Unfortunately, there was no time to work on this during the week. Today I will post the updated dataset (Struggling with one column).
There is a lot more in this dataset, so I'm working on some scripts to extract this as well. When this is done, I will remove the experimental flag.
Sorry for the inconvenience.

Thank you for the help! Looking forward this the new dataset.
A related question: I saw you have IC data from another source and the reading is quite different - how would you read into this? Which one would you think is more trustworthy/accurate?

I noticed that the new-intake data set from the nice site is the only one to contain 2 series instead of 1 as do the others. Both series show the same date range as any other but the values differ significantly. How di I read this?
KR, Jan van Mastbergen

@elvissey1984 The one of LCPS is very useful because it gives an accurate overview. It is updated once a day. NICE has more variables and is updated multiple times a day. The latter one is something you have to keep in mind for some applications.
@janvanmastbergen First col is the actual number. The second is the number of patients not tested yet, but highly likely affected by the virus. Therefore, the difference is large.


feat: support canada central 1 region

Issue #, if available:
https://github.com/aws-greengrass/aws-greengrass-gdk-cli/issues/132
Description of changes:
Remove region enum validation from config if users use an invalid region they will get an error like this one
=============================== ERROR ===============================
Could not publish the component due to the following error.
Failed to publish new version of component with the given configuration.
Error while fetching account number from credentials.
Could not connect to the endpoint URL: "https://sts.invalid-region.amazonaws.com/"

Why is this change necessary:
Users hosting gg on Canada can not use the gdk.
How was this change tested:
Manually tested publishing a component to ca-central-1

May

Do we need this validation at all? Can we just remove it?

Trying to call Greengrass APIs in a region that we don't exist will fail already, I don't really want us to maintain an additional listing.

True let me see if we can remove that

Reverted removing the validation for regions. @saranyailla had a great point which is that we upload the s3 artifacts before creating the gg component. Not adding the validation will with the current version lead to uploading something to s3 and failing to create the component on a region we don't support.
We can look into improving this later and change it to check if the region is supported by making an api call at the beginning of the whole process.

https://stackoverflow.com/questions/56669224/boto3-list-available-services-in-a-region


Deploy Mongodb as a StatefulSet

Action Item
mongodb shall be deployed as a StatefulSet.
Details
Currently, we are deploying our mongodb as a k8s Deployment with Recreate strategy and 1 replica.
To guarantee zero-downtime, and also high availability, it is recommended to use a StatefulSet for deploying the database.
As a proof of concept, I have deployed the database with the following configuration:
---
apiVersion: v1
kind: Service
metadata:
  name: mongo
  labels:
    name: mongo
  annotations:
    service.alpha.kubernetes.io/tolerate-unready-endpoints: 'true'
spec:
  ports:
  - port: 27017
    targetPort: 27017
  clusterIP: None
  selector:
    role: mongo
---
apiVersion: apps/v1
kind: StatefulSet
metadata:
  name: mongo
spec:
  serviceName: "mongo"
  selector:
    matchLabels:
      app: mongo
  replicas: 3
  template:
    metadata:
      labels:
        role: mongo
        environment: test
        app: mongo
    spec:
      serviceAccountName: keptn-default
      securityContext:
        fsGroup: 184
      terminationGracePeriodSeconds: 10
      containers:
        - image: "docker.io/centos/mongodb-36-centos7:latest"
          name: mongo
          args:
            - run-mongod-replication
          ports:
            - containerPort: 27017
          volumeMounts:
            - name: mongo-rs-volume
              mountPath: /var/lib/mongodb/data
          env:
            - name: MONGODB_DATABASE
              value: "keptn"
            - name: MONGODB_USER
              valueFrom:
                secretKeyRef:
                  name: mongodb-credentials
                  key: user
            - name: MONGODB_PASSWORD
              valueFrom:
                secretKeyRef:
                    name: mongodb-credentials
                    key: password
            - name: MONGODB_ADMIN_PASSWORD
              valueFrom:
                secretKeyRef:
                    name: mongodb-credentials
                    key: admin_password
            - name: MONGODB_REPLICA_NAME
              value: "mongodb-replicaset"
            - name: MONGODB_KEYFILE_VALUE
              value: "mykeyfilevalue"
            - name: MONGODB_SERVICE_NAME
              value: mongo
          readinessProbe:
            exec:
              command:
                - stat
                - /tmp/initialized
          securityContext:
            runAsNonRoot: true
            runAsUser: 184
            readOnlyRootFilesystem: false
            allowPrivilegeEscalation: false
  volumeClaimTemplates:
  - metadata:
      name: mongo-rs-volume
    spec:
      accessModes: [ "ReadWriteOnce" ]
      resources:
        requests:
          storage: 1Gi

after applying this StatefulSet in the keptn namespace, I verified that the three replicas have been created:
$ kubectl get pods -n keptn -lrole=mongo
NAME      READY   STATUS    RESTARTS   AGE
mongo-0   1/1     Running   0          71m
mongo-1   1/1     Running   0          71m
mongo-2   1/1     Running   0          70m

Afterward, I tried to update the database by changing the image tag: As expected the update was applied to one pod one after another, while always maintaining at least one running instance of the replica set.
In the services using the database, the connection string had to be adapted by appending the name of the replica set, e.g.:
mongodb://<user>:<password>@mongo:27017/keptn?replicaSet=mongodb-replicaset

NOTE: One drawback of deploying the database as a StatefulSet is that it is not straightforward to use kubectl port-forward to connect MongoDB compass to the database anymore, which has a negative impact on the developer experience. The reason for that is that when connecting to a replicaSet, the mongodb cluster returns a list of available Hostnames to connect to, e.g.:
mongo-0.mongo.keptn.svc.cluster.local (primary)
mongo-1.mongo.keptn.svc.cluster.local
mongo-1.mongo.keptn.svc.cluster.local

These URLs are then used by Mongodb Compass to connect to an instance of the replicaset, but of course these cluster-internal server names cannot be resolved on the local developer machine.
Maybe this can be addressed by using a proxy service within the cluster and connecting to that via MongoDB Compass.
NOTE: Maybe another option to consider is to use the mongodb K8s operator to deploy the database. As documented here, this one seems to handle upgrades to the database more efficiently, as documented here: https://github.com/mongodb/mongodb-kubernetes-operator/blob/master/docs/architecture.md#example-mongodb-version-upgrade
Acceptance Criteria

[ ] mongodb deployed as a stateful set which also supports the rollingUpdate deployment strategy
[ ] mongodb can also be accessed directly via port forwarding
[ ] if possible , use an external helm chart as dependency in our installer chart (like it's done for NATS) (this should also be compatible with openshift)

Definition of Done

[ ] feature implemented and reviewed
[ ] installer adopted

When working on this Issue, I encountered a number of problems:
Backup and restore data from previous Keptn installation

Need to backup and restore previous db from Standalone to ReplicaSet

Idea: Post-install job that retrieves db using mongodump from Standalone and uploads it with mongorestore to new ReplicaSet

Inconsistend behavior across Keptn installation attempts

Configuration of StatefulSet:

Getting Authentication errors when trying to connect - one time it worked, then I reinstalled Keptn and then the connection was not working anymore
At one point, for some reason, two replicas are running, while the third one runs into a CrashLoop

Previous configurations seem to not be forgotten even when deleting the StatefulSet and creating a new one:

E.g. Tried to connect previous standalone instance to replicaSet to have the previous data available automatically - Reinstalled everything eventually because I ran into an error - After the new installation has been finished, the pods of the replicaSet tried to connect to the old Standalone pod that was not there anymore
Therefore, I deleted the Keptn installation again, and created a new replicaSet to make the replicas forget about the old Pod. However, in that case, the new replicaSet detected that there was a configuration of the previous replicaSet on the PV, which again lead the replicaSet to not work properly. Uninstalling the Keptn installation, renaming the PV and reinstalling everything finally lead to a working installation. Then I reinstalled everything with the same configuration that was working before and afterwards the connection to the replicaSet was again not working :-(

Resource consumption:

Need to keep previous mongodb deployment+svc to migrate data to new replicaSet

Thank you @bacherfl for your research and findings. I created #5369 as a follow-up!


GPU Unpack, take four

Add support for GPU-based unpacking and quantization (fourth attempt). This includes:

GPU functions for unpacking integer data into 'i8'/'ci8'
Functions to unpack integer data and promote to float/double
Support for unpacking 1-bit data as:

0 unpacks to -1
1 unpacks to 1

Preliminary support for packing into 'i2'/'ci2' and 'i1'/'ci1'. Full support held up by a check for padded arrays.

Codecov Report

Merging #107 into master will increase coverage by <.01%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master     #107      +/-   ##
==========================================
+ Coverage   65.88%   65.89%   +<.01%
==========================================
  Files          41       41
  Lines        3834     3835       +1
==========================================
+ Hits         2526     2527       +1
  Misses       1308     1308

Impacted Files
Coverage Δ

python/bifrost/DataType.py
63.49% <66.66%> (+0.29%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd5161a...75d7896. Read the comment docs.

This is like take three but puts the new GPU quantizer/unpacker into .cu and .hu files to preserve the history in quantize.cpp and unpack.cpp.  This also adds additional unit tests for the GPU functions and the promotion functions.

Coverage increased (+0.006%) to 62.201% when pulling 75d7896e4ad78e8e367492a79a1723d8e0d33b64 on jaycedowell-gpu-unpack2 into cd5161a02ae77ee6e23c2c8777ed254c9316b08a on master.

Looks good to me! @benbarsdell do you have any issues with this?

I'm not sure what happened to the CI tests here; any ideas?. All tests pass when I run this branch locally.

I'm not sure what is going on here.  I just triggered a build of master and ended up with the same error that kills this PR.  I think the culprit may be:
test_block.py:315: UserWarning: loadtxt: Empty input file: ".log.txt"   result = np.loadtxt(self.logfile).astype(np.float32).view(np.complex64)
although I don't fully understand what this means.

That's interesting.  I restarted a build from the jaycedowell-gpu-unpack2 branch that was previously marked as successful and it failed.

Ah, it's the NumPy version.  I rolled back the NumPy version in the .travis.yaml file from the latest (1.14.3) to 1.13.3 using the jaycedowell-travistest branch and the build works.

Making sure that files are closed after np.savetxt() is called with a file handle fixes the testing problem.

Thanks for tracking that down Jayce!


Fix findall helpers as per phonogram solution

function findall(pattern, string) {
  const matches = [];

  if (!pattern.global) {
    const result = pattern.exec(string);

    if (result)
      matches.push(result);

    return matches;
  }

  let match;
  while (match = pattern.exec(string))
    matches.push(match);

  // Resetting state of the Regex for safety
  pattern.lastIndex = 0;

  return matches;
}

False alarm.

No. In fact this is to prevent infinite loops.


[EmbeddingAPI] Add usecase for XWalkView theme-color support disable-…

…able on Android
-Add usecase for XWalkView theme-color support disable-able on Android
-Cover the XWalkActivity and XWalkInitializer two ways
Impacted tests(approved): new 2, update 0, delete 0
Unit test platform: [Android]
Unit test result summary: pass 2, fail 0, block 0
BUG=https://crosswalk-project.org/jira/browse/XWALK-6440

@Shao-Feng please help to review.


chore(main): release veto 0.7.1

:robot: I have created a release beep boop
0.7.1 (2024-12-05)
Bug Fixes

veto: add custom to refineString (da969ac)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

veto-v0.7.1
:sunflower:


Emojis with mixed skin tone variants not rendering correctly

The latest emoji updates support handshake emojis with mixed skin tone variants. This is not rendering/working correctly currently.
When selecting the handshake, all the "half handshake" variants appear in the popup:

If one is selected, it renders two emojis side by side in the emitted result:

This is similar to the couple emojis ("with heart", "kissing", etc.):

This one overflows in the preview area:

Apple has a nice interface for these types of emojis:

You can select the generic yellow one in the bottom left, or to construct a mixed one, the top row shows the left hand variants and the bottom row shows the right. You can click in each row to set the skin tone of each side, then click the final emoji in the bottom right.
Tasks
[ ] Find a way to identify such mixed variant emojis
[ ] Provide the alternative variant popup for these
[ ] If variant popup not used, make sure the weird double rendering issue shown above does not happen --> use the generic yellow one.

Some more details:
The variants exposed by the emoji data appear to be the two "halves":

Once the correct variant is chosen, the two glyphs need to be superimposed on top of each other.

Twemoji seems to handle this already:

The mixed tone handshake is part of Emoji 14, this looks to be a rendering error for the OS not supporting it yet. It renders the emoji character sequence the only way it knows how.
Looking at the emojibase data, it looks like each variant also has a version field, so we can filter out unsupported variants to prevent the rendering issues.

Update: Even with Emoji 14 support, these are still not rendering correctly in some browsers. They look ok in Safari:

But render incorrectly in Chrome:

Chrome bug here: https://bugs.chromium.org/p/chromium/issues/detail?id=1310282&q=emoji&can=2

Emoji variants with a version are filtered out when they don't match the current version. As for rendering issues, there's not much else that can be done if it's a browser bug other than provide a note in the documentation.
Closing this for now.


failed to execute script 'discord_token_grabber' due to unhandled exception: No module named 'requests'

when they download it and run it it shows
File "resources/discord_token_grabber.py",line 5, in  ModuleNotFoundError: No module named 'requests'
https://cdn.discordapp.com/attachments/1265128758025912331/1269561703272677376/image.png?ex=66b082f9&is=66af3179&hm=0aeab065e4b1743cd4ae85b43589a776d6a0d940c8d50ab012cf4ebdc42acc45&

Possibly dual hooked, don't try it again.

Possibly dual hooked, don't try it again.

Its not, the token grabber makes requests to get more info such as billing and nitro.

uninstall python 3.12, install python 3.11.4, rebuild and it will work and no its not dual hooked, if you think so then just check the source code


Use both .eh_frame and .debug_frame

.debug_frame is quite similar to .eh_frame, but some binaries have one and not the other, or have a mix of things in both. In this commit, we construct things from both.
We don't have much experience with our .debug_frame parser in the real world, so for now if anything is correpted or fails parsing that one, we just fall back to the old behavior of using only .eh_frame and log a warning / bump a metric. After we gain some more confidence, we can reconsider that logic.
Why?
Various old versions of gcc apparently didn't put everything in .eh_frame by default, at least on aarch64. This seems to be why our python tests are failing.
Test Plan
Not tested yet, but after we fix the issue with failing to unwind past main due to missing dwarf info, this should improve the state of aarch64 python integration tests.

I've updated the PR to use Go runtime VDSO data for unwinding from within VDSO stacks.

don't merge, this still is broken somehow


Uncaught (in promise) Error: Setting up fake worker failed: "Cannot read property 'WorkerMessageHandler' of undefined".   at pdf.js:2336

Attach (recommended) or Link to PDF file here:
Configuration:

Web browser and its version:
Operating system and its version:
PDF.js version:2.9.359 2.8.335 2.5.207 2.4.456
Is a browser extension:

Steps to reproduce the problem:

All version I had tried to reinstall. First I uninstall pdfjs-dist Second I install<EMAIL_ADDRESS>or and so on.

var pdfjsLib = require('pdfjs-dist')
// import { TextLayerBuilder } from 'pdfjs-dist/web/pdf_viewer'
pdfjsLib.GlobalWorkerOptions.workerSrc = require('pdfjs-dist/build/pdf.worker.js')
import 'pdfjs-dist/web/pdf_viewer.css'
const CMAP_URL = './cmaps/'
var container
export default class DrawPdf {
static getPDF(url) {
const loadingTask = pdfjsLib.getDocument({
url: url,
cMapUrl: CMAP_URL,
cMapPacked: true
})
loadingTask.promise.then(function(pdfDocument) {
  // Document loaded, retrieving the page.
  console.log(pdfDocument)
})

}
What is the expected behavior? (add screenshot)
Please help me to fix the problem.
What went wrong? (add screenshot)
Uncaught SyntaxError: Unexpected token '<'
Uncaught (in promise) Error: Setting up fake worker failed: "Cannot read property 'WorkerMessageHandler' of undefined".   at pdf.js:2336
Link to a viewer (if hosted on a site other than mozilla.github.io/pdf.js or as Firefox/Chrome extension):

Closing since this is a duplicate of many others is https://github.com/mozilla/pdf.js/search?q=workermessagehandler+of+undefined&type=issues and https://github.com/mozilla/pdf.js/issues/11787#issuecomment-610867258 is most likely the cause of this.


Unstoppable ERROR Flood After GridMap Addition Undo

Godot version:
99da466
OS/device including version:
Ubuntu 17.10
Issue description:
Scene.  Bewildered user sits in front of Godot and wants to make a game.  User creates project and a simple scene, comprising a Camera and a MeshInstance of a Cube.  Success!
Scenario.  User adds GridMap to Camera and is presented with the following errors:
ERROR: get_meta: Condition ' !metadata.has(p_name) ' is true. returned: Variant()
   At: core/object.cpp:1025.
ERROR: get: Condition ' !p_rid.is_valid() ' is true. returned: __null
   At: core/rid.h:154.
ERROR: instance_set_visible: Condition ' !instance ' is true.
   At: servers/visual/visual_server_scene.cpp:620.
ERROR: get_meta: Condition ' !metadata.has(p_name) ' is true. returned: Variant()
   At: core/object.cpp:1025.
ERROR: get: Condition ' !p_rid.is_valid() ' is true. returned: __null
   At: core/rid.h:154.
ERROR: instance_set_visible: Condition ' !instance ' is true.
   At: servers/visual/visual_server_scene.cpp:620.
ERROR: get_meta: Condition ' !metadata.has(p_name) ' is true. returned: Variant()
   At: core/object.cpp:1025.

User immediately realizes his horrible mistake (not really, that silly user) and undoes it with CTRL+Z.
User is presented with an endless stream of:
ERROR: get_global_transform: Condition ' !is_inside_tree() ' is true. returned: Transform()
   At: scene/3d/spatial.cpp:266.
<snip, looping>

Steps to reproduce:
Be the silly user.
Minimal reproduction project:
Min3DExample.zip

Gridmap module code is here
https://github.com/godotengine/godot/tree/master/modules/gridmap

OK, I've been trying to figure this out. Here's what I've found.
After pressing CTRL+Z GridMapEditor still stores GridMap in its node field. According to backtrace editor receives NOTIFICATION_PROCESS notification and subsequently calls get_global_transform() on the underlying GridMap. Because creation of this GridMap has been canceled is_inside_tree() of get_global_transform() returns false which causes one error in log. I guess that NOTIFICATION_PROCESS is signaled instantly which creates the flood.
I've started familiarizing myself with Godot just a few days ago, so the following is just my guess.
I saw that several editors subscribe to "node_removed" signal and set their underlying Node to NULL if it has been removed. GridMapEditor has similar _node_removed method but it's not even binded. I believe that the solution is the folowing: bind _node_removed in _bind_methods() and add this line somewhere:
get_tree()->connect("node_removed", this, "_node_removed");

I'm not sure about the last part. I saw that some editors calls connect during handling of NOTIFICATION_ENTER_TREE others do it when they handle NOTIFICATION_READY. GridMapEditor already handles NOTIFICATION_ENTER_TREE, so I added call to connect at the beginning of the corresponding if branch. This removed error flood problem, so I can create a two-line PR. Just not sure that I'm doing everything right.
During my investigation I also noticed that this combination (create node and then immediately CTRL+Z) is handled wrongly by many editors (may be all of them?). After CTRL+Z is pressed created object disappears but the editor is still there. This allows to press one of its menu options, for examples, which immediately leads to a crash. Proposed solution fixes error flood problem but not this one. I'm not sure may be this CTRL+Z problem is a more general one. May be it's a separate problem that requires separate issue.

This removed error flood problem, so I can create a two-line PR.
@Ivan-Veselov If you still have the code around, you could make the PR.


Skip tests on Mono if KOREBUILD_TEST_SKIPMONO is set.

This change will enable us to run tests on CoreCLR on the CI.
cc @muratg @Eilon @victorhurdugaci

Why not use the FrameworkSkipConditionAttribute?

@victorhurdugaci Because I'd have to put it on every test in every repo. We want to be able to run tests on CoreCLR only across the board. The idea is to have two CIs per non-Windows system, one where we run tests on Mono and another where we run tests on CoreCLR.

Can you wait until I merge the dotnet support (1h or so) and then make the same change in _dotnet-test too?

Sure.

Ping.

:watch:

Checking for 1 or true per @Eilon's order :grin:

:shipit:


Create benchmark tests for RAS

As a first step for #587, implement some benchmark tests for RelationalAlgebraTests.

@jonasrenault can we merge this PR?

@jonasrenault can we merge this PR?

I'm not entirely satisfied. I think I should maybe rework the test to account for join orders, with a test where the order is really bad and one where it's optimal to see the perf difference?

I'm not entirely satisfied. I think I should maybe rework the test to account for join orders, with a test where the order is really bad and one where it's optimal to see the perf difference?


feat(benchmarks): react19/next15

Depends on https://github.com/risc0/risc0/pull/1924
This PR includes these changes:

react compiler seems to break column visibility picker, so turned off for the time being -- can still safely migrate to react 19
ppr now works properly

I'd like to stay on stable versions for production. Is there a feature in canary that you'd really like to have?

I'd like to stay on stable versions for production. Is there a feature in canary that you'd really like to have?

Thing is, Vercel really changed how caching works in NextJS v15 (for the better)
On 14 everything was cached by default, now on 15 it's the opposite, caching is now opt-in. So it makes for more predictable caching behavior.


Makefile: Remove deppy dependency

Update the Makefile and remove deppy dependency.
Also updates BundleInstance to BundleDeployment to be consistent with new RukPak naming.
Signed-off-by: Catherine Chan-Tse<EMAIL_ADDRESS>

Hmm weird.
/approve
/lgtm


Fix various issues and add missing semantics.

AsyncFunction Awaited Fulfilled and AsyncFunction Awaited Rejected must return something. To keep it simple I've used the value of the resumed computation.
AsyncArrowFunction changes:

AsyncArrowBindingIdentifier is used as the parameters production (cf. call to AsyncFunctionCreate), parameters productions need to define BoundNames, ExpectedArgumentCount, IsSimpleParameterList, ContainsExpression and IteratorBindingInitialization (see FunctionDeclarationInstantiation). (Also: Definitions in ES2015 for arrow functions are incorrect - need to file a spec bug.)
Remove BoundNames definition, not needed.
Add missing LexicallyDeclaredNames, LexicallyScopedDeclarations, VarDeclaredNames and VarScopedDeclarations definitions. It's necessary to define these static semantics for both AsyncConciseBody productions; the definitions for ConciseBody in ES2015 are incomplete. That's a spec bug, I still need to file an issue for it. (Later: Never mind, I've misread the chain production definition from 5.1.1).

Add missing SuperCall early errors for AsyncFunctionDeclaration and AsyncFunctionExpression.
Remove unnecessary HasDirectSuper for AsyncFunctionDeclaration and AsyncFunctionExpression.
IsConstantDeclaration: Change AsyncFunctionDeclaration to create mutable bindings. (Is this correct?)
Add missing evaluation semantics for AsyncFunctionExpression.
Add missing PropertyDefinitionEvaluation semantics for AsyncMethod.
Add early error restriction for AwaitExpression in ArrowFunction.
Add early error restrictions for await as identifier when [Await] parameter is present. (Is this correct?)
Add more modified static semantics (IsFunctionDefinition, IsValidSimpleAssignmentTarget).
And other minor issues.

@anba has signed the spec text CLA.