Delete a Wishlist

As a customer
I need to delete the entire wishlist
So that I can easily remove all items from the wishlist at once, instead of having to delete them one by one.
Details and Assumptions

A wishlist may or may not contain any items, hence, allowing the user to delete it.
Once deleted, the user gets a confirmation about the same and wishlist details are deleted from the database.
If the wishlist is not empty, individual items from the wishlist are first cleared.

Acceptance Criteria
Given a valid wishlist ID,
When customer requests to delete it
Then all items inside the wishlist are first deleted and then the wishlist itself.

I created another branch to resolve the conflict issues caused by changes in the file hierarchy.


EXC_CRASH (Code Signature Invalid) when running tests on macOS

It seems that macOS Catalina 10.15.7 have troubles with runnings macOS downloaded for test from .vscode-test folder. It seems there is some problems with singing:
Exception Type:        EXC_CRASH (Code Signature Invalid)
Exception Codes:       0x0000000000000000, 0x0000000000000000
Exception Note:        EXC_CORPSE_NOTIFY

However codesign --verify --verbose Visual\ Studio\ Code.app/Contents/MacOS/Electron says that's everything ok, and even if I move/coppy Visual Studio Code.app from .vscode-test to the desktop it runs normally.

VSCode Version: 1.52.1
OS Version: macOS Catalina 10.15.7 (19H114)

Steps to Reproduce:

Clone on macOS Catalina 10.15.7 extension hello world example https://github.com/microsoft/vscode-extension-samples/tree/master/helloworld-test-sample
Run npm install && npm run tests

Does this issue occur when all extensions are disabled?: Yes/No

From: https://developer.apple.com/library/archive/qa/qa1884/_index.html
Q:  When I run my Mac app, it crashes immediately, and the crash log says Exception Type: EXC_CRASH (Code Signature Invalid). What is going on here?
A: The crash log indicates that your app is signed with your Mac App Store distribution identity, with the certificate’s Subject Common Name starting with “3rd Party Mac Developer Application.” Mac apps signed this way can no longer be run directly. Here’s the background on this.
Over time, more Mac App Store technologies have been added that require entitlements that come from a provisioning profile. This started with push notifications and iCloud. Later, Game Center and Maps were added to the list.
Recently, the com.apple.developer.team-identifier entitlement was added to all new Mac provisioning profiles. This means that, going forward, distribution builds of Mac apps cannot be run directly; they are for submitting to iTunes Connect for app review only
Instead, developers should adopt the Archive Build Workflow in QA1778: How to reproduce bugs reported against Mac App Store submissions for testing the builds that they plan to submit for the Mac App Store. On Xcode 6, select Export as a Mac Application. You won't see any chance to select your development signing identity, but Xcode will export the app from the archive as it was signed at build time. So the result will be the same.
You can create an installer package containing your development-signed app by hand with the productbuild tool, like this:
$ productbuild --component Sample.app /Applications --sign “3rd Party Mac Developer Installer:" Sample.pkg

Then install the package as documented in Testing the Mac Installer Package:
$ sudo installer -store -pkg Sample.pkg -target /

This workflow means that you will need to add your beta testers’ test systems to your Mac Developer Program account so they will be able to run your app.
Another possibility is to use Xcode Organizer > Export > Export a Developer ID-signed Application. Developer ID-signed apps can be run by anyone. However, code that uses technologies only available to Mac App Store apps, such as receipt validation, iCloud, and push notifications, will not work if your app is Developer ID-signed. You might need to temporarily disable those parts of your app if you opt for the Developer ID testing approach.

Does this issue persist with latest stable 1.74 ?

Confirm that on 1.74.1 there is no problem.

Thanks for confirming.

@deepak1556 Which commit and/or PR did fix this?
(link please, no matter if vscode or vscode-test.)
But this is a binary signing related, hence maybe there is no such commit?

Btw I forget to mention - since 21 Jan I've changed laptop and issue doesn't reproduce on macOS Monterey 12.6.


Really great job

You really made the best sky charts I've ever seen. I fully support your project, I'm making an astronomy discord bot and I'm going to use these charts. I'll make sure that every time you create a chart, the name of the library is mentioned under it :)

@EsatAkkasoglu thanks so much for your kind words! Let me know when your astronomy bot is up and running, I'd love to check it out.

@EsatAkkasoglu hey! I wanted to let you know I created a discord server for starplot, where I'm hoping users and developers of starplot can get together and share thoughts/ideas/feedback and just general astronomy chat :) I remember you mentioning you're building a discord bot so it'd be great to see you (or the bot! haha) on the starplot server! Here's the invite: https://discord.gg/bwazdyD7


[tool_crash] TlsException

Command
flutter doctor -v

Steps to Reproduce

git clone https://github.com/flutter/flutter.git -b master
flutter upgrade
flutter doctor -v

System
Windows 11 Build 25300-dev
Ram: 32GB
Processor: Ryzen 9 5000HS
Logs
TlsException
#0      new _HttpClientConnection.<anonymous closure> (dart:_http/http_impl.dart:2098:9)
#1      _rootRunBinary (dart:async/zone.dart:1422:47)
#2      _CustomZone.runBinary (dart:async/zone.dart:1314:19)
#3      _CustomZone.runBinaryGuarded (dart:async/zone.dart:1224:7)
#4      _BufferingStreamSubscription._sendError.sendError (dart:async/stream_impl.dart:358:15)
#5      _BufferingStreamSubscription._sendError (dart:async/stream_impl.dart:376:7)
#6      _BufferingStreamSubscription._addError (dart:async/stream_impl.dart:280:7)
#7      _SyncStreamControllerDispatch._sendError (dart:async/stream_controller.dart:778:19)
#8      _StreamController._addError (dart:async/stream_controller.dart:656:7)
#9      _StreamController.addError (dart:async/stream_controller.dart:610:5)
#10     _rootRunBinary (dart:async/zone.dart:1422:47)
#11     _CustomZone.runBinary (dart:async/zone.dart

Hi @Mic-360
(Just to confirm this) Does the issue happen when executing flutter doctor -v? Is there any remaining crash log that you can provide?

Just after pulling from git i ran flutter doctor -v and there was no other log. I ran it again the problem got fixed.

@Mic-360 Can you please check whether the issue also happens on the stable channel? Or is it only on the master channel?
Also, as I understand right, the issue is only happening once time and you don't see it currently?

It is only in beta and master channel.

Labeling the issue for the team's attention.

@Mic-360 do you still see this error on the newer versions of Flutter ? If not can you please close the issue.

Closing issue as we have not heard back from the user, please reopen if you still think there is a problem and reproduction instructions exist.


Simulate long life decays

To be able to simulate long life decays we have to use G4RadioactiveDecay::SetThresholdForVeryLongDecayTime(double) with a proper threshold. For example here I set 1e12 years. For reference, the mean life of U238 is 4.5e9 and for Th232 1e10 years
With this change, it seems that the U238 decays:
./radiation-decay-secondaries -n 1 -p U238 -d G4_CONCRETE 100 -o test.root

And Th232:
./radiation-decay-secondaries -n 1 -p Th232 -d G4_CONCRETE 100 -o test.root

See "Note on the time threshold for radioactive decay of ions" in this link: https://geant4-userdoc.web.cern.ch/UsersGuides/ForApplicationDeveloper/html/TrackingAndPhysics/physicsProcess.html#particle-decay-process

Looks good, thanks @mariajmz !


IGNITE-9171  Use lazy mode for default

Also I have not noticed if query originating node failure is handled. We need to cleanup resources left by lazy query execution in that case.


Bug: When closing Glance, jumps to the end of the buffer

When I close the Glance window without opening an item (i.e, q or esc), then the cursor jumps to the last line in the buffer, as if I had pressed G.
It seems my jump history is somewhat messed up by Glance: when I do jump to a definition/reference, jumping back leads me to the last line of the buffer as well instead of jumping to the actual location I opened glance from.

A far from ideal workaround I use for now:
hooks = {
	before_open = function(results, open, _)
		vim.cmd.mkview(3)
		open(results)
	end,
	after_close = function()
		local isOnLastLine = vim.fn.line(".") == vim.fn.line("$")
		if isOnLastLine then vim.cmd.loadview(3) end
	end,
},

Hey,
Do you by any chance run glance full height? How big is the preview compared to the active window?

Hi,
my window has a height of 29, and I set Glance to a height of 20

This could also happen when you have high scrolloff value configured

oh yes, indeed I do have a relatively high scrolloff value, namely 15.

okay, reducing the height to 12 indeed fixes the issue, even though it is a bit small...
So I tried changing the scrolloff, and this workaround to change the scrolloff before entering glance and restoring it after leaving glance seems to work. Maybe this could be added the glance?
hooks = {
	before_open = function(results, open, _)
		vim.opt_local.scrolloff = 0
		open(results)
	end,
	after_close = function()
		vim.opt_local.scrolloff = vim.opt_global.scrolloff:get()
	end,
},

great, thanks for the quick fix 😊

Should be fixed now, thanks for reporting!


ExampleServer on the readme not compiling

Hi, I'm trying to use uzhttp so obviously I was trying the example on the readme file but I can't compile it.
Error is
[error] /Users/yolo/uzhttp/src/main/scala/q/Main.scala:13:15: type mismatch;
[error]  found   : zio.ZIO[Any with zio.blocking.Blocking with zio.clock.Clock,Throwable,Nothing]
[error]     (which expands to)  zio.ZIO[Any with zio.Has[zio.blocking.Blocking.Service] with zio.Has[zio.clock.Clock.Service],Throwable,Nothing]
[error]  required: zio.ZIO[zio.ZEnv,Nothing,Int]
[error]     (which expands to)  zio.ZIO[zio.Has[zio.clock.Clock.Service] with zio.Has[zio.console.Console.Service] with zio.Has[zio.system.System.Service] with zio.Has[zio.random.Random.Service] with zio.Has[zio.blocking.Blocking.Service],Nothing,Int]
[error]       }.serve.useForever

Ok for the html case I managed to make it work just by wrapping it into ZIO.succeed(...)

Ok, looks like it works if one would mapError on the Response.fromResource(...)

Ah, this is because most of the Response.fromX constructors can fail with Throwable (because they call Java stuff) but your request handler has to only return HTTPError. The fact that you have to handle those Throwable isn't reflected in the README.
Maybe we should add a convenience thing that gives you an easy default way to map Throwable into HTTPError (e.g. turn FileNotFoundException into 404, everything else into 500. Something like that)

I guess. The Throwable comes from effectBlocking or similar right?

Yes, it's the default error type... we can't unilaterally refine it when there are filesystem calls and such involved. But we could provide a sensible default for when you don't want to deal with it.

Right. The ZIO.succeed part should be added though right?


Tracing needs a mock step

In Camel 4 we couldn't use exchanges for the changelog. Reason is that now a flow is used mostly as one exchange, instead of creating one for each step.
Alternatively we switched to steps. This means every Dovetail component/step is wrapped in a Camel step. This allows us to get a copy of the message and send it to Elastic each time a message goes through the step.
After testing this didn't work in all cases. When there was only one action in the step, there was no message to copy. This was reported to the Camel team, and should be fixed in Camel 4.7.0.

The mock step has been removed, and the tracing can be retested if still a each step in the flow is visible in the tracelog.


Adding barcode to existing product missing search

In v 1.2.5 I can not find a way to search for products when I want to add a barcode to existing product. The products are sorted in the same order they were added to Grocy which makes it almost impossible without a filter/search.
This was possible before the V3 redesign, I am just missing how? Or was it removed?

Same issue, I used to be able to start typing in the name of a product, but now the only option is to scroll through every product added to Grocy.


workflows/artifacts: use stable rustc to install elf2tab

This applies the same hack of tock/libtock-rs#486 to work around our current rust-toolchain being too old to build elf2tab.

Do we still want this with #513 merged? At the moment we're using the MSRV Rust toolchain to install elf2tab in the CI workflow (as well as on developer machines). The artifacts workflow should probably be synchronized with the CI workflow.
I was thinking we'd update the MSRV if a new elf2tab release requires a newer toolchain, but alternatively we could use the nightly toolchain to install elf2tab. Either option avoids adding a third toolchain to libtock-rs's dependencies.

I agree we wouldn't want this with #513. It doesn't make sense for us to target an MSRV if we can't use it to build a core piece of our toolchain, such as elf2tab. If elf2tab requires a newer version of Rust, let's bump our MSRV.


Update cats-tagless-core, ... to 0.12

Updates

org.typelevel:cats-tagless-core
org.typelevel:cats-tagless-macros

from 0.10 to 0.12.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.typelevel" } ]

labels: library-update

Superseded by #276.


Cannot run bot, please help

I am trying to run bot from raspberry pi 3
after i got libencrypt.so on the bot root folder and run the command
this is error below:
(env) pi@raspberrypi:~/OpenPoGoBot $ python pokecli.py config/config.yml
Traceback (most recent call last):
File "pokecli.py", line 42, in
ssl._create_default_https_context = ssl._create_unverified_context  # type: ignore
AttributeError: 'module' object has no attribute '_create_unverified_context'
OS: raspbian

this need a pythin rather up to date, what version are you using?
you can try to disable those lines also

It is Python 2.7.9

Did you pip install -r requirements.txt?

Yes, I did
Follow instruction below
git clone --recursive https://www.github.com/OpenPoGo/OpenPoGoBot
cd OpenPoGoBot
virtualenv env
source env/bin/activate
pip install -r requirements.txt

Try removing lines 40 to 42 in pokecli.py

did it work?

nope, it gave another error below

(env) pi@raspberrypi:~/OpenPoGoBot $ python pokecli.py config/config.yml
[2016-08-17 22:41:11] [Plugins] Loaded plugin "egg_incubator".
[2016-08-17 22:41:11] [Plugins] Loaded plugin "spin_pokestop".
[2016-08-17 22:41:11] [Plugins] Loaded plugin "recycle_items".
[2016-08-17 22:41:11] [Plugins] Loaded plugin "evolver".
[2016-08-17 22:41:11] [Plugins] Loaded plugin "catch_pokemon".
[2016-08-17 22:41:11] [Plugins] Loaded plugin "transfer_pokemon".
Traceback (most recent call last):
File "pokecli.py", line 88, in
main()
File "pokecli.py", line 73, in main
kernel.boot()
File "/home/pi/OpenPoGoBot/app/kernel.py", line 66, in boot
for plugin in self.container.get_by_tag('plugin'):
File "/home/pi/OpenPoGoBot/app/service_container.py", line 88, in get_by_tag
services.append(self.get(service_id))
File "/home/pi/OpenPoGoBot/app/service_container.py", line 77, in get
self._services[service_id] = self._make_service(service_id)
File "/home/pi/OpenPoGoBot/app/service_container.py", line 50, in _make_service
args.append(self.get(service_arg[1:]))
File "/home/pi/OpenPoGoBot/app/service_container.py", line 74, in get
raise ServiceNotFoundException('Service "{}" was not registered.'.format(service_id))
app.exceptions.ServiceNotFoundException: Service "config.egg_incubator" was not registered.

did you rename all .example files in config directory to .yml files to configure the bot?

Closing due to no answers. Reopen it if needed.


Error NU1001: The dependency Microsoft.AspNetCore.Mvc.Formatters.Xml >= 1.0.1 could not be resolved.

*** This seems to be a common/recurring issue with the dotnet tooling (Error NU1001: The dependency xxxxx could not be resolved) ***
I've a ASP.NET Core 1.0.1 project with a plain vanilla controller returning XML not Json.
This project references a csproj library (4.6.2). I had the solution building fine on the build server until I added the package Microsoft.AspNetCore.Mvc.Formatters.Xml reference to the ASP.NET Core project, that is when the build started failing with the error mentioned in the title.

Interesting enough, if I reference Microsoft.AspNetCore.Mvc.Formatters.Json package instead. The builds succeeds.
Also, the project builds and executes fine in VS. However on my build server,  I've been pulling my hair to resolve this build error.

My very simple build steps:
Step 1. Nuget restore MySolution.sln (I also verified that the pacakages are getting installed to the user profile .nuget folder)
Step 2. MSBuild MySolution.sln

dotnet CLI (1.0.0-preview2-003133)
Aspnet Core targeting  .NET 4.6.2 using Visual Studio 2015 Update 3
Nuget 3.4
TeamCity

Please help. This is a show stopper and I'm nearing a deadline and I've already spent way too much time.

@yishaigalatzer any ideas?
@stanuku there are pre-release builds of NuGet 3.5 at https://dist.nuget.org/index.html, maybe you could try one of those and see if it fixes it?
@pranavkm perhaps you have some idea on this as well?

Not entirely sure what the cause could be. Could you include the Package Manager output (View -> Output -> Show output from Package Manager) when you restore the project?

@stanuku do you have a repro project.json?

Thanks for your responses.
@Eilon: NuGet 3.5 didn't help.
@pranavkm: As I stated earlier, it builds and runs fine from VS 2015. The issue is on the build server. I actually installed 2015 community edition with update 3 on my build agent. Didn't help.
@davidfowl: Please see the extract from project.json below:
`{
"title": "xxxxx",
"copyright": "xxxx",
"description": "HTTP JSON API services",
"version": "1.0.0-*",
"dependencies": {
"Microsoft.AspNetCore.Mvc": "1.0.1",

"Microsoft.AspNetCore.Routing": "1.0.1",
"Microsoft.AspNetCore.StaticFiles": "1.0.0",
"Microsoft.AspNetCore.Server.IISIntegration": "1.0.0",
"Microsoft.AspNetCore.Server.Kestrel": "1.0.1",
"Microsoft.AspNetCore.Diagnostics": "1.0.0",
"Microsoft.Extensions.Configuration.EnvironmentVariables": "1.0.0",
"Microsoft.Extensions.Configuration.FileExtensions": "1.0.0",
"Microsoft.Extensions.Configuration.Json": "1.0.0",
"Microsoft.Extensions.Logging": "1.0.0",
"Microsoft.Extensions.Logging.Console": "1.0.0",
"Microsoft.Extensions.Logging.Debug": "1.0.0",
"Microsoft.Extensions.Options.ConfigurationExtensions": "1.0.0",
"EntityFramework": "6.1.3",
"Ninject": "<IP_ADDRESS>",

"Swashbuckle": "6.0.0-beta902",
"FAKE": "4.41.5"
},
"tools": {
    "Microsoft.AspNetCore.Server.IISIntegration.Tools": "1.0.0-preview2-final"
},

"frameworks": {
    "net462": {
        "dependencies": {
            "xx.xx.Data": {
                "target": "project"
            },
            "xx.xx.Models": {
                "target": "project"
            },
            "xx.xx.Utils": {
                "target": "project"
            }
        }
    }
},

"buildOptions": {
    "emitEntryPoint": true,
    "preserveCompilationContext": true,
    "xmlDoc": true,
    "optimize": true,
    "define": [ "DEBUG" ]
},

"publishOptions": {
    "include": [
        "wwwroot",
        "**/*.cshtml",
        "appsettings.json",
        "web.config"
    ]
},

"scripts": {
    "postpublish": [ "dotnet publish-iis --publish-folder %publish:OutputPath% --framework %publish:FullTargetFramework%" ]
}

}
`

Can you share the log? What happens when you run restore from the commandline with verbose level of logging?

@yishaigalatzer: The restore is always successful (from VS, from command line, from build agent).
My two build steps again:

nuget restore MySolution.sln.
MSBuild MySolution.sln
Note: MySolution.sln is a mix of ASP.NET Core and a couple of class libraries targeting 4.6.2.

This below information might be of some help to you folks -
After further experiments, what I found is that if I run my build steps from command line (which runs under my login identity) on the build agent server all runs fine. However, the same steps when run under the build agent service identity, the MSBuild fails with the previously stated error.
My understanding is that NuGet 3.+ installs/restores the packages to the %userprofile% nuget cache. My build agent runs as "Local System" and so I checked in the profile folder for 'Local System' which is
C:\Windows\SysWOW64\config\systemprofile\.nuget\packages and I see all the packages. So restore definitely is fine.
However, I think MSBuild is having trouble resolving this dependency alone. If you see my project.json, I have other dependencies that are resolved just fine even from the build agent's process. There is something different  with this package 'Microsoft.AspNetCore.Mvc.Formatters.Xml' and also 'AutoMapper' that has the same issue.
Note: I tried both MSBuild (x86 and x64) and restore installs the packages into the SysWOW64 and System32 respectively. The build steps is what fails and only from the agent's process running as Local System.
Thanks for your time and any insights are appreciated. Just some much to deal with when you have an application to deliver.

@davidfowl @pranavkm @Eilon @yishaigalatzer
I think I solved (work around) the issue. I created a local user account on the build server and set the build agent's service to this user account. The build steps ran fine. So, apparently MSBuild running under 'Local System' has some sort of issue resolving (some of) the dependencies. Which weird because some  dependencies resolve fine.

Closing the issue, turns out when assigning the "Log on as" for the windows service, the "Allow service to interact with desktop" should be checked. That helped resolve the issue.
Sorry for the confusion.

@stanuku that's interesting. We just switched our Windows build agents to run as Local Service Accounts and they've been restoring and building AspNetCore repositories just fine. The build agents don't have the interaction checkbox ticked. The one thing we do as part of building on the CI is specify the NUGET_PACKAGES directory to a subdirectory of the working directory (%workingDir%/.nuget). Perhaps that too might help resolve this for you.

@pranavkm: I'm not too convinced either with my solution. However, I have other fishes to fry and get back to meeting the deadline...whether I like it or not

@stanuku Another workwaround for this issue is here https://github.com/NuGet/Home/issues/4277.
Also, there is still hope that it will be fixed.


add retry logic and set zagg_client to 2 retries

add custom patch to deal with exceptions in the exception path of urllib3

:+1:  i like this!


[FEAT ✨] Support landscape mode

When switching to landscape mode the detections appear erratic. Is there something we can do to support them better in the current version?

can you add a screenshot or a video showing what you mean with "detections appear erratic"?

Okay, can you please check if frame.orientation change when you rotate your device?
Currently I’m using frame’s orientation to determine MLKit orientation.

Oddly frame.orientation never changes. Orientation change does get captured with expo-screen-orientation though.
https://github.com/luicfrr/react-native-vision-camera-face-detector/assets/329887/729e4ba3-4328-4c12-918a-e8615c76f3f6

Okay I definitely need to update the documentation on frame.orientation as a lot of people seem to misunderstand what it actually means and I get asked about this almost daily.

Orientation is not fully implemented. I'm trying to raise money so I can implement orientation here: https://github.com/mrousavy/react-native-vision-camera/issues/1891
The orientation of the Frame is probably not what most people think under orientation. Maybe I can find a different name for it. But it is always the way you need to read the Frame to make sure it is up-right. That's because Camera sensors are often in landscape orientation and that means you need to rotate the Frame by 90deg to display it up-right. This is handled already for preview photo and video, but in Frame Processors you need to do it yourself - if I would always rotate the frame to be 90deg upright position, that would introduce a huge latency and performance bottleneck in the pipeline. So instead, ML models work by internally just reading the Frame rotated. That way I don't have to actually rotate any buffers around and it's much faster.

Hope this explains why it stays the same.

I'll do some tests and try to implement this feature ASAP. The problem is I'm busy with another project right now so I can't say when I'll have time to do this.
Anyway, if you want to try it yourself: orientation is handled on native side in these lines:
https://github.com/luicfrr/react-native-vision-camera-face-detector/blob/4d3629e426feadbdb9e223b025b9cfd7acc60af6/android/src/main/java/com/visioncamerafacedetector/VisionCameraFaceDetectorPlugin.kt#L251-L262
https://github.com/luicfrr/react-native-vision-camera-face-detector/blob/4d3629e426feadbdb9e223b025b9cfd7acc60af6/ios/VisionCameraFaceDetector.swift#L220-L231
a good start point is to set fixed values on native side and check if it works:
// ios
let image = VisionImage(buffer: frame.buffer)
image.orientation = .up //or .left or .right etc....

// android
val image = InputImage.fromMediaImage(frame.image, 0) // or 90, 180, etc...

maybe we can add the orientation prop on config so when orientation changes it will recreate face detector:
const orientation = someOrientationHook()
const { detectFaces } = useFaceDetector( {
  ... other props,
  orientation
} )

Or maybe get device's orientation on native side instead?

@gwendall I just released 1.7.0 version.
Can you please check if it really fix this issue?

@gwendall I just released 1.7.0 version. Can you please check if it really fix this issue?

I think the issue still isn't fixed. When I run the face detector in a landscape orientation the detections are erratic, similar to what was described by the OG post.
In @mrousavy's post about frame.orientation (https://github.com/mrousavy/react-native-vision-camera/pull/3077), he mentions that the frame is "... always some fixed orientation (e.g. landscape-left), no matter if the phone is in portrait or landscape".
He then mentions that Frame Processor Plugin authors need to adjust their respective Plugins accordingly so that the Plugins themselves compensate for any rotations that the user may encounter or use.
He states that "If the user holds his phone sideways (aka not in it's native portrait orientation), then you would also need to rotate that Orientation".
This is an option I don't believe is currently available in this pacakge, and would really appreciate it if it got added!
That said, there could be something obvious that I'm missing so please advise in the case that I am!

@dkoh555 The issue is reopened but I don't have time to work on this package right now.
Anyway you're wellcome to open a PR anytime.


Pool creation limitation on Uniswap

What command(s) is the bug in?
No response
Describe the bug
A token selection issue on Uniswap testing the Scroll Alpha Testnet prevents the creation of liquidity pools, which negatively impacts user engagement and adoption rates.
Wallet: 0x235014a26D821a86794bbEd6AAa577126cbe57c6
Concrete steps to reproduce the bug
No response

This is not related to the zkevm-circuits repo, closing this. Please ask this in our discord!


modify yardopts parsing to ignore hash and c-style comments

Description
Adds support for hash and c-style comments in .yardopts files.
We want this to be able to reduces developer confusion for those new to YARD. Devs can tend to see a .yardopts file, get confused, then just shrug and walk away. Being able to comment the options can pull them in more easily.
# YARD options, see `yardoc -h`
# for valid options and descriptions

# parse inline documentation with
# rdoc markup formatting
--markup "rdoc"

# treat code mixed in via include
# and extend as first class citizens
# of the module without additional directives
--embed-mixins

# clear the yardoc database
# when requesting documentation
# --no-cache

# Additional files to add to documentation tree
-
CHANGELOG.md
CONTRIBUTING.md
LICENSE

Completed Tasks

[y] I have read the Contributing Guide.
[y] The pull request is complete (implemented / written).
[y] Git commits have been cleaned up (squash WIP / revert commits).
[y] I wrote tests and ran bundle exec rake locally (if code is attached to PR).

Coverage increased (+0.004%) to 93.521% when pulling 58f63f401e1ea66a5a20c645e8614d932a0a040e on eprothro:yardopts-comments into fdf71a4708e91d2c422ef2a815ee9c36a7c60710 on lsegal:master.


key not found

Traceback (most recent call last):
  File "C:\Users\whitepoet\AppData\Roaming\Python\Python38\site-packages\capa\ida\plugin\form.py", line 1175, in slot_change_rules_dir
    path = self.ask_user_directory()
  File "C:\Users\whitepoet\AppData\Roaming\Python\Python38\site-packages\capa\ida\plugin\form.py", line 1146, in ask_user_directory
    self.parent, "Please select a capa rules directory", settings.user.get("rule_path", "")
  File "C:\Users\whitepoet\AppData\Roaming\Python\Python38\site-packages\ida_settings\ida_settings.py", line 265, in __getitem__
    return self.get_value(key)
  File "C:\Users\whitepoet\AppData\Roaming\Python\Python38\site-packages\ida_settings\ida_settings.py", line 425, in get_value
    return self._qsettings.get_value(key)
  File "C:\Users\whitepoet\AppData\Roaming\Python\Python38\site-packages\ida_settings\ida_settings.py", line 355, in get_value
    raise KeyError("key not found")
KeyError: 'key not found'

i used the change in the form.py as #462 said, but it did not work.

the stack trace source snippets indicate you've applied the fixes, but the exception doesn't make sense there. this makes me think one of two things:

have you restarted IDA between patching form.py? you have to do this because IDA caches the python modules.
have you removed any python cache files (.pyc or __pycache__ directories)?

ok,it is useful, thanks!


Fix accesibility problems in files/message selectors in hint and RHS

Summary
Fix accesibility problems in files/message selectors in hint and RHS
Ticket Link
MM-34652

Accessing the search dropdown options is now possible with the down arrow, but still not with tab - tabbing will still dismiss the dropdown

Tabbing in Search Results now selects "Messages" and "Files" as expected, but it doesn't select file results.
This was not specified in the ticket, but I think we should be able to tab through the file results as well @esethna ?

@ogi-m 1. That is exactly the same behavior previously existing with search hint, nothing new there. We can fix that, but that is another bug, I think.
2. I going to fix that, makes a lot of sense to have that.

@ogi-m 2. fixed, PTAL.

Looks good overall. @ogi-m can you file another issue for the tabbing bug you identified.
I think the expected here is that the search pop-over should not appear unless the user hits ENTER (or space) when the search field is focused (note this shouldn't change the behaviour of using the mouse to click on the search field and see the pop-over). That way we can be sure that the users tabs are directed within the modal (if they hit enter or space on the search field to open the modal) OR if they are trying to tab past the search field to the next icons.

@ogi-m can we please test this with a screen reader to ensure there are no issues with read out on the buttons or other elements?

#2 Is fixed now, thanks @jespino
Opened a ticket for the tab issue - https://mattermost.atlassian.net/browse/MM-34969
@esethna The current behaviour is that the dropdown opens when focused with the keyboard - should we file a separate ticket for that?

@ogi-m 0/5, could be part of the same ticket you filed above, but not blocking this PR

I think the expected here is that the search pop-over should not appear unless the user hits ENTER (or space) when the search field is focused (note this shouldn't change the behaviour of using the mouse to click on the search field and see the pop-over). That way we can be sure that the users tabs are directed within the modal (if they hit enter or space on the search field to open the modal) OR if they are trying to tab past the search field to the next icons.

@eric I'm not sure this is the best approach. Right now, I think it works well that I can tab to focus on the search input and start typing right away. With the proposal above, we'd be adding another keystroke before you can start typing in the search input. Plus, ENTER is used to execute the search. It feels odd to tab to focus on the search field and press ENTER before I type anything.
Can we not just tab through the messages and files options in popover?
The expected outlined in the ticket makes sense to me:

Expected: "Messages" is highlighted and selected in the dropdown, tabbing will move the selection to the “Files” option. Hitting Enter should add the “Messages” or “Files” element in the search box.

@matthewbirtch good call, that makes sense, I agree we don't want to require another keystroke before typing a search query

/update-branch

Thanks guys! Approving the PR.

Cherry pick is scheduled.

Error trying doing the automated Cherry picking. Please do this manually
+++ Updating remotes...
Fetching upstream
Failed to add the RSA host key for IP address '<IP_ADDRESS>' to the list of known hosts (/app/.ssh/known_hosts).
From github.com:mattermost/mattermost-webapp
   c2c4725be..142de1d1f  master     -> upstream/master
Fetching origin
Failed to add the RSA host key for IP address '<IP_ADDRESS>' to the list of known hosts (/app/.ssh/known_hosts).
+++ Updating remotes done...
!!! 'upstream/release-5.35' not found. The second argument should be something like upstream/release-0.21.
    (In particular, it needs to be a valid, existing remote branch that I can 'git checkout'.)

+++ Returning you to the master branch and cleaning up.

/cherry-pick cloud

Cherry pick is scheduled.


dns: limit to 3 resolvers and use better timeout for them

The default timeout was 5s and as 5s is the default for most clients we may try more upstream servers but at that point the client already considered this a timeout and no longer accepts answers. As such if we want to try more reolvers in case the first one is offline/not working then we need a lower timeout. Let's only try 3 as glibc does and then just divide 5s through the number of resolvers, i.e. 1, 2, 3. This should make the fall back work.
Fixes #482

@mheon @baude PTAL

LGTM

/lgtm


Add canFire option

Check if Ouibounce can be fired before triggering the callback.
May be usefull if you want to check something before triggering ouibounce (in my case, checking whether a modal is currently opened or not)

Hi!
any news about this PR ?

+1
There are scenarios where you don't want it to fire (to only invoke on certain pages, for example), which I've done using an If statement wrapping around the ouibounce call, but this would be a neater solution.

+1 That's also what we need!
I also had a fix for this but this solutions seems even better to me :)

any news?

An alternate solution might be as I've described in #137 which would allow code to disable the modal (perhaps through events or some other mechanism)


[New sniff ?] Have either UNIX or DOS line endings for TXT files

Rule:
Have either UNIX or DOS line endings, not both. This rule gets applied to PHP, CSS, JS and TXT files.
Ref: https://make.wordpress.org/themes/handbook/review/required/theme-check-plugin/#line-endings
Theme check file covering this rule:
https://github.com/Otto42/theme-check/blob/master/checks/lineendings.php
Decision needed:
Currently the Theme Check plugin check also checks the line endings in .txt files. This is not covered by the existing Generic.Files.LineEndings sniff and quite likely can't be covered by it as no tokenizer for .txt files is available within PHPCS.
A decision is needed on if and if so, how to continue checking the line endings for .txt files.
To do:

[ ] ... ?

Related: #3

We may have some other sniffs in the future for text files. As the text file would normally only contain text we would not need to tokenize but process it differently. I am also thinking about the readme validator for plugins https://wordpress.org/plugins/about/validator/.

Is there a possibility for txt files to get renamed to php or js, or would this be found by the File System functions check?

Is there a possibility for txt files to get renamed to php or js, or would this be found by the File System functions check?

@joyously I'm not sure what you mean. Could you elaborate a bit ?

I was just thinking that a file could be named with a txt extension, but have code in it. I didn't know if all the code checks would be run on the txt file, or if the check for File System calls (such as rename) would catch code that tries to rename one of the theme files.

I was just thinking that a file could be named with a txt extension, but have code in it.

Files with a .txt extension will not be executed by the server, so we don't really need to concern ourselves with those for the code specific checks. Similarly, a browser won't execute js code found in a .txt file.
(well, ok, they could be executed, but only if you apply some very dirty .htaccess hacks which will get you banned from any reputable webhost. Actually - it might not be a bad idea to check that a theme does not contain any .htaccess files for that matter).

if the check for File System calls (such as rename) would catch code that tries to rename one of the theme files

Interesting thought (and scary). I'd have to check what the specific rule is here about file system calls, but if they are forbidden, then yes, they would (should) catch attempts to rename files.
But a theme - or plugin - for that matter, renaming files within their own installed code base is something I've not come across before and sounds wickedly evil.

Oh and @joyously - if you believe either of those points should be turned into sniffs, please open separate issues for them. This issue is specifically about the line ending check for txt files.

(dot) files are blocked by the theme uploader already.
see https://github.com/Otto42/theme-check/blob/master/checks/filenames.php

@jrfnl  Somehow when I read this sniff, my mind returned to an old article I read recently
http://ottopress.com/2010/anatomy-of-a-theme-malware/  and other articles I've read about putting data on the end of a jpg, and I wondered if you could trust file extensions, and whether these sniffs are run only on certain files(according to file extensions). And it seems that even going through the WordPress File System would allow you to rename(move) a file. I'm not devious enough to be a hacker, and I don't know enough about this sniff code to know how to contribute except to ask my original questions.

There are ways to check files for mimetype - that would give some indication if for instance a .zip file would have been renamed to .txt, it could flag that.
But this is not a catch-all (though could catch a lot).

Possibly related with @joyously 's comment : Also think about things like include('my_php_file_with_wrong_file_extension.txt').
With all the ugly spaghetti horror scenarios I've had to work with in the last 2 years - mostly takeover jobs - I see that as a definite possibilty. Yep, its insane, but there are so many insane "btw: I'm originally a print graphic designer and never properly learned PHP"-self declared developers that have no clue what they're doing, mostly copy-and-pasting themselves through "programming" .. I'd call it a given.
cu, w0lf.
ps: maybe it'd help gathering all those nut jobs / nut cases once in a while and then use that to create better testing routines? Its mostly crappy premium themes, too many folks having worked (or ARE working) on the same job, or above described apocalyptic scenario.

maybe it'd help gathering all those nut jobs / nut cases once in a while and then use that to create better testing routines?

Creating new unit tests for sniffs is incredibly easy. Please feel invited to start creating/adding them. The better the test cases we have, the better sniffs we can create ;-)

This should be solved by #3

This should be solved by #3

Actually, no, it shouldn't. #3 deals with PHP, CSS and JS files. This issue is about the same for TXT files.

While this may be needed for the wp.org markdown parser, this is not something which can be checked for by PHPCS. If we tell PHPCS to parse txt files as PHP, it would possibly also trigger on example code contained in the readme, thus creating false positives we don't want.
This would be better solved from within the Theme Check plugin itself, just scanning the readme.txt file.


docs: maintainers

Fixes Issue
TODO

[ ] Need to add example template replies we use

Changes proposed

Check List (Check all the applicable boxes)

[ ] My code follows the code style of this project.
[ ] My change requires changes to the documentation.
[ ] I have updated the documentation accordingly.
[ ] All new and existing tests passed.
[ ] This PR does not contain plagiarized content.
[ ] The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

Thank you 👍 - still a few things to add and tweak

Thank you 👍 - still a few things to add and tweak

lol totally didn't see this was in draft wehn I was looking through it

Images


Performance Question: Does changing properties to same value cause PIXI to do work?

For performance in my game, I'm currently setting all objects' visibility properties to false every frame, then doing a tree lookup with my camera's visible area to set the visible ones to true. However, I'm wondering if this is causing pixi to do extra work. Like, does pixi use getters/setters for object properties? Here are some contrived examples:
// Does toggling visibility cause pixi to do extra work?
myContainer.visible = false;
myContainer.visible = true;

// Same question for object props.
mySprite.rotation = Math.PI;
mySprite.rotation = 0;

If pixi is using getters/setters and is doing extra work every time I set these properties, then I can easily track them myself and only set them when they're changed. Just wanting to know if that's necessary.

visible is a vanilla property, no cost here.
rotation is a pass-thru for transform.rotation which is a setter. This does some math to re-compute the skew, but only if rotation is changed (so in your case yes).

this will maybe interest you, i was ask similar question here
https://github.com/pixijs/pixi.js/issues/4638
This will depending of your source code and game system.
Menue,huds sprites Out of camera are .renderable = false on my side and seem more fast.

All computations are lazy, it doesnt matter if you set rotation 10 times per frame or just 1. Even then, the cost of drawing sibgle element is much more than setter+matrix computation. It will affect your app only on 5000+ elements.

Great, so sounds like minimal impact from setting values, even though some properties do have setters. Thanks for the info guys.


Templates name aren't clear in the output in the error log for the latest e2e testing.

Report
While doing negative testing on the latest migrated code for the e2e testing, the output for a test with erroneous template was this:
cannot apply file - error: error parsing /tmp/tempTemplateFile393652011: error converting YAML to JSON: yaml: line 31: could not find expected ':'
This proves to be confusing in case we have scalers with multiple templates.
Expected Behavior
The expected behavior was something like this:
cannot apply file - error: error parsing /tmp/deploymentTemplateFile393652011: error converting YAML to JSON: yaml: line 31: could not find expected ':'
or as mentioned by @JorTurFer it could also be printing the template itself in the error log.
Actual Behavior
The error log doesn't provide clarity to which exact template file is causing error and the error is like this:
Error Trace:	helper.go:170
        	            				helper.go:178
        	            				helper.go:209
        	            				cpu_test.go:127
        	Error:      	Received unexpected error:
        	            	error: error parsing /tmp/tempTemplateFile1287392103: error converting YAML to JSON: yaml: line 31: could not find expected ':'

Steps to Reproduce the Problem

make an error in templateFile.
Run go test on the test file with : go test -v ./scalers_go/scalerName/scalerName_test.go
find the error in output

Logs from KEDA operator
None
KEDA Version
2.7.1
Kubernetes Version
1.23
Platform
Any
Scaler Details
Any
Anything else?
No response

@JorTurFer @zroubalik @arschles WDYT?

BTW, are you willing to contribute with this?

I think having a template name parameter in the function is not that bad of an idea. I was thinking something like this -
- func KubectlApplyWithTemplate(t *testing.T, data interface{}, config string) {
+ func KubectlApplyWithTemplate(t *testing.T, data interface{}, templateName, config string) {
	tmpl, err := template.New("kubernetes resource template").Parse(config)
	assert.NoErrorf(t, err, "cannot parse template - %s", err)

-	tempFile, err := ioutil.TempFile("", "tempTemplateFile")
+       tempFile, err := ioutil.TempFile("", templateName)
	assert.NoErrorf(t, err, "cannot create temp file - %s", err)

	defer os.Remove(tempFile.Name())

	err = tmpl.Execute(tempFile, data)
	assert.NoErrorf(t, err, "cannot insert data into template - %s", err)

	_, err = ExecuteCommand(fmt.Sprintf("kubectl apply -f %s", tempFile.Name()))
	assert.NoErrorf(t, err, "cannot apply file - %s", err)

	err = tempFile.Close()
	assert.NoErrorf(t, err, "cannot close temp file - %s", err)
}

- func KubectlApplyMultipleWithTemplate(t *testing.T, data interface{}, configs ...string) {
- for _, config := range configs {
+ func KubectlApplyMultipleWithTemplate(t *testing.T, data interface{}, configs map[string]string) {
+	for name, config := range configs {
		KubectlApplyWithTemplate(t, data, name, config)
	}
}

BTW, are you willing to contribute with this?

hi @JorTurFer , i might have missed the comment here, sure I'd love to work on it. if @v-shenoy don't mind? any suggestion is also appreciated of how we can improve this even more.

BTW, are you willing to contribute with this?

hi @JorTurFer , i might have missed the comment here, sure I'd love to work on it. if @v-shenoy don't mind? any suggestion is also appreciated of how we can improve this even more.

Yes, please take it up. I was just adding my thoughts.

Thanks @v-shenoy

Hi @JorTurFer the changes according to what @v-shenoy and I proposed earlier look like this

And there is another simple way to give a hint to the developer about which template file created the error.
We can add tags to the templateFile name itself, as the multipleTemplateFiles are always applied in sequence it's easier.
Here are the changes needed.

Please let me know what you think.

The problem I feel with the approach of using an index as the tag is, if you have code like
KubectlApplyMultipleWithTemplate(t, data, []string{secretTemplate, deploymentTemplate})
// some lines of code
// ...
KubectlApplyMultipleWithTemplate(t, data, []string{triggerAuthTemplate, scaledObjectTemplate})

Now if there's an error in applying some template the error message might look like
cannot apply file - error: error parsing /tmp/tempTemplateFile-1#393652011: error converting YAML to JSON: yaml: line 31: could not find expected ':'
This still doesn't tell you whether the deploymentTemplate caused the error or scaledObjectTemplate caused the error. You're going to have to check the logs for more context (if there's any) to differentiate.
I would rather have the error message be something like
cannot apply file - error: error parsing /tmp/deploymentTemplateFile#393652011: error converting YAML to JSON: yaml: line 31: could not find expected ':'

Now if there's an error in applying some template the error message might look like cannot apply file - error: error parsing /tmp/tempTemplateFile-1#393652011: error converting YAML to JSON: yaml: line 31: could not find expected ':'
This still doesn't tell you whether the deploymentTemplate caused the error or scaledObjectTemplate caused the error. You're going to have to check the logs for more context (if there's any) to differentiate.

Agreed there is not complete clarity. the developer might have to go back to see tempTemplateFile-1#393652011 and search for the 1st template file as the tag is 1 herethe files are applied as sequence but this method seems to uncertain i agree

@JorTurFer @v-shenoy ,If everyone agrees on the variable approach with exact name of template, then i'll continue doing the required changes in other *_test.go files

If you think that it's the best approach, we can give a try. Maybe I'm overthinking and one extra parameters it's not a problem at all, and in case of if it is, we can rethink this in the future.

There's one issue that I have noticed cause due to the use of map for template names, and config. When multiple templates are applied / deleted, they're done by iterating over the keys of the map. But the order of keys when iterating is not same as the order of dependencies.
As an example, when applying the order should be secret -> deployment -> trigger auth -> scaled object
And the reverse order when deleting.
This causes multiple error messages showing up in the operator logs when testing. If this is a problem in itself or not, is up for question.
What do you think, @JorTurFer?

mmm...
It's true that doesn't affect to the test, but it's hard to read the logs when you are troubleshooting... Maybe we can iterate the values in the opposite order in case of deletion. WDYT?

This will require changes to the apply / delete multiple method signature, and all the tests that are currently there. We should pick a consistent signature that would not require changes in the future. @JorTurFer @Ritikaa96

This is kind of my bad, as I suggested the map approach and forgot about the iteration order.

This is kind of my bad, as I suggested the map approach and forgot about the iteration order.

don't worry, we are iterating to figure out the best solution. You have done an awesome work, really!!


Cannot save "Revoke tokens upon user logout" settings

Describe the issue:
In  Service Provice Oauth configuration the "Revoke tokens upon user logout" checkbox settings is not saved upon "Update".
How to reproduce:
Login to Carbon console. Open Service Provider/Inbound Authentication Configuration/OAuth/OpenID Connect Configuration.
Check the Revoke tokens upon user logout.
Click on the "Update"
You'll see "Application updated successfully"
Open config again, "Revoke tokens upon user logout" is not set.
Expected behavior:
"Revoke tokens upon user logout" must be set after successul update.
Environment information (Please complete the following information; remove  any unnecessary fields) :

Product Version: IS 6.0.0.
OS: Linux
Database: Postgresql
Userstore: JDBC

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


Bug

it is infinitely refreshing! help!

Not that much information but I guess you mean the website is refreshing all the time? If so this is a duplicate of another issue I think?

Probably a duplicate of #302. Are you using HTTPS Everywhere?
If not, which browser/OS?

Oh, I do. does https everywhere do something to it? Should I disable it?
2016. 2. 28. 오후 9:42에 "Tim"<EMAIL_ADDRESS>작성:

Probably a duplicate of #302
https://github.com/nathan/phosphorus/issues/302. Are you using HTTPS
Everywhere?
If not, which browser/OS?
—
Reply to this email directly or view it on GitHub
https://github.com/nathan/phosphorus/issues/557#issuecomment-189863963.


Missing 'make' dependency when booting new instance

resolution_fixed   |    by<EMAIL_ADDRESS>
I'm getting the following error when booting a test instance from master:
[I] Installing ruby gem: ruby-augeas (0.4.1)
Building native extensions.  This could take a while...
ERROR:  Error installing ruby-augeas:
	ERROR: Failed to build gem native extension.

        /opt/rh/ruby193/root/usr/bin/ruby extconf.rb
creating Makefile

make
sh: make: command not found

Gem files will remain installed in /opt/rh/ruby193/root/usr/local/share/gems/gems/ruby-augeas-0.4.1 for inspection.
Results logged to /opt/rh/ruby193/root/usr/local/share/gems/gems/ruby-augeas-0.4.1/ext/augeas/gem_make.out

Issue migrated from trac:135 at 2024-01-31 18:07:00 +1100

<EMAIL_ADDRESS>commented

Fixed in changeset:1f69a67

<EMAIL_ADDRESS>commented

Milestone Future deleted

<EMAIL_ADDRESS>removed milestone (was Future)

<EMAIL_ADDRESS>changed resolution from `` to fixed

<EMAIL_ADDRESS>changed status from new to closed


fuzzy enable pipeline and nereids in regression env by default

Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 50.49 seconds
stream load tsv:          502 seconds loaded<PHONE_NUMBER>9 Bytes, about 142 MB/s
stream load json:         19 seconds loaded<PHONE_NUMBER> Bytes, about 118 MB/s
stream load orc:          65 seconds loaded<PHONE_NUMBER> Bytes, about 16 MB/s
stream load parquet:          30 seconds loaded 861443392 Bytes, about 27 MB/s
insert into select:          28.9 seconds inserted 10000000 Rows, about 346K ops/s
storage size:<PHONE_NUMBER>0 Bytes


Inner HTML does not return anything

HTMLAgility Pack 1.5.0-beta2
if tag format like this
the InnerHTML doesn't return anything
Example link : http://www.mangahere.co/manga/tower_of_god/c331/
content:
1
2
3
4

Hello @sebastianolafhandjojo ,
I believe there is something missed in your question.

if tag format like this

I believe this part is incomplete or I don't understand it.
I currently don't have enough information to reproduce it:
string url = @"http://www.mangahere.co/manga/tower_of_god/c331/";

HtmlWeb web = new HtmlWeb();
HtmlAgilityPack.HtmlDocument doc = web.Load(url);

var inner = doc.DocumentNode.InnerHtml;

Best Regards,
Jonathan

Hi Sorry, i wrote that at 1AM
so a bit half a sleep
string url = @"http://www.mangahere.co/manga/tower_of_god/c331/";
var _web = new HtmlWeb();
HtmlDocument document = _web.Load(url);
var options = document.DocumentNode.Descendants("option");
foreach (var option in options)
{
string someinnertext = option.InnerText.Trim();
Console.WriteLine("Inner Text = {0}", someinnertext);
}

i have test this many times,
it seems something wrong with word "option" it does not populate any value for InnerText or InnerHtml
but if try with any random text as Html Tag, it populate value
below is example i use to test
HtmlDocument document = new HtmlDocument();
string text = "olaf";
// notice i put a space between double quote and closing tag " >
// plus somehow in the result , it trims down see screenshot
document.LoadHtml("<"+text +" value="http://www.mangahere.co/manga/tower_of_god/c331/5.html\" >5</"+text+">");
            var options = document.DocumentNode.Descendants(text).ToList();

            int i = 0;
            foreach (var option in options)
            {
                string someinnertext = option.InnerText.Trim();
                string someinnerhtml = option.InnerHtml.Trim();
                string someouterhtml = option.OuterHtml.Trim();
                Console.WriteLine("{0}) {1} = {2} --> {3}",i++, someinnertext, someinnerhtml, someouterhtml);
            }

using Random word as Tag

using word option as tag

Above i test with beta2, and I saw that you have release beta5
but with beta5 still has same problem

Ok, so I saw in your source code for "option" somehow got "special" treatment,
so am thinking to replace word "option" with other random text, using ReplaceChild method,
But I don't understand how to use HtmlNode use? and what index means ?
Do you have any example for this method ?
Thank you !

Hello @sebastianolafhandjojo ,
It looks option tag have some weird behavior.
You can find two solutions here:
https://stackoverflow.com/questions/13977243/how-can-i-parse-innertext-of-option-tag-with-htmlagilitypack
// REMOVE option from "special tag"
HtmlAgilityPack.HtmlNode.ElementsFlags.Remove("option");

string url = @"http://www.mangahere.co/manga/tower_of_god/c331/";
HtmlWeb web = new HtmlWeb();
HtmlAgilityPack.HtmlDocument doc = web.Load(url);

var options = doc.DocumentNode.Descendants("option");

foreach (var option in options)
{
    string someinnertext = option.InnerText.Trim();
}

As you noticed.
Some tag has some custom behavior. When we will re-write the 2.0 version of this library, we will make sure to check them and fix some issue like this one.
Let me know if the solution above worked correctly.
Best Regards,
Jonathan

You can find an example here about ReplaceChild: http://html-agility-pack.net/replace-child

ok I will try first and let you know

both working, Thank You!

Closing comment: Issue solved confirmed


Fix manifests for calico policy only

Description
Network configuration appears in some of the manifests for installing Calico for policy only. These changes will fix that by setting the appropriate network value for helm rendering.
Todos

[ ] Tests
[ ] Documentation
[ ] Release note

Release Note

None required

Fixes https://github.com/projectcalico/calico/issues/2579

Deploy preview for calico ready!
Built with commit 7806ba77bdfd95e72f41ddfc4b934120a7f6b3bd
https://deploy-preview-2589--calico.netlify.com


Base the master branch's fedora-coreos image from testing-devel

/cc @vrutkovs

/test e2e-aws-ovn
master-2 failed to start


Don't use setuid on chkmq*

Duplicate of https://github.com/ibm-messaging/mq-container/pull/429  Currently blocked by issues with Travis.


Helm port forward integration test

Which issue is resolved by this Pull Request:
Resolves #
Description of your changes:
-Wrapped kustomize.py fixture into installation.py fixture, which includes both kustomize and helm as based on passed kubeflow installation option
-ran test_sanity_portforward.py to confirm it's working as expected.
example user input to run the integration test:
pytest tests/test_sanity_portforward.py --metadata .metadata/metadata-002.json --region eu-west-2 --installation_option helm

Testing:

[x] Unit tests pass
[x] e2e tests pass
Details about new tests (If this PR adds a new feature)
Details about any manual tests performed

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

will this PR be updated? if not please close and open a new one


using difflet for object diffs

Here's what it looks like now:
http://substack.net/images/screenshots/tap_using_difflet.png

+1 OH YEAH

Landed on f197f56e89b5cf6d98888b2eca49720179027531, published in 0.2.1
Thanks!


Skip the ice fields in the hycom output file (archv/archm/archs) usin…

As to the requirements on the last meeting, the new compiling flag -DOFFICEField together with Toffice=.true. will shield the output of ice variables in the hycom files like archv/archm/archs....

Thanks Annette.  It is a good comment to avoid the merging issue.


cloud-init failed on usermod to ssm-user

Describe the bug
As the system log below shows, a command on userData, 'usermod -aG docker ssm-user' does not work.
[   93.182052] cloud-init[2486]: usermod: user 'ssm-user' does not exist

Expected behavior
ssm-user should have been existed before usermod.
Screenshots

Additional context
usermod command can be deleted If it's just for running docker command without sudo.

Thank you for the information, ok, let's remove usermod


Entity classes can only be placed in $APP_PACKAGE_NAME/model

Subject says it all: if I try to put Entity classes under any other package name, compilation will fail because the generated classes will not be able to locate the Entity classes

Do you recompile the project after moving? since new Entity classes should be generated again in the same package your Abstract/Interface Entities are.

Wherever you use your entity in variables use the original type e.g. IEntity or AbstractEntity. The import statements will be updated by your IDE when you move these classes.
You'll have to update import statements manually wherever you reference generated Entity class.

Actually, my problem is not that my code cannot find the non-abstract Entity classes.
The problem is that the non abstract Entity classes fail to compile.
Here follow some more details...
This is the package where I would like to put my abstract Entities to:

This is the actual implementation of the abstract Entity:
@Entity
public abstract class AbstractCachedTile {

    @Column(nullable = false, name = "tile_hash")
    long tileHash;

    @Column(nullable = false, length = 25, name = "cache_key")
    String cacheKey;

    @Column(nullable = false, name = "last_used")
    double lastUsed;

    @Column(nullable = false, name = "data")
    byte[] data;
}

When I attempt to compile the project so configured, the compilation of the non-abstract CachedTile class fails:

If I go see the generated class, this is what I find:

first start by changing the package names to all lowercases so Core.DataModel.CachedTile should be core.datamodel.CachedTile and also instead of just using core.datamodel.CachedTile the package name should include the fully qualified name so com.zirak.easytrails.core.datamodel.CachedTile. Maybe check the class CachedTile if the package at the top of the file is correctly set to com.zirak.easytrails.core.datamodel; and not Core.DataModel;

setting package names to all lowercase does indeed fix the compilation problem. After that the generated classes work just fine...
I do think, however, that package names with upper case letters ought to be supported. If I remember correctly, the convention of using all lowercase letters only applies to the top level domain prefix of the package name...

The convention for using only lower case for package names is so you cant clash with classnames which start with uppercase.
Any java programmer would read Core.DataModel.CachedTile as class Core has an inner class DataModel which has an inner class CachedTile instead of the the class CachedTile in the package core.datamodel`.

I see.
If that is the case then this issue can be closed.
Do you by chance have any feedback for issue #252? That one is rather more serious...


feat(ndt7): Use X-Forwarded-For hint for the client's IP address

When running behind a proxy the RemoteAddr in various places won't return the real client's IP. This commit uses various hints to get it, falling back to using the default.
cc @pthankappan

This change is

Hello, thank you for submitting this PR.
Unfortunately, for ndt-server to function properly, it requires an unterminated end-to-end TCP connection. The use of a reverse proxy, which would terminate the connection, is not supported. This will lead to inaccuracies in the TCPInfo, BBRInfo, and other network-related data, as they would be associated with the connection between the server and the reverse proxy instead of the server and the client.
Also note that if you are running the fullstack ndt-server, which includes sidecar services, all of them will still record the proxy's IP rather than the client's.
Additionally, data transmission to or from the client would be handled by the proxy's network stack, rather than the NDT server's network stack, resulting in inaccurate application-level metrics.
For these reasons, we recommend avoiding the use of ndt-server behind a reverse proxy and not overwriting the ClientIP field.

Hey! Thanks for the detailed response, I let the team know. Lots of new info here for me.
We'll reconsider our approach. We might end up finding some middle ground here, unsure. We've already got a bunch of infra set up and some requirements along with that, so there's going to be some acrobatics required to fit this in.
Either way, we learned a lot. Thanks again!


webapp name in section 6.5 is incorrect

This section has -n "${WEBAPP_NAME}" but it should be -n "${ASE_WEBAPP_NAME}"

Changed the value


clang-tidy fails on nanopb-generated code

clang-tidy fails on nanopb-generated code:
https://travis-ci.com/github/RespiraWorks/VentilatorSoftware/builds/161259051#L680
unknown attribute '__progmem__' ignored  [clang-diagnostic-unknown-attributes,-warnings-as-errors]

This blocks CI, so we're disabling clang-tidy with @jkff's blessing.

cc @Miceuz


Blog Resource for Mozilla Quality Assurance - Bug Verification day

hey hai,
This is Surentharan. I am from Mozilla Tamilnadu Community. I am one of the QA Co-ordinators of Mozilla India Community. I Would Like to add Blog resource for Bug verification so that it can help new contributors to make their contribution easier. The Blog which I would like to add will acts as a reference for their contribution and it includes step by step procedure

@SurenVino thanks for taking time to contribute. Yaay!! go ahead and add it. Eagerly waiting to merge your PR. ⭐
Have a look on SOHW wiki for forking, working with repo files, etc. If you want any help, let me know. 😄


Reserve multiboot physical memory

Fixes #342 by passing the multiboot memory range to the physical memory manager. The physical memory manager then skips any memory overlapping with the multiboot memory range.

Just realized there might be an issue when there is no multiboot image since the range would then be the empty range at 0 and block the first physical memory page.

In the future, we probably should add another flag reserved to the frame_t and handle it properly in the PMM. Then, maybe instead of skipping the frames, we could create them and reserve (consume) them immediately. Same should apply to all the memory regions reported as reserved by multiboot, ACPI and others.


Support for Point In Time Recovery

Added PointInTimeRecovery param in DataStoreConfig. Param can have value Enabled, Disabled and NotManaged for backward compatibility. DataStore DSC resource sets PITR using tools\changedbproperties.bat.  Backup location variable needs to be set when enabling PITR so DatabaseBackupsDirectory parameter is used. Lastly to set set the backup location the configurebackuplocation.bat script is used instead of changebackuplocation.bat (which is obsolete).

@JosWesterbeek Thanks for your contribution. We have incorporated this in v3.2.0 version the module. Hence closing this PR.


Fix a compilation error

The lib gave me following error when I tried to use it:
error: cannot initialize a struct with a map
   16 | // load_env is a simple loader
   17 | pub fn load_env() {
   18 |     loader({})
      |            ~~
   19 | }
   20 |

I've fixed that and also ran v fmt to get consistent formatting.
The tests pass.
Btw there is a guide how to integrate v unit tests to GitHub Actions available here.

Hello sorry but I don't have the plan to continue on this project, please do fork or create a separate project for this one
I am very sorry


Handle device creation when first device (#1) is not supported

Describe the bug
After we merged device entities to a single parent device, there are issues when the first entity of a device isn't supported. It won't create a device in the registry anymore and just show the separate entities.
Expected behavior
Fall back to the first supported device?

I am not able to test this easily, since I don't have such devices, but I believe we should loop through the entity list in async_added_to_hass to determine if there is a supported parent device.


[ZEPPELIN-5594] HDFS fileId, blockSize should be read as "long", not "int".

What is this PR for?
fileId, blockSize should be declared as long, not int.
What type of PR is it?
Bug Fix
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-5594
How should this be tested?

Strongly recommended: add automated unit tests for any new or changed behavior

I modified some value in the HDFSFileInterpreterTest.java to simulate integer overflow.

Outline any manual steps to test the PR here.

In the file interpreter, if you try to access any file with high (><PHONE_NUMBER>) fileId or blockSize, you will see the exception(java.lang.NumberFormatException).

Screenshots (if appropriate)
ERROR [2021-11-29 14:46:51,519] ({FIFOScheduler-org.apache.zeppelin.file.FileInterpreter1871691756-Worker-1} HDFSFileInterpreter.java[listAll]:249) - listall: listDir /user/*******
com.google.gson.JsonSyntaxException: java.lang.NumberFormatException: Expected an int but was<PHONE_NUMBER> at line 1 column 585 path $.FileStatuses.FileStatus[2].fileId

Questions:

Does the licenses files need update?
Is there breaking changes for older versions?
Does this needs documentation?

I don't think so.

I remove unnecessary sentences. Thanks to let me know.

Thanks @eubnara  PR LGTM

Merged. Thank you for your contribution.

@jongyoul
Hello, could you list my name on 0.11.0 release note?
https://zeppelin.apache.org/releases/zeppelin-release-0.11.0.html

@eubnara Added. https://zeppelin.apache.org/releases/zeppelin-release-0.11.0.html Thank you for your contribution. I hope you keep contributing to Zeppelin. :-)

Thank you very much!


Make Javacomplete works with python 2 or 3.

[Problem]
Currently javacomplete plugin relies on Python to do some of its work.
Unfortunately it strictly rely on Python 2 even though the code can run on
Python 3 without any problem.
[Solution]
Make the code first check which Python is available and the first one.
[Notes]
This change essentially remove the use of pyeval due the fact Vim does not
support this function if only Python 3 is available.
Also, I put a check on the beginning of the file to guarantee that we don't
proceed if no Pythno is available.
Signed-off-by: Thiago Alves<EMAIL_ADDRESS>

Thanks, will check it.
But before, can you make changes that apply only to your modification. Without ident changes. And let version be 2.2 until the release.

Sure, no problem. After I create the pull request I realized I forgot to turn off the remove of white spaces after save on my vimrc. Will create a new one in a bit.

@Townk well, your patch still contains changes that not related on this issue.
https://patch-diff.githubusercontent.com/raw/artur-shaik/vim-javacomplete2/pull/33.patch
you have better to separate patch

remove needless whitespaces
support python 2 or 3 both

And I noticed you define Pyfile command in global scope. buffer-local is better. if it doesn't work, you should define them if it not defined.

@mattn if I define the commands as buffer commands wouldn't that cause problems to the second java file I open?
Also, I already rolled back the white space changes.

See https://patch-diff.githubusercontent.com/raw/artur-shaik/vim-javacomplete2/pull/33.patch
If merge this PR, this patch will be merged.

if I define the commands as buffer commands wouldn't that cause problems to the second java file I open?

I'm not sure. But at least you need to block like below.
if !exists(':PyFile')
  " define PyFile
endif

Your patch should be like below.
https://gist.github.com/mattn/abfa8bbe7ed0194f62a7
Sorry, I don't apply this patch yet.

Got it. Two things:

Do you guys see my second revision of this patch? I mean, the one where I remove the changes not related to the fix including the version bump Arthur asked me to not change? If I click on the "Files changed" tab here I can see it, can you guys do it as well?

The reason why I didn't verify if the command existed was the "command!" portion of it. If the command existed I would override it. I know this is a bed choice and I agree with you that checking is the right approach but my line of though was that I can't guarantee the command created by other plugin or even the user actually represent what I'm trying to create. Maybe I should have appended the plugin name like "Javacomplete_Py" and "Javacomplete_Pyfile", this way it would be very clear whom is the owner of this command.

I already merge it, there were nothing unnecessary.

Yeah, I think Javacomplete prefix gives more guarantees that nothing will be broken.

Thanks Arthur, I'll do the changes on the command prefix. I'll push a PR by EOD.


[SYSTEMML-446] Bug fixes to SYSTEMML-446

@niketanpansare - Could you please take a look at these?

LGTM. Thanks Nakul.
@deroneriksson @dusenberrymw Can you please merge this in ?

I will merge. Thank you @nakul02.

Thanks @deroneriksson


add gRPC quickstart link to left sidebar menu

noticed that the gRPC quickstart page is not listed on the left sidebar menu.

grpc quickstart is not real - I shouldn't even have it in the list of pages. Got an update coming soon that should deal with this as well as a slew of other errors.


Allow user specified s3 key in conjunction with --use-s3-bucket in cr…

…eate and update commands
Hi there!
This is for allowing users to specify an S3 key (path and file name) in conjunction with the --use-s3-bucket option for both the create and update commands (inspired by this old conversation in Gitter). Is backwards compatible with current implementation of --use-s3-bucket.
If the parameter provided for that option includes a / character, the string following that character will be treated as the path for the uploaded file. The string after the final / character in the parameter provided will be treated as the key for the file itself. The file extension (.zip) is automatically appended to the key.
Examples:

--use-s3-bucket claudia-uploads

Bucket: claudia-uploads
Key: (no change — uses filePath argument provided to uploadToS3 function)
Path: (no change — uses filePath argument provided to uploadToS3 function)

--use-s3-bucket claudia-uploads/some-file

Bucket: claudia-uploads
Key: some-file
Path: /some-file.zip

--use-s3-bucket claudia-uploads/some/path/some-file

Bucket: claudia-uploads
Key: some-file
Path: /some/path/some-file.zip

New tests added to spec/create-spec.js and spec/update-spec.js.
Thanks!

Hi - thanks for this. I would prefer to use a different option, since identifying a key within a parameter called "bucket" is a bit roundabout, as is then magically adding .zip; perhaps we could do this with a --use-s3-key that would set the whole key (including the extension), so if a user wants it uploaded to a specific key then can set the whole thing.

Thanks for the feedback, Gojko. I've create a new option --s3-key for both create and update, updated the tests I'd made before and added some config validation tests (so that --s3-key can only be used in conjunction with --use-s3-bucket).

this is now on npm, as @5.12.0. thanks!


Functionaliteiten pag in dashboard

Het moet mogelijk zijn om alle functionaliteiten te activeren in het dashboard, dus ook afspraak, herstelling,... wij krijgen hier veel vragen over.

Functionalities page in dashboard
It must be possible to activate all functionalities in the dashboard, including appointment, repair, ... we get a lot of questions about this.

@stevendepaepe, can you prepare a list of the remaining modules, with the EN and NL description that has to be shown? Make sure the description is consistent with the functionalities that already exist.
English descriptions:

I've requested the images from Roel.

Afspraken
Laat alle app gebruikers een afspraak maken
Appointments
Allow all app users make an appointment
Herstellingen
Laat alle app gebruikers een herstelling doorgeven
Reparations
Allow all app users report their reparations
Groepschat (enkel voor verenigingen)
Laat alle app gebruikers in groep communiceren
Group chat (only for associations)
Allow all app users communicate in groups

@abom, I will receive the images from Roel tonight. In the mean time, can you add these functionalities already?

I received the images a bit sooner

@bart-at-mobicage think the 'Group chat' icon is missing/incorrect

the group chat image is the same as ask question and is already in the project. I updated my previous comment.

Ok, because Sylvie only posted 3 new modules/translations

@Sylviecraeye, are we going to skip the GROUP PURCHASE module?

Yes, almost anyone use this
Verstuurd vanaf mijn iPhone

Op 12 dec. 2017 om 14:49 heeft Bart Pede<EMAIL_ADDRESS>het volgende geschreven:
@Sylviecraeye, are we going to skip the GROUP PURCHASE module?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.


Tabbing inside Modal component goes outside of the modal.

Tabbing inside Modal component goes outside of the modal. I believe this happen only for the Modal created dynamically with prop open="true" (related issue: https://github.com/IBM/carbon-components-react/issues/1616)
Carbon Design System:  6.59.0

Hi 👋 could you try putting a focusable element that come after <Modal> (ideally the last of the <body>)? If it doesn't solve the problem, could you create a reduced case based on https://codesandbox.io/s/github/IBM/carbon-components-react/tree/master/examples/codesandbox? Thanks!

Closing this out as resolved. Happy to reopen if that's not the case. 🏄


suggest document .net 3.0 core installation

if one loads this on an "empty" windows system you may not have .net core 3.0.  Suggestion: in the readme or elsewhere give some bit of hint as to what to retrieve from the Microsoft (or wherever) site to install this.

With .NET Core 3.0, a single executable can be built with the all the required dependent components. I'll rebuild the next release with this option.

The Readme file includes the location of the self executable files that includes all the required files.

didn't work for me on some machines.
On Mon, Jan 13, 2020 at 4:42 PM Jonathan Horvath<EMAIL_ADDRESS>wrote:

The Readme file includes the location of the self executable files that
includes all the required files.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/bytedreamer/OSDP.Net/issues/5?email_source=notifications&email_token=ABNXPBMFHFOPFZ2M6MTZUZTQ5UDANA5CNFSM4JV3JGS2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEI2264I#issuecomment-573943665,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABNXPBKRNSWHGAAP7YXAKRLQ5UDANANCNFSM4JV3JGSQ
.


Results viewer: DELETE key incorrectly deletes rows

In my preferences the shortcut key to delete a row in the results pane is Alt+Delete (the default one). However, DBeaver also will delete a row when I press Delete without Alt. Here are the key preferences:

I don't know how long this behavior has been in DBeaver but I noticed it today when I wanted to add a new row by duplicating an existing row. It was an unpleasant experience because there were many columns in the table and I spent some time filling in all the values and I accidentally pressed Delete while not having the cursor focused in a cell (because I used the Delete key a lot while editing some of the column values). The not yet saved row was deleted and there seemed to be no way of restoring my new data and I had to start again. The default Alt+Delete key is a safe choice as it makes it hard to delete data and the standard Delete operation should not delete the row (it might for example make the selected cell value NULL but not delete the whole row).
A related bug that I've noticed here: First I accidentally pressed Delete when adding a new row in the Record view and the Delete key did not make the editing row disappear but only moved the cell selection to the top of the page so I didn't even know my data would be lost. Only when I pressed Save I noticed that my data were not saved. This is another bug - when I delete a new row in the Record view the data should disappear so that I can see the delete operation has been executed.

Delete shortcut was there for a years. A lot of people get used to it.
It is a very convenient shortcut in most cases.
So I don;t know how to solve this..

There are 2 commands: 'Delete', working "In windows", and 'Delete current row', working in "Results viewer context". What if both are bound to the Del key by default, but the former does not delete current row (i.e. is ignored when on results viewer)?
Then @lemon-juice could remap 'Delete current row' to Alt+Del and will live happily with the Del key doing nothing on resultsets, while the rest of us continue using the Del key.
Don't know if this is feasible with Eclipse keybindings.

Yes, I can see now how the pure Delete key is convenient for deleting rows, though I never used it that way. I first thought about a similar solution to what @p91paul suggests with separate key bindings - then I could simply remove the key binding for the Delete key. However, I think there is a better solution to solve the problem, which I think exists elsewhere.
The thing is that there is no problem with the pure Delete key used for deleting existing rows: the rows are marked for deletion with the red background and there's always an option to cancel the action if I've marked wrong rows. However, the problem is with new rows that have been added with the 'Add new row' or 'Duplicate current row' action. If I delete a new row then it is not marked for deletion, it disappears from the view immediately. And if I delete a new row in the Record view it is deleted although it does not disappear from the view - which is misleading and looks like a bug. In either case there is a (too) easy way of deleting new rows with the Delete key without any way to bring them back.
What I'm suggesting is:

When deleting new rows make the behaviour the same as when deleting existing rows: keep them in the view and mark them for deletion (or rather not-insertion) with the red background (also in the record view).

Add an action to revert the deletion (un-mark for deletion, remove the red background). Then if I press Delete by accident I can see immediately the row gets red background and I can revert it back. This revert action could get its own context menu entry and a shortcut key (like Ctrl+Delete or Ctrl+Z) or the same Delete action could be used for both deleting and reverting - either solution would be fine for me.

I think this would solve the real problem and additionally fix some weird and buggy behaviour. Additionally, we would get a possibility to revert rows from deletion even for the existing ones, which could come in handy sometimes.

There is no update on the ticket more than a month.
The ticket is closed.
If you want to propose any enhancement or create a feature request - feel free to create a new ticket


custom highlight format

Would love a way to set a variable in tmux to change the default highlight format as
hint_format = "\033[30;1;43m%s\033[0m"
highlight_format = "\033[1;33m%s\033[0m"

is not readable with my current terminal colorscheme

Implemented in 0.6.0 \o/ :tada:


WIP: tests: improve redirection

TODO:

[ ] revisit / test example from commit msg

Followup in https://github.com/neomake/neomake/pull/2365.


Dashboard A11y: Move focus on successful story deletion

Bug Description
When a story is deleted in the dashboard with a keyboard, focus moves to the top of the dashboard.
Expected Behaviour
The existing functionality is confusing, we should move the focus to the next story I think when a story is successfully deleted. If there's no next story to focus on then the previous one should be focused.
Steps to Reproduce
Use the keyboard to delete a story in the dashboard, see that focus is moved on successful delete.
Screenshots

Additional Context

Plugin Version:
Operating System:
Browser:

Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance Criteria

Implementation Brief

PR https://app.zenhub.com/workspace/o/google/web-stories-wp/issues/4317 has the commits for this ticket.

Verified in QA


Stack widget does not clip children wrapped in Align (beta channel)

According to this documentation: flutter.dev/go/clip-behavior, Stack is one of the few widgets that will clip it's children by default (as {Clip clipBehavior = Clip.hardEdge} is the default). However, even with a simple example (which I've pasted below) this is not the case for children wrapped in Align.
Here is an example main.dart that recreates the issue:

code sample
import 'package:flutter/material.dart';

void main() {
  runApp(MyApp());
}

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) => MaterialApp(
        home: Scaffold(
          body: SafeArea(
            child: Row(
              children: [
                Expanded(
                  child: Container(
                    decoration: BoxDecoration(
                      border: Border.all(color: Colors.green),
                    ),
                    child: Stack(
                      children: [
                        Align(
                          alignment: Alignment(-0.98, 0.43),
                          child: Container(
                            width: 120,
                            height: 120,
                            decoration: BoxDecoration(
                              shape: BoxShape.circle,
                              color: Colors.black,
                            ),
                          ),
                        ),
                        Align(
                          alignment: Alignment(1.8, 1),
                          child: Container(
                            width: 120,
                            height: 120,
                            decoration: BoxDecoration(
                              shape: BoxShape.circle,
                              color: Colors.blue,
                            ),
                          ),
                        ),
                      ],
                    ),
                  ),
                ),
                Container(width: 100, height: 100, color: Colors.red),
              ],
            ),
          ),
        ),
      );
}

Expected results: The child with Alignment(1.8, 1) extends beyond the bounds of the Stack and should be clipped.
Actual results: The child with Alignment(1.8, 1) is not clipped and is painted beyond the bounds of the Stack.
Output of flutter analyze:
Running "flutter pub get" in bug...                                408ms
Analyzing bug...
No issues found! (ran in 3.2s)

Output of flutter doctor -v:
[✓] Flutter (Channel beta, 1.24.0-10.2.pre, on Mac OS X 10.15.6 19G73 darwin-x64, locale en-US)
    • Flutter version 1.24.0-10.2.pre at /Users/agreaves/flutter
    • Framework revision 022b333a08 (2 weeks ago), 2020-11-18 11:35:09 -0800
    • Engine revision 07c1eed46b
    • Dart version 2.12.0 (build 2.12.0-29.10.beta)

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
    • Android SDK at /Users/agreaves/Library/Android/sdk
    • Platform android-29, build-tools 29.0.2
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.5)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.5, Build version 11E608c
    • CocoaPods version 1.9.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 3.5)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 40.2.2
    • Dart plugin version 191.8580
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)

[✓] VS Code (version 1.51.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.16.0

[✓] Connected device (3 available)
    • Android SDK built for x86 (mobile) • emulator-5554 • android-x86    • Android 10 (API 29) (emulator)
    • Web Server (web)                   • web-server    • web-javascript • Flutter Tools
    • Chrome (web)                       • chrome        • web-javascript • Google Chrome 86.0.4240.198

• No issues found!

Here's a snapshot of the result (it's basically just what I described):

Update: After playing around with it a little more, I noticed that adding a Positioned widget inside of the Stack changes this behavior, but only if the widget needs to be clipped. I've added code below to demonstrate:
The main.dart file demonstrating this behavior:
import 'package:flutter/material.dart';

void main() {
  runApp(MyApp());
}

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) => MaterialApp(
        home: Scaffold(
          body: SafeArea(
            child: Row(
              children: [
                Container(
                  width: 200,
                  decoration: BoxDecoration(
                    border: Border.all(color: Colors.green),
                  ),
                  child: Stack(
                    children: [
                      Positioned(
                        top: 100,
                        // Comment out the line below and uncomment the line below
                        // that to demonstrate the difference.
                        left: 90,
                        // left: 100,
                        child: Container(
                          width: 100,
                          height: 100,
                          color: Colors.indigo,
                        ),
                      ),
                      Align(
                        alignment: Alignment(-0.98, 0.23),
                        child: Container(
                          width: 120,
                          height: 120,
                          decoration: BoxDecoration(
                            shape: BoxShape.circle,
                            color: Colors.black,
                          ),
                        ),
                      ),
                      Align(
                        alignment: Alignment(1.8, 0.5),
                        child: Container(
                          width: 120,
                          height: 120,
                          decoration: BoxDecoration(
                            shape: BoxShape.circle,
                            color: Colors.blue,
                          ),
                        ),
                      ),
                    ],
                  ),
                ),
                Expanded(
                  child: Container(
                    width: 100,
                    height: 100,
                    color: Colors.red,
                  ),
                ),
              ],
            ),
          ),
        ),
      );
}

When the Positioned widget doesn't need to be clipped:

When the Positioned widget is nudged just to the right and needs to be clipped:

@agreaves
What should be the expected behavior you are looking from your updated code sample's point of view ?

The expected behavior would be that in both the first view and the second view (of my updated code), the blue circle is clipped, because it extends beyond the bounds of the stack.
If not, then I would expect them to both not clip the blue circle. The most unintuitive case (to me at least) is the case shown above, where the blue circle is only clipped when there is a Positioned widget in the Stack AND it extends beyond the bounds of the Stack.

flutter doctor -v
[✓] Flutter (Channel stable, 1.22.4, on Mac OS X 10.15.4 19E2269 darwin-x64,
    locale en-IN)
    • Flutter version 1.22.4 at /Users/dhs/documents/Fluttersdk/flutter
    • Framework revision 1aafb3a8b9 (3 weeks ago), 2020-11-13 09:59:28 -0800
    • Engine revision 2c956a31c0
    • Dart version 2.10.4

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.0)
    • Android SDK at /Users/dhs/Library/Android/sdk
    • Platform android-30, build-tools 30.0.0
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 12.0.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.0.1, Build version 12A7300
    • CocoaPods version 1.9.3

[✓] Android Studio (version 4.0)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 46.0.2
    • Dart plugin version 193.7361
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)

[✓] VS Code (version 1.51.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.16.0

[✓] Connected device (1 available)
    • sdk gphone x86 arm (mobile) • emulator-5554 • android-x86 • Android 11
      (API 30) (emulator)

• No issues found!

With Positioned widget's top is not same as left :

With Positioned widget's top = left:

The reason this happens is because Stack will only push a clip when its children overflow, in this case the immediate child of the Stack (Align) does not extend beyond it.
Perhaps Align should have its own clipping behavior, with an overflow indicator similar to Flex.

Interesting, so the Align widget doesn't extend beyond the Stack even when its child does?

Reproduces on stable 3.3 and master 3.7, Notice the Blue circle overflows but does not clip.

flutter doctor -v (mac)
[✓] Flutter (Channel master, 3.7.0-3.0.pre.33, on macOS 12.6 21G115 darwin-arm64, locale en-IN)
    • Flutter version 3.7.0-3.0.pre.33 on channel master
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision<PHONE_NUMBER> (38 minutes ago), 2022-12-05 18:27:21 -0800
    • Engine revision a309d239c4
    • Dart version 2.19.0 (build 2.19.0-463.0.dev)
    • DevTools version 2.20.0
    • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly
      to perform update checks and upgrades.

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0-rc4)
    • Android SDK at /Users/mahesh/Library/Android/sdk
    • Platform android-33, build-tools 33.0.0-rc4
    • ANDROID_HOME = /Users/mahesh/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.0.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14A400
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)

[✓] IntelliJ IDEA Community Edition (version 2021.2.1)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 61.2.4
    • Dart plugin version 212.5080.8

[✓] VS Code (version 1.70.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.55.20221129

[✓] Connected device (3 available)
    • iPhone 12 Pro (mobile) • 026D5789-9E78-4AD5-B1B2-3F8D4E7F65E4 • ios            •
      com.apple.CoreSimulator.SimRuntime.iOS-14-5 (simulator)
    • macOS (desktop)        • macos                                • darwin-arm64   • macOS 12.6 21G115 darwin-arm64
    • Chrome (web)           • chrome                               • web-javascript • Google Chrome 108.0.5359.94

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

[✓] Flutter (Channel stable, 3.3.9, on macOS 12.6 21G115 darwin-arm, locale en-IN)
    • Flutter version 3.3.9 on channel stable at /Users/mahesh/Development/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision b8f7f1f986 (24 hours ago), 2022-11-23 06:43:51 +0900
    • Engine revision 8f2221fbef
    • Dart version 2.18.5
    • DevTools version 2.15.0

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0-rc4)
    • Android SDK at /Users/mahesh/Library/Android/sdk
    • Platform android-33, build-tools 33.0.0-rc4
    • ANDROID_HOME = /Users/mahesh/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.0.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14A400
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)

[✓] IntelliJ IDEA Community Edition (version 2021.2.1)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 61.2.4
    • Dart plugin version 212.5080.8

[✓] VS Code (version 1.70.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.53.20221101

[✓] Connected device (3 available)
    • iPhone 12 Pro (mobile) • 026D5789-9E78-4AD5-B1B2-3F8D4E7F65E4 • ios            •
      com.apple.CoreSimulator.SimRuntime.iOS-14-5 (simulator)
    • macOS (desktop)        • macos                                • darwin-arm64   • macOS 12.6 21G115 darwin-arm
    • Chrome (web)           • chrome                               • web-javascript • Google Chrome 107.0.5304.110

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!