using -r switch in jq to get rid of double quotes in json

The 'sed' command was being used to remove double quotes from the result of the 'jq' command.
This can be achieved by passing '-r' to 'jq', like it was already implemented in other places of this code base.

Awesome thanks and congrats on your first contribution :)

Hi Marcin,
It was my pleasure, I've been learning a lot from great open source stuff
but I never felt I could one day contribute.
It was very simple contribution, but I guess it's a start.
I once asked Martin Thomson how can a developer become really good, and he
told me to start by being humble, to find a open source project that I
cared about and to begin with simple contributions.
And that's it. Keep up the good work!
Cheers,
Jorge
On Fri, 10 Aug 2018, 09:07 Marcin Grzejszczak<EMAIL_ADDRESS>wrote:

Awesome thanks and congrats on your first contribution :)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/spring-cloud/spring-cloud-pipelines/pull/185#issuecomment-411995597,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AOMOh-RGWYoykKNoBL3Lnks_5OqAhniHks5uPTEygaJpZM4V24lU
.

I'm humbled that you chose this project :)


Add ability to specify ssh key and known hosts

This is a wrapper around the :ssh_client_key_api callback behavior to allow specifying a key and known hosts file in a way that doesn't involve a particular user's home directory.

Great work guys! Thanks!

Included on 2.2.0 release


when I generate onnx by exporter.py, i got the error

['Car', 'Pedestrian', 'Cyclist']
3
0 -39.68 -3 69.12 39.68 1
[0.16, 0.16, 4]
32
40000
4
64
0.78539
0.0
2
[3.9, 1.6, 1.56, 0.0, 3.9, 1.6, 1.56, 1.57, 0.8, 0.6, 1.73, 0.0, 0.8, 0.6, 1.73, 1.57, 1.76, 0.6, 1.73, 0.0, 1.76, 0.6, 1.73, 1.57]
[-1.78, -0.6, -0.6]
0.1
0.01
anchors:      const float anchors[num_anchors * len_per_anchor] = {
      3.9,1.6,1.56,0.0,
      3.9,1.6,1.56,1.57,
      0.8,0.6,1.73,0.0,
      0.8,0.6,1.73,1.57,
      1.76,0.6,1.73,0.0,
      1.76,0.6,1.73,1.57,
      };

anchors:      const float anchor_bottom_heights[num_classes] = {-1.78,-0.6,-0.6,};

########
2022-03-15 11:08:59,269   INFO  ------ Convert OpenPCDet model for TensorRT ------
2022-03-15 11:09:05,030   INFO  ==> Loading parameters from checkpoint ../../checkpoint_epoch_1.pth to CPU
2022-03-15 11:09:05,171   INFO  ==> Checkpoint trained from version: pcdet+0.3.0+0642cf0
2022-03-15 11:09:05,462   INFO  ==> Done (loaded 127/127)
/home/nvidia/project/pointpillar/CUDA-PointPillars-main/tool/pcdet/models/backbones_3d/vfe/pillar_vfe.py:45: TracerWarning: Converting a tensor to a Python boolean might cause the trace to be incorrect. We can't record the data flow of Python values, so this value will be treated as a constant in the future. This means that the trace might not generalize to other inputs!
  if inputs.shape[0] > self.part:
/home/nvidia/project/pointpillar/CUDA-PointPillars-main/tool/pcdet/models/backbones_2d/map_to_bev/pointpillar_scatter.py:31: TracerWarning: Converting a tensor to a Python number might cause the trace to be incorrect. We can't record the data flow of Python values, so this value will be treated as a constant in the future. This means that the trace might not generalize to other inputs!
  batch_size = coords[:, 0].max().int().item() + 1
Traceback (most recent call last):
  File "exporter.py", line 150, in <module>
    main()
  File "exporter.py", line 135, in main
    output_names = ['cls_preds', 'box_preds', 'dir_cls_preds'], # the model's output names
  File "/home/nvidia/.local/lib/python3.6/site-packages/torch/onnx/__init__.py", line 208, in export
    custom_opsets, enable_onnx_checker, use_external_data_format)
  File "/home/nvidia/.local/lib/python3.6/site-packages/torch/onnx/utils.py", line 92, in export
    use_external_data_format=use_external_data_format)
  File "/home/nvidia/.local/lib/python3.6/site-packages/torch/onnx/utils.py", line 530, in _export
    fixed_batch_size=fixed_batch_size)
  File "/home/nvidia/.local/lib/python3.6/site-packages/torch/onnx/utils.py", line 366, in _model_to_graph
    graph, torch_out = _trace_and_get_graph_from_model(model, args)
  File "/home/nvidia/.local/lib/python3.6/site-packages/torch/onnx/utils.py", line 319, in _trace_and_get_graph_from_model
    torch.jit._get_trace_graph(model, args, strict=False, _force_outplace=False, _return_inputs_states=True)
  File "/home/nvidia/.local/lib/python3.6/site-packages/torch/jit/__init__.py", line 338, in _get_trace_graph
    outs = ONNXTracedModule(f, strict, _force_outplace, return_inputs, _return_inputs_states)(*args, **kwargs)
  File "/home/nvidia/.local/lib/python3.6/site-packages/torch/nn/modules/module.py", line 722, in _call_impl
    result = self.forward(*input, **kwargs)
  File "/home/nvidia/.local/lib/python3.6/site-packages/torch/jit/__init__.py", line 426, in forward
    self._force_outplace,
  File "/home/nvidia/.local/lib/python3.6/site-packages/torch/jit/__init__.py", line 412, in wrapper
    outs.append(self.inner(*trace_inputs))
  File "/home/nvidia/.local/lib/python3.6/site-packages/torch/nn/modules/module.py", line 720, in _call_impl
    result = self._slow_forward(*input, **kwargs)
  File "/home/nvidia/.local/lib/python3.6/site-packages/torch/nn/modules/module.py", line 704, in _slow_forward
    result = self.forward(*input, **kwargs)
  File "/home/nvidia/project/pointpillar/CUDA-PointPillars-main/tool/pcdet/models/detectors/pointpillar.py", line 31, in forward
    spatial_features_2d = self.module_list[2](spatial_features) #"BaseBEVBackbone"
  File "/home/nvidia/.local/lib/python3.6/site-packages/torch/nn/modules/module.py", line 720, in _call_impl
    result = self._slow_forward(*input, **kwargs)
  File "/home/nvidia/.local/lib/python3.6/site-packages/torch/nn/modules/module.py", line 704, in _slow_forward
    result = self.forward(*input, **kwargs)
  File "/home/nvidia/project/pointpillar/CUDA-PointPillars-main/tool/pcdet/models/backbones_2d/base_bev_backbone.py", line 103, in forward
    stride = int(spatial_features.shape[2] / x.shape[2])
RuntimeError: Integer division of tensors using div or / is no longer supported, and in a future release div will perform true division as in Python 3. Use true_divide or floor_divide (// in Python) instead.```

when I generate onnx by exporter.py, i got the error 。 How can i fix it?

Can you provide the software version，such as torch, onnx and so on. I use torch==1.6.0 onnx==1.8.1

Try with torch=1.10.1+cu113? onnx version is the same.

Try with torch=1.10.1+cu113? onnx version is the same.

how can I install high torch version of openpcdet. when I use, for example, torch 1.11.x + cuda113 the setup process error.

I use Jetson xavier NX.with JetPack4.6. I fix this by install torch==1.8.1.
after replace torch 1.8.1 the error became a warning


Add "How it Works" section for sample 7.middleware

Currently there is no "How it Works" section for sample 7.middleware and adding it will help understand how the sample works.

No longer relevant


Adjust initial_states to num_reads

As a continuation of #38, support initial_states semantics (along with initial_states_mapper) as described in https://github.com/dwavesystems/dwave-neal/issues/56.

Closed in #42.


[FEATURE REQUEST] Dark mode option

Description
Dark mode option that changes the theme of the website from light colours to dark ones for those who prefer.
Describe the solution you'd like
I can provide a toggle dark mode button near the top of the page to change the page from light mode to dark mode.

can I be assigned this issue to work on?

We are not going with a dark theme for the project


Add french translations and (very) minor rewording to English

All the translations are (hopefully) done.
Note: did some testing, and seems like french translations don't load? (screenshot below is also set to french)
Also not sure anymore about the english rewording of Show Expression List Top Bar in en.ftl line 79, as it makes the words go to the next line. I just found show top bar confusing as initially I thought it means the top black bar with the logo.

Also nice new ui for the categories!

Welp, french translations do load fine now, forgot to update the i18n-core file, will investigate prettier failing and ui fix for overflowing text in desmodder options and some weirdness in video creator menu. Might possibly need some help on ui fixing.


Slower performance than AMS with associations

Basically, we just tested our production application with fast_jsonapi, and discovered that AMS actually seems (don't have proper compiled benchmarks other than the stats I'm about to mention, but wanted to start this conversation) faster when lots of associations are used. I'm not sure where to start with speeding that up in fast_jsonapi, but there are noticeable slow-downs when associations are used, to the point where our identical AMS implementation (with even less cached columns than our new fast_jsonapi implementation--we're actually using some cached strings and integer IDs to save on costly string concatenation and database queries that AMS used to do at serialization time in our old implementation) was noticeably faster. On a large endpoint with a ~100kb response document (10 records, with 100 associations included), we're seeing 1.7s response times, whereas AMS was consistently 1.2s.
Happy to help with this, but I'm fairly confident there's something up with included associations, or relationships in general.

@TrevorHinesley one of the first steps is to get a benchmark or performance test example. I would love to figure out why it would be slow.

Definitely, we are going to try to set up some benchmark tests tomorrow and early next week. I’ll report back as soon as I have those.

Sorry about this, it turned out there was a single point of failure that was causing this that was unrelated to fast_jsonapi. It's still slightly faster with fast_jsonapi (takes about 60% of the time that AMS does). Red herring!


Add the Stochastic Indicator

Create a calculator and render for the Stochastic Oscillator.
http://www.investopedia.com/terms/s/stochasticoscillator.asp?adtest=term_page_v14_v1
Renderer very similar to the RSI

Closed via https://github.com/ScottLogic/d3fc/pull/611


Error for renku==2.9.2

Describe the bug
Building a new Python project on renkulab currently fails. It seems that it's an issue with a missing renku version:
#8 25.92 ERROR: No matching distribution found for renku==2.9.2

Link to project
https://gitlab.renkulab.io/guillaume.witz1/davpy-demos/-/jobs/701721
To Reproduce
Just create a default project.
Run environment (please complete the following information):

Default python project on renkulab

There's apparently a discrepancy between the latest release on Github 2.9.2 and the latest stable on PyPi which is 2.9.1 On PyPi there are only release candidates for 2.9.2.

sorry we missed this @guiwitz - I believe you managed to try a new project right when the new renku version was being released. Should work fine now so I'll close this for the time being.


Add BeatSaver / Scoresaber / Beatleader Buttons to Map Pages

For map pages adding other services to view specific leaderboards beside the download button 👍

No BeatSaver, but yeah.


Activities Enchantment, "Item uses" on the enchantment.

Working on some modified artificer stuff and I've run into a snag. I may not be using the system correctly, so hopefully there is a way to do this. If not, then this could be a suggestion.
So, the item I'm creating is an infusion for the artificer. It passes two activities to a piece of armor Boost STR and Prevent Prone. These two activities share charges. Now, when I create them, the only option for consumption that makes sense to me is Item uses and I set that on the infusion like so:

Now, the problem is that when it transfers these two activities to the infused piece, they stick with "This item". Obviously, the infused item has no uses, breaking the charges. Is there a way for me to lock it to the infusion ability itself? I've noticed that, once it is infused into an item, I can manually go in and edit it to use the resource like so:

So my goal is for it to transfer the activities to the piece of armor and automatically switch the target to the Armor of Magical Strength "parent" item. If this isn't a thing that is currently doable, maybe a future option?

That would probably work. Good idea, lol.


Cannot delete push notifications from apps in a public channel (not DMs)

We have configured CircleCI, Bitbucket to pour push notifications into a public channel. We can delete them manually below.

However, when running the code, these messages are excluded from the message view, hence they cannot be deleted.

Is is because these messages are not actually messages, and rather notifications? Therefore we need to replace the --message with something else?

Updated. This is solved. Actually messages coming from apps are considered "bot" and we had to use this code.
slack-cleaner --token xxx --message --channel bot-bitbucket --bot --rate 1


[FEAT] Efficient Schafer-Strimmer for MinT

This PR implements an optimized version of the Schafer-Strimmer shrunk empirical covariance algorithm for MinT.
1. Up to 60x faster
First, the result is that we can perform MinT reconciliation much faster, as demonstrated in the table below, where mint_legacy is the old version and mint is the new version, with the number in brackets denoting whether the forecasts contain NaNs (True or False) and the number of bottom-level timeseries reconciled (i.e., 20, 200, 2000). An improvement of up to 60x (on my machine, i7-12700k) is seen (no NaNs, 2000 timeseries).
Note that the NaN-version is about 3x slower than the version that doesn't have to deal with NaNs, which is due to all the masking involved when dealing with NaNs. However, it is still significantly faster than the legacy version (that doesn't handle NaNs properly).
Benchmark script can be found in tests/ and can be run using:
pytest tests\test_benchmark_mint.py -v -s
Note that pytest-benchmark should be installed to run the benchmark (pip install pytest-benchmark)

2. Forecasting performance
Forecasting performance is approximately similar:

3. Improved NaN handling
Thirdly, this improves NaN-handling (thanks to @christophertitchen for the suggestions!), leading to more cases that MinT can handle. For example, introducing 20% NaN values in the Australian Tourism forecasts couldn't be handled by the old version but the new version will give results nearly identical to the no-nan case:

Code for introducing NaNs in the Australian Tourism example:
# Randomly set NaNs
nan_fraction = 0.2
Y_fitted_df = Y_fitted_df.reset_index()
Y_fitted_df_sample_idx = Y_fitted_df.sample(frac=nan_fraction).index
Y_fitted_df.loc[Y_fitted_df_sample_idx, ["y", "ETS"]] = np.nan
Y_fitted_df = Y_fitted_df.set_index("unique_id")

@christophertitchen Again thanks for the remarks, I made a few other micro optimizations, in the end in total further reducing computation time by ~30%

I am happy the comments were helpful!
The only further change I thought of would be to potentially modify the naïve approach when computing covariance and correlation to a pairwise approach for each time series, like what is done in stats::cov for R. This could better describe the relationship between pairs of time series, but honestly, it would slow down the generation of the shrunk W and go against the spirit of what you were trying to achieve here by implementing a fast method, so I think it is perfectly fine as you have done it.
As a quick example to demonstrate, imagine monthly time series representing the units sold of products over the past six months.  The residuals of a naïve forecast would be:
X = [ ( x t − 6 − x t − 7 ) , ( x t − 5 − x t − 6 ) , ( x t − 4 − x t − 5 ) , ( x t − 3 − x t − 4 ) , ( x t − 2 − x t − 3 ) , ( x t − 1 − x t − 2 ) ]
Y = [ − , − , − , ( y t − 3 − y t − 4 ) , ( y t − 2 − y t − 3 ) , ( y t − 1 − y t − 2 ) ]
This approach would use an n_samples of 6 and the the mean of X would include all six observations. However, a pairwise approach would only use pairs of temporally aligned observations, so an n_samples of 3 , and the mean of X would be X ― = ( ( x t − 3 − x t − 4 ) + ( x t − 2 − x t − 3 ) + ( x t − 1 − x t − 2 ) ) / 3 , which would obviously lead to a different cov ( X , Y ) , corr ( X , Y ) , σ x for standardisation and so on.
not_mask = ~np.isnan(residuals)

...
for i in prange(n_timeseries):
    x = residuals[i]
    for j in range(i + 1):
        y = residuals[j]
        # Get the temporally aligned pairs of observations.
        mask = not_mask[i] & not_mask[j]
        n_samples = len(mask)
        # Check for insufficient observations for unbiased estimator.
        if n_samples - 1 == 0:
            ...
        x = x[mask]
        y = y[mask]
        # Calculate the pairwise sample means.
        mean_x = np.mean(x)
        mean_y = np.mean(y)
        ...

Anyway, I am not familiar with any literature on this topic or if there is any evidence to suggest it is significantly worse, and the legacy version also takes the same approach, so as I said, I favour the fast approach you have implemented here. Good job!

Didn't think about this, but it's a good point. I'll have a try and play around a bit with it :)

@christophertitchen Thanks for the suggestion for the temporal alignment - I included two versions, one that can handle NaNs in the way you describe. It's a bit slower but it enlarges the scope of MinT significantly, as it can handle much more cases without leading to ill-conditioned W matrices.

@christophertitchen Again thanks for the thoughtful comments.
I think I'll be deprecating the legacy version now that I get equivalent results across datasets.

@christophertitchen Again thanks for the thoughtful comments.
I think I'll be deprecating the legacy version now that I get equivalent results across datasets.

@elephaint great job!
Also, regarding Hyndman's implementation, you were right.
https://github.com/earowang/hts/blob/1408ab2c5c40f1022e6957bcf8438aaefc8464bf/R/MinT.R#L24
  covm <- crossprod(x) / n

  v <- (1/(n * (n - 1))) * (crossprod(xs^2) - 1/n * (crossprod(xs))^2)

It uses the biased estimator, i.e. normalisation by $N$. We could have changed ddof in np.ma.cov to $0$ to copy this approach, but deprecating the legacy approach in favour of your superior one makes sense. 😉


State access checking failing valid script

State access checking is failing scripts that are valid, e.g.
    run-permations:
      - for-each: TEST ${{TESTS}}
        then:
        - for-each: VERSION ${{QUARKUS_VERSIONS}}
          then:
          - set-state: RUN.results.${{TEST}}["${{VERSION}}"].something 1000
      - sh: echo '${{RUN.results}}' > /tmp/results.json
      - download: ${{RESULT_FILE}}

Will fail to run with the following message;
Error: results is used before it appears to be set
  role: build stage: run script: run-permations
  command: sh: echo '${{RUN.results}}' > /tmp/results.json

In this instance, the state is built dynamically and will be valid at the point it is accessed.  There is no branching in the script logic such that the state might not be instantiated at the point it is accessed.  So users either have to add boilerplate code to instantiate state at the start of the script or in the states: section
or
the error is reported as a WARN and the script is allowed to run
@willr3 wdyt?

You're right, that looks like it should work.
I will add a test case and work on a fix.

You're right, that looks like it should work.
I will add a test case and work on a fix.


Emulating initalState function for Hooks

Turns out my previous fix only papers over the real issue in #73.
Halogen does not seem to guarantee the order in which HalogenQ fires. It's possible that Receive or Query arrive before Initialize. This means that the HookState has to be ready before evalHook is ever called. mkInitialState contains most of the old Initialize step code.
This PR adds the mkInitialState function which is an analog to initialState in vanilla Halogen. Given a Hook and the input it constructs the HookState required for evalHook.
Unfortunately this is a big change and I had to touch every test. It also slightly changes the behavior:

the initial render is actually valid instead of just an empty text node
UseMemo now also runs before the Initialize-step

Hi @jterbraak! Thanks for opening this PR. I'm on vacation until October 9, and I can take a thorough look at this then.


T&C

Add T&C and Privacy Policy
https://getterms.io/g/2VbOrhD

We should turn these onto page on the site.

[ ] Privacy Policy
[ ] Add Terms of Service
[ ] Add Cookie Policy
[ ] Add small links in the footer.

On it! Thanks for the additional details @mmmoli

@all-contributors please add @rebagliatte to code


Improve engine event loop task prioritization

Expired tasks posted on task runners in the Flutter engine are serviced in FIFO order. For threads that service a large number of tasks, critical tasks related to jank free operation may be queued behind asynchronous callbacks that are of little relevance to frame workloads. A mechanism to identify and service UI critical tasks in the core event loop mechanism of the Flutter Engine is desirable.
Identifying and preferring UI critical tasks also gives the engine the ability to surface feedback to app developers when non-UI tasks cause UI tasks to miss deadlines.
/cc @iskakaushik @chinmaygarde (Filing an issue for this since I think we didn't already have one, but feel free to close this one as a duplicate if I'm mistaken.)

closed by https://github.com/flutter/engine/pull/25307

Re-opening for revert.

This has re-landed, but will close after roll to g3.


Merge master branch to prTesting1_202010301923 branch

Docs Build status updates of commit 4151922:
:clock10: Pending: waiting for processors (5 builds ahead of you)
:warning: Docs Build is busy, currently there are 5 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit 4151922:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/updateTestRef1.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Add 'Type-check name' from the book

The book 'Type-driven Development with Idris' by Edwin Brady
describes a 'Type-check name' command in the Atom extension
for Idris (called with Ctrl-Alt-T).
It is described as showing the type of a hole, and the types
of all the variables associated with it.
It seemed useful to me but there wasn't tooling for it, so
I have attempted to replicate its functionality as close
to the description in the book as I could get it.

I am pretty sure that what you are describing is what the Idris 2 LSP already surfaces as the result of the hover action.
That is, the Neovim plugin does not need to offer a special option to support it because you can already bind whatever you'd like to vim.lsp.buf.hover. I've got '<Leader>t' bound to hover which gives the same result as you used to get from Edwin's older Neovim plugin and the same result as I am pretty sure Ctrl-Alt-T gave in the Atom extension.

Yeah I realized this a couple of weeks after I'd made this pull request, and then forgot I made this PR. I'll close it now, thanks.


BUG 2030752: rbd: execute rbd image promote with timeout

added ExecCommandWithTimeout helper function to execute the commands with the timeout option, if the command does not return any response within the timeout time the process will be terminated and an error will be returned back to the user.
use ExecCommandWithTimeout with a timeout of 1 minute for the promote operation. If the command does not return an error/response in 1 minute the process will be killed and the error will be returned to the user
backport of https://github.com/ceph/ceph-csi/pull/2737
Signed-off-by: Madhu Rajanna<EMAIL_ADDRESS>

/assign @agarwal-mudit


Cannot install from marketplace

Not sure if vscode issue or not, but when I go to install this from the vs code marketplace, cpu gets pegged to max and freezes the marketplace.  all other installs are fine

Is this still an issue?

Yeah still can’t get it
Cheers,
Daniel
On 16 Dec 2022, at 7:41 pm, Jan Schaffranek @.***> wrote:

Is this still an issue?
—
Reply to this email directly, view it on GitHubhttps://github.com/franneck94/Vscode-C-Cpp-Runner/issues/88#issuecomment-1354464501, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A4IANXXETG4A5BNFXKMDIDLWNQ2K3ANCNFSM6AAAAAATAHKIAQ.
You are receiving this because you authored the thread.Message ID: @.***>

What do you mean with marketplace?
This: https://marketplace.visualstudio.com/vscode ?
So You downloaded the vsix file?


CentOS 8 Ruby 2.7.2 do-install-nodoc Installation Error

I cannot install Ruby 2.7.2. It is listed as an option.  Not sure what's happening here.  Tried twice.
https://pastebin.com/QWtt8tgf
openssl-x86_64 is indeed installed.

Solved.
sudo yum install openssl-devel


Remove osutil dependency

The osutil package doesn't appear to be Windows compatible. The only method being used was CopyUtil. I copied the CopyUtil function into the main.go file and cleaned up the go.mod file.

Just to be abundantly clear, this changeset allows the code to compile and run on Windows machines. After compiling, I ran go-mutesting . against a sample project and everything appeared to work properly. This should resolve #58.


Change information section title smaller

Issue

#182

Overview (Required)

Change information section title smaller

Links

Screenshot

Before
After

Perfect! 💯  Thank you for contribution!


Problems with the String output of pretty_table from PrettyTables.jl in Pluto cell

I am not sure whether this issue should be filed here on on PrettyTables, but basically using the @htl macro on the String output from the pretty_table functions doesn't correctly renders the HTML in a pluto cell, but simply puts the HTML code inside the text of the pluto output.
The same string is correctly parsed by the HTML() function.
Here is an example:

I don't know whether this is expected or if it is indeed an issue that was not known.

My guess is that PrettyTables isn't implementing show(obj, "text/html").

So, I opened a ticket over in PrettyTables with this detail.  I hope this helps.

Oh.  I see why you've thought this way.  Hmm.  I hadn't thought of @htl used in this manner.  Let me investigate further.

@clarkevans, thanks for the prompt reply and overall for the package that seems awesome.
I indeed filed the issue here while probably it is more relevant to the other package.
At default PrettyTables prints the html directly to the stdout and I didn't find a way to provide a custom io rathern than stdout.
In some discussion I was seeing the suggestion of using the form I put above HTML(pretty_table(String,...)) for correctly displaying on Pluto and given that this package seems to be just better in every aspect with respect to the standard HTML function I just tried to translate it directly.
I was in a bit of rush to get results so I didn't go too much into the documentation details of both packages so I will do that now that I have some more time and hopefully give more context.

Thank you for reporting this.  I can see how this was confusing, moreover, the behavior was incorrect.  I was treating the argument as a callable expression returning value that should be escaped.  What you have is a function that is returning a string.  The macro actually needs a string literal, not a string value or a function returning a string.  So, I've fixed this issue... by raising an error.
https://github.com/MechanicalRabbit/HypertextLiteral.jl/commit/5f3543e756d58ab1a187d92e35961f0103c1f049
...
One option I considered (but rejected) is to evaluate the expression immediately, and then use the String result of that expression as a template, e.g.
expr = __module__.eval(code)

However this creates the opportunity for perhaps unintended outcomes, as described by Mason Protter.
julia> macro whichtype(code)
          if isa(code,Symbol) && isdefined(__module__,code)
             return typeof(__module__.eval(code))
          end
          return esc(code)
       end
@whichtype (macro with 1 method)

julia> n = 1
1

julia> @macroexpand foo(n) = @whichtype n
:(foo(n) = begin
          #= REPL[99]:1 =#
          Int64
      end)

I think if someone wishes to to dynamically build a template, they might use @htl_str() instead.

Thanks for the clarification.
In the end, in case someone has a similar issue, for my use case I realized I could achieve my functionality by writing:
s = pretty_table(String,args...)
eval(:(@htl $s))


ci(windows): always cleanup after build or test

Issue #, if available:
Description of changes:
Use the always() built in status check function to always run cleanup steps, even if a job is cancelled:
https://docs.github.com/en/actions/learn-github-actions/expressions#status-check-functions
Testing done:
refactor

[x] I've reviewed the guidance in CONTRIBUTING.md

License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Nice, TIL about always(). LGTM


Clipping

As described in #58 , the PR includes clipping algorithm, bigram, bipartite entanglement.

Thanks! I will do a quick first pass review, but there is no need to start addressing these comments until a full review is done.

I think these are all the comments I have. This is a great addition, thanks for writing it.

Codecov Report

Merging #59 (c3f6f0b) into master (0a10120) will increase coverage by 0.61%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #59      +/-   ##
==========================================
+ Coverage   70.12%   70.73%   +0.61%
==========================================
  Files          14       15       +1
  Lines        2122     2221      +99
==========================================
+ Hits         1488     1571      +83
- Misses        634      650      +16

Impacted Files
Coverage Δ

src/QuantumClifford.jl
75.48% <ø> (-0.97%)
:arrow_down:

src/graphs.jl
100.00% <ø> (+2.32%)
:arrow_up:

src/entanglement.jl
100.00% <100.00%> (ø)

src/canonicalization.jl
96.18% <0.00%> (-2.30%)
:arrow_down:

src/symbolic_cliffords.jl
73.26% <0.00%> (-2.14%)
:arrow_down:

src/project_trace_reset.jl
86.71% <0.00%> (-1.33%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a10120...c3f6f0b. Read the comment docs.

Hi, @Krastanov , thanks again for your detailed reviews! By https://github.com/Krastanov/QuantumClifford.jl/pull/59/commits/b721b98fe52d840960c4690addc4033a4734d332, I suppose all modifications are completed according to our discussion.

It seems there is a bibtex reference missing in the docs (check the failing build above). It is nahum2017quantum. Could you add it in?

I wrote a wrong ref entry name. Now should be good.

Great! This is merged now. Thank you for contributing this and let me know if there are other related tools that would be useful to you that we can look into adding!
I will release a new version towards the end of the week: there are some minor addition that I would like to look into first.


delay between physical line and voip

My ont-router config has a output for the typical rj11 infrastructure, I've tryed to do some calls but baresip always starts notifying the call like 4 tones latter than the "copper" instalation. What could I do to enhace the detection of incomming calls?

@ccokee
do you have some more information about the setup, versions, logs etc?
is the issue that there is a long delay for incoming calls ?
(how long is 4 tones ?)
Alfred

Well I clearly didnt found the exact word I meant (Im spanish). I have a router+switch+ont+voip  box from my ftth provider. This box has an output for old twisted pair phone installations... Instead of having a PTR I get line in the classic telephones through that box. Well, the thing is, when I call my home with baresip open un my computer and connected to my home voip, baresip starts ringing waaaaaaay later than the normal phones do. Is this a known issue?

in a normal setup there should be virtually no delay from the SIP proxy to baresip.
how long is the delay you are talking about? is it 1 second, 10 seconds or 100 seconds ?
can you please provide the baresip output from start and until there is
an incoming call ?
also a Wireshark or ngrep trace would be nice to have a look at.
(sudo ngrep -p -d any -W byline port 5060).

closing due to lack of response. feel free to re-open if you can provide the requested info.


Using wmic from zsh (cygwin) causes conhost to crash

Environment
Windows build number: 10.0.18362.0
Windows Terminal version (if applicable): 0.10.781.0

Any other software?
zsh (from cygwin package manager)

Steps to reproduce

Type wmic <- First round
Press Ctrl-C
Type wmic again <- Second round
Press Ctrl-C

Then OpenConsole.exe crashes with exit code 1.

Expected behavior

Other shells work just fine (w/ and wo/ Windows Terminal), only zsh causes OpenConsole.exe to crash.
Bash

Bash (from cygwin, running with Windows Terminal)

Git Bash (MINGW64)

Windows PowerShell, running with Windows Terminal

Windows Command Prompt, running with Windows Terminal

zsh, first round

zsh, second round before pressing Ctrl-C

zsh, second round after pressing Ctrl-C

(I didn't scroll the console window, it looks like the console just scrolled itself)
Actual behavior
When you do the first time, nothing abnormal happens

If you do it again, OpenConsole.exe crashes and Windows Error Reporting prompts up.

leaving output: [process exited with code 1]
Although I used oh-my-zsh for customization, zsh itself without any modification will crash OpenConsole.exe to crash, too.
My guess is that zsh printed something corrupt that OpenConsole.exe cannot handle. And zsh is the only shell that outputs a little % after Ctrl-C is pressed.

Triage notes: wmic sets the screen to be 1500x300 characters (which is insane); when zsh later attempts to clear part of the screen we try to access a character that's out of bounds.

This reproduces in the windows console host if the buffer size and screen size are set to the same thing. Even in Windows 20H1.

Marking this for 21H1, taking triage off.

I've got good news and bad news.

Arguably, whatever they were doing should still not crash, even if wmic itself is deprecated.

Meh, this one and #7581 are the same thing. That other thread's got a better non-wmic repro though, so I'm gonna use that one. Thanks!
/dup #7581


Killssimulator

Closing as this is very old PR now and has a lot of merge conflicts, reopen if you want to re-implement it.


Use test materialization when executing ✨generic✨ tests

Current Behavior
generic (aka schema) tests are currently executed using the python api directly.
https://github.com/fishtown-analytics/dbt/blob/77c10713a325d2bee91d1822951ce5d91ccc3278/core/dbt/task/test.py#L84-L85
Desired Behavior
Schema tests should be executed and handled by the same test materialization used for data tests. The goal here is to maintain existing behavior handling results (simply interpreting number of rows returned by count(*) for the test)
Things to consider
Returning results for most schema tests is straight forward, we can simply remove count(*) and return the results of the query fulfilling the test, the materialization will take care of the rest. In some cases, this is not straight forward for tests that are simple pass/fail and do not necessarily return results.
Example:
https://github.com/fishtown-analytics/dbt/blob/749f87397ec1e0a270b2e09bd8dbeb71862fdb81/test/integration/005_simple_seed_test/macros/schema_test.sql
We will have to create a way to interpret different types of results as part of this.

@ezequielberto I'm hopeful that a migration to the new testing mechanisms in v0.20 is smoother than it may first appear. In fact, I think you have some options.

Leverage new error_if + warn_if configs: The behavior you're after with tolerate_errors is now available via built-in test configs. This could be as simple as:

with validation_errors as (
    select
        left_.id as left_id,
        right_.id as right_id
    from (select {{ column_name }} as id from {{ model }}) as left_
        left join (select {{ field }} as id from {{ to }}) as right_
            on left_.id = right_.id
    where left_.id is not null
        and right_.id is null
)
select * from validation_errors

Then replace tolerate_errors with error_if and/or warn_if in the test definition:
relationships:
  to: ...
  field: ...
  error_if: 10
  warn_if: 50

Light rewrite just to get this working: The test defined above is perfectly workable up until the last CTE, where it returns numeric 0 or 1 in a case when statement. Instead, you could move the case when comparison to a where filter:

select * from count_errors
where n_errors > {{ tolerate_errors }}


report version of firmware that a ruuvi device is running

In the tag settings part of the app under the "more info" section it would be useful to list the current version of firmware that the tag is running, probably at the top above the MAC address would be a good spot.

This is not possible because data format does not include this data. However, on the latest connectable firmware 3.x this is possible and will be implemented. Closing.


docs: include the -lock file to hopefully make CI builds consist with local ones

I couldn't reproduce the issue, so im thinking that including the lock file so the CI uses the same dependencies might fix it.
Looking around the error we got is webpack dependency version related, if it continues ill keep an eye on it / dig deeper.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.004%) to 54.644%

Totals

Change from base Build<PHONE_NUMBER>:
0.004%

Covered Lines:
40510

Relevant Lines:
74135

💛  - Coveralls


feat:  update deneb types and spec to 1.4.0-alpha.1

update types and spec to 1.4.0-alpha.1 for devnet-6

:tada: This PR is included in v1.9.0 :tada:


Add PreviewImage component

There's a bunch of this logic that gets repeated in listings. This component makes it easier to reuse that logic.
There's a 'cover' option, which sets the preview image as background image. I thought it would be interesting to have it, there's listing scenarios where it could be useful.

I think I like it, I'll have a deeper look into it

@sneridagh right. No need for old school tricks. I'll remove that option

@tiberiuichim @nzambello how this one relates to the uber Image component?

Not related to this PR: I sometimes find the preview_image not shown when used in the summary template of the listing block without any criteria set. Dunno if it's a real bug, but then the listing block without criteria should not be supposed to save!

@nileshgulia1 That's this ticket: https://github.com/plone/volto/issues/2891
The listing block without criteria works in "folder contents mode", listing the children of the current folder.

This PR should be brought up to date.


Feature Request: Keyboard command to Find

I often use Ctrl+F to find a song or artist from a long list. Would be nice if it was possible to do in the app. It doesn't need to be mapped to Ctrl+F necessarily.

I'm submitted a pull request #103 for this feature, I thought it was a good idea

@FuzzAU next time in your PR description say "Fixes #93" then when it gets merged this issue will automatically close :+1:


Form UI

Feature request（新功能建议）
Really missing the form ui with validations. In README file image, I can see Form section, but in preview form page is not there.

I don't quite understand what you want to express.


Train page: Output window still shows 'Code generated' section

System Information (please complete the following information):

Model Builder Version: <IP_ADDRESS>5801
Visual Studio Version

Describe the bug

On which step of the process did you run into an issue: Train page
Clear description of the problem: After training is complete, the output window shows "Code generated" section. This will not be needed anymore since the Consume page now has a code-snippet section for customers to use instead.

To Reproduce
Steps to reproduce the behavior:

Go to
Click on '....'
Scroll down to '....'
See error

Expected behavior
Code generated section not needed in the output window on Train page.
Screenshots

Additional context
Add any other context about the problem here.

Validate this issue on Main branch: https://privategallery.blob.core.windows.net/gallery/refs/heads/main/atom.xml

Windows 10 Enterprise, Version 20H2
ML.Net Model Builder (Preview): <IP_ADDRESS>2301
Microsoft Visual Studio Enterprise 2019: 16.9.4
.Net: 5.0.202

After trained, find the Code generated section shows in Output window, but the messages have changed.

@zewditu , as I can't access the referenced issue https://app.zenhub.com/workspace/o/dotnet/machinelearning-tools/issues/972 to get more information, could you help to confirm whether the changed Code generated part is expected?

The "code generated" section is not needed in the output window on the Train page, including the title 'code generated'.
@briacht could you please confirm this?

Repro on Main branch: https://privategallery.blob.core.windows.net/gallery/refs/heads/main/atom.xml

Windows 10 Enterprise, Version 20H2
ML.Net Model Builder (Preview): <IP_ADDRESS>2903
Microsoft Visual Studio Enterprise 2019: 16.9.4
.Net: 5.0.202

Still reproducable
@zewditu can you take a look?

I think the original intention of adding "Code generated"  is to update the status of the generation of code-behind files. @romalpani   why we need to remove it, is that because of the redundancy of info(we already have it in the main window)?
Generate code-behind files.

If the sentences highlighted in the above screenshot are like bookends to what's happening between them, then yes, we can maintain it. My understanding before was that "Code generated" was for the "consume code", not code-behind files.
Since we are at it, could we perhaps update the copy there to reflect exactly what's happening...
E.g.,
Generating code-behind files

Code-behind files generated
Thoughts @briacht ?

The "Code generated" was removed on main branch:  <IP_ADDRESS>2901


[2.0.1] Add manifest file parsing (#3105)

Add -m/--manifest flag to accept manifest.yml produced by
epicli init/prepare

Add -v/--verbose mode for printing out parsed manifest data

Add ManifestReader class used for paring the manifest.yml file

Move src/command/*.py to debian/redhat subdirs where needed

@sbbroot Can you resolve the conflicts before review?

@sbbroot Could we pls make a feature branch for this for now and not merge it straight into develop?

Also @sbbroot 2 scenarios to think about:

People are using it after the prepare step, so they will include their manifest.yml file. Just wondering if in that case there should be a merge/validate procedure in place like we have for apply etc.
People are just including the manifest in apply. do we want apply to also only generate the partial downloading of the requirements from the start?

@seriva

Yes, there is a separate issue for this: #3103
I assume "yes", default manifest.yml alone provides enough information to reduce the number of downloaded files.


Add get-started-macvlan.md to TOC

Describe the proposed changes
Added topic to the TOC, removed some extraneous metadata from the topic
Project version
n/a
Related issue
#252
Related issue or PR in another project
n/a
Please take a look
@danix800 @johndmulhausen

LGTM!


vendor.min.js:59 Uncaught ReferenceError: _ is not defined

This method throws an error.
.constant('', )
.constant('moment', moment)
.factory('timezoneFactory', ['', 'moment', function (, moment) {
return {
get: function () {
var timezoneMap = {}
.forEach(moment.tz.names(), function (zoneName) {
var tz = moment.tz(zoneName)
timezoneMap[zoneName] = {
id: zoneName,
name: zoneName.replace(//g, ' '),
offset: 'UTC' + tz.format('Z'),
nOffset: tz.utcOffset()
}
})
return timezoneMap
}
}
}])

Looks like you don't have lodash installed or your build system is removing underscores. If you have a look at the built file here you'll see that  the code should be like this
  .constant('_', _)
  .constant('moment', moment)
  .factory('timezoneFactory', ['_', 'moment', function (_, moment) {

Note how the one you pasted is missing underscores

thanks for your response.


Cluster broken after 1.20.2 update

After auto upgrading of my nodes to v1.20.2 today they started to become Not Ready. I suspected the minor versions to be incompatible so I upgraded all nodes and the master to the most recent snap version.
The master somehow recovered and is displayed as Ready by kubectl get nodes. The nodes however did not. They actually did not even send their current version to the master which stayed pre-update.
ubuntu@pi-k8s-1:/var/snap/microk8s/current$ kubectl get nodes
NAME       STATUS     ROLES    AGE    VERSION
pi-k8s-1   Ready      <none>   226d   v1.20.2-35+e99a4bd69e2a3e
pi-k8s-2   NotReady   <none>   226d   v1.20.1-34+97978f80232b01

I tried to rejoin another node (pi-k8s-3) to the cluster and even did a hard reset on microk8s on that node. But the join process does not succeed even after a fresh install of the snap on node 3. Failed to join cluster. Error code 500. There seems something to be really off after the upgrade with the communication and I suspect the errors to be related.
Maybe it is related to the introduction of kubelite which were not present before.
Is there some way to recover my cluster maybe by temporarily reverting from kubelite to the way it was before?
I am happy to provide more details if needed.
Inspect on master node
Inspecting Certificates
Inspecting services
  Service snap.microk8s.daemon-cluster-agent is running
  Service snap.microk8s.daemon-containerd is running
  Service snap.microk8s.daemon-apiserver-kicker is running
  Service snap.microk8s.daemon-kubelite is running
  Service snap.microk8s.daemon-flanneld is running
  Service snap.microk8s.daemon-etcd is running
  Copy service arguments to the final report tarball
Inspecting AppArmor configuration
Gathering system information
  Copy processes list to the final report tarball
  Copy snap list to the final report tarball
  Copy VM name (or none) to the final report tarball
  Copy disk usage information to the final report tarball
  Copy memory usage information to the final report tarball
  Copy server uptime to the final report tarball
  Copy current linux distribution to the final report tarball
  Copy openSSL information to the final report tarball
  Copy network configuration to the final report tarball
Inspecting kubernetes cluster
  Inspect kubernetes cluster
Inspecting juju
  Inspect Juju
Inspecting kubeflow
  Inspect Kubeflow

 WARNING:  Port 16443 seems to be in use by another application.
# Warning: iptables-legacy tables present, use iptables-legacy to see them
Building the report tarball
  Report tarball is at /var/snap/microk8s/2048/inspection-report-20210216_151718.tar.gz

inspection-report-20210216_151718.tar.gz
Port 16443 is used by kubelite according to ss -tulwnp which seems somehow related.

Hi @oleo65 thank you for reporting this.
Indeed, kubelite is the problem here. We have reverted the offending revision so now the nodes should be running with the old setup (no kubelite).
The issue at hand appeared in the context of a non-HA (etcd based) cluster as the one you have here. kubelite would try to start all services, including the control plane but this is not what should happen in the non-HA setup. We are working on this case now.
Something not related to this issue. Your cluster is a long lasting one (209) days. For such use cases you may want to follow a channel other than the latest/stable so you do not get surprising upgrades (eg from 1.20 to 1.21).

Perfect @ktsakalozos thank you alot for your feedback and fast response. Really appreciated.
The cluster started automagically working again after the latest snaps arrived on the nodes. I really like the snap concept for being no frills most of the time.
Thank you also for your feedback related to the specific release channels. I was getting more familiar with snap and kube over the last month and should probably pin it to a specific channel and then intentionally trigger the update to the next major revision.
As far as the current issue is concerned, pinning to 1.20/stable would not have prevented this, right?

As far as the current issue is concerned, pinning to 1.20/stable would not have prevented this, right?

No it wouldn't. We thought kubelite would have been a drop-in replacement to k8s services but we missed some usecases. It will be released on v1.21.

Will be closing this issue.  Since it is already addressed.
Thanks


Using a Custom Model (or Models) on Magic Leap 2

Hi!
I wanted to implement your code on a Magic Leap 2 application. Could you please let me know which parts of the code to change to implement a custom model? And which script should I change to change the labeling on the tag? Is there a character limit?
I'm also looking at training multiple models to use in different parts of the application (so that the minimumProbability can be set at a higher number without risk for false detections). Would this work with your implementation of YOLO? Or is the model only loaded once when the application is run?
Sorry for the many questions, any help would be appreciated! I love your work :)

Thank you. Have you, I by any chance, I seen this article on my blog? https://localjoost.github.io/Running-a-YoloV8-model-on-a-Magic-Leap-2-to-recognize-objects-in-3D-space/

Yes, I have. I downloaded the project file for Magic Leap 2 and have been looking through the various scripts to find where it accesses the ONNX file. I'm not too familiar with C# but it seemed like Line 11 of YoloProcessorProfile.cs was where you'd make the change for a custom model. Is this correct? And if so, is menuName for the Translator file and fileName for the ONNX model?
Thanks for the quick reply

Hi @ThisisSaron, if you look into my various Yolo blogs you might be able to piece this together yourself, but I hope to save you some time by these images:
If you want to use a different model, just drag in into the Model field of the YoloV8ProcessorProfile.

If you want the classes correctly translated, you will need to make a Translator file. Samples are DemoModelTranslator and V8AirplaneTranslator. They need to implement IYoloClassTranslator. The list is 0 based, so if we take DemoModelTranslator , class 0 is "person", class 1 is "bicycle", class 2 is "car", etc. The V8AirplaneTranslator only has one class, number 0, "airplane",  because the model recognizes only one type of object. The exact values and order of values depend on your model. Once you created a Translator, you should be able to select it from the drop down in the processor profile:

So you can swap out your model with changing very little code.
Caveats: HoloLens 2 is a powerful spatial computer, but it does not have much power to spare for other things. Performance goes down the drain pretty quickly if you take larger Yolo models. I used the very, very smallest (nano) models, and I could get about 3-4 recognitions per second. Also, the model's image size is very small (320x256) so any images you feed to it should be scaled down to that.
Good luck!

Okay, thank you. I didn't realize it could be done through the GUI on the asset. I really appreciate your help!


chore: add cleanup resources script for codebuild

Description of changes

Added resource cleanup scripts for codebuild
Fixed the lint script so that it now can emit the lint error instead of ignore it in codebuild

Issue #, if available

Description of how you validated changes
Run the cleanup workflow in beta accounts
Checklist

[x] PR description included
[x] yarn test passes
[ ] Tests are changed or added
[ ] Relevant documentation is changed or added (and PR referenced)
[ ] Breaking changes to existing customers are released behind a feature flag or major version update
[ ] Changes are tested using sample applications for all relevant platforms (iOS/android/flutter/Javascript) that use the feature added/modified

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #622 (c96da6a) into main (8fb4331) will not change coverage.
The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@           Coverage Diff           @@
##             main     #622   +/-   ##
=======================================
  Coverage   85.93%   85.93%
=======================================
  Files         152      152
  Lines        7489     7489
  Branches     1956     1956
=======================================
  Hits         6436     6436
  Misses        960      960
  Partials       93       93

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Stop times after midnight fix

Allow the output of stop times that occur after midnight by decrementing
the hour until it is parseable by moment.

Thanks!


Ask user to disable battery optimisation for background scanning

1.7.14

@andreevdenis is this related to widgets?

Changes were made in background scan settings screen and widget setup screen.

QA passed


How to configure SWC options? To use Stage 3 decorators, for example.

Hi,
Basically the question is this:
How can I test SWC Stage 3 decorator support when using React SWC plugin?
Some background:
SWC recently shipped with Stage 3 decorator support: https://swc.rs/docs/configuration/compilation#jsctransformdecoratorversion
I'd like to try it out with React SWC plugin, but I don't see where to pass those options. Simply creating .swcrc file (with the following contents) at the root of the project does nothing:
{
  "jsc": {
    "parser": {
      "syntax": "ecmascript",
      "decorators": true
    },
    "transform": {
      "decoratorVersion": "2022-03"
    }
  }
}

I also don't see a config to pass SWC options to the React SWC plugin:
import { PluginOption } from "vite";
type Options = {
    /**
     * Control where the JSX factory is imported from.
     * @default "react"
     */
    jsxImportSource?: string;
    /**
     * Enable TypeScript decorators. Requires experimentalDecorators in tsconfig.
     * @default false
     */
    tsDecorators?: boolean;
    /**
     * Use SWC plugins. Enable SWC at build time.
     * @default undefined
     */
    plugins?: [string, Record<string, any>][];
};
declare const react: (_options?: Options) => PluginOption[];
export default react;

I would expect being able to pass SWC options to the React SWC plugin like so, if the options in .swcrc file are not picked up when using SWC via the React SWC plugin:
plugins: [react({
  swcOptions: {
    "jsc": {
      "parser": {
        "syntax": "ecmascript",
        "decorators": true
      },
      "transform": {
        "decoratorVersion": "2022-03"
      }
    }
  }
})],

Any help is appreciated!

Hi,
We decided to not support decorators for JS files: https://github.com/vitejs/vite-plugin-react-swc/issues/60#issuecomment-1484278954
Seeing how much this spec has changed make me confortable with the idea that this should not be easy to use until shipped browser.
If you really want to use it with pure JS, the plugin is easy to patch

@ArnaudBarre Thank you for your quick response. I'm actually trying to make use of Stage 3 decorators in a TypeScript (v5) project. From my understanding, Stage 3 decorators are transpiled to JS code that works in current browsers, as can be seen in the following example.
If you copy-paste the transpiled output into the console, you'll see the expected output mentioned in the official TS 5.0 announcement.
With that in mind, what do you think is still missing for Stage 3 decorators to be usable in a Vite/React/Typescript project?

Oh I see. I need to look at how esbuild handles this, but as soon as esbuild also correctly handles the new decorator version for TS (maybe it already does) I will publish a major version that makes tsDecorators default to the standards

I believe the work hasn't even started in esbuild: https://github.com/evanw/esbuild/issues/104
But SWC shipped with initial support a few days ago. Some work is still outstanding though:
https://github.com/swc-project/swc/discussions/5053#discussioncomment-5543835
https://github.com/swc-project/swc/issues/7193
But from my understanding there's enough there already for decorators to be usable.

Thanks for the links.
The proposal was merged 6 hours ago 😮
I will wait a week or two to see what API will be shipped in esbuild. Maybe this will be in a breaking version of esbuild, meaning that we will need to wait for Vite core to release a version with it so that the plugin can expect it.
If you want to try output the change in the meantime, you can patch the plugin to pass decoratorVersion to SWC and use plugins: [] to force the plugin to use SWC at build time so that decorators are transformed by SWC and not esbuild

The proposal was merged 6 hours ago

I think it was initially thought to be ready a few months ago, followed by some normative updates:
https://github.com/microsoft/TypeScript/pull/52582
https://github.com/tc39/proposal-decorators/issues/499

If you want to try output the change in the meantime, you can patch the plugin to pass decoratorVersion to SWC and use plugins: [] to force the plugin to use SWC at build time so that decorators are transformed by SWC and not esbuild

Thank you. I'll give it a try!

Were you able to use ecmascript decorators with vite?

If you want to use TS decorator and auto accessor, you can try unplugin-swc
import { defineConfig } from "vite";
import swc from "unplugin-swc";

export default defineConfig({
  plugins: [
    swc.vite({
      jsc: {
        parser: {
          syntax: "typescript",
          decorators: true,
        },
        transform: {
          decoratorMetadata: true,
          decoratorVersion: "2022-03",
          react: {
            runtime: "automatic",
          },
        },
      },
    }),
  ],
});

@uinz can this be used with vite-plugin-react-swc, or is it intended to be used instead of it?

@uinz can this be used with vite-plugin-react-swc, or is it intended to be used instead of it?

esbuild 0.21.3 has implemented ES decorator, so vite should support it by default.
try lock esbuild version at 0.21.3 (eg pnpm overrides)

esbuild 0.21.3 has implemented the ES decorator, so vite should support it by default.

I am using typescript so I'm not 100% that this is even directly the cause of my issue but isn't https://github.com/vitejs/vite-plugin-react/issues/314#issuecomment-2105728919 relevant for direct vite support?


TS-4622 Use port from SRV response when connecting to origin

-1, this breaks TSHttpTxnServerAddrSet.

FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/388/ for details.

Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/284/ for details.

@jacksontj Maybe the right place to do this is when HttpSM::set_next_state()  handles SM_ACTION_DNS_LOOKUP?

Yea, I'll have to look a bit more. Ideally its as close to that DNS lookup as possible, that way if some plugin wants to overwrite it I've done the change in core before they can (so that we won't be clobbering eachother). Have to look into it this week.

@jpeach HttpTransact::OSDNSLookup seems to be the correct place-- as it is called immediately after the DNS lookup is complete-- and is what sets the port numbers for the destination.

FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/455/ for details.

Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/349/ for details.

FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/458/ for details.

Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/354/ for details.

@jpeach
I did some testing of my own and I can't reproduce any problems with TsHttpTxnServerAddrSet() at all. TSHttpTxnServerAddrSet() is supposed to be called before the DNS lookup. If called then the core bypasses the entire OS_DNS stuff which includes this port setting block in HttpTransact.
I tested calling the API on both the TS_EVENT_HTTP_READ_REQUEST_HDR and TS_EVENT_HTTP_OS_DNS hooks-- with no problem at all.
You mentioned in a previous comment that it was broken in your testing, can you share the code you were using to see it broken?

👍 This looks good to me and I think it will be safe w/ "TsHttpTxnServerAddrSet()".

FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/464/ for details.

Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/360/ for details.

FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/465/ for details.

FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/466/ for details.

Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/361/ for details.

Linux build failed! See https://ci.trafficserver.apache.org/job/Github-Linux/362/ for details.


phraseapp cli client behind proxy

I am not able to use the phraseapp client behind a proxy:
uname -a
Linux ghost 4.4.0-62-generic #83-Ubuntu SMP Wed Jan 18 14:10:15 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux

phraseapp version: 1.4.1

echo $HTTPS_PROXY
http://localhost:3128

socket(PF_INET, SOCK_STREAM, IPPROTO_TCP) = 3
socket(PF_INET6, SOCK_STREAM, IPPROTO_TCP) = 3
setsockopt(3, SOL_IPV6, IPV6_V6ONLY, [1], 4) = 0
bind(3, {sa_family=AF_INET6, sin6_port=htons(0), inet_pton(AF_INET6, "::1", &sin6_addr), sin6_flowinfo=0, sin6_scope_id=0}, 28) = 0
socket(PF_INET6, SOCK_STREAM, IPPROTO_TCP) = 4
setsockopt(4, SOL_IPV6, IPV6_V6ONLY, [0], 4) = 0
bind(4, {sa_family=AF_INET6, sin6_port=htons(0), inet_pton(AF_INET6, "::ffff:<IP_ADDRESS>", &sin6_addr), sin6_flowinfo=0, sin6_scope_id=0}, 28) = 0
socket(PF_INET, SOCK_DGRAM|SOCK_CLOEXEC|SOCK_NONBLOCK, IPPROTO_IP) = 3
setsockopt(3, SOL_SOCKET, SO_BROADCAST, [1], 4) = 0
connect(3, {sa_family=AF_INET, sin_port=htons(53), sin_addr=inet_addr("<IP_ADDRESS>")}, 16) = 0
getsockname(3, {sa_family=AF_INET, sin_port=htons(35781), sin_addr=inet_addr("<IP_ADDRESS>")}, [16]) = 0
getpeername(3, {sa_family=AF_INET, sin_port=htons(53), sin_addr=inet_addr("<IP_ADDRESS>")}, [16]) = 0
getsockopt(3, SOL_SOCKET, SO_ERROR, [110], [4]) = 0
socket(PF_INET, SOCK_STREAM|SOCK_CLOEXEC|SOCK_NONBLOCK, IPPROTO_IP) = 3
setsockopt(3, SOL_SOCKET, SO_BROADCAST, [1], 4) = 0
connect(3, {sa_family=AF_INET, sin_port=htons(443), sin_addr=inet_addr("<IP_ADDRESS>")}, 16) = -1 EINPROGRESS (Operation now in progress)
getsockopt(3, SOL_SOCKET, SO_ERROR, [110], [4]) = 0
ERROR: dial tcp <IP_ADDRESS>:443: getsockopt: connection timed out

It looks like the app is ignoring the proxy and just tries to connect directly to: <IP_ADDRESS>:443

@nexeck we are only using the HTTPS_PROXY env variable if you also provide PHRASEAPP_INSECURE_SKIP_VERIFY=true (see https://github.com/phrase/phraseapp-client/blob/7a3f83980a97c44ad447001a0a0ff1bee344d6bd/client.go#L18-L20). In that case your connection should go through the configured proxy but the server's TLS certificate chain is not verified!. That means you would be vulnerable to a man-in-the-middle attack.

@tobstarr The HTTPS_PROXY env variable is also set:
http_proxy="http://localhost:3128"
HTTP_PROXY="http://localhost:3128"
https_proxy="http://localhost:3128"
HTTPS_PROXY="http://localhost:3128"
ftp_proxy="http://localhost:3128"
FTP_PROXY="http://localhost:3128"

For the Windows client behind the same proxy I have to wait about 40 s each for pulling and pushing. There is an error message, but it works anyway. Maybe that helps for debugging the linux issue?
C:\Users\xxx>phraseapp pull
ERROR: dial tcp <IP_ADDRESS>:443: connectex: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond.
Downloaded de to messages_de.properties
Downloaded en to messages_en.properties
Downloaded nl to messages_nl.properties

C:\Users\xxx>phraseapp push
ERROR: dial tcp <IP_ADDRESS>:443: connectex: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond.
Uploading messages_de.properties... done!
Check upload xxx for information about processing results.
Uploading messages_en.properties... done!
Check upload xxx for information about processing results.
Uploading messages_nl.properties... done!
Check upload xxx for information about processing results.

@nexeck what are you using as a proxy server? will try to setup a proxy locally to debug the issue myself.

@tobstarr locally i am using: squid > 3.5.12-1ubuntu7.3
squid config:
# This file managed by Salt , do not edit by hand!!
# Squid normally listens to port 3128
http_port 3128

# acl port rules

# acl src rules
acl localhost_src src <IP_ADDRESS>/8
acl localhost_src src ::1/128

acl localnet_src src <IP_ADDRESS>/8
acl localnet_src src <IP_ADDRESS>/12
acl localnet_src src <IP_ADDRESS>/16
acl localnet_src src fc00::/7
acl localnet_src src fe80::/10

acl docker_src src <IP_ADDRESS>/12

# acl dst rules
acl localhost_dst dst <IP_ADDRESS>/8
acl localhost_dst dst ::1/128

acl localnet_dst dst <IP_ADDRESS>/8
acl localnet_dst dst <IP_ADDRESS>/12
acl localnet_dst dst <IP_ADDRESS>/16
acl localnet_dst dst fc00::/7
acl localnet_dst dst fe80::/10

# acl dstdomain rules

# http_access rules
http_access allow localhost_src
http_access allow docker_src

# And finally deny all other access to this proxy
http_access deny all

# cache rules
cache deny all

# cache_peer rules

# always_direct rules
always_direct allow all

# never_direct rules

# Leave coredumps in the first cache dir
coredump_dir /var/spool/squid

# hostname
visible_hostname ghost

# Wait x seconds before termination
shutdown_lifetime 5 seconds

# Extra configuration

@nexeck I am sorry to inform you that I failed to reproduce your issue locally. What I did was this:

run squid in a docker container using my local network interface: docker run --net=host --name squid sameersbn/squid
monitor the logs of that container: docker exec squid tail -f /var/log/squid3/access.log

Then I tested the client doing this:
export HTTPS_PROXY="http://localhost:3128"
phraseapp-client formats list -t test

and I could see the requests going through the squid proxy:
1487750778.737    318 ::1 TCP_MISS/200 7302 CONNECT api.phraseapp.com:443 - HIER_DIRECT/<IP_ADDRESS> -

Using the env variables http_proxy, HTTP_PROXY and HTTPS_PROXY also worked. I also did not have to provide the PHRASEAPP_INSECURE_SKIP_VERIFY=true option at all.
 You should see this in the output:
* Connected to localhost (::1) port 3128 (#0)
* Establish HTTP proxy tunnel to phraseapp.com:443

Another thing you could try is listen for traffic using ngrep:
sudo ngrep port 3128 -d lo -q -l

The output should include something like this
T ::1:57646 -> ::1:3128 [AP]
  CONNECT api.phraseapp.com:443 HTTP/1.1..Host: api.phraseapp.com:443..User-Agent: Go-http-client/1.1..

Did you run the client from a directory where there is a .phraseapp.yml file present?

@tobstarr
Thank you for your feedback.
I have tried the following:
curl -v -I https://phraseapp.com

Result:
access.log:<PHONE_NUMBER>.228    395 <IP_ADDRESS> TCP_TUNNEL/200 6507 CONNECT phraseapp.com:443 - FIRSTUP_PARENT/<IP_ADDRESS> -

curl -v -I https://phraseapp.com
* Rebuilt URL to: https://phraseapp.com/
*   Trying <IP_ADDRESS>...
* Connected to localhost (<IP_ADDRESS>) port 3128 (#0)
* Establish HTTP proxy tunnel to phraseapp.com:443
> CONNECT phraseapp.com:443 HTTP/1.1
> Host: phraseapp.com:443
> User-Agent: curl/7.47.0
> Proxy-Connection: Keep-Alive
>
< HTTP/1.1 200 Connection established
HTTP/1.1 200 Connection established
<

* Proxy replied OK to CONNECT request

I am going to try to debug this the next days with another System.

I can reproduce your results on another system.
And i can reproduce you results on another network with the "not working system".
Will try again in the corporate network.

@tobstarr
This is strange.
Given:

System1: with Docker Squid (Like your Example)
System2: with local Squid (Corporate System)

Steps i have done:
System1:

Works with docker squid

System2:

Does not work with local and docker squid (Corporate Network)
Move System2 into private Network, works with local and docker squid
Move System2 back into Corporate Network, works with local squid
Reboot System2, does not work with local or docker squid

Is there anything the Client caches?
Maybe only one request which does not use the HTTPS_PROXY ENV's?
After one Working Request, i can move the system (withouth rebooting) back into the corporate Network, and it will work.
After one reboot, i cannot use phraseapp again.

@nexeck we were actually able to locate the issue (the version check was not going through the proxy) and @theSoenke provided a fix I just merged with PR https://github.com/phrase/phraseapp-client/pull/88
This will go into the next release we will probably release in the next days.
If you want to use the feature before you could just build the client yourself from our master branch. If you already have a docker setup running, the quickest way would be to use
docker run -t -i -v $(pwd):/go/bin golang:1.8 sh -c "go get -v github.com/phrase/phraseapp-client"

This will build the client in a docker container and place the final binary in your current directory.

fixed in https://github.com/phrase/phraseapp-client/commit/474e4696080de9cad000c22a6ca2c99ccc04bbfc and thus version 1.4.3


fix: properly traverse methods with synchronize blocks that have no clear exit

This issue appears to come from a difference in understanding of what a synchronized block exit is between traverseMonitorExitsCross and the later multi-exit handling in processMonitorEnter.
In this test case, there are two paths out of the first synchronized block: One through a return-void, and one that is more complex and continues into the method. The return-void path is simple enough that it can be pulled into the synchronized block so this can be decompiled correctly. However, traverseMonitorExitsCross still attempts to find a common cross point between both exits, which fails.
At that point, no single exit is known (the exit local variable in processMonitorEnter is null). In that method, this is not an issue: The fallback handling below recognizes that the return-void path is too simple to be added to the stack as an exit, so the stack looks good. However, the exit local variable is never set, thus null is returned. This leads to the traverse loop that initiated the processing of the block in the first place terminating. The code after the synchronized block is never processed, which leads to "missing block" errors:
20:47:08 WARN  - Code restructure failed: missing block: B:7:0x0007, code lost:
    monitor-enter(r5);
 in method: synchronize.TestSynchronized5.get():void, file: /tmp/jadx-14744901629462858150.dex
20:47:08 WARN  - Code restructure failed: missing block: B:9:0x0009, code lost:
    if (1 == 0) goto L_0x000e;
 in method: synchronize.TestSynchronized5.get():void, file: /tmp/jadx-14744901629462858150.dex
20:47:08 WARN  - Code restructure failed: missing block: B:11:?, code lost:
    java.lang.System.gc();
 in method: synchronize.TestSynchronized5.get():void, file: /tmp/jadx-14744901629462858150.dex
20:47:08 WARN  - Code restructure failed: missing block: B:12:0x000e, code lost:
    monitor-exit(r5);
 in method: synchronize.TestSynchronized5.get():void, file: /tmp/jadx-14744901629462858150.dex
20:47:08 WARN  - Code restructure failed: missing block: B:13:0x000f, code lost:
    return;
 in method: synchronize.TestSynchronized5.get():void, file: /tmp/jadx-14744901629462858150.dex
-----------------------------------------------------------
package synchronize;

public class TestSynchronized5 {
    /* JADX WARNING: Code restructure failed: missing block: B:11:?, code lost:
        java.lang.System.gc();
     */
    /* JADX WARNING: Code restructure failed: missing block: B:12:0x000e, code lost:
        monitor-exit(r5);
     */
    /* JADX WARNING: Code restructure failed: missing block: B:13:0x000f, code lost:
        return;
     */
    /* JADX WARNING: Code restructure failed: missing block: B:7:0x0007, code lost:
        monitor-enter(r5);
     */
    /* JADX WARNING: Code restructure failed: missing block: B:9:0x0009, code lost:
        if (1 == 0) goto L_0x000e;
     */
    public final void get() {
        synchronized (this) {
            if (0 != 0) {
            }
        }
    }
}
-----------------------------------------------------------

Method with problems: synchronize.TestSynchronized5.get():void
 Code restructure failed: missing block: B:7:0x0007, code lost:
    monitor-enter(r5);

Code restructure failed: missing block: B:9:0x0009, code lost:
    if (1 == 0) goto L_0x000e;

Code restructure failed: missing block: B:11:?, code lost:
    java.lang.System.gc();

Code restructure failed: missing block: B:12:0x000e, code lost:
    monitor-exit(r5);

Code restructure failed: missing block: B:13:0x000f, code lost:
    return;

 INLINE_NOT_NEEDED
org.opentest4j.AssertionFailedError: Method with problems: synchronize.TestSynchronized5.get():void
 Code restructure failed: missing block: B:7:0x0007, code lost:
    monitor-enter(r5);

Code restructure failed: missing block: B:9:0x0009, code lost:
    if (1 == 0) goto L_0x000e;

Code restructure failed: missing block: B:11:?, code lost:
    java.lang.System.gc();

Code restructure failed: missing block: B:12:0x000e, code lost:
    monitor-exit(r5);

Code restructure failed: missing block: B:13:0x000f, code lost:
    return;

This fix is very simple: if no single exit is known from traverseMonitorExitsCross, processMonitorEnter now returns one of the non-trivial candidate exits. For the test case, this leads to correct behavior. It is possible that there may be cases where there are even more exit blocks, with more than one of them meeting the "non-trivial" criterium (buildSimplePath(exit).last.successors.isNotEmpty), in which case only one of them would be returned. There is no check for this case, since I believe that this might still decompile correctly in some cases and should lead to downstream errors in the other cases (thoughts?).
This change also appears to have fixed TestSynchronizedInEndlessLoop, though I did not look at that test case in detail.

@yawkat this is nice solution, but as you mention, if several exit candidates appear result can be non-deterministic because of unordered iterations over exits set. Not sure how this possible, maybe replacing if with switch can lead to this.
Anyway, your change is good and I can merge it because we don't know any failing cases right now.


Clarify Milestones/Roadmap

Splitting the definition of ES6 module's syntax/parsing from the loading of said modules is really confusing. I understand that the roadmap is out of date, but what level of functionality does "Milestone 0" on the roadmap represent?
It would be really great if we could get some informed opinions on what an entry for modules would look like in the Kangax table.

I'm going to close this issue as the status appears to be that there is no clear consensus on loading and the wrench that Node threw in to the system.


Update dependencies, fix jshint errors and tests

Thanks, I'll pull this down and check it out later this week, then get it merged in.

Maybe replace __indexOf on http://emberjs.com/api/classes/Ember.Array.html#method_contains

I like that idea. I started updating to ember cli 0.2.5 and removed prototype extensions. I used this branch to compare against to see if we had the same changes. It's pretty similar, I'll change the array contains to ember https://github.com/Semantic-Org/Semantic-UI-Ember/tree/ember-cli-0.2.5

I merged in another branch which had the ember cli 0.2.5 changes.  I think this included all your changes. Closing for now


Save results on reception in case of fatal error

We do not want to lose information in the event of an outage. So, we will save the raw result values into a database for future retrieval if necessary. This will be done with sqlite, to keep with #2 .

This and #2 are tied together- "Every so often", the app should check its database and see if there are callbacks that were recieved but did not get publisher confirms. Gotta love those publisher confirms.


YouTube Brand video compliance

User Story

As a [user role below]:
video platform available on the ibm.com web site

I need to:
have IBM make changes to the ibm.com video implementation

so that I can:
protect the YourTube brand.

Additional information

Youtube Policy #:  III.F.2 (Branding)
Violation:  YouTube logos and icons do not follow the YouTube Branding guidelines.

Acceptance criteria

[ ] poster image/icon is removed

This work is related to Northstar and was created in the wrong repo.  This issue is replaced by Issue #1834 on the Digital Design Board.


Metrics doesn't with large number of layers/files

When metrics are obtained on large database I got the following error:
ERROR page server thread exited with error err=invalid message length

Not so clear how to reproduce and debug it...

 Maybe that will help to pinpoint it, if you can reproduce it.

Sorry, it was my fault: HTTP server was listening different port.
I expected that when I run tests, it is always 15001, but looks like it find first unused and in this case it was 15003


Use /bin/sh instead of /bin/bash when possible

The scripts in this repo are using #!/bin/bash, for some of them it's possible to use #!/bin/sh instead without modifications:
https://github.com/system-transparency/system-transparency/blob/master/operating-system/ubuntu/debos_enable_ssh.sh
https://github.com/system-transparency/system-transparency/blob/master/operating-system/ubuntu/debos_cleanup_some_irreproducible_data.sh
it might worth to change it for some other scripts if they not relaying to much on bash specific operations (see checkbashisms tool)

Since some of the scripts use bashisms and the whole build environment (make) uses bash as shell, we would stick with bash to keep it simple.
But in general you are right, one should rather use sh over bash, if possible.


Broken Test For "MongoDB and Mongoose - Create Many Records with model.create()"

The following code produces a Timeout has occurred message in the freeCodeCamp console, yet no errors are shown on the Glitch console, and the data does get saved to the MongoDB Atlas.
const { Schema } = mongoose;

const personSchema = new Schema({
  name: String,
  age: Number,
  favoriteFoods: [String],
});

const Person = mongoose.model('Person', personSchema);

const createManyPeople = (done) => {
  console.log('Done:', done);
  const arrayOfPeople = [
    { name: 'Meeva', age: 30, favoriteFoods: ['Fettuccine Alfredo', 'Sushi', 'Quiche'] },
    { name: 'Leonardo', age: 44, favoriteFoods: ['Pasta', 'Cheeseburgers', 'French Fries'] },
  ];
  Person.create(arrayOfPeople, (err, data) => {
    if (err) return done[err];
    return done[null, data];
  });
};

Furthermore, the Glitch console reports the following when I have the console log logging done enabled and the freeCodeCamp I've completed this challenge button is pressed:
OPTIONS
POST
Done: [ { name: 'John', age: 24, favoriteFoods: [ 'pizza', 'salad' ] },
  { name: 'Mary', age: 21, favoriteFoods: [ 'onions', 'chicken' ] } ]

So it turns out that there was confusion between the previous lesson, and the current one. In the previous one we had to specifically create a person and pass in the values as an object, but in this lesson we had to utilise the arrayOfPeople argument.
Updating my function to the following solved the issue and passed the test:
const createManyPeople = (arrayOfPeople, done) => {
  Person.create(arrayOfPeople, (err, data) => {
    if (err) return done(err);
    return done(null, data);
  });
};

Leaving this open so that a decision can be made on if there needs to be an update to the wording perhaps?

Hi @Deadmano, could you provide a glitch link? Thanks 😄

Hey @jonathan-grah! While I'm not sure if the link will still be useful, as I had to use another method to pass the test, here it is in any event.

@Deadmano, I agree the wording could be better on this challenge, as it may not be obvious due to the previous challenge asking you to create an object by yourself.


SuperGATConv bug?

I think there might be a typo in the SuperGATConvlayer? I think it should be using the positive supervision edges in the attention calculation, rather than the message passing edges (just like in the calculation of the attention for the negative supervision edges).

Thanks. This is not necessarily a bug, since pos_edge_index is a subset of edge_index, but it's definitely a typo :) Thanks for fixing!

Glad it's helpful!
I thought that for link prediction we tend to want our supervision edges and message passing edges to be disjoint, so we don't end up just memorising the supervision edges? Very happy to be corrected, I am still working on getting my head around a lot of these things!
I appreciate that it doesn't matter for the PR and it's more for my understanding.


create utrans pallet

lgtm

Other than some unused variables that I'm not too concerned with at this point this LGTM as well.

lgtm again


Added Angular logo

Noticed Angular logo was missing, it has been uploaded

Thank you, but we currently do not accept PRs in this area.


Support bot should work in all channels with shortcut, but only some for suggest

Weird bug where it acts like it's running, but then doesn't post the report.


[Close #290] 🐛Fix link 404 using web.archive.org

Link 404 (waiting-for-dev github user changed name or deleted)
https://waiting-for-dev.github.io/blog/2014/05/04/distributable-and-organized-dotfiles-with-homeshick-and-mr/
Fixed link using web.archive.org:
https://web.archive.org/web/20200904205236/https://waiting-for-dev.github.io/blog/2014/05/04/distributable-and-organized-dotfiles-with-homeshick-and-mr/

PR #292 inluce this pr :smile:


[main] Upgrade to latest dependencies

Cron -knative-prow-robot
/cc knative-sandbox/eventing-writers
/assign knative-sandbox/eventing-writers
Produced by: knative-sandbox/knobots/actions/update-deps

closing and letting the bot create a new one. The failures have been fixed in https://github.com/knative-sandbox/eventing-rabbitmq/pull/986
/close


Using Xcode 7 image on Travis CI for testing Swift 2.0

Using Xcode 7 image on Travis CI for testing Swift 2.0.

And fixes some pod lib lint errors

I think pod lib lint part of Travis CI fails because of CocoaPods/CocoaPods#4103


Fixes for #image, #background, #linebyline

I've grouped these together because they are all in calico.js and they are all boolean manipulation mistakes.
#image & #background have a bad check: !typeof property === "string" is not equivalent to typeof property !== "string". When property is undefined, it's wrong. It causes a bug when using #background without a file name to clear the background (it doesn't work).
#linebyline doesn't work well as reported in #18

Closes #18


Changed style

The overflow bars catch the eye a lot so i made them show up only when needed, i also added a bit of opacity so that you can see below the overlay, the opacity could be reduced further
Previous:

After:

What's the reason for closing? Do I reopen on main branch?

hmmm, I didn't close it. Don't know why it's closed 🤔. Let's reopen it.

There're some conflicting files now due to a big PR merge

There're some conflicting files now due to a big PR merge, could you rebase and resolve the conflicting?

i'm gonna close this and remake on the main branch


Add user facing docs for the MergeGateways feature

Description:

Describe the issue.

Add user facing docs for the merge gateways feature introduced in https://github.com/envoyproxy/gateway/pull/1938
[optional Relevant Links:]

Any extra documentation required to understand the issue.

@shawnh2 would you mind if I take over on this doc, since I'm working on multiple gc documentation?

@shawnh2 would you mind if I take over on this doc, since I'm working on multiple gc documentation?

sure, go ahead.


Markdown: Added support for code blocks

This PR adds support for markdown backtick code blocks.
~The new code is intentionally written so that we can easily write a plugin which highlights the code block with the given language.~
~I actually intended that the language does that itself, but that turned out to be really difficult and it lacks certain features, so a plugin it is then.~
It now also supports syntax highlighting!
The highlighting is done in two steps:

Add an alias language-**** containing the given language to the code-block token.
This happens in the after-tokenize hook.
Highlight the code with the wrap hook.

This is to get around the encoding (util.encode) of tokens in Prism.highlight.
By using this procedure we get the correct execution of the before-tokenize, after-tokenize, and wrap hook for all included languages.
Btw: This implementation would have benefitted from #1524.
Example

How I use this for Objective-C？ What I should write after "```"?

@ripperhe
Use objectivec after the first tripple backtick.
The language names are the same as you would use after language- in code or pre tags.

But it not works for me. When I use it for ruby or bash is OK,  only use if for Objective-C is not available.
I have add this to index.html
<script src="//unpkg.com/prismjs/components/prism-objectivec.min.js"></script>

But it not works for me . This is the final result.
https://ripperhe.com/ZYDebugo/#/Guide/quick-login
This is GitHub link
https://github.com/ripperhe/ZYDebugo/blob/master/docs/Guide/quick-login.md
I had add  objectivec.

@ripperhe That's because you are using<EMAIL_ADDRESS>which does not include this PR.

@RunDevelopment So, how can I get the latest prism code for Objective-C? What should I write in index.html? Please tell the solution, thank you!  🙏

@ripperhe
This is an open pull request as of right now, which means that until properly reviewed by one of the maintainers, it is not even clear if this PR is going to be included into Prism's code base.
It is also very likely that there will be changes made to this PR during the review process.
I highly suggest you wait until this PR is reviewed and (hopefully) included in the latest release (which might take a few weeks).
If you really need this feature for your website right now, you can do the following:

Download this branch of my fork.
Include the downloaded files into the JS folder of your website.
Change all references to prism-markdown.min.js from https://unpkg.com/prismjs/components/prism-markdown.min.js to path_to_js_folder/prism/components/prism-markdown.min.js.

@RunDevelopment OK, I see. Thank you very much. 🙏

Looks like there are some conflicts here to resolve.

Thought for the future: can we integrate w/ the autoloader so you can write Markdown & it'll autoload the languages you need?

write Markdown & it'll autoload the languages you need

I also thought about but for that would we need the Autoloader itself to expose the API and find a clever way to highlight the code asynchronously after the markdown pass.


xen: Wait for console backend to process data

Left-over from development. Fixes #489.
@talex5 Any objections? This doesn't seem any less performant than what Mini-OS was doing, and just does exactly what the XTF code does. It fixes the test unikernel for me, though I can see in real-time that it's pausing for console writes.

Sounds good. Xen rate-limits the console quite a bit, so pauses are expected and fine (if people want high performance verbose logging, they'll have to send it elsewhere, but I like the default of not losing stuff).
Thanks!


You should not be passing off a livery I made as completely your own without credit.


[QUESTION] how to define request body for telegram webhook handler?

First check

[x] I used the GitHub search to find a similar issue and didn't find it.
[x] I searched the FastAPI documentation, with the integrated search.
[x] I already searched in Google "How to X in FastAPI" and didn't find any information.

Description
I'm trying to write handler for telegram webhook.
Telegram will send update object whenever user sends message to my bot, and i need to process it inside my route handler.
The problem is, the telegram update object is rather large, and has nested object of different types.
How can i easily define pydantic model to declare the update object schema?
Or, is there a better way to handle this?

i solve this issue by using type definition from pygramtic
https://github.com/devtud/pygramtic

Thanks for reporting back and closing the issue @pirey :+1:


Move to Most Recent Alpaka Version + Newest Caching Allocator

Moves to gcc11 and CMSSW_13_0_0_pre4 (same as current CMSSW integration) in order to upgrade to the most recent version of Alpaka used by CMSSW. Also gets rid of our temporary hyperbolic functions and replaces them with Alpaka's which were introduced into Alpaka recently.

Comparison plots: Here
This PR: Here
Current Master: Here
Given that Philip is probably busy, I'll leave it to them to open a PR later on if this configuration doesn't work on their machine.

Hi Gavin, sorry for coming to the PR late. I am wondering about is this enough for us to have setup.sh for both UCSD machine and Cornell machine? Previously we had setup_ucsd.sh and setup_lnx7188.sh 2 versions. In alpaka do we need to have separate setup files also?

Hi Gavin, sorry for the late review and thank you for the efforts! I checked the external LST package and it runs smoothly. However, I met an error when compiling the LST set up as CMSSW external.
When I did scram b -j 12, after the cms-checkdeps in README, it says:
/home/users/yagu/TrackLooper_Ntuple/test_PR314/workingFolder/CMSSW_13_0_0_pre4/src/RecoTracker/LST/plugins/alpaka/LSTProducer.cc:46:43: error: cannot bind non-const lvalue reference of type 'CUstream_st*&' to an rvalue of type 'CUstream_st*'
46 |       lst_.run(ctx.queue().getNativeHandle(),
I'm not sure if the error comes with issues in this PR, but it would be nice if you have any ideas.

@YonsiG Just updated the README as you suggested. The CMSSW integration steps should work now.

Thanks Gavin, I tested the codes on external packages, and test the CMSSW integration with cmsRun. Everything works smoothly on my side. Thanks for contribution and PR merged!


Fix crawler implementation

Coverage increased (+0.0%) to 36.39% when pulling 56dcca0108613c5b80b8d8dc50df7c8e9bf84f2e on AlexMathew:scrapple into c04b1ec96017e0ce45e81b45122b54626fbb6055 on scrappleapp:master.


Define how import 'dmail/module' will behave once for all

Freezing this issue which is too ambitious and may not be implemented in this project.


[WIP] Replace mock.patch with assertLogs

Replaced mock.patch with assertLogs as asked in issue #15331.
Currently modified only at 3 places in GoogleAuthBackendTest class
in test_auth_backends.py file.
Work in progress still need to replace mock.patch with assertLogs in
all the tests testing log output.
tested using ./tools/test-backend and circleCI

LGTM

Looks good to me too. I think you can continue to work on replacing mock.patch for loggers in other places too.

@chdinesh1089 @showell Okay, Thanks.

@chdinesh1089 can you provide feedback on the recent commits. I am not doing any change to the function we are testing and testing whatever logs are being generated, unlike what you did in commit https://github.com/zulip/zulip/commit/d30f11888a009dea59711d24696e140d905488c6. You created some logger there in backends.py. I hope I am doing what is required.

Replace root logger with zerver.lib.rate_limiter logger  which got removed
in last commit in class RateLimitTests in file zerver/tests/test_external.py
issue #15331

To fix anything of a previous commit introduced in this PR, use git commit --amend. Also, amend to a previous commit if you think the new code you added should belong to the previous commit.
If you haven't seen this, we have a very well written git guide in the docs. This could be very helpful to fix commits if you didn't read it yet. https://zulip.readthedocs.io/en/latest/git/fixing-commits.html#fixing-the-last-commit

@thedeveloperr FYI -- you may want to read this as I saw you were looking at similar code.

@palashcode check out the Zulip commit message guidelines for more details: https://zulip.readthedocs.io/en/latest/contributing/version-control.html#commit-messages
You'll want to rebase your commit series to be readable/reviewable.

@palashcode check out the Zulip commit message guidelines for more details: https://zulip.readthedocs.io/en/latest/contributing/version-control.html#commit-messages
You'll want to rebase your commit series to be readable/reviewable.

I think I am following the guidelines also doing rebase before pushing. If you found any mistake, please let me know.

@palashcode better commits can be
Where you just replaced mock.patch with assertLogs in a single file, I think we can write a commit message like, for eg. you refactored test_auth_backends.
test_auth_backends: Refactor mock.patch to assertLogs

Also I suggest to squash all refactor commits for a single file in a single commit (note: only refactor of this kind and not any logger change commits) into a single commit.
For commits where you have changed logger. A single line commit should be enough and code is clean enough in these situations for not mentioning why tests are need to be changed in description. Also I think you should mention issue in the last commit of your PR like format Fixes: #<issue_number> and not in each commit.
email_mirror: Change logger to zerver.lib.email_mirror from root logger.

You haves used tests: in heading indicating it's primarily related to test but in logger change case it's not

Thanks for working on this @palashcode!  I merged one commit as 8393f64120e033b5509c1361de57e2de27ea90cc; see my comments above for how to get the next batch ready to integrate.

Sorry for the delayed review, and thanks for doing this!  I merged much of this branch as the series ending with 2632317b066046b0e66ba4b47dee863822d86c37.  A few notes:

The test_auth_backends changes deserved an explicit mention of the explicit token change in 04f08f45e7375a773ca778a9afd0b528a32f6a50; I took care of adding that.
I didn't merge the ~6 commits that touch soft deactivation, because they don't pass individually.  A correct branch should have every commit pass tests; so rather than doing one commit per file affected by the change in the logging for soft_deactivation, you should make a commit that changes the logger used there and updates all tests accordingly.

Are you up for rebasing those commits to achieve that?
Check out the Zulip commit message guidelines for more details: https://zulip.readthedocs.io/en/latest/contributing/version-control.html#commit-messages

@timabbott No problem. I also got busy. I will work on this in a few days.

Merged as the series ending with 3242fc7388ab6cf358504fa13f3a7a38518fb1de after fixing a typo.  Thanks for doing this @palashcode!

Be encouraged to submit another PR doing the next batch of assertLogs changes! :)

@timabbott @palashcode Hi. I would like to collaborate on this issue. I saw your previous PR https://github.com/zulip/zulip/commit/8393f64120e033b5509c1361de57e2de27ea90cc#, here mock.patch was not replaced with assertlog as mentioned in the issue head. Can you please explain @timabbott ?

@shubham00jain we should replace mock.patch('logging...) lines with assertLogs as a better pattern; the commit you referenced removed such a mock.patch where the lines wasn't logged -- that's the correct change in such a case (and a demonstration of the benefits of the new system -- we verify the line was actually logged in a more consistent fashion and thus can detect bugs in the tests or code like this).

@timabbott Got it. How to know in which files these changes are done and where they are missing. Can you link me to a file where some changes are needed?

@shubham00jain This will help you know some of the files that have mocks to be replaced. :)
$ git grep -n mock.patch\([\'\"]logging
Seeing Tim's comment here, I believe $ git grep -n mock.patch | grep log  will list all of them but will a add a bit of noise.


Can't install using npm

Describe the bug
Can't install it using npm (as meant to). Getting error:
sudo npm install -g @microsoft/inshellisense
(node:25632) ExperimentalWarning: CommonJS module /usr/lib/node_modules/npm/node_modules/debug/src/node.js is loading ES Module /usr/lib/node_modules/npm/node_modules/supports-color/index.js using require().
Support for loading ES Module in require() is an experimental feature and might change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
npm error code ETARGET
npm error notarget No matching version found for @microsoft/inshellisense@*.
npm error notarget In most cases you or one of your dependencies are requesting
npm error notarget a package version that doesn't exist.

To Reproduce
Steps to reproduce the behavior:

try to install it using npm:
sudo npm install -g @microsoft/inshellisense
See error

Expected behavior
installation complete
Environment

OS: Arch Linux
Output of is --version:
Nodejs Version: 23.1.0
Shell: zsh
Shell Version: 5.9

Additional context

Same result on macOS 15.2 (24C101)

downgrade to Node.js 20.X

Only LTS versions are supported, I just added support for 22