Style leak with dynamic loading

Description
Custom element style which is defined outside of template is leaked into other elements while its module is being dynamically loaded. This fact sometimes invokes undesired FOUC.
Live Demo
http://plnkr.co/edit/kK4ex3OkNjeCuiKUDYcG?p=preview
Steps to Reproduce

Click the style-out-template link
Click the Reload button
Go back to 1

Expected Results
Nothing happens.
Actual Results
This is Home background color sometimes turns yellow.
Browsers Affected

[x] Chrome
[x] Firefox
[ ] Edge
[x] Safari 9
[ ] Safari 8
[ ] IE 11

Versions

Polymer: v1.4.0
webcomponents: v0.7.22

This is a mis-feature of HTML Imports to apply <style> elements to the main page if they are not wrapped in <template>.

@azakus Thanks for replying. I found many custom elements whose styles are not wrapped in <template>, such as iron-icon, iron-dropdown, and so on. Is the only thing we can do is to fix those elements? Or any workaround?
By the way, this issue did not occur on shadowDOM. I think that is because document styles which are inserted do not penetrate into custom elements there.

Summarizing the facts I found,
In case x-foo, never causes style leak.
<dom-module id="x-foo">
  <template>
    <style>
      .message:after {
        content: ' style leak';
        color: red;
      }
    </style>
  </template>
  <script>
    Polymer({
      is: 'x-foo'
    });
  </script>
</dom-module>

In case x-bar, always causes style leak on loading.
<dom-module id="x-bar">
  <style>
    .message:after {
      content: ' style leak';
      color: red;
    }
  </style>
  <!-- without template -->
  <script>
    Polymer({
      is: 'x-bar'
    });
  </script>
</dom-module>

In case x-bar, lazy loading or normal loading with lazyRegister causes style leak. I don't know why, but sometimes doesn't without vulcanizing.
<dom-module id="x-bar">
  <style>
    .message:after {
      content: ' style leak';
      color: red;
    }
  </style>
  <template></template>
  <script>
    Polymer({
      is: 'x-bar'
    });
  </script>
</dom-module>

Many elements of this kind exist in iron-elements and paper-elements. So I think we should rewrite them as x-foo pattern, If this is a platform issue and there is no way to do in polymer.

Possible style leaks in PolymerElements.
warn:    bower_components/iron-a11y-announcer/iron-a11y-announcer.html:48:3
    Style tag is not in template
warn:    bower_components/iron-autogrow-textarea/iron-autogrow-textarea.html:42:3
    Style tag is not in template
warn:    bower_components/iron-collapse/iron-collapse.html:55:3
    Style tag is not in template
warn:    bower_components/iron-dropdown/iron-dropdown.html:47:3
    Style tag is not in template
warn:    bower_components/iron-icon/iron-icon.html:86:3
    Style tag is not in template
warn:    bower_components/neon-animation/neon-animated-pages.html:30:3
    Style tag is not in template
warn:    bower_components/neon-animation/neon-animatable.html:30:3
    Style tag is not in template
warn:    bower_components/paper-dialog-scrollable/paper-dialog-scrollable.html:74:3
    Style tag is not in template
warn:    bower_components/paper-scroll-header-panel/paper-scroll-header-panel.html:87:3
    Style tag is not in template
warn:    bower_components/iron-overlay-behavior/iron-overlay-backdrop.html:31:3
    Style tag is not in template

@naoak Thank you for all the PR's!  Yes moving the <style> into the templates is the correct way to solve the issue.
Early in Polymer 1.0 we had support for <style> outside of the template, and in that case Polymer either a.) moves the style into the template in native shadow DOM or b.) rewrites the selectors to be scoped to and not leak in shady DOM.  This all happens prior to the first paint when all imports are loaded synchronously.  However, when imports are async/demand-loaded, the browser can paint between when the <style> outside the template is parsed and when it is re-written for shady DOM, hence the FOUC.
It's for this reason (among others) that we now recommend <style> be placed inside the template in the docs:

Note: Prior to Polymer 1.1, the recommendation was to place <style> tags inside the <dom-module> for an element (but outside the <template>). This is still supported, but is no longer recommended.

Awesome that you took the time to fix up elements that are lagging behind the recommended practice.

@kevinpschaaf Thank you for the detailed explanation! I've seen the note before, nevertheless I was stupidly taking it as a kind of coding style. Now I've fully understood. Thanks!

Closed based on explanation.


Option to Forward to 'live' endpoint if no matches for mock response

There are options to either "Forward" a request to a backing endpoint in SOAP/REST or "Mock" the response back to caller.
Can there be another option to "Forward if no mock matches"?
E.g. I use XPath to match incoming request and return back particular mock responses.
There's a "Default response" option now but this is just to return another mock response.

An example modification for your consideration:
https://github.com/castlemock/castlemock/compare/v1.51...giddyhut:1.51-additives

Hi,
any update on implementing this?

We are looking for this feature. Any update on this ?

We are looking for this feature. Any update on this ?

We are looking for this feature too

We are looking for this feature. Any update on this?

We are looking for this feature too


Error when visualizing the workflow dag

Snakemake version

The error occurs in v8.0.1, and I've verified that it doesn't occur in v7.32.4
Describe the bug

Error when visualizing the workflow dag.
Logs

Traceback (most recent call last):
  File "/home/venv/lib/python3.11/site-packages/snakemake/cli.py", line 1934, in args_to_api
    dag_api.printdag()
  File "/home/venv/lib/python3.11/site-packages/snakemake/api.py", line 602, in printdag
    self.workflow_api._workflow.printdag()
  File "/homevenv/lib/python3.11/site-packages/snakemake/workflow.py", line 879, in printdag
    ignore_incomplete=self.execution_settings.ignore_incomplete,
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'ignore_incomplete'

Minimal example

Create  an Snakefile like the example below:

rule test_rule:
    output:
        "test.txt"
    shell:
        "touch test.txt"

As described in the documentation, run snakemake --dag | dot | displayor snakemake --dag | dot -Tpdf > dag.pdf

Additional context

Python 3.11.6

I get this error too using 8.0.1. Very simple workflow

Same with 8.1.0, identical workflow

Same issue #2577

Hi dear all,
Same in 8.0.0 to 8.2.0. I need to revert to 7.xxx
Thank for your help, have a nice day,
Best,
Nicolas

Any solutions?

Similar error #2637

Solved in v8.4.0

Solved in v8.4.0


Incorrect results of GPU-based BFS algorithm on graph500-26 dataset

Do you have questions or need support? Please describe.
I use the GPU program run_cuda_app of libgrape-lite to run the data of graph500--26, the command is ：
” ./run_cuda_app --application=bfs --lb=cm --bfs_source 62455266 --vfile ../dataset/graph500zst/graph500-26/graph500-26.v --efile ../dataset/graph500zst/graph500-26/graph500-26.e --out_prefix ./output_bfs-26“
and the results （bfs-output）are as follows. The results are very strange. Is this normal?

Additional context
Add any other context about the question here.

Hi @lilux618, Thanks for your report, It seems graph500-26 has only 32,804,978 vertices in this dataset (if you download it from https://ldbcouncil.org/benchmarks/graphalytics/), I guess the bfs_source 62455266 is out-of-range.  this is weird for a SCALE=26 Kronecker graph, I will check the dataset and reproduce the result as soon as possible.

Hi @lilux618, I have tested the graph500-26 dataset (download it from https://ldbcouncil.org/benchmarks/graphalytics/) in a V100 GPU server. I can not reproduce the bug with your command  and the result is like
> head -n15 ./result_frag_0
0 4
1 4
2 4
5 4
6 4
7 3
9 4
10 4
12 4
17 3
18 4
19 4
26 3
29 4
30 4

I recommend you update the code to the latest version since recent PRs(#114 #117) introduce massive changes in GPU flow, This bug may have been fixed in these PRs.

Thank you! I will test it. I have another two questions:

How to verify the results of BFS application?  In graph500 reference code, the results can be verified by Algorithm validate.
How can I get a score such as TEPS used in graph500 benchmark according to the output in libgrape-lite? I run libgrape-lite with datatsets graph500-26, and the output is as follow:
, it seems the TEPS is as high as 333GTEPS, which is not
reasonable. Could you please show the results you have run?

How to verify the results of BFS application? In graph500 reference code, the results can be verified by Algorithm validate.

If you download the dataset from https://ldbcouncil.org/benchmarks/graphalytics/, you will see the correct result (graph500-26-BFS) provided by the LDBC benchmark. To validate the result, you can run md5sum result_frag_0 graph500-26-BFS. The source vertex of the BFS algorithm used to produce the graph500-26-BFS is in graph500-26.properties

How can I get a score such as TEPS used in graph500 benchmark according to the output in libgrape-lite?

TEPS is a metric for graph traversal algorithms like BFS, but it is not appropriate for other algorithms like PR, thus libgrape-lite reports the runtime of algorithms instead of TEPS. To get the TEPS, you can compute edge_num/runtime.  If the result of libgrape-lite passes the validation, you may get a reasonable TEPS.
Hope this information may help you reproduce the performance.


Assistance needed for running model

Hello!  I'm trying to do a test run of the pre-trained MAT model.  I've run SMILES through the DataLoader, which returns the following nine variables:

adj
afm
bft
orderAtt
aromAtt
conjAtt
ringAtt
distances
label

The model itself, as instantiated in load_weights.ipynb, is class GraphTransformer which needs these arguments:

src
src_mask
adj_matrix
distances_matrix
edges_att

Is there example code that shows how to go from the output of the DataLoader into the transformer?

Hi!
We are working on improving and polishing the code for creating the molecule datasets.
Right after that we will do an example of how to use our model.
It will take us a few days.

We made a clearer example of how to use our code in EXAMPLE.ipynb notebook. In this notebook you can see how to run our code up to the training loop.
Moreover, we cleaned the code responsible for features generation so it is now clear and easy to follow.

@genec1 does this solve your issue?

Looks good! I will try it out in a few days and report back. Appreciate the quick res!

Closing for now. But please reach out if you have any questions!

Thanks, kudkudak.  The updated EXAMPLE.ipyb is much clearer.  I'm still missing something, though, as I'm not getting any convergence with training.  Here is my simple attempt at training:
model.cuda()
loss_fn = nn.MSELoss()
device = torch.device("cuda")

train_losses = []
model.train()

for epoch in range(0, 50):
    for batch in data_loader:
        model.zero_grad()
        adjacency_matrix, node_features, distance_matrix, y = batch
        batch_mask = torch.sum(torch.abs(node_features), dim=-1) != 0
        output = model(node_features, batch_mask, adjacency_matrix, distance_matrix, None)
        loss = loss_fn(torch.flatten(output), torch.flatten(y.to(device)))
        train_losses.append( loss.item() )
        loss.backward()
#        print(".", end="", flush=True)
#    print(epoch)

#print("*")

plt.figure(figsize=(10,5))
plt.plot(train_losses)

I don't see any optimizer in your code snippet, this might be the issue.

I added an optimizer and a scheduler and am seeing a decrease in loss now.  Thanks for pointing out my oversight!
Here is the log10(loss) over batch without any hyperparameter optimization:

Closing for now, please reopen if you have any other questions.


Educational JupyterHub considerations for notebook v7 switch

Very excited about the upcoming notebook v7! With help from @jtpio, we (Berkeley) already moved a 1500 beginner data8 class to retrolab (https://github.com/berkeley-dsep-infra/datahub/issues/2422) and it has gone super well!
One of the most important considerations from instructors when we were pitching them the switch is that there was always an option to switch back to the classic notebook whenever they encounter issues. This actually led me to working on https://github.com/jupyterlab/retrolab/pull/158, and getting that in before the semester started was very important in convincing instructors to switch. The pitch was - we are changing the default, but the older one is still available. I think everyone enjoyed retrolab, but it definitely took some time to move.
The other important aspect here is that a single JupyterHub often serves many different classes, 20-30, and they often have different UI needs. In our primary hub, we offer classic notebook, jupyterlab, RStudio and retrolab. The nbgitpuller link generator is used by instructors to pick which UI they want their students to launch into. All UIs are fairly heavily in use, and we've been slowly moving people away from classic notebook to jupyterlab or retrolab.
What I'd love to do with the notebook v7 transition is:

Offer the new UI as default!
Allow people to switch back to jupyterlab or classic UI (offered via nbclassic) if needed
Do not break existing nbgitpuller URLs, as they already pick a UI they want to be sent to. These URLs are in course websites, emails sent out to students, and some on bit.ly links printed on textbooks. https://www.w3.org/Provider/Style/URI.
Switch nbgitpuller.link to point to the new interface as well by default.

As a JupyterHub admin, I expect to have to put in a bunch of work to make this happen - notebook v7 is after all a big breaking change!
Here's what I'd love for how this works.

New endpoints being served by notebook v7 have a /v7/ (or similar?) URL prefix. This is exactly what we do with retrolab now, with the /retro/ prefix.
By default, with just the notebook package installed, URLs without a prefix will just redirect to /v7/. So /tree/ will redirect to /v7/tree/, so if you just have the notebook package installed, all existing links will just take you to the new UI.
However, allow the option to continue using nbclassic interface via the nbclassic package, provided under a /v6/ URL prefix. This will not take over / by default, but allow code to switch to this if it needs to. I think some work needs to be done in the nbclassic package for it to actually ship all the JS, instead of just shimming to notebook package as it does now.
Provide a traitlet or other option that lets admins control what / actually redirects to - /v6/ or /v7/.

This has a few advantages:

Users don't lose choice, but we still change the default.
This doesn't commit the notebook team to long term maintenance of classic UI, but does require a short term work in moving stuff over to the nbclassic package.
The default experience users get is still the new and maintained interface
URL versioning in general IMO is a good thing, and if necessary lets us evolve the notebook package in the future.
JupyterHub admins responsible for educational hubs everywhere in the world will thank you with all their hearts.

This is an exciting transition, and I'm very grateful for all the folks who have put in a lot of emotional and technical work into making this happen. Feels like we're on the home stretch, and this will hopefully help make the transition easier for everyone.
Thanks a lot to @Zsailer and @jtpio for conversations around this.

I'm not convinced that this is the responsibility of the frontend to define the prefix of the tool. The versioning as suggested here is actually not proper as versioning is about server API not the frontend (although I would also love the server API to get versioned :wink:). And in this particular case the server is the same and the endpoints won't change.
However, as mentioned by @williamstein in the notebook meeting, using the base URL to distinguish the frontends and documenting how to use that approach (if it is possible) sounds like a good way forward and JupyterHub is a proxy after all; routing is what it does.
The question is probably more should nb v6 and v7 be installed in the same environment. The current answer is no and we should consider providing both similar to providing RStudio next to JupyterLab.

Thanks @yuvipanda for raising this and the detailed write-up :+1: And for promoting RetroLab / Notebook v7 to be adopted for Data 8, this is really exciting :tada:
As mentioned above, prefixing the frontend endpoints with /v7 might feel awkward. In the Notebook weekly meeting yesterday someone in the chat mentioned that URLs are user interfaces. The idea with the v6 to v7 transition is to keep the same set of endpoints without redirect. Users are already used to going copy pasting URLs to notebooks from the browser URL / search bar and it would be surprising if a new /v7 pops up.

Do not break existing nbgitpuller URLs, as they already pick a UI they want to be sent to. These URLs are in course websites, emails sent out to students, and some on bit.ly links printed on textbooks. https://www.w3.org/Provider/Style/URI.

The URLs will not break because Notebook v7 is taking the same endpoints as Notebook v6. The nbgitpuller links will just redirect to the new interface (via /tree, /notebook, /edit...).
We also need to clarify what the proposal of having v6 and v7 cohabiting means:

are we talking about having the full Notebook v6, including the Classic Notebook Server, running side-by-side Notebook v7 (Notebook v7 runs on Jupyter Server)?
or is it just the Notebook v6 front-end that would be served next to the Notebook v7 frontend?

Because nbclassic runs on Jupyter Server and not the Classic Notebook Server. If it's only about the v6 frontend, then probably this could work if the static assets are moved to nbclassic and served behind /v6/ or /classic/ or /nbclassic/.

This doesn't commit the notebook team to long term maintenance of classic UI, but does require a short term work in moving stuff over to the nbclassic package.

Right, but continuing to provide the classic v6 UI could give the wrong message that we are still maintaining it, which hasn't been the case for many years since the original plan was to even sunset notebook. Maybe there should be some kind of banner at the top of the classic notebook v6 UI to say this is deprecated software, and encourage the switch to v7 since there won't be any new features added to the classic v6 UI.

Thanks for the responses, @fcollonval and @jtpio. I really appreciate all the work you and others are doing on this.
Just to answer one specific question,

We also need to clarify what the proposal of having v6 and v7 cohabiting means

This is only about the v6 frontend, and doesn't require any other API endpoints. I agree with you that this would mostly entail moving the assets to nbclassic (or another package - @Zsailer had some more specific ideas here).
I think there are two primary issues here:

Make it possible for users to switch between v7 and v6 user interfaces on the same JupyterHub. This requires both interfaces are available side-by-side. Moving static assets to another package (nbclassic? elsewhere?) and making it available under a prefix (I like /classic) would be one solution to this. jupyter-server will be the only thing running, no classic notebook server endpoints.
Should the new v7 interface use a URL prefix, with the default no-prefix URLs redirecting to this prefixed URL, but hub admins be able to configure what the default no-prefix URL redirects to, and it could be /classic/. I'll think about better ways to express this and explore other options.

(2) seems to be a bit more contentious than (1).

The URLs will not break because Notebook v7 is taking the same endpoints as Notebook v6. The nbgitpuller links will just redirect to the new interface (via /tree, /notebook, /edit...).

Ah, apologies for using an unclear version of 'break'. Instead, let's say they might end up with a different UI than what they selected in nbgitpuller.link:

Note that the option there explicitly says Classic Jupyter Notebook, rather than just Jupyter Notebook.
There are many layers this problem can be solved - including by 'fixing' this in nbgitpuller itself. I'll think about this for another day or two. But it does fundamentally require that both the classic notebook UI and the new notebook UI are available on the same server, under different URLs.

Trying to draw diagram to describe the scenarii - don't hesitate to edit to correct them

Scenario A (current state):

flowchart TD
    JupyterLab --> Server[Jupyter Server]
    RetroLab --> Server
    Notebook[Notebook v6] --> Server

Scenario B (@yuvipanda wish):

flowchart TD
    JupyterLab --> Server[Jupyter Server]
    RetroLab[Notebook v7] --> Server
    Notebook[Notebook v6] --> Server

Scenario C (what I'm supporting):

flowchart TD
    JupyterLab --> Server[Jupyter Server]
    RetroLab[Notebook v7] --> Server
    Notebook[Notebook v6] --> Server2[another Jupyter Server]

One important issue with scenario B is linked to future developments. If we want to break the Jupyter server API, we will either:

break scenario B and force scenario C; so it is better to not support scenario B at all.
publish a server with versioned API that can serve both the new and the old API to support scenario B.

@fcollonval aha, so your fundamental concern is that we don't want to constrain the server endpoints to continue to be compatible with classic notebook UI. That if the classic notebook UI is still talking to the same jupyter-server endpoints as the new UI, there will need to be fixes to the classic notebook UI if something breaks. Is that an accurate summary of the primary concern?
I agree that's definitely not long term sustainable, and not something I want us to do at all.

@fcollonval to expand on scenario C, it'd look more like this
flowchart TD
    JupyterLab --> Server[Jupyter Server]
    RetroLab[Notebook v7] --> Server
    jsp[jupyter-server-proxy] --> Server
    notebookv6[Notebook API Server] --> jsp
    notebookv6UI[Classic Notebook UI] --> notebookv6

The most important difference from your scenario B (which was what I was advocating for!) is that classic notebook will not be talking to the primary jupyter-server, but to a different server process that doesn't receive guarantees of maintenance. Does that sound right?

By invoking jupyter-server-proxy, I think your scenario C may work today with the right configuration - you need to tell the subprocess notebook server about its new prefix, but notebook already works fine on any URL prefix. If this is the right way to go, it's extensible to any combination of versions. Installation might be the hardest part, since the 'classic' server will eventually need to be in its own env to avoid conflicts on jupyter-client/other dependency versions. Might need to be careful about getting auth right (jupyter-server will enforce the hub auth, notebook should only require requests from jupyter-server rather than redoing hub auth or its own token auth). But this should mostly be a matter of getting the right config/env. I'm sure we can make that smoother after we show what is needed to make it work with what we have now.

Me and @ian-r-rose actually did pretty much exactly this in https://github.com/jupyterlab/jupyterlab/pull/5952, for the jupyterlab dev mode setup on binder. The latest released version of jupyterlab + jupyter-server starts up, but then we use jupyter-server-proxy to run another jupyter-server instance from the current master of jupyterlab in dev mode, so new changes can be tested out. It works fairly well, with the primary problem being one of confusion around serverextensions and nbextensions - since they share config, the serverextensions are loaded by both I think. But mostly alright.

We discussed this during the JupyterHub team call today. I think the primary goal here is to make sure that JupyterHub admins are prepared for the notebook v7 release, and know what their options are. We want to avoid frustration on their part, as well as preempt any negativity that might get thrown towards the notebook team. @choldgraf just opened https://github.com/jupyterhub/team-compass/issues/498 to track and discuss what would be needed from a JupyterHub perspective.

Here's a proposal for discussion to achieve a balance of encouraging forward progress while giving people a less-stark transition opportunity.
We can create a new, separate classic-notebook-ui pypi package that provides the Notebook JS. This is where "maintenance" will happen for Notebook JS.
Here is a list of practical steps and outcomes:

The classic-notebook-ui (PyPI) package could be installed in environments with either notebook v6 or v7.
NBClassic and Notebook v6.5.x will both depend on this package for the Javascript source.

NBClassic would need to prefix its endpoints with e.g. /nbclassic to avoid endpoint collision.

The classic notebook UI could be from the classic Notebook API server or the new Jupyter Server in environments with either notebook v6 or v7 installed.
The classic Notebook UI could be served side-by-side with Notebook.v7, via nbclassic.

It has the added advantage that we can transfer issues targeted at the classic Notebook UI from of the notebook repo to the classic-notebook-ui.
To help visualize all the moving parts/packages necessary, here is my attempt at drawing a new technical diagram with all the moving parts.
graph TD
    subgraph Classic Notebook UIs
    nbclassic
    notebook.v6
    end
    subgraph JupyterLab-based Notebook UIs
    notebook.v7
    jupyterlab
    end
    subgraph REST API servers
    jupyter_server
    notebook-api-server
    end
    notebook.v7 --> jupyter_server;
    jupyterlab --> jupyter_server;
    nbclassic --> jupyter_server;
    nbclassic --> classic-notebook-ui;
    notebook.v6 --> classic-notebook-ui;
    notebook.v6 --> notebook-api-server;

(For the sake of clarity, I didn't include notebook_shim here, which a package that shims server-side config/traits.)
In the diagram above, we run the risk that classic-Notebook UI falls behind Jupyter Server development (mentioned by @fcollonval), but that's on the shoulders for classic-notebook-ui maintainers. Jupyter Server doesn't "feel" the responsibility of ensuring the classic Notebook UI works with it.

The downside of this approach is that we'd likely need to create a bunch of mostly empty python submodules in the notebook (v7) package to shim the old Python APIs to jupyter-server.

This would become really painful over time...

Back in the old days of The Big Split, we used import shims (https://github.com/ipython/ipython/pull/8186) to help manage the maintenance of shims as implementations moved between packages.

Thanks a lot @Zsailer for the detailed explanation and diagram and @yuvipanda for highlighting a similar setup for jlab dev on Binder.
I'm :+1: on Zach proposal.

Just want to say thanks everybody for your brainstorming and thoughtful considerations here.
I want to re-iterate one other point, that seems relevant to comments like "this will be painful over time to maintain". I think we are all in agreement here that "simultaneously use notebook v6 and v7 on the same environment" is not the long-term goal. I see this as a mechanism for speeding up the transition of many communities to v7 by reducing the perceived risk of using v7 for these communities, even though we temporarily give ourselves more maintenance burden.
In my opinion, we should consider putting a clear message in the "shim repository / project" that it is not a long-term solution, we make no long-term promises about maintaining it, and consider putting a date where we'll actively stop maintaining the project in the future (with the implication that communities should have migrated to notebook v7 by then).

I like @Zsailer proposal as well! Even when the latest @yuvipanda proposal (the Binder one) is super interesting, I feel it is too complex for the average user/admin and I foresee them getting pretty confused about the underlying model.

This has just been discussed at today classic notebook meeting, and the outcome is summarised on https://hackmd.io/gl6x_SL0S_aYVn0Y0lSBpQ (see section Outcome of the discussion is a consensus on...).

@yuvipanda just checking if you had the opportunity to try the latest versions of JupyterLab 4, NBClassic 1 and Notebook 7 and see if they address the concerns raised in this issue? Thanks!

Looks like this issue can be closed now that Notebook 7 final is released: https://github.com/jupyter/notebook/releases/tag/v7.0.0
There is also a migration guide in the documentation for running the classic notebook UI alongside Notebook 7 via nbclassic: https://jupyter-notebook.readthedocs.io/en/stable/migrating/multiple-interfaces.html
Please open new issues here on the team compass repo or on the notebook repo if there are remaining items to be addressed. Thanks!


ebusd service sets all logs to notice-level

Describe the bug
ebusd logging config doesn't seem to be applied to the invocation of ebusd
Steps To Reproduce
Steps to reproduce the behavior:

Use the following log config for ebusd:

services.ebusd = {
  logs = {
    main = "notice";
    network = "notice";

    bus = "error";
    other = "error";
    update = "error";
  };
};

Start ebusd.service
Observe bus info-level logs coming through (despite the bus = "error" config)

Expected behavior
No bus info-level logs appear in the service log, config is applied.
Additional context
I suspect the final all argument is overriding all previous log configs, going off how all is parsed as lf_COUNT and this appears to then set all log levels.
Notify maintainers
@nathan-gs
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"aarch64-linux"`
 - host os: `Linux 6.1.46, NixOS, 24.05 (Uakari), 24.05pre588267.73de017ef2d1`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.18.1`
 - channels(root): `"nixos"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

Add a :+1: reaction to issues you find important.

@bobrippling I see this more as an issue with the ebusd upstream. Their docs are clear, it should work:

--log=AREAS:LEVEL
Only write log for matching AREAs (main|network|bus|update|other|all) below or equal to LEVEL (error|notice|info|debug) [all:notice].
This is an alternative form to using --logareas/--loglevel and allows to specify an individual level for each area by using the option multiple times. E.g. for having only bus messages in info level and all other in error level, use --log=all:error --log=bus:info.

I do see your issue and I'm wondering if it would be better to leave out the all directive (since we specified all others).

Thanks @nathan-gs, yes I'm thinking the final all directive is overriding all the others, so I guess it is a quirk of the upstream.
I like the idea of leaving it out, or we could have it at the start of the log arguments (just after --scanconfig), which will allow configuration of an all level, with the ability to override it for specific areas, as subsequent arguments. Wdyt?
(although having said that, I guess we always pass the other --log=<area>:<level> areas, so perhaps dropping all is simpler, leaving the nixos config to default each area)

@bobrippling go ahead and make the PR, you can tag me as reviewer! Thx a lot.


fix(uploads): fix buffer that is sent to s3

fix #59

@pselle confirmed with me that this works through an end-to-end test.


Support predicates for file and process hashes

Some monitoring software will provide logs that include hashes of files and processes.
At minimum these should be predicates in the graph.
Beyond that, these may be useful for the node-identifier.

Closing for a more accurate issue.


added my name to guestbook.md

Thank you!

Thank you sir for an awesome course!  I've learned a lot!


Changed background color of "Splash Screen"

Moved the last commit to PR #14 for a clean history. This Pull Request is closed.


Enhancement for App Insights

Label prediction was below confidence level 0.6 for Model:CategoryLabels: 'Mgmt:0.49718484,Client:0.48860794,Service:0.008762382'

This issue is created for the wrong repo.


Annotations

Would it be possible to have annotation support? That would make it a lot easier to write the relationship mapping, you could simply do it in your doctrine entities.

Agreed.
Perhaps introduce a new annotation to determine which columns should be exposed via the API, so that we don't accidentally blurb out sensitive information (like passwords).
For instance @ApiExposable or @ClientExposable.
Example entity:
/**
 * @Entity
 */
class User
{
    /**
     * @Id
     * @Column(type="integer")
     * @GeneratedValue
     * @ApiExposable
     */
    private $id;

    /**
     * @Column(type="string")
     * @ApiExposable
     */
    private $username;

    /**
     * @Column(type="string")
     */
    private $password;

    /**
     * @Column(type="string")
     */
    private $email;
}

(Disclaimer: Passwords should never be in any User table directly, but that's another talk and this is just a thought-up example.)
In the above example, only columns id and username will be exposed when the entity is JSON serialized.

On a related note: The class metadata can be used to automatically find @Id columns. As such:
$meta = $em->getClassMetadata(get_class($entity));
$identifiers = [];
foreach ($meta->getIdentifierFieldNames() as $propertyName) {
    if (property_exists($entity, $propertyName)) {
        $identifiers[] = $propertyName;
    }
}
var_dump($identifiers);

It should just work without annotation, so it would be better with @ApiHide annotation.


adding missing step for additional control plane nodes

There appears to be a missing step instructing the user to apply the kubeadm-config on each of the additional control plane nodes

I signed the CNCF CLA in April, not sure why it is failing the check now.

/lgtm

/cc @kubernetes/sig-cluster-lifecycle-pr-reviews

/cc @fabriziopandini @luxas @neolit123
PTAL

LGTM

@kubernetes/sig-cluster-lifecycle-pr-reviews

/approve


How to put modal window in to separate component?

I have big problems with this.
Can you make simple example?

Sorry for being late :)
Can you give me a bit more detail on the result you want to achieve?
Also, did you already take a look at the example?.

I'm closing the issue, feel free to re-open it if needed.


Verify that "Coșlariu Nou" is listed in the dropdown menu when searched

Description:
"Coșlariu Nou" should appear in the dropdown menu with correct spelling and locality information.
Preconditions:
The website is up and running.

Step 1
Type "Coșlariu Nou" in the search bar.
Expected results:
The dropdown is listing "Coșlariu Nou" as the first location in the dropdown menu.

Step 2
Observe the dropdown menu.
Expected results:
"Coșlariu Nou" is displayed and selectable from the dropdown menu.


Application settings remake

Move mobile app integration settings to connection settings and rename it to app settings
Implement easy settings:

Ask user to enter the url for web ui
Parse it, try to establish socket connection and send "ping"

Fill port input if connection success
Ask user to check url if not connected

Was done somewhere in 1.x.x


Contradictions about inst UKADDH，UKSUBH

Hi，
It seems a contradiction about the descriptions of UKADDH,UKSUBH. Should the result be sign-extended or zero-extended?

UKADDH Rt, Ra, Rb
Add with I16 saturation
Rt = ZE(SAT.U16(Ra.W[0] + Rb.W[0]))

vs

tmp = Rs1.W[0] + Rs2.W[0];
if (tmp > (2^16)-1) {
tmp = (2^16)-1;
OV = 1;
}
Rd = SE(tmp[15:0]);

The short definitions and detailed definitions mismatch can be found also for:
UKADDW
UKSUBW

This issue has been fixed. Could it be closed?


Show more diag info about partition

Splitting #32 into separate PRs

Coverage decreased (-1.0%) to 81.183% when pulling 202a1436f773e025118a411ff11c63bdcc0eb1a5 on techtonik:diaginfo into cb1a85bde81549704e21158d638efc1e74719ec4 on dariusbakunas:master.

Coverage decreased (-0.9%) to 81.203% when pulling fe9f82b7baf07fc1e127f13829817109ef064a47 on techtonik:diaginfo into cb1a85bde81549704e21158d638efc1e74719ec4 on dariusbakunas:master.

Coverage increased (+0.2%) to 82.385% when pulling f7b0b8caab8580e80ccd1c59d1fc03ea9696483a on techtonik:diaginfo into cb1a85bde81549704e21158d638efc1e74719ec4 on dariusbakunas:master.


Files updated for CATS Report<PHONE_NUMBER>149 de-de locale

Files updated for CATS Report<PHONE_NUMBER>149 de-de locale

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: v-bhmakwn sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Exchange-Server-2013/content-conversion-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/create-a-theme-for-outlook-web-app-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/exchange-admin-center-in-exchange-2013-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/exchange-workload-management-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/recipient-filtering-on-edge-transport-servers-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/recipient-resolution-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/review-the-voice-mail-calls-in-your-organization-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/track-messages-with-delivery-reports-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/transport-agents-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/voice-mail-greetings-announcements-menus-and-prompts-exchange-2013-help.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Update dropdown setting type validations

Fix #1

This looks good. Can you increase the 8 on line 3 of LibEditModeOverride.lua to a 9 so that the newer version with the fix will be used and then I'll merge it.

Done. 👍🏻 😸


Wild Card Check Issue.

wild card check doesn't seems to be working with alteration functions. it keeps resolving altered subdomains even if its wildcard domain.

Thanks. I’ll take a look at what happened.

The problem should be fixed now. Of course, there are multiple reasons why the wildcard detection can fail anyway depending on how DNS server respond, etc. Please let me know if it still does not appear to be back to normal. Otherwise, I'll close the issue.


purchaseUpdateListener  for iOS subscription is always called twice

Description
When making purchases or receiving renewal updates through purchaseUpdateListener on iOS, the notification always arrives twice for some reason. They always arrive somewhere around 2.5 seconds after each other. I tried calling finishTransaction right after I receive the purchaseUpdateListener but still nothing, it works the same way.
Any idea what might be the reason for this double notification for the same purchase?
I am using the Storekit 2 in case if that is relevant.
Expected Behavior
purchaseUpdateListener  should have fired only once for the same purcahse
Environment:

react-native-iap: 12.13.0
Platforms: iOS

I am also facing the same issue. Did you get any solution?

No, I also tried with a minimal example and it is still happening. For now I just made sure that the extra call is not causing any issues on frontend or backend at least so everything is handled correctly even if it gets called multiple times but the double call was still bothering me a bit.

How do you make sure that the extra call is not causing any issues? I am experiencing this on Android

Hi @Saikedo , @harrymash2006 ,
Any update on this?
how you handled this issue?

Hi @Karthik-V26 , @FXStreetDeveloper .
Any update on this?
how you handled this issue?


Show '1 instead of1 Tickers` in Wallet tab for NFTs

Part of #2890

Before PR
After PR

Close issue once all PRs listed in https://github.com/AlphaWallet/alpha-wallet-ios/issues/2890#issuecomment-860487761 merge


[d3d8] Return S_FALSE if VCache queries are unsupported

Related to https://github.com/doitsujin/dxvk/pull/4020. While testing the behavior on native platforms, I uncovered the fact that native drivers actually adhered to spec and returned S_FALSE when VCache queries are unsupported.
Additionally, both modern AMD drivers and ATI native drivers of old (on WinXP) zero out the return struct:
Listing VCache query result:
  ~ Response: S_FALSE
  ~ Pattern: 0
  ~ OptMethod: 0
  ~ CacheSize: 0
  ~ MagicNumber: 0

The behavior on Nvidia is correct and we should be inline with what d3d9 returns.
I'm not entirely sure if I've implemented this correctly, but I rather added the D3DDEVINFO_VCACHE struct declaration to our headers than messing about with D3D9Types.h. Let me know if that's a problem.

I've moved the definition of D3DDEVINFO_VCACHE as part of d3d8_include.h, since AFAIU it should be included in d3d8.h (but MinGW doesn't seem to provide it). @AlpyneDreams In case MSVC has it, let me know, and we can gate it behind an ifdef.


After updating to ZF 2.4.2 module throws the exception on try to get service from servicemanager.

After updating to ZF 2.4.2 module throws the exception on try to get service from servicemanager.
$mailService = $this->getServiceLocator()->get('AcMailer\Service\MailService');
Uncaught exception 'Zend\Mail\Exception\InvalidArgumentException' with message 'Email must be a valid email address'
The issue is related to parameter "from' => ''" in config file. New version of zend framework not allow to pass empty From header on module init. If i uncomment this parameter and fill it with something all works fine, but i don't need this default parameter because i set "from" header in runtime.

Thank you! I'll fix it as soon as possible.

I have same problem with ZF 2.3.*

The problem arise when no "from" config exists in $config["mail_options"]["from"].
A quick workaround is to set the from option in mail.global.php file inside config/autoload/
I suppose that Zend change something in Mail clasess and doesn´t accept empty "from" address.

That seems to be the problem. I will try to fix it this weekend, but any
pull request is very welcome ;)
Thank you all for reporting the issue
--
Alejandro Celaya Alastrué
www.alejandrocelaya.com
El 14/5/2015 7:55 p. m., "Alejandro Fiore"<EMAIL_ADDRESS>escribió:

The problem arise when no "from" config exists in
$config["mail_options"]["from"].
A quick workaround is to set the from option in mail.global.php file
inside config/autoload/
I suppose that Zend change something in Mail clasess and doesn´t accept
empty "from" address.
—
Reply to this email directly or view it on GitHub
https://github.com/acelaya/ZF2-AcMailer/issues/94#issuecomment-102117242
.

I already sent you a pull request!
https://github.com/acelaya/ZF2-AcMailer/pull/96
Thanks for sharing your work!

I've seen it, thanks!
--
Alejandro Celaya Alastrué
www.alejandrocelaya.com
El 14/5/2015 8:59 p. m., "Alejandro Fiore"<EMAIL_ADDRESS>escribió:

I already sent you a pull request!
#96 https://github.com/acelaya/ZF2-AcMailer/pull/96
Thanks for sharing your work!
—
Reply to this email directly or view it on GitHub
https://github.com/acelaya/ZF2-AcMailer/issues/94#issuecomment-102136653
.

The pull request won't be merged, since there are some BC breaks in ZF2.4 that cannot be applied in this module without introducing a BC break on itself.
I will push a small version 4.5.1 that will require ZF2.2 or 2.3.
The upcomming version 5 (which is already introducing other BC breaks) will support ZF2.4.
By the moment, keep using the workaround of defining a from addresses at configuration level.

I'm glad to say that finally found a workaround so that I can fix the problems with ZF2.4 without introducing a BC break.
Version 4.5.1 is available now.

¡Gracias Alejandro!
Thanks @acelaya for the fix!


Rule proposal: Prefer memoized callback functions

Consider the following:
type MyComponentProps = {
  onClick?: (event: React.MouseEvent<HTMLDivElement>) => void
};

const MyComponent = (props: MyComponentProps) => {
  return
;
};

If props.onClick changes frequently and/or changes on every parent render, it will cause the child component to re-render. Therefore, one may want to memoized the callback:
const MyComponent = ((props: MyComponentProps) => {
  const handleClick = useCallback(
      ((event: React.MouseEvent<HTMLDivElement>) => {
        props.onClick?.(event);
      }),
      [props.onClick]
  );

  return (
);
});

If props.onClick changes on every parent render, e.g., it is defined inline (onClick={() => doSomething()}) without memoization, handleClick will change on every render as well, mirroring the pitfall of the first example. However, by memoizing handleClick, one has more control over re-renders if props.onClick is stable, i.e., it is not recreated on every parent render.
I propose a new rule that reports when a prop is used directly as a callback function. More generally, such a rule could allow developers to prefer one pattern over the other.
Note: I opened this issue is conjunction with https://github.com/jsx-eslint/eslint-plugin-react/issues/3683.

@oliveryasuna While in general this is correct, for HTML elements that's not actually true - React is smarter than that. It's only functions passed as props to custom elements that need to be memoized.


fix(gossip): Double free in ActiveSet

Fixes #50
Root cause
Multiple contacts with the same pubkey were being passed to the rotate method. This resulted in duplicate items being included in the array, but the hashmap internally prevents duplicates. So the next time rotate is called, it would iterate through the array and attempt to deinit the same hashmap entry twice.
Solution
Duplicates are detected and skipped during the insertion loop by checking for their presence in the hashmap.
Alternate Solution
This could have also been addressed with a simpler approach: Remove the peers field from ActiveSet. This field does not seem necessary, since the same data is already in the hashmap.
Even though it would be simpler code, it is a more significant change in behavior and compatibility. To be safe, I decided not to take this approach.
Let me know if this approach would be better and I can quickly switch to that implementation.

nice
yeah good point you can get rid of the peers field


Removes all usage of block_on, and use a oneshot channel instead.

Calling block_on panics in certain context.
For instance, it panics when it is called in a the context of another
call to block.
Using it in tantivy is unnecessary. We replace it by a thin wrapper
around a oneshot channel that supports both async/sync.

Codecov Report

Merging #1315 (27fe8f4) into main (958b2be) will increase coverage by 0.01%.
The diff coverage is 91.06%.

:exclamation: Current head 27fe8f4 differs from pull request most recent head 10c6386. Consider uploading reports for the commit 10c6386 to get more accurate results

@@            Coverage Diff             @@
##             main    #1315      +/-   ##
==========================================
+ Coverage   94.04%   94.06%   +0.01%
==========================================
  Files         230      231       +1
  Lines       39384    39428      +44
==========================================
+ Hits        37040    37088      +48
+ Misses       2344     2340       -4

Impacted Files
Coverage Δ

src/query/term_query/term_scorer.rs
74.49% <0.00%> (+0.59%)
:arrow_up:

src/indexer/index_writer.rs
96.74% <62.50%> (-0.18%)
:arrow_down:

src/aggregation/mod.rs
97.96% <66.66%> (ø)

src/indexer/segment_updater.rs
95.00% <86.00%> (+0.45%)
:arrow_up:

src/future_result.rs
94.11% <94.11%> (ø)

src/directory/file_watcher.rs
100.00% <100.00%> (ø)

src/directory/tests.rs
99.09% <100.00%> (ø)

src/directory/watch_event_router.rs
95.79% <100.00%> (-0.36%)
:arrow_down:

src/fastfield/mod.rs
92.93% <100.00%> (-0.02%)
:arrow_down:

src/fastfield/multivalued/mod.rs
96.96% <100.00%> (+3.03%)
:arrow_up:

... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 958b2be...10c6386. Read the comment docs.


fix: cjson header issue

- What I did

Fixed atclient CMakeLists.txt file so the cJSON library can be detected by other files. This involves using FetchContent_Declare to fetch the library, instead of using the files in 3rdparty folder.
As a result of the previous changes, 3rdparty folder was removed, as it won't be necessary for now.

- How to verify it
Run any of the currently working examples in examples/desktop/crud.
- Description for the changelog
Closes #180

Thanks for this !


Round 2 - Style

Looks like a mix of ES5 and ES6 between these two chunks of code. Would recommend picking one and being consistent all the way through. So either change line 20 to ES5 or switch line 24 to a const/arrow function.
https://github.com/StephanieEA/savery/blob/master/main.js#L20-L33

Fixed it! 🔨 🔧 :men_wrestling:


Add test to ensure staged publish includes images listed in publish

Add test that verifies - images in - https://github.com/Azure/azure-functions-docker/blob/dev/host/3.0/publish.yml are included in https://github.com/Azure/azure-functions-docker/blob/dev/host/3.0/publish-appservice-stage.yml

cc @CooperLink @balag0 @yojagad @divyagandhisethi

Related issue #493

Tagging PR that fixes this issue : https://github.com/Azure/azure-functions-docker/pull/500
All -appservice images must be accounted for in both pipelines (except for base image) in order for PR+Upgrade to work.


Opensearch snapshot

Change Summary
Overview
This update adds functionality to backup the OpenSearch database each time a set of files is indexed. The OpenSearch version was also updated to version 2.7 and the CDK version was updated to 2.88. CDK version 2.88 was required to deploy OS 2.7 through the CDK.
New Dependencies

requests-aws4auth (used to send authentication through requests)
requests-mock (used to mock requests in unit tests)
freezegun (used to keep file timestamp consistent in unit tests)

New Files

snapshot.py (mostly copied from Libera. Big thanks to Brian M.)

This file includes the code for registering a backup repository (S3 bucket) and taking the OpenSearch snapshot.
I think it would be good to update this file in the future to better fit in with the existing opensearch_utils classes, but this should work for now.

Deleted Files
None
Updated Files

sds_data_manager_stack.py

Updated OpenSearch to 2.7
Added Snapshot Role and policies for Indexer lambda to allow it to take the snapshots
Added a new S3 bucket to store snapshots

indexer.py

Added function to take snapshot at end of lambda

Testing
A new unit test file test_snapshot.py was created, sds_data_manager_stack.py and test_open_search_stack.py were updated. All files are passing all tests.
NOTE: When deploying and testing the snapshots, there are a few extra steps to give proper permissions to OS to take the snapshots.

Log in to your OpenSearch instance dashboard
Back in AWS, go to IAM -> Roles and copy your IndexerServiceLamba role's ARN
In the OpenSearch dashboard menu, go to Security -> Roles and click on the manage_snapshots role.
Go to the Mapped Users tab and click on the Map Users
Paste the ARN that you copied into the backed role text bock and click Map

Now when you upload files to the data bucket, a snapshot should be taken. You can confirm those files were created in the snapshot bucket.

Overall looks good to me. Can you add some documentation somewhere (maybe in indexer.py?) about the manual steps to add the role to opensearch? Is there any way to do that in CDK? I found I could assume roles in CDK, but that might be different than what you need to do here.
If we're going to have manual steps, I'd really prefer at least having them written down somewhere! You could also write a rst doc covering all of that info.

I agree. I'll document this somewhere. I'm hoping this is just temporary for this SIT and we can find a way to do this in the CDK in the future. The documentation only had the manual steps (this is only needed because we are using fine-grain access controls for OpenSearch). I talked to Brian M about this and Libera hasn't tightened permissions for their OpenSearch instance yet, so they haven't had to deal with this. But I'm hoping these manual steps are temporary.


MoE: no longer works with GUIFlash 0.3.1

since GUIFlash 0.3.1 g_guiFlash.animateComponent no longer exists.
It seems that its done in updateComponent now:
def updateComponent(self, alias, props, params=None):
Can you please take a look on it and confirm it?

it was fixed with v7.04...
btw: a bit late :)


Implement verbosity option

Is your feature request related to a problem? Please describe.
It should be possible to configure the software to display logging information or not.
Describe the solution you'd like
Consider adding a verbosity option with short name v and long name verbose.

Quoting my reply on #1194, although I don't really know Java, I think a possible implementation of this proposal would be to wrap logging messages in a if (!quiet) { ... } block:

I was thinking, for example, that this line
https://github.com/MobilityData/gtfs-validator/blob/cec914e802571cb4ee56994dae453a7a593b091e/main/src/main/java/org/mobilitydata/gtfsvalidator/runner/ValidationRunner.java#L150
that outputs how long validation took, could be wrapped in a if (!quiet) { .... } block, thus preventing it from printed when --quiet is specified (I'm not sure how CLI args parsing works in Java, I'm just assuming the quiet param could be parsed as bool and then saved in a quiet variable).

I have no strong opinion on whether quiet or verbose should be used, but I'd like to note that the flag -v is already used as a short for --validation_report_name.


(DOCS) PDB 5.2.13 release notes

This commit adds one new feature release note.

CLA signed by all contributors.


Bug Report: Error when building

Please check for duplicates, similar issues or closed issues with the same problem, as well performing simple troubleshooting steps (such as deleting the export folder if it's an issue with compiling, reinstalling Kade Engine) before submitting an issue.
If you are playing a downloaded version of the game, what operating system are you using?
Windows (x86), Windows (x86_64), Linux, or macOS? Specify below.
What version of the game are you using? Look in the bottom left corner of the main menu.
1.7
Have you identified any steps to reproduce the bug? If so, please describe them below. Use images if possible.
Please describe your issue. Provide extensive detail and images if possible.

what is wrong?

Nvrm i found out this is a duplicate.
https://github.com/KadeDev/Kade-Engine/issues/2403 if someone needs it


Project Watcher

Struct has a cool watcher that will regenerate a project when ever it detects changes or files being added to the project directory.
We should probably do this too

To be honest, I see no value in it! I would prefer to be fully in control of when my project is being regenerated and not polluting my commit with unexpected project regeneration. Plus, Xcake has many small issues or does not provide everything I need, so after regenerating project I usually need to do few adjustments manually before continue working normally. I understand this is an optional feature, but I find it completely unnecessary and just wast of time, you better focus on known issues and more needed features. Plus, when you add file, you usually do it from Xcode, add to a group, and based on the group, Xcode suggests you proper default physical location in file system. Once file created - you have it added under the group where you started "Add new file" process, so there is absolutely no need to regenerate entire project. IMHO, of course.

Thats true and I would imagine most people who use watchers may have their own dedicated thing for triggering it. Also I tend to just manually run xcake make after every change.
So we should probably ignore this for now.

Agree :)


improvements in cmake build

This PR adds minor improvements in the cmake based build. Th largest change is to remove the option BUILD_SHARED_LIBS because it is a cmake default. There is also no need to explicitly quantify add_library() with BUILD_SHARED_LIBS because cmake will automatically build shared or static based on BUILD_SHARED_LIBS.
All in all this PR should not break anything and slightly simplify the CMakeLists.txt. Is this useful and acceptable?

This makes sense to me, modulo forcing POSITION_INDEPENDENT_CODE ON - static library builds shouldn't set this.

The POSITION_INDEPENDENT_CODE ON will not hurt static libs, AFAIK it will just be ignored. But I can remove it if you prefer?

POSITION_INDEPENDENT_CODE ON should not be ignored for static libs - there are valid reasons to use PIC for static libs (which is when a static lib is linked into a shared lib), but it has a small performance penalty so it's the wrong default.
I was trying to find the defaults for BUILD_SHARED_LIBS in CMake documentation and couldn't. I'm starting to lean towards keeping this a project-only setting, since that way all valid and supported options are clearly documented in CMakeLists file.

I'm not an expert in this matter, but the cmake documentation specifies "The POSITION_INDEPENDENT_CODE property determines whether position independent executables or shared libraries will be created", so it is my understanding that it should not have an effect on static libraries (see https://cmake.org/cmake/help/v3.12/prop_tgt/POSITION_INDEPENDENT_CODE.html).
Should I check how to set a default for BUILD_SHARED_LIBS? I recall there was a way to query if a variable is already set or not.


Copy a TensorNetwork without copying the Tensors

I would like a convenient way to copy a TensorNetwork without copying the Tensors associated with nodes. I don't think I can just use deepcopy for that, since it would copy the Tensors too?
This could be useful for algorithms involving finite tensor networks. We could set a network once for e.g. a matrix product state, then create copies before contracting subnetworks for various computations (e.g. compute the norm or energy).

Could you provide a code sample of your ideal workflow?

If your network creation is wrapped in a function, you should just be able to regenerate a TN with whatever tensors you want.

Yeah, that's true. And the (negligible) cost of doing so would be about the same as the copy, I expect.

Never mind :)

I do want to build a TensorNetworkShell class that doesn't have tensors. That would be useful for contraction algorithms.


[WIP] Fix build.gradle and .travis.yml to se coveralls

Changes Unknown when pulling c81421476e72178e99540e0a8de555332805660c on readme_show_coveralls into ** on master**.

Changes Unknown when pulling a1cee662038eab942ee22a041a76a60d2485d2b0 on readme_show_coveralls into ** on master**.

@dmikurube Please take a look when you have time

Thank you! I merge it after rebase.

Merged.


The body content no show

That feature was added to master after v1 was tagged: https://github.com/actions/create-release/commits/master. You need to use master, or wait until v1.0.1 is tagged (and v1 updated accordingly).

cc

think you

That feature was added to master after v1 was tagged: https://github.com/actions/create-release/commits/master. You need to use master, or wait until v1.0.1 is tagged (and v1 updated accordingly).
EDIT
Actually, it seems that v1 does not currently point to v1.0.0 (which it should). It is pointing to a commit without full semver tag.
/cc @ethomson

thank you.


Will flutter suport Js or typescript?

As a ReactNative Developer, I do not want to study Dart.
Will flutter support js/ts language ? It will be more attractive.

Hi @Allenyn, Flutter leverages Dart to allow both JIT compilation for fast debugging/hot reload and AOT compilation to native arm code. This is a fairly unique capability that isn't shared by JavaScript/Typescript, which always require a JavaScript VM to run.
You can find more information on why Flutter chose dart in our FAQ https://flutter.dev/docs/resources/faq#why-did-flutter-choose-to-use-dart and in this article https://hackernoon.com/why-flutter-uses-dart-dd635a054ebf

@jonahwilliams
create a ts-llvm may be a good choice.
for example:
https://github.com/ts-llvm/ts-llvm


Heap allocator has issues with each Node

Almost always, if not always, the MmKernelMalloc function returns an area in use by a node for the allocator.

2dae173 might be good enough for now, at least until there's more arenas that need to be created, and until there's a need for a MmKernelFree().


Opening multiple source-file links is broken on Chromium based browsers

I’m on macOS 12.0.1 (x86_64) and am using this example app.
I have tested this on:

MS Edge 96.0.1054.62 (Official build) (x86_64)
Chromium 85.0.4183.102 (Developer Build) (64-bit)

It does, however, work correctly with Firefox.

I haven't noticed any difference in behavior across browsers; it's possible that something has been altered since the issue was first reported. Additionally, I observed that the source maps configuration in Webpack is incorrect. I've made the following adjustments, and now everything appears to be functioning as expected:


Closes #43 codeowners and #47 contributors

Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.
Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the devel branch until you have checked off each task.

[ ] Place Closes #<insert_issue_number> into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update)
[ ] Code is formatted according to the tidyverse style guide. Run styler::style_file() to style R and Rmd files
[ ] Updated relevant unit tests or have written new unit tests, which should consider realistic data scenarios and edge cases, e.g. empty datasets, errors, boundary cases etc. - See Unit Test Guide
[ ] If you removed/replaced any function and/or function parameters, did you fully follow the deprecation guidance?
[ ] Update to all relevant roxygen headers and examples, including keywords and families. Refer to the categorization of functions to tag appropriate keyword/family.
[ ] Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately
[ ] Address any updates needed for vignettes and/or templates
[ ] Update NEWS.md if the changes pertain to a user-facing function (i.e. it has an @export tag) or documentation aimed at users (rather than developers)
[ ] Build admiral site pkgdown::build_site() and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.
[ ] Address or fix all lintr warnings and errors - lintr::lint_package()
[ ] Run R CMD check locally and address all errors and warnings - devtools::check()
[ ] Link the issue in the Development Section on the right hand side.
[ ] Address all merge conflicts and resolve appropriately
[ ] Pat yourself on the back for a job well done! Much love to your accomplishment!

Hi @Gopi2345 @yangc71 @toni-1991 @RealSlimMahdi,
I found you through the history of the following data programs, can we list you as code owners for them?
Code owners are automatically requested for review when someone opens a pull request that modifies code that they own.
Thanks!
data-raw/ds.R @Gopi2345           (from https://github.com/pharmaverse/admiral.test/blob/main/dev/update_ds.R)
data-raw/lb.R @yangc71     (from https://github.com/pharmaverse/admiral.test/blob/main/dev/update_lb.R)
data-raw/mh.R @yangc71   (from https://github.com/pharmaverse/admiral.test/blob/main/dev/update_mh.R)
data-raw/pc.R @toni-1991 @RealSlimMahdi   (from https://github.com/pharmaverse/admiral.test/blob/main/dev/pc.R)
data-raw/pp.R @toni-1991    (from https://github.com/pharmaverse/admiral.test/blob/main/dev/pp.R)

Hi @Gopi2345 @yangc71 @toni-1991 @RealSlimMahdi, I found you through the history of the following data programs, can we list you as code owners for them? Code owners are automatically requested for review when someone opens a pull request that modifies code that they own. Thanks!
data-raw/ds.R @Gopi2345 (from https://github.com/pharmaverse/admiral.test/blob/main/dev/update_ds.R) data-raw/lb.R @yangc71 (from https://github.com/pharmaverse/admiral.test/blob/main/dev/update_lb.R) data-raw/mh.R @yangc71 (from https://github.com/pharmaverse/admiral.test/blob/main/dev/update_mh.R) data-raw/pc.R @toni-1991 @RealSlimMahdi (from https://github.com/pharmaverse/admiral.test/blob/main/dev/pc.R) data-raw/pp.R @toni-1991 (from https://github.com/pharmaverse/admiral.test/blob/main/dev/pp.R)

I'm fine to be includedin PC and PP

@toni-1991 Thanks a lot!
@manciniedoardo could you please give @toni-1991 access to this repo?


[BUG] Properties do not inherit superclass docstrings

Describe the bug
Properties do not properly inherit docstrings from parent class if they are not set.
To Reproduce
I observed this when rendering documentation using mkdocstrings.

Sub class with missing property docstrings: link
Super class with property docstrings defined: link

From looking at the pytokdocs source code, I think the problem is because the get_property_documentation method is using inspect.getdoc on prop.fget instead of prop directly (link).
Based on my experimentation below, both the property itself and fget work for the superclass but only the property and not fget work the subclass.
import inspect

class SuperClass:
    @property
    def read_only(self):
        """SuperClass.read_only docs"""
        return 0

    @property
    def mutable(self):
        """SuperClass.mutable getter docs"""
        return 0

    @mutable.setter
    def mutable(self, value):
        pass

class SubClass(SuperClass):
    @property
    def read_only(self):
        return 1

    @property
    def mutable(self):
        return 1

    @mutable.setter
    def mutable(self, value):
        pass

inspect.getdoc(SuperClass.read_only)
#> 'SuperClass.read_only docs'

inspect.getdoc(SuperClass.read_only.fget)
#> 'SuperClass.read_only docs'

inspect.getdoc(SuperClass.mutable)
#> 'SuperClass.mutable getter docs'

inspect.getdoc(SuperClass.mutable.fget)
#> 'SuperClass.mutable getter docs'

inspect.getdoc(SubClass.read_only)
#> 'SuperClass.read_only docs'

inspect.getdoc(SubClass.read_only.fget)

inspect.getdoc(SubClass.mutable)
#> 'SuperClass.mutable getter docs'

inspect.getdoc(SubClass.mutable.fget)

Created on 2021-02-05 by the reprexpy package
Expected behavior
Sub class properties should inherit docstrings from their parents when not set.
System (please complete the following information):

pytkdocs==0.10.1
mkdocstrings==0.14.0
Python: 3.8.6
OS: macOS

Hi @jayqi! Thanks a lot for the detailed report and the examples. I'll see if we can use getdoc on the property itself rather than its fget method.

Pushed a fix, will release it soon, closing!


Internal Object - potential error in documentation

In the README is says that if i want to import the internal Chart.js object i should use import {Chart} from 'react-chartjs-2'; but typescript throws an error. I have the @types installed.

I'm having the same issue. Please did anybody found a workaround?


Add Heinrich-Kleyer-Schule

https://www.heinrich-kleyer-schule.de/
Kühhornshofweg 27
60320 Frankfurt am Main
Germany

@udvlp Thank you for your patience while waiting for a review and processing your request. Pull request merged.
Please start requesting the licenses in about an hour, to let the changes to propagate through our system.


In the current release v0.2.2 you need to add use ExUnit.Case

In the current v0.2.2 you need add use ExUnit.Case before use ShouldI.
This could be a bit confusing to people who reading the instruction on the README.
As I can see @lpil fixed this with https://github.com/batate/shouldi/commit/baa39867fb2a60a632d66af1dba1b8b5134c7adb, so could we have soon a v0.2.3 release with that?
That would be great!  :+1:
Cheers
Samuel

:+1:

:+1:

Released.

Thanks :heart:


Use TimeProvider instead of ISystemClock

Why this PR?
#451
Visible Changes
Updated Microsoft.Bcl.AsyncInterfaces version to the latest one
Used Microsoft.Bcl.TimeProvider package. More info can be found here

This PR will be pending until major version bump.


Determine optimal parameters for data filtering per language

Context
We currently have very basic parameters for filtering by default for all languages, except english, specified in this params file.
These parameters are used to tune the following data filters:

stopwords_ratio: sample is excluded if it contains too many stopwords (often indicative of spam)
lang_id_cutoff : we look at the score obtained from the fasttext lang detection model
perplexity_cutoff: we set a score threshold for the kenlm model for each language
special_characters_ratio : sample is excluded if it contains too many special characters
contains_long_words : discard text if contains a word that is too long

For a list of supported languages, see this list.
What to do
For this work, we should run analyses per language (we have a visualization script that might help) to try to remove outliers (spam, junk text, etc) from the dataset and update the params file.
We want to start with simple stats for filtering as this needs to run for all supported languages and scale to TB's of data.

Good point, i think we can maybe do both?
If we can have simple parameter tweaks such as PR #66 , that'd be a good start. Afterwards, we want to run a deeper analysis (visualizations, sampling based on cutoffs, modifying stopwords, etc). For that, perhaps we can have a spreadsheet that we can update and serve as an example for future reports.
We need to agree on the format though. Let's try to think what that might look like


Fix #3998: Allow self types in JS types

I'm not sure this is the best way of tackling this... But it seems to work :-/


[User Feedback] Improve error message for serial port access denied

Not report “config iot hub device connection string failed: opening com4: access denied”, use "Serial Port already occupied"

The code is updated, please review the PR: #34808

Tested on version 1.3.7, the error message changes to "Config IoT Hub device connection string failed: Opening COM4: Serial Port already occupied", so close this issue


Add instanceprincipal clusteridentity support

What this PR does / why we need it:
Add InstancePrincipal support to ClusterIdentity.
Just as an add on, some other cloud provider are also moving away from env variable based identity to use Cluster Identity. So this will help us to be on par.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #314

unit test
GOBIN=/home/ubuntu/go/src/github.com/oracle/cluster-api-provider-oci/hack/tools/bin ./scripts/go_install.sh sigs.k8s.io/controller-runtime/tools/setup-envtest setup-envtest v0.0.0-20230131074648-f5014c077fc3
kube-builder assets: /home/ubuntu/.local/share/kubebuilder-envtest/k8s/1.24.2-linux-amd64
KUBEBUILDER_ASSETS="/home/ubuntu/.local/share/kubebuilder-envtest/k8s/1.24.2-linux-amd64" go test -coverprofile=coverage.out ./...
?   	github.com/oracle/cluster-api-provider-oci	[no test files]
ok  	github.com/oracle/cluster-api-provider-oci/api/v1beta1	58.251s	coverage: 23.7% of statements
ok  	github.com/oracle/cluster-api-provider-oci/api/v1beta2	0.094s	coverage: 15.7% of statements
?   	github.com/oracle/cluster-api-provider-oci/cloud/config	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/cloud/metrics	[no test files]
ok  	github.com/oracle/cluster-api-provider-oci/cloud/ociutil	0.004s	coverage: 19.6% of statements
ok  	github.com/oracle/cluster-api-provider-oci/cloud/scope	241.063s	coverage: 75.0% of statements
?   	github.com/oracle/cluster-api-provider-oci/cloud/scope/mocks	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/cloud/services/base	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/cloud/services/base/mock_base	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/cloud/services/compute	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/cloud/services/compute/mock_compute	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/cloud/services/computemanagement	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/cloud/services/computemanagement/mock_computemanagement	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/cloud/services/containerengine	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/cloud/services/containerengine/mock_containerengine	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/cloud/services/identity	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/cloud/services/identity/mock_identity	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/cloud/services/loadbalancer	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/cloud/services/loadbalancer/mock_lb	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/cloud/services/networkloadbalancer	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/cloud/services/networkloadbalancer/mock_nlb	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/cloud/services/vcn	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/cloud/services/vcn/mock_vcn	[no test files]
ok  	github.com/oracle/cluster-api-provider-oci/cloud/util	0.139s	coverage: 73.4% of statements
ok  	github.com/oracle/cluster-api-provider-oci/controllers	27.030s	coverage: 60.3% of statements
ok  	github.com/oracle/cluster-api-provider-oci/exp/api/v1beta1	14.292s	coverage: 15.2% of statements
ok  	github.com/oracle/cluster-api-provider-oci/exp/api/v1beta2	0.016s	coverage: 4.8% of statements
ok  	github.com/oracle/cluster-api-provider-oci/exp/controllers	0.435s	coverage: 58.4% of statements
?   	github.com/oracle/cluster-api-provider-oci/feature	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/version	[no test files]

e2e tests
Ran 7 of 28 Specs in 3681.027 seconds
SUCCESS! -- 7 Passed | 0 Failed | 0 Pending | 21 Skipped


Uninstall instructions?

Description
Is there documentation for uninstallation instructions? Thanks.

just clean up your .zshrc? and maybe sudo apt remove antige, if you used apt to install...not an expert, though...

Anyone? BUMP

Curl just downloads the script. Remove the references from .zshrc, remove the downloaded file and clean up the plugins folder. Thats it.


.once doesn't go well with .self

Consider following element:

Eat me

If we click on "Eat" word, everything works as expected. The event is being fired once and we are happy.
 It seems like .once is too easy on judging an event as fired.
I think .once should mark it as done only if it has been fired in fact.

Thanks for filing the issue. Please follow the Issue Reporting Guidelines and provide a minimal JSFiddle or JSBin containing a set of reproducible steps that can lead to the behavior you described.
Why is this required?

Hi,
I am not the OP but I think I managed to reproduce the issue he was referring to. I attached a JSFiddle below for illustration.
JSFiddle

Clicking on the word 'Eat' works as expected: the event is fired and the fruit data is updated.

If we reload the JSFiddle and click on the span child element 'me', and then on 'Eat', the fruit data is not updated.

Hope this helps.

@boristhuy Thank you for providing JSFiddle. This is exactly what I meant.

This should be a bug. Currently the event handle will be removed once it enters, in fact it is not invoked indeed because of the modifiers.
Maybe we need to update the once internal strategy to support it.
like
(function(){
  var called = false;
  return function($events){
    // modifiers check
    // called check
    if (called)return;
    called = true;
    // handler code
  }
})()

but how to insert the called into once
i have no idea about that

As for once  used in render function, it would bring a breaking change. I'm trying to find a way to fix this issue.

@defcc I fixed it by returning a special value from handlers that are prevented from execution. This may not address the (3) bug you mentioned, but let's handle that in a separate PR if necessary.


Add support for audit-policy logging

Thanks for the PR, sorry for delayed response.
There are a couple of problems overall...

Please run build/genfixed.sh to update the 'fixed' scripts (CircleCI fails because of this)
The change is not compatible with k8s 1.8 and 1.9.

E.g. for k8s 1.9 you get (see Travis job):
feature-gates: Invalid value: map[string]bool{"Auditing":true, "CoreDNS":false}: Auditing is not a valid feature name. Valid features are: [CoreDNS DynamicKubeletConfig SelfHosting StoreCertsInSecrets HighAvailability]

You need to either verify kubeadm vesion prior to enabling the feature gate, or just don't enable it by default, adding a note to README.md.

@hh please rebase.

I signed it

I just added audit log support for kind e2e.sh
Should I back port / rebate that here or have we moved to kind?

/remove-lifecycle stale

Closing as this project is being deprecated and retired in favor of KinD.
Please see this issue for more details:
https://github.com/kubernetes/org/issues/1016
/close


How to best access TypedArrayContents data as an array?

I have made use of the test code for TypedArrayContents. I notice that the data is accessed through a pointer. In code I have written to add one to each item in a typed array, I have:
(*data)[i] = (*data)[i] + 1;

How can I efficiently cast the data from the TypedArrayContents to an array of doubles?
This does not work:
double* data2 = static_cast<double*>(data);

Is there an equivalent that would work (if it's clear what I am trying to achieve)?

*data returns a pointer to the underlying buffer
On Friday 09 October 2015 06:08:35 metabench wrote:

I have made use of the test code for TypedArrayContents. I notice that the
data is accessed through a pointer. In code I have written to add one to
each item in a typed array, I have:
(*data)[i] = (*data)[i] + 1;

How can I efficiently cast the data from the TypedArrayContents to
an array of doubles?
This does not work:
double* data2 = static_cast<double*>(data);

Is there an equivalent that would work (if it's clear what I am trying to
achieve)?

Reply to this email directly or view it on GitHub:
https://github.com/nodejs/nan/issues/488

How about double* data2 = *data; ... or even ++((*data)[i]);

Ah... what @kkoopa says... ;)

@agnat Thanks, double* data2 = *data; looks like it does the job.


Feat/patch call integration

What is the change?
Integrated patch api , api integration according to remix docs
(#157 )
*Dev Tested?

[x] Yes

Platforms

[x] Web

Browsers

[x] Chrome

[ ] Safari

[ ] Firefox

For visual or interaction changes. Can be video / screenshot.

https://github.com/Real-Dev-Squad/website-calendar/assets/68243599/64aee7d4-4642-4336-a053-5738cce2c508

@isVivek99 video shows the details not being updated. The second time when you open the event, the updated details are reset to the original one. Am I missing anything?
Also not able to create new event now.

@isVivek99 video shows the details not being updated. The second time when you open the event, the updated details are reset to the original one. Am I missing anything?
Also not able to create new event now.

video shows only attendees not being updated, that is an issue with backend, there is a comment about the same on the backend repo
// TODO: Need to fix updating attendees list
creating new event i will handle, in the next commits

@isVivek99 homepage still crashing:

@isVivek99 homepage still crashing:

its happening because eslint in not throwing errors we need to fix it first

@isVivek99 , seems like the test cases are still failing for the above

Thanks @isVivek99 for this PR.

The PR has entirely revamped the project, ensuring we maintain the global state for the event update.
Creation of a separate route for the event with handling the error scenario which highlights your attention to details
Creation of separate files for constants and creating API, business and view layer
You have ensured to keep us in loop for constant communication
Constant Demo and discussion has helped us in this revamp and making the project better

Great work :)

Thanks @isVivek99 for this PR.

The PR has entirely revamped the project, ensuring we maintain the global state for the event update.
Creation of a separate route for the event with handling the error scenario which highlights your attention to details
Creation of separate files for constants and creating API, business and view layer
You have ensured to keep us in loop for constant communication
Constant Demo and discussion has helped us in this revamp and making the project better

Great work :)

Thanks for ur kind words @harshith-venkatesh , waiting for the first release now 🚀


Customize error messages from Auth

reported by @Morred
https://github.com/eigenbart/rack-jwt/issues/9
Hi there,
First of all, thanks for writing this gem, it's super useful!
I guess this one is more like a feature request, I'm looking for a way to customize the format of the error responses of the Auth class.
Every time something fails, it will automatically return a 401 response with the error body format that is hardcoded into this method, so currently I'm just monkeypatching the return_error method to build the error body into the format I need.
Is a general, more flexible way to format the error responses something you would consider adding to this gem?

I know, it is obvious, but i think that good way to handle it is add localization files, just like in other gems like device.
It is easy to develop, needs one default english-locale file somewhere inside the gem (no need to do generator for that). Also need to have configurable path to user locale file for overlapping and default value for it, or several, if it needs to do for distinct frameworks.

@xfynx honestly I don't think localization is needed here. Error messages returned by the gem are not meant to be shown to the user, they are useful for logging and debugging but the client should show "Authentication failed" instead of "Invalid JWT token : Signature Verification Error", wdyt?

@morred what's the point of having custom error messages? do you need a different format than {error: message} to accommodate error messages to your client without changes maybe?

@eparreno yeah, you are right, there is no need more dependencies for gems like this. and "Authentication failed" is a great variant. In general i think that current variant is okay: no exceptions, that will return something another than 401 with description. From another point of view if it will be used as it is, it needs more common messages for user, but not scary "Invalid JWT ID" or "Incorrect Key Algorithm"

I'd like to be able to do more than customize the error message string. I'd like to return a JSON error message with the same structure as all my other API errors. I haven't yet settled on exactly what that structure will be (I'm studying this SO answer). I was hoping I could pass a block as one of the options to customize the error generation.
@eparreno do you mind sharing your monkey patch?

I ended up here also looking for a way to customise the HTTP 401 JSON.  How about an option, say, called customize_unauthorized_response, which is a proc that accepts the original message?
The default proc would emulate the current behavior:
default = Proc.new { |message| { error: message } }

Then, return_error would just call either a provided proc, or, the default if none provided, to format the body:

DEFAULT_CUSTOMIZE_UNAUTHORIZED_RESPONSE = Proc.new { |message| { error: message } }

 def initialize(app, opts = {})
        @app     = app
        @customize_unauthorized_response  = opts.fetch(: customize_unauthorized_response, DEFAULT_CUSTOMIZE_UNAUTHORIZED_RESPONSE)
....

def return_error(message)
  body    = @customize_unauthorized_response(message).to_json
   ...

Is that too much indirection?  Thoughts?  I could try a PR if there is interest in this feature.

Whoops, I just noticed @mpoisot suggested passing in a block as well.  Apologies for the dupe.

Sorry for the delay guys, gonna check that one today since a few people is interested


I am looking for a job

I am looking for a job, I hope to find a suitable job in Beijing, please contact me if you are interested, thank you!

@an-tao Are you graduating? I ain't sure but it should be pretty easy to find a network related job in China?!

@ihmc3jn09hk I have graduated for more than ten years. I just want to change my job.

@an-tao I see. Good luck 🤟


Library C++ version incorrect for older releases

Graph requires C++14 yet 1.18.0 was released in 2013?

I'm curious when you investigate the cause for this, if it's only to this particular case, or if there is reason to think it could be a deeper issue.

Someone needs to manually adjust each row in the table to have the correct date and version

The cpp version being shown is tied to the Library (Graph) rather than the Library Version Graph 1.xx.yy.
The change for this would be to add cpp version to the Library Version and use that instead. In some cases we have some additional data on the cpp version, but for Graph for example, we only have it from 1.77 on.
In that case, should we default to 03 as it does now?

I don't know what "add cpp version to the Library Version" means. Are you suggesting that library versions should appear as "1.86.0C++17" for example? That doesn't make sense...


Color picker covered up

Thanks for the plugin! Great work.
On iPhone X's, the color picker is covered half way by the keyboard when writing text and by the bottom of the screen when drawing. Is this due to the safe areas? Is there a way to fix this via {N} or styling?
Screenshots:

This is now fixed in the new version of the plugin available in the ProPlugins NPM registry.
All future work of this plugin will be available exclusively as part of ProPlugins initiative. So if you want to get the latest updates/fixes/features make sure you subscribe to the service. You get all my plugins plus many of the most used and high quality plugins for a small monthly subscription fee.


Side nav bar is not in sync with the theme

Bug
What is the expected behavior?
Side navigation bar should have the same theme as the toolbar
What is the current behavior?
The background is not set

What are the steps to reproduce?

Create a brand new angular project
Add angular Material to it(Selected indigo-pink theme)
Add the nav component using schematics(ng generate @angular/material:nav )

What is the use-case or motivation for changing an existing behavior?
We are not trying to change the existing behavior.
Which versions of Angular, Material, OS, TypeScript, browsers are affected?

Is there anything else we should know?
No, it is pretty straightforward. I tried checking in MS-Edge, Firefox, and Chrome. All the browsers have the same behavior

I'll be happy to assist with any information that is required to debug/fix the issue.

Thanks for your issue. Based on the PR that recently changed the schematic, this is by intention. See: https://github.com/angular/material2/pull/13282
Based on the information in the PR, the toolbar should align with the color of the content though.

@castasint I tried looking into it, but couldn't reproduce the case where the .mat-toolbar does not inherit the color from the background.
Can you inspect the toolbar in the sidenav and check if there is a background: inherit statement?


JSON files with comments or trailing commas are not supported

I managed to reproduce this with the VSCode plugin, where the parsing of settings.json file failed.  However, I suppose that it would be reproducible with the Firefox plugin as well (which also parses JSON files).
When I execute yin-yang -t from the command line, the following error messages appear:

2022-04-16 13:57:39,999 ERROR - src.yin_yang: Error while changing the theme in plugin VS Code
json.decoder.JSONDecodeError: Expecting property name enclosed in double quotes: line 16 column 5 (char 558)
After the first yin-yang run, I noticed that there are comments in my settings.json file, and the mentioned line and column number matched the // sequence which begins the first comment.  After removing all comments from the file, the same error persisted on the second run.  However, now it was on the line containing the closing } of a JSON object with a trailing comma after its last property:

    "files.associations": {
        ".clang-format": "yaml",
        ".nvimrc": "viml",
    },

I suppose that is caused by limitations in the json Python module.  It's up to the author to decide if it's feasible to use another module which supports these syntax features.

@rgeorgiev583 thanks for the bug report, I was not aware of this. However I will not going to fix this issue since this is not a breaking bug. If you are interested in collaboration feel free to take up that task.

We’d need something like tomli for JSON-with-comments to properly support VS Code.
I don’t want this project to get rid of my comments and formatting in my VS Code config.

What’s a “breaking bug”? This makes Yin-Yang incompatible with any VS Code config that uses comments or trailing commas, which is almost all of them.

Duplicate of #84


Substreams: Aggregation

We need a page to explain, even if just in summary form, how to do aggregations.
Someone was using append, and that’s not the pattern. We have examples in Uniswap-v3, and we need to give a high-level overview of how to use keys to do such aggregations.
https://github.com/streamingfast/substreams-uniswap-v3/blob/develop/substreams.yaml
people are going to look how to do Aggregations, so I’d have something like “Aggregation” .. under some Tutorials or Cookbook section.. unsure where to put it right now

I was experimenting with Append this weekend. ... :)


⚠ Jenkins Plugins Artifactory has degraded performance

In dbdaa93, Jenkins Plugins Artifactory (https://get.jenkins.io/plugins/artifactory/) experienced degraded performance:

HTTP code: 200
Response time: 1245 ms

Resolved: Jenkins Plugins Artifactory performance has improved in 3136a82 after 12 minutes.


Physics Profiler sections shows something irrelevant

Godot version:

3.1 beta11
OS/device including version:

macOS
Issue description:

I'm debugging the peak FPS drop and encountered this. This looks like a profiler bug to me, since Physics time is high while Physics2D sections shows really low usage.
What I am actually doing to slow things down is some UI node manipulation.

Steps to reproduce:
Minimal reproduction project:

The only explanation I can have is that Physics it actually _fixed_process() time. But why it doesn't show up in Script Functions then?

I am having similar problems understanding the profiler. I have no physics in my game. What is this Physics time that takes the entire time.  Also why don't Script Functions time add up to all the functions below it. FYI the frame did take about 4 seconds, so the profiler got that right. But it should all be inside the _redraw_table() and it just shows 10% of what is should be.

Same issue here on 3.3.2:

The spikes represent selecting objects in a 3D editor built within Godot; various things happen in response to this, such as assembling composite meshes for outline rendering in a separate viewport / world, and assembling similar composite collision shapes so the selected objects can all collide as one while being moved around.
However, disabling the code that talks to the physics server - namely the creation of composite collision shapes - has no effect on the profiler output. The spikes still occur on selection change, suggesting that the performance issue lies elsewhere, but are nonetheless attributed to Physics Time.

Duplicate of https://github.com/godotengine/godot/issues/23715#issuecomment-859460407.


NSData *buffer = [stream propertyForKey:NSStreamDataWrittenToMemoryStreamKey]; problem

Hi,
I used to HubConnection class. After 1-5 minutes, I take an error about this line "NSData *buffer = [stream propertyForKey:NSStreamDataWrittenToMemoryStreamKey];" on SREventSourceStreamReader class.
my sample code:
self.hubConnection = [SRHubConnection connectionWithURLString:@"http://this-ismy-ip];
// Register for connection lifecycle events
[self.hubConnection setStarted:^{
    NSLog(@"Connection Started %@",self.hubConnection.connectionId);
}];
[self.hubConnection setReceived:^(id message) {

    NSLog(@"Connection Recieved Data: %@",message);
}];
[self.hubConnection setConnectionSlow:^{
    NSLog(@"Connection Slow");
}];
[self.hubConnection setReconnecting:^{

    NSLog(@"Connection Reconnecting");
}];
[self.hubConnection setReconnected:^{

    NSLog(@"Connection Reconnected");
}];
[self.hubConnection setClosed:^{
    NSLog(@"Connection Closed");
}];
[self.hubConnection setError:^(NSError *error) {
    NSLog(@"Connection Error %@",error);
}];
// Start the connection
[self.hubConnection start];

Please help me!

Hi, What do you mean "needs repro".

It's short for "reproduction." It means the code above does not crash locally, and we still need to figure out how to create an environment that does crash

I get exactly the same issue
@aybarsyalcin @ellezerh what have you done with this?

I am having same problem. When there is little high traffic, this error out. I switched to long polling which solved the issue.

I have the same issue too, when there is high traffic.

how I change to long polling  ?

@roeeAsaf  [connection start:[[SRLongPollingTransport alloc] init]]

@alabib its replace [connection start] ?

@roeeAsaf Yes.

Thanks guys for opening this issue/suggestion a workaround. I have the same problem - under a high SignalR messages load (actually, not that high - each message arrives in 0.1-0.2 second) it crashes at the same place. Switching to long polling transport helped.

@ni4 I found out that the server events did the crashing but the long polling and web sockets they both work fine.

I'm getting the same error.
It's about a 2MB payload (5K json array of objects). I just have to do a few and it will fail quite easily after 2 or 3 times.

Where do you place the "[connection start:[[SRLongPollingTransport alloc] init]]" code? Having this same issue.

I have the same issue in signal R in the line no. 90
NSData *buffer = [stream propertyForKey:NSStreamDataWrittenToMemoryStreamKey];
shall any one explain me how to solve this.

Got this issue few times. It happened when

SRAutoTransport was used
It falled back to SRServerSentEventsTransport
WS sent big amount of data.
Quick fix was to use SRWebSocketTransport or SRLongPollingTransport directly, e.g. :
[connection start:[[SRWebSocketTransport alloc] init]];
[connection start:[[SRLongPollingTransport alloc] init]];


Support for multiple languages/translations of front matter

Suggestion: Create a "This page is available in the following languages" section at the bottom of the resources homepage, with translations of the front matter.

We're not maintaining this project; closing this.


In OSX Firefox it now takes about 3 seconds before the project is loaded locally

Something is wrong with app loading in OSX Firefox now. My application that is built on angular2-seed sticks on "loading.." and when I click around, switch browser tabs, open/close browser console it sometimes completes loading and shows the content. Original angular2-seed project is taking about 3 seconds to remove "loading.." and show home page.

@tandu are you using it on your local machine ?

Yes.

@tandu currently we load all the modules from Angular 2 (including the internal modules, the router, http etc) on demand, which slows down the initial load.
This is due to the fact that we require Angular 2 by using:
import {whatever...} from 'angular2/angular2';

Which goes to node_modules and loads all the angular files one by one.
This is caused by the change we made in https://github.com/mgechev/angular2-seed/pull/262.
Possible optimizations

As possible optimization we can provide the bundles for the core libraries of the seed (such angular 2 and all the standard modules such as router & http), like we did before.
Bundle all the files with the systemjs or browserify (it doesn't make big difference which one we're going to use for the dev build as soon as we're generating source maps).

I implemented the first strategy since with the second one would take too much to create the entire bundle.


scripts/setup/timelog_user_group.py is so slow

Users might think it's hanging.

Oh, wait, no, it's probably restarting timelog.service that takes so long. Brb.


remove config deserialize from core

Issue number and link
Fixes: #220

Describe your changes

remove config crate dependency from springql-core
add config crate to springql
move config deserialize function from core, to springql
add public surface api config_from_toml

Checklist before requesting a review

[x] I follow the Semantic Pull Requests rules (bugfix/feature)
[x] I specified links to related issues (must: bugfix, want: feature)
[x] I have performed a self-review of my code (bugfix/feature)
[ ] I have added thorough tests (bugfix/feature)
[x] I have edited ## [Unreleased] section in CHANGELOG.md following keep a changelog syntax (bugfix/feature)
[ ] I {made/will make} a related pull request for documentation repo (feature)

I guess we can keep SpringConfig API for springql crate users.
I feel It is totally OK to break the springql-core's config related APIs but I would like to keep the API in springql crate.

I close this.
and Re-create pr to implement this.
https://github.com/SpringQL/SpringQL/pull/216#discussion_r919574717