Duplicate context lines in search result view

Type: Bug

Open an existing file
Open a new search editor (This doesn't happen in the search sidebar, because the sidebar doesn't show context lines)
Search for something that's in the file you opened
See that the "context" lines that appear around the matching line are doubled.

See below for an example when searching for short_id:
app/assets/javascripts/react/songPage/components/AdminMenu.js:
   34  const clientAdminActions = [
   35  const clientAdminActions = [
   36:   'see_short_id', 'manage_chart_item',

   36  ];
   37  ];

  143              }
  144              }
  145:             {can('see_short_id', song) && (
  145                <>
  146                <>

In this case, lines 36 and 145 are matching, and the surrounding lines are doubled.
This appears to happen both in a local context and when using Remote-SSH. I was able to reproduce it in both environments.
VS Code version: Code 1.82.3 (Universal) (fdb98833154679dbaa7af67a5a29fe19e55c2b73, 2023-10-02T11:06:17.496Z)
OS version: Darwin x64 21.6.0
Modes:
Remote OS version: Linux x64 5.15.0-1025-gcp
Remote OS version: Linux x64 5.15.0-1025-gcp

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz (12 x 2600)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: enabled

Load (avg)
8, 5, 5

Memory (System)
16.00GB (0.51GB free)

Process Argv
--crash-reporter-id a23ed286-653c-4edd-854c-4b1de37bd0f5

Screen Reader
no

VM
0%

Item
Value

Remote
SSH: evan.genius-development

OS
Linux x64 5.15.0-1025-gcp

CPUs
AMD EPYC 7B12 (4 x 2250)

Memory (System)
15.62GB (3.64GB free)

VM
0%

Item
Value

Remote
Dev Container: Go @ ssh://evan.genius-development

OS
Linux x64 5.15.0-1025-gcp

CPUs
AMD EPYC 7B12 (4 x 2250)

Memory (System)
15.62GB (3.64GB free)

VM
0%

Extensions (17)

Extension
Author (truncated)
Version

jupyter-keymap
ms-
1.1.2

remote-containers
ms-
0.315.1

remote-ssh
ms-
0.106.5

remote-ssh-edit
ms-
0.86.0

remote-explorer
ms-
0.4.1

vscode-ruby
win
0.28.0

circleci
Cir
1.22.1

gitlens
eam
14.3.0

EditorConfig
Edi
0.16.4

vscode-pull-request-github
Git
0.72.0

go
gol
0.39.1

ruby
reb
0.28.1

snyk-vulnerability-scanner
sny
1.24.1

uridecode
sry
0.3.6

shellcheck
tim
0.34.0

vscode-ruby
win
0.28.0

markdown-all-in-one
yzh
3.5.1

(1 theme extensions excluded)

A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
vserr242:30382549
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vshan820:30294714
vstes263cf:30335440
vscoreces:30445986
vscod805:30301674
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593:30376534
pythonvs932:30410667
vsclangdf:30486550
c4g48928:30535728
dsvsc012cf:30540253
pynewext54:30695312
azure-dev_surveyone:30548225
2e4cg342:30602488
89544117:30613380
a9j8j154:30646983
showlangstatbar:30737416
03d35959:30757346
pythonfmttext:30731395
fixshowwlkth:30771522
showindicator:30805244
pythongtdpath:30769146
i26e3531:30792625
pythonnosmt12:30797651
pythonidxptcf:30805731
pythonnoceb:30805159
copilotsettingc:30839828
asynctok:30821568
dsvsc013:30795093
dsvsc014:30804076
diffeditorv2:30821572
dsvsc015:30845448
pythonfb280951:30830810

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.83.1. Please try upgrading to the latest version and checking whether this issue remains.
Happy Coding!

I updated to 1.83.1 and am still able to reproduce this issue.

/duplicate of #192113

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for similar existing issues. See also our issue reporting guidelines.
Happy Coding!


Excessive Bandwidth Consumption Post v36.0 Node Upgrade

Description:
Since upgrading to Akash node release v36.0, nodes have been consuming an unusually high amount of bandwidth, far exceeding the previous usage. This has resulted in "out of bandwidth" notifications across multiple nodes in various datacenters, as well as noticeable lag on residential networks. No changes were made to the default deployment code.
To Reproduce:

Deploy an Akash node using the default deployment code.
Monitor the bandwidth usage of the node.

Expected Behavior:
The node should have a sustained bandwidth usage of approximately 5,100,000 BPS (5.1 Mbps) for incoming and 6,000,000 BPS (6 Mbps) for outgoing traffic.
Traffic Analysis:
Upon reviewing the provided screenshot:

Pre-Upgrade Bandwidth Usage:

Incoming bandwidth: Approximately 5,100,000 BPS (5.1 Mbps).
Outgoing bandwidth: Approximately 6,000,000 BPS (6 Mbps).

Post-Upgrade Bandwidth Usage: There is a significant spike in bandwidth consumption.

Outgoing bandwidth: Approximately 600,000,000 BPS (600 Mbps).
Incoming bandwidth: Approximately 50,000,000 BPS (50 Mbps).

Attempted Fixes:
I have attempted to limit the P2P connections and adjust the send_rate and recv_rate parameters in the Cosmos SDK configuration. Despite these efforts, the issue persists.
Request:
Please examine the issue deeper and push a fix to stop the irregular bandwidth consumption.
Recommendation:
Anyone running an Akash node should check their bandwidth consumption and traffic to ensure they are not affected by this issue. Create point release for v36.0 that stops excessive bandwidth consumption.
Monthly Traffic View:

Monthly Traffic View:

Before Upgrade Daily:

After Upgrade Daily:

Additional Context:
This issue is critical as it affects the performance and reliability of the nodes across various datacenters and residential networks. Immediate attention and resolution are required.

@88plug - could you please confirm:
1). Are these nodes being built via Akash Helm Charts?  Asking because the Helm Charts sets - minimum_gas_prices: 0.025uakt - and want to ensure this setting is in place in affected nodes.
2). During node start up - are there any log entries regarding 0 gas prices?

Review from additional node operator impacted by increased P2P traffic:

Nodes using both CLI and Helm Chart builds are experiencing heightened traffic

The CLI node build has minimum_gas_prices: 0.025uakt setting in app.toml

Helm Chart default values were not changed and thus should have minimum_gas_prices: 0.025uakt

The bandwidth is NOT increasing further over time.  I.e. the P2P bandwidth rose considerably a few days ago and has been steady at that level since.

No evidence of 0 gas fees in node logs but logs are littered with failed to add vote errors such as:

Jun 21 19:46:38 mainnet-node start-node.sh[32110]: ERR failed to process message err="error adding vote" height=16846721 module=consensus msg_type=*consensus.VoteMessage peer=2a3ba81a7ddb00016af1593f925aed390c4bcca9 round=0
Jun 21 19:46:38 mainnet-node start-node.sh[32110]: INF failed attempting to add vote err="expected 16846720/1/2, but got 16846720/0/2: unexpected step" module=consensus... (175 KB left)

Review from additional node operator impacted by increased P2P traffic:

Nodes using both CLI and Helm Chart builds are experiencing heightened traffic
The CLI node build has minimum_gas_prices: 0.025uakt setting in app.toml
Helm Chart default values were not changed and thus should have minimum_gas_prices: 0.025uakt
The bandwidth is NOT increasing further over time.  I.e. the P2P bandwidth rose considerably a few days ago and has been steady at that level since.
No evidence of 0 gas fees in node logs but logs are littered with failed to add vote errors such as:

Jun 21 19:46:38 mainnet-node start-node.sh[32110]: ERR failed to process message err="error adding vote" height=16846721 module=consensus msg_type=*consensus.VoteMessage peer=2a3ba81a7ddb00016af1593f925aed390c4bcca9 round=0
Jun 21 19:46:38 mainnet-node start-node.sh[32110]: INF failed attempting to add vote err="expected 16846720/1/2, but got 16846720/0/2: unexpected step" module=consensus... (175 KB left)

It seems that this issue is observed in other networks as well, for example, in the Sentinel Network

https://x.com/zeroservices_eu/status/1784553362316288174
I'm not sure exactly how this problem arises, but it seems that it spreads through specific peers

grep "00a39ac3ec012ffa3116a162c17f49df484d0298" .akash/config/config.toml

grep -A 2 -B 2 "00a39ac3ec012ffa3116a162c17f49df484d0298" .akash/config/addrbook.json

I'm not sure why this P2P address appears in the address book 123 times 😳
grep "00a39ac3ec012ffa3116a162c17f49df484d0298" .akash/config/addrbook.json | wc -l
123

addrbook.json

@c29r3 can you backup your addrbook and try one from polkachu

@c29r3 can you backup your addrbook and try one from polkachu

Done, but err="error adding vote" still exists

I enabled the --log_level debug mode and saved logs for the last 20 minutes  from my RPC node
sudo journalctl -u akash.service --no-hostname --since "20 minutes ago" | grep -v p2p > akash_20min_log.txt

https://drive.google.com/file/d/1HxHpD4AUQORsWmMSNBGQLfXsLv9YEtA7/view?usp=sharing

Fixes excessive bandwidth #285
I did a battery of tests over the weekend and was able to resolve the issue.
The issue appears to be with the p2p seed_mode is set to true for the node in the Helm charts.
Cosmos default is pex enabled and seed mode disabled.
I have updated the Helm charts and tested with seed_mode disabled and the excessive bandwidth issue is resolved.
For reference in my testing I also found "error adding vote" will show with 0.025uakt fee. So that may indict some other issue, but it was not related to the bandwidth.

Issue was caused by IBC relayers allowing zero/very low gas TXs onto the network and into validator mempool.  While Akash RPC/validators are universally configured to reject zero gas TXs, a number of IBC relayers were not configured to reject these TXs.
Issue was resolved by:
1). Specific validators intentionally set their min gas requirement to zero to allow these TXs to be written to the chain and thus cleansing the validator mempools of such TXs.
2). Worked with current IBC relayers to ensure they have min gas settings.
Network P2P traffic is now normalized.

Issue was caused by IBC relayers allowing zero/very low gas TXs onto the network and into validator mempool.  While Akash RPC/validators are universally configured to reject zero gas TXs, a number of IBC relayers were not configured to reject these TXs.
Issue was resolved by:
1). Specific validators intentionally set their min gas requirement to zero to allow these TXs to be written to the chain and thus cleansing the validator mempools of such TXs.
2). Worked with current IBC relayers to ensure they have min gas settings.
Network P2P traffic is now normalized.

Issue was caused by IBC relayers allowing zero/very low gas TXs onto the network and into mempool. While Akash RPC/validators are universally configured to reject zero gas TXs, a number of IBC relayers were not configured to reject these TXs.

That's an interesting case though. So essentially you can bombard a chain with traffic and increase block times by just running a node with 0 minimum-gas-prices and creating a bunch high gas and 0 fee txs? Assuming every validator running with non-zero min gas prices.
Because we had non-zero gas prices on all of our nodes, but still experienced huge spike in traffic. And according to metrics mempool was almost empty all the time. But i guess that's because for node to determine if it needs to accept a tx into the mempool based on gas price - it has to "download" the full tx, decode it and look at actual gas price.

@Krewedk0 It's not quite correct.

All validators had and have minimum gas fees >0
There were a few relayers using default configuration from chain registry which had minimum gas fees set 0.
Due to IBC v4 design, transactions coming via IBC with 0 or very small gas fees could enter mempool and stuck there forever, because:

all validators has gas fees set to correct level
tx recheck in cosmos SDK v0.45.x does not work correctly, even tho transactions were expired, they still stayed in the mempool.

@troian Deleted my last comment not not give bad people good ideas. But i ran some tests last night and you can actually do very nasty stuff with the setup i mentioned.
Also Chandra Station and 16psyche  still have 0 min gas prices set on their validator nodes.


ipcache: Fix ipcache pod IP update

If an IP was reused by another pod, then a bug in the pod/namespace
comparison logic would prevent the ipcache being updated for the pod.
Fix it.
Reported-at: https://lgtm.com/projects/g/cilium/cilium/alerts
Fixes: 348051e7aaaf ("ipcache: Associate IPs with K8s namespace and pod name")
Related: #10099
Only affects v1.7 branch AFAICT.

This change is

test-me-please

Coverage increased (+0.005%) to 44.626% when pulling 1a5232eb34451a8c2aaf73b44fff73fb98b5a3bf on joestringer:submit/fix-ipcache-pod-comparison into bc5d8e16eca13141936e939c96a7b1ef5f9d2571 on cilium:master.

test-me-please


No support for plot_objective using Classifier class

I can't seem to use the functions plot_objective or plot_evaluations for results retrieved using the Optimizer class. This is sad, because this class is the best way I have found to optimize both the ML model structure, the preprocessing routines and other settings in the same process. And visualization would be very insightful.
Error message:

AttributeError: 'Optimizer' object has no attribute 'x_iters'

Code example:
def test_plot():
    space = [skopt.space.Integer(2, 300, name='first_parameter'),
             skopt.space.Integer(2, 100, name='second_parameter')]

    opt = skopt.Optimizer(space, "GP", acq_optimizer="sampling")

    for i in range(10):
        # Ask optimiser for settings to try
        settings = opt.ask()

        score = settings[0] + settings[1]
        opt.tell(settings, -score)

    plot_objective(opt)
    plot_evaluations(opt)

if __name__ == "__main__":
    test_plot()

Hi tordbb,
You have to store the last opt.tell(setting,score) in a variable. And then call that variable in the plot_objective().
Like:
result = opt.tell(settings[-1], score[-1])
plot_objective(result, dimensions=['first_parameter', 'second_parameter'])
Hope it helps

Thank you so much, sqbl!
I had to tweak a little more to make the plots show in pyCharm, but now it all works. Here is the complete, working code:
import random
import skopt
from skopt import plots
from matplotlib import pyplot as plt

def test_plot():
    space = [skopt.space.Integer(2, 300, name='param1'),
             skopt.space.Integer(2, 100, name='param2')]

    opt = skopt.Optimizer(space, "GP", acq_optimizer="sampling")

    for i in range(10):
        # Ask optimiser for settings to try
        settings = opt.ask()

        score = random.random()
        res = opt.tell(settings, -score)

    plots.plot_objective(res, dimensions=['param1', 'param2'])
    plots.plot_evaluations(res, dimensions=['param1', 'param2'])
    plt.show()

if __name__ == "__main__":
    test_plot()


[Snyk] Security upgrade next from 13.3.0 to 13.5.0

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to fix one or more vulnerable packages in the `npm` dependencies of this project.
Changes included in this PR

Changes to the following files to upgrade the vulnerable dependencies to a fixed version:

apps/frontend/nextjs-blog/package.json
apps/frontend/nextjs-blog/package-lock.json

Vulnerabilities that will be fixed
With an upgrade:

Severity
Priority Score (*)
Issue
Breaking Change
Exploit Maturity

658/1000  Why? Proof of Concept exploit, Recently disclosed, Has a fix available, CVSS 5.3
Resource Exhaustion SNYK-JS-NEXT-6032387
No
Proof of Concept

(*) Note that the real score may have changed since the PR was raised.

Commit messages

Package name: next
    The new version differs by 250 commits.

ffafad2 v13.5.0
4a589ed v13.4.20-canary.41
deb81cf fix styled-jsx alias (#55581)
1a9b0f6 improve internal error logging (#55582)
0631549 Fix react packages are not bundled for metadata routes (#55579)
bad5365 Update supported config options for Turbopack (#55556)
8881c41 Fix useState function initialiser case for `optimize_server_react` transform (#55551)
1025011 Add react-icons to optimizePackageImports (#55572)
d5c35a1 chore: replace issue triaing actions with `nissuer` (#55525)
33c561b Consolidate experimental React opt-in & add `ppr` flag (#55560)
f630cb8 Add `mui-core` to the default `optimizePackageImports` list (#55554)
caa9083 chore: Fix heading hierarchy in revalidateTag documentation (#55470)
d01ab61 v13.4.20-canary.40
6123a97 Fix missing trace file and unhandledRejection in ensurePage (#55553)
b5beb3a Correct spelling in playwright docs (#55557)
4c6d4b3 Type Error on Event Type payment_intent webhook (#55493)
41c89f0 v13.4.20-canary.39
7fe01bb Disable client-only for middleware and pages api layer (#55541)
e4439b1 chore(third-parties): replace rimraf with rm.mjs (#55547)
1b8ce8f Add route groups example to revalidatePath doc (#55543)
9697bcd Fix notFound status code with ISR in app (#55542)
0338dcd fix next.js own build on windows (#55544)
4f98dc6 v13.4.20-canary.38
0ddb15b fix: run turbopack in forked process (#55545)

See the full diff

Check the changes in this PR to ensure they won't cause issues with your project.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
🛠 Adjust project settings
📚 Read more about Snyk's upgrade and patch logic

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Resource Exhaustion

Replaced by #34


unwrap/warn if ref is passed to action

Reproduction
https://stackblitz.com/edit/github-vl7ve8?file=src/App.vue
Steps to reproduce the bug

Click "Set (not OK)"
Observe that counter and event count is unchanged
Click "Increment"
Observe that the event count remains unchanged and counter is now in sync with input (as they both share a single ref object)

Expected behavior
I think the parameters should be unwrapped or alternatively a warning should be displayed.
Reactivity and subscriptions should not be broken.
Actual behavior
When passing a ref as a parameter to an action, undefined behavior occurs.
If this ref is set as state, no mutation is displayed in the timeline and subscriptions do not receive an event.
Additional information
I don't use TypeScript, maybe IDEs already show a warning when a ref is passed to an action?

This could be valid usage as the user could do the unwrapping in their action so we cannot change this behavior.
It's the kind of error that is picked up by a type system


Remove unnecessary "OK"s text settings

AcceptDialogs already have "OK" in their buttons, there's no need to set it again.

Looks good. One thing to check though is whether there aren't occurrences in those files where the OK button's text is set to a different value, and where the set to "OK" would actually be a reset.

@akien-mga Already did.

Great, thanks!


No 32-bit version?

Pleaae publish a 32-bit version.

sorry for not responding...
corrscope should be compatible with 32-bit. but given my current auto-build system, 32-bit support would slow down every build.
maybe only make 32-bit builds for master? releases? idk


"Grey out" entities on selection in Application Vis

The application visualization allows users to select entities and highlight their communication with other classes / packages.
On selection of an entity X, all entities that do not participate in communication with X should be "greyed out". This should be similar to the "greyed out" communication lines on selection.

Looks good with ebd8d14e1bf909b867398809c724a4b3fca2f18e, 7aa2026602f853e85dac86f805684b6ebed6b9e7, a1fdf744ef2f03d32a2cb15ce491303b8f7ea021, 8ef4e136b30bc52276b45a0ce108378fc026eb6e, 30ef78a75c37e73e67244ec26730bdf2baca3573, 8a90d216399e143625c5502b252db2dfdf3f90a4, and 52f7b6c4d3a373df76436bca9b5c5846d5fbf87e


Wrong snap lines are shown on paste

Describe the Bug
When multi-element pasting wrong/confusing snap lines are shown to the user:

Steps to Reproduce

Open test diagram
Copy all elements
Start two-step pasting
See snap lines being shown relative to coordinate origin ? under certain circumstances

Expected Behavior
Snap lines are not shown at all or show next to the diagram.
Environment

OS: Any
Camunda Modeler Version: v3.4.1, v3.5.0

Oh no. 😢

I thought we fixed this one but apparently we did not.

By having a first look, the problem seems to be that we make a calculation error when setting snap origins for connections inside BpmnCreateMoveSnapping.
In the buggy example file:
An origin point set for the connection -> (-428, -221)
An origin point set for the shape mid point -> (20, -10)

I think the solution is to do the same thing that CreateMoveSnapping in diagram-js does, which is to substract the event coordinates from the actual coordinates only if we are moving the shape but not creating it. The solution should be applied to here.


Uncaught SyntaxError: Unexpected token < in JSON

updated: sorry, my fault. I use sync function instead of async because of the docs. Please update the docs from "gmail.get.visible_emails(async)" to "gmail.get.visible_emails_async".
I tried a simple test and got these error.
jquery.js:9488 [Deprecation] Synchronous XMLHttpRequest on the main thread is deprecated because of its detrimental effects to the end user's experience. For more help, check https://xhr.spec.whatwg.org/.
jquery.js:9600 GET https://mail.google.com/mail/u/0/?ui=2&ik=982c4ad31a&rid=undefined&view=tl&num=120&rt=1&start=0&sstart=0&search=data => {
        console.log(data)
    } 404 ()
send @ jquery.js:9600
ajax @ jquery.js:9206
Gmail.api.tools.make_request @ gmail.js:1916
Gmail.api.get.visible_emails @ gmail.js:2144
gmail.observe.on @ test.js:15
(anonymous) @ gmail.js:1848
setInterval (async)
Gmail.api.observe.on_dom @ gmail.js:1844
Gmail.api.observe.on @ gmail.js:1481
(anonymous) @ test.js:9
VM7748:2 Uncaught SyntaxError: Unexpected token < in JSON at position 1
at JSON.parse ()
at Object.Gmail.api.helper.get.visible_emails_post (gmail.js:2108)
at Object.Gmail.api.get.visible_emails (gmail.js:2145)
at gmail.observe.on (test.js:15)
at eval (gmail.js:1848)
my code:
gmail.observe.on("load", () => {
    const userEmail = gmail.get.user_email();
    console.log(userEmail);
    console.log('new data layer', gmail.check.is_new_data_layer());
    console.log('new ui', gmail.check.is_new_gui());

    gmail.get.visible_emails(data => {
        console.log(data)
    });
});

gmail.get.visible_emails is not an sync function.
What you provide as a callback is actually a custom query URL filter which is only meant to be used by expert users. The result is a failed request (HTTP 404), and that does not adhere to the JSON format we expect.
Change your code to the following:
const data = gmail.get.visible_emails();
console.log(data);


Make adapter call a hook when encountering a change for a record that is not yet loaded.

Pouch adapter now calls a hook method when encountering a change for a record that is not yet loaded.

The hook is no-op by default, to match present behavior and performance profile
Added a test demonstrating use of the hook to load the new data into the ember-data store

@lukemelia / @chrislopresto

Hmmm, reading this and trying to understand it (forgive me; I am really weak on EmberData specifics, although I grok Pouch and relational-pouch :smiley:).
I guess what I'm wondering is why we have this early return in the first place. Doesn't this mean that changes from a remote CouchDB will never be loaded into the Ember store? Why don't we just make your commented code the default behavior?
(Side note: it seems like we have a very robust syncing system between PouchDB and CouchDB, but a rather weak one between PouchDB and the in-memory store. In particular, the fact that this syncing logic isn't taking _conflicts or _revisions into consideration worries me a lot. I'm not sure if anything's wrong, but it just seems like a code smell to me.)

@nolanlawson here is the discussion: https://github.com/nolanlawson/ember-pouch/issues/50#issuecomment-86102868

@nolanlawson @fsmanuel yes, my understanding based on the README and the referenced thread was that pushing every new record into the store on arrival was an undesirable for performance reasons. We have a low-volume use case and wanted to make it easier to implement that approach.

@nolanlawson, I know you're busy so here's a summary: the ember-data store is the in-memory cache of records the application has touched during the current session. For records which are already cached, our default change watcher updates the cached copy when they change and removes them from the cache when they are removed from PouchDB. It does not automatically cache new records that arrive because that causes terrible performance during the initial sync with medium-and-up data sizes.
(Re: revisions. The change watcher does not update cached records unless ember-data's state machine believes that the cached record is up to date with PouchDB; see this line. If an in-memory copy has been modified but not saved and simultaneously a sync brings in a new rev of that record, the application's attempt to save it will cause a conflict. The application can then resolve the conflict as it sees fit.
(Similarly for _conflicts: if there are conflicts during replication, it's the responsibility of the app to take care of them in PouchDB directly. When the app resolves them, the change watcher will update any loaded records. If the app ignores _conflicts, I guess that the change watcher would receive changes that reflect the default resolutions, but I haven't tried that myself.)

@lukemelia / @chrislopresto: thanks for this. I have an idea about how to make the adapter act  more naturally with regards to this area, but I haven't had a chance to implement/propose it yet. Your change would not interfere with what I'm thinking of, and it looks like a good interim step.

Thanks for the summary @rsutphin. With respect to the discussion of conflict handling. This seems like it could also be initially addressed by calling a hook with the relevant details that has no-op behavior. i.e. but the power in the hands of the end-user while providing conservative defaults.

@rsutphin Ah okay, that makes a lot more sense then. I look forward to the more complete in-memory mirroring solution (I take it something like this would reproduce exactly the performance problem you describe, for the initial load of a large database?), but for now, if you're +1 on this PR, then I am as well. I'll let you merge it when you're ready. :)

:+1: is there anything that needs to be done to get this merged?

I just wanted to give other contributors time to look at it. I'm +1; I'll merge later today when I get a chance.


Indicate that you may not be prompted to re-authenticate

Why:
This last step is a bit unclear what it means, and can be confusing if you aren't prompted to re-authenticate.
Closes:
Closes #33750

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

[ ] I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).

For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.

[x] For content changes, I have completed the self-review checklist.

@YanisaHS Thanks so much for opening a PR! I'll get this triaged for review ✨

👍

Що я отримала
вт, 30 лип. 2024 р., 11:24 користувач Ben Ahmady @.***>
пише:

@.**** commented on this pull request.
Hi @YanisaHS https://github.com/YanisaHS and thanks for raising a PR 👋
— I've made one small suggestion. If you're happy with it, we can go ahead
and get this merged
In
content/authentication/managing-commit-signature-verification/adding-a-gpg-key-to-your-github-account.md
https://github.com/github/docs/pull/33751#discussion_r1696529210:

@@ -44,7 +44,7 @@ When verifying a signature, {% data variables.product.product_name %} extracts t

In the "Title" field, type a name for your GPG key.
In the "Key" field, paste the GPG key you copied when you generated your GPG key.
Click Add GPG key.
-1. To confirm the action, authenticate to your {% data variables.product.prodname_dotcom %} account.
+1. If prompted, authenticate to your {% data variables.product.prodname_dotcom %} account.

⬇ Suggested change
-1. If prompted, authenticate to your {% data variables.product.prodname_dotcom %} account.
+1. If prompted, authenticate to your {% data variables.product.prodname_dotcom %} account to confirm the action.
—
Reply to this email directly, view it on GitHub
https://github.com/github/docs/pull/33751#pullrequestreview-2206983086,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BG5JK4VK2HPVNPRQYG7SRQTZO5ETDAVCNFSM6AAAAABKAAXCCKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDEMBWHE4DGMBYGY
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Thanks @subatoi! Looks good to me 😄


test(execution): add get_execution_info scenario to test

test(execution): add get_execution_info scenario to test_validate_accounts_tx

This change is

crates/blockifier/src/transaction/transactions_test.rs line 1441 at r1 (raw file):

    if let CairoVersion::Cairo1 = cairo_version {
        // Trying to use the syscall get_block_hash (forbidden).
        // TODO(Arni, 12/12/2023): Test this scenario with the constructor.

We are :)
Code quote:
        // TODO(Arni, 12/12/2023): Test this scenario with the constructor.

crates/blockifier/src/transaction/transactions_test.rs line 1481 at r2 (raw file):

                ]),
                ..default_args
            },

Suggestion:
        let account_tx = create_account_tx_for_validate_test(
            // Calling the syscall get_execution_info and get block_info which was modified for validate.
            nonce_manager,
            FaultyAccountTxCreatorArgs {
                scenario: GET_EXECUTION_INFO,
                contract_address_salt: salt_manager.next_salt(),
                additional_data: Some(vec![
                    StarkFelt::from(CURRENT_BLOCK_NUMBER_FOR_VALIDATE),
                    StarkFelt::from(CURRENT_BLOCK_TIMESTAMP_FOR_VALIDATE),
                    StarkFelt::from(0_u64), // Sequencer address for validate.
                ]),
                ..default_args
            },


Llama3.2-Vision: Add reference submodule and tests

Ticket
#13368
Problem description
The multimodal reference code was not tracked in git. We now have a fork of it we should use as reference code in tests and demos https://github.com/tenstorrent/llama-models/tree/main
What's changed

Add llama-models as a submodule
Move TT multimodal modules and tests into their own folders under models/demos/llama3
Added tests to t3k unit, t3k frequent, and t3k demo. For each pipeline, I run the tests on a 1x2 mesh and a 1x8 mesh.

Checklist

[ ] Post commit CI passes https://github.com/tenstorrent/tt-metal/actions/runs/11500543568
[x] T3k unit, frequent, and demo https://github.com/tenstorrent/tt-metal/actions/runs/11489788982

Llama3 tests failing in demo test due to segfault. Shouldn't have been caused by this PR, will re-run.
rerunning t3k demo: https://github.com/tenstorrent/tt-metal/actions/runs/11500679208

@tt-rkim could you check out .gitmodules to make sure that looks alright?

Looks good
Where are we running the multimodal tests exactly on CI?

Where are we running the multimodal tests exactly on CI?
I'd like to add the multimodal tests to CI after I experiment locally to see if I can tighten up the PCC bounds. I'll make a separate PR to put the tests in CI.

sounds good, so these reference files are not used anywhere in CI currently? Or are they used for other parts of 3.2?

@cglagovichTT Shouldn't this PR also include the tests?
This is the PR that fully includes multimodal llama, so it's good practice to have it all good to go.
But I'm ok with either approach.

Due to popular demand I will add the tests to this PR :)

THANK YOU SIR

I'm encountering an issue where the python packages required in the new submodule llama-models aren't included in the tt-metal python env. The following are required packages:
blobfile
fairscale
jinja2
json-strong-typing
tiktoken
torch
pydantic
pydantic_core

there may be more that we're missing -- I'll check on a clean build. @tt-rkim

@cglagovichTT You should be able to add them to the python env list:
tt_metal/python_env/requirements-dev.txt

Added them. Found that only pydantic and pydantic_core are actually needed to run the tests.

should we still be concerned with this segfault on llama?

should we still be concerned with this segfault on llama?

It seems to be non-deterministic. I am able to repro it on main locally, so it's not an issue specific to this branch.

Think I caught a new issue in my CI run after merging main. https://github.com/tenstorrent/tt-metal/actions/runs/11505869140/job/32029208090
> /home/cglagovich/tt-metal/models/demos/llama3/demo/demo.py(351)run_llama3_demo()
-> trace_id = ttnn.begin_trace_capture(mesh_device, cq_id=0)
(Pdb)
> /home/cglagovich/tt-metal/models/demos/llama3/demo/demo.py(353)run_llama3_demo()
-> decode_input = ttnn.unsqueeze_to_4D(tt_embd(tt_out_tok))
(Pdb)
                 Always | FATAL    | Enqueue Read Buffer cannot be used with tracing
libc++abi: terminating due to uncaught exception of type std::runtime_error: TT_FATAL @ ../tt_metal/impl/dispatch/command_queue.cpp:1902: !this->manager.get_bypass_mode()
info:
Enqueue Read Buffer cannot be used with tracing
backtrace:
 --- /home/cglagovich/tt-metal/ttnn/ttnn/_ttnn.so(+0x3c9038) [0

Checking t3k demo on main: https://github.com/tenstorrent/tt-metal/actions/runs/11507082924

The hang blocking this PR was resolved. https://github.com/tenstorrent/tt-metal/issues/14310#issuecomment-2439770070
A change to reshape uncovered a deadlock in async runtime. The bad commit was reverted, and a fix to runtime is in PR.


Provide a RefreshTaskListener

In order to enable instrumentation around a Refresher's tasks, we need an event-driven model similar to RefreshListener and friends.
Let's add a RefreshTaskEvent and a RefreshTaskListener that gets notified of certain lifecycle events for a task:  startup, shutdown, etc.

punting on this for now, as refresh events seem to cover these cases.


Use ENMASSE_OPENSHIFT as a short-circuit to determine the presence of OpenShift

The Go path already uses this environment variable so it seems reasonable for Java to do the same.

LGTM
An additional place where we are using a check for openshift is in the console, OPENSHIFT_AVAILABLE:

pkg/controller/consoleservice/consoleservice_controller.go
console/console-init/oauth-proxy/bin/init.sh

For consistency, could rename the variable to ENMASSE_OPENSHIFT

I think the use-cases for the two environment variables are different.  ENMASSE_OPENSHIFT is a way for the deployer to tell the EnMasse software it is running under OpenShift, so don't bother use heuristics to detect it yourself.  OPENSHIFT_AVAILABLE is just a Console concern and is a mechanism to get knowledge of the presence of OpenShift over to the client side.   I think conflating the two would be a mistake.


Unable to Run flutter application in Android Virtual Device on Ubuntu Linux

Unable to Run flutter application in Android Virtual Device on Ubuntu Linux

1.Unable to Run flutter application in Android Virtual Device on Ubuntu Linux
2. AVD is working fine
3. Debugging in Chrome Browser is working correctly
4. I have installed Android Studio via Jet brains Toolbox, so flutter doesn't recognise that, but I don't have any issues with it as I use VS Code for Code Editing
@FlutterIssues
Logs

flutter doctor -v
Launching lib/main.dart on sdk gphone x86 in debug mode...
lib/main.dart:1

Exception in thread "main" java.util.zip.ZipException: zip file is empty
	at java.base/java.util.zip.ZipFile$Source.zerror(ZipFile.java:1502)
	at java.base/java.util.zip.ZipFile$Source.findEND(ZipFile.java:1310)
	at java.base/java.util.zip.ZipFile$Source.initCEN(ZipFile.java:1404)
	at java.base/java.util.zip.ZipFile$Source.<init>(ZipFile.java:1209)
	at java.base/java.util.zip.ZipFile$Source.get(ZipFile.java:1172)
	at java.base/java.util.zip.ZipFile$CleanableResource.<init>(ZipFile.java:717)
	at java.base/java.util.zip.ZipFile.<init>(ZipFile.java:237)
	at java.base/java.util.zip.ZipFile.<init>(ZipFile.java:167)
	at java.base/java.util.zip.ZipFile.<init>(ZipFile.java:181)
	at org.gradle.wrapper.Install.unzip(Install.java:214)
	at org.gradle.wrapper.Install.access$600(Install.java:27)
	at org.gradle.wrapper.Install$1.call(Install.java:74)
	at org.gradle.wrapper.Install$1.call(Install.java:48)
	at org.gradle.wrapper.ExclusiveFileAccessManager.access(ExclusiveFileAccessManager.java:65)
	at org.gradle.wrapper.Install.createDist(Install.java:48)
	at org.gradle.wrapper.WrapperExecutor.execute(WrapperExecutor.java:128)
	at org.gradle.wrapper.GradleWrapperMain.main(GradleWrapperMain.java:61)
Exception: Gradle task assembleDebug failed with exit code 1
Exited (sigterm)

### The output of running `flutter doctor -v
[✓] Flutter (Channel beta, 2.0.1, on Linux, locale en_GB.UTF-8)
    • Flutter version 2.0.1 at /home/subhan/snap/flutter/common/flutter
    • Framework revision c5a4b4029c (2 months ago), 2021-03-04 09:47:48 -0800
    • Engine revision 40441def69
    • Dart version 2.12.0

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /home/subhan/Android/Sdk
    • Platform android-30, build-tools 30.0.3
    • Java binary at: /home/subhan/.local/share/JetBrains/Toolbox/apps/AndroidStudio/ch-0/201.7199119/jre/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Chrome - develop for the web
    • Chrome at google-chrome

[✓] Android Studio
    • Android Studio at /home/subhan/.local/share/JetBrains/Toolbox/apps/AndroidStudio/ch-0/201.7199119
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • android-studio-dir = /home/subhan/.local/share/JetBrains/Toolbox/apps/AndroidStudio/ch-0/201.7199119
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)

[✓] VS Code (version 1.56.0)
    • VS Code at /usr/share/code
    • Flutter extension version 3.22.0

[✓] Connected device (2 available)
    • sdk gphone x86 (mobile) • emulator-5554 • android-x86    • Android 11 (API 30) (emulator)
    • Chrome (web)            • chrome        • web-javascript • Google Chrome 90.0.4430.212

• No issues found!

Hi @SubhanRaj
This usually happens when you've unfinished Gradle download (common when Gradle download gets canceled due to network issues or canceled by user) or corrupted Gradle.
To fix the issue you need to first delete the existing Gradle cache and download it again
cd ~
rm -rf .gradle
then run your app, this will take sometime since this is downloading Gradle again, builds will be faster after this
Thank you

Ok, I used (https://gradle.org/install/) to download and then run the following commands to install

cd ~
rm -rf .gradle
mkdir .gradle
cd .gradle
unzip gradle-7.0.1-bin.zip
ls gradle-7.0.2
export PATH=$PATH:~/.gradle/gradle-7.0.1/bin
gradle -v

The Output after this is following

Gradle 7.0.1
Build time:   2021-05-10 16:08:58 UTC
Revision:     67e618faef187783dadd03a34fdab9dc71b85b19
Kotlin:       1.4.31
Groovy:       3.0.7
Ant:          Apache Ant(TM) version 1.10.9 compiled on September 27 2020
JVM:          14.0.2 (Private Build 14.0.2+12-Ubuntu-1)
OS:           Linux 5.8.0-50-generic amd64
But, when I close the terminal once and again run gradle -v, it gives me the following output

Command 'gradle' not found, but can be installed with:
sudo snap install gradle  # version 6.8.3, or
sudo apt  install gradle  # version 4.4.1-12
See 'snap info gradle' for additional versions.

I used the official Gradle installation method given here https://gradle.org/install/
And then added it to path permanently using the following method

Run the command
gedit ~/.profile
Add the line
export PATH=$PATH:/opt/gradle/gradle-7.0.2/bin
to the bottom and save
Log out and log in again

Now gradle -v gives the following output

------------------------------------------------------------
Gradle 7.0.2
------------------------------------------------------------
Build time:   2021-05-14 12:02:31 UTC
Revision:     1ef1b260d39daacbf9357f9d8594a8a743e2152e
Kotlin:       1.4.31
Groovy:       3.0.7
Ant:          Apache Ant(TM) version 1.10.9 compiled on September 27 2020
JVM:          14.0.2 (Private Build 14.0.2+12-Ubuntu-1)
OS:           Linux 5.8.0-50-generic amd64

and after trying to run using F5 now it only shows

Exception in thread "main" java.lang.NullPointerException
at org.gradle.wrapper.BootstrapMainStarter.findLauncherJar(BootstrapMainStarter.java:34)
at org.gradle.wrapper.BootstrapMainStarter.start(BootstrapMainStarter.java:25)
at org.gradle.wrapper.WrapperExecutor.execute(WrapperExecutor.java:129)
at org.gradle.wrapper.GradleWrapperMain.main(GradleWrapperMain.java:61)
Exception: Gradle task assembleDebug failed with exit code 1
Exited (sigterm)

@SubhanRaj
Please use the supported Gradle version, you don't have to install it manually, clear your Gradle cache, simply run your app. Flutter will fetch supported Gradle.
If the issue persists with supported Gradle, please provide complete reproducible steps
Thank you

It's working now, I removed manually installed Gradle, updated my JDK and then allowed Android studio to download the gradle itself, after that now it's running fine.
Thanks, @TahaTesser and @FlutterIssues


Maybe include debug symbols in release builds?

Rust by default removes all debug symbols in release builds. But at some point, we probably have to debug a problem that occurs in production. And with debug symbols, we at least get file locations with our stack traces. (debug = 1 should be sufficient for that.) Given that the only disadvantage is a larger binary (which is not really important for the use cases), we should probably enable debug symbols in release builds.
I will get some specific numbers on the file size in the near future.

We are in the business of dealing with large files anyway ;-P
Larger binaries shouldn't really matter much.

Good point :D
I did some measurements now:

standard debug build: 93 MB
release build (no symbols): 13 MB (a)
release build (no symbols) stripped: 8 MB
release build (debug=1 all deps): 46 MB
release build (debug=1 only tobira): 28 MB (b)
release build (debug=1 only tobira with fat LTO): 19 MB
release build (debug=1 only tobira with fat LTO, codgen-units=1): 18 MB (c)

The bold lines (a), (b) and (c) are relevant options. The first one is the current state: no debug symbols. The second bold line is if we only add debug symbols for our own code, but not our dependencies. The last bold line configures some options to reduce the file size (plus producing slightly faster code) at the expense of compile time (this is only for release builds!). We are talking a compile time (without dependencies) of 11s vs. 1m10s -- quite substantial.
Also note that about 2MB of that file size is just the embedded frontend code (the vast majority of that is just the bundle.js.map, i.e. debug infos :P).
What do you think? I would go with (b) or (c) to get the debug symbols, but I don't really care which one of those two.

Thinking about this for a second, as a packager (at least for RPMs) you would actually build your packages with full build symbols but then strip them and package them separately. I haven't actually looked at how that works (ever) since that happens magically (I have used this quite often). The effect is that you end up with a tool.rpm and a tool-debuginfo.rpm and you get proper stack traces, … if you install the latter. I bet that there are macros for doing that for Rust as well and we don't need to think about this.

Looks like it. They are explicitly prohibiting a debuginfo being built for libraries. They wouldn't do that if it wouldn't be created.
https://docs.fedoraproject.org/en-US/packaging-guidelines/Rust/


Implicit narrowing conversion might create trouble

queued_dedent_count has type uint32_t whereas buffer has type char*, so you'll wrap around for deeply indented code.
https://github.com/tree-sitter/tree-sitter-agda/blob/59cefa7bd5df94063a4a352eb363548031937a6e/src/scanner.cc#L23
This line has a similar problem where uint16_t will get narrowed to char, so non-ASCII characters will be misrepresented.
https://github.com/tree-sitter/tree-sitter-agda/blob/59cefa7bd5df94063a4a352eb363548031937a6e/src/scanner.cc#L29
Maybe I'm grossly misunderstanding something -- the example in the Readme does show non-ASCII symbols and somehow it has been working fine?

Thanks for reporting this!
I'm not quite sure what non-ASCII characters got misrepresented means, could you please provide some screenshot to show what's happening?
The example in the Readme has been working fine for me.

Ah! Okay, I was misreading. Sorry for the false alarm. The problem is only with indentation, because you're only saving indentation values to the buffer, never actual characters. Say you have code which has
foobar = do
  -- depth = 2
  print "Blah"
  -- depth = 130
                                                                                print "Blep"

This is going to make the parser think that they're both at the same indentation because char is (almost always) 8 bits (Here's a simplified godbolt example which shows this wrap around behaviour.). I don't fully understand what the resulting SExp means though
(source_file [0, 0] - [3, 0]
  (function_clause [0, 0] - [3, 0]
    (lhs [0, 0] - [0, 6]
      (atom [0, 0] - [0, 6]
        (qualified_name [0, 0] - [0, 6])))
    (rhs [0, 7] - [3, 0]
      (expr [0, 9] - [3, 0]
        (do [0, 9] - [3, 0]
          (do_stmt [1, 2] - [2, 141]
            (atom [1, 2] - [1, 7]
              (qualified_name [1, 2] - [1, 7]))
            (atom [1, 8] - [1, 14]
              (literal [1, 8] - [1, 14]))
            (atom [2, 129] - [2, 134]
              (qualified_name [2, 129] - [2, 134]))
            (atom [2, 135] - [2, 141]
              (literal [2, 135] - [2, 141]))))))))

I guess this is not a problem in practice because people don't generate Agda code (do they?), so the indentation level isn't going to exceed 128, but it might cause issues if you do get that kind of code.

I see, but IFAIK there are also other problems regarding the scanner and indentation.
We need this customized scanner because we cannot handle indentation in the parser.
But I've only managed to make the scanner semi-functional because my C programming was so bad. That's why it's so buggy when it comes to indentation.
the indentation rules of Agda should be very similar to that of the Haskell, but can't just copy their scanner because it has some termination issue. So the scanner we are using now was adapted from the python one.

Understood. I bumped across this because I was writing a similar scanner. I've already fixed this in the code I'm working on. Do you have time to review a PR? I can submit a patch to fix this issue.
Of course, that won't fix the other issues with the scanner but hey, at least it is something.

That would be really helpful!

@theindigamer sorry having to bug you about this, but the CI build is mysteriously failing on Linux, which didn't happen on your pull request. Is there anything I should be aware of?

The problem seems to be that the compilation command needs to be given a flag to understand that it should be compiling with C++11 features. I wonder why the CI didn't fail earlier. I don't have time right now to look into it more but I'll get back to you within ~12 hours.

Thanks a lot!!


Subsequent requests by curl through tsproxy are significantly faster.

Initially discussed in issue 18, but this still seems odd.
Steps to reproduce:

Start tsproxy with fixed latency. e.g.
python tsproxy.py --rtt=100

Make an http request with curl through tsproxy, logging time spent. e.g.
curl -w "%{time_total}\n" -o /dev/null https://www.example.com --socks5-hostname <IP_ADDRESS>:1080

Continue to repeat the http requests through curl, noting how long they take to complete.

For the first request I'm seeing results like ~0.643 seconds.
Subsequent requests complete in ~ 0.548 seconds.
So about 100ms faster, which is a lot considering that's the total rtt that I set.
I see the same results on MacOS (10.13.6) and on Windows 10.
I don't believe this is caused by the OS DNS cache because:
• I've tried resetting the DNS cache on both OS's (after step 2) and I see the same results
• If I stop and then restart tsproxy the next request is always "slow", followed by "fast" ones. The DNS cache shouldn't have been flushed in this case.
• Curl attributes the time reduction to "time_connect - start until the TCP connect to the remote host (or proxy) was completed", but not time_namelookup
I noticed that it's the first request to a given url that's slow.
So first instance my first request to http://www.example.com will be slow. Subsequent ones will be faster.
With the same tsproxy session running, my first request to http://www.google.com will be slow. Subsequent ones will be faster.
Happens with http and https urls.
Any ideas?

If you run tsproxy with -vvvv it should dump a detailed log of all of the packet flows and connection setups which should make it easy enough to see where the 100ms difference is coming from.
tsproxy has its own DNS cache which is likely causing the difference. It should be easy enough to add a flag to disable the internal dns cache though it will introduce variability from going to the OS/network for repeated DNS lookups.

Actually, I wonder if the cached DNS lookup is bypassing the added latency for a real DNS lookup which is why it is right around the latency.  In addition to adding an option to disable the cache I will check to make sure the cached results get the added 1RTT

Actually, the cache is there on purpose because usually the browser (or other client) will cache the DNS lookup internally and only do 1 DNS lookup regardless of the number of connections. With a socks 5 proxy it passes the name directly and relies on the proxy to do the DNS lookups.  If I added the delay to all of the subsequent DNS lookups then it would behave differently from how browsers normally operate.
What I can do is flush the DNS cache after 1 second of no activity after the last client disconnects (and also flush it as part of the flush command) which should be a happy medium (in addition to the flag to disable the cache which I just pushed)

Thanks for the explanation and the great logging.
I do see that on my first connect the DNS resolution block introduces the time delay.
Having the option to disable the DNS cache is a good addition.
Personally I'm not in favor of flushing the DNS cache after a fixed amount of time since I feel like it may introduce nondeterminism into some test scenarios.

I added the auto flushing but I can also make that optional....one sec

OK, the auto flushing is disabled by default and just enabled if you pass -f

Thank you! Happy to close this one.


Can't install using Carthage

When trying to build your framework using Carthage, I get the following error:

Dependency "InstagramLogin" has no shared framework schemes

Full Terminal output:

carthage update
*** Fetching InstagramLogin
*** Checking out InstagramLogin at "v1.2.0"
*** xcodebuild output can be found in /var/folders/rx/jxm8sgs10tb0d3b3ndvpgygw0000gn/T/carthage-xcodebuild.cNZPbK.log
*** Skipped building InstagramLogin due to the error:
Dependency "InstagramLogin" has no shared framework schemes
If you believe this to be an error, please file an issue with the maintainers at https://github.com/AnderGoig/InstagramLogin/issues/new

My Cartfile only has this single line:
github "AnderGoig/InstagramLogin"

Thanks for notifying me! Should be fixed in v1.2.1


refactor(compaction): decouple compactor struct with compactor context

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
as title

Checklist

[ ] I have written necessary rustdoc comments
[ ] I have added necessary unit tests and integration tests
[ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features #7934).
[ ] My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
[ ] All checks passed in ./risedev check (or alias, ./risedev c)
[ ] My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)

[ ] My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

[ ] My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Close as https://github.com/risingwavelabs/risingwave/pull/12020 is more reasonable


Use correct/updated tokens.json file

Should use this: https://github.com/AlphaWallet/alpha-wallet-ios/pull/4470/files

Updated https://github.com/AlphaWallet/TokenTest, which is a mirror of your updated file.
This will be removed once the maintained list is ready.


AP Issue

I have applied the earlier fix but still no AP is coming up. Below is the o/p I am getting from my Kali VM
[I] Writing config file...
[I] Configuring AP interface...
[I] Applying iptables rules...
[?] Set speed limit for the clients? Y/n: n
[I] Skipping...
[?] Start WIRESHARK on wlan0? Y/n: n
[?] Capture packets to .pcap with TSHARK? (no gui needed) Y/n: n
[?] Spoof DNS manually? y/N: N
[I] Starting DNSMASQ server...
[I] Starting AP on wlan0 in screen terminal...
[I] Starting DRIFTNET...
TAIL started on /root/mitmAP/logs/mitmap-sslstrip.log...
Wait for output... (press 'CTRL + C' 2 times to stop)
HOST-s, POST requests and COOKIES will be shown.
[I] Restarting tail in 1 sec... (press 'CTRL + C' again to stop)

Had you said "n" at the WPA password question?

certainly and my hostapd is also the newest version.
Upon pressing CTRL+C, it tells that no session was found.
What should I do?

Meanwhile, I installed it last friday and since then didn't clone your git repo. So if you did any modification in the mean time, it shouldn't be reflected in my case.
Secondly, I put "n" straight forward when the script asked whether I want to use WPA2 only to disable this WPA option as far as your earlier discussion is concerned , so WPA password question option didn't come.

Can you send me please your /etc/hostapd.conf file?
Also start it manually with this command:
"sudo hostapd /etc/hostapd/hostapd.conf"
And send me the error what this gives as well.

Below is error msg
hostapd /etc/hostapd/hostapd.conf
Configuration file: /etc/hostapd/hostapd.conf
nl80211: Could not configure driver mode
nl80211: deinit ifname=wlan0 disabled_11b_rates=0
nl80211 driver initialization failed.
wlan0: interface state UNINITIALIZED->DISABLED
wlan0: AP-DISABLED
hostapd_free_hapd_data: Interface wlan0 wasn't started

content of hostapd.conf
interface=wlan0
driver=nl80211
ssid=TestingAP
hw_mode=g
channel=11
macaddr_acl=0
auth_algs=1
ignore_broadcast_ssid=0

Its something to do with your virtual machine. If you are running this on a virtual machine, maybe you should consider trying on a booted kali (e.g. from usb), or use a usb wireless adapter and connect it properly vm.
What wireless card are you using? Maybe there is a problem with the drivers.

I am using alpha card as wireless interface whereas ethernet the internet facing interface.

Are you running it in a virtual machine, or you have kali fully booted?

I am running it inside VM. But in case of fully booted Kali, the problem remains the same that no AP is coming up.

Its possible that something is using the wireless card in the background. Try killing all of the wireless-type processes with airmon-ng, and  after it try running hostapd manually again.

airmon-ng check kill

hostapd /etc/hostapd/hostapd.conf

I think its a bug of Kali :(
https://bugs.kali.org/view.php?id=3751
error I am getting
root@Attacker:~# hostapd /etc/hostapd/hostapd.conf
Configuration file: /etc/hostapd/hostapd.conf
nl80211: Could not configure driver mode
nl80211: deinit ifname=wlan0 disabled_11b_rates=0
nl80211 driver initialization failed.
wlan0: interface state UNINITIALIZED->DISABLED
wlan0: AP-DISABLED
hostapd_free_hapd_data: Interface wlan0 wasn't started

@beeprime Is this bug fixed by now? Can you please try running mitmAP again after a full dist upgrade:
sudo apt-get update && sudo apt-get dist-upgrade -y

Closing issue because of no reply from OP.

FWIW I have exactly the same issues as the original poster - tried all the suggestions in this thread and none have worked.

@derrabe Can you start hostapd manually?
`sudo hostapd /etc/hostapd/hostapd.conf'

Hi,
Nope - I ran airmon-ng check kill first, then hostapd /etc/hostapd/hostapd.conf and got:
hostapd /etc/hostapd/hostapd.conf
Configuration file: /etc/hostapd/hostapd.conf
nl80211: Could not configure driver mode
nl80211: deinit ifname=wlan0 disabled_11b_rates=0
nl80211 driver initialization failed.
wlan0: interface state UNINITIALIZED->DISABLED
wlan0: AP-DISABLED
hostapd_free_hapd_data: Interface wlan0 wasn't started

Also, I ran apt-get update && apt-get dist-upgrade a couple of hours ago, so things should be up to date:
Linux kali 4.9.0-kali1-amd64 #1 SMP Debian 4.9.6-3kali2 (2017-01-30) x86_64 GNU/Linux
When running mitmap.py, when it gets to the stage of:
[?] Please enter the name of your wireless interface (for the AP): wlan0
[?] Please enter the name of your internet connected interface: eth0
[I] Backing up NetworkManager.cfg...
[I] Editing NetworkManager.cfg...
[I] Restarting NetworkManager...

it seems to drop the wlan0 interface (i.e. its no longer visible from an ifconfig)

Can you bring it back up and after it start hostapd?
ifconfig wlan0 up
Also what wifi card are you using? (model, manifacturer)

That gave the same result.
The card is an Alfa AWUS036H. I also tried it with an Alfa AWUS036NEH and had the same result.


[e2e]: go tag main config-ldflags-assets slsa3

Repo: https://github.com/slsa-framework/example-package/tree/v13.0.117
Run: https://github.com/slsa-framework/example-package/actions/runs/3247392253
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.go.tag.main.config-ldflags-assets.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.go.tag.main.config-ldflags-assets.slsa3.yml
Trigger: push
Branch: v13.0.117
Date: Fri Oct 14 04:16:36 UTC 2022

Repo: https://github.com/slsa-framework/example-package/tree/v13.0.118
Run: https://github.com/slsa-framework/example-package/actions/runs/3252015098
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.go.tag.main.config-ldflags-assets.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.go.tag.main.config-ldflags-assets.slsa3.yml
Trigger: push
Branch: v13.0.118
Date: Fri Oct 14 18:31:54 UTC 2022

Repo: https://github.com/slsa-framework/example-package/tree/v13.0.119
Run: https://github.com/slsa-framework/example-package/actions/runs/3252441453
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.go.tag.main.config-ldflags-assets.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.go.tag.main.config-ldflags-assets.slsa3.yml
Trigger: push
Branch: v13.0.119
Date: Fri Oct 14 19:35:44 UTC 2022
Tests are passing now. Closing this issue.


Deploy

This deploy contains the following PRs:

@starsirius: Refactored partnerships page to use JSON page component (#1468 by @craigspaeth)
@damassi => responsive submission flow (#1507 by @sweir27)
@kanaabe => Use indexable for noindex meta tag (#1502 by @eessex)
@eessex => [Venice] Email fields + Social share fix (#1506 by @kanaabe)
@mzikherman: add item_id to search result analytics (#1508 by @xtina-starr)
@craigspaeth => Check-in ArtsyOpenSource token for Danger (#1511 by @mzikherman)
@yuki24: Moves the hover and focus styles to the inputs container (#1505 by @xtina-starr)
@mzikherman: Restores marketing signup modal for mobile (#1500 by @xtina-starr)
@kanaabe => Follow button bug (#1503 by @eessex)
@joeyAghion => Remove fragment metatag on article (#1501 by @kanaabe)

  Generated by :no_entry_sign: Danger


What unit does your language server use in lsp ranges?

Does this project use UTF-8, UTF-16, codepoint, or grapheme cluster indexes for lsp ranges?
I am conducting a survey to inform the debate over what unit ranges should use in the Language Server Protocol.
The debate is occuring in issue #376.

This implementation currently uses UTF-8

@nadeeshaan thanks


Added lectures 6 and 7 -- Vinay

Thanks. It would be great if you could have code and formulas as code and latex, not as images. That makes it easier for people to copy & paste code or for me to change something.
You can just copy the code from the notebook.

https://github.com/amueller/COMS4995-s18/commit/2c808e063f01571f69d8d8b615eb89872a47d0cd


feat(fiatconnect): check KYC on return user flow

Description
Checks if KYC is required on return user flow and if required, only go to Review screen if KYC is approved. If KYC is not created, go to select provider, otherwise to the appropriate KYC status screen. The KYC handling on handleAttemptReturnUserFlow is very similar to handleSelectFiatConnectQuote, but different enough for them to be in separate sagas.
Few things that are different:

handleAttemptReturnUserFlow fetches quote and fiat account in parallel to check for a match before checking KYC, handleSelectFiatConnectQuote gets quote as input, checks KYC first and then checks for fiat account
handleAttemptReturnUserFlow navigates to KYC pending screen immediately if KYC is pending whereas handleSelectFiatConnectQuote may navigate to fiat account details screen
handleAttemptReturnUserFlow navigates to select provider screen if KYC is not created with the provider, whereas handleSelectFiatConnectQuote navigates to Persona

Other changes
N/A
Tested
Unit tests
How others should test
Not ready for testing since first time KYC flow isn't complete
Related issues

Fixes ACT-386

Backwards compatibility
Yes

Hey @MuckT since NA is mentioned in how other should test section ,we are skipping this PR
CC: @satish-ravi
Thanks.!


Data quirks

Depends on #35 being merged first.
Removal of data quirk handling introduced before the release of global tool version.
Handles points 1, 2 and 3 from https://github.com/nismod/infra-risk-vis/issues/161

tests to check that the backend data has been correctly updated:
in feature property names (damages):

"historical" substring doesn't appear in property names - only "baseline"
"rcp_rcp", "rcp_historical" substring doesn't appear in property names - in infrastructure datasets
"epoch_2020", "epoch_1980", "epoch_present" don't appear in property names

Consider fixing the quirks also in adm0_exposure - to find this and other leftovers, search for "TODO: quirks"


List the dependencies in sorted order when building firebase app

Will be helpful to show dependencies for the firebase app sorted by npm & lib groups and alpha sorted within each group.
For bonus points show a tick when copying the lib deps.

added in v0.3.3


Redesign list of offers

Closes #102

Build failuje na Vercelu s touhle chybou:
info  - Checking validity of types...
--
14:19:07.613 | Failed to compile.
14:19:07.613 |
14:19:07.613 | ./components/MainNav.tsx:101:10
14:19:07.613 | Type error: Property 'fillColor' is missing in type '{}' but required in type '{ fillColor: string; }'.
14:19:07.613 |
14:19:07.613 | 99 \| 								onClick={() => setIsOpen(false)}
14:19:07.613 | 100 \| 							>
14:19:07.614 | > 101 \| 								<CloseIcon />
14:19:07.614 | \| 								 ^
14:19:07.614 | 102 \| 							</div>
14:19:07.614 | 103 \| 							<NavLinks
14:19:07.614 | 104 \| 								showHome
14:19:07.637 | Error: Command "npm run build" exited with 1


Expand the ability to use internal data

Similar to the solution in this blog (https://tech.deliveryhero.com/employeegpt-leveraging-ai-for-internal-knowledge-discovery/), we can enable anyone at tomtom to quickly answer questions from the internal sources such as

What POI categories do we have? What are the mandatory attributes?
How many roads are covered in Germany in our map?
These and similar trivial questions are often asked by non-tech customer facing teams and steal time of the development teams answering them because customer-facing teams are not equipped with easy to use tools.

We are working on seeing how/if we can integrate AI tooling with our internal knowledge systems. This is however a feature of the deployed model; not of Chatty. Hence closing this feature request. Please feel free to contact CCOE in TomTom for this as well.


Unaligned Icons on API 23

On my Nexus 5 with Android 6.0 the top of some icons is cut-off
(the icons left of Vor 2 Stunden)

On api 15 everthing seems to work fine


[./bin/test] Allow skipping clone of swift-docc and swift-docc-render-artifact

From https://github.com/apple/swift-docc-plugin/pull/21#discussion_r929419898
In some scenarios, running swift-docc-plugin tests against the built-in docc in the installed toolchain could save time. Add an option to ./bin/test to skip cloning swift-docc and swift-docc-render-artifact and setting the environment variables to use those.
Behavior:
If --skip-building-upstream-docc (or perhaps an environment variable) is set:

Don't set the following:

SWIFT_DOCC_ROOT
SWIFT_DOCC_RENDER_ARTIFACT_ROOT
SWIFT_DOCC_BRANCH
SWIFT_DOCC_RENDER_ARTIFACT_BRANCH

Don't clone swift-docc or swift-docc-render-artifact
Also don't set:

DOCC_EXEC
DOCC_HTML_DIR

See the above mentioned pull request for new code that should be skipped in this case.

Hi @bitjammer, can I work on this? I went through the mentioned PR and I now have a clear idea on what needs to be done.

Of course, that’s why it’s here! Thank you for taking it on. Please have a go and let me know if you have any questions.

Hi @bitjammer, I raised a PR. I used the approach to use an env variable. Hope that's fine.

Hi @bitjammer, just sending a little nudge to bump up the PR in your inbox. Thanks.

Thank you! I will have a look at this today.

Nice work @A-N-uraag, thank you.


patch-polishing

Some polish items based on feedback from Forge Utah community. Obviously more to come.

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Redis cache invalidates unchanged models

First, thanks for this awesome package. This is more then cool! This is awesome :)
I have developed a product database and have a lot of different product relations and i am using redis as cache. When i am changing a product it seems to invalidate a lot o models. Example.

i go to a category
276 queries runs first time then just 2 queries
I change a relation to a product that is not in that particular category
Refresh and 243 queries runs first time

is this an expected behavior? or am i missing something?

Hi @dalholm, that is expected functionality. The cache will invalidate by model, not be instance, so if once category changes, all categories will be invalidated.


Expanding a bit the README

tradeoffs vs dfdx typed shapes

100% I definitely want to give a hat's off to dfdx and mention it, and why we though another library was worth it.


Infinite loop to change password after user creation and first login

Version: OSCM 18.0
Browser: Chrome
Country: BG
Actual >(wrong) behaviour:

create a new user
login as the new user with pwd from mail
user changes pwd in change dialog
pwd is changed but user asked to change pwd again and again (inifinite loop)

workaround: close browser completely and login again

system.log
system.log

tested okay with build from 13/09/2019

portal: register new user, new organization
marketplace. add user

tested with firefox and chrome

@uhu133
The fix release OSCM 18.0.2 is available DockerHub. Just pull all servicecatalog/oscm-* images with tag latest.


Add SKIP_GO_SPECIFIC_TRACERS config option

Quick option to allow using a Go test server to test httpfltr.

Codecov Report

Merging #228 (a17e6db) into main (b4841e4) will decrease coverage by 42.71%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##             main     #228       +/-   ##
===========================================
- Coverage   80.65%   37.95%   -42.71%
===========================================
  Files          37       35        -2
  Lines        3066     2951      -115
===========================================
- Hits         2473     1120     -1353
- Misses        442     1765     +1323
+ Partials      151       66       -85

Flag
Coverage Δ

integration-test
?

unittests
37.95% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed
Coverage Δ

pkg/internal/ebpf/common/common.go
0.00% <ø> (-62.50%)
:arrow_down:

pkg/internal/ebpf/tracer.go
0.00% <0.00%> (-67.22%)
:arrow_down:

... and 28 files with indirect coverage changes


Protocol Fees (Set to 20%)

This is the implementation for incorporating the fees that will be reserved for protocol usage. The commission collected can be used for incentivising different stakeholders. The current fees is set to 20 % and hard coded to take into account the format of decimals in solidity language. This code only aims to hold back the commission and does not show how to utilise or withdraw it from the contract at the moment. The issue for the same can be found at https://github.com/vacp2p/rfc/issues/485

Also, following our call, please create an issue for passing the fee percentage as a constructor argument (instead of being hardcoded).

@staheri14 The protocol fees setting via constructor issue can be found at https://github.com/vacp2p/rln-contract/issues/8

Closing this PR as tokenomics hasn't been allotted to rlnp2p, yet


ffmpeg 3.0 support

Add support for linking opencv with ffmpeg 3.0.

@alalek VP8/VP9 support and ffmpeg changes did not make it into 3.1.0?

Brainfart! Haha.. disregard that, I thought there was new major release but it was only a maintenance release for 2.4.x series.


Reproducible download of stationdata

I downloaded the zips from the endpoint (which tubeulator should likewise be able to do… but actually doesn’t, presumably because the names for StopPoint are hardcoded and stationdata is discarded?)

Get that schema codegen’d
Add a step that reproducibly calls the downloaders and then receives the data and stores it, unpacks it, and renames as needed to fit the existing format (I think gtfs was .txt suffixed and I changed to .csv, the detailed dataset was fine)

https://github.com/lmmx/tubeulator/blob/master/src/tubeulator/data/stationdata/gtfs/
https://github.com/lmmx/tubeulator/blob/master/src/tubeulator/data/stationdata/detailed/

This could then be extended to do things like make a graph of the network

So previously we only cared about the components/schemas path in the schema, whereas here the schema doesn't have any, it has paths which indicate where to go pull stationdata datasets from
(tubeulator) louis 🚶 ~/dev/tubeulator $ tubeulator populate
> /home/louis/dev/tubeulator/src/tubeulator/utils/paths.py(60)load_endpoint_component_schemas()
-> endpoint_schema = load_endpoint_schema(schema_name)
(Pdb) n
> /home/louis/dev/tubeulator/src/tubeulator/utils/paths.py(61)load_endpoint_component_schemas()
-> component_schemas = endpoint_schema["components"].get("schemas", {})
(Pdb) n
> /home/louis/dev/tubeulator/src/tubeulator/utils/paths.py(62)load_endpoint_component_schemas()
-> return component_schemas
(Pdb) pp endpoint_schema
{'components': {'securitySchemes': {'apiKeyHeader': {'in': 'header',
                                                     'name': 'app_key',
                                                     'type': 'apiKey'},
                                    'apiKeyQuery': {'in': 'query',
                                                    'name': 'app_key',
                                                    'type': 'apiKey'}}},
 'info': {'description': '', 'title': 'Station Data', 'version': '1.0'},
 'openapi': '3.0.1',
 'paths': {'/tfl-stationdata-detailed.zip': {'get': {'description': 'TfL '
                                                                    'station '
                                                                    'data '
                                                                    'detailed',
                                                     'operationId': 'detailed',
                                                     'responses': {'200': {'description': ''}},
                                                     'summary': 'TfL station '
                                                                'data '
                                                                'detailed'}},
           '/tfl-stationdata-gtfs.zip': {'get': {'description': 'TfL station '
                                                                'data gtfs '
                                                                'files',
                                                 'operationId': 'gfts',
                                                 'responses': {'200': {'description': ''}},
                                                 'summary': 'TfL station data '
                                                            'gtfs'}}},
 'security': [{'apiKeyHeader': []}, {'apiKeyQuery': []}],
 'servers': [{'url': 'https://api.tfl.gov.uk/stationdata'}]}

It would make sense to populate these into Pydantic models now


Unable to docker pull bde2020/hive

Expected behavior
Able to pull bd2020/hive
Actual behavior
Not able to pull bde2020/hive
Information about the Issue
On the terminal, I see
f5eedb46fcd1: Downloading
dial tcp: i/o timeout

Steps to reproduce the behavior

On terminal docker pull bde2020/hive
On Kitematic "create" bde2020/hive

if the terminal is unable to pull the image, Kitematic will have a similar issue.
Are you behind a firewall or VPN?
See our wiki for possible solutions:
https://github.com/docker/kitematic/wiki/Common-Proxy-Issues-&-Fixes

Uninstalling and installing Docker for mac beta worked.
Thank you.


allow configurable region name

What this PR does / why we need it:
Configuration region-name to avoid get_bucket_location API calls, some users
may have restricted policies, thus allow for these situations.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

/ok-to-test

Nice fix! Thanks!

Nice fix! Solved our issue.
Our issue was that KFServing gets access denied error when downloading the model from bucket using Minio client. Turned out that we don't have get_bucket_location access. This will avoid similar issue

thanks @harshavardhana for the prompt fix!

/lgtm
/approve


Define New Extension Domain Schema

Need to convert BCO data into Linked Data Hub format for users of LDH.

Define a schema to represent BCO data

Use https://ldh.clinicalgenome.org/ldh/ui/api-docs to find the relevant fields
Map fields from BCO to fields in LDH
Find a "catch all" field for BCO fields that don't map well (BCO is for workflows and LDH is for data, so there will be many)

Write a conversion script that will take BCO data and convert it into LDH-ready format

This may be hosted as an API endpoint on the BioCompute server so data can be requested programmatically

This is part of the CFDE project.

https://github.com/biocompute-objects/extension_domain

@HadleyKing  to review example BCO, and @tiwa1154  to add exemplar BCOs.

@NiramishCuisine Can you please add your linked data hub schema and example file to the repo?

Continuation plan in case I'm gone. Once we have the schema and the example BCO:

Host publicly accessible schema on server
Add example BCO to Portal
Add documentation to Wiki for both
Submit to Jeet for review

@HadleyKing
Schema file is here:
https://github.com/biocompute-objects/linked-data-hub/blob/master/linked-data-hub-schema.json
Example file is here:
https://github.com/biocompute-objects/linked-data-hub/blob/master/result.json
This is what we need.


Sign compare warning fixes batch 1

warning ids: [ 28, 29, 30, 31, 32, 33, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 50, 81, 82, 83, 84, 85, 86, 87, 88, 89, 90, 91, 92, 94, 95, 96, 97, 98, 99 100, 101, 102, 103 ]
@mihaimaruseac

I changed quantization_config.cc because it failed the build.
@joker-eph

@joker-eph


[BUGs, GoodCollective] Starting and stopping stream using Celo

Starting and stopping stream using Celo, a few issues:

0:11 - Starting swap and stream: Metamask launched to start the swap BEFORE I see the modal.
1:33 - Had to click the "Confirm" button again after swap to get the Stream transaction to start.
2:31 - unable to stop donation stream (keeps crashing metamask). I'm still blocked on this - about to try from Superfluid Dapp

https://gooddollar.slack.com/archives/C07RRC4NQTY/p1733769902866939?thread_ts=1733767326.289819&cid=C07RRC4NQTY
https://gooddollar.slack.com/files/U05U2ULLL0L/F083WK3C5P1/screenrecording_12-09-2024_12-39-36_1.mp4
suggestions - https://gooddollar.slack.com/archives/C07RRC4NQTY/p1733770464035859?thread_ts=1733767326.289819&cid=C07RRC4NQTY

@vldkhh can you please try to reproduce before I prioritize?

@vldkhh

verified on prod


[QBD] Import settings main page

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/49702
PROPOSAL:
Tests

Prerequisites:

Turn on Beta quickbooksDesktopOnNewDot on your account
Connect your workspace to QBD in OldDot. (Help doc)

Sign in on an account above
Go to any Workspace -> Accounting
Click on "Import" menu under QuickBooks Desktop connection
Verify it opens Import settings main page
Verify it displays 4 menu items: "Chart of accounts", "Classes", "Customers/projects" and "Items"

[x] Verify that no errors appear in the JS console

Offline tests

Same as above
QA Steps

Same as above

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/user-attachments/assets/021df66b-42eb-4adb-a004-8df9137bfafd

Android: mWeb Chrome

https://github.com/user-attachments/assets/37f434f0-67b9-4e4d-9774-b6e94876ffc8

iOS: Native

https://github.com/user-attachments/assets/b2e4cd9d-47f4-4842-bddb-24ba5f10b925

iOS: mWeb Safari

https://github.com/user-attachments/assets/32c7d470-5c1d-44fb-8a95-65f80f7f564d

MacOS: Chrome / Safari

https://github.com/user-attachments/assets/0703c3d7-5a72-4cd2-b376-137fcd6b458c

MacOS: Desktop

https://github.com/user-attachments/assets/074c1913-09e6-4ee4-9871-9ff42cbc9de0

I think it is better to ask the internal engineer to assign the C+ to the concerned issue before making the PR ready for review if it had already been decided which C+ would review the PR.
As far as practicable we can avoid disturbing the auto assigner queue. 😃

Or just add me to the QBO project as well because that is what the Auto Assigner Overlord seems to be asking. 😆

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@mountiny @c3024 @lakchote Applause QA team does not have QBD credentials. Could this be verified internally?

Seeing as this is behind a beta I am going to assume we will test it before removing the beta and so it can be checked off.

@mountiny @c3024 @lakchote Applause QA team does not have QBD credentials. Could this be verified internally?

You'll be using the credentials that will be stored in 1P in the QA vault.
cc @mallenexpensify @kadiealexander

@m-natarajan tagging you too :)

You'll be using the credentials that will be stored in 1P in the QA vault.


RuntimeError in shot_term_forecast/PEMS script

Encountered the following error running the bash ./scripts/short_term_forecast/PEMS/TimeMixer.sh.
OS: MacOS 12.7.6
Python version: 3.12.2 (pyenv)
PyTorch: 2.2.2
CPU: intel
>>>>>>>start training : long_term_forecast_PEMS03_none_TimeMixer_PEMS_sl96_pl12_dm128_nh4_el5_dl1_df256_fc3_ebtimeF_dtTrue_Exp_0>>>>>>>>>>>>>>>>>>>>>>>>>>
data file: ./dataset/PEMS/PEMS03.npz
train 15617
data file: ./dataset/PEMS/PEMS03.npz
val 5135
data file: ./dataset/PEMS/PEMS03.npz
test 427
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/Users/jx/.pyenv/versions/3.12.2/lib/python3.12/multiprocessing/spawn.py", line 122, in spawn_main
    exitcode = _main(fd, parent_sentinel)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/jx/.pyenv/versions/3.12.2/lib/python3.12/multiprocessing/spawn.py", line 131, in _main
    prepare(preparation_data)
  File "/Users/jx/.pyenv/versions/3.12.2/lib/python3.12/multiprocessing/spawn.py", line 246, in prepare
    _fixup_main_from_path(data['init_main_from_path'])
  File "/Users/jx/.pyenv/versions/3.12.2/lib/python3.12/multiprocessing/spawn.py", line 297, in _fixup_main_from_path
    main_content = runpy.run_path(main_path,
                   ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "<frozen runpy>", line 286, in run_path
  File "<frozen runpy>", line 98, in _run_module_code
  File "<frozen runpy>", line 88, in _run_code
  File "/Users/jx/ProgramData/git/TimeMixer/run.py", line 157, in <module>
    exp.train(setting)
  File "/Users/jx/ProgramData/git/TimeMixer/exp/exp_long_term_forecasting.py", line 132, in train
    for i, (batch_x, batch_y, batch_x_mark, batch_y_mark) in enumerate(train_loader):
                                                             ^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/jx/.pyenv/versions/venv_3.12.2/lib/python3.12/site-packages/torch/utils/data/dataloader.py", line 439, in __iter__
    return self._get_iterator()
           ^^^^^^^^^^^^^^^^^^^^
  File "/Users/jx/.pyenv/versions/venv_3.12.2/lib/python3.12/site-packages/torch/utils/data/dataloader.py", line 387, in _get_iterator
    return _MultiProcessingDataLoaderIter(self)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/jx/.pyenv/versions/venv_3.12.2/lib/python3.12/site-packages/torch/utils/data/dataloader.py", line 1040, in __init__
    w.start()
  File "/Users/jx/.pyenv/versions/3.12.2/lib/python3.12/multiprocessing/process.py", line 121, in start
    self._popen = self._Popen(self)
                  ^^^^^^^^^^^^^^^^^
  File "/Users/jx/.pyenv/versions/3.12.2/lib/python3.12/multiprocessing/context.py", line 224, in _Popen
    return _default_context.get_context().Process._Popen(process_obj)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/jx/.pyenv/versions/3.12.2/lib/python3.12/multiprocessing/context.py", line 289, in _Popen
    return Popen(process_obj)
           ^^^^^^^^^^^^^^^^^^
  File "/Users/jx/.pyenv/versions/3.12.2/lib/python3.12/multiprocessing/popen_spawn_posix.py", line 32, in __init__
    super().__init__(process_obj)
  File "/Users/jx/.pyenv/versions/3.12.2/lib/python3.12/multiprocessing/popen_fork.py", line 19, in __init__
    self._launch(process_obj)
  File "/Users/jx/.pyenv/versions/3.12.2/lib/python3.12/multiprocessing/popen_spawn_posix.py", line 42, in _launch
    prep_data = spawn.get_preparation_data(process_obj._name)
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/jx/.pyenv/versions/3.12.2/lib/python3.12/multiprocessing/spawn.py", line 164, in get_preparation_data
    _check_not_importing_main()
  File "/Users/jx/.pyenv/versions/3.12.2/lib/python3.12/multiprocessing/spawn.py", line 140, in _check_not_importing_main
    raise RuntimeError('''
RuntimeError:
        An attempt has been made to start a new process before the
        current process has finished its bootstrapping phase.

        This probably means that you are not using fork to start your
        child processes and you have forgotten to use the proper idiom
        in the main module:

            if __name__ == '__main__':
                freeze_support()
                ...

        The "freeze_support()" line can be omitted if the program
        is not going to be frozen to produce an executable.

        To fix this issue, refer to the "Safe importing of main module"
        section in https://docs.python.org/3/library/multiprocessing.html

Hi, thank you for your attention to our work. This issue seems to be caused by the setting of num_work. You can try setting it to 0.

Confirmed that adding --num_workers 0 as argument in the shell script is able to solve the issue. Thanks for the prompt reply!


Only alphanumeric character set ranges are detected as ranges

S = Regexp::Scanner
S.scan /[1-9]/ # => [..., [:set, :range, "1-9", 1, 4], ...]
S.scan /[a-z]/ # => [..., [:set, :range, "a-z", 1, 4], ...]
S.scan /[!-%]/ # => [..., [:set, :member, "!", 1, 2], [:set, :member, "-", 2, 3], [:set, :member, "%", 3, 4], ...]
S.scan /[ä-ü]/ # => [..., [:set, :member, "\xC3\xA4", 1, 3], [:set, :member, "-", 3, 4], [:set, :member, "\xC3\xBC", 4, 6], ...]

I think we could detect everything as a range that follows this pattern:
anything_but_a_bracket . "-" . anything_but_a_bracket

Of course, "anything" can be a unicode escape or even a codepoint list. Funny enough this works:
/[\u{41 42}-\u{55 56}]/ =~ "\u{44}" # => 0

But besides of that are there any other pitfalls I didn’t think of?

That change makes sense. All of those cases should identified as ranges by the scanner, leaving it up to the lexer or parser to handle the semantics of the range, and possibly detect invalid ones.

I’ve started playing with scanner.rl to fix this issue, but come across a few other issues along the way.
Similar to the point made about sets in #28, marking stuff as a range causes a loss of token information. If 0-9, \a-\e and \u{600}-\u{6FF} are all emitted simply as range, library users will have to scan the token data themselves if they want to act on specific token types.
Encoding both the "rangeness" and token type at index 1 sounds like an option, and is already done for :range_hex, but it does not seem like a sustainable solution. It would require lots of new token types to cover all cases, and some cases are ambiguous. E.g. is \x42-\u{6FF} a range_hex, a range_codepoint, or something else altogether?
So I’m a little unsure whether a bigger refactoring might make sense.
A first step could still be to simply detect all ranges as range. However, even that first step is bigger than I initially thought, with chars like ^ or \ potentially acting as the start or end of a range. So I guess I’ll wait and see what conclusion you reach about #28 to avoid duplicate work on these parts.

fixed by #55


BetterTransformer support for BLOOM

Feature request
Can you please consider adding BetterTransformer support for BLOOM?
Thanks
Motivation
Definitely this support will be of great help for people working with BLOOM.
Your contribution
model = AutoModelForCausalLM.from_pretrained(hugg_path)
model = BetterTransformer.transform(model)

Hi @Hukongtao, this is done with #1221.


Version 3.1.9 update: Failed to find pattern

The game crashed and notified "Failed to find pattern: E8 ? ? ? ? 48 8D 8D ? ? 00 00 E8 ? ? ? ? 48 85 C0". Latest release version onto 13.21 Patch (OCE server)

I have the same problem. Is there a solution?

the same problem, wait for update

https://github.com/sansbruhgaming/R3nzSkin/releases/tag/THEYRE_COMING_HELPME_HELPHEMHEHELPHELPHELPHELPHELP
updated

anyone know something about the error (0xc000007b) i already installed a lot of dll´s but r3nzskin wont open due to this error


Adding buildspec file

@bryanvalencias94 Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.