Fix back/forward navigation using dedicated mouse/keyboard buttons.

PR Checklist

Please check all that apply to this PR using "x":

[x] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
[x] I have checked that this PR does not introduce a breaking change
[ ] This PR introduces breaking changes and I have provided a detailed explanation below

PR Type
What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting)
[ ] Refactoring (no functional changes)
[ ] Documentation changes
[ ] Other - Please describe:

Fixes
Issue Number: none
What is the current behavior?
The LBRY app does not navigate backward or forward when using the dedicated back/forward keyboard or mouse buttons.
What is the new behavior?
Back/forward keyboard and mouse buttons cause the LBRY app to navigate backward/forward.
Other information
The handlers for the 'navigate-backward' and 'navigate-forward' events introduced in #2250 look like they were removed at one point. So instead of firing those events upon receiving the back/forward app-command, I've rewritten it to call the window's WebContents goBack and goForward methods.
Tested on Windows 10 x64.

Hey @jcamp0x2a , thanks for the PR! My app seems to work fine with mouse forward/back on Windows and Linux.  The keyboard buttons do not. Are you sure this is an issue?
Can we show you some apprecation for your contribution?

Hi @tzarebczan , thank you for the timely response.
It's interesting... I tested the version without my changes with another mouse, and the buttons do indeed work. I also reverted the custom bindings for my main mouse (an Elecom trackball), and the default back/forward buttons work again.
This is my first time working with Electron, but if I were to hazard a guess, it would be that the LBRY app or the browser instance (Blink?) inside Electron itself is explicitly handling mouse buttons 4 and 5 to trigger back/forward navigation. Whereas, the keyboard keys and my rebound mouse are sending the back/forward app commands, not clicks of mouse button 4 or 5.
I've tested my changes again and verified that the standard mouse's back/forward buttons still work, so that functionality remains intact with the gain of being able to use the keyboard keys, rebound mouse buttons, and other possible input methods like accessibility tools.


Limit max number of register

add dev config to set a maximum  number of registers in case there's a lot of data

done


Continuation section too long when runnig script

Technical problem while downloading script. When you download it saves not only script, but whole html page.
Надіслано з iPhone

20 квіт. 2022 р. о 16:31 Theodore @.***> пише:

Why was this closed? Was it an issue with Anti-AFK or not?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you modified the open/close state.


Timestamps for URL downloads match the download time

By enabling CMake policy 135 we ensure that extracted files timestamp match that of the download time, instead of when the archive is created. This makes sure that if the URL changes to an older version we still rebuild everything as the timestamp
stays newer.

Hey, thanks for the PR! That policy change definitely sounds like a good idea. However, I feel a bit uneasy with changing global CMake policies from a utility script like CPM, as it can be unexpected for users. E.g. this lead to different behaviour of the same scripts based on the current CMake version.
Alternatively, how about adding a note to the Readme explaining the issue and suggesting using cmake_minimum_required(VERSION <min>...3.24) in projects if possible?

Hey, thanks for the PR! That policy change definitely sounds like a good idea. However, I feel a bit uneasy with changing global CMake policies from a utility script like CPM, as it can be unexpected for users. E.g. this lead to different behaviour of the same scripts based on the current CMake version.
Alternatively, how about adding a note to the Readme explaining the issue and suggesting using cmake_minimum_required(VERSION <min>...3.24) (which will auto-set the new policies) in projects, if possible?

I think we would need to suggest that the projects set CMAKE_POLICY_DEFAULT_CMP0135 value instead cmake_minimum_version. That way when a nested project calls CPM it uses the correct behavior instead of the behavior being reset by the nested projects cmake_minimum_version call.

How about if we do this as a global CPM option? That would be an opt-in behavior change and we would document the flag as only working with CMake 3.24+

I think we would need to suggest that the projects set CMAKE_POLICY_DEFAULT_CMP0135 value instead cmake_minimum_version. That way when a nested project calls CPM it uses the correct behavior instead of the behavior being reset by the nested projects cmake_minimum_version call.

I see, that's a good point. Maybe having an option CPM_SET_RECOMMENDED_CMAKE_POLICIES,  that sets the policies and defaults (as available for the current CMake version) on launch, would be a good idea.

I think we would need to suggest that the projects set CMAKE_POLICY_DEFAULT_CMP0135 value instead cmake_minimum_version. That way when a nested project calls CPM it uses the correct behavior instead of the behavior being reset by the nested projects cmake_minimum_version call.

I see, that's a good point. Maybe having an option like CPM_SET_RECOMMENDED_CMAKE_POLICIES, that sets the policies and defaults (as available for the current CMake version) on launch, would be a good idea.

I have updated this PR with the introduction of CPM_SET_RECOMMENDED_CMAKE_POLICIES

I also wonder if it would make sense to default CPM_SET_RECOMMENDED_CMAKE_POLICIES to YES, as I can imagine this being much more common than opting out, as it's hard to imagine the policy changes in question to introduce bugs. But then again I'm not completely about all possible implications and edge-cases.
@iboB do you have any thoughts on this?

I agree with @TheLartians that setting the policies to new by default is desirable. This is the future, right? :)
I also think that we should set them when CPM.cmake is included.
It should be the responsibility of the users to manually handle policies if they want to depend on the old behavor
IMO the tougher question is what to do with the policies set in cmp_add_subdirectory. We can just delete the code there and assume they're being handled from above (and I favor this), but it should be noted that if we allow opting out of setting the default CPM policies, old working code with options will break. If we do keep the code there, there is no point in setting them to NEW at the point of inclusion. Also in such case CPMAddPackage will set them to NEW in packages added with OPTIONS anyway regardless of the opt-out. We could also do a cmake_policy(PUSH/POP) there to try to save the policy configuration from the scope above, but they will be set to NEW in the package's CMakeLists anyway.
Thinking about it, I find it unpleasant that adding the exact same package with and without OPTIONS will lead to potentially different policy configurations in the package itself.
So... in short I would:

set all three policies to NEW when including CPM.cmake without the possibility to opt-out
document that these policies are set to NEW and advise authors that want to depend on the old behavior that they should manually take care of it in the appropriate places.

Based on the feedback it looks like everyone agrees that the policies should be set on inclusion of CPM.cmake. So I have updated the PR to do exactly that.
The policies are still guarded by CPM_SET_RECOMMENDED_CMAKE_POLICIES, but by default the value is set to ON.

Thanks @iboB for the feedback and @robertmaynard for the changes!
After thinking about it I'm now also convinced that setting the policies initially without option to opt-out is the way to go. Besides the points mentioned above, providing no opt-out also means less options to handle and maintain for us. If setting the policies does lead to an increase in issues, we can still add an opt-out in a future version if deemed necessary.

After thinking about it I'm now also convinced that setting the policies initially without option to opt-out is the way to go. Besides the points mentioned above, providing no opt-out also means less options to handle and maintain for us. If setting the policies do lead to an increase in issues, we can still add an opt-out in a future version if deemed necessary.

I have updated the PR to always enable the policies, and dropped the CPM_SET_RECOMMENDED_CMAKE_POLICIES option ( and docs ).


Kafka consumer stops completely(TERMINATE on main thread) after value deserialization

Description
Log at the end of description. Motivation and structure of app below.
In order to test my consumer I publish from a C# client or a python client. I can see my value deserializer being called and the value being deserialized properly but along with that thrd:app is invoking TERMINATE on main thread which stops my consumer. The deserialized value does not reach my consume loop, so re-initializing consumer is not a make shift solution. And the C# client never comes up(TRY_CONNECT) it just detects the broker to be DOWN at the end then stops. Eventually my broker detects this failure and removes the group as I am only running one instance of my app(only one process with groupid).
I can consume the published content on another python client simultaneously using a different groupid. This can be done repeatedly as expected so no issue in broker.
Before I start my consumer I fetch metadata using AdminClient and ensure topic partitions are created and as can be seen in logs they are polled too.
I am also able to produce using my app and consume the published content on a different process using python client. Hence my app can reach the broker always.
Please note I am quite novice in both Kafka and C# and have used none of them in industrial setting.
Other details:
Confluent.Kafka nuget version. 1.4.3 and 1.4.0 (tried with both)
Apache Kafka version. 2.5.0
Client configuration with (tried with both)
config1:
ConsumerConfig consumerConfig = new ConsumerConfig { BootstrapServers = kafkaHost, GroupId = groupId, EnableAutoCommit = true,  Debug = "all", EnableAutoOffsetStore = true, AutoCommitIntervalMs = 5000 };
config 2:
EnableAutoCommit = false, Debug = "all", EnableAutoOffsetStore = false,AutoCommitIntervalMs = 0
Operating system: in ubuntu host on mcr.microsoft.com/dotnet/core/aspnet:3.1
Critical: Stopper yes, critical no, will appreciate a link to an working example of C# consumer running on container
Some other details:
I am trying to run a asp net core application which has some web based endpoints and uses Kafka as event bus. I am using minimal configuration for Kafka in both broker and client side. As this is a container based solution I am using docker and used an arbitrary IP as KAFKA_ADVERTISED_LISTENERS as can be seen in logs. Except that all other broker side configs are taken as https://github.com/confluentinc/cp-all-in-one/tree/5.5.0-post/cp-all-in-one-community .
I have not used schema registry and implemented my own synchronous IDeserialization interface for Json deser with Newtonsoft.
I have run a BackgroundService to do consume on a background tread. I am using consumer.Consume(1000) or consumer.Consume(TimeSpan.FromSeconds(1)) to poll in loop. If null is returned I do Task.yeild().
How to reproduce
code snippet:
   ConsumeResult<Ignore, PaymentStatus> result = null;
        Console.WriteLine("initializing PaymentStatusConsumer subscriber");
        using var consumer = new ConsumerBuilder<Ignore, PaymentStatus>(_consumerConfig)
                    .SetValueDeserializer(new JsonDeser<PaymentStatus>())
                    .SetErrorHandler((_, e) => Console.WriteLine($"Error: {e.Reason}"))
                    .SetPartitionsAssignedHandler((c, partitions) =>
                    {
                        Console.WriteLine($"Assigned partitions: [{string.Join(", ", partitions)}]");
                    })
                    .SetPartitionsRevokedHandler((c, partitions) =>
                    {
                        Console.WriteLine($"Revoking assignment: [{string.Join(", ", partitions)}]");
                    }).Build();

        consumer.Subscribe("fo_pay_sta");
        Console.WriteLine("subscribed PaymentStatusConsumer");
        while (!cts.IsCancellationRequested)
        {
            while (result == null)
            {
                try
                {
                    Console.WriteLine("consuming PaymentStatusConsumer");
                    result = consumer.Consume(TimeSpan.FromSeconds(1));
                    if(result==null)
                        Console.WriteLine("consuming null");
                    else
                        Console.WriteLine("consumed PaymentStatusConsumer: {}",
                       result.Message.Value);
                }
                catch (ConsumeException e) {
                    _logger.LogError("Exception during consumption : {}, {}, {}, {}, {}",
                        e.Message, e.StackTrace, e.InnerException.StackTrace,
                        e.InnerException.Message, e.InnerException.Data);
                }
                if (result == null)
                    await Task.Yield();
                else
                {
                    Console.WriteLine("consumed PaymentStatusConsumer: {}",
                       result.Message.Value);
                    status = result.Message.Value;
                    result = null;
                }
            }

JsonDeser is a implementation IDeserializer which does simple Json deseriliazation without schema registry lookup and other confluent system specific validations(magic byte etc.).
confluent_failed.log
Checklist
Please provide the following information:

[x] A complete (i.e. we can run it), minimal program demonstrating the problem. No need to supply a project file.
[x] Confluent.Kafka nuget version. 1.4.3 and 1.4.0
[x] Apache Kafka version. 2.5.0
[x] Client configuration.
[x] Operating system.
[x] Provide logs (with "debug" : "..." as necessary in configuration).
[ ] Provide broker log excerpts.
[ ] Critical issue.

order-service.zip
Project files

I am sorry, this was my fault.


Auto-register admin classes

User should unregister them if needed using admin.site.unregister

Current coverage is 96.12% (diff: 100%)

Merging #2 into master will increase coverage by 0.06%

@@             master         #2   diff @@
==========================================
  Files            14         14
  Lines           228        232     +4
  Methods           0          0
  Messages          0          0
  Branches         10         13     +3
==========================================
+ Hits            219        223     +4
  Misses            6          6
  Partials          3          3

Powered by Codecov. Last update 82865ea...5f53b00


Not able to edit Milliseconds field in the widget, able to edit in input field however.

I'm Submitting a ...

[x ] Bug report
[ ] Feature request
[ ] Support request

Steps to Reproduce

Create a DateTime component with custom timeFormat which includes milliseconds.
<DateTime timeFormat="HH:mm:ss:SSS" />
Try updating millisecond values from the widget. It does not allow updating. However, you can update from the input element.

Expected Results

Milliseconds field should be updatable.
Actual Results

Unable to update Milliseconds field.
Minimal Reproduction of the Problem

https://codepen.io/anon/pen/LePeqO
Other Information (e.g. stacktraces, related issues, suggestions how to fix)

From what I have seen in the code the issue originates in src/TimeView.js updateMilli function. The first part of if condition is never going to be true as it compares types as well, which are number & string respectively.
We can probably change if ( milli === e.target.value && milli >= 0 && milli < 1000 ) { to if ( milli === +e.target.value && milli >= 0 && milli < 1000 ) { with exception checks, but I am not sure of the use of the first part of this if condition.
I can create a PR if you think this is a good solution.

same issue here.

Hi there, I saw that we have a fix, can we have a 2.16.4 version with this issue fixed please? Thank you in advance.


wrong links in proj3.md

the links in proj3-README-zh_CN.md link to 404, please update them.
#36 LGTM, please check.

fixed via #36


Add exponenetial backoff for fetching from repos that fail

Suggested here

Most of these fails come from abandoned repos.
I think backing of with a 404 is not the correct behaviour, just ignore repos that don't exists.

github returns "access denied" for deleted repos, to make it ambiguous whether they've been deleted of went private.


Hard-remove gallery images from admin site

A button on a GalleryImage's admin page to remove it from both the database and the static_resources directory

No longer relevant with new gallery structure


AssertionError: Premium is tax free, assignments not. Found "xx.x" EUR.

I am facing this assertion error. Don't know much context about it. If I comment out this assertion will get error again somewhere. Looks like this tool only works only for IDEAL CASEs!
  File "/Users/nharalahalli/workspace_nd/tastyworks-pnl/tw-pnl.py", line 1418, in <module>
    main(sys.argv[1:])
  File "/Users/nharalahalli/workspace_nd/tastyworks-pnl/tw-pnl.py", line 1415, in main
    check(all_wk, output_summary, output_csv, output_excel, tax_output, show, verbose, debug)
  File "/Users/nharalahalli/workspace_nd/tastyworks-pnl/tw-pnl.py", line 1193, in check
    stats = get_summary(new_wk, orig_wk, tax_output, min_year, max_year)
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/nharalahalli/workspace_nd/tastyworks-pnl/tw-pnl.py", line 662, in get_summary
    raise AssertionError(f'Premium is tax free, assignments not. Found "{eur_amount}" EUR.')
AssertionError: Premium is tax free, assignments not. Found "-47.9" EUR.```

The script does sanity checks, so you get notifications if your data might not be handled correctly.
The error message comes from line 662 in tw-pnl.py. If you disable this check, what error message comes next?
If you can give sample lines to reproduce this error, I might be able to help. If you don't mind, some people even
send in their input data via email to me, so I can try to reproduce the error.
Are you sure that your input data is complete from beginning of all your trades?
best regards,
Florian La Roche

Hi Florian,
I have attached the input data with the mail.
Best regards,
Nandeesh
On Sun, 27 Oct 2024 at 17:55, Florian La Roche @.***>
wrote:

The script does sanity checks, so you get notifications if your data might
not be handled correctly.
The error message comes from line 662 in tw-pnl.py. If you disable this
check, what error message comes next?
If you can give sample lines to reproduce this error, I might be able to
help. If you don't mind, some people even
send in their input data via email to me, so I can try to reproduce the
error.
Are you sure that your input data is complete from beginning of all your
trades?
best regards,
Florian La Roche
—
Reply to this email directly, view it on GitHub
https://github.com/laroche/tastyworks-pnl/issues/45#issuecomment-2440097653,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACORZTD4HLVKCQ3OA7ES4ITZ5UEHTAVCNFSM6AAAAABQV4T322VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINBQGA4TONRVGM
.
You are receiving this because you authored the thread.Message ID:
@.***>

Current checks about tax free EurUSD-conversion is wrong. Just disabling them should work fine, I'll check
this again the next days for a correct patch.
best regards,
Florian La Roche

--- a/tw-pnl.py
+++ b/tw-pnl.py
@@ -586,7 +586,8 @@ def get_summary(new_wk, orig_wk, tax_output, min_year, max_year):
         if type in ('Ein/Auszahlung', 'Aktie', 'Aktienfond', 'Mischfond',
             'Immobilienfond', 'Sonstiges', 'Long-Option', 'Future'):
             if bool(tax_free):
-                raise ValueError(f'tax_free is True for type "{type}". Full row: "{new_wk.iloc[i]}"')
+                pass
+                #raise ValueError(f'tax_free is True for type "{type}". Full row: "{new_wk.iloc[i]}"')
         # Währungsgewinne:
         stats.loc['Währungsgewinne USD', year] += float(usd_gains)
         stats.loc['Währungsgewinne USD (steuerfrei)', year] += float(usd_gains_notax)
@@ -659,7 +660,8 @@ def get_summary(new_wk, orig_wk, tax_output, min_year, max_year):
                     raise AssertionError(f'Premium is tax free, assignments not. Found "{eur_amount}" EUR.')
             else:
                 if eur_amount < .0:
-                    raise AssertionError(f'Premium is tax free, assignments not. Found "{eur_amount}" EUR.')
+                    pass
+                    #raise AssertionError(f'Premium is tax free, assignments not. Found "{eur_amount}" EUR.')
         elif type == 'Ordergebühr':
             stats.loc['zusätzliche Ordergebühren', year] += pnl
         elif type == 'Dividende':

Just looked again more closely: Your input data has on 2023-12-27 8 lines with "Special Dividend".
My script parses this later on as option trade and then fails.
These are the failing lines:

2023-12-27T12:48:34+0100,Receive Deliver,Special Dividend,SELL_TO_OPEN,QQQ   240119P00384780,Equity Option,Special dividend: Open 1.0 QQQ   240119P00384780,123.00,1,123.00,--,0.00,100,QQQ,QQQ,1/19/24,384.78,PUT,,USD
2023-12-27T12:48:34+0100,Receive Deliver,Special Dividend,BUY_TO_CLOSE,QQQ   240119P00385000,Equity Option,Special dividend: Close 1.0 QQQ   240119P00385000,-123.00,1,-123.00,--,0.00,100,QQQ,QQQ,1/19/24,385,PUT,,USD
2023-12-27T12:48:21+0100,Receive Deliver,Special Dividend,BUY_TO_OPEN,QQQ   240119P00379780,Equity Option,Special dividend: Open 1.0 QQQ   240119P00379780,-91.00,1,-91.00,--,0.00,100,QQQ,QQQ,1/19/24,379.78,PUT,,USD
2023-12-27T12:48:21+0100,Receive Deliver,Special Dividend,SELL_TO_CLOSE,QQQ   240119P00380000,Equity Option,Special dividend: Close 1.0 QQQ   240119P00380000,91.00,1,91.00,--,0.00,100,QQQ,QQQ,1/19/24,380,PUT,,USD
2023-12-27T12:47:08+0100,Receive Deliver,Special Dividend,BUY_TO_OPEN,QQQ   240119C00429780,Equity Option,Special dividend: Open 1.0 QQQ   240119C00429780,-33.00,1,-33.00,--,0.00,100,QQQ,QQQ,1/19/24,429.78,CALL,,USD
2023-12-27T12:47:08+0100,Receive Deliver,Special Dividend,SELL_TO_CLOSE,QQQ   240119C00430000,Equity Option,Special dividend: Close 1.0 QQQ   240119C00430000,33.00,1,33.00,--,0.00,100,QQQ,QQQ,1/19/24,430,CALL,,USD
2023-12-27T12:47:03+0100,Receive Deliver,Special Dividend,SELL_TO_OPEN,QQQ   240119C00424780,Equity Option,Special dividend: Open 1.0 QQQ   240119C00424780,53.00,1,53.00,--,0.00,100,QQQ,QQQ,1/19/24,424.78,CALL,,USD
2023-12-27T12:47:03+0100,Receive Deliver,Special Dividend,BUY_TO_CLOSE,QQQ   240119C00425000,Equity Option,Special dividend: Close 1.0 QQQ   240119C00425000,-53.00,1,-53.00,--,0.00,100,QQQ,QQQ,1/19/24,425,CALL,,USD

Just deleting those 8 lines and then running the script should work ok. Not sure what those 8 lines should do, maybe
replacing all the option strike prices here? This needs further investigation. Can you check what happens with
these options in 2024?
best regards,
Florian La Roche

Thank you very much Florian for looking into the issue!
I am not sure what do you mean by -

Can you check what happens with
these options in 2024?


gateway-api: bump version to 1.0 and add a script for update.

1. Please confirm that you have read the document before PR submitted

[ ] Yes, I have read THIS NOTE DOC.

2. Contact Information(Optional)
If it is convenient, please provide your contact information so we can reach you when processing the PR:

Email:
HomePage:

next pr will working for auto-update the gateway-api with github action.


Allow disabling flattening

Currently JSON arrays are string-ified. Users may want to output the raw JSON arrays, and many database targets, for example, support loading them into the appropriate array/variant column type.

Hi @edgarrmondragon , I provided this option some time ago via this option.
    - name: store_raw_json_message
      kind: boolean

By default it is set to False but if it is set to True you get the whole raw JSON message. You can choose to only select a few string-ified fields alongside the raw JSON message.

In reflection, I believe I should have added a bit more context.
There is an additional attribute added _SDC_RAW_JSON . This can be enabled via the boolean store_raw_json_message property being set to true. This field will contain the full JSON payload.
I left the rest of the discovered fields as because you may wish to retain a few of the discovered fields like an ID and LAST_MODIFIED_TIMESTAMP (depending on the API) as it is very useful for the incremental nature of retrieve data from an API and updating the state so you don't need to retrieve all the records.
For some API's like FHIR API, I select only the id, meta_lastUpdated, and the _sdc_raw_json.
If you wanted you could select only the _sdc_raw_json if you just want the JSON payload.

That makes sense, those are helpful pointers for folks. Thanks as always @s7clarke10 🙏


Update ReadMe

Description
Update ReadMe with build status
Issues Resolved
Check List

[ ] New functionality includes testing.

[ ] All tests pass ($ rake test).

[ ] New functionality has been documented in the README if applicable.

[ ] New functionality has been thoroughly documented in the examples (please include helpful comments).

[ ] Changes are documented in the CHANGELOG.

Looks fine.

Looks fine.

Yuvarani - After seeing the versions, I see that Puppet version is not same as OV version (or not aligned). So, I do not think we should use as 5.50 / 5.40 / 5.20 Branch. We should rather use the Puppet version tags such as v2.9.0 / 2.8.0 / 2.7.0 (last three)
Also, let's keep the master branch status (as it existed today).

Yuvarani - After seeing the versions, I see that Puppet version is not same as OV version (or not aligned). So, I do not think we should use as 5.50 / 5.40 / 5.20 Branch. We should rather use the Puppet version tags such as v2.9.0 / 2.8.0 / 2.7.0 (last three)
Also, let's keep the master branch status (as it existed today).

You can merge it.. Looks fine. Need to adopt the same style for other SDKs too.

You can merge it.. Looks fine. Need to adopt the same style for other SDKs too.


Remove unnecessary null-safe calls against Guava multimaps

As of version 30 or 31, multimaps are now specified to (and annotated as) not return null from .get(K key), even when no values exist for the key.  An empty collection is returned in that case.
This may or may not have been true in the past; I think it was, but there definitely weren't any non-null annotations to tell Kotlin about this fact.  That's fixed, so now we don't need to guard calls with the safe-call operator.

Codecov Report

Merging #483 (2e8953d) into master (6325d9c) will increase coverage by 0.03%.
The diff coverage is 75.00%.

@@             Coverage Diff              @@
##             master     #483      +/-   ##
============================================
+ Coverage     59.12%   59.15%   +0.03%
  Complexity      865      865
============================================
  Files            69       69
  Lines          6481     6481
  Branches       1012     1010       -2
============================================
+ Hits           3832     3834       +2
  Misses         2345     2345
+ Partials        304      302       -2

Impacted Files
Coverage Δ

.../com/microsoft/thrifty/kgen/KotlinCodeGenerator.kt
84.74% <75.00%> (+0.13%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6325d9c...2e8953d. Read the comment docs.


It would be greatly beneficial if you could provide the pre-trained model as the input checkpoint file.

It would be greatly beneficial if you could provide the pre-trained model as the input checkpoint file.

Unfortunately we cant not do this as this, as the LDC data the model is trained with is not freely available.


bundle requisite copies of original assets

the pak chunk that is built from this project requires two other things to work properly:

pseudoregalia/Content/UI/UI_HUD_ORIGINAL.uasset and uexp
pseudoregalia/Content/UI/title/UI_MainMenu_Copy.uasset and uexp

which should be copies of the original assets from the game. we might want to add a script that extracts these assets from the game pak and bundles them into the built pak.

Done 3c432f1


Move resources to kpack.io api group

Today, our kpack resources live within the experimental.kpack.pivotal.io or the build.pivotal.io api group. We know that the *.pivotal.io api group is not the long term home of the resources and it will need to be eventually changed.
As changing the api group of a resource is a breaking change, we should enable upgrades in the future by moving to a
future proof api group.
The api group: kpack.io will provide a long term home for the resources and is a more vendor neutral api group for the kpack community.

Note: This change would most likely involve removing the "experimental" api group.


[WIP] feat!: support stream prefix

Marked as WIP while I run a few more tests.
Feature or Problem
This PR supports an advanced configuration requirement where multiple wadms may be running in an environment where you do not want them sharing streams. With this feature, you can isolate wadms by separating the streams and KV buckets from each other. For example:
wadm --stream-prefix mycustom_wadm --manifest-bucket mybucket --state-bucket otherbucket

This command will prepend mycustom_wadm to each of the streams (e.g. mycustom_wadm_commands, mycustom_wadm_events, etc) and create separate manifest buckets.
This was somewhat of an oversight in #133 as we already separated the mirror stream, but not the others.
Related Issues
#133
Release Information
v0.5.0
Consumer Impact
Default behavior (prepending wadm) is preserved here.
Testing

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin
[ ] x86_64-windows

Tested on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin
[ ] x86_64-windows

Unit Test(s)

Acceptance or Integration

Manual Verification

After talking with @thomastaylor312, I think this is not necessary!


April Trustnet report

To be published first half of April

Many thanks to @pollecuttn and @alexwlchan for helpful comments on review. Copied to Tom FYI.
Submitted today.


Naming referenced schemas

It might be useful to point out how to name schemas which are referenced by imports in other schemas. In example, for an imported schema file named "referencedSchema.xsd" on disk, it must be named just "referencedSchema" in the Add Schema blade. A schema which imports referencedSchema should still use schemaLocation="referencedSchema.xsd".  If not named correctly you cannot upload schemas which import referencedSchema as you will get an error about referencedSchema.xsd not being found in the integration account. One might naturally think the name should be referencedSchema.xsd, but that is not correct based on my observations.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4693440c-6b93-1d37-8baa-e45a0450a0f7
Version Independent ID: ea20c70a-7714-7271-0002-5ee4a40abaae
Content: Schemas for XML validation - Azure Logic Apps
Content Source: articles/logic-apps/logic-apps-enterprise-integration-schemas.md
Service: logic-apps
Product: unspecified
GitHub Login: @MSFTMan
Microsoft Alias: LADocs; padmavc

@sparsematrix Thank you for your feedback! We have assigned this issue to the author to review and take the right course of action.

@mike-urnun-msft Can you reassign to @divyaswarnkar? Thanks!

We've created a work item to track this request.
@mike-urnun-msft - Please close? Thanks!

@mike-urnun-msft: Mike, please close as we have a work item tracking this issue now. Thanks!


File matching objectName not found in the pod

Have you

[x] Read Troubleshooting Guide
[x] Searched on GitHub issues and Discussions

What steps did you take and what happened:
We have installed the software in this way:
Secret Provider Class:
apiVersion: secrets-store.csi.x-k8s.io/v1alpha1
kind: SecretProviderClass
metadata:
  name: docker-config
  namespace: [REDACTED]
spec:
  secretObjects:
  - data:
    - key: docker-config
      objectName: DOCKER-CONFIG
    secretName: docker-config
    type: Opaque
  provider: azure
  parameters:
    usePodIdentity: "true"
    keyvaultName:  [REDACTED]
    objects:  |
      array:
        - |
          objectName: DOCKER-CONFIG
          objectType: secret
          objectAlias: "config.json"
          objectVersion: ""
    tenantId: [REDACTED]

Pod:
[..]
    volumeMounts:
    - mountPath: /root/.docker/
      name: docker-config
      readOnly: true
    volumes:
    - csi:
        driver: secrets-store.csi.k8s.io
        readOnly: true
        volumeAttributes:
          secretProviderClass: docker-config
        name: docker-config
[..]

In this way, the pod starts and inside the /root/.docker/ folder we find the secret config.json.
So far everything is fine but the describe of the pod give these error messages:
Warning  SecretRotationFailed  4m2s (x33 over 9m5s)    csi-secrets-store-rotation    failed to get data in spc [REDACTED]/docker-config for secret docker-config, err: file matching objectName DOCKER-CONFIG not found in the pod
Warning  FailedToCreateSecret  3m57s (x17 over 9m25s)  csi-secrets-store-controller  failed to get data in spc [REDACTED]/docker-config for secret docker-config, err: file matching objectName DOCKER-CONFIG not found in the pod

It seems that the procedure of rotation and creation of the secret does not take into account the configured alias.
What did you expect to happen:
I expect to have the secret properly valued and rotated. Without any error message.
Anything else you would like to add:
Nothing
Which access mode did you use to access the Azure Key Vault instance:
We use AAD Pod Identity https://github.com/Azure/aad-pod-identity
In the specific case, however, integration with Azure is not the problem.
Environment:

Secrets Store CSI Driver version: 0.0.23 (Helm Chart Version 0.0.20)
Azure Key Vault provider version: 0.0.16 (Helm Chart Version 0.0.20)
Kubernetes version: v1.20.5
Cluster type: AKS

I found the solution myself but you need to document this better.
Ref: https://github.com/kubernetes-sigs/secrets-store-csi-driver/pull/202/
and https://github.com/ritazh/secrets-store-csi-driver/blob/b53290fde5b1cb2fddb0acb3156354e7571e5707/README.md#optional-sync-with-kubernetes-secrets
@aramase @ritazh could you please document better this feature?

@pierluigilenoci Thank you for reporting the issue. This is already part of our doc: https://azure.github.io/secrets-store-csi-driver-provider-azure/configurations/sync-with-k8s-secrets/#how-to-sync-mounted-content-with-kubernetes-secret

Closing this issue now. Please feel free to reopen if you have any questions.


how can i apply Geotiff raster image on different map its in australia region need to apply in canada region like this similar raster image i had tried Qgis and other software to convert to .tiff format

how can i apply Geotiff raster image on different map its in australia region need to apply in canada region like this similar raster image i had tried Qgis and other software to convert to .tiff format
https://github.com/stuartmatthews/leaflet-geotiff

If you can't attach the files, feel free to email them to<EMAIL_ADDRESS>

Hi Daniel , Thank u for the reply
Basically  i need to create a raster image for the country canada like the below screenshot image which i had attached it is for australia region .How can i create a raster image for canada or any other country and apply it on map tried so many times to create a raster image by taking map screenshot & converting to .tiff format but still it does not worked .
Can u create the below Geo.png image to raster colored format to .tiff and Load it on map here: http://app.geotiff.io/
I need to create the same raster colored image and load it instead of australia tried so many but the image is not loading properly here   http://app.geotiff.io/
If the raster image loads in the above link i can apply to my code and load the raster image
This is the code:   https://github.com/stuartmatthews/leaflet-geotiff
const windSpeedUrl = "https://stuartmatthews.github.io/leaflet-geotiff/tif/wind_speed.tif";
const windSpeedOptions = {
band: 0,
displayMin: 0,
displayMax: 30,
name: "Wind speed",
colorScale: "rainbow",
clampLow: false,
clampHigh: true,
vector:true
};
const windDirectionUrl = "https://stuartmatthews.github.io/leaflet-geotiff/tif/wind_direction.tif";
const windDirectionOptions = {
  band: 0,
  name: "Wind direction",
  arrowSize: 40
};


Adding IMG (or Image in toolbar) does not permit base64 images pasted from clipboard

The paste event suppresses base64 image conversion when pasting an image from the clipboard even if IMG or the Image option are selected. Looking at the source, it doesn't appear to look at the clipboardData.items collection values of type image. Alternatively, if img/image is permitted, permit the default quill paste behavior for that type.

Hi @jadkisson,
thank you for raising this issue.
To be clear, you don't mean the image being part of a copied string (as a html tag), but just the image by itself?
If so, you're right. I didn't thought about this. A PR would be highly appreciated. Otherwise I'll implement it by myself as soon as I find some time.


PILOT_ENABLE_STATUS won't take effect if it is set without PILOT_ENABLE_CONFIG_DISTRIBUTION_TRACKING

Is this the right place to submit this?

[X] This is not a security vulnerability or a crashing bug
[X] This is not a question about how to use Istio

Bug Description
Since https://github.com/istio/istio/pull/43226, the PILOT_ENABLE_STATUS only takes effect when PILOT_ENABLE_CONFIG_DISTRIBUTION_TRACKING is also set to true. Is this behavior intended? If it is, maybe we can mark PILOT_ENABLE_STATUS as deprecated as it doesn't have a unique meaning.
Version
$ istioctl version
client version: 1.21.0
control plane version: unknown
data plane version: 1.21.0 (2 proxies)
$ kubectl version --short
Client Version: v1.25.11
Kustomize Version: v4.5.7
Server Version: v1.25.11

Additional Information
No response
Affected product area

[ ] Ambient
[ ] Docs
[ ] Dual Stack
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[X] User Experience
[ ] Developer Infrastructure
[ ] Upgrade
[ ] Multi Cluster
[ ] Virtual Machine
[ ] Control Plane Revisions

Wasn't sure if that flag was designed to control the write status for different controllers, such as gateway/analysis, or if it is just for config distribution tracking. If it's the latter, I think we can deprecate it.

On the other side, only setting PILOT_ENABLE_CONFIG_DISTRIBUTION_TRACKING won't take effect if PILOT_ENABLE_STATUS is not set. Maybe we can deal with this together during the deprecation.


Allow ImageSpec::find_attribute of "datawindow" and "displaywindow"

These are "pseudo-attributes", they aren't metadata themselves as we store them in an ImageSpec, but
aggreagate from x,y,z,width,height,depth (and the full_ versions). The "datawindow" and "displaywindow" are OpenEXR nomenclature, but it's likely that people will want to refer to them that way.

Amended with a minor fix to ImageCache::get_image_info and  TextureSystem::get_texture_info, to make the right kind of ImageSpec::find call to retrieve the pseudo-attributes.


Set MSRV to 1.67

Determined with cargo-msrv.
More specific, Rust 1.67 is required by deps: time, time-macros, time-core, powerfmt and deranged.

Merged, thanks!


Unable to do npm install on OSX with node version 4.x

$ npm install bunyan-syslog --save
><EMAIL_ADDRESS>install /Users/ashwinikumar/work/1_hs/hotelsoftrzr/node_modules/bunyan-syslog
> node-gyp rebuild

  CXX(target) Release/obj.target/syslog/src/syslog.o
In file included from ../src/syslog.cc:7:
In file included from ../../nan/nan.h:74:
In file included from ../../nan/nan_new.h:190:
../../nan/nan_implementation_12_inl.h:181:66: error: too many arguments to function call, expected at most 2, have 4
  return v8::Signature::New(v8::Isolate::GetCurrent(), receiver, argc, argv);
         ~~~~~~~~~~~~~~~~~~                                      ^~~~~~~~~~
/Users/ashwinikumar/.node-gyp/4.2.1/include/node/v8.h:4675:3: note: 'New' declared here
  static Local<Signature> New(
  ^
In file included from ../src/syslog.cc:7:
../../nan/nan.h:165:25: error: redefinition of '_NanEnsureLocal'
NAN_INLINE v8::Local<T> _NanEnsureLocal(v8::Local<T> val) {
                        ^
../../nan/nan.h:160:25: note: previous definition is here
NAN_INLINE v8::Local<T> _NanEnsureLocal(v8::Handle<T> val) {
../../nan/nan.h:310:12: error: no matching function for call to '_NanEnsureLocal'
    return NanEscapeScope(NanNew(v8::Undefined(v8::Isolate::GetCurrent())));
           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../nan/nan.h:296:43: note: expanded from macro 'NanEscapeScope'
# define NanEscapeScope(val) scope.Escape(_NanEnsureLocal(val))
                                          ^~~~~~~~~~~~~~~
../../nan/nan.h:165:25: note: candidate template ignored: substitution failure [with T = v8::Primitive]
NAN_INLINE v8::Local<T> _NanEnsureLocal(v8::Local<T> val) {

$ npm version
{ npm: '3.3.8',
  ares: '1.10.1-DEV',
  http_parser: '2.5.0',
  icu: '56.1',
  modules: '46',
  node: '4.2.1',
  openssl: '1.0.2d',
  uv: '1.7.5',
  v8: '<IP_ADDRESS>',
  zlib: '1.2.8' }

It's not OS X issue, but node. The node v4 is not supported yet.

@koresar when should I expect the support of node v4.
.
And which node version should I downgrade to get it going.

@dopeddude look around :)
there is a PR for that: https://github.com/mcavage/node-bunyan-syslog/pull/30
I'd recommend forking this: https://github.com/sempasha/node-bunyan-syslog

@koresar Thanks, will give it a try. Thanks again.

This should be fixed in v0.3.1


Embed trace ids into logs

We don't currently expose incoming OpenTracing trace/span ids in logs. We should do so in a way that makes them easy for fluentd etc to extract

This is done now


Rename config.rb to middleman.rb to avoid conflicts with Compass

As in topic. Please reopen this issue and implement this feature.

Already done on master

When it's going to be released, or is it possible to use middleman from master directly right now?

I wouldn't expect a stable release for several months still. If you're comfortable with the bleeding edge, I'm using master for my sites, but then again, I have a little more insight into why things might break.


checkov: 2.0.660 -> 2.0.664

Motivation for this change
https://github.com/bridgecrewio/checkov/releases/tag/2.0.664
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 150934 run on x86_64-linux 1

1 package built:

checkov


Compose: card swipe, rotate will make screen flash

Description:
Card swipe, rotate will make screen flash

QA passed


[FLINK-7583] [REST] Use static constant for CONTENT_TYPE header

What is the purpose of the change
This PR introduces a static constant to be used as the HTTP CONTENT_TYPE header value. This ensures that we only allocate the string once, and that the client/server always use the same value.
Brief change log

Add RestConstants class
Add REST_CONTENT_TYPE constants
modify RestClient and AbstractRestHandler accordingly

Verifying this change
This change is a trivial rework / code cleanup without any test coverage.

I went through all usages of HttpHeaders.Names.CONTENT_TYPE and they are all related to rest operators, making RestContants a good place to put them. Also, ConfigConstants should be reserved for constants related to the configuration of Flink, which this isn't. Lastly, many of these usage will be eclipsed in the near future anyway.

I see. Thanks @zentol.
So +1 to merge from me.


0.86.0 Snowflake Table Contstraints all failing to create

Terraform CLI and Provider Versions
Terraform v1.6.3
on darwin_arm64

provider registry.terraform.io/aidanmelen/snowsql v1.3.3
provider registry.terraform.io/hashicorp/aws v5.38.0
provider registry.terraform.io/hashicorp/random v3.6.0
provider registry.terraform.io/hashicorp/time v0.10.0
provider registry.terraform.io/snowflake-labs/snowflake v0.86.0

Your version of Terraform is out of date! The latest version
is 1.7.4. You can update by downloading from https://www.terraform.io/downloads.html
Terraform Configuration
required_providers {
    snowflake = {
      source  = "Snowflake-Labs/snowflake"
      version = ">=0.53.0"
    }
  }

Expected Behavior
I should be able to create a primary key on a table using provider version 0.86.0.
Actual Behavior
│ Error: table id is incorrect: {TERRAFORM_WORKSPACE|MYAPP|MYTABLE}
│
│   with module.snowflake.module.my_module["MYTABLE"].snowflake_table_constraint.primary_key,
│   on .terraform/modules/snowflake/modules/my_module/main.tf line 42, in resource "snowflake_table_constraint" "primary_key":
│   42: resource "snowflake_table_constraint" "primary_key" {
Steps to Reproduce
changelog doens't mention anything about primary keys: https://github.com/Snowflake-Labs/terraform-provider-snowflake/blob/main/CHANGELOG.md#0860-2024-02-15
resource "snowflake_table_constraint" "primary_key" {
  columns  = local.upper_primary_keys
  name     = snowflake_table.this.name
  table_id = snowflake_table.this.id
  type     = "PRIMARY KEY"
}

pinning to version 0.85.0 of the provider does not allow apply to complete successfully because resources were created with a newer version of the module:

│ Error: Resource instance managed by newer provider version
│
│ The current state of module.snowflake.module.my-sub-module["my-table"].snowflake_procedure.etl_proc was created by a newer provider version than is currently selected. Upgrade the snowflake provider to work with this state.

only solution is to destroy resources and redeploy pinned to 0.85.0
How much impact is this issue causing?
High
Logs
No response
Additional Information
No response

Closing this as a dupe of https://github.com/Snowflake-Labs/terraform-provider-snowflake/issues/2535


Importing via LDAP possible or am i doing something wrong ?

Hi , i have set up ldap with zulip and it works fine i just have some questions.
I want to pre subscribe my users to some groups using Java , the thing is that unless the user log in it won't show up as an existing user on Zulip therefore i can't use my java to do things with him .
Is there any way to import the names to Zulip so i can use the API on my users?
Is the sychronization suppose to do this ? Cause in my case i can log in just fine with my ldap users but they only appear on the users list after i log in with them .

The Zulip users are created when the user logs in and only existing users get synced via sync_ldap_user_data - so another tool would need to be built to allow grabbing all user entries in the directory and creating Zulip accounts for them all.


Send MMD trough Kubernetes version of the Event Queue

The deterministic AA files are MMD-ready, start sending through the event queue and register in DMCI using the MMD - agent

Messages are possible to send over the mms running on kubernetes. but we are debugging an error where kubernetes overwrites http-codes and sometimes give 502 when message is sent through.


TP-1088 Support reordering with preemptive transactions

TP-1088 Support reordering with preemptive transactions
Why
In some cases, e.g. we import commodity code changes, we may add preemptive transactions to the draft import workbasket, e.g. to deal with side effects on other models and avoid business rule violations.
This ticket enhances workbasket.approve(), which is also responsible for reordering workbasket transactions, to support both negative and very large transaction orders in the same workbasket.
What
Add a new method to TransactionQueryset that provides the functionality to reorder workbasket transactions when there are negative transactions

Codecov Report

Merging #442 (251418a) into master (b2d3cd7) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #442      +/-   ##
==========================================
+ Coverage   91.84%   91.85%   +0.01%
==========================================
  Files         284      284
  Lines       17232    17255      +23
  Branches     1411     1415       +4
==========================================
+ Hits        15826    15849      +23
  Misses       1136     1136
  Partials      270      270

Impacted Files
Coverage Δ

common/models/transactions.py
90.09% <100.00%> (+0.87%)
:arrow_up:

common/tests/test_transactions.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2d3cd7...251418a. Read the comment docs.


Update tracekit.js to include webpack stacktrace

hi @benvinegar i took this change from here: https://github.com/csnover/TraceKit/blob/master/tracekit.js
it solve situation when you work with webpack with devtool: 'eval' on staging the code that generated starts with "webpack" and the current regex don't match it and i don't have stack trace because of that.

Right – I see the PR here. Alas, I still need a test, or at least a sample stack trace that the environment you're describing generates.

@benvinegar sample: webpack:///./~/react-dom/lib/R or webpack:///./src/components/ it just will always start with wbpack://, basically i don't get why to keep local copy of vendor instead of using the repo as dependency but if you want to keep it you should manage it and update that to have the latest changes.

here is complete stack trace sample:
TypeError: Cannot read property 'error' of undefined
  at TESTTESTTEST.eval(webpack:///./src/components/test/test.jsx?:295:108)
  at TESTTESTTEST.render(webpack:///./src/components/test/test.jsx?:272:32)
  at TESTTESTTEST.tryRender(webpack:///./~/react-transform-catch-errors/lib/index.js?:34:31)
  at TESTTESTTEST.proxiedMethod(webpack:///./~/react-proxy/modules/createPrototypeProxy.js?:44:30)
  at eval(webpack:///./~/react-dom/lib/ReactCompositeComponent.js?:796:21)
  at measureLifeCyclePerf(webpack:///./~/react-dom/lib/ReactCompositeComponent.js?:75:12)
  at ReactCompositeComponentWrapper._renderValidatedComponentWithoutOwnerOrContext(webpack:///./~/react-dom/lib/ReactCompositeComponent.js?:795:25)
  at ReactCompositeComponentWrapper._renderValidatedComponent(webpack:///./~/react-dom/lib/ReactCompositeComponent.js?:822:32)
  at ReactCompositeComponentWrapper._updateRenderedComponent(webpack:///./~/react-dom/lib/ReactCompositeComponent.js?:746:36)
  at ReactCompositeComponentWrapper._performComponentUpdate(webpack:///./~/react-dom/lib/ReactCompositeComponent.js?:724:10)
  at ReactCompositeComponentWrapper.updateComponent(webpack:///./~/react-dom/lib/ReactCompositeComponent.js?:645:12)
  at ReactCompositeComponentWrapper.performUpdateIfNecessary(webpack:///./~/react-dom/lib/ReactCompositeComponent.js?:561:12)
  at Object.performUpdateIfNecessary(webpack:///./~/react-dom/lib/ReactReconciler.js?:157:22)
  at runBatchedUpdates(webpack:///./~/react-dom/lib/ReactUpdates.js?:150:21)
  at ReactReconcileTransaction.perform(webpack:///./~/react-dom/lib/Transaction.js?:140:20)
  at ReactUpdatesFlushTransaction.perform(webpack:///./~/react-dom/lib/Transaction.js?:140:20)
  at ReactUpdatesFlushTransaction.perform(webpack:///./~/react-dom/lib/ReactUpdates.js?:89:32)
  at Object.flushBatchedUpdates(webpack:///./~/react-dom/lib/ReactUpdates.js?:172:19)
  at ReactDefaultBatchingStrategyTransaction.closeAll(webpack:///./~/react-dom/lib/Transaction.js?:206:25)
  at ReactDefaultBatchingStrategyTransaction.perform(webpack:///./~/react-dom/lib/Transaction.js?:153:16)
  at Object.batchedUpdates(webpack:///./~/react-dom/lib/ReactDefaultBatchingStrategy.js?:62:26)
  at Object.enqueueUpdate(webpack:///./~/react-dom/lib/ReactUpdates.js?:200:22)
  at enqueueUpdate(webpack:///./~/react-dom/lib/ReactUpdateQueue.js?:24:16)
  at Object.enqueueForceUpdate(webpack:///./~/react-dom/lib/ReactUpdateQueue.js?:157:5)
  at TESTTESTTEST.ReactComponent.forceUpdate(webpack:///./~/react/lib/ReactComponent.js?:84:16)
  at forceUpdateIfPending(webpack:///./~/react-deep-force-update/lib/index.js?:28:43)
  at traverseRenderedChildren(webpack:///./~/react-deep-force-update/lib/index.js?:6:3)
  at eval(webpack:///./~/react-deep-force-update/lib/index.js?:36:5)
  at eval(webpack:///./~/react-transform-hmr/lib/index.js?:84:28)
  at wrapped(webpack:///./~/raven-js/src/raven.js?:295:29)

basically i don't get why to keep local copy of traceKit instead of using the repo as dependency or using your own fork, but if you want to keep it you should manage it and update that to have the latest changes.

You're welcome to read through the history to see what's changed to the file in order to understand. The TL;DR is that our version is wildly forked, and contains less than half of TraceKit's original code.

here is complete stack trace sample:

Thanks.

Moved to #908 where I've added tests (but retains your original commit)


New Feature - Variadic tuples with noUncheckedIndexedAccess

Variadic tuples were introduced in Typescript 4.0, and they allow some pretty nifty tricks.
If the --noUncheckedIndexedAccess is enabled, it's possible to differentiate arrays that are guaranteed to have at least one element from simple arrays, like so:
type Array1<T> = [T, ...T[]];

const a: Array1<string> = []; // this will show an error
const b: string[] = []; // no error here

and it also correctly types if we want to access some index:

I used this approach in a previous project, but had to define manually all the necessary type guards to check if a standard array has at least one element.
https://github.com/nicu-chiciuc/dependent-ts/blob/59f92dc243bfdc53494fd6e3dfd13efbef026829/src/index.ts#L82
I was wondering if this is something that would be of interest to somebody.

I agree, this is a very useful pattern :) https://github.com/colinhacks/zod#nonempty


main file name should be log-filter.js

this follows the seneca convention to drop the seneca- prefix from file names

I fixed it. PR about to be merged.


Cannot install Firefox 57 on i686-linux

cargo-vendor does not provide binary files for i686-linux[1], with no option to build from source. This ultimately means firefox-57.0 cannot be installed.
[1] https://github.com/NixOS/nixpkgs/commit/5f8cf0048ea089fa73d17512fc4f9f0f0644e225
Full output from nix-env -iA nixpkgs.firefox --show-trace:
replacing old ‘firefox-56.0.2’
installing ‘firefox-57.0’
error: while evaluating the attribute ‘buildCommand’ of the derivation ‘firefox-57.0’ at /nix/store/flkklvjlx5gc6knmj7mkkzwvx67ddl07-nixpkgs-18.03pre121255.45a85eaceb/nixpkgs/pkgs/stdenv/generic/make-derivation.nix:98:11:
while evaluating the attribute ‘nativeBuildInputs’ of the derivation ‘firefox-unwrapped-57.0’ at /nix/store/flkklvjlx5gc6knmj7mkkzwvx67ddl07-nixpkgs-18.03pre121255.45a85eaceb/nixpkgs/pkgs/stdenv/generic/make-derivation.nix:98:11:
while evaluating the attribute ‘cargoDeps’ of the derivation ‘cargo-0.22.0’ at /nix/store/flkklvjlx5gc6knmj7mkkzwvx67ddl07-nixpkgs-18.03pre121255.45a85eaceb/nixpkgs/pkgs/stdenv/generic/make-derivation.nix:98:11:
while evaluating the attribute ‘buildInputs’ of the derivation ‘cargo-0.22.0-vendor’ at /nix/store/flkklvjlx5gc6knmj7mkkzwvx67ddl07-nixpkgs-18.03pre121255.45a85eaceb/nixpkgs/pkgs/stdenv/generic/make-derivation.nix:98:11:
while evaluating the attribute ‘src’ of the derivation ‘cargo-vendor-0.1.12’ at /nix/store/flkklvjlx5gc6knmj7mkkzwvx67ddl07-nixpkgs-18.03pre121255.45a85eaceb/nixpkgs/pkgs/stdenv/generic/make-derivation.nix:98:11:
while evaluating anonymous function at /nix/store/flkklvjlx5gc6knmj7mkkzwvx67ddl07-nixpkgs-18.03pre121255.45a85eaceb/nixpkgs/pkgs/build-support/fetchurl/default.nix:38:1, called from /nix/store/flkklvjlx5gc6knmj7mkkzwvx67ddl07-nixpkgs-18.03pre121255.45a85eaceb/nixpkgs/pkgs/build-support/rust/cargo-vendor.nix:22:9:
attribute ‘i686-linux’ missing, at /nix/store/flkklvjlx5gc6knmj7mkkzwvx67ddl07-nixpkgs-18.03pre121255.45a85eaceb/nixpkgs/pkgs/build-support/rust/cargo-vendor.nix:17:14

same for aarch64-linux

+1

Is this still an issue or can it be closed? Firefox 64 is default now in stable.


fixing wrong link

Both links in this sentence were pointing to the same content, the latter one was clearly wrong. Replacing it with the right link to related tutorial.

@wickste : Thanks for your contribution! The author, @vturecek, has been notified to review your proposed change.


Add libvirt support for Vagrantfile

Hi @g2g ,
Thanks for the addition!
In general, I want to keep this salt-vagrant-demo simple, but this looks interesting.
Can you add some info to the README on how to use this?
Specifically, what dependencies this has and specific command line examples of how to run this with libvirt vs virtualbox.
Also, will this continue to default to virtualbox?

Hi, @g2g
I really appreciate your PR adding support for libvirt. After considering this PR for a while I think I'm not going to merge it.  The purpose of this repo is to demo Salt with Vagrant. Adding support for other virtualization technologies is a great idea, but it does add increased complexity which I think will make it somewhat more difficult for new users to understand what's going on.
I would be open to creating another repo that showcases how to use this with many different virtualization technologies, but I think that repo isn't this repo.


MINOR: Enable the TransactionsBounceTest

I'll let this have multiple runs on the branch builder to see if it fails, and investigate if so.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.11/5735/
Test PASSed (JDK 7 and Scala 2.11).

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/5721/
Test PASSed (JDK 8 and Scala 2.12).

Retest this please

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.11/5736/
Test PASSed (JDK 7 and Scala 2.11).

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/5722/
Test PASSed (JDK 8 and Scala 2.12).

Retest this please

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.11/5744/
Test FAILed (JDK 7 and Scala 2.11).

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/5730/
Test FAILed (JDK 8 and Scala 2.12).

the transactions bounce test didn't fail in the previous runs.

retest this please

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/5733/
Test PASSed (JDK 8 and Scala 2.12).

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.11/5747/
Test PASSed (JDK 7 and Scala 2.11).

cc @ijuma @hachikuji
The test succeeded 8 times in a row. It was never really unstable to begin with, so I think we should enable it to see if there are real issues.

Sounds good to me. What do you think @ijuma?

Sounds good.

Merging to trunk.

Merging for real now.


fix: [ARPA] Update "Workbook" terminology to be consistent (#699)

Renames user-visible references to "spreadsheet" to "workbook". Keeps code-internal references the same.
Ticket
#699
Description
This is a minimal fix for #699, which for now just changes "spreadsheet" to "workbook". The original ticket also proposed changing "template" and "upload", but there are potentially issues with doing this. I've asked for further product guidance around those other changes in Slack.
Screenshots / Demo Video

Testing
Affects working on the following screens:

Home - button text, explanatory text
Upload list - button text
Add/Edit Agency - field description for add/edit agency

Does not impact any backend code or storage.
Checklist

[x] Provided ticket and description
[x] Your PR title contains the ISSUE ticket number e.g "86: ..."
[x] Provided screenshots/demo
[x] Provided testing information
[x] Provided adequate test coverage for all new code
[x] Run automated tests (docker compose exec app yarn test)
[x] Added PR reviewers
[ ] Ensure at least 1 review before merging

One other observation is that our current .editorconfig file with the line max_line_length = 100 -- this is arguably less intelligent than the linting rules that eslint is supplying - maybe we could consider removing this? (github apparently also relies on this file and flagged this in my followup patch!). Let me know if you or others know of reasons to keep this around!


[QUERY] Migrate MessageReceiver.DeadLetterAsync() in v4 to ?? in v5 of Microsoft.Azure.WebJobs.Extensions.ServiceBus

Library name and version
Microsoft.Azure.WebJobs.Extensions.ServiceBus 5.3.0
Query/Question
I have code that was written using Microsoft.Azure.WebJobs.Extensions.ServiceBus v4.3.0 that was dead lettering the message if it didn't pass validation:
    internal sealed class ProcessEventFunction
    {
        private readonly MyEventValidator eventValidator;

        public ProcessEventFunction(MyEventValidator? eventValidator)
        {
            this.eventValidator = eventValidator ?? throw new ArgumentNullException(nameof(eventValidator));
        }

        [Disable("DisableFunctions")]
        [FunctionName(nameof(ProcessEventAsync))]
        public Task ProcessEventAsync(
            [ServiceBusTrigger("%EventTopicName%", "%SubscriptionName%", Connection = "ServiceBusConnection")]
                MyEvent myEvent,
            MessageReceiver messageReceiver,
            string lockToken
        )
        {
                    ValidationResult validationResult = eventValidator.Validate(myEvent);

                    if (!validationResult.IsValid)
                    {
                        await messageReceiver.DeadLetterAsync(lockToken);
                        return;
                    }

                    // Process event
        }
    }

Note the use of the strongly typed message.
I am struggling to figure out how to migrate this to v5.3.0 while also still using strongly typed messages.
As #26564 rightly points out, there is currently nothing in the migration document that mentions sending messages to the Dead Letter Queue.
I did manage to find the Message Settlement section within the package's readme file.  Unfortunately, the mentioned ServiceBusMessageActions DeadLetterMessageAsync() method seems to only take a ServiceBusReceivedMessage and not a strongly typed message.
Can you please provide guidance on how to send a strongly typed message to the Dead Letter Queue using the v5.3.0 package?
Environment
Win64 Azure Function using .NET 6 in process model
Visual Studio 17.1.3

Thank you for your feedback.  Tagging and routing to the team member best able to assist.

I did manage to find the Message Settlement section within the package's readme file. Unfortunately, the mentioned ServiceBusMessageActions DeadLetterMessageAsync() method seems to only take a ServiceBusReceivedMessage and not a strongly typed message.

Can you clarify what you mean by the method not taking a strongly typed message? ServiceBusReceivedMessage is the strongly typed message that the Service Bus library exposes.

Can you clarify what you mean by the method not taking a strongly typed message? ServiceBusReceivedMessage is the strongly typed message that the Service Bus library exposes.

In the sample code I provided, I am binding directly to MyEvent instead of working with ServiceBusReceivedMessage and manually deserializing its body into an instance of MyEvent.  As such, I don't have an instance of ServiceBusReceivedMessage to pass into the DeadLetterMessageAsync method.  I only have the MyEvent instance.

Can you clarify what you mean by the method not taking a strongly typed message? ServiceBusReceivedMessage is the strongly typed message that the Service Bus library exposes.

In the sample code I provided, I am binding directly to MyEvent instead of working with ServiceBusReceivedMessage and manually deserializing its body into an instance of MyEvent. As such, I don't have an instance of ServiceBusReceivedMessage to pass into the DeadLetterMessageAsync method. I only have the MyEvent instance.

I see, in that case you would need to bind to the ServiceBusReceivedMessage as well instead of binding to the lockToken string.

Hmmz, I tried that but I'm receiving this error message:
[2022-04-01T22:03:52.006Z] Microsoft.Azure.WebJobs.Host: Error indexing method 'GenerateEmailsAsync'.
Microsoft.Azure.WebJobs.Host: Cannot bind parameter 'message' to type ServiceBusReceivedMessage. Make sure the parameter Type is supported by the binding. If you're using binding extensions (e.g. Azure Storage, ServiceBus, Timers, etc.) make sure you've called the registration method for the extension(s) in your startup code (e.g. builder.AddAzureStorage(), builder.AddServiceBus(), builder.AddTimers(), etc.).
This is my function definition:
    [Disable("DisableFunctions")]
    [FunctionName(nameof(GenerateEmailsAsync))]
    public Task GenerateEmailsAsync(
        [ServiceBusTrigger("%TopicName%", "%SubscriptionName%", Connection = "ServiceBusConnection")]
            StatusChangeEvent statusChangeEvent,
        [ServiceBus("%SendEmailTopicName%", Connection = "ServiceBusConnection", EntityType = ServiceBusEntityType.Topic)]
            IAsyncCollector<SendEmailEvent> topicCollector,
        ServiceBusReceivedMessage message,
        ServiceBusMessageActions messageActions,
        CancellationToken cancellationToken
    )
    {
        return cancellationToken.IsCancellationRequested
            ? Task.FromCanceled(cancellationToken)
            : ProcessEventAsync(
                statusChangeEvent,
                () => InvalidateEventAsync(message, messageActions),
                (statusChangeEvent, requestTelemetry) => GenerateEmailAsync(statusChangeEvent, requestTelemetry, topicCollector)
            );
    }

The parameter needs to go after the ServiceBusTrigger attribute. Right now it is after the ServiceBus attribute so it is getting associated with the wrong one.

I tried that but now the error message is for my strongly typed Message record:
2022-04-04T17:11:22.736Z] Microsoft.Azure.WebJobs.Host: Error indexing method 'GenerateRSCEmailsAsync'. Microsoft.Azure.WebJobs.Host: Cannot bind parameter 'statusChangeEvent' to type StatusChangeEvent. Make sure the parameter Type is supported by the binding. If you're using binding extensions (e.g. Azure Storage, ServiceBus, Timers, etc.) make sure you've called the registration method for the extension(s) in your startup code (e.g. builder.AddAzureStorage(), builder.AddServiceBus(), builder.AddTimers(), etc.).
This makes me believe that you can only input bind to one message class per function.  As such, my original question stands as I want to bind to my StatusChangeEvent class and not the sdk's ServiceBusReceivedMessage class.
How do I keep using my StatusChangeEvent class as the message class while still being able to dead letter it on demand in v5.3.0 like I could in v4.3.0?

Ah I see. I will look into what we can do to improve this. In the meantime, you can either handle the deserialization into your model within the function body, or alternatively, you can use a workaround to create a ServiceBusReceivedMessage instance in your function body by passing in the lockToken into the ServiceBusModelFactory.ServiceBusReceivedMessage method.

or alternatively, you can use a workaround to create a ServiceBusReceivedMessage instance in your function body by passing in the lockToken into the ServiceBusModelFactory.ServiceBusReceivedMessage method.

Sounds like the ServiceBuseMessageActions.DeadLetterMessageAsync method should have an overload that takes in the lockTokenGuid instead of the ServiceBusReceivedMessage to do this behind the scenes 😀
I'll work on verifying that this resolves my issue.

If we carry the original ServiceBusReceivedMessage around in our code it doubles our memory footprint over when we could just carry around the locktoken, which is a big problem.
The ServiceBusModelFactory workaround works, but it's awkward. Could the reason for making the locktoken overloads internal-only be shared?

@JoshLove-msft If we carry the original ServiceBusReceivedMessage around in our code it doubles our memory footprint over when we could just carry around the locktoken, which is a big problem.
The ServiceBusModelFactory workaround works, but it's awkward. Could the reason for making the locktoken overloads internal-only be shared?

Do you need to carry it around beyond the function invocation? Even if you only bind to the locktoken, the extension still creates the ServiceBusReceivedMessage so that memory is still being allocated.
In terms of the reasoning for the locktoken removal, see https://github.com/Azure/azure-sdk-for-net/issues/10852#issuecomment-679859788

It seems like a mess to me. Why are you making it so hard to handle Service Bus Messaging?
Hours and hours are running through dev teams each day trying to bend everything into a soft six pence.
Very annoying :(

Found this GitHub issue after more digging than I'd like to admit.
Based on this comment by @JoshLove-msft :
https://github.com/Azure/azure-sdk-for-net/issues/27926#issuecomment-1086424433
I tried using ServiceBusReceivedMessage in my function and placing it directly under the attribute
    public async Task RunAsync(
        [ServiceBusTrigger("season_service_create_request", Connection = Constants.ServiceBusConnectionString)] string seasonJson,
        ServiceBusReceivedMessage message,
        ServiceBusMessageActions messageReceiver,
        ILogger log,
        string replyTo,
        string messageId
        )

Doing this gives me this error:
Microsoft.Azure.WebJobs.Host: Error indexing method 'CreateSeasonTrigger'. Microsoft.Azure.WebJobs.Host: Cannot bind parameter 'message' to type ServiceBusReceivedMessage.
I'm also running an in process function, like OP.
I tried doing this same thing in an isolated function just as a test, in case it was only available in isolated functions.
To my amusement, the isolated function does run, but my received message is null:

I'm late to the party when it comes to Az Functions, but it would appear as though we used to be able to manually dead letter messages and now, it seems there isn't a straight forward way to do this?
All I'm looking to do is this:
If any of my own logic throws exceptions based on my business logic, I want to dead letter the message so that 1) I can customize the headers for debugging and 2) There's no need to keep retrying the message if I'm throwing an exception from say, the database entry or something.
Am I overlooking something really simple here?
This seems like a feature that anyone developing a microservice with even basic business logic would want to be able to have access to.

You can still manually dead letter messages, you would just need to remove the string seasonJson parameter and instead get the Json from the ServiceBusReceivedMessage.Body property.

Hey Josh,
Thanks for the tip, and for commenting on the weekend, much appreciated!
That did fix the in process function for me and I'm now able to dead letter just fine.
I tried the same thing with the isolated function though, to see if I could figure out why the message was null and I received this error:
Exception: Microsoft.Azure.Functions.Worker.FunctionInputConverterException: Error converting 1 input parameters for Function 'CreateSeasonTrigger': Cannot convert input parameter 'message' to type 'Azure.Messaging.ServiceBus.ServiceBusReceivedMessage' from type 'System.String'.
I'll need to scour the docs again to find the right way to handle this with isolated functions as we will be migrating to them with .NET 7 this fall.

Sorry, to clarify, manual dead lettering is only currently supported for in process functions. Adding support for isolated functions is actively being investigated.

Gotcha, thanks for the info, Josh.

Sorry, to clarify, manual dead lettering is only currently supported for in process functions. Adding support for isolated functions is actively being investigated.
Along the same lines, binding to the ServiceBusReceivedMessage is only available right now for in-process, but is also being investigated for isolated functions.

@JoshLove-msft consider this a vote for support for SDK types in Isolated Functions.

The core feature request being made in this issue is to include support for completing messages using just the lock token.  After further discussion, this is not a feature that we will be moving forward with at present.  As was mentioned earlier, the rationale for the original decision can be found in #10852.
With respect to the orthogonal discussion around isolated worker support that appears in later comments - this is work in progress.  Currently, it is now possible to bind to SDK types in the isolated Functions context.  We are continuing to collaborate with the Functions runtime team to enable a communications channel that will allow us to support operations like completing messages, though the timeline for this remains unknown.
Closing this out.


How do I provide the key passphrase for the pem key?

I need to provide the key passphrase to unlock the pem key.
I don't see documentation for how to do this?

@jwatte
New option called "pemPassphrase" added to support this ticket.
Fix is available via https://github.com/springml/spark-sftp/commit/f58cab968f48d6fca2c4d3cfabd143e7b3c83b9d

Great! Looking forward to it.


different value of ST_Distance depending on value of always_xyin ST_Transform

Data:  https://s3.amazonaws.com/tripdata/202003-citibike-tripdata.csv.zip
load spatial;

CREATE TABLE biketrip AS SELECT * , st_transform(st_point("start station latitude", "start station longitude"), 'EPSG:4326', 'EPSG:3857') pickup_point,  st_transform(st_point("end station latitude", "end station longitude"), 'EPSG:4326', 'EPSG:3857') dropoff_point FROM '202003-citibike-tripdata.csv';

Explore trip patterns by user type
SELECT
    usertype,
    AVG(tripduration) AS avg_duration,
    AVG(ST_Distance(pickup_point, dropoff_point)) AS avg_distance
FROM
    biketrip
GROUP BY
    usertype;

This returns avg_distance :
Subscribers: 2457.47758
Customer: 3017.728121
While if we do:
load spatial;

CREATE TABLE biketrip AS SELECT * , st_transform(st_point("start station latitude", "start station longitude"), 'EPSG:4326', 'EPSG:3857', true) pickup_point,  st_transform(st_point("end station latitude", "end station longitude"), 'EPSG:4326', 'EPSG:3857', true) dropoff_point FROM '202003-citibike-tripdata.csv';

Explore trip patterns by user type
SELECT
    usertype,
    AVG(tripduration) AS avg_duration,
    AVG(ST_Distance(pickup_point, dropoff_point)) AS avg_distance
FROM
    biketrip
GROUP BY
    usertype;

I think this is a bug in ST_Transform because the distance seems to be computed correctly. Moreover, when using always_xy=True the transformation matches with geopandas. Meaning that the problem is most likely in the default implementation of st_transform.
Geopandas transformation example:
import geopandas as gpd
import pandas as pd

df = pd.read_csv('202003-citibike-tripdata.csv')
pickup_points = gpd.points_from_xy(df['start station latitude'], df['start station longitude'])
pickup_points.crs = 'EPSG:4326'
pickup_points.to_crs('EPSG:3857')

The points returned after this operation, match with
st_transform(st_point("start station latitude", "start station longitude"), 'EPSG:4326', 'EPSG:3857', true) pickup_point

With just having a cursory glance at this, is this not expected? You are passing latitude/longitude in both cases, even when always_xy = true where it should be lon/lat. IIRC geopandas always does the equivalent of always_xy := true by default which is why you get a different result when you don't use it.
ST_Distance does not take the projection into account, it just does a cartesian distance calculation.

I think we definitely misunderstood on our end what this parameter does, but after some thought I think now we do? please confirm if this is the right interpretation for duckdb implementation:

Output is always in x, y format
The assume input (with default value always_xy=False) is lat/long which is equivalent to y, x
If the user is providing input data as lon/lat they need to pass always_xy=True

Well yes, but it also depends on the projection parameters you pass in. I think the big source of confusion is that wgs84 (epsg 4326) is standardized to be in lat/lon (even though almost all gis systems ignore that and pretend its always lon/lat), while basically every other projection youd care about is in lon/lat.

Thanks @Maxxen this is very helpful. Closing this.

For what its worth we will probably change this at some point to be consistent with the rest of the ecosystem, see eg #63


Graphical edit view does not display code differences between languages

When editing a code sample available in several languages, the graphical edit view does show the same code for every languages, even if they have different code samples (which you can see in the raw view and when previewing/publishing changes).

Graphical view:

Raw view:

Reproduced on Firefox 44.0.2 and Chrome Version 48.0.2564.116 (64-bit).

Fixed in 1cf7bd9398a9533b7979ce7a8b8b4d5a1b8606bf


Update styling

[ ] Mentor is added to pr

[ ]  AC copied to pr description

[ ]  Link to deployed version is added to pr

[ ]  Simple Pagination component (without ...) is added and works correctly

[ ]  On the 1st page button Back should be disabled, same as button Forward on the last page

[ ]  Interaction with pagination should not change or break sorting and filtration.

[ ]  Category filter (multi-select) is added and works correctly

[ ]  Sorting input (single select) is added and works correctly

[ ]

[ ] Interaction with filter and sorter should reset pagination and move a user to the 1st page

[ ] Pagination component with ... is implemented according to [design]

[ ]  Search input works correctly

As @MZabolotnev is on vacation, @serhii-tsivinskyi-moc  please review


[jax2tf] Incorrect translation for jax.lax.round

import jax
import jax.experimental.jax2tf as jax2tf
import jax.numpy as jnp
import tensorflow as tf
tf.compat.v1.enable_eager_execution()

print("Jax:", jax.lax.round(0.5))
print("Jax2Tf:", jax2tf.convert(jax.lax.round)(0.5))

Jax: 1.0
Jax2Tf: tf.Tensor(0.0, shape=(), dtype=float32)

The issue is coming from the fact that jax.lax.round uses away from zero rounding based on what the corresponding XLA op is doing but then it maps to tf,round what does round towards even.

@bchetioui Is this now fixed?

@hawkinsp I think #4959 is ready, but it has not been merged!


Update README.md

Added link to "awesome-powershell“

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

Please remove trailing spaces:

C:\projects\powershell\README.md: 84: MD009 Trailing spaces

@SRGOM Approve option is for reviewers only.


added some extra signatures

Some of the plugins were missing signatures. Feel free to rid of the comments. More soon, team.

Hey @ChairsDaily,
Thanks for makng this PR. Much appreciated! Please keep them coming.


[5.3][ConstraintSystem] Properly diagnose operator reference ambiguities

If operator is referenced instead of applied e.g. arr.sort(by: <)
ambiguities should be diagnosed as no exact matches with attached
notes describing a failure associated with each potential candidate.
Resolves: rdar://problem/62054241
(cherry picked from commit bb414927a0b4d75d2a66ae38ad468f62868a10cf)
Reviewed by: @hborla

@swift-ci please test

Build failed
Swift Test Linux Platform
Git Sha - f7ed98fa6463db88fab6c6a4f2b0494da37d152f

@swift-ci please test

Build failed
Swift Test Linux Platform
Git Sha - f7ed98fa6463db88fab6c6a4f2b0494da37d152f

Build failed
Swift Test OS X Platform
Git Sha - f7ed98fa6463db88fab6c6a4f2b0494da37d152f


fota upgrade use 5684

hi
For FOTA upgrade, requests cannot arrive with port 5684.I want to know why.
the url likes coap://xxxx.xxx.xxx.xx:5684/fota/xxx.name.use coaps?
thanks.

Could you give us more context...
Which clients or server are you using ? where Leshan is involved ? (which version of Leshan ?)
Describe more precisely steps to reproduce the issue.

thanks for you reply.
the version leshan 1.0.0-M5 and use leshan-server-cluster.
we send a coap url to device.
The scenario is that we send a COAP URL to the device, which is like coap://xx xx.xxx.xx:5684. Then we found that the device did not request our Resource which to inherit from CoapResource. Then it changed to 5683 and found that it was possible to access the Resouce.

It's not clear but I suppose you don't use Leshan for your client ?
It's seems your client does not really like that you are using the default coaps port (5684) with coap:// url ...
The rfc7252 defines :

default coap port is 5683
default coaps port is 5684

But you should be able to not respect this default value, so I would say that your client is buggy ...
Just in case about leshan-server-cluster, it's pretty experimental and will probably not be part of the 1.0.0 final release (see cluster northbound api , module descriptions and roadmap)

Could we close this issue ?

(feel free to reopen it if needed)


Address code scanner issues

There are still some warnings. Not sure if everybody has access to them, so I create this as a reminder for me to either fix or create proper issues for them

Can you specify this in a way that everyone can have a look at this?


Error loading nes.py plugin

When I load a rom into the nes.py plugin in binary ninja 1.0.307 build f2ac3d81 on OS X 10.11.6 I get this error:
Traceback (most recent call last):
  File "/Applications/Binary Ninja.app/Contents/MacOS/plugins/../../Resources/python/binaryninja/__init__.py", line 883, in _is_valid_for_data
    return cls.is_valid_for_data(BinaryView(None, handle = core.BNNewViewReference(data)))
  File "/Users/stefan/Library/Application Support/Binary Ninja/plugins/nes.py", line 529, in is_valid_for_data
    hdr = data.read(0, 16)
  File "/Applications/Binary Ninja.app/Contents/MacOS/plugins/../../Resources/python/binaryninja/__init__.py", line 1574, in read
    buf = DataBuffer(handle = core.BNReadViewBuffer(self.handle, offset, length))
NameError: global name 'offset' is not defined

This error doesn't appear to be coming from the plugin code, but from within binary ninja D:

Sorry about that, some last-minute changes to the Python API documentation caused trouble. We're planning on pushing an update to fix it -- in the meantime, you can pull the latest version manually from here and update and it should work fine: https://github.com/Vector35/binaryninja-api/tree/dev/python
The only thing you need to download is the __init__.py and replace the version in the install path of your copy of binary ninja. When it auto-update to the newest version it will automatically put the latest in place and shouldn't cause any problems.


can't get v.55.4 remote debugging to work

--------------^ Click "Preview" for a nicer view!
Get help with your React Native app or ask code-level questions
Unfortunately I can't ask Stack Overflow questions with my account, only add comments.
I am unable to  get the remote debugging to work with the current RN version 55.4. is there something I'm missing? the app work OK otherwise on both the emulator and on the actual device, I just can't get the remote debugger to work!

thanks; issue has been resolved, I found the answer in the react-native
github pages.
On Tue, Jun 5, 2018 at 8:06 PM, Bot<EMAIL_ADDRESS>wrote:

Please use Stack Overflow
http://stackoverflow.com/questions/tagged/react-native for this type of
question.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/facebook/react-native/issues/19583#issuecomment-394898527,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AcucznOseoefemC6Ot0tcK1ZdL11Lqp1ks5t5x0dgaJpZM4UbyHK
.


Add support for Jinja2 extensions and custom preprocessors

Simple solution for #55. A slight variation on what I proposed there: decided it was easier & more explicit to separate jinja2 / preprocessors in podspec.yaml:
extensions:
  jinja2:
  - path.to.CustomJinja2Extension
  preprocessors:
  - path.to.CustomPreprocessor

See the example in grow/testing/testdata/pod/podspec.yaml.
Custom Jinja2 filters would need to be wrapped in an extension class (i.e. a subclass of) — the tests I’ve written for this include an example of this. Could add syntax to allow filters to be declared directly in podspec.yaml (then added to the env via the filters arg) — maybe at a later date?
Happy to write some docs for this once merged — should that be a PR against https://github.com/grow/growsdk.org?

Great work on this and thank you for the contribution. :) The solution looks great from a quick glance.
Before merging, I'm doing a tiny bit of research on naming and the syntax in podspec.yaml. Can you adjust the PR to be based off of develop instead of master? master is what's currently released.
Also, before releasing this I'd like to perhaps iterate on the "public API" for writing extensions -- for example, it might be cleaner to allow import grow and then for the base class to be grow.Preprocessor (via an alias in the right place in __init__.py). This would basically be the first time the internal paths of the Python program have any implication on how folks construct sites.
Additionally (just as a reminder to myself) – need to test the behavior of the imports in the frozen/binary environment.

Closing this — will re-raise against develop.


[charlie] cache chainspec

Cherry picks #281 on top of charlie branch.

@momipsl here's a branch that caches the chainspec – this should improve the node performance when handling incoming deploys and handling/creating new blocks. We should test it using the same setup as described in https://github.com/CasperLabs/stests-reports/blob/master/0001/report.md


LegendText performance

This issue was imported from CodePlex
lloydchriswilson wrote 2011-08-18 at 01:09
I know the application is still in testing and so performance is not a high priority issue, however I am testing my code and adding several moderate size line and polygon shape files. Using ANTS profiler, I find that my calls to set the LegendText property
take a long time as compared to the Layers.Add(shapefile) routine, which of course should take quite some time due to the file io. In one test, six calls to LegendText take 12 seconds whereas the same number of calls to Layers.Add take 31 seconds.
It seems odd that just setting the text should take such a large percentage of time.

Not reproduced.


feat: Added UDT for Managed identity and Deployment Scripts

Description
This pull request introduces two user-defined types for the following modules:

Deployment scripts -> (secure) environment variables (tagging module owner: @sebassem)
User Assigned Managed Identity -> federated identity credentials (tagging module owner: @elanzel)
Removed an unused line of code in .github/actions/templates/avm-validateModuleDeployment/action.yml

Extra context regarding @secure() decorator on user-defined type. When the Bicep template is built the type is referred as a secureString so the parameter inherits the secureString type and the parameter is secure during deployment:

Also double checked if the outputs were working and tested it via this Bicep template:
/* Bicepparam
using './testsecureoutput.bicep'

param parTestingParameter = {
  secureList: [
    {
      name: 'test'
      secureValue: 'test123'
    }
  ]
}
*/

param parTestingParameter environmentVariableType

output outTestBool bool = parTestingParameter != null
output outTestArray array = parTestingParameter != null ? parTestingParameter!.secureList : []
output outTestArrayV2 array = parTestingParameter!.secureList ?? []
output outTestString string = first(parTestingParameter.secureList)!.secureValue!

@secure()
type environmentVariableType = {
  secureList: {
    name: string
    secureValue: string?
    value: string?
  }[]
}?

Pipeline Reference

Type of Change

[ ] Update to CI Environment or utlities (Non-module effecting changes)
[ ] Azure Verified Module updates:

[ ] Bugfix containing backwards compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:

[ ] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
[ ] The bug was found by the module author, and no one has opened an issue to report it yet.

[x] Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
[ ] Breaking changes and I have bumped the MAJOR version in version.json.
[x] Update to documentation

Checklist

[x] I'm sure there are no other open Pull Requests for the same update/change
[x] I have run Set-AVMModule locally to generate the supporting module files.
[x] My corresponding pipelines / checks run clean and green without any errors or warnings

@AlexanderSehr FYI - had some issues with the randomised resource location selector on the deployment of the user-assigned managed identity. It deployed in eastasia, but that region does not support federated credentials. Maybe being able to override the location would be handy.

@AlexanderSehr FYI - had some issues with the randomised resource location selector on the deployment of the user-assigned managed identity. It deployed in eastasia, but that region does not support federated credentials. Maybe being able to override the location would be handy

Hey @johnlokerse,
that's indeed unfortunate as the location selector tries to only select regions where the resource exists, yet fails if certain features don't exist.
I worked around it in some other module recently by introducing an additional parameter to enforce a certain location
https://github.com/Azure/bicep-registry-modules/blob/a964d0c128afd8ccfe1d2ecbb3428868214cdf17/avm/res/purview/account/tests/e2e/max/main.test.bicep#L24-26
cc: @eriqua, @ChrisSidebotham fyi


fix(test): Add OIDC token refresh to int_test pipeline

Running into token timeout issues all over the place, this script is a stop-gap until a new Az CLI version (2.60.0 currently) fixes issues refreshing OIDC federated tokens.
This adds a script that runs every 4 minutes to request a new federated token for the CLI, which runs in the background while the rest of the tests complete.

This project has adopted the Microsoft Open Source Code of Conduct. For more information see the Code of Conduct FAQ or contact<EMAIL_ADDRESS>with any additional questions or comments.
Thank you for contributing to Azure IoT Operations tooling!
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Intent for Production

[ ] It is expected that pull requests made to default or core branches such as dev or main are of production grade. Corollary to this, any merged contributions to these branches may be deployed in a public release at any given time. By checking this box, you agree and commit to the expected production quality of code.

Basic expectations

[ ] If introducing new functionality or modified behavior, are they backed by unit and/or integration tests?
[ ] In the same context as above are command names and their parameter definitions accurate? Do help docs have sufficient content?
[ ] Have all the relevant unit and integration tests pass? i.e. pytest <project root> -vv. Please provide evidence in the form of a screenshot showing a succesful run of tests locally OR a link to a test pipeline that has been run against the change-set.
[ ] Have linter checks passed using the .pylintrc and .flake8 rules? Look at the CI scripts for example usage.
[ ] Have extraneous print or debug statements, commented out code-blocks or code-statements (if any) been removed from the surface area of changes?
[ ] Have you made an entry in HISTORY.rst which concisely explains your user-facing feature or change?

Azure IoT Operations CLI maintainers reserve the right to enforce any of the outlined expectations.
A PR is considered ready for review when all basic expectations have been met (or do not apply).

Running test here:
https://github.com/c-ryan-k/azure-iot-ops-cli-extension/actions/runs/8838708756/job/24270515723


Add schedule project link to planning agenda

I'm hoping to update the query to use project fields and make everything nice later.

Okay, I added the query logic. PR is a big bigger now.


When in replace menu tab key does not cycle through buttons

I have updated to spyder 3.0.2 and found that pressing  does not cycle through the different buttons and fields in the replace pane; this used to be the case in the previous version I used (2.something)

@mariacamilaremolinagutierrez take a look at this one

I think this is closely related to https://github.com/spyder-ide/spyder/issues/3674

You're right. Closing as a duplicate of issue #3674.


whenReachable() and whenUnreachable() do not work

Hello. Can you help me with my problem? I have always used this framework in my apps but now I can't figure out what I am doing wrong.
In my viewDidLoad() function I call this method:
//MARK: Reachability
func startReachability(){
//declare this property where it won't go out of scope relative to your listener
do{
    let reachability = try Reachability.reachabilityForInternetConnection()

    reachability.whenReachable = { reachability in
        // this is called on a background thread, but UI updates must
        // be on the main thread, like this:
        dispatch_async(dispatch_get_main_queue()) {
            if reachability.isReachableViaWiFi() {
                print("Reachable via WiFi")
            } else {
                print("Reachable via Cellular")
            }
        }
    }
    reachability.whenUnreachable = { reachability in
        // this is called on a background thread, but UI updates must
        // be on the main thread, like this:
        dispatch_async(dispatch_get_main_queue()) {
            print("Not reachable")
        }
    }

    try reachability.startNotifier()

} catch {
    print("Unable to start notifier")
}
}

But it does not work. It calls whenReachable() and whenUnreachable() only once and when I turn Wi-Fi off and on it does nothing. I use 2.4 version.

Same for me using iOS 10 and debugging on a real device.

You need a strong reference to your reachability variable, so declare it at class level. See the example in the readme, issues #93, #85

@ashleymills thank u very much) it is evident but sometimes shit happens)))


zigConsole template maintainance

@kassane as maintainer of this template, would like to continue maintaining?
The next update will bump major, with breaking changes, and we will clean the templates. Let us know.
#268

I will update support for v0.13.0 of zig.
Thanks for the feedback, by the way.

@kassane We are still on bookworm. The changes that we did are related with the Torizon OS version, so the new one Torizon OS7 will use base containers with tag 4 instead of 3, but they still use bookworm.


Fix product category page facets 'plus'/'minus' icon

Currently 'plus'/'minus' icon in facets doesn't change on click (facet expand/collapse).

QA

expand / collapse facet navigation
confirm the plus/minus icons are shown

tested dev17, passing


[feature request] more contextual info customMerge

Hi,
Would it be possible to supply the target and source object to options.customMerge?
In the situation below, I want to check for the existence of source.objNeedingCustomMerge.
So I want to check on a child key name instead of the default key (in the below case I would get b and c as the 'key' parameter, but I would like to know if source[key].objNeedingCustomMerge exists).
const targetObj = {
  // this obj needs deep merge
  a : { keyA1: 'xTarget', keyA2: 'yTarget', },
  // this object needs to be replaced by source.b
  b : { objNeedingCustomMerge: true, keyB1: 'z' },
  c : { objNeedingCustomMerge: true, keyC1: 'z' },
}

const sourceObj = {
  a : { keyA2: 'ySource', keyA3: 'zSource', },
  b : { somethingCompletely: 'different' },
  c : { somethingElse: 'different' },
}

Expected result:
{
  a : { keyA1: 'xTarget', keyA2: 'ySource', keyA3: 'zSource', },
  b : { somethingCompletely: 'different' },
  c : { somethingElse: 'different' },
}

Would it be possible to allow for this?
const result = deepmerge(targetObj, sourceObj, {
  customMerge: (key, targetCurrLvl, sourceCurrLvl) => {
     if ('objNeedingCustomMerge' in targetCurrLvl[key]) {
       return () => sourceCurrLvl[key];
     }
  },
});

This should hopefully do what you want (completely untested):
const result = deepmerge(targetObj, sourceObj, {
  customMerge: (key) => (targetCurrLvl, sourceCurrLvl, options) => {
    if ('objNeedingCustomMerge' in targetCurrLvl[key]) {
      return sourceCurrLvl[key];
    }
    return deepmerge(targetCurrLvl, sourceCurrLvl, options);
  },
});

Ah, I see, since the fallback function is deepmerge again (https://github.com/TehShrike/deepmerge/blob/master/index.js#L24)
Thanks! 👍
I also noticed this merge request implements the exact thing requested above, so will wait for that as well: https://github.com/TehShrike/deepmerge/pull/228/files#diff-e727e4bdf3657fd1d798edcd6b099d6e092f8573cba266154583a746bba0f346R64