Feature - Image optimisation

Had to install Spatie package for the image optimisation. It works with tools that should be installed additionally so:

Get the new package - composer update/install
Refer to this so that you install the tools (they need to be installed in the container)

Currently added only on the logo upload.
On my machine it works quite slow so I really hope it's just my machine. If you decide that it is too slow, we may try to configure it or even remove it. We should also probably alter the docker compose file to automatically download those tools when the container is build.

Had to install Spatie package for the image optimisation. It works with tools that should be installed additionally so:
1. Get the new package - composer update/install

2. Refer to [this](https://github.com/spatie/image-optimizer#optimization-tools) so that you install the tools (they need to be installed in the container)

Currently added only on the logo upload.
On my machine it works quite slow so I really hope it's just my machine. If you decide that it is too slow, we may try to configure it or even remove it. We should also probably alter the docker compose file to automatically download those tools when the container is build.

I am wondering on how this would would work on the production environment. I am not sure if we are able to install these tools on there.

Had to install Spatie package for the image optimisation. It works with tools that should be installed additionally so:
1. Get the new package - composer update/install

2. Refer to [this](https://github.com/spatie/image-optimizer#optimization-tools) so that you install the tools (they need to be installed in the container)

Currently added only on the logo upload.
On my machine it works quite slow so I really hope it's just my machine. If you decide that it is too slow, we may try to configure it or even remove it. We should also probably alter the docker compose file to automatically download those tools when the container is build.

I am wondering on how this would would work on the production environment. I am not sure if we are able to install these tools on there.

Probably need to talk with @dwaard tomorrow and maybe check with Elio as well


Smart Editor - Ability to sketch in mutliple features then perform edit

Widget
Smart Editor
Version of widget
2.1
Enhancement
Ability to add multiple features and then save all at one time. For example: when doing project sketching I want to sketch all features (cables, patch panels, etc.) at one time. Though I need to change feature templates, it would be nice to have the ability to go back choose another template and add those features versus add new cable, save, add patch panel, save, add new cable save. Ideally, it would be add new cable, add patch panel, add new cable save.

@clareprice


Set n_pcs when use_rep is specified in sc.pp.neighbors

[X] Additional function parameters / changed functionality / changed defaults?

Sorry to file two issues in a row! I've been using Scanpy + scVI for my analysis recently, and am really enjoying it!
Currently, if use_rep is set in sc.pp.neighbors, then n_pcs is ignored. These seems like sane default behaviour to me - if we aren't using 'X_pca', then n_pcs doesn't really make sense.
This can actually be limiting, as I recently discovered. If you calculate a latent representation with scVI with n_latent = 50, you can't then do...
sc.pp.neighbors(adata, use_rep='X_scvi', n_pcs = 25)

...as the neighborhood graph is calculated on all 50 latent variables. If I want to use only 25 - say, as a point of comparison to see which best represents my data - I have to recalculate the latent representation with scVI with n_latent = 25. Basically, if you aren't using PCA, you have to calculate a full reduction for every number of dimensions you are interested in.
I don't think the fix would be that major. The source seems to be in the _choose_representation function, with the directly relevant snippet below:
https://github.com/theislab/scanpy/blob/5bc37a2b10f40463f1d90ea1d61dc599bbea2cd0/scanpy/tools/_utils.py#L48-L58
I think the only change needed would be to have the n_pcs is not None catch in all cases, not just when use_rep = 'X_pca'. Might also generalise the variable name to make it more clear it refers to any reduction, not just PCA. Admittedly, I only just started exploring the code base, so I'm not sure where else _choose_representation is called, or what other impacts this could have.
I have some blue sky time tomorrow, so I'll fork it then and see if I can whip up a pull request. Thanks for the excellent product!

And I just saw #1267, which mentioned the subsetting option and totally solves the problem. If you all are interested in having this functionality as an option, leave this open, let me know, and I'll work on a pull request. Otherwise, feel free to close it. Sorry for the (sort of) repeat.


Spring cleaning part 1: Remove ConsistentRNG, silence StatsTools tests

Remove ConsistentRNG
Make StatsTools tests less noisy
Fix MPI tests on multiple ranks

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

11 of 13 (84.62%)  changed or added relevant lines in 5 files are covered.
27 unchanged lines in 5 files lost coverage.
Overall coverage decreased (-0.4%) to 89.507%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/RMPI/helpers.jl
0
2
0.0%

Files with Coverage Reduction
New Missed Lines
%

src/RMPI/helpers.jl
1
70.27%

src/StatsTools/reweighting.jl
1
96.02%

src/BitStringAddresses/fermifs.jl
3
94.7%

src/strategies_and_params/memorystrategy.jl
3
4.76%

src/apply_memory_noise.jl
19
16.49%

Totals

Change from base Build<PHONE_NUMBER>:
-0.4%

Covered Lines:
4231

Relevant Lines:
4727

💛  - Coveralls


Unable to connect to Linux box

System.Net.WebException: 'The underlying connection was closed: Could not establish trust relationship for the SSL/TLS secure channel.'
AuthenticationException: The remote certificate is invalid according to the validation procedure.
Reason: HTTP error while creating session on the machine 'Linux'.
Exception: The underlying connection was closed: Could not establish trust relationship for the SSL/TLS secure channel.

https://github.com/Microsoft/RTVS/commit/54426fb36461586ce1e7ca1e1466614ccdd69cee


Outlook Mail Tool - Search results for specific dates which are more than a week older result in incorrect results.

Electron build - https://github.com/gptscript-ai/desktop/commit/2fa0a180691b6de6c7a678015415f9ba6595ef91
Steps to reproduce the problem:

Start a chat with Tildy.
Add Outlook Mail tool.
Ask to list emails received on any day like today , yesterday or a specific date

I see that the searchMessages call always fails and user is presented with this message which gets overwritten when call to listMessage with folderid is done with no other criteria.
Most of the time i end up getting correct results since the emails returned from the folderId search has the necessary information we need for last 1 weeks seems like.

These are the stack traces showing  searchMessages calls failing and resorting to listMessage

When I make queries to fetch messages for an older date like 7/01/2024 , it gives few random emails from last week as response:

This is from outlook email client that shows the right date when this email was received:

Tracked in otto


Add: Canal 79 Villa Maza

Channel Name
Canal 79 Villa Maza
Alternative Names (optional)
No response
Network (optional)
No response
Owners (optional)
No response
Country
AR
Subdivision (optional)
No response
City (optional)
Villa Maza
Broadcast Area
c/AR
Languages
esp
Categories (optional)
general
NSFW
FALSE
Launched (optional)
No response
Closed (optional)
No response
Replaced By (optional)
No response
Website (optional)
https://canal79tv.com.ar/
Logo
https://canal79tv.com.ar/wp-content/uploads/2021/06/canal_79_gif.gif
Notes
No response

https://iptv-org.github.io/channel?id=Canal79VillaMaza.ar


[NIFI-2105] [NIFI-2106] fix status history dialog issues

Reviewing...

Thanks @scottyaslan! This has been merged to master.


Add match_phrase query

Hi Jeroen :)
I also added the 'match_phrase' query
Let me know if I need to add more tests
Thanks,
Christian

Thank you!


Table of contents fails on international characters

Detected on https://rocketvalidator.com/s/4ec0b390-f775-4db1-87a4-ced8f5ece619/p/4686420/i
It looks like the tables of contents for lessons does not generate the headings when those contain non-English characters.
While in the legacy site it works fine:
https://elixirschool.com/es/lessons/specifics/mnesia/#inicialización-de-datos-y-migración
the beta site doesn't work OK:
https://beta.elixirschool.com/es/storage/mnesia

Headings containing non-English characters like "inicialización" are not being generated.

I took a look at this and the culprit appears to be the @headers_regex in the SchoolHouse.Content.Lesson module. The regex scans the body of the lesson and finds header tags to construct the TOC. Right now, the regex does not include accented characters in the main capture group.
I am not familiar with capturing accented characters in regex so I went to Stack Overflow of course and found this suggestion for matching all characters (accented and unaccented): A-Za-zÀ-ÖØ-öø-ÿ . If we update the regex used in the Lesson module, it would look like:
# current regex
@headers_regex ~r/<(h\d)>(["\w\s?!\.\/\d]+)(?=<\/\1>)/i

# proposed regex
@headers_regex ~r/<(h\d)>(["A-Za-zÀ-ÖØ-öø-ÿ\s?!\.\/\d]+)(?=<\/\1>)/i

I can go ahead and create a pr for this and add tests for this use case specifically, but before I do I want to see if there are any suggestions or improvements we can make to this regex update.

Sounds fine, here are some accented character I can think of, to include in your tests:
áéíóú
àèìòù
âêîôû
äëïöü
ñ ç

and in uppercase:
ÁÉÍÓÚ
ÀÈÌÒÙ
ÂÊÎÔÛ
ÄËÏÖÜ
Ñ Ç

Also, found this - there's a regex match for international characters!
https://davidwalsh.name/regex-accented-letters

Thanks for sharing that link, that's a much better approach. I tried using \p{Letter} and got an error but I was able to find the solution pretty quickly: \p{L}


New industry sector data from REMIND, for baseline scenarios.

A new iteration of REMIND industry sector data. Please have a look. Specific energy figures should be somewhat more plausible:

Remaining issues are the values for IND, where the IEA numbers for energy consumption of the steel sector seem to be quite high, leading to high values there, and, NEU, MEA, and USA, whose production is too efficient. Total production figures seem to be in line with IEA.

@Loisel why did you close it?

@Loisel why did you close it?


Spurious constructor/destructor call

Basically one of the examples, except I added print statements to the PerSocketData's constructor/destructor. For some reason, the destructor is getting called immediately after a connection opens.
/* We simply call the root header file "App.h", giving you uWS::App and uWS::SSLApp */
#include "App.h"

/* This is a simple WebSocket echo server example.
 * You may compile it with "WITH_OPENSSL=1 make" or with "make" */

int main() {
    /* ws->getUserData returns one of these */
    struct PerSocketData {
        /* Fill with user data */
	PerSocketData() {
		std::cout << "Constructor call, this = " << std::hex << this << std::endl;
	}

	~PerSocketData() {
		std::cout << "Destructor call, this = " << std::hex << this << std::endl;
	}
    };

    /* Keep in mind that uWS::SSLApp({options}) is the same as uWS::App() when compiled without SSL support.
     * You may swap to using uWS:App() if you don't need SSL */
    uWS::SSLApp({
        /* There are example certificates in uWebSockets.js repo */
	    .key_file_name = "../misc/key.pem",
	    .cert_file_name = "../misc/cert.pem",
	    .passphrase = "1234"
	}).ws<PerSocketData>("/*", {
        /* Settings */
        .compression = uWS::SHARED_COMPRESSOR,
        .maxPayloadLength = 16 * 1024,
        .idleTimeout = 10,
        .maxBackpressure = 1 * 1024 * 1024,
        /* Handlers */
        .open = [](auto *ws) {
            /* Open event here, you may access ws->getUserData() which points to a PerSocketData struct */
        },
        .message = [](auto *ws, std::string_view message, uWS::OpCode opCode) {
            ws->send(message, opCode, true);
        },
        .drain = [](auto *ws) {
            /* Check ws->getBufferedAmount() here */
        },
        .ping = [](auto *ws) {
            /* Not implemented yet */
        },
        .pong = [](auto *ws) {
            /* Not implemented yet */
        },
        .close = [](auto *ws, int code, std::string_view message) {
            /* You may access ws->getUserData() here */
        }
    }).listen(9001, [](auto *token) {
        if (token) {
            std::cout << "Listening on port " << 9001 << std::endl;
        }
    }).run();
}

Output:
Listening on port 9001
Constructor call, this = 0x7fffffaed3b0
Destructor call, this = 0x7fffffaed3b0                    // Executed immediately after opening a connection
Destructor call, this = 0x558fc8161e50                    // Executed on disconnect

I believe that for this particular example, the actual "useful" memory allocated for the struct was at 0x558fc8161e50. Not sure what's going on at  0x7fffffaed3b0.
The only reason I feel obligated to report this is because I am worried this could be exploited. However, I'm not as familiar with the internals, so I'll defer on this one.

I don't remember the internals here but this looks like a move. Will have a check. What you could do is print the open and close events and see what happens if you put a std::string in open and use it from close. The Node.js addon makes heavy use of PerSocketData so it obviously works as is, but maybe not entirely as one would expect.

We have an issue that may be related.  We do stress testing by letting an external system open (and close) thousands of connections to our uWebsocket listener.
When the rate of opening connections becomes too high (approaching 1000 per second) we see intermittent memory faults:
Segmentation fault
Similarly when the rate of closing connections becomes too high (around 4000 per second) we see:
corrupted double-linked list
Our debugging efforts have focused mainly on PerSocketData, tracking the pointers and comparing "opens" to "closes" but as yet we have not succeeded in identifying any definitive issue.

This is a move. You can see it in App.h at around line 200. The struct is created, moved, then destructed. Then you destruct the moved one when it is disconnected. This is the intended behavior and not a bug.
@AnwaPeck That's something entirely different. You most definitely have issues in your business logic.


chore(Blog): update “2016-12-17-making-sense-of-the-scaas-new-flavor-wheel”

Automatically generated by Netlify CMS

👷 Deploy Preview for lucileetguillaume processing.
🔨 Explore the source changes: f4df8d9df5c809b9888487f8e72e7d12c32cb6af
🔍 Inspect the deploy log: https://app.netlify.com/sites/lucileetguillaume/deploys/615eaca0f38b59000755b9a8


add a new custom backend for extensions?

TL;DR allow alternative controllers/operators/steps to populate Secret resources from ExternalSecret CRDs; so add a backendType to the CRD which the external secrets controller ignores and indicates some custom/out of band mechanism does the population.
Background
We're using https://github.com/godaddy/kubernetes-external-secrets by default in Jenkins X 3.x now and its working awesome. However we have a requirement to support just regular kubernetes secrets (i.e. no vault / cloud secret storage) - particularly for low resource usage (e.g. folks trying Jenkins X on minikube).
We'd like to still use ExternalSecret CRDs though but have a backendType string we can use which if the external secrets controller is running its just ignored for that ExternalSecret. Maybe folks could combine custom backend with vault/others too?
This might sound strange; but from a GitOps perspective we want to check in all resources to git - apart from Secrets. So the pipelines in Jenkins X converts all Secret resources generated by helm / helmfile / kustomize / kpt to ExternalSecret resources and check them in.
Then when using vault / (Amazon | Azure | Google) Secret manager then the external secrets controller populates the Secret resources. When not using any of those, we can populate those Secret resources automatically via Jenkins X so we don't need the external secrets controller to do anything. So we basically want a kind of noop backendType.
Currently we've a minor hack ;) - when folks are not using vault / * Secret Manager, we install a modified version of the external secrets CRD which adds a new local backendType (then we don't install the external secrets controller) but it'd be nice to submit a PR on this git repository and add this backendType for real to both the CRD and the controller.
So I thought I'd raise this issue first to see what you thought about the idea. If you're cool with it I'll try create a PR.
While the use case for Jenkins X might seem fairly specific - I could see folks wanting to use custom scripts/pipelines/tools/mechanisms to populate Secret resources - but still reuse the ExternalSecret CRDs to describe the Secret resources that are required.
Aside
Incidentally we've got a little jx-secret CLI too for working with ExternalSecret resources and being able to edit them, import/export them, view which secrets are valid/populated + auto-generate them using a JSON-schema like schema (annotated on the ExternalSecret resources) or wait for the mandatory secrets to be populated etc. See the  CLI reference docs here
I'm hoping to do a blog soon on how we're using external secrets; they are awesome!
Questions
What should we call this new noop backendType?  I wondered about something like kubernetesSecret or something but maybe we need a name to indicate some out of band / custom process is used to populate them. So maybe custom for the backendType?

So we'd like KES to just ignore ExternalSecret resources with backendType noop (or whatever its called) so that the Secret can be populated out of band. In the case of Jenkins X we have an out of band way to make the Secrets.
i.e. we're using the ExternalSecret resource to describe the metadata of how a Secret should look (type, annotations, labels, data entries etc) and want to allow other processes to actually populate the Secret.
e.g. we have a little CLI tool jx secret populate which can generate random passwords or other generators, use templates or default values defined in a schema (populated on the ExternalSecret resources via annotations).
Or folks can explicitly edit a secret in (local k8s Secret / vault / GSM) via jx secret edit


feat: add cmd to check if all resources is implemented

Description of your changes
Add new golang cmd to check if all resources is correctly implemented
How to use
go run cmd/resources/main.go
Checking resources
=====================================

* Found 196 resources in terraform provider
* Found 171 resources implemented in crossplace provider
* Found 18 resources ignored in crossplace provider

Total 189/196 resources implemented

> 4 resources are not implemented (Add resources to ExternalName):
    + flexibleengine_lb_certificate_v2
    + flexibleengine_vpc_eip_v1
    + flexibleengine_vpc_route_v2
    + flexibleengine_compute_floatingip_v2

> 8 resources are deprecated (Add resources in skipList):
    + flexibleengine_elb_listener
    + flexibleengine_rds_instance_v1
    + flexibleengine_drs_replication_v2
    + flexibleengine_networking_router_route_v2
    + flexibleengine_elb_health
    + flexibleengine_drs_replicationconsistencygroup_v2
    + flexibleengine_elb_backend
    + flexibleengine_elb_loadbalancer

> 5 resources are implemented and ignored:
    ? flexibleengine_cce_pvc
    ? flexibleengine_fgs_dependency
    ? flexibleengine_mrs_cluster_v1
    ? flexibleengine_mrs_job_v1
    ? flexibleengine_mrs_hybrid_cluster_v1

It's not really a feature for the provider but a tool around this. Maybe you can change your commit name?


Ability to resize the taskbar, restore "use small icons" functionality.

Description of the new feature / enhancement
Replicate the Windows 10 functionality of right-click on the taskbar and "use small icons"
Scenario when this would be used?
Every minute of every day spent staring at the screen, the taskbar in Windows 11 takes up far too much valuable screen space.
Supporting information
No response

partially  /dup #35 and #6141


Update version

Description
Please include a summary of the change and which issue is fixed. Also, please include the motivation and context for the change. List any dependencies that are required for this change.
Check the relevant boxes:

[ ] Bug fix (nonbreaking change that fixes an issue)
[ ] New feature (nonbreaking change that adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Examples or tests (addition or updates of examples or tests)
[ ] Documentation update
[ ] CI related update (pipeline, etc.)

Checklist

[ ] If relevant, a test for the change has been added or updated as part of this PR.
[ ] If relevant, documentation for the change has been added or updated as part of this PR.

Merge

Merge using "Squash and merge".
Make sure to use a relevant conventional commit message that is based on the PR contents. The commit message determines whether a new version of the modules needs to be released, and if so, which semver number to use).

:tada: This PR is included in version 1.1.3 :tada:
The release is available on:

GitHub release
v1.1.3

Your semantic-release bot :package::rocket:

FYI this PR should have been done by renovate, however this repo was not yet added to the list of repos in the renovate pipeline for the terraform-ibm-modules org. I have just added it so no more manual PRs will need to be created to bump versions.


JSON message

As we agreed on our call with Kim Clark, I created this pull request with some code changes. Instead of a string message, it now has a JSON structure, which, in addition to the location, also contains a color and "key". The color information is of course used to display the Google maps marker. The "key" is bound to the marker and sent back to the server and stored in another Kafka topic if somebody clicks the marker. The "red" color marker is displayed over other colors.
If message is created using "surveyInputService" the color is blue and key is "--".

Thank you very much! I will review and integrate as soon as I can.


Network: gw restart fix

Description
This PR fixes a bug about gateway pod restart.
The problem
When a gateway restarts, it changes its IP. This means that all the geneve tunnels inside of the fabric must reconfigure the remote IP. The first solution was deleting and recreating the interface. This is a problem because linux deletes all the routing configurations related to that interface.
The solution
The solution is the netlink.LinkModify function. It implements the change of the netlink interfaces attributes (which is not supported by iproute2)

/merge


[HUDI-6145] Fix the flink table create schema to be compatible with S…

…park
Change Logs
Fix the table create schema namespace and record name.
Impact
none
Risk level (write none, low medium or high below)
none
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change

The config description must be updated if new configs are added or the default value of the configs are changed
Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the instruction to make
changes to the website.

Contributor's checklist

[ ] Read through contributor's guide
[ ] Change Logs and Impact were stated clearly
[ ] Adequate tests were added if applicable
[ ] CI passed

nice work

The failed test case: https://dev.azure.com/apache-hudi-ci-org/apache-hudi-ci/_build/results?buildId=16711&view=logs&j=3b6e910d-b98f-5de6-b9cb-1e5ff571f5de&t=30b5aae4-0ea0-5566-42d0-febf71a7061a&l=713634
is flaky and should not be caused by this patch, has validated it multiple times and can not reproduce.

The spark test should be a flaky one: https://dev.azure.com/apache-hudi-ci-org/apache-hudi-ci/_build/results?buildId=16724&view=logs&j=dcedfe73-9485-5cc5-817a-73b61fc5dcb0&t=746585d8-b50a-55c3-26c5-517d93af9934&l=37991

https://github.com/apache/hudi/pull/8587
what's the version of hudi?

0.13.1 and 0.14.x+

it did not work
---Original---
From: "Danny @.>
Date: Sun, Jun 16, 2024 08:14 AM
To: @.>;
Cc<EMAIL_ADDRESS>Subject: Re: [apache/hudi] [HUDI-6145] Fix the flink table create schema to be compatible with S… (PR #8587)
0.13.1 and 0.14.x+
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID: @.***>

i used flink1.16-hudi0.14.1 to test my program,but it did not work
---Original---
From: "Danny @.>
Date: Sun, Jun 16, 2024 08:14 AM
To: @.>;
Cc<EMAIL_ADDRESS>Subject: Re: [apache/hudi] [HUDI-6145] Fix the flink table create schema to be compatible with S… (PR #8587)
0.13.1 and 0.14.x+
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID: @.***>


feat: extend plugin api with captureScreen

Overview
This feature enables plugin get the image of the map.
Without this API the plugin can manually get the canvas and use canvas.toDataURL but the result will be a full black image due to the canvas webgl settings.
The solutions are:
A: Config contextOptions with {{ webgl: { preserveDrawingBuffer: true } }} but this will technically harm the performance so i did not apply this.
B: Call canvas.toDataURL immediately after a viewer.render. This is what i implemented for the API.
NOTICE: the output image comes from the canvas so anything implemented out of canvas (eg. infobox) can not be included. If you want to take a screenshot of all HTML elements you may try implement with some third-party libraries in plugin code.
What I've done
Extend the plugin API with
reearth.scene.captureScreen: (type?: string, encoderOptions?: number) => string | undefined

Refer canvas.toDataURL for parameters type encoderOptions
Thers's also a little refactor to unit test file included in this PR (Basically renaming function).
What I haven't done
How I tested

Add unit test.
Test with console.
Test with plugin. Here's an example which can be tested with plugin editor.

reearth.ui.show(`
  <div id="wrapper">
    <button id="button">Capture</button>
  </div>
  <script>
    document.getElementById("button").addEventListener("click", (e) => {
      parent.postMessage({ type: "captureScreen" }, "*");
    });
    addEventListener("message", e => {
      if (e.source !== parent) return;
      if (e.data.type && e.data.type === 'getCaptureScreen') {
        const fileName = "capture.png";
        const link = document.createElement("a");
        link.download = fileName;
        link.href = e.data.payload;
        link.click();
        link.remove();
      }
    })
  </script>
`);

reearth.on("message", msg => {
  if (msg.type === "captureScreen") {
    reearth.ui.postMessage({
      type: "getCaptureScreen",
      payload: reearth.scene.captureScreen(),
    });
  }
});

Screenshot
Which point I want you to review particularly
Memo

I have quickly tested. Seems working fine.


Browser doesn't prompt for location access if the "How to Allow Location" guide popup is closed using "X" button

The browser will only ask for location access if the "How to Allow Location"  popup is closed by clicking the OK button. On clicking the "X" button, there is no location prompt.

@nirmalvp  - which is the browser and OS that you used to test this ?

@nirmalvp it's working fine..

I can replicate this issue on Firefox 61.

@bobinson Chrome on an Ubuntu

@nirmalvp @clasick @jishnunand - What about mobile browsers ? I think most people will be using mobiles.

@bobinson Issue replicated in Firefox for Android.

Yes this can be fix by changing
$('#modal_ok_button').click(function(event) {
      navigator.geolocation.getCurrentPosition(success, error, options);
});

to
$('#instructionModal').on('hidden.bs.modal', function () {
    navigator.geolocation.getCurrentPosition(success, error, options);
})

@bobinson it's working fine in mobile version i have tested just now. But, in safari (Iphone users) not popup the location access.

@jishnunand https://developer.mozilla.org/en-US/docs/Web/API/Geolocation/getCurrentPosition#Browser_compatibility

@abdullatheef Please give pull request after fixing this issue.

@clasick created PR for this fix

'getCurrenPosition' call can be taken out of the click event. so that it will be called in all cases.
//--------remove this line->-- $('#modal_ok_button').click(function(event) {
navigator.geolocation.getCurrentPosition(success, error, options);
//----------remove this line->--});

@nirmalvp is this not expected behaviour? If close button is clicked, then it probably means they are registering for someone else. we need to provide an interface to those people to enter GPS coordinates.


Milestone 3 Feedback

Milestone 3 Feedback Group 10
Anaylysis abstracted to four or more scripts, which take command line arguments and save analysis artifacts (figures and data for tables)

[x] scripts except 01_data_loading.R do not use command line argument and those naming paths for files to be written to csv / or saveing to figs could be abstracted to command line argument -4

Report written in literate code document code, which primarily functions to source analysis artifacts and format document

[x] Extra code for confusion matrix. Again you had enough time to ask instructors team, deadline was again pushed to day after of original due date. You could ve plot it and ggsave it, then just load inside the report. -2

Project file and directory structure organization

[x] analysis.Rmd could be in the results directory as well and not in the top-level -1

Side Note:
Consider using a reference.bib and put it together within the same directory as your analysis.Rmd
Analysis can be run reproducibly using documentation provided in README
- [ ] No such target for make test exists -2

[x] Did not use auto referencing and makes it hard to follow which figure/table referring to table 2.2.1 and 2.2.2 -2
[x] Check your numbers, details matters, you could have use inline R code to show that -1, see below:

Address Feedback from Milestone 1 and 2
Up to 50 % of Milestone 1 + Milestone 2 points, if feedback and comments are adequately addressed
Milestone 2 Feedback
None addressed by April 05
Check below:

Milestone 1 Feedback

README.md 50% of 1 = 0.5
Analysis 50% of 6 = 3

Total = $0.5 + 3 = 3.5$ points

Removed the task for make test, it is my mistake here. Im sorry about that, and your marks will be fixed as well on Canvas

Above mentioned issues will be addressed with #171 #174 #175 #178 #179.
We will also update this ticket accordingly.

All tasks done!


Errors in topips()

I use pip install dshield then ran:
>>> import dshield
>>> print(dshield.topips())

This is the error in 2.7:
>>> import dshield
>>> print(dshield.topips())
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/my/path/here/lib/python2.7/site-packages/dshield.py", line 157, in topips
    return _get(uri, return_format)
  File "/my/path/here/lib/python2.7/site-packages/dshield.py", line 35, in _get
    return _strip_and_reformat(requests.get(''.join([__BASE_URL, function, JSON])).json())
  File "/my/path/here/lib/python2.7/site-packages/dshield.py", line 21, in _strip_and_reformat
    data_copy = data.copy()
AttributeError: 'list' object has no attribute 'copy'

I fixed this by adding be below snippt at line 21:
    if type(data) == dict:
        data_copy = data.copy()
    elif type(data) == list:
        data_copy = list(data)

to maintain the shallow copy. I also added TypeError to the execptions on line 25 of dshield.py.
This is the error in 3.5:
>>> import dshield
>>> print(dshield.topips())
Traceback (most recent call last):
  File "<input>", line 1, in <module>
  File "/my/path/here/lib/python3.5/site-packages/dshield.py", line 157, in topips
    return _get(uri, return_format)
  File "/my/path/here/lib/python3.5/site-packages/dshield.py", line 35, in _get
    return _strip_and_reformat(requests.get(''.join([__BASE_URL, function, JSON])).json())
  File "/my/path/here/lib/python3.5/site-packages/dshield.py", line 23, in _strip_and_reformat
    data_copy.__delitem__('METAKEYINFO')
TypeError: list indices must be integers or slices, not str

I remedied this by adding AttributeError to the execptions on line 25 of dshield.py.
Am I using this incorrectly or is this a current bug? If it's a bug I'm happy to make a PR.

Thanks for reporting this. Looks like the API changed from returning ordered dicts to lists. You can see the old expected format in the TestInternals cases in test.py. The "correct" fix will be a little more involved than your patches, as the exceptions you mentioned are just symptoms of the upstream change. You're welcome to do a PR, or I'll probably fix this later today.

If you've got spare time to make the fix today, I'll leave it to you as you know the code base better than I do.
Thank you for building and maintaining this.

Should be fixed now, let me know if you have any more problems.

Fixed in 76996a72f3c27c5208496ff3a6c472d2cb13e5e7


Investigate adding custom policies on crossplane compositions to handle logic

What: Make it easy for endusers to avoid problems when dealing with resources that require multiple steps or some logic in order to be deleted.
Why: Some resources may needed additional logic to delete or update them which can be complicated to handle in simple compositions.
Example: "kubectl delete" on Cloudfront resources does not remove the resource from AWS because it requires disabling the resource first and then deleting it.

[ ] investigate
[ ] create relevant issues

Might also be needed to display info about how different resources behave on deletion request like in SNS topic subscription: https://docs.aws.amazon.com/sns/latest/dg/sns-delete-subscription-topic.html


Read .dat in Python

Hi!
As I know it is possible to read binary files with header in Python using offset parameter in numpy method. As I understood from depth writer the size of the header is 8+4+4+4 bytes but unfortunately I couldn't read frames from the file. Could you please explain to me how binary file is constructed, what kind of hierarchy does it have? Maybe it will help me to read it in Python.
Thanks in advance!

Hey, @BobrG  did you figure it out? I'm trying to read it using c#


testing travis

whoops I meant to PR my own thing

:)

hey @Silvertorch5 you're not dead! I sent you a PM on Reddit, me and a couple other guys made a fork here and did some work while I was waiting on a reply: https://github.com/vgstation-coders/space-station-14

Nevermind I should've checked my inbox before making that comment.


Feature porting from vscode-chatgpt

Since the tragic news of vscode-chatgpt's discontinuation, there are a few things that I would love to see brought over to code-gpt.
These are all personal preferences, however nice to haves in my eyes.

A separate tab for the chat so it doesn't take over the explorer. Typically I kept GPT on the right side of my monitor within VSC while leaving my explorer/etc untouched.

The ability to show real-time response instead of just "thinking" for the chat window.

Buttons above codeblocks which allow for import/copy, similar to what vscode-chatgpt had.

Better response interactions. At the moment code-gpt opens a new file and pastes the response from the api, however because of this, things like linters get mad and it can also make the response very difficult to read. Not to mention having to close the newly created tab over and over again. Simply responding in the chat window would be nice instead of creating a new file.

Disable sending requests when the input field is empty.

Ability to clear conversations via a button.

Allow for control over text injection/appending.

Respect VSC themes (backgrounds, etc).

A more minimal response layout. Why is there a new line before every response and such a wide bottom margin after while the chat input doesn't have this.

@Zendrex
Thank you very much for the proposals, I will pass them to discussion to add the improvements.
Could you clarify what happened with vscode-chagpt ?

@Zendrex Thank you very much for the proposals, I will pass them to discussion to add the improvements.
Could you clarify what happened with vscode-chagpt ?

Feel free to take a look here. They discontinued it yesterday.
https://marketplace.visualstudio.com/items?itemName=gencay.vscode-chatgpt

How unfortunate what happened.
I received some feedback from people that their OpenAI account was being locked out because they were using the Browser Autologin service.
The project was great.

Additionally, here is the repo now that it's open source.
https://github.com/gencay/vscode-chatgpt

Both being streamed in the chat window plus having the chat window detached from the sidebar should go hand in hand. Like mentioned in another issue, closing and opening the window clears the chat, having a separate window entirely would solve this issue at least in the meantime till a more robust solution can be produced.

Additionally, is there an ETA on when we can see the extension open-sourced? I recall reading somewhere that it was on the roadmap a while back, but have yet to see it anywhere.

@Zendrex
Download the new version 2.0.4, it already comes with the improvements of points: 2, 3 (only the copy button) and 5.
Working on the others one.

Just upvoting this issue :) I agree with all the improvements proposition, especially number 4. Thanks @davila7 for the work!

@TanguySoto @Zendrex
Issue 4 will be added next week! And we are preparing an amazing update 😱


Regenerate cached file if timestamp is smaller than original file.

Can you update the isImageCached() function such that it takes into account if the source file is updated?
So look at the filemtime of the original file. If it is larger than the filemtime of the cached file, you should regenerate it!

I have fixed this, can I push to a developer branch?

/**
     * Checks if the requested resize/compressed image is already cached
     * @return bool
     */
    protected function isImageCached()
    {
        // if there is no cached image return false
        if(!is_file($cached_img = $this->getCachedImagePath())){
            return false;
        }
        else {
            // if cached image is newer than source file, the image is already cached
            if(filemtime($this->filePath) - filemtime($this->getCachedImagePath()) < 0){
                return true;
            }
            else {
                // delete older cached file
                unlink($cached_img);

                // generate new cache file
                return false;
            }
        }
    }


Serializer

For needs in https://github.com/lighttransport/gltf-insight, I'm writing an obj serializer. I figure it may be valuable to use tinyobj's data structure as an intermediate, since you have everything here to represent a obj file in memory.
Doing so, it make sense to write the code that write the files inside the library itself.
This is a draft, it's not ready to be merged yet, but this will permit you to easily follow the progress of my fork, in case you are interested into it.

@syoyo I have never used wercker as a CI service. Looks like the build script can't find clang++. I will try to see if I can help with that too, it seems that the master branch is not passing CI either.


Poolability test in PoolOLS

Kevin, I was wondering if linearmodels (or really anything else) implements the standard Chow test for poolability as in http://support.sas.com/documentation/cdl/en/etsug/66840/HTML/default/viewer.htm#etsug_panel_details41.htm.
I see that FixedEffects model has an F-test for effects but was looking for testing whether pooled ols is appropriate or not.
Thanks for writing this wonderful package. It plugs a big hole in statsmodel currently!

The F-test for poolability is a standard output of PanelOLS. If the effects pool -- and so the null isn't rejected -- then a PooledOLS is appropriate.

If you are looking for a test whether a model with 2 effects can be pooled to a model with 1, then you will need to directly implement this using teh sum of squared residuals.

With no effects turned on, I don't see the pooled Ftest. See below:

Whereas if I turn on entity effects, I see the F-test.

I was thinking of a simple pooled test for when all effects are turned off. For now, I will implement the test directly.

The test is effect specific, so I cannot be implemented without known the effects you want to test, e.g. entity effects, or possibly some other effect.  For this reason, it is only available after running PanelOLS with 1 or more effects.

Sorry. I realize that I am not being clear. Assume the pooled regression model is (without any fixed effects):
y_it = a + b x_it + u_it. i is the entity and t is the time
This can be compared to the unrestricted model where say regression coefficients are split up by entities:
y_it = a_i + b_i x_it + u_it.
Then, we can run the standard Chow test to see if the pooled regression is appropriate or not.
This is what I was hoping to see out-of-the-box. Currently, the implemented f-tests only test for different intercepts not different coefficients...

That is clearer.  What you are describing a a fixed slope, not a fixed effect.  I don't have any plans for fixed slopes.

Ok. Thanks for clarifying. I will close the ticket.


formatExtraData value from state not refreshing

I might have implemented it not on the most perfect way, but it worked for RBTv1.
Why? Because the formatExtraData value was explicitly declared inside render.
With RBTv2, it is just a field on a JSON, and changing the state isn't seen by render().
I make a bunch of ajax calls (up to 3). One is for master tabledata, and others to get descriptions about IDs used on the database table, so I can display names instead of ids.
Since everything is async, it happens to update this side data bucket AFTER rendering, and I keep seeing nothing at table cells (since side-json is empty at this moment).
The trick is (and where I am asking for quick help) that if I do paginate, next page has all my data, and if I go back to page 1, it is sitting there perfectly. But I don't know how to trigger that re-render w/o changing pages.
Long help would be if this is a real problem, and needs to be discussed. My point on this is because using table v1 it was working because it happened to be declared in render on TableHeaderColumn as prop.

I did a few experiments now, w/o success.
One thing I saw is changing the page rows limit from 25 to 50. The "newer" records showed up correctly, but the current older view remained with the "n/a" in the fields, meaning it was not rendered again.

Same data, if I keep 25 per page, and do "go to page 2" and "go to page 1" back.

Some code:
... inside render()
      {
        dataField: "conta_uuid",
        text: "Banco / Ag / Conta",
        sort: true,
        align: "left",
        formatter: contaFormatter,
        formatExtraData: this.state.contas
      },

Well, "solved" my problem this way:
    if ( this.state.contas.length > 1) {
      const columns = [...
      ... and so on up to render the table
    } else {
      return (
 HOLD ON
);
    }

I will evolve it to a better "no data handler", but if there is another way to implement something better than the way I did, I will appreciate. Else, this ticket can be closed.

@lovato https://react-bootstrap-table.github.io/react-bootstrap-table2/docs/column-props.html#columnformatter-function
I will not suggest developer to give a state data to formatExtraData, but if you did, I must update formatExtraData in a correct way: https://redux.js.org/recipes/structuring-reducers/immutable-update-patterns
If ok, would you please give me a simple and minimal code on codesandbox so that I can help you too see what's kind of issue you face?  No rush, thank you
btw, https://codesandbox.io/s/jlol04qrxv this is an example you can take and remember to change react-bootstrap-table-next version to the newest.  Many thank

@AllenFang I am also experiencing this issue.  Would you mind explaining what is incorrect about the example below?
https://codesandbox.io/s/zkn05nxpvl

@jrae26 I think I can reproduce your case and I hope @lovato had the same issue like your, I will fix it in next version, thanks

hello @jrae26  and @lovato this issue is fixed, please at least to upgrade related package listed below to newest version:
https://react-bootstrap-table.github.io/react-bootstrap-table2/blog/2019/03/26/version-bump.html

I will give it a try, but as I said, I am now waiting till all my ajax calls get 200, and that is the greenlight to render the component.

I still have this issue with v3.0.3 and v3.1.0 using this sample:
 https://codesandbox.io/s/zkn05nxpvl
Updates to state do not force a rendering of the table even if passed through formatExtraData. However, if you choose to sort a column, that does force a render and displays the updated state data.

@AllenFang I coded another feature, which led me back to the same issue, on a different Bootstrap Table property.
"react-bootstrap-table-next": "^3.1.1",
"react-bootstrap-table2-paginator": "^2.0.6",
"react-bootstrap-table2-toolkit": "^1.4.1",

      {
        dataField: "name",
        formatter: (cell, row) => titleFormatter(cell, row, this.props.globalState.debug_ui),

So, just by clicking here:

I understand that my table shoud refresh, but it doesn't.
However, if I navigate or even paginate, it gets refreshed nicely.
Is this supposed to be fixed, or I should workaround this in a different way? I mean, I can force-refresh if I find a way to subscribe to globalstate changes, but I don't think this will be correct.
Should we keep it here or open another issue?
Best,
Lovato

I still have this issue with v3.0.3 and v3.1.0 using this sample:
 https://codesandbox.io/s/zkn05nxpvl
Updates to state do not force a rendering of the table even if passed through formatExtraData. However, if you choose to sort a column, that does force a render and displays the updated state data.

I'm facing the exact same issue.

I still have this issue with v3.0.3 and v3.1.0 using this sample:
 https://codesandbox.io/s/zkn05nxpvl
Updates to state do not force a rendering of the table even if passed through formatExtraData. However, if you choose to sort a column, that does force a render and displays the updated state data.

I'm facing the exact same issue. Can't seem to figure out an effective and efficient workaround either.

Having the same problem. A change of states does not rerender the table.

I seem to still be having this issue in ^4.0.6 with my use case. I am passing in a Map, and every time the data updates, I create a new Map and pass that to formatExtraData. However, it does not rerender when I pass a new Map to formatExtraData.
I update the state of the Map like this:
function addNewData(data, state) {
  return {
    ...state,
    mapping: new Map([...state.mapping, ...data])
  }

Then I pass state.mapping to formatExtraData. But it does not update.

The library (underscore) that you are using to compare equality for formatExtraData does not seem to work right for Map objects:
import React from "react";

import _ from "underscore";
import {_ as __} from "lodash";

import "./styles.css";

export default function App() {
  const [map1, map2] = [
    new Map(),
    new Map(
      [["hello", "world"], ["works", false]]
    )]
  return (

native: {(map1 === map2).toString()}

underscore: {_.isEqual(map1, map2).toString()}

lodash: {__.isEqual(map1, map2).toString()}

  );
}

This shows:
native: false
underscore: true
lodash: false
(https://codesandbox.io/s/romantic-easley-dbqt7)

See also:
https://github.com/jashkenas/underscore/issues/2147
https://github.com/jashkenas/underscore/pull/2808
https://github.com/jashkenas/underscore/issues/2451


benten-flickr-bolt

https://github.com/intuit/benten/issues/27

@DivakarUngatla

@DivakarUngatla https://github.com/DivakarUngatla/divakarungatla.github.io/pull/1 done


The index property on the event is missing

The event object provides an "index" property as well which give the index of the item (if in an each block). It would be nice to have that property included in the "tap" event as well.
You can get from the keypath, but then string manipulation :(

This is causing tutorial no.10 (http://learn.ractivejs.org/partials/1/) to fail.


[Feature Request]: Enable option to apply preprocessor on input query string and use original query string in response synthesizer

Feature Description
Enable option to apply preprocessor on input query string and use original query string in response synthesizer.
Eg. Say it is needed to remove the stopwords from original query string to improve the query embedding generation and in the during response synthesis using LLM chat completion original query string needs to be passed.
Reason
It is needed to remove the stopwords from original query string to improve the query embedding generation
Value of Feature
No response

You can specify separate strings for response synthesizer vs. retrieval
from llama_index.core import QueryBundle

query_engine.query(QueryBundle(query_str="Hello", custom_embedding_strs=["Other string", ...]))


How can I use the same strategy with different configurations?

I am trying to use the same authentication strategy (Oauth2Strategy) for 2 different IdP with different set of configuration. However, both of them are referenced through the same strategy ID ("oauth2") so the configuration basically "collides".. Is there a way to specify / override the name so that I can do something like..
    passport.authenticate('oauth2-something')(req, res, next);

I've found a workaround for this.. although it's a bit ugly.
I could basically override the strategy name like this.
const orcid_strat = new OAuth2Strategy({
    authorizationURL: config.orcid.authorization_url,
    tokenURL: config.orcid.token_url,
    clientID: config.orcid.client_id,
    clientSecret: config.orcid.client_secret,
    callbackURL: config.orcid.callback_url,
    scope: "/authenticate",
}, function(accessToken, refreshToken, profile, _needed, cb) {
    logger.debug("orcid loading userinfo ..", accessToken, refreshToken, profile);
    db.User.findOne({where: {"orcid": profile.orcid}}).then(function(user) {
        cb(null, user, profile);
    });
});
orcid_strat.name = "oauth2-orcid";
passport.use(orcid_strat);

Then, I can use the same name to use it
//initiate oauth2 login!
OAuth2Strategy.prototype.authorizationParams = function(options) {
    return { selected_idp: options.idp }
}
router.get('/signin', function(req, res, next) {
    passport.authenticate(orcid_strat.name, {
        //this will be used by my authorizationParams() and selected_idp will be injected to authorized url
        idp: req.query.idp
    })(req, res, next);
});


updated gopro (<IP_ADDRESS>78)

There was a PR template when you submitted. It must be filled.
Next time, please do so.


dockerise stellargraph and publish images via CI

PR:

Dockerises stellargraph (image name stellargraph/stellargraph
Dockerises the stellargraph demos in a docker image with jupyter notebook (image name stellargraph/stellargraph-demos), with the included datasets—built from the base image stellargraph/stellargraph
Both images are public
Updates the buildkite pipeline so that the docker images are built and pushed via the CI

PRs build and push docker images with the tag testing
develop branch builds and pushes the docker images with the tag latest
As discussed with Andrew, for now we don't build and push on master since it gets merged back into develop

Updates the README.md with information on running the docker image + adds the "docker pulls" badge for stellargraph

The demos can be tested by running
docker run -it -p 8888:8888 stellargraph/stellargraph-demos
and opening http://localhost:8888

Coverage remained the same at 84.282% when pulling 9a7d28c69adc1c78ba53a7ba44529abb21c2772c on feature/dockerise-stellargraph into 598323571a66a7de01130587fabc332d3e350490 on develop.

I've added a .dockerignore but I'm taking a whitelist approach via negation (the README.md seems to be required by seup.py for building stellargraph).
I also thought about the base image and decided to switch to alpine—reason being is that if someone builds locally and they won't have python:3.6-slim (having stellargraph/stellargraph locally won't count AFAIK). It's also easier to pull a 3MB image + alpine it has more of the packages required built in.
What do you think @huonw?

I've added a .dockerignore but I'm taking a whitelist approach via negation (the README.md file seems to be required by seup.py for building stellargraph).

Seems fragile, but I guess the installed may start failing if some required files are missed (e.g. if someone has a change that adds new required ones, they'll be forced to update them here). The most concerning thing would be potential files that are required for running but aren't required for installation, meaning the docker image is built successfully, but can't actually run anything.

I also thought about the base image and decided to switch to alpine—reason being is that if someone builds locally and they won't have python:3.6-slim (having stellargraph/stellargraph locally won't count AFAIK). It's also easier to pull a 3MB image + alpine it has more of the packages required built in.

Docker's layer model means stellargraph/stellargraph should count? It would have to check docker hub to find the tag, but it should find out that it's already downloaded all the layers.

Yep it would use the layer hash if it exists—will need to test it out locally to be certain it works. Agreed on the potential issues with the whitelist approach (I already ran into it with the latest build). I'll roll it back to using blacklist ignores, so at the very least we can speed up the build context generation and reduce the size. Using .gitignore also isn't enough since it doesn't capture everything that one would want to ignore for the image.
I'm thinking doing blanket COPY . /dest is considered harmful or at least problematic, since you end up managing a .dockerignore file for everything under the root directory. We could alternatively just have COPY of the folders + files that are actually needed and not worry about  a monolithic .dockerignore (keep it only for .gitignore type files)?

Using .gitignore also isn't enough since it doesn't capture everything that one would want to ignore for the image

It isn't enough to be perfect, but it covers a lot, e.g. the .tox folder.

We could alternatively just have COPY of the folders + files that are actually needed and not worry about a monolithic .dockerignore (keep it only for .gitignore type files)?

I think that's quite similar to the whitelist approach (it's a whitelist of files to explicitly copy), and so has the same downsides?

I added a .dockerignore (generated from .gitignore). To avoid the whitelist/blacklist approach, the latest commit does a COPY . as before—however using multi-stage builds, the final image copies the installed packages from /home/stellar/.local so it's clean

It seems like this was superseded by #386? Can it be closed?

Yep, closing


Issues following "Try out the CLI" instructions

Windows 11, Powershell Core 7.2.5, node v16.15.1
Note: node installed using nvm for windows version 1.1.9, if that matters
Following instructions in https://code.visualstudio.com/blogs/2022/05/18/dev-container-cli quite literally, I ran into some issues following the instructions referring to https://github.com/microsoft/vscode-remote-try-rust.  The instructions say:
git clone https://github.com/microsoft/vscode-remote-try-rust
devcontainer up --workspace-folder <path-to-vscode-remote-try-rust>

Expected: these commands should execute without error.
Actual:  The first problem was the <path-to-vscode-remote-try-rust>, which isn't proper for any shell.   I replaced it with a relative path, so now I have:
git clone https://github.com/microsoft/vscode-remote-try-rust
devcontainer up --workspace-folder ./vscode-remote-try-rust

So now I get an error I really don't understand:
Error: Command failed: docker ps -q -a --filter label=devcontainer.local_folder=C:\Users\burt_\vscode-remote-try-rust
    at createSetupError (C:\Users\burt_\AppData\Roaming\nvm\v16.15.1\node_modules\@devcontainers\cli\dist\spec-node\singleContainer.js:59:84)
    at openDockerfileDevContainer (C:\Users\burt_\AppData\Roaming\nvm\v16.15.1\node_modules\@devcontainers\cli\dist\spec-node\singleContainer.js:54:15)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at async resolveWithLocalFolder (C:\Users\burt_\AppData\Roaming\nvm\v16.15.1\node_modules\@devcontainers\cli\dist\spec-node\configContainer.js:74:18)
    at async launch (C:\Users\burt_\AppData\Roaming\nvm\v16.15.1\node_modules\@devcontainers\cli\dist\spec-node\devContainers.js:42:20)
    at async doProvision (C:\Users\burt_\AppData\Roaming\nvm\v16.15.1\node_modules\@devcontainers\cli\dist\spec-node\devContainersSpecCLI.js:185:24)
    at async provision (C:\Users\burt_\AppData\Roaming\nvm\v16.15.1\node_modules\@devcontainers\cli\dist\spec-node\devContainersSpecCLI.js:170:20)
{"outcome":"error","message":"Command failed: docker ps -q -a --filter label=devcontainer.local_folder=C:\\Users\\burt_\\vscode-remote-try-rust","description":"An error occurred setting up the container."}

Could you rerun with --log-level debug.


Cannot spend Sapling balance while there is Transparent balance

After performing several tests by sending part of my available balance to other wallets, I was left with a balance of 0.000189 ZEC.
I send a transaction to the transparent address of my Zashi wallet for a total of 0.10005 ZEC, I try to spend the available balance that according to Zashi is 0.000189 ZEC and in no attempt it was possible to spend.
In order to manage to spend, I had to shield the balance that was in transparent, in this way the available balance was updated and I managed to spend the balance.

Why is it not possible to spend the available balance in Sapling while there is a balance in transparent?
Why isn't there a button to shield balance?

Video where I try to spend the available balance in sapling while there is balance in Transparent:
https://github.com/Electric-Coin-Company/zashi/assets/37910384/7bff5800-bfd3-4313-9b57-2ad08f2c0c43
Video where I manage to spend available balance in sapling after transparent balance shielding is confirmed (shielding was performed from another app):
https://github.com/Electric-Coin-Company/zashi/assets/37910384/bf24ac29-b16e-4510-8a70-c870254c2900
The same publication can be used in Discord:
https://discord.com/channels/1133829162591846461/1133829407295942666/1184564080346939492

This problem was likely related to the guardrails that prevent the creation of "dust" notes. There are a few possibilities for how to address this problem, so this example should be considered when evaluating #39. #40 is also related.

After further consideration, this is more likely a UX problem. If the wallet contains 0.000189 ZEC, after accounting for fees required to spend, the maximum value that can actually be spent is either 0.000089 ZEC (if sending within the same pool, with only one or two source notes) or no spend may be possible at all, due to the fees required for pool-crossing.
We've had ideas for some time about accounting for fees in the balance display, but have hesitated because there's a tradeoff: if the balance accurately reflects the actual spendable value, given fees, then the balance will likely disagree with what is displayed by other wallets that do not take this approach.
One possibility is to display a separate "fee escrow" value, such that the top-line balance plus the fee escrow is equal to the total value of coins in the wallet. @Edicksonjga if you have feedback on this topic, please post it here.

Hi @nuttycom, I am trying to understand what you are saying.
I have to test with the new version, I consider that it is not a UX problem, but a bug since as you can see in the video I try to spend much less (0.00001 ZEC) than the maximum balance you comment (0.000085 ZEC), also, by the time I reported the error the ZIP 317 was not yet implemented so the rate was the same.
Maybe you are talking from a more general way and not about the specific error taking into account the progress that Zashi has already had and how the behavior may be at this moment.
About the fee, I consider that showing the available balance to spend without deducting the fee is fine, since after completing the data there is a Confirmation screen where the fee is shown.
Deducting the fee before making any transaction and showing it that way in the available balance can be confusing, yes, no other Zcash wallet does it that way, they all apply the actual total balance and a confirmation screen where the fee is deducted.
What maybe needs to be improved is the error message when trying to spend the total balance without considering the fee, make it more understandable for the common user and not so complicated with those figures in zatoshis.

(This was translated with DeepL, sorry if the translation is not so good 😁)

Hi @nuttycom, I am trying to understand what you are saying.
I have to test with the new version, I consider that it is not a UX problem, but a bug since as you can see in the video I try to spend much less (0.00001 ZEC) than the maximum balance you comment (0.000085 ZEC), also, by the time I reported the error the ZIP 317 was not yet implemented so the rate was the same.

Ah, I had not noticed that this was reported using a wallet that was prior to ZIP 317 support. In that case, then I agree with you that this was a bug at the time, likely the one that was fixed in https://github.com/zcash/librustzcash/pull/1312

About the fee, I consider that showing the available balance to spend without deducting the fee is fine, since after completing the data there is a Confirmation screen where the fee is shown.
Deducting the fee before making any transaction and showing it that way in the available balance can be confusing, yes, no other Zcash wallet does it that way, they all apply the actual total balance and a confirmation screen where the fee is deducted.

The one problem that arises here is, when the user wants to send close to their full balance out of the wallet, they cannot correctly predict the fee that is required by ZIP 317. In particular, this is a problem because the fee may vary depending upon whether or not the transaction results in funds crossing pool boundaries.
If, on the send screen we report the minimum amount that the user can successfully send, then I think that would be a better experience for the user. We would want the "spendable value" and the amount of fees reserved for spending to be clearly identified in the UI.

What maybe needs to be improved is the error message when trying to spend the total balance without considering the fee, make it more understandable for the common user and not so complicated with those figures in zatoshis.

I think that this is separately also a good idea.

Based on my understanding and the last communication iwth @str4d. This is going to be a spike task for @nuttycom, is that right?


Build libponyc and libponyrt benchmarks on Windows

This PR makes the Windows build system build the libponyc.benchmarks and libponyrt.benchmarks executables.
The ignored files are Visual Studio profiler outputs.
Microsoft C++ doesn't have variable-length arrays, so I replaced a few instances of these with calls to alloca().

Cool, thanks!
The one OSX failure on CI is unrelated, so I'm merging.


youtube-dl dependency removal

Removing the dependency of youtube-dl will simplify greatly the overhead caused by using it.
An alternative would be compile to C the module of youtube-dl responsible to generate the URLs streams. Here is some info:

http://stackoverflow.com/questions/138521/is-it-feasible-to-compile-python-to-machine-code
http://stackoverflow.com/questions/4650243/convert-python-program-to-c-c-code

youtube-dl is a lot more useful than just parse youtube urls more importantly though YouTube is constantly breaking the functionality of youtube-dl due to API breakage to mitigate the usage of it. They make constant updates so really the best option is to simply use youtube-dl unless it was rewritten to obey all of the API rules.


Carla训练下的Map元素lane divider, road boundary, and pedestrian crossing提取

打扰了，文章中提到了在vectorized map中使用了 lane divider, road boundary, and pedestrian crossing 三种元素。这几个元素在carla里训练时 是如何提取的？ 同时是以何种方式加入到训练数据集中的呢？

same with the issue https://github.com/hustvl/VAD/issues/16

你好，我想问下这个问题你解决了吗

@lsrrrrrrrr @raozhongyu  Hi, we are the authors of Bench2Drive and we would like to introduce that we have implemented VAD (non-official) in CARLA with code, checkpoints, and closed-loop results open sourced. Feel free to try it. https://github.com/Thinklab-SJTU/Bench2DriveZoo/tree/uniad/vad

Thinks a lot.
发自我的iPhone
------------------ 原始邮件 ------------------
发件人: Xiaosong Jia @.>
发送时间: 2024年6月11日 18:47
收件人: hustvl/VAD @.>
抄送: raozhongyu @.>, Mention @.>
主题: Re: [hustvl/VAD] Carla训练下的Map元素lane divider, road boundary, and pedestrian crossing提取 (Issue #27)
@lsrrrrrrrr @raozhongyu  Hi, we are the authors of Bench2Drive and we would like to introduce that we have implemented VAD (non-official) in CARLA with code, checkpoints, and closed-loop results open sourced. Feel free to try it. https://github.com/Thinklab-SJTU/Bench2DriveZoo/tree/uniad/vad
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: @.***>


make cluster-down failed

rm: cannot remove '/root/.kube/config-kepler': No such file or directory
make: *** [Makefile:144: cluster-down] Error 1
[root@jitest42 kepler-operator]#

seems this is in our repo.. so close this


SPA core components

Expected Behaviour
The Latest React core components / Angular core components are hooked into the SPA react / angular modules, to provide a good example to developers on how to use this.
Actual Behaviour
These are not included.

was added in https://github.com/adobe/aem-project-archetype/commit/a2f477539b2f16d49bbe6eec1663724d3f05bc47


Use http over unix socket domain instead of a custom protocol

It would be better to use a well known protocol for the tray communication. HTTP is widely used now and most of the time a library is available.
Here we could use https://github.com/swift-server/async-http-client.

Thanks, this is the interesting part https://github.com/swift-server/async-http-client#unix-domain-socket-paths

Fixed in #108


Refactor the factories!

Many cool changes... This commit essentially adds some Quality of life improvements, and helps tie together the factory system with the MainGameArea. And clarifies how the over arching gameplay is to be implemented.
Services:

RandomService: any class can add randomness and still be deterministic according to the master seed, while also maintaining seed integrity between revisions.
GameAreaService: for accessing the main game area from anywhere.
RenderService: now provides access to the camera.

LevelFactory: essentially inject the whole game logic into a game area.
PlayerFactory: further parameterises the creation of players.

Game Areas:

Game Areas have been refined, and their responsibilities clarified.
There is now a "TestGameArea" if you wanna do something like just spawn some crap to manually test, use that.
and MainGameArea for the actual game.

@dhruvanil55 merged BossRoomSpawner into BossRoom


Wrong base URL with nuxi build with NUXT_PUBLIC_SITE_URL env var set

Describe the bug
I have NUXT_PUBLIC_SITE_URL=http://localhost:3000
When I run nuxi dev the base URL in the sitemap is set correctly to http://localhost:3000.
However, when I run nuxi build && nuxi start the base URL is set to https://false
I have a reproduction but is not relevant since on stackblitz you can't set env vars, and you can't run nuxi build
Reproduction
https://stackblitz.com/edit/nuxt-sitemap?file=package.json
System / Nuxt Info
- Operating System: Linux
- Node Version:     v18.17.0
- Nuxt Version:     3.6.5
- Nitro Version:    2.5.2
- Package Manager<EMAIL_ADDRESS>- Builder:          vite
- User Config:      runtimeConfig, app, $production, css, components, modules, robots, sitemap, i18n, content, auth, pinia, imports, image, nitro, delayHydration
- Runtime Modules<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>- Build Modules:    -

export default defineNuxtConfig({
  site: {
    url: process.env,NUXT_PUBLIC_SITE_URL
  }
})

Fixes the issue, but this should be not needed, at least accordingly to the documentation.

Hey @learntheropes, thanks for the issue.
This should be fixed in 3.1.3, let me know if you have any issues.

I confirm that is resolved.
Thank you for the quick fix!


Use null instead of undefined

lua-style-arrays Pull Request
Describe what your pull request does
This replaces and fixes tests for the package
Replaces undefined with null like it should be
Why should it be accepted?
Because semantics and the difference between undefined and null
I have

[x] made sure there are no pull requests that add this functionality.
[x] read and followed the contribution guidelines.
[x] read and followed the Code of Conduct.

sure


Collections > League > Fetch - Subresource Scoreboard Only Returns Last in Array of Scoreboards

Leveraging the Collections > League > Fetch resource and adding the subresource of scoreboard does not return all matchups for NFL leagues, only the last matchup of the week.

https://yahoo-fantasy-node-docs.vercel.app/collection/leagues/fetch

Response object for scoreboard:
scoreboard: {
  matchups: [
    {
      week: "16",
      ...
    },
    {
      week: "16",
      ...
    },
    ...
  ],
}

However, by contrast the Resources > League > Scoreboard pulls back all weeks as expected.

https://yahoo-fantasy-node-docs.vercel.app/resource/league/scoreboard

Response Object is an array of Matchups for each week of the season:
scoreboards: [
  { matchups: Array(5), week: '1' },
  { matchups: Array(5), week: '2' },
  { matchups: Array(5), week: '3' },
  ...
]

I would expect these two responses to be identical.  I'm able to work around by not including the scoreboard sub-resource and making a subsequent call for each league to get Scoreboards the second way.
Unfortunately all my leagues are private so I can't provide any specific league key examples, but I imagine this applies for any NFL league.
Thanks for developing this library and your continued support!
@whatadewitt

There are a few different spots in their API where things just don't make sense like this and you have to do things with multiple calls that you'd think should only take one.
That said, can you try using a "matchups" sub-resource and see if it returns anything? I can give it a shot later today, but working the day job at the moment :D

"Invalid subresource matchups requested"
Dammit... looks like it isn't exposed...

@whatadewitt Sorry for reporting this then going dark there. holidays and family had illnesses run through.  Seems like your library intends for this to return all leagues scoreboards and not just the last one in the array.  Would be nice if it could do that more efficiently than calling scoreboards endpoint 1 by 1 for each league.  Hope you are well! Appreciate you looking at this one.

Unfortunately I am at the mercy of what Yahoo! allows. If you wanted to check here if what you're looking for is possible, I could try to implement it...
https://developer.yahoo.com/fantasysports/guide/


x/vgo: vgo build and vgo mod -sync produce different list of dependencies

What version of Go are you using (go version)?
go version go1.10.3 linux/amd64
golang/vgo@f574d316627652354b92fbdf885a2b2f7ea7dac9
Does this issue reproduce with the latest release?
yes
What operating system and processor architecture are you using (go env)?
cross-platform issue
What did you do?
In the following case, having the files outside of GOPATH:

main.go

package main

import "github.com/gorilla/mux"

func main() {
	m := mux.NewRouter()
	_ = m
}

go.mod

module awesomevgoProject

Then run vgo build. Cleanup the go.mod file to the one in the issue and now run vgo mod -sync.
What did you expect to see?

vgo build produces the following go.mod

module awesomevgoProject

require github.com/gorilla/mux v1.6.2

vgo mod -sync produces the following go.mod

module awesomevgoProject

require (
	github.com/gorilla/context v1.1.1
	github.com/gorilla/mux v1.6.2
)

What did you see instead?
I expect the file to be similar in both cases.
And given that vgo build produces a working code, I expect that vgo build is the minimal source of truth in this case.
Maybe this works as expected but in this case, more documentation would be useful as vgo build will be significantly faster than vgo mod -sync in case of many dependencies that need to be downloaded if the pattern can replicate in larger projects.

The difference here is in the build tags: mux/context_gorilla.go imports github.com/gorilla/context, but is guarded by a !go1.7 build tag. When you invoke vgo build, it is probably only updating the requirements that are affected by the current tags.
In contrast, vgo mod -sync intentionally ignores build tags: the go.mod file is also the input to vgo vendor, which is the support path for users on older versions of the go command.

Thank you for the update.
In this case, what is preferred to invoke? vgo build or vgo mod -sync?
Also, in the case of third-party tooling that wants to support users work on vgo enabled apps, what is preferred to run?
I understand the difference in these run modes but I think that in order to minimize the friction with developers, both commands should behave the same.
Imagine a case where a dependency will be present or not based on the user's operating system. In this case, it could potentially create unnecessary churn and additional confusion for reviewers as to why the go.mod file changes between users.

To be clear: I'm not saying that vgo build and vgo mod -sync should produce different results. I'm just explaining the likely reason that they do today.
(I tend to agree with you that they should be equivalent, but that invariant has a non-trivial cost. I'm curious to find out @rsc's thoughts on the matter.)

They should not be equivalent. go build should be lazy and do minimal work for that GOOS, GOARCH, and tag-set.
go mod x is for managing the mod requirements regardless of the current system setup. This is similar to how govendor works. This attribute is important.
One project I work on I develop on Linux and deploy to windows. I don't want my deploy step pulling down extra un-reviewed deps. So when I update dependencies they ignore current GOOS values. This is also why govendor had to reimplement package discovery.
Issue #25873 is about limiting the scope of the mod subcommand, but would not affect go build.

I chatted a bit about this with Russ this morning, and his interpretation agrees with @kardianos' comment: vgo build does the minimal work needed to satisfy the imports of the requested packages for that particular build invocation. So I think this is working as intended.
Personally, I would recommend vgo build as the default during development, plus a vgo mod -sync in any commit to be tagged for release.


Empty service name in Zipkin when using brave-opentracing

Description
Empty service name in Zipkin when using brave-opentracing. Please refer to the screenshot below.
How to replicate the issue
public static void main(String[] args) throws InterruptedException {
        OkHttpSender sender = OkHttpSender.create("http://<IP_ADDRESS>:9411/api/v1/spans");
        AsyncReporter reporter = AsyncReporter.builder(sender).build();
        Tracing braveTracing = Tracing.newBuilder()
            .localServiceName("my-service")
            .reporter(reporter)
            .build();

        Tracer tracer = BraveTracer.create(braveTracing);
        try ( Span span0 = tracer.buildSpan("span-0")
            .withTag("description", "top level initial span in the original process")
            .start() ) {
            Thread.sleep(500);
            System.out.println("Done. Next step is to visit http://localhost:9411 and check service name.");
        }

        Thread.sleep(2000);
    }

Dependencies used

brave-opentracing:0.20.0
opentracing-api:0.21.0
io.zipkin.brave:brave:4.2.0 (the newest checked as well)
io.zipkin.reporter:zipkin-sender-okhttp3:0.10.0

Zipkin server
For test purposes, Zipkin is executed as follows:
java -jar zipkin-server-1.26.0-exec.jar

Actual result

JSON
[
  {
    "traceId": "7c7f770e7a66b439",
    "id": "7c7f770e7a66b439",
    "name": "span-0",
    "timestamp":<PHONE_NUMBER>339364,
    "duration": 502318,
    "binaryAnnotations": [
      {
        "key": "description",
        "value": "top level initial span in the original process",
        "endpoint": {
          "serviceName": "my-service",
          "ipv4": "<IP_ADDRESS>"
        }
      }
    ]
  }
]

/trace JSON
{
  "timestamp":<PHONE_NUMBER>369,
  "info": {
    "method": "POST",
    "path": "/api/v1/spans",
    "headers": {
      "request": {
        "content-encoding": "gzip",
        "content-type": "application/x-thrift",
        "content-length": "178",
        "host": "<IP_ADDRESS>:9411",
        "connection": "Keep-Alive",
        "accept-encoding": "gzip",
        "user-agent": "okhttp/3.8.0"
      },
      "response": {
        "X-Application-Context": "zipkin-server:shared:9411",
        "status": "200"
      }
    },
    "timeTaken": "153"
  }
}

Expected result
I would expect service name "my-service" displayed on a bar.

I found out that if .withTag() is not used, the example above works.
Alternatively, calling .withTag("span.kind", "client") also makes the missing service label appear.
So, despite using of brave.Span#kind is optional, it somehow influences displayed service name.
Having said that, it may be an issue in brave.

Interesting, I'm hoping to have time to look at stuff again starting next week. I'm moving and therefore super busy in and out of work

this is sorted in a recent version of zipkin server (as was a javascript related issue). Upgrade your server and all should work. I verified by posting the span you sent.. excellent detail


update on keypressed functions : it just returns keys.pressed.space when i set it to a variable

Describe your problem here.
so in https://github.com/ShadowMario/FNF-PsychEngine/issues/1246 @ShadowMario said just to use getPropertyFromClass('flixel.FlxG', 'keys.pressed.space') to select a specific key it just returns keys.pressed.space instead of ytrue of false
Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows x64
Did you edit anything in this build? If so, mention or summarize your changes.
No response

I think you have to make space capital. Like this:
getPropertyFromClass('flixel.FlxG', 'keys.pressed.SPACE')

> I think you have to make space capital. Like this: getPropertyFromClass('flixel.FlxG', 'keys.pressed.SPACE')
thx!


OSS101-Level1-Challenges

name: Nitin Yadav
github_user_name: nitinya9av

URL of the forked repository

https://github.com/nitinya9av/oss101.git

A screenshot of the cloned project in my system.

Screenshot showing the list of all the current branches inside of my forked clone repository

Screenshot of this new branch nitinya9av-details-clone

Content from the stash area

A scenario of a merge conflict locally in my system.

Git Alias
alias.last log -p -1
alias.cm commit -m
alias.unstage restore --staged --


One Days Off update per user and update propogated to all teams of which user is a member.

One Days Off update per user and update propogated to all teams of which user is a member within a project.
Similar to need in Multiple teams in the same project - Calendar should rollup #167.  (This issue was noted as an enhancement in Sept. 21, 2017)

Hi, we are currently working on a different extension for the team calendar. We will prioritize bug fixes for the moment

It doesn't sound like the same enhancement.  #167 is suggesting a master calender.  I am suggesting make one change and all the user's team calenders can be updated with that change.

HI, I  have been working on other extensions and will prioritize this issue as soon as possible.

I received an email stating this issue will be prioritized as soon as possible, but this item is showing as still closed.  Will it be reopened?


Msal AADB2C90085 on redirect after custom policy flow

Core Library
MSAL.js (@azure/msal-browser)
Core Library Version
2.28.2
Wrapper Library
MSAL Angular (@azure/msal-angular)
Wrapper Library Version
2.4.2
Public or Confidential Client?
Public
Description
I am implementing B2c custom MFA and PasswordRest flow in our angular app. However, after the flow is completed the msal is appending http with the redirect url. For instance if the redirect url is www.abc.com, after redirect it's www.abc.com/https:. In the browser console I get the following errors
POST https://qhrdqab2cmedeo.b2clogin.com/qhrdqab2cmedeo.onmicrosoft.com/b2c_1a_signup_signin/oauth2/v2.0/token 400 (Bad Request)
ServerError: invalid_grant: undefined - [undefined]: AADB2C90085: The service has encountered an internal error. Please reauthenticate and try again.
<EMAIL_ADDRESS>: Error - Guard - error while logging in, unable to activate
MSAL Configuration
{
    auth: {
      clientId: config.clientId,
      authority: config.authorities.signUpSignIn,
      redirectUri: window.origin,
      postLogoutRedirectUri: window.origin,
      knownAuthorities: [config.authorityDomain]
    },
    cache: {
      cacheLocation: BrowserCacheLocation.LocalStorage,
      storeAuthStateInCookie: false
    },
    system: {
      loggerOptions: {
        // eslint-disable-next-line ban/ban, no-console
        loggerCallback: (level, message) => console.log(message),
        logLevel: config.logLevel,
        piiLoggingEnabled: false
      }
    }
  }

export function b2cGuardFactory(): MsalGuardConfiguration {
  return {
    interactionType: InteractionType.Redirect,
    loginFailedRoute: `${window.origin}/error/B2C_USER_LOGIN_FAILED/1`
  };
}

Relevant Code Snippets
init() {
  // setup msal to use router instead of setting window.location
    const customNavigationClient = new MsalCustomNavigationClient(this.authService, this.router, this.location);
    this.authService.instance.setNavigationClient(customNavigationClient);

    this.userFacade.userPermissions$
      .pipe(
        map(userPermission => !!this.b2cConfig && !!userPermission?.b2c_login)
      )
      .subscribe((flag: boolean) => this._enabledSubject$.next(flag));

    this.msalBroadcastService.inProgress$
      .pipe(
        filter((status: InteractionStatus) => status === InteractionStatus.None),
        takeUntil(this.ngUnsubscribe)
      )
      .subscribe(() => {
        this.checkAndSetActiveAccount();
      });

    // listen for msal events
    this.msalBroadcastService.msalSubject$.subscribe((event: EventMessage) => {
      if (event.error) {
        if (event.error.message?.indexOf('AADB2C90091') > -1) {
          this.window.location.replace('/settings');
        } else {
          console.error(event.error);
        }
      }
    });
  }

mfaSetUp() {
    // Redirect user to MFA policy
    this.authService.loginRedirect({
      extraQueryParameters: {
        p: 'B2C_1A_MFAEDIT'
      },
      scopes: OIDC_DEFAULT_SCOPES,
    });
  }

Identity Provider
Azure B2C Custom Policy
Source
Internal (Microsoft)

Hey @adnan-ashfaq , can you share trace level logs for this issue by setting the logLevel to Trace? Thanks!

@adnan-ashfaq Can you also please share your network trace on my email?

@adnan-ashfaq Can you also please share your network trace on my email?

Just Sent. Can you confirm you've received it?

I received the logs but not the network trace!

I received the logs but not the network trace!

Just sent them.

I tried sending har. But says file message to big. Rejected from your server.
From: Lalima Sharda @.>
Sent: Friday, August 25, 2023 5:28 PM
To: AzureAD/microsoft-authentication-library-for-js @.>
Cc: Adnan Ashfaq @.>; Mention @.>
Subject: Re: [AzureAD/microsoft-authentication-library-for-js] Msal AADB2C90085 on redirect after custom policy flow (Issue #6389)
I received the logs but not the network trace!

Reply to this email directly, view it on GitHubhttps://github.com/AzureAD/microsoft-authentication-library-for-js/issues/6389#issuecomment-1693954518, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AVW7F5Y5NBJL2PYZ7ESS253XXEKEVANCNFSM6AAAAAA35UPOFQ.
You are receiving this because you were mentioned.Message ID<EMAIL_ADDRESS>

Attached is the zipped har file.
From: Lalima Sharda @.>
Sent: Friday, August 25, 2023 5:28 PM
To: AzureAD/microsoft-authentication-library-for-js @.>
Cc: Adnan Ashfaq @.>; Mention @.>
Subject: Re: [AzureAD/microsoft-authentication-library-for-js] Msal AADB2C90085 on redirect after custom policy flow (Issue #6389)
I received the logs but not the network trace!

Reply to this email directly, view it on GitHubhttps://github.com/AzureAD/microsoft-authentication-library-for-js/issues/6389#issuecomment-1693954518, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AVW7F5Y5NBJL2PYZ7ESS253XXEKEVANCNFSM6AAAAAA35UPOFQ.
You are receiving this because you were mentioned.Message ID<EMAIL_ADDRESS>

Hey @adnan-ashfaq , the network trace you shared does not show the /authorize call. Can you please collect another trace and make sure it contains the /authorize and /token request & response? Also, can you please double check your code to see if you have a custom method for building a redirect URI somewhere and if it is generating the correct redirect URI? I do not see anything wrong with the redirect URI in your request to /token call.

I have just send the complete Network log form when user sign-in to completing the flow and redirecting to the url. And yes, I  have confirmed we do not have any custom method the redirect uri.

Hi @lalimasharda @sameerag , any update on the issue?

Hi, Any update on the issue?

@sameerag Waiting for update on the issue.

Closing as this is a stale issue. If the issue still persist, please raise a new issue and preferably on the latest MSAL JS version.


Web error stack traces inconsistent with app

We parse file locations from stack traces in the IntelliJ plugins to allow users to click to open relevant files when an error occurs. This is broken for web because the format of web stack traces differs from apps.
We could add separate parsing when users are running a web app, but as far as we know there isn't a particular reason why we would want a different format of messaging for web vs non-web, particularly for the file locations.
Example error (not web):

══╡ EXCEPTION CAUGHT BY GESTURE ╞═══════════════════════════════════════════════════════════════════
The following _Exception was thrown while handling a gesture:
Exception: test message

When the exception was thrown, this was the stack:
#0      _MyHomePageState._incrementCounter.<anonymous closure> (package:hello_flutter_external/main.dart:63:7)
#1      State.setState (package:flutter/src/widgets/framework.dart:1109:30)
#2      _MyHomePageState._incrementCounter (package:hello_flutter_external/main.dart:56:5)
#3      _InkResponseState._handleTap (package:flutter/src/material/ink_well.dart:1004:21)
#4      GestureRecognizer.invokeCallback (package:flutter/src/gestures/recognizer.dart:247:24)
#5      TapGestureRecognizer.handleTapUp (package:flutter/src/gestures/tap.dart:612:11)
#6      BaseTapGestureRecognizer._checkUp (package:flutter/src/gestures/tap.dart:298:5)
#7      BaseTapGestureRecognizer.acceptGesture (package:flutter/src/gestures/tap.dart:269:7)
#8      GestureArenaManager.sweep (package:flutter/src/gestures/arena.dart:157:27)
#9      GestureBinding.handleEvent (package:flutter/src/gestures/binding.dart:449:20)
#10     GestureBinding.dispatchEvent (package:flutter/src/gestures/binding.dart:425:22)
#11     RendererBinding.dispatchEvent (package:flutter/src/rendering/binding.dart:329:11)
#12     GestureBinding._handlePointerEventImmediately (package:flutter/src/gestures/binding.dart:380:7)
#13     GestureBinding.handlePointerEvent (package:flutter/src/gestures/binding.dart:344:5)
#14     GestureBinding._flushPointerEventQueue (package:flutter/src/gestures/binding.dart:302:7)
#15     GestureBinding._handlePointerDataPacket (package:flutter/src/gestures/binding.dart:285:7)
#16     _invoke1 (dart:ui/hooks.dart:167:13)
#17     PlatformDispatcher._dispatchPointerDataPacket (dart:ui/platform_dispatcher.dart:341:7)
#18     _dispatchPointerDataPacket (dart:ui/hooks.dart:94:31)

Handler: "onTap"
Recognizer:
  TapGestureRecognizer#21ff9
════════════════════════════════════════════════════════════════════════════════════════════════════

Example error on web:
══╡ EXCEPTION CAUGHT BY GESTURE ╞═══════════════════════════════════════════════════════════════════
The following _Exception was thrown while handling a gesture:
Exception: test message

When the exception was thrown, this was the stack:
dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/errors.dart 251:49  throw_
packages/hello_flutter_external/main.dart 63:7                                <fn>
packages/flutter/src/widgets/framework.dart 1109:30                           setState
packages/hello_flutter_external/main.dart 56:5                                [_incrementCounter]
packages/flutter/src/material/ink_well.dart 1004:21                           [_handleTap]
packages/flutter/src/gestures/recognizer.dart 247:24                          invokeCallback
packages/flutter/src/gestures/tap.dart 612:48                                 handleTapUp
packages/flutter/src/gestures/tap.dart 298:5                                  [_checkUp]
packages/flutter/src/gestures/tap.dart 269:7                                  acceptGesture
packages/flutter/src/gestures/arena.dart 157:12                               sweep
packages/flutter/src/gestures/binding.dart 449:20                             handleEvent
packages/flutter/src/gestures/binding.dart 425:14                             dispatchEvent
packages/flutter/src/rendering/binding.dart 329:11                            dispatchEvent
packages/flutter/src/gestures/binding.dart 380:7                              [_handlePointerEventImmediately]
packages/flutter/src/gestures/binding.dart 344:5                              handlePointerEvent
packages/flutter/src/gestures/binding.dart 302:7                              [_flushPointerEventQueue]
packages/flutter/src/gestures/binding.dart 285:32                             [_handlePointerDataPacket]
lib/_engine/engine/platform_dispatcher.dart 1118:13                           invoke1
lib/_engine/engine/platform_dispatcher.dart 185:5                             invokeOnPointerDataPacket
lib/_engine/engine/pointer_binding.dart 147:39                                [_onPointerData]
lib/_engine/engine/pointer_binding.dart 560:18                                <fn>
lib/_engine/engine/pointer_binding.dart 513:21                                <fn>
lib/_engine/engine/pointer_binding.dart 227:16                                loggedHandler

Handler: "onTap"
Recognizer:
  TapGestureRecognizer#a5aa8
════════════════════════════════════════════════════════════════════════════════════════════════════

@lrhn The IntelliJ plugins are written in Java and we aren't using package:stack_trace. We're instead parsing the stdout from the Flutter SDK, really only looking for URIs. If this stack trace/URI formatting is a result of JS translation, we may just have to implement a slightly different parsing method in the plugins.

Note that DDC produces JS stacks initially, but then uses a stack-trace-mapper to processes stacks and convert them using inline source-map content added to each .js module. The stack-trace-mapper is not shipped with the SDK but loaded by serving frameworks (like flutter web and webdev).
The stack-trace-mapper uses package:stack_trace internally, and it may be possible to tweak how the lines get formatted. There is a risk, however, that other tools/scripts may be relying on today's format, so a change to the mapper would need to be rolled out carefully.
Long term, my personal preference in the future is to move away from using the stack-trace mapper and leave the original JS stacks intact if possible. Then let the IDEs manage the translation with source-map outside of the client process (this is the mechanism we take with dart2js, where production stacks are deobfuscated on the server-side). Unfortunately, there are additional challenges we need to resolve first before we can do this.

@sigmundch Is source-map a package/other entity or do you mean the general idea of having a map from sources to JS files?
I'll bring up this issue within IDEs and then update here if we want to try to coordinate a change.

Source-maps is a standard used by many browsers vendors to convert JS location back to the original source locations (in our case in Dart). We have an implementation of the translation in Dart in package:source_maps (which is used also by the stack-trace-mapper). There are implementations in other languages too (including Java) and, for instance, our internal customers use such implementations to convert stack traces server-side.

We're going to make some changes on the IDE side, so I can close this. Thanks for the input here all!


UVI Request

--- UVI JSON ---
{
  "vendor_name": "Linux",
  "product_name": "Kernel",
  "product_version": "versions from v2.6.30 to before v4.14.249",
  "vulnerability_type": "unspecified",
  "affected_component": "unspecified",
  "attack_vector": "unspecified",
  "impact": "unspecified",
  "credit": "",
  "references": [
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=c71a896154119f4ca9e89d6078f5f63ad60ef199",
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=d56171d9360c0170c5c5f8f7e2362a2e999eca40"
  ],
  "extended_references": [
    {
      "type": "commit",
      "value": "c71a896154119f4ca9e89d6078f5f63ad60ef199",
      "note": "introduced"
    },
    {
      "type": "commit",
      "value": "d56171d9360c0170c5c5f8f7e2362a2e999eca40",
      "note": "fixed"
    }
  ],
  "reporter": "joshbressers",
  "reporter_id": 1692786,
  "notes": "",
  "description": "blktrace: Fix uaf in blk_trace access after removing by sysfs\n\nThis is an automated ID intended to aid in discovery of potential security vulnerabilities. The actual impact and attack plausibility have not yet been proven.\nThis ID is fixed in Linux Kernel version v4.14.249 by commit d56171d9360c0170c5c5f8f7e2362a2e999eca40, it was introduced in version v2.6.30 by commit c71a896154119f4ca9e89d6078f5f63ad60ef199. For more details please see the references link."
}
--- UVI JSON ---

This issue has been assigned UVI-2021-1001540


Replaced pyyaml with ruamel.yaml

Created a git mirror for ruamel.yaml.
Added ruamel.yaml as a submodule.
Added support for installing ruamel.yaml from pip.

Addresses issue #282

Hello @UjjwalAyyangar! Thanks for submitting the PR.

In the file cli/setup.py, following are the PEP8 issues :

Line 4:8: E225 missing whitespace around operator

Encountered an installation issue with the build. I will fix it and notify when completed.

@ivotron Completed :+1:

Thanks a lot!


Feat: Enhancing few section of home page

Describe the feature
I have added the link below
Add ScreenShots
https://www.awesomescreenshot.com/video/29752082?key=38c776a7fb713f78de7d720e275e55af
https://www.awesomescreenshot.com/video/29752156?key=da511afdade1871d7ad59914ed3e5c42
Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[ ] I'm a VSoC'24 contributor
[X] I want to work on this issue

@mdazfar2 i have added scrolling effects to these 2 parts. Do you need it??

@ayush-848 As of now, we do not need it. We will let you know in the future if there is a need. Please search for another issue and raise it, which I'm happy to assign to you.


docs: update setup and configuration

Summary by CodeRabbit

Documentation

Updated configuration documentation for clearer guidance on bot setup.
Renamed and reorganized setup instructions for improved clarity.
Added a new section on creating a Twitch developer account, including details on client ID and secret.
Expanded instructions for updating the auth_code in the configuration file, emphasizing the need to restart the server.

LGTM 👌


Investigate serving frontend on server

QoL feature.
Look into static html export and express.static.

this is svelte not next
I looked into this pretty early on in the project and it seems like a bit of a PITA. Not saying it won't happen but chances are slim unless i get really bored


Code consistency

While working on the extension over the last few days I saw a lot of inconsistencies around the code.
So I added an .editorconfig file and included the TSLint rules VSCode is using to establish a more consistent code. Also I went through the code and cleaned it up a little bit.
I probably haven't caught all inconsistencies but I guess it is a start.

 I apologize - I went on vacation, came back, and never touched this PR. Excellent work, thank you so very much.