Fix SKU is changed to null value if the parameter is not specified in the input data

SKU is changed to null value if the parameter is not specified in the input data
Fixes https://github.com/saleor/saleor/issues/11811

Impact

[ ] New migrations
[ ] New/Updated API fields or mutations
[ ] Deprecated API fields or mutations
[ ] Removed API types, fields, or mutations
[ ] Documentation needs to be updated

Pull Request Checklist

[ ] Privileged queries and mutations are guarded by proper permission checks
[ ] Database queries are optimized and the number of queries is constant
[ ] Database migration files are up to date
[ ] The changes are tested
[ ] GraphQL schema and type definitions are up to date
[ ] Changes are mentioned in the changelog

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Mat menu height gets shrinked when scrolled out of view

Bug, feature request, or proposal:
Bug
What is the expected behavior?
When an opened menu is scrolled out of the view, and it's scrolled back to the view, then it should have the original height.
What is the current behavior?
When an opened menu is scrolled out of the view, and it's scrolled back to the view, then it loses it's original height and gets shrinked to the height of one menu-item.
What are the steps to reproduce?

Use the mat-menu with reposition scroll strategy (that's the default)
Open mat-menu
If it's opened above the menu trigger then scroll down, if it's opened below then scroll up until you scroll the menu out of the view

Stackblitz example:
I used the original mat-menu example from the angular.material.io and just slightly modified the html by adding some extra content to make it scrollable.
Just open the link and see the menu trigger on the middle of the page and do the reproduction steps. Furthermore see the attached gif below.
https://stackblitz.com/edit/angular-rnvofb-2d2zsm?file=src%2Fapp%2Fmenu-overview-example.html

What is the use-case or motivation for changing an existing behavior?
To fix the issue mentioned above
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
@angular/material ~8.2.2
Is there anything else we should know?
Tested it in chrome.
Possible solution can be: (only checked it in browser console, but it worked)
Call the withGrowAfterOpen(true) on the position builder when the related overlay config is retrieved for the overlay. This overlay config instantiated inside the  _getOverlayConfig() function in the menu.trigger.ts.
So it would look like this:
private _getOverlayConfig(): OverlayConfig {
    return new OverlayConfig({
      positionStrategy: this._overlay.position()
          .flexibleConnectedTo(this._element)
          .withLockedPosition()
          .withGrowAfterOpen(true) // this is newly added
          .withTransformOriginOn('.mat-menu-panel, .mat-mdc-menu-panel'),
      backdropClass: this.menu.backdropClass || 'cdk-overlay-transparent-backdrop',
      scrollStrategy: this._scrollStrategy(),
      direction: this._dir
    });
  }

My current temporary solution is setting the min height for the connected position overlay element (with class "cdk-overlay-connected-position-bounding-box") to equal with it's height after opening, but it's quite a hack as I get this element from the DOM with getElementsByClassName.

Any updates on this one? Or do you guys have found any workarounds?

Any updates on this one? Or do you guys have found any workarounds?
Except of closing it on scroll of course...

For me it worked what I mentioned at the end of my report, see below as well.
If you set the min-height for the element equal with it's height after opening, then it can't shrink.
My current temporary solution is setting the min height for the connected position overlay element (with class "cdk-overlay-connected-position-bounding-box") to equal with it's height after opening, but it's quite a hack as I get this element from the DOM with getElementsByClassName.

Any updates on this one? Or do you guys have found any workarounds?
Except of closing it on scroll of course...

For me it worked what I mentioned at the end of my report, see below as well.
If you set the min-height for the element equal with it's height after opening, then it can't shrink.
My current temporary solution is setting the min height for the connected position overlay element (with class "cdk-overlay-connected-position-bounding-box") to equal with it's height after opening, but it's quite a hack as I get this element from the DOM with getElementsByClassName.

Ty, I have found temporary solution in another issue https://github.com/angular/components/issues/13988. It has done the job for now.


How do I insert foreign key related data?

when i execute below line,
modelBuilder.Entity<DeviceTypeFamily>().HasData(new DeviceTypeFamily {Name = "ABC" });
This line will produce auto generated guid, now this shall be the input for new table. How can we do it?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: fc418ab9-0592-f610-e751-40cb501220da
Version Independent ID: 822e8923-2647-f573-0c74-66af903776d8
Content: Data Seeding - EF Core
Content Source: entity-framework/core/modeling/data-seeding.md
Product: entity-framework
GitHub Login: @AndriySvyryd
Microsoft Alias: divega

@kudlatiger You need to specify the GUID value explicitly, HasData cannot be used with store-generated values


investigate validation options

https://www.tandfonline.com/doi/abs/10.1198/106186006X136976?cookieSet=1
https://arxiv.org/abs/1804.06788

These don't appear to easily apply to dinf.

Looking at Talts et al. (https://arxiv.org/abs/1804.06788) again, I think it is worth attempting.

https://statmodeling.stat.columbia.edu/2021/09/03/simulation-based-calibration-some-challenges-and-directions-for-future-research/

We don't actually have a posterior distribution, so we can't use this stuff.


update HTTP links to HTTPS in examples, try, use, and package files

Changes links from HTTP to HTTPS in appropriate places; fixes issue #32

Thanks!


Add metric to track number of segments missed in upsert-snapshot

label:

observability

Adding a metric to track number of segments missed in upsert-snapshot.
cc @ankitsultana

Codecov Report
Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 0.00%. Comparing base (59551e4) to head (9791998).
Report is 73 commits behind head on master.

Files
Patch %
Lines

...a/org/apache/pinot/common/metrics/ServerGauge.java
0.00%
2 Missing :warning:

...cal/upsert/BasePartitionUpsertMetadataManager.java
0.00%
1 Missing :warning:

Additional details and impacted files
@@              Coverage Diff              @@
##             master   #12581       +/-   ##
=============================================
- Coverage     61.75%    0.00%   -61.76%
=============================================
  Files          2436     2375       -61
  Lines        133233   129984     -3249
  Branches      20636    20146      -490
=============================================
- Hits          82274        0    -82274
- Misses        44911   129984    +85073
+ Partials       6048        0     -6048

Flag
Coverage Δ

custom-integration1
?

integration
0.00% <0.00%> (-0.01%)
:arrow_down:

integration1
?

integration2
0.00% <0.00%> (ø)

java-11
?

java-21
0.00% <0.00%> (-61.63%)
:arrow_down:

skip-bytebuffers-false
0.00% <0.00%> (-61.75%)
:arrow_down:

skip-bytebuffers-true
0.00% <0.00%> (-27.73%)
:arrow_down:

temurin
0.00% <0.00%> (-61.76%)
:arrow_down:

unittests
?

unittests1
?

unittests2
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Create sitee

Summary

Changes

Closes:
Task list

[x] For workflow changes, I have verified the Actions workflows function as expected.
[x] For content changes, I have reviewed the style guide.

Summary
Changes
Closes:
Task list

[x]  For workflow changes, I have verified the Actions workflows function as expected.
[x]  For content changes, I have reviewed the style<EMAIL_ADDRESS>

https://sites.google.com/view/selectbazaar/home


Installation clarifications

As I rushed to set this up locally to get something working for our call center in S Houston in response to Harvey, I ran into a couple issues that I was able to work through, but thought might be helpful to document to help future people.

Added a quick note in the README about how this needs to work when running locally (need ngrok). It's obvious why ngrok is necessary for local work, but in my rush I didn't realize it for a little while.
Because all of the setup processes happen asynchronously, and because the error messages if you haven't set up a chat service, for example, may not be clearly related to the problem, I added simple log statements on errors to help identify the part of the application that was failing.

No big changes here, just helpful tools to save people some time later on. (Sorry just realized I didn't rebase, but hopefully these changes are simple enough to just absorb!)

Thanks for the update, I've merged it.


Git - un(stage) selected ranges does not respect file encoding setting

Does this issue occur when all extensions are disabled?: Yes

Version: 1.74.0 (system setup)
Electron: 19.1.8
Chromium: 102.0.5005.167
Node.js: 16.14.2
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.19044
Sandboxed: No
Steps to Reproduce:

Settings -> "files.encoding": "windows1252" (either workspace or user or both)
open/create new file with encoding windows1252
enter some umlauts (äöüßÄÖÜ and some text)

stage the changes
open changes in diff
mark some of the changes and select "unstage selected ranges"
now the content of the staged changes is trash because the file got reencoded

❗ The problem has become even more prominent with 1.88.1 ("Diff Editor Stage/Revert Selection Buttons") because the button  for staging is now in the differ UI which has the same problem as described above

Closing as duplicate of #111915


[ Bug Fix ] fix the error in FP32 only case

There is configuration bugs for the FP32 only case. This PR fixes the configuration and some of the ENABLE_FP16 compiler macro errors.
Resolves:
Self evaluation:

Build test:	 [X]Passed [ ]Failed [ ]Skipped
Run test:	 [X]Passed [ ]Failed [ ]Skipped

Commits to be reviewd in this PR
   title
contents
Signed-off-by:jijoong.moon<EMAIL_ADDRESS>

LGTM!
Were configuration bugs also the case with ARM64 machines?

I'm not sure. We should test .


DO NOT PUBLISH OR REBASE: Restructure demo

Closing as example and URL available still.

Closing. Link is not working anymore. I have a local branch.


New package: Thorn v0.1.0

Registering package: Thorn
Repository: https://github.com/TenzinCHW/Thorn.jl
Created by: @TenzinCHW
Version: v0.1.0
Commit: d61cd59c7f91be43b13a5c778980ed696f882363
Reviewed by: @TenzinCHW
Reference: https://github.com/TenzinCHW/Thorn.jl/commit/d61cd59c7f91be43b13a5c778980ed696f882363#commitcomment-39199689

I have updated compat. Not sure how to update this PR but I will try to initiate the process again through the Github App.

@TenzinCHW you commented without the [noblock] text, so automerge didn't work.  Just to confirm, are you happy with us manually merging this pull request?

@giordano Hi yes sure. Sorry about that.


Could you please update it to laravel 5.2.. i will be very thankful

Hello, actually i tried to install all the dependency and all of it get installed but the problem is on artisan command it's not working.. don't know why tried many times.. and yeah i'm using laravel 5.2 now to build my project.. could you please update this to laravel 5.2 or give me some instructions how to set in laravel 5.2.. please help me as soon as possible ,i will be thankful for this a lot.

Hi @Rahul-Giri,
The project was updated to Laravel 5.2 in https://github.com/sahat/satellizer/commit/c9e3c688ad2c1da3fcd5992d57cfbbca0a3170af.
Hope that helps!


chore(env): Update fast forward pipeline token

Trying to pass GITHUB_SECRET directly to the fast forward pipeline, as this value is taken from env variables in sequoia-pgp/fast-forward@v1 action
Signed-off-by: [Michał Leszczyński]<EMAIL_ADDRESS>

/fast-forward


Issue where user selection on navbar and checkout page is annoying user experience

Updated both components with user selection turned off


changed output to html, to be able to style the number more precisely

With that method you are be able (for example) to split the number in two parts and give them different spans to style them differently.
For example:
`
  formatValue(v) {
    v = v.toFixed(2)
    let a = v.toString().split('.')
    return `<span>${a[0]}.</span><small>${a[1]}</small>`;
  }

`

Thanks for your contribution @stylefieber


update to work with angular 17

This adds support for Angular 17 and adds a fix to the core unit tests to support new behavior for OnPush notifications
Addresses Issue #62

@thekiba check this PR pls;

@ValeraS @alQlagin @tplk mb you can check this PR, pls ?


html tags in the markdown files

Thank you for a very useful project!
I wanted to add more help on version 7.55 and re-generate the markdown files.
Downloaded help 7.31, 7.40, 7.52 and 7.55.
Added version 7.55 everywhere in the script files.
I edited the build.sh file and left only this tsc && ts-node index.ts
Now if I open an md file in Typora, I see some html tags

Hi @lwfl,
Thanks for contributing with this issue. It could be that the HTML for the 7.55 documentation is slightly different from the other versions.
What happens if you open this file in a browser? Does it also show the HTML tags? This issue could be specific to Typora.
Nevertheless, feel free to contribute with a Pull Request (I am not actively looking at this project any more, but would review and test a PR).
Most likely, you would need to change the [parser](url) to handle the special cases.

Eduardo, thanks for the quick response.
html tags can be seen in the markdown file itself.
Probably, they changed the structure of html file and parser works incorrectly.
Unfortunately, I don't have enough knowledge in TypeScript to join your project and make changes.
I had an idea to make a converter from SapScript to markdown format.
Similar to how ABAP_DOCU_DOWNLOAD_FILES report unloads help in html.
The structure of SapScript is simpler than that of html.


Flexibility on passing the test requirements.

Describe the Issue
The test "Build a Pokémon Search App Project - Build a Pokémon Search App" has some stories that require me to have certain elements with specific IDs to be present in the project. Now, nowhere does it say that those elements must strictly be present in the index.html file. So, when I created those elements with the exact Id-naming requirements in script.js. The test did not pass. I think the tests should pass as long as the elements are present in the project regardless of the file they are in.
Affected Page
https://www.freecodecamp.org/learn/javascript-algorithms-and-data-structures-v8/build-a-pokemon-search-app-project/build-a-pokemon-search-app
Your code

<!DOCTYPE html>

    <meta charset="UTF-8">
    <meta name="viewport" content="width=device-width, initial-scale=1.0">
    <meta http-equiv="X-UA-Compatible" content="ie=edge">
    <title>Pokemon Search Project</title>
    <link rel="stylesheet" href="styles.css">

Pokemon Search App

Search for Pokémon Name or ID:
<input id="search-input" required>
<button id="search-button">Search</button>

/* file: script.js */
const input = document.getElementById("search-input");
const btn = document.getElementById("search-button");
const heading = document.getElementById("page-heading");
const dataDiv = document.getElementById("pokemonData");

btn.addEventListener("click", ()=>{

async function fetchData(){
  try{
    const inputValue = input.value.toLowerCase();
    const response = await fetch(`https://pokeapi-proxy.freecodecamp.rocks/api/pokemon/${inputValue}`)

  if (!response.ok){
    alert("Pokémon not found")
  }
    const data = await response.json();
    console.log(data)
    dataDiv.innerHTML = `

${data.name.toUpperCase()}

Id: ${data.id}

Height: ${data.height}

Weight: ${data.weight}

Hp: ${data.stats[0].base_stat}

Attack: ${data.stats[1].base_stat}

Defense: ${data.stats[2].base_stat}

Sp. Attack: ${data.stats[3].base_stat}

Sp. Defence: ${data.stats[4].base_stat}

Speed: ${data.stats[5].base_stat}

Type: ${data.types.map(obj => obj.type.name).join(", ").toUpperCase()}

      `;

  }
  catch(error){
    console.log(error)

  }
}
fetchData()
})

/* file: styles.css */
body{
background-color: black;
color: white;
}

Expected behavior
Expected the code to pass since the required elements were present in the project.
Screenshots
No response
System

Browser: Microsoft Edge [Version 127.0.2651.105 (Official build) (64-bit)]

Additional context
I am only talking about the tests 3 to 13 here. Ignore other tests as I have not completed the project as of submitting this request.

It's not as much in which file they are, but at which point they are present on page. Tests 3-13 are using similar wording as tests 1 & 2. 1 & 2 clearly must be present on load to be able to fulfill further tests.
Similarly tests 14+ are very clear that specific actions must be taken before result can be checked. That's not a case for 1-13 tests.

I understand that the wording is similar but in both the modules of API in "JavaScript Algorithms and Data Structures (Beta)", the elements are created in the script.js and not in the index.html. So, when the elements created in the "Build a Pokémon Search App Project" in script.js do not pass, It seems counter-intuitive to teach that in the first place. Also, it makes the test seem more rigid than flexible on methods.

It's not as much in which file they are, but at which point they are present on page. Tests 3-13 are using similar wording as tests 1 & 2. 1 & 2 clearly must be present on load to be able to fulfill further tests.
Similarly tests 14+ are very clear that specific actions must be taken before result can be checked. That's not a case for 1-13 tests.

I understand that the wording is similar but in both the modules of API in "JavaScript Algorithms and Data Structures (Beta)", the elements are created in the script.js and not in the index.html. So, when the elements created in the "Build a Pokémon Search App Project" in script.js do not pass, It seems counter-intuitive to teach that in the first place. Also, it makes the test seem more rigid than flexible on methods.

Thank you for your feedback, I see how this might be a bit confusing.
We should add a second note:  Please note that the first 13 steps must be completed inside the index.html file.  We should put this note above the user stories.


Extension Report 5196, 5197 and 5198 "Add Contact" etc.

We need a way to extend the core elements of segmentation in terms of the master data (contacts) to be used.

Since it is not possible to extend reports, we propose to convert functionality to objects of the type Filter BuilderPage, for example. The functions these filter BuilderPages create could then include publishers to attach tables. Prerequisites may also be necessary here. For example, specifying a field with relation to the Contact table or related tables.

Great idea! Go ahead and post this to our Ideas forum at https://aka.ms/BusinessCentralideas, or vote up the idea if its already there. We're constantly monitoring top Ideas and will consider them for a future release.


Remove localization segment

https://github.com/aspnet/Docs/pull/10789#discussion_r253707591

What about the other templates?

It's in a few README files but not in template code that renders output.

@guardrex could you resolve the merge conflict if this PR is still valid?

I must have deleted by fork for some reason. I'll reconstitute this tomorrow (Saturday) morning.


BlitPixelData

We've got a PixelData section written, thanks again @Tresquel, but appear to be missing BlitPixelData!
If someone could quickly write up a description and add it it would be very helpful.

Didn't see it at first, will do later 👍


Just some extra stuff with Flax and Onnx, which maybe I should try to use

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Add templates

Describe the added commits
Issues and pr templates are added in these commits. This should tell issues and pr openers about the information they need to provide.
Additional context
This is an implementation of #941

Hi @molangning
I think this is a great stuff, but feel like it needs a bit more work towards it before it can be merged.
Breaking it down - simple and quick is what people would need todo at the very least.

Why are they doing it?
Where did they get the values from (source) - its always good to know what upstream is and to give credit!

Thanks for the feedback! I will work on it more.

@g0tmi1k I have added them and some more templates I felt would be helpful.

Thanks @molangning .
Will give this a spin and may alter it slightly later.


Update publish workflow + add dependabot

This PR closes #115 by updating the publish to PyPI workflow. Note, the workflow will only run if a GitHub release is published. I.e., one can create draft releases and hold off publishing it until it's relevant.
It's worth noting that the built distributions (bdist) rely on the OS, here being Ubuntu 20.04. If a specific OS is desired, the runs-on value should be changed accordingly.
This PR also adds dependabot, which will run for two different cases:

pip
Monday mornings, it will run to check if there are newer versions released for the packages specified in requirements.txt, comparing to the versions specified in said file. Since only a single package has a version specified (Owlready2), it will be the only one targeted at this point in time.
actions
Every weekday morning, it will check whether there are newer versions for the actions used in the GitHub Actions workflows.

Finally, I've updated the used actions in both workflows to the latest.

Ah. You might also want to consider using an API token for PyPI instead of storing your username and password in the project secrets. Then the username and password should be changed to:
        user: __token__
        password: ${{ secrets.PYPI_TOKEN }}

Ah. You might also want to consider using an API token for PyPI instead of storing your username and password in the project secrets. Then the username and password should be changed to:
        user: __token__
        password: ${{ secrets.PYPI_TOKEN }}

Looks fine.

Looks fine.


Update vendor

@jmontleon and @jortel were able to build this on their machines, so think it's safe to merge.

Agreed.


Update Composer dependencies (2023-10-02-00-17)

Visual regression test passed!
View the visual regression test report


Suggestion for addition to documentation

I would suggest adding to the documentation that the infinite-scroll directive must be a child of the DIV that is being watched for scroll.
e.g.
WONT WORK

WILL WORK

+1


Need access to be able to submit

I somehow cannot push to the repo. But I'd like to share teh orthoprofile.

We could also right away move to lexibank.

Ok, moved to lexibank, so you should be able to push now. Let me know if it's still locked.


Protein integration

Data containing different analytes can be separated and protein data has extra QC steps added. Protein data can go through HK and Neg normalization.
Added functionality for ignoring PKC files that weren't actually used in the study compared to the config file.
Tests have been added for all new features. I did not rewrite tests to validate outputs when using protein instead of RNA. I only wrote tests for the new features.

Approved by Shilah

check looks good. The mixedModelDE example always fails on my instance.
── R CMD check results ────────────────────────────────────────────────────────────────────────────────────────────────────── GeomxTools 2.1.2 ────
Duration: 14m 18.7s

checking examples ... ERROR
Running examples in ‘GeomxTools-Ex.R’ failed
The error most likely occurred in:

base::assign(".ptime", proc.time(), pos = "CheckExEnv")
Name: mixedModelDE
Title: Run a mixed model on GeoMxSet
Aliases: mixedModelDE
** Examples
datadir <- system.file("extdata", "DSP_NGS_Example_Data", package = "GeomxTools")
demoData <- readRDS(file.path(datadir, "/demoData.rds"))
target_demoData <- aggregateCounts(demoData)
target_demoData <- normalize(target_demoData, norm_method="quant")
target_demoData <- target_demoData[1:100, ]
pData(target_demoData)[["slide"]] <-

factor(pData(target_demoData)[["slide name"]])

protocolData(target_demoData)[["pool_rep"]] <-

factor(protocolData(target_demoData)[["pool_rep"]])

mixedOutmc <- mixedModelDE(target_demoData,

                       elt = "exprs_norm",

                       modelFormula = ~ pool_rep +  (1 | slide),

                       groupVar = "pool_rep",

                       nCores = 12,

                       multiCore = TRUE,

                       pAdjust = NULL

)
Error in .check_ncores(cores) : 12 simultaneous processes spawned
Calls: mixedModelDE ->  -> .check_ncores
Execution halted

checking tests ...
See below...

checking for unstated dependencies in examples ... OK
WARNING
‘qpdf’ is needed for checks on size reduction of PDFs

checking installed package size ... NOTE
installed size is 25.3Mb
sub-directories of 1Mb or more:
doc       5.3Mb
extdata  19.1Mb

checking DESCRIPTION meta-information ... NOTE
License components which are templates and need '+ file LICENSE':
MIT

checking top-level files ... NOTE
File
LICENSE
is not mentioned in the DESCRIPTION file.

checking R code for possible problems ... NOTE
aggregateCounts: no visible binding for global variable ‘TargetName’
hkNorm: no visible binding for global variable ‘TargetName’
mixedModelDE: multiple local function definitions for ‘deFunc’ with
different formal arguments
setGrubbsFlags: no visible binding for global variable ‘TargetName’
setGrubbsFlags : : no visible binding for global variable
‘Module’
setProbeRatioFlags: no visible binding for global variable ‘TargetName’
setTargetFlags: no visible global function definition for ‘analtye’
subtractBackground : : no visible binding for global
variable ‘Module’
setSignatureFuncs<-,NanoStringGeoMxSet-character: no visible global
function definition for ‘setSigFuncs<-’
signatureScores,NanoStringGeoMxSet: no visible global function
definition for ‘assayDataElement2’
signatureScores,NanoStringGeoMxSet: no visible global function
definition for ‘.sigCalc’
Undefined global functions or variables:
.sigCalc Module TargetName analtye assayDataElement2 setSigFuncs<-


Fresh install does not run due to missing dependencies

It seems that either package.json or the README is incomplete.
git clone, then npm install, then ./bin/hubot initially results in
Error: Cannot find module 'lodash'
It seems either modules are missing from package.json, or it expects globally installed npm packages which aren't called out in the README
Or, as seems to be the preferred communication mechanism round this here repo: :rage:

:pensive: :hospital: :clock1:


h2 tags should not have capitalize applied to them because different languages have different casing rules

US title casing differs from other languages. e.g. in French you only capitalize the first word in a header.
We need to update strings to fit the country casing rules + remove the capitalize css

will change the CSS, but @nburt question re: translation -- when we change titles, will Smartling always re-translate them with first-letter capitalization as we do in the US, meaning we'll have to fix it, or will it learn the capitalization differences?


Fixes file path matching for resource files on Windows

Resource file detection was failing on Windows with the message 'Keyword definition not found from the workspace'.
Uri.fsPath was used when parsing all files but Uri.path was used to find the cached keywords later.
Fixes #16.
I tested this on Windows. I have not yet been able to test it on Mac.

Thank you for fixing this! Tested and works nicely on Mac as well.


Modify browser-based polling to poll the current microservice the user is looking at

Currently the dashboard begins polling a statically configured endpoint upon browser load. This feeds a single microservice instance's metrics into Redux as timeseries data (stored in memory).
This approach works fine for a single microservice, but it likely does not scale well for multiple microservices because:

Each microservice pulls a fairly large metrics.json file (~98kb for the ESS service) pretty often (now every 5 seconds by default). This means approximately 20kbps per microservice
Each poll must be parsed and refactored into timeseries metrics, some of which happens on the main UI thread.
Because the timeseries metrics are stored in Redux, this information is held in memory. The memory footprint for a single microservice grows substantially over time (at a theoretical rate of ~4KBps for ESS, likely less than half that due to JS runtime optimizations). This amounts to somewhere between 175 - 350 MB after collecting 24 hours of metrics.

In order to support multiple microservices before a full TSDB implementation, it makes sense to limit the app to polling a single microservice at a time. This should be whatever microservice the user is actively looking at. Initially, metrics should just be purged and replaced when switching between active microservices ( bringing us to feature parity with current implementation).
However, in a future PR, Redux can namespace metrics by service name and instance IDs to preserve previously captured metrics.

Work around this area is in 93-config-scrape-point. It should be broken out into a separate feature branch when the blocking issues around service discovery are resolved.

Resolved by 0.5.0


WIP Fix motor torque calculation

This is a poor way to implement the correct calculation. We need to track across two classes what terms have been calculated and which have not. However, I'm not sure there if there is a better way to implement this. Some other options are to:
1. Pass the measured sensor torque to sim::Bicycle. This would allow the motor torque calculation to be done entirely in sim::Bicycle. However, the steer torque input is calculated in the project file.
2. Get the steer acceleration from sim::Bicycle and do the motor calculation in the project file. This would keep all physical terms outside of the sim::Bicycle class.
3.  Move the handlebar model into sim::Bicycle and do 1.
And this certainly needs some hardware tests before merging.
Fixes #109

[x] merge #119
[ ] build and test with hardware

I think option 3 makes the most sense.

I still need to test this on hardware and plot the results.

Data from two speeds v = 5, v = 7 with commit (Fix sign in motor torque calculation			a7f65a6): pr114.zip
v = 5

v = 7

After adding a 5 element moving average filter:

This looks better in that there is no longer a growing oscillation, however, this doesn't stabilize the steering column at all

Essentially the "scale factor" is a conversion from physical inertia to virtual inertia, assuming it scales linearly. Plots look a lot better though.

Steer state plot has poor convergence, likely due to the increase in measurement noise covariance in (WIP Changes to flimnap  … ff87200)

ADC events were not working, resulting in a filter output of zero.

Okay so this isn't working as it essentially breaks causality.
There are three candidates solutions:

Extension of the static handlebar feedback calculation to include roll rate and steer rate terms.
Extension of the static handlebar feedback calculation to include roll rate, steer rate, and steer acceleration terms.
Configure the motor drive for position control.

This is invalid.


Registering custom stack component flavors

Custom Stack Components
Hey everyone,
Previously, our stack component flavors were registered to a StackComponentRegistry which was populated upon runtime. This made it almost impossible for our users to add new flavors and it put a limit on our extensibility. With this PR, we will aim to change this and enable our users to implement and register custom stack component flavors.
There are a few important things to consider while we are going through the changes which I will try to explain as much as possible down below.
IMPORTANT: The branch is still WIP. I will try to finish it as soon as possible.
Adding the functionalities to the CLI
First of all, we can start with the new CLI functionalities. Let's take a look at the register first. Once you implemented a custom stack component such as:
class MyArtifactStore(LocalArtifactStore):
    """is the best"""
    some_random_param: str

    FLAVOR = "best"

    ...

You can now go ahead and register it as follows:
zenml artifact-store flavor register path.to.your.module.MyArtifactStore

ZenML will import the class and validate its flavor and type and register it in the ZenStore. If you are sharing this ZenStores, your teammates will also have access to this new flavor.
Now, you can take a look at your flavors by using the list subcommand as follows:
zenml artifact-store flavor list

which will show you something like this:
Running with active profile: 'baris' (local)
┏━━━━━━━━┯━━━━━━━━━━━━━┯━━━━━━━━━━━━━━┯━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┓
┃ FLAVOR │ INTEGRATION │ READY-TO-USE │ SOURCE                                                        ┃
┠────────┼─────────────┼──────────────┼───────────────────────────────────────────────────────────────┨
┃ local  │ built-in    │ ✅           │ zenml.artifact_stores.local_artifact_store.LocalArtifactStore ┃
┃ azure  │ azure       │ ✅           │ zenml.integrations.azure.artifact_stores.AzureArtifactStore   ┃
┃  gcs   │ gcp         │ ✅           │ zenml.integrations.gcp.artifact_stores.GCSArtifactStore       ┃
┃   s3   │ s3          │              │                                                               ┃
┃  best  │             │ ✅           │ my_artifact_store.MyArtifactStore                             ┃
┗━━━━━━━━┷━━━━━━━━━━━━━┷━━━━━━━━━━━━━━┷━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┛

There are a few important things to consider here:

All the flavors which are defined within integrations are already there, even before activating the integrations.
You can even see the flavors whose integrations are not installed.
ZenML can understand whether your new flavor can be imported, thus also used.

This is achieved by refactoring the integrations and introducing the notion of flavors to the ZenStores.
Refactoring the integrations
Now, our integrations have a declare method in addition to the activate method. This is only called when you initiate a ZenStore. As we will have to declare our flavor even when the integrations are not installed, the declaration within this method is a manual one and any integration which brings a new stack component need to conform to this new standard.
Example:
class GcpIntegration(Integration):
    """Definition of Google Cloud Platform integration for ZenML."""

    NAME = GCP
    REQUIREMENTS = ["gcsfs"]

    @classmethod
    def declare(cls, store: "BaseZenStore"):
        """Declare the stack component flavors for the GCP integration."""
        store.create_flavor(
            name=GCP_ARTIFACT_STORE_FLAVOR,
            source="zenml.integrations.gcp.artifact_stores.GCSArtifactStore",
            stack_component_type=StackComponentType.ARTIFACT_STORE,
            integration=cls.NAME,
        )

Removing the Stack Component registry
Since, we can now use the ZenStore to manage our flavors, the old stack component registry is completely removed.
Renaming the --type to --flavor
Finally, the type option is renamed to flavor in our CLI to reduce confusion.
Old:
zenml artifact-store register --type local --path=........

New:
zenml artifact-store register --flavor local --path=........

TODOs

I need to still implement to the delete methods.
The code needs more documentation.
I can add a zenml stack-component flavor describe method and some error handling when registering new stack components, so our users will have a smoother experience.
Implement tests.

Pre-requisites
Please ensure you have done the following:

[x] I have read the CONTRIBUTING.md document.
[ ] If my change requires a change to docs, I have updated the documentation accordingly.
[ ] If I have added an integration, I have updated the integrations table.
[ ] I have added tests to cover my changes.

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Other (add details above)

I'm assuming that large parts of the docs will need to be checked for the --type -> --flavor change. Just flagging this for @AlexejPenner since he's knee-deep in this at the moment...

Outside of the review, I had a question while testing your PR. There is a change in the CLI usability that I'm not yet sure was intentional. Let me show you what I mean:

before:

$ zenml orchestrator list
Registering default stack and user...
 Is there a way to hide the config attribute and still show the attributes of components coming from integrations that are active ?

@stefannica The change in your CLI output is not necessarily due to a limitation. Before this PR, when you did zenml orchestrator list, our CLI created the actual instances of all stack components of the given type, which caused a major slowdown and even some failures when you tried to list stack components whose integrations were not installed. In order to counter that, we have started using the wrappers, however the ComponentWrapper, in its nature, has the attributes encoded in a config attribute. I have adjusted our CLI output in a way that it is closer to your older output, however, I think I have to give out a warning here. If you registered 5 orchestrators with 5 different types which all have their own set of 5 unique attributes, the CLI will try to output more than 25 columns. I am not sure if this is the desired behavior.

@stefannica @schustmi I thought I would be able to address several comments at the same time through a bigger comment, so I will give it a shot.
First of all, I rearranged the implementation in a way that the different responsibilities throughtout registering/accessing the flavors have been placed in different components along the line.

Now, the 'register' and 'update' subcommands of stack components (which need to create an instance of a flavor) are using the 'Repository' to get the flavor.
Repository now has a get_flavor method which acts as a bridge between the flavor_registry and the ZenStore. It is responsible for checking if the flavor exists (KeyError if it doesn't) and if a custom flavor is overwriting a ZenML flavor.
The to_flavor of the FlavorWrapper is responsible for loading the source path class and raises two different ImportErrors (depending on the flavor having an integration).

With this approach, there is no duplicated code anymore.
Now, for the Repository-ZenStore relationship. At first, I wanted to design it in a way that the ZenStore is the entity which interacts with the wrappers/models and whereas the Repository is the user-facing version of it which lets you interact with the actual instances. This way, the users can get_stack or get_stack_component through it and they would not have to deal with the intermediary representations.
However, this situation leaves CLI in a weird spot as a user of ZenML. Let's look at two examples which leave the ZenStore exposed in the CLI:
1.zenml user create: This operation creates a user however, there is no corresponding create_user or register_user method in the definition of the Repository. Instead, it taps into the zen store within the repo and utilizes this store to create the user. This way, the functionalities that the Repository provides to our users are a bit more limited and but cleaner at the same time.
2. zenml artifact-store list: This is even a bit more complicated. On the first look, it seems like this need to call the get_stack_components method of the Repository. However, doing that means that we would be creating all the instances of these components, which can lead to slowdowns or failures (in the case of uninstalled integrations) and the solution here was to tap into the store to get the raw configurations.
I believe that this interaction can be improved. But, as far as I can see, it would also mean that a bigger refactoring session is required. I would be happy to discuss how we can arrange something like this, perhaps as a next iteration of the PR. Let me know if you have any questions.


Redirects are not supported when DNS is disabled

Would be nice if this was supported, as long as we provided an existing ACM Certificate ARN.
SST would take care of creating the extra distribution + S3 Website for redirects, with the appropriate alternate domain name and the ACM Certificate.
This is useful if DNS is not managed within AWS, so we'd just need to take care of creating the CNAME records pointing to the cloudfront hostnames.
As of now, adding redirects makes SST try creating a new ACM Certificate and ignore the ARN provided, which is a related issue logged here #853

@AlissonRS given #853 is supported, is this issue resolved?

I'm facing the same issue when using DNS that's not supported.
I have manually created the certificates in AWS and set the ARN in sst config. And accordingly, I've set dns to false.


"Drăgănești", "Orțăști", "Râșca" and "Șoimărești" are listed in the drop-down menu

Description:
"Drăgănești", "Orțăști", "Râșca" and "Șoimărești" are listed in the drop-down menu alongside its corresponding county and commune, according to the law
Precondition:
The website is up an running.

Step 1
Type "Drăgănești" in the search bar.

Expected results
The location is listed in the drop-down menu as "Sat Drăgănești, NEAMȚ (Drăgănești)" and "Comuna Drăgănești, NEAMȚ".

Step 2
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 4
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 6
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 7
Type "Șoimărești" in the search bar.

Expected results
The location is listed in the drop-down menu as "Sat Șoimărești, NEAMȚ (Drăgănești)".


run any test

Error: cabal: Cannot test the package testing-cardano-<IP_ADDRESS> because none of
the components are available to build: the test suite 'testing-cardano-test'
is not available because the solver picked a plan that does not include the
test suites, perhaps because no such plan exists. To see the error message
explaining the problems with such plans, force the solver to include the test
suites for all packages, by adding the line 'tests: True' to the
'cabal.project.local' file.

https://github.com/aleeusgr/testing-cardano/commit/5b24cdbca8bdbdfef3aa199cc1a17c34396fcc18


fix: use runtimes

:tada: This PR is included in version 1.9.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release
v1.9.3
v1.9.3

Your semantic-release bot :package::rocket:


Default folder setting while cloning a git repository

Added a setting for cloning a git repository to a default location.
If it is not specified in settings, it will prompt the user.
This PR is for the issue: https://github.com/Microsoft/vscode/issues/17671

Hi @gagangupt16, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

On checking logs of travis-ci, it is showing error at gulp hygiene --silent
On locally running, I found it is failing in file terminal.ts
vscode/src/vs/workbench/parts/terminal/electron-browser/terminal.ts is not formatted

I have signed the CLA yesterday. Is there anything else that needs to be done to change the label of PR?

Hi @gagangupt16, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
We will now validate the agreement and then real humans will evaluate your PR.
TTYL, MSBOT;

Hi,
AppVeyor build is failing.
Initially, it passed but after PR was closed and opened, it failed due to...
`) ExtHostWorkspace asRelativePath:
AssertionError: '.' == ''
+ expected - actual
-.
  at Context.<anonymous> (C:\projects\vscode\out\vs\workbench\test\node\api\extHostWorkspace.test.js:12:20)
  at callFn (C:\projects\vscode\node_modules\mocha\lib\runnable.js:326:21)
  at Test.Runnable.run (C:\projects\vscode\node_modules\mocha\lib\runnable.js:319:7)
  at Runner.runTest (C:\projects\vscode\node_modules\mocha\lib\runner.js:422:10)
  at C:\projects\vscode\node_modules\mocha\lib\runner.js:528:12
  at next (C:\projects\vscode\node_modules\mocha\lib\runner.js:342:14)
  at C:\projects\vscode\node_modules\mocha\lib\runner.js:352:7
  at next (C:\projects\vscode\node_modules\mocha\lib\runner.js:284:14)
  at Immediate.<anonymous> (C:\projects\vscode\node_modules\mocha\lib\runner.js:320:5)

`
I pulled latest code and pushed again. It failed again with...
1) Telemetry - common properties default:      Error: timeout of 10000ms exceeded. Ensure the done() callback is being called in this test.       at Timeout.<anonymous> (C:\projects\vscode\node_modules\mocha\lib\runnable.js:226:19)
It would be great if you can guide me through the inconsistency of the error and how can we make it correct.

Delaying this due to the upcoming SCM feature.

@gagangupt16 So sorry to let you know that I'll have to close this since the old Git world is deprecated.
I'd happily accept a PR on the new git extension. Or I can also implement it, I just don't want to step on your toes. Let me know what you want to do. 👍


Support for ordinal axis type

Pull Request
Hi,
Thanks for helping us improve the Predix UI platform by submitting a Pull Request.
To help us merge your Pull Request as fast as possible, please fill out the following sections:

A description of the changes proposed in the pull request:

This PR provides the ability to add ordinal chart type and this is a feature requirement for Event analysis which uses ordinal chart type, changes have been made to the px-vis-axis, px-vis-event, px-vis-markers, px-vis-register, px-vis-register-item and px-vis-tooltip to facilitate the ordinal type.
Also for event markers, added code to allow text per event in addition to the icons.
Please note that appropriate comments have been added inline.

A reference to a related issue (if applicable):

@mentions of the person or team responsible for reviewing proposed changes:

working tests:

The tests need to be functional and/or unit tests, written for the wct framework, and placed in the test folder, following our testing guidelines.

@evanjd
Hi Evan I already signed the CLA but it hasn't updated. Can you please review
Thanks

@JoabGE You've signed the CLA, but @madhuri-ch has not, and their commit is in your PR.

@JoabGE You've signed the CLA, but @madhuri-ch has not, and their commit is in your PR.

I have signed the CLA as well.  Thanks!!

@cla-bot check

@madhurich05 It looks like you've signed as @madhurich05, but your commit is authored by @madhuri-ch. Can you sign the CLA with the username you contributed code with?

@madhurich05 It looks like you've signed as @madhurich05, but your commit is authored by @madhuri-ch. Can you sign the CLA with the username you contributed code with?

Actually I did, not sure why it showed up with a different ID. I signed again with madhurich05. Here is the screenshot:

@evanjd sorry for all the comments if you want just ignore the rest and check this one.
Made the changes in all of the advices and fixed the test issue. The only one I didnt change is the Comic Sans MS to GE Inspira Sans since everywhere is used like that and is a fallback value in case GE fonts has not loaded.
If you want me to change it anyways I'll do it.
thanks

@evanjd  @justin-kirkwood
I checked the test and its working somehow there are some timeouts that are showing errors but test-wise everything is passing. Made the changes and also @evanjd  hope you do great wherever you go, good luck!
and Hi to @justin-kirkwood


Update validation.cpp

test13

@jonastest00 has been requested to review this pull request as specified in the REVIEWERS file.


modal: Make the modal content scrollable instead of the whole modal.

The first commit is required for the second commit to work in the Manage bot modal, since scrolling requires the overflow: auto CSS.
Before

After

I think we need a light border at the top of the footer area, but otherwise this lgtm.

I think we need a light border at the top of the footer area, but otherwise this lgtm.

Done.

Cool! Looks like the light border at the top of the footer area only got implemented for dark mode; I think we need it for light mode as well:

Are we tracking the same scrollbar issue for other parts of the app?

I think we need it for light mode as well

Specifically, please make sure it looks consistent with the Invite users modal in both light and dark theme, and post screenshots to confirm. Thanks!

Cool! Looks like the light border at the top of the footer area only got implemented for dark mode; I think we need it for light mode as well:

Done.

Are we tracking the same scrollbar issue for other parts of the app?

I think not. This is for modals only.

Specifically, please make sure it looks consistent with the Invite users modal in both light and dark theme, and post screenshots to confirm. Thanks!

Updated the PR description.

Cool, it's a bit different from how the invitation modal works, but it seems reasonable to standardize on this approach.

I have not re-tested, by @timabbott I think you can take a look now.

I think not. This is for modals only.

Got it; I filed #22958.

Merged, thanks @ganpa3!

Setting .mode_content to be flex introduces this type of bug. I am not sure if other modals have it.  @ganpa3 the correct fix would be to use it only the modals you want to be scrollable.

Setting .mode_content to be flex introduces this type of bug. I am not sure if other modals have it. @ganpa3 the correct fix would be to only use it on the modals you want to be scrollable.

That's because the flex-direction for this modal is set to row instead of column. It is set to column for other modals by data-simplebar.
I think adding data-simplebar to this modal would be better, since it fixes the bug, and also, in the rare case a user has a tiny browser window, it shows a simplebar scrollbar.
Opened #22985


Highlight Shapes and Points layer data only when active

References and relevant issues
Closes #7233
Description
Prevent showing data higlighted if the layers (Shapes or Points layers) are not the active layer:

Shapes behavior:

Points behavior:

Would be good to add a test for this, ideally.

That could be nice indeed but not totally sure how to assert that something is not being rendered over the canvas. The only thing I can think of is maybe some sort of test where multiple layers are created and screenshots are taken to check for the color of the highlight while changing the active layer. Does something like that make sense or maybe there is a simplier alternative for a test? :thinking:

Hmm perhaps checking that the highlight_visibility value gets toggled correctly on active layer changed would be at least a partial test. Agreed it's harder to check if the highlight is actually rendered, I don't have good ideas there

That could be nice indeed but not totally sure how to assert that something is not being rendered over the canvas.

typically I make a screenshot check with something that won't be too sensitive to rendering details. See for example my test in 6654:
    screenshot = viewer.screenshot(canvas_only=True, flash=False)
    # center should have a hole
    # use -1 because edge is exactly halfway down.
    center = (screenshot.shape[0] // 2 - 1, screenshot.shape[1] // 2)
    # ignore alpha channel
    np.testing.assert_array_equal(screenshot[center][:3], 0)

So in this case, I would check that the highlight color is or isn't present in the screenshot, based on the active layer.

So in this case, I would check that the highlight color is or isn't present in the screenshot, based on the active layer.

Yep that's the initial idea that came to mind when thinking about creating a new test for this. Should I try to implement a new test doing screenshots then or the test changes I did following the flag check idea are enough?

Personally I'd like to see such a test as it's more robust, but I think it can come in a follow-up PR. I'm gonna merge!


Properly handle multiple blocks with same name in a single file

If we declare a block with the same name, the normal behavior is to overwrite the previous definition with the latest one. That works if blocks are defined in separated files. But it did not work properly when blocks were declared in the same file.
I fixed this in the generic merge function, but that only worked if multiple blocks were declared in an included file but not for the main configuration file. So, I forced the main file to also go through the merge process (starting with an empty structure).
I also discovered a test no-tf-variable that was working even if it used the same block many times in the configuration. Fixing this problem caused that specific test to fail.
To ensure that we don't break existing configuration without being noticed, I added a warning when a block is overridden by another block with the same name in a file.

Pull Request Test Coverage Report for Build 701

69 of 109 (63.3%)  changed or added relevant lines in 11 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.7%) to 59.479%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

config/generated_hooks.go
13
14
92.86%

config/generated_extra_args.go
12
14
85.71%

config/generated_extra_command.go
11
14
78.57%

config/generated_import_files.go
11
14
78.57%

config/generated_import_variables.go
11
14
78.57%

config/extension_base_list.go
0
14
0.0%

config/generated_approval_config.go
0
14
0.0%

Totals

Change from base Build 699:
0.7%

Covered Lines:
3586

Relevant Lines:
6029

💛  - Coveralls


Implement "clear" method for collection handles

Note: implement in both - in-memory and firebase storage.

Did we add this, I forget? I feel like maybe we did. Or at least discussed sometime recently. Marking P2 since it seems we do want it at some point.

I believe this was done: https://github.com/PolymerLabs/arcs/pull/2029


[BEAM-8086] add isRetraciton() to WindowedValue.

We need a way to mark WindowedValue as a retraction. Current idea is we should separate sub-classes of WindowedValue without and with retraction flag to reduce the impact of enabling retractions. It is mostly because I plan to use Boolean as the flag of retraction so each instance of WindowedValue will have 8 bytes overhead if we don't have such a separation.
In the future, as the implementation of retraction work goes, I will probably add more sub-classes of WindowedValue which implements isRetraction(), and those will be used for retracting mode. Hopefully by doing so, we can limit the overhead of message metadata change on pipelines that enables retraction only.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Choose reviewer(s) and mention them in a comment (R: @username).
[x] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

An open question is if the default return value should be false than throwing an exception. It could be left to the future for clarification.

LATE/EARLY/... status is part of PaneInfo, would that be a better place?

@lukecwik Thanks for the idea. It reminds me that I actually got this suggestion in #9199 as well.
Let me compare PaneInfo with WindowedValue and I will summarize pros and cons for the further discussion.

I think, that PaneInfo and RetractionMode (let's say) are orthogonal. It is imaginable (at least in theory), that at fully general level there will be early retraction firings. That can happen at least with early firings on merging windows, because every merge with previously (early) fired data will have to be retracted.
I'd also suggest to convert the boolean isRetraction() to something returning and enum, because it is better extensible and is somehow more consistent with PaneInfo.


Create kyoto-msc.txt

Kyoto College of Medical Science has been added.

@MOTOTANI-Takayuki First stage of verification passed, official domain is kyoto-msc.jp as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

@MOTOTANI-Takayuki  Pull request merged. Thank you.


Multi-round conversation (InstructBLIP)

In multi-round conversation scenario, how does the InstructBLIP model encode the context in previous conversation rounds? Simply concatenating the previous-round conversations? My concern is the max_txt_len=128 may be easily exceeded. So how do you make the multi-round conversation demos (obviously longer than 128)?
BTW, what is the text_input made of in https://github.com/salesforce/LAVIS/tree/59273f651b9bffb193d1b12a235e909e9f826dda/projects/instructblip#instruction-tuning? Again, if it contains all the instructions and responses of previous rounds, the max_txt_len may be easily exceeded?

We simply concatenate the previous-round conversations. You may extend the maximum length of the LLM to encode more context information. For the Q-former's text_input, it is expected to contain the most informative context, which may or may not be the same as the text input to LLM.
Thanks.

Seems there is no difference between the text_input for LLM and the text_input for Q-former. They both tokenized samples['text_input'] or prompt. What do you mean by the difference here?

In our implementation, the text input to the LLM and Q-former is the same. However, you could also give different input. The text input to the Q-former serves as a condition for visual feature extraction. Please refer to our paper for details. Thanks.

In our implementation, the text input to the LLM and Q-former is the same. However, you could also give different input. The text input to the Q-former serves as a condition for visual feature extraction. Please refer to our paper for details. Thanks.

Hi, I would like to know if it would be helpful to include 'background' as an instruction word when working on the image caption task, as I want to describe the background of the image.


Cow: Watch (?-i:cellucare.australia)(?# facebook.com)

Cow requests the watch of the watch_keyword (?-i:cellucare\.australia)(?# facebook.com). See the MS search here and the Stack Exchange search in text, in URLs, and in code.

(?-i:cellucare\.australia)(?# facebook.com) has been seen in 1 true positive, 0 false positives, and 0 NAAs.


Redirect to intended room after logging in

Describe the bug
If you are not logged in and you click a link to the room it takes you to the login page after you login you are redirected to the dashboard page instead of the room page
To Reproduce
Steps to reproduce the behavior:

Click a link to room while not logged in
Login with GitHub or twitter
It redirects you to /dash instead of the link you originally clicked

Expected behavior
I was expecting to be redirected to the original link I clicked
What device are you on? Chrome Android 8 same thing also happens in win 10 latest chrome.

Changed your title to make it more clear 👍🏼


GPT-3.5?

Is there a way to make the package use GPT-3.5? Setting gpt-openai-engine to "gpt-3.5-turbo" (which appears to be the name of GPT-3.5 according to this page) does not work unfortunately.

FYI, this package was just released, which uses an Elisp library for the OpenAI API, so it may not be worth putting in the effort to update this one.

If we want to continue working on it (maybe as a simpler alternative to the chatgpt package @benthamite  mentioned), we could use the openai package that the chatgpt package depends on.

Implemented in a38c152


Can't make a master route for react/vue.js

Laravel Version
11.1
PHP Version
8.3
Database Driver & Version
No response
Description
I created a project in laravel 11.1 and I try to setup the react js in the project for the frontend. I've add the following snippet in my web.php
Route::get('/{all?} ', function(){     return view('app'); })->where('all', '. *');
But It doesn't work. Is still the way to configure routes. or something else.
Steps To Reproduce

Looks like there is a space in your where. Try changing . * to .*

Oh, you are right, it seems Iike I've added a space which prevents the route to be hit.
Thanks for you help


Logging login attempts

I wanted to write a fail2ban rule for node-red. After defining some users in adminAuth in reference to https://github.com/node-red/node-red/issues/539 I expected to see errors on failed login attempts in the syslog (and successful logins too). I configured
    logging: {
        console: {
            level: "debug",
            metrics: false,
            audit: true
        }
    },

Has failed login attempt logging been merged in the end? #539 has been closed, but there's no PR. Thanks lots...
Please tell us about your environment:

[ ] Node-RED version: 0.19.5
[ ] node.js version: v10.15.0
[ ] npm version: 6.4.1
[ ] Platform/OS: Ubuntu 18.04
[ ] Browser: n/a

Hi,
I've just checked 0.19.5, with audit: true set as you have it, I get the following type of event in the Node-RED log when I enter an incorrect password:
2 Jan 22:53:21 - [audit] {"event":"auth.login.fail.credentials","username":"admin","client":"node-red-editor","scope":"","level":98,"timestamp":1546469601808}

I see successful access log with IP address, i.e
May 04 11:01:15 homeassistant Node-RED[1518]: 4 May 11:01:15 - [audit] {"event":"library.get.all","type":"flow","level":98,"user":{"username":"admin","permissions":"*"},"path":"/library/flows","ip":"<IP_ADDRESS>, <IP_ADDRESS>","timestamp":1556992875846}
but failed access attempts don't log the originating IP address so I cant block the offender with fail2ban, is this string configurable or can we request to add IP address?
May 04 11:01:17 homeassistant Node-RED[1518]: 4 May 11:01:17 - [audit] {"event":"comms.auth","user":{"username":"admin","permissions":"*"},"level":98,"timestamp":1556992877375}

I have the same issue with version v0.20.5 running in docker.
The failed login gets logged, but without IP address
8 Jun 16:14:08 - [audit] {"event":"auth.login.fail.credentials","username":"georg80","client":"node-red-editor","scope":"","level":98,"timestamp":1560010448291}

success looks like this
8 Jun 18:42:04 - [audit] {"event":"auth.login","username":"georg90","client":"node-red-editor","scope":" *","level":98,"timestamp":1560019324406}

The IP is missing in both..
my logging settings
    logging: {
        // Only console logging is currently supported
        console: {
            // Level of logging to be recorded. Options are:
            // fatal - only those errors which make the application unusable should be recorded
            // error - record errors which are deemed fatal for a particular request + fatal errors
            // warn - record problems which are non fatal + errors + fatal errors
            // info - record information about the general running of the application + warn + error + fatal errors
            // debug - record information which is more verbose than info + info + warn + error + fatal errors
            // trace - record very detailed logging + debug + info + warn + error + fatal errors
            // off - turn off all logging (doesn't affect metrics or audit)
            level: "trace",
            // Whether or not to include metric events in the log output
            metrics: false,
            // Whether or not to include audit events in the log output
            audit: true
        }
    },

@917huB The log with IP is from the frontend or API?

If anyone stumbled on this from google like I did, there is a flood control at the user level in the application.
https://github.com/node-red/node-red/blob/e26eb85718e55c91a688a5309287e47354ad901d/packages/node_modules/%40node-red/editor-api/lib/auth/strategies.js#L61
I can verify that the above works after looking at my logs from starting the server via systemd...
Apr 08 11:55:16 NAS Node-RED-Server[24289]: 8 Apr 11:55:16 - [audit] {"event":"auth.login.fail.credentials","username":"homenodered","client":"node-red-editor","scope":"","level":98,"timestamp":
Apr 08 11:55:17 NAS Node-RED-Server[24289]: 8 Apr 11:55:17 - [audit] {"event":"auth.login.fail.credentials","username":"homenodered","client":"node-red-editor","scope":"","level":98,"timestamp":
Apr 08 11:55:18 NAS Node-RED-Server[24289]: 8 Apr 11:55:18 - [audit] {"event":"auth.login.fail.credentials","username":"homenodered","client":"node-red-editor","scope":"","level":98,"timestamp":
Apr 08 11:55:19 NAS Node-RED-Server[24289]: 8 Apr 11:55:19 - [audit] {"event":"auth.login.fail.credentials","username":"homenodered","client":"node-red-editor","scope":"","level":98,"timestamp":
Apr 08 11:55:20 NAS Node-RED-Server[24289]: 8 Apr 11:55:20 - [audit] {"event":"auth.login.fail.credentials","username":"homenodered","client":"node-red-editor","scope":"","level":98,"timestamp":
Apr 08 11:55:21 NAS Node-RED-Server[24289]: 8 Apr 11:55:21 - [audit] {"event":"auth.login.fail.too-many-attempts","username":"homenodered","client":"node-red-editor","level":98,"timestamp":15863
Apr 08 11:55:24 NAS Node-RED-Server[24289]: 8 Apr 11:55:24 - [audit] {"event":"auth.login.fail.too-many-attempts","username":"homenodered","client":"node-red-editor","level":98,"timestamp":15863
Apr 08 11:55:25 NAS Node-RED-Server[24289]: 8 Apr 11:55:25 - [audit] {"event":"auth.login.fail.too-many-attempts","username":"homenodered","client":"node-red-editor","level":98,"timestamp":15863
Apr 08 11:55:25 NAS Node-RED-Server[24289]: 8 Apr 11:55:25 - [audit] {"event":"auth.login.fail.too-many-attempts","username":"homenodered","client":"node-red-editor","level":98,"timestamp":15863
Apr 08 11:55:25 NAS Node-RED-Server[24289]: 8 Apr 11:55:25 - [audit] {"event":"auth.login.fail.too-many-attempts","username":"homenodered","client":"node-red-editor","level":98,"timestamp":15863
Apr 08 11:55:25 NAS Node-RED-Server[24289]: 8 Apr 11:55:25 - [audit] {"event":"auth.login.fail.too-many-attempts","username":"homenodered","client":"node-red-editor","level":98,"timestamp":15863
Apr 08 11:55:25 NAS Node-RED-Server[24289]: 8 Apr 11:55:25 - [audit] {"event":"auth.login.fail.too-many-attempts","username":"homenodered","client":"node-red-editor","level":98,"timestamp":15863
Apr 08 11:55:25 NAS Node-RED-Server[24289]: 8 Apr 11:55:25 - [audit] {"event":"auth.login.fail.too-many-attempts","username":"homenodered","client":"node-red-editor","level":98,"timestamp":15863
Apr 08 11:55:25 NAS Node-RED-Server[24289]: 8 Apr 11:55:25 - [audit] {"event":"auth.login.fail.too-many-attempts","username":"homenodered","client":"node-red-editor","level":98,"timestamp":15863
Apr 08 11:55:26 NAS Node-RED-Server[24289]: 8 Apr 11:55:26 - [audit] {"event":"auth.login.fail.too-many-attempts","username":"homenodered","client":"node-red-editor","level":98,"timestamp":15863
Apr 08 11:55:26 NAS Node-RED-Server[24289]: 8 Apr 11:55:26 - [audit] {"event":"auth.login.fail.too-many-attempts","username":"homenodered","client":"node-red-editor","level":98,"timestamp":15863
lines 455-493/493 (END)

I dont see an IP address included to the fail messaging that fail2ban can use to block the source address.

Correct, there is not one, but there is a flood control function built into the application's login flow, see the linked function.

@RNCTX's comment has prompted me to go look at the code over the last 10 minutes. I can see why the IP address isn't included, but I can also see getting it included will require some careful reworking of the error handling.
The audit message is currently being logged at the point we identify the password is incorrect. But at that point of the code we have no reference to the http request itself, only the credential data being provided. The audit message is logged and then a generic rejection error is passed back up the stack so the request can be refused.
We will need to change it around so the error contains more details on the failure type, so the event can be logged at a point where we know the IP address.  But we need to be very careful to ensure that change in error message doesn't change any other behaviours looked for the existing error.

Thank you for taking a look. If you do take a look at adding the originating IP address to the logging, can I also ask you consider those folks may be running node-red behind a nginx or similar proxy and to consider the implications of $proxy_add_x_forwarded_for headers etc.

X-Forwarded-For is recorded properly where IPs are recorded, I verified that when testing the above as well.
I'm running inside-out to a fully qualified subdomain.  My internal IP is <IP_ADDRESS>, and the reverse proxy is my router at <IP_ADDRESS>...
server {
    listen 443;
    server_name nodered.mydomain.net;
    include /opt/etc/nginx/ssl.conf;
    error_log syslog:server=<IP_ADDRESS>,tag=nginx_home;
    access_log syslog:server=<IP_ADDRESS>,tag=nginx_home,severity=notice combined;
    proxy_buffering off;

    location / {
      proxy_pass http://<IP_ADDRESS>:1880;
      proxy_http_version 1.1;
      proxy_set_header Upgrade $http_upgrade;
      proxy_set_header Connection "upgrade";
      proxy_set_header X-Forwarded-For $remote_addr;
    }
  }
}

With x-forwarded-for set to remotte addr:
8 Apr 12:06:30 - [audit] {"event":"nodes.list.get","level":98,"user":{"username":"nodereduser","permissions":"*"},"path":"/nodes","ip":"<IP_ADDRESS>","timestamp":1586365590354}

Without x-forwarded-for set:
8 Apr 11:55:11 - [audit] {"event":"auth.login.revoke","level":98,"user":{"username":"nodereduser","permissions":"*"},"path":"/auth/revoke","ip":"<IP_ADDRESS>","timestamp":1586364911563}

I'm running NodeRed 2.2.2 and I'm having the same missing feature.
I would like to secure my server with fail2ban but the log still not show any IP address :
2 Jul 15:42:41 - [audit] {"event":"auth.login.fail.credentials","username":"xxx@yyy.fr","client":"node-red-editor","scope":"","level":98,"timestamp":1656769361308}
Does someone has a patch for this ? is this scheduled to be put into version 3 of NodeRed ?

@ClementToche The problem is that at the point we know the wrong password has been provided we are deep in a PassportJS callback stack and don't have access to the requesting IP address.
https://github.com/node-red/node-red/blob/f760354e821c464295285651b38d0acdcdc1443d/packages/node_modules/%40node-red/editor-api/lib/auth/strategies.js#L110

@hardillb, Thanks for answering and I see the problem.
Another solution would be to print 2 traces, 1 when a client connect to the server web front-end and 1 when credentials fails.
Fail2Ban is able to parse 2 lines and I can easily make a regex in this way.
To give an example, mosquitto (MQTT open source server) print those 2 lines :
New connection from <IP_ADDRESS>:6565 on port 8883 Client <unknown> disconnected, not authorised.
First line would be printed by the web server front-end when new client connects.
And second line would be printed as already developed in NodeRed code.
Of course, this is not a perfect solution for big server that could have 2 user connection at the very same time but this is for sure enough for personal server at home for which a little bit of security can be added.
Do you think it is something feasible ?

Hello Node-RED team.
I would like to raise that up on top of the list since it's a very old request.
Node-RED is a very good tool that can be used for many stuff in a professional grade way but it really need the same level of quality for security requirement and this is really needed to make DDoS attack protection in place for this tool.
Is there is any chance it can come on top of the new major 3.X version ?
Thanks.

@ClementToche I will take another look to see how we can get the required information surfaced. As was said in previous comments, there are some architectural difficulties in getting the information in the right place so it can be logged at the right time.


License(s)?

Hi! I noticed this repo doesn't have a LICENSE file.
Under which license(s) is this offered (if any)?

I created this project to learn how connect to IoT Hub using MQTT. Happy if this helps to anyone.
https://github.com/ridomin/iothub-webclient/commit/96a3a54c84c022fa0fc16e0a6f5651984272f474 adds a MIT License
Thanks !!
Rido

We have found this very helpful. Thank you for the license addition!


DynamicStringProperty does not interpolate variables on update

Ran some tests with this recently to verify some assumptions. Glad that I did. Here's my testing code and properties:
public class ArchaiusTest {
	public static final String KEY = "test.message";
	public static final String DEFAULT = "No Message Found";

	public static void main(String[] args) throws Exception
	{
		DynamicStringProperty message
				= DynamicPropertyFactory.getInstance().getStringProperty(KEY, DEFAULT);

		Configuration configuration = ConfigurationManager.getConfigInstance();

		while (true)
		{
			System.out.println("dynamic : " + message.get());
			System.out.println("config  : " + configuration.getString(KEY, DEFAULT));
			TimeUnit.SECONDS.sleep(30);
		}
	}
}

And the properties file that I'm using :
message.default=default
message.new=new

test.message=This is the ${message.default} message

If I launch the process, the two outputs are the same. If I change the message.default property to be something else (lets say "old"), the dynamic property will remain as "default", but the Configuration object will correctly update the variable interpolation to use "old" in the place holder.
Also, if I completely change the variable (lets say to message.new) the dynamic property picks up the raw, un-interpolated variable name, but the configuration object correctly interpolates the value.
I've posted the program output. *Text surrounded by asterisks are my interactions with the environment*

* Start Program *
SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
dynamic : This is the default message
config  : This is the default message
* Update configuration - 'message.default=old' *
dynamic : This is the default message
config  : This is the default message
dynamic : This is the default message
config  : This is the default message
* Program picks up updated configuration *
dynamic : This is the default message
config  : This is the old message
dynamic : This is the default message
config  : This is the old message
* Update configuration - 'test.message=This is the ${message.new} message' *
dynamic : This is the default message
config  : This is the old message
dynamic : This is the default message
config  : This is the old message
* Program picks up updated configuration *
dynamic : This is the ${message.new} message
config  : This is the new message
* Kill Program *
Process finished with exit code 137

Is this expected behavior?

Closing this for now since there's been no traction for a while now.


How to Use a List as an input to sum_overlay command

Hi.  I have 100 rasters that I'm trying to sum together.  I generated a list with the os.listdir command but the Whitebox tool sum_overlay doesn't seem to like the format of the list.
The list is like this ['cost_pathway_1.tif', 'cost_pathway_2.tif', 'cost_pathway_3.tif']
but Whitebox wants this 'cost_pathway_1.tif';cost_pathway_2.tif';cost_pathway_3.tif'
Do I just need to reformat the list with python or is there any way that Whitebox will read the list as is?
In my example, I hard coded three of the inputs so I know it works this way, but I would like to pass the list which is called cost_pathway_files.
Thanks in advance.
Here's my code:
import tools from WBT module
from WBT.whitebox_tools import WhiteboxTools
import os
declare a name for the tools
wbt = WhiteboxTools()
Set the Whitebox working directory
You will need to change this to your local path name
set the output folder if different
out_dir = "D:/Permeability_model/Hinesburg"
wbt.work_dir = "C:/Users/whegman/OneDrive - Middlebury College/White_Box/testData"
define an output file name
cost_pathway_summed = os.path.join(out_dir,f'cost_pathway_summed.tif')
to find all files that are cost_pathway_....tif we will use os package
all_output_files = os.listdir(out_dir)
cost_pathway_files = [file for file in all_output_files if "cost_pathway_" in file and file.endswith('.tif')]
print (cost_pathway_files)
run the sum_overlay tool to combine all 100 cost pathway rasters
wbt.work_dir = out_dir
wbt.sum_overlay(
'cost_pathway_1.tif;cost_pathway_2.tif;cost_pathway_3.tif',
cost_pathway_summed
)

You can use “;”.join(cost_pathway_files) to convert the list to a string.
On Mon, Jan 10, 2022 at 4:25 PM bhegman @.***> wrote:

Hi. I have 100 rasters that I'm trying to sum together. I generated a list
with the os.listdir command but the Whitebox tool sum_overlay doesn't seem
to like the format of the list.
The list is like this ['cost_pathway_1.tif', 'cost_pathway_2.tif',
'cost_pathway_3.tif']
but Whitebox wants this
'cost_pathway_1.tif';cost_pathway_2.tif';cost_pathway_3.tif'
Do I just need to reformat the list with python or is there any way that
Whitebox will read the list as is?
In my example, I hard coded three of the inputs so I know it works this
way, but I would like to pass the list which is called cost_pathway_files.
Thanks in advance.
Here's my code:
import tools from WBT module
from WBT.whitebox_tools import WhiteboxTools
import os
declare a name for the tools
wbt = WhiteboxTools()
Set the Whitebox working directory You will need to change this to your
local path name set the output folder if different
out_dir = "D:/Permeability_model/Hinesburg"
wbt.work_dir = "C:/Users/whegman/OneDrive - Middlebury
College/White_Box/testData"
define an output file name
cost_pathway_summed = os.path.join(out_dir,f'cost_pathway_summed.tif')
to find all files that are cost_pathway_....tif we will use os package
all_output_files = os.listdir(out_dir)
cost_pathway_files = [file for file in all_output_files if "cost_pathway_"
in file and file.endswith('.tif')]
print (cost_pathway_files)
run the sum_overlay tool to combine all 100 cost pathway rasters
wbt.work_dir = out_dir
wbt.sum_overlay(
'cost_pathway_1.tif;cost_pathway_2.tif;cost_pathway_3.tif',
cost_pathway_summed
)
—
Reply to this email directly, view it on GitHub
https://github.com/jblindsay/whitebox-tools/issues/218, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABGIXBI62XOZK66GGN2VT2DUVNFDVANCNFSM5LUV4BSA
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


Backup doesn't work

I tried to use backup and it doesn't work.
OS version <IP_ADDRESS> (not officially released)
Storeman version: 0.0.15 & 0.0.16 RC
Backup option is not active.

Backup functionality is temporarily removed. I'll reenable it in next release.


Unhandled Exception on flutter web first run

Unhandled exception:
FormatException: Unexpected character (at character 1)
Not Found
^

#0      _ChunkedJsonParser.fail  (dart:convert-patch/convert_patch.dart:1392:5)
#1      _ChunkedJsonParser.parseNumber  (dart:convert-patch/convert_patch.dart:1259:9)
#2      _ChunkedJsonParser.parse  (dart:convert-patch/convert_patch.dart:924:22)
#3      _parseJson  (dart:convert-patch/convert_patch.dart:29:10)
#4      JsonDecoder.convert  (dart:convert/json.dart:493:36)
#5      JsonCodec.decode  (dart:convert/json.dart:151:41)
#6      jsonDecode  (dart:convert/json.dart:94:10)
#7      parse
package:source_maps/parser.dart:27
#8      Sources.scriptParsed  (package:dwds/src/debugging/sources.dart:55:19)
 <asynchronous suspension>
#9      _RootZone.runUnaryGuarded  (dart:async/zone.dart:1314:10)
#10     CastStreamSubscription._onData  (dart:_internal/async_cast.dart:81:11)
#11     _RootZone.runUnaryGuarded  (dart:async/zone.dart:1314:10)
#12     _BufferingStreamSubscription._sendData  (dart:async/stream_impl.dart:336:11)
#13     _BufferingStreamSubscription._add  (dart:async/stream_impl.dart:263:7)
#14     _SinkTransformerStreamSubscription._add  (dart:async/stream_transformers.dart:68:11)
#15     _EventSinkWrapper.add  (dart:async/stream_transformers.dart:15:11)
#16     WipDomain.eventStream.<anonymous closure>.<anonymous closure>
(package:webkit_inspection_protocol/webkit_inspection_protocol.dart:301:26)
#17     _HandlerEventSink.add  (dart:async/stream_transformers.dart:228:7)
#18     _SinkTransformerStreamSubscription._handleData
(dart:async/stream_transformers.dart:120:24)
#19     _RootZone.runUnaryGuarded  (dart:async/zone.dart:1314:10)
#20     _BufferingStreamSubscription._sendData  (dart:async/stream_impl.dart:336:11)
#21     _DelayedData.perform  (dart:async/stream_impl.dart:591:14)
#22     _StreamImplEvents.handleNext  (dart:async/stream_impl.dart:707:11)
#23     _PendingEvents.schedule.<anonymous closure>  (dart:async/stream_impl.dart:667:7)
#24     _microtaskLoop  (dart:async/schedule_microtask.dart:41:21)
#25     _startMicrotaskLoop  (dart:async/schedule_microtask.dart:50:5)
#26     _runPendingImmediateCallback  (dart:isolate-patch/isolate_patch.dart:116:13)
#27     _RawReceivePortImpl._handleMessage  (dart:isolate-patch/isolate_patch.dart:173:5)

cc @jonahwilliams

Issues is tracked https://github.com/dart-lang/webdev/issues/514

Looks like this was fixed in https://github.com/dart-lang/webdev/issues/514. @jakemac53 could you do a release of dwds soon so we can pick it up?

We are almost ready for a release, waiting for a resolution on https://github.com/flutter/devtools/issues/918

@jonahwilliams - the fixed is landed, but we need a new dwds rolled in?

Yes, we're not able to roll in dwds because the devtools dependency is tightly constrained by mockito: https://github.com/flutter/devtools/pull/923

@jonahwilliams - the devtools issue appears closed.  Anything more to do here?

We need a new release of devtools/dwds

@jacob314 @grouma - can we do another release of the above?

I think we are blocked by this if I'm not mistaken: https://github.com/dart-lang/webdev/pull/600
@devoncarew is looking to do a new release then we can publish a new version of dwds.

@grouma do you know the status here, is this confirmed fixed and released?

I did a publish of DWDS last week so this should be resolved.

Ok, I am going to close this then as it should be resolved


fpga network stack code synthesize but not compile.

Hi,
We were able to synthesize the fpga network stack code. But when we tried to do the CSimulation, we found compile issues with toe_tb.cpp, toe.cpp and toe.hpp. We have concern that if this code is recently tested and have complete implementation. Has anyone tested generated bitstream on vc709 successfully ?
thanks and regards,
Ishtiyaque

I haven't recently tested the code on vc709, but i am regulary using the vcu118 and the alpha data. If you run into any issues on the vc709 please report them here. Thanks David
C-simulation is out-dated and has to be updated, in case you manage to do this please create a pull request.

Hi,
I've succesfully generated and tested the project on the VC709 board. I'm using Vivado version 2018.3 which required a few minor changes to the code. You can find the code I compiled at https://github.com/GustavSVJ/fpga-network-stack.
Hope this helps,
Gustav


Can't install<EMAIL_ADDRESS>on mac

Does anyone face this problem? Please help

Thank you @xtkoba
Last time I used to face the problem with the installation of OpenSSL and also opened issue.
I already consulted with Homebrew official repository. I found a new merge request https://github.com/Homebrew/homebrew-core/pull/85812

Marking as inactive, to be closed at the end of 3.4 dev barring further input


GROOVY-7995: @CS short syntax closure call from closure

Short syntax of closure call invokes wrong closure if wrapped in another
closure. This fix includes a combination of the contributed commit from
PR #460 along with the patch (see PR comments) provided by Jochen.

+1


[netcdf-c] Update to 4.9.2

Fixes #32942, update netcdf-c to 4.9.2.

[x] Changes comply with the maintainer guide
[x] SHA512s are updated for each updated download
[ ] The "supports" clause reflects platforms that may be fixed by this new version
[ ] Any fixed CI baseline entries are removed from that file.
[ ] Any patches that are no longer applied are deleted from the port's directory.
[x] The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
[x] Only one version is added to each modified port's versions file.

@MonicaLiu0311 can u also update the netcdf-cxx4 to 4.3.1?

@MonicaLiu0311 can u also update the netcdf-cxx4 to 4.3.1?

I will continue it next week.

@MonicaLiu0311 can u also update the netcdf-cxx4 to 4.3.1?

I will continue it next week.

@MonicaLiu0311 any news?

Dupliacte of #35230.


Add brand.yml

https://github.com/posit-dev/brand-yml/issues/53
Noting from the issue that NHS England does not cover the other Nations in their branding. NHS-R Community uses NHS England branding but we often use the least used colours (the pinks and greens for example).

@send2dan my interest (and ultimately control) is for NHS-R Community branding as I'm unsure how NHS England feel about their details or branding being used if we submit on their behalf. NHS-R uses the colours under the copyright agreement https://www.nationalarchives.gov.uk/doc/open-government-licence/version/3/ so you can get the same England NHS colours and avoids the assumption that NHS England have approved this submission. It might be that they are fine with this but this needs to be checked and could cause undue delays.

OK, so are you simply proposing that the outcome of https://github.com/posit-dev/brand-yml/issues/53 could be hosted at https://github.com/nhs-r-community/assets?

Sorry, I've just realised I've effectively tagged the original issue by referencing it and that's slightly out of context.
This is an issue that I'll use to reference in this repo the NHS-R Community brand.yml and then I'll do a PR to the posit-dev repo for the Gallery on behalf of NHS-R Community which uses the NHS England colour branding.


modified updatePosition function to support Undo feature, added test case for TestUndo

The original Undo implementation failed to revert the game status if the lastmove leads to a result of the game. I modified updatePosition to handle this issue and added a test case in TestUndo to illustrate how the original implementation might fail.

The original Undo implementation failed to revert the game status if the lastmove leads to a result of the game. I modified updatePosition to handle this issue and added a test case in TestUndo to illustrate how the original implementation might fail.

Thanks. Looks good to me now. I will update the original PR.


Server stack remove: GridServices::Stop: can't modify frozen BSON::Document (RuntimeError)

Shows up in the #2699 logging when removing a stack, which tries to stop the stack services. Not entirely sure what the frozen BSON::Document is, but I'm guessing this is from the StackRemoveWorker#stop_stack -> GridServices::Stop#execute async_thread do grid_service.set_state('stopped') racing with the StackRemoveWorker#remove_stack -> GridServices::Delete#execute grid_service.destroy. The async stop thread is trying to mutate the the GridService after it has been destroyed by the main thread.
<IP_ADDRESS> - - [07/Sep/2017:11:10:03 +0000] "DELETE /v1/stacks/development/test HTTP/1.1" 200 2 0.1173
E, [2017-09-07T11:10:03.573530 #21] ERROR -- GridServices::Stop: can't modify frozen BSON::Document (RuntimeError)
/usr/lib/ruby/gems/2.4.0/gems/bson-4.2.1/lib/bson/document.rb:68:in `[]='
/usr/lib/ruby/gems/2.4.0/gems/bson-4.2.1/lib/bson/document.rb:68:in `[]='
/usr/lib/ruby/gems/2.4.0/gems/mongoid-5.2.1/lib/mongoid/attributes.rb:182:in `block in write_attribute'
/usr/lib/ruby/gems/2.4.0/gems/mongoid-5.2.1/lib/mongoid/threaded/lifecycle.rb:31:in `_assigning'
/usr/lib/ruby/gems/2.4.0/gems/mongoid-5.2.1/lib/mongoid/attributes.rb:170:in `write_attribute'
/usr/lib/ruby/gems/2.4.0/gems/mongoid-5.2.1/lib/mongoid/fields.rb:462:in `block (2 levels) in create_field_setter'
/usr/lib/ruby/gems/2.4.0/gems/mongoid-5.2.1/lib/mongoid/attributes/processing.rb:100:in `process_attribute'
/usr/lib/ruby/gems/2.4.0/gems/mongoid-5.2.1/lib/mongoid/persistable/settable.rb:34:in `block (2 levels) in set'
/usr/lib/ruby/gems/2.4.0/gems/mongoid-5.2.1/lib/mongoid/persistable.rb:172:in `block in process_atomic_operations'
/usr/lib/ruby/gems/2.4.0/gems/mongoid-5.2.1/lib/mongoid/persistable.rb:167:in `each'
/usr/lib/ruby/gems/2.4.0/gems/mongoid-5.2.1/lib/mongoid/persistable.rb:167:in `process_atomic_operations'
/usr/lib/ruby/gems/2.4.0/gems/mongoid-5.2.1/lib/mongoid/persistable/settable.rb:24:in `block in set'
/usr/lib/ruby/gems/2.4.0/gems/mongoid-5.2.1/lib/mongoid/persistable.rb:145:in `prepare_atomic_operation'
/usr/lib/ruby/gems/2.4.0/gems/mongoid-5.2.1/lib/mongoid/persistable/settable.rb:23:in `set'
/app/app/models/grid_service.rb:105:in `set_state'
/app/app/mutations/grid_services/stop.rb:16:in `rescue in block in execute'
/app/app/mutations/grid_services/stop.rb:12:in `block in execute'
/app/app/helpers/async_helper.rb:11:in `block in async_thread'

Yes, Mongoid::Document#destroy calls #delete -> #prepare_delete, which freezes the document after it's been deleted.
It doesn't make sense to trigger the async stop mutation for the stack services right before destroying them. With the async stop, the agents would need to pull the updated service instances before they get destroyed, which is highly unlikely to happen.


Adding .npmignore file

@substack Apparently this module is quite popular with other NPM authors. I have 202 copies of "In Praise of Idleness" by Bertrand Russell on my computer 😃

You can also add .npmignore to the file itself.

This would be great. @substack - Any chance to get this change merged?

+1

+1 will free up a lot of collective disk space across the world

keep it
everyone could use a reminder to enjoy their leisure time

+1

So I created a PR before checking all the comments here, whoops. Anyway I see that some were keen to have the example folder retained so, I've created a new PR here that just excludes test: https://github.com/substack/node-wordwrap/pull/18 If its not at all helpful let me know.

Is this going to be merged @substack?

Pretty small though:
$ curl -sS https://registry.npmjs.org/wordwrap/-/wordwrap-1.0.0.tgz | wc -c
14509

Generally speaking, I prefer to include tests and examples in packages. Github won't be around forever and it's handy to have tests and examples while working offline.

Github won't be around forever

I mean, that's one of the reasons the code is in a Git repo, right? The entire purpose of Git is that it's decentralised.
Also, I feel like Github will outlive npm :)


Remove TextEntity By Drag & Drop

Hey UptechTeam, Hope you are doing well.
Currently, I am using this MotionViews-Android Library in my project. To delete an entity from motionview "motionView.deletedSelectedEntity()" method is called to delete it. But, I get stuck on one mechanism that, I want to delete an entity by dragging it & dropping it on an imageview. I didn't get any position or method to do it.
How can I apply delete(by drag & drop) to this code?
Any help will be appreciable. Thanks in advance.

Hello @nikhil94090 . Currently, there's no such functionality. You need to implement it yourself.

Okk Thanks, But can you help me to figure out where should I get the drop event of the TextEntity. As I tried it myself all time I get is just nullpointer exception due to no textentity found at the time of release().

Nope, sorry, cannot help, it's a very specific request.


Update dockerfile to use npm ci for slightly faster builds

Updates npm version to 5.7.1 to use npm ci
Time Taken for installing packages for this project
npm install 14.185s
npm ci  9.934s
More details about npm ci

@rvgpl Why is this still here?

Forgot about this. @gja Please review.

@gja Even if I upgrade to node 8.11, I would still need to update npm. Node 8.11 comes with 5.6.0 https://nodejs.org/en/download/releases/


added Karmayogi Competency Passbook project

Project
Karmayogi-Competency Passbook for Officials
Changes
added Karmayogi Competency Passbook project

Add bullet point in contact info


AutoScaling group in web stack fails to launch, PHP55 not avialable

Currently, it does not seem to be possible to launch the "Web" stack. The Auto Scaling Group resource, with logical ID "WebAutoScalingGroup" will fail to create with an error stating that 0 Success signals were received from the generated instances
====
Received 0 SUCCESS signal(s) out of 2. Unable to satisfy 100% MinSuccessfulInstancesPercent requirement
Taking a look at the console logs of one of the generated instances, I see that the "php55-pear" package is not available for installation, failing the run.
+ /opt/aws/bin/cfn-init --configsets deploy_webserver --verbose --stack WordPress1-web-PPL1N99D78WX --resource WebLaunchConfiguration55 --region us-east-1
Error occurred during build: Yum does not have php55-pear available for installation
Sep 26 03:15:03 cloud-init[2439]: util.py[WARNING]: Failed running /var/lib/cloud/instance/scripts/part-001 [1]
Sep 26 03:15:03 cloud-init[2439]: cc_scripts_user.py[WARNING]: Failed to run module scripts-user (scripts in /var/lib/cloud/instance/scripts)
Sep 26 03:15:03 cloud-init[2439]: util.py[WARNING]: Running module scripts-user (<module 'cloudinit.config.cc_scripts_user' from '/usr/lib/python2.7/dist-packages/cloudinit/config/cc_scripts_user.pyc'>) failed

Checking the CloudFormation template, I see that there are 3 different versions available of php (php55, php56, and php70). I tried installing each of this packages on a stand alone EC 2 instance, and found that none of them are available.

[root@ip-xxx-xx-xx-xxx ec2-user]# yum install php55
Loaded plugins: extras_suggestions, langpacks, priorities, update-motd
No package php55 available.
Error: Nothing to do

[root@ip-xxx-xx-xx-xxx ec2-user]# yum install php56
Loaded plugins: extras_suggestions, langpacks, priorities, update-motd
No package php56 available.
Error: Nothing to do

[root@ip-xxx-xx-xx-xxx ec2-user]# yum install php70
Loaded plugins: extras_suggestions, langpacks, priorities, update-motd
No package php70 available.
Error: Nothing to do

So, there are several related problems to this. After digging into the template, it looks like someone changed the available PHP versions to:
PHPVersion:
    AllowedValues:
    - 8.1
    - 8.0
    - 7.4
    Default: 8.1
    Description: The version of PHP to install.
    Type: String

But, they didn't change any of corresponding launch configurations. The only change that actually happened is:
 PHP55:
    !Equals [ 8.1, !Ref PHPVersion ]
  PHP56:
    !Equals [ 8.0, !Ref PHPVersion ]
  PHP70:
    !Equals [ 7.4, !Ref PHPVersion ]

This then obviously causes a parameter value of 8.1 to deploy the PHP 5.5 Launch Configuration.