Validators for tender and tender document views

This change is

Coverage increased (+0.1%) to 89.92% when pulling e9c2fcf367b1479ee702a696cae0a6a379b88ce9 on annawzz:a289368434081969_validators into 6323d1401bcb23d5dae604ad2a58f149b05bb9ad on openprocurement:a258001251842882_refactoring.


Closing, this didnt fix the rate limit


AAD-GRB has link to SFPU Communications, Remove or Replace?

link to SFPU Communications, https://www.youtube.com/user/SFPUCcommunications

remove


Cannot visit the material ui website

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Current behavior 😯
I know this is not related directly to material ui but this has become quite an annoyance.
A while ago I remember I was playing around with the setting the global theme and whatnot on the material ui website ( I believe where you can enable dark mode ) and ever since then I have had this error and have been unable to visit the guides without crashing unless I open in an incognito browser.

I have tried to do a empty cache/hard reset through developer mode but have had no luck.
Expected behavior 🤔
Not crash
Steps to reproduce 🕹
Steps:

Change theme to dark mode on material ui website?
Get error about type

Context 🔦
I was setting the type and got this error and have been unable to use the website without incognito mode
Your environment 🌎

`npx @mui/envinfo`
I am using    Edge: Spartan (44.22000.120.0)
```
npx: installed 2 in 2.213s
System:
OS: Windows 10 10.0.22000
Binaries:
Node: 14.17.2 - C:\Applications\nodejs\node.EXE
Yarn: 1.22.17 - ~\AppData\Roaming\npm\yarn.CMD
npm: 6.14.13 - C:\Applications\nodejs\npm.CMD
Browsers:
Chrome: Not Found
Edge: Spartan (44.22000.120.0), Chromium (96.0.1054.62)
npmPackages:
@mui/base:  5.0.0-alpha.62
@mui/material:  5.2.6
@mui/private-theming:  5.2.3
@mui/styled-engine:  5.2.6
@mui/system:  5.2.6
@mui/types:  7.1.0
@mui/utils:  5.2.3
@mui/x-data-grid:  5.2.1
@types/react:  17.0.38
</details>

Duplicate of #30343

Unless it's a duplicate of #30304 and the issue is with the sw.js that fail to reinstall.


Use release version of deps

What is the goal of this PR?
Update to the latest release of all graknlabs dependencies.
What are the changes implemented in this PR?

Updated all graknlabs dependencies to their latest release.

What's the status of this? Does it need any help?


control-service: use full url for heartbeat tests and heartbeat tests run in multiple namespaces

Why
We want to catch regressions in control plane if they are related to using the wrong namespace.
What
We now use different namespace for deployment and control.
How was this tested?
on a previous commit I enabled heartbeat steps and everything ran well.

Maybe we can use the public one https://iaclqhm5xk.execute-api.us-west-1.amazonaws.com ?
Added benefit some tests can run in the gitlab.com runners (instead of ours) .
I've been wanting to run vdk-hearbeat on windows for example.

Maybe we can use the public one https://iaclqhm5xk.execute-api.us-west-1.amazonaws.com ?
Added benefit some tests can run in the gitlab.com runners (instead of ours) . I've been wanting to run vdk-hearbeat on windows for example.
The downside may be that if Control Service is re-created (deleted and created) the Load Balanced domain name would change and one need to manually update the API gateway (https://github.com/vmware/versatile-data-kit/wiki/Gitlab-CICD#api-gateway)

@tozka  I don't agree with using the external url its needless IO on the network and not the pattern we should encourage.

@tozka I don't agree with using the external url its needless IO on the network and not the pattern we should encourage.

You make a valid point, when it comes to jobs deployed / jobs runnning on the cloud ("cloud jobs").
Let me clarify the difference between local command runs and cloud runs.

Local command runs refer to executing jobs or other CLI commands on the local machine of the user, where the vdk is run on the same system where it's stored.
On the other hand, cloud runs involve deploying and executing jobs on a cloud-based platform (VDK Kubernetes runtime)

For cloud jobs, indeed, minimizing unnecessary network I/O by avoiding external URLs is a more efficient approach as it reduces unnecessary network traffic and latency and instability.
However  vdk-heartbeat is designed to verify local CLI (Command Line Interface) commands and simulate how user users VDK. For that case, it might be beneficial to use the external URL. The rationale behind this is that these tests simulate the conditions under which end-users would be interacting with our application. Typically, these users would be accessing our services via the external URL. Therefore, using the external URL in tests helps ensure that we're accurately replicating and testing the user experience.
As part of its test vdk-heartbeat also deploys a job and remotely executes it. And also prints the logs of that remote execution. That remote execution likely would use CONTROL_SERVICE_URL that is internal because it's part of the "cloud" but the rest of the vdk-heartbeat which runs commands outside of the cloud should use external address

@tozka I am only coming back to this PR now.
I am setting the URL only in ini files which are used internally? Where in this PR do you want me to use the full external URL?

I forgot what was the problem being fixed here? Does it still exists? (perhaps update PR description?)

@murphp15 Will this affect the frontend deployment in any way?
https://github.com/vmware/versatile-data-kit/blob/main/projects/frontend/cicd/.gitlab-ci.yml#L201
https://github.com/vmware/versatile-data-kit/blob/main/projects/frontend/cicd/ping_frontend_heartbeat_config.ini#L5

@DeltaMichael  it won't effect the frontend in anyway because deployments never make requests to the frontend.


Popup window invisible after disconnecting second screen

I often switch between working with both the laptop screen and an external screen, and just the laptop screen. If I try to use Quicksilver without the external screen, the popup is not visible. It seems it tries to show on the external screen that is not connected at that moment. If I just blindly type what I want to start it does work.
Using Quicksilver 1.4.2 and OSX 10.11.5

Which interface are you using?
If you don’t know, you can check under Preferences → Appearance.

I am using Primer built-in.

OK, I can see how this would happen. Primer is one (maybe the only one) that remembers its position after you move it around. It needs to somehow check that the coordinates still exist before it appears.
In the meantime, you’ll need to make sure it’s on the laptop screen before disconnecting the other, or try another interface. Most of them will automatically appear on whichever screen has the active window. Give the other built-in interface (Bezel) a try. If you like the wide style of Primer that lets you see more text, install and try Nostromo. (You can install other interfaces from the Plugin prefs.)

I think I have a fix for that one (IIRC, there's an override in QSWindow that helpfully blindly accept whatever frame is used, which prevents the default AppKit screen-bound checking of taking place).


Autonomous Production Support

Add autonomous production support capability to the system.  Specifically, introduce a new operations service which monitors system capabilities, such as the microservices, repositories, and API gateway.
Due to the nature of this feature, a reactive system approach is applicable.  Encoding decision support rules normally required of an SRE will be done with Drools.
Percepts related to this effort include:

[ ] Service heartbeat monitoring
[ ] Service metrics interpretation
[ ] System log interpretation
[ ] System event monitoring
[ ] API gateway monitoring

When deemed applicable based on observed facts and support rules, actionable recommendations must be emitted.  A departure from the "observation-then-recommendation" pattern is when Kafka is observed to be offline.  In this case, the service must operate in "emergency mode" and act to shut down the system.

Due to the intricacy of this enhancement, work is planned to be introduced to master in multiple atomic feature enhancement branches.  Each will be documented with a comment added to this issue.
Once the new service is deemed feature complete, this ticket can be closed.

Refactored to introduce support for multi-repository system development with PR #18


Ubuntu Shell Hangs and Doesn't start on Windows 10 1709

Upgraded from Build 1607 to 1709, and installed Ubuntu from app store.  Ubuntu shell just hangs at launch:

Get the following error after a period of time:

I see this error in the system logs:
The LxssManager service terminated with the following error:
Windows cannot verify the digital signature for this file. A recent hardware or software change might have installed a file that is signed incorrectly or damaged, or that might be malicious software from an unknown source.
Any help would be appreciated.

Did you change the LxssManage.dll file in System32\lxss folder?

Did you change the LxssManager.dll or LxssManagerProxy.dll file in System32\lxss folder?

Windows cannot verify the digital signature for this file. A recent hardware or software change might have installed a file that is signed incorrectly or damaged, or that might be malicious software from an unknown source.

Last time I had this error, it was for a different Win32 program and the issue was with Trusted Installer (I had removed Trusted Installer from my ACLs, painful lesson learned that day. )This was on Windows 8.1 mind you, but nothing really changed regarding Trusted Installer with Win 10. Try uninstalling Ubuntu, restarting the Windows Module Installer service (if it's running), otherwise start it and see if an error appears. If it does, it will probably affect other Win32 programs as well. What's odd is Trusted Installer shouldn't of had any issues when upgrading versions. The issue may be a corrupt image from when you downloaded the new version. It may simply just be easier to revert back from backup to 1607 and use the Windows Media Creation tool to download and install 1709 (vice using Windows Updates). If that fails, then there's always the option to download the .iso file directly and manually install (you're able to mount .iso in Win 10 without third party apps.) At this point though, if you're doing this much work, you might as well wait for 1803 to come up in a couple weeks and upgrade to that and see if it has the same issue.

@Biswa96 I made no changes to the DLL myself.
@DarthSpock I would try this approach, the issue I have with that though is that this machine happens to be a company managed machine, therefore I don't really have the means to reimage the machine myself.

@DarthSpock tried your recommendation, but still have the same issue.  I guess I will have to look at getting my machine re-imaged, but that is going to take awhile.  I appreciate the help.

Ah yes painful. A re-image will do the trick if you can verify the image is clean. I'd hate for you to go through that, only to find out the image used was corrupt.

Will a factory default kick me off the company domain?  That is the pain when dealing with company machines...but yes I do have admin privs on the machine.

Can you run bash.exe or wsl.exe from command prompt? Or open service manager (services.msc) and try to start LxssManager service.

Nope.  Both bash.exe and wsl.exe just hang, and if I attempt to run the LxssManager service, I get the following error:

@donwlewis - Yeah unfortunately looks like something corrupted your LxssManager.dll file.  Have you tried adding and removing the optional component?

I'm definitely sure that your DLL files may be changed.
I've some dangerous steps to solve this issue. Beware of these steps. First backup System32\lxss folder. Take ownership of that folder. Search LxssManager.dll and LxssManagerProxy.dll in System32\WinSxS folder and copy those in lxss folder.

@benhillis yes I have removed and re-added the Linux subsystem feature multiple times with no luck.
@Biswa96 what kind of danger?  Security issue or breaking LXSS?

The second  one.

@Biswa96 tried you fix, but didn't help.  At this point most likely dealing with a bad image.  Was hoping to get this resolved without a reimage, but looking less likely.  WSL was one of the main reasons I upgraded, so its kinda a bummer, but I appreciate everyone's help with trying to get this working.

Do you have a clean image for 16299? Also, a culprit to always consider with updates/upgrades is A/V, host based FW, IPS, etc. getting in the way. They will cause data corruption if not configured correctly. So if you have the older version for your image, try manually upgrading with those security features disabled. Obviously re-enable after the upgrade is complete (if they don't enable themselves after the reboot). Follow these steps to enable WSL and install Ubuntu via Powershell.

Most likely has to do with my personal image.  Going to go ahead and close the issue.  Thanks for the help everyone!


Collective2 module modernization and finalization

Removed platformId support from C2.
Modernized C2 API calls to APIv4.
Added C2 rate limiters (RateGate).
Added response logging so users can easily debug their code. Added a few symbols for the demo.

Description
Collective2 Module and a DemonstrationAlgorithm
Related Issue
I am not aware of any related open issues
Motivation and Context
Modernize and finalize module
Requires Documentation Change
None
How Has This Been Tested?
Collective2SignalExportDemonstrationAlgorithm contains a list of symbols that produce expected results.
Types of changes

[X ] Bug fix (non-breaking change which fixes an issue)
[X ] Refactor (non-breaking change which improves implementation)
[ ] Performance (non-breaking change which improves performance. Please add associated performance test and results)
[ X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Non-functional change (xml comments/documentation/etc)

Checklist:

[ X] My code follows the code style of this project.
[ X] I have read the CONTRIBUTING document.
[ X] I have added tests to cover my changes.
[X ] All new and existing tests passed.
[ X] My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

Reviews addressed in https://github.com/QuantConnect/Lean/pull/7448, closing this PR since included


Update to v1.0.3

Linter check found the following problems:
The following problems have been found:
WARNING: clone/recipe/meta.yaml:78: missing_license_file: The recipe is missing the about/license_file or about/license_url key.
Warnings were found


JSON-requests not correctly proxied

#PROXY-REWRITE:
local-web-server proxy request +0ms from: /loginservice/de/1234, to: http://myserver/login/de?myId=1234
#local-web-server RESPONSE
curl -v -H "Content-Type:application/json" --data<EMAIL_ADDRESS>"http://mylocalhost/loginservice/de/1234"

Hostname was NOT found in DNS cache
Connected to ... (...) port 8999 (#0)

POST /loginservice/de/1234 HTTP/1.1
User-Agent: curl/7.35.0
Host: ...
Accept: /
Content-Type:application/json
Content-Length: 122

upload completely sent off: 122 out of 122 bytes
< HTTP/1.1 500 Internal Server Error
Server Apache-Coyote/1.1 is not blacklisted
< server: Apache-Coyote/1.1
< date: Wed, 16 Dec 2015 09:41:52 GMT
< content-length: 0
< connection: close

#CORRECT RESPONSE VIA DIRECT CALL

upload completely sent off: 122 out of 122 bytes
< HTTP/1.1 200 OK
< Date: Wed, 16 Dec 2015 09:48:53 GMT
Server Apache-Coyote/1.1 is not blacklisted
< Server: Apache-Coyote/1.1
< Content-Type: application/json
< Transfer-Encoding: chunked
<
Connection #0 to host localhost left intact
{"status":"SUCCESS","resultUri":"..."}

hi marcus.. i don't have enough information to reproduce this, it could be caused by one of several things.. could you send

the full URL of the remote endpoint you are hitting ("http://myserver/login/de?myId=1234")
some example request body data (--data<EMAIL_ADDRESS>)

if you prefer you can email me or use the gitter room

hi markus, is this still an issue with local-web-server v1.1.1?
The latest version has an updated http-proxy module and also a significant bug was fixed..

Hey Lloyd,I installed the latest version 1.1.1 and retried, but without a remarkable effect. The problem still exists.RegardsMarkusLloyd Brookes<EMAIL_ADDRESS>hat am 20. Februar 2016 um 17:18 geschrieben:hi markus, is this still an issue with local-web-server v1.1.1?The latest version has an updated http-proxy module and also a significant bug was fixed..—Reply to this email directly or view it on GitHub.

hi Markus.. sorry for the long delay.. i have discovered and fixed an issue today which may also fix your problem..
could you run this command (to install ws directly from Github) and check if your issue is fixed please?
$ npm i -g 75lb/local-web-server

thanks,
Lloyd


Fix for help command showing "interaction failed"

Thanks!
Can you only use https://github.com/quantumsheep/lennybot/pull/3/commits/4a944d52fa6e357ea7f205aa856b1ae326da7404 in this PR and do another separated PR with the Prettier configuration that goes with https://github.com/quantumsheep/lennybot/pull/3/commits/68d6215d8322f927a44346fbecdf47e2cc63a2c4?

im not that handy with git, i can add the config to this pr or make a new one for it. Im not sure how to remove commits from pr's

Let's not complicate thing then, just add a prettier configuration that matches your changes and that will be fine :)


Microsoft.Web/sites/hostnameBindings

Describe the noise
Resource type Microsoft.Web/sites/hostnameBindings
apiVersion 2019-08-01
Client (PowerShell, Azure CLI, or API) Azure CLI
Relevant ARM Template code (we only need the resource object for the above resourceType and apiVersion, but if it's easier you can include the entire template
resource functionAppHostnameBinding 'Microsoft.Web/sites/hostnameBindings@2019-08-01' = if (!empty(backendHostname)) {
  name: '${functionAppName}/${backendHostname}'
  dependsOn: [
    functionApp // remove when bicep supports lexical scoping: https://github.com/Azure/bicep/issues/1363
  ]
  properties: {
    sslState: 'SniEnabled'
    thumbprint: reference(backendCertificate.name).Thumbprint
  }
}

resource backendCertificate 'Microsoft.Web/certificates@2019-08-01' = if (!empty(backendHostname)) {
  name: '${namePrefix}-backendCert'
  location: location
  // bicep thinks "password" is required, but it is not.
  // Tracking issue: https://github.com/Azure/azure-rest-api-specs/issues/5029
  properties: {
    serverFarmId: hostingPlan.id
    canonicalName: backendHostname
  }
}

Expected response made no change
Current (noisy) response (either include a screenshot of the what-if output, or copy/paste the text)
  ~ Microsoft.Web/sites/REDACTED/hostNameBindings/REDACTED [2019-08-01]
    - location:                "Japan East"
    - properties.hostNameType: "Verified"
    - properties.siteName:     "REDACTED"
    ~ properties.thumbprint:   "REDACTED" => "[reference(format('{0}-backendCert', parameters('namePrefix'))).Thumbprint]"

The property "location" is read-only, and is tracked by the S360 KPI, but it takes time for the web RP to fix them, so I tagged it in our metadata. The other properties are immutable (cannot be updated after creation), but currently the What-If engine doesn't handle them. I'm going to update the engine to ignore immutable properties.


Attempting to redeclare a contract fails with Internal error

Describe the bug
When trying to declare a contract that has already been declared on testnet fails with LibraryError: -32603: Internal error.
This is the full error message:
LibraryError: -32603: Internal error
    at RpcProvider.errorHandler (/Users/david/apps/issues/starknet-js-rpc/node_modules/starknet/src/provider/rpc.ts:98:13)
    at RpcProvider.fetchEndpoint (/Users/david/apps/issues/starknet-js-rpc/node_modules/starknet/src/provider/rpc.ts:109:12)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async Account.estimateDeclareFee (/Users/david/apps/issues/starknet-js-rpc/node_modules/starknet/src/account/default.ts:160:22)
    at async Account.getSuggestedMaxFee (/Users/david/apps/issues/starknet-js-rpc/node_modules/starknet/src/account/default.ts:520:23)
    at async Account.declare (/Users/david/apps/issues/starknet-js-rpc/node_modules/starknet/src/account/default.ts:332:8)
    at async declareContract (/Users/david/apps/issues/starknet-js-rpc/scripts/utils.ts:71:21)
    at async main (/Users/david/apps/issues/starknet-js-rpc/scripts/deploy.ts:29:9)

To Reproduce
I put together a small repository to reproduce the issue. Follow the instructions in the Readme file.
Expected behavior
The script should fail with a properly formatted error message so it can be handled.
Screenshots
This is the line where the library fails

Desktop (please complete the following information):

Browser & version [e.g. chrome, safari, webworker]:
Brave Version 1.60.114 Chromium: 119.0.6045.124 (Official Build) (x86_64)

Node version [e.g. 16.0.1]: 20.9.0

Starknet.js version: 5.19.5

Network [devnet, testnet]: testnet

Additional context
The error happens only when redeclaring. Declaring a new contract works fine.

starknet.js doesn't do anything fancy with the error response it just passes along the top level code and message. The reported issue arose because the error message that was once on the top level got moved deeper within the error response object.
It's currently not a straightforward fix that would align with earlier error handling because the error response objects are different between different nodes (Pathfinder and Juno). Making the original error response object available through LibraryError could potentially be a usable compromise.

Before trying to declare, you can test if the class already exists (provider.getClassByHash())
https://www.starknetjs.com/docs/next/API/namespaces/hash#computecontractclasshash
https://www.starknetjs.com/docs/next/API/classes/Provider#getclassbyhash

@penovicp would it make sense to return the whole error object to the user? It would help a lot with debugging

@PhilippeR26 thank you, that worked. I'll leave it up to you if you want to close the issue or not. My problem is solved but I think this might be a bigger discussion about how the library should handle errors coming from an RPC server.

@penovicp would it make sense to return the whole error object to the user? It would help a lot with debugging

In the latest pre-release the underlying error response is stringified and included in the error message, it’s just a bit clunky since it requires manual parsing. The issue will probably be kept open to be reevaluated for when the network itself is in calmer waters (or if closed, at least aggregated with other error related issues). I haven't checked, but I believe part of the issue is also that some nodes might not necessarily comply to the response specification when it comes to errors.
And to add to Phil’s recommendation, the Account class has two very convenient methods that Toni created that noticeably simplify declarations/deployments: declareIfNot encapsulates the check from Phil’s suggestion, and declareAndDeploy does what its name says and uses declareIfNot internally.

We can open a new issue regarding better handling errors, but closing this one as resolved.


fix(pacmak/python): improve detection of twine

Attempt to check for twine using which, and only fall back to
pip3 show if that fails. This should hopefully improve detection in
contexts where a Python virtual environment is activated that does not
have twine installed in it, causing pip3 show to (presumably) not
see it.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository


hash-files breaks tailwind hot reloading

Hey there! Thanks for adding the hash-files option; it's really helpful.
I have hash-files and tailwind enabled. When I change my code to add a new tailwind class, it kicks off the rust build and the tailwind build as expected, but when the page reloads I don't get the new styles. I suspect that this is because the hashes don't get properly updated for the CSS when tailwind rebuilds.
Right now I have to restart cargo leptos watch for the target/debug/hash.txt file to change, and also for the CSS link in the HTML head to change. Following the restart, I have the new classes.
I apologize that I don't have enough time for a reproduction right now, but to reproduce it should only require that hash-files and tailwind are enabled.
EDIT: actually I do have a reproduction, it's just not minimal :)

Any thoughts on this? If there's not bandwidth to look at this, let me know and I can spend some time on it.

Generally with cargo-leptos the answer is going to be that there's not bandwidth to look at this, so definitely feel free to investigate.

For others seeing this, my workaround is to turn hash-files off in the Cargo.toml and then add LEPTOS_HASH_FILES=true during the release build.
I'm still planning to investigate the root cause when I have some time.

@johnbchron Any update on this? :)

@Boscop Have not worked on this at all. cargo-leptos is basically just a ton of glue (not blaming anybody for this, it's just how side projects end up, when in this position) so I didn't have bandwidth to grok the codebase and diagnose the problem at the time I posted this.


Split Atmos between Lossy and Lossless

I suggest splitting Atmos to Lossy and Lossless. Here is what I use:
TrueHD Atmos (lossless)
truehd.*atmos|atmos.*truehd
DDP 5.1 Atmos (lossy)
\bDDP5.1\b.*atmos|atmos.*\bDDP5.1\b
I added | just in case the title doesn't follow the correct format.

Not sure if I'm going to split it but I will add them tomorrow perhaps.
But I noticed you only use 5.1 for lossy. What if there is a 7.1 ?
Or does that not exist ?

I believe Dolby Digital Plus doesn’t go beyond 5.1.

Did some research and asking,
Got some big help from @rg9400.
When I get home tomorrow from work they will be added and a few others.
And a edited version from yours for better matching.

should be added in the new and updated guide


[Crash Report] Array out of bounds in eva::format::pprint maybe?

2^63

are you by chance, using the version on crates.io (that is pretty outdated), ill make a new release soon, i have got too many things on my hands right now.
the newest release would give you the right output (but it would still crash on large multiplications):
> 2^63
9,223,372,036,854,775,808.0

yep that was the problem. will use version from github for now :)


module github.com/micro/go-micro/v2@latest found (v2.9.1), but does not contain package github.com/micro/go-micro/v2/grpc

as this title，what should I do？

because there is no such thing as v2/grpc. Either use v2/client/grpc or v2/server/grpc. Please look at the docs, or even the github repo to understand your import path is wrong.


minor change to panel flow when machine has multiple disks

Problem:

PR introduces a minor change to the installer to direct panel flow to password panel when node has multiple disks.
When multiple disks are present the disk choose page, after choosing the installation disk, the installer guides user to hostname panel even when install node is present.
Solution:

The PR changes the workflow when additional disks are present on the node.
Related Issue:
Test plan:

In my PR I merged installation disk and data disk, and this change seems not needed 🤔
https://github.com/masteryyh/harvester-installer/blob/a744bb185eea6dc6cbc8b68a1ad4af3aeb7d1662/pkg/console/install_panels.go#L457

@mergifyio backport v1.2


ninja: bad depfile: multiple outputs under Alpine Linux

Hey,
currently im building gRPC under Alpine Linux with ninja 1.9 .
I got at almost every file i compile the error
ninja: bad depfile: multiple outputs: _deps/grpc-src/third_party/protobuf/src/google/protobuf/stubs/strutil.h != _deps/grpc-build/third_party/protobuf/CMakeFiles/libprotobuf-lite.dir/__/src/google/protobuf/stubs/strutil.cc.o
despite that, its linking.
It is working with other docker images like Debian or Ubuntu. Any clue? Can i suppress this warning somehow?

Support for multiple outputs in depfiles was introduced in Ninja 1.10.0, it looks like the generator you are using depends on this. You should probably upgrade your Ninja binary to fix this instead.


Address issues in Acey-Ducey Python ports

This addresses issues discussed in #869 regarding the Python ports of Acey-Ducey; it also has a minor update to the Nim port.

Outstanding, thank you for your attention to detail!

@coding-horror Glad to be of assistance! This is a cool project; been spreading the word.


ffmpeg-full: don't disable rav1e

Description of changes
Remove disabling of rav1e encoder.
Even though it may be less performant, someone may want to use this encoder in particular. That's what ffmpeg-full is for.

Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[X] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[X] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 194547 run on x86_64-linux 1

4 packages marked as broken and skipped:

libsForQt512.kdenlive
libsForQt512.soundkonverter
libsForQt514.kdenlive
libsForQt514.soundkonverter

6 packages failed to build:

manim
obs-studio-plugins.obs-ndi
python310Packages.dm-sonnet
python310Packages.tensorflow-datasets
python39Packages.dm-sonnet
python39Packages.tensorflow-datasets

46 packages built:

MIDIVisualizer
arcanPackages.all-wrapped
arcanPackages.arcan
arcanPackages.arcan-wrapped
arcanPackages.durden-wrapped
arcanPackages.ffmpeg
arcanPackages.pipeworld-wrapped
arcanPackages.prio-wrapped
arcanPackages.xarcan
corrscope
ffmpeg_5-full
handbrake
haruna
imagination
jellyfin
jellyfin-ffmpeg
libsForQt5.kdenlive
libsForQt5.soundkonverter
libsForQt5_openssl_1_1.kdenlive
libsForQt5_openssl_1_1.soundkonverter
liquidsoap
media-downloader
megasync
obs-studio
obs-studio-plugins.looking-glass-obs
obs-studio-plugins.obs-backgroundremoval
obs-studio-plugins.obs-gstreamer
obs-studio-plugins.obs-move-transition
obs-studio-plugins.obs-multi-rtmp
obs-studio-plugins.obs-nvfbc
obs-studio-plugins.obs-pipewire-audio-capture
obs-studio-plugins.obs-vkcapture
obs-studio-plugins.obs-websocket
obs-studio-plugins.wlrobs
olive-editor
printrun
python310Packages.moderngl-window
python310Packages.pydub
python310Packages.pyglet
python310Packages.pytmx
python39Packages.moderngl-window
python39Packages.pydub
python39Packages.pyglet
python39Packages.pytmx
restream
webcamoid

Packages that failed to build required manually downloading specific files, which I didn't have the time to do.

@codyopel what do you think?

nixpkgs-review reveals no new failures, macos 10.15 & nixos x86_64. Package builds, nixos aarch64. pkgsCross.aarch64-multiplatform.ravle builds, so it shouldn't cause any problems for cross builds.
Though note comments of the commit which disabled it: https://github.com/NixOS/nixpkgs/commit/6cdbde2f0d0cc6b22b1fff9e6d3f3c63aecab171

nixpkgs-review reveals no new failures, macos 10.15 & nixos x86_64. Package builds, nixos aarch64. pkgsCross.aarch64-multiplatform.ravle builds, so it shouldn't cause any problems for cross builds.
Though note comments of the commit which disabled it: 6cdbde2

I understand the commit's motives, but I sometimes explicitly want to encode using rav1e (for comparisons, benchmarks, etc.), and not having it built by default in what should be ffmpeg-full does not make any sense imho.
If something in-between is needed, it should be called ffmpeg-most, to differentiate it with the full package.

No I think that's fair enough.

(can always revisit if rav1e becomes unreliable to build again)


No messages are fired on rebase or merge in versioning panel

Disabling versionning panel #205 .
Since atom is doing a git integration in 1.18, we  don't need it anymore.


Benchmark with modkit find-motifs

Hi team,
It was seeing your poster at ISME. I wanted to follow up on my question with an issue to serve as a (hopefully useful) reminder. It would be cool to benchmark your motif finding with modkit find-motifs.
Gio

Hello Gio!
It is on our to do list! We will post in here once the benchmark is available
Best Søren


min exposure

currently wand doesn't allow 0ms exposures, while the HF software does. In the source I see the following somewhat cryptic statement. @cjbe @dnadlinger any ideas what the issue was here? Otherwise I'll try removing it and see what breaks
https://github.com/OxfordIonTrapGroup/wand/blob/1fb4ac42d341e80e5afdb84c987683189e4597f3/wand/drivers/high_finesse.py#L105-L107

this seems to work absolutely fine on our WS7. Maybe this is an issue with one of the really old models.
@cjbe @dnadlinger any objection to me allowing 0ms min exposures after a bit more testing here?

I'm not aware of any specifics regarding this.

Me neither

Some observations:

CCD 1 seems to work as expected
Setting the CCD 2 exposure to 1ms deterministically gives errors on our WS7 (0,2, etc are all fine AFAICT)
looking on the HF GUI if one starts at 0ms and clicks up, the trace gets taller, but the number changes ~1s later to 2ms without user input and without the trace height changing. Similarly going down from 2ms to 1ms the trace gets lower but then the exposure changes to 0ms without intervention/a further change in trace height.

So it seems that there is no 1ms exposure...another undocumented feature courtesy of high-finesse. I'll push a suitably scummy hack to this shortly

I'll spin up a PR to do this. However, given the state of the HF software it's quite possible that the hack will not work on other models. Only one way to find out though...


enable back encrypt/decrypt pixel errors

Task/Issue URL: https://app.asana.com/0/488551667048375/1205581521828305/f
Description
Re-add encrypt/decrypt pixels now that sync is only triggered for users with sync enabled.
Steps to test this PR
Feature 1

[ ] with sync disabled
[ ] Perform actions that will trigger sync (e.g: access bookmarks, opening the app, add a bookmark, etc.)
[ ] ensure not pixel is sent
[ ] with sync enabled
[ ] it should work as usual (if need to produce an error, hardcode a line to throw an error when encrypt happens)

UI changes

Before
After

!(Upload before screenshot)
(Upload after screenshot)

Current dependencies on/for this PR:

develop

PR #3590   👈

This comment was auto-generated by Graphite.

Closing since we decided to discuss first what's the best approach to introduce them again.


cephfs: Scaling up fails if mount directory contains some files

description
When target volume to mount by fuse mount, client failed without nonempty option. Since fuse mount for ceph-csi does not have nonempty option, scale up fails once the volume contained files.
steps to reproduce
1. Run one pod with with fuse mount
  $ kubectl get pod web-server-76bdb8c758-b9m7d
  NAME                          READY     STATUS    RESTARTS   AGE
  web-server-76bdb8c758-b9m7d   1/1       Running   0          3m

  $ kubectl exec -it web-server-76bdb8c758-b9m7d bash
  root@web-server-76bdb8c758-b9m7d:/# mount |grep ceph
  ceph-fuse on /var/lib/www/html type fuse.ceph-fuse (rw,nosuid,nodev,relatime,user_id=0,group_id=0,allow_other)

2. make a file under the mounted volume in the
  (inside pod)
  root@web-server-76bdb8c758-b9m7d:/# touch /var/lib/www/html/test
  root@web-server-76bdb8c758-b9m7d:/# exit

3. scale up the pod
  $ kubectl scale --replicas=2 deployment web-

Result

Failed to mount the volume:

  $  kubectl logs csi-cephfsplugin-4sbnr csi-cephfsplugin
  ...
  ceph-fuse[452]: starting ceph client
  fuse: mountpoint is not empty
  fuse: if you are sure this is safe, use the 'nonempty' mount option
  ceph-fuse[452]: fuse failed to start
  2018-07-31 06:46:31.268 7fd5523cec00 -1 fuse_mount(mountpoint=/var/lib/kubelet/plugins/csi-cephfsplugin/controller/volumes/vol-8f3200c0-948c-11e8-9d90-54e1ad486e52) failed.

Just FYI, same error could be produced by local command.
// Add some file under target directory.
]# touch /mnt/cephfs/test

// Try to mount cephfs to /mnt/cephfs. (and it fails)
]# ceph-fuse  /mnt/cephfs  -m <IP_ADDRESS>:6789   -c ceph.client.admin.keyring
2018-07-31 02:47:39.038282 7f7d3457a0c0 -1 init, newargv = 0x55c54341ee40 newargc=9ceph-fuse[12016]: starting ceph client

fuse: mountpoint is not empty
fuse: if you are sure this is safe, use the 'nonempty' mount option
ceph-fuse[12016]: fuse failed to start
2018-07-31 02:47:39.057991 7f7d3457a0c0 -1 fuse_mount(mountpoint=/mnt/cephfs) failed.


Integration test for streaming data

Existing integration test
https://github.com/gojek/feast/tree/v0.1.0/testing/integration/tests/redis-bq-dataflow
only validates correct features ingestion and retrieval for bounded/batch data sources.
We need an integration test where the data source is unbounded/streaming as well.

I believe this is stale. Lets reopen after 0.3.0


[$500] Web - Workspace - First member highlighted after inviting users

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.3-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:

Navigate to Settings > Workspace > New workspace
Go to the Members section > Invite
Select 3 users and invite them
Notice after inviting the first member is highlighted
Click on the back button and revisit the members page
Again revisit the members page
Notice the highlighting is removed

Expected Result:
Members should not be highlighted, particularly the first member, after inviting others
Actual Result:
The first member in the workspace is highlighted after inviting, and the highlighting is eventually removed after revisiting the members page twice
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/d9ca1408-0055-4a6c-9d91-406147bdb972
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0129dea2eb15178846
Upwork Job ID:<PHONE_NUMBER>485468160
Last Price Increase: 2023-11-25
Automatic offers:

getusha | Contributor | 27866653

Please re-state the problem that we are trying to solve in this issue.
Workspace members are highlighted after inviting other users.
What is the root cause of that problem?
There is a styling option in BaseSelectionList.js that enables a list item to be highlighted.
What changes do you think we should make in order to solve the problem?
In BaseSelectionList.js, within the function renderItem, alter the variable 'isItemFocused' on line 295 to be equal to false. This would eliminate any list item from being highlighted in the specified manner.

What alternative solutions did you explore? (Optional)

Whoops, a bit late after reading the post above my proposal. If the situation changes, let me know.

Proposal
Please re-state the problem that we are trying to solve in this issue.

Web - Workspace - First member highlighted after inviting users

What is the root cause of that problem?

Generally, the first member is highlighted if the updateAndScrollToFocusedIndex(0) is called.
After we invite any user to the workspace then go back to WorkspaceInitialPage, then we go to the WorkspaceMemberPage again, the props.policyMembers in this page is updated because of API OpenWorkspaceMembersPage is called, that leads to the sections data that is passed to BaseSeletionList is updated, so that lead to the case updateAndScrollToFocusedIndex(0) is called in the second render, that leads to the first member is highlighted:
https://github.com/Expensify/App/blob/d985a0ee2604686911f34c99f5298af059622244/src/components/SelectionList/BaseSelectionList.js#L344-L355
Then, if we go back to WorkspaceInitialPage and then go to WorkspaceMemberPage again, the API OpenWorkspaceMembersPage is still called but the props.policyMembers is not updated because there is no member is added anymore, so the updateAndScrollToFocusedIndex(0) is not called in the second render, that leads to the behavior The first member in the workspace is highlighted after inviting, and the highlighting is eventually removed after revisiting the members page twice"

What changes do you think we should make in order to solve the problem?

We can call the API OpenWorkspaceMembersPage right after inviting any user to make sure the props.policyMembers is up-to-date. Can do it by updating:
https://github.com/Expensify/App/blob/d985a0ee2604686911f34c99f5298af059622244/src/pages/workspace/WorkspaceMembersPage.js#L132-L135
to:

    const isFocused = useIsFocused();
    useEffect(() => {
        getWorkspaceMembers();
        // eslint-disable-next-line react-hooks/exhaustive-deps
    }, [isFocused]);

What alternative solutions did you explore? (Optional)

NA

Result
Screencast from 26-11-2023 03:35:32.webm

Thanks @getusha! Looks like we have a few proposals up for review.

Proposal
Please re-state the problem that we are trying to solve in this issue.
When search using RHN, the scrollbar does not scroll properly when long pressed up or down arrow keys.
What is the root cause of that problem?
There are several areas of improvements. The search page is using section list which is setting renderItem without using useCallback or implementing shouldComponentUpdate. The list is being recreated for each render and for each item in the list. The scrollToLocation is dependent on SectionIndex and itemIndex, for each scroll sectionIndex and itemindex needs to be calculated. ScrollTolocation can be replaced with scrollIntoView.
The for loop for adjustedSectionIndex can also be removed.
https://github.com/Expensify/App/blob/8417724e600fc64e8c088925c9acb4b649b28955/src/components/OptionsSelector/BaseOptionsSelector.js#L335
What changes do you think we should make in order to solve the problem?
Refactor renderItem from BaseOptionsList.js into another class component BaseOptionsView.js and implement shouldComponentUpdate. Currently, the renderItem is called for each item on scrolling whether the item is highlighted or not. The shouldComponentUpdate skips re-renders and only updates the necessary items.
https://github.com/Expensify/App/blob/a273354130bbbc057dee4eefb1f9ac0371bec26a/src/components/OptionsList/BaseOptionsList.js#L279
      shouldComponentUpdate(nextProps, nextState) {
        if (nextProps.focusedIndex === nextProps.index + nextProps.section.indexOffset) {
          return true;
        }
        if (this.state.previousFocusedIndex === nextProps.index + nextProps.section.indexOffset) {
          return true;
        }

        return false;
      }

Instead of using sectionIndex and ItemIndex use scrollIntoView. ScrollIntoView allows smooth scrolling and is not dependent on sectionIndex or itemIndex.
https://github.com/Expensify/App/blob/a273354130bbbc057dee4eefb1f9ac0371bec26a/src/components/OptionsSelector/BaseOptionsSelector.js#L341
    window.requestAnimationFrame(() => {

        const scroll = this.state.listRef.current.getScrollResponder();
        if (this.state.focusedIndex == this.state.lastItemIndex) {
            scroll.scrollToEnd({animated: true});
        }
        else if (this.state.focusedIndex == 0) {
            scroll.scrollTo({
                y: 0,
                animated: true,
            });
        }
        else {
            const element = this.state.listRef.current.props.extraData.current;
            if (!element) {
                return;
            }
            element.scrollIntoView({behavior: 'smooth', block: 'center'});
        }
    });

The improvement is significantly better than that on staging. The scrolling animations are also preserved. Related to long pressing, the scrolling speed of the scrollbar is dependent on the key repeat rate set in the system settings. The key repeat rate can be turned off basically disabling long press or adjusted from slow to fast.
bug_solution.webm
Staging Search
staging_rhn.webm

Should this be hold based on https://github.com/Expensify/App/issues/31865#issuecomment-1826375553?

@getusha could you take a look at this one?

@lschurr this should be held for https://github.com/Expensify/App/issues/29080 as it could potentially change the current behavior.

On hold.

Hold

On hold.

On hold.

On hold.

On hold.

On hold.

On hold.

On hold.

On hold.

On hold.

The bug this was held on is fixed - https://github.com/Expensify/App/issues/29080
@getusha are you able to reproduce this bug?

Perfect, thanks!


about LabelMapping

Hi，
when i use my volume （969648）and label to run the “main.py”，i get this error
”dz = (target[0] - oz[pos[0]]) / anchors[pos[3]]
IndexError: index 4 is out of bounds for axis 0 with size 0”
and the index ，may be 5,6 or 7 in this error。 I have try to print the ”target，oz，anchors ”before run the ”dz = (target[0] - oz[pos[0]]) / anchors[pos[3]]”，but i failed。
meanwhile  I can't understand the details in the LabelMapping function. Could you please explain it?  thanks very much！

I also met the problem.
Have you solved it?


Allow providing a mnemonic in the StrongholdSecretManager builder

Description
I have this use-case in the cli-wallet init_command fn:
let secret_manager = StrongholdSecretManager::builder()
    .password(&password)
    .build(snapshot_path)?;
// TODO: allow providing the mnemonic in the builder?
secret_manager.store_mnemonic(mnemonic).await?;
let secret_manager = SecretManager::Stronghold(secret_manager);

Motivation
Ergonomics.
Open questions (optional)
I haven't investigated this deeply enough as to why this doesn't exist already. There might be a good reason for it.
Are you planning to do it yourself in a pull request?
I would do it.

After thorough investigation, I do not believe this is feasible without making the build function async, which I think would worsen the ergonomics in general.

Yeah, I don't think we're going to switch to sync locks for this.


Likely scam page on esp-rs.org

When dropping the hostname from https://docs.esp-rs.org I end up at a broken shopify (scam) page that looks like it might have been created by a bot with some picked up credentials... Probably worth looking into.

Thank you very much for reporting this. It is apparently a known issue that GitHub has yet to resolve, I was able to find other people complaining about the same thing happening to them.
I've nuked our DNS records setting up the apex domain with GitHub, and left only the CNAME entry redirecting to our self-hosted documentation for now, so that spam site is no longer accessible via our domain. Hopefully we can figure out how to configure the apex domain in a secure manner in the future.


Jobs on preempted VMs hang indefinitely until manually cancelled

Jenkins and plugins versions report

Environment

Paste the output here

What Operating System are you using (both controller, and any agents involved in the problem)?
Ubuntu
Reproduction steps

Create a pipeline where steps are run on preemptible instances
run the pipeline until an instance gets preempted while in the middle of a step

Expected Results
When a node is preempted, jobs / steps on the node should auto-cancel and be restarted elsewhere.
Actual Results

the node is marked as "offline"
the console output shows the preemption handler getting the preemption event;
The step is still treated as "in progress"--it shows with the progress display in the sidebar, the build time clock keeps ticking, etc, despite there being no hope of ever completing

Anything else?
No response

I also have the same issue with the following implementation :

Jenkins controller

OS : Debian 10
Java 11
Jenkins official LTS Docker image + some plugins
google-compute-engine:4.3.16
google-metadata-plugin:0.4
google-oauth-plugin:1.0.11

Jenkins image template agent on GCE

OS : Ubuntu 22.04 LTS
Java 11
Remoting : managed with SSH (but it is 3077.vd69cf116da_6f)

Jenkinsfile used :
pipeline {
    agent {
        label 'preemptible'
    }
    options {
        timestamps()
    }
    stages {
        stage('Test 1') {
            steps {
                echo 'Hello World'
                sh 'hostname'
                sh '''#!/bin/bash
                    COUNT=0
                    while [ $COUNT -le 100 ]
                    do
                        echo "Test # $COUNT"
                        sleep 1
                        COUNT=$(( $COUNT + 1 ))
                    done
                '''
            }
        }
        stage('Test 2') {
            steps {
                echo 'Hello Buddy'
                sh 'uname -a'
                sleep time: 5, unit: 'MINUTES'
            }
        }
    }
}

I simulated a preemption with the following command in the middle of the bash count loop :
gcloud compute instances simulate-maintenance-event --zone europe-west1-b --project my_project the_agent_gce_instance_name
Agent log and build log attached.
Steps to reproduce :

Create a pipeline job with the pipeline declarative code above
When the job is in the middle of a step (like the bash script), simulate a maintenance event with the above command.
The agent is getting the preemption event (as seen in the agent log) but the build is never failed or aborted and can last for days without a manual abort.
After the manual abort, the job is relaunched on another agent.

build.log
jenkins_agent.log

Hello, any updates on this ?


[release-1.10] tests: Add timeout before stop container.

release-1.10 - tests: Add timeout before stop container.
Starting a container and then stopping it right away can
be racy in some slow environments.
Implement a function to poll the status of the container
for a maximum of 100 seconds to let the container finish
its process and exit before stopping it.
Signed-off-by: Salvador Fuentes<EMAIL_ADDRESS>
- What I did
- How I did it
- How to verify it
- Description for the changelog

/test all

/test e2e_rhel

Hi, updated the PR using the same approach as #1656

/test all

@mrunalp @rhatdan those builds failed for weird reasons, could you retrigger them ?

/test all

@runcom @mrunalp @rhatdan could you re-trigger travis build?
Thanks

/test e2e_rhel

/test e2e_rhel

/test e2e_rhel


MatplotlibDeprecationWarning running pytest with PythonDebugger

Type: Bug
I am getting MatplotlibDeprecationWarning when I run this with the PythonDebugger in the Testing extension:
import warnings
import pytest

def f():
    warnings.warn("Test", UserWarning)

def test_warn():
    with pytest.warns(UserWarning, match="Test"):
        f()

Here's the traceback:
/home/stefanie/code/scikit-learn_dev/scikit-learn/sklearn/test_warn.py::test_warn failed: def test_warn():
>       with pytest.warns(UserWarning, match="Test"):
E       matplotlib._api.deprecation.MatplotlibDeprecationWarning: The interactive_bk attribute was deprecated in Matplotlib 3.9 and will be removed in 3.11. Use ``matplotlib.backends.backend_registry.list_builtin(matplotlib.backends.BackendFilter.INTERACTIVE)`` instead.

I would have expected not to see this warning and to continue with the debugging. Just running the test with Testing in VSCode or running pytest on the terminal works just fine.
sklearn/test_warn.py:8: MatplotlibDeprecationWarning
VS Code version: Code 1.94.2 (384ff7382de624fb94dbaf6da11977bba1ecd427, 2024-10-09T16:08:44.566Z)
OS version: Linux x64 6.11.5-arch1-1
Modes:

versions:
pytest==8.3.1
matplotlib==3.9.2

Hi @StefanieSenger ,
Thank you for reaching VS Marketplace Support Team, this issue is specific to VS Code editor and tools, if we understand correctly. It is best to reach out VS Code team at https://github.com/microsoft/vscode/issues.
Please feel free to reach out to us if you still require any help.

this issue is specific to VS Code editor and tools, if we understand correctly.

Yes it is. Sorry, I have then misplaced this issue. I will raise it in the correct project.


Revert "Merge pull request #9250 from alphagov/add-specific-rds-alarms"

This reverts commit 05ae3cb77c50e3e05a511c1d7cc4e23b689b747b, reversing
changes made to 585e2f2953c59b8ffb67177abda761da9b334e52.

About to raise a fix, instead of revert these changes


[Bug]: Middleware declared in controller construct is validated after other construct methods

As mentioned in the title, middleware declared in the construct method of a controller appears to be validated after any other methods in the construct.
Code example below, but summary is:

middleware should trigger an abort(404)
abort(500) is called after the middleware is declared
the abort(500) will always run first, even though it is called after the middleware.

Route:
Route::get('foo', 'ApiController@foo');

Controller:
class ApiController extends Controller {

	public function __construct()
	{
		$this->middleware('baz');
		abort(500);
	}
	public function foo()
	{
		return 'bar';
	}

Middleware:
class baz extends BaseMiddleware {

	public function handle($request, Closure $next)
	{
		if($request->input('test') == 1) {
        			abort(404);
    		}
    		return $next($request);
	}
}

visiting url.com/foo or url.com/foo?test=1 both returns the 500 error.
removing the abort 500 from after the middleware declaration and visiting url.com/foo?test=1 returns a 404 as expected.
Whilst this example is oversimplified, running a method which depends on the success of the middleware, after the middleware will fail. My case being getting the user from a token, where the middleware ensures the token is valid.

This is the expected behaviour. I have no idea why you would expect anything else?

Forgive me, was more the difference in when the middleware is run when declared in the construct, as opposed to when declared in the routes. When the middleware is called in the route, this happens before the construct is run, it would seem.

is there a way to have functions run in __construct() but after any included middleware??

@heisian I know I'm late but maybe someone will see this. You can override callAction method like this:
public function callAction($method, $parameters)
{
    //your code to run after middleware and before action
    return parent::callAction($method, $parameters);
}

It's not in construct but will be run in more less correct time. Unless you want to run something between middlewares.


Add dylib to mopro integration

Right now, mopro builds a .a library instead of .dylib, see here.
It looks like that the reason why the iOS app works when running it on Xcode but not with the react-native server or when exporting a .ipa.
Adapting mopro to use .dylib would allow us to do iOS releases.
Relevant PRs in mopro are here and here
Due to the way mopro is integrated now (subdirs copied in /app/ios), this would involved modifying the scripts/build_ios_module.sh script.

Solved in https://github.com/zk-passport/proof-of-passport/pull/82 by leaving mopro on iOS


Incomprehensible outcome characters

Hi!
I just run fairtally with my repo and got these results. Could you help me get the normal symbols?

S3bei

Moved issue to fairtally's repo: https://github.com/fair-software/fairtally/issues/94, closing this one.


Switch to ESM

I see that this lib switched to ESM only. This has some impact, considering the current state of the JS ecosystem. For example Next.js still has no support for ESM modules. While ESM is the way forward for sure, I wonder if it would be possible to still offer a CJS build until the the JS ecosystem more widely has adapted ESM.

Hmm, I successfully got a Next.js project to incorporate the ESM bundle just fine here. Can you help me understand your setup that's having trouble?
I'll admit I'm no Next.js expert but I was satisfied from testing that the move to ESM-only wouldn't impact most of the popular frameworks. Let me take a look at how I got Next.js to handle it, I should still have that around here somewhere...

Okay, I found my "Next.js + JS" setup, here's the package.json:
{
  "name": "learn-starter",
  "version": "0.1.0",
  "private": true,
  "scripts": {
    "dev": "next dev",
    "build": "next build",
    "start": "next start"
  },
  "dependencies": {
    "@simplewebauthn/browser": "file:../browser",
    "next": "^10.0.0",
    "react": "17.0.1",
    "react-dom": "17.0.1"
  }
}

$> npm list --depth=0
<EMAIL_ADDRESS>/Users/matt/Repos/simplewebauthn-integration-testing/nextjs-js-skoshx
├──<EMAIL_ADDRESS>-> /Users/matt/Repos/simplewebauthn-integration-testing/browser
├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>└──<EMAIL_ADDRESS>
It's nothing special, just a barebones Next.js v10 project with a copy of the ESM version of @simplewebauthn/browser. npm start says it's using Webpack 5 to build; maybe this will become a question of ESM support with earlier versions of Next.js using Webpack 4?

@MasterKale Strange. I have @simplewebauthn/browser as a dependency of an auth library that is consumed by a Next.js app. Using the library with @simplewebauthn/browser works fine, but when it is included and I start next dev I get the following error
SyntaxError: Unexpected token 'export'
    at wrapSafe (internal/modules/cjs/loader.js:979:16)
    at Module._compile (internal/modules/cjs/loader.js:1027:27)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1092:10)
    at Module.load (internal/modules/cjs/loader.js:928:32)
    at Function.Module._load (internal/modules/cjs/loader.js:769:14)
    at Module.require (internal/modules/cjs/loader.js:952:19)
    at require (internal/modules/cjs/helpers.js:88:18)
    at Object.<anonymous> (/Users/florian/Github Repositories/supportcodes/node_modules/@culinario-mortale/authentication-internal/lib/auth-stages/sign-in/sign-in.logic.js:19:19)
    at Module._compile (internal/modules/cjs/loader.js:1063:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1092:10)
/Users/florian/Github Repositories/supportcodes/node_modules/@simplewebauthn/browser/dist/bundle/index.js:116
export { startAssertion, startAttestation, supportsWebauthn };

I'm using Next 11 + Webpack 6, no special config.
Using<EMAIL_ADDRESS>the error is gone.
Not exactly sure what is the root of the problem. As far as I known, Next.js does not support ESM modules (https://github.com/vercel/next.js/discussions/22381).  Problem could also be my build setup
In the library that consumes @simplewebauthn/browser I have the following build setup
// package.json  (relevant parts) – no module prop set, only main
{
"main": "./lib/index.js",
 "name": "@culinario-mortale/authentication-internal",
"types": "./lib/index.d.ts",
"files": [
    "lib"
  ],
"scripts": {
"build": "rimraf lib && tsc",
}
}

// tsconfig.json
{
  "compilerOptions": {
    "allowSyntheticDefaultImports": true,
    "declaration": true,
    "esModuleInterop": true,
    "jsx": "react",
    "lib": ["ES2018", "DOM"],
    "module": "CommonJS",
    "moduleResolution": "node",
    "outDir": "lib",
    "strict": true,
    "suppressImplicitAnyIndexErrors": true,
    "target": "ES6"
  },
  "include": ["src"],
  "exclude": [
    "node_modules",
    "lib",
    "./src/**/*.spec.ts",
    "./src/**/*.spec.tsx",
    "./src/setupTests.ts",
    "./src/**/__mocks__"
  ]
}

Are you able to produce a reproduction repo I can pull down to work with? I have a couple of hunches but if you're able to distill the issue down to its essential elements I'll have a much easier time identifying potential solutions.

I will try to put something together this week, give me a few days.

I am also getting this error on my Next project. Currently reverting to 3.0.0 version works fine :)

I have @simplewebauthn/browser as a dependency of an auth library that is consumed by a Next.js app. Using the library with @simplewebauthn/browser works fine, but when it is included and I start next dev I get the following error

@florianbepunkt I keep thinking about this. So @simplewebauthn/browser can be consumed directly by Next.js 10+, but the same project could fail to build if browser is a dependency of another library that's being consumed by Next.js instead?

@MasterKale Apologies for the delay. I contrived a repro.
This is the library that imports webauthn (published to npm): https://github.com/florianbepunkt/test-webauthn-package-next
This is the next app that consumes the above lib: https://github.com/florianbepunkt/webauthn-next
You can clone the next app and run npm install && npm run dev

@MasterKale The problem is easy to understand.
His library is compiled in CJS and it's doing only an import of SWAN and using startAssertion method.
Then that library is included in a Next.js project but because the library isn't in ESM so it's not compiled correctly in the application.
The library which included SWAN should be compiled and published in ESM then included in the Next.js application like this all will be compiled and all will work.

@akanass Yes, but as far as I know, Next.js does not support ESM only modules

For example Next.js still has no support for ESM modules. While ESM is the way forward for sure, I wonder if it would be possible to still offer a CJS build until the the JS ecosystem more widely has adapted ESM.

@florianbepunkt Next.js is able to compile ESM to CJS as @MasterKale did in his example.
All is working fine with ESM in this library because it's the job of the bundler to compile to CJS.
We did a lot of test which worked fine on our side even with Next.js

@akanass Thank you. I definitely see, that importing this package directly in Next.js works. However I can't figure out where I went wrong...
There is no compley build setup, just using plain typescript compiler tsc in my example.
I just updated the tsconfig to match the one of this package, so it does not compile to CJS, but then I get an error from next.js
// tsconfig of my lib
{
  "compilerOptions": {
    "allowSyntheticDefaultImports": true,
    "declaration": true,
    "esModuleInterop": true,
    "jsx": "react",
    "target": "ES2018",
    "module": "ES2020",
    "moduleResolution": "node",
    "lib": ["ES2018", "DOM"],
    "outDir": "lib",
    "strict": true,
    "suppressImplicitAnyIndexErrors": true
  },
  "include": ["src"],
  "exclude": [
    "node_modules",
    "lib",
    "./src/**/*.spec.ts",
    "./src/**/*.spec.tsx",
    "./src/setupTests.ts",
    "./src/**/__mocks__"
  ]
}

Next error: SyntaxError: Unexpected token 'export'

@florianbepunkt the problem isn't with Next options but with your library which has to be compiled in ESM as well because that is where SWAN is imported.
Then you include your ESM library in Next and it will be compiled in CJS and it should work with the default option that you used when you have directly imported SWAN inside.

But the tsconfig (of my library) given above does compile to an ESM module, doesn't it?
"compilerOptions": {
"target": "ES2018",
"module": "ES2020",
 "moduleResolution": "node",
}

@akanass Thanks for jumping in, now that we know it's likely something with the library and how it's built I'll work with @florianbepunkt from here on.
@florianbepunkt Let me summarize as I understand things so far: you confirmed that @simplewebauthn/browser works when directly imported, but your library (that uses browser), when built with tsc, succeeds in building to ESM but Next.js errors out about the existence of export when you attempt to import your library?
After hearing that you use tsc to transpile your library I need to clarify that browser uses Rollup to build to ESM (getting pedantic for a second, tsc lacks the ability to bundle code; it can only compile TS to vanilla JS code), so this won't be an apples-to-apples comparison.
When Rollup builds browser it generates a single file with everything crammed into it, and a single export statement at the bottom - you can see for yourself here: https://unpkg.com/<EMAIL_ADDRESS>When I use just tsc to build I get a bunch of individual .js files that look like proper ESM code, minus the typings and I guess some TS optimizations (I haven't done a diff of a .ts compared to it's .js, just eyeballed it)
So for some reason Next.js has no problem with the export in something bundled with Rollup, but doesn't like it in TS code...
I think there are two options here:

Figure out why Next.js supports an ESM bundle like browser
Incorporate a bundler into your library and see if you can get it to produce something that Next.js will load

I suppose option three is I restore the CommonJS bundle to browser as was available pre-3.1.0, but I think it's weird for an ostensibly front end library to include a bundle using the same import/export mechanism as Node...

@MasterKale Thank you. Next.js by default only transpiles the ES6 code of the application source code (using babel-loader), while ES6 code imported from node_modules is not transpiled. This can be solved with the next-transpile-modules library.
// inside next.config.js

const withTM = require("next-transpile-modules")([
  "my-library",
  "@simplewebauthn/browser",
]);

module.exports = withTM({
  // your next.js config options
});

Thank you for the follow-up, and for including a solution! I'll look to document this officially somehow, because I know this question will come up again.
For anyone coming to this later: next-transpile-modules is the way to get Next.js to consume any third-party package that only offers an ESM build, like @simplewebauthn/browser.

Well y'all are super fast with your response 🤟 . I checked the linked issue and abracadabra there lies the solution, works like magic 🎉  thanks! I will close this issue. Sorry for the duplicate.


Proper formatting in HelpText of options with DefaultValue set to arrays.

Created from
http://stackoverflow.com/questions/15208931/default-values-for-lists-arrays-using-command-line-parser-library
by @pheiberg.
@pheiberg, thank you for taking time to report issue. As the previous, will be fixed ASAP.
Regards, Giacomo

This issue seems to be present in the latest (git) version. I'm still getting (Default: System.String[]).

This is an issue, I've to put my mind on it again ... :smile:
Did the problem persists with actual 2.0.* version?

@gsscoder yeah, I've just pulled from this git repo

Would it be a good idea to use OptionAttribute.Separator to display the default value for lists/arrays,
e.g. Default: a;b for
public IEnumerable<string> Words { get; set; }```
That would serve as an example and correspond directly to the expected input format.

Sorry I just realised that space-separated lists are always accepted.

@gaborigloi, anyway you were right! This issue was re-introduced with 2.0.x version.
Why? Because kernel was heavily refactored and same change to satellite types may have lost due to different internal software structure.
Now this is fixed also for 2.0 (I'm talking of Default output problem, yes in 2.0 is called Default not DefaultValue).
Am I right or do you have spotted something new? If yes, please tell me...
Thanks again! :)

2.0.223-beta fixes it (just commited!) and also on NuGet.

Can you check if everything work and tell me if not (please)?

I've also added two comments in S.O. topic: http://stackoverflow.com/questions/15208931/default-values-for-lists-arrays-using-command-line-parser-library.

@gsscoder I've just checked <IP_ADDRESS> and it works fine :)
no problem, and thanks for the fix :)

Perfect @gaborigloi, thanks for checking it and using this library.
And for everything, don't hesitate and back here, I or one of your excellent contributors will try to assist!


Define product model

Adds the product.py and Product class.

Thomas, good work. But next time, wait for me to approve your pull request so I can give feedback before doing so.

Can you please create a folder called "models" for the product.py? Also, please make sure you do "git pull origin main" before doing anything, as I've just pushed some changes.


[CuriousCatBridge] Add new bridge

Adds a bridge for Curious Cat profiles. Uses undocumented API that powers the website.

Thanks for the PR !


setup CI check for anchors & dead links

Proposed changes:

Fixes https://github.com/RasaHQ/rasa/issues/6763

Status (please check what you already did):

[ ] added some tests for the functionality
[ ] updated the documentation
[ ] updated the changelog (please check changelog for instructions)
[ ] reformat files using black (please check Readme for instructions)

@erohmensing I am sure you'll love it. The two plugins I've setup have detected a bunch of dead links + dead anchors! (also, since we removed the ".mdx" extensions to some links, we need to added them back, otherwise the remark plugins do not work, cc @lunelson)

@lunelson let's prioritize these for later. With the release date coming up, it's better to activate only the things that we need now. Btw, you can also install a recommended for remark-lint, tried it, and it definitely needs more config / tweaks than I have time to do it.

@erohmensing I've fixed a lot of link errors (a few external links and a lot of anchor errors). Would you mind giving me a hand here? 🙏

Thanks will do!

thanks a lot for your help @erohmensing on this one! couldn't have done it without you 💯 I'll open a PR to have this ready for Rasa X as well


Async suffix

Should the Async suffix convention be used in 2018?
I'm so sorry for bringing this up, its not an issue as such, its debatable, but this might be the best forum for it.
Should .NET and other open-source libraries continue to append Async on awaitables?
General
My team here have begun to drop it; I always wondered whether this might happen but thought it premature until I read this.
https://docs.particular.net/nservicebus/upgrades/5to6/async-suffix
What do we feel is appropriate guidance in 2018?
Thanks

I totally agree. There are enough indications that a method is async:

Return type is Task / Task<>
Code completion presents an awaitable hint
the IDE will warn you by underlining in green
Compiler will present a warning when task is not awaited.

Using the Async suffix only makes sense if your API offers the same functionality in both flavors:
GetObject()
GetObjectAsync()

For any other use case, using the Async-suffix is as silly as adding a Lazy-suffix to any Lazy<> property:
public Lazy<Customer> CustomerLazy.
If you wouldn't do that, then don't use the Async suffix :-)

Thanks for your answer.
For accuracy, number one isn't quite right, the compiler works by looking for an awaitable type, which is any type that has TaskAwaiter GetAwaiter() on it.

Hey Folks,
I've moved this discussion to the dotnet/corefx repo where Framework Design Guidelines and API discussions occur - as you're more likely to get engagement there.  For more details on the CoreFX API and FDG see http://aka.ms/api-review
The new issue is https://github.com/dotnet/corefx/issues/31275


Aztec Macros

Tracking issue for Aztec Macros.
This might change quite a lot depending on what the priorities look like for Noir Macros.
### Tasks
- [ ] https://github.com/AztecProtocol/aztec-packages/issues/2247
- [ ] https://github.com/AztecProtocol/aztec-packages/issues/4519
- [ ] https://github.com/AztecProtocol/aztec-packages/issues/3129
- [ ] https://github.com/AztecProtocol/aztec-packages/issues/3011
- [ ] https://github.com/AztecProtocol/aztec-packages/issues/5078
- [ ] https://github.com/AztecProtocol/aztec-packages/issues/5081
- [ ] https://github.com/AztecProtocol/aztec-packages/issues/5079
- [ ] https://github.com/AztecProtocol/aztec-packages/issues/5057
- [ ] https://github.com/AztecProtocol/aztec-packages/issues/4129
- [ ] https://github.com/AztecProtocol/aztec-packages/issues/5080
- [ ] https://github.com/AztecProtocol/aztec-packages/issues/4373
- [ ] https://github.com/AztecProtocol/aztec-packages/issues/3119
- [ ] https://github.com/AztecProtocol/aztec-packages/issues/4647
- [ ] https://github.com/AztecProtocol/aztec-packages/issues/4649
- [ ] https://github.com/AztecProtocol/aztec-packages/issues/4520
- [ ] https://github.com/AztecProtocol/aztec-packages/issues/5427

### To Triage
- [ ] https://github.com/AztecProtocol/aztec-packages/issues/5131
- [ ] https://github.com/AztecProtocol/aztec-packages/issues/5130

Might be a good idea to also add tests for the macros.


Add injected reagents and metabolism

We should support injected reagents and metabolism for them. Currently reagents can only be metabolized if consumed by a mob with a StomachComponent. This would include a few things:

[ ] Syringes that can draw/inject reagents from containers
[ ] Single use injectors that can only inject reagents and aren't refillable
[ ] Some component that accepts injected reagents and metabolizes them

I'm already working on this and should have a PR + design write up ready in the next few days. While #170 is related it's very broad and there was no issue specifically for this so I wanted to make it so multiple people didn't try working on it at the same time. Can this be assigned to me?

Can you edit the issue and link to the hackmd docs when you finish them?

Yup. Will do.

some component to metabolize injected reagents

perhaps some kind of BloodComponent?

Yup, I was thinking something similar. Currently have BloodstreamComponent that injectors inject into. Not going to have actual blood that can be drawn/bled for now to keep the PR from getting any bigger. Current design is looking something like this:

Still need to change StomachComponent so it gradually sends it's contents to BloodstreamComponent, make my code less garbage, and document it.

There was a discussion about making a bloodstream reagent container that would hold reagents that were absorbed into the bloodstream. Things like the brain would take the reagents from the bloodstream and metabolize them.

I think that would over complicate things. Similar behavior should be possible with IMetabolizable (what the bloodstream would use to metabolize each reagent) since it passes the entity metabolizing the reagent. This would let certain metabolism effects interact with other organs like the brain or depend on them being present to have an effect.
This should be cleaner since it'd keep all the metabolism code in classes inheriting IMetabolizable and not strewn across multiple components. Easier to find and keeps components from getting bloated. I understand that it makes sense in real life but for our purposes it'd be simpler to have the bloodstream handle it and let IMetabolizable implementations to interact with other organs when needed.

I was thinking about having a liver organ metabolize chems specifically but having metabolism be handled by ANY organ sounds interesting. Most of them would probably still be metabolized by the liver but it would allow for more robust treatments for certain conditions.

While I still think having the bloodstream handle metabolism is simpler, the good thing is that the changes I'm suggesting work as a precursor for either path.
What I'm suggesting is that once reagents are in the bloodstream it gradually runs their IMetabolizable implementations and discards them after they're metabolized. If we wanted other organs to do this instead you could cut the bottom half of that graph off and pass reagents to other organs and run their metabolism code instead once they're in the bloodstream. The bloodstream would essentially be the interface between different delivery methods and the organs.

Cum chem metabolized by reproductive organ


Added inheritMin and inheritMax to globals

Hi,
I made this PR because I had the need to specify if min or max would be inherited globally.
The changes were very simple, as you can see in the diff.
I've also added the documentation for it on Readme.md and brought the version to 4.1.2.

Refactored to use existing min /  max properties. See v4.2.0

Cool, that is a best solution.


is there a way to disable move down/up events for treeMap

I wound like to disable the default event behavior of move down/up the tree level. And would to like add customized event for 'select'. I have tried this, but it won't work.
                chartEvents={[
                    {
                        eventName: "ready",
                        callback: (a) => {
                          a.google.visualization.events.removeAllListeners(a.chartWrapper);
                        }
                    }, {
                        eventName: "select",
                        callback: (a) => {
                            const chart = a.chartWrapper.getChart();
                            console.debug("SELECTED: ", chart.getSelection());
                        }
                    }
                ]}

Thanks!

If you don't care about hover, then it's possible by css. Set the attribute pointer-events:none for the id of the chart. This sattisfied my use-case but there should be a better solution.


Adding segmentation tool to version 2

Hello,
I'm trying to deploy an OHIFViewer server in a hospital in France, and for this I would like to add a freehandROI tool from Cornerstone tools ((https://tools.cornerstonejs.org/examples/tools/freehand-mouse.html), and afterwards be able to save the Dicom and the segmentation. .
I found how I could add the corresponding button in the Toolbar (getDefaultToolbarButtons.js), but I am struggling to find how and where the tools are called in the code, and so where to add my code calling the corresponding tool.
I know this issue has already been posted but the posts mainly refer to the version 1.x and I could not find my answers.
Many thanks in advance

Our extension/module system is still in its infancy, and will likely change a fair amount over the next month or two before stabilizing. I have just updated existing extensions to specify their own toolbar buttons, commands, etc. as well as in what "contexts" they should be visible/active.
The only way to modify the toolbar, today, is to modify the toolbarModule for the appropriate extension. I have a few different ideas on how we can improve the ergonomics here that I'll post shortly to a discussion issue.
You'll notice in the @ohif/extension-cornerstone, that there is a command named setToolActive that takes a toolName via options. The tool's currently available for a cornerstone viewport are set in the react-cornerstone-viewport via the availableTools prop.
If you:

Create a PR that adds freehand as a default availableTool
Fork the @ohif/extension-cornerstone and modify the toolbarModule
Update your Viewers reference to your forked extension
Rebuild

You should be able to add support for the freehand tool.

save the Dicom and the segmentation

Are you trying to "burn in" the annotation, or push the seg to your PACS? I know we have a few efforts internally to get functionality in line w/ our Meteor version, but I'm not sure where we're at on their progress.

Thank you for your quick answer.
I will try what you suggest and let you know how this goes.
In the future the idea would be to push the seg to the PACS, but for the moment we would like to push the DICOM image and the segmentation to a local server.

Hi @dannyrb,
I followed your advices but I am still struggling.

I did the PR for the FreehandMouse tool as default avaibleTool (that you merged)
2/3. I don't understand what you mean by "Fork the @ohif/extension-cornerstone and modify the toolbarModule", given that this is a subfolder of Viewer. So basically i just modified the toolbarModule of my Viewers folder (Viewers\extensions\ohif-cornerstone-extension\src)

After rebuilding, nothing is different. I even tried to remove all tool from the toolbarModule file, but they are still there, working.
Many thanks for the support

Hi @MathisGuilhin
The development workflow really sucks right now for extensions. You have to use yalc or something similar to make changes and push it to a local npm registry (yarn link might also work). See https://docs.ohif.org/contributing.html#when-changes-impact-multiple-repositories
We are looking into ways to make this easier. The problem is that the extensions have a separate build process from the main application.

Thanks for your help @swederik
I managed to add the segmentation tool with yalc.

@MathisGuilhin will you create a PR for this? Currently struggling myself with this...

@t-fi, recent changes to the ExtensionManager could make this easier. Need someone to spike adding configuration to specify the availableTools for the cornerstone extension in the ExtensionManager's preRegistration hook.

Thanks for the feedback! I managed to do this by myself by now, in a quite hacky manual way. But it works 🎉🎉🎉
It was basically adding a few lines to the toolbar module and fighting with yarn and yalc.
Can I shamelessly advertise this issue about storing the annotaitons? That would be the next big step!

Well done @t-fi,
I am currently able to save the measurement under a JSON format, and I'm now trying to be able to load them back. I'll open an issue today about this.
If you want to be able to save the measurement, I could give you a few hints, don't hesitate to write me
Mat

@MathisGuilhin Could you please guide me too? This code has the tools, but they're commented out for a future release. I have a requirement to get the segmentation tool save the segmentation to the DICOM. Could you help me out as well?

@KhyatiMehta3 I'm sorry, I haven't been working on this for a year and haven't followed the recent updates, so I can't help you with this.. Wish you good luck though

Oh okay, thank you.. But if possible could you point me to your commits that worked? I'll figure something out from there?

You can check them there : https://github.com/MathisGuilhin/CREATIS-OHIFViewer-dev/commits/master. I left something that was working, with a segmentation tool, a repulsor toor and saving/loading measurements, but I have missed one year of OHIFViewer commit.. Hope that can help you though

Okay thank you very much! :)

Are you trying to "burn in" the annotation, or push the seg to your PACS? I know we have a few efforts internally to get functionality in line w/ our Meteor version, but I'm not sure where we're at on their progress.

@dannyrb Could you please give advice on how to achieve this? I'm trying something similar and the tools are up, but I want to know how to add the segmentation to the DICOM, just like how measurementsApi assists in persisting measurements inside the DICOM. I know the DataExchange.js file performs burning the data into the DICOM file, but would like your guidance on how to go forward.

@kkmehta03 did you have any success with storing and retrieving the annotation/measurement data? Would really appreciate if you could give some pointers on how to achieve it.


Allow customizing the headers of the email attachments

I updated this pull request to support images embedded in the HTML body.
This requires to keep the HTML and its related images in a new multipart/related MIME part (implemented in https://github.com/concrete5/concrete5/pull/6051/commits/0b29635135fdab39b847b1bd2cb4e2b9a44689a8).
Example usage:

<?php

$app = \Concrete\Core\Support\Facade\Application::getFacadeApplication();

$mail = $app->make('mail');

$mail->from('sender@example.com');
$mail->to('recipient@example.com');
$mail->setSubject('Sample message');

$mail->setBodyHTML('
This is an HTML message with an
');
$mail->setBody('Please see the HTML part of this message');

// Add a "normal" attachment
$mail->addAttachment(\File::getByID(1));

// Add an inline image
$mail->addAttachment(\File::getByID(2), ['disposition' => 'inline', 'id' => 'myContentID']);

$mail->sendMail();

Here's the final way the attachment-related function can be used:
$app = \Concrete\Core\Support\Facade\Application::getFacadeApplication();

$mail = $app->make('mail');

$mail->from('sender@example.com');
$mail->to('recipient@example.com');
$mail->setSubject('Sample message');
$mail->setBodyHTML('
This is an HTML message with an
');
$mail->setBody('Please see the HTML part of this message');

// Add a "normal" attachment
$mail->addAttachment(\File::getByID(1));

// Add a "normal" attachment, customizing the attachemt name
$mail->addAttachmentWithHeaders(\File::getByID(1), ['filename' => 'Name of the attachment.jpg']);

// Add an inline image
$mail->addAttachmentWithHeaders(\File::getByID(1), ['disposition' => 'inline', 'id' => 'myContentID']);

// Add an attachment by specifying its binary data
$mail->addRawAttachment('Example content', 'Text file.txt', 'text/plain');

// Add an attachment by specifying its binary data and custom headers
$mail->addRawAttachmentWithHeaders('Τεχτ φιλε ωιτη μυλτιβψτε ξηαραξτερσ', 'Text file with multibyte characters.txt', ['mimetype' => 'text/plain', 'charset' => 'UTF-8']);

$mail->sendMail();

With https://github.com/concrete5/concrete5/pull/6051/commits/0514febbb7238e7d21cf09f44306d2ebc0e5bdfe I added a workaround for a ZendMail bug (see that commit description).

When it comes to BC I am of the mind that we should adopt a standard and follow it. This is probably not the place to discuss since you've already addressed concerns in this pull request but I do think it's worth solidifying what BC means and where it's preserved. IMO we should just straight adopt what symfony does.

Let's continue the discussion about BC at https://github.com/concrete5/concrete5/issues/6057

This pull request looks good to me, the last thing that crosses my mind is: Should we use the existing content block formatting for interpolated values? I think it's{CCM:FID_1234} and {CCM:CID_1234}.
Another thought, could we detect these kinds of interpolated strings and add the images automatically? That way I could do:
$mail->setBodyHTML("Download a file");

and not need to do the resolution for that file id

That'd ne a really nice addition! BTW I think that's for another pull request, where in the sendMail method we could parse the HTML message and add the found images to the attachments.

See https://github.com/concrete5/concrete5/issues/6058


Fixing TestMinimumPasswordAge.test_too_soon

TestMinimumPasswordAge.test_too_soon assumed that new users were created with a password that can't be changed until 24 hours later. That assumption is no longer valid, so I've altered the test to make certain that the user is not allowed to change their password.

I don't think it's pedantic-- and I think the tests you describe might be better. Maybe I'm just being defensive about a test I wrote ;)
As it exists here, this test would fail if a change was introduced that altered the behavior of can_change_password to no longer correctly takes locked_until into account-- which seems like it'd be a thing worth knowing.

Okay, I think I'm convinced that it's meaningful, but that we should also write additional tests. I'm going to go ahead and merge so that all our tests are passing again. Thanks! :)


[devtools] remove "video will be out soon" note from WNDT64

What's changed, or what was fixed?

removes the note about the video being out in late Jan. The vid is already embedded in the post

Fixes: N/A
Target Live Date: 2018-02-06

[x] This has been reviewed and approved by @kaycebasques (myself)
[ ] I have run gulp test locally and all tests pass.
[x] I have added the appropriate type-something label.
[ ] I've staged the site and manually verified that my content displays correctly.

CC: @petele

Whoops!
There were 1 warnings that will prevent this PR from being merged. Please take a look, and either fix, or provide a justification for why they can't be fixed.
WARNINGS
src/content/en/updates/2017/11/devtools-release-notes.md#L168 - Updates post is missing comment widget: {% include "comment-widget.html" %}

:tada: This has been pushed live to https://developers.google.com/web/


Cow: Watch indiarehabs.in

Cow requests the watch of the watch_keyword indiarehabs\.in. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

indiarehabs\.in has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by VLAZ in Charcoal HQ


missing dependencies on master branch

when following the instructions for installation, after running "npm run bootstrap" and "npm run build" results in an error because its missing two packages: popper.js and react-dnd-html5-backend.
running npm i popper.js react-dnd-html5-backend results in a clean build.

Huh, weird, CI on master is green and only ran a day ago. 😕 But it does install things slightly differently. Could you perhaps make a PR with those dependencies fixed? In our root package.json we have everything in devDependencies btw.

closing this because it looks like its been fixed...sorry for not doing this myself awhile back :smile:


Don't cache kerberos tokens

They can't actually be reused. Instead, remember that a server requires
auth and perform it preemptively when sending future requests to the
same server

looks good


Support named export in loader modules

Feature request

What is the expected behavior?
module.exports.loader = function (content) {
  return someSyncOperation(content, this.data.value);
};

module.exports.pitch = function (remainingRequest, precedingRequest, data) {
  data.value = 42;
};

What is motivation or use case for adding/changing the behavior?
This could allow to make  loaders in generated js languages like PureScript that support generation only of named exports.
Actually currenlty it can be accomplished using default name - exports.default = it works, but probably when it will start to generate ES6 it won't be able to generate "named default export".
I think it is reasonable addition, to be symetric with other exported methods.
How should this be implemented in your opinion?
Are you willing to work on this yourself?
Maybe?

Here you can improve it https://github.com/webpack/loader-runner

default is also a named export. I don't see an issue with that. What kind of problem are you experiencing?

Closing due to inactivity.


Set WM_CLASS based on initial window title.

I think there is some problem with that code. Tile managers like XMonad, Openbox have ability to apply some properties to windows (e.g. make window floated or tiled) based on their properties.
I created window with some initial title using glutin and I can see title and WM_CLASS were correctly set using xprop utility. But I can't force XMonad to make glutin window floated using WM_CLASS value, only match based on title works.
I think it's because glutin sets WM_CLASS property too late (i.e. after window was appeared) and so WM can't match its window.


Request: Add docker compose example for Graylog-Forwarder

It would be very helpful to include a reference or example docker compose file for using Graylog-forwarder with docker. Currently there does not appear to be anything documented on how to correctly do this.

@drewmiranda-gl See https://github.com/Graylog2/docker-compose/pull/29. What do you think?


MySQL 8: ordering of multiple table options can prevent diff

After migrating from local MySQL 5.6.45 to RDS MySQL 8.0.15, skeema diff starting reporting this error on 16 out of 73 tables. I ran skeema init with no errors, and then ran skeema diff:
2019-07-25 23:56:09 [WARN]  Skipping table `categories`: unable to generate DDL due to use of unsupported features. Use --debug for more information.
2019-07-25 23:56:09 [DEBUG] --- Expected CREATE
2019-07-25 23:56:09 [DEBUG] +++ MySQL-actual SHOW CREATE
2019-07-25 23:56:09 [DEBUG] @@ -15 +15 @@
2019-07-25 23:56:09 [DEBUG] -) ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_unicode_ci ROW_FORMAT=DYNAMIC CHECKSUM=1 DELAY_KEY_WRITE=1
2019-07-25 23:56:09 [DEBUG] +) ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_unicode_ci CHECKSUM=1 DELAY_KEY_WRITE=1 ROW_FORMAT=DYNAMIC

The only difference seems to be in the ordering. I built skeema from source a day or two ago. The same schema had no problems when it was running on local MySQL 5.6.
$ skeema --version
skeema version 1.2.5-dev (snapshot build from source)

Thank you for the issue report! I've confirmed this is a bug in Skeema affecting MySQL 8.0. I should have a fix in master within a few days.
If you need an urgent work-around, you could manually remove the CHECKSUM=1 and DELAY_KEY_WRITE=1 clauses from your tables if you are using InnoDB storage engine. These clauses have no effect whatsoever on InnoDB; they're only meaningful to MyISAM tables. (see https://dev.mysql.com/doc/refman/8.0/en/create-table.html#create-table-options for corresponding manual entries for CHECKSUM and DELAY_KEY_WRITE.)
Background on this Skeema bug:

In all previous versions of MySQL, the order of table option clauses in SHOW CREATE TABLE exactly matched what was shown in information_schema.tables.create_options.

MySQL 8 introduced a new internal data dictionary, which has changed the underlying implementation of much of information_schema. As a result, the ordering of several things there has changed and no longer matches the behavior of previous versions.

Skeema primarily uses information_schema to introspect table structure (rather than relying on SQL parsing, which could be brittle across different versions/vendors). In order to sanity-check its understanding of a table and ability to diff a table, Skeema ensures that its expectation of what the canonical CREATE TABLE looks like matches the output of SHOW CREATE TABLE. The bug fix will be to ignore differences in the order of table options in MySQL 8+, as long as the option names and values are otherwise identical.

Thanks! Manually removing those unnecessary table options worked.

Glad the work-around was successful!
I've fixed the root cause in the master branch now too. Next binary release might be a few weeks away though.
Thanks again for the issue report!

I've just released Skeema v1.2.6 containing this fix. Thanks again for the bug report!


Error: Building package openssl-windows:x86-windows

It seems http://www.nasm.us/pub/nasm/releasebuilds/2.14/win32/nasm-2.14-win32.zip is offline? Is there a short term workaround?
-- Downloading http://www.nasm.us/pub/nasm/releasebuilds/2.14/win32/nasm-2.14-win32.zip...
-- Downloading http://www.nasm.us/pub/nasm/releasebuilds/2.14/win32/nasm-2.14-win32.zip... Failed. Status: 7;"Couldn't connect to server"
CMake Error at scripts/cmake/vcpkg_download_distfile.cmake:172 (message):

      Failed to download file.
      If you use a proxy, please set the HTTPS_PROXY and HTTP_PROXY environment
      variables to "https://user:password@your-proxy-ip-address:port/".
      Otherwise, please submit an issue at https://github.com/Microsoft/vcpkg/issues

Call Stack (most recent call first):
  scripts/cmake/vcpkg_find_acquire_program.cmake:262 (vcpkg_download_distfile)
  ports/openssl-windows/portfile.cmake:37 (vcpkg_find_acquire_program)
  scripts/ports.cmake:73 (include)

https://www.isitdownrightnow.com/nasm.us.html

I can reproduce this issue locally.
Fortunately for me, I have another machine that already had "nasm-2.14-win32.zip" downloaded from earlier when the site was still up so copying that file over fixed things for me.

www.nasm.us is unreachable in many places:
https://www.site24x7.com/public/t/results-1562316163264.html

Any update on this issue. ? or workaround

Looks like www.nasm.us is back online so I suppose the issue is fixed for now.

I suggest add a mirror for nasm as #7175 in case of it is down again

Thanks for posting this issue. This issue has been fixed in PR #7175. So I am closing this issue for now.


Adjust VDF security parameter

[x] regenerate fixtures test/prod
[x] update fixtures in tests miner
[x] update fixtures in move tests
[x] update defaults in NodeConfigs & genesis

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.0 out of 2 committers have signed the CLA.:x: root:x: lpgeigerroot seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


fix(schema): fix schema generation with multiple Enums having the same name

Change Summary
Two Enums with the same name were overlapping because we were not using the "long name" (module name + __name__ (soon __qualname__ but that's another PR...cf #2170))
Since we were already computing the long names for both models and enums, the fix is trivial!
Related issue number
closes #1857
Checklist

[x] Unit tests for the changes exist
[x] Tests pass on CI and coverage remains at 100%
[x] Documentation reflects the changes where applicable
[x] changes/<pull request or issue id>-<github username>.md file added describing change
(see changes/README.md for details)

looks good to me, any chance this is going to cause a breaking change with schema changing in a breaking way for some people?

looks good to me, any chance this is going to cause a breaking change with schema changing in a breaking way for some people?

IMO no. It doesn't change anything if there is a single name. The only impact is when there were conflicting names. So if it breaks something for someone it should highlight the issue that there were in fact multiple enums with the same name and fixing it should be trivial

IMO no. It doesn't change anything if there is a single name. The only impact is when there were conflicting names. So if it breaks something for someone it should highlight the issue that there were in fact multiple enums with the same name and fixing it should be trivial

thank you.

thank you.

I hope this fix can be released soon

I hope this fix can be released soon