ARM64 docker image

Hey could you please add an ARM64 docker image for this project?? I've tried running it locally, but keep getting this weird error that says that my I haven't added my db / bot token / channel id even though i've wrote everything correctly in the .env file. Thanks!

can you show your docker-compose file

Quote reply

version: "3.8"

services:
  update-notifier:
    image: ghcr.io/asdfzxcvbn/update-notifier:main
    restart: unless-stopped
    container_name: update-notifier
    environment:
      DATABASE: /data.db
      BOT_TOKEN: "6097140980:AAHrjWCNyFrxgtC1neHkRVhF0-3s57xxxxx"
      CHANNEL_ID: "20697xxxxx"
    volumes:
      - ./data.db:/data.db

Quote reply

version: "3.8"

services:

  update-notifier:

    image: ghcr.io/asdfzxcvbn/update-notifier:main

    restart: unless-stopped

    container_name: update-notifier

    environment:

      DATABASE: /data.db

      BOT_TOKEN: "6097140980:AAHrjWCNyFrxgtC1neHkRVhF0-3s57xxxxx"

      CHANNEL_ID: "20697xxxxx"

    volumes:

      - ./data.db:/data.db

huh?? can you show your container logs then? i mean you did specify everything so it should be going through fine

Quote reply

version: "3.8"

services:

  update-notifier:

    image: ghcr.io/asdfzxcvbn/update-notifier:main

    restart: unless-stopped

    container_name: update-notifier

    environment:

      DATABASE: /data.db

      BOT_TOKEN: "6097140980:AAHrjWCNyFrxgtC1neHkRVhF0-3s57xxxxx"

      CHANNEL_ID: "20697xxxxx"

    volumes:

      - ./data.db:/data.db

huh?? can you show your container logs then? i mean you did specify everything so it should be going through fine

I can't run the container bc there's no arm64 version for it (i told you this before). I tried running it on bare metal but it gives a weird error saying that I haven't specified my bot token or channel id correctly wven though I have done so. I'll send you the error message when I get home

ah right you said you needed an arm64 image but then proceeded to say you had it running so i was confused

arm64 images are now available

Tried running it now and am getting an error regarding the database. Keep in mind that I have created the database before starting the container, like it was indicated in the docs. Here are the logs:
_update-notifier_logs.txt

umm, how'd you create it? maybe the db is still locked? i mean i personally dont have any issues

ah with touch, uhhhh hold on

alright i believe i know what the issue is, after you touch data.db make sure to run the container, then stop it, then you can add apps after that, pls lmk if you still have problems

alright i believe i know what the issue is, after you touch data.db make sure to run the container, then stop it, then you can add apps after that, pls lmk if you still have problems

Hey could you please tell me how I would add apps if the container is stopped?? Tried attaching to the container while it is running but it keeps on telling me that I have to wait until it is running (which it never does because the database cant be opened)

alright i believe i know what the issue is, after you touch data.db make sure to run the container, then stop it, then you can add apps after that, pls lmk if you still have problems

Hey could you please tell me how I would add apps if the container is stopped?? Tried attaching to the container while it is running but it keeps on telling me that I have to wait until it is running (which it never does because the database cant be opened)

use your systems python to call the script to add an app, it only requires the stdlib so you shouldnt need anything else

alright i believe i know what the issue is, after you touch data.db make sure to run the container, then stop it, then you can add apps after that, pls lmk if you still have problems

Hey could you please tell me how I would add apps if the container is stopped?? Tried attaching to the container while it is running but it keeps on telling me that I have to wait until it is running (which it never does because the database cant be opened)

use your systems python to call the script to add an app, it only requires the stdlib so you shouldnt need anything else

Here's what I get:
`python src/update_notifier.py add -l https://apps.apple.com/us/app/tiktok/id835599320
please ensure DATABASE, BOT_TOKEN, and CHANNEL_ID are defined in the environment`

alright i believe i know what the issue is, after you touch data.db make sure to run the container, then stop it, then you can add apps after that, pls lmk if you still have problems

Hey could you please tell me how I would add apps if the container is stopped?? Tried attaching to the container while it is running but it keeps on telling me that I have to wait until it is running (which it never does because the database cant be opened)

use your systems python to call the script to add an app, it only requires the stdlib so you shouldnt need anything else

Here's what I get: `python src/update_notifier.py add -l https://apps.apple.com/us/app/tiktok/id835599320
please ensure DATABASE, BOT_TOKEN, and CHANNEL_ID are defined in the environment`

Btw, I have specified these in the .env file and renamed it from .env.example. Here's whats inside of it:
DATABASE=./data.db BOT_TOKEN=6097140980:AAHrjWCNyFrxgtC1neHkRVhF0-3s57xxxxx CHANNEL_ID=20697xxxxx

alr then you could simply leave the container running and, for example, use:
podman-compose exec update-notifier python /src/update_notifier.py add -l https://apps.apple.com/au/app/pinterest/id429047995

exec update-notifier python /src/update_notifier.py add -l https://apps.apple.com/au/app/pinterest/id429047995

Here's what I get when trying to run it with docker-compose (i dont use podman):
Error response from daemon: Container b2a5712ed18c7856ddc6fa9b368c3ddd7dca5fbca207d3df4b42b7f1631703e9 is restarting, wait until the container is running
I've tried restarting the container multiple times...

exec update-notifier python /src/update_notifier.py add -l https://apps.apple.com/au/app/pinterest/id429047995

Here's what I get when trying to run it with docker-compose (i dont use podman): Error response from daemon: Container b2a5712ed18c7856ddc6fa9b368c3ddd7dca5fbca207d3df4b42b7f1631703e9 is restarting, wait until the container is running I've tried restarting the container multiple times...

huh?
start over -- stop and remove the container, remove the database file, touch it again, then start the container
check its logs just to be sure theres no errors

exec update-notifier python /src/update_notifier.py add -l

Thank you this seems to have solved the issue


Godeni village component of Godeni is not found in Arges county

Precondition
SOLR: http://zimbor.go.ro/solr/#/romania/query
browser: Chrome
Steps to Reproduce:

Step
Action
Expected
Status

1
open SOLR in browser
SOLR UI is loaded without any errors
Pass

2
type one by one in the q field all the list of the components of every village in Arges county found in test data
you are able to type one by one in the q field  all the list of the components of every village in Arges county found in test data
Pass

3
type judet: Arges in the fq field
you are able to type judet:Arges in the fq field
Pass

4
click on Execute Query button
Verify that all the list of the components of every village in judet:Arges form the test data are displayed
Fail

Actual Results:
Godeni village component of Godeni is not found in Arges county

Open defect in TestQuality D74

Test List of the components of every village in Arges county in Run Run 6 (linked to Cycle Sprint 1).

Este satul Godeni, in Godeni


Fixt bug

Make "HMSS" an instance variable   HH:mm:ss, S

Hi @RafMo20D Thanks for contribution! What's is the purpose of that change? What problem you're trying to solve?

Thanks  @ArtsiomCh  Fixt bug  The problem is the clock of two betrayed  HH:mm:ss,S
H:mm:ss,S

SimpleDateFormat dateFormat = new SimpleDateFormat("dd-MM-yyyy HH:mm:ss:aa");
System.out.println(dateFormat.format(fromDateTime.getTime()));
System.out.println(dateFormat.format(toDateTime.getTime()));

Thanks @ArtsiomCh Fixt bug The problem is the clock of two betrayed HH:mm:ss,S
H:mm:ss,S

Why do you think there is a bug/problem here?
Variable HMSS is not used anywhere and even if used - it's just for internal debug logging
So, probably proper fix here will deleting HMSS at all...

yes deleting HMSS at all  And you, what do you think is better? I want to know something new

Please verify the code before committing. mmssSSS we still using in the code. Only HMSS (whole line) need to be deleted (probably with usage in committed code below in the file).
Also could you please remove/squash all unrelated commits?

Please verify the code before committing. mmssSSS we still using in the code. Only HMSS (whole line) need to be deleted (probably with usage in committed code below in the file). Also could you please remove/squash all unrelated commits?

ok Thanks

The whole line was debug deleted and everything worked

Good try, but no and you know why.


Question: How to install pretty print and beautiful tracebacks permanently in python REPL

As of now when I run
>>> from rich import pretty
>>> from rich.traceback import install
>>> install()
>>> pretty.install()

This only enables it for the current session, but I want it permanently.

You cat put that in your Python startup file. Create a .py file with those lines and set the environment variable PYTHONSTARTUP to point at it. See docs.

Thanks.


Add parametrizeble release name

Today, release names take the generated version name. It would be interesting if people could override this name completely or add a preffix in version name pattern.

Closed by #31


Cannot use new Polaris Button design

When using the Polaris Button as described in the docs, I don't get the latest design of the button. I created another app with the template to see if any of my dependencies were colliding with Polaris, but the result was the same.
The problem doesn't seem to be specific to the Button component either, because the primary- and secondaryAction of the PolarisModal give the same, wrong button design.
I have the latest version of Polaris installed (13.9.1).

Desired Button

Button I get
I am very curious if this is a common problem.
Thanks in advance.

Alright thanks a lot. But I guess the long-term solution is to just do everything over with remix. Appreciate the help.

Alright thanks a lot. But I guess the long-term solution is to just do everything over with remix. Appreciate the help.

For you I'm not going to learn Remix. Especially now that it was merged into React Router V7 maybe will update to Remix if the official Remix template is updated to new React Router. In our app client-side rendering provides a better user experience. So, I prefer to use node-template.


User Guide [Enhancement]

Enhancements:

add section: About this guide
add section: About user interface
add section: Glossary

References:
https://cs2103jan2018-w13-b1.github.io/main/

Added


C# only: specify rounding modes explicitly

... so that they match the (SSE2 optimized) C++ version as accurately as possible
resolves #656 (at least partly)

AngusJohnson closed this 51 minutes ago

Hmm, not sure what was wrong with this one?

Can think of at least the following reasons:

Issue 656 is not worth fixing to begin with
It should be the C++ code that is made to match the C# code, and not the other way around

If it's the latter, let me know and I can try to create an alternative PR.
If it's the former, that's fine too – then we'll just continue using our fork of the library, at least for the time being.

AngusJohnson closed this 51 minutes ago

Hmm, not sure what was wrong with this one?

Sorry, my mistake (cleaning up at bedtime).

Oh, no problem. Thank you.


Added Voila dashboards to SD build package list. Fixes Xilinx/PYNQ-Dev#309

Codecov Report

Merging #1236 (284b4e1) into image_v2.7 (635f8e5) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           image_v2.7    #1236   +/-   ##
===========================================
  Coverage       47.61%   47.61%
===========================================
  Files              25       25
  Lines            4646     4646
  Branches          773      773
===========================================
  Hits             2212     2212
  Misses           2381     2381
  Partials           53       53

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 635f8e5...284b4e1. Read the comment docs.


cancellable music search

after $play <search query>, allow $cancel to stop selection

closed by cf8ecb4, deployed


Migrate to conan instead of aqt-install

new conan v2 Qt6 was merged we can migrate to use it. https://github.com/conan-io/conan-center-index/pull/17539#event-9505668295

WIP here: https://github.com/omortie/qtgql/tree/WIP-262-Migrate-to-conan-instead-of-aqt-install
there is still a problem with building tests here: tests/test_codegen/generated_test_projects/ScalarsTestCase/graphql/__generated__/CMakeLists.txt:27 (qt_policy)
that says:
QTP0001 is not a known Qt policy.  Did you include the necessary Qt module?
also I've used this code to install and build with conan:
export NOT_ON_C3I=1
poetry run conan build . -o test=True --build=missing

it seems it needs to also bind to qtdeclarative and qtquickcontrols as described here: https://stackoverflow.com/a/67615177/9751735

build times with conan takes decades. we're unlikely to support that. users ought to supply Qt themselfes...


Add test and type annotations for LongNamesConverter

Continuation of #660
Closes #693

Pull Request Test Coverage Report for Build<PHONE_NUMBER>8
Details

13 of 13 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.001%) to 93.551%

Totals

Change from base Build<PHONE_NUMBER>7:
-0.001%

Covered Lines:
7253

Relevant Lines:
7753

💛  - Coveralls

I would prefer to import the classes from typing instead of just the module because when raising the minimum python version to 3.10, these type annotations can basically be lowercased, but I'm fine with the patch.

there's a conflict of typing.Optional and textparser.Optional. We can change when 3.10 is the minimum supported version.

okay. I would go to import Optional from typing and use textparser.Optional where the other Optional is needed. Anyway, the proposed solution is fine IMO, so I'll merge...


I can't download the dataset. it is downloaded slowly.

does this (https://www.cs.ubc.ca/research/tcc/) working for you?  try using axel.


ML 3:2: k-means Clustering (V)

Description
Description
📌  Issues for Week 3
Welcome to 'ML' Team, good to see you here
:arrow_forward: This issue will helps readers in acquiring all the knowledge that one needs to know about ----
k-means Clustering.
:red_circle: To get assigned to this issue, add your Batch Numbers mentioned in the spreadsheet of "Machine Learning", the approach one would follow and choice you prefer (Documentation, Audio, Video). Please note this issue is for VIDEO contribution only
✔ Domain : Machine Learning
:red_circle::yellow_circle: Points to Note :

The issues will be assigned on a first come first serve basis, 1 Issue == 1 PR.

"Issue Title" and "PR Title should be the same. Include issue number along with it.

Changes should be made inside the Machine Learning/Machine_Learning/Supervised_Machine_Learning Branch.

Follow Contributing Guidelines & Code of Conduct before start Contributing.

This issue is only for 'GWOC' contributors of 'Machine Learning' domain.

:white_check_mark: To be Mentioned while taking the issue :

Full name
Batch Number
GitHub Profile Link
Which type of Contribution you want to make :

[ ] Video

Happy Contributing 🚀
All the best. Enjoy your open source journey ahead. 😎
Domain
Machine Learning
Type of Contribution
Video
Code of Conduct

[X] I follow Contributing Guidelines & Code of conduct of this project.

/assign

Hello, I would like to work on this issue
Name: Shubham Patel
Batch: 1
GitHub id: https://github.com/ShubhamPatel01
Approach: What is k means clustering, how to implement it, and applications of k means clustering algorithm.

Sorry @m0hit-kumar  you've been unassigned due to violating the rules of not to use /assign

@ShubhamPatel01 This is a video contribution, would you like contribute in this?

@ShubhamPatel01 This is a video contribution, would you like contribute in this?

Yes, I would like to contribute

@ShubhamPatel01 Amazing! This issue has been assigned to you. Please make sure that you complete the work and make a PR within 3 days.

@geeythree can you elaborate what I did wrong or what violation."To get assigned to this particular issue please use /assign ". I just follow this

@mohit355 Hey, we had asked all the contributors in ML domain to comment on the issues to get them assigned. The thing is, in some cases somebody might have already commented on the issue and a new person might just come in and self assign the issue, then the first person to have commented would not get a fair chance. We just want to make it fair for everyone. There are plenty more issues that you could contribute to. Please check them out. 😄

@mohit355 Hey, we had asked all the contributors in ML domain to comment on the issues to get them assigned. The thing is, in some cases somebody might have already commented on the issue and a new person might just come in and self assign the issue, then the first person to have commented would not get a fair chance. We just want to make it fair for everyone. There are plenty more issues that you could contribute to. Please check them out. 😄

but here I was the one to comment first.

@mohit355 Hey, we had asked all the contributors in ML domain to comment on the issues to get them assigned. The thing is, in some cases somebody might have already commented on the issue and a new person might just come in and self assign the issue, then the first person to have commented would not get a fair chance. We just want to make it fair for everyone. There are plenty more issues that you could contribute to. Please check them out. 😄

but here I was the one to comment first.

Please check the discord pinned messages, you will understand why you were not given the issue.


Fix/android attestation validity

Add AttestationValueException.Reason.TIME to indicate too far off or missing attestation statement creation
time inside the attestation statement (in contrast to Certificate validity issues)
Add attestationStatementValiditySeconds to Android attestation configuration, to set a custom attestation statement
validity.
Defaults to 5 minutes (i.e. 300)
Fix verification time calculation

Will publish as 1.7.0 once merged


Macro Expression Bug

We get an error if we embed expressions like x +2y in macro calls. This can probably be resolved in combination with #5.

This has been resolved in the latest version of the JuMP-0.20.1 branch


Make a self-contained Repo

Hello @mr-mig,
This Repo is a good idea! Congrulations!
I have  a comment, why don't we a self-conteined Repo? Without links. That mean that instead have link to external web page, we should have information inside the repo.
I could help with Spanish translation if you consider it interesting.
Regard!

Hi @eamanu
I think this is a great idea as well.
However, the questions I have are:

What shall we do with the videos and papers? Those are only available in English mostly.
What shall we do with books? Shall they have links to corresponding translated books?
What benefit do you see in a self-contained repo?

Hi @mr-mig

There are material in Spanish. We just need found it.
That is a problem
I think that is better have all the information inside a repo and not links to external webs

I do not see much value in creating self-contained repo taking into account all related problems.
Make it in a fork if you think it's valueable


Identity guidance

A new document that provides clear guidance on how to determine the right auth solution. Based on requirements, will explain the trade-offs associated with deciding between self hosted (ASP.NET Core Identity), managed (Azure AD) or third-party solutions (i.e. when an on-premises OIDC server is required).
Parent: #29452

My goal with this document is to provide a clear set of guidelines for choosing solutions to manage identity for web apps written in .NET. Most of it likely it will be in the "matrix style" with options and requirements so as a developer you can pick the row that addresses the majority of your requirements.
I propose the following solution buckets:

Self-host with simple sign on - ASP.NET Core Identity and related APIs
Self-host with requirements that lead to an OAuth Server - use the ASP.NET Core Identity management solutions document to find the right solution
Managed (Microsoft) - Microsoft Entra solutions, link to their ASP.NET specific guidance
Managed (other) - same page, follow vendor guidance

For the matrix, I plan to pivot on:

Do you handle settings and options via interactive code, or do you prefer configuration and/or environment variables, or perhaps something more specific like Azure Key Vault?
How much customization do you need or are able to do? (legacy app that is locked in vs. app you have more control over)
Do you need to support external and/or "social" authentication?
Do you need custom logic in your authorization flows?
Do you need easy and straightforward access to the authenticated user's name or other identity-specific credentials?
How do you handle consent?
Is cookie-based auth fine or do you need tokens?
How important are refresh tokens to your user experience?
Do you need single sign on between environments (development and test for example)
Do you need support for clients in multiple languages and platforms?
Will mobile applications require access to your APIs?

What else influences your decision to go with a particular identity management solution?
This issue will track the progress of the new "guidance document", and also serve a place for our developer community to provide thoughts and feedback for our consideration. The ASP.NET Core team is committed to delivering improved documentation in the .NET 8 timeline. I also appreciate when those of you who own or coordinate a project or solution in this space provide feedback and help us improve what and how we deliver features that support the requirements in your product or service offerings.
/cc @damienbod @brockallen @kevinchalet

Thanks for this @JeremyLikness   I am looking forward to seeing the end product.

This is great

These are all important considerations and I thank you for you efforts.  When working with clients, the question of authentication is always the first that needs to be answered.  To implement my designs, I need custom logic in authorization flows.

Where to store tokens for SPAs. localStorage/sessionStorage/cookie, or use auth cookie and save it in backend (like BFF)

Hi @JeremyLikness If you are creating docs about choosing an identity management solution and then authentication based on this environment, maybe you should also include docs about FIDO2/passkeys and ID-tech solutions (self sovereign identity SSI based). The security context is most important when choosing a solution, not just the technical implementation.
Greetings Damien


[BACKLOG-27573] - Temporarily managing scope of OSGi core to compile …

…here to include it in all pdi lib assemblies.
Note: Only merge after https://github.com/pentaho/pdi-osgi-bridge/pull/69 changes have been BUILT by Ciren so that the new pdi-osgi-bridge dependency tree is available.

Build Skipped
:white_check_mark: There was nothing to build. The changes are probably excluded by the build rules. If this is an error, please contact your system administrator.


Recurring events

First of all, thanks for an awsome extension!
I would like to suggest the possibility to create recurring events such as birthdays, dailys etc.
NB! I don't know how to tag this issue as an enhancement.
Cheers!
/Mike

Just fyi, you can extend the Calendar by providing your own event source, in case you are interested in building this feature :) There is an example of a contributed event source here.

Thanks!
I guessed that contributing would be possible since it's the whole idea of open source (GitHub).
But It has been years since I coded som I am a bit afraid that I will ruin something. ;)
I might look in to it once I built up some courage, It would actually be fun to build!
Cheers Trevor!


Fred ans/fix sym

To correctly compute the Sym() value, we needed more info back from MAPDL. It has been fixed from gRPC API Release 0.5.0

We're going to need v0.5.1 from https://github.com/ansys/ansys-api-mapdl (pending database proto).
Let me know when the database proto has been added and I'll push a release (or German).

@akaszynski  I think the 0.5 is the version where @FredAns fixed this issue.

@akaszynski I think the 0.5 is the version where @FredAns fixed this issue.

True.


Fix spurious rebuilds when switching source paths

The method of creating package ids in Cargo means that all sub-crates of a main
repo have the same package id, which encodes the path it came from. This means
that if the "root crate" switches, the package id for all dependencies will
change, causing an alteration in package id hashes, causing recompiles.
This commit alters a few points of hashing to ensure that whenever a package is
being hashed for freshness the source root of the crate is used instead of the
root of the main crate. This cause the hashes to be consistent across compiles,
regardless of the root package.
Closes #1694

r? @wycats
(rust_highfive has picked a reviewer for you, use r? to override)

r? @brson

@bors r+

:pushpin: Commit ddf3c79 has been approved by brson

:hourglass: Testing commit ddf3c79 with merge 1ae683a...

:sunny: Test successful - cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-gnu-32, cargo-win-gnu-64


[release-1.7] Increase receivers memory requests

Backport of #2950
(auto cherry-pick had merge conflicts https://github.com/knative-sandbox/eventing-kafka-broker/pull/2950#issuecomment-1425710333)

@pierDipi @matzew: In 1.7 we didn't define any requests at all. Any objections on still backporting it?

1.7 is not supported upstream anymore, only the last 2 releases are supported (1.8 and 1.9)

1.7 is not supported upstream anymore, only the last 2 releases are supported (1.8 and 1.9)

:+1:


Aggregation fuzzer

Which issue does this PR close?

Part of #12114
Rationale for this change
The aggregation fuzz tests maybe not enough, becasue there are so many optimizations in aggregation in datafusion.
For improving the testing, the first thing to do may be building a framework to make creating testcase easier.
This pr aimed to introduce such a framework.

What changes are included in this PR?
Design an AggregationFuzzer to make creating testcases for aggregation easier.
Two key components in AggregationFuzzer  are DatasetGenerator and SessionContextGenerator.
In AggregationFuzzer(with a deinfed query represented by sql currently):

Multiple datasets will be generated by DatasetGenerator firstly.

And then for a specific dataset, multiple SessionContext with the random params about aggreagtion, and a baseline SessionContext will be generated.

Still for the specific dataset, each randomly generated SessionContext + basline result(generated from dataset + basline SessionContext) will be used to build AggregationFuzzTestTask.

In AggregationFuzzTestTask, we will run the query with dataset + related SessionContext, then we compare the result with basline result. If inconsistency found, report it and panic.

Finally, all AggregationFuzzTestTasks will be run in parallel in AggregationFuzzer

Are these changes tested?
Test by uts.

Are there any user-facing changes?
No,

😍 😍 😍 😍

Rest works:

[ ] Rewrite more cases through fuzzer
[ ] Refine the error handling

@alamb I found the new fuzz cases failed after I rebase main.
I try to revert #12623 , and tests passed again, but I am still not sure what is wrong...

I found the reason and have submitted a pr to fix it https://github.com/apache/datafusion/pull/12758

I found the reason and have submitted a pr to fix it #12758

Testing for the win!

I see this one is ready for review. I plan to do so carefully tomorrow

I think this is good to go other than maybe making it a bit shorter to run
Before we merge it it would be nice to add:
1. A list of some additonal tests (first maybe would be good to get additional coverage for other agrgegates)

Is it ok to list such tests in todos comments in aggregate_fuzz.rs?
// ========================================================================
//  The new aggregation fuzz tests based on [`AggregationFuzzer`]
// ========================================================================

// TODO: write more test case to cover more `group by`s and `aggregation function`s
// TODO: maybe we can use macro to simply the case creating

/// Fuzz test for group by `single int64`
#[tokio::test(flavor = "multi_thread")]
async fn test_group_by_single_int64() {

@alamb I have added tests to cover more aggregations:

basic prim aggr(sum/sum distinct/max/min/count/avg)
basic string aggr(count/count distinct/min/max)

I make it through the simpel implementation about randomly select sql memtioned in https://github.com/apache/datafusion/pull/12667#issuecomment-2399675682

it will randomly select a sql for each dataset
then run CTX_GEN_ROUNDS(now 16) randomly SessionConfig on specific dataset + selected query

Now the testcase may be like:
    // Build fuzzer
    let fuzzer = builder
        .data_gen_config(data_gen_config)
        .data_gen_rounds(16)
        .add_sql("SELECT sum(a) FROM fuzz_table")
        .add_sql("SELECT sum(distinct a) FROM fuzz_table")
        .add_sql("SELECT max(a) FROM fuzz_table")
        .add_sql("SELECT min(a) FROM fuzz_table")
        .add_sql("SELECT count(a) FROM fuzz_table")
        .add_sql("SELECT count(distinct a) FROM fuzz_table")
        .add_sql("SELECT avg(a) FROM fuzz_table")
        .table_name("fuzz_table")
        .build();

And unforunately, seems a new bug about min/max for string found... Maybe we to check and try to fix it in other pr.

And unforunately, seems a bug about min/max for string found... Maybe we should check and try to fix it in other pr.

Yes, let's handle that as a separate PR / issue.

Thanks again @Rachelint  -- this is so great

I am working on filing the error that this found for min/max

I also have some ideas on how to improve the error reporting here

I also have some ideas on how to improve the error reporting here

Nice, the error reporting is indeed not so readable currently

I also have some ideas on how to improve the error reporting here

Maybe #5131 will help? The error seems similar.

https://github.com/apache/datafusion/pull/12832 has a proposal for improved error reporting

BTW this found another bug in https://github.com/apache/datafusion/pull/12792
See https://github.com/apache/datafusion/actions/runs/11272685143/job/31348663515?pr=12792
❤


Vulnerability roundup 85: botan-2.7.0: 2 advisories [5.9]

search, files

[ ] CVE-2018-12435 CVSSv3=5.9 (nixos-20.03, nixos-unstable)
[ ] CVE-2018-20187 CVSSv3=5.9 (nixos-20.03, nixos-unstable)

Scanned versions: nixos-20.03: a84b797b28e; nixos-unstable: 22c98819ccd. May contain false positives.

CVE-2018-20187 - up to excluding 2.9

20.03 is Frozen and EOL.
... and master is merged.
As such, issue is closed.


[ESD-2251] Automatically set compile options when creating tests

I'm constantly forgetting to call swift_set_compile_options after creating a test which very often leads to linker errors due to mismatched RTTI flags.
Always call swift_set_compile_options with no arguments when creating a test. This doesn't prevent this function from being called separately should the creator of a test really need to customise compiler flags.
This is pretty much the same thing as already happens for swift_set_language_standards

@woodfell merge?


Blob digest not available before saving the first document version

Hi @blaugold,
sry for bothering you again about a question regarding a feature change from 0.6.0 to 1.0.0:
When we save a document with an attachment, we need already to know the complete Blob entry including the digest (for adding an overall digest to the document). That was possible in 0.6.0 after performing db.blobManager.createBlob.
However, in version 1.0.0 the digest is created during the save process of the document itself. Unfortunately, we are only allowed to write the document once due to our use case. Do you have any idea about a workaround to get the full blob document entry already including the digest before saving the first version of the corresponding document? Thank you very much :)

P.S. We were already thinking about creating a dummy document with the blob first and then "re-linking" the blob to the other document where we need to add the overall digest. Not sure, whether that would work.

Hey @nblum37,
No problem, thanks for sticking with this library. :+1:
As a workaround, saving a dummy document to calculate the digest works. Blobs with the same digest are shared between documents.
I'll add methods to Database to save and retrieve Blobs. The Couchbase Lite SDKs for the other Platforms already have those.

Ok nice! Thank you very much and looking forward to it :)

Thank you very much for the new version, it's working great!
Maybe one add-on, that we just realized, when using the new functionality:

The Blob entry within the CB server looks like the following (with one additional entry)

Requesting the Blob with doc.blob('attachment').properties in the mobile app leads to the following entries

However accessing the Blob properties via json.decode(doc.toJson())['attachment'] as Map<String, dynamic> lead to the wanted result

I guess, it would be really complicated to extend the properties return by some customized fields. But maybe there is the possibility to access the "raw" entries by something like doc.dictionary('attachment').toPlainMap? So no real need from our side, as we found the shown workaround. But maybe as a kind of idea for one of your upcoming releases, if you think it's worth it and not too much effort. And of course I would be a little bit happy to get rid of the ugly JSON workaround :D
BR @nblum37

I was going by the other SDKs (for Swift, Java, etc.) and they don't provide access to properties which are not Blob metadata. Seems to me like users are not meant to store additional data directly in the Blob dictionary. That's why I would rather not expose custom properties through Blobs.
If possible, it would be a good idea to migrate those custom fields out of the Blob dictionaries and tread Blobs like scalar values.

Ok, that makes completely sense. Thanks for the evaluation and feedback!


Transfer to other Datasets

Hi,
Can TransPose be transferred to other datasets, e.g. MPII and PoseTrack? If yes, how should I perform the fine-tuning?
Many thanks in advance!

Yes, please see this version for reference.

Thanks for the response! I have read this update version and seen that pretrained TransPose models can be successfully transferred to MPII dataset.
I am trying to transfer TransPose to PoseTrack dataset and I have a few questions about the details:

Should I prepare PoseTrack dataset and annotations just like preparing COCO described in README?

In PoseTrack, there're only 15 keypoints annotation (left_ear and right_ear are excluded compared to COCO). To transfer TransPose to PoseTrack, I try to replace the final layer of the pre-trained TransPose model with a uniform-initialized dx15 linear layer and freeze other parts of the model. Is this the correct way?

How should I correctly conduct the fine-tuning? (I plan to train only the re-initialized last layer for a few epochs, then fine-tune the entire model for a few epochs. )

I suggest following the dataset preparation of mmpose for Posetrack.
Yes. You also can use a smaller learning rate for the pre-trained layers.
Your plan seems to be effective. And setting different learning rates for pre-trained layers and the final layer might work well.

Thanks for your suggestion!


Bug: in-progress outgoing payment isn't included in payment list

Current behaviour
If list_payments() is called while send_payment() is running, the payment list doesn't include the new outgoing payment.
Expected behaviour
If list_payments() is called while send_payment() is running, the payment list includes the new payment with status PaymentStatus::Pending

Taking this up if no one has yet

Its yours!

I realized that calling sync() between the start of the payment and getting the payments list effectively circumvents the issue. I assume that syncing within the implementation of list_payments isn't a desirable fix as it makes the method rely on network requests, which up until now it doesn't. Am I correct in this assumption?

Yes, correct.

Can we close this @danielgranhao @dleutenegger  ?

Closing as per confirmation above.


Add docker and postgres service

Description
We need to create a docker with PostgreSQL database service for a dev environment

@Rodrigo-Dev123  Mandando a task para review. Dá uma olhada no PR 👆  e da merge ! 🚀


[BUG] Regression: Apktool tries to load unexpected framework packages

A new issue with 2.8.0 and 2.8.1-SNAPSHOT, whenever decompiling an APK, it now calls "getPackage" (and then "loadFrameworkPkg") on arbitrary IDs instead of just loading the framework packages the APK depends on.
Don't have much information about this, still investigating myself where those IDs are coming from, but here's a piece of logging I added to both 2.8.1-SNAPSHOT and 2.7.1-SNAPSHOT for an obvious demo:
(same APK, left is 2.8.1-SNAPSHOT, right is 2.7.1-SNAPSHOT)

cc @sv99 - might be related to recent refactors you did.

One important point to mention, those unexpected getPackage/loadFrameworkPkg calls are happening between multiple stages while there are none of those calls in 2.7.1. If the output is saved to a file, it's a whopping 1.35MB of junk:
Apktool_2.8.1-SNAPSHOT.txt


type change for AF_INET, PF_INET  AF_INET6 PF_INET6

I am not sure if this change is enough or more is needed fo #468

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
Please see the contribution instructions for more information.

:umbrella: The latest upstream changes (presumably #1793) made this pull request unmergeable. Please resolve the merge conflicts.

Hey, thanks for the PR! But this is a breaking change, as Alex said, and I'd hold off this as we currently have no plan to make a release 0.3 or 1.0.

ok. Thanks for taking a look.
Any other ways I could contribute   ?

Any other ways I could contribute ?

Basically we add items when we need them. There're some requests on the issue tracker that someone wants to use constants or functions, I think they're good stuff to contribute (btw, if you want to contribute to Rust, there're some repos like rust-lang/rust that have more newcomer welcome issues).

:umbrella: The latest upstream changes (presumably #1962) made this pull request unmergeable. Please resolve the merge conflicts.
Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels:
@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author

Even if we were making breaking changes, I don't think we'd want to change the types of these particular constants and not others in the same category.
In C, these are preprocessor symbols, and they don't have a type. I don't think this kind of change is worth the breakage it would cause.

Even if we were making breaking changes, I don't think we'd want to change the types of these particular constants and not others in the same category.
In C, these are preprocessor symbols, and they don't have a type. I don't think this kind of change is worth the breakage it would cause.

Now this can be resent to libc 0.3


[KERAS]Upsample3d & ZeroPadding3d op

UpSample3d & ZeroPadding3d Frontend op for Keras
@FrozenGene please help to review this PR.
TIA
Thanks for contributing to TVM!   Please refer to guideline https://docs.tvm.ai/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers by @ them in the pull request thread.

cc @FrozenGene @Huyuwei @srkreddy1238 please help to review the PR

@siju-samuel Thanks, this is merged!


get inspired !

http://orange.biolab.si/

http://googleresearch.blogspot.ch/

test

maybe there is some interesting material on http://icml.cc/2015/

This seems to be interesting too http://www.jmlr.org/

https://en.wikipedia.org/wiki/Inductive_logic_programming

A lot of resources are linked on this page: https://www.quora.com/What-are-some-good-resources-to-learn-about-data-science-case-studies-use-cases-and-white-papers-implemented-in-various-industries

Moved to the projects list of references


Test Agent not using ResultsDirectory in .runsettings file

We're using a .runsettings file with the  'Visual Studio Test using Test Agent' build task:
<RunSettings>   <RunConfiguration>     <ResultsDirectory>C:\TestRuns</ResultsDirectory>     <TargetPlatform>x64</TargetPlatform>     <TargetFrameworkVersion>Framework45</TargetFrameworkVersion>   </RunConfiguration> </RunSettings>
We expect Test Runs to use the C:\TestRuns directory however it is using the %Temp% directory instead.
It looks like the .runsettings file was used based on the fact that setting the TargetPlatform to 'x64' was apparently effective. Also, using the same .runsettings locally in Visual Studio configured the directories as expected to "C:\TestRuns".
Is there something missing to be configured on the Test Agent or task?

Ack: I was able reproduce this issue.

Hi TestO2015,
This behavior is by design.
Any specific reason why you are interested in having a specific results directory location?

Hi AshwiniChalla,
When the %TEMP% directory is used the the 260 character path limit is exceeded.
We were able to work around this for most of the Test Run directories by changing them using the TestContext object during TestInitialize. What remains is the TestContext.DeploymentDirectory as it is created before the TestInitialize. We could probably work around this too but it doesn't sound ideal.
Would be interested to know the reason behind the design! Thanks.

There is no other way to configure the test run directories as of today.
We will look to fix this. Added to our backlog.

I was able to set the Results directory by adding an "Override TestRun Parameters" to "ResultsDirectory=.\TestResults".  This created the TestResults directory in the directory above the Build_SourcesDirectory.

MattHanMS, did you achieve this using the "Run Functional Tests" task, or the "Visual Studio Test" task? Was this with TFS 2015 Update 2?

This was using the ‘Visual Studio Task’.  I believe it was with TFS 2015 Update 2, but can’t confirm.
From: Chris Breitner<EMAIL_ADDRESS>Sent: Friday, June 16, 2017 2:40 PM
To: Microsoft/vsts-tasks<EMAIL_ADDRESS>Cc: Matt Hanson<EMAIL_ADDRESS>Comment<EMAIL_ADDRESS>Subject: Re: [Microsoft/vsts-tasks] Test Agent not using ResultsDirectory in .runsettings file (#1207)
MattHanMS, did you achieve this using the "Run Functional Tests" task, or the "Visual Studio Test" task? Was this with TFS 2015 Update 2?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2Fvsts-tasks%2Fissues%2F1207%23issuecomment-309140346&data=02|01|matthan%40xbox.com|4581a4ce2c4646d6b04f08d4b5003dc3|72f988bf86f141af91ab2d7cd011db47|1|0|636332460038151241&sdata=jXsneEUVe%2FTKF9g0bH4EhBYFtpjHJM14ne8TAKc7H60%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAQxBETnofVwv6Qmh5RuRcWTDvg1pCakgks5sEvYvgaJpZM4HXFW7&data=02|01|matthan%40xbox.com|4581a4ce2c4646d6b04f08d4b5003dc3|72f988bf86f141af91ab2d7cd011db47|1|0|636332460038151241&sdata=NwCEnyR2ZuRMITDIZz6eIk4TfG6ZfuBQUVr7iDOorek%3D&reserved=0.

This behavior is by design.

That response makes no sense. There's a property called ResultsDirectory and it's documented as being where the test results go. Therefore it cannot be "by design" that they go somewhere else.

Any specific reason why you are interested in having a specific results directory location?

This sort of question is so annoying ... there are numerous well-known reasons why people want to keep generated files out of their source folders.

I was able to set the Results directory by adding an "Override TestRun Parameters" to "ResultsDirectory=.\TestResults". This created the TestResults directory in the directory above the Build_SourcesDirectory.

I'm not sure how this could possibly work.


Hosted mode annotation fix bug

I made a mistake previous pr. I wanted to fix annotation arg.
Signed-off-by: Yi Rae Kim<EMAIL_ADDRESS>

/cherrypick release-2.8


SQLite Authentication Issue

Describe the bug
While Configuring SQLite Connector, Test Connection is running successful even if we enter any wrong value or leave empty all values of the form
To Reproduce

Expected behavior
Authentication layer has to provide for SQLite connector which authenticate credentials are valid or not. If Credentials are valid test connection should be successfull otherwise it should failed.
Version:

OpenMetadata version: 1.1.0

I will take care of this issue.

@pmbrull @vanshika18 , is this issue resolved?


Error with -fsanitize=alignment

Related WebRTC bug: https://bugs.chromium.org/p/webrtc/issues/detail?id=11405
The issue is with sctp_getaddresses, when casting addr to a sockaddr_conn.
On a 64 bit system, sockaddr_conn is 8-byte aligned due to one of its members being a pointer. However, sockaddr is only 4-byte aligned, so the compiler doesn't know it needs to insert four bytes of padding.
Fix on the way.

Is this a compile time or run time thing? Which compiler does provide it?

@tuexen It's a compile flag which detects undefined behavior at run time, similar to the memory and address sanitizers.
Supported e.g. by clang
https://clang.llvm.org/docs/UndefinedBehaviorSanitizer.html#available-checks

@weinrank This means we need to use it in one of the examples on the buildbots (assuming that we run the undefined sanitizer there).

Yep! 👍

I have committed a change to ekr_loop such that it triggers the bug on our buildbots. Next step is to fix it.

Reminder that I have a PR: https://github.com/sctplab/usrsctp/pull/438/files

Fixed by https://github.com/sctplab/usrsctp/commit/63d620ae9ab818cf51448c9ad0a04f9688c5f28b after cleaning up sctp_bindx(). Thanks for reporting and providing a patch!


Come up with a different name

Make sure the new name does not already exist on PyPI

nectar?
amrit(a)?

nectar it is


Should canvasBounds be required?

In https://github.com/phetsims/greenhouse-effect/issues/255#issuecomment-1382591012, we found that photons did not render in the screenshots because canvasBounds was not being passed through.  There are 3 places where canvasBounds is in the options, but it is optional each time.  Should it be required?

It definitely seems like an option where things shouldn't take up "no" bounds... "infinite" bounds doesn't really work too well either. To me it makes sense to be required.

Here's a patch that attempts to make it required:

Subject: [PATCH] Reuse model values for rewind property, see https://github.com/phetsims/gravity-and-orbits/issues/459
---
Index: main/scenery/js/nodes/WebGLNode.ts
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/main/scenery/js/nodes/WebGLNode.ts b/main/scenery/js/nodes/WebGLNode.ts
--- a/main/scenery/js/nodes/WebGLNode.ts	(revision 6e34d8cdeacbcc82f64c1a7bbc4d537bdd94bc14)
+++ b/main/scenery/js/nodes/WebGLNode.ts	(date<PHONE_NUMBER>992)
@@ -22,7 +22,7 @@
 ];

 type SelfOptions = {
-  canvasBounds?: Bounds2;
+  canvasBounds: Bounds2;
 };

 export type WebGLNodeOptions = SelfOptions & NodeOptions;
Index: main/scenery/js/nodes/CanvasNode.ts
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/main/scenery/js/nodes/CanvasNode.ts b/main/scenery/js/nodes/CanvasNode.ts
--- a/main/scenery/js/nodes/CanvasNode.ts	(revision 6e34d8cdeacbcc82f64c1a7bbc4d537bdd94bc14)
+++ b/main/scenery/js/nodes/CanvasNode.ts	(date<PHONE_NUMBER>995)
@@ -21,7 +21,7 @@
 ];

 type SelfOptions = {
-  canvasBounds?: Bounds2;
+  canvasBounds: Bounds2;
 };

 export type CanvasNodeOptions = SelfOptions & NodeOptions;
Index: main/bending-light/js/intro/view/WaveCanvasNode.ts
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/main/bending-light/js/intro/view/WaveCanvasNode.ts b/main/bending-light/js/intro/view/WaveCanvasNode.ts
--- a/main/bending-light/js/intro/view/WaveCanvasNode.ts	(revision dff052fa6b7885eae761e6dda060c107a023a584)
+++ b/main/bending-light/js/intro/view/WaveCanvasNode.ts	(date<PHONE_NUMBER>864)
@@ -10,7 +10,7 @@
  */

 import ModelViewTransform2 from '../../../../phetcommon/js/view/ModelViewTransform2.js';
-import { CanvasNode, NodeOptions } from '../../../../scenery/js/imports.js';
+import { CanvasNode, CanvasNodeOptions } from '../../../../scenery/js/imports.js';
 import bendingLight from '../../bendingLight.js';
 import LightRay from '../../common/model/LightRay.js';

@@ -23,7 +23,7 @@
    * @param modelViewTransform - Transform between model and view coordinate frames
    * @param [providedOptions] - options that can be passed on to the underlying node
    */
-  public constructor( lightRays: LightRay[], modelViewTransform: ModelViewTransform2, providedOptions?: NodeOptions ) {
+  public constructor( lightRays: LightRay[], modelViewTransform: ModelViewTransform2, providedOptions?: CanvasNodeOptions ) {

     super( providedOptions );
     this.lightRays = lightRays;
Index: main/scenery/js/nodes/Sprites.ts
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/main/scenery/js/nodes/Sprites.ts b/main/scenery/js/nodes/Sprites.ts
--- a/main/scenery/js/nodes/Sprites.ts	(revision 6e34d8cdeacbcc82f64c1a7bbc4d537bdd94bc14)
+++ b/main/scenery/js/nodes/Sprites.ts	(date<PHONE_NUMBER>989)
@@ -29,7 +29,7 @@
   // testing, etc.). If false, the canvasBounds will be used for hit testing.
   hitTestSprites?: boolean;

-  canvasBounds?: Bounds2;
+  canvasBounds: Bounds2;
 };

 // We don't specify a default for canvasBounds on purpose, so we'll omit this from the optionize type parameter.

There are 15 or so type errors though, with several sim-specific details to work through.  So this could take 2 hours or so, and require assistance for sim devs.

I wrote on Slack #dev-public:

Currently canvasBounds is typed as optional, but failing to provide it means we end up catching bugs in QA instead of during type checking.  I opened this issue to investigate https://github.com/phetsims/scenery/issues/1521, but my subteam’s choice board is filling up and I don’t feel we have time to work on it in this iteration.  But I also don’t want the issue to get forgotten, so I thought I would post it here and see if anyone else wants it.

Self-unassigning.

You can search for canvasBounds? in the code to the places it is optional.  The 3 places are: CanvasNode.ts, Sprites.ts and WebGLNode.ts.

By optional, I mean "it should be required for canvasBounds to work", sorry. But optional as an option, since you can set it with a link, etc., since we don't have the ability to set canvasBoundsProperty with a DerivedProperty right now. We might also want to update it and NOT set it initially.
Presumably we should add an assertion that it needs canvasBounds whenever it's rendered.


HTML5 draggable within a boundary

Hello Marcel,
is there a way how to restrict move boundaries similarly to: http://jqueryui.com/draggable/#constrain-movement ?
Would you consider adding this feature?
Best regards,
Zat

Sorry, this is impossible with native drag & drop, you can even drop the element into other applications.


Drop Make

The project can 100% use maven and should not require make to also be installed for proper usage.
ref: #2
if/when this is merged, the project can be imported, built, and published fully using basic maven commands

nope.


Move cache miss errors to info level

Customer reports spurious error messages for simple cache misses from MSAL. We'll catch those errors and log them at the INFO level instead of ERROR.
This only applies to sync cases. In async cases we already suppress the error entirely.
Fixes #38300

API change check
API changes are not detected in this pull request.


-no-launch option does not work

Running totsugeki.exe -no-launch makes GGST launch anyways. This is on the latest v0.0.3 release.

-no-launch wasn't added until v0.2.0 which is still in pre-release. It should work but has some other bugs that people have reported.


OP-1940: add back removed true

Adding back a pipe to true that was removed in a recent pr.

for reference to the issue: https://github.com/Supervisor/supervisor/issues/1223

reference: https://github.com/CasperLabs/casper-node/pull/899/files

reference: removed here, https://github.com/CasperLabs/casper-node/pull/1220

bors r+


deprecation of Controller.Finish breaks certain test frameworks

Actual behavior
When using the Ginkgo test framework, there's only a single TestXXX function. This function call all other test functions written in the Ginkgo framework. When using gomock, users will need to manually call the gomock.Controller.Finish method after each test.
Expected behavior
gomock.Controller.Finish needs to be available, and needs to remain so in the future. #50 deprecated this function, which makes staticcheck emit errors on my test code. That's ok (I can add nolint directives), but I'm worried that the deprecation is a first step to an eventual remove of Finish, which would break my entire test setup in quic-go. (For the record, I'm not happy with Ginkgo, but that's what we're stuck with for the moment, see https://github.com/quic-go/quic-go/issues/3652).
Given that there are valid use cases of Finish, the function should probably not deprecated at all. Instead, documentation could be added explaining that usually (i.e. when not using any test framework) it's not necessary to call that function.
Additional Information

gomock mode (reflect or source): both
gomock version or git ref: 837f20ad6bc3c8d1ad2128760cd812f2c95ef699
golang version: Go 1.21.1

Triage Notes for the Maintainers

Hey @marten-seemann , thanks for raising this issue.
I believe we have a disagreement on what marking an API as Deprecated entails:
From https://github.com/golang/go/wiki/Deprecated:

In contrast to some other systems, an API feature being deprecated does not mean it is going to be removed in the future.

We merged #50 because we believe that calling ctrl.Finish being no-op means we should discourage users from calling that all the time. We get that it creates inconvenience with linters, etc., but it is a step towards the right direction.
I want to reiterate that marking this as deprecated does not mean that we will be eventually removing it. That is a breaking change, and we don't want to make any breaking changes to any of the public APIs of gomock.


Figure out template partials with Underscore 1.2.x

Our current system of using the this scope for handling template partials seems to be bust with underscore 1.2.2+ changes where this in the context of a template is no longer the templates object. We need a new approach or a way to repair the scope of our template functions back to the templates object.
If we do make a breaking change for this it should belong in 2.x with 1.x staying on underscore 1.x.
/cc @kkaefer @tmcw @willwhite

This is fixed in documentcloud/underscore#372.

Looks like it's made its way into Underscore 1.2.3. Just need to update, test, and release now.


COMPONENT_INFORMATION version metatdata

MAVLink is introducing the component information system that allows a GCS to query PX4 (or other component) for metadata, including parameter metadata, version info, supported mission commands etc. An url to the requested metadata (in a .json.gz file) is returned in response to a COMPONENT_INFORMATION request, which may then be downloaded using MAVFTP or HTTP.
This is a request for advice on how to approach generating and storing the version info metadata file
Example metadata:
{
    "version":                      1,
    "vendorName":                   "QGC MockLink Vendor",
    "modelName":                    "QGC MockLink Model",
    "firmwareVersion":              "1.0.0",
    "hardwareVersion":              "1.0.0",
    "supportedCompMetadataTypes":   [ 0, 1 ]
}

Schema (from MAVLINK#1431)
{
    "$id":          "https://mavlink.io/comp_version.schema.json",
    "$schema":      "http://json-schema.org/draft-07/schema",
    "description":  "Schema for COMP_METADATA_TYPE_VERSION",
    "type":         "object",

    "properties": {
        "version": {
            "description":  "Version number for the format of this file.",
            "type":         "integer",
            "minimum":      1
        },
        "vendorName": {
            "type":         "string",
            "description":  "Name of the component vendor."
        },
        "modelName": {
            "type":         "string",
            "description":  "Name of the component model."
            },
        "firmwareVersion": {
            "type":         "string",
            "pattern":      "^\\d+\\.\\d+\\.\\d+(\\.\\d+)?$",
            "description":  "major.minor.patch.dev format"
        },
        "hardwareVersion": {
            "type":         "string",
            "pattern":      "^\\d+\\.\\d+\\.\\d+(\\.\\d+)?$",
            "description":  "major.minor.patch.dev format"
        },
        "supportedCompMetadataTypes": {
            "type":         "array",
            "description":  "Which `COMP_METADATA_TYPE` specs are supported.",
            "items": {
                "type": "integer"
            }
        }
    },
    "required":             [ "version", "supportedCompMetadataTypes" ],
    "additionalProperties": false
}

Generally the file might be generated at run/boot time and stored on SD card or generated at build time. My leaning is the later.
Broadly wondering:

Where/if the vendorName, modelName, firmwareVersion, hardwareVersion data might be obtained from in the build process? Is it already available in some way and easily tunable for other systems that want to have their own values?
Where a parser to generate this file might best live in the Firmware tree.
Where the file should be copied to for inclusion in firmware.

Was thinking that most of the values are hard coded and you could generate this pretty easily via jinga template replacement.
@bkueng I might find time for this, but having a kick start would be great.

This can be built at runtime if there is somewhere to store the file. Beat mentioned though normally this sort of file would be stored on SD card. If we want it to be available on any system we need ability to store it in RAM (no way to store in the "binary" itself as you can with Qt resource files?). That implies having a virtual RAM drive we can access? I don't know enough about the file system to know what is possible, but I do know that MAVSDK expects to be able to work on files.


[now dev] Error! Your codebase isn’t linked to a project on ZEIT Now.

I just upgraded now and now I get the following on now dev:
Error! Your codebase isn’t linked to a project on ZEIT Now. Run `now` to link it.

Did I understand correctly that I have to deploy a project before I can develop it?

Hi @gadicc
This is the intended behavior.
Now CLI 17.x.x introduced Project Linking so that build and dev commands live in the project dashboard.
You link your source code to a project once and then you can run now dev.

@styfle and how is this done on CI?

You can use the --confirm option to skip these questions.

how to perform codebase link without deploy?

That's not possible at this time. I'll send your feedback to the team, thanks!

Thanks @styfle it will very handy for development purposes

that you're adding steps in to the cli process is disheartening :(

Would be awesome to be able to share my repository with others (public or private) and allow them to use now dev without giving them privileges to deploy. I had to downgrade now to 16.x to work with someone :(
Besides my use case, open-source websites could use now for deployment and allow random contributors to use now dev to emulate the site including its serverless functions API.
I would greatly appreciate it if this use case was considered. now dev is an amazing tool.

While trying to link the projects (which is a step I do not want to do)
I'm getting the following error:
❗  The `name` property in now.json is deprecated (https://zeit.ink/5F)
Error! SHA1 sum of the file (b196187a451fb8eb6c3c89b2097f7154a7c8534c) doesn't match the provided SHA1 sum (2fd6d71392316dae9ef96b0a9324d34b08d14067)

Workaround to run "now dev" (in a private CI for instance) without the interactive deployment or linking:

Copy over the .now directory from your project dir after the project linking process. This contains the project ID.
Run the now dev command with the zeit token like:

$ now dev --token $token_value

Alternatively, you can place the token inside ~/.now/auth.json.

Workaround to run "now dev" (in a private CI for instance) without the interactive deployment or linking:

Copy over the .now directory from your project dir after the project linking process. This contains the project ID.
Run the now dev command with the zeit token like:

$ now dev --token $token_value

Alternatively, you can place the token inside ~/.now/auth.json.

I just tried this, but it seems that now doesn't like that my project is in a sub-directory. So when I run this command now dev --token 1234 I get the message, Error! /Users/me/my-project/web/web doesn't exist I have set the sub-directory in now to web, so it seems now is trying to use that sub-directory, even when I'm trying to use dev locally. I found the DEVELOPMENT COMMAND on the settings page in now.sh, but even setting next dev / as the command there doesn't seem to have any affect when I try to run now dev locally.

Are we suppose to use the --confirm option in our CI deployment ? This changement has broke my CI deployment...

Is there any workaround when --confirm isn't an option for me? Clearly, include .now in git isn't a good practice also.

For next projects I found that just running next works for me.

You link your source code to a project once and then you can run now dev.

Hey @styfle, can you explain why that's necessary? Isn't now dev strictly local?

@aleclarson It is necessary because now dev needs to know what the "Development Command" is and the "Development Command" defined in the Project Settings.
We're looking at a solution to create a Project without actually deploying so that you can run now dev.

Why force a remote "link" to establish Project Settings when now.json is an established pattern for setting configuration?
It seems to me that now should check for the settings in now.json. If there's a link established then it can check there too.
One can override the other; my vote would be that now.json "disables" the fields in the dashboard.

For CI/CD you can also use NOW_ORG_ID and NOW_PROJECT_ID environment variables.
See https://spectrum.chat/zeit/now/solved-project-linking-and-ci-cd-pipelines~5e6eb62a-9d56-47ac-9e32-0d973a523787

I've recently opened up an issue that details my concerns with the current approach and how I believe things should work instead. Since this and my own issue seem to be quite aligned and to avoid having two issues on the topic I'll close my issue and re-post it here as-is.

It has come to my attention that "now dev is moving towards the use of frameworks and other libraries since this is the most common usage". These were the exact words from @paulogdm in a support ticket. I'm not sure if I'm the only one that sees now dev differently but I'm here to explain my use case for now dev, as requested by Paulo.
I currently have my home page deployed to ZEIT Now and I'm not using any framework; it's a basic website built with Gulp.js and I use Browsersync for local development. My website is built with yarn build and there's nothing I need to do to deploy this to ZEIT, Yarn is detected and it uses the build task in package.json with zero configuration.
However, I have a custom now.json configuration file where I have some security headers specified. Now, how do I test this configuration and make sure the headers are properly configured? I could run now and have a preview version deployed and test the headers online, but now dev allows me to do that locally without deploying anything. Currently, I just have to run now dev on the root of my project and a local HTTP server will be available to me, replicating everything as if I were to deploy to ZEIT Now, but without deploying anything.
This feature is awesome and I'm hereby requesting that you don't remove it. Please keep supporting now dev for framework-less projects. I can't be alone using ZEIT Now and now dev without a framework, can I?
As an extension of the above, I have a feature request to improve local development based on now dev. You might have noticed the following in my now.json file above:
"builds": [
  {
    "use": "@now/static-build",
    "src": "package.json",
    "config": {
      "zeroConfig": true,
      "outputDirectory": "dist"
    }
  }
],

I understand that the above is deprecated, however, now dev - on framework-less/custom projects - is defaulting to public and the above was the only way I found that allowed me to change the output directory (I use dist by convention and I really would like to keep it that way).
The same way you allow the BUILD COMMAND, OUTPUT DIRECTORY and DEVELOPMENT COMMAND to be overridden for deployments to ZEIT Now:

I propose that now.json allows one to configure/override those 3 options to be read by now dev at least, if overridden, of course.
What I meant with "at least" above is that these options could also be read by now (or now --prod) and be used to override the UI options in "Build & Development Settings" above. And the UI could reflect that by displaying the overridden option value and changing the toggle to blue (as if it was overridden directly in the UI). However, to avoid having the UI overrides out-of-sync with the now.json options, the input fields and the blue toggles should be disabled (slightly faded out perhaps) not allowing changes in the UI with a little message saying something like "this is overridden in now.json please remove/change it there".
What does everyone think about this?

I think that:

now dev should read package.json and now.json if it/they exists (just like it did before v17)
The cloud should also read package.json and now.json if it/they exists (just like it did before v17)
IF package.json and/or now.json does not exist, the new semantics of this new "project linking" should happen.

So basically, leave it as it was for those of us that have used Now pre-17 and use a proper package.json + now.json approach. We do NOT have a problem that needs solving regarding "how to build the deploy" or "how to configure build and development settings", it is already working. You said it yourselves in the blog post

we're extending this process to non-JavaScript projects

You should've done this without a breaking change to now and now dev regarding "project linking". The way you implemented this with v17 is more like

we're replacing this process for JavaScript projects so that we can better support non-JavaScript projects even though we are making the experience for JavaScript projects worse

Just have "project linking" use the values from package.json and now.json if they exist (in the deployment and locally) (like Now has been doing for quite some time now), if they don't exist you trigger this new "project linking" flow.
I can't imagine the majority of your customers being "non-JavaScript projects" that it would warrant this breaking change to all your "JavaScript project" customers. I mean you have to have more customers deploying Next.js and Gatsby then you have deploying Hugo and Jekyll, no? And even if you don't, why not just improve the experience for non-JavaScript projects without degrading it for JavaScript projects.
Recently it has felt like you have been making the world a better place 2-steps-forward-and-1-step-back at a time 😕

For those grappling with the change breaking their CI, I found a solution and documented it step-by-step in this comment. I'm not sure there is official documentation for that yet, so linking it from here for more people to be able to find it.

@michaellopez there are two issues we are addressing here:

now dev will stop requiring a deployment very soon. We'll be able to detect framework configuration and project settings without deploying at all. This is a problem and it's on us.
With regards to the requirement of .now, it strictly has to do with making a more resilient system. Mapping "name" is dangerous and entirely relies on the idea that you will never change the project name.
It also introduces a potentially fatal problem from an availability perspective: if a developer happens to name a folder the same as your production website, and then runs now --prod, they will basically be overwriting your project.

The second point is really worth stressing. Without .now, we don't have a project id, just a loose mapping based on name, that has led some customers to unexpected downtime.

@rauchg

This is a problem and it's on us.

For the record I think this is a great response. But why is it 61 DAYS later?

@rauchg Thanks for the reply

Fair enough, thanks for the honest reply, I appreciate it.

I get your predicament, I really do. What I am trying to get at with many of my posts in the issue queue, spectrum, e-mails, etc. to you and your team is that this info that you are giving here, in this thread (and other threads about other things), to the select few that are following along here is what we need to get in the blog post, in the public announcement. It helps us developers know WHY these changes are needed, most likely we will understand the problem you are solving and have a little more patience and understanding when these sudden errors get thrown in our face by CI, colleagues and trainees. This particular change was HUGE in regards to using the platform. Me and my team of developers lost productivity for a whole day trying to figure out what happened, not cool. Downgrading to v16 felt so bad, but had to be done to get now dev working without losing more time.

Also regarding the dangerous aspect of mapping "name"; when a deploy has happened to a specific name, isn't that name taken by the user/team that deployed to it? Why can someone else override it? It doesn't make sense to allow that (unless it is another developer of the same team). If you allow it, can you explain the reasoning behind why? If you don't allow it and still had customers experiencing unexpected downtime, then I reckon that those customers doesn't understand the platform correctly and they should get educated, no offense.
Last question, why is the recommendation that .now be ignored by version control? If the problem is the mapping, shouldn't a repo be "connected" to a project id and have the connection in version control? If it can live in version control, can't it be set inside now.json? Hehe, sorry, that was three questions.
Thanks in advance 🙏

I think @rauchg was mentioning mainly the situation when a developer from
the same team accidentally deploys to production. Education’s nice, but its
not a sufficient prevention of human error.
As to .now, I’d say it shouldn’t be in Git because you can have multiple
projects attached to one codebase? 🤔 Or are those IDs secrets? Honestly I
don’t know. I haven’t really seen any docs/blogs mentioning any
recommendation.
On Wed, 8 Apr 2020 at 22:07, Michael Zetterberg fd. Lopez <
<EMAIL_ADDRESS>wrote:

@rauchg https://github.com/rauchg Thanks for the reply

Fair enough, thanks for the honest reply, I appreciate it.
2.
I get your predicament, I really do. What I am trying to get at with
many of my posts in the issue queue, spectrum, e-mails, etc. to you and
your team is that this info that you are giving here, in this thread (and
other threads about other things), to the select few that are following
along here is what we need to get in the blog post, in the public
announcement. It helps us developers know WHY these changes are needed,
most likely we will understand the problem you are solving and have a
little more patience and understanding when these sudden errors get thrown
in our face by CI, colleagues and trainees. This particular change was HUGE
in regards to using the platform. Me and my team of developers lost
productivity for a whole day trying to figure out what happened, not cool.
Downgrading to v16 felt so bad, but had to be done to get now dev
working without losing more time.
Also regarding the dangerous aspect of mapping "name"; when a deploy has
happened to a specific name, isn't that name taken by the user/team that
deployed to it? Why can someone else override it? It doesn't make sense to
allow that (unless it is another developer of the same team). If you allow
it, can you explain the reasoning behind why? If you don't allow it and
still had customers experiencing unexpected downtime, then I reckon that
those customers doesn't understand the platform correctly and they should
get educated, no offense.
Last question, why is the recommendation that .now be ignored by version
control? If the problem is the mapping, shouldn't a repo be "connected" to
a project id and have the connection in version control? If it can live
in version control, can't it be set inside now.json? Hehe, sorry, that
was three questions.
Thanks in advance 🙏
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/zeit/now/issues/3767#issuecomment-611166690, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AACFGMNY4HNA2XDZ4DSJED3RLTKPBANCNFSM4KRRECTQ
.

@honzajavorek I'm really not a fan of decisions based on users that don't know how to use something. I do understand that I'm probably in the minority there, but still, there is nothing preventing that same human error from occurring with project linking. It's just as easy to answer "yes" to all the CLI prompts or drop in a -c / --confirm in the command or set NOW_ORG_ID+
NOW_PROJECT_ID in the environment to get the same "downtime issue" as described. Users that don't understand something are usually the same users that don't read the prompts/modals/docs/whatever (that's the whole point of why they don't understand what they are using) and would therefore be prone to the same human error rate, with or without project linking.
For me it all comes down to giving the correct permission to the correct users. That's why I don't have any of my developers in my Now team, everything is done by CI. I shouldn't need to trust them or require them to learn skills they aren't interested in learning, no one should. Again, I understand my opinion might be considered harsh and in the minority.
The change could just as well have been "when deploying to prod (now --prod), ask for confirmation when there already is a deployment aliased to production" (and make it big and shiny, or even better do it like Super Smash Bros. Brawl did it for data deletion). It is essentially the same level of help against human error as this project linking is. Except not as invasive as project linking.

As to .now, I’d say it shouldn’t be in Git because you can have multiple
projects attached to one codebase? 🤔 Or are those IDs secrets? Honestly I
don’t know. I haven’t really seen any docs/blogs mentioning any
recommendation.

Having multiple projects attach to one codebase feel more human error prone than being without project linking. The IDs might be considered secrets, not sure. Now applies access rights properly (both web and deploy) so I'm not sure what an attacker could gain from knowing the IDs. Maybe the ZEIT team can shed some light on this.
The recommendation is obviously to not have them in version control as the CLI has code that makes sure to add .now to your .gitignore, it even informs you of this. Although the catch makes me wonder, hence I'm asking. If the purpose of project linking is to link a codebase to a project it should be in version control. Otherwise the codebase won't be linked to a project. The clone/working copy on a developers machine will be linked to a project. I reckon that the users that don't understand the platform will still have a hard problem with the human errors and probably some problems with project linking too 🤷♂
By the way, making an initial deploy a.k.a. project linking actually leaves you with a dirty working copy, which feels a bit dirty to me :)

Personally, I would really appreciate a way to configure all of the project settings from the command-line.  For example, I would like to be able to set a production deploy alias on a custom domain without opening up the now website in my browser.  I would also like to be able to link the project from command line without a deploy.
Could you add a now project command that allows linking a directory to a project and performs operations on the linked project, such as configuring deploy aliases?  Maybe have now project link, now project alias deploy.example.com, and maybe some sort of now project config <property> [value] for setting things like build commands? The now project link command would collect all of the same info that the deploy linking would, send that to the server, and set up the project.  You would be able to specify a custom project name with now project link --name example or maybe now project link example and not specifying the name would suggest the directory name but ask for confirmation and allow you to enter a value if you decline the suggestion.
One of the things I like best about now is that I can do everything from the command-line and my config files.  Having to go to the website to configure a project is a significant departure from the complete command-line control that I've liked so much until recently.

I'd like to add one point of view here, which I didn't entirely realize previously.
One of the things which we sadly lost by this update is the simplicity of going to a directory and typing now to just deploy the contents. After the update, now becomes an interactive "wizard" with questions, which somehow reminds me more Windows XP program installations than ZEIT's focus on simplicity.
I have materials where I teach beginners in programming the concept of web APIs. There is grand finale in deploying your own API to the internet. I'm using ZEIT Now to achieve that and I love it for its simplicity of installation and deployment. During the workshop, I don't want people to think about the deployment much, I want them to just type now and see URL. They usually don't have any serious experience with deploying stuff. After the update, I'll have to rewrite the tutorial (again...), and instead of a few lines, I'll have to guide the beginner through all the bumps of the wizard and project linking.
Will ZEIT Now still stay the best platform where to achieve something like this the easiest possible way? Perhaps! But I championed it for this purpose in the first place because of the simplicity of deployment. I could have choose Heroku etc., but typing now was too hassle-free for a workshop lecturer (and a tutorials author) to resist.

I'll echo that.  When I demo people now when they're stepping in to serverless for the first time, I want them to avoid the hell that is the native serverless of AWS / GCP.  This project linking is moving away from simplicity towards a more complicated solution.

@michaellopez Regarding multiple projects connected to one codebase... In the above mentioned tutorial for APIs, I have three deployments from a single codebase. My deployment step in CI currently looks like this:
# NOW_TOKEN needs to be set in CircleCI project settings
deploy:
  docker:
    - image: "circleci/python:3.8-node"
  working_directory: "~/repo"
  steps:
    - checkout
    - *install
    - run:
        name: "Installing now.sh"
        command: "sudo npm install --global --unsafe-perm now"
    - run:
        name: "Building & Deploying cojeapi.cz"
        command: |
          source ./venv/bin/activate
          make build-cs
          now ./_build --name=cojeapi-docs-cs --prod --token=$NOW_TOKEN
    - run:
        name: "Building & Deploying whatisapi.org"
        command: |
          source ./venv/bin/activate
          make build-en
          now ./_build --name=cojeapi-docs-en --prod --token=$NOW_TOKEN
    - run:
        name: "Deploying Server"
        command: "now ./code/server/16_deploy --name=cojeapi --token=$NOW_TOKEN"

There is a single throwaway _build directory. I can build the docs either in Czech and then deploy them as static files as simply as now ./_build --name=cojeapi-docs-cs --prod --token=$NOW_TOKEN, or I can do the same for English and deploy with --name=cojeapi-docs-en. Then, I have a sample application https://cojeapi.honzajavorek.now.sh/ the workshop attendees can play with, and which works with the examples. I deploy that directly from a directory with examples.
With upgrading to now@18, this all has broken. I found a while now to fix it, but after initial investigation of the setup I think the only reasonable thing I can do is to downgrade to v17 😞  I can imagine spending hours to get this whole thing working with the new approach.

I'm encountering the same pain, and it's become even worse now, become v16 doesn't work anymore for us, it got broken ~7 days ago and won't get fixed. (see https://github.com/zeit/now/issues/4332)
I've lost the ability to have my designers work locally on the codebase without granting them access to deployment with v17+. It used to be simple, but it has become bloated and complex, and a source of frustration and quite-a-lot-of wasted time. For no good reason whatsoever.
Hacks like allowing them access by adding the base code to their own Vercel account without granting them access to the Vercel team so that they can work locally creates a copy on their own Vercel account, a copy of the source code, on which, as a CTO, I have no access nor control. On the other hand, if I add them to the team, they could change domain name config, or deploy something to production by mistake. I can't have neither.
I want to highlight the fact that I have had to told my people not to work on Vercel projects until further notice. (It's been a week)
@rauchg How is it possible that Vercel encourages such irresponsible practices? The decision of forcing project linking obviously had unforeseen consequences, consequences that need to be fixed ASAP.

v16 doesn't work anymore for us, it got broken ~7 days ago and won't get fixed. (see #4332)

@Vadorequest you can fix the versions of the builders as a workaround to this issue. This is an example extracted from my v16 project's now.json, using last functioning versions:
  "builds": [
    { "src": "admin-api/*.js", "use": "<EMAIL_ADDRESS>},
    { "src": "api/*.js", "use": "<EMAIL_ADDRESS>},
    {
      "src": "web/package.json",
      "use": "<EMAIL_ADDRESS>      "config": { "distDir": "build" }
    }
  ],

v16 doesn't work anymore for us, it got broken ~7 days ago and won't get fixed. (see #4332)

@Vadorequest you can fix the versions of the builders as a workaround to this issue. This is an example extracted from my v16 project's now.json, using last functioning versions:
  "builds": [
    { "src": "admin-api/*.js", "use": "<EMAIL_ADDRESS>},
    { "src": "api/*.js", "use": "<EMAIL_ADDRESS>},
    {
      "src": "web/package.json",
      "use": "<EMAIL_ADDRESS>      "config": { "distDir": "build" }
    }
  ],

Yes, I can confirm this works too. This is what we are doing in our team too.

Thanks, I tried it and ran into various issues (infinite loop build/test/deploy).
is there an official guide/doc for this? I've tried the following:
  "builds": [
    {
      "src": "src/*.ts",
      "use": "<EMAIL_ADDRESS>    },
    {
      "src": "src/*.ts",
      "use": "<EMAIL_ADDRESS>    },
    {
      "src": "package.json",
      "use": "<EMAIL_ADDRESS>    }
  ]

My now.json file lives at the root, with the src folder, like so:

Do I need to install those deps/devDeps in my package.json<EMAIL_ADDRESS><EMAIL_ADDRESS>

The issue with not being able to run now dev locally really needs to be addressed... Codebase needs to be able to run anywhere locally without having access remote stuff. I'm working around this by running npx<EMAIL_ADDRESS>dev

I eventually stopped using now, and I'm using next instead. I don't know why I used now in the first place, maybe related to ENV variables but the recent Next.js .env support made it easy to migrate.

This issue is a bummer. :(
I want to open source a site and be sure that folks can clone the repo run it locally without a lot of hassle. Since it has a serverless function, vercel dev is used to start it up locally. This can't be used without jumping through a few more Vercel hoops. :/
I hop this issue is addressed soon.

@Flet If by "serverless function" you mean something in pages/api/ then it doesn't need vercel cli to work, using next is enough.

Thanks @Vadorequest, I'd be OK with this as a fix, but I'm not using the next framework at all.

The canary channel has been updated with a new command, vercel link.
Additionally, vercel dev will ask to link to a project if it is not already.
Try it out now with npm i -g vercel@canary, thanks!

now dev will stop requiring a deployment very soon. We'll be able to detect framework configuration and project settings without deploying at all. This is a problem and it's on us.
https://github.com/vercel/vercel/issues/3767#issuecomment-611074321

So this statement was about specifically not requiring a deployment but not about not requiring a link.
So this issue is closed because now dev prompts for you to use now link but not because the actual issue is solved which is not requiring a link for local dev?

@styfle so like: (?)
vercel link  VERCEL_ORG_ID=$VERCEL_ORG_ID   VERCEL_PROJECT_ID=$VERCEL_PROJECT_ID  --confirm  --token $VERCEL_TOKEN

then we can do vercel dev in CI successfully?

Canary version works good for me!
My GitHub actions code is below.
- name: Install Vercel
  run: yarn global add vercel@canary

- name: Pull env from Vercel
  run: vc env pull -t ${{ secrets.VERCEL_TOKEN }}
  env:
    NOW_ORG_ID: ${{ secrets.ORG_ID }}
    NOW_PROJECT_ID: ${{ secrets.PROJECT_ID }}

- name: Run vercel dev
  run: vc dev -t ${{ secrets.VERCEL_TOKEN }} &
  env:
    NOW_ORG_ID: ${{ secrets.ORG_ID }}
    NOW_PROJECT_ID: ${{ secrets.PROJECT_ID }}i

On Travis CI, I get this when trying canary:
$ npm i -g vercel@canary
npm ERR! code E404
npm ERR! 404 Not Found - GET https://registry.npmjs.org/@vercel%2fredwood - Not found
npm ERR! 404
npm ERR! 404  '<EMAIL_ADDRESS>is not in the npm registry.
npm ERR! 404 You should bug the author to publish it (or use the name yourself!)```

Any updates on how to run vercel dev without linking an account? This issue got sidetrack from the original intend.

It feels like the ultimate reason they will not support vercel dev without linking is to avoid loosing paid customers since all their paid plans work on a per developer basis.

Attn @styfle
Is VERCEL_ORG_ID now a directory instead of a code?
I still can't get v20 to cooperate in TravisCI:
> vercel link VERCEL_ORG_ID=$VERCEL_ORG_ID VERCEL_PROJECT_ID=$VERCEL_PROJECT_ID --confirm --token $VERCEL_TOKEN && vercel dev --listen 3000
Vercel CLI 20.0.0
Error! Expected directory but found file: VERCEL_ORG_ID=[secure]

I was afraid that this will cause some problems in the future and today was the day that vercel blocked my account without a reason/warning. Now I cant even run vercel dev because it needs to be linked to an account and somehow this is invalid now.
Something to consider if you are using Vercel for you next project.


Add substring assertion functions

Ready to review / discuss @molovo

@MichaelAquilina thanks for the PR, a very nice addition. I've just asked for some changes to the tests for consistencies sake, and to add tests for the failure state so we can check the error message. See the tests for same_as for an example.
Could you also please target the next branch rather than master, so I can get this in the next release?
Thanks very much for contributing.

@molovo updated and changed base :)

Just rebased the branch on next

@MichaelAquilina Excellent. I'll get this merged, and it'll be released with v0.8.0. Thanks for your contribution.

Thanks for the help :)


adds descriptions for fed, regionalAlternate and regionalDenied

when you merge this PR it will automagically flow into the PR you have against Comcast/traffic_control. how neat is git!

except i broke your travis-ci :(

No problem about TravisCI - that is a not-yet-working experimental effort! Thanks!


The JSON API endpoint shows that the Beta channel version is newer than the Dev channel version

Yesterday, 10/7/2023, I found that the JSON API endpoint (https://googlechromelabs.github.io/chrome-for-testing/last-known-good-versions.json) shows that the Beta channel version is newer than the Dev channel version.

Is that correct??

Beta is definitely correct: https://chromereleases.googleblog.com/2023/10/chrome-beta-for-desktop-update_6.html
Dev should have been in 119 as well as per https://chromereleases.googleblog.com/2023/10/chrome-dev-for-desktop-update.html

Thanks, @thiagowfx, for your reply!
Okay, but I still need clarification... Where has version 118 gone away?? Ver.118 doesn't exist in any channels.

The source of truth for Chrome (not CfT) releases is https://chromiumdash.appspot.com/releases.
CfT aims to follow that. In this case, https://googlechromelabs.github.io/chrome-for-testing/#dev shows that a CfT build was triggered across all platforms but the mac-x64 one hasn’t finished:

On the relevant build detail page (not public, sorry), it looks like step “27. compile” says “step was never finalized; did the build crash?”. I just manually restarted the build.

@mathiasbynens
When the entire build process is succeeded eventually, the versions of each channel will be the following, right?

Stable ver.117
Beta ver.119
Dev ver.119
Canary ver.120

If my understanding is correct, ver.118 will not be in any channels. Is that the expected result??

118 is going Stable this week, so this is expected.

@mathiasbynens I could understand. Thank you for your reply.


Cannot commit DML scripts (DELETE, INSERT, UPDATE)

Describe the bug
When I execute Insert or Delete command then the change is not applied in Oracle DB.
After script execution I use COMMIT to finish transaction.
No errors are returned during script insert, delete, and commit execution.

I'm also having this problem. When I execute an update/insert/delete query like:
update db.sample_table
        set client_name = 'Example'
        where id = '1';

It run with success with the message: 1 rows were affected, but the change it's not represented on table. So I run COMMIT in a separated query, and the message is:
No Data

And the table is still with the previous value.
If I run something like:
update db.sample_table
        set client_name = 'Example'
        where id = '1';
commit;

I get the following message:
ORA-00933: SQL command not properly ended

Not supported within this repository anymore.


The balance is not up to date

Hello,
I have 0.1 COQUI at the address RTdPu16FBA4aoSdevhnPe6pBw3EQ8CKRU6, but Hyperdex says 0 COQUI in my wallet. Can anyone help?

HyperDEX 0.4.0
Electron 4.0.1
linux 4.19.0-8-amd64
Locale: en-US

COQUI hardforked a while ago and since this app hasn't been updated in a while, the old parameters are still used.
We'll put it on the list when this app gets a re-release.


Confirm with cmd+enter instead of enter key

As the title says, I want to confirm with cmd+enter instead of enter key. If there is a way to do this, please let me know. If not, I would like the feature to be added. I'm not confident about the code quality, but I can submit a PR.
The following are the reasons for this feature request.
Confirming with the enter key is problematic for many Japanese people. In Japanese, 3-7 types of characters are mainly used: hiragana, katakana, kanji, and alphabet (x2-4). After entering text on the keyboard, the user selects which type to use. Since the enter key is used to select, if the text is confirmed with the enter key, it is frustrating because you cannot continue entering text. I have expressed a specific example of the operation in text.
When typing
"CarlosNZは偉大なengineerです"
It need to type
"CarlosNZ" "は" "enter" "偉大な" "enter" "engineer" "です" "enter"
ref: https://github.com/CarlosNZ/json-edit-react/blob/10f5c9fe3c28154fbafa9c633863695d3c85d5aa/src/ValueNodes.tsx#L23

Thanks for the suggestion. You currently use Cmd-Enter when editing the multiline/JSON blocks so that you can add line breaks in the text, but plain old Enter for simple inputs.
I should be able to make the "Confirm" key a customisable option fairly easily. I'll try and do that in the next week or so.

You currently use Cmd-Enter when editing the multiline/JSON blocks so that you can add line breaks in the text,

I feel like that's a bit misleading, so let me clarify. In this multi-line editing, you can confirm with Cmd-Enter. The Enter key is treated as adding a line.
https://github.com/CarlosNZ/json-edit-react/blob/10f5c9fe3c28154fbafa9c633863695d3c85d5aa/src/CollectionNode.tsx#L130

On the other hand, when inputting strings only (is this simple inputs?), Cmd+Enter is treated as just Enter. Shift-Enter creates a new line.
https://github.com/CarlosNZ/json-edit-react/blob/10f5c9fe3c28154fbafa9c633863695d3c85d5aa/src/ValueNodes.tsx#L23

On the other hand, when inputting strings only (is this simple inputs?), Cmd+Enter is treated as just Enter. Shift-Enter creates a new line.

Yes, that is correct, I forgot 🙄
I'll make it so you can override as many or few of the keyboard controls as you wish, by passing in an object like this:
export interface KeyEvent {
  key: string
  modifier?: string | string[]
}

export interface KeyboardShortcuts {
  confirm?: KeyEvent | string // buttons, and value node default
  cancel?: KeyEvent | string // all "Cancel" operations
  objectConfirm?: KeyEvent | string
  objectLineBreak?: KeyEvent | string
  stringConfirm?: KeyEvent | string
  stringLineBreak?: KeyEvent | string // for Value nodes
  numberConfirm?: KeyEvent | string
  booleanConfirm?: KeyEvent | string
  numberUp?: KeyEvent | string
  numberDown?: KeyEvent | string
  clipboardModifier?: string | string[]
  collapseModifier?: string | string[]
}

Thank you. That feels so good.
I'm looking forward to the fix!!

Hi @DameNianch, I've made a PR for this and published a beta to npm if you'd like to give it a try:
https://www.npmjs.com/package/json-edit-react/v/1.18.0-beta1
Documentation added to README here: https://github.com/CarlosNZ/json-edit-react/blob/133-keyboard-overrides/README.md#keyboard-customisation

@CarlosNZ
I'm very grateful for your quick response.
I just installed it and checked that it works.
The coding remains cool, and it's friendly to Japanese people, which I like even more.

I'm very grateful for your quick response. I just installed it and checked that it works. The coding remains cool, and it's friendly to Japanese people, which I like even more.

Glad to hear, it was a good suggestion.


ImportError: cannot import name '_build_cond_encoder' from 'ddpm.trainer'

Hi, thanks for sharing your great work again.
When I run the evaluation, it shows:
File ".../ccdm-stochastic-segmentation/evaluation/eval_cdm.py", line 30, in
from ddpm.trainer import _build_model, _build_cond_encoder, _build_feature_cond_encoder
ImportError: cannot import name '_build_cond_encoder' from 'ddpm.trainer'". (.../ccdm-stochastic-segmentation/ddpm/trainer.py)
Just wondering where to find the "_build_cond_encoder" function. Look like it's not in ddpm/trainer.py now. Thank you!

Hey, I updated the code to remove the unused cond_encoder from eval_cdm.py. Let me know if you run into any more issues!


Language fr

Game map transcription in French

Thank you in advance for the update for the French language

@ericacclermont I gladly will, but you closed the pull request. Anything wrong with it?

I hope it's like this to reopen the pull request to add the French translation. Thanks again for your feedback.

@ericacclermont Thanks a lot! If you want translations of H5P content types to be more convenient, you can check out https://translate-h5p.tk