lint: switch pretty-quick for lint-staged in pre-commit hook?

Extacted from https://github.com/iterative/dvc.org/issues/716#issuecomment-550666828

We're now using lint-staged for ESLint in the pre-commit hook (see #776) and it seems it also supports Prettier so it would be cleaner to only use this tool and stop using pretty-quick.
Please refer to the lint-staged README and figure out the necessary changes to package.json by testing locally. (And remove pretty-quick dependency, update yarn.lock.)

Can I take this one?

By all means @theashraf. Thanks!

Per okonet/lint-staged/pull/745 we are currently unable to implement this, but the corresponding PR can be left open for future review.

This was already done in #790 but we are missing the --bail functionality in lint-staged. So if/when it gets implemented (see okonet/lint-staged/pull/745), we can continue that same PR.

@jorgeorpinel is this one solved with the recent migration (+the lates #776 PR)?

lint-staged won't be supporting the same behavior as pretty-quick so we can just keep both tools. Closeable!


$input is not defined in unmaskedvalue(input) function.

Chrome gives me the following error since updating to the latest version (3.2.1-55)...
Uncaught ReferenceError: $input is not defined
I tracked this down to line 694 of jquery.inputmask.bundle.js. This bug is in the unmaskedvalue(input) function. Renaming $input to input fixes the problem.

@LukeFranky ,
Thx for reporting.


feat(client): add support for "off" value in auto_flush_rows and auto_flush_interval

Closes #31

Package Test Coverage:


proposal: Go 2: allow any type of slice to work

func main() {
	nums := []int{5, 6, 7}

	var (
		a int = 1
		b int = 2
		c int = 3
	)
	F(a, b, c) // Works
	F(1, 2, 3) // Works

	Inums := []interface{}{5, 6, 7}
	F(Inums...) // Works
	F(nums...) // Doesn't work
}

func F(x ...interface{}) {
	fmt.Println(x...)
}

Compiler Error:
cannot use nums (type []int) as type []interface {} in argument to F

I think for Go 2, a nice change would be to allow the above example to work as syntax sugar.
I understand they are technically different types (hence the error). I'm not saying the underlying data types or how the underlying data types works should be changed.
My proposal is only from a "verbal" point of view. The compiler just "pretends" each item in the slice was by hand written out.

See the discussion in #18605, especially https://github.com/golang/go/issues/18605#issuecomment-392947258 .

Adopting this as suggested would cause a subtle change in the handling of ...: if the types match exactly the same slice would be passed, but if the types differ then a new slice would be created and that new slice would be passed.
Also, as a general guideline we try to avoid having a simple statement cause a lot of work, but this could cause a simple call F(s...) to copy a large slice, converting each element of that slice.
It's always possible to write a little helper function to do this kind of work.
For those reasons, we aren't going to adopt this proposal.  Thanks for sending it.


1.7.6 Update Feedback

First day of month works but now the currentday gives no feedback if its selected (Doesnt change color) and doesnt show a eventindicator cycle

It's how Google calendar works. Current day is highlighted in a special colour. If you select it, it doesn't change colour. Events are also not shown and as far as I can tell and there's no way of changing the colour for the current day.
Is this functionality important to you? I can add a method to make it configurable.

That would be nice. Its the only thing i miss, because in the actual condition the calendar loses on information demand. lets say the current day is the 17th and it has an event. when i click on a other day lets say the 5th --> the 17th doesnt show the small indicator cycle --> Only when i click on it i can see that there are events on it

Closing as #73 has been raise so just closing as a duplicate.


[FormRecognizer] returning iterators for extract results?

Currently the analyze operations return pages in an array.  The PDF page limit is 2000.  It would be nice to support enumerating those pages for potential stream processing in the future, instead of array?

This was stabilized in GA.


BracesForForLoop-0 could not be fixed

Hi,
I am experiencing an issue regarding the rule GroovyLint(BracesForForLoop-0)
Unfortunately  vscode-groovy-lint is still reporting this issue, regardingless if it is fixed or not.
The quick fix option does not solve the issue as well...

VS Code is reporting following inside the Problems:
Braces should start on the same line GroovyLint(BracesForForLoop-0)

If any other debug output is required feel free to notify me, I'll try to assist

This is a false positive from CodeNarc, i can't do anything about it except upgrading to CodeNarc 1.6, something I'll do one of these days ( or some other contributor if he/she's motivated :) )
For now, I advice you to disable this rule( Hover -> Quick action -> Ignore this problem for all files


Updates to alliancecan.md

I updated the alliancecan.md to include the following information:

Updated to sshfs instructions for Linux to mount graham in your personal computer. I gave a bit more details.
Included instructions on how to run Jupyter Notebooks in your local VS Code using kjupyter and Remote-SSH extension.
Included details about how to visualize compute nodes using VNC and neuroglia-helpers.

I already compiled it in my computer and it's looking good on my end.

Just implemented your suggestions and also included instructions to run kjupyter under the Software/Graham

Done!


Switching to mainnet <-> testnet network on extension with ledger device leads to error: No signer

Edge browser, Ledger nano S OS version 1.1.1
Wallet version 6.34.0
Refreshing page or reloading and clearing cache had no effect. Reinstalled the wallet to resolve the error from showing and being able to proceed with wallet.

console.js:36  React Router caught the following error during render
Error: No signer
    at taproot-account.hooks.ts:91:24
    at Object.Ci [as useMemo] (react-dom.production.min.js:179:117)
    at exports.useMemo (react.production.min.js:25:191)
    at useCurrentAccountTaprootIndexZeroSigner (taproot-account.hooks.ts:90:17)
    at AssetsList (asset-list.tsx:28:85)
    at Xh (react-dom.production.min.js:167:135)
    at dj (react-dom.production.min.js:197:256)
    at Wk (react-dom.production.min.js:292:18)
    at Vk (react-dom.production.min.js:280:383)
    at Uk (react-dom.production.min.js:280:319)
    at Jk (react-dom.production.min.js:280:180)
    at Ok (react-dom.production.min.js:271:86)
    at Fk (react-dom.production.min.js:273:286)
    at jg (react-dom.production.min.js:127:100)
    at react-dom.production.min.js:267:262 {componentStack: '\n    at AssetsList (chrome-extension://ldinpeekobn…hjjdofggfgjlcehhmanlj/951.js:248331:3)\n    at App'}

Looks like some users hit this error when they try to connect their ledger device.

I tested this on this branch and it seems to fix the issue 5254


Ensure middleware that can report errors are bound to the controller

Middlewares which are not bound to the controller will not pass through controller level error handling. To resolve this, bind the check session, progress, and csrf middlewares onto the controller using controller.use instead of onto the parent router. This means that controllers can attach their own custom error handling for the errors that these middlewares emit, instead of having them bound at a router level where errors can only be resolved at an application level.
This fixes a bug in the previous release where error handling was put into controllers for pre-requisite step errors, but is never actually hit because the error is not thrown in the controller level router.

Is there a test you can write for the previous bug?

Damnit @easternbloc!!

Now with added tests.

:+1:


ajax got response but result not show in select2

i use select2 to retrive a list in json from my database... i see response and filter result in firebug but i can not have any sesult show in my drop box
my jquery look like that:
$('#country2').select2({
    ajax: {
    url: "{{path('report-filter-list', {'type': 'country'})}}",
    dataType: 'json',
    delay: 250,
    multiple:true,
    data: function (params) {
    return {
    q: params.term, // search term
    page: params.page
                        };
                    },
                    processResults: function (data, page) {
                        return {
                            results: data.items
                        };
                    }
                },
                minimumInputLength: 3,

            });

my select:
<select  class="input-xxlarge"  multiple="multiple" id="country2" name="country[]">

and the response:
[{"text":"American Samoa","id":"AS"},{"text":"Canada","id":"CA"},{"text":"Central African Republic","id":"CF"},{"text":"Dominican Republic","id":"DO"},{"text":"Holy See (Vatican City State)","id":"VA"}]

anything i do wrong...was working in 3.5.4 but input hidden not post on submit

Your processResults method should be
processResults: function (data) {
  return {
    results: data
  }
}

Because your response is giving back an array instead of an object with an items attribute.

This appears to be more of a usage question than a bug report or common feature request.  As we continue to keep the Select2 issue tracker geared towards these two areas, bug reports and common feature requests, we are redirecting usage questions to other communities such as the mailing list, IRC, or Stack Overflow.


Add a test for runtime-scoped deps in coursier (#156)

thanks a ton!
I'm hoping we can make coursier the default very soon. Thanks for testing!

any time.  i'm excited for coursier -- it feels really solid so far.


Better interop for keys and configs

Custom key bindings backed by config values currently need to have the same name for ButtonConfig and ConfigValue.
Problematic line
https://github.com/Valheim-Modding/Jotunn/blob/dev/JotunnLib/Managers/SynchronizationManager.cs#L170

seems to be already handled in 2.1_keybindDeconflict branch


Content group simple

Related Ticket(s)
{{Provide url(s) to the related ticket(s) that this pull request addresses}}
Description
{{Add a human-readable description / detail summary of what the PR is changing and any details around how and why}}
{{If applicable, include a screenshot indicating an example or examples of what the PR is changing in the application}}
Changelog
New

{{new thing}}

Changed

{{changed thing}}

Removed

{{removed thing}}

@jacobottesen-dgc The page title should be "content group simple". It says "Callout quote" right now.


Front end won't start because nuxt not found

Hi There,
First, thanks SO much for this repo, it's a huge help!
The backend starts nicely, but the frontend container fails with the following ...
**docker logs my-app-frontend-1**
yarn run v1.22.19
$ nuxt dev
/bin/sh: 1: nuxt: not found
error Command failed with exit code 127.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

I saw no errors with the docker build and start.
Thanks!

Hey @dividor I've had this problem as well and I think it's purely for the dev environment. This never worked well with the Vue/Nuxt frontend on the original fullstack because it doesn't do hot reload, even though it used to start. Now, for some reason, it doesn't reference the nuxt dev command correctly (something to do with the path), which may have something to do with errors in nuxt itself ... still a very new release with a few glitches.
For development, what I do is simply run the frontend directly (i.e. outside of docker). I've got that in the readme.

NOTE: I find that the Nuxt container does not run well in development mode, and does not refresh on changes. In particular, nuxt/content is very unpredictable in dev mode running in the container. It is far better to run the frontend outside of the container to take advantage of live refresh.
Change into the /frontend folder, and:
yarn install
yarn dev

Just note that you'll use http://localhost:3000 and not http://localhost to reach it, although the api will still be at the backend http://localhost/api/v1.
I find it more responsive to work this way, otherwise you're messing around with starting and stopping your docker containers to get the updates you need on Nuxt.

Thanks for the workaround @turukawa!


loadOpencv sometimes never resolves

The call to Mirada.loadOpencv never resolves if opencvJsLocation points to a opencv.js that loads opencv_js.wasm. (self-compiled 4.4.0 if that matters).
This is due to the fact that  cv.onRuntimeInitialized gets assigned only after the "load" callback here, at which point opencv.js already checks the global cv variable, and assigns a new empty object to its Module variable and then doesn't see an "onRuntimeInitialized" property to call when done with the initialization.

Seems like the proper way to detect if it's loaded is by defining a Modules directly: https://stackoverflow.com/a/56978454
const Module = {};
function ... {
  return new Promise((resolve, reject) => {
    Module.onRuntimeInitialized = resolve;
    /* create script element ... */
  }
}

I will share information on this issue.
I made the method in Promise so that I can easily get the initialized instance, but for some reason Promise did not solve the problem.
import cv from '@techstark/opencv-js';
export async function getReadyCv() {
  await new Promise<void>(resolve => {
    cv.onRuntimeInitialized = () => {
      resolve();
    }
  })
  return cv;
}

The problem seems to be that the Module already implements a method named "then", and I have some doubts about the javascript behavior, but anyway, I modified it as follows and it works
import cv from '@techstark/opencv-js';
export async function getReadyCv() {
  await new Promise<void>(resolve => {
    cv.onRuntimeInitialized = () => {
      resolve();
    }
  })
  return {cv:cv};
}


500error

Hi, goproxy is very good ,I love this soft.
I test it in many case, and find that many time it return 500 error, some time it works well ,but some time make me  can't use .
Client send request to goproxy_server , use wireshark capture the packet ,it seem that ,goproxy_server do not send request to the real server and direct return 500.
the server is www.artilib.cn.
How Can I deug the process  and find out the real problem?
my go compiler is 1.7.3
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GORACE=""
GOROOT="/usr/local/Cellar/go/1.7.3/libexec"

Hi,
Thanks for the kind words.
Can you try running the proxy  with Verbose = true?
On Fri, Dec 2, 2016 at 8:51 AM, zhangyc310<EMAIL_ADDRESS>wrote:

Hi, goproxy is very good ,I love this soft.
I test it in many case, and find that many time it return 500 error, some
time it works well ,but some time make me can't use .
Client send request to goproxy_server , use wireshark capture the packet
,it seem that ,goproxy_server do not send request to the real server and
direct return 500.
the server is www.artilib.cn.
How Can I deug the process and find out the real problem?
my go compiler is 1.7.3
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GORACE=""
GOROOT="/usr/local/Cellar/go/1.7.3/libexec"
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/elazarl/goproxy/issues/200, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAP4ov3LCeeKrC_HPosf84gQoJHM589Wks5rD7_1gaJpZM4LCQMx
.

Hi,
Thanks for you reply.
I run it again with the Verbose info.
It seemd that the resp got EOF.
2017/02/15 23:44:00 [102] INFO: Got request /dzi1/20160911/20160911211731xn61ekHH_files/13/5_5.jpg www.artlib.cn GET http://www.artlib.cn/dzi1/20160911/20160911211731xn61ekHH_files/13/5_5.jpg
2017/02/15 23:44:00 goproxy:resp is here:%!(EXTRA string=http://www.artlib.cn/dzi1/20160911/20160911211731xn61ekHH_files/13/5_5.jpg)
2017/02/15 23:44:00 [102] INFO: Sending request GET http://www.artlib.cn/dzi1/20160911/20160911211731xn61ekHH_files/13/5_5.jpg
2017/02/15 23:44:00 goproxy:resp is error:%!(EXTRA string=http://www.artlib.cn/dzi1/20160911/20160911211731xn61ekHH_files/13/5_5.jpg, string=EOF)
2017/02/15 23:44:00 [102] INFO: error read response http://www.artlib.cn/dzi1/20160911/20160911211731xn61ekHH_files/13/5_5.jpg EOF:
2017/02/15 23:44:00 goproxy:resp is nil and err:%!(EXTRA string=http://www.artlib.cn/dzi1/20160911/20160911211731xn61ekHH_files/13/5_5.jpg, string=EOF)

some time there  is http: server closed idle connection instead of the EOF .
wait for your reply.


kie-issues#671: add missing import

apache/incubator-kie-issues#671
Adding missing import of MavenCommand.

The import has been added into pr_check.groovy script instead, this PR was used for testing only.

PR job #3 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer
build-chain build full_downstream  -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u https://github.com/apache/incubator-kie-kogito-runtimes/pull/3273 --skipParallelCheckout
NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3273/3/display/redirect
Test results:

PASSED: 3385
FAILED: 4

Those are the test failures:

org.kie.kogito.quarkus.workflows.RPCGreetIT.testEnglish
Read timed out

org.kie.kogito.quarkus.workflows.RPCGreetIT.testUnsupportedLanguage
Read timed out

org.kie.kogito.quarkus.workflows.RPCGreetIT.testDefaultLanguage
Read timed out

org.kie.kogito.quarkus.workflows.RPCGreetIT.testSpanish
Read timed out


adds glitch-hello-eleventy.json to starter list

This is our (Glitch.com) official generated static site starter for Eleventy, one of our upcoming official "Create Project" starters!

Thank you!


Remove AWS stuff

The Amazonka library is going to have quite a few breaking changes in the next major version. I was originally going to try to support both versions simultaneously, but I don't think that will be possible. For one thing, the MonadAWS class will go away entirely.
https://github.com/brendanhay/amazonka/blob/27322ea0db68712e1c331be4124080144c975750/lib/amazonka/CHANGELOG.md
Since the blast area is so small, I decided to simply remove Amazonka.

[ ] I manually tested the code locally to make sure that it works.
[ ] If there is documentation, I made sure it's accurate and up to date.
[ ] If possible, I wrote automated tests for the new behavior.

The build failure is unrelated to these changes.


Change the title bar text

What is your question?
When you try to change the title bar, click on the
(PlayState.hx)

#if desktop
import Discord.DiscordClient;

and add the following under

import lime.app.Application;

In addition, add the following to

var songName:String = Paths.formatToSongPath(SONG.song);

and add the following under

Application.current.window.title("Friday Night Funkin': Psych Engine - Now playing "+songName);

In addition, add the following to

		if(endingSong)
		{

added the following under the

Application.current.window.title("Friday Night Funkin': Psych Engine");

However, I get the following error at build time

source/PlayState.hx:1676: characters 4-72 : String cannot be called
source/PlayState.hx:441: characters 3-95 : String cannot be called

This may be strange because I am using DeepL translation.

it's not a function

it's not a function

it's not a function
Application.current.window.title = "Title Here";

Thank you! It worked!


[Istio V2] Add possibility to add/remove istio auto injection namespace label with a click

The ember UI has a very handy feature to quickly add and remove the istio-injection=enabled namespace label with a click.

It would be great, if this is also available in the new UI.

Verified on 2.5-head[v2.5-8d5b3b8d933d04b04e0f0ae3a23d48d0a962c53f-head] and master-head[master-3ba112acba52c36b87c2bf88c40a64c693fba41d-head]
Rancher versions the above has been verified on:
Rancher | v2.5-8d5b3b8d933d04b04e0f0ae3a23d48d0a962c53f-head
User Interface | v2.5-dev
Helm | v2.16.8-rancher1
Machine | v0.15.0-rancher49
Rancher | master-3ba112acba52c36b87c2bf88c40a64c693fba41d-head
User Interface | vmaster-dev
Helm | v2.16.8-rancher1
Machine | v0.15.0-rancher49
Create a cluster and from the dashboard, install monitoring[9.4.202] and istio[1.7.600] from the apps and marketplace.
From the namespaces, create multiple namespaces and once active select the created namespaces and enable the istio auto injection. Verified that the sidecar injection has been enabled. Now disable the auto-injection and verified its disabled.
Install istio[1.7.301]. Performed similar actions from above and verified its working as expected. Upgrade the istio from 1.7.301 to 1.7.600 and verified the side car is enabled/disabled.
Screenshot showing all of the namespaces have istio-auto injection enabled

Screen shot highlights both enable and disable options as one of them has auto injection enabled and rest two has auto injection disabled

Verified on 2.5-head[v2.5-8d5b3b8d933d04b04e0f0ae3a23d48d0a962c53f-head] and master-head[master-3ba112acba52c36b87c2bf88c40a64c693fba41d-head]
Rancher versions the above has been verified on:
Rancher | v2.5-8d5b3b8d933d04b04e0f0ae3a23d48d0a962c53f-head
User Interface | v2.5-dev
Helm | v2.16.8-rancher1
Machine | v0.15.0-rancher49
Rancher | master-3ba112acba52c36b87c2bf88c40a64c693fba41d-head
User Interface | vmaster-dev
Helm | v2.16.8-rancher1
Machine | v0.15.0-rancher49
Create a cluster and from the dashboard, install monitoring[9.4.202] and istio[1.7.600] from the apps and marketplace.
From the namespaces, create multiple namespaces and once active select the created namespaces and enable the istio auto injection. Verified that the sidecar injection has been enabled. Now disable the auto-injection and verified its disabled.
Install istio[1.7.301]. Performed similar actions from above and verified its working as expected. Upgrade the istio from 1.7.301 to 1.7.600 and verified the side car is enabled/disabled.
Screenshot showing all of the namespaces have istio-auto injection enabled

Screen shot highlights both enable and disable options as one of them has auto injection enabled and rest two has auto injection disabled


Add debug logging for Exchange handling

Port from 7.8 to master of extra debug logging for Exchange Mail handling issues.

See #4394 and issue #4328


Redesign

There are a lot of things going on in this PR. A summary of the changes:

The main change is that formulae/terms.py does not exist anymore and all the functionality in there was moved to smaller classes that live under formulae/terms/.
None of the changes impact the usage of the library. design_matrices() works the same way it used to.
We have stateful transformations. This allows us to implement a method to pass new data and obtain the design matrix for the new data consistently with transformations applied originally.
The computation of the design matrices should be faster because unnecessary redundancies were removed. However, I'm not saying redundancies do not exist!

UPDATE: This PR actually does not speed up anything. The following
np.random.seed(1234)
size = 2000
data = pd.DataFrame(
    {
        "y": np.random.uniform(size=size),
        "x1": np.random.uniform(size=size),
        "x2": np.random.uniform(size=size),
        "x3": np.random.choice([1, 2, 3, 4], size=size),
        "f": np.random.choice(["A", "B"], size=size),
        "g": np.random.choice(["A", "B"], size=size)
    }
)
%timeit design_matrices("y ~ x1 + x2 + f:g", data)

Returns something like
4.22 ms ± 86.8 µs per loop (mean ± std. dev. of 7 runs, 100 loops each)
in both cases

Some quick benchmarks. It may be good to add official benchmarks.
import pandas as pd
import numpy as np

from formulae import model_description
from patsy import dmatrices
from formulaic import Formula

np.random.seed(1234)
def get_data(size):
    data = pd.DataFrame(
        {
            "y": np.random.uniform(size=size),
            "x1": np.random.uniform(size=size),
            "x2": np.random.uniform(size=size),
            "f": np.random.choice(["A", "B"], size=size),
            "g": np.random.choice(["A", "B"], size=size),
            "h": np.random.choice(["A", "B"], size=size),
            "j": np.random.choice(["A", "B"], size=size),
        }
    )
    return data

formula = "y ~ x1 + x2 + f:g + h:j:x2"
data = get_data(100)
%timeit design_matrices(formula, data)
%timeit dmatrices(formula, data)
%timeit Formula(formula).get_model_matrix(data)
6.24 ms ± 684 µs per loop (mean ± std. dev. of 7 runs, 100 loops each)
7.7 ms ± 34.1 µs per loop (mean ± std. dev. of 7 runs, 100 loops each)
7.68 ms ± 84.9 µs per loop (mean ± std. dev. of 7 runs, 100 loops each)

data = get_data(1000)
%timeit design_matrices(formula, data)
%timeit dmatrices(formula, data)
%timeit Formula(formula).get_model_matrix(data)
6.44 ms ± 21.7 µs per loop (mean ± std. dev. of 7 runs, 100 loops each)
18.9 ms ± 32.7 µs per loop (mean ± std. dev. of 7 runs, 100 loops each)
7.76 ms ± 7.08 µs per loop (mean ± std. dev. of 7 runs, 100 loops each)

data = get_data(10000)
%timeit design_matrices(formula, data)
%timeit dmatrices(formula, data)
%timeit Formula(formula).get_model_matrix(data)
11.7 ms ± 7.54 µs per loop (mean ± std. dev. of 7 runs, 100 loops each)
128 ms ± 334 µs per loop (mean ± std. dev. of 7 runs, 10 loops each)
10.5 ms ± 29.1 µs per loop (mean ± std. dev. of 7 runs, 100 loops each)


nixos/bookstack: conflicting types for appKeyFile

Describe the bug
While trying to use the bookstack module I encountered this error:
error:
       … while calling the 'head' builtin

         at /nix/store/3kwj19dbdfxnjbcns4hw307ylhz3wgrm-source/lib/attrsets.nix:1541:11:

         1540|         || pred here (elemAt values 1) (head values) then
         1541|           head values
             |           ^
         1542|         else

       … while evaluating the attribute 'value'

         at /nix/store/3kwj19dbdfxnjbcns4hw307ylhz3wgrm-source/lib/modules.nix:809:9:

          808|     in warnDeprecation opt //
          809|       { value = builtins.addErrorContext "while evaluating the option `${showOption loc}':" value;
             |         ^
          810|         inherit (res.defsFinal') highestPrio;

       (stack trace truncated; use '--show-trace' to show the full trace)

       error: A definition for option `services.bookstack.config.APP_KEY._secret' is not of type `null or string'. Definition values:
       - In `/nix/store/3kwj19dbdfxnjbcns4hw307ylhz3wgrm-source/nixos/modules/services/web-apps/bookstack.nix': /run/keys/bookstack-appkey
error: Recipe `rebuild` failed on line 17 with exit code 1

Despite having not set services.bookstack.config.APP_KEY._secret. It looks
like the module is setting services.bookstack.config.APP_KEY._secret to
be services.bookstack.appKeyFile despite them having disparate types.
Steps To Reproduce
The following configuration triggers the issue.
services.bookstack = {
  enable = true;
  appKeyFile = /run/keys/bookstack-appkey;
};

Expected behavior
The config does not type error on variables I have not manipulated.
Additional context
Nixpkgs revision
5c24cf2f0a12ad855f444c30b2421d044120c66f
Workaround
I was able to work around this problem with the following config:
services.bookstack = {
  enable = true;
  appKeyFile = /run/keys/bookstack-appkey;
  config.APP_KEY._secret = lib.mkForce (toString config.services.bookstack.appKeyFile);
};

Notify maintainers
@ymarkus
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 6.6.26, NixOS, 24.05 (Uakari), 24.05.20240419.5c24cf2`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.18.2`
 - nixpkgs: `/etc/nix/path/nixpkgs`

Add a :+1: reaction to issues you find important.

you shouldn't be using a path here, use a string instead

You can't use a string, it complains that it has to be a path.
Apr 20, 2024 6:47:44 PM éclairevoyant @.***>:

you shouldn't be using a path here, use a string instead
—
Reply to this email directly, view it on GitHub[https://github.com/NixOS/nixpkgs/issues/305566#issuecomment-2067816137], or unsubscribe[https://github.com/notifications/unsubscribe-auth/ALEG4APREVH2X2RGEVYZG4TY6L5BNAVCNFSM6AAAAABGQRWXVWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRXHAYTMMJTG4].
You are receiving this because you authored the thread.
[Tracking image][https://github.com/notifications/beacon/ALEG4AI7LLC7ZW4JSL7WHO3Y6L5BNA5CNFSM6AAAAABGQRWXVWWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTT3IBPMS.gif]

https://github.com/NixOS/nixpkgs/blob/754a00b38a44e774dba3518ced7efbf51a8970ba/nixos/modules/services/web-apps/bookstack.nix#L51 in particular here is it where it forces that's a path

lib.types.path includes any string that starts with /

I could have sworn I had tried that :sweat_smile:. Thanks.


👂 Set a custom listen address if provided

When running in OpenShift, installer needs to listen on a different
address (and possibly different port, too). Allow a user to specify a
custom listen address via environment variable.
Signed-off-by: Major Hayden<EMAIL_ADDRESS>

This is a re-do of https://github.com/osbuild/image-builder/pull/11 which somehow broke with the project rename. :shrug:


Add more filters and sorting options to the list

Hey there,
First of all, really neat UI for the awesome-self-hosted data, impressive work!
A welcome addition would be to add more filters/sort options on the list, like

most popular repo over the past month/year (probably the increase of the count of github stars over the given period)
filter by number of commit past year (only show active repos, or very-active ones like those with >N commits/year
filter by number of stars, number of maintainers, languages, date of creation, etc.

An out-of-scope nice view could also be to show on a single page, the 3 most starred repos for each category, each on its own line.

Hey @jo-chemla
Thank you for your suggestions! This would be great, I will go through each one seperately:

Most popular repo: This somewhat ties into https://github.com/mkitzmann/awwesome/issues/8, as we would have to request the stars of each repo for the last month/year. Sadly github currently does not provide a star count per timeframe at the moment, so each star date would be requested and then accumulated. Probably is quite time consuming.
filter by number of commits: This should be pretty straight forward since we already get the number of commits per month for the graph.
filter by number of stars: Also pretty simple if only the total is used, otherwise more complex as in point 1.
filter by number of maintainers: We are currently not getting this info, but should be part of the graphql schema.
filter by languages: I had trouble with languages (as in Javascript, C++), as the GraphQL did not seem to provide this info
filter by date of creation: That could be done, but we would need to create a range datepicker or find a suitable library
Highlight 3 most starred repos: Do you think this would show any more information than the usual card or additional things?

Hey,
Thanks for getting back so quickly and the detailed reply!

Indeed I would have assumed Github would allow to count stargazers at different timestamps via their graphql endpoint, or at least that they would provide with these "last-month trend". Will follow the star-history thread.
Indeed most of the filters I mentionned are based on properties already aggregated for each repo (number of commits, stars, date-of-creation). Are you using a specific UI framework (asking for the daterange-picker.
Understood for the languages not returned by the graphql endpoint.
And finally, indeed, the think I had in mind was just simply displaying the usual card, maybe 3 per category - interleaved with the title of the category before the corresponding most starred cards.
Hope this helps clarify the suggestion, don't hesitate if you need anything else!


gdb: fix charset issue on darwin, missing libiconv

Description of changes
Hi. gdb on darwin have charset issue.
Currently in nixpkgs libiconv is missing, so gdb will fallback to ISO-8859-1 and set charset feature is disabled.
This was discovered during: https://github.com/NixOS/nixpkgs/pull/222046
Examples:
Linux from nixpkgs ✅
(gdb) show charset
The host character set is "auto; currently ANSI_X3.4-1968".
The target character set is "auto; currently ANSI_X3.4-1968".
The target wide character set is "auto; currently UTF-32".
(gdb) set charset UTF-8
(gdb) show charset
The host character set is "UTF-8".
The target character set is "UTF-8".
The target wide character set is "auto; currently UTF-32".

Macos from nixpkgs ❌
(gdb) show charset
The host character set is "auto; currently ISO-8859-1".
The target character set is "auto; currently ISO-8859-1".
The target wide character set is "auto; currently UTF-32".
(gdb) set charset UTF-8
Undefined item: "UTF-8".

Macos with libiconv ✅
(gdb) show charset
The host character set is "auto; currently UTF-8".
The target character set is "auto; currently UTF-8".
The target wide character set is "auto; currently UTF-32".
(gdb) set charset UTF-32
(gdb) show charset
The host character set is "UTF-32".
The target character set is "UTF-32".
The target wide character set is "auto; currently UTF-32".

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
~- [ ] aarch64-darwin~

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

@ofborg build gdb


When browsing/adding scenes, changing spatial filters clears the UI with no intuitive way back

//The title of this issue is fairly useless, hopefully someone can find a more descriptive title

Create a project and browse scenes to add:

Select a different cell/spatial filter as if to add scenes from a different part of the map:

//All of the scenes on the left are refreshed with what's available at the new spatial filter, but the previously selected scenes are gone. The natural instinct is to hit "back" to return to the previous selection, but that option doesn't exist. What if I want to remove those scenes that I selected? How do I find them again?

Try selecting overlapping spatial filters to get your previous scenes back:

It works! They are back! But it would be nice to "keep" selected scenes in that menu even if I move away from the area I original was searching in. I may decide I want to remove them, but I have to recreate the spatial filter to find them again to remove them.

My feeling on what would be expected here is that when a user selects a scene and changes filters that those scenes would then be excluded that the selected scenes should be persisted in the sidebar and moved to the top.

@notthatbreezy I agree!
Another potential enhancement tangentially related would be a "back" button that returned you to your previous state in case you accidentally clicked out of your spatial filter and didn't want to have to reconstruct it.

I can see that working for some filters, but for others like the filter on the map view, I'm not sure.
For instance - user resizes their browser window and causes a scene list refresh, then hits back. What does it do? We can't restore the old browser size, and if we just revert the filter, then it's listing scenes outside of the view or not listing all of the scenes in the view.

This issue is pretty old and I don't think it's as relevant with shape filters


pkg/scheduled_test tests timeout in IE

 Issue by kevmoo
Originally opened as dart-lang/sdk#21007

#IE 10
scheduled_test/test/scheduled_test/current_schedule_errors_test
scheduled_test/test/scheduled_test/nested_task_test
scheduled_test/test/scheduled_test/out_of_band_task_test
scheduled_test/test/scheduled_test/signal_error_test
scheduled_test/test/scheduled_test/task_return_value_test
scheduled_test/test/scheduled_test/timeout_test
scheduled_test/test/scheduled_test/wrap_async_test
scheduled_test/test/scheduled_test/wrap_future_test
#IE 11
scheduled_test/test/scheduled_test/task_return_value_test
scheduled_test/test/scheduled_test/wrap_future_test

 Comment by floitschG

Added Area-Pkg, Pkg-ScheduledTest, Triaged labels.

@kevmoo is this still the case with the new test runner support?

@nex3 We'll have to see once the bots are updated to the latest scheduled_test. I don't have my VM working yet where I can run these tests.


gcmon stops emitting GC events if a 2nd gcmon is used to monitor the first

Open admin console
Run gcmon on a process dotnet gcmon -n <processName>
Observe that it is emitting GC events / works as expected.
Open a 2nd admin console
Run a 2nd gcmon instance to monitor the first dotnet gcmon -p <pidOfFirstGcMonProcess>

Expected: The first gcmon process continues to work as expected and the second one reports on the 1st's GC behavior.
Actual: The first gcmon appears to stop writing gc events to the output once the 2nd starts monitoring it.
I've been able to repro this on Windows 10 20H2. Haven't tried any other platforms.

Could this be because the name of the session is hardcoded as MySession here and we are opening multiple of these sessions, which seems like a violation of what's described in the TraceProgrammer's Guide in this section:

"Creates a new TraceEventSession, each session is given a name that is unique ACROSS THE MACHINE. In our case we called our session MySession. Sessions CAN live beyond the lifetime of process that created them, and this name is how you refer to these sessions from other processes besides the process that created them. We also specify a file where the data is to be logged. By convention, these data files use the .ETL (Event Trace Log) suffix."

Solution: Pass in a forced unique session name via a command line argument.

@MokoSan that certainly sounds like a plausible cause :)

Just proved that my hypothesis is true.. Will add a new command line arg for specifying the name of the session.

If the arg is not passed by the user, could the session name be random (a
guid?) to avoid collision? My reasoning is: As a user, I don’t want to have
to remember to use an extra argument if I’m running more than one gcmon
instance.
On Tue, Nov 23, 2021 at 10:07 PM Mukund Raghav Sharma <
@.***> wrote:

Just proved that my hypothesis is true.. Will add a new command line arg
for specifying the name of the session.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Maoni0/realmon/issues/25#issuecomment-977561838, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAENIH5C42DXNIDNVMYPMMDUNR6K7ANCNFSM5IUJPJUQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Yup - my alternative solution was exactly along those lines.. A guid based name of a session was what I was going for. More I think about this, the more I agree with your rationale - as it is, we have enough command line args. Thanks!


update build

Update to sbt 1.0.x

Looks good, but builds seem to be failing 🤔

I try to run the tests in master and failed too, integrations test by the way, so it can be failing by the test repo, @juanpedromoreno can you confirm it?

Mmm... It seems to be a binary incompatibility, I'd need to look at it deeper

Is the current issue the same that you found last week, @suhasgaddam ?

I'm going to mark this as blocked until the test library is fixed

Could we go ahead keeping 0.13.16?

I can try but freestyle doesn't is for scala 2.10, It's ok if I remove that support?

@AdrianRaFo unless I missed a PR, github4s still supports 2.10 and has not switched to freestyle yet. The build project can use 0.13/2.10, and the "real" project can use any Scala version. (I think I am using bad wording with respect to build vs "real" project.)

@suhasgaddam the purpose of my pr is to prepare github4s to make a freestyle migration

I'm 👍 on dropping 2.10

Ah, for some reason I thought it was only to bump sbt-org-policies. You can still make forward progress on converting to freestyle with keeping the sbt version to 0.13.16 and bumping sbt-org-policies.
It gets interesting because sbt-org-policies itself has a dependency on github4s(currently the cats 0.9 version due to another issue), but that dependency will not collide with the "real" project.
In terms of dropping 2.10(specifically the consequences for sbt-org-policies), I'll defer to @juanpedromoreno. We'll eventually stop publishing sbt-org-policies for 0.13.16, but I have no idea for that timeline.


Running appRun or jettyRun in eclipse automatically stops

The system doesn't keep running.  It just automatically stops.  Running from the command line works fine.
I saw a similar issue was posted a while back regarding IntelliJ

Thank you for your awesome plugin! I have tried to run ./gradlew appRun; when I run it from the terminal it correctly blocks until I press Ctrl+C. Yet when I try to run it (or debug it) from Intellij, it will just terminate immediately:
...
15:32:34 INFO  Jetty 9.2.15.v20160210 started and listening on port 8080
15:32:34 INFO  myproject runs at:
15:32:34 INFO    http://localhost:8080/myproject
Press any key to stop the server.
15:32:34.456 [main] INFO  c.b.b.u.s.ServicesServletListener - All services were closed

BUILD SUCCESSFUL

Total time: 10.975 secs


QrCode lifetime

Hi, I'm using this package and I would like to know the lifetime of a generated QrCode.
@Cordobo

QR-Codes generated with angularx-qrcode do not have a limited lifetime.


Definition files vs projects

Please have a look at the individual commit messages for the details.

Merging despite the unrelated test failure.


WIP: Conversations

ToDo's
Service 'conversations'

[x] create
[ ] add methods create() & writeMessage()
[ ] add tests

Component 'conversations'

[ ] create

Component '_conversationsList'

[ ] create
[ ] show conversations or 'No Conversations'
[ ] Actions: delete, mark as read
[ ] translation
[ ] Pagination (optional)

Component '_conversation'

[ ] create
[ ] show messages
[ ] participates-list
[ ] reply
[ ] error when there are no participates anymore
[ ] translation

Wow, thank you for tackling this @alangecker - I'm at your service if you need something.
Some thoughts: do you also plan to integrate real-time chat using socket.io? There is the /socket/ endpoint configured at the server and it should also work in the backend.

We could merge the conversation service first, and then add the other components. Makes it faster to work on. What do you think?

good point! moved the ToDo's to an Issue #151, this PR is now only about the service.
i didn't planned it so far, because i'm still running into a lot of angular-related problems during just creating simple components...  :D
but i guess for somebody who knows how, it should not be that difficult to let the angular component listen for updates from the service


splunk make eventfield plural

What this PR does / why we need it:
This change allows to set multiple eventFields as described in the crd and supportet in the plugin
Which issue(s) this PR fixes:

Fixes #446
Does this PR introduced a user-facing change?

Splunk output for fluentbit:  changed the field eventField: string to eventFields: []string`.

Additional documentation, usage docs, etc.:

@havardelnan Thanks for the contribution


add jws parsing

do not add kid to a jwt body
add jws parsing

Codecov Report

Merging #247 (6cc3dd5) into main (c1d4b23) will increase coverage by 0.01%.
The diff coverage is 36.36%.

@@            Coverage Diff             @@
##             main     #247      +/-   ##
==========================================
+ Coverage   59.38%   59.39%   +0.01%
==========================================
  Files          38       38
  Lines        4276     4280       +4
==========================================
+ Hits         2539     2542       +3
- Misses       1335     1336       +1
  Partials      402      402

Impacted Files
Coverage Δ

crypto/jwt.go
38.30% <36.36%> (+1.07%)
:arrow_up:


Trace tags are not accounting for parameterized URLs

https://github.com/micrometer-metrics/micrometer/blob/master/micrometer-spring-legacy/src/main/java/io/micrometer/spring/web/servlet/WebMvcTags.java#L68

Done through https://github.com/spring-cloud/spring-cloud-sleuth/pull/878


iOS/Safari does not work if camera facingMode has been changed

Describe the bug
NOTE: Using an established video element

Error thrown (twice) on iOS (as seen in issue #14), but tracking initiates and works if facingMode has not changed:
WebGL: INVALID_OPERATION: texImage2D: type HALF_FLOAT_OES but ArrayBufferView is not NULL

If the facingMode has been changed ("user" or "environment", as seen below), tracking fails to start.
         this.mediaDevices.getUserMedia({
             "audio": false,
             "video": this.params.constraints || {
                 minWidth: this.params.dest_width,
                 minHeight: this.params.dest_height,
                 facingMode: "user"
             }
         })

To Reproduce
Steps to reproduce the behavior:

Instantiate new video element and use getUserMedia to start it up
Change the facingMode of the video element and re-attach to the camera
Attempt to init jeelizFaceFilter on the established video element
Errors are thrown and tracking fails

Expected behavior
Face tracking should start, regardless of if the camera has been re-bound with new constraints prior to init.
Smartphone (please complete the following information):

Device: iPhone 6
OS: iOS 11.4
Browser: Safari
Version: 11.4

More investigation shows that this is not about the switching of the facingMode, but in fact a timing issue. the stream was not ready after being switched, so when jeeliz went to look for the face, it didn't find a ready video element.
That said, I'm still receiving the following error twice (first on variable 'b' on line 1705 and second on variable 'n' on line 1163):
WebGL: INVALID_OPERATION: texImage2D: type HALF_FLOAT_OES but ArrayBufferView is not NULL

Thanks for the quick response! No worries on the stuff you listed... everything is working well now that I rewrote some of my code to wait and ensure the video stream is live before running init on the facial tracking.


use with shadow dom

I want to use it in my chrome webext project. Here is my content-script to apply styles
const container = document.createElement('div')
const root = document.createElement('div')
const styleEl = document.createElement('link')
const shadowDOM = container.attachShadow?.({ mode: __DEV__ ? 'open' : 'closed' }) || container
container.className = 'repo-stack'
styleEl.setAttribute('rel', 'stylesheet')
styleEl.setAttribute('href', browser.runtime.getURL('dist/contentScripts/style.css'))
shadowDOM.appendChild(styleEl)
shadowDOM.appendChild(root)
document.body.appendChild(container)
render(<App />, root)

It will looks like this

However, the CSS variables from daisyui is on :root, so component UI is broken. Is there anyway to fix this...

I did not find it necessary to add the data-theme attribute to the shadow dom, css variables work fine inside shadow dom. Therefore, an approach like this one works very well.


Makeability Lab TEST server showing up in Google search results

We need to add a robots.txt file to test (but not to production).
From reading about this, it seems like the file should simply say:

User-agent: * Disallow: /

Some directions from Google: https://developers.google.com/search/docs/advanced/robots/create-robots-txt#:~:text=txt file.-,The robots.,.com%2Frobots.txt .
And moz: https://moz.com/learn/seo/robotstxt

This is complete.  I've placed the file at /cse/web/research/makelab/www-test/robots.txt and made an alias on the -test webserver to serve that up.
https://makeabilitylab-test.cs.washington.edu/robots.txt

hrmph.  It's evaluating correctly for https, but not http.    This might be a limitation of the testers?  The RFC (and google's documentation) says it'll follow 5 redirect hops before treating the file as 404.

I've been reading up a bit on how to prevent sites from being shown in search engines, and it doesn't seem like the robots.txt file and preventing indexing is the thing that needs to be done.
From this link:

@mechanicjay is this something that you could do? And does this look like a real solution to you?
Another link with more concrete steps but less explanation of why: https://www.ilfusion.com/how-to-prevent-google-from-indexing-certain-web-pages#:~:text=1.,shown in search engine results.

I have no experience with this so I personally don't know what is best. I thought this would be sufficient:

Looks like this is now fixed!

I believe @mechanicjay fixed it by using @misaugstad's proposed solution:
https://github.com/makeabilitylab/makeabilitylabwebsite/issues/1000#issuecomment-1063315541

Okay I don't actually think that it's fully working :/ If you look at the second link below, it still points to the test server. And for Project Sidewalk, the Amsterdam test server is still the only one showing up at the top :pensive:

Ugh, oh no!

The file is valid, and the testers evaluate it properly for https, but
don't respect it for http -- not sure what's going on there yet, will
look into it.
--Jason
On 3/9/22 09:34, Jon Froehlich wrote:

Thanks for the fast response Jason. I've now tested this with online
|robots.txt| testers and it doesn't seem to be working correctly. I've
never written a |robots.txt| file before, have you? Did I make a mistake?
For example, this tester https://en.ryte.com/free-tools/robots-txt/
says that Googlebot is allowed on our site:
image
https://user-images.githubusercontent.com/1621749/157498177-ad8c4069-7e05-43f8-a8fa-9ba7dd12b21b.png
And this one https://technicalseo.com/tools/robots-txt/ says
"Result: Allowed" as well—not sure if I'm interpreting it correctly or
not, however:
image
https://user-images.githubusercontent.com/1621749/157498317-3e1c7eb3-7ec7-45b1-a356-bee22b6bfbc7.png
—
Reply to this email directly, view it on GitHub
https://github.com/makeabilitylab/makeabilitylabwebsite/issues/1000#issuecomment-1063181680,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABR54ZRR4KO5V2FZOZKRIUDU7DOLFANCNFSM5QJQSTIQ.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were assigned.Message ID:
@.***>

I think it's working now:

Thanks @mechanicjay and @misaugstad


New version: Kronecker v0.2.2

Registering package: Kronecker
Repository: https://github.com/MichielStock/Kronecker.jl
Created by: @MichielStock
Version: v0.2.2
Commit: a626a84ee5ed3d67e08e898ec007b16a6e605646
Reviewed by: @MichielStock
Reference: https://github.com/MichielStock/Kronecker.jl/commit/a626a84ee5ed3d67e08e898ec007b16a6e605646#commitcomment-34716686

Needs a retrigger due to conflicts.


feat: react-navigation support

This PR adds a createMaterialCollapsibleTopTabNavigator function which can be used with react-navigation.
Usage:
import {createMaterialCollapsibleTopTabNavigator} from 'react-native-collapsible-tab-view';

const Tab = createMaterialCollapsibleTopTabNavigator();

export function YourTabScreen() {
  return (
    <Tab.Navigator
      collapsibleOptions={{
        tabBarHeight: 30,
        // disableSnap: true,
        headerHeight: 250,
        renderHeader: () => <CoverImage {...params} />,
      }}
   ...

Additionally, I made some hopefully minor project infrastructure changes:

It seems that the root project was set up to use npm and had a package-lock.json but the scripts in package.json were using yarn. So I changed it to yarn.
Added a prepack script so that it can be installed from git and properly compiled. (prepack is ran when installing a git dependency)
In order for prepack not to fail because bob build also type checks the example folder, I excluded example from being compiled by the root and instead created its own tsconfig.json

If you have any questions or concerns, let me know. See individual commits for details.
It can be tested via:
yarn add react-native-collapsible-tab-view@andreialecu/react-native-collapsible-tab-view#navigation
(documentation still needs to be updated, and the example as well)

PS: Allow edits from maintainers is on, feel free to adjust anything as necessary.

Don't mind the expo preview action failing, it won't work because PR doesn't have access to my secrets env variables. Can you add an example to the example folder?

Sorry for taking a long time to review this, I'm on a busy week, but will review it later

@PedroBern I added an example. If you wouldn't mind updating the docs for it it would be great, you'd be doing a better job at it than me.

It seems that #12 still had a minor issue if you initiated a momentum scroll gesture while the header was in the process of snapping back. The loop would still start and make the snapping janky. You can reproduce it by scrolling quickly while it's snapping back on main.
I have added a commit that reworks the debounce into a throttle, and removed the dependency that #12 added. It seems to work better overall, and is quicker to snap back.
I added it as part of this PR since it was easier to do, otherwise I need to keep merging main into this branch, hopefully that's ok.

@PedroBern I added an example. If you wouldn't mind updating the docs for it it would be great, you'd be doing a better job at it than me.

It's perfect, I will release after updating the docs

@andreialecu I haven't tried to use the project without react-navigation after this PR, until now with #27. Looks like it's not an optional dependency. I tried, but don't know exactly how to conditionally export the navigator. Perhaps do you know? If you don't know, I will have to set it as a peer dependency without the optional meta field.

Can you clarify what the error or behavior you are seeing is?
The dependencies are added as optional via the peerDependenciesMeta field, which is supported by all package managers, so it should work properly as-is and indeed be optional.


sim: role_name attribute used by ScenarioRunner for CARLA

Added role_name attribute to sim that is used by ScenarioRunner for the CARLA simulator.

What exactly does this do?

This attribute is used by Scenario Runner for CARLA. Without this attribute, Scenario Runner cannot recognize the ego (hero) vehicle.
Info: https://carla.readthedocs.io/en/latest/ts_traffic_simulation_overview/#scenario-runner-and-openscenario
Repo: https://github.com/carla-simulator/scenario_runner
The line of code which retrieves the attribute: https://github.com/carla-simulator/scenario_runner/blob/master/srunner/scenariomanager/carla_data_provider.py#L740


Update Weave Net to 1.7.2

https://github.com/weaveworks/weave/releases/tag/v1.7.2
https://github.com/weaveworks/weave/releases/tag/v1.7.1
https://github.com/weaveworks/weave/releases/tag/v1.7.0
https://github.com/weaveworks/weave/releases/tag/v1.6.2
https://github.com/weaveworks/weave/releases/tag/v1.6.1
https://github.com/weaveworks/weave/releases/tag/v1.6.0

LGTM, works locally with two Vagrant CoreOS stable 1122.2.0 nodes:
        Version: 1.7.2 (up to date; next check at 2016/10/17 14:14:01)

        Service: router
       Protocol: weave 1..2
           Name: c6:3f:e0:48:25:8d(core-01)
     Encryption: enabled
  PeerDiscovery: enabled
        Targets: 0
    Connections: 1 (1 established)
          Peers: 2 (with 2 established connections)
 TrustedSubnets: none

        Service: dns
         Domain: kontena.local.
       Upstream: <IP_ADDRESS>
            TTL: 1
        Entries: 30


Dev server for Firefox MV3

Is your feature request related to a bug?
N/A
What are the alternatives?
Currently, there is no alternative
Additional context
I discovered that when I register a Firestore event listener in the background script, not only does it prevent the background script from being terminated, but on all browsers, including Firefox MV3, whenever I make a change in the Firestore database, the attached event listener will fire instantly
It's worth exploring how the Firebase team managed to do this and apply the same technique to make a dev server for Firefox
I believe that this is the function

They use a websocket. Websockets are known to keep the background service worker alive. But there are other ways as well, like what WXT does for development: https://github.com/wxt-dev/wxt/blob/main/packages%2Fwxt%2Fsrc%2Fvirtual%2Futils%2Fkeep-service-worker-alive.ts
Not sure how this would help with the last TODO of #230 though... Is this about adding support to dev mode for Firefox MV3? If so, how would this help us?

I'm not sure of the mechanics that the Firebase SDK uses to connect between the client and the server, but the team worked it out such that as soon as as soon as a ping is sent from the server, the client can respond
If a similar mechanism could be implemented in WXT, it can enable restarting parts of the extension similar to how you made WXT do it in Chrome MV3


Fix auto_sweep in Keysight N52xx Driver

This fixes #5089 and reenables auto_sweep.
I also fix the units for polar which should be a ratio rather than a voltage.

Thanks @spauka would you mind adding a changelog note for this?

Done :)


AUR Package Provider

Solves #2845
Adds a package provider & relevant tests for the Arch User Repository (AUR). The code is based largely on the existing pacman provider.
Roughly analogous to apt's ppas, AUR is a very popular package source for Arch Linux users, and seems to be appropriate for inclusion into the chef client (since ppas are supported as well).

Just a quick glance, this does not really install any of the dependencies for the package you are wanting to install...seems like something that would get annoying.
Other thoughts...I would rather see this going into an awesome arch community cookbook.

It does not, but dependency installation is totally doable.
As far as an awesome arch community cookbook, it seems like there is really
not much out there. I'd be happy to make a pacman/pacaur equivalent of the
apt cookbook or something like that, but I also figured that the native
chef client ought to have at least rudimentary AUR support.
On Sun, Feb 1, 2015 at 7:25 PM, Jay Mundrawala<EMAIL_ADDRESS>wrote:

Just a quick glance, this does not really install any of the dependencies
for the package you are wanting to install...seems like something that
would get annoying.
Other thoughts...I would rather see this going into an awesome arch
community cookbook.
—
Reply to this email directly or view it on GitHub
https://github.com/chef/chef/pull/2846#issuecomment-72393371.

--
Ryan Chipman
MIT Course 6 2016
B.S. Computer Science and Engineering
ryanchipman.com

Yeah we've been accepting other package providers into core and we should probably accept this one into core as well.  There's a template for doing it from all the package providers before it.

Couple things are left on my TODO list for this one. It works well eonugh, but I should really add automatic dependency resolution (since that is generally the default package manager behavior).
Also, I think this and the pacman provider could both use a bit of cleaning up. For example, both of these use pacman -R instead of pacman -Rs, which means orphaned dependencies are not removed. Maybe I'll make that a separate issue? Seems like properly supporting pacman's different options might have some room for discussion itself.

Getting this on the appveyor build:
OpenSSL::SSL::SSLError: SSL_connect returned=1 errno=0 state=SSLv3 read server certificate B: certificate verify failed

It seems to me that the build machine's ssl certs may need to be updated. (Also, if you google this, you will see that it is a common pain point with ruby Net:HTTP requests) It runs fine on my local machine.
Impossible to work around by just using HTTP/port 80, since that serves up html for a 301 redirect page, and not the actual content. It seems that SSL is necessary for the query.

@rychipman A rebase against master should resolve the cause of these build failures (they are failing due to some audit mode issue which should be addressed in master) and a squash of the outstanding commits will help make this more merge-able.

Hi. I am an automated pull request bot named Curry. There are commits in this pull request whose authors are not yet authorized to contribute to Chef Software, Inc. projects or are using a non-GitHub verified email address. To become authorized to contribute, you will need to sign the Contributor License Agreement (CLA) as an individual or on behalf of your company. You can read more on Chef's blog.
GitHub Users Who Are Not Authorized To Contribute
The following GitHub users do not appear to have signed a CLA:

@rychipman

Please sign the CLA here.

@rychipman are you still interested in getting this merged?  We'd need the CLA signed and would need a fresh rebase against master.

@rychipman Unfortunately, without a valid CLA we can't do anything with this PR. We'd love to take this code, even if you have no more time to work on it - just sign the CLA and we'll get it polished up and merged. If you do, please feel free to reopen this PR. Thank you!

Hi. Your friendly Curry bot here. Just letting you know that all commit authors have become authorized to contribute. I have added the "Signed CLA" label to this issue so it can easily be found in the future.

Signed the CLA. Would be interesting in cleaning up and merging.

well, i'd reopen the PR but it says the repo has been deleted and its greyed out so i can't now...

if you've got it laying around on disk feel free to push it up to github again


How to make custom audio EQ

Hello I want to make custom EQ for song which are playing.
i have apply
POP
JAZZ
ROCK
CLASSICAL
DEEP
DANCE
like etc
is that posible using.
please let me know

The custom EQing settings you listed are just that: EQ settings. So for example, people used a 10-band Peaking EQ filter set-up and just preselected a few settings that they thought fitting for pop or jazz or rock etc. I don't have a list of those settings, but I imagine you will be able to find them somewhere online, or come up with your own.
Or is your question about detecting the genre (pop, jazz, rock..) automatically?


Make aspect ratio crop feature gone in the newest version?

Hi. I've been trying to get my pictures cropped to the maximum according to the aspect ratio on load. I found a nice example, but I've come to realize that this feature plainly doesn't work in the newest version, although it it's there in 6.0.4. I would have downgraded but I am looking for the circular crop option which is a newer feature. Am I missing something or is it gone for good?
Here's the demo I followed

6.0.4 - works as intended, on upload the crop is stretched to the maximum
8.6.6 - on upload the crop is not defined and you have to do it by hand.

Hi, that function signature has changed a bit it should be:
onImageLoaded = image => {
    this.setState({
      crop: makeAspectCrop(
        {
          x: 10,
          y: 0,
          aspect: 4 / 3,
          height: 100,
        },
        image.width,
        image.height
      ),
    })
    return false;
  }

To fit and center a percentage crop if that's what you're trying to do check out the code in onLoad here - https://github.com/DominicTobias/react-image-crop/blob/master/README.md#how-can-i-center-the-crop

Hi, that function signature has changed a bit it should be:
onImageLoaded = image => {
    this.setState({
      crop: makeAspectCrop(
        {
          x: 10,
          y: 0,
          aspect: 4 / 3,
          height: 100,
        },
        image.width,
        image.height
      ),
    })
    return false;
  }

To fit and center a percentage crop if that's what you're trying to do check out the code in onLoad here - https://github.com/DominicTobias/react-image-crop/blob/master/README.md#how-can-i-center-the-crop


[🐞] Optimizer introduced a SyntaxError in my code!

Which component is affected?
Qwik Optimizer (rust)
Describe the bug
Inside <script q:func="qwik/json">, it's generated this line by the optimizer:
(p0)=>((p0.withDescription??false&&"description"in p0.metadata)?p0.metadata.description:undefined),
and because of it, i'm getting javascript errors:

Uncaught SyntaxError: cannot use ?? unparenthesized within || and && expressions

I don't know what's going on!
I have a component that has this:
<PageHeader
  title={metadata.title}
  description={(withDescription && 'description' in metadata)
    ? metadata.description
    : undefined
}

withDescription is a boolean.
Reproduction
none  but can upload if needed
Steps to reproduce
No response
System Info
<EMAIL_ADDRESS>"^0.101.0",
<EMAIL_ADDRESS>"^0.101.0",

Additional Information
No response

I fixed it by changing my code to:
<PageHeader
  title={metadata.title}
  description={((withDescription) && 'description' in metadata)
    ? metadata.description
    : undefined
  }

But I think the optimizer should take care of this and don't introduce this kind of bugs. If it's going to use ??, then wrap condition in parethesis! @manucorporat

Also as a side note, optimizer also created this:
(p0)=>((p0.withDate??false)?p0.metadata.publishedAt:undefined),
but since i'm not using && or ||, everthing is fine. So clearly the optimizer needs to wrap in parenthesis when doing this ?? optmization, just in case the developer is also using &&or||`, so this don't cause a crash


Upstream ability to specify --platform when running Jest

Remaining work

[ ] add --platform flag to override haste.defaultPlatform

[ ] Update cli to forward --platform on the appropriate versions and tell people to migrate off rnx-test

[x] export loadConfig so it can be used for other purposes

[ ] Update jest-preset to use public loadConfig

The maintainer has essentially said no to this (https://github.com/facebook/jest/pull/11764#issuecomment-930155415). I'm not sure if there is anything else we can do for now so I'm closing this.


whether the training data can be released

Good work! I just wander whether the training dataset can be released? thanks!

Thank you for your interest in our research! Regrettably, we are not permitted to release it. :-( However, you can visit our dataset-generation section to discover how to generate training data using your own dataset. Thank you!


Using CSS in content_scripts

Summary
I can't use CSS files in content_scripts. If I import one in a .tsx file, it gets compiled and the contents go to the dist/style.css file. But trying to use it by adding it into manifest.json, I get Could not resolve entry module "style.css". error.
Reproduction
https://github.com/KamilBaczkowski/vpwe-repro
Environment
System:
    OS: Linux 6.1 NixOS 24.05 (Uakari) 24.05 (Uakari)
    CPU: (12) x64 AMD Ryzen 5 5600X 6-Core Processor
    Memory: 8.10 GB / 31.27 GB
    Container: Yes
    Shell: 3.6.1 - /run/current-system/sw/bin/fish
  Binaries:
    Node: 18.18.2 - ~/.nix-profile/bin/node
    npm: 9.8.1 - ~/.nix-profile/bin/npm
  npmPackages:
    vite: ^5.0.0 => 5.0.10
    vite-plugin-web-extension: ^4.0.0 => 4.0.1

I assume I'm doing something wrong, but I can't really tell what, and the docs are not helpful when it comes to this part of the extension development.

The plugin will automatically add the CSS to your content script, you don't have to list it manually.
So just remove the CSS from your manifest, run a build, and open dist/manifest.json. you'll see the CSS is listed there!
I thought this was documented, but I can't find it right now...

You are right, I didn't notice it, because I used a shadow DOM and couldn't get it to load there. I actually got it to work by adding it to web_accessible_resources and loading it manually within the shadow root. Now my question is wholly different: is there a way to stop the extension from adding style.css to the final manifest? I know there's the transformManifest way, but anything else?

Depends on the rest of your content script.
If the CSS file contains all your styles, you can:

Remove import in the entry point
Add it to the additionalInputs option (if it needs to be transformed by vite) or add it to the public directory (if it doesn't need to be transformed by vite)
Add the CSS file to web_accessible_resources
Use chrome.runtime.gstURL to get the CSS files final URL at runtime, and either fetch it or load it via a link element in your shadow root. (I recommend fetching it and loading the string into the body of a style element to avoid website's CSP)

If your using react or another framework that's generating additional styles, your only option is to remove it from the manifest with transformManifest.

All right, in such case I'll stick to transformManifest and document why I'm using it in that way. Thanks!


Add build instructions to the readme

hello, I added the changes you wanted.
can you please give me your idea of it?
also, I added the build and installation according to the tuv-x readme. md
hope you will like it
if there you want me to fix something I will be more than happy to do it.
thanks for the option to learn and work with you

closes #95


Add medium icon

Add medium icon using React icons SiMedium

you forgor fix:, feat:, or refac: prefixes on your commits lol
it's fine

@lifeng-yin while you're at it can you add it to the links page
like the icon i mean

Looks like this


Fixed #632 using relative path instead of absolute path for Image tag

It cannot see the some images that are using absolute path on the web page,
so I think it should use absolute path.

Tricky. This way works on the website (probably), but not when viewing on GitHub…

@spicyj Maybe react-native/img/EmbeddedAppExample.png works.

@spicyj it's not tricky. MD files in docs folder is using for http://facebook.github.io/react-native/docs/
another md files are using Relative path. ex) LinkingLibraries.md
![](/react-native/img/AddToLibraries.png)
![](/react-native/img/AddToBuildPhases.png)
![](/react-native/img/AddToSearchPaths.png)

Sure, okay. Maybe we can find something that works on both later.


Is WinUtil utterly broken?

Describe the bug
Title. It seems none of the toggles or options work.
To Reproduce
Steps to reproduce the behavior:
Use anything.
Expected behavior
Everything to work.
Screenshots
Setting the classic context menu. After doing so, 11's default still appears. Restarted as well, same result.
This affects the Snap options too, and Search, and Copilot toggle... and everything else. I don't need to list everything.

Additional context
N/A.

It seems after YET another reinstall of Windows, its working fine apparently. Not sure what the hell was going on. Windows being Windows:tm: I guess.


[WIP] Modified mesos-modules to build against a specific branch.

High level description including:

mesos-modules will be compiled against a specific branch of dcos/dcos-mesos-modules.
DC/OS-552
Commit message has the details.

Issues
DCOS-552
...
Checklist

[ ] Included a test which will fail if code is reverted but test is not
[ ] Followed relevant code rules Rules for Packages and Systemd

If this is a component/package update, include

[ ] Change Log from last:
[ ] Test Results:
[ ] Code Coverage:

Currently the mesos-modules package in DC/OS is built against the
dcos/dcos-mesos-modules master. The Mesos modules in the
dcos/dcos-mesos-modules repo has dependencies on Mesos headers and should
always be compiled against the Mesos source include in DC/OS
(mesosphere/mesos). Hence, we have introduced branches in the
dcos/dcos-mesos-modules to track the version of DC/OS. This would help
maintainability of the dcos/dcos-mesos-modules repo when we want to fix
issues in the Mesos modules against minor versions of DC/OS.
Since, we have branches in the dcos/dcos-mesos-modules repo we should be
compiling the mesos-modules package against a specific branch that conforms
to the DC/OS Mesos version.

This change is

@kaysoky @adam-mesos can you review?

Should this be updating ref as well as ref_origin? Only touching ref will ever cause a new build.
If this is ready for review can we remove the WIP in the PR title?
I don't see a lot of value to branching before the actual release. Practically, people accidentally delete the branches and the like, and ideally we won't need to add more PRs / commits to the 1.9 thing. Also deciding once the branch has been made which (or copying to all) branches every new commit / pr is work which people often forget or defer.

Was waiting for @adam-mesos or @kaysoky to give the go. In case @adam-mesos wanted to bump the Mesos version and hence update commits on the 1.9.x branch.
Currently, @cmaloney, the ref is the point from which we created the 1.9.x branch so it remains the same.
Had a discussion with all the stake holder in the dcos-mesos-modules repo and the concensus was that branching would simplify maintenance. Owners will be responsible for cherry-picking their commits to the right branch.
In terms of creating the branch now vs after the release that would be a bit odd right? If we don't branch of now DC/OS would release with the mesos-modules package pointing to the Master?

I think it makes sense for us to use master until we have a 1.9-rc1, at which point we can branch and decide whether new patches get cherry-picked into 1.9.x (for future rc's) or just into master (for future dcos releases).
You could go ahead and create a 1.8.x branch based on whatever we're using in 1.8.7 (and even a 1.7.x, etc). But I already know we'll be adding commits to dcos-mesos-modules before rc1, e.g. https://github.com/dcos/dcos/pull/977/files#diff-1a4c148ff2c418d6ff5e14ec904acacbL6

@adam bumped the sha on the 1.9.x branch to capture the commits needed to fix DCOS-557. These commits would allow the module to honor the operator's AgentNetworkConfig over the config that the Master is trying to apply.
Has been reviewed by @kaysoky and @jieyu
https://github.com/dcos/dcos-mesos-modules/pull/7
Couldn't add an integration test for this case, since its hard to run ssh commands on a box during integration test. Instead of integration tests have gone ahead and added unit-tests for this specific case.

Pretty sure that this can be closed. Please re-open if necessary.


visualize standard fbp patterns

Wirepattern might look like this:

Other ideas visualized:

vertical alignment of 'main' in and out

visual connection of main
async component = visual break in connection

wirepattern options collapse down when zoomed out

Somewhat related also to #51
And see earlier mockups related to this in noflo/noflo#166:

https://github.com/noflo/noflo/issues/166#issuecomment-43858397
https://github.com/noflo/noflo/issues/166#issuecomment-43859107


api: Add disableMergeSlash and escapedSlashesAction to ClientTrafficPolicy

What this PR does / why we need it:
This PR adds settings into ClientTrafficPolicy to control slashes in the incoming request path URI.
The following settings are added:
spec:
  path:
     escapedSlashesAction: UnescapeRedirect # or UnescapeForward, RejectRequest, KeepUnchanged
     disableMergeSlashes: false # set to true to prevent Envoy from merging slashes

The proposed defaults are the current EnvoyGateway behavior - so not setting these parameters will not cause any change to the current behavior.
These settings map to the EnvoyProxy HTTP Connection Manager configuration path_with_escaped_slashes_action and merge_slashes keys.
Which issue(s) this PR fixes:
These parameters were proposed in issue #1846 .

-1 on this setting, since its against the recommendations in https://www.envoyproxy.io/docs/envoy/latest/configuration/best_practices/edge#configuring-envoy-as-an-edge-proxy
what is the use case here @liorokman

-1 on this setting, since its against the recommendations in https://www.envoyproxy.io/docs/envoy/latest/configuration/best_practices/edge#configuring-envoy-as-an-edge-proxy what is the use case here @liorokman

The mergeSlashes setting recommended by the best practices is actually not part of the HTTP spec. See the comment on the setting's documentation. There are instances of frameworks that require that proxies in the middle don't merge adjacent slashes - e.g. Passenger.
With regards to the  escapedSlashesAction setting, the recommendations you cited actually recommend setting the value of this key based on your specific use-case:

Additionally the path_with_escaped_slashes_action setting should be set according to following recommendations:
REJECT_REQUEST if dowstream clients are expected to use RFC 3986 compliant normalized paths (i.e. gRPC clients).
UNESCAPE_AND_REDIRECT if downstream client supports HTTP redirect (i.e. a browser). This option minimizes possibility of path confusion by forcing request to be re-issued with the same path across all parties: downstream client, Envoy and upstream server. Note that gRPC requests will still be rejected with the INTERNAL (13) error code, as gRPC clients do not support redirect.
KEEP_UNCHANGED for servers that are not RFC 3986 compliant and require encoded slashes.
UNESCAPE_AND_FORWARD for servers that are known to treat escaped and unescaped slashes equivalently. Choosing this option may increase probablity of path confusion vulnerabilities if intermediaries perform path based access control.

In order to do so, it needs to be exposed in ClientTrafficPolicy.
In our use-case, we have some upstream servers that are not RFC 3986 compliant and we need to keep the encoded slashes as they are.
I think the current defaults are good, and I would definitely keep the current settings as defaults. But I think it does make sense to make these flags available for cases where the defaults don't work.

A few other OSS ingress controllers also allow controlling the mergeSlashes key:

Ambassador
Contour (see "disableMergeSlashes" )
Gloo (see "mergeSlashes")

thanks for added context @liorokman, some thoughts

since the above path field are set at within the hcm, we are limited to defining it in the ClientTrafficPolicy which might not be the ideal home, SecurityPolicy could have been another place to keep it, but can't how we can toggle this setting on/off at the route level
prefer if we have a top level field like path to hold all path specific setting

path:
  disableEergeSlashes:

prefer if escapedSlashesAction is represented as a boolinstead of enum e.g. allowEscapedSlashes

prefer if we have a top level field like path to hold all path specific setting

path:
  disableEergeSlashes:

These parameters are already grouped under a top level path field.

prefer if escapedSlashesAction is represented as a boolinstead of enum e.g. allowEscapedSlashes

Changing this to a bool would mean that EG supports only two of the possible actions. It would only be possible to either KEEP_UNCHANGED or UNESCAPE_AND_REDIRECT. The documentation would have to explicitly say that if allowEscapedSlashes is set to false, the behavior is UNESCAPE_AND_REDIRECT and not any of the other options.
I think there's also a hidden issue here that when the route is a gRPC route the better value for this configuration key would probably be REJECT_REQUEST, because gRPC clients are expected to be RFC 3986 compliant to begin with.

thanks for the detailed comments @liorokman
only have suggestions reg naming, else LGTM
reg default setting for escapedSlashesAction for gRPC, based on the doc string for UNESCAPE_AND_REDIRECT. - Note that gRPC requests will still be rejected with the INTERNAL (13) error code, as gRPC clients do not support redirect.
feels like the outcome is the same  as REJECT_REQUEST - error code 13 :)


Changing with stackTrace paramter without server restart

As the ExceptionHandler was static, it was impossible to change the configuration,  with stacktrace or not, wihtout restart of the server.

This looks great, merging now!


Added TPCH

@mtakahar Thank you!
Fixed all comments, currently running tests against latest release and checking results.


Webapp - Update for staking reward

Update WebApp for Staking Reward

[x] Update earning preview screen (Wait middleware service for validator list)
[x] Update Earning Trans Screen

[x] Auto enable network
[x] Auto select account
[x] Auto focus to amount
[x] Auto select validators

[x] Redirect promise (Redirect user after finish create account)

BA docs: https://www.notion.so/subwallet/Integration-with-Staking-rewards-2b63d60534fa4e4da4b17dd047ca84bd

[ ] Update new logic
BA docs : https://www.notion.so/subwallet/Integration-with-Staking-rewards-2b63d60534fa4e4da4b17dd047ca84bd

Please check issues:

[ ] UI bug in case Invalid account type

[ ] Show incorect account

Actual: Save and show the first account
Expect: Selected current account

Disuss more:

Earning method supported  -> Content
Automatic turn on network

Version test :

Demo page: https://h5tyq5.csb.app/

WebApp: https://webapp-demo.subwallet-webapp.pages.dev/

[ ] Update logic when using invalid accounts
Steps : In the case when the wallet does not have an account

Stand on popup Instrucsion earning
Click button Start to earn -> Navigate to Welcome screen to Create account/Import account/Attach account
Perform Import account/Attach account invalid
Click button Finish
Expect :

Option 1 : Navigate to Earning options screen , display popup Invalid account type
Option 2 : Navigate to Start earning screen , display popup Invalid account type

About issue "Automatic turn-on network when user click on "Stake" button on Start earning screen", keep the flow turn on from preview screen @ThaoNguyen998

Discuss more : In case there are many valid accounts and in All account mode

Version test :

Demo page: https://h5tyq5.csb.app/

WebApp: https://webapp-demo.subwallet-webapp.pages.dev/

[ ] Can not navigate to Start earning when Import multi-account

Version test :

Demo page: https://h5tyq5.csb.app/

WebApp: https://webapp-demo.subwallet-webapp.pages.dev/

[ ] Updated Max validator warning for WebApp

Version test :

Demo page: https://h5tyq5.csb.app/
WebApp: https://webapp-demo.subwallet-webapp.pages.dev/
Validation passed in case :

Update logic when using invalid accounts

Update logic for previously staked account

Nominated

Pooled

Improve on issue https://github.com/Koniverse/SubWallet-Extension/issues/2708


Can't update field inline

Describe the bug
When you tried to update any field in "inline mode", return the error "Unknown column '_antares_id' in 'where clause'
To Reproduce
Steps to reproduce the behavior:

Open any table
Select any field to update
Double click and change the value

Screenshots

The column with red underline is the one I want to modify.
Just one record is inserted with 'id' 1 and all columns are empty.
Application:

App version 0.5.5
Installation source: Microsoft Store

Environment:

OS name: Windows 10 Pro x64
OS version: 21H2 - 19044.1706
DB name  MySQL
DB version 5.7.33-log

Hi Agustín,
thanks for this precious bug report.
It happens when a table misses a primary key. I'll fix as fast as possible.

You're awesome bro. Thanks!


Will not collect similarly named workflows

In my scenario I am trying to collect info about workflows.  We run a lot of copies of the workflows in a short period of time and this seams to trip up the collector resulting in missing info about a lot of the workflows.
I see this in the debug logs (data anonymized):
level=debug ts=2023-07-13T17:05:50.187766828Z collector=workflow msg="Fetched workflows" count=70 duration=1.163039389s
...
level=debug ts=2023-07-13T17:05:50.187867274Z collector=workflow msg="Collecting workflow" owner=org/repo name="Product / OS1"
level=debug ts=2023-07-13T17:05:50.187876148Z collector=workflow msg="Collecting workflow" owner=org/repo name="Product / OS2"
level=debug ts=2023-07-13T17:05:50.187886639Z collector=workflow msg="Collecting workflow" owner=org/repo name="Product"
level=debug ts=2023-07-13T17:05:50.187897423Z collector=workflow msg="Collecting workflow" owner=org/repo name="Product / OS3"
level=debug ts=2023-07-13T17:05:50.187906483Z collector=workflow msg="Already collected workflow" owner=org/repo name="Product / OS2"
level=debug ts=2023-07-13T17:05:50.18791209Z collector=workflow msg="Already collected workflow" owner=org/repo name="Product / OS1"
level=debug ts=2023-07-13T17:05:50.187914841Z collector=workflow msg="Already collected workflow" owner=org/repo name="Product"
level=debug ts=2023-07-13T17:05:50.18796688Z collector=workflow msg="Already collected workflow" owner=org/repo name="Product / OS3"
...

What looks like is happening is that since it has already collected a workflow with a similar owner and name it skips the rest that are similar.
It looks like this loop may be the culprit?
https://github.com/promhippie/github_exporter/blob/dd9bb94738b5f4fbeea38dac64dfb169a752f7a0/pkg/exporter/workflow.go#L96-L107

This check have been added after people reported issues with prometheus errors like this metric have been already collected.

hmmm were experiencing similar behaviour I think...Ours appears to be missing occasional workflow runs. We have a workflow per repo, and these can be run multiple times a day one after each other. I wonder if its doing similar behaviour where it skips a run record because it has the exact same name, only the run number changes?
if thats the case, is there anyway we can make it compare run numbers so we get all the workflow runs?

With all the issues regarding workflow metrics I'm currently thinking about how to reimplement the whole feature.
Currently I'm tending to integrate a webhook listener which got to be configured on repos or orgs as a target, store the state with boltdb or optionally some other database and use the database content to generate the metrics offered by this exporter.
It would be great to gather some feedback by people using this feature at this larger scale as this would turn the exporter into some stateful service.

ran into the same issue. it seems to be using repo name + workflow name to dedup. it always reports the latest run and all previous runs of the same workflow are skipped.
@tboerger , what do you think about using something like repo name + workflow name + run_id + retry as the unique key?
about using GitHub webhooks, if I understand correctly, that would mean GitHub needs to call the exporter. So the exporter has to be exposed on the public Internet. To lots of companies, this may be a security risk. But letting the exporter pull GitHub is ok.

I won't continue the workflow exporter without the webhook integration. The current behavior led to so many issues that have been reported over all mostly related to paging size, timeouts and rate limits. If somebody really thinks that this is such a huge security risk maybe this is just the wrong exporter, sorry.

This current issue should be resolved with https://github.com/promhippie/github_exporter/pull/262 based on webhooks sent from Github.

Hopefully this issue is history with the new webhook-based implementation introduced with https://github.com/promhippie/github_exporter/pull/262, if the issue have not been resolved with the latest container image please feel free to report it at https://github.com/promhippie/github_exporter/issues/261 and we will get this fixed ASAP. Be aware that you need to integrate the webhook to receive workflow metrics in the future.


Added NGINX (auth/HTTPS) setup

Implements #12 and #11

Hey Ben, great work! I've merged this right away to give it a test drive. (Testing right now)
I still have one requests...
Could you add the additional whiptail dialog to inform the user of the details before starting the process? I've done that in almost all routines to avoid accidental clicks... see here

I've added a few small improvements to the printouts. Why did you decide to divide read and echo for the domain?
Another thing I just realized: One can not cancel while being in the prompts because I've trapped SIGINT. Would agree it would be a good idea to present all given information and ask for yet another confirmation before the setup process begins?

I encountered the first real problem: My domain is resolved though a CNAME entry pointing to a dyndns provider domain: openhab.mydomain.de -> abcd.no-ip.biz -> <IP_ADDRESS>
Now dig +short openhab.mydomain.de produces:
abcd.no-ip.biz.
<IP_ADDRESS>

which as a string is not equal to my wanip ("<IP_ADDRESS>"). Sadly dig +short openhab.mydomain.de A will not solve this problem as a CNAME is always part of the answer (if you know better, let me know). How do you think we can solve this?

We could extend the command to always use the last line of the output
We could extend the else part with a "I don't care, just use the given domain" option.

Could you add the additional whiptail dialog to inform the user of the details before starting the process? I've done that in almost all routines to avoid accidental clicks

Sure thing!

Why did you decide to divide read and echo for the domain?

Er.... Good question! I should have used a read prompt for this.

Would agree it would be a good idea to present all given information and ask for yet another confirmation before the setup process begins?

Yes this would be a safe bet, otherwise some weird default nginx configurations might occur. I'll move the install of nginx to after this prompt too?

CNAME entry pointing to a [..] domain

This is a normal way of doing this and for some reason didn't think of it! I don't think the "I don't care" option would be a good idea because if a domain can't eventually be resolved to the ip of the wan at the time of the setup, then this may cause problems with the proxy forwarding if the issue persists. Perhaps a better way of doing this is:
domainip=$(host $domain | awk '/has address/ { print $4 ; exit }')

Yes this would be a safe bet, otherwise some weird default nginx configurations might occur. I'll move the install of nginx to after this prompt too?

As you think. Sounds reasonable. ;)

I don't think the "I don't care" option would be a good idea because ...

I was thinking of the tech-savvy user, knowing what he's doing but maybe it's better to not tempt the normal end user to try and occupy a domain he doesn't own.
Why not dig +short $domain |tail -1? This should always return the A entry

I've just been reading on this at it looks like the last line will always be an ip address. My hesitancy was if the last line was an ipv6 address if it ever becomes a default (rather than depending on AAAA type). But thinking about it changing $(dig +short myip.opendns.com @resolver1.opendns.com |tail -1) will always output the same IP and type.

@ThomDietrich Would the input be better served through whiptail dialogue? That way we can keep to the same input type instead of suddenly shifting the user to reading the command line.

I've resorted to whiptail dialogs whenever possible to make things as "creamy" as possible for the end user but you already got your dialogs with read. So I would say it'ss totally up to you ;) As you know there is an example in the Karaf console function.