SPARQL Query Transformation to SQL for N-columns results in N-1 Self Joins or Left Joins, Extremely Slow Query Performance

Description
I have a Microsoft SQL Server table with 117 columns - 2 key columns.
As I add more columns, Ontop adds self-joins for each non-key column, resulting in 115 self joins if I include all columns.
With OPTIONAL variables, Ontop adds LEFT JOINS for each non-key column, resulting in 115 left joins if I include all columns.
A simple query on a database with 100,000 rows for all columns takes 5 minutes in Ontop. Using direct SQL, query takes 10 seconds.
Steps to Reproduce

Deploy mssql-vw-database.txt to Microsoft SQL Server.
 Most optimization techniques cannot be applied and the left joins and the distincts remain.
See for instance https://ontop-vkg.org/tutorial/mapping/primary-keys (with inner joins instead of left joins).
I suggest adding unique constraints to your DDL or, if it is not possible, using a basic lens to do so.

Thank you @bcogrel
To clarify, there's nothing I can do in the R2RML/ODBA mapping file, I either need to modify the underlying database to add unique constraints to the table, or provide a LENS defining the unique constraint.
For a lens, would this be the minimum information I would need to provide for a single table?
"relations": [
  {
    "name": "vw2_lense",
    "baseRelation": "\"dbo\".\"vw2\"",
    "uniqueConstraints": {
      "added": [
        {
          "name": "vw2_key",
          "determinants": [ "\"ID\"", "\"ID2\"" ]
        }
    ]
  }
]

Would there be any problem if the lens duplicated a uniqueConstraint that already exists in the database? (or was added later by a DBA)
I understand that a lens may also specify foreignKeys. Does Ontop perform any optimizations with these relationships? For example, if I queried:
SELECT v1.*, v2.*
FROM vw1 v1, vw2.v2
WHERE v1.ID = v2.ID

Would there be any advantage to creating a foreignKey in the lens for the relationship between vw1 and vw2? (presuming vw1 also has a lens with uniqueConstraints for vw1.ID)

You need to add the entry "type": "BasicLens" to your lens, otherwise it looks good.
In principle duplication of unique constraint should not cause any problem. If it does, just let us know, that would be a bug.
Yes, foreign keys are important as well for optimizing. They are used for removing unions in the mapping (after saturating it using the ontology), for reducing left joins into inner joins and eliminating inner joins. In your example, the inner join will indeed be eliminated thanks to the foreign key.

@bcogrel when I add unique constraints directly to the tables, Ontop removes the self/left joins.
However, I can't seem to get the Ontop Lens to work correctly (on tables with no keys)... it is still running the query with multiple self joins.
Ontop Lens
mssql-vw-lens.json
{
  "relations": [
    {
      "baseRelation": [
        "[dbo]",
        "[vw2]"
      ],
      "foreignKeys": {
        "added": [
          {
            "from": [
              "[ID]"
            ],
            "name": "vw1",
            "to": {
              "columns": [
                "[ID]"
              ],
              "relation": [
                "[dbo]",
                "[vw1]"
              ]
            }
          }
        ]
      },
      "name": [
        "lenses",
        "dbo",
        "vw2"
      ],
      "type": "BasicLens",
      "uniqueConstraints": {
        "added": [
          {
            "determinants": [
              "[ID]",
              "[ID2]"
            ],
            "name": "ID_ID2"
          }
        ]
      }
    },
    {
      "baseRelation": [
        "[dbo]",
        "[vw1]"
      ],
      "name": [
        "lenses",
        "dbo",
        "vw1"
      ],
      "type": "BasicLens",
      "uniqueConstraints": {
        "added": [
          {
            "determinants": [
              "[ID]"
            ],
            "name": "ID"
          }
        ]
      }
    }
  ]
}

Ontop Query Execution Log
mssql-vw-lens-query-log-4col.txt
SELECT  (?vw2_1_iD AS ?ID) (?vw2_1_iD2 AS ?ID2) (?vw2_1_col1 AS ?col1) (?vw2_1_col2 AS ?col2)
FROM <http://rdb/vw>
WHERE
  { ?_cls_vw2  a                    <http://rdb//vw2> ;
              <http://rdb//vw2#ID>  ?vw2_1_iD ;
              <http://rdb//vw2#ID2>  ?vw2_1_iD2
    OPTIONAL
      { ?_cls_vw2  <http://rdb//vw2#col1>  ?vw2_1_col1}
    OPTIONAL
      { ?_cls_vw2  <http://rdb//vw2#col2>  ?vw2_1_col2}
  }

SELECT DISTINCT v1."ID" AS "ID1m275", v1."ID2" AS "ID21m275", v2."col1" AS "col11m179", v3."col2" AS "col21m178"
FROM "vw2" v1
 LEFT OUTER JOIN
"vw2" v2 ON (v2."col1" IS NOT NULL AND v1."ID" = v2."ID" AND v1."ID2" = v2."ID2")
 LEFT OUTER JOIN
"vw2" v3 ON (v3."col2" IS NOT NULL AND v1."ID" = v3."ID" AND v1."ID2" = v3."ID2")

@thomasjtaylor, the mapping needs to be adapted to point to the lenses instead of the database tables.
Recording quoting, double-quotes should work fine with SQL Server. I haven't tested recently squared brackets, but I guess they work too. Anyway, Ontop should throw an exception if no table or column matches.

I had thought Ontop would use the Lens baseRelation to add the uniqueConstraints to the underlying table when planning the query.
I've updated the R2RML Mapping mssql-vw-mapping.ttl to replace: rr:tableName "\"dbo\""."\"vw1\"" with: rr:tableName "\"lenses\""."\"vw1\"", (the matches the relations/name value in the Lens) but the Ontop configuration fails to load with the below Exception.
It seems I'm missing something in the documentation, examples, and tutorials to get this working.
 it.unibz.inf.ontop.exception.InvalidMappingSourceQueriesException: Error: Cannot find relation "mssql_vw"."lenses"."vw2" (available choices: ["mssql_vw"."dbo"."vw1", "mssql_vw"."dbo"."vw2"]) (from "lenses"."vw2")
Problem location: source query of triplesMap
[id: mapping-1570583125
target atoms: triple(s, p, o) with s/RDF(urn://rdb/vw2/ID={};ID2={}(TmpToNVARCHAR("ID"),TmpToNVARCHAR("ID2")),IRI), p/<http://www.w3.org/1999/02/22-rdf-syntax-ns#type>, o/<urn://rdb/vw2>, quad(s, p, o, g) with s/RDF(urn://rdb/vw2/ID={};ID2={}(TmpToNVARCHAR("ID"),TmpToNVARCHAR("ID2")),IRI), p/<http://www.w3.org/1999/02/22-rdf-syntax-ns#type>, o/<urn://rdb/vw2>, g/<http://rdb/vw>,
...
source query: SELECT * FROM "lenses"."vw2"]
	at it.unibz.inf.ontop.spec.mapping.pp.impl.SQLPPMappingConverterImpl.getRAExpression(SQLPPMappingConverterImpl.java:162) ~[ontop-mapping-sql-core-5.2.0-SNAPSHOT.jar:5.2.0-SNAPSHOT]
	at it.unibz.inf.ontop.spec.mapping.pp.impl.SQLPPMappingConverterImpl.convert(SQLPPMappingConverterImpl.java:64) ~[ontop-mapping-sql-core-5.2.0-SNAPSHOT.jar:5.2.0-SNAPSHOT]
	at it.unibz.inf.ontop.spec.mapping.impl.SQLMappingExtractor.convert(SQLMappingExtractor.java:248) ~[ontop-mapping-sql-core-5.2.0-SNAPSHOT.jar:5.2.0-SNAPSHOT]
	at it.unibz.inf.ontop.spec.mapping.impl.SQLMappingExtractor.convert(SQLMappingExtractor.java:219) ~[ontop-mapping-sql-core-5.2.0-SNAPSHOT.jar:5.2.0-SNAPSHOT]
	at it.unibz.inf.ontop.spec.mapping.impl.SQLMappingExtractor.convert(SQLMappingExtractor.java:188) ~[ontop-mapping-sql-core-5.2.0-SNAPSHOT.jar:5.2.0-SNAPSHOT]
	at it.unibz.inf.ontop.spec.mapping.impl.SQLMappingExtractor.convertPPMapping(SQLMappingExtractor.java:153) ~[ontop-mapping-sql-core-5.2.0-SNAPSHOT.jar:5.2.0-SNAPSHOT]
	at it.unibz.inf.ontop.spec.mapping.impl.SQLMappingExtractor.extract(SQLMappingExtractor.java:108) ~[ontop-mapping-sql-core-5.2.0-SNAPSHOT.jar:5.2.0-SNAPSHOT]
	at it.unibz.inf.ontop.spec.impl.DefaultOBDASpecificationExtractor.extract(DefaultOBDASpecificationExtractor.java:51) ~[ontop-mapping-core-5.2.0-SNAPSHOT.jar:5.2.0-SNAPSHOT]
	at it.unibz.inf.ontop.injection.impl.OntopMappingConfigurationImpl.loadSpecification(OntopMappingConfigurationImpl.java:140) ~[ontop-mapping-core-5.2.0-SNAPSHOT.jar:5.2.0-SNAPSHOT]
	at it.unibz.inf.ontop.injection.impl.OntopMappingSQLConfigurationImpl.loadSpecification(OntopMappingSQLConfigurationImpl.java:93) ~[ontop-mapping-sql-core-5.2.0-SNAPSHOT.jar:5.2.0-SNAPSHOT]
	at it.unibz.inf.ontop.injection.impl.OntopMappingSQLAllConfigurationImpl.loadSpecification(OntopMappingSQLAllConfigurationImpl.java:55) ~[ontop-mapping-sql-all-5.2.0-SNAPSHOT.jar:5.2.0-SNAPSHOT]
	at it.unibz.inf.ontop.injection.impl.OntopSQLOWLAPIConfigurationImpl.loadOBDASpecification(OntopSQLOWLAPIConfigurationImpl.java:42) ~[ontop-system-sql-owlapi-5.2.0-SNAPSHOT.jar:5.2.0-SNAPSHOT]
	at it.unibz.inf.ontop.injection.impl.OntopOBDAConfigurationImpl.loadSpecification(OntopOBDAConfigurationImpl.java:44) ~[ontop-obda-core-5.2.0-SNAPSHOT.jar:5.2.0-SNAPSHOT]
	at it.unibz.inf.ontop.injection.OntopSystemConfiguration.loadQueryEngine(OntopSystemConfiguration.java:20) ~[ontop-system-core-5.2.0-SNAPSHOT.jar:5.2.0-SNAPSHOT]
	at it.unibz.inf.ontop.rdf4j.repository.impl.OntopVirtualRepository.initializeInternal(OntopVirtualRepository.java:72) ~[ontop-rdf4j-5.2.0-SNAPSHOT.jar:5.2.0-SNAPSHOT]

@bcogrel for the Lens foreignKeys, does the to also need to refer to the Lens relation if it is defined?
I currently have:
"to": {
  "columns": [
    "\"ID\""
  ],
  "relation": [
-    "\"dbo\"",
    "\"vw1\""
  ]

but I'm thinking I also need to change it to:
"to": {
  "columns": [
    "\"ID\""
  ],
  "relation": [
+   "\"lenses\"",
    "\"vw1\""
  ]

I haven't yet tested the query optimization across object properties.

@thomasjtaylor, yes it is probably better to have it pointing to the lens as a general practice.
Ontop has a mechanism for inheriting foreign keys defined over the base relations to the lenses, which may be active in your case. So changing the target of the foreign key may not make any difference here, but this needs to be tested.

Thanks @bcogrel my question/issue has been resolved. I will do some tests with the foreign keys and if I find anything, I'll open a new issue for it.


Documentation: Write app desc for play store

Description
Documentation: Write app desc for play store
👀 Have you spent some time to check if this issue has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I agree to follow this project's Code of Conduct

I would like to work on this issue under JWOC ✌

I want to work on this issue under JWOC

@aritra-tech Sorry for that , we know first cum first serve but , binay say the issue for so , I assigned him ..

@aritra-tech Sorry for that , we know first cum first serve but , binay say the issue for so , I assigned him ..

Yah yah ok NP


Upgrade WCS to v6.2

Wow, this is totally broken! :persevere:

@kbarbary How do you decide whether a field should be considered private or not?  Are there other changes needed for this to be merged?


How to set NODE_ENV to development ?

I'm building a chrome extension in which I use some packages that have custom dev tools (react-query to be named).
The devtools, as stated in the documentation, is bundled only when NODE_ENV is set to development.
When I pnpm run dev, I don't have the var properly set.
To check what is the value of this node env variable, I added a console.log("env", process.env); directly inside vite.config.ts file.
I can see when starting the dev script: NODE_ENV: 'production'.
How to ensure this env variable is properly set ?
I tried to fix all the package.json to force the value, without success:
  "scripts": {
    "build": "tsc --noEmit && vite build",
    "build:watch": "cross-env __DEV__=true NODE_ENV=development vite build --watch",
    "build:hmr": "cross-env NODE_ENV=development rollup --config utils/reload/rollup.config.ts --configPlugin typescript",
    "wss": "cross-env NODE_ENV=development node utils/reload/initReloadServer.js",
    "dev": "cross-env NODE_ENV=development pnpm run build:hmr && (run-p wss build:watch)",
    "test": "jest"
  },

Thanks

process.env.NODE_ENV = "development"; in vite.config.ts is not working?

Seems to work !
Thanks !


Relative url paths in node_modules css

Preface: I'm not entirely sure if this is an issue that should be handled by rollup-plugin-sass but I didn't know where else to ask this.
Some npm libraries use relative image url paths in their css (eg. leaflet). I cannot figure out how to get this plugin to respect those relative paths. My js and css live in
src/MyProject/

MyProject.js
MyProject.css

and I have rollup's destination set to
dist/MyProject/

MyProjectOutput.js
MyProjectOutput.css

However, the relative paths in the output css are unchanged. So if /node_modules/leaflet/dist/leaflet.css is included in MyProjectOutput.css and it has a path like "url(images/marker-icon.png)" my browser will look for an image at "/dist/images/marker-icon.png" and 404. Any suggestions as to how I might fix that?

I cloud advise you using postcss to twist the url of images.
import { rollup } from 'rollup';
import postcss from 'rollup-plugin-postcss';

rollup({
  entry: 'main.js',
  plugins: [
    sass(),
    postcss({
      plugins: [
        twistImagesUrl()
      ]
    })
  ]
}).then(...)

Checkout the doc.This is really easy to get your own plugin.

Ok so this is not something that rollup-plugin-sass is designed to handle? Feel free to close this issue if you don't believe it to be relevant.

Ok. So I was able to write a little plugin that converts my urls which ended up being pretty straightforward. Thanks for the suggestion! It works fine as a standalone postcss-plugin but it does not work with the sass processor. The idea is that you pass in the destination file to which rollup will output the css and my plugin will replace any relative url paths of the css input file with a relative path based on the destination file.
My plugin:
var postcss = require('postcss');
var path = require("path");

// Credit: http://stackoverflow.com/a/6582214
var extensionPattern=/\.[0-9a-z]{1,5}$/i;

module.exports = postcss.plugin('myplugin', function (destinationPath) {

	return function (css) {

		if (typeof destinationPath === 'undefined') {
			console.log("You MUST provide a destination path. Skipping " + css.source.input.file);
			return;
		}

		css.walkRules(function (rule) {
			rule.walkDecls(function (decl, i) {
				var value = decl.value;
				if (value.indexOf( 'url(' ) !== -1) {
					// Get the url requested by matching the string inside the brackets of url().
					// Then replace any double or single quotes therein.
					var urlPath = value.match(/\(([^)]+)\)/)[1].replace(/["']/g, "");

					// Check against the regex for file extensions
					var urlExtension = urlPath.match(extensionPattern);

					// No extension implies that the the url is a dataURI.
					// Starting with '/' means that the url is absolute.
					if (!urlExtension || urlPath.toString().startsWith('/')) {
						return;
					}
					// Strip the file name from the input file path
					var inputFilePath = css.source.input.file.replace(/[^\/]*$/, '');
					// Send the new value back into the stylesheet
					decl.value = 'url("' + path.relative(destinationPath, inputFilePath) + '/' + urlPath + '")';
				}
			});
		});
	}
});

My relevant rollup config:
      sass({
        // Make sure to grab any css needed node_modules
        include: [ 'node_modules/**/*.css', '/my/project/path/**/*.scss'],
        processor(code, id) {
          return postcss([myplugin(id)])
            .process(code)
            .then((result) => {
              return result.css;
            });
        },
        output(styles, styleNodes) {
           ....
        }
      }),

The problem seems to be that css.source.input.file is undefined. Instead css.source.input.id exists but for my use case that's not helpful. Is there any way I can pass my plugin the actual file path of the input css?

@jbccollins Try tihs:
sass({
  // Make sure to grab any css needed node_modules
  include: [ 'node_modules/**/*.css', '/my/project/path/**/*.scss'],
  processor(code, id) {
    return postcss([myplugin()], { from: id })
      .process(code)
      .then((result) => {
        return result.css;
      });
  },
  output(styles, styleNodes) {
     ....
  }
})

Ahhhh! Yes. Thanks I got it. It ended up being
sass({
  // Make sure to grab any css needed node_modules
  include: [ 'node_modules/**/*.css', '/my/project/path/**/*.scss'],
  processor(code, id) {
    return postcss([myplugin()])
      .process(code, { from: id })
      .then((result) => {
        return result.css;
      });
  },
  output(styles, styleNodes) {
     ....
  }
})

Thanks for being so quick to respond to my questions! Feel free to close this issue.

Hey sorry I know this thread is dead now but if anyone stumbles across this question in the future I wrote a small plugin to deal with it. https://www.npmjs.com/package/postcss-twist-url-assets


TinyMce style select not showing after upgrade

Laravel version
Laravel Framework 9.52.15
PHP version
PHP 8.1
Voyager version
v1.6.0
Database
MYSQL 8
Description
After upgrading Laravel and Voyager, Styleselect is disabled on tinyMce.
Steps to reproduce

When we edit any post from backend, from editor which is TInyMce we don't see style select dropdown anymore.

Expected behavior

Dropdown should be there for choosing style of the text.

Screenshots
Before:

After:

Additional context
No response

https://github.com/thedevdojo/voyager/issues/5711


Expose the CPU cgroup realtime options to the run CLI

Hi all,
I have an application that calls the sched_setscheduler system call [1]. This requires that I set the followings (assuming a CentOS 7 for example):
$ C=$(docker run ...)
$ echo 950000 > /sys/fs/cgroup/cpu/system.slice/cpu.rt_runtime_us
$ echo 950000 > /sys/fs/cgroup/cpu/system.slice/docker-$C.scope/cpu.rt_runtime_us
Unlike cpu.shares, this cannot be done directly via the docker CLI (as of 1.6.2) which is a bit of an issue because my process fails when it calls sched_setscheduler as I didn't get a chance to set the appropriate system values. We can't rely on the fact the parent cgroup has the appropriate value since the kernel clearly states that children cgroups will always get initialized to 0 anyhow [2]

By default all bandwidth is assigned to the root group and new groups get the period from /proc/sys/kernel/sched_rt_period_us and a run time of 0.

Browsing the code, I can see some other options have been added [3] but not the ones regarding real-time scheduling.
However, looking at the libcontainer's code, I can see the underlying code is already there [4]. So, what's lacking is to expose them from the docker interface.
Is there a chance this could be added to the CLI as well? This would make using docker and real-time scheduling much friendlier.
Thanks,
[1] http://man7.org/linux/man-pages/man2/sched_setscheduler.2.html
[2] http://lxr.free-electrons.com/source/Documentation/scheduler/sched-rt-group.txt?v=3.10
[3] https://github.com/docker/docker/blob/master/runconfig/parse.go#L70
[4] https://github.com/docker/docker/blob/04c6f09fbdf60c7765cc4cb78883faaa9d971fa5/vendor/src/github.com/docker/libcontainer/cgroups/fs/cpu.go#L54

Hi!
Please read this important information about creating issues.
If you are reporting a new issue, make sure that we do not have any duplicates already open. You can ensure this by searching the issue list for this repository. If there is a duplicate, please close your issue and add a comment to the existing issue instead.
If you suspect your issue is a bug, please edit your issue description to include the BUG REPORT INFORMATION shown below. If you fail to provide this information within 7 days, we cannot debug your issue and will close it. We will, however, reopen it if you later provide the information.
This is an automated, informational response.
Thank you.
For more information about reporting issues, see https://github.com/docker/docker/blob/master/CONTRIBUTING.md#reporting-other-issues

BUG REPORT INFORMATION
Use the commands below to provide key information from your environment:
docker version:
docker info:
uname -a:
Provide additional environment details (AWS, VirtualBox, physical, etc.):
List the steps to reproduce the issue:
1.
2.
3.
Describe the results you received:
Describe the results you expected:
Provide additional info you think is important:
----------END REPORT ---------
#ENEEDMOREINFO

dup of #10459 which was closed.
You can use --cgroup-parent and set these.

Hello @cpuguy83,
I don't think that fixes it. Like I said, when you create a cgroup, the kernel will always set the cpu.rt_runtime_us to 0. See [1].

By default all bandwidth is assigned to the root group and new groups get the period from /proc/sys/kernel/sched_rt_period_us and a run time of 0.

And in fact, I have tried using --cgroup-parent as you suggest and cpu.rt_runtime_us was being set to 0 anyhow.
For instance, on a CentOS 7
$ echo 950000 > /sys/fs/cgroup/cpu/system.slice/cpu.rt_runtime_us
$ docker run --rm --cap-add=SYS_NICE --cgroup-parent=system.slice -it ubuntu bash
# python3
>>> import os
>>> os.sched_setscheduler(os.getpid(), os.SCHED_FIFO, os.sched_param(2))"
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
PermissionError: [Errno 1] Operation not permitted

Indeed since:
$ cat /sys/fs/cgroup/cpu/system.slice/system.slice-<DOCKER_ID>.scope/cpu.rt_runtime_us
0

Now let's change that value to give some realtime share to that container:
$ echo 950000 > /sys/fs/cgroup/cpu/system.slice/system.slice-<DOCKER_ID>.scope/cpu.rt_runtime_us

And sure enough
# python3
>>> import os
>>> os.sched_setscheduler(os.getpid(), os.SCHED_FIFO, os.sched_param(2))"

Maybe, I'm missing something though.
[1] http://lxr.free-electrons.com/source/Documentation/scheduler/sched-rt-group.txt?v=3.10

Is it possible that could be evaluated again @cpuguy83?
Thanks.

After testing, you cannot use cgroup parent for this currently since the container is getting a default value of 0 in it's cgroup regardless of what the parent has set.

Where does this currently stand?

I'm curious about the motivation behind the call to sched_setscheduler. Unless I'm misunderstanding the docs [1], the kernel uses RT scheduling (95% RT / 5% not RT), even if CONFIG_RT_GROUP_SCHED is not enabled, which means that within the root group, the 95% assigned to it is scheduled using CFS, which has the ability to set quotas and periods. Thus, [cpu-quota/cpu-period [2] might be enough for the purposes of OP. Or is it more of an issue of not being able to conditionally call sched_setscheduler within the app?

Maybe I'm misreading it but, it wouldn't be enough to set the bandwidth. Indeed, you would still need to  allocated RT shares to the group:

By default all bandwidth is assigned to the root group and new groups get the
period from /proc/sys/kernel/sched_rt_period_us and a run time of 0. If you
want to assign bandwidth to another group, reduce the root group's bandwidth
and assign some or all of the difference to another group.

As you say, cpu-quote/cpu-period are useful but you still need to allocate RT period to the group anyway.

I was wrong in assuming that the RT allocation on the root group would propagate to any children (as with other cgroups options). So you're right, it has to be reduced from the root and assigned to others, if they need to use the RT scheduler.
However, I think that cpu-quota/cpu-period serve the same purpose without having to use the RT scheduler (or change cpu.rt_runtime_us). After reading the red hat docs on this [1] and experimenting myself, I think this is the case. From the docs:

The RT scheduler works similar to the ceiling enforcement control of the CFS (for more information, refer to Section 3.2.1, “CFS Tunable Parameters”) but limits CPU access to real-time tasks only

The main difference is that in order for a task to get affected by cpu.rt_* options, it has to explicitly use the RT scheduler (as you show via your python example).

Any update on this one? I'm running a Docker container on a network-switch. To interact with the ASIC I use OpenNSL which wants to change interrupt priorities. To get it working I currently manually change the cgroup settings, similar as described above:
$ echo 950000 > ./cgroup/cpu/docker/cpu.rt_runtime_us
$ echo 950000 > ./cgroup/cpu/docker/CONTAINER-ID/cpu.rt_runtime_us

Obviously it would be nice to get this done via the docker cli.

@neuhausler I don't think someone is working on this, but we always welcome PRs :innocent: :heart:

@thaJeztah  I’m working on this

Thanks @coolljt0725!

@coolljt0725 any thoughts about timeframe, when that function will be implemented and available in docker?

Hi, can you look at this PR and see if it supports your use case? https://github.com/docker/docker/pull/23430

Tentatively closing as the issue seems to be resolved: please let me know if it needs reopening! Thanks.


Connected friends to position retrieval. Updates to API Endpoints: friendInviteResponse. Added more friending code.

👍


Added nimCat to DSL and progressBar to MCMC

@perrydv @paciorek Two changes in this PR:

Addition of nimCat to the DSL. Identical to nimPrint, except doesn't add a "newline" at the end.
Addition of progressBar option to MCMC, as a runtime argument (default TRUE).

To see how the progress bar looks, build off this branch and run the following examples:
library(nimble)
Rmodel <- readBUGSmodel('birats2.bug', dir = getBUGSexampleDir('birats'), data = 'birats-data.R', inits = 'birats-inits.R')
Rmcmc <- buildMCMC(Rmodel)
Cmodel <- compileNimble(Rmodel)
Cmcmc <- compileNimble(Rmcmc, project = Rmodel)
Cmcmc$run(20000)
Cmcmc$run(30007, reset = FALSE)         ## continue previous run
Cmcmc$run(10000, progressBar = FALSE)   ## turn off progress bar
Cmcmc$run(100003, reset = FALSE)        ## sort of slow run
Cmcmc$run(5000)     ## faster
Cmcmc$run(2000)     ## faster still
Cmcmc$run(1000)     ## ...
Cmcmc$run(500)
Cmcmc$run(100)
Cmcmc$run(40)  ## no progress bar when too few iterations

I'm slightly wary of defining nimCat simply as nimPrint without newlines
given how cat operates in R is a bit different than print. But I guess it's
an ongoing question of how much the DSL should mimic R.
What do you think about adding an arg to nimPrint, with default, as
"newline = TRUE" instead?
On Sun, Jul 10, 2016 at 4:47 PM, Daniel Turek<EMAIL_ADDRESS>wrote:

@perrydv https://github.com/perrydv @paciorek
https://github.com/paciorek Two changes in this PR:

Addition of nimCat to the DSL. Identical to nimPrint, except
doesn't add a "newline" at the end.
Addition of progressBar option to MCMC, as a runtime argument
(default TRUE).

To see how the progress bar looks, build off this branch and run the
following examples:
library(nimble)
Rmodel <- readBUGSmodel('birats2.bug', dir = getBUGSexampleDir('birats'),
data = 'birats-data.R', inits = 'birats-inits.R')
Rmcmc <- buildMCMC(Rmodel)
Cmodel <- compileNimble(Rmodel)
Cmcmc <- compileNimble(Rmcmc, project = Rmodel)
Cmcmc$run(20000)
Cmcmc$run(30007, reset = FALSE) ## continue previous run
Cmcmc$run(10000, progressBar = FALSE) ## turn off progress bar
Cmcmc$run(100003, reset = FALSE) ## sort of slow run
Cmcmc$run(5000) ## faster
Cmcmc$run(2000) ## faster still
Cmcmc$run(1000) ## ...
Cmcmc$run(500)
Cmcmc$run(100)
Cmcmc$run(40) ## no progress bar when too few iterations
You can view, comment on, or merge this pull request online at:
https://github.com/nimble-dev/nimble/pull/184
Commit Summary

added nimCat to DSL
added progressBar to MCMC

File Changes

M packages/nimble/NEWS
https://github.com/nimble-dev/nimble/pull/184/files#diff-0 (2)
M packages/nimble/R/MCMC_build.R
https://github.com/nimble-dev/nimble/pull/184/files#diff-1 (25)
M packages/nimble/R/RCfunction_core.R
https://github.com/nimble-dev/nimble/pull/184/files#diff-2 (1)
M packages/nimble/R/genCpp_generateCpp.R
https://github.com/nimble-dev/nimble/pull/184/files#diff-3 (6)
M packages/nimble/R/genCpp_sizeProcessing.R
https://github.com/nimble-dev/nimble/pull/184/files#diff-4 (3)
M packages/nimble/R/nimbleFunction_Rexecution.R
https://github.com/nimble-dev/nimble/pull/184/files#diff-5 (22)

Patch Links:

https://github.com/nimble-dev/nimble/pull/184.patch
https://github.com/nimble-dev/nimble/pull/184.diff

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/nimble-dev/nimble/pull/184, or mute the thread
https://github.com/notifications/unsubscribe/ACYr3huaMEx3HVA4VJ_maV7-HmEhIehVks5qUYR9gaJpZM4JI8h1
.

I'm certainly open to that way of going.  Perry, thoughts?

I think adding nimCat (as the replacement for the DSL synonym “cat”, I presume) makes sense.  The reason nimPrint (or print) is inconsistent with R behavior is that we haven’t had any string processing in compiled-generated C++, so we don’t have paste() in the DSL.  As a result it made sense to simply allow comma-separated arbitrary arguments to print() that are automatically pasted together.  Unfortunately that is not consistent with R’s print() but it is consistent with R’s cat().  So really the NIMBLE DSL print should arguably have been named cat in the first place.  When we add meaningful string processing, including paste, it would make sense to change print() to behave like R’s print().  To that end it would make sense to name what we have more consistently with R, which would be cat.

On Jul 11, 2016, at 12:49 AM, Daniel Turek<EMAIL_ADDRESS>wrote:
I'm certainly open to that way of going. Perry, thoughts?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/nimble-dev/nimble/pull/184#issuecomment-231664287, or mute the thread https://github.com/notifications/unsubscribe/AHpCMR5XJZPA8PyueyzKRPRngXkxuA5Cks5qUfVsgaJpZM4JI8h1.

So I've missed the consensus here.... For background to Perry, I created a
pull request, which adds a new DSL keyword: cat() / nimCat(), which
functions identical to our current print() / nimPrint() except without
outputing a newline "\n" at the end.
So which way are we leaning here?

Change our current print() to be named cat() ?
Change our current print() to be named cat(), and add a newline=FALSE
argument ?  (breaks old code).
Add a newline=TRUE argument to our current print() ?  (old code works,
and we have new functionality).
Have both print() and cat()  (as my pull request does).

Thanks.  I just wasn't sure the conclusion of Perry's comments.
Daniel
On Mon, Jul 11, 2016 at 6:14 AM, perrydv<EMAIL_ADDRESS>wrote:

I think adding nimCat (as the replacement for the DSL synonym “cat”, I
presume) makes sense. The reason nimPrint (or print) is inconsistent with R
behavior is that we haven’t had any string processing in compiled-generated
C++, so we don’t have paste() in the DSL. As a result it made sense to
simply allow comma-separated arbitrary arguments to print() that are
automatically pasted together. Unfortunately that is not consistent with
R’s print() but it is consistent with R’s cat(). So really the NIMBLE DSL
print should arguably have been named cat in the first place. When we add
meaningful string processing, including paste, it would make sense to
change print() to behave like R’s print(). To that end it would make sense
to name what we have more consistently with R, which would be cat.

On Jul 11, 2016, at 12:49 AM, Daniel Turek<EMAIL_ADDRESS>wrote:
I'm certainly open to that way of going. Perry, thoughts?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <
https://github.com/nimble-dev/nimble/pull/184#issuecomment-231664287>, or
mute the thread <
https://github.com/notifications/unsubscribe/AHpCMR5XJZPA8PyueyzKRPRngXkxuA5Cks5qUfVsgaJpZM4JI8h1
.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/nimble-dev/nimble/pull/184#issuecomment-231695426,
or mute the thread
https://github.com/notifications/unsubscribe/AETW4UbPyxJAIUrlI0_8raEeJp6Op_TGks5qUheIgaJpZM4JI8h1
.

I think consensus is to go with Daniel's PR for now and change nimPrint in
the future to be more like R.
On Mon, Jul 11, 2016 at 6:20 AM, Daniel Turek<EMAIL_ADDRESS>wrote:

So I've missed the consensus here.... For background to Perry, I created a
pull request, which adds a new DSL keyword: cat() / nimCat(), which
functions identical to our current print() / nimPrint() except without
outputing a newline "\n" at the end.
So which way are we leaning here?

Change our current print() to be named cat() ?
Change our current print() to be named cat(), and add a newline=FALSE
argument ? (breaks old code).
Add a newline=TRUE argument to our current print() ? (old code works,
and we have new functionality).
Have both print() and cat() (as my pull request does).

Thanks. I just wasn't sure the conclusion of Perry's comments.
Daniel
On Mon, Jul 11, 2016 at 6:14 AM, perrydv<EMAIL_ADDRESS>wrote:

I think adding nimCat (as the replacement for the DSL synonym “cat”, I
presume) makes sense. The reason nimPrint (or print) is inconsistent
with R
behavior is that we haven’t had any string processing in
compiled-generated
C++, so we don’t have paste() in the DSL. As a result it made sense to
simply allow comma-separated arbitrary arguments to print() that are
automatically pasted together. Unfortunately that is not consistent with
R’s print() but it is consistent with R’s cat(). So really the NIMBLE DSL
print should arguably have been named cat in the first place. When we add
meaningful string processing, including paste, it would make sense to
change print() to behave like R’s print(). To that end it would make
sense
to name what we have more consistently with R, which would be cat.

On Jul 11, 2016, at 12:49 AM, Daniel Turek<EMAIL_ADDRESS>wrote:
I'm certainly open to that way of going. Perry, thoughts?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <
https://github.com/nimble-dev/nimble/pull/184#issuecomment-231664287>,
or
mute the thread <

https://github.com/notifications/unsubscribe/AHpCMR5XJZPA8PyueyzKRPRngXkxuA5Cks5qUfVsgaJpZM4JI8h1

.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/nimble-dev/nimble/pull/184#issuecomment-231695426,
or mute the thread
<
https://github.com/notifications/unsubscribe/AETW4UbPyxJAIUrlI0_8raEeJp6Op_TGks5qUheIgaJpZM4JI8h1

.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/nimble-dev/nimble/pull/184#issuecomment-231731799,
or mute the thread
https://github.com/notifications/unsubscribe/ACYr3lH7nqIw7wHcbNaQ4EGgZEOzxlQjks5qUkMigaJpZM4JI8h1
.

If that's the case, then I'll leave it to @perrydv to look over the changes I made in the DSL / compiler, and merge this pull request.  Until I hear otherwise, I'm assuming this is out of my court.  Hopeful for this to go in the 0.6 release, though.
If this PR is merged, I still need to make updates to the User Manual, FYI.
I'll also encourage both of you to try out the example code I sent (first message in this conversation) to see if you like the "look & feel" of the progress bar.  Many different ways to go about it.

I looked at this and ran the example on OS X and Windows.  I like it and think we should merge it.  On my machine the cases with niter<=2000 were essentially instantaneous (the entire bar fills in at once), so perhaps the threshold for not showing a bar could be raised, but it may not hurt to have it lower rather than higher.   I sent an email note about the roxygen entry.  Since GitHub says this branch has conflicts to resolve, I am going to throw it back to @danielturek to merge.

@danielturek can I ask a favor while you are merging this PR?  The first line in each of cppOutputCout and cppOutputCoutNoNewline (which has "std::cout" in it) can be removed.  These have no impact whatsoever since the next line provides the return value of each function.  We made the switch a while ago to using a std::ostringstream object for output from C++, called _nimble_global_output.  Apparently the paste() creating the old return value from cppOutputCout was left there accidentally, with no effect.  Thanks.

@perrydv The threshold for not showing the progress bar is when the number of MCMC iterations is less than the number of '-' characters in the progress bar, in which case the logic for determining when to display the next '-' fails.  I'm leaving this as-is, since for some MCMCs (large model, lots of samplers) even a small number of MCMC iterations (e.g., 500) can take appreciable time, hence a progress bar is useful.
I touched up the roxygen documentation, per your other email.  Note, though, you might want to revise the documentation for print() / nimPrint(), since I had basically copied it from there.
I fixed the merge conflict.
I removed the old paste() lines (no longer used) from genCppCout and genCppCoutNoNewline, as you described.  I was a little perplexed by those, but what you said makes sense.
Merging this in.


Error on opening unsupported file

Add notice that opening a particular file type is not supported instead of opening nothing with no dialog.

Hey! Sorry I never replied to these, I'm awful with github notifications.
Although I like this suggestion in principle, I won't do it because on this project the main principle is minimalism. Having any kind of dialog means loading a font and a UI library.
Although.. it just occurred to me I can write the message to the window title! Yeah, I think I'll do that..


fix: persist runUnattendedUpgradesOnBootstrap even if not set by input API model

Reason for Change:
runUnattendedUpgradesOnBootstrap is persisted in the output API Model only if a value is set explicitly.
This PR ensures that runUnattendedUpgradesOnBootstrap is always persisted.
The default behavior is not altered.
Issue Fixed:

Credit Where Due:
Does this change contain code from or inspired by another project?

[ ] No
[ ] Yes

If "Yes," did you notify that project's maintainers and provide attribution?

[ ] No
[ ] Yes

Requirements:

[ ] uses conventional commit messages

[ ] includes documentation
[ ] adds unit tests
[ ] tested upgrade from previous version

Notes:

/azp run


simple if statement inside component DOM

Hey,
This might be silly question, but I couldn't get it working so I decided to post it here. I'm not able to render component DOM based on boolean condition. For example if I want to hide or show different DOM nodes based on some logic.
versions:
-infernoJs dev
-babel-plugin-inferno: ^0.2.5,
I have tried following:
    class Component extends Inferno.Component {
        constructor(props) {
            super(props);
            this.state = {
                counter: 0
            }
        }
        render() {
            let condition = true; // some logic
            return (

                    {condition ?
BIG
 :
small
}

test

            )
        }
    }

    Inferno.render(<Component />, APP_ELEMENT);

output:
var tpl4282471407 = _inferno2.default.createTemplate(function (v0) {
	    return {
	        tag: 'div',
	        children: ['                    ', v0, '                    ', {
	            tag: 'p',
	            children: 'test'
	        }, '                ']
	    };
	});

	var tpl3625453295 = _inferno2.default.createTemplate(function () {
	    return {
	        tag: 'h1',
	        children: 'BIG'
	    };
	});

	var tpl4021787591 = _inferno2.default.createTemplate(function () {
	    return {
	        tag: 'h2',
	        children: 'small'
	    };
	});

	var tpl1546018623 = _inferno2.default.createTemplate(function (v0) {
	    return {
	        tag: v0
	    };
	});
// this function gets called runtime
	function loginPresenter() {

	    var Component = (function (_Inferno$Component) {
	        _inherits(Component, _Inferno$Component);

	        function Component(props) {
	            _classCallCheck(this, Component);

	            var _this = _possibleConstructorReturn(this, Object.getPrototypeOf(Component).call(this, props));

	            _this.state = {
	                counter: 0
	            };
	            return _this;
	        }

	        _createClass(Component, [{
	            key: 'render',
	            value: function render() {
	                var condition = true; // some logic
	                return tpl4282471407(condition ? tpl3625453295(null) : tpl4021787591(null));
	            }
	        }]);

	        return Component;
	    })(_inferno2.default.Component);

	    _inferno2.default.render(tpl1546018623(Component), _dom.APP_ELEMENT);
	}

fails with runtime exception:
Uncaught TypeError: Failed to execute 'appendChild' on 'Node': parameter 1 is not of type 'Node'.
Also tried following:
    class Component extends Inferno.Component {
        constructor(props) {
            super(props);
            this.state = {
                counter: 0
            }
        }
        render() {
            let condition = true; // some logic
            return (

                    {function(){
                        if (condition) {
                            return
BIG

                        } else {
                            return
small

                        }
                    }.call(this)}

test

            )
        }
    }

    Inferno.render(<Component />, APP_ELEMENT);

output:
	var tpl4282471407 = _inferno2.default.createTemplate(function (v0) {
	    return {
	        tag: 'div',
	        children: ['                    ', v0, '                    ', {
	            tag: 'p',
	            children: 'test'
	        }, '                ']
	    };
	});

	var tpl3625453295 = _inferno2.default.createTemplate(function () {
	    return {
	        tag: 'h1',
	        children: 'BIG'
	    };
	});

	var tpl4021787591 = _inferno2.default.createTemplate(function () {
	    return {
	        tag: 'h2',
	        children: 'small'
	    };
	});

	var tpl1546018623 = _inferno2.default.createTemplate(function (v0) {
	    return {
	        tag: v0
	    };
	});

// this function gets called runtime
	function loginPresenter() {

	    var Component = (function (_Inferno$Component) {
	        _inherits(Component, _Inferno$Component);

	        function Component(props) {
	            _classCallCheck(this, Component);

	            var _this = _possibleConstructorReturn(this, Object.getPrototypeOf(Component).call(this, props));

	            _this.state = {
	                counter: 0
	            };
	            return _this;
	        }

	        _createClass(Component, [{
	            key: 'render',
	            value: function render() {
	                var condition = true; // some logic
	                return tpl4282471407((function () {
	                    if (condition) {
	                        return tpl3625453295(null);
	                    } else {
	                        return tpl4021787591(null);
	                    }
	                }).call(this));
	            }
	        }]);

	        return Component;
	    })(_inferno2.default.Component);

	    _inferno2.default.render(tpl1546018623(Component), _dom.APP_ELEMENT);
	}

and it also fails runtime with following exception:
Chrome:  Uncaught TypeError: Failed to execute 'appendChild' on 'Node': parameter 1 is not of type 'Node'.
Firefox:  TypeError: Argument 1 of Node.appendChild is not an object.
tested on Chrome 47.0.2526.106 m and Firefox 43.0.2
What am I doing wrong here... ?
Havunen

@Havunen Sounds no good. When did you try this on the dev branch? A lot of changes happened the last 6 - 7 hours. Can you first try with the latest build I just pushed so we can start to narrow it down?

thanks for reply @Kflash, I just took latest and issue exists

Ok, could you try same thing without JSX to verify if this is a plugin issue?

@Havunen this seems to be a bug in the JSX plugin. It's trying to assign a RootDynamicNode to a tag value. I'll look into this later, as I'm travelling back home from the holidays right now.

@trueadm Can be something I did too. I rolled back.
@Havunen Can you try latest distro on dev branch too see if it still exist?

@Kflash I think this problem has been there for a while I had same issue before xmas. ( didn't have time to post it then)
@trueadm manually changing that line results into different exception,
failing here:
case ValueTypes.FUNCTION:
	  					throw Error('Inferno Error: A valid template node must be returned. You may have returned undefined, an array or some other invalid object.');

@Havunen actually scrap that, it's not a bug in the JSX plugin (the tag: v0 is correct), I misread something on my phone. I'll take a look at this ASAP when I get back :)

@Havunen can you please try again using latest dev. Thanks!

Great work guys! Just minor issue with isVoid import
isVoid is undefined.  Adding it (src/util/isVoid.js)
import isVoid from '../util/isVoid';

and making new build fixes this issue now. Thx!

@Havunen nice find, do you want to discuss Inferno with us on Slack? If so, drop me a mail at<EMAIL_ADDRESS>so I can give you an invite :)


Run clean before build in server package

All other packages already have this setup correctly.  I don't know why it was missing from server.

Coverage remained the same at 94.367% when pulling 3982f43fed43d6144085dbb6e56eca331eed0d8c on cody-clean-server-on-build into 23a9542acab8278e21d85e4a60403e813717b11c on main.


request slightly longer example in readme for enterprise github runs

Hi. Could more information be added to the readme for how to run this on a hosted enterprise github? The readme blurb seems to suggest I should add /API/v3/ onto the end of the base url for my enterprise github. That doesn't do anything for me or return an error, even with --verbose. I've tried using
gitleaks --github-url=<myURLtoHostedEnterpriseGithub>/<org>/<repo>
gitleaks --github-url=<myURLtoHostedEnterpriseGithub>/API/v3/
gitleaks --github-url=<myURLtoHostedEnterpriseGithub>/API/v3/ -github-org==<orgName>
gitleaks --github-url=<myURLtoHostedEnterpriseGithub>/<org>/<repo> -github-org==<orgName
gitleaks --github-url=<myURLtoHostedEnterpriseGithub>/API/v3/<orgName>
I'm making calls from with the firewall. I can't get any errors to print to terminal, so I'm struggling to figure out what is stopping me.
Any help would be great. I started to use this on public github and appreciate it a lot.
This is related to  #85 #84 by @eripa

dropped support for github/gitlab integrations in v7


fix: leader election stop not called

https://github.com/operator-framework/java-operator-sdk/pull/2059/files#diff-e493dfcdf8473a2824e76c20c95f07b6dc94a1305f6816d029b7de8e73a46931R59 should be removed. sorry for seeing this late

ahh, yes: https://github.com/operator-framework/java-operator-sdk/pull/2066


Update 5f3ef6e0f8c230bdd2349716.md

Added ;
Checklist:

[x] I have read and followed the contribution guidelines.
[x] I have read and followed the how to open a pull request guide.
[x] My pull request targets the main branch of freeCodeCamp.
[x] I have tested these changes either locally on my machine, or GitPod.

Closes #56284

the issue is present in other 43 files. I listed them all in the issue

Also, please update your PR title to something more descriptive so the maintainers will know what you are working. 👍
Update 5f3ef6e0f8c230bdd2349716.md doesn't let us know at quick glance what this PR is about


Enabling builder for org whose owner is not builder yields builder for subs but not owner

Steps to Reproduce

You have an org whose owner is editor
Enable builder for org from central

Current Result
Owner is still editor although org users see builder.
Expected result
Owner is builder, along with other org members.
cc/ @CartoDB/builder-backend

Unless I'm missing something, this is expected behaviour!

Thanks for clarifying!


node: add shebang rewriting

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[x] Have you written new tests for your changes? Here's an example.

[x] Have you successfully run brew typecheck with your changes locally?
[x] Have you successfully run brew tests with your changes locally?

Formulae that depend on node sometimes contain files that use a shebang like #!/usr/bin/env node and this can lead to issues when the node in a user's environment isn't brewed node.
For example, some node modules are compiled when the formula is built but if the user's node is a different major version than brew's node, the differing NODE_MODULE_VERSION can produce an error when certain parts of the application are used. The formula may build and test fine and the issue may only become apparent when more of the application is exercised (e.g., https://github.com/Homebrew/homebrew-core/pull/139389).
This adds a Language::Node::Shebang module, which allows us to use rewrite_shebang detected_node_shebang, ... in formulae to address this type of issue. I borrowed from the existing Perl and Python implementations but omitted logic that doesn't seem to apply to node (though do let me know if I've overlooked anything).

I've pushed a commit that incorporates the above feedback and extracts the length of the longest matching shebang string into a constant. I also created a constant for the regex, so it's not recreated every time #node_shebang_rewrite_info is called.
While I was at it, I reworked the existing Shebang modules for Perl and Python to use the previously-mentioned setup (adding constants and also type signatures) and to better align with each other (e.g., adding a perl_shebang_rewrite_info method). Lastly, I expanded the tests for Perl and Python, so they hit 100% coverage. That said, if we would prefer to handle the Perl/Python changes in a separate PR, I can pare this down to the Node changes.

How worried should we be about name clashes from these mixins? They now all have constants with the same names so if you included multiple of them in your formula (something that is technically possible but not present at the moment in core) at least one of them would get overwritten, right?
I also don't think we should really be that worried about the regexes being redefined each time since it doesn't seem to be a hot codepath and should really only be needed once for a handful of formula (67 by my count) during bottling. I guess what I'm saying is that I'm partial to how it was before.


Added table of contents to Suppressions Overview

Description of the change: Adds table of contents to Suppressions index.html
Reason for the change: #3088
Link to original source: Source

Closes #3088
@ksigler7

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Chase Hainsworth seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Classic first PR mistake: I accidentally committed under a generic email. Would it be possible to change the commit log for the first two commits to my actual email? Otherwise, the CLA can't be processed.


TagSet breaks visuals of StructuredList

Package
Carbon for IBM Products
Description
When nesting a TagSet inside a StructuredListCell, the bottom border of the cells that don't contain a TagSet are broken.
This seems to only happen in Safari. Using regular <Tag>s don't cause this issue.
Component(s) impacted
TagSet
Browser
Safari
@carbon/ibm-products (previously @carbon/ibm-cloud-cognitive) version
2.49.0-rc.0
Suggested Severity
Severity 3 = The problem is visible or noticeable to users but does not impede the usability or functionality. Affects minor functionality, has a workaround.
Product/offering
watsonx.governance
CodeSandbox or Stackblitz example
https://stackblitz.com/edit/github-ytnhnj?file=src%2FExample%2FExample.jsx
Steps to reproduce the issue (if applicable)
In Safari:

In Edge:

Release date (if applicable)
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct
[ ] I checked the current issues for duplicate issues

Hey @janhassel ,
As I investigated this issue, this is no way related to Tagset. <StructuredList> in carbon is using table display. Any div with a margin inside a table cell cause this odd behaviour in Safari browser, which I think is a known browser issue. However they are suggesting a work around by setting vertical-align to top, middle, or bottom seems to remove the extra border for the cds--structured-list-td.
https://github.com/user-attachments/assets/a48a107f-83fb-4b03-a790-3a268b8cb229

Please re-open if you feel any fix is required from our side.

Thanks @amal-k-joy! I moved it to core: https://github.com/carbon-design-system/carbon/issues/17667


Does not support Dvorak keyboard layout

It would be nice to have asdf in Dvorak keyboard layout.

/


Open a Potree viewer

I have installed potree and potree converter on an ubuntu server.  Successfully converted the point cloud datasets into potree format.
How can I open a display of Potree viewer, from the server ?

Can someone respond to my query?

It is not necessary to do an installation of potree and the converter on the server. All you need to do is convert your point cloud on  Windows machine. Then upload the directory with the converted data and the libs directory that has been created in the resources/page_template directory to the server. Edit the viewer_template.html file. You need to add the code for loading the point cloud. You can use the viewer.html file in the examples directory of the potree ZIP as example. Replace cloud.js with metadata.json and make sure that all paths are correct.

You can use https://github.com/potree/potree

You can use the viewer.html file in the examples directory of the potree ZIP as example. Replace cloud.js with metadata.json and make sure that all paths are correct.

That was exactly he precision I needed, after modifying different other examples without results. Thanks!

@tfwittwer  thank you so much i had the same problem.

@tfwittwer can you help me with my issue ? #613


Provide a way to check whether a company signed the corporate CLA

Hi,
I'm preparing a PR as an employee of BlackRock, and our policy states that all code is the intellectual property of the firm. I'm trying to check if my firm already signed the CLA and I only need to be added as a contributor to it, but the discussion groups and links on this page were removed.

Please acknowledge the issue - we need to proceed with the RWS rollout ASAP and it's being blocked due to the inability to check whether a company signed the CLA.

Hi @GBodoBLK - Could you check if https://cla.developers.google.com/ lists any existing corporate agreements for you? I believe you will need to login using your corporate email.

@krgovind I see the following, but surely that doesn't necessarily mean that nobody from BlackRock signed a contract?

@GBodoBLK I was able to verify through my internal resources that BlackRock does indeed have a Corporate CLA signed; but based on your view of the dashboard, it appears that you are not a party to it.
We would recommend checking internally within your organization on either becoming party to the CLA, or having someone who's already party to the CLA make the submission. Hope that helps!


Bug when select 2020-02-29

when select 2020-02-29, it will auto changed to 2020-03-01...

Some news?

Stepping through the code, the problem is that WheelDayPicker parses the date text without the year specified. So "Sat 29 Feb" is parsed into a date as Sun Mar 01 00:00:00 PST 1970.
The last day in February in 1970 is the 28th, which is why the date would roll over when parsing with 1970 as the year.

Here's my candidate fix for it: https://github.com/greensopinion/SingleDateAndTimePicker/commit/41f2ecf3098e633f04164ec6c9ef77b9a857b6fe


Fix typos and make bucket_interval selection clear

bucket_interval description has typos and is not clear.  Improve description and provide examples to aid understanding.

@EdProsser Hi Ed. One more cloudant related fix. Can you merge and then make the update on staging, to be included in the next update?

These updates have been merged into staging ready for next production push.


Python: List & matrix

Description :
What are: list & matrix?
Note :

Changes should be made inside the Python/ directory & Python branch.
Issue only for GWOC'21 contributors.
Issue will be assigned on a first come first serve basis, 1 Issue  ==  1 PR.
In the PR, keep this issue's title as your PR's title.

Must Follow : Contributing Guidelines & Code of Conduct before start Contributing.

I am interested ind documentation

Peddi sai lohith
Python batch 4

I would like to work on this issue via documentation. Thank you!!

Hi I'd like to contribute through documentation on this topic
Harmandeep - python - batch 4

Please assign me this issue . I am comfortable to contribute in any of the three ways.
Geetansh - python - batch 6

@adityabisoi
Sir, I would like to contribute to this issue.
Name: Priyanshi Naredi
Type: Documentation
Batch: 18

I would like to work on this issue via documentation.

@adityabisoi
Sir, I would like to contribute to this issue.
Name: Arushi Rautela
Type: Video
Batch: 6

I would like to contribute to this issue in the form of video
kindly please assign me this issue.
Thanks
Ishu khare
batch-1 (python)

@ankurg132 Is the mentor of this issue. Please reach out to him in case of queries.

This issue is currently open for audio and video contributions.

@adityabisoi @ankurg132
I would like to work on this issue via Audio.

Sure! @adityabisoi you can assign audio to @surjyaneeh


How to Start Blockchain

Descripion📜
Added a new blog in the blog section.
Fixes #45
Type of Change 📝

[x] Improve the readme of any project

Checklist ✔

[x] I'm SSOC'22 Contributor

Make  the font of the bigger size of all  decscription under each heading as its hard to read  that .. make one  font bigger

Great @AnmolSirola


Hero image for blog posts

Feature request

What problem does this feature solve?
It might enrich the UI, and it's common feature for blog.
What does the proposed API look like?
Developer can define it in front matter.
---
hero: ./hero.jpg
---

This would be great.
Is there a way to use the default theme with the blog plugin instead of the theme? That would be another way to also get the hero image and a bunch of other useful features.

Is there a way to use the default theme with the blog plugin instead of the theme?

A simple solution? I'm afraid not. But it would be possible if you learn how to develop a theme yourself.

Love this feat 😻 When will it be realized?


Auto-completion for macro-built interface fails in implementing class

I have an interface for a build macro:
@:autoBuild(lycan.components.EntityBuilder.build())
interface Entity { }

and interfaces which extend it:
interface CenterPositionable extends Entity {
	public var center:CenterPositionableComponent;
    ...
}

and classes which implement these interfaces:
class Player implements CenterPositionable

Outside of the implementing class, auto-complete works, but inside the class it fails. E.g.
class Test {
	public function new() {
		new Player().ce // Autocomplete brings up "center" from the interface
	}
}

class Player implements CenterPositionable {
    public function new() {
		this.ce // "center" does not show in the list
	}
}

Note that I have tried this with two classes in the same file exactly as above, and auto-complete still works in the test class, but not in the player class that implements the macro-built interface.

Pretty much impossible to tell what's going on here without the code to reproduce.
Generally, you're getting compiler completion?

@Gama11 All the code required to reproduce is practically here.
Builder.hx:
class Builder {
	public static function build():Array<Field> {return Context.getBuildFields();}
}

IBuilder.hx:
@:autoBuild(Builder.build())
interface IBuilder { }

MyInterface.hx:
interface MyInterface extends IBuilder {
    public var completeMe:String;
}

MyClass.hx:
class Test {
    public function new() {
        new MyClass().compl // Try to get autocomplete on "completeMe" (Succeeds)
    }
}

class MyClass implements MyInterface {
    public function new() {
        this.compl // Try to get autocomplete on "completeMe" (Fails)
    }
}

One sec, I'll put together a simple test case.

It's not quite as simple as I thought. I'm going to close this until I can figure out how to reproduce consistently. I have discovered some other strange behaviour with my current test case, but not yet the original issue. :P


Richardson number diagnostic

Would be useful to add Ri(z) to the long list of statistics that are output.
It can be computed from U(z), V(z), and B(z) but probably we need to compute the local Ri(x, y, z) then horizontally average?
@tomchor also wrote a KernelComputedField in Oceanostics.jl: https://github.com/tomchor/Oceanostics.jl/blob/81d48c323f38f38617ed162e320d14c1691a615f/src/FlowDiagnostics.jl#L7-L15
Do we just add a dependency on Oceanostics.jl to make use of all the new diagnostics?
cc @xinkai

It would seem Oceanostics.jl is more general, so maybe the right approach is to add a dependency to it?

I'm definitely fine with adding Oceanostics.jl as a dependency. I've tested it (albeit for 2D vertical domains only) and it seems to be working fine.
But I don't know why the code needs that statistic, instead of keeping Ri as a possible user-defined diagnostic. I guess I don't know what "long list of statistics" is being referred to here. Is that related to some turbulence closure?

Ah haha nice. Yeah I think the three_layer_constant_fluxes.jl example is up to 51 statistics without third-order statistics:
julia> ds["timeseries"] |> keys |> length
51

julia> show(IOContext(stdout, :limit => false), ds["timeseries"] |> keys)
["t", "vb", "uT", "tke_shear_production", "tke_advective_flux", "wc₀", "uv", "c₁c₁", "νₑ_∂z_v", "uu", "uc₁", "c₁", "p", "e", "wc₁", "vv", "vT", "bT", "v", "bc₂", "wT", "c₂", "wc₂", "uc₀", "wb", "νₑ_∂z_u", "κₑ_∂z_T", "tke_buoyancy_flux", "uc₂", "wv", "κₑ_∂z_c₁", "bc₁", "ww", "u", "T", "wu", "vc₁", "bc₀", "b", "c₀c₀", "c₀", "c₂c₂", "vc₂", "κₑ_∂z_c₀", "ub", "νₑ_∂z_w", "tke_dissipation", "κₑ_∂z_c₂", "TT", "tke_pressure_flux", "vc₀"]

Also for the record, I'm very much open to you guys "dumping" KernelComputedFields and other statistics/diagnostics on Oceanostics to keep LESbrary for other stuff. We'd just need to discuss organizational aspects a bit.

More packages with more focused purposes = better, probably...


Enable Form Recognizer tests

API change check
API changes are not detected in this pull request.

/azp run java - formrecognizer - tests

/azp run java - formrecognizer - tests


Issue when transfering propriety from a user to an organisation?

When transfering propriety of a repository from a Gogs user to a Gogs organisation, the address of the repository of the mirror now looks<EMAIL_ADDRESS>user:@ part isn't present on a new mirror. with userwhere gogs user,
Is there an issue?
I am using Gogs 0.8.10.

I can't reproduce this. The repo, is it a mirror or a plain repo?

Can't reproduce with a mirrored repo either...

Thanks your feedback!

the address of the repository of the mirror now looks<EMAIL_ADDRESS>
Can you rephrase this sentence?

address of the repository mirrored is<EMAIL_ADDRESS>user:@ shouldn't be here.
I couldn't reproduced it.

@M5oul Can you try to test on master branch version see if this problem still exists?

I can't reproduce it. I close the issue.


Cancel old BackgroundRefresh if config is reloaded

This PR cancels BackgroundRefresh goroutines in the case when a plugin is instantiated with the same name. This happens e.g. when a watched config has a change.
This will not prevent the leak if the Plugin is deleted from a config or will be renamed, but it will prevent leaks from changes in a config that have nothing to do with the plugin.

@simonpahl is this ready for review or keepin it in Draft is intentional ?

@simonpahl is this ready for review or keeping it in draft is intentional ?

@simonpahl ?

sorry i was not available for a week

sorry i was not available for a week

plz adjust commit message, so corresponding #67 will be closed after merging this

I mentioned the issue number in the commit. Will this suffice?

I mentioned the issue number in the commit. Will this suffice?

no, its not enough for auto closing
https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword

Thanks @simonpahl
Available in 0.8.1


integration: Configure drain time in integration tests

integration: Configure drain time in integration tests

Set drain_time_ in integration tests to pass on to the server's DrainManagerImpl
Lengthen the drain period to 10 seconds in DrainClose integration tests, which uncovered  #11240.
Fix the test race with retries, i.e. keep sending requests until the drainClose() call in conn manager is hit

Risk Level: Test-only change
Testing: Test-only change
Fixes #11240

/retest

@mattklein123 this has the retry test strategy we discussed earlier this week. I don't know what's going on with the presubmits.

/retest


Hello, I encountered a problem when I reproduced the code. I tried the solutions on the Internet without success. Can you help me take a look? Plz~

RuntimeError:
Tried to access nonexistent attribute or method 'crow_indices' of type 'Tensor'.:
File "D:\Pycharm\KGCL\kgcl\lib\site-packages\torch_sparse\tensor.py", line 109
def from_torch_sparse_csr_tensor(self, mat: torch.Tensor,
has_value: bool = True):
rowptr = mat.crow_indices()
~~~~~~~~~~~~~~~~ <--- HERE
col = mat.col_indices()

Problem solved by after I reinstall torch_sparse==0.6.10

Problem solved after I reinstall torch_sparse==0.6.10
Thanks for your solution. it‘s work.


avoid array allocation

https://www.gamlor.info/wordpress/2017/08/javas-enum-values-hidden-allocations/

fyi: a similar change was made in Eureka last week:  https://github.com/Netflix/eureka/pull/1485

fyi:  the Hazelcast project uses a similar technique:
https://github.com/hazelcast/hazelcast/blob/master/hazelcast/src/main/java/com/hazelcast/jet/core/JobStatus.java#L69


Ensure compatibilty with tools that support Debug IDs

BunJS has added some debug ID support and other tools will potentially follow suite. Since we do a lot of custom magic ourselves in Sentry CLI, and if debug IDs continue to populate around, then we will potentially have compatibility issues with our own injection of debug ID comments and the injected code snippets.
Interim solution in the bundler plugins:

When preparing the files for the upload, wipe existing debug ID comments and add our own.

This is becoming more important now that rollup, webpack, and vite will have built-in debug id support.


Fix minor errors in Swedish translation

This fixes some minor errors in the Swedish translation. Info hash -> Infohash for example
Any ETA for the next version btw?

Great! There's no general ETA for the next version, but I'd like to release something quite soon.


Remove unused functions from util.ts

Tested by running grunt test (and acking the code base for all function names)

Do we need extractCryptoKey?

Good catch, no.  I saw it referenced in the spec file for util and interpreted that as it being used.  Updating the commit.

sweet! keep it up! :+1:


function to rename crystal

closes #99

Codecov Report

Merging #147 (74710f8) into master (78464cc) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #147      +/-   ##
==========================================
+ Coverage   93.52%   93.54%   +0.01%
==========================================
  Files           8        8
  Lines         973      976       +3
==========================================
+ Hits          910      913       +3
  Misses         63       63

Impacted Files
Coverage Δ

src/Xtals.jl
100.00% <ø> (ø)

src/crystal.jl
94.88% <100.00%> (+0.03%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78464cc...74710f8. Read the comment docs.


OOPS/Semester average calculator

Simple java program to calculate average sem marks using Inheritance concept

You can follow me on github


Django Ninja returning int

Using a Django Hash ID Field with Django Ninja returns the original int rather than the Hash ID of the field.
[   {     "id": 109908,     "product": "Test Product"   } ]
The above should be:
[   {     "id": "a1b3xc",     "product": "Test Product"   } ]
Is there a way to return the Hash ID instead?

Check your apps.py and delete there default_auto_field = "django.db.models.BigAutoField" then run command python manage.py makemigrations and python manage.py migrate


Devices got reorganized after update of matterbridge

Hi,
I updated matterbridge via "docker compose pull" from version 1.6.1 to 1.6.2. Afterwards almost all devices seem to be rediscovered in Alexa. So the configuration in Alexa (basically the renaming of the devices) got useless again and I will have to rename and configure them again. :-(
Seems that this happened for almost all devices but some devices still remained as before and some devices occur twice now. Do not see any pattern here. At least it has nothing to do with the devices types. Maybe the devices that kept their old names are just dirty left overs?!
The endpoint numbers of the device seem to be much higher than before, but I can not proof it anymore. Maybe that's the reason why Alexa created these new devices and removed the old ones.
I am not sure but I would say previous updates via matterbridge itself did not show theses problems. Will try out that way the next time.

Hi,
I can just imagine that changing the names in Alexa can cause the issue. Like finding new devices when you update.
The device (nodeLabel in Matter) is writable by the controller and persists on restart of the node.
If Alexa writes it then you restart and it doesn’t find the old one and create a new device?

 Updating now from 1.6.2 to 1.6.4 via update mechanism of matterbridge itself did not cause these issues again yet.

Using "docker compose pull" again did not cause that problem yet.

I checked the code and I had a possible reason.
I those releases I updated some revisions on the Matter deviceTypes.
It is possible that it causes Alexa to believe they are new...

Does not sound so good if that's the reason. Is there any chance to prevent that happening in the future again?! Can imagine that preventing this would be hard to implement by design?! Did this possibly also affect other matter controllers or is this just another thing thats Alexa specific? If just Alexa specific we should add this information to the discussion.

Is difficult to answer. I can only tell that @tammeryousef1006 and I before releasing an update, we test not only new setups from 0 but also the existing setups.
I have Apple in my production setup and never had this issue. Never lost configurations at controller side.
I hope this is not a consequence of renaming the devices in Alexa.
I also didn’t read about this kind of issues since a lot.

same here , never lost a device over homeassistant , smartthings , google home or alexa  over upgrade

Unfortunately I must say the problem is reproducable.
These are the steps to reproduce.

Checkout matterbridge with tag 1.6.1 and rebuild in folder "matterbridge"
npm install
npm run build
Checkout matterbridge-shelly with tag 1.0.10 and rebuild in folder "matterbridge-shelly"
npm link matterbridge (if needed)
matterbridge remove . (if needed to remove matterbridge-shelly)
npm install
npm run builld
matterbridge add . (to add matterbridge-shelly)
npm start
Ensure that a shellycolorbulb (or any other device) is in the whitelist and noCachelist
Restart matterbridge
Remove the device from noCachelist
Restart matterbridge
Check enpoint ID of device in matterbridge
Pair with alexa if needed
Rename the Hub device in alexa (append " Bridge")
Rename the light device in alexa (some other name)
Stop matterbridge
checkout matterbridge to tag 1.6.2
npm install
npm build
npm start

Now the device gets another endpoint id compared to the one in step 16. Alexa now creates a new Hub device again with name as in the webapp of the device and a new light device with the typical naming scheme (e.g. "First light")

To check if this also happens if the devices are not renamed in Alexa, you should use outlet or switch device. Instead of renaming you can than change the type of the outlet device (not the hub) in alexa to light. I would expect that this type is than also gone after updating to 1.6.2. Also the devices should disappear from routines in alexa. If you want I can test this, but will do that later, when got time again.

You don't need to build locally even because the local environment is not verified. (All packages are build inside a workflow with the ideal environment and ubuntu latest with node 20).
Just npm install -g<EMAIL_ADDRESS>--omit=dev
Same for mattebridge-shelly.
I will do the test myself.

Hi,
yesterday I finally understood what went wrong in that update.
It is a side effect of removing a cluster from the aggregator to be 100% Matter compliant.
That changed how matter.js store the endpoint numbers.
Thanks for pointing it up.

Thx for investigating! BTW: got new endpoint ids with the last update again, but this time did not need to reconfigure things in Alexa. :+1:


chore(readme): update links, references, install notes for 1.x branch

Summary

Minor update, self explanatory title

Change List (commits, features, bugs, etc)

update readme.md

:tada: This PR is included in version 1.90.1 :tada:
The release is available on:

npm package (@release-1.x dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.5.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[fixed] Update state to nextState after running RouteHook

If any route hooks are registered, transitionHook calls matchRoutes to determine what route hooks and caches the computed next state as partialNextState.  However when these cached results are used later in the history.listen callback, it shortcuts logic in the main path to update the history object's state.
Since this is required of all paths that call finishMatch (including the one that uses the cached partialNextState), it's been moved there.

I didn't originally intend for match to update state at all, actually. Ideally match would only be used to compute the next state whatever the current state may be. Ideally, we would update state in the history.listen callback instead.

Understand your point about making match a pure function, without a side-effect on state.  I just played around, and moved the state = nextState logic into listen, and out of finishMatch.  All tests passed, except for "renders active Links as active" in "Server rendering."
Bizarre, so I did some more snooping and discovered that match (modules/match.js), which constructs a temporary staticHistory and calls match on it is implicitly imperative.  The callback match takes expects the history object to be mutated (which it hadn't been with a purely function history.match implementation), causing the calls to history.isActive in <Link> to fail in the test.
Options:  1) keep history.match imperative but make sure all paths update history's internal state; 2) make history.match pure but add a new method matchAndUpdate (or whatever) that is used in history.listen and match (modules/match.js).
As it is, there seems to be a bug, whereby the listener set up by registerRouteHook short-circuits an update to state, after which the router doesn't transition to the next route.  I've never written Karma tests, but will try to work on one.
BTW, any feedback on whether this is helpful or not is appreciated.  Long a stalker in the OSS world, I'm pretty new to pull requests and contributing ...

Thanks for taking a closer look at this, @jmathews. It's actually really helpful to have someone reading through the code and understanding it to the point that you do.
In be3719661b5714a15d3e70f50503450caddc3ee8 I moved the state updates out of useRoutes.match and back into useRoutes.listen where I originally had it. This resolves the issue this PR was originally meant to solve, and useRoutes.match is once again a pure function, which I like.
Now, the server rendering tests are borked because the top-level match function doesn't have state anymore. So we essentially need a "stateful" match function (or, as you described it, matchAndUpdate). Let's discuss that in a separate issue.


OSCI: Onboard the docs image

Description
WIP.
Checklist

[x] Investigated and inspected CI test results

Testing Performed
CI is sufficient

/test go-unit-tests-release


update sample queries related to pages API phase 2

[WIP]  do not merge this until the code rollout

@microsoftgraph/msgraph-devx-api-write Hi folks, could you please take a look on this? Many thanks  :)

@sangle7 I've approved the changes. Please merge when you are ready.

@millicentachieng could you help to merge it since I dont have the permission?


Simplified settings' BASE_DIR definition

Suggested by milliams on reddit as simpler on the back of my pathlib blog post. I agree - it's more user friendly. parents[1] opens up the questions like "Which order are the parents in?" and "Does 1 mean the first or the 2nd parent?".

Checked performance, no real difference.
In [1]: from pathlib import Path

In [2]: p = Path('.').resolve(strict=True)

In [3]: %timeit p.parents[1]
1.56 µs ± 11.1 ns per loop (mean ± std. dev. of 7 runs, 1000000 loops each)

In [4]: %timeit p.parent.parent
1.66 µs ± 10.6 ns per loop (mean ± std. dev. of 7 runs, 1000000 loops each)


Swift3 branch is also not working

Carthage cart file with github "SwiftyJSON/SwiftyJSON" "swift3" is also not working?

Folks over at IBM converted it
https://github.com/IBM-Swift/SwiftyJSON/blob/master/Source/SwiftyJSON.swift

Apparently the IBM-Swift version is not compatible (or built for) the iOS platform.

@UncleRic Care to explain further? Like it won't work at all or do you mean it just won't work with Carthage?

We have landed swift3 support in master branch, feel free to try it out. 😄

@zhigang1992 Very Nice . Thinks

xcode still wanted to convert the code when i installed it via cocoa pod.

I have the same problem

@Adarkas2302 @MaximGorin
Odd, can you paste in the corresponding section in podfile.lock?
Also your cocoapods version as well.
Thx

@zhigang1992
`PODS:

SwiftyJSON (2.3.2)

DEPENDENCIES:

SwiftyJSON (from https://github.com/SwiftyJSON/SwiftyJSON.git, branch swift3)

EXTERNAL SOURCES:
SwiftyJSON:
:branch: swift3
:git: https://github.com/SwiftyJSON/SwiftyJSON.git
CHECKOUT OPTIONS:
SwiftyJSON:
:commit: 494f9bf12763d634216ce5b10a88bb5240f59074
:git: https://github.com/SwiftyJSON/SwiftyJSON.git
SPEC CHECKSUMS:
SwiftyJSON: 04ccea08915aa0109039157c7974cf0298da292a
PODFILE CHECKSUM: d646f0dd20b277efbdfbbc3803cb9204c296ab67
COCOAPODS: 1.0.0
`

@MaximGorin you have to update to version 3.0.0 for swift 3 support.
And 2.4.0 for swift 2.3 or lower.
Let me know if you're still having issue with it.
Cheers

@zhigang1992 the error persists
PODS:

SwiftyJSON (3.0.0)

DEPENDENCIES:

SwiftyJSON (~> 3.0.0)

SPEC CHECKSUMS:
SwiftyJSON: f57b2b44bc166617372d1c70773591fe9f0f5fd4
PODFILE CHECKSUM: 3c7432f9e522dd9230a200cf2f7646c325981751
COCOAPODS: 1.0.0

Can you try this from the RxSwift repo
post_install do |installer|
  installer.pods_project.targets.each do |target|
    target.build_configurations.each do |config|
      config.build_settings['SWIFT_VERSION'] = '3.0'
      config.build_settings['MACOSX_DEPLOYMENT_TARGET'] = '10.10'
    end
  end
end

Or you can update to cocoapods rc version by
gem install cocoapods -v 1.1.0.rc.2

Let me know if it works.

@zhigang1992 it works. Thx

Also, the master branch was updated to Swift 3 and I don't have any errors with Carthage and Xcode 8

Closing now, feel free to reopen this if you are running into more issues.
🍻


[WIP] Add spark 35

Which issue does this PR close?
Adds Spark 3.5
Rationale for this change
Spark 3.5 is the latest Spark release.
What changes are included in this PR?
Adds Spark 3.5 support, this introduces a new per-spark version of shims as part of adding interfacing to the 3.5 APIs.
This has the advantage of static compile checks over the existing shim approach which does reflection for everything, but I can switch to the runtime reflection model for consistency if that's preferred.
How are these changes tested?
WIP

Some class and function has changed in spark 3.5, maybe we need some more shim classes to support both spark 3.5 and the versions before.
I has a similar commit to do this:
https://github.com/apache/arrow-datafusion-comet/commit/b038267eb5e6ddafccf84b0147760f6992f36077

Yup this adds some shims (there are existing shims too for 3.3 etc but they use reflection heavily).

FWIW I created https://github.com/apache/arrow-datafusion-comet/issues/140 to improve the current Spark shim handling.

I love it :)
On Thu, Feb 29, 2024 at 10:45 AM Chao Sun @.***> wrote:

FWIW I created #140
https://github.com/apache/arrow-datafusion-comet/issues/140 to improve
the current Spark shim handling.
—
Reply to this email directly, view it on GitHub
https://github.com/apache/arrow-datafusion-comet/pull/127#issuecomment-1971741645,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAOT5NRC355APXEYYRFIADYV53MJAVCNFSM6AAAAABD5DERESVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZRG42DCNRUGU
.
You are receiving this because you authored the thread.Message ID:
@.***>

FYI https://github.com/apache/datafusion-comet/pull/318 is just merged

Thanks for getting this started @holdenk. I have now created https://github.com/apache/datafusion-comet/pull/587 to add experimental support for Spark 3.5.1 (there will be follow up PRs to fix some test failures), so will close this one.


Reporting errors on .git files (returns)

Hi,
My vscode just self-updated to 1.41.0 and I am now seeing behaviour similar to that reported in issue #4 and resolved in v0.2.1.  Here is a screenshot of what I am seeing:

I only have the one shellcheck option set in vscode:
"shellcheck.executablePath": "C:\\Apps\\shellcheck\\shellcheck-stable.exe"

Same here, have you tried the extension version from before the fix from #4?

Thanks for reporting, needs time investigating what happened in vscode (again) 😂

It seems that a new scheme "gitfs" is introduced, I'll fix it later


AOT NGC Compiler fails on scss @import

First of all, thank you for this boilerplate!
I am running into a problem on how to use AOT ngc compiler, since I have @import in my component.scss file. Do you know how to resolve this? Getting scss to css instead? Thanks in advance.

did it work with you?

Oh, I changed the scss to css in component.ts. And it all worked. Thanks for the response.


Click house/v1.54.3

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 17 committers have signed the CLA.:white_check_mark: rschu1ze:x: drfloob:x: ejona86:x: ctiller:x: yashykt:x: ananda1066:x: stanley-cheung:x: veblush:x: jtattermusch:x: matthewstevenson88:x: markdroth:x: apolcyn:x: yousukseung:x: XuanWang-Amos:x: sergiitk:x: gnossen:x: eugeneoYou have signed the CLA already but the status is still pending? Let us recheck it.


INT-2323 Fix links in codemod README files

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


No OTAA join with RN2483 or RHF76-052 to loraserver.io

Could not OTAA join, neither RN2483 nor AI76-052. Use version 5.3.3 and loraserver.io. Loraserver receives JoinRequest and sends JoinAccept. Loraserver gateway processes ../rx than ../tx than ../ack.
Debug reads:
rxPkt:: t=xx:xx:xx, f=1, sf=7, a=6E674846, flags=50, addr=0, len=23
RXDONE in dT=836939188: I=RXDONE HEADER , F=1, SF=7, E=0, S=RX   , eT=14771212, dT=836941761
G addLog:: fileno=1, rec=34: 1 xx xx xx xx xx xx xx xx xx xx xx {"rxpk":[{"tmst":836942776,"chan":0,"rfch":0,"freq":868.299987,"stat":1,"modu":"LORA","datr":"SF7BW125","codr":"4/5","lsnr":9,"rssi":-53,"size":23,"data":"xxxxxxxxxxxxxxxx"}]}
M readUdp:: PKT_PULL_RESP received
T LoraDown tmst=841942776
M PKT_TX_ACK:: micros=837423554
M PKT_PULL_RESP:: size 198 From xx.xx.xx.xx, port 1700, data: txpk...
T TX done:: I=  --  , F=1, SF=7, E=1, S=TX   , eT=5031321, dT=842003247
T TXDONE:: rcvd=842049560, diff=106844
T TXDONE:: done OK
Tried both #define _STRICT_1CH	1 and #define _STRICT_1CH	0.
ABP works fine with both modules in this setup.
Any hint? Thanks a lot.

Issue seems related to loraserver.io since OTAA works fine with TTN. Sorry for bothering.


Has error: authentication session not found in request (Gogatekeeper + keycloack)

Title

Has error: authentication session not found in request (Gogatekeeper + keycloack)
Summary
Hi!
I have a question how can i see the problem of keycloack in logs of gogatekeeper?
Sometimes in logs I see those logs (user lost session):
2024-11-29 11:01:56 2024-11-29T08:01:56.760Z    error   authentication session not found in request
2024-11-29 11:01:56 2024-11-29T08:01:56.782Z    error   state parameter mismatch
2024-11-29 11:01:56 2024-11-29T08:01:56.802Z    error   authentication session not found in request
2024-11-29 11:01:56 2024-11-29T08:01:56.830Z    error   authentication session not found in request
2024-11-29 11:01:56 2024-11-29T08:01:56.839Z    error   unable to exchange code for access token        {"error": "oauth2: \"invalid_grant\" \"Code not valid\""}
2024-11-29 11:01:56 2024-11-29T08:01:56.889Z    error   authentication session not found in request
2024-11-29 11:01:56 2024-11-29T08:01:56.920Z    error   authentication session not found in request
2024-11-29 11:01:56 2024-11-29T08:01:56.949Z    error   authentication session not found in request
2024-11-29 11:01:56 2024-11-29T08:01:56.987Z    error   authentication session not found in request
2024-11-29 11:01:57 2024-11-29T08:01:57.014Z    error   authentication session not found in request
2024-11-29 11:01:57 2024-11-29T08:01:57.039Z    error   authentication session not found in request
2024-11-29 11:01:57 2024-11-29T08:01:57.072Z    error   state parameter mismatch

And I think this problem with keycloack, but i don't have permissions to logs of keycloack (because it's not our app).
Сan I determine on whose side the problem is based on the keeper logs?

Environment

Expected Results

Actual Results

Steps to reproduce

Additional Information

Authentication session not found in gatekeeper logs can mean that somebody is trying to access protected site without token, there too little information here about situation you are trying to solve


Enable/disable map templates within new create dialog with a feature flag

On premise stuff will need it.

It doesn't make sense, people will be enabled or disabled from the superadmin


1.0.0

Codecov Report

Merging #429 into 2.7.0-release will decrease coverage by 3.85%.
The diff coverage is 84.45%.

@@                 Coverage Diff                 @@
##             2.7.0-release     #429      +/-   ##
===================================================
- Coverage            88.69%   84.83%   -3.86%
- Complexity             129      160      +31
===================================================
  Files                   19       33      +14
  Lines                  398      455      +57
  Branches                48       50       +2
===================================================
+ Hits                   353      386      +33
- Misses                  24       47      +23
- Partials                21       22       +1

Impacted Files
Coverage Δ
Complexity Δ

...ring/boot/actuate/health/DubboHealthIndicator.java
94.28% <ø> (ø)
18 <0> (?)

...pache/dubbo/spring/boot/util/EnvironmentUtils.java
96.42% <ø> (ø)
12 <0> (?)

.../context/event/WelcomeLogoApplicationListener.java
92% <ø> (ø)
5 <0> (?)

...ubboDefaultPropertiesEnvironmentPostProcessor.java
91.42% <ø> (ø)
14 <0> (?)

...actuate/health/DubboHealthIndicatorProperties.java
85.71% <ø> (ø)
2 <0> (?)

...nfigure/DubboHealthIndicatorAutoConfiguration.java
100% <ø> (ø)
2 <0> (?)

.../org/apache/dubbo/spring/boot/util/DubboUtils.java
81.81% <ø> (ø)
4 <0> (?)

...uate/endpoint/DubboPropertiesMetadataEndpoint.java
100% <100%> (ø)
2 <2> (?)

...g/boot/actuate/endpoint/DubboShutdownEndpoint.java
100% <100%> (+5.26%)
2 <2> (-1)
:arrow_down:

...tuate/endpoint/metadata/AbstractDubboMetadata.java
82.6% <100%> (ø)
14 <1> (?)

... and 41 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e5f935...050d4e4. Read the comment docs.


addressing recent issues

resolves #83  and resolves #81  and resolves #79 and resolves #82

saying no hyperlinks in overall takeaways
saying no hyperlinks in writing section

Anywhere else we need to? Is it emphatic enough? This thing Jeff sent is kinda intense: https://nexus.od.nih.gov/all/2023/01/10/dms-plan-tip-leave-the-hypertext-at-home/

@avahoffman  does this link seem kinda equivalent to the activity code link that is broken that we had before: https://sharing.nih.gov/node/112
I can't quite recall what it was like

@avahoffman does this link seem kinda equivalent to the activity code link that is broken that we had before: https://sharing.nih.gov/node/112
I added it, but there is also this option: https://sharing.nih.gov/data-management-and-sharing-policy/about-data-management-and-sharing-policies/research-covered-under-the-data-management-sharing-policy#research-covered-by-the-2023-data-management-&-sharing-policy
I can't quite recall what it was like

Yes I think that's basically what it was!

LGTM!
Also edited this slide :)

Perfect - thanks!


More verbose logs on opening file

:shipit:

@drolando cool with you?

+1. Paging @drolando ?

+1


Provide a setting to 'queue' or 'play' when adding to an already populated stream via Omnibox

Generally speaking, I think it would be nice to support at the bare minimum:
"streamus songname @play"
"streamus songname @add"
"streamus songname @save"
where @play would begin playing the song (same as default?), @add would simply add the song to the end of the stream's queue, and @save would save the song to the current playlist. Maybe.

This is added, but I need to provide better instructions on how to use it.


goproxy.AlwaysReject seems doesn't work

which code
this example https://github.com/elazarl/goproxy/blob/master/examples/goproxy-eavesdropper/main.go#L22
what I do
curl https://test.baidu.com/ -x "http://<IP_ADDRESS>:8080" -k

what I except
connect failed
what actually happen
connected

some supplement
in line 22, we got
proxy.OnRequest(goproxy.ReqHostMatches(regexp.MustCompile("^.*baidu.com$"))).
		HandleConnect(goproxy.AlwaysReject)

in the doc https://godoc.org/github.com/elazarl/goproxy#ReqProxyConds.HandleConnect , we find the explain rejects all CONNECT requests, so I think my connect should be reject, but I connected successfully, it seems doesn't work

Is that my problem?

Hi @hundan2020 try using this code:
proxy.
		OnRequest(goproxy.ReqHostMatches(regexp.MustCompile("baidu.com"))).
		HandleConnect(goproxy.AlwaysReject)

According to package http documentation, req.Host "may be of the form 'host:port'".
So when visiting https://test.baidu.com/, req.Host is actually "test.baidu.com:443", which doesn't match with the regexp.MustCompile("^.*baidu.com$") .
(One more note: the dot(".")s in the above regular expression are not escaped, so it matches "testbaidu.com" "test.baidu1com" as well. Maybe regexp.MustCompile(`^(.*\.)?baidu\.com$`) would be better?)

On a same note:
proxy.OnRequest(goproxy.ReqHostMatches(regexp.MustCompile("^.*$"))).HandleConnect(goproxy.AlwaysReject)

Doesn't seem to work. I want to block all traffic that are not explicitly allowed.


[FLINK-16753] Use CheckpointException to wrap exceptions thrown from AsyncCheckpointRnnable

Cherry-pick from https://github.com/apache/flink/pull/11509 to branch release-1.10.
What is the purpose of the change
If an exception is thrown from task's async checkpoint process, the checkpoint will be declined as expected, but the reason for declining checkpoint will be regarded as #CheckpointFailureReason.JOB_FAILURE, which gives a wrong message to users. We should replace #CheckpointFailureReason.JOB_FAILURE with #CheckpointFailureReason.EXCEPTION, otherwise user will see "The job has failed" on Checkpoint UI.
Brief change log
Use #CheckpointException to wrap the exception thrown from #AsyncCheckpointRunnable.
Verifying this change
A trival rework without testing.
Does this pull request potentially affect one of the following parts:
This change will correct the error message when circumstances mentioned above happen.
Documentation
No need.

@flinkbot run azure

The failure is from python testing module, which should be unrelated to my changes.


Broken Documentation Link to Dependency Injection Example (and possible documentation improvements)

Information

OS: Windows
Version: 11
Terminal: Cmder

Describe the bug
The documentation link on this page is broken in the official docs.
To Reproduce
Open the relevant documentation, scroll to the "Dependency Injection" subheading, and click the first link.
Expected behavior
I expected to find relevant documentation to help troubleshoot the 'TypeRegistrar' is inaccessible due to its protection level error when trying to copy/paste code from the dependency injection example.
Screenshots
This is the relevant error when following the example docs.

Additional context
I haven't done a through search of the documentation for other examples, but there are likely more broken links in the docs.
Searching for the specific error I'm running into led me to this answer. I've found a few more answers in various issues, and all the relevant links are pointing to the old example links. I think I've found the relevant implementation of TypeRegistrar at this location, but I'm not sure, since there are multiple classes with that name spread between the main project and the example docs.
Recommendation to Rename Example Class
After digging through various issues to try and find the correct links, it seems like I'm not the first person to struggle with implementing DI due to namespace collisions. I'd suggest updating the examples to not collide class names. Maybe rename the example to something like MyExampleRegistrar? That would make it explicitly clear just from the class name that you're not supposed to find a default implementation.
It's quite confusing to have the documentation implement a class with the exact same name as another private class. It makes it difficult to search for the right answers. It's easy to make the mistake of thinking you're failed to include the correct dependencies, rather than thinking you need to implement that same class in a different namespace. Renaming the example implementation would make things far more clear.
Recommendation to Improve Documentation for Better Clarity
I know the documentation already says "TypeRegistrar is a custom class that must be created by the user", but it's easy to miss that single sentence when skimming dozens of pages of docs. I definitely made that mistake earlier today. That sentence is massively more important than the surrounding context. Updating the docs to move that section into a warning box would make it explicitly clear that you're not supposed to try and resolve access issues with the private TypeRegistrar. See the example mockup I made below.

Alternatively, since the example implementation is so basic, you could just provide a default registrar implementation for basic use cases, something like SingletonTypeRegistrar in the library, and leave alternative implementations up to the end user. I'm only using DI for a basic global logger and a global settings cache, so I'm just going to end up copy/pasting the example Singleton class because I don't need anything more complex for my current project. Providing a default implementation would at least give people a simple option to get started, without increasing the maintenance burden by any real amount.

Please upvote :+1: this issue if you are interested in it.

Broken links have been caused by https://github.com/spectreconsole/spectre.console/pull/1598, specifically links referencing examples (which have now been split out into its own project)
eg. https://github.com/spectreconsole/spectre.console/tree/main/examples/Cli/Injection (now a 404)
should be: https://github.com/spectreconsole/examples/tree/main/examples/Cli/Injection
Proposed approach to fix

Find and replace on the documentation markdown files
Broken link checker on the published spectre.console website (?)

cc: @patriksvensson

Providing a default implementation [of TypeRegistrar] would at least give people a simple option to get started, without increasing the maintenance burden by any real amount.

I've often wondered why we've avoided doing this @nils-a, can you remember why?

Hello @alex-lowe-quickparts, I like this issue report, I thank you for the time spent writing it, I find it high quality and I agree with what you say. I'm going to remove the triage label, and if no one gets to it first, I will probably aim to address it myself. Hopefully you will still be on hand to sanity check the updated documentation/examples etc, when the time comes.

Hello @alex-lowe-quickparts, I've rewritten the dependency injection section as follows (screenshot is from my localhost, not published yet) and renamed the classes in the examples solution accordingly, do you think it fully satisfies this issue?


Color tweaks

Adds color for CellEditor and RodEditor

Seems ok

:tada: This PR is included in version 1.3.4 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket: