🤦VS Code extensions do not support esm

🎯 Aim
The aim of this issue is to track the support of es modules in VS Code extensions.
Issues with more info:

https://github.com/microsoft/vscode/issues/130367

Currently using CLI for Microsoft 365 directly from PnP builds is not possible due to that, so for now as a temporary workaround the CLI dependency is added from a local version of the package which was reverted to common js
https://github.com/Adam-it/cli-microsoft365/tree/cli-cjs

Yep, that's a serious disappointment.
Did you try using vite?

Yep, that's a serious disappointment.
Did you try using vite?

Not sure how would that help for a dependency that is not used in webview but in the extension itself 🤔. Do you have any example I could check 👍?

Yep, that's a serious disappointment.
Did you try using vite?

Not sure how would that help for a dependency that is not used in webview but in the extension itself 🤔. Do you have any example I could check 👍?

Yep, I use vite to bundle my VSCode extension
It's WIP, but the bundling part works; it bundles from my typescript source written in ESNext to a CJS build
Here is the source code: https://github.com/Malix-off/VSC-Extension-StashFlow

Awesome. I need to check it for sure 🤩. Will it work also if one of the dependencies I use is already build in esm? As this is actually the problem I'm having

Will it work also if one of the dependencies I use is already build in esm?
As this is actually the problem I'm having

Yes, it's the main point of bundler, fixing the dumbass cjs vs esm fight and optimize code output with minification and circular resolution, and library imports with tree-shaking
There is theoretically no reason vite couldn't fix your problem in one way or another, I believe

this is awesome. I need to do a deep dive on this in the coming weekend.
Thanks @Malix-off for sharing. You Rock 🤩

You're welcome ❤

@Malix-off, it is a great tip, also started using Vite a while ago, but now stepping away from it again as Vite dropped CJS support in v5 and will be completely removed in v6.

More information: https://vitejs.dev/guide/migration.html#deprecate-cjs-node-api

I stumbled on this issue as I had some issues with types that were incorrectly referenced during the build and made the extension fail.
It would be better to look at esbuild or tsup to be future-proof.

Vite dropped CJS support in v5

Nope, they dropped their own CJS Node API, which is not a bad move imho because it would be weird to use a bundle in a non-ESM env
It means that, to use Vite, you need to call it with an ESM syntax, but vite will still be available to output CJS
See https://github.com/Malix-off/VSC-Extension-StashFlow/blob/dev/vite.config.ts as an exemple, the CJS output is a rollupOption.

@estruyf ⬆

related issues and PRs
https://github.com/microsoft/vscode-loader/pull/57
https://github.com/microsoft/vscode-loader/issues/36
https://github.com/microsoft/vscode-loader/issues/56

https://code.visualstudio.com/updates/v1_94#_esm-is-shipping-for-vs-code

Rechecked this topic and still no change on that note. Seems like we could wait for another year to get this 🫤

Yep.
Related issue : https://github.com/microsoft/vscode/issues/130367


Edit Table in Service Explorer blocking UI while retrieving table information

Some actions, like Edit Table should perform the request in a background task, and then show the Edit popup, instead of blocking the UI.

Let's target Jan

This working as expected in the latest build.


[Fix](Top-N opt) evicting quering rowsets in prior to correct use_cou…

…nt
This addresses the scenario where a rowset cannot be removed.
Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


Entrypoint args should be sent over as a list of args, not a string

See the comment here for code information! https://github.com/actions/runner/pull/1853#discussion_r864366705

Closed by this commit


Topic labeling

Currently, the score of each word per cluster is computed like this:
score_{cluster}({word}) = \sum_{cluster-doc} (TF-IDF(word) * distance(centroid, doc))

Where

IDF is based on the entire corpus
distance is the cosine distance between the centroid and the document embedding.

Alternative options to investigate:

TF-IDF based on documents in cluster, instead of entire corpus
different methods for computing distance
assign different weights to TF-IDF and to distance
LLM-generated topic descriptions, as used by Bertopic; also see this Colab notebook
[...]

vectorizer can be fitted on various (sub-)corpora: mark which cluster is has been fitted on; how to keep track for corpora inheriting a vectorizer?
check if the weighted distance makes sense; does the distance out-weigh the TF-IDF?
why are the distances between passages and centroid different from the ones Weaviate computes?

Design idea:

extract a KeywordExtractor class that holds a TfIdfVectorizer and Corpus object
fit(): fit vectorizer to documents in corpus
top_words(corpus) extract top words for corpus, that should be different from KeywordExtractor.corpus
remove Corpus._vectorizer attribute


⚠ Bofrost.de has degraded performance

In 3b2d827, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1170 ms

Resolved: Bofrost.de performance has improved in 2c7e9f0.


[Feature Request] Allow Dimension Stacking to be Set in Config as Default

Hello,
Would you be willing to look into making the dimension stacking option a default setting in the mod config? I'd like to setup a number of dimensions ahead of time for my modpack and currently there exists no way to do that short of looking for a mod to copy data files into the save file.
Thank you!
Darkosto
Minecraft: 1.18.2
Forge: 40.2.0
Immersive Portals: 1.4.13

This has already been requested and is on my todo list.
I've watched some bits from your stream. You should probably read through some wiki pages if you haven't already:

https://qouteall.fun/immptl/wiki/Dimension-Stack.html
https://qouteall.fun/immptl/wiki/Config-Options.html
https://qouteall.fun/immptl/wiki/Miscellaneous.html#can-fluid-redstone-and-light-work-across-a-portal
https://qouteall.fun/immptl/wiki/Implementation-Details.html

If you've any questions I highly suggest you to join the official discord server: https://discord.gg/BZxgURK

Thanks for the response and information @Nick1st
Have a wonderful rest of your day!

The dimension stack preset feature was  added in 1.19.x. And the preset only works on client now (I am going to make it also work in dedicated server).

@Darkosto New version with global Dim Stack Config. Let me know if you find any problems with it.
How to use:

Set the new editDimensionStackConfig option in the main config to true.
Create a new world, open the dimension stack configuration screen and configure a dimensionstack.
Hit Save in the top right corner. (Note: Pressing this button will overwrite the existing saved config.)
This creates a file with the dimensionstack config, that you can also edit manually.
Setting the editDimensionStackConfig option in the main config back to false will hide the save configuration button from that menu again.

Hey @Nick1st
Thanks for putting that update out! I just loaded everything up in a fresh instance and I'm not seeing the config option in a brand new generated config file. I checked the server config files and it's not located there either. I also tried adding the editDimensionStackConfig to the config manually but it was removed after starting up my MC instance. Is the config located elsewhere?

Oh, I named it enableGlobalDimensionStack. Sorry.

My mistake on not seeing the new config option right away. Just got everything setup and saved to the new file. All worlds are loading correctly as stacked with no need to change anything afterwards. Looks good to me 👍
Thank you again for taking the time and putting that together, I appreciate your hard work


Bagging

Is the bagging capability functional? I've run the code with settings.bagging=1 and settings.bagging=0 and I get the same answer both times. So I was wondering if there is a problem with the bagging?

Sorry, the bagging functionality is not supported anymore.
Balaji Lakshminarayanan
PhD student, Gatsby Unit, University College London
http://www.gatsby.ucl.ac.uk/~balaji
On Mon, May 23, 2016 at 10:26 PM, dberma15<EMAIL_ADDRESS>wrote:

Is the bagging capability functional? I've run the code with
settings.bagging=1 and settings.bagging=0 and I get the same answer both
times. So I was wondering if there is a problem with the bagging?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/balajiln/mondrianforest/issues/7

Is there a reason for this? Is there an easy way to re-implement it?

Bagging is necessary to de-correlate the trees only when the other randomization mechanism is not powerful enough. Breiman-RF uses bagging as it searches over all split locations amongst a subset of features whereas Extremely randomized trees (ERTs) randomly choose a split location for a subset of features and only optimize the location. Due to the additional randomization, ERTs do not use bagging (in fact, bagging hurts performance as it uses only 63.2% of unique data points at each tree). For a similar reason, I think bagging is unnecessary for MFs.
The easiest way to re-implement it would be to replace train_ids_current_minibatch with something like  bootstrap(train_ids_current_minibatch) before calling fit and partial_fit.

Thanks for help.
I have another question. I have been changing some of the parameter values such as the discount factor, the budget, store_every, and smooth_hierarchically and the output of the tree remains the same. The number of leaves does not change with with each minibatch and the accuracy  on the test set does not change. Is there a reason for this?

Unless you change n_minibatches or the budget, the tree size shouldn't change; Try increasing the budget gradually from 0 to n_dim --- you should see the tree size change. Discount factor, smooth_hierarchically and store_every only affect the predictions from the tree.
I'll close this issue. Email me if you have any other questions.


Add ability to specify export_library kwargs for autotvm

I tried to run autotvm for custom ARM device recently and found that current autotvm requires edge device to have build tools (gcc, g++, ld) in order to link tar(.o) file to .so file.
It might be a situation when custom ARM devices has minimal linux installation which does not have gcc, g++ and ld tools installed. Also it might be missing package managers like apt.
I found that it is possible to cross compile and export shared object (.so file) for edge device on tracker side using cc parameter in lib.export_library.
This PR replaces default_build_func and android_ndk_build_func identical methods with function   make_build_func returning build_func.
I also updated tune_relay_mobile_gpu.py tutorial to demonstrate the use of make_build_func to generate so file instead of default tar file

I feel it might be more proper to have a new builder, e.g., CrossBuilder. @merrymercy please comment.

You don’t have to pass these argument in. A growing number of args is exactly what we want to prevent from happening here. Instead, you can direct pass in a callable which is a functor that has those options baked in

Maybe we can just create more built-in build_func and register them with proper name.

We can add some of them if they are common. if there is still a lot of things to be configured, my guess is passing in a custom callback will be much cleaner

@tqchen , @kevinthesun, @yzhliu Thank you for your quick feedbacks!
When I look at the existing code second time I found that default_build_func and android_ndk_build_func methods are 99% identical.
I replaced them with DefaultBuilder class which has build_func method and three class parameters:

file_ext="tar"
fcompile=None
**export_library_kwargs

That solutions allows me to replace default_build_func and android_ndk_build_func methods with single DefaultBuilder.build_func method.
Also I added export_library_kwargs class parameter which allows users to specify export_library options. I put the example of how to pass cc option to DefaultBuilder - See tune_relay_mobile_gpu.py tutorial.
Just uploaded the second revision of the PR

Let us stick with the original API and not introducing the new arguments.
So with the existing API, you can already define a function my_cross_build with the extra arguments in and pass that in as build_func directly. The callback function is really powerful and it allows you to define arbitrary ways of compilation.
The reason why we do not want to add new options to the Builder, is that these options only carry a few cases and sometimes users want more. Because build_func can already be functors, they can be customized to contain arbitrary code.
For example, we can just define my_cross_build in users' code and just pass that in as an argument.
def my_cross_build(measure_input, tmp_dir, **kwargs):
    tic = time.time()
    try:
        filename = os.path.join(tmp_dir, "tmp_func_%0x.so" % getrandbits(64))
        func, arg_info = _build_func_common(measure_input, **kwargs)
        func.export_library(filename, cc, **extra_options)
    except Exception as e:
        return BuildResult(None, None, e, time.time() - tic)
    return BuildResult(filename, arg_info, None, time.time() - tic)

If we want to complain that this is still too complicated, then we should do something to make it easier to do clean callback functional specification. Or perhaps create a functor that builds the functions

@tqchen Can you look at my second revision of the PR I posted on Mar 27?
It does not change ANY API.
I just replaced default_build_func and android_ndk_build_func methods with class DefaultBuilder which has single build_func method.

My way is to use_ndk (i.e. build_func='ndk') and set TVM_NDK_CC. Then we use lib.export_library(path, ndk.create_shared). If we have one better wrapper, it also be nice.

@tqchen  I just submitted 3rd revision of the PR

No modifications in any API
No modifications in __init__.py files

This PR just replaces two identical methods default_build_func and android_ndk_build_func with class DefaultBuilder having single method build_func.

OK. You don't really need to have BuildFactory as a class. In python you can return closures, which means you can do things functionally.
def make_build_func(args):
    def my_build_func():
        #   code
    return my_build_func

This being said, we actually can get a better solution to this problem.
What is a better solution
The real reason why we are doing such a level of indirection was really due to the fact that the tvm.cc.create_shared and export_library is a bit poorly designed. The reason that we need another level of indirection here is that we need to know the extension file type and the build_args which is separated by _build_common in the code. We can definitely get it cleaner by somehow suggests the extension type in the build function.
Consider the following code, which is much cleaner
import tvm
from tvm.contrib import cc

def my_build_func(output, objects):
     cc.create_shared(output, objects, cc="myg++", **mykwargs)
# annotate the library output format
my_build_func.lib_format = "so"
builder=autotvm.LocalBuilder(my_build_func)

And we enhance the export_library to support the following case
# notice no suffix here
#  the default lib_format suffix will be attached if hasattr(my_build_func, "lib_format")
# otherwise a ValueError is raised.
lib.export_library("mylib", my_build_func)

Now we can even get rid of the build_common, because we can just take cc.create_shared as the build_func (assuming we also set the right lib_format).
What is even better, we can enhance create_shared to return a partial functor if you do not specify output and objects(this might go a bit far but may worth the effort)
builder=autotvm.LocalBuilder(cc.create_shared(cc="myg++", options=myopts))

@tqchen @merrymercy I replaced class BuildFuncFactory with function make_build_func.
Can you accept this PR as a working solution which allows users to easily switch from tar to so file for autotvm.
I will open new PR for "better solution" code refactoring proposed by Tianqi.

I would prefer us directly to go with the better solution :)

BTW, I find that it is a useful design lessons that can be highlighted through the conversations of this PR. Mainly on

Factory class vs functional style
Reduce abstractions vs adding layers of abstraction

@merrymercy After looking at existing measure_methods.py and cc.py code one more time I think that the refactoring proposed by Tianqi in "better solution" requires autotvm retesting on gpu (OpenCL and CUDA) because _build_func_common which Tianqi suggested to remove deals with check_gpu and cuda_arch parameters.
Another issue is that cc.create_shared automatically determines platform using sys but in case of autotvm the compilation should be done not for tracker platform but for edge device platform.
I think that the change requested  by Tianqi in "better solution" should be done in a separate PR and requires dedicated time to implement it and test.
Given this situation can I ask you to merge this PR in its current state.

It would be great to take a few days to get the better solution out:) while it might take a bit more time, but it is always good to go with the best design we have. New code changes always comes with technical debt and it is important to avoid it.
The reason that we are doing code review and discussion(instead of directly send in another PR) is to find time to improve the design and make everyone learn.

@merrymercy Looks like I addressed all of the comment above except of code refactoring for measure_methods.py. My intention was to share what I did to run autotune for edge device without g++/gcc/ld installed. I think measure_methods.py code refactoring should be done in a separate activity/PR.

I created https://github.com/dmlc/tvm/pull/2927 which implemented the proposed better solution

Let me explain a bit why we don't want to merge the proposed change before the refactor.
New features(use cross-compiler) is always exciting but also brings technical debt(backward compatibility and how the developer is going to use it). Given that the refactored ver is better and will also change the way things are being used. It is better to not introduce the new feature and always aim for the best solution.

@apivovarov please rebase against the master and update the tutorial comments with note and code blocks


Making an AWS Service account

Can't add another account to the organization since it can only have one free tier account at at time. Figuring out a working around. May just need to have a single account that both John and I use.

Current Dev Email<EMAIL_ADDRESS>


Vector indexing error

The plugin shows an error when trying to index into a vector with an int.

@bishan-batel
Thanks for you input. I try to find time to do some stuff here. There are also few other issues. Hopefully soon :)

This should be fixed with release 1.0.7. Looks all good on your side?

It works on my side, thank you!


Cannot connect to the Docker daemon at unix:///var/run/docker.sock.

Hello,
I'm trying to use this image in a gitea act runner as image to build a docker container with. But if I start this image with for example the following command: docker run --rm -it ghcr.io/catthehacker/ubuntu:act-latest, I'm getting this error message, if I run docker ps for example:
Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?
Only if I pass the docker.sock as a volume to the container, I can get a valid result, but I'm not sure if that's what I'm supposed to do.
Could someone tell me what is exactly needed to use docker from inside this image?

I'm pretty sure this is a Gitea act_runner issue, not a problem with the image, but I just fixed this myself. You want to set DOCKER_HOST to unix:///run/user/1000/docker.sock, not unix:///var/run/docker.sock.
Also make sure to comment out the DOCKER_CERT_PATH and DOCKER_TLS_VERIFY if you have those set from the example config, or that'll cause another issue (it seems to try to TLS verify the internal address, then complain when that obviously doesn't work.)

Hello @Jordanb716,
Do you then mean the DOCKER_HOST set on the rootless dind runner itself?

Yes, either that or the docker_host line in the runner config file. (The environment variable seems to override the config file setting, so whichever you're already using I suppose.)

Just realized I was being stupid, your setup is obviously different than mine so my solution won't work for you, sorry about that.

https://shisho.dev/blog/posts/docker-in-docker/


net-mgmt/collectd: Add exec plugin

Example of the relevant bit of UI with these changes:

I don't think this is a good idea as it will be prone to future security issues, more information about the reasons why we shouldn't allow non safe input can be found in our documentation ( https://docs.opnsense.org/development/guidelines/basics.html#safeguard-user-input )

I don't think this is a good idea as it will be prone to future security issues, more information about the reasons why we shouldn't allow non safe input can be found in our documentation ( https://docs.opnsense.org/development/guidelines/basics.html#safeguard-user-input )

Ah, interesting. Yes, I agree that this allows the user to make mistakes ... Would validation of the script existence and having a specific AuthUserField (like the AuthGroupField) be sufficient? From what I can tell, it looks like that would take a fair amount of plumbing, but I'm OK tackling it if it's likely to end up with this approved, and an improved OPNsense ecosystem in the end.
I'd really like to figure out a way to use the functionality of the software that's already on my machine.

FWIW, while arbitrary commands in the config.xml are not desirable we do allow file-based overrides if collectd allows to include configuration files from a directory... so that might be a useful addition if the GUI integration is more difficult than expected.
Cheers,
Franco

FWIW, while arbitrary commands in the config.xml are not desirable we do allow file-based overrides if collectd allows to include configuration files from a directory... so that might be a useful addition if the GUI integration is more difficult than expected.

Ah good idea. Collectd's config language does allow file and whole directory includes, so I think that would be a nice thing to have.

@fichtner Could you point me at another plugin/service which does something like this? The closest I can find is haproxy, which allows Lua script content in the config -- is that the sort of thing that you are suggesting? ie, should the UI allow adding config snippets, or should the UI just have a checkbox for something like "Include config in directory /bla/bla", or should the UI allow the user to specify a file path to include?

I'd prefer a directory to include, should be easy

Closing for now. I won't be able to get to changing to an include for a little bit and I don't want to leave this dangling unnecessarily. I'll open a new PR for the different functionality when I've built it.

Sorry for late reply. It's been a bit difficult time-wise lately. A simple example is https://github.com/opnsense/core/commit/daddecfb4f4e4c50d16
Should be a quick addition.
Cheers,
Franco


Query Equatable/Comparable Conformances to Build Typed Derived ASTs

This resolves a case of a semantic ambiguity dredged up in rdar://86780149. The problem there is a library author exported a retroactive conformance of a type to Equatable. That type then gained an Equatable conformance in its originating module, and all clients downstream of them broke. In the Equatable synthesis code, it broke a very particular way where we'd assemble a UDRE that the expression checker wouldn't actually be able to resolve to a singular decl. Because this was implicit AST, it also didn't consider that error a strong enough condition to not make it to codegen.
We already made sure the Equatable/Comparable conformance for the members/payloads of the types entering synthesis were valid. Just use those to construct well-typed AST instead of relying on the expression checker.

@swift-ci test

@swift-ci test source compatibility

Build failed
Swift Test OS X Platform
Git Sha - a64c88df1be400ada99a1444ba5aece63f7d70d8

Build failed
Swift Test Linux Platform
Git Sha - a64c88df1be400ada99a1444ba5aece63f7d70d8


Hybrid Planning

Description
Here is a PR for the hybrid planner.  I plan on doing the work to clean this up so it can be merged.
Here is the original hybrid planner PR: https://github.com/ros-planning/moveit2/pull/488
Checklist

[x] Required by CI: Code is auto formatted using clang-format
[ ] Extend the tutorials / documentation reference
[ ] Document API changes relevant to the user in the MIGRATION.md notes
[ ] Create tests, which fail without this PR reference
[ ] Include a screenshot if changing a GUI
[ ] While waiting for someone to review your request, please help review another open pull request to support the maintainers

I am really confused as to how this would affect the servo tests in any way.  None of the servo PRs seem to be failing but this one is.

@tylerjw Thanks for taking over! In the previous PR, I've marked the things I've addressed in #718 with ":thumbsup:". I don't know why the servo tests are failing, this is really weird.

I am having the following issues with this branch:

Multiple consecutive requests are not possible. In single_plan_execution.cpp the call_once of the local planner ensures that the local planner is only executed once. However, this is not reset when the local planner was successful. Replacing the std::once_flag with a Boolean and resetting after stopping the local planner seems to solve this. However I'm not sure this is thread safe.
When the global planner does not find a solution (Not possible or collision after smoothing) this crashes the Hybrid Planner Component container. In other words: if the initial path is not possible, it will not try again, or return that this path is not possible, but the hybrid container will stop.
It is not possible to pass a ompl_planning.yaml file to change the ompl planning parameters for the global planning.
The following parameters in the MotionPlanRequest are ignored:

max_velocity_scaling_factor
max_acceleration_scaling_factor
max_cartesian_speed
workspace_parameters.*
start_state.*

I find this branch  has broken the demo. One of the reasons, at least, is that the trajectory controller does not come up:
[component_container_mt-1] [WARN] [1637178427.024121523] [moveit.simple_controller_manager.gripper_controller_handle]: Waiting for panda_hand_controller/gripper_cmd to come up
[component_container_mt-1] [ERROR] [1637178427.024137421] [moveit.simple_controller_manager.gripper_controller_handle]: Action client not connected: panda_hand_controller/gripper_cmd

I am having the following issues with this branch:

Multiple consecutive requests are not possible. In single_plan_execution.cpp the call_once of the local planner ensures that the local planner is only executed once. However, this is not reset when the local planner was successful. Replacing the std::once_flag with a Boolean and resetting after stopping the local planner seems to solve this. However I'm not sure this is thread safe.

When the global planner does not find a solution (Not possible or collision after smoothing) this crashes the Hybrid Planner Component container. In other words: if the initial path is not possible, it will not try again, or return that this path is not possible, but the hybrid container will stop.

It is not possible to pass a ompl_planning.yaml file to change the ompl planning parameters for the global planning.

The following parameters in the MotionPlanRequest are ignored:

max_velocity_scaling_factor
max_acceleration_scaling_factor
max_cartesian_speed
workspace_parameters.*
start_state.*

@JensVanhooydonck  Hello, right now I also try to use hybrid planning. Passing ompl_planning.yaml and modify max_velocity_scaling_factor do not work as you described. Have you figure out how to fix it? Any advice will be highly appreciated. Thanks!

I am having the following issues with this branch:

Multiple consecutive requests are not possible. In single_plan_execution.cpp the call_once of the local planner ensures that the local planner is only executed once. However, this is not reset when the local planner was successful. Replacing the std::once_flag with a Boolean and resetting after stopping the local planner seems to solve this. However I'm not sure this is thread safe.

When the global planner does not find a solution (Not possible or collision after smoothing) this crashes the Hybrid Planner Component container. In other words: if the initial path is not possible, it will not try again, or return that this path is not possible, but the hybrid container will stop.

It is not possible to pass a ompl_planning.yaml file to change the ompl planning parameters for the global planning.

The following parameters in the MotionPlanRequest are ignored:

max_velocity_scaling_factor
max_acceleration_scaling_factor
max_cartesian_speed
workspace_parameters.*
start_state.*

@JensVanhooydonck Hello, right now I also try to use hybrid planning. Passing ompl_planning.yaml and modify max_velocity_scaling_factor do not work as you described. Have you figure out how to fix it? Any advice will be highly appreciated. Thanks!

I didn't try this in the last year.. I don't know what the status is currently..

@JensVanhooydonck  Thanks for reply! I will try to find a solution.


Add api endpoints

Hi there! We are sending this pull request for you to review our code. Thanks in advance for your feedback!Milestones 🎯:📌 Work on Pair Programming📌 Create an API endpoint to list all posts for a user.📌 Create an API endpoint to list all comments for a user's post.📌 Create an API endpoint to add a comment to a post.📌 Ensure API posts JSON & GETS JSON as well
🎖 General requirements:GitflowNo linter errorsEnsure the use of best practices and Ruby style

thanks for your time


Small fix for subfolder proxying, Documentation, small fix for build process hangs

I had the issue that the build from master was hanging up on "flask assets build"
I switched the the filter to rcssmin, cssmin is only available in 0.2.0 in pip which is stone age old.
rcssmin was added to the requirements, build works fine.
I documented how to set up an apache reverse proxy with subfolder using the SCRIPT_PATH environment variable.
There was a small error in powerdnsadmin/templates/admin_history.html using static urls instead of url_for

@ckbaker10 the build process doesn't hang but just takes a really long time currently. Does your replacement notably speed that up?

@AzorianMatt I left it running for about 10 minutes and then canceled, with rcssmin the flask assets build process ends within a few seconds.

@ckbaker10 great to hear about such an improvement. I'll test as soon as I can later this week and look at getting that merged in. The current process was taken between 10 to 15 minutes on average for me.

@ckbaker10 This has been tweaked and merged into the newly created "dev" branch which will hold on-going pre-release dev updates.


vsr: DVC header is blank and journal has valid header from old wrap

Fixes ./zig/zig build -Drelease -Dvopr-log=full vopr -- --ticks-max-requests=3000000<PHONE_NUMBER>021648557 on the matklad/c2 branch (4ee9445f69a4eaf976e795a3d8f4c1214d05fc57). There is no failing seed on main yet but main is vulnerable to this issue as well.
This is a regression due to https://github.com/tigerbeetle/tigerbeetle/pull/2385. While https://github.com/tigerbeetle/tigerbeetle/pull/2385 correctly solves a safety issue, it misses out on correctly handling  a blank DVC header from the current wrap with a valid journal header from an old wrap. We must nack such headers as the op from the current wrap is guaranteed to not exist in the journal.
This is fixed by using header_for_op → header_with_op while populating the nack & present bitsets in send_do_view_change. While both these functions fetch a valid header from the slot where an op resides, there exists a subtle difference between the two:

header_for_op:  valid header could be from an old wrap
header_with_op: valid header corresponds to the specified op

Using header_with_op, nacking a blank DVC header from the current wrap with a valid journal header from an old wrap is handled by the following pre-existing condition:
https://github.com/tigerbeetle/tigerbeetle/blob/ed0a1c73a24b2caa9fbcecf54b52dfbb27ded83d/src/vsr/replica.zig#L7463-L7466

Let's also add a replica test for the case that is fixed by https://github.com/tigerbeetle/tigerbeetle/pull/2385!

@matklad: Bumping this in case you missed seeing it, I have added the replica test for the case fixed by https://github.com/tigerbeetle/tigerbeetle/pull/2385 in https://github.com/tigerbeetle/tigerbeetle/pull/2399/commits/1a6024703708279f5379f037dc9f9f241eaf9589! 😄

Yeah, I am reviewing this right now actually, sorry for the delay!

@matklad Alas, buggy core_missing_prepare strikes back in ./zig/zig build -Drelease vopr --<PHONE_NUMBER>7547372328!
Here, op=123 is missing on the R0 and R1, but core_missing_prepare isn't able to correctly detect that. The reason for that is that there is also a missing header op=105 on R0, but that header is present on R1.
[debug] (simulator): 0: commit_min=79, commit_max=106
[debug] (simulator): 0: found missing header op=105
[debug] (simulator): 1: commit_min=122, commit_max=123
[debug] (simulator): 1: checking prepare op=123
[debug] (simulator): 1: found dirty/fault prepare op=123, current missing prepare op=null
[info] (cluster): no liveness, final cluster state (core=11100011):
[info] (cluster):  0   \ v         9356V  79/_79/102C  71:106Jo  0/_0J!  71:106Wo <__0:__0> v1:2    39Ga  0G!   0G?
[info] (cluster):  1   \  v        9356V 119/122/123C  92:123Jo  1/_1J!  92:123Wo <__0:__0> v2:2    39Ga  0G!   0G?

In other words, we incorrectly assume that if a header is missing, it must be the root cause for the cluster being stuck. However, as we observed above, we could have it so that a header and a prepare are missing, but the cluster is actually stuck because of the prepare, not the header (in the above case, R0 was lagging and waiting to state sync). So perhaps, instead of giving preference to header over the prepare, we should check both for whether they're missing? 🤔
https://github.com/tigerbeetle/tigerbeetle/blob/ed0a1c73a24b2caa9fbcecf54b52dfbb27ded83d/src/vopr.zig#L717-L720

Found a seed on main as well, for the symptom described in https://github.com/tigerbeetle/tigerbeetle/pull/2399#issuecomment-2407528193:
./zig/zig build -Drelease vopr --<PHONE_NUMBER>2659963795

I think it's safe to say that we should be landing this then!

Here, op=123 is missing on R0 and R1, but core_missing_prepare isn't able to correctly detect that. The reason for that is that there is also a missing header op=105 on R0, but that header is present on R1.

Ah, I think the original assumption there was that you should be able to repair the header in this case, but this seems to be not true: to repair headers, you need to be in .normal state, and that's exactly what we can't do here.
So, yeah, checking for either prepare or header missing feels right here.


[WIP] Making AssertQuery fully typed

This can be done if all type arguments are inferred - we can achieve this by adding a mock argument that specifies entity sets that should be used in the query.
this is extremely WIP, will rename, format and cleanup the nits later, i'm interested in critiques of the design.

@maumar - Is this still relevant?


Query Params Broken

BEFORE SUBMITTING AN ISSUE CHECK THE FOLLOWING:

[x] I checked existing issues.
[x] This is not a support question (which can be answered on Slack).
[x] This issue is on the web client (not API, Lambda, or Bots)

ISSUE DESCRIPTION
- What version of the project are you using?
1.0.0-alpha1
- What browser and its version are you using?
Chrome
- What did you do? (Steps to Replicate Issue)
Query params are not being properly parsed by secretary
- What did you expect to see?
Query param parsing
- What did you see instead?
- More details?
https://github.com/gf3/secretary/issues/63
We may need to migrate from pushy to googles html pushstate to get this working.
This is causing pattern matching to not work in the router which will cause problems with pagination as well.

This needs to go into alpha-2, updating milestone.


Had to downgrade from 1.14 to restore JSX intellisense

Intellisense broke in React .jsx/.js files in v1.14 for me (not Typescript).  Downgrading back to v1.13.1 resolved it.

Open a .js file with JSX in it.  Fiddle with Language Mode but nothing works to give Intellisense.  No dice with .jsx files either.

Interesting. I'm having the issue for TypeScript.

Can you try:

Set "typescript.tsserver.trace": "verbose"
Reproduce the issue
Check the TypeScript section of the output window.

Look for error messages in this window when you trigger a completion. You can also paste up the output and I can take a look.

Anyone getting this similar error message on OUTPUT tab when TypeScript is selected.

VERSION :
1.15.0-insider (1.15.0-insider)
7bb3b89031cbce46536ba870868d889d639e12f1
2017-07-11T17:41:53.024Z
[Error  - 2:32:58 AM] 'definition' request failed with error.
Error processing request. Project '/Users/<username>/<path>/<to>/<project>/jsconfig.json' does not contain document<EMAIL_ADDRESS>Error: Project '/Users/<username>/<path>/<to>/<project>/jsconfig.json' does not contain document<EMAIL_ADDRESS>    at Object.ThrowProjectDoesNotContainDocument (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js:75718:23)
    at ConfiguredProject.Project.getScriptInfoForNormalizedPath (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js:77238:42)
    at ConfiguredProject.Project.getScriptInfo (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js:77243:29)
    at ModuleBuilder.AbstractBuilder.getOrCreateFileInfo (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js:76551:51)
    at /Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js:76679:84
    at Object.map (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js:1483:29)
    at ModuleBuilder.getReferencedFileInfos (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js:76679:31)
    at ModuleBuilder.updateFileReferences (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js:76708:42)
    at ModuleBuilder.ensureProjectDependencyGraphUpToDate (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js:76693:30)
    at ModuleBuilder.onProjectUpdateGraph (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js:76684:22)
    at ConfiguredProject.Project.updateGraph (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js:77177:34)

Sorry @mjbvz I didn't read the issue carefully. I am however getting less syntax highlighting than I used to in TypeScript.

@drew-wallace Can you please file a seperate issue with screenshots and sorce code so that I can investigate. Thanks

For anyone running into issues with the VSCode 1.14: You probably don't need to downgrade VSCode, just the TypeScript version. Here are the instructions on that. We previously shipped with TS 2.3.4 so you'll want to try installing that version locally and using it in your workspace

@revathskumar Can you share your jsconfig.json?

@mjbvz My jsconfig.json
{
	"compilerOptions": {
		"target": "ES6",
		"module": "commonjs"
	}
}

Hi all,
My jsconfig.json:
{
"compilerOptions": {
"experimentalDecorators": true
}
}
And I also have the following in my user settings:
"files.associations": {
"*.jsx": "javascript"
}
I'm writing ES6 .js and .jsx files (not explicitly using TS).  I had
absolutely no Intellisense in my JS files after upgrading, then downgrading
resolved it.  I didn't check if the culprit was the VSCode version or TS
version.  I apologize but I don't have time right now to go back to 1.14 to
provide the typescript tsserver trace, but if you really need it let me
know and I'll find the time.
-Nadeem
On Wed, Jul 12, 2017 at 3:11 AM Revath S Kumar<EMAIL_ADDRESS>wrote:

@mjbvz https://github.com/mjbvz My jsconfig.json
{
"compilerOptions": {
"target": "ES6",
"module": "commonjs"
}
}
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/vscode/issues/30425#issuecomment-314676069,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABmlcBvhljAw48YFhpAHdid5qEWS87xUks5sNHGsgaJpZM4OUxxW
.

I'm experiencing this too :(

I believe this may be caused by https://github.com/Microsoft/TypeScript/issues/17131
@nmitha or @dearsaturn Can you please try:

Set "typescript.tsserver.trace": "verbose" in your user settings
Restart vscode and open a file that should have intellisense but does not
Open the output pane in VSCode
Look for Error processing request. messages in the TypeScript section of the output pane

@mjbvz Strangely, updating again brought my intellisense back? Maybe I hadn't waited long enough for results to come in before. I'm sorry.

@mjbvz Thanks for the tip. I installed TS 2.3.4 and set "typescript.tsdk" setting to it. Then i got back my JS intellisense.
Looks like built in tsc on v1.14.0 is the culprit.

Same problem here. Intellisense in my typescript project stopped working since upgrading to 1.14. Downgrading to 1.13 solved the problem.

Possibly related, the following JavaScript does not syntax highlight correctly in v1.14:
{
    'd': '(';
}
var foo;

var foo; will be highlighted incorrectly

Deleting jsconfig.json also fixes this issue.
Having the same problem, my jsconfig.json looks like this.
{
  "compilerOptions": {
    "target": "es6",
    "baseUrl": "./",
    "paths": {
      "@/*": ["./src/*"]
    }
  },
  "exclude": ["node_modules"]
}

it works fine if you delete the jsconfig.json file. I'm acquiring type from @types/jest
error looks like this: jsconfig.json' does not contain document
[Info  - 2:50:42 PM] Using tsserver from: /Applications/Visual Studio Code.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js
[Info  - 2:50:42 PM] Forking TSServer
PATH: /usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin
[Error  - 2:55:22 PM] 'completions' request failed with error.
Error processing request. Project '/Users/serkanyersen/playground/test-unittests/jsconfig.json' does not contain document<EMAIL_ADDRESS>Error: Project '/Users/serkanyersen/playground/test-unittests/jsconfig.json' does not contain document<EMAIL_ADDRESS>    at Object.ThrowProjectDoesNotContainDocument (/Applications/Visual Studio Code.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js:75718:23)
    at ConfiguredProject.Project.getScriptInfoForNormalizedPath (/Applications/Visual Studio Code.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js:77238:42)
    at ConfiguredProject.Project.getScriptInfo (/Applications/Visual Studio Code.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js:77243:29)
    at ModuleBuilder.AbstractBuilder.getOrCreateFileInfo (/Applications/Visual Studio Code.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js:76551:51)
    at /Applications/Visual Studio Code.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js:76679:84
    at Object.map (/Applications/Visual Studio Code.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js:1483:29)
    at ModuleBuilder.getReferencedFileInfos (/Applications/Visual Studio Code.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js:76679:31)
    at ModuleBuilder.updateFileReferences (/Applications/Visual Studio Code.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js:76708:42)
    at ModuleBuilder.ensureProjectDependencyGraphUpToDate (/Applications/Visual Studio Code.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js:76693:30)
    at ModuleBuilder.onProjectUpdateGraph (/Applications/Visual Studio Code.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js:76684:22)

Same issue here, I think
This is my error log. Not using TS, just JSX with vscode 1.14. Didn't happen before. I also noticed that if I close and open the editor, it starts and it works for a few seconds and then it stops working and gives the error below.
[Error  - 10:56:45 PM] 'completions' request failed with error.
Error processing request. Project '/<project>/jsconfig.json' does not contain document
<EMAIL_ADDRESS>

OK disabling automatic type acquisition by adding this did the trick as mentioned here   #30122
"typeAcquisition": {
    "enable": false
  },

I have a similar problem in #30122 when installing with yarn but not when installing with npm
Can anyone try to remove the entire node_modules folder and try with npm and see if the problem is still present?

To verify the fix, test the steps listed in this issue https://github.com/Microsoft/TypeScript/issues/17131


Bump to github.com/containers/common to v0.9.2

This allows us to fix issues with people with old libpod.conf
Signed-off-by: Daniel J Walsh<EMAIL_ADDRESS>

@mheon PTAL

Once this merges, we can cherry pick it for v1.9.0

LGTM

/lgtm


Support for installing scrcpy from macOS12 using brew

steven@lesetonglijiandeMacBook-Pro  /usr/local  brew install scrcpy
Updating Homebrew...
^CWarning: You are using macOS 12.
We do not provide support for this pre-release version.
You will encounter build failures with some formulae.
Please create pull requests instead of asking for help on Homebrew's GitHub,
Twitter or any other official channels. You are responsible for resolving
any issues you experience while you are running this
pre-release version.
Error: scrcpy: no bottle available!
You can try to install from source with:
brew install --build-from-source scrcpy
Please note building from source is unsupported. You will encounter build
failures with some formulae. If you experience any issues please create pull
requests instead of asking for help on Homebrew's GitHub, Twitter or any other
official channels.

Please ask/report to Homebrew, this is a homebrew issue.

Warning: You are using macOS 12.
We do not provide support for this pre-release version.

Or try updating your homebrew first.


chore: JS icon update

Description

This PR updates the JS Icon to the new yellow colored one.

PR fixes following issue(s)
Fixes #24093
Media

A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video

Type of change

Please delete options that are not relevant.

Chore

Testing

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration.
Delete anything that is not relevant

[x] Manual
[ ] JUnit
[ ] Jest
[ ] Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:
Dev activity

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[ ] PR is being merged under a feature flag

QA activity:

[ ] Speedbreak features have been covered
[ ] Test plan covers all impacted features and areas of interest
[ ] Test plan has been peer reviewed by project stakeholders and other QA members
[ ] Manually tested functionality on DP
[ ] We had an implementation alignment call with stakeholders post QA Round 2
[ ] Cypress test cases have been added and approved by SDET/manual QA
[ ] Added Test Plan Approved label after Cypress tests were reviewed
[ ] Added Test Plan Approved label after JUnit tests were reviewed

/ok-to-test

/ok-to-test

/ok-to-test

/ok-to-test


Config Validator not scaling to large datasets

In profiling large CAI exports with a dataset with 2M resources we are finding that the virtual machine is running out of memory.
Next Steps:

[x] Prep for new RPC endpoint https://github.com/forseti-security/config-validator/pull/60
[ ] Create new RPC endpoint in Config Validator (without referential support)

[ ] Enable mult-threading of Config Validator auditing

[ ] Forseti / Config Validator teams profile performance of new RPC end point with multi-threading

Assigning to @morgante who offered to do some initial investigations around memory the consumption with a large data set.

I did some preliminary analysis. The problem seems to be in OPA/Rego itself: https://docs.google.com/document/d/1AV23q8YqjSwaVv3FqXkzH7m7kInjyxWE3Xk2WH6xCWo/edit

@briantkennedy based on @morgante findings what is the right next step here regarding this issue?

@briantkennedy I wanted to document high level tasks related to this effort please review and edit.

[ ] Prep for new RPC endpoint https://github.com/forseti-security/config-validator/pull/60
[ ] Create new RPC endpoint in Config Validator (without referential support)

[ ] Enable mult-threading of Config Validator auditing

[ ] Forseti / Config Validator teams profile performance of new RPC end point with multi-threading

yeah, that looks roughly like the path, although the PRs aren't necessarily going to map 1:1 there, we can edit as we go

@briantkennedy I will move the tasks to the first edit on this issue. We can update there as needed. Thanks.

I believe this has been closed out.  Feel free to reopen if there's more work to do.

@katze120 Have we still been seeing issues with using CFT Scorecard against large CAI dumps?

I have some performance data here for running scorecard on macbook pro. I tried on CAI of 2G too, no out-of-memory issue but I terminated the process after 2+ hrs.

CAI file size
# of Projects
# of lines in CAI exports
Time to complete

17M
50
11567
4 mins

30M
67
15508
6 mins

200M
39047
247126
110 mins

Very often, large CAI size is caused by BQ tables. For now I'd recommend to exclude BQ tables from CAI file before running scorecard, unless there is any constraint for BQ table being used, which is rare.

If there's a CAI dump and set of constraints you're able to give me, please reopen and I can take a last look at improving the single host performance, but other than that we are at the end of the road in terms of the single host performance story.


APM: add probabilistic sampling rate to span when kept

What does this PR do?
Adds _dd.prob_sr to spans that have been kept by the probabilistic sampler with the sampling rate. (ie. 0.40 is 40% kept)

Motivation
We use these sampling rates to help drive metrics to show the source and volume of spans

Additional Notes

Possible Drawbacks / Trade-offs
Technically speaking this shouldn't be strictly necessary since the probabilistic sampling rate should be consistent across the whole trace to ensure a fully connected trace, but in actuality it's possible due to mis-configurations and having the data here on the span is much more consistent with the other sampling approaches.

Describe how to test/QA your changes
I updated the unit tests to check that this metric is properly set

/merge


⚠ Bofrost.be has degraded performance

In 40905ba, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1705 ms

Resolved: Bofrost.be performance has improved in 1d574ca after 8 minutes.


Remove link translation

This pull request remove the ability to translate links. The links are now hardcoded into the footer.

@leo Here is the pull request you asked for. One note: the current German translations seem very incomplete, it might be good to only accept languages once they are complete to avoid confusion.

@GjjvdBurg Thanks, but it's my own one. Thankfully, all non-translated pages simply show the english content :blush: But you're right, we'll only accept finished ones in the future.

@leo Sounds good!


[Utils] Skip generating benchmark scripts in cases

This PR skips generating benchmark scripts when the NotImplementedError thrown by
https://github.com/apache/tvm/blob/unity/python/tvm/dlight/benchmark/extract.py#L138 is hit.

cc @zxybazh

Hi thanks for the fix! Is there any specific case that the not implemented error would be thrown? I think it should be fixed in https://github.com/apache/tvm/pull/15538 if you're referring to similar cases as in https://github.com/mlc-ai/mlc-llm/issues/742


Allow EarlyStopping to be reused between multiple fits.

All values were already reset properly in on_train_begin except best.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 60.03%. Comparing base (a93828a) to head (e443bd4).

:exclamation:  There is a different number of reports uploaded between BASE (a93828a) and HEAD (e443bd4). Click for more details.
HEAD has 6 uploads less than BASE

Flag
BASE (a93828a)
HEAD (e443bd4)

keras
4
1

keras-torch
1
0

keras-tensorflow
1
0

keras-jax
1
0

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #20533       +/-   ##
===========================================
- Coverage   82.11%   60.03%   -22.09%
===========================================
  Files         515      515
  Lines       47806    47808        +2
  Branches     7490     7491        +1
===========================================
- Hits        39258    28702    -10556
- Misses       6736    17350    +10614
+ Partials     1812     1756       -56

Flag
Coverage Δ

keras
60.03% <100.00%> (-21.94%)
:arrow_down:

keras-jax
?

keras-numpy
60.03% <100.00%> (-0.01%)
:arrow_down:

keras-tensorflow
?

keras-torch
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests


Denis : Add day 1

@troisdiz the CI was broken for go and was fixed in a recent commit 😬  do you mind rebasing from master or merging master into your branch?


bug: hostmetrics receiver generating excessive log spam

Currently, the hostmetrics receiver generates a lot of log spam because of a permissions issue preventing the collector from accessing the path of a process owned by another user. An upstream bug has been reported at:

https://github.com/open-telemetry/opentelemetry-collector/issues/3004

This has been marked as non-harmful log spam which is technically true, but is making logs very hard to use since these messages constitute a majority of my logs. I was wondering if it would be possible to set a filter for these types of logs at source? I am currently filtering out all logs from the opentelemetry agent to make my logs usable. This isn't ideal but feels like the best option until it can be addressed upstream.
I think it would be great this could be added to the Fluentbit config or if it would be possible to specify exclude filters for logs through configuration.
[FILTER]
    name    grep
    match    *
    exclude msg otelopscol

Since there isn't an easy way to specify the above filter as a configuration option, I'm manually adding the following filter to my rsyslog configuration.
/etc/rsyslog.d/99-exclude-otel.conf:
if ($programname contains "otelopscol") then {
   action(type="omfile" file="/var/log/dropped-msgs.log")
   stop
}

For anyone who build ops-agent manually (or running Arch), here is [1] the patch to minimize this logging spam.
diff --git a/apps/hostmetrics.go b/apps/hostmetrics.go
index 84bdc49..14a77f7 100644
--- a/apps/hostmetrics.go
+++ b/apps/hostmetrics.go
@@ -43,8 +43,6 @@ func (r MetricsReceiverHostmetrics) Pipelines() []otel.Pipeline {
 					"filesystem": struct{}{},
 					"network":    struct{}{},
 					"paging":     struct{}{},
-					"process":    struct{}{},
-					"processes":  struct{}{},
 				},
 			},
 		},
diff --git a/confgenerator/confgenerator.go b/confgenerator/confgenerator.go
index 1916bcd..a8443ec 100644
--- a/confgenerator/confgenerator.go
+++ b/confgenerator/confgenerator.go
@@ -47,7 +47,7 @@ func (uc *UnifiedConfig) GenerateOtelConfig(hostInfo *host.InfoStat) (string, er
 	}.Pipeline()

 	if uc.Metrics.Service.LogLevel == "" {
-		uc.Metrics.Service.LogLevel = "info"
+		uc.Metrics.Service.LogLevel = "error"
 	}
 	otelConfig, err := otel.ModularConfig{
 		LogLevel:  uc.Metrics.Service.LogLevel,
@@ -126,7 +126,7 @@ func (uc *UnifiedConfig) GenerateFluentBitConfigs(logsDir string, stateDir strin
 func (l *Logging) generateFluentbitComponents(userAgent string, hostInfo *host.InfoStat) ([]fluentbit.Component, error) {
 	var out []fluentbit.Component
 	if l.Service.LogLevel == "" {
-		l.Service.LogLevel = "info"
+		l.Service.LogLevel = "error"
 	}
 	out = append(out, fluentbit.Service{LogLevel: l.Service.LogLevel}.Component())

Its very annoying.
[1] https://aur.archlinux.org/cgit/aur.git/tree/0001-apps-hostmetrics.patch?h=google-cloud-ops-agent-git

Seems like they patched it in this PR
Is it possible to bump the opentelemetry-collector-contrib version?

The problem outlined in this issue should be fixed in Ops Agent 2.10 and above. There can be scenarios where similar log spam from hostmetrics can occur, but it won't be occurring by default with processes that it shouldn't be trying to read in the first place.
If you encounter something similar to this issue in a new version of the Ops Agent, please open a new issue that we can triage separately.


Component: Content Switcher (Segmented Controll)

https://www.figma.com/file/xZ0IW0MJO0vnFicmrHiKaY/Components-Post?type=design&node-id=10129%3A53612&t=5mzQjs4il43FOfTt-1

same question here @rouvenpost do you think we can change this pattern?

any accessibility concerns here @Cian77 ?

@rouvenpost: Hier muss noch der AX-Check gemacht werden.

[ ] check design (accessibility and visual)
[ ] fix height (8px grid)

Closing as duplicate of #2633


glueckkanja.KONNEKT version 2.9.1

Checklist for Pull Requests

[x] Have you signed the Contributor License Agreement?
[ ] Is there a linked Issue?

Manifests

[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[x] Have you validated your manifest locally with winget validate --manifest <path>?

[x] Does your manifest conform to the 1.6 schema?

Note: <path> is the directory's name containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

Verify:

This application has minimal UI elements, and is always-on-top.


Fix a typo and some formatting in the readme

Description
This change fixes a typo as some formatting in the readme:

fix desginer -> designer
fix indentation of code blocks
pull the explainer text out of the code block
switch to json5 syntax to stop comments appearing as errors

Type of change
Documentation change
How Has This Been Tested?
N/A
Checklist:

[ ] My changes do not introduce any new linting errors
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation and versioning
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] I have rebased onto master and there are no code conflicts
[ ] I have checked deployments are working in all environments
[ ] I have updated the architecture diagrams as per Contribute.md

I don't think most of this applies, but please let me know if I'm wrong.

Hi @erbridge, thanks for the PR! We don't have CI set up properly for forks :(.. and not enough hours in the day to fix it 😅. Seeing as we're getting outside contributors I'll try to get this prioritised.
In the mean time, if I create a branch, would you mind opening your PR against that instead? it's here: origin/patch/readme
If you're thinking of contributing more soon, I'm happy to add you as a maintainer.

Hi @erbridge, thanks for the PR! We don't have CI set up properly for forks :(.. and not enough hours in the day to fix it 😅. Seeing as we're getting outside contributors I'll try to get this prioritised.
In the mean time, if I create a branch, would you mind opening your PR against that instead? it's here: origin/patch/readme
If you're thinking of contributing more soon, I'm happy to add you as a maintainer.

That's all merged in now F. Thanks!

That's all merged in now F. Thanks!


ART-3095 Flaw bugs with no additional trackers are considered first fixes

In my last PR we fixed the issue of not failing
but the function return value wasn't accurate.
If additional trackers are not found for the flaw bug
then the flaw bug IS considered a first fix.
relevant slack thread

Codecov Report

Merging #211 (5618d81) into master (2c7c9b4) will increase coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #211      +/-   ##
==========================================
+ Coverage   28.05%   28.06%   +0.01%
==========================================
  Files          47       47
  Lines        4442     4440       -2
  Branches      951      951
==========================================
  Hits         1246     1246
+ Misses       3125     3123       -2
  Partials       71       71

Impacted Files
Coverage Δ

elliottlib/attach_cve_flaws.py
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c7c9b4...5618d81. Read the comment docs.

@thegreyd The first fix check needs to checking if it is a first fix for the given componnent (i.e. rpm or container). I vaguely recall another item for this in the ART backlog, but not sure it was completed yet.

@sfowl I vaguely remember the component name check is already done when elliott attaches trackers. So this LGTM but I could be wrong.

Thanks Sam, here's the story https://issues.redhat.com/browse/ART-2725
Since this PR is fixing a regression (that went in with an earlier PR in the description), I'd like to merge this,
and get the other story in with another PR.


fix(typeahead): Typeahead uses ngSanitize when present

Hey there!
This pull request addresses the issue #2884 which mentions the use of the attribute of bind-html-unsafe attribute in the default template/typeahead/typeahead-match.html.
So basically, I changed a little the testing process, considering what @chrisirhc said about the fix, here's the implemented solution:

Added the angular-sanitize.js dependency to the misc/test-lib/ folder (the angular-sanitize.js is the same version as the angular.js included).
Changed the karma.conf.js file to add this dependency.
Added a line in the demo file to ship it with the dist folder.
Changed the typeaheadHilghlight filter:

Checks if $sanitize is available to use, if not then a warning is printed to the console using the $log service, this will happen when the filer is requested by angular. The ngSanitize can be imported as part of the module that's using the typeahead directive. The reason of why the ngSanitize module is not imported directly on the ui.bootstrap.typeahead module is because it will add another dependency to the project, needless to say it will not work if not present.
When $sanitize is present it will use it to sanitize the string itself if it contains any sequence of < followed by any combination of chars, and an ending >, if not, then the string is wrapped in an object that ng-bind-html need to be displayed with the $sce.trustAsHtml method.
And finally the <strong> tags are added to the matched characters.

On the file src/typeahead/test/typeahead-highlight.spec.js the returned value of the filter need to be unwrapped.
Created another spec file (src/typeahead/test/typeahead-highlight-ngsanitize.spec.js) that will include the ngSanitize module and test that tags and attributes are being escaped.

And that's it, I think that's all.
I'm looking forward to your feedback and comments. Thanks!

Did a review. Good work here. Also, PR needs rebasing.

Hi @chrisirhc
Thanks for your feedback, I polished the code according to your comments. I already pushed the commit.

Can't be merged at present

@karianna I'm sorry, I'm kind of new to this, can I or should I do something about that?

@fernando-sendMail you'll need to rebase, e.g. do a git pull angular-ui/bootstrap master (I'm assuming you've aliased the angular-ui bootstrap remote), resolve any conflicts and git push into your remote branch again.

@karianna Thanks for the info!

Thanks @fernando-sendMail for your work on this, I did some further review.

Also note, should remove dependency on ui.bootstrap.bindHtml module as it's no longer used after this change ( :+1: hooray!)

@chrisirhc Thanks for the review, I'll be working on this over the week.

Hey @chrisirhc I committed the latest stuff with the fixes and modifications to the test.

Took another look. I saw that you updated package.json but the angular-sanitize.js is still in your PR and karma.conf.js hasn't been updated to use the angular-sanitize.js from node_modules.

Hey @chrisirhc I think it's more convenient to name it isSanitizePresent given the use it has in this context.
I made a commit with the other changes that you noticed.

Looks good to me. I'm scheduling this for 0.13.1 because we already have a lot of changes in 0.13.0 .

Hey @chrisirhc It's been a while since I committed this.
Do I need to do something else?

This just needs to be rebased off of current master I believe - this LGTM, lot of good work here.

Hey @wesleycho I'm having some trouble rebasing, I'm running:
git rebase master
and I resolve all the conflicts but, seems like it's the same result every time, is there a step that I'm missing?

Your merge commit might have messed things up a bit here - I will try to fix this locally and get this in.

Can you fix the broken test first?

@fernando-sendMail can you open a new PR with fixed history? It seems like something is broken with the history in this one, and I am having a bit of trouble untangling the conflicts.

@wesleycho Sure, I'll work on that.

Hey @wesleycho I think I resolved all the conflicts, the PR is ready for review again

Can you squash into one commit @fernando-sendMail ?

With these minor reverts/changes, this should be good to merge. Squashing the commits makes it easier to replay the change on top of master when we merge it, which is very useful for us.

Hey @wesleycho I tried using git rebase -i <commit to squash> but that didn't worked for me, it created an aditional commit instead, am I doing something wrong?

You can do git rebase -i HEAD~[number of commits without brackets]

Keep in mind once you do this, you will have to force push to the remote to overwrite the history with the new version.

@wesleycho Finally I've made it, it's ready for review again.

Thanks a lot for sticking with it through the time, this is good work!

No problem, thanks a lot for the support guys!
On Mon, Aug 17, 2015 at 7:18 AM Wesley Cho<EMAIL_ADDRESS>wrote:

Thanks a lot for sticking with it through the time, this is good work!
—
Reply to this email directly or view it on GitHub
https://github.com/angular-ui/bootstrap/pull/3463#issuecomment-131833829
.


Add Task on the run

Hi,
I'm having a slightly different use case: I would like to add task to Listr while it's already running (my task list is unknown when the program start).
On my first tries, the 2nd task is rendered but the spinner never shows and the list complete before the return of the second promise. My guess is that it use a reduce to run the tasks and it won't accept new entries while reducing.
I'm working on a recursive approach that would shift the array until null. Do you think it can work? Any advice? Thanks

I'm doing something similar just, now: it work very well!
I hope it can help you:
'use strict';
const Listr = require('listr');
const config = require('./config');
const {
	connect,
	getSaveableMeasures,
	convertToMeasureValues,
	saveMeasures,
	updateMeasureState
} = require('.');

const pool = connect(config);
const tasks = new Listr([{
	title: 'Find unsaved measures',
	task: async ctx => {
		ctx.unsavedMeasures = await getSaveableMeasures(pool);
	}
}, {
	title: 'Saving measures',
	task: ctx => {
		const savingProcedures = ctx.unsavedMeasures.map(({year, code, results}) => ({
			title: code,
			task: async() => {
				const measures = convertToMeasureValues(results, 4242, year);
				await saveMeasures(measures, pool);
				await updateMeasureState(code, 'Caricata', pool);
			}
		}));
		return new Listr(savingProcedures);
	}
}, {
	title: 'All measures saved',
	task: () => pool.close()
}]);

tasks.run().catch(err => {
	console.error(err);
});

Output:

If I understand correctly, you still create the subtask list before running it. That may be a lead but I don't think it will be enough for my use case.
BTW, how come All measures saved popped up before all measures were checked?
Thank you

If I understand correctly, you still create the subtask list before running it

Exactly, they are created in 'Saving measures' task.
There, I return another Listr instance containing all subtasks.

BTW, how come All measures saved popped up before all measures were checked?

Here "Find unsaved measures" is running: subtasks are not yet known:

Here I return the new Listr instance. Please note that "Saving measures" node is now expanded. "All measures saved" node it's not still executed.

Process completed: "Saving measures" node is now shrinked again:

I understand, I misread between listed and executed.
Here's a basic example of my use case:
'use strict';
const Listr = require('.');

var list = new Listr([]);

let i = 0;
var interval = setInterval(() => {
		list.add({
		title: 'Test '+i,
		task: () => {
			return new Promise((resolve, reject) => {
				setTimeout(resolve, 2000);
			});
		}
	});
	if(i == 0) list.run();
	else if(i == 4) {
		list.add({
			title: 'Sub',
			task: () => {
				return new Listr([
					{
						title: 'sub1',
						task: () => {
							return Promise.resolve();
						}
					},{
						title: 'sub2',
						task: () => {
							return new Promise((resolve, reject) => {
								setTimeout(resolve, 2000);
							});
						}
					}
				]);
			}
		});
		clearInterval(interval);
	}
	i++;
}, 500);

This could be achieve with very few modification: https://github.com/JbIPS/listr/commit/f0fa0cd3cfae26613fd5b5d75e6f55bd27402397

Not sure if this is a fit for Listr to be honest. If all of this is dynamic, you might be better of with Ora.
The thing I'm most concerned about is this. What if we define Listr with one task that takes 2 seconds to execute. After 1 second we add another task which takes 1 second to execute. This makes a total of 3 seconds of execution. What if we waited for another 4 seconds and tried to add another task. This means that the 2 previous tasks are already entirely executed and listr has stopped executing.
I like how @parro-it solved his use case. We actually needed a "dynamic" task in np which might use come up with the possibility of enabling or disabling a task and also adding the possibility of dynamically chaning the tasks title.
It really looks and feels like Listr was not designed for this. Feel free to provide feedback on my remarks.

you might be better of with Ora.

You're right, I started with Ora, but ironically you brought me here 😄
I understand your concerns and IMHO the user is responsible for adding new tasks before ending the last one. Since it was only a addition and don't break compatibility with the existing code I though it could be a nice feature but maybe I'll stick with Ora. Or do you have another idea?
Thanks

Hi @JbIPS, sorry for the late reply.
Sorry that the link brought you here ;). I think it's really use case dependent if Listr is a good fit or not. I answered that thread because it looked like the topic starter could benefit from all the things Listr covers. If you know all your things beforehand, then Listr is a perfect fit. If you could defer task creation like @parro-it did and run it in a subtask, then Listr is a perfect fit. But if everything is dynamically, I think Listr isn't a perfect fit and you might be better of with Ora because then you can just run task after task dynamically and you have more flexibility.
I'm closing this feature request for now. I'm still open for discussion though. So if other people want to chime in on this one, go ahead.


SHA 256 is generating invalid signatures

When signing messages with SHA-1 I get valid signatures. However when using SHA-256 I get invalid ones.
See messages below:
VALID SIGNATURE
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Vou tentar mais uma vez. Quem sabe funciona...
-----BEGIN PGP SIGNATURE-----
Version: Outlook Privacy Plugin
iQFsBAEBAgBWBQJV0yO5TxxHaWxiZXJ0byBSZWlzIEZpbGhvIChTYW50YW5kZXIg
UEdQIEtleSkgPGdpbGJlcnRvLnJlaXMuZmlsaG9Ac2FudGFuZGVyLmNvbS5icj4A
CgkQFtxrHx+NsySUSAgAui+jEvaaAPR+2oLH4wJ7aEgVLbKDPkra8iCu1NG12pxR
rHg0P3lnN/ApYiVDdf0ks0lFgYsSis/1tZQgTrMw0n26qR9LZU9QgzM0SnZWctim
WE9ebjqlr87OGR9kklqeRjpz/b5W7eAo8qFq44Sy9ZaGIn/Vyl583RFPzk52e8/z
zVy+zMvggK2DWyxkxl23y9AEFVdL9lqTG5vKGcXbU7XYv+2yRXqp7b612bS/ej7C
Y3IeYRGEi3SiOU1UwcUgUC1U3V/bpEAsMY5GnbMAjWho0KSOwwfTNFIzdHHGXfPY
Okomxs1LZWGc2XA66odo8mshDf+Uw4NAN+i0MU2nKg==
=hYdX
-----END PGP SIGNATURE-----
INVALID SIGNATURE
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Vamos tentar mais uma vez só que com criptografia mais forte...
-----BEGIN PGP SIGNATURE-----
Version: Outlook Privacy Plugin
iQFsBAEBCABWBQJV0yQZTxxHaWxiZXJ0byBSZWlzIEZpbGhvIChTYW50YW5kZXIg
UEdQIEtleSkgPGdpbGJlcnRvLnJlaXMuZmlsaG9Ac2FudGFuZGVyLmNvbS5icj4A
CgkQFtxrHx+NsySyaAf5AXsbzZ1ezhuzFhsTST9la3l4Su4+2fgkp3lGfEfSEVlr
nmrTueW/I3D+SeVISdOPxwCMgN+URzvyF/IY2YZgKK7HFKO0nBv74PPwKFtJ4Biw
TptW1rPRIFsrs/99SVFFrqIpgFRay0xgsPlYte5xy/8AZPq0UpFGM6KHLtr8+TOL
xybrShrPUu64Fk7p/St5Yb347q6BpAyOcTK9PRy7l7y0MHnyiYtyPmpJnRIfVtwC
Y0MeXCO2AyYUMsbP7w1bAAflrAIWHRzovJAW4uc46gV2Es1wuGGaOqehbOCu/UF4
++OLV5dz9c3oQWMKS05gTfNJWe+H86EQ+lePrFarxA==
=yNqO
-----END PGP SIGNATURE-----
PUBLIC KEY TO VALIDATE THE SIGNATURES
-----BEGIN PGP PUBLIC KEY BLOCK-----
Version: GnuPG v2
mQENBFVbRn4BCADJ2WeQO6YHKabyGkKwYxsqilydQ2TzWRk7jJDyR843G134wzLp
E+hcC85NJvPBOlJ2Sv9htUZKsaHgsX1o1UCyQyrIKPT03Z1Rh9+CKZjom8aohu3S
JcEeFvSu56Qzj8g2NzdyVEdISY2v/45UbjNfo1DlvsrMczHZkF7Dsc1nJKgq+eq7
SREqdUjOHOeYQ0q/byi4pRTonrDDC6dJpElDgdH56pAyPiPUuI1Kmg30erVX0ZEE
mCwfKbT/vOLA2wrhMv1MR9MkzMDFequvM4jnnvmsI4YlMdrzON2ClNl2PjlrRcfE
5i5hdE7OVqD9vZAXT1pf+VN/qu6oPCYmSAmPABEBAAG0TkdpbGJlcnRvIFJlaXMg
RmlsaG8gKFNhbnRhbmRlciBQR1AgS2V5KSA8Z2lsYmVydG8ucmVpcy5maWxob0Bz
YW50YW5kZXIuY29tLmJyPokBOQQTAQgAIwUCVVtGfgIbDwcLCQgHAwIBBhUIAgkK
CwQWAgMBAh4BAheAAAoJEBbcax8fjbMkXP4IALjIxXNl1vgs0VQSmLrFeOnN6XX4
Uu97BKketgZCt7zGgEuKFcI4dIhWvpVN5Laz2DytaR/GfvhOqgzsCOWnYYLe3XfV
QQNsfb843sO624RQGmSuELfS2KYqUfGaPJUq1CxtGCI7jfs5p7emzt6CyA6rTtZS
Oo3dFEFp8krF3TdnkSjnBuLa8wD8gnFG+eynXyrPxSQQ7iAIR1QfZLJMQebdR0X9
2BwYS8hHtIgLXebiHF4Yu72Yocbv+zrNl10PV29VARvkkVl18Y6nOZX7f3wtQfW2
7DkIA4J3yy6FkrXQPIVAhHOzIUsaaM8ahA83MrNsh3jVN1MWxgx3n/VeD/U=
=9Y1x
-----END PGP PUBLIC KEY BLOCK-----

Sorry to bump this but is this issue confirmed or am I doing something wrong?

My testing has this working A-OK.  Could you please try again but use only ASCII.  Perhaps this is an issue with unicode.

Tested with Outlook -> Thunderbird w/enigmail
Perhaps the issue was related to another bug about selecting correct keys for signing

I have the same issue. If I include accent like "é" and only sign the email it's invalid. If there is no accent everything goes well.
If I sign and encrypt, everything work as expected even with accent.

I've noticed this problem on pretty much any mail that uses "=XX" encoding, even if it's just an "=20" for a hard newline. Is verification being invoked on the raw source?


Subscriptions and language

Hello, I have two questions:
Is this valid for subscriptions?
Can the texts of "Pay", "Add your payment information", etc be changed?
Thanks!

@Marius-Romanus  Maybe yes. Difference of payment once or subscription looks loke on backend only.

Can the texts of "Pay", "Add your payment information", etc be changed?

No, this is be from stripe's SDK. We can use multi language, but can't change arbitrarily.

thank you, how can I change the language?

Device's settings of language. But this is not plugin issue, if you want to know detail, please ask stripe team.

Right, thanks for the help

@Marius-Romanus Did you adapt this plugin for production? If yes, please tell us what app. Please help us to develop this plugin in 2022.
https://github.com/capacitor-community/stripe/issues/145
Thanks.


.isBoolean not working

Hi, I'm submitting a form through post method, but submitting a checkbox fails in validating it.
This is the code in the post route
req.checkBody('agreeTerms', 'You\'ve to accept Terms&Conditions').isBoolean();
The console.log(req.body.agreeTerms); return the "on" value but the function checkBody continues to throw the error

The source of the isBoolean for validator v8.2.0 tells me that the only acceptable values are true, false, 1 and 0.
You should work your checkbox so that it sends one of the accepted values, or open an issue in the validator repository requesting such change in isBoolean validator.


Change how status is displayed for submissions in the Submissions table

Status column should be changed to be calculated based on the combined statuses of all repositoryCopys associated with the submission

No repositoryCopy objects associated with the submission: display nothing
submission.source="other" && submission.submitted=false: display Manuscript expected
All repositoryCopy objects have copyStatus=complete: display status complete
Other combination of repositoryCopy.copyStatus: display a link saying "See details" that links to the submission details page. This part relates to #539 which will have a nicer way of displaying all repositoryCopy.copyStatus

@jabrah I believe status display is still undecided unless you recently talked to @htpvu. The problem is that we may not have a RepositoryCopy for every Deposit. Some Deposits may be accepted by the target Repository and that's the last we know of them.

@jabrah @karenhanson @htpvu yes this probably deserves larger discussion.
Concrete example: NIH submissions

Deposit Services processes the Submission
Upon successful processing this results in a Deposit with a status of SUBMITTED.

A tar.gz is dropped off at the NIH FTP server.
All we know at that time is whether or not the bytes of the package were transferred successfully
There is no indication of acceptance of custody from NIH at the time the package is created and dropped off on the FTP server.
In the absence of an acceptance of custody, we ought to leave the status of the Deposit as SUBMITTED.

No RepositoryCopy is created.

Because there is no acceptance of custody, there's no location for a RepositoryCopy to reference, so at the moment Deposit Services does not create one.

After some time in the future, the NIH will process the .tar.gz file we dropped off, and they send an email that indicates the acceptance (or not) of custody.
After that email is received, we can change the status of the Deposit to ACCEPTED (or REJECTED, if they do not take custody).  If the email indicates a location of the content, we can create a RepositoryCopy.

FOR SUBMISSION TABLE:
Status column should be changed to be calculated based on the combined statuses of all repositoryCopys associated with the submission

submission.source="pass" && submission.submitted=true && no repoCopy: display submitted
submission.source="other" && submission.submitted=false && no repoCopy : display Manuscript expected
repoCopy.copyStatus="complete": display complete
Other combination of repositoryCopy.copyStatus: display a link saying "See details" that links to the submission details page. This part relates to #539 which will have a nicer way of displaying all repositoryCopy.copyStatus

The nuances of individual deposits and repocopies as they are related to a single submission should be captured in the submission details page

Table incorrectly showing Submitted instead of See details when a repositoryCopy.copyStatus=stalled

looks good.


[Fatal] Unhandled top-level exception: $exn

Both my block producer and snark worker node crashed at the same time.
Here's the crash report from the block producer:
coda_crash_report_2020-01-25_13-49-38.346094.tar.gz
And here's the crash report from the snark worker:
coda_crash_report_2020-01-25_13-49-21.968956.tar.gz

This was likely caused by a race between multiple threads updating the transaction pool. We haven't seen this class of error since #7759. Closing.


Build error: Trying to touch file below public/js after  "rm -rf public/js"

Gitea version (or commit ref): 77f3dbe
Git version: 1.7.1
Operating system: CentOS 6.10
Database (use [x]):

[ ] PostgreSQL
[x ] MySQL
[ ] MSSQL
[ ] SQLite

Can you reproduce the bug at https://try.gitea.io:

[ ] Yes (provide example URL)
[ ] No
[x ] Not relevant

Log gist:

Description
Searched issues for "UnhandledPromiseRejectionWarning" but turned up nothing
Building against

node-v10.22.1-linux-x64.tar.xz
go1.15.2.linux-amd64.tar.gz

# go version
go version go1.15.2 linux/amd64

# node --version
v10.22.1

# npm --version
6.14.6

# git version
git version 1.71

# cd /usr/local/gitea
# git branch -v
* master 77f3dbe latest version is 1.12.5 (#13005)

# TAGS="bindata" make build

... puls down a load of stuff ..

... Starts building ...

... then fails ...

[15:01:40] Created: ../../web_src/fomantic/build/themes/material/assets/fonts/ic
ons.woff2
[15:01:40] Finished 'Building Assets' after 118 ms
[15:01:40] Finished 'build-assets' after 119 ms
[15:01:40] Finished 'build' after 50 s
rm -rf public/js public/css public/fonts public/img/webpack public/serviceworker.js
npx webpack --hide-modules --display-entrypoints=false
(node:2419) UnhandledPromiseRejectionWarning: Error: "version" is a required argument.
(node:2419) UnhandledPromiseRejectionWarning: Error: "version" is a required argument.
    at Object.getArg (/usr/local/gitea/node_modules/webpack-sources/node_modules/source-map/lib/util.js:24:11)
    at new BasicSourceMapConsumer (/usr/local/gitea/node_modules/webpack-sources/node_modules/source-map/lib/source-ap-consumer.js:294:22)
    at new SourceMapConsumer (/usr/local/gitea/node_modules/webpack-sources/node_modules/source-map/lib/source-map-onsumer.js:22:7)
    at SourceMapSource.node (/usr/local/gitea/node_modules/webpack-sources/lib/SourceMapSource.js:32:62)
    at SourceMapSource.proto.sourceAndMap (/usr/local/gitea/node_modules/webpack-sources/lib/SourceAndMapMixin.js:29:18)
    at getTaskForFile (/usr/local/gitea/node_modules/webpack/lib/SourceMapDevToolPlugin.js:65:30)
    at files.forEach (/usr/local/gitea/node_modules/webpack/lib/SourceMapDevToolPlugin.js:215:20)
    at Array.forEach (<anonymous>)
    at compilation.hooks.afterOptimizeChunkAssets.tap (/usr/local/gitea/node_modules/webpacklib/SourceMapDevToolPlugin.js:186:12)
    at SyncHook.eval [as call] (eval at create (/usr/local/gitea/node_modules/tapable/lib/HookCodeFactory.js:19:10), <anonymous>:7:1)
    at SyncHook.lazyCompileHook (/usr/local/gitea/node_modules/tapable/lib/Hook.js:154:20)
    at hooks.optimizeChunkAssets.callAsync.err (/usr/local/gitea/node_modules/webpack/lib/Compilation.js:1413:42)
    at _promise2.then._result2 (eval at create (/usr/local/gitea/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:14:1)
(node:2419) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:2419) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
touch: cannot touch `public/js/index.js': No such file or directory
touch: cannot touch `public/css/index.css': No such file or directory
make: *** [public/js/index.js] Error 1

Notes
Bit further back up the build, we saw
added 1811 packages from 1184 contributors and audited 1821 packages in 38.437s

116 packages are looking for funding
  run `npm fund` for details

found 6 vulnerabilities (5 low, 1 high)

sugesting it did a fair bit, though of course, after the
rm -rf public/js public/css public/fonts public/img/webpack public/serviceworker.js

it comes as little surprise to see
# ls public/
img  vendor

which suggests that any attempt to do this
touch: cannot touch `public/js/index.js': No such file or directory
touch: cannot touch `public/css/index.css': No such file or directory

is bound to fail.
So what did I miss?

The touch is only there to help make keep track of build dependencies. Ideally make should have failed and exited after the webpack error.
Now that webpack error is strange, I'm not sure why it's happening. It seems to come from here.

Ideally make should have failed and exited after the webpack error.

Given that it does say that
"Unhandled promise rejections are deprecated. In the future, .."
then the
"UnhandledPromiseRejectionWarning: Error:"
is not really an error, but a warning, then I think make is only doing
what's it being told, no?
Once unhandled promise rejections are obsolete, and the warning
becomes an error, I am sure make, in which I have a lot of cofindence,
will do the right thing.
Would you advise a "make -k" ?

Yeah I guess it may be Node's weird way of handling such unhandled rejections that don't cause the process to exit properly. Normally one would run node --unhandled-rejections=strict for more sane behaviour but that's not easily possible with package binaries like webpack.

FWIW,
TAGS="bindata" make -k build
run without cleaning anything up from before, has
see it move along a lot further ...
.. to the extent of filling up the disk of the VM I was building it on.
I wonder how much space it needs: didn't see anything in the docs.

Not much more space than I had it turns out, so it seems as though a
TAGS="bindata" make -k build
does do what's required.
Talking of what's required though, when i came to do
./gitea web
i was told
2020/10/08 16:40:06 cmd/web.go:108:runWeb() [I] Starting Gitea on PID: 2536
2020/10/08 16:40:06 ...s/setting/setting.go:509:NewContext() [W] Custom config '/usr/local/gitea/custom/conf/app.ini' not found, ignore this if you're running first time
2020/10/08 16:40:06 ...dules/setting/git.go:68:newGit() [F] Failed to initialize Git settings%!(EXTRA *log.ColoredValue=Git version not supported. Requires version > 1.7.2)

Didn't mention that requirement in the docs either ?

It's documented: https://docs.gitea.io/en-us/#system-requirements
I'd not recommend -k. If webpack fails to build, you'll end up with a broken web interface. You can alternatively use the src tarball downloads that include precompiled frontend files.

Because I'd started out building from source, I'd been refering to the
https://docs.gitea.io/en-us/install-from-source/
doc, where it only specifies minimum versions for NodeJS and Go.
As I said, it - make -k - appears to have worked, not that I have
got that far into the web interface yet.

I had the same problem, and I accidently fixed it by replacing --hide-modules --display-entrypoints=false with --unhandled-rejections=strict. Don't know why though.

I had the same problem, and I accidently fixed it by replacing --hide-modules --display-entrypoints=false with --unhandled-rejections=strict. Don't know why though.

Out dated, the code base has changed a lot


confusing about stop_gradient in the code

why there are two stop_gradients in "mask" function of pretrain_helpers.py. see snapshot under.

i can understand the stop_gradient here, but after that, there is still an argmax op, seems strange

The tf.stop_gradients were there to stop back-propagating through non-differentiable operations (categorical sampling and argmax), although I'm not 100% sure if they are actually necessary, as tensorflow may not backprop through them by default.


BG Photo Gradient Bug with CSS

Odd CSS bug with photo gradient, override in html to fix

Fixed with recent submission


Question: is dispatching in cancelled$ observable subscriber OK?

We need to dispatch action in cancelled$ observable subscriber. Is it OK? Our usecase is:
process({ cancelled$ }, dispatch, done) {
    const pid = Math.random(); // progress id
    dispatch(startProgress(pid));
    cancelled$.subscribe(() => {
      dispatch(stopProgress(pid));
    });
    asyncFn(function (err, result) {
      dispatch(setResult(err, result));
      dispatch(stopProgress(pid));
      done();
    });
}

Actions startProgress and stopProgress is to indicate some async profress and is presented in UI.
We tried it and it works.
Also documentaiton says:

This osbservable will also complete when the hooks have finished, regardless of whether it was cancelled.

What does it exactly mean? Because calling done() doesn't complete it (subscriber is not called).

@zdila I don't believe that dispatching in the cancelled$ will work for you since once things are cancelled, I don't send anything that is dispatched after that.
What the documentation was trying to say is that cancelled$.next is fired when things are cancelled$ but also cancelled$.done fires when everything was complete. However in both cases the underlying observable is finished so the dispatch function won't send anything out.
Normally if I need to do something in regards to a cancellation, I simply listen for the event that triggers the cancellation and update the UI from that. So if a LOCATION_CHANGE triggers the cancel then I would have logic that listens for that and simply clears out the UI. However in your case you'd need to track the pids somehow, probably storing them in redux so they are all available when you want to handle the cancellation.
If you'd rather do it in a manner like you have here inside the logic, then you can do the following.
// in your create store function add a new injected dep after your create your logic mw and store
const logicMiddleware = createLogicMiddleware(logic);
const store = createStore(rootReducer, applyMiddleware(logicMiddleware));
store.logicMiddleware = logicMiddleware; // attach for easy use later
// now adding a new injected dep called storeDispatch which always will dispatch
// even after a logic has been cancelled
store.logicMiddleware.addDeps({ storeDispatch: store.dispatch });

You have to add this injected dependency after you have created your store so you can get a hold of the dispatch fn, so that's why we added it with addDeps() rather than providing it during the createLogicMiddleware. It's a chicken and egg thing, need to create store to get access to the dispatch function.
Now that you have this new storeDispatch function as a dep you can also use it in your logic to do dispatching at any time even after cancellation or completion. You still use the original process dispatch when you want to have cancellation to stop your dispatches, but the new storeDispatch can be used when you always want to dispatch regardless.
So your logic adapted to use the new storeDispatch would look like this:
process({ cancelled$, storeDispatch }, dispatch, done) {
    const pid = Math.random(); // progress id
    dispatch(startProgress(pid));
    cancelled$.subscribe(() => {
      // need to use storeDispatch here since dispatch doesn't emit after cancellation
      storeDispatch(stopProgress(pid));
    });
    asyncFn(function (err, result) {
      dispatch(setResult(err, result));
      dispatch(stopProgress(pid));
      done();
    });
}

Thanks for your solution, but...

I don't believe that dispatching in the cancelled$ will work for you since once things are cancelled, I don't send anything that is dispatched after that.

...it really works :-)
cancelType: ['SET_TOOL'],

cancelled$.subscribe(() => {
  dispatch(stopProgress(pid));
});

And in the logs I see dispatching SET_TOOL and immediately after that STOP_PROGRESS (using redux-logger).

Maybe it is occurring immediately before the cancellation is actually taking effect. If it works, it works :-) If for any reason it doesn't you can use the above solution.


strict linter

Codecov Report

Merging #14 into master will increase coverage by 0.02%.
The diff coverage is 96.36%.

@@            Coverage Diff             @@
##           master      #14      +/-   ##
==========================================
+ Coverage   97.05%   97.07%   +0.02%
==========================================
  Files          54       55       +1
  Lines        1189     1198       +9
  Branches       94       94
==========================================
+ Hits         1154     1163       +9
  Misses         31       31
  Partials        4        4

Impacted Files
Coverage Δ

jj/_version.py
100.00% <ø> (ø)

jj/handlers/_handler.py
100.00% <ø> (ø)

jj/logs/_filter.py
100.00% <ø> (ø)

jj/logs/_logger.py
100.00% <ø> (ø)

jj/logs/formatters/__init__.py
100.00% <ø> (ø)

jj/logs/formatters/_simple_formatter.py
100.00% <ø> (ø)

jj/middlewares/_abstract_middleware.py
100.00% <ø> (ø)

jj/resolvers/_reversed_resolver.py
100.00% <ø> (ø)

jj/runners/__init__.py
100.00% <ø> (ø)

jj/servers/__init__.py
100.00% <ø> (ø)

... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e16be40...b9a16a2. Read the comment docs.


link the results page

+1 on this. I know it's an old project but since Github changed their linking structure, all the links from say HackerNews no longer point to the results page.

For those looking for the results, they are here: http://eric.themoritzfamily.com/websocket-demo-results-v2.html