Side Menu issue after upgrading to Beta 11 (Ionic2)

Hello guys,
Earlier I created a simple project in ionic2 beta-10 version. In beta-10 side menu working properly.
But today I upgraded my project to beta 11 the same code for Side Menu not working. The Navigation drawer from the left side is not working. My most of the navigation is depend upon side-menu in current project.
When I click on navigation drawer button (i.e. three horizontal lines icon) at the upper-left side of the navigation bar, nothing happens.
Also if I drag from left to right on the screen, side menu is not opening.
The side menu is not opening on iPad and ionic serve (i.e. browser) too..
If anyone having such problem after upgrading to beta-11.
Anyone know the solution for this??
Related issue created as topic on ionic forum, below is link for reference
https://forum.ionicframework.com/t/side-menu-issue-after-upgrading-to-beta-11/59865
Thanks in advance.

Related to #7586

Hello @vaibsVB are you trying to use the sidemenu from a modal? Thanks for using Ionic!

@jgw96 do you have an actual plunker template for beta11?

@mpaland not yet, unfortunately we have ran into some issues involving npmcdn that i am currently working on resolving. Sorry for any hassle this causes.

@jgw96
Hey justin,
actually in my case I'm not used modal from sidemenu.
My project consists of pure side menu example.
It works fine with ionic2 beta-10.
But after up-gradation to beta-11 referring to this link https://github.com/driftyco/ionic/blob/master/CHANGELOG.md#200-beta11-2016-08-05.
But after upgradation to beta-11 side menu is not working.
Sorry for little english if you may get confused with my issue and mpaland's issue.
But in general we both are facing kind of similar issue.
Thanks in advance.

Hello @vaibsVB !  Unfortunately, I am having an issue reproducing this issue. Would you mind trying a fresh starter app by running ionic start test-app sidemenu --v2 and trying it? Thanks!

Thanks Justin for saying perfect English :) Unfortunately its not so good. :)
Coming to issue, currently I'm trying to find why it is happening with beta-11. Shortly I will create new starter with side-menu starter. :+1:
Thanks for reply.
Regards.

@jgw96
Hi Justin,
As per you said, I thought to create a fresh project with sidemenu.
But while creating a fresh project there is issue with Ionic CLI.. I am providing log..

$ ionic start demoApp sidemenu --v2 --ts
Creating Ionic app in folder /Users/bista-mac/Documents/demoApp based on sidemenu project
Downloading: https://github.com/driftyco/ionic2-app-base/archive/master.zip
[=============================]  100%  0.0s
Downloading: https://github.com/driftyco/ionic2-starter-sidemenu/archive/master.zip
[=============================]  100%  0.0s
Installing npm packages...
Error with start undefined
Error Initializing app: There was an error with the spawned command: npminstall
There was an error with the spawned command: npminstall
Caught exception:
undefined

I don't know what is happened with my CLI.
I'm sharing my ionic info with you.

$ ionic info
Your system information:
Cordova CLI: 6.2.0
Ionic CLI Version: 2.0.0-beta.32
Ionic App Lib Version: 2.0.0-beta.18
ios-deploy version: 1.8.6
ios-sim version: 5.0.8
OS: Mac OS X El Capitan
Node Version: v4.2.4
Xcode version: Xcode 7.3.1 Build version 7D1014

with CLI version : 2.0.0-beta.32 previously I created sidemenu project and it was performing  well so far.
Kindly look into this and provide some solutions in order to make my CLI stable.
Thank you.

I have the same proble,too pls help with it?

@vaibsVB Would you mind updating your ionic cli by running sudo npm install ionic -g? The latest version is 2.0.0-beta.36. Thanks!

I tried your command i.e. sudo npm install ionic -g
but now my ionic info shows different information about ionic CLI

$ ionic info
Your system information:
Cordova CLI: 6.2.0
Gulp version:  CLI version 3.9.1
Gulp local:   Local version 3.9.1
Ionic CLI Version: 1.7.16
Ionic App Lib Version: 0.7.3
OS: Distributor ID:	Ubuntu Description:	Ubuntu 14.04.3 LTS
Node Version: v4.0.0

seems it updated the version of ionic 1

Hello @vaibsVB , sorry that is my fault. The command should be sudo npm install ionic@beta -g. Very sorry about that.

It's fine justin.. Actuly I'm did the mistake by direct copy paste the command..
After posting a reply I got to know that I inputted command for ionic 1..
So I inserted new command with this @beta added..
Thank you.

No problem! Are you able to reproduce the issue with a sidemenu starter?

Will check for sidemenu starter issue if in case I found with this updated CLI and let you know.
Thank you.

Hi @jgw96,
I have updated to Ionic CLI Version: 2.0.0-beta.32 and Ionic Framework Version: 2.0.0-beta.11 as per your guidance. Now my sidemenu is toggling on clicking on toogle button present at top-left navigation bar.
But the thing is when the sidemenu is opened and I clicked anywhere on the screen (except navigation drawer) the navigation drawer is not going to close.
Few times it takes 5-7 seconds to close the navigation drawer after tap on the screen.

Hello @vaibsVB ! Glad to hear that we are making progress! Quick question, what device are you testing on when you get this issue? Unfortunately i cant seem to reproduce this with any of my sidemenu apps. Thanks!

It's iPad Air.
I'm not able to create snapshot/screen video recording to produce it.

Hello! Would you mind trying our conference demo app https://github.com/driftyco/ionic-conference-app and seeing if you can repro the issue their too? Thanks!

I'm seeing the same issue. We have an application that we started based on the ionic-conference-app and have been upgrading as each beta is released.
What appears to be happening is that the root NavController isn't being retained. If I have my rootPage call
NavController.setRoot(), the menu continues to work.
However, if I present a Modal, and from that Modal do a NavController.setRoot(), the menu appears to be lost. I'm guessing this all retains on a 2nd navigation context since the Modal presents itself now.
//Further issues with sidemenu
Additonally, if the menu is open, and I click on the main page to have it close, it is delayed closing, and then anytime I click on the main page again, the menu drawer is re-opened. Until I use the slide motion to close the menu, all clicks on the page will just toggle the menu.

I just confirmed the menu is broken in the conference app as well. If I am in platformiconic=ios, in chrome. I get the same behavior. When I slide out the menu it slides out fine, but then if I click anywhere, it's a delayed abrupt snap back to closed, and any clicks on the page will cause the menu to open back up. Until I have dragged the menu back to closed from an open position, I cannot click on anything in the main content page.
If I use the menu toggle button during this time, it appears the menu slides too far to the right underneath the content as well..but if I click a couple more times it will toggle "closed" and back open.
I made no modifications to the conference app, I just cloned it, npm installed, and ran
ionic serve --browser chrome

@Barryrowe  I am also having the issue. I am calling NavController.setRoot from a popover and when directed back to other page the menu isn't working.

@jgw96 I replicate ionic-conference-app and check for sidemenu behavior.
In the ionic-conference-app of beta-11 sidemenu's giving same problem (even I cross verified packge.json file, all dependencies are the same but still having an issue).
Hope this will resolve soon.
Thanks.

Im also experiencing the problem.
On IOS (Iphone 6s) pressing menu icon the menu is delayed (half a second or so) before showing. Then (sometimes) I have to  click the menu items several times before reacting.
I then  the app on Samsung S7Edge  running Ionic View - everything is working as expected. So to me there seems to an issue on Ios.
Hope this will get fixed soon.
Thanks

Hello all! I am still having trouble reproducing these issues. On my iphone 5, safari, chrome,  android 5.1.1, android 6 and android 7 with the latest version of the Conference app everything seems to be working fine. Would anyone be able to provide a more minimal repo than the ionic-conference-app that i can use to reproduce any of the above stated issues? Thanks!

@jgw96 Hmm, I was consistently getting the issue to appear in the conference app. The steps to reproduce the side menu bugged states with the conference app:

run the app with parameters ionicplatform=ios in query string
use the slide motion to open the side menu (drag from the left of the screen)
Click anywhere on the body of the screen (you should notice a stuttered close)
Click anywhere on the body of the screen (you should see a non-animated open of the side menu)
Until you drag the side menu closed, all clicks on the body of the page will attempt to toggle the side menu
After you've dragged the side menu closed, if you click the menu hamburger icon, the side menu panel opens, but the menu content appears to be hidden under the body of the main content leaving a blank white side panel.
Clicking the hamburger icon a couple more times appears to get you back to a "normal" state.

Just upgrade my application to beta11 yesterday. So, here I share some of the screenshot that I think might give hint to what actually happen. Basically, clicking on the menu from other navigated page still trigger the one at the root.

Thanks everyone for the info! @lufias would you be able to provide a repo with a minimal example that I can use to reproduce this issue? @Barryrowe does your issue happen only when using that string to change the mode in your query? Would you mind trying with just device emulation on chrome emulating an iPhone? Thanks everyone!

@jgw96 I just tested this in chrome with emulation. It appears that everything works fine with the user-agent emulation. Whether iPad/iPhone or an Android device. I also tested without the header emulation and just using localhost:8100, localhost:8100?ionicplatform=ios, localhost:8100?ionicplatform=android.  In all of these 3 scenarios the side menu appears to be broken as stated above.
It appears that something is dependent on the User-Agent headers being picked up and applying some styles/events.

Just did a fresh install of the conference app on my Iphone 6s (ios 9.3.4) delay issue is reproduced as follows:

Click menu button in upper left corner (main content slides to the left)
Try click the menu button (now at the upper right) right after sliding has ended.
You will have to click several times before main content is sliding in to the right again.

The same can be reproduced in
a) IOS simulator running IOS 9.3
b) Iphone 5s (IOS 8.3)
How this helps just a bit :-)

@jgw96 I just created an example repo similar to my screenshot shown before..
https://github.com/lufias/sideMenu
You may try running it on the browser and follow the same step as I told before. Unfortunately (in my case), there's no back button on the browser, so, you shouldn't be a able to do back action to view what happened on the root page (Menu should appear)
So, perhaps you can try to run this on mobile device. I was running it on an android device with crosswalk 19+ plugin installed.
On that note, I was also assigning the root nav into ViewChild in app.ts so that i can do a redirect right off the first page. Wonder if that what make the menu somehow binded to the root.
@ViewChild('myNav') nav

@vaibsVB @jgw96

Installing npm packages...
Error with start undefined
Error Initializing app: There was an error with the spawned command: npminstall
There was an error with the spawned command: npminstall
Caught exception:
undefined

I'm running the latest CLI, beta 37. But, I actually stumbled this error back in beta 22.. I always wonder if this is just some kind of syntax error, that, whoever manage this, forget to remove the space between npm and install? Btw, you can proceed to installation by getting into the app directory, remove node_module folder and proceed with npm install directly from within..

Not sure if this issue is going in 2 separate issues or both part of same original issue posted.
If I navigation from a popover to another page am 100% able to replicate issue. A work around this issue with the the following:
FROM inside popover
import {NavController, App} from 'ionic-angular'; this.navController.setRoot(MainPage)
TO
import {NavController, App} from 'ionic-angular'; this.app.getRootNav().setRoot(MainPage)
This will navigate to page but the popover will still appear. Click away to close popover... and then the sideMenu toggle should work as intended.
This is a temp workaround when I am developing so I don't have to refresh my page.

@lufias Ahh i think i may know what the issue is now. Are you using this.navcontroller.setRoot() from your popover? The actual correct way to set the root from an overlay component is this.app.getRootNav().setRoot(). @abartolo That is actually not a workaround but is the correct way to use setRoot from an overlay component like popover now. With beta.11 we changed it to where each overlay component has its own nav stack, which means that to get the NavController of your "root" instead of the NavController of the overlay component you must do this.app.getRootNav(). Hope all this makes sense.

Also, @Barryrowe your bug seems to be related to the same bug mentioned in this issue. Would you mind adding your findings to that issue? Thanks for using Ionic!

@jgw96 Thanks! I will have to look at documentation to get more familiar with changes to nav stack.
However I still have the issue when calling
this.app.getRootNav().setRoot(MainPage)
The popover and backdrop carries over to new page. I have to click away from popover to close it. I can't provide images now but hopefully someone can reproduce.

Hello @abartolo you should be calling the dismiss() method on the ViewController inside your popover to dismiss the popover. Example:
  import { ViewController } from "ionic-angular";

  constructor(private viewCtrl: ViewController){}

  closeMethod() {
     this.viewCtrl.dismiss()
  }

@jgw96 Yup that makes sense lmao. Thanks!

haha 😄  no problem!

@jgw96 Done, posted to the other issue.

@Barryrowe Yep i saw. Thanks!

@jgw96 awesome.. it works!! even though I'm not actually setting root in my popover, rather to navigate to some other page.
Leaving some code here for reference
// Within popover class
import {ViewController, App} from 'ionic-angular';
import {OtherPage} from '../otherpage/otherpage'

@Component
export class MyPopover {
	constructor(
		private viewCtrl: ViewController,
		private app:App){}

	goToTestPage(){
		this.viewCtrl.dismiss().then(
			(result) => this.app.getRootNav().push(TestPage)
		)
	}
}

Hello! @lufias Awesome, glad its working for you now! Since it seems like this issue has been fixed  i will be closing this issue for now. Thanks everyone!

@jgw96 Have you find any solution to the issue i.e. we were cloned conference-app or created a new project using beta-11. But still, we find lags or unsuccessful attempt when closing of side menu/navigation drawer.

Hello @vaibsVB ! That issue is being tracked here https://github.com/driftyco/ionic/issues/6405 Feel free to add your findings to that issue. Thanks for using Ionic!

I am still experienced the same issue with beta-11. is this issue closed? Can we have detail step on how to remediate this issue in iOS device?

Hello @walter133 ! We are tracking this issue on #6405 as part of the beta.12 release . Thanks!

Thank Justin

Justin Willis<EMAIL_ADDRESS>於 2016年8月29日 下午11:46 寫道：
Hello @walter133 https://github.com/walter133 ! We are tracking this issue on #6405 https://github.com/driftyco/ionic/issues/6405 as part of the beta.12 release . Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/driftyco/ionic/issues/7600#issuecomment-243163769, or mute the thread https://github.com/notifications/unsubscribe-auth/AS5HwxYXFkPw78MM1SVHm_PSr1LExXSEks5qkv7QgaJpZM4Je6fP.

Will issue #6645 be finally fixed in beta 12??

Why this issue and issue #6405 have been closed when they clearly have not yet been fixed? (just wondering :/)

Thanks @abaratolo / @jgw96 / @lufias, this fix works well for now.

@jgw96  I am still facing this issue
this.app.getRootNav().setRoot(AppointmentsPage)
this fix is not working for me.I am still facing the issue.


Adding Suspend/Activate events support

For ProcessInstances and Tasks, so query and Audit can consume them

https://github.com/Activiti/Activiti/issues/1755


Inconsistent determination of positional Argument when using context.Arguments versus context.Argument

Prerequisites

[X] I have written a descriptive issue title
[X] I have searched issues to ensure it has not already been reported

Cake runner
Cake Frosting
Cake version
3.0.0
Operating system
Windows
Operating system architecture
64-Bit
CI Server
No response
What are you seeing?
When I am running a task, and I have an IFrostingContext, I have 4 options to get an argument:

ArgumentAliases.Argument(IFrostingContext, string)

Requires the argument and displays an error if there is none displayed

IFrostingContext.ICakeContext.GetArguments()

Returns a dictionary of collections for all the arguments, which puts the onus on the user to get the argument

IFrostingContext.ICakeContext.GetArguments(string)

Returns a collection of arguments for the provided string, which once again puts the onus on the user to get the Argument

ICakeContextExtensions.GetArgument(ICakeContext, string)

Returns the "Last" instance of an argument provided to the CLI

Since 2 and 3 require the user to do extra work, we'll disregard those, unless they're helpful or informational. So to compare 1 vs 4:

Returns and requires an argument to be present. Returns the FIRST instance of the argument.
Returns and does not require an argument to be present. Returns the LAST instance of the argument

We need consistency, because there is an actual use-case for both. Sometimes I want to use ArgumentAliases.Argument so that I don't have to write in my own Error Message, and mess with the AnsiConsole in the same way that that function messes with it.
What is expected?
I would expect that when using:
ArgumentAliases.Argument(IFrostingContext, string)
and
ICakeContextExtensions.GetArgument(ICakeContext, string)
I would get the same result.
Steps to Reproduce
Create a task in which you pass in an argument. Then, try to retrieve the argument using the two methods described:
.\build.ps1 --required_single=0 --required_single=1
var foo = context.Argument("required_single");
var bar = context.Arguments.GetArgument("required_single");
See that foo is 0, and bar is 1.
Output log
No response

BTW, I have a commit across streams, but I'm working on some extra integration tests. I'm having trouble running the specific tests I want to run, and having trouble adding new ones. But if you can approve of this, it's a simple modification from FirstOrDefault to LastOrDefault.
Here's my reasoning why we're going Last instead of First:
if you type in --target=A --target=B, we use B as the target, not A. Therefore, to keep it consistent with other places in the application, we should make it always return the last value, that way the value can likewise be overwritten, by whatever process can overwrite it.
While I say it's a "simple modification", I realize this is not a "trivial change" because it completely alters existing behavior for users of frosting who may be using the ArgumentAliases.Argument() function.

Thanks for reporting this @EdLichtman. Returning the value of the last occurrence of the argument is the way to go.
This will be fixed by https://github.com/cake-build/cake/pull/4136

@augustoproiete I also have a changelist that includes additional unit/build tests but couldn't get them running locally yet. Could you possibly vet the code for me and add it to yours before you merge in?

@EdLichtman Sure. Point me to it or post a patch here

https://github.com/cake-build/cake/pull/4139

@augustoproiete I really appreciate that, even though you also did some work, you gave me the opportunity to get a contribution. It made me very happy!


Exception when enabling 301 redirects module

Issue is related to an exception within the data migration.
2019-03-22 15:07:20.9564|Default|0HLLER042K18S:00000004||OrchardCore.Data.Migration.DataMigrationManager|ERROR|Error while running migration version 1 for 'Moov2.OrchardCore.SEO.Redirects'. System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation. ---> System.MissingMethodException: Method not found: 'YesSql.Sql.SchemaBuilder OrchardCore.Data.Migration.DataMigration.get_SchemaBuilder()'.
   at Moov2.OrchardCore.SEO.Redirects.Migrations.UpdateFrom1()
   --- End of inner exception stack trace ---

Tried debugging this but wasn't able to replicate the issue. With that in mind, it's likely how this module is packaged up and referenced via NuGet.

Adding reference to OrchardCore.Data.Abstractions fixed the issue 👍


[popup] Add Standard Apex classes documentation in shortcut

Is your feature request related to a problem? Please describe.
It would be great to search and navigate to apex doc from shortcut popup
Describe the solution you'd like

Idea would be to use setup links and add "external" property to model in order to prevent the addition of the current domain when selecting the link.
  {label: "Class String", link: "/apex_methods_system_string", section: "Apex Doc > System > String", prod: false, external: true}


Pr gzrendering7 support bayer images

🎉 New feature
Closes gz-sensors issue 299
Sub-Tasks

[x] Support  simulation for BAYER_RGGB8 with OGRE
Extend the functionality to support all bayer types with OGRE
Extend the functionality to support with OGRE2

Summary and Related PRs
The functionality reads the user input and renders an RGB image, which is later converted into a single channel 8bit Bayer image using ConvertRGBToBayer() added to Utils.cc inside gz-rendering.

gz-sensors : Adds a switch case for RGGB bayer format inside CameraSensor.cc and passes the R8G8B8 format to render the image.
gz-redering : Adds ConvertRGBToBayer() to Utils.cc, modifies OgreRenderTarget.cc to call the conversion function, and handles image format conversion functions with if-else statements.
gz-gui : Adds switch cases to display Bayer images in Gazebo GUI inside. It treats them as single-channel 8-bit images.
gz-common : Modifies Image::SetFromData inside Image.cc to support saving of Bayer images. In order to save it It treats them as single-channel 8-bit images.

Test it
In order to test this, one can modify camera_sensor.sdf inside gz-sim here. Would have just to replace the part with the following snippet.
<image>
   <width>320</width>
   <height>240</height>
   <format>BAYER_RGGB8</format>
</image>
<clip>
   <near>0.1</near>
   <far>100</far>
</clip>
<save enabled="true">
    <path>path to the folder</path>
</save>

Checklist

[x] Signed all commits for DCO
[ ] Added tests
[ ] Added example and/or tutorial
[ ] Updated documentation (as needed)
[ ] Updated migration guide (as needed)
[ ] Consider updating Python bindings (if the library has them)
[ ] codecheck passed (See contributing)
[ ] All tests passed (See test coverage)
[ ] While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Since the title of the PR ends up in the changelog, mind changing it to maybe just "Add support for bayer images to Ogre and Ogre2". Feel free to reword, but "Pr" and "gzrendering7" should not be in the title.

updated channel count of bayer image format from to 4 to 1 and fixed crash in 79a83c6


Add post link card with og:image,og:title,og:description

Hi, first of all, thank you for the wonderful project
Added an example of getting og:image from a site and posting a link card with an image.
Please merge if you like.
like this:

Hi! Thank you for your contribution! I cleaned up the example and moved to httpx lib because it should be already installed (SDK uses it). Also, I made the image optional (atproto allows it). Does that look good to you?

Thank you! No problem. LGTM.


[Feature Request]: Syntax highlighting for scripts

What would you like to happen?
Migration: https://issues.apache.org/jira/browse/HOP-3036
https://issues.apache.org/jira/browse/HOP-3224
I think it'd be great if Hop Gui has highlight syntax for components where the end user input some code.
Like SQL scripts , JSON configurations or Javascript code.
Something like we had in PDI / Kettle.
Issue Priority
Priority: 3
Issue Component
Component: Hop Gui

I'd love that. Even if we'd only get bracket highlighting, that alone would be helpful.


TS-5108-SSL requests might stall because enabled write is ignored

In non-debug mode an enabled write is ignored resulting in a stalled request. In debug mode the writeReschedule is fired.
A fix is to move the conditional writeReschedule out of the conditional debug code.
Addendum to:
https://issues.apache.org/jira/browse/TS-2815
https://github.com/apache/trafficserver/commit/f3a3edb048fc5f96163d1c4a26c1523383786f5d
For more context:
https://github.com/apache/trafficserver/blob/6.2.0/iocore/net/SSLNetVConnection.cc#L1279

lgtm!

[approve ci]

Looks good to me as well.  Indeed, the reenable is useless where it is currently for production deployment.

FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1293/ for details.

Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/1186/ for details.


Incorrect documentation on regex string comparator about not supporting flags

While comparing HBase and Bigtable and outlining what can be supported, the documentation outlined here: https://cloud.google.com/bigtable/docs/hbase-differences#filters says that BigTable

Supports only the following comparators: RegexStringComparator with no flags and the EQUAL operator

It is possible to set case insensitivity flag using regex function in the library by setting RE2 flag for case insensitive search. (?i)

Hi @PragyaTripathi! Are you using the Bigtable Java client or the Bigtable Hbase Java client? If you are using the Bigtable Java client, you can achieve that using a regex filter. Here's an example for a row key:
Filters.Filter filter = FILTERS.key().regex("(?i)rowkey.*");
You can find more filter examples here: https://github.com/GoogleCloudPlatform/java-docs-samples/blob/master/bigtable/snippets/src/main/java/com/example/bigtable/Filters.java
Hope that helps!

Hi @kolea2, I am well aware of it. I was just pointing out that the documentation is incorrect.

Hi @PragyaTripathi,
The flag in difference's documentation refers to RegexStringComparater's constructor param. In case a user sets this param(eg. new RegexStringComparator("a.*", Pattern.CASE_INSENSITIVE)) the Bigtable HBase client ignores the flag.

@PragyaTripathi apologies, I misread your initial post - got it, thank you for filing this!
@cshaff0524 is this something you could take a look at?

Yes, I'll create a docs bug for this. Thanks for the heads up!


Dev to Master

Dave please review this.
Intention is to only house links to the proper starterkit branches or file downloads and instructions
You may also add anything you need to in PHP here before the merge too please

Added my stuff to dev. Feel free to merge.


Tooltipster always show.

I want Tooltipster to be open always, because I want to style it. How can I do that ?

Use an open trigger and no close trigger.

You can do it like this.
('#abc').tooltipster({
trigger: 'custom',
triggerOpen: {
click: true,
touchstart: true,
},
triggerClose: {
click: false,
},
});


BladeDance Constitution check bonus not working

Looks like BladeDance's Constitution check bonus isn't working.
From description:
You have a +4 bonus on Constitution checks.

On the screenshot
+2: CON
+1: Lucky stone
+1: Blessing
The wizard is under the effect of BladeDance, I can not provide a screenshot, I watched the log after the battle.

Can I have your save?

Can I have your save? What are the game and mod versions? GOG or Steam?

it's custom compain with auto translate form UB, but i can send save
UB version <IP_ADDRESS>
Steam

Just checked code and it’s only giving advantage on ability checks instead of savings. Easy fix but save will help me confirm. Share please.

Just checked code and it’s only giving advantage on ability checks instead of savings. Easy fix but save will help me confirm. Share please.
Sure
QuickSave_2.zip

Fixed on dev.


auth.setSession returns AuthRetryableFetchError

Bug report

[x] I confirm this is a bug with Supabase, not with my own application.
[x] I confirm I have searched the Docs, GitHub Discussions, and Discord.

Describe the bug
In my react-native expo app I'm using email sign-up with confirmation and a password reset workflow. I'm creating a session from the confirmation URL sent on sign up the following way.
createSessionFromUrl = async (url) => {
        const { params, errorCode } = QueryParams.getQueryParams(url);
        if (errorCode) throw new Error(errorCode);
        const { access_token, refresh_token } = params;
        if (!access_token) return;

        const { data, error } = await supabase.auth.setSession({
            access_token,
            refresh_token,
        });

        if (error) throw error;
    };

In Expo Go everything works fine. The issue comes when I build my app and test it on my device through TestFlight. Upon receiving and going through the confirmation link to the app, receiving the URL and eventually ending up in the mentioned function supabase.auth.setSession returns an error AuthRetryableFetchError with a status: 0. Apart from happening only on production, the other annoying part is that it's not consistent. Every second or third attempt will fail even tho the URL and the tokens are valid.
It's important to note that receiving a link for password reset goes through the same workflow and always succeeds without issues.
To Reproduce
Because of the nature of the issue I can't give any concrete steps. But any suggestion would be welcome.
Expected behavior
setSession, given valid access_token and refresh_token should always succeed
System information

OS: iOS
Version of supabase-js: "@supabase/supabase-js": "^2.45.6"
Expo version: "expo": "^51.0.37"
React Native: "react-native": "0.74.5"

After speaking with support I was able to mitigate this issue. I'm gonna write down my response and leave it in case someone also stumbles on the same issue.
In short setSession can fail for a multitude of reasons, poor network connection can be one of them.
If we receive an AuthRetryableFetchError we can periodically try again to set the session.
What I ended up doing is this:
const maxRetries = 3;
let attempt = 0;

while (attempt < maxRetries) {
    const { data, error } = await supabase.auth.setSession({
        access_token,
        refresh_token,
    });

    if (!error) {
        return data;
    }

    if (error.name === "AuthRetryableFetchError") {
        attempt += 1;
        await new Promise((resolve) =>
            setTimeout(resolve, 1000 * attempt)
        );
    } else {
        return;
    }
}

Basically try three times to set the session only if it fails with an AuthRetryableFetchError.


persistent connection

Does influxdb-ruby library support a persistent connection to a influxdb?

The InfluxDB::HTTP module does not support persistent connections however the UDP writer does use a persistent connection


allow both HTML and SSH URLs

It can be quite annoying to type in the username and password for many packages. Thus, I added an option to use the SSH URL of repos.

Codecov Report
Base: 13.33% // Head: 12.84% // Decreases project coverage by -0.48% :warning:

Coverage data is based on head (8895515) compared to base (68a1ad6).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #59      +/-   ##
==========================================
- Coverage   13.33%   12.84%   -0.49%
==========================================
  Files           6        6
  Lines         105      109       +4
==========================================
  Hits           14       14
- Misses         91       95       +4

Impacted Files
Coverage Δ

src/public.jl
0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Bump

@timholy Can you review this?


Station -> Add Ship AllSrv crash

Both servers crashed during 7/21/10 beta test at the same place.
http://build.alleg.net/Dumps/Reports/CrashHang_Report__AllSrv.exe__07212010195342797.mht.html
Imported from trac ticket #168,  created by anonymous on 07-22-2010 at 20:37, last modified: 01-09-2011 at 19:57

After review, this is likely being caused by changes for #7
Trac comment by Imago on 07-23-2010 at 03:06

dang, this was supposed to auto close based off commit msg
Trac comment by Imago on 07-23-2010 at 03:20

Milestone R5.1 deleted
Trac comment by pkk on 01-09-2011 at 19:57


Added Java solution for First_missing_positive

Fixes #342
Issue
Given an unsorted integer array nums, return the smallest missing positive integer.
You must implement an algorithm that runs in O(n) time and uses constant extra space.
Describe the changes
I have sorted all elements using Cyclic sort and then,
search out first missing element in an array(nums).

They are not considering dsa,cp,algorithm repository :(
all the pr will not be considered in hacktoberfest but your contribution will be for lifetime, this will help many students to practice dsa .
Thank you for your contribution :)
you can contribute to other repo

Then why you are still labeling to new issues or accepted PR's as hacktoberfest label ?


Azure function error connection

Does this occur consistently?
Repro steps:

Action: azureFunctions.startStreamingLogs
Error type: Error
Error Message: Entry not found in cache.
Version: 1.0.0
OS: win32
OS Release: 10.0.18363
Product: Visual Studio Code
Product Version: 1.50.1
Language: en

Call Stack
s.createError extension.js:16:58035
b.<anonymous> extension.js:393:42004
extension.js:393:36599extension.js:393:36599
extension.js:243:74686extension.js:243:74686
extension.js:243:72667extension.js:243:72667
extension.js:243:72287extension.js:243:72287
i.find extension.js:243:106819
extension.js:243:53526extension.js:243:53526
processTicksAndRejections task_queues.js:94:5

As a workaround you could try reloading your window or signing out and signing back in to your Azure Account using the command palette.
Unfortunately there's not much we can do in this extension, but this is being tracked upstream here: microsoft/vscode-azure-account#53


Fix ipv4 mask restrictions for users and add integration tests

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
For changelog. Remove if this is non-significant change.
Category (leave one):

Bug Fix

Short description (up to few sentences):
Fix bug with wrong prefix for ipv4 subnet masks

Also, fixed compose version to 2.2 because in later version ipv6 network configuration is not available:
https://github.com/docker/compose/issues/4958#issuecomment-311466816


Request

hey dude, i want to request for function helper calling collor theme in php, how ? cause the default collor is green, i need to change it

hey man. You are welcome to send me a PR with changes. My primary language is JS and I work with it in VScode, so I don't have enough expertise in php. Just remember, the main goal of this theme  - is creating a copy of the default theme from Sublime text 3

So in javascript too , the colour of $ is cyan, its should be white.
I'm appreciate for your works , great job
Pada tanggal Sab, 6 Apr 2019 16.41, volosovich<EMAIL_ADDRESS>menulis:

hey man. You are welcome to send me a PR with changes. My primary language
is JS and I work with it in VScode, so I don't have enough expertise in
php. Just remember, the main goal of this theme - is creating a copy of the
default theme from Sublime text 3
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/volosovich/Monokai-ST3-theme-for-vscode/issues/3#issuecomment-480490381,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AalryjjdEXdJjOd_uyQ7Ul3PPSAVZAd1ks5veGvcgaJpZM4cM7By
.

@marvin46 COuld you please send example with code?

of course,
this is a compare picture in the same code
On Mon, Apr 8, 2019 at 2:53 PM volosovich<EMAIL_ADDRESS>wrote:

@marvin46 https://github.com/marvin46 COuld you please send example
with code?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/volosovich/Monokai-ST3-theme-for-vscode/issues/3#issuecomment-480724262,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AalrytQaXZZU5ihJ0OC419KDKmkjRaORks5vevWDgaJpZM4cM7By
.


Edit Mandatory Fields in Site Submission Resource Model

[x] Remove Submission Type mandatory requirement
[x] remove Information Provided as mandatory requirement

@emjohnst  - This leaves nothing on that card that is mandatory. This may cause issues if cards are created with no data at all. I'd suggest we leave at least one value a mandatory on this card.

Can you make requested operation mandatory


What 'type's can I use for placeholders?

Perhaps I've missed something but I've been trolling the inter webs for hours trying to figure this out.
AS far as I can tell I can use the 'String' type for a placeholder like this in a *.arb file:
"workedHoursGraphCriteriaLastNDays": "Last {days} days",
  "@workedHoursGraphCriteriaLastNDays": {
    "placeholders": {
      "days": {
        "type": "String"
      }
    }
  }

That works. Now I want to inject a number but I can't seem to find any docs on what type to specify or in fact, any other types. I tried int but the generator fails saying it isn't supported and to check the NumberFormat class for details. I also tried 'number', 'Number', 'Int', 'int', 'double', 'Decimal' and others. I'd either get told to look at 'NumberFormat' or a compilation failure.
Unfortunately NumberFormat isn't that helpful. It knows nothing of '*.arb' files and I've not been able to find anything on the web that talks about what the options are.
Is there a list of value types somewhere?

Hi @drekka
You don't need to define the types in ARB files for placeholders. It will be enough to define it in ARB file like this:
"workedHoursGraphCriteriaLastNDays": "Last {days} days",
"@workedHoursGraphCriteriaLastNDays": {
    "placeholders": {
       "days": {}
    }
}

Or even just
"workedHoursGraphCriteriaLastNDays": "Last {days} days",

It will generate a key getter that accepts any object for the placeholder, but you might want to format it before you pass it to the string key getter.


This is a simple, difficult to use, and useless project

This is a simple, difficult to use, and useless project
Dette er et simpelt, svært at bruge og ubrugeligt projekt
Este es un proyecto humilde, difícil de usar e inútil.
C'est un projet humble et inutile
Это простой и бесполезный проект.

Ah, this project is a bit useless in some ways, but it has a lower footprint than some Minecraft server management software, usually around 20mb

Generally, in Minecraft server usage scenarios, space consumption is not the primary consideration. The storage space for a Minecraft server increases exponentially when active. For instance, my Minecraft server started with just 9GB, and now it nears 30GB. The decrease of a dozen MB or so has negligible impact. Server administrators prioritize the program's ease of use over space consumption, as seen in web applications. Thank you.

I mean, in the case of the vanilla GUI interface, you usually need a console window followed by a jar built-in gui window. This program simplifies the GUI window and brings the Console into the program, making it easier to manage the server.

Could you highlight any advantages of your program over the original GUI, apart from space occupation? (Actually, your program doesn't have a space occupation advantage over the original GUI either, since it's embedded in the jar and cannot be deleted to save space.)

Ah,my gui can run ever command,and can set Max Menory,Min Memory.It can custom java,Newcomer friendly

Even true beginners will not have channels to find your project, and your GUI is not very user-friendly for beginners

why it's not user-friendly for beginners? It can automatically found java
获取Outlook for Androidhttps://aka.ms/AAb9ysg

From: weyeah @.>
Sent: Friday, August 16, 2024 10:40:38 AM
To: Whirity404/PMSL @.>
Cc: Rubedo332 @.>; State change @.>
Subject: Re: [Whirity404/PMSL] This is a simple, difficult to use, and useless project (Issue #1)
Even true beginners will not have channels to find your project, and your GUI is not very user-friendly for beginners
―
Reply to this email directly, view it on GitHubhttps://github.com/Whirity404/PMSL/issues/1#issuecomment-2292627251, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A5RVDCUZSWCEZPP646ATKNDZRVRCNAVCNFSM6AAAAABMTGXHFSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJSGYZDOMRVGE.
You are receiving this because you modified the open/close state.Message ID: @.***>


New Course Git PT-BR

Please add new course in Git in language PT-BR:
https://www.youtube.com/watch?v=M3aHjXSqFtE&list=PLHbGjxRVA_FmFRF1-OqWaWwqhIiS9Cg0w

For youtube, we prefer "playlist" links and the name of the producer/creator. docs/CONTRIBUTING.md#platforms-and-access-notes

This is an automated response to help you with this issue. Please let us know if you need further assistance.


gh-1212: Fix scope_for_name to catch NameError properly

fix: #1212

@windelbouwman
Please take a look.
The CI test failure looks like not related to this patch.
(I found that https://github.com/RustPython/RustPython/pull/1231 is also failed with the same test)

The build might be fixed on the master branch. If you merge the master branch again into your own branch, the build might succeed.

@windelbouwman
Thanks for the review! Please take a look


Some background images not loading on mobile

Hi, I am using this plugin with Shopify.
I have tested the site on https://developers.google.com/speed/pagespeed/insights/ but I have noticed that lazy loading works on some images but doesn't work on some images on mobile.
It seems it works properly on the desktop.
Javascript
let myLazyLoad;

// Lazyload images
export function initLazyLoad() {
  myLazyLoad = new LazyLoad({
    elements_selector: '.lazyload',
    callback_loaded: function(el) {}
  });
}

export function updateLazyLoad() {
  myLazyLoad.update();
}

initLazyLoad();

$(document).on('shopify:section:load', function() {
  initLazyLoad();
});

$(window).on('popup-loading', function(event) {
  updateLazyLoad();
});

Liquid
<div class="box-item__image lazyload" data-bg="url({{ _block.image | img_url: '1900x' }})">
...
</div>

Did anyone have this issue before?

same issue here used default setup, happened at the end of October, desktop OK but default mobile browsers (chrome  android 9.0 safari iPhoneXS) confirm only some images appearing.

Hey @yu-coder ,
thanks for opening this.
Have you checked the demo about loading background images?
Code here: https://github.com/verlok/lazyload/blob/master/demos/background_images.html
Live demo here: https://www.andreaverlicchi.eu/lazyload/demos/background_images.html
I don't happen to notice any malfunctioning there.
I suggest you to check the final HTML generated from Liquid. Are there any spaces or strange characters in the images URLs? If there are spaces, have you wrapped the images urls inside single quotes (')?

@verlok
It was an issue on my side not on lazyload issue.
I have fixed it so now it works properly.
Sorry for not updating you.
Thank you.

Good to know that you solved.
Thanks


Support nesting for connect mapDispatchToProps?

Example:
connect(() => {...}, {
  noteActions: {
    create: createNote,
    update: updateNote,
    ...
  },
  laneActions: {
    create: createLane
  }
})(Demo);

// at component
this.props.noteActions.create();

This would allow you to namespace actions better. You could even do
connect(() => {...}, {
  noteActions,
  laneActions
})(Demo);

if you want to be terse and don't mind connecting each action. This isn't as maintainable, though.

At the moment I get round this by manually wrapping nested Actions with dispatch
function mapDispatchToProps(dispatch) {
  return {
    noteActions: {
      save: {
        create: () => dispatch(createNote())
      }
    }
  };
}

Obviously this is more verbose but it would get you what you needed.

Using traverse I put together this little util, it might be of use to someone.
// createNestedMapDispatchToProps.js
import traverse from 'traverse';

module export function(obj) {
  return function (dispatch) {
    return traverse(obj).map(function(action) {
      if (this.isLeaf) {
        this.update(function (...args) {
          return dispatch(action(...args));
        });
      }
    });
  };
}

// MyComponent.jsx
import * as bookActions from './actions/books.js'
import * as authorActions from './actions/authors.js'

var mapDispatchToProps = createNestedMapDispatchToProps({
  bookActions,
  authorActions
});

@connect(
  mapStateToProps,
  mapDispatchToProps
)
class MyComponent extends React.Component {
  ...
}

@rockingskier Nice work. Depending on what the maintainers of react-redux think, maybe this should become a little package of its own. That wouldn't be as discoverable, though.

This seems pretty obvious enhancement to me although I wonder whether it encourages writing huge components instead of small composable ones.

maybe this should become a little package of its own

It would be good for test driving at least.

I think the way it is right now is perfect.
This of mapDispatchToProps as factory.
You can do something like this:
function attachBookActions (dispatch, getState, actions) {

}

I think the way it is right now is perfect.
This of mapDispatchToProps as factory.
You can do something like this:
function attachBookActions (dispatch, getState, actions) {
  return assign({}, actions, {bookActions: {getBook: function () {//...}}}
}

function attachAuthorActions (dispatch, getState, actions) {
  return assign({}, actions, {bookActions: {getAuthor: function () {//...}}}
}

function combinePropMappers (factories, dispatch, getState) {
  return factories
          .map(function (factory) {
            return factory.bind(null, dispatch, getState)
          })
          .reduce(function (actions, factory) {
            return factory(actions);
          }, {});
}

var mapDispatchToProps = combinePropMappers.bind(null, [
    attachAuthorActions,
    attachBookActions
  ]);

You can achieve a cleaner code with currying. That's the way I try to write all my apps. I try not to create objects out of nowhere. only functions that reduce other objects.
This gives you the advantage of separating reducers.
For example you'd be able to have book reducers and author reducers.
All contained in the same module. Each module would have it's factories. Or whatever functions that are related to the logic of the reducer.

I'd be wary of including too much convenient opinionated defaults. I generally agree namespacing is nice, but there are potential unwanted side effects too (e.g. an export of some unrelated object from actions.js that we begin to iterate over because of import * as actions—or a recursive object we get stuck on).
The example in API docs actually show namespacing:
import * as todoActionCreators from './todoActionCreators';
import * as counterActionCreators from './counterActionCreators';
import { bindActionCreators } from 'redux';

function mapStateToProps(state) {
  return { todos: state.todos };
}

function mapDispatchToProps(dispatch) {
  return {
    todoActions: bindActionCreators(todoActionCreators, dispatch),
    counterActions: bindActionCreators(counterActionCreators, dispatch)
  };
}

export default connect(mapStateToProps, mapDispatchToProps)(TodoApp);

I don't think it's too much typing, and the upside is it's explicit and non-magic.
I'd prefer to keep it that way.


Pocket getAllChunks

getAllChunks in leveldbpocket.py returns the same chunk multiple times. The function checks if the byte after the chunk location is equal to 47 which is the terrain key however there can be multiple terrain keys. Unless there is a reason why this function needs to return the chunk coords multiple times it should be checking for the version key which is 118

We're looking into this now since we now support the new LevelDB format

Well, I'm not sure why we use specifically use 47 either but I fixed the duplicate issue another way. I'll ask the one who wrote the code why he wrote it like that and we'll see if there's a need to change that.
Thanks for the help and the suggestion, hope you love our changes for this next release so far (Even if there are a few bugs :P)


Makefile colorizing improvement: colorize at the beginning of line, handling the '' symbol and other.

Pull request is created into TextMate repository as well: https://github.com/textmate/make.tmbundle/pull/15
1). Colorize when there is an expression at the beginning of line.
2). Handle '\' at the end of prerequisites (the next line should be colorized as a continuation of previous).
3). Colorize (origin|flavor).
4). Fix colorizing of built-in which stands after a common variable.

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@fadeevab Thanks a lot for your efforts!
The make grammar has been converted from https://github.com/textmate/make.tmbundle/blob/master/Syntaxes/Makefile.plist.
We don't want to maintain our own fork, therefore, if you want to provide a fix or improvement, please create a pull request against the original file.
Once accepted there, we are happy to run the update script and fix the tests.

@fadeevab Sorry for my previous comment, now I see your pull request.
Give it a bit time for the guys at textmate/make.tmbundle to look into it.
If nothing happens there we can think again what to do and if we make an exception and move ahead.

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@aeschli, Sure, thank you! It would be great if somebody review my pull request more carefully. But actually, current makefile colorizing couldn't be worse, so I believe this patch makes one better. At least I tried to test it carefully, that's why I recreated pull request with additional fixes. And also several fixes will come later, because some cases are still not covered.

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

(re-opened because it's closed accidentally from mobile phone)

Nothing happens in the referred pull request. Wait more?

There is some movement in the referred review.
I actualized makefile tests.

A moment ago both builds were ok. Now AppVeyor build failed, I'm sure it doesn't depend on update.
npm ERR! code EBADF
npm ERR! errno -4083
npm ERR! syscall fstat
npm ERR! EBADF: bad file descriptor, fstat

Review is stuck

@aeschli, TextMate review of Makefile syntax is not moving on. What could we do in such case: could we submit?

Let's be patient one more week or so. Creating our own fork is not really what we want as we don't have the resources to maintain it. So given that you got some response on your PR I'd rather wait a bit more.

Right, I just don't want this patch would be sank into oblivion.

What we can do is that we use your fork (https://github.com/fadeevab/make.tmbundle/) as the new input for the make grammar. Would that be ok for you?

you'd have to make sure to keep master in a working state
avoid diverging from the original so that we eventually can unify them again.
Ideally this is only a temporary solution.

Let me know when your repo is ready.

Just let's do this. I agree to send new pull request to the original repo to synchronize our repos, so we can eventually unify them. Also I'll try to take care about new issues, still maybe it worth to duplicate the issues to the original repo.

Thanks @fadeevab !

@fadeevab I'm now consuming your repo. To simplify thing, can you add a MIT licence to your repo?

@aeschli, Done


Explore geographical browse options

Explore use of map view across catalog to indicate one or more of these geographical connections: subject area (FAST subject region), publication location, narrative location

The Solr index is queries for the top 500 (i.e. most frequently used) FAST region headings which are then sent to FAST API which returns a URI.  Wikidata is queried for entities that match this FAST URI and coordinates are then retrieved.  The browse maps page uses leaflet to put these as point coordinates on the map, with the catalog search URL in the popup.  Clicking the search link retrieves results from the catalog and displays them in the page.


Linguist didn't detect languages in repository

Following are the two repositories
https://github.com/instinxt/Tinder-clone
https://github.com/instinxt/Tiktok-clone

The languages weren't detected on these repositories
All i did was remote push and set the master as default git base branch , whilst deleting the main branch

Looks like to job that does the analysis failed when you pushed. Pushing another change will kick off the job again.


Add new route tree state management system

:eyeglasses: @keybase/react-hackers
See https://github.com/keybase/client/pull/4681 for some design notes.

Core router code is in "Add new route tree state management system". Happy to walk through the code with anyone who is interested.

Updating all the previous router usages is in "Overhaul routes to route tree structure". This also contains some cleanup of the Nav TabBar code to flatten away logic. The top-level component is now called <Main>. <Nav> is a renders a container around the current screen content with a nav bar.

On the mobile side, this switches to using NavigationExperimental and removes the native-esque header title. Screens can now bleed underneath the status bar. This is implemented in "Add status bar height bleed to some views".

I have attempted to manually test all of these routes, but there's the possibility I've missed a case. We should QA this for a little while internally to make sure there's no critical breakage (+ pause builds?).

I'd like to add tests for the core route functions, but will break that into another ticket.

@MarcoPolo Updated for your comments, thanks! Also merged w/ current master.

The commits e7e67b557222...95e5c4fd8ca1 introduce visual changes on linux. :mag_right: 4 new, 3 removed, 3 changed

Added: Settings_Container-Normal_Good_Banner

Added: Settings_Container-Normal_Bad_Banner

Added: Settings_Container-Normal

Added: Profile-Your_Profile_Following_Tab

Changed: Folders_TLF-Normal_Public (before) (after)

Changed: App_Tab_Bar-Search_Active (before) (after)

Changed: App_Tab_Bar-Normal (before) (after)

Removed: Settings_Nav-Normal_Good_Banner (view original)
Removed: Settings_Nav-Normal_Bad_Banner (view original)
Removed: Settings_Nav-Normal (view original)

The commits e7e67b557222...24b39131d64c introduce visual changes on linux. :mag_right: 4 new, 3 removed, 3 changed

Added: Settings_Container-Normal_Good_Banner

Added: Settings_Container-Normal_Bad_Banner

Added: Settings_Container-Normal

Added: Profile-Your_Profile_Following_Tab

Changed: Folders_TLF-Normal_Public (before) (after)

Changed: App_Tab_Bar-Search_Active (before) (after)

Changed: App_Tab_Bar-Normal (before) (after)

Removed: Settings_Nav-Normal_Good_Banner (view original)
Removed: Settings_Nav-Normal_Bad_Banner (view original)
Removed: Settings_Nav-Normal (view original)

The commits e7e67b557222...16fcc840c896 introduce visual changes on linux. :mag_right: 4 new, 3 removed, 3 changed

Added: Settings_Container-Normal_Good_Banner

Added: Settings_Container-Normal_Bad_Banner

Added: Settings_Container-Normal

Added: Profile-Your_Profile_Following_Tab

Changed: Folders_TLF-Normal_Public (before) (after)

Changed: App_Tab_Bar-Search_Active (before) (after)

Changed: App_Tab_Bar-Normal (before) (after)

Removed: Settings_Nav-Normal_Good_Banner (view original)
Removed: Settings_Nav-Normal_Bad_Banner (view original)
Removed: Settings_Nav-Normal (view original)

@MarcoPolo Could I please have a review of these tiny fixes? Should be really quick.

The commits c70ceccceb9a...ec6e453363ba introduce visual changes on linux. :mag_right: 4 new, 3 removed, 3 changed

Added: Settings_Container-Normal_Good_Banner

Added: Settings_Container-Normal_Bad_Banner

Added: Settings_Container-Normal

Added: Profile-Your_Profile_Following_Tab

Changed: Folders_TLF-Normal_Public (before) (after)

Changed: App_Tab_Bar-Search_Active (before) (after)

Changed: App_Tab_Bar-Normal (before) (after)

Removed: Settings_Nav-Normal_Good_Banner (view original)
Removed: Settings_Nav-Normal_Bad_Banner (view original)
Removed: Settings_Nav-Normal (view original)

The commits c70ceccceb9a...9793a5e41d9d introduce visual changes on linux. :mag_right: 4 new, 3 removed, 6 changed

Added: Settings_Container-Normal_Good_Banner

Added: Settings_Container-Normal_Bad_Banner

Added: Settings_Container-Normal

Added: Profile-Your_Profile_Following_Tab

Changed: unlock_folders-Single (before) (after)

Changed: Pinentry-Paper_Key_Normal (before) (after)

Changed: Pinentry-Paper_Key_Error (before) (after)

Changed: Folders_TLF-Normal_Public (before) (after) (diff)
Changed: App_Tab_Bar-Search_Active (before) (after) (diff)
Changed: App_Tab_Bar-Normal (before) (after) (diff)
Removed: Settings_Nav-Normal_Good_Banner (view original)
Removed: Settings_Nav-Normal_Bad_Banner (view original)
Removed: Settings_Nav-Normal (view original)

The commits c70ceccceb9a...c702742b5bd8 introduce visual changes on linux. :mag_right: 1 new, 6 changed

Added: Profile-Your_Profile_Following_Tab

Changed: Settings_Nav-Normal_Good_Banner (before) (after)

Changed: Settings_Nav-Normal_Bad_Banner (before) (after)

Changed: Settings_Nav-Normal (before) (after)

Changed: Folders_TLF-Normal_Public (before) (after)

Changed: App_Tab_Bar-Search_Active (before) (after)

Changed: App_Tab_Bar-Normal (before) (after)

The commits c70ceccceb9a...f462e8a923bf introduce visual changes on linux. :mag_right: 1 new, 6 changed

Added: Profile-Your_Profile_Following_Tab

Changed: Settings_Nav-Normal_Good_Banner (before) (after)

Changed: Settings_Nav-Normal_Bad_Banner (before) (after)

Changed: Settings_Nav-Normal (before) (after)

Changed: Folders_TLF-Normal_Public (before) (after)

Changed: App_Tab_Bar-Search_Active (before) (after)

Changed: App_Tab_Bar-Normal (before) (after)

The commits c70ceccceb9a...185ebdbe02cb introduce visual changes on linux. :mag_right: 1 new, 6 changed

Added: Profile-Your_Profile_Following_Tab

Changed: Settings_Nav-Normal_Good_Banner (before) (after)

Changed: Settings_Nav-Normal_Bad_Banner (before) (after)

Changed: Settings_Nav-Normal (before) (after)

Changed: Folders_TLF-Normal_Public (before) (after)

Changed: App_Tab_Bar-Search_Active (before) (after)

Changed: App_Tab_Bar-Normal (before) (after)

The commits c70ceccceb9a...f600d4860619 introduce visual changes on linux. :mag_right: 1 new, 6 changed

Added: Profile-Your_Profile_Following_Tab

Changed: Settings_Nav-Normal_Good_Banner (before) (after)

Changed: Settings_Nav-Normal_Bad_Banner (before) (after)

Changed: Settings_Nav-Normal (before) (after)

Changed: Folders_TLF-Normal_Public (before) (after)

Changed: App_Tab_Bar-Search_Active (before) (after)

Changed: App_Tab_Bar-Normal (before) (after)

The commits c70ceccceb9a...9d2951e45ef3 introduce visual changes on linux. :mag_right: 1 new, 6 changed

Added: Profile-Your_Profile_Following_Tab

Changed: Settings_Nav-Normal_Good_Banner (before) (after)

Changed: Settings_Nav-Normal_Bad_Banner (before) (after)

Changed: Settings_Nav-Normal (before) (after)

Changed: Folders_TLF-Normal_Public (before) (after)

Changed: App_Tab_Bar-Search_Active (before) (after)

Changed: App_Tab_Bar-Normal (before) (after)

The commits c70ceccceb9a...9cd95e431401 introduce visual changes on linux. :mag_right: 1 new, 7 changed

Added: Profile-Your_Profile_Following_Tab

Changed: Settings_Nav-Normal_Good_Banner (before) (after)

Changed: Settings_Nav-Normal_Bad_Banner (before) (after)

Changed: Settings_Nav-Normal (before) (after)

Changed: Paper_Key-Normal (before) (after)

Changed: Folders_TLF-Normal_Public (before) (after)

Changed: App_Tab_Bar-Search_Active (before) (after)

Changed: App_Tab_Bar-Normal (before) (after) (diff)

The commits c70ceccceb9a...9cd95e431401 introduce visual changes on linux. :mag_right: 1 new, 6 changed

Added: Profile-Your_Profile_Following_Tab

Changed: Settings_Nav-Normal_Good_Banner (before) (after)

Changed: Settings_Nav-Normal_Bad_Banner (before) (after)

Changed: Settings_Nav-Normal (before) (after)

Changed: Folders_TLF-Normal_Public (before) (after)

Changed: App_Tab_Bar-Search_Active (before) (after)

Changed: App_Tab_Bar-Normal (before) (after)

The commits c36e584230a2...d1fb30edac97 introduce visual changes on linux. :mag_right: 1 new, 6 changed

Added: Profile-Your_Profile_Following_Tab

Changed: Settings_Nav-Normal_Good_Banner (before) (after)

Changed: Settings_Nav-Normal_Bad_Banner (before) (after)

Changed: Settings_Nav-Normal (before) (after)

Changed: Folders_TLF-Normal_Public (before) (after)

Changed: App_Tab_Bar-Search_Active (before) (after)

Changed: App_Tab_Bar-Normal (before) (after)


Trying to upload a file and getting false == true error

Trying to upload a file (caa. 800MB) via swarm-cli returns an error, see screenshot:

This happens quite quickly after confirming, probably the upload does not even start.
Expected behavior: a more descriptive error message returned.

I get the same error in bee dev mode (macbook) on any file upload

downgrading node version from 18 to 16 fixed this for me


adding sample of stateful app

Describe stateful service 1 and stateful service 2 and what their differences are.


6x ore production for 1.17+

when minecraft introduced raw form for every ore. This allowed mekanis with fortune 3 to make 6.6-13.3x ore processing and now irradiating ore for 6x thas't sound that great. Maybe consider updating this feature for newer version.

13.3x u serious?
Ok then we need to change loot tables for irradiated ores. So it will drop 50% plus raw chunks.


Fixing code smell for config/repo_config.go

Description
Fixed minor code smell issue (see screenshot) in config/repo_config.go.

Fixes # (issue)
Type of change
What is it?

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Documentation update
[ ] Tests update
[x] Refactor

Checklist:

[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[ ] I run make pre-commit to check fmt/vet/lint/test-no-fdo

Codecov Report
Base: 38.16% // Head: 38.12% // Decreases project coverage by -0.03% :warning:

Coverage data is based on head (e3ae64e) compared to base (af84c89).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1656      +/-   ##
==========================================
- Coverage   38.16%   38.12%   -0.04%
==========================================
  Files          66       66
  Lines        8970     8970
==========================================
- Hits         3423     3420       -3
- Misses       5143     5145       +2
- Partials      404      405       +1

Impacted Files
Coverage Δ

pkg/services/devices.go
50.10% <0.00%> (-0.33%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

ACK


Resolve issue with unused tx_number field in block structure

Description of the Change
IR157
An un-used variable tx_number was present in the block schema.
Benefits
Less space will be used by a block.
Possible Drawbacks
None

Hi, @namitkrarya. Congratulations on your first Iroha PR!
Your idea is very sensible. Unfortunately, we have at least two reasons not to make that change right now:

Removing a field from block is a backward-incompatible change (since block's hashes become different) and prefer to avoid them at this point, at least before we make Iroha fully backwards compatible with different block versions (v2 in this case).
Another mechanism for limiting amount of transactions in a block should be designed. It could be a stateless validation rule of something different. At the moment we are not sure.

Thank you for mentioning that, it does seem outdated. But we need to have a discussion about how to make the change and what alternative design to use.


munge: 0.5.14 -> 0.5.15

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/dun/munge/releases.
meta.description for munge is: "An authentication service for creating and validating credentials\n"
meta.homepage for munge is: ""
meta.changelog for munge is: ""
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.5.15 with grep in /nix/store/36j7k2rj8382wqj573yp8waq136pks6d-munge-0.5.15
found 0.5.15 in filename of file in /nix/store/36j7k2rj8382wqj573yp8waq136pks6d-munge-0.5.15

Rebuild report (if merged into master) (click to expand)

231 total rebuild path(s)

231 package rebuild(s)

First fifty rebuilds by attrpath
EBTKS
apacheHttpdPackages.mod_tile
apacheHttpdPackages_2_4.mod_tile
bicgl
bicpl
cdo
cloudcompare
cntk
conglomerate
cp2k
crystfel
crystfel-headless
diod
dl-poly-classic-mpi
eccodes
elmerfem
elpa
ezminc
febio
freecad
gdal
gdal_2
getdp
globalarrays
gmt
gnudatalanguage
gplates
gpt2tc
grass
gromacsCudaMpi
gromacsDoubleMpi
gromacsMpi
haskellPackages.haskell-mpi
hdf5-mpi
highfive-mpi
hp2p
hpcg
hpl
inormalize
ior
lammps-mpi
libLAS
libminc
librsb
libtensorflow
mapcache
mapnik
mapproxy
mapserver
merkaartor

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/36j7k2rj8382wqj573yp8waq136pks6d-munge-0.5.15 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A munge https://github.com/r-ryantm/nixpkgs/archive/3957ab13791c2df3cd324310dc86a5605ea011ec.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/36j7k2rj8382wqj573yp8waq136pks6d-munge-0.5.15
ls -la /nix/store/36j7k2rj8382wqj573yp8waq136pks6d-munge-0.5.15/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
nixpkgs-review took longer than 45m and timed out

Maintainer pings
cc @rickynils for testing.

@ofborg build munge

@GrahamcOfBorg test slurm

https://github.com/dun/munge/releases/tag/munge-0.5.15


STORM-2296 Kafka spout no dup on leader changes,  1.x-branch

Current behavior of Kafka spout emits duplicate tuples whenever Kafka topic leader's change.
In case of exception caused by leader changes, PartitionManagers are simply recreated losing the state about which tuples were already emitted and new PartitionManager re-emits them again.
This is fine as at-least-once is fulfilled, but still it would be better to not emit duplicate data if possible.
Moreover this could be easily avoided by moving the state related to emitted tuples from old PartitionManager to new one.

@ernisv
Looks good. Minor nits. Build failing is unrelated.

+1

@ernisv
Could you squash your commits into one?
STORM-2296 Kafka spout no dup on leader changes would be sufficient to new commit title, and you can describe current commits' titles to the body.
I can handle it if you mind, but then you need to close this PR manually after merging, since Github auto-close doesn't work against non-master branch.

Ok, I've squashed all the changes to single commit.


Add support for missing values when constructing from list of dicts

Other changes:

Make default str column type a PandasColumn

Codecov Report

Merging #139 (aba4434) into dev (abc701d) will decrease coverage by 0.53%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev     #139      +/-   ##
==========================================
- Coverage   83.32%   82.79%   -0.54%
==========================================
  Files          46       46
  Lines        2813     2720      -93
  Branches      479      482       +3
==========================================
- Hits         2344     2252      -92
- Misses        367      368       +1
+ Partials      102      100       -2

Flag
Coverage Δ

unittests
82.79% <100.00%> (-0.54%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

meerkat/columns/abstract.py
83.24% <100.00%> (-0.27%)
:arrow_down:

meerkat/columns/numpy_column.py
87.25% <100.00%> (-0.37%)
:arrow_down:

meerkat/datapanel.py
90.78% <100.00%> (-0.38%)
:arrow_down:

meerkat/pipelines/entitydatapanel.py
70.83% <100.00%> (-0.79%)
:arrow_down:

meerkat/columns/list_column.py
67.50% <0.00%> (-3.93%)
:arrow_down:

meerkat/columns/spacy_column.py
48.07% <0.00%> (-2.84%)
:arrow_down:

meerkat/mixins/collate.py
75.00% <0.00%> (-2.78%)
:arrow_down:

meerkat/cells/imagepath.py
66.66% <0.00%> (-2.57%)
:arrow_down:

meerkat/columns/cell_column.py
70.96% <0.00%> (-2.57%)
:arrow_down:

meerkat/cells/spacy.py
44.44% <0.00%> (-1.99%)
:arrow_down:

... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abc701d...aba4434. Read the comment docs.


feat: use latest amazon-managed codebuild image

This, among other things, has Node v16 and NPM >= v7 in the CodeBuild job that synthesizes the CDK application. This should mitigate some of the issues that can occur when using older Node and NPM versions.

Tilstrekkelig utdatert til at vi heller håndterer dette dersom problemet/symptomene viser seg på nytt


Vulkan works - dxvk doesn't (empty d3d11.log and dxgi.log files)

Hey,
I've been trying to get dxvk running for some hours now but to no avail.
I can confirm that Vulkan via Wine does work as intended (cube.exe works, etc).
When trying to run any game with dxvk via the following command
DXVK_HUD=1 DXVK_LOG_LEVEL=debug DXVK_DEBUG_LAYERS=1 WINEPREFIX=/home/user/.wineCustom/dxvk64/ WINEDEBUG=-all,+vulkan wine64 /path/to/game.exe &> output.txt
the game will just start with usual DX11. The game_d3d11.log and game_dxgi.log files are just empty and output.txt is empty as well (since no vulkan messages get logged).
I'm kinda sure that my setup is right, since I tried it manually a few times and via setup scripts. I also tried different Wine versions, different Windows Vulkan SDK versions and a 32bit prefix.
Does someone know how to tackle this problem? Since I can't even get debug messages, I don't know how to proceed..
System information

GPU: NVidia GTX 970
Driver: 390.42-3
Wine version: 3.4-staging-pba, 3.4-staging, 3.4
DXVK version: 0.31-4
VulkanSDK version: <IP_ADDRESS>, <IP_ADDRESS>, <IP_ADDRESS>
(bold = my main versions)

Log files

$WINEPREFIX/drive_c/Program\ Files\ (x86)/VulkanRT/<IP_ADDRESS>/vulkaninfo.exe:
vulkaninfo.txt

Which game are you even trying to run?

Guild Wars 2, Battlerite and Minion Masters were used for testing but mainly GW2, since it doesn't require Steam

Make sure that both 32 bit and 64 bit vulkan applications run btw

GW2 doesn`t support d3d 10/11

In general, if the log files are empty, the game loads the D3D11 and DXGI DLLs, but doesn't use them at all. Make sure to run your games in Dx11 mode, if available.

@Guy1524  Yes, they do.
@steemandlinux  Damn, I could have sworn it uses dx11. No wonder why dxvk doesn't work. I'm certain the other two do use dx11, though.
@doitsujin So some applications load these DLLs even if they don't use them? That's definitely not the case for all directx applications. Right now I tested WoW-3.3.5a and it was running 100% d3d9 without generated log files from dxvk.
Anyways, I had the GOG copy of Witcher 3 laying around and - in fact - it works as intended. Seems like I just tested the wrong game(s)..
Some more testing: It seems like just UNITY games are affected. I can confirm that the two games in question (see above, BR and MM) start in d3d11 mode but don't generate an output in their log files. On the other hand FFXV (on the same prefix and steam.exe) does. If anyone can confirm a similar behavior, let me know and we should open a separate issue for this.
Nonetheless, I'll close this issue. Thanks for the help! I Hope the information can help others as well.


Navigation [DESTINATION_NAME]  is unknown to this navController after calling navigateUp in Observer

I have 3 fragments = Fragment A, Fragment B, and Fragment C
now I'm on Fragment B, I try to move back to the previous fragment which is Fragment A and call Navigation.findNavController(view).navigateUp() from Observer ViewModel and after that, I try to move to another fragment which is Fragment C and call  Navigation.findNavController(view).navigate(R.id.fragment_c) but I get an error Navigation [DESTINATION_NAME]  is unknown to this navController and the app was force closed
Here is my code
viewModel.dataUpdateBackend.observe(this, Observer {           isSuccessful ->  if (isSuccessful){                 Toast.makeText(context, activity?.getString(R.string.toast_data_berhasil_dikirim), Toast.LENGTH_LONG).show() Navigation.findNavController(imageView_arrowBack).navigateUp()             }         })

Please file Navigation library bugs on the issue tracker with a sample project that reproduces your issue.

add throwable in subscribe method
 itemAdapter.observeClickListener().subscribe ({             bundle.putSerializable("ui",it)             view?.findNavController()?.navigate(R.id.action_uiFragment_to_detailFragment, bundle)         },{             t ->             t.message?.let { onError(it) }         }).addTo(compositeDisposable)


Feature/tuya panel szos sdk

Owner

[x] Nickname(Tuya): Tuya-panel-szos-sdk
[x] Intra-group review（组内审阅人员）：羲之

Description
Please provide a brief summary of the changes. If it is related to an issue, please bring the issue number, like fixes #${number}.
Package
Please select the relevant package.

[ ] tuya-panel-animation-sdk
[ ] tuya-panel-api
[ ] tuya-panel-electrician-sdk
[ ] tuya-panel-ipc-sdk
[ ] tuya-panel-lamp-sdk
[ ] tuya-panel-lock-sdk
[ ] tuya-panel-robot-sdk
[ ] tuya-panel-outdoor-sdk
[x] tuya-panel-szos-sdk

Type of change
Please select the relevant option.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] This change requires a documentation update

Self CheckList
Please check all options.

[x] Intra-group review
[x] ESLint lint
[x] Example Run
[x] Jest Run
[x] No Grammer Error
[x] No Spell Error
[x] No Merge Conflict

Codecov Report

Merging #153 (768a997) into main (9ed54c2) will increase coverage by 0.17%.
The diff coverage is 76.64%.

@@            Coverage Diff             @@
##             main     #153      +/-   ##
==========================================
+ Coverage   64.32%   64.50%   +0.17%
==========================================
  Files         268      271       +3
  Lines       10117    10254     +137
  Branches     2280     2300      +20
==========================================
+ Hits         6508     6614     +106
- Misses       3597     3628      +31
  Partials       12       12

Impacted Files
Coverage Δ

...panel-szos-sdk/src/components/turn-plate/index.tsx
70.83% <70.83%> (ø)

...dk/src/components/simple-vertical-slider/index.tsx
77.67% <77.67%> (ø)

packages/tuya-panel-szos-sdk/src/res/index.ts
100.00% <100.00%> (ø)

...anel-lock-sdk/src/date-picker-range/datePicker.tsx
84.78% <0.00%> (+0.32%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ed54c2...768a997. Read the comment docs.

@zesenzhu  commit 格式不对，另外不能有中文


Add links to linked objects on the measure details tab

TP-2000-971 Add links to linked objects on the measures detail tab page
Why
A measure is linked with a bunch of other things viewable objects on TAP, so it makes sense to have links to see them easily.
What
This PR adds links to the measures details (core data) tab for:

Measure generating regulation,  and adds the title too..
Commodity Code
Additional Code
Geographical area
Geographical exclusions
Quota order number

Checklist

Requires migrations? - no
Requires dependency updates? - no

Before:

After:

Codecov Report
Patch coverage: 87.93% and project coverage change: -0.15% :warning:

Comparison is base (c753cd0) 92.61% compared to head (25fc1dc) 92.46%.
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #990      +/-   ##
==========================================
- Coverage   92.61%   92.46%   -0.15%
==========================================
  Files         435      444       +9
  Lines       30855    31776     +921
  Branches     2342     2420      +78
==========================================
+ Hits        28575    29382     +807
- Misses       1821     1919      +98
- Partials      459      475      +16

Files Changed
Coverage Δ

commodities/forms.py
100.00% <ø> (+11.47%)
:arrow_up:

commodities/tests/test_forms.py
100.00% <ø> (ø)

commodities/tests/test_views.py
100.00% <ø> (ø)

commodities/urls.py
100.00% <ø> (ø)

commodities/views.py
97.54% <ø> (-0.26%)
:arrow_down:

common/views.py
82.87% <0.00%> (-0.78%)
:arrow_down:

geo_areas/tests/test_forms.py
100.00% <ø> (ø)

importer/tests/management/commands/base.py
100.00% <ø> (ø)

publishing/models/envelope.py
90.96% <ø> (ø)

publishing/storages.py
100.00% <ø> (ø)

... and 40 more

... and 3 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


embedded bots: Consistently use 'storage' instead of 'state.'

If agreed on BotStorageData, we should rename BotUserConfigData as well. I'll update this in python-zulip-api as soon as we have discussed on how to proceed with the caching thingy.

lgtm, merged, thanks @roberthoenig!  What name are you thinking about for config data -- BotConfigData?  that seems reasonable as a new name.

Yeah, BotConfigData was what I had in mind.

Yeah, that would be an improvement.


Broken imports (pre-transpiled code) on v1.0.0-beta.1

@oliviertassinari I just updated to try out the new beta.
Importing style utilities is broken:
import { withStyles, createStyleSheet } from 'material-ui/styles';

I found out that style folder in material-ui module is pre-transpiled! How come?
Sources:
export { default as MuiThemeProvider } from './MuiThemeProvider';
export { default as createStyleSheet } from './createStyleSheet';
export { default as withStyles } from './withStyles';
export { default as withTheme } from './withTheme';
export { default as createMuiTheme } from './theme';
export { default as createTypography } from './typography';
export { default as createBreakpoints } from './breakpoints';
export { default as createPalette } from './palette';

Published:
'use strict';

Object.defineProperty(exports, "__esModule", {
  value: true
});

var _MuiThemeProvider = require('./MuiThemeProvider');

Object.defineProperty(exports, 'MuiThemeProvider', {
  enumerable: true,
  get: function get() {
    return _interopRequireDefault(_MuiThemeProvider).default;
  }
});

var _createStyleSheet = require('./createStyleSheet');

Object.defineProperty(exports, 'createStyleSheet', {
  enumerable: true,
  get: function get() {
    return _interopRequireDefault(_createStyleSheet).default;
  }
});

var _withStyles = require('./withStyles');

//etc etc

Additional thought: nowadays published ES6 modules should be compiled on hosting environment and not being published precompiled because only the final developer knows where the app is going to run!
That's why we have babel-env.
ES6 published modules should be identified by the jsnext:main entry in package.json.
Easy as the following in the webpack.config.js for anyone who may need this:
const jsnextMainNotFound = filename => {
    if(!filename.includes('node_modules') || filename.includes('lodash'))
        return false;
    const packageFile = filename.replace(/(.+node_modules\/)(@.+?\/)?(.+?\/)(?:.+)?/, '$1$2$3package.json');
    const pkg = require(packageFile);
    return !pkg['jsnext:main'];
};

rules: [{
            test: /\.(js|mjs)$/i,
            exclude: jsnextMainNotFound,
            use: [{
                loader: 'babel-loader',
            }],
        },{

react-router use an interesting approach. They have an es folder.

Oh I didn't know about it. IMHO that's a very wrong direction.
ES should be the normality today, not the exception.
How do you think I can solve this for now? Main modules are es while nested ones are transpiled. 🤔

People would have to do the following change with react-router-dom solution.
-import { withStyles, createStyleSheet } from 'material-ui/styles';
+import { withStyles, createStyleSheet } from 'material-ui/es/styles';

Not good.

Additional thought: nowadays published ES6 modules should be compiled on hosting environment and not being published precompiled because only the final developer knows where the app is going to run!

I don't agree. As far as I know, babel isn't transpiling the node_modules by default. So we have to target the lowest environment we support, hence ES2015. The only difference is how the import/export syntax is handled.
Still, what's the error? I don't see why the linked example wouldn't work.

I did investigate more because the exported objects from the compiled js were supposed to work anyway.
It turned out a mistmatch between material-ui versions between modules!
Fool me once... closing this and sorry for bothering as always.
@oliviertassinari I'd like to stay tuned on the "ES module publishing" matter: do you lean toward a particular approach?
For instance: do you think the correct approach today is to publish both transpiled and untranspiled code?
For the former, what environment would you assume as the lowest to support?

what environment would you assume as the lowest to support?

I think that we should be using babel-env targeting the following platforms.

do you think the correct approach today is to publish both transpiled and untranspiled code?

I think that we should be publishing a true es version. I don't think that only having a index.es.js file is enough.


Builtin name

We use prefix _builtin_riscv*  to define builtins for RISC-V vector and other extensions in LLVM, can we keep consistancy to use the same prefix to define the same builtins for P extension?
See clang/include/clang/Basic/BuiltinsRISCV.def for detail.

I think this is not a problem but only intrinsic function interfaces are defined in p spec. The spec does not specify compiler built-in style.  This issue should be discussed in riscv-non-isa/riscv-c-api-doc#19.


bug in user_informer middleware

Hi,
I think I stumbled across a bug in the user_informer - for me it always showed the same error id (always that of the first error to occur after an app restart), even if new errors were created. Reason: in user_informer.rb you're putting the replacement text into a global, which isn't a good thing imho as the middleware instance appears to be re-used across requests. Update: While the global might be fine (as long as no threads are involved), using it as a cache with ||= isn't.
Happened to me in a Rails 2.3.14 / 1.8.7 / Passenger environment, and removing the global fixed it.
Cheers,
Jens

Thank you for this contribution! Added a variant to the Airbrake repository: https://github.com/airbrake/airbrake/commit/b35c8c8946e5589bc3f86d98a144c63822f09c0a
This repository is going away shortly and won't reflect the pull.


"Error: Undefined array key "host" -  "mongodb/laravel-mongodb": "v4.0.0-ALPHA1"

Laravel-mongodb Version: "v4.0.0-ALPHA1"
PHP Version: "^8.1"
Database Driver & Version: php_mongodb-1.16.2-8.1-nts-x64

Description:
Steps to reproduce

install Laravel-mongodb Version: "v4.0.0-ALPHA1
Configure database.php with

'connections' => [

        'mongodb' => [
            'driver' => env('MONGO_DB_CONNECTION'),
            'dsn' => env('MONGO_DB_URI'),
            'database' => env('MONGO_DB_DATABASE'),
]]

Create a model and try a post request

<?php

namespace App\Models;
use MongoDB\Laravel\Eloquent\Model;
class Test extends Model
{
    protected $connection = 'mongodb';

    protected $fillable = [
        'Test'
    ];
}

----------

<?php

namespace App\Http\Controllers;

use App\Models\Json;
use Illuminate\Http\Request;
class JsonController extends Controller
{
 public function postTestForm(Request $request)
    {
        try {
            $test = Test::create([
                'Test' => $request->get('test'),

            ]);
            $test->save();

            return 'success test has been successfully created';
        } catch (\Exception $e) {
            return 'Error: ' . $e->getMessage();
        }
    }
}

Expected behaviour
I should get a new object  in my  database.
Actual behaviour
First, I never had to specify a 'host' with laravel 9 and jenssegers/mongodb but now i got ' "Error: Undefined array key "host""'.
So i have tried to had a host in my database config.
Then, when I try another time to postTestForm with the host added I got a return 'success test has been successfully created' but nothing is created in my database.
I have tried with v4.0.0-ALPHA1 and v4.0.0-ALPHA2.
I don't have this problem with laravel 9 and jenssegers package.

Was a mistake from me so not a problem but I can't delete the post. Thank you

Note that you can upgrade to 4.0.0-rc1.

Was a mistake from me so not a problem but I can't delete the post. Thank you

No worries. Want was your mistake and the solution if someone else have this problem. Sometime we can improve error messages.

Was a mistake from me so not a problem but I can't delete the post. Thank you

I have the same problem, can you explain this issue for me?

In your configuration, you must provide either dsn or host parameter. https://www.mongodb.com/docs/drivers/php/laravel-mongodb/current/fundamentals/connection/connect-to-mongodb/#connection-example


Sometimes crash on low-end android devices

Hi , I have a problem with Interstitial ad. After It loaded, showed and closed. It is still there, my question is how can I destroy it ? Because it take too much image memory which make my app crash so often in some weak android devices, I just found this bug in 2 days ago and lost so many customers because of it >.< I saw removeBanner() function, does it work for Interstitial ad ? Thank you so much.
P/S : This bug is only on real mode. Test mode works perfectly.

I found many topics on lots of forum , they all have same issue and seems no clue to fix it... or I did't find it yet ...

The admob interstitial object is a one-time object, once it's dismissed (when user click X to close it), it will be destroyed automatically.
As to when the memory will be released, it will be depends on the JVM garbage collection settings.

Sorry for the title of the topic, because I didn't know exactly what the problem is. I'm still looking for the solution to fix it.

Why you think it's cause by AdMob Ads? Any crash error report, logs or analysis as evidence or clues?

Because I tested it in many ways, test mode is perfect, nothings happened. The real mode cause the fps of the game dropped in few seconds and make app closed or crashed if the device is really weak, as my testing device Dragon Touch Y88, or some vdevices have 512 mb. Many forum reported it as Admob ad bug. I just found a solution is choose the ad to show as text or image only to fix this. i

I found it here https://shatter-box.com/knowledgebase/troubleshooting/  Fix lags Admob plugin. I'm testing it.

I see. It might be when admob sdk loading resource from server. Using text ad only may reduce the risk of crash as less resource required.

The fps drop happened only after the ad is showed and closed.

It goes completely well now. Follow above instruction fixed it. I checked to show Image ad only, and uncheck text ad in Setting of the Admob ad.

Nice to hear that your issue is resolved. I think the experience is useful to other guys too. Thanks.

Hi Raymond, today I tried to run my ad with low battery on same my testing Android tablet, the bug is still there. No idea >< I think it isn't resolved with above config.

The game has crashed many times I tried today.

The ad is keep loading after closed. I think somethings happened with adView.stopLoading();  function. I need to figure it out ...


is it possible to generate reply based on multiple questions

Bot: what is your favorite color?
User: red
Bot: do you like sweet?
User: yes
Bot: do you like fruits?
User: yes
Bot: i guess you like apple?
Does Chatterbot able to perform such kind of conversation?

Currently this is not possible.

how about creating new logic adaptor ?

If you create a new logic adapter that performs the desired functionality, then yes.