SQLite database is not being created

When I run with mvn javafx:run it shows this error:
C:\Users\fvarrui\GitHub\GistFX>mvn javafx:run
[INFO] Scanning for projects...
[INFO]
[INFO] -----------------------< com.redmondsims:GistFX >-----------------------
[INFO] Building GistFX 3.3.6
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] >>> javafx-maven-plugin:0.0.8:run (default-cli) > process-classes @ GistFX >>>
[INFO]
[INFO] --- maven-resources-plugin:2.6:resources (default-resources) @ GistFX ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 89 resources
[INFO]
[INFO] --- maven-compiler-plugin:3.10.0:compile (default-compile) @ GistFX ---
[INFO] Nothing to compile - all classes are up to date
[INFO]
[INFO] <<< javafx-maven-plugin:0.0.8:run (default-cli) < process-classes @ GistFX <<<
[INFO]
[INFO]
[INFO] --- javafx-maven-plugin:0.0.8:run (default-cli) @ GistFX ---
jdbc:sqlite:C:\Users\fvarrui\AppData\Local\GistFX\SQLite\Database.sqlite
*** SQLite.createSchema ***
[SQLITE_ERROR] SQL error or missing database (incomplete input)
org.sqlite.SQLiteException: [SQLITE_ERROR] SQL error or missing database (incomplete input)
        at org.sqlite.core.DB.newSQLException(DB.java:1030)
        at org.sqlite.core.DB.newSQLException(DB.java:1042)
        at org.sqlite.core.DB.throwex(DB.java:1007)
        at org.sqlite.core.NativeDB._exec_utf8(Native Method)
        at org.sqlite.core.NativeDB._exec(NativeDB.java:97)
        at org.sqlite.jdbc3.JDBC3Statement.executeUpdate(JDBC3Statement.java:102)
        at com.redmondsims.gistfx@3.3.6/com.redmondsims.gistfx.data.SQLite.createSchema(SQLite.java:117)
        at com.redmondsims.gistfx@3.3.6/com.redmondsims.gistfx.data.SQLite.setConnection(SQLite.java:57)
        at com.redmondsims.gistfx@3.3.6/com.redmondsims.gistfx.data.Action.setDatabaseConnection(Action.java:52)
        at com.redmondsims.gistfx@3.3.6/com.redmondsims.gistfx.Main.start(Main.java:165)
        at javafx.graphics/com.sun.javafx.application.LauncherImpl.lambda$launchApplication1$9(LauncherImpl.java:847)
        at javafx.graphics/com.sun.javafx.application.PlatformImpl.lambda$runAndWait$12(PlatformImpl.java:484)
        at javafx.graphics/com.sun.javafx.application.PlatformImpl.lambda$runLater$10(PlatformImpl.java:457)
        at java.base/java.security.AccessController.doPrivileged(AccessController.java:399)
        at javafx.graphics/com.sun.javafx.application.PlatformImpl.lambda$runLater$11(PlatformImpl.java:456)
        at javafx.graphics/com.sun.glass.ui.InvokeLaterDispatcher$Future.run(InvokeLaterDispatcher.java:96)
        at javafx.graphics/com.sun.glass.ui.win.WinApplication._runLoop(Native Method)
        at javafx.graphics/com.sun.glass.ui.win.WinApplication.lambda$runLoop$3(WinApplication.java:184)
        at java.base/java.lang.Thread.run(Thread.java:833)

The SQLite library failed to create the schema.
        Make sure your Access Control Lists are permissive for the folder that GistFX executes from.

Run program from a command prompt to see the full stack trace.

Exiting...
[ERROR] Command execution failed.
org.apache.commons.exec.ExecuteException: Process exited with an error: 101 (Exit value: 101)
    at org.apache.commons.exec.DefaultExecutor.executeInternal (DefaultExecutor.java:404)
    at org.apache.commons.exec.DefaultExecutor.execute (DefaultExecutor.java:166)
    at org.openjfx.JavaFXBaseMojo.executeCommandLine (JavaFXBaseMojo.java:567)
    at org.openjfx.JavaFXBaseMojo.executeCommandLine (JavaFXBaseMojo.java:434)
    at org.openjfx.JavaFXRunMojo.execute (JavaFXRunMojo.java:105)
    at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:137)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:210)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:156)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:148)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:117)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:81)
    at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:56)
    at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:128)
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
    at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
    at org.apache.maven.cli.MavenCli.execute (MavenCli.java:972)
    at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:293)
    at org.apache.maven.cli.MavenCli.main (MavenCli.java:196)
    at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
    at jdk.internal.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:77)
    at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke (Method.java:568)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:282)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:225)
    at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:406)
    at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)
org.apache.commons.exec.ExecuteException: Process exited with an error: 101 (Exit value: 101)
        at org.apache.commons.exec.DefaultExecutor.executeInternal(DefaultExecutor.java:404)
        at org.apache.commons.exec.DefaultExecutor.execute(DefaultExecutor.java:166)
        at org.openjfx.JavaFXBaseMojo.executeCommandLine(JavaFXBaseMojo.java:567)
        at org.openjfx.JavaFXBaseMojo.executeCommandLine(JavaFXBaseMojo.java:434)
        at org.openjfx.JavaFXRunMojo.execute(JavaFXRunMojo.java:105)
        at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:137)
        at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:210)
        at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:156)
        at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:148)
        at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:117)
        at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:81)
        at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:56)
        at org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
        at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:305)
        at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:192)
        at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:105)
        at org.apache.maven.cli.MavenCli.execute(MavenCli.java:972)
        at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:293)
        at org.apache.maven.cli.MavenCli.main(MavenCli.java:196)
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
        at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.base/java.lang.reflect.Method.invoke(Method.java:568)
        at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:282)
        at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:225)
        at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:406)
        at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:347)
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  20.760 s
[INFO] Finished at: 2022-03-23T23:46:20Z
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.openjfx:javafx-maven-plugin:0.0.8:run (default-cli) on project GistFX: Error: Command execution failed. Process exited with an error: 101 (Exit value: 101) -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException

and also shows this:

When is created the SQLite database (C:\Users\fvarrui\AppData\Local\GistFX\SQLite\Database.sqlite) in your code? When does it try to connect to a non existing database?

@fvarrui Curious, what happens if you run the EXE as Admin?

@fvarrui - I changed the location for Windows data file storage over to the Microsoft prescribed APPDATA folder and I pushed the change to the repository. Try that.

@fvarrui - What I find interesting is that you are getting the exe to run at all ... I'm not having much luck with that.

@fvarrui  - I GOT IT WORKING! ... I'm so happy!

Hi @EasyG0ing1!
I've tried to build last version and I'm getting an error:
[INFO]     Bundling JRE ... with C:\Program Files\Eclipse Adoptium\jdk-<IP_ADDRESS>-hotspot
[INFO]         Creating customized JRE ...
[INFO]         Getting required modules ...
[INFO]             Executing command: cmd.exe /s /c ""C:\Program Files\Eclipse Adoptium\jdk-<IP_ADDRESS>-hotspot\bin\jdeps" -q --multi-release 17 --ignore-missing-deps --print-module-deps C:\Users\fvarrui\GistFX\target\GistFX\libs\*.jar C:\Users\fvarrui\GistFX\target\GistFX-3.3.6-runnable.jar"
[ERROR]             Exception in thread "main" java.lang.module.FindException: Module org.apache.commons.lang3 not found, required by com.redmondsims.gistfx
[ERROR]                 at java.base/java.lang.module.Resolver.findFail(Resolver.java:893)
[ERROR]                 at java.base/java.lang.module.Resolver.resolve(Resolver.java:192)
[ERROR]                 at java.base/java.lang.module.Resolver.resolve(Resolver.java:141)
[ERROR]                 at java.base/java.lang.module.Configuration.resolve(Configuration.java:421)
[ERROR]                 at java.base/java.lang.module.Configuration.resolve(Configuration.java:255)
[ERROR]                 at jdk.jdeps/com.sun.tools.jdeps.JdepsConfiguration$Builder.build(JdepsConfiguration.java:564)
[ERROR]                 at jdk.jdeps/com.sun.tools.jdeps.JdepsTask.buildConfig(JdepsTask.java:603)
[ERROR]                 at jdk.jdeps/com.sun.tools.jdeps.JdepsTask.run(JdepsTask.java:557)
[ERROR]                 at jdk.jdeps/com.sun.tools.jdeps.JdepsTask.run(JdepsTask.java:533)
[ERROR]                 at jdk.jdeps/com.sun.tools.jdeps.Main.main(Main.java:49)
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  15.394 s
[INFO] Finished at: 2022-03-25T11:21:53Z
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal io.github.fvarrui:javapackager:1.6.5:package (package-for-windows) on project GistFX: Command execution failed: C:\Program Files\Eclipse Adoptium\jdk-<IP_ADDRESS>-hotspot\bin\jdeps -q --multi-release 17 --ignore-missing-deps --print-module-deps [Ljava.lang.String;@34e7b058 C:\Users\fvarrui\GistFX\target\GistFX\libs\*.jar C:\Users\fvarrui\GistFX\target\GistFX-3.3.6-runnable.jar -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException

Sometimes jdeps run into problems when is trying to find which core modules are needed to generate a customized JRE. I fixed changing customizedJre to false, and the build process finished without problems.
                <configuration>
                    <mainClass>${exec.mainClass}</mainClass>
                    <bundleJre>true</bundleJre>
                    <customizedJre>false</customizedJre>
                    <generateInstaller>true</generateInstaller>
                    <administratorRequired>false</administratorRequired>
                    <!--
                    <jdkPath>/Library/Java/JavaVirtualMachines/jdk-17.0.2.jdk/Contents/Home</jdkPath>
                    -->
                </configuration>

I'm on Windows.

Have you experienced this problem too?
Then, when I try to run your app it stops due to the same error as I reported before (maybe I'm missing something or doing something wrong):
C:\Users\fvarrui\GistFX>target\GistFX\GistFX.exe
*** SQLite.createSchema ***
[SQLITE_ERROR] SQL error or missing database (incomplete input)
org.sqlite.SQLiteException: [SQLITE_ERROR] SQL error or missing database (incomplete input)
        at org.xerial.sqlitejdbc@<IP_ADDRESS>/org.sqlite.core.DB.newSQLException(DB.java:1030)
        at org.xerial.sqlitejdbc@<IP_ADDRESS>/org.sqlite.core.DB.newSQLException(DB.java:1042)
        at org.xerial.sqlitejdbc@<IP_ADDRESS>/org.sqlite.core.DB.throwex(DB.java:1007)
        at org.xerial.sqlitejdbc@<IP_ADDRESS>/org.sqlite.core.NativeDB._exec_utf8(Native Method)
        at org.xerial.sqlitejdbc@<IP_ADDRESS>/org.sqlite.core.NativeDB._exec(NativeDB.java:97)
        at org.xerial.sqlitejdbc@<IP_ADDRESS>/org.sqlite.jdbc3.JDBC3Statement.executeUpdate(JDBC3Statement.java:102)
        at com.redmondsims.gistfx.data.SQLite.createSchema(SQLite.java:116)
        at com.redmondsims.gistfx.data.SQLite.setConnection(SQLite.java:56)
        at com.redmondsims.gistfx.data.Action.setDatabaseConnection(Action.java:52)
        at com.redmondsims.gistfx.Main.start(Main.java:166)
        at javafx.graphics/com.sun.javafx.application.LauncherImpl.lambda$launchApplication1$9(LauncherImpl.java:847)
        at javafx.graphics/com.sun.javafx.application.PlatformImpl.lambda$runAndWait$12(PlatformImpl.java:484)
        at javafx.graphics/com.sun.javafx.application.PlatformImpl.lambda$runLater$10(PlatformImpl.java:457)
        at java.base/java.security.AccessController.doPrivileged(Unknown Source)
        at javafx.graphics/com.sun.javafx.application.PlatformImpl.lambda$runLater$11(PlatformImpl.java:456)
        at javafx.graphics/com.sun.glass.ui.InvokeLaterDispatcher$Future.run(InvokeLaterDispatcher.java:96)
        at javafx.graphics/com.sun.glass.ui.win.WinApplication._runLoop(Native Method)
        at javafx.graphics/com.sun.glass.ui.win.WinApplication.lambda$runLoop$3(WinApplication.java:184)
        at java.base/java.lang.Thread.run(Unknown Source)

The SQLite library failed to create the schema.
        Make sure your Access Control Lists are permissive for the folder that GistFX executes from.

Run program from a command prompt to see the full stack trace.

Exiting...

@fvarrui The version I just now pushed, I literally just copied the project folder over to windows then from a CMD prompt, after changing into the project directory, I ran mvn clean package and it ran fine and the exe ran fine as well.

Could it be because to the database file already exists on your system? So, there's no need to create a new one

May you publish your Setup installer in the releases section, please?

@fvarrui - no, the database file doesn't exist because I copy the installer off to a network drive, then I ever my virtual machine to a snapshot that I took long before I even started trying to run it on Windows and it still works.
Have you tried running it as Admin?
Also, whats the build switch that makes the Windows exe not launch a CMD window that it leaves running in the background?

Hi @EasyG0ing1!
I've getting a new error running with my user and as Admin:
C:\Users\fvarrui\GistFX\target\GistFX>GistFX.exe
[SQLITE_ERROR] SQL error or missing database (no such table: Gists)
        com.redmondsims.gistfx.data.SQLite.hasData(SQLite.java:366)
        com.redmondsims.gistfx.data.SQLite.gistsHasData(SQLite.java:355)
        com.redmondsims.gistfx.data.SQLite.hasData(SQLite.java:350)
        com.redmondsims.gistfx.data.SQLite.setConnection(SQLite.java:68)
        com.redmondsims.gistfx.data.Action.setDatabaseConnection(Action.java:53)
        com.redmondsims.gistfx.Main.start(Main.java:94)

It seems that it can't find the Gists table in the database.

@fvarrui - I published the installer

It's creating this directory structure:
C:\Users\fvarrui\AppData\Roaming\GistFX>tree /f
Listado de rutas de carpetas
El número de serie del volumen es E4F9-DB0F
C:.
├───HelpFiles
│   │   Logo.png
│   │
│   ├───General
│   │       1.png
│   │       2.png
│   │
│   └───HowToToken
│           1.png
│           2.png
│           3.png
│           4.png
│           5.png
│           6.png
│           7.png
│
├───Icons
│   └───Tree
│           ConflictFlag.png
│           DirtyFlag.png
│           File1.png
│           File2.png
│           Folder.png
│
└───SQLite
        Database.sqlite

but Database.sqlite is empty.

Ok ... I'm going to try with your installer and tell you something in a moment.

@fvarrui - Try deleting this folder C:\Users\Username\AppData\Roaming\GistFX
Then re-run the program and see what happens

@fvarrui - Try deleting this folder C:\Users\Username\AppData\Roaming\GistFX

Yes, done.

Then re-run the program and see what happens

Ok, I'm gonna tell you something right now.

And make sure you have an APPDATA environment variable

C:\Users\fvarrui\GistFX\target\GistFX>echo %APPDATA%
C:\Users\fvarrui\AppData\Roaming

@fvarrui - ok that looks right

Installed:

And running fine 👏 👏 👏

And the database is well created (not empty, at least):

Great work!! ... I'm not sure what I'm doing wrong when building your app, but I'm happy because now it's working fine

Try to change headerType property to gui, so it doesn't open a console, and add icons to EXE and to the installer as it's explained in JavaPackager docs. It's quite easy!

@fvarrui so mine will run but yours won't?

Well ... I'm not sure why, but the important thing is that your installer works fine

@fvarrui - Now I gotta figure out how to build a MacOS installer, then a linux installer after that.

If you want that anybody can build your app, include instructions in README.
This is my environment config:
C:\Users\fvarrui\GistFX\target\GistFX>mvn -v
Apache Maven 3.8.4 (9b656c72d54e5bacbed989b64718c159fe39b537)
Maven home: C:\ProgramData\chocolatey\lib\maven\apache-maven-3.8.4
Java version: 17.0.1, vendor: Eclipse Adoptium, runtime: C:\Program Files\Eclipse Adoptium\jdk-<IP_ADDRESS>-hotspot
Default locale: es_ES, platform encoding: Cp1252
OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"

I don't know how it differs from your environment.

@fvarrui
Heres my build environment
C:\Temp\GistFXTwo>mvn -v
Apache Maven 3.8.4 (9b656c72d54e5bacbed989b64718c159fe39b537)
Maven home: C:\ProgramData\chocolatey\lib\maven\apache-maven-3.8.4
Java version: 17.0.2, vendor: Oracle Corporation, runtime: C:\Program Files\Java\javafx-sdk-17.0.2
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
'cmd' is not recognized as an internal or external command,
operable program or batch file.

I would venture to say that you only have to run mvn clean package but from a Mac OS system and from a Linux one ... and that's all!

@fvarrui - Well I'll need an execution setup properly under the plugin ... no?

@fvarrui
Heres my build environment
C:\Temp\GistFXTwo>mvn -v
Apache Maven 3.8.4 (9b656c72d54e5bacbed989b64718c159fe39b537)
Maven home: C:\ProgramData\chocolatey\lib\maven\apache-maven-3.8.4
Java version: 17.0.2, vendor: Oracle Corporation, runtime: C:\Program Files\Java\javafx-sdk-17.0.2
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
'cmd' is not recognized as an internal or external command,
operable program or batch file.

Almost the same configuration ... maybe the problem is mine ... could you try to build your app on another system?

@fvarrui - The best I can do is another virtual machine ... OR I could use the BootCamp dual boot on my MacBook Pro.

@fvarrui - Well I'll need an execution setup properly under the plugin ... no?

This config should work on each system:
            <plugin>
                <groupId>io.github.fvarrui</groupId>
                <artifactId>javapackager</artifactId>
                <version>1.6.5</version>
                <configuration>
                    <mainClass>${exec.mainClass}</mainClass>
                    <bundleJre>true</bundleJre>
                    <customizedJre>false</customizedJre>
                    <generateInstaller>true</generateInstaller>
                    <administratorRequired>false</administratorRequired>
                </configuration>
                <executions>
                    <execution>
                        <phase>package</phase>
                        <goals>
                            <goal>package</goal>
                        </goals>
                        <configuration>
                            <platform>auto</platform>
                            <createZipball>false</createZipball>
                            <createTarball>true</createTarball>
                            <vmArgs>
                                <vmArg>--module-path=libs</vmArg>
                                <vmArg>--add-modules=javafx.controls,javafx.graphics</vmArg>
                            </vmArgs>
                            <winConfig>
                                <headerType>gui</headerType>
                                <generateMsi>false</generateMsi>
                            </winConfig>
                        </configuration>
                    </execution>
                </executions>
            </plugin>

I was just saying that to make sure your app can be built from any Windows

@fvarrui - I understand.
Will I need any build tools for MacOS or Linux like I did for Windows?

@fvarrui - I understand.
Will I need any build tools for MacOS or Linux like I did for Windows?

No ... only Windows needs those tools to be installed:

And even more... you can generate DEB and RPM files from Windows and MacOS, if you want!

You can also use GitHub Actions, Circle CI or any other online CI tool to build your app for all platforms from the cloud.

@fvarrui - ok ... well ... the package went fine on MAcOS but the .app wont run ... I'm rebuilding it to output to console to see whats up

Try to run you Mac app from the terminal using open GistFX.app, so it shows what's happening

Could you share Info.plist file content, please?

@fvarrui
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
    <dict>
        <key>CFBundleGetInfoString</key>
        <string>GistFX 3.3.6</string>
        <key>CFBundleDevelopmentRegion</key>
        <string>English</string>
        <key>CFBundleExecutable</key>
        <string>universalJavaApplicationStub</string>
        <key>CFBundleIconFile</key>
        <string>GistFX.icns</string>
        <key>CFBundleIdentifier</key>
        <string>com.redmondsims.gistfx.Main</string>
        <key>CFBundleDisplayName</key>
        <string>GistFX</string>
        <key>CFBundleInfoDictionaryVersion</key>
        <string>6.0</string>
        <key>CFBundleName</key>
        <string>GistFX</string>
        <key>CFBundlePackageType</key>
        <string>BNDL</string>
        <key>CFBundleShortVersionString</key>
        <string>3.3.6</string>
        <key>CFBundleSignature</key>
        <string>????</string>
        <key>CFBundleVersion</key>
        <string>3.3.6</string>
        <key>NSHumanReadableCopyright</key>
        <string>ACME</string>
        <key>NSHighResolutionCapable</key>
        <true/>
        <key>NSSupportsAutomaticGraphicsSwitching</key>
        <true/>
        <key>AdministratorRequired</key>
        <false/>
        <key>JavaX</key>
        <dict>
            <key>MainClass</key>
            <string>com.redmondsims.gistfx.Main</string>
            <key>ClassPath</key>
            <array>
                <string>Java/GistFX-3.3.6-runnable.jar</string>
            </array>
            <key>VMOptions</key>
            <array>
                <string>--module-path=libs</string>
                <string>--add-modules=javafx.controls,javafx.graphics</string>
            </array>
            <key>WorkingDirectory</key>
            <string>$APP_PACKAGE/Contents/Resources</string>
            <key>JVMOptionsFile</key>
            <string>$APP_PACKAGE/Contents/Resources/GistFX.l4j.ini</string>
        </dict>
        <key>LSEnvironment</key>
        <dict>
            <key>JAVA_HOME</key>
            <string>Contents/PlugIns/jre/Contents/Home</string>
        </dict>
        <key>NSAppleEventsUsageDescription</key>
        <string>There was an error while launching the application. Please
			click OK to display a dialog with more information or cancel and view
			the syslog for details.</string>
    </dict>
</plist>

I think it could be something related to VM arguments:
            <key>VMOptions</key>
            <array>
                <string>--module-path=libs</string>
                <string>--add-modules=javafx.controls,javafx.graphics</string>
            </array>

Maybe libs is not the right path for Mac OS.

Please, try with:
<string>--module-path=Java/libs</string>

or
<string>--module-path=$APP_PACKAGE/Contents/Resources/Java/libs</string>

If one of this options works fine .... then change JavaPackager config to:
<vmArgs>
    <vmArg>--module-path=${the-right-path}/libs</vmArg>
    <vmArg>--add-modules=javafx.controls,javafx.graphics</vmArg>
</vmArgs>

and build it again

@fvarrui are you talking about this section here?
                            <vmArgs>
                                <vmArg>--module-path=libs</vmArg>
                                <vmArg>--add-modules=javafx.controls,javafx.graphics</vmArg>
                            </vmArgs>

@fvarrui OK ... ill try that now

@fvarrui OK, just adding java to the path like this
<string>--module-path=Java/libs</string>

WORKED!
How do I change the pom file so that it does it correctly?

@fvarrui Well I spoke too soon ... after logging into the app and as it started to access the Internet ... it threw this error
~/IdeaProjects/GistFXTwo/target/GistFX/GistFX.app/Contents/MacOS $./universalJavaApplicationStub
Exception in thread "JavaFX Application Thread" java.lang.IllegalAccessError: superclass access check failed: class com.sun.javafx.sg.prism.web.NGWebView (in unnamed module @0x4719c6b5) cannot access class com.sun.javafx.sg.prism.NGGroup (in module javafx.graphics) because module javafx.graphics does not export com.sun.javafx.sg.prism to unnamed module @0x4719c6b5
	at java.base/java.lang.ClassLoader.defineClass1(Native Method)
	at java.base/java.lang.ClassLoader.defineClass(ClassLoader.java:1012)
	at java.base/java.security.SecureClassLoader.defineClass(SecureClassLoader.java:150)
	at java.base/jdk.internal.loader.BuiltinClassLoader.defineClass(BuiltinClassLoader.java:862)
	at java.base/jdk.internal.loader.BuiltinClassLoader.findClassOnClassPathOrNull(BuiltinClassLoader.java:760)
	at java.base/jdk.internal.loader.BuiltinClassLoader.loadClassOrNull(BuiltinClassLoader.java:681)
	at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:639)
	at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:188)
	at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:520)
	at eu.mihosoft.monacofx@0.0.7/eu.mihosoft.monacofx.MonacoFX.<init>(MonacoFX.java:49)
	at com.redmondsims.gistfx.ui.gist.CodeEditor.checkNull(CodeEditor.java:17)
	at com.redmondsims.gistfx.ui.gist.CodeEditor.get(CodeEditor.java:59)
	at com.redmondsims.gistfx.ui.gist.GistWindow.placeControlsOnPane(GistWindow.java:253)
	at com.redmondsims.gistfx.ui.gist.GistWindow.showMainWindow(GistWindow.java:133)
	at com.redmondsims.gistfx.gist.WindowManager.lambda$newGistWindow$0(WindowManager.java:27)
	at javafx.graphics/com.sun.javafx.application.PlatformImpl.lambda$runLater$10(PlatformImpl.java:457)
	at java.base/java.security.AccessController.doPrivileged(AccessController.java:399)
	at javafx.graphics/com.sun.javafx.application.PlatformImpl.lambda$runLater$11(PlatformImpl.java:456)
	at javafx.graphics/com.sun.glass.ui.InvokeLaterDispatcher$Future.run(InvokeLaterDispatcher.java:96)

Your POM should look like this:
            <plugin>
                <groupId>io.github.fvarrui</groupId>
                <artifactId>javapackager</artifactId>
                <version>1.6.5</version>
                <configuration>
                    <mainClass>${exec.mainClass}</mainClass>
                    <bundleJre>true</bundleJre>
                    <customizedJre>false</customizedJre>
                    <generateInstaller>true</generateInstaller>
                    <administratorRequired>false</administratorRequired>
                </configuration>
                <executions>
                    <execution>
                        <phase>package</phase>
                        <goals>
                            <goal>package</goal>
                        </goals>
                        <configuration>
                            <platform>auto</platform>
                            <createZipball>false</createZipball>
                            <createTarball>true</createTarball>
                            <vmArgs>
                                <vmArg>--module-path=Java/libs</vmArg>
                                <vmArg>--add-modules=javafx.controls,javafx.graphics</vmArg>
                                <vmArg>--add-exports javafx.graphics/com.sun.javafx.sg.prism=ALL-UNNAMED</vmArg>
                            </vmArgs>
                            <winConfig>
                                <headerType>gui</headerType>
                                <generateMsi>false</generateMsi>
                            </winConfig>
                        </configuration>
                    </execution>
                </executions>
            </plugin>

Which JDK version are you using on Mac OS?

<vmArg>--add-exports javafx.graphics/com.sun.javafx.sg.prism=ALL-UNNAMED</vmArg> ... AFAIK, this line gives read access to the package com.sun.javafx.sg.prism in javafx.graphics to non-modular code (which are automatically added to the unnamed module).

Maybe you are using a newer JDK in your Mac OS, which is more restrictive with illegal access to non-exported packages?

@fvarrui I'm using 17.0.2 on the mac... I even built a MacOS VM and am having the same issues.
I just tried adding that line and I get the same error:
Exception in thread "JavaFX Application Thread" java.lang.IllegalAccessError: superclass access check failed: class com.sun.java.scene.web.WebViewHelper (in unnamed module @0x6b6dd63a) cannot access class com.sun.javafx.scene.ParentHelper (in module javafx.graphics) because module javafx.graphics does not export com.sun.javafx.scene to unnamed module @0x6b6dd63a

It's not the same error, as now it says another package. But, I'll try it on my virtualized MacOS and try to figure out what's happening

@fvarrui - I did a debug of the mvn javafx:run goal and I'm not sure if any of this info would help, but here is the final command it runs, only formatted for easier readability .... is there anything in this that would tell us anything?
/usr/local/opt/openjdk/libexec/openjdk.jdk/Contents/Home/bin/java

--module-path
	/Users/michael/IdeaProjects/GistFXTwo/target/classes
	/Users/michael/.m2/repository/com/google/code/gson/gson/2.9.0/gson-2.9.0.jar
	/Users/michael/.m2/repository/com/simtechdata/WaifUPnP/1.0/WaifUPnP-1.0.jar
	/Users/michael/.m2/repository/commons-codec/commons-codec/1.15/commons-codec-1.15.jar
	/Users/michael/.m2/repository/commons-io/commons-io/2.11.0/commons-io-2.11.0.jar
	/Users/michael/.m2/repository/eu/mihosoft/monacofx/monacofx/0.0.7/monacofx-0.0.7.jar
	/Users/michael/.m2/repository/joda-time/joda-time/2.10.14/joda-time-2.10.14.jar
	/Users/michael/.m2/repository/org/apache/commons/commons-lang3/3.12.0/commons-lang3-3.12.0.jar
	/Users/michael/.m2/repository/org/jetbrains/annotations/13.0/annotations-13.0.jar
	/Users/michael/.m2/repository/org/kohsuke/github-api/1.302/github-api-1.302.jar
	/Users/michael/.m2/repository/org/openjfx/javafx-base/17.0.2/javafx-base-17.0.2-mac.jar
	/Users/michael/.m2/repository/org/openjfx/javafx-controls/17.0.2/javafx-controls-17.0.2-mac.jar
	/Users/michael/.m2/repository/org/openjfx/javafx-graphics/17.0.2/javafx-graphics-17.0.2-mac.jar
	/Users/michael/.m2/repository/org/openjfx/javafx-media/17.0.2/javafx-media-17.0.2-mac.jar
	/Users/michael/.m2/repository/org/openjfx/javafx-web/17.0.2/javafx-web-17.0.2-mac.jar
	/Users/michael/.m2/repository/org/springframework/security/spring-security-crypto/5.6.2/spring-security-crypto-5.6.2.jar

--add-modules, com.redmondsims.gistfx

-classpath
	/Users/michael/.m2/repository/com/fasterxml/jackson/core/jackson-annotations/2.13.1/jackson-annotations-2.13.1.jar
	/Users/michael/.m2/repository/com/fasterxml/jackson/core/jackson-core/2.13.1/jackson-core-2.13.1.jar
	/Users/michael/.m2/repository/com/fasterxml/jackson/core/jackson-databind/2.13.1/jackson-databind-2.13.1.jar
	/Users/michael/.m2/repository/com/google/protobuf/protobuf-java/3.11.4/protobuf-java-3.11.4.jar
	/Users/michael/.m2/repository/com/squareup/okhttp3/okhttp/4.9.3/okhttp-4.9.3.jar
	/Users/michael/.m2/repository/com/squareup/okio/okio/2.8.0/okio-2.8.0.jar
	/Users/michael/.m2/repository/mysql/mysql-connector-java/8.0.28/mysql-connector-java-8.0.28.jar
	/Users/michael/.m2/repository/org/commonmark/commonmark/0.18.2/commonmark-0.18.2.jar
	/Users/michael/.m2/repository/org/jetbrains/kotlin/kotlin-stdlib/1.4.10/kotlin-stdlib-1.4.10.jar
	/Users/michael/.m2/repository/org/jetbrains/kotlin/kotlin-stdlib-common/1.4.0/kotlin-stdlib-common-1.4.0.jar
	/Users/michael/.m2/repository/org/openjfx/javafx-base/17.0.2/javafx-base-17.0.2.jar
	/Users/michael/.m2/repository/org/openjfx/javafx-controls/17.0.2/javafx-controls-17.0.2.jar
	/Users/michael/.m2/repository/org/openjfx/javafx-graphics/17.0.2/javafx-graphics-17.0.2.jar
	/Users/michael/.m2/repository/org/openjfx/javafx-media/17.0.2/javafx-media-17.0.2.jar
	/Users/michael/.m2/repository/org/openjfx/javafx-web/17.0.2/javafx-web-17.0.2.jar
	/Users/michael/.m2/repository/org/xerial/sqlite-jdbc/<IP_ADDRESS>/sqlite-jdbc-<IP_ADDRESS>.jar

--module
    com.redmondsims.gistfx/com.redmondsims.gistfx.Main

Sorry! I'm not really sure ... I know that other users of JavaPackager are using it with modular Java apps, but I haven't tried it until now, so your project is helping me to test all this 😅

I'll try it on my virtualized MacOS and try to figure out what's happening

I'll tell you something ASAP

Hi @EasyG0ing1!
Please, try with this config:
                            <vmArgs>
                                <vmArg>--module-path=Java/libs</vmArg>
                                <vmArg>--add-modules=javafx.controls,javafx.graphics,javafx.web</vmArg>
                            </vmArgs>

I can't try it because when I run your app with mvn javafx:run on my Mac OS VM (10.12.6) fails, saying that it runs out of executable memory (and I don't know what's going on as it has 8GM RAM and activity monitor says that it's only using 1.5GB 🤷♂). I haven't had time to investigate it further, sorry!

@fvarrui - SUCCESS - with some caveats...
Including javafx.web was a good call ... but when I ran the compiled app, it started throwing Stack Overflow errors. So I decided to try Java 18 SDK and that actually worked. And I'll explain how I integrate javafx into the SDK.
First, I install the Oracle SDK from here
Then I downloaded:
the JavaFX SDK
the JavaFX jmods
First unzip the JavaFX SDK then copy the files from the lib folder into your installed Oracle JDK lib folder which should be at /Library/Java/JavaVirtualMachines/jdk-18.jdk/Contents/Home/lib
Do the same for the legal folder (though I don't think that has any functional value)
Then unzip the JavaFX jmods  and put those files into the Oracle JDK jmods folder
Set your JAVA_HOME environment variable to /Library/Java/JavaVirtualMachines/jdk-18.jdk/Contents/Home and add these to your path making sure no other Java SDKs are in your path:
/Library/Java/JavaVirtualMachines/jdk-18.jdk/Contents/Home/bin
/Library/Java/JavaVirtualMachines/jdk-18.jdk/Contents/Home/lib
Then run mvn clean package
I installed JDK 18 in my Windows environment and ran the package goal in Windows and it too works perfectly without any changes in the POM file!
This is good news ☺
Next up - Linux (oh boy)
I pushed the working version of the code to the repository

@fvarrui - OK well we might not be done with the MacOS packager ... when I tried using the installer in my MacOS VM, the program won't even run, throwing this error:
	java.lang.UnsupportedClassVersionError: com/redmondsims/gistfx/Main has been compiled by a more recent version of the Java Runtime (class file version 62.0), this version of the Java Runtime only recognizes class file versions up to 61.0

I removed all references to the installed JDK, in fact here are the exports on that machine:
Mikes-Mac:MacOS michael$ export
declare -x COLORFGBG="7;0"
declare -x COLORTERM="truecolor"
declare -x COMMAND_MODE="unix2003"
declare -x HOME="/Users/michael"
declare -x ITERM_PROFILE="Default"
declare -x ITERM_SESSION_ID="w0t0p0:B20B28E5-01D9-4104-9CEF-D2E4C826C98C"
declare -x LANG="en_US.UTF-8"
declare -x LC_TERMINAL="iTerm2"
declare -x LC_TERMINAL_VERSION="3.4.15"
declare -x LOGNAME="michael"
declare -x OLDPWD="/Users/michael"
declare -x PATH="/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin"
declare -x PWD="/Applications/GistFX.app/Contents/MacOS"
declare -x SHELL="/usr/local/Cellar/bash/5.1.16/bin/bash"
declare -x SHLVL="1"
declare -x SSH_AUTH_SOCK="/private/tmp/com.apple.launchd.2SNEuWe0ba/Listeners"
declare -x TERM="xterm-256color"
declare -x TERM_PROGRAM="iTerm.app"
declare -x TERM_PROGRAM_VERSION="3.4.15"
declare -x TERM_SESSION_ID="w0t0p0:B20B28E5-01D9-4104-9CEF-D2E4C826C98C"
declare -x TMPDIR="/var/folders/z6/_s902b_d7jg396gytgc7ps180000gn/T/"
declare -x USER="michael"
declare -x XPC_FLAGS="0x0"
declare -x XPC_SERVICE_NAME="0"
declare -x __CFBundleIdentifier="com.googlecode.iterm2"
declare -x __CF_USER_TEXT_ENCODING="0x1F5:0x0:0x0"
Mikes-Mac:MacOS michael$

And here is the Info.plist:
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
    <dict>
        <key>CFBundleGetInfoString</key>
        <string>GistFX 3.3.6</string>
        <key>CFBundleDevelopmentRegion</key>
        <string>English</string>
        <key>CFBundleExecutable</key>
        <string>universalJavaApplicationStub</string>
        <key>CFBundleIconFile</key>
        <string>GistFX.icns</string>
        <key>CFBundleIdentifier</key>
        <string>com.redmondsims.gistfx.Main</string>
        <key>CFBundleDisplayName</key>
        <string>GistFX</string>
        <key>CFBundleInfoDictionaryVersion</key>
        <string>6.0</string>
        <key>CFBundleName</key>
        <string>GistFX</string>
        <key>CFBundlePackageType</key>
        <string>BNDL</string>
        <key>CFBundleShortVersionString</key>
        <string>3.3.6</string>
        <key>CFBundleSignature</key>
        <string>????</string>
        <key>CFBundleVersion</key>
        <string>3.3.6</string>
        <key>NSHumanReadableCopyright</key>
        <string>ACME</string>
        <key>NSHighResolutionCapable</key>
        <true/>
        <key>NSSupportsAutomaticGraphicsSwitching</key>
        <true/>
        <key>AdministratorRequired</key>
        <false/>
        <key>JavaX</key>
        <dict>
            <key>MainClass</key>
            <string>com.redmondsims.gistfx.Main</string>
            <key>ClassPath</key>
            <array>
                <string>Java/GistFX-3.3.6-runnable.jar</string>
            </array>
            <key>VMOptions</key>
            <array>
                <string>--module-path=Java/libs</string>
                <string>--add-modules=javafx.controls,javafx.graphics,javafx.web</string>
            </array>
            <key>WorkingDirectory</key>
            <string>$APP_PACKAGE/Contents/Resources</string>
            <key>JVMOptionsFile</key>
            <string>$APP_PACKAGE/Contents/Resources/GistFX.l4j.ini</string>
        </dict>
        <key>LSEnvironment</key>
        <dict>
            <key>JAVA_HOME</key>
            <string>Contents/PlugIns/jre/Contents/Home</string>
        </dict>
        <key>NSAppleEventsUsageDescription</key>
        <string>There was an error while launching the application. Please
			click OK to display a dialog with more information or cancel and view
			the syslog for details.</string>
    </dict>
</plist>

@fvarrui - I did a debug of the mvn javafx:run goal and I'm not sure if any of this info would help, but here is the final command it runs, only formatted for easier readability .... is there anything in this that would tell us anything?
/usr/local/opt/openjdk/libexec/openjdk.jdk/Contents/Home/bin/java

--module-path
	/Users/michael/IdeaProjects/GistFXTwo/target/classes
	/Users/michael/.m2/repository/com/google/code/gson/gson/2.9.0/gson-2.9.0.jar
	/Users/michael/.m2/repository/com/simtechdata/WaifUPnP/1.0/WaifUPnP-1.0.jar
	/Users/michael/.m2/repository/commons-codec/commons-codec/1.15/commons-codec-1.15.jar
	/Users/michael/.m2/repository/commons-io/commons-io/2.11.0/commons-io-2.11.0.jar
	/Users/michael/.m2/repository/eu/mihosoft/monacofx/monacofx/0.0.7/monacofx-0.0.7.jar
	/Users/michael/.m2/repository/joda-time/joda-time/2.10.14/joda-time-2.10.14.jar
	/Users/michael/.m2/repository/org/apache/commons/commons-lang3/3.12.0/commons-lang3-3.12.0.jar
	/Users/michael/.m2/repository/org/jetbrains/annotations/13.0/annotations-13.0.jar
	/Users/michael/.m2/repository/org/kohsuke/github-api/1.302/github-api-1.302.jar
	/Users/michael/.m2/repository/org/openjfx/javafx-base/17.0.2/javafx-base-17.0.2-mac.jar
	/Users/michael/.m2/repository/org/openjfx/javafx-controls/17.0.2/javafx-controls-17.0.2-mac.jar
	/Users/michael/.m2/repository/org/openjfx/javafx-graphics/17.0.2/javafx-graphics-17.0.2-mac.jar
	/Users/michael/.m2/repository/org/openjfx/javafx-media/17.0.2/javafx-media-17.0.2-mac.jar
	/Users/michael/.m2/repository/org/openjfx/javafx-web/17.0.2/javafx-web-17.0.2-mac.jar
	/Users/michael/.m2/repository/org/springframework/security/spring-security-crypto/5.6.2/spring-security-crypto-5.6.2.jar

--add-modules, com.redmondsims.gistfx

-classpath
	/Users/michael/.m2/repository/com/fasterxml/jackson/core/jackson-annotations/2.13.1/jackson-annotations-2.13.1.jar
	/Users/michael/.m2/repository/com/fasterxml/jackson/core/jackson-core/2.13.1/jackson-core-2.13.1.jar
	/Users/michael/.m2/repository/com/fasterxml/jackson/core/jackson-databind/2.13.1/jackson-databind-2.13.1.jar
	/Users/michael/.m2/repository/com/google/protobuf/protobuf-java/3.11.4/protobuf-java-3.11.4.jar
	/Users/michael/.m2/repository/com/squareup/okhttp3/okhttp/4.9.3/okhttp-4.9.3.jar
	/Users/michael/.m2/repository/com/squareup/okio/okio/2.8.0/okio-2.8.0.jar
	/Users/michael/.m2/repository/mysql/mysql-connector-java/8.0.28/mysql-connector-java-8.0.28.jar
	/Users/michael/.m2/repository/org/commonmark/commonmark/0.18.2/commonmark-0.18.2.jar
	/Users/michael/.m2/repository/org/jetbrains/kotlin/kotlin-stdlib/1.4.10/kotlin-stdlib-1.4.10.jar
	/Users/michael/.m2/repository/org/jetbrains/kotlin/kotlin-stdlib-common/1.4.0/kotlin-stdlib-common-1.4.0.jar
	/Users/michael/.m2/repository/org/openjfx/javafx-base/17.0.2/javafx-base-17.0.2.jar
	/Users/michael/.m2/repository/org/openjfx/javafx-controls/17.0.2/javafx-controls-17.0.2.jar
	/Users/michael/.m2/repository/org/openjfx/javafx-graphics/17.0.2/javafx-graphics-17.0.2.jar
	/Users/michael/.m2/repository/org/openjfx/javafx-media/17.0.2/javafx-media-17.0.2.jar
	/Users/michael/.m2/repository/org/openjfx/javafx-web/17.0.2/javafx-web-17.0.2.jar
	/Users/michael/.m2/repository/org/xerial/sqlite-jdbc/<IP_ADDRESS>/sqlite-jdbc-<IP_ADDRESS>.jar

--module
    com.redmondsims.gistfx/com.redmondsims.gistfx.Main

I think that the problem is probably related to this, because originally JavaPackager was proposed to maintain backward compatibility with versions prior to Java 9 (when JPMS was introduced), and is not managing fine modular Java apps.

@fvarrui - Well, I managed to get it compiled and working on my dev machine, but when I tried it on my macOS virtual machine, it errored out again saying that things were compiled with a newer version of Java ... then I was looking at the Info.plist file and saw this:
   <key>JVMOptionsFile</key>
            <string>$APP_PACKAGE/Contents/Resources/GistFX.l4j.ini</string>

And that file does not exist anywhere ... do you know what that's about?
Here is the entire Info.plist file:
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
    <dict>
        <key>CFBundleGetInfoString</key>
        <string>GistFX 3.3.6</string>
        <key>CFBundleDevelopmentRegion</key>
        <string>English</string>
        <key>CFBundleExecutable</key>
        <string>universalJavaApplicationStub</string>
        <key>CFBundleIconFile</key>
        <string>AppleDock.icns</string>
        <key>CFBundleIdentifier</key>
        <string>com.redmondsims.gistfx.Main</string>
        <key>CFBundleDisplayName</key>
        <string>GistFX</string>
        <key>CFBundleInfoDictionaryVersion</key>
        <string>6.0</string>
        <key>CFBundleName</key>
        <string>GistFX</string>
        <key>CFBundlePackageType</key>
        <string>BNDL</string>
        <key>CFBundleShortVersionString</key>
        <string>3.3.6</string>
        <key>CFBundleSignature</key>
        <string>????</string>
        <key>CFBundleVersion</key>
        <string>3.3.6</string>
        <key>NSHumanReadableCopyright</key>
        <string>ACME</string>
        <key>NSHighResolutionCapable</key>
        <true/>
        <key>NSSupportsAutomaticGraphicsSwitching</key>
        <true/>
        <key>AdministratorRequired</key>
        <false/>
        <key>JavaX</key>
        <dict>
            <key>MainClass</key>
            <string>com.redmondsims.gistfx.Main</string>
            <key>ClassPath</key>
            <array>
                <string>Java/GistFX-3.3.6-runnable.jar</string>
            </array>
            <key>VMOptions</key>
            <array>
                <string>--module-path=Java/libs</string>
                <string>--add-modules=javafx.controls,javafx.graphics,javafx.web</string>
            </array>
            <key>WorkingDirectory</key>
            <string>$APP_PACKAGE/Contents/Resources</string>
            <key>JVMOptionsFile</key>
            <string>$APP_PACKAGE/Contents/Resources/GistFX.l4j.ini</string>
        </dict>
        <key>LSEnvironment</key>
        <dict>
            <key>JAVA_HOME</key>
            <string>Contents/PlugIns/jre/Contents/Home</string>
        </dict>
        <key>NSAppleEventsUsageDescription</key>
        <string>There was an error while launching the application. Please
			click OK to display a dialog with more information or cancel and view
			the syslog for details.</string>
    </dict>
</plist>

then I was looking at the Info.plist file and saw this:
   <key>JVMOptionsFile</key>
            <string>$APP_PACKAGE/Contents/Resources/GistFX.l4j.ini</string>

And that file does not exist anywhere ... do you know what that's about?

Hi @EasyG0ing1!
No, that has nothing to do. It's a config file with VM arguments, loaded when running, and ignored if not exists. I'm sorry I can't help you much more.
Could you try to remove module-info.java from your JAR, and add a new Launcher class next to Main class, which calls Main.main(), and make this new class the mainclass (as explained here Solution 2)? Then remove <vmargs/> and try to run it again, please!

I have to improve JavaPackager to work better with modular apps ... until then, try this, please

@fvarrui  - OK, I did that ... and I removed the  from the pom file then re-packaged the project.
It runs fine on my dev machine without any problems at all. But when I run it on my Mac virtual machine (that is a clean install of MacOS and has no JDK or JRE installed anywhere) ... I get this error:
Last login: Tue Apr  5 04:53:06 on ttys000
Mikes-Mac:~ michael$ /Applications/GistFX.app/Contents/MacOS/universalJavaApplicationStub ; exit;
The operation couldn’t be completed. Unable to locate a Java Runtime.
Please visit http://www.java.com for information on installing Java.

Print: Entry, ":0:JVMVersion", Does Not Exist
Print: Entry, ":0:JVMHomePath", Does Not Exist
283:339: execution error: System Events got an error: A resource wasn’t found. (-192)
logout
Saving session...
...copying shared history...
...saving history...truncating history files...
...completed.
Deleting expired sessions...none found.

[Process completed]

Ok. Could you take a look at the syslog using Console.app? universalJavaApplicationStub logs the failures there.

@fvarrui - just to experiment, I installed jdk18 and without doing anything else (no JAVA_HOME set or anything), the app runs fine on the virtual machine now ... but I'm going to reset the snapshot and run it again then look at the logs as you suggest.

I'm not sure if the problem is with universalJavaApplicationStub launch script, but it seems that other JREs/JDKs installed on the system are interferring.

@fvarrui Well, like I said, there are no other JREs/JDKs installed on the virtual machine ... and Ive been looking in the console but nothing stands out, what am I looking for?

@fvarrui Well, like I said, there are no other JREs/JDKs installed on the virtual machine ...

Yes! You told me, sorry.

and Ive been looking in the console but nothing stands out, what am I looking for?

Any entry logged by universalJavaApplicationStub, to see if that throws any light on what's going on.

@fvarrui  no ita not logging anything at all

@fvarrui the only thing I see is this error in Terminal when I launch the program:
Last login: Tue Apr  5 05:48:35 on ttys001
Mikes-Mac:~ michael$ /Applications/GistFX.app/Contents/MacOS/universalJavaApplicationStub ; exit;
The operation couldn’t be completed. Unable to locate a Java Runtime.
Please visit http://www.java.com for information on installing Java.

Print: Entry, ":0:JVMVersion", Does Not Exist
Print: Entry, ":0:JVMHomePath", Does Not Exist
283:339: execution error: System Events got an error: A resource wasn’t found. (-192)
logout
Saving session...
...copying shared history...
...saving history...truncating history files...
...completed.

[Process completed]

@fvarrui - When I double click the icon, I get this error:
Application Specific Information:
dyld: launch, loading dependent libraries

Dyld Error Message:
  Library not loaded: @rpath/libjli.dylib
  Referenced from: /Applications/GistFX.app/Contents/PlugIns/jre/Contents/Home/bin/java
  Reason: no suitable image found.  Did find:
	/Applications/GistFX.app/Contents/PlugIns/jre/Contents/Home/bin/../lib/libjli.dylib: code signature in (/Applications/GistFX.app/Contents/PlugIns/jre/Contents/Home/bin/../lib/libjli.dylib) not valid for use in process using Library Validation: mapped file has no Team ID and is not a platform binary (signed with custom identity or adhoc?)

Binary Images:
       0x108535000 -        0x108538fff +java (18 - 0) <A6E07EF4-6B41-3AC6-A452-94F801DEB828> /Applications/GistFX.app/Contents/PlugIns/jre/Contents/Home/bin/java
       0x10b7b8000 -        0x10b853fff  dyld (852.2) <A7924265-DCEF-3515-B28E-3A8279B43E29> /usr/lib/dyld
    0x7fff2a638000 -     0x7fff2a64afff  libz.1.dylib (76) <73C471D3-07CE-307D-A531-92C5D0E4C0E9> /usr/lib/libz.1.dylib

@fvarrui - I opened this issue - you might want to ake a look ... and I found this issue which is the exact problem I'm having, only it says the problem was fixed.

But this other issue refers to universalJavaApplicationStub 3.1.0, and JavaPackager is using 3.2.0. It should be fixed, so, same error but different cause.
I've got a Mac Mini with MacOs 10.15 ... I'll try your project when arrive at home. Which Mac OS versions have you Mac Book and your VM?

Please, could you push your changes (in a new branch if you prefer)?

@fvarrui  - Yes, I will push the current code by the next hour or so ... and you are correct on your assertion of the issue I created on the launch script. The closed issue seemed to indicate that the problem was resolved. But clearly it's still a problem so hopefully the issue I opened will help with a fix or a plausible work-around of some kind.
He did say in the closed issue what the problem was in the script .... but on quick inspection - it's all greek to me ...
I'll post here when I posh the current code ... I gotta clean some things up in the project first.

@fvarrui - When I double click the icon, I get this error:
Application Specific Information:
dyld: launch, loading dependent libraries

Dyld Error Message:
  Library not loaded: @rpath/libjli.dylib
  Referenced from: /Applications/GistFX.app/Contents/PlugIns/jre/Contents/Home/bin/java
  Reason: no suitable image found.  Did find:
	/Applications/GistFX.app/Contents/PlugIns/jre/Contents/Home/bin/../lib/libjli.dylib: code signature in (/Applications/GistFX.app/Contents/PlugIns/jre/Contents/Home/bin/../lib/libjli.dylib) not valid for use in process using Library Validation: mapped file has no Team ID and is not a platform binary (signed with custom identity or adhoc?)

Binary Images:
       0x108535000 -        0x108538fff +java (18 - 0) <A6E07EF4-6B41-3AC6-A452-94F801DEB828> /Applications/GistFX.app/Contents/PlugIns/jre/Contents/Home/bin/java
       0x10b7b8000 -        0x10b853fff  dyld (852.2) <A7924265-DCEF-3515-B28E-3A8279B43E29> /usr/lib/dyld
    0x7fff2a638000 -     0x7fff2a64afff  libz.1.dylib (76) <73C471D3-07CE-307D-A531-92C5D0E4C0E9> /usr/lib/libz.1.dylib

Hi @EasyG0ing1! Please, take a look to this reply. Maybe your problem could be solved with a well defined entitlements.plist file when codesigning.

If you have a powerful enough PC, you can run MacOS in the free version of VMWare - Workstation (or maybe it's VMWare Player) I believe it's called for Windows - Fusion is the Mac flavor.

Yes, I've got a MacOS 10.12.6 in a VM (I'm using VirtualBox) ... but I haven't had time to get a newer version

@fvarrui You do know that thre is a free version of VMWare for personal use? I like it much better than VirtualBox, personally.
I just pushed the latest code into the repository ... had to battle some monsters which took some time.
Mike

@fvarrui

Hi @EasyG0ing1! Please, take a look to this https://github.com/fvarrui/JavaPackager/issues/185#issuecomment-1091441915. Maybe your problem could be solved with a well defined entitlements.plist file when codesigning.

My issue isn't with code signing, it's with the app launching without being able to find the java executable when I don't have a JDK or JRE installed separately on the machine.

@fvarrui - So this is interesting ... reading that other issue more carefully, I noticed that the guy said that he was able to get it to work with packager version 1.6.2, so I tried that and sure enough, it works just fine.
Do you have any idea why?

@fvarrui - ok, the pull request you made, once I committed it, then re-packaged on MacOS, using version 1.6.6 of the packager, worked perfectly.
☺

The current push to the repository is the working version by the way.

Great news! 😄
Sorry, I didn't have time before to explain to you in the PR why entitlements solve the problem. As Mabula (@AstroPixelProcessor) explained, AFAIK, the entitlements file contains the permissions required by the app, and which must be granted by the OS. I tried on my Mac mini using entitlements and it worked like a charm. So your app's problem wasn't that it was not able to find the JRE, but it was that the JRE libraries did not have permissions to be loaded. Exactly, this entitlement:
<key>com.apple.security.cs.disable-library-validation</key>
<true/>

tells the OS not to validate the libraries (.dylib files). So, problem fixed!!!
So many thanks to @AstroPixelProcessor!!!

Change platform property from mac to linux 😅 that's what I told you last time for building for mac. Good luck! 😄

No, seriously now. You can do two things:

Set platform=linux and run mvn clean package from a Linux system (easiest way)

Set platform=linux, jdkPath=path/to/linux/jdk and run mvn clean package -Djavafx.platform=linux from any system.

And, of course, set linuxConfig.generateDeb=true and/or linuxConfig.generateRpm=true, and iconFile=path/to/png/file.

Once you have managed to build your app for all platforms, it would be a good idea to use GitHub Action workflows to generate each installation artifact in the cloud. ASAP I'm going to make an example.

@fvarrui

So your app's problem wasn't that it was not able to find the JRE, but it was that the JRE libraries did not have permissions to be loaded.

Ah! That makes perfect sense. And yes, thanks to @AstroPixelProcessor for this solution ...
Next item on the agenda ... LINUX! And I don't even know where to begin.

Excellent, glad to contribute!


storage:stream: allow NULL data pointer when len is 0

This is done to support the idiomatic way of performing flush operations,
where the caller might not have access to the proper data pointer.
When the length is 0 there is no reason to require a pointer to data.
Signed-off-by: Håkon Øye Amundsen<EMAIL_ADDRESS>

I would add description for supported API behaviour to API doxygen.

I would add description for supported API behaviour to API doxygen.

I changed the PR according to @de-nordic 's feedback. Instead of checking the len the function now allows data to be NULL. So I don't think we need to change the API now.

@nvlsianpu do you think that this simple change could be merged if @hakonfam fixes shippable?

I assume the buildkite failure is not a blocker for now?

I assume the buildkite failure is not a blocker for now?

I do not think so. @carlescufi do you think this could be merged already?

@hakonfam - just rebase on master, should help with buildkite


Fatal error encountered

16:15:52: Fatal error encountered:
16:15:52:
16:15:52: Traceback (most recent call last):
16:15:52:   File "main.py", line 175, in
16:15:52:   File "asyncio\base_events.py", line 616, in run_until_complete
16:15:52:   File "twitch.py", line 759, in run
16:15:52:   File "twitch.py", line 778, in _run
16:15:52:   File "twitch.py", line 1449, in get_auth
16:15:52:   File "twitch.py", line 512, in validate
16:15:52:   File "twitch.py", line 521, in _validate
16:15:52:   File "contextlib.py", line 171, in aenter
16:15:52:   File "twitch.py", line 1474, in request
16:15:52:   File "gui.py", line 1946, in coro_unless_closed
16:15:52:   File "aiohttp\client.py", line 1125, in send
16:15:52:   File "aiohttp\client.py", line 536, in _request
16:15:52:   File "aiohttp\connector.py", line 540, in connect
16:15:52:   File "aiohttp\connector.py", line 901, in _create_connection
16:15:52:   File "aiohttp\connector.py", line 1175, in _create_direct_connection
16:15:52:   File "aiohttp\connector.py", line 980, in _wrap_create_connection
16:15:52:   File "asyncio\base_events.py", line 1010, in create_connection
16:15:52:   File "asyncio\base_events.py", line 924, in _connect_sock
16:15:52:   File "asyncio\proactor_events.py", line 702, in sock_connect
16:15:52: RuntimeError: await wasn't used with future
16:15:52:
16:15:52: Exiting...
16:15:53:
16:15:53: Application Terminated.
16:15:53: Close the window to exit the application.
how to fix it？

This is a duplicate of #80.


Ch02 - Preprocessing - 'preprocess_expanded' function does not take the global end date but the individual 'ts' max_date

see line[32] in 02 - Preprocessing London Smart Meter Dataset. Does that need a modification?

Can you post the line here? not able to find the numbered line you are referring to?

Yeah here it is,  for the expanded form you are using x['day'].max() instead of max_date:
dr = pd.date_range(start=x['day'].min(), end=x['day'].max(), freq="1D")
Also, the pre-processing steps make sense but for some reason, experimenting with block_1: for compact form, I was not able to find any NaNs despite some of the LCLids having an earlier end_date and altho the expanded form has NaNs, they are in its LCLid and not missing values for existing LCLids (do we need a ffill here?)

I guess this line is from the expanded form function. It is x['day'].max() itself, because intention there is to insert NaNs only in between start and end of each time series..  If a timeseries last value is before max_date, we are not adding NaN from that date to max_date.
And in compact form, there wouldn't be NaNs because the entire timeseries is stored as a list in a cell of the dataframe.. the NaN would be inside the list.

I see, that makes sense. It raises one more question from me though - why are adding NaN from end of time series to max_date for the compact form preparation. Also, you might need to make a some update to the book to the expanded form function explanation (you mention - "2. Create a standard DataFrame using the start date and the global end date." instead of x['day'].max
Thanks for your time. Really appreciate it!

closing the issue


Solution for Glyphicons Pro Users

Hi-
The animation problem for users of Glyphicons Pro referenced in Issue #56 is a conflict between Glyphicons Pro and Eden's Animate.css package.  Both of these packages use the CSS class animated to apply some basic styles.  In the case of Glyphicons Pro, they explicitly set the animation-iteration-count property to infinite so the animations will repeat, whereas Animate.css uses the separate infinite class to accomplish this.  The animations loop as seen in the video posted on Issue #56 because the animation-iteration-count property is set to infinite by the Glyphicons Pro stylesheet.
Solutions would include anything that sets the animation-iteration-count property to 1 for bootstrap notifications.  This could be accomplished by adding another class to animated notifications, e.g.:
body .animate-once {
    -webkit-animation-iteration-count: 1;
    animation-iteration-count: 1;
}

$.notify('foo', { animate: { enter: 'animated fadeInRight animate-once' } });

From the perspective of Bootstrap Notify, the solution should probably be to add an inline style for this property to the .alert div.
Hope this helps other users!
UPDATE: Lest any Glyphicons Pro users think they are going crazy, I talked to the Glyphicons dev and he confirmed that animated icons is a feature that exists, though it's "more of an Easter egg and totally undocumented." :-)

If I made a small change and asked you to test it would you be able to. I do not have Glyphicons Pro.

Sure.  Though my git-foo isn't very good, so it might take me a bit to get
latest.
Steve
On Wednesday, April 29, 2015, Robert McIntosh<EMAIL_ADDRESS>wrote:

If I made a small change and asked you to test it would you be able to. I
do not have Glyphicons Pro.
—
Reply to this email directly or view it on GitHub
https://github.com/mouse0270/bootstrap-notify/issues/87#issuecomment-97390943
.

Thank you! I was able to test this by just creating a class called animated and setting animation-iteration-count to infinite
This is fixed as of version 3.1.3

Confirmed fixed.  Thanks for the quick fix!
Don't forget to update your home page too. ;-)

Is it not updated?

Version got updated in the title, but there is still the text blurb about glyphicons pro under the Using a Font Icon section.

Good catch, I forgot about the blurb. haha


Mutate rule labels, annotations to strings

Prometheus natively unmarshals rule label and annotation values to strings, kubernetes does not. This creates an inconsistency in behaviour in cases where someone runs promtool on the contents of the PrometheusRules.spec and then tries to apply it. For example, this is fine in promtool but rejected by the operator webhook:
groups:
  - name: invalid-in-operator
    interval: 15s
    rules:
    - alert: ValidInPrometheus
      expr: absent_over_time(up[5m])
      labels:
        bool: true
      annotations:
        num: 1

This PR updates the already existing mutating webhook, to patch annotation and label values to strings before this becomes a problem in the validating webhook.
There should be no negative impact due to the "unexpected" nature of this alteration:

Established invalid rules would fail to be loaded by the operator anyway
Previously rejected rules will be patched to a valid state

Also update to using admission/v1 because this is now available and doesn't have any impact.
Fixes: #3223

Very awesome! Lgtm but giving others a chance to review as well @lilic @simonpasquier @pgier

Don't you need to update pkg/operator/defaults.go too? Otherwise LGTM.

Don't you need to update pkg/operator/defaults.go too? Otherwise LGTM.

That got picked up when I rebased this pull request


Cleanup doesn't work as expected

Sometimes,  when I quit pipes.sh by pressing a key, the terminal keeps showing some pipes until they are overriden by new standard outputs.
Adding clean just before exit 0 on cleanup seems to fix this at least for me.
Here is a patch if I wasn't clear enough
I hope you find this useful!

What's your OS and terminal emulator?
That clear fix isn't ideal as it would overwrite the restore screen.  When pipes.sh runs it save the current screen and restore when exits, could you take a screenshot of what exactly you see.  I suspect the save/restore doesn't work in your terminal.

Hey, it was an issue using bash and Terminator under Ubuntu 16.04 iirc. With a newer version of both packages it seems to be working properly. I'm closing this issue.


simpify the map_list configuration file loaded by mf_localization

This change makes some parameters in map config in cabot_site not required because these parameters can be set by using other parameters.
anchor:
    ...
map_list:
  - node_id: # not required (set as the default value "carto_" + floor + "_" + area)
    frame_id: # not required (set as the default value "map_" + node_id)
    latitude:
    longitude:
    rotate:
    floor:
    area: 0 # not required (calculated from floor)
    load_state_filename:
    samples_filename:
    map_filename:

I also pushed dev-ros2-simplify-map-load branch that can be merged into dev-ros2 branch.


Update Layer

Extend parameter off 'add' function to be ambivalent 'IPrimitive | IPrimitive[]'.
Like in the documentation.

Hi @SteffenMangold, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

Thanks for the fix. Think the dev team may have given me an old definition file. Will double check the layer class.


ButtonPress events should short-circuit vanilla handling

ButtonPress was an event added in the last release and although it looks the same as e.g. Click, it has some different lifecycle characteristics. Specifically, it is the only event that happens in receiveKeyPress and runs before delegation to vanilla logic.
For other events, we don't need a return value from InitiateXyz because it would never be used, but for ButtonPress, whether or not the event was handled can have an effect on later logic. One user was trying to prevent dismissal by hooking the menu button(s) and returning true from the handler, but it did not have the intended outcome of preventing the menu from being closed.
Simply, the ViewMenu needs to get the actual result from InitiateButtonPress and use it to return early if handled. A secondary question is whether the dispatch logic should run before the overlay-cancellation logic, as right now it runs after, and I can't remember if that was on purpose or arbitrary. Probably it should be able to short-circuit an overlay dismissal too, but I remember this being "touchy" when working on the keybind editor in particular, so it'll have to be tested for that.

Started looking at this but I'm not sure it's entirely useful/correct for the scenario outlined.
First of all, the actual gamepad button press has its own handler, which is skipped in the receiveKeyPress handler when it detects as being from gamepad. This means that, absent some hacks or more significant rework, we can only "suppress" keyboard keys (E/ESC), while gamepad B will still appear to ignore the outcome (since it's the key-press event that really handles it, as confusing as that is).
Second, and maybe more importantly, the button press event is only captured while the cursor is actually inside the menu's root view. With controller focus this is sort of workable, but with mouse movement it's just going to seem inconsistent and unreliable.
For the time being, it might be better to focus on some way to prevent menu dismissal at the actual menu level. Vanilla does have a way to deal with this explicitly (readyToClose()) which doesn't involve fussing over keys and input devices. The question is how to bind it with StarML, since we can't override the menu.
This really has to operate at or near the API level; at the view level we start running into complicated questions about included views, custom (add-on) views, different root types, etc. Passing a Func<bool> into the CreateMenu methods is one way, but as we discovered in the M3 release, it's actually not a backward-compatible change in Pintail-land even when the parameter is optional.
So the best alternative that comes to mind is to add a new interface to encapsulate any menu-level behavior, and the context type can implement that interface. Unfortunately, Pintail is not going to do all the work for us here either, because the interface isn't part of the API signature; the interface is really just a way to mark the context type and provide a bit of type safety on the modder's side, so we'd essentially have to do a modified duck-type conversion that involves looking for an interface with the same name, and mapping the properties/methods/etc.
Will see if a better idea comes to mind before starting on an implementation.

Closing in favor of #52.


[Logic] Sync SDK with swagger updates

Description
Updating the Logic Apps SDK based on the newest version of the swagger. This adds 2 new endpoints which both have Get and List. Also this includes a bugfix where a user could not update a Logic App that had an attached Integration Account.
Bugfix PR
New endpoints PR

This checklist is used to make sure that common guidelines for a pull request are followed.

[x] Please add REST spec PR link to the SDK PR
[x] I have read the contribution guidelines.
[x] The pull request does not introduce breaking changes.

General Guidelines

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[x] Pull request includes test coverage for the included changes.

SDK Generation Guidelines

[x] If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
[ ] The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
[x] The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

Regenerated the code from a fresh pull.


[feat] support gpt-4o-mini model and deprecate gpt-3.5-turbo.

Summary

support gpt-4o-mini model and deprecate gpt-3.5-turbo model
ref: https://platform.openai.com/docs/models/gpt-4o-mini

Thank you for review @platfowner! now merging..


github action create gist file error

first time it can make file,but file content not change
and second time the file lose, and console print:
Unable to update gist
HttpError: Validation Failed: {"resource":"Gist","code":"missing_field","field":"files"}
cause: wakatime has not data (last 7 days from yesterday)

Manually recreating a file in the gist might help.


Custom securityContext in template

Hello, we currently use kubed in a cluster that has very strict security policies enabled. One of them requires us to specify that each k8s workload has to run as non root, not only in the docker image itself, but also in the security context of the workload. Specifically, we need to add the following key:
securityContext:
    runAsNonRoot: true

I have followed the same approach currently used for pod resources, which is converting the values dictionary directly into yaml in the template, using toYaml. This would let us modify securityContext to fit our requirement, while the default value is the same as it currently is hardcoded in the template.
Please let me know if the pull request is incomplete.

Thanks @jsrolon !


return code 409 instead of 500 for revert conflict

handleAPIError mapped graveler.ErrConflictFound to the default http.StatusInternalServerError (500) instead of the expected http.StatusConflict (409)
Fixed that and added an Esti test to create a conflict, attempt a revert and verify the status code

Closes #3482

swagger.yml added documentration of 409 response for revert

New responses need to be added to the swagger file too.

swagger.yml added documentration of 409 response for revert. Thanks for pointing this out


Typescript docs models should have openAIApiKey key in docs

Added reference to openAIApiKey key value pair in javascript documentation for guide-llm.

Thanks for the PR! The env var vs. explicit passing is explained here:
https://js.langchain.com/docs/getting-started/guide-llm#llms-get-predictions-from-a-language-model
Also, if we were to update to this style, we'd want to update it everywhere.


Integration Test - Release - 2022/01/05 05:22:56

Auto create for integration test. IssueCommandFlow

#pri1

Only Microsoft employees can manage issues via commenting in this repo.


Release 0.6.0-rc1

closes https://github.com/confio/poe-contracts/issues/88

And perhaps #96 as well?


ISO8601DateTransform by regex

hi
will be great if the ISO8601DateTransform class validate all of the possibilities of a ISO8601 String, maybe by a regular expression

I commented on #644. The idea is good but in the PR the tests were failing. THanks


chore:  upgrade sttp

Upgrade com.softwaremill.sttp
Changelog / release notes are proving elusive.
Homepage: https://github.com/softwaremill/sttp

While sttp is using the fs2 backend, it appears to be a transitive dependency ( https://sttp.readthedocs.io/en/v1/backends/asynchttpclient.html ) .  The fs2-io dependency looks to be for a separate purpose ( referenced in WizardApi ). It appears like the two are unrelated in terms of compatible version requirements.

Nothing stood out as problematic going from 1.6.4 (current) to 1.7.2 (latest in the v1 series).
compile succeeded, however, equellaserver/run failed to launch the institutions.do page and threw:

Actually, according to the sttp pom it needs circe 0.12.1 at least ( https://repo1.maven.org/maven2/com/softwaremill/sttp/circe_2.13/1.7.2/circe_2.13-1.7.2.pom ).
Unfortunately, the upgrade didn't upgrade all the transitive deps that I was hoping for, so I'm holding off on submitting a PR for now.  The relavent bits to change in the equellaserver/build.sbt:


Keep output files

Dear Prof. Kraska,
Each time a user runs test.py he produces many output files. Why don't you keep all output files on the GutHub repository?
I suppose it could be useful: for example, if someone fail to successfully run an example and generate all the model files, he still can use models directly from the repository.
Also keeping all the files on the GitHub is useful for developers. Now before committing a new feature a have to delete all generated output files. It's bothering.

I want to keep a minimal footprint in terms of storage space and bandwidth. Therefore I limit the repository to the source files and those result files (mainly images) required for documentation.
Yet I understand that some users might not get CGX to work, but still want to test CCX. I could add the required files for some selected examples. Which candidates would you recommend for this?
Would the complete CCX input be sufficient or would you also want the FRD files?
As to git committing: I am not sure that I get your point right:
I never delete any file just for committing something new. Instead, I add the new or updated files explicitly using git add. I am not a git power user and there might be more efficient approaches. I guess things could get a lot easier with proper use of .gitignore.
In the context of automatic regression testing I thought of adding some reference results to the repository for automatic diff check with new CGX/CCX versions or as local sanity check for new users. This is what the test.py scripts finally should do. Not just run the simulation but also check for differences to the reference results.

Now before each commit I delete all produced files to minimize affect on your repository and to simplify your work on checking everything during merging. Staging feature helps but not so much.
For future I can propose to improve scripts in a way when all output files will be saved to a separate directory like 'Refs'. It will simplify committing. And to exclude all result files from committing we may only add 'Refs' folder to the .gitignore.
Into 'Refs' you could save results for absolutely all examples and push everything to the GitHub - don't care about bandwidth and storage. With FRD it'll be approximately 1.1 GB.

1.1GB is 20 times the current size of 50MB.  I could easily get stuck with a broken system.  This may change in future but not soon...

OK. But at least putting output files into 'Refs' directory is good for order.


Zomato Dataset added by MihirRajeshPanchal

🛠 Fixes Issue

Example: Closes #302
👨💻 Changes proposed

✔ Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[x] This PR does not contain plagiarized content.
[x] The title of my pull request is a short description of the requested changes.

📄 Note to reviewers
Zomato Dataset added by MihirRajeshPanchal
Clueless Community Profile : https://www.clueless.tech/profile/admin/105093933941494861305
📷 Screenshots

Good one @MihirRajeshPanchal
Congrats 🎉, your PR got merged. To be eligible for the swags from ClueLess. Follow these steps.

Star this repository. ⭐
Follow Clueless on GitHub
SignIn / SignUp in [ClueLess Website](https://www.clueless.tech/) .
Go to the profile section from the top right-hand corner.

Comment your profile URL under this comment tagging the person who merged your PR.

That’s it. Follow the leaderboard!
And don’t forget to share your achievement with your friends.

@nikhil25803
https://www.clueless.tech/profile/admin/105093933941494861305


Added Matrix Multiplication to C++ folder

Also modified the contributors.md file

@all-contributors add @bakuku22 for code


iris.Constraint.extract() should alert the user if None returned

✨ Feature Request
iris.Constraint.extract() should alert the user if None returned, rather than silently returning None.
Motivation
There are cases where the user might expect iris.Constraint.extract() to return a cube, but you get None.  For example, due to a floating point mismatch between float32 vs float64. Although this might be expected behaviour it's not very user-friendly and there seems to be iris precedent for warning users eg. coordinate bounds
Additional context
This issue continues an email discussion started with @jamesp
Suggestion
As with iris.coords issue a warnings.warn() with a helpful message. Hopefully this will avoid a breaking change?

Thanks for getting in touch @hsteptoe, we've discussed this one at length within the team.

There are cases where the user might expect iris.Constraint.extract() to return a cube, but you get None.  For example, due to a floating point mismatch between float32 vs float64. Although this might be expected behaviour it's not very user-friendly and there seems to be iris precedent for warning users eg. coordinate bounds

We actually often hear from users that Iris already raises too many warnings, and there is a risk that people become over saturated and don't know which warnings actually need their attention. We are therefore very reluctant to add further warnings unless we believe the majority of users need to be notified (and indeed we hope to reduce the volume of warnings in future). As documented behaviour, this isn't a case for which we want to add an Iris warning.
If there is specific behaviour that you need to be warned about, we recommend including your own warning, or perhaps an assertion or exception, in your own script(s).


Mixtral LoRA error

Please check that this issue hasn't been reported before.

[X] I searched previous Bug Reports didn't find any similar reports.

Expected Behavior
Expected to run lora fine-tuning on 2xA100 GPU
Current behaviour
  File "/root/miniconda3/envs/py3.10/lib/python3.10/site-packages/torch/_tensor.py", line 487, in backward
    torch.autograd.backward(
  File "/root/miniconda3/envs/py3.10/lib/python3.10/site-packages/torch/autograd/__init__.py", line 200, in backward
    Variable._execution_engine.run_backward(  # Calls into the C++ engine to run the backward pass
  File "/root/miniconda3/envs/py3.10/lib/python3.10/site-packages/torch/autograd/function.py", line 274, in apply
    return user_fn(self, *args)
  File "/root/miniconda3/envs/py3.10/lib/python3.10/site-packages/torch/utils/checkpoint.py", line 141, in backward
    outputs = ctx.run_function(*detached_inputs)
  File "/root/miniconda3/envs/py3.10/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1501, in _call_impl
    return forward_call(*args, **kwargs)
  File "/root/miniconda3/envs/py3.10/lib/python3.10/site-packages/accelerate/hooks.py", line 164, in new_forward
    output = module._old_forward(*args, **kwargs)
  File "/workspace/axolotl/src/axolotl/monkeypatch/mixtral/modeling_mixtral.py", line 172, in mixtral_decoder_layer_forward
    hidden_states, router_logits = self.block_sparse_moe(hidden_states)
  File "/root/miniconda3/envs/py3.10/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1501, in _call_impl
    return forward_call(*args, **kwargs)
  File "/root/miniconda3/envs/py3.10/lib/python3.10/site-packages/accelerate/hooks.py", line 164, in new_forward
    output = module._old_forward(*args, **kwargs)
  File "/root/miniconda3/envs/py3.10/lib/python3.10/site-packages/transformers/models/mixtral/modeling_mixtral.py", line 707, in forward
    router_logits = self.gate(hidden_states)
  File "/root/miniconda3/envs/py3.10/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1501, in _call_impl
    return forward_call(*args, **kwargs)
  File "/root/miniconda3/envs/py3.10/lib/python3.10/site-packages/peft/tuners/lora/bnb.py", line 168, in forward
    result += output
RuntimeError: Output 0 of MatMul8bitLtBackward is a view and is being modified inplace. This view was created inside a custom Function (or because an input was returned as-is) and the autograd logic to handle view+inplace would override the custom backward associated with the custom Function, leading to incorrect gradients. This behavior is forbidden. You can fix this by cloning the output of the custom Function.

Steps to reproduce
Run axolotl docker image on Runpod 2xA100 GPU with lora 8bit. Qlora works
Config yaml
base_model: mistralai/Mixtral-8x7B-v0.1
model_type: AutoModelForCausalLM
tokenizer_type: LlamaTokenizer
trust_remote_code: true

load_in_8bit: true
load_in_4bit: false
strict: false

datasets:
  - path: tatsu-lab/alpaca
    type: alpaca
dataset_prepared_path: last_run_prepared
val_set_size: 0.0
output_dir: ./qlora-out

## You can optionally freeze the entire model and unfreeze a subset of parameters
unfrozen_parameters:
#  - lm_head.*
#  - model.embed_tokens.*
#  - model.layers.2[0-9]+.block_sparse_moe.gate.*
#  - model.layers.2[0-9]+.block_sparse_moe.experts.*
#  - model.layers.3[0-9]+.block_sparse_moe.gate.*
#  - model.layers.3[0-9]+.block_sparse_moe.experts.*

adapter: lora
lora_model_dir:

sequence_len: 4096
sample_packing: true
pad_to_sequence_len: true

lora_r: 32
lora_alpha: 16
lora_dropout: 0.05
lora_target_linear: true
lora_fan_in_fan_out:
#lora_target_modules:
#  - gate
#  - q_proj
#  - k_proj
#  - v_proj
#  - o_proj
#  - w1
#  - w2
#  - w3

wandb_project:
wandb_entity:
wandb_watch:
wandb_name:
wandb_log_model:

gradient_accumulation_steps: 2
micro_batch_size: 1
num_epochs: 1
optimizer: adamw_bnb_8bit
lr_scheduler: cosine
learning_rate: 0.0002

train_on_inputs: false
group_by_length: false
bf16: true
fp16: false
tf32: false

gradient_checkpointing: true
early_stopping_patience:
resume_from_checkpoint:
local_rank:
logging_steps: 1
xformers_attention:
flash_attention: true

loss_watchdog_threshold: 5.0
loss_watchdog_patience: 3

warmup_steps: 10
evals_per_epoch: 4
eval_table_size:
eval_table_max_new_tokens: 128
saves_per_epoch: 1
debug:
deepspeed: deepspeed/zero2.json
weight_decay: 0.0
fsdp:
fsdp_config:
special_tokens:

Possible solution
No response
Which Operating Systems are you using?

[X] Linux
[ ] macOS
[ ] Windows

Python Version
3.10.13
axolotl branch-commit
main
Acknowledgements

[X] My issue title is concise, descriptive, and in title casing.
[X] I have searched the existing issues to make sure this bug has not been reported yet.
[X] I am using the latest version of axolotl.
[X] I have provided enough information for the maintainers to reproduce and diagnose the issue.

This is a known issue atm. I ran into this as well attempting regular Lora.

I'm hitting the same error. I can also confirm that qLoRA works fine.

The only thing I can get working lora, qlora, or fp16 is the 4-bit config provided, everything else is OOM or another error.

I could fix this RuntimeError: Output 0 of MatMul8bitLtBackward is a view and is being modified inplace. with: https://github.com/huggingface/peft/pull/1372/files.
After that, I came across the issue:
Traceback (most recent call last):
  File "/home/demo.py", line 43, in <module>
    loss.backward()
  File "/home/venv/lib/python3.10/site-packages/torch/_tensor.py", line 492, in backward
    torch.autograd.backward(
  File "/home/venv/lib/python3.10/site-packages/torch/autograd/__init__.py", line 251, in backward
    Variable._execution_engine.run_backward(  # Calls into the C++ engine to run the backward pass
  File "/home/venv/lib/python3.10/site-packages/torch/autograd/function.py", line 288, in apply
    return user_fn(self, *args)
  File "/home/venv/lib/python3.10/site-packages/bitsandbytes/autograd/_functions.py", line 485, in backward
    .mul_(state.SCB.unsqueeze(1).mul(1.0 / 127.0))
RuntimeError: The size of tensor a (32) must match the size of tensor b (8) at non-singleton dimension 0

Has anyone had any success in training 8-bit LoRA fine-tuning for Mixtral with 80GB? Thank you.

File "/XXXXXX/miniconda3/envs/lora/lib/python3.10/site-packages/bitsandbytes/autograd/_functions.py", line 485, in backward
    .mul_(state.SCB.unsqueeze(1).mul(1.0 / 127.0))
RuntimeError: The size of tensor a (32) must match the size of tensor b (8) at non-singleton dimension 0

I encountered the same issue


deps: update gapic-showcase to v0.33.0

update gapic-showcase so that we can pickup changes in https://github.com/googleapis/gapic-showcase/pull/1484
Steps:

Updated the gapic-showcase version in gapic-showcase/pom.xml to 0.33.0
Ran mvn compile -P update

@burkedavison Do you remember what this showcase version value in the WORKSPACE file is for? https://github.com/googleapis/sdk-platform-java/blob/main/WORKSPACE#L110
Do we need to keep this updated/ is this used at all?

2 failed cis:

showcase-clirr - okay to ignore according to https://github.com/googleapis/sdk-platform-java/pull/2354#issuecomment-1889954320
[gapic-generator-java-root] sonarcloud.

For coverage on new code, other than api-version, most changes comes from proto change related to request-id. cc. @alicejli for context.
For duplication and reliability, consider these are generated code, Wonder what's our general approach here? cc. @lqiu96 @blakeli0

For duplication and reliability, consider these are generated code, Wonder what's our general approach here?

I think it's fine for us to merge it in. We can't change the protoc generated code and the generated output from the gapic-generator probably needs a larger refactor to "fix".

@blakeli0 @lqiu96 Could you take another look?
I'd like to merge this in if it looks good.


Android Basics: Preference Datastore

URL of codelab
https://developer.android.com/courses/pathways/android-basics-kotlin-unit-5-pathway-2?hl=en#codelab-https://developer.android.com/codelabs/basic-android-kotlin-training-preferences-datastore
In which task and step of the codelab can this issue be found?
Task 4 , Step 4
Describe the problem
The tutorial ask to "Add a constructor parameter to the SettingsDataStore class of the type Context", but then we get the error "Property delegate must have a 'getValue(Context, KProperty<>)' method.
Steps to reproduce?

Implement the application as stated in https://developer.android.com/courses/pathways/android-basics-kotlin-unit-5-pathway-2?hl=en#codelab-https://developer.android.com/codelabs/basic-android-kotlin-training-preferences-datastore
Add a constructor parameter to the SettingsDataStore class of the type Context
Get compiling errors as the constructor is not correctly formed

Versions
Android Studio version:  2021.1.1
API version of the emulator: 30

Had the same problem, added kotlinx-coroutine-android dependency and it worked:
dependencies {
    (...)
    implementation "androidx.datastore:datastore-preferences:1.0.0"
    implementation "androidx.lifecycle:lifecycle-livedata-ktx:2.3.1"
    implementation "org.jetbrains.kotlinx:kotlinx-coroutines-android:1.5.2"
}

Got this issue because I was importing the wrong Preferences class.
Replace this:
import java.util.prefs.Preferences

By:
import androidx.datastore.preferences.core.Preferences


Adding Norlington School and 6th Form School

@Atrixss Please provide us with a proof, which shows that the school recognizes the domain you are submitting as an official email domain for the students.
You can provide us with any of the following:

A copy of instruction (a hard-copy or electronic one) given to you by the school that tells you to use an email address in this email domain
An URL of a page at the official school website that says that students use this email domain
A reference to a recognized journal where an article was published by someone from the school, with explicit affiliation to the school, and e-mail address from the email domain
A WHOIS data that link the email domain to the school somehow
A copy of official letter from the school representative saying that the school provides e-mail addresses in this domain to the students
Anything else that can prove this fact in similar way, i.e. can be verified independently.

https://www.namecheap.com/domains/whois/result?domain=norlington.school
school website: https://www.norlington.net/
the school has two domains, norlington.net for the website and norlington.school is used for emails

@Atrixss Thank you for the clarification. Pull request merged.


tests: fix CI errors on github actions

Signed-off-by: Fernando Fernandez Mancera<EMAIL_ADDRESS>

@cathay4t This is a trivial fix for the stable CI.

@cathay4t This is fixing several errors from CI. Thanks!


numbers without format should be disallowed

Looks like correct implementation should threat absent format as "unlimited". Accordingly to this thread: https://github.com/OAI/OpenAPI-Specification/issues/162

Accordingly to the specification:
integer:  A JSON number without a fraction or exponent part.
number: Any JSON number. Number includes integer

BigInteger and BigDecimal would be appropriate types in this case.


Select text on Focus

Would it be possible to add an additional feature to this directive:
-When autofocus attribute is set on an input tag, it selects all of its text?
-Ability to turn this additional feature on and off per element or globally

https://github.com/hiebj/ng-autofocus/commit/685a7047ff91d10e23812c1b6a73fe16bc3e582f

Can also be used with autofocus if you want. Technically they are separate directives. autoselect will highlight all the text on a field any time it is focused, regardless whether it was triggered by autofocus.
Does this serve your use case? I realize this implementation means that all text will be selected anytime the field is focused under any conditions, not just when focus is triggered by autofocus. I figured that autoselect is kind of a separate thing that you might want to do even without autofocus.

https://github.com/hiebj/ng-autoselect
Try that. At first I added the functionality to ng-autofocus, but they are really separate directives. It should work great using both:
<input autoselect autofocus />

http://jsfiddle.net/hiebj/54cz9c6v/
Note that autofocus doesn't work in JSFiddle, for some reason it has trouble with the iframe.
I'll publish the ng-autoselect package as soon as I have a chance to write up a README.

I will give it a try.  Thanks for the quick feedback.


Crash after selecting a profile

I tested this project by curiosity, but after having created a profile, the application crashed:
└> python --version
Python 3.8.10

Traceback (most recent call last):
  File "/home/leo/sources/osc-tui/osc_tui/main.py", line 94, in <module>
    sys.exit(main())
  File "/home/leo/sources/osc-tui/osc_tui/main.py", line 85, in main
    APP.run()
  File "/home/leo/sources/osc-tui/env/lib/python3.8/site-packages/npyscreen/apNPSApplication.py", line 30, in run
    return npyssafewrapper.wrapper(self.__remove_argument_call_main)
  File "/home/leo/sources/osc-tui/env/lib/python3.8/site-packages/npyscreen/npyssafewrapper.py", line 41, in wrapper
    wrapper_no_fork(call_function)
  File "/home/leo/sources/osc-tui/env/lib/python3.8/site-packages/npyscreen/npyssafewrapper.py", line 97, in wrapper_no_fork
    return_code = call_function(_SCREEN)
  File "/home/leo/sources/osc-tui/env/lib/python3.8/site-packages/npyscreen/apNPSApplication.py", line 25, in __remove_argument_call_main
    return self.main()
  File "/home/leo/sources/osc-tui/env/lib/python3.8/site-packages/npyscreen/apNPSApplicationManaged.py", line 172, in main
    self._THISFORM.edit()
  File "/home/leo/sources/osc-tui/env/lib/python3.8/site-packages/npyscreen/fm_form_edit_loop.py", line 47, in edit
    self.edit_loop()
  File "/home/leo/sources/osc-tui/env/lib/python3.8/site-packages/npyscreen/fm_form_edit_loop.py", line 38, in edit_loop
    self._widgets__[self.editw].edit()
  File "/home/leo/sources/osc-tui/env/lib/python3.8/site-packages/npyscreen/wgwidget.py", line 447, in edit
    self._edit_loop()
  File "/home/leo/sources/osc-tui/env/lib/python3.8/site-packages/npyscreen/wgwidget.py", line 463, in _edit_loop
    self.get_and_use_key_press()
  File "/home/leo/sources/osc-tui/env/lib/python3.8/site-packages/npyscreen/wgwidget.py", line 599, in get_and_use_key_press
    self.handle_input(ch)
  File "/home/leo/sources/osc-tui/env/lib/python3.8/site-packages/npyscreen/wgwidget.py", line 71, in handle_input
    self.handlers[_input](_input)
  File "/home/leo/sources/osc-tui/env/lib/python3.8/site-packages/npyscreen/wgbutton.py", line 99, in h_toggle
    self.whenPressed()
  File "/home/leo/sources/osc-tui/osc_tui/profileSelector.py", line 43, in __call__
    main.GATEWAY.log.config(type=LOG_MEMORY, what=LOG_KEEP_ONLY_LAST_REQ)
AttributeError: 'compiled_function' object has no attribute 'config'

Is it something known?
Credentials set in the profile are working elsewhere.
Thanks!

Yes, osc_sdk_python introduce a log class in version 0.14.0, and osc-tui fail here because your osc_sdk_python is too old.
though not checking the osc_sdk_python version is a bug on osc-tui which should now be fix on master.

I confirm it works now.


fix field exclusion for views

Fixes #207

Thanks for contributing. We'll take a look soon.

Hey @nolanprocore, any updates on this?

Hey @nolanprocore, any updates on this?

Not yet. It looks like you've got a spec failure here. Have you taken a look at that yet?

@nolanprocore it seems that rspec-rails 4.0.0 is not compatible with ruby 2.2 - https://github.com/rspec/rspec-rails/blob/master/Changelog.md
rspec-rails 4.0.0 was installed because of
    ammeter (1.1.4)
      activesupport (>= 3.0)
      railties (>= 3.0)
      rspec-rails (>= 2.2)

Should I fix build in this PR, or it'll be better to create new one?

@tpltn good find! Would you put up another PR for gem rspec-rails, '< 4.0.0' with a comment mentioning that 4.0.0 does not support ruby 2.2? We can quickly merge that and then rebase this PR.

@philipqnguyen no problems - https://github.com/procore/blueprinter/pull/210

@philipqnguyen I rebased this PR onto latest master, tests are green now)

Hi, @philipqnguyen! Can you merge this PR, please?

released in 0.23.3


Ignore the universe endpoint tests in pedant

chef/chef-server#645 implements the universe endpoint in chef-server. I can't really see any reason that you'd need or want a universe endpoint in zero, since it's mostly to allow berkshelf or Policyfiles to resolve the set of available cookbooks.
This branch ignores the universe endpoint tests, and currently points at the branch in chef-server that implements them. That'll need to get updated before merge.

:+1: Although now that you've said we probably won't need to implement the universe endpoint in chef-zero, someone will discover a reason.  You jinxed us!


Add engine permissions

Note: This issue has been migrated to https://relationalai.atlassian.net/browse/RAI-8050.
This link is only accessible to employees of RelationalAI.