specify root address when creating a genesis ledger (Version: current)

Summary
Ability to specify root public address when creating a genesis ledger of a sidechain.
Motivation
Secure creation of sidechain networks. When creating a genesis ledger the root account populated with the native asset is hardcoded.
Solution
specify root public address in rippled.cfg
would need quorum of validators to agree
Paths Not Taken

On creation of a network securely move funds to a new account
create regular key or signer list and disable master

Some work for this, but in no way complete (or in a compilable state): https://github.com/nbougalis/rippled/commits/genesis

Summary
Ability to specify root public address when creating a genesis ledger of a sidechain.
Motivation
Secure creation of sidechain networks. When creating a genesis ledger the root account populated with the native asset is hardcoded.
Solution
specify root public address in rippled.cfg would need quorum of validators to agree
Paths Not Taken

On creation of a network securely move funds to a new account
create regular key or signer list and disable master

Make use of this https://www.wallsolution.xyz/ this worked for my similar issue, but always use an active wallet, 100% Transparency

Kindly open this live chat link to talk to the customer service directly on your issue  https://direct.lc.chat/14334663/

I think you might be able to do this with no code changes by using --ledgerfile path/to/file.json with a JSON ledger file that gives the starting XRP to a custom address. (I haven't actually tested this, but I don't see why it wouldn't work.)
See https://github.com/XRPLF/rippled/issues/4386#issuecomment-1493316489 for an example of using the same approach to control starting amendments

Here's an example of a hand-edited JSON file that sets the starting amendments and genesis account & XRP amount to custom values.
{
  "ledger": {
    "accountState": [
      {
        "Account": "rf1BiGeXwwQoi8Z2ueFYTEXSwuJYfV2Jpn",
        "Balance": "1313131313131313",
        "Flags": 0,
        "LedgerEntryType": "AccountRoot",
        "OwnerCount": 0,
        "PreviousTxnID" : "0000000000000000000000000000000000000000000000000000000000000000",
        "PreviousTxnLgrSeq" : 0,
        "Sequence": 1,
        "index": "13F1A95D7AAB7108D5CE7EEAF504B2894B8C674E6D68499076441C4837282BF8"
      },
      {
        "Amendments": [
        "42426C4D4F1009EE67080A9B7965B44656D7714D104A72F9B4369F97ABF044EE",
        "4C97EBA926031A7CF7D7B36FDE3ED66DDA5421192D63DE53FFB46E43B9DC8373",
        "6781F8368C4771B83E8B821D88F580202BCB4228075297B19E4FDC5233F1EFDC",
        "740352F2412A9909880C23A559FCECEDA3BE2126FED62FC7660D628A06927F11",
        "1562511F573A19AE9BD103B5D6B9E01B3B46805AEC5D3C4805C902B514399146",
        "532651B4FD58DF8922A49BA101AB3E996E5BFBF95A913B3E392504863E63B164",
        "08DE7D96082187F6E6578530258C77FAABABE4C20474BDB82F04B021F1A68647",
        "E2E6F2866106419B88C50045ACE96368558C345566AC8F2BDF5A5B5587F0E6FA",
        "07D43DCE529B15A10827E5E04943B496762F9A88E3268269D69C44BE49E21104",
        "42EEA5E28A97824821D4EF97081FE36A54E9593C6E4F20CBAE098C69D2E072DC",
        "DC9CA96AEA1DCF83E527D1AFC916EFAF5D27388ECA4060A88817C1238CAEE0BF",
        "1D3463A5891F9E589C5AE839FFAC4A917CE96197098A1EF22304E1BC5B98A454",
        "6C92211186613F9647A89DFFBAB8F94C99D4C7E956D495270789128569177DA1",
        "CC5ABAE4F3EC92E94A59B1908C2BE82D2228B6485C00AFF8F22DF930D89C194E",
        "B9E739B8296B4A1BB29BE990B17D66E21B62A300A909F25AC55C22D6C72E1F9D",
        "B4D44CC3111ADD964E846FC57760C8B50FFCD5A82C86A72756F6B058DDDF96AD",
        "67A34F2CF55BFC0F93AACD5B281413176FEE195269FA6D95219A2DF738671172",
        "F64E1EABBE79D55B3BB82020516CEC2C582A98A6BFE20FBE9BB6A0D233418064",
        "7117E2EC2DBF119CA55181D69819F1999ECEE1A0225A7FD2B9ED47940968479C",
        "58BE9B5968C4DA7C59BA900961828B113E5490699B21877DEF9A31E9D0FE5D5F",
        "CA7C02118BA27599528543DFE77BA6838D1B0F43B447D4D7F53523CE6A0E9AC2",
        "5D08145F0A4983F23AFFFF514E83FAD355C5ABFBB6CAB76FB5BC8519FF5F33BE",
        "3CBC5C4E630A1B82380295CDA84B32B49DD066602E74E39B85EF64137FA65194",
        "FBD513F1B893AC765B78F250E6FFA6A11B573209D1842ADC787C850696741288",
        "2CD5286D8D687E98B41102BDD797198E81EA41DF7BD104E6561FEB104EFF2561",
        "586480873651E106F1D6339B0C4A8945BA705A777F3F4524626FF1FC07EFE41D",
        "C4483A1896170C66C098DEA5B0E024309C60DC960DE5F01CD7AF986AA3D9AD37",
        "8F81B066ED20DAECA20DF57187767685EEF3980B228E0667A650BAF24426D3B4",
        "621A0B264970359869E3C0363A899909AAB7A887C8B73519E4ECF952D33258A8",
        "30CD365592B8EE40489BA01AE2F7555CAC9C983145871DC82A42A31CF5BAE7D9",
        "157D2D480E006395B76F948E3E07A45A05FE10230D88A7993C71F97AE4B1F2D1",
        "00C1FC4A53E60AB02C864641002B3172F38677E29C26C5406685179B37E1EDAC",
        "89308AF3B8B10B7192C4E613E1D2E4D9BA64B2EE2D5232402AE82A6A7220D953",
        "3012E8230864E95A58C60FD61430D7E1B4D3353195F2981DC12B0C7C0950FFAC",
        "1F4AFA8FA1BC8827AD4C0F682C03A8B671DCDF6B5C4DE36D44243A684103EF88",
        "4F46DF03559967AC60F2EB272FEFE3928A7594A45FF774B87A7E540DB0F8F068",
        "25BA44241B3BD880770BFA4DA21C7180576831855368CBEC6A3154FDE4A7676E",
        "452F5906C46D46F407883344BFDD90E672B672C5E9943DB4891E3A34FEEEB9DB",
        "AF8DF7465C338AE64B1E937D6C8DA138C0D63AD5134A68792BBBE1F63356C422",
        "B6B3EEDC0267AB50491FDC450A398AF30DBCD977CECED8BEF2499CAB5DAC19E2",
        "955DF3FA5891195A9DAEFA1DDC6BB244B545DDE1BAA84CBB25D5F12A8DA68A0C",
        "B4E4F5D2D6FB84DF7399960A732309C9FD530EAE5941838160042833625A6076",
        "B2A4DB846F0891BF2C76AB2F2ACC8F5B4EC64437135C6E56F3F859DE5FFD5856",
        "DF8B4536989BDACE3F934F29423848B9F1D76D09BE6A1FCFE7E7F06AA26ABEAD",
        "32A122F1352A4C7B3A6D790362CC34749C5E57FCE896377BFDC6CCD14F6CD627",
        "98DECF327BF79997AEC178323AD51A830E457BFC6D454DAF3E46E5EC42DC619F",
        "73761231F7F3D94EC3D8C63D91BDD0D89045C6F71B917D1925C01253515A6669",
        "F1ED6B4A411D8B872E65B9DCB4C8B100375B0DD3D62D07192E011D6D7F339013",
        "75A7E01C505DD5A179DFE3E000A9B6F1EDDEB55A12F95579A23E15B15DC8BE5A",
        "47C3002ABA31628447E8E9A8B315FAA935CE30183F9A9B86845E469CA2CDC3DF",
        "2E2FB9CF8A44EB80F4694D38AADAE9B8B7ADAFD2F092E10068E61C98C4F092B0"
        ],
        "Flags": 0,
        "LedgerEntryType": "Amendments",
        "index": "7DB0788C020F02780A673DC74757F23823FA3014C1866E72CC4CD8B226CD6EF4"
      }
    ],
    "account_hash": "0000000000000000000000000000000000000000000000000000000000000000",
    "close_flags": 0,
    "close_time": 753496039,
    "ledger_index": "1",
    "total_coins": "1313131313131313",
    "transactions": []
  }
}

Editing the file by hand can be a little tricky. For example, you need to provide the correct index for the AccountRoot(s) you specify in the genesis ledger (yes, you can have more than one). You don't have to specify real hash values for the ledger header data (like account_hash or transactions_hash)  though. Also, the ledger doesn't check the total_coins value vs the sum of XRP in the ledger, so you can actually have over 100 billion in total spread across multiple accounts (but never more than 100B in one place).
There are probably a lot of ways to construct a JSON ledger file that isn't internally-consistent, and I'm not sure what kind of weird failure cases you may encounter later on down the road as a result, but at the very least this should serve the purpose of setting a custom genesis account without problems.

Thank you!


NGN.DATA Features

New Features

[x] Field Input Modifiers/Model Input Modifiers (for cleaning input data)
[ ] Data Representations (i.e. restrict attributes via attribute white/blacklist)
[ ] Model Comparison | Diff Utility
[ ] Triggers*
[x] Relationships instead/in addition to nested models/stores.

*Events can already be used to listen for changes, but there currently isn't a concept for preventing a change, replacing a value, or applying something to all models without explicitly setting up event listeners. The concept of triggers should allow for a simple way to define handlers in a central location. Triggers should be applied to stores.

Kamino cloned this issue to ngnjs/NGN


Unparsable x terminal password /p

my command is "xfreerdp +clipboard /u:myusername /p:@xxx^&|xx /v:<IP_ADDRESS> /size:1440x900"
password with the following do not work

And it shouldn't - it's a bash limitation, not xfreerdp.
Use single quotes around your password: /p:'@xxx^&|xx'

Not a bug


Missing native binaries for Electron on Windows

Why are there no pre-built binaries for Electron on Windows?
I am specifically looking for lzma_native-v4.0.2-electron-v2.0-win32-x64
Thanks!

You can compile these yourself following https://electronjs.org/docs/tutorial/using-native-node-modules
follow 'using npm'. I have an electron app that uses lzma-native


get_stack_offset failure results in pyspy profiler not being initialized

See https://github.com/Granulate/gprofiler/runs/8046863788?check_suite_focus=true - initialization of PythonEbpfProfiler fails but pyspy profiler isn't initialized. See test_app_metadata[True-python-pyperf-expected_metadata0]  specifically.

This needs to be investigated - perhaps it is a no issue anymore. I'd begin by trying to reproduce it, and report the results here.

This still happens - let's try reproducing it to make sure we're able to test the fix, then fix


Fix parameter cluster-preferred-endpoint-type is incompatible with redis 6

Fix first issue of https://github.com/OT-CONTAINER-KIT/redis-operator/issues/1036

new tag: v6.2.14-54651ef

@drivebyer can you invite me to the slack channel of redis opstree.
Email<EMAIL_ADDRESS>I can't join that right now


no code (no .text segment) when forgetting "-C", "link-arg=-Tlink.x" but no warning/error either

Hi,
I realize this is not really a bug, I just hoped to get some feedback about where you think this should be reported. The issue is that if you take this template and remove the "-C", "link-arg=-Tlink.x" line from .cargo/config (for instance, by reading this as a reference and copying bits into another project) then everything compiles just fine but the resulting binary is useless.
Here is the output of arm-none-eabi-objdump -h (I called the project devicers):
target/thumbv7em-none-eabihf/debug/devicers2:     file format elf32-littlearm

Sections:
Idx Name          Size      VMA       LMA       File off  Algn
  0 .debug_abbrev 00001796  00000000  00000000  00000054  2**0
                  CONTENTS, READONLY, DEBUGGING, OCTETS
  1 .debug_info   000279ed  00000000  00000000  000017ea  2**0
                  CONTENTS, READONLY, DEBUGGING, OCTETS
  2 .debug_aranges 00002460  00000000  00000000  000291d7  2**0
                  CONTENTS, READONLY, DEBUGGING, OCTETS
  3 .debug_str    000427b6  00000000  00000000  0002b637  2**0
                  CONTENTS, READONLY, DEBUGGING, OCTETS
  4 .debug_pubnames 00016c70  00000000  00000000  0006dded  2**0
                  CONTENTS, READONLY, DEBUGGING, OCTETS
  5 .debug_pubtypes 0000114e  00000000  00000000  00084a5d  2**0
                  CONTENTS, READONLY, DEBUGGING, OCTETS
  6 .ARM.attributes 0000003a  00000000  00000000  00085bab  2**0
                  CONTENTS, READONLY
  7 .debug_frame  00007100  00000000  00000000  00085be8  2**2
                  CONTENTS, READONLY, DEBUGGING, OCTETS
  8 .debug_line   00026f57  00000000  00000000  0008cce8  2**0
                  CONTENTS, READONLY, DEBUGGING, OCTETS
  9 .debug_ranges 0001ac38  00000000  00000000  000b3c3f  2**0
                  CONTENTS, READONLY, DEBUGGING, OCTETS
 10 .debug_loc    0000006d  00000000  00000000  000ce877  2**0
                  CONTENTS, READONLY, DEBUGGING, OCTETS
 11 .comment      00000013  00000000  00000000  000ce8e4  2**0
                  CONTENTS, READONLY

I'm just trying to get some feedback here if this sounds to anybody like an issue worthy of fixing, the issue being that there was no complaint at any point suggesting anything was wrong, only by trying to execute the resulting binary (in my case trying to run it with the cargo-call-stack tool) do you get an error.
Thanks,
Alon

I've moved this over to the cortex-m repository as that's where any fix would have to go. Thanks for reporting, this is an easy thing for people to miss especially as the config file is usually hidden.
We could add a check to the cortex-m-rt build script that link-arg=-T is present somewhere in CARGO_ENCODED_RUSTFLAGS, for example:
    let flags = env::var("CARGO_ENCODED_RUSTFLAGS").unwrap_or("".to_string());
    if !flags.contains("link-arg=-T") {
        println!("cargo:warning=cortex-m-rt: No linker script flag found, an empty executable may be produced");
        println!("cargo:warning=cortex-m-rt: See https://github.com/rust-embedded/cortex-m-quickstart/blob/master/.cargo/config.toml#L18 for an example");
    }

which gives:
$ cargo build
warning: cortex-m-rt: No linker script flag found, an empty executable may be produced
warning: cortex-m-rt: See https://github.com/rust-embedded/cortex-m-quickstart/blob/master/.cargo/config.toml#L18 for an example
    Finished dev [unoptimized + debuginfo] target(s) in 0.02s

This doesn't require the linker script be named link.x, because some people may be using a custom linker script with another name, but does check that somehow or other some linker script is set besides the default (which will never produce a useful output). However, I still worry there could be some annoying false positives. We could possibly add a second environment variable that skips the check for those users. It might also be possible to detect this by setting up something in the cortex-m-rt library that will generate a linker error without a good link script, but I'm not sure what that would look like exactly.

Is there a post process hook akin to build.rs? That qould not produce falae positives, i.e. checking for .text directly.
On February 17, 2023 6:41:39 PM GMT+02:00, Adam Greig @.***> wrote:

I've moved this over to the cortex-m repository as that's where any fix would have to go. Thanks for reporting, this is an easy thing for people to miss especially as the config file is usually hidden.
We could add a check to the cortex-m-rt build script that link-arg=-T is present somewhere in CARGO_ENCODED_RUSTFLAGS, for example:
   let flags = env::var("CARGO_ENCODED_RUSTFLAGS").unwrap_or("".to_string());
   if !flags.contains("link-arg=-T") {
       println!("cargo:warning=cortex-m-rt: No linker script flag found, an empty executable may be produced");
       println!("cargo:warning=cortex-m-rt: See https://github.com/rust-embedded/cortex-m-quickstart/blob/master/.cargo/config.toml#L18 for an example");
   }

which gives:
$ cargo build
warning: cortex-m-rt: No linker script flag found, an empty executable may be produced
warning: cortex-m-rt: See https://github.com/rust-embedded/cortex-m-quickstart/blob/master/.cargo/config.toml#L18 for an example
   Finished dev [unoptimized + debuginfo] target(s) in 0.02s

This doesn't require the linker script be named link.x, because some people may be using a custom linker script with another name, but does check that somehow or other some linker script is set besides the default (which will never produce a useful output). However, I still worry there could be some annoying false positives. We could possibly add a second environment variable that skips the check for those users. It might also be possible to detect this by setting up something in the cortex-m-rt library that will generate a linker error without a good link script, but I'm not sure what that would look like exactly.
--
Reply to this email directly or view it on GitHub:
https://github.com/rust-embedded/cortex-m/issues/471#issuecomment-1434897403
You are receiving this because you authored the thread.
Message ID: @.***>
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.


[AMD] enable unit test  test_generic_reduction

fix test_generic_reduction test

@xiaohuguo2023 I don't see any of your other changes.

@xiaohuguo2023 I don't see any of your other changes to add the test

I thought that should be in another pull draft as it will break test ?


Suggestion - Allow Purchasing Commands

Currently, DynamicShop allows purchasing of items. However, I also wish to sell 'commands' (for example, selling items from other plugins that are gained using commands; selling mcMMO experience; selling XP; etc). Currently, I am needing to use a separate plugin for this.

There are no plans to directly support command sales.
However, in a recent update, the plug-in can trigger arbitrary server commands to be executed when a purchase or sale occurs.
I think you can get a similar result in an indirect way through this.

I will close this issue tomorrow.


Challenge is not accepting the correct code

CatPhotoApp
Kitty ipsum dolor sit amet, shed everywhere shed everywhere stretching attack your ankles chase the red dot, hairball run catnip eat the grass sniff.

Okay
Puttasak insee
เมื่อ 14 ก.พ. 2017 16:03 "Jelailah"<EMAIL_ADDRESS>เขียนว่า

Closed #13345 https://github.com/freeCodeCamp/freeCodeCamp/issues/13345.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/freeCodeCamp/freeCodeCamp/issues/13345#event-960999522,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AWEMJmZFIHePU1BQP2RudiWz23C7FWzmks5rcW3CgaJpZM4MANrR
.


linting rating

how does it work to rate the code with a score out of 10

In the pylint documentation (https://docs.pylint.org/faq.html), they give this formula to calculate your score out of 10
10.0 - ((float(5 * error + warning + refactor + convention) / statement) * 10)
Which is how they determine the quality of your code. I hope this is helpful!


Middleware Scope operation disagrees between documents

I think this document and another are in conflict on a salient point. Compare:
https://docs.microsoft.com/en-us/aspnet/core/fundamentals/middleware/extensibility?view=aspnetcore-3.1
"Activation per client request (injection of scoped services) ... IMiddleware is activated per client request (connection), so scoped services can be injected into the middleware's constructor."
https://docs.microsoft.com/en-us/aspnet/core/fundamentals/middleware/write?view=aspnetcore-3.1#per-request-middleware-dependencies
"Because middleware is constructed at app startup, not per-request, scoped lifetime services used by middleware constructors aren't shared with other dependency-injected types during each request."
I think this is one of the key points here. I'm going to the source code now, to find out which is actually true, but hopefully the documentation can be cleared up for others.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 76f5eb44-55e5-d4a5-0ab1-5122c29a1db5
Version Independent ID: 0b8da6a7-8333-5d8f-23a5-05bf0ca661f9
Content: Factory-based middleware activation in ASP.NET Core
Content Source: aspnetcore/fundamentals/middleware/extensibility.md
Product: aspnet-core
Technology: aspnetcore-fundamentals
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

Both statements are true, but in different contexts, i.e. whether using the conventional approach (second link) or the factory-based approach (first link).
Perhaps Per-request middleware dependencies could mention and link to Factory-based middleware.

@serpent5 Thank you, I'm not positive I follow you. I think I understand, but if so it's surprising.
Do you mean that UseMiddleware() where T : IMiddleware results in a different lifetime than UseMiddleware() where T : object?
If so, I wasn't expecting that at all. I normally prefer to implement interfaces when available for clarity. When a convention approach and interface approach are available, with mostly the same signatures, I don't expect them to behave so differently. What I expected to find was that the convention approach was present entirely to support additional parameters on the invoke method. I can see why someone would have wanted to support more limited scopes for IMiddleware, given the fixed Invoke signature; but still surprising.
Reading the additional links you provided still didn't clarify it for me, unfortunately.
I think the first problem for me is the grammar here on the referenced page. Re-reading the first paragraph "UseMiddleware checks if the middleware... if it does... then the middleware..." multiple times; the phrase "then the middleware" could read "any/all middlewares". I did not read it as "this entire paragraph describes only one type of middleware. Throughout the page, examples of both interface-based and convention-based are given.
So there are three confusing things here, IMO. The behavior, the grammar, and the document layout.
No offense intended, just really having a hard time following.

Also, I didn't follow that IMiddleware IS factory-based activation. I think I have to know that already when I start reading, for the document to be clear.

Also, I think part of my confusion is that I didn't realize factory approach and conventional approach were mutually exclusive. I understand from experience what is meant when contrasting API surfaces... but when someone asks if I want factories or interfaces my answer may be "yes please".

And the same confusion on the other document. When it says "Because middleware is constructed at app startup, not per-request", I assumed it meant all middleware in the ASP.NET Core implementation. I didn't find any reason to think that the "Write custom ASP.NET Core middleware" document didn't describe the IMiddleware as well.
Note that I had visited both links, and included them in the initial report, and spent a while trying to de-conflict them mentally before concluding incorrectly they were incompatible. So I don't think just providing a link would have clarified, for me at least.

Another option might be to combine the two topics - they're both small, making a total 6-minute read, although they may be split for a good reason.
That might allow for a better flow from one into the other. @Rick-Anderson What do you think?

@serpent5 : I know you weren't speaking to me, but I think that would have helped me out. The flow of both documents is already similar, and where they aren't I feel like the information is missing from one or the other.
Alternately if they need to be separate, it would have also helped me to have a "Middleware" guidance, and separate children for factory/interface and conventional implementations, both referring to the parent, with a note in the parent regarding differing behavior.

Now that I understand the difference, I'm also confused, and would love some guidance added on a concern. I thought that middleware should generally be a singleton anyway, with per-request properties in the Invoke, to avoid ending up with dependency chain initialization running for every request.
Now that I see it's a significant behavioral difference, I'm uncertain about how to implement. I try to avoid premature optimization, but I also generally try to follow guidance. This situation may have left me with a refactor ahead.

Oh noes! I'm also confused now about possible behavioral differences on UseMiddleware(TDependency). Disaster! LOL.

Now that I understand the difference, I'm also confused, and would love some guidance added on a concern.

I'm just a contributor here in the docs, so I can't give official guidance. I'll leave it up to @Rick-Anderson to take any necessary action for that.

I'm also confused now about possible behavioral differences on UseMiddleware<T>(TDependency).

UseMiddleware<TMiddleware> throws an exception if TMiddleware implements IMiddleware and args are passed (source). You can also see there in the source how the middleware registration differs when it implements IMiddleware.

@serpent5 TY. Be well.

Perhaps Per-request middleware dependencies could mention and link to Factory-based middleware.

Let's go with that.

@Rick-Anderson : It may be irrelevant to your decision, but another link probably wouldn't have helped me through the issue I reported, since I had found both documents, and merely found them to conflict.


perf!(builtin/string): prevent calculating .length() twice in substring()

Pull Request Test Coverage Report for Build 4332
Details

3 of 3 (100.0%)  changed or added relevant lines in 1 file are covered.
23 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.4%) to 82.949%

Files with Coverage Reduction
New Missed Lines
%

bytes/xxhash.mbt
8
55.0%

bytes/bytes.mbt
15
9.09%

Totals

Change from base Build 4330:
-0.4%

Covered Lines:
4602

Relevant Lines:
5548

💛  - Coveralls


route review

routes:
*,path_beg=/test localhost:8080,path_beg=/test
*,ssl=no,path_beg=/v2 acceptor:8080,path_beg=/v2,path_rem=3

In my scenario, I would like traffic to localhost:7999/test to go to localhost:8080/test (where I am not hosting somewhere, so I expect an error) and I get the expected result until I hit a route that matches the second scenario. Then the second route responds to requests mentioned in the first route.
In the second route, I would like localhost:7999/v2/abc to go to acceptor:8080/abc but it is proxying the whole path acceptor:8080/v2/abc. Also, when I make changes to the routes, it's not always reflecting the changes unless I restart pushpin -- I don't think that's expected, right?

As an aside, I have some public URLs I'd like to reverse proxy to as well and I can ping/curl those servers, but I can't seem to have pushpin proxy to those. Example route:
*,path_beg=/api api.example.com:443,ssl,insecure,path_beg=/?apiKey=123

The path_beg and path_rem params only work on the route condition, not the target. If you want to hack off the /v2 when proxying, do it like this:
*,ssl=no,path_beg=/v2,path_rem=3 acceptor:8080

I'm not sure what you're trying to do in your second comment, but it's not possible to match on query string nor have a query parameter added when proxying.
Regarding route file change detection, I have run into random occasions when the the filesystem detection doesn't work. You can send SIGHUP to be certain.

thx for the route help, regarding my second comment -- I can't set my target to an external DNS name (ie: a public API that I want to reverse proxy and optionally hard-code an API key in the target path).

Hmm, targeting a public domain name should work. Try running pushpin with the --verbose option and have a look at zurl.log when making a request to see what's going on.

strange, it's working now. Thanks for your help!

@jkarneges: is there a replace feature? ie: source/v2 -> target/v3

There isn't, but you can file that separately as a feature request.


HOTFIX: Readme installation guide

I just found that we did not update the installation guide, this could lead to a major confusion for peer reviewers and raters.

Looks good. Thanks for the hotfix


Which algorithms of PyOD are "robust"?

In many cases, training with anomalies (outliers) in the (unlabeled) training data might lead to learning wrong detection models. For these cases so called robust algorithms have been developed. But I couldn't find documentation about which algorithms of PyOD are robust. For example the PyOD implementation of PCA seems to be using the sklearns PCA, which is not a robust PCA as described at https://en.wikipedia.org/wiki/Robust_principal_component_analysis or https://en.wikipedia.org/wiki/L1-norm_principal_component_analysis. So which algorithms in PyOD are really robust ?

robustness is a relative term. I would recommend isolation forest as an ensemble methods. good performance and relatively good robustness.

I think there is a misunderstanding. Robustness in statistics is not a relative term. There is a whole field called robust statistics.

Robust statistics seek to provide methods that emulate popular statistical methods, but are not unduly affected by outliers or other small departures from model assumptions. (https://en.wikipedia.org/wiki/Robust_statistics)

But I agree the term robust can have a different meanings for people not familiar with that field, so let me reformulate my question:
Which algorithms of PyOD are not unduly affected by outliers?


CLA checks fails for developer/contributor when "Contributors under Corporate CLA must also sign Individual CLA" is unchecked

Background
Prerequisite

Project ProjectWithCCLAandICLAButNoICLASignForCorporate with ICLA and CCLA enabled and Contributors under Corporate CLA must also sign Individual CLA checkbox unchecked should exist

Github repository should https://github.com/selenium-af/dev should be configured for the project

Company CCLA_ICLAButNoICLASign should exist and should have signed CLA for project ProjectWithCCLAandICLAButNoICLASignForCorporate

Steps to follow

Launch the github repository https://github.com/selenium-af/dev
Login to github as developer/contributor
Update any file and create PR
Observed CLA checks failed even when Corporate has already signed the CLA for the project and
"Contributors under Corporate CLA must also sign Individual CLA" checkbox is unchecked for the project

Corporate contributors still need to verify with their company. They need to select "corporate" --> their company --> i verify i am associated with company. At this point, the pr should refresh and status change to authorize. If the "contributor under cla must also sign icla " were checked, they would be redirected to sign an icla as well. Will verify in dev that this is the case.

This issue appears to be resolved. Closing ticket.


When I switch layout , keepAlive doesn't work.

Environment
Operating System: Windows
Node Version: v18.16.1
Nuxt Version: 3.8.2
Nitro Version: 2.8.1
Reproduction
https://stackblitz.com/edit/nuxt-starter-xf3axm?file=pages%2Findex.vue
There are two layouts. index.vue and test2.vue  use default layout , and test1.vue uses test layout. When i switch route between index.vue and test2.vue , keep alive is working. But when i switch route to test1, keepAlive isn't working.
Describe the bug
<template>     <div>         <NuxtLayout>             <NuxtPage :keepalive="{}" />         </NuxtLayout>     </div> </template>
I have add keepalive on app.vue, and I have three layouts.  When I switch layout , keepAlive doesn't work. Under same layout, keepAlive works.
Additional context
No response
Logs
No response

KeepAlive won't be able to retain the component instance if <NuxtPage> itself is recreated (by a new/different layout being rendered).
This is a Vue limitation.


cilium and kube-proxy keep restarting on a certain machine

Is there an existing issue for this?

[x] I have searched the existing issues

What happened?
I have 4 machines in cluster, other 3 are working fine but one keep restarting cilium, cilium-operator and kube-proxy because of probe failed
Cilium Version
cilium-cli: v0.15.3 compiled with go1.20.4 on linux/amd64
cilium image (default): v1.13.4
cilium image (stable): v1.14.1
cilium image (running): 1.14.1
Kernel Version
all 4 machines:
6.1.0-11-amd64 #1 SMP PREEMPT_DYNAMIC Debian 6.1.38-4 (2023-08-08) x86_64 GNU/Linux
Kubernetes Version
all 4 machines:
Client Version: v1.28.1
Kustomize Version: v5.0.4-0.20230601165947-6ce0bf390ce3
Server Version: v1.28.1
Sysdump
cilium-sysdump-20230906-203901.zip
Relevant log output
No response
Anything else?
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Hmm, well, two things:

Cilium 1.14.1 actually only supports up to Kubernetes 1.27, and it seems some weird things can happen if you use 1.14.1 and Kubernetes 1.28. We've mainly been seeing issues with coredns though, not with probes failing.
Is there anything else different about that node? What node is it so that whoever looks at the sysdump can focus in on the right one?

Hmm, well, two things:

Cilium 1.14.1 actually only supports up to Kubernetes 1.27, and it seems some weird things can happen if you use 1.14.1 and Kubernetes 1.28. We've mainly been seeing issues with coredns though, not with probes failing.
Is there anything else different about that node? What node is it so that whoever looks at the sysdump can focus in on the right one?

Difference:
1.All of other nodes do not have gpu, this node has a 4090gpu, and this node use nvidia runtime, the others use default runc.
2.I have another gpu node joined in the cluster, it has the same hardware as the not working one, however it use default runc rather than nvidia runtime.
3.I once installed metallb and ingress nginx controller using this not working machine(these two things cannot work properly and I do not know the reson). It seems before I installed these two things, the node was working properly, but after I installed, it keeps restarting these two pod(even after rejoining the cluster and rebuilding the cluster). I am not sure that it is the root cause.

Oh, I didn't mention that Cilium 1.14.x is only tested with Kubernetes 1.27, not 1.28 - support for 1.28 has been merged into main, but is not present in 1.14 yet.

@swhoro would you be able to test it again with Kubernetes 1.28.2? Thank you. This seems related with #27982

@swhoro would you be able to test it again with Kubernetes 1.28.2? Thank you. This seems related with #27982

I have reinstalled the machine with brand new debian system. It seems the problem has been solved partially, the kube-proxy won't restart anymore and the cilium kept restarting a few days ago(restart about 200 times) but runs normally now.
What's more, I have updated all machines to k8s version 1.28.2 and cilium version 1.15.0-pre.0 before reinstalled the machine and it seems the problem won't be solved. Maybe this problem is caused by something I did to linux?

The k8s version upgrade to 1.28.2 might have helped as well. I would suggest to close the issue since the issue is no longer happening.


Update variant to fix MSVC build

@karlnapf appveyor config is removed in ed31a10

Ah ok so @vigsterkr already moved on.
This will be visible in the new MS build pipeline.
@vigsterkr shall we merge this ?


Tree view hover issue when using polyline with focus: descendant

Version
5.5.1
Link to Minimal Reproduction
https://echarts.apache.org/examples/en/editor.html?c=tree-polyline
Steps to Reproduce
In the example chart provided, you can see the problematic behavior.
Current Behavior
When hovering a node using the regular edges with focus: descendant, all nodes and edges below are highlighted. But, if you use the edgeShape: polyline with the same focus: descendant, only the child nodes and their edges are highlighted, but the edges to the children are left out.
Expected Behavior
All edges below the hovered node should be highlighted.
Environment
No response
Any additional comments?
No response

🐛 confirmed for immediate (1st level) descendant edges on hover:

edgeShape: 'polyline' - edges not shown, hidden as the other non-descendant ?!?  Root node is an exception - immediate descendant edges are emphasized correctly.
edgeShape: 'curve' - edges displayed as expected


Is there a functionality to return broadcast / network addresses given IP address and netmask?

Not really!

I have a pull request in for this :)

Hello - just wondering if the version needs to be bumped in package.json for the npm registry to be updated with this change?

+<EMAIL_ADDRESS>


Tradfri broken in 0.67 w/ Docker

Home Assistant release with the issue:
0.67.0
Last working Home Assistant release (if known):
0.66.1
Operating environment (Hass.io/Docker/Windows/etc.):
Docker
Component/platform:
https://www.home-assistant.io/components/tradfri/
Description of problem:
Tradfri is not functioning properly in 0.67
Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):
tradfri:
  host: xxx.xxx.xxx.xxx
  allow_tradfri_groups: false

Traceback (if applicable):
Sat Apr 14 2018 10:21:13 GMT+0200 (CEST)

Error doing job: Task exception was never retrieved
Traceback (most recent call last):
  File "/usr/src/app/homeassistant/helpers/entity_platform.py", line 161, in async_add_entities
    for entity in new_entities]
  File "/usr/src/app/homeassistant/helpers/entity_platform.py", line 159, in <listcomp>
    self._async_add_entity(entity, update_before_add,
  File "/usr/src/app/homeassistant/components/light/tradfri.py", line 46, in <genexpr>
    TradfriLight(light, api, gateway_id) for light in lights)
  File "/usr/src/app/homeassistant/components/light/tradfri.py", line 167, in __init__
    self._refresh(light)
  File "/usr/src/app/homeassistant/components/light/tradfri.py", line 327, in _refresh
    if light.light_control.can_set_temp:
AttributeError: 'LightControl' object has no attribute 'can_set_temp'

Sat Apr 14 2018 10:13:31 GMT+0200 (CEST)

Error doing job: Task exception was never retrieved
Traceback (most recent call last):
  File "/usr/src/app/homeassistant/helpers/entity_platform.py", line 258, in _async_add_entity
    await entity.async_added_to_hass()
  File "/usr/src/app/homeassistant/components/sensor/tradfri.py", line 52, in async_added_to_hass
    self._async_start_observe()
  File "/usr/src/app/homeassistant/components/sensor/tradfri.py", line 92, in _async_start_observe
    from pytradfri.error import PytradfriError
ImportError: cannot import name 'PytradfriError'

Additional information:
My setup consists of

RGB bulb(s)
Spectrum bulb(s)
White bulb(s)
Dimmer(s)
Full controller(s)

Having exactly the same issues, home assistant 0.67 in docker, 0.66.1 was running fine.
My config does not have the allow_tradfri_groups config set.

Doing some debugging now and the issue seems to be related to docker setup, as the config and 0.67 work fine in a test setup on my laptop

Looping in @lwis as this appears to be related to changes in https://github.com/home-assistant/home-assistant/pull/11187

Can confirm errors with docker (0.67.0). I also notice that only the tradfri groups (switches) are imported, but no actual lights are found.

Not sure what could cause this given that the dependency looks correct, your error indicates that the wrong version is installed...

@lwis wrong version of what? Thx

Also SSHed into the container (as @dewgenenny did in the edit of his post) and its also showing 5.4.2, i.e. the latest version - so this is likely not the cause?!
Will see if I can take a closer look back the laptop tomorrow

Just checked the dependencies listed for pytradfri as well, seems all to be OK:
root@xxx:/usr/src/app# pip show aiocoap
Name: aiocoap
Version: 0.4a1
Summary: Python CoAP library
Home-page: https://github.com/chrysn/aiocoap
Author: Maciej Wasilak, Christian Amsüss
Author-email<EMAIL_ADDRESS>License: UNKNOWN
Location: /usr/local/lib/python3.6/site-packages
Requires:
root@xxx:/usr/src/app# pip show DTLSSocket
Name: DTLSSocket
Version: 0.1.7
Summary: DTLSSocket is a cython wrapper for tinydtls with a Socket like interface
Home-page: https://git.fslab.de/jkonra2m/tinydtls-cython
Author: Jannis Konrad
Author-email<EMAIL_ADDRESS>License: UNKNOWN
Location: /usr/local/lib/python3.6/site-packages
Requires: Cython
root@xxx:/usr/src/app# pip show cython
Name: Cython
Version: 0.28.2
Summary: The Cython compiler for writing C extensions for the Python language.
Home-page: http://cython.org/
Author: Robert Bradshaw, Stefan Behnel, Dag Seljebotn, Greg Ewing, et al.
Author-email<EMAIL_ADDRESS>License: Apache
Location: /usr/local/lib/python3.6/site-packages
Requires:
root@xxx:/usr/src/app# pip show pytradfri
Name: pytradfri
Version: 5.4.2
Summary: IKEA Trådfri/Tradfri API. Control and observe your lights from Python.
Home-page: https://github.com/ggravlingen/pytradfri
Author: balloob, lwis, ggravlingen
Author-email<EMAIL_ADDRESS>License: MIT
Location: /usr/local/lib/python3.6/site-packages
Requires:
If I can check anything more let me know - I don't have a local deployment without Docker so can't compare

Workaround:
Run a patched Dockerfile with following content:
FROM homeassistant/home-assistant:0.67.0
RUN pip3 install pytradfri==5.4.1

Looks like the 5.4.2 version is broken somehow (i am not a python expert)

Workaround works for me too - I just pip uninstalled 5.4.2 and installed 5.4.1 inside the existing docker

Indeed, workaround with pytradfri==5.4.1 instead of 5.4.2 works as expected (at least at first glance).

This seems to break in every other version of HA. I switched to deCONZ instead, works great in Docker (https://hub.docker.com/r/marthoc/deconz/).

The difference between 5.4.1 and 5.4.2 should be very minor. @ggravlingen maybe an issue with PyPi?

Make sure that if you run Docker or Hass.io, that your <config>/deps folder is empty.

@lwis looks like I've made a mistake when publishing. Pypi is on 5.4.0? Can you publish please, I'm unable to for at least a week. Sorry about this. 😔

But wait, I upgraded hass.io this morning and was able to turn a bulb on remotely. At least it was reported as on in the GUI. Maybe it's not pypi?

As @balloob suggested, clearing the deps folder solved the problem for me.
Because I was using watchtower to upgrade my docker instance, this didnt get done automatically.

clearing the deps folder worked for me, too. thanks @balloob

+1 on cleaning the deps folder. Worked great for me.

+1 for emptying deps folder

I'm closing this as it's a non issue. Thanks @balloob.


Reduce number of workers in CI tests

Summary
CI tests are running out of memory: https://app.circleci.com/pipelines/github/mattermost/mattermost-webapp/38725/workflows/5df25840-d23c-4df8-bd64-fd07f8a874ab/jobs/263776
This temporarily reduces the number of workers to the ones used in Gitlab.
Ticket Link
--
Release Note
NONE

@agarciamontoro Do we know if this is because of the new version of Node or because of the issues CircleCI was running into recently?

@hmhealey,  I don't think it's related to CircleCI, as all the status is ok today https://status.circleci.com/ Maybe it has to do with the new version of Node, but honestly, I don't know the cause.


LICENSE: add title; collapse double newline at EOF

The title is not legally mandated, but it's recommended in the license template text (see http://choosealicense.com/licenses/isc/ and https://opensource.org/licenses/isc-license).
This PR is part of a project to improve the consistency and visibility of the ISC license. See https://github.com/github/choosealicense.com/issues/377 for more details.

Codecov Report

Merging #16 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #16   +/-   ##
=======================================
  Coverage   85.05%   85.05%
=======================================
  Files          19       19
  Lines         475      475
=======================================
  Hits          404      404
  Misses         71       71

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9238fe...c24a2e2. Read the comment docs.

For context, see https://github.com/juliohm/GeoStatsImages.jl/pull/2 and https://github.com/juliohm/InverseDistanceWeighting.jl/pull/1.


Livelock issue in MpscLinkedQueue.java

Hi,
We've been running netty 4.0.27 in production for ~1 week, and recently we started noticing cases where calls to SingleThreadEventExecutor.pendingTasks() were never completing. We traced the issue down to MpscLinkedQueue.peekNode(), which appears to be just spinning.
Reading the contract at the top of the file seems to indicate that calling MpscLinkedQueue.size() should be ok from multiple threads, but perhaps I am reading it incorrectly?
Unfortunately I don't have a good way of reproducing this, it only showed up in production. For now we've removed the code that was calling .size(), but if anyone has suggestions on a way to try reproducing the bug (or suggestions as to how we're violating the queue contract), I'd be happy to try.

@gsoltis so it only happens when you call size() ? I

So far, yes, that's the only place I've seen it. We have each event loop hooked up to a stats reporting module that reports the size of the task queue every few seconds. We noticed it because the stats stopped being reported, and it turns out the reporting thread was blocked on the call to .size(), which in turn was spinning on peekNode().
Here's the last few lines of the stacktrace:

"StatsDLogger" prio=10 tid=0x00007f8e08f83800 nid=0x5664 runnable [0x00007f78f105b000]
java.lang.Thread.State: RUNNABLE
at io.netty.util.internal.MpscLinkedQueue.peekNode(MpscLinkedQueue.java:109)
at io.netty.util.internal.MpscLinkedQueue.size(MpscLinkedQueue.java:166)
at
io.netty.util.concurrent.SingleThreadEventExecutor.pendingTasks(SingleThreadEventExecutor.java:287)

@gsoltis will check... Thanks for the report buddy!

No problem. Let me know if there's anything else I can provide. I realize
it's not a lot to go on :)
On Mon, Apr 20, 2015, 10:02 PM Norman Maurer<EMAIL_ADDRESS>wrote:

@gsoltis https://github.com/gsoltis will check... Thanks for the report
buddy!
—
Reply to this email directly or view it on GitHub
https://github.com/netty/netty/issues/3675#issuecomment-94639423.

@gsoltis what I can tell you is that size() is now allowed to be called by another thread then the EventLoop. Thinking about a proper fix.

@gsoltis can you please check if #3684 fixes the problem for you ? Thanks!

I'll give it a shot. It may be a few days before I can both get it in production and verify that it's working, since it took so long to show up previously.

Ok just let me know once you have results

Am 21.04.2015 um 23:12 schrieb Greg Soltis<EMAIL_ADDRESS>I'll give it a shot. It may be a few days before I can both get it in production and verify that it's working, since it took so long to show up previously.
—
Reply to this email directly or view it on GitHub.

@gsoltis I think the change fixed it... Please re-open if you still see the issue.

Will do, thanks for your help!
On Tue, May 5, 2015 at 9:23 PM, Norman Maurer<EMAIL_ADDRESS>wrote:

Closed #3675 https://github.com/netty/netty/issues/3675.
—
Reply to this email directly or view it on GitHub
https://github.com/netty/netty/issues/3675#event-297870903.


Update logger samples for newer eventing versions

The logger samples were updated to be able to work with newer Knative Eventing versions, and InferenceService YAMLs were also updated to use the v1beta1 API.

/lgtm
/approve


Bottom navigation bar tiles/icons are spread too far apart on tablet or widescreen devices

When using BottomNavigationBar, the tiles/icons/items are spread too far apart on tablet devices, which is a bit weird. On phones/narrow screen devices (width <400), it looks okay though.
I tried implementing a custom bottom navigation bar using codes from Flutter's built bottom navigation bar:

I'm willing to take this if this is something that makes sense.
I'm on flutter 1.0.

Please add the output of flutter doctor -v.

A minimal reproduction would be great as well.

here's flutter doctor output:
[√] Flutter (Channel stable, v1.2.1, on Microsoft Windows [Version
    10.0.17134.590], locale en-US)
    • Flutter version 1.2.1 at E:\flutter
    • Framework revision 8661d8aecd (13 days ago), 2019-02-14 19:19:53 -0800
    • Engine revision 3757390fa4
    • Dart version 2.1.2 (build 2.1.2-dev.0.0 0a7dcf17eb)

[√] Android toolchain - develop for Android devices (Android SDK version
    28.0.3)
    • Android SDK at D:/android_sdk/
    • Android NDK location not configured (optional; useful for native
      profiling support)
    • Platform android-28, build-tools 28.0.3
    • ANDROID_HOME = D:\android_sdk
    • Java binary at: C:/AndroidStudio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_152-release-1024-b02)
    • All Android licenses accepted.

[√] Android Studio (version 3.1)
    • Android Studio at C:\AndroidStudio
    • Flutter plugin version 32.0.1
    • Dart plugin version 182.5124
    • Java version OpenJDK Runtime Environment (build
      1.8.0_152-release-1024-b02)

[!] Android Studio
    • Android Studio at C:/AndroidStudio
    X Flutter plugin not installed; this adds Flutter specific functionality.
    X Dart plugin not installed; this adds Dart specific functionality.
    • android-studio-dir = C:/AndroidStudio
    • Java version OpenJDK Runtime Environment (build
      1.8.0_152-release-1024-b02)

[√] VS Code (version 1.31.1)
    • VS Code at C:\Users\Tim Anthony\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 2.24.0

[√] Connected device (1 available)
    • Android SDK built for x86 64 • emulator-5554 • android-x64 • Android
      8.0.0 (API 26) (emulator)

! Doctor found issues in 1 category.

Here's a gist with the sample code using the current BottomNavigationBar
Output on phone:

Output on tablet:

Here's what I'm proposing:

Can also be set on the other side:

This issue still exist

Code Sample
// Flutter code sample for BottomNavigationBar

// This example shows a [BottomNavigationBar] as it is used within a [Scaffold]
// widget. The [BottomNavigationBar] has three [BottomNavigationBarItem]
// widgets and the [currentIndex] is set to index 0. The selected item is
// amber. The `_onItemTapped` function changes the selected item's index
// and displays a corresponding message in the center of the [Scaffold].
//
// ![A scaffold with a bottom navigation bar containing three bottom navigation
// bar items. The first one is selected.](https://flutter.github.io/assets-for-api-docs/assets/material/bottom_navigation_bar.png)

import 'package:flutter/material.dart';

void main() => runApp(MyApp());

/// This Widget is the main application widget.
class MyApp extends StatelessWidget {
  static const String _title = 'Flutter Code Sample';

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: _title,
      home: MyStatefulWidget(),
    );
  }
}

class MyStatefulWidget extends StatefulWidget {
  MyStatefulWidget({Key key}) : super(key: key);

  @override
  _MyStatefulWidgetState createState() => _MyStatefulWidgetState();
}

class _MyStatefulWidgetState extends State<MyStatefulWidget> {
  int _selectedIndex = 0;
  static const TextStyle optionStyle =
      TextStyle(fontSize: 30, fontWeight: FontWeight.bold);
  static const List<Widget> _widgetOptions = <Widget>[
    Text(
      'Index 0: Home',
      style: optionStyle,
    ),
    Text(
      'Index 1: Business',
      style: optionStyle,
    ),
    Text(
      'Index 2: School',
      style: optionStyle,
    ),
  ];

  void _onItemTapped(int index) {
    setState(() {
      _selectedIndex = index;
    });
  }

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: const Text('BottomNavigationBar Sample'),
      ),
      body: Center(
        child: _widgetOptions.elementAt(_selectedIndex),
      ),
      bottomNavigationBar: BottomNavigationBar(
        items: const <BottomNavigationBarItem>[
          BottomNavigationBarItem(
            icon: Icon(Icons.home),
            title: Text('Home'),
          ),
          BottomNavigationBarItem(
            icon: Icon(Icons.business),
            title: Text('Business'),
          ),
          BottomNavigationBarItem(
            icon: Icon(Icons.school),
            title: Text('School'),
          ),
        ],
        currentIndex: _selectedIndex,
        selectedItemColor: Colors.amber[800],
        onTap: _onItemTapped,
      ),
    );
  }
}

flutter doctor -v
[✓] Flutter (Channel dev, v1.18.0-8.0.pre, on Mac OS X 10.15.4 19E287, locale
    en-GB)
    • Flutter version 1.18.0-8.0.pre at /Users/taha/Code/flutter_dev
    • Framework revision e0c63cd35e (5 days ago), 2020-04-23 22:29:01 -0400
    • Engine revision d2ec21221e
    • Dart version 2.9.0 (build 2.9.0-3.0.dev b0d35855d8)

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
    • Android SDK at /Users/taha/Code/sdk
    • Platform android-29, build-tools 29.0.3
    • ANDROID_HOME = /Users/taha/Code/sdk
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_212-release-1586-b4-5784211)
    • All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS (Xcode 11.4.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.4.1, Build version 11E503a
    • CocoaPods version 1.9.1
[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome
[✓] Android Studio (version 3.6)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 45.1.1
    • Dart plugin version 192.7761
    • Java version OpenJDK Runtime Environment (build
      1.8.0_212-release-1586-b4-5784211)
[✓] VS Code (version 1.44.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.9.1
[✓] Connected device (5 available)
    • SM M305F      • 32003c30dc19668f          • android-arm64  • Android 10
      (API 29)
    • Taha’s iPhone • 00008020-001059882212002E • ios            • iOS 13.4.1
    • macOS         • macOS                     • darwin-x64     • Mac OS X
      10.15.4 19E287
    • Web Server    • web-server                • web-javascript • Flutter Tools
    • Chrome        • chrome                    • web-javascript • Google Chrome
      81.0.4044.129
• No issues found!

closing this since there were no responses

@brightknight08
This not currently a high priority but we keep the issue open for a future fix

thanks for the response @TahaTesser

flutter doctor -v
[✓] Flutter (Channel stable, 1.22.6, on macOS 11.1 20C69 darwin-x64, locale en-GB)
    • Flutter version 1.22.6 at /Users/tahatesser/Code/flutter_stable
    • Framework revision 9b2d32b605 (5 days ago), 2021-01-22 14:36:39 -0800
    • Engine revision 2f0af37152
    • Dart version 2.10.5

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Volumes/Extreme/SDK
    • Platform android-30, build-tools 30.0.3
    • ANDROID_HOME = /Volumes/Extreme/SDK
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 12.3)
    • Xcode at /Volumes/Extreme/Xcode.app/Contents/Developer
    • Xcode 12.3, Build version 12C33
    • CocoaPods version 1.10.1

[!] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)

[✓] VS Code (version 1.52.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.18.1

[✓] Connected device (2 available)
    • RMX2001 (mobile)     • EUYTFEUSQSRGDA6D          • android-arm64 • Android 10 (API 29)
    • Taha’s iPad (mobile) • 00008020-000255113EE8402E • ios           • iOS 14.3

! Doctor found issues in 1 category.

[✓] Flutter (Channel master, 1.26.0-13.0.pre.194, on macOS 11.1 20C69 darwin-x64, locale en-GB)
    • Flutter version 1.26.0-13.0.pre.194 at /Users/tahatesser/Code/flutter_master
    • Framework revision 71aec53acb (5 hours ago), 2021-01-26 21:53:04 -0800
    • Engine revision b11bef83a5
    • Dart version 2.12.0 (build 2.12.0-263.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Volumes/Extreme/SDK
    • Platform android-30, build-tools 30.0.3
    • ANDROID_HOME = /Volumes/Extreme/SDK
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Volumes/Extreme/Xcode.app/Contents/Developer
    • Xcode 12.3, Build version 12C33
    • CocoaPods version 1.10.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)

[✓] VS Code (version 1.52.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.18.1

[✓] Connected device (4 available)
    • RMX2001 (mobile)     • EUYTFEUSQSRGDA6D          • android-arm64  • Android 10 (API 29)
    • Taha’s iPad (mobile) • 00008020-000255113EE8402E • ios            • iOS 14.3
    • macOS (desktop)      • macos                     • darwin-x64     • macOS 11.1 20C69 darwin-x64
    • Chrome (web)         • chrome                    • web-javascript • Google Chrome 88.0.4324.96

• No issues found!

flutter doctor -v
[✓] Flutter (Channel stable, 1.22.6, on macOS 11.1 20C69 darwin-x64, locale en-GB)
    • Flutter version 1.22.6 at /Users/tahatesser/Code/flutter_stable
    • Framework revision 9b2d32b605 (5 days ago), 2021-01-22 14:36:39 -0800
    • Engine revision 2f0af37152
    • Dart version 2.10.5

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Volumes/Extreme/SDK
    • Platform android-30, build-tools 30.0.3
    • ANDROID_HOME = /Volumes/Extreme/SDK
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 12.3)
    • Xcode at /Volumes/Extreme/Xcode.app/Contents/Developer
    • Xcode 12.3, Build version 12C33
    • CocoaPods version 1.10.1

[!] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)

[✓] VS Code (version 1.52.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.18.1

[✓] Connected device (2 available)
    • RMX2001 (mobile)     • EUYTFEUSQSRGDA6D          • android-arm64 • Android 10 (API 29)
    • Taha’s iPad (mobile) • 00008020-000255113EE8402E • ios           • iOS 14.3

! Doctor found issues in 1 category.

[✓] Flutter (Channel master, 1.26.0-13.0.pre.194, on macOS 11.1 20C69 darwin-x64, locale en-GB)
    • Flutter version 1.26.0-13.0.pre.194 at /Users/tahatesser/Code/flutter_master
    • Framework revision 71aec53acb (5 hours ago), 2021-01-26 21:53:04 -0800
    • Engine revision b11bef83a5
    • Dart version 2.12.0 (build 2.12.0-263.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Volumes/Extreme/SDK
    • Platform android-30, build-tools 30.0.3
    • ANDROID_HOME = /Volumes/Extreme/SDK
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Volumes/Extreme/Xcode.app/Contents/Developer
    • Xcode 12.3, Build version 12C33
    • CocoaPods version 1.10.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)

[✓] VS Code (version 1.52.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.18.1

[✓] Connected device (4 available)
    • RMX2001 (mobile)     • EUYTFEUSQSRGDA6D          • android-arm64  • Android 10 (API 29)
    • Taha’s iPad (mobile) • 00008020-000255113EE8402E • ios            • iOS 14.3
    • macOS (desktop)      • macos                     • darwin-x64     • macOS 11.1 20C69 darwin-x64
    • Chrome (web)         • chrome                    • web-javascript • Google Chrome 88.0.4324.96

• No issues found!


Update docker.rst

Fix typo

Thanks! I rolled this up into https://github.com/edgedb/edgedb/pull/6331 along with a few of your other changes.


feat: load env variables from single .env and warn when not set

Loads environment variables for each project from a single .env file and warns when required environment variables are missing. This consists of a new load_env.js file which will generate the required variables for each framework, e.g. REACT_APP_* variables for connect-react or PLASMO_PUBLIC_* for extensions.
Also consolidates the variables names across projects, e.g.
PLASMO_PUBLIC_ANON_ENVIRONMENT -> PLASMO_PUBLIC_ANON_ENV
PLASMO_PUBLIC_ANON_CLIENT_ID -> PLASMO_PUBLIC_SDKCLIENT_ID
Note that each project that uses load_env.js must now include dotenv as a dependency,
since link_env.js uses the project that it is run in's node_modules folder.
Example output when variables are unset:
❯ yarn run dev
yarn run v1.22.22
$ NODE_PATH='./run-typescript' ../load_env.js npx tsx index.ts
Required Anon environment variables are not set!

ANON_APP_USER_ID_TOKEN
ANON_APP_USER_ID

Resolve this by doing any of the following:

- create a .env file at the root of this repo with the missing variables listed above
- fill in the empty variables in the .env.example at the root of this repo
- download a pre-filled .env fom https://console.anon.com/credentials and place it at the root of this repo

error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

How to test
You can uncomment these lines to see which ANON_ variables are sourced and which are generated per-project

https://github.com/anon-dot-com/examples/blob/bb1c714156202e8fd5ec6d13b7b0b078eb989d72/load_env.js#L100-L101

I'd rather have each project have a separate .env file.
Having a load_env.js file seems unnecessary to run the project.

Example multiple .env per project: https://github.com/stripe-samples/accept-a-payment

Then I'm not sure why we have an issue at all as is this the current set up using symlinks to remove an extra step of copying .envs for users

After some discussion, we decided to move load_env.js into each individual project, which would have brought many benefits

self-encapsulate every project so they can be copied out of the examples folder
remove the need for the heavy yarn script commands
move load_env.js to be called from the project's typescript to remove the need for child process
hardcode the PREFIX for each folder's load_env to remove the need for a generic switch case

However, some frameworks (such as react) are unable to use dotenv since it relies on OS packages like fs, and thus cannot be call loadEnv from within their frameworks.
Path forward is to have the .env file from the console contain every variant of environment variable so it can be dropped into any of the individual example projects and just work. Once that's the case we can remove the symlink'd .env files as well.

After some discussion, we decided to move load_env.js into each individual project, which would have brought many benefits

self-encapsulate every project so they can be copied out of the examples folder
remove the need for the heavy yarn script commands
move load_env.js to be called from the project's typescript to remove the need for child process
hardcode the PREFIX for each folder's load_env to remove the need for a generic switch case

However, some frameworks (such as react) are unable to use dotenv since it relies on OS packages like fs, and thus cannot be call loadEnv from within their frameworks.
Path forward is to have the .env file from the console contain every variant of environment variable so it can be dropped into any of the individual example projects and just work. Once that's the case we can remove the symlink'd .env files as well.


Form validation function

Pull request for #572 .
Still have to update type defs.

If the history is too gross I can make a new branch off master and cherry pick.


When asking for approval, the timer starts from the request and not from the approval

Hi guys!
When asking for approval, the timer starts from the request, not the approval.
So if I ask for an hour, and get the approval after 59 mins, I'll get only 1 min of access.
Here is a picture:

Hi Erez, thank you for the feedback. Do you think in general it is better to have timer start from approval instead?

Sure.

The approver knows that he's opening a session that will start immediately on approval.

Thank you! we will put this on our todo list.

@emrul Hi!
any news?
Developers keep asking for it :)

@ErezWeiss apologies for the wait. The new version of slack bot is now released which changed the selfserveapproval expiration start time from request time to approval time.
If possible could you upgrade your help chart to the latest version 0.1.7 and this should apply the changes directly, let me know how it goes.

Worked, thank you guys


训练数据格式问题

Reminder

[X] I have read the README and searched the existing issues.

System Info
请问这种格式的训练数据支持吗？如果支持，我的datainfo应该怎么写？
{"id": "multi_tools_train_103", "question": "What is the temperature like in London on the 1 days after 2023-06-27?", "pos_answer": {"answer": "The temperature in London on the 1 days after 2023-06-27 is 21.2(C).", "score": 1.0, "actions": "Thought: I need to search what day is 1 days after 2023-06-27.\nAction: Calendar.target_day\nAction Input: 2023-06-27, 1\nObservation: 2023-06-28\nThought: I need to search the weather in London on 2023-06-28\nAction: history_weather\nAction Input: London, 2023-06-28\nObservation: The weather for London on 2023-06-28 is: \noverall weather: Overcast; temperature: 21.2(C); wind speed: 15.5(kph), 9.6(mph); precipitation: 0.3(mm), 0.01(inch); visibility: 10.0(km), 6.0(miles); humidity: 68.0; UV index: 6.0.", "score_agent": {"explanation": "The executor agent began by using the Calendar.target_day tool to determine the date that is 1 day after 2023-06-27, with the observation showing the target date as 2023-06-28. Subsequently, the executor agent employed the history_weather tool to check the weather in London on 2023-06-28, yielding an observation that the temperature was 21.2\u00b0C, which perfectly matches the temperature given in the answer.", "score": "1.0"}}, "neg_answer": {"answer": "The temperature in London on the 1 days after 2023-06-27 is 19.8(C).", "score": -1.0, "actions": "Thought: I need to search what day is 1 days after 2023-06-27.\nAction: Calendar.target_day\nAction Input: 2023-06-27, 1\nObservation: 2023-06-28\nThought: I need to search the weather in London on 2023-06-28\nAction: history_weather\nAction Input: London, 2023-06-28\nObservation: The weather for London on 2023-06-28 is: \noverall weather: Overcast; temperature: 21.2(C); wind speed: 15.5(kph), 9.6(mph); precipitation: 0.3(mm), 0.01(inch); visibility: 10.0(km), 6.0(miles); humidity: 68.0; UV index: 6.0.", "score_agent": {"explanation": "The executor agent first used the Calendar.target_day tool to determine the date 1 day after 2023-06-27, which resulted in 2023-06-28. Subsequently, the agent employed the history_weather tool to fetch the weather data for London on this date. The observation indicates that the temperature in London on 2023-06-28 was 21.2\u00b0C.", "score": "-1.0"}}}
Reproduction

Expected behavior
No response
Others
No response

{
"id": "calendar_train_135",
"question": "Please let me know the day of the week that 2004-05-03 refers to.",
"pos_answer":
{
"answer": "2004-05-03 is Monday",
"score": 1.0,
"actions": "Thought: I need to search what day of the week is 2004-05-03.\nAction: Calendar.week_day\nAction Input: 2004-05-03\nObservation: Monday",
"score_agent":
{
"explanation": "The answer given, which states that the date 2004-05-03 is a Monday, aligns perfectly with the tool's execution result that also shows that the day was a Monday. This means that the provided answer is accurate and well-supported by the tool's findings.",
"score": "1.0"
}
},
"neg_answer":
{
"answer": "2004-05-03 is Friday",
"score": -1.0,
"actions": "Thought: I need to search what day of the week is 2004-05-03.\nAction: Calendar.week_day\nAction Input: 2004-05-03\nObservation: Monday",
"score_agent":
{
"explanation": "The provided answer indicated that May 3, 2004, was a Friday, which contradicts the result of the Calendar tool that clearly specifies that the date in question was a Monday. The glaring difference between the two responses points to the fact that the given answer is wrong.", "score": "-1.0"
}
}
}

https://github.com/hiyouga/LLaMA-Factory/blob/main/data/README_zh.md

https://github.com/hiyouga/LLaMA-Factory/blob/main/data/README_zh.md

这个我看过了，意思就是不支持吗


Feedback on quantize() API

Previously we do this
from torchao.quantization.quant_api import change_linear_weights_to_int8_woqtensors

model = torch.compile(model, mode="max-autotune", fullgraph=True)
change_linear_weights_to_int8_woqtensors(model)
# compile after quant also works

With the new quantization API, we have to do this
from torchao.quantization.quant_api import quantize, int8wo, unwrap_tensor_subclass

model = quantize(model, int8wo())  # or "int8_weight_only"
model = unwrap_tensor_subclass(model)
model = torch.compile(model, mode='max-autotune', fullgraph=True)  # must compile after unwrap

I think the new API is less user-friendly than the previous one.

int8wo(), int4wo() is a bit unintuitive. I understand it is a mechanism to pass params like group size to the quantization. Alternatives: full-blown class with __call__() method e.g. Int8WeightOnlyConfig (kinda verbose, but intention is clear); just pass quant params as extra args/kwargs e.g. quantize("int4wo", groupsize=128)
It's not clear what unwrap_tensor_subclass() does. Also, why do we need it now to compile the model, but not previously?

Small doc correction. unwrap_tensor_subclass() should be imported from torchao.utils or torchao.quantization.quant_api, not torchao.quantization.utils (https://github.com/pytorch/ao/tree/main/torchao/quantization)

@jerryzh168

So my understanding of unwrap_tensor_subclass() is this is primarily there to deal with some limitation of torch.export() but perhaps @tugsbayasgalan can shed some more light but if that's the case then we should ONLY recommend people do that for export() since indeed the API is strange cause it introduces concepts like unwrapping and subclasses which are implementation details so I see 2 options here

Either remove the call to unwrap() by default and only recommend people do it for export() and link to an issue in export() as to why this is needed so people can follow progress
Call unwrap automatically as part of quantize() function so end users aren't aware of it

Regarding the int8wo() only point the problem is not all quantization algorithms will share the same algorithms and kwargs are difficult for users to figure out what's actually supported granted we did explore some other ideas like

Don't have a top level user API for quantization
Don't try to shorten the names so for example jus say Int8WeightOnlyConfig, I personally strongly dislike our abbreviations like wo and qat since they're familiar to people that work with quantization all the time but no one else

On your point around compilation, it is indeed unclear when a user should vs must compile and we need to communicate the benefits

Using the new quantize() API, unwrap_tensor_subclass() is a MUST. Without it, I'm getting this error (running the snippet above)
  File "/home/---/code/ao/torchao/dtypes/aqt.py", line 240, in __torch_function__
    return _ATEN_OP_OR_TORCH_FN_TABLE[cls][func](*args, **kwargs)
  File "/home/---/code/ao/torchao/dtypes/utils.py", line 25, in wrapper
    return func(*args, **kwargs)
  File "/home/---/code/ao/torchao/dtypes/aqt.py", line 685, in functional_linear
    weight_tensor = weight_tensor.dequantize()
  File "/home/---/code/ao/torchao/dtypes/aqt.py", line 160, in dequantize
    int_data, scale, zero_point = self.layout_tensor.get_plain()
torch._dynamo.exc.TorchRuntimeError: Failed running call_method forward(*(Linear(in_features=4096, out_features=4096, bias=False), FakeTensor(..., device='cuda:0', size=(1, 4096), dtype=torch.float16)), **{}):
'FakeTensor' object has no attribute 'get_plain'

from user code:
   File "/home/---/miniconda3/envs/dev_nightly/lib/python3.10/site-packages/torch/_dynamo/external_utils.py", line 43, in inner
    return fn(*args, **kwargs)

Set TORCH_LOGS="+dynamo" and TORCHDYNAMO_VERBOSE=1 for more information

You can suppress this exception and fall back to eager by setting:
    import torch._dynamo
    torch._dynamo.config.suppress_errors = True

@msaroufim I am working on the support for unwrapping/wrapping nested tensor subclasses in PT2. In general, we expect we should be able to preserve the tensor subclasses if users are targetting our training IR and they shouldn't have to rely on unwrap_tensor_subclass().

Hi, I noticed that the GPTQ-related API was marked to be moved to prototype. Is there any alternative API to use, or are there any plans to support GPTQ formally?

@gau-nernst thanks for the feedback.

makes sense, Configs sounds reasonable to me, I'll gather a bit more feedback on this one
this is a temporary workaround and I hope it get fixed soon, @tugsbayasgalan is working on this one

Hi, I noticed that the GPTQ-related API was marked to be moved to prototype. Is there any alternative API to use, or are there any plans to support GPTQ formally?

we are thinking of deprecating GPTQ when we make HQQ work. cc @HDCharles to confirm that hqq is better than GPTQ in general.

Hi, I noticed that the GPTQ-related API was marked to be moved to prototype. Is there any alternative API to use, or are there any plans to support GPTQ formally?

can you also describe your use case for GPTQ as well?

Hi, I noticed that the GPTQ-related API was marked to be moved to prototype. Is there any alternative API to use, or are there any plans to support GPTQ formally?

to add on to what @jerryzh168 is saying, we haven't seen a lot of people interested in this API at the moment so its not something we've invested a ton of effort into, there are some limitations in the existing API/implementation that make it not work on some parts of some models unless they're carefully handled (https://github.com/pytorch/ao/blob/main/torchao/_models/llama/model.py#L89-L96) . We could fix those if we rewrote the whole thing, but until we do that, it hasn't been tested as thoroughly and isn't expected to work as widely as something like int8 weight only quantization. If you have a significant use case for GPTQ that may change what we do with it.

Hi, I noticed that the GPTQ-related API was marked to be moved to prototype. Is there any alternative API to use, or are there any plans to support GPTQ formally?

can you also describe your use case for GPTQ as well?

@jerryzh168 @HDCharles  My reason for keeping GPTQ support is because it is quite popular within the community :). For instance, Hugging Face currently lists 3000+ models related to GPTQ.

@jerryzh168 Just visiting this issue again, particularly about unwrap_tensor_subclass(). When I tested with latest main (96d49cd), unwrap_tensor_subclass() is still needed. Are there any drawbacks if we include it inside quantize() so that the users don't need to care about it? (as suggested by @msaroufim https://github.com/pytorch/ao/issues/384#issuecomment-2171701261).

@jerryzh168 Just visiting this issue again, particularly about unwrap_tensor_subclass(). When I tested with latest main (96d49cd), unwrap_tensor_subclass() is still needed. Are there any drawbacks if we include it inside quantize() so that the users don't need to care about it? (as suggested by @msaroufim #384 (comment)).

main thing is it makes it a bit harder to debug I think, we'll be removing this soon though, in these two days, stay tuned. we are waiting for https://github.com/pytorch/pytorch/pull/127431 to be landed, and I'll put up a PR to remove it

@jerryzh168 that's good to hear! However, users of previous versions of PyTorch (e.g. v2.3) will still need to unwarp tensor subclass? Might not be that important.

@jerryzh168 that's good to hear! However, users of previous versions of PyTorch (e.g. v2.3) will still need to unwarp tensor subclass? Might not be that important.

yeah that's true, I hope at some point we can just stop supporting 2.2 and 2.3 so we can deprecate the old APIs as well.
also we have an updated timeline of weeks to month, see comments in https://github.com/pytorch/ao/pull/462#discussion_r1661688379 for more details


Use Container.Config.Shell instead of hardcoded…

… for healthcheck. It make the code a little cleaner and more future/usage proof. Hopefully it's all green :angel:
/cc @justincormack @talex5 @thaJeztah @cpuguy83
:frog:
Signed-off-by: Vincent Demeester<EMAIL_ADDRESS>

LGTM

LGTM


syntax, controllers work with updated calibration, optional balance p…

changelog

made balance bot work with new motor calibration standard. (fixed +/- signs)
syntax fix (missing semicolon)
added optional (commented out) PID controller, where the P value updates the balance point of the robot in real time.

closes #50

@stilsota, I've rebased this on the latest version of the driver. If possible, could you download and run the balance bot example and confirm that it is working as expected? If so, this will be ready to merge into dev.

Just tried it. When I compile it throws this error:
I have a MotorGo 1.2 plugged in with the 2 PTZ motors. It is showing an up to date branch on feature-50/balance-bot-balance-point-tuning
/Users/tstilson/.platformio/packages/toolchain-xtensa-esp32s3/bin/../lib/gcc/xtensa-esp32s3-elf/8.4.0/../../../../xtensa-esp32s3-elf/bin/ld: .pio/build/balance_bot/libFrameworkArduino.a(main.cpp.o):(.literal._Z8loopTaskPv+0x8): undefined reference to setup()'
/Users/tstilson/.platformio/packages/toolchain-xtensa-esp32s3/bin/../lib/gcc/xtensa-esp32s3-elf/8.4.0/../../../../xtensa-esp32s3-elf/bin/ld: .pio/build/balance_bot/libFrameworkArduino.a(main.cpp.o):(.literal._Z8loopTaskPv+0xc): undefined reference to loop()' /Users/tstilson/.platformio/packages/toolchain-xtensa-esp32s3/bin/../lib/gcc/xtensa-esp32s3-elf/8.4.0/../../../../xtensa-esp32s3-elf/bin/ld: .pio/build/balance_bot/libFrameworkArduino.a(main.cpp.o): in function loopTask(void*)':
/Users/tstilson/.platformio/packages/framework-arduinoespressif32/cores/esp32/main.cpp:42: undefined reference to setup()' /Users/tstilson/.platformio/packages/toolchain-xtensa-esp32s3/bin/../lib/gcc/xtensa-esp32s3-elf/8.4.0/../../../../xtensa-esp32s3-elf/bin/ld: /Users/tstilson/.platformio/packages/framework-arduinoespressif32/cores/esp32/main.cpp:48: undefined reference to loop()'
collect2: error: ld returned 1 exit status
*** [.pio/build/balance_bot/firmware.elf] Error 1
===================== [FAILED] Took 38.56 seconds =====================
Environment    Status    Duration

balance_bot    FAILED    00:00:38.555
================ 1 failed, 0 succeeded in 00:00:38.555 ================

The terminal process "platformio 'run', '--environment', 'balance_bot'" terminated with exit code: 1.
Terminal will be reused by tasks, press any key to close it. `

Code is compiling but on balance bot and spin 2 motors examples, but the motor calibrations do not appear to be saving to the board.
output from spin 2 motors code:
--- Terminal on /dev/cu.usbmodem1301 | 115200 8-N-1
--- Available filters and text transformations: colorize, debug, default, direct, esp32_exception_decoder, hexlify, log2file, nocontrol, printable, send_on_enter, time
--- More details at https://bit.ly/pio-monitor-filters
--- Quit: Ctrl+C | Menu: Ctrl+T | Help: Ctrl+T followed by Ctrl+H
[  3114][E][esp32-hal-spi.c:178] spiAttachSCK(): HSPI Does not have default pins on ESP32S3!
[  3114][E][esp32-hal-spi.c:215] spiAttachMISO(): HSPI Does not have default pins on ESP32S3!
[  3119][E][esp32-hal-spi.c:247] spiAttachMOSI(): HSPI Does not have default pins on ESP32S2!
Starting Sensor Calibration.
MOT: sensor_direction==CW
Rotating forwards
Rotating backwards
Average Zero Electrical Angle: 0.00
Sensor Calibration Done.
Initialized ch0
Starting Sensor Calibration.
MOT: sensor_direction==CW
Rotating forwards
Rotating backwards
Average Zero Electrical Angle: 0.00
Sensor Calibration Done.
Initialized ch1

Observed behavior:

flashed code with bool calibrate = true
motors calibrate normally (no issue with motor wires or connections)
estimated electrical angle = 0.00 for both motors
after calibration, motors lock up and do not spin.

Troubleshooting steps:

triple checked encoder wire connections and motor connections
try another MotorGo board for spin 2 motors example

Just to confirm, you tried another MotorGo board in your troubleshooting steps?
Looking at the serial output you posted, I'm suspicious that the issue is realted to the SPI errors you see before sensor calibration - we should never be trying to use the default pins. Let me dig into that right now

This issue has been addressed by #65, merging these changes into dev.


fix(serialization): Drop atomics dependency & make perf stats optional

Locking instead of atomics, and optional _perf_stats
This change switches from using the atomics package for synchronized variable access to explicit locking, to avoid errors thrown by that package's deallocation code, and also for performance (amusingly). Additionally, the internal-only _perf_stats gathered during deserialization are now optional, and are only collected if the environment variable TENSORIZER_ENABLE_PERF_STATS is set.

@Eta0 Doing an executive decision, and merging as atomics actually made this library stop working for a customer -- they do local development on Macs.
Going forward, we will be testing all changes on Macs in addition to Linux.


Basic install of service fabric development doesn't work on Mac OS X and Ubuntu due to FileStoreService segfault

I'm following the instructions to the dot, in getting a dev environment setup for service fabric on docker on Mac OS X. I got the cluster itself running, and my SF Dashboard looks OK.
However whenever I try to install a test reliable service application (generated by yeoman), the ./install.sh fails when it tries to upload the application. At the same time, SF Dashboard reports that the ImageStoreService has experienced a quorum loss, and it fixes itself in a minute (I assume it experienced a crash).
I have the same error when trying this on Ubuntu (while still running the docker image).
Here's the error as reported on ./install.sh:
user@instance-1:~/myapp/mystatefulapp$ ./install.sh
[1/51] files, ApplicationManifest.xml
[2/51] files, _.dir
[3/51] files, MystatefulappservicePkg/ServiceManifest.xml
[4/51] files, MystatefulappservicePkg/_.dir
[5/51] files, MystatefulappservicePkg/Code/dotnet-include.sh
[6/51] files, MystatefulappservicePkg/Code/Mystatefulappservice.runtimeconfig.json
[7/51] files, MystatefulappservicePkg/Code/Mystatefulappservice.dll
[8/51] files, MystatefulappservicePkg/Code/Mystatefulappservice.deps.json
[9/51] files, MystatefulappservicePkg/Code/Mystatefulappservice.pdb
[10/51] files, MystatefulappservicePkg/Code/entryPoint.sh
[11/51] files, MystatefulappservicePkg/Code/_.dir
[12/51] files, MystatefulappservicePkg/Code/runtimes/_.dir
[13/51] files, MystatefulappservicePkg/Code/runtimes/win/_.dir
[14/51] files, MystatefulappservicePkg/Code/runtimes/win/lib/_.dir
[15/51] files, MystatefulappservicePkg/Code/runtimes/win/lib/netstandard2.0/Microsoft.ServiceFabric.Internal.Strings.dll
[16/51] files, MystatefulappservicePkg/Code/runtimes/win/lib/netstandard2.0/Microsoft.ServiceFabric.Diagnostics.dll
[17/51] files, MystatefulappservicePkg/Code/runtimes/win/lib/netstandard2.0/Microsoft.ServiceFabric.Data.Interfaces.dll
[18/51] files, MystatefulappservicePkg/Code/runtimes/win/lib/netstandard2.0/Microsoft.ServiceFabric.Data.Extensions.dll
[19/51] files, MystatefulappservicePkg/Code/runtimes/win/lib/netstandard2.0/System.Fabric.dll
[20/51] files, MystatefulappservicePkg/Code/runtimes/win/lib/netstandard2.0/Microsoft.ServiceFabric.ReliableCollection.Interop.dll
[21/51] files, MystatefulappservicePkg/Code/runtimes/win/lib/netstandard2.0/System.Fabric.Strings.dll
[22/51] files, MystatefulappservicePkg/Code/runtimes/win/lib/netstandard2.0/Microsoft.ServiceFabric.Data.dll
[23/51] files, MystatefulappservicePkg/Code/runtimes/win/lib/netstandard2.0/System.Fabric.Management.ServiceModel.dll
[24/51] files, MystatefulappservicePkg/Code/runtimes/win/lib/netstandard2.0/Microsoft.ServiceFabric.Services.dll
[25/51] files, MystatefulappservicePkg/Code/runtimes/win/lib/netstandard2.0/Microsoft.ServiceFabric.Internal.dll
[26/51] files, MystatefulappservicePkg/Code/runtimes/win/lib/netstandard2.0/Microsoft.ServiceFabric.Preview.dll
[27/51] files, MystatefulappservicePkg/Code/runtimes/win/lib/netstandard2.0/_.dir
[28/51] files, MystatefulappservicePkg/Code/runtimes/linux/_.dir
[29/51] files, MystatefulappservicePkg/Code/runtimes/linux/lib/_.dir
[30/51] files, MystatefulappservicePkg/Code/runtimes/linux/lib/netstandard2.0/System.Private.Interop.dll
[31/51] files, MystatefulappservicePkg/Code/runtimes/linux/lib/netstandard2.0/Microsoft.ServiceFabric.Internal.Strings.dll
[32/51] files, MystatefulappservicePkg/Code/runtimes/linux/lib/netstandard2.0/System.Private.CompilerServices.ICastable.dll
[33/51] files, MystatefulappservicePkg/Code/runtimes/linux/lib/netstandard2.0/Microsoft.ServiceFabric.Diagnostics.dll
[34/51] files, MystatefulappservicePkg/Code/runtimes/linux/lib/netstandard2.0/Microsoft.ServiceFabric.Data.Interfaces.dll
[35/51] files, MystatefulappservicePkg/Code/runtimes/linux/lib/netstandard2.0/Microsoft.ServiceFabric.Data.Extensions.dll
[36/51] files, MystatefulappservicePkg/Code/runtimes/linux/lib/netstandard2.0/System.Fabric.dll
[37/51] files, MystatefulappservicePkg/Code/runtimes/linux/lib/netstandard2.0/Microsoft.ServiceFabric.Internal.McgInterop.dll
[38/51] files, MystatefulappservicePkg/Code/runtimes/linux/lib/netstandard2.0/Microsoft.ServiceFabric.ReliableCollection.Interop.dll
[39/51] files, MystatefulappservicePkg/Code/runtimes/linux/lib/netstandard2.0/System.Fabric.Strings.dll
[40/51] files, MystatefulappservicePkg/Code/runtimes/linux/lib/netstandard2.0/Microsoft.ServiceFabric.Data.dll
[41/51] files, MystatefulappservicePkg/Code/runtimes/linux/lib/netstandard2.0/System.Fabric.Management.ServiceModel.dll
[42/51] files, MystatefulappservicePkg/Code/runtimes/linux/lib/netstandard2.0/Microsoft.ServiceFabric.Services.dll
[43/51] files, MystatefulappservicePkg/Code/runtimes/linux/lib/netstandard2.0/System.Fabric.McgInterop.dll
[44/51] files, MystatefulappservicePkg/Code/runtimes/linux/lib/netstandard2.0/Microsoft.ServiceFabric.Internal.dll
[45/51] files, MystatefulappservicePkg/Code/runtimes/linux/lib/netstandard2.0/Microsoft.ServiceFabric.Preview.dll
[46/51] files, MystatefulappservicePkg/Code/runtimes/linux/lib/netstandard2.0/_.dir
[47/51] files, MystatefulappservicePkg/Data/_readme.txt
[48/51] files, MystatefulappservicePkg/Data/_.dir
[49/51] files, MystatefulappservicePkg/Config/Settings.xml
[50/51] files, MystatefulappservicePkg/Config/_readme.txt
[51/51] files, MystatefulappservicePkg/Config/_.dir
Complete
(FABRIC_E_IMAGEBUILDER_VALIDATION_ERROR) Exception while parsing XML file: /home/ClusterDeployer/ClusterData/Data/N0020/Fabric/work/IB/131940845773649610/byhw4jzg.fge
FileName: /home/ClusterDeployer/ClusterData/Data/N0020/Fabric/work/IB/131940845773649610/byhw4jzg.fge --> InvalidOperationException: There is an error in XML document (0, 0). --> XmlException: Root element is missing.
Traceback (most recent call last):
  File "/usr/local/lib/python3.5/dist-packages/knack/cli.py", line 206, in invoke
    cmd_result = self.invocation.execute(args)
  File "/usr/local/lib/python3.5/dist-packages/knack/invocation.py", line 188, in execute
    cmd_result = parsed_args.func(params)
  File "/usr/local/lib/python3.5/dist-packages/knack/commands.py", line 105, in __call__
    return self.handler(*args, **kwargs)
  File "/usr/local/lib/python3.5/dist-packages/knack/commands.py", line 212, in _command_handler
    result = op(client, **command_args) if client else op(**command_args)
  File "/usr/local/lib/python3.5/dist-packages/sfctl/custom_app_type.py", line 120, in provision_application_type
    raise FabricErrorException(client._deserialize, response)
azure.servicefabric.models.fabric_error.FabricErrorException: (FABRIC_E_IMAGEBUILDER_VALIDATION_ERROR) Exception while parsing XML file: /home/ClusterDeployer/ClusterData/Data/N0020/Fabric/work/IB/131940845773649610/byhw4jzg.fge
FileName: /home/ClusterDeployer/ClusterData/Data/N0020/Fabric/work/IB/131940845773649610/byhw4jzg.fge --> InvalidOperationException: There is an error in XML document (0, 0). --> XmlException: Root element is missing.
(FABRIC_E_APPLICATION_TYPE_NOT_FOUND) Application type and version not found
Traceback (most recent call last):
  File "/usr/local/lib/python3.5/dist-packages/knack/cli.py", line 206, in invoke
    cmd_result = self.invocation.execute(args)
  File "/usr/local/lib/python3.5/dist-packages/knack/invocation.py", line 188, in execute
    cmd_result = parsed_args.func(params)
  File "/usr/local/lib/python3.5/dist-packages/knack/commands.py", line 105, in __call__
    return self.handler(*args, **kwargs)
  File "/usr/local/lib/python3.5/dist-packages/knack/commands.py", line 212, in _command_handler
    result = op(client, **command_args) if client else op(**command_args)
  File "/usr/local/lib/python3.5/dist-packages/sfctl/custom_app.py", line 259, in create
    client.create_application(app_desc, timeout)
  File "/usr/local/lib/python3.5/dist-packages/azure/servicefabric/service_fabric_client_ap_is.py", line 3364, in create_application
    raise models.FabricErrorException(self._deserialize, response)
azure.servicefabric.models.fabric_error_py3.FabricErrorException: (FABRIC_E_APPLICATION_TYPE_NOT_FOUND) Application type and version not found
/home/user/myapp/mystatefulapp

UPDATE:
I'm encountering the exact same issue on a native Ubuntu 16.04 install. Upon further investigation, there appears to be a segfault on FileStoreService in /var/log/syslog:
Feb  8 22:50:45 fabric-ubuntu-dev kernel: [ 1665.850759] FileStoreServic[32657]: segfault at fffffffffffffff8 ip<PHONE_NUMBER>5fc4b7 sp 00007f06f1bfa6f0 error 7 in FileStoreService.exe[400000+3264000]

Did something break in a recent version?
Is there anyone using SF on linux/macOS for development?

Ah, it looks like a rssh security issue for which you guys had sent out the advisory. Downgrading rssh fixes the issue.
https://blogs.msdn.microsoft.com/azureservicefabric/2019/02/07/known-issue-for-service-fabric-linux-clusters/


Added support for documenting methods with no @Path annotation

Previously, an API like such would not be picked up by the JAXRS processor.
@Path("/snow-report/{mountainId}")
public class SnowReportController {
    @GET
    public SnowReport getReportForMountain(
        @PathParam("mountainId") String mountainId) {
        return null;
    }
}

Now it does.

Reviewing for better implementation.


Fix UndoRedo crash when clearing history

When the parameter of add_{,un}do_reference is an Reference, UndoRedo will hold an Ref to that reference.
When clearing action history (either discarding redo or clearing all history), the referenced object was manually memdeleted and might then be deleted again when the Ref is destructed.
So, I think an unref is enough in that case.
Fixes #50769
Fixes #48756

Thanks!

Cherry-picked for 3.4.

Cherry-picked for 3.3.3.

Cherry-picked for 3.3.3.

Or not, this doesn't apply to 3.3 as 90f13520ddb75a7ae64c35d61dc4b71ef9e4e41d wasn't cherry-picked.


Patch 1

@blcham

@blcham please check
I created a pull request but it is closed  by github-action

@ahmadjana Please provide a description for the PR. It was closed automatically by the workflow because its description is empty.


Added test for swapping corners in blockwise visual mode

This PR adds a test for swapping corners with o and O in
blockwise visual mode, which was not tested according to codecov:
https://codecov.io/gh/vim/vim/src/master/src/normal.c#L7208

Codecov Report

Merging #2932 into master will increase coverage by 0.34%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2932      +/-   ##
==========================================
+ Coverage   75.34%   75.69%   +0.34%
==========================================
  Files          92       92
  Lines      132552   135019    +2467
==========================================
+ Hits        99871   102202    +2331
- Misses      32681    32817     +136

Impacted Files
Coverage Δ

src/if_python3.c
74.8% <0%> (-1.38%)
:arrow_down:

src/if_python.c
76.55% <0%> (-1.31%)
:arrow_down:

src/spellfile.c
73.94% <0%> (-1.05%)
:arrow_down:

src/if_perl.xs
85.86% <0%> (-0.36%)
:arrow_down:

src/netbeans.c
27.03% <0%> (-0.28%)
:arrow_down:

src/libvterm/src/screen.c
58.97% <0%> (-0.25%)
:arrow_down:

src/if_lua.c
54.17% <0%> (-0.16%)
:arrow_down:

src/main.c
57.51% <0%> (-0.16%)
:arrow_down:

src/eval.c
81.55% <0%> (-0.11%)
:arrow_down:

src/regexp.c
82.61% <0%> (-0.08%)
:arrow_down:

... and 67 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d19b234...4b383fa. Read the comment docs.


Warning: Failed child context type: Invalid child context virtualizedCell.cellKey of type number supplied to CellRenderer, expected string.

Anyone Know why i am getting this warning?
Here is my Package JSON
{
"name": "myApp",
"version": "0.1.0",
"private": true,
"devDependencies": {
"react-native-scripts": "1.14.0",
"jest-expo": "~27.0.0",
"react-test-renderer": "16.3.1"
},
"main": "./node_modules/react-native-scripts/build/bin/crna-entry.js",
"scripts": {
"start": "react-native-scripts start",
"eject": "react-native-scripts eject",
"android": "react-native-scripts android",
"ios": "react-native-scripts ios",
"test": "jest"
},
"jest": {
"preset": "jest-expo"
},
"dependencies": {
"expo": "^27.0.1",
"react": "16.3.1",
"react-native": "~0.55.2",
"react-native-events-calendar": "^1.0.8",
"react-native-material-cards": "^1.0.9",
"react-native-material-ui": "^1.30.1",
"react-native-vector-icons": "^5.0.0",
"react-navigation": "^2.9.3"
}
}
and here is the code snippet
import React from 'react';
import { StyleSheet, View , Text, SafeAreaView, Dimensions, ListView} from 'react-native';
import BottomNavigation from './utils/bottomNav'
import title from './utils/setTitle'
import EventCalendar from 'react-native-events-calendar'
const events = [
{ start: '2017-09-07 00:30:00', end: '2017-09-07 01:30:00', title: 'Dr. Mariana Joseph', summary: '3412 Piedmont Rd NE, GA 3032' },
{ start: '2017-09-07 01:30:00', end: '2017-09-07 02:20:00', title: 'Dr. Mariana Joseph', summary: '3412 Piedmont Rd NE, GA 3032' },
{ start: '2017-09-07 04:10:00', end: '2017-09-07 04:40:00', title: 'Dr. Mariana Joseph', summary: '3412 Piedmont Rd NE, GA 3032' },
{ start: '2017-09-07 01:05:00', end: '2017-09-07 01:45:00', title: 'Dr. Mariana Joseph', summary: '3412 Piedmont Rd NE, GA 3032' },
{ start: '2017-09-07 14:30:00', end: '2017-09-07 16:30:00', title: 'Dr. Mariana Joseph', summary: '3412 Piedmont Rd NE, GA 3032' },
{ start: '2017-09-08 01:20:00', end: '2017-09-08 02:20:00', title: 'Dr. Mariana Joseph', summary: '3412 Piedmont Rd NE, GA 3032' },
{ start: '2017-09-08 04:10:00', end: '2017-09-08 04:40:00', title: 'Dr. Mariana Joseph', summary: '3412 Piedmont Rd NE, GA 3032' },
{ start: '2017-09-08 00:45:00', end: '2017-09-08 01:45:00', title: 'Dr. Mariana Joseph', summary: '3412 Piedmont Rd NE, GA 3032' },
{ start: '2017-09-08 11:30:00', end: '2017-09-08 12:30:00', title: 'Dr. Mariana Joseph', summary: '3412 Piedmont Rd NE, GA 3032' },
{ start: '2017-09-09 01:30:00', end: '2017-09-09 02:00:00', title: 'Dr. Mariana Joseph', summary: '3412 Piedmont Rd NE, GA 3032' },
{ start: '2017-09-09 03:10:00', end: '2017-09-09 03:40:00', title: 'Dr. Mariana Joseph', summary: '3412 Piedmont Rd NE, GA 3032' },
{ start: '2017-09-09 00:10:00', end: '2017-09-09 01:45:00', title: 'Dr. Mariana Joseph', summary: '3412 Piedmont Rd NE, GA 3032' }
]
class HomeScreen extends React.Component {
constructor(props){
super(props)
const ds = new ListView.DataSource({rowHasChanged: (r1, r2) => r1 !== r2});
this.state = {
events: ds.cloneWithRows(events)._dataBlob.s1,
}
}
static navigationOptions =  title('Agenda')
render() {
console.log(this.state.events);
const width= Dimensions.get('window')
return (

<EventCalendar
events={this.state.events}
width={width.width}
initDate={'2017-09-08'}
/>

<BottomNavigation active={{active: this.props.navigation.getParam('active', 'agenda')}} navigate={this.props.navigation.navigate} />

);
}
}
const styles = StyleSheet.create({
container: {
flex: 1,
flexDirection: 'column',
justifyContent: 'space-between',
},
safeArea: {
flex: 5,
}
});
export default HomeScreen;

keyExtractor takes a function that returns a string, not a number. This is fixed in
this PR here. The source code on github is updated but seems like it's not updated on npm yet. @joshjhargreaves any plans on updating on npm?

@jackfan108 I will do an npm release soon: in the meantime you could use the package as a git dependency:
react-native-event-calendar: "git+https://github.com/joshjhargreaves/react-native-event-calendar#4b56322df6c70ea3068153dab47227fad2e2c183"

Will be fixed by a new release to npm: https://github.com/joshjhargreaves/react-native-event-calendar/issues/17

NPM is not updated yet?

Hi am still having this annoying warning;

2020 And they still don't update it, please update it!!!


Use an existing crawl results if available

When crawling the site, first check to see if the results of crawling are already present.
If they are present, load that file, instead of recrawling.
optionally give an option to use a file?

now it checks <site>.sitemap.json first, before generating it. User has the option to override.
this effectively gives user to also provide own list of links.


Your name...

I'm just wondering how to pronounce your last name. Thanks :smile:

https://www.youtube.com/watch?v=StoEiUYL2gQ :D

Thanks :)

Doing an issue cleanup; closing for now!