[UPNP] Allow disabling UPNP implementation on the Web

Make UPNP classes custom instance, so they can come with empty implementation on the Web (where the would not work anyway) without breaking scripts referencing it.
This results in smaller Web builds by not including the library which also results in the emscripten socket wrappers to be stipped away.

Thanks!


Fix ScriptCreateDialog so it does not select the file extension when it's opened

Fixes: #89295
This is a regression from commit 2bd714e34eb57b3fff2c9eaff0eb59ac2cb515aa

Thanks!


Add optional confirmation_depth field to cert verification

A confirmation depth should be added in the certificate verification as a counter-measure to an attack vector where the disperser gives a rollup sequencer a blob which is verified against a block which is subsequently reorged from the L1 chain. In the current DA interaction model, this would result in DoS on the rollup, rendering it incapable of progression state.

#51


⚠ AGEG website (prod) has degraded performance

In 5d50c69, AGEG website (prod) (https://www.ageg.ca/) experienced degraded performance:

HTTP code: 200
Response time: 2344 ms

Resolved: AGEG website (prod) performance has improved in 5f30e0b.


Common reorganization/sample refactor

This branch makes several changes to all of the samples as well as the showcase in order to prepare existing showcase samples to be ported over to the sandbox.
Primary Changes:
-Reorganized the common and Components folders. common now contains code that is shared between several samples(such as the geometry decorator), while Components contain code that is used directly by the showcase(such as the sample gallery)
-Removed the need for samples to have setup and teardown functions. Code that was used by samples as part of setup or teardown has been moved into ComponentDidMount and ComponentWillUnmount on the UI Components.

LGTM; Tested the samples I created as well as several others. Also quickly scanned though code and looked good as well.


Subqueries

According to the docs it appears that subqueries are not even going to be on the roadmap in the future, is there a reason for this decision? Will there be some alternative but semantically similar way to achieve the same effect?

Lovefield is still in a very early stage. There are quite a few features (e.g. constraints) we'd like to implement before even thinking about subqueries. Meanwhile, one can always use two or more queries to achieve the same results.

I'm not questioning the timing of this feature, merely the fact that from the start the documentation states that this will not be implemented (as opposed to not saying anything at all - or - saying it will be on the roadmap in the very distant future).
I was just wondering if there was a technical reason for stating this in the document, for example: that this would be impossible to do given the architecture of lovefield.

There are some technical issues that need to be overcome before declaring the implementation of subqueries. For example, transaction model of IndexedDB is not really for subqueries. Unless we have figured a clear way of implementing that feature, we will not put it on our roadmap.
In other words, roadmap is for something that we are certain is doable, and we just need time and people to do it. Things that will not implemented can be moved to a distant roadmap if and only if we are certain it can be done and there are actual client needs for them.

I love what lovefield is already able to do and I highly respect your work! It is an almost incomprehensibly complex task to implement an RDBMS, yet alone in JavaScript. May I be so bold, since this request is two years old, to ask for an update on the current state of subqueries?

The team has no plan to implement this feature. We do welcome contributions.

Thanks for the update and the quick response!


Can't access token in form submission

I am having an issue accessing the token submitted in a form following the pattern from the readme. The readme example includes
<%= form_for :foo, Routes.foo_path(MyApp.Endpoint, :new), fn f -> %>
  <%= hidden_input, f, :token, value: Guardian.Plug.current_token(conn) %>
  <%= submit "Submit" %>
<% end %>

The problem I am seeing is that this results in the token being passed in the params under params.foo.token. Shopifex.Plug.ShopifySession.get_token_from_conn\1 expects the token to be in params.token. However, I see no way to get it there with a hidden input in a form.
I have a proposed change that I have made locally and is working. Since the hidden input can take any atom as it's input, we can pass the same atom to all hidden inputs (in all forms) so the token is always found in the same place. For example:
<%= form_for :foo, Routes.foo_path(MyApp.Endpoint, :new), fn f -> %>
  <%= hidden_input :hidden_input, :token, value: Guardian.Plug.current_token(@conn) %>
  <%= submit "Submit" %>
<% end %>

And now we can add another clause to Shopifex.Plug.ShopifySession.get_token_from_conn\1
# existing
defp get_token_from_conn(%Plug.Conn{params: %{"token" => token}}), do: token

# new
defp get_token_from_conn(%Plug.Conn{params: %{"hidden_input" => %{"token" => token}}}), do: token

My only confusion with this approach is that it goes against the suggestion made by Dockyard in their Tips for Token Article where they suggest requiring tokens in the Authorization header (as you have shown in the SPA example). This seems like a good idea but I don't see any way to getting the token in the Authorization header.
If you agree with my solution I could submit a PR with the change.

I went ahead and opened up a pull request with this change. However, this if the first time I am testing with v0.6 and I am getting a compilation error unrelated to my change. I haven't had a chance to do much digging yet but I am getting:
== Compilation error in file lib/shopifex_web/views/error_view.ex ==
** (CompileError) lib/shopifex_web/views/error_view.ex:2: module ReactPhoenix.ClientSide is not loaded and could not be found
    expanding macro: ShopifexWeb.__using__/1
    lib/shopifex_web/views/error_view.ex:2: ShopifexWeb.ErrorView (module)
    (elixir 1.11.3) expanding macro: Kernel.use/2
    lib/shopifex_web/views/error_view.ex:2: ShopifexWeb.ErrorView (module)
    (elixir 1.11.3) lib/kernel/parallel_compiler.ex:314: anonymous fn/4 in Kernel.ParallelCompiler.spawn_workers/7

Thank you! I did not like the "hidden_input" method either and this is clearly the much better solution.
I have updated my PR to be a documentation update instead.
In regards to the other compile issue I saw, not sure what happened. After cleaning deps it is working now. I was using v0.5 previously for reference.


CryptoNight v2 RX Vega Performance Regression on AMDGPU-PRO 18.50

So, our good ol’ Vega hashrate issue https://github.com/RadeonOpenCompute/ROCm/issues/325 ended up being solved by using amdgpu-pro 18.30 together with either an older OpenCL compiler version or ROCm-HCC.
As far as I understood, it was basically the firmware shipped with amdgpu-pro that made the difference.
I believe 18.20 did also work. 18.40 still does.
18.50 however sees significantly worse hashrates on cn/2 variants. Interestingly, cn/1 and cn/0 retain full performance.
The critical loop of CryptoNight does reads to random addresses in 2 MB scratchpads and writes back new values.
In cn/0 and cn/1, the reads are 128 bit wide.
In cn/2, they are 4x128 bit wide instead, covering 3 adjacent addresses via XOR. (I.e. what is read is the computed address, as well as address^1, address^2, address^3. There is again a write-back to each of these addresses.)
Just wanted to let you know. I’m of course free to stick with 18.40, and will do so, but perhaps this observation is an indication of a larger problem worth fixing.
Cheers!

Hi @949f45ac
I recommend taking this report to other support forums, as this is for ROCm software only. Thanks.


"PURPOSE not defined" on boot loader

The cause is incorrect formatting of file /boot/logo-trident.4th read by the forth interpreter.
The words PURPOSE, CONSEQUENTIAL, STRICT, and WAY,  all part of the standard legal disclaimer, are incorrectly formatted (looks like bad cut and paste) are are interpreted by forth.  This causes an error on processing of logo-trident.4th and no trident is displayed.
However, if corrected, a separate problem occurs.  The file "logo-trident.4th" is displayed resulting in an overlapping trident on top of the displayed menu (brand-trident.4th), as shown in the attached image.

A horizontal trident is suggested for

A horizontal trident is suggested for logo-trident.4th.

Here's a sample of a horizontal trident for an artist better than me :-)
logo-trident.4th.txt
File must be installed as /boot/logo-trident.4th  to work.

Thank you for pointing that out!
I just fixed the brand-trident.4th file in this commit: https://github.com/trueos/trueos/commit/f69c78502b08ddd0583faae38bc8d2a185cf7b60#diff-6883b5ddd892906d6e5a15efeff52ace
and I fixed the logo-trident.4th file for the syntax issues in this commit: https://github.com/trueos/trueos/commit/7d23d5a2e0e288567136b33c992487f144fabab7#diff-6883b5ddd892906d6e5a15efeff52ace
The "logo" will always appear on the right-side of the menu box for the FreeBSD boot menu, so a vertical trident seems to make more sense so that the boot menu can fit on 4:3 aspect ratio screens instead of assuming a 16:9 aspect ratio. The only thing we will still need to test/adjust for the logo file now is probably the placement/scaling of the ascii. I am not terribly familiar with forth, but it seems like we might be able to just adjust line 29 (reproduced below) to move the logo a bit further to the right.
52 logoX ! 9 logoY ! \ Initialize logo placement defaults

The Trident has now been moved to the right a bit and sligned with the bottom of the menu box.
It also has color too!
https://github.com/trueos/trueos/commit/ec18031213ada03804f69cbd8224e751a2c17adf


Confusion upon email signup while waiting for the verification link

I tried signing up into my newly created open-saas app once I got it started, I signed up with email and pass, and I got a message that now I need to click on my verification link in my email.
But, of course, I got no verification link in the email, since Dummy provider is used (which I might not be aware of if I didn't know Wasp, and would probably keep checking the email).
So even though I knew I am not getting an email, I actually didn’t know what to do! What now? I looked into the terminal (which if I didn't know Wasp, I probably wouldn't have thought of), but no message there either. I guess we set the flag that no verification is needed?
So I finally tried logging in and that worked! But I would never think of trying logging in actually if I didn't know this much about Wasp, I would instead keep checking that email, and try other stuff, probably try signing again.
I think we need to tell them somehow what to do here.
Possible solution might be to print email in the terminal. But how will they know they need to look there? We can extend the message in the app that they get upon signup, regarding checking the email, so it says they are using Dummy provider and should look in their terminal, not in email. In Wasp Generator, we can potentially do this if we see that Dummy provider is used! Yeah, I think this could be cool solution.
Additionaly, I noticed we do mention in comments in main.wasp file that they should check server logs (we don’t tell them those will be in the terminal though! As a new user, I probably am not sure what "server logs" means), but I haven’t read that at this point yet, so didn’t know about this. Nor was anything printed to the terminal actually, so this comment is outdated / wrong also.
Actual Wasp user went through this confusion also: https://discord.com/channels/686873244791210014/1236335436918689832/1236335436918689832 .

@Martinsos what if we add something to the template UI (that they will obviously delete later) that alerts them to ignore the messages and explains the Dummy email provider + email signup process?
Otherwise, the docs do explain this in a couple different sections:

https://docs.opensaas.sh/guides/authentication/#email-verified-auth
https://docs.opensaas.sh/guides/email-sending/#the-dummy-email-provider-for-local-dev-only

But you are right, theSKIP_EMAIL_VERIFICATION_IN_DEV=true var is set so theyre not being logged to the console (i probably changed this for e2e testing and forgot about the implications for the auth flow)

I made this PR as a potential part of the solution: https://github.com/wasp-lang/wasp/pull/2052 .
We should also do following then:

[ ] Mention it in the docs in an earlier place, probably right before they start playing with their newly created open-saas app.
[ ] remove SKIP_EMAIL_VERIFICATION_IN_DEV=true

ok @Martinsos I added a section on the Dummy provider to the Auth section of the "Guider Tour".
SKIP_EMAIL_VERIFICATION_IN_DEV=true has been removed from the template but remains in .github/workflows/e2e-tests.yml so that it's available to the tests in the latest commit 2c94ced5c53f7caf7b753b5a5d1026500ad914b6

ok @Martinsos I added a section on the Dummy provider to the Auth section of the "Guided Tour".
SKIP_EMAIL_VERIFICATION_IN_DEV=true has been removed from the template but remains in .github/workflows/e2e-tests.yml so that it's available to the tests in the latest commit 2c94ced

Ok sweet! However a question: will e2e tests work locally then? Who sets that env var for them in that situation?
I am reopening issue to make sure we cover this question as it might be a potential problem.

Ok, this leaves us with one thing left to resolve in this issue: do e2e tests work ok locally now, in the sense that the email verification is skipped? If yes, we can close it, if not, let's fix that.

@Martinsos to make sure e2e tests work locally, I though it'd be best to just instruct users to change their development env vars to suit the tests --> https://github.com/wasp-lang/open-saas/pull/184

@vincanger but that means they need to add that when running e2e tests and then again remove it when not running them? That sounds very cumbersome. Can't we instead just specify in the e2e tests themselves this env vars is set? I thought we had a mechanism for that? Right now you sepcified it for CI -> but let's sepcify it for e2e tests so it happens regardless of CI or not. That way we solved it. And you can then remove it from the CI.

@Martinsos because we run the wasp app in a separate session than the e2e-tests, we have to set the env var before starting the wasp app. I could tell users to run SKIP_EMAIL_VERIFICATION_IN_DEV=true && wasp start in the README, before running the e2e tests locally. Besides that, I'm not sure how else to go about setting this dynamically when running local e2e tests.

@vincanger I forgot a bit about how e2e tests are run locally, my bad! Yeah ok, I remember now that we did it this way due to different issues we had on CI vs local side. While this sounds like ideally we would need to refactor this once and for all properly, to have a single command that runs both app and tests, in the meantime, while we don't have that, the only solution is what you said: tell them, in README, that when starting web app, they need to set their env var, so SKIP_EMAIL_VERIFICATION_IN_DEV=true wasp start in the README. That is how it is right now, so that is what we need to add. In the future I hope we improve those e2e tests so they can be run in a better way.


Julia package?

Is this a Julia package? If so it should be OceanMultigrid.jl.

Yes. My bad...
How about MultigridOceanSolvers.jl?


facerec_from_webcam_faster.py

face_recognition version:1.2.1
Python version:2.7
Operating System:macOS

Description
I tried to run example facerec_from_webcam_faster.py,but when I set up a few people's heads,No matter who appears in the camera, the matching result is [False,True].Can you help me to answer it?

I've found that I get fewer false positives by bumping that down to 0.5.


whats the point of..

having multiple OneOrMany<string,SomeComplex> Width
but single value Category ?

Not sure I completely understand.
Schema.org lets you include N number of items for each property. It's a very loose standard. This is what OneOrMany lets you do but limits it to certain concrete types as defined by schema.org.

Feel free to reopen if you have more to add.


[HOLD for payment 2023-07-26] IOU - Money request header is not greyed out in offline mode

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Issue found when executing PR https://github.com/Expensify/App/pull/21918
Action Performed:

Go to staging.new.expensify.com
Disconnect network
Click + > Request money > Enter amount > Select contact > Submit
Click on the payment request in the new DM

Expected Result:
Money request header is greyed out
Actual Result:
Money request header is not greyed out
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: <IP_ADDRESS>
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/78819774/ffa0c647-b7f3-43be-bda4-806e0294b33a

Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

This is caused by https://github.com/Expensify/App/pull/21918#issuecomment-1630672820

Also I don't think this is a deploy blocker

Agreed, removing the label

Not overdue

Not overdue

Not overdue

@aimane-chnaif we can close this out right? Since it's not a new issue, but one that stems from the PR for the other issue there's not payment to make right?


Add support for other servers in Movies/TV Show

Current server is Vidsrc / Vidplay, is having few broken links. Find some better alternatives and add support to choose between them.

Yes, this site looks too good to be true (https://www.braflix.video/). I could find everything even newly released ones 😅. But I could not play any movie, not sure if it is blocked in my network.

Hopefully it won't go down after a couple of days 😅. Also, I noticed that it is going down occasionally.

Closing this as completed.


tests: gdbstub: simple test

Gdbstub test with Twister pytest plugin:

clone samples/subsys/debug/gdbstub to tests and convert it back to a build-only sample aligned with documentation.
some improvements with pytest fixtures, parametrization, and expected pattern matching on outputs from GDB and the test application.

as suggested at https://github.com/zephyrproject-rtos/zephyr/pull/63472#pullrequestreview-1660080073
and follows #63061

@gchwier  @gopiotr  @PerMac  please review

looks good overall, just a few comments and clarifying questions.

@nashif could you please look again after the changes done here.


Fixing the name of the repository

Fixing the name of the repository

Well spotted, @andreipope - many thanks for the correction!


 SUCCESS [  0.337 s]
[INFO] Vavr Match ......................................... SUCCESS [  2.085 s]
[INFO] Vavr ............................................... FAILURE [ 11.749 s]
[INFO] Vavr Benchmark ..................................... SKIPPED
[INFO] Vavr Test .......................................... SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 14.308 s
[INFO] Finished at: 2017-10-23T11:15:34+03:00
[INFO] Final Memory: 34M/517M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal net.alchim31.maven:scala-maven-plugin:3.3.1:script (default) on project vavr: wrap: java.lang.Exception: A NoSuchMethodError exception was thrown: scala.Predef$.refArrayOps([Ljava/lang/Object;)[Ljava/lang/Object; -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn <goals> -rf :vavr

Thanks, see #2141

Hi @yegor256, are you on Windows?  Currently I can’t reproduce it on a Mac. I’m searching the reason - something must have been changed, it worked before.
Most probably the scala-maven-plugin (used by our code generator) has a classpath that contains two different Scala versions. I will check that.

I think @tmtron found the origin of the issue. We use another Scala version in the same classpath for our benchmarks. The workaround is to use an older Scala version (see link above). We will fix the multi-project configuration.


Each new BEAM instance always gives the same sequence of values. How to prevent this?

@jj1bdx Hi,
Please each new BEAM instance always gives the same sequence of random values for exs64:uniform(N).
How can I prevent this?
Example:
uniform(900000) always gives same sequence: 114849, 855038, 232204, 496223, ...
Thanks.

If you are using 18.x, try rand:uniform/1 instead; rand:uniform/1 initializes with a set of monotonic time values when it is called for the first time after the BEAM is initialized. You can choose exs64 in the rand module, though the default algorithm is exsplus (or exsplus116), which is as good as exs64 for most purposes.
If you are using 17.x or earlier, always call the seeding function as follows before using the function:
<<A:32, B:32, C:32>> = crypto:rand_bytes(12), exs64:seed(A, B, C)

Thanks!
Yes i'm using R18. i had not realized that your work has become part of OTP, until i just watched your video from Erlang Factory SF 2015

@jj1bdx
Please I am trying to build a token system that issues unique random 6-digit codes. Each code has a life-span of 3mins after which it may be reused. Codes range from<PHONE_NUMBER>99 i.e. 900,000 possible codes.
Problems: I always have some collisions, and the more tokens issued the higher the collisions.
Iex(1)> Enum.uniq(for a<- 1..100000,do: :rand.uniform(900000)) |> length
94693

Is there a way to skew the random function such that it ignores previously issues values?
I have tried to use a Map to store already assigned values, but that is very slow, as i need to do a lookup each time before i can find a token that has not been used. I even need multiple lookups to find a free token, as more tokens are issued.
How would such a solution run effectively on multiple nodes, so  that one users request to generate a token will not block another concurrent user - and each is guaranteed to have a unique token?
My idea:
Run N BEAM instances, each handling 1/N of the Token range.
Use a router to decide which instance handles next request,  using request_count rem N as my routing function

Issue closed.


FancyZones: Fix Window Resizing when Connecting to Hyper-V VM

📝 Provide a description of the new feature
When connecting to a Hyper-V VM by going to the Hyper-V Manager, right clicking on a VM, and selecting "Connect", the vmconnect.exe application will launch with a GUI interface to the VM. After logging into my VM, if I try and use FancyZones to snap the VM's window to a zone, the window resizes but the VM's resolution stays the same.
For example, in the following screenshot, you can see that the VM's display is smaller than the window size (the window size was changed by FancyZones, but the VM's viewport stayed the same):

If you'd like to see this feature implemented, add a 👍 reaction to this post.

Duplicate: #4336


Crate Issue for Itertools 0.4.11 for Rust 1.0 & 1.1

Running travis builds here and seem to see an issue for itertools. Is there some breaking change that prevents 1.0 & 1.1 from working with the new version? It seems to work fine for rustc > 1.1
 Downloading itertools v0.4.11
Unable to get packages from source
Caused by:
  failed to parse manifest at `/home/travis/.cargo/registry/src/github.com-1ecc6299db9ec823/itertools-0.4.11/Cargo.toml`
Caused by:
  expected a value of type `string` for the key `lib.name`

itertools has required Rust 1.1 since version 0.4.2, and Rust 1.2 since 0.4.11. The bump is not in the changelog, but the README was updated to say requires Rust 1.2+. See this commit https://github.com/bluss/rust-itertools/commit/7541e7c1f13d302a1d07a2b654fef78fcc65146f

The error you are citing was probably caused by https://github.com/bluss/rust-itertools/commit/89a2d3146a3513ab8a70012be574abd408cb6b49

Fair enough. I will update my project requirements.


Added rest api

New feature:

Serializes talks and publications objects currently (can add more objects to the serializer if necessary)
Allows for POST and GET requests to the api
Displays the data in a readable manner

API form

JSON form

All changes suggested have been made.

Oops. Looks like you want to take out the import python code here so that there is clean separation in PRs as discussed.
Sent from my iPhone

On Aug 3, 2018, at 12:05 PM, johnsonkuang<EMAIL_ADDRESS>wrote:
All changes suggested have been made.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

changes made.

changes made, please merge. Thank you.


ref(component-annotate): Use default export

I know, default exports bad, but we don't have much of a choice here. Babel expects our plugin to be using a default export, or else it will not be able to resolve the plugin when using its string identifier in the config (@sentry/babel-plugin-component-annotate)
See this in Babel's source for reference:
https://github.com/babel/babel/blob/main/packages/babel-core/src/config/config-descriptors.ts#L335

Good idea, added a comment 👍


detektCheck starts failing - Was passed main parameter '--output' but no main parameter was defined in your arg class

Just started getting the following error when running ./gradlew detektCheck with no changes to the source or environment:
Was passed main parameter '--output' but no main parameter was defined in your arg class

Usage: detekt [options]
  Options:
    --baseline, -b
      If a baseline xml file is passed in, only new code smells not in the
      baseline are printed in the console.
    --config, -c
      Path to the config file (path/to/config.yml). Multiple configuration
      files can be specified with ',' or ';' as separator.
    --config-resource, -cr
      Path to the config resource on detekt's classpath (path/to/config.yml).
    --create-baseline, -cb
      Treats current analysis findings as a smell baseline for future detekt
      runs.
      Default: false
    --debug
      Prints extra information about configurations and extensions.
      Default: false
    --disable-default-rulesets, -dd
      Disables default rule sets.
      Default: false
    --filters, -f
      Path filters defined through regex with separator ';' (".*test.*").
    --generate-config, -gc
      Export default config to default-detekt-config.yml.
      Default: false
    --help, -h
      Shows the usage.
  * --input, -i
      Input paths to analyze.
    --parallel
      Enables parallel compilation of source files. Should only be used if the
      analyzing project has more than ~200 kotlin files.
      Default: false
    --plugins, -p
      Extra paths to plugin jars separated by ',' or ';'.
    --print-ast
      Prints the AST for given [input] file. Must be no directory.
      Default: false
    --report, -r
      Generates a report for given 'report-id' and stores it on given 'path'.
      Entry should consist of: [report-id:path-to-store-report]+
    --run-rule
      Specify a rule by [RuleSet:Rule] pattern and run it on input.

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':app:detektCheck'.
> Process 'command '/Library/Java/JavaVirtualMachines/jdk1.8.0_66.jdk/Contents/Home/bin/java'' finished with non-zero exit value 255

Version: 1.0.0.RC8 (same with RC9)
This happens both locally (macOS) and on CI .
The same CI build was passing a week ago and only started failing with the above error as I re-run, and I really don't understand what could have changed that leads to this error.

In your detekt config in your build.gradle file, do you specify toolVersion?
If not try setting it to the same version that you also use for the Detekt Gradle Plugin.
If you don't specify toolVersion below RC9 it will always pick the latest version and due to breaking changes in RC9 this could cause the problem you're describing.

Thanks. Adding version to detekt config fixes the issue with RC8.

How do I add the tool version it using Gradle Task?

You can't. For a gradle task you have to specify the right detekt-cli version and call the Main class of it. No need to specify a toolVersion.

I'm facing the same issue with my project when upgrading to RC9. If I return it to RC8, it works. This is my detekt.gradle file.

Hey, please read the migration guide here: https://arturbosch.github.io/detekt/changelog.html#rc9
It now mentions that --output was removed and --report [id:path] is now the new default reporting option.
E.g.: java --jar detekt.jar --input . --report xml:./reports/detekt.xml

Thanks, it worked adding the new format.

Please, refer to the configuration file in my project:
https://github.com/igorescodro/alkaa/blob/master/config/quality/detekt.gradle


nit: Segment length is given in ISO8601 duration

"For example, if segmentLength is set to 300, then the module will accumulate 5 minutes worth of video..."
This case the user can use PT5M, there is really no need to say 300...

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9f0b865c-299f-a496-a1a7-1eaaeddcfdc8
Version Independent ID: a94a1a36-b873-a51e-2256-8cbd74364c3d
Content: Playback of recordings - Azure - Live Video Analytics on IoT Edge
Content Source: articles/media-services/live-video-analytics-edge/playback-recordings-how-to.md
Service: media-services
GitHub Login: @Juliako
Microsoft Alias: juliako

@rodrigb Thank you for pointing out this detail and making the suggestion. This is being evaluated where an enhancement to the document will be made as appropriate.

@Juliako, Requesting your comments on this.

@AjayKumar-MSFT , can you please reassign the issue to the current AMS writer, @IngridAtMicrosoft

#please-close


Pechakucha

make a checklist

what story will you tell with your pechakucha?

my experience during the  TD program


Add more exporters to bash_bench

Codecov Report
Attention: Patch coverage is 67.18147% with 170 lines in your changes missing coverage. Please review.

Project coverage is 77.83%. Comparing base (7b39274) to head (ffba88c).

Files
Patch %
Lines

...ental_experiment/torch_bench/_bash_bench_common.py
58.10%
137 Missing :warning:

...al_experiment/torch_interpreter/_aten_functions.py
87.65%
10 Missing :warning:

experimental_experiment/xbuilder/graph_builder.py
70.83%
7 Missing :warning:

...rimental_experiment/xbuilder/shape_type_compute.py
76.19%
5 Missing :warning:

...l_experiment/torch_bench/_bash_bench_common_cmd.py
73.33%
4 Missing :warning:

experimental_experiment/bench_run.py
92.50%
3 Missing :warning:

...erimental_experiment/torch_dynamo/debug_backend.py
0.00%
2 Missing :warning:

...ntal_experiment/torch_bench/export_model_helper.py
50.00%
1 Missing :warning:

...mental_experiment/torch_interpreter/interpreter.py
0.00%
1 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #178      +/-   ##
==========================================
+ Coverage   77.76%   77.83%   +0.06%
==========================================
  Files         125      125
  Lines       15020    15449     +429
==========================================
+ Hits        11680    12024     +344
- Misses       3340     3425      +85

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


improve code coverage for UserGroupCheck

The check_user_group.go source file should be at 100% coverage after this.

Codecov Report

Merging #168 into master will increase coverage by 1.36%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master    #168      +/-   ##
=========================================
+ Coverage   86.33%   87.7%   +1.36%
=========================================
  Files          20      20
  Lines         732     732
=========================================
+ Hits          632     642      +10
+ Misses         99      89      -10
  Partials        1       1

Impacted Files
Coverage Δ

lib/app/nagiosfoundation/check_user_group.go
100% <0%> (+12.98%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 414f412...0e24036. Read the comment docs.


api: server: credentials_linux: fix wrong uid parsing (rhel7-1.10.3)

Same as https://github.com/projectatomic/docker/pull/87 but for the rhel7-1.10.3 branch (fedora branch already has this, found in https://bugzilla.redhat.com/show_bug.cgi?id=1328204#c4)
solves those logs:
Mar 23 15:46:57 localhost.localdomain docker[30043]:
time="2016-03-23T15:46:57.097702190+01:00" level=error msg="Failed to
get pwuid struct: strconv.ParseInt: parsing "橌": invalid syntax"
Failed to get pwuid struct: strconv.ParseInt: parsing "Ϩ": invalid
syntax
Signed-off-by: Antonio Murdaca<EMAIL_ADDRESS>

@rhatdan @mrunalp PTAL

LGTM


Add unit tests

Add unit tests for Mode and estimate_co2 function.
Closes #8

Great start, just two thoughts:

I think it's better to have the tests in their own dir. As it is, the tests would also be installed with the library, which is not necessary.
The float values comparison is likely to fail with a different architecture or implementation. We should use a numerical close function with a given precision. I'm sure numpy has such functionality.

I think it's better to have the tests in their own dir. As it is, the tests would also be installed with the library, which is not necessary.

I moved the tests to a tests subfolder in the package directory. It seems the tests should be ignored when publishing the package due to this line in setup.py:
https://github.com/maasglobal/sustainable-mobility-api/blob/8446b4810a5c6e7971be6c69613ced6cd7e15516/estimator/setup.py#L130

The float values comparison is likely to fail with a different architecture or implementation. We should use a numerical close function with a given precision.

I added pytest.approx to all numerical comparisons.

@MarkusShepherd should we add another wildcard to the exclude list?

"tests", ".tests", ".tests.", "tests."

E.g. would we need to add *tests? Also, should we be adding this to manifest.in?
https://packaging.python.org/guides/using-manifest-in/

@MarkusShepherd should we add another wildcard to the exclude list?

"tests", ".tests", ".tests.", "tests."

E.g. would we need to add *tests? Also, should we be adding this to manifest.in?
https://packaging.python.org/guides/using-manifest-in/

Ah, from what I understand, we want to include the tests in the package, but not in the installed module (which makes sense). I think it is doing the right thing now. An alternative school would be to have estimator.tests.py etc as siblings of estimator.py etc. I don't mind either way. 😉

An alternative school would be to have estimator.tests.py etc as siblings of estimator.py etc. I don't mind either way.

Let's keep it as is for now.

It might also be worth adding a small section to the README, even if it just reads "run pytest for unittesting".

Done.


mimic the infra-container ttl

Relevant information
As we agreed, containers will live unreported for the same TTL as infra-containers (4 hours)
Checklist

[ ] I've read the guidelines and understand the acceptance criteria.
[ ] The value of the attribute marked as identifier will be unique and valid.
[ ] I've confirmed that my entity type wasn't already defined. If it is I'm providing an
explanation above.

dup of https://github.com/newrelic/entity-definitions/pull/1036


Add Goodreads QOTD and Hitokoto API

已进入强迫症阶段，说明差不多好了 :-)

Looks good!

Thanks very much, you taught me so much! @apsun

@Yubyf How would you like to be credited? Is a link to your GitHub profile fine?

Yes, it's OK. And thx again.


Is there a way to set a keyboard type to UIKeyboardTypeTwitter

I'm building an app where I need to have the "hashtag" key accessible directly when the keyboard is open (think twitter or instagram). I know that - in objectiveC - it's something along the line of UIKeyboardTypeTwitter

:+1:  – I'd really like to see this supported as well.

+1

+1


capturePromise needs to be called in handler middleware in Lambda

I have the following setup where helloHandler does some async calls using Axios:
import express from "express";
import serverless from "serverless-http";
import AWSXRay from "aws-xray-sdk-core";
import xrayExpress from "aws-xray-sdk-express";
import http from "http";
import https from "https";

AWSXRay.captureHTTPsGlobal(http);
AWSXRay.captureHTTPsGlobal(https);
AWSXRay.capturePromise();

import helloHandler from "./helloHandler";

const app = express();

app.use(xrayExpress.openSegment("my-app"));

app.use("/hello", helloHandler);

app.use(xrayExpress.closeSegment());

export default serverless(app);

When I run this in Lambda, I see many Error: Missing AWS Lambda trace data for X-Ray. Ensure Active Tracing is enabled and no subsegments are created outside the function handler errors in CloudWatch. However, with the following setup, I don't get these errors:
import express from "express";
import serverless from "serverless-http";
import AWSXRay from "aws-xray-sdk-core";
import xrayExpress from "aws-xray-sdk-express";
import http from "http";
import https from "https";

AWSXRay.captureHTTPsGlobal(http);
AWSXRay.captureHTTPsGlobal(https);

import helloHandler from "./helloHandler";

const app = express();

app.use((req, res, next) => {
  AWSXRay.capturePromise();
  next();
});

app.use(xrayExpress.openSegment("my-app"));

app.use("/hello", helloHandler);

app.use(xrayExpress.closeSegment());

export default serverless(app);

Is that expected? Why does capturePromise have to be called in the handler?

Hi @cloudlena ,
In Lambda, the X-Ray SDK will only create subsegments, which will all be attached to the segment generated by Lambda. Any subsegment that exists outside the Lambda handler will cause the error you saw and that's the reason why the second instrumentation code works.

Thanks, @lupengamzn!


Update config.py

A very special failure case where a container has other environment variables that start with RASA and doesn't have an "_". The server fails to start.
Hope fully this helps.
Proposed changes:

Modified the lookup to RASA_ instead of RASA under the environment variables.

Status (please check what you already did):

[x] made PR ready for code review
[ ] added some tests for the functionality (N/A)
[ ] updated the documentation (N/A)
[ ] updated the changelog (N/A)

Good point, thanks for fixing this :+1:


Getting into issues when running testpmd for dpdk

Issue while running testpmd
$ sudo testpmd -l 0-5   -w 0000:02:01.0 --
EAL: Detected 24 lcore(s)
EAL: Detected 1 NUMA nodes
EAL: Multi-process socket /var/run/dpdk/rte/mp_socket
EAL: Selected IOVA mode 'PA'
EAL: No available hugepages reported in hugepages-2048kB
EAL: Probing VFIO support...
EAL: PCI device 0000:02:01.0 on NUMA socket -1
EAL:   Invalid NUMA socket, default to 0
EAL:   probe driver: 8086:154c net_i40e_vf
testpmd: No probed ethernet devices
testpmd: create a new mbuf pool <mbuf_pool_socket_0>: n=187456, size=2176, socket=0
testpmd: preferred mempool ops selected: ring_mp_mc
Done
Getting Invalid NUMA socket, default to 0. and seeing testpmd: No probed ethernet devices
It blocks my testing

@geetikakay is this still an issue for you?
In the testpmd log, it indicates that there is no available hugepages and i40evf device is not probed.

@zshi-redhat  Yeah still seeing it not sure what triggers this problem.Could be setup issues but looking for pointers to debug it.
Thanks

Hi @geetikakay.
If it's a sriov-device-plugin issue, please attach the version of Device Plugin, Multus (or other) and SR-IOV CNI you're using as well as the configMaps, network-attachment-definitions and pod definition.
Other things to check:

Your pod has the right permissions
Your pod has access to hugepages
You have bound the right driver to the VF (dpdk-devbind -s can help you there)

@amorenoz Hello ..
I have configured hugepages in my VM .
I have set it under:
$ cat /etc/default/grub
GRUB_TIMEOUT=1
GRUB_DISTRIBUTOR="$(sed 's, release .*$,,g' /etc/system-release)"
GRUB_DEFAULT=saved
GRUB_DISABLE_SUBMENU=true
GRUB_TERMINAL_OUTPUT="console"
GRUB_CMDLINE_LINUX="no_timer_check net.ifnames=0 console=tty1 console=ttyS0,115200n8 default_hugepagesz=1GB hugepagesz=1G hugepages=2"
GRUB_DISABLE_RECOVERY="true"
GRUB_ENABLE_BLSCFG=true
$ dpdk-devbind -s
Network devices using kernel driver
0000:02:01.0 'Ethernet Virtual Function 700 Series 154c' if=eth0 drv=iavf unused= Active
0000:03:00.0 'Virtio network device 1041' if=eth1 drv=virtio-pci unused= Active
No 'Baseband' devices detected
No 'Crypto' devices detected
No 'Eventdev' devices detected
No 'Mempool' devices detected
No 'Compress' devices detected
No 'Misc (rawdev)' devices detected

This issue is not related to the Device Plugin so @zshi-redhat: you can close this one.
I'll help @geetikakay offline.

closing per Adrian's comment above.


DLL Versioning

It looks like the DLL in the MonoAndroid10 folder is versioned to 3.0.2 but all the others are <IP_ADDRESS>
Is this expected? I think it is the cause for some build warnings because I built a .net standard 2.0 dll and then use it in my Xamarin Android project and I get conflicting version warnings.
Is this expected, can someone comment on it? Thanks!

Hmmmm... The abstractions are <IP_ADDRESS>? Probably because of .net standard format....

This could be naivety on my part (very good odds), but I will basically explain what's happening. I have an Android 8.0 (oreo) project, and .NET Standard 2.0 targeted project in my solution. When I install the Media plugin it puts the monoandroid10 medial plugin dll in my android project and the .net standard  media plugin dll in my net standard project.
Then, when I build my .net standard project and add my built dll as a reference inside in the android project I get the conflict, saying my .net standard dll version conflicts with the monoandroid10 version referenced in the android project.
My understanding is that using Xamarin and targeting android 8.0 supports .net standard, so shouldn't the .net standard media plugin dll be added to the references of the android project, and not the monoandroid10 dll? The only other thing that led me down that path is that newtonsoft.json doesn't have a monoandroid build anymore, the nuget installation just puts the .net standard dll in the android project as a reference.

There are 2 dlls:
Plugin.Media.Abstractions.dll -> both .NET Standard + Android
Plugin.Media.dll -> Only Android

i think i figure out what is going on and can fix on the build server.

Awesome, thanks very much! Mind giving a little more detail for inquiring minds when you have a chance? No rush.

<IP_ADDRESS>-beta
Give that a go.
Yeah, so:... Appveyor I have it turned on to update the assembly info... however .NET Standard Libraries don't have this stuff as it is in the .csproj. So since they dont' have auto tooling you have to do it manually in the powershell script such as:
$newVersion = $env:APPVEYOR_BUILD_VERSION.Replace("-beta","")
$configFiles = Get-ChildItem . *.csproj -rec
$assemblyVersionString = "<AssemblyVersion>" + $newVersion + "</AssemblyVersion>"
$assemblyFileVersionString = "<AssemblyFileVersion>" + $newVersion + "</AssemblyFileVersion>"
$versionString = "<Version>" + $newVersion + "</Version>"
foreach ($file in $configFiles)
{
    (Get-Content $file.PSPath) |
    Foreach-Object { $_ -replace "<AssemblyVersion><IP_ADDRESS></AssemblyVersion>", $assemblyVersionString  } |
    Set-Content $file.PSPath
}

foreach ($file in $configFiles)
{
    (Get-Content $file.PSPath) |
    Foreach-Object { $_ -replace "<AssemblyFileVersion><IP_ADDRESS></AssemblyFileVersion>", $assemblyFileVersionString  } |
    Set-Content $file.PSPath
}

foreach ($file in $configFiles)
{
    (Get-Content $file.PSPath) |
    Foreach-Object { $_ -replace "<Version><IP_ADDRESS></Version>", $versionString  } |
    Set-Content $file.PSPath
}

Thanks!


Evaluate exported .joint object detection model on COCO

I want to run inference on my exported INT8 .joint model locally (on my laptop). The idea here is to evaluate its mAP performance. I only see one way of doing this:
pulsar run\
    my_model.joint\
    --input resnet18_export_data/images/cat.jpg\
    --output_gt inference_results

And then read the generated .npy file. I want to avoid reading/writing from file during evaluation as it is a very time consuming operation. Is there a way of running inference using python? I don't see anybody wanting to deploy a model without knowing its performance... How do you calculated the performance of your exported INT8 .joint models?

Simulation running speed is very slow, we usually only run one picture to test on X86. Accuracy evaluation such as mAP?  We all with do it on the board.

Could you provide INT8 model COCO results so that people know what level of performance degradation is to be expected on the quantized models @BUG1989 ?


Track LightInstance::shadow_atlases so that it will be freed properly

This will fix the issues https://github.com/godotengine/godot/issues/11848 (the second issuse (endless error message on scene change) of two issues reported there) and its duplicate https://github.com/godotengine/godot/issues/10346.
My observation on this issue is as follows.
LightInstance::shadow_atlases is supposed to be freed from RasterizerSceneGLES3::free(RID p_rid), but currently it turns out nothing is added to the Set data structure light_instance->shadow_atlases. So what I changed in this commit is adding light_instance->shadow_atlases.insert(...) where it seems appropriate, which is after successful RasterizerSceneGLES3::_shadow_atlas_find_shadow.

seems fine to me


support to upload files through via this module

wrapper for Directus SDK directus.files.createOne
Have you any function for this SDK function?
Thanks.

If you are referring to the nuxt-directus-next module then it is based on the NEW SDK, so syntax is a bit different, and yes we do have a function to directly upload files via:
const { uploadFiles } = useDirectusFiles()

const formData = new FormData()
formData.append('file_1_property', 'Value')
formData.append('file', raw_file)
formData.append('file_2_property', 'Value')
formData.append('file', raw_file_2)

const result = await uploadFiles(formData)

or via link:
const { importFile } = useDirectusFiles()

const result = await importFile(file_url, file_object)

Be aware that nuxt-directus-next is still being finalized and not yet fully stable, so if you do find any issue while implementing the code above feel free to reopen this issue by providing a reproduction link to a git repo or stackblitz.


ESP32 hwSPI = false will be cause panic

Hello,
I found that in device ESP32 the function:
ILI9341_SPI::ILI9341_SPI(int8_t cs, int8_t dc, int8_t mosi,
int8_t sclk, int8_t rst, int8_t miso) : DisplayDriver(ILI9341_TFTWIDTH, ILI9341_TFTHEIGHT) {
The var "hwSPI = false" will cause kernel guru panic in SPI init.
In ESP8266 works in both SPI modes hwSPI true or false.
Please analise it.
Thank you.

Hi,
I'd like to do some animation on the TFT screen, so I am very interested in your frame buffering solution.
I am also having issues running your examples on an ESP32. While trying to run your BasicDrawing example, I got the error, "Guru Meditation Error: Core  1 panic'ed (LoadProhibited). Exception was unhandled." I'm using an ILI9341 TFT on the HSPI pins, so I init'd with:
ILI9341_SPI tft = ILI9341_SPI(TFT_CS, TFT_DC,13,14,4,12);
I got these results from decoding the backtrace with the ESP Exception Decoder tool:
0x400d2f98: spiWriteNL at \Arduino15\packages\esp32\hardware\esp32\1.0.0\cores\esp32\esp32-hal-spi.c line 861
0x400d0f3e: SPIClass::writeBytes(unsigned char*, unsigned int) at \Arduino15\packages\esp32\hardware\esp32\1.0.0\libraries\SPI\src\SPI.cpp line 213
0x400d15dd: ILI9341_SPI::writeBuffer(unsigned char*, unsigned char, unsigned short*, unsigned short, unsigned short, unsigned short, unsigned short) at \Arduino\libraries\minigrafx-master\src\ILI9341_SPI.cpp line 436
0x400e9b19: MiniGrafx::commit(unsigned short, unsigned short) at \Arduino\libraries\minigrafx-master\src\MiniGrafx.cpp line 573
0x400d0bb7: setup() at \Temp\arduino_modified_sketch_316460/BasicDrawing.ino line 76
0x400e8c37: loopTask(void*) at \Arduino15\packages\esp32\hardware\esp32\1.0.0\cores\esp32\main.cpp line 15
I've successfully run the Adafruit IL9341 library with this setup, so I've confirmed the wiring is correct. However, when I run your example, the screen just flashes between a white background and grey/black stripes. Can you offer any insight?
Thanks


Updates botocore to latest master.

Latest master as of 9/20/16.

We've got some work to do on this to get it to compile!


Teleport Animation conflicting with Tombs of Amascut's crystal scarabs

When activating a crystal scarab, I guess the plugin thinks you're using a teletab as both use the same animation. This results in the chosen teleport animation playing (in my case Darkness Ascends), the player disappearing, and the camera being locked to the position it was before activating the item. The player can still move around and do stuff, but it's incredibly disorienting.

Wow, well that's no good! Thanks for letting me know, I will take a look at it here soon to try and differentiate between the crystal scarabs and teleporting.

This issue should be resolved with the latest update https://github.com/ArtimosPenguidor/animation-transmog/commit/d3bd75aea96ff18c6947a4c19452724dfa3085d8
This essentially disables the plugin in certain regions, like ToA. It's the only good way to go about this since the crystal scarab uses the same exact animation as a teletab and the plugin can't distinguish the two.
I'll close the issue once the new update has been released in Runelite.
Thanks!
Nick


chore: rename python install force parameter

Closes #4961
Summary
Rename the --force parameter of uv python install to --reinstall

@zanieb there's this test failing which I'm not sure it's related to my changes


Synology App hangs

I have followed the instructions to the letter, using a Synology DS1019+ Running the Latest official release firmware.
It hangs on the
DungeonDB Start 182 | stdout
After that it does another debug step but never continues. I can see it has created the world files, and the start_server.sh file is present as well as the adminlist, bannedlist, and permittedlist, and a prefs file. it just neter continues. even after letting it sit there for 30 minutes.

That sounds correct. DungeonDB Start is the last message the server will output after startup. This means the server is ready to accept connections. Once you connect to the server there will be more log messages.


Support higher Unicode ranges for Char.fromCode

> Char.fromCode 0x1F0A1 == Char.fromCode 0xF0A1
True : Bool

> Char.fromCode 0x1F0A1
'' : Char

> Char.fromCode 0xF0A1
'' : Char

I'm trying 0x1F0A1 = 🂡, I'm getting 0xF0A1 = .
That's because Elm uses JavaScript's String.fromCharCode which doesn't support higher Unicode ranges.
To mitigate that, String.fromCodePoint should be used.

As a sidenote, maybe toCode could be also updated to use String.codePointAt instead of String.charCodeAt?

Unfortunately String.fromCodePoint isn't well supported by browsers so it would need to be polyfilled. Even a low-level polyfill of this function is a lot slower than the native, as demonstrated by the benchmark below
http://jsbin.com/taraguwaja/1/edit?js,console

Fixed in https://github.com/elm-lang/core/commit/bf16ca8a10f29e271d61ca463a1268232e97ac79 with an implementation that is cross-browser and should be reasonably fast. In the BMP, it usually adds on conditional check.
@lukewestby, most polyfills have lots of code to handle all the bad data that could be passed in. What does .codePointAt do on objects? On arrays? Etc. In this case I just learned a lot about UTF-16 for some recent parser work, and it turns out that it's not so hard to sort out. I used the formulas from here for surrogate pairs.


KUJI throws internal error

Hi,
I tried two addresses, but they seem to just go from generating estimate to internal error. I check back in a few days it still says the internal error and eventually stops at 97%

Hi, I have the same issue, but already at 4%.
Tried Brave Browser, Chrome and Firefox...

Not a replacement nor perfect but I built a small tool if you end to test it to pull transactions out.-  https://kuji-csv-downloader-kersch.replit.app/

Unable to find suitable kujira node, after removal of deprecated kujira archive node.

https://chainsco.pe/ runs one still (https://discord.gg/rQ3JKcZK) unsure how long though. I also struggled to find one - thus took down my replit :/


feat: Shorten outputs (removing this_)

v5.0.0 has been just released.
PS: @bryantbiggs you started it :)


Unexpected token error at code with optional chaining when using Typescript

UPD for everyone who will find this issue. For fix this error acornjs/acorn#891 and acornjs/acorn#890 must be merged.
UPD2 we all awaiting while estree/estree/pull/204 will be merged
UPD3 fix for optional chaining landed into acorn 7.3.0 but webpack@4 uses acorn 6.x. so fix of this issue will be in webpack@5: https://github.com/webpack/webpack/issues/10227#issuecomment-642734920
Temporary fixes
For Babel
Add @babel/plugin-proposal-optional-chaining and @babel/plugin-proposal-nullish-coalescing-operator plugins in your config
For Typescript
Do not upgrade to version 3.8 or set compiler option target to es2019
Yarn/NPM level
See the https://github.com/webpack/webpack/issues/10227#issuecomment-698662228

Do you want to request a feature or report a bug?
I don't know is it a bug or feature
What is the current behavior?

Build bundle successfull
Description
When I set in tsconfig.json target: "ESNext" TS keeps my code with optional chaining (and nullish coalescing)  as is. But I've got an error
Module parse failed: Unexpected token (2:10)
File was processed with these loaders:
 * ./node_modules/ts-loader/index.js
You may need an additional loader to handle the result of these loaders.
| var a = { b: 2 };
> var c = a?.b;

I made a minimum reproduce repo inoyakaigor/webpack-typescript-optional-chaining
How I can avoid this error?

It looks like you just deleted our lovely crafted issue template. It was there for good reasons. Please help us solving your issue by answering the questions asked in this template. I'm closing this. Please either update the issue with the template and reopen, or open a new issue.

@evilebottnawi Closing the issue because I removed the template looks like excessive bureaucracy.
However, I updated the description.

For others that stumble on this issue, it looks like we're waiting on https://github.com/acornjs/acorn/pull/891 and https://github.com/acornjs/acorn/pull/890 before we stop transpiling this syntax via babel/tsc.

it looks like the mentioned issues on acorn have been merged, any news?

@evilebottnawi Can we reopen this issue? Since this is a unresolved problem, it will help people find answers and let people track the progress.

Good news everyone! Acorn 7.3.0 with optional chaining support just released 2 hours ago!

Unfortunately webpack 4 uses acorn 6.x - not sure if we'll get this before webpack 5. Fingers crossed!

Yes, it will be part of webpack@5

I just tried to make a junction link (symbolic in terms of *nix OSes) ./node_modules/webpack/node_modules/acorn a junction link to ./node_modules/acorn and everything build ok.

as a temporary solution;
https://github.com/OnurGvnc/acorn-with-stage3
package.json:
{
  ...
  "resolutions": {
    "acorn": "npm:acorn-with-stage3"
  },
  "dependencies": {

as a temporary solution;
https://github.com/OnurGvnc/acorn-with-stage3
package.json:
{
  ...
  "resolutions": {
    "acorn": "npm:acorn-with-stage3"
  },
  "dependencies": {

Maybe I am missing something, but doing this did not fix the issue for me. I still get the same unexpected token at each use of optional chaining I have in my code.

Based on @sboisse temporary solution, in Yarn we just need resolution part,
"resolutions": {
    "acorn": "8.0.1"
},

After that, just run yarn install.

webpack uses acorn@8

Just the case, if we're using a library/loader that doesn't support webpack@5 yet.

It occurs that optional chaining won't be supported in Webpack 4, so the best course of action would be to update to Webpack 5 or use Babel for transpilation.

What's the status on this? Why is it closed?

I'm getting the same error-
Module parse failed: Unexpected token (363:46)
File was processed with these loaders:
  ./node_modules/ts-loader/index.js
You may need an additional loader to handle the result of these loaders.

tsconfig.json-

as a temporary solution;
https://github.com/OnurGvnc/acorn-with-stage3
package.json:
{
  ...
  "resolutions": {
    "acorn": "npm:acorn-with-stage3"
  },
  "dependencies": {

Originally posted by @OnurGvnc in https://github.com/webpack/webpack/issues/10227#issuecomment-653408484
Thanks it helped solve my problem. However my problem is weird because optional chaining is already supported in my own files, the only place it breaks is in a nested dependency I just added node_modules/xxxx/node_modules/yyyy. I'm still not sure why it happened.


Improve print output

Clarify and expand print output for the whole process

This was addressed partially in the version submitted for review in Bioinformatics.


Option function and default parameter is not executed

In source diving the arguments passed to command.option, it appears that it accepts a 3rd and 4th parameter for defining a function and default value for the option, but it appears that these aren't actually being executed. In this test case, I was unable to get a default value or have the function execute. Am I doing something wrong, or is this just not supported yet?
#! /usr/bin/env node

let Vorpal = require('vorpal');
let cli = new Vorpal();

cli
  .command('test')
  .description('A test')
  .option('--url <url>', 'Some url', function(val) { cli.log('VALUE!', value); }, 'http://some.url')
  .action(function(args, done) {
    this.log('URL:', args.options.url);
    done();
  });

cli.parse(process.argv);

$ ./cli test
URL: undefined

$ ./cli test --url other.url
URL: other.url

Haha - interesting find.
No, those aren't currently supported (what you find in the wiki is essentially what is supported), but it's funny it's there.
I copied a lot of the command logic originally out of TJ's Commander.js, and it looks like this may have been supported by him, and I never noticed.
Do you have need of this?

I do. I currently use the deprecated nomnom package which allows you to specify an option's default value if not specified, and also a function, which you can use for validation or transforming logic. I write a wrapper around nomnom to handle this, but that means having to duplicate the vorpal plugin logic, which I'd rather not do. It would be nice to switch from nomnom to Vorpal.

Okay cool. Could you do me a favor and detail the exact expected logic of the function? i.e. at what point in the action's lifecycle is it executed, etc.?

According to commander, it appears it is done during the parseOptions method:
https://github.com/tj/commander.js/blob/master/index.js#L690
which I assume maps to command._parseExpectedArgs, but that's just a cursory guess.

K I'll see if I can get to this soon.

Experimented with a patch, which seemed to work well with my test case:
let Vorpal = require('vorpal');
let cli = new Vorpal();

cli
  .find('exit')
  .description('Exits instance of Raptor');

let transform = function(val, defaultValue) {
  if (val && !val.startsWith('http')) {
    return 'http://' + val;
  }

  return val;
};

cli
  .command('test')
  .description('A test')
  .option('--url <url>', 'Some url', transform, 'http://some.url')
  .action(function(args, done) {
    this.log('URL:', args.options.url);
    done();
  });

cli.parse(process.argv);

./cli test
URL: http://some.url

./cli test --url github.com
URL: http://github.com

./cli test --url https://github.com
URL: https://github.com

diff --git a/lib/util.js b/lib/util.js
index e37309e..40693d7 100755
--- a/lib/util.js
+++ b/lib/util.js
@@ -191,15 +191,20 @@ var util = {
     // and throws help.
     for (var m = 0; m < cmd.options.length; ++m) {
       var o = cmd.options[m];
+      var name = o.name();
       var short = String(o.short || '').replace(/-/g, '');
       var long = String(o.long || '').replace(/--no-/g, '').replace(/-/g, '');
-      var exist = (parsedArgs[short] !== undefined) ? parsedArgs[short] : undefined;
-      exist = (exist === undefined && parsedArgs[long] !== undefined) ? parsedArgs[long] : exist;
-      if (exist === true && o.required !== 0) {
+      var value = parsedArgs[long || short] || cmd[name];
+
+      cmd.emit(name, value);
+      value = cmd[name];
+
+      var exist = value !== undefined;
+      if (exist === false && o.required !== 0) {
         return '\n  Missing required option. Showing Help:';
       }
-      if (exist !== undefined) {
-        args.options[long || short] = exist;
+      if (exist) {
+        args.options[long || short] = value;
       }
     }

Thoughts?

What's interesting about this approach is that the same function passed to .option could be used for validation as well. Maybe it could be sniffed to see if value instanceof Error, then return the error message instead of "missing required option". Just an idea.

+1 for being able to specify defaults!

@dthree any more thoughts on this? Just had this come up on another project that would be useful.


Fix #6319: Add support for --t: es5 and  --m es6

Fixes #6319.

@sheetalkamat any more comments?

👍

CC @Victorystick!

Woop! This is fantastic news! 🎉 In which stable version can we expect to see these changes?

Yey, great to see this feature! 🎉
@Victorystick The roadmap lists it underneath 2.0.

It was merged into master so I assume 1.9 though and testable in nightly 1.9.0-dev.20160610-1.0?

correct. today's build should have the fix. it should be shipped as part of the next release (TS 2.0).


Does not run on Dedicated servers due to client-side issues

2021-05-03-3.log.gz
Hey,
Can you look into dedicated server issues with this mod? I hope this log helps a bit...
And I hope it's the correct log.

that's the wrong log, search in your server folder

your version of Besmirchment was way out of date; BSM 1-2 are not compatbile with BW >=10, use BSM 4


Can we add react-bootstrap button in the column's cell of react-bootstrap-table2?

Can we add react-bootstrap button in the column's cell of react-bootstrap-table2?
I want my last column to have button for every row so how will we do it?
@AllenFang or anybody from your team if you can guys can help me with this as it is really important.
Thanks

I found the solution.

Can you provide the solution? @sakshivicesoftware

@Vitagliano you can use a formatter to achieve that result, I have an example here that uses it.


Improve Matching Functionality

Motivation
Fixes #38, #39, #40.
Solution
Return a new Match struct instead of *types.Operation from MatchOperations. This new struct allows for multiple *types.Operation to be matched with a given OperationDescription.

Pull Request Test Coverage Report for Build 1554

60 of 73 (82.19%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.1%) to 65.93%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

parser/match_operations.go
60
73
82.19%

Totals

Change from base Build 1501:
0.1%

Covered Lines:
1461

Relevant Lines:
2216

💛  - Coveralls


Lambda analyzer: get used names once

@DedSec256 Can't assign you as a reviewer, could you give it a look please? 🙂

@auduchinok, LGTM, thanks!


Some trouble when using phone-align method

Hi,
When I using phone-align label run train process, I had changed script/setup.sh from state-align to phone-align.
Do I need change something else? Cause the results are so unacceptable.

Are you using slt demo or your own data?
The [results] (https://github.com/CSTR-Edinburgh/merlin/blob/master/egs/slt_arctic/s1/RESULTS.md) for phone-align are slightly worse than state-align. Having said that, the quality shouldn't defer much.
Once you alter any variable in global_settings.cfg, you need to recreate all the conf files. Please share the conf files if possible.

I just use cmu slt demo and cmu slt full data to run the script.
I've changed the file "merlin/egs/slt_arctic/s1/scripts/setup.sh".
set echo "Labels=phone_align" >> $global_config_file
Then I run the script "merlin/egs/slt_arctic/s1/run_demo.sh" directly. Dose there anything missing?
And I double check my log, the phone-align labels used~
Thanks for replay~

Sorry, check down.
When I just change the script, the test labels didn't change.
So I switched my test labels, it's work fine~

okay, I assume you are using run_full_voice.sh rather than run_demo.sh


Wrote script to generate new UI Themes for IntelliJ 2019.1

Recently IntelliJ finally started supporting the ability to create UI Themes. I wrote a quick node script that parses each color scheme xml file and generates the relevant UI theme json file.
Note this only supports 2019.1+ versions. Here's a link to the docs.
Admittedly I'm not a designer and don't have an eye for this sort of thing, but I was tired of using these great themes with a different UI in IntelliJ. You can change any of the values with fields from the xml color schemes. I'm currently running the jar file. The light themes could probably use some looking over. I use strictly dark themes, but I did confirm they all load.

@daylerees Any chance of this repository being updated now that Jetbrains support full IDE theming?

Please, it would be nice to use these awesome themes again!


Fix: inline policies limit when updating

Inline policies created by the library include a timestamp, this is creating new policies whenever CloudFormation tries to redeploy them.
Because of the way CloudFormation works this new policies (identical to the old ones, but with different name due to the timestamp) will be added to the role before deleting the old ones: Link
Therefore when having many Acitivities added to a role or in combination with other inline policies the error about policy size is appearing: "Maximum policy size of 10240 bytes exceeded for role"

Create the following PR: Link with a possible fix


How to manage page stack in flutter/native hybrid App?

Hello, I'm doing a project to migrate an existing app to Flutter, a page-by-page migration, so we need to mix Flutter with Native(Android/IOS).
The biggest problem in the mixing process is how to manage the page stack.
For example (N: Native, F: Flutter):
Page opening order: Page1(N) -> Page2(F) -> Page3(F) -> Page4(N) ->Page5(F)
Due to the normal usage of FlutterActivity is singleton, problems occur when returning along this stack. In order to solve this problem, we thought about some possible solutions as below. Which one is appropriate？ Wish your suggestion.
Plan 1, the application records this stack data by itself, and when the page is rolled back,  try to modify the native stack. This method works on IOS, but since Android doesn't provide an interface to manage the system stack, it's hard to work on Android, and we can only lose the Page2(F) and Page3(F) stack frames.

Plan 2, Refactor the functions of FlutterActivity,  extract it into a singleton Fragment instance. Each Flutter page corresponds to a new Activity nested with this singleton Fragment.

Plan 3, Similar to option 2, extracts the FlutterNativeView in FlutterView as a singleton instance. Each Flutter page use a new FlutterActivity instance nested with this singleton FlutterNativeView instance.

Plan 4, Start a new FlutterActivity instance for each Flutter page. In this case, the system can easily manage the stack. However, starting multiple instances of Flutter may cause performance problems, and the startup speed of the page will be slower.

this is a good idea。
but i dont know how to isolate  context （isolate） of each flutterActivity

@mravn-google: This is a specific use case related to #14821.

The long-term solution is option 4. @chinmaygarde is working on steps to enable this and can probably refer you to the tracking bug (I couldn't find it).
If you're trying to implement this right away, perhaps opt for a low-ish cost solution for now like option 2 which other users have successfully adopted. https://github.com/flutter/engine/blob/master/shell/platform/android/io/flutter/app/FlutterActivityDelegate.java is already somewhat interfaced out to fit ok with a Fragment API minus all the splash screen stuff.

Thanks @xster . If I use option 4, I will create many FlutterActivity instance.  Will the memory size be problem?  Or will there be any other problems you can suppose?

Thanks to your suggestions @xster @InMatrix , following these hints, we have solved this problem by a manner similar to plan 2, reusing a singleton FlutterView and embed it into different Activities. The result is proved to be well.


Support setting a static minutes read on posts.

Useful if you have a lot of invisible content, e.g. commented out with . These become part of the minutes read calculation which then will be incorrect. My setting the minutes var in the YML frontmatter of the post you can bypass the calculation.

Awesome.


Can this work on WASM?

Does this library work on the WebAssembly backend for GHC? As far as I can tell it comes with its own version of libffi, but maybe it's incompatible with the code in this repo? Here's the error (using GHC WASM 9.10.1):
Internal.hsc:37:32: error: use of undeclared identifier 'FFI_TYPE_STRUCT'
   37 |         static int test_array[(FFI_TYPE_STRUCT) > 0 ? 2 : 1];
      |                                ^
Internal.hsc:38:32: error: no member named 'elements' in 'ffi_type'
   38 |         static int test_array[(offsetof(ffi_type, elements)) > 0 ? 2 : 1];
      |                                ^                  ~~~~~~~~
/home/rubenverg/.ghc-wasm/wasi-sdk/lib/clang/19/include/__stddef_offsetof.h:16:24: note: expanded from macro 'offsetof'
   16 | #define offsetof(t, d) __builtin_offsetof(t, d)
      |                        ^                     ~

I presume a version of libffi exists because the error isn't "libffi header not found" but "FFI_TYPE_STRUCT not found" and ffi_type seems to exist too.

Does this library work on the WebAssembly backend for GHC?

Hard to say, as I've never tried. Nor do I have a Wasm-enabled GHC compile handy, so it's not easy for me to test locally.

As far as I can tell it comes with its own version of libffi, but maybe it's incompatible with the code in this repo?

That's quite possible. I feel very out of my depth trying to debug Wasm-related issues, but I'd be happy to review a patch that adds any Wasm-specific tweaks necessary to make the library work.

After further investigation, it looks like dlsym doesn't work on WASM either, so there's no point to getting the lib to work.

Indeed, I would be surprised if Wasm had a direct counterpart to dlsym() or LoadLibrary(). That being said, there might be a more Wasm-friendly way to achieve the same thing. Some searching turns up this blog post by the maintainer of the GHC Wasm backend:

https://www.tweag.io/blog/2022-03-17-libffi-wasm32/

There, he mentions https://gitlab.haskell.org/ghc/libffi-wasm, a code generator that can generate Wasm-friendly libffi functionality. Admittedly, I haven't tried this myself, but that seems like a good place to start from.
Once we collectively understand how this works better, we can think about whether it makes sense to integrate it with this library in some way, or if we'd be better served approaching the problem differently from how this library does it.

As far as I can tell, that library is the one that ships with GHC WASM and therefore gets used by this library. I'm not sure there's a way to use external libraries though; it looks like WASI doesn't support dlopen and dlsym; so it probably only works for the GHC-internal use, or maybe a completely different strategy is required.


fix(ci): avoid false negative by disabling hypothesis health check

Change Summary
Sometimes the CI fails (right now master is red) due to
E   hypothesis.errors.FailedHealthCheck: Data generation is extremely slow:
Only produced 9 valid examples in 1.22 seconds (0 invalid ones and 2 exceeded maximum size).
Try decreasing size of the data you're generating (with e.g.max_size or max_leaves parameters).

I suggest we simply remove this health check

Related issue number

Checklist

[ ] Unit tests for the changes exist
[ ] Tests pass on CI and coverage remains at 100%
[ ] Documentation reflects the changes where applicable
[ ] changes/<pull request or issue id>-<github username>.md file added describing change
(see changes/README.md for details)

@Zac-HD WDYT?

Unless you want to use settings profiles from e.g. conf.py, this looks good to me :+1:
(assuming of course that you don't want to simplify the code by requiring Hypothesis for tests)

For now I think it's best to stick with this approach. But good to know! Thanks a lot 🙏

Happy to help!
Also a terminology tip: I prefer "false alarm" over "false positive", and "missed bug" over "false negative"... just a bit easier to remember or read :slightly_smiling_face:

Great advice! Will definitely remember

Great, I was thinking about this yesterday.
Thanks for fixing.


refactor!: remove --k8s-control-plane-url CLI flag from Helm Chart

Related to #71

I don't remember if I need to remove the flag from the code or only from the helm chart

I don't remember if I need to remove the flag from the code or only from the helm chart

Well, you raised a good topic.
I think we should create two MRs: one for the code, the second one for the Charts.
Saying this since we have to release, first, the new binary along with Docker image, otherwise, we could end up with errors for users installing in the release process.

I don't remember if I need to remove the flag from the code or only from the helm chart

Well, you raised a good topic.
I think we should create two MRs: one for the code, the second one for the Charts.
Saying this since we have to release, first, the new binary along with Docker image, otherwise, we could end up with errors for users installing in the release process.

Got it so this one is only for Helm chart!

@ludusrusso may I ask you to refer the appVersion to v0.1.0?
Once done, we can merge this!

@ludusrusso may I ask you to refer the appVersion to v0.1.0?
Once done, we can merge this!

done!


Sky Map doesn't work anymore on Fairphone 2 with Lineage 14.1

Summary:
nach dem dem Start und dem Kalibrierungsbildschirm hängt sich die App auf
Device and Android version:
Fairphone 2, Lineage 14.1

The problem may have something to do with the location determination in LineageOS 14.1. Several other apps have no problem with this. I used FDroid to download Sky Map. I don't know how to send a debug report because Sky Map crashes the whole phone. What do you mean by "access to this type of phone"?

I have an Axon 7 with LineageOS 15.1 and microG providing network location. The application works for me, and it keeps working when I disable all network location backends, and even when I disabled network location entirely from the Android settings and select GPS only (with reboots between each test).
So, I would presume this is a problem specific to the Fairphone or to LineageOS 14.1.

As already mentioned: other apps (e.g. OsmAnd, Vespucci) can also query the location on my Fairphone FP2 with LineageOS 14.1 without having to use microG or upgrade to LineageOS 15.1.

Very late reply.  "access to this type of phone" - I mean I simply don't have one. So it's hard for me to debug given that it's phone specific.  If you're able to get logs (using adb logcat) then I might be able to figure it out. Sorry I can't be more helpful.

I have a Fairphone 2 with Lineage 14.1 as well and the app from F-Droid is working fine. Can you send a adb logcat in case you have the problem, still?
Also, the new 1.9.4 version should be an F-Droid soon.


Setting mouse mode to confined causes TextureButton hover to stop working (new -after upgrading to Godot 4.2 from 4.1.1)

Godot version
v4.2.stable.mono.official [46dc27791]
System information
Godot v4.2.stable.mono - Fedora Linux 38 (Thirty Eight) - X11 - Vulkan (Forward+) - dedicated NVIDIA GeForce GTX 1650 SUPER (nvidia; 545.29.06) - Intel(R) Core(TM) i7-4790K CPU @ 4.00GHz (8 Threads)
Issue description
I updated my project from 4.1.1 to 4.2. I noticed that the TextureButton hover textures stopped appearing. After some experimentation I narrowed it down to occurring after setting mouse mode to confined.
Steps to reproduce

Make a new project
Make a new scene with TextureButton
Attach a script and set mouse mode to confined
Play the scene and moving the cursor over the TextureButton doesn't result in the hover texture

Minimal reproduction project

texture_button.tscn shows the issue with a C# script
texture_buttongd.tscn shows the issue with a GDScript script

hover_issue.zip

Bisected to https://github.com/godotengine/godot/commit/59c13fea5da195fe550f95b247bf2b84daf05b1a (https://github.com/godotengine/godot/pull/80334), cc @Sauermann


Type for postgres pool with any Tls

Hi!
Depending on settings I want to use Tls or NoTls. How to specify this type for function that gets Pool as argument?
Now I do it like this:
fn example<Tls>(
    _: Request<Body>,
    pool: &Pool<PostgresConnectionManager<Tls>>,
) -> impl Future<Item = Response<Body>, Error = hyper::Error>
where
    Tls: MakeTlsConnect<Socket> + Clone + Send + Sync + 'static,
    <Tls as MakeTlsConnect<Socket>>::Stream: Send + Sync,
    <Tls as MakeTlsConnect<Socket>>::TlsConnect: Send,
    <<Tls as MakeTlsConnect<Socket>>::TlsConnect as TlsConnect<Socket>>::Future: Send,
{
    //do something with pool
}

But it looks a bit weird and hard to define this type in many functions. Is there a better solution?

I don't think there's much that can be done here, sadly.


[SPARK-5231][WebUI] History Server shows wrong job submission time.

History Server doesn't show collect job submission time.
It's because JobProgressListener updates job submission time every time onJobStart method is invoked from ReplayListenerBus.

Test build #25490 has started for   PR 4029 at commit 11107a8.

This patch merges cleanly.

Test build #25490 has finished for   PR 4029 at commit 11107a8.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class SparkListenerJobEnd(

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25490/
Test FAILed.

It looks like this failed due to a test compilation error:
[error] /home/jenkins/workspace/SparkPullRequestBuilder/core/src/test/scala/org/apache/spark/scheduler/SparkListenerSuite.scala:47: not enough arguments for method apply: (jobId: Int, time: Option[Long], jobResult: org.apache.spark.scheduler.JobResult)org.apache.spark.scheduler.SparkListenerJobEnd in object SparkListenerJobEnd.
[error] Unspecified value parameter jobResult.
[error]     (1 to 5).foreach { _ => bus.post(SparkListenerJobEnd(0, JobSucceeded)) }
[error]                                                         ^
[error] /home/jenkins/workspace/SparkPullRequestBuilder/core/src/test/scala/org/apache/spark/scheduler/SparkListenerSuite.scala:57: not enough arguments for method apply: (jobId: Int, time: Option[Long], jobResult: org.apache.spark.scheduler.JobResult)org.apache.spark.scheduler.SparkListenerJobEnd in object SparkListenerJobEnd.
[error] Unspecified value parameter jobResult.
[error]     (1 to 5).foreach { _ => bus.post(SparkListenerJobEnd(0, JobSucceeded)) }
[error]                                                         ^
[error] /home/jenkins/workspace/SparkPullRequestBuilder/core/src/test/scala/org/apache/spark/scheduler/SparkListenerSuite.scala:102: not enough arguments for method apply: (jobId: Int, time: Option[Long], jobResult: org.apache.spark.scheduler.JobResult)org.apache.spark.scheduler.SparkListenerJobEnd in object SparkListenerJobEnd.
[error] Unspecified value parameter jobResult.
[error]     bus.post(SparkListenerJobEnd(0, JobSucceeded))
[error]                                 ^
[error] /home/jenkins/workspace/SparkPullRequestBuilder/core/src/test/scala/org/apache/spark/scheduler/SparkListenerSuite.scala:348: not enough arguments for method apply: (jobId: Int, time: Option[Long], jobResult: org.apache.spark.scheduler.JobResult)org.apache.spark.scheduler.SparkListenerJobEnd in object SparkListenerJobEnd.
[error] Unspecified value parameter jobResult.
[error]     (1 to 5).foreach { _ => bus.post(SparkListenerJobEnd(0, JobSucceeded)) }
[error]                                                         ^
[info] Compiling 1 Scala source and 1 Java source to

To prevent these sorts of issues, you can run sbt/sbt test:compile to compile the tests without running them.

Thanks, I just did assembly.
Now the compilation error is resolved.

Test build #25516 has started for   PR 4029 at commit 2d47bd3.

This patch merges cleanly.

Test build #25516 has finished for   PR 4029 at commit 2d47bd3.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class SparkListenerJobEnd(

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25516/
Test FAILed.

Test build #25527 has started for   PR 4029 at commit 26b9b99.

This patch merges cleanly.

Test build #25527 has finished for   PR 4029 at commit 26b9b99.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class SparkListenerJobEnd(
    val classServer                                   = new HttpServer(conf, outputDir, new SecurityManager(conf), classServerPort, "HTTP class server")
 case class QualifiedTableName(database: String, name: String)
case class CreateMetastoreDataSource(

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25527/
Test PASSed.

This is a nice patch, but I wonder whether there's a smaller fix that doesn't require changing SparkListener events; that will make it easier to backport that patch to branch-1.2.  The job page already knows the last stage in the job (the result stage), so I think we might be able to use the final stage's completion time as the job completion time and the first stage's submission time as the job start time.  However, there are a couple of corner-cases that this might miss: I could submit a job that spends a bunch of time queued behind other jobs before its first stage starts running, in which case it would be helpful to be able to distinguish between scheduler delays and stage durations.  Similarly, there might be a corner-case related to the job completion time if we have a job that spends a lot of time fetching results back to the driver after they've been stored in the block manager by completed tasks.
So, I guess the approach here seems like the right fix.  I'd guess we might be able to do a separate fix in branch-1.2 to use the first/last stage time approximations.
I have a couple of comments on the code here, so I'll comment on those inline.

@JoshRosen Thanks for your advises. I reflected your comment and added a test case.
For now, I will take the original approach and also, I will try to address this issue using the approximation approach you mentioned for 1.2.x.
What do you think?

Test build #25569 has started for   PR 4029 at commit da8bd14.

This patch merges cleanly.

Test build #25569 has finished for   PR 4029 at commit da8bd14.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class SparkListenerJobEnd(

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25569/
Test PASSed.

Test build #25627 has started for   PR 4029 at commit 0af9e22.

This patch merges cleanly.

Test build #25627 has finished for   PR 4029 at commit 0af9e22.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25627/
Test PASSed.

@sarutak @JoshRosen I would prefer to use the same solution for both master and 1.2 if possible, so if something goes wrong we only need to reason about one fix. Since we should not push this PR's current changes to branch-1.2 (it will break upgrades for 1.2.0 users), I would actually rather not fix this in branch-1.2 if we're not using the approximation solution. In general it would be good to minimize the complexity that arises from the divergence of behavior across branches.

The changes here actually LGTM, so I will merge this in master. Thanks @sarutak!

If the only backwards incompatibility is via pattern matching on listener events, can we maybe just make the new field a mutable var that's set outside of the constructor?  This should avoid that incompatibility even if it's a little messy.
Sent from my phone

On Jan 16, 2015, at 10:04 AM, andrewor14<EMAIL_ADDRESS>wrote:
The changes here actually LGTM, so I will merge this in master. Thanks @sarutak!
—
Reply to this email directly or view it on GitHub.

@JoshRosen that could work. If we do decide to do it we must absolutely make sure that we don't break anything for 1.2.0 users, since compatibility in a patch release even for a developer API is expected by most users.


Improve platform selection in the GDNativeLibrary dock

Follow up to #30869

Replace button text with currently selected platforms
Expand button size horizontally

This still needs a few improvements before it can be merged:

Add a drop-down icon to the right of the button
Add a box around the button

Maybe you can retrieve the stylebox of OptionButton and apply it to the MenuButton?
Though maybe it's better to leave it as is, the fact that MenuButton doesn't make its expandable menu discoverable is a more general issue that should likely be handled for the whole editor.

Maybe OptionButton should be changed so it accepts checkboxes.
Adding functions such as

use_radio(bool)
get_selected_ids()

By default the mode would be set to "radio"/exclusive selection so that it doesn't break compatibility.

A better solution would be to create another class that's derived from OptionMenu and supports checkboxes.
Or make OptionMenu be derived from this class.

I think your improvements are good as is for now, let's open a new issue to discuss improving the editor theme or features around drop-down checkbox lists?

Thanks!


Focus issue with multiple selections

Thanks a lot for the library - I spent ages trawling through different select2 wrappers before finding it and it seems much better than the alternatives I tried!
I have found an issue with focus handling when the component is in multiple select mode. If a focusable element is placed before the component then that element is mistakenly activated when the Enter key is pressed to confirm a selection.
Here's a plunkr to reproduce the issue:
https://plnkr.co/edit/QsuqwKiJ1tCWCkfFYeLC?p=preview
Note the button element that is placed before the multiple selection example. When you type "0" then press enter to select the "0" value, the button will be clicked.

I should be fixed if you put type="button".
Here:
<button type="button" (click)=handleButtonClick()>Some button
instead of
<button (click)=handleButtonClick()>Some button
Otherwise it assumes that the button it's a submit type since it's inside of a form.

You're totally right, thanks!


README and jquery example lists wrong SDK

The README links to the 1.0.0 SDK on the CDN, but it seems the current version is 2.1.0:
https://github.com/FamilySearch/familysearch-javascript-sdk/blob/master/README.md
The jquery example links to the 2.0.0 SDK, but that link is no longer live:
https://github.com/FamilySearch/familysearch-javascript-sdk/blob/master/examples/jquery.html
Instead, it should link to the 2.1.0 SDK.

Thanks for bringing it to our attention. Got it current now.

Great, thanks for the quick fix!


Rewrite Shader.cpp example

Based on #3027

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

57 of 69 (82.61%)  changed or added relevant lines in 3 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.1%) to 55.769%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/SFML/Graphics/Font.cpp
11
17
64.71%

src/SFML/Graphics/Texture.cpp
43
49
87.76%

Files with Coverage Reduction
New Missed Lines
%

src/SFML/Graphics/Texture.cpp
1
72.45%

Totals

Change from base Build<PHONE_NUMBER>:
0.1%

Covered Lines:
11551

Relevant Lines:
19614

💛  - Coveralls

Rebased on master now that #3027 is merged. No changes made.

@ChrisThrasher: can you run the example locally? I'm getting an issue getting the first texture displayed but I'm not sure if I screwed up something or if my build environment has some sort of issue.

I'm getting weird behavior. First thing I get is this UBSan error:
/Users/thrasher/Projects/sfml/src/SFML/Graphics/RenderTarget.cpp:863:63: runtime error: load of value 136, which is not a valid value for type 'bool'
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /Users/thrasher/Projects/sfml/src/SFML/Graphics/RenderTarget.cpp:863:63 in
Abort trap: 6

If I disable UBSan then the program will launch but the Pixelate and Edge Post-effect shaders don't work anymore. Here's a console log that may be of use
UNSUPPORTED (log once): POSSIBLE ISSUE: unit 0 GLD_TEXTURE_INDEX_2D is unloadable and bound to sampler type (Float) - using zero texture because texture unloadable

@ChrisThrasher: thanks for confirming the weird behavior. My guess is some sort of misuse of sf::Texture or maybe a bug in sf::Texture's move constructor

@ChrisThrasher: the issue disappears when changing the tryLoad functions to use guaranteed RVO copy elision, e.g.:
static std::optional<Pixelate> tryLoad()
{
    // ...
    return std::optional<Pixelate>{std::in_place, std::move(*texture), std::move(*shader)};
}

So the issue is definitely in either Texture(Texture&&), or Sprite(Sprite&&), or Shader(Shader&&).
It's very late here, so you're more than welcome to try to figure this out while I get some rest :)
Otherwise I'll give it a shot tomorrow.

@ChrisThrasher: the issue disappears when changing the tryLoad functions to use guaranteed RVO copy elision, e.g.:
static std::optional<Pixelate> tryLoad()
{
    // ...
    return std::optional<Pixelate>{std::in_place, std::move(*texture), std::move(*shader)};
}

So the issue is definitely in either Texture(Texture&&), or Sprite(Sprite&&), or Shader(Shader&&).
It's very late here, so you're more than welcome to try to figure this out while I get some rest :)
Otherwise I'll give it a shot tomorrow.

@ChrisThrasher: BTW, we should use this pattern in all our optional-returning functions. Basically, when we do
std::optional<T> f()
{
    return T{args...};
}

we should instead do:
std::optional<T> f()
{
    return std::optional<T>{std::in_place, args...};
}

The former always invokes a move constructor, the latter never does so -- it is guaranteed RVO copy elision. We should make this change library-wide.

@ChrisThrasher: oh, I think I get it. sf::Sprite stores a sf::Texture*. But when the entirety of Pixelate gets moved, the pointer doesn't get updated. This is very unfortunate

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 55.758%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
11585

Relevant Lines:
19671

💛  - Coveralls

SFMLBuildMaster: Build this please.

SFMLBuildMaster: Build this please.

but it worries me that this sort of bug can end up unnoticed...

I suppose this is another instance of the existing API limitation which states that the texture must outline the sprite. Moving the texture implies ending the lifetime of the texture (at its original address) before the sprite's lifetime ends. I'm still bothered by how hard this is to detect though.

we should instead do:
std::optional<T> f()
{
    return std::optional<T>{std::in_place, args...};
}

Fine by me. This pattern is new to me but it looks like a reasonable solution for use internally.

https://github.com/SFML/SFML/pull/3070
I tried testing this new assert with the older, buggy start of this PR and can't get the assert to fire so this doesn't seem to fix the problem. It may still be useful but it's not sufficient to catch the bug we were previously seeing.


113705: Windows framework_tests_misc is 5.21% flaky

Separated out some longer running tests from runMisc to prevent flakiness from timeouts.
Closes #113705.
Pre-launch Checklist

[x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
[x] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
[x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
[x] I signed the [CLA].
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is [test-exempt].
[ ] All existing and new tests are passing.

I've consistently titled my PRs to match the issue they're resolving so they can be easily found/related to each other. I don't think that pattern breaks any of the contribution guidelines, so I'd rather leave it as is.
The description goes more in depth and is searchable from the Pull Request search bar as well.

I've consistently titled my PRs to match the issue they're resolving so they can be easily found/related to each other. I don't think that pattern breaks any of the contribution guidelines, so I'd rather leave it as is.
The description goes more in depth and is searchable from the Pull Request search bar as well.

GitHub already relates them to each other in the UI.

The PR title is used as the commit description, and it's much easier to pick out what's changed in a git log if it described what changed.  Your good commit message "Separated out some longer running tests from runMisc to prevent flakiness from timeouts" will instead become "113705: Windows framework_tests_misc is 5.21% flaky".

I've never seen anyone use this pattern before, but indeed there are no contribution guidelines that I'm aware of. 🤷♀

I've consistently titled my PRs to match the issue they're resolving so they can be easily found/related to each other. I don't think that pattern breaks any of the contribution guidelines, so I'd rather leave it as is.
The description goes more in depth and is searchable from the Pull Request search bar as well.

The issue here is visibility from the commit log. This is also what we auto-generate release notes from (https://github.com/flutter/flutter/blob/master/.github/release.yml), so it's preferred the commit message is worded in terms of the fix the commit contains, rather than the bug it is addressing.

@jmagman @christopherfujino
Thank you for the further context. I didn't realize just how many things were based on the title alone. I'll adjust my pattern going forward, though it may be worth mentioning that context somewhere in the contribution guidelines since it does seem more important than one would assume at a first glance.
Updated the title.