spring cloud gateway TraceContext.traceId() Is not equal to micro service tid

Please answer these questions before submitting your issue.

Why do you submit this issue?
[Agent ] Bug

Question

What do you want to know?
Spring Cloud Gateway TraceContext.traceId() Is not equal to micro service logback tid
I think that is the cause of the TraceCrossThread
Before 6.5.0, the traceid Repeated Generation in spring cloud gateway。Now,the bug is solve，but the traceid is not a GlobalTraceId

Bug

Which version of SkyWalking, OS and JRE?
SkyWalking 6.5  jdk1.8

What happen?
spring cloud gateway GlobalFilter:
LOGGER.info(TraceContext.traceId());
[ctor-http-nio-3] c.d.cbhis.his_gateway.filter.GrayFilter  : 3729.128.15741514902390093
Micro service logback:
[TID:3729.128.15741514391310083]

Requirement or improvement

How to get the GlobalTraceId in spring cloud gateway GlobalFilter or GatewayFilter.

Maybe you could provide your codes? @dodomao
@zhaoyuguang Please take a look, look like Gateway plugin is still no stable.

Spring Cloud Gateway:
Spring Boot:'org.springframework.boot' version '2.1.4.RELEASE'
Spring Cloud:"Greenwich.SR2"
build.gradle:
compile 'org.apache.skywalking:apm-toolkit-logback-1.x:6.5.0'
compile 'org.apache.skywalking:apm-toolkit-trace:6.5.0'
GlobalFilter:
`@Component
public class LoggerFilter implements GlobalFilter, Ordered {
private static final Logger LOGGER = LoggerFactory.getLogger(LoggerFilter.class);

@Override
public Mono<Void> filter(ServerWebExchange exchange, GatewayFilterChain chain) {

    ServerHttpRequest request = exchange.getRequest();
    URI uri = request.getURI();
    HttpHeaders httpHeaders = request.getHeaders();
    String zhiGongXm = "";

    if (LOGGER.isDebugEnabled()) {
            StringBuilder stringBuilder = new StringBuilder();
            stringBuilder.append("traceID:'").append(TraceContext.traceId()).append("'");
            LOGGER.debug(stringBuilder.toString());
    }

    String finalZhiGongXm = zhiGongXm;
    ServerHttpRequest serverHttpRequest = exchange.getRequest().mutate().headers(headers -> {
        try {
            headers.add("DangQianYhMc", URLEncoder.encode(finalZhiGongXm, "UTF-8"));
        } catch (UnsupportedEncodingException e) {
            LOGGER.error("UnsupportedEncodingException:", e);
        }
    }).build();

    return chain.filter(exchange.mutate().request(serverHttpRequest).build());
}

@Override
public int getOrder() {
    return Integer.MAX_VALUE;
}

}`
Micro Service:
Logback.xml:
<appender name="DAILY_FILE" class="ch.qos.logback.core.rolling.RollingFileAppender">         <Append>true</Append>         <File>${logs.dir}/micro-service.log</File>         <encoder class="ch.qos.logback.core.encoder.LayoutWrappingEncoder">             <charset>UTF-8</charset>             <layout class="org.apache.skywalking.apm.toolkit.log.logback.v1.x.TraceIdPatternLogbackLayout">                 <pattern>{[%tid] - %d - [%t] %-5p %c:%L %X - %m}%n</pattern>             </layout>         </encoder>         <filter class="ch.qos.logback.classic.filter.ThresholdFilter">             <level>DEBUG</level>         </filter>         <rollingPolicy class="ch.qos.logback.core.rolling.TimeBasedRollingPolicy">             <fileNamePattern>${logs.dir}/micro-service.log.%d{yyyy-MM-dd}</fileNamePattern>             <maxHistory>7</maxHistory>         </rollingPolicy>     </appender>
@zhaoyuguang thanks

received, I will try it

Test of time, you need a concurrent execution, this problem will be very obvious. A single execution, may not be able to recurrence。the TraceID Obtained from gateway logback with MicroService TraceID No relevance

@dodomao There is a fix in the master branch for Gateway and Webflux. Could you recheck whether does it fix this?

Gateway plugin improved through #4878 again.


hls.js: play when autoPlay is true

It seems now that is responsibility of each playback to autoplay itself, since html5video already provide the basic (marking autoplay attribute).

I agree this is correct. But I'm just a bit confused because I'm sure I tested autoplay not that long ago an it worked :/


Adds form label changes

Ok so i am supposed to be changing the actual Label not the for attribute?
Admin name:
So standardizing the part that currently says "Admin name", eliminating redundancies?


Add connect cmdlet

ITNOA
please add connect cmdlet based on https://github.com/Azure/autorest.powershell/issues/1252#issuecomment-1771991548

Like https://learn.microsoft.com/en-us/powershell/azure/get-started-azureps?view=azps-10.4.1

related to https://github.com/Azure/azure-powershell/discussions/23233

ask some question about solution of this task
https://stackoverflow.com/q/77416109/1539100


Sheet Home

Issues Addressed
closes #9
closes #10
closes #11

@sfaria27 spec in left

included in #30


Fixed OS image lookup in VirtualMachine

Before we start an instance a check is made if the provided image
is reachable by the cloud service. However if the image itself
does not (or not yet) exist azurectl runs into an unhandled
exception

We should explain to the user at some point why his request failed.

We should explain to the user at some point why his request failed.

With this fix the AzureImageNotReachableByCloudServiceError is
raised causing this message
'The selected image "%s" is not available',
'in the region of the selected cloud service "%s",',
'cannot launch instance'

I think that matches that case and is clear enough
Thoughts ?


Update progress-report.md

https://dev.azure.com/mseng/AzureDevOps/_workitems/edit/1962421/
updating for this ticket

@steved0x
Can you review this PR?
IMPORTANT: When this content is ready to merge, you must add #sign-off in a comment or the approval may get overlooked.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team


Remove Gradle, Settings and Project interfaces from Kotlin DSL script type hierarchies

Fixes #9255

Superseded by #10822


[SPEC] correctly locating sub-facets in OpenLineage.json

Signed-off-by: howardyoo<EMAIL_ADDRESS>Problem
The sub-facets under each facet location is located under additionalProperties which is not necessary, but rather, should be located on one level above.
Solution
This PR corrects the current spec's location of the sub-facet types by moving them one-level up.

Note: All schema changes require discussion. Please link the issue for context.

[x] Your change modifies the core OpenLineage model
[ ] Your change modifies one or more OpenLineage facets

If you're contributing a new integration, please specify the scope of the integration and how/where it has been tested (e.g., Apache Spark integration supports S3 and GCS filesystem operations, tested with AWS EMR).
Checklist

[x] You've signed-off your work
[x] Your pull request title follows our guidelines
[ ] Your changes are accompanied by tests (if relevant)
[ ] Your change contains a small diff and is self-contained
[ ] You've updated any relevant documentation (if relevant)
[ ] You've updated the CHANGELOG.md with details about your change under the "Unreleased" section (if relevant, depending on the change, this may not be necessary)
[x] You've versioned the core OpenLineage model or facets according to SchemaVer (if relevant)
[ ] You've added a header to source files (if relevant)

SPDX-License-Identifier: Apache-2.0
Copyright 2018-2022 contributors to the OpenLineage project

Great idea! I believe @JDarDagran may be working on work to validate schemas, so maybe this can be part of it! Sounds like something that we can do for that.


2 AM Ramble About Custom GregTech Radiation Mechanic

Details
Since it seems that GregTech is implementing heavier elements that are highly toxic and radioactive, I guess it would be reasonable to add in new gameplay mechanics that require the player to use extra care when handling stuff like polonium, astatine, etc.
There are many types of radiation in real life ranging from particle radiation to electromagnetic radiation. This radiation will not only hurt players but will also damage electronics and could make machines unusable.
Alpha particles (emitted by unstable nuclei that undergo alpha decay) - Easiest radiation to block, even paper can protect against this.
β- Decay (high energy electrons) - Also easy to block, but it is better to use materials with low atomic weight such as water, plastic, or wood, to prevent making more radiation due to Bremsstrahlung X-rays. β+ Decay emits positrons instead, which produce Gamma Rays when they collide with electrons in normal matter.
X-Ray or Gamma Rays - Harder to block. Almost any material can be used but it has to be thick. Lead is the one of the most common materials used to block this radiation. Nuclear Reactors use specialized types of concrete as well for extra shielding. This type of radiation has side effects on living beings and electronics due to its ability to penetrate materials and affect atoms in them.
"Most nuclear reactors use thick concrete shields to create a bioshield with a thin water-cooled layer of lead on the inside to protect the porous concrete from the coolant inside. The concrete is also made with heavy aggregates, such as Baryte or MagnaDense (Magnetite), to aid in the shielding properties of the concrete." - https://en.wikipedia.org/wiki/Radiation_protection#Radiation_shielding
Finally there is neutron radiation. This type of radiation is the most damaging. This radiation can be mitigated by using neutron reflectors (graphite, beryllium, tungsten carbide, etc) or absorbed by light materials such as water or polyethylene. It also degrades reactor materials over time.
"Graphite neutron moderator blocks are especially susceptible to this effect, known as Wigner effect, and must be annealed periodically. The Windscale fire was caused by a mishap during such an annealing operation." - https://en.wikipedia.org/wiki/Neutron_radiation
Radioactive materials, stored in inventories or chests or Quantum Storages or whatever, would produce one or more of the four types of radiation listed above based on how they decay. The same goes for radioactive liquids/gases placed in the world or stored in fluid tanks/buses or whatever is capable of storing liquids/gases. Radioactive machine blocks or multiblocks (such as fission reactors) will also produce one or more of these types of radiation. Essentially there will be 4 different types of maps corresponding to each type of radiation, which will each have their own effects on blocks and entities in those maps.
Each individual chunk will have its own counter for the four types of radiation above. Individual blocks will not have their own radiation because not even censoredasm will save us from the supreme lag that will create. Particles from alpha decay and beta decay will be ez to take care of. However, Gamma radiation and neutron radiation will spread very far to other chunks if not taken care of.
But how exactly will radiation be taken care of? The way radiation will be blocked might be that radioactive blocks will contribute less radiation to the chunk if the right material/block is used to cover them on their sides (with all sides being the best fpr blocking). For example, a block producing neutron radiation will not increase radiation in the chunk if it is covered by a lot of water around it. The more water, the less radiation (neutron radiation is annoying and does not go away that easily).
Increasing gamma radiation and neutron radiation in chunks will lead to increased chances of negative effects on entities and machines in the chunks. For example, machines might stop working. You might get a negative status effect. Or if you want to go GTNH mode just make everything explode when the slightest thing goes wrong.
However, radiation can sometimes be useful for stuff related to biology and genetics (similar to how radioactive materials were sometimes used to assist in bacterial vat recipes in GT:NH) But we will not get into that for now.
New machine covers could be added that provide radiation protection for machines. Inversely, new machine covers could be added that prevents machines from contributing certain types of radiation to chunks.
Hazmat suits and geiger counters could also be added for dealing with radiation.
By making radioactive materials annoying to deal with, it could also lead to another interesting gameplay choice. Long term storage and disposal of radioactive materials. Imagine gregtech bases with spent nuclear waste bunkers hundreds of blocks from the main area. That will be pretty "Greggy" as Regian would have put it.
Sources
Broader article on the effects of radiation on materials and human beings: https://en.wikipedia.org/wiki/Radiation_damage

I think it's worth making a distinction between radiation and radioactive contamination, the total radiation in a chunk should be the sum of the dose given by sources like inventories and machines and the presence of radioactive particles in the air/ground/water/whatever.
The first is immediately negated by shielding machines and inventories.
The second is caused by radioactive items or fluids being thrown on the ground or despawning, it lingers around and requires cleanup operations to get rid of (think of the scrubbers from nuclearcraft), while also being able to spread to other chunks.

I think it's worth making a distinction between radiation and radioactive contamination, the total radiation in a chunk should be the sum of the dose given by sources like inventories and machines and the presence of radioactive particles in the air/ground/water/whatever.
The first is immediately negated by shielding machines and inventories. The second is caused by radioactive items or fluids being thrown on the ground or despawning, it lingers around and requires cleanup operations to get rid of (think of the scrubbers from nuclearcraft), while also being able to spread to other chunks.

I agree with this idea. Furthermore, neutron radiation (which will fall into the first category) will cause radioactive contamination due to possible neutron activation.

Igblon, would it be possible for you to reopen some sort of alt account on Discord? I understand you want to focus on your channel more, but using an alt would allow you to avoid distractions and only join relevant servers (basically some sort of communication channel with us). It would be nice if you could do that so we can discuss various ideas. There's one in particular we'd like your input on, but it's classified until we have a working prototype ready to be released on CurseForge, and GitHub doesn't have any sort of DM features.

Igblon, would it be possible for you to reopen some sort of alt account on Discord? I understand you want to focus on your channel more, but using an alt would allow you to avoid distractions and only join relevant servers (basically some sort of communication channel with us). It would be nice if you could do that so we can discuss various ideas. There's one in particular we'd like your input on, but it's classified until we have a working prototype ready to be released on CurseForge, and GitHub doesn't have any sort of DM features.

I would rather they send me an email<EMAIL_ADDRESS>


dump versus parse time durations

I was analyzing my build using xclogparser invoked with parse --reporter json. As a test, I focused on one type == target. This had 22 defined subSteps. My thought was that the duration of the target should equal the sum of the durations of the subSteps. Each of these sub steps did not have any other sub steps.
Summing the sub steps results in a value of 1.0292 whereas the duration value for the target was defined as 5.7726 (I rounded these down)
I took at a look of the Xcode build output for the file I parsed. I did happen to notice that the steps that Xcode listed as 0.1 seconds were actually must smaller values. My guess is they just round up to 0.1 seconds. For example 0.007 sec appears to be rounded up to 0.1 sec. Unfortunately the total time for this target was not displayed in Xcode.
The time disparity is quite large. So I ran a dump to see if any clues could be found there. I found the same matching signature in the dump. I also verified the individual subSections from the dump matched the subSteps defined in the parse export to help verify I was looking at the same data.
I also wrote another script to do the math from the dump and got the same values.
Any thoughts on where that extra time came from? Should I expect summing the sub steps/ sub sections to match the target's duration time? Is the xcactivitylog missing information or is something being dropped on the floor?
Or am I looking at the data the wrong way where really the total time should be the target's duration plus the sum of the subStep durations? And if this is the case, how does one classify what "work" is being done by the target?
We're trying to optimize our build and find the places where we are slow, but it is a little unsettling to see a target's duration be so far off from it's subSteps
Thanks!

Quick addition here. I looked over the subSteps a little better. One thing I notice is that there is actually a gap between them. For example, I see a jump from one section stopping at 597803329.65822005 and then the next on starting at 597803334.31234396.
Looking at it this way, the start time of the target is roughly equal to the start time of the first section and the ending time of the target is roughly equal to the end time of the last target.
I do have parallel builds turned off. But I think despite this Xcode does still do some things concurrently.
Does one chalk up gaps related to the OS or to Xcode scheduling something else?

Hi, yeah we use the start time of the first substep and the endtime of the last substep to compute the duration of the target. It would be more visible if you generate the timeline of the project using --reporter html. You may found interesting data with the html report, such as having a target that it took 30 seconds, but if you click on it to open the substeps you may realise that the compiler finished to compile all the files in 3 seconds and the linking was done after waiting for 26 seconds.
This can be up to parallelisation as you mentioned, but even with that turned-off Xcode is still doing some work concurrently. The other reason could be due to your build graph, that the linker is waiting for a dependency to be ready or a build-phase script is waiting for an input to be ready. You will need to gig more to know why those gaps between steps are happening and try to optimise them.
If you just want the actual compilation time, you can grab only the steps with type swiftCompilation and calculate those.
I'll double check that the target duration is accurately computed according to the substeps.


Update endless.go

i am not sure i understand your question. the listener needs to get closed on the parent after forking so that the Accept function and finally Serve will return.

Sorry, I mean that if we can just call Close() method directly.
func newEndlessListener(l net.Listener, srv *endlessServer) (el *endlessListener) {
	return &endlessListener{
		Listener: l,
		stop:     make(chan error),
		server:   srv,
	}
}

func (el *endlessListener) Close() error {
    if el.stopped {
		return syscall.EINVAL
	}
    el.stopped = true
	return el.Listener.Close()
}

call (*TCPListener).Close() method without a stop channel.
I just can not understand this goroutine here
go func() {
	_ = <-el.stop
	el.stopped = true
	el.stop <- el.Listener.Close()
}()

If it has special significance?

i remember that when i started putting things together from grishas ideas that part was the one that  confused me at first - but it was needed - i think the parent just exited because there were no other goroutines running and did not serve outstanding requests... but i cannot remember exactly.
looking at it now it does not really make sense any more. probably lost it's meaning at some point when the whole thing came together using the same signatures as the stl ListenAndServe. my gutfeeling right now is that it can be removed... will have to write some tests... still an outstanding todo... i will look into it on the weekend and get back to you then.

:) THX

sorry - took a while...
https://github.com/fvbock/endless/tree/remove_channeled_close
here is a version that uses calls Close() directly. i added a very simple (hacky;) test script: go run test/test_restarting.go it relies on ab - apache bench. it makes 10000 requests to a test server (100 concurrent) which take random times between 1~1000ms while hitting the server with restart signals (SIGHUP).
as a first test that looks all good:
Document Path:          /foo
Document Length:        4 bytes

Concurrency Level:      100
Time taken for tests:   94.275 seconds
Complete requests:      10000
Failed requests:        0
Total transferred:      1200000 bytes
HTML transferred:       40000 bytes

maybe you can help me test a bit more?  will then hopefully soon merge this into master.

No problem, I will take the time to do this. But one or two days perhaps.

merged the changes into master: https://github.com/fvbock/endless/pull/5
closing this


Please drop machine-os-content reference

xref https://github.com/openshift/machine-config-operator/pull/3364
https://issues.redhat.com/browse/MCO-392?focusedCommentId=21045301&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-21045301

Reopening this issue with #103.
We need more guidance on how to replace machine-os-content, which provides an essential piece in the way DTK is currently released.

/reopen

OK, let's discuss design in https://issues.redhat.com/browse/MCO-392?focusedCommentId=21048335&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-21048335 or so?  I see the desire for a tag for "default operating system".  But I'd still really like to push for a world where we ship both rhel-coreos-8 and rhel-coreos-9 for example, and so anything using the "default" tag would then need to consider whether it actually needs to look at all possible operating system tags for example.

/cc @ybettan
So I can keep track of it.

I have added documentation of all the moving parts of that imagestream.

/remove lifecycle/stale
After some discussion the first step of the solution will be to try to user rhel-coreos-8 or rhel-coreos-9 in the image-refrences instead of machine-os-content.
This will require adding the io.openshift.build.versions label to the rhel-coreos-<8|9> and replace the primary source in ART's repo.
Additional info can be found at https://redhat-internal.slack.com/archives/C02CU30L7GF/p1676467754327349

/remove-lifecycle stale

/assign @ybettan

it's just rhel-coreos now. but io.openshift.build.versions label isn't there:
🐚 oc image info $(oc adm release info --image-for rhel-coreos 4.13.0-rc.5) | grep version
            org.opencontainers.image.version=413.92.202304191831-0
            version=413.92.202304191831-0

Yeah, this is messy...there's a whole lot interlocked here.  We have a build time option to add it and I tried to use it here but then we reverted here because we discovered that oc adm release new barfs if there are two images with the same machine-os label...
And that's where it stands, I think we'd need to fix oc adm release new.

perhaps DTK could change to looking at org.opencontainers.image.version label for 4.13+?
not sure the significance of these labels

@sosiouxme DTK isn't doing any of this stuff at all.
All we are doing is to add the machine-os-content snapshot.
I think that oc adm new... is the one responsible for the substitution so this change will probably need to be done there.
I don't mind changing the shapshot to any other container if needed to make it work.

/remove-lifecycle stale

The RHCOS pipeline is still building and maintaining the path to this container image. Would be helpful if we could finally nuke it completely from our deliverables. (E.g. our pipeline just tripped on a bug trying to build that container: https://github.com/coreos/coreos-assembler/issues/3635).
Naive question: rather than trying to solve the "how to ship multiple images with proper labels" part (which requires changes to oc), can we not stage the changes in both RHCOS and DTK and flip the switch roughly at the same time so that the new container has machine-os and the old container is gone?
It sounds like the blocker was on the fact that we'll eventually want the oc changes anyway so that we can ship multiple OS versions in the future, but it seems like for now we don't have to block on that to remove the legacy oscontainer.

Naive question: rather than trying to solve the "how to ship multiple images with proper labels" part (which requires changes to oc), can we not stage the changes in both RHCOS and DTK and flip the switch roughly at the same time so that the new container has machine-os and the old container is gone?

I don't anticipate an issue from the DTK side doing it.
AFAIK, if:

machine-oc-content is removed
"io.openshift.build.versions": "machine-os=<ocp version>.<rhel version>.<timestamp>" is added to rhel-coreos instead
dtk-image-references is modified to point to rhel-coreos image instead of machine-os-content
Then we should be good to go.

In case the io.openshift.build.versions needs to be added to any other container in the payload in the future, then we can address the oc issue.

I threw up https://github.com/openshift/os/pull/1374 and https://github.com/openshift/driver-toolkit/pull/135. I invite folks who have more context on this issue to review those. On the ART side, it looks like https://issues.redhat.com/browse/ART-4932 is still the ticket tracking the cleanups needed there.


Remove tools folder from coverate report

Pull Request Test Coverage Report for Build 287

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+2.7%) to 63.627%

Totals

Change from base Build 283:
2.7%

Covered Lines:
441

Relevant Lines:
621

💛  - Coveralls

Pull Request Test Coverage Report for Build 367

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+2.7%) to 63.627%

Totals

Change from base Build 283:
2.7%

Covered Lines:
441

Relevant Lines:
621

💛  - Coveralls

Even though we have tests in tools I agree that we do not have to collect coverage on that.


User Story 3 - (Priority 2, Estimation: 2 weeks)

As a player, I want to read a story, so that I am entertained

Playable story implemented


_Update function in Cart library

Hi,
There's a little bug in the _update function of the cart library. If you want to update something that is not the qty, like options or whatever, it doesn't update because the function _update returns false.
The problem is in /system/libraries/Cart.php, line 342
// Is the new quantity different than what is already saved in the cart?
// If it's the same there's nothing to do
if ($this->_cart_contents[$items['rowid']]['qty'] == $items['qty'])
{
     return FALSE;
}

Hey Marcos. Thanks for sending us this code change, but could you make it again as a pull request please?


stm32h747i_disco board M4 core not working

Describe the bug
stm32h747i_disco M4 core not work on recent zephyr version.
I found this issue when testing #37300 on stm32h747i_disco. The driver worked fine on our internal project which is based on v2.6.0. But it's not working on recent zephyr version.
I have followed the 'Getting Started Guide' to build a fresh blinky application. The yellow led for M7 is blinking, the blue led for M4 is not.
To Reproduce
Steps to reproduce the behavior:

west init zephyrproject
west build -p -b stm32h747i_disco_m7 samples/basic/blinky
west flash
west build -p -b stm32h747i_disco_m4 samples/basic/blinky
west flash

Expected behavior
The yellow led for M7 and blue led for M4 are both blinking.
Impact
stm32h747_disco board M4 core not worked.
Environment:

OS: Ubuntu 20.04
Toolchain: zephyr-sdk-0.12.4

Looks M4 doesn't receive wake-up events from M7. If I remove blow code in soc_m4.c, M4 led will blink too.
Now, I'm wondering why M4 doesn't receive the event.
	 /* Request Wait For Event */
	 __WFE();

Refer from "Table 33. Low-power mode summary" in STM32 RM0399,  Wakeup M4 core need an EXTI interrupt or event.
Since HSEM1 interrupt is an NVIC2 interrupt, maybe we should use __SEV() to wakeup M4?
But it still not explain why it's work on v2.6.0.

After upgraded the zephyr-sdk from v0.12.4 to v0.13, this issue disappeared.

@erwango I meet this issue again with v0.13 zephyr sdk.

After recheck my local dev branch, I found this time M4 not working are cause by others problem.
Below is my test on M4:

sample blinky, work fine.
sample h7_dual_core , work fine.
rpmsg_service enabled, not working.

So, close this issue again. If I have fixed the rpmsg_service issue, new PR will be send.

After recheck my local dev branch, I found this time M4 not working are cause by others problem.
Below is my test on M4:
sample blinky, work fine.
sample h7_dual_core , work fine.
rpmsg_service enabled, not working.

So, close this issue again. If I have fixed the rpmsg_service issue, new PR will be send.


Insert note index includes #undefined in the list when run in the root.md note

Please select the area your bug applies to. (Multiple selections are Possible. You can leave blank if you're not sure.)

[ ] Workspace.  VSCode workspace, vaults, Intellisense/autocomplete, Dendron settings
[ ] Lookup.  Dendron's Lookup Command
[ ] Views.  Dendron Preview, Tree View, Side Panels in the UI
[ ] Schema.  Dendron Schemas
[ ] Pod.  Data import from / export to Dendron
[ ] Publish.  External Site Publish
[ ] Markdown.  Markdown features, such as syntax support and features

Describe the bug
Running the Insert note index command in the root.md note includes #undefined in the list of children:
## Index

- [[Areas|a]]
- [[Archive|archive]]
- [[Daily|daily]]
- [[Inbox|inbox]]
- [[Projects|p]]
- [[People|people]]
- [[Resources|r]]
- #undefined
- [[Scratch|scratch]]

Doesn't happen in any other note I checked.
To Reproduce
Steps to reproduce the behavior:

Go to the root.md
Run Dendron: Insert Note Index
Observed that there is #undefined in the index list

Expected behavior
#undefined should not be in the list of children
Desktop (please complete the following information)

Version: 0.79

hmm, this is interesting. have not been able to reproduce. can you see what note shows up in lookup right above scratch for you?

tags is above scratch and that's the only one that's not in the list (I didn't realize it before). If I remove this hierarchy, the #undefined entry also goes away; if I rename tags to something else, the new item is included in the index instead #undefined. Also, it doesn't make a difference if tags is a stub or not.

I work on this bug.

https://github.com/dendronhq/dendron/pull/2789


vue 2?

Hello, thanks for component, very good.
But one question: How to use in Vue 2? Or have alternative this component for Vue 2?
Thanks

Hi Fabio,
Thank you for your kind comment. made me very happy. You know vue official version is 3. So I wrote for only vue3. But I planned to write for Vue2. Added my backlog. If you need a form wizard library you can check this. Very popular library for Vue2. https://binarcode.github.io/vue-form-wizard/#/

Any update on vue2?


Generalize Menu Logic

Context--
Typeaheads were created and then some parts of the code were reused/adapted for the AutoEmbed menus. This led to a lot of extra code in the LexicalTypeaheadMenuPlugin.tsx.
So in preparation for the upcoming LexicalContextMenuPlugin I've generalized the core menu logic into LexicalMenus.ts and separated the LexicalNodeMenuPlugin that's used by Embeds into it's own file.
Nothing functionally changed here. Things were just moved around/renamed to be more clear.
You can see this in action on the new-context-menu-v1 branch which will have PRs coming soon.

LGTM, but I don't think we can merge this just yet as removing modules is a breaking change. Do you want to keep the old modules for now or you want to prioritize the next Lexical version?

LGTM

@tylerjbainbridge Great it broke the < .10 version because of this rename no value added besides renames.


adding semantic search feature to the web

API is ready thanks to Fatih, all we need to do is add the correct mapping and servlets.

Done with commit: https://github.com/bounswe/bounswe2015group7/commit/fb5a6c3e17ac6e809ca42f93ed345bae37380311


chore: exclude sampleRUM from coverage

WIP - sampleRUM first basic test
@trieloff I am not sure on how to test all sampleRUM capabilities and features. It would be great if you could write tests to reach 100% of coverage (currently 71%).
Note that the change to web-test-runner.config.js has to be reverted once 100% is hit. Testing only the rum code is the easiest solution I have found to know the current coverage on the rum area.

Oh, I just saw https://github.com/adobe/aem-lib/issues/2 - maybe the code will even go away, thus no test required in this repo.
@chicharr @trieloff ... ?

Ok, I have updated the PR to exclude rum.js from coverage since the code will come from https://github.com/adobe/helix-rum-js (tracked in #2). I have also created a draft PR to initiate the testing work on sampleRUM (see https://github.com/adobe/helix-rum-js/pull/93).


Update to newer versions of Node.js and start using some ES7 features

I think that, since we're using Electron, we could be able to start using newer features of ES without having problems. What do you think?
Other option could be using TypeScript if you're into that...

Yeah, @peterdouglas has the same purpose #195. I agree we need to switch to ES6/7, but I think Typescript is not a good choice for angular v1

Yes, do it. But please make a new branch and commit step-by-step.

@luciorubeens is turning into true ARKer with meme addiction 😂


Create Monitoring System Helm Chart

Sub-issue of #876
If possible (which is should be).  Create a Helm chart to deploy the kraken monitoring system (vs the initial example scripts).
It should conform to our Helm chart set up.

pat to move to issues repo

moved to samsung-cnct/issues#76


common-updater-scripts: add fetchgit support

When I try to update some package that uses fetchgit, it fails.
$ update-source-version volume_key 0.3.12
error: attribute 'urls' missing, at (string):1:37
update-source-versions: error: Couldn't evaluate source url from 'volume_key.name'!

This was fixed by @NeQuissimus in https://github.com/NixOS/nixpkgs/commit/cce486838b6c52dedfec1c93f60ebadb72c48431

My bad, I had not even seen this issue before :)
I did run into the same thing and just fixed it :D


Recent ndk-sys yank is breaking CI.

Checksum is failing on ndk-sys 0.4.0.
https://github.com/Zageron/rrr/actions/runs/3529598287/jobs/5920752227
Etc...

So it seems that the problem is that there is a version 0.4.0 and a version 0.4.0+25.0.8775105 on crates.io.
Apparently, the code in cargo get confused because the two version compare the same.
Cf  https://github.com/rust-lang/cargo/issues/6504 https://github.com/rust-lang/crates.io/issues/1059 https://github.com/rust-lang/cargo/issues/7180
The immediate solution would be to release ndk-sys 0.4.1 as soon as possible (I recommend re-publishing 0.4.0 as 0.4.1)

Duplicate of #368, and the offending crate has been yanked: I cannot repro this locally with a cargo update on a crate that consumes ndk-sys.
Could this possibly exhibit itself when an a cargo update (or in general downloading the initial crates.io index) was performed while the broken 0.4.0+25.0.8775105 release was live, leading to the crate being downloaded into ~/.cargo and considered by commands like cargo metadata going forward? That sounds like a followup cargo bug if it isn't able to recover from having previously downloaded a broken crate that's now been yanked, when it should instead be disregarded completely.
(None of the links shared by @ogoffart seem to describe this, but crates.io should disallow such publishes anyway :no_mouth:)
I was anyway planning on releasing a 0.4.1+23.1.7779620 to represent the version of the previous release, if that helps. Going forward we'll have to think more carefully about bumping this metadata version as our CI will immediately publish it as a release; any version upgrades should just be a release at that point.

I think there is a race condition in cargo and the bug happens only sometimes when downloading the crates from fresh cargo cache.
But now that 0.4.1+23.1.7779620 is released, the problem should be solved.
thank you!

I think there is a race condition in cargo

Is this reported upstream somewhere?

and the bug happens only sometimes when downloading the crates from fresh cargo cache.

Right, the CI run linked by @Zageron above indicates No cache found.; that CI run is from a few hours ago, well after I yanked the broken release yesterday which is strange to say the least.

But now that 0.4.1+23.1.7779620 is released, the problem should be solved. thank you!

Thanks, I'll close this as completed then unless you want to confirm it first!
(Confirmed to build and run fine on my crates)

Hah I'm also running into the exact same issue randomly, perhaps because of still being Cargo.lock'ed into 0.4.0, despite (again) this crate being yanked well over a day ago and the ~/.cargo` cache being completely empty/fresh. :disappointed:

Reopening this because it's super easy to repro. On a cleaned ~/.cargo, all I need to do is force use of 0.4.0 (not 0.4.1!) with the semver string "=0.4.0" or use a Cargo.lock fixed (not yet updated) to 0.4.1. Then try to build, and before it even downloads the crate:
  Downloaded ndk-sys v0.4.0
error: failed to verify the checksum of `ndk-sys v0.4.0`

(There's no ndk-sys folder anywhere inside ~/.cargo/registry/{cache,src}/github.com-1ecc6299db9ec823/)

See also: https://github.com/rust-lang/cargo/issues/11412

Please update file ndk-glue/Cargo.toml to reference version ndk-sys v0.4.1
On https://github.com/rust-lang/cargo/issues/7180 it is mentioned
"I have since published 0.4.1 to help users resolve this issue,"

Not hearing anyone about this issue anymore, hoping it is resolved now (and will be much more careful pushing version changes in the future)! :crossed_fingers:


Do not overwrite roepnaam

This issue is imported from pivotal
The roepnaam should always be the self-asserted name. Only the last name and the formal first name are overwritten upon linking

(Peter Havekes - Oct 13, 2023)


Show error message when request fails.

Seems to be issue when starting end editing things in dropdown. It is possible to do so even if the network connection is not up.
Should:

handle the error
show error message to user
(bonus) queue the request for re-sync.

Improved error handling added with 5bff5fc9073db078174a703e3eb8112d795895ad
Offline store has another issue #507


Supported Gherkin version

Question: Does godog support Gherkin v6. I see in Readme that godog supports gherkin3. Is it same as gherkin version 3?

yes it is v3. the reason why it is not upgraded to v6 is the dependency of protobuf. I prefer that this library would not have any external dependencies. In later versions, there are some different keyword support and Rule keyword, which could be migrated at some point. But that will be done sometime later. Though, to resolve some concurrency issues you also referenced, the gherkin nodes should be linked by parent node or additional abstraction layer needs to be made. anyway, these all have something to do with gherkin. Sadly, I do not want the protobuf dependency for this library

Thanks for the prompt reply


Print error message from request, if clipboardRequest return an error

@cekk change log, please!

https://www.ueu.eus/ is suffering intermittent ISE 500 errors. Is that one of @erral's sites?

it is. we are looking at it

@cekk change log, please!

You're right..i didn't found the news folder with this new structure ;)
Added it

@cekk indeed @jensens also stumbled on it, and we updated the docs in hopes it made it easier to find in Change log entry. Sorry I didn't give that link, as I assumed you already knew.
Also @erral says a bad bot was hammering their site, and it should pass now.
If it's green, let's merge!

Acceptance Tests / Core Blocks - Listing (18.x) (push) is flaky. I restarted it.

All green!


frontend deleted

the frontend is deleted so can you give me the file?

You need frontend of this URL Shortening Service?

yes

Fork this repo https://github.com/abhishekraj272/Shotly-URL-Shortner-Frontend
@Crypto195


Is there a way to not "inspect" the expected output when it fails?

I'm using rspec to test build deploys which are very verbose. I want the full output when it fails because it's very valuable for debugging, but when an expectation fails it looks like it is "inspect"-ed so it shows up with newlines like this and is largely unreadable:
     Failure/Error: ]


Programming exercises: Add GenAI feedback requests

Checklist
General

[ ] I tested all changes and their related features with all corresponding user types on a test server.
[ ] This is a small issue that I tested locally and was confirmed by another developer on a test server.
[x] Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
[x] I chose a title conforming to the naming conventions for pull requests.

Server

[x] Important: I implemented the changes with a very good performance and prevented too many (unnecessary) database calls.
[x] I strictly followed the server coding and design guidelines.
[x] I added multiple integration tests (Spring) related to the features (with a high test coverage).
[x] I added pre-authorization annotations according to the guidelines and checked the course groups for all new REST Calls (security).
[x] I documented the Java code using JavaDoc style.

Client

[x] Important: I implemented the changes with a very good performance, prevented too many (unnecessary) REST calls and made sure the UI is responsive, even with large data.
[x] I strictly followed the client coding and design guidelines.
[x] Following the theming guidelines, I specified colors only in the theming variable files and checked that the changes look consistent in both the light and the dark theme.
[ ] I added multiple integration tests (Jest) related to the features (with a high test coverage), while following the test guidelines.
[x] I added authorities to all new routes and checked the course groups for displaying navigation elements (links, buttons).
[ ] I documented the TypeScript code using JSDoc style.
[x] I added multiple screenshots/screencasts of my UI changes.
[x] I translated all newly inserted strings into English and German.

Changes affecting Programming Exercises

[ ] High priority: I tested all changes and their related features with all corresponding user types on a test server configured with the integrated lifecycle setup (LocalVC and LocalCI).
[ ] I tested all changes and their related features with all corresponding user types on a test server configured with Gitlab and Jenkins.
[ ] I tested all changes and their related features with all corresponding user types on a test server configured with Bitbucket and Bamboo.

Motivation and Context
In Artemis, it is currently possible to enhance the learning experience of students by providing the option to request feedback from a tutor before the assignment deadline, provided that 100% of the auto-tests have been passed. This process requires the involvement of a human tutor, which needs certain resources and takes some time. With the development of LLMs, this process can be automated and made more convenient for students by introducing automatic non-graded feedback requests. This feedback is automatically generated by LLM and has no impact on the grade.
Assumption: Athena suggestions are turned on and a module with feedback suggestions support is set.
Description
Server Side Changes:

The AthenaFeedbackSuggestionsService can now send requests for both graded and non-graded feedback.
Introduced a new service, ProgrammingExerciseCodeReviewFeedbackService. If the Athena profile is active and an Athena programming module for the exercise is set, this service will send out feedback requests to it. Otherwise, it will create normal tutor feedback requests.
This service also processes the results from Athena and sends WebSocket messages to notify users about the latest results.
Introduced a new assessment type: AUTOMATIC_ATHENA.

Client Side Changes:

On the exercise creation page, I renamed the checkbox to "Allow manual feedback requests."
Modified the text of the button used to request manual feedback.
Modified the result overview component to correctly display feedback items.
Introduced logic for automated feedback requests: the status of feedback requests will be shown on the results timeline and updated accordingly. Success, failure, and timed-out results will be displayed.
Changed the code editor: no points will be shown for AI-generated feedback.
The building and loading/last result indicator does not include AI-generated feedback.

Prerequisites:

1 Instructor
1 Student
1 Programming Exercise

Steps for Testing
Test case 1:

Setup and Preliminaries:

As an Instructor:

Log into the test server where Athena is not active.

Navigate to the area where you can create a new programming exercise.

Create a programming exercise and ensure the option "Allow manual feedback requests" is available and selected. Note: Make sure that the relevant checkboxes or tooltips are correctly set.

Testing Manual Feedback Requests and Indicators:

As a Student:

Complete the programming exercise ensuring a 100% score in auto-tests.

Request manual feedback once the auto-tests are successfully passed.

Observe the building and loading indicator; ensure it does not represent non-graded submissions.

Check the text of the request button and its tooltip for accuracy and relevance to manual feedback.

Ensure that the process completes without any errors.

Assessment and Feedback Review:

As an Instructor:

Go to the assessment dashboard.

Find the submission from the student who requested manual feedback.

Grade the submission.

Back as a Student:

Check the results timeline and the code editor to ensure the graded submission is visible.

Verify that the building and loading indicator reflects the newly graded result accurately.

Confirm that all details, including scores and instructor comments, are clearly visible and correctly displayed in both the results timeline and code editor.

As an Instructor:

Set the due date to the past.

Student:

Make sure that the send feedback button is disabled.

Test case 2

Setup and Preliminaries:

As an Instructor:

Log into the test server where Athena is active. Confirm that the corresponding version of Athena is deployed.

Navigate to the area where you can create a course and enable restricted modules.

Proceed to the area for creating a new programming exercise.

Create a programming exercise ensuring the option "Allow automatic feedback requests" is available and selected. Opt for Athena suggested feedback and choose module_programming_llm.

Testing Automatic Feedback Requests and Indicators:

As a Student:

Complete the programming exercise ensuring a 100% score in auto-tests.

Request automatic feedback after successfully passing the auto-tests.

Observe the building and loading indicators during the request; ensure they represent only the current state of submissions and do not include non-graded submissions.

Check the text of the request button and its tooltip for accuracy, ensuring they reflect the option for automatic feedback.

Confirm that the entire process completes without any errors.

Case Distinctions(case 2&3 only if you know what to do):

Different Feedback Request Outcomes:

Successful Feedback: Ensure everything completes successfully.

Interrupted Request: Attempt to interrupt the feedback request (e.g., by shutting down Athena, providing a non-valid configuration locally, etc.) and ensure the result is marked as failed.

Timeout Case: Modify the corresponding database entry to simulate a timeout scenario: set the completion date to the near future and jhi_successful to null. Reload the page to ensure the status is "processing". Without reloading, confirm that the status updates to "timed out" after the set time. Reload the page to check if the status remains "timed out".

Assessment and Feedback Visibility:

Check the results timeline and the code editor to ensure the non-graded submission is visible.

Verify that the building and loading indicator does not reflect the newly graded result since it should not include AI-generated feedback.

Confirm that all details, including non-graded feedback messages, are clearly visible and correctly displayed in both the code editor and in the results timeline.

Testserver States

[!NOTE]
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked

Review Progress

Performance Review

[ ] I (as a reviewer) confirm that the client changes (in particular related to REST calls and UI responsiveness) are implemented with a very good performance
[ ] I (as a reviewer) confirm that the server changes (in particular related to database calls) are implemented with a very good performance

Code Review

[ ] Code Review 1
[ ] Code Review 2

Manual Tests

[ ] Test 1
[ ] Test 2

Exam Mode Test

[ ] Test 1
[ ] Test 2

Test Coverage

Screenshots
Location of the button:

The results then look like this:

Pay attention on the timeline:

If Athena is available, make sure these checkboxes and fields are set as on the screenshots:

Summary by CodeRabbit

Refactor

Enhanced import statements for improved clarity and consistency across files.
Renamed method getAllowManualFeedbackRequests() to getAllowFeedbackRequests() for better readability in exercises.
Improved assessment and result handling in programming exercises to support automatic AI results.

New Features

Introduced Profile_ATHENA and AssessmentType imports in the student actions component for enhanced functionality.
Added faPenSquare icon and assureConditionsSatisfied method to the student actions component.

Tests

Refactored tests for feedback request button logic and added new tests for conditions satisfaction alerts in the student actions component.

Documentation

Added a conditional block in the feedback component HTML template to display a tooltip based on the assessment type.

It seems I can request feedback even when the preliminary score isn't 100%. Is this intended? Perhaps you could adjust the tooltip to be more consistent with the manual feedback request button.

Yes, this requirement has changed recently. Thanks for pointing this out - will adapt the PR description and the tooltips.


[improve][dependency] Upgrade JNA to 5.12.1

Motivation
JLine3 doesn't work well with current JNA version on Windows. It's a requirement for https://github.com/apache/pulsar/pull/17243
Modifications

Upgrade JNA from 4.2.0 to 5.12.1

Note that this lib is also used by the ZK cli. I tested it and it still works correctly after the upgrade.

[x] doc-not-needed

OWASP check failure due to https://github.com/apache/pulsar/pull/17282


[BUG] Error building cpu_adam

Describe the bug
hello everyone,
when I use the DeepSpeed integration with HuggingFace's Trainer integration on my server with two 32GB V100 GPUs，I get the error 'RuntimeError: Error building extension 'cpu_adam' '. I have taken a look at similar issues #889 #2268, but it doesn't works.
Here's the part of the code I'm running:
import deepspeed
deepspeed.ops.op_builder.CPUAdamBuilder().load()

training_args = TrainingArguments(
    output_dir=output_dir,
    num_train_epochs=3,
    per_device_train_batch_size=1,
    per_device_eval_batch_size=2,
    eval_steps=20,
    save_steps=20,
    warmup_steps=100,
    learning_rate=5e-6,
    fp16=True,
    do_train=True,
    do_eval=True,
    deepspeed='deepspeed_config.json',
    save_strategy='steps',
    save_total_limit=3,
    evaluation_strategy='steps',
    load_best_model_at_end=True,
    metric_for_best_model='rouge-l',
    logging_steps=50,
    logging_dir='./logs')
trainer = MyTrainer(
    model,
    training_args,
    train_dataset=train_dataloader,
    eval_dataset=dev_dataloader,
    data_collator=collate_fn,
    tokenizer=tokenizer
    )

trainer.train()

deepspeed_config.json
{
  "train_micro_batch_size_per_gpu": 1,
  "gradient_accumulation_steps": 1,
  "steps_per_print": 50,
  "gradient_clipping": 1.0,
  "zero_optimization": {
    "stage": 2,
    "contiguous_gradients": false,
    "overlap_comm": true,
    "reduce_scatter": true,
    "reduce_bucket_size": 5e7,
    "allgather_bucket_size": 5e7,
    "cpu_offload": true
  },
  "zero_allow_untested_optimizer": true,
  "fp16": {
    "enabled": true,
    "loss_scale": 0,
    "loss_scale_window": 1000,
    "hysteresis": 2,
    "min_loss_scale": 1
  },
  "optimizer": {
    "type": "Adamw",
    "params": {
      "lr": 5e-6,
      "betas": [
        0.9,
        0.999
      ],
      "eps": 1e-8
    }
  },
  "activation_checkpointing": {
    "partition_activations": false,
    "contiguous_memory_optimization": false
  },
  "wall_clock_breakdown": false
}

error information
(/home/whzhu_st/mypython) whzhu_st@s3:~/Pytorch/GPT/GLM$ python train_glm_finetune.py
Using /home/whzhu_st/.cache/torch_extensions as PyTorch extensions root...
Detected CUDA files, patching ldflags
Emitting ninja build file /home/whzhu_st/.cache/torch_extensions/cpu_adam/build.ninja...
Building extension module cpu_adam...
Allowing ninja to set a default number of workers... (overridable by setting the environment variable MAX_JOBS=N)
[1/2] /usr/local/cuda-11.1/bin/nvcc  -DTORCH_EXTENSION_NAME=cpu_adam -DTORCH_API_INCLUDE_EXTENSION_H -DPYBIND11_COMPILER_TYPE=\"_gcc\" -DPYBIND11_STDLIB=\"_libstdcpp\" -DPYBIND11_BUILD_ABI=\"_cxxabi1011\" -I/home/whzhu_st/mypython/lib/python3.8/site-packages/deepspeed/ops/csrc/includes -I/usr/local/cuda-11.1/include -isystem /home/whzhu_st/mypython/lib/python3.8/site-packages/torch/include -isystem /home/whzhu_st/mypython/lib/python3.8/site-packages/torch/include/torch/csrc/api/include -isystem /home/whzhu_st/mypython/lib/python3.8/site-packages/torch/include/TH -isystem /home/whzhu_st/mypython/lib/python3.8/site-packages/torch/include/THC -isystem /usr/local/cuda-11.1/include -isystem /home/whzhu_st/mypython/include/python3.8 -D_GLIBCXX_USE_CXX11_ABI=0 -D__CUDA_NO_HALF_OPERATORS__ -D__CUDA_NO_HALF_CONVERSIONS__ -D__CUDA_NO_BFLOAT16_CONVERSIONS__ -D__CUDA_NO_HALF2_OPERATORS__ --expt-relaxed-constexpr -gencode=arch=compute_70,code=compute_70 -gencode=arch=compute_70,code=sm_70 --compiler-options '-fPIC' -O3 --use_fast_math -std=c++14 -U__CUDA_NO_HALF_OPERATORS__ -U__CUDA_NO_HALF_CONVERSIONS__ -U__CUDA_NO_HALF2_OPERATORS__ -gencode=arch=compute_70,code=sm_70 -gencode=arch=compute_70,code=compute_70 -c /home/whzhu_st/mypython/lib/python3.8/site-packages/deepspeed/ops/csrc/common/custom_cuda_kernel.cu -o custom_cuda_kernel.cuda.o
FAILED: custom_cuda_kernel.cuda.o
/usr/local/cuda-11.1/bin/nvcc  -DTORCH_EXTENSION_NAME=cpu_adam -DTORCH_API_INCLUDE_EXTENSION_H -DPYBIND11_COMPILER_TYPE=\"_gcc\" -DPYBIND11_STDLIB=\"_libstdcpp\" -DPYBIND11_BUILD_ABI=\"_cxxabi1011\" -I/home/whzhu_st/mypython/lib/python3.8/site-packages/deepspeed/ops/csrc/includes -I/usr/local/cuda-11.1/include -isystem /home/whzhu_st/mypython/lib/python3.8/site-packages/torch/include -isystem /home/whzhu_st/mypython/lib/python3.8/site-packages/torch/include/torch/csrc/api/include -isystem /home/whzhu_st/mypython/lib/python3.8/site-packages/torch/include/TH -isystem /home/whzhu_st/mypython/lib/python3.8/site-packages/torch/include/THC -isystem /usr/local/cuda-11.1/include -isystem /home/whzhu_st/mypython/include/python3.8 -D_GLIBCXX_USE_CXX11_ABI=0 -D__CUDA_NO_HALF_OPERATORS__ -D__CUDA_NO_HALF_CONVERSIONS__ -D__CUDA_NO_BFLOAT16_CONVERSIONS__ -D__CUDA_NO_HALF2_OPERATORS__ --expt-relaxed-constexpr -gencode=arch=compute_70,code=compute_70 -gencode=arch=compute_70,code=sm_70 --compiler-options '-fPIC' -O3 --use_fast_math -std=c++14 -U__CUDA_NO_HALF_OPERATORS__ -U__CUDA_NO_HALF_CONVERSIONS__ -U__CUDA_NO_HALF2_OPERATORS__ -gencode=arch=compute_70,code=sm_70 -gencode=arch=compute_70,code=compute_70 -c /home/whzhu_st/mypython/lib/python3.8/site-packages/deepspeed/ops/csrc/common/custom_cuda_kernel.cu -o custom_cuda_kernel.cuda.o
gcc: fatal error: cannot execute ‘cc1plus’: execvp: No such file or directory
compilation terminated.
nvcc fatal   : Failed to preprocess host compiler properties.
ninja: build stopped: subcommand failed.
Traceback (most recent call last):
  File "/home/whzhu_st/mypython/lib/python3.8/site-packages/torch/utils/cpp_extension.py", line 1666, in _run_ninja_build
    subprocess.run(
  File "/home/whzhu_st/mypython/lib/python3.8/subprocess.py", line 516, in run
    raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['ninja', '-v']' returned non-zero exit status 1.

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "train_glm_finetune.py", line 115, in <module>
    deepspeed.ops.op_builder.CPUAdamBuilder().load()
  File "/home/whzhu_st/mypython/lib/python3.8/site-packages/deepspeed/ops/op_builder/builder.py", line 485, in load
    return self.jit_load(verbose)
  File "/home/whzhu_st/mypython/lib/python3.8/site-packages/deepspeed/ops/op_builder/builder.py", line 520, in jit_load
    op_module = load(
  File "/home/whzhu_st/mypython/lib/python3.8/site-packages/torch/utils/cpp_extension.py", line 1080, in load
    return _jit_compile(
  File "/home/whzhu_st/mypython/lib/python3.8/site-packages/torch/utils/cpp_extension.py", line 1293, in _jit_compile
    _write_ninja_file_and_build_library(
  File "/home/whzhu_st/mypython/lib/python3.8/site-packages/torch/utils/cpp_extension.py", line 1405, in _write_ninja_file_and_build_library
    _run_ninja_build(
  File "/home/whzhu_st/mypython/lib/python3.8/site-packages/torch/utils/cpp_extension.py", line 1682, in _run_ninja_build
    raise RuntimeError(message) from e
RuntimeError: Error building extension 'cpu_adam'

System info :
Linux version 4.15.0-163-generic (buildd@lcy01-amd64-021) (gcc version 7.5.0 (Ubuntu 7.5.0-3ubuntu1~18.04)) #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021

GPU: one machine with x2 32GB V100
Python version: 3.8
torch、cuda version: 1.91、11.1

Thanks in advance for your help!

Hello @taofennanhai. The log line gcc: fatal error: cannot execute ‘cc1plus’: execvp: No such file or directory indicates the missing g++ package.
Please refer to https://stackoverflow.com/questions/39455741/gcc-error-trying-to-exec-cc1plus-execvp-no-such-file-or-directory for different ways to install g++.
After installing, you can try g++ -v to see if g++ is correctly installed.
Please feel free to reopen this issue if you still get this error after installing g++

Hello @taofennanhai. The log line gcc: fatal error: cannot execute ‘cc1plus’: execvp: No such file or directory indicates the missing g++ package. Please refer to https://stackoverflow.com/questions/39455741/gcc-error-trying-to-exec-cc1plus-execvp-no-such-file-or-directory for different ways to install g++. After installing, you can try g++ -v to see if g++ is correctly installed. Please feel free to reopen this issue if you still get this error after installing g++

Thanks for your reply! I am sure that g++ has been installed.The mechine can execute g++ -v and gcc -v commands, but it still report same error. Do I need a higher gcc or g++ version?
gcc (Ubuntu 9.4.0-1ubuntu1~20.04.1) 9.4.0
Copyright (C) 2019 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

(/home/whzhu_st/mypython) whzhu_st@s3:~/Pytorch/GPT/GLM$ g++ --version
g++ (Ubuntu 9.4.0-1ubuntu1~20.04.1) 9.4.0
Copyright (C) 2019 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

(/home/whzhu_st/mypython) whzhu_st@s3:~/Pytorch/GPT/GLM$ python train_glm_finetune.py
[2023-03-25 05:02:27,948] [INFO] [comm.py:634:init_distributed] Not using the DeepSpeed or dist launchers, attempting to detect MPI environment...
[2023-03-25 05:02:28,319] [INFO] [comm.py:688:mpi_discovery] Discovered MPI settings of world_rank=0, local_rank=0, world_size=1, master_addr=<IP_ADDRESS>, master_port=29500
[2023-03-25 05:02:28,319] [INFO] [comm.py:652:init_distributed] Initializing TorchBackend in DeepSpeed with backend nccl
Explicitly passing a `revision` is encouraged when loading a model with custom code to ensure no malicious code has been contributed in a newer revision.
Explicitly passing a `revision` is encouraged when loading a configuration with custom code to ensure no malicious code has been contributed in a newer revision.
Explicitly passing a `revision` is encouraged when loading a model with custom code to ensure no malicious code has been contributed in a newer revision.
Using cuda_amp half precision backend
[2023-03-25 05:02:32,549] [INFO] [logging.py:93:log_dist] [Rank 0] DeepSpeed info: version=0.8.3, git-hash=unknown, git-branch=unknown
[2023-03-25 05:02:32,552] [WARNING] [config_utils.py:75:_process_deprecated_field] Config parameter cpu_offload is deprecated use offload_optimizer instead
[2023-03-25 05:02:36,472] [INFO] [logging.py:93:log_dist] [Rank 0] DeepSpeed Flops Profiler Enabled: False
Using /home/whzhu_st/.cache/torch_extensions as PyTorch extensions root...
Detected CUDA files, patching ldflags
Emitting ninja build file /home/whzhu_st/.cache/torch_extensions/cpu_adam/build.ninja...
Building extension module cpu_adam...
Allowing ninja to set a default number of workers... (overridable by setting the environment variable MAX_JOBS=N)
[1/2] /usr/local/cuda-11.1/bin/nvcc  -ccbin /home/whzhu_st/mypython/bin/x86_64-conda-linux-gnu-cc -DTORCH_EXTENSION_NAME=cpu_adam -DTORCH_API_INCLUDE_EXTENSION_H -DPYBIND11_COMPILER_TYPE=\"_gcc\" -DPYBIND11_STDLIB=\"_libstdcpp\" -DPYBIND11_BUILD_ABI=\"_cxxabi1011\" -I/home/whzhu_st/mypython/lib/python3.8/site-packages/deepspeed/ops/csrc/includes -I/usr/local/cuda-11.1/include -isystem /home/whzhu_st/mypython/lib/python3.8/site-packages/torch/include -isystem /home/whzhu_st/mypython/lib/python3.8/site-packages/torch/include/torch/csrc/api/include -isystem /home/whzhu_st/mypython/lib/python3.8/site-packages/torch/include/TH -isystem /home/whzhu_st/mypython/lib/python3.8/site-packages/torch/include/THC -isystem /usr/local/cuda-11.1/include -isystem /home/whzhu_st/mypython/include/python3.8 -D_GLIBCXX_USE_CXX11_ABI=0 -D__CUDA_NO_HALF_OPERATORS__ -D__CUDA_NO_HALF_CONVERSIONS__ -D__CUDA_NO_BFLOAT16_CONVERSIONS__ -D__CUDA_NO_HALF2_OPERATORS__ --expt-relaxed-constexpr -gencode=arch=compute_70,code=compute_70 -gencode=arch=compute_70,code=sm_70 --compiler-options '-fPIC' -O3 --use_fast_math -std=c++14 -U__CUDA_NO_HALF_OPERATORS__ -U__CUDA_NO_HALF_CONVERSIONS__ -U__CUDA_NO_HALF2_OPERATORS__ -gencode=arch=compute_70,code=sm_70 -gencode=arch=compute_70,code=compute_70 -c /home/whzhu_st/mypython/lib/python3.8/site-packages/deepspeed/ops/csrc/common/custom_cuda_kernel.cu -o custom_cuda_kernel.cuda.o
FAILED: custom_cuda_kernel.cuda.o
/usr/local/cuda-11.1/bin/nvcc  -ccbin /home/whzhu_st/mypython/bin/x86_64-conda-linux-gnu-cc -DTORCH_EXTENSION_NAME=cpu_adam -DTORCH_API_INCLUDE_EXTENSION_H -DPYBIND11_COMPILER_TYPE=\"_gcc\" -DPYBIND11_STDLIB=\"_libstdcpp\" -DPYBIND11_BUILD_ABI=\"_cxxabi1011\" -I/home/whzhu_st/mypython/lib/python3.8/site-packages/deepspeed/ops/csrc/includes -I/usr/local/cuda-11.1/include -isystem /home/whzhu_st/mypython/lib/python3.8/site-packages/torch/include -isystem /home/whzhu_st/mypython/lib/python3.8/site-packages/torch/include/torch/csrc/api/include -isystem /home/whzhu_st/mypython/lib/python3.8/site-packages/torch/include/TH -isystem /home/whzhu_st/mypython/lib/python3.8/site-packages/torch/include/THC -isystem /usr/local/cuda-11.1/include -isystem /home/whzhu_st/mypython/include/python3.8 -D_GLIBCXX_USE_CXX11_ABI=0 -D__CUDA_NO_HALF_OPERATORS__ -D__CUDA_NO_HALF_CONVERSIONS__ -D__CUDA_NO_BFLOAT16_CONVERSIONS__ -D__CUDA_NO_HALF2_OPERATORS__ --expt-relaxed-constexpr -gencode=arch=compute_70,code=compute_70 -gencode=arch=compute_70,code=sm_70 --compiler-options '-fPIC' -O3 --use_fast_math -std=c++14 -U__CUDA_NO_HALF_OPERATORS__ -U__CUDA_NO_HALF_CONVERSIONS__ -U__CUDA_NO_HALF2_OPERATORS__ -gencode=arch=compute_70,code=sm_70 -gencode=arch=compute_70,code=compute_70 -c /home/whzhu_st/mypython/lib/python3.8/site-packages/deepspeed/ops/csrc/common/custom_cuda_kernel.cu -o custom_cuda_kernel.cuda.o
x86_64-conda-linux-gnu-cc: fatal error: cannot execute 'cc1plus': execvp: No such file or directory
compilation terminated.
nvcc fatal   : Failed to preprocess host compiler properties.
ninja: build stopped: subcommand failed.
Traceback (most recent call last):
  File "/home/whzhu_st/mypython/lib/python3.8/site-packages/torch/utils/cpp_extension.py", line 1666, in _run_ninja_build
    subprocess.run(
  File "/home/whzhu_st/mypython/lib/python3.8/subprocess.py", line 516, in run
    raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['ninja', '-v']' returned non-zero exit status 1.

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "train_glm_finetune.py", line 168, in <module>
    trainer.train()
  File "/home/whzhu_st/Pytorch/GPT/GLM/transformers/src/transformers/trainer.py", line 1498, in train
    return inner_training_loop(
  File "/home/whzhu_st/Pytorch/GPT/GLM/transformers/src/transformers/trainer.py", line 1567, in _inner_training_loop
    deepspeed_engine, optimizer, lr_scheduler = deepspeed_init(
  File "/home/whzhu_st/Pytorch/GPT/GLM/transformers/src/transformers/deepspeed.py", line 344, in deepspeed_init
    deepspeed_engine, optimizer, _, lr_scheduler = deepspeed.initialize(**kwargs)
  File "/home/whzhu_st/mypython/lib/python3.8/site-packages/deepspeed/__init__.py", line 125, in initialize
    engine = DeepSpeedEngine(args=args,
  File "/home/whzhu_st/mypython/lib/python3.8/site-packages/deepspeed/runtime/engine.py", line 340, in __init__
    self._configure_optimizer(optimizer, model_parameters)
  File "/home/whzhu_st/mypython/lib/python3.8/site-packages/deepspeed/runtime/engine.py", line 1283, in _configure_optimizer
    basic_optimizer = self._configure_basic_optimizer(model_parameters)
  File "/home/whzhu_st/mypython/lib/python3.8/site-packages/deepspeed/runtime/engine.py", line 1354, in _configure_basic_optimizer
    optimizer = DeepSpeedCPUAdam(model_parameters,
  File "/home/whzhu_st/mypython/lib/python3.8/site-packages/deepspeed/ops/adam/cpu_adam.py", line 96, in __init__
    self.ds_opt_adam = CPUAdamBuilder().load()
  File "/home/whzhu_st/mypython/lib/python3.8/site-packages/deepspeed/ops/op_builder/builder.py", line 485, in load
    return self.jit_load(verbose)
  File "/home/whzhu_st/mypython/lib/python3.8/site-packages/deepspeed/ops/op_builder/builder.py", line 520, in jit_load
    op_module = load(
  File "/home/whzhu_st/mypython/lib/python3.8/site-packages/torch/utils/cpp_extension.py", line 1080, in load
    return _jit_compile(
  File "/home/whzhu_st/mypython/lib/python3.8/site-packages/torch/utils/cpp_extension.py", line 1293, in _jit_compile
    _write_ninja_file_and_build_library(
  File "/home/whzhu_st/mypython/lib/python3.8/site-packages/torch/utils/cpp_extension.py", line 1405, in _write_ninja_file_and_build_library
    _run_ninja_build(
  File "/home/whzhu_st/mypython/lib/python3.8/site-packages/torch/utils/cpp_extension.py", line 1682, in _run_ninja_build
    raise RuntimeError(message) from e
RuntimeError: Error building extension 'cpu_adam'
Exception ignored in: <function DeepSpeedCPUAdam.__del__ at 0x7fb9099ec940>`

Hello @taofennanhai. The log line gcc: fatal error: cannot execute ‘cc1plus’: execvp: No such file or directory indicates the missing g++ package. Please refer to https://stackoverflow.com/questions/39455741/gcc-error-trying-to-exec-cc1plus-execvp-no-such-file-or-directory for different ways to install g++. After installing, you can try g++ -v to see if g++ is correctly installed. Please feel free to reopen this issue if you still get this error after installing g++

ds_report information:
(/home/whzhu_st/mypython) whzhu_st@s3:~$ ds_report
--------------------------------------------------
DeepSpeed C++/CUDA extension op report
--------------------------------------------------
NOTE: Ops not installed will be just-in-time (JIT) compiled at
      runtime if needed. Op compatibility means that your system
      meet the required dependencies to JIT install the op.
--------------------------------------------------
JIT compiled ops requires ninja
ninja .................. [OKAY]
--------------------------------------------------
op name ................ installed .. compatible
--------------------------------------------------
 [WARNING]  async_io requires the dev libaio .so object and headers but these were not found.
 [WARNING]  async_io: please install the libaio-dev package with apt
 [WARNING]  If libaio is already installed (perhaps from source), try setting the CFLAGS and LDFLAGS environment variables to where it can be found.
async_io ............... [NO] ....... [NO]
cpu_adagrad ............ [NO] ....... [OKAY]
cpu_adam ............... [NO] ....... [OKAY]
fused_adam ............. [NO] ....... [OKAY]
fused_lamb ............. [NO] ....... [OKAY]
quantizer .............. [NO] ....... [OKAY]
random_ltd ............. [NO] ....... [OKAY]
 [WARNING]  please install triton==1.0.0 if you want to use sparse attention
sparse_attn ............ [NO] ....... [NO]
spatial_inference ...... [NO] ....... [OKAY]
transformer ............ [NO] ....... [OKAY]
stochastic_transformer . [NO] ....... [OKAY]
transformer_inference .. [NO] ....... [OKAY]
utils .................. [NO] ....... [OKAY]
--------------------------------------------------
DeepSpeed general environment info:
torch install path ............... ['/home/whzhu_st/mypython/lib/python3.8/site-packages/torch']
torch version .................... 1.9.1+cu111
deepspeed install path ........... ['/home/whzhu_st/mypython/lib/python3.8/site-packages/deepspeed']
deepspeed info ................... 0.8.3, unknown, unknown
torch cuda version ............... 11.1
torch hip version ................ None
nvcc version ..................... 11.1
deepspeed wheel compiled w. ...... torch 1.13, cuda 11.7

Hi @taofennanhai. In this case, maybe you have different versions of gcc and g++. Could you try running gcc -v and g++ -v and double check if their outputs are the same?

maybe you have different versions of gcc and g++. Could you try running gcc -v and g++ -v and double check if their outputs are the same?

Thanks for your reply! I solved this ploblem last weekend. The error reason may be that '/usr/bin' path of g++ is not in the environment variable PATH. Then I added it to the path, the error disappeared.
Finally, your team works very well. Look forward to future work!


⚠ Panel - Hydeos has degraded performance

In 8f6c7a0, Panel - Hydeos (https://pterodactyl.hydeos.fr) experienced degraded performance:

HTTP code: 200
Response time: 597 ms

Resolved: Panel - Hydeos performance has improved in dafee25 after 11 minutes.


Addition of EspalomaCharge method

An additional machine learning method was added. EspalomaCharge partial charge model added to predict AM1-BCC charges (https://doi.org/10.1039/D2SC02739A). Conda recipe for this package was also written.

Looking at your repo history, you were working on the latest commit, so no need to merge/rebase, but somehow used an old version of electrostatics.py - I assume that you didn't revert changes on purpose. Maybe reset electrostatics.py and then add back in the few new lines for the espaloma charges?


chore: update to @eslint-community/eslint-plugin-mysticatea

#20 was closed on accident when I removed alpha branch

Could you please fix the error in the test? I think you can refer to the fix in #20.


Allow argument suppressing without removing.

This PR delivers:

New method attribute HideAll
Support for masking all command line args if Main has the attribute and user specifies the hide term.
Tiny change to console app showing how it's used.

Intended to ease testing/debugging where developers/users can suppress all args easily yet leave them present in the debug settings (or .bat files, whatever). Just prepending 'rem' for example causes the system to act as if no args were supplied (thus showing help).

@adrianaisemberg - Hi, I added this while playing with your utility, made it easier for me to explore and test, it should be useful going forward but you may want to adjust it yourself, not sure.


(QA-2501) add ability to install hosts in parallel

Add :install_in_parallel option.  Default to false (existing behavior)
Run timesync in parallel if :install_in_parallel
Updated stop_agent_on to accept an array of hosts (as it was documented)
Updated sign_certificate_for to take an array of hosts (as it was documented)
install_puppet_on method now checks :install_in_parallel option
Added ability to run in parallel to run_block_on - closes host SSH connection in run_block_on after each parallel command is issued
Added run_in_parallel argument (defaulting to false) to:

run_block_on
block_on
on
install_puppet_agent_on
apply_manifest_on
stop_agent_on
execute_powershell_script_on

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker_btc-intn/2535/

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker_btc-intn/2537/

@puppetlabs-jenkins retest this please

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker_btc-intn/2538/

@puppetlabs-jenkins retest this please

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker_btc-intn/2540/

@puppetlabs-jenkins retest this please

@puppetlabs-jenkins retest this please

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker_btc-intn/2548/

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker_btc-intn/2547/

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker_btc-intn/2549/

@samwoods1 this PR needs acceptance tests; let's remove that label after they have been submitted for this work.

@samwoods1 Nice job, I like these changes.  Overall, I think we should pursue keeping this as an options in the various opts parameters, and we definitely need acceptance tests.  I'm happy to help with either!

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker_btc-intn/2558/

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker_btc-intn/2562/

@puppetlabs-jenkins retest this please

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker_btc-intn/2563/

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker_btc-intn/2564/

Much of the acceptance testing will be performed by this: https://jenkins-beaker.delivery.puppetlabs.net/job/In parallel job (In progress)/ which will execute some basic validation after running a parallel install for the following configurations: pe, pe with frictionless agent, FOSS. This will run on a matrix of agent OS's.  I'm looking at possibly doing some upgrade tests as well.

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker_btc-intn/2565/

@puppetlabs-jenkins retest this please

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker_btc-intn/2567/

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker_btc-intn/2566/

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker_btc-intn/2568/

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker_btc-intn/2569/

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker_btc-intn/2590/

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker_btc-intn/2615/

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker_btc-intn/2617/

@samwoods1, we were discussing the potential timing of merging & releasing this change earlier today, and were thinking of potentially giving it its own Y release, in order to minimize risk. This would be a follow-on to the June 29th currently planned release.
One thing that would be helpful from both a minimizing risk standpoint and a "getting your changes out faster" standpoint would be if you separated out the unrelated bugfixes from the parallel work. Then we could merge those into the next release, and make this as small as possible for it's own release. Is this something that you have time for?

@samwoods1 to summarize our discussion yesterday:

Alter/make configurable the behavior of in-parallel to wait for all forks to finish before raising exceptions; I think the default should be to fail "slow", so all forks have a chance to complete.

Add a default timeout for child process completion; this is just a failsafe so that something doesn't hang forever. I'm guessing that 30 min is a decent default to start with? I'm also assuming that this is something outside of the code in this PR...I'd love to take a look at that code when it's ready.

Solving the "in-parallel" level setting. We had talked about a none, conservative, and aggressive settings. I'm still unsure of what the best solution might be...

Overall, my ad hoc testing of this has been pretty good. I'm excited to merge in the functionality.

@kevpl  the only bug fixes I did were things that were required to do this work.  Was there particular stuff you wanted to see in a separate PR?

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker_btc-intn/2624/

Ok... I believe I have addressed all of the feedback up to this point.
@tvpartytonight

I updated in-parallel to wait for all forked processes to complete before re-raising an exception from the child process by default (and optionally fail fast)
Added default timeout https://github.com/puppetlabs/in-parallel/pull/6
Changed install_in_parallel to run_in_parallel with array of values.  Currently only supports 'configure' and 'install'

@puppetlabs-jenkins retest this please

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker_btc-intn/2632/

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker_btc-intn/2634/

@puppetlabs-jenkins retest this please

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker_btc-intn/2647/

retest this please

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker_btc-intn/2654/

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker_btc-intn/2655/

retest this please

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker_btc-intn/2665/

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker_btc-intn/2666/

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker_btc-intn/2668/

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker_btc-intn/2669/

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker_btc-intn/2670/

I made some minor updates to the in-parallel library to address some of the things Tony mentioned to me, mainly the logging.  Now it is using a logger, and will swap out it's own simple logger with the Beaker logger if it is available.  I also consolidated a lot of the logging so there are fewer unique log messages.
I Also made a couple of bug fixes, one to address the timeouts we were seeing on Fedora and Ubuntu tests, and one to fix an issue where pressing CTRL-C or stopping a debugging session would always kill the child proc's, but wouldn't abort execution of the program, you always had to do it a second time to truly stop.  I think how things are should be pretty stable now.

@samwoods1 so in ESO Codecraft today I mentioned the fact that (at least for *nix-like systems) when forking a new subprocess each new subprocess will inherit a COW clone of all the parent process's memory segments as well as copies of the parent process' file descriptors. From that point on, any changes made in the child process will not be reflected in the parent process' memory space, ie changes made to variables defined outside the parellelized block.
I understand that you have provided for interprocess communication by allowing forked processes to return values to the parent process but given the proclivity of ruby programmers to modify non-local state it should be made more clear than it currently is that what happens in the child process stays in the child process (unless explicitly returned--but of course, that part you have already documented).

@waynr Good point, I updated documentation in run_in_parallel.md to include this info.

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker_btc-intn/2681/

@puppetlabs-jenkins retest this please

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker_btc-intn/2698/

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker_btc-intn/2699/

LGTM!


Add -enable-cxx-interop flag and support for extern "C" {}

Updated some swift headers to build with c++ and c.
Added -enable-cxx-interop flag.
Added support for 'extern "C"'.

@swift-ci please test tensorflow

@swift-ci please test tensorflow

@swift-ci please test tensorflow

@swift-ci please test tensorflow


Airflow batch jobs need a way to pull the latest batch jar from s3

Right now ingest fetches the rf-batch jar from an environment variable or defaults to a known "good" one, but this is fragile and we should pull the latest instead, or serve the commit to use at an endpoint somewhere since prod probably won't want "latest"

Another option is to inject the commit hash prefix in the environment of the container.


Minor Styling Bugs on Live Site

Bugs
The following bugs occur on production
SocialLInks missing on mobile
It appears that social links need some love since the image shows this getting cut off.

Global padding on body
There is some global padding that is not being properly cleared out.

This was taken care of with #27 and is good to close out.


docs: improve the look in cli-installation(#1308)

Signed-off-by: nikhilkalburgi<EMAIL_ADDRESS>Description
Add Indentation to MacOS, Linux, Windows, OtherOS and resolve cli cmd rendering problem.Let me know if any modification

Related issue(s)
Fixes #1308

@alequetzalli @akshatnema PTAL

@nikhilkalburgi can you provide url where this code can be checked

@nikhilkalburgi can you provide url where this code can be checked

Agree with @sambhavgupta0705, we need to see an actualy example of this working to make sure this is the right solution 😄

as there is no update from @nikhilkalburgi so I am closing this pull request.

Hi @sambhavgupta0705 ,
Sorry for the late response!
URL: https://www.asyncapi.com/docs/tools/cli/installation

as there is no update from @nikhilkalburgi so I am closing this pull request.

@nikhilkalburgi https://deploy-preview-2587--asyncapi-website.netlify.app/docs/tutorials/generate-code
This is the correct url link

@alequetzalli we need your review here

Hey folks, I can't approve this PR because:

The new hardcoded bold elements look spammy.
The quotation indentations are unnecessary because this fragment has NO quotes. Additionally, they are distracting.
Branding and CSS styling enhancements should work with design; we have a brand repo, that is the appropriate place to propose brand changes such as bolding commands.

Closing.


new version 1.8.0

I integrated this branch too in my PR but I found an issue :

The form-data lib is missing in the package.json file

1.8.0 ha been merged into https://github.com/agorapay/node-sdk/pull/3/commits/639a5d4fc8455c1d4541ea44fe7a75908fbf33c1

The form-data lib was well added on PR #4  and also visible on package.json of this PR #5.
"dependencies": {
"axios": "^0.21.1",
"form-data": "^4.0.0",
"i": "^0.3.7",
..


Repeat dialog doesn't work when auto-end is enabled for skills

Describe the bug
Repeat dialog doesn't work when if auto end dialog is set to true
Version
Version:  2.0.0-nightly.239198.1de395f
Electron: 8.2.4
Chrome: 80.0.3987.165
NodeJS: 12.13.0
V8: 8.0.426.27-electron.0
Browser

[x] Electron distribution
[ ] Chrome
[ ] Safari
[ ] Firefox
[ ] Edge

OS

[ ] macOS
[x] Windows
[ ] Ubuntu

To Reproduce
Steps to reproduce the behavior:

create a parent bot and basic echo skill bot locally

First screenshot is echo skill bot logic
Second screenshot is parent logic

Create the manifest for the echo bot
Add the local echo skill bot to the parent
Have the parent call the skill
go through the echo flow on the skill
try to go through the echo flow again

Expected behavior
The echo dialog ends and you end up back in the parent
Screenshots

Additional context
It's unexpected for auto-end dialog to override repeat dialog.

This seems to be resolved with the current build. Closing for now. I'll reopen if it pops back up.


[Bug] Server Tick Crash

Minecraft 1.18.1
Mods:
techreborn 5.1.0
Crops-Love-Rain 1.2.0
croptopia 1.8.3
Fabric-API 46.4
Issue:
When raining, Cabbage crops supported by Greenhouse controllers may grow beyond stage 7 which causes the crash.
Quoted from the log:
Caused by: java.lang.IllegalArgumentException: Cannot set property class_2758{name=age, clazz=class java.lang.Integer, values=[0, 1, 2, 3, 4, 5, 6, 7]} to 8 on Block{croptopia:cabbage_crop}, it is not an allowed value

This issue probable happens with other crops as well, but it should still be easy to fix.

A fixed version (1.2.1) has been released to all platforms.


adding judopayviewcontroller to public headers

adding judopayviewcontroller to public headers and exposing it through the judoKit session object

:+1:


GenAIComps microservices refactor

Description
GenAIComps microservices refactor
Issues
List the issue or RFC link this PR is working on. If there is no such link, please mark it as n/a.
Type of change
List the type of change like below. Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds new functionality)
[x] Breaking change (fix or feature that would break existing design and interface)
[ ] Others (enhancement, documentation, validation, etc.)

Dependencies
List the newly introduced 3rd party dependency if exists.
Tests
Describe the tests that you ran to verify your changes.

Related GenAIExamples update.  https://github.com/opea-project/GenAIExamples/pull/1285/files


Couple issues

had to manually calculate work-life balance category score cause it wasn't there
Also generate scores button doesn't do anything on mobile, had to re enter all my answers on computer
Don't think the work life balance category is contributing to the total aggregate score currently

Good quiz otherwise

We won't be addressing mobile but I'll take a look at the other issues.

Huh, it worked from my android phone with firefox klar on a test URL behind NGINX:
https://emptyduck.com/bri.html
After clicking the Generate Scores button, you have to manually scroll down a bit to see it.
(i removed the debugging buttons so i wouldn't accidentally click them)

Nice. Did you fix the missing category?

@daveshap Thanks, yes I just fixed it in the .html directly with a quick search replace.
The issue is that the naming uses a split on a dash - character:
input.name.split("-")[0]

So there are two categories that end up mapped to Work e.g.
Work-A-0
Work-Life Balance-A-0

So I did a quick search/replace in the .html file to change Work-Life to WorkLife and it picked it up correctly and calculates it now.
:%s/Work-Life/WorkLife/g

Thanks for putting this together!

@ubergarm can you submit a PR that will fix it in the python script so that it is fixed permanently?

Yeah I'll fork the repo and add the fix to the python code and link the PR to this issue. cheers!


Unable to identify Cloudflare IUAM Javascript on website

Before creating an issue, first upgrade cfscrape with pip install -U cfscrape and see if you're still experiencing the problem. Please also confirm your Node version (node --version or nodejs --version) is version 10 or higher.
Make sure the website you're having issues with is actually using anti-bot protection by Cloudflare and not a competitor like Imperva Incapsula or Sucuri. And if you're using an anonymizing proxy, a VPN, or Tor, Cloudflare often flags those IPs and may block you or present you with a captcha as a result.
Please confirm the following statements and check the boxes before creating an issue:

[x] I've upgraded cfscrape with pip install -U cfscrape
[x] I'm using Node version 10 or higher
[x] The site protection I'm having issues with is from Cloudflare
[x] I'm not using Tor, a VPN, or an anonymizing proxy

Python version number:3.6.0
cfscrape version number:2.1.1
Code snippet involved with the issue
scraper = cfscrape.create_scraper(delay=5)
print(scraper.get(session_url).content)
Complete exception and traceback
(If the problem doesn't involve an exception being raised, leave this blank)
ValueError: Unable to identify Cloudflare IUAM Javascript on website. Cloudflare may have changed their technique, or there may be a bug in the script.
URL of the Cloudflare-protected page: https://cn.investing.com/
[LINK GOES HERE]
URL of Pastebin/Gist with HTML source of protected page
[LINK GOES HERE]

This library is unmaintained and dead, see #406

This library is unmaintained and dead, see #406

Thanks for your response. I have noticed that issue only after my comment.

This library is unmaintained and dead, see #406

Also https://github.com/VeNoMouS/cloudscraper/ just republish but script still not work

This library is unmaintained and dead, see #406

Also https://github.com/VeNoMouS/cloudscraper/ just republish but script still not work

I just saw on twitter that 1 week ago, cloudflare posted an announcement about '' cloudscraper '' saying that the new update destroyed cloudscraper forever
I think that the cloudscraper admin @VeNoMouS can no longer fix this public repo, probably only the version paid by him will keep it updated
a new method would be to use puppeteer, I found this version of cloudscraper based on puppeteer
https://github.com/ryxnSZN/cloudscraper
it needs a few updates to bypass the IUAM page
Cloudflare no longer uses the cfduid cookie in headers (set-cookie)

I choose not to update the public one, its not a case of "can no longer fix"...


HBASE-25562 ReplicationSourceWALReader log and handle exception immediately without retrying

…iately without retrying

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 47s
Docker mode activated.


Improve schema mapper

No need to manually parse dictionary type, need to parse field description and replace it's value by appropriate dictionary value

[ ] settlement_type not validated
"settlement_type": "CITYq",


Design for additional AI sources for buildings & roads

Need to make sure that if we get other AI building/road layers, we have a UI design that adequately handles these cases. Right now, we have only one AI road layer (FB Roads) and one AI building layer (Microsoft).

This is done, we have buildings available in many Esri provided datasets now  🎉
Some changes are coming soon to the dataset view/manage screen to better scale to handle the number of datasets we have.


Rodri/invoices api

The router.ex has been modified in order to add the JSON api. And the module InvoicesController has been created in order to recive the HTTP request of the JSON api, this modue.

solve conflicts in route and I'll merge


Confusing definition for references to uninitialized local variables

I'm trying to understand the semantics of local variables, and this clause in the spec is confusing (the non-normative rationale is in italics):

A local variable may only be referenced at a source code location that is after its initializer, if any, is complete, or a compile-time error occurs. The error may be reported either at the point where the premature reference occurs, or at the variable declaration.
We allow the error to be reported at the declaration to allow implementations to avoid an extra processing phase.

Coupled with the definition of compile-time errors:

Compile-time errors are errors that preclude execution. A compile-time error must be reported by a Dart compiler before the erroneous code is executed.

This reads as if an implementation is free to decide whether (1) a reference to a variable before its initialization is erroneous code and a compile-time error must be reported before it is executed, or (2) the declaration of a variable that has been referenced before its initialization is erroneous code and a compile-time error must be reported before it is executed.
The second one of those doesn't make sense to me:
undefined() {
  throw a;  // This should not be executed.
  var a;
}

I agree that it looks confusing.
I'm assuming it's trying to cover a case like:
bar() {
  foo(x) => x + y;
  var y = 42;
  return foo;
}

In this case, the erroneous usage is in the foo function, but the VM (or a similar implementation with interleaved compilation and execution) may not compile the foo function before it's called. So, the VM may report a compile time error when compiling the var y declaration or when compiling the y usage in the foo function - which may be at very different times.
If the error reporting must happen when the declaration is compiled, the VM would need an extra processing phase to (at least) parse the foo function, even if it isn't compiling it at this point.
On the other hand, an implementation is free to report the compilation error before executing the declaration as well.
So it really is (1) or (2) - implementations may pick either.

I wondered if something like that was the motivation, but it still doesn't make sense to me.  The rationale muddies things when it talks about about avoiding extra phases because there is so much more that is unsaid than said.
It doesn't really make any difference to an implementation that compiles foo when compiling bar, because the two compile times coincide.
For an implementation that compiles foo when it is applied (after compilation of bar), I agree that it seems complicated to try to report the error at the application of foo and you would choose to report it when compiling the block in bar.
I think it's fine for the spec to say unambiguously that it is the block in bar containing the use of y before its initializer that is the compile-time error.  There should also be no difference between the text here and in 17.4 Local Function Declaration.

I agree. The error is at the early occurrence of the variable (removing that will fix the problem, removing the declaration won't), and you may report compile-time errors at any time you are compiling code that contains the error, as long as it's before executing it. There is no need to be explicit about when that is.
If you had multiple nested function declarations containing the error, you could detect the problem at any intermediate function body as well (maybe due to inlining of the error code).
I would avoid saying that you can report errors at any time before executing it because there is a push to make compile-time errors catchable at runtime, and you would want the error to occur at a point where the erroneous code is involved, so that the error is repeatable if the same function is called again - even if code is really being compiled in a background thread, and the error was detected concurrently with unrelated execution.

This is still an issue.  I suggest just getting rid of:

The error may be reported either at the point where the premature reference occurs, or at the variable declaration.

We allow the error to be reported at the declaration to allow implementations to avoid an extra processing phase.

Agree. The first statement is sufficient and correct.

No milestone now: The clarification should be carried out as described, but this does not block Dart 2.

Closing: This was part of the update in commit 5af984438298212fd821a091c013602b419340e5.


Incorrect formatted text for PDF's

The following code was used to extract the pdf text and output later being stored into an html file
import tika
from tika import parser
parsed = parser.from_file('/path/to/file', xmlContent=True)
print(parsed["content"])

The problem i am facing is that although all the text is extracted successfully, but it is not able to retain the text styling(bold, italic, underline font size, etc.). The problem is faced only in PDF's; for word files(docx, doc) it works great.

please check the upstream Tika java library and the PDF parser. There are a number of options to set there. Any further questions send them to<EMAIL_ADDRESS>


datepicker today

When using the today button of the datepicker, the date is selected and the dialog closed.
When the dialog is reopened, the selected date is marked differently than after selecting a date and clicking ok.
I'd also argue that today should not close the dialog, but that's a matter of taste I guess...

Removed today btn and added option for clear btn in d613187735a908b28682ed85ddcab91929d99d75