Ensure that the bash shells for examples build

Over time some of the bash files for the examples may have become broken or were migrated improperly.

Ensure that the bash files for the examples all function properly
Are the file lists correct?
Set execution rights properly with chmod.

An additional potential improvement would be to add a bash build script for examples/chapter03_02 as it currently doesn't have one.

An additional potential improvement would be to add a bash build script for examples/chapter03_02 as it currently doesn't have one.

Good catch. Thank you. Will do.

The bash shells are out of synchronization for some examples.
The main problems are:

Files not properly listed.
Name of ELF/HEX, etc. not in line with example name.

For Win* batch files, see #60

Progress has slowly begun.
Example chapter03_02 bash shell and DOS batch builds are fixed.

Nice. I can now compile and flash the example for chapter03_02. It was necessary to manually set the execution bit on build.sh as it's not set in the repository. I don't actually know if the example is running correctly as I'm not 100% sure what visible feedback should be seen when the example runs. I'll have to take a closer look at the code.
One small point is that the first line displayed by ./build.sh is:
Building with        : build.bat

but it should be:
Building with        : build.sh

brian@linuxbox:~/src/real-time-cpp/examples/chapter03_02$ ./build.sh
bash: ./build.sh: Permission denied
brian@linuxbox:~/src/real-time-cpp/examples/chapter03_02$ chmod +x build.sh
brian@linuxbox:~/src/real-time-cpp/examples/chapter03_02$ ./build.sh

Building with        : build.bat
Using tool path      : /home/brian/opt/arduino-1.8.10/hardware/tools/avr/bin
Using tool prefix    : avr
Remove bin directory : bin/
Create bin directory : bin/

Compile  : app_led.cpp to bin/app_led.o
Compile  : app_prime.cpp to bin/app_prime.o
Compile  : mcal.cpp to bin/mcal.o
Compile  : mcal_gcc_cxx_completion.cpp to bin/mcal_gcc_cxx_completion.o
Compile  : mcal_cpu.cpp to bin/mcal_cpu.o
Compile  : mcal_eep.cpp to bin/mcal_eep.o
Compile  : mcal_gpt.cpp to bin/mcal_gpt.o
Compile  : mcal_irq.cpp to bin/mcal_irq.o
Compile  : mcal_led.cpp to bin/mcal_led.o
Compile  : mcal_osc.cpp to bin/mcal_osc.o
Compile  : mcal_port.cpp to bin/mcal_port.o
Compile  : mcal_pwm.cpp to bin/mcal_pwm.o
Compile  : mcal_spi.cpp to bin/mcal_spi.o
Compile  : mcal_wdg.cpp to bin/mcal_wdg.o
Compile  : os.cpp to bin/os.o
Compile  : os.cpp to bin/os_task_control_block.o.
Compile  : sys_idle.cpp to bin/sys_idle.o
Compile  : sys_mon.cpp to bin/sys_mon.o
Compile  : sys_start.cpp to bin/sys_start.o
Compile  : crt0.cpp to bin/crt0.o
Compile  : crt0_init_ram.cpp to bin/crt0_init_ram.o
Compile  : crt1.cpp to bin/crt1.o
Compile  : int_vect.cpp to bin/int_vect.o
Link     : objects to bin/chapter03_02.elf

Extract  : executable hex file : from bin/chapter03_02.elf
Extract  : assembly list file  : from bin/chapter03_02.elf
Extract  : size information    : from bin/chapter03_02.elf
Extract  : name information    : from bin/chapter03_02.elf
Extract  : demangled names     : from bin/chapter03_02.elf
brian@linuxbox:~/src/real-time-cpp/examples/chapter03_02$ sudo $(which avrdude) -C $AVRDUDE_CONFIG -c dragon_isp -P usb -p m328p -e -U flash:w:./bin/chapter03_02.hex

avrdude: AVR device initialized and ready to accept instructions

Reading | ################################################## | 100% 0.15s

avrdude: Device signature = 0x1e950f (probably m328p)
avrdude: erasing chip
avrdude: reading input file "./bin/chapter03_02.hex"
avrdude: input file ./bin/chapter03_02.hex auto detected as Intel Hex
avrdude: writing flash (6198 bytes):

Writing | ################################################## | 100% 6.67s

avrdude: 6198 bytes of flash written
avrdude: verifying flash memory against ./bin/chapter03_02.hex:
avrdude: load data flash data from input file ./bin/chapter03_02.hex:
avrdude: input file ./bin/chapter03_02.hex auto detected as Intel Hex
avrdude: input file ./bin/chapter03_02.hex contains 6198 bytes
avrdude: reading on-chip flash data:

Reading | ################################################## | 100% 6.68s

avrdude: verifying ...
avrdude: 6198 bytes of flash verified

avrdude: safemode: Fuses OK (E:FF, H:D9, L:62)

avrdude done.  Thank you.

brian@linuxbox:~/src/real-time-cpp/examples/chapter03_02$

but it should be: Building with        : build.sh

Good catch. Thank you.
This has been corrected.

not 100% sure what visible feedback should be seen when the example runs

This particular example does not offer very mush visible verification
other than the 1/2Hz blinky reflecting proper error-free execution
and check of the prime sieve calculation.
There is, however, a debug port toggle built in for a runtime scope measurements
A clear description of this feature and a few details about what to expect
when running 03_02 are provided in the bottom of the page in the extended
description of example chapter03_02

Please feel free to provide indication, either positive or negative, or other
suggestions regarding your experience with 03_02.
Play around with the compiler optimization flags to investigate runtime per size
optimization potential once you have the cycle task runtime on the scope.

Please feel free to provide indication, either positive or negative, or other
suggestions regarding your experience with 03_02.

Up until now I have only read the first three chapters of the book. To a certain extent, as a reader, I felt a little like I was been throw into the deep end with  examples 02_03, 02_03a and 03_02. At least this is how I felt initially. This feeling was stronger with example 03_02. If I'm not mistaken, these examples use quite a bit of code that isn't discussed till later in the book. On the other hand, I don't expect to be spoon-fed so I was able to figure out what I needed to know. Figuring things out was relatively easy for 02_03, 02_03a. For 03_02 it was more time consuming. Today, a new section was added to the readme; Running the Setup. This improves things a lot. Yesterday evening and earlier this morning this section didn't exit. The presence of the file mcal_port_expander_microchip_mcp23s17.h led me to believe that an MCP23S17 I/O port was being used. In addition, as least for me, the presence of code related to SPI in the assembly listing file was further confirmation that SPI was being used. It took me a while to figure out that this isn't the case.
I'm not using an IDE to look at the code. Perhaps I should be. If an IDE is not being used a few searches with grep or similar are needed to figure out that port d bit 3 is used by this line of code:
app_prime_port_type::set_direction_output();

I understand why it's called app_prime_port_type and not app_prime_portd_b3_type but nevertheless the searching is tedious.
I tend to look at the assembly code in the listing file quite a bit. However, the listing file contains mangled symbol names which makes it difficult to read. As an example, here's the assembly code for main() in 03_02 with mangled names:
000012d8 <main>:
    12d8:	a0 d8       	rcall	.-3776   	; 0x41a <_ZN4mcal4initEv>
    12da:	62 dd       	rcall	.-1340   	; 0xda0 <_ZN2os8start_osEv>
    12dc:	90 e0       	ldi	r25, 0x00	; 0
    12de:	80 e0       	ldi	r24, 0x00	; 0
    12e0:	08 95       	ret

To demangle symbol names I edit build.sh and pass the -C option to avr-objdump and get the following assembly code for main() with demangled names which is easier to read:
000012d8 <main>:
    12d8:	a0 d8       	rcall	.-3776   	; 0x41a <mcal::init()>
    12da:	62 dd       	rcall	.-1340   	; 0xda0 <os::start_os()>
    12dc:	90 e0       	ldi	r25, 0x00	; 0
    12de:	80 e0       	ldi	r24, 0x00	; 0
    12e0:	08 95       	ret

Perhaps you could use the -C option when generating assembly listings.

Play around with the compiler optimization flags to investigate runtime per size
optimization potential once you have the cycle task runtime on the scope.

After reading this I noticed that build.sh isn't using the options -fdata-sections -ffunction-sections. Adding both of these options to CFLAGS will decrease the size of the text section for 03_02 from 5888 to 3632 bytes. This means that the text segment is currently approximately 62% larger than it needs to be.
In the assembly listing file there are 68 bytes of SPI specific code in the address range 0x7ac to 0x7ef. I don't think it's actually needed for anything.
I hope all of the above doesn't sound too negative as this isn't my intention. To be honest, in retrospect I think it's better to have been thrown into the deep end with 03_02 rather than to have been spoon-fed.

Thank you for providing your excellent and detailed feedback.

into the deep end with examples 02_03, 02_03a and 03_02

That was the intent, in an ultr-practical, almost irreverent way. I will, however look into ways to provide more clear steps along the way. Your identification of unused files and even chip drivers in 03_02 have motivated me to reduce those kinds of things and make sure that the examples are lean and clear as possible.

The presence of the file mcal_port_expander_microchip_mcp23s17.h led me to believe that an MCP23S17 I/O port was being used. In addition, as least for me, the presence of code related to SPI in the assembly listing file was further confirmation that SPI was being used. It took me a while to figure out that this isn't the case.

This is simply an overlooked mistake. The SPI and the external chip driver do not belong in this example. I am in the process of cleaning up all of the examples. And this cleanup is still underway. The misplaced files will be removed from examples where not needed.

isn't using the options -fdata-sections -ffunction-sections

These are intended to be used. A historical mistake seems to have removed them from bash and batch. I will re-insert them.

Perhaps you could use the -C option when generating assembly listings

I will investigate this. Thanks. I also should produce a symbol listing of unmangled names with c++filt. I will improve the situation for the study of the listings and maps.
Thanks again and kind regards, Chris

fixed by #62


Changing Gravatar settings causes Hasura crash

I've changed AUTH_GRAVATAR_DEFAULT  in Nhost Console and Hasura got crashed. Even changing it back to blank did not save Hasura and I had to disbale it completely to get everyting work back.

Can't reproduce, closing for now. If you're still facing this issue, please share a reproduction link, for instance a video recording of the steps that led to the crash


Package Version incremented?

After upgrading the backend I noticed that it still shows as version 2.0.0 in the UI.  The package.json version has not been changed - is this intentional?

Hi @ratsey so the version currently shows the version of the backend angular app which is not identical to the actual Fusio version but with the new release we show the Fusio version to prevent confusion


Project name changer

Add in a utility to rename the native projects from Brazos to your project name.  Need to be able to change bundle ID as well

Fixed in f5db381db1a47bcdf7a35887e3baa00ce3dc703c


DEP: remove extra np.deprecate and add docs back

Reference issue

Follow up to https://github.com/scipy/scipy/pull/18861
What does this implement/fix?

Additional information

The refguide check doesn't seem to respect literal blocks so I opted just to skip these functions in the refguide check. I think this is probably fine since they will be gone in 6 months.
Lint failure unrelated


Adding azure AD B2C to the copilot sample app

Motivation and Context

Adding AzureADB2C support to the copilot sample app.
Description

Contribution Checklist

[ ] The code builds clean without any errors or warnings
[ ] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
[ ] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with dotnet format
[ ] All unit tests pass, and I have added new tests where possible
[ ] I didn't break anyone :smile:

@wayne-o please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
@microsoft-github-policy-service agree [company="{your company}"]

Options:

(default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.

@microsoft-github-policy-service agree

(when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.

@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree [company="{Made Software Ltd}"]

Loging in works now but the MS Graph plugin activation needs some work - I'll try and get that done tonight

I think it will need to use https://learn.microsoft.com/en-us/azure/active-directory/develop/v2-oauth2-on-behalf-of-flow for this to work - is that correct? If so then I will start looking into it - otherwise lmk if there's an easier approach :)

I am not sure this is going to be possible - keep getting invalid audience errors when using the token :/

@wayne-o Looks like there's a MS Graph application pre-requisite to enable the MS Graph APIs, did you configure your Azure application with the required permissions?
This sample  seems like it gives a pretty comprehensive overview of how use MSAL to obtain a JWT token, you can try to compare your work to this to see if there's any gaps.
Let me know if you're able to get it to a working state and I can help test!

@wayne-o Adding the PR:paused label to this PR, please remove the label if you're going to going to resume this PR or close this PR out if you want to abandon this work.
Feel free to open an issue as a feature request for the team to add Azure AD B2C support!

Closing this PR for now; if you want to pick this back up, feel free to open the PR back up :)


Fix for MODCLUSTER-790.

Fix for https://issues.redhat.com/browse/MODCLUSTER-790
Upstream corresponding PR: https://github.com/modcluster/mod_cluster/pull/713

Thanks @jfclere


Automatically project referenced WinRT components without CsWinRTIncludes

Repro sample here:
https://github.com/Scottj1s/ReunionCsAppWithCppRC/blob/22a8792d54a15c3ace13e131808e63300635a7f0/App3/App3/App3.csproj#L6
CsWinRTWindowsMetadata should default to TargetPlatformMinVersion.  And CsWinRTIncludes should default to enabling anything which is not expressly in CsWinRTExcludes (Microsoft, Windows).

#657

#657 tracking CsWinRTWindowsMetadata issue

I think this is very much needed. With C++/WinRT being a first class citizen in the Microsoft techstack, we need smooth tech interop as is expected and available on all other Microsoft languages/technologies. It's ok to require adding a NuGet to allow interop from C++/WinRT to .NET Core. But additionally requiring manual editing of project files does not make sense.
If no inputs are explicitly configured, CsWinRT should generate and compile projection headers for all referenced winmd projects. It should be as easy as that. Add CsWinRT nuget, add your C++\WinRT project references, and things should just work.
One more thing to make the above vision work would be automatically moving referenced binaries into the expected place (not directly into the project output folder, but into runtimes\win10-\native). This would allow us to get rid of the intermediate NuGet packages and directly work with project references. Having to create NuGets inside the develop+debug loop is a productivity nightmare. But I will open a separate issue for that.


refactor(isolated-declarations): remove useless code from scope

The original logic was written to fix incorrect TypeScript ast scopes. Now the scopes are correct so they can be removed

#4420  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Dunqing and the rest of your teammates on  Graphite


Action on NotificationStack

I am not sure why its hardcoded to not display action on NotificationStack.
https://github.com/pburtchaell/react-notification/blob/master/src/stackedNotification.js#L34

Please see issue #46. :smile:


Added mergeDeep function

Created a mergeDeep function to recursively merge objects, similar to lodash's merge function.

cc @colbyr


UIActionSheet & UIPopoverController deprecated

I ported over the action button functionality from IDMPhotoBrowser, but didn't realize they were using deprecated code.   I'll update & submit a pull request to get rid of the warnings.

:+1:

@pj4533 I fixed it.

@suzuki-0000 you can close this because I made it in previous pull request


Don't stop on readonly files in converter

Fixes #109
I need to sort out the PRs so they are mergeable.  My first attempt fell flat! Will let you know when they are ready

The failing test works fine on my machine, so not sure what's up. I'll try fixing by making a copy of the file first so that there isn't a potential clash if tests are run in parallel


How to use Uniswap

Due: 0000 24th April UTC +0

To get date object from UTC time: new Date("2020/04/24 00:00 UTC")

Lets wait for the v2 release

Is that imminent?

The v2 is already out on testnets, and it seems quite close on the horizon


Provide support for Godot 4

Godot 4 is still in beta, but there are some changes that will be in Effect in the Future.
In particular this change is backwards compatible to the existing workflows. In particular linux_headless has been sunset and replaced by the regular linux distribution (linux.x86_64). To run Godot in a headless context, it is now necessary to specify the display-driver to be "headless".
With this change a Workflow can be created for the beta releases of Godot.
The following Workflow File (it's based on the official one) can be used to create an image on ghcr.io now (without this PR).
If you want i can also contribute the changes to the release workflow, so once godot4 has been released, the images can be created automatically:
All in all thanks for creating this container image. Has been a blast in the past already.
name: build

env:
  IMAGE_NAME: godot-ci

on:
  workflow_dispatch:
    inputs:
      version:
        description: 'Version of engine to build e.g. "3.4.4", "3.5"'
        required: true
        type: string

      release_name:
        description: 'Release name, usually "stable", but can also be something like "rc3", "beta1"'
        type: string
        default: "stable"
        required: true

      godot_platform:
        description: 'Name of the Platform to download. For Godot 3.X this is linux_headless.64, while for Godot 4 it is linux.x86_64'
        type: string
        default: "linux.x86_64"
        required: true

      godot_args:
        description: 'Appends additional arguments to the Godot invocation running the container running. This allows to specify the display driver in Godot 4+. Otherwise empty'
        type: string
        default: "--display-driver headless"
        required: true

jobs:
  build:
    runs-on: ubuntu-latest

    steps:
      - uses: actions/checkout@v3
        with:
          repository: abarichello/godot-ci

      - name: 'Fork: Add fix for Godot 4'
        run: |
          REPLACE_NEEDLE=linux_headless.64
          sed -i 's/'${REPLACE_NEEDLE}'/${GODOT_PLATFORM}/g' Dockerfile
          sed -i 's/RUN godot -e -q/RUN godot -e -q ${GODOT_TEST_ARGS}/g' Dockerfile
          sed -i '/ARG SUBDIR=""/a ARG GODOT_PLATFORM="'${REPLACE_NEEDLE}'"' Dockerfile
          sed -i '/ARG SUBDIR=""/a ARG GODOT_TEST_ARGS=""' Dockerfile

      - run:  echo IMAGE_OWNER=$(echo ${{ github.repository_owner }} | tr '[:upper:]' '[:lower:]') >> $GITHUB_ENV
      - name: Login to GitHub Container Registry
        uses<EMAIL_ADDRESS>        with:
          registry: ghcr.io
          username: ${{ github.repository_owner }}
          password: ${{ secrets.GITHUB_TOKEN }}

      - run:  echo IMAGE_TAG=$(echo ${{ github.event.inputs.release_name != 'stable' && format('.{0}', github.event.inputs.release_name) || '' }}) >> $GITHUB_ENV

      - name: Build and push Docker images
        uses<EMAIL_ADDRESS>        with:
          context: .
          file: Dockerfile
          push: true
          tags: |
            ghcr.io/${{ env.IMAGE_OWNER }}/${{ env.IMAGE_NAME }}:${{ github.event.inputs.version }}${{ env.IMAGE_TAG }}
          build-args: |
            GODOT_VERSION=${{ github.event.inputs.version }}
            RELEASE_NAME=${{ github.event.inputs.release_name }}
            SUBDIR=${{  github.event.inputs.release_name != 'stable' && format('/{0}', github.event.inputs.release_name) || '' }}
            GODOT_PLATFORM=${{ github.event.inputs.godot_platform }}
            GODOT_TEST_ARGS=${{ github.event.inputs.godot_args }}

Another example:
when using the above mentioned Workflow to create a package (e.g. ghcr.io/bjoernakamanf/godot-ci:4.0.beta14 * )
docker run --rm -it -w /game -v $(pwd):/game ghcr.io/bjoernakamanf/godot-ci:4.0.beta14     godot --display-driver headless --export-release "Windows Desktop"

i could make that public if there is demand for that. Though i don't plan to support any of the images beyond my own usage. (latest beta, export for Windows, Linux, Web, maybe MacOS)

Thanks for getting this working @BjoernAkAManf ! I tried the workflow file from your comment against 4.0 RC5 and it mostly works, but the part of the Dockerfile that runs godot -e -q --display-driver headless (the default godot_args input) never exits. I suspect that it's continuing to run in server mode.
I got it to work by setting godot_args to --headless --quit. --quit tells Godot to quit after its first iteration, and --headless is a shortcut for --display-driver headless --audio-driver Dummy.

Is this working on Godot 4.0 now? If so we can merge this.

The changes here are still relevant, the current release of Godot CI 4.0 failed!

@Brawmario Good catch thanks!

merging this PR would make it work, or anything else in necessary?

merging this PR would make it work, or anything else in necessary?

Well yes. You'd need to run it with the appropiate arguments though, as i designed it in a way, that it is compatible with godot 3. Similar to @teekennedy 's comment.
2023-01-26T21:03:45.2449593Z   build-args: GODOT_VERSION=4.0
RELEASE_NAME=beta15
SUBDIR=/beta15
GODOT_PLATFORM=linux.x86_64
GODOT_TEST_ARGS=--headless --quit

@realkotob Is this PR good to merge?


Martinkeen patch 4

Delete PDF and update README

looks like i need to learn how to make changes the github way


Create reports that shows events and logs grouped  By the use case by timeframe

Hi there
When troubleshooting different use cases the common sources of that that we search for, currently is separated and in different folders, organized by the location where that information exists.
It would be useful to have a report  that could shown the main useful information that happen in a timeframe that  we could set in the
UI grouped by troubleshooting use case.
Authentication Report .txt:
| Time Frame     | source             | Count   |    Event Ids | Error Codes |  Details |
|  12h00-13h00  | Event Log Lsa |       3     |  YYYY, XXXX, |  | < event message >
| 12h00 - 13h00 | Event Logs Kerberos |  4|  AAAA, BBBB|  |  < event message >
| 12h00 - 13h00 | FREB Logs | 3 |   | 401.2 |  Request Summary with URL, App Pool, Authentication
| 12h00 - 13h00 | Http Err | 3 |  | 403 |  http response message
Crash Reports.txt:
| Time Frame     | source             | Count   |    Error Codes  |
|  11h00-13h00  | Event Log WAS |       3     |  YYYY, XXXX,   |
| 11h00 - 13h00 | IIS Logs | 100 | 500 |
Currently we have different sources of information: Event Logs , IIS Logs, Freb Logs, Http Err Logs. For each entry that we find that is a error or warning we could increment  the count, collect the Event ID and the Error Code/Status Code.
To not impact the time we take to collect all the data , this reports could be generated only by the person that is troubleshooting the issues. For this it could exist a button that could represent  the trigger to generate such reports.
With this information we could easily identify i which time frame we had the main errors that  we are looking for depending on the use case, such as Authentication or Crashing.

@v-paulino , this is a tool for the collection of logs. Do you want to have the ability to generate the reports once the logs have been collected, or before collecting them?
I`m asking this as that way i can think how the feature should be implemented.

Reports should be generated from data collected only and also available on the zip file.
If could be implemented in one of two possible ways. During collection stage, or during the troubleshooting stage.
During Troubleshooting stage:
Sometimes we see that log-catcher takes a while to collect everything and create the zip file. In such cases and because that is data needed mostly for troubleshooting it could only be generated when we are doing troubleshooting and not so much during collection of data.
A button describing the action like :" Generate Reports" could generate all the implemented reports that we want could be useful.
During Collection Stage:
On the other hand, collected data does not change after being collected ( it shouldn´t ).
So we can generate the reports once and read the reports many times after being generated and stored into the zip file. This approach could make sense if it would not impact the amount of time it takes to collect and generate the zip file during collection of information.


Fix Lead that's missing enumerator disposal & test

Fix a part of #649
Fork of #660

Closed. The implementation of Lead is fixed here #672


[HUDI-7054][FOLLOW_UP] HoodieCatalogTable should ignore lazily deleted partitions

Change Logs
Describe context and summary for this change. Highlight if any code was copied.
Thinking it might be better to directly let HoodieCatalogTable to filter deleted partitions, it shouldn't show deleted partitions when calling getPartitionPaths.
This can also fix RepairHoodieTableCommand to not repair deleted partitions.
Impact
Describe any public API or user-facing feature change or any performance impact.
None
Risk level (write none, low medium or high below)
If medium or high, explain what verification was done to mitigate the risks.
None
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change

The config description must be updated if new configs are added or the default value of the configs are changed
Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the instruction to make
changes to the website.

Contributor's checklist

[ ] Read through contributor's guide
[ ] Change Logs and Impact were stated clearly
[ ] Adequate tests were added if applicable
[ ] CI passed

@hudi-bot run azure

The CI actually passes, @danny0405


[Algo]

Algorithm

[ ] I have gone through the repository and made sure this algorithm has not been implemented

Information about my new algorithm

Algorithm Name:  Fibonacci Numbers using Matrix Exponentiation

Programming Language:  C

Time complexity: O(log n)

**Is this your first contribution to this repository?**Yes
Yes

I want to work on this issue


2.x Updating to Governator 1.7 and archaius2.

dependency updates
server refactoring to be inline with governator 1.7

NetflixOSS » eureka » eureka-pull-requests #315 SUCCESS
This pull request looks good

NetflixOSS » eureka » eureka-pull-requests #316 SUCCESS
This pull request looks good

NetflixOSS » eureka » eureka-pull-requests #317 SUCCESS
This pull request looks good

NetflixOSS » eureka » eureka-pull-requests #318 FAILURE
Looks like there's a problem with this pull request

NetflixOSS » eureka » eureka-pull-requests #319 SUCCESS
This pull request looks good

NetflixOSS » eureka » eureka-pull-requests #322 SUCCESS
This pull request looks good


AutoPort should be all lowercase for xml

The AutoPort param on Graphics struct must be all lowercase letter for
libvirt's xml, see
https://libvirt.org/formatdomain.html#graphical-framebuffers.
If use AutoPort param, it will be a bug, so fix it now before use it.
Signed-off-by: shewensheng<EMAIL_ADDRESS>
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Release note:

/test all

To keep history and intact, referencing here the original PR: https://github.com/kubevirt/kubevirt/pull/7525

/test all

/release-note-none

/retest-required

/ok-to-test


The max marline should not follow the precision option

Version
5.1.2
Reproduction link
https://jsfiddle.net/6L5bzfxn/
Steps to reproduce

Use some really small decimal data (please check the reproduction link).
Set a max markline.

What is expected?
The max markline shows the maximum data.
What is actually happening?
The max markline shows wrong data.

Ok, I recheck the doc, there is the precision option, but I don't think that the max and the min markline should follow this option, that made me confused.

Seems the precision should not be fixed by default. We can automatic the precision calculation from the raw data.


Add mandatory cargo_doc

Something went wrong here, your PR contains other people's commits.

Looks good! Can you please squash this all into a single commit? Then we can land this.

This doesn't seem to have caught the original CI error in rust-lang/rust.
warning: unresolved link to `0`
   --> src/tools/miri/src/eval.rs:400:13
    |
400 | /// in argv[0] cannot be encoded using the standard command line parsing rules.
    |             ^ no item named `0` in scope
    |
    = note: `#[warn(rustdoc::broken_intra_doc_links)]` on by default
    = help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]`

I think you need to add --document-private-items to the CI job.

This doesn't seem to have caught the original CI error in rust-lang/rust.
warning: unresolved link to `0`
   --> src/tools/miri/src/eval.rs:400:13
    |
400 | /// in argv[0] cannot be encoded using the standard command line parsing rules.
    |             ^ no item named `0` in scope
    |
    = note: `#[warn(rustdoc::broken_intra_doc_links)]` on by default
    = help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]`

good catch

I think you need to add --document-private-items to the CI job.

This should be ready to go now
Just would need to wait for a submodule update

This PR now has two commits with the same description? Probably better to squash them.

Thanks, looking good. :)
@bors r+

:pushpin: Commit eaa1e444eb3efa0bb4e1faf00b0ee2b4e3d8f673 has been approved by RalfJung

:hourglass: Testing commit eaa1e444eb3efa0bb4e1faf00b0ee2b4e3d8f673 with merge 7656fc45cf13ade469661a11f84999b5e43e2e29...

:sunny: Test successful - checks-actions
Approved by: RalfJung
Pushing 7656fc45cf13ade469661a11f84999b5e43e2e29 to master...


Populating with new object models

Added all new models from DAVE Object Models and some more Cole's library.
Also, ported all new object models to Ignition fuel, checkout the collection here.
Updated world looks like this,

starting from top left we have the electrical(+bimanual) demo, hardhats, torpedos, sonobuoy, uxos
top right ocean rock
middle rexrov, mbari mars, flight data recorder, niskin, kelp, coral, fishes
bottom left mud anchor in mud pit, sunken ships, vases

Please suggest any additions/modifications! You can run this by launching the integrated world roslaunch dave_demo_launch dave_integrated_demo.launch.
Also, @bbingham-nps since the models are uploaded, is it a good idea to delete them from the repo? Except the ones having inertial properties.

@mabelzhang You're right, the ones I uploaded have inertial properties, I will remove the comments and use the Fuel links. Corrected the description, only models having inertial_calcs.py script needs to be preserved in the repo.

@aaronchongth has a lot of experience uploading and managing models on fuel. He can guide you better on this if needed.

Hey there! :wave: Pardon me for butting in,
We were plagued with these similar concerns around the start of the Open-RMF project, and has since found that the some best practices were needed to ensure consistent model loading/downloading behaviors over time. Most of the rules we end up adopting can be found here, naming consistencies, the absence of spaces, all referenced assets are within the model relatively, etc. The script I linked was just something random I was using a few years back, no idea if it still works.

absence of spaces

this prevented any cases of directories having apostrophes like @Yadunund mentioned, which allows us to easily write scripts to work with models en masse when needed, e.g. adding plugins, tweaking parameters, changing names, etc

naming consistencies between folder name, name in model.config and name in model.sdf

I haven't checked the models if they have differing names in different places yet, but in our experience this was rather important, as gazebo-classic references different names from different locations in different cases. Example in this screenshot of an innocent table,

when loaded into the world and has duplicates, it opts for the name in model.sdf, it also adds underscores and indices :sweat_smile: If that is the desired behavior, then no problem!

<uri>https://fuel.ignitionrobotics.org/1.0/quarkytale/models/MBARI MARS</uri>

We had to use a bunch of workarounds in the past when the gazebo-classic was not supporting fuel URLs, and this PR just showed us that it works now! :partying_face: So all's good regarding using URLs.

uploading models

Could we also check if the assets and models created should be uploaded under the Open Robotics organization instead? I am unsure if we have any policy regarding this. I'm not sure if you need to be an admin, but you can choose under which user/organization to upload a certain model.

Thanks for the most valuable comments! I have some follow-up questions:

Currently, both the torpedos and sonobuoy are static, leaving the uxos non-static for manipulation. It did seem hazardous to put missiles near an electrical station, but I'm open to suggestions, maybe stationing them vertical for better visibility?
I put two versions of ships to highlight the distortion feature, I initially placed them one in each mud pit, or should I skip the non-distorted one?
Model names seems like a separate discussion? For DAVE object models I followed Cole's semantics. Changing the name will require deleting and re-uploading models and from them to have OpenRobotics as owner will require access or Nate. I'll pass this on!
Apart from that working on making lionfish, hardhats, mars and ships static plus adding more creatures near the mud pit vases.

Currently, both the torpedos and sonobuoy are static, leaving the uxos non-static for manipulation. It did seem hazardous to put missiles near an electrical station, but I'm open to suggestions, maybe stationing them vertical for better visibility?

The torpedos and sonobuoys were library items as examples of things that we often pickup with underwater robots.  Unrelated to the electrical station - the model collection world is just there to demonstrate the existence of various models.

I put two versions of ships to highlight the distortion feature, I initially placed them one in each mud pit, or should I skip the non-distorted one?

For the example, I think more is better ;)

Apart from that working on making lionfish, hardhats, mars and ships static plus adding more creatures near the mud pit vases.

@quarkytale just to clarify, you only need to add <static>true</static> elements within the include blocks in the dave_integrated.world file. You don't need to change anything to the models on fuel.


Fix calculation of truncated binary exponential backoff

The intent of the jitter in the exponential backoff calculation is to create a uniform random distribution.  However, the current calculation applies the truncation after the randomization.  This results in clamped/truncated distribution which is not what we want.
This only affects cases where the calculated backoff exceeds the MAX_BACKOFF, and is more pronounced the more you exceed MAX_BACKOFF. The current default of 3 max attempts is well below this value so this change has no effect on the default behavior.  A user would have to have a max attempts of at least 6 before this started to affect backoff times.
As an example, this is a distribution based on 10,000 events with attempt=10 (x-axis is backoff time in seconds):

And here's the distribution with 10,000 events with attempt=10 with the changes in this PR:

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.13%. Comparing base (52e97a5) to head (9eee61e).
 Consider uploading reports for the commit 47bfd56 to get more accurate results

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3178      +/-   ##
===========================================
- Coverage    93.14%   93.13%   -0.01%
===========================================
  Files           66       66
  Lines        14237    14248      +11
===========================================
+ Hits         13261    13270       +9
- Misses         976      978       +2

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Is there a chance that the back off is very close to 0 each time? Depending on how random the random number is and how many retries.
Surely it would be better to create jitter with non-zero values for random such as rand(0.1,1)
I assume the initial intent would have been for rand(0,1) + 2 ** attempt however this was likely changed to deal with small values of MAX_BACKOFF.
expoential backoff would likely to fix up flow control, not sure a very short back off makes sense and cause errors that are hard to debug.


When multiple databases are configured with clear: true, command gen dao will  cleared the previous entity.

1. What version of Go and system type/arch are you using?

go version go1.19.1 darwin/arm64
2. What version of GoFrame are you using?

 Can this issue be re-produced with the latest release?
4. What did you do?

This's my config.yaml
gfcli:
  gen:
    dao:
      - link: "mysql:root:12345678@tcp(localhost:3306)/cc_sys"
        tables: ""
        removePrefix: "s_,u_,c_,w_"
        descriptionTag: true
        noModelComment: true
        group: "sys"
        clear: true
        overwriteDao: true
      - link: "mysql:root:12345678@tcp(localhost:3306)/cc_book"
        tables: ""
        removePrefix: ""
        descriptionTag: true
        noModelComment: true
        group: "book"
        clear: true
        overwriteDao: true

I added clear: true to each databaes configuration.
When I use gen dao . Only the entity configured at the bottom will be retained, and all previous ones will be cleard.
5. What did you expect to see?
I hope that even if clear: true is configured for each database, the previous entity will not be cleard.
6. What did you see instead?

https://github.com/gogf/gf/pull/3301


Version 1.3.2 availability

Good day,
Congratulations on pushing v1.3.2.
When will it be available for the public?  Tried to update and I am still getting v1.3.1.
Thanks

Related: https://github.com/Control-D-Inc/ctrld/issues/97
We are going to have a better release process, so once thing is available on Github, the installer will download the same version.
cc @yegors

Binaries are available on Github, installer is a separate system from Github.

OPs question remains unanswered, so I am pinging again. Understood that the installer follows a diff system, but when can we (those who use the installer) expect to see v1.3.2?
Agree that the release process needs to be revamped to be uniform across the board.

Be patient or update it manually.

So when will be the installer updated?


component chart nfs support

Is your feature request related to a problem?
Currently component chart doesn't support nfs key when volumes are defined so containers cannot directly mount nfs share.
Which solution do you suggest?
add nfs section to component chart volumes section same as kubernetes.
Which alternative solutions exist?
as my understanding, only way to mount nfs is through storageclass.
Additional context

/kind feature

@Orgil thanks for creating this issue! As the component chart shouldn't cover every use case and rather be a simple to use generic chart, you could also just create a separate chart or manifests to configure this. Would that be an option for you?


Change script handling to abort on error

When a script runs into a script error, it should abort, not just go on.
Example:
- if <tag that returns pickle> {
   - narrate "Wilbur"
   } else {
   - narrate "Ed"
   }
- narrate "eh?"

This should abort, this should not assume false and print
Ed
eh?

I was considering making a special case for this to happen, but definitely not all the time.

That way, certain people can stop returning nulls when it should be booleans >.>

@Talamar1 True, false, or error are all possible results of a boolean tag.

null is not boolean... thus my point, the system should error and not just let an invalid boolean value like null or anything else pass through the system.  As I argued with Fortifier, if you are going to call something a boolean, it has 2 return values, true or false, null is not a valid boolean.

null = error

null isn't error, or you aren't handling the error properly, null results in false.

null invalidates the tag, causing the user to get an error in console, thus error.

It doesn't error the code, it prints an error message, there is a difference between error reporting and error handling.

It would appear you want the script to fail purely due to semantics? Having it fail softly is probably better than just not working, due to the nature of the language. Many beginners will pick up denizen to try and learn something VERY complicated they have 0 experience with. Though there is no need to baby someone through their time learning how to script. There is also no need to have "Boolean" checks entirely stop the script if they are not exactly "true" or "false". Not to mention if you Require if checks to be either true or false that become EXTREMELY difficult due to the limitations of tags.
The method of 'if it is not true, then it is false' really keeps it simple for most users. You obviously would not personally have a problem with what you are suggesting but, what about every one else?

KeangDavid, teaching a user how to use Boolean properly is not babying them, its teaching them to use proper coding.  Meh, I'm done arguing this point.


Please include The Fn Project under Serverless/Event-based Category

Please only report on one project or product per issue
Guidelines for getting added to the CNCF Cloud Native Landscape:

We generally will only list a company in one box, to represent its major or best known offering. We occasionally make exceptions for large companies.
Projects with at least 250 GitHub stars that clearly fit in an existing category are generally included.
We are unlikely to create a new category for products/projects as we'd rather find the best home with the current options.
We are generally not including commercial versions of open source software, when that version just includes minor tweaks.
Closed source products need to link to a clear description of your product; no stealth mode companies.
Your project or company needs a logo.

Project or Product name: The Fn Project
Is it open source? (if you are tempted to say partially, please answer no): YES
What are the best URL(s) for it? Repo and homepage (if different) for open source, product homepage for closed source?: https://github.com/fnproject/
What one category does it best belong in?: Serverless/Event-based Category
What's the URL for the best logo (and it needs to include the name)?: https://github.com/fnproject/fnproject.github.io/blob/master/images/logos/fn.png
Anything else we need to know?: For more information about the project:
https://medium.com/fnproject/8-reasons-why-we-built-the-fn-project-bcfe45c5ae63
Thank you!
Chad

Closing as this update was included in the most recent version https://github.com/cncf/landscape#current-version


Improved window sizing API (Windows)

Currently, window sizing (at least on Windows) is fairly broken for a few reasons:
Swing has some hi-dpi bugs that make window.minimumSize and window.maximumSize not really usable
window.minimumSize takes a density-independent pixel (not dp) value. However, due to a bug, when setting the value the window will get resized to a minimum size with scaling applied.
On a 200% display, window.minimumSize = Dimension(400, 400) will resize the window to 800x800px, then prevent the window from shrinking below 400x400px.
private fun main() = application {
    var minimumSizeDp by remember { mutableStateOf(DpSize(320.dp, 320.dp)) }
    val state = rememberWindowState(size = minimumSizeDp)

    Window(onCloseRequest = ::exitApplication, state = state) {
        val density = LocalDensity.current
        LaunchedEffect(density, minimumSizeDp) {
            window.minimumSize = with(density) { Dimension(minimumSizeDp.width.roundToPx(), minimumSizeDp.height.roundToPx()) }
        }

        var boxSize by remember { mutableStateOf(IntSize.Zero) }
        Box(modifier = Modifier.fillMaxSize().onSizeChanged { boxSize = it }) {
            Button(onClick = { minimumSizeDp = minimumSizeDp.times(1.2f) }) {
                Text("increase min size")
            }

            val boxSizeDp = with (LocalDensity.current) { boxSize.toSize().toDpSize() }
            Text(modifier = Modifier.align(Alignment.BottomEnd), text = "minimumSizeDp: $minimumSizeDp, boxSizeDp: $boxSizeDp")
        }
    }
}

https://github.com/JetBrains/compose-multiplatform/assets/87964/940e433e-ac0d-46ee-b3ca-561682b17d52
The only workaround for this that I've found is to implement a custom WindowProc and implement WM_GETMINMAXINFO manually for the window
WindowState.size is inconsistent, and includes the invisible window frame that surrounds a Windows 10/11 window
You might expect the window size to either be the size of the content below the titlebar, or the size of the visible window.

On macOS, WindowState.size corresponds to the window's frame (i.e. NSWindow.frame)
On Windows, WindowState.size is a value that's larger than the visible size of the window, and includes some invisible padding that Windows added when they removed visible (thick) window borders around windows. There's an invisible border around each window to allow for resize handles, and this is included in the window size.

Repro:
private fun main() = application {
    val initialSize = DpSize(200.dp, 200.dp)

    val state = rememberWindowState(size = initialSize)

    Window(onCloseRequest = ::exitApplication, state = state) {
        Box(modifier = Modifier
            .background(Color.Red)
            .requiredSize(initialSize) // <- Box set to same size as window size
            .padding(10.dp)
            .background(Color.Blue))
    }
}

This means that sizing logic needs to be platform-specific, and needs to factor in the border thickness for Windows. You have to use something along the lines of:
    // The raw border measurements of the window. Includes a top border which is not applied unless the
    // window is maximised.
    fun borderWidth(hWnd: HWND): Insets {
        val style = User32.INSTANCE.GetWindowLongPtr(hWnd, WinUser.GWL_STYLE).toLong()
        val styleWithoutTitlebar = style and WinUser.WS_CAPTION.inv().toLong()

        // AdjustWindowRectEx modifies "offsets" to become the size of the enclosing frame that
        // would fit "offsets". Since a zeroed rect is passed in, this ends up setting offsets to
        // the additional size that the frame takes up.

        val offsets = WinDef.RECT()
        User32.INSTANCE.AdjustWindowRectEx(
            offsets,
            WinDef.DWORD(styleWithoutTitlebar),
            WinDef.BOOL(false),
            null)

        return Insets(-offsets.top, -offsets.left, offsets.bottom, offsets.right)
    }

The combination of these two issues means that:

It's impossible to adjust a window's minimum size at runtime
It's impossible to (easily) resize a window to fit its content after the window is opened

I'd love to see improvements in this area, since currently a lot of extra work is needed to workaround these issues -- and it's likely that developers primarily using Linux or macOS are not aware of these behavior differences on Windows!

Maybe you can try return the WindowInsets that is provided by compose foundation.

@Sanlorng
You could stuff the frame widths into WindowInsets, but since that uses Dp sizing, density would need to be taken into account.
What I think should happen here is that this should be considered a bug, and ComposeWindow should make this adjustment internally when setting the window size.
That way, a 200dp window on Mac, Linux and Win will all open to the same visible size.
The current logic made sense when windows had visible frames (Win8 and earlier) but doesn't make sense today.
Similarly, as a feature request, I think WindowState should have minimumSize and maximumSize fields that bypass the broken AWT implementation.

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.


[urho3d] Add new port

Add Urho3D port.

Thanks for your PR. Now port urho3d build failed on CI test, you can download failure logs from: https://dev.azure.com/vcpkg/public/_build/results?buildId=41976&view=artifacts&type=publishedArtifacts

Pinging @koprok for response. Is work still being done for this PR?

Pinging @koprok for response. Is work still being done for this PR?

@LilyWangL, Currently not. Maybe later I will try to finish the port. But I will also be grateful if anyone else does it.

Closing this PR since it seems that no progress is being made. Please reopen if work is still being done.


[searchinput] : Fixes #258 Add typing functionality.

The input is able to take values onChange.

The search bar has been implemented, styled, and has a working submit functionality. Props have also been spread.

This resolves #257 , #219 , #210 , #199 .


Model export fails on transformation pickle

Hi,
I'm trying to export a trained model, but it fails when trying to pickle the transformations.
I was wondering if this functionality is supported in fastai2_audio, because I used only out-of-the box methods.
How to reproduce:
Run this in the end of a training notebook
learn.export('model_fname')

The error message:
---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
<ipython-input-125-7815b0949909> in <module>
----> 1 learner.export('model_fname')

/usr/local/lib/python3.7/site-packages/torch/serialization.py in save(obj, f, pickle_module, pickle_protocol, _use_new_zipfile_serialization)
    369     with _open_file_like(f, 'wb') as opened_file:
--> 370         _legacy_save(obj, opened_file, pickle_module, pickle_protocol)
    371

/usr/local/lib/python3.7/site-packages/torch/serialization.py in _legacy_save(obj, f, pickle_module, pickle_protocol)
    441     pickler = pickle_module.Pickler(f, protocol=pickle_protocol)
    442     pickler.persistent_id = persistent_id
--> 443     pickler.dump(obj)

AttributeError: Can't pickle local object 'CropSignal.<locals>._inner'

What I tried:

run my custom training notebook: fails
copy Google Colab example notebook with my data: fails
move transformation definition from common function to list: still fails
explicitly only import transformations that I use from fastai2_audio.augment: fails, no change
google 😅

These are the transformations I tried to use, taken from the tutorials in this project.
item_tfms = [
    RemoveSilence(),
    CropSignal(3000),
    DownmixMono(),
    Resample(22050),
    AddNoise(noise_level=0.1),
    AudioToMFCC(n_mffc=20, melkwargs={"n_fft":2048, "hop_length":256, "n_mels":128}),
    Delta(),
]

Is this a known problem? If yes, is there a workaround?
Do you have a hint how to fix this? I'm up for trying and opening a PR

Testing whether a model can be exported hasn't been tested thoroughly but is a feature that we would like to support. If you work out what the issue is then please yes open a PR.

When exporting a Learner in fastai2, it also tries to export the dataloaders. The problem is that our current way of writing the data augmentation functions is not compatible with pickle (see this to know more why). But, we can change the code to subclass Transform without changing the user interface. I started working on the fix, but it will take a couple of days to translate all the code and properly test it.

Thanks a lot @scart97
Let me know if I can help or support in any way

@hellno  as a workaround you can export only the model, as it's just a normal nn.Module. Following the guide, torch.save(learn.model.state_dict(), PATH), and to load it you create a new learner the same way you created the first time and try to run learn.model.load_state_dict(torch.load(PATH)).

this works now with the changes in #41 😍 thank you!


Kousa: Remove starter processes

This removes Onion.StartRooms and Onion.StartRabbits in favor of starting the necessary processes without intermediaries. The two GenServer modules did not keep any state and were only used to start other processes after the supervisor tree has been set up, becoming useless afterwards.
The code for starting the processes is now inside the parent Kousa module, but if anyone knows a better place for it, please tell me!

this looks good to me, @ityonemo what do you think?


Fix text_edit drawing incorrect chars when syntax highlighting enabled

Fixes text_edit drawing incorrect characters when syntax highlighting is enabled, it now works the same way as having the setting disabled. I believe this is left over from before the syntax highlighter was extracted.
closes #28860

Cherry-picked for 3.1.2.


How to call the AlgoSigner class with typscript ?

Hi,
How to call the AlgoSigner class with typscript. i am getting error
Cannot find name 'AlgoSigner'.

Hi!
The AlgoSigner object is available via the installed extension and exists on the window object in a browser.
You could either declare it as a global variable (always making sure to only call it when in a browser context) or reference it by doing 'window.AlgoSigner'


Fix off by 1 error in secondsToHms value converter

Round seconds to nearest value rather than flooring it.

Coverage increased (+0.7%) to 73.489% when pulling b7851e01f7d604affcdbd2ec197c6599b05ee7de on dd/secondstohhmmss into a94fba5f49a3b50adee0d98abd2e047f5e9c43c7 on master.


Only query vehicle attributes once

Description:
Instead of requesting vehicle attributes on each update, just do it once when initializing
Also, use vehicle registration number as default device id, instead of the (longer) vehicle identification number.
Related issue (if applicable): fixes #
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#
Example entry for configuration.yaml (if applicable):

Checklist:
If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated in home-assistant.io

If code communicates with devices, web services, or a:

[ ] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[ ] New dependencies have been added to the REQUIREMENTS variable (example).
[ ] New dependencies are only imported inside functions that use them (example).
[ ] New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[ ] New files were added to .coveragerc.

If the code does not interact with devices:

[x] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[ ] Tests have been added to verify that the new code works.

use registration number as dev id

🐬


Module parse failed: Unexpected token (1:0)

Do you want to request a feature, report a bug or ask a question?
I think it is a bug or something else
What is the current behavior?
Just simply configured it in webpack and loaded given sprite file but failed when start vuejs project by npm
What is the expected behavior?
load sprite successfully and can be used in vue file
If the current behavior is a bug, please provide the steps to reproduce, at least part of webpack config with loader configuration and piece of your code.
This is my simple configuration in webpack:
      {
        test: /\.svg$/,
	loader: 'svg-sprite-loader',
	include: resolve('src/assets/fa-brands.svg')
      },

I'm using font awesome svg file
The best way is to create repo with minimal setup to demonstrate a problem (package.json, webpack config and your code).
It you don't want to create a repository - create a gist with multiple files
If this is a feature request, what is motivation or use case for changing the behavior?
Please tell us about your environment:

Node.js version: 6.9.2
webpack version: 2.9.0
svg-sprite-loader version: latest
OS type & version: mac

Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow, gitter, etc)

Here is my sprite svg file:
fa-brands.svg.zip

Could you please create repo with minimal setup to demonstrate a problem (package.json, webpack config, SVG image and piece of your code). If you don't want to create a repository - you can create a gist with multiple files.

Have the same issue, but need some time to distinguish minimal setup to reproduce the issue from my pretty huge project.

I don't know yet, how it is related but the issue is reproducing only if i run task within Webstorm npm scripts runner module. In case if i manually launch exactly the same command (npm task) directly from console, it builds successfully!

@eschao you're using precompiled SVG sprite, it's not possible with this loader.


Feature/1857 feature card block

Related Ticket(s)
https://app.zenhub.com/workspaces/ibmcom-library-5d449f3642eb1962336cbe52/issues/carbon-design-system/ibm-dotcom-library/1857
Description
Develop new FeatureCardBlockLarge block using functional and design specs

FeatureCardBlockLarge will be added to menu of patterns

Also need to export it in .../packages/react/src/patterns/blocks/index.js


3.14.x branch fix for travis

Fixes build on development versions by installing the okhttp-testing-support jar locally
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  36.691 s
[INFO] Finished at: 2019-04-24T20:23:16+01:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal on project okhttp-testing-support: Could not resolve dependencies for project com.squareup.okhttp3:okhttp-testing-support:jar:3.14.2-SNAPSHOT: Could not find artifact com.squareup.okhttp3:okhttp:jar:3.14.2-SNAPSHOT in sonatype-nexus-snapshots (https://oss.sonatype.org/content/repositories/snapshots) -> [Help 1]

Watching build here https://travis-ci.org/square/okhttp/builds/524151745?utm_source=github_status&utm_medium=notification to avoid extra spam of partial fixes


cann't work in Win10 and Windows server 2016

To run "wacs.exe", it print this info:
=====================================================
Error while creating logger: The source was not found, but some or all event logs could not be searched.  Inaccessible logs: Security. -    at System.Diagnostics.EventLog.FindSourceRegistration(String source, String machineName, Boolean readOnly, Boolean wantToCreate)
at System.Diagnostics.EventLog.SourceExists(String source, String machineName, Boolean wantToCreate)
at System.Diagnostics.EventLog.SourceExists(String source, String machineName)
at Serilog.Sinks.EventLog.EventLogSink.ConfigureSource(EventLog log, String source)
at Serilog.Sinks.EventLog.EventLogSink..ctor(String source, String logName, ITextFormatter textFormatter, String machineName, Boolean manageEventSource, IEventIdProvider eventIdProvider)
at Serilog.Sinks.EventLog.EventLogSink..ctor(String source, String logName, ITextFormatter textFormatter, String machineName, Boolean manageEventSource)
at Serilog.LoggerConfigurationEventLogExtensions.EventLog(LoggerSinkConfiguration loggerConfiguration, String source, String logName, String machineName, Boolean manageEventSource, String outputTemplate, IFormatProvider formatProvider, LogEventLevel restrictedToMinimumLevel, IEventIdProvider eventIdProvider)
at PKISharp.WACS.Services.LogService..ctor()
Platform:

OS: Windows 10, Windows Server 2016
Version: 1909, 64-bit, pluggable

Which version of the software are you running? This should be fixed in version 2.1.1. If you're on 2.1.0 the workaround is to run as administrator (at least the first time).


converging with Prickle

What I see is that boopickle is very similar to Prickle in terms of API but uses binary format instead of json one. I wonder is it possible to separate API from the format in a way that by changing one implicit I will be able to switch between json and binary and vice versa?

that's more of a scala question, you have to define a trait for that

The implementations are already diverging, so this is not going to work.


feat: add UI

👀

Can't wait!!

Hi, is there any progress made on this?
If yes, I suggest adding a "go home" button to go back to the / route, since the only way to do that right now is to modify the path on the search bar.

Hi, is there any progress made on this?
If yes, I suggest adding a "go home" button to go back to the / route, since the only way to do that right now is to modify the path on the search bar.

@Akryum is cooking !


trustify-operator-0.1.0-alpha.1

Automated changes by create-pull-request GitHub action

Closing as it was a test


Repackaging Checkpoint and Domain Tools Solution

Required items, please complete
Change(s):

Added workbook and other recent updates

Reason for Change(s):

Incorporating changes in PR #7555 and #7557

Version Updated:

Required only for Detections/Analytic Rule templates
See guidance below

Testing Completed:

Check Point Solution Testing Document

Checked that the validations are passing and have addressed any issues that are present:

See guidance below

Guidance <- remove section before submitting

Before submitting this PR please ensure that you have read the following sections and filled out the changes, reason for change and testing complete sections:
Thank you for your contribution to the Microsoft Sentinel Github repo.

Details of the code changes in your submitted PR.  Providing descriptions for pull requests ensures there is context to changes being made and greatly enhances the code review process.  Providing associated Issues that this resolves also easily connects the reason.

Change(s):

Updated syntax for XYZ.yaml

Reason for Change(s):

New schema used for XYZ.yaml
Resolves ISSUE #1234

Version updated:

Yes
Detections/Analytic Rule templates are required to have the version updated

The code should have been tested in a Microsoft Sentinel environment that does not have any custom parsers, functions or tables, so that you validate no incorrect syntax and execution functions properly.  If your submission requires a custom parser or function, it must be submitted with the PR.

Testing Completed:

Yes/No/Need Help

Note: If updating a detection, you must update the version field.

Before the submission has been made, please look at running the KQL and Yaml Validation Checks locally.
https://github.com/Azure/Azure-Sentinel#run-kql-validation-locally

Checked that the validations are passing and have addressed any issues that are present:

Yes/No/Need Help

Note: Let us know if you have tried fixing the validation error and need help.

References:

Guidance for Detection checks
General contribution guidance
PR validation troubleshooting

Looking into this

Looks good here


Support + doc for audio

I'm not sure this piece of doc should necessarily end up in the main README, but I think there should at least be a pointer to it there.

Will you be backporting this into thud/warrior as well?

We probably will next time we do a backporting round. I don't see why not.
I'll hold off on adding it to the troubleshooting documentation until it's at least in thud, so people can use it directly.

Manually tested, I can show you when you're back @patrickvacek


3658 adding updating with history rewrite feature

What was done:

Added new method doUpdateWithHistoryRewrite in BaseHapiFhirResourceDao.java to support this new feature in update
Added new method updateHistoryEntity in BaseHapiFhirDao.java to update the table entries
Refactored out notifyInterceptors to handle the 2 cases where interceptors needs to be notified from the updateInternal method, is now also used in updateHistoryEntity
Refactored out getResourceBinary to from populateResourceIntoEntity since it's also needed in updating historical version of the resource
Refactored out getExcludedElements for the same reason as above
Added new setting to DaoConfig.java to support this operation
Added new fluent for the update history rewrite api call, changes were in the following:

IGenericClient.java
IUpdateWithRewrite.java
IUpdateWithRewriteExecutable.java
IUpdateWithRewriteTyped.java
MethodUtil.java

Added new permission to allow this operation for a user, changes were in the following:

IAuthRuleBuilderRule.java
IAuthRuleBuilderUpdateHistoryRewrite.java
RuleBuilder.java
RuleImplOp.java
RuleImplUpdateHistoryRewrite.java

Overall looks great!, but theres enough changes that need to be made that I'm going to set it to request changes. This is a pretty big feature, so we want as much coverage as possible. The parts I'm most concerned about are:

What happens in the case of current resource version (with history number included, e.g. _history/3)  when the setting is enabled. Ensure that theres no new entries in the table.
The RuleBuilder is just unfamiliar enough to me that I'm not sure this implementation is solid. I'm going to delegate to another dev to review that chunk.
The IGenericClient has no new tests in it for new behaviour.
The RuleBuilder has no new tests in it for the new behaviour.

@tadgh for 3., the tests are written on the cdr side, should I move those over, or write more tests on the hapi side?


Windows 8 Issue?

I recently downloaded this program on a Windows 8 PC. Once I launched it, nothing happened (the program didn't appear). I checked task manager and it seems that when I open the program, it only opens for a few seconds, then disappears.

Do you have .NET 4.7.2 installed? https://dotnet.microsoft.com/download/dotnet-framework-runtime/net472

Windows 8 does not support .NET 4.7.2, however, I have installed the latest supported version of .NET, which was .NET 4.6.

If you are still running Windows 8, I urge you to upgrade to 8.1. You are not receiving important security updates anymore since 2016, and 8.1 is compatible with 4.7.2. It is a free upgrade, as well.
https://support.microsoft.com/en-ca/help/15288/windows-8-update-to-windows-8-1
https://docs.microsoft.com/en-us/dotnet/framework/get-started/system-requirements


fix: use mocked date in EarnPoolInfoScreen test

Description
As the title.
Also fixes the following warning in the tests by updating the way we are using MockedNavigator in the tests.
Looks like you're passing an inline function for 'component' prop for the screen 'MockedScreen' (e.g. component={() => <SomeComponent />}). Passing an inline function will cause the component state to be lost on re-render and cause perf issues since it's re-created every render. You can pass the function as children to 'Screen' instead to achieve the desired behaviour.

Test plan
n/a
Related issues
n/a
Backwards compatibility
Y
Network scalability
If a new NetworkId and/or Network are added in the future, the changes in this PR will:

[ ] Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)

Merging bypassing branch protections as the E2E workflows are being fixed separately


When app is backgrounded on the media player, cannot resume if system destroys app

When in the fullscreen media player placing the app in the background and then using other apps until NES is killed by the system, when opening the app it will attempt to resume being on the fullscreen media player but no media is loaded so a spinner will occur forever.
Either push the user back to the selected show or reload the media when this happens.

(just personally really hope reload the media and at the correct time in the track)
(there may be ways to help keep the app from being killed. i've seen some others do tricks but i'm not sure of the current state of affairs)


feat: add skip-nav support to the navbar component

This is what our skip-nav looks like today, and no visual changes are happening as part of this work:

As part of DE49505, we'd like to fix:

The semantics of our skip-nav: Make it a link instead of a button, since assistive technology users expect it to be a link.
Tweak the behaviour: Previously, we would focus on the page's <h1> and then fall back to a placeholder element after the navbar. In practice, the focusing on the placeholder never worked (focus would get lost). Instead, we first want to find a <main> element (or [role="main"]), then fall back to the <h1> and finally fall back to the first focusable element after the navbar.

At first I just added this functionality directly to <d2l-navigation>, but because that made it extend LocalizeDynamicMixin, I noticed that the extra rendering delay that caused broke a bunch of timing-sensitive things in the LMS (the link chomping specifically). So to be extra safe, I instead made <d2l-navigation-skip> its own component.

I'm a tad worried that focusable span was working in some weird client-specific edge case

We render a <div role="main"> on all our MVC and legacy pages (even blank page), so I think we're good.


added Telegram support. Lyrics are now sent over via a bot.

Thanks for the PR. Telegram support is not something I'm interested in for my version of the code - probably best to just keep that in your fork :-)


:pen: update readme

Codecov Report

Merging #20 (470f9cb) into main (48f9af9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #20   +/-   ##
=======================================
  Coverage   80.43%   80.43%
=======================================
  Files          23       23
  Lines         782      782
=======================================
  Hits          629      629
  Misses        153      153

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48f9af9...470f9cb. Read the comment docs.


Add resource to Helpful Pages & Articles.md

Add Pythonium (my website), an online collection of Python tools (Regex tester, code checker, ...) , to Helpful Pages & Articles.md

I will try to help you, thank you for sharing with me, the next release next week you will see your project. I will try to double-check what is it, thanks for your advice bro @cyr1l0u

I will drop your PR with combining from my release this weekend. I hope you can enjoy my wiki and contribute to your something.


container has no permissions on USB device

Checklist

[X]  I am not using Home Assistant. Or: a developer has told me to come here.
[X] I have checked the troubleshooting section and my problem is not described there.
[X] I have read the changelog and my problem is not mentioned there.

Deploy method
Docker
Z-Wave JS UI version
9.0.1
ZwaveJS version
12.0.0
Describe the bug
After upgrading from 8.26 to 9.0, the container no longer has rights to the key.
Before :

After :

I use zwave js ui in a podman container, my podman run :
podman run -dt --name zwavejs -v /etc/localtime:/etc/localtime:ro -p 8091:8091 -p 3000:3000 \
--device /dev/serial/by-id/usb-0658_0200-if00:/dev/ttyACM0 -v /data/2_daily/zwavejs/config:/usr/src/app/store \
--group-add keep-groups zwavejs/zwavejs2mqtt:latest

Normally --group-add keep-groups for using device in podman ct is the good thing to do.
It seems to be the same as on this issue :
https://github.com/zwave-js/zwave-js-ui/issues/1894
And disabling "soft reset" fix the problem.
To Reproduce

Run the latest docker image
Get permission denied on /dev/ttyACM0

Expected behavior
I should be able to access /dev/ttyACM0 inside my container
Additional context
If i rollback to 8.26 everything works again without disabling "soft reset"

@Herbs851 Nothing has changed on code that could cause this, I think this is something related to podman or other tools that you are using to run the container

Thanks for you reply.
I'll investigate podman side.
last question: is there any risk in deactivating "soft reset" ?

@Herbs851 You shouldn't disable it, you should instead use /dev/serial/by-id path

I'm not sure I understand.
I should change ?
--device /dev/serial/by-id/usb-0658_0200-if00:/dev/ttyACM0
to
--device /dev/serial/by-id/usb-0658_0200-if00:/dev/serial/by-id/usb-0658_0200-if00

Oh nope sorry I didn't saw you were already using the by-id mapping. It's ok to use it like you are doing now, maybe try to change /dev/ttyACM0 with /dev/zwave and use that inside the container.

Unfortunately it doesn't work :

@AlCalzone Can this be related to https://github.com/zwave-js/node-zwave-js/issues/6341 ?

Not sure about podman, but at least Proxmox/LXC requires setting the ACL as part of udev rules:
https://github.com/AlCalzone/ioBroker.zwave2/blob/master/docs/en/vm-usb.md#proxmoxlxc
I assume this is because the stick reconnects during soft-reset and the ACL isn't restored properly. I'd recommend looking into that first and only disable soft-reset if you don't find a solution.

@robertsLando  @AlCalzone
Thanks for support.
I've updated the Aeotec Gen5 firmware to version 1.2 => no effect
I've also tried :
KERNEL=="ttyACM[0-9]*", SUBSYSTEM=="tty", ATTRS{idVendor}=="0658", ATTRS{idProduct}=="0200", SYMLINK="k-zwave", MODE="0777", GROUP="users"

and
KERNEL=="ttyACM[0-9]*", SUBSYSTEM=="tty", ATTRS{idVendor}=="0658", ATTRS{idProduct}=="0200", SYMLINK="k-zwave", MODE="0777", GROUP="dialout"

And then in "my podman run"
--device /dev/k-zwave:/dev/ttyACM0
But no effect either, after that I have to admit that I'm not very comfortable with the udev rules.

To be honest I have no clue about podman and USB either.
You may just have to disable soft-reset in the options manually. Z-Wave JS probably did that for you on the old version, but it no longer does.

ok, so let's go deactivate "soft reset".
Thank you both for your help ;) !!!


Taking a photo freezes app on iOS 10

Bug
When taking a photo app freezes on iOS 10 with the following errors in the output. We are setting NSCameraUsageDescription and NSPhotoLibraryUsageDescription. And played around with setting the UiViewControllerBasedStatusBarAppearance after some suggestions in StackOverflow posts.
CGContextAddPath: invalid context 0x0.
invalid context 0x0.
CGContextSetFillColorWithColor: invalid context 0x0.
CGContextFillRects: invalid context 0x0.
Version Number of Plugin:  2.6.0-beta1,
ios10camera.txt
2.3.0
Device Tested On: iPad Air 2 iOS 10, iPad Air iOS 10
Simulator Tested On: None
Expected Behavior
Opens the camera view
Actual Behavior
App freezes
Steps to reproduce the Behavior
Call CrossMedia.Current.TakePhotoAsync(...)
Feature Request:
For the app not to freeze

What does your code look like in general? I have updated my test app and testing against iOS 10 devices and working nicely here...

It is an Xamarin Forms app running on the iOS devices. Basically a button with a command that calls TakePhotoAsync. I tried it in both Modal and non Modal pages.
 public ICommand OnTakePhotoCommand => onTakePhotoCommand ?? (onTakePhotoCommand = new Command(async () => await OnTakePhoto()));

       private async Task OnTakePhoto()
        {
            if (!CrossMedia.Current.IsCameraAvailable || !CrossMedia.Current.IsTakePhotoSupported) return;
            await CrossMedia.Current.Initialize();
            using (var mediaFile = await CrossMedia.Current.TakePhotoAsync(new StoreCameraMediaOptions()))
            {
                if (mediaFile != null)
                {
                }
            }
        }

What version of Xamarin and what version of Xcode are you building against? My tests locally have been good on iOS 10 devices.
Also, your initialize() should be the VERY first thing you do before IsCameraAvailable :)

I am unable to reproduce on my iPhone 6 or iPad Pro with my test applications. Attempt to run and checkout the test apps that I have in the test folder as they are working for me.
Are you using Xamarin.Forms or Traditional UIs? I could test that route with Forms and see if something is broken there.

I am on Xamarin Forms. The latest version of Xamarin and Xcode. It has been the same on all versions coming out since iOS 10, before iOS 10 everything was working so I am not sure what changed except the privacy settings. It has also been the same on all iterations of the plugin from stable to the latest beta.
I will try your sample app. We have tried multiple of ours app and different deploys (macs, bitrise) without luck.

I tried your exact code and it is working great on my iPad Pro running 10.0.2. Here it is:
TestApp2.zip

So it seems like the culprit is adding the line below in FinishedLaunching in the AppDelegate class. It seems like this should be OK and it worked in iOS 9. Does this freeze the UI on your end too?
UISlider.Appearance.MinimumTrackTintColor = UIColor.Orange;

Hi.
Did you manage to reproduce the issue when setting the MinimumTrackTintColor?

Seems like it isn't related to the plugin at all so I haven't attempted to look at it at all. Maybe a change in ios10

@ddklo Did you ever get to the bottom of this issue, we're seeing very similar behaviour.

No, havent had time to look into it further. We ended up not setting the MinimumTrackTintColor. It would probably work applying the UISlider appearance in a custom renderer. But hopefully its a bug in iOS that get fixed or @jamesmontemagno finds a way to work around the bug in this library.


Snapshotter improvements, browserstack support

Some improvements to snapshotting:

Encapsulate the snapshotting logic in its own class/file.
Make an implementation for browserstack. The API contract is that a snapshotter must implement the method snapshot(url).
If we have browserstack credentials configured, use browserstack for snapshotting. Otherwise, fall back to PageSnap (less reliable/stable/capable).

Browserstack config is two env vars: BROWSERSTACK_USER, BROWSERSTACK_KEY.

And to be clear, I think this is good to go. If nobody has any feedback by tomorrow morning, I’ll merge it in. Definitely will be happy to offload the snapshotting stuff to Browserstack.


docs: fixes 3084

This PR covers doc issues that were discussed during a meeting with Max on Nov. 05, 2024.
@mkurapov Tagging you because of the YAML updates. Also, the OpenAPI spec for IdP is missing Continue Grant POST /interact/{id}/{nonce}. Is that intentional or should I create an issue for it?

Also, the OpenAPI spec for IdP is missing Continue Grant POST /interact/{id}/{nonce}. Is that intentional or should I create an issue for it?

Continue Grant POST is for the Open Payments Auth API, so shouldn't be in the IdP spec


Add random-boolean to readme

https://github.com/sindresorhus/random-float/commit/8affeb2f4880b81fdc62aba9aa597e4d7d657c4f#commitcomment-11894597

Can you place it below random-item? It's sorted by how often I would use them.
Also feel free to commit directly for smaller changes like this.

Can you place it below random-item? It's sorted by how often I would use them.

Sure.

Also feel free to commit directly for smaller changes like this.

I don't have push access to this repo (yet)

Oh, right. You do now.

We need something to automate that too :) Thanks! I'll take care of this.


Add support for grouping/namespacing mirrored git repositories

Currently, all repositories are mirrored to /Library/GitMirrors, but that leaves an opportunity for name conflicts if two repositories have the same name.
For GitHub repositories, repositories are already grouped/namespaced by user name within the repo URI, so that could be automatically parsed and utilized.
Some additional method of manually grouping/namespacing repositories should be provided as well. I propose adding a group ([<group>]) directive to the config file. Any repositories listed after such a directive would be stored in a folder of the same group name (within Library/GitMirrors). I'd also suggest a built-in [auto] group which would try to parse the group name from the repo URI (as mentioned above). Example tiggit.conf:
[auto]
https://github.com/morgant/tiggit.git
[tobuji]
https://example.com/some-path/other-repo.git

The above would result in the following directory structure:
/Library/GitMirrors/morgant/
/Library/GitMirrors/morgant/tiggit.git
/Library/GitMirrors/tobuji/
/Library/GitMirrors/tobuji/other-repo.git

I have added the initial grouping support, but still need to add parsing of GitHub URIs.

And, I have added auto grouping support for GitHub URIs.

Documented in the README, so this is done.


browser support

We need client support for internet browsers.
Should we rely on an html5 websocket implementation and do a separate browser logic?

Browser tests should also be included.
#zuul
#saucelabs

What about this issue? Generally current Client logic is fully appropriate for browser usage. The only main problem, as i see, is uws usage, which must be replaced with native WebSockets for browser.

Hi, @soulhunter1987!
For the browser we use browserify, which will take care of our client code.
After installing rpc-websockets, you can copy file ./dist/index.browser.js to your frontend code, since browserify bundled the entire library there for you.
An RPCWebSocket class is exposed there for you to use.
This is an example html: https://gist.github.com/mkozjak/fa9296484c40445af516e563c65536bf
Cheers!

That will do the job but, not very efficiently. It would be good to also allow compiling from source with webpack or some other bundling tools. That would allow to write ES6-style code and then bundle (and may be transpile for old browsers) it as appropriate for the project. Also it would reduce size of resulting bundle, because repeating dependencies would be included only once.

Automatic updates via npm/yarn are also not available with this approach, because one will need to copy new file to his project's public directory (of course that may be automated, but that's extra work).

index.browser.js is really HUGE now, because it includes uws (which is not needed there at all), eventemitter and many other libraries, which may already be used in the project.

Agreed. TBH, I'm not really experienced with bundlers, so could you point me in the right direction with some examples, maybe? Also, PR welcome!

First of all you need to supply "src" directory in the package along with "dist".
Then one approach is to manually import and pass "transport" object (uws or browser websocket) to Client constructor via dependency injection.
NodeJs usage would look like this then:
import WebSocket from 'uws'
import {Client} from 'rpc-websocket';

connection = new Client(address, options, WebSocket)
connection.call(...)

And browser ES6 code would be:
import {Client, WebSocketWrapper} from 'rpc-websocket';

connection = new Client(address, options, WebSocketWrapper)
connection.call(...)

where "WebSocketWrapper" is your src/lib/client/websocket.browser.js wrapper class.
So with this approach you give users a choice which transport to use. And it would allow usage of any other transport which implements compatible interface.

If you create a separate branch with this solution implemented - I could try and test it's browser usage.

@soulhunter1987: Can you please give me an example library/project where both src and dist are shipped and dependencies are handled like described?

@mkozjak mongoose handles this situation pretty well without needing to publish the dist. I might be able to put together a PR sometime today.

@dstreet: I believe you meant 'src', since the dist directory should definitely be published. :)

@mkozjak I got slammed with some other project work. I'm not sure when I'll have time to get to this, sorry.

Finally got some time to work on this. I'll submit a PR soon.

Submitted PR #13. @soulhunter1987 can you test this on your end?

Awesome work, @dstreet! Thanks!
Will wait for @soulhunter1987 to check up on it just in case and publish the update afterwards.

Great, thanks!

@soulhunter1987 Do you think you'll have time to review this soon? Turns out I need this for a project I'm working on.

@dstreet I will publish this release now. If it works for you, I am okay with it.

@mkozjak Looks like you forgot to rebuild the dist before publishing to npm. I apologize if this was a miscommunication on my part

@dstreet I forgot to include the dist directory altogether. It was still in .gitignore.

@dstreet Published. Can you check on it, please?

Still broken, but I found where the problem is. commit 2c20dddd5b87347189fc7e3e02084285b9aea00b reverted the change I had made to the build script


Sail install failed on mac monterey : permission denied

Sail Version: 1.15.4
Laravel Version: 9.26
PHP Version: 8.1
Host operating system: macOS 12.5.1

Description:
I'm simply trying to install sail on my dev machine and it failed as on my screen capture
Steps To Reproduce:
no more commands than explained in documentation : composer install, php artisan sail:install

I can use Sail just fine right now on macOS Monterey. Please try a support channel:

Laracasts Forums
Laravel.io Forums
StackOverflow
Discord
Larachat
IRC

I just found a solution : I made a chmod +x ./vendor/bin/sail and chmod -R +x ./vendor/laravel/sail/ and now it's ok


[BUG] missing preset info for microshift on config command

On pre-released version CRC version: 2.16.0+05b62a75 when getting information for config options on presets, there is no value for microshift:
preset                               Virtual machine preset (valid values are: podman, openshift and okd)

fixed in #3580


tour: { starting in a newline after the function definition results in compilation error

Context: http://<IP_ADDRESS>:3999/basics/4
Having { starting in a newline after the function definition and hitting Format results in prog.go:10:1: unexpected semicolon or newline before {. Below is the code that reproduces the issue.
package main

import "fmt"

func add(x int, y int) int {
	return x + y
}

func main()
{
	fmt.Println(add(23, 1))
}

Hitting Run will also show additional details around the compilation error.
# command-line-arguments
./compile6.go:9:6: missing function body
./compile6.go:10:1: syntax error: unexpected semicolon or newline before {

Hi,
not allowed in go. See the "why can't I put the opening brace on the next line?" FAQ. Closing here, since this is working as intended.

Gotcha, thanks for clarifying.


Drop unused profiles for artifacts distribution

What changes were proposed in this pull request?
Drop unused profiles for artifacts distribution
How was this patch tested?
Jenkins
Quick checklist
The following checklist helps ensure your PR is complete:

[ ] Eclipse Contributor Agreement signed, and signed commits - see IP Requirements page for details
[ ] Reviewed the Contributing Guidelines and followed the steps within.
[ ] Created tests for any significant new code additions.
[ ] Relevant tests for your changes are passing.

Not sure if we need skymindnexus-skil, what do you think @AlexDBlack ?

@sshepel

Not sure if we need skymindnexus-skil, what do you think @AlexDBlack ?

Yeah, I'm not aware of any reasons we need that... it can be removed also.

Yeah, I'm not aware of any reasons we need that... it can be removed also.

Done


SCHEME_ERROR during "ydb auth get-token" step

fatal: [static-node-1.ydb-cluster.com]: FAILED! => {"attempts": 10, "changed": false, "msg": "command: \"ydb auth get-token\" failed", "stderr": "(!) New version of YDB CLI is available. Run 'ydb update' command for update. You can also disable further version checks with 'ydb version --disable-checks' command\n/opt/buildagent/work/3e574e3efc81dc20/tag/ydb/public/sdk/cpp/client/ydb_types/credentials/login/login.cpp:192: SCHEME_ERROR\n", "stderr_lines": ["(!) New version of YDB CLI is available. Run 'ydb update' command for update. You can also disable further version checks with 'ydb version --disable-checks' command", "/opt/buildagent/work/3e574e3efc81dc20/tag/ydb/public/sdk/cpp/client/ydb_types/credentials/login/login.cpp:192: SCHEME_ERROR"]}

If you encounter this, check server logs: https://ydb.tech/docs/en/devops/ansible/observability/logging


Option to disable URL escaping

Using this add-on will URL escape the input before sending it to the defined site.
For some search engines the URL should not be escaped when it is a URL you are actually searching for.
I don't know if this behaviour is Firefox search related or add-on related though. If the latter is the case it would be good to have an option per search engine to prevent URL escaping.
Suppose you add the Wayback Machine as a search engine.
The URL would be "https://web.archive.org/web//%s", with a valid search query being "https://web.archive.org/web//https://example.com". Now the search query is being transformed to "https://web.archive.org/web/*/https%3A%2F%2Fexample.com" and the search will fail.

Unfortunately this is managed by the browser, no way to alter this behavior.


Link to blog post is broken

The link to your blog post, as stated in your README, is broken FYI.

Thank you very much for pointing that out, it's fixed now


[WIP] Add --layers and --no-cache to buildah bud

This patch adds in the caching feature to buildah bud.
Signed-off-by: umohnani8<EMAIL_ADDRESS>

Working on tests, completions and docs.
@rhatdan @TomSweeneyRedHat  can you please pull these changes in and play around with it a bit. I have tried to hit every case I could find, but it is possible i missed/messed up something.

@umohnani8 looks like test unhappiness.  I'm pulling now to test fwiw.

Looks like buildah from scratch isn't happy with his patch.  The other tests that don't use scratch in the baseline tests passed with this patch though.
# buildah from scratch
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x38 pc=0xa136db]

goroutine 1 [running]:
github.com/projectatomic/buildah.newBuilder(0xcbaa40, 0xc4200260b0, 0xcc9080, 0xc420486c60, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
	/tmp/tsweeney/workspaces/buildah/src/github.com/projectatomic/buildah/new.go:338 +0xd4b
github.com/projectatomic/buildah.NewBuilder(0xcbaa40, 0xc4200260b0, 0xcc9080, 0xc420486c60, 0x7ffdc8ac05d3, 0x7, 0x0, 0x0, 0x0, 0x0, ...)
	/tmp/tsweeney/workspaces/buildah/src/github.com/projectatomic/buildah/buildah.go:365 +0x97
main.fromCmd(0xc4200c54a0, 0x0, 0xf3)
	/tmp/tsweeney/workspaces/buildah/src/github.com/projectatomic/buildah/cmd/buildah/from.go:224 +0x654
github.com/projectatomic/buildah/vendor/github.com/urfave/cli.HandleAction(0xb12c60, 0xc51f78, 0xc4200c54a0, 0x0, 0xc42036de00)
	/tmp/tsweeney/workspaces/buildah/src/github.com/projectatomic/buildah/vendor/github.com/urfave/cli/app.go:501 +0xc8
github.com/projectatomic/buildah/vendor/github.com/urfave/cli.Command.Run(0xc17a44, 0x4, 0x0, 0x0, 0x0, 0x0, 0x0, 0xc389ef, 0x2c, 0x0, ...)
	/tmp/tsweeney/workspaces/buildah/src/github.com/projectatomic/buildah/vendor/github.com/urfave/cli/command.go:165 +0x47d
github.com/projectatomic/buildah/vendor/github.com/urfave/cli.(*App).Run(0xc420020700, 0xc42001e090, 0x3, 0x3, 0x0, 0x0)
	/tmp/tsweeney/workspaces/buildah/src/github.com/projectatomic/buildah/vendor/github.com/urfave/cli/app.go:259 +0x6e8
main.main()
	/tmp/tsweeney/workspaces/buildah/src/github.com/projectatomic/buildah/cmd/buildah/main.go:107 +0xbff

Missing man pages and command completion.

missing tests too

Still missing man pages and completions.

Using filepath.Glob instead for pattern matching. Add docs, completions, and tests.

Fixes https://github.com/projectatomic/buildah/issues/601

Tests are happy. @rhatdan @TomSweeneyRedHat @nalind PTAL

Awesome job @umohnani8
LGTM

@pixdrift PTAL

@rh-atomic-bot r+

I'd a test machine hiccup with Docker, but after I fixed that, the baseline tests passed.


Update Docs: Shell Agnostic Method

I've discovered I can use a shell agnostic implementation in place of manually wiring up a shell script in BASH, etc. It makes use of npm link functionality. There's a screen shot below of what's needed. I'm working on a PR to submit that should reflect this in the readme.
Required:

a repo (project dir) w/ _redirects file and a package.json with baseUrl and shorten script values

Add:

to the package.json:"bin": { "shorten": "cli.j.s" }

to the project, add cli.js with the following:#!/usr/bin/env node
require('netlify-shortener');

optional: *nix permissions, chmod +x cli.js

Register:

from your project dir, run npm link, which will register your project's bin names against their respective actions, running from your project path

Use remains the same, with shorten <url> <name> syntax.

I love it! Yes, if you can add docs on how to do that, I'd appreciate it :)

It'll follow the description above (minus screen shot), but I'll try to make it readable for nearly anyone.

I've created the PR. Let me know if we should massage the description; I tried to make it easy enough for someone with little experience to follow.

Perfect. I like it :+1:


Add util OsResources.resources_for_tx_type

Replaces common idiom. Also move getter after new, which should be the
first function.

Stack:

#1181
#1180
#1179 ⬅
#1178
#1177
#1176
#1175

⚠ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

This change is

Codecov Report
Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (9c6a5eb) 68.91% compared to head (ac0d74a) 68.85%.

Files
Patch %
Lines

crates/blockifier/src/fee/os_usage.rs
80.00%
0 Missing and 1 partial :warning:

Additional details and impacted files
@@                              Coverage Diff                              @@
##           pr/giladchase/gilad/os-resources/67f489ab    #1179      +/-   ##
=============================================================================
- Coverage                                      68.91%   68.85%   -0.06%
=============================================================================
  Files                                             57       57
  Lines                                           7097     7087      -10
  Branches                                        7097     7087      -10
=============================================================================
- Hits                                            4891     4880      -11
  Misses                                          1791     1791
- Partials                                         415      416       +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Flutter: Unable to initialize() in Chrome web application due to reliance on Platform._operatingSystem

When calling initialize() from a DockerCommander(DockerHostLocal()) object, I get an error when using Chrome.
This is not the case when using a Windows application.
I only bring this up because the package on pub.dev says that it is compatible with the web platform which is something that I would prefer to use in my use case. That is why I chose this package.
Let me know if there are any clarifications you need!
Replicate

Put the example code into a Dart function anywhere (as long as you can call it). I called mine startDockerDemo.
Call the function via a Flutter widget
I used a text button to call the function, like so (note that cn is just a reference to the separate file where I have the function stored):

Run using "Chrome (web-javascript)" device
Observe error
Run again using "Windows (windows-x64)" device
Will run the demo as expected

Chrome (web-javascript) debug output (snippet - see full below)

Windows (windows-x64) debug output

Full debug output from Chrome (web-javascript)
Restarted application in 232ms.

Next, you will need to use the remote version:
var dockerCommander = DockerCommander(DockerHostRemote(host, port, username: '...', password: '...'));

Additionally, you will require a DockerCommander server. Please refer to the example at:
https://github.com/gmpassos/docker_commander#remote-docker


Added EditorConfig

Using EditorConfig for sharing common formatting

Coverage remained the same at 83.951% when pulling 82a7b5e56c5570aa8eac40c327bca499090a8649 on add_editorConfig into 085e3f1f83772694db391953d106d369453158ef on master.

+1


Created and added a logo

Hello @euanwm I created and added a logo to the index.html and search.html files. Check to see if you like the logo. Thank you.

Hello @euanwm I've made the suggested adjustments.


where to place .pkl model files?

Hi,
Thanks for the fantastic repo,
I really want to drop a custom .pkl model file into LucidSonicDreams and it isn't obvious to me where I should put it? I'm working in Colab for the time being.
Thanks,
Mark

my bad, realised that I just need to mount my google drive and specify a path in the style argument