Fb 4713 assay refactor

I don't know much... but from reading various posts (e.g., https://stackoverflow.com/questions/2314652/is-it-possible-to-move-rename-files-in-git-and-maintain-their-history), I'm not sure line endings are at fault here. It appears that (unlike SVN) Git doesn't track renames or moves at all, rather, various log/merge tools detect renames & moves after the fact (or they don't). I don't know why the GitHub viewer recognizes some of the renames but not others. However, when I view NabUrls and AssayDomainKind (post move, commit, push to FB) in IntelliJ, I see the full history and line-by-line annotations. Not sure there's anything we can do to make GitHub behave better with file moves.

Seems like CODEOWNERS should have been deleted by my recent merge from develop, but I deleted it here.
Also updated .gitattributes with hundreds of changes. #tedious


GUVNOR-2680: VersionRecordManager: Index Out of Bounds when opening a deleted file

See https://issues.jboss.org/browse/GUVNOR-2680
@Rikkola could you please review. I may have fixed a symptom not the cause (as presumably VersionService may have used to always return at least one VersionRecord). It could be the regression was introduced with the refactoring done for asset vs meta-data VersionRecords.
If this "patch" is of a symptom and not the cause feel free to say!

Jenkins please retest this.

I guess it makes sense that the file has not VersionRecord if it is deleted.
With Git it would be possible to get the full history including the commit that deleted the file, but I guess we should not expose too much of the Git underneath. Git is pretty much the only file system type that could support this.

Again nice clean fix.
+1

Thanks @manstis


add void return type to PsrLogger methods

PsrLogger should match return types from LoggerInterface v3.0.0

emergency:
https://github.com/php-fig/log/blob/master/src/LoggerInterface.php#L30

alert:
https://github.com/php-fig/log/blob/master/src/LoggerInterface.php#L43

critical:
https://github.com/php-fig/log/blob/master/src/LoggerInterface.php#L55

error:
https://github.com/php-fig/log/blob/master/src/LoggerInterface.php#L66

warning:
https://github.com/php-fig/log/blob/master/src/LoggerInterface.php#L79

notice:
https://github.com/php-fig/log/blob/master/src/LoggerInterface.php#L89

info:
https://github.com/php-fig/log/blob/master/src/LoggerInterface.php#L101

debug:
https://github.com/php-fig/log/blob/master/src/LoggerInterface.php#L111

log:
https://github.com/php-fig/log/blob/master/src/LoggerInterface.php#L124

We've seen the following error in Google App Engine Standard runtime PHP 8.1:

PHP message: PHP Fatal error:  Declaration of
Google\Cloud\Logging\PsrLogger::emergency($message, array $context = [])
must be compatible with
Psr\Log\LoggerInterface::emergency(Stringable|string $message, array $context = []): void
in /workspace/vendor/google/cloud/Logging/src/PsrLogger.php on line 168

This error was worked around using "psr/log": "2.0.0" as a dependency instead of v3.0.0.
LoggerInterface v2.0.0 did not have explicit return types, but v3.0.0 does explicitly declares void return types.

Hi @ghux 👋 , thanks for the PR - but unfortunately we can't accept this addition right now as the void return type was introduced in a version of PHP greater than our lowest supported version. What we can do is add a conflict in the composer file for when users attempt to install psr/log v3, I've done that here if you wouldn't mind taking a look :).

Hello @dwsupplee 👋🏼 !
This should work for now.
QQ: are there any plans to support psr/log version 3.0.0?

We will be dropping support for older versions of PHP in this half of the year, along with some other breaking changes. We will definitely evaluate how to handle supporting psr/log 3 as well.

Great news! Thank you !


Gurobi.jl v0.2.8 "unable to locate Gurobi installation"

Hello,
I had Gurobi.jl installed and it worked fine until I did a Package update yesterday.
Now, with Gurobi.jl v0.2.8 I get the error "unable to locate Gurobi installation" even though GUROBI_HOME is set to the right path in terminal (If I type 'gurobi.sh' in terminal it works just fine). I use julia v0.5.0 on Ubuntu 16.04.

can you check the contents of Gurobi.jl/deps/deps.jl and confirm that it points to the correct Gurobi shared library?

There is no file called "deps.jl" in the directory .julia/v0.5/Gurobi/deps

Run Pkg.build("Gurobi") then.

I did that, still no file called "deps.jl"

Strange, can you post the output from
versioninfo()
Pkg.status()
Pkg.build("Gurobi")

versioninfo:
Julia Version 0.5.0
Commit 3c9d753 (2016-09-19 18:14 UTC)
Platform Info:
  System: Linux (x86_64-linux-gnu)
  CPU: Intel(R) Core(TM) i7-4500U CPU @ 1.80GHz
  WORD_SIZE: 64
  BLAS: libopenblas (NO_LAPACKE DYNAMIC_ARCH NO_AFFINITY Haswell)
  LAPACK: liblapack.so.3
  LIBM: libopenlibm
  LLVM: libLLVM-3.7.1 (ORCJIT, haswell)

Pkg.status():
26 required packages:
 - Atom                          0.5.6              a2ace2b1 (dirty)
 - Clp                           0.3.0              ce11ac71 (dirty)
 - Combinatorics                 0.3.2              15a86147 (dirty)
 - DataFrames                    0.8.5              49da3ccc (dirty)
 - Dates                         0.4.4              1764fc04 (dirty)
 - DriftDiffusionPoissonSystems  0.1.0              b118fe12 (dirty)
 - ECOS                          0.7.0              19898728 (dirty)
 - FastGaussQuadrature           0.1.0              b4787178 (dirty)
 - GLPK                          0.3.0              1674755b (dirty)
 - Gurobi                        0.2.8              8ae65514 (dirty)
 - IJulia                        1.3.2              4cd1a63e (dirty)
 - Ipopt                         0.2.6              959b9c67 (dirty)
 - Iterators                     0.2.0              dd9024cb (dirty)
 - JLD                           0.6.6              0d889438 (dirty)
 - JuMP                          0.14.1             c89327dc (dirty)
 - LegacyStrings                 0.1.1              2725e479 (dirty)
 - LightGraphs                   0.7.2              0bbc5f63 (dirty)
 - LsqFit                        0.0.2              9d883760 (dirty)
 - NLopt                         0.3.3              befd716a (dirty)
 - PkgDev                        0.1.3              707a1726 (dirty)
 - PyPlot                        2.2.4              12901421 (dirty)
 - SCS                           0.2.7              fe5e5d79 (dirty)
 - Sobol                         0.2.0              29d3c0ad (dirty)
 - SymPy                         0.4.0              44ef1745 (dirty)
 - TensorOperations              0.5.1              21b51520 (dirty)
 - ZMQ                           0.4.0              8a780fbc (dirty)
70 additional packages:
 - ASTInterpreter                0.0.4              f583c99c (dirty)
 - AbstractTrees                 0.0.4              38c53b5b (dirty)
 - ArgParse                      0.4.0              22f66720 (dirty)
 - AutoHashEquals                0.0.10             3542065f (dirty)
 - BinDeps                       0.4.5              115b2288 (dirty)
 - Blink                         0.5.0              64115773 (dirty)
 - Blosc                         0.1.7              897ea349 (dirty)
 - COFF                          0.0.2              39c35011 (dirty)
 - CRC                           1.2.0              a7b42744 (dirty)
 - Calculus                      0.1.15             10056bbf (dirty)
 - Cbc                           0.3.0              aed0d73a (dirty)
 - CodeTools                     0.4.3              bd2c1877 (dirty)
 - Codecs                        0.2.0              e490f404 (dirty)
 - ColorTypes                    0.2.12             a0f98987 (dirty)
 - Colors                        0.6.9              e5fe33a2 (dirty)
 - Compat                        0.9.5              3541c2df (dirty)
 - Conda                         0.4.0              da472a56 (dirty)
 - DWARF                         0.1.0              015d4053 (dirty)
 - DataArrays                    0.3.10
 - DataStructures                0.4.6              52615e84 (dirty)
 - Distributions                 0.11.1             9e4a72fe (dirty)
 - ELF                           0.1.0              07a2a38b (dirty)
 - FileIO                        0.2.0              c2b21270 (dirty)
 - FixedPointNumbers             0.2.1              ccb4267a (dirty)
 - ForwardDiff                   0.2.5              afdf6034 (dirty)
 - GZip                          0.2.20             69b67654 (dirty)
 - Gallium                       0.0.4              613ab104 (dirty)
 - HDF5                          0.7.0              3218c835 (dirty)
 - Hiccup                        0.0.3              95abcf50 (dirty)
 - HttpCommon                    0.2.6              d5201507 (dirty)
 - HttpParser                    0.2.0              fcc85783 (dirty)
 - HttpServer                    0.1.7              412e3003 (dirty)
 - JSON                          0.8.0              0e364731 (dirty)
 - JuliaParser                   0.7.4              51ec7616 (dirty)
 - Juno                          0.2.5              b967b69e (dirty)
 - LNR                           0.0.2              8d0d48e0 (dirty)
 - LaTeXStrings                  0.2.0              bfedfdc9 (dirty)
 - Lazy                          0.11.4             ad69f5ac (dirty)
 - LightXML                      0.4.0              069f51fd (dirty)
 - MachO                         0.0.4              865953f7 (dirty)
 - MacroTools                    0.3.2              7e5dbcea (dirty)
 - MathProgBase                  0.5.8              e0699bbb (dirty)
 - MbedTLS                       0.3.0              18dfb5cd (dirty)
 - Media                         0.2.4              90241245 (dirty)
 - Mustache                      0.1.2              5b17fbb1 (dirty)
 - Mux                           0.2.2              0d146ca9 (dirty)
 - NaNMath                       0.2.2              6da4a4ea (dirty)
 - Nettle                        0.2.4              f20cbb3d (dirty)
 - ObjFileBase                   0.0.4              350e2a75 (dirty)
 - Optim                         0.6.1              90f08476 (dirty)
 - PDMats                        0.5.2              83d2440b (dirty)
 - ParserCombinator              1.7.11             a0c0da6c (dirty)
 - Polynomials                   0.1.1              6bb8e2ee (dirty)
 - PositiveFactorizations        0.0.3              c1886597 (dirty)
 - PyCall                        1.7.2              be354e07 (dirty)
 - Reactive                      0.3.6              22278dcb (dirty)
 - RecipesBase                   0.1.0              700de20b (dirty)
 - Reexport                      0.0.3              bc6a5f90 (dirty)
 - ReverseDiffSparse             0.5.8              823f920c (dirty)
 - Rmath                         0.1.5              f6b155e7 (dirty)
 - SHA                           0.3.0              7a57fd67 (dirty)
 - SortingAlgorithms             0.1.0
 - StatsBase                     0.11.1             96cd82a5 (dirty)
 - StatsFuns                     0.3.1              5de325f6 (dirty)
 - StructIO                      0.0.2              56866046 (dirty)
 - TerminalUI                    0.0.2              66dd7d5a (dirty)
 - TextWrap                      0.1.6              fb405bec (dirty)
 - URIParser                     0.1.6              6ae90da6 (dirty)
 - VT100                         0.0.2              f7a02f31 (dirty)
 - WebSocket

Pkg.build("Gurobi"):
INFO: Building Gurobi
===============================[ ERROR: Gurobi ]================================

LoadError: Unable to locate Gurobi installation. Note that this must be downloaded separately from gurobi.com
while loading /home/stefan/.julia/v0.5/Gurobi/deps/build.jl, in expression starting on line 44

================================================================================

================================[ BUILD ERRORS ]================================

WARNING: Gurobi had build errors.

 - packages with build errors remain installed in /home/stefan/.julia/v0.5
 - build the package(s) and all dependencies with `Pkg.build("Gurobi")`
 - build a single package by running its `deps/build.jl` script

================================================================================

Seems there's something seriously wrong with my package manager, as every package is dirty...

Yeah, that's bizarre. I'd suggest wiping your package directory and reinstalling.

Did that, it works again now. Thanks for your help!

Glad that worked!

Hi @Stivanification @joehuchette ,
I have the same problem running Julia on cluster. May I ask what did you do exactly? Did you manually delete the Gurobi folder in .julia/v0.5/Gurobi/deps? Thanks.

No, I do not have des.jl! Just build.jl and .gitignore!

@joehuchette , I cleared the package directory using rm -rf ~/.julia/lib/v0.5 ~/.julia/v0.5/ and tried to reinstall Gurobi (and CPLEX), but still I got the built error!
===============================[ ERROR: Gurobi ]================================
LoadError: Unable to locate Gurobi installation. Note that this must be downloaded separately from gurobi.com
while loading /home/p/parsafard/.julia/v0.5/Gurobi/deps/build.jl, in expression starting on line 44
================================================================================
================================[ BUILD ERRORS ]================================
WARNING: Gurobi had build errors.

packages with build errors remain installed in /home/p/parsafard/.julia/v0.5
build the package(s) and all dependencies with Pkg.build("Gurobi")
build a single package by running its deps/build.jl script

================================================================================

@parsafard what is the output of
julia> ENV["GUROBI_HOME"]

Do you have Gurobi installed on the cluster?

@odow this is the output:
ERROR: KeyError: key "GUROBI_HOME" not found
in access_env(::Base.##339#340, ::String) at ./env.jl:45
in getindex(::Base.EnvHash, ::String) at ./env.jl:73
I can see Gurobi's name as an installed package on cluster! What about this error?

Per the installation instructions, you need to make sure that the environment variable is set so that Gurobi.jl can locate the library.

Thanks Guys! Yeah the environment variable was the problem. Solved!

Hey Guys! I had the same problem right now, but for another reason. I managed to solve it, so I'm posting the solution here to help the next.
In the /Gurobi/deps/build.jl file there was a line:
aliases = ["gurobi70","gurobi65","gurobi60","gurobi56","gurobi55"]
I modified it to:
aliases = ["gurobi75","gurobi70","gurobi65","gurobi60","gurobi56","gurobi55"]
and it worked!

@lucasaa when was the last time you ran Pkg.update()? It looks like this was already fixed in https://github.com/JuliaOpt/Gurobi.jl/pull/103 :)

@odow I ran it before trying to build the package.
After I modified the line I saw it was already fixed, but I don't know why i didn't get the updated code.

I had the same problem as @lucasaa now that Gurobi version 8.1 was released a few days ago. (I'm glad I found this issue!) I added "gurobi81" to aliases = ["gurobi81","gurobi80","gurobi75","gurobi70","gurobi65","gurobi60","gurobi56","gurobi55"], and it started working. Maybe this could be fixed in some permanent way?

See https://github.com/JuliaOpt/Gurobi.jl/issues/163


Classpath scan time lapse for every included changelog file

Environment
Liquibase Version: 4.3.5
Liquibase Integration & Version: Maven 3.2.5
Liquibase Extension(s) & Version: N/A
Database Vendor & Version: PostgreSql 10.8.1
Operating System Type & Version: Windows 7
Description
Hello,
While ugrading an app from SpringBoot 2.4.6 to 2.5.1, Liquibase dependency was updated from 3.10.3 to 4.3.5, the database management startup time increased from 4 seconds to 33 seconds.
For my changlog, I use an inclusion for each applicative version (32 times).
<include file="major/minor/version-number.xml" relativeToChangelogFile="true" />
With a profiling (see joined capture), it appears that with Liquibase 4.3.5, the classpath is scanned for each of the 32 resource files, which leads to an increase of the whole process duration. This behaviour did not occur in previous versions (Liquibase 3.10.3).
Regards,
Before upgrade Liquibase 3.10.3 (SpringBoot 2.4)

15/06/2021 10:51:21.234 INFO  [main] xx - Starting xx
15/06/2021 10:51:21.294 INFO  [main] xx - No active profile set, falling back to default profiles: default
15/06/2021 10:51:21.894 INFO  [main] hikari.HikariDataSource - HikariPool-1 - Starting...
15/06/2021 10:51:22.034 INFO  [main] hikari.HikariDataSource - HikariPool-1 - Start completed.
15/06/2021 10:51:24.328 INFO  [main] lockservice.StandardLockService - Successfully acquired change log lock
15/06/2021 10:51:24.931 INFO  [main] changelog.StandardChangeLogHistoryService - Reading from xxx
15/06/2021 10:51:24.971 INFO  [main] lockservice.StandardLockService - Successfully released change log lock
15/06/2021 10:51:25.131 INFO  [main] xx - Started xx in 4.534 seconds (JVM running for 5.289)
15/06/2021 10:51:25.141 INFO  [SpringContextShutdownHook] hikari.HikariDataSource - HikariPool-1 - Shutdown initiated...
15/06/2021 10:51:25.161 INFO  [SpringContextShutdownHook] hikari.HikariDataSource - HikariPool-1 - Shutdown completed.

After upgrade Liquibase 4.3.5 (SpringBoot 2.5)

15/06/2021 10:37:18.615 INFO  [main] xx - Starting xx
15/06/2021 10:37:18.695 INFO  [main] xx - No active profile set, falling back to default profiles: default
15/06/2021 10:37:19.316 INFO  [main] hikari.HikariDataSource - HikariPool-1 - Starting...
15/06/2021 10:37:19.487 INFO  [main] hikari.HikariDataSource - HikariPool-1 - Start completed.
15/06/2021 10:37:19.979 INFO  [main] liquibase.lockservice - Successfully acquired change log lock
15/06/2021 10:37:51.364 INFO  [main] liquibase.changelog - Reading from xxx
15/06/2021 10:37:51.455 INFO  [main] liquibase.lockservice - Successfully released change log lock
15/06/2021 10:37:51.455 INFO  [main] liquibase.lockservice - Successfully acquired change log lock
Skipping auto-registration
15/06/2021 10:37:51.455 WARN  [main] liquibase.hub - Skipping auto-registration
15/06/2021 10:37:51.465 INFO  [main] liquibase.lockservice - Successfully released change log lock
15/06/2021 10:37:51.637 INFO  [main] xx - Started xx in 33.61 seconds (JVM running for 34.551)
15/06/2021 10:37:51.647 INFO  [SpringApplicationShutdownHook] hikari.HikariDataSource - HikariPool-1 - Shutdown initiated...
15/06/2021 10:37:51.657 INFO  [SpringApplicationShutdownHook] hikari.HikariDataSource - HikariPool-1 - Shutdown completed.

The following profiling capture shows execution times for the ClassLoaderResourceAccessor.loadRootPaths method.

Hi @purpleloop Thanks for writing up this issue.  We will add it to the list of issues that we are processing.

This should be handled by the in-progress #1860 PR.
Are you able to try the build from that PR and see if it improves performance for you?

Hello,
Thanks for your returns.
After various tests, the performances seem relative to the operating system.
I will try for the PR.

I tested the #1860 PR on the 4.3.x branch to have only this change with regard to the version I use.
This really improved the changeset loading times 👍 😃
For instance, I made a test with 100 includes of a changeset that inserts a row in a table :

Before applying the fix : 52.971 seconds
After applying the fix : 2.539 seconds

Great, this solves my problem, thanks !

Thanks for the update. I'm going to keep this ticket open until we get the PR merged down so it doesn't get lost.


Code completion and navigation not working in kotlin plugin

Can't resolve reference in kotlin script.

IDEA version: 2022.2.1

It does work after I clear the index


Can't delete via keyboard recently added text

Bug Description
Texts are not allowing delete once you add them on the canvas, only after removing its focus and focusing again.
Expected Behaviour
Any element should allow being deleted when it is focused.
Steps to Reproduce

Add a Text in the Workspace
Press delete key on the keyboard

Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance Criteria
QA Instructions

Duplicated of #738.


Log error when download failed

Signed-off-by: shiyu22<EMAIL_ADDRESS>

Codecov Report

Merging #1414 (f0493f6) into main (15e0068) will decrease coverage by 0.41%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1414      +/-   ##
==========================================
- Coverage   68.78%   68.36%   -0.42%
==========================================
  Files         295      296       +1
  Lines       16228    16268      +40
  Branches     2633     2647      +14
==========================================
- Hits        11162    11122      -40
- Misses       4320     4406      +86
+ Partials      746      740       -6

Impacted Files
Coverage Δ

towhee/hub/repo_manager.py
24.16% <0.00%> (-0.62%)
:arrow_down:

towhee/models/clip/clip_utils.py
32.52% <0.00%> (-39.84%)
:arrow_down:

towhee/models/clip/clip.py
85.43% <0.00%> (-3.32%)
:arrow_down:

towhee/dataframe/dataframe.py
73.10% <0.00%> (-1.05%)
:arrow_down:

towhee/models/drl/drl.py
18.07% <0.00%> (-0.62%)
:arrow_down:

towhee/models/drl/__init__.py
100.00% <0.00%> (ø)

towhee/functional/storages.py
82.14% <0.00%> (+2.38%)
:arrow_up:

towhee/functional/mixins/column.py
75.00% <0.00%> (+9.00%)
:arrow_up:

towhee/engine/execution/vectorized_execution.py
85.71% <0.00%> (+35.71%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15e0068...f0493f6. Read the comment docs.

/lgtm
/approve


C# Application, slow rendering

I'm using the library to develop a C# desktop application. For the moment I just load a pdf document in the viewer on the application start up, but it seems to me it is very slow, both on the initial load and on the form resize. Is it normal or am I doing something wrong? I can post code if needed.
Thank you very much for your project

Can you try the demo application that's part of the project and see if that's slow too for you? The demo application shows how you should use the PdfiumViewer project, so maybe there's a difference to how you're using it, and how the demo application uses the component you can use to help pin down the issue.

I have tested the demo Application with a pdf of size 11MB with only two pages. It takes a lot of time to render the PDF. Also there is a considerable lag every time the pdf viewer is scrolled to a different region.
I think some kind of caching should be done. I have used a different clone of google PDFium project. Its performance is very good. Wish you all good luck for the performance improvement of this PDFViewer.

Could you please make the PDF available? That'll make it a lot easier to diagnose this issue.


[HOLD for payment 2024-04-25] Web - Endless loading on Private section when login via Abracadabra

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.42-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers<EMAIL_ADDRESS>Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:

Navigate to staging.new.expensify.com
Enter gmail account with lot of conversations> Click Continue
Navigate to e-mail> copy the login link, change to staging and Enter in new tab
Navigate to original Tab and while app still loading navigate to Settings icon
Take a note of the Private section

Expected Result:
Private section should load immediately or there should be short time delay
Actual Result:
There is a endless loading on Private section
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/ba1ef566-5888-464f-9b5b-ddb4737ae44b
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~012818d61c231e3c33
Upwork Job ID:<PHONE_NUMBER>844518400
Last Price Increase: 2024-02-15

Production:
https://github.com/Expensify/App/assets/78819774/d74849f6-44e7-4421-8f33-d1c46be4646f

Yeah, weird - looks like private_personalDetails is getting set to [] on staging. I can't reproduce on dev, and I don't see any logic. The details are being returned correctly in OpenPersonalDetailsPage though.
FWIW this bug also occurs if you manually paste the magic code, so it's not specific to the Abracadabra flow.

@grgia could this be tied to https://github.com/Expensify/Web-Expensify/pull/40867 by any chance?

@NikkiWines it looks like personalDetails arent loading here, not privatePersonalDetails

@grgia the personal details seem to be ok from my testing - it looks like only the private ones are getting overwritten and in the response to the OpenApp call we can see the following:

Even though the private_personalDetails are correctly being returned earlier in OpenPersonalDetailsPage

It also explains why this bug only occurs if you immediately navigate to the settings page (prompting the OpenPersonalDetailsPage, since the OpenApp call takes a lot longer and can finish after OpenPersonalDetailsPage completes.

ah gotcha, so we need to remove the private personal details from being overwritten in OpenPersonalDetailsPage

Yeah, I think ideally OpenApp would return the default empty values (here) for private_personalDetails instead of [] here.

Oh also not a newDot blocker since this is due to backend changes 👍

Proposal
Please re-state the problem that we are trying to solve in this issue.
Endless loading on personal private section when logging
What is the root cause of that problem?
.

When user click fast enough after login via Abracadabra, the OpenPersonalDetailsPage was called before OpenApp.
OpenPersonalDetailsPage return appropriate private_personalDetails data.
OpenApp return [] for private_personalDetails data (and override the appropriate one).
Personal private section keep loading because below line fallback to true.

https://github.com/Expensify/App/blob/a6fe014150f0de5ddf86787b05fd3417447c73f5/src/pages/settings/Profile/ProfilePage.js#L106
What changes do you think we should make in order to solve the problem?
Currently, user can navigate to setting page even when the user's avatar icon is show loading.
=> We need to prevent navigate action when loading to ensure OpenPersonalDetailsPage can only be called after OpenApp
The condition should be apply in line 44:
https://github.com/Expensify/App/blob/a6fe014150f0de5ddf86787b05fd3417447c73f5/src/pages/home/sidebar/PressableAvatarWithIndicator.js#L43-L50
It should be
const shouldShowLoading = isLoading && !currentUserPersonalDetails.avatar;
const showSettingsPage = useCallback(() => {
  if (isCreateMenuOpen || shouldShowLoading) {
    return;
  }

What alternative solutions did you explore? (Optional)
Above solution correct behavior of loading element. Anyway, we can change OpenApp in the BE too. Both fix the issue

I can take this @NikkiWines

also the auth changes weren't merged yet oops https://github.com/Expensify/Auth/pull/9913

@damadoko Thank you for your interest here. Looks this will be fixed internally.

Re-assigning to @grgia per this comment

Only payment needed here is $500 to @s77rt for C+ via Upwork (this issue was created before default price lowered to $250).

OG upwork job is closed. new one is here: https://www.upwork.com/jobs/~01058cf92b6ef09600

@s77rt offer for $500 sent!

@joekaufmanexpensify Accepted! Thanks!

@s77rt $500 sent and contract ended!

Upwork job closed.


Strange behaviour running tests with karma --auto-watch

Note: for support questions, please use one of these channels: Chat: AngularClass.slack or Twitter: @AngularClass

I'm submitting a ...
[x] bug report
[ ] feature request
[ ] question about the decisions made in the repository

Do you want to request a feature or report a bug?
Report a possible bug.

What is the current behavior?
Running tests with karma auto-watch active (npm run watch:test) does not always trigger the correct results, as it seems something is not fetching the correct last version of the code.

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem

Steps:

clone the project
npm install
npm run watch:test

the test are sucessfull

change src/app.component.ts line 58 url = 'https://twitter.com/AngularClass'; to url = 'https://twitter.com/AngularClassXXXX'
the tests are not sucessfull, which is correct
undo the change made on src/app.component.ts line 58
the tests are not sucessfull, which is incorrect

So the first change in code after karma starts is always triggered, then the strange behaviour happens (cant find a pattern)

subsequent changes are not trigger
sometimes after a change in code, to trigger the correct behaviour I need to change a second file

Seems something about karma-webpack-webpack-middleware is caching the old code or not syncing correctly.

What is the expected behavior?
Every last change in code reflected in the environment tests that are running with karma watch

Please tell us about your environment:

I used the last version of the repo (as today)
Browser: [ PhantomJS 2..0.1 | Chrome 51.0.2704.63 ]

Exact same problem: https://github.com/AngularClass/angular2-webpack-starter/issues/718
I thought the problem was due to removing fileGlob but it turns out that it's not.

As for me, the problem is recent.

It seems to be a well known issue: https://github.com/karma-runner/karma/issues/1087 https://github.com/webpack/karma-webpack/issues/9

I'v found some projects where there this bug does not exists: angular2-starter or angular2-webpack
But still could not find the differences that may be the cause the problem. Maybe some kind of buggy configuration around karma/webpack.

@abdulhaq-e Before I submit this issue I tried the solution around fileGlob but with no success.

Btw, are you using Atom?

I tried with Atom, WebStorm and vi.
Always the same problem.

I have just tested Karma 1.0.0, same issue.

Have you resolved this issue? I am experiencing the same issue with typescript validation errors. If i restart task, errors are gone.

With the actual version on master i'm not seeing this problem anymore.

Been having this issue since august.
Touching (saving or other) files other than the actual specs triggers a rerun but specs are not updated.


Install more krakentools tools at ORG to support tutorials and synch up servers

Please install
priority

[ ] toolshed.g2.bx.psu.edu/repos/iuc/krakentools_extract_kraken_reads/krakentools_extract_kraken_reads/1.2+galaxy1

others

[ ] toolshed.g2.bx.psu.edu/repos/iuc/krakentools_kreport2mpa/krakentools_kreport2mpa/1.2+galaxy1
[ ] toolshed.g2.bx.psu.edu/repos/iuc/krakentools_beta_diversity/krakentools_beta_diversity/1.2+galaxy1
[ ] toolshed.g2.bx.psu.edu/repos/iuc/krakentools_alpha_diversity/krakentools_alpha_diversity/1.2+galaxy1
[ ] toolshed.g2.bx.psu.edu/repos/iuc/krakentools_combine_kreports/krakentools_combine_kreports/1.2+galaxy1

Listing at ORG

Listing at EU

Listing at AU

Reported by Frederick Tan
XRef https://training.galaxyproject.org/training-material/topics/microbiome/tutorials/pathogen-detection-from-nanopore-foodborne-data/workflows/. More tools are missing to fully support these but the tools above are a start.

I've added them here: https://github.com/galaxyproject/usegalaxy-tools/pull/780
The procedure is really straightforward, anyone can learn this. It is probably less work than opening this issue if you get familiar with the process.

Open the file for the section you want to add, e.g https://github.com/galaxyproject/usegalaxy-tools/blob/master/usegalaxy.org/metagenomic_analysis.yml
Add the repositories as I did in the PR. If you have the tool id, the owner comes after /repos/ in the id, and that's followed by the name.
run make-fix
commit and create PR


Error creating datalink

Receiving error on AWS as well as other clouds
Error message:
"Error creating datalink channel: No such device (os error 19)".

Was linked to a Crate issue. upgraded to latest pnet.


[HUDI-5780] Refactor Deltastreamer source configs to use HoodieConfig/ConfigProperty

Change Logs
Relevant classes:
HiveIncrPullSource
HoodieIncrSource
JdbcSource
PulsarSource
S3EventsHoodieIncrSource
SqlSource
CloudObjectsSelector
CloudStoreIngestionConfig
DatePartitionPathSelector
DFSPathSelector
KafkaOffsetGen
GcsIngestionConfig
MaxwellJsonKafkaSourcePostProcessor
org.apache.hudi.utilities.testutils.sources.config.SourceConfigs
Impact
NA
Risk level (write none, low medium or high below)
low
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change

The config description must be updated if new configs are added or the default value of the configs are changed
Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the instruction to make
changes to the website.

Contributor's checklist

[ ] Read through contributor's guide
[ ] Change Logs and Impact were stated clearly
[ ] Adequate tests were added if applicable
[ ] CI passed

Need to address https://github.com/apache/hudi/pull/8152#discussion_r1142860859


Update to 1.2.7

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@davidh-ssec this feedstock needs to be re-rendered with conda-smithy. Do you know how to do that? If not I can take care of that later.

@ocefpaf Done. Is there a way to know I should rerender a feedstock or should I just update conda-smithy every time and see if anything changes? Are there times that I wouldn't want to rerender?

@ocefpaf Done. Is there a way to know I should rerender a feedstock

Only if you are following the developments of conda-forge closely. Which is not recommended due to the high noise level :smile:

or should I just update conda-smithy every time and see if anything changes?

You can rerender when the CIs fail when you know the problem is not the recipe.

Are there times that I wouldn't want to rerender?

Nope. It is pretty safe to rerender constantly. However, in theory the bot should be ahead of the manual updates so you should not rerender at all. But the feedstock boilerplate, updates, and fixes are more frequent than what the bot can handle lately.


http-check frequency < 1

I tried to find the code line for the specific part but wasn't successful. Is there any possiblity to have a http-check frequency below 1 minute? Something like 0.5 would be nice. But the form won't allow it.
I would change the code on my own and make a pr if needed but I can't find any point to start at.

The issue here is that the frequency is stored as an integer representing the number of minutes between checks, see https://github.com/arachnys/cabot/blob/master/cabot/cabotapp/models/base.py#L428
I'd suggest starting from there, you'd probably want to change this to represent seconds instead of minutes or using https://docs.djangoproject.com/en/1.11/ref/models/fields/#django.db.models.DurationField instead.

The relevant code for the scheduling should work just fine with minutes=0.5:
https://github.com/arachnys/cabot/blob/4e4ca0a8b6d08b40007e84a9e61160873000f6f5/cabot/cabotapp/tasks.py#L31
The form won’t allow 0.5 though because it is defined as an IntegerField
https://github.com/arachnys/cabot/blob/4e4ca0a8b6d08b40007e84a9e61160873000f6f5/cabot/cabotapp/models/base.py#L428-L431
I assume that changing that to eg a DecimalField would require a database migration?
(In general, I’m not sure this would actually have the desired effect − the way tasks are scheduled (using Celery), I’m not sure it can be guaranteed to run that often reliably.)

At the moment it's set up as an IntegerField - see https://github.com/arachnys/cabot/blob/ae97ba7a5258d1d38515dd41230769923149cafe/cabot/cabotapp/models/base.py#L428. Migrating it is definitely possible but requires testing that we are unlikely to have time to prioritize, so you may need to fork.

Thank you for your input. Will try to get this problem solved and provide pr - or will fail hardly

hey hummel, did you try changing the frequency?
I am also looking for this solution, I wanted it to be in seconds.

@vijaytejak sorry. Yes I did solve the problem but we moved away from cabot due to no maintenance anymore. I don't have anything to provide left. sry


Feature/gh 24

Close #24

Bundle Report
Changes will increase total bundle size by 476 bytes (0.04%) :arrow_up:. This is within the configured threshold :white_check_mark:
Detailed changes

Bundle name
Size
Change

jarm-online-esm
1.26MB
476 bytes (0.04%) :arrow_up:


Fix wrong duration and wav errors

Fix #103
Fix #145

Shouldn't we make all new APIs promise-returning?

About promises: we're not forced to put promises everywhere, it's fine for now.

I don't think it is about solving callback hell, it is about consistency

Can you checkout the branch and make the needed changes ?

Sure.

You know, I tried making it Promise-based, but it does not look as nice as I thought it would.
How about landing this as is and creating an issue to rework all library-related functions to be Promise-based?
Branch is here if you still want to look at it.

Let it go, let it gooooo


Ability to set unique token name from Figma style name

Problem
When declaring tokens that also have associated Figma styles (color, text, effects) the hierarchy of the token name determines the naming structure of the Figma style. This is very problematic. The way we structure Figma styles will probably be different than the underlying token taxonomy. This also limits the flexibility to re-structure Figma styles since they will impact the token names introducing 'breaking changes' per-se.
Name: pds.tkn.color.purple.400
Figma style: pds / tkn / color / purple / 400
Solution Idea

Make the token name independent from the Figma style name and allow them both to be unique.
Still allow the token -> Figma styles to stay in sync in ways that support the unique token name from Figma style name (probably the really hard part!)
Add the ability to read, update, and set the Figma style name from the Edit Token modal on applicable token types.

The above would allow independent control of the token name and Figma style names. Thus giving power and control to create names for each platform that make sense vs sticking to a rigid structure that can't be changed.
Example 1
Lets say I want to have a core Tier of colors, and a semantic tier of colors, but don't want to include certain parts of the token name in the Figma style name and vice-versa. I also want my Figma color styles to have different names which make more sense for designers and how Figma works to keep the hierarchy simpler.
Core Color Token
Name: pds.tkn.color.purple.400
Figma style: PDS Palette / Purple / 400
Semantic Color Token
Name: pds.tkn.color.primary.key
Figma style: PDS Primary / Key
References: pds.tkn.color.purple.400
Example 2
Lets say I have some component-specific token groups for colors, but I don't want to put component in the token name. However, it would make sense to keep it in the Figma style name to separate these from other color styles.
Name: pds.tkn.button.surface.color.default
Figma style: PDS Components / PDS Button / Surface Default
Thanks for considering! I feel this would be a nice enhancement to the plugin...

Was about to post for the exact same issue
Glad to see it's not just on our side :)
Did you find a solution for this ?

@six7 proposing we close this one as its stale and can we reintroduced in Featurebase if the request is till relevant


Add hand interaction state (touch, grab) to Interactable's states

Overview
Current Interactable has four states available for HoloLens v1 and WMR controllers: Default, Focus, Pressed, Disabled. By adding additional states for the hand interactions, developers and creators can define visual/audio feedback without writing additional script. Touch and Grab event could be useful.
https://microsoft.github.io/MixedRealityToolkit-Unity/Documentation/README_Interactable.html
Expected Behavior
Developers can define visual/audio feedback for Touch and Grab state in the theme of Interactable without writing code.
Actual Behavior
Currently, there is no way to define visual/audio feedback in the Interactable. Developers have to write additional code with hand interaction related interfaces.

Adding the states to show up in the themes is easy, but wiring up the input to drive those states will require code. I'm working on some updates for press right now.

@killerantz I guess two additional states 'Touch' and 'Grab' could be added for hand interactions. For hand interaction press, I think we can use existing 'Press' state - However, I am not clear how we can drive hand press which is currently in PressableButton script.

There's a PhysicalTouch state that was added recently, it's in there and will listen for touch events I'll try to make it less reliant on other components. The grab will be something new. I saw in another script, I think the Manipulation Handler, that looks for grab and checks for the literal string of the action description. That seems breakable if the actions are changed. Is there guidance for action label/descriptions to enable grab functionality?

@cre8ivepark I think it would be good to clarify the meaning of grabbed and touched. Touched is easy: a near pointer is physically touching the Interactable's collider. Grabbed is less clear. An intercatable will already be in the Pressed state if a near pointer grasps the object. So why couldn't a designer just use the Pressed state? Is it really that you want to distinguish "near pressed" from "far pressed"?

Fixed by #4357


Add Math.Lerp

[x] Add Math.Lerp & tests
[x] Add shader translation

Usage:
  (Float3 0.0 1.0 2.0) >= .first-3
  (Float3 4.0 -1.0 0.0) >= .second-3
  0.5 (Math.Lerp .first-3 .second-3) (Log "Lerped value")

  (Color 0x10 0x20 0x40 0xff) >= .first-c
  (Color 0x25 0xff 0x20 0xff) >= .second-c
  0.5 (Math.Lerp .first-c .second-c) (Log "Lerped color")

What would that do? @Kryptos-FR


Tameable should extend Sittable

The vanilla MInecraft server does not have a discrete EntitySittable class. Instead, the AI for sitting is included in EntityTameable within the aiSit object. Therefore, because all tameable entities are also capable of sitting, it would make sense from an implementation standpoint for Tameable to extend Sittable, rather than vice versa as it currently stands.

Sorry, but not all tamable entities are able to sit, Horses come to mind as an easy example. I wrote the interfaces knowing full well the structure of entities in the vanilla Minecraft code base and chose to avoid blindly following the precise structure (which included Tamable and Sittable).


Project template update

Updated to project-template v9.0.2.

Codecov Report

Merging #532 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #532   +/-   ##
=========================================
  Coverage     28.13%   28.13%
  Complexity      954      954
=========================================
  Files            85       85
  Lines          3252     3252
=========================================
  Hits            915      915
  Misses         2337     2337

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 761c46c...ff22c36. Read the comment docs.


investigate fixed-size set containing pointers

The set we use when the user asks for a fixed capacity is currently an array of state values. It would be possible to instead use an array of state pointers. We can still preserve the capacity limits because we know the size of the state when allocating, so we can account for this in the allocation.
This will less effectively use memory (overhead of pointer storage) but would allow us to (a) use a more granular concurrency model with atomics instead of a global lock and (b) avoid the awkward calling convention where we currently modify the caller's pointer when inserting.

This is basically exactly the approach taken in 5637524b6beba60829ad8b45aea0d52e170ee6c8 in the branch "c-checker2".

This was done a while back when "c-checker2" was merged.


Please rebuild with recent ca-certificates

On 1st of October I noticed that external auth stopped working. Our external auth is a simple Go program that connects to a server via https that has a let's encrypt certificate. Might be related to this? https://community.letsencrypt.org/t/transition-to-isrgs-root-delayed-until-jan-11-2021/125516 . But anyways, replacing the ca-certificates.crt with one from recent Alpine fixed it. Would be great if you could rebuild the image.

Thanks for ping, I've sent a rebuild of the docker container.
Which image are you using? I may need to re-tag if you aren't using the :edge tag.

I've just tagged a new version which hopefully fixes things. I will close this now. Please re-open if you still experience issues :)

Which image are you using?

The :1 which looks like it was pushed. So thanks for fixing.


"Save" button margins on Create Event page

The margins of the "Save" button seems wrong on the Create Event page. Fix the margins so that it looks more natural. As of now, it has no space between the button and the bottom of the page.

 "Save" button margins on the Create Event page


How does "safeToRun" works?

 It works without any error and I didn't notice any change.
By reading source code, I think it's purpose to avoid using reactive data in .subscriptions.

An error gets thrown when the when it changed reactively.
 It works without any
error and I didn't notice any change.
By reading source code, I think it's purpose to avoid using reactive data
in .subscriptions.
—
Reply to this email directly or view it on GitHub
https://github.com/meteorhacks/flow-router/issues/27.

oh I see.
I'm curios about what is the reason behind this decision :D?

We don't allow any kind of reactive stuff run inside the router. If so, you
are doing something wrong.
There'll be another way to do it for sure.
This is made to avoid re-renders.
On Sat, Mar 7, 2015 at 4:36 PM Delgermurun Purevkhuu <
<EMAIL_ADDRESS>wrote:

oh I see.
I'm curios about what is the reason behind this decision :D?
—
Reply to this email directly or view it on GitHub
https://github.com/meteorhacks/flow-router/issues/27#issuecomment-77684472
.

Yeah that makes a lot of sense to me. Now I really understand the this router's purpose.
I definitely need to really deeply understand tracker.
Thanks a lot.

No problem.
On 2015 මාර්තු 7, සෙන at ප.ව. 4.49 Delgermurun Purevkhuu <
<EMAIL_ADDRESS>wrote:

Yeah that makes a lot of sense to me. Now I really understand the this
router's purpose.
I definitely need to really deeply understand tracker.
Thanks a lot.
—
Reply to this email directly or view it on GitHub
https://github.com/meteorhacks/flow-router/issues/27#issuecomment-77685063
.


Removes outdated known_failure annotations

Removing the known_failure annotations for multi_collection_test and multi_list_set_test as the problem behind those tests seems to have been fixed.

+1


.humanize for near-zero duration says "just now"

This is very confusing for a field that is meant to be duration.
Consider, I may have a very short duration event that occurred weeks ago.
Arrow will say this event was "just now".
A more accurate description would be "instantly".

My understanding of "humanize()" is that it isn't offering a duration, but rather a human-language version of a "time delta" between two points in time, so we have: "a few minutes ago", "a week ago", "a year ago", etc.

It does both depending on the arguments.
On Tue, May 9, 2017, 07:43 Brendan McCollam<EMAIL_ADDRESS>wrote:

My understanding of "humanize()" is that it isn't offering a duration, but
rather a human-language version of a "time delta" between two points in
time, so we have: "a few minutes ago", "a week ago", "a year ago", etc.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/crsmithdev/arrow/issues/416#issuecomment-300186043,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAnFSMa2Ksufw70ddJUL4emYk64TvWe_ks5r4HqygaJpZM4L0oJt
.

ya, the only_distance param.
here's a repro:
In [1]: import arrow

In [2]: now = arrow.now()

# we're going to compare everything against `t`, which is the relative time in the past we want to compare against

In [3]: t = arrow.now() - timedelta(days=100)

# when the result is minutes ago, the `only_distance` parameter strips off the relativity
# information from the time
In [6]: t1 = t - timedelta(minutes=3)

In [8]: t1.humanize(other=t)
Out[8]: u'3 minutes ago'

In [7]: t1.humanize(other=t, only_distance=True)
Out[7]: u'3 minutes'

THIS is what @bukzor is talking about. when the result is only 1 second, the same relative-to-now time string is returned, regardless of the only_distance param
In [9]: t2 = t - timedelta(seconds=1)

In [11]: t2.humanize(other=t)
Out[11]: u'just now'

In [12]: t2.humanize(other=t, only_distance=True)
Out[12]: u'just now'

I have the exact same use case and I'm running into the same issue.. Thanks for the PR @bukzor , let's hope it gets merged eventually (though it's been quite a while since you sent it)


.text does not return all content

Describe the bug
When trying to get text from a  tag, gazpacho returns empty string
To Reproduce
Code to reproduce the behaviour:
from gazpacho import Soup

html  = 'by Sorasful'

soup = Soup(html)

print(soup.text)
# prints nothing

print(soup.find('a').text)
# prints "by"

Expected behavior
Should return "by Sorasful"
Environment:

OS: Windows 10
Version: Python3.8

Actually, this is correct behaviour. If you want "by Sorasful" try .strip:
soup.find("a").strip()

Concerning your first point:
print(soup.text)
# prints nothing

This is being worked on in #28 but could use some help!

Why does
soup.find("a").text.strip()

Returns only "by" ? It should return the content of a tag I believe

Hmm. You're actually right 😬
The first issue has been fixed in #29.
But, I think:
print(soup.find('a').text)

Should return just Sorasful and not by or by Sorasful

Should return just Sorasful and not by or by Sorasful
Can you please explain why?

I think he meant this because actually the a tag just contains Sorasful text, even though there is a span in it.


Updated some files to the lastest dotnet standards

Updated Program.cs to the latest standard implementation
Renamed getConnectionString to GetConnectionString to match naming conventions
Used include and exclude in environment TagHelper to make it easier to add a new environment without breaking styles and script includes

Since no one is


Create chargelogic:xslt

Function to take as input an xml file and an xsl stylesheet, apply the stylesheet to the xml file, and output a transformed document.

@jcooper01,
Thanks for having already signed the Contribution License Agreement. Your agreement has not been validated yet. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

Thanks for your submission  -we are considering your request and have added a work-item for it.

I believe we have addressed this request through #15, where we added the TryTransformXMLToOutStream function. This functionality will be made available through the November update! Thank you very much for your contribution!


Fix linker errors

Since the code was refactored to use Boost.Asio, the tests need to link to Boost.Asio.

We still haven't corrected the Travis CI builds, and this explains the failure. However, your fix is trivial so I can merge it anyway.


Added Tera Campus

Official website: https://www.tera-campus.com/
This is a French school of advanced engineering in IT offering long-term studies only (3 years minimum for a bachelor degree).
The domain name can be seen on all email addresses of the university, for example in the contact tab of the website: https://tera-campus.com/contact
Our contact email address is<EMAIL_ADDRESS>Thank you :)

@baiello First stage of verification passed, official domain is tera-campus.com as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

No problem, thanks for the note

@baiello Thank you for your patience while waiting for a review and processing your request. Pull request merged.


Clicking "all" for weapon category does nothing

Think this has something to do with moving the routing/query stuff to the weapons component from the navbar component. The queries still work fine however.

Fixed in: 03bc63084e462d8b0e95b018f80c47d38641b2e8


Support concurrent DuckDB queries

In DuckDB, each connection can only process one query at a time. The runtime currently opens one DuckDB connection and runs all queries sequentially on that connection. We want to add a connection pool to the DuckDB driver to enable running concurrent DuckDB queries. We should experiment with the number of concurrent connections, but something like 4 might be a good number.
DuckDB only allows one process to open a DuckDB file (for writing) at a time. But within that process, you can open multiple connections. Even though DuckDB also parallelizes the processing of each individual query, it often can't leverage all available resources all the time, so in testing we've seen performance improvements in running multiple queries on multiple connections in parallel.
We can't just naively use Go's builtin connection pool in database/sql for two reasons:

DuckDB loads extensions on a connection-level, not a DB-level. So we need to run some custom init (loading the extensions) for each new connection before it's used.
The analytical APIs use DuckDB's temporary tables, which are connection-specific. All queries related to a temporary table must run against the same connection.

PR: https://github.com/rilldata/rill-developer/pull/1405
Tasks:

[x] Parse config option rill_pool_size from DuckDB DSN
[x] Support concurrent prioritized queries by using a prioritized semaphore instead of priorityworker
[x] Adapt the drivers.OLAPStore interface to enable sequentially running multiple queries against a single connection in the pool (e.g. by adding a callback or a transaction interface)
[x] Add a custom connection pool in the DuckDB driver that lets us load extensions before the connection is first used
[x] Fix consistency bug described in comment below (PR: https://github.com/marcboeker/go-duckdb/pull/61)
[x] Simplify connection pool logic by implementing https://github.com/marcboeker/go-duckdb/issues/62
[ ] Adapt OLAP tests (duckdb/olap_test.go) to reflect new mechanics of priority semaphore and to test with rill_pool_size > 1 (testing doesn't have to check performance/concurrency, just check that everything works)
[x] Consider reserving one DB connection when cfg.PoolSize > 1 for lightweight queries like catalog queries and dry-run queries (prepared statements)
[x] Refactor analytical APIs that uses temporary tables to use the new single-connection interface in drivers.OLAPStore

We are experiencing a bug with this PR when running an initial reconciliation against an empty DB with rill_pool_size > 1. This feels like a consistency bug where changes made in one DuckDB connection are not immediately reflected in other DuckDB connections.
Here's one hypothesis:

The DuckDB C API docs suggest using multiple connections, so it feels like this should be supported
In the go-duckdb driver, the Open function creates a new DB handle (using duckdb_open) and new connection handle (using duckdb_connect) each time. Maybe the use of multiple DB handles is the problem here. That should be easy to test in a temporary test case in the go-duckdb driver.
If that's the case, we should submit a patch to go-duckdb to re-use the same DB handle each time it opens a new connection. Fortunately, the database/sql interface (which the driver implements) already provides an optional mechanism to achieve this. See Driver and DriverContext and Connector in the database/sql/driver package.

The maintainer of go-duckdb is quite active, so we should be able to get a fix in quite fast – and until then, if relevant, we can use a replace directive in go.mod to use our patch.
If we fail on 2. above, we should reach out in the DuckDB Discord to ask about consistency across multiple connections.

I'm now also realizing that we could avoid having our own custom connection pool if we used the DriverContext and Connector options (linked above) in the go-duckdb driver to load extensions. We could submit a PR to go-duckdb that lets you pass a load_extensions=json,parquet,... option in the DuckDB DSN, which the driver could parse to automatically load extensions on each new connection. If the submit the patch outlined above to go-duckdb, then this would be easy to add.

@begelundmuller so what's a reasonable number of concurrent connections to expect duckdb to handle at once now (in readonly mode)?

I'm running into a similar issue where I want to use a connection pool but also have temp tables (which I think are scoped per connection). Did you find a solution to this problem?

Hey @domoritz we still tie statements that use temp table to same connection using utility function, see here.


Nicer transitions between examples

We need some nicer transitions while switching between examples.

PR: https://github.com/src-d/landing/pull/84


avoid calling kubeclient methods on non kube clusters

On implementations of our cluster.Cluster interface in the test framework, such as staticvm, we embed a nil pointer for kube.ExtendedClient that we shouldn't interact with.
Ideally we'd make this transparent via a mock but that comes with it's own problems:

How do callers handle empty responses, or "this is a mock" error
Codegen may be required to generate such a mock/keep it up to date.

This protects a few places from using the nil client, but our concept that a tf cluster is a place where workloads live is a bit confusing and will probably continue to be violated.

@stevenctl: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-test_istio
480e104ea52746e394f3f4e7dc0f4525024997cf
link
/test release-test_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-test_istio
480e104ea52746e394f3f4e7dc0f4525024997cf
link
/test release-test_istio

integ-pilot-multicluster-tests_istio
480e104ea52746e394f3f4e7dc0f4525024997cf
link
/test integ-pilot-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest


New queries with JSON syntax

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your<EMAIL_ADDRESS>seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Could we use json_extract_path_text() for JSON queries as described in https://github.com/folio-org/ldp/blob/master/README.md?

Oh, sure. Sorry, I modeled off the example in Slack, but I'll change it.

I think at this point we can use simple names like circ-detail.sql and delete all of the other versions.  They will still exist in the repository history.  I believe we have decided not to use stored procedures/functions but to create a model query exactly as you have done, with placeholders in the query that need to be changed (as long as that is clearly documented).

Something to think about might be 4-space indentation.  The closer we can get to fitting within 80 characters, the more we can potentially do things like viewing two queries side-by-side on a medium sized monitor, which can be useful for development.
Also, would it be easier to figure out a testing approach for queries now, or come back to it later?

Have updated code with json_extract_path_text and more consistent style! Happy to talk testing anytime.


Internal: KeyError: 'bark'

Running bark with transformers.
Using transformers 4.31.0.
Getting Internal: KeyError: 'bark'. I am using the example code.
Even when I use BarkModel it says it can't import it. Anything special I need to do?

Hey,
I've got no problems running the code example on transformers 4.31.0 on a colab notebook. Could you share more info about your error and setup ?
Thanks!

same here

same with me


Dev Mode on VS2017 does not work

The Dev Mode document says "Dev Mode does not currently work with Dev15 Preview 5", does the same applies to VS2017 stable? EnableDevMode does not show script files when attaching to VS2017 process so I cannot debug. It seems CustemTypeScriptServicesFileLocation also does not work.
I used Computer\HKEY_CURRENT_USER\Software\Microsoft\VisualStudio\15.0\TypeScriptLanguageService directory.

The language service no longer runs either inside Visual Studio, or inside the chakra engine, so the old method of script debugging no longer works.
You can still set a custom tsserver.js location to use. See https://github.com/Microsoft/TypeScript/issues/14529#issuecomment-287517438 .


Body of if let is detected as not covered (false positive).

tl;dr
Though actually there is a unit test for it, the body of if let is detected as not covered:

Code
The only source code I have is this src/main.rs:
use std::fmt::Debug;
use std::hash::Hash;
use std::{collections::HashMap, rc::Rc};

struct BidirectionalMap<K, V> {
    left_to_right: HashMap<Rc<K>, Rc<V>>,
    right_to_left: HashMap<Rc<V>, Rc<K>>,
}

impl<K: Eq + Hash + Debug, V: Eq + Hash + Debug> BidirectionalMap<K, V> {
    fn new() -> Self {
        Self {
            left_to_right: HashMap::new(),
            right_to_left: HashMap::new(),
        }
    }

    fn insert(&mut self, left: K, right: V) {
        let left = Rc::new(left);
        let right = Rc::new(right);
        self.left_to_right.insert(left.clone(), right.clone());
        self.right_to_left.insert(right, left);
    }

    fn remove_by_left(&mut self, left: &K) -> Option<(K, V)> {
        if let Some(right) = self.left_to_right.remove(left) {
            let left = self.right_to_left.remove(&right).unwrap();
            return Some((
                Rc::try_unwrap(left).unwrap(),
                Rc::try_unwrap(right).unwrap(),
            ));
        }
        None
    }
}

fn main() {}

#[cfg(test)]
mod tests {
    use super::*;

    #[test]
    fn test01() {
        let mut m = BidirectionalMap::new();

        m.insert("a".to_string(), 1);
        assert_eq!(None, m.remove_by_left(&"b".to_string()));
        assert_eq!(
            Some(("a".to_string(), 1)),
            m.remove_by_left(&"a".to_string())
        );
        assert!(m.left_to_right.is_empty());
        assert!(m.right_to_left.is_empty());
    }
}

Used Command
$ cargo tarpaulin --out html

Environments

Rust 1.82.0

tarpaulin 0.31.2

macOS Sonoma 14.7 (M3 mac)

Perhaps this issue is specific to macOS or specific to ARM architecture?
When I tried the same command for the same code with the same Rust and tarpaulin versions on Arch Linux / x86_64, it gave this correct result:

So on mac and non linux x86 systems the coverage instrumentation is the same in the Rust compiler (the llvm coverage) by default. This is essentially LLVM instrumentation put by instructions and things like constant folding etc can remove them and then I can't do anything about it.
It's generally worthwhile in these cases to check if it's still an issue with cargo-llvm-cov and if so raise an issue on the rust compiler because it's out of my hands. But if it works on cargo-llvm-cov let me know because we should both agree on these cases

@xd009642
Thank you for your response.
I just installed cargo-llvm-cov and executed cargo llvm-cov --open.
It gave me the correct coverage:

Confirming that cargo-llvm-cov correctly identify those lines as ran.

I have also found this issue on a Mac M1.
Note that tarpaulin:

does not say that the line was not ran (red highlight)
but it fails to say that the line was ran (green highlight)

_Repro code:_
mod test {
    #[allow(dead_code)]
    fn pattern_matching(my_option: Option<i32>) -> i32 {
        let mut result = 0;

        if let Some(value) = my_option {
            //FIXME: Tarpaulin does not mark this line as ran, even thought it has.
            // https://github.com/xd009642/tarpaulin/issues/1644
            result += value;
        } else {
            //NOTE: Tarpaulin correctly says the line below was never ran.
            panic!("my_option does not have value")
        }

        #[allow(clippy::single_match)]
        match my_option {
            Some(value) => result += value,
            //NOTE: Tarpaulin correctly says the line below was never ran.
            _ => panic!("my_option does not have value"),
        }

        if my_option.is_some() {
            let value = my_option.unwrap();
            result += value;
        } else {
            //NOTE: Tarpaulin correctly says the line below was never ran.
            panic!("my_option does not have value")
        }

        result
    }

    #[test]
    fn test_coverage() {
        assert_eq!(pattern_matching(Some(1)), 3);
    }
}

> cargo tarpaulin --version
cargo-tarpaulin-tarpaulin 0.31.2


src: unit test for create yaml function

Connects to #197

Coverage increased (+1.2%) to 81.053% when pulling 335aba872aae6ea59abff4557550e988e5922445 on helio-frota:pr into bd6e35f40bfd6be573032d5749037b6a6d52d96c on bucharest-gold:master.


Issues/1495 instagram stories

Category
This change is exactly one of the following (please change [ ] to [x]) to indicate which:

[X] a bug fix (Fix #1495 )
[ ] a new Ripper
[ ] a refactoring
[ ] a style change/fix
[ ] a new feature

Description
Fix stories hash regex
Testing
Required verification:

[X] I've verified that there are no regressions in mvn test (there are no new failures or errors).
[X] I've verified that this change works as intended.

[X] Downloads all relevant content.
[ ] Downloads content from multiple pages (as necessary or appropriate).
[ ] Saves content at reasonable file names (e.g. page titles or content IDs) to help easily browse downloaded content.

[X] I've verified that this change did not break existing functionality (especially in the Ripper I modified).

Optional but recommended:

[ ] I've added a unit test to cover my change.

Is fixed better in https://github.com/RipMeApp/ripme/pull/1499


Update images for SDK & Libraries page

Update images for SDK & Libraries page
Here is the design: https://www.figma.com/file/6NA1usM50PE2DG74CjL8A5/SDK%2FLibraries?node-id=181%3A1467

If this issue hasn't been worked on, can I get assigned to it? I will take care of it.

I worked on the issue. is this how the images are expected to appear

I worked on the issue and submitted a pull request.
if there is a bounty for this fix
Account Number : 34830d09415a8479c28723528e87eb5e20721addac21522255b04b5baa8046c5

Hey @thesanjeevsharma please review this one. Thanks

@manishram please pay the PR bounty to @mwelwankuta

thank you


Add promtool command to check expressions

Adds command to check expressions
promtool check expressions --help
usage: promtool check expressions

Pass Prometheus expressions over stdin to check if they are valid.

Each line is considered a separate expression.

examples:

$ cat expressions.prom | promtool check expressions

Flags:
  -h, --help     Show context-sensitive help (also try --help-long and --help-man).
      --version  Show application version.

Closes https://github.com/prometheus/prometheus/issues/7167

I'm not sure about "each line is a separate expression". e.g. Grafana is mentioned in the issue; I happily use multiple lines in my Grafana queries (it's quite useful to put a comment above a query for example, or break up an expression). I also don't believe there's any other place in Prometheus where PromQL is treated as a single line, so this would be an anomaly.
(Closest I can think of is promtool query instant, as it's PromQL on a command line, but still, this works:
$ promtool query instant http://prometheus.demo.do.prometheus.io "# test query
up +
0"
{env="demo", instance="demo.do.prometheus.io:9093", job="alertmanager"} => 1 @[1624957836.518]
[snip]

)
I kind of think it would be better to first implement promtool check expression, that either takes an expression as a parameter (like query instant does), or if no parameter, reads stdin. That way if you want the behaviour of "each line is an expression", you can do something like <expressions.prom xargs -n1 -d '\n' promtool check expression without Prometheus having to compromise on what PromQL looks like.

addressed comments, ptal!

@dgl I've used a double loop to parse the file now, so there's no requirement to have promQL queries be limited to a  single line. let me know what you think!

Thanks, for the update and sorry for the delay, took me a while to test this out.
I'm afraid this still has problems, for example:
$ ./promtool check expressions
up
*1
invalid 'expr': cannot be parsed: *1
$ ./promtool check expressions
# example
up
invalid 'expr': cannot be parsed: # example

We can't assume that if an expression parses without an error it is a complete expression.
I think like I said we should go for the minimal viable approach of implementing check expression rather than trying to make a way to check a list of expressions that takes those expressions in a new format not used elsewhere in Prometheus.

thanks for the review!
since we can't accept multiple promQL queries in the input file without creating new DSL to separate them from one another, i've reverted the commits that attempted to do so.

We discussed this during our bug scrub.
We believe that this functionality is essentially implemente by the promtool promql format command.
Therefore, we will close this. @dgl if you think there is something in this PR that is still worthy to resurrect, please follow up.


Added missed semicolon

This is fix for this issue:
https://github.com/alexei/sprintf.js/issues/159

Fixed


CB-21044 Patch FreeIPA constants lib to support hostnames longer than…

… 64 chars
RedHat claims that hostname must be the same as FQDN thus have the limit 64 char for the hostname/FQDN. As we don't set the hostname to FQDN, it's possible the FQDN is longer than 64 char, but this limit would cause failures on client side when ipa-client-install is run. This change is introduced in RH8, Centos7 works fine. Commit causing the validation error: https://github.com/freeipa/freeipa/commit/6662e99e173a16059271528e1fa58e37a3028924
The limit on FreeIPA server side is also increased: https://github.com/hortonworks/cloudbreak/commit/18a867c6b47fc6efb39dd50c3f5557f3940f25bb

@akanto I've replaced file.replace with file.patch which would fail if the patch could not be done for any reason. Tested with moving the line and deleting it


sshfs: support interactive input

related: #12

Not sure whether or not this belongs in upstream fsspec sshfs. As far as I can tell none of the existing fsspec implementations allow any kind of interactive input for auth, so I kept this in dvc-ssh for now.


Fix README: Twitter no longer uses Jobvite

Thanks for this repository!
I tried the example from the README and it was failing due to the fact that Twitter no longer employs Jobvite for job applications (example).
I replaced the company ID of Twitter with another company that is still active on Jobvite (TiVo) and the code worked flawlessly. 🎉

Thanks @claudiob 🙇


perf: optimize code performance

Description

Linked Issues
Additional context

Thank you so much for taking the time to review my PR and providing feedback. I'm sorry if my changes have caused any unnecessary trouble for you.
I completely understand your concerns, and I absolutely agree with your point about the need to handle code optimization/refactoring with care. I will keep your advice in mind and make an effort to better understand the requirements and implementation of the codebase, so that I can contribute more effectively to the project.
Once again, thank you for your invaluable feedback, and I look forward to continuing to work with you in the future.


search does not work

I get this error:
[Error - 10:22:03 PM] Client codeium: connection to server is erroring. Shutting down server.
[Error - 10:22:03 PM] Client codeium: connection to server is erroring. Shutting down server.
[Error - 10:22:03 PM] Stopping server failed
Error: Client is not running and can't be stopped. It's current state is: starting
at S.shutdown (c:\Users\profile.vscode\extensions\codeium.codeium-1.2.15\dist\extension.js:2:1657798)
at S.stop (c:\Users\profile.vscode\extensions\codeium.codeium-1.2.15\dist\extension.js:2:1657379)
at S.stop (c:\Users\profile.vscode\extensions\codeium.codeium-1.2.15\dist\extension.js:2:1817610)
at S.handleConnectionError (c:\Users\profile.vscode\extensions\codeium.codeium-1.2.15\dist\extension.js:2:1663342)
at c:\Users\profile.vscode\extensions\codeium.codeium-1.2.15\dist\extension.js:2:1662169
at c:\Users\profile.vscode\extensions\codeium.codeium-1.2.15\dist\extension.js:2:1661335
at o.invoke (c:\Users\profile.vscode\extensions\codeium.codeium-1.2.15\dist\extension.js:2:1612063)
at i.fire (c:\Users\profile.vscode\extensions\codeium.codeium-1.2.15\dist\extension.js:2:1612828)
at c:\Users\profile.vscode\extensions\codeium.codeium-1.2.15\dist\extension.js:2:1604438
at o.invoke (c:\Users\profile.vscode\extensions\codeium.codeium-1.2.15\dist\extension.js:2:1612063)
at i.fire (c:\Users\profile.vscode\extensions\codeium.codeium-1.2.15\dist\extension.js:2:1612828)
at y.fireError (c:\Users\profile.vscode\extensions\codeium.codeium-1.2.15\dist\extension.js:2:1624077)
at Socket. (c:\Users\profile.vscode\extensions\codeium.codeium-1.2.15\dist\extension.js:2:1624863)
at Socket.emit (node:events:525:35)
at Socket.emit (node:domain:489:12)
at emitErrorNT (node:internal/streams/destroy:157:8)
at emitErrorCloseNT (node:internal/streams/destroy:122:3)
at process.processTicksAndRejections (node:internal/process/task_queues:83:21)
the chat works fine though!

This repository is specific to the Codeium vim plugin. Please report issues with the VSCode extension on our Discord: https://discord.com/invite/3XFf78nAx5


Can't run terragrunt apply

I have a simple hello world terragrunt example and I am getting the following error:
$ tg apply
[terragrunt] [C:\dev\code\personal\terragrunt-hello-world\live\staging\app] 2019/08/02 15:35:43 Running command: terraform --version
[terragrunt] 2019/08/02 15:35:44 Reading Terragrunt config file at C:/dev/code/personal/terragrunt-hello-world/live/staging/app/terragrunt.hcl
[terragrunt] 2019/08/02 15:35:44 Downloading Terraform configurations from file://C:/dev/code/personal/terragrunt-hello-world/infrastructure into C:/dev/code/personal/terragrunt-hello-world/live/staging/app/.terragrunt-cache/Iuk57wqOPE_7PkKaFmUOii7vrSQ/jIMZ6meZTUEKM4-_y0agCmUjNao
[terragrunt] 2019/08/02 15:35:44 Hit multiple errors:
error downloading 'file://C:/dev/code/personal/terragrunt-hello-world/infrastructure': remove C:\dev\code\personal\terragrunt-hello-world\live\staging\app\.terragrunt-cache\Iuk57wqOPE_7PkKaFmUOii7vrSQ\jIMZ6meZTUEKM4-_y0agCmUjNao\app\myapp\main.tf: The system cannot find the file specified.
[terragrunt] 2019/08/02 15:35:44 Unable to determine underlying exit code, so Terragrunt will exit with error code 1

Steps to reproduct
git clone https://github.com/jamie3/terragrunt-hello-world
cd terragrunt-hello-world
cd live/staging/app
# First step works
terragrunt init
# This fails
terragrunt apply

You might be hitting the long paths issue with Windows. Can you try this workaround and see if that works? https://github.com/gruntwork-io/terragrunt/issues/581#issuecomment-460051767

I tried the following:
export TERRAGRUNT_DOWNLOAD=/c/.terragrunt-cache
rm -rf .terraform-cache
terragrunt init
# Fail
terragrunt apply

FYI im running this inside VSCode bash shell
[terragrunt] [C:\dev\code\personal\terragrunt-hello-world\live\staging\app] 2019/08/02 15:58:55 Running command: terraform --version
[terragrunt] 2019/08/02 15:58:55 Reading Terragrunt config file at C:/dev/code/personal/terragrunt-hello-world/live/staging/app/terragrunt.hcl
[terragrunt] 2019/08/02 15:58:55 Downloading Terraform configurations from file://C:/dev/code/personal/terragrunt-hello-world/infrastructure into C:/.terragrunt-cache/Iuk57wqOPE_7PkKaFmUOii7vrSQ/jIMZ6meZTUEKM4-_y0agCmUjNao
[terragrunt] 2019/08/02 15:58:55 Hit multiple errors:
error downloading 'file://C:/dev/code/personal/terragrunt-hello-world/infrastructure': remove C:\.terragrunt-cache\Iuk57wqOPE_7PkKaFmUOii7vrSQ\jIMZ6meZTUEKM4-_y0agCmUjNao\app\myapp\main.tf: The system cannot find the file specified.
[terragrunt] 2019/08/02 15:58:55 Unable to determine underlying exit code, so Terragrunt will exit with error code 1

Which version of terragrunt are you using? I'm wondering if there is a bug from https://github.com/gruntwork-io/terragrunt/releases/tag/v0.19.13. Can you try https://github.com/gruntwork-io/terragrunt/releases/tag/v0.19.12?

Sorry should have specified this terragrunt version v0.19.16

That seemed to work. When I downgraded to 0.19.12 it worked

FYI @brikis98 @ekini Looks like this is a bug from https://github.com/gruntwork-io/terragrunt/pull/774.

I think I know why it's happening. So I tried to clone the repo from scratch and wasn't able to reproduce the issue.
But this error might happen if:

You have main.tf in both terraform_source and the terragrunt module directory.
Run terragrunt init to copy the files. main.tf from terragrunt module will override the file copied first from terraform_source. When files are copied, they are added to 2 manifests, one for terraform source, and the other one from terragrunt module dir.
On a second run terragrunt will delete main.tf because it is in the manifest, and then try to delete it again, because it exists in the second manifest.
Previously, os.RemoveAll golang function was used without a comment, and it didn't make sense to use it to remove one file. Normally it's used to recursively delete files. I changed it to os.Remove as per the comment, and because it seemed logical. However, os.RemoveAll has a nice side effect: it doesn't return an error if the file doesn't exist already.

So I reverted it to using RemoveAll again, and added a comment explaining why this particular function is used. Hope it helps.
Thanks @jamie3 for the bug report!

Please try https://github.com/gruntwork-io/terragrunt/releases/tag/v0.19.17. Thank you to @ekini for the fix!


Support statisics service API

See https://git.corp.adobe.com/pages/experience-platform/api-specification/?urls.primaryName=└ Statistics Service
We should have a module to support that.

Thanks for sharing this. The link does not work for me but it sounds interesting.


Added a Node StoreLister type

I'm building an ALB ingress controller that will leverage NodePorts, this was needed to be able to access the EC2 IDs of the nodes.

@bigkraig please open this PR in the main repo


Allow ibmcloud provider to be deployed as a POD

The type field of a volume causes the following error:

Error from server (BadRequest): error when creating "install/overlays/ibmcloud": Deployment in version "v1" cannot be handled as a Deployment: strict decoding error: unknown field "spec.template.spec.volumes[0].type"

Deployment of cloud-api-adaptor-deployment-ibmcloud fails since the image pull policy is always but the target image is not yet available on quay.io.

The type field of a volume causes the following error:

Error from server (BadRequest): error when creating "install/overlays/ibmcloud": Deployment in version "v1" cannot be handled as a Deployment: strict decoding error: unknown field "spec.template.spec.volumes[0].type"

Deployment of cloud-api-adaptor-deployment-ibmcloud fails since the image pull policy is always but the target image is not yet available on quay.io.

@inatatsu thanks for providing the feedback. Can you please retry and let me know.


C Core API cleanup.

Simplify grpc_event into something that can be non-heap allocated.
Deprecate grpc_event_finish.
Remove grpc_op_error - use an int as this is more idiomatic C style.

The changes to Node and PHP look good to me.

@nathanielmanistaatgoogle, @soltanmm - PTAL at Python code here
@murgatroid99, @jcanizales - Could someone send me a pull request against this for Objective C
@jtattermusch - I got a little bit done for Objective-C, but then my build environment failed - can you send me a pull request against this for the rest?
@tbetbetbe - I haven't touched Ruby due to some install issues on my machine - can you (or somebody) send a pull request against this for it?

@yang-g - PTAL at the C++ code

LGTM

LGTM but @soltanmm is actively working on the affected Python code and will conduct a more thorough review.

Other than a minor concern about a little itty bit I'm going to have to change in my running work in https://github.com/grpc/grpc/compare/grpc:master...soltanmm:extension, LGTM.

Re the Objective-C change: let's add ".DS_Store" files to the gitignore.

Can someone send me a PR against this one to do this?
On Mon, May 11, 2015 at 10:50 AM Jorge Canizales<EMAIL_ADDRESS>wrote:

Re the Objective-C change: let's add ".DS_Store" files to the gitignore.
—
Reply to this email directly or view it on GitHub
https://github.com/grpc/grpc/pull/1472#issuecomment-100996012.

I can do that

@tbetbetbe - can you look over the Ruby changes
@yang-g - can you look over the rest

(also: Green)

Fixes #1576


Support Beego JSON format

Is it possible to parse this json https://github.com/astaxie/beego/pull/2863 ?

Looks like it is possible. Please feel free to post a few samples lines. Thanks.

2018/05/02 17:51:41.255 [server.go:2741]  {"remote_addr":"<IP_ADDRESS>","request_time":"2018-05-02T17:51:40.478269717+01:00","request_method":"GET","request":"GET /page HTTP/1.1","server_protocol":"HTTP/1.1","host":"gadelkareem.com","status":200,"body_bytes_sent":0,"elapsed_time":777262464,"http_referrer":"","http_user_agent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; Googlebot/2.1; +http://www.google.com/bot.html) Safari/537.36","remote_user":""}
2018/05/02 17:51:42.190 [server.go:2741]  {"remote_addr":"<IP_ADDRESS>","request_time":"2018-05-02T17:51:42.18455599+01:00","request_method":"GET","request":"GET /page2 HTTP/1.1","server_protocol":"HTTP/1.1","host":"gadelkareem.com","status":200,"body_bytes_sent":0,"elapsed_time":6394816,"http_referrer":"https://gadelkareem.com/","http_user_agent":"Mozilla/5.0 (Windows NT 10.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/71.0.3578.98 Safari/537.36","remote_user":""}
2018/05/02 17:51:42.201 [server.go:2741]  {"remote_addr":"<IP_ADDRESS>","request_time":"2018-05-02T17:51:39.357598357+01:00","request_method":"GET","request":"GET / HTTP/1.1","server_protocol":"HTTP/1.1","host":"gadelkareem.com","status":200,"body_bytes_sent":0,"elapsed_time":2843595161,"http_referrer":"","http_user_agent":"Mozilla/5.0 (Linux; Android 6.0.1; Nexus 5X Build/MMB29P) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/41.0.2272.96 Mobile Safari/537.36 (compatible; Googlebot/2.1; +http://www.google.com/bot.html)","remote_user":""}

Sorry for the delay on my reply. This should work:
goaccess access.log --log-format='%d %t.%^ %^ %^:"%h",%^:"%^",%^:"%^",%^:"%r",%^:"%^",%^:"%v",%^:%s,%^,%^,%^:"%R",%^:"%u",%^:"%e"' --date-format=%Y/%m/%d --time-format=%T

I'm not sure the elapsed_time values are in microseconds? If they are, you could try:
goaccess access.log --log-format='%d %t.%^ %^ %^:"%h",%^:"%^",%^:"%^",%^:"%r",%^:"%^",%^:"%v",%^:%s,%^,%^:%D,%^:"%R",%^:"%u",%^:"%e"' --date-format=%Y/%m/%d --time-format=%T

Great thanks!  the elapsed_time is in nanosecond. The parsing is taking quite some time to finish but the end result is amazing!

great to hear it worked. though, you won't be able to parse the elapsed_time w/o some preprocessing of the log. closing this. feel free to reopen it if needed.


Added support for new kubernetes ingress syntax, pathType

Hello everyone.
When i tried to use component-chart with minikube(1.20.0) with enabled ingress addon and fresh kubernetes() i got an error:
[fatal]  error deploying: error deploying <WIPED>: Unable to deploy helm chart: error during 'helm upgrade <WIPED>; --values /tmp/635534093 --install --kube-context minikube': W0610 17:09:33.468780  101725 warnings.go:70] extensions/v1beta1 Ingress is deprecated in v1.14+, unavailable in v1.22+; use networking.k8s.io/v1 IngressW0610 17:09:33.472288  101725 warnings.go:70] extensions/v1beta1 Ingress is deprecated in v1.14+, unavailable in v1.22+; use networking.k8s.io/v1 Ingress
So i decided to fix this problem and created this PR.
FYI: Some code copypasted from helm default Ingress template.
Please review carefully, maybe i forgot something

Any updates on getting this merged? If not is there a work around?

@zefman
As a workaroud you can try to delete ValidatingWebhookConfiguration for minikube nginx ingress.
for example: kubectl delete -A ValidatingWebhookConfiguration ingress-nginx-admission
@LukasGentele maybe you can review and merge this PR?

@iamtio Sorry for taking so long to have a look at this and thanks for the ping.

Thanks for the contribution, @iamtio. Much appreciated 🙂


Eager loading

It's loading!  It's eager!  OMG!!!1

Coverage decreased (-0.17%) to 98.25% when pulling 39c985249adcfe0146310badc8b7beb7cc1d4ea5 on eager_loading into a4ccaa99d40919647a2f4af193759b2bc7258f96 on master.

Coverage decreased (-0.17%) to 98.25% when pulling 39c985249adcfe0146310badc8b7beb7cc1d4ea5 on eager_loading into a4ccaa99d40919647a2f4af193759b2bc7258f96 on master.

Coverage decreased (-0.17%) to 98.25% when pulling 39c985249adcfe0146310badc8b7beb7cc1d4ea5 on eager_loading into a4ccaa99d40919647a2f4af193759b2bc7258f96 on master.

Coverage decreased (-0.17%) to 98.25% when pulling db00e26dbae7e7dc98fd26892ef6affd50791992 on eager_loading into 5c960c12ed4f1633bdbbf9c6b2987ffe7e80a619 on master.

Coverage decreased (-0.17%) to 98.25% when pulling db00e26dbae7e7dc98fd26892ef6affd50791992 on eager_loading into 5c960c12ed4f1633bdbbf9c6b2987ffe7e80a619 on master.

The most-wanted feature, imho )

Agreed, though @subvertallchris is doing some performance improvements that I think will be welcomed by all as well ;)
As for a status update on this, I've got a final bit I'm trying to do which should allow eager loading to go as deep and you want.  After that I need to finish up the documentation and I'll merge.

:fireworks:

Coverage decreased (-0.12%) to 98.34% when pulling 8a6efd51dd3a3d5d7a7d265c5fca7ab1e83e4754 on eager_loading into 59938ae8656ecb4c9e3397be58c94464afd6b1ea on master.

Coverage decreased (-0.14%) to 98.32% when pulling<PHONE_NUMBER>cb9f320fd97d96bcaea13f6c903dd3 on eager_loading into 59938ae8656ecb4c9e3397be58c94464afd6b1ea on master.

Coverage decreased (-0.14%) to 98.32% when pulling 78743a7fed65fb11ceac268ef8bed0dc413698e0 on eager_loading into 59938ae8656ecb4c9e3397be58c94464afd6b1ea on master.

Coverage decreased (-0.13%) to 98.32% when pulling 78743a7fed65fb11ceac268ef8bed0dc413698e0 on eager_loading into 59938ae8656ecb4c9e3397be58c94464afd6b1ea on master.

Coverage decreased (-0.13%) to 98.32% when pulling 78743a7fed65fb11ceac268ef8bed0dc413698e0 on eager_loading into 59938ae8656ecb4c9e3397be58c94464afd6b1ea on master.

Finally, here's some eager loading for y'all!

Coverage decreased (-0.16%) to 98.17% when pulling cd12dd4ef471112f4a766124fbf23894c83d09fe on eager_loading into 7a6cf6203c1218ae15199c16db23cfd42f1ec326 on master.


feat(perl): add support for Perl

This adds support for Perl

Thank you for your PR. I get a parser error on line 31 of the test file, can you please fix that? I don't know Perl, so I cannot do it myself. And please rename the test file to test/highlight/perl/regular.pl to be more consistent with the rest.

@HiPhish sorry for toooo late.

fixed filenames: code.pl → regular.pl
I noticed tree-sitter-perl does not support string interpolation yet. so I commented out the code.

check it!

Thank you. I have squashed the commits and cleaned up a few details before merging.

d


Support of pdm along poetry package manager for python

I'm using https://pdm-project.org/latest/ which has lock file like poetry but named "pdm.lock"
When I change the filename and run the scanner some vulnerabilities had been found. Generating a requirements.txt and using this one will fail.

Almost same problem when we use pdm  :/

File to maybe to change of clone...
# chussenot @ t495 in /tmp/tmp.qsVWT4DAyh [17:44:18]
$ ag poetry.lock
DependencyCheck/core/src/test/java/org/owasp/dependencycheck/analyzer/PoetryAnalyzerTest.java
56:        assertThat(analyzer.accept(new File("poetry.lock")), is(true));
61:        final Dependency result = new Dependency(BaseTest.getResourceAsFile(this, "poetry.lock"));

DependencyCheck/core/src/main/java/org/owasp/dependencycheck/analyzer/PoetryAnalyzer.java
70:    private static final String POETRY_LOCK = "poetry.lock";
76:     * The file filter for poetry.lock
78:    private static final FileFilter POETRY_LOCK_FILTER = FileFilterBuilder.newInstance()
79:            .addFilenames(POETRY_LOCK, PYPROJECT_TOML)
119:        return POETRY_LOCK_FILTER;
196:            d.addEvidence(EvidenceType.PRODUCT, POETRY_LOCK, "product", name, Confidence.HIGHEST);
197:            d.addEvidence(EvidenceType.VERSION, POETRY_LOCK, "version", version, Confidence.HIGHEST);
198:            d.addEvidence(EvidenceType.VENDOR, POETRY_LOCK, "vendor", name, Confidence.HIGHEST);
204:        final File lock = new File(parent, POETRY_LOCK);
210:                    + "is not a `poetry.lock` or `requirements.txt` - analysis will be incomplete");

@nerdinand @jeremylong  Can you help us to work on it?

It's seems that the skip is no more working as you wrote in the CHANGELOG.

## [Version 9.0.7](https://github.com/jeremylong/DependencyCheck/releases/tag/v9.0.7) (2023-12-18)

- docs: document insecure configuration for GHSA-qqhq-8r2c-c3f5 (#6315)
- fix: improve memory usage on NVD update (#6321)
- fix: skip pyproject.toml unless it contains `tool.poetry` (#6316)
- fix: resolve build error that may cause an issue on some JDK versions (#6312)


Add bubble sort algorithm

Note - If you are implementing the algorithm in java then create it under the directory /java. Ther is no restriction for the language

Please accept my pull request for BubbleSort.java


Use named import over import *

refactor(runtime-dom): use named import over import *; also apply linting
While this may not impact build size, coming as this does in a declaration file, having come across one named import in source (as a general no-no in an audit trying to minimize package size), thought we would offer this more focused import which instead exclusively draws in the property actually used. Also found a few linting fixes upon running yarn lint.
Thanks!

Thanks but I don't think this makes any difference.


remove unfinished code snippets

Some month ago I added a python based script - mainly to demo some code for #88.
So far the code did not prove to be a significant improvement over the great job you have been doing in bash.
Additionally - and unfortunately - I have not been able to keep up with the changes that were made to the inner workings of RaspiBlitz (e.g. raspiblitz.conf file..).
I suggest to remove this broken code from the master and release (v1.2) branches in order to not confuse users with outdated, seemingly duplicate scripts.

In the long view I think its stil important to get to a infoservice like deamon similar you concepted in #88. But in the short view it showed that there is much prio to focus on stability and data security of the node first and put time resources there - thats what is v1.2 and also v1.3 will be about.
But while going thru the scripts I already started to create more seperation between UI and config logic what is needed to make the switch to a web UI in the future. I also started to fresh up my python skills (some new scripts are in python) and experimenting with a way to use the existing bash scripts from python scripts. That way existing and tested bash scripts can still be part of the future versions and it will reducing a lot of rewrites and retests. So it will be a an iterative process over a longer time than expected until a switch can be made.
Possibly chaos camp can be a good point in time for that combined with the possobility to sync up in person and plan on how to finally switch to a WebUI/deamon structure. So much thanks for the input so far, keep it up ... we take the long way home ... but we will get there :)
https://www.youtube.com/watch?v=aoEUeTxmYHk


[AutoPR apimanagement/resource-manager] Make 2018-01-01 as default for all clients

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/3633

This PR has been merged into https://github.com/Azure/azure-sdk-for-python/pull/3106


feat(config): Allow overriding of remote API URL

Description

This PR aims to simplify the configuration of remote API URL for a particular remote by adding the option in the remote section.
Motivation and Context
Up until now, an environment variable needed to be set such as GITLAB_API_URL_ENV
fixes #704

How Has This Been Tested?
I only ran the existing tests, as I was unsure of where tests for this feature would have to be added. If there's a particular place I should consider adding them in, let me know.

Screenshots / Logs (if applicable)
Types of Changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation (no code change)
[x] Refactor (refactoring production code)
[ ] Other

Checklist:

[x] My code follows the code style of this project.
[x] I have updated the documentation accordingly.
[x] I have formatted the code with rustfmt.
[x] I checked the lints with clippy.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

Questions
The change introduces a refactor which I wouldn't consider a breaking change. The functionality is preserved but essentially the api_url() method in the RemoteClient has now a default implementation which leverages on the constants API_URL and API_URL_ENV which allows us to just implements the various traits by setting the appropriate  constants without duplicating the code.
I have two questions related to this:

Is this a welcomed refactor?
In the following code:

https://github.com/pauliyobo/git-cliff/blob/c2398dc452b0f8c3aef1a3f7db8c6748a6de7f24/git-cliff-core/src/repo.rs#L397-L444
I wasn't sure of whether the returned upstream  remote should also have its proper api_url set. Is that the case? I have left it on None for now.

Codecov Report
Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 40.23%. Comparing base (bfe9beb) to head (01478d1).

Files with missing lines
Patch %
Lines

git-cliff-core/src/remote/mod.rs
0.00%
3 Missing :warning:

git-cliff-core/src/repo.rs
0.00%
1 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #896      +/-   ##
==========================================
+ Coverage   40.04%   40.23%   +0.20%
==========================================
  Files          21       21
  Lines        1671     1663       -8
==========================================
  Hits          669      669
+ Misses       1002      994       -8

Flag
Coverage Δ

unit-tests
40.23% <0.00%> (+0.20%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Hello, thanks for the PR! I pushed some nitpicks & refactored the remote handling a bit not to keep you waiting any longer :) Now, when it comes to your questions:

I only ran the existing tests, as I was unsure of where tests for this feature would have to be added. If there's a particular place I should consider adding them in, let me know.

Yup, we should add a fixture test to make sure this is working. I would suggest copying test-gitlab-integration and using a project hosted on a custom GitLab instance (e.g. arch-repro-status.
Also, I couldn't see the part where we override the remote URL with the value taken from config yet. We should probably do that as well.

Is this a welcomed refactor?

Yup, I think it's good :)

I wasn't sure of whether the returned upstream remote should also have its proper api_url set.

Not really, this should be left like this for now.

Sorry for the delayed review, would you be able to address these sometime? 😊

Hello, thanks for the feedback.
I'm a bit busy this week, will try to get something out by the next.
Thank you.