(enhancement)chaosresult: add an instance_id to chaosresult name and spec

Signed-off-by: ksatchit<EMAIL_ADDRESS>
What this PR does / why we need it:

Adds a user-defined string to the chaosresult name and also the CR spec to enable users to define an "instance" of chaos.
Useful in cases where existing chaosresult resources are not to be overwritten
The instance info is taken as an env var INSTANCE_ID in the chaosengine

Note: This change also necessitates an update to the chaos-runner to process the INSTANCE_ID info and pass it to the experiment job.
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Checklist

[ ] Does this PR have a corresponding GitHub issue?
[ ] Have you included relevant README for the chaoslib/experiment with details?
[ ] Have you added debug messages where necessary?
[ ] Have you added task comments where necessary?
[ ] Have you tested the changes for possible failure conditions?
[ ] Have you provided the positive & negative test logs for the litmusbook execution?
[ ] Does the litmusbook ensure idempotency of cluster state?, i.e., is cluster restored to original state?
[ ] Have you used non-shell/command modules for Kubernetes tasks?
[ ] Have you (jinja) templatized custom scripts that is run by the litmusbook, if any?
[ ] Have you (jinja) templatized Kubernetes deployment manifests used by the litmusbook, if any?
[ ] Have you reused/created util functions instead of repeating tasks in the litmusbook?
[ ] Do the artifacts follow the appropriate directory structure?
[ ] Have you isolated storage (eg: OpenEBS) specific implementations, checks?
[ ] Have you isolated platform (eg: baremetal kubeadm/openshift/aws/gcloud) specific implementations, checks?
[ ] Are the ansible facts well defined? Is the scope explicitly set for playbook & included utils?
[ ] Have you ensured minimum/careful usage of shell utilities (awk, grep, sed, cut, xargs etc.,)?
[ ] Can the limtusbook be executed both from within & outside a container (configurable paths, no hardcode)?
[ ] Can you suggest the minimal resource requirements for the litmusbook execution?
[ ] Does the litmusbook job artifact carry comments/default options/range for the ENV tunables?
[ ] Has the litmusbooks been linted?

Special notes for your reviewer:

apiVersion: litmuschaos.io/v1alpha1
kind: ChaosResult
metadata:
  annotations:
    kubectl.kubernetes.io/last-applied-configuration: |
      {"apiVersion":"litmuschaos.io/v1alpha1","kind":"ChaosResult","metadata":{"annotations":{},"creationTimestamp":"2020-04-29T12:53:15Z","generation":2,"labels":{"chaosUID":"","type":"ChaosResult"},"name":"nginx-chaos-pod-delete-29-04-2020","namespace":"default","resourceVersion":"8587296","selfLink":"/apis/litmuschaos.io/v1alpha1/namespaces/default/chaosresults/nginx-chaos-pod-delete-t1","uid":"6489759d-8a18-11ea-a20f-42010a800064"},"spec":{"engine":"nginx-chaos","experiment":"pod-delete","instance":"29-04-2020"},"status":{"experimentstatus":{"failStep":"N/A","phase":"Completed","verdict":"Pass"}}}
  creationTimestamp: 2020-04-29T13:08:32Z
  generation: 1
  labels:
    chaosUID: ""
    type: ChaosResult
  name: nginx-chaos-pod-delete-29-04-2020
  namespace: default
  resourceVersion: "8590348"
  selfLink: /apis/litmuschaos.io/v1alpha1/namespaces/default/chaosresults/nginx-chaos-pod-delete-29-04-2020
  uid: 8728bd48-8a1a-11ea-a20f-42010a800064
spec:
  engine: nginx-chaos
  experiment: pod-delete
  instance: 29-04-2020
status:
  experimentstatus:
    failStep: N/A
    phase: Completed
    verdict: Pass

Thanks @Jasstkn this is the corresponding PR in the docs repo: https://github.com/litmuschaos/litmus-docs/pull/269


build grpc_php_plugin in github actions with setup-php

I want to build grpc_php_plugin in github actions with setup-php
like below
git clone -b v1.27.0 https://github.com/grpc/grpc
cd grpc && git submodule update --init && make grpc_php_plugin
mv grpc_php_plugin /usr/local/bin
I use v2 version
I think this can add to tools label.

@zhangchunsheng
Now you can setup grpc_php_plugin and protoc.
- name: Setup PHP
  uses: shivammathur/setup-php@v2
  id: php
  with:
    php-version: 7.4
    tools: protoc, grpc_php_plugin

grpc_php_plugin path is exported as grpc_php_plugin_path which can be used in a later step.
For example
- name: Test grpc_php_plugin and protoc
  run: |
    git clone https://github.com/grpc/grpc
    cd grpc/examples/php
    protoc --proto_path=../protos --php_out=. --grpc_out=. --plugin=protoc-gen-grpc=${{ steps.php.outputs.grpc_php_plugin_path }} ../protos/helloworld.proto


[doc] Write Documentation for System Call Interface

Description
We should have a documentation for the Demikernel system call interface.

This issue was fixed in commit 267a1190a7eb78ccba3803ec194a47bdf122a5f3.


Is there reason to have two separate path declaraions?

Looks like in tasks we have two ways to define working path. Smth like
{{ home }}/eth-netstats
and
/home/{{ username }}/eth-netstats
Is there reason two have them both?
@phahulin

They should be equal, but I agree, we should have a single one, maybe
home: /home/{{ username }}

defined at the top of the playbook and then home used everywhere else?

It also might be a good idea to rewrite all the occurrencies of {{ home }} variables into /home/{{ username }} since it will allow us to remove {{ home }} variable at all and use {{ username }} only. It will simplify the process and reduce the possibility of errors.


Update AAVE/GHO token logos, add stkGHO

Update the AAVE/GHO token logos to align to latest branding.
Update GHO token label from Gho to GHO
Add staked GHO (stkGHO) token to the contract metadata.

Official website: https://www.aave.com
Project activity:
$19B in Total Value Locked (TVL) across all networks

Etherscan:
stkGHO Contract address: 0x1a88Df1cFe15Af22B3c4c783D4e6F7F9e0C1885d
Reputation: OK
Verified contract: Yes, https://etherscan.io/address/0x1a88Df1cFe15Af22B3c4c783D4e6F7F9e0C1885d#code

This token meets the criteria for inclusion as it has:
A clear use case in the DeFi ecosystem as a wrapped version of ether.fi's liquid staking token
Significant Total Value Locked in the parent protocol, indicating strong adoption
A verified contract on Etherscan
A OK reputation on Etherscan
An active and informative official website

@MRabenda - just realised the token map I provided references stkGHO.svg when the actual filename is STKGHO.svg
Not sure if this will be an issue?


Correct error in VertexBufferObjectWithVAO

Move "bindAttributes" out of the condition in "bind" function.
This Pull Request is linked to this issue: https://github.com/libgdx/libgdx/issues/3050

Thanks!


Command "ls" showing the wrong directory on windows

When start the cloverxell, and try to use the "ls" command is showing the wrong direcotry

https://issues.jboss.org/browse/AESH-298

thanks @efraimgentil and https://github.com/jerr/ !


iOS - "SyntaxError: Unexpected identifier 'Error'. Expected ')' to end a argument list."

I'm getting this error when I try to go into offline mode in my app.  As best I can tell it is caused by this plugin.  If I remove it from my config, everything works correctly.
Unfortunately, it's not giving me any stack trace so I really have no way of debugging this.
My steps to reproduce are:

Install
Start the app up.  Wait a minute for everything to initialize
Go into airplane mode to fire the cordova offline handlers.
Observe the error in the safari tools

Now I have no idea why it would be throwing a syntax error there and not when it tried to load the script into the view.  For the record, this is NOT happening on Android.

If you start the app up with no connection, it throws this error and just sits on the splash screen.  You can't even get into the app.
I built in handlers in the initialization sequence to not do the branch handlers if there is no connection, so it's something internal to the plugin that's executing when the connection is lost.

So the app not starting with no connection I mentioned above was actually because of a bug in my error processing code and you can disregard that, go figure.  But his error is still happening.  I just added a condition to ignore this specific error for the time being so I can still use the plugin.

@gabaum10 I've filed this internally and we will hopefully hear something back in the next 10-12 hours. Sorry for the inconvenience.

Hello @gabaum10,
It seems the iOS gets an error upon calling the DeepLinkHandler method from iOS to Javascript,
For some reason the response should be in form of a JSON string instead of string.
I've submitted my pull request and hopefully this will fix the error.

@gabaum10 Please check if the issue was fixed then you can close this ticket. Thanks.


Instance Options - localhost:7700 instead of <IP_ADDRESS>:7700

Summary
Replace <IP_ADDRESS>:7700 by localhost:7700 to match both ipv4 and ipv6 address.
Related to:

https://github.com/meilisearch/meilisearch/issues/2782
https://github.com/meilisearch/meilisearch/pull/2861

Changes
See Summary section.
Out Of Scope
N/A

Attention To Reviewers
N/A

Misc
N/A

@gmourier this PR is breaking as well, you might want to put the breaking label on it


Is there a way to pass in a list as a variable?

Is there a way to pass in a list as a variable?
SCENARIO 1:
GOSSFILE:
file:
my_file:
exists: true
contents: "{{ .Vars.my_list }}"
VARS FILE:
my_list:

"one"
"two"

EXECUTION
goss -g test_goss.yaml --vars test_vars.yaml v
.F
Failures/Skipped:
File: my_file: contents:
Expected
"one\ntwo\n"
to equal
"[one two]"
diff
--- test
+++ actual
@@ -1 +1,3 @@
-[one two]
+one
+two
+
Total Duration: 0.001s
Count: 2, Failed: 1, Skipped: 0
SCENARIO 2:
GOSSFILE:
file:
my_file:
exists: true
contents: ${.Vars.my_list}
VARS FILE:
my_list:

"one"
"two"

EXECUTION
goss -g test_goss.yaml --vars test_vars.yaml v
.F
Failures/Skipped:
File: my_file: contents:
Expected
"one\ntwo\n"
to equal
"${.Vars.my_list}"
diff
--- test
+++ actual
@@ -1 +1,3 @@
-${.Vars.my_list}
+one
+two
+
Total Duration: 0.001s
Count: 2, Failed: 1, Skipped: 0

Here ist an example of using a list. You need the range.
https://github.com/bitnami/containers/blob/main/.vib/common/goss/templates/check-binaries.yaml

Thank you

Not sure if I have something wrong, but I'm still getting errors.
goss.yaml
file:
{{ range $item := .Vars.my_list }}
my_file-{{ $item }}:
path: my_file
exists: true
contents: {{ $item }}
{{ end }}
vars.yaml
my_list:

one
two

my_file
one
two
goss -g goss.yaml --vars vars.yaml v
.F.F
Failures/Skipped:
File: my_file-one: my_file: contents:
Expected
"one\ntwo"
to equal
"one"
diff
--- test
+++ actual
@@ -1 +1,2 @@
one
+two
File: my_file-two: my_file: contents:
Expected
"one\ntwo"
to equal
"two"
diff
--- test
+++ actual
@@ -1 +1,2 @@
+one
two
Total Duration: 0.001s
Count: 4, Failed: 2, Skipped: 0

Thank you @dklimpel !
Anyone reading this issue, feel free to submit a PR improving the documentation if you feel it will help.


Validate that benches and tools crates are formatted in CI

          Yep. This is what we have to do, otherwise someone else is gonna run into this eventually.

Additionally, from the Bevy side, this should be checked by CI.
Originally posted by @rlidwka in https://github.com/bevyengine/bevy/pull/10758#pullrequestreview-1749866027

The issue here lies in that benches are not checked by cargo fmt --all -- --check. I've found two ways to solve it:

We can add "benches" to members of workspace in Cargo.toml. However, this could add additional overhead - especially as "benches" are currently explicitly excluded from members.
We could add flag in tools/ci/src/main.rs. This would then be: cmd!(sh, "cargo fmt --all --manifest-path  ../../../benches/Cargo.toml -- --check"). While not best, it seems to be the only solution I've found if we don't want to add benches to workspace.

I think we should start with solution 2 for now.

The issue is that benches (and compile fail crates) are excluded from the workspace:
https://github.com/bevyengine/bevy/blob/4221f7e7e9ae5b2d664a067f1fbabc97a5806232/Cargo.toml#L15-L21
I don't remember why, but if we want the benches to be checked in CI they should be in the workspace


Pass SWT through Black and Pylint

This should ensure nice formatting of the module, which can be further perfected.
Actually, all Python/Jupyter Notebook scripts should go through the same procedure (now and before any other update/pull request/commit).
This is also a prerequisite for creating a documentation.
See CONTRIBUTING GUIDELINES  for more info.

I did not manage to run Black on Jupyter notebook ...

the recommended fix did not help

So I managed to install black using "conda install black" from Jupyterlab terminal window. But when I run this on my Jupyter notebook, I was not happy with the result at all. The code takes much more space than necessary and the radability of the Jupyter notebook is then significantly compromised.
I can imagine to run this on .py files, but I dont like the result on Jupyter notebooks.


Draft: Version 1.0

TODO
THIS PR IS A WORK IN PROGRESS
The workflow is strict Stage 1 :arrow_right: Stage 2
meaning Stage 2 can't be worked on until Stage 1 is done :x:
General can be implemented at anytime because it is not related to the project. :clock10:
:bulb: General
General changes in the project. not related to the plugin core.

[x] reconstruct project structure. :heavy_check_mark:
[ ] add auto deployment to maven central (API Module)
[ ] add README.md.
[ ] Complete WIKI using gitbook.
[x] Add MIT license :heavy_check_mark:

:bangbang: Features (Stage 1)
This will have priority, this list will be completed before moving to Stage 2.
Stage 1 in short is the complete plugin feature list, though this list is prone to change at any given time.

[x] Implement basic functionality to the plugin :heavy_check_mark:

Money on mob kill :ballot_box_with_check:

[x] add daily limit:heavy_check_mark:
[x] add mysql support :heavy_check_mark:
[x] add file storage support (json) :heavy_check_mark:
[x] add support for PlaceholderAPI.
[ ] add support for WorldGuard.
[x] Implement custom event and call them correctly ✔
[x] Add Metrics (BStats) :heavy_check_mark:

:heavy_exclamation_mark: Testing (Stage 2)
Second stage is before release, this will be basically testing the plugin and fixing bugs. this list will be changed depending on how many bugs/issues will be found.

[ ] Check 1.8 - 1.18 compatibility.
[ ] Check MySQL & File Storages.
[ ] Check if API is working Correctly.
[ ] Write needed Test units.
[ ] Check WorldGuard and PlaceholderAPI compatibility

✏ Total lines of code: 2297 (+300)
⌚ Total hours spent: 5hr 45min 12sec
✅ completed percentage: 44.44%

run failure doesn't make any sense huh


XCode interaction “Resolving Package Graph” loop

Description
: I’m having the problem described here with XCode Version 14.3 (14E222b) and the SPM that comes with it.  If it's any help, I commonly switch back and forth between editing my project with Xcode and Emacs, FWIW, including using Git from the command-line.
Expected behavior
No response
Actual behavior
No response
Steps to reproduce
I don't know how to reproduce it reliably yet.
Swift Package Manager version/commit hash
Swift Package Manager - Swift 5.8.0
Swift & OS version (output of swift --version ; uname -a)
swift-driver version: 1.75.2 Apple Swift version 5.8 (swiftlang-<IP_ADDRESS>.2 clang-14<IP_ADDRESS>.100)
Target: arm64-apple-macosx13.0
Darwin DaveA-MBP14.local 22.4.0 Darwin Kernel Version 22.4.0: Mon Mar  6 20:59:28 PST 2023; root:xnu-8796.101.5~3/RELEASE_ARM64_T6000 arm64

cc @abertelrud


Issue resolved "Error in main.py"

Issue is with bitwise_and of opencv, it's better to use numpy's bitwise_and. Results are same.

Hey - This looks good, I'll merge it in. I updated travis.ci so now the issue with cv2.bitwise_and is appearing on them.

Is the issue resolved? And what's the issue with travis.cl?

Looks like it.
Issue with travis CI was using sudo apt-get install -y python-opencv and how it couldn't be accessed within the virtualenv that travis uses. Swapping to pip install opencv-python fixed the issue.

Cool. That's great!
On 22 Sep 2017 04:47, "Will Brennan"<EMAIL_ADDRESS>wrote:

Looks like it.
Issue with travis CI was using sudo apt-get install -y python-opencv and
how it couldn't be accessed within the virtualenv that travis uses.
Swapping to pip install opencv-python fixed the issue.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/WillBrennan/SkinDetector/pull/9#issuecomment-331307296,
or mute the thread
https://github.com/notifications/unsubscribe-auth/APxqUoSROylWdTaUWhP11OSoTuSFhaTnks5sku5vgaJpZM4Pf1vb
.

Btw I used your script in my colour detection package. So it was working
great just need to threshold the algorithm so that it can differentiate
between object and human skin.
On 22 Sep 2017 04:51, "Parth Sharma"<EMAIL_ADDRESS>wrote:

Cool. That's great!
On 22 Sep 2017 04:47, "Will Brennan"<EMAIL_ADDRESS>wrote:

Looks like it.
Issue with travis CI was using sudo apt-get install -y python-opencv and
how it couldn't be accessed within the virtualenv that travis uses.
Swapping to pip install opencv-python fixed the issue.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/WillBrennan/SkinDetector/pull/9#issuecomment-331307296,
or mute the thread
https://github.com/notifications/unsubscribe-auth/APxqUoSROylWdTaUWhP11OSoTuSFhaTnks5sku5vgaJpZM4Pf1vb
.


How to prepare dataset? Using from dgl?

Hello, how to prepare dataset, need your help! Thanks so much!

Please check the code here get dataset.
And README has explained the dataset format of adj.npz and labels.npy, etc. All these data should be placed under one datafolder, which will be taken by --dataset argument.
Since I don't know what your dataset looks like, you need to convert your dataset into the above format.

您好，请问是需要先下载好reddit数据集再运行dgl2pagraph吗？
明明是你先靠近我的阿
@.***

------------------ 原始邮件 ------------------
发件人:                                                                                "zhiqi-0/PaGraph"                                                                                @.>;
发送时间: 2022年11月11日(星期五) 中午11:18
@.>;
<EMAIL_ADDRESS>主题: Re: [zhiqi-0/PaGraph] How to prepare dataset? Using from dgl? (Issue #2)
Please check the code here get dataset.
And README has explained the dataset format of adj.npz and labels.npy, etc. All these data should be placed under one datafolder, which will be taken by --dataset argument.
Since I don't know what your dataset looks like, you need to convert your dataset into the above format.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>

您好，有两个问题希望您可以解答一下：
问题1：我刚刚是下载了dgl的reddit数据集，然后运行了dgl2pagraph.py这样数据集就算准备完毕了吧，不过我看您的数据集用的是reddit_self_loop，dgl好像有提供下载这个数据集的接口吗。
问题2：您的partition哪个文件是实现了您论文中基于采样的图分区方法呢？
明明是你先靠近我的阿
@.***

------------------ 原始邮件 ------------------
发件人:                                                                                "zhiqi-0/PaGraph"                                                                                @.>;
发送时间: 2022年11月11日(星期五) 中午11:18
@.>;
<EMAIL_ADDRESS>主题: Re: [zhiqi-0/PaGraph] How to prepare dataset? Using from dgl? (Issue #2)
Please check the code here get dataset.
And README has explained the dataset format of adj.npz and labels.npy, etc. All these data should be placed under one datafolder, which will be taken by --dataset argument.
Since I don't know what your dataset looks like, you need to convert your dataset into the above format.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>

To your Q1: Yes, it should be ok. For reddit_self_loop, I'm not sure whether DGL currently still supports downloading Reddit-self dataset, you could double check the tutorials and see how they train models with given datasets.
To your Q2: Please checkout code in DG

To your Q1: Yes, it should be ok. For reddit_self_loop, I'm not sure whether DGL currently still supports downloading Reddit-self dataset, you could double check the tutorials and see how they train models with given datasets.
To your Q2: Please checkout code in DG

I find that dg.py has a small bug using args.num_hop, but actually args passed in it is args.num_hops,
And can we talk on QQ or wetchat to save time, I am really interested on your excellent work and want to learn more since I am a new learner, my qq is<PHONE_NUMBER> or wechat<PHONE_NUMBER>8, both are OK, I think we can make progress together. Look forward to your reply!!!

Sorry, will find you the next month, I'm really busy these days. You can firstly try to read the code and figure out how it works.


about real world data？

thanks for your great work!!
also i have some questions below:
1、 I want to use the 3d Diffuser actor on an actual robotic arm, but I'm not clear enough on how to collect real data. Can you provide some scripts or instructions?
2、Can the real world dataset be open sourced?
3、Does predicting the frequency of keyposes determine whether an outward movement planner is needed? For example, if the intervals between predicted keyposes are small and the relative changes are small, is there no need for this additional planner? and How to decide if one need a planner？
4、what does the following sentence mean? what's the corresponding trajectory?

Once again I would like to express my gratitude and look forward to your reply!

Thanks for your interest!  Setting up real-world experiments in fact requires quite some efforts!  In our lab, we use Franka Emika robot to collect and present real-world manipulation demos.

See this repo for setting up Franka robot.  We recorded only the keyposes for our real-world experiments.  For example, for "put duck in plate", the keyposes are the following: gripper on top of duck, gripper has grasped duck, gripper on top of the plate, gripper lowers down and releases. See our paper (appendix) for more details.
We can provide our collected real-world demos.  However, you still need to set up the real-world robot to test/present manipulation in the real world.  For reference, our robot/scene setup can be seen in our paper and the videos on our website. Since real-robot setups are probably different per lab, our real-world training data would possibly be useful for reference only.
Yes, you're right.  If the relative change between neighboring keyposes is small, you don't need a motion planner.  Conceptually, let K1 and K2 be two neighboring keyposes, and we need to find a path to reach K2 from K1.  If these two poses are close,  you can reach the target pose via a straight line, otherwise, you need to deploy a motion planner or learn a policy to predict the intermediate path.
Following 3., our 3D Diffuser Actor can predict both K2 and the intermediate path.  We predict K2 only for RLBench and use the RRT planner to connect keyposes. We predict both K2 and the trajectory up to K2 for CALVIN.

@twke18 Thank you for your detailed reply！
The current situation is that I probably don’t have the same model of robotic arm as the one in the paper. In this case, I should be able to refer to the paper for actual data collection, right?

Hi @lunalulu, although we do not name the semantics of each keypose, we do provide the number of keyposes per task in our appendix. Based on the "put duck in plate" example, you could infer the logic behind real-world data collection. If you have doubts about a specific task or need some more advice, don't hesitate to ask us.
Good luck! Let us know how 3D Diffuser Actor performs on your setup!


Bazel Support for Kotlin-->Wasm Compilation

Now we can support compiling Koltin code into Wasm in Bazel build files.
Here's an example build file to demonstrate how this new rule works:
load("//build_defs/kotlin-native:build_defs.bzl", "kt_wasm_binary", "kt_wasm_library")

kt_wasm_binary(
    name = "binary_test",
    srcs = ["alone.kt"],
    deps = []
)

kt_wasm_library(
    name = "cat",
    srcs = ["cat.kt"],
    deps = []
)

kt_wasm_binary(
    name = "hello",
    srcs = ["hello.kt"],
    deps = [":cat"]
)

Tested, fixed a bug, and it works in the transitive case.


Add PostgreSQL certificate support

May be it's not so good implementation, but it works (tests are missed)

thanks @nikicat! I'll happily merge - just one small fix to consider :)

Ok, @rickbergfalk-uptycs, I'll fix it

@nikicat I'm doing some refactoring with the way the connections UI is done... merging this into my dev branch so we don't lose out on your work :)


#47 Added missing required origin for addAnnotation call

Issue
After in #48 PR I added usage of the actual TextAnnotatorStore - the store.addAnnotation within the SelectionHandler started to fail. That's because the store defines the origin as a mandatory argument:
https://github.com/recogito/text-annotator-js/blob/3f587dd752084f3f6c291dec0577e01afb2d1e4d/packages/text-annotator/src/state/TextAnnotationStore.ts#L8

Ah - good catch! But the wrong fix ;-) Origin shouldn't be required. I.e. it's actually the Store type that should be fixed.
addAnnotation(annotation: TextAnnotation, origin?: Origin): boolean;

Feel free to either make the change, or close the PR & I can make it.

No problem, I can add the change to the store 👌🏻
Thanks for the update


Adding support for loading authConfig from dockers config

My Java fu is a bit outdated, but this should get the job done.
Thanks

Any feedback on this?

@brujoand Sorry for the delayed response. I just merged https://github.com/spotify/docker-client/pull/261 but haven't gotten a chance to see go over how yours differs from that one yet.

Overall LGTM, but what happens if there are multiple servers in the auths element of ~/.docker/config.json? Seems like only the first one is used. It might be best to attempt to match it up with a user-supplied URL.

Oh and thank you for adding tests with your change :wink:

Thanks for the feedback, I've cleaned up some of this on the branch we use at work. I'll push the changes when I get in tomorrow! :)

I moved this to #266
So I'll just close this one


Installation Probelm

I am trying to install statussfy on VPS server i have installed but i don't know how to access admin panel or everything

Hello @arkhalid1986. For questions, please go to https://spectrum.chat/bazzite/statusfy.


Update Pytorch and noisy devices demo in preparation for 0.27

Note, we should revisit whether the following makes sense to run on a computer that does not have a GPU:
phi = Variable(torch.tensor(1.0, device="cuda"), requires_grad=True)
theta = Variable(torch.tensor(0.05, device="cuda"), requires_grad=True)

I get an error on my laptop.

Note, we should revisit whether the following makes sense to run on a computer that does not have a GPU:
phi = Variable(torch.tensor(1.0, device="cuda"), requires_grad=True)
theta = Variable(torch.tensor(0.05, device="cuda"), requires_grad=True)

I get an error on my laptop.

Were you able to run it elsewhere?

Note this is a really old demo, written around PL ~0.3 when we only had 5 or so demos. The purpose was to show that hybrid GPU-QPU computing is possible with PennyLane

So less about wanting users to use a GPU specifically, and more about having at least one demo to show how to do it/that it is possible


Docker hub versions make no sense

Hey JWilder, really appreciate the work you've done. I like to version my companies images they are using, so I tried to look into the history of your project here.
The dates and numbers make no sense you have a latest tag which doesn't correspond in size to any other version (it should be corresponding to something else). And you have a version 0.3.0 made 3 days ago and a version 0.3.6 made 10 months ago.
Could you follow, maybe semantic versioning? Just increase the last digit every commit you push - it would be awesome :-D
(this came up because I couldn't get one of your new versions to work, I'll file a different but for that)
Again sorry to ask more of you. Thank you for your work.

I do use semantic versioning.  The images are built using docker hub's automated builds and I have no idea when it rebuilds them. The tags on the hub correspond to tags on this repo.  0.1.0 is built off of the 0.1.0 tag.  latest is just the HEAD on master.  0.3.6 was a tag corresponding to the version of docker-gen from a long time ago and I didn't realize it was still around.  I've removed that.  No idea what master is or how it got there, but I also removed that.
If you use latest, you running what ever is committed to master.  0.4.0 would be the latest stable version.  0.5.0 will be next.

Ok, thank you!


Auth guidance

Is there a recommend way of handling authorized URLs with Junctions?

Could you give me some more details as to what you mean by authorised URLs, and how you'd like to handle them?

Sure. I'm just thinking of URLs that require a login, such as /inbox. Is there a built-in way to handle that (like a way to pass a callback function) or is it just a matter of how one implements their Converters, Junctions, Locations, or Routes?
Ideally it would be a great addition to the Guide or Examples page.

I agree that it would be nice to have a guide for this.
There is no built in way to handle it, but it is definitely possible. Given the converter just converts a URL into a Route, you'll just need to look at the Route and decided whether the user is authenticated before rendering any content.

Thanks.


Data not updated after april 4

I checked the mobility reports. for India, the reports end on April 11.
Which might mean the data isn't going to be updated anymore, but would you please update up till then.

This has been updated till Apr 11th.


TypeError when calling account.declare from main branch

This occurs in main.  Does not occur in a release.
Running the command nile declare PKEY1 contract causes the following error:
🚀 Declaring contract
⏳ Successfully sent declaration of contract as 0x0f28592e02fb10ae73e235b5959bd18297efaa4333ded153bdbefc785a243ef
🧾 Transaction hash: 0x3209fb31d79a4e53d3fccdca9f23b60d89734ded57d479a194589aa084ac073
Traceback (most recent call last):
  File "/Users/eric/git/nileproj2/env/bin/nile", line 8, in <module>
    sys.exit(cli())
  File "/Users/eric/git/nileproj2/env/lib/python3.9/site-packages/click/core.py", line 1130, in __call__
    return self.main(*args, **kwargs)
  File "/Users/eric/git/nileproj2/env/lib/python3.9/site-packages/click/core.py", line 1055, in main
    rv = self.invoke(ctx)
  File "/Users/eric/git/nileproj2/env/lib/python3.9/site-packages/click/core.py", line 1657, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/Users/eric/git/nileproj2/env/lib/python3.9/site-packages/click/core.py", line 1404, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/Users/eric/git/nileproj2/env/lib/python3.9/site-packages/click/core.py", line 760, in invoke
    return __callback(*args, **kwargs)
  File "/Users/eric/git/nile/src/nile/cli.py", line 117, in declare
    account.declare(
  File "/Users/eric/git/nile/src/nile/core/account.py", line 116, in declare
    return declare(
  File "/Users/eric/git/nile/src/nile/core/declare.py", line 45, in declare
    deployments.register_class_hash(padded_hash, network, alias)
  File "/Users/eric/git/nile/src/nile/deployments.py", line 85, in register_class_hash
    hash = hex(hash)
TypeError: 'str' object cannot be interpreted as an integer

The same occurs from the following script using NRE:
from nile.core.account import Account

def run(nre):
    signer = "PKEY1"
    account = Account(signer, nre.network)
    account.declare("contract")

which causes error:
Traceback (most recent call last):
  File "/Users/eric/git/nileproj2/env/bin/nile", line 8, in <module>
    sys.exit(cli())
  File "/Users/eric/git/nileproj2/env/lib/python3.9/site-packages/click/core.py", line 1130, in __call__
    return self.main(*args, **kwargs)
  File "/Users/eric/git/nileproj2/env/lib/python3.9/site-packages/click/core.py", line 1055, in main
    rv = self.invoke(ctx)
  File "/Users/eric/git/nileproj2/env/lib/python3.9/site-packages/click/core.py", line 1657, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/Users/eric/git/nileproj2/env/lib/python3.9/site-packages/click/core.py", line 1404, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/Users/eric/git/nileproj2/env/lib/python3.9/site-packages/click/core.py", line 760, in invoke
    return __callback(*args, **kwargs)
  File "/Users/eric/git/nile/src/nile/cli.py", line 83, in run
    run_command(path, network)
  File "/Users/eric/git/nile/src/nile/core/run.py", line 14, in run
    script.run(nre)
  File "scripts/declare.py", line 7, in run
    account.declare("contract")
  File "/Users/eric/git/nile/src/nile/core/account.py", line 116, in declare
    return declare(
  File "/Users/eric/git/nile/src/nile/core/declare.py", line 45, in declare
    deployments.register_class_hash(padded_hash, network, alias)
  File "/Users/eric/git/nile/src/nile/deployments.py", line 85, in register_class_hash
    hash = hex(hash)
TypeError: 'str' object cannot be interpreted as an integer

We should also determine why the tests do not catch this.

Yes, the issue came from handling the class hash in declare and not removing the hex conversion in register_class_hash (#257). The issue should be fixed in main from the #122 merge.

We should also determine why the tests do not catch this.

I agree^. I propose more granular tests


Is support decorators ?

Hi team, package is support decorators.
Sometime, in my content have hashtag #abc , and i want to custom color it. How to ?
Thanks

Hi @thanhtungdp!
We don't support it yet. But we'll be happy to receive some help. 🙂
Thanks for your question.

@thanhtungdp, how did you solve this problem?

Are decorators supported now?


[Correction] Typo in definition of OSAPISystemFunction

In src/ontology/d3fend-protege.ttl, the definition of :OSAPISystemFunction reads:
Indirect System calls are made through OS-specific libraries (like glibc in Linux) that provides a higher-level API for the system calls.

The plurality of "libraries" and "provides" don't match.

merged

thank you!


🚀Added Gmplot

Description
Tracking the route of a person OR Tracking a specific path followed by a person

Gmplot Can be used to plot the coordinates on Google map .
These coordinates can be imported from a fixed CSV file that doesn't change  OR can be taken as input from user in Latitude and Longitude format .

Fixes #713
Have you read the Contributing Guidelines on Pull Requests?

[x] Yes
[ ] No

Type of change

[x] New feature (non-breaking change which adds functionality)

Checklist:

[x] My code follows the style guidelines(Clean Code) of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have created a helpful and easy to understand README.md
[x] My documentation follows Template for README.md
[x] My changes generate no new warnings
[x] I have added tests/screenshots(if any) that prove my fix is effective or that my feature works.

For any  modifications let me know .

I think now it looks fine , mentors please have a look

Code Works Properly
CSV file added / Clarification
Output Screenshot added in README

You have not done something new here: https://pypi.org/project/gmplot/. Only the coordinates loading is changed from zipping to pandas data frame. This being level2 issue needs modifications. Suggestions:

Add some more coordinates, Indian coordinates of around 100 places.
Here: gmplot.GoogleMapPlotter(37.771260, -122.511011,17), take input for zoom level and for central coordinates, take the average of all the coordinates for x and y separately.

Requested Changes are made

For now i haven't modified README screenshot , waiting for @kaustubhgupta sir to verify changes after that i will modify it.
Code works fine
100 Coordinates added
Average Taken in x and y
Zoom is taken as input

Also i could have added polygon just like in the link you mentioned but it would have been lot more cluttering with 100 coordinates

You have not done something new here: https://pypi.org/project/gmplot/. Only the coordinates loading is changed from zipping to pandas data frame. This being level2 issue needs modifications. Suggestions:

Add some more coordinates, Indian coordinates of around 100 places.
Here: gmplot.GoogleMapPlotter(37.771260, -122.511011,17), take input for zoom level and for central coordinates, take the average of all the coordinates for x and y separately.

Requested Changes are made

For now i haven't modified README screenshot , waiting for @kaustubhgupta sir to verify changes after that i will modify it.
Code works fine
100 Coordinates added
Average Taken in x and y
Zoom is taken as input

This looks good. You can make the changes in the PR

Updated README request a review from other members please if it is good to go.
For modifications let me know

@Kushal997-das


core script built in custom nodes should not be not visible in scene tree

that's a proposal.
Let's build a custom node: we do a custom class into a custom script. It is ok.
Let's put this custom node in the tree. Editor add custom node and its custom script. That's ok.
Let's add many of this custom nodes in the tree. Editor add all custom nodes in the tree, but associates each node to a single shared script. That should ok.
Let's custom scripts fpr one or two of those custom nodes, now troubles begin because custom script is shared between custom nodes.
After few days, we want to look at custom nodes we have customized: we face new troubles, because usually we look for script icon near node icons, but all custom nodes have one. We have to look inside scripts, one by one, and figure out wich one we have customized. That's no good.
I hope I explained what the point is.
ciao
Graziano

Duplicate of #6067 (or at least was discussed there).


Frustrations found along the way of building the dog app

The app: https://master--toolpad.mui.com/_toolpad/app/cl1c2j0l512939zo6a43575en/editor/pages/cl27gc98v00003f69ideijta5
I have prefixed each of the pain points under two different categories: UX vs. DX

UX (7): a generic notion, this is the kind of challenge that you would face working on a generic product, like Airbnb.
DX (6): similar to UX, but you would need to imagine yourself as a developer to resonate with the usability pain.

My notes:

[x] DX: Having to create a connection to make a fetch call seems a bit overkill. I get the use cases to be able to create REST connections, e.g. to add basic auth headers or to differentiate between the staging and production environment. Maybe it would make sense to have a generic REST connection that would always be available for usage. So that it's only once you face a specific need that you use it. It would have saved me one action. https://github.com/mui/mui-toolpad/issues/364

[x] UX: I have created an API and left the view but now I'm confused. My URL is not persisted? I need to click on the UPDATE button. The challenge is that we don't want to auto-save mistakes in the URL. I would suggest we have a dialog to confirm abandoning the changes when trying to leave. It will help build muscle and learn to save the changes. This caught me multiple times, it's painful.

[x] DX: Would it be possible to apply post transformations on my query states? I get that I can apply this transformation when I bind the value to a prop or a component, but I feel that I could save one context shifting. https://github.com/mui/mui-toolpad/issues/366

[x] UX: In the binding editor: It would be great for Cmd + S to save in the code editor views or the whole state #254.
[x] UX: When I'm on the "Create a new MUI Studio Code Component" popup, why is the input already filled with "MyComponent"? If we really want to have a default value, I think that we could have the default value selected so we can more quickly type something new.

[x] DX: I wish I had a debugger somewhere to see all my states. I have created a Debugger component to help me. But in the end, I didn't really used it.

import * as React from "react";
import type { ComponentConfig } from "@mui/toolpad-core";

export interface DebugProps {
  msg: string;
  debug: string;
}

export const config: ComponentConfig<DebugProps> = {
  argTypes: {
    msg: {
      typeDef: { type: "object" },
    },
    debug: {
      typeDef: { type: "string" },
    },
  },
};

export default function Debug({ debug = "Debug", msg }: DebugProps) {
  console.log(debug, msg);
  return (
    <div style={{ width: 400, backgroundColor: "red", color: "white" }}>
      Debug
    </div>
  );
}

[x] UX: When I bind a property, I wish I could get a live preview of the new value. Since I don't have this, I press the update binding multiple times. Not great.

I even wonder if on hover we shouldn't have a popup to show the content of the variable. So not the type, the value

[x] DX: I have caught myself forgetting to create a queryState multiple times. What could work better is to make what we current call "queryState" an "API" and what we currently call "API" a "Query library". https://github.com/mui/mui-toolpad/issues/365
[x] UX: Sometimes, I wish I could resize the right-side panel. https://github.com/mui/mui-toolpad/issues/496
[x] DX: I feel that the JSON type is painful to use. Would it make sense to have a JavaScript object syntax everywhere instead? My main issue is that JSON is less forgiving. You forget a quote, add one more quote and it fails to parse. https://github.com/mui/mui-toolpad/pull/495
[x] DX: In the "Bind a property" view, it would be interesting to know the nature of the global variable. Is it a component or an API state? It could help more quickly navigate what's available. We might even want to group them. https://github.com/mui/mui-toolpad/issues/497

[x] DX: I have to handle the case when the data is loading manually. I have disabled the select components. I also had to add defensive logic:

getImage?.data?.message

[x] UX: We could have a proper Image component, there is an issue about it on the Material UI repository, maybe to use it as a source of inspiration or even for contribution https://github.com/mui/material-ui/issues/22470

Going to sketch out a rough idea here that is forming around the loading/error states of components. The goal is to wire these up transparently to components that support such states, like the DataGrid

I think we could do the following:
create a marker in the component type definition that designates two special properties:

one boolean property that represents loading state for the component
one Error property that represents error state for the component

In the component properties editor it will be possible to wire up whatever logic to these manually in case users want to do their own logic.
For databinding
currently, from the code that evaluates binding expression, we already get a two-state as a result
type LiveBinding = { error: Error } | { value: any };

We will add an additional third state
type LiveBinding = { error: Error } | { value: any } | { loading: boolean };

We will then augment the page state that we feed into this evaluator with Proxies that will throw special markers if some property on the state of a datafetch accessed, while it's still loading. The binding evaluator can then catch these markers to know that any of the property accesses is still waiting for something to load. We can then mark the whole expression as loading. The marker will contain a promise that we can wire up for rerendering later on. From a user perspective it will be transparent.
The Toolpad runtime can then wire the result up to the right properties in the component. value will go to the property that has been bound, and loading and error will be filled into the properties designated by the component type definition. (currently all it does is wire up value and error is only used for debugging)
This way custom components will also be able to designate properties for loading and errors and seamlessly work with Toolpad databinding and datafetching

All issues are either fixed or scoped down to individual github issues


Is there a way to play audio from the middle of the file?

Question
I am developing my minecraft mod and I want to play sound at the middle of the file. Can i set the progress of the audio? for example, I want to play the sound from 00:10 of the audio file?

Thanks for your concern. I have solved the problem after reading an 12-year-ago resource (https://stackoverflow.com/questions/4015051/openal-on-mac-os-x-setting-al-sample-offset-does-nothing) now my mod can run smoothly. But it is really unbelievable that how few that the openAL has changed in these years.


bump dependencies

Applied mkpr on package.json
/tmp/mkpr.sh

:tada: This PR is included in version 1.10.140 :tada:
The release is available on:

npm package (@latest dist-tag)
v1.10.140
GitHub release

Your semantic-release bot :package::rocket:


fix: Corrected typo

@abacus-x please fix the merge conflicts

Thanks @StanislavBreadless - the conflicts are have been merged

:tada: This PR is included in version 2.4.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Documentation Suggestion

Is there a way that you can update the README.rst on Github to include a windows install section?
If you could it would remove some confusion with runtime errors on the windows platform.
Things that would be nice if they were added there:

Software Prerequisites (Python 3.6 for windows and Microsoft C++ Redistributable 2013) ** This is For Windows 7 64bit Don't know if windows 10 has different requirements
Add links to these resources to make it much easier for more basic users to find the correct files.

Seperate form the windows related items can you add in the README.rst the --password cli argument? Until i dug around i didn't even know it existed.
Thanks again for a excellent program.

(related to #88, where I listed the issues I noticed about our documentation)
Thanks for these suggestions! We are working on improving the documentation for the upcoming Instaloader-v4, where it is really helpful to get some feedback by readers.
Some comments:

We discourage from using --password, which is why we nowhere promote it. When it is used, the password becomes part of the command line and is visible a) in the command prompt and b) (much worse) in top or ps (programs similar to the Windows Task Manager) where all running applications with their command line and resource usage are listed. The latter makes it very insecure on (at least) Linux, where on a computer that is used by multiple users everyone can see the other users' application with their command line and hence the password. The preferred way is instaloader --login USERNAME [--sessionfile SESSIONFILE] to create and reuse a session file, which is per default stored in a secure place with rightly set file permissions.
The README.rst on Github is merely a short introduction to what Instaloader is, mainly listing its features and giving a brief usage introduction, to attract people if they see it may help solve their problem. We consider https://instaloader.github.io/ as the main entry point, where we have a better control about the contents, how they are presented and internally linked. However, that site certainly needs some rework, too. Nevertheless, we probably should extend the installation section in README.rst or at least guide the reader to our installation section in our documentation.


500 internal server error when using emoji in issue

Description
Exactly this issue. I would like to know how to fix an existing install. Even after correcting the default character set and collation the existing tables and columns have an incorrect character set+collation, so what columns should be updated to use the utf8mb4 character set?
Screenshots
MariaDB [(none)]> select table_name, column_name, character_set_name, collation_name from information_schema.columns where table_schema = 'gitea' and (character_set_name is not null or collation_name is not null);
+---------------------------+--------------------------------+--------------------+--------------------+
| table_name                | column_name                    | character_set_name | collation_name     |
+---------------------------+--------------------------------+--------------------+--------------------+
| milestone                 | name                           | utf8               | utf8_general_ci    |
| milestone                 | content                        | utf8               | utf8_general_ci    |
| two_factor                | secret                         | utf8               | utf8_general_ci    |
| two_factor                | scratch_salt                   | utf8               | utf8_general_ci    |
| two_factor                | scratch_hash                   | utf8               | utf8_general_ci    |
| two_factor                | last_used_passcode             | utf8               | utf8_general_ci    |
| issue                     | name                           | utf8               | utf8_general_ci    |
| issue                     | content                        | utf8               | utf8_general_ci    |
| issue                     | ref                            | utf8               | utf8_general_ci    |
| issue                     | original_author                | utf8               | utf8_general_ci    |
| repo_unit                 | config                         | utf8               | utf8_general_ci    |
| access_token              | name                           | utf8               | utf8_general_ci    |
| access_token              | token_hash                     | utf8               | utf8_general_ci    |
| access_token              | token_salt                     | utf8               | utf8_general_ci    |
| access_token              | token_last_eight               | utf8               | utf8_general_ci    |
| commit_status             | state                          | utf8               | utf8_general_ci    |
| commit_status             | sha                            | utf8               | utf8_general_ci    |
| commit_status             | target_url                     | utf8               | utf8_general_ci    |
| commit_status             | description                    | utf8               | utf8_general_ci    |
| commit_status             | context_hash                   | utf8               | utf8_general_ci    |
| commit_status             | context                        | utf8               | utf8_general_ci    |
| notification              | commit_id                      | utf8               | utf8_general_ci    |
| action                    | ref_name                       | utf8               | utf8_general_ci    |
| action                    | content                        | utf8               | utf8_general_ci    |
| release                   | tag_name                       | utf8               | utf8_general_ci    |
| release                   | lower_tag_name                 | utf8               | utf8_general_ci    |
| release                   | target                         | utf8               | utf8_general_ci    |
| release                   | title                          | utf8               | utf8_general_ci    |
| release                   | sha1                           | utf8               | utf8_general_ci    |
| release                   | note                           | utf8               | utf8_general_ci    |
| release                   | original_author                | utf8               | utf8_general_ci    |
| public_key                | name                           | utf8               | utf8_general_ci    |
| public_key                | fingerprint                    | utf8               | utf8_general_ci    |
| public_key                | content                        | utf8               | utf8_general_ci    |
| webhook                   | url                            | utf8               | utf8_general_ci    |
| webhook                   | signature                      | utf8               | utf8_general_ci    |
| webhook                   | http_method                    | utf8               | utf8_general_ci    |
| webhook                   | secret                         | utf8               | utf8_general_ci    |
| webhook                   | events                         | utf8               | utf8_general_ci    |
| webhook                   | meta                           | utf8               | utf8_general_ci    |
| project_board             | title                          | utf8mb4            | utf8mb4_general_ci |
| gpg_key_import            | key_id                         | utf8               | utf8_general_ci    |
| gpg_key_import            | content                        | utf8               | utf8_general_ci    |
| hook_task                 | uuid                           | utf8               | utf8_general_ci    |
| hook_task                 | url                            | utf8               | utf8_general_ci    |
| hook_task                 | signature                      | utf8               | utf8_general_ci    |
| hook_task                 | payload_content                | utf8               | utf8_general_ci    |
| hook_task                 | http_method                    | utf8               | utf8_general_ci    |
| hook_task                 | event_type                     | utf8               | utf8_general_ci    |
| hook_task                 | request_content                | utf8               | utf8_general_ci    |
| hook_task                 | response_content               | utf8               | utf8_general_ci    |
| pull_request              | conflicted_files               | utf8               | utf8_general_ci    |
| pull_request              | head_branch                    | utf8               | utf8_general_ci    |
| pull_request              | base_branch                    | utf8               | utf8_general_ci    |
| pull_request              | merge_base                     | utf8               | utf8_general_ci    |
| pull_request              | merged_commit_id               | utf8               | utf8_general_ci    |
| pull_request              | changed_protected_files        | utf8               | utf8_general_ci    |
| gpg_key                   | key_id                         | utf8               | utf8_general_ci    |
| gpg_key                   | primary_key_id                 | utf8               | utf8_general_ci    |
| gpg_key                   | content                        | utf8               | utf8_general_ci    |
| gpg_key                   | emails                         | utf8               | utf8_general_ci    |
| email_address             | email                          | utf8               | utf8_general_ci    |
| oauth2_authorization_code | code                           | utf8               | utf8_general_ci    |
| oauth2_authorization_code | code_challenge                 | utf8               | utf8_general_ci    |
| oauth2_authorization_code | code_challenge_method          | utf8               | utf8_general_ci    |
| oauth2_authorization_code | redirect_uri                   | utf8               | utf8_general_ci    |
| language_stat             | commit_id                      | utf8               | utf8_general_ci    |
| language_stat             | language                       | utf8               | utf8_general_ci    |
| lfs_meta_object           | oid                            | utf8               | utf8_general_ci    |
| comment                   | old_title                      | utf8               | utf8_general_ci    |
| comment                   | new_title                      | utf8               | utf8_general_ci    |
| comment                   | tree_path                      | utf8               | utf8_general_ci    |
| comment                   | content                        | utf8               | utf8_general_ci    |
| comment                   | patch                          | utf8               | utf8_general_ci    |
| comment                   | commit_sha                     | utf8               | utf8_general_ci    |
| comment                   | original_author                | utf8               | utf8_general_ci    |
| comment                   | old_ref                        | utf8               | utf8_general_ci    |
| comment                   | new_ref                        | utf8               | utf8_general_ci    |
| external_login_user       | external_id                    | utf8               | utf8_general_ci    |
| external_login_user       | raw_data                       | utf8               | utf8_general_ci    |
| external_login_user       | provider                       | utf8               | utf8_general_ci    |
| external_login_user       | email                          | utf8               | utf8_general_ci    |
| external_login_user       | name                           | utf8               | utf8_general_ci    |
| external_login_user       | first_name                     | utf8               | utf8_general_ci    |
| external_login_user       | last_name                      | utf8               | utf8_general_ci    |
| external_login_user       | nick_name                      | utf8               | utf8_general_ci    |
| external_login_user       | description                    | utf8               | utf8_general_ci    |
| external_login_user       | avatar_url                     | utf8               | utf8_general_ci    |
| external_login_user       | location                       | utf8               | utf8_general_ci    |
| external_login_user       | access_token                   | utf8               | utf8_general_ci    |
| external_login_user       | access_token_secret            | utf8               | utf8_general_ci    |
| external_login_user       | refresh_token                  | utf8               | utf8_general_ci    |
| repository                | lower_name                     | utf8               | utf8_general_ci    |
| repository                | name                           | utf8               | utf8_general_ci    |
| repository                | description                    | utf8               | utf8_general_ci    |
| repository                | website                        | utf8               | utf8_general_ci    |
| repository                | default_branch                 | utf8               | utf8_general_ci    |
| repository                | topics                         | utf8               | utf8_general_ci    |
| repository                | avatar                         | utf8               | utf8_general_ci    |
| repository                | original_url                   | utf8               | utf8_general_ci    |
| repository                | owner_name                     | utf8               | utf8_general_ci    |
| repo_indexer_status       | commit_sha                     | utf8               | utf8_general_ci    |
| email_hash                | hash                           | utf8               | utf8_general_ci    |
| email_hash                | email                          | utf8               | utf8_general_ci    |
| attachment                | uuid                           | utf8               | utf8_general_ci    |
| attachment                | name                           | utf8               | utf8_general_ci    |
| oauth2_application        | name                           | utf8               | utf8_general_ci    |
| oauth2_application        | client_id                      | utf8               | utf8_general_ci    |
| oauth2_application        | client_secret                  | utf8               | utf8_general_ci    |
| oauth2_application        | redirect_uris                  | utf8               | utf8_general_ci    |
| review                    | content                        | utf8               | utf8_general_ci    |
| review                    | commit_id                      | utf8               | utf8_general_ci    |
| review                    | original_author                | utf8               | utf8_general_ci    |
| u2f_registration          | name                           | utf8               | utf8_general_ci    |
| notice                    | description                    | utf8               | utf8_general_ci    |
| lfs_lock                  | path                           | utf8               | utf8_general_ci    |
| project                   | title                          | utf8mb4            | utf8mb4_general_ci |
| project                   | description                    | utf8mb4            | utf8mb4_general_ci |
| topic                     | name                           | utf8mb4            | utf8mb4_general_ci |
| protected_branch          | branch_name                    | utf8               | utf8_general_ci    |
| protected_branch          | whitelist_user_i_ds            | utf8               | utf8_general_ci    |
| protected_branch          | whitelist_team_i_ds            | utf8               | utf8_general_ci    |
| protected_branch          | merge_whitelist_user_i_ds      | utf8               | utf8_general_ci    |
| protected_branch          | merge_whitelist_team_i_ds      | utf8               | utf8_general_ci    |
| protected_branch          | approvals_whitelist_user_i_ds  | utf8               | utf8_general_ci    |
| protected_branch          | approvals_whitelist_team_i_ds  | utf8               | utf8_general_ci    |
| protected_branch          | status_check_contexts          | utf8               | utf8_general_ci    |
| protected_branch          | protected_file_patterns        | utf8               | utf8_general_ci    |
| user                      | lower_name                     | utf8               | utf8_general_ci    |
| user                      | name                           | utf8               | utf8_general_ci    |
| user                      | full_name                      | utf8               | utf8_general_ci    |
| user                      | email                          | utf8               | utf8_general_ci    |
| user                      | passwd                         | utf8               | utf8_general_ci    |
| user                      | login_name                     | utf8               | utf8_general_ci    |
| user                      | location                       | utf8               | utf8_general_ci    |
| user                      | website                        | utf8               | utf8_general_ci    |
| user                      | rands                          | utf8               | utf8_general_ci    |
| user                      | salt                           | utf8               | utf8_general_ci    |
| user                      | language                       | utf8               | utf8_general_ci    |
| user                      | description                    | utf8               | utf8_general_ci    |
| user                      | avatar                         | utf8               | utf8_general_ci    |
| user                      | avatar_email                   | utf8               | utf8_general_ci    |
| user                      | diff_view_style                | utf8               | utf8_general_ci    |
| user                      | theme                          | utf8               | utf8_general_ci    |
| user                      | email_notifications_preference | utf8               | utf8_general_ci    |
| user                      | passwd_hash_algo               | utf8               | utf8_general_ci    |
| team                      | lower_name                     | utf8               | utf8_general_ci    |
| team                      | name                           | utf8               | utf8_general_ci    |
| team                      | description                    | utf8               | utf8_general_ci    |
| deleted_branch            | name                           | utf8               | utf8_general_ci    |
| deleted_branch            | commit                         | utf8               | utf8_general_ci    |
| task                      | payload_content                | utf8               | utf8_general_ci    |
| task                      | errors                         | utf8               | utf8_general_ci    |
| oauth2_session            | id                             | utf8               | utf8_general_ci    |
| oauth2_session            | data                           | utf8               | utf8_general_ci    |
| repo_redirect             | lower_name                     | utf8               | utf8_general_ci    |
| deploy_key                | name                           | utf8               | utf8_general_ci    |
| deploy_key                | fingerprint                    | utf8               | utf8_general_ci    |
| login_source              | name                           | utf8               | utf8_general_ci    |
| login_source              | cfg                            | utf8               | utf8_general_ci    |
| user_open_id              | uri                            | utf8               | utf8_general_ci    |
| upload                    | uuid                           | utf8               | utf8_general_ci    |
| upload                    | name                           | utf8               | utf8_general_ci    |
| label                     | name                           | utf8               | utf8_general_ci    |
| label                     | description                    | utf8               | utf8_general_ci    |
| label                     | color                          | utf8               | utf8_general_ci    |
| reaction                  | type                           | utf8               | utf8_general_ci    |
| reaction                  | original_author                | utf8               | utf8_general_ci    |
+---------------------------+--------------------------------+--------------------+--------------------+
168 rows in set (0.001 sec)

There is the convert command, and also make sure your database config has CHARSET set to utf8mb4

Wonderful! Thank you @jolheiser :tada:


UUID behaviours

Hello. Sorry for bothering you. I'm trying to find a mootensai enhance gii documentation. As I can't find it, i have to ask you: I'm designing a table and I want use UUID generator using enhancement gii. What is the size of the id column and it's type? I think I can use varchar 20. I tried use int and had som troubles. I'm using MySQL.
Another question: when the table has related tables, the enhanced gii creates a modular form as (I think, a way of make things easier). If I comment the tabular form code and update the data on the main table, all related data is deleted. Can I avoid it even commenting the modular form code?
Thanks. You make my job easier and faster.

Hi,
I use char(32) for my UUIDs and it works fine.
Take a look at line 88
https://github.com/mootensai/yii2-relation-trait/blob/master/RelationTrait.php
For the saveAll function you can specify an array of related tables, that
should be skipped, thus data will not be deleted by a missing form.
Best
Christoph
On 5 May 2017 at 23:40, ednotorres<EMAIL_ADDRESS>wrote:

Hello. Sorry for bothering you. I'm trying to find a mootensai enhance gii
documentation. As I can't find it, i have to ask you: I'm designing a table
and I want use UUID generator using enhancement gii. What is the size of
the id column and it's type? I think I can use varchar 20. I tried use int
and had som troubles. I'm using MySQL.
Another question: when the table has related tables, the enhanced gii
creates a modular form as (I think, a way of make things easier). If I
comment the tabular form code and update the data on the main table, all
related data is deleted. Can I avoid it even commenting the modular form
code?
Thanks. You make my job easier and faster.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/mootensai/yii2-enhanced-gii/issues/105, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AQPCR-Wim2SfnWAQieMJZxLi1cdMgQksks5r25djgaJpZM4NSdDD
.

Thank you. I'll do that and feedback.

Hi again. Feeding back: I'm getting crazy with skippedRelation.
I can't find any example of using it and have tried set the parameter with the following values: 'tcr_contato', 'tcr-contato', 'TcrContato'.
It's clear that the child table is tcr_contato. I did set the parameter with the database relation name, like: fk_tcr_contato_tcr_pessoa.
Can anyone help me?
Thanks.
:)

Hi, your model's attributes should be uncapitalized. In camel case your
attribute for the table name should be 'tcrContato', if you got a 1:n
relationship going on, use plural: 'tcrContatos'.
To be sure, check your (base) model generated by gii. It should show up as:

@property \frontend\models\TaskEvent[] $taskEvents
(in this case the table name is "task_event")

Best
Christoph
On 22 May 2017 at 23:44, ednotorres<EMAIL_ADDRESS>wrote:

Hi again. Feeding back: I'm getting crazy with skippedRelation.
I can't find any example of using it and have tried set the parameter with
the following values: 'tcr_contato', 'tcr-contato', 'TcrContato'.
It's clear that the child table is tcr_contato. I did set the parameter
with the database relation name, like: fk_tcr_contato_tcr_pessoa.
Can anyone help me?
Thanks.
:)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/mootensai/yii2-enhanced-gii/issues/105#issuecomment-303228386,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AQPCRz5DHHAQtYGQNxDDNiLrJycqxh-Vks5r8gGygaJpZM4NSdDD
.

Thanks' for everything.
It's working nice now.


Make fields on pallet_democracy's types public.

This relaxes fields on several data types in pallet_democracy from pub(crate) to  just pub.
Currently these types are already pub, and there are even pub accessor methods on the storage items that store them (eg. fn referendum_info https://github.com/paritytech/substrate/blob/master/frame/democracy/src/lib.rs#L419).
But the data they return isn't useful because the fields are all private. My concrete use is writing an evm precompile that wraps this pallet's functionality.

Do I need to do anything about the CI here?

gitlab unleach check is temporary always red until in master.
gitlab node bench regression guard I don't know but it must not be caused by this PR

bot merge

bot merge force

@JoshOrndorff can you please merge master


adds missing connect method from MultiEdge

Example doesn't work without the connect method being overwritten to take into account the directed flow attributes of MultiEdge.
Example error
Traceback (most recent call last):
File "./commodity_flow.py", line 70, in
edges[-1].connect(nodes[n1], nodes[n2])
File "/home/jwgwalton/Documents/ConvexOptimisation/examples/cvxpy_graph_examples/max_flow.py", line 15, in connect
in_node.edge_flows.append(-self.flow)
AttributeError: 'MultiEdge' object has no attribute 'flow'

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Coverage remained the same at 89.344% when pulling 96f301a954980761cc6b7a1674fd77c785a36077 on jwgwalton:commodity_flow_fix into 8059cc9c643ae3d5dd1ec91b9f76f476ad024c6e on cvxgrp:master.

Coverage remained the same at 89.344% when pulling 96f301a954980761cc6b7a1674fd77c785a36077 on jwgwalton:commodity_flow_fix into 8059cc9c643ae3d5dd1ec91b9f76f476ad024c6e on cvxgrp:master.

Looks good! Thanks for fixing this.


Links reference SQL Database but article makes no mention

[Enter feedback here]
The bulleted list of links for setting up Private Link or Private Service for Azure SQL seem to refer to articles that do not mention SQL Database.  Suggestion would be to change the links to refer to the targeted resource of Azure App Service.  Kind regards.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b006a616-2f2f-8ecf-8b80-fd0a3cc62090
Version Independent ID: 92c54dc6-8ddf-b1f7-4a58-d61b8cd7fe25
Content: What is an Azure Private Endpoint?
Content Source: articles/private-link/private-endpoint-overview.md
Service: private-link
GitHub Login: @malopMSFT
Microsoft Alias: allensu

@southerncoder Thanks for the feedback! We are currently investigating and will update you shortly.

@southerncoder Thanks for the feedback! I have updated the links, and the docs should reflect the change within 24 hours.
We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.

Looks better now, cheers!


Feature to compare two JSON strings?

Summary
Does assertj have function to compare if two JSON strings are equal? By equal, I mean the key-value mapping are the same but the order might be different. I found project like https://github.com/skyscreamer/JSONassert provides such functionalities. Does assertj already have something like this?
If not, are contributions like introducing JSONassert as dependency and add new assert methods so that assertThat(jsonA).isSameJsonAs(jsonB)
Example
assertThat("{a : {a : 2}, b : 2}").isSameJsonAs("{b : 2, a : {a : 2}}"); // pass

nope we recpmmand JSONAssert or https://github.com/lukas-krecan/JsonUnit

JsonUnit also have AssertJ support https://github.com/lukas-krecan/JsonUnit#assertj-integration. So it is a really good fit for AssertJ users.


Fix interpreter cache collisions for relative virtualenv paths

Closes #3784
The cache did not use an absolute path. I'm not sure this is actually a new bug, as this code wasn't touched in #3266 but perhaps there was a slight difference in the paths we were passing around. Note, just canonicalizing the path as soon as we see it doesn't work because then we jump out of the virtual environmnent into the system interpreter.
Test plan
❯ uv venv
Using Python 3.12.3 interpreter at<EMAIL_ADDRESS>Creating virtualenv at: .venv
Activate with: source .venv/bin/activate
❯ uv pip install anyio
Resolved 3 packages in 81ms
Installed 3 packages in 4ms
 + anyio==4.3.0
 + idna==3.7
 + sniffio==1.3.1
❯ mkdir uv-issue-3784 && cd uv-issue-3784
❯ uv venv
Using Python 3.12.3 interpreter at<EMAIL_ADDRESS>Creating virtualenv at: .venv
Activate with: source .venv/bin/activate

❯ gcm
Switched to branch 'main'
Your branch is up to date with 'origin/main'.
❯ cargo run -q -- pip list -v -p .venv
DEBUG Checking for Python interpreter in directory `.venv`
TRACE Cached interpreter info for Python 3.12.3, skipping probing: .venv/bin/python3
DEBUG Using Python 3.12.3 environment at .venv/bin/python3
Package Version
------- -------
anyio   4.3.0
idna    3.7
sniffio 1.3.1
❯ cd uv-issue-3784
❯ cargo run -q -- pip list -v -p .venv
DEBUG Checking for Python interpreter in directory `.venv`
TRACE Cached interpreter info for Python 3.12.3, skipping probing: .venv/bin/python3
DEBUG Using Python 3.12.3 environment at /Users/zb/workspace/uv/.venv/bin/python3
Package Version
------- -------
anyio   4.3.0
idna    3.7
sniffio 1.3.1

❯ cd ..
❯ gco zb/fix-relative-venv
Switched to branch 'zb/fix-relative-venv'
❯ cargo run -q -- pip list -v -p .venv
DEBUG Checking for Python interpreter in directory `.venv`
TRACE Cached interpreter info for Python 3.12.3, skipping probing: .venv/bin/python3
DEBUG Using Python 3.12.3 environment at .venv/bin/python3
Package Version
------- -------
anyio   4.3.0
idna    3.7
sniffio 1.3.1
❯ cd uv-issue-3784
❯ cargo run -q -- pip list -v -p .venv
DEBUG Checking for Python interpreter in directory `.venv`
TRACE Cached interpreter info for Python 3.12.3, skipping probing: .venv/bin/python3
DEBUG Using Python 3.12.3 environment at .venv/bin/python3

Hi
Should we still apply the suggestion mentioned
https://github.com/astral-sh/uv/issues/3784#issuecomment-2129554631
We still get the same issue with 0.2.4


Sid translation

Added additional error handling to ConvertTo-Sid helper function

This change is

Review status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @jcwalker)

DSCResources/SecurityPolicyResourceHelper/SecurityPolicyResourceHelper.psm1, line 402 at r1 (raw file):

[System.String]

Might want to make the data type the same for both string parameters in this function

Comments from Reviewable

@jcwalker Can you write 'done' on the review comment so that @regedit32 can sign off (resolve his comment) on this?

Reviewed 2 of 4 files at r1, 2 of 2 files at r2.
Review status: all files reviewed, 1 unresolved discussion (waiting on @jcwalker)

Comments from Reviewable

Review status: :shipit: complete! all files reviewed, all discussions resolved

Comments from Reviewable


Line color doesn't update when negative/positive values change

How to reproduce
    CartesianChartHost(
        chart = rememberCartesianChart(
            rememberLineCartesianLayer(
                lineProvider = LineCartesianLayer.LineProvider.series(
                    rememberLine(
                        shader = TopBottomShader(
                            topShader = DynamicShader.color(MaterialTheme.colorScheme.primary),
                            bottomShader = DynamicShader.color(MaterialTheme.customColors.negative)
                        )
                    )
                )
            ),
        modelProducer = graphModelProducer,
        scrollState = rememberVicoScrollState(scrollEnabled = false)
    )

Observed behavior
Initial colors are good. However when the data refreshes the line seems to remember previous splitY value and doesn't update. The background color is updating though.

Expected behavior
All was working on alpha.22. The line color respected splitY = 0
Vico version(s)
2.0.0-alpha.24
Android version(s)
Any
Additional information
No response

Hello, and thanks for the report! We’re working on changes that will fix both this and the problem reported in issue #784.
The unexpected DefaultCartesianMarker label color is a direct result of the bug at hand. Regarding no Component being drawn on the line, this is expected—the default indicator value is (and always has been) null. You can add an indicator by passing a lambda that returns a Component. Here’s a simple example:
rememberDefaultCartesianMarker(
  label = rememberTextComponent(),
  indicator = remember { { shapeComponent(it, Shape.Pill) } },
)

We plan on introducing non-null defaults for indicator and guideline.

Vico 2.0.0 Alpha 26 resolves this. Cheers!

Just checked the alpha26, it's better but there are still same issues present. Now for zero values the line is split and for mixed negative/positive the marker color returns negative color for positive values in some cases.
chart = rememberCartesianChart(
            rememberLineCartesianLayer(
                lineProvider = LineCartesianLayer.LineProvider.series(
                    rememberLine(
                        fill = LineCartesianLayer.LineFill.double(
                            topFill = fill(MaterialTheme.colorScheme.primary),
                            bottomFill = fill(MaterialTheme.customColors.negative)
                        )
                    )
            )

Thanks for letting us know, @mak1nt0sh! Since this is more closely related to issue #784, I’ve reopened that. Please see here.


Implement the endpoints for Web Admin Interface

We provides the Admin interface now in Admin.d. But the requirement for the endpoints has changed so we support the change in Agora.

This PR is for the Web Admin interface that uses the Agora Admin endpoints.

Completed with PR #3294


Allow browsing of SynBioHub private parts

-Registry needs to store the authenticated token
-Preferences needs a way to log in
-SynBioHub Java API needs to allow browsing of private parts (rootCollections, subCollections, search, get, submit)

This is now implemented.  SynBioHubFrontends stores logged in SynBioHubFrontend instances, and you can log in using the "login" button in Registry preferences.  Everything seems to be working as intended on my side, but I haven't been able to see any private constructs while searching.  Upload and login have been working great though!  @cjmyers, has synbiohub.utah.edu been updated with the new functionality?
Please give it a try :)
Remaining TODOs: RegistryPreferencesDialog should only show the login button when the Registry is a SynBioHub instance and not a file.

 Should be able to submit and see immediately.
Chris
Sent from my iPhone

On Aug 27, 2017, at 11:15 PM, Michael Zhang<EMAIL_ADDRESS>wrote:
This is now implemented. SynBioHubFrontends stores logged in SynBioHubFrontend instances, and you can log in using the "login" button in Registry preferences. Everything seems to be working as intended on my side, but I haven't been able to see any private constructs while searching. Upload and login have been working great though! @cjmyers, has synbiohub.utah.edu been updated with the new functionality?
Please give it a try :)
Remaining TODOs: RegistryPreferencesDialog should only show the login button when the Registry is a SynBioHub instance and not a file.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

I logged in, submitted some parts, and they show up on the website.  However, when I search for them in SBOLDesigner (still while logged in), I can't find them.  I see the collection the submission made (which I assume is private?), but there are no parts.

Strange.  It is actually working for me.  If you are around the office today, perhaps we can take a look.

On Aug 27, 2017, at 11:22 PM, Michael Zhang<EMAIL_ADDRESS>wrote:
I logged in, submitted some parts, and they show up on the website. However, when I search for them in SBOLDesigner (still while logged in), I can't find them. I see the collection the submission made (which I assume is private?), but there are no parts.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/SynBioDex/SBOLDesigner/issues/168#issuecomment-325262514, or mute the thread https://github.com/notifications/unsubscribe-auth/ADWD94qz0efsdJTeiL86jNFU0e5b_ylJks5sck6wgaJpZM4PDGer.

Well, that's good to hear.  I'll probably drop by around noon today.

Finished remaining TODO about preventing users from logging into file Registries.  Everything has been tested and confirmed working.


Allow struct deserialization to ignore unknown fields

Right now #[derive(Deserialize)] on structs and struct variants raises an error if it's passed an unknown field. We should add an annotation that allows users to just skip these fields.

To me it is highly desirable to allow the serde-client to learn about deserialization/serialization issues. An example I have is a client communicating to a server. The server may at some point start returning fields in its json-encoded stream that are now unknown to the client. The latter should be able to choose how to handle this. Some application might want to fail outright, others might just want to warn about the data-loss. In any case, this kind of information should not be withheld from the serde-client, as it would prevent truly safe client implementations. After all, Rust is safe and fast, in that order, so are Rust programs.
Possible Solutions
Options for the Deserialization/Serialization
It feels like a clean solution to provide an options structure to all functions that perform serialization or deserialization. That way, one can configure the operation as desired. Doing so would help other issues as well, like #65 to help configure 'pretty printing'.
Special Struct Fields
Maybe one could add a struct field which is annotated with something like [serde(catch_unknown)], which will contain all field names that were skipped. That way, a client who receives values from a server may at least report that some fields were added, to possibly trigger a code-update to contain these fields natively in future.
The obvious downside of this is that structures are artificially enlarged, and it feels like orthogonal concepts are mixed here (i.e. the struct has nothing to do with the 'serde' operation, and should not be forced to keep its results).
Example
#[derive(Deserialize)]
struct Foo {
    x: i64,
    #[serde(catch_unknown)]
    __unknown_fields__: Vec<String>,
}

Possible Issues
A field with the proposed custom annotation must not deserialize, nor serialize. Also it must not clash with an existing field within the 'to-be-deserialized' json data. Possibly there are other intricacies that I don't see right now.

toml-rs does this by filling a toml structure with the left-over data. The same could be done for json and xml, since both have a value.

Is there any kind of workaround at this time? For example,
a) deseralize JSON as a multimap
b) filter out the keys that are not present in the structs
c) then serialize back to string
d) deseralize as struct
I have no clue how to do (b). If this is a viable approach (ignoring the performance, of course), can anyone write the code to do this?
Or is there some other way to hack into the mechanism without complicating things too much?

@kirillkh it's probably not that hard to implement directly in serde. You need to modify all the unknown_field functions to not error when some flag is set in the deserializer.

@oli-obk it's not immediately clear how to change this in serde, e.g. line 832 in serde_codegen/src/de.rs

the question is whether to solve this for json or or for specific types...

This sounds more like a patch than a work around.

+1 for making it it a default not to have deserializing fail for unmapped fields for a few reasons.

it's the default behavior of rustc serialize as well as many (de)serializing libraries in various languages. this is a behavior that users expect.

a client of a service may intentionally chose to not capture fields during deserialization the client application doesn't care to allocate the extra memory to pass around. without an alternative, it's an unavoidable tax clients have to pay.

it's surprising user experience to have working code break with server(sioned) services honoring contracts. It shouldn't be a breaking change for a remote service to add fields without changing fields clients have mapped.

I'm choosing not to capture one of the bajillion fields with my http json client I'm building out at the moment and ran in to this, kind of an annoying issue for me as I'm not really interested in filling out hundreds of possible fields for what I'm doing. For now I can probably hack serde to ignore unknown, I think in the future though this probably should be a deserialization option.

^ Same here, is there currently any low boilerplate way to achieve this?

I would really like this feature.

+1 this would be a great add.

I have a prototype solution to this working. It needs a few days of work before it's ready for submission. I'll hijack this issue for a mini design review:
#serde[skip_deserializing_unknown]
When on a container, causes any unrecognized fields encountered during deserialization to be silently ignored. This is only meaningful for deserializing from self-describing serialization formats like JSON. Non-self-describing formats like bincode will continue to error if there are extra serialized fields.
Implementation:

Add attrs::ContainerAttrs to support attributes on containers. FieldAttrs could be hijacked to work (it's what my prototype does), but it looks super tacky.
Plumb ContainerAttrs through serde_codegen's Deserialize functions
Add skip_deserializing_unknown attribute (I'm not married to the name; plus, see below).
In addition to the __fieldN fields on the codegen'ed __Field enum, also synthesize __Field::__ignore when skip_deserializing_unknown is true. In all matches on __Field where it errors in the fallthrough case, change it to silently eat __ignore.
... in particular, visit_map's value visiting should handle __ignore value visiting by coercing the visit() result into one that does the least possible amount of work. Currently my prototype coerces to serde_json::Value and then discards it. I'll make a lighter-weight generic consumer before submission if I can't find one pre-built.

Some formats might want to know we're skipping data (for example a format with length prefixes for entire maps/objects), but I'm keeping it simple for now and adding no new public API.
On the one hand, I don't want to muddy up this submission by advocating that skipping unknown should be the default. On the other hand, I plan on advocating for that afterwards, and there is a small way that will affect this first round: how do I allow for potential skip_deserializing_unknown negation in the future? As far as I can see there are two alternatives:

Make it take a boolean: #[serde(skip_deserializing_unknown=false)]. Simple, but discordant with the other attrs.
Introduce an error_deserializing_unknown attr, and allow at most one of {error_deserializing_unknown, skip_deserializing_unknown} to be specified.

I think I lean towards 1, and adding support for that syntax to the other boolean attrs.

+1 @JohnHeitmann I still can think of a case where we'd want this on as the default. I realized that making it a default is kind of a breaking changing but I can't think of who would want to depend on on this behavior as a default.They'd currently be a in a very fragile state anyway.
I'd rather flip the use of your utility to turn on deserialization errors when new fields are added to structures existing clients are unaware of.

Re the name: I'd suggest simply "skip_unknown" (or similar for inverted
sense) since afaics the "deserialisation" part is implied (and lengthy).
On Wed, 6 Jan 2016, 12:11 AM doug tangren<EMAIL_ADDRESS>wrote:

+1 @JohnHeitmann https://github.com/JohnHeitmann I still can think of a
case where we'd want this on as the default. I realized that making it a
default is kind of a breaking changing but I can't think of who would want
to depend on on this behavior as a default.They'd currently be a in a very
fragile state anyway.
I'd rather flip the use of your utility to turn on deserialization
errors when new fields are added to structures existing clients are unaware
of.
—
Reply to this email directly or view it on GitHub
https://github.com/serde-rs/serde/issues/44#issuecomment-168994229.
Message protected by MailGuard: e-mail anti-virus, anti-spam and content
filtering.
http://www.mailguard.com.au/mg
Report this message as spam
https://console.mailguard.com.au/ras/1Nzqq2xa7s/3LHHWoZMk56isao94qjy56/6.077

@JohnHeitmann is there a repo I could clone to build your changes to test it out.  This gh issue is the only thing holding me back from switching all my rustc serialize deps over to serde deps so I'm excited someone is looking into a fix.

@softprops https://github.com/JohnHeitmann/serde/tree/v0.6.x
Should be in a testable state.

This has been implemented in #201 for serde 0.7.0.


S1014711679 patch 2

Add a new line containing my GitHub username to roll-call.txt S1014711679

Add a new line containing your GitHub username to roll-call.txt S1014711679 (edx XCJoe)


WIP / HELP WANTED: Refactord all scripts, adding shellcheck to travis; refactoring a few other files on the fly

This is a bigger one
This was a lot of work. Please consider this before arguing. I know it's kind of big, but I think it's worth the hassle.
First things first

[ ] This PR obsoletes #1228 and #1550. Please close these issues.
[ ] This PR is based on both #1595 and #1596. They will need to be merged first. (#1595 is already.)

Help needed
The current problem I'm working on arises from a (locally executed) test:
 ✗ checking spoofing: accepts sending as alias
   (from function `assert_success' in file test/test_helper/bats-assert/src/assert.bash, line 114,
    in test file test/tests.bats, line 1503)
     `assert_success' failed

   -- command failed --
   status : 1
   output :
   --

This is kind of ridiculous:
not ok 2 check helper function: _sanitize_ipv4_to_subnet_cidr
 (from function `assert_output' in file test/test_helper/bats-assert/src/assert.bash, line 239,
  in test file test/helper_functions.bats, line 9)
   `assert_output "<IP_ADDRESS>/0"' failed
 ./target/helper_functions.sh: line 39: mapfile: -d: invalid option
 mapfile: usage: mapfile [-n count] [-O origin] [-s count] [-t] [-u fd] [-C callback] [-c quantum] [array]
 ./target/helper_functions.sh: line 29: & 0: syntax error: operand expected (error token is "& 0")
 ./target/helper_functions.sh: line 29: & 0: syntax error: operand expected (error token is "& 0")
 ./target/helper_functions.sh: line 29: & 0: syntax error: operand expected (error token is "& 0")
 ./target/helper_functions.sh: line 29: & 0: syntax error: operand expected (error token is "& 0")

 -- output differs --
 expected : <IP_ADDRESS>/0
 actual   : .../0
 --

Using this function locally works perfect. The use of mapfile -d '.' ... in other places does not seem to throw an error. This seems to be related with the version of Bash used**?** I'm on Bash 5.0.17.
I would like to receive some help here.
This is rather interesting: I do not get this error locally too.
not ok 260 checking setup.sh: setup.sh email add and login
 (from function `assert_output' in file test/test_helper/bats-assert/src/assert.bash, line 239,
  in test file test/tests.bats, line 1251)
   `assert_output "passdb<EMAIL_ADDRESS>auth succeeded"' failed

 -- output differs --
 expected : passdb<EMAIL_ADDRESS>auth succeeded
 actual   : passdb<EMAIL_ADDRESS>auth failed
 --

Changes & Rationale
I made this PR to include shellcheck and to make all the scripts more robust. I believe the latter to be especially important. Therefore, I refactored all scripts under target/ (which was a lot of work). I furthermore extended CONTRIBUTING.md with necessary coding style guidelines, and linking to it from README. This accounts for the biggest portion of this PR.
Travis should now use the shellcheck option and apply it via make.
I refactored the Makefile too, to make it verbose where it should be, and less verbose where it's appropriate.
Important
I'd really like to see some contributions in the form of either objective opinions or (better :D) code contributions to fix possible errors.

I really appreciate all the work you have put into this and it is absolutely worthwhile. However, based on previous similar attempts that have lost speed after a while and our limited review capacity I would suggest splitting the massive PR into many small parts, where we can merge and get the benefits from one change without having to wait for all of them to go through.
That is just a suggestion. I'll get around to this eventually regardless, but I'm short on time as always and it tends to be easier to merge many small changes on at a time.

@erik-wramner You're right. I came  up with this: All changes not related to start-mailserver.sh will be thrown into another PR. Those account for the minority of changes. The changes to start-mailserver.sh will receive their own PR. I will need #1596 for this to be merged though. How fast can you arrage this?

PS: I read about the limited review capacity. I'd like to help there, but I'd need to be a collaborator for this (or don't I?). What can we do abut this?

It is merged now. You would need access from @tomav to actually do merges, but you're welcome to help with reviews of other PRs if you like. Not to mention answering questions, that is where I spend the bulk of my time.

How would I go about contacting @tomav,  @erik-wramner ?
My rationale is this: I'm using the server and wan't it to be stable. Therefore I'd like to collaborate, answer questions and review/manager PRs :)

Closing this PR as #1600 will come up soon.

@aendeavor thanks for this very good work and welcome onboard!