find locustfile in the root directory

if the locustfile.py file is located in the filesystem root, and the locust command is launched from the fs root too, then the file is not found.
(to work around this issue, -f /locustfile has to be explicitly passed to the locust command)
having the locustfile in the fs root is a common use case when running in docker

Looks good! Thanks!


[Bug report] getMediaUrl() return wrong path from shared albums

Version
2.5.2
Platforms
iOS
Device Model
iphone 14 pro
flutter info
[✓] Flutter (Channel stable, 3.3.10, on macOS 12.6 21G115 darwin-arm, locale en-TW)
    • Flutter version 3.3.10 on channel stable at /Users/kevintk/fvm/versions/2.0.6
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 135454af32 (5 months ago), 2022-12-15 07:36:55 -0800
    • Engine revision 3316dd8728
    • Dart version 2.18.6
    • DevTools version 2.15.0

[✓] Android toolchain - develop for Android devices (Android SDK version 32.0.0)
    • Android SDK at /Users/kevintk/Library/Android/sdk
    • Platform android-33, build-tools 32.0.0
    • Java binary at: /Users/kevintk/Library/Java/JavaVirtualMachines/liberica-<IP_ADDRESS>/bin/java
    • Java version OpenJDK Runtime Environment (build <IP_ADDRESS>+1-LTS)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.0.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14A400
    • CocoaPods version 1.12.0

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[!] Android Studio (version 2022.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    ✗ Unable to find bundled Java version.
    • Try updating or re-installing Android Studio.

[✓] Connected device (4 available)
    • Pixel 4a (mobile)             • 09171JEC220754            • android-arm64  • Android 12 (API 32)
    • iPhone 14 Pro - test (mobile) • 00008120-000619900E68C01E • ios            • iOS 16.1 20B82
    • macOS (desktop)               • macos                     • darwin-arm64   • macOS 12.6 21G115 darwin-arm
    • Chrome (web)                  • chrome                    • web-javascript • Google Chrome 113.0.5672.126

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

How to reproduce?
I found a bug when I called getMediaUrl() to get the file path from shared albums.
Sometimes it's correct, but sometimes I get the path from another video in other shared albums.
The different ids of the entity may get the same file path, you can see it in the log below.
Logs
flutter: V/[   34 ms](xxx) id: A6B00026-4FA2-4FDC-BF52-1130FC98F6D0/L0/001
flutter: V/[    0 ms](xxx) file: file:///private/var/mobile/Containers/Data/Application/16FCD61B-214C-438D-9C19-8D5537AB05A5/tmp/.video/0.000000_IMG_0003.MP4

flutter: V/[   44 ms](xxx) id: 88973EA5-4CD5-4E8E-B742-312859641B51/L0/001
flutter: V/[    1 ms](xxx) file: file:///private/var/mobile/Containers/Data/Application/16FCD61B-214C-438D-9C19-8D5537AB05A5/tmp/.video/0.000000_IMG_0003.MP4

Example code (optional)
item.entity.getMediaUrl().then((file) {
      Log.v("id: ${item.entity.id}");
      Log.v("file: $file");
    });

Contact
No response

I found that the problem is that the modifiedDate in makeAssetOutputPath maybe 0.
So files in different shared albums may have the same filename.


Add functionality of editing(select, delete, modify...)an individual history entry or several selected entries;   type: feature request

Editing functionality of individual or several entry is a fundamental scene when using the app.

Hard to tell from the description, but what I'm upvoting is the ability to paste several items at once.
So you would need the ability to multi-select multiple items and paste all of them in one keystroke.


fix types not picked up by typescript

Fixes #3 (and specifically https://github.com/texel-org/color/issues/3#issuecomment-2563860262)

@bengry Did you ask on Discord about this PR? I think it looks good. Seems like this is exactly what was missing.
(Ignore me, if that was something else.)

@bengry Did you ask on Discord about this PR? I think it looks good. Seems like this is exactly what was missing.
(Ignore me, if that was something else.)

I asked about a different PR, for the DefinitelyTyped repo, before @mattdesl added the types into this repo.

Thanks! Merged.


GUI for Responses

Acceptance Criterias:

[x] Create new and modify existing responses
[x] Delete an existing response
[x] Search and sort responses
[x] See response dependencies with rules and stories
[ ] Show last changes view
[x] Display data validation errors - notifications on any errors, or adding/deleting/modifying responses
[ ] Limit response length (450 words)
[x] Notify on banning duplicate responses
[x] "utter_" is always in front of the response name (RASA specific criteria) - can not be deleted!

Prototype view to add new response:

@ceirowe When adding new response I can not see the text limitation mark. Only seen when modifying.

@vmugra Prototype updated.

Prototype views:

Add new response:

Marked to done status based on prototype!

@Kristjan259 I believe this need to be developed also, maybe we could groom this?


Hacs dir fix

change custom_component/jlrincontrol to custom_components/jlrincontrol
and removed DOC dir because HACS can't install with it.
link external image on readme ?

Thanks for this PR.  Have amended the custom_components directory as part of another commit to fix issues.
The docs directory and ref in the readme is pretty standard across HACS integrations and the images do show up in HACS when viewing integrations.  Am I missing something?

dont' know. HAVC install only after i remove DOC dir.
but not work . so i close this pull.
thank you


Having trouble getting the node client to run...

Have added my secret and serial codes.
❯ npm install
npm WARN EPACKAGEJSON<EMAIL_ADDRESS>No repository field.

❯ npm start

><EMAIL_ADDRESS>start /Users/greg/ha-python/loop
> node loop.js

But then it looks look the process terminates.
Sorry if I'm doing something foolish -

I stole your ideas to make a Python api.
https://github.com/pavoni/pyloopenergy
Thanks for all the work.
Leaving this open in case you want to fix - but not urgent in my case.

Sorry - only just saw this. Thanks for reporting, the start script in package.json was pointing to the wrong file.
Glad to hear you've made a Python version - that's my usual goto for this kind of thing, but in this case I wanted it to run easily in the browser.


There is no pins to connect 5v from PCB to Tiva-C VCC (5V)

This should be connected through J3.1 (upper right corner of the left side 2-row header).


Bump Go Version from 1.20~ to 1.21~

What would you like to be added?
Go version should be upgraded.
Why is this needed?
Needed to keep up with libraries and security patches.

Handled in d03b774f0d4536d5ac156adfc34df4da970c58df.


RoutingManager learning RA header from host

I noticed a potential situation in RoutingManager with how we update stale timer and how the RA header discovered from Host daemons. Here is an overview:

When we receive an RA msg, we check if the source IP address matches the InfraIf itself
(if (mInfraIf.HasAddress(aSrcAddress)))
If it is we call UpdateRouterAdvertHeader()

which then updates mTimeRouterAdvMessageLastUpdate time and sets mLearntRouterAdvMessageFromHost.

From ResetDiscoveredPrefixStaleTimer() one of the conditions is related to this

if we learnt the RA msg header from host, we then use mTimeRouterAdvMessageLastUpdate to check if discovered RA header may be stale or not

When stale timer expires, we send a sequence of RS msgs (to check if we see again the same RA msg with RA header)

The situation is that I think it is possible that we receive the RA message that we sent out ourself which would then reset the RA header back and reset the mTimeRouterAdvMessageLastUpdate

If the host daemon stopped sending RA, we may not notice it and keep using the saved RA header.

One solution is to try to somehow determine if the received RA is the one generated by RoutingManager or host (from options included in it).
Thoughts?

Can we really receive RA/RS from Thread BR self? @wgtdkp
If so, we may need to configure IPV6_MULTICAST_LOOP to zero to avoid the issue.

Can we really receive RA/RS from Thread BR self?

The mechanism in RoutingManager to discover the host RA header is assuming that we would receive RA message that is sent by the host (on the BR itself). So I expect it can be possible that we also receive the RA message that we (from RoutingManager) prepare and give to platform/host to be sent out.

If the host daemon stopped sending RA, we may not notice it and keep using the saved RA header.

Typically, the host daemon will send a RA message with zero Router Lifetime and we will reset the learnt RA header in this case. But in case we missed that RA or the host daemon crashes before sending out the RA, I agree there will be a problem that we will keep using the old RA header.
Comparing the entire RA message to determine who sent the RA should work with most cases, but we can't guarantee that host daemon won't sent the same options.
I think below idea should work:
If we are using the RA learnt from host daemon (mLearntRouterAdvMessageFromHost is true), we keep decreasing the Router Lifetime when sending out RA messages. For example, if we received a RA from host daemon at 00:00:00 with Router Lifetime of 30 minutes, we use Router Lifetime of 20 minutes when sending our RA messages 10 minutes after learning the RA (just kind of tracking the Router Lifetime of the initial learnt RA header).  So if the host daemon crashes and we do't get a refresh of the Router Lifetime from the host daemon anymore, we will decrease to zero Router Lifetime and then we can reset to our default RA header.
@abtink @simonlingoogle @jwhui Thoughts?
// @librasungirl FYI

For example, if we received a RA from host daemon at 00:00:00 with Router Lifetime of 30 minutes, we use Router Lifetime of 20 minutes when sending our RA messages 10 minutes after learning the RA (just kind of tracking the Router Lifetime of the initially learnt RA header).

I think it's a good idea to timeout the RA header, but sending RA with decreasing Router Lifetime might not be a good idea because it brings extra unexpected changes to the networking environment.
I think comparing the whole RA message is a better idea.

Submitted https://github.com/openthread/openthread/pull/7846

We can close this.


Upon deploy of prov-sys we need to ensure executable permissions on terraform provider files for each org

We get this message sometimes when we deploy prov-sys:
│ Error: Failed to load plugin schemas
│
│ Error while loading schemas for plugin components: Failed to obtain
│ provider schema: Could not load the schema for provider
│ registry.terraform.io/hashicorp/aws: failed to instantiate provider
│ "registry.terraform.io/hashicorp/aws" to obtain schema: fork/exec
│ .terraform/providers/registry.terraform.io/hashicorp/aws/4.58.0/linux_arm64/terraform-provider-aws_v4.58.0_x5:
│ permission denied..
╵
The solution is:
chmod +x .terraform/providers/registry.terraform.io/hashicorp/aws/4.58.0/linux_arm64/terraform-provider-aws_v4.58.0_x5

The solution here is to not upload or download the .terraform dir or state files


PUB-971 - Refactor Navigation

JIRA link
https://tools.hmcts.net/jira/browse/PUB-971
Change description

refactor current navigation to only include 3 links (account home, subscription, and sign out) for signed in users
display navigation with 2 links (home and sign in) for public users

Currently most of the links point to the heroku pages in order to be aligned with UAT requirements
NOTE:
This is already merged into master
Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[x] No

Closing as it has already been merged into master and will be added to pre-release with one of the future PRs


Compilation error: 'class CRtspSession' has no member named 'broadcastCurrentFrame'

What is the problem?

Same error here

Same error here

Same error

Same error any solution

I am the same issue: error: no matching function for call to 'OV2640Streamer::OV2640Streamer(OV2640&)'
105 |   streamer = new OV2640Streamer(cam);


Move TDRepository code to thingweb-common

The Code for pushing and retrieving thing descriptions from the repository is in thingweb-client part (see https://github.com/thingweb/thingweb/blob/master/thingweb-client/src/main/java/de/thingweb/discovery/TDRepository.java)
I propose moving it to thingweb-common given that it should be usable by the server also.
Any objections?
e.g, @sebastiankb do you any objections? Would like to re-use code in server part...

Implemented by https://github.com/thingweb/thingweb/commit/11f9d5311656ea2d15ff92dcb03674d3323122b0


Rewrite JUnit Assertions.assertThrows() to AssertJ assertThatThrownBy

Problem
We prefer to use AssertJ for our assertions. So we could use a Refaster rule that automatically prefers this over the assertions library built into JUnit!
Description of the proposed new feature

[x] Support a stylistic preference.
[ ] Avoid a common gotcha, or potential problem.

I would like to rewrite the following code:
org.junit.jupiter.api.Assertions.assertThrows(
    RuntimeException.class,
    () -> {
      throw new RuntimeException("bar");
    });

to:
assertThatThrownBy(() -> {
	throw new RuntimeException("bar");
})
.isInstanceOf(RuntimeException.class):

Good idea! I would like to suggest that we expand the scope of this issue a bit to cover "some sizable subset" of the org.junit.jupiter.api.Assertions API. Having a separate PR for each method in that class is not efficient :sweat_smile:.

Interested in picking this up! Below are the methods in org.junit.jupiter.api.Assertions and the equivalent AssertJ code. There are quite a few but quite straight-forward so they could all be part of one big PR.
Conditions:
assertTrue(condition) -> assertThat(condition).isTrue()
assertFalse(condition) -> assertThat(condition).isFalse()
assertNull(obj) -> assertThat(obj)isNull()
assertNotNull(obj) -> assertThat(obj)isNotNull()
assertInstanceOf(clazz, obj) -> assertThat(actual).isInstanceOf(clazz) (or isExactlyInstanceOf?)
Equality:
assertEquals(expected, actual) -> assertThat(actual).isEqualTo(expected)
assertNotEquals(expected, actual) -> assertThat(actual).isNotEqualTo(expected)
assertSame(expected, actual) -> assertThat(actual).isSameAs(expected)
assertNotSame(expected, actual) -> assertThat(actual).isNotSameAs(expected)
assertArrayEquals(expected, actual) -> assertThat(actual).containsExactly(expected)
assertIterableEquals(expected, actual) -> assertThat(actual).containsExactly(expected)
assertLinesMatch -> ?
Exceptions:
assertThrows(clazz, () -> ...) -> assertThatThrownBy(() -> ...).isInstanceOf(clazz)
assertThrowsExactly(clazz, () -> ...) -> assertThatThrownBy(() -> ...).isExactlyInstanceOf(clazz)
assertDoesNotThrow(() -> ...) -> assertThatCode(() -> ...).doesNotThrowAnyException()
Other:
assertAll -> ?
assertTimeout -> ?
assertTimeoutPreemptively -> ?
Each method also has overloads with a String message or Supplier<String> message supplier, so we'd also need templates for these. Not sure if there's a nice way to group these or we'd need to define separate templates for each.
assertEquals(expected, actual, message) -> assertThat(actual).isEqualTo(expected).withFailMessage(message) assertEquals(expected, actual, messageSupplier) -> assertThat(actual).isEqualTo(expected).withFailMessage(messageSupplier)
Left a question mark for a few I'm not sure about, but I'm guessing those are used much less frequently.

Nice @giall! Indeed it makes sense to bundle these rules.
Maybe we can also include the .fail method(s):

fail() -> this one doesn't have a direct equivalent... (Any ideas on how to approach this one?)
fail(String) -> fail(String)

Not sure if we should tackle timeout now, I haven't yet found a nice AssertJ equivalent. I think it would make more sense to rewrite it to JUnit's timeout annotation. This sounds like out of scope for this ticket however 😄.
W.r.t. assertAll, maybe this would be better suited in an Error Prone check. Let's defer that one as well. It is an interesting one, see examples.

which does explode the scope of the work a bit.

Sounds to me like it'd be better to split that in two PRs then 😉.

Resolved in #417


Custom date - expected string format

Hi,
Thank you for your hard work. It is a great app.
I wanted to make a customised date format. It's not clear what I should write:
classic: false

# == Date ==.
# Possible values: date, relative, +<date_format>
date: '%d %b %y %X'

I was expecting this config to give me a date such as "10 Jun 21 13:01:00".
What am I missing?

You are missing a + in front. We require that for a custom date format.
date: '+%d %b %y %X'

hi @meain
thanks for the feedback. it also required me to update to the latest for this to work. i had installed lsd as a snap which is still at v0.16.0.


Bug in sign up page

Hey, @AtriSukul1508 There is a bug in the signup page as I am unable to sign up. Please assign me this issue so that I can fix it. Thank you.

I can solve this issue very fast, i have already analyzed the code, please assign me this issue @AtriSukul1508

i can solve this issue please assign this issue to me


Student Hubs

Summary
Adding Student Hubs Channel
What is the feature request for?
The core library
The Problem
Currently student hubs are not included in the libary, but are already available. this might result in errors regarding invites trying to be resolved (bots can not join so far but invites might throw errors)
The Ideal Solution
Implement a basic placeholder for them without any major functions
The Current Solution
none
Additional Context
https://github.com/discord/discord-api-docs/pull/3757

Currently student hubs are not included in the libary, but are already available. this might result in errors regarding invites trying to be resolved (bots can not join so far but invites might throw errors)

I do not understand this. You want bots to be able to join student hubs? I'm not sure it's possible, or even allowed (because you need a student email to join). Student hubs also don't have any text channels to themselves, they simply show a list of servers that some students from the hub are owners of.
That doesn't stop a bot from interacting with a server that is part of the hub though, since in the end that's just a normal server.

No, as shown in the additional context, a new guild feature and a new channel type was added for students hub

Currently student hubs are not included in the libary, but are already available. this might result in errors regarding invites trying to be resolved (bots can not join so far but invites might throw errors)

I do not understand this. You want bots to be able to join student hubs? I'm not sure it's possible, or even allowed (because you need a student email to join). Student hubs also don't have any text channels to themselves, they simply show a list of servers that some students from the hub are owners of.
That doesn't stop a bot from interacting with a server that is part of the hub though, since in the end that's just a normal server.

i do not want them to be able to join, but be able to understand the invites as invites to student hubs and display them correspondingly

for ref for if this is ever  merged ddocs' side https://github.com/discord/discord-api-docs/pull/4701


TinyIoC PCL

I added a portable class library project for TinyIoC. The PCL supports net45, sl4+, wp7.5+, WindowsStoreApps, Mono for Android and MonoTouch. Maybe it is a starting point for a official PCL release.

Any updates on this?

Loving TinyIoC. I wish I could use it within a PCL though! Any news? If I could help, I would!

@dazinator please check out the latest code: https://github.com/grumpydev/TinyIoC/commit/361a01741a6b94583b88dcb9b71330602c59bb89 I had a big commit for this and I'm using it in our pcl library: https://github.com/exceptionless/Exceptionless.net

@niemyjski oooooo nice! I'll take a look - cheers :)

@grumpydev any news on this pull request? Thanks ;)

@wizche : the current code works in PCL, I think this PR has been superseded.

@grumpydev thanks, but only if it targets .NET 4.0 right?

@wizche : nope, works on all "modern" pcl profiles - in some scenarios you need to compile it into a PCL assembly and reference it (so .net adds the reflection shims) but other than that it's fine.

Is this Pull Request still valid considering the current code works in PCL?

Yeah I'd close it my pull request added support for it


Docker-compose and incorrect absolute paths for volumes

windows 10 build 1503.11 running Xenial 16.04.2 LTS with docker client 17.03.0 connecting to the hyper-V docker-for-windows daemon 17.03.1 and docker-compose 1.11.1
From within wsl things like docker run --rm -v c:/my/stuff:/var/goes/here bash ls /var/goes/here work fantastically.  This command will simply list the contents of c:/my/stuff.
What does not work is If you have a docker-compose.yml that looks like:
version: '2'
  services:
    bash_it:
      image: bash
      volumes:
        - ./:/var/goes/here

and you run something like  docker-compose -p test -d bash_it up && docker exec test_bash_it_1 ls /var/goes/here. Everything will explode and die - you may have to restart the docker-for-windows daemon / engine.
the error will look something like:
ERROR: for proxy  Cannot start service proxy: oci runtime error: container_linux.go:247: starting container process caused "process_linux.go:359: container init caused \"ro
otfs_linux.go:54: mounting \\\"/mnt/c/my/stuff\\\" to rootfs \\\"/var/lib/docker/overlay2/e4bda146bae2ce38c13ad8f3c4ff5f6e
6f3198041ce02d4c6f593f65948e7086/merged\\\" at \\\"/var/lib/docker/overlay2/e4bda146bae2ce38c13ad8f3c4ff5f6e6f3198041ce02d4c6f593f65948e7086/merged/var/goes/here\\\"
 caused \\\"not a directory\\\"\""
: Are you trying to mount a directory onto a file (or vice-versa)? Check if the specified host path exists and is the expected type
ERROR: Encountered errors while bringing up the project.

It's all rather complicated looking, but I'm pretty sure I can tell you what's going on:  the windows-for-docker daemon expects a valid windows path (eg c:/my/stuff)  BUT docker-compose is calling os.path.abspath to resolve the absolute path of the resource and it's getting a URI/path that looks like /mnt/c/my/stuff - which is absolute nonsense unless you're in the windows linux subsytem.. which the hyper-v daemon is clearly not.
so... that's an interesting problem.  Is there a switch like MSYS_NO_PATHCONV=1 or something I can do to prevent os.path.abspath from returning a wsl alias? OR - how should this work?

So, this is a little more conceptually complicated:  Unlile in Cygwin, /mnt/c/... is not an alias in WSL.  It is the canonical and only way to refer to that directory.  C:\... is not a valid Linux path; therefore not a valid WSL path.  (C:\ would immediately cause errors on Linux, so WSL does likewise.)
In this particular case, maybe you could try putting an absolute Windows path in your config file?  You might also want to bring this up on the Docker forums -- they seem to be pretty active, and the Docker team seems to care a lot about compatibility.  (And this would be a really easy, if kind of hackish, thing for them to work around.)

/mnt/c/path makes total sense though. The issue is the mismatch between /mnt/c of WSL and /c in the VM of Docker for Windows.
Within the Hyper-V VM, the C: is mounted to /c instead of /mnt/c. I believe https://github.com/docker/for-win/issues/371 would be the ideal solution, which is to make Docker for Windows mount C: into /mnt/c inside the VM.

Within the Hyper-V VM, the C: is mounted to /c instead of /mnt/c

And in MSYS as well, which is how the whole Windows Git BASH world sees things. I know that mounting remote shares on / is an anathema on Real Linux, which WSL strives to follow. But there is (unfortunately) a lot of precedent for that convention, and WSL goes against the grain here. I imagine this will sort itself once WSL supports mounting of DrvFS on arbitrary paths.

@sakai135 -- ah, interesting:  I initially assumed Docker for Windows did Windows path translation server-side but it would make a lot of sense for it to do it client-side (in which case the Linux client would indeed need to pass in a VM-compatible path).
@therealkenc -- ooh, that's a good thought:  WSL already supports bind-mounts.  Therefore it does (in essence) support mounting DrvFS on arbitrary paths.  So, proposed workaround (untested):
$ sudo mkdir /c
$ sudo mount --bind /mnt/c /c
$ cd /c/path/to/project
$ docker-compose ...

@aseering the bind mount worked for me :) Thanks for the workaround!

I forgot binding works. Perfect. Once real init (aka systemd) is working, I am imagining that line being in everyone's startup script....

@aseering you made me realize that it was unusual that the WSL docker client was taking non-canonical paths as arguments, so I went back and tried
$ docker run --rm -v /mnt/c/Users/ej3/dev/play/:/var/play bash ls -la /var/play
total 4
drwxr-xr-x    5 root     root           100 Apr  5 21:05 .
drwxr-xr-x    1 root     root          4096 Apr  5 21:47 ..
drwxr-xr-x    2 root     root            40 Apr  5 20:58 Dockerfile
drwxr-xr-x    2 root     root            40 Apr  5 21:02 configure.file
drwxr-xr-x    2 root     root            40 Apr  5 21:05 test.dev.conf

which seemed to work! (but the listing wasn't complete?!)  so then I had no idea what the problem could have been, and I panicked a bit.
Then the conversation went on, and the bind for DrvFS came up:
$ docker run --rm -v /c/Users/ej3/dev/play/:/var/play bash ls -la /var/play
total 12
drwxr-xr-x    2 root     root          4096 Apr  5 21:44 .
drwxr-xr-x    1 root     root          4096 Apr  5 21:47 ..
drwxr-xr-x    2 root     root             0 Apr  5 21:44 .git
-rwxr-xr-x    1 root     root            81 Apr  5 21:10 Dockerfile
-rwxr-xr-x    1 root     root           675 Apr  5 21:44 README.md
-rwxr-xr-x    1 root     root           139 Apr  5 21:19 bash_it.sh
-rwxr-xr-x    1 root     root           116 Apr  5 21:04 docker-compose.yml
-rwxr-xr-x    1 root     root            39 Apr  5 21:09 test.conf
-rwxr-xr-x    1 root     root            40 Apr  5 21:08 test.dev.conf
$

Then I was able to reproduce my issue with a simple docker-compose example, and the bind completely resolves the issue.
Just a further note: When I first tried using the bind I was getting a new set of IO errors because I had created the containers with docker-compose on the /mnt/c volume, moved to the /c volume and simply did a docker-compose up without recreating the containers from the images.  If anyone else has this problem: be sure to re-instantiate new containers from the original images after you switch mount points.
Thanks.

I wanted to do the same a few months ago. I ended up simply symlinking /mnt/c to /c:
sudo ln - s /mnt/c /c

Not sure if it's better performance-wise than bind-mounting, but it works just as well.

For what it's worth, there are some applications (Web servers in particular) that will deliberately refuse to read files from any path that contains a symlink.  Usually for security reasons, because malicious users could use symlinks to escape DocumentRoot.  Bind mounts usually don't suffer from this limitation -- anyone can create a symlink anywhere, but you need elevated permissions (traditionally, root) to set up a bind-mount, so sysadmins can still use them but they're harder to exploit.

Hi folks,
We're talking this over internally at Microsoft and open to suggestions.
From Russ on the WSL (Windows Subsystem for Linux) team:  "Bind and symlinks both work, but the bind may be better in some cases since not all services will follow symlinks. Downside of bind is that it will not stick between WSL instances due to our init."
Essentially agreeing with @aseering's points :)
What ideas do you have?  What are you trying to do when you run into problems around file paths?
Cheers,
Myles

From my holistic point of view, the ideal solution would be for all us (and I really expect it happen some day), iff WSL will converge with Docker and Docker on Windows will move to use WSL compatibility layer instead of MobyLinux VM. In this case Docker Compose could be used the way it is used on Linux and transparently rely on WSL underneath.

Thanks for the suggestions!

Do you need to sudo mount --bind /mnt/c /c everytime you open up a bash? I've tried adding the following line to /etc/fstab but that doesn't seem to do the trick:
C: /c drvfs rw,noatime 0 0

Has anyone found a way to make sudo mount --bind /mnt/c /c permanent yet? I know I could just add it to something like ~/.zshrc .However, that requires me to enter a password every time I want to open the terminal >.>. It would be nice if we could add it to something like /etc/rc.local and have it automatically start up when I run the terminal

There's a long thread regarding daemons and startup tasks in #834, with a reasonable work-around at the very bottom. Short story, add mount to your /etc/sudoers so you don't have to enter the password every time. The User Voice is here.

@DeadPixelz01 For me https://github.com/docker/for-win/issues/371#issuecomment-318633201 works quite well

oh my god @aseering ily. you just helped me finally jump through the last of the many fiery hoops that line the pathway to getting docker fully operable from within lxss

Just as a reference for anyone facing this with Docker Toolbox (using VirtualBox by default).
Either make the bind or the symbolic link sugested above inside the docker-machine environment: sudo ln -s  /c/ /mnt/c

Has anyone gotten their files corrupted by modifying files through mounted C drive to /c/ instead of /mnt/c? Specifically, I'm working on an issue in docker/composerepo. My.git/index` would get corrupted sometime after running the test scripts.
I tried both
sudo ln -s /c/ /mnt/c
and
sudo mount --bind /mnt/c /c

@aseering Thanks for the offer of help. I did eventually get this working with the bind mount. Turned out my config was the issue - of course.
Today Microsoft released insiders build 17093. In the release notes it states:

WSL now processes the /etc/fstab file during instance start [GH 2636].

I thought this might be of interest to @edrevo who previously mentioned fstab was not working. Would this help us to keep the bind mount permanent rather than entering it into our .bashrc or equivalent?
The notes also mention:

AF_UNIX allows socket connections between Linux processes on WSL and Windows native processes

Would anyone with a bit more knowledge be able to say if these changes affect this issue at all?

@pd93 - yes the addition of fstab support adds a better way to configure mounts. AF_UNIX support is new functionality that allows WSL processes and Windows processes to communicate and should not impact this. See the blog post for more details.

Regarding AF_UNIX, in principle Docker for Windows should be able to use that to allow WSL/Linux applications to talk over a local socket (just like native Linux Docker) rather than TCP/loopback.  I haven't read this part of Docker's source code, but I would guess that they would need to make some small modifications to their code:  Previously, AF_UNIX didn't work and wasn't available on Windows, so existing applications will often avoid even trying it on Windows.

But there is OTOH one new feature that might be of relevance here. On wsl.conf you can now specify the mount point of the C: drive:

Key: root
Value: String value (/mnt/…)

Default: “/mnt/”

This key lets you  define a new directory where fixed drives will be automatically mounted.  For example, if you have a directory in WSL at “/windir/” and you  specify that as the root, you would expect to see your fixed drives (for  example, C:/) mounted at “/windir/c”

@villasv I can confirm that adding the following to the /etc/wsl.conf file appears to work:
[automount]
root = /

I brought up my docker project and can access all of my volume mounts 👍

@benhillis Is there a way to obtain the root mount point from from the wsl command line without having to parse the wsl.conf file?

@pd93 - No there is not.

@pd93 you can get similar information by parsing /proc/mounts.  Not clear that's any better :-)  But it's more Linux-ey; existing Linux tools already support it.

I can get this to work, but it doesn't respect the file permissions I set in WSL. Thanks to recent changes, I can set keys on my windows system to 600 through WSL (I think it uses the drvfs filesystem and attaches some metadata to it). These changes aren't visible on the volume mount. Every file ends up with the same permissions, just like when I run docker from powershell.

How to access WSL filesystem fromcomposer?
Each folder I ‘mount’ using volumes command appear empty in container...
The workarounds described here shows how to access windows drives, not WSL...

@kskalski I did before mounting the volume to the root.  This could be happening because your mount --bind /mnt/d /d is not actually occurring / executing cleanly?

The mounts seems to be working fine, I can access all content without problem in /d, however when I mount /d as volume to docker container, it shows empty dirs (seems like it memoizes the subdirs that I tried to mount as volumes and shows just them, so running with /d, then /d/subdir, then /d will show subdir as content in last step).
It works somewhat better for /c than for /d though... For /c I can correctly access /c/Users/kamil and all contents in subdir, for /d there is nothing at all. Maybe Docker Toolbox VM is not actually mounting D: and for C: maybe it's a different problem.

After fighting with Windows and Docker for a bit, I found out the secret to mapping the drives is as follows:
Update Docker so that it has access to the drive in question (see screenshot), and begin the path using /[drive] (in this case, /c/whatever)

Ah, ok. For Docker Toolbox (using VirtualBox) you can actually map drives (host C: or D:) under (guest, visible to docker containers) /mnt/c /mnt/d directories, so the workarounds mentioned in this issue could be skipped and the problem solved through VM settings.

Hello!
Yesterday I've had same issue with mounting folders with Docker-compose and this tip has helped me:
https://github.com/docker/compose/issues/4303#issuecomment-391394800
it was just as simple as "Reset credentials" in Docker "Shared drives", update password to current and restart Docker (in reset menu).
Maybe it will help somebody too.

I faced the same issue with docker-compose as well, by default Docker Toolbox for Windows only has access to C:\Users. Additional directories can be shared via VirtualBox UI.
REF : https://docs.docker.com/toolbox/toolbox_install_windows/#optional-add-shared-directories

I think the bind trick is a hack, this should be made to work:
     volumes:
     - "./db:/var/db"

Having to bind the drive first, then navigating to that new fake drive, makes things really complicated. If you already have a development setup with scripts that run the docker-compose, this is annoying thing. I can't go and edit the development scripts because they are correct.
Right now I should do a new script just for WSL, and that is clunky.


chore: filtering patches from docs deployment script

Description
This change makes the script that runs before yarn build filter down the patches to the latest patch of every major.
Problem*
This script used to remove:

Prereleases
Nightlies (which are prereleases)
"Aztec" versions

However, this would mean that every patch, as long as it was stable, would have its own docs deployed. This would lead to docs having three patch versions, which shouldn't even differ (they're patches, no breaking changes), like 0.19.1, 0.19.2, etc
Summary*
This change simplifies the script by removing some computation that was there just for debugging reasons. It also stops assuming all "aztec" versions are prereleases. And finally, it filters down only for the latest patch version.
Additional Context
Another way of doing it (which is how we're doing it now) is to just make all non-latest patch as prereleases, which is kinda annoying. With this change, it shouldn't matter.

It doesn't show our third-recent stable release v0.10.5 🤔

It doesn't show our third-recent stable release v0.10.5 🤔

Likely a pagination issue on the github api due to the nightly releases.

It only shows three versions, that's dev + 2... I think this is good this way, I believe there's no reason to support anything older than v17

It only shows three versions, that's dev + 2... I think this is good this way, I believe there's no reason to support anything older than v17

The issue is that nightlies are pushing all of the stable releases out of the api response. As time goes on then we'll gradually get fewer and fewer versions showing up in the dropdown unless we release new breaking versions fast enough to ensure that we have 3 on the first page of the response from github.
The way filtering is set up currently does "3 + dev" afaik as we're filtering the api response whereas dev gets added later by docusaurus. If you drop the limit down to 2 I expect that we'll get the same dropdown.

+1 concern isn't on v0.10.5 specifically, but to make sure frequent nightlies / pre-releases would not affect versions available on docs.

I'm sure it is getting pretty much all the versions, it does pagination but we get versions all the way back to 0.7ish iirc.
It's the filtering that makes only the last releases show up 😊

I only see releases back to 0.19.0 although this is just when opening up the endpoint in the browser so maybe if you're using an API key then you get more.

So yeah seems like we're getting 100 versions per page, which is apparently not enough for 0.10.5. Here are all the versions pulled from the axios call:

And this is after the first .filter that removes prereleases, nightlies and stables:

Had a quick look and indeed, versions like 0.15.0 are not stable. We also remove 0.16.0 manually for some reason I currently do not recall. That leaves us with these two.
I'll make the change to pull more pages to filter, but I still believe it wouldn't be important to document anything below 0.17. Wdyt @Savio-Sou ?

We also remove 0.16.0 manually for some reason I currently do not recall.

It had an unsafe merkle tree impl in the stdlib.

I still believe it wouldn't be important to document anything below 0.17. Wdyt @Savio-Sou ?

It's not so much that we need to go back to 0.10.5, the trouble is that going forwards in the best case scenario the longest time that we show docs for a particular minor version is around 3 months (before it's pushed off of the first page of the api response). I think that 3 months is a pretty short amount of time to display docs for a particular version.

Makes sense 👍  Just updated the script to deal with 3 pages, which is enough to get ALL the versions since the beginning of time 💥
gtg @TomAFrench @Savio-Sou


change capitalization of Kokkos to kokkos

If a user wants to use submodules like the AresPK documentation suggests, there will be an issue with the capitalization of Kokkos in CMakeLists.txt. the submodule creates a file external/kokkos, which is not found with the current CMakeListst.txt. This is not a problem on mac, since by default capitalization of paths does not matter, but on linux it does matter. This fix should work on all machines since the capitalization matches that of the submodule.

When I get access to my mac, I'll test it there, but it may be a good idea to test the cmake functionality on Windows also, however I do not have a windows machine.


Cancel the subscription after receiving all of the pertinent emissions (#259)

See #259.

@ktoso can you provide some guidance on how you want this tested please.

I think adding a test that has a simple synchronous publisher that checks for the cancellation signal while spinning would be good enough here - we just want to show that such test will properly terminate - right?

Got a few mins more time, more hints which should help you get started :-)
Put the test inside PublisherVerificationTest, the used naming format is testedMethodName_shouldPass[_optionalDesctiptionWhen]:
In our case I'd go with:
@Test
  public void required_spec317_mustNotSignalOnErrorWhenPendingAboveLongMaxValue_forSynchronousPublisher() throws Throwable {

:+1:

@ktoso ping.

Yup good one, LGTM (I think I'd skip the 11 check, it's a bit internals looking, no need for it IMO). Thanks @alkemist

I've already done the copyright waiver thing: https://github.com/reactive-streams/reactive-streams-jvm/blob/master/CopyrightWaivers.txt#L29

@reactive-streams/contributors Let's merge this TCK fix in and issue a new RC immediately to get feedback.

Merging


CMake Unable to open .lib file

Hi all,
I'm trying to compile my program using cmake. However, I'm getting an issue: Error LNK1104: cannot open file 'jsoncpp.lib'. If I remove the jsoncpp line, I get the error with curl and then curlpp. So I think I'm doing something wrong with my cmake file. All of the packages are installed via vcpkg. Here is my cmake file:
# CMakeList.txt : CMake project for NickvisionApplication5, include source and define
# project specific logic here.
#
cmake_minimum_required (VERSION 3.8)
set(CMAKE_CXX_STANDARD 17)

if(MSVC)
    add_definitions(-D_CRT_SECURE_NO_WARNINGS)
endif()

find_package(PkgConfig)
find_package(jsoncpp)
find_package(curl)
find_package(unofficial-curlpp CONFIG REQUIRED)

add_executable (NickvisionApplication5 "main.cpp" "Models/Update/Version.h" "Models/Update/Version.cpp" "Models/Update/UpdateConfig.h" "Models/Update/UpdateConfig.cpp" "Models/Update/Updater.h" "Models/Update/Updater.cpp" "Views/MainWindow.h" "Views/MainWindow.cpp")

pkg_check_modules(GTKMM_VARS REQUIRED IMPORTED_TARGET gtkmm-4.0)
target_link_libraries(NickvisionApplication5 PRIVATE PkgConfig::GTKMM_VARS)
target_link_libraries(NickvisionApplication5 PRIVATE jsoncpp)
target_link_libraries(NickvisionApplication5 PRIVATE curl)
target_link_libraries(NickvisionApplication5 PRIVATE curlpp)

target_link_libraries(NickvisionApplication5 PRIVATE jsoncpp)

needs either to be one of those:
target_link_libraries(NickvisionApplication5 PRIVATE jsoncpp_lib) (only for triplets with VCPKG_LIBRARY_LINKAGE = dynmaic)
target_link_libraries(NickvisionApplication5 PRIVATE jsoncpp_static) (only for triplets with VCPKG_LIBRARY_LINKAGE = static)
target_link_libraries(NickvisionApplication5 PRIVATE jsoncpp_object)
depending on your triplet

Error LNK1104: cannot open file 'jsoncpp.lib'.

Note: Such an error always indicates your are not linking a target.

Please use the following cmake code instead:
For dynamic jsoncpp (triplet doesn't contains static):
    find_package(jsoncpp CONFIG REQUIRED)
    target_link_libraries(main PRIVATE jsoncpp_lib jsoncpp_object)

For static jsoncpp:
    find_package(jsoncpp CONFIG REQUIRED)
    target_link_libraries(main PRIVATE jsoncpp_object jsoncpp_static)

@JackBoosY The jsoncpp is now fixed using
find_package(jsoncpp CONFIG REQUIRED)
target_link_libraries(NickvisionApplication5 PRIVATE jsoncpp_lib jsoncpp_object)

However curl and curlpp have the same issue unable to open the .lib file. I tried using the same example that you provided for jsoncpp for curl and curlpp, but it's not working.
Heres what I have currently:
find_package(curl CONFIG REQUIRED)
find_package(unofficial-curlpp CONFIG REQUIRED)
target_link_libraries(NickvisionApplication5 PRIVATE libcurl)
target_link_libraries(NickvisionApplication5 PRIVATE curlpp)

Fixed all issues
This is my final cmake file:
# CMakeList.txt : CMake project for NickvisionApplication5, include source and define
# project specific logic here.
#
cmake_minimum_required (VERSION 3.8)
set(CMAKE_CXX_STANDARD 17)

if(MSVC)
    add_definitions(-D_CRT_SECURE_NO_WARNINGS)
endif()

find_package(PkgConfig)
find_package(jsoncpp CONFIG REQUIRED)
find_package(curl CONFIG REQUIRED)
find_package(unofficial-curlpp CONFIG REQUIRED)

add_executable (NickvisionApplication5 "main.cpp" "Models/Update/Version.h" "Models/Update/Version.cpp" "Models/Update/UpdateConfig.h" "Models/Update/UpdateConfig.cpp" "Models/Update/Updater.h" "Models/Update/Updater.cpp" "Views/MainWindow.h" "Views/MainWindow.cpp")

pkg_check_modules(GTKMM_VARS REQUIRED IMPORTED_TARGET gtkmm-4.0)
target_link_libraries(NickvisionApplication5 PRIVATE PkgConfig::GTKMM_VARS)
target_link_libraries(NickvisionApplication5 PRIVATE jsoncpp_lib jsoncpp_object)
target_link_libraries(NickvisionApplication5 PRIVATE CURL::libcurl)
target_link_libraries(NickvisionApplication5 PRIVATE unofficial::curlpp::curlpp)

Note that:

find_package(jsoncpp CONFIG REQUIRED)

finds a named package (via a cmake config file or cmake find module). You need to look into the documentation for that software or find module to see what it provides, because:

target_link_libraries(NickvisionApplication5 PRIVATE jsoncpp_lib jsoncpp_object)

will try to link to the named libraries. Packages provide the libraries in different ways:

as (imported) targets
as variable containing the actual library name or target name.

Example: https://cmake.org/cmake/help/v3.19/module/FindCURL.html


Add more compact serialisation formats for ABI/artifacts

We currently have a POC serialisation format for ABIs (just to ensure serde compatibility) however this has some pros and cons:
Pros:

Human readable
Familiar to Solidity developers who are used to contracts outputting JSON ABIs.

Cons:

Verbose, for large circuits with many fields in the interface this JSON can become huge.

It's then preferable to have a more concise binary format with JSON as a pretty-print option to maintain readability for people writing small circuits.
Some options which have been raised are:

https://github.com/protocolbuffers/protobuf
https://github.com/google/flatbuffers (Koby's preference)
https://github.com/google/flatbuffers/tree/master/rust/flexbuffers (Gets us serde support in return for giving up schemas)

We should also consider whether whatever format is chosen, if we should also change ACIR to follow it

This issue is pretty stale, we are using base64 and json


Integrate react-blockstack package

I am very excited about your gitix project. It's one of the most promising Blockstack projects by far.
I hope you're open to pull requests? I've submitted PR #3, which takes a first stab at integrating the react-blockstack package, providing react hooks for the Blockstack SDK.

I have merge the PR, but now I am stuck with the question how to add radiks. See https://github.com/njordhov/react-blockstack/issues/3
@njordhov If you want to help fix it, the work to save a relationship between two gitix users (followship) was started in feature/radiks

Radiks should be initialized when the user has been authenticated, right? Instead of initializing Radiks when loading blockstack.js, do it when userData is determined to be available. In App.js there is a watch/effect triggered by changes to userData, so you may initialize Radiks there:
useEffect(() => {
      if (userData) {
       /* Initialize Radiks here */
        setSignIn({ checking: false, user: userData, isSignedIn: true });
      } else {
        setSignIn(NotSignedIn);
      }
  }, [userData]);

You can alternatively create a separate watch/effect for Radiks initialization like the one above.

@njordhov I have added radiks, it looks like it works.
Do you have any ideas how to use react-blockstack in Nav.js?

I take you'd like to avoid passing the UserStateContext from Nav.js. Here are some suggestions.
A) As Nav is a react class component, useBlockstack() can't be called from the render function. You may rewrite it to be a function component. Alternatively, factor out the relevant parts from render into function components, specifically those conditioned on signIn.isSignedIn.
B) Note that userData from useBlockstack only is truthy when authenticated, so you can use that to test for isSignedIn. As userData is available in App-Container where the Nav component is used, consider  adding an isSignedIn prop to Nav that is set to !!userData, and you should be able to eliminate UserStateContext from Nav by using the isSignedIn prop in place of signIn.isSignedIn from the context.


Fix conversion error in VolatilityModelPythonWrapper.Volatility

Description

A PyObject to decimal conversion has been fixed in the Volatility getter in the VolatilityModelPythonWrapper class

Related Issue
Closes #2918
Motivation and Context
The Volatility getter was throwing the following error:
Cannot convert type 'Python.Runtime.PyObject' to 'decimal'

Requires Documentation Change
No
How Has This Been Tested?
Verified the issue was resolved with an algorithm in the cloud.
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Non-functional change (xml comments/documentation/etc)

Checklist:

[x] My code follows the code style of this project.
[x] I have read the CONTRIBUTING document.
[x] All new and existing tests passed.
[x] My branch follows the naming convention bug-<issue#>-<description or feature-<issue#>-<description>

Fixing via python net.


Get events by location in the Home Screen

Something like this

First handle pagination, right now only 20 events are shown

@iamareebjamal Can I start working on this ? I am stuck in the pagination PR so in the mean time I can finish this and then try  pagination again

OK


Add Rudimentary HTML Support

This is a great project! I used it for a project documenting how to integrate Livefyre for our customers. It helped a lot!
I wanted to use it on an HTML document, though. So I added rudimentary HTML support for multiline comments. I couldn't do it with the built in symbol-only definition in the langs dict, so I added two lines to generate_html to let me explicitly define divider_text and divider_html.
You can see it in action here: http://demos.livefyre.com/ssosandbox/help/
I will probably have a need soon to add support for not needing to have a newline between the <!-- and the actual comment, but I think that will be more invasive. Someone might be able to tweak a regex somewhere to do it easily. I didn't grok the whole program, but like I said, it's great!

Thanks for the contribution.
HTML support had not been added yet due to #21.
I want to make this into a more general purpose solution to fix that issue before merging.  I'll leave this pull request open for others that need HTML support to use in the meantime.
I plan on using None for language symbols that are unused (for languages with multi-line comments but no line comments) and I want to find out how divider_text and divider_html are used and see if there's a better way to override them.

Great. Yeah, just wanted to start the conversation with some code. :)

Closing as out-of-date.


Panic while redering space in NotoSans-Regular

I've been thorugh a a bit of a rabbit hole today because of a segfault in freetype-rs. After reading logs and stack traces, it is caused by this crate using a way too low version of freetype-rs. From what I have gathered, the issue happens with some characters that are blanks.
This is because Face::load_glyph can populate the slot with valid information, but no bitmap buffer, leaving it empty. However, in C, an empty slice is represented as (null, 0) but this is invalid in rust, causing a panic when trying to load it in crossfont. Here's the offending code: link.
This issue was fixed in this commit, and later released as version 30.1.
Related issue: #44

See https://github.com/alacritty/crossfont/pull/65
I think we kind of can propagate this bump, given that only sctk-adwaita and alacritty depend on crossfont according to crates.io, thus it's likely not that big of a deal, given that we won't break binary crates, I think.

Btw, thank you for being bery quick to respond!

If you could, make this a patch number bump. That way, it get's automatically selected by the resolver

It's a breaking change, so we can't do that.

Understandable. Thank you very much again :)


Not showing in plugin menu

After installing the plugin, it doesn't show in the plugin menu or the preferences window for me. I'm running Sketch 48.1.

I normally install plugins via Sketch Runner, but since Chart wasn't listed in Runner for installation, I tried installing manually.
I just tried again, and there were two plugin files inside the zip file: Chart.sketchplugin and chArt-1.sketchplugin. If I double-click Chart.sketchplugin, it doesn't show in the menu. If I double-click chArt-1.sketchplugin, it shows in the menu, but only Line chart, Stacked area chart, and Sparkline are in the menu, and none of them work.
Since manual installation still isn't working, I installed Sketchpacks and then Chart via Sketchpacks, and now it's working perfectly fine.


Create Docker Service failed

I running this code inside the container host at Master Node. I had mount /var/run/docker.sock:/var/run/docker.sock to run container by client.Containers.ListContainersAsync and it's work. but then I try to run the below code then i got an exception "A possible object cycle was detected which is not supported. This can either be due to a cycle or if the object depth is larger than the maximum allowed depth of 32."
I don't understand why i got thit exception. Please give me some clues to fix this issue.
 ServiceCreateParameters serviceCreateParameters = new ServiceCreateParameters() {                     Service = new ServiceSpec() {                         Name = "bim service",                         TaskTemplate = new TaskSpec() {                             ContainerSpec = new ContainerSpec {                                 Image = "bim",                             }                         },                         EndpointSpec = new EndpointSpec {                             Ports = new List<PortConfig>() {                                 { new PortConfig() {                                     TargetPort = 3003,                                     PublishedPort = 3003                                 } }                             }                         },                         Mode = new ServiceMode() {                             Replicated = new ReplicatedService {                                 Replicas = 5                             },                         }                     }                 };                 ServiceCreateResponse serviceCreateResponse = await client.Swarm.CreateServiceAsync(serviceCreateParameters);
`

Close issue


HHH-10643 - Add support for foreignKeyDefinition

I am pretty sure this pull request is not perfect and also probably still misses a few things.
However I would like to see support for the @javax.persistence.ForeignKey(foreignKeyDefinition=...) attribute within Hibernate.
Could someone of the more experienced hibernate team take my pull request and finish it? I am not too comfortable with the codebase and also very short on time right now so I would like to leave the remaining work that needs to be done to the core team.
I justed wanted to kick start the implementation work by showing what's kind of necessary to add support for this feature.
A few notes on this pull request
Probably the most interrupting change is that getAddForeignKeyConstraintString now takes the foreignKeyDefinition as second argument. This means each dialect now has to choose if to use the foreignKeyDefinition or generate the foreign key. Please look closely on all the overriden getAddForeignKeyConstraintString methods why I implemented this that way: Some dialects handle the "add constraint " statement differently - e.g. there is a case where the constraintname is set at the end; another case is that the "add constraint" is not even part of the sql. So I think that the decision if to use the foreignKeyDefinition of @ForeinKeyDefiniton should be done within the getAddForeignKeyConstraintString method. Feel free do change that if you can find another solution :smile:
What still needs to be done (at least that's what I think):
For all occurences of setForeignKeyName in
hibernate-core/src/main/java/org/hibernate/boot/model/source/internal/hbm/ModelBinder.java
we also have to call setForeignKeyDefinition
Which means for all the *Sources we also need a .getExplicitForeignKeyDefinition() method - like we have with Source.getExplicitForeignKeyName().

Thanks for the Pull Request. Did you sign the CLA?

@vladmihalcea Yes I signed it already on Apr 15, 2014. But the status is still "Awaiting approval by project lead". Is this OK?

@sebersole can you please approve @mkurz CLA? Thanks

CLA still waiting for approval by project lead...

@sebersole Can you approve @mkurz CLA request? Thanks.

Thanks. I'm going to review your proposal and let you know.

@vladmihalcea Thanks! Looking forward to it.

I added some tests, and changed the Dialect to avoid breaking backward compatibility. This is the new PR for review.

@vladmihalcea Nice! Thanks!


singular name across api call

@jkandasa seem to be ok!

@gbaufake closing this with https://github.com/Kiali-QE/kiali-client-python/pull/2


Documentation Out of Date for Submit Expense Report

The V1 Endpoint for Submitting an expense report does not work as described in the documentation.  I couldn't get it to work.
However, if I re-work the V4 endpoint (e.g. https://{datacenterURI}/expensereports/v4/users/{userID}/context/{contextType}/reports/{reportId}/approve) and change "/approve" to "/submit" and add argument to the header "X-UserID" with the appropriate userName, then the api call works as intended.

@OverlordRon
Hi,
Unfortunately the developer teams responsible for APIs don't monitor this GitHub repo. It would be best to reach out to your SAP Concur contact for this information.


Android 11: Select image from Picture library returned blank data

Bug Report
Problem
file browser blank when choose from picture library
What is expected to happen?
file content data
What does actually happen?
"data":"content://com.android.providers.downloads.documents/document/msf%3A37551"
Information

Select image from Picture library returned blank data
Command or Code

Select image from Picture library
Environment, Platform, Device

Pixel 4, Android 11
Version information

Android Studio: 4.1
Cordova Android 9.0.0
Cordova CLI 10.0.0
Cordova Plugins camera 5.0.0
Operating System windows 10
Checklist

[x ] I searched for existing GitHub issues
[ x] I updated all Cordova tooling to most recent version
[ x] I included all the necessary information above

I got it working right, just because the image format selected was in webp format whichis not working but JPEG


When I put more than ten e-books in md format, 3246 files, into the content folder, and re-ran the command npx quartz build --serve, the following error was reported

Describe the bug
When I put more than ten e-books in md format, 3246 files, into the content folder, and re-ran the command npx quartz build --serve, the following error was reported:
Parsed 3246 Markdown files in 27s
Filtered out 0 files in 2ms
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots and Source
If applicable, add screenshots to help explain your problem.
You can help speed up fixing the problem by either

providing a simple reproduction
linking to your Quartz repository where the problem can be observed

Desktop (please complete the following information):

Quartz Version: [e.g. v4.3.0]
node Version: [e.g. v22.6.0]
npm version: [e.g. v10.8.2]
OS: [e.g. iOS]
Browser [e.g. chrome]

Additional context
Add any other context about the problem here.

do you have a public repository that reproduces it?

Closing due to lack of reproduction

@jackyzha0 the punycode deprecation is from serve-handler actually, I traced this a while back iirc

yeah and rehype-mathjax too


Q: Is ElasticSearch 7 supported?

This is not an issue, just a question. Just wanted to know if ElasticSearch 7 (and specifically 7.7) is supported.

@synhershko Hey, thanks for this plugin. Pinging you to ask if ES 7.x is supported. Thanks in advance!

I could not even build it. Guessing es7 is not supported

Fixed by https://github.com/BigDataBoutique/elasticsearch-repository-swift/pull/11


chore(main): release 10.10.0

:robot: I have created a release beep boop
10.10.0 (2024-12-24)
Features

chat: adding to chat initializes buffer if needed (#567) (8c82ced)

Bug Fixes

adapters: gemini-2.0-flash-exp inline strategy (#568) (a9faa69)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v10.10.0
:sunflower:


cmd/vet: go vet not supporting vendoring

Please answer these questions before submitting your issue. Thanks!

What version of Go are you using (go version)?

1.6

What operating system and processor architecture are you using (go env)?

linux amd64

What did you do?

vendor a package into another. run 'go tool vet -v thepkg/thefile.go'

What did you expect to see?

Any vet reports.

What did you see instead?

Missing reports when compared to having the vendored lib in the gopath like normal. Also see in the output, something like:
vet: ./internal/httpserver/httpserver.go:13:2: could not import github.com/rs/cors (can't find import: COMPANYSPECIFIC/vendor/github.com/rs/cors)
which is not the case if the dependency is in the gopath.
Another user with the same thing on the mailing list and me whining in the thread :)
https://groups.google.com/forum/#!searchin/golang-nuts/vet$20vendor/golang-nuts/uTcfZ15Ks0U/XBOXyfVPAQAJ
Thanks!

I think this might only work at the package level, not files.
/cc @robpike @dsymonds

using without going through tool swallows errors, so is there a way to find out? It seems consistent that the error given from going through tool is what is causing the missing vet reports when not going through tool.

Given just the file, it can't do the imports necessary to do the full job, and lacking the imports will lack the vendored imports.  Try go tool vet -v thepkg. If that doesn't work, call in a vendoring expert.


feat: Add run_ticket to dial all addresses stored in a Ticket

This adds a new iroh::get::run_ticket call which will dial all the
addresses in a ticket concurrently, up to a specified concurrency
limit.  The first established connection is returned.
This allows much better fetching of a ticket, without having to know
how it is constructed and speeds up connecting.
When dialing an attempt is made to first try addresses which are
considered to be on the same subnet as any local address.
This doesn't yet update main.rs to use this.  Probably best as a
separate PR.

cargo-deny is fixed in #890


Do not suggest any realm by default

Fixes #294

Automated message from Dropbox CLA bot
@borisyankov, it looks like you've already signed the Dropbox CLA. Thanks!


Alina: Headless CMS, chapter 1-4

my fork of the exercises repo

Learning objectives

[x] 🥚 Understanding what a content management system is, and why people use it
[x] 🥚 Given an existing CMS installation fill in and publish a new piece of content
[x] 🥚 Perform a simple http call via postman to retrieve a piece of information.
[ ] 🐣 Extend and adapt an existing CMS configuration
[x] 🐣 Perform a http call with filtering via Postman
[ ] 🐣 Perform a http call with "include" via Postman
[x] 🐣 Perform a http POST call to create new data
[x] 🐣 Perform a http PUT call to update existing data
[ ] 🐣 Configuring endpoint permissions (Authentication vs Authorization)
[ ] 🐥 Design a data model from scratch based on user requirements

Study Plan

Week 1

[ ] I have pushed my progress to my fork of exercises repo--Headless CMS

Check-In
I Need Help With:
About /data-model-design. If I want to develop an online  reservations app for Pizzeria,  I can figer out how to write the source code(html, css, js) on my own, that I've been training for. But how to set development environment, like config, lib ... everything that I need. I need  help.
What went well?
group study and exercises
What went less well?
Lessons Learned

query parameter:
fields: [ ]
filters: { }
sort:[ ]
Using the Fetch API
init object from fetch(url, init)

Sunday Prep Work

About /data-model-design. If I want to develop an online reservation app for Pizzeria, where to start? Can someone give me a guide?

this will be covered on Sunday's class. Make sure you come prepare to ask all the questions you have in mind.


Many icons missing?!

There are many icons missing in the applications list. I don't know if it has anything to do with these errors?!

You need to provide more information:

What's your GTK4 theme?
What's your icon theme?
example *.desktop file of an app with missing icon

GTK4 Theme is Catppuccin Mocha
Icon Theme is Morewaita
.desktop file example: https://pastebin.com/iwAAU6qc

If it's relevant, anyrun and wofi are working fine.
Let me know if you need anything else!

Both anyrun and wofi are GTK3. Walker is GTK4.
I've installed the GTK theme and icon theme.. also installed boxbuddy and geary. No problems.
I've changed the way icons are loaded in order to catch errors... can you checkout the latest version, start via terminal and see if there's an icon-related error showing up?
This issue only seems to affect Nix users... on Arch stuff is fine.

Not fixed unfortunately.

I've just pushed an update letting you explicitly set an icon theme... can you try that? I don't know what kinda problem nix and gtk4 have with icons....
icons: {
"theme": "<theme>"
}

Still the same.

Ok, can u do this for me? Put the following into example.c:
#include <gtk/gtk.h>

static void
activate (GtkApplication* app,
          gpointer        user_data)
{
  GtkWidget *window;
  GtkWidget *icon;
GtkWidget *box;

    icon = gtk_image_new_from_icon_name ("org.gnome.Geary");

  window = gtk_application_window_new (app);

box = gtk_box_new (GTK_ORIENTATION_HORIZONTAL, 0);
  gtk_window_set_child (GTK_WINDOW (window), box);
    gtk_box_append (GTK_BOX (box), icon);

  gtk_window_set_title (GTK_WINDOW (window), "Window");
  gtk_window_set_default_size (GTK_WINDOW (window), 200, 200);
  gtk_window_present (GTK_WINDOW (window));
}

int
main (int    argc,
      char **argv)
{
  GtkApplication *app;
  int status;

  app = gtk_application_new ("org.gtk.example", G_APPLICATION_DEFAULT_FLAGS);
  g_signal_connect (app, "activate", G_CALLBACK (activate), NULL);
  status = g_application_run (G_APPLICATION (app), argc, argv);
  g_object_unref (app);

  return status;
}

compile it via: gcc $( pkg-config --cflags gtk4 ) -o example example.c $( pkg-config --libs gtk4 ) .
Run ./example.
This should show the geary icon.

Sure. But I'm getting this.

Yeah, ok... for me this is good news: the issue is not related to Walker. I'm sorry.
Guess you need to ask Nix people why it's broken.
Closing, as it's not related to Walker.

Okay, so maybe @diniamo knows this? Since he packaged it for nix?

It shouldn't have anything to do with the Nix package. I have no idea.
If walker uses the builtin methods of gtk, or some xdg library, I can't help you.

@RoccoRakete you should open an issue with Nix (github? their forum?) and provide the little C example from above.

Yes, I already opened an issue with this discussion linked.

Can you link it here so i can follow? There'll be more users and having a place to point them to would be good.

It's over at the nixOS Discord ID is:<PHONE_NUMBER>556409555


Replace per-tenant GC threads with a thread pool or async

Currently, we launch a thread for each tenant, which wakes up every now and then to GC. That's not great, because:

with a lot of tenants, you get a lot of threads. Number of threads can cause trouble, e.g. we ran into limit on number of threads from the sharded_slab (https://github.com/neondatabase/neon/issues/1609).
if a lot of tenants need to perform GC at the same time, you get a CPU and I/O storm. Better to queue up the work and use a small number of concurrent threads.

Let's change the thread model so that there is a fixed-size pool of GC threads that handle all the tenants. Possibly use tokio async to implement that pooling.

I'll give it a try


Argon Commands resulting in an error

The newest release version of Argon has been throwing this error, taking one glance at the DevForum's it seems to be a prominent issue.
Reinstalling the plugin and reloading VSCode doesn't seem to fix it, either.

Good news! Finally found the issue. It’s related to the embedded C++ file which is only used on Windows to manipulate user’s input. It has something to do with node.js version mismatch, so I’m working on a fix!

Good news! Finally found the issue. It’s related to the embedded C++ file which is only used on Windows to manipulate user’s input. It has something to do with node.js version mismatch, so I’m working on a fix!

Is it possible if you could tell me what the correct version of node.js is?

Unfortunately you would have to downgrade VSC to make it work as it runs its own version of node.js. You can check that by clicking on Code > About Visual Studio Code (macOS)  or Help > About (Windows).
I compiled that C++ file with the latest Electron headers and it fixed the issue on my Windows PC. However before publishing the update I would like to make sure that it won't brake Argon for other users.
Could you try this by yourself? Here is the file.

Sure.

It works perfectly! There aren't any issues with syncing code or such. Only warning/error I got was a version mismatch which didn't restrict me from doing anything at all.

Happy to hear that! Just released 1.2.3 update.


Added 'F' character in straight.h

Hey, i am new to opensource I have add F character in Straight font. If there is any issue plz Let me know.i am ready to contribute
closes #258

@Stunner33, thanks for contributing to our project. Although this issue was assigned to someone else, I am merging your PR. But, for further contributions, please get an issue assigned to yourself before opening a PR. This helps in avoiding confusion. I hope you understand, 😊

@AnshumanMahato I am sorry about that, as i said i am new to open-source so wasn't aware of it...Plz Add hacktoberfest-accepted tag.Thank u🙂

No worries @Stunner33, Just make the requested changes and ping me here. I'll check and merge.

@AnshumanMahato Ok.I have made the changes for about issues and sent pr already so plz check it..if there any correction then let me know

@Stunner33 did you commit those changes?

@Stunner33 did you commit those changes?

I did make the changes, can you please check it once from your end?

@Stunner33 did you commit those changes?

I did make the changes, can you please check it once from your end?

Well, all I have here is that you added the letter F. There is nothing for the changes that I requested after that. You can see the above messages. I have mentioned some changes that I want here.

@Stunner33 did you commit those changes?

I did make the changes, can you please check it once from your end?

Well, all I have here is that you added the letter F. There is nothing for the changes that I requested after that. You can see the above messages. I have mentioned some changes that I want here.

Plz can u re-mention the changes as i can't find ur message for changes

everything is fine... thanks for contributing @Stunner33. 😊 For further contributions, look for missing characters in any fonts. If there is no existing issue open and assigned for that, open an issue for yourself and I will assign that you.

everything is fine... thanks for contributing @Stunner33. 😊 For further contributions, look for missing characters in any fonts. If there is no existing issue open and assigned for that, open an issue for yourself and I will assign that you.

Thank u@AnshumanMahato and sorry for trouble caused. I may have disturb u by asking too many questions..My apologies 🙂

No worries @Stunner33 . Happy to help. That's what we are here for 😊.


Connection closed by certstream-server due to missing ping packets

I discovered that using certstream-js (and any other websocket client), the connection by certstream-server is closed if there are no ping/heartbeat packets sent by the client.
certstream-js doesn't send any and also doesn't auto-reconnect so this effectively stop consumption. I didn't want to file this as an issue against certstream-server since I believe certstream-server/cowboy is behaving correctly. I don't have a workaround right now, just posting this for visibility.

Any news on this?

Hi there, sorry about the delay. I don't have time to implement this unfortunately, but I'll happily review a PR to add these client pings.

PR looks good.

PR looks good.
You can also fix this in your client script:
const client = new CertStreamClient(function(message){
    console.log(message);
});

client.connect();

setInterval(() => client.ws.ping(), 30000);

For me this did not work, I was getting errors:
Connecting to wss://certstream.calidog.io/...
Connection established to certstream! Waiting for messages...

/home/**********/node_modules/ws/lib/WebSocket.js:313
       throw new Error('not opened');
      ^

 Error: not opened
     at WebSocket.ping (/home//**********/node_modules/ws/lib/WebSocket.js:313:13)

PR looks good.
You can also fix this in your client script:
const client = new CertStreamClient(function(message){
    console.log(message);
});

client.connect();

setInterval(() => client.ws.ping(), 30000);

For me this did not work, I was getting errors:
2021-09-09T13:10:39: Connecting to wss://certstream.calidog.io/...
2021-09-09T13:10:39: Connection established to certstream! Waiting for messages...
2021-09-09T13:16:24: /home/**********/node_modules/ws/lib/WebSocket.js:360
2021-09-09T13:16:24:       throw new Error('not opened');
2021-09-09T13:16:24:       ^
2021-09-09T13:16:24:
2021-09-09T13:16:24: Error: not opened
2021-09-09T13:16:24:     at WebSocket.ping (/home/**********/node_modules/ws/lib/WebSocket.js:313:13)
2021-09-09T13:16:24:     at Timeout._onTimeout (/home/**********/**********/certStream.js:171:42)
2021-09-09T13:16:24:     at listOnTimeout (internal/timers.js:554:17)
2021-09-09T13:16:24:     at processTimers (internal/timers.js:497:7)

This happens when your websocket has been closed (or it wasn't open, but from your timestamps I can rule that out).
You can see what is happening by registering these event handlers:
client.connect(); // must happen first for client.ws to be created

setInterval(() => client.ws.ping(), 30000);

client.ws.on('terminate',  (...args) => console.log('terminate', ...args));

client.ws.on('close',  (...args) => console.log('close', ...args));

client.ws.on('error', (...args) => console.log('error', ...args) );

Thanks for the reply. I added the above handlers and now I can see:
2021-09-10T04:02:29: Connecting to wss://certstream.calidog.io/...
2021-09-10T04:02:29: Connection established to certstream! Waiting for messages...
2021-09-10T07:07:13: close 1006

Did anyone resolve this? Using the .ping() method and/or sending a ping packet manually doesn't seem to make a difference with this.
No matter what I get disconnected after ~60s.

@ImLunaHey From what I can tell regular disconnects are fairly standard with certstream. If you use the Python command line tool you'll notice that it disconnect and reconnects often.
I think the missing piece with the node library is the automatic reconnection. I faced this by watching the 'close' event and reconnecting.
client.ws.on('close', function() {
    console.log("CLOSE");
    // reconnect logic
});


Did you use warmup technique?

Thanks for your sharing. I've noticed that the generalization gap between small batch size and large batch size is not the same as described as in the original paper. I'm wondering if this is because of the lack of warmup technique which is always combined in the paper to generate the results. Hope for your clarification.

My guess is "no". I think it is a bit complicated to chain schedulers, so a linear warmup is not straightforward to write. I have some code to do this (its a bit messy) here and here.
This repo is where I started my code. It is much cleaner I think but it is not quite correct for reloading from a saved state.


Adjust FileSlicingCount runtime

Is it possible to set FileSlicingCount at runtime..? I want the user to set FileSlicingCount for specific download. And also the ability to set different chunk no for different downloading.
Same feature for DownloadConcurrentLimit.  I want the user to set DownloadConcurrentLimit and also able to change DownloadConcurrentLimit at runtime.

@maulik9898 You would have to create a custom downloader and override method fun getFileSlicingCount(request: ServerRequest, contentLength: Long): Int?. Then set the custom downloader on the fetch configuration.
    @Override
    public void onCreate() {
        super.onCreate();
        final FetchConfiguration fetchConfiguration = new FetchConfiguration.Builder(this)
                .enableRetryOnNetworkGain(true)
                .setDownloadConcurrentLimit(3)
                .setHttpDownloader(new CustomParallelDownloader())
                .build();
        Fetch.Impl.setDefaultInstanceConfiguration(fetchConfiguration);
        RxFetch.Impl.setDefaultRxInstanceConfiguration(fetchConfiguration);
    }

    public static class CustomParallelDownloader extends OkHttpDownloader {

        public CustomParallelDownloader() {
            super(Downloader.FileDownloaderType.PARALLEL);
        }

        @Nullable
        @Override
        public Integer getFileSlicingCount(@NotNull Downloader.ServerRequest request, long contentLength) {
            //return new count here after checking request and content length
            return super.getFileSlicingCount(request, contentLength);
        }
    }

Note custom FileSlicingCount only works for Parallel Downloaders. Hope this helps.

Ok, so is there any way i can customise this fileslicing option for each and every new download request

@maulik9898 The fileSlicingCount method is called for each download request when started. So you are able to set the slice count for any download request.

Ohh i get it now. Thank you for this awesome library


After 0.31.1, problems caused by type having to be placed in the head

As I mentioned in #901, although the editor no longer reported an error at that time, I did not test the packaging, now I test the packaging and found the packaging error, the problem is the same as the last issue, I used vite + vue-tsc.
Attach an error log:
src/components/roleModal.vue:168:21 - error TS2339: Property 'changeLoading' does not exist on type '{ $: ComponentInternalInstance; $data: {}; $props: Partial<{ width: string; title: string; modelValue:
boolean; asyncClose: boolean; showBtn: boolean; destroyOnClose: boolean; }> & Omit<...>; ... 10 more ...; $watch(source: string | Function, cb: Function, options?: WatchOptions<...> | undefined): WatchStopHandle; }...'.

168     modalRef.value?.changeLoading(false)

Eventually, I had to re-type the function in the corresponding file.
<script lang="ts">
export interface ModalExpose {
  changeLoading: (loading: boolean) => void
}
</script>
<script lang="ts" setup>
...
<script>

I'm not sure there's a better way.

From what I can tell, while this did change recently in vue-tsc, I believe it is intentional with the current script setup design. Any additional named exports are supposed to be in an additional

From what I can tell, while this did change recently in vue-tsc, I believe it is intentional with the current script setup design. Any additional named exports are supposed to be in an additional

@lykl see https://github.com/vuejs/core/issues/4397#issuecomment-1035863245.


re-enable testCustomExecutor

What is the purpose of the change
re-enable testCustomExecutor
Brief changelog
update UT
Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[ ] Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[ ] Run mvn clean install -DskipTests & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
[ ] If this contribution is large, please follow the Software Donation Guide.

Codecov Report

Merging #2917 into master will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #2917      +/-   ##
=========================================
+ Coverage   63.67%   63.7%   +0.02%
=========================================
  Files         577     577
  Lines       25921   25921
  Branches     4536    4536
=========================================
+ Hits        16506   16513       +7
+ Misses       7247    7238       -9
- Partials     2168    2170       +2

Impacted Files
Coverage Δ

...org/apache/dubbo/rpc/filter/ActiveLimitFilter.java
77.77% <0%> (-5.56%)
:arrow_down:

.../apache/dubbo/remoting/transport/AbstractPeer.java
63.04% <0%> (-4.35%)
:arrow_down:

.../exchange/support/header/HeaderExchangeServer.java
59.82% <0%> (-1.71%)
:arrow_down:

...e/dubbo/remoting/transport/netty/NettyChannel.java
56.47% <0%> (-1.18%)
:arrow_down:

...dubbo/remoting/exchange/support/DefaultFuture.java
69.79% <0%> (ø)
:arrow_up:

.../java/org/apache/dubbo/config/ReferenceConfig.java
56.06% <0%> (+0.37%)
:arrow_up:

...pache/dubbo/registry/support/AbstractRegistry.java
82.08% <0%> (+0.74%)
:arrow_up:

...bo/remoting/transport/netty/NettyCodecAdapter.java
54.68% <0%> (+1.56%)
:arrow_up:

...pache/dubbo/remoting/transport/AbstractServer.java
48.45% <0%> (+3.09%)
:arrow_up:

...onfig/spring/extension/SpringExtensionFactory.java
84.61% <0%> (+5.12%)
:arrow_up:

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b000a3...03688c4. Read the comment docs.

@beiwei30 I remove @Ignore,ci pass

it's cool, would you mind add further comments here to explain why it starts working?

@beiwei30
    @Test
    public void testCustomExecutor() {
        Executor mockedExecutor = mock(Executor.class);
        CompletableFuture<Integer> completableFuture = CompletableFuture.supplyAsync(() -> {
            return 0;
        }, mockedExecutor);
        verify(mockedExecutor, times(1)).execute(any());
    }

最终调用 CompletableFuture#asyncSupplyStage
    static <U> CompletableFuture<U> asyncSupplyStage(Executor e,
                                                     Supplier<U> f) {
        if (f == null) throw new NullPointerException();
        CompletableFuture<U> d = new CompletableFuture<U>();
       //确保execute运行一次
        e.execute(new AsyncSupply<U>(d, f));
        return d;
    }


Issue with project name and k8s namespace

The regex for project name is not the same that is allowed for k8s namespaces
Error from server (Invalid): error when creating "deploy/kube/namespace.yml": Namespace "tmp_test" is invalid: metadata.name: Invalid value: "tmp_test": a lowercase RFC 1123 label must consist of lower case alphanumeric characters or '-', and must start and end with an alphanumeric character (e.g. 'my-name',  or '123-abc', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?')

Closed in #37.
Thanks, @gpkc.


fix : check_components_type

Good afternoon,
I found a small bug on the plotter.plot function :
The bug
When plotting a function and selecting a single component, like this :
plotter.plot(pinn,components = 'x1' , fixed_variables = ...)

if the variable name is longer than 1 character, an error is thrown because the function expects a list and gets a string, therefore counting the number of characters in it.
The solution
I added a simple check :
if type(components) is not list:
     components = [components]

I have tested these changes locally, but I would greatly appreciate it if you could review and provide feedback on the solution I used.

Hi! I will have a look and let you know :)

Hello @dario-coscia, I have made the changes, tell me if it suits you.
Have a nice afternoon :)


feat: support for multi page experiments and multiple experiments on the same page

add support for multi-page experiments, i.e., same experiment running across multiple pages
multi-page experiments can be run across every page, so storing those experiments may not make sense, so only experiments that have got at least 500 daily page views (configurable) will be kept, remaining will be ignored

Fixes SITES-23730

:tada: This PR is included in version 1.23.0 :tada:
The release is available on:

v1.23.0
GitHub release

Your semantic-release bot :package::rocket:


Make XRootDSource fork-safe

By setting the appropriate environment variable.
The bug this fixes is a hang in child processes triggered by use of uproot with XRootD files in multiprocessing or concurrent.futures process pools after doing so in the parent process.  An example that triggers the bug is below:
#!/usr/bin/env python
import concurrent.futures
import uproot

file = "root://eospublic.cern.ch//eos/root-eos/cms_opendata_2012_nanoaod/Run2012B_DoubleMuParked.root"

def read(fn):
    print("starting work")
    with uproot.open(fn) as f:
        print("opened file")
        sumw = f['Events'].numentries
    return sumw

print(read(file))

with concurrent.futures.ProcessPoolExecutor(max_workers=1) as executor:
    future = executor.submit(read, file)
    print(future.result())

I couldn't find much documentation on why one would ever not want this option enabled.

Unless you have any objection, I'll take this when the tests pass. It will combine with PR #269 to become uproot 0.5.1.


After some editing, you cannot see flowcharts anymore

Describe the bug
I downloaded project https://github.com/jjansenvr/frank-development-docker and added frank-flow.war to it as described in the README.md. I started it with docker-compose up. When I browsed to http://localhost:8080/frank-flow, I saw a flow-chart. There were two files with Frank configuration XML: Configuration.xml and Configuration_weather.xml. I updated Configuration.xml to add an extra include for file Configuration_martijn.xml and added that file. The file was automatically filled with a Hello World example. But at this point, I could not see any flowcharts anymore. When I selected the mode to see flowcharts, the canvas went empty.
Reporter
Martijn Dirkse
Category
Use the following Tags to categorize your bug report

Explorer
Editor
Flow
Pipe options
Palette
Settings

To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here. (f.e. ladybug report, console error or test adapter with larva test)

I got back my flowcharts as follows. I edited Configuration_martijn.xml outside the Frank!Flow in VSCode. It contained <Configuration name="${displayName}">. I changed it to just <Configuration> and saved it. In the Frank!Flow I saw the old code. I refreshed my browser. Then I saw a flowchart of file Configuration_martijn.xml.

Sounds like this issue: https://github.com/frankframework/frank-flow/issues/1330


Godaddy dns01 support

/kind feature
Support Godaddy as a DNS provider. Godaddy already exist in https://github.com/xenolf/lego/tree/master/providers/dns so it would be nice to have support for it in cert-manager.

/remove-lifecycle stale

So it seems like it will not be supported?

I too am looking for dns01 support on godaddy.

It seems like it will no be supported, it would be really nice to have. Is there any other alternative to generate wildcard certs when using Godaddy?

A webhook needs to be created for any dns provider not already supported by cert manager
https://github.com/jetstack/cert-manager/pull/1084#issuecomment-489060126
Surprisingly, I can’t find one already created for godaddy.
I did find the following guide for automating the dns challenge using the godaddy DNS API, but it would have to be converted to a webhook for Certmanager
https://pbxhacks.com/automating-lets-encrypt-ssl-certs-via-godaddy-dns-challenge/
I don’t have the time to overcome the learning curve for this right now, so I’m continuing to use the http challenge with a certificate for each sub domain.

At this point, due to our inability to test all DNS01 providers that we currently have in our codebase, we are requiring all new DNS01 implementations to be implemented as external DNS01 webhooks, following the example here: https://github.com/jetstack/cert-manager-webhook-example/
We are currently not accepting new DNS01 providers into the core codebase as we don't have a good way to test them reliably - we've not determined an exact process for 'upstreaming' these DNS01 providers into the core codebase yet, but if a provider demonstrates it passes tests, and we are able to find a way to run these tests in our own environment, we'd definitely like to explore defining this process 😄
Hope that makes sense, and hopefully it'll allow for you to develop on your own provider with more confidence (as you can actually configure some end-to-end tests!)

Is anyone interested in collaborating in implementing this webhook? Please DM on the kubernetes slack at saada

For anyone coming after me; here is a great list of webhook implementations for cert-manager - Including GoDaddy: https://github.com/topics/cert-manager-webhook?o=asc&s=stars
Hope that's helpful for someone! 😄

Hope this will help: https://github.com/snowdrop/godaddy-webhook

/remove-lifecycle stale


"Add secret" form improvements

Add label for "name" and "value" inputs
Display validation error when secret already exists in a hub
Change hub select to a list of radio buttons

Please rebase after #1687 is merged. :)

yup, I know!


Scala prompt templating

Following on https://github.com/xebia-functional/xef/pull/143 comments, perhaps a more useful abstraction/templating could be done for a chain of prompts where one prompt response feeds the next prompt.
I have this initial version setup with an example included, let me know your thoughts on this.

Rebased and improved the PR. Ready for review.


1 of 3 calico-node unable to reach calico-typha on EKS 1.23.9

Current Behavior
I have an EKS (v.1.23.9) cluster which I've setup using Terraform.  The aws-node ds has been uninstalled and I am using the tigera-operator Helm chart to install calico (v3.24.0).  The helm chart seems to configure everything correctly, but 1 of the 3 calico-node pods will not become ready (Status: 0/1 Running)
The error I see when describing this pod: Readiness probe failed: calico/node is not ready: felix is not ready: readiness probe reporting 503.
And when I look at the logs, I can see this FATAL event:
2022-08-24 13:47:18.821 [FATAL][2338] felix/daemon.go 532: Failed to connect to Typha error=connection to typhas ([{node-3:5473 node-3 0xc0005ec640} {node-2:5473 node-2 0xc0005ec600}]) failed
When I get all pods with -o wide. You can see that the calico-node pod on node-1 is having the problem. (I substituted the IPs for node-# dns so its easier to follow)
NAME                                       READY   STATUS    RESTARTS   AGE   IP              NODE
calico-kube-controllers-758d8d4948-9nrz4   1/1     Running   0          33m   <IP_ADDRESS>     node-1
calico-node-59vg6                          1/1     Running   0          77m   node-3          node-3
calico-node-nd6jm                          1/1     Running   0          28m   node-2          node-2
calico-node-zvhhx                          0/1     Running   0          2m    node-1          node-1
calico-typha-855c7d89c-fl2pj               1/1     Running   0          28m   node-2          node-2
calico-typha-855c7d89c-s4rwq               1/1     Running   0          77m   node-3          node-3
csi-node-driver-2nnrb                      2/2     Running   0          77m   <IP_ADDRESS>   node-2
csi-node-driver-k9rds                      2/2     Running   0          77m   <IP_ADDRESS>    node-3
csi-node-driver-tfqst                      2/2     Running   0          77m   <IP_ADDRESS>     node-1
tigera-operator-946fd59c5-mtzst            1/1     Running   0          77m   node-1          node-1

It seems that because calico-typha is not running on this node, it is causing the calico-node on that instance to fail to start?
Additional info: I allowed All Traffic between my worker node group to rule out a security group issue between calico-node -> calico-typha.
Perhaps there is something else I need to configure, but I am unsure what that would be.
Expected Behavior
All calico-node pods come up without issue
Possible Solution
I am no expert, but it seems if calico-typha is required on the same host which calico-node is running, then it should be deployed as a daemonset.  Although this could be way off base.  I do know that there is calico-typha service, which calico-node is probably using so deployment should not be a problem...
Context
We are trying to migrate our clusters from self-managed with Kops to EKS with Terraform using the AWS recommended Helm chart
Your Environment
EKS v1.23.9
OS: Amazon Linux 2 (5.4.209-116.363.amzn2.x86_64)
Container Runtime:  containerd://1.4.13
Helm Chart: Latest from https://docs.projectcalico.org/charts (tigera-operator)
Calico version: v3.24.0
My Helm values file looks like this:
# https://projectcalico.docs.tigera.io/getting-started/kubernetes/managed-public-cloud/eks
installation:
  kubernetesProvider: "EKS"
  cni:
    type: Calico
  calicoNetwork:
    bgp: Disabled

Closing this lol.  I figured it out and it WAS a security group issue.  I had allowed All Traffic for the inbound but not outbound.  Once I permitted outbound in the SG, all calico-node pods started.


ValueError: The following model_kwargs are not used by the model: ['token_type_ids']

When I try to use the vicuna-13b-1.1 model, the following problem occurs
import torch
query_wrapper_prompt = SimpleInputPrompt(
    "Below is an instruction that describes a task. "
    "Write a response that appropriately completes the request.\n\n"
    "### Instruction:\n{query_str}\n\n### Response:"
)
hf_predictor = HuggingFaceLLMPredictor(
    max_input_size=2048,
    max_new_tokens=512,
    temperature=0.25,
    do_sample=False,
    query_wrapper_prompt=query_wrapper_prompt,
    tokenizer_name="eachadea/vicuna-13b-1.1",
    model_name="eachadea/vicuna-13b-1.1",
    device_map="auto",
    tokenizer_kwargs={"max_length": 2048},
    # uncomment this if using CUDA to reduce memory usage
    model_kwargs={"torch_dtype": torch.float16}
)
prompt_helper = PromptHelper(max_input_size=2048, num_output=512, max_chunk_overlap=50)
embed_model = LangchainEmbedding(HuggingFaceEmbeddings(model_name="sentence-transformers/all-mpnet-base-v2"))
service_context = ServiceContext.from_defaults(chunk_size_limit=512, llm_predictor=hf_predictor, embed_model=embed_model, prompt_helper=prompt_helper)
index = GPTVectorStoreIndex.from_documents(documents, service_context=service_context)
index.storage_context.persist(persist_dir="./storage")
query_engine = index.as_query_engine(streaming=True, similarity_top_k=4, service_context=service_context)

Exception in thread Thread-14 (generate):
Traceback (most recent call last):
  File "/usr/lib/python3.10/threading.py", line 1016, in _bootstrap_inner
    self.run()
  File "/usr/lib/python3.10/threading.py", line 953, in run
    self._target(*self._args, **self._kwargs)
  File "/usr/local/lib/python3.10/dist-packages/torch/utils/_contextlib.py", line 115, in decorate_context
    return func(*args, **kwargs)
  File "/usr/local/lib/python3.10/dist-packages/transformers/generation/utils.py", line 1267, in generate
    self._validate_model_kwargs(model_kwargs.copy())
  File "/usr/local/lib/python3.10/dist-packages/transformers/generation/utils.py", line 1140, in _validate_model_kwargs
    raise ValueError(
ValueError: The following `model_kwargs` are not used by the model: ['token_type_ids'] (note: typos in the generate arguments will also show up in this list)

You can temporarily make it work this way:
open site-packages/transformers/generation/utils.py
this will be located in the folder wherever your python interpreter is
delete line 1139, 1140, 1141
Remember to keep those lines somewhere, for when you are done with this project and have to restore the package as it was.

You can temporarily make it work this way:
open site-packages/transformers/generation/utils.py this will be located in the folder wherever your python interpreter is
delete line 1139, 1140, 1141
Remember to keep those lines somewhere, for when you are done with this project and have to restore the package as it was.

This worked for me. Thank you, was tearing my hair out.

This worked for me. Thank you!


Integrate CodeCov service to get test coverage reports

The reports should be displayed as comments on every PR after this
branch is merged.

@zupo After reading your short discussion with @zwilias on Slack I understand that you are satisfied with the CodeCov reports in comments. No need to fail the CI, right?

Merging this so we get "the coverage for the base commit".


proposal: support cross compiling

In https://github.com/myitcv/gobin/pull/62, we fixed -run to use runtime.GOOS and runtime.GOARCH.
At the time of writing, cross compiling with gobin does not work. Nor are the cache paths it uses (either globally or module-locally) GOOS/GOARCH-aware.
This issue is a proposal to fully support cross-compiled binaries with gobin.

we will need to refactor the way we go install in order not to trip over the fact that you cannot go install with GOBIN set when GOOS and GOARCH differ from runtime.GOOS and runtime.GOARCH respectively
we will need to introduce GOOS and GOARCH into our cache paths

As part of this we should explicitly say we do not (currently) support build tags, and consequently set GOFLAGS="" in all of our go commands.

We should add support for -tags and GOFLAGS. The more I think about it, the more I'm convinced that actually the right thing to do is also to install everything to a fully obfuscated path.

Per @rogpeppe - we could instead only flip to using an obfuscated path in case GOOS, GOARCH, GOFLAGS etc differ from the "defaults".