Typescript support

Some variables are declared but their values are never read, please remove them
node_modules/react-native-image-zoom-viewer/src/image-viewer.component.tsx(5,3): error TS6133: 'Dimensions' is declared but its value is never read.
node_modules/react-native-image-zoom-viewer/src/image-viewer.component.tsx(8,3): error TS6133: 'PanResponder' is declared but its value is never read.
node_modules/react-native-image-zoom-viewer/src/image-viewer.component.tsx(9,3): error TS6133: 'Platform' is declared but its value is never read.
node_modules/react-native-image-zoom-viewer/src/image-viewer.component.tsx(15,3): error TS6133: 'ViewStyle' is declared but its value is never read.
node_modules/react-native-image-zoom-viewer/src/image-viewer.component.tsx(41,11): error TS6133: 'hasLayout' is declared but its value is never read.
node_modules/react-native-image-zoom-viewer/src/image-viewer.component.tsx(171,11): error TS6133: 'sizeLoaded' is declared but its value is never read.
node_modules/react-native-image-zoom-viewer/src/image-viewer.component.tsx(173,9): error TS6133: 'imageLoaded' is declared but its value is never read.
node_modules/react-native-image-zoom-viewer/src/image-viewer.component.tsx(180,11): error TS2339: Property 'getSize' does not exist on type 'typeof Image'.
node_modules/react-native-image-zoom-viewer/src/image-viewer.component.tsx(188,7): error TS6133: 'error' is declared but its value is never read.
node_modules/react-native-image-zoom-viewer/src/image-viewer.type.ts(2,17): error TS6133: 'ImageURISource' is declared but its value is never read.

tsconfig.json 增加这个配置：noUnusedLocals: false

@wadim yes it would.  it's not a solution.  I just changed over to const ImageViewer = require("react-native-image-zoom-viewer") once I was ready to compile.  If anyone knows of a way around this it would be great.

@wadim @nicomontanari98 figured it out solving another problem: "skipLibCheck": true in tsconfig.json!  👍

@david-cako skipLibCheck is the right way.


 Secrets directory not ignored!

I just wanted to point out that your secrets directory is not ignored. It should be put into a .gitignore, and all sensitive details leaked should be considered leaked (especially your private SSH keys).

I deliberately keep the secrets in the repository, they are encrypted using git-crypt so it's should be fine.


Create Notes_

Required setters and getters

.

Required setters and getters

Hello, what is this pull request for?


Hyperlink buttons raise a bad request error

Using this code
        [Command("button")]
        public async Task ButtonAsync()
        {
            var builder = new ComponentBuilder().WithButton("Hello!", ButtonStyle.Link, emote: null, customId: "hello_button",
                url: "https://github.com/shift-eleven/Alexandra", disabled: false, row: 0);

            await Context.Channel.SendMessageAsync("Buttons!", component: builder.Build());
        }

Upon attempting to send them to a channel, Im getting a bad request error
 Discord.Commands.CommandService[0]
      Command:
      Discord.Commands.CommandException: Error occurred executing "button" for shift-eleven#7304 in Black Rose/bot-test.
       ---> Discord.Net.HttpException: The server responded with error 400: BadRequest
         at Discord.Net.Queue.RequestBucket.SendAsync(RestRequest request)
         at Discord.Net.Queue.RequestQueue.SendAsync(RestRequest request)
         at Discord.API.DiscordRestApiClient.SendInternalAsync(String method, String endpoint, RestRequest request)
         at Discord.API.DiscordRestApiClient.SendJsonAsync[TResponse](String method, String endpoint, Object payload, BucketId bucketId, ClientBucketType clientBucket, RequestOptions options)
         at Discord.API.DiscordRestApiClient.CreateMessageAsync(UInt64 channelId, CreateMessageParams args, RequestOptions options)
         at Discord.Rest.ChannelHelper.SendMessageAsync(IMessageChannel channel, BaseDiscordClient client, String text, Boolean isTTS, Embed embed, AllowedMentions allowedMentions, MessageReference messageReference, MessageCo
mponent component, RequestOptions options)
         at Harley.Modules.GeneralModule.ButtonAsync() in D:\Projects\C# projects\Harley\Harley\Modules\GeneralModule.cs:line 21
         at Discord.Commands.ModuleClassBuilder.<>c__DisplayClass6_0.<<BuildCommand>g__ExecuteCallback|0>d.MoveNext()
      --- End of stack trace from previous location ---
         at Discord.Commands.CommandInfo.ExecuteInternalAsync(ICommandContext context, Object[] args, IServiceProvider services)
         --- End of inner exception stack trace ---
dbug: Discord.WebSocket.DiscordSocketClient[0]
      Rest: POST channels/825360796153544735/messages: 507.73 ms

Full Stack trace
It is noted that the example in the readme works as intended, alongside with the event handler

The issue lies within this part of the docs

Non-link buttons must have a custom_id, and cannot have a url
Link buttons must have a url, and cannot have a custom_id
Link buttons do not send an interaction to your app when clicked

I will add a check to the builder when adding buttons for this. For now just dont pass in a custom Id

Alright, thanks for clarifying this


Admin Portal UI issues when adding a Key Manager

Description
The following UI issues were noticed when trying to add Azure AD as a Key Manager [1].

When following along our documentation [1], point 3 under step 1 mentions to add the well-known URL and click on Import. However, when doing so some of the previously filled fields like Grant Types, Microsoft Graph API Endpoint, Client ID, Client Secret and Key Manager Permission resets. Check the feasibility of retaining those previously filled values in the form as opposed to clearing out those fields by force.

When importing the Well-known URL, some fields get filled automatically. Noticed that the UserInfo Endpoint is not getting picked properly in this scenario. However, this is a required field as per the UI. By checking the well-known url's response, it was noticed that there is a userinfo endpoint available there. Please check if this is a required field or not, if required check why its not getting retrieved.

Under the Connector Configurations section there is a checkbox for Microsoft Graph API Endpoint Version which is not marked as required. However, when checking the codebase, noticed how this is a required field. If this is not checked, there can be validation issues. We need to fix the UI by marking the Microsoft Graph API Endpoint Version as required. Take note that this can be done programmatically by checking the required nature of this field under [2]. This information is already available at this location: keymanagerConnectorConfiguration.required.

Also, UI error message for required fields not being filled properly should be improved. Alert message that appears should ideally show what's missing as opposed to this general error message.

Apart from the above-mentioned UI issues, we need to improve the documentation [1] to overcome the 403 issue that is encountered upon key generation. The fix for that issue is as follows:
After completing [3], need to ensure that all permissions have been granted. One can grant those permissions by clicking on the Grant admin consent for Default Directory button right next to Add a permission button.

[1] https://apim.docs.wso2.com/en/latest/administer/key-managers/configure-azure-ad-key-manager/
[2] https://github.com/wso2-support/apim-apps/blob/support-9.1.74.x-full/portals/admin/src/main/webapp/source/src/app/components/KeyManagers/KeyManagerConfiguration.jsx#L113-L119
[3] https://apim.docs.wso2.com/en/latest/administer/key-managers/configure-azure-ad-key-manager/#step-3-configured-permissions
Steps to Reproduce
Mentioned above
Affected Component
APIM
Version
4.4.0
Environment Details (with versions)
No response
Relevant Log Output
No response
Related Issues
No response
Suggested Labels
No response

Closing this issue as the product level fixes and doc fixes are completed.


feat: port Geometry.Manifold.VectorBundle.Basic

todo:

[ ] FiberBundle.chartedSpace_chartAt error with rw [Trivialization.coe_coe]
[ ] FiberBundle.extChartAt simp couldn't solve goal
[ ] "infer kinds are unsupported in Lean 4" and "unsupported: advanced export style". Link to mathlib code.
[ ] VectorPrebundle.smoothVectorBundle failed to synthesize Trivialization.IsLinear 𝕜 (FiberPrebundle.trivializationOfMemPretrivializationAtlas (toFiberPrebundle a) he)

I'm trying to fix.


TFRS - Unit Test for Scenario 3 Compliance Unit Balance Change from Assessment

Description:
In light of the recent issue found with Scenario 3's 'Compliance Unit Balance Change from Assessment' field, we need a dedicated unit test to ensure that the value in this field is always correctly computed and displayed to the end-users. This test will ensure that any future changes to our codebase won't reintroduce this problem.
Acceptance Criteria:

The unit test should focus on Scenario 3's reporting.
The test must validate that when the organization doesn't have any balance to reduce, the 'Compliance Unit Balance Change from Assessment' should show a zero value.
In the case of Jan-release, report ID 1155, Org name: FS6, the test should confirm that the balance change from the assessment field should describe the actual balance change that will be applied to the account when the report is assessed.
If the field shows any value other than zero in this scenario, the test should fail, alerting the developer of an inconsistency.

Steps:

Initialize a report with properties consistent with Scenario 3, such as report ID 1155, Org name: FS6.
Mock the necessary services, ensuring the organization doesn't have any balance to reduce.
Run the report assessment logic.
Validate that the 'Compliance Unit Balance Change from Assessment' field displays a value of zero.
If it does not, the unit test should throw an error or fail, highlighting the discrepancy.

Note:
Ensure that this unit test runs as part of our regular CI/CD pipeline so that it checks against any future changes made to the system.

Nothing to test on the front end


[QUESTION] How to wrap commands

First check

[x] I used the GitHub search to find a similar issue and didn't find it.
[x] I searched the Typer documentation, with the integrated search.
[x] I already searched in Google "How to X in Typer" and didn't find any information.
[x] I already searched in Google "How to X in Click" and didn't find any information.

Description
How can I wrap a command and extend the options?
I am able to do this via Click but haven't figured out a way to make it work. I want to be able to extend certain commands to give extra options when they are annotated.
Lets say I have a command defined as:
@app.command()
def hi(name: str = typer.Option(..., '--name', '-n', prompt=True, help="Name of person to say hi to"),):
    """ Say hello. """

    print(f"Hello, {name}!")

I can call this via python cli.py hi. Want I want is the ability to wrap the hi function to include a city and state if I wanted. Example:
def from_city(func,) -> "wrapper":
    @wraps(func)
    def wrapper(
        city: str = typer.Option(..., '--city', '-c', prompt=True, help='The name of the city to say hi from'),
        state: str = typer.Option("VA", '--state', '-s', help="The state you are saying hi from"),
    ):
        """ Setup for finding city. """
        # <do some stuff>
        return None
    return wrapper

@app.command()
@from_city
def hi_city(name: str = typer.Option(..., '--name', '-n', prompt=True, help="Name of person to say hi to"),):
    """ Say hello. """

    print(f"Hello, {name}. Welcome from {kwargs['city']}, {kwargs['state']}!")

By adding the @from_city annotation, I want the additional city/state options to be available.
Additional context
I can do this in Click with the following code:
def from_city(func) -> "wrapper":
    @click.pass_context
    @click.option(
        "--city",
        "-c",
        show_default=True,
        help="The name of the city to say hi from",
    )
    @click.option(
        "--state",
        "-s",
        default="VA",
        show_default=True,
        help="The state you are saying hi from",
    )
    @__wraps(func)
    def wrapper(*args, **kwargs):
        # Grab the context and put it in kwargs so the wrapped function has access
        kwargs["ctx"] = args[0]

        return

    return wrapper

@cli.command()
@from_city
@click.option(
    "--name",
    "-n",
    default="~/Downloads/pyshthreading.yaml",
    help="Location on disk to the cf template",
)
def test(*args, **kwargs):
    print(f"Hello, {kwargs['name']}. Welcome from {kwargs['city']}, {kwargs['state']}!")

Is there a way to do this in Typer?

I have a solution for you.
The main problem here is the way Typer knows about command parameters. It uses function signature and type hints. hi_city has one parameter of name and that's what it expects. And you use functools.wraps so the parameters stay the same. To add more you have to modify the function signature to include the parameters you want to reuse in from_city.
I was tinkering how to do that elegantly and I found an article which does exactly that: https://chriswarrick.com/blog/2018/09/20/python-hackery-merging-signatures-of-two-python-functions/
The author created package merg-args: you can install it, you can check out the bottom of the article.
The secondary problem is how to pass the new parameters. You cannot use kwargs, because Typer does not support this. You can use typer.Context (click.Context in disguise) to access them.
I used the mention package and the Context to achieve your goal:
from typing import Callable

import typer
from merge_args import merge_args

app = typer.Typer()

def from_city(
    func: Callable,
) -> "wrapper":
    @merge_args(func)
    def wrapper(
        ctx: typer.Context,
        city: str = typer.Option(
            ..., "--city", "-c", prompt=True, help="The name of the city to say hi from"
        ),
        state: str = typer.Option(
            "VA", "--state", "-s", help="The state you are saying hi from"
        ),
        **kwargs,
    ):
        """Setup for finding city."""
        return func(
            ctx=ctx,
            **kwargs
        )

    return wrapper

@app.command()
@from_city
def hi_city(
    ctx: typer.Context,
    name: str = typer.Option(
        ..., "--name", "-n", prompt=True, help="Name of person to say hi to"
    ),
):
    """Say hello."""
    kwargs = ctx.params
    print(f"Hello, {name}. Welcome from {kwargs['city']}, {kwargs['state']}!")

if __name__ == "__main__":
    app()

ctx.params stores all the parameters that function was invoked with, so name too and you can use it, as you wanted to use **kwargs.

You can actually also use the Typer callback. It will be less obvious what arguments there are but looks like less code and does not require magic like the above solution.
import typer

app = typer.Typer()

@app.callback()
def extras(
    ctx: typer.Context,
    city: str = typer.Option(
        ..., "--city", "-c", prompt=True, help="The name of the city to say hi from"
    ),
    state: str = typer.Option(
        "VA", "--state", "-s", help="The state you are saying hi from"
    ),
):
    ctx.obj = ctx.params
    pass

@app.command()
def hi_city(
    ctx: typer.Context,
    name: str = typer.Option(
        ..., "--name", "-n", prompt=True, help="Name of person to say hi to"
    ),
):
    """Say hello."""
    kwargs = ctx.obj
    print(f"Hello, {name}. Welcome from {kwargs['city']}, {kwargs['state']}!")

if __name__ == "__main__":
    app()

@captainCapitalism thank you for this! I had never heard of merge_args. I believe this will work for our use case. Will close after doing some more testing.

You can actually also use the Typer callback. It will be less obvious what arguments there are but looks like less code and does not require magic like the above solution.
import typer

app = typer.Typer()

@app.callback()
def extras(
    ctx: typer.Context,
    city: str = typer.Option(
        ..., "--city", "-c", prompt=True, help="The name of the city to say hi from"
    ),
    state: str = typer.Option(
        "VA", "--state", "-s", help="The state you are saying hi from"
    ),
):
    ctx.obj = ctx.params
    pass

@app.command()
def hi_city(
    ctx: typer.Context,
    name: str = typer.Option(
        ..., "--name", "-n", prompt=True, help="Name of person to say hi to"
    ),
):
    """Say hello."""
    kwargs = ctx.obj
    print(f"Hello, {name}. Welcome from {kwargs['city']}, {kwargs['state']}!")

if __name__ == "__main__":
    app()

This one wouldn't work for apps that already have a callback

I found a was getting a error from pyflakes with @captainCapitalism 's example code. Removing -> "wrapper" seems to fix the error.
I also found that it didn't work with sub-commands or multiple commands - the commands were not listed correctly. functools.wraps fixes this.
Here's a revised example with two commands:
from typing import Callable

import typer
from functools import wraps
from merge_args import merge_args

app = typer.Typer()

def from_city(
    func: Callable,
) -> "wrapper":  # noqa: F821
    @merge_args(func)
    @wraps(func)
    def wrapper(
        ctx: typer.Context,
        city: str = typer.Option(
            ...,
            "--city",
            "-c",
            prompt=True,
            help="The name of the city to say hi from"
        ),
        state: str = typer.Option(
            "VA", "--state", "-s", help="The state you are saying hi from"
        ),
        **kwargs,
    ):
        """Setup for finding city."""
        return func(ctx=ctx, **kwargs)

    return wrapper

@app.command()
@from_city
def hi_city(
    ctx: typer.Context,
    name: str = typer.Option(
        ..., "--name", "-n", prompt=True, help="Name of person to say hi to"
    ),
):
    """Say hello."""
    kwargs = ctx.params
    print(f"Hello, {name}. Welcome from {kwargs['city']}, {kwargs['state']}!")

@app.command()
@from_city
def bye_city(
    ctx: typer.Context,
    name: str = typer.Option(
        ..., "--name", "-n", prompt=True, help="Name of person to say bye to"
    ),
):
    """Say goodbye."""
    kwargs = ctx.params
    print(
        f"Goodbye, {name}. Welcome from {kwargs['city']}, {kwargs['state']}!"
    )

if __name__ == "__main__":
    app()

I think this is something I can work with.

Ugh, found a problem. I tried adding this to allow the common options to be specified before the command:
@app.callback()
@from_city
def main(
    ctx: typer.Context,
) -> None:
    # ctx.obj = Common(profile=profile, region=region)
    pass

And, while it does allow the from_city options to be specified, they are not recognised by the options in the sub-commands.
For example, this still prompts for city:
$ python3 main.py --city foo hi-city --name bar

As mentioned in https://github.com/tiangolo/typer/issues/405#issuecomment-1191719026 I would also be interested in an elegant solution to this. :)

Here's an addition to @robinbowes code that uses a pydantic model (#1) to make it easy to declare (#2) and obtain the options (#3) in a way that's a little bit more statically typed (#4).  Basically, it avoids having to access the options from a dictionary by name/string. This still feels like too many hoops to jump through, but it feels slightly easier to maintain.  Also, a vanilla dataclass (rather than a pydantic model) might work too, but I didn't go that route.
from typing import Callable

from pydantic import BaseModel
import typer
from merge_args import merge_args

app = typer.Typer()

# 1) define the common options in a pydantic model
class FromCity(BaseModel):
    city: str = typer.Option(
        ..., "--city", "-c", prompt=True, help="The name of the city to say hi from"
    )
    state: str = typer.Option(
        "VA", "--state", "-s", help="The state you are saying hi from"
    )
    class Config:
        arbitrary_types_allowed = True

def from_city(
    func: Callable,
) -> "wrapper":
    @merge_args(func)
    def wrapper(
        ctx: typer.Context,
        # 2) get the TyperOptions for each of the options
        city: str = FromCity().city,  #  <-- here
        state: str = FromCity().state,  #  <-- here
        **kwargs,
    ):
        return func(ctx=ctx, **kwargs)
    return wrapper

@app.command()
@from_city
def hi_city(
    ctx: typer.Context,
    name: str = typer.Option(
        ..., "--name", "-n", prompt=True, help="Name of person to say hi to"
    ),
):
    """Say hello."""
    # 3) Convert the arguments into an object / instance of the pydantic model
    from_city = FromCity(**ctx.params)
    # 4) Access them as attributes of the objects
    print(f"Hello, {name}. Welcome from {from_city.city}, {from_city.state}!")

if __name__ == "__main__":
    app()

@jimkring Which version of python are u using?
I get into some errors with your solution on 3.10 like NameError: name 'typer' is not defined.
But when I comment both of the ctx: typer.Context, lines, It seems working (but of course partially since there is no access to the Context obj)

Here's an addition to @robinbowes code that uses a pydantic model (1) to make it easy to declare (2) and obtain the options (3) in a way that's a little bit more statically typed (4). Basically, it avoids having to access the options from a dictionary by name/string. This still feels like too many hoops to jump through, but it feels slightly easier to maintain. Also, a vanilla dataclass (rather than a pydantic model) might work too, but I didn't go that route.
from typing import Callable

from pydantic import BaseModel
import typer
from merge_args import merge_args

app = typer.Typer()

# 1) define the common options in a pydantic model
class FromCity(BaseModel):
    city: str = typer.Option(
        ..., "--city", "-c", prompt=True, help="The name of the city to say hi from"
    )
    state: str = typer.Option(
        "VA", "--state", "-s", help="The state you are saying hi from"
    )
    class Config:
        arbitrary_types_allowed = True

def from_city(
    func: Callable,
) -> "wrapper":
    @merge_args(func)
    def wrapper(
        ctx: typer.Context,
        # 2) get the TyperOptions for each of the options
        city: str = FromCity().city,  #  <-- here
        state: str = FromCity().state,  #  <-- here
        **kwargs,
    ):
        return func(ctx=ctx, **kwargs)
    return wrapper

@app.command()
@from_city
def hi_city(
    ctx: typer.Context,
    name: str = typer.Option(
        ..., "--name", "-n", prompt=True, help="Name of person to say hi to"
    ),
):
    """Say hello."""
    # 3) Convert the arguments into an object / instance of the pydantic model
    from_city = FromCity(**ctx.params)
    # 4) Access them as attributes of the objects
    print(f"Hello, {name}. Welcome from {from_city.city}, {from_city.state}!")

if __name__ == "__main__":
    app()

How does this perform ? Is it slowing down building the CLI, in comparison to normal functions with normal signatures ?


Add files via upload

Have you read the Contributing Guidelines ?
(Write your answer here.)
Description
(Write your answer here.)
Checklist

[x] I've read the contribution guidelines.
[x] I've checked the issue list before deciding what to submit.
[x] I've edited the README.md and link to my code.

Related Issues or Pull Requests
(Write your answer here.)

@suy1968 Please fetch this repo once again it's says you are behind 23 commits make sure you fetch this and send PR .

Okay

@suy1968 Please fetch this repo once again it's says you are behind 23 commits make sure you fetch this and send PR .

please check i already fetch


[PROF-9742] Package libdatadog v9.0.0 for Ruby

What does this PR do?
This PR includes the changes documented in the "Releasing a new version to rubygems.org" part of the README: https://github.com/datadog/libdatadog/tree/main/ruby#releasing-a-new-version-to-rubygemsorg
(It's also very similar to the v7.0.0 release PR).
It also includes a tiny paper cut fix: it disables the Rake build task which is the default way to package a Ruby gem, since we have our own custom packaging steps in the Rakefile.
Motivation
Enable Ruby to use libdatadog v9.0.0.
Additional Notes
We ended up not packaging the previous release (v8) for Ruby, so we're directly jumping from v7 to v9.
How to test the change?
I've tested this release locally using the changes in https://github.com/DataDog/dd-trace-rb/pull/3627 .
As a reminder, new libdatadog releases don't get automatically picked up by dd-trace-rb, so the PR that bumps the Ruby profiler will also test this release against all supported Ruby versions.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 64.83%. Comparing base (d3f8544) to head (da4b238).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #422   +/-   ##
=======================================
  Coverage   64.83%   64.83%
=======================================
  Files         183      183
  Lines       22359    22359
=======================================
  Hits        14496    14496
  Misses       7863     7863

Components
Coverage Δ

crashtracker
20.37% <ø> (ø)

data-pipeline
51.45% <ø> (ø)

data-pipeline-ffi
0.00% <ø> (ø)

ddcommon
81.23% <ø> (ø)

ddcommon-ffi
74.93% <ø> (ø)

ddtelemetry
53.72% <ø> (ø)

ipc
79.30% <ø> (ø)

profiling
77.05% <ø> (ø)

profiling-ffi
60.09% <ø> (ø)

serverless
0.00% <ø> (ø)

sidecar
28.66% <ø> (ø)

sidecar-ffi
0.00% <ø> (ø)

spawn-worker
50.49% <ø> (ø)

trace-mini-agent
69.12% <ø> (ø)

trace-normalization
97.79% <ø> (ø)

trace-obfuscation
95.74% <ø> (ø)

trace-protobuf
25.64% <ø> (ø)

trace-utils
68.85% <ø> (ø)

This PR appears totally mechanical. Would it be worth adding creating this PR to the release CI action?

Yes, but I haven't had the chance to do it so far :)


nlp.pos('constructor') is returning an error

Uncaught TypeError: Cannot read property 'match' of undefined

if (w.match(/^(over|under|out|-|un|re|en).{4}/)) {
  var attempt = w.replace(/^(over|under|out|.*?-|un|re|en)/, '')
  return parts_of_speech[lexicon[attempt]]
}

thanks scott, i will take a look

Upon further investigation, it's this line https://github.com/spencermountain/nlp_compromise/blob/master/src/pos.js#L190
contractions["constructor"] will return something like function Object() { [native code] }

ah, this is a great one. Think i found all places where I should use hasOwnProperty, thanks a bunch. crash-test it in 0.3.10.
cheers


[BUG] Issue when autosubscribeaudio=false

I want to manually subscribe to remote user's audio using MuteRemoteAudioStream.
This works fine if I set _autosubscribeaudio to true when joining the channel.
However, if I set it to false, I never receive user connection notifications through mRtcEngine.OnUserJoined. As a result, I don't have access to connected users ids and can thus not call MuteRemoteAudioStream on those users.
Am I doing something wrong ?

Is there a particular reason why you want an audio subscription to happen specifically through MuteRemoteAudioStream?
It might just be easier to set _autosubscribeaudio to true when joining the channel and then just use MuteRemoteAudioStream in the OnUserJoined callback. that way the user's still start muted and you still have access to their remote audio tracks.

Not really. I'm actually fine with doing things the way you describe it. It's just that on your website the best practices document suggest to set autosubscribe to false and then to use MuteRemoteAudioStream. Maybe that works on other platforms, but not on WebGL.

from what I can tell in the SDK code, MuteRemoteVideoStream should happen only after the remote user has fully joined the channel and has been setup properly. Subscribing to the video & audio tracks happens automatically in the handleUserPublished callback in agoraChannel.js. Also some demos might still be using using the mute functions from clientManager.js, which currently doesn't have a function named muteRemoteVideoStream. Can you share your code or what demo your using to test?


context override

create a new method called ctx.override! which does what the current ctx.override does today.
And then make the current ctx.override not modify the ctx but pass back a new ctx for the override

done


Separate positional and keyword arguments

Ruby 3.0 will separate positional and keyword arguments, so Ruby 2.7 gives deprecation warnings about code that will become incompatible:
devise-security/lib/devise-security/controllers/helpers.rb:91: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call

This PR fixes such warnings.

Coverage decreased (-4.0%) to 92.851% when pulling<PHONE_NUMBER>b9b8dc3e0de570d0971192173df657 on hnatt:fix-deprecation-warnings into ce11948dbd75ceb83fe645ee24fff4d4d7566cdd on devise-security:master.


pull request for e2e test at 12/23/2016 08:45:09

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Append version number to exported file

It would really help if the exported files had a version number in them, like MR_modpackname_version.mrpack. For all export formats.

39ccc7571ad836ceaf10514b8588f6455fccc34f, I hope that's fulfill your request

Works, thanks!


Webpublisher: Thumbnail extractor

Brief description
Current thumbnail extractor in global is based on specific workflow which should work in different way in webpublisher so easier way is to create webpublisher specific plugin for thumbnail extraction.
Changes

removed webpublisher from global plugin ExtractJpegExr
created new thumbnail extractor in webpublisher host

Notes
I've added image and render families there but if any others should be added there then do it (@kalisp or @64qam).

Task linked: OP-2525 Webpublisher: a special extractor for families


(PUP-7042) Mark strings in file_serving

This commit marks user-facing error and info strings in
lib/puppet/file_server/* for translation.

CLA signed by all contributors.

Closing and reopening to fix Travis.

Closing and reopening to fix CI.

Updated.


Update ext-authz extension provider with more flexibility

Please provide a description for what this PR is for.
And to help us figure out who should review this PR, please
put an X in all the areas that this PR affects.
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[x] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[x] Does not have any changes that may affect Istio users.

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

/test all

@yangminzhu: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
8f81ae6f9994784369d4a630347c32a5b316bbf6
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@incfly @howardjohn I have addressed comments, could you take a look again? thanks.


add_msbuild_path.cmd adds quotes to the PATH environment variable

It is possible to avoid this, for a cleaner result.

Fixed by #2943


Alignment in line breaking mode

Hey,
I've followed the instructions here to implement the line breaking feature in my app. It really suits my needs, but there's a little caveat using a Wrap widget in order to display Tex break parts : some parts are not aligned. Here are some examples :

Is there a way to align the Math widgets in a Wrap ?
Thanks !

@Skyost
Hey!
I am a beginner in flutter, so I couldn't use the author's documentation to implement the line-breaking feature correctly. I have an error: Error: The method 'texBreak' isn't defined for the class 'Math'.
Could you help me? Could you share your code?

@MuratovArthur You have to install the dev version from git (see here).

@Skyost
Hey!
Thank you for helping me!
I've tried to install the dev version from git, but it required to update some other packages. I've updated sdk to sdk: ">=2.6.0 <3.0.0", flutter_svg to flutter_svg: ^0.20.0-nullsafety.3.
After that, I've tried to run my app, but there was an error Error: Too few positional arguments: 8 required, 7 given.             child: selectionControls!.buildToolbar(.
Did you face such an error?)

@MuratovArthur Nope because I'm not using selectionControls.buildToolbar, but the error is only telling you that you're missing an argument at that line.

I finally have some results using the following code :
@override
Widget build(BuildContext context) {
  Math math = Math.tex(
    content,
    textStyle: textStyle.copyWith(color: textStyle.color ?? context.resolveTheme().textColor),
  );

  List<Math> parts = math.texBreak().parts;
  if (parts.length == 1) {
    return parts.first;
  }

  return RichText(
    text: TextSpan(
      children: _handleParts(parts),
    ),
  );
}

List<InlineSpan> _handleParts(List<Math> parts) {
  List<InlineSpan> result = [];
  for (Math part in parts) {
    result.add(WidgetSpan(
      baseline: TextBaseline.alphabetic,
      alignment: PlaceholderAlignment.baseline,
      child: part,
    ));
    result.add(const TextSpan(
      text: ' ',
    ));
  }
  return result;
}

I don't think it's the best way to achieve this, but at least it works.

@Skyost

@MuratovArthur You have to install the dev version from git (see here).

i tried  add the package flutter_math_fork: ^0.3.0 like yours, it needs tuple 2.0.0(which depends quiver 2.0.0) but your pupspec.yaml not contains tuple, also google sign in depends quiver 3.0.0 , i am stuck

@MuratovArthur

@Skyost
Hey!
Thank you for helping me!
I've tried to install the dev version from git, but it required to update some other packages. I've updated sdk to sdk: ">=2.6.0 <3.0.0", flutter_svg to flutter_svg: ^0.20.0-nullsafety.3.
After that, I've tried to run my app, but there was an error Error: Too few positional arguments: 8 required, 7 given. child: selectionControls!.buildToolbar(.
Did you face such an error?)

how do you fix it ?


Make it easier to add a story

Summary
Multiple testers found it difficult to know how to add a story on AutSPACEs and the instructions were quite hidden away. It would be useful to have an obvious add story button on the main homepage that would link to a diagram which takes you through the process and let you click on a registration link, and include other "add story" options throughout the platform.
Deadline
What needs to be done?

[ ] Include an "add story" in nav bar for non-logged in users which takes you to the register or login page
[ ] Include on the register page information a clear user journey in the form of text and a diagram, plus a link to register, as well as clear text saying, "if you are already a user click here to log in"
[ ] Include an obvious "add story" button on the homepage that would lead to the registration page if you are not logged in and the submit experience story if you are
[ ] Include an "add story" button in the "view experiences" section of the website that would lead to the registration page if you are not logged in and the submit experience story if you are
[ ] Include a separate "add story" section on the nav bar for signed in users instead of it being part of a drop down menu

Also interacts with #591, #586, #592


runtime error

2018/10/22 21:06:50 [Recovery] 2018/10/22 - 21:06:50 panic recovered:
GET /check/mapp/... HTTP/1.1
Host: bi:6663
Accept: */*
Accept-Encoding: gzip, deflate
Connection: keep-alive
User-Agent: python-requests/2.8.1

runtime error: invalid memory address or nil pointer dereference
/afs/inf.ed.ac.uk/user/s16/s1620208/.local/go/src/runtime/panic.go:513 (0x42bf28)
/afs/inf.ed.ac.uk/user/s16/s1620208/.local/go/src/runtime/panic.go:82 (0x42b07d)
/afs/inf.ed.ac.uk/user/s16/s1620208/.local/go/src/runtime/signal_unix.go:390 (0x4414a1)
/afs/inf.ed.ac.uk/user/s16/s1620208/.local/go/src/net/textproto/textproto.go:115 (0x60dcf6)
/afs/inf.ed.ac.uk/user/s16/s1620208/Documents/Go/src/github.com/qaisjp/gosign/daemon.go:107 (0x960f6b)
/afs/inf.ed.ac.uk/user/s16/s1620208/Documents/Go/src/github.com/qaisjp/gosign/client.go:109 (0x95fd6c)
/afs/inf.ed.ac.uk/user/s16/s1620208/Documents/Go/src/github.com/qaisjp/cosign-webapi/pkg/api/backend/check.go:44 (0x9696d9)
/afs/inf.ed.ac.uk/user/s16/s1620208/Documents/Go/src/github.com/qaisjp/cosign-webapi/pkg/api/api.go:35 (0x96ac93)
/afs/inf.ed.ac.uk/user/s16/s1620208/Documents/Go/src/github.com/gin-gonic/gin/context.go:108 (0x949142)
/afs/inf.ed.ac.uk/user/s16/s1620208/Documents/Go/src/github.com/gin-gonic/gin/recovery.go:48 (0x95a529)
/afs/inf.ed.ac.uk/user/s16/s1620208/Documents/Go/src/github.com/gin-gonic/gin/context.go:108 (0x949142)
/afs/inf.ed.ac.uk/user/s16/s1620208/Documents/Go/src/github.com/gin-gonic/gin/logger.go:84 (0x959831)
/afs/inf.ed.ac.uk/user/s16/s1620208/Documents/Go/src/github.com/gin-gonic/gin/context.go:108 (0x949142)
/afs/inf.ed.ac.uk/user/s16/s1620208/Documents/Go/src/github.com/gin-gonic/gin/gin.go:361 (0x951afa)
/afs/inf.ed.ac.uk/user/s16/s1620208/Documents/Go/src/github.com/gin-gonic/gin/gin.go:326 (0x951321)
/afs/inf.ed.ac.uk/user/s16/s1620208/.local/go/src/net/http/server.go:2741 (0x680e6a)
/afs/inf.ed.ac.uk/user/s16/s1620208/.local/go/src/net/http/server.go:1847 (0x67d0d5)
/afs/inf.ed.ac.uk/user/s16/s1620208/.local/go/src/runtime/asm_amd64.s:1333 (0x459520)

@findoslice this is the crash. it seems to happen randomly


Revert hive library to fix downstream

Signed-off-by: Jorge Padilla<EMAIL_ADDRESS>Related Issue: https://github.com/stolostron/backlog/issues/26637
Description of changes

Revert hive version replace because it breaks downstream because oof cachito dependency.

/cherrypick release-2.6
/cherrypick release-2.5


chore(x/protorev): use errors.New to replace fmt.Errorf with no parameters

errors.New is specifically designed to instantiate a new error with a given message, without any formatting overhead. I think this should be the preferred method when we do not need to format the error string.
On the other hand, it saves a couple function calls and a comparison on the error path, although this is tiny diff...

Please open a single PR with the desired changes

Please open a single PR with the desired changes

Sorry for this, I thought that would changes too much files in one pr, so I splitted them into 3 prs.
I just chery pick other prs' commits to this pr, thanks for your review

Would you mind updating the PR description to something meaningful?
Would like to know your thought process behind this change before merging?

@PaddyMc updated, thx sir.

Can you fix the tests please? :pray:

Can you fix the tests please? :pray:
@PaddyMc Hi sir, I have fixed the tests. The new ci errors seems that not relevent to this PR, or shall I fix them too?

Hi sir, I have fixed the tests. The new ci errors seems that not relevent to this PR, or shall I fix them too?

Thanks for fixing the tests.
These error are because you've created a PR from a fork and are known errors, I can run the e2e tests locally then I'll merge, thanks for this PR :bow:


Roll Flutter Engine from b6749106a482 to 72e253466fe3 (2 revisions)

https://github.com/flutter/engine/compare/b6749106a482...72e253466fe3
2023-04-22<EMAIL_ADDRESS>Roll Dart SDK from b6de2d42e58d to be6db2b60a41 (2 revisions) (flutter/engine#41416)
2023-04-22<EMAIL_ADDRESS>Roll Skia from 36a6690cd1f1 to 9912500bcca3 (2 revisions) (flutter/engine#41415)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


[Investigation] Investigate Model Registry Backend API

A new backend API is being crafted for Model Registry, the UI team needs to investigate any implications against this.

This is the current API structure. https://github.com/opendatahub-io/model-registry/pull/51#issuecomment-1747581155
We'll need to know a bit more about the UX (late Oct) to be properly able to link things up.

This was an initial recording of API... seems I sparked a reply for linking it 🙂
Carrying that note over here: https://github.com/opendatahub-io/model-registry/pull/51#issuecomment-1754268540
It's just a draft, more changes will happen. But until we see the UI, it's not going to be hugely helpful to really know the API as such.


[openblas] Build error

vcpkg>.\vcpkg install openblas --triplet=x64-windows --editable
Computing installation plan...
The following packages will be built and installed:
openblas:x64-windows -> 0.3.25
Installing 1/1 openblas:x64-windows...
Building openblas:x64-windows...
-- Automatically setting %HTTP(S)_PROXY% environment variables to "<IP_ADDRESS>:33210".
-- Using cached xianyi-OpenBLAS-v0.3.25.tar.gz.
-- Using source at H:/vcpkg/buildtrees/openblas/src/v0.3.25-dc6d649124
-- Using cached strawberry-perl-<IP_ADDRESS>-64bit-portable.zip.
CMake Error at scripts/cmake/vcpkg_extract_archive.cmake:19 (message):
H:/vcpkg/downloads/tools/perl/<IP_ADDRESS> was an extraction
target, but it already exists.
Call Stack (most recent call first):
scripts/cmake/vcpkg_find_acquire_program.cmake:199 (vcpkg_extract_archive)
ports/openblas/portfile.cmake:20 (vcpkg_find_acquire_program)
scripts/ports.cmake:170 (include)
error: building openblas:x64-windows failed with: BUILD_FAILED
Elapsed time to handle openblas:x64-windows: 6 s
Please ensure you're using the latest port files with git pull and vcpkg update.
Then check for known issues at:
https://github.com/microsoft/vcpkg/issues?q=is%3Aissue+is%3Aopen+in%3Atitle+openblas
You can submit a new issue at:
https://github.com/microsoft/vcpkg/issues/new?title=[openblas]+Build+error&body=Copy+issue+body+from+H%3A%2FAlgorithm%2F3D%2Fvcpkg%2Finstalled%2Fvcpkg%2Fissue_body.md

Please see https://github.com/microsoft/vcpkg/issues/30604 for how to report an issue.

@XueXiJinBuShangShang Thanks for posting this issue, please remove this tool H:/vcpkg/downloads/tools/perl/<IP_ADDRESS> and try again.

We hope your question was answered to your satisfaction; if it wasn't, you can reopen with more info.


Fixed URL

Updated readme Checkout our website URL from example.com to goodmorningtech.simonrijntjes.nl

Can you change to develop branch?


DTPPSDK-239: Add new  component

This PR adds a new <BraintreePayPalButtons /> component for Braintree merchants who would like to render the PayPal Buttons using the JS SDK (https://developer.paypal.com/braintree/docs/guides/paypal/client-side).
Code Example
There's a couple things to highlight with the following code example:

Braintree SDK integrations require both server-side and client-side code. A new Braintree auth token is required for each page render. Similar to hosted-fields, we use the data-client-token attribute for accepting this value. This can be server-side rendered directly into the JSX like in the code snippet below. Or it can be added at a later time using the dispatcher feature of the provider.
The paypalCheckoutInstance needs to be made available to the end user. This solution is decorating the actions for createOrder and onApprove with this instance as actions.braintree (ex: actions.braintree.createPayment()).

<PayPalScriptProvider
    options={{
        "client-id": "test",
        "data-client-token": "abc123xyz==",
    }}
>
    <BraintreePayPalButtons
        createOrder={(data, actions) => {
            return actions.braintree.createPayment({
                flow: "checkout",
                amount: "10.0",
                currency: "USD",
                intent: "capture"
            });
        }}
        onApprove={(data, actions) => {
            return actions.braintree.tokenizePayment(data)
                .then((payload) => {
                    // call server-side endpoint to finish the sale
                })
        }
    />
</PayPalScriptProvider>

Storybook Screenshot

Noticed this open PR yesterday and It looks like this has been approved. Any estimate on when this might get merged and cut in a new release? Thanks for building this out, its very helpful!

Noticed this open PR yesterday and It looks like this has been approved. Any estimate on when this might get merged and cut in a new release? Thanks for building this out, its very helpful!

Thanks for the positive feedback @philbirt! We plan to publish a new version to npm tomorrow.


NEXT-12049 Add cache for different json responses

1. Why is this change necessary?
Different Json responses don't use the HttpCache proper as it's defined in the annotation. The header AbstractSessionListener::NO_AUTO_CACHE_CONTROL_HEADER is missing. It's just set when using renderStorefront.
2. What does this change do, exactly?
Add the header before sending result.
3. Describe each step to reproduce the issue or behaviour.

Activate HttpCache
Add time() to JsonResponse of route fronted.detail.switch
Call a switch-url
Notice the timestamp
Refresh the switch-url
See new timestamp
Booooom, http-cache not correct used

4. Please link to the relevant issues (if any).
https://issues.shopware.com/issues/NEXT-12049
5. Checklist

[ ] I have written tests and verified that they fail without my change
[x] I have squashed any insignificant commits
[x] I have created a changelog file with all necessary information about my changes
[x] I have written or adjusted the documentation according to my changes
[x] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

Thank you for creating this pull request @tinect ! Please complete our contribution guidelines, by adding simple testcases which assert that the desired Header gets sent.

Hey @philipgatzka
I'm not familiar with tests that much :-( You call it simple, I call it ¯\_(ツ)_/¯
Any help would be great, cause this header is removed before response 🤔 I don't know how to get into it.

No worries, and sorry if that sounded like I wanted to trivialise writing tests - it's not always easy of course, I meant that more in regard to the needed assertions. You could go with a test like this in the existing SearchControllerTest class for example:
public function testFilterResponseContainsCorrectCacheHeader(): void
{
    $controller = $this->getContainer()->get(SearchController::class);
    $salesChannelContextFactory = $this->getContainer()->get(SalesChannelContextFactory::class);

    $request = new Request();
    $request->request->set('search', true);
    $salesChannelContext = $salesChannelContextFactory->create(Uuid::randomHex(), Defaults::SALES_CHANNEL);

    $response = $controller->filter($request, $salesChannelContext);

    static::assertSame($response->headers->get(AbstractSessionListener::NO_AUTO_CACHE_CONTROL_HEADER), '1');
}

You could use an almost identical test for the other controllers I think :slightly_smiling_face:

This PR was closed due to inactivity. If this change is still important to you, feel free to create a new pull request.
For more information about our contribution guidelines, see https://docs.shopware.com/en/shopware-platform-dev-en/contribution/contribution-guideline


How to use it with react ?

Hello ,
is there a way to use this package for react js and interia .

We only support Vue 2 and 3 as we don't use React ourselves :)


Is there a Heartbeat sensor?

Hi guys,
I have a question or request if its not implemented yet.
On my Samsung S9 next to the camera I have a Fingerscanner that can tell me my heartrate for example.
I want to build a small FitnessApp and I would like to use this heartbeat detection.
Can I somehow get access to this sensor by using this package? OR maybe anyone knows how to access it?
Ty - Stay Safe 😷

I think there is:

iOS
Android

Would you be interested in adding it to React Native Sensors? Would be happy to review a PR :)

Honestly I wouldnt even know how to do it.. :D
So just to be clear the module currently doesnt provide this feature and I would have to tackle some native java code right?

hello? 😟

Yes, the current module does not provide this feature and if you want to enhance react-native-sensors you would need to write Objective-C and Java code. If you just want to solve this in your codebase java code should be enough

@DanielMSchmidt alright ty - do you know if there is a guide or something to this?

I linked two above

Aight thanks again, I am going to close this then.


feat: add hex color code box

Related Issue

fixes: https://github.com/Sanchitbajaj02/palettegram/issues/321
Description

The code adds a HEX color code box such that user can add specific colors to his palettes. It makes it easier instead of dragging pointer to find exact color.
The user selects the specific color box, then either selects a particular color from the Colorpicker or uses a hex color code in the text box given below
Screenshots

https://github.com/Sanchitbajaj02/palettegram/assets/128628820/c6ec3598-1fbb-4865-8987-aed33c6da422

Summary by CodeRabbit

New Features

Enhanced color picker functionality with dynamic color input management.
Simplified color picker rendering based on selected color sections.

Refactor

Improved internal logic for handling color input changes and state updates.

Hi @harini-1597 please acknowledge the changes raised by code review AI as well as undo the commented part at the end of the page

Hi @harini-1597 please give your update on the features that I have requested. If you didn't acknowledge it in 48 hrs, unfortunately I have to close this PR

Hey; addressed the changes and it still works perfectly; you can merge the PR successfully!


Wrong filename for google drive download links

When using google drive download link like this one
https://doc-08-60-docs.googleusercontent.com/docs/securesc/ha0ro937gcuc7l7deffksulhg5h7mbp1/vrjqdumliftd7s3pnk79ihs435nc5i4g/1560355200000/12024208594662412395/*/1wgeEKZDdf1-zS0vD-2YGVpLPzQcw4q3y?e=download
it doesn't recognise the correct file name.
for the above link, it detects file name as  1wgeEKZDdf1-zS0vD-2YGVpLPzQcw4q3y
but what it should be is ChernobylS1R0X.part1.rar
Here is Image

if i download in chrome browser it is able to get correct file name
here is response header i get from chrome network inspect
access-control-allow-credentials: false
access-control-allow-methods: GET,OPTIONS
access-control-allow-origin: *
alt-svc: quic=":443"; ma=2592000; v="46,44,43,39"
cache-control: private, max-age=0
content-disposition: attachment;filename="ChernobylS1R0X.part1.rar";filename*=UTF-8''ChernobylS1R0X.part1.rar
content-type: application/rar
date: Wed, 12 Jun 2019 16:50:17 GMT
expires: Wed, 12 Jun 2019 16:50:17 GMT
server: UploadServer
status: 200
x-goog-hash: crc32c=CygWPA==
x-guploader-uploadid: AEnB2Ur_aNxDKmGnCaaCxUloQTwu-3SZ4k7nyanCvZGE1PgsOzlixHEQd1-CJDfZZMEeKmT8B1VSrFYh99DT9YfwEybd3Ooti4J-c7wZKmdbPNOqPIQ1IJA
Maybe using     content-disposition: attachment;filename="ChernobylS1R0X.part1.rar";filename*=UTF-8''ChernobylS1R0X.part1.rar
Might help..?
And also not able to get size of file
Note : I am using fetch demo with modified url list in ListDownload activity

@maulik9898 looking into this.


Investigate odd logging behaviour

MWE
Steps to reproduce
Add logging statements to an ISI

Expected behaviour
WARN: Non-mintable
Actual output

The culprit turned out to be the #[log] attribute. Contrary to what one might believe, all this does is create a tracing span. It decorates every function called within that span with the debug representation of all of its arguments. I recommend a more fine-grained approach, only displaying the trace level messages if asked to.


Note about auth git github oauth

Page: /setup/ci/jenkins/
Feedback:
I spent some time guessing how connect the basic auth for Jenkins using the github oauth plugin. So if it's possible can you add something like this?:
Github oauth plugin:
If you are using github oauth plugin as auth provider for your jenkins installation is a also possible configure it to work with spinnaker using a github token as a password. (https://github.com/settings/tokens)
Starting in the version 0.29 the github oauth plugin also allows the authentication using the Jekins API token instead a github token.

@stewchen , what say ye? If this works for you, I can add it.

This looks like a good addition. @rafitadiaz did you pass in the github token as $PASSWORD here?
echo $PASSWORD | hal config ci jenkins master add my-jenkins-master \
    --address $BASEURL \
    --username $USERNAME \
    --password # password will be read from STDIN to avoid appearing
               # in your .bash_history

Hi @stewchen, Yes it works with Github personal access token created.
hal config ci jenkins master edit MASTER1 --address $ADDRESS/ --username $Username --password
pass your token when its prompted.

That's really neat, I would definitely call that out.


assets.generate directory in shipping PS should be renamed to generator-assets

Need to do this on a non-dot-release cycle. Next opportunity is 16.0. Hope we don't forget. Again.

Looks like we forgot, @joelrbrandt.  Can you explain why this is necessary/recommended?

The only reason is hygiene. This is low priority for sure.
FWIW, the fact that the copy of generator core that ships inside PS is in a directory named "generator-Builtin" instead of "generator-builtin" or "generator-built-in" really gets my OCD wound up.

On Feb 2, 2016, at 4:12 PM, Cory McIlroy<EMAIL_ADDRESS>wrote:
Looks like we forgot, @joelrbrandt. Can you explain why this is necessary/recommended?
—
Reply to this email directly or view it on GitHub.

welp, it just got three times harder since we now have three delivered plugins that follow the same naming pattern.  This might just be the new normal, joel.  I'll tack this on to the general build story I've got open - but still no guarantees.

thanksfor.trying
On Wed, Feb 10, 2016 at 5:35 PM, Cory McIlroy<EMAIL_ADDRESS>wrote:

welp, it just got three times harder since we now have three delivered
plugins that follow the same naming pattern. This might just be the new
normal, joel. I'll tack this on to the general build story I've got open -
but still no guarantees.
—
Reply to this email directly or view it on GitHub
https://github.com/adobe-photoshop/generator-assets/issues/249#issuecomment-182668726
.


History table

Updates and deletes on the database will have their old data logged onto a history table for auditing and revision of data.
Because of this, it would be a good measure to track the user who made the change onto the cables table, and also log the old one into the history table when it is saved.
This will require an extra field in the cables table, the username of who made the change.
This way the old user will be easily recorded on the history table as well.

moving the auxiliary functions will also be of much use


websockets: don't silently discard early data

Signed-off-by: Bjoern Metzdorf<EMAIL_ADDRESS>Description:
This addresses the current websocket behavior where early data (HTTP BODY) is being silently discarded. Now if a websocket client sends an HTTP BODY alongside a websocket upgrade request, then the data gets forwarded to upstream.
Some clients rely on this behavior to save a round trip.
Risk Level: Low
Small behavior fix
Testing:
Added unit tests and tested manually.
Docs Changes:
N/A
Release Notes:
still TODO

+1 to integration tests - it'd be good to regression test that this doesn't bypass flow control limits (i.e. we won't queue data infinitely at this layer)

@alyssawilk I added a simple integration test. Let me know what you think.

@alyssawilk Yep, you're absolutely right. Thanks for the clarification :) How does it look now?

@rshriram No worries, you assumption was correct. Not sending a body is the standard behavior.


Kingfisher.xcframework: a sealed resource is missing or invalid

Issue Description
Thanks very much for such a great project. I have found an issue using Kingfisher's xcframework, delivered in the release section of the GitHub page.
There is a problem using the provider XCFramework with XCode related to framework signature.

Reproduce

download the xcframework for the latest release
use any dependency management to import the framework into an app
build and run to a device

Ummm, thanks for reporting this. Let me check...

It turn out to be an issue that symlinks are not kept during zipping. Fixed in #2179 and will give it a tag very soon.

The pre-built xcframework has been recompiled and uploaded to the release pages (I did it for the last 3 versions: 7.10.1, 7.10.0 and 7.9.1).
@kimi-santander Any chance to check if it is working for you now? Thanks!

Works like a charm. Thank you very much.

@onevcat the latest version still has the issue 🥲

@AlbGarciam Just tried the zip file of the latest version and it works fine to me.
Any idea or error reason?

Nevermind it is an issue on the way we move the location of the xcframework. Sorry


[MinistryAdmin]  - Update/Delete

add functionality to update ministry admin
add functionality to delete ministry admin

Done


Dockerfile

Hi @relekang
Thanks for the project which looks awesome!
Can you create an image out of the Dockerfile? I cannot on Windows. Will have to try from WSL too.
Regards
Laurent

It is uploaded here on release now: https://hub.docker.com/repository/docker/relekang/graphql-rss-parser
Better late than never i guess 😅


Allow domain with one digit at the beginning or between two dots

This should fix #95

Please change the tests to not use actual domains but some bogus ones


Fix Network Manager connection names for Leap micro

What does this PR change?
This PR changes "Network Connection" into "Network connection 1" and "Network connection 2".
It also installs bind-utils, needed for "host" utility by test suite.

AFAIK this is combustion only. ID we need similar things for cloud-init as well?

it's for combustion only

Current version seems to work, merging.
Fabian Vogt seems to have a better and simpler solution, we can always apply it later on.


feat(windows): print HRESULT hex in debug information

Change-Type: patch
Signed-off-by: Juan Cruz Viotti<EMAIL_ADDRESS>

@hedss VB going wonky again?

@lurch Probably Travis updating after the merge event.


Lack of DenseVLAD part of localization

Thanks for your sharing this impressive work, but it looks only contain the ToDayGAN part and what about the localization part?
Could you share about the DenseVLAD featurization and the details of its implementation?

Hi yes, you can find all the other resources on the main challenge repo here:
https://github.com/tsattler/visuallocalizationbenchmark

Hi @AAnoosheh thanks for your rapid reply.
Unfortunately, I found that the project homepage of DenseVLAD is not accessible any more and there is also rare implement details about it at Github. So I am wondering may be you have some code resource about the DenseVLAD.
Whatever, thanks for your reply~

Oh no, it appears DenseVLAD has fallen off the face of the earth!
I can't find any site or even repo with it

The code was on my school computer from many years ago, so I don't have even that.
You could try messaging the owner of the other repo (Professor Torsten Sattler) to see if he might have a copy left on his disk somewhere


[SPARK-11852] [ML] StandardScaler minor refactor

withStd and withMean should be params of StandardScaler and StandardScalerModel.

Test build #46330 has started for PR 9839 at commit 37fe45d.

Test build #46333 has started for PR 9839 at commit 76ef338.

Test build #46330 has finished for PR 9839 at commit 37fe45d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/46330/
Test PASSed.

Merged build finished. Test PASSed.

Test build #46333 has finished for PR 9839 at commit 76ef338.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/46333/
Test PASSed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/46412/
Test FAILed.

Merged build finished. Test FAILed.

Test build #46413 has started for PR 9839 at commit c6b6d7e.

Jenkins, test this please.

Test build #46415 has started for PR 9839 at commit c6b6d7e.

Test build #46413 has finished for PR 9839 at commit c6b6d7e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/46413/
Test PASSed.

Merged build finished. Test PASSed.

Test build #46415 has finished for PR 9839 at commit c6b6d7e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/46415/
Test PASSed.

Merged build finished. Test PASSed.

LGTM. Merged into master and branch-1.6. Thanks!


Ajive tests

Reference Issues/PRs

What does this implement/fix? Explain your changes.
Adds some tests for the factorization module to increase code coverage.
Any other comments?

Is there some way to see the coverage on PRs?

I feel like we used to have that set up but now we don't. I remember it used to tell you your code coverage change on a PR. I'm not sure what happened to that or how to get it back.

Going to wait to update this branch and merge it until PR #183 is merged to check if the codecoverage bot works

Going to wait to update this branch and merge it until PR #183 is merged to check if the codecoverage bot works

Don't think the code coverage bot is working but correct me otherwise

Going to wait to update this branch and merge it until PR #183 is merged to check if the codecoverage bot works

Don't think the code coverage bot is working but correct me otherwise

Yeah I'm not sure. I also don't know if it only gives an update if you add lines of code that have code coverage themselves. Like since this only added tests I'm not sure it looks at it. I'll try to look more into it later because I'm not sure exactly how it's supposed to behave


Compare with is (vs ==) in enum rule

Similar to #164, this patch avoids calling overridden __eq__() in the modified enum rule after v3.0.2 (due to #575),
so that e.g. pandas (series & dataframes) don't choke on enum rules.

Hi. Thanks.
This one is trickier -- it's not necessarily correct here. Unlike #164, those aren't singletons -- an implementation is free to have 0 == 0 but the two 0's not being the same object.

(So might need to think about what a solution that'd work here would be, but a failing test would be great as well!)

but a failing test would be great as well!

I had long thought of building one, just to weed out some more hurdles when dealing with pandas as instances (it is possible to do that in the end, needs 5-6 interventions in the rules).
Let's hope, now that i managed to teach my quarantined daughter not to interrupt me too much :-), i to serve such a test case.
Would it be ok if it imported pandas?

Let's hope, now that i managed to teach my quarantined daughter not to interrupt me too much :-), i manage to serve such a test case.

Ha!

Would it be ok if it imported pandas?

If need be that's fine, though I suspect it'll be simpler to define a small class with an __eq__ that has the peculiarity that's relevant here? But if it's tons simpler either is fine.


monitoring for capo clusters

User stories

As a giant swarm customer on OpenStack I want the giant swarm monitors my clusters and acts on alerts so that I can rely on my clusters.

Tasks

[x] #725
[x] install PMO and monitoring components on MC
[x] test that new WC clusters get picked up and are scraped by PMO
[x] Push prometheus rules to the openstack app collection
[x] #745
[x] #908
[x] label hubble to be production so that we get paged (https://github.com/giantswarm/config/pull/783)

Currently PMO fails with
Message:               rpc error: code = Unknown desc = Manifest generation error (cached): sh -c konfigure generate --installation=${KONFIGURE_INSTALLATION} --app-name=${KONFIGURE_APP_NAME} --app-destination-namespace=${ARGOCD_APP_NAMESPACE} --app-catalog=${KONFIGURE_APP_CATALOG} --app-version=${KONFIGURE_APP_VERSION} --name=${ARGOCD_APP_NAME} failed exit status 1: Error: Template: main:6:27: executing "main" at <.certificate.monitoring.crtPem>: map has no entry for key "certificate"

Changes made towards this issue:

https://github.com/giantswarm/g8s-prometheus/pull/1325
https://github.com/giantswarm/prometheus-meta-operator/pull/798
https://github.com/giantswarm/capo-mc-bootstrap/pull/44

Prometheus / alert manager / promxy / oauth2 are all running. Last issue that needs to be figured out is an issue in the ingress config.

Internal slack discussion thread: https://gigantic.slack.com/archives/C01BYMF6RN0/p1641927438062600

Last change required: https://github.com/giantswarm/config/pull/736

Consider cancelling the alerts outside of business hours. See example here https://github.com/giantswarm/installations/blob/3bbb7368f79e12005be5fc13815105cf347d2cd4/gauss/appcatalog/default-appcatalog-values.yaml

Note that vault alerts don't work for CAPO now. See https://github.com/giantswarm/prometheus-rules/pull/314

The missing parts for GA will be tracked with this epic. https://github.com/giantswarm/roadmap/issues/1030
Closing this for the beta now.


Interested in a performance comparison with protocol buffer

First of all thanks for making this great library, since it almost always has the "best" performance out-of-the-box. I would be interested to look for a performance comparison between this and protocol buffer library, as there seems not many results of it.

Sorry, I haven't compared them before; I suggest you benchmark them with your actual payload.


for some requests aleph HTTP client prepends invalid bytes to response

example - this is PNG and the correct response starts with -119 80...:
(->> @(http/get "https://whimsical.co/s/images/favicon-96.png?v=e6206c6071d5442388b98afe4b3f4c18")
     :body
     bs/to-byte-array
     (take 20))
=> (-119 80 78 71 13 10 26 10 0 0 0 13 73 72 68 82 0 0 0 96)
(->> @(http/get "https://whimsical.co/s/images/favicon-96.png?v=e6206c6071d5442388b98afe4b3f4c18")
     :body
     bs/to-byte-array
     (take 20))
=> (31 -117 8 0 0 0 0 0 0 0 0 0 32 -1 -33 -119 80 78 71 13)
(->> @(http/get "https://whimsical.co/s/images/favicon-96.png?v=e6206c6071d5442388b98afe4b3f4c18")
     :body
     bs/to-byte-array
     (take 20))
=> (-119 80 78 71 13 10 26 10 0 0 0 13 73 72 68 82 0 0 0 96)
(->> @(http/get "https://whimsical.co/s/images/favicon-96.png?v=e6206c6071d5442388b98afe4b3f4c18")
     :body
     bs/to-byte-array
     (take 20))
=> (31 -117 8 0 0 0 0 0 0 0 0 0 32 -1 -33 -119 80 78 71 13)

Oddly it only happens when query attribute is specified. https://whimsical.co/s/images/favicon-96.png works fine all the time.

@k7d I've tried to perform your request a few times using curl. The server actually replies with different responses: once gzipped, once not. Seems like randomly. Maybe there are a few servers under the load balancer or something. Are you sure that the response should be the same each time?

Right, you can adjust this using pipeline-transform option. Not sure why it's not included by default. For a server, we have :compression? option to include deflator. I don't see any drawbacks not to include this for client pipeline tho'. The only one potential objection: it might break the code if I already use pipeline-transform that adds a decompressor. @ztellman What do you think?

@k7d BTW, you didn't specify Accept-Encoding header, so sending gzipped content is in fact a server failure :)
I've checked clj-http documentation. It says

The client transparently accepts and decompresses the gzip and deflate content encodings.

It also provides :decompress-body? option to switch off Accept-Encoding headers and body decompression on detected Content-Encoding. By default, this option is set to true. If we want to provide the same API, we need to cover those case as well. But once again, we cannot just start including Accept-Encoding: gzip, deflate to any request as it's definitely would be a breaking change for a lot of users. But we can do the following: introduce :decompress-body? option set to false by default, when set to true explicitly using connection-options, - add decompressor and appropriate header. I'll make a PR if there are no objections, @ztellman.

@k7d If you have no objections, I would close this issue and open another one with a feature request for automatic body decompression on a client side (just not to confuse anyone).

https://github.com/ztellman/aleph/issues/444


Last item is clipped

Good day,
@imtoori, When you scroll all the way to the bottom of the list, the very last item is clipped. In this case, it's British Virgin Island. Please see the picture below.
country_code_picker: ^1.4.0

flutter: 1.17.1

@yap-studios  if you could show us your code, then we could see if there is a problem and what is the reason!


[WIP] ppc64le

Signed-off-by: Christy Norman<EMAIL_ADDRESS>

I'm running through these and just getting everything to build atm. Doug did some testing but I don't think he did the whole docker runtime test. I'm working on that this week and next.

the package builds work for centos and ubuntu, but for debian I'm running into:
cd /mnt/libnvidia-container_1.0.0_ppc64el && debuild clean
This package has a Debian revision number but there does not seem to be
an appropriate original tar file or .orig directory in the parent directory;
(expected one of libnvidia-container_1.0.0~alpha.2.orig.tar.gz, libnvidia-container_1.0.0~alpha.2.orig.tar.bz2,                                             libnvidia-container_1.0.0~alpha.2.orig.tar.lzma,  libnvidia-container_1.0.0~alpha.2.orig.tar.xz or libnvidia-container_1.0.0_ppc64el.orig)
continue anyway? (y/n) Use of uninitialized value $ans in pattern match (m//) at /usr/bin/debuild line 951.                                                 Makefile:290: recipe for target 'deb' failed
make: *** [deb] Error 1

Thanks! I was already working on unifying the build process so I only took few bits from this PR, I hope you don't mind.
It should build fine on PPC64 now, for example the following gives you the latest release for Xenial:
make docker-ubuntu:16.04 WITH_LIBELF=yes TAG=alpha.3 DISTRIB=xenial

Not at all. That's great news @3XX0. I'll try this out!

@3XX0 I built a stretch, centos7, and the ubuntu 16.04 packages. ✔ ✔ ✔


Sonarr media request wont change to processing/available (sonarr v4)

Description
After requesting a show, it gets succesfully pushed to sonarr and downloaded. It is then available in Jellyfin, as anticipated, but never changes to "processing" (when downloading) or "Available" when available.
Version
1.7.0
Steps to Reproduce
Request a show, wait for it to download.
Screenshots
No response
Logs
No response
Platform
desktop
Device
lenovo notebook
Operating System
windows 11
Browser
firefox
Additional Context
No response
Code of Conduct

[X] I agree to follow Jellyseerr's Code of Conduct

Can you hop onto discord. This is a configuration issue and ill help you fix it. We dont really provide support on issues as its hard to follow through

Solution: turn on season folders. I'm closing this issue


[gradle] blade.servicebuilder works well

Just started reviewing :) :octocat: Sent from GH.

Merged here https://github.com/rotty3000/blade/pull/127 Thanks Andy! :octocat: Sent from GH.


🐝 Fix editor toolbar link focus issues.

When the toolbar is toggled into link mode the link input field should always focus, however this only happens on the first time which leads to issues with mobiledoc having focus but not the range.
This fix means that the toolbar always focuses.
Closes: https://github.com/TryGhost/Ghost/issues/8195

I don't understand why this is failing the image uploading tests, it has:
commit e87762c7236078778aceb48ed27a7be98df3c700
Author: Kevin Ansfield<EMAIL_ADDRESS>Date:   Fri Mar 17 19:13:38 2017 +0200

    <U+2705> fix broken gh-image-uploader tests

as a previous commit.

I don't understand why this is failing the image uploading tests, it has:
commit e87762c7236078778aceb48ed27a7be98df3c700
Author: Kevin Ansfield<EMAIL_ADDRESS>Date:   Fri Mar 17 19:13:38 2017 +0200

    <U+2705> fix broken gh-image-uploader tests

as a previous commit.

I don't understand why this is failing the image uploading tests, it has:
commit e87762c7236078778aceb48ed27a7be98df3c700
Author: Kevin Ansfield<EMAIL_ADDRESS>Date:   Fri Mar 17 19:13:38 2017 +0200

    <U+2705> fix broken gh-image-uploader tests

as a previous commit.

Sounds like Travis' cache has got mixed up again. I've cleared and restarted, if it doesn't work now I have no idea what's going on 😅


Detect absence of fenv.h in CMake

I realized I was only avoiding redundant checks when fenv.h is present when I really wanted to honor the absence of fenv.h in cases that previously assumed its presence. (#1571 )

Input file lines of the form “#cmakedefine01 VAR” will be replaced with either “#define VAR 1” or “#define VAR 0” [depending on whether VAR is set in CMake to any value not considered a false constant].

https://cmake.org/cmake/help/v3.1/command/configure_file.html

This can also be overridden by users by passing -DCPPUTEST_HAVE_FENV=<value> on the command line or with set(CPPUTEST_HAVE_FENV <value> CACHE BOOL "Enable IEEE754 extension") before including CppUTest.

In the past, we've always used a construct like this:
/* Do we use Standard C or not? When doing Kernel development, standard C usage is out. */
#ifndef CPPUTEST_USE_STD_C_LIB
#ifdef CPPUTEST_STD_C_LIB_DISABLED
#define CPPUTEST_USE_STD_C_LIB 0
#else
#define CPPUTEST_USE_STD_C_LIB 1
#endif
#endif
We can set the variables either thought a value from outside or through a DISABLED define. In the code, we prefer to use #if instead of #ifdef as the #if catches more cases (it fails when not set).
Perhaps that should be done for FENV also ?

I'm not sure I follow. This change switches from #ifdef to #if. The only remaining #ifdef is here where I do what you describe: if a value isn't provided one is deduced.

I was thinking whether we can make this #if block consistent with the other #if by having it the same way and having a DISABLED flag, then you can pass the DISABLED flag. Maybe also move the compiler checking then out of the #if block and let that set the DISABLED flag as the compiler checking should eventually go away as it ought to be done by CMake or automake

gotcha. that makes sense. thanks for the explanation.

Nevermind. I'm still confused. It sounds like you want me to add a DISABLE macro used to set the HAS macro when it isn't set? Why not let the user pass the HAS macro directly (as in my current implementation)?

My comment was mostly to make it more consistent with the other #if blocks in the CppUTestConfig.h (like the one I copy pasted related to Standard C. In this way, you CAN set the CPPUTEST_USE_FENV via the CMake/Automake file but you can also pass a -DCPPUTEST_FENV_DISABLED flag (which might be used by the Makefile templates that also still exist).
Then the second suggestion was to then pull out the compiler checking and put it before the #if block that would look the same as the other #if blocks. The compiler checking will eventually need to go because auto-detecting via CMake/Automake is likely the way to go. The compiler checks could then set the CPPUTEST_FENV_DISABLED so that it will be picked up by the #if block... when it wasn't set yet.
If you think it is a bad idea (I'd be interested to hear why) or rather just merge as is, that is also ok. I'll probably refactor it later sometime when doing a consistency check on the CppUTestConfig.h

I think I've made the change you're asking for. Let me know what you think.

Yes, exactly. Now the compiler checking is already separated and can be perhaps thrown away at some point. And the #if is consistent with how it is done in other places. Thanks!

I will likely take a bit more time on the other CMake commits. While I wasn't paying attention, the TravisCI build stopped because we used all the credits (stupid company!). Now I understand also why earlier we merged some PRs that should have been caught by the automated build. So, I want to try to migrate that asap to something else so that your changes are covered by the automated build.

How's the CI effort going? Is there anything I could do to help?

Oh, this one needs an update also still due to conflict. I think I'm ready to merge it.

Coverage remained the same at 98.515% when pulling 885f6876f1ee6855e7386b94c3e23d727c42dc70 on thetic:fenv into a521a90d35ba267089f6bb1fd28c754f9f4a04b9 on cpputest:master.


how to drag one corner of the cube?

hi,is there an example to drag the corner of the cube?
or how to change a cube to a pyramid by dragging four corners of the top of the cube?
please help

I haven't used this old version of Deform in forever, but I think you could do it with a Taper deformer. However I'd recommend trying out the newer version of Deform. The taper deformer will definitely work for that, or you can try out the lattice deformer on the develop branch


chore(deps): upgrade dev dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-dev-dependencies-k8s-25-main" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 2749

Questions ?
Please refer to the Backport tool documentation


Add more test assertions for the component functionalities

The snapshot test is good for asserting the styling changes.
Nevertheless, I think it would be helpful if we add another test assertion this href property to signal the developers that it's something that matters in this component.
Originally posted by @zainfathoni in https://github.com/kawalcovid19/wargabantuwarga.com/pull/506#discussion_r679630513

Can I help with the testing? @zainfathoni is this something like this? https://stackoverflow.com/questions/57827126/how-to-test-anchors-href-with-react-testing-library

Can I help with the testing? @zainfathoni is this something like this? https://stackoverflow.com/questions/57827126/how-to-test-anchors-href-with-react-testing-library

Yes, exactly. We have exactly the same implementations across our test scenarios, but they're not implemented in all of them.
Therefore, please help us to implement them, especially in the tests where we're only relying solely on the snapshots.
Thanks, @rubiagatra! 🙏


Blacklining while tokenizing strings

I think it would be extremely helpful if we'd have a way to do blacklining on case classes, or collections to see which of the parameters are different. For example
case class Hello(arg: String)
when tokenizing two strings and applying blacklining we'd have something like this:
Hello("World") > Hello("Everyone")

Just read this article https://blog.softwaremill.com/human-readable-case-class-diffs-c707e83e08a2 and this is exactly what I was proposing. I'll give this a try, but I'd have to add https://github.com/softwaremill/diffx as a dependency


sdspi_host: bugfix The clock may be sent out before the bus that was used immediately before is released. (IDFGH-6024)

If the SPI bus is shared between SDSPI and TFT, etc., and the SPI bus is used alternately, it may not work correctly in some cases.
( For example, #6510 )
It makes sense to do go_idle_clockout after running spi_device_acquire_bus.
In the unmodified state, go_idle_clockout would be run with other devices CS-asserted, which would result in a loss of control.

Thanks for your contribution.

sha=cd5d30b56a13b8f0933e8879be1f97724a88004a

Thanks for your contribution again, changes merged with https://github.com/espressif/esp-idf/commit/8bb95150bf2a4402e9bd91620cefbaefa8655882.


Avoid using throwing queries with expect: no-expect-get-by-query

Problem
According to the cheatsheet, getBy, getAllBy are queries that throw an error if there are no matches. Thus, it doesn't make sense to use expect with a query that throws:
expect(getByText("foo")).toBeInTheDocument()

I don't know if that's a thing but I'm more used to use:
getByText("hello")
// OR
expect(queryByText("foo")).toBeInTheDocument()

Solution
The rule (let's call it no-expect-throwing-query but I'm not sure of that name) would prevent getBy and getAllBy to be used with expect as they already throw an error.
Valid cases:
// ✅ Valid
getByPlaceholderText("foo")
expect(queryByText("foo")).toBeInTheDocument()
expect(queryAllByText("foo")).toHaveLength(3)
getAllByTitle("foo")

Invalid cases:
// ❌Invalid
expect(getByPlaceholderText("foo")).toBeInTheDocument()
expect(getAllByText("foo")).toHaveLength(3)

const foo = getByText("foo")
expect(foo).toBeInTheDocument()

Nice, this is recommended in testing library doc too so it would definitely be a good addition.
Anyway, there are couple of examples in your invalid cases I don't understand:
expect(findByText("foo")).not.toBeNull()
Why is this one wrong? There is no alternative in this case for async queries.
expect(findAllByText("foo").toHaveLength(3)
And this one? Again, there is no alternative for async queries.
So I think findBy variants are out of the scope of this issue as there is no alternative, and the point of this it's just getBy vs queryBy.

Yeah, true. I updated the comment!

Could, everything lgtm now! Do you want to take care of this one? I'll try to build something for #20 meanwhile.

Sure! 🙂

FYI: my team and I started recently to also implement some eslint rules for RTL. In fact we have one that basically solves this problem
https://www.npmjs.com/package/eslint-plugin-testing-library-react
@Belco90 would you be open if we contribute to your list of rules, so that we deprecate our package? WDYT?

Hey @emmenko! Absolutely, I'll be more than happy if you contribute to this plugin with that rule and even collaborate together in the future with more rules. The only thing is I see your plugin is focused in just react, but the rule should be generic enough to work also with dom, vue and angular for this plugin, which I think it already is but we would have to double check.
I'm not sure how to proceed from here, maybe @thomlom can tell us how far he got the rule so we can get it working together with your rule implementation?

Sure thing. Let me know if we have the green light to make a PR with our rule.

Of course! There is no better way to review the rule being included here for sure.

I haven't done nothing yet @Belco90, so you can open a PR @emmenko 🙂
Thanks for contributing!

I opened a PR with the new rule.


Is Crypto threadsafe?

Can I use single instance of Crypto in my whole application?

Provided the KeyChain you pass to is thread safe, it should be thread safe.

Is SharedPrefsBackedKeyChain thread safe?

I just noticed a bug in SharedPrefsBackedKeyChain that makes it not completely thread safe. I'm going to put up a fix for it.

Is SharedPrefsBackedKeyChain thread safe now?

bump


🐞 - ERROR Error: StaticInjectorError(AppModule)[IntersectionObserverService -> ElementRef]

Which @taiga-ui/* package(s) are the source of the bug?
Don't known / other
Please provide a link to a minimal reproduction of the bug
https://stackblitz.com/edit/angular-g4gttt
Description

Angular version
12
Taiga UI version
2.27
Which browsers have you used?

[X] Chrome
[ ] Firefox
[ ] Safari
[ ] Edge

Which operating systems have you used?

[X] macOS
[ ] Windows
[ ] Linux
[ ] iOS
[ ] Android

That is most likely an issue with StackBlitz and disabled Ivy, avatars work fine on my pet project with the same versions.


codis-fe Group正常，但是仍然显示OUT OF SYNC 状态

Is this a regression?
Yes
Description
复现步骤：
停止主节点或从节点后，立即重启，OUT OF SYNC 状态不会消失。即便在codis-fe页面上手动执行 slaveof 命令，也不会消失

Please provide a link to a minimal reproduction of the bug
No response
Screenshots or videos
No response
Please provide the version you discovered this bug in (check about page for version information)
No response
Anything else?
No response

目前已经解决了


Segmented response for GET request with transfer-encoding: chunked

Whenever attempting to GET a resource, on the response assembly, gentlemen invokes EnsureResponseFinalized, which works perfectly for the majority of use cases.
However, when the response uses a transfer-encoding: chunked strategy, the response should only be finalized once all chunks have been processed.

This should be fixed via #21.


ability to change colors on continuous values

Use a colormap entry to define two colors: for each end of values.

related to #32

Just wanted to voice my support for this feature. When showing multiple maps side-by-side (but highlighting a different gene activity feature, for example), it can look strange for the maps to look so similar... ability to choose colors would help this. Thank you

fixed a while ago


Remove coverage via shortcut key broken

Describe the bug
Pressing Ctrl+Shift+7 Displays coverage
Pressing Ctrl+Shift+0 Does not remove coverage
Steps to reproduce:

Go to covered file
Press Ctrl+Shift+7  - Coverage appears
Press Ctrl+Shift+0  - Coverage remains
Open command pallet. Select to remove coverage. Coverage is removed

Expected behaviour
When pressing Ctrl+Shift+0 coverage should be removed
Desktop (please complete the following information):

OS: Windpws 10
Extension Version: 2.3.0
VSCode Version: 1.30.2 (system setup)

@AlbertoBN thanks for submitting an issue! The shortcut display and remove seems to be working for myself (see picture and webm below) can you check your keybindings and make sure they are still set for the extension?

Screencast from 2019-02-16 01:06:55 PM.zip

Hi,
Just a quick update. The keybindings are correct.
I will check the log later today.
However what I did discover for now is that The binding for "remove watch" dies the trick. BTW I also checked this on a fresh install with fewer extensions and had the same problem. Will follow up with the log

Interesting fact... I am using Omnisharp, .Net test explorer and Coverlet .net tool to produce the coverage

So I checked the log and there was nothing different from yours.
[1550999660877][coverageservice]: READY
[1550999660877][coverageservice]: RENDERING
[1550999660878][renderer][section file path]:
[1550999660879][coverageservice]: READY
However!!!! apparently on Windows 10 with VSCode ctrl+shift+0 cannot be set or called... which is mind boggling . So I set it to ctrl+shift+backspace and it works like a charm!

One final note... if watch is not set and remove watch is selected then this little baby pops up

[2019-02-24 11:29:09.646] [exthost] [error] TypeError: Cannot read property 'dispose' of undefined
at CoverageService.dispose (C:\Users\Alberto.vscode\extensions\ryanluker.vscode-coverage-gutters-2.3.0\out\src\coverage-system\coverageservice.js:37:30)
at Gutters.removeWatch (C:\Users\Alberto.vscode\extensions\ryanluker.vscode-coverage-gutters-2.3.0\out\src\extension\gutters.js:66:30)
at vscode.commands.registerCommand (C:\Users\Alberto.vscode\extensions\ryanluker.vscode-coverage-gutters-2.3.0\out\src\extension.js:28:17)
at e._executeContributedCommand (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:485:959)
at e.$executeContributedCommand (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:486:443)
at t._doInvokeHandler (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:644:118)
at t._invokeHandler (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:643:744)
at t._receiveRequest (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:642:322)
at t._receiveOneMessage (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:641:155)
at c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:638:960
at c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:38:994
at e.fire (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:44:113)
at a (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:170:213)
at Socket.f._socketDataListener (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:170:434)
at Socket.emit (events.js:182:13)
at addChunk (_stream_readable.js:279:12)
at readableAddChunk (_stream_readable.js:264:11)
at Socket.Readable.push (_stream_readable.js:219:10)
at Pipe.onread (net.js:636:20)
extension.removeWatch

Which is harmless albeit annoying.

@AlbertoBN thanks for all the extra info! keybindings are my bane as I can never get exactly the right ones to please everyone / every operating system. I have added a fix to the 2.3.1 release for the harmless annoying error 4298597cba57e73cd22d3bf6aaf5edf6cea54a00.

On a final note .... 3 bugs caught with your visualization of coverage. So thank you!

@ryanluker
It seems that "Ctrl+Shift+0" is not supported by VSCode on windows. After I run the command Developer: Toggle Keyboard Shortcuts Troubleshooting, the log shows VSCode can not detect the "Ctrl+Shift+0".

log
[2021-03-22 20:06:40.941] [renderer7] [info] [KeybindingService]: / Received  keydown event - modifiers: [ctrl], code: ControlLeft, keyCode: 17, key: Control
[2021-03-22 20:06:40.941] [renderer7] [info] [KeybindingService]: | Converted keydown event - modifiers: [ctrl], code: ControlLeft, keyCode: 5 ('Ctrl')
[2021-03-22 20:06:40.942] [renderer7] [info] [KeybindingService]: \ Keyboard event cannot be dispatched in keydown phase.
[2021-03-22 20:06:40.966] [renderer7] [info] [KeybindingService]: / Received  keydown event - modifiers: [ctrl,shift], code:  ShiftLeft, keyCode: 16, key: Shift
[2021-03-22 20:06:40.966] [renderer7] [info] [KeybindingService]: | Converted keydown event - modifiers: [ctrl,shift], code: ShiftLeft, keyCode: 4 ('Shift')
[2021-03-22 20:06:40.966] [renderer7] [info] [KeybindingService]: \ Keyboard event cannot be dispatched in keydown phase.
[2021-03-22 20:06:41.082] [renderer7] [info] [KeybindingService]: / Received  keydown event - modifiers: [ctrl,shift], code: Digit7, keyCode: 55, key: &
[2021-03-22 20:06:41.082] [renderer7] [info] [KeybindingService]: | Converted keydown event - modifiers: [ctrl,shift], code: Digit7, keyCode: 28 ('7')
[2021-03-22 20:06:41.083] [renderer7] [info] [KeybindingService]: | Resolving ctrl+shift+7
[2021-03-22 20:06:41.083] [renderer7] [info] [KeybindingService]: \ From 1 keybinding entries, matched coverage-gutters.displayCoverage, when: no when condition, source: user extension ryanluker.vscode-coverage-gutters.
[2021-03-22 20:06:41.174] [renderer7] [info] [KeybindingService]: + Storing single modifier for possible chord shift.
[2021-03-22 20:06:46.653] [renderer7] [info] [KeybindingService]: / Received  keydown event - modifiers: [ctrl], code: ControlLeft, keyCode: 17, key: Control
[2021-03-22 20:06:46.653] [renderer7] [info] [KeybindingService]: | Converted keydown event - modifiers: [ctrl], code: ControlLeft, keyCode: 5 ('Ctrl')
[2021-03-22 20:06:46.654] [renderer7] [info] [KeybindingService]: \ Keyboard event cannot be dispatched in keydown phase.
[2021-03-22 20:06:46.690] [renderer7] [info] [KeybindingService]: / Received  keydown event - modifiers: [ctrl,shift], code: ShiftLeft, keyCode: 16, key: Shift
[2021-03-22 20:06:46.691] [renderer7] [info] [KeybindingService]: | Converted keydown event - modifiers: [ctrl,shift], code: ShiftLeft, keyCode: 4 ('Shift')
[2021-03-22 20:06:46.691] [renderer7] [info] [KeybindingService]: \ Keyboard event cannot be dispatched in keydown phase.
[2021-03-22 20:06:47.145] [renderer7] [info] [KeybindingService]: + Storing single modifier for possible chord shift.

Maybe you should set other shortcut keys for windows.
    "keybindings": [
      {
        "command": "coverage-gutters.removeCoverage",
        "key": "ctrl+shift+0",
        "mac": "shift+cmd+0",
        "win": "shift+cmd+backspace",
      }

@Krysl Interesting! I didn't know about this feature to set keybindings per OS...
I made a new ticket here for that: https://github.com/ryanluker/vscode-coverage-gutters/issues/299

@Krysl thanks for the suggestion on using backspace, this will be in the 2.8.1 release! https://github.com/ryanluker/vscode-coverage-gutters/issues/299


fix: escape original_content

str:gsub cannot correctly handle original_content if it contains certain Lua special symbols.
For example:
package main

import "strings"

func main() {
	strings.Replace("https://login.xxx.com/query?redirect=https%3A%2F%2Fxx.com", "%2F", "/", -1)
}

The problematic symbols are %2 and %3.
Let's fix this.

LGTM! There are some code conflicts that need to be resolved.


Filter for selecting date wrong width

Description
The date Pup-up for selecting a release date has a wrong width.
Version
1.5.0
Steps to Reproduce

Go to Movies or Series
Press 'Active Filters'
Select A From or To date

Screenshots

Logs
No response
Platform
desktop
Device
PC
Operating System
Windows 10
Browser
Brave
Additional Context
No response
Code of Conduct

[X] I agree to follow Overseerr's Code of Conduct

:tada: This issue has been resolved in version 1.8.0 :tada:
The release is available on:

v1.8.0
GitHub release

Your semantic-release bot :package::rocket:


occ map coordinate popup has confusing beahviour

https://www.gbif.org/occurrence/map?has_coordinate=true&has_geospatial_issue=false&taxon_key=2972841&geometry=POLYGON((2.62916 48.59526,18.36703 50.45403,7.94373 55.93384,2.62916 48.59526))&geometry=POLYGON((9.41045%2044.80176,16.26117%2044.49212,15.22986%2048.39408,9.41045%2044.80176))
no matter how many times i click "Yes hide them" the popup lingers.
The behaviour of this popup has changed.
It used to only show if you looked at the map and hadn't specified anything about geometry or weather to include/exclude suspicious data. Not it simply shows always and you cannot close it.

For what it's worth, I don't get the popup at all with that query on Firefox.

Thanks - I have a feeling it is erratic and depends on how you navigated there


Create Core Functionalities for Messages API

@chinzou any specific fields or table template ?

Hi @mohsenuss91 , There is a draft data model for Messages API here: https://docs.openemp.org/en/latest/about/core/#data-model
but I'd love to see a suggested approach :)

OK @chinzou . I need access to push.

Hi @mohsenuss91 , There is a draft data model for Messages API here: https://docs.openemp.org/en/latest/about/core/#data-model
but I'd love to see a suggested approach :)

@chinzou  it's done based on this draft data model check out https://github.com/mohsenuss91/openemp-api-message

@chinzou  please make sure to add another section in the progress board called "to test" (for Testers who can contribute.)


[Fix #4449] Make Layout/IndentHeredoc aware of line length

Problem
See #4449
Layout/IndentHeredoc does not treat line length. So the cop adds an offense for a heredoc with long line.
For example
module A
  module B
    class C
      def foo
        puts <<-MSG
This message's max line length is 75.
So, if you add indentations to this heredoc, this code violates LineLength.
But if `Metrics/LineLength`'s `AllowHeredoc` is true(default),
it does not violate.
        MSG
      end
    end
  end
end

Solution
This change will make Layout/IndentHeredoc to not register any offenses for a heredoc with long line when AllowHeredoc is false.

Before submitting the PR make sure the following are checked:

[x] Wrote good commit messages.
[x] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Used the same coding conventions as the rest of the project.
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
[x] All tests(rake spec) are passing.
[x] The new code doesn't generate RuboCop offenses that are checked by rake internal_investigation.
[x] The PR relates to only one subject with a clear title
and description in grammatically correct, complete sentences.
[x] Updated cop documentation with rake generate_cops_documentation (required only when you've added a new cop or changed the configuration/documentation of an existing cop).

I'm okay with the change, but not super excited about it. Keeping source lines short makes a lot of sense, but many of the arguments that can be made for code are moot when talking about natural language. From the original issue, it seems the problem is rather lacking editor configuration. 😅
However, since we have the AllowHeredoc option for LineLength, and it is true by default, might as well make use of it here.

I'm also conflicted about this change. It kind of make sense, but I wonder if this should be the default behavior or not.

This behaviour is not default.This behaviour is turned on when Metrics/LineLength's AllowHeredoc is false(default: true).
In the original issue case, we should choose one of the following.

An indented heredoc, but it's too long (maybe wrapped).
A short heredoc, but it is not indented.

Currently, RuboCop supports only the 1st choice. (AllowHeredoc: true, Layout/IndentHeredoc indents long heredoc.)
We will be able to choose 2nd choice by this pull-request(AllowHeredoc: false, Layout/IndentHeredoc does not indent long heredoc(keep short).)
So I think RuboCop should provides this behaviour. What do you think?

OK, you've convinced me.

Btw, this should probably be mentioned in the cop's documentation.