Keep camera position during a morph.

For #1060.
Fixes #2065. May also fix #1518 and #1845, though I couldn't reproduce #1845 in master either.
Might want to close #451 too since the morph view at the end is whatever the user set it to.

@bagnell @mramato let me know when the kinks are worked out, and I will take a quick look at the code.

@pjcozzi This is ready for another review. I decided for an incremental improvement until the other issues can be resolved.
If the duration is 0.0, the camera will maintain its position and orientation. In the Sandcastle, add viewer.sceneModePicker.viewModel.duration = 0.0;. Also, the issues mentioned above should still be fixed.

Code is OK with me.  @mramato can you test and merge?

I do not agree with going back to the old fly out behavior.  I also think it's confusing from a usability standpoint to have the camera stay where it is when duration is 0 vs fly out if it's non-zero.  I'm super excited about the other morph fixes though (no more crashes!)
@bagnell can you please list what the remaining issues were that caused us to go back to the old behavior?  The only thing I notice is jitter and tile seems.
In my opinion the graphical glitches during the morph are well worth the tradeoff to be able to morph in all cases without losing position.  I'm not sure if others had time to see it in action, but git checkout 472d512cdf554fd1573dc4b42285b1743e66d741 in order to see for yourself.  I'd be interested to hear what others' opinions are.  If no one cases that we're still flying out, then I won't object to merging this; but it's such a common complain on the forum that I feel it's worth keeping the position around.

I do not agree with going back to the old fly out behavior

:+1:  People hate that they lose their position
But I don't think the morph in commit 472d512cdf554fd1573dc4b42285b1743e66d741 is quite right either.  The morph between CV and 2D is good because even when you're zoomed in, you have a sense of what just happened.  3D to 2D, it's just weird to see the globe do a wiggle then stop.  There's no context.
It's a little silly, but I think flying out, doing the morph, then flying back in is a better solution.
And I think it should tilt when you get into CV, otherwise you don't notice that the mode is any different from 2D until you use the middle mouse button.
Either way, I think this is a huge improvement.  I haven't been able to switch between scene modes without the browser crashing in forever, so that's 100% worth merging in.

This incremental improvement is OK with me.  The user this is for is just going to do a duration=0 "morph."  We can revisit as time allows.

@mramato Those are the only two issues. For the second, it's not just cracks between tiles. There are whole tiles missing for certain views because the quadtree isn't updated during the morph.
@mramato @pjcozzi @hpinkos What are we doing with this PR?

I'm in favor of merging this in.  I think there are some additional improvement that can be made further down the line, but this is much better than what we have now.

I changed the title so when people stumble on this they don't get their hopes up.  I just hope we eventually get back to making this work in all cases.


CI passes when it fails to OK

https://github.com/bfbbdecomp/bfbb/pull/230/checks?check_run_id=2277971968
Seems to have an error in the size of the ROM, but somehow passed the check when it was spamming the diff


Strange error in component wrapped by Fade

Hi, I'm receiving this error when using Fade to wrap another component.

Hi, unfortunately this is an issue with the latest version of Emotion. As soon as this will be fixed by the Emotion team, I will update React Awesome Reveal.
As a temporary fix, please use the version 3.4.0 🦊

Tnx @dennismorello! I will do that 👍

I've had the same issue and tried using 3.4.0, but am still getting the error. I was using Fade around Slide. I've tried removing Fade to see if that would help, but am still getting the error. Any thoughts?

I've had the same issue and tried using 3.4.0, but am still getting the error. I was using Fade around Slide. I've tried removing Fade to see if that would help, but am still getting the error. Any thoughts?

I've had the same issue and tried using 3.4.0, but am still getting the error. I was using Fade around Slide. I've tried removing Fade to see if that would help, but am still getting the error. Any thoughts?

Why are you putting <Slide> as child of <Fade>? You can just set the direction prop to <Fade> and get rid of <Slide> 👀

The React error is not caused from react-awesome-reveal itself, so I do not have control over it. I am releasing v3.5.2 where I updated the @emotion/react dependency – the one responsible of the error. Hope it fixes the issue 🤞

I've had the same issue and tried using 3.4.0, but am still getting the error. I was using Fade around Slide. I've tried removing Fade to see if that would help, but am still getting the error. Any thoughts?

Why are you putting <Slide> as child of <Fade>? You can just set the direction prop to <Fade> and get rid of <Slide> 👀

The React error is not caused from react-awesome-reveal itself, so I do not have control over it. I am releasing v3.5.2 where I updated the @emotion/react dependency – the one responsible of the error. Hope it fixes the issue 🤞

@dennismorello I've just updated the Fade to use the direction prop, but it still seems to being giving the error. I tried using just Fade as well without props and was still getting the error

@dennismorello I've just updated the Fade to use the direction prop, but it still seems to being giving the error. I tried using just Fade as well without props and was still getting the error

@dennismorello Ahh i figured it out. thanks!!

@dennismorello Ahh i figured it out. thanks!!

I had the same issue with v3.7.0

I had the same issue with v3.7.0

I had the same issue with v3.7.0.

<Slide triggerOnce duration={200}>

 <Slide cascade duration={500}>

test1

test2

 </Slide>

</Slide>

Why are you wrapping the
 elements twice with <Slide>?

I had the same issue with v3.7.0.

<Slide triggerOnce duration={200}>

 <Slide cascade duration={500}>

test1

test2

 </Slide>

</Slide>

Why are you wrapping the
 elements twice with <Slide>?

That is just an example. When I use another  or  in a ,
I have an issue. For v3.4.0, I don't see this issue. So for now, I use
v3.4.0.
On Wed, Jan 20, 2021 at 8:46 AM Dennis Morello<EMAIL_ADDRESS>wrote:

I had the same issue with v3.7.0.

test1
test2

Why are you wrapping the  elements twice with ?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/dennismorello/react-awesome-reveal/issues/57#issuecomment-763777053,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHYF6MFGW7LDCFJ6NNAWWCLS24CHTANCNFSM4T3VBOHQ
.

That is just an example. When I use another  or  in a ,
I have an issue. For v3.4.0, I don't see this issue. So for now, I use
v3.4.0.
On Wed, Jan 20, 2021 at 8:46 AM Dennis Morello<EMAIL_ADDRESS>wrote:

I had the same issue with v3.7.0.

test1
test2

Why are you wrapping the  elements twice with ?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/dennismorello/react-awesome-reveal/issues/57#issuecomment-763777053,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHYF6MFGW7LDCFJ6NNAWWCLS24CHTANCNFSM4T3VBOHQ
.

But why would you want to use nested animation components?

But why would you want to use nested animation components?

I updated the actual code I am using. Firstly, the sub-navigation section is shown with the slide effect, and then, the items of the submenu will be shown with the cascade slide in the section.

I updated the actual code I am using. Firstly, the sub-navigation section is shown with the slide effect, and then, the items of the submenu will be shown with the cascade slide in the section.

Hi Dennis,
Do you have any updates on that, or what worked for you to get rid of the error?
I tried with the following versions, but still get the message:

3.4.0
3.5.2
3.7.0

I understand this is caused by Emotion, just trying to see if there's a workaround for it.
Thanks!

Hi Dennis,
Do you have any updates on that, or what worked for you to get rid of the error?
I tried with the following versions, but still get the message:

3.4.0
3.5.2
3.7.0

I understand this is caused by Emotion, just trying to see if there's a workaround for it.
Thanks!

If you downgrade to 3.4.0 that should work. At least I did that and it worked for me.

If you downgrade to 3.4.0 that should work. At least I did that and it worked for me.

Unfortunately, it didn't. :/
But thanks for suggesting it.

If you downgrade to 3.4.0 that should work. At least I did that and it worked for me.

Unfortunately, it didn't. :/
But thanks for suggesting it.

Then, check that you are not using nested animations.

Then, check that you are not using nested animations.

Yep, I was. Removing nested animations combined with downgrading to 3.4.0 did the trick.
Thanks!

I was just looking through issues on Emotion's repo. I didn't find any obvious open issues that pertain to this particular problem we're having.
Has anyone here thought about opening an issue with Emotion in hopes that it might put this bug on their radar if it isn't already? I would, except I don't really understand the underlying problem or how to describe our issue in a way that would be relevant to Emotion.
I only found out about Emotion a few minutes ago, shortly after I found out about this library... which looks awesome, by the way!

I am facing the same issue, my app is on Emotion 10, react-awesome-reveal 3.5 and up is on Emotion 11, I see the same errors, downgraded to v3.4.0 for now.
On related matters I tried to upgrade Emotion to 11, but Typescript support changed and Theming and other things proved harder than expected, I explored for a day but will leave that for the future.

FYI everyone, this is just a dev warning and not an actual error. The warning doesn't show up in production, so I consider this at worst a minor annoyance during dev time. I'm not going to worry about it anymore, nor am I going to roll back to a previous version. So far it's working great on prod with no errors (or warnings) which is all I care about.

That’s nice for you, but it was causing visual behavior issues for me.
On Mon, Feb 22, 2021 at 6:42 PM Aaron Sarnat<EMAIL_ADDRESS>wrote:

FYI everyone, this is just a dev warning and not an actual error. The
warning doesn't show up in production, so I consider this at worst a minor
annoyance during dev time. I'm not going to worry about it anymore, nor am
I going to roll back to a previous version. So far it's working great on
prod with no errors (or warnings) which is all I care about.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/dennismorello/react-awesome-reveal/issues/57#issuecomment-783783694,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAPYJT6KC7ZUMV7PIMBZUKDTAL2XNANCNFSM4T3VBOHQ
.

--
casey hunt
<EMAIL_ADDRESS>|  @caseymhunt | caseymhunt.com
<EMAIL_ADDRESS>

Any updates on this?
I also don't see any issues like this in emotions issues log, I'm just not sure if it's actually an issue caused by emotion - wouldn't it be showing up in other emotion powered projects?
I'm personally only seeing it as a dev only issue, but it can't be ruled out that it won't cause errors in surprising mysterious way. React seems pretty certain it's a bad idea.
It definitely seems to be caused by nesting animations, but nesting animations sounds like a feature you'd totally want?

Any updates on this?
I also don't see any issues like this in emotions issues log, I'm just not sure if it's actually an issue caused by emotion - wouldn't it be showing up in other emotion powered projects?
I'm personally only seeing it as a dev only issue, but it can't be ruled out that it won't cause errors in surprising mysterious way. React seems pretty certain it's a bad idea.
It definitely seems to be caused by nesting animations, but nesting animations sounds like a feature you'd totally want?

I am also feeling the same. I feel like there is something wrong with the code that uses the emotions js in the react-awesome-reveal plugin.  It will be great if there is someone who can review it to tackle the problems.

FYI everyone, this is just a dev warning and not an actual error. The warning doesn't show up in my production build, ...

To be clear, this is because it's a class of error that's suppressed by React in production mode, not because it's "just a dev warning."
To everyone else, I assume your code looks something like this?
<Element css={someFlag && css`...`} />

The issue is with this line in Emotion, which also hints at the solution:
<Element css={[someFlag && css`...`]} />

To be clear, this is because it's a class of error that's suppressed by React in production mode, not because it's "just a dev warning".

Point taken @tills13. Though I'd still emphasize that it's presented as a "warning" and not an "error." In any case, thanks for doing a deep dive into the emotion code to identify the culprit.

I have taken the liberty of submitting an issue to the Emotion repo and I'll have a PR there soon as well.
https://github.com/emotion-js/emotion/issues/2423

I would like to mention a warning too about @emotion/core package. I have separate @emotion/core package installed in my project and since this package is using @emotion too therefore react logs warning into console. Is there any way to suppress the warning?

I'm at version 11.9.0 and i'm still getting the same error. Is this fixed yet?


[ERROR][stocksight] Got an error with status code: 404 (will try again later)

I am facing this issue upon executing the sentiment.py file. Any Suggestions or solutions??

possible solution and suggestions:-
A 404 error in this context indicates that the script encountered a resource that doesn't exist. Here are some potential causes and solutions for the 404 error:

Incorrect URL:
Double-check the URL defined in the sentimentURL variable or the URL you're trying to access for headlines. Ensure there are no typos or missing parts.
Temporary Server Issue:
The error message "will try again later" suggests the issue might be temporary. Try rerunning the script after a short wait (a few minutes) to see if the resource becomes available.
Authentication Issues:
If the URL requires authentication (e.g., login credentials), ensure your script has the necessary information to access the resource.

Debugging Tips:
Print the exact URL the script tries to access before the error occurs. This can help you identify if it's an incorrect URL or a server issue.
Check the documentation for the third-party sentiment service or the website you're trying to access headlines from. They might have updated their API or structure, requiring adjustments in your script.
hope this helps, thanks


Bug: Can't remove "Type" column

Description
Under settings I have Type set to disabled, yet the column is still showing. Is there a way to drag-n- drop to swap columns, move left and right? I want to be able to see the "Size" column.
Steps To Reproduce

Went into settings \ layout \ columns, and disabled Type, yet its still showing.

Files Version
<IP_ADDRESS>
Windows Version
24H2 26100.2161
User ID
No response
Log File
debug.log

Thanks for the report, you can't reorder them yet, We're tracking this in #8385. You can check there or click subscribe in the right sidebar for updates.
Do you have Sync layout and preferences at the top of those options on?

The column options in settings are the defaults, but they won't affect folders where the defaults were already overridden. You can reset all those locations by toggling the setting to sync folder preferences on and off.

Sync is set to off.
Not sure what or where the right sidebar is located.
"You can check there or click subscribe in the right sidebar for updates".
On Sun, Nov 10, 2024 at 10:41 AM Yair @.***> wrote:

The column options in settings are the defaults, but they won't affect
folders where the defaults were already overridden. You can reset all those
locations by toggling the setting to sync folder preferences on and off.
—
Reply to this email directly, view it on GitHub
https://github.com/files-community/Files/issues/16456#issuecomment-2466781968,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AK3ZIJAITZ7HRQ2EE6E3OXTZ755BPAVCNFSM6AAAAABRQKMU3GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRWG44DCOJWHA
.
You are receiving this because you authored the thread.Message ID:
@.***>

Try toggling sync on and off, that should reset any overrides previously set in folders.


Implementation of  ST_PrecisionReduce

ST_PrecisionReduce is wanted in current version, so if it could be done by gdal 3.0.4, try to implement it by boost

finish this feature


stale PHAF log

The last couple of dumps have included a log file from the 2015-11-14 build:
log.2015-11-14-12-16-36.phenotypes_from_PMID_15821139_phaf.txt
I guess it's not being updated because the PHAF in question was deleted a few days after it was added, but that doesn't explain why the old log is still hanging around.
affected builds include pombase-build-2015-11-28-v2-l1 and at least one before it
snippet from svn log -v external_data/phaf_files/chado_load/ :
------------------------------------------------------------------------
r3094 | antonia | 2015-11-16 14:59:08 +0000 (Mon, 16 Nov 2015) | 1 line
Changed paths:
   M /trunk/chromosome1.contig
   M /trunk/chromosome2.contig
   D /trunk/external_data/phaf_files/chado_load/PMID_15821139_phaf.txt

gene exp
------------------------------------------------------------------------
r3082 | antonia | 2015-11-12 17:42:33 +0000 (Thu, 12 Nov 2015) | 1 line
Changed paths:
   A /trunk/external_data/phaf_files/chado_load/PMID_15821139_phaf.txt

added phaf 15821139
------------------------------------------------------------------------

Thanks for catching that.  I've removed the rogue log file.  The problem was triggered by the PHAF file ending in .txt (PMID_15821139_phaf.txt)


[SPARK-10573] [ML] IndexToString output schema should be StringType

Fixes bug where IndexToString output schema was DoubleType. Correct me if I'm wrong, but it doesn't seem like the output needs to have any "ML Attribute" metadata.

Can one of the admins verify this patch?

ok to test

LGTM pending Jenkins.

Merged build triggered.

Merged build started.

Test build #42435 has started for   PR 8751 at commit b9577e8.

Test build #42435 has finished for   PR 8751 at commit b9577e8.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42435/
Test PASSed.

Merged build finished. Test PASSed.

LGTM. Merged into master and branch-1.5. Thanks!


Add Golang routes for reporting configuration differences to Traffic Ops in ort script

It would be useful to have the ort script send the configuration differences between the cache's configuration files and those in the Traffic Ops database (in every mode except REVALIDATE).  This way the administrators of the CDN can see which/when caches are out of date and in what way.
@limited do you have anything to add?

sounds good!

this feels like a snapshot diff but for caches. any thoughts on this @rob05c outside of simply running atstccfg locally on a cache to see the pending changes.

Yeah, I think this would be a valuable feature. But it's a good amount of work. We'd need work on both the ORT side to get the diff and POST it to TO, and endpoint(s) on TO to receive that.
I'd +1 that. But that work should be coordinated with fixing the Snapshot-Queue issue a.k.a. "killing the chicken." Because fixing Snapshot-Queue also involves having ORT POST the date/snapshot that it applied back to TO. So, there might be some overlap, or maybe we could do both at the same time, or something.


Using different options on Requests in Guzzle\Pool

Hi,
I am currently working on the following problem: I want issue multiple concurrent Requests using different request options with the client; right now, when using Guzzle\Pool, I have to pass in the request options on creation of the Guzzle\Pool object, since it creates just one client instance. So, if I want to set different timeouts on the requests in the Pool, this would not be possible. But what would be the preferred way to achieve this, or am I overlooking something here?

The pool supports options that can be applied to each request: https://github.com/guzzle/guzzle/blob/master/src/Pool.php#L28
When sending requests through a pool, instead of yielding requests, you can also yield out callback functions. These callback functions are then invoked with the options of the Pool and can be used to create requests dynamically based on the Pool configuration. Here's an example https://github.com/guzzle/guzzle/blob/master/tests/PoolTest.php#L75


Remove bower & component.json or automate version bump

Version in bower.json & component.json is clearly outdated.
Any watchers who still use bower or component(1) ?
Otherwise I'm wondering if we should just stop supporting this 2.
I think this 2 packages managers can use package.json, do they?

I am vote for this

automate version bump

with help of grunt-release or grunt-bump

or just using mversion cli :p

Oh, I see that you are going to drop grunt. then you picked up better tool


Add a Message.getSchema() in the client API

When the schema is not known at compile time, a Consumer<GenericObject> should be able to get the message schema.
Currently, a Consumer<GenericRecord> can get the AVRO message and retreive its schema, but if the message is a KeyValue for example, there is no way to get the actual Schema.
The idea is to introduce a CompletableFuture<Schema<?>> getSchema() in the Message API, returning null by default.
The implementation classes (MessageImpl, TopicMessageImpl) could then fetch the Schema if available, and eventually keep it cached as a class member.

@congbobo184 here https://github.com/apache/pulsar/pull/9970/files#diff-955419b4b0ad976e96f9f7595989e79c391109aeaa304bd286a80fc6eb9360c7R324 you are adding MessageImpl#getSchema() with CompletableFuture
but why can't we use directly the schema instance that is cached inside the Message ?

Related work:
Here in this existing test we have a Consumer with AUTO_CONSUME schema
the tests tests that it is possible to access the "current" AvroSchema using Schema.getNativeSchema()
https://github.com/apache/pulsar/blob/7c0a798c28fc8dfcc72f072876b9c11eccc14b5c/pulsar-broker/src/test/java/org/apache/pulsar/client/api/SimpleSchemaTest.java#L530

The problem with AUTO_CONSUME and especially while dealing with multi-version schemas, is that Message.getSchema() should return the exact schema applied to the message, that is the schema identified by "topic" + "schemaVersion".

As discussed at the community meeting I am going to send a PIP

This is the PIP
https://docs.google.com/document/d/1VWi5LHP44V31nP4bCui9d5RXwH6xc_phrUes6tvNguk

https://github.com/apache/pulsar/pull/10476 is merged, so close this issue.


sr_psnr less than bicubic psnr

I tried your Test code directly and run the Demo_SR_Conv. But I get the following result:
iter:1
Elapsed time is 0.805680 seconds.
sr_psnr: 11.556457 dB
bi_psnr: 24.038857 dB
And the sr_reconstructed image looks like this:

Any recommendation will be appreciated.

Have you compiled matconvnet?

Yeah, I compiled and run the test. It compiled successfully and passed all the tests.

At first I got this error:
Warning: Name is nonexistent or not a directory:
/home/Dharma/caffe-vdsr/Test/matconvnet/matlab/mex

In path (line 109)
In addpath (line 88)
In vl_setupnn (line 13)
In run (line 96)
In Demo_SR_Conv (line 4)
iter:1
Attempt to execute SCRIPT vl_nnconv as a function:
/home/Dharma/caffe-vdsr/Test/matconvnet/matlab/vl_nnconv.m

Error in VDSR_Matconvnet (line 15)
convfea = vl_nnconv(im_y,weight{1},bias{1},'Pad',1);
Error in Demo_SR_Conv (line 42)
im_h_y = VDSR_Matconvnet(im_l_y, model,up_scale,use_cascade);
Then I found from stack overflow That I need to put the mex file in the root directory. So i copied the mex folder from my matconvnet that I got from vfleat and put it inside Test/matlab. And I run the Demo_SR_Conv. It works but it gives the above result.

At first I got this error:
Warning: Name is nonexistent or not a directory:
/home/Dharma/caffe-vdsr/Test/matconvnet/matlab/mex

In path (line 109)
In addpath (line 88)
In vl_setupnn (line 13)
In run (line 96)
In Demo_SR_Conv (line 4)
iter:1
Attempt to execute SCRIPT vl_nnconv as a function:
/home/Dharma/caffe-vdsr/Test/matconvnet/matlab/vl_nnconv.m

Error in VDSR_Matconvnet (line 15)
convfea = vl_nnconv(im_y,weight{1},bias{1},'Pad',1);
Error in Demo_SR_Conv (line 42)
im_h_y = VDSR_Matconvnet(im_l_y, model,up_scale,use_cascade);
Then I found from stack overflow That I need to put the mex file in the root directory. So i copied the mex folder from my matconvnet that I got from vfleat and put it inside Test/matconvnet/matlab. And I run the Demo_SR_Conv. It works but it gives the above result.

Sorry My mistake. I have compiled your matconvnet and it works now. Thank you.

It is ok. Maybe there are some differences between latest matconvnet and the early version. I will check it.

Seems like some problem with my machine. It works on my another machine but does not work on this.


Failure on Summit

I am running with e91fc5f13. I have been seeing the following error pretty reliably with 32 nodes, 192 ranks
/gpfs/alpine/scratch/bandok/csc335/Softwares/legion/runtime/realm/transfer/transfer.cc:3691: void Realm::TransferDesc::perform_analysis(): Assertion `srcs.size() == dsts.size()' failed.

I have been randomly seeing the following (type of) error with 8 nodes and 16 nodes
LEGION ERROR: Region requirement 6 of operation compute_interior_faces_flux_part2_task (UID 59364) in parent task top_level_task (UID 36) is using uninitialized data for field(s) (...)

This region requirement is a simple READ_ONLY requirement on a region that was written to by a different point task of an index launch that was launched before. All coherences are EXCLUSIVE. I ran the 32-node case with a debug build with -DLEGION_BOUNDS_CHECKS and the following debugging flags
-lg:warn -lg:partcheck -lg:safe_ctrlrepl 1 -lg:safe_mapper -ll:force_kthreads

I got this new error which was sometimes followed by the "uninitialized fields" error on some processes which makes me think that all of the above are related.
solver: /gpfs/alpine/scratch/bandok/csc335/Softwares/legion/runtime/legion/legion_instances.cc:366: void Legion::Internal::LayoutDescription::compute_copy_offsets(const FieldMask&, Legion::Internal::PhysicalInstance, std::vector<Realm::CopySrcDstField>&): Assertion `pop_count == FieldMask::pop_count(copy_mask)' failed.

Here is a full backtrace of the frozen process gdb.txt. The relevant bits are as follows
#6  0x000020000a716f70 in __assert_fail_base () from /lib64/power9/libc.so.6
#7  0x000020000a717014 in __assert_fail () from /lib64/power9/libc.so.6
#8  0x0000000012bd523c in Legion::Internal::LayoutDescription::compute_copy_offsets (this=0x202243489090, copy_mask=..., instance=..., fields=...) at /gpfs/alpine/scratch/bandok/csc335/Softwares/legion/runtime/legion/legion_instances.cc:366
#9  0x0000000012bdfe34 in Legion::Internal::IndividualManager::compute_copy_offsets (this=0x20224348bb70, copy_mask=..., fields=...) at /gpfs/alpine/scratch/bandok/csc335/Softwares/legion/runtime/legion/legion_instances.cc:2682
#10 0x0000000012bdf8b0 in Legion::Internal::IndividualManager::copy_from (this=0x20224348bb70, src_view=0x2022383b3e90, dst_view=0x20224348bfb0, source_manager=0x2022383b3a50, precondition=..., predicate_guard=..., reduction_op_id=0, copy_expression=0x202243478740, op=0x20224348b140, index=0, copy_mask=..., trace_info=..., recorded_events=..., applied_events=..., across_helper=0x0, manage_dst_events=true, copy_restricted=false) at /gpfs/alpine/scratch/bandok/csc335/Softwares/legion/runtime/legion/legion_instances.cc:2621
#11 0x000000001299fb44 in Legion::Internal::CopyFillAggregator::issue_copies (this=0x202243451790, target=0x20224348bfb0, copies=..., recorded_events=..., precondition=..., copy_mask=..., trace_info=..., manage_dst_events=true, restricted_output=false, dst_events=0x0) at /gpfs/alpine/scratch/bandok/csc335/Softwares/legion/runtime/legion/legion_analysis.cc:5416
#12 0x000000001299e994 in Legion::Internal::CopyFillAggregator::perform_updates (this=0x202243451790, updates=..., trace_info=..., precondition=..., recorded_events=..., redop_index=-1, manage_dst_events=true, restricted_output=false, dst_events=0x0) at /gpfs/alpine/scratch/bandok/csc335/Softwares/legion/runtime/legion/legion_analysis.cc:5250
#13 0x000000001299df54 in Legion::Internal::CopyFillAggregator::issue_updates (this=0x202243451790, trace_info=..., precondition=..., restricted_output=false, manage_dst_events=true, dst_events=0x0) at /gpfs/alpine/scratch/bandok/csc335/Softwares/legion/runtime/legion/legion_analysis.cc:5092
#14 0x00000000129a9760 in Legion::Internal::UpdateAnalysis::perform_updates (this=0x20223552b880, perform_precondition=..., applied_events=..., already_deferred=true) at /gpfs/alpine/scratch/bandok/csc335/Softwares/legion/runtime/legion/legion_analysis.cc:6965
#15 0x00000000129a2f80 in Legion::Internal::PhysicalAnalysis::handle_deferred_update (args=0x20006a4a4c50) at /gpfs/alpine/scratch/bandok/csc335/Softwares/legion/runtime/legion/legion_analysis.cc:5932
#16 0x0000000011fdd13c in Legion::Internal::Runtime::legion_runtime_task (args=0x20006a4a4c50, arglen=28, userdata=0x4563dd30, userlen=8, p=...) at /gpfs/alpine/scratch/bandok/csc335/Softwares/legion/runtime/legion/runtime.cc:31430
#17 0x000000001338ede0 in Realm::LocalTaskProcessor::execute_task (this=0x4557d690, func_id=4, task_args=...) at /gpfs/alpine/scratch/bandok/csc335/Softwares/legion/runtime/realm/proc_impl.cc:1135
#18 0x0000000013428ee8 in Realm::Task::execute_on_processor (this=0x20006a4a4ad0, p=...) at /gpfs/alpine/scratch/bandok/csc335/Softwares/legion/runtime/realm/tasks.cc:302
#19 0x000000001342dd44 in Realm::KernelThreadTaskScheduler::execute_task (this=0x453b2aa0, task=0x20006a4a4ad0) at /gpfs/alpine/scratch/bandok/csc335/Softwares/legion/runtime/realm/tasks.cc:1355
#20 0x000000001342c7b4 in Realm::ThreadedTaskScheduler::scheduler_loop (this=0x453b2aa0) at /gpfs/alpine/scratch/bandok/csc335/Softwares/legion/runtime/realm/tasks.cc:1094
#21 0x000000001342ce68 in Realm::ThreadedTaskScheduler::scheduler_loop_wlock (this=0x453b2aa0) at /gpfs/alpine/scratch/bandok/csc335/Softwares/legion/runtime/realm/tasks.cc:1206
#22 0x00000000134395b4 in Realm::Thread::thread_entry_wrapper<Realm::ThreadedTaskScheduler, &Realm::ThreadedTaskScheduler::scheduler_loop_wlock> (obj=0x453b2aa0) at /gpfs/alpine/scratch/bandok/csc335/Softwares/legion/runtime/realm/threads.inl:97
#23 0x000000001344e010 in Realm::KernelThread::pthread_entry (data=0x2022354f99e0) at /gpfs/alpine/scratch/bandok/csc335/Softwares/legion/runtime/realm/threads.cc:774
#24 0x0000200000208ae0 in start_thread () from /lib64/power9/libpthread.so.0
#25 0x000020000a80e7c8 in clone () from /lib64/power9/libc.so.6

I need a core file for the assertion and detailed Legion Spy logs for a run that produces the error.

I am hitting this
/gpfs/alpine/scratch/bandok/csc335/Softwares/legion/runtime/legion/runtime.cc:17096: void Legion::Internal::Runtime::log_machine(Legion::Machine) const: Assertion `false' failed.

I tried to reduce the size of the problem but was unsuccessful to reproduce. Moving over a 32-node case here /home/bandokihiro/scratch/ForMike/Issue1235

I am hitting this

Pull and try again

I tried to reduce the size of the problem but was unsuccessful to reproduce. Moving over a 32-node case here

The core file requires a binary to load. Preferably x86, but if you're running on a PowerPC machine I will try to dig up access to one.
How long did you have to run before the error condition arose for the Legion Spy logs? The current size of them makes them prohibitively expensive to analyze.

How long did you have to run before the error condition arose for the Legion Spy logs?

On 32 nodes, it doesn't complete one iteration before failing. I saw similar failure on 8 and 16 nodes in release mode but I haven't been able to reproduce them in debug mode with detailed spy logging.

Preferably x86, but if you're running on a PowerPC machine I will try to dig up access to one.

Yes, I am only able to reproduce on Summit at some scale.

I was able to reproduce with 8 nodes. The data is located here /home/bandokihiro/scratch/ForMike/Issue1235.
Note that the binary for the 8 node and the 32 node case are not the same.
I will move over a few core files.

Does it reproduce on an x86 machine of comparable scale?
Does it reproduce after building with -DDISABLE_EQUIVALENCE_SET_MIGRATION?

I removed the 32-node case.
The 8-node 48-rank case from Summit is still at /home/bandokihiro/scratch/ForMike/Issue1235/08Nodes
A 48-node 48-rank case from Piz Daint can be found at /home/bandokihiro/scratch/ForMike/Issue1235/PizDaint

Can you get a core file from Piz Daint?

I have already put one there
bandokihiro@sapling:~/scratch$ ll /home/bandokihiro/scratch/ForMike/Issue1235/PizDaint/core.12017
-rwxrwxrwx 1 bandokihiro bandokihiro 50G Apr 20 12:43 /home/bandokihiro/scratch/ForMike/Issue1235/PizDaint/core.12017*

If you need more, please tell me today if possible. They are each 50GB so I only moved one.

The smallest case with which I was able to reproduce is 20 ranks. I am currently moving the files over to sapling.

I had to delete the other cases for lack of space. Please find the binary + logs + 1 core file here
/home/bandokihiro/scratch/ForMike/Issue1235/PizDaint_20Ranks

You can delete the core files and binaries. They are not useful. I can see some threads, but none of the threads with the errors reported above. Next time you should put them in /scratch2/... where there is more space.
TBD if the Legion Spy logs are useful. I have a strong suspicion that this is also being caused by the equivalence set replication code which will be deleted just as soon as I can actually find time to finish debugging collective instances. It's going to be very hard to debug this without a reproducer though.

Probably easier to discuss here directly. Currently

the bug reproduces non-deterministically for any rank count greater or equal than 17
there isn't a clear pattern between how often the bug occurs and the number of ranks
the bug doesn't reproduce on 16 ranks (or at least I wasn't able too)
changing LEGION_COLLECTIVE_RADIX to 2 didn't help reproduce the bug on 16 ranks

Steps to reproduce on Piz Daint
Passwordless connection to Piz Daint
You need passwordless connection to be able to ssh into the compute nodes. For this, access Piz Daint the first time with
ssh<EMAIL_ADDRESS>(enter password)
ssh<EMAIL_ADDRESS>(enter password)

Drop off your public ssh key. Then, edit your ~/.ssh/config on your local machine with these lines
Host daint
    HostName        daint.cscs.ch
    ProxyJump<EMAIL_ADDRESS>    User            user
    AddKeysToAgent  yes
    ForwardAgent    yes

Doing ssh daint should bring you directly to Piz Daint (source).
Reproduce the bug
I have set up my permissions such that you can directly run the app in my scratch space. If it doesn't work for permission conflicts, please try to copy the folder into your user scratch space and run it there.
cd /scratch/snx3000/kbando/Runs/DG-Legion_Run
sbatch runslurm.sh

The application is linked to a debug build of Legion with -DLEGION_BOUNDS_CHECKS -DLEGION_SPY. It will restart the solver in a while true loop until the bug is triggered. LEGION_FREEZE_ON_ERROR=1 is defined in the batch script so it should freeze once it hits the bug. It typically takes O(10) attempts before the bug is triggered. The following command will tell you how many attempts succeeded so far
grep 'SSPRK3 step from 9e-10 to 1e-09 with time-step 1e-10' slurm*.out | wc -l

Feel free to modify the batch script. These days, it typically takes less than 10 minutes for the job to start. The time it takes for the bug to reproduce is very variable.

I've reproduced the error on Piz-Daint. I need a way to make changes to the source code and rebuild the runtime.

Legion is located here /users/kbando/Softwares/legion. Once you have made changes, do
cd /users/kbando/Softwares/legion/build
make install
cd /users/kbando/Softwares/DG-Legion/build
make solver

By the way, this is how my environment is set up
module unload PrgEnv-cray
module load gcc/9.3.0 # the prog env comes with a too recent gcc
module load intel/<IP_ADDRESS>4 # for mkl
module load PrgEnv-gnu/6.0.10 # not sure if needed
module load cudatoolkit/21.5_11.3
module load cray-python/<IP_ADDRESS>

is this issue supposed to go away with the merge of collective?

In theory yes. If you would like to try the collective branch you can. I'm not guaranteeing that inline mappings in a control replicated parent task or physical tracing with collective instances are working correctly yet. They might be, but I haven't done enough testing to ensure that yet.

ok, it doesn't work yet, but if at some point, you want me to run some tests, let me know

What is the current failure mode?

Backtrace: gdb.txt
The relevant bits are the following (i think):
Thread 11 (Thread 0x7f50f58b6000 (LWP 453762)):
#0  0x00007f51219533bf in __GI___clock_nanosleep (clock_id=clock_id@entry=0, flags=flags@entry=0, req=req@entry=0x7f50f58a3a20, rem=rem@entry=0x7f50f58a3a20) at ../sysdeps/unix/sysv/linux/clock_nanosleep.c:78
#1  0x00007f5121959047 in __GI___nanosleep (requested_time=requested_time@entry=0x7f50f58a3a20, remaining=remaining@entry=0x7f50f58a3a20) at nanosleep.c:27
#2  0x00007f5121958f7e in __sleep (seconds=0) at ../sysdeps/posix/sleep.c:55
#3  0x000055653ee0ab7f in Realm::realm_freeze (signal=6) at /home/bandokihiro/Builds_GPUNodes/legion/runtime/realm/runtime_impl.cc:179
#4  <signal handler called>
#5  __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50
#6  0x00007f5121898859 in __GI_abort () at abort.c:79
#7  0x000055653dead9f3 in Legion::Internal::Runtime::report_error_message (id=626, file_name=0x55653fc762d8 "/home/bandokihiro/Builds_GPUNodes/legion/runtime/legion/legion_instances.cc", line=4837, message=0x7f50f58a4430 "Mapper did not pass in a domain point when calling PhysicalInstance::get_instance or PhysicalInstance::get_location for a collective instance. Mappers must always specify a point when calling these me"...) at /home/bandokihiro/Builds_GPUNodes/legion/runtime/legion/runtime.cc:32094
#8  0x000055653e8510cd in Legion::Internal::CollectiveManager::get_instance (this=0x7f42c4033be0, p=..., from_mapper=true) at /home/bandokihiro/Builds_GPUNodes/legion/runtime/legion/legion_instances.cc:4837
#9  0x000055653e873008 in Legion::Internal::CollectiveManager::get_memory (this=0x7f42c4033be0, point=..., from_mapper=true) at /home/bandokihiro/Builds_GPUNodes/legion/runtime/legion/legion_instances.h:917
#10 0x000055653da2c319 in Legion::Mapping::PhysicalInstance::get_location (this=0x7f42c01875d0, point=0x0) at /home/bandokihiro/Builds_GPUNodes/legion/runtime/legion/legion_mapping.cc:110
#11 0x000055653d6af3ee in MyMapper::map_task (this=0x7f42c8020cb0, ctx=0x7f42c016e840, task=..., input=..., output=...) at /home/bandokihiro/Builds_GPUNodes/DG-Legion/mapper/my_mapper.cpp:415
#12 0x000055653dd27568 in Legion::Internal::MapperManager::invoke_map_task (this=0x7f42c8023900, task=0x7f42c018f650, input=0x7f50f58a5ad0, output=0x7f50f58a5b00, info=0x7f42c016e840) at /home/bandokihiro/Builds_GPUNodes/legion/runtime/legion/mapper_manager.cc:180
#13 0x000055653dc124b8 in Legion::Internal::SingleTask::invoke_mapper (this=0x7f42c018f650, must_epoch_owner=0x0) at /home/bandokihiro/Builds_GPUNodes/legion/runtime/legion/legion_tasks.cc:3756
#14 0x000055653dc149e8 in Legion::Internal::SingleTask::map_all_regions (this=0x7f42c018f650, must_epoch_op=0x0, defer_args=0x7f4d2803f0f0) at /home/bandokihiro/Builds_GPUNodes/legion/runtime/legion/legion_tasks.cc:4138
#15 0x000055653dc2339f in Legion::Internal::PointTask::perform_mapping (this=0x7f42c018f650, must_epoch_owner=0x0, args=0x7f4d2803f0f0) at /home/bandokihiro/Builds_GPUNodes/legion/runtime/legion/legion_tasks.cc:7289
#16 0x000055653deaeb84 in Legion::Internal::Runtime::legion_runtime_task (args=0x7f4d2803f0f0, arglen=52, userdata=0x556a28281f70, userlen=8, p=...) at /home/bandokihiro/Builds_GPUNodes/legion/runtime/legion/runtime.cc:32655
#17 0x000055653edef658 in Realm::LocalTaskProcessor::execute_task (this=0x556a25e54000, func_id=4, task_args=...) at /home/bandokihiro/Builds_GPUNodes/legion/runtime/realm/proc_impl.cc:1135
#18 0x000055653ee56a7f in Realm::Task::execute_on_processor (this=0x7f4d2803ef70, p=...) at /home/bandokihiro/Builds_GPUNodes/legion/runtime/realm/tasks.cc:302
#19 0x000055653ee5acda in Realm::KernelThreadTaskScheduler::execute_task (this=0x556a25e54340, task=0x7f4d2803ef70) at /home/bandokihiro/Builds_GPUNodes/legion/runtime/realm/tasks.cc:1366
#20 0x000055653ee59a1e in Realm::ThreadedTaskScheduler::scheduler_loop (this=0x556a25e54340) at /home/bandokihiro/Builds_GPUNodes/legion/runtime/realm/tasks.cc:1105
#21 0x000055653ee5a06f in Realm::ThreadedTaskScheduler::scheduler_loop_wlock (this=0x556a25e54340) at /home/bandokihiro/Builds_GPUNodes/legion/runtime/realm/tasks.cc:1217
#22 0x000055653ee62204 in Realm::Thread::thread_entry_wrapper<Realm::ThreadedTaskScheduler, &Realm::ThreadedTaskScheduler::scheduler_loop_wlock> (obj=0x556a25e54340) at /home/bandokihiro/Builds_GPUNodes/legion/runtime/realm/threads.inl:97
#23 0x000055653ee6f4de in Realm::KernelThread::pthread_entry (data=0x7f4d2801da90) at /home/bandokihiro/Builds_GPUNodes/legion/runtime/realm/threads.cc:774
#24 0x00007f512be68609 in start_thread (arg=<optimized out>) at pthread_create.c:477
#25 0x00007f5121995293 in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:95

Thread 10 (Thread 0x7f50f5492000 (LWP 453760)):
#0  syscall () at ../sysdeps/unix/sysv/linux/x86_64/syscall.S:38
#1  0x000055653ef1db96 in Realm::Doorbell::wait_slow (this=0x7f50f5491090) at /home/bandokihiro/Builds_GPUNodes/legion/runtime/realm/mutex.cc:316
#2  0x000055653ecef4a2 in Realm::Doorbell::wait (this=0x7f50f5491090) at /home/bandokihiro/Builds_GPUNodes/legion/runtime/realm/mutex.inl:81
#3  0x000055653ef1f098 in Realm::FIFOCondVar::wait (this=0x7f50f5480400) at /home/bandokihiro/Builds_GPUNodes/legion/runtime/realm/mutex.cc:1088
#4  0x000055653ee5aed6 in Realm::KernelThreadTaskScheduler::worker_sleep (this=0x556a25e54340, switch_to=0x7f4d2801da90) at /home/bandokihiro/Builds_GPUNodes/legion/runtime/realm/tasks.cc:1414
#5  0x000055653ee58bcd in Realm::ThreadedTaskScheduler::thread_blocking (this=0x556a25e54340, thread=0x7f42c016e250) at /home/bandokihiro/Builds_GPUNodes/legion/runtime/realm/tasks.cc:896
#6  0x000055653ed04e04 in Realm::Thread::wait_for_condition<Realm::EventTriggeredCondition> (cond=..., poisoned=@0x7f50f5480a2f: false) at /home/bandokihiro/Builds_GPUNodes/legion/runtime/realm/threads.inl:218
#7  0x000055653ecf2d1c in Realm::Event::wait_faultaware (this=0x7f42dc05f090, poisoned=@0x7f50f5480a2f: false) at /home/bandokihiro/Builds_GPUNodes/legion/runtime/realm/event_impl.cc:254
#8  0x000055653ecf28d2 in Realm::Event::wait (this=0x7f42dc05f090) at /home/bandokihiro/Builds_GPUNodes/legion/runtime/realm/event_impl.cc:206
#9  0x000055653da007a2 in Legion::Internal::LgEvent::wait (this=0x7f42dc05f090) at /home/bandokihiro/Builds_GPUNodes/legion/runtime/legion/legion_types.h:2855
#10 0x000055653e8d0a7a in Legion::Internal::GatherCollective::perform_collective_wait (this=0x7f42dc05ef50, block=true) at /home/bandokihiro/Builds_GPUNodes/legion/runtime/legion/legion_replication.cc:12613
#11 0x000055653e8d3893 in Legion::Internal::ShardingGatherCollective::validate (this=0x7f42dc05ef50, value=1000) at /home/bandokihiro/Builds_GPUNodes/legion/runtime/legion/legion_replication.cc:14188
#12 0x000055653e8a1e9a in Legion::Internal::ReplIndexTask::trigger_prepipeline_stage (this=0x7f42dc05e270) at /home/bandokihiro/Builds_GPUNodes/legion/runtime/legion/legion_replication.cc:1865
#13 0x000055653da3b73e in Legion::Internal::Operation::execute_prepipeline_stage (this=0x7f42dc05e430, generation=0, from_logical_analysis=true) at /home/bandokihiro/Builds_GPUNodes/legion/runtime/legion/legion_ops.cc:981
#14 0x000055653da3b89d in Legion::Internal::Operation::execute_dependence_analysis (this=0x7f42dc05e430) at /home/bandokihiro/Builds_GPUNodes/legion/runtime/legion/legion_ops.cc:1002
#15 0x000055653da41581 in Legion::Internal::SpeculativeOp::execute_dependence_analysis (this=0x7f42dc05e430) at /home/bandokihiro/Builds_GPUNodes/legion/runtime/legion/legion_ops.cc:4122
#16 0x000055653daecef0 in Legion::Internal::MemoizableOp<Legion::Internal::SpeculativeOp>::execute_dependence_analysis (this=0x7f42dc05e430) at /home/bandokihiro/Builds_GPUNodes/legion/runtime/legion/legion_ops.inl:106
#17 0x000055653e77ee57 in Legion::Internal::InnerContext::process_dependence_stage (this=0x7f42c803e1b0) at /home/bandokihiro/Builds_GPUNodes/legion/runtime/legion/legion_context.cc:7773
#18 0x000055653e78bd92 in Legion::Internal::InnerContext::handle_dependence_stage (args=0x7f42dc05e020) at /home/bandokihiro/Builds_GPUNodes/legion/runtime/legion/legion_context.cc:10672
#19 0x000055653deae39c in Legion::Internal::Runtime::legion_runtime_task (args=0x7f42dc05e020, arglen=12, userdata=0x556a28281f70, userlen=8, p=...) at /home/bandokihiro/Builds_GPUNodes/legion/runtime/legion/runtime.cc:32396
#20 0x000055653edef658 in Realm::LocalTaskProcessor::execute_task (this=0x556a25e54000, func_id=4, task_args=...) at /home/bandokihiro/Builds_GPUNodes/legion/runtime/realm/proc_impl.cc:1135
#21 0x000055653ee56a7f in Realm::Task::execute_on_processor (this=0x7f42dc05dea0, p=...) at /home/bandokihiro/Builds_GPUNodes/legion/runtime/realm/tasks.cc:302
#22 0x000055653ee5acda in Realm::KernelThreadTaskScheduler::execute_task (this=0x556a25e54340, task=0x7f42dc05dea0) at /home/bandokihiro/Builds_GPUNodes/legion/runtime/realm/tasks.cc:1366
#23 0x000055653ee59a1e in Realm::ThreadedTaskScheduler::scheduler_loop (this=0x556a25e54340) at /home/bandokihiro/Builds_GPUNodes/legion/runtime/realm/tasks.cc:1105
#24 0x000055653ee5a06f in Realm::ThreadedTaskScheduler::scheduler_loop_wlock (this=0x556a25e54340) at /home/bandokihiro/Builds_GPUNodes/legion/runtime/realm/tasks.cc:1217
#25 0x000055653ee62204 in Realm::Thread::thread_entry_wrapper<Realm::ThreadedTaskScheduler, &Realm::ThreadedTaskScheduler::scheduler_loop_wlock> (obj=0x556a25e54340) at /home/bandokihiro/Builds_GPUNodes/legion/runtime/realm/threads.inl:97
#26 0x000055653ee6f4de in Realm::KernelThread::pthread_entry (data=0x7f42c016e250) at /home/bandokihiro/Builds_GPUNodes/legion/runtime/realm/threads.cc:774
#27 0x00007f512be68609 in start_thread (arg=<optimized out>) at pthread_create.c:477
#28 0x00007f5121995293 in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:95

That is a "problem" with your mapper. We can probably safely ignore it though for now since we just decided to change the interfaces for the mapper to talk about collective instances in the Legion meeting last week, and this particular problem will go away.


Create database

Is it possible to create a database with this library with CREATE DATABASE [dbName] or should you allways connect to an existing database?
I want to create Unittests that create a test database and drop it when finished.

As far as I understand it connects to existing. I guess it could be done with a 'master' db that executes a create db type stored procedure... Kinda shoehorning it in though.


Bumping 2.x branch version from 2.1.0 to 2.2.0.

Signed-off-by: AWSHurneyt<EMAIL_ADDRESS>Issue #, if available:
https://github.com/opensearch-project/alerting/issues/498
Description of changes:

Bumping 2.x branch version from 2.1.0 to 2.2.0. This change is dependent on https://github.com/opensearch-project/notifications/pull/493.
Bumped mockito-core version from 4.3.1 to 4.6.1.

CheckList:
[x] Commits are signed per the DCO using --signoff
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

This is failing right now since there are no notification 2.2 artifacts available right now.

Please update this file as well: https://github.com/opensearch-project/alerting/blob/2.x/alerting/build.gradle#L260

Codecov Report

Merging #506 (2f0e0cb) into 2.x (f320733) will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                2.x     #506      +/-   ##
============================================
+ Coverage     76.73%   76.75%   +0.01%
  Complexity      176      176
============================================
  Files           166      166
  Lines          8370     8370
  Branches       1232     1232
============================================
+ Hits           6423     6424       +1
- Misses         1342     1344       +2
+ Partials        605      602       -3

Impacted Files
Coverage Δ

...ing/model/destination/DestinationContextFactory.kt
75.00% <0.00%> (-3.58%)
:arrow_down:

...destinationmigration/DestinationConversionUtils.kt
68.88% <0.00%> (-1.12%)
:arrow_down:

...rg/opensearch/alerting/BucketLevelMonitorRunner.kt
76.92% <0.00%> (+0.76%)
:arrow_up:

...nationmigration/DestinationMigrationCoordinator.kt
68.08% <0.00%> (+4.25%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


overfit models yeild domain specific image compressors?

excellent work! this is awesome.
Ive been looking at this project and reading the paper and i think i have an experiment id like to run. being a lazy scientist, i'd like your opinion of the idea. my idea was also partially inspired by the paper: COIN: COmpression with Implicit Neural representations (https://arxiv.org/abs/2103.03123)
i'm sorta a newb here so... sorry if this is dumb,
but heres the gist of it:
in data science we are typically building models that generalize to unseen data, which you've done very well. but in the use case of storing large amounts of domain specific images (like a database of cat pictures). it would seem that a little overfitting would benefit the performance of the model. also, the model could be continuously trained as new images are added to the database?
does anyone else think this might work?

ok wow, i guess they did mention dataset compression in the paper, im running it right now.


⚠ ClamAV has degraded performance

In 678db2f, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 222 ms

Resolved: ClamAV performance has improved in e5c9330.


Is this project active?

Hi all.
I want to help, but I want to know if this project is active. Is this project active?

Check pinned issues, #779.


Ring Doorbell Downgrade to 0.6.2

Hi,
could you please downgrade the requirements to version 0.6.2 of ring_doorbell.. There is a bug in the current version of 0.7.0 (https://github.com/tchellomello/python-ring-doorbell/issues/240)
Thx, Jan

Hi Jan,
thx for the info. I reverted back to 0.6.2.
New release: 0.1.56


Add Tomorrow night bright theme

Nothing more to say ! :D
I like this theme and I thought it would be nice to add it to your list.

I'll do a complete rebuild soon


Task00 Алсу Верещагина ITMO

Локальный вывод

# ./enumDevices
Number of OpenCL platforms: 2
Platform #1/2
    Platform name: NVIDIA CUDA
    Platform vendor: NVIDIA Corporation
Number of OpenCL devices: 1
    Device name: NVIDIA GeForce GTX 1080
        Device type: GPU
        Device memory size: 8500 MB
        Device with unified memory: no
        Device compute units: 20
        Device max clock frequency: 1733 MHz
Platform #2/2
    Platform name: Intel(R) CPU Runtime for OpenCL(TM) Applications
    Platform vendor: Intel(R) Corporation
Number of OpenCL devices: 1
    Device name: Intel(R) Xeon(R) CPU E5-2680 v4 @ 2.40GHz
        Device type: CPU
        Device memory size: 25195 MB
        Device with unified memory: yes
        Device compute units: 8
        Device max clock frequency: 2400 MHz

Все хорошо, задача зачтена, 5/5 баллов 👍


Example code does not compile and is incorrect

Regarding this code block:
static async Task CreateTwins()
{
    // Create twins - see utility functions below
    await CreateRoom("Room01", 68, 50, false, "");
    await CreateRoom("Room02", 70, 66, true, "EId-00124");
    await CreateFloorOrBuilding("Floor01", makeFloor:true);

    // Create relationships
    await AddRelationship("Floor01", "contains", "Floor-to-Room01", "Room01");
    await AddRelationship("Floor01", "contains", "Floor-to-Room02", "Room02");
}

static async Task<bool> AddRelationship(string source, string relationship, string id, string target)
{
    var relationship = new BasicRelationship
    {
        TargetId = target,
        Name = relationship
    };

    try
    {
        string relId = $"{source}-contains->{target}";
        await client.CreateRelationshipAsync(source, relId, JsonSerializer.Serialize(relationship));
        Console.WriteLine("Created relationship successfully");
        return true;
    }
    catch (RequestFailedException rex) {
        Console.WriteLine($"Create relationship error: {rex.Status}:{rex.Message}");
        return false;
    }
}

Code does not compile as it's using the variable relationship twice. Furthermore the variable id is never used. I tried some of my own interpretations of what could be meant here but these don't work yet.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f69ab4ee-a444-27d9-eba6-60e378934ba6
Version Independent ID: 8da3d3e9-98b5-c695-b277-f9373dafcc09
Content: Manage the twin graph with relationships - Azure Digital Twins
Content Source: articles/digital-twins/how-to-manage-graph.md
Service: digital-twins
GitHub Login: @baanders
Microsoft Alias: baanders

Thanks @devedse! This article is currently undergoing edits to resolve. I'll keep this thread updated with the progress!

Hello @devedse , the article has now been updated. This section of code has been replaced with a new code sample, which should hopefully resolve your issue: Create a twin graph.
Since the affected section of code no longer exists, I'll now proceed to close this issue.
Please feel free to comment back with additional questions or comments, or to open new issues on the new code if you encounter any.
Thanks again!

#please-close


Add new theme

Add new theme
Add RTD

Hello @IAlibay! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file docs/conf.py:

Line 40:31: E231 missing whitespace after ','

@orbeckst this will fix #65 and #66


Model class django.contrib.sites.models.Site doesn't declare an explicit app_label and isn't in an application in INSTALLED_APPS.

Hello,
Thank you for your work.
I had a runtime error when i install django-conversation package with pip.
My settings.py looks good but i had now the following message :
Model class django.contrib.sites.models.Site doesn't declare an explicit app_label and isn't in an application in INSTALLED_APPS.
Best regards

Ok
Just add 'django.contrib.sites' in settings


✨ Webhook URL based CRD conversions

Summary
An attempt to add webhook URL based CRD conversions
Changeset

APIResourceSchema API Changes
Convertor changes to support apigen
Changes to apibinding reconciler

More to be added. I'm still figuring out the request flow. The conversion works for CRDs created manually, just like Kubernetes. For CRDs created from API bindings, some plumbing needs to be included.
Related issue(s)
None
Release Notes
✨ Add Webhook URL based CRD conversions

/retest

/lgtm

/lgtm
/approve


feat(fee): set the resources slope values

This change is

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (97c76c6) 70.90% compared to head (f8cc1f0) 70.91%.

Additional details and impacted files
@@                      Coverage Diff                      @@
##           noa/adding_resources_role    #1363      +/-   ##
=============================================================
+ Coverage                      70.90%   70.91%   +0.01%
=============================================================
  Files                             59       59
  Lines                           7627     7630       +3
  Branches                        7627     7630       +3
=============================================================
+ Hits                            5408     5411       +3
  Misses                          1797     1797
  Partials                         422      422

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Cirbular buffer ranged based for const version

currently it is not possible to constly iterate over a circular bufffer

Closed with #286


Use latest contrib

@jrcamp replaced by https://github.com/signalfx/splunk-otel-collector/pull/174

@jrcamp should this be closed?

Yeah I'll close it, was being used with my automated script but I'll just open a new one when I get back to it.


Fixed Websockets example in README.md

My updated example is a little rough around the edges but it should be up to date with the latest version of the library.
I had some trouble when I copy pasted the example so I thought I would merge back what I did to get it working!

Thank you!


Fix: Change dev container image

Change Summary
Fix dev container image to existing one.

LGTM - I had already applied this change to my local copy.


Merge Branch-editEventComand-Vinod with master

Closes #92; Closes #91

Codecov Report
Base: 64.25% // Head: 60.47% // Decreases project coverage by -3.78% :warning:

Coverage data is based on head (b8c7fed) compared to base (5fc7031).
Patch coverage: 2.54% of modified lines in pull request are covered.

:exclamation: Current head b8c7fed differs from pull request most recent head 6558e01. Consider uploading reports for the commit 6558e01 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #99      +/-   ##
============================================
- Coverage     64.25%   60.47%   -3.79%
- Complexity      468      470       +2
============================================
  Files            88       92       +4
  Lines          1701     1814     +113
  Branches        182      206      +24
============================================
+ Hits           1093     1097       +4
- Misses          548      654     +106
- Partials         60       63       +3

Impacted Files
Coverage Δ

...main/java/seedu/address/commons/core/Messages.java
0.00% <ø> (ø)

...seedu/address/logic/commands/EditEventCommand.java
0.00% <0.00%> (ø)

.../seedu/address/logic/parser/AddressBookParser.java
76.19% <0.00%> (-3.81%)
:arrow_down:

...u/address/logic/parser/EditEventCommandParser.java
0.00% <0.00%> (ø)

src/main/java/seedu/address/model/AddressBook.java
78.04% <0.00%> (-10.85%)
:arrow_down:

src/main/java/seedu/address/model/Model.java
100.00% <ø> (ø)

...rc/main/java/seedu/address/model/ModelManager.java
77.27% <0.00%> (-6.34%)
:arrow_down:

src/main/java/seedu/address/model/event/Event.java
18.18% <0.00%> (-2.51%)
:arrow_down:

...odel/event/exceptions/DuplicateEventException.java
0.00% <0.00%> (ø)

...model/event/exceptions/EventNotFoundException.java
0.00% <0.00%> (ø)

... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


fix: consistent path separator on windows

Resolves #70
When debugging this error, I noticed that paths are being indexed with both / and \ separators. This was causing the nil value error in virtual_name.lua because it expects either one or the other.
To resolve this, I added an extra step to ensure all path / chars are replaced with \ before trying to determine the virtual path. This is only executed on Windows.

a more solid solution is to use plenary.nvim for path operation.

I'm merging this into 0.3.x, if anybody wants to contribute a more solid solution, I'm open, but I'll take this for now.


dark mode in licensing page

fixes #1101
before :
https://github.com/user-attachments/assets/4b3577e1-bf96-4cad-b0dc-b36a65218942
after :
https://github.com/user-attachments/assets/79b0cecc-727e-44e2-b901-c5f92370ecb2

@Its-Aman-Yadav please review and merge my pr


Support URL embedding of layer opacity

https://github.com/eblondel/OpenFairViewer/commit/2e92174071977beca4b1d3ab000fca420c37df89


ValueError: 'oculus' is not in list

Epoch 1/100
Traceback (most recent call last):
File "hololens_train.py", line 7, in
trainer.trainModel()
File "D:\deeplearningvideos\anaconda\lib\site-packages\imageai\Detection\Custom_init_.py", line 291, in trainModel
max_queue_size=8
File "D:\deeplearningvideos\anaconda\lib\site-packages\keras\legacy\interfaces.py", line 91, in wrapper
return func(*args, **kwargs)
File "D:\deeplearningvideos\anaconda\lib\site-packages\keras\engine\training.py", line 1732, in fit_generator
initial_epoch=initial_epoch)
File "D:\deeplearningvideos\anaconda\lib\site-packages\keras\engine\training_generator.py", line 185, in fit_generator
generator_output = next(output_generator)
File "D:\deeplearningvideos\anaconda\lib\site-packages\keras\utils\data_utils.py", line 625, in get
six.reraise(*sys.exc_info())
File "D:\deeplearningvideos\anaconda\lib\site-packages\six.py", line 703, in reraise
raise value
File "D:\deeplearningvideos\anaconda\lib\site-packages\keras\utils\data_utils.py", line 610, in get
inputs = future.get(timeout=30)
File "D:\deeplearningvideos\anaconda\lib\multiprocessing\pool.py", line 657, in get
raise self._value
File "D:\deeplearningvideos\anaconda\lib\multiprocessing\pool.py", line 121, in worker
result = (True, func(*args, **kwds))
File "D:\deeplearningvideos\anaconda\lib\site-packages\keras\utils\data_utils.py", line 406, in get_index
return _SHARED_SEQUENCES[uid][i]
File "D:\deeplearningvideos\anaconda\lib\site-packages\imageai\Detection\Custom\generator.py", line 112, in getitem
obj_indx = self.labels.index(obj['name'])
ValueError: 'oculus' is not in list

i could resolve it... no issues now
just added
trainer.setTrainConfig(object_names_array=["hololens","oculus"], batch_size=4, num_experiments=100, train_from_pretrained_model="pretrained-yolov3.h5")


Introduce an image of CloudEvent Http Receiver

Introduce an image of CloudEvent Http Receiver that is for CloudEvent e2e testing.
Checklist

[X] Commits are signed with Developer Certificate of Origin (DCO)
[X] A PR is opened to update the documentation on our docs repo

Related #https://github.com/kedacore/keda/pull/4968

@SpiritZhou , you can use the image using ghcr.io/kedacore/tests-cloudevents-http:latest


cannot reproduce

I really dont think this can be reproduced,
RuntimeError: Error(s) in loading state_dict for CViViT:
Missing key(s) in state_dict: "discr.attn_blocks.3.null_kv", "discr.attn_blocks.3.q_scale", "discr.attn_blocks.3.k_scale", "discr.attn_blocks.3.norm.gamma", "discr.attn_blocks.3.norm.beta", "discr.attn_blocks.3.context_norm.gamma", "discr.attn_blocks.3.context_norm.beta", "discr.attn_blocks.3.to_q.weight", "discr.attn_blocks.3.to_kv.weight", "discr.attn_blocks.3.to_out.weight".
Unexpected key(s) in state_dict: "discr.blocks.6.conv_res.weight", "discr.blocks.6.conv_res.bias", "discr.blocks.6.net.0.weight", "discr.blocks.6.net.0.bias", "discr.blocks.6.net.2.weight", "discr.blocks.6.net.2.bias", "discr.blocks.5.downsample.1.weight", "discr.blocks.5.downsample.1.bias".
size mismatch for discr.to_logits.3.weight: copying a param with shape torch.Size([1, 8192]) from checkpoint, the shape in current model is torch.Size([1, 16384]).

i use a simple video dataset, no problem with gpu and dataset, and i haven't changed anything on the source code.

Alright, nevermine, its my problem, I should never waste time on a nonreproducible project, and a github less than 1k stars

and this RuntimeError: CUDA error: device-side assert triggered CUDA kernel errors might be asynchronously reported at some other API call,so the stacktrace below might be incorrect. For debugging consider passing CUDA_LAUNCH_BLOCKING=1. have tried many gpu on google colab, all failed

I experienced the problem and posted it, as an issue.

and this RuntimeError: CUDA error: device-side assert triggered CUDA kernel errors might be asynchronously reported at some other API call,so the stacktrace below might be incorrect. For debugging consider passing CUDA_LAUNCH_BLOCKING=1. have tried many gpu on google colab, all failed

I experienced the problem and posted it, as an issue.

I tried many all GPU on google colab but none work, what the error means is just that the training dataset and label are not correct, but i check the dataset and the label, you know it are the three lines:
texts = [
'a whale breaching from afar',
'young girl blowing out candles on her birthday cake',
'fireworks with blue and green sparkles'
]
also, the dataset is videos = torch.randn(3, 3, 17, 256, 128).cuda() # (batch, channels, frames, height, width)
mask = torch.ones((3, 17)).bool().cuda() # [optional] (batch, frames)
so i dont see any problem here because the sample size is 3

and this RuntimeError: CUDA error: device-side assert triggered CUDA kernel errors might be asynchronously reported at some other API call,so the stacktrace below might be incorrect. For debugging consider passing CUDA_LAUNCH_BLOCKING=1. have tried many gpu on google colab, all failed

I experienced the problem and posted it, as an issue.

maybe we can work together to fix this error.

Let's do it, can you share your fork or you or I can share mine: luthando-contribution


Support Speech Synthesis

Use native version shipped in Chrome. Use polyfill for Firefox (hit Google Translate servers).

FWIW, B2G does have support for SpeechSynthesisUtterance, but it's not shipped with the desktop builds of Firefox (or the Gecko builds that have SpeechRecognition).


Gif recording

Wow, very cool. Didn't imagine it could be done in under 200 lines.
It would be good to include a link for attribution to the original version, don't you think?

Sure, also I'll include gamax64 in contributers list


Error reading predefined ALARM tags

Can not read a predefined tag of type ALARM or ALARM_DIGITAL.
Current Behavior

The readTag() function returns the following error:
{ generalStatusCode: 15, extendedStatus: [] }
Expected Behavior

Read the tag without error.
Possible Solution (Optional)

Might have something to do with the extra SINT members that come along with structures that have BOOL members (one SINT for every 8 BOOLs). Just a thought because I am also experiencing incorrect data being written to DINT members, if the structure contains any BOOL members.
Context

Steps to Reproduce (for bugs only)

Run this code with a tag named 'ALM_1' defined as type ALARM.
const {Controller} = require('st-ethernet-ip')

const PLC = new Controller()

PLC.connect('<IP_ADDRESS>',0).then(async () => {

  console.log('Connected...')
  const udt = PLC.newTag('ALM_1')

  await PLC.readTag(udt)
  console.log('ALM_1:', udt.value)

}).catch(e => {
  console.log('Error: ', e)
})

Your Environment

Package version (Use npm list - e.g. 1.0.6): 2.5.0
Node Version (Use node --version - e.g. 9.8.0): 16.14.2
Operating System and version: OSX 10.15.7
Controller Type (eg 1756-L83E/B): 1769-L24ER-QB1B CompactLogix 5370
Controller Firmware (eg 30.11): 30.011

I read and wrote an ALARM type tag using the same code structure as you and did not have an issue on a 1769-L32E. Double check that it is a controller scope tag and the name is correct. Check external access is also Read/Write.

Actually, reading type ALARM does work for me. It's ALARM_DIGITAL and ALARM_ANALOG types that do not. I noticed the External Access field is grayed-out in the controller tags editor for those types. Can not be changed from Read/Write. Not sure why that is or if it matters, but it is set to Read/Write.

Looks like Rockwell blocks reading the whole structure of ALARM_DIGITAL and ALARM_ANALOG, but you can read the individual components of the structure with separate tags for each value. The ALARM_DIGITAL and ALARM_ANALOG  types and corresponding instructions ALMD and ALMA are designed to interact with the Factory Talk Alarm and Event System.

As a work around I just copied the data I need from the alarm tag into a new structure in the PLC and read that. Want to stick with UDT's instead of separate tags. Works nicely. Thanks


Update docs to include support for uploading .zip and .tar.gz pipeline files

Update docs to include info that it is possible to upload .zip and .tar.gz pipeline files as well
Resolves: https://github.com/kubeflow/website/issues/3715

Resolves: https://github.com/kubeflow/website/issues/3715

@hbelmiro updated

/lgtm
/approve


Issue with /docs/tutorials/stateless-application/run-stateless-application-deployment/

the apiVersion in deployment.yaml should be "extensions/v1beta1" not "apps/v1beta1"

@mixj93 Kubernetes v1.6 uses apps/v1beta1 for Deployment and the documentation is reflecting the latest stable release.


Error: dateHelper is null

Hi all,
with the following configuration:

PC + Firefox (68.0.2)
datetimepicker version 2.5.20

I receive the following error:
dateHelper is null
With "Interner Explorer" all is ok.
Thanks for your help
Miche

Same problem with Safari 13.0.2 (146<IP_ADDRESS>.3) on Mac OS.

Same with Firefox 72 on Ubuntu 18.04 and 2.5.20 (master was also tested). JQuery 3.4.1 is used. datetimepicker is not functional because if that. Could you please look into the issue? Thanks! :)

Can confirm same issue with Firefox 78.0.2 on Ubuntu with both 2.5.20 and master, with both JQuery 3.4.1 and JQuery 3.5.0 (which is the version listed in package-lock.json).
Chrome 83.0.4103.106 also seems to have this error (only testing master with JQuery 3.5.0). It throws TypeError: Cannot read property 'formatDate' of null when attempting to read dateHelper.formatDate.

Same here. It's not at all obvious from the documentation but try including 'jquery.datetimepicker.full.js' in your script instead of 'jquery.datetimepicker.js'.  It looks like it's working with that 'full.js' script and I didn't have to include a '<script src="php-date-formatter' tag.
I don't know much about these kind of npm packages and I don't use transpilers or webpack or any of that stuff (yet). So I find the documentation on stuff like this to be a bit unfriendly to those of use who don't use those things.

+1


Problem downloading the model, not able to make connection.

is anyone experimenting this issue as well?
i think is not making handshake with hugging face,
requests.exceptions.ConnectionError: ('Connection aborted.', ConnectionResetError(10054, 'An existing connection was forcibly closed by the remote host', None, 10054, None))
These are the last logs before it breaks.
2024-03-05 16:15:32.392 | INFO     | xtts_api_server.server::73 - Model: 'v2.0.2' starts to load, wait until it loads
[XTTS] Downloading config.json...

Sorry for bothering but I'm having the same issue, did you ever figure out why?


sas-emitter plugin

Signed-off-by: Shripad Nadgowda<EMAIL_ADDRESS>Sas Emitter Plugin to emit data from K8S environment to SAS-compliant https headers.
Assumption:
1> Cloud-OE credetials are stored in k8s cluster in form of secrets and crawler is configured to mount these secrets
2> SAS-emitter plugin is configured in crawler/crawler.conf with the location of these credentials files
Changes incorporated:
1> read k8s credentials from cred files
2> update cloudoe/token in the https headers and access-group/namespace/timestamp/source-type as  query parameter

Codecov Report

Merging #287 into master will decrease coverage by 0.19%.
The diff coverage is 78.48%.

@@            Coverage Diff            @@
##           master     #287     +/-   ##
=========================================
- Coverage   89.22%   89.03%   -0.2%
=========================================
  Files         113      114      +1
  Lines        4251     4330     +79
=========================================
+ Hits         3793     3855     +62
- Misses        458      475     +17

Impacted Files
Coverage Δ

crawler/plugins/emitters/base_http_emitter.py
87.5% <100%> (+0.32%)
:arrow_up:

crawler/plugins/emitters/sas_emitter.py
78.2% <78.2%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fe4626...2d3b10b. Read the comment docs.

adding @niltonb. Satisfies your issue #250 ?


Add sinatra example

Only now I see that the Docker tag sinatra:demo is used. That works, but it is a bit cleaner to not use a tag :demo. Somethig like sinatra-secrethub-demo is more explanatory. So:
docker build -t sinatra-secrethub-demo .

Same goes for the other examples.


noSuchMethod, runtimeType are not hooked up on Array

From @jmesserly on June 16, 2016 22:16
noSuchMethod, runtimeType are not hooked up on Array ... strangely toString and hashCode work.
You can see this via the console:
let obj = [];
obj[dartx.toString]; // the toString method
obj[dartx.hashCode]; // returns a number
obj[dartx.runtimeType]; // undefined
obj[dartx.noSuchMethod]; // undefined

EDIT: toString and hashCode are both declared on JSArray so that explains the difference.
Copied from original issue: dart-lang/dev_compiler#592

FYI the test case where I caught this:
import "package:expect/expect.dart";

Invocation invocation;

class C {
  noSuchMethod(Invocation i) {
    invocation = i;
    return 42;
  }
}

expectNSME(Object d) {
  try {
    d.noSuchMethod(invocation);
  } on NoSuchMethodError catch (e) {
    Expect.isTrue(e.toString().contains('foobar'));
  }
}

main() {
  dynamic c = new C();
  Expect.equals(42, c.foobar(123));
  Expect.equals(invocation.memberName, #foobar);
  Expect.listEquals(invocation.positionalArguments, [123]);
  expectNSME(null);
  expectNSME(777);
  expectNSME('hello');
  // These fail because of https://github.com/dart-lang/dev_compiler/issues/592.
  // expectNSME([]);
  // expectNSME(['a', 'b', 'c']);
}

tracked this down. JSArray uses setExtensionBaseClass and that breaks _installProperties2 of dart.registerExtension. It expects to walk up the Dart superclass chain, but instead finds itself right back at Array.prototype, and ends up copying all properties from Array to Array. Oops.
The reason we do use setExtensionBaseClass is to reify generics, so we have a proto chain  (dart) JSArray<E> --> (JS) Array --> (JS) Object. That's fine, but JSArray<dynamic> ends up also linked Array, leading to the problem above.
I've got some ideas on how to fix this.

https://codereview.chromium.org/2962263002/


Rebased Code

Code update with rebased.

@rushirajsilvertouch Have you tried to compile the code? Fails with the following error:
package github.com/portainer/portainer/http/request: cannot find package "github.com/portainer/portainer/http/request" in any of:

	/usr/local/go/src/github.com/portainer/portainer/http/request (from $GOROOT)

	/go/src/github.com/portainer/portainer/http/request (from $GOPATH)

package github.com/portainer/portainer/http/response: cannot find package "github.com/portainer/portainer/http/response" in any of:

	/usr/local/go/src/github.com/portainer/portainer/http/response (from $GOROOT)

	/go/src/github.com/portainer/portainer/http/response (from $GOPATH)

You need to use github.com/portainer/libhttp/error and github.com/portainer/libhttp/response here.

Fixed the issue Lapenna  - Kindly check again.

Required small changes and validation are done - kindly check.

We have added User Id stored when creating the key and store whole stack module with new deploy key option. ->  Kindly check.

Give the actual ability to use the key to clone a git repository -> Can you provide the brief overview on how ssh key would be utilised to clone the repository?

ping @rushirajsilvertouch what is status with this one?
With updated documentation which most probably can close also #1926

@olljanat work on this one by @rushirajsilvertouch has been dropped. Any contribution to finish this work accepted, can be rebased of https://github.com/portainer/portainer/tree/feat1752-stack-deploy-keys

@deviantony ok but notice that I have no big interest to implement this as it does not fit to our use cases (look: #2448 ).
But based on https://github.com/portainer/portainer/issues/1926#issuecomment-437662167 this looks to be needed by paying customer so you most probably should prioritize it.


Texture get blended with principle base color

when i export a cube with a image texture, the texture get blended with a base color principle bsdf node.
see image below:

i use blender 3.0 beta and old trainz mesh viewer

Try this again with the latest version

worked, thanks

!


After read timeout, connection broken for a second timeout period

Using urllib3 1.12 to access etcd with a HTTPConnectionPool.  I do a long-poll read in a retry loop:
http = HTTPConnectionPool("localhost", 4001, maxsize=2)
while True:
    try:
        resp = http.request("GET", "http://localhost:4001/v2/keys/calico/v1",
                            fields={"recursive": "true", "wait": "true",
                                    "waitIndex": next_index},
                            timeout=5)
        resp_body = loads(resp.data)
    except ReadTimeoutError:
        _log.info("Watch read timed out, restarting watch at index %s",
                  next_index)
        continue
    else:
        ...

I expect some reads to time out because there was no data available.  In that case, I expect to hit the ReadTimeoutError, loop again and retry.  If there's then data waiting, I should get it immediately.
I do see the ReadTimeoutError after the first failure.  However, when my code retries, I see a 5s delay and then this log:
2015-10-15 09:38:16,311[DEBUG]273: Incremented Retry for (url='http://localhost:4001/v2/keys/calico/v1?waitIndex=7611342&recursive=true&wait=true'): Retry(total=2, connect=None, read=None, redirect=None)
2015-10-15 09:38:16,311[WARNING]625: Retrying (Retry(total=2, connect=None, read=None, redirect=None)) after connection broken by 'ReadTimeoutError("HTTPConnectionPool(host='localhost', port=4001): Read timed out.",)': http://localhost:4001/v2/keys/calico/v1?waitIndex=7611342&recursive=true&wait=true

Only then do I receive a response to my retry.

This is using normal Threads on Python 2.7, no gevent monkeypatching going on.

(It also repros 100% in my script.)

So just to clarify, when the 5s delay occurs on the second call to request(), before either of those logs is emitted?

Hmm, I'm a little bit interested in where your ReadTimeoutError is coming from. My suspicion is that you should be getting some retries before that hits, but I'd like to see proof. Can you show me the traceback immediately before you hit the hang?

Adjusted my script to give better diags:
2015-10-15 10:52:03,594 [INFO][46889/140035896854272] __main__ 64: About to call http.request...
2015-10-15 10:52:03,596 [INFO][46889/140035896854272] urllib3.connectionpool 207: Starting new HTTP connection (1): localhost
2015-10-15 10:52:03,598 [DEBUG][46889/140035896854272] urllib3.connectionpool 387: "GET http://localhost:4001/v2/keys/calico/v1?waitIndex=7653237&recursive=true&wait=true HTTP/1.1" 200 None
2015-10-15 10:52:08,604 [ERROR][46889/140035896854272] __main__ 72: Watch read timed out, restarting watch at index 7653237
Traceback (most recent call last):
  File "calico/felix/readetcd.py", line 69, in watch_etcd
    resp_body = loads(resp.data)
  File "/home/gulfstream/git/calico/env27/local/lib/python2.7/site-packages/urllib3/response.py", line 164, in data
    return self.read(cache_content=True)
  File "/home/gulfstream/git/calico/env27/local/lib/python2.7/site-packages/urllib3/response.py", line 292, in read
    flush_decoder = True
  File "/usr/lib/python2.7/contextlib.py", line 35, in __exit__
    self.gen.throw(type, value, traceback)
  File "/home/gulfstream/git/calico/env27/local/lib/python2.7/site-packages/urllib3/response.py", line 219, in _error_catcher
    raise ReadTimeoutError(self._pool, None, 'Read timed out.')
ReadTimeoutError: HTTPConnectionPool(host='localhost', port=4001): Read timed out.
2015-10-15 10:52:08,606 [INFO][46889/140035896854272] __main__ 64: About to call http.request...
2015-10-15 10:52:13,611 [DEBUG][46889/140035896854272] urllib3.util.retry 273: Incremented Retry for (url='http://localhost:4001/v2/keys/calico/v1?waitIndex=7653237&recursive=true&wait=true'): Retry(total=2, connect=None, read=None, redirect=None)
2015-10-15 10:52:13,612 [WARNING][46889/140035896854272] urllib3.connectionpool 625: Retrying (Retry(total=2, connect=None, read=None, redirect=None)) after connection broken by 'ReadTimeoutError("HTTPConnectionPool(host='localhost', port=4001): Read timed out. (read timeout=5)",)': http://localhost:4001/v2/keys/calico/v1?waitIndex=7653237&recursive=true&wait=true
2015-10-15 10:52:13,612 [INFO][46889/140035896854272] urllib3.connectionpool 207: Starting new HTTP connection (2): localhost
2015-10-15 10:52:13,613 [DEBUG][46889/140035896854272] urllib3.connectionpool 387: "GET http://localhost:4001/v2/keys/calico/v1?waitIndex=7653237&recursive=true&wait=true HTTP/1.1" 200 None

Yes, there's a 5s delay after the second call to request.
In case it helps, etcd pushes its headers immediately and then it's the read of the body that times out.

Right, ok, so that was roughly my theory. For people other than me, it should be noted that etcd sends chunked transfer encoding for its responses. This means that urllib3 does not preload the content, which means that a ReadTimeout is not raised from urlopen but instead from .data.
The problem here is that we try to close the socket but it doesn't work (silently), because we technically don't have access to the connection. This is due to this interesting selection of code:

# First, in ConnectionPool.urlopen

if release_conn is None:
    release_conn = response_kw.get('preload_content', True)

...

response_conn = not release_conn and conn
response = HTTPResponse.from_httplib(httplib_response,
                                     pool=self,
                                     connection=response_conn,
                                     **response_kw)

# Then, in HTTPResponse.__init__

# We certainly don't want to preload content when the response is chunked.
if not self.chunked and preload_content and not self._body:
    self._body = self.read(decode_content=decode_content)

# Then back in ConnectionPool
finally:
    if release_conn:
        # Put the connection back to be reused. If the connection is
        # expired then it will be None, which will get replaced with a
        # fresh connection during _get_conn.
        self._put_conn(conn)

This is a problem: the response is basically overriding the logic of preload_content, which is not only local to the response. Essentially, the response is choosing not to preload the content if it's chunked, which is a bad idea.
I believe this is the root of the problem: because the connection still exists (in the pool), our error handling code in the response closes its handle on the socket, but the connection keeps its one open. However, the socket is in an error state, so it's no longer useful.
Removing the (totally unnecessary) preload exemption for chunked transfer encoding will resolve the problem.

I have a suspicion, looking into this, that our connection handling following errors in preload_content=True requests might not be quite right either, so I'm going to chase that a little bit this afternoon and see if I'm right.

Did you mean preload_content=False?  Either setting seemed to fail in the same way for me on vanilla 1.12.

Ah, yes, I did. =) Sorry!

Hmm, I can't reproduce my concern in a controlled environment. That's not to say it doesn't exist, just that I'm not necessarily trying hard enough to make it work.

@Lukasa are you sure.  I think I still saw the issue with preload=False.  I can double check if you want.

@fasaxc This was not your original issue, it was a related one I believe I saw when I was diving through the source.


Why and How to Solve Vim and Gvim Not Listening Content of Specific Folders on Windows 11

Steps to reproduce
1.Go to the explorer and search for a folder
2.Open it and see if the Netrw Directory Listing is Showing up with anything
Expected behaviour
At least in my case my Vim's Netrw is not listing anything in an specific folder that has a .cs (Csharp) file in it.
It is neither showing "../" nor "./" lines

Version of Vim
9.1
Environment
Windows 11
Logs and stack traces
No response

Sorry the name that I created had symbols


[WIP] System.Exception

@matejr
Thoughts?

All exception classes should end with the word "Exception".

Thanks

Will update when I get a chance soon

I'll make more comments. This commit is much more complex than I anticipated and I'll need some time.

Yeah, there's probably more issues or at least tweaks to be made. I whipped
it together quickly, buut also, I'm not super familiar with .NET. However,
I wanted to address the issue you brought up about abuse of
System.Exception.

In general, I wouldn't throw exception that inherits from FormatException unless the method parses a string. Throw or inherit from ArgumentException instead. For example, .NET throws ArgumentException (in fact DecoderFallbackException) if the byte array doesn't contain valid UTF-8 characters.

Thanks, will take on board

@matejr
I squashed it down to one commit with your changes, and credited you with --author ship.  When you're ready, I'll push to master rather than use Github and a merge commit.


DBFormatter formatDict/formatList to native string instead of bytes

Fixes #10638
Status
ready (tested in WMA Py3)
Description
When formatting the output of the relational database queries, decode bytes to native strings in python3. At the same time, stop encoding python2 native strings to bytes.
Is it backward compatible (if not, which system it affects?)
yes, hopefully!
Related PRs
Cherry-picked one of the commits from https://github.com/dmwm/WMCore/pull/10635
External dependencies / deployment changes
None

Dario, we already had a chat on this subject and we do not see any blocker. So I'm merging it now, but please do leave any comments/concerns that you might have.


Add Find methods for queues

Allow for a search for if an item is in a queue

Due to generics, will require a comparator to be passed


feat(shield): add limit, page, keyword for pagination and filter

Update shield.proto
Add limit, page, keyword for pagination and filter.

@niharbansal02 Let's follow the guidelines suggested in this doc for pagination.


2 slides needed, but inspector shows 10 created after slider is initialized

Not sure why 5 clones are needed for each slide. It seems an overkill to me.
I've noticed this only happens when loop is set to true, but still the amount of clones looks like a lot
http://ganlanyuan.github.io/tiny-slider/tests/index.html
v2.6.0
Chrome latest
Mac OS

Yes, 5 times of items are needed for the transforms.
I will update it to make less clones if slides are more than items later.

Fixed in v2.7.0


Unresolvable dependency resolving when using PHPUnit\Runner\AfterLastTestHook

Describe the bug
When dumping data from a custom PHPUnit extension that hooks into AfterLastTestHook::executeAfterTest(), I receive this console output:
Unresolvable dependency resolving [Parameter #0 [ <required> array $settings ]] in class Spatie\Ray\Settings\Settings

I've attempted to set every ray.php setting to false, but removing the package does allow the test to pass and the hook to function.
Versions
Ray version (you can see this in "About Ray"):
You can use composer show to get the version numbers of:
spatie/backtrace                     1.2.0     A better backtrace
spatie/laravel-query-builder         3.5.0     Easily build Eloquent queries from API requests
spatie/laravel-ray                   1.24.2    Easily debug Laravel apps
spatie/macroable                     1.0.1     A trait to dynamically add methods to a class
spatie/query-string                  1.0.3     Manipulate query strings
spatie/ray                           1.30.0    Debug with Ray to fix problems faster
PHP version: PHP 7.4.21
Laravel version (if applicable): 8.52.0
To Reproduce
Steps to reproduce the behavior:
Add this to your phpunit.xml:
<phpunit ...>
  <extensions>
    <extension class="Tests\TestHook" />
  </extensions>
</phpunit>

Add this in your tests folder:
<?php

namespace Tests;

use PHPUnit\Runner\AfterTestHook;

class TestHook implements AfterTestHook
{
    public function executeAfterTest(): void
    {
        dump('anything');
    }
}

Expected behavior
Expect no error
Screenshots

Desktop (please complete the following information):

OS: macOS
Version 11.5.1

Additional context
N/A

Running into a similar issue in phpunit:
The register_shutdown_function (https://github.com/spatie/ray/blob/main/src/helpers.php#L54) calls ray()
and ray() runs app(LaravelRay::class)->send(...$args);
LaravelRay => https://github.com/spatie/laravel-ray/blob/main/src/Ray.php
needs Settings $settings in the constructor
Settings needs an `array in the constructor => https://github.com/spatie/ray/blob/main/src/Settings/Settings.php#L23
Which is only available when RayServiceProvider is loaded: https://github.com/spatie/laravel-ray/blob/main/src/RayServiceProvider.php#L61
The thing is, we don't use spatie/ray atm
spatie/ray is required by spatie/laravel-ray which is required by orchestra/testbench
Any way for this to be fixed?
$ phpunit
PHPUnit 9.5.8 by Sebastian Bergmann and contributors.

...............................................................  63 / 337 ( 18%)
............................................................... 126 / 337 ( 37%)
............................................................... 189 / 337 ( 56%)
............................................................... 252 / 337 ( 74%)
............................................................... 315 / 337 ( 93%)
......................                                          337 / 337 (100%)

Time: 00:08.431, Memory: 48.00 MB

OK (337 tests, 1859 assertions)
PHP Fatal error:  Uncaught Error: Call to a member function send() on null in my-project/vendor/spatie/ray/src/helpers.php:23
Stack trace:
#0 my-project/vendor/spatie/ray/src/helpers.php(55): ray()
#1 [internal function]: {closure}()
#2 {main}
  thrown in my-project/vendor/spatie/ray/src/helpers.php on line 23
PHP Stack trace:
PHP   1. {main}() my-project/vendor/phpunit/phpunit/phpunit:0
PHP   2. PHPUnit\TextUI\Command::main($exit = *uninitialized*) my-project/vendor/phpunit/phpunit/phpunit:92
PHP   3. PHPUnit\TextUI\Command->run($argv = [0 => 'vendor/bin/phpunit'], $exit = TRUE) my-project/vendor/phpunit/phpunit/src/TextUI/Command.php:96
PHP   4. PHPUnit\TextUI\TestRunner->run($suite = class PHPUnit\Framework\TestSuite { protected $backupGlobals = NULL; protected $backupStaticAttributes = NULL; protected $runTestInSeparateProcess = FALSE; protected $name = ''; protected $groups = ['default' => [...]]; protected $tests = [0 => class PHPUnit\Framework\TestSuite { ... }]; protected $numTests = 337; protected $testCase = FALSE; protected $f3

Fatal error: Uncaught Error: Call to a member function send() on null in my-project/vendor/spatie/ray/src/helpers.php on line 23

Call Stack:
    0.0169     408008   1. {main}() my-project/vendor/phpunit/phpunit/phpunit:0
    0.3172   14589168   2. PHPUnit\TextUI\Command::main($exit = ???) my-project/vendor/phpunit/phpunit/phpunit:92
    0.3172   14589280   3. PHPUnit\TextUI\Command->run($argv = [0 => 'vendor/bin/phpunit'], $exit = TRUE) my-project/vendor/phpunit/phpunit/src/TextUI/Command.php:96
    0.5826   20039312   4. PHPUnit\TextUI\TestRunner->run($suite = class PHPUnit\Framework\TestSuite { protected $backupGlobals = NULL; protected $backupStaticAttributes = NULL; protected $runTestInSeparateProcess = FALSE; protected $name = ''; protected $groups = ['default' => [...]]; protected $tests = [0 => class PHPUnit\Framework\TestSuite { ... }]; protected $numTests = 337; protected $testCase = F3

Error: Call to a member function send() on null in my-project/vendor/spatie/ray/src/helpers.php on line 23

Call Stack:
    0.0169     408008   1. {main}() my-project/vendor/phpunit/phpunit/phpunit:0
    0.3172   14589168   2. PHPUnit\TextUI\Command::main($exit = ???) my-project/vendor/phpunit/phpunit/phpunit:92
    0.3172   14589280   3. PHPUnit\TextUI\Command->run($argv = [0 => 'vendor/bin/phpunit'], $exit = TRUE) my-project/vendor/phpunit/phpunit/src/TextUI/Command.php:96
    0.5826   20039312   4. PHPUnit\TextUI\TestRunner->run($suite = class PHPUnit\Framework\TestSuite { protected $backupGlobals = NULL; protected $backupStaticAttributes = NULL; protected $runTestInSeparateProcess = FALSE; protected $name = ''; protected $groups = ['default' => [...]]; protected $tests = [0 => class PHPUnit\Framework\TestSuite { ... }]; protected $numTests = 337; protected $testCase = F3
    9.1687   47677064   5. {closure:my-project/vendor/spatie/ray/src/helpers.php:54-56}() my-project/vendor/spatie/ray/src/helpers.php:0
    9.1687   47677064   6. ray() my-project/vendor/spatie/ray/src/helpers.php:55

this fixes phpunit:
$ composer require spatie/ray:1.29.2 --dev
./composer.json has been updated
Running composer update spatie/ray
Loading composer repositories with package information
Updating dependencies
Lock file operations: 0 installs, 1 update, 0 removals
  - Downgrading spatie/ray (1.30.0 => 1.29.2)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 0 installs, 1 update, 0 removals
  - Downloading spatie/ray (1.29.2)
  - Downgrading spatie/ray (1.30.0 => 1.29.2): Extracting archive

$ phpunit
PHPUnit 9.5.8 by Sebastian Bergmann and contributors.

...............................................................  63 / 337 ( 18%)
............................................................... 126 / 337 ( 37%)
............................................................... 189 / 337 ( 56%)
............................................................... 252 / 337 ( 74%)
............................................................... 315 / 337 ( 93%)
......................                                          337 / 337 (100%)

Time: 00:00.718, Memory: 42.00 MB

OK (337 tests, 1859 assertions)

Diff link: https://github.com/spatie/ray/compare/1.29.2...1.30.0#diff-7827dcf8c28ba9d97397f03b4ca75c132540f5c377e253fbc47ef064a373ce73R54

Hey, is there an update on this issue? :)

No, but we are open for a PR that fixes your issue

I got the same error when running xdebug and ray together running PHP8.1;
Illuminate\Contracts\Container\BindingResolutionException: Unresolvable dependency resolving [Parameter #0 [ <required> array $settings ]] in class Spatie\Ray\Settings\Settings

But maybe I'am missing a setting?

@tdwesten I have the same issue using PHP 7.4 and pcov.
Did you mamage to fix that issue?


Add linuxArm64 and watchosDeviceArm64 targets to runtime

linuxArm64 was added before but reverted because of missing coroutines support: https://github.com/JetBrains/compose-multiplatform-core/pull/382 Coroutines 1.7.x added support for these targets.
I'd submit a pr for adding these targets but jb-main is still using coroutines 1.6.x and I'm not sure how your process is for pulling changes from androidx-main works.

The androidNative* targets also are supported by coroutines now but not sure how much sense it makes to add these to the compose runtime.

Hello. Unfortunately we have to wait til Compose starts using Coroutines 1.7. As we see Jetpack Compose uses Coroutines 1.7 only in Compose 1.6 so the most probably Compose Multiplatform will start using Coroutines 1.7 in Compose 1.6 as well (and it won't happen in the near months).

Thanks for the update

https://github.com/JetBrains/compose-multiplatform-core/blob/jb-main/gradle/libs.versions.toml#L45 It looks like the main branch is now on couroutines 1.8.0-RC so the blocked should be gone. Maybe runtime could even get the new wasm target?

The runtime already has wasmJS support since 1.6.0-alpha01.

Ah nice, I somehow missed that, then it's just the 2 targets from the original request

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.


Split the bots guide.

The initial commit splits the guide only section-wise, with minimal changes done to the new guides:

For the writing-bots-guide, those changes are visible in the diff
For the running-bots-guide, I

changed the docs title
removed two items from the On this page you'll find list

This is not ready to merge, since both new guides still have some overlap in the introduction, and don't feel properly ordered.
Feedback for the existing commits is welcome.

@eeshangarg added your suggestion in the last commit.
@timabbott this is now ready for full review/merge.

OK, I'm merging this, with a few commits on top to rewrite the introductions to the guides (which had way too much intro text), and also some slight reordering of the docs/index.rst.
Also, I had to fix one broken link; remember to run tools/test-documentation when editing user docs.
Thanks for doing this @derAnfaenger!