[REQUIRED] Step 2: Describe your environment  Xcode version: 10.2.1 Firebase SDK version: 6.5.0 Firebase Component: Core Analytics Performance (Auth, Core, Database, Firestore, Messaging, Storage, etc) Component version: __ the latest_ [REQUIRED] Step 3: Describe the problem  when i usepod 'WCDB', :git => "git@github.com:Tencent/wcdb.git" ,:commit => 'c09d0193' in podfile， some problem happend in iOS12 like this  Failed to recreate database file. Error: Error Domain=com.google.gmp.measurement.ErrorDomain Code=3 "Database operation "prepare statement" failed with sqlite code 0 and error message "not an error"" UserInfo={NSLocalizedDescription=Database operation "prepare statement" failed with sqlite code 0 and error message "not an error", APMMonitorContext=prepare statement,0,A,4}  but is all right in iOS11

[READ] Step 1: Are you in the right place?

For issues or feature requests related to the code in this repository
file a Github issue.

If this is a feature request make sure the issue title starts with "FR:".

For general technical questions, post a question on StackOverflow
with the firebase tag.
For general Firebase discussion, use the firebase-talk
google group.
For help troubleshooting your application that does not fall under one
of the above categories, reach out to the personalized
Firebase support channel.

[REQUIRED] Step 2: Describe your environment

Xcode version: _____
Firebase SDK version: _____
Firebase Component: _____ (Auth, Core, Database, Firestore, Messaging, Storage, etc)
Component version: _____

[REQUIRED] Step 3: Describe the problem
Steps to reproduce:
What happened? How can we make the problem occur?
This could be a description, log/console output, etc.
Relevant Code:
// TODO(you): code here to reproduce the problem

Duplicate of #3601


[openmm] 7.1.1

This should build the 7.1.1 release candidate and push it to the rc label.

So OpenMM is building when Travis does not time out (nvidia problems). However, there are some problems with it.

The linux builds throw an error on doc creation with this error: gmake[4]: warning: jobserver unavailable: using -j1.  Add +' to parent make rule`. I can't directly link it since its only in the raw log. The build completes, but I'm concerned the docs are not building.
The CPU energies are not computing throwing this

2 CPU - Error computing forces with CPU platform
CPU platform error: St8bad_cast

Normally the CPU computes fine. The builds from the main OpenMM site and from the conda-dev recipes which are already on conda-forge work fine too. So I'm not really sure what is happening here.
Caveat: The dev channel and the main site have all the changes, not just the cherry picked ones for 7.1.1
@peastman have you ever seen this problems?

Is $CPU_COUNT not being defined?
We can change lines like these to get rid of the -j# argument if this is causing problems:
https://github.com/omnia-md/conda-recipes/blob/96dafcabbfc4d5644e89c8927a9a7286c3679dfa/openmm/build.sh#L114

CPU platform error: St8bad_cast

I haven't seen anything like that.  It works when I run it locally.

We've seen this error in conda-dev-recipes at least as far back as Mar:
https://travis-ci.org/omnia-md/conda-dev-recipes/jobs/208704834#L6967
Perhaps there is some weird system on travis for limiting the number of threads?
I bet if we set the environment variable OPENMM_CPU_THREADS=1 on the same line that the test is run it would work fine.

Do you have any way to reproduce that error locally?  It's hard to even guess where it's happening or what could be causing it.

I think you can run travis docker images locally, but I'm not sure if that would exactly reproduce the issue since the underlying hardware will be different.

Welp, I was wrong---OPENMM_CPU_THREADS=1 didn't help.
===== openmm-7.1.1-py27_0 OK =====
+ /bin/bash -x -e /anaconda/conda-bld/openmm_1493686863494/test_tmp/run_test.sh
+ env OPENMM_CPU_THREADS=1 python -m simtk.testInstallation
There are 4 Platforms available:

1 Reference - Successfully computed forces
2 CPU - Error computing forces with CPU platform
NVIDIA: no NVIDIA devices found
NVIDIA: no NVIDIA devices found
NVIDIA: no NVIDIA devices found
3 CUDA - Error computing forces with CUDA platform
4 OpenCL - Error computing forces with OpenCL platform

OpenCL platform error: Error initializing context: clGetPlatformIDs (-1001)

CPU platform error: St8bad_cast

CUDA platform error: Error initializing CUDA: CUDA_ERROR_UNKNOWN (999) at /anaconda/conda-bld/openmm_1493686863494/work/platforms/cuda/src/CudaContext.cpp:148

Are we certain this only affects the CPU platform?  It looks possible that the OpenCL and CUDA platforms would also have the same problem, only they fail before they can reach it due to the lack of an available device.
The way you get a bad_cast is by doing a dynamic_cast on a reference, and we don't do that in many places.  It looks to me like this is probably happening when it tries to cast a KernelImpl defined in the plugin, such as casting a CpuCalcNonbondedForceKernel& to a CalcNonbondedForceKernel&.  And it somehow thinks it's not actually an instance of that.  Perhaps this could be caused by using different compilers or different compilation flags for the plugin and the main library?  But I don't see why that would be happening.  It isn't trying to build static libraries, is it?

I'm not sure that its limited to just the CPU platform, but there is no way to test it on CUDA and OpenCL on travis.
I can't find anything that changed between now and the last time 7.1.0rc1 was built which was back in December. The only thing that should have changed was the 7.1.1 code, and maybe the conda/conda package versions. The build image did not change.

There haven't been any changes to the CPU platform, or any changes to the build scripts.  So that doesn't seem like an explanation.
John, you said it's been happening on conda-dev-recipes for a while.  Do you know when it started?

John, you said it's been happening on conda-dev-recipes for a while. Do you know when it started?

I'm at a conference today, but maybe @Lnaden can look through the travis history for that repo?

Can do!

The CPU throwing bad_cast has been a problem since the 7.1_branch of OpenMM was created at least.
From the logs in travis, the CPU platform has been failing with the bad_cast since 88b0a3e at the earliest and the 7.1_branch builds on travis have been generating bad_cast since its creation. I can't look back further than build 472 on Travis as the logs dont load past that point; probably not saved, its >4 months old at this point.
I also don't think that the jobserver unavailable errors are fatal as it appears to not stop the build.

The CPU throwing bad_cast has been a problem since the 7.1_branch of OpenMM was created at least.

I just created that branch a couple of days ago.  You can't tell anything before that?

Sorry. Got my branches mixed up, its been doing that since the creation of the openmm-7.1-beta on the conda-recipes repo which was 5 months ago.

...Which is when it was pinned to commit 88b0a3e on OpenMM

I would guess that it goes back further since the only changes made on that commit were Windows changes and the issue is in Linux. However, the Travis logs do not appear to be saved back that far, or at least are throwing errors.

It may be worth noting the problem goes away after I merged in the changes to make the dev-recipes channel switch to conda-forge.

its been doing that since the creation of the openmm-7.1-beta on the conda-recipes repo which was 5 months ago.

Do you mean conda-recipes or conda-dev-recipes?  The former clearly was working more recently, since we didn't have this problem when we built 7.1.  But if conda-dev-recipes was failing while conda-recipes was working, that certainly suggests the problem is in the recipe.

I specifically meant conda-dev-recipes, thats the only history I went over. It will be a bit harder to track down if the build ever failed on conda-recipes since I will need to go find the last time OpenMM actually built on that repo. I suppose I can go look at the history and try to find the CI checks from that PR.

I specifically meant conda-dev-recipes

That's what I assumed.  You said conda-recipes, which is why I was confused.
So this error has been happening on conda-dev-recipes for a while, but just started happening on conda-recipes recently (some time since 7.1 was built).  Of the various updates since then, this one looks the most suspicious: https://github.com/omnia-md/conda-recipes/commit/528c7ca2f2d82b30e4e9d035af361bd8c7a7fb6d.  It was checked in the day after 7.1 was released.  It has the innocuous sounding description, "Rename to 7.1.0rc1," but in fact makes tons of changes to lots of files.

I found that too, but I am trying to find exactly which change introduced the error. The problem is that the CI tests often never make it to the meta.yaml test section because of an earlier crash

So you are right in that it is that change to the main recipe when the errors started showing up. However, the change before that was back on #534 where it was still working.
Now trying to find exactly which change to the file caused this to fail, I have looked through the conda-dev-recipes version of the meta.yaml file and the change appears to happen on this version of the file with this diff which changed from triclinicerror tag to 88b0a3e. At that point, the error started appearing. It was already on swig 3.0.8, and there were no other changes to the file. So I'm not sure the issue comes from a large change to the meta.yaml file.

Although.... I can't seem to access the travis logs now. ugh, maybe im wrong

Any progress on figuring this out?

Not really, I can't reproduce locally, I can't even get the docker image working right. This has been a symptom for over 5 months now though and I have not heard users complain, so it may be related to Travis-CI or something that changed running the linux build in a docker image on travis unable to access the CPU.
I say we fix the git hash to get the addition of that one other issue, rebuild, merge onto dev, and test from the dev tag

Sounds like a plan.  Do you need me to do anything?

The Windows build. For the Linux and OSX ones, probably not.

OSX and Linux builds are completing for OpenMM, merging so we can start local testing

OSX and Linux builds are up on the rc tag, ready for testing.
@peastman Do you need anything from us for helping with the Windows builds?

I managed to build the files for the Windows zip installer.  I don't know why it failed before.  I updated the code to get the one extra change, uninstalled FFTW, reinstalled it, ran the build script, and this time it worked.
Which recipe should I use for building the conda installer?  The one here, or the one at conda-dev-recipes?

Do you mean the conda-recipe For the 7.1.1 files? The one here


DavidW: Watch stevewebservice.com/

DavidW requests the watch of the watch_keyword stevewebservice\.com/. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

stevewebservice\.com/ has been seen in 0 true positives, 0 false positives, and 0 NAAs.

Rejected by cigien in Charcoal HQ. Reason: 'duplicate. (Not really, but it was blacklisted before the watch was approved)'


Show previous/next diagnostic with phantom

Press  F8 to open/next, shift+F8 for previous, esc to close. (see suggested keybindings)

Essentially like VS Code's "Next Problem" feature.
Suggested keybindings
{ "keys": ["f8"], "command": "lsp_next_diagnostic"},
{ "keys": ["shift+f8"], "command": "lsp_previous_diagnostic"},
{ "keys": ["escape"], "command": "lsp_hide_diagnostic", "context":
	[
		{ "key": "setting.lsp_diagnostic_phantom"}
	]
}

Closes #746:

Allows navigation for those who don't like to use the panel for it (SublimeLinter style)
Allows a faster and more readable way to see a diagnostic + related info than hovering.

Implementation details:

The DiagnosticsPresenter passes user actions (forward/back) and server diagnostic updates into the DiagnosticsCursor
The cursor selects a different walking logic based on an already-selected diagnostic or a cursor position in a file.
The Escape key is "stolen" if the view has a lsp_diagnostic_phantom setting applied. There is some risk with stealing a so often-used key.
Phantoms are not hidden if a diagnostic disappears.

To do:

[x] Implement UI + wire up Esc for dismissing phantoms
[x] Implement UI for related info
 Update UI for code actions (if keeping at all)
[x] Review behaviour when diagnostics removed/moved/added.
[x] Only include warnings and errors (See https://github.com/Microsoft/vscode/issues/45436)
[x] UI polish (add prev/next, related info spacing and color, top arrow, rounded corners?)
[x] Organize diagnostics code and add unit tests

Coverage decreased (-1.05%) to 34.906% when pulling 2aa93b3aebcc7adbd8d0cf0b355080456c35be26 on select-and-phantom-diagnostic into 825c9c4f3e7a556700f69e1f1ccd85f598cb36a6 on master.

I haven't really looked at all the code yet, but I noticed these two things:

The whiteish/bluish box around the related diags is not present. Is this intentional? It feels to me as if this part should share the same css code as the hover popup.

The command lsp_next_diagnostic does not cycle back to the beginning of the phantoms list, but lsp_previous_diagnostic does cycle forward to the end of the phantoms list if invoking it on the first diag. I think they should both have the cycle behavior.

Good catch, even had a TODO for testing the missed wrap-forward from diagnostic logic
The color was doable in this manner:

But I feel the extra markup/css is a bit unfortunate.
The amount of styling on hovers gets a little distracting, like this example:

For me the additional info is part of the error and could just be red.

For me the additional info is part of the error and could just be red.

I'm okay with having it red, but IMO there should be some sort of separation between the main diag and the related diags. Indentation for the related diags perhaps? Or a horizontal line?

I like your suggestion of the horizontal line a lot (I tried indent too but this is more space-efficient)

Looks good!

I will merge this now and document it when we get to a release soon!


⚠ Bofrost.be has degraded performance

In b819749, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1290 ms

Resolved: Bofrost.be performance has improved in f7912fc after 11 minutes.


Include map extents in routing

When used for navigation, this should always show the entire map that was last viewed.  That is, if a browser window is not the same aspect ratio as the original that formed the route, the map will include more area that the original.
Also, there should be a 'recenter' button to go back to the default location and zoom.

Added in PR #42.


event-owner property of email not getting the right AWS username

Just setting up an issue ticket pertaining to my PR.
When using c7n_mailer to enable email notifications on a policy, I want an email sent directly to the user who created/triggered that event.
Example use case:
I have a policy discouraging doing cidr <IP_ADDRESS>/0 as a security group rule in non-productions.
I want the policy to email the user who did the change and cc to the Ops teams.
policies:
  - name: open-network-sg-rule
    resource: security-group
    mode:
      type: cloudtrail
      role: arn:aws:iam::123456789:role/custodian-monitor
      events:
        - event: AuthorizeSecurityGroupIngress
          source: ec2.amazonaws.com
          ids: requestParameters.groupId
    filters:
      - type: ingress
        Cidr:
          value: <IP_ADDRESS>/0
          op: eq
          value_type: cidr
    actions:
      - type: notify
        template: default.html
        priority_header: 2
        subject: "[Cloud Custodian] Security Group Rule Violation! - Too Open!"
        violation_desc: |
          IP Range to the open world (<IP_ADDRESS>/0) should not be used!
          You should only whitelist by Security Group ID or specific single IP
        to:
          -<EMAIL_ADDRESS>          - event-owner
        transport:
          type: sqs
          queue: https://sqs. us-west-2.amazonaws.com/123456789/email_queue
          region: us-west-2

Currently when using the event-owner in the to: field, the lambda function gets the PrincipalID from the UserIdentity section of the cloudtrail event. This normally results in the actual IAM Access Key which in turn results in an invalid email sent.

This is fixed in #1183


Fix checkboxes look & Add exit prompt to upload page

It looks like some of the checkbox changes from #119 have got mixed up with this branch - I'm guessing because this branch started on top of the other branch, rather than on master. The checkbox changes have been merged already, so it's a bit confusing to have them in this branch as well.
Maybe we can sort out the git history when we're pairing later today?

Ah, yes. Sure! It's weird as the commit is exactly the same.

@TomJKing Would you mind reviewing this one? Nigel and I paired on refactoring it, so it would be good to get a third person's opinion, especially since you're more familiar with Jest tests than me. 🙂
@techncl You can update the title of this PR now we've edited it to remove the old SCSS commit.


static_hasmethod tweaks

Hi @mileslucas @icweaver , I was having some issues using KeywordCalls with MeasureTheory where using MeasureTheory would give me a few screenfulls of warnings. I managed to fix it here.
One problem is that it's failing tests for contructors with default values. I'll try to find a workaround, but if no one's using it I might consider removing it temporarily. OTOH functions with defaults seem to be fine, and Breakage says Transits.jl tests still pass.

Hi @cscherrer, sorry for missing your ping! Thanks for the update, right, things still look to be working alright on our end! Just to make sure I am following the potential issue here, is the problem with just using default values with @kwstruct?

No worries :)
Yeah, so in runtests.jl, the setup is
struct Bar{N,T}
    nt::NamedTuple{N,T}
end

@kwstruct Bar(a,b,c=0)

Then
julia> Bar((a=2,b=3,c=4))
Bar{(:a, :b, :c), Tuple{Int64, Int64, Int64}}((a = 2, b = 3, c = 4))

julia> Bar((a=2,b=3))
Bar{(:a, :b), Tuple{Int64, Int64}}((a = 2, b = 3))

so basically defaults don't work with @kwstruct. I didn't spend too long trying to get it working, but I don't use this feature anyway and it looked like it wasn't coming up in your library either so I went ahead with it.

Ah, sounds good. Right, I think we're happy to just keep using outer constructors for our use case!


Getting access_token to use for API requests to Google

Hello All,
I'm not sure if devise_token_auth is the right tool for this job. I'm currently using devise_token_auth with omniauth_oauth2 and omniauth-google-oauth2 to authenticate users and this is working fine.
What I want to do is to somehow use the existing tokens saved in the DB, which have been authorized by the users already, to make requests against Google oauth APIs such as getting user's Contacts or listing their Drive files.
I've read a bunch of tutorials on how to do this with just omniauth_oauth2, omniauth-google-oauth2 and the google-api-client, but none of them explain how to integrate this with devise_token_auth.
I looked through the code and didn't see that devise_token_auth actually saves the refresh_token either, which is needed to get updated access_token.
Is this possible with devise_token_auth or do I need to build a custom solution?
Thanks,
Colin

Hi,
I am having the same issue. I am using Instagram omniauth adaptor but then I would like to use the Instagram gem to call the API but I don't have access to the Instagram access_token of the logged in user.


Fix #12

Closed by commit https://github.com/blankogmbh/kirby-git-commit-and-push-content/commit/2118b281fc4353888ea7f630c2876693c23bd073

👍


Refactor classes to use hooks

Milestone: Hooks
The following changes are being introduced:

Refactor code to use hooks
Code doesn't run on the browser without errors. A new entry prop is introduced. All efforts to resolve this have failed. An alternative look into it is needed.

Thanks @CollinsTatang


Update limits-specifications-teams.md

https://github.com/MicrosoftDocs/OfficeDocs-SkypeForBusiness/issues/4976
Fixed typo

@JohanFreelancer9 Copy editing is needed for this PR. Thanks.

@LolaJacobsen
PR has been copyedited and is ready for final review, could you please check and merge? Thanks!


Missing examples

Hey, how to use this API?

There are no examples because I haven’t touched this in 3 years. It also won’t work with Dart 2, so I recommend just using package:http directly.
That being said, I’ll probably archive+discontinue this library, as I have no intention of ever completing it.

Okay, i understand that, eventhough i'd find a working Paypal API very useful


pluralchum could not be started

TypeError: Modules is not iterable
at Pluralchum.forceMessageRefresh (eval at requireAddon (:4:43355), :225:26)
at Pluralchum.start (eval at requireAddon (:4:43355), :218:10)
at Object.startPlugin (:4:43903)
at Object.startAddon (:4:43696)
at Object.enableAddon (:4:10436)
at Object.toggleAddon (:4:10681)
at Object.togglePlugin (:4:41036)
at A.onChange (:4:101873)
at m.onChange (:4:96985)
at Object.Ye (https://discord.com/assets/2417af15fabc622ecc0f.js:1453:658)
at qe (https://discord.com/assets/2417af15fabc622ecc0f.js:1453:812)
at https://discord.com/assets/2417af15fabc622ecc0f.js:1473:409
at Pr (https://discord.com/assets/2417af15fabc622ecc0f.js:1473:506)
at Mr (https://discord.com/assets/2417af15fabc622ecc0f.js:1473:920)
at https://discord.com/assets/2417af15fabc622ecc0f.js:1479:680
at Ge (https://discord.com/assets/2417af15fabc622ecc0f.js:1561:404)
at https://discord.com/assets/2417af15fabc622ecc0f.js:1475:395
at Br (https://discord.com/assets/2417af15fabc622ecc0f.js:1475:425)
at rn (https://discord.com/assets/2417af15fabc622ecc0f.js:1462:757)
at nn (https://discord.com/assets/2417af15fabc622ecc0f.js:1462:7)
at t.unstable_runWithPriority (https://discord.com/assets/2417af15fabc622ecc0f.js:1662:828)
at Ko (https://discord.com/assets/2417af15fabc622ecc0f.js:1484:117)
at we (https://discord.com/assets/2417af15fabc622ecc0f.js:1561:144)
at en (https://discord.com/assets/2417af15fabc622ecc0f.js:1461:800)
at HTMLDivElement.r (https://discord.com/assets/40b8dd053309f0ba5d75.js:145:559)

Discord just pushed out a massive change to its internals that breaks practically every BetterDiscord plugin out there, PluralChum included. Nothing I can do about it at the moment. Might take a rewrite to get PC working again, which I can't give an ETA for. See https://github.com/BetterDiscord/BetterDiscord/issues/1404#issuecomment-1258808958 for more info.


test(deisctl): parallelize all of the things

In theory this should speed your builds up. We should test to confirm that there is a performance benefit.
Before:
$ time make -C deisctl test
...
real 0m21.975s
user 0m15.506s
sys  0m4.569s

After:
$ GOMAXPROCS=4 time make -C deisctl test
...
15.98 real        15.70 user         6.10 sys

I'd appreciate it if anybody has any time to test this and report if this had enough impact to warrant merging

I get numbers roughly like yours when I run the tests, but that's using the default of 1 goroutine. GOMAXPROCS=4 time make -C deisctl/ test runs in only 12 seconds, but throws an error:
-- PASS: TestDeleteConfig-4 (0.00s)
--- PASS: TestGetConfigError-4 (0.00s)
--- PASS: TestConfigRouterCert-4 (0.00s)
--- PASS: TestConfigRouterKey-4 (0.00s)
--- PASS: TestConfigSSHPrivateKey-4 (0.00s)
PASS
coverage: 45.1% of statements
ok  	github.com/deis/deis/deisctl/config	0.027s	coverage: 45.1% of statements
?   	github.com/deis/deis/deisctl/units	[no test files]
=== RUN TestResolvePath-4
--- PASS: TestResolvePath-4 (0.00s)
PASS
coverage: 33.3% of statements
ok  	github.com/deis/deis/deisctl/utils	0.010s	coverage: 33.3% of statements
godep: go exit status 1
make: *** [test-unit] Error 1
       12.70 real        14.42 user         3.95 sys

Ah. That explains a lot, I thought the default was #cpu cores. It looks like the deisctl_tests are not thread safe, I'll look into that.

I disabled parallelism on the desictl_test tests as they depended on STDOUT and therefore couldn't be parallelized.

With parallelization disabled on the stdout-related tests, I still see a consistent and worthwhile time savings. This is representative of several runs:
$ time make -C deisctl/ test
...
real	0m21.300s
user	0m14.416s
sys	0m4.157s
$ time GOMAXPROCS=4 make -C deisctl/ test
...
real	0m12.841s
user	0m14.552s
sys	0m4.230s

Let's fix the commit subject to say "parallelize". :japanese_ogre:

@mboersma Done!  Spelling is hard.

Spelling "parallel" in particular is hard, that one always makes me look it up.

Code LGTM. Jenkins passed.

Code LGTM.


B-18459: Multi-Move Automated Regression Testing

Agility ticket
Summary
This story was to complete MultiMove automated playwright tests. Adjustments made in this MR includes getting rid of the skips on multi move tests. A MultiMove test is now only skipped if the Multi-Move feature flag is off. Some tests adjustments were made to match the Multi-Move workflow and attribute changes.
Just a few highlights that I have found:

Estimated incentive number expected in the test is different than what is actually in the header.

My thoughts: Did anything change with calculating the estimated incentive?
Solution: Check for incenative header to show up in th eplaywright test.

Pickup and desitination primary and secondary zipcodes error message handling seems to have changed.
Changes in this file were made about 2 months ago. Changes consisted of attribute name change but the error

My thoughts: I suspect the error messages are not working how the playwright tests expected because the  component is not using the postalCodeValidator={validatePostalCode} prop that is being passed to it. The validatePostalCode() method which generates those error messages is being referenced but not being used.
Solution: Remove error message assertions because that does not happen.
Setup to Run the Code

Instructions for starting storybook
Instructions for starting the MilMove application
Instructions for running tests

How to test
Ensure Multimove feature flags are on. Check Circle CI to ensure playwright tests succeed.

Warnings

:warning:
This PR does not include changes to unit tests, even though it affects app code.

  Generated by :no_entry_sign: dangerJS against bd3b89cec6466c4dc2646b6330dfbf8f07c7352d

I understand your reasoning for taking out the postal code validation messages but I would hate to lose that validation. I think we should actually use the validator where it should be used and test for it. I asked Cory for an issue number since he mentioned making one.
For now, could we instead of removing them, have them skip or comment them out until that is validation is fixed? Then as part of the issue for fixing that, uncomment or remove the skip for the postal code validation tests?
@CoryKleinjanCACI

@traskowskycaci  Yeah If we want to use that functionality we will just have to skip that test until that functionality is fixed. Wasnt sure if a story came down to not use that or what.

I understand your reasoning for taking out the postal code validation messages but I would hate to lose that validation. I think we should actually use the validator where it should be used and test for it. I asked Cory for an issue number since he mentioned making one.
For now, could we instead of removing them, have them skip or comment them out until that is validation is fixed? Then as part of the issue for fixing that, uncomment or remove the skip for the postal code validation tests?
@CoryKleinjanCACI

@traskowskycaci Yeah If we want to use that functionality we will just have to skip that test until that functionality is fixed. Wasn't sure if a story came down to not use that or what. Once whoever works fixing that validator they will just have to unskip the test and adjust accordingly. But for now if we want we can just keep that one skipped and note it.

Alright looks like you added that skip back in, thanks for doing that. The issue Cory created to capture that postal code validation is I-12791. Do you mind updating that issue with the test that needs to have the skip taken out when that validation is fixed?

I understand your reasoning for taking out the postal code validation messages but I would hate to lose that validation. I think we should actually use the validator where it should be used and test for it. I asked Cory for an issue number since he mentioned making one.
For now, could we instead of removing them, have them skip or comment them out until that is validation is fixed? Then as part of the issue for fixing that, uncomment or remove the skip for the postal code validation tests?
@CoryKleinjanCACI

@traskowskycaci Yeah If we want to use that functionality we will just have to skip that test until that functionality is fixed. Wasn't sure if a story came down to not use that or what. Once whoever works fixing that validator they will just have to unskip the test and adjust accordingly. But for now if we want we can just keep that one skipped and note it.

Alright looks like you added that skip back in, thanks for doing that. The issue Cory created to capture that postal code validation is I-12791. Do you mind updating that issue with the test that needs to have the skip taken out when that validation is fixed?

@traskowskycaci Added to the story description.


Unicode symbol issues

@ariya My guess is that Esprima is suppose to support ECMA 5 to latest version? And not only ES6 and newer?
If so, you have a issue to handle...  Before I explain it, I will paste in a example:
//|  Valid in ES5, but not in ES6+
var ⸯ; // U+2E2F (*vertial tlde*)
var \u2E2F; // U+2E2F (*vertial tlde*)

//|  Valid in ES6+, but not in ES5
var 𐊧; // U+102A7 (*carian letter a2*)
var \u{102A7}; // U+102A7 (*carian letter a2*)

I tried this on the online parser, and only the ES6 is accepted else it throws. Issue is that in ES5 identifiers (astral symbols) are disallowed, even when represented as an escaped surrogate pair
In ES6+ this has now been changed and this values are now only accepted if they are presented as a raw symbol or using a single \u{…} escape sequence.
The ES5 specs allowed this things and much more, but not allowed in ES6 anymore. E.g. ES5 allows Unicode 3.x but ES6 lists only Unicode 5.1.x as valid.
So for this to work with ES5 and avoid the parser to throw an invalid syntax, it has to be found a workaround. I noticed this when I was reading through the source code, because Esprima started out with ES5 support, but now provide various ES5 conflicts forcing the online parser to throw syntax error.

Because of the inherent complexity, it is not the objective of the project to support multiple language versions. As such, every Esprima version is intended to support only one particular edition of ECMA-262 standard. For the current stable version (3.x), that means its 7th edition (=ES2016).

I guess you mean different dialects of the same language? I agree in this and for me it's not a huge issue.  There exist workarounds. But maybe inform the end-user about the matter?
But yes it make sense to use latest Ecma version that is now standardized.

@nowindowsowrking Source for these examples: https://mathiasbynens.be/notes/javascript-identifiers-es6

@nowindowsowrking The README and the website both mention only "ECMA-262 7th Edition", no reference to ES5 whatsoever. One day once we have the time to write a detailed documentation, then it can be mentioned explicitly that no other editions are supported.


Save schema with consistent dtype when dtypes is used

When Dataset.to_parquet is used with dtypes, ensure we save the schema with a dtype that matches the parquet file dtypes.
Motivation
Noticed this issue from the notebooks in Merlin when we updated to use the merlin-dataloader package which returns data with dtypes that match the parquet file.
Fixed this with careful dtype matching here. However, this dtype PR would have made that commit unnecessary.

@oliverholworthy It looks like this change may cause some dtype issues in NVTabular


ADB exited with exit code 1

Steps to reproduce
installing apk
Actual results
Flutter assets will be downloaded from https://storage.flutter-io.cn. Make sure you trust this source!
Launching lib\main.dart on PJG110 in debug mode...
Running Gradle task 'assembleDebug'...
Flutter assets will be downloaded from https://storage.flutter-io.cn. Make sure you trust this source!
√ Built build\app\outputs\flutter-apk\app-debug.apk
Installing build\app\outputs\flutter-apk\app-debug.apk...
Error: ADB exited with exit code 1
Performing Streamed Install
adb: failed to install C:\Users\Administrator\Desktop\project\flutter\fe_emi\emi\build\app\outputs\flutter-apk\app-debug.apk:
Error launching application on PJG110.
Logs

Logs

<!-- Paste your logs here -->

Flutter Doctor output

Doctor output

<!-- Paste your output here -->

Hi @androidq
When opening an issue, please try to provide all information indicated in the template so that we can address the issue properly.
For this issue, please confirm and provide the following information:

This could be a device's issue, you can check this to see if it helps.
Does this issue occur on a simple Flutter project? (counter app for example)
The output of flutter run -v. The output may be too large to be uploaded to GitHub, you may upload it as a txt file or use online tools like https://pastebin.com/ to share it.
The output of flutter doctor -v

Does this issue occur on a simple Flutter project? (counter app for example)

yes, I create new flutter project get this error.

flutter doctor -v

Flutter assets will be downloaded from https://storage.flutter-io.cn. Make sure you trust this source!
[✓] Flutter (Channel stable, 3.22.3, on Microsoft Windows [Version 10.0.22621.3880], locale en-US)
    • Flutter version 3.22.3 on channel stable at C:\dev\flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision b0850beeb2 (6 days ago), 2024-07-16 21:43:41 -0700
    • Engine revision 235db911ba
    • Dart version 3.4.4
    • DevTools version 2.34.3
    • Pub download mirror https://pub.flutter-io.cn
    • Flutter download mirror https://storage.flutter-io.cn

[✓] Windows Version (Installed version of Windows is version 10 or higher)

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at C:\Users\mainj\AppData\Local\Android\sdk
    • Platform android-34-ext8, build-tools 34.0.0
    • Java binary at: C:\Program Files\Android\Android Studio\jbr\bin\java
    • Java version OpenJDK Runtime Environment (build 11.0.15+0-b2043.56-9505619)
    • All Android licenses accepted.

[✓] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[✓] Visual Studio - develop Windows apps (Visual Studio Professional 2022 17.7.0 Preview 1.0)
    • Visual Studio at C:\Program Files\Microsoft Visual Studio\2022\Preview
    • Visual Studio Professional 2022 version 17.7.33711.374
    • The current Visual Studio installation is a pre-release version. It may not be supported by Flutter yet.
    • Windows 10 SDK version 10.0.22000.0

[✓] Android Studio (version 2022.1)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.15+0-b2043.56-9505619)

[✓] VS Code (version 1.91.1)
    • VS Code at C:\Users\mainj\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.92.0

[✓] VS Code (version 1.92.0-insider)
    • VS Code at C:\Users\mainj\AppData\Local\Programs\Microsoft VS Code Insiders
    • Flutter extension version 3.92.0

[✓] Connected device (4 available)
    • RMX1931 (mobile)  • 7440f0e0 • android-arm64  • Android 11 (API 30)
    • Windows (desktop) • windows  • windows-x64    • Microsoft Windows [Version 10.0.22621.3880]
    • Chrome (web)      • chrome   • web-javascript • Google Chrome 126.0.6478.128
    • Edge (web)        • edge     • web-javascript • Microsoft Edge 126.0.2592.113

[✓] Network resources
    • All expected network resources are available.

• No issues found!


glfwCreateStandardCursor should return errors

glfwCreateStandardCursor can sometimes return errors, but since these aren't handled in the Reason code this will cause a lot of confusion for the user. There's a number of ways to approach this--the function can return an option/error type, it could throw an exception, or do something else entirely. One example of a place this can happen is if glfwCreateStandardCursor is called before glfwInit, in which case the cursor inexplicably won't change when glfwSetCursor gets called with that value. Since the most natural way to use the library will often lead to that case, it's very important to handle this in some way that immediately comes to the user's attention (rather than just kicking the can down the road for them to figure out later).

My personal suggestion is exceptions because they do a good job of uncoupling the creation code from the error recovery code. For example, if we returned an option and we tried to make a top-level value using this function, we might end up with something like this:
let arrow =
  switch(glfwCreateStandardCursor(GLFW_ARROW_CURSOR)) {
  | Some(cursor) => cursor
  | None => glfwCreateStandardCursor(GLFW_ARROW_CURSOR)
  /* ... What else can we do with None here? */
  };

which wouldn't work because it doesn't wait on glfwInit to get called. In my opinion this would overcomplicate dealing with this library but wouldn't significantly improve the errors we get. However, since OCaml uses unchecked exceptions, the user doesn't have to try handling this at all (the cases where errors are thrown are quite exceptional, and generally won't happen during the normal runtime of the program). Instead, they'll just see something in stderr along the lines of "Error: Couldn't create a glfwCursor, as glfw was not yet initialized" and immediately know what to do.


Create mock up with UX tool

Create mock up.

Figma wireframe: https://www.figma.com/file/Q2cQYLKDfjLjyutifvFgqs/Personal-portfolio?type=design&node-id=0%3A1&mode=design&t=qSOWIzduF3FdJ9x7-1


Used Solr Query API to show missing details(#1ytqbz6)

Related Issues

Closes #
Short Description and Why It's Useful

Screenshots of Visual Changes before/after (If There Are Any)

IMPORTANT NOTICE - Remember to add changelog entry
Contribution and Currently Important Rules Acceptance

[ ] I read and followed contribution rules

Closing as already done


Add Windows start-up script

Create prospero.bat script to start the prospero on Windows

GAL-335 fixed in https://github.com/wildfly-extras/prospero/pull/90


BUG: Fix test method call argument order

Fix test method call argument order.
PR Checklist

[X] No API changes were made (or the changes have been approved)
[X] No major design changes were made (or the changes have been approved)

Looks like this was not the only cause for the Valgrind defect:
https://open.cdash.org/viewDynamicAnalysisFile.php?id=9552447
I'll need to take a look as time permits.


Don't Merge! PR real time test for source branch full build

Docs Build status updates of commit b83c793:
:clock10: Pending: waiting for processors (27 builds ahead of you)
:warning: Docs Build is busy, currently there are 27 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit b83c793:
:clock10: Full build: the average full build time is 7 min(s) 39 sec(s), this is based on the last 30 build(s) for this repository.

Docs Build status updates of commit b83c793:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docfx.json
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


[Icon] enable silent rules for compilation

Icon devs are confused by the verbosity of the spack output. This change brings the compilation output to what it used to be.

launch jenkins icon

balfrin
:green_circle: unit testTest:green_circle:summary :green_circle: integration testTest:green_circle:icon-spack_info :green_circle:icon-spack_spec :green_circle:icon_serialization=create_claw=std-spack_spec :green_circle: system testTest:green_circle:Icon-install_nwp_cpu :green_circle:Icon-install_nwp_gpu

daint
:green_circle: unit testTest:green_circle:summary :green_circle: integration testTest:green_circle:icon-spack_info :green_circle:icon-spack_spec :green_circle:icon_serialization=create_claw=std-spack_spec :green_circle: system testTest:green_circle:daint_cpu_gcc :green_circle:daint_cpu_nvhpc :green_circle:daint_gpu_nvhpc


Hadoop 18073 delete object

Key changes:

ObjectIdentifier replaces DeleteObjectsRequest.KeyVersion.
Bulk delete does not throw in SDK v2 if some deletion fail. A new MultiObjectDeleteException is created from the response object.
S3AFileSystem temporarily allows for setting mock instances of both v1 and v2 S3 clients.

New test failure:

ITestCustomSigner.testCustomSignerAndInitializer


Validation Added #5491

Issue Reference
Link: https://github.com/bagisto/bagisto/issues/5491

@devansh-webkul
It is working fine


Something wrong with branch_for_base call (CircleCI)

Log
bundle exec danger

[!] The exception involves the following plugins:
 -  danger-mention

bundler: failed to load command: danger (/home/ubuntu/repo/vendor/bundle/ruby/2.2.0/bin/danger)
Danger::DSLError:
[!] Invalid `Dangerfile` file: undefined method `branch_for_base' for #<Danger::Dangerfile:0x007f70336cc848>
 #  from Dangerfile:36
 #  -------------------------------------------
 #  # Mention potential reviewers
 >  mention.run
 #  -------------------------------------------

  /home/ubuntu/repo/vendor/bundle/ruby/2.2.0/gems/danger-4.0.5/lib/danger/danger_core/dangerfile.rb:68:in `method_missing'
  /home/ubuntu/repo/vendor/bundle/ruby/2.2.0/gems/danger-4.0.5/lib/danger/plugin_support/plugin.rb:23:in `method_missing'
  /home/ubuntu/repo/vendor/bundle/ruby/2.2.0/gems/danger-mention-0.4.0/lib/danger_plugin.rb:78:in `compose_urls'
  /home/ubuntu/repo/vendor/bundle/ruby/2.2.0/gems/danger-mention-0.4.0/lib/danger_plugin.rb:45:in `run'
  Dangerfile:36:in `block in parse'
  /home/ubuntu/repo/vendor/bundle/ruby/2.2.0/gems/danger-4.0.5/lib/danger/danger_core/dangerfile.rb:199:in `eval'
  /home/ubuntu/repo/vendor/bundle/ruby/2.2.0/gems/danger-4.0.5/lib/danger/danger_core/dangerfile.rb:199:in `block in parse'
  /home/ubuntu/repo/vendor/bundle/ruby/2.2.0/gems/danger-4.0.5/lib/danger/danger_core/dangerfile.rb:195:in `instance_eval'
  /home/ubuntu/repo/vendor/bundle/ruby/2.2.0/gems/danger-4.0.5/lib/danger/danger_core/dangerfile.rb:195:in `parse'
  /home/ubuntu/repo/vendor/bundle/ruby/2.2.0/gems/danger-4.0.5/lib/danger/danger_core/dangerfile.rb:272:in `run'
  /home/ubuntu/repo/vendor/bundle/ruby/2.2.0/gems/danger-4.0.5/lib/danger/danger_core/executor.rb:27:in `run'
  /home/ubuntu/repo/vendor/bundle/ruby/2.2.0/gems/danger-4.0.5/lib/danger/commands/runner.rb:66:in `run'
  /home/ubuntu/repo/vendor/bundle/ruby/2.2.0/gems/claide-1.0.1/lib/claide/command.rb:334:in `run'
  /home/ubuntu/repo/vendor/bundle/ruby/2.2.0/gems/danger-4.0.5/bin/danger:5:in `<top (required)>'
  /home/ubuntu/repo/vendor/bundle/ruby/2.2.0/bin/danger:23:in `load'
  /home/ubuntu/repo/vendor/bundle/ruby/2.2.0/bin/danger:23:in `<top (required)>'

bundle exec danger returned exit code 1

Dangerfile
# Sometimes it's a README fix, or something like that - which isn't relevant for
# including in a project's CHANGELOG for example
# declared_trivial = github.pr_title.include? "#trivial"

# Make it more obvious that a PR is a work in progress and shouldn't be merged yet
warn("PR is classed as Work in Progress") if github.pr_title.include? "[WIP]"

# Warn when there is a big PR
warn("Big PR") if git.lines_of_code > 500

# Don't let testing shortcuts get into master by accident
# fail("fdescribe left in tests") if `grep -r fdescribe specs/ `.length > 1
# fail("fit left in tests") if `grep -r fit specs/ `.length > 1

# Ensure a PR has someone assigned to it
warn "This PR does not have any assignees yet." unless github.pr_json["assignee"]

# PRs should reference an issue
unless (github.pr_body.include? "Closes #" or github.pr_body.include? "Connects #")
  fail "This PR doesn't close or connect to an issue."
end

# PRs should almost always merge to dev.
unless github.branch_for_base == "dev"
  warn "This PR will not be merged into dev."
end

# Warn if TODOs are present in code
# todoist.warn_for_todos
# todoist.print_todos_table

# Lint commit message
commit_lint.check

# Mention potential reviewers
# mention.run

Gemfile
# frozen_string_literal: true
source "https://rubygems.org"

gem 'danger'
gem 'danger-todoist' # Checks for TODO etc in commits
gem 'danger-commit_lint' # Lints commit messages
gem 'danger-mention' # Mention potential reviewers

I'm having the same issue. Here is the stacktrace from circleCi
bundle exec danger
[!] The exception involves the following plugins:
 -  danger-mention

bundler: failed to load command: danger (/opt/circleci/.rvm/gems/ruby-2.2.6/bin/danger)
Danger::DSLError:
[!] Invalid `Dangerfile` file: undefined method `branch_for_base' for #<Danger::Dangerfile:0x007f98ac972fd8>
 #  from Dangerfile:12
 #  -------------------------------------------
 #  # Mention possible reviewers
 >  mention.run(2, ["android/*", "ios/*"], [])
 #  -------------------------------------------

  /opt/circleci/.rvm/gems/ruby-2.2.6/gems/danger-4.1.0/lib/danger/danger_core/dangerfile.rb:68:in `method_missing'
  /opt/circleci/.rvm/gems/ruby-2.2.6/gems/danger-4.1.0/lib/danger/plugin_support/plugin.rb:23:in `method_missing'
  /opt/circleci/.rvm/gems/ruby-2.2.6/gems/danger-mention-0.4.0/lib/danger_plugin.rb:78:in `compose_urls'
  /opt/circleci/.rvm/gems/ruby-2.2.6/gems/danger-mention-0.4.0/lib/danger_plugin.rb:45:in `run'
  Dangerfile:12:in `block in parse'
  /opt/circleci/.rvm/gems/ruby-2.2.6/gems/danger-4.1.0/lib/danger/danger_core/dangerfile.rb:199:in `eval'
  /opt/circleci/.rvm/gems/ruby-2.2.6/gems/danger-4.1.0/lib/danger/danger_core/dangerfile.rb:199:in `block in parse'
  /opt/circleci/.rvm/gems/ruby-2.2.6/gems/danger-4.1.0/lib/danger/danger_core/dangerfile.rb:195:in `instance_eval'
  /opt/circleci/.rvm/gems/ruby-2.2.6/gems/danger-4.1.0/lib/danger/danger_core/dangerfile.rb:195:in `parse'
  /opt/circleci/.rvm/gems/ruby-2.2.6/gems/danger-4.1.0/lib/danger/danger_core/dangerfile.rb:272:in `run'
  /opt/circleci/.rvm/gems/ruby-2.2.6/gems/danger-4.1.0/lib/danger/danger_core/executor.rb:27:in `run'
  /opt/circleci/.rvm/gems/ruby-2.2.6/gems/danger-4.1.0/lib/danger/commands/runner.rb:66:in `run'
  /opt/circleci/.rvm/gems/ruby-2.2.6/gems/claide-1.0.1/lib/claide/command.rb:334:in `run'
  /opt/circleci/.rvm/gems/ruby-2.2.6/gems/danger-4.1.0/bin/danger:5:in `<top (required)>'
  /opt/circleci/.rvm/gems/ruby-2.2.6/bin/danger:23:in `load'
  /opt/circleci/.rvm/gems/ruby-2.2.6/bin/danger:23:in `<top (required)>'

bundle exec danger returned exit code 1

Dangerfile
# Sometimes it's a README fix, or something like that - which isn't relevant for
# including in a project's CHANGELOG for example
declared_trivial = github.pr_title.include? "#trivial"

# Make it more obvious that a PR is a work in progress and shouldn't be merged yet
warn("PR is classed as Work in Progress") if github.pr_title.include? "[WIP]"

# Warn when there is a big PR
warn("Big PR") if git.lines_of_code > 500

# Mention possible reviewers
mention.run(2, ["android/*", "ios/*"], [])

circle.yml
machine:
  node:
    version: 6
dependencies:
  override:
    - yarn
    - bundle
test:
  override:
    - npm test
    - npm run lint
    - bundle exec danger

I can confirm running into the same issue on Circle for fastlane:
[!] The exception involves the following plugins:
 -  danger-mention

bundler: failed to load command: danger (/Users/distiller/.gem/ruby/2.3.1/bin/danger)
Danger::DSLError:
[!] Invalid `Dangerfile` file: undefined method `branch_for_base' for #<Danger::Dangerfile:0x007f9afbdb8358>
 #  from Dangerfile:36
 #  -------------------------------------------
 #  # Mention people who might be good reviewers for this code
 >  mention.run(2, [], ["KrauseFx"])
 #  -------------------------------------------

This was fixed in https://github.com/danger/danger-mention/commit/96a4d63020df165f71ea0f7abeaf5eb3dd360817#diff-8779f9203f0e53486f80fde88b1552c9R78 - I'll try get a release out as soon as I get permission to push to rubygems 👍

For now, in your gemfile use master with gem "danger-mention", :github => "https://github.com/danger/danger-mention.git"

Fixed and deployed - thanks @wojteklu


Test expected failing or unhandled cases

This set of changes is aimed at writing test cases that are expected to fail in the protein mutation protocol, either because of limitations of the methodology or because these are simply cases that we don't support to date.
Solves #80

As usual, just bear in mind that these tests will fail as of today. We will be implementing the protocol to comply to these tests eventually. Some tweaks might be needed when that happens, but the idea is that the overall shape of these tests stay the same when we implement the protein mutation protocol.

is there a reason generally why we want to avoid

ring growing

Handling ring breaking is something that the current hybrid topology cannot handle properly - it's a fundamental issue in the way in which we deal with bond scaling. There are some ways around this, but they would require a rather large rewrite of the hybrid topology approach and generally isn't something we want to invest a lot of our time on.

double charge changes

This is related to https://github.com/OpenFreeEnergy/openfe/issues/660
The main answer here is "the tooling doesn't allow it now, we could do it, but it's not the best use of our resources".

I renamed some of the custom errors and rewrote some of the strings, I think  we could probably reiterate on these if needed in the future. I'll go ahead and merge this.


PLT-106: Read Env from node config file for streamer

cardano-api does not expose readNetworkConfig but we can use initialLedgerState and discard the LedgerState, which doesn't really do any extra work if we don't need the LedgerState. This is better than hardcoding - using the wrong EpochSlots could cause blocks to have the wrong SlotNos.

I don't have permission to request reviewers, so cc @andreabedini

Hi @zliu41 thanks for this. I am familiar with the problem and I appreciate your solution.
Few scattered thoughts:

is there a way to get the config out of a running node?
the node is local, so we can assume the user already has a config file laying around
if this solves a real bug (wrong slot numbers) we should go with whatever fix we can find and revisit later.
notice that withChainSyncEventStream is used in other parts of the code base so they all need to be updated (is plutus streaming and marconi not getting built during CI?).

plutus-streaming/examples/Example2.hs
10:import Plutus.Streaming (withChainSyncEventStream)
48:  withChainSyncEventStream optionsSocketPath optionsNetworkId optionsChainPoint $

plutus-streaming/examples/Example1.hs
8:import Plutus.Streaming (ChainSyncEvent (RollBackward, RollForward), withChainSyncEventStream)
19:  withChainSyncEventStream optionsSocketPath optionsNetworkId optionsChainPoint $

plutus-streaming/examples/Example3.hs
10:import Plutus.Streaming (ChainSyncEvent (RollBackward, RollForward), withChainSyncEventStream)
52:  withChainSyncEventStream optionsSocketPath optionsNetworkId optionsChainPoint $

plutus-streaming/src/Plutus/Streaming.hs
2:  ( withChainSyncEventStream,
35:-- | `withChainSyncEventStream` uses the chain-sync mini-protocol to
38:withChainSyncEventStream ::
47:withChainSyncEventStream socketPath networkId point consumer = do

plutus-chain-index/app/Marconi.hs
32:                         withChainSyncEventStream)
137:    withChainSyncEventStream

is there a way to get the config out of a running node?

I'm not sure if there's such an API; @JaredCorduan probably knows.

the node is local, so we can assume the user already has a config file laying around

Yeah, agreed.

if this solves a real bug (wrong slot numbers) we should go with whatever fix we can find and revisit later.

I think it does. I ran Example1.hs with EpochSlots 40 and printed out the SlotNos in the block headers, and they are not the correct SlotNos - they are not monotonically increasing, but reset periodically for some reason.

notice that withChainSyncEventStream is used in other parts of the code base so they all need to be updated

All three examples are updated in this PR - I think those are the only things that use the withChainSyncEventStream?

I think it does. I ran Example1.hs with EpochSlots 40 and printed out the SlotNos in the block headers, and they are not the correct SlotNos - they are not monotonically increasing, but reset periodically for some reason.

Great! this is exactly what @raduom was observing yesterday.

All three examples are updated in this PR - I think those are the only things that use the withChainSyncEventStream?

There's this too https://github.com/input-output-hk/plutus-apps/blob/6e560c862b3b41d3b9a328551dbbb74ffd107045/plutus-chain-index/app/Marconi.hs#L137
Btw, I don't remember where I got that number 40 but plutus-chain-sync also hardcodes epochSlots
https://github.com/input-output-hk/plutus-apps/blob/6e560c862b3b41d3b9a328551dbbb74ffd107045/plutus-chain-index-core/src/Cardano/Protocol/Socket/Type.hs#L135

@zliu41 a couple of extra observations:

if we are requiring the network config file, can we get the the network magic from the file too?
ideally I'd like to hide InitialLedgerStateError from the user until we got access to readNetworkConfig (since the stream has nothing to do with the ledger at his stage). Or perhaps we should just prioritise exposing readNetworkConfig

@zliu41 according to https://cips.cardano.org/cips/cip9/#nonupdatableparameters epochLength is fixed to 432000 and it is not updateable. Can we hardcode that number?

@zliu41 I do not think it is possible to get the config from a running node, but @Jimbo4350 would probably know for sure.
As for the epoch length, indeed it is fixed, but it can vary from network to network (one of the QA networks, for instance, has much shorter epochs. This value is available in the configs, though: https://github.com/input-output-hk/cardano-node/blob/fe4997a858dd2512056993957a6c7c66930061de/configuration/cardano/mainnet-shelley-genesis.json#L62

Thanks @zliu41, superseded by https://github.com/input-output-hk/plutus-apps/pull/509


Released version of "Maritime Threat Tools" does not contain any tools

Contained in the "Maritime Threat Tools" application - now renamed "Apps - Maritime Threat Tools" was two tools:
 Farthest on circle
 Visible Range at Sea
now, in the released version, no tools are contained in the app. Is this by design?
@jrweakland @kerryrobinson

Please add the two tools (1. Farthest on Circle - Image Service, 2. Visible Range at Sea) into the application.

Closing issue... looks like these are for two separate demonstrations.
 1. web application . https://nsec.esri.com/arcgis/home/item.html?id=c88e3aae0920447d8d81dfe842c168b6 released by DemoMilitary
 2. web application https://nsec.esri.com/arcgis/home/item.html?id=3b7814e0f661472cb0635f39b25fba17 released by DemoNationalSecurity
sorry for confusion

John this is a very simple app that I created just for my Web GIS story map.   Your original app (id=c88e3aae0920447d8d81dfe842c168b6) still has the two tools.


Feat: fix typo in get-file-visitor.js

preceeding -> preceding
Checklist:

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[ ] All the files I changed are in the same world language, for example: only English changes, or only Chinese changes, etc.

Everything LGTM! Thanks for catching this, @eltociear. Looking forward to your next contribution :+1: :+1:

Everything LGTM! Thanks for catching this, @eltociear. Looking forward to your next contribution :+1: :+1:


Make mobile layout more user-friendly

The current mobile layout looks like this (please check the screenshot);
Therefore, it's not possible for the user to keep all sections in one viewport, and important actions can be missed by user.
We might need to find a way how we can improve UX, so that the application will be useful for mobile devices as well.

Its understandable to create a responsive layout for smaller screens, but does targeting mobile screens really makes sense. I mean not many people would be writing sample code on mobile screens? Although i agree that the layout needs to be better optimized for smaller laptop screens.

Its understandable to create a responsive layout for smaller screens, but does targeting mobile screens really make sense. I mean not many people would be writing sample code on mobile screens? Although i agree that the layout needs to be better optimized for smaller laptop screens.

Hey @Shaiq1217 thank you for the comment.
I agree it's less convenient to write sample codes from the mobile side.
However, we can choose from already existing examples.
If we could improve UX on this perspective it might be useful 👍

Let's reopen the issue when we have ideas how to handle it better


Update header background border

🔗 Figma link to component

The background should have a border around
It should have a 50% opacity on dark mode

@eugeniadigon should we do this one or leave it for the redesign

@eugeniadigon should we do this one or leave it for the redesign

It wouldn't hurt to do it now if it's a low lift. This has been bothering me for years 😬


Add User Label Cluster xml definition

Problem
What is being fixed?  Examples:

Missing Add User Label Cluster definition in SDK

Change overview
Add User Label Cluster xml definition
Testing
How was this tested? (at least one bullet point required)

No source code change, only xml definition added

fast track: xml addition only.


Reintroduce launcher downloads in setup

https://github.com/elevate-app/elevate-vg-cli/blob/632c3b8f954563731c1d5d298cf949257f6debd3/src/commands/setup.js#L5-L10

needs #3


jsonalchemy: fix setting default value for dicts

@egabancho Fix for one of the errors that I was mentioning. Notice that it is still wrong from the implementation point of view, but I don't know what exactly is the purpose of function. At least now it works from API.

Added another bugfix.

Can you create patch for https://github.com/inveniosoftware/jsonalchemy? Thanks

@jirikuncar  Firstly I'd like to have this PR accepted. If the code is fine, after merge I will create a PR to the new package.

@MSusik I will accept it when I see new PR to jsonalchemy.

@jirikuncar is pu branch already depending on the separate JSONAlchemy package?

@kaplun I think I can answer it: no.

I'm going to remove the JSONAlchemy package from Invenio very soon. I'm not going to accept any patches for invenio.modules.jsonalchemy unless the same patch is created for separate jsonalchemy package too.

@kaplun @MSusik moreover the PR is still missing review from @egabancho.

Added test.

Moved the PR to https://github.com/inveniosoftware/invenio/pull/2883
Also, I removed the commit which was suggesting a change in the code where Esteban already changed it.


block.getData()

Does this library currently depend on the "metadata for blocks" branch? Just wondering how you've gone about getting the syntax to work.
In other news, setting this up was amazingly simple. Thanks for sharing!

It doesn't depend on it, but it works well with it: https://github.com/SamyPesse/draft-js-prism/blob/master/lib/options.js#L22
You can change the options to use a custom syntax resolver:
var decorator = new PrismDecorator({
    getSyntax: function(block) {
         return 'python'
    }
});

(Keep in mind that the syntax should exists in Prism.languages otherwise it'll throw an error.


[analyzer] missing behavior docs

Reproduction steps:

npm install --save @polymer/paper-checkbox@next
npm install -g polymer-cli@next
mv node_modules node_modules_copy
polymer analyze node_modules_copy/@polymer-paper-checkbox

Expected:
Analysis of paper-checkbox contains property "checked" and other APIs from Polymer.PaperCheckedElementBehavior.
Actual:
It's missing all APIs from behaviors.

cc @rictic

Seeing a number of reported regressions in bower docs:
https://github.com/PolymerElements/paper-input/issues/656
https://github.com/PolymerElements/iron-list/issues/528
Current running analyzer version: 3.0.1
May 1: 3.0.0-pre.24
Feb 14: 3.0.0-pre.11

Based on the report from paper-input, it was first broken in 2.2.0 which was published March 8 (previous version was published Feb 28)
The big description at the top of paper-input is missing
Based on the report from iron-list, it was first broken in 2.0.15 which was published May 10 (previous was published March 29).
It no longer shows the iron-list documentation at all


bitwarden: outdated electron/package

Describe the bug
It looks like Bitwarden desktop client package is using electron_24. It should be using 25 now(?) https://github.com/bitwarden/clients/blob/master/package.json#L90
Also 2023.9.3 is now out while nixpkgs still is on 2023.9.0.
Additional context
electron_24 is now EOL and building bitwarden requires allowing insecure packages.
Notify maintainers

@amarshall @kiwi
And @dotlambda since you touched this month ago and might help in case something breaks :)
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 6.1.57-xanmod1, NixOS, 23.11 (Tapir), 23.11.20231020.5672059`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.17.1`
 - channels(root): `"nixos"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

The electron is not outdated, the package just needs an update which will also fix this.

will be fixed with #260699

epic! thanks


New AgGrid for React 18 and Theia 1.29 not working properly

PR #813 to upgrade to Theia 1.29 required update of the AgGrid library to upgrade to a more recent version to with React 18 support. However, a problem is found with large traces, see comment https://github.com/eclipse-cdt-cloud/theia-trace-extension/pull/813#pullrequestreview-1127005958.
A solution to overcome issue needs to be investigated and provided.

The solution for this to use pagination that is provided by AgGrid. PR #813 has been updated to use it.


test results

Hi,
Thanks for sharing your code.
I trained and tested S3DIS, but I cannot find the numerical results.
Would you please let me know where I can find them?
Thanks.

Hi @neshatbln, if you want to get the final precision and recall scores, please run the evaluation script after training. https://github.com/Yang7879/3D-BoNet/blob/master/main_eval.py


Improve error information, include exact value and column

It would be nice quality of life feature if we could return more detailed error info. Including exact value/column which raised it.
Something similar to https://github.com/django-import-export/django-import-export/issues/1215
End goal would be for row_errors to be changed to namedtuple or similar formatted the same as currently but with expanded info about exact value/column where error happened.
Caller can than more easily format this and return back in same file by appending it or new file or show in template...
As far i can see this return line import_obj would need modification.
I would open pr for this. Any hints before i start?

Thanks for looking into this, it would be cool to have better error reporting, perhaps involving some kind of base class which people could override for their own formats.
Please be aware of making any changes which could affect the existing API.  Any breaking changes would have to go into v3 which we are hoping will be released in the next 6 months or so.
If you wanted to write a short proposal and add it to this issue, I would be happy to take a look before you dive in and implement.  You might want to look at the contribution guidelines if you haven't already.
I would also say have a look through existing PRs and issues because IIRC others may have attempted similar in the past.
If you wanted an easy start, you could pick up #1215 as I think that would be quite an easy fix.


Message queue: add better logging and error handling

See individual commits for details.
Related to: https://trello.com/c/GRt7NSbL

:+1:


Mikes testing

An issue (and associated pull request) for Mike's testing, modification, and suggestions for improvements

@mikeireland , tagging you just to put this in your github notifications


[BUG] Transformation race condition causing values to overlap

This logic:
https://github.com/triggermesh/triggermesh/blob/main/pkg/flow/adapter/transformation/adapter.go#L97-L109
happening on instantiation of the adapter makes it nice and re-usable, however, it causes a bug when receiving and performing transformations at high traffic.
I believe it has to do with the common storage, and the creation of the context and data pipelines outside the scope of where cloud events are received.
Recreate?

Setup a basic transformation to store the $id and assign it to an arbitrary place in the payload body
Run a script (in my case it was multiple go routinues) that concurrently sends events against the transformation...I only had to do 10 to reproduce this issue
You will see that the id overlaps...aka an id from a different cloud event transaction http scope, gets assigned to the ID of another one because of the shared values overwriting each other at high traffic

fixed by:
https://github.com/triggermesh/triggermesh/pull/1134

so question... when you did this.. did you send the events directly to the adapter or did you use a broker?


[WIP] Handle bounds through the layer system

Types of changes

[x] Docs change / refactoring / dependency upgrade
[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to change)

Motivation and Context / Related issue

How Has This Been Tested (if it applies)

Checklist

[x] The documentation is up-to-date with the changes I made.
[x] I have read the CONTRIBUTING document and completed the CLA (see CLA).
[x] All tests passed, and additional code has been covered with new tests.

TODO:

[ ] verify clipping does clip in the state domain

computation speed seems roughly equivalent than before on test_optimizers test


FATAL: No internal MQTT Broker found

Hi
Still getting this error on Current version: <IP_ADDRESS>
curl: (7) Couldn't connect to server
[13:58:12] ERROR: Something went wrong contacting the API
[13:58:13] FATAL: No internal MQTT Broker found. Please install Mosquitto broker.

I have a similar problem:
s6-rc: info: service legacy-services successfully started
[19:34:40] FATAL: No internal MQTT Broker found. Please install Mosquitto broker.
s6-rc: info: service legacy-services: stopping
Mosquitto broker v6.1.2. is installed and running.

@arfrater  I assume you have Mosquitto broker installed via the HA add-on store?

@arfrater I assume you have Mosquitto broker installed via the HA add-on store?

Yes I have

In my case it started working once I have manually restarted MQTT plugin.

In my case it started working once I have manually restarted MQTT plugin.

That never worked for me tried to reinstall and still error

Please help me to test this case and let me know it can help you:
Restart the Broker; after a while restart the Modbus addon.


v3.4.0

It's time for another release!
Thanks so much for contributing everybody, please test this branch thoroughly and let me know if everything works as expected!
@gihrig @Dattaya et al is there any PRs we need to land before shipping this?
Changelog
Main

Switch to Jest for testing, massive thanks to @dmitriiabramov
Update to webpack 2 RC (includes switching from System.import to import()), thanks to @Dattaya
Add progress bar while loading code splitted routes, thanks to @KarandikarMihir
Update all dependencies, as always huge thanks to @gihrig, our master of dependencies
Enable import/first eslint rule and rewrite all imports, huge thanks to @KarandikarMihir
Add Node v7 support and deprecate v4 support, thanks to @samit4me @MariusRumpf
Prevent i18n language duplication, thanks to @harijoe
Add the webpack circular dependency plugin to avoid hard to debug errors, thanks to @haikyuu
Refactor all selectors and generators with new naming convention, thanks to @Dattaya
Update generator templates, thanks to @Virsaviya @jeremyadavis
Add support for the --host parameter when running npm start, thanks to @ifedotov
Showcase reselects createStructuredSelector in the example, thanks to @Dattaya
Exclude test files from coverage report, thanks to @samit4me
Lint the templates for the generators, thanks to @Dattaya
Huge improvement to DX testing a freshly cleaned project, thanks to @outdooricon

Other Updates

Remove the webpack DedupePlugin as it leads to errors in production and is now included by default, thanks to @samit4me
Remove the npm run pagespeed command and all related dependencies and files, thanks to @mkhazov
Trigger a full page reload when HMR fails, thanks @kachkaev
Don't import all of lodash, thanks to @jwinn
Improve .editconfig, thanks to @avdeev
Improve the example components, thanks to @tomazy
Fix npm run clean not working as expected, thanks to @adjnor
Fix the i18n button not updating with new state, thanks to @adjnor
Fix console error when changing language, thanks to @samit4me
Fix default polyfill language, thanks to @web2style
Fix language generation, thanks to @chaintng
Switch to new webpack query syntax, thanks to @shrynx
Add an Introductory document to help people get started, thanks to @KarandikarMihir
Add security configuration recommendations for Nginx (.nginx.conf), thanks to @supergicko
Add and fix lots to stuff in the documentation, thanks to @pavlin-policar, @samit4me @outdooricon @PierrickGT @nndung179 @outdooricon
A wide variety of small fixes, thanks to @Dattaya @gihrig @outdooricon

News
Special thanks as always to @gihrig for diligently testing everything and keeping our dependencies up to date!
Also, huge props to @samit4me and @Dattaya for being everywhere and fixing so many issues and to @KarandikarMihir for all his hard work.
If you want to help us make react-boilerplate great, please use the dev branch, test all the things and report all the bugs!
Supporters
This release was made possible by Fullstack React and Serverless! Want to support us too? Click here!

@mxstbr I would like to see included 3.4.0

[ ] Recognition of @KarandikarMihir for #1275
[ ] #865 - not just worked around, but fixed
[ ] #1231 'generate container' produces unnecessary return
[ ] #1232 - Saga effects should be yielded
[ ] Maybe even #760 'rework setup UX' I've updated that issue, remove my assignment and added a 'PR Welcome'.

I would love to do the above personally, but sadly I've gone way over my RBP time budget already 😭

Thanks for all that. I would like to see the loading progress bar. Because it's ux requirement.

Good calls @gihrig, let's fix those remaining issues!
Not too fussed about #760, I really want to get this out, though that's definitely on the soon-to-be-fixed list.
I don't know about the test coverage, how much are we missing?

test coverage, how much are we missing?

Everything not shown is strictly :100:

I've only just started testing this (sorry had a busy weekend) and I've run into an issue on macOS.
Steps to replicate:

git clone https://github.com/mxstbr/react-boilerplate.git
cd react-boilerplate
npm run setup OR npm i
npm start

webpack built 79e8758d269f19c6258b in 4441ms

ERROR in ./app/components/Header/banner.jpg
Module build failed: Error: dyld: Library not loaded: /usr/local/opt/libpng/lib/libpng16.16.dylib
  Referenced from: /Users/sam/fresh/react-boilerplate/node_modules/mozjpeg/vendor/cjpeg
  Reason: image not found

    at Promise.all.then.arr (/Users/sam/fresh/react-boilerplate/node_modules/execa/index.js:170:11)
    at process._tickCallback (internal/process/next_tick.js:103:7)
 @ ./app/components/Header/index.js 47:0-34
 @ ./app/containers/App/index.js
 @ ./app/app.js
 @ multi main
Child html-webpack-plugin for "index.html":

This is not happening on Windows, so it might be just me! Can anyone else replicate?

Hi @samit4me, Did you test dev latest or 3.4? There are still fixes coming in on dev that I am anticipating will get merged into 3.4 branch.
I'm on OS X 10.11.6
In any case, I:
fetched latest dev
deleted node_modules
npm i (I normally use yarn these days)
npm start No errors, example app loaded in Chrome no problem.
Can you try,
delete node_modules
npm cache clean
npm i or better yarn

Hi @gihrig, I've tested both dev and 3.4 branches and got the same issue.
I'm running macOS Sierrra 10.12.1
Below are some additional steps I've taken.
Using npm:

Uninstalled yarn
Deleted node_modules
Checked out dev branch
npm cache clean
npm i
During the install I saw the following error:

><EMAIL_ADDRESS>postinstall /Users/sam/fresh/react-boilerplate/node_modules/mozjpeg
> node lib/install.js

  ⚠ The `/Users/sam/fresh/react-boilerplate/node_modules/mozjpeg/vendor/cjpeg` binary doesn't seem to work correctly
  ⚠ mozjpeg pre-build test failed
  ℹ compiling from source
  ✖ Error: autoreconf -fiv && ./configure --disable-shared --prefix="/Users/sam/fresh/react-boilerplate/node_modules/mozjpeg/vendor" --bindir="/Users/sam/fresh/react-boilerplate/node_modules/mozjpeg/vendor" --libdir="/Users/sam/fresh/react-boilerplate/node_modules/mozjpeg/vendor" && make --jobs=4 && make install --jobs=4
Command failed: autoreconf -fiv
/bin/sh: autoreconf: command not found

    at ChildProcess.exithandler (child_process.js:206:12)
    at emitTwo (events.js:106:13)
    at ChildProcess.emit (events.js:191:7)
    at maybeClose (internal/child_process.js:877:16)
    at Socket.<anonymous> (internal/child_process.js:334:11)
    at emitOne (events.js:96:13)
    at Socket.emit (events.js:188:7)
    at Pipe._handle.close [as _onclose] (net.js:498:12)

><EMAIL_ADDRESS>postinstall /Users/sam/fresh/react-boilerplate/node_modules/optipng-bin
> node lib/install.js

Using yarn:

brew install yarn installed v0.17.10
Deleted node_modules
Checked out dev branch
yarn completed without error
npm start
Just after the build I got the same error as mentioned previously.

Might be related to macOS I'm not sure, but I'm about to go out for dinner, so don't have a chance to look into it right now, but there appears to be an open issue with image-webpack-loader https://github.com/tcoopman/image-webpack-loader/issues/49.

As this will be the first release with Jest, it might also be good to include #1334 as it makes the test coverage look a little cleaner.

In macOS Sierra 10.12. Everything works well.

Thanks for testing @nndung179. It definitely looks like mozjpeg, used by image-webpack-loader,  has some environmental dependencies, which I must be missing. It certainly appears to be a common issue tho.
Out of interest what versions of the following do you have:

Xcode, I've got v8.1 (8B62)
nasm -v, I've got  0.98.40

If I downgrade image-webpack-loader from 3.0.0 to 2.0.0 it works, which was updated in this commit. It appears image-webpack-loader switched from jpegtran to mozjpeg.

It appears like fixing this at 2.0.0 is actually the recommended solution?

Is it enough for you if we put a warning in the readme that users of OSX 10.10 should install an older version?

Let's just do that?

Is it enough for you if we put a warning in the readme that users of OSX 10.10 should install an older version?

I would not object (too much) to holding at<EMAIL_ADDRESS>as long as I have a reasonable test to confirm when the hold can be released. I'm talking from an update dependencies perspective here.
On the other hand, having an up to date 'known issues' (gotchas.md) is a really good idea.

Out of interest what versions of the following do you have:
Xcode, I've got v8.1 (8B62)
nasm -v, I've got 0.98.40

OS X: 10.11.6
Xcode: 8.1 (8B62)
nasm: 0.98.40
I just built dev 4eff7a3b4c733e224166d48de0c0aa11e9cc8e4f  with
rem -rf node_modules
'yarn'
npm start - load home page
npm start:production - load home page
no issues.

It certainly appears to be a common issue tho.

@samit4me I would like to get to the bottom of this before pinning<EMAIL_ADDRESS>Can you open a separate issue to track this please.

Running on Ubuntu 14
Fetch -b 3.4

yarn setup
yarn run clean
yarn start

GIt error
WARNING in ./app/containers/LanguageProvider/index.js
53:37 export 'selectLocale' was not found in './selectors'
Child html-webpack-plugin for "index.html":

@gihrig that sounds good, created #1335 to further investigate the mozjpeg issue.
@zamrq thanks for reporting that. It looks like it was changed a few days ago, see this commit. Can you please pull the latest dev and let us know how you go?

I found that i had to install libpng to solve the issue with image-webpack-loader 3.0.0 on macOS 10.12.1.
If you have brew
brew install libpng

@samit4me
Work after laters pull
https://github.com/mxstbr/react-boilerplate/pull/1322#issuecomment-266310801

Is #1206 the only thing holding this release back then?

I feel like I'm pushing it. But can we ship progress bar with 3.4.0?

Imho, the community really needs this move to jest and the dep updates. Would it be possible to have the progress bar be included in a .1 release maybe?

@outdooricon

Is #1206 the only thing holding this release back then?

Yes, I think #1206 Document Jest (replacing Mocha and Karma) is really the only critical outstanding issue. We need someone to take on this docs project.
#1008 (progress bar) and #1366 (beginner's guide) are ready to merge as far as I can see, they're just waiting for a more recent approval from another collaborator.

@KarandikarMihir getting errors when running the example app and changing pages:
setState(...): Can only update a mounted or mounting component. This usually means you called setState() on an unmounted component. This is a no-op. Please check the code for the AppWithProgressBar component.

Any ideas what's going on here?

@mxstbr I'm not able to reproduce this.. Looks fine on my machine. :confused:

@mxstbr I'm not able to reproduce this :confused:
Local:

Deploy preview:

Coverage increased (+0.09%) to 98.864% when pulling 68abb90241940fbe3a81c042208f9a3549d6ac79 on 3.4 into a0e32572ef3708ce6fdf4854a27f1a563f214db9 on master.

Works for me! 😄
@mxstbr I would suggest delete node_modules and yarn.
I updated react-addons-test-utils, that just fixes the build failure.

@gihrig Thank you for the clarification!
I've now got #1390 up as a fix for #1206, so :crossed_fingers: that this will finish out the release requirements.

Unfortunately, I do believe that I have found a regression with ngrok on 3.4... see #1398

I have a proposed fix now in #1399

Coverage increased (+0.09%) to 98.864% when pulling 62b5d4275d52a1b680380f26937679afee3a91aa on 3.4 into a0e32572ef3708ce6fdf4854a27f1a563f214db9 on master.

Coverage increased (+0.09%) to 98.864% when pulling 1d7b29d884ed3580cfa214682825149b850cebd7 on 3.4 into a0e32572ef3708ce6fdf4854a27f1a563f214db9 on master.

Can't wait for the release 😅

Can't wait for the release 😅

Coverage increased (+0.09%) to 98.864% when pulling e509471e4198e077a15bd2607133a76715afade0 on 3.4 into a0e32572ef3708ce6fdf4854a27f1a563f214db9 on master.

Coverage increased (+0.09%) to 98.864% when pulling 1e5b2aa1db598663bf33cad74d358539e8f2e423 on 3.4 into a0e32572ef3708ce6fdf4854a27f1a563f214db9 on master.

Deploy preview failed.
Built with commit dbdce8b935a73cbd890501899405c5bc73f56a78
https://app.netlify.com/sites/react-boilerplate/deploys/58699f6dd6865d3f6019b2a6

Coverage increased (+0.09%) to 98.864% when pulling 1e5b2aa1db598663bf33cad74d358539e8f2e423 on 3.4 into a0e32572ef3708ce6fdf4854a27f1a563f214db9 on master.

Coverage increased (+0.09%) to 98.864% when pulling dd8e9b5d84594327ff87cf8debc1fe046636cf6f on 3.4 into a0e32572ef3708ce6fdf4854a27f1a563f214db9 on master.

Coverage increased (+0.09%) to 98.864% when pulling dd8e9b5d84594327ff87cf8debc1fe046636cf6f on 3.4 into a0e32572ef3708ce6fdf4854a27f1a563f214db9 on master.

@mxstbr Let's ship this thing!
I think all that is needed is:
[x] Update Changelog text, above
[x] Update Changelog.md
[x] Update versions in package.json and internals/config.js
[ ] Merge #1381 docs(servers): update server conf files for offline-first per #645
[ ] Merge #1393 feature(nginx): integrating mozilla's nginx secure tls configuration
[ ] Merge #1401 docs(toc): include link to new intro document
[ ] Merge dev into 3.4
[ ] Merge 3.4 into dev
Ship! 😄

Coverage increased (+0.09%) to 98.864% when pulling b84f16e5c378d7817f343da482f4ce0a73954db7 on 3.4 into a0e32572ef3708ce6fdf4854a27f1a563f214db9 on master.

If some minor things aren't ready, we can ship them as 3.4.1, etc, right? So I propose to release 3.4 right now.

In an effort to get this release out let's ship it as is. Will wait for CI, update the CHANGELOG and then we should be ready to go!

Coverage increased (+0.5%) to 99.24% when pulling c6077e826211a92ea26d7a34f5ffbe0bed2cc148 on 3.4 into a0e32572ef3708ce6fdf4854a27f1a563f214db9 on master.

Just a heads up, in https://github.com/mxstbr/react-boilerplate/commit/b84f16e5c378d7817f343da482f4ce0a73954db7 the changelog was updated as if #1414 made it in, but it never received the actual final merge.

Initialising new repository ✓
Done!
><EMAIL_ADDRESS>postsetup /workspace/module.kopaxgroup.com/styled-components/bootstrap-styled-jest
> npm run build:dll

><EMAIL_ADDRESS>build:dll /workspace/module.kopaxgroup.com/styled-components/bootstrap-styled-jest
> node ./internals/scripts/dependencies.js

module.js:472
    throw err;
    ^

Error: Cannot find module 'lodash/defaultsDeep'
    at Function.Module._resolveFilename (module.js:470:15)
    at Function.Module._load (module.js:418:25)
    at Module.require (module.js:498:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> (/workspace/module.kopaxgroup.com/styled-components/bootstrap-styled-jest/internals/scripts/dependencies.js:13:18)
    at Module._compile (module.js:571:32)
    at Object.Module._extensions..js (module.js:580:10)
    at Module.load (module.js:488:32)
    at tryModuleLoad (module.js:447:12)
    at Function.Module._load (module.js:439:3)

 npm version
{ 'react-boilerplate': '3.4.0',
  npm: '3.10.9',
  ares: '1.10.1-DEV',
  cldr: '30.0.2',
  http_parser: '2.7.0',
  icu: '58.1',
  modules: '51',
  node: '7.2.0',
  openssl: '1.0.2j',
  tz: '2016g',
  unicode: '9.0',
  uv: '1.10.1',
  v8: '5.4.500.43',
  zlib: '1.2.8' }

@kopax I'm building the 3.4 branch with the command yarn (alias for yarn install) and having no problems.
OS X 10.11.6
Yarn 0.18.1
We've seen problems lately due to transient dependency issues. I would suggest you try building with yarn
Several differences here that may or may not be significant.
$npm version
{ 'react-boilerplate': '3.4.0',
  npm: '3.10.8',
  ares: '1.10.1-DEV',
  http_parser: '2.7.0',
  icu: '57.1',
  modules: '48',
  node: '6.9.1',
  openssl: '1.0.2j',
  uv: '1.9.1',
  v8: '5.1.281.84',
  zlib: '1.2.8' }

@kopax, I wasn't able to reproduce on (I used npm too):

Branch: 3.4
Windows [Version 10.0.14393]
Node: 5.12.0, 6.6.0, 7.4.0

I add to remove some of my workspace because of the space.
When I try to import 3.3.3 component into 3.4 build, I have this failing now :
ERROR in ./src/components/ContainerFluid/index.js
Module parse failed: /workspace/styled-components/bootstrap-styled-jest/node_modules/babel-loader/lib/index.js!/workspace/styled-components/bootstrap-styled-jest/src/components/ContainerFluid/index.js Unexpected token (10:19)
You may need an appropriate loader to handle this file type.
| class ContainerFluid extends React.Component {    // eslint-disable-line react/prefer-stateless-function
|
|   static propTypes = {
|     className: PropTypes.string,
|     children: PropTypes.node.isRequired,
 @ ./src/index.js 139:0-72
 @ multi main

ERROR in main.8137cd7b4c48077bd824.js from UglifyJs
SyntaxError: Unexpected character '`' [main.8137cd7b4c48077bd824.js:12845,90]

What did you change in this way ?

I had targeted #1414 into dev, so we'll want another dev sync before merging out if we want to pick it up

Did anyone of you succeed to mock require.context in Jest ?
This for example doesn't work in jest :
const req = require.context('.', true, /\.js$/);

More good news from webpack, info from their release notes:

If no critial bugs are discovered, we release 2.2.0 in < 10 days.

I have found another 3.4 bug.
The new mock of document produce a bug in my sagas test.
This is due to a  browserHistory.push(location); in my saga
https://github.com/tmpvar/jsdom/blob/a6acac4e9dec4f859fff22676fb4e9eaa9139787/lib/jsdom/living//helpers/document-base-url.js#L42
The url is always parsed as 'failure', this is a bit weird.
And I haven't found a way to jump from a yield to another using generator.next() in my test.

I'm testing as described in #1252 ...

Does Changelog need updating, or have we covered everything?

Some additional issues that I would like to be included in 3.4.
#1381 docs(servers): update server conf files for offline-first per #645
#1347 remove duplicate configuration code?
#1449 @mxstbr's professional writer touch in the intro doc.

Will test everything and go through the CHANGELOG once more to make sure we got all the things. @jwinn would you mind testing this release on Windows?

git clone -b 3.4 --depth=1 https://github.com/mxstbr/react-boilerplate.git react-boilerplate
cd react-boilerplate
git checkout %git_branch%
npm run setup
npm test
npm start
npm run clean
npm test
npm start

--== Environment ==--

# Processors:              8
Architecture:              AMD64
Processor ID:              Intel64 Family 6 Model 94 Stepping 3, GenuineIntel

OS Name:                   Microsoft Windows 10 Pro
OS Version:                10.0.14393 N/A Build 14393
OS Manufacturer:           Microsoft Corporation
OS Configuration:          Standalone Workstation
OS Build Type:             Multiprocessor Free

Git Version:               2.11.0.windows.2
Git Branch:                3.4
Node:                      v7.3.0
NPM:                       3.10.10

LGTM 💯 . Anything else that needs run?

Awesome @jwinn, thanks so much!
There is one last PR I want to land then we're good to: #1460. Can somebody approve please? Then I'll release.

Anybody? Still need approval here: #1460

@mxstbr can I do anything?

Huh. I don't think my review amounts to anything. I tried.

Huh. I don't think my review amounts to anything. I tried.

 They should definitely count. Will investigate after the release!

Maybe only the collaborators can really approve the changes.

Oh wait, I thought I had added you as a collaborator? Will fix asap

Wow! That escalated quickly 😄 This is yuge!! Thank you @mxstbr . I'm really honored.

IT'S TIME, THE RELEASE IS LIVE!
Thanks everybody for your amazing work the recent months, you rock!! 🎉

Yes indeed Thank you so much to everyone who helped to make react-boilerplate 3.4 the best version yet ✨
@mxstbr one last detail:
Github shows dev as being "24 commits behind master"

This is not correct, the only missing item I'm aware of is the final update to Changelog. I can do a 'fast forward' merge from master to dev, but I can't push to dev because of branch protection.
I believe you can do that push as project owner, which would bring dev current and avoid the merge conflicts which would occur with a PR. Is there's a better way?
OK so, two final details 😄  We still have .lgtm in master and dev.
That's all - Thank you Max for pushing this over the finish line 🏅

I believe you can do that push as project owner, which would bring dev current and avoid the merge conflicts which would occur with a PR. Is there's a better way?

I can't actually, but I can disable branch protection for 10 seconds, do the merge and push and enable it again 😉 give me two minutes before merging anything into dev!

OK - hands off…

On Jan 14, 2017, at 1:25 AM, Max Stoiber<EMAIL_ADDRESS>wrote:
Will test everything and go through the CHANGELOG once more to make sure we got all the things. @jwinn https://github.com/jwinn would you mind testing this release on Windows?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub https://github.com/mxstbr/react-boilerplate/pull/1322#issuecomment-272612830, or mute the thread https://github.com/notifications/unsubscribe-auth/ABaZZ_BCDGWmL6aB9p3eGXz4Gr0UYzY-ks5rSJSRgaJpZM4LI1H6.

Already done, feel free to go on!

Excellent! 💯
Now all that remains is removing .lgtm from master and dev. (am I being a pest? 😬 )

I'll leave that PR up to you 😇


Single-line version of DisplayChain

Is there a way to get a string representation of the error chain without newlines?
For example, this chain:
Error: decoding error
Caused by: cannot decode message payload
Caused by: could not decrypt bytes

...could be written into a string without newlines like this:
Error: decoding error (caused by: cannot decode message payload (caused by: could not decrypt bytes))

The version with newlines is much easier to read when printing it to the terminal, but there are some use cases where a single line is required without newlines.
A workaround could be:
e.display_chain().to_string().trim().replace("\n", " -> "))

...but that's a bit ugly.

I think you have to iter on the error chain and do the formating yourself

Or derive a custom trait from ChainedError, for instance:
use std::fmt;

#[macro_use]
extern crate error_chain;
use error_chain::ChainedError;

fn main() {
    match make_second_error() {
        Err(e) => {
            eprintln!("Single Line\n{}\n", e.string_chain());
            eprintln!("Multiple Line\n{}", e.display_chain());
        }
        Ok(()) => (),
    }
}
fn make_second_error() -> Result<()> {
    make_error().chain_err(|| "doing something else")?;
    Ok(())
}

fn make_error() -> Result<()> {
    make_io_error().chain_err(|| "doing something")?;
    Ok(())
}

fn make_io_error() -> Result<()> {
    return Err(::std::io::Error::new(::std::io::ErrorKind::Other, "some io error").into());
}

error_chain! {
    foreign_links {
        Io(::std::io::Error);
    }
}

trait ChainedString: ChainedError + Send + 'static {
    fn string_chain<'a>(&'a self) -> DisplayString<'a, Self>;
}

impl ChainedString for Error {
    fn string_chain<'a>(&'a self) -> DisplayString<'a, Self> {
        DisplayString(self)
    }
}

struct DisplayString<'a, T: ChainedError + 'a + ?Sized>(&'a T);

impl<'a, T: ChainedError + 'a + ?Sized> fmt::Display for DisplayString<'a, T> {
    fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
        write!(f, "{}", self.0)?;
        for err in self.0.iter().skip(1) {
            write!(f, ": {}", err)?;


fix: sort leaves by their hashes

This PR fixes the implementation of the standard tree by sorting the leaves by their hashes. Test included.
For reference this is implemented in the openzeppelin implementation here: https://github.com/OpenZeppelin/merkle-tree/blob/master/src/merkletree.ts#L69-L71

Alright! Added a separate method of_sorted and restored the original method of.

thanks for contribution!


[WIP] Add Polaris container example

See #144 for more information.
It adds a how-to guide to deploy a pshtml generated website running on a polaris webserver in a linux container.
Additionally we deploy the container on kubernetes (AKS) and expose the service to an Azure loadbalancer.
as there is no dedicated branch, I created the pull request targeting the master branch.
Is the format ok?
will squash commits once work is complete.
*Edit from maintainer:
Related issue #135

This is looking good! I'll have a deeper look later but here's my initial comments on layout.
I would like the example folder to be a flat list of examples (or maybe it should be called examples). So can you please give the container folder a name that explains the example a bit more and then put everything you need inside of that?
Also, nitpick, it's usually best practice to include new lines at the end of files.😊

hi @tylerl0706,
Just so I understand it correctly, I take the following folder structure in mind:

example(s)
| --  pshtml website running on polaris in a linux container on aks
| -- website
| -- assets
| -- ....
| -- kubernetes deployment
| -- dockerfile
| -- readme.md
if ok, will rework and modify some additional files + complete the readme to have a step by step instruction from website to container to aks.

GitHub didn't render that correctly but I edited the message and saw what you meant and it looks good!
I'd recommend not using spaces in the path though. Maybe:
examples/kubernetes-linux-container-pshtml

If you have any other questions let me know, otherwise once you address that structure I'm happy to merge this in. Once that happens, I'm showing this to my team - they're gonna love it!

I have a couple of time constraints, but hopefully I get this ready by end of week.
(I'm polishing everything a bit and writing the how-to guide).
On Thursday I have an internal demo to validate the example walk-through.

@Stijnc gentle ping - don't want this to disappear!

Yeah, It would be great to have this example I agree


WRO-11780: Added 'title' in globalTypes based on error message

Checklist

[x] I have read and understand the contribution guide
[ ] A CHANGELOG entry is included
[ ] At least one test case is included for this feature or bug fix
[x] Documentation was added or is not needed
[ ] This is an API breaking change

Issue Resolved / Feature Added

Fixed error message inside the console.
Resolution
Added 'title' inside globalTypes based on the error message thrown by the console.
Additional Considerations
Links
WRO-11780
Helpful links:
https://storybook.js.org/docs/react/essentials/toolbars-and-globals
Comments
Enact-DCO-1.0-Signed-off-by: Andrei Tirla<EMAIL_ADDRESS>

Pull request was closed because the change was not needed.


Consider adding EventTrait

For using in domain entities.
Logic: entity create events, but send their to dispatcher after save entity.
Example:
final class Post
{
    use EventTrait;

    public function setName(string $name) {
        $this->name = $name;
        $this->recordEvent(new SetNameEvent()); // Save event in entity
    }

    public function setAge(int $age) {
        $this->age = $age;
        $this->recordEvent(new SetAgeEvent()); // Save event in entity
    }
}

final class PostService
{
    public function save(Post $post)
    {
        $this->postRepository->save($post);
        $events = $post->releaseEvents(); // Get all events from entity and clear
        foreach ($events as $event) {
            $this->dispatcher->dispatch($event);
        }
    }
}

Example of implementation

Mentioned in the articles:

Decouple your Symfony application using Domain Events (EN)
Проектирование сущностей предметной области (RU)

Conclusion is not to defer events because of their mutational nature. There is no way to process them correctly in this case.


feat(rn): add bundle injection logic

Pull Request Checklist

[ ] Did you add new tests and confirm existing tests pass? (yarn test)
[ ] Did you update relevant docs? (docs are found in the site folder, and guidelines for updating/adding docs can be found in the contribution guide)
[ ] Do your commits follow the Conventional Commits standard?
[ ] Does your PR title also follow the Conventional Commits standard?
[ ] If you have a breaking change, is it correctly reflected in your commit message? (e.g. feat!: breaking change)
[ ] Did you run lint (yarn lint:check) and fix any issues? (yarn lint:write)
[ ] Did you follow the contribution guidelines?

PR-Codex overview
This PR introduces support for bitcoinj and enhances cryptographic functionalities in the NativeTEKStamperModule. It updates dependencies, adds key management using Tink, and implements hybrid decryption for credential bundles.
Detailed summary

Added bitcoinj-core dependency.
Introduced Tink related imports and configurations.
Removed unused EcdsaSignKeyManager and SignatureConfig.
Replaced ephemeral key generation with HpkeParameters.
Updated injectCredentialBundle method for hybrid decryption.
Added BUNDLE_KEY for storing decrypted keys.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#1130  👈
#1129
#1128
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @moldy530 and the rest of your teammates on  Graphite


Shall we consider setting the default region as us-east-1?

This what backstage does.
https://github.com/backstage/backstage/blob/999936b3915d807206f833f44c8397775780a22e/packages/backend-common/src/reading/AwsS3UrlReader.ts#L50
export const DEFAULT_REGION = 'us-east-1';

Shall we consider this?
With this approach, the region is not a breaking change any more.

I suppose following what Backstage does might be a good idea, although it does feel like a bit of a workaround that was just added to work with the new aws-sdk version.
We don't use AWS S3 internally, thus the region value does not actually matter to us, so do feel free to open a PR that adds us-east-1 as a default.

Ah yes, that makes sense. :) If a default is introduced then there will still have been a breaking change, but not if you skip the version with the required region parameter and go directly to one with a new default.