Support AST and Tokens as output targets

What was wrong?
There's currently no way to instruct the compiler to show the internal representation of Tokens or AST for a given code snippet. Being able to emit these can be beneficial for learning purposes and debugging.
How was it fixed?

Unrelated but included in this PR: Map -e, -o to --emit and --output-dir
add support for ast and tokens target
internal changed the yul compiler from only emitting the bare yul str to emitting a CompilerOutput

pub struct CompilerOutput {
    pub tokens: String,
    pub ast: String,
    pub yul: String,
}

Codecov Report

Merging #79 into master will decrease coverage by 0.11%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master      #79      +/-   ##
==========================================
- Coverage   87.90%   87.78%   -0.12%
==========================================
  Files          36       36
  Lines        2281     2284       +3
==========================================
  Hits         2005     2005
- Misses        276      279       +3

Impacted Files
Coverage Δ

compiler/src/yul/mod.rs
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de034e0...23d821c. Read the comment docs.


Sending Branch Deeplink via push notification not translating into URI for routing

Hi, I'm following this the steps required to be able to handle Branch Deeplinks sent in push notifications: https://github.com/BranchMetrics/android-branch-deep-linking#deeplink-via-push-notification
What I'm doing is heading over to Mixpanel and sending the push from over there to a specific device, the following is a push that includes a Branch URI and it works when I try to route it. Meaning I am able to read the URI as uri.host and determine what to do with it accordingly, using the rest of that URI's params to know exactly what to do.
{"mp_message": "This is a message", "branch": "my-app://search/create/?make_id=chevrolet&year_min=2007&price_max=230000"}
Now for actual URL's (deeplinks) being sent as a part of the message:
{"mp_message": "This is a message", "key_name": "https://my.app-app.link/JYYFLYtG8T"}
This push is received successfully as well of course, but the handling is the problem, the above documentation from Branch states that I have to pass that link, as is, to my result intent under the key branch so that Branch may magically turn it into a URI that I can parse like I did with the payload above?
Intent resultIntent = new Intent(this, TargetClass.class);
intent.putExtra("branch","http://bnc.lt/testlink");
.....
PendingIntent resultPendingIntent =  PendingIntent.getActivity(this, 0, resultIntent, PendingIntent.FLAG_UPDATE_CURRENT);

And this is just what I do as it happens that I re-send the contents of that push notification as my own local notification by doing the following:
if (routerKeyLink != null && routerKeyLink.contains("http")) {
                clickedIntent.putExtra("branch", routerKeyLink)
}

.....
val actionIntent = PendingIntent.getActivity(
                this,
                0,
                clickedIntent,
                PendingIntent.FLAG_UPDATE_CURRENT
            )

            val notification = NotificationCompat.Builder(
                this,
                getString(R.string.car_updates_notification_channel_id)
            )
                .setContentIntent(actionIntent)

..... ETC.

And the push is successfully sent, clicking on it though does not produce anything new, or turn the URL into a URI that i can parse like the above, it just remains as is: https://my.app-app.link/JYYFLYtG8T This is something I cannot treat in the same fashion as I do above of course, isn't this what is supposed to happen when I follow the above docs?
My Branch Links Host value is correct and matches the URL i am sending in the faulty push, I don't know what else to do here.
Branch lib version 3.0.1

nothing?

Hey @Odaym, we released a new version of the Android SDK v3.1.1 https://github.com/BranchMetrics/android-branch-deep-linking/releases/tag/3.1.1 to address the known issue with Push Notification deep linking.
You can continue to use the current implementation, but with the new update, you'll receive the deep link data inside the initSession() method when you click the notification with Branch link under branch key in the intent, as you get the data with normal deep links. This should help resolve the issue you are facing.

Thanks, I hope you can leave this issue open until I try this tomorrow 👍

Seems to have worked as you mentioned, thank you again!


About pre-trained checkpoint

When I tested with the pre-trained checkpoint, I found that the L1 distance of the VoxCeleb and taichiHD datasets was better than the L1 distance in the paper. I want to know why.
Is the pre-trained checkpoint trained on the training set or on the entire dataset (including training set and testing set).
Thank you.

Provided checkpoints obtained with more iterations. In paper number of iterations is chosen to be comparable with the baselines.

thank you!


[SPARK-14387][SPARK-16628][SPARK-18355][SQL] Use Spark schema to read ORC table instead of ORC file schema

What changes were proposed in this pull request?
Before Hive 2.0, ORC File schema has invalid column names like _col1 and _col2. This is a well-known limitation and there are several Apache Spark issues with spark.sql.hive.convertMetastoreOrc=true. This PR ignores ORC File schema and use Spark schema.
How was this patch tested?
Pass the newly added test case.

Test build #82620 has started for PR 19470 at commit d11ce09.

Test build #82620 has finished for PR 19470 at commit d11ce09.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82620/
Test PASSed.

Hi, @gatorsmile and @cloud-fan .
Could you review this PR?

Could you create test cases with the different schemas between files and hive metastore.

Thank you for review, @gatorsmile .
Sure. I assume that you want to check the regression here. Could you tell me the degree of difference?
Here, this PR is focusing on missing-columns scenario after ADD COLUMNS. This is a typical use cases by customers.

I remember we previously hit multiple issues due to the schema difference between the actual orc-file schema and the metastore schema. Just ensure it still exists.

Ya, that was my question, too.

What kind of difference does Spark support, especially in ORC? Apache Spark only supports HiveFileFormat so far, not old OrcFileFormat.
In addition, there is no Schema Merging. Randomly (usually the bigging ORC file?), the first correct ORC file schema is used now. For old ORC cases, those are meaningless like _colX. For me, HiveMetastore schema is the only valid one in Apache Spark.

To be clear, I'll file another JIRA about ORC status on mismatched column orders.

Hi, @gatorsmile .

For mismatched column orders: SPARK-22267 shows the current status of ORC.
For mismatched column types: Parquet also does not support.

Test build #82701 has started for PR 19470 at commit 8ac1acf.

Test build #82701 has finished for PR 19470 at commit 8ac1acf.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82701/
Test PASSed.

Merged build finished. Test PASSed.

LGTM except some minor comments

@cloud-fan . Thank you so much for review!
I updated the PR except one: IffieldValue is null, we also use setNull again in else. So, the current one is simpler.
if (fieldRef == null) {
  row.setNull...
} else {
  val fieldValue = ...
  ...
}

Test build #82718 has started for PR 19470 at commit ef2123e.

LGTM, pending jenkins

Test build #82720 has started for PR 19470 at commit 8e7fe9b.

LGTM too.

One minor comment doesn't affect this. LGTM.

Test build #82718 has finished for PR 19470 at commit ef2123e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82718/
Test PASSed.

Test build #82720 has finished for PR 19470 at commit 8e7fe9b.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82720/
Test FAILed.

Merged build finished. Test FAILed.

Retest this please.

R failure seems to be irrelevant.
[error] running /home/jenkins/workspace/SparkPullRequestBuilder/R/run-tests.sh ; process was terminated by signal 9
Attempting to post to Github...

Test build #82724 has started for PR 19470 at commit 8e7fe9b.

Test build #82724 has finished for PR 19470 at commit 8e7fe9b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82724/
Test PASSed.

Now, it's passed again. :)

thanks, merging to master/2.2!

Thank you so much, @cloud-fan , @gatorsmile , and @viirya !

BTW, @cloud-fan . Could you review #18460 , too? I think we need your final approval. :)


Unmet peer dependencies, @typescript/ata 0.9.4 x<EMAIL_ADDRESS>found 5.4.2

Describe the bug
pnpm enables strict-peer-dependencies in the latest version, and @typescript/ata 0.9.4 peers<EMAIL_ADDRESS>but slidev/client's typescript version is 5.4.2. so the start template installs deps via pnpm, will get a error.
 ERR_PNPM_PEER_DEP_ISSUES  Unmet peer dependencies

.
└─┬ @slidev/cli 0.48.3
  └─┬ @slidev/client 0.48.3
    └─┬ @typescript/ata 0.9.4
      └── ✕ unmet peer<EMAIL_ADDRESS>found 5.4.2

hint: If you don't want pnpm to fail on peer dependency issues, add "strict-peer-dependencies=false" to a .npmrc file at the root of your project.

To Reproduce
Steps to reproduce the behavior:

pnpm create slidev@latest
use pnpm to install

To Fix

add .npmrc and set strict-peer-dependencies=false in the starter template.
or, fix the peer deps version

Desktop (please complete the following information):

OS: NA
Browser: NA
Slidev version: NA

https://github.com/slidevjs/slidev/pull/1448#issuecomment-2008727969

strict-peer-dependencies is enabled by default since pnpm v7 (https://github.com/pnpm/pnpm/pull/4427), but re-disabled in v7.3.15 (https://github.com/pnpm/pnpm/pull/5499). So updating pnpm to a version larger than v7.3.15 can fix this.

pnpm -v
8.15.4

My pnpm version is 8.x

tested on pnpm v8.15.1 and v8.15.4 and laetst(v8.15.5), all no error happens


ERROR TypeError: Cannot read property 'foo' of undefined

I'm submitting a ...  (check one with "x")
[x] bug report => check the FAQ and search github for a similar issue or PR before submitting
[ ] support request => check the FAQ and search github for a similar issue before submitting
[ ] feature request

Current behavior
You use a {placeholder}, you get an error.
https://stackblitz.com/edit/ngx-translate-pluralization?file=app%2Fapp.component.html
Expected/desired behavior
No errors.
Reproduction of the problem
https://stackblitz.com/edit/ngx-translate-pluralization?file=app%2Fapp.component.html
Please tell us about your environment:
(shown in dep list on stackblitz, all the latest)

most likely a fault of the core, rather than the plugin, as it works for pipe, doesn't for directive

The problem is in your translation file.
{
  "TITLE": "{{value}} foo"
}

See https://github.com/ngx-translate/core#3-define-the-translations

@CodeAndWeb except it's not the problem.
See https://github.com/lephyrus/ngx-translate-messageformat-compiler#usage

Right. Sorry - missed that you are using message format compiler...

As far as i know translate directive should not receive the key you are attempting to translate i just change your example to
TITLE

and error goes

Both should work.

@CodeAndWeb you are right seems i'm a little outdated

But it's at least interesting that your version avoids the error :)

problem seems to be related when node is empty and it tries to set the the key, i'll check it when i get some time

I solved this by
{{ 'HELP.STEPS.1.TEXT.1' | translate:"{siteName: '" + ('SITE_NAME' | translate) + "'}" }}
`or simply by:
{{ 'HELP.STEPS.1.TEXT.1' | translate:"{siteName: 'Your Site Name'}" }}

May be related issue https://github.com/lephyrus/ngx-translate-messageformat-compiler/issues/35
Seems that this is an error in ngx-translate core.

Any update on this? Same issue here. Works with the filter, does not work with [translateParams].

I find that having the translateParams directive before the translate directive prevents that error.
So, instead of:

Use:

hello, same problem here, I was struggling trying to figure out what was the problem; thanks for reporting it and the workarounds.


Skills retrieve from CV/text (In built)

Create a function that can retrieve developer skills from CV/resume text.

completed


Native POSIX MAC addresses are not random and are duplicate between multiple instances

Describe the bug
I am building a network of multiple instances of Zephyr, each instance represents a simulated radio with a wired and wireless interface.
I am using the following kernel configurations to generate 2 virtual interfaces and I want truly random MAC addresses, or random enough so that there are no collisions between multiple running instances on a single workstation.
# Random MAC is required for more than 1 POSIX interfaces
CONFIG_ETH_NATIVE_POSIX_RANDOM_MAC=y

# POSIX two interfaces, wired and wireless
CONFIG_ETH_NATIVE_POSIX_INTERFACE_COUNT=2

But for multiple instances, the MAC addresses will match between instances, so I get the same MAC for the zeth0 interface as 02:00:5e:00:53:3b and for zeth1 as 02:00:5e:00:53:cc.
To Reproduce
Steps to reproduce the behavior:

west build -p always -b native_posix_64 -- -DOVERLAY_CONFIG=prj[x].conf*
The custom kernel overlay file prj[x].conf simply contains a different prefix for the POSIX drive name (e.g. CONFIG_ETH_NATIVE_POSIX_DRV_NAME="zeth1.").
Run applications, and observe the MAC addresses assigned to the zeth[x].0 and zeth[x].1 interfaces. They will match in my experience.
See error as my application logs below.

Expected behavior
Unique MAC addresses for each virtual interface.
Impact
Showstopper relative to networking between multiple nodes using Linux bridging between devices.
Application Log output
exec: Wired interface 'zeth1.0', MTU 1600, MAC Address : 02:00:5e:00:53:3b
Raw socket on wired interface 'zeth1.0; is open with socket 0
HSS UDP socket on wired interface 'zeth1.0; is open with socket 1
LSS UDP socket on wired interface 'zeth1.0; is open with socket 2
ifaceAddIpv4Addr: Adding IPv4 Address to Ethernet interface 0x5593cc81d4a0 as <IP_ADDRESS>
ifaceSetNetmask: Setting Ethernet interface 0x5593cc81d4a0 netmask as <IP_ADDRESS>
exec: Wireless interface 'zeth1.1', MTU 9014, MAC Address : 02:00:5e:00:53:cc

exec: Wired interface 'zeth2.0', MTU 1600, MAC Address : 02:00:5e:00:53:3b
Raw socket on wired interface 'zeth2.0; is open with socket 0
HSS UDP socket on wired interface 'zeth2.0; is open with socket 1
LSS UDP socket on wired interface 'zeth2.0; is open with socket 2
ifaceAddIpv4Addr: Adding IPv4 Address to Ethernet interface 0x558ab5cc94a0 as <IP_ADDRESS>
ifaceSetNetmask: Setting Ethernet interface 0x558ab5cc94a0 netmask as <IP_ADDRESS>
exec: Wireless interface 'zeth2.1', MTU 9014, MAC Address : 02:00:5e:00:53:cc
Raw socket on wireless interface 'zeth2.1; is open with socket 3

exec: Wired interface 'zeth3.0', MTU 1600, MAC Address : 02:00:5e:00:53:3b
Raw socket on wired interface 'zeth3.0; is open with socket 0
HSS UDP socket on wired interface 'zeth3.0; is open with socket 1
LSS UDP socket on wired interface 'zeth3.0; is open with socket 2
ifaceAddIpv4Addr: Adding IPv4 Address to Ethernet interface 0x555fb35394a0 as <IP_ADDRESS>
ifaceSetNetmask: Setting Ethernet interface 0x555fb35394a0 netmask as <IP_ADDRESS>
exec: Wireless interface 'zeth3.1', MTU 9014, MAC Address : 02:00:5e:00:53:cc
Raw socket on wireless interface 'zeth3.1; is open with socket 3

Environment (please complete the following information):

OS: (Ubuntu 20)
Zephyr SDK Build Version zephyr-v2.6.0-1448-g4566d0ec580c)

Additional context
From source file eth_native_posix.c, it would seem the gen_random_mac() routine
generates the same MAC addresses for multiple instances of the zephyr.exe binary.
#if IS_ENABLED(CONFIG_ETH_NATIVE_POSIX_RANDOM_MAC)
	/* 00-00-5E-00-53-xx Documentation RFC 7042 */
	gen_random_mac(ctx->mac_addr, 0x00, 0x00, 0x5E);

	ctx->mac_addr[3] = 0x00;
	ctx->mac_addr[4] = 0x53;

A workaround of Native POSIX is to simply make modifications to the MAC address itself runtime.  Changes made show up under "net iface".  More testing is required to verify that the application changes do what is necessary to reassign the MAC attributes.

@aescolar  FYI

Short answer:
call native_posix as zephyr.exe -seed=$RANDOM
Long answer: native_posix is meant by design to produce by default the exact same results each time you execute it. This is due to its nature as a test/debug platform. And that includes the random generator being seeded with the same number by default. If you want it to not produce the same result you need to seed it with something else.
This is a design choice, not a bug.

Thanks for the explanation, that makes sense.  Glad to see there is a command line argument for doing this.


How would i add a bootup cutseen

Describe your problem here.
How would i make it so when you open the mod it will play a cutseen
Are you modding a build from source or with Lua?
Source
What is your build target?
Windows x64
Did you edit anything in this build? If so, mention or summarize your changes.
A lot of source and mods folder

I think its easier to do it with lua, but idk if lua can play an cutscene in main menu

I think its easier to do it with lua, but idk if lua can play an cutscene in main menu

lua cant mess with menu

put this line of code in titleState.hx:  startVideo("your video's name");

put this line of code in titleState.hx: startVideo("your video's name");

this bugged but i will try again

put this line of code in titleState.hx: startVideo("your video's name");

for 0.4 hotfixes and beyond, you might have to try: PlayState.instance.startVideo("your video name");
If forcing a function from playstate doesn't work, try: new FlxVideo('your video name")

for 0.4 hotfixes and beyond, you might have to try: PlayState.instance.startVideo("your video name"); If forcing a function from playstate doesn't work, try: new FlxVideo('your video name");

thank you

for 0.4 hotfixes and beyond, you might have to try: PlayState.instance.startVideo("your video name"); If forcing a function from playstate doesn't work, try: new FlxVideo('your video name");

i keep getting null object refrence

i have a cache loading screen file it will play after would i put the fxl video pr the playstate under case one what line would i put it under?

I'm not near a compile target I can test videos on, gimmie a moment later today to check where to put new FlxVideo('your video name");, or figure out why it isn't working.

new FlxVideo('assets/videos/"your video name".mp4);

i tried and none of it works

Put your 1280x720p .mp4 file in the Psych Engine's root folder. assets>videos. Place the line,  new FlxVideo('your video name".mp4); in the .hx file where you want the video to play, and then compile it. It works if you follow this. Never tell someone SOUCRE CODE doesn't work, otherwise it's something wrong with your build.

you two should show me what your code blocks look like, there shouldn't be any issues with syntax. Videos work just fine.
new FlxVideo(assets/videos/videonName.mp4');

dont have pc access rn so imma say it from memory:
case 1:
         // skip.Intro()

         new Flx video("brap".mp4);

i think it was something like this idk i dont remember

Itz

it goes case 1 then 3 cuz 2 breaks the code 0 idea why

dont have pc access rn so imma say it from memory:
case 1:
         // skip.Intro()

         new Flx video("brap".mp4);

i think it was something like this idk i dont remember

new Flx video("assets/videos/brap.mp4");
lol

were guys keeping the quotes in the whole time??

were you guys keeping the quotes in the whole time??

how was i supposed to know? you didnt say NOT to include the quotes?

ok i changed the code and now it works, thanks

Wait so what line in TitleState.hx do I put "new FlxVideo(assets/videos/videonName.mp4')?"
I want it on startup..

Yeah, so I put in the code, but when I try building it I end up with:
"source/TitleState.hx:664: characters 9-17 : Type not found : FlxVideo"
What should I do?


Quote into variable?

Hi,
First of all, thanks for you work, I discovered you tool by reading MISC :)
I have prepared my macro as suggested in the doc (cf demo_prepared.txt).
I have a randomized macro generated but in fact, it's not OK with syntax (cf demo_result.txt).
IMHO, it's because of "quote" inside the variable (it should break the detecting string regex) but I need them in the powershell command.
So my question is : how can I achieve what I want?
demo_result.txt
demo_prepared.txt

I managed to do what I want by putting Chr(34) instead of quote.
Wait for a better idea is someone has :-)

Hi elenoir .
Right on time :smile:.
I commit the fix for quotes inside string yesterday evening (issue by telltell3). I tried with your demo_prepared.txt, everything sounds good now with this new commit.
Thx for the report,


⚠ Mobitopup has degraded performance

In d7a219f, Mobitopup (https://napcard.voz.tech) experienced degraded performance:

HTTP code: 200
Response time: 3920 ms

Resolved: Mobitopup performance has improved in e296de5.


Package deployment fails on v3.0.0

With the update to v3 deployment started to fail with:
Run azure/webapps-deploy@v3
Package deployment using OneDeploy initiated.
Error: Failed to deploy web package to App Service.
Error: Deployment Failed, Error: Failed to deploy web package using OneDeploy to App Service.
Not Found (CODE: [40](https://github.com/pure-fa/fa-cbs-lighthouse/actions/runs/6532560651/job/17735980172?pr=85#step:16:41)4)

On v2 the workflow and function app configuration we have was working. Since the release doc explicitly says that Users who are currently using the webapps-deploy@v2 can still use the same action without any change in the workflow file. I assume no changes are needed on our side.
Our workflow for reference:
    - name: Publish package
      id: publish_package
      uses: azure/webapps-deploy@v3
      with:
        resource-group-name: ${{ env.AZURE_FUNCTION_RESOURCE_GROUP_NAME }}
        app-name: ${{ env.AZURE_FUNCTION_APP_NAME }}
        package: ${{ env.AZURE_FUNCTION_APP_PACKAGE_PATH }}

I am having this same issue using v3.0.0, however I inserted all the necessary parameters, including publish-profile but it still fails.

I have the same issue with v3 (v2 works). When digging into the AppServicePlatformLogs, I can find the following logs:
EventName:ContainerStopped - Reason: - Message: - ContainerIDs:4c98f9dc3faec6fc00a299e9acdd5870c9bc483076471716353dacc837f5f4e7 - AdditionalInfo:
Stopping site <app-name> because it exceeded memory limits.

Thanks for bring this to our attention @barinalex. Are you trying to deploy to a consumption (serverless) function app?

We're using a consumption plan, yes.

Hey @tschirky , @barinalex if you're deploying the Function apps, did you try using this action.

@sgollapudi77 No we haven't. What's the rational behind using the "functions-action" and not the "webapp-deploy" action? I'm a bit confused, as we're having a web app on app services, and not a pure function app.

Hi, I was testing v3, but can't make it work:

replaced:
      - name: Deploy APP       uses: azure/webapps-deploy@v2       with:         app-name: ${{ env.AZ_APP_NAME }}         package: app-artifact
That deploys successfully, with:
      - name: Deploy APP       uses: azure/webapps-deploy@v3       with:         app-name: ${{ env.AZ_APP_NAME }}         package: app-artifact         type: ZIP         clean: false         restart: true
that lamentably fails with this error:
`Run azure/webapps-deploy@v3
Package deployment using OneDeploy initiated.
node:events:491
throw er; // Unhandled 'error' event
^

Error: EISDIR: illegal operation on a directory, read
Emitted 'error' event on ReadStream instance at:
at emitErrorNT (node:internal/streams/destroy:157:8)
at emitErrorCloseNT (node:internal/streams/destroy:122:3)
at processTicksAndRejections (node:internal/process/task_queues:83:21) {
errno: -21,
code: 'EISDIR',
syscall: 'read'
}`

@gopher194 I will need the name of your app to look into this. If you do not want to post it here, please email me at<EMAIL_ADDRESS>

@gopher194 and anyone else having the same problem with the EISDIR error and happens to land here: the issue seems to be from setting package to point to a directory instead of a file. This fixed it for me:
    package: *.zip
    type: ZIP

Suggestion for Azure team: make the reason for this error a little more verbose.

The issue is still happening

The issue is still happening

I forgot to add WEBSITE_RUN_FROM_PACKAGE with the value 1 to the App Settings of my Web App. This tells Azure that you want the app service to run from the package (no kidding, Sherlock haha) you’ve provided. So, maybe this is the same issue for you and others encountering it! 🤞🏻


[WIP] - Sticky powerup + vertical snapping + other fixes.

This adds a couple of features...
Sticky powerup
Demo - http://www.giphy.com/gifs/3kymprR8R3onHgmoIv

When the player touches a ball while not spinning, the ball comes to a stop
When the player is spinning, the ball behaves as normal

To-do

[x] Add a better icon/graphic for the powerup
[ ] Rename to "sticky" in the code
[ ] Add better visual indication that the ball won't stick when the paddle is spinning (make the paddle less dark?)
[ ] Add some effect to the ball, or particles or something, to indicate the ball will stop
[x] Make it last longer, it's not as devastating as the Grow powerup, so we can make it last a big longer
[ ] Add a sound? Some kind of sticky thump when the ball is hit?

cc @DevonBird

Vertical Angle Snap
This makes it easier to end up in a vertical alignment, which is generally what you want after you have been spinning for a while. You can still go vertical with a short tap if you want to handle a vertical ball.
Demo - https://giphy.com/gifs/9M1of3ZxgmfSPvVne3

When the player spins for longer than 100ms, the paddle snaps to a vertical orientation
When the player does a 'tap' spin, it snaps to 90 degree increments, as before

Other fixes

The "gun" and "word" effects after a hard hit only trigger if you are spinning. They no longer trigger if you just run into the ball while not rotating.
Z-index of elements on the board now depends on their Y position on the board so that things overlap properly.

Sir, these are excellent changes. I love the magnet powerup. It's not really "sticky" though. It's like a sponge, or a dampener. It could be like a tractor beam, but I really like how it feels now. Actually, I wonder what it would be like to slow it down even more.
Good call on the vertical snapping too. It's subtle, but feels correct.

@secretrobotron MERGED


first docu for g8os

use the gitbooks repo
https://www.gitbook.com/book/gig/g8os
create working set of docu

how to get started
how to use
configuration
...

a lot of content can be moved from main jumpscale repo
e.g. https://gig.gitbooks.io/jumpscale8/content/BeyondBasics/AYS FS.html

Main configuration
https://gig.gitbooks.io/g8os/content/docs/config/generic.html
Network configuration
https://gig.gitbooks.io/g8os/content/docs/config/network.html

@muhamadazmy documentation around network is not clear, please fix asap.
e.g. how is relation with OpenvSwitch, when used when not, ...?

OpenvSwitch deamon and database are always started when they are configured (with ovs-vsctl) their devices will be configured before the network.toml is processed. From within the network.toml file one can add IP layer on top of those devices.


Formula that use shell_profile are failing

Bug reports:
Since #201 was merged, formula that use the shell_profile method are failing.  Two formula that I have seen this on are nvm and gnupg.
This is the error from nvm:
  brew install nvm
==> Using the sandbox
==> Downloading https://github.com/creationix/nvm/archive/v0.31.7.tar.gz
==> Downloading from https://codeload.github.com/creationix/nvm/tar.gz/v0.31.7
######################################################################## 100.0%
Error: undefined local variable or method `shell_profile' for #<Formulary::FormulaNamespace04637aebbac9f42aa8b16bb58c3b99b8::Nvm:0x007f991680dca0>
Please report this bug:
    https://git.io/brew-troubleshooting
/usr/local/Library/Taps/homebrew/homebrew-core/Formula/nvm.rb:24:in `caveats'
/usr/local/Library/Homebrew/caveats.rb:12:in `caveats'
/usr/local/Library/Homebrew/caveats.rb:29:in `empty?'
/usr/local/Library/Homebrew/formula_installer.rb:484:in `caveats'
/usr/local/Library/Homebrew/formula_installer.rb:513:in `finish'
/usr/local/Library/Homebrew/cmd/install.rb:273:in `install_formula'
/usr/local/Library/Homebrew/cmd/install.rb:150:in `block in install'
/usr/local/Library/Homebrew/cmd/install.rb:150:in `each'
/usr/local/Library/Homebrew/cmd/install.rb:150:in `install'
/usr/local/Library/Homebrew/brew.rb:91:in `<main>'

shell_profile now resides in Utils.Shell. It was moved there with some other functions that handle things like quoting. We could include Utils.Shell in the Formula module.
I have a patch here.
https://github.com/Homebrew/brew/pull/876

This is now fixed; thanks for your patience!


Invalid XML structure in jUnit with constructor stack trace

Summary
Test command generates invalid XML structure for jUnit when one of the tests results in a exception that generates a stack trace that includes a constructor. The constructor will be listed as ClassName. in the failure message attribute which is not valid for XML.
Validation error:
The value of attribute "message" associated with an element type "failure" must not contain the '<' character.xml(LessthanInAttValue)
<testcase name="TestMethodName" classname="ClassName" time="1.12">
            <failure message="System.DmlException: Insert failed. First exception on row 0; first error: CANNOT_INSERT_UPDATE_ACTIVATE_ENTITY, ClassName: execution of BeforeInsert
caused by: jException: No Salesforce profile for ProfileX

Class.Class1.Method: line 20, column 1
Class.Class2.<init>: line 158, column 1
Class.Class3: line 528, column 1
Class.Class3: line 344, column 1
Class.Class4: line 23, column 1
Class.Class5.execute: line 105, column 1
Trigger.Class6: line 3, column 1: []"><![CDATA[Class.ClassName.TestMethodName: line 20, column 1]]></failure>
        </testcase>

Steps To Reproduce:

Make a test class that tests code that somewhere hits a constructor and hits an exception after.
run sfdx force:apex:test:report -i [testid] -u [OrgAlias] -r junit -d [locationFile]
View Junit

Expected result
Perhaps it would make more sense to have the stack trace as part of the value of the failure element in the CDATA block and the message be more only of a description.
Actual result
Stack Trace in Message attribute of the failure element. Causing invalid XML structure
Additional information
Mac BigSur 11.4
sfdx-cli/7.110.0 darwin-x64 node-v14.17.3
Also Bitbucket pipelines in SalesforceDX docker container https://hub.docker.com/r/salesforce/salesforcedx/ tag:latest-slim

Actually digging through the cli code i found where the data is coming from. Seems the cli does exactly what is intended. The issue seems to come from how the data is structured in the actual ApexTestResult.
Apparently a DML exception triggered by another (Custom) exception returns the stack trace of that custom exception in it's message field. As a "caused by"

@Erisiel I ran into the same issue, but with another character (the double-quote) which was also not escaped correctly in the junit XML generation. I was able to fix it myself locally, so I've just created a PR that should solve both our problems:
https://github.com/forcedotcom/salesforcedx-apex/pull/279


Chat messages should be an array

To better enforce sanitization, chat messages should be an array to be ng-repeated over

Fixed this in https://github.com/mikaelec/spyfall-mobile/commit/dc7d254f6f9c4db7cf9c097bf8c75104aa60c6d0


Fixed incompatibility with older Vim versions

Fixed incompatibility with older Vim versions that are compiled without float function support such as log10 and ceil
This fixes #452

I am currently away from the computer till Monday, so can't investigate this properly. However, if the log10 call is removed then this will cause the sort keys to be wrong under certain conditions.
@vtsang - can you comment further on this? Perhaps there is another way to generate the keys

While that's true, the only case it could go wrong in some cases (not even all) is if you've got more than 10^4 (10000) files in a directory, seems like a sane enough default in case you have a Vim version without math methods :)

If Vim doesn't have float functions compiled with, then the sorting key may not work as expected. Having 4 digits as workaround is more than enough.
@WoLpH, the sortKeyFormat is not for number of files in a directory. It's for number of elements in g:NERDTreeSortOrder instead.
Its default value of NERDTreeSortOrder in my Vim is ['/s', '*', '.swpS', '.bakS', '~s'] which has only four elements. Not likely people defines it with more than 10k elements. So your workaruond should be pretty much fine in most of time.


v1.27.0 fails to build golang network filter

I'm experimenting with the new golang network filter in v1.27.0
I've created some baisc repo that implement all of the necessary functions and interfaces
and I got to the point where I want to start building the project to ".so" file to be used with my envoy instance,
however, when I try to build my project in c-shared mode I'm getting the following error:
/go/pkg/mod/github.com/envoyproxy/envoy@v1.27.0/contrib/golang/filters/network/source/go/pkg/network/capi.go:30:10: fatal error: api.h: No such file or directory,
the file is indeed not a part of the module when imported (although it does appear to exist in this repo but not when imported)
could there be something that I'm missing?

cc: @doujiang24 @wangfakang

seems that this fix pr forget the contrib/golang/filters/network/source/go/pkg/network/capi.go file, https://github.com/envoyproxy/envoy/pull/28722/files


MRG: Add second-order sections filtering

This should give us more stable IIR filtering.
Closes #1941.
cc @teonbrooks @jona-sassenhagen @dengemann since you were originally interested in #1941.

I plan to tackle #3239 after this is merged

[Current coverage][cc-pull] is 86.19%

Merging [#3324][cc-pull] into [master][cc-base-branch] will decrease coverage by 0.05%

@@             master      #3324   diff @@
==========================================
  Files           336        336
  Lines         57298      57503   +205
  Methods           0          0
  Messages          0          0
  Branches       8717       8755    +38
==========================================
+ Hits          49414      49562   +148
- Misses         5214       5255    +41
- Partials       2670       2686    +16

[][cc-pull]

Powered by Codecov. Last updated by [61885e6...32977d9][cc-compare]
[cc-base-branch]: https://codecov.io/gh/mne-tools/mne-python/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/mne-tools/mne-python/compare/61885e6c5db39b1147dd9450ebc0922b2aa77c0b...32977d99932a3a43afa2b2cf31c7156f3218a81f
[cc-pull]: https://codecov.io/gh/mne-tools/mne-python/pull/3324?src=pr

This looks great! One small thing though: is it really necessary to provide the full filtfilt and sos filter implementations in fixes.py? (Maybe it is, but it is the one thing in this PR that stood out to me as a bit weird). Scipy 0.16 really isn't that new anymore, if someone is still using the ancient 0.15 version, couldn't MNE fall back to standard ab filtering?

is it really necessary to provide the full filtfilt and sos filter implementations in fixes.py

For filtfilt we were doing something bad before, which was to discard a kwarg. For sosfiltfilt it's going to be in 0.18 when it comes out but is not otherwise released, so it needs to be in there, too.

Comments addressed

@agramfort rebased for you :)

code LGTM
can you document this somewhere? in the filtering tutorial? shall we change our filter params in some examples?

can you document this somewhere? in the filtering tutorial? shall we change our filter params in some examples?

I don't think we use IIR filtering in any of the examples actually. Right now the filtering tutorial is all FIR filters, and it would take a lot of work to bring in IIR. Would it suffice to open an issue about expanding the filtering tutorial to IIR?

can you maybe just create an example that runs different filters on sample
on one good sensor (or all if fast enough) and plot all of them next to
eachother? I'd like to be able to point people to an example or some doc so
they can evaluate what's best for them.

Wouldn't really make much sense to have that example be separate from the FIR filtering tutorial, though. I'll see if I can update the filtering tutorial instead, maybe it won't take that long.

@agramfort done
https://1319-1301584-gh.circle-artifacts.com/0//home/ubuntu/mne-python/doc/_build/html/auto_tutorials/plot_background_filtering.html#iir-filters

You probably know most/all of what's in there, but if you need a ref for filter design for EEG:
http://www.sciencedirect.com/science/article/pii/S0165027014002866

can you also add a few sections "See also" to cross link between the filtering functions such construct_iir_filter and eventually the tutorial on filtering? the more cross links we have the better.

@agramfort cross-refs added

thanks heaps @Eric89GXL !

This seems to have broken master, since this doesn't work on scipy 0.11.

Oh right the doctest will break. @agramfort that's why I had the skips in there, there is no way to have the doctests only run if a specific scipy version is available. I'll open a quick PR to fix it soon.

master should be fixed now


Create a pop-up when exiting application

I want to contribute in this issue. Please assign it to me.

I'll assign you this issue when the contribution period starts from 10th June, then you can start working on this issue.

Thank you!

I want to contribute to this issue. Please assign me this one.

I want to solve this issue. Please assign me the task.

I'll assign you this issue when the contribution period starts from 10th June, then you can start working on this issue.
Since many contributors are willing to resolve this issue only the best solution/design will be accepted.

i want to contribute in this issue.please assign me this task

I want to contribute to this issue. please assign me this task

@Khushijindal24 this issue has already been resolved see pull request https://github.com/QAZIMAAZARSHAD/Income-Tax-Calcultor/pull/13.
I'll merge this request tomorrow which will close this issue. You can always open another issue to improve the design if you have any better idea.

ok sir

@QAZIMAAZARSHAD sir please assign this issue to me

i want to do this, assign me this kindlly

I want to do this, assign me this kindly

@Itashamodi this issue has already been resolved by @shashwat-2077 and it will be closed soon.
You can look for any other issues or open a new one.


Question regarding Permissions in Permission Dialog

If I open the Edit Permission dialog, I see the permissions I have in place as expected (including the ones I have registered specially) What confuses me though is that there are 2 Administration entries One as the root of my Administration sub permissions and a Administration one above it. Is the one that is a root of other Admin permissions just there as a placeholder for the tree start? As in if you grant that it ticks the boxes below it?
Would the way to clear this up be to create a new Sub Permission called Administration:General and then get rid of the non sub type one? Or would this break everything?

You should change "Administration" to something like "Administration:General"
One you see is group ("Administration:"), while one is a permission key ("Administration").

Thanks Volkan. I went through and did that. I noticed that there is some variance in the way Permissions are assigned in the standard code. Some use PermissionKeys. and others name key explicitly with "". Might be worth going through the code to make this standard just in case. It's not a functional issue at all and I can understand if you don't feel like doing that :)


Post Release Version Increment for Core Libraries

/check-enforcer override

Pipeline stages are failing on non-code issue, others have passed which verified PR


Create .styleci.yml

Add PSR-2 screening.

@humbug/core wdyt of waiting for two approvals before merging and when the two are given anyone can merge?

@theofidry That sounds good here - I was going to bring up on a issue thread with a few other items, but let's see what the other guys think.

Sounds good! The only edge case happens when a core member opens a PR, shall we treat it as implicit approval or require two other core members to approve it?

@pamil as a rule I would say no exception (for that case). However I'm also for being a minimal flexible: if the PR is relatively simple (e.g. merge a StyleCI fix) I would be ok with only one approval

I agree on keeping exceptions to simple cases - it may extend the time to getting stuff merged, but it also adds an additional layer of checking, and keeps everyone informed about what's going into the code ;).


[TIKA-4309] Mach-O Universal in tika-mimetypes.xml

A follow-up to #1947 & #1961 & #1962: Mach-O universal + optimized Mach-O
cc @tballison

Probably I'm testing in a wrong way locally as I didn't see a failing test on my side

Updated to make it a non-breaking change

Aren't the magic bits at 4096 important for jnilib? Or what is the difference between what we were detecting as x-java-jnilib and mach-O and its variants?
  <mime-type type="application/x-java-jnilib">
    <_comment>Java Native Library for OSX</_comment>
    <magic priority="50">
      <match value="0xcafebabe" type="string" offset="0">
        <match value="0xfeedface" type="string" offset="4096"/>
        <match value="0xfeedfacf" type="string" offset="4096"/>
        <match value="0xcefaedfe" type="string" offset="4096"/>
        <match value="0xcffaedfe" type="string" offset="4096"/>
      </match>
    </magic>
    <glob pattern="*.jnilib"/>
  </mime-type>

Aren't the magic bits at 4096 important for jnilib? Or what is the difference between what we were detecting as x-java-jnilib and mach-O and its variants?

Yes and no. There's no guarantee they are at 4096 offset, that's empiric - at least based on what I know as of now. The offset should be read from the file itself - that's why I've asked about dynamic offset. An top of that, we should check that it's a library, not that it's a Mach-O, so technically those checks aren't ideal either.
So far we're mimicking the file behavior that was also used by this:

This might be useful: https://github.com/gabriel-vasile/mimetype/pull/53/files#diff-db84ad344d2bf91ea9533dbaa5974e81940b053644665471594fb2eedd34e7daR19 ?

K, that's what I was trying to figure out -- the diff between what we were calling a jnilib (https://issues.apache.org/jira/browse/TIKA-1169 for the original work on jnilib) and mach-o


Doesn't re-render on HMR

I'm using vite and in dev mode when HMR happens on a module that calls a tunnel, the tunnel itself isn't re-rendered.
I've written a helper as a work-around:
import t from 'tunnel-rat'

export const tunnel = (key: string) => {
  if (import.meta.hot) {
    const fullKey = `tunnel-${key}`
    if (import.meta.hot.data[fullKey]) {
      return import.meta.hot.data[fullKey]
    }
    import.meta.hot.data[fullKey] = t()
    return import.meta.hot.data[fullKey]
  }
  return t()
}

The helper requires a key so that it can persist the tunnel instance in import.meta.hot.data. I'm not incredibly experienced in HMR, so I'm not sure if there's a better solution here.
I believe the issue may have been masked before because we were never clearing the tunnel contents.

is this something that can safely be published that way? or will it inhibit some bundlers or environments?

I've got a safer solution. It's a minor breaking change, but worth it I think. I'll PR it.

I've got a safer solution. It's a minor breaking change, but worth it I think. I'll PR it.

@zephraph Could you say more about this change? I'm going to re-implement the same pattern very soon and I'd love to have HMR


Update azure-stack-add-scale-node.md

We need to note that expansion is possible, but scale in operations are unsupported. This page appears to be best to add the note.

@rammalkani : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@rammalkani I have a small language change request. Thanks! Matt
#in-progress

@rammalkani : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Made the language change as suggested.

#sign-off


Locale in bootstrap-datetimepicker?

Can I use the locale in calendar to be translated into the selected language, set the output format of the date and change icons of the calendar?
For example, {{> afQuickField name = 'postedAt' template = "bootstrap3-horizontal" label-class = "control-label postedAt" input-col-class = "controls postedAt" placeholder = "__ / __ / __ __: __" timezoneId = "Europe / Moscow" format = "dd-mm-yyyy" locale = "RU" buttonClasses="fa fa-calendar"}}
The package is not compatible with https://github.com/michaelbishop/meteor-bootstrap-datepicker ?
Thank you!

Hey, folks! Telescope has changed a lot in the past months, and there is a new React-based version, Telescope Nova (intro video). If you know Crater, it runs on the latest version.
The Legacy version is no longer supported. I'm closing this issue.
I invite you to check the new version, it's awesome!
Happy hacking! 🚀
Ps: by the way, don't hesitate to join the Slack to ask any question, you are welcome! 👍


ThemeData constructor is complex and untested

The behavior of the ThemeData constructor determines the appearance of Flutter apps and is fairly complex. We should consider writing some tests for this constructor, to document what the important behaviors are.
Relates to #17848.

@collinjackson In my experience it's the most frustrating feature of Flutter. On the paper the Theme is a very cool and useful feature but in fact its implementation is in pain 😥. I found several bugs using Theme and widget style customization in general.  In my experience a lot of Theme values are not take into account while they had to. This enforce my incomprehension about Theme behavior. For example #17717

Hi @collinjackson
Do you think this issue still valid?
Thank you

Without additional information we are unfortunately not sure how to resolve this issue.
We are therefore reluctantly going to close this bug for now.
Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.


Documentation updating for #1717

Added usecase for oscar_fork_app command with dot path for forking to project_root dir and added reference to usecases of oscar_fork_app.
Added in #1717
p.s. Feel free correct my misspellings

Thanks, two minor spelling errors

Such silly typos :)

Thanks! :-)


Fix #2157 by adding one lemma to FStar.List.Tot.Properties

As discussed in the meeting. Thanks!

I'm fine with this PR, but wondering if it may be better to just add a lemma about memP (l1@l2), which implies this one easily by SMT (and is sometimes needed on its own, I had to define it myself for some examples).
I tried it here https://github.com/FStarLang/FStar/commit/a1184433046eed6d05f19d21f9d6e1c41fe22127, CI hasn't come back yet. Also having the memP_append pattern around probably means this lemma isn't needed: as long as the SMT is behaving reasonably, it should be trivial.

Fine by me, I'm happy with this solution since it's more general. As always, introduction of SMTPats may break unrelated proofs, so I'm happy to run an Everest regression on my (fast) linux machine if that helps. Let me know. Thanks!

Nik suggested here https://github.com/FStarLang/FStar/commit/e8ff13edd2111ed266bb0140a08222a0d6c31605 to add a pattern to the forall in the conclusion of for_all_mem, but I can't get it to work, it seems to not be triggered at all, so the proof of for_all_append fails (even when calling the lemma explicitly, bypassing the outer SMTPat). Not sure what to do here. It was anyway just a suggestion so the original PR is fine by me.


Uncaught Error: ENOENT: no such file or directory

I got this error when installing the package.
Atom: 1.18.0 x64
Electron: 1.3.15
OS: Mac OS X 10.12.4
Thrown From: atom-maven package 1.3.0
Stack Trace
Uncaught Error: ENOENT: no such file or directory, open '/Users/Serguei/projects/learn-java/effective.pom'
At fs.js:640

Error: ENOENT: no such file or directory, open '/Users/Serguei/projects/learn-java/effective.pom'
    at Error (native)
    at Object.fs.openSync (fs.js:640:18)
    at Object.module.(anonymous function) [as openSync] (ELECTRON_ASAR.js:168:20)
    at Object.fs.readFileSync (fs.js:508:33)
    at Object.fs.readFileSync (ELECTRON_ASAR.js:501:29)
    at /packages/atom-maven/node_modules/node-maven-api/lib/maven.js:49:29
    at /packages/atom-maven/node_modules/node-maven-api/lib/maven.js:71:7
    at ChildProcess.exithandler (child_process.js:225:5)
    at emitTwo (events.js:106:13)
    at ChildProcess.emit (events.js:191:7)
    at maybeClose (internal/child_process.js:877:16)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:226:5)

Commands
     -2:11.9.0 settings-view:open (div.tool-panel.tree-view)
  2x -2:02.5.0 core:confirm (input.hidden-input)
     -0:51.7.0 editor:delete-to-beginning-of-line (input.hidden-input)
     -0:49.7.0 core:confirm (input.hidden-input)
     -0:27.4.0 editor:delete-to-beginning-of-line (input.hidden-input)
     -0:25.3.0 core:confirm (input.hidden-input)

Non-Core Packages
atom-maven 1.3.0
railscast-theme 0.3.0
cucumber 0.6.0
cucumber-autocomplete 0.7.2
rails-rspec 0.3.2
rspec 0.3.2

Just a couple of questions to help me debug this issue:

Does the effective.pom file exist in the referenced directory?
Was the effective.pom file deleted by yourself or any third party apps?
Do you as the user that opened atom, have permissions to write to the referenced directory?

Any other info you can provide would be extremely helpful. Thanks!

@concon121 I can't reproduce the issue any more. I uninstalled the plugin. I think it was a corporate proxy settings problem. After re-installing it without proxy, everything seems to work as needed.
Regards


[BUG] @frontegg/redux-store/toolkit/index.js is ESM not CommonJS

I ran into an error in Jest when this file was loaded:
.../node_modules/@frontegg/redux-store/toolkit/index.js:1
    ({"Object.<anonymous>":function(module,exports,require,__dirname,__filename,global,jest){export { bindActionCreators, combineReducers, configureStore, getDefaultMiddleware } from '@reduxjs/toolkit';
                                                                                ^^^^^^

    SyntaxError: Unexpected token 'export'

      at Runtime.createScriptFromCode (node_modules/jest-runtime/build/index.js:1350:14)
      at Object.<anonymous> (node_modules/@frontegg/react-hooks/index.cjs.js:9:15)

I can probably get around this in my Jest config, but its likely that since this file is ESM, users may run into issues.

Hi @sdemjanenko,
From version 3.3.0 @frontegg/redux-store built with CommonJS format.


Go back from classic version is not working

Moved to https://github.com/frontity/wp-plugin/issues/1


feat: device attributes and other configurable properties

closes https://github.com/customerio/issues/issues/7288
closes https://github.com/customerio/issues/issues/7328
FEATURES
The customer can send device attributes over and above the default ones using react native package
Also, autoTrackDeviceAttributes is a configurable property using React Native package
This PR also covers configuring other properties such as logLevel, autoTrackPushEvents, backgroundQueueMinNumberOfTasks etc using the package
Below is an example of a workspace receiving custom device attributes

:tada: This PR is included in version 1.0.0-beta.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


feat: ✨ syn-details

Pull Request
📖 Description
This PR adds the new <syn-details> and <syn-accordion> components.
🎫 Issues

Closes #462
Closes #464

👩💻 Reviewer Notes
Next to the new components, the following adjustments where made that have to be checked:

A new size-token syn-spacing-medium-large was added. It points to a size of 20px and sits between the syn-spacing-medium (16px) and syn-spacing-large (24px) tokens.
The documentation tokens originally in branch origin/feat/change-syn-details-docs where included into this dev-branch.

📑 Test Plan

As usual compare the stories in Storybook
Have a look at the code of <syn-accordion> and make sure everything works and is accessible.

✅ DoD

[x] I have tested my changes manually.
[x] I have added automatic tests for my changes (unit- and visual regression tests).
[x] I have updated the project documentation to reflect my changes (e.g. CHANGELOG, Storybook, ...).
[x] I have made sure to follow the projects coding and contribution guides.
[x] I have made sure that the bundle size has changed appropriately.
[x] I have validated that there are no accessibility errors.
[x] I have used design tokens instead of fix css values

Accordion also done! Nice work!
I am not so sure about the default size though. Medium looks so large. I'd rather go for small as default.

@kirchsuSICKAG What do you think about taking this one over? As you already got some experience with sharp and contained this could make sense?

please review migration guide: https://gitlab.sick.com/platforms/davinci/synergymigrationguide/-/merge_requests/1


Sign in button / icon download file names

You might want to take another look at the name of the files you ask to download to use as icons or sign in buttons within apps. Perhaps a tactical _ (underscore) between 'symbol' and 'lockup' would be less suggestive of an alternative meaning to the name.
ms-symbollockup_signin_dark.png
I will now drag my mind from the gutter.
All the best.
Rob

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 142962d7-66c3-9372-3e3e-c621cba4d881
Version Independent ID: 748f0246-0a13-e7ed-46dd-be219f19343b
Content: App branding guidelines - Microsoft identity platform
Content Source: articles/active-directory/develop/howto-add-branding-in-azure-ad-apps.md
Service: active-directory
Sub-service: develop
GitHub Login: @rwike77
Microsoft Alias: ryanwi

@RADickinson good catch! :)
I made a pull request to update this document. https://github.com/MicrosoftDocs/azure-docs-pr/pull/156070
@rwike77 please review.


How to use ReactShadow with ChakraUI Drawers?

Hi guys, can anyone help me figure out why the text input breaks on this drawer: https://codesandbox.io/s/winter-bash-z0bjp?file=/src/index.tsx
We are using react shadow to encapsulate the styles and need to use portals to stop the drawer from being rendered outside of react shadow
Much appreciated

+1 did you ever figure this out?


Cannot install Nuget package in Win Universal C++ project

In an attempt to use WriteableBitmapEx in a Windows Universal Store App written in C++, I attempted to install the nuget package but get the following message:
Could not install package 'WriteableBitmapEx 1.5.0'. You are trying to install this package into a project that targets 'native,Version=v0.0', but the package does not contain any assembly references or content files that are compatible with that framework. For more information, contact the package author.
After wandering around in stack overflow, I found a link that describes how nuget supports C++ projects:
http://docs.nuget.org/consume/support-for-native-projects
Would it be possible to modify the nuget package so its compatible with C++ projects?

WBX is written in C# and compiled as a managed assembly and not available as WinRT component.

Sorry for the noob question.  In case anyone else runs into this issue, I didn't realize that my project was really "C++/CX" and is not "C++/CLI".  Here are a couple links that helped sort this out for me (and feel free to correct this if I'm posting misinformation)
http://programmers.stackexchange.com/questions/162168/what-are-c-cx-and-c-cli-and-how-do-they-relate-to-c-and-winrt
https://en.wikipedia.org/wiki/C%2B%2B/CX


Allow to pass locals when rendering a collection

Type of PR
Feature
Description
This PR implements the suggested solution as described in #27. It allows pass locals when rendering a collection with futurize:
<%= futurize partial: 'items/card', collection: @cards, as: :card, extends: :div, locals: { selected: true } do %>

<% end %>

Resolves #27.
Why should this be added
In order to stay as close as possible to the render method in Rails it makes sense to support the passing of locals when rendering a collection.
Checklist

[x] My code follows the style guidelines of this project
[x] Checks (StandardRB & Prettier-Standard) are passing

Sure! Just updated the mentioned test :)

@all-contributors add @marcoroth for code


Use rendevous hash or lexical sort for topic chain placement

the first steps here were taken care of in #112


Frontcss

@CodiumAI-Agent /review

PR Review

 ⏱ Estimated effort to review [1-5]
3, because the PR includes multiple files across both frontend and backend with configuration changes, new functionality, and styling. The complexity is moderate, involving integration with MongoDB, React components, and CSS modules, which requires a thorough review to ensure functionality, performance, and adherence to best practices.

 🧪 Relevant tests
No

 🔍 Possible issues

Possible Bug: The hardcoded MongoDB connection string in server/index.js includes credentials, which is a security risk.

Performance Concern: In client/src/components/Home.jsx, all matches are fetched and stored in state, which might not scale well with a large number of matches.
 🔒 Security concerns
Sensitive information exposure: The MongoDB connection string in server/index.js is hardcoded with credentials, which could lead to unauthorized access if the codebase is public.

 Code feedback:
relevant fileserver/index.js
suggestion

Consider using environment variables for MongoDB connection strings and other sensitive information. This prevents hardcoding sensitive data in your source code. You can use the dotenv package to load environment variables from a .env file. [important]

relevant lineconst urii = 'mongodb+srv://dev326patil:devrajcapstone326@capstone.riouq2l.mongodb.net/?retryWrites=true&w=majority&appName=Capstone';
relevant fileclient/src/components/Home.jsx
suggestion

Implement pagination or infinite scrolling for loading matches. This will improve the performance and user experience by not loading all matches at once, especially as the number of matches grows. [important]

relevant lineconst response = await axios.get('http://localhost:3000/');
relevant fileclient/src/components/Home.jsx
suggestion

Avoid using index as a key for React elements in a list. If the order of items changes, it could lead to performance issues and bugs. Consider using a unique identifier from the match data as a key. [medium]

relevant line
relevant fileclient/src/components/Home.module.css
suggestion

For better maintainability and readability, consider using CSS variables for repeated values like colors, font sizes, and spacing in your CSS modules. This makes it easier to update and keep your styling consistent. [medium]

relevant line--first-color: hsl(82, 60%, 28%);

 ✨ Review tool usage guide:
Overview:
The review tool scans the PR code changes, and generates a PR review. The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on any PR.
When commenting, to edit configurations related to the review tool (pr_reviewer section), use the following template:
/review --pr_reviewer.some_config1=... --pr_reviewer.some_config2=...

With a configuration file, use the following template:
[pr_reviewer]
some_config1=...
some_config2=...

  Utilizing extra instructions
The review tool can be configured with extra instructions, which can be used to guide the model to a feedback tailored to the needs of your project.
Be specific, clear, and concise in the instructions. With extra instructions, you are the prompter. Specify the relevant sub-tool, and the relevant aspects of the PR that you want to emphasize.
Examples for extra instructions:
[pr_reviewer] # /review #
extra_instructions="""
In the 'possible issues' section, emphasize the following:
- Does the code logic cover relevant edge cases?
- Is the code logic clear and easy to understand?
- Is the code logic efficient?
...
"""

Use triple quotes to write multi-line instructions. Use bullet points to make the instructions more readable.

  How to enable\disable automation

When you first install PR-Agent app, the default mode for the review tool is:

pr_commands = ["/review", ...]

meaning the review tool will run automatically on every PR, with the default configuration.
Edit this field to enable/disable the tool, or to change the used configurations

  Auto-labels
The review tool can auto-generate two specific types of labels for a PR:

a possible security issue label, that detects possible security issues (enable_review_labels_security flag)
a Review effort [1-5]: x label, where x is the estimated effort to review the PR (enable_review_labels_effort flag)

  Extra sub-tools
The review tool provides a collection of possible feedbacks about a PR.
It is recommended to review the possible options, and choose the ones relevant for your use case.
Some of the feature that are disabled by default are quite useful, and should be considered for enabling. For example:
require_score_review, require_soc2_ticket, and more.

  Auto-approve PRs
By invoking:
/review auto_approve

The tool will automatically approve the PR, and add a comment with the approval.
To ensure safety, the auto-approval feature is disabled by default. To enable auto-approval, you need to actively set in a pre-defined configuration file the following:
[pr_reviewer]
enable_auto_approval = true

(this specific flag cannot be set with a command line argument, only in the configuration file, committed to the repository)
You can also enable auto-approval only if the PR meets certain requirements, such as that the estimated_review_effort is equal or below a certain threshold, by adjusting the flag:
[pr_reviewer]
maximal_review_effort = 5

  More PR-Agent commands

To invoke the PR-Agent, add a comment using one of the following commands:

/review: Request a review of your Pull Request.
/describe: Update the PR title and description based on the contents of the PR.
/improve [--extended]: Suggest code improvements. Extended mode provides a higher quality feedback.
/ask <QUESTION>: Ask a question about the PR.
/update_changelog: Update the changelog based on the PR's contents.
/add_docs 💎: Generate docstring for new components introduced in the PR.
/generate_labels 💎: Generate labels for the PR based on the PR's contents.
/analyze 💎: Automatically analyzes the PR, and presents changes walkthrough for each component.

See the tools guide for more details.
To list the possible configuration parameters, add a /config comment.

See the review usage page for a comprehensive guide on using this tool.


Load 1 and 2 icons

Would it be possible to add the facility to add icons to load 1 and 2 on essential loads? The same as you have for nonessential loads.

It's possible but I cant see how these would fit on the card given the limited space

Added to v1.8.0

Thanks, can a stove icon be added as well in a future update.
Also I notice the icons only show in the full layout not the lite.  Any possibility to add this to the lite layout
Perhaps here:

Thanks

Yes. I'll add it.  I didn't have time to work on the lite card. Will do that this weekend.

Added to v1.8.1

You can now use mdi icons in 1.8.2 😄

One small issue with the mdi icons. When the card is in panel mode the mdi icons are in the middle of the card.

When the card is not in panel mode then the icons are offset to the left.

That's strange, I cant reproduce that.  Does it happen on all your devices? What browser are you using?

Seems to be a known issue with Safari.

Fixed positions looks to be working.


script runs into error

Hi,
thanks for the script, I am trying to run it windows 11 and trying for VFS Poland.
this site always needs to be opened in incognito mode so I added this line in your code.
self.options.add_argument("--incognito")
But it gets stuck on below part

Looks like they've added cloudflare captcha. You need to find some methods of bypassing the captcha.


Added additional form for giving extra option(s) to [main]

An additional rich text box was added to the plugin form. Everything written there will be placed right under outputmap of [main].
This can be used to put in a plugin with the highest priority as well, by putting in a plugin there.
Warning: doesn't give backwards compatibility!

Thank!


Missing style for table headers

In tables, the header rows is bolded, but there's no other visual indication that it's a header. Shouldn't we have some shading, @luciaaaaaaa?
Example: https://deploy-preview-8489--cockroachdb-docs.netlify.app/docs/v20.2/cockroach-start.html#general

Table header rows are displaying as mocked: https://www.figma.com/file/6XcxaUdad2RkjpEqnVHKAG/Education-docs-redesign?node-id=3254%3A8174
However, we didn't prioritize adding the filters to tables (which would add the arrows in the header). Since we don't have the filters, it might be good to add a grey background to the table headers

Table header rows are displaying as mocked: https://www.figma.com/file/6XcxaUdad2RkjpEqnVHKAG/Education-docs-redesign?node-id=3254%3A8174
However, we didn't prioritize adding the filters to tables (which would add the arrows in the header). Since we don't have the filters, it might be good to add a grey background to the table headers

This issue willl require design work

I think this is okay as is. The bolded table headers match the Design System. This issue can be closed


Release 24Q3

GPU DRA driver v0.6.0
Gaudi DRA driver v0.2.0
QAT DRA driver v0.1.0

Fixed comments, added QAT docs.


Registering Calls With BioCaddie/DataMed

@rkboyce would like to register calls with BioCaddie, DataMed
https://datamed.org/

This is nearly complete. I have a FAIR Sharing URI for the repository: https://fairsharing.org/biodbcore-001093
Submitted a dataset on 5/31 indexing request to Datamed. Awaiting response.

Associated to ticket #79

Added information out FAIRSharing.org on Wiki
https://github.com/OHDSI/CommonEvidenceModel/wiki/Data-Access

I spoke with the datamed folks today and found out more about their process. They are currently building up datamed by manually screening the datasets that scientists request they share within datamed. Our request is on the top of their queue. They are working on creating some metadata based on the CEM_UNIFIED table and the related SOURCE and CONCEPT tables. Stay tuned.


Internal link in addons view show HTML encoded hard to read for humans

VSCode Version: Rolling Release 1.31.0
OS Version: ArchLinux (Rolling Release)

Steps to Reproduce:

Go for example on any extension page
Hover a link

You'll see the same as the following screenshot displayed in the tooltip:

Does this issue occur when all extensions are disabled?:
STR doesn't seem to be testable in this mode

This only happens for anchor links. External links seem to work fine


[fix] use .ts extension for tests when using TypeScript

fixes https://github.com/sveltejs/kit/issues/4194
fixes https://github.com/sveltejs/kit/issues/4341

Version that I think is slightly more future-proof: #4368


GKE Web UI 404 Archival Using bucket

Web UI 404 when accessing detail of workflow id from archival

Here is the English translation of your issue:

I am using Helm to deploy to GKE with the values.archival.gcloud.yaml as follows:
server:
  archival:
    history:
      state: "enabled"
      enableRead: true
      provider:
        gstorage:
          credentialsPath: "/etc/credentials/credentials.json"
    visibility:
      state: "enabled"
      enableRead: true
      provider:
        gstorage:
          credentialsPath: "/etc/credentials/credentials.json"

  namespaceDefaults:
    archival:
      history:
        state: "enabled"
        URI: "gs://kp-temporal-archival/temporal_archival"
      visibility:
        state: "enabled"
        URI: "gs://kp-temporal-archival/temporal_visibility"

For persistence, I am using PostgreSQL with the following values.postgresql.yaml:
server:
  config:
    persistence:
      default:
        driver: "sql"

        sql:
          driver: "postgres12"
          host: postgres.example.dev
          port: 5432
          database: temporal
          user: temporal
          password: temporal
          maxConns: 20
          maxConnLifetime: "1h"

      visibility:
        driver: "sql"

        sql:
          driver: "postgres12"
          host: postgres.example.dev
          port: 5432
          database: temporal_visibility
          user: temporal
          password: temporal
          maxConns: 20
          maxConnLifetime: "1h"

cassandra:
  enabled: false

mysql:
  enabled: false

postgresql:
  enabled: true

prometheus:
  enabled: false

grafana:
  enabled: false

elasticsearch:
  enabled: true

schema:
  createDatabase:
    enabled: false
  setup:
    enabled: true
  update:
    enabled: true

Then, I forward the Web UI using Internal Ingress with the following configuration:
web:
  enabled: true
  replicaCount: 1
  image:
    repository: temporalio/ui
    tag: 2.28.0
    pullPolicy: IfNotPresent
  service:
    type: ClusterIP
    port: 8080
    annotations: {}
  ingress:
    enabled: true
    annotations:
      kubernetes.io/ingress.regional-static-ip-name: ingress-temporal-web
      kubernetes.io/ingress.allow-http: "true"
      kubernetes.io/ingress.class: "gce-internal"
    hosts:
      - "temporal.example.dev"
    tls:
      - secretName: temporal
        hosts:
          - temporal.example.dev

The archival and visibility files are already in the bucket.

and this is my version server 1.24.2

Thanks for reporting this issue!
It seems the Web UI is unable to fetch details of workflow IDs from archival.  To help me understand better, please let me know if you have tried accessing archival details of workflow IDs that are in a different Namespace. If you are able to access archival details for other Namespaces, then this could be a configuration issue.  Let me know if you have access to your Temporal Server logs, in which case I can ask you to provide me with additional information.


Scoring calculation

Would it be possible to change the values of the video scoring?
Currently the following scores are used:
episode_scores = {'hash': 215, 'series': 108, 'year': 54, 'season': 18, 'episode': 18, 'release_group': 9,                   'format': 4, 'audio_codec': 2, 'resolution': 1, 'hearing_impaired': 1, 'video_codec': 1}
movie_scores = {'hash': 71, 'title': 36, 'year': 18, 'release_group': 9,                 'format': 4, 'audio_codec': 2, 'resolution': 1, 'hearing_impaired': 1, 'video_codec': 1}
I have a problem with the hearing_impaired score. I would like to have it the lowest score. This means that no other video property should have an equal score.
I am using subliminal in api mode and I can configure which video properties must match before the subtitle is downloaded.
I also have an option to indicate if I want to download hearing_impaired subs or not. If enabled, they can be donwloaded, but no preference. If disabled, they should not be downloaded. Therefore, I'm putting the flag to false, which will add a match when the subtitle is not hearing impaired and increase the score with 1.
However, since the score is 1, it can also be considered a video_codec or resolution match, which messes up required video properties to match.
I hope it's a bit clear what I like to accomplish. This was working fine with the previous version (<2.0.0) . I now have this problem because the hearing_impaired is included in the scoring algorithm.
It would be nice if the default scoring could be adapted. IMHO a non video property should always have a lower score than a video property so it couldn't influence the matching.
The non video property (hearing_impaired) should only be used to increase the score with 1 if required.
-> hearing_impaired can stay 1
-> resolution and video_codec should become 2
-> recalculate the rest...
Is this feasible or are there other ways?

Thanks for the changes. What are the most sane minimum scores for TV series and movies compared to subliminal v1?
Sub-Zero currently uses (with V1) 23 for movies and 85 for series.
Thank you in advance!

This is how I'm using it: https://github.com/h3llrais3r/Auto-Subliminal/commit/1dc13045dc3eb96d5fd2139b0da39177cf5a9c26
See the changes in autosubliminal/config.py


Add link to zoom signals

We go over them in the workshop itself, but I guess it can't hurt to
make people think about it early.

Good idea. I will add a link also from the intro session.


Elastic clusters which have authentication are not supported

If you are using X-Pack or another means to protect the Elasticsearch cluster, the proxy should authenticate to that.

Fixed by https://github.com/amboss-mededu/quepid-es-proxy/pull/6


Commands with special characters are not automatically escaped, and therefore, throw an error

This throws an error. We need to escape ( and ) in this example.
s = Sultan()
s.touch("/tmp/foo(bar).txt")

NOT Working on it since it is up to the user to escape this.


Upload Cropped Image to Server?

Awesome! Other than the super beautiful crop controls, I love the fact that this tool does only one thing!It is so difficult to find an angular cropper that isn't burdened with rotate, skew, etc etc. Thanks for this.
Please do you have a small sample to show how to upload the cropped image to server? Say Nodejs? Just a little pointer might do, because I am pitching my tent here!
Oh and I did evaluate about a dozen other solutions, but this shines!

Thanks! Glad you like it. I don't have a NodeJS example right now, but I do have a PHP example ripped form one of my projects if that helps in the mean time.

$scope.selectCroppedPhoto = function()
{
	var croppedImage = {};
	croppedImage.dataUrl = $scope.cropper.croppedImage;
	croppedImage.name = $scope.generateUniqueName();
	$scope.cropper.sourceImage = null;
	$scope.listForm.croppedImages.push(croppedImage);
}

$scope.submit = function()
{
	//Unfortunately can't upload all at once so need to upload one by one
	for (var i = 0; i < $scope.listForm.croppedImages.length; ++i)
	{
		$upload.upload({
			url: 'http://<IP_ADDRESS>/projects/list',
			headers: {'Content-Type': "multipart/form-data"},
			method: 'POST',
			data:  {image:$scope.listForm.croppedImages[i]}
		}).progress(function(evt)
		{

		}).success(function(data, status, headers, config)
		{
			//is last image
			if(i==$scope.listForm.croppedImages.length-1)
			{
				//TODO redirect
			}
		});
	}
}

$scope.seed = 0;
$scope.generateUniqueName = function()
{
    $scope.seed++;
	return $scope.seed;
}

Thank you!  This code will do. Your cropper is going to hit it. I will drop a NodeJs sample here shortly, for those of the nodejs community. Been following the threads, cool!


Adjusted readme to fix issues and also delete sddc action

Adjusted readme to fix issues and also removed the variables for the sddc delete sample to be safe!

Thanks @alanrenouf! 🎉


Decide on license

The licence in the pom states its Apache2 whereas the LICENCE file states BSD 3-clause.

modify pom.xml to this
 <licenses>
        <license>
            <name>BSD 3-Clause</name>
            <url>file://${basedir}/LICENSE.txt</url>
        </license>
    </licenses>

Updated pom file to BSD-3 clause


Staged Wallet Init

Addresses #3000

There might be a conflict with https://github.com/bithyve/hexa/pull/3004


feat: [PubSub] add Schema Revision Support

This pull request addresses a critical gap in the existing functionality of the Google Library in PHP by introducing support for managing schema revisions within Google Pub/Sub. Currently, this feature is missing, and this PR aims to rectify that by providing the ability to retrieve all revisions for a specific schema, as well as the capability to commit and delete these revisions.
Key Changes:
Schema Revision Retrieval: We've added a new method to the Google Library that allows users to retrieve all revisions associated with a particular schema. This enhancement makes it easier to track and manage schema changes over time.
Example Usage:
$client = new PubSubClient();
$schema = $client->schema('schema_name');
$revisions = $schema->listRevisions();

foreach ($revisions['schemas'] as $revision) {
    echo $revision['definition'];
}

Commit and Delete Revisions: To provide comprehensive schema management, we've introduced methods for committing and deleting schema revisions. These functions empower users to control their schema history effectively.
Example Usage (Committing a Revision):
$client = new PubSubClient();
$schema = $client->schema('schema_name');
$definition = file_get_contents('path_to_your_schema_definition.json');
$revision = $schema->commit($definition, $typw);

$client = new PubSubClient();
$schema = $client->schema('schema_name');
$revisions = $schema->deleteRevision('revision_id);

Benefits:
Improved Schema Management: Users can now effortlessly access, commit, and delete schema revisions, enhancing the overall schema management experience.
Comprehensive Control: This addition provides a holistic solution for handling schema revisions within Google Pub/Sub, ensuring better version control and traceability.
We believe that this PR will significantly improve the functionality and usability of the Google Library in PHP, making it a more powerful tool for developers working with Google Pub/Sub schemas. Your feedback and review on this PR are highly appreciated.

@saranshdhingra could you take a look at this or assign it to someone who can? It looks like an important feature to me!

Hey @bshaffer and @saranshdhingra, could you provide an update on this PR? It's been over two months since it was opened. Is there anything I can do to facilitate merging these crucial changes? They're essential for managing revisions in the project I'm involved with.


the deploy script seems broken

See https://github.com/sifis-home/libp2p-rust-dht/actions/runs/4424356581/workflow

The env keyword should be aligned with the with keyword on this line, so it's not a sifis-generate issue


[5.9] [test] Require asserts for a couple of tests

5.9 cherry-pick of https://github.com/apple/swift/pull/66667

@swift-ci please test


#via comments leak full system path with new pip-tools versions

New versions of pip-tools (4.5.1) leave comments of the form # via -r requirements.in next to packages that are directly mentioned. Unfortunately, when executing pip-compile-multi -d /home/{me}/some_directory as we typically do, it makes those comments read # via -r /home/{me}/some_directory/requirements.in which is really annoying and also leaks the full system path into the repo, making the compile non-reproducible.
Our workaround for now is to instead execute pip-compile-multi with the working directory set to the target directory, and use -d ./, but that's a bit of a mess and still results in # via ./requirements.in which isn't ideal. Ideally, pip-compile-multi would set the working directory when it calls out to pip-compile to whatever is in the -d flag, and avoid this issue.

Sounds reasonable. Can you put up a PR for that?


[Girder backend] Add search-by-tag plugin

Original report (archived issue) by Andrés Fortier (Bitbucket: andres_fortier).

Add search-by-tag plugin that provides a new REST endpoint. Tags should be added to the metadata of both folders and items and we should find a way to properly query them (i.e. to make proper use of limit / count parameters)

I believe we're not considering Girder anymore, so closing this.


Knowing if you are going back or forward in the history

We have a situation where the transitions that we apply differ based on if we are moving forward or back in the history. Unless I am missing something, I don't see a way to get that info. If we were doing pushState ourselves then we have the state object to muck with, but {} is used right now as it is all handled by logic such as:
saveLocation : function(fragment) {
  fragment = (fragment || '').replace(hashStrip, '');
  if (this.fragment == fragment || this.fragment == decodeURIComponent(fragment)) return;
  if (this._hasPushState) {
    var loc = window.location;
    if (fragment.indexOf(this.options.root) != 0) fragment = this.options.root + fragment;
    this.fragment = fragment;
    window.history.pushState({}, document.title, loc.protocol + '//' + loc.host + fragment);
  } else {
    window.location.hash = this.fragment = fragment;
    if (this.iframe && (fragment != this.getFragment(this.iframe.location.hash))) {
      this.iframe.document.open().close();
      this.iframe.location.hash = fragment;
    }
  }
}

Ideally, the system would track this for us (for both pushState and hash mode) and we would be able to ask Backbone.history.* for that info (and optionally could be nice to have a forward/back event fired.
Is there any appetite for this? Is there a better solution that I am missing?
The other approach is for us to manage a state map and handle transitions based on how we are moving in the state machine.

Would it be possible to set a flag on the popstate event, and unset the flag when .navigate() is called directly?
Then we could test in our Router's handler whether or not the user pressed the browser's Back button. I think it would only work in modern browsers with HTML5 History support, but it's better than nothing.


explain auto and manual

Fixes #19

Actually it's not what I initially thought here, in Java:

for elastic agent auto means using the -javaagent setup option, which we call "manual" in our documentation: https://www.elastic.co/guide/en/apm/agent/java/current/setup-javaagent.html
for elastic agent manual means there is a minor code modification to use the runtime attach setup: https://www.elastic.co/guide/en/apm/agent/java/current/setup-attach-api.html
for otel, the manual option means explicit code changes in the app to capture traces by using only the otel API/SDK without an agent.
for otel , the auto means using the otel instrumentation agent with the -javaagent setup option, and no code modification is needed in the application (because the otel agent has automatic instrumentation for the used framework/libraries).

I think here we should probably rename and simplify things if we want to be consistent:

use the manual for the explicit tracing, which requires few changes to the application code
maybe leave the different setup options (like runtime attach and -javaagent) outside of the scope of what is shown here, as they don't provide much value and are quite well documented, also we have 3 of them in java doc.
With Elastic agent there is no "manual tracing", as it's not possible to use the tracing API without the agent. If we go this route, then only the otel agent would have a "manual".


Disallow accidental comments in JSX from being inserted as text nodes (react/jsx-no-comment-textnodes)

https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-no-comment-textnodes.md
This rule prevents comment strings (e.g. beginning with // or /*) from being accidentally
injected as a text node in JSX statements.
Rule Details
The following patterns are considered warnings:
var Hello = createReactClass({
  render: function() {
    return (

// empty div

    );
  }
});

var Hello = createReactClass({
  render: function() {
    return (

        /* empty div */

    );
  }
});

The following patterns are not considered warnings:
var Hello = createReactClass({
  displayName: 'Hello',
  render: function() {
    return
{/* empty div */}
;
  }
});

var Hello = createReactClass({
  displayName: 'Hello',
  render: function() {
    return

;
  }
});

var Hello = createReactClass({
  displayName: 'Hello',
  render: function() {
    return <div className={'foo' /* temp class */}
;
  }
});

Legitimate uses
It's possible you may want to legitimately output comment start characters (// or /*)
in a JSX text node. In which case, you can do the following:
var Hello = createReactClass({
  render: function() {
    return (

{'/* This will be output as a text node */'}

    );
  }
});

Shipping in standard 14.


Multi-channel support, broken?

Hey,
Currently with 2 channels on 1 email it doesn't seem to work, even when providing all cookies including LOGIN_INFO, on only 1 of the 2 channels it can upload successfully, and fails on the other one.
Is this a known issue or something wrong with my implementation?
(returns error 400)

Lack of this LOGIN_INFO used to cause 403 problems (more here: https://github.com/adasq/youtube-studio/issues/9)
Do you specify valid SESSION_TOKEN?


BIO_new_file has an unitialized read

On OpenSSL 1.1.0 (default on Fedora 30), the function BIO_new_file has an unitialized read of a variable.
This was found while running client code with clang's memory sanitizer.
(This also begs the question of whether the code is being tested with these sanitizers - it probably isn't and probably should - but that is another issue)
The high level API called was OPENSSL_init_ssl;
I did not evaluate whether there is any security impact. However, when dealing with UB, anything goes.

On OpenSSL 1.1.0 (default on Fedora 30), the function BIO_new_file has an unitialized read of a variable.

Which variable? Looking at the code I can't see any obvious place where that is the case.
1.1.0 is old and out of support. It's possible that this has already been fixed...although I looked at the old 1.1.0 code and couldn't see an obvious place there either where this could occur.

(This also begs the question of whether the code is being tested with these sanitizers - it probably isn't and probably should - but that is another issue)

We regularly run our full test suite with various sanitizers enabled.

Hi,
I inspected the code, and in fact couldn't find the variable.
It seems to me a hard bug to track (or maybe not a bug at all).
The library call didn't have any input, so it certainly wasn't any misuse on my part.
I understand that 1.1.0 is old, but it is widespread...

1.1.0 is past end of life, so we won't target that.
However, it's quite possible that the bug remains in 1.1.1 or even in the master branch, so still worth looking into.
That being said, it's quite difficult to figure out with so very little specifics, I'm sure you understand, so I wonder if you have some small piece of code that you know triggers this error when built with ub sanitizer?

You need to build instrumented openssl version like shown here: https://github.com/google/sanitizers/wiki/MemorySanitizerLibcxxHowTo

On OpenSSL 1.1.0 (default on Fedora 30), the function BIO_new_file has an unitialized read of a variable.

That is not true. There was OpenSSL-1.1.1b in Fedora 30 release and there is OpenSSL-1.1.1d in the Fedora 30 updates. There is no OpenSSL-1.1.0 in Fedora 30.

@t8m You're right, I must have read this wrong.
That would mean that this happens on th 1.1.1 version

I am closing this as you need fully instrumented builds to be able to use the memory sanitizer.


Cannot replicate example from tutorial containing dims()

Bug description
There is already an issue with documentation of dims()
I want to plot distributions as shown in example 2 in the tutorial. However, the example throws an error. I expect the tutorial example to run as it is without errors.
Steps to reproduce
Minimal (non)working example
using CairoMakie
CairoMakie.activate!(type="svg")
using AlgebraOfGraphics

x = [-pi .. 0, 0 .. pi]
y = [sin cos] # We use broadcasting semantics on `tuple.(x, y)`.
dims() * mapping(x, y, color=dims(1), linestyle=dims(2)) |> draw

Error reporting
ERROR: MethodError: no method matching *(::AlgebraOfGraphics.DimsSelector{0}, ::Layer)
Closest candidates are:
  *(::Any, ::Any, ::Any, ::Any...) at operators.jl:591
  *(::SpecialFunctions.SimplePoly, ::Any) at ~/.julia/packages/SpecialFunctions/hefUc/src/expint.jl:8
  *(::ChainRulesCore.AbstractThunk, ::Any) at ~/.julia/packages/ChainRulesCore/C73ay/src/tangent_arithmetic.jl:125
  ...

Version info
]st Makie CairoMakie AlgebraOfGraphics
  [cbdf2221] AlgebraOfGraphics v0.6.14
  [13f3f980] CairoMakie v0.10.3
  [ee78f7c6] Makie v0.19.3

Maybe I am looking at the wrong place.
The current docs are here https://aog.makie.org.
The ones I found on a search engine are https://docs.juliahub.com/AlgebraOfGraphics.
Can someone confirm whether this is the case?


Module 'undefined' not found.

Simplest test case I could find:
var db = require(
	'../../db'
	);

Given that the db.js is in fact in this location.

Fixed with https://github.com/medikoo/find-requires/commit/fe7a23a38971eb5d6b14cb6916e72353df303350


Cannot compile docs.rs

Not sure what's going on here, it works fine with cargo 1.42.0-nightly (9d32b7b01 2020-01-26), but using cg_cranelift breaks:
$ CHANNEL="release" ../rustc_codegen_cranelift/cargo.sh run
rustc_codegen_cranelift is build for rustc 1.42.0-nightly (cd1ef390e 2020-01-31) but the default rustc version is rustc 1.41.0 (5e1a79984 2020-01-27).
Using rustc 1.42.0-nightly (cd1ef390e 2020-01-31).
error[E0277]: expected a `std::ops::Fn<()>` closure, found `std::boxed::Box<(dyn std::ops::Fn() -> web::pool::Pool + std::marker::Send + std::marker::Sync + 'static)>`
   --> src/web/mod.rs:113:44
    |
113 |         let shared_resources = Self::chain(&pool_factory, rustdoc::SharedResourceHandler);
    |                                            ^^^^^^^^^^^^^ expected an `Fn<()>` closure, found `std::boxed::Box<(dyn std::ops::Fn() -> web::pool::Pool + std::marker::Send + std::marker::Sync + 'static)>`
    |
    = help: the trait `std::ops::Fn<()>` is not implemented for `std::boxed::Box<(dyn std::ops::Fn() -> web::pool::Pool + std::marker::Send + std::marker::Sync + 'static)>`
    = note: wrap the `std::boxed::Box<(dyn std::ops::Fn() -> web::pool::Pool + std::marker::Send + std::marker::Sync + 'static)>` in a closure with no arguments: `|| { /* code */ }
    = note: required for the cast to the object type `dyn std::ops::Fn() -> web::pool::Pool + std::marker::Send + std::marker::Sync`

error[E0277]: expected a `std::ops::Fn<()>` closure, found `std::boxed::Box<(dyn std::ops::Fn() -> web::pool::Pool + std::marker::Send + std::marker::Sync + 'static)>`
   --> src/web/mod.rs:114:40
    |
114 |         let router_chain = Self::chain(&pool_factory, routes.iron_router());
    |                                        ^^^^^^^^^^^^^ expected an `Fn<()>` closure, found `std::boxed::Box<(dyn std::ops::Fn() -> web::pool::Pool + std::marker::Send + std::marker::Sync + 'static)>`
    |
    = help: the trait `std::ops::Fn<()>` is not implemented for `std::boxed::Box<(dyn std::ops::Fn() -> web::pool::Pool + std::marker::Send + std::marker::Sync + 'static)>`
    = note: wrap the `std::boxed::Box<(dyn std::ops::Fn() -> web::pool::Pool + std::marker::Send + std::marker::Sync + 'static)>` in a closure with no arguments: `|| { /* code */ }
    = note: required for the cast to the object type `dyn std::ops::Fn() -> web::pool::Pool + std::marker::Send + std::marker::Sync`

error[E0277]: expected a `std::ops::Fn<()>` closure, found `std::boxed::Box<(dyn std::ops::Fn() -> web::pool::Pool + std::marker::Send + std::marker::Sync + 'static)>`
   --> src/web/mod.rs:184:29
    |
184 |                 Self::chain(&self.pool_factory, err).handle(req)
    |                             ^^^^^^^^^^^^^^^^^^ expected an `Fn<()>` closure, found `std::boxed::Box<(dyn std::ops::Fn() -> web::pool::Pool + std::marker::Send + std::marker::Sync + 'static)>`
    |
    = help: the trait `std::ops::Fn<()>` is not implemented for `std::boxed::Box<(dyn std::ops::Fn() -> web::pool::Pool + std::marker::Send + std::marker::Sync + 'static)>`
    = note: wrap the `std::boxed::Box<(dyn std::ops::Fn() -> web::pool::Pool + std::marker::Send + std::marker::Sync + 'static)>` in a closure with no arguments: `|| { /* code */ }
    = note: required for the cast to the object type `dyn std::ops::Fn() -> web::pool::Pool + std::marker::Send + std::marker::Sync`

When removing the Box<dyn FnOnce(...)> impl to workaround the missing unsized locals support I also had to remove the Box<dyn Fn(...)> and Box<dyn FnMut(...)> impls. As Fn and FnMut require an FnOnce impl.
Replacing the marked & with &* should fix this, I think. I am going to try this now.

It works with & replaced with &*. Because I don't have libmagic installed, linking failes though.
From 891db3f6f2dfdb5cfbab805931823afb7cc7b24a Mon Sep 17 00:00:00 2001
From: bjorn3<EMAIL_ADDRESS>Date: Sat, 1 Feb 2020 17:02:37 +0100
Subject: [PATCH] Workaround missing Fn for Box<Fn> impl

---
 src/web/mod.rs | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/web/mod.rs b/src/web/mod.rs
index 07190a9..0619530 100644
--- a/src/web/mod.rs
+++ b/src/web/mod.rs
@@ -110,8 +110,8 @@ impl CratesfyiHandler {
         let routes = routes::build_routes();
         let blacklisted_prefixes = routes.page_prefixes();

-        let shared_resources = Self::chain(&pool_factory, rustdoc::SharedResourceHandler);
-        let router_chain = Self::chain(&pool_factory, routes.iron_router());
+        let shared_resources = Self::chain(&*pool_factory, rustdoc::SharedResourceHandler);
+        let router_chain = Self::chain(&*pool_factory, routes.iron_router());
         let prefix = PathBuf::from(env::var("CRATESFYI_PREFIX").unwrap()).join("public_html");
         let static_handler = Static::new(prefix)
             .cache(Duration::from_secs(STATIC_FILE_CACHE_DURATION));
@@ -181,7 +181,7 @@ impl Handler for CratesfyiHandler {
                 }

-                Self::chain(&self.pool_factory, err).handle(req)
+                Self::chain(&*self.pool_factory, err).handle(req)
             })
     }
 }
--
2.21.0 (Apple Git-122)

Yeah libmagic is a known issue on our end. Thanks for checking and congrats that it works!