Rendering artifacts on https://modelviewer.dev/

Description
I'm seeing strange rendering artifacts - noise - with the Neil Armstrong suit model on https://modelviewer.dev/. See the attached video.
Live Demo
Directly on https://modelviewer.dev/.
Version

model-viewer: v3.5.0

Browser Affected

[x] Chrome, version: 127.0.6533.119
[ ] Edge
[ ] Firefox (no rendering artifacts there)
[ ] IE
[x] Safari, version: 17.6

OS

[ ] Android
[ ] iOS
[ ] Linux
[x] MacOS: version 14.6.1
[ ] Windows

AR

[ ] WebXR
[ ] SceneViewer
[ ] QuickLook

Also attaching my chrome://gpu info: about-gpu-2024-09-17T08-25-00-145Z.txt

This is a duplicate of https://github.com/google/model-viewer/issues/4773 - looks like Apple shipped a bad GPU driver for their old Intel-based Macs, since it's affecting both Chrome and Safari. Please help us rattle Apple's cage about this bug - there's not much we can do from here.

@AdaRosCanon FYI, in case you know a good way to escalate this regression.

Sorry about that @elalish. Let me close this ticket, and hopefully Apple addresses this soon.

Filing requests with Feedback Assistant is honestly the best way to escalate.


Changed pattern of URL to match appropriate URL's

I have changed pattern of the url validator to match correct URLs so that error #10533 would not occure again. As explained in 10533, URLs are passing the tests, but URLs are not correct, this issue was encountered dut to the pattern issues. I ran PHPUnit tests and now everything is passing as well as checked URL in variety of programs to check if URL is correct or not. Please review and let me know if I should re do it or accepted
Thank you!

Thank you for your effort.
Could you add a test case for original problem? (http://ya.1ru.!@.!$%^)

The Regexp is overcomplicated and must be simplified.

The regex itself should not allow UTF8 characters, utf8 is handled by converting the IDN name first and then checking against the pattern.

@cebe is right about it.

I propose fixing it by adding (:?$|/) to the end of existing regex.

@samdark That might help with escaping issues of not recognized symbols, byt what about patterns like https://www.google.de/search?q=yii+framework&ie=utf-8&oe=utf-8.&rls=org.mozilla:de:official&client=firefox-a&gws_rd=cr
How do you work them around? Trough regexp or trough some system in the code? I apologize in advance, I am still trying to figure out the code and dependencies in the whole system
I came up with something like this, taking in cosideration what you had and suggestions of @samdark
^(http|https)://(([A-Z0-9][A-Z0-9_-])(.[A-Z0-9][A-Z0-9_-])+)([./?\w\d=_-&%+:])*
Could you please provide feedback on that and I would update my PR as well as add test cases as requested above.
Thank you

[./?\w\d=_-&%+:]

I don't like this part. All we need to do - to stop matching domain name part of the string. We mustn't take care anything else in the URL.
The original problem was a domain http://ya.1ru.!@.!$%^, that is not a valid domain, for sure, but http://ya.1ru/!@.!$%^ might be a valid one.
I'm suggesting the following regexp:
/^(http|https):\/\/((?:[A-Z0-9][A-Z0-9_-]*)(?:\.[A-Z0-9][A-Z0-9_-]*)+)(?::?|\/|\?)/i
(?::?|\/|\?) means stop matching domain name on :, / or ? character.

I apologize for inconvenience. I totally misunderstood the problem. If I
need to cut out URL as only to domain name part then proposed fix is better
one, I thought that I need to check for possible folder names, variables or
"pretty" URLs. I will take that into consideration tomorrow and apply all
the fixed if that is still applicable.
Thank you for guidance!
Best Regards,
Maksud Aghayev
*Maksud Aghayev *| Full LAMP stack web application developer/PHP Web
Developer
Linkedin: https://www.linkedin.com/in/maksudaghayev
https://www.linkedin.com/in/maksudaghayev
On Mon, Jan 18, 2016 at 11:03 PM, Dmitry Naumenko<EMAIL_ADDRESS>wrote:

[./?\w\d=_-&%+:]
I don't like this part. All we need to do - to stop matching domain name
part of the string. We mustn't take care anything else in the URL.
The original problem was a domain http://ya.1ru.!@.!$%^, that is not a
valid domain, for sure, but http://ya.1ru/!@.!$%^ might be a valid one.
I'm suggesting the following regexp:
/^(http|https)://((?:[A-Z0-9][A-Z0-9_-])(?:.[A-Z0-9][A-Z0-9_-])+)(?::?|/|?)/i
(?::?|/|?) means stop matching domain name on :, / or ? character.
—
Reply to this email directly or view it on GitHub
https://github.com/yiisoft/yii2/pull/10600#issuecomment-172759813.

Closed in favor or #10753


What are the difference to Chalk?

Hi,
can you briefly explain why there is kolorist? The chalk (https://github.com/chalk/chalk) project on this topic has been around for a very long time.

Chalk does a lot more then just adding colors to terminal output. It comes with a light built in template engine, color conversion pipeline and a bunch of other stuff that I feel are overkill for me. kolorist does only one thing: It just adds colors, nothing more, nothing less.
That difference comes to light if we compare package sizes and the number of dependencies that have to be fetched on install:

Package
Size
dependencies

chalk
20.4kB
5

kolorist
3.3kB
0

I'm currently in the process of making node docker containers lighter at work and there isn't one single piece that makes it large, it's rather more like a death by a thousand papercuts. Lib A adds 30kb unnecessary stuff (for me) here, another lib A adds 30kb there, and pretty soon you can shave of a few MBs of the container size.
If you don't mind the weight or share the same constraints that I have, you can just pick whatever project you prefer. In the end both give you colored terminal output.

Many Thanks,
for your detailed explanation.
You may have noticed by now, but in another case I'm following the same philosophy with the @leanupjs project.
I want to offer a complete technology stack for developing SPAs that has as few dependencies as possible and yet is fully functional.
I can only offer almost all frames in the same shape with a flat frame facade.
The topic is particularly important in sensitive organizations.

[ ] We'll replace Clark with Colonist. (https://github.com/leanupjs/leanup/issues/1350)

Thank you @marvinhagemeister,
for your detailed explanation.
Maybe you've already read it, but in another case, I'm following the same philosophy with the @leanupjs project.
I want to offer a complete technology stack for developing SPAs that uses as less dependencies as possible and yet is fully functional.
If at all necessary, I can use a small framework facade to provide the stack to all frameworks in the same form. (only needet for dev and build)
The topic is particularly important in sensitive organizations.
For example, I can implement fully automated dependency updates to counter emerging vulnerabilities.


RuntimeError: Directory './frontend/dist' does not exist

(streamdiffusion) C:\Users\ghj\StreamDiffusion\demo\realtime-txt2img\frontend>cd ..
(streamdiffusion) C:\Users\ghj\StreamDiffusion\demo\realtime-txt2img>python main.py
A matching Triton is not available, some optimizations will not be enabled.
Error caught was: No module named 'triton'
vae\diffusion_pytorch_model.safetensors not found
Loading pipeline components...:  86%|███████████████████████████████████████████████▏       | 6/7 [00:05<00:01,  1.38s/it]C:\Users\ghj\python\envs\streamdiffusion\lib\site-packages\transformers\models\clip\feature_extraction_clip.py:28: FutureWarning: The class CLIPFeatureExtractor is deprecated and will be removed in version 5 of Transformers. Please use CLIPImageProcessor instead.
warnings.warn(
Loading pipeline components...: 100%|███████████████████████████████████████████████████████| 7/7 [00:05<00:00,  1.18it/s]
C:\Users\ghj\python\envs\streamdiffusion\lib\site-packages\diffusers\loaders\lora.py:952: FutureWarning: fuse_text_encoder_lora is deprecated and will be removed in version 0.25. You are using an old version of LoRA backend. This will be deprecated in the next releases in favor of PEFT make sure to install the latest PEFT and transformers packages in the future.
deprecate("fuse_text_encoder_lora", "0.25", LORA_DEPRECATION_MESSAGE)
Traceback (most recent call last):
File "C:\Users\ghj\StreamDiffusion\demo\realtime-txt2img\main.py", line 158, in
Api(config).app,
File "C:\Users\ghj\StreamDiffusion\demo\realtime-txt2img\main.py", line 90, in init
self.app.mount("/", StaticFiles(directory="./frontend/dist", html=True), name="public")
File "C:\Users\ghj\python\envs\streamdiffusion\lib\site-packages\starlette\staticfiles.py", line 59, in init
raise RuntimeError(f"Directory '{directory}' does not exist")
RuntimeError: Directory './frontend/dist' does not exist
This problem occurred while executing the main.py file in the demo folder

Please set up your Node.js environment.
https://github.com/cumulo-autumn/StreamDiffusion/tree/main/examples#:~:text=the capture area.-,You need to install extra dependencies for this script as follows%3A,-pip install -r


Method selectPage in bootstraptable has bug when executed the current page element is not actived

                                <button class="btn btn-default" type="button"
                                    id="btnTableSelectPageNumber">

                                    Goto
                                </button>

                                <input id="SelectPageNumber" type="text" placeholder="please input the page number">

SearchDesignPatent.btnTableSelectPageNumber().click(function() {
var selectPageNumber = $('#SelectPageNumber').val();
if(window.console){
console.log(selectPageNumber);
}
SearchDesignPatent.tableSearchDesignPatent().bootstrapTable('selectPage',selectPageNumber);
$('.page-number').each(function(){
if(window.console){
console.log($(this).text());
}
if($(this).text() == selectPageNumber){
$(this).attr("class","page-number active");
}
});
});
the above sample code can fix the bug.

No idea what this was in regards to—I don't recall ever seeing this issue originally. Closing out now. Please feel free to open a new issue if a bug still exists, but please include a fully reduced test case.

you should open an issue in bootstrapTable repository 👍


Isolate.run does not complete correctly when using pause-isolates-in-exit

This code spawns an isolate with Isolate.run that does 5 seconds of nothing and then returns. The main isolate waits for this work and prints "Done" when it's complete.
import 'dart:isolate';

Future<void> main() async {
  print('Running isolate...');
  await Isolate.run(_compute);
  print('Done');
}

Future<void> _compute() async {
  print('Waiting 5s...');
  await Future<void>.delayed(Duration(seconds: 5));
  print('Done waiting!');

Waiting 5s...
Done waiting!
Done

If you run with --pause-isolates-on-exit, the isolate is paused when it completes (as expected), but trying to resume it does not seem to work - the main isolate never resumes ("Done" is never printed and the application never terminates).
I can repro this both with VS Code and DevTools. Using DevTools, you can run:
dart --observe --pause-isolates-on-exit run foo.dart

Then click on the link to open DevTools and wait for the program to pause. Switch to the RemoveRunner isolate and click Resume. This should resume the isolate and let it finish exiting, which should allow the main isolate to continue and print "Done", but it doesn't appear to.
Same behaviour in VS Code, where I captured this VM Service log:
// `print` output
<== {"jsonrpc":"2.0","method":"streamNotify","params":{"streamId":"Stdout","event":{"type":"Event","kind":"WriteEvent","isolate":{"type":"@Isolate","id":"isolates/242898339736375","name":"_RemoteRunner._remoteExecute","number":"242898339736375","isSystemIsolate":false,"isolateGroupId":"isolateGroups/14793226976164994877"},"timestamp":1675080426747,"bytes":"RG9uZSB3YWl0aW5nIQ=="}}}
<== {"jsonrpc":"2.0","method":"streamNotify","params":{"streamId":"Stdout","event":{"type":"Event","kind":"WriteEvent","isolate":{"type":"@Isolate","id":"isolates/242898339736375","name":"_RemoteRunner._remoteExecute","number":"242898339736375","isSystemIsolate":false,"isolateGroupId":"isolateGroups/14793226976164994877"},"timestamp":1675080426747,"bytes":"Cg=="}}}

// Isolate pauses on exit
<== {"jsonrpc":"2.0","method":"streamNotify","params":{"streamId":"Debug","event":{"type":"Event","kind":"PauseExit","isolate":{"type":"@Isolate","id":"isolates/242898339736375","name":"_RemoteRunner._remoteExecute","number":"242898339736375","isSystemIsolate":false,"isolateGroupId":"isolateGroups/14793226976164994877"},"timestamp":1675080426747}}}

// Attempt to resume the isolate
==> {"jsonrpc":"2.0","id":"55","method":"resume","params":{"isolateId":"isolates/242898339736375"}}
// Get success
<== {"jsonrpc":"2.0","result":{"type":"Success"},"id":"55"}

// Note: VS Code is still asynchronously trying to fetch the stack because we paused - I don't think that is related
==> {"jsonrpc":"2.0","id":"56","method":"getStack","params":{"isolateId":"isolates/242898339736375","limit":1}}
<== {"jsonrpc":"2.0","result":{"type":"Stack","frames":[],"truncated":false,"messages":[]},"id":"56"}
==> {"jsonrpc":"2.0","id":"57","method":"getStack","params":{"isolateId":"isolates/242898339736375","limit":19}}
<== {"jsonrpc":"2.0","result":{"type":"Stack","frames":[],"truncated":false,"messages":[]},"id":"57"}

// No further output

@bkonyi any ideas?

@aam might be able to help out here.

Not sure if this is a library-isolate issue as the program runs just fine, it seems more like a vmservice issue.

thanks for the report @DanTup . https://dart-review.git.corp.google.com/c/sdk/+/280044 aims at fixing the problem.

Works as expected now, thank you!


Update syn dependency to 2.0

We should update the syn dependency to 2.0 now that it has been released.

This was trivial after the simplification in #30, so I added a commit to do that.

Scratch that - syn 2.0 requires edition 2021 so MSRV would have to move up.

Scratch that - syn 2.0 requires edition 2021 so MSRV would have to move up.

 Thanks for checking.

I think bumping MSRV for this is worth doing. At present this causes anyone who uses test-log to compile syn twice.


Fix Markdown link checker GitHub Action

What type of suggestions?
Wrong Information
What page is concerned?
No response
What is the issue?
Fix Markdown links checker GitHub Action as it was created for Markdown files, and now it's not working on MDX. It may be just about adjusting the actions to take those in consideration, but we may have to change it completely if the tool we use doesn't support the code in MDX files or cannot be configured.
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Disabling it until it's fixed.

Need to fix all the issues before enabling them again.


Support identical input and output (v2)

In this version, whenever we create an output that has already been specified as an input, we unlink the file before recreating it.
As we already have a memory map to the input, deleting it from the filesystem does not change that map. And after creating the output (especially if it has a different size from the input), the original input file is unusable anyway.
There is only one difficulty: the join command. Here, we specifically want to extend an input, and therefore we cannot remove it. The solution is to pretend that it isn't an input (by calling io_unregsiter) and then opening it with create_cfl.
Related changes are a new file_type function which returns an enum to get the file_type from its name. Additionally, io_unregister now removes all IOs of that name from the list.
Closes #60 .

ok, looks good. Just some minor comments:

Can we add a  prefix to the file type enum constants? RA is not a constant I like to have defined by a header.
Please remove empty new lines before the closing brackets.

and a failing unlink should probably not yield an error about failing to create a file.

Can we add a  prefix to the file type enum constants? RA is not a constant I like to have defined by a header.

Oh, yeah. Good point. Is FILE_TYPE_RA and FILE_TYPE_CFL better?

remove empty new lines before the closing brackets.

I hope I found them all.

and a failing unlink should probably not yield an error about failing to create a file.

These now say "Failed to unlink file: %s\n"


Added a phpcs.xml.dist file

Description
I have added a phpcs.xml.dist file for codesniffer.
This dist file works in the same logic as phpunit.xml.dist. Developers can add their own custom one.
I don't know exactly the version that codesniffer package added this feature. Going through the releases I think it is on 2.5.0. So it might be better if we wait for this #129 to be merged first.
Motivation and context
Adding an XML with rules is more friendly rather than running through the command line the rules that you need.
How has this been tested?
I have run composer update and executed the commands of composer.
Types of changes
What types of changes does your code introduce? Put an x in all the boxes that apply:

[x] New feature (non-breaking change which adds functionality)

Checklist:

[x] I have read the CONTRIBUTING document.
[x] My pull request addresses exactly one patch/feature.
[x] I have created a branch for this patch/feature.
[x] Each individual commit in the pull request is meaningful.
[x] I have added tests to cover my changes.
[x] If my change requires a change to the documentation, I have updated it accordingly.

If you're unsure about any of these, don't hesitate to ask. We're here to help!

I forgot to add the link with the 2.5.0 release changelog of codesniffer
here it is https://github.com/squizlabs/PHP_CodeSniffer/releases/tag/2.5.0

Cheers @gmponos 👍


Analyzer rejects implementing alias that expands to type.

typedef A<T> = T;
extension type EIAliasInt(int _) implements A<int> {}

Both CFE and analyzer rejects this extension type, saying that you can't implement an alias that expands to a type variable. (Checked in DartPad, master branch.))
It should be accepted.
The behavior seems (based on the error message) like an incorrect interpretation of the rule:

A compile-time error occurs if an extension type has a non-extension superinterface whose transitive alias expansion is a type variable, a deferred type, any top type (including dynamic and void), the type Null, any function type, the type Function, any record type, the type Record, or any type of the form T? or FutureOr<T> for any type T.

The "transitive alias expansion is a type variable" should be applied to the actual superinterface type term, A<int>, not to the alias declaration A<T>.
The places where you can't use an alias like A are places where the alias is not used as a type, but as a scope, and we want to know what the scope is statically.
The analyzer says:

error
line 2 • A type alias that expands to a type parameter can't be implemented. (view docs)
Try specifying a class or mixin, or removing the list.

The linked diagnostic explanation does suggest that the behavior is intentional, and lists class C implements A<Object> {} as something that should err.
@eernstg Am I missing something here? Did we disallow implements A<Object> even if it's supposedly equivalent to implements Object?

We do actually have this error:

A compile-time error occurs if D expands to a type variable, and T uses D as a class.

where D is a type alias declaration named F, and T is a type of the form F<T1 .. Tk>.
This does kick in when A<Object> is used as a superinterface, e.g., in the implements clause of a class. I agree that this is overkill: We wanted to prevent class C<X> implements X {}, but this also prevents something that just means class C implements Object {} and similar benign things.
The rule would have to be somewhat more involved in order to handle cases like this:
typedef F<X> = X;
typedef F2<X, Y> = X;

class C<X> implements F2<F<F<F<X>>>, F<F<F<F<Object>>>>> {} // Error.
class C<X> implements F2<F<F<F<Object>>>, F<F<F<F<X>>>>> {} // OK.

So we're being a little bit lazy, but the question is whether we want to handle the extra machinery which is needed (whatever that is) in order to allow these "dangerous" type aliases to be used as superinterfaces and as the class which is being instantiated in instance creations, etc.
Do we prevent any useful idioms by keeping it simple?

We might be able to simplify the notion of 'being used as a class', because we already have the other rule that you mentioned:

A compile-time error occurs if an extension type has a non-extension superinterface whose transitive alias expansion is a type variable ..

However, the rules that we have for classes, mixins, and enums is a bit simpler, for example:

It is a compile-time error if an element in the type list of the implements clause of a class is
... a type alias that does not denote a class

So we might want to talk about the transitive alias expansion in all these cases (not just extension types) and then take superinterfaces out of the definition of 'use as a class'.

My personal preference is that we should never talk about a type alias, only about is expansion, except where we define said expansion, and where we say which static members you can access through the type alias (where we are really aliasing a namespace as well, not a type).
There might be reasonable reasons for what we're doing here, even if it's only making our own job easier. Probably only that.
I like to think of the static part of compilation as being somewhat staged, and being able to rely on the prior stages not having compile-time errors.
That means checking that, fx, a class declaration parses before introducing any types for it, and checking that the type hierarchy is well-defined (super-class/mixin/interfaces exist and are valid declarations, and it have no cycles) before introducing subtyping. Before that, the subtyping relation simply doesn't exist, because it requires all types to exist first, and then it requires that the types can be ordered.
If we require type aliases to be expanded when we check whether the superinterface exists, we migth so before we have introduced subtyping, which means we cannot check any bounds at that point. We're not doing real type alias expansion, because that requires primitives that do not exist yet. All we can do at this point is resolve identifiers to declarations.
That should be enough. We can detect type-alias cycles using just that, and we can introduce all the types for all type-introducing-declarations, even if we can't say which ones of them are well-bounded yet (maybe not even which ones have the correct number of type arguments).
We should be able to do symbolic expansion of type aliases, without checking any bounds, to figure out that A<Object> refers to the declaration Object, A<List<int>> refers to the declaration List (never-mind the rest of the type arguments for now), and A<T> refers to the type variable T, and is therefore not a valid implements clause entry.
We'll only need to find the first head-term that is not an alias, the rest will be dealt with in later phases. That is "does this type alias instantiation refer to a declaration, and if so, which one?", and nothing more.
(We probably also need to define "instantiate to bounds" at this time, otherwise we can't expand type raw alias references. I believe that's possible too.)
But that does require defining a separate alias expansion algorithm, just for this.
(Not sure disallowing type aliases which expand to one of their own type variables helps, though, because we still do need to expand the rest to see which declaration they point to. But we might be able to reuse the test for "which declaration does this alias" that we also use for accessing static members through an alias.)
All in all, I think this restriction is unnecessary, but I can't say whether it does make something easier for implemnters.
It also feels inconsistent:
typedef A<T> = T;
typedef AC = A<C>;
typedef AD = A<D>;

class C {}
class C0 implements A<C> {} // Error, A<C> is not a valid superinterface.
class C1 implements AC {} // No problem AC, alias for A<C>, is perfectly fine.
class D implements AD {} // Whoa, cyclic reference!

It's not the type that is the problem. It's apparently also not the ability to expand type aliases that is a problem, because we do that anyway for D.
So, the rule doesn't seem to make everything magically easier, it's not needed to disallow implementing a type variable, just expand the alias and see that the result is a type variable, then complain like we would for a directly written type variable.

Note that there is an easy workaround, we can just introduce one extra layer of type aliasing:
// Example 1

typedef A<T> = T; // Cannot be used as a class.
typedef Aint = A<int>; // Add one layer, _can_ be used as a class.

extension type EIAliasInt(int _) implements Aint {} // OK.

// Example 2

typedef F<X> = X;
typedef F2<X, Y> = X;

typedef F2a<X> = F2<F<F<F<X>>>, F<F<F<F<Object>>>>>; // Cannot be used as a class.
typedef F2b<X> = F2<F<F<F<Object>>>, F<F<F<F<X>>>>>; // Can be used as a class.

class C<X> implements F2a<X> {} // Error, `F2a` cannot be used as a class.
class C2<X> implements F2b<X> {} // OK.

// Example 3 -- essentially already uses the extra layer of type aliases.

typedef A<T> = T; // Cannot be used as a class.
typedef AC = A<C>; // Alias for `C`.
typedef AD = A<D>; // Alias for `D`.

class C {}
class C0 implements A<C> {} // Error, just can't use `A` directly.
class C1 implements AC {} // OK.
class D implements AD {} // Error, cannot implement itself.

This would serve as an argument in favor of keeping the rules as they are today: No expressive power is lost by coloring each type alias as "can be used as a class" or "cannot be used as a class", and then proceeding to report an error for every occurrence of a "cannot" type alias which is used as a class.
Note that "being used as a class" applies to other constructs as well, not just superinterfaces: It is used with static member lookups and it is used with instance creation expressions. I do think that the notion of "being used as a class" is reasonably intuitive, which might be an argument in favor of using that concept (say, in error messages).
In summary, you're right that the currently specified approach is more restrictive than it must be. I'm just not convinced that this amount of overkill creates any real problems.

This would serve as an argument in favor of keeping the rules as they are today

Arguably, it's also an argument in favor of removing the unnecessary restriction, since it doesn't actually restrict anything.
We just don't have to do so eagerly, since there is a workaround.

Arguably, it's also an argument in favor of removing the unnecessary restriction, since it doesn't actually restrict anything.

I don't understand? The restriction is that no parameterized type F<T1 .. Tk> where F is a type alias that expands to a type variable can be used as a superinterface. I do think that restricts something (and even more than strictly necessary).
The rule about extension types that talks about the transitive expansion of type aliases is special (we don't have the same kind of rule for classes, mixins, etc.), so we'd need to go over all relevant constructs and ensure that they get the protection they need. This is true for instance creations and redirecting constructors as well.

I do think that restricts something

It's a syntactic restriction, which prevents you from writing a thing in a specific way,  without actually preventing you from achieving the same semantics in a different way.
It doesn't prevent you from doing anything, it just restricts how you can write it.
That can be fine in some cases, where a particular way of working things can be confusing, but this is not one of those cases. So it's just an unnecessary restriction, with no real benefit.
(That's assuming we still prevent you from actually implementing a type variable, if an aliased type expands to it.)


Button shortcuts no longer "press" the Button.

Button shortcuts were treated as generic input events on buttons. This means that to activate a button shortcut you had to press and release.
This logic is removed and now shortcuts always activate on press.
This makes the editor feel more responsive and solves problems related to this behavior.

Fixes #45033 and possibly others.

This basically reverts (or more like supersedes) #71328
You forgot to update the docs btw.

Also fixes #40464

@KoBeWi I restored shortcut feedback (works a little different now).

Seems good to me.

Shortcut feedback is kept, but it is now a timed event after press.

I foresee potential requests to make the timer configurable... but we can see first if we can get away with a reasonable default. I guess we can also add a project setting for it eventually if there's demand.

@akien-mga made the timer configurable as a project setting

I think the default value 0.5 is too long and doesn't look good. Something like 0.2 is better. The button is highlighted for similar time as the shortcut is normally pressed.

@KoBeWi changed!

CC @Spartan322 as you had interest in disabling the shortcut feedback (which this still preserves but refactors).
The last question for me is this one:

Which BTW raises the question of whether folks really want to configure this on a per-button basis, or if a global toggle for shortcut feedback and duration wouldn't be better.

Ah yes, another one-element section lol

a global toggle for shortcut feedback and duration wouldn't be better.

It can be easily achieved by setting the highlight time to 0.

Ah yes, another one-element section lol

Maybe we can move to gui/timers/.

@KoBeWi done changes!

Thanks!


[cognitive language] Enable AAD tests

Packages impacted by this PR
Issues associated with this PR
Describe the problem that is addressed by this PR
Add AAD tests for the new API
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Are there test cases added in this PR? (If not, why?)
Provide a list of related PRs (if any)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists

[ ] Added impacted package name to the issue description
[ ] Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
[ ] Added a changelog (if necessary)

API change check
API changes are not detected in this pull request.

Let's create an issue to track unskipping them and bring the issue to the service team's attention.


Find version in container instead of using a REVISIONS file

Hi there,
thanks a lot for your awesome article on http://devblog.springest.com/deploy-notifications-to-newrelic-appsignal-and-slack-with-elastic-beanstalk/
The only thing that bothered me a bit, was the fact that you should commit the current version to a REVISIONS file, which I found not optimal.
So I changed the script a bit, to support a fallback mechamism when there is no REVISIONS file; it will look inside the server container for the deploy file, which holds the current deployed version number (aka git commit hash).
Please consider this pull request, as it will remain compatible with your blog post.
Thanks again!
Kind regards,
Stijn

Nice @stijnster, thanks and sorry for the super late reply!

w00t


Refactor proxy and add IP argument

Branches off of #871 and solves #874
I've introduced a Proxy struct but I'm not sure if I like it. Very open to some pointers here, I'm doing a lot of clones because of that pesky move and something about Fn vs FnOnce which has confused me quite a bit.
Usage:

$ wrangler proxy
Listening on http://localhost:8000

worker preview sends origin requests to https://example.com

$ wrangler proxy -u http://example.com
Listening on http://localhost:8000

worker preview sends origin requests to http://example.com

$ wrangler proxy -h averyharnish.com
Listening on http://localhost:8000

worker preview sends origin requests to https://averyharnish.com

$ wrangler proxy -i <IP_ADDRESS> -p 8080
Listening on http://<IP_ADDRESS>:8080

worker preview sends origin requests to https://example.com

closing this in favor of an async refactor


cmd/compile: simplify multiplication and division of Abs()

What version of Go are you using (go version)?

$ go version
go version go1.16.8 linux/amd64

Does this issue reproduce with the latest release?
Yes. See https://go.godbolt.org/z/1Gq4bPPnd for assembly output.
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/jacob/.cache/go-build"
GOENV="/home/jacob/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/home/jacob/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/jacob/go"
GOPRIVATE=""
GOPROXY="direct"
GOROOT="/usr/lib/golang"
GOSUMDB="off"
GOTMPDIR=""
GOTOOLDIR="/usr/lib/golang/pkg/tool/linux_amd64"
GOVCS=""
GOVERSION="go1.16.8"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/dev/null"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build3228184624=/tmp/go-build -gno-record-gcc-switches"

What did you do?

I noticed that the compile doesn't optimize calls to math.Abs() or cmplx.Abs() to strip out unnecessary calls to those functions when multiplying them or dividing them. According to the absolute value rules, |A * B| = |A| * |B| and |A / B| = |A| / |B|, meaning that the compiler should be able to work the right two calls to either math.Abs() or cmplx.Abs() into a single call by moving the multiplication or division inside the call instead.
This means that the first block of assembly can be simplified to the one after.
        MOVQ    X0, AX
        BTRQ    $63, AX
        MOVQ    AX, X0
        MOVQ    X1, AX
        BTRQ    $63, AX
        MOVQ    AX, X1
        MULSD   X1, X0

        MULSD   X1, X0
        MOVQ    X0, AX
        BTRQ    $63, AX
        MOVQ    AX, X0

The above assembly was taken from the multiplication examples below:
func AbsMult(x, y float64) float64 {
    return math.Abs(x) * math.Abs(y)
}

func AbsMultSimple(x, y float64) float64 {
    return math.Abs(x * y)
}

func AbsDiv(x, y float64) float64 {
    return math.Abs(x) / math.Abs(y)
}

func AbsDivSimple(x, y float64) float64 {
    return math.Abs(x / y)
}

This should also apply to complex numbers. It is important to note that it is only for multiplication and division, not addition and subtraction.
What did you expect to see?
I expected the compiler to strip out the duplicated calls to math.Abs(). Thus getting the following assembly for the AbsMult function below.
        MULSD   X1, X0
        MOVQ    X0, AX
        BTRQ    $63, AX
        MOVQ    AX, X0

What did you see instead?
The compiler did not strip it out:
        MOVQ    X0, AX
        BTRQ    $63, AX
        MOVQ    AX, X0
        MOVQ    X1, AX
        BTRQ    $63, AX
        MOVQ    AX, X1
        MULSD   X1, X0

For more info, see: https://github.com/dominikh/go-tools/issues/1135

The optimization may be correct, but is it worthwhile to hardcode it in the compiler? You can just write math.Abs(x * y), after all.
I can understand special-casing arithmetic simplifications for built-in operators (like + or *), but I'm not sure about math functions.

Indeed. That is a good question that also was brought up in the issue that I opened for staticcheck. I figured that it was better to open an issue here and let you all decide on that :)


Fix -Wnon-virtual-dtor warnings.

Example of the warning:
./core/script_language.h:198:7: warning: 'class ScriptCodeCompletionCache' has virtual functions and accessible non-virtual destructor [-Wnon-virtual-dtor]

Thanks!

Cherry-picked for 3.1.1.


Crashing on CreateMove hook

I can inject in the lobby and be fine but once I go into a game and a few seconds pass csgo will crash.
It has also crashed when I try to open console after injecting.

Indexes totally outdated

I updated the indexes but now I have arrived with another problem.

Thank you


12/18/2018 19:50 : Create Pull Request for branch master -> prTesting1_2018121819

OPS Build status updates of commit 234ca59:
:clock10: Preparing: average preparing time is 42 sec(s)

OPS Build status updates of commit 234ca59:
:clock10: Incremental building: average incremental building time is 14 sec(s)

OPS Build status updates of commit 234ca59:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details
Dependent Files

split/updateTestCon1.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


auth.acme-dns.io has become unavailable

auth.acme-dns.io has become unavailable in the last day.
Has this service been decommissioned or is it a fault ?
Thanks

This was fixed during the same day. It's a testing instance after all, so for production you should host a personal instance :)


Add Ignition Utils as dependency from v4

The new Ignition package has minimal dependencies and provides utility functions that could be useful to Ignition Physics, like the warning suppression macros.
https://github.com/ignitionrobotics/ign-utils/
The dependency needs to be added on CI for all 3 platforms before it can be used here.

Closed by #213

For completeness, I think it would be good to explicitly add the dependency in:

[ ] https://github.com/ignition-release/ign-physics4-release
[ ] https://github.com/osrf/homebrew-simulation/blob/master/Formula/ignition-physics4.rb
[ ] https://github.com/ignition-tooling/release-tools/blob/master/jenkins-scripts/docker/ign_physics-compilation.bash

[ ]  https://github.com/ignition-release/ign-physics4-release
[ ]  https://github.com/osrf/homebrew-simulation/blob/master/Formula/ignition-physics4.rb

it is getting ignition-utils transitively from sdformat11, so I think it's working in several cases, but I'll update these for completeness (https://github.com/osrf/homebrew-simulation/pull/1335)

[ ]  https://github.com/ignition-tooling/release-tools/blob/master/jenkins-scripts/docker/ign_physics-compilation.bash

I'm not sure why we are both building these from source in these docker scripts and using the nightly debs. Shouldn't the nightly debs be enough?

[ ]   https://github.com/ignition-release/ign-physics4-release

https://github.com/ignition-release/ign-physics4-release/pull/3

Shouldn't the nightly debs be enough?

Argh yeah I have it on my list to address this but I never get to make time for it. A while back we decided with @j-rivero that GitHub actions would use nightlies and Jenkins would install dependencies from source. But now that release-tools is using packages.apt, it's also picking up the nightlies. I think we should filter out our Ignition / SDFormat dependencies for release-tools CI. The fix itself is probably a 1 liner, but we need to make sure it doesn't break anything.


[ISV-4109] Introduction of Hadolint and Ansible-lint.

Preparation for the introduction of Pymarkdownlnt.

Integration tests successfully ran, ready for review.

@Allda @BorekZnovustvoritel Are the folder name changes necessary for the linter, can't they be ignored? There are downstream consumers (and documentation) and changing the folder names make implementing failover/fallback logic to support both folder structures less the ideal.

The issue I have encountered with the linter is that if the role dir does contain the - character, then it does not apply all the role-related rules to the directory even though it is located in the ansible/roles directory.
From my testing, if we were to rollback the changes, the linter would mark the code as passing and would be less enforcing. I don't think there is a way to keep the role name and have the linter recognize the directory as a role without failing. The related linter rule can be found here.
If the changes are breaking and have to be rolled back, let me know. I did not expect this change to propagate outside of this repository.


Fix Step 3a of TC_xxxCONC_1_1

Description
Fixes test step 3a in all Concentration Measurement 1.1 tests.
Before it was checking for a non-compliant state.
Now, it checks for the statement in the Test Plan:

At least one of bit 0 and bit 1 SHALL be 1.

Links
Fixes #28838

@manjunath-grl it would be great if you could review, I think this is reverting your change!


Redesign Deadman Checks

Currently the user flow for creating a deadman is the same as that of a check, however I this is not the behavior that we want.
Creating a deadman is a fundamentally different task and the user should be presented with the option earlier on in the process.
Ideally the flow should be the series selection flow without the user ever having to select an aggregate.

Link https://github.com/influxdata/influxdb/issues/14958


How much the loss can be convergence？

I have trained the vovnet version for 18 epcochs, but the total loss is still about 12.

Sorry, I cannot find the log of polarformer-vovnet. But the log of polarformer-r101-w/o-bev_aug indicates that the loss converges at around 3.8 after 24 epochs, and I remember polarformer-vovnet converges much faster and ends up with a lower value than polarformer-r101, maybe around 3 or below 3. (The vovnet backbone I use was pretrained on nuScenes trainval set #8 ,  so polarformer-vovnet is supposed to converge faster.)
Maybe you can share your training log here and I will check if there is anything wrong. : )


Doesn't return correct response on RN 0.60

I am updating my project to RN 0.60 and have some issue using react-native-public-ip. The response text value returned is no longer the IP address but a text [object Blob]

Sorry it was an issue on my side, our code used
global.XMLHttpRequest = global.originalXMLHttpRequest
    ? global.originalXMLHttpRequest
    : global.XMLHttpRequest;
  global.FormData = global.originalFormData
    ? global.originalFormData
    : global.FormData;


Nav item shouldn't be "Active" when you open it but don't navigate to the page

Bug🐛: Nav item shouldn't be "Active" when you open it but don't navigate to the page
Page: https://next.carbondesignsystem.com/
Suggestion: I'm on the homepage, opened the "Designing" section and it set the active styles, it should only open the section, and set active when you are actually on that page. The headings that aren't pages shouldn't ever have the active state with the blue border to the left. See current Carbon website nav for example.

Originally posted by @alisonjoseph in https://github.com/carbon-design-system/carbon-platform/discussions/1268#discussioncomment-3663385

Hey team! Please add your planning poker estimate with Zenhub @andreancardona @francinelucca @jdharvey-ibm


Pin blinker to version <1.8 as fix for #329.

As PyleniumIO relies on selenium-wire (which is no longer alive/maintained) and this project again uses blinker one would like to pin this "stack" to a working version.
selenium-wirein it's final version uses a private method of blinker which has been removed in the 1.8 release. As selenium-wire cannot be changed the only way is to pin blinker.

You've raised really good points! It's probably best to remove selenium-wire as a dependency. If someone wants to add similar functionality, they are welcome to!

Yes I agree. Removing the selenium-wire dependency would be the cleanest solution.

I'm closing this as we've now removed selenium-wire completely. This will be out in v1.21


Assistance Required in Creating Reference Samples for SingleR

Hello,
I am seeking assistance in creating reference samples for SingleR. I aim to annotate my data's cells using annotation extracted from studies with previously reported annotation details. However, I am currently unable to restructure the reference data as per the instructions provided in the tutorials.
I have been utilizing the following datasets: GSE166648_snRNA_metadata.csv.gz, GSE166648_snRNA_normdata.csv.gz, and GSE166648_snRNA_unnormdata.csv.gz, available at NCBI GEO.
My approach has been as follows:

Loading Seurat data
Making SummarizedExperiment
Conversion from Rda to h5ad
Following the tutorial
Could you please guide me on how to properly format the data to create a reference for SingleR?

It is my results

Do you mean add an existing annotation into the ref?

Do you mean you want to add an existing annotation into the reference or meet an error when using your own reference?

Hello,
I am interested in applying annotation information from other published studies to my dataset using SingleR. My goal is to leverage the annotation details reported in other research to enhance the annotations of my own cell data. However, I am facing difficulties in matching the format of my data with the reference format suggested in the SingleR tutorials.
The process I've been following involves simply loading datasets from previous studies and converting Rda files into h5ad format. Yet, it appears that this approach does not align with the reference format required by SingleR.
Could you provide guidance or a methodology on how to appropriately apply external annotation information to my dataset using SingleR? Specifically, I'm looking for a way to format the data correctly or any additional steps I might be missing to integrate the annotation information effectively.
Thank you for your help.


Fix operator precedence involving or and addition

The addition expression was not evaluated when first operand is truthy. ie:
(1 or 0) + 1 == 2
1 or 0 + 1 == 1

coolio!  We should look into adding some linting -- I bet something could have warned us! (it is not our fault! ;))


NOISSUE - Fix doc for ENV vars in README

Signed-off-by: Drasko DRASKOVIC<EMAIL_ADDRESS>

Codecov Report

Merging #920 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #920   +/-   ##
=======================================
  Coverage   83.61%   83.61%
=======================================
  Files          75       75
  Lines        5357     5357
=======================================
  Hits         4479     4479
  Misses        611      611
  Partials      267      267

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da4fc62...e341c19. Read the comment docs.


Document rpc node requirements

As of version 1.13.0 of the kilt-node implementation, I'm not able to connect to a KILT rpc node via WS using polkadot-api.
The error I get is
RpcError: invalid type: sequence, expected a (both 0x-prefixed or not) hex string or byte array containing 32 bytes at line 1 column 0

so presumably we're dealing with an exception on the side of the node implementation (seems to be happening when calling the method chainHead_v1_unpin).
Connections using smoldot seem to be working for the most part, so I suspect this is due to issues in or incompatibilities with the rpc node implementation.
Are there known requirements on minimum polkadot-sdk version ranges etc.? If so, it seems like a good idea to mention that in the docs.
Steps to reproduce
Try running the following script, you should get an error raised from within createClient after 30-60s.
My node version: v20.13.1
import { createClient } from "polkadot-api";
import { WebSocketProvider } from "polkadot-api/ws-provider/node";

// Connect to kilt spiritnet.
const client = createClient(WebSocketProvider("wss://kilt-rpc.dwellir.com"));

// after subscribing and waiting for ~30s, I'm getting the error
client.finalizedBlock$.subscribe((finalizedBlock) =>
  console.log(finalizedBlock.number, finalizedBlock.hash)
);

The error I get is
RpcError: invalid type: sequence, expected a (both 0x-prefixed or not) hex string or byte array containing 32 bytes at line 1 column 0

so presumably we're dealing with an exception on the side of the node implementation (seems to be happening when calling the method chainHead_v1_unpin).

This is because your node implements a pretty old version of the -now stable- chainSpec group of functions of the JSON-RPC spec.

Are there known requirements on minimum polkadot-sdk version ranges etc.? If so, it seems like a good idea to mention that in the docs.

Really good point. We will as soon as we find out.
@jsdw @lexnv @ niklasad1 do you happen to know which version of the polkadot-sdk node is the one that came after this fix (I think that release is the one that we should use as the minimum polkadot-sdk version node).
I'm guessing that it must be the release of Polkadot v1.11.0, but I'm not certain.

I was assuming something like that, yeah.
Spiritnet should be on 1.7.0 soon, it will be a little while until we're updated to 1.11.0 though. We'll try to work with the light client until then. Unfortunately the omni-node is not yet ready to be used by us, because it currently does not support u64 block numbers, which we use on kilt.
If you find ways to support older rpc specs as well, that would make things easier for us of course.

After checking the node implementation a bit, I'm quite certain that a node built with Polkadot equal or after v1.8.0 shouldn't have any issues. This is the relevant PR. Before that many issues happened, but after v1.8.0 everything should be fine.

After checking the node implementation a bit, I'm quite certain that a node built with Polkadot equal or after v1.8.0 shouldn't have any issues. This is the relevant PR. Before that many issues happened, but after v1.8.0 everything should be fine.

There were other important bugs that were fixed afterwords, like the one that I linked in my comment... What makes you think that v1.8.0 is the correct target?

If you find ways to support older rpc specs as well, that would make things easier for us of course.

There is a way, actually, which is to create a JsonRpcProvider enhancer that handles the upstream issues. I can definitely hook you up. I will try to find some time this week to give you an enhancer that solves these issues.

I have been thinking a lot about this and I now realize that we can't release v1 until we don't have a proper solution to this issue.
Therefore, this is what we are going to do do: we will add a new package (possibly named which will provide different enhancers for different versions of the polkadot-sdk node which either have bugs or are not yet using the stable version of the JSON-RPC spec.
What this means is that if you are using a node build with Polkadot equal or after v1.11.0 then you would do:
import { createClient } from "polkadot-api";
import { WebSocketProvider } from "polkadot-api/ws-provider/node";

const client = createClient(WebSocketProvider("wss://your-fancy-server.io"));

However, if your node was built with a version prior to that, then you would have to do something like:
import { createClient } from "polkadot-api";
import { WebSocketProvider } from "polkadot-api/ws-provider/node";
import compatEnahncer from "polkadot-api/polkadot-sdk-compat";

const client = createClient(
  compatEnhancer(
    WebSocketProvider("wss://your-fancy-server.io")
  )
);

The final API may differ a bit (perhaps I will create different enhancers for different versions, but I don't think so). Also, the compatEnhancer would have a tiny bit of overhead, but I'm pretty sure that it would be neglectible.
This is not going to be an easy task, but I think that it's pretty important: so I will try to priorize this during this week.
AFWIW @mutantcornholio already requested something like this a while back. Anyhow, I will get to it right away.
Also, the CLI should use this compat enhancer by default.

List of all the enhancers that should be needed:

remove dups from pruned blocks
deal with subscription messages out of order
finalizedBlockHash -> finalizedBlockHashes
unpin hashes -> unpin hash
translate unstable methods to v1 (and the other way around)
when transaction_v1_broadcast is not present use transaction_unstable_submitAndWatch as broadcast (same for transaction_v1_stop -> transactionWatch_unstable_unwatch)

Frankly I think that is a very good idea, as polkadot-sdk upgrades have been quite labour-intensive recently, so I would assume we're not the only team that is not on the latest versions - especially given that there's no immediate pressure to upgrade since v1 afaik.

import compatEnhancer from "polkadot-api/polkadot-sdk-compat";

I finished implementing all these ones, but it turns out that the kilt node is running a super-old version that still uses the old events 😭 E.g:
{
  "jsonrpc":"2.0",
  "method":"chainHead_unstable_call",
  "params":{"subscription":"gDV32FvQCQ7YqfB4","result":{"event":"done","result":"0x080e0000000f000000"}}
}

I will try crafting another enhancer to fix this, but I'm afraid that this node version may be too old, so I'm not sure if I will be able to fix all the bugs of this old version just with these enhancers... Let's see.

I will try crafting another enhancer to fix these events, but I'm afraid that this node version may be too old, so I'm not sure if I will be able to fix all the bugs of this old version just with these enhancers... Let's see.

We are in the process of updating to 1.7.0, so if the current enhancers work with that version that would be completely sufficient. You could try against branch https://github.com/KILTprotocol/kilt-node/tree/ag_polkadot_v1.7.0 - we have a standalone runtime included, which is pretty easy to spin up (especially when using the --dev flag). I could also bundle up a docker image for you to try it against.

I will try crafting another enhancer to fix these events, but I'm afraid that this node version may be too old, so I'm not sure if I will be able to fix all the bugs of this old version just with these enhancers... Let's see.

We are in the process of updating to 1.7.0, so if the current enhancers work with that version that would be completely sufficient. You could try against branch https://github.com/KILTprotocol/kilt-node/tree/ag_polkadot_v1.7.0 - we have a standalone runtime included, which is pretty easy to spin up (especially when using the --dev flag). I could also bundle up a docker image for you to try it against.

I actually managed to make it work with any node created with polkadot-sdk 1.1.0 or higher, which is a lot more than what I expected! So, basically, if your node is between 1.1.0 and bellow 1.11.0, then you can use the enhancer provided by the new package to make things work. If your work is equal or higher than 1.11.0 then you won't need any enhancers, and if your node is below 1.1.0 then... tough luck! (at least for now).
It's actually possible (but extremely tricky) to make those below 1.1.0 work, but I mean, 1.1.0 was released around September 2023, so I think that it's fair to say that we don't support a version that's older than that.

That's fantastic news! Let me know when it's released - I found out that our current node version also seems to be a problem for smoldot (transaction submission and runtime calls don't seem to work), which means that this strategy is the only real option for us to try using papi right now.

That's fantastic news! Let me know when it's released - I found out that our current node version also seems to be a problem for smoldot (transaction submission and runtime calls don't seem to work), which means that this strategy is the only real option for us to try using papi right now.

I would be very interested to jump into a call and have a look at the issues that you are facing with smoldot, is that possible? My matrix/element user is @josepot:matrix.org, you can ping me there, or send me a DM on twitter (@Joseptec). Thanks!

reopening this, because it was accidentally closed by #571 ... We still have to release the new version and update the docs


Select kubeconfig current context namespace before 'default'.

What this PR does / why we need it:
When the end-user is requesting a tenant cluster to be created in an external infrastructure cluster, the logic that resolves the namespace where to spawn it doesn't take the namespace set for the current context in the kubeconfig that has been provided (please see the issue for the full resolution logic).
This change addresses this by leveraging the clientcmd.ClientConfig; which offers a Namespace method that will return the namespace of the current context, if it is set, and fallback to "default" otherwise.
Which issue this PR fixes:
fixes #158
Special notes for your reviewer:
This fix simply replace the direct call to clientcmd.RESTConfigFromKubeConfig to generate the REST config, with the intermediate call to first generate the clientcmd.ClientConfig, capture the namespace out of it, and then, the REST config. The intermediate generation of the clientcmd.ClientConfig is encapsulated in the clientcmd.RESTConfigFromKubeConfig method, we just do it manually here.
Release notes:
NONE

/ok-to-test

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 45.93%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
711

Relevant Lines:
1548

💛  - Coveralls

/lgtm

/assign @davidvossel


Ability to send client events (data) from other languages as a string…

Allow data to be sent on channel "client event" from other clients with a programming language other than JavaScript, sending the data as a string and try parsing it on the server.

Thanks!


⑤ [Currency selection] Add view model tests

📲 What
Adds tests for SelectCurrencyViewModel.
🤔 Why
To prove that it works as expected!
✅ Acceptance criteria

[ ] Tests pass.
[ ] Tests make sense.
[ ] Coverage is sufficient.

⏰ TODO

[ ] SelectCurrencyViewControllerTests.

🤖Related PR's for this feature
#568
#569
#570
#571

 Change Currency Picker to new view with TableViewCells


Update calico urls and minor typo fixup

Updated several of the calico-related URLs and a minor typo fix.

Thank you!


Front: dry

too much repeating (see table code)

Tables looking more mergeable, tbd when time

getting there


Replace PP with SNR search key word

Updated Search Key word from PP to SNR in order for the operator to appear in OCP UI when searched.

/lgtm


Implement PushSecret

discussed in #641
We want to implement the SecretSink proposal https://github.com/external-secrets/external-secrets/blob/main/design/001-secretsink.md.

We are really looking forward for this feature, awesome work!! 🚀
Could you provide estimates when this feature (Hashicorp Vault) will be available.
Maybe like: yes we start next week, in 2-3 month, will take at least half a year.

Hey @dweber019! We are currently working on it (as you can see with the related issues) as a way to upskill internally some teams here. Our work order can be followed here. Our first focus will be GCP, but then we can go for Hashicorp Vault as well.
I'd estimate 3 months to have basic functionality for one, maybe two providers.
Also, this is an initiative open to the community. So, if you want to join in (and maybe help us deliver it faster), we are happy to welcome you! :smile:

Hi @robert-heinzmann-logmein ! A PR is open - basically following standard review process in our end :)

Do you think there could be a way to use TokenRequest to periodically generate a token for a service account and uploads the information to the secretStore?
Currently, it would be impossible to use because the selector only has a secret as input, but it could have a serviceAccount selector.
Otherwise it is possible to manually create a token with a fixed name for a ServiceAccount since 1.24, but it would be a long-lived token without rotation.

Hi @agaudreault-jive ! This is already supported by ESO :)

Hi @agaudreault-jive ! This is already supported by ESO :)

@gusfcarvalho can you point me to documentation on how to achieve that? 👀

I’m your SecretStore, when you define a ServiceAccountRef. We will automatically request a new token if permissions are there. If not, we fall back to searching for a secret.

In your SecretStore, when you define a ServiceAccountRef. We will automatically request a new token if permissions are there. If not, we fall back to searching for a secret.

I think you misunderstood the question or perhaps it was confusing. The goal would be to upload/push specific service account token to the target secretStore, in our case hashicorp vault.
Not authenticate to the secretStore with a service account :)

I'd add a generator [1] that produces a service account using the token-request API. This service account token is then stored in a secret (alongside ca cert). This secret can be referenced from the PushSecret and pushed to a remote store.
I think that would solve your use-case and i'd be super happy about that addition. This is kind of close to what Vault Kubernetes secrets engine provides, but vault-agnostic :smile:.
[1] https://external-secrets.io/v0.7.0/guides/generator/

Is PushSecret released and ready to use?
According to https://github.com/external-secrets/external-secrets/issues/1101 it has been implemented for HashiCorp Vault and I can find some documentation about it https://external-secrets.io/v0.7.0/api/pushsecret/ and https://external-secrets.io/v0.7.0/provider/aws-parameter-store/#creating-a-push-secret but not for https://external-secrets.io/v0.7.0/provider/hashicorp-vault/.

Is PushSecret released and ready to use?

It has been released with 0.7.0, however expect some rough edges :)
We'd be glad if users report bugs for it so we can improve upon it.


Printing Bug Fixes

Fixed the issue where budget rows could be getting cut off when
printing, and did some additional improvements to fix blank space when
printing the account section.
I did discover, though, that the account view only prints about a page
and a half of transactions due to the way Ember hides and loads
transaction data when scrolling. That may be a limitation I can’t do
much about without some extensive work. I’ll look into it.

Nice, thanks!


Codeset conversion

I'm running on Ubuntu 16.04 LTS with both LifeLines 3.0.61 from the distro and LifeLines 3.1.1 (official) from a recent pull on it. I wish to create a new database and read the attached GEDCOM into it.
xxx.zip
On the newer version I get a message saying
Lossy codeset conversion (from  to <~@>) likely
Proceed anyway?
enter y (yes) or n (no):
After y, I get
Cannot convert codeset (from  to <~@>)
Enter codeset to assume (* for none)
I just hit return, and although it reports
Checking GEDCOM file for errors.
74 Persons
27 Families
0 Sources
0 Events
1 Other (SUBM)
0 Errors
it does not say "No errors" the database remains empty.
On the older version there is no problem.

I was able to reproduce this on Ubuntu 16.04.  Once.  I haven't been able to reproduce it since.
The <~@> text seems like garbage, and that takes us down the path of remapping everything in the file to NULLs (since no codeset conversion map exists).  However, I haven't found a place in the code that allows garbage to be introduced (uninitialized pointer, etc.)  I will continue to attempt to repro.

I've had an idea: some websites export a GEDCOM kludging the UTF-8.
I.e. they abuse the fact that UTF-8 shuns 0x80-0x9F to simply recycle
the software for exporting ANSI/ANSEL. This works most of the time, but
sometimes the linebreaking logic on a CONC line cuts in the middle of
a UTF-8 codepoint.
So the GEDCOM claims to be CHAR UTF-8 but actually contains illegal
sequences.
Would such a GEDCOM break LifeLines?
Best wishes
Dirk
2017-03-25 22:23 GMT+02:00 Matt Emmerton<EMAIL_ADDRESS>
I was able to reproduce this on Ubuntu 16.04. Once. I haven't been able to
reproduce it since.
The <~@> text seems like garbage, and that takes us down the path of
remapping everything in the file to NULLs (since no codeset conversion map
exists). However, I haven't found a place in the code that allows garbage
to be introduced (uninitialized pointer, etc.) I will continue to attempt
to repro.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/MarcNo/lifelines/issues/309#issuecomment-289237169,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AB9TPFsDTR1gdBKspzCn4aA6lsU9l7Afks5rpXe6gaJpZM4L9LnQ
.

That sounds plausible. I get the same error importing a gedcom from wikitree: Lossy codeset conversion (from <UTF-8> to <~@>) likely


Add banner for test systems

Motivation

Sometimes, it can be dangerous to mix up the test and prod systems.
Proposed Solution

Add new TEST setting independently from DEBUG mode
Also support reading this setting from environment variables
When this setting is True, add a test banner at the top of the screen

Alternatives

Additional Context

Just for reference, e.g. PyPI does it the following way:
https://pypi.org/

https://test.pypi.org/

@timoludwig the text of the banner is not 100% accurate, the content of test cms is not visible in our beta versions. It is only visible in webnext/dev releases of the native apps.

@steffenkleinle ah ok, that's unfortunate. The banner should reduce confusion, not add to it. Do you want to open an issue and suggest a different wording?

@timoludwig done


Upgrade Mongock dependency to v5.1.0

Is your feature request related to a problem? Please describe.
v5.1.0 contains some breaking changes. Refer migration guide
Describe the solution you'd like
Should support the latest stable release.
Describe alternatives you've considered
N/A
Additional context
Refer https://github.com/jhipster/generator-jhipster-quarkus/pull/247/commits/3cf3bd5273492ad5ae43f72466cf2129012e16e7

@mraible, Since you already worked on this part before, do you want to take it up?

I'm can take a look on Monday. Steps to reproduce would be awesome.

@mraible, Sorry for the late reply. Lately I was bit occupied and could not spend much time over here. This ticket is to upgrade the dependencies and adjust code. In the linked commit, I see you had already tried/explored most of the changes. Let me know if you want to continue to take it to completion.

I was able to make some progress and resolve most of the issues. However, native tests do yet work and fail due to a similar error as in the previous version.
If we are fine with this limitation, then, I can try templatizing these changes and raise PR in the next few days.

Sounds good!

Adding a bug bounty.

@kamilkrzywanski , If I recall correctly, there was some issue with native tests after upgrade. Does that works now?

Fixed and tested according to official documentation: https://github.com/mongock/graalvm-example
and added required graalvm library jboss-vfs
PR:  https://github.com/jhipster/generator-jhipster-quarkus/pull/426

@mraible here is also native fix commit #426


Add ability to delete single gists

For a some time I've wanted to be able to cleanup my gists in the apps list.
This PR adds this ability, by adding a delete button to each gist in the "Your apps" list.
I made the change as small and simple as possible, using the browsers built in confirm dialog.
UPDATE 2021-12-19:
I've pushed some changes to make this a more robust and proper solution:
When a gist is deleted, the new gists list for the current page is re-fetched and loaded. If there are no gists for the current offset after a deletion, and we have a prev offset (i.e. last gist on last page deleted), we'll navigate to the prev page.
I also added a "Previous" pagination link to the bottom of the list.
A page state "deleteState" is introduced to make sure we don't open up for deletion during deletion on slower connections.
/UPDATE
Some screenshots
On hover:

Confirm:

Pagination:

Thanks — FYI I opened #202, we don't want to end up deleting data irretrievably. As well as adding a deleted_at column, it changes the signature of gist.destroy (there's no need to send all the gist metadata, just the id). Added a note in there that we will probably want the ability to bulk-delete, though that can come later.
It would probably be more RESTful if we were making a DELETE request against /repl/[id].json rather than /app.json, though admittedly I haven't thought about what that would look like in the bulk-delete case.

Thanks @Rich-Harris, that makes sense. I still haven't gotten too familiar with the codebase yet.
I've updated this PR to build on your #202 and addressed the comments you had.
wdyt about the window.location.reload() after a successful deletion?
I figured it was the simplest solution for now, but could read in the new list of gists for the current page number instead.

Added the ability to bulk-delete apps in #214, so I'll close this — thank you


Module 1.1 Assignment

Given what you have learned about Git, why would you want to use Git in your classroom?

Version control for my students, code submission, review, grading automation control for myself


fix(Pit): round the middle value to the whole number

Most prices start from > 0, which causes annoying decimal values at the middle.
This PR fixes that by always rounding the middle value to a whole number
Maybe not a complete fix for #2275, but definitely related to the underlying reason.

version
result

before

after

I wanted to add this as a prop first, but it seems like that might be hard with Rheostat

When I did this, I wanted to correct the issues with the rangeSlider from v1 which was not placing the middle pit at the correct middle.
And also, to provide support for negatives values which was a nightmare for the v1.
What I purpose, is to use the precision parameter to know at what decimal we should round for the start/middle/end pit value.
What do you think?

Having this as an argument seems good to me. Precision as number of digits after 0, defaulting to 1?

Yes exactly, the default value is 2 👍

Pit has now got a precision Prop, how do we expose it to the users, via Slider?

@Haroenv what's the status on this? If you don't have time to take care of it for the moment, do you mind if I close the PR?


Windows - ssh-kengen executable file not found in %PATH%

Gitea version (or commit ref):  1.11.6 built with GNU Make 4.1, go1.13.11
Git version: git version 2.24.0.windows.2
Operating system: WINDOWS SERVER 2012 R2
Database (use [x]):

[ ] PostgreSQL
[x] MySQL
[ ] MSSQL
[ ] SQLite

Can you reproduce the bug at https://try.gitea.io:

[ ] Yes (provide example URL)
[ ] No
[X] Not relevant

Log gist:
2020/06/17 08:25:17 ...user/setting/keys.go:96:KeysPost() [E] AddPublicKey: calcFingerprintSSHKeygen: 'ssh-keygen -lf C:\Windows\TEMP\gitea_keytest389891466' failed with error 'exec: "ssh-keygen": executable file not found in %PATH%':

Description
Fresh install, while adding ssh public key, it is throwing 500 error code. Checked the logs, it shows above message in the log.
Restarted the entire server once to make sure PATH is updated.
before and after restarting the server, I tried ssh-kengen on server, it is executing the binary ok. For some reason Gitea is not finding it right. Any help appreciated!
Screenshots

Could it be that it is not in system path

@lafriks  thanks! that fixed it.
I had to add the path under System PATH, it was in User's path. And restarted the Windows service. Thanks for the quick response.


Simplify the logic of ObjectReuseJob

Previous ObjectReuseJob is a bit too complex for participants.
We should drop some complex statements to let participants focus on understanding points below:

how to ensure job correctness when object reuse is enabled
how to improve the performance by changing serializer

This is a forward-port of https://github.com/ververica/flink-training-troubleshooting/pull/6. I adapted the training dashboard to remove a now unnecessary graph and checked that you can still see the same results from enabling object reuse (too high temperatures)

Yeah, locally, you don't see the wrong results that easily - we export the temperatures as metrics and with object reuse on, in the task, they are just too high. Eventually, we should change the setup and also verify the results via tests...

Might be nice to add a comment in solution1 pointing out what had to change to in order make object reuse safe

yes - we are actually missing a whole description of the exercise in this repo. I'm afraid, we will have to work on this later though.


Production Build Not working

When adding debug = false annd DJANGO_VITE_DEV_MODE = false, the resulting html has incorrect attributes (type=module, async, defer)
Steps to recreate
clone the https://github.com/MrBin99/django-vite-example
run:
yarn
pip install django django-vite

In settings.py:
Set Debug = False (which turns DJANGO_VITE_DEV_MODE = False)
then run:
yarn build
then run:
python manage.py runserver
the console shows two errors:

The resulting html source is:

which shows:

the css is getting a mime/type error.
js is 404, and has type=module, async and defer.

I don't think this is expected behavior per the docs:

I've you done python manage.py collectstatic ?

Yes I did run python manage.py collectstatic

Found the issue:
One needs to install WhiteNoise serve the static files when Debug=False.
I love this project so I'm going to throw in a MR for outlining the set up steps for the example if you're okay with that.

I don't understand why you want to put this inside the doc. It's a thing you maybe have to do in your environment.
I think it may be useful for a minority of people and for beginner it will be confusing.
Personnaly I serve static files with Nginx and the default Django static files system in production and well configured it works like a charm.
What do you think of maybe, put your doc inside another .md file not inside the root one, and juste put a simple
link to it in the root one ?
(We can continue this conversion in your PR if you want).


Change sample runs in ex6p [ex6p-runs2-dev]

This is a follow-up PR to #2105 that actually changes the runs (prefer NC refinement, improve SFC ordering).
(#2105 needs to be merged first)

This PR is now under review (see the table in the PR description). To help with the review process, please do not force push to the branch.

What is difference between using -m ../data/star-hilbert.mesh and -m ../data/star.mesh -rm 1?

star-hilbert.mesh is manually ordered and oriented to get a nice continuous SFC (I wasn't able to get this result automatically with Gecko). The option -rm 1 is just a quick spatial sort, better than nothing but by far not optimal.

LGTM

Sorry, one last change, the -rm option is not needed for the -cs run...

LGTM

Merged in next for testing...


Text2Mel input to WaveGlow outputs noisy audio file without any speech

I've retrained the text2mel model (Described in [https://arxiv.org/pdf/1710.08969.pdf]), by cutting out mel reduction part in preprocessor, and changing the hparams to:
    hop_length = 256
  win_length = 1024
 max_N = 180  # Maximum number of characters.
max_T = 210  # Maximum number of mel frames.
  e = 512  # embedding dimension
 d = 256  # Text2Mel hidden unit dimension
I'm trying to feed generated mels to WaveGlow, but output audio file is just noisy honk.
Any ideas?

Make sure the mel-spectrogram preprocessing match the one used in Waveglow.


Should we add PowerToys utilities to Dev Home?

Provide a description of requested docs changes
We're looking into adding more features into Dev Home and we're considering adding a page for PowerToys to build in utilities. Dev Home is directly built into Windows and allows us to provide deep, feature-rich experiences for developers directly into the OS.
Our question is, do you want to see PowerToys in Dev Home? If so, which utilities would be most useful to you?

How would that work? Adapting the features 1:1 or just linking to the PowerToys installer?
Imo the lines between what "Dev Home" means in my mind and "PowerToys" are very blurry. But I'm a dev. Not all PowerToys features are targeted at devs. If it was just me, Dev Home and PowerToys should merge.
If you want the products stay separate, maybe move the features targeted at devs into Dev Home and remove them from PowerToys? But that would make people who only use PT unhappy because they have to install yet another thing and lose functionality if they don't act.
I would be interested to see what Telemetry you guys have on this, how many Dev Home users also have PowerToys installed and vice versa.
At the end, maybe Dev Home should stay a "hub" like it currently is and only display links to PowerToys, open the PT UI when it detects it is installed, offer to download when not?

Would it make sense to turn all PowerTools into individual programs, like Dev Home extensions, that then register/install into Dev Home? With the PowerToys installer just installing all of them or giving you a choice? And then dev home handles management of options/updating via store etc?

I'd generally love to see some of the PowerToys getting properly integrated into default Windows, either through Dev Home or otherwise.

PowerTools Awake alone provides so much utility. Like @CanePlayz  said, we would love to see this and other PowerTools integrated straight into Windows 11.

What is the benefit to adding them in Dev home rather than getting them from their existing location?

@wolf99 There are 3rd party tools out there that work similar to PowerTools, but their obscurity does not lend them any credibility and they could become backdoors for malware.
Including PowerTools in Windows is great for anyone seeking the functions that PowerTools fulfills, without having to search elsewhere for untrustworthy 3rd party software because PowerTools has the backing of Microsoft. Including PowerTools will also increase visibility and awareness of the PowerTools themselves, as I was looking for a tool with functions like PowerTools Awake, but search engines could not lead me to PowerTools Awake itself. There are many more folks who could willingly get use out of the utility PowerTools provides.

Including PowerTools in Windows is great

💯 Agreed, include them in Windows, that would be awesome... Not inside Dev home.
It's like putting regedit inside notepad. Both are useful things within Windows. Both are used by developers, power users, and others. Theoretically you could use them both as part of a single use case. But there's no benefit to putting one inside the other.

💯 Agreed, include them in Windows, that would be awesome... Not inside Dev home.

@wolf99 I'm all for their inclusion in Windows itself. I'm going to come clean and mention that I'm unfamiliar with Dev Home, as I'm not a developer myself. However, as a power user, these tools have broader appeal beyond devs, and I wanted to jump into the conversation here to advocate for their inclusion in Windows, given the developers here are listening.

PowerTools Awake alone provides so much utility. Like @CanePlayz  said, we would love to see this and other PowerTools integrated straight into Windows 11.

Power Tools are good indeed, but what is the benefit to adding them in Dev home rather than getting them from their existing location?

Increase visibility and make them accessible to more people.

This entire time, I've been calling PowerToys "PowerTools"
I've edited my posts to correct the typo and apologize if you folks end up looking goofy in the quote replies.

Provide a description of requested docs changes
We're looking into adding more features into Dev Home and we're considering adding a page for PowerToys to build in utilities. Dev Home is directly built into Windows and allows us to provide deep, feature-rich experiences for developers directly into the OS.
Our question is, do you want to see PowerToys in Dev Home? If so, which utilities would be most useful to you?

Or you should focus on finishing basic features first 🤯🤯🤯🤯🤯

Thanks for all the feedback here, this has been super helpful :) I'm going to close this out and file a new issue for just adding a couple PowerToys to Dev Home and not the entire PowerToys experience.
Our goal is to bring in stable versions of specific PowerToys that make the most sense in Dev Home, i.e. Hosts File Editor, which was originally created with the intent to add to Dev Home when we built it for PowerToys


[Security] Fragile cipher suites supported, would you like to remove them?

What kind of issue is this?

[ ] Bug report. If you’ve found a bug, spend the time to write a failing test. Bugs with tests
get fixed. Here’s an example: https://gist.github.com/swankjesse/981fcae102f513eb13ed

Our apk with OKHttp is under the security inspection of IBM AppScan, and get the issue that Android: Weak SSL Cipher Suites are Supported. Here is the details of this issue:

Title
Description

Severity
High

Status
New

Classification
Definitive

Location
(okhttp3\internal\connection\RealConnection.java:241)

Calling Line
(okhttp3\internal\connection\RealConnection.java:241)

Calling Method
okhttp3.internal.connection.RealConnection.connectTls(int, int, okhttp3.internal.connection.Conn ectionSpecSelector):void

Class
com.xxx.xxx

Package
com.xxx.xxx

Availability Impact
Partial

Confidentiality Impact
Partial

Integrity Impact
Partial

Date Created
Wednesday, July 11, 2018

Last Updated
Wednesday, July 11, 2018

Risk
It is possible to steal or manipulate customer session and cookies, which might be used to impersonate a legitimate user, allowing the hacker to view or alter user records, and to perform  								transactions as that user.

Causes
The web server or application server are configured insecurely.

Payload

Intent Package
com.xxx.xxx

Intent Class
com.xxx.xxx

Method Signature
javax.net.ssl.SSLParameters.setCipherSuites(java.lang.String[]):void

Issue Validation Parameters - Name
ciph￼￼￼￼￼￼￼erSuites

Issue Validation Parameters - Value
TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256,TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA25, TLS_ECDHE_ECDSA_WITH_AES_256_CBC_SHA,TLS_ECDHE_ECDSA_WITH_AES_128_CBC_SHA,TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA,TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA,TLS_RSA_WITH_AES_128_GCM_SHA256,TLS_RSA_WITH_AES_128_CBC_SHA,TLS_RSA_WITH_AES_256_CBC_SHA

The above with bold and italic are reported as the cause of this issue.  As far as I'm concerned, it is SHA that considered fragile by IBM AppScan. In fact it is an outdated algorithm and many security standards such as PCI consider it fragile.
So, would you like to upgrade OKHttp, deprecate SHA to make it complies with these security standards? Or else some apk with high security requirements may face the same problem.

Configure your OkHttpClient to use ConnectionSpec.RESTRICTED_TLS instead of it's default connection specs. This may limit which servers you can complete a TLS handshake with.

Doesn't appear to be anything to do here

@jackyvictory Hello! How did you resolved this problem?


docs(line): add demo line with area annotation

添加一个 demo：

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 87.794%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
10153

Relevant Lines:
11199

💛  - Coveralls


Remove version: Jackett.Jackett version 0.20.4083

404 - release deleted
Microsoft Reviewers: Open in CodeFlow

URL: https://github.com/Jackett/Jackett/releases/download/v0.20.4083/Jackett.Installer.Windows.exe
Response Error: The remote server returned an error: (404) Not Found.
(Automated message - build 918)


Basic support for custom title component, left & right button components in NavigationExperimental

This is by no means ideal, we need a custom title component and left & right nav buttons internally so I quickly hacked in support.
Figured this might be useful for others, hence the PR.

Well never mind that; looks like this is pretty much done (and in a much nicer way) in 0.23.0-rc.


stats: name lookups occur on every new http1 connection may cause contention

It appears that the h1 codec instantiates new stats every time it's instantiated:
#define ALL_HTTP1_CODEC_STATS(COUNTER)                                                             \
  COUNTER(dropped_headers_with_underscores)                                                        \
  COUNTER(metadata_not_supported_error)                                                            \
  COUNTER(requests_rejected_with_underscores_in_headers)                                           \
  COUNTER(response_flood)

and those may induce symbol-table contention. It'd be good to pre-symbolize those at startup.

looks like this also occurs for http2, and there are actually some common stat names.

Was doing some issue cleaning and this is a dup of https://github.com/envoyproxy/envoy/issues/8324 FYI.

@danzh2010


Question: Is it OK to map over AtomWithQueryResult?

I couldn't find anywhere else to ask this, so sorry in advance if this is the wrong place.
I'd like to be able to apply a function to the data part of an AtomWtihQueryResult value. I have the following implementation, which I think works fine, but are there any reasons I am missing why this would not work or is a bad idea?
const mapQueryResult = <A,B,E>(
  f: ((a: A) => B),
  queryResult: AtomWithQueryResult<A, E>
): AtomWithQueryResult<B, E> => {
  if (queryResult.isSuccess || queryResult.isRefetchError) {
    return {
      ...queryResult,
      data: f(queryResult.data),
      refetch: (...args) => queryResult.refetch(...args).then(res => mapQueryResult(f, res))
    };
  } else {
    return queryResult;
  }
};

Nothing is obviously bad to me about that implementation. But if you only want to transform data, you can either use a derived atom, or use the select property available in useQuery: https://tanstack.com/query/latest/docs/framework/react/reference/useQuery

Feel free to reopen or file a new issue.

Thanks! That's very helpful.


Array column type in dataset is not correctly parsed

This issue is related to https://github.com/CartoDB/cartodb/issues/11328
Looks like the application returns a different data structure depending on what column is being updated, and that the column type with an array/matrix is not parsed properly.
Steps to reproduce

Use Builder.
Upload a dataset with a number[] column type, or any type that implies an array or matrix (i.e. https://data.rennesmetropole.fr/explore/dataset/topologie-des-stations-le-velo-star0/download?format=geojson&timezone=Europe/Berlin&use_labels_for_header=true).
Go to the dataset editor view and try to edit that column. It will return an error message:

row identified with 1 not found

This is what the request sends:

Now try to edit another column. It will return an error like this one:

Error editing adressevoie with cartodb_id 1: PG::Error: ERROR: column "coordonnees" is of type double precision[] but expression is of type record

The request now sends:

cc @javitonino @xavijam

Just to complement the description, the correct format is probably the array as that is what is returned by both SQL API and the records controller. However, the records controller only takes as an input things between brackets like {123,456}, but it then returns an array.
The direct solution would imply changes in front (consistent behaviour that does not depend on which column are you editing) and backend (to ensure it accepts the same format as it returns).
Alternatively, we could start thinking about phasing out the use of records controller, and have the dataset view work directly against the SQL API for write operations.


Petitions

change.org: Swan (and Goose)
change.org: Swan

The ISO/IEC working group WG2 who jointly develop the single characters set with Unicode, agreed to add several pictographs intended for emoji usage:

U+1F93F BILLIARD GAMES
U+1F97B TROLL
U+1F9A1 MAMMOTH
U+1F9A2 DODO
U+1F9A3 BADGER
U+1F9A4 SQUIRREL
U+1F9A5 SWAN

Sources

N4870
L2/17-350 = N4566
L2/17-329 = N4888


Add extra statically-determined fields

Continent - see data at https://github.com/ipinfo/python/blob/5236852adc34218cce2151af9a69bfc6a4719eab/ipinfo/continent.json
Country Name - see data at https://github.com/ipinfo/python/blob/5236852adc34218cce2151af9a69bfc6a4719eab/ipinfo/countries.json
Currency - see data at https://github.com/ipinfo/python/blob/5236852adc34218cce2151af9a69bfc6a4719eab/ipinfo/currency.json
Is EU? - see data at https://github.com/ipinfo/python/blob/5236852adc34218cce2151af9a69bfc6a4719eab/ipinfo/eu.json
Flag URL / Emoji - see data at https://github.com/ipinfo/python/blob/5236852adc34218cce2151af9a69bfc6a4719eab/ipinfo/flags.json

@muhammadahmadmslm let's make these inlined in-memory, not as separate files.


GitHub Actions for Website

Auto PR preview for
https://github.com/apache/incubator-apisix-website

Hi @juzhiyuan Can I take this?

Sure

Please note, this issue is for apisix website[1], not dashboard.
[1] https://github.com/apache/incubator-apisix-website

Please note, this issue is for apisix website[1], not dashboard.
[1] https://github.com/apache/incubator-apisix-website

Yeah. I have noticed that.

I will explain what this issue should do here later.

Apache APISIX has a website[1][2], which is built on Hugo[3].
We used to update this site by following steps:

Update codes in the repository[1];
Run custom publish shell publish.sh locally, and once it's done, it will push built files to the gh-pages branch.

So this issue is mainly to use GitHub Action to run publish shell instead of running locally. Because this is not a GSoC task or isrc task, so I'm not sure of its feasibility. If you need any help, please let me know by commenting here or add my wechat JuShaoyao.
[1] https://github.com/apache/incubator-apisix-website
[2] https://apisix.apache.org/
[3] https://gohugo.io/

Apache APISIX has a website[1][2], which is built on Hugo[3].
We used to update this site by following steps:
1. Update codes in the repository[1];

2. Run custom publish shell `publish.sh` locally, and once it's done, it will push built files to the `gh-pages` branch.

So this issue is mainly to use GitHub Action to run publish shell instead of running locally. Because this is not a GSoC task or isrc task, so I'm not sure of its feasibility. If you need any help, please let me know by commenting here or add my wechat JuShaoyao.
[1] https://github.com/apache/incubator-apisix-website
[2] https://apisix.apache.org/
[3] https://gohugo.io/

Thanks for your informative feedback! I managed to set up hugo build on my fork and am now trying to connect to render to set up a PR preview.

2. Run custom publish shell `publish.sh` locally, and once it's done, it will push built files to the `gh-pages` branch.

So this task consists of two parts.

PR Preview
Auto deploy for commits on master

Right?

PR Preview is done on my fork. See https://github.com/Rapiz1/incubator-apisix-website/pull/1

🤔We can use Netlify, but I need to apply for access from Apache, once it's approved, I will let you know!

Apache APISIX has a website[1][2], which is built on Hugo[3].
We used to update this site by following steps:

Update codes in the repository[1];
Run custom publish shell publish.sh locally, and once it's done, it will push built files to the gh-pages branch.

So this issue is mainly to use GitHub Action to run publish shell instead of running locally. Because this is not a GSoC task or isrc task, so I'm not sure of its feasibility. If you need any help, please let me know by commenting here or add my wechat JuShaoyao.
[1] https://github.com/apache/incubator-apisix-website
[2] https://apisix.apache.org/
[3] https://gohugo.io/

Note that PR preview has to be done with CI like render or netlify.

emmm We don't need a preview for every PR currently, just pushed the bundled files to gh-pages branch.

Hi @Rapiz1 , would you mind fixing this issue?
https://github.com/apache/incubator-apisix-dashboard/issues/215


inserting a line after frontmatter fence

If the cursor is on a boundary of frontmatter and I insert a line, I get a line with a -.  But this isn't a list item--it's just a fence.
--- %%cursor could be here%%
tags:
updated: '2023-01-09 11:06-08:00'
created: '2023-01-09 11:06-08:00'
--- %%or cursor could be here%%
- %%inserting a line incorrectly adds a `-`%%

Nice catch! Fixed in v1.12.0


r82.EmojiKeyboard version 1.0

[ ] Have you signed the Contributor License Agreement?
[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?
[ ] This PR only modifies one (1) manifest
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.4 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

//Close pull request I'll send the original dl link in another pull request but it is allowed for me to distrubite the software tho

I deleted the repository I created but I tried to use the original download link with "wingetcreate new" and it doesnt work. What should I do? do I reupload the repository I made to github and we call it a day or is there a fix for the original download link

also here is the original site https://download.cnet.com/Emoji-Keyboard/3000-20418_4-77548075.html

I deleted the repository I created but I tried to use the original download link with "wingetcreate new" and it doesnt work. What should I do? do I reupload the repository I made to github and we call it a day or is there a fix for the original download link  also here is the original site https://download.cnet.com/Emoji-Keyboard/3000-20418_4-77548075.html

The download is failing because the repository was deleted. The original site is a 3rd party download site, which is normally not allowed, but this developer doesn't appear to have their own site, and there doesn't appear to be a better link for this package.

/AzurePipelines run

hey the bot said the url is invalid since I deleted the repo can you close the pull request or do I reupload the repo as its the only option?

hey the bot said the url is invalid since I deleted the repo can you close the pull request or do I reupload the repo as its the only option?

Sure, I can close the PR for you.


Add licenses

Motivation for this change
Another round for https://github.com/NixOS/nixpkgs/issues/43716
Things done
Update/add licenses for:

data-sharp
gdcm
gdk_pixbuf
geany[-with-vte]
gengs (dead lownload link, https://github.com/NixOS/nixpkgs/issues/45076)
gettext
giflib_4_1
ginac
gio-sharp
gitlab
gl117
glock
glsurf
glusterfs
gnet
gnuplot
gnupth
gnuvd

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Fits CONTRIBUTING.md.

Thank you!


Peer-to-peer code review

Hy @david30-maker ✋🏻
Your project is perfect everything is well done 💯
There are only one change that you can fix in your contact us the section is going to left, you can put that in center just to look much more good 👍🏻  other than that its perfect.
Cheers & happy coding 😄

thanks for reviewing my project

thanks


[flink] support big decimal for flink cdc sync action

Purpose

if the mysql has a decimal data like<PHONE_NUMBER>222222300000001111.1234567890  ,when sync to paimon ,it is<PHONE_NUMBER>222222400000000000.0000000000 , lose the precision.

Tests

API and Format

Documentation

Please rebase master. We have pushed some fix to solve the test timeout problem.

Please rebase master. We have pushed some fix to solve the test timeout problem.

done

fix MySqlCdcTypeMappingITCase#testReadAllTypes method