fix: serializeFunction helper fails with certain functions

A function shorthand with certain statements inside failed to
serialize properly using serializeFunction.
Resolves #8779

Types of changes

[x] Bug fix (a non-breaking change which fixes an issue)
[ ] New feature (a non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Description
The issue was due to the replacement patterns not considering there being
a space between the function name and the parenthesis before the
arguments.
Changed the simple string pattern to regexp to be able to match any
number of whitespace characters between those.
Also changed the test file to not be transformed by babel-jest as that
has affected the input passed to "serializeFunction" and made some tests
invalid. For example, the new test didn't even fail with babel-jest as
it was transforming the test input in a way that made it pass.
Checklist:

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly. (PR: #)
[x] I have added tests to cover my changes (if not applicable, please state why)
[ ] All new and existing tests are passing.

Codecov Report

Merging #8780 (b0ed202) into dev (fffb1a1) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##              dev    #8780   +/-   ##
=======================================
  Coverage   66.03%   66.03%
=======================================
  Files          92       92
  Lines        4013     4013
  Branches     1105     1105
=======================================
  Hits         2650     2650
  Misses       1097     1097
  Partials      266      266

Flag
Coverage Δ

unittests
66.03% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

packages/utils/src/serialize.js
87.87% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fffb1a1...b0ed202. Read the comment docs.


It freezes Firefox to death

Firefox not responding
Firefox stops responding when angular-translate tries to load JSON files.
It performs well in other browsers (Chrome 52.0.2743.116 m (64-bit) and MS Edge / Internet Explorer latest versions
The environment

version of angular-translate: 2.11.1
version of angular: 1.4.9
which browser and its version: Firefox 48.0.2
operating system: Windows 10 (64)

The plugin configuration
`       'pascalprecht.translate',
        ])
        .config(['$translateProvider', function ($translateProvider) {
            // define translation JSON files' name pattern
            $translateProvider.useStaticFilesLoader({
                prefix: 'scripts/translations/translation-',
                suffix: '.json'
            });
            $translateProvider.fallbackLanguage('en-AU');
            $translateProvider.preferredLanguage('en-AU');
            // remember language
            $translateProvider.useCookieStorage();
        }])`

@jednorog  Please provide a working demo with the crash.

the working application is on this URL (language switching is temporarily disabled but language defaults to using JSON translation file for en-AU. There is another JSON translation for lv-LV which can be accessed if cookie value is edited):
https://memberstest.icompetenatural.com/#/

@jednorog  Please provide an isolated demo/test case only with your issue.

Hello,
this is a second reminder: We are still waiting for your reply with additional details. If you cannot help us, we cannot help you.
Outdated issues will be discarded after a period of time.
Looking forward to hear from you.

Hello,
I'm closing this issue due inactivity. We have asked for additional details, but you could not helped us. Therefore we close this issue as not reproducible.
If you still have an issue, please create a new issue because we cannot be sure to track closed issues.


The boto config used by s3fs is not parameterizeable when instantiated by Petastorm

The problem is that their stock configuration uses the legacy retry mode, which is not the recommendation from AWS. Since Petastorm instantiates the s3fs client when using either make_reader or make_batch_reader, there's no opportunity to configure it correctly, and brute-force changes to the ~/.aws/config file impacts any code using boto3, even if unrelated, so there is no fine-grained control to the number of retries by use case.

Got it. I assume our idea of parametrizing make_read/make_batch_reader with a file-system instance would solve this. RIght?

The merged code solved this, but parameterizing with a FileSystem might allow me to work-around the deadlock in the interaction between pyarrow and s3fs. As mentioned, I'll pull you into that ongoing conversation.


Add Bloomberg logo to frontend

Tier: Kilo
https://drive.google.com/open?id=0B2Kw5r5r7Uy-Q3k4LW1jbXRyRDA

When adding Bloomberg logo please keep the following in mind:
The logo can be used only in the colors black, white or yellow (Pantone Yellow C) and must be placed at least .5 inches from any other logo or visual asset. When used digitally, the trademark must appear in white on a black background or black on a white background, may not be smaller than 100px in width, and should have adequate space on all sides. The trademark should never appear in a box or any other holding shape, nor may it be used in combination with any other trademark or tradename.
You can obtain the logo here: https://mlh.io/brand-guidelines


[Bug] VFN crashes after 1.1 -> 1.2 upgrade

🐛 Bug
VFN crashes after 1.1 -> 1.2 upgrade.
To reproduce

Deploy testnet on 1.1
Upgrade one validator to 1.2
VFN of upgraded validator crashes

Stack trace/error message
2021-04-06T21:41:06.087305Z [network-vfn] ERROR common/crash-handler/src/lib.rs:38 details = '''panicked at 'called `Result::unwrap()` on an `Err` value: InconsistentCardinality { expect: 3, got: 2 }', /root/.cargo/registry/src/github.com-1ecc6299db9ec823/prometheus-0.12.0
/src/vec.rs:258:49'''

Logs: fn.txt
Expected Behavior
It shouldn't crash.
System information

release-1.2_59d95143
mgorvennet testnet, val0

Resolved by adding in this change :( https://github.com/diem/diem/pull/8142


[Bug]: OpenAPI 3 Emitter failed to add specification extension

Describe the bug
@extension failed to add specification extension
Actual Specification
The OpenAPI Object cannot be extended with Specification Extensions.
openapi: 3.0.0
info:
  title: ' title info'
  version: 0.0.0
tags: []
paths: {}
components: {}

Expected Specification
The OpenAPI Object be extended with Specification Extensions.
openapi: 3.0.0
info:
  title: ' title info'
  version: 0.0.0
tags: []
paths: {}
components: {}
x-custom: My value

Reproduction

git clone https://github.com/skywing918/typespec-workaround.git
tsp compile extension.tsp
Open /tsp-output/@typespec/openapi3 to get the result

Checklist

[X] Follow our Code of Conduct
[X] Check that there isn't already an issue that request the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion.
[X] The provided reproduction is a minimal reproducible example of the bug.

Dup of https://github.com/microsoft/typespec/issues/3837


Allow reupload of same file once the upload is complete

Adding an option to override the default behavior of ignore reupload of the same file.

Tests ar not passing because you are using opts instead of this.opts, please fix  and it will be merged. Thanks

Could you add documentation for this option to the readme?

Added documentation for this option.
https://github.com/flowjs/flow.js/pull/113

Could you please add this merge into the version in the dist directory? Installing Flow using bower ignores the src directory, which actually contains the Flow version that allows this behaviour. I spent an hour or so trying to find why duplicate downloads were not accepted, only to find out that the version I have installed, even though it's "the latest" one, is not the latest one :(
It's even more confusing because the README which is shown on github says that the option is available.

Sorry for this confusion, I will try to release this as soon as possible.

Hi, I need using this option in my project, but I found this option didn't merge into the version in the dist directory. So I tried to use the version in the  src directory. Bad luck, it throw an error said ' domNode.appendChild is not a function '. I also use ng-flow.js in my project.
Help me, thx~!


Feature/liayoo/init

Added some skeleton code and tests.
Note that the API has not been tested yet (will be tested once the server & domain are set up).

Thanks for the quick review. I'll merge this PR after testing the API!


Corne cherry v3 into mini

Hi,
I have pcbs for corne cherry v3. I wonder if the pcb can be cut to have only 5 columns as nothing help to cut it (unlike the corne choco for instance).
Thanks for your answer.
Damien

v3 doesn't support the mini version.

Hi foostan,
Thanks for your answer. Even if not supported with pre-cut pcb, I thought it was possible to cut it with precautions in order to have a mini version. I understand by your answer there is no way.

Hi,
To answer myself, here is how I cut the PCB of a cherry v3 in order to have a mini version.
Disclaimer : I am not an expert and I just share what I did in order to help.
What you need to know before ?
If you don't have LEDs, then you have nothing else to do than cutting the PCB.
If you have LEDs, then you will break the LEDs circuit on the right hand. But it is easy to solve.
Where should we cut the PCB ?
Please see purple lines 1 and 2 that materialize the cutting line.

How to cut the PCB ?
Take a cutter and begin slowly to mark the line on both side of the PCB. Repeat operation in order to have deep lines that would allow you to break the PCB. Be careful !

How to fix right hand ?
I repair the break by connecting 2 LED with a piece of cable as you can see here :

Result :-)

Enjoy
Damien


remove console.log

<EMAIL_ADDRESS>line 784 ther is a console.log that need to remove :)

Could you create a PR;)


added feature of manually setting "BUFFERSIZE" of FFT data used in amplitude analysis

solves #417
not only feature is added but also example have been updated !

areas of impact
examples/amplitude_analysis/sketch.js
lib/p5.sound.js
lib/p5.sound.js.map
lib/p5.sound.min.js
lib/p5.sound.min.js.map
src/amplitude.js

hey @therewasaguy !
after exploring a lot and playing around with P5.js-sound library ,  i pointed out a new feature and
have tried to implement the same!
please have  a  look!
thanks!

@therewasaguy
It must be power of 2, thank you for pointing out 😅. I will be correcting it.

@therewasaguy
I have read the w3 specs about web audio api and here is what i get
The bufferSize parameter determines the buffer size in units of sample-frames. If it's not passed in, or if the value is 0, then the implementation will choose the best buffer size for the given environment, which will be constant power of 2 throughout the lifetime of the node. Otherwise if the author explicitly specifies the bufferSize, it must be one of the following values: 256, 512, 1024, 2048, 4096, 8192, 16384. This value controls how frequently the audioprocess event is dispatched and how many sample-frames need to be processed each call. Lower values for bufferSize will result in a lower (better) latency. Higher values will be necessary to avoid audio breakup and glitches. It is recommended for authors to not specify this buffer size and allow the implementation to pick a good buffer size to balance between latency and audio quality
But i think p5 user barely cares about how frequently onaudioprocess task is dispatched and
Neither i find any glitches with or without setting bufferSize
Thus keeping  present requirement

hey @endurance21, I've added a card for this to our GSoC backlog. It would need resolving of merge conflicts and the changes mentioned above, but before doing that...it sounds like we're on the same page that this feature isn't as much of a priority right now. How do you feel about closing this so that we can focus?


Investigate possibly broken 8.10.1

Current Behavior
As seen in #30462, Gradle fails to update the wrapper on release to 8.10.1 with:
> Cannot call Task.usesService(Provider) on task ':build-logic:integration-testing-kotlin:compileKotlin' after task has started execution

Expected Behavior
This should not happen
Context (optional)
No response
Steps to Reproduce
Take the code from #30462 and:

./gradlew -g test-home sanCh
./gradlew -g test-home prepareKotlinBuildScriptModel :build-logic:binary-compatibility:compileTestKotlin

Can reproduce by doing 2 before 1 as well, make sure you get a CC miss though (add a newline to settings.gradle.kts is enough) and stop daemon between runs: ./gradlew -g test-home --stop
Gradle version
8.10.1
Build scan URL (optional)
https://ge.gradle.org/s/acaycvsfdqn4c
Your Environment (optional)
No response

When upgrading to 8.10.1 I regularly get a similar but different error, see: https://gist.github.com/jasperkamerling/0e5d582b3924d383d58c7a96fdb5cb91
If it helps i can provide the projects build scripts.

We encounter the same issue as @jasperkamerling in many of our build.

When upgrading to 8.10.1 I regularly get a similar but different error, see: https://gist.github.com/jasperkamerling/0e5d582b3924d383d58c7a96fdb5cb91

Seeing this one too in detekt builds since 8.10.1. Should this be raised as a separate issue or is it suspected to have the same root cause as Cannot call Task.usesService(Provider) on task?
It's intermittent so I don't have a reproducer.

I am also seeing this in a large multi includeBuild project when importing to eclipse with buildship - happens every time

I managed to have a temp workaround by adding --no-daemon to my commands.

It seems this occurs on daemon reuse. I can workaround by using gradle --stop, ./gradlew --stop or .\gradlew.bat --stop when it happens.

The root cause has been identified and is indeed related to the Kotlin plugins keeping stale state in the daemon. We are validating a fix.
If you are impacted, either:

Revert to Gradle 8.10 until we release 8.10.2
Run your builds with --no-daemon, which will make sure the daemon expires at the end of the build

@3flex
Yes, it will

Same problem, same workaround helps

Hello @LarsSven, @jasperkamerling, @paul-middelkoop-sympower, @3flex, @JWood48, @andriperalt, @GingerGeek  and @IGR2014,
Could you try version 8.10.2-milestone-1 and report the results?
./gradlew wrapper --gradle-version 8.10.2-milestone-1
On our side we are updating Gradle's own wrapper to that version on the release branch to confirm the fix.

@ljacomet With version 8.10.2-milestone-1 I'm not able to reproduce the issue.
Thanks for the fix, looking forward to the release of 8.10.2 :)

Fixed via #30523

For me as well this looks fixed with gradle-8.10.2-milestone-1
https://github.com/bric3/excalidraw-jetbrains-plugin/pull/340


CoroutineUtils unit tests

Actually tests look great
But I'm not sure if they are needed
tryUnlock and tickerFlow don't seem to be used
withContextAndLock has very simple logic
@kirillt Do we need tests for dead code?


Add Layout Designer (a macOS app that makes layout for UICollectionView)

Project URL
https://github.com/amirdew/CollectionViewPagingLayout
Category
Development > iOS/macOS
Description
Add Layout Designer repo to the applications.json file
Why it should be included to Awesome macOS open source applications  (optional)
Its a simple but powerful tool for making complex layouts for UICollectionView.
Using the app is very easy since it shows a preview in real-time and generates code.
so it's an awesome macOS app that helps developers to make awesome apps!
Checklist

[x] Edit applications.json instead of README.md.
[x] Only one project/change is in this pull request
[x] Screenshots(s) added if any
[x] Has a commit from less than 2 years ago
[x] Has a clear README in English

@amirdew Thank you! 👍


[Feature] Add version and build number to About page

I'd vote against doing this—I don't see the benefits and think it unnecessarily complicates the screen.

Since the app is still in development and subject to changes, it could be useful to know which version you are using. Would make bug reporting easier. I'm happy to do this!


channel-dependent DEPS

If multiple ReactiveModels are present on a site, Stipple.init() stores only the latest stipple_deps() in DEPS[Stipple], although the deps are model and channel-dependent. So only the page with the model that was last initialised will work whereas the other receive the wrong deps.
I propose to make the DEPS channel-dependent by allowing also Strings as a key and to include all Module deps and the deps of the respective channel that is being rendered.
Alternatively one could introduce a new constant CHANNELDEPS ...

This PR covers StippleUI issue 39

Maybe, it' s better idea to have CHANNELDEPS separated, that would help to support multiple models on a single page later. So only the first model would include DEPS and each model would include it's own CHANNELDEPS.


[Question] Any suggestions to help debug the server side code via gui tools ?

I am trying to debug the server side api's using some tools like node-inspector, iron-node and devtool with no success. Has anyone implemented debugging feature into this stack? What i am looking for is to be able to debug the code with the source maps enabled on server side, possibly initiating via npm script when node environment is set to development mode. Any suggestions or pointers to any fork implementing this would really help me.
P.S
I am building my app on 2.0 branch of mern.

Also do not have an idea,  how to deal with it

This is what worked for me, not sure if it's the best approach, open to suggestions.
I added the following script in package.json with node-inspector@0.12.8(global) and concurrently@2.1.0(local) installed. When i launch http://<IP_ADDRESS>:8080/?port=5858, debugger gui loads with source maps and breakpoints on api's are working too.
"debug": "concurrently "node-inspector --save-live-edit" "cross-env BABEL_DISABLE_CACHE=1 NODE_ENV=development nodemon --debug index.js""

I can not even imagine, why and where sourcemap for server side are generated. It is magic. Have you  tried to do the same in some IDE? I have tried to build server with source maps and run transpiled code in web strom, but it does not work

Even i wonder how server side code has sourcemaps by default, i suppose it's because of babel-register or babel-polyfill being required in the server entry point. @somus: could you please clarify this?
And i use atom editor with terminal inside it and don't use IDE's, so not sure about running the app in them.

@aga5tya But I am. Net developer.  I am used to cool and powerful IDE.  I do not want to hold one browser tab for results and debugging client side,  one tab for server debugging and editor window for coding. I am trying to discover something new for and all this javascript stuff is really funny ( especially React) but developer experience (especially on server) is bad.  Or maybe I do not know something.  I can not even imagine how Node.js developers implement some complicated backend logic.  For example Mern.  It is cool for client side,  but I have no idea,  how II should make server development. As for me I,  have implemented separated api server and proxy my calls to it.  For debugging api server I am transpilling it with source map and run generated files with separate instance of debugger.

I solved some issues today using this...
Debugging NodeJs and Webpack Loaders
https://forum.shakacode.com/t/debugging-nodejs-and-webpack-loaders/142
npm install -g node-inspector
change script in package file to this or add new script 'start2'
"start": "cross-env BABEL_DISABLE_CACHE=1 NODE_ENV=development node-debug index.js"
than go to your server.js file and add where applicable
debugger
than go cli and npm start or npm start2
a gui debugger will show up :+1:

I solved some issues today using this...
Debugging NodeJs and Webpack Loaders
https://forum.shakacode.com/t/debugging-nodejs-and-webpack-loaders/142
npm install -g node-inspector
change script in package file to this or add new script 'start2'
"start": "cross-env BABEL_DISABLE_CACHE=1 NODE_ENV=development node-debug index.js"
than go cli and npm start or  npm start2
a gui debugger will show up

@aga5tya you mentioned "debug the server side api's" have you tried postman from chrome dev tools found here? or tried http://swagger.io/ ? here is the demo

regarding node-inspector
npm install -g node-inspector
in your script file do the following, notice the replacement of nodemon?
"start": "cross-env BABEL_DISABLE_CACHE=1 NODE_ENV=development node-debug index.js",
than go to your server.js file and add debugger where you want the breakpoints to be place than start stepping through etc

@SOSANA : Looking into what swagger.io has to offer. But running node-debug instead of nodemon would kill my server changes being watched right ? nodemon is restarting the server for me automatically watching the file changes.

Finally, I have found solution. It is not very cool, bur it works. I have made webpack bundle for server (with source maps). Then, to debug server code in WebStorm, you need to start debugging for this bundle (not for the original code), and it will stop on breakpoints of original code. If you use Visual Studio Code, you should add in webpack.config for server this lines:
output: {
  pathinfo: true,
  filename: 'server.js',

  // If need vscode debugging support uncomment this lines
  // devtoolModuleFilenameTemplate        : '[absolute-resource-path]',
  // devtoolFallbackModuleFilenameTemplate: '[absolute-resource-path]?[hash]'
}

And then start original server code. Also for VsCode you should make correct launch.json
    {
        "version": "0.2.0",
        "configurations": [
            {
                "name": "Launch",
                "type": "node",
                "request": "launch",
                "program": "${workspaceRoot}/server/index.js",
                "stopOnEntry": false,
                "args": [],
                "cwd": "${workspaceRoot}",
                "preLaunchTask": null,
                "runtimeExecutable": null,
                "runtimeArgs": [
                    "--nolazy"
                ],
                "env": {
                    "NODE_ENV": "development"
                },
                "externalConsole": false,
                "sourceMaps": true,
                "outDir":  "${workspaceRoot}/build"
            },
            {
                "name": "Attach",
                "type": "node",
                "request": "attach",
                "port": 5858,
                "address": "localhost",
                "restart": false,
                "sourceMaps": false,
                "outDir": null,
                "localRoot": "${workspaceRoot}",
                "remoteRoot": null
            }
        ]
    }

Per this thread  it sounds like node-debug is broken in > 6.3.1.
As suggested in that thread though, node --inspect --debug-brk is working for me on a fresh clone of mern with node v6.6.0.
Added a debug script to my package.json
"debug": "cross-env BABEL_DISABLE_CACHE=1 NODE_ENV=development node --inspect --debug-brk index.js",


Check if bundle is done before it could be fetch

Fixes: DCOS_OSS-5483

Codecov Report

Merging #149 into master will increase coverage by 0.09%.
The diff coverage is 92.85%.

@@            Coverage Diff             @@
##           master     #149      +/-   ##
==========================================
+ Coverage   66.32%   66.41%   +0.09%
==========================================
  Files          30       30
  Lines        2913     2921       +8
==========================================
+ Hits         1932     1940       +8
  Misses        786      786
  Partials      195      195

Impacted Files
Coverage Δ

api/rest/bundle_handler.go
79.26% <100%> (+0.79%)
:arrow_up:

api/rest/cluster_bundle_handler.go
68.86% <83.33%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3dedc72...4580d9f. Read the comment docs.

Codecov Report

Merging #149 into master will increase coverage by 0.09%.
The diff coverage is 92.85%.

@@            Coverage Diff             @@
##           master     #149      +/-   ##
==========================================
+ Coverage   66.32%   66.41%   +0.09%
==========================================
  Files          30       30
  Lines        2913     2921       +8
==========================================
+ Hits         1932     1940       +8
  Misses        786      786
  Partials      195      195

Impacted Files
Coverage Δ

api/rest/bundle_handler.go
79.26% <100%> (+0.79%)
:arrow_up:

api/rest/cluster_bundle_handler.go
68.86% <83.33%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3dedc72...4580d9f. Read the comment docs.


Mybatis interceptor cannot intercept batch insert data

Mybatis interceptor cannot intercept batch insert data.
log:

Minimization case
git@github.com:pog2g/demo.git

http://<IP_ADDRESS>:8080/demo/swagger-ui.htm

In a batch operation, StatementHandler#prepare() is called just once and the created PreparedStatement is reused for all parameters, so the log output is expected.
It's unclear what you are trying to achieve, but StatementHandler#prepare() may not be the right method to intercept (ParameterHandler#setParameters(), maybe?).

If you apply a your interceptor to the StatementHandler#parameterize method instead of StatementHandler#prepare, you may be able to expected result.

PreparedStatement 'is intercepted in order to be able to intercept the total number of queries from the paging plug-in. 'ParameterHandler' is no problem


Recompile only changed files?

Hey, a feature that would be amazing if only the files that have changed are compiled (and watches for them). How difficult would this be to do? Would be happy providing a bounty for this.

Hey!
Can you elaborate on why this is needed? Do you use TC for smart-contract development where ABIs change often? I was always under the impression that TC is reasonable fast.
Few thoughts

Have you thought about using something like lint-staged?
Checking file status can be actually done very efficiently just based on timestamps ie. find inputs that are newer than outputs and recompile only those. I believe tsc uses the same trick. I believe this would be an easy way to implement such feature.
We can actually put more effort into speed optimizations. An easy path forward is parallel execution.

Cheers!

Yeah so basically I write stubs for my contract, generating typings and then write unit tests. After writing in my tests I write the actual code then need to compile contracts and typings so the tests can execute. Currently this workflow is super slow and annoying to deal with. If contracts can recompile and typechain rebuilds what was changed that'd be 10x faster.

Yeah so basically I write stubs for my contract, generating typings and then write unit tests. After writing in my tests I write the actual code then need to compile contracts and typings so the tests can execute. Currently this workflow is super slow and annoying to deal with. If contracts can recompile and typechain rebuilds what was changed that'd be 10x faster.

I have the exact same problem, it's slowing things down a lot to have to regenerate types each time that I run tests.
Has there been any improvements on this side? It looks like it could be pretty useful to have a command to at least disable types generation when we run tests.

@PierrickGT it is supported if you use harhat (via harhdat target). What's your setup @PierrickGT?

@PierrickGT it is supported if you use harhat (via harhdat target). What's your setup?

I do use it via Hardhat but I suppose my setup needs some improvement.
Here is a project in which I use Typechain and Hardhat: https://github.com/pooltogether/aave-yield-source

Closing this as this is implemented


Can't download any subtitles.

Hi, I've just downloaded latest version of Hulu Subs Downloader Windows Binary and I also have followed your Youtube tutorial but I can't download anything. I have tried this link for single video and this link for whole series. After running program, the screen shows up the text "Writing Links to the File..." and there was no subtitles downloaded. But there was a new file created by the program and It was named "newfile.txt" in the same folder with the  program. I have uploaded this file to pastebin. Please, fix this soon!

Hey,
Ah, thanks for notifying. I have updated the whole repository to fix the issue and reflect the changes. However, not that the "Batch Subs Downloading" won't work, because Hulu won't let logged out users to access the "Links" to single episodes. This caused the batch subs ripper to be shut down.
 I'll have to figure out a workaround for this.


Add "Overview"

Just a braindump of how I would conceptually explain WB's value to a potential user

I also changed the tagline to JavaScript Libraries For Offline Web Apps for dramatic effect :)

Thanks for working on this!
I haven't digested the full set of text yet, but re: the "JavaScript Libraries For Offline Web Apps" tagline—I don't want to give the impression that these libraries are only for "offline" use cases. Going cache-first even when a device is online leads to reliable, fast performance. "Offline-First" would be my preference over "Offline", or just keep it "Progressive".

My big issue with "JS Libraries for PWAs" is that you look at the definition for PWA, and it has sections on being responsive, add to homescreen, serving over HTTPS, being indexed by Google, etc. Workbox has nothing to do with those, so it's way too broad to define it as a PWA library.
The bit about it making it sound like it's only for offline is a good point though. You may never expect users to go fully offline, maybe you're just caching app shell stuff for a faster UX

"JS Libraries that make service workers easy"? Ultimately I'd like workbox to contain a library or two for push in the near future.

@kaycebasques thank you so much for this - it's awesome!!
I've added comments but they are all personal. Where do you think this should live on the microsite? I'm not sure it's a good idea to have a wall of text as the first thing developers see, but again that's personal preference and if you think it's a good idea then let's do it.

Where do you think this should live on the microsite?

This was just a hack to get it displayed on the site, I'm not suggesting to add it to the homepage like this
Although, since users have said that they look at the homepage and have no idea what Workbox is about, it may be worthwhile to add some short (1-3 paragraph) overview on the homepage

+1 to adding like a TL;DR of this for home page and linking up to somewhere for this. Let me know if you want any help figuring out a home for this.

Although, since users have said that they look at the homepage and have no idea what Workbox is about, it may be worthwhile to add some short (1-3 paragraph) overview on the homepage

This is awesome. I think it would be immensely valuable for us to add that shorter summary overview on the homepage and as Matt suggested linking up to a longer overview doc. Would you be up for taking a stab at that @kaycebasques? 🍪

Hey @jeffposnick @gauntface @addyosmani I iterated on the Overview and tried to get it all to a shippable state:

For some reason the overview page doesn't build on prod builds, will dig into why soon

@gauntface it's because I'm using a pretty URL in the nav... we can change it to overview.html or see if Jekyll has a flag that we can switch

I'd prefer option 2 (enabling pretty URLs)

@kaycebasques reviewed. Very minor nits, but in general I love it ❤

@jeffposnick @gauntface plz leave comments in the markdown if you've got any feedback

and @philipwalton

Re: pretty URLs, let's keep them turned off and always include the .html extension in our links, as we ran into issues with our service worker caching when we had pretty URLs enabled in our Firebase config (see https://github.com/GoogleChrome/workbox-microsite/pull/67)

@jeffposnick let me know if the updates are good enough to meet your feedback points

I'm 👍
Thanks again for writing this up!

Somebody want to give me write access so I can merge PRs (after reviews)?

Looks like you've already got it, @kaycebasques (Someone else might have just added you?)


Faulty installation script and inadequate documentation regarding installation

I've had my developer friend tell me that the vscode playwright extension doesn't work. I figured if Microsoft supports it, it must. So I dug into the issue myself. I believe the problem is a slightly faulty installation script and inadequate documentation. See below for my journey and fix.
Personal Specs

Running on windows 11, WSL2 shell
I already have playwright and Chromium installed and successfully running tests outside of the VSCode extension.

Steps I took
After I install the extension, it successfully finds my tests and populates the left sidebar.
If I run tests, they fail immediately with no description as to why
The extension help page seems to suggest using VSCode's command ">Install playwright" is not necessary if you already have playwright installed (I installed it with yarn). Since it isn't working, I use the VSCode command and attempt to install playwright, chromium browser support and dependencies.
Most seems to install correctly, until this point:
Err:7 https://dl.yarnpkg.com/debian stable InRelease
  The following signatures couldn't be verified because the public key is not available: NO_PUBKEY 23E7166788B63E1E
Reading package lists... Done
W: GPG error: https://dl.yarnpkg.com/debian stable InRelease: The following signatures couldn't be verified because the public key is not available: NO_PUBKEY 23E7166788B63E1E
E: The repository 'https://dl.yarnpkg.com/debian stable InRelease' is not signed.
N: Updating from such a repository can't be done securely, and is therefore disabled by default.
N: See apt-secure(8) manpage for repository creation and user configuration details.
Failed to install browsers
Error: Installation process exited with code: 100
Error: Command failed: npx playwright install --with-deps chromium
    at checkExecSyncError (node:child_process:828:11)
    at execSync (node:child_process:899:15)
    at executeCommands (/home/talkingtoaj/.npm/_npx/d352e76cc6b4974c/node_modules/create-playwright/lib/index.js:4519:39)
    at Generator.run (/home/talkingtoaj/.npm/_npx/d352e76cc6b4974c/node_modules/create-playwright/lib/index.js:4592:5)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at async /home/talkingtoaj/.npm/_npx/d352e76cc6b4974c/node_modules/create-playwright/lib/index.js:4844:3 {
  status: 1,
  signal: null,
  output: [ null, null, null ],
  pid: 6509,
  stdout: null,
  stderr: null
}
npm ERR! code 1
npm ERR! path /home/talkingtoaj/GFGD_frontend
npm ERR! command failed
npm ERR! command sh -c create-playwright "--quiet" "--browser=chromium" "--install-deps"

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/talkingtoaj/.npm/_logs/2022-06-17T13_31_37_183Z-debug-0.log

It appears that there is a problem with unsigned debian package which prevents chromium from being installed?
If I try playwright extension again, still fails each test immediately. If I run in debug mode and have the test file open in the main window, I receive more info:
browserType.launch: Executable doesn't exist at /home/talkingtoaj/.cache/ms-playwright/chromium-1005/chrome-linux/chrome
╔═════════════════════════════════════════════════════════════════════════╗
║ Looks like Playwright Test or Playwright was just installed or updated. ║
║ Please run the following command to download new browsers: ║
║ ║
║ npx playwright install ║
║ ║
║ <3 Playwright Team ║
╚═══════════

So I try npx playwright install and it installs browsers chromium, firefox, webkit.
All works now!
Requested action
Better documentation:

Select to install playwright from Vscode command bar, even if you have previously installed playwright and browsers
If install process fails to install browser support, run npx playwright install from terminal to complete installation
Make it clear that you must have the playwright test file open in the main window in order to have the debug terminal open up and see debug output

The cause for why its miss-behaving is that your apt sources are "broken", (you need to add a key to trust your yarn apt sources). This ends up that the dependencies don't get installed.
Regarding the proposed action items:

We just published a new version which will select install dependencies by default if you don't have Playwright installed.
install is different to install-deps. Install-deps fails in your case, so it won't fix anything. See here for reference.
Do you mean this "Show output" button?


cmake: Handle visibility inconsistency

Currently the Bazel build marks the default visibility as off.

Currently the Bazel build marks the default visibility as off.

Here is the Bazel in question:
https://github.com/KhronosGroup/SPIRV-Tools/blob/30e51ceaab2d9f4b419e7602f740bf395f5ed636/BUILD.bazel#L18


Only use reaction text of quote tweet for sentiment

Now it can give wrong results because the text of the quoted tweet is being used

Apparently we already do this


Fix non-idiomatic usage of self in HTTP crate

Fix an instance of a non-idiomatic usage of self by replacing usage from Self::_foo(self, arg) with self._foo(arg).

There are a ton more of these that I've added if you want to get them

I'm pretty sure there are a ton more of these that I've added if you want to get them

I found only one other.


Compute statements_functions_map_for_tests only when profiling.

This change is

crates/cairo-lang-test-plugin/src/lib.rs line 200 at r1 (raw file):
Previously, piotmag769 (Piotr Magiera) wrote…
Incorrect comment

why is it incorrect?

crates/cairo-lang-test-plugin/src/lib.rs line 200 at r1 (raw file):
Previously, ilyalesokhin-starkware wrote…
why is it incorrect?

https://github.com/starkware-libs/cairo/blob/021408a9d509087e2cd49755130f4265fa11379a/crates/cairo-lang-sierra-generator/src/statements_locations.rs#L159


Remove use of the 'wc' command

Because 'wc' is unavailable on windows...
I couldn't test it on linux yet.

Ha! Thanks, I've opened a ticket earlier (#69) without knowing there was a PR about it.

Shameless bump!
I'm running into this problem as well.


Add Set Temperature and its tests in bulgarian language

Also closed and unclosed bracket in _common.yaml

There was a missing closing bracket in HA repository. This PR also resolves this bug.


Do not classify Infinity and NaN

Fixes #42022

Cool, improved the tests and made it only check for "Infinity" and not -Infinity (which didn't make a difference on the tests, so wasn't doing work anyway)


Fixed #82

Object and BasicObject are not looked up anymore.
I also figured out that if you try to derive a BasicObject instance, it results in a NoMethodError. But honestly, I don't see why somebody would try to derive a BasicObject so I'm not sure if this case should be treated and tested.

@plexus :smile: love your gifs!

It's pronounced jiff!


selectRow is not selecting a particaular row

I want to select the ith row of my grid, so passing $scope.gridOptions.data[i] entity as a parameter to selectRow function. But still that row is not selected. Is there any other configuration requires to set for the grid in order to enable row selection?

You need to include the selection module, and you need to wait until after the grid has rendered before you call the function.

I have include the "ui-grid-selection" module.  Still its not working. Below is the code -
//grid configurations
$scope.gridOptions = {
enableHorizontalScrollbar: 2,
enableVerticalScrollbar: 2,
gridHeight: 300,
minRowsToShow: 5,
enableRowSelection: true,
multiSelect: false,
enableGridMenu: true
};
$scope.gridOptions.data.splice(j, 1, data.server_groups[0]);
$scope.gridApi.selection.toggleRowSelection($scope.gridOptions.data[j]);
I want to replace a grid's row with the new entity. Once its done, I want to select that particular row.

Could you perhaps provide a plunker, which would then make it much easier to diagnose.  Perhaps base off the selection tutorial (click the "edit in plunker" button).

Plunker for the same - http://plnkr.co/edit/UiAuyBaChgkXkHj2XW2N?p=preview

OK, there are some things in your code that I don't quite understand, so I deleted an if condition....but the main problem is that you've loaded the data, but haven't given the grid time to actually process it.  So you're trying to select a row before the grid knows about it.
You can deal with this by using another interval, I've set it to zero ms, so it runs immediately after the digest cycle finishes.
http://plnkr.co/edit/W5ZLHEW02SIX4PNyVHw8?p=preview

Thanks alot :+1:


ran SAMPLE and failed

Every time I run SAMPLE, it fails and shows as below. What should I do with  DStarcmp.class? Can anyone help me with it? Thanks!
Undefined function or variable 'DStarcmp'.

Error in FDSInit (line 50)
    out.comparator = DStarcmp;

Error in SAMPLE (line 38)
        state = FDSInit(start, goal, maps{1}, scalling);

Unfortunately I don't own Matlab license anymore. Which version are you using? IIRC it was written in something around v2013.

Thanks for your reply! I am using MATLAB 2016a and I will try v2013. BTW, do I need to install any package before I run SAMPLE?

Ah, I remember, first java should be called in this folder. I'm using priority queue from java which gives nice performance boost.
%% init java, run at begin, once
% necessary to  load java files
% clear java
% javaclasspath(pwd)

But I don't remember how exactly use it, I didn't use it since I was a student.

That's really important! Don't worry I will try it out. Thanks for your reminder!

I just ran the this code and it works!  javaclasspath(pwd);  Thanks a lot for the tip!

Great!


no duration of audio/ogg files

there's no duration in metadata for audio/ogg

there's a problem with ffprobe if input is piped via stdin.
not so perfect solution is using metadata from tika.


Feature/618/96 dpf pool

What this PR changes/adds
Share a thread pool across all DPF transfers. Made number of threads configurable.
Instrument the thread pool with metrics.
Why it does that
This allows better control of resources.
Further notes
Had to introduce ExecutorInstrumentationImplementation class for better control of optional dependencies.
Linked Issue(s)
Relates to #96
Checklist

[x] added appropriate tests?
[x] performed checkstyle check locally?
[x] added/updated copyright headers?
[x] documented public classes/methods?
[x] added/updated relevant documentation?
[x] added relevant details to the changelog? (skip with label no-changelog)
[x] formatted title correctly? (take a look at the CONTRIBUTING and styleguide for details)

Codecov Report

Merging #162 (2dd0c58) into feature/618-dpf-pool (7fa65d3) will decrease coverage by 0.00%.
The diff coverage is 33.33%.

@@                    Coverage Diff                     @@
##             feature/618-dpf-pool     #162      +/-   ##
==========================================================
- Coverage                   60.07%   60.07%   -0.01%
+ Complexity                   2262     2261       -1
==========================================================
  Files                         607      608       +1
  Lines                       13071    13076       +5
  Branches                      912      912
==========================================================
+ Hits                         7853     7856       +3
- Misses                       4792     4794       +2
  Partials                      426      426

Impacted Files
Coverage Δ

...e/azurestorage/DataPlaneAzureStorageExtension.java
0.00% <0.00%> (ø)

...nnector/dataplane/http/DataPlaneHttpExtension.java
0.00% <0.00%> (ø)

...pipeline/DataTransferExecutorServiceContainer.java
0.00% <0.00%> (ø)

...taplane/framework/DataPlaneFrameworkExtension.java
74.28% <100.00%> (+2.41%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fa65d3...2dd0c58. Read the comment docs.

./gradlew :launchers:data-plane-server:run fails
org.eclipse.dataspaceconnector.spi.system.injection.EdcInjectionException: The following injected fields were not provided:
Field "executorInstrumentation" of type [interface org.eclipse.dataspaceconnector.spi.system.ExecutorInstrumentation] required by org.eclipse.dataspaceconnector.dataplane.framework.DataPlaneFrameworkExtension

Starting review on this.

@algattik DataPlaneManagerImpl also has an Executors.newFixedThreadPool under start method. That will also be good to be instrumented with micrometer. What do you think ?

@algattik DataPlaneManagerImpl also has an Executors.newFixedThreadPool under start method. That will also be good to be instrumented with micrometer. What do you think ?

Thanks, implemented


Update-Module BcContainerHelper throws error "Access to the cloud file is denied"

Issue
Since today I am getting the error "Access to the cloud file is denied" when executing the following PowerShell script
Scripts used to create container and cause the issue
Update-Module -Name bccontainerhelper -force

Last week I did not encounter this issue.
Searching for the error on the internet I cam across this post: https://docs.microsoft.com/en-us/answers/questions/328264/access-to-the-cloud-file-is-denied-when-install-az.html which led me to https://docs.microsoft.com/en-us/powershell/scripting/gallery/installing-psget?view=powershell-7.2. From which I tried various things to see if that could fix it:

https://docs.microsoft.com/en-us/powershell/scripting/gallery/installing-psget?view=powershell-7.2#system-requirements
https://docs.microsoft.com/en-us/powershell/scripting/gallery/installing-psget?view=powershell-7.2#installing-the-latest-version-of-powershellget
But all to no avail. Still getting the same error.

Not being a PowerShell geek I am out of options right now. SO, I decided to log this issue. Maybe not related to BCContainerHelper as such, but surely someone out here has a simple pointer on how to solve this. Thanx in advance.

Executing one by one:
PS C:\Windows\system32> Remove-Module BcContainerHelper
Remove-Module : No modules were removed. Verify that the specification of modules to remove is correct and those module
s exist in the runspace.
At line:1 char:1
+ Remove-Module BcContainerHelper
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : ResourceUnavailable: (:) [Remove-Module], InvalidOperationException
    + FullyQualifiedErrorId : Modules_NoModulesRemoved,Microsoft.PowerShell.Commands.RemoveModuleCommand

PS C:\Windows\system32> UnInstall-Module BcContainerHelper -allversions
PackageManagement\Uninstall-Package : Access to the cloud file is denied
At C:\Program Files\WindowsPowerShell\Modules\PowerShellGet\2.2.5\PSModule.psm1:12733 char:21
+ ...        $null = PackageManagement\Uninstall-Package @PSBoundParameters
+                    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (Microsoft.Power...ninstallPackage:UninstallPackage) [Uninstall-Package],
   Exception
    + FullyQualifiedErrorId : System.ComponentModel.Win32Exception,Microsoft.PowerShell.Commands.RemoveItemCommand,Mic
   rosoft.PowerShell.PackageManagement.Cmdlets.UninstallPackage

Ok, let's try a new one
Close all powershell sessions.
Open Windows Explorer and remove the BcContainerHelper folder from these 3 locations:
C:\Users\<username>\Documents\WindowsPowerShell\Modules
C:\Program Files\WindowsPowerShell\Modules
C:\Windows\system32\WindowsPowerShell\v1.0\Modules

Thanx. Knew that I could remove some directories, but did not recall which.
Also ran Update-Module -Name bccontainerhelper -force gettting now a expected response
WARNING: The version '3.0.8' of module 'BcContainerHelper' is currently in use. Retry the operation after closing the applications.


feat: fill_with

Hi DougLau,
I want to use footile for masking or applying effects etc. And I thought something like fill_with could work.
I'm not exactly happy with my naming as well as the fact that trait user needs to implement their own scan_even_odd and scan_non_zero
I'm open to improve my proposal with your guidance in case you also think, that such a feature would be interesting for footile
cheers,
anvlkv

I guess that should be better. Curious what do you think about it.
Thank you for the awesome crate!


Autocomplete in mobile

[x] The issue is present in the latest release.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯

Expected Behavior 🤔

Steps to Reproduce 🕹

Steps:
1.go to demo page (https://material-ui.com/components/autocomplete/)
2. Open Inspect window and go to the mobile screen (eg iPhone X)
3. Check when hovering  on the options in the list
4. Sometimes the when selecting the option from the list , the onChange function returns undefined
Context 🔦

Your Environment 🌎
On the mobile screen only

Tech
Version

Material-UI
v4.6.1

React
16.10.1

Browser
chrome,fierfox, etc.

TypeScript

etc.

The issue has been closed because it does not conform to our issue requirements.
Please provide a full reproduction test case. This would help a lot 👷 .
A live example would be perfect. This codesandbox.io template may be a good starting point. Thank you!
tip: the first value of the onChange is the event while the second is the new value.

reproducing link : https://u7s12.csb.app/
steps: 1. open inspect window
2. select iPhone X screen
3. try select option from list
In firefox selecting not working using touchpad/mouse
in chrome , the hover on the option not working

I can reproduce one issue. The option hover state shouldn't be persistent on the second disableCloseOnSelect demo.

Actually, my bad, it looks OK.

please check screen shot. I selected one option from the list using touchpad (not keyboard) .But the option is not showing in the box. This happens in firefox. Please use this sandbox links.
https://u7s12.csb.app/ (preview -> open this for reproduce bug)
https://codesandbox.io/s/u7s12 (code)


Custom Element without VM not working in CEF

I'm submitting a bug report
Please tell us about your environment:

Operating System:
Windows 10

JSPM OR Webpack AND Version
JSPM

Browser:
Chromium 49

Language:
TypeScript

Current behavior:
It works in browser and Electron, in CEF I don't see any error message,, just debug:
DEBUG [templating] importing resources for file://location/to/my/file.html

When I create a class (VM) and change my code from:
<require "./file.html">

to:
<require "./file">

It works. Maybe it's a problem with a protocol.

This is very odd. Please let us know if you are able to track down what is causing this more specifically.

@tomasbonco is this still an issue?

I didn't had time to dig into it, but we're going to switch to https protocol, so I'll try it then, and let you know.

After updating CEF, it works. Can be closed.


i had issus but when deleting some codes in it . It worked awesome

I'm submitting a

Current behavior

Expected behavior

Minimal reproduction of the problem with instructions

What is the motivation / use case for changing the behavior

Environment

ueuadfasdh]


Add support for PowerPC VMX128 instructions

The addition of VMX128 instructions will be essential for successful disassembly of Xbox 360 game executables, which is why I request the addition of said CPU instructions.
The attached file contains the opcodes necessary for implementation:
vmx128.txt

#2094

Duplicate of #2094

@pcgamer31098: What's the Xbox 360 emulation scene like? That might be a better place to get started regarding the missing instructions. I found this one: https://github.com/xenia-project

@pjsoberoi The file I attached contains the opcodes for the VMX128 extension. I was looking for this extension to be implemented as a Ghidra "Sleigh" processor module so these instructions can be generated into p-code.

The Xenia project has disassembly for the VMX128 instructions. I'm taking a look at that.

@pcgamer31098: I checked in support for disassembling the vector load instructions into my branch: https://github.com/pjsoberoi/ghidra/tree/master/Ghidra/Processors/PowerPC. I haven't started on P-Code yet.
Would you mind testing? The processor is PowerPC:Xenon.

@pjsoberoi I tried opening a XEX file with your processor module and most instructions still weren't disassembled.

@pjsoberoi By the way, do you have a Discord profile or any other social account that I can message you on?

@pjsoberoi I tried opening a XEX file with your processor module and most instructions still weren't disassembled.

First checkin was lvewx128 - lvxl128. I just checked in stewx128 - stvxl128.

@pjsoberoi By the way, do you have a Discord profile or any other social account that I can message you on?

You can message me on Discord @pjsoberoi.

@pjsoberoi What is your account number # after the username?

Sorry about that, pjsoberoi#5101.


Improve speed of builds

Library Affected:
sw-appcache-behavior, sw-offline-google-analytics, etc.
A full build currently takes between 10-30 minutes to complete on Travis:

On AppVeyor/Windows, we're looking at it taking multiple minutes too.

For smaller PRs, this introduces a bit of a bottleneck for folks that are trying to land incremental work at a decent pace.

sw-precaching
sw-background-sync-queue

appear to take a while.
Some areas for exploration:

Could we speed up the build by reducing our reliance on babel? drop async/await
Are we holding RollUp wrong? We might be able to squeeze some wins out by disabling features like tree-shaking
Downloading browsers (although I believe cached..) appears to take 500+ms per package:

FWIW, a unscientific experiment on 4 year old Mac shows that removing async/await transpilation takes the sw-lib build time from 17s down to 15s, and shaves ~1.1kb from the final output size of the minified umd bundle.
Removing babili minification (which I'm not suggesting we remove) takes the build time from 17s down to 13s.
sw-background-sync-queue is a bit of an extreme case, since it requires bundling a whole bunch of individual modules for testing purposes during the build. Perhaps @prateekbh could provide some context as to whether that's really necessary, and if not, it could be rewritten to follow the patterns used by the other modules?

https://github.com/GoogleChrome/sw-helpers/pull/485 should have helped, particular with the speed of sw-offline-google-analytics and sw-background-sync-queue builds.
A lot of the latency in those screenshots has to do with running code in a throttled CI build environment, as you can see total build times vary by up to an hour depending on what the Travis infrastructure is up to: https://travis-ci.org/GoogleChrome/sw-helpers/builds

@jeffposnick as of now I can see some really super fast builds on my local. I'll see if I can work with a single build itself

I'm going to close this, I think between my testing re-write and Jeffs build tidy up, the builds are more bearable.

💨


[SPARK-18105] fix buffer overflow in LZ4

What changes were proposed in this pull request?
In the LZ4BlockInputStream, there is a mistake that it use the originalLen as compressedLen, in the case that the compressed data is longer than original data, then compressedBuffer could overflow (some InputStream may does not check that), which cause it failed to decompress the buffer.
File a issue in uptream: https://github.com/jpountz/lz4-java/issues/89
How was this patch tested?
Can't generate some dataset to reproduce this bug, will test it manually.

Test build #67540 has started for PR 15632 at commit e5a9abe.

Ah, nice catch !
LGTM, can you merge it when build it done ? Thx.

Out of curiosity

@srowen I think it's a matter of how fast upstream publishes a new version, and we can make sure that everything works

+1 for @srowen's comment. There are no test cases for this class in Spark. Since LZ4 is used by default, changing such a core class without any test case sounds risky.

@srowen The last update to the upstream library was 1.5+ years ago. Is it still maintained ?
You are right, pushing it there and getting it released it might be good - if possible.

Test build #67540 has finished for PR 15632 at commit e5a9abe.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67540/
Test PASSed.

Thanks to @viirya, this is a false alarm, I will continue to looking for the real cause.
@srowen The reason we have a fork here is that the upstream does not support concated stream, we send a patch for it a year ago but that is still open. We have some tests to cover concated stream on Spark side (not a unit test for LZ4).

@davies that check looks wrong - behaviorally we might not be hitting it
due to other preconditions enforced ; worrying to see this
On Oct 26, 2016 10:18 AM, "Davies Liu"<EMAIL_ADDRESS>wrote:

Thanks to @viirya https://github.com/viirya, this is a false alarm, I
will continue to looking for the real cause.
@srowen https://github.com/srowen The reason we have a fork here is
that the upstream does not support concated stream, we send a patch for it
a year ago but that is still open. We have some tests to cover concated
stream on Spark side (not a unit test for LZ4).
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/apache/spark/pull/15632#issuecomment-256417065, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABhJlABWaV6OhI6D-QFWIYk8AwwiuNwkks5q34tPgaJpZM4KgnQm
.


[Addition]: 36 Hotspots in same wallet went online the same day and only witness each other. All Panther X

Hotspot b58 Addresses
11cTJ9sNja48tcR1nUS636oKU2qew5P5wb8BuoYhSWMZLP2MMXJ
11nxeq2r2eJzMt3iBbpWhude3JA91Ue4LJgpsbfC3uvid1XVBU2
11637SXanpdiwy4zuVJLPzbJzqS29Jn8ccGq8rgXgB4mqdzrJgP
11bwcXdZ3NeCxJAcYhRg3CaRBm9CwnZJXK7yATBbXSyFiVPSKKu
11DsqjNvAs9MSPKNDSjhDwHumUzvQojnCEhZtzBYE41RonHWCX4
11289cW1FCodZawYvcDn6FP41oPdcrtaJwCCewFEMWp7bUqavgx1
11P9ZUq28BxAaKo2fxHD4V2khwwTbpVMwmvhN2t5hZgc6kzLD4M
11AgnN4XG7KuW8a5yhQsBPegfNtzRWZJ6qb3rHCn2jxqQHfdWCt
11cnW8Pzp39Aos9EosZgoM5y5r5Zo8Thp7LK99R9o5Kyovd7cs7
112rJRnJ3SXV6AmrpBsp281gYgh3L5Yoq92sv3b4egYHZM88AUa8
11bxjyd71acZd1s73GtC82pH4kUr9rYcX2JnxB6r5cExFouZQjD
11ueczpgVY8yUECYBsXHdYBxdJw1t2xeLATHb1Mp6HgG2KSbexB
112qQn6cXF3xefH7VYJZautu5iSsPVHC9X6ZGuexitsmpYc2M7VS
11CnT46kCj4KiS2UB55zaSZ39Q8efbLQC3k38qvRGW87TPXctvs
112DRgGkfgGmnQEm5XYUTjbRRSSzficFTXuKEuDdVmT57c5GdnTe
112Yc1qRr3REq5JUYiUoKNR6JKvr5AtszEgfs677MGhLcap6C8G1
11UxcCNs8H6B2wHCeLYdyjCnn5K1jT4KjaeatJyhpRZkrbt6Mkj
112md22TKErxjBCgoDKQJDVJ1gTppjkHxjqQUQ6qHvEKWNnZ2PgS
112vtgLTbmUSVzPXQ6hnpmGxXr1SWwxmpin5bUMdBXvQ8DLCfZ2k
1197uoUsPUEaZ2nm7t1SXSoZiYmDxg5gpdA3dJZBC3HwGb9ZAnb
11NceSf59MGfxaD65xWty442rLBi66LMDhACH3B2jDiKGywQ6Fp
11AhgjWS1MicAytTptTwufaa4vFJHigRRnstYBgvCpfjUxZmiBs
11ZkHa6vBpprX77pZMCMVfeR2BDGU8ikqgJ4hD61BCVKwEoENjP
112XQfY3YYeTi4xRkjhoR1ZwgdQsN4qMxSmRCSGBcJ4h88pLXDoi
112pWYQeGtEy9Fk6K4jBvFszGhULq1M6Ys466sFq5Azpszkpz5HB
114uXDE51djtDWQjvPKqR93bWnsS1VxFMGZpUV5Zw5MnoDRquM5
11NfnZRuEGTW5ab8EafbbGoMLbVkBMnZrwzfgLC2uAAwKcb4Yfo
11mcKV2THJKoKdpz1i1GRjuvbhZGLZ9ijtm2ahdEwzBEVHE3Ta1
11SbADhJibWEPjdMxnLf6bLHy89xadnA9yGaN2QhT1Tk7zMy9sL
11TQh9F4hzPMeTKgsDPABiZdzeNGbazaKB9vgRuEufp7MdVEnS6
11hFGo9QRoPmmLd6qDRnqesMpax2ZX3xpbLGf7xjLdjKiNWeKxn
11265F4dGHx4g4HSDiHLMEpKm35xPJfFQcNmkqkyD7gUTfyByrdN
11DHeotmCyibPJWj9anRkwP6M1MZUGAREVrhDghzhf8uxM29WcU
112KvkXnb3imi9aFDEG1UE4AsPGpfTBPQVdKZcNPcUkTRt2Ku1a
112wK9LCVSDXYGChJpy5iyCbA4SJqLGd2x9utSxR7rHgK84rPZ3v
119kZDWRagYWRC3zsiCtQYXWYE6SJPAF6DxkPTw1UU3629SEFWh
Discord Handle
im not a member of discord<EMAIL_ADDRESS>Reason(s)
All of these hotspots came on line the same day. That alone would have been a travel nightmare. They are all the same brand (PantherX). They are all in the same wallet. They only witness each other, no other adjacent hexes witness them. They are long distance witnesses with 1.2db gain antennas at 0 meter elevation. Already at 13 hnt

These are more sophisticated cheaters

What can be done about it? This affects us all
Sent from Mail for Windows
From: hexPi
Sent: Friday, April 22, 2022 10:46 PM
To: helium/denylist
Cc: UnkleSambo; Author
Subject: Re: [helium/denylist] [Addition]: 36 Hotspots in same wallet wentonline the same day and only witness each other. All Panther X (Issue #4216)
These are more sophisticated cheaters
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>

@CTH-Red-Team-Mapping-Service-I004 Can you help with PantherX cheaters in the US? They have all the same ingredients as the CN cheaters


docs: Document the syntax we use for autogenerating frontend forms from run function docstrings

Description:
The docstring syntax that we automatically translate into a form was undocumented. This PR adds documentation for it, so that users can self-serve their own form generation.
Is this change user facing?
YES

@mieubrisse this is excellent and I particularly like that you added in which primitives and complex data types we support as that isn't obvious otherwise


Counting the number of CompatHelper installations

I'm interested in answering the following questions for the packages in the General registry.
For the purpose of this analysis, let us define package X has CompatHelper installed as on the default branch of the Git repo for package X, there is a file named .github/workflows/CompatHelper.yml. (I'm open to a better definition.)

How many packages in the General registry have CompatHelper installed?
How many unique individual user accounts (i.e. not organization accounts) have CompatHelper installed on one or more of their packages?
How many unique organization accounts (i.e. not individual user accounts) have CompatHelper installed on one or more of their packages?

Would it be possible for me to use PackageAnalyzer.jl to help me answer these questions?

I think that in the future we may want to collect all filenames in .github/workflows, and exclude compathelper.yml, tagbot.yml only as part of data munging analysis, much like what we do now for the contributors (we were initially filtering out the bots, including @staticfloat), but honestly I'd like to avoid changing the data structure before JuliaCon.


After deploy Bot with composer, Luis has no endpoints hits not even is possible to Review Endpoint Utterances

After deploy Bot with composer, Luis has no endpoints hits not even is possible to Review Endpoint Utterances

Version

Browser

[X] Electron distribution
[ ] Chrome
[ ] Safari
[ ] Firefox
[ ] Edge

OS

[ ] macOS
[X] Windows
[ ] Ubuntu

To Reproduce
Steps to reproduce the behavior:

Go to Composer
Create a new Bot
Create intents with LUIS (Language Understanding)
Add QnA
Change Language of bot to Pt-Br
Buil Bot and test em Bot Emulator
See hit-points in Luis in development Authoring resource
Click on Deploy
Follow steps explained in https://docs.microsoft.com/en-us/composer/how-to-publish-bot
Check that a new Authoring resource is created for LUIS
Test your bot in Web Page using token of Bot Channel created automaticaly in deploy
Check if Luis in Authoring resource generated by deploy have hits

Expected behavior
Luis - Language Understanding in Authoring resource generated automaticaly in deploy have hits and possibility to Review Endpoint Utterances
Screenshots
1. Luis with Authoring resource used in Bot Framework Composer has hits after testing in emulator

2. After deploy with composer, a new Luis a new Authoring resource is created but never gets hit when using web channel token

Additional context
Language used is PT-BR

@SantiagoMadeira, thanks for reporting this. I will attempt a repro on my end and update the thread accordingly

hi,
I think I found a common factor between this issue and another one I reported #4458
Was using PT-BR as the defaultLanguage in Composer settings, and whenever I use that configuration I have these errors. When changing to defaultLanguage = 'en-us' everything works fine!
The final test I did was:

configure Composer with only defaultLanguage = 'en-us', both issues work well.
added PT-BR in Composer, rebuild bot in Composer. After that in LUIS a new APP was created for PT-BR.
Without changing defaultLanguage in Composer it continued to work correctly.
In Composer remove language 'en-us' and set PT-BR as default, rebuild,  both issues work well (in this point have two Apps in Luis)
In LUIS I removed APP for language 'en-us' (well, at this point i'm not using that language in Composer) and just stayed with APP for PT-BR, and without rebuilding Composer and without Deploy for Azure... KABOOM! The error reappeared.
I added APP for language 'en-us' in LUIS, everything worked fine again.

I think there is a problem when defining a default language other than 'en-us'
Now i'm working only with defaultLanguage='en-us' in Composer and everithing runs smooth

Adding @feich-ms for pointers

Hi @SantiagoMadeira, from my observations, there are some delays for the hits data in luis.ai portal even for local tests. Can you verify again that the hit counts is still 0 after a period of time?

Closing the issue. Please feel free to reopen if the issue persists.


pango-querymodules > '/etc/pango/pango.modules'

Describe the bug
While trying to install a gog program via steam-run ./gog_hyper_light_drifter_<IP_ADDRESS>.sh, I got:
(mojosetup:7374): Gtk-WARNING **: Unable to locate theme engine in module_path: "pixmap",

(mojosetup:7374): Gtk-WARNING **: Could not find the icon 'system-software-installer'. The 'hicolor' theme
was not found either, perhaps you need to install it.
You can get a copy from:
	http://icon-theme.freedesktop.org/releases

(mojosetup:7374): Pango-CRITICAL **: No modules found:
No builtin or dynamically loaded modules were found.
PangoFc will not work correctly.
This probably means there was an error in the creation of:
  '/etc/pango/pango.modules'
You should create this file by running:
  pango-querymodules > '/etc/pango/pango.modules'

(mojosetup:7374): Pango-WARNING **: failed to choose a font, expect ugly output. engine-type='PangoRenderFc', script='latin'

(mojosetup:7374): Pango-WARNING **: failed to choose a font, expect ugly output. engine-type='PangoRenderFc', script='common'

The installer runs fine but shows squares instead of proper characters.
This is on nixos-unstable. I tried to nix-locate a pango-querymodules zihtout success. I might look into it later but post his in case someone already has a solution.

https://github.com/GNOME/pango/commit/fa6dfc688c293fa02c36ee89ac5611fd5e0131a5

thus in absence of this pango-querymodules, how can I work around the error ?

It must be using a pango shipped with the game because pango in Nixpkgs does not even have the code for loading the modules: https://github.com/GNOME/pango/commit/7d30b3f91958a3ff45ee2b8e5de2b6186cadfb72 So hopefully, it would also contain pango-querymodules or something.
I would try extracting the archive and looking how pango is linked (and trying to replace it with system one if it is dynamically linked, hoping ABI did not change).
But I doubt it will work on any other distro without work.

Here I found a mention of this issue in IRC logs: https://logs.nix.samueldr.com/nixos/2018-02-03#884288;

thanks ! dont have time to test now but sounds promising !


Designer vs developer podcast

Adding a new podcast to the shows section, this will be updated once the videos go live.

Are we good to go? could I get this merged? I'd like to submit the XML feed to feedburner : )


Does not provide instructions for iPad / iPhone App

There are multiple users in our environment that need to use the iPad RDP client to connect to their desktops, please provide instructions on how this can be done.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 72e1cc18-3fc2-d7fa-7ff3-20fc9a3596d4
Version Independent ID: 8ed24664-ce8c-7c08-654a-d3ef267f274f
Content: Connect to remote Azure Active Directory-joined PC (Windows 10)
Content Source: windows/client-management/connect-to-remote-aadj-pc.md
Product: w10
GitHub Login: @jdeckerMS
Microsoft Alias: jdecker

You can find instructions for using Remote Desktop on iOS here: https://docs.microsoft.com/en-us/windows-server/remote/remote-desktop-services/clients/remote-desktop-ios


[UI] Bulk delete should exclude services bound to applications in Configuration page

Issue:
Currently in the UI an app bound to an application, with an existing configuration, can be selected when doing bulk delete (even when it will not be deleted):

Expected behavior:
Perhaps one solution could be preventing the bound service to application from being selected.

The selection is used to provide rows to all bulk action buttons. For this table though there is only one. When hovering over the delete button the user will be told it will only apply to some of the selection.

Yes, but it may result a bit confusing making the UX not so smooth to the end user. As an user, I think it makes sense that if an user should not able to perform an action, besides a message when hovering, it would nice the he/she is actually prevented from doing so. The message may not be the first thing to be read. I actually happened to me; I was focused in deleting the items and I did not realize about that message appearing during hovering.


Update React peer dependency

Update React peer dependency to include v17. Without this change everything is working fine but "incorrect peer dependency" warning appears in the console.
I think no CI change is necessary to run tests over React v16 and v17?

:tada: This PR is included in version 2.26.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 3.2.0-beta.24 :tada:
The release is available on:

npm package (@beta dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[5.3] Allow Gate to explicitly check abilities for guests

See #10568
Currently, the Gate immediately denies abilities if there is no authenticated user. This PR makes it possible to allow abilities to be checked for guests (closure abilities or abilities in policies).
Say for example, We want to allow guests to comment on posts but we may change our mind in the future, So if we don't use an ability for commenting at all, Then in the future when we change our mind we have to update the views and/or controllers.
But now we can use an ability for commenting and we can mark it to be checked for guests, Then in the future when we change our mind we only have to change the ability's logic.
Closure abilities
By default, when we define an ability as normal, If no user is logged-in, it will immediately deny the ability:
$gate->define('update-article', function ($user, Article $article) {
    // If no user is logged-in, the guest will be denied before reaching here
    return $user->id === $article->user_id;
});

but if we want to mark the ability to be checked for guests, We can pass true to the third parameter (includeGuest) :
$gate->define('show-article', function ($user, Article $article) {
    // If user is logged-in or not, this ability will be check because we told it so
    return $user || $article->visibility == 'all';
}, true);

Note The same applies for the before and after methods, If we want them to be called for guests we have to explicitly tell it so, Meaning that if we have an ability that is marked to be checked for guests, Then when this ability is called, It will be interrupted only by the before methods which are marked to be called with guests.
Note In case of guest, The $user parameter will be null.
Policies
For abilities in policies, To mark any of them to be checked for guests, We can add an attribute named $includeGuest and include the names for the abilities that we want them to be checked for guests :
// app/policies/ArticlePolicy.php

namespace App\Policies;

use App\Models\Article;

class ArticlePolicy
{
    /**
     * Array of abilities allowed to be checked for guests
     *
     * @var array
     */
    public $includeGuest = ['index', 'view'];

    /**
     * Ability to show index page
     *
     * @return bool
     */
    public function index()
    {
        return true;
    }

    /**
     * Ability to view specific article
     *
     * @param  User|Null  $user
     * @param  Article $article
     * @return bool
     */
    public function view($user, Article $article)
    {
        // View all articles for the users, but only articles with 'all' visibility level for guests
        return $user || $article->visibility == 'all';
    }

    /**
     * Ability to create new article
     *
     * @param  User  $user
     * @param  Article $article
     * @return bool
     */
    public function create($user)
    {
        return $user->isAdmin;
    }

    /**
     * Ability to edit specific article
     *
     * @param  User  $user
     * @param  Article $article
     * @return bool
     */
    public function edit($user, Article $article)
    {
        return $user->id === $article->user_id;
    }

    /**
     * Ability to delete specific article
     *
     * @param  User  $user
     * @param  Article $article
     * @return bool
     */
    public function delete($user, Article $article)
    {
        return $user->id === $article->user_id;
    }
}

Note Like closure abilities, If the before method is not included in the $includeGuest attribute, It will not be called with guests.
The benefit of allowing abilities to be checked for guests

This way we can always have abilities like index and view in our policies and making them default to allow all users and guests, And change them when we want, For example if we decide to restrict some page to be only accessible for users (or admins), Then we can remove the index item from the includeGuest attribute and add some logic in the ability.

Also it will make it easy to give partial abilities for guests

And leads for good practice when letting the Gate responsible for all the permissions, Even if one of them is currently allowed for all users and guests and could be removed.

Also will allow (in the future) to use the abilities instead of some middlewares (like the Auth middleware), So we won't have to add the Auth middleware on the routes we want to allow only for users , This should be the responsibility of the Gate to determine.

Again, we never make users pass a boolean parameter.

I was going for $gate->allowGuest('ability-name'); but that's won't work with the before and after filters because one may register any number of them :
https://github.com/laravel/framework/blob/5.3/src/Illuminate/Auth/Access/Gate.php#L147
So I can't do $gate->allowGuest('before');.
But there's an idea came to my mind here, We may solve this by chaining the definition of the ability with a method to allowGuest for the last defined ability, Something like that :
$gate->define('show-article', function ($user, Article $article) {
    //
})->allowGuest();

and the same for before filter :
$gate->before(function ($user, Article $article) {
    //
})->allowGuest();

But just note this way calling $gate->allowGuest(); anytime will mark the last defined ability to be called with guests.
We may also use the parameter abroche but maybe passing an array of options to make the user type allowGuest by his hand .. would be like that :
$gate->define('show-article', function ($user, Article $article) {
    //
}, ['allowGuest' => true])

@taylorotwell
What do you think about that?
Do you have a better suggestions to make it work with both ability and filters in a consistent way?

Also, Do you have a better name for allowGuest that shows we are allowing the ability to be checked with guests, Not allowing the ability to be absolutely given to guests.

@mmghv To solve the problem you're running into, would you be able to just update your base request class to resolve a User that is flagged as a guest instead of returning a null? Then you could simply leverage something like isGuest() right on that object?

@Jaspaul The problem is not how to make the ability accept a guest user (which is basically null), It's how can the developer mark an ability to be called with guests, The default behavior MUST stay the same (which is guests are immediately denied the ability [If not told otherwise]).
Beside, If $user is an object, It should correspond to an authenticated user, Otherwise it's a BC break.

@mmghv I was suggesting that you modify your application code instead of changing the underlying framework. You would likely have to update a few of your policies to work, based on the example you've provided, but the changes should be minor.

@Jaspaul Of course this is up to the developer he can do that, Actually some of who wanted this feature did something similar to that, But it's a bit of extra work and would be nice if the framework supports this feature out of the box, Beside, If it's done the way you suggests, It won't provide some of other later benefits and best-practices that the framework can provide out of the box (like including the index ability by default with the ResourceAbilityMap)

Wouldn't this introduce unwanted behavior? Let's say I defined can-comment ability and allowed it for the guest, logged in user goes to a post and makes a comment - no problem, now the logged in user goes to take coffee or something, leaves the page too long, sessions expires, get's back and makes another comment - what would happen is that he made a comment as a guest without even knowing. How would this be handled? the example is probably terrible but I bet it's valid.

@donnysim Of course that's the developer problem if he decided to allow guests to comment,  here I'm not suggesting you allow abilities for guests, I'm just making sure you can do so when this is the desired behavior.
And to answer your question, I would make sure that guest commenting is distinguished from users,  Maybe a note below the input and the user profile picture

But you basically write policy map in AuthServiceProvider, if you'd define closure abilities, probably would do it in AuthServiceProvider, so what prevents you from adding separate array with abilities for guests in gate and then just checking it when user is null instead?
    protected $guestAbilities = [];

   ....

        if (!$user) {
            if (isset($this->guestAbilities[$ability . '-' . $arugments[0]]) {  // some logic to resolve ability and model etc
                 return true;
            }

            return false;
        }

That's perfectly okay with abilities, but can't work with beforr and after filters because it might be more than one filter, the gate allows so, so i need a way that is consistent with abilities and before filters.

But it wouldn't reach before and after filter if you check on if (!$user) {. What would you do in before/after filter for guests anyway? Check their IP and deny based on that?

Wouldn't it be better to separate user and guest behaviors then instead of trying to clump them together?   I mean where it works for one or the other, not both, and by that I mean if it's guest, authenticated checks are ignored, if it's authenticated user - guest checks are ignored. And maybe I want to have guestResolver where it passes a Guest object which contains some information or methods, which I actually did have a though about, but never decided if it's worth making.

You mean we define two add-comment abilities one is checked if user is authenticated and one if it's guest? I guess that would be harder than doing something like this :
$gate->define('show-article', function ($user, Article $article) {
    return $user || $article->visibility = 'all';
}, true);

I didn't specifically had in mind that you'd specify it twice, for policy it could check if guestIndex method exists for guests and index method for , etc.. didn't think about closures as I never used them in any project.

That seems a good idea for policies but I can't think of a consistent way to do the same with closure abilities without repeating ourselfs especially most of the time the logic in the ability is just simple.

I'm just not a big fan of this approach I don't think.

IMO the whole point of authorization is that there is some unique thing about the given user that does or does not give them permission to perform X. All guests can inherently perform the same actions as all other guests.

@taylorotwell

All guests can inherently perform the same actions as all other guests.

I guess you misunderstood the purpose of the PR, It doesn't distinguish one guest from another, It just allows you to set (chosen) abilities to be called with guests instead of immediately denying all abilities for guests.

If it's the boolean parameter I can redo the PR and make it work with chaining by making the define method return an Ability object and send this PR to the master branch .

is there a work around for that? i would like to use policies on guest users

@eduarguzher You will need to extend the Gate class to add the desired behavior then you need to override the the gate service provider Illuminate\Auth\AuthServiceProvider registered in config/app.php to register your own version of the Gate class.

@taylorotwell I have a use case that this enhancement would help to meet.
I have multiple levels of security for a multi-tenant site where each tenant can set documents to be available to the public or to members-only using a site setting in the database.   In addition, each individual document could be set to be accessible only to certain groups of logged in users.  So in essence, the policy would need to check if the document itself is secured to a group and if not it would check the site setting.  If the site setting says "public" then a guest would have access but if it is "members" it would require a logged in user.  This is not currently possible with policies since they don't get called for guests.

Authorization, in the context of abilities, gates, etc., doesn't make sense without an authenticated user. There are many ways to handle this. Seems like a good use case for a simple decorator.


Should FSA allow Symbol action types?

The Redux BDFL has mentioned before that Symbols as action types is a bad idea.
We're considering dropping support for Symbols in redux-actions, and wanted to cross-post that issue here since this is really about FSA shape.
Is anyone using Symbols as action types? What are the advantages over using strings? Standardizing on strings would lead to conceptual simplicity and potentially less special-casing.

@yangmillstheory my thoughts here: https://github.com/acdlite/redux-actions/issues/126#issuecomment-256832993 but I don't have a strong opinion either way so I'm fine with whatever the community decides :)

Thanks for bringing this up. I would vote for removing Symbol support for simplicity. Keep action serializable. 🌷

I'd also vote for removing Symbols since they are not serializable


bin/make_tarball.sh: use bsdtar instead of tar

When using tar with overlayfs it could happen that you end up with for example
a /bin folder with 0700 rights, while it should be 0755. This is caused by:

tar: bin: Directory renamed before its status could be extracted

This is a known issue: https://github.com/docker/hub-feedback/issues/727
In this case we have a "currupt" rootfs because the vcap user isn't able to do
anything anymore, because it's shell is /bin/bash (which is in /bin).
As a workaround we use bsdtar instead of tar. See:
https://github.com/coreos/bugs/issues/1095#issuecomment-292664145
Also generate a UTF-8 locale, so bsdtar can use it and you don't get:

bsdtar: Pathname can't be converted from UTF-8 to current locale.
bsdtar: <path/to/filename>: Can't translate pathname '<path/to/another_filename>' to UTF-8
bsdtar: <path/to/filename>: Can't translate linkname '<another_filename>' to UTF-8

Hi @pommi, thanks for the PR!
I'm not sure if we can take this as-is, because it modifies the host system and requires root privileges. I'll prioritize https://www.pivotaltracker.com/story/show/144610517 to investigate.

Hi @sclevine! Thanks for your quick follow-up!
This change only applies to the intermediate step (make cflinuxfs2.tar.gz) to create the tar.gz file using ./bin/make_tarball.sh. It spins up a docker instance and re-tar's the provided cflinuxfs2.tar file. ./bin/make_tarball.sh is only executed in this temporary docker instance.

Hello @pommi,
Our assumption here (based on reading the linked issues) is that the problem:

occurs occasionally
is that the .tar.gz file created by running make is bad

That is, the problem occurs while creating the .tar.gz file, not when extracting it later.
If this is the case, it may be better to add a check to bin/make_tarball.sh to confirm /bin was created with the proper permissions (or just fail if the tar command has any warnings)
We're not entirely comfortable switching to BSD tar if it's not absolutely necessary.

Hi @sesmith177,
Here is another issue that gives more in-depth information about the issue: https://github.com/moby/moby/issues/19647. So it's overlayfs that is causing behaviour that tar isn't able to handle.

occurs occasionally

In our case it happens in 100% of our builds. I have to say that we add another 1GB of stuff to our rootfs, which cloud make things worse.
And it's not only /usr that is wrong, but sometimes a lot more:
tar: usr/lib/x86_64-linux-gnu/mit-krb5: Directory renamed before its status could be extracted
tar: usr/lib/x86_64-linux-gnu: Directory renamed before its status could be extracted
tar: usr/lib/ssl: Directory renamed before its status could be extracted
tar: usr/lib/python3.4/config-3.4m-x86_64-linux-gnu: Directory renamed before its status could be extracted
tar: usr/lib/python3.4: Directory renamed before its status could be extracted
tar: usr/lib/python2.7: Directory renamed before its status could be extracted
tar: usr/lib/openblas-base: Directory renamed before its status could be extracted
tar: usr/lib/gold-ld: Directory renamed before its status could be extracted
tar: usr/lib/gcc/x86_64-linux-gnu/4.8: Directory renamed before its status could be extracted
tar: usr/lib/gcc/x86_64-linux-gnu: Directory renamed before its status could be extracted
tar: usr/lib/gcc: Directory renamed before its status could be extracted
tar: usr/lib/compat-ld: Directory renamed before its status could be extracted
tar: usr/lib: Directory renamed before its status could be extracted
tar: usr/include/krb5: Directory renamed before its status could be extracted
tar: usr/include/kadm5: Directory renamed before its status could be extracted
tar: usr/include/gssrpc: Directory renamed before its status could be extracted
tar: usr/include/gssapi: Directory renamed before its status could be extracted
tar: usr/include: Directory renamed before its status could be extracted
tar: usr/bin: Directory renamed before its status could be extracted
tar: sbin: Directory renamed before its status could be extracted
tar: opt: Directory renamed before its status could be extracted
tar: lib64: Directory renamed before its status could be extracted
tar: lib/systemd/system/sysinit.target.wants: Directory renamed before its status could be extracted
tar: lib/systemd/system/sockets.target.wants: Directory renamed before its status could be extracted
tar: lib/systemd/system: Directory renamed before its status could be extracted
tar: lib/systemd: Directory renamed before its status could be extracted
tar: lib: Directory renamed before its status could be extracted
tar: etc/systemd/system/multi-user.target.wants: Directory renamed before its status could be extracted
tar: etc/systemd/system: Directory renamed before its status could be extracted
tar: etc/systemd: Directory renamed before its status could be extracted
tar: etc/ssl/certs: Directory renamed before its status could be extracted
tar: etc/ssl: Directory renamed before its status could be extracted
tar: etc/rcS.d: Directory renamed before its status could be extracted
tar: etc/rc6.d: Directory renamed before its status could be extracted
tar: etc/rc5.d: Directory renamed before its status could be extracted
tar: etc/rc4.d: Directory renamed before its status could be extracted
tar: etc/rc3.d: Directory renamed before its status could be extracted
tar: etc/rc2.d: Directory renamed before its status could be extracted
tar: etc/rc1.d: Directory renamed before its status could be extracted
tar: etc/rc0.d: Directory renamed before its status could be extracted
tar: etc/newt: Directory renamed before its status could be extracted
tar: etc/network: Directory renamed before its status could be extracted
tar: etc/init.d: Directory renamed before its status could be extracted
tar: etc/fonts/conf.d: Directory renamed before its status could be extracted
tar: etc/fonts: Directory renamed before its status could be extracted
tar: etc/apparmor.d/disable: Directory renamed before its status could be extracted
tar: etc/apparmor.d: Directory renamed before its status could be extracted
tar: etc/apparmor/init/network-interface-security: Directory renamed before its status could be extracted
tar: etc/apparmor/init: Directory renamed before its status could be extracted
tar: etc/apparmor: Directory renamed before its status could be extracted
tar: etc/alternatives: Directory renamed before its status could be extracted
tar: etc: Directory renamed before its status could be extracted
tar: dev: Directory renamed before its status could be extracted
tar: bin: Directory renamed before its status could be extracted
tar: Exiting with failure status due to previous errors

is that the .tar.gz file created by running make is bad

That is, the problem occurs while creating the .tar.gz file, not when extracting it later.

True

If this is the case, it may be better to add a check to bin/make_tarball.sh to confirm /bin was created with the proper permissions (or just fail if the tar command has any warnings)

That would mean that we will not be able to build a cflinuxfs2 anymore, because this will check will always fail.

We're not entirely comfortable switching to BSD tar if it's not absolutely necessary.

Can you share your specific concerns?

I just created 2 builds (1 using tar, 1 using bsdtar), did tar -ztvf and compared the results: http://paste.debian.net/plainh/c2599140 As you can see bin/ and dev/ have wrong permissions, the rest looks fine.

Now I'm thinking about this, why don't we just do:
gzip -f tmp/cflinuxfs2.tar

instead of:
docker run --rm -w /cflinuxfs2 -v `pwd`:/cflinuxfs2 $(docker_image) ./bin/make_tarball.sh cflinuxfs2

In 5586ddcd8de0c86cbd0d24db8e5aaa9c33dcd285 it made sense, because there also were etc/hosts and etc/timezone that needed to be included, but those were removed in 7168dc07be80a43716a3adbcfde6ea8c9cbe6988.

Hello @pommi,
Just zipping the final file looks interesting; could you try replacing the final line of the makefile with
docker run -w /cflinuxfs2 -v `pwd`:/cflinuxfs2 "ubuntu:trusty" bash -c "gzip -f tmp/cflinuxfs2.tar && mv tmp/cflinuxfs2.tar.gz ."


Listeners incorrectly removed

Ultron removes listeners not added with Ultron when the listener is the same.
const EventEmitter = require('events');
const assert = require('assert');
const Ultron = require('.');

function listener() {}

const ee = new EventEmitter();
const ultron = new Ultron(ee);

ee.on('foo', listener);
ultron.on('foo', listener);

ultron.remove('foo');

assert.strictEqual(ee.listenerCount('foo'), 1);

The issue has been indirectly reported by @apapirovski in https://github.com/nodejs/node/pull/17440#discussion_r154526393.

I think that using Ultron to add an already existing listener on an event emitter or using the event emitter to add a listener already added with Ultron doesn't make much sense so this is probably an edge case, but still valid.

I think it's valid, I can PR this if you guys think it's cool! :smile:


shashlik: init at 0.9.3

Motivation for this change
Things done

[ ] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Closing until the software is fixed: https://github.com/shashlik/shashlik-build/issues/33


Menu option 'exit' is lowercase instead of title case

All other menu options are in title case, while the exit option is lower case. Please see image attached (disregard multiplayer as I am developing that right now).

I have implemented the fix in the following pull request: #9


Upgrade com.puppycrawl.tools:checkstyle 10.8.1 -> 10.9.0

This PR contains the following updates:

Package
Type
Update
Change

com.puppycrawl.tools:checkstyle (source)
build
minor
10.8.1 -> 10.9.0

[ ] If you want to rebase/retry this PR, check this box

Suggested commit message:
Upgrade Checkstyle 10.8.1 -> 10.9.0

See:
- https://checkstyle.sourceforge.io/releasenotes.html
- https://github.com/checkstyle/checkstyle/releases/tag/checkstyle-10.9.0
- https://github.com/checkstyle/checkstyle/compare/checkstyle-10.8.1...checkstyle-10.9.0

Version 10.9.1 also LGTM.


Can't return a value from a void function

I am having an issue as shown below.
compiler message: file:///Users/niyazitoros/.pub-cache/hosted/pub.dartlang.org/splashscreen-1.1.0/lib/splashscreen.dart:49:40: Warning: Can't return a value from a void function.
compiler message:           return **Navigator.of(context).pushReplacementNamed(widget.navigateAfterSeconds);**
compiler message:                                        ^
compiler message: file:///Users/niyazitoros/.pub-cache/hosted/pub.dartlang.org/splashscreen-1.1.0/lib/splashscreen.dart:51:40: Warning: Can't return a value from a void function.
compiler message:           r### eturn Navigator.of(context).pushReplacement(new MaterialPageRoute(builder: (BuildContext context) => widget.navigateAfterSeconds));
compiler message:

Niyazis-MBP:capital_splash niyazitoros$ dart --version
Dart VM version: 2.0.0-dev.69.5 (Tue Jul 31 15:05:14 2018 +0200) on "macos_x64"
Niyazis-MBP:capital_splash niyazitoros$ flutter --version
Flutter 0.8.2 • channel beta • https://github.com/flutter/flutter.git
Framework • revision 5ab9e70727 (3 weeks ago) • 2018-09-07 12:33:05 -0700
Engine • revision 58a1894a1c

Does this cause error to your app?

No, it doesnt cause any errro yet but it looks little bit anoying to see everytime in console, when I am trying to test my app. Thanks for great plugin anyway.

the fat arrow is just a syntactic sugar for one-line return statement. if you do the builder: (BuildContext context) { widget.navigateAfterSeconds(); then that wouldn't return anything at all.


How to solve the difficult in converge of molecules included heavy atoms

Hello, I’ve been working with PySCF to perform calculations on molecules containing heavy atoms, such as Sn(CH3)3. However, I’m encountering issues with convergence when using the B3LYP/def2-TZVPD level of theory. Could you provide some suggestions on how to address this problem, such as adjusting suitable parameters or methods?
Thank you very much for your help!

level shift and soscf. See https://pyscf.org/user/scf.html#converging-scf-iterations

level shift and soscf. See https://pyscf.org/user/scf.html#converging-scf-iterations

Thanks for your reply, the issue has been resolved.


Fix Rails 5 params deprecation warning

This approach uses a Rails Shim to handle formulating the params for a request to the app in integration tests, as discussed in https://github.com/westfieldlabs/apivore/pull/96#issuecomment-273587222, modeled after https://github.com/thoughtbot/shoulda-matchers/pull/989/files#diff-f46c5b61347eb8f9749762252d06fb52R29 but modified because we have to worry about headers as well (hence the Arrays and splatting).
I briefly considered moving the entire request out to a shimming object, but for whatever reason I couldn't get that to work.  If someone else can, it might be a cleaner approach.  Not sure it's worth driving ourselves crazy over, though.
I had some trouble getting older versions of Ruby to bundle locally for testing, but recent builds seem to work on Travis, so in this case I'm going to rely on Travis to confirm this works for Rails 4.

👍 when ✅

OK, so I'm not crazy.  The bundle isn't resolving for some older versions of Ruby.  This shouldn't have anything to do with my particular pull request.  Any ideas as to what's going on and how to fix it?

Tried to leave a 👍 on your review comment but apparently I can't.  So, in words: thanks so much for working out the dependency stuff!

Alright, I think this is ready to go!
Along the way, I made a quick fix to match a change to the json-schema gem, see https://github.com/ruby-json-schema/json-schema/commit/853d0dca72218d4c77efe069c256763ed118daf2 (Basically, instead of Ruby types like String, they now use JSON types like string.)  Without the change, the build was failing.
Let me know if you'd like me to make any further changes and/or squash commits.

Can we squash the commits down to two. One that covers the deprecation warning fix and tests and one for the additional spec mod for the failing build and I think ... that should do it.


Fix bip32 test

Solved by https://github.com/ArkEcosystem/ark-js/commit/294053703c8e592fff3ed9d53235ff4efb4619ca.