Add getTile function

Adding getTile function to provide fetching tile blobs by
TileKey with caching metadata support.
User can configure the TileRequest with specific catalog, layer and
version info and use getTile() function for fetch tiles.
Resolves: OLPEDGE-1668
Signed-off-by: Oleksii Zubko<EMAIL_ADDRESS>

Codecov Report

Merging #290 into master will decrease coverage by 2.8%.
The diff coverage is 15.3%.

@@           Coverage Diff            @@
##           master    #290     +/-   ##
========================================
- Coverage    89.3%   86.5%   -2.8%
========================================
  Files          61      63      +2
  Lines        1838    1910     +72
  Branches      238     249     +11
========================================
+ Hits         1641    1652     +11
- Misses        107     168     +61
  Partials       90      90

Impacted Files
Coverage Δ

...olp-sdk-dataservice-read/lib/client/TileRequest.ts
11.1% <11.1%> (ø)

...here/olp-sdk-dataservice-read/lib/utils/getTile.ts
14.0% <14.0%> (ø)

@here/olp-sdk-dataservice-read/lib/client/index.ts
100.0% <100.0%> (ø)

@here/olp-sdk-dataservice-read/lib/utils/index.ts
100.0% <100.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ea97a2...18b2e56. Read the comment docs.


support required for swift 4.2

Please fix library for swift 4.2

@devxoul Any updates on this?

@hujiaju doesn't work

@anonym24 support for Swift 4.2 (and Swift 5.0) is available on the master branch, so you can simply do:
pod 'Toaster', :git => 'https://github.com/devxoul/Toaster', :branch => 'master'

@Coeur well there is still issue about Objective-C

@anonym24 then it's not the right issue: you may want to create a separate issue, showing your Podfile, Podfile.lock and eventually a sample project demonstrating the problem. Also make sure you have use_frameworks! or explain why you don't.

Toaster doesn't support Objective-C since 2.0.0. (#89) You may create a bridge class to support Objective-C in your project.
import Toaster

 @objc class MyToast: NSObject {
  private let toast: Toast

   @objc init(text: String, delay: TimeInterval, duration: TimeInterval) {
    self.toast = Toast(text: text, delay: delay, duration: duration)
  }

   @objc func show() {
    self.toast.show()
  }
}

#import "MyApp-Swift.h"

[[[MyToast alloc] initWithText:@"Hello, world!" delay:0 duration:2.5] show];

We can continue this thread on the duplicate: #143

Version 2.2.0 was released and is compatible Swift 5.0 and Swift 4.2.


Grid visualization code

I see that your project home page provides a Grid visualization demo? Is the Grid visualization code open source?
In addition, what do Top, Lateral and Front mean?

We utilized matplotlib to display grids. Given that each grid contains more than three channels (except for non-masked grids), we applied principal component analysis (PCA) to distill three crucial components. Subsequently, we employed these three extracted channels for visualization.
Regarding the terms "top," "lateral," and "front," they simply serve as notations for representing each perpendicular planes.

I see that your project home page provides a Grid visualization demo? Is the Grid visualization code open source?
In addition, what do Top, Lateral and Front mean?

Thanks for your answer, I was wondering if you would like to share this part of the code, I really appreciate it. my email<EMAIL_ADDRESS>

Unfortunately, we do not have the visualization code at the moment. But it will not be difficult to implement. Sorry for that.

Unfortunately, we do not have the visualization code at the moment. But it will not be difficult to implement. Sorry for that.

ok,thank you!


DDAIG: different hyperparameters for different domains violates the DG settings

I notice that in https://github.com/KaiyangZhou/Dassl.pytorch/issues/12#issuecomment-712081804
The DDAIG (AAAI 2019) method uses different hyperparameters on different domains, which violates the original setting of domain generalization (The test domain is unseen.).
Fine tuning the hyperparameter for each domain will indirectly use the unseen target to improve the performance.
The real improvement of DDAIG method is unclear. And it is an unfair comparison with other SOTA results!

hi, thanks for your interest in our work
it's a very good question—indeed, it's still a difficult problem for param tuning in DG
in the existing work, people either 1) tune params on the test data to show the best they can achieve for their methods (otherwise how do you adjust the model design in prototyping?), or 2) use cross-val where the val images come from the held-out set of source domains
the 1st way is not wrong as you are not touching the test data at all during training. in practice you could prepare several models trained with different hyper-params, collect a small test dataset and deploy the model that has the best performance on it—the performance really matters for any applications so why not? for comparison, it's not uncommon to pick your best-performing model (I agree it sounds weird for DG)
the 2nd way doesn't make too much sense though I used it in another work. say you pick the best-performing model in the val data of source domains, it could well be the most overfitting one. therefore, the tradtional cross-val doesn't perfectly fit DG
this topic of param tuning could be a good direction to explore for future work if you'd like to :)

Thank you for your reply.
I think we need keep the hyper-parameters the same among different domains, because the compared performance of DG methods is the average accuracy on 4 leave-one-domain-out experiments. If we tune hyper-parameters per domain, the universality of proposed method is limited.
I agree with that sometimes we have to tune hyper-parameters by the test data, but use different hyper-parameters on different domains is a 'less' general way to deal with DG problem.

Came across this paper which discusses model selection for DG https://openreview.net/forum?id=lQdXeXDoWtI


IE issue

Hey guys,
I could really use some help. Almost done implementing my calendar but running into an issue in IE. Here is my post on stack overflow about it:
http://stackoverflow.com/questions/29133172/clndr-js-somehow-not-passing-full-days-events-data-to-template-only-in-ie

Hey, I can run a test on IE10 later today, but for now— your date format YYYY-M-D is not a valid format (you want to stick with ISO 8601. Your best shot is to use the format YYYY-MM-DD, where single digits are padded with zeros. So, rather than 2015-4-1, it would be 2015-04-01.
Could be a totally different issue, but it's worth checking out.

Wow man, Thanks so much for the quick answer. Right as I came back in to work xD
Yeah that did it, fixed the issue on IE for me. I didn't even think about that man. sigh..so glad haha. Thanks for the help!

:+1:


divides tts sentences

Hello there. Ive made the same issue before in a different account you may not remember it but you told me to do this:
const dividersSentence = /[\p{Extended_Pictographic}]/ug;
it was working fine but for some reason one day it divided the sentences again so i installed the latest version and made the same thing that i did in the old one but still didnt work. BTW here is the python server logs for knowing what is happening:

Serving Flask app 'apimain'
Debug mode: off
WARNING: This is a development server. Do not use it in a production deployment. Use a production WSGI server instead.
Running on http://<IP_ADDRESS>:6699
Press CTRL+C to quit
<IP_ADDRESS> - - [21/Jun/2024 22:52:26] "GET /login HTTP/1.1" 200 -
<IP_ADDRESS> - - [21/Jun/2024 22:52:26] "OPTIONS /moderation_ai HTTP/1.1" 200 -
<IP_ADDRESS> - - [21/Jun/2024 22:52:26] "POST /moderation_ai HTTP/1.1" 200 -
<IP_ADDRESS> - - [21/Jun/2024 22:52:26] "GET /login HTTP/1.1" 200 -
<IP_ADDRESS> - - [21/Jun/2024 22:52:26] "OPTIONS /chatbot HTTP/1.1" 200 -
Received request data: {'model': 'gpt-3.5-turbo', 'messages': [{'role': 'user', 'content': 'nick: hi there this is just a test.'}], 'temperature': 1, 'presence_penalty': 0, 'frequency_penalty': 0, 'max_tokens': 1000, 'stream': True}
Last message: {'role': 'user', 'content': 'nick: hi there this is just a test.'}
Content of last message: nick: hi there this is just a test. <-- my message
typing message
sent
Finding response...
Captcha button not found, proceeding without interaction.
Matches found:
2b: Hey there, no problem, just testing things out. Always good to make sure everything is working properly. winks <-- the response
Only one match found: 2b: Hey there, no problem, just testing things out. Always good to make sure everything is working properly. winks <-- it returns it to talking head
<IP_ADDRESS> - - [21/Jun/2024 22:52:39] "POST /chatbot HTTP/1.1" 200 -
<IP_ADDRESS> - - [21/Jun/2024 22:52:39] "GET /login HTTP/1.1" 200 -
<IP_ADDRESS> - - [21/Jun/2024 22:52:39] "GET /login HTTP/1.1" 200 -
<IP_ADDRESS> - - [21/Jun/2024 22:52:39] "OPTIONS /gtts HTTP/1.1" 200 -
<IP_ADDRESS> - - [21/Jun/2024 22:52:39] "OPTIONS /moderation_ai HTTP/1.1" 200 -
twob Hey there, no problem, just testing things out. <-- for some reason it divides it
<IP_ADDRESS> - - [21/Jun/2024 22:52:39] "POST /moderation_ai HTTP/1.1" 200 -
#generates audio
<IP_ADDRESS> - - [21/Jun/2024 22:53:22] "POST /gtts HTTP/1.1" 200 -
<IP_ADDRESS> - - [21/Jun/2024 22:53:25] "GET /login HTTP/1.1" 200 -
<IP_ADDRESS> - - [21/Jun/2024 22:53:25] "OPTIONS /gtts HTTP/1.1" 200 -
Always good to make sure everything is working properly. <-- divided sentence
#generates audio
Done.
<IP_ADDRESS> - - [21/Jun/2024 22:54:16] "POST /gtts HTTP/1.1" 200 -
<IP_ADDRESS> - - [21/Jun/2024 22:54:20] "GET /login HTTP/1.1" 200 -
<IP_ADDRESS> - - [21/Jun/2024 22:54:20] "OPTIONS /gtts HTTP/1.1" 200 -
winks <-- last divided sentence
#generates audio
<IP_ADDRESS> - - [21/Jun/2024 22:55:01] "POST /gtts HTTP/1.1" 200 -

so as you can see it divides the text and then sends it back and i dont want that bec it takes a long time (20s) generating the audio bec it uses a hugging face coqui tts through api so it will reaaaallly take a long time just to say something but when its not divided it will normally read it well. is there a way to divide it? (i tried const dividersSentence = /[\p{Extended_Pictographic}]/ug; but it still didnt work) Thanks!

If I remember correctly, you are using the speakText method. There haven't been any recent changes to that method, so if you don't want the method to divide the text into sentences, changing the line const dividersSentence = /[!\.\?\n\p{Extended_Pictographic}]/ug; to const dividersSentence = /[\p{Extended_Pictographic}]/ug; should be enough.
Browsers typically cache modules, so make sure that you are using the updated module. Assuming you are using Chrome, navigate to the page, open Developer Tools, right-click on the Reload button, and choose "Empty cache and hard reload".

thanks i think this worked i think but ive did this but it still didnt work even i deleted the whole browser data using ccleaner but for some reason it worked this time THANKS

im sorry for doing this too much but there is a problem look:

2b: Aw, Thanks, Nick. I owe you one now. waves
Only one match found: 2b: Aw, Thanks , Nick.  I owe you one now.
#generates voice
<IP_ADDRESS> - - [28/Jun/2024 20:47:07] "POST /gtts HTTP/1.1" 200 -
<IP_ADDRESS> - - [28/Jun/2024 20:47:12] "GET /login HTTP/1.1" 200 -
<IP_ADDRESS> - - [28/Jun/2024 20:47:12] "OPTIONS /gtts HTTP/1.1" 200 -
waves

now for some other reason it separates sentences between two *
can you help?

I couldn't reproduce your issue. I tested the phrase in my test environment by calling head.speakText("Aw, Thanks , Nick. I owe you one now. waves"). Without the code change, the class made three requests as expected, but with the change, it sent everything in one message without splitting.
I don't know your setup, but are you using any code from the test app index.html? If so, note that it also splits sentences to ensure the streaming response is sent as soon as possible but without splitting mid-sentence. For example, in openaiSendMessage method, there is a section with the following line:
let idx = Math.max(tts.lastIndexOf('.'), tts.lastIndexOf('!'), tts.lastIndexOf('?'), tts.lastIndexOf('\n'));

Now, if you have that in your code that could explain your issue. To prevent the split, just change the above line to let idx = -1.

well look it sometimes divides it and sometimes not but i think you didnt understand me well that last message it doesnt divide the (.-!-?-/n) but the words between two * like in this log:

2b: Aw, Thanks, Nick. I owe you one now. (waves) <------ between two **
Only one match found: 2b: Aw, Thanks , Nick.  I owe you one now. <-------- removed here
#generates voice
<IP_ADDRESS> - - [28/Jun/2024 20:47:07] "POST /gtts HTTP/1.1" 200 -
<IP_ADDRESS> - - [28/Jun/2024 20:47:12] "GET /login HTTP/1.1" 200 -
<IP_ADDRESS> - - [28/Jun/2024 20:47:12] "OPTIONS /gtts HTTP/1.1" 200 -
waves <-------- alone here
#generates voice

its actually written like this:*waves* but github doesnt show the two *
anyway it divides it for some reason
btw: it sometimes do this and sometimes not idk why

I tried it with *waves* now, but still couldn't reproduce the issue.
The regex /[\p{Extended_Pictographic}]/ug doesn't match a normal * character, but it does match emojis, so are you sure that *waves* isn't actually an emoji being converted to text when printed to the log?

well can i remove the \p and now it wont cut anything
But if It still cut it what do i do to make it not cut anything?

If you don't want to split on anything, change the line to const dividersSentence = /[]/ug;.


Fixed an issue when putting large words (or spam) into a RoomCard's SubText would cause the text to overlap away from the card

Hey maintainers,
While trying to break the components I spotted this issue so here we are with me making a pull request. (Hopefully I didn't fuck anything up)

please pull from staging, otherwise new-design will get merged into staging

Isn't it in the CONTRIBUTING.MD ?

@ofsho probably not, that's why there have been 10+ contributions with wrong source branches.

oh, we should fix it

@nadirabbas Fork the repo and create your branch (usually named patch-%the number of PRs you've already made%) from staging.
its there


[$1000] IOS - Timezone - Toggle switch back to online results after enabled connection

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Go to staging.new.expensify.com
Log in with gmail account
Go to Settings -> Profile -> Timezone.

[ ] Android / native
[ ] Android / Chrome
[x] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: <IP_ADDRESS>
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://user-images.githubusercontent.com/93399543/222770191-ba38746f-3c61-4be2-af46-77c1fefeca32.MP4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01aa6eaf96fa7c4cfe
Upwork Job ID:<PHONE_NUMBER>934312960
Last Price Increase: 2023-03-03

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)

If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead

[ ] This bug is reproducible using the reproduction steps in the OP. S/O

If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
If the reproduction steps aren't clear and you determine the correct steps, please update the OP.

[ ] This issue is filled out as thoroughly and clearly as possible

Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.

[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Job added to Upwork: https://www.upwork.com/jobs/~01aa6eaf96fa7c4cfe

Current assignee @abekkala is eligible for the External assigner, not assigning anyone new.

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

Triggered auto assignment to @aldo-expensify (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

I don't understand why this is considered a bug.

The latest state of that option was "automatic" and hence it should be automatic whether or not there's internet connection, unless I am misunderstanding the concern.

I think the expected/actual results are poorly described, or at least I don't understand when I read this: "should not switch back to online results". Anyway, from looking at the video, I understand that the problem is that it doesn't keep the settings the user chose while offline, it reverts back to choosing automatically the timezone.
@osofus thanks for having a look. I think we may consider it a bug because: The user changes its settings from X to Y, it should stay in Y no matter the connection status. We shouldn't force back on the user to have automatic detection of timezone just because they regained connection.

Thanks @aldo-expensify, when I watched the video again till the end I understood the problem.
The app gets the status when it was last online and switches to manual time zone briefly before switching back to automatic.

Yep, I think we should expect that the setting should not change at all when going offline/online/offline/etc

Proposal
Please re-state the problem that we are trying to solve in this issue.
Timezone selection set when network is offline resets when network is back online.
What is the root cause of that problem?
The root cause of this issue is that while offline, network requests for setting timezone fail. Since we have not defined any failureData, the selection is switched back when the connection becomes available again.
What changes do you think we should make in order to solve the problem?

We need to add the following here and here.
failureData: [
            {
                onyxMethod: CONST.ONYX.METHOD.MERGE,
                key: ONYXKEYS.PERSONAL_DETAILS,
                value: {
                    [currentUserEmail]: {
                        timezone,
                    },
                },
            },
        ],

What alternative solutions did you explore? (Optional)
None

No updates on my side, I'll give some time for @mananjadhav to have a first look at the proposals

I'll review the proposals today.

@mananjadhav have you had a moment to review?

its the end of the for me, I'll prioritize this to review proposals on Monday. @mananjadhav would be good if you can also do that

I checked the proposals and the root cause is on point for both of them. I am just not sure if we should go with Offline Pattern B or C.  Can comment on the acceptance of the proposal after we can confirm the offline pattern.
Tagging @Expensify/design @aldo-expensify @abekkala to confirm the offline behaviour here.

@mananjadhav can you bring this up in the open source room for more visibility? cc @JmillsExpensify @trjExpensify as my offline experts too.
But my take is that we want this action to be optimistic right? And this:

Anyway, from looking at the video, I understand that the problem is that it doesn't keep the settings the user chose while offline, the setting reverts back to detecting automatically the timezone.

This is the thing we need to fix without changing any of the offline patterns we're currently using.

I'm thinking that the right thing here is a pattern A, I see little value on complicating things with pattern B to let the user know that the update request has not been sent yet.
I'm failing to reproduce at the moment.

Yeah, I agree this should be pattern A. It's not an optimistic action that requires feedback (patternB).
I initially though this was linked to the "replay effect" we've documented here, but this doesn't seem like a case of toggling the setting back and forth causing the switching is it?

I thought that this may be because the write request UpdateAutomaticTimezone was resolving after the ReconnectApp request triggered on reconnection. This could cause ReconnectApp to read the old time zone value (before update) and cause the front end to switch back... but I can't reproduce it.
 DEBUG  [info] Finished API request - {"command":"UpdateAutomaticTimezone","jsonCode":200,"requestID":"7WuSTI"}
 DEBUG  [info] Making API request - {"command":"ReconnectApp"}
 DEBUG  [info] Finished API request - {"command":"ReconnectApp","jsonCode":200,"requestID":"izmVQY"}

https://user-images.githubusercontent.com/87341702/224831005-a6390f7c-7405-4002-a0f0-0efa63d3541e.mov
@mananjadhav can you test if you can reproduce this? if you can't, I think we should close this.

I initially though this was linked to the "replay effect" we've documented https://github.com/Expensify/App/issues/12775, but this doesn't seem like a case of toggling the setting back and forth causing the switching is it?

@trjExpensify maybe it is. I can reproduce it in web if I switch exactly 3 times while offline and then go online:
https://user-images.githubusercontent.com/87341702/224832451-a58026c7-f053-4404-a74d-b8e45297c24c.mov

Ah okay, then yeah.. if that was omitted from the OP to toggle multiple times then yeah, I would say it's the same root cause as the issue I linked which is a known limitation we need to figure out more broadly. CC: @JmillsExpensify @iwiznia @neil-marcellini

Woah yeah this one is weird. Regardless, I agree with Pattern A and keeping this separate from the "replay" effect issue.

I wasn't able to reproduce this without change the value multiple times ("replay" effect), would be good to if someone else can confirm the same. If we confirm that this issue only arrises when we change the setting multiple times, I do think we should close and put it in the "replay" effect issue bucket :)

Ah gotcha, sorry I totally misunderstand your last comment that you toggled it multiple times. My bad. Disregard that part of my last comment.

@aldo-expensify I'm also not able to reproduce following the steps described in the description. However, as you said, there is a replay effect if it's toggled multiple times while offline. I will put this issue on HOLD and add it to the tracking issue.

Good call, I agree with that. Thanks for the ping @shawnborton!

I can consistently reproduce this on v1.2.84-1. Here's the video recording for iOS Native. I couldn't reproduce the replay effect on Web.
https://user-images.githubusercontent.com/3069065/225306797-b575dcf1-a77f-445c-9a89-6ed471a3ae0c.MP4

I can consistently reproduce this on v1.2.84-1. Here's the video recording for iOS Native.

I think you are using a real device, right? maybe it is easier to reproduce because of that? I tried in the emulator again connected to the staging API and the dev API, I couldn't reproduce.

Yes I am using a physical iPhone not simulator. But I think we can keep this open for proposals as it doesn't relate to the replay effect.

How are the existing proposals looking?

None of the proposals cover Pattern A here, so I think we're still looking for proposals.

@mananjadhav Isn't the code using the Pattern A already?

Triggered auto assignment to @flaviadefaria (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@flaviadefaria
I'm ooo until Tue April 04 so I'm reassigning this.
Current Status:

Upwork job is posted
Discussion is occurring irt Proposals - nothing has been accepted yet, no one has been assigned

@mananjadhav Isn't the code using the Pattern A already?

@allroundexperts yes, I believe that is the case. We don't want to change the pattern, we just want to fix the settings changing the value when we come back online. This seems to only happen in IOUs devices (not the emulator), and I don't have one to debug this further.

No overdue!

I'll remove the HOLD because there is something to fix (maybe) not related to the replay effect (see this)

@mananjadhav @flaviadefaria @aldo-expensify this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ and will need to go internal. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

The only last bug I found is toggle 2 times => it shows incorrect "automatic timezone" setting until we refresh whole page

@hoangzinh toggle it 2 times while offline and then go online?

@aldo-expensify I am not able to reproduce the original bug. But I am able to reproduce the bug @hoangzinh reported.

@mananjadhav This is due to the request/response timing issues. The response from the ReconnectApp command is received before the second request is completed in the backend. So if you refresh the app again you'll get the right value back for the timezone. In one of the previous issues I had recommended to only send one request (the final one) to the server for all toggle-able actions that are added while being offline. I would recommend to do the same here.

I'll just put it back on hold and we can track it in the issue tracking all issues related to triggering an action multiple times while offline.


Add max-width media query breakpoint configuration option

Awesome project! :) Would love to see an option to enable max-width media queries for desktop-first design.

Hi there! Unfortunately a desktop-first design would break a lot of fundamental design of this project 😕. We had to pick between the two and currently the mobile first was more common so we opted for that design.

@jinsupark Thanks for letting me know. I'll close this ticket.


chore: put everything in one big Cargo workspace

Currently, this repo contains three separate Cargo workspaces: one for
source/, which contains the actual mnemOS crates, and then a separate
root workspace for each crate in tools/.
This is a bit unfortunate, as it means that it's not possible to run
cargo run --bin WHATEVER from the root directory of the repo. Instead,
in order to run melpomene, it's necessary to cd into source.
Similarly, if I want to run tools like crowtty, I need to cd into
tools/crowtty. This is very mildly annoying. The lack of a global
workspace also means that it's not currently possible to run cargo
commands like cargo build --workspace and build everything in one go.
This branch rectifies this by moving the workspace's Cargo.toml to the
root of the repo, and including all crates in the workspace (both
source/ and tools/). The potential downside of this is that it means
there's a lockfile, Cargo.toml, and .cargo/ directory in the root of
the workspace, which previously was nice and clean, and didn't have a
bunch of random config files and stuff in it. But, I think this is
probably not that bad?
If you'd really prefer not to make this change, that's fine --- having
to change dirs was really only a minor inconvenience.

I can't remember if it was cargo or rust-analyzer's fault, but the original division of workspaces was made to avoid "embedded" crates and "desktop crates" being in the same workspace.
That being said - in this consideration melpo should probably be in the "tools" folder.
I'm happy to merge this now, but it might make sense to back out later when we get closer to working with real hardware.

Ah, hmm, I was wondering if there was some issue like that. I've not had problems with having all the mycelium stuff in the same workspace even though it will do builds for both the host target (build tools) and the actual OS target (which is still x86 in my case but uses a very different target.json). But, it's possible that only works because of some specific aspect of the way I've set things up.
If this causes problems, we can definitely undo it later.


fixes #63 Kafka client classes implementation

fixes #63

@pushpithaDilhan I really don't understand why you are opening and closing PRs (4 up to now) to fix the same. We started the discussion in the PR #95 and I asked for changes then you made them ... why not continue on PR #95 ?

@ppatierno sorry, I had a indentation problem with my IDE. I think now its fixed

@pushpithaDilhan I can understand that but why opening different PRs ? You can do the same on the PR #95 because we have the history of our discussions and fixed to apply.

@ppatierno I thought it will be a problem to have more commits in one PR. I wanted to take them all to one commit.

@pushpithaDilhan ok I got it. When you open a PR with some commits and then people ask you some changes, you can just do other commits on the branch you are using for the PR; the PR will be updated automatically. If people ask to you to have just one commit, you can use the git squash command for doing that but always using the same PR. It's fine for now, it happens when how Git works is not clear ;)

@ppatierno Thanks, this won't happen again. :)

@pushpithaDilhan all the tests are running fine right ? Did you fix the problem with mocks ?

@ppatierno yes it is fixed now. All the tests in Mock passed.

Thanks :)


Incorrect hierarchy and position of objects parented to armature

Describe the bug
Some of the exported objects lost their hierarchy and are incorrectly positioned
To Reproduce
Steps to reproduce the behavior:

Load provided incorrect.blend and observe the parenting hierarchy (Armature > sphere1 > sphere2 > sphere3) and positioning
Export GLB
re-import and/or test in gltf-viewer

Screenshots
.blend file/ .gltf

incorrect.zip
Version

OS: linux
Blender 3.3.0
gltf import/export 3.3.27

Confirmed.
TRS of skinned meshes must be ignored in glTF, so TRS of children of skinned meshes are wrong at export, because we don't have to take into account the parent TRS.
No hierarchy issue ar export. At import, because of this ignore TRS, we can't use direct parenting, and need to create a new node. You have the same behaviour in babylon.js for example.


Pass original requestor around during forwards

This is another pretty mechanical change related to requestors and their use in the lifecycle API.
With this, we're now passing additional HTTP headers when forwarding a request to another cluster member, those headers include the original username, protocol and address and are then pulled by the daemon logic on the target server and used to set the relevant context.
I've already added what's needed for the address in anticipation of #8856 but it's currently not directly used.

Testsuite passed

@tomponline that should do the trick

@tomponline green enough? :)

Testsuite passed


Enable discovery to continue if reading a holding register hangs

Hi,
We are dealing with a device that claims to be Sunpec-compliant, but fails to respond to reads of holding register 0, making it impossible to use the standard discovery process as implemented in the sunspec module.
Some options to resolve the issue:

Time out reads, so the process could proceed from 0 onwards
Enable specifying the starting address for discovery

I think I'll add a discovery config struct for those two things:
struct Discovery {
    /// Addresses to check for the SunS identifier (default: [0, 40000, 50000])
    info_model_addrs: Vec<u16>,
    /// Timeout to be applied for every `read_holding_register` call
    read_timeout: Duration,
}

This sounds excellent.

Sorry for taking so long. I completely forgot about that. I implemented that feature some time ago but simply forgot to push and release it. :facepalm:

@tazle I just pushed sunspec 0.5.0 to crates.io:

:package: https://crates.io/crates/sunspec/0.5.0

I'm not too happy about having to carry a context and config structure around. I think a 0.6 release will add an actual Client structure which is a bit more ergonomic to use.


triggering event on ActiveForm

I use Select2 widget in ActiveForm and when validate attribute event trigger for each field the event is also trigger for select2 widget but its good to only trigger event on select2 when i focus or click on this field not the others

yes, we have same problem :(


Item doublets

I have two issues:

How to avoid a given title to occcur more than once.
How to hide disabled items

Here is two screenshots - with and without Nelisoft Shell registred - and you se the problems with Notepat++.
Its in danish - sorry:

Removing duplicate commands is not possible - it will be done later. For more information see:
https://discord.com/channels/1106387012707168318/1106390602964283483/threads/1142536977510567956
https://github.com/moudey/Shell/issues/300

about notepad++ see here:
https://discord.com/channels/1106387012707168318/1142556557075284130

hide disabled items:
item(type='*' where=this.disabled vis=remove)


Links to Terms and Conditions/Privacy Policy pages in Settings.jsx

⚠ IMPORTANT: Please do not create a Pull Request without creating an issue first.
All changes need to be discusssed before proceeding. Failure to do so may result in the pull request being rejected.
Please be sure to review our Code of Conduct, Contributing Guidelines, and Support documentation before submitting a pull request.

Please include the issue number the pull request fixes by replacing YOUR-ISSUE-HERE in the text below.
Fixes #636
Summary

Added Links to Terms & Conditions/Privacy Policy pages in Settings component at the very bottom.
Details

Test Plan (required)

Here is a gif showing it:

Final Checklist

[X] For CoronaTracker, did you bump the version in package.json?

Update the second decimal for a major change
Update the third decimal for a minor change
Numbers can go past 9, e.g. 1.0.9 => 1.0.10
For more info, read about Semantic Versioning

[X] Did you add any new tests as necessary?
[X] Is your PR rebased off the most current master?
[ ] Have you squashed all commits? (can be done at merge)
[X] Did you use yarn not npm? (important!)
[X] Did you use Material-UI wherever possible?
[X] Did you run yarn lint on the code?
[X] Did you run all of your most recent changes locally to make sure everything is working?

I just merged the latest master into your branch. Bump the package.json version and we should be good to go


automatic creation does not work for me - 8.0

When I just run the import of my2.sql I get GLOBAL_STATUS does not exist on line 37; when I manually remove both else statements completely, all works fine.

Well done.
Did You tested also the script in https://github.com/meob/my2Collector/blob/master/my2_80.sql ?
The main difference are the lines You removed!

Ow! Apologies! I thought because the if is there, it would do that automatically. Thanks for the good work!


[BUG] Server is duplicated and corrupted during the upgrade process

Describe the bug
While performing the 1.0.0 -> 1.0.1 upgrade one of the servers was "duplicated" causing the duplicated server to malfunction and the cluster to be reduced to just 2 working nodes when the upgrade completed.
To Reproduce

Install Harvester 1.0.0 on 3 servers
Perform the upgrade to 1.0.1 following the documentation (including all the preparations, such as shutting down VMs): https://docs.harvesterhci.io/v1.0/upgrade/automatic/

The screenshot below shows how the server harvey was duplicated as a server named <IP_ADDRESS> (note the identical host IP).

Here is the in-progress upgrade, showing how the duplicate server appeared when the server `harvey´ was in "post-draining" phase.

Support Bundle (after cleaning up the duplicated node and removing the non-working server "harvey" from the cluster).
supportbundle_e040cc7c-fcf3-4892-bcf4-514bca7bf53b_2022-05-10T11-26-09Z.zip

the panic stack in https://gist.github.com/janeczku/7d42329f40154776c4f2b108ab8db1aa
May 10 08:13:48 harvey rke2[15992]: panic: removed all voters
May 10 08:13:48 harvey rke2[15992]: goroutine 358 [running]:
May 10 08:13:48 harvey rke2[15992]: go.etcd.io/etcd/raft.(*raft).applyConfChange(0xc000ea0280, 0x0, 0xc004259b90, 0x1, 0x1, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
May 10 08:13:48 harvey rke2[15992]:         /go/pkg/mod/github.com/k3s-io/etcd@v0.5.0-alpha.5.0.20220113195313-6c2233a709e8/raft/raft.go:1514 +0x225

is similar to :
https://github.com/rancher/rke2/issues/2829

Can't reproduce it with the latest version; please feel free to re-open it if u have more detailed info, thanks.


config: enable tichi for docs / docs-cn / docs-dm / docs-tidb-operator

Related
close #151
Related repository

pingcap/docs
pingcap/docs-cn
pingcap/docs-tidb-operator
pingcap/docs-dm

Enable Plugin

ti-community-lgtm
ti-community-merge
ti-community-owners (By default, PR must have at least one lgtm)
ti-community-label
welcome
assign
hold
wip
size (Use the size plugin to automatically add size label to PR, replaces the original size label manually added)
require-matching-label (All PRs need to add translation/* label)

Should we enable the tars plugin?

Should we enable the tars plugin?

No. Because we don't need to keep the base updated for PR.

/merge
/unhold


AKAudioPlayer: pause and playFrom methods seems to corrupt their instance

Hi !
Bad news...
Playing with AKAudioplayer , I got very buggy behaviors.
If I only use start stop methods, everything works fine. But when I call pause or playFrom,  many problems occur.
-> The sound can play silently (current time is still updated, but no sound)
-> I can loose control (start doesn't work anymore at all)
-> It may finish in a crash (buttons do not fire anything anymore.)
-> If I start playing using playFrom, then the callBack is trigerred BEFORE the player reach the end of the file (I's say about an half a second before). Then, you cannot play the sound anymore.
-> call playFrom twice (or once after the player started) will play a short time of the sound, then stop (and the callback will be triggered)
-> If I use "replace" file and then "reload", then the played file is the previous file (not the replaced one). But if you just replace and NOT reload, then it is the replacing file that is played.
And so on...
I noticed that if I pause the player, currentTime and playhead properties give 0.0
Right now, except if you only just play / stop, audioplayer seems to be unusable.
:-/
I plan to work on an AKAudioFile class first (I need it :-). Then I'll try to fix or may be rewrite an AKAudioPlayer. I'll try to stick to the actual methods and properties.
But, right now, I think the start() method should be deprecated or changed and we should use a play() method instead (it would be more coherent with  Apple's AVAudioPlayer implementation.)
May be Start() should play the sound from the beginning when play() should continue to play according the playhead/currentTime value.
It would be cool to have a loopStart/loopEnd property that could be set.
And I'd like to try to implement a kind of markers callback, that could be triggered when the player reach an associated playing time value.
I attach a zip with my testPlayground, and the audio files I trig with.
I extended AKAudioPlayer to expose some internal var properties for debug.
so just add those lines to your AKAudioPlayer.swift if you want to experiment with my playground page.
// Added for debug
extension AKAudioPlayer {

    public var Paused : Bool {
        get {
            return paused
        }
    }

    public var InternalPlayerPlaying : Bool {
        get {
            return internalPlayer.playing
        }
    }
}

I'll let you know if I can submit a tested and working AKAudioPlayer.
:-)
Laurent.
_Recorder.xcplaygroundpage.zip

I guess start() and play() methods should do the same thing AKNode expects them and I think defaults one just calling the other, but I'll have to look at this in more detail in the morning.

This issue seems to be in place to let us know that you've identified something that you plan to fix right?  I'll leave you to it unless you want me to get involved.

I Think I can try to fix it.
As I'm a beginner in swift and AVFoundation, it takes years to code anything, but I learn a lot.
I begin to have a better understanding, and I should be able to submit soon a V1 of AKAudioFile (that inheritates AVAudioFile, with some utilities and public handy properties).
Right now, I already got some success with a my custom class in the playground.
But I must work on it to keep things simple and handy.
Then, I hope I can submit an upgraded AKAudioPlayer based on your implementation. I have an idea about what is going wrong in the current version, but I haven't made tests yet.
So if there's no emergency, I think I should be able to fix the AKAudioPlayer within a reasonable delay.
Coming back soon with some lines of code !
:-)
Laurent.

Hey @laurentVeliscek,
Just curious where your at with your AKAudioPlayer. If you need any help or want to pass on the job, let me know.

I’m just working on now !
Just cleaning and should be ready very soon…
:-)
Laurent

Le 10 juin 2016 à 19:08, Brandon Barber<EMAIL_ADDRESS>a écrit :
Hey @laurentVeliscek https://github.com/laurentVeliscek,
Just curious where your at with your AKAudioPlayer. If you need any help or want to pass on the job, let me know.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/audiokit/AudioKit/issues/384#issuecomment-225240104, or mute the thread https://github.com/notifications/unsubscribe/ASTVrlb14vQr2iSmspROJbPOq_Tb66eZks5qKZoagaJpZM4IkRWV.

Mes compos en téléchargement libre sont sur Soundcloud (musicatalogue) :
https://soundcloud.com/musicatalogue

I think this one could be closed...


Error resolving dependency tree with typography

Description
package.json
{
"name": "spectrum-test",
"version": "1.0.0",
"description": "",
"main": "index.js",
"scripts": {
"test": "echo "Error: no test specified" && exit 1"
},
"author": "",
"license": "ISC",
"dependencies": {
"@spectrum-css/accordion": "^3.0.39",
"@spectrum-css/actionbutton": "^3.0.29",
"@spectrum-css/actiongroup": "^3.0.30",
"@spectrum-css/asset": "^3.0.35",
"@spectrum-css/button": "^9.1.4",
"@spectrum-css/buttongroup": "^6.0.32",
"@spectrum-css/card": "^5.0.17",
"@spectrum-css/checkbox": "^6.0.17",
"@spectrum-css/clearbutton": "^1.2.25",
"@spectrum-css/dialog": "^6.0.34",
"@spectrum-css/divider": "^2.0.28",
"@spectrum-css/fieldlabel": "^6.0.18",
"@spectrum-css/icon": "^3.0.38",
"@spectrum-css/logicbutton": "^1.2.24",
"@spectrum-css/menu": "^4.0.20",
"@spectrum-css/page": "^5.0.22",
"@spectrum-css/pagination": "^6.0.3",
"@spectrum-css/picker": "^3.0.5",
"@spectrum-css/popover": "^6.0.32",
"@spectrum-css/progressbar": "^3.0.20",
"@spectrum-css/progresscircle": "^2.0.28",
"@spectrum-css/quickaction": "^3.0.41",
"@spectrum-css/radio": "^7.0.17",
"@spectrum-css/search": "^5.0.3",
"@spectrum-css/searchwithin": "^4.0.5",
"@spectrum-css/site": "^3.0.12",
"@spectrum-css/slider": "^3.1.20",
"@spectrum-css/splitbutton": "^5.0.31",
"@spectrum-css/switch": "^3.0.22",
"@spectrum-css/table": "^4.0.35",
"@spectrum-css/tabs": "^3.2.37",
"@spectrum-css/tag": "^5.0.17",
"@spectrum-css/taggroup": "^3.3.30",
"@spectrum-css/textfield": "^4.1.8",
"@spectrum-css/thumbnail": "^2.0.30",
"@spectrum-css/toast": "^9.0.17",
"@spectrum-css/tokens": "^8.1.0",
"@spectrum-css/treeview": "^6.0.35",
"@spectrum-css/typography": "^5.0.1",
"@spectrum-css/vars": "^9.0.2"
}
}

Steps to reproduce

copy package.json to local system
run npm install
Observe error message

npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR!
npm ERR! While resolving<EMAIL_ADDRESS>npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/@spectrum-css/typography
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR! node_modules/@spectrum-css/card
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Conflicting peer dependency<EMAIL_ADDRESS>npm ERR! node_modules/@spectrum-css/typography
npm ERR!   peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!   node_modules/@spectrum-css/card
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR! See C:\Users\syner\AppData\Local\npm-cache\eresolve-report.txt for a full report.
npm ERR!      C:\Users\syner\AppData\Local\npm-cache_logs\2023-04-19T17_16_56_906Z-debug-0.log
Expected behavior

Screenshots

Environment

NPM Version 9.6.4 on Windows 11

Additional context

This appears to be an outdated issue.  If you run into this issue again, please feel free to open a new issue with details and we can look into it further from there!


input placeholder and hint nomenclature is misleading

https://material.io/guidelines/components/text-fields.html#text-fields-layout
MdPlaceholder acts like what should be the "Label" from the spec, perhaps rename it MdLabel
MdHint acts like what should be "Helper Text" from the spec, perhaps rename MdHelperText
"Placeholder Text (hint text)" from the spec appears to be unimplemented, AND conflicts with what I would assume should be namedMdPlaceholder and/or MdHint

The MdPlaceholder part is a dupe of #6240.
About MdHint I really prefer the actual name than MdHelperText.

Placeholder part is captured in #6240
We don't have any plans to change MdHint


Add high-level tests for /ldp/db/* WSAPIs

These are all tested in reporting_test.go but it would be good to also have them invoked as WSAPIs from server_test.go.

/db/ldp/tables -- done
/db/ldp/columns -- done
/db/ldp/query -- not yet done
/db/ldp/reports -- not yet done

But the real work in this was setting up the infrastructure for being able to run reporting queries from a test server, and that's out the way.


PageData  has a promise type if layout afterLoad is async

Describe the bug
Repro:

https://github.com/gterras/houdini-typeloss-repro
branch layout-async-afterload

See the src/routes/layout-async-afterload folder. I didn't know how to write a test for a TS check so you just have to run the app and open layout-async-afterload/+page.svelte in your IDE and see the type is:
  data: {
    // ...
    then:
    catch:
    finally:
  }

You can toggle the bug on/off by commenting afterLoad in the +layout.ts file.
Severity
serious, but I can work around it
Steps to Reproduce the Bug
1- Follow the steps above
Reproduction
https://github.com/gterras/houdini-typeloss-repro

This should be pretty easy to implement. Just need to use the Awaited<F> type.
Currently it uses the Promise<ReturnType> but Awaited<F> unwraps this for us.


Laravel Passport

Hello,
I'm trying to build API's for a project. However, I'm confused as to how to make this work with L5.3 Passport. I know this issues sounds vague. But a little light towards the right direction might help.
Regards

I am not sure how best I can answer you.   This project is a wrapper for Cartalyst\Sentinel, so you might start by seeing if someone has already done an integration for that package.

@tusharvikky It works with Passport but you need to change default users model used by Sentinel.

I am going to close this for now.


V 1.06 Is not working.

The game gives an error telling me I cannot place the splitter.
I also noted that the DLL is not showing the correct version in all of your mods. Checked the DLL's in another mod from another author, and all the DLLs are showing the correct version for their mods.
I am using the Galactic scale mod, with a planet size of 400. Trying to place on the equator. Not sure if this makes a difference or not.
Thanks for your time in looking at this.

First, 1.0.6 will show up as 1.0.5 because I forgot to increment number. If the file modification date of the DLL is 2022, it is 1.0.6. (I don't use r2modman, so I don't know about that)
1.0.6 requires <IP_ADDRESS>09 game version. 11209 is important, it is latest patch.
I tried GalacticScale with size of 400 and could not find a problem.
Do you have any more information or screenshots?

According to E:\SteamLibrary\steamapps\common\Dyson Sphere Program\Configs\versions file, I am at the latest game version which matches what you have. (I find it strange that DSPGAME.exe has a different version from the game. This is not standard from my experience working at Microsoft. Or is it something to do with the game engine?)
I'll create a new game with only this mod and check again. Maybe I can find a mod conflict. I also posted my modlist if that will help.
modlist.txt

Found that the PlanetwideMining mod is preventing this one to work.


Fix small things in README

format all mentions of sanitize-html in the same way
fix a link
add a few commas for readability
fix the case of some characters
remove space before colons
align a response to a FAQ

Thank you!


App not downloading and not asking for file access permissions

The app literally doesn't download anymore and doesn't ask for file permission so it can download

Anyone else has the same problem? I'm using android 13, and I thinh that might be the problem

I think it is because of Android 13 that you can no longer download anything in the app 😔


Add Agent connection metrics and health indicator

Coverage decreased (-0.01%) to 91.563% when pulling a4095b0fb7033dbe677b388b5925df949ac380a3 on tgianos:agentConnectionMetrics into 77ab9ade8b1ea63f94371818135518c674f5a23b on Netflix:master.


View Packages: Search packages

Description
Search packages with : name, providers,  curatory groups or status.
Input
name, String,
providers, Numbers,
curatory group ids, curatoryIds, Numbers,
status statusId, Number,
paging, offset and limit, Number,
sorting, asc or desc, String
Output
List of packages with paging and name an ...
Implementation
GET /packages?name=’package 1’ &providers=42,33&curatoryGroupIds=42,41&statusId=42 &_include=name, provider, platform&_sort=name&_order=asc&offset=10&limit=10

{
  data: [
    {
      id: 42,
      name: ‘Frank’,
      provider: { id: 41, name: 'European' },
      platform: { id: 43, name: 'JSTOR' },
      _links: {
        self: { href: ‘/packages/42’ },
        delete: { href: ‘/packages/42’ },
        update: { href: ‘/packages/42’ }
      }
    },...  ],
    _pagination: {
      offset : 10
      limit: 10,
      total : 26
    },
    _links: {
      self: { href: ‘/packages?like above...&offset=10&limit=10’’ },
      first: { href: ‘/packages?like above...&offset=0&limit=10’ },
      last: { href: ‘/packages?like above...&offset=20&limit=10’ },
      prev : { href: ‘/packages?like above...&offset=0&limit=10’ },
      next: { href: ‘/packages?like above...&offset=20&limit=10’ }
  }
}

The self link can be used to edit a specific package, update can be used to change the package, in this dialog the package can be archived.
Like always no link available, no right to do it.
Estimated Workload: 3-4d
Actual Workload:

Actual delivers 500.


Nuxt-Bridge support

Hi!
Is there any plan to have it work for nuxt-bridge with a defineNuxtConfig setup in nuxt.config.ts? Thank you!

If you don't use Vite @nuxtjs/style-resources@^1 will work.
When using Vite, the same can be done with the following options
https://vitejs.dev/config/shared-options.html#css-preprocessoroptions


No Browsing possibilities in flash and RTMP in Fullscreen

Hello everyone,
I'm using mediaelement (amazing work by the way) with wowza (rtmp) and with the flash plugin. Everything works perfectly but one tiny thing :
when i play the video fullscreen, I can go forward in the video, and browse in any direction in fact.
Is this a known issue ? (can't find any answer anywhere though)
Thank you for you help !
A.

Same issue here, also with an RTMP stream from Wowza.  This is a streamed mp4 video file.  In the fullscreen Flash player, clicking on different regions of the timeline (a.k.a. "seeking") works in NON-fullscreen mode, but not in fullscreen.  The timeline still responds to hover events, showing the time code at that point.
It's worth noting that I CAN jump forward and back in the video using the left and right arrow keys, and the pause and play buttons still work for me.
Using:

MediaElement 2.16.3.
Mac OSX 10.9.5
Chrome 40 (Flash 16,0,0,252)
Firefox 35.0 and Safari 7.1.2 (Flash Flash 16,0,0,235)

@elo2112 Can you provide a URL to test this?

Closing this issue since no answer has been posted in more than 2 weeks. If you'd like to reopen this, let us know. Thanks!


Fix for several test cases

see #26

Coverage remained the same at 57.693% when pulling 72b8d4625c06d8072738dbaf6a56c009e8ab9928 on develop into 91062e0470e1372594b34d21a8f1983a4c6b043f on master.

Coverage remained the same at 57.693% when pulling 72b8d4625c06d8072738dbaf6a56c009e8ab9928 on develop into 91062e0470e1372594b34d21a8f1983a4c6b043f on master.


Update dependencies to stable state

Follow up on https://github.com/casper-network/casper-node/issues/3921. The underlying problem is a dependency mismatch with casper-types and casper-node . More specifically, casper-types 1.6 (should be 3.0) had breaking changes compared to casper-types 1.5 . We should update the casper-db-utils dependencies to a stable state once the casper-types changes are sorted out.

@RitaMAllenCA
unassigning @georgepisaltu due to no cycles left during this sprint


Route Table routes show that each route removes hasBgpOverride=false property

Describe the noise
Our route tables, while unchanged, show quite a bit of noise for the route definitions.
Resource type
Microsoft.Network/routeTables
apiVersion
2020-05-01
Client
PowerShell and Azure CLI
Relevant ARM Template code (we only need the resource object for the above resourceType and apiVersion, but if it's easier you can include the entire template
{
    "$schema": "https://schema.management.azure.com/schemas/2019-04-01/deploymentTemplate.json#",
    "contentVersion": "<IP_ADDRESS>",
    "parameters": {
        "routeTables": {
            "type": "array",
            "metadata": {
                "description": "Array containing the route tables and routes to be created."
            }
        },
        "location": {
            "type": "string",
            "metadata": {
                "description": "Specifies the default Azure location where the resources should be created"
            }
        }
    },
    "variables": {},
    "resources": [
        {
            "apiVersion": "2020-05-01",
            "type": "Microsoft.Network/routeTables",
            "name": "[concat(parameters('routeTables')[copyIndex('routeTables')].subnet, '-rt')]",
            "location": "[parameters('location')]",

            "properties": {
                "copy": [
                    {
                        "name": "routes",
                        "count": "[length(parameters('routeTables')[copyIndex('routeTables')].routes)]",
                        "input": "[parameters('routeTables')[copyIndex('routeTables')].routes[copyIndex('routes')]]"
                    }
                ]
            },
            "copy": {
                "name": "routeTables",
                "count": "[length(parameters('routeTables'))]"
            }
        }
    ],
    "outputs": {}
}

Example parameter value for routeTables:
{
          "subnet": "mysubnet",
          "routes": [
            {
              "name": "my-first-route",
              "properties": {
                "addressPrefix": "<IP_ADDRESS>/27",
                "nextHopType": "None"
              }
            },
            {
              "name": "my-second-route",
              "properties": {
                "addressPrefix": "<IP_ADDRESS>/27",
                "nextHopType": "None"
              }
            }
          ]
}

Expected response
I expect no noise because the routes have not changed
Current (noisy) response
~ properties.routes: [
      ~ 0:

        - properties.hasBgpOverride: false

      ~ 1:

        - properties.hasBgpOverride: false

      ]

Still seeing this in 2023 in bicep and CARML on the latest provider and template versions. When you have dozens of routes, this adds a whole lot of noise to each and every 'what-if'. Is this still pending investigation?


Update the comment of rdb_restore_command_behavior in shake.toml

There are two inconsistencies in the description of the "rdb_restore_command_behavior" configuration in the [advanced] section when  the developer sees the comment.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Use GitHubs commit API to check out the tree directly

Cargo often needs to clone or update repos that have a lot of history, when all it needs is the contents of one particular reference. The most dramatic example is the index, which we clone or update regularly. sparse-registry will move us from using get for this particular case entirely, but in the meantime it would be nice to reduce the transfer costs.
GitHub Blog "Get up to speed with partial clone and shallow clone" describe how to use "shallow clone" (--depth=1) or "treeless clone" (--filter=) to make this less expensive. Unfortunately, libgit2 does not support either of these features. When GitOxide is ready, we should talk to GitHub about if these features make sense in our use case.
It turns out, without using any fancy features, you can fetch an arbitrary git object ID and everything it links to. If we knew the ID of the Tree of the commit of the reference we were trying to check out, we could fetch everything we needed without any of the history! GitHub provides an API endpoint for retrieving information about a commit. One of the included pieces of information is the ID of the Tree. Even better, we already hit that API as a fast path for discovering that we are up-to-date. So instead of that fast path returning the sha we return the commit.tree.sha, and we no longer clone the history!
In fact there are more minor implementation details:

We need to store the sha and commit.tree.sha somewhere so that we can use it as an etag, and so that we know what to check out, as git no longer has Commits to refer to. I have chosen to make a blob and a ref point to that blob.
Our checkout code needs to be slightly modified because it doesn't make sense to update the HEAD commit if we don't have history.
The database cash can no longer check for cached files written from older Cargos, as they used the ID of the HEAD, which is no longer easy to get. (This can be put back if needed.)

There is one failing test, specifically added because this cannot be merged until we talk to GitHub about:

Is it acceptable for us to drive a significant portion of the traffic to fetching a Tree object instead of its associated Commit?
Is it acceptable for us update a repository that has Tree objects checked out, to a different tree object?
Occasionally, the call to https://api.github.com/repos/OWNER/REPO/commits/REF will fail after succeeding in the past. (For example due to rate limiting.) Leading to us normally cloning a repository which had previously only had Tree objects. Is this acceptable?

You have publicly asked people not to do any kind of fetch in a repository that was checked out using "shallow clone", is this the same situation?
Fundamentally this change reduces disk footprint and network bandwidth by an enormous amount. Different repose will have different repos. But the index is quite significant, in the 80% range, depending on how recently it was squashed.

r? @epage
(rust-highfive has picked a reviewer for you, use r? to override)

I find this method downright genius as it uses the GitHub API in conjunction with the standard git protocol features (namely, fetching objects specified by hash) to emulate a shallow clone which is even more space efficient than an actual shallow clone, as it skip on commits entirely. Let's call it 'super-shallow' clone. Thus, even once shallow cloning is available, assuming there is no blockers on GitHubs side, using this fast-path would be beneficial either way.
From a performance perspective on the server side, judging from my own limited experience, I'd be surprised if GitHub would have an issue with it. It will be good to hear that from them though.
Something I was always interested in was to keep the local crates-index clone as standard as possible to allow users to interact with it like they normally would. With this PR we get a step further away from that as HEAD seems to be bypassed entirely, that is it won't point to a recent commit (we wouldn't have that anymore), nor to a tree. Pointing it to a tree would probably disturb most tools out there as well so there is little value. Furthermore, the requirement to store an etag as alternative to a tree as reference for 'last seen' for GitHub requires more than HEAD for storage.
I hope to get to integrating cloning and fetching the crates index using gitoxide soon and open a PR for that, by then I should understand all the details which should allow to maybe provide more helpful comments here as well. (Something I'd like to understand more is how the transition from this 'super-shallow' implementation works back to the 'normal' one, and vice-versa)

One thing I forgot to do in this PR and forgot to mention, we can easily change the hash used by Cargo in the file path where the git db is stored. This can prevent old and new Cargos from interacting with the same git dbs. Hopefully then the only time we transition back to a normal clone is on a failed api call.

Ready for the next review

👋 Hello from GitHub!
Using the commits API certainly works. However, if you are requesting a lot of files then you might run into our API rate limits.
If you are only interested in the content of the HEAD commit of a particular reference, then the most efficient way to get this data is our archive API.
Here is an example which downloads a tarball of the HEAD of the master branch of your crates.io-index repository and extracts it into the current directory:
$ curl -L https://api.github.com/repos/rust-lang/crates.io-index/tarball/master | tar zxf -

Switching to using tarballs is a larger structural change. One I will definitely continue to look into. For some of Cargos needs we do in fact want to extract the output, where it might be a very good fit.
However, The Index is the place where Cargo puts the most load on GitHubs infrastructure. We do not extract the Index on disk, instead only extracting and parsing the files we happen to need. I don't think tarballs are compatible with random-access. We could get a zipball, but this is also significantly larger. The result would be a whole new kind of Index (Git/Sparse and now ZIP), with significant testing and implementation overhead, which would probably not merge before we stabilize Sparse Indexs.

We need to store the sha and commit.tree.sha somewhere so that we can use it as an etag, and so that we know what to check out, as git no longer has Commits to refer to. I have chosen to make a blob and a ref point to that blob.

I realize the problem with this plan, git gc has no way of knowing that we are still using the object pointed at OID commit.tree.sha. I am switching to having two refs, one to the commit.tree.sha and one to a blob containing sha.

Is it acceptable for us update a repository that has Tree objects checked out, to a different tree object?

I built a separate project that creates a new git repository and then fetches into it twice. The goal was to see the first one download a pack file of 64 MB, and the second one only downloading the changes. I used head: "e6c48cfe712d28e17914a2822b8f2f492ff22c80" whose tree: "a792a7874f7033acf3a8d8aacfd914c77c5673fd" as the first fetch and head: "37c5a461c41265670000d91eb76e9256b91f6dc3" whose tree: "63a4fe231ca6fcc6107b41f9c4f56cdbb6381481" for the second. Unfortunately, everything I tried ended up downloading two pack files that were both 64 MB.
Things I tried:

.fetch(&[&format!("+{tree}")]) where tree is the oid above.
.fetch(&[&format!("+{tree}:{old_tree}")]) where old_tree is the oid of the tree from the previous fetch.
.fetch(&[&format!("+{tree}:{old_head}")]) where old_head is the oid of the head from the previous fetch.
.fetch(&[&format!("+{tree}:refs/ref_that_point_to_old_tree")]) where refs/ref_that_point_to_old_tree does what it says on the tin.
.fetch(&[&format!("+{tree}:refs/ref_that_point_to_a_commit_that_points_to_old_tree")]) where refs/ref_that_point_to_a_commit_that_points_to_old_tree does what it says on the tin.

    git2::trace_set(git2::TraceLevel::Trace, |a, b| {
        if b.contains("have") {
            eprintln!("{a:?} {b}")
        }
    });

Was helpful in figuring out what's going on. libgit2only sends a have line when the oid points to a commit. However when it does point to a commit, the server has no way to know what tree that commit is associated with.
Unless we can figure out how to get deltas between two trees, I think this PR is probably dead in the water.

Unless we can figure out how to get deltas between two trees, I think this PR is probably dead in the water.

Does it have to be between two trees?
I see two distinct stages

the first clone
consecutive fetches

1) could be done, I think, by fetching single {tree}, and keeping the hash of the commit that refers to it without fetching it. That way, we have all data associated with the tree and can work with it.
For 2), and in order to get deltas, one would have to get libgit2 to produce a have line in the protocol, which it does only if the right-hand side of the refspec points to a commit object, which unfortunately we don't have in the object database. The left-hand side must also be a commit, and it's something that we know from using the GitHub API, and it doesn't have to exist locally either.
This narrows the problem down to: How can we make a commit object (that we know, but don't have) so that a ref points to it and it is picked up as have line in the protocol?
A look at the code reveals that the way libgit2 negotiates requires a revision walk, so it needs a real commit to work. But what constitutes a real commit? It's just a file like this:
tree <hash>
parent <our_previous_fake_commit>
author name <email><PHONE_NUMBER> +0100
committer GitHub<EMAIL_ADDRESS>1666095079 +0100

commit message

The idea is to manufacture a commit that:

points to our previous known fake-commit. It's fake as it has a hash that doesn't match its contents
points to our actual tree.

 That way the server will get enough information, even without mentioning the intermediate commits that we don't know about. I know this is fine as gitoxide currently implements a naive negotiation which only mentions haves based on the tracking branches.
This sounds like a lot of workaround'ing to have another stab at getting this to work, but I think it could indeed work. The question is if it's worth the effort (and maintenance) in the light of gitoxide being around the corner which would bring true shallow clones and fetches.

Unfortunately there are two problems with that suggestion. One problem is that libgit2 does appear to check. In my experiments if the right hand side of a refspec point at a loose object that has been renamed to have the hash of head, then libgit2 gives "object hash mismatch" error.
The second issue is more subtle, what happens if the new tree contains a file whose contents existed in an old commit, but not in the tree associated with the old head. What would happen is:

Initial clone of only old tree.
Download Delta between old head and new tree. (This does not include the new version of the file, because we claim to have had old head which implies that we have the entire history, and so we have the blob already.)
Attempts to look at the object in the new tree, and get an error because it does not exist in our object database. (As it was not in the old tree nor in the delta.)

So this is how it feels to be sad and happy at the same time 😅.

Seems like the low-level control needed to make this work will have to wait on gitoxide. Which will probably also support more normal/standard operations, making this scheme unnecessary. Also hopefully sparse indexes will be stable by then, which also makes such extraordinary measures unjustified.


feat: keep comments from git commit template

This change avoids removing potentially useful comments from the git commit template file in order to act more like actual git client
This PR fixes #130045

OK clearly not that simple, comments in commit messages are actually passed through in vscode

@stuart-warren, apologies for not getting back to you on this pull request until now. I have taken a look at the pull request and while from a functionality perspective, these changes work as expected, it does not make sense to clutter the very limited space in the commit message input with comments. Having said that, including comments will make sense as we look to enable using the full editor as an input for the comment message (https://github.com/microsoft/vscode/issues/30562).


Realtime News-Web

Is your feature request related to a problem? Please describe.
I want to add Realtime News-Web that provide you news by your search topics and find all the data related to all news available in different news pages.
Describe the solution you'd like
I will use News API that will fetch the data in real time.
Describe alternatives you've considered
I think alternatives is rare because of finding real time news we need to fetch API'S.
Additional context

What problem is this feature trying to solve? :- Real time News
How do we know when the feature is complete? :- When you search any topic this page give's you real time data about that.

Currently not accepting sample projects.


[QUESTION]:

How can the Team help you today?
Details: ?
Hi Team, does anyone know if our PowerFlex CSI driver supports KubeVirt CDI?
We have an issue that CDI cannot mount volume normally while creating a VM using Kubevirt.
[centos@worker-node ~]$ lsblk
NAME            MAJ:MIN RM   SIZE RO TYPE MOUNTPOINT
sda               8:0    0 223.6G  0 disk
├─sda1            8:1    0     1G  0 part /boot
└─sda2            8:2    0 222.5G  0 part
├─centos-root 253:0    0 168.5G  0 lvm  /
├─centos-swap 253:1    0     4G  0 lvm
└─centos-home 253:2    0    50G  0 lvm  /home
sdb               8:16   0 279.4G  0 disk
sdi               8:128  0    12G  0 disk
scinia          252:0    0    40G  0 disk
└─scinia1       252:1    0    40G  0 part
[centos@master-node ~]$ kubectl get pvc
NAME              STATUS   VOLUME                 CAPACITY   ACCESS MODES   STORAGECLASS   AGE
test-vm-boot-dv   Bound    powerflex-368286c5ac   40Gi       RWO            vxflexos       60m
[centos@master-node ~]$ kubectl get pv
NAME                                       CAPACITY   ACCESS MODES   RECLAIM POLICY   STATUS   CLAIM                                                                 STORAGECLASS       REASON   AGE
powerflex-368286c5ac                       40Gi       RWO            Delete           Bound    default/test-vm-boot-dv                                               vxflexos                    60m
[centos@master-node ~]$ kubectl describe pod cdi-upload-test-vm-boot-dv
Name:           cdi-upload-test-vm-boot-dv
Namespace:      default
Priority:       0
Node:           worker-node/172.16.x.x
Start Time:     Tue, 05 Jul 2022 16:28:49 +0900
Labels:         app=containerized-data-importer
app.kubernetes.io/component=storage
app.kubernetes.io/managed-by=cdi-controller
cdi.kubevirt.io=cdi-upload-server
cdi.kubevirt.io/uploadTarget=368286c5-ac85-439a-89a9-02e2639024c2
service=cdi-upload-test-vm-boot-dv
Annotations:    cdi.kubevirt.io/storage.createdByUploadController: yes
sidecar.istio.io/inject: false
Status:         Pending
IP:
IPs:
Controlled By:  PersistentVolumeClaim/test-vm-boot-dv
Containers:
cdi-upload-server:
Container ID:
Image:         quay.io/kubevirt/cdi-uploadserver:v1.50.0
Image ID:
Port:
Host Port:
Args:
-v=1
State:          Waiting
Reason:       ContainerCreating
Ready:          False
Restart Count:  0
Limits:
cpu:     750m
memory:  600M
Requests:
cpu:      100m
memory:   60M
Readiness:  http-get http://:8080/healthz delay=2s timeout=1s period=5s #success=1 #failure=3
Environment:
TLS_KEY:              <set to the key 'tls.key' in secret 'cdi-upload-test-vm-boot-dv'>  Optional: false
TLS_CERT:             <set to the key 'tls.crt' in secret 'cdi-upload-test-vm-boot-dv'>  Optional: false
CLIENT_CERT:          -----BEGIN CERTIFICATE-----
MIIDVTCCAj2gAwIBAgIIeL9a9tQAfGwwDQYJKoZIhvcNAQELBQAwODE2MDQGA1UE
AwwtY2RpX2NkaS11cGxvYWRzZXJ2ZXItY2xpZW50LXNpZ25lckAxNjU2OTA3NjM1
MB4XDTIyMDcwNDA0MDcxNFoXDTMyMDcwMTA0MDcxNVowODE2MDQGA1UEAwwtY2Rp
X2NkaS11cGxvYWRzZXJ2ZXItY2xpZW50LXNpZ25lckAxNjU2OTA3NjM1MIIBIjAN
BgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEAv2zFJF1HLT7I8BPFEqX5JhajNX5Y
TRT4gBFUzDTN4EXVdhFBhL4GWK68k+VphLbG8ay9tb+ZP4xMvIBhc06o45vxurK/
k3rjZkiIyvTzgXYps44hFwVo762xIr0zIb4ve4vIXgu5RVzBX4s6A/bbH9t0QnEV
GyKBjCQ5nZU97+MRwcFtb59+2agf4XPAXloesGdUdnJYKb6tAtluZVadUC34lwoL
rEj4y6T1zv2yirSwX7rDH4Xp1rWrPDwgU8V53l2Y+9K50kcvWJUkChPyX+wC6ubH
YvResl9LBLfGg0MncvJDsBYWJO6C2MQ4z+/+B2KIS7Wq1X88eXlOFMRV0QIDAQAB
o2MwYTAOBgNVHQ8BAf8EBAMCAqQwDwYDVR0TAQH/BAUwAwEB/zAdBgNVHQ4EFgQU
oLgMTEbov+UNs0NPi42vo7xtUBcwHwYDVR0jBBgwFoAUoLgMTEbov+UNs0NPi42v
o7xtUBcwDQYJKoZIhvcNAQELBQADggEBAJb1eeoCohRVxbc4oysvGdouAa8TteHE
j5f1ZIOlbNH0HnYkiwOtqydyxnpgr6pZiXQ/4i1WJCqxAm29gwuPlhUTk5cbUzpV
kR7BuGNKPCY3zuZKZR76inkliQAzqhW9nzosPmBiV8vGIZ0rqKwURQqd99qs3fHQ
WaX1lccQjJQHNiy0Ao8vefLz24EZ6/VsE4yPjDu15YeOa4hsywnDK2U/lfAeGE1P
uQI3HyBkUfATDnDZDSqGwflxeTGejL4Pw1ngqtxbFVfe99qTgQubpR+97xp7S2z9
wO2mrTCgLdFuOOo3Za3hF6KJvjz9itvAr+iAv8K76iQ4mE4OLAvDTnc=
-----END CERTIFICATE-----
  FILESYSTEM_OVERHEAD:  0.055
  UPLOAD_IMAGE_SIZE:    40Gi
  CLIENT_NAME:          imagevolume/centos-7-image-default/test-vm-boot-dv
  PREALLOCATION:        false
Mounts:
  /data from cdi-data-vol (rw)
  /var/run/secrets/kubernetes.io/serviceaccount from kube-api-access-w5fqt (ro)

Conditions:
Type              Status
Initialized       True
Ready             False
ContainersReady   False
PodScheduled      True
Volumes:
cdi-data-vol:
Type:       PersistentVolumeClaim (a reference to a PersistentVolumeClaim in the same namespace)
ClaimName:  test-vm-boot-dv
ReadOnly:   false
kube-api-access-w5fqt:
Type:                    Projected (a volume that contains injected data from multiple sources)
TokenExpirationSeconds:  3607
ConfigMapName:           kube-root-ca.crt
ConfigMapOptional:
DownwardAPI:             true
QoS Class:                   Burstable
Node-Selectors:              kubernetes.io/os=linux
Tolerations:                 node.kubernetes.io/not-ready:NoExecute op=Exists for 300s
node.kubernetes.io/unreachable:NoExecute op=Exists for 300s
Events:
Type     Reason                  Age                From                     Message

Normal   Scheduled               57m                default-scheduler        Successfully assigned default/cdi-upload-test-vm-boot-dv to worker-node
Normal   SuccessfulAttachVolume  57m                attachdetach-controller  AttachVolume.Attach succeeded for volume "powerflex-368286c5ac"
Warning  FailedMount             57m (x2 over 57m)  kubelet                  MountVolume.SetUp failed for volume "powerflex-368286c5ac" : rpc error: code = Internal desc = error performing private mount: failed to mount volume as "ext4"; already contains unknown data, probably partitions: error: mount failed: exit status 32
mounting arguments: -t ext4 -o defaults /dev/scinia /var/lib/kubelet/plugins/vxflexos.emc.dell.com/disks/31831cd50bec1b0f-c76d6dd100000000
output: mount: /var/lib/kubelet/plugins/vxflexos.emc.dell.com/disks/31831cd50bec1b0f-c76d6dd100000000: /dev/scinia already mounted or mount point busy.
Warning  FailedMount  21m (x4 over 55m)     kubelet  Unable to attach or mount volumes: unmounted volumes=[cdi-data-vol], unattached volumes=[kube-api-access-w5fqt cdi-data-vol]: timed out waiting for the condition
Warning  FailedMount  12m (x15 over 53m)    kubelet  Unable to attach or mount volumes: unmounted volumes=[cdi-data-vol], unattached volumes=[cdi-data-vol kube-api-access-w5fqt]: timed out waiting for the condition
Warning  FailedMount  2m26s (x33 over 57m)  kubelet  MountVolume.SetUp failed for volume "powerflex-368286c5ac" : rpc error: code = Internal desc = error performing private mount: failed to mount volume as "ext4"; already contains unknown data, probably partitions: error: mount failed: exit status 32
mounting arguments: -t ext4 -o defaults /dev/scinia /var/lib/kubelet/plugins/vxflexos.emc.dell.com/disks/31831cd50bec1b0f-c76d6dd100000000
output: mount: /var/lib/kubelet/plugins/vxflexos.emc.dell.com/disks/31831cd50bec1b0f-c76d6dd100000000: wrong fs type, bad option, bad superblock on /dev/scinia, missing codepage or helper program, or other error.

Hi JacobGros,
Thank you for your answer.
But actually PowerFlwx doesn't use linux's multipath feature. SDC driver is installed and block service is performed using a separate driver. The multipath package is not even installed.
[centos@master-node ~]$ multipath -l
-bash: multipath: command not found
[centos@master-node ~]$

Pflex does not support mpath, however sometimes when mpath is enabled (likely for another driver) we see that issue.
Since it looks like Mpath is off on this cluster, can you try running this command on the worker node?
 lsblk -n -o FSTYPE /dev/scinia
curious to see what comes back since it looks like the driver isn't recognizing it from the logs:
Warning FailedMount 2m26s (x33 over 57m) kubelet MountVolume.SetUp failed for volume "powerflex-368286c5ac" : rpc error: code = Internal desc = error performing private mount: failed to mount volume as "ext4"; already contains unknown data, probably partitions: error: mount failed: exit status 32


Provide a method with all available Values listed

In order to provide Developer Support functionalities, such as #360, we need a method which returns a list of available values. For each of values it should return at least:

value name
value type (AskScript type not JS type)

@czerwinskilukasz1 what do you mean by method? A method that returns the values is easy to setup - but should it satisfy a certain API? Should it be a REST API? Who is going to use this method? Will it be a resource unto itself?


Sortable : Active Class

Hello Markus,
I am too impressed with your plugin, but can you please guide me how to add .Activeclass to single item on sortable.
~Sahib

$('.sequence').sortable({forcePlaceholderSize: true, activeClass: 'active'});
but i want to add Class to an Single draggable item not to parent.
Thanks & Regards
Sahib

Hi @sahibsingh, you could try something like:
.sortable()
.on('sortable:start', function(e, ui) { ui.item.addClass('active') })
.on('sortable:stop', function(e, ui) { ui.item.removeClass('active') })

Does this work for you?

Thanks @rkusa  you solved it. Great :+1:

Can we do this thing same as with Dragging and Dropping?


Printing class segfaults

Get a segfault for the following program
class Foo():
    def __init__(self):
        pass

actor main(env):
    f = Foo()
    print()
    env.exit(0)

Fixed by #743


add links in manifest to enable direct links in psgallery

The .psd1 files are autogenerated from these lines:
https://github.com/microsoft/navcontainerhelper/blob/5eef4ac0d52d40151cba7f5fc0e97c8a3783b4df/.github/workflows/CI.yaml#L193
and
https://github.com/microsoft/navcontainerhelper/blob/5eef4ac0d52d40151cba7f5fc0e97c8a3783b4df/.github/workflows/Release.yaml#L63
-LicenseUri and -ProjectUri

The maifest ist not autogenerated but auto-updated.
As we do not overwrite the values in Update-ModuleManifest, the values already set in the psd1 will be retained. (Just Tested)
Should I add it to the actions anyway?

The .psd1 files are autogenerated from these lines:
https://github.com/microsoft/navcontainerhelper/blob/5eef4ac0d52d40151cba7f5fc0e97c8a3783b4df/.github/workflows/CI.yaml#L193
and
https://github.com/microsoft/navcontainerhelper/blob/5eef4ac0d52d40151cba7f5fc0e97c8a3783b4df/.github/workflows/Release.yaml#L63
-LicenseUri and -ProjectUri

The maifest ist not autogenerated but auto-updated. As we do not overwrite the values in Update-ModuleManifest, the values already set in the psd1 will be retained. (Just Tested)
Should I add it to the actions anyway?

Yes, please do - I don't want to have anything in the .psd1 files which needs to be maintained.


Code cruft - no need for child ordering

https://github.com/alimanfoo/anjl/blob/6c568b0f7656acfc4df857301c4873854d29b91d/anjl/_dynamic.py#L173-L175
These should already be ordered, because we are searching the lower triangle, except the other way around.

Will leave this alone for now.


feat(SASS): Allow import scss files from lib or dependencies

This feature allow the developer to import other SCSS files into the scss component file.
Eg :
From node_modules dependencies : @import '~angular/material/theming';
From other component : @import '../other-component/other-component.component.scss';

@rtrompier — Thank you, this works great! 👍
Would you be able to add a section to the README so I can merge this?
Thanks in advance!

@rtrompier — I have added the documentation and released your changes as v10.2.0.
Thank you for your contribution! 👍

Question: @rtrompier - where inside the generator code would I put a global .scss file in which to import my styles - I have several components and want to have it used for them all


[core] Clean up technical debt in defaulting code (1)

How to categorize this PR?

/area dev-productivity
/kind technical-debt
What this PR does / why we need it:
This PR cleans up technical debt in our API defaulting code according to https://github.com/gardener/gardener/issues/7312.
This PR tackles the following resources in the core API group:

Project
CloudProfile
ControllerRegistration

Which issue(s) this PR fixes:
Part of https://github.com/gardener/gardener/issues/7312
Special notes for your reviewer:
Use the dedicated commits to review this PR step-by-step.
Commits named Prefactor: extract defaulting into dedicated file don't change code or tests but only move them for easier reviews of the actual refactoring
Release note:

NONE

/assign

@timuthy thanks for the review! PTAL :)

/test pull-gardener-e2e-kind-operator

/test pull-gardener-e2e-kind-operator

@shafeeqes I leave the decision up to include it in the v1.63 release. The change itself is not important for the release, though.

/milestone v1.63


feat(SqlSmith): gen Table Subquery EXISTS

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
EXISTS implement
Checklist

[x] I have written necessary rustdoc comments
[x] I have added necessary unit tests and integration tests
[x] All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)
close #4296

There is 1 out of 1024 query that I run have this issue https://github.com/singularity-data/risingwave/issues/4434 . Need to fix this first

There is 1 out of 1024 query that I run have this issue #4434 . Need to fix this first

alright, I think it is nothing related to exists, we can merge it. Because the problem occur in subquery with aggregate. Probably this probability is very low, until now it is notice.

For some exists query, e.g.

SELECT t1.* FROM t1
WHERE EXISTS (SELECT * FROM t3 WHERE t1.c1 = t3.c1)

It can be transformed into a hash join, not necessarily a nested loop join.

SELECT t1.* FROM t1, t3 WHERE t1.c1 = t3.c1

So we can probably do more than this.

Clarification: Do you mean that exists can be transformed into something we already test (hash join), so we probably don't need to generate it, there are other more important things to generate?

We still need to generate in these cases as we can test the transformed into something.
I mean, we can generate correlated subqueries in the exists clause.

Any updates?

Currently a few feature not yet implemented

Local subquery inside Aggregate
Correlated subquery in HAVING or SELECT with agg is not implemented

so I decided to workaround, as such
If currently the subquery is inside an aggregate function, then it won't generate EXISTS subquery
With this, when I want to generate correlated subquery. The following problem shown up https://github.com/risingwavelabs/risingwave/issues/6350
As for Imatz comment on the possible EXISTS subquery generated by materialised view. I will look into what I can do in a later time.

The problem I facing is  "Feature is not yet implemented: correlated subquery in HAVING or SELECT with agg,"
This show that if I would want to generate correlated query (Not the local query), I need to pass the information about "Cannot have agg" all the way until gen_expr which is too much of parameter passing.
I am planning to refactor some code to able to workaround unsupported feature.

put the two variable 'inside_agg' and 'can_agg' as internal state instead of passing around gen_expr. Meaning that the variable will become global to all the methods (functions).
To ensure correctness, the same way as how the gen_local_query done is, saving all the state and restoring the state upon leaving the function. (This may be quite a some refactor).
By doing so, we can actually think of a few more internal state that can help us with workaround for example, if it is mv, then we avoid generating Nested Loop Join.

Since this PR is not about correlated query, and it is about EXISTS, would it be alright if I dun generate correlated query and have another PR about generating correlated query.
I need some advise on this.

Since this PR is not about correlated query, and it is about EXISTS, would it be alright if I dun generate correlated query (meaning I generate local context) and have another PR about generating correlated query.

Sounds good.

This show that if I would want to generate correlated query (Not the local query), I need to pass the information about "Cannot have agg" all the way until gen_expr which is too much of parameter passing.

This is a good point, I think the way we workaround unsupported features have added complexity to the code.
I think an alternative to your suggestion is to handle by matching on the error unimplemented!(). I think this will handle a class of errors without having to manually check can_agg, inside_agg depending on the unsupported expression.
This is similar to our approach for runtime errors: https://github.com/risingwavelabs/risingwave/blob/7a12a6ba0d6977d1363888952e4b7d46bb65cc20/src/tests/sqlsmith/src/runner.rs#L139-L145

Lets continue discussion under this issue https://github.com/risingwavelabs/risingwave/issues/6592


Elastic unbounded range query

Been working on this for a couple of days. Find parser generators tricky, so still walking through it in the debugger.
Took time to tidy-up and add comments, where I thought it would be useful.
Had a separate elastic_range parser! function first, thought it would be better for unit testing. Ended up merging its functionality into parser! range function, but finding it hard to debug.
Closes #498

@petr-tik can you fix the unit test?

Weirdly enough, travis reported the build as green, despite the failure in one of the tests
https://travis-ci.org/tantivy-search/tantivy/jobs/570252947#L2601
I think this error proves that our previous parser was inconsistent with assigning bounds and delimiters.
I propose choosing the "{" as a delimiter for the unbounded range like "weight: >50" = "weight:{50 TO *}". Mathematically speaking an unbounded range doesn't have a limit value, therefore has to be exclusive, so we should use the exclusive delimiter for it.

GitHub doesn't give me a button to squash commits. Tried making it locally.
Please review, but don't merge, I will work on squashing this into 1 commit tomorrow (it's past 1am in London)

@petr-tik the default button for merging is "squash and merge"

Can you run cargo fmt? I suspect you will have a few diffs here.

I run cargo-fmt locally (version below) and I didn't get any diffs, when I ran it before the patch.
If you are referring to the indentation in the parser functions - I did this on purpose, because I think it helps legibility.
$$$ cargo-fmt --version
rustfmt 1.2.2-stable (5274b49 2019-04-24)

Please review and approve (re-requested), so I can squash and merge (the button is currently greyed out)

@petr-tik  i'm not fond of the second } on l.121.
It is very hard to see what it's { counterpart is.

@petr-tik thanks

Are you happy with the rest of the PR to approve it, so I can squash-merge?

@petr-tik I don't think you have permission to merge. I will squash-merge as soon as travis is done.

I think I might have such permissions (the merge request buttons were green in other PRs), but I need an approving review.
Let me know how you prefer to do this

I'm ok if you want to merge it.

I approved the changes.

You are right, I cannot merge this PR.
Accessing this PR from my phone (logged in) suggests that I can, but I guess I don't have write access to the repo, which keeps the button greyed out from the web UI


Upgrade faster-whisper 1.1.0rc0

Upgrade to faster_whisper==1.1.0rc0
Enables whisper-turbo
Minor fixes that improves punctatuations

hello  ,  Very happy to have updates but the transcription speed  is much slower this times

@yatoooon We didnt notice anything like that on our end, if you can share your setup, we can try and reproduce the issue.

same_output_threshold was 5 before, now it is 10.

yep, you can play with it, gave me better punctuations, shouldnt slow it down though.


PyTorch Lightning Trainer

Hey there,
First of all, thanks for this library, it looks great.
While reading throught the codebase, it seems there is lot of boilerplate.
Might want to consider PyTorch Lightning : https://github.com/PyTorchLightning.
Best,
T.C

The current main focus of WarpDrive is to provide an end-to-end-at-GPU CUDA boosted multiagent RL environment simulator(step and reset functions) with Python interface.
Thank you for the feedback about using Pytorch Lightning as the training pipeline. Actually the data such as observation and rewards managed by WarpDrive is designed to be directly accessible by Pytorch as torch.Tensor. So a lot of training pipelines can be adopted once WarpDrive provides the RL environment simulator.

Sure, let me ask. Thank you.

@tchaton interesting, could you share an example of another Lightning example that's representative of what you have in mind?

Hey @StephanZheng @Emerald01,
Here are all our RL examples: https://github.com/PyTorchLightning/lightning-bolts/tree/master/pl_bolts/models/rl
Also, we are building tutorials for the Lightning which are added to the documentation : https://pytorch-lightning.readthedocs.io/en/latest/
I would like to get very clean RL tutorial and believe an example with your library would be great.
Best,
T.C

@tchaton loved the collaboration with the team @ pytorch lightning. Thanks! The PL example went online just yesterday :)


Possible to submit multiple, independent projects?

Sorry for my ignorance in case that is possible anyway and I just couldn't figure it out or was misconfiguring things or was discussed already.
Let's say I have a repository with two independent projects project_a/build.sbt and project_b/build.sbt.
Can I submit both of those build.sbt files to GitHub so they show up independent in the /network/dependencies view?
I tried that with the Play Framework were we have a build.sbt and a documentation/build.sbt, but in the GitHub UI only the build.sbt shows up.
The workflow: https://github.com/playframework/playframework/blob/3c21f31f28c27ad00c9495096fa60e25a4b67050/.github/workflows/dependency-graph.yml#L24-L27
I think this has to be possible somehow because in our Dependency UI it shows all our (multiple) yml workflow files already.

Thanks for opening this issue. It should indeed be possible to submit multiple independent projects but currently it is not.
The problem is that currently all manifests are declared as coming from a single build file build.sbt:
https://github.com/scalacenter/sbt-dependency-submission/blob/04f2579de8e5d7ce6049129ff1b6912520d21dfd/sbt-plugin/src/main/scala/ch/epfl/scala/GithubDependencyGraphPlugin.scala#L186-L187
I thing we can fix this by comparing the sbt baseDirectory with the GITHUB_WORKSPACE from Github default env variables.

@adpi2 Thanks! Would be nice to have this working :wink:

Thanks for fixing. However how does that actually work now?
Do I need to run a separate step for each project? E.g.
...
steps:
  - uses: actions/checkout@v3
  - uses: scalacenter/sbt-dependency-submission@v2
    with:
      working-directory: ./my-scala-project-one
  - uses: scalacenter/sbt-dependency-submission@v2
    with:
      working-directory: ./my-scala-project-two

Or does the action detect all build.sbt files automatically?

Thanks for fixing. However how does that actually work now?
Do I need to run a separate step for each project? E.g.

Yes you still need to run a separate step for each project.
The fix is released in 2.2.1. @mkurz Could you test that it works as expected?

@adpi2 Exactly, see my comment https://github.com/playframework/play-mailer/pull/250#issuecomment-1482742155

@mkurz, thanks for the comment. Being able to send the manifests of several build in a single snapshot would require quite some changes in the architecture of the action. I could try it but I think there is a simpler fix.
Currently we use the pair GITHUB_RUN_ID and GITHUB_JOB as identifiers of a snapshot. In your job there are possibly both the same and that would be why the snapshots get overwritten.

Found some interesting documentation about that problem:

Correlator provides a key that is used to group snapshots submitted over time. Only the "latest" submitted snapshot for a given combination of job.correlator and detector.name will be considered when calculating a repository's current dependencies. Correlator should be as unique as it takes to distinguish all detection runs for a given "wave" of CI workflow you run. If you're using GitHub Actions, a good default value for this could be the environment variables GITHUB_WORKFLOW and GITHUB_JOB concatenated together. If you're using a build matrix, then you'll also need to add additional key(s) to distinguish between each submission inside a matrix variation.

@mkurz If you can try again to run your dependency submission that would be very helpful

@adpi2 It's working now :tada:

https://github.com/playframework/play-mailer/actions/runs/4511227545/jobs/7946346475
https://github.com/playframework/play-mailer/network/dependencies

Thanks!


Improve TOTP connector

Is your suggestion related to an experience ? Please describe.
Improve the TOTP connector to support Level of Assurance in API Level.
Describe the improvement
The TOTP endpoint can be improved to check the level of assurance on taking actions which requires higher level authentication (ex: 2FA).

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


Add option to query by language

Given that this is just parameter in the Twitter API, it should be easy to do, and frustrating that it isn't already available

Hi sinzini91,
I'll add this feature to twitterscraper as soon as I have time. For now, you can query Tweets written in a specific language by adding "%20lang%3Aen" (for en/english) to the end of the query. For a list of all available languages and their corresponding abbreviations see https://twitter.com/search-advanced

@sinzin91 This issue should be solved with PR #61


Add example of votable to json conversion

Add example of simple VOTABle 2 json conversion

@lmichel Very interesting indeed :+1:


[Feat]: Adding icons to the Quicklinks

Is there an existing issue for this?

[X] I have searched the existing issues

Feature Description
Adding icons to the Quicklinks section can significantly improve both the visual appeal and the user experience of your website's footer. Currently, the Quicklinks options might appear plain or less engaging, making it harder for users to quickly identify their purpose. By integrating relevant icons next to each Quicklink, you not only enhance the overall aesthetic but also make it easier for users to recognize the links at a glance.

Use Case
This addition adds a visual cue that makes navigation more intuitive, allowing users to quickly understand the link's functionality without needing to read through each label. Ultimately, using icons can create a more polished, professional, and user-friendly footer design.
Benefits
No response
Priority
High
Agreements

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSoC contributor
[X] I'm a Hacktoberfest contributor
[X] I want to work on this issue
[X] I'm willing to provide further clarification or assistance if needed.

@Tejashri-Taral please assign this task to me....I wish to work on this issue

Proceed!

@Tejashri-Taral please checkout my pull request and please add me a level1 label

@Tejashri-Taral can you add me a level1 label


Update azure-pipelines.yml to run tests on Windows CI

Previously, Azure Pipline was not running tests.
This PR fixes Windows CI.

Let's use GH Actions instead.

Yep, you can pretty much copy/pasta this one: https://github.com/zeit/node-file-trace/blob/master/.github/workflows/ci.yml


Abilities and Conditions Windows Truncation / Blank Space

The ability scores/conditions are truncated to a small window, leaving a large blank space to the right of it.
Also, ability names such as "Strength", "Constitution", and so on are missing (image attached).

Yup just realized that today. Will fix it tomorrow.
On Jan 14, 2023 at 1:52 PM -0800, zoonza @.***>, wrote:

The ability scores/conditions are truncated to a small window, leaving a large blank space to the right of it.
Also, ability names such as "Strength", "Constitution", and so on are missing (image attached).
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: @.***>

This is fixed in 1.9.4, though my issue was not as severe as yours. I was missing headers but did not have this blank space.  Seems like an interfering module.

Thank you! Looks like the interfering module was 5e-Custom Abilities & Skills, in case anyone else has the same issue.