Does not support query array  parameters

Currently, grape-swagger does not support query array parameters, setting them to formData by default:
https://github.com/ruby-grape/grape-swagger/blob/master/lib/grape-swagger/doc_methods/parse_params.rb#L87
        def document_array_param(value_type, definitions)
          if value_type[:documentation].present?
            param_type = value_type[:documentation][:param_type]
            doc_type = value_type[:documentation][:type]
            type = DataType.mapping(doc_type) if doc_type && !DataType.request_primitive?(doc_type)
            collection_format = value_type[:documentation][:collectionFormat]
          end

          param_type ||= value_type[:param_type]

          array_items = parse_array_item(
          array_items = parse_array_item(
            definitions,
            type,
            value_type
          )

          @parsed_param[:in] = param_type || 'formData'
          @parsed_param[:items] = array_items

This situations where as long as it is an array parameter, even if it occurs in a get request, by default the parameter's in is set to formData.
However, according to the OpenAPI v2 spec, Query parameters only support primitive types. You can have an array, but the items must be a primitive value type. Objects are not supported.
As such, in situations where there an array parameter's in/param_type is not explicitly defined and it occurs in a GET request and the array items type are non-object primitive value types, it should be set as query type.

I've come across the issue you mentioned regarding query parameters and arrays in the Swagger-Grape gem, and I'd like to share my thoughts on this.
It's important to note that this limitation, where query parameters only support primitive types and arrays must consist of primitive value types, can indeed be a bit restrictive in certain use cases. Not being able to use complex objects in query parameters or arrays within the request payload can be a limitation when working with more complex data structures.
I believe this limitation could potentially be challenging when dealing with more intricate data schemas and API designs, especially when it comes to representing nested or structured data.
It might be beneficial to explore whether this limitation can be addressed or if there's a workaround that allows for more flexibility in the use of complex data structures in both query parameters and request payloads.


[AIRFLOW-3333] New features enable transferring of files or data from GCS to a SFTP remote path and SFTP to GCS path.

Hello,
Here is an ticket related to GCP on Jira:
https://issues.apache.org/jira/browse/AIRFLOW-3333
Lots of love

Duplicated and closed in:
https://issues.apache.org/jira/browse/AIRFLOW-3429

Ongoing.
PRs already created and merged:
https://github.com/apache/airflow/pull/6387
https://github.com/apache/airflow/pull/6378
https://github.com/apache/airflow/pull/6366
https://github.com/apache/airflow/pull/6344
PRs in progress:
https://github.com/apache/airflow/pull/6393
https://github.com/PolideaInternal/airflow/pull/399

Is it done?

One PR until end.

All PRs successfully merged.


Bulk annotation update

The new acls-everywhere branch adds sub-resource apis for acl and acl_binding that superficially look like the existing annotation resource: a collective sub-resource represented as a JSON object with a set of keyed fields, and separate sub-resource URLs to access each keyed field individually.
The new apis also support bulk operation to write a new document to the collective resource and replace and/or reset the whole set of keyed fields underneath. This would also be useful for the annotation api to allow more isomorphic administrative patterns where a client may push in a gold standard config.
Suggested new operation:

PUT .../annotation with JSON document { "annotation key1": "annotation value", ... } which replaces any existing annotations on the same catalog or model resource. The new state of the collective resource will match that described by the input document.
DELETE .../annotation works like PUT with {} input which causes all annotations to be dropped.

This is done for PUT only in the acls-everywhere branch so it will merge with the rest of that PR.


Cancel gift aid

@rjmk I decided to do the changes the accompany cancelling the Gift Aid declaration on the front-end as they did not depend on any previously stored information. What do you think?
Also I am unsure if I need to change all the fields that I did. Maybe gift_aid_signed and date_gift_aid_signed need to remain as they are? Otherwise I don't see the point of having both gift_aid_signed and gift_aid_cancelled.

Yep, I think keep those two variables as they are. Really there shouldn't be both a gift_aid_signed and a gift_aid_cancelled as that gives 4 possibilities but only 3 of them have meaning. Oh well!

@rjmk I am unsure about doing the transformation of the user in the reducer as you suggested. As I understand it that would mean passing down another field into the redux form, creating an action to look out for this change and then sending the form off. The way I have currently done it, the cancel Gift Aid button does not have anything to do with the redux form. Therefore you do not need to enter 'edit' mode, which is a prerequisite for sending the form off unless I am mistaken. I think the UI works better this way.
Also at the moment this cancel gift aid buttons are only displayed if gift_aid_cancelled is true. Pressing this button only changes this entry in DB (as well as date_gift_aid_cancelled). After that the button is not displayed anymore but the state is updated with new values from response. Therefore I do not see the benefits of doing these changes in reducer. What's your opinion?

@ivanmauricio I would stick with doing it in the reducer. It doesn't have to be done through Redux Form. Have a look at something like DEACTIVATED_MEMBER.
I definitely agree that this is the UI we want. But the UI should not contain the logic for updating the state

@rjmk For DEACTIVATED_MEMBER the delete button changes this field in the state but it does not get updated on the DB. It only gets updated when you press save, triggering a form submission. This is why I thought that I would have to involve redux form. Is that not the case?

@rjmk Also I sent you a message on gitter.

@ivanmauricio Sorry I was slightly wrong in my comment -- the changes to the state of the member should not happen in the reducer, but in the action creator. You should export a specific action for this

@ivanmauricio Will check gitter


Copy Edits & RWX Testimonial

[x] Copy Edits
[x] RWX testimonial

I think the testimonial looks great, do we want it second?

I think the testimonial looks great, do we want it second?

@tgsoverly yeah that would be great! Do you have one in mind?


Update the Rust version to compile on macOS

The current version of Rust being used to build is 1.28, which is nearly 5 years old.
This leads to libc not compiling on macOS in the tests.
We should look to update to a newer version, such as 1.76.0 (latest as of the writing of this ticket).

Fixed in #20, thanks!


AutoFixture.AutoMoq does not work with newer versions of Moq without manually changing the project.lock.son file

This problem is super easy to reproduce:

Create a new class library (package) in visual studio 2015
Edit the project.json to depend on AutoFixture, AutoFixture.AutoMoq, and Moq like this:

{
    "version": "1.0.0-*",
    "description": "autofixturetest Class Library",
    "authors": [ "dpeden" ],
    "tags": [ "" ],
    "projectUrl": "",
    "licenseUrl": "",
    "dependencies": {
        "AutoFixture": "3.40.0",
        "AutoFixture.AutoMoq": "3.40.0",
        "Moq": "4.2.1510.2205"
    },
    "frameworks": {
        "net46": { }
    }
}

You will get the following error:

You can manually work around the error by following this guidance:
http://stackoverflow.com/a/34579963/607701
Which is clearly less than desirable.
If you remove the explicit Moq dependency or if you explicitly reference the same version of the dependency of Moq that AutoFixture.AutoMoq depends on, you do not get the dependency resolution error.
This problem is not associated with ASP.NET MVC as originally speculated in the comments of the linked SO post but may be related to dnu build/restore and how it generates the project.lock.json file.

Looks like this should be a matter of fixing the capitalization in the nuspec file.

I looked for that and didn't find it. Thanks for linking the file. I have submitted a pull request to correct the casing.

Does AutoFixture 3.40.1 resolve this issue?

It does, indeed. Thank you for getting the package pushed so quickly.

I got "Moq, Version=4.1.1308.2120, Culture=neutral, PublicKeyToken=69f491c39445e920" FileLoadException after use AutoMoq in VS2017 in regular, <TargetFrameworkVersion>v4.6.1</TargetFrameworkVersion> project.
<PackageReference Include="AutoFixture.AutoMoq">
      <Version>3.50.7</Version>
    </PackageReference>
    <PackageReference Include="AutoFixture.NUnit3">
      <Version>3.50.7</Version>
    </PackageReference>
    <PackageReference Include="Moq">
      <Version>4.7.99</Version>
    </PackageReference>
    <PackageReference Include="NUnit">
      <Version>3.8.1</Version>
    </PackageReference>

@sm-g Could you please create a separate issue for that? Also please provide me with a sample project (zip and attach) where I can reproduce the issue. This will simplify the investigation process.
Thank you in advance.


报bug：stock_zh_index_spot接口报错

Traceback (most recent call last):
File "", line 1, in
File "/root/.local/share/virtualenvs/agu-5NQDdpah/lib/python3.8/site-packages/akshare/index/zh_stock_index_sina.py", line 69, in stock_zh_index_spot
data_json = demjson.decode(res.text)
File "/root/.local/share/virtualenvs/agu-5NQDdpah/lib/python3.8/site-packages/akshare/utils/demjson.py", line 5740, in decode
result = j.decode(txt,
File "/root/.local/share/virtualenvs/agu-5NQDdpah/lib/python3.8/site-packages/akshare/utils/demjson.py", line 4957, in decode
raise errors[0]
akshare.utils.demjson.JSONDecodeError: Can not decode value starting with character '<'

Traceback (most recent call last): File "", line 1, in File "/root/.local/share/virtualenvs/agu-5NQDdpah/lib/python3.8/site-packages/akshare/index/zh_stock_index_sina.py", line 69, in stock_zh_index_spot data_json = demjson.decode(res.text) File "/root/.local/share/virtualenvs/agu-5NQDdpah/lib/python3.8/site-packages/akshare/utils/demjson.py", line 5740, in decode result = j.decode(txt, File "/root/.local/share/virtualenvs/agu-5NQDdpah/lib/python3.8/site-packages/akshare/utils/demjson.py", line 4957, in decode raise errors[0] akshare.utils.demjson.JSONDecodeError: Can not decode value starting with character '<'

新浪接口需要增加时间间隔


Request: Training config repository

Hello,
Thanks for open sourcing this framework!
I'm thinking it could be quite valuable to the community to create further .config repositories, with further documentation.
For example, for someone who would like to train a DAC VAE in stereo, it could be valuable to understand how to modify the existing config, especially if it's for beginners. Maybe a discussion would be a great addition, too, to share results and insights.
Best,
M

Yeah I originally had a lot of configs in here, but decided to pare it down to just ones I've gotten to work before. I could add some more. I also created a Discussions section if people want to talk more about it there.


i18n is cumbersome with devise + simple_form

I'm not sure whether this belongs here or in the simple_form tracker, but here goes.
What is the right way to translate form submit buttons with devise and simple_form? The problem is that the forms for both sign_up and sign_in operate on the same model (e.g. User), and they both use POST. This results in simple_form using the i18n string helpers.submit.user.create for both (or "Create User" if it doesn't exist).

Please use mailing list for questions and in this case, Simple Form one. I believe Simple Form allows you to customize the label per action.


Link error in docs

Thanks for your error report and we appreciate it a lot.
Checklist

I have searched related issues but cannot get the expected help.
I have read the FAQ documentation but cannot get the expected help.
The bug has not been fixed in the latest version.

Describe the bug
Some models require additional [COCO-stuff](http://calvin.inf.ed.ac.uk/wp-content/uploads/data/cocostuffdataset/stuffthingmaps_trainval2017.zip) datasets, such as HTC, DetectoRS and SCNet, you can download and unzip then move to the coco folder. The directory should be like this.

mmdetection
├── data
│   ├── coco
│   │   ├── annotations
│   │   ├── train2017
│   │   ├── val2017
│   │   ├── test2017
│   │   ├── stuffthingmaps
Panoptic segmentation models like PanopticFPN require additional [COCO Panoptic](http://images.cocodataset.org/annotations/panoptic_annotations_trainval2017.zip) datasets, you can download and unzip then move to the coco annotation folder. The directory should be like this.

The href value in the above text should be started with https, or the downloading will be failed since the Chrome has stopped the downloading process.
Mixed Content: The site at 'https://github.com/' was loaded over a secure connection, but the file at 'https://calvin-vision.net/wp-content/uploads/data/cocostuffdataset/stuffthingmaps_trainval2017.zip' was redirected through an insecure connection. This file should be served over HTTPS. This download has been blocked. See https://blog.chromium.org/2020/02/protecting-users-from-insecure.html for more details.

Reproduction

What command or script did you run?

A placeholder for the command.

Did you make any modifications on the code or config? Did you understand what you have modified?
What dataset did you use?

Environment

Please run python mmdet/utils/collect_env.py to collect necessary environment information and paste it here.
You may add addition that may be helpful for locating the problem, such as

How you installed PyTorch [e.g., pip, conda, source]
Other environment variables that may be related (such as $PATH, $LD_LIBRARY_PATH, $PYTHONPATH, etc.)

Error traceback
If applicable, paste the error trackback here.
A placeholder for trackback.

Bug fix
If you have already identified the reason, you can provide the information here. If you are willing to create a PR to fix it, please also leave a comment here and that would be much appreciated!

Is it convenient for you to submit a PR to fix this bug, we will review it as soon as possible.


System testing using "pip install ." to 1) catch bugs before pushing to pypi; 2) avoid 'fake' contributions to downloads

This task will be be a good task to migrate into composite-actions

this approach was used to run composite-actions on the local.


Move routes

I know you like having everything in the one place @sahat but would you be opposed to a PR to move just the routes into their own file? It would really make it easier when rapidly developing. For example, CMD+P in Sublime, start typing 'routes', enter - bam - your routes are right there. Happy to implement.

Please see https://github.com/niallobrien/hackathon-starter/commit/d955e4326e2c4b80b0ea810a68c4ff5eda7e99ac for proposed changes, thanks.

+1 for this, it just makes it easier - even for beginners.

I've submitted a PR for this.


chore(deps): update common-dev-assets digest to 32674f3

This PR contains the following updates:

Package
Update
Change

common-dev-assets
digest
c84fb95 -> 32674f3

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by Renovate Bot.

:tada: This PR is included in version 1.0.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


contribute here button needs to have better css - good color with good hover effect

@rko0211 assign me this issue under apertre24

plz check and merge and close issue @rko0211

Please assign me this issue as assigned one seemed to be inactive .


Not working on kubuntu

i couldnt use it on pardus thats why i install kubuntu and i could install with no error but when i try to run it gives the error below;
Traceback (most recent call last):
File "/usr/local/bin/dragonfire", line 11, in
load_entry_point('dragonfire==0.9.9', 'console_scripts', 'dragonfire')()
File "/usr/local/lib/python3.6/dist-packages/pkg_resources/init.py", line 476, in load_entry_point
return get_distribution(dist).load_entry_point(group, name)
File "/usr/local/lib/python3.6/dist-packages/pkg_resources/init.py", line 2700, in load_entry_point
return ep.load()
File "/usr/local/lib/python3.6/dist-packages/pkg_resources/init.py", line 2318, in load
return self.resolve()
File "/usr/local/lib/python3.6/dist-packages/pkg_resources/init.py", line 2324, in resolve
module = import(self.module_name, fromlist=['name'], level=0)
File "/usr/local/lib/python3.6/dist-packages/dragonfire/init.py", line 45, in
from dragonfire.conversational import DeepConversation
File "/usr/local/lib/python3.6/dist-packages/dragonfire/conversational/init.py", line 14, in
from dragonfire.conversational.textdata import TextData
File "/usr/local/lib/python3.6/dist-packages/dragonfire/conversational/textdata.py", line 15, in
from dragonfire.conversational.corpus.cornelldata import CornellData
ModuleNotFoundError: No module named 'dragonfire.conversational.corpus'
i try to search for it but i couldnt do :(

@syhgorath Have you ever tried to install Dragonfire using install.sh script? Just run: sudo ./install.sh

Yes i did.

I had same issue as your's and i solved using  (https://github.com/DragonComputer/Dragonfire/issues/73)
Just edit your setup.py at Line 94 to whatever python version you are using
If you are using python 3.6 change
'Programming Language :: Python :: 3 :: Only',
to
'Programming Language :: Python :: 3.6 :: Only',
and manually copy corpus folder from
Dragonfire/dragonfire/conversational/
to
/usr/local/lib/python3.6/dist-packages/dragonfire/conversational/
finally run sudo ./install.sh

@KrVignesh could you find a version independent solution (like; both works for Python 3.5 and Python 3.6) and send a pull request?

@syhgorath fixed with https://github.com/DragonComputer/Dragonfire/commit/6f5d0881c27803a9920cba886bae8f07a7b83cce


Tesla app pairing instructions for non-owners

I’ve noticed an unintuitive experience for users who do not own their vehicle, somewhat related to this issue. Essentially the Tesla app doesn't do the best job of setting expectations for what the user will need to do and the fact they will need to be in their vehicle to finish pairing.

When attempting to pair our user was shown the ownership error as expected
However the next screen doesn’t give the user any idea that they need to be in their vehicle. If they tap “approve”…
They see an error with no guidance for the user instructing them that they need to be in their vehicle
If they are in the car when they do this they do see some further instructions and are able to complete the pairing from there

1
2
3
4

App version: iOS v11.1 (2<IP_ADDRESS> 6d34fdd99bae)

Thanks for the feedback. I filed a ticket with the mobile app team.

dont know if its the same error but for me it says "this third person is not registered in tesla"


Import errors with tensorflow version 0.12.1

Hi,
I just cloned your repo and downloaded tensorflow version 0.12.1. I am trying to run your example code. I am getting errors on the imports:
Traceback (most recent call last):
File "main.py", line 5, in
from trainer import Trainer
File ".../pointer-network-tensorflow/trainer.py", line 7, in
from model import Model
File ".../pointer-network-tensorflow/model.py", line 4, in
from layers import *
File ".../pointer-network-tensorflow/layers.py", line 7, in
LSTMCell = rnn.LSTMCell
AttributeError: 'module' object has no attribute 'LSTMCell'.
From looking at the tensorflow docs it seems that LSTMCell is now located at:
tf.nn.rnn_cell.STMCell. I changed the code to read: LSTMCell = tf.nn.rnn_cell.LSTMCell and made a similar change for the next line of layers.py: MultiRNNCell = tf.nn.rnn_cell.MultiRNNCell.
I'm now getting a similar error on the seq2seq line, and can't figure out how to fix it:
Traceback (most recent call last):
File "main.py", line 5, in
from trainer import Trainer
File ".../pointer-network-tensorflow/trainer.py", line 7, in
from model import Model
File ".../pointer-network-tensorflow/model.py", line 4, in
from layers import *
File ".../pointer-network-tensorflow/layers.py", line 9, in
dynamic_rnn_decoder = seq2seq.dynamic_rnn_decoder
AttributeError: 'module' object has no attribute 'dynamic_rnn_decoder'
It seems that tensorflow.contrib.seq2seq exists but does not have a dynamic_rnn_decoder function in version 12.1.0? Can you confirm that this is still working on your version and that you are in fact using tensorflow version 12.1.0.
Thanks!
Maddie

tf.nn.rnn_cell.LSTMCell

It seems that tf 0.12.1 doesn't have dynamic_rnn_decoder or simple_decoder_fn_train, I made it work on tf 1.0.0.
In layers.py:
replace
LSTMCell = rnn.LSTMCell
MultiRNNCell = rnn.MultiRNNCell
dynamic_rnn_decoder = seq2seq.dynamic_rnn_decoder
simple_decoder_fn_train = seq2seq.simple_decoder_fn_train

to
LSTMCell = tf.contrib.rnn.LSTMCell
MultiRNNCell = tf.contrib.rnn.MultiRNNCell
dynamic_rnn_decoder = tf.contrib.seq2seq.dynamic_rnn_decoder
simple_decoder_fn_train = tf.contrib.seq2seq.simple_decoder_fn_train

In model.py: change all tf.concat_v2 to tf.concat.
After that, it will still complain that tf.contrib.layers doesn't contain utils. I modified site-packages/tensorflow/contrib/layers/__init__.py, adding 'utils' into _allowed_symbols, and it worked. Perhap there is a better way to do this.

I changed file model.py as link, and it worked with tensorflow v1.0 without any modification in tensorflow library.

why did you close this issue? I still have the same problem


Result verification - could you please give a pointer to the model used to obtain SPIDER results in the paper?

Result verification - could you please give a pointer to the model used to obtain SPIDER results in the paper?

Hi, please check issue #35 for details! Setting the beam size to 1 gives us better results than setting it to 4.


[lighthouse] Ceiling rate of reconcile should be configurable by route

Problem
What is the problem or opportunity?
Reconcile is expensive when not batched in full, but also impacts rate of router replenishment.
Should have a route-configurable ceiling of time to wait for a batch (10 messages sharing the same origin and destination), so if router utilization spikes (indicating routers should be replenished) it can be addressed directly.
Impact
Why is it important? Who requested it? Who does it impact? What data do we have to suggest this is a problem? Is there specific timelines that increase urgency?
Impacts our ability to configure liquidity vs. cost. See here for experimental results.
Proposed Solution
[OPTIONAL] Thoughts on solution design. We could do  to solve this problem.
Make ceilings route configurable with a global default.
Acceptance Criteria
From an end user perspective, the below criteria must be met to consider this done:

[ ] Process batch times take routes into account.

We currently have destination specific ceilings, do we need path (origin-destination) specific ones?
@alexwhte


Fixes #1300 some words weren't shown on the intro slides

Description
there was a missing backward slash before the single quotation mark, this prevented the remaining text from being shown.
Related issues and discussion
#1300

Merged, thanks @PO15ON


Relicense as dual APACHE/MIT

Fixes #47.
@kvark and @msiglreith please confirm if you're okay with relicensing your contributions.

Yes I'm ok with this.

On Feb 9, 2018, at 01:04, Josh Groves<EMAIL_ADDRESS>wrote:
@kvark and @msiglreith please confirm if you're okay with relicensing your contributions.
You can view, comment on, or merge this pull request online at:
https://github.com/grovesNL/spirv_cross/pull/54
Commit Summary
Relicense as dual APACHE/MIT
File Changes
D LICENSE (201)
A LICENSE-APACHE (201)
A LICENSE-MIT (23)
M README.md (15)
M spirv_cross/Cargo.toml (2)
Patch Links:
https://github.com/grovesNL/spirv_cross/pull/54.patch
https://github.com/grovesNL/spirv_cross/pull/54.diff
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Thanks! bors r+

Thanks! bors r=kvark

Forgot a newline
bors r=kvark


[SPARK-34125][CORE][2.4] Make EventLoggingListener.codecMap thread-safe

What changes were proposed in this pull request?
EventLoggingListener.codecMap change mutable.HashMap to ConcurrentHashMap
Why are the changes needed?
2.x version of history server
EventLoggingListener.codecMap is of type mutable.HashMap, which is not thread safe.
This will cause the history server to suddenly get stuck and not work.
The 3.x version was changed to EventLogFileReader.codecMap to ConcurrentHashMap type, so there is no such problem.(SPARK-28869)
Multiple threads call openEventLog, codecMap is updated by multiple threads, mutable.HashMap may fall into an infinite loop during resize, resulting in history server not working.
https://github.com/scala/bug/issues/10436
PID 117049 0x1c939

Does this PR introduce any user-facing change?
No
How was this patch tested?
exist ut

Can one of the admins verify this patch?

Can one of the admins verify this patch?

ok to test

ok to test

Could we please elaborate more on the impact of the issue in Why are the changes needed? via linking Scala issue as we did in JIRA issue?

Could we please elaborate more on the impact of the issue in Why are the changes needed? via linking Scala issue as we did in JIRA issue?

Test build #134104 has started for PR 31194 at commit 076e28e.

Test build #134104 has started for PR 31194 at commit 076e28e.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38688/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38688/

Test build #134104 has finished for PR 31194 at commit 076e28e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test build #134104 has finished for PR 31194 at commit 076e28e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134104/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134104/

Test build #134117 has started for PR 31194 at commit 2b94425.

Test build #134117 has started for PR 31194 at commit 2b94425.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38700/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38700/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38700/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38700/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38700/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38700/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134117/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134117/

Does this not affect master / 3.x?

Does this not affect master / 3.x?

Yes, we changed it already in Spark 3.0, but as a part of commit and we haven't realized it should be fixed in 2.4.x as well.

Yes, we changed it already in Spark 3.0, but as a part of commit and we haven't realized it should be fixed in 2.4.x as well.

retest this, please

retest this, please

Just triggered Jenkins/GA. Once one of them passes I'll merge this.

Just triggered Jenkins/GA. Once one of them passes I'll merge this.

Test build #134132 has started for PR 31194 at commit 2b94425.

Test build #134132 has started for PR 31194 at commit 2b94425.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38715/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38715/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38715/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38715/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38715/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38715/

Test build #134132 has finished for PR 31194 at commit 2b94425.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test build #134132 has finished for PR 31194 at commit 2b94425.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134132/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134132/

FYI, the first commit already passed with Jenkins here.

Test build #134140 has started for PR 31194 at commit 5ed0ee9.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38723/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38723/

Test build #134140 has finished for PR 31194 at commit 5ed0ee9.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test build #134140 has finished for PR 31194 at commit 5ed0ee9.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134140/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134140/

Test passed. Merging.

Test passed. Merging.

Thanks @cxzl25 for the contribution! Merged to branch-2.4.

Thanks @cxzl25 for the contribution! Merged to branch-2.4.

Thank you all!

Thank you all!


kdfreemob

Issue description

Target framework

[x] .NET Core
[x] .NET Framework
[x] .NET Standard

dotnet --info output or About VS info
<replace>

closing, as I believe this was opened by mistake.


Open guided install nerdlet in a card

Description
The guided install will be opened in a card on top of the explorer nerdlet.
Reviewer Notes
If there are links or steps needed to test this work, add them here.
Related Issue(s) / Ticket(s)
If there are any related GitHub Issues or JIRA tickets, add links to them here.

issue

Screenshot(s)
If relevant, add screenshots here.
Use Conventional Commits
Please help the maintainers by leveraging the following conventional commit
standards in your pull request title and commit messages.
Use chore

for minor changes / additions / corrections to content.
for minor changes / additions / corrections to images.
for minor non-functional changes / additions to github actions, github templates, package or config updates, etc

git commit -m "chore: adjusting config and content"

Use fix

for minor functional corrections to code.

git commit -m "fix: typo and prop error in the code of conduct"

Use feat

for major functional changes or additions to code.

git commit -m "feat(media): creating a video landing page"

@aswanson-nr I haven't worked with modules in a while and it took me longer than I expected to get it working but it's good now.


Errors are not propagated

Bug Report

Versions

Driver: io.r2dbc:r2dbc-mssql:0.9.0.M2
Database: MSSQL19 (Using docker image mcr.microsoft.com/mssql/server:2019-latest
Java: 11
OS: MacOS 11.6 Bug Sur

Current Behavior

When an error takes place during a persistence operation (in my case - I tried to invoke a stored procedure that doesn't exist), it is still handled by the onNext hook of the ReactorNettyClient, instead of being handled by the onError hook. As a result, the error is only seen in the logs (on a debug level, for some reason), and it gets "swallowed" within ReactorNettyClient, instead of being propogated to the error hook defined in the applicaiton code.

![image](https://user-images.githubusercontent.com/11587731/149658692-2efa007b-ad30-4c34-bde4-3f02e2373073.png)
It can be seen that an ErrorToken has been received, stating that the stored procedure cannot be found. Yet it is processed by the onNext hook and the error is consumed there.

Steps to reproduce

Code
Mono.from(connectionFactory.create())
                .flatMap(connection -> {
                            connection.createStatement("EXEC sp_Nonextstent_Stored_Procedure")
                            .execute()
                            .subscribe(new Subscriber<MssqlResult>() {
                                @Override
                                public void onSubscribe(Subscription s) {
                                    log.debug("onSubscribe:" + s);
                                }

                                @Override
                                public void onNext(MssqlResult result) {
                                    log.debug("onNext:" + result);
                                    log.debug("Rows updated: {}", result.getRowsUpdated());
                                }

                                @Override
                                public void onError(Throwable t) {
                                    log.error("onError:", t);
                                }

                                @Override
                                public void onComplete() {
                                    log.debug("Completed");
                                }
                            });

Output:
2022-01-16 13:39:13 [reactor-tcp-nio-3] DEBUG io.r2dbc.mssql.client.ReactorNettyClient -[cid: 0x2] Request: SQLBatch [sql="EXEC sp_Nonextstent_Stored_Procedure"]
2022-01-16 13:39:22 [reactor-tcp-nio-3] DEBUG io.r2dbc.mssql.client.ReactorNettyClient -[cid: 0x2] Response: ErrorToken [number=2812, state=62, infoClass=16, message='Could not find stored procedure 'sp_Nonextstent_Stored_Procedure'.", serverName='sql19", procName='", lineNumber=16777216]
2022-01-16 13:39:22 [reactor-tcp-nio-3] DEBUG io.r2dbc.mssql.client.ReactorNettyClient -[cid: 0x2] Warning: Code [2812] Severity [GENERAL_ERROR]: Could not find stored procedure 'sp_Nonextstent_Stored_Procedure'.

Expected behavior/code
The onError hook should've been invoked. In practice, none of the client hooks are invoked. The error is consumed by the internal onNext hook, as shown in the screenshot.
Possible Solution
If the message is an instance of an ErrorToken, might it be possible to route it to the onError hook?
Thanks

Does the same happen with version 0.9.0.RELEASE?

It does. (I switched my r2dbc-spi to 0.9.0.RELEASE, accordingly)
Furthermore, even when the operation does succeed, neither the onNext nor the onComplete hooks are invoked, so I can't know that the persistence is successful either.
Is my code incorrect, or is indeed an issue in the driver?

Thanks for verifying. I now see what causes the issue: The code calls execute() without consuming results. The actual execution happens in a later stage when you subscribe to the Result methods. As soon as you e.g. flatMap(Result::getRowsUpdated).subscribe(…) you will see the correct signals. Statement.execute() returns a publisher of results that is a promise for execution. In R2DBC, results must be consumed, otherwise, they will block the transport channel when left unconsumed.

Thanks for the prompt response, mark!
Subscribing on Result::getRowsUpdated works like a charm! :-)
I noticed a behavior that you might want to check, though.
The relevant code piece from my side looks like this:
                            .subscribe(statement -> statement
                                    .execute()
                                    .flatMap(Result::getRowsUpdated)
                                    .doOnError(t -> log.error("Error executing statement: ", t))
                                    .doOnComplete(() -> log.debug("Statement execution completed"))
                                    .subscribe(numRows -> {
                                        log.debug("Transaction successful, {} rows affected", numRows);
                                    }));

When the statement is a direct SQL operation (e.g. INSERT INTO...), the lambda in the subscribe is invoked only once, as expected. Yet in case it's an execution of a stored procedure, it is invoked twice, for some reason.
Is this a normal behavior?


Backwards support for GPUShaderModule.compilationInfo()

This API was recently renamed. Fall back to the old API if the new one is not found.
Fixes: #72

Humm, doesn't work:
TypeError: Failed to execute 'compilationInfo' on 'GPUShaderModule': Illegal invocation

Awesome, thank you.


Change shown sequential number and add a space

Closes #2876

A nbsp would be too large. A space is cleared by the code prettifier,


Combine integration test struct into themes

This cleans up the integration test directory a bit. No need to review code, just structure. I've broken the tests up into integration themes: proxying, join (maybe eventually rolled into SWIM integration), ring tests.
test
test/integration/
test/integration/join-test.js
test/integration/proxying-test.js
test/integration/ring-test.js

@mrhooray @Raynos

lgtm.


Bump to docker 1.10-dev and dependencies

This is more a try (or a "it would look like this" kinda thing) than a real thing because this feels almost too early to bump a docker version but as we still don't have versions, so it feel safer (will probably just have to bump it on the way later too).
Anyway, what this does is bumping to current master (my dream is to bump it on a tag but… it's not gonna happen until 1.10) to remove the autogen/dockerversion thingy and make it go gettable/buildable/testable, and thus would fix #32.

go gettable/…
No more use of go generate,
Keep the source up-to-date and update a little tiny bit the code base to compile with it :wink:.

@ibuildthecloud @docker/libcompose-maintainers WDYT ?
Signed-off-by: Vincent Demeester<EMAIL_ADDRESS>

I like the idea, and I'm fine with pulling this in before 1.10 is released.  It's almost safer to bump now as it's closer to 1.9 as it is right now.

@ibuildthecloud cool :smile_cat: Then I have to see why the integration tests are failing and fix it :stuck_out_tongue_closed_eyes:.

Updated with some fixes. I splited the commit into two, one for the vendoring, the other one for the fix.
Build should be green :wink:.

Great idea @vdemeester ! Very happy with this :) as it will be go gettable it appears

ping @ibuildthecloud @dnephin

Changes in the second commit seem fine.
I think it's ok to use a pre-release version of Docker.
Can't really review the vendor/ change
LGTM

@vdemeester Does this work with docker-1.9.1? If it does, maybe vendor it?

@imikushin I could update the "hash" but the dockerversion thingy was not cherry-picked on 1.9.1 so the whole point of this PR wouldn't be met with 1.9.1 :stuck_out_tongue_closed_eyes:

@vdemeester to get rid of go generate? okay :+1:

@vdemeester Do you have any timeline on when this will be merged?

LGTM


Create no-labels version of Tron

return buildings to original color:
https://github.com/tangrams/tron/commit/1726d4ef7cd6a5638c8204d7064bfa194781c16a
https://github.com/tangrams/tron/commit/0433f4b4741a346c9f4495a21a45404ce6073c96

this is in progress:
https://github.com/tangrams/tron/commit/f45a999c676aa6d3db96601d2e13e3a16c681cfe

This is mostly working now, small about of DAT ux work left.

Fixed DAT ux work in 9548991bc5d2595b1ee3a8220c2266a44c141dd1.
There are a few townspots that don't hide at zoom 9 and 10. Once that is fixed this can be closed.


Search bar on the left text has poor visiblity and doesn't seem to do anything

When I type stuff inside it, the text has poor visibility plus when I press enter or click the search icon, it doesn't do anything at all.
Browser: Librewolf 132.0-1 (Firefox fork)

The issue with the search bar on the left, which had poor visibility and appeared to be non-functional, has been fixed.


ls on windows doesn't seem to work

From<EMAIL_ADDRESS>on 2010-10-21T20:26:38Z
What steps will reproduce the problem?

typing ls in the command line seems to fire up a dos window which is quickly closed before displaying any output. What is the expected output? What do you see instead? Given that pwd works I thought ls would list the local files. What version of the product are you using? On what operating system? 2.0.0beta5
windows xp 64

Please provide any additional information below
.
Original issue: http://code.google.com/p/spyderlib/issues/detail?id=423

From pierre.raybaut on 2010-10-27T13:07:04Z
Unfortunately the pop-up command window can't be avoided because it's related to Python implementation on Windows: if you run Spyder without console (spyder.pyw -- or from the Python(x,y) launcher) some bugs like this will happen ; on the contrary, when running Spyder with a console (spyder.py) it won't happen.
Now, with or without this pop-up command window, the 'ls' command is working on Windows.

From pierre.raybaut on 2010-11-10T10:56:41Z
issue #447 has been merged into this issue.

From pierre.raybaut on 2011-10-29T04:47:02Z
Status: Fixed

From pierre.raybaut on 2011-05-16T01:15:46Z
Labels: Cat-Console


ENH: Micro-optimizations for spatial.transform.Rotation methods

Reference issue
N/A
What does this implement/fix?
Makes a couple small optimizations for Rotations:

Skip an extra numpy array copy operation when instantiating rotations.
Skip normalization when inverting rotations.
Skip normalization when raising to the first power and returning a copy of self

Additional information
N/A

Pinging @nmayorov for review


Add integration tests with Apalache for list operators

Closes #688

[x] Tests added for any new code
[x] Ran npm run format (or had formatting run automatically on all files edited)
[x] Documentation added for any new functionality
[x] Entries added to the respective CHANGELOG.md for any new functionality
[x] Feature table on README.md updated for any listed functionality

This won't pass CI until a new release of Apalache is cut which includes https://github.com/informalsystems/apalache/pull/2515

Thanks for the review.


Error via API on checking

I am getting the below error when running the code via the API.
Unhandled rejection Error: getaddrinfo EAI_AGAIN github.com:443
    at Object.exports._errnoException (util.js:874:11)
    at errnoException (dns.js:31:15)
    at GetAddrInfoReqWrap.onlookup [as oncomplete] (dns.js:77:26)

Looks like some proxy issue as I am able to run via CLI.

The complete code that I am running is below for reference.
"use strict";

var blc = require("broken-link-checker");
var options = {};

var handlers =
	{
		html: function(tree, robots, response, pageUrl)
		{
			console.log(response);
		},
		junk: function(result)
		{
			console.log(result);
		},
		link: function(result)
		{
			console.log(result);
		},
		page: function(error, pageUrl)
		{
				console.log(error.name + " : "+ error.message );
		},
		end: function()
		{
			console.log(data.total.pages);
		}
	};

var siteChecker = new blc.SiteChecker(options,handlers);

siteChecker.enqueue("https://github.com");

If it's a proxy issue, then it's related to #25

In my case the issues are even before starting the validation. But n other
issue, prixy issue was for one is the link.
On 15-Mar-2016 8:08 pm, "Steven Vachon"<EMAIL_ADDRESS>wrote:

If it's a proxy issue, then it's related to #25
https://github.com/stevenvachon/broken-link-checker/issues/25
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
https://github.com/stevenvachon/broken-link-checker/issues/28#issuecomment-196848487

I get no errors running your code.

It was due to proxy and I suggest to have friendly error message on this case as it was for that linked issue.

I haven't done any testing with proxies yet, mainly because the request library that's used doesn't support them. request lib is very sloppy under the hood, so I'm waiting for the next release. Closing this for now, as we have #25 open.


Node-Level IAM Permissions and Potential StorageClass-Level Separation

Tell us more about this new feature.
Hi,
I would like to initiate a discussion—or request additional documentation if available—regarding the separation of permissions at the node level.
During my evaluation of the application, I observed that IAM permissions are granted at the node level. This requires specifying each individual S3 bucket within the policy. Additionally, if we install the app and later need to add more S3 buckets, we must update the policy to include the new buckets.
Is there a way to address this at the StorageClass level?
My goal is to enable us to install the application once on an EKS cluster, after which different teams can extend its functionality. They would do so by creating their own permissions in S3 and defining a dedicated StorageClass that leverages these specific permissions. This approach would allow us to control which StorageClass has access to which bucket, ensuring a clear separation of access rights.
Thanks

Hi, it looks like you're using the Mountpoint CSI Driver.
It looks like your feature request is pretty similar to this one: https://github.com/awslabs/mountpoint-s3-csi-driver/issues/111, which you can 👍.
Though if you need something on the storage class level, you might want to create a feature request on the CSI Driver repository: https://github.com/awslabs/mountpoint-s3-csi-driver


Any plan to add Swin transformer?

Swin transformer achieves higher accuracy in model size and computational amount similar to ViT.
I think that using clip's method and dataset will show higher performance.

ViT-B/16, 384x384, 86M, 55.4Gflops, 77.9 (imagenet 1k acc)
Swin-B, 384x384, 88M, 47.0Gflops, 84.5 (imagenet 1k acc)

reference : Swin Transformer table 1 (a)
It would be great if a Swin transformer could be added to compare performance.
Although Resnet is still powerful, I would like to compare whether the performance that was too poor compared to ViT showed that transformer showed overwhelming performance compared to convolution in vision field. Therefore, it would be nice to add famous convolution-based networks such as Efficientnet and Convnext.

It is excactly what I've expected too

I've expected , too


:bug: Fixing json parse error

Tried to open a PR with the GitHub cli, trying again!

Tried to open a PR with the GitHub cli, trying again!


Expose TypeScript-specific globbing behavior

Today, TypeScript's globber uses a custom strategy that acts differently from other tools. This is an issue for 3rd party users who need to consume TypeScript's APIs, but need to validate that a file belongs to a compilation. #32564 dives into some of the discussion around this.
This API doesn't have to be the same as matchFiles - but it needs to compose well with the rest of our API.

@DanielRosenwasser should this be part of a meta-issue along the lines of "tsc.js should be implementable using only public APIs"? (Since that's what API consumers are essentially trying to do.) So we audit other possible concerns?

Sure, a minimal core of tsc.js at the very least makes sense. Letting API consumers drive these requests seems like a reasonable way of getting there.

Happy to see this discussion, although I'm quite sure there's an open issue regarding this API (lost and forgotten by time and indexes). I might have even commented in one.
Anyhow, it's not just about powering tsc-like builds programmatically. I personally wanted to create a language service using a custom host around my own in-memory fs implementation. The only way I got the globbing behavior to match typescript's default node host was to expose this internal API:
https://github.com/wixplosives/file-services/blob/master/packages/typescript/src/typescript-internals.d.ts
Needed it to provide a readDirectory implementation, which is basically a proxy to this function. I needed other internal APIs as well, but this is a good start, heh. :)

Better late than never: https://github.com/microsoft/TypeScript/issues/13793


catching exceptions

from time to time i get:
FacebookResponseException in FacebookResponseException.php line 105: An unexpected error has occurred. Please retry your request later.
any ideas how to try and catch it? I've tried a couple things but i fail.
in my example i am doing
$token = Session::get('fb_user_access_token');
$fb->setDefaultAccessToken($token);
$request   = $fb->sendRequest('GET', '/' . $query);
$graphNode = new GraphNodeFactory($request);
do i put the try catch around that?

never mind, yes i was right


Uninstall inmanta packages from compiler service on update

Description
Make the compiler service remove inmanta packages from the compiler venv on update.
closes #4718
Self Check:

[x] Attached issue to pull request
[x] Changelog entry
[x] Type annotations are present
[x] Code is clear and sufficiently documented
[x] No (preventable) type errors (check using make mypy or make mypy-diff)
[x] Sufficient test cases (reproduces the bug/tests the requested feature)
[x] Correct, in line with design
[ ] End user documentation is included or an issue is created for end-user documentation

Reviewer Checklist:

[ ] Sufficient test cases (reproduces the bug/tests the requested feature)
[ ] Code is clear and sufficiently documented
[ ] Correct, in line with design

Processing this pull request

Merged into branches master in 974f3e13ab6ec0f1de40dcda7ccebcdb8c36a49a

Processing #4784.


Please add specific release command to juliaup help text

Please add something like this to the juliaup help text:
To launch a specific Julia version, say in channel release, run julia +release.
Otherwise there's no way to discover this without coming to GitHub.

Note that the help text does include this information, but perhaps too hidden?
$ juliaup
The Julia Version Manager

Usage: juliaup <COMMAND>

Commands:
  default   Set the default Julia version
  add       Add a specific Julia version or channel to your system. Access via `julia +{channel}` e.g. `julia +1.6`
[...]

I made PR #779 to show a similar message at the end of the full help text, perhaps that makes it easier to see / harder to miss?

Yeah, I would have overlooked it because I'm not trying to add, I'm trying to run.


Link to failed plugins

If a plugin is invalid we can still link to it, this PR enables that functionality.

Solid stuff again! 🔥


Support write environment file such like .env, .local.env

I know there is a way to add commend before or after each deploy step. But a large configuration file is not good to write in a command.
So support to write some files to the release path is much nice.
In order to achieve this, we need a model [StaticFile] to store the files for each project !

Thanks


uWSGI wheel: Apply patch to work around pyuwsgi bug on macOS

See unbit/uwsgi#1680
I don't want to update the version to some kind of custom tag like 2.0.15+gx1, because that moves us further from pip install -r requirements.txt without needing wheels.galaxyproject.org. This issue only affected macOS, only (at least for @dannon and me) when logging in over ssh. The existing 2.0.15 Linux wheels are fine, and uWSGI 2.0.15 was mot included in Galaxy's requirements.txt until 17.09.
I propose that I just replace the existing macOS wheel for 2.0.15 on wheels.galaxyproject.org with this fixed one. macOS users on 17.09 or later who've already downloaded the broken wheel and who encounter this problem can simply reinstall with:
(.venv)$ pip install --index-url https://wheels.galaxyproject.org/simple/ --upgrade uWSGI==2.0.15

Or just drop --index-url https://wheels.galaxyproject.org/simple/ to compile and install from the source tarball from PyPI.

@dannon want to try this one as well?: https://depot.galaxyproject.org/starforge/wheels/build-272/uWSGI-2.0.15-cp27-cp27m-macosx_10_6_intel.whl

@natefoo Works great.

Okay, I've replaced only the macOS wheel on wheels.galaxyproject.org with the one from build 272.


Updated dependencies

DO NOT MERGE YET!

Bumped to 0.4.0

There are some tests failing, perhaps because of new coefficients in the image library.

Seems likely to be the coefficient change. I'll update the tests tomorrow.

Feel free to merge or base your PR on this one.


[Fix] dive should pass along options from shallow

I made it, could you check this source?
I only added a logic that merges options to dive()
refs: #770

@ljharb this might be a major, no? it can break existing tests for components that depend on context being available/not available.

@nfcampos my thinking is that a component that expects context would never be used or tested without context - thus, what would be the use case for having a test that this change breaks?
This also will pass through the lifecycle flag, but we're planning to enable that by default in the next major anyways.

I fixed it. I tried to apply your feedbacks.
Could you check it out? thanks!

@ljharb only got to this now — ive been without internet at home for the better part of two weeks :( — thinking about this some more I could agree with this being a patch, arguably the previous behaviour was wrong, the expectation in react for a child to receive the same thing in context as its parent, what do you think?

I think I agree that it should be a patch.

@blackpost38 do you mind reabsing this on latest master?

@nfcampos It's done.

Thanks @blackpost38 !


bug: ion-searchbar error icon svg

Bug Report
Ionic version:
[x] 5.x
Current behavior:
When I use the ion-search-bar  i can see error on console
zone.js:1127 GET http://localhost:8100/svg/arrow-back-sharp.svg 404 (Not Found)
zone.js:1127 GET http://localhost:8100/svg/search-sharp.svg 404 (Not Found)
I have already imported ionicons:
{
"glob": "**/*.svg",
"input": "node_modules/ionicons/dist/ionicons/svg",
"output": "./svg"
},
Steps to reproduce:
Related code:
  <ion-card-content class="ion-margin">
    <ion-searchbar show-cancel-button="false"></ion-searchbar>
  </ion-card-content>

Which Ionicons Version so you have installed?

Thanks for the issue. Are you using the latest version of Ionicons (v5)? Certain icons did not exist until v5.


Runtime Logs disappear if idling on logs page

On a project, go to runtime logs. Wait a few minutes, the logs will disappear after some time. You have to refresh to see them again.

Could not reproduce. I see this was added a while ago so I am closing for now.

@JarrodMFlesch I am able to reproduce pretty consistently in production


Update layers.js

修改资源下载为CN镜像站

Do not try to update the squad maps link. I have no idea where even that points to.


Extracting Taskwarrior version method issue

I'm getting an error when running a cronjob that is supposed to sync tasks. In short, the error traceback boils down to the place to the backend.py file TaskWarrior client:
    def _get_version(self):
        p = subprocess.Popen(
            self._get_task_command() + ['--version'],
            stdout=subprocess.PIPE,
            stderr=subprocess.PIPE)
        stdout, stderr = [x.decode('utf-8') for x in p.communicate()]
        return stdout.strip('\n')

running the subprocess.Popen where self._get_task_command() is returning task
Traceback (most recent call last):
...
  File "/Users/leikoilja/Development/Envs/nvim/lib/python3.8/site-packages/tasklib/backends.py", line 112, in __init__
    self.version = version_override or self._get_version()
  File "/Users/leikoilja/Development/Envs/nvim/lib/python3.8/site-packages/tasklib/backends.py", line 151, in _get_version
    p = subprocess.Popen(
  File<EMAIL_ADDRESS>line 854, in __init__
    self._execute_child(args, executable, preexec_fn, close_fds,
  File<EMAIL_ADDRESS>line 1702, in _execute_child
    raise child_exception_type(errno_num, err_msg, err_filename)
FileNotFoundError: [Errno 2] No such file or directory: 'task'

The weird part is that when I run task --version from my user it returns 2.5.1, but using a job through crontab -e(these jobs should run using the same user) it ends up in the error.

Ops, sorry, just realized it's the problem of how the 3rd party package is implemented that I am using for cronjob.
My solution is open PR in the 3rd party package to specify task_command="/usr/local/bin/task" when initializing TaskWarrior client

Ops, sorry, just realized it's the problem of how the 3rd party package is implemented that I am using for cronjob.
My solution is open PR in the 3rd party package to specify task_command="/usr/local/bin/task" when initializing TaskWarrior client


Tooltips conflict with agm-map

Describe the bug
If a tooltip is assigned to a disabled button, it goes behind the nearby Google Map.
How to reproduce
Steps to reproduce the behavior:

Go to 'https://stackblitz.com/edit/clarity-v4-light-theme-3tvwya?file=src/app/app.component.html'
Hover mouse on the enabled top button - tooltip is OK
Hover mouse on the disabled bottom button - tooltip is cut off

Expected behavior
Tooltips don't get cut off for disabled buttons
Versions
App

Angular: clarity demo default
Node: clarity demo default
Clarity: clarity demo default

Device:
Firefox, Chrome
Additional notes

@duzenko  you are right, we need to check why the z-index change for disabled tooltips.
This is an easy fix ( I think ) we gonna investigate and try to include it in the next releases.

@duzenko you are right, we need to check why the z-index change for disabled tooltips.
This is an easy fix ( I think ) we gonna investigate and try to include it in the next releases.

That was my first thought too but I can't see that z-index actually changes for disabled buttons.
I may be wrong with this, too. I'm no css guru.

After inspecting it,
.btn.disabled, .btn:disabled {
  opacity: .4;  /* this is triggering the issue */
}

I don't have a solution right now, will have to play a little more

It seems that it's more complicated than I expected.
The issue is that the parent element is setting the opacity so this is messing up the viewing order. Try to set the correct opacity to the child element but that did not have any effect. An experimental solution that I found was to use color with opacity value (rgba) - but this will require a lot of workarounds related to the disabled state and the tooltip.
We have in the roadmap to rework the tooltips and we are reworking our color schema and theming at the moment.
I think that this issue will be best addressed there. For the moment as a workaround, I could suggest changing the position of the tooltip if possible - so it won't be shown on top of the affected component.

Using opacity: 1 as a workaround in our app for now


Backup failed

Steps to reproduce the behaviour

Settings > backup and export > create backup

Expected behaviour
Backup gets created
Actual behaviour
Get a message that says backup failed. There is a zero bytes file in the backup location.
This has started to happen since the beta version was installed.
Software specifications

GnuCash Android version: 2.4.1 beta 2
System Android version: Android 10
Device type: OnePlus 6t

When I try to export XML via Export > XML
I get the following message which may be related to the backup as they're both XML backups?
Error exporting XML file
Failed to generate GNUCash XML-guid  not exists in commodity db

Is there any way to back up the app data other than exporting the XML?
I've tried "adb backup -f org.gnucash.android.ab -apk org.gnucash.android " however it creates an empty backup file. The manifest says that allowBackup is set to true so this should work?

I restored a backup from before this issue occurred and manually entered missing transactions. The backups now work on the beta version of the app.


support automatic provisioning of backing PVs using a configurable StorageClass

I am currently supporting a customer on the Digitalocean Kubernetes (DOKS) platform who has deployed longhorn to their cluster. They have encountered a problem where pods are being evicted from one of their worker nodes with the following eviction message:
  Warning  Evicted    12m        kubelet, pool-7mdtiup01-irwf  The node was low on resource: ephemeral-storage. Container <name> was using 68Ki, which exceeds its request of 0.

I believe this is because longhorn is using a default-data-path of /var/lib/rancher/longhorn/ which is on the node's rootfs. My first impulse was to seek out a way to tell longhorn to automatically provision volumes and mount them onto nodes using the do-block-storage StorageClass, but the closest thing I have found is setting default-data-path to point to a volume that is already mounted at a specific location on worker nodes. I brought this issue up in slack and was recommended to do the following:
bq.  add more disks to the node and ask Longhorn to use those disk instead, e.g. by disable scheduling in the root disk or add tags to the disk, see https://github.com/longhorn/longhorn/blob/master/examples/storageclass.yaml for examples on customize storage class
Which is a slight improvement in that it seems one point longhorn to pre-mounted volumes by disk tag rather than datapath.
But this still seems sub-optimal to me since in theory longhorn itself could be made responsible for provisioning volumes using a configurable storage class (eg do-storage-class on DOKS) and attaching/mounting those volumes to a specified node.

Is this still being considered? I'd also like to use something like this on Linode. Another way I was thinking of achieving this is to have a controller deployed that on node up automatically creates and mounts a new block storage device to a node on Longhorns default-data-path.
I'm wondering what would be the simplest / most universal solution to achieve this as most k8s providers have a block storage option with ReadWriteOnce available and Longhorn would then allow me to use ReadWriteMany and have redundancy.
Is there a recommended way of doing this so that we don't have to manually mount the volumes and when the nodes get "refreshed" we don't have the volumes mounted anymore ...
My end goal is to have:

ReadWriteMany available
have redundancy
storage needs to be automatically added (it can be predefined in size for example, but should not rely on the original nodes to be there always)
I'm trying to use this as an infrastructure for Wordpress, Grav and other similar applications that if scaled expect the same files to be available for all the replicas

If someone has some other idea I'm all for it.


Update rdm to 0.8.3-2550

After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} left no offenses.
[x] The commit message includes the cask’s name and version.

This isn't the latest version, but the latest (stable) version for macOS is not accessible without paying a subscription fee – in other words, I can't get to a download link for the latest version. Waiting until a new stable version is released for macOS on its GitHub repository.


SearchBar styles

how do I remove the outline of the searchbar?

@jjhesk You can use containerStyle or inputStyle based on what you need.

yes.thanks