Support vendor verify

The scripts is copied from @liggitt kubernetes pr  and make a small modification

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: hzxuzhonghu
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: geeknoid
If they are not already assigned, you can assign the PR to them by writing /assign @geeknoid in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS
pkg/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hzxuzhonghu: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/shellcheck.sh
a016a33eedc1598604624e766651d6e470a2c391
link
/test istio-shellcheck-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/shellcheck.sh
a016a33eedc1598604624e766651d6e470a2c391
link
/test istio-shellcheck-master

prow/istio-lint.sh
a016a33eedc1598604624e766651d6e470a2c391
link
/test istio-lint-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: hzxuzhonghu
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: rshriram
If they are not already assigned, you can assign the PR to them by writing /assign @rshriram in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-lint.sh
a016a33eedc1598604624e766651d6e470a2c391
link
/test istio-lint-master

prow/shellcheck.sh
c0be45a108e441d190ac8c65a97d00d4b18c5577
link
/test istio-shellcheck-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/cc @geeknoid

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-lint.sh
a016a33eedc1598604624e766651d6e470a2c391
link
/test istio-lint-master

prow/shellcheck.sh
c0be45a108e441d190ac8c65a97d00d4b18c5577
link
/test istio-shellcheck-master

prow/integ-mixer-k8s-k8s-presubmit-tests.sh
c0be45a108e441d190ac8c65a97d00d4b18c5577
link
/test integ-mixer-k8s-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-lint.sh
a016a33eedc1598604624e766651d6e470a2c391
link
/test istio-lint-master

prow/shellcheck.sh
c0be45a108e441d190ac8c65a97d00d4b18c5577
link
/test istio-shellcheck-master

prow/integ-mixer-k8s-k8s-presubmit-tests.sh
c0be45a108e441d190ac8c65a97d00d4b18c5577
link
/test integ-mixer-k8s-k8s-presubmit-tests-master

prow/integ-telemetry-k8s-presubmit-tests.sh
c0be45a108e441d190ac8c65a97d00d4b18c5577
link
/test integ-telemetry-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/shellcheck.sh
c0be45a108e441d190ac8c65a97d00d4b18c5577
link
/test istio-shellcheck-master

prow/integ-mixer-k8s-k8s-presubmit-tests.sh
c0be45a108e441d190ac8c65a97d00d4b18c5577
link
/test integ-mixer-k8s-k8s-presubmit-tests-master

prow/integ-telemetry-k8s-presubmit-tests.sh
c0be45a108e441d190ac8c65a97d00d4b18c5577
link
/test integ-telemetry-k8s-presubmit-tests-master

prow/istio-lint.sh
c0be45a108e441d190ac8c65a97d00d4b18c5577
link
/test istio-lint-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/shellcheck.sh
c0be45a108e441d190ac8c65a97d00d4b18c5577
link
/test istio-shellcheck-master

prow/integ-mixer-k8s-k8s-presubmit-tests.sh
c0be45a108e441d190ac8c65a97d00d4b18c5577
link
/test integ-mixer-k8s-k8s-presubmit-tests-master

prow/integ-telemetry-k8s-presubmit-tests.sh
c0be45a108e441d190ac8c65a97d00d4b18c5577
link
/test integ-telemetry-k8s-presubmit-tests-master

prow/istio-lint.sh
c0be45a108e441d190ac8c65a97d00d4b18c5577
link
/test istio-lint-master

prow/integ-mixer-k8s-presubmit-tests.sh
c0be45a108e441d190ac8c65a97d00d4b18c5577
link
/test integ-mixer-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-mixer-k8s-k8s-presubmit-tests.sh
c0be45a108e441d190ac8c65a97d00d4b18c5577
link
/test integ-mixer-k8s-k8s-presubmit-tests-master

prow/integ-telemetry-k8s-presubmit-tests.sh
c0be45a108e441d190ac8c65a97d00d4b18c5577
link
/test integ-telemetry-k8s-presubmit-tests-master

prow/integ-mixer-k8s-presubmit-tests.sh
c0be45a108e441d190ac8c65a97d00d4b18c5577
link
/test integ-mixer-k8s-presubmit-tests-master

prow/istio-lint.sh
399e7b68a4ec7e28c109f9679597d5f594d2c756
link
/test istio-lint-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-telemetry-k8s-presubmit-tests.sh
c0be45a108e441d190ac8c65a97d00d4b18c5577
link
/test integ-telemetry-k8s-presubmit-tests-master

prow/integ-mixer-k8s-presubmit-tests.sh
c0be45a108e441d190ac8c65a97d00d4b18c5577
link
/test integ-mixer-k8s-presubmit-tests-master

prow/istio-lint.sh
399e7b68a4ec7e28c109f9679597d5f594d2c756
link
/test istio-lint-master

prow/integ-mixer-k8s-k8s-presubmit-tests.sh
399e7b68a4ec7e28c109f9679597d5f594d2c756
link
/test integ-mixer-k8s-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

the jq is not installed, @howardjohn should i install it here https://github.com/istio/test-infra/blob/a9ed9324824392f6554bf681872d449f81dcb3c0/docker/istio/istio/install.sh?

opened https://github.com/istio/test-infra/pull/1364/

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-lint.sh
399e7b68a4ec7e28c109f9679597d5f594d2c756
link
/test istio-lint-master

prow/integ-mixer-k8s-k8s-presubmit-tests.sh
399e7b68a4ec7e28c109f9679597d5f594d2c756
link
/test integ-mixer-k8s-k8s-presubmit-tests-master

prow/integ-mixer-k8s-presubmit-tests.sh
399e7b68a4ec7e28c109f9679597d5f594d2c756
link
/test integ-mixer-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

I don't really want code to verify that vendor is correct, I want to get rid of the vendor directory completely in the coming weeks. It is completely redundant and is largely deprecated given go modules. We're already not using it in our other repos.

/retest

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-mixer-k8s-k8s-presubmit-tests.sh
399e7b68a4ec7e28c109f9679597d5f594d2c756
link
/test integ-mixer-k8s-k8s-presubmit-tests-master

prow/integ-mixer-k8s-presubmit-tests.sh
399e7b68a4ec7e28c109f9679597d5f594d2c756
link
/test integ-mixer-k8s-presubmit-tests-master

prow/istio-lint.sh
399e7b68a4ec7e28c109f9679597d5f594d2c756
link
/test istio-lint-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@geeknoid You can not assume every one have very well network environment to get all the vendors.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-mixer-k8s-presubmit-tests.sh
399e7b68a4ec7e28c109f9679597d5f594d2c756
link
/test integ-mixer-k8s-presubmit-tests-master

prow/istio-lint.sh
399e7b68a4ec7e28c109f9679597d5f594d2c756
link
/test istio-lint-master

prow/integ-pilot-k8s-presubmit-tests.sh
399e7b68a4ec7e28c109f9679597d5f594d2c756
link
/test integ-pilot-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-pilot-k8s-presubmit-tests.sh
399e7b68a4ec7e28c109f9679597d5f594d2c756
link
/test integ-pilot-k8s-presubmit-tests-master

prow/istio-lint.sh
099b92adb6e384759e6bc6be878ed437c4babf71
link
/test istio-lint-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/codecov.sh
2680957006ef989370a0191b8f93b59f1557657d
link
/test istio-codecov-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test istio-codecov-master

@howardjohn Now the test-infra image has been updated, can I think the vendor check can pass now.

@hzxuzhonghu: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/racetest.sh
d4a4f7403632064866df2ddb90870b70123d4522
link
/test istio-racetest-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/racetest.sh
d4a4f7403632064866df2ddb90870b70123d4522
link
/test istio-racetest-master

prow/integ-mixer-k8s-presubmit-tests.sh
d4a4f7403632064866df2ddb90870b70123d4522
link
/test integ-mixer-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn @geeknoid what's your concern? The pr is conflicting frequently, I have rebased many times.

I don't know why we need all this complexity. Why can't we just do go mod tidy && go mod vendor&& git status? That is what we did with dep.
I think Martin already gave his opinion

I don't really want code to verify that vendor is correct, I want to get rid of the vendor directory completely in the coming weeks. It is completely redundant and is largely deprecated given go modules. We're already not using it in our other repos.

there is already some work to go in this direction too.
for what its worth, personally, I don't care much whether or not we vendor.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/racetest.sh
d4a4f7403632064866df2ddb90870b70123d4522
link
/test istio-racetest-master

prow/integ-mixer-k8s-presubmit-tests.sh
d4a4f7403632064866df2ddb90870b70123d4522
link
/test integ-mixer-k8s-presubmit-tests-master

prow/e2e-mixer-no_auth.sh
1f9c60806bbdc54b02e037ff122f8ada89898765
link
/test e2e-mixer-no_auth-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/racetest.sh
d4a4f7403632064866df2ddb90870b70123d4522
link
/test istio-racetest-master

prow/integ-mixer-k8s-presubmit-tests.sh
d4a4f7403632064866df2ddb90870b70123d4522
link
/test integ-mixer-k8s-presubmit-tests-master

prow/e2e-mixer-no_auth.sh
1f9c60806bbdc54b02e037ff122f8ada89898765
link
/test e2e-mixer-no_auth-master

prow/e2e_pilotv2_auth_sds.sh
1f9c60806bbdc54b02e037ff122f8ada89898765
link
/test istio_auth_sds_e2e-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/racetest.sh
d4a4f7403632064866df2ddb90870b70123d4522
link
/test istio-racetest-master

prow/integ-mixer-k8s-presubmit-tests.sh
d4a4f7403632064866df2ddb90870b70123d4522
link
/test integ-mixer-k8s-presubmit-tests-master

prow/e2e-mixer-no_auth.sh
1f9c60806bbdc54b02e037ff122f8ada89898765
link
/test e2e-mixer-no_auth-master

prow/e2e_pilotv2_auth_sds.sh
1f9c60806bbdc54b02e037ff122f8ada89898765
link
/test istio_auth_sds_e2e-master

prow/e2e-bookInfoTests-trustdomain.sh
1f9c60806bbdc54b02e037ff122f8ada89898765
link
/test e2e-bookInfoTests-trustdomain-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Why can't we just do go mod tidy && go mod vendor&& git status?

That is basically verfy-vendor does.
In addition, this pr provides scripts to upgrade pkg and update go mod, thus users do not need care much about go mod commands

As can see, by running update-vendor.sh, it prunes some useless files under vendor/github.com/lestrrat-go/jwx/jwt/

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e_pilotv2_auth_sds.sh
1f9c60806bbdc54b02e037ff122f8ada89898765
link
/test istio_auth_sds_e2e-master

prow/integ-mixer-k8s-presubmit-tests.sh
20544bc13b3cc96b727e272314b5258efa8dc799
link
/test integ-mixer-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

this just seems like a huge hack around go modules and it's not clear to me what benefit we are getting for all the complexity.

suppose one has to upgrade a vendor, how should he do

set Env xxxxx
exec go get xxxxx
go mod vendor
maybe think of exec go mod tidy

How we can make sure all does this in order, how to check it. Though one can even edit go.mod manually. How can you prevent it?

I would much rather run go get istio.io/api@latest, which is universal across go projects then have to find some script and run ./updateVendors.sh istio.io/api@latest. We can check they did it correctly with the lint that just does go mod tidy && go mod vendor&& git status which if you try will catch the same github.com/lestrrat-go/jwx issue

@hzxuzhonghu: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Given that this may have a license issue, i agree we add a simple script for this.

I have no bandwidth on this, let me close it.


Uncouple BitVec and Vec

Resolves #877

Makes BitVec a constructor of the type inductive, replacing Bit
Removes simple_denote_type; it's no longer necessary if BitVec is always N and Vec is always list
Removes take and drop in favor of skipn and firstn (they appeared to be exactly equivalent; any reason to use our own custom definitions instead of the standard library here?)
Adjusts primitives so that "arithmetic"-type operations (e.g. shifting, addition, bitwise operations) are defined only on BitVec, and "vector"-type operations (e.g. uncons, reverse) are defined only on Vec; some operations, such as resizing and concatenation, are defined on both
Adapts circuits to new setup

@blaxill the intermediate tests for sha_inner and sha_padder are working, but sha256 isn't and I don't understand the desired control flow well enough to debug it. I didn't change the body of sha256 at all, so I'm a little perplexed. Would you mind either debugging the test or writing some comments that explain what's going on and what the intermediate values of state variables are expected to be so that I can debug it more effectively?

Removes take and drop in favor of skipn and firstn (they appeared to be exactly equivalent; any reason to use our own custom definitions instead of the standard library here?)

I was already wondering this when I reviewed a previous PR, and noted that if firstn gets a count that's bigger than the length of the list, it returns only the list, whereas take appends default values to make sure to always return a list whose length equals the desired count. But I see you wrap firstn inside a resize, so I guess it's equivalent, and better to use standard library functions.


bugfix: deb package build failed

As we remove the ceph volume modules, the deb package building failed.
We will remove the ceph dependency in Makefile
Signed-off-by: Eric Li<EMAIL_ADDRESS>
Ⅰ. Describe what this PR did
As we remove the ceph volume modules, the deb package building failed. We will remove the ceph dependency in Makefile
Ⅱ. Does this pull request fix one issue?
fixes #1726
Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

LGTM and it works well for me.

Codecov Report

Merging #1727 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1727      +/-   ##
==========================================
- Coverage   41.29%   41.26%   -0.03%
==========================================
  Files         274      274
  Lines       18123    18123
==========================================
- Hits         7483     7478       -5
- Misses       9728     9733       +5
  Partials      912      912

Impacted Files
Coverage Δ

ctrd/image.go
77.47% <0%> (-2.75%)
:arrow_down:


Website fails to build on Travis with Pelican>=4 and new atom feed slug spec

See this issue: https://github.com/getpelican/pelican/issues/2489
I have yet to get it debugged on Travis. So I'm using the old slug spec and Pelican < 4 currently.
I tried removing the svbhack theme on Travis and it still failed.

Stopped using the svbhack theme which caused the issue with the new pelican version.

Actually seems like the alchemy theme might have the same issue.

It seems to be building fine.


Form inputs should not be so long, reduce width

https://github.com/jayzamazing/Restaurant-POS/issues/43


fix depfile generation on Windows, across different drives

Since its first implementation in commit 9db1fc39b31b7b3b2ed574a79f5f9fd980ee3be7, depfiles try to calculate relative paths for files relative to the project base dir. This usually worked, but fails when the output directory is being used from another Windows drive letter. This can happen for build systems that encourage out of source build directories. When that happens, the logical thing to do is to use an absolute path anyway. That's what those build systems do as well, so the resulting depfiles still align with the build system manifest.

Thanks. I'm taking the view that we can't easily test this (much as I'd like to)

It would probably be awkward to do so, yes. :(

Can this be backported to 0.29.x? :) It doesn't backport cleanly but I think that's because my backport of c656624a4fc638e4c0cc098dab0f59a6f8331b1c made a minor tweak (evaluate abspath earlier) that I no longer remember the reason for...

I think so. It'd probably be easier if you created a PR against the 0.29.x branch since you're hopefully in a position to test this

Backported in #5283


Improve build speed

Consider:

esbuild
Vite

https://github.com/yuanqing/create-figma-plugin/tree/next


lib: gui: lvgl: align names and other improvements

Summary:

Kconfig object names have been aligned with LVGL (as discussed and agreed in dev-review)
Improved lv_conf.h by introducing IS_ENABLED macro for boolean options
Splitted Kconfig options into more granular units
Sorted objects in order to improve readability/keep track of options

@vanwinkeljan should be ready now


panic: read /dev/stdin: resource temporarily unavailable

Hey there.
On OSX 11.4 (Intel), I get the following error after navigating to a file, editing it with Neovim, and exiting Neovim:
panic: read /dev/stdin: resource temporarily unavailable

goroutine 1 [running]:
main.main()
	/Users/anton/dev/llama/main.go:66 +0x277

Yeah, can’t do much. This issues is blocking https://github.com/charmbracelet/bubbletea/issues/171

Ah, that's a shame. Thanks for responding so quickly! Also, awesome project, love using llama. :)

The appropriate functionality has been implemented in Bubble Tea and Llama's been updated accordingly in https://github.com/antonmedv/llama/pull/19, which I believe resolves this issue.


nbdev github CI Action fails with missing path attribute

I have been test driving nbdev on a personal project but I have not been able to figure out why github CI action is failing on the Read all notebooks step launching nbdev_read_nbs which passes on my local dev box.
You can see the error on this run.
The stack trace:
Run nbdev_read_nbs
Traceback (most recent call last):
  File "/opt/hostedtoolcache/Python/3.8.6/x64/bin/nbdev_read_nbs", line 8, in <module>
    sys.exit(nbdev_read_nbs())
  File "/opt/hostedtoolcache/Python/3.8.6/x64/lib/python3.8/site-packages/fastcore/script.py", line 77, in _f
    func(**args.__dict__)
  File "/opt/hostedtoolcache/Python/3.8.6/x64/lib/python3.8/site-packages/nbdev/test.py", line 130, in nbdev_read_nbs
    files = Config().path("nbs_path").glob('**/*.ipynb') if fname is None else glob.glob(fname)
  File "/opt/hostedtoolcache/Python/3.8.6/x64/lib/python3.8/site-packages/fastcore/foundation.py", line 460, in __getattr__
    def __getattr__(self,k):   return stop(AttributeError(k)) if k=='d' or k not in self.d else self.get(k)
  File "/opt/hostedtoolcache/Python/3.8.6/x64/lib/python3.8/site-packages/fastcore/foundation.py", line 252, in stop
    raise e
AttributeError: path
Error: Process completed with exit code 1.

This is weird. If my understanding is correct, it is claiming Config class has no method named path?

Adding the requirements = nbdev>=1.1.4 to settings.ini fixed my issue. I think somehow github CI just pulled in older version of nbdev.


Add io connectors through rountripping with dask/dask

cc @mrocklin
This is probably the area where we can save time without losing much in the sense of performance and UX for users. We can switch them out one after another after we are happy with the other parts of the API, compromising here makes the most sense imo. Wdyt?

I don't have strong thoughts.  In principle this isn't great, but it's not worse than status quo and doesn't bind us to any bad decisions.  The best counterargument I can come up with is "if it's this straightforward to cheat then it's probably not much harder to just do the work.  This is probably just a tricky copy paste job.  There aren't any complex optimizations or anything.".  You're on the ground though and so I figure you have a more nuanced understanding of the costs here, so I'm more than happy to defer to your judgement.

The transfer shouldn't be hard generally speaking but I suspect that it would still take at least 3-4 days of work until everything works smoothly. There are optimisations available, read_sql comes to mind, but that's probably not a big deal for now.
I don't want to keep this implementation forever, but if we want to get to a point where we are confident that dask-expr works reliable as fast as possible, I would rather prioritise making sure that the non-io stuff works great and do this after we are at that point.


added CRD file test Go script.

Signed-off-by: Marco Yeung<EMAIL_ADDRESS>added CRD file tester for its content validation.

lgtm, thanks for the additions/improvements...


Fix missing imports in core

Just downloaded <IP_ADDRESS> but found that it still had a few minor errors. Just missing some import statements with the new download function.

Yeah, I'm trying to fix things from a train and the wifi is so slow I basically can't test... :)
But thank you for your super nice comments earlier!


Resolve

#4 is directly merged to main branch. It's my mistake. This pr resolve it.

Thanks for review!


Change editor to markitup

codemirror causes some strange behabior on Android and iOS...
markitup wont, and seems good.

CodeMirror can be used with Android Chrone and iOS Safari. changing JavaScript library is not so hack valueable.


Memory for kraken2

The memory requirements of this tool are largely dependent on the DB size you're using with it.
For DB sizes see:
https://benlangmead.github.io/aws-indexes/k2
As you can see, there are dramatic size differences.
Can this information be used somehow to guide the memory assigned to the tool?

If you provide a database=memory mapping we could use that I think.

I am using DB size + 24 GB:
  toolshed.g2.bx.psu.edu/repos/iuc/kraken2/kraken2/.*:
    cores: 16
    # TODO: make a helper
    mem: |
      import os
      mem = 64
      table_name = "kraken2_databases"
      lookup_column = "value"
      value_column = "path"
      value_template = "{value}/hash.k2d"
      options = job.get_param_values(app)
      lookup_value = options["kraken2_database"]
      table_value = app.tool_data_tables.get(table_name).get_entry(lookup_column, lookup_value, value_column)
      if table_value is not None:
          table_value = value_template.format(value=table_value)
          try:
              mem = os.path.getsize(table_value)/1024**3
              log.debug("Data table '%s' lookup '%s=%s: %s=%s': %s GB",
                        table_name, lookup_column, lookup_value, value_column, table_value, mem)
          except OSError:
              log.exception("Failed to get size of: %s", table_value)
      else:
          log.warning("Data table '%s' lookup '%s=%s: %s=None' returned None!, defaulting to %s",
                      table_name, lookup_column, lookup_value, value_column, mem)
      mem + 24

This looks like a good rule to add to the TPV db itself? Would you be able to make a PR?

Yes, I meant to add a helper at some point, just haven't gotten to it yet - I will do that.


It would be nicer if react-simple-checkbox has a check and uncheck delay controls.

Hi, thanks for your issue.
Should the delay apply only for the animation or also for the onChange event ?

animation. also little bit padding is needed for checkmark.

props for the animation speed would be great

Hi, sorry for late answer, i did not have as many time as i wanted to work on this project. Be sure i'll take a look to add these props as soon as possible

Hi, I made some updates trying to implement your suggestions. Could you give a try to the latest version (1.3.0) ?


Sort translations

Implements #4947 , sorts translations while building. English is however at the top, since it's not handled as other translations, sorting it also would non-trivial. However I think this behavior is fine, since English is handled this way in many applications.

That's a good start, thanks! I think eventually it would be best to sort the array containing the translations before trying to use it in the editor settings, but handling the problem at the source this way is a good step forward already :) There's no reason indeed to generate the header in a random order when we can have it sorted :)

seems fine to me
On Wed, Jun 1, 2016 at 11:46 AM, J08nY<EMAIL_ADDRESS>wrote:

Implements #4947 https://github.com/godotengine/godot/issues/4947 ,
sorts translations while building. English is however at the top, since
it's not handled as other translations, sorting it also would non-trivial.
However I think this behavior is fine, since English is handled this way in
many applications.
You can view, comment on, or merge this pull request online at:
https://github.com/godotengine/godot/pull/4976
Commit Summary

Sort l18n while building

File Changes

M tools/SCsub
https://github.com/godotengine/godot/pull/4976/files#diff-0 (17)

Patch Links:

https://github.com/godotengine/godot/pull/4976.patch
https://github.com/godotengine/godot/pull/4976.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/pull/4976, or mute the thread
https://github.com/notifications/unsubscribe/AF-Z26T_Z1Emd56VIdn4Ka_KFwffH7y3ks5qHZsqgaJpZM4IroF8
.


Script asks me to install Python 2.x although I have Python 2.7.5 installed

I tried using the script, but when I tried to run it with the -h flag to see the usage, I was asked to install Python 2.x. As shown in the output below, I already have Python 2.7.5 installed.
System:

Mac OSX 10.9.4
Bash
Python 2.7.5

$ python --version
Python 2.7.5

Steps to reproduce:

$ sh ./OCRmyPDF.sh -h

Expected:

Script runs and shows its usage.

Actual:

Please install python v2.x. Exiting...

To get this working, the actual command I needed to use in OS X was:
sudo ln -s /usr/bin/python /usr/bin/python2

Should be fixed in v3.0-rc2


Update AuPayCategoryType.cs

Please review supported Category types list on
https://api.keypay.com.au/australia/reference/pay-category/au-pay-category--post
We are currently experiencing an issue with this.

This is the second time this has happened within a year. I had a pull request for this on the 17th August 2023, with a fix from keypay issued on the 25th August.

@Blitheness hey is there any chance of getting this merged in soon? Thanks!

I've just sent Keypay Support details of this and the URL to these PRs. Hopefully it gets noticed soon.

Hi both, it's on our radar to get sorted out soon. The difficulty with accepting PRs here is that our API client is automatically generated by an internal tool, so changes would be overwritten anyway when our automations release a new version. I cannot provide timescales right now, but colleagues are doing good work on enhancing the client generator and their changes are being tested internally. We're also looking into the best way of having the API client release with every production release of Payroll that changes the API specification. Please do continue to contact us via the support desk with any queries about the API or this API client as we greatly appreciate your feedback.
@SergioBAM @ThirstyJarek

I think notifying people of pending API changes would be a great start. Some sort of notification from Keypay/EH would allow us to prepare for these changes, rather than having our clients or internal monitoring systems notify us on the day.
You did have a dev forum thats since been archived at https://developers.yourpayroll.com.au/
Perhaps bring something like that back? We dont need the full forum capabilities but a breaking changes announcement sticky would be helpful.

Thanks for your patience. The latest release incorporates the requested changes. If you have any feedback on the latest release, please reach out to our support team and we'll do our best to assist.


update tls repo

No description provided.

Thank you very much for your submission.

你好，这个有打算合并吗

你好，这个有打算合并吗

Currently your submission failed our ci test, please check the ci status, thank you.

你好，这个有打算合并吗

Great! @PandaLIU-1111
I see that you replaced the import package, did you forget to submit go.mod.

@PandaLIU-1111
Hello, thank you very much for your resubmission, can you execute make successfully?
I see you have added two duplicate packages in go.mod.  github.com/libp2p/go-libp2p v0.14.4.
And there is no such directory p2p/security/tls  in the github.com/libp2p/go-libp2p v0.14.4.


Moveit does not wait for trajectory completion

I have a custom robot arm using dynamixel motor for which I have successfully made the urdf according to the requirements and it works with this package.
I am able to control the real robot as well as in gazebo using the interbotix functions.
The issue is that when I send multiple points together to for execution,
for example point a,b,c,d on real robot it start moving towards b but immediately changes course and moves directly to d.
If I give only 2 points it works perfectly.
In gazebo multiple point execution works perfectly without any issue so looks like the issue is with the driver. The driver seems to accept the goal and return completed/succeeded immediately before even the trajectory is completed.
while row is not None:

                joint_goal = self.group.get_current_joint_values()
                joint_goal[0] = row[0]
                joint_goal[1] = row[1]
                joint_goal[2] = row[2]
                joint_goal[3] = row[3]
                joint_goal[4] = row[4]
                joint_goal[5] = row[5]
                rospy.logwarn("sent goal to moveit")
                self.group.go(joint_goal, wait=True)
                rospy.logwarn("goal reached sending

next goal if available")
self.group.stop()

self.group.go(joint_goal, wait=True) This line of the code is completed immediately even before the trajectory execution is finished.
We are using gears for the motors so to account for them
I divide the position by "gear_ratio"
In lines  1385 and 1434 I divide by the gear ratio
position = dxl_wb.convertValue2Radian(joint.motor_id, get_position[index]);
position = position/gear_ratio;
and multiply by "gear_ratio" before sending the joint values to the motors in
void RobotArm::arm_set_single_joint_angular_position and void RobotArm::arm_write_joint_commands.
The issue of returning completed trajectory/success before reaching it is due to the something the way the driver works or there is something wrong in the way I am implementing the gear ratio.
Rest of functions though seems to work fine. Like single joint movement, multi joint movement and even just moving between only 2 points.

Can you post a snapshot of your terminal screen where these messages appear?

This is the output.
It shows up warnings thats the joint value is not as expected. (which is exactly 6.7 times which is the gear_ratio i mentioned)
I am trying to have moveit is getting and sending out commands, within it's normal range of operation as I am dividing joint_states values before it is published and multiply the joint cmds before sending those commands to the motors.
In the example below i send point a to b to c to d.
In the terminal output below, Completed trajectory execution with status SUCCEEDED is shown twice even before robot moves to point b or c and it finally just moves directly to d from a.
[ INFO] [1591280519.364279682]: Combined planning and execution request received for MoveGroup action. Forwarding to planning and execution pipeline.
[ INFO] [1591280519.364705220]: Planning attempt 1 of at most 1
[New Thread 0x7fff97fff700 (LWP 13307)]
[ INFO] [1591280519.370735383]: Planner configuration 'interbotix_arm' will use planner 'geometric::RRTConnect'. Additional configuration parameters will be set when the planner is constructed.
[ INFO] [1591280519.372606440]: RRTConnect: Starting planning with 1 states already in datastructure
[Thread 0x7fff97fff700 (LWP 13307) exited]
[ INFO] [1591280519.388024159]: RRTConnect: Created 4 states (2 start + 2 goal)
[ INFO] [1591280519.388176096]: Solution found in 0.015883 seconds
[ INFO] [1591280519.398292129]: SimpleSetup: Path simplification took 0.009755 seconds and changed from 3 to 2 states
[New Thread 0x7fff97fff700 (LWP 13308)]
[New Thread 0x7fff977fe700 (LWP 13309)]
[ WARN] [1591280519.408942356]: shoulder motor is not at the correct initial state.
[ WARN] [1591280519.409075140]: Expected state: 1.770214, Actual State: 0.264440.
[ WARN] [1591280519.409169506]: elbow motor is not at the correct initial state.
[ WARN] [1591280519.409231211]: Expected state: 0.363553, Actual State: 0.054262.
[ WARN] [1591280519.409341539]: forearm_roll motor is not at the correct initial state.
[ WARN] [1591280519.409421776]: Expected state: 0.131922, Actual State: 0.019461.
[ INFO] [1591280519.409506645]: Succeeded to get joint trajectory!
[ INFO] [1591280519.903753303]: Trajectory done being executed.
[ INFO] [1591280519.910274969]: Controller arm_controller successfully finished
[ INFO] [1591280519.934144223]: Completed trajectory execution with status SUCCEEDED ...
[Thread 0x7fff977fe700 (LWP 13309) exited]
[Thread 0x7fff97fff700 (LWP 13308) exited]
[ INFO] [1591280520.001989464]: Received event 'stop'
[ INFO] [1591280520.013729859]: Combined planning and execution request received for MoveGroup action. Forwarding to planning and execution pipeline.
[ INFO] [1591280520.013792496]: Planning attempt 1 of at most 1
[New Thread 0x7fff977fe700 (LWP 13310)]
[ INFO] [1591280520.014387601]: Planner configuration 'interbotix_arm' will use planner 'geometric::RRTConnect'. Additional configuration parameters will be set when the planner is constructed.
[ INFO] [1591280520.014504565]: RRTConnect: Starting planning with 1 states already in datastructure
[Thread 0x7fff977fe700 (LWP 13310) exited]
[ INFO] [1591280520.026005203]: RRTConnect: Created 4 states (2 start + 2 goal)
[ INFO] [1591280520.026109873]: Solution found in 0.011625 seconds
[ INFO] [1591280520.031688533]: SimpleSetup: Path simplification took 0.005485 seconds and changed from 3 to 2 states
[New Thread 0x7fff977fe700 (LWP 13311)]
[Thread 0x7fff977fe700 (LWP 13311) exited]
[New Thread 0x7fff97fff700 (LWP 13312)]
[ WARN] [1591280520.035631650]: shoulder motor is not at the correct initial state.
[ WARN] [1591280520.035727525]: Expected state: 1.250194, Actual State: 0.181559.
[ WARN] [1591280520.035770492]: forearm_roll motor is not at the correct initial state.
[ WARN] [1591280520.035819940]: Expected state: -0.165670, Actual State: -0.025872.
[ INFO] [1591280520.035866372]: Succeeded to get joint trajectory!
[ INFO] [1591280520.663703954]: Trajectory done being executed.
[ INFO] [1591280520.666372116]: Controller arm_controller successfully finished
[ INFO] [1591280520.696140495]: Completed trajectory execution with status SUCCEEDED ...
[Thread 0x7fff97fff700 (LWP 13312) exited]
[ INFO] [1591280520.710401710]: Received event 'stop'
[ INFO] [1591280520.733649680]: Combined planning and execution request received for MoveGroup action. Forwarding to planning and execution pipeline.
[ INFO] [1591280520.733732431]: Planning attempt 1 of at most 1
[New Thread 0x7fff97fff700 (LWP 13313)]
[ INFO] [1591280520.734190076]: Planner configuration 'interbotix_arm' will use planner 'geometric::RRTConnect'. Additional configuration parameters will be set when the planner is constructed.
[ INFO] [1591280520.734335109]: RRTConnect: Starting planning with 1 states already in datastructure
[Thread 0x7fff97fff700 (LWP 13313) exited]
[ INFO] [1591280520.744911593]: RRTConnect: Created 5 states (2 start + 3 goal)
[ INFO] [1591280520.744944010]: Solution found in 0.010654 seconds
[ INFO] [1591280520.748457603]: SimpleSetup: Path simplification took 0.003480 seconds and changed from 4 to 2 states
[New Thread 0x7fff97fff700 (LWP 13314)]
[New Thread 0x7fff977fe700 (LWP 13315)]
[ WARN] [1591280520.753956239]: shoulder motor is not at the correct initial state.
[ WARN] [1591280520.753990786]: Expected state: 0.645806, Actual State: 0.092497.
[ WARN] [1591280520.754010118]: elbow motor is not at the correct initial state.
[ WARN] [1591280520.754024956]: Expected state: 0.690291, Actual State: 0.109210.
[ WARN] [1591280520.754037846]: forearm_roll motor is not at the correct initial state.
[ WARN] [1591280520.754053318]: Expected state: -0.184078, Actual State: -0.027474.
[ INFO] [1591280520.754065637]: Succeeded to get joint trajectory!
[ INFO] [1591280521.743613150]: Trajectory done being executed.
[ INFO] [1591280521.744621739]: Controller arm_controller successfully finished
[ INFO] [1591280521.774082693]: Completed trajectory execution with status SUCCEEDED ...
[Thread 0x7fff977fe700 (LWP 13315) exited]
[Thread 0x7fff97fff700 (LWP 13314) exited]
[ INFO] [1591280521.953536619]: Received event 'stop'
[ INFO] [1591280521.974154450]: Combined planning and execution request received for MoveGroup action. Forwarding to planning and execution pipeline.
[ INFO] [1591280521.974331618]: Planning attempt 1 of at most 1
[New Thread 0x7fff977fe700 (LWP 13316)]
[ INFO] [1591280521.975514229]: Planner configuration 'interbotix_arm' will use planner 'geometric::RRTConnect'. Additional configuration parameters will be set when the planner is constructed.
[ INFO] [1591280521.975909073]: RRTConnect: Starting planning with 1 states already in datastructure
[Thread 0x7fff977fe700 (LWP 13316) exited]
[ INFO] [1591280521.989366109]: RRTConnect: Created 4 states (2 start + 2 goal)
[ INFO] [1591280521.989485649]: Solution found in 0.013692 seconds
[ INFO] [1591280521.995057855]: SimpleSetup: Path simplification took 0.005461 seconds and changed from 3 to 2 states
[New Thread 0x7fff977fe700 (LWP 13317)]
[Thread 0x7fff977fe700 (LWP 13317) exited]
[ERROR] [1591280522.004116978]:
Invalid Trajectory: start point deviates from current robot state more than 0.01
joint 'elbow': expected: 0.448289, current: 0.46111
[ INFO] [1591280522.008632371]: Received event 'stop'

i assume that the gear ratio you are talking about means that for every 6.7 revolutions of the Dynamixel Servo (the driver gear), the outer (or driven) gear rotates once.
Since you're accounting for the gear ratio in the driver node, this means that you should be sending commands from MoveIt in terms of what the joint positions should be after the gear reduction (ex. if the desired position of the shoulder joint is pi/2 radians, then you should be sending pi/2 radians, at which point the driver will take that, multiply it by 6.7 and command the motor). In this manner, MoveIt receives and commands joint values post-gear-reduction. I'm not sure why, but it looks like you are commanding the joints from MoveIt in terms of joint values pre-gear-reduction (i.e. what the Dynamixel servo positions should be and not what the driven gear should be).
As a side note, if the Dynamixel Servos are supposed to be able to rotate up to +/- 6.7 revolutions, you should be setting the arm_operating_mode to 'ext_position'. By default, the motors are set to 'position' control mode and will ignore any commands trying to make them rotate past +/- 1 revolution (this is just how the firmware in the motors was configured for safety reasons I expect).

The driver here did not support ext_position implemented even though there were some mentions of it. I made changes in the driver so it works with ext_position. And it works when I manually send the commands to the joints even above +/- 1.
I am trying to do exactly what you are suggesting.
in the function void RobotArm::arm_update_joint_states(const ros::TimerEvent &e)
I divide the position by "gear_ratio" So that moveit does receives the the joint position after division.
So in the following line the position values will be for example 6.7(ext_position) as it is coming from the motors. I divide it by 6.7 so that moveit always gets it between +/-1(I understand these are in radians so -2pi to 2pi)
In lines 1385 and 1434 I divide by the gear ratio
position = dxl_wb.convertValue2Radian(joint.motor_id, get_position[index]);
position = position/gear_ratio;

As this the function which publishes to joint_states. I checked joint_states topic and its values are between -2pi to 2pi. But the warning says that moveit expects it to be different. That's what I am not able to understand.
I think this is where the problem lies. There maybe somewhere else from where moveit gets the joint states and I am missing that
I also take the output of moveit and multiply it 6.7 to send to motors.(This second part works perfectly)
multiply by "gear_ratio" before sending the joint values to the motors in the functions
void RobotArm::arm_set_single_joint_angular_position
void RobotArm::arm_write_joint_commands.

The driver here did not support ext_position implemented even though there were some mentions of it. (Please correct me if I overlooked the implementation somehow but from what I found that it was not implemented fully) I made changes in the driver so it works with ext_position. And it works when I manually send the commands to the joints even above +/- 1.

I took another look, and you're right! I decided against implementing ext_position control for the arm joints since it wasn't necessary for the robot arms we develop. As an FYI though, I did a complete redesign of the interbotix_sdk that I plan to release in the next couple months. In the new version, it does allow you to set a group of joints to ext_position control. That said, in this version of the sdk it should still be possible to change each joint individually to ext_position control using the 'set_operating_modes' ROS service.

As this the function which publishes to joint_states. I checked joint_states topic and its values are between -2pi to 2pi. But the warning says that moveit expects it to be different. That's what I am not able to understand.

Technically, values should be from -pi to pi since this accounts for one full revolution (joint centered at 0 degrees with the ability to go to +/- 180 degrees). Also, the warnings you are seeing (about how the 'shoulder motor is not at the correct initial state' and 'Expected state: XXX, Actual State: XXX' ) is outputted by the interbotix_sdk node - not MoveIt. Essentially, when the interbotix_sdk node receives a joint trajectory command from MoveIt, it compares the joint values in the first waypoint to the current joint states. This is to make sure that they are the same or at least not too different (otherwise when the trajectory execution starts - the arm would jerk). However, in your case it seems that the joint commands in the first waypoint (and potentially the other waypoints) of the joint trajectory coming from MoveIt is roughly 6.7 times the current joint states. I'm not sure how this could be happening without seeing all the changes you made to the sdk. As an FYI, the line here is where the current joint states are saved to a private variable called 'joint_states'. This is the variable that is used when comparing against the joint trajectory command being sent by MoveIt.

I think this is where the problem lies. There maybe somewhere else from where moveit gets the joint states and I am missing that

MoveIt should only be getting the joints states from the /<robot_name>/joint_states topic, not anywhere else. If the arm showing up in Rviz seems to match the physical arm layout, then you should be good. Out of curiosity, if you just run the arm_run.launch file with Rviz, and manually manipulate the arm (torquing off the motors first), does the virtual model in Rviz mimic the real arm?

Closing due to lack of activity. Feel free to reopen if necessary.


Speed up omnibus build and allow running it dockerized

What does this PR do?

Create a new inv docker.dockerize-omnibus task to run the agent omnibus build in a sandboxed docker container
Remove the protobuf-py dependency, as our UCS4 python build can now use the upstream binary wheel
Remove the always_build directive from datadog-process-agent to avoid unnecessary dirtying the cache
Blacklist some agent folders that can hold big artifact, to reduce the copy time of the datadog-agent recipe
Reorder the omnibus deps to optimize cache use

Cache (venv, sources and binaries is kept in ~/.omni-build/ by default. We reuse the publicly available circleci runner image for simplicity.
Metrics when running in the ci_box on a macbook pro with 4 GB / 4 vcores:

First run: 42 minutes
Cache size: 1.9 GB
Second run: 14 minutes

Motivation
Make it faster to iterate on the containerized agent, as the docker image depends on the debian package

Codecov Report

Merging #2493 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2493      +/-   ##
==========================================
- Coverage   57.13%   57.12%   -0.02%
==========================================
  Files         382      382
  Lines       24289    24289
==========================================
- Hits        13878    13875       -3
- Misses       9510     9514       +4
+ Partials      901      900       -1

Impacted Files
Coverage Δ

pkg/logs/client/connection_manager.go
44.82% <0%> (-3.45%)
:arrow_down:


Go Language invalid indentation on return

VSCode Version: 1.29.1 (bc24f98b5f70467bc689abf41cc5550ca637088e)
OS Version: macOS 10.14.1 (18B75)

Steps to Reproduce:

Write source

package product_test

func ExampleProduct() {
	p, _ := NewProduct(
		"Foo",
		"Foo is awesome product",
		decimal.NewFromFloat(10000))|

}

and put the cursor on column contains "NewFromFloat"

Hit return

package product_test

func ExampleProduct() {
	p, _ := NewProduct(
		"Foo",
		"Foo is awesome product",
		decimal.NewFromFloat(10000))
		|
}

The cursor is under "decimal"
While expect, cursor under "p"
package product_test

func ExampleProduct() {
	p, _ := NewProduct(
		"Foo",
		"Foo is awesome product",
		decimal.NewFromFloat(10000))
	|
}

Does this issue occur when all extensions are disabled?: Yes

AFAIK Go grammar taken from atom editor. But somehow atom behaviour was correct while incorrect on vscode

In Atom this is controlled by decreaseNextIndentPattern which we use onEnterRule to control in VS Code. I'll suggest to implement this in the Go extension as it's fairly complicated and requires Go knowledge.


Pynini istrings utf-8 errors

Hello,
I have a problem when printing all shortest paths from FST (please see my code below). I guess that my input symbols contains some characters (not in utf-8 encodings). I would like to ask: Is there any way to get paths as list of input label ids instead of  symbols?
Thank you very much in advance.
Code
shortest_filepath = ""
LM = pynini.Fst.read(shortest_filepath)
for i in LM.paths().istrings():
print('path: ', i)
Error:
File "pynini.pyx", line 2221, in istrings
File "stringsource", line 38, in string.to_py.__pyx_convert_PyUnicode_string_to_py_std__in_string
UnicodeDecodeError: 'utf-8' codec can't decode byte 0x83 in position 0: invalid start byte

python 3.7
openfst-1.7.4
Pynini 2.0.0

Thanks for the clear report.
I am assuming you have a real filename and not a blank string filename in
your actual example...
First, try this:
for i in LM.paths(input_token_type="utf8").istrings():
    print("path: ", i)

If you really just want arc labels instead of strings, you can use
ilabels(). That'll look a bit like this:
paths = LM.paths(input_token_type="utf8")  # The argument here is

optional.
while not paths.done():
print(paths.ilabels())
paths.next()
You may also want to try updating to a newer Pynini; the current release is
2.1.2 and 2.0.0 came out over two years ago.
On Wed, Aug 12, 2020 at 8:57 AM HaiNguyen<EMAIL_ADDRESS>wrote:

Hello,
I have a problem when printing all shortest paths from FST (please see my
code below). I guess that my input symbols contains some characters (not in
utf-8 encodings). I would like to ask: Is there any way to get paths as
list of input label ids instead of symbols?
Thank you very much in advance.
Code
shortest_filepath = ""
LM = pynini.Fst.read(shortest_filepath)
for i in LM.paths().istrings():
print('path: ', i)
Error:
File "pynini.pyx", line 2221, in istrings
File "stringsource", line 38, in
string.to_py.__pyx_convert_PyUnicode_string_to_py_std__in_string
UnicodeDecodeError: 'utf-8' codec can't decode byte 0x83 in position 0:
invalid start byte
python 3.7
openfst-1.7.4
Pynini 2.0.0
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/kylebgorman/pynini/issues/28, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABG4OISEYIEBSF7HRT3YD3SAKGUPANCNFSM4P4U3LIA
.

Thanks for the clear report. I am assuming you have a real filename and not a blank string filename in your actual example...
First, try this:
for i in LM.paths(input_token_type="utf8").istrings():
    print("path: ", i)

If you really just want arc labels instead of strings, you can use ilabels(). That'll look a bit like this:
paths = LM.paths(input_token_type="utf8")  # The argument here is optional.
while not paths.done():
    print(paths.ilabels())
    paths.next()

You may also want to try updating to a newer Pynini; the current release is 2.1.2 and 2.0.0 came out over two years ago.

Thank you so much for your very quick reply.
For the 1st suggestion, I still have the same error. Fortunately, my problem is solved with your 2nd suggestion. It's so great.
I will update to the latest version as well.
Many thanks again.


Can I keep my annotations when parsing SQL into objects?

Hi, developers, because the SQL I work with is very complex, I will add a lot of comments to the SQL.But when I use JSQLParser, it automatically removes the annotations from the body.Please, can I keep my annotations in the parsed object?  Thank you very much and I am looking forward to your reply

Unfortunately, this is not possible, since comments are parsed as special tokens that are finally skipped. However, it is possible to intercept those special tokens: https://www.cs.purdue.edu/homes/hosking/javacc/doc/tokenmanager.html.

Unfortunately, this is not possible, since comments are parsed as special tokens that are finally skipped. However, it is possible to intercept those special tokens: https://www.cs.purdue.edu/homes/hosking/javacc/doc/tokenmanager.html.

Thank you very much for your reply. I will try to use the interception scheme to restore the annotations, because I think I still need the SQL annotations, because it will be very convenient for me to read the SQL.


fix(vscode): extension command, server crate path

What kind of change does this PR introduce?
When we install and use the VS Code extension, we're now installing the correct crate and running the correct binary.
I also added already-in-use, non-default settings to the .prettierrc.js file, so that the diff is more readable.
What is the current behavior?
Running cargo xtask install fails because it's looking for a postgres_lsp crate; there is none. The crate is called pg_lsp.
Starting the VSCode extension fails because it tries to execute the postgres_lsp binary; it's called pglsp.
What is the new behavior?
We're installing the correct crate and executing the correct binary.
It's working now 🥳🥳🥳:

awesome! 🫶🏼


Not Running In Repal.it

Hi your bot surce code is not working check your code

see the readme.md
and is replit.com

replit.com use 12.x


add: safe serialization while pushing to hf

Closes #187
@psinger I found that marking safe_serialization = True pushes safetensors to Hub
https://github.com/huggingface/transformers/blob/e16191a8ac118cea95b3353fc837e288edae64be/src/transformers/utils/hub.py#L770-L771

Please run make format and update the branch.

@psinger all checks pass !

Hi @pascal-pfeiffer !
Removed those args from tokenizer and model_card.

Also is there a way to run format without make, it's throwing some errors for me now, I'm using a custom conda environment.

@shivance custom conda environment is not recommended, specifically for development.
Best is to run make setup and then use that environment.

Also is there a way to run format without make, it's throwing some errors for me now, I'm using a custom conda environment.

the make command basically runs
python run isort .
python run black .

so, you can also run that you own, but as @psinger said, using the pipenv is highly recommended over a custom conda environment. For development, you will need to run make setup-dev to get the linter etc.

Hi @psinger & @pascal-pfeiffer Could you review?
Instead of checkbox how about we use a toggle ?

Hi @psinger & @pascal-pfeiffer Could you review? Instead of checkbox how about we use a toggle ?

Thank you for the changes. Toggle is a great idea, probably better UX.

CI is ✅


Added problem nd solution for compare-the-triplets

Added implementation for a Hackerrank Problem Compare the Triplets
@Vishruth-S Please merge this PR.

@Vishruth-S Is it ok now?


App is not working with new v6 Mi-light bridge and bulbs

Hey, i know you haven't worked on this for a while, but i was hoping that you could still help me out. I've been trying to get your app to work on the new v6 mi-light bridge and bulbs i got just so I could set up a sunrise light, but I just can't connect using your app. It works with the standard mi-light app, but that doesn't have a sunrise feature. I used the LimitlessLED windows app to confirm the connection and i tried using the ip and port that the bridge is sitting on, but without success. I'm wondering if the commands have changed? I've tried looking through your code, but i'm having a hard time getting through it, as i'm not that familiar with app dev. I attached a screenshot of the LimitlessLED app that has all the main commands in hex and also some details about the commands that and am hoping that it shows enough info for a quick and easy fix perhaps? I would just love it if I could get your app to work and wake up to a natural sunrise. Thanks

Hi @keevstr,
Unfortunately, all of the command codes have changed in the new MiLight bridge.
These are actually implemented in a different project I created called milight-api that this project depends on:
https://github.com/eladnava/milight-api/tree/master/api/src/main/java/com/eladnava/milight/api/lib
If you would like to take a stab at changing them, please go ahead. I will unfortunately not be able to devote time into adding support for this new router.

This is great. No worries about the time. I figured you'd moved on to other projects or are just busy with life. This link is what I was looking for before. I think i can figure it out with this. Thanks again

Hi @keevstr,
Great to hear that. I wish you the best of luck! 🍺


chore: release 0.1.0

:robot: I have created a release *beep* *boop*
0.1.0 (2024-10-03)
Features

jest setup (6d35d3f)
listen same as subscribe (c35eeee)
mine resource id (44f40d5)
mine same as mineResourceId (b37beed)
mineResourceID parameter type expansion (5a62e37)
postage batch related functionalities (cc2467c)
proximity check utility (a7b634e)
resourceId parameter type expansion (8686bb8)
return back gsoc address on subscribe (69b831d)
send same as write (f5d2cf1)

Bug Fixes

curve cannot generate from zero priv key (9927140)
resourceId increment (45f86dc)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/anythread/gsoc/releases/tag/v0.1.0 :sunflower:


Add open-iscsi to the base image

What would you like to be added:
Add open-iscsi to the default installed packages.
Why is this needed:
This package is required to allow iSCSI volumes to be mounted on the node.

A a temporary mitigation for Garden Linux 27.x the following will work via a privileged pod (will not work anymore with the next version):
gardenctl shell <host>
mount -o remount,rw /usr
apt-get update && apt-get install -y open-iscsi


Replace s2geometry-node with pure js version

The only thing that requires non-javascript code in this repo is s2geometry-node.
I'm pretty sure we only need methods for latlng2cellid and cellid2latlng.
Looks like https://github.com/jonatkins/s2-geometry-javascript/blob/master/src/s2geometry.js might do the trick.

https://github.com/jonatkins/s2-geometry-javascript (original)
https://github.com/coolaj86/s2-geometry-javascript (updated fork)

But it still needs a hilbert curve:
http://jsfiddle.net/Pointy/zGLKF/3/

And it also needs a way to represent S2CellId, which is a 64-bit int (noted here https://github.com/coolaj86/s2-geometry-javascript/blob/master/src/s2geometry.js#L19)
Might need long.js...

Done and Done! https://github.com/coolaj86/s2-geometry-javascript


Fix emcc call

Call $EMSCRIPTEN/emcc instead of python EMSCRIPTEN)/emcc.py otherwise the build fails when python3 is set as active version (emcc.py needs python 2).

Why did you comment out the Sys.deleteFile ?

Ups. Forgot to remove the comment.


can we use more than 5 different images in markerclusterplus?  if yes max how many images we can use please suggest me

Thanks for stopping by to let us know something could be better!

PLEASE READ
If you have a support contract with Google, please create an issue in the support console. This will ensure a timely response.
Discover additional support services for the Google Maps Platform, including developer communities, technical guidance, and expert support at the Google Maps Platform support resources page.
If your bug or feature request is not related to this particular library, please visit the Google Maps Platform issue trackers.
Check for answers on StackOverflow with the google-maps tag.

Please be sure to include as much information as possible:
Environment details

Specify the API at the beginning of the title (for example, "Places: ...")
OS type and version
Library version and other environment information

Steps to reproduce

?

Code example
# example

Stack trace
# example

Following these steps will guarantee the quickest resolution possible.
Thanks!

There is no specific value. You can pass in as many as you want for the styles option.

Can we change the images based on count multiple of 10?

Yes, you can provide a calculator function.

The function used to determine the text to be displayed on a cluster marker and the index indicating which style to use for the cluster marker. The input parameters for the function are (1) the array of markers represented by a cluster marker and (2) the number of cluster icon styles.

Closing for now as there is no action item here.


Reference page click-to-reveal class methods

Actual Behaviour
Currently, the only way to find out about the existence of class methods from the Reference page is by clicking on the class article. For example, the only way to become aware of the setUniform method is by clicking on the p5.Shader article.
This works fine if you are already familiar with what a class does. However, it is not so great for discovering functionality you are unaware of.
Expected Behaviour
In addition to the current style (of nesting method links in class articles), I think modifying the way these classes are listed on the Reference page would go a long way in discover-ability.
Specifically, I propose using a click-to-reveal interface on the class entries. On click, the entry would expand to show nested methods. On next click, the entry would collapse. And so on. In this way, the Reference page is not cluttered, but now class methods are immediately visible (without clicking through to the associated class article).
For example:
default state

p5.Image ᐯ

toggled state

p5.Image ᐱ

loadPixels()
updatePixels()
get()
...

Would you like to work on the issue?
Yes

@JetStarBlues Can you please include how it is going to increase the accessibility of the reference.

Accessibility
The current organization of class methods makes the assumption that 1) a user is familiar with concept of classes and that 2) they will know what the base class is of an object they are working with, and 3) they will know to look in the documentation of the class to find associated methods.
As a personal example, when I was trying to figure out how to work with shaders in p5, I started out using the loadShader() function. In the example provided, the method setUniform is used. Looking at the reference page, I did not see an entry for the function, and I thus assumed it was undocumented. However later, through an unrelated Google search, I came across setUniform's documentation page. It was then that I realized that the documentation is nested under p5.Shader. With this proposal, class methods such as this one would be readily listed in the Reference page.


Add new filters

Codecov Report
Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (b14d2a6) 48.78% compared to head (21efe9b) 48.73%.

Files
Patch %
Lines

clic/src/tier1.cpp
33.33%
3 Missing and 9 partials :warning:

clic/src/tier2.cpp
54.54%
2 Missing and 3 partials :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #210      +/-   ##
==========================================
- Coverage   48.78%   48.73%   -0.05%
==========================================
  Files          14       14
  Lines        2706     2735      +29
  Branches     1158     1171      +13
==========================================
+ Hits         1320     1333      +13
- Misses        481      485       +4
- Partials      905      917      +12

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Prevent scale up

Hi,
Thank you for this fantastic library! I want to scale down the image with the cover: true option, but I do not want the image to scale up. Is there an option in the library that only scales down and not up? I search through almost all issues on Github but can not yet find the answers.
Thanks so much!

Hi @thomasdao!
Yeah, unfortunately there's no specific option for that, but as you said, you can load the image first and then use the scale API with options based on the image dimensions.

Thanks @blueimp, I implemented that and it works fine :)


deck: init at 1.22.0

Description of changes
Add new package deck. Users can use this package to manage their Kong API gateway configurations declaratively.
Things done

Built on platform(s)

[x] x86_64-linux
[x] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Let's squash all the commits into one commit please.

@GrahamcOfBorg build deck

Don't forget to squash your commits :)

Don't forget to squash your commits :)

✔

Thank you for your collaboration


Hawkular 920 Refactor out chart types and features to individual files

First commit, so as to avoid any additional merge/rebase trauma. More to come.

Merged #109


luci-base: Fix using isActive in widget-change notification.

The onchange notification handler is called too early to be able to evaluate other widget's isActive() status. Solve this by changing order of event handling - first register/execute map.checkDepends and then onchange.
Fixes: openwrt/luci#4516.

I am open to discussion, issue #4516 can be fixed simply by switching the order of events registration. Feel free to suggest even different approach 😀

I think we should simply swap the event handlers as you suggested. Can you update the PR accordingly?

I think we should simply swap the event handlers as you suggested. Can you update the PR accordingly?

Done.

Done.

Awesome! Merged.


[WIP] fix(module:tree): unexpected disappear of tree-node

PR Checklist

[x] The commit message follows our guidelines: https://github.com/NG-ZORRO/ng-zorro-antd/blob/master/CONTRIBUTING.md#commit
[x] Tests for the changes have been added (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[x] Bugfix

What is the current behavior?
Issue Number:
To close https://github.com/NG-ZORRO/ng-zorro-antd/issues/3739
What is the new behavior?
Does this PR introduce a breaking change?

[x] No

Other information
I'm a new of ng and nz, and I'm working on how to complete test case, maybe take lots of time...

What can I do with coverage?
I'm working on arch linux and have never change options of line break, so it's LF, but why this break coverage?

Is there anything wrong with my code? I don't know why netlify crashed.

@orzyyyy Please rebase to the master branch.

I have tried, but it doesn't work.

https://travis-ci.org/NG-ZORRO/ng-zorro-antd/jobs/559920055#L1201
Is there anything I can do with this?

@orzyyyy We fixed the @angular/cdk breaking change,  Please rebase to the master branch.


[Feature][Manager] Support installing agents by SSH key-based authentication

Description

SSH Authentication by username and password implemented in https://github.com/apache/inlong/pull/10098
The Dashboard also supported the password SSH Authentication in https://github.com/apache/inlong/pull/10244

But in the product environments, most users like using key-based authentication to log in to nodes by SSH, we hope this issue can complete it.
Use case
No response
Are you willing to submit PR?

[ ] Yes, I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

I would like to work on this issue.


Windows Terminal (and other apps) can't be shift-dragged to a zone

Trying out FancyZones, I discovered that the new Windows Terminal can't be shift-dragged into a zone. All the other apps I'm using seem to work, but holding down shift while dragging the terminal window just moves the window as normal and won't snap to a zone. Win+arrow doesn't seem to work specially for it either.

confirmed, looks like the terminal is hacking into the explorer.

Great bug!  I verified it too.  We'll investigate

Just to add another application with the same problem: Telegram Desktop can't be shift-dragged too.
Both are Windows Store apps but other apps like Spotify and WhatsApp Web work properly.

This also happens when using maxto, a paid alternative. I guess the underlying API is the same

Does this possibly affect all Win store apps on the UWP platform?

It's also the case with ConEmu and if you have General->Appearence:Hide captions always option activated and General->Tab bar: Tabs on bottom option deactivated.
If so, the zones are not shown if you drag the ConEmu window and shift is pressed.

The Epic Games store and Origin have this issue as well

It seems like there's something about Qt that makes windows unable to be snapped in place.
Telegram is made with Qt, Origin is made with Qt (I believe) and a Discord client I use, Ripcord, is made with Qt and is undraggable as well.

This has been reported over in the Windows Terminal project: https://github.com/microsoft/terminal/issues/2689

Edge in Application Guard can not be dragged to FanzyZones zone.
Same behaviour for Edge Dev in Application Gurard.

I can't get Chrome (76.0.3809.132) to snap either. Firefox 69 does. Edge does.

We have found the root cause and we are working on fix, stay tuned ;)

confirmed, looks like the terminal is hacking into the explorer.
@810

Hi. Terminal dev lead here. We're definitely not "hacking into the explorer", we're just using traditional non-client painting techniques. That's.. a very strange accusation.

Hi @DHowett-MSFT
feel free to close the bug that has been opened on the Terminal repo, this is not a bug in Terminal, it's a problem with the way we detect if the window is being moved or resized, the fix is on the way.
Thank you.

The fix is in master, if you don't want to wait for the next release, you can build it and give it a try!

This doesn't work with MS Edge in Application Guard.
MS Edge version: 44.18362.10024.0
It also doesn't work in the new MS Edge (Dev)
MS Edge(dev) version: 79.0.309.5 (Official build) dev (64-bit)

Hi @jopose
I haven't tested it with Application Guard yet, but I tested it with Edge Chromium Dev Version 79.0.309.5 and it works fine. Can you make sure you are running v0.12.0?
Thanks.

@jopose
when you drag Edge, the zones don't show up or they show up but Edge doesn't get snapped into the selected zone?

Yes, I'm running 0.12.
And yes, it works with Edge Chromium and regular Edge. It seams as if it's Application Guard that is the problem.

The zones don't show up.

@jopose
can you please open a new issue specific to Application Guard, since the bug seems to be different from the one that was effecting windows with custom title bars.
Thanks.

@jccraig, you are on 0.15?

@jccraig can you add you report here https://github.com/microsoft/PowerToys/issues/1466?
Thanks.

Super obscure example to throw on the pile... CVI LabWindows by National Instruments.
Its main window and all it's little undocked windows, none of them respond.

Now strangely, FancyZones did work with this application in an earlier release.  Sorry I don't remember which one.  But in the last 2 or 3 releases on, FancyZones doesn't recognize the app.

Hi @ElectroLund
in the early releases FancyZones was accepting basically every window, but it was causing a lot of problem since it was not treating dialog and child windows as they should, causing several bugs.
We make some changes to prevent those bugs and that had the side effect of not being able to move certain windows. Now we try to add support for those windows on a per case basis.

Gotcha, @enricogior.  Any chance we can get our specific app added to the "whitelist"?

We have two approaches to this:

if the app is available we can test it to determine if it can be supported
if not, we are considering adding a list of "allowed" up that the users can manage themselves

Awesome!  The 1st option is a pain to you devs and presents an "playing catch-up" forever.  It's also difficult with my app, because it's a paid suite, so a hassle for you.
I vote for #2, as it puts the responsibility on the user.

Just to add another application with the same problem: Telegram Desktop can't be shift-dragged too.
Both are Windows Store apps but other apps like Spotify and WhatsApp Web work properly.

Furthermore Telegram breaks it for ALL other apps on my system. Telegram has to be stopped, PowerToys has to be stopped and restarted for it to work again.

Hi @ziplock9000
can you please provide more information:

what version of PowerToys are you running?
what are the exact repro steps and does it happen all the times?

Hi @ziplock9000
can you please provide more information:

what version of PowerToys are you running?
what are the exact repro steps and does it happen all the times?

v0.17.0 and it happens 100% of the time.

Start PT
Start Telegram
Attempt to shift-drag a window.. nothing happens

Steps 1 and 2 can be swapped, it makes no difference.

@ziplock9000
please check if it still happens with 0.18 https://github.com/microsoft/PowerToys/releases

@ziplock9000
please check if it still happens with 0.18 https://github.com/microsoft/PowerToys/releases

That's fixed it, thanks!.

Just adding another app that doesn't snap into zones, "S3 Browser"
using powertoy ver v0.18.2

@coxse
this is a closed issue, please add your comment to https://github.com/microsoft/PowerToys/issues/1466
Thanks.

Also Teamspeak 3 cant dragged to zones. Zones do not appear.

@codingbott this is a closed issue, please add your comment to #1466
Thanks.

Same issue with OBS Studio (using version 23.1.0 64 bit)

https://parsecgaming.com/ stopped snapping after the last power tools update for me, latest versions (150-46)

This is still an issue with PT v0.45 and Windows Terminal Version: 1.8.1521.0.
As this seems to be the main issue that all others refer to, maybe re-open it until it's actually fixed?

I'm still having this issue with the Origin Launcher on the latest PowerToys update as well.

@zigurana or @jgkawell Please file a new issue for this and reference this issue to track it.

Still having this issue with Windows Terminal

If your Windows terminal uses administrator mode, then powertoy also needs to use administrator mode in order to control


Intercepting  appears to break other plugins that need it

Like the title says: other plugin that uses CR key (for ex: vim-clap) is broken if used together with pear-tree, somehow pear-tree will intercept it first and doesn't bubble it further downstream.

I would say this is a duplicate of #33, isn’t it?

Resolving in favor of https://github.com/tmsvg/pear-tree/issues/33


improve suggestions

I'm not real stuck on these but the seemed like a good idea.
I wasn't sure if you wanted to keep two variations for some translations, one that's more strokes (and hopefully both simpler to remember and easier to stroke) and one that's fewer strokes. As you can see I was a little haphazard about which I did.
I prefer the *S -> "-self" convention. It works for lots of words "himself", "herself", etc and even some plurals like "themselves". It was fairly recently (at my suggestion) that "yourself" works with the *, which I think completes the set.
I'm still a little nervous about suggesting -GT and -TD but I think that's just cuz I'm a little new and because I don't have a real steno machine. I assume it'll get easier with practice and hopefully when I get/make a more steno friendly input device

I'm still evolving a policy, but here's where I'm at.
If there are phonetic strokes and briefs, I'm trying to keep both, and sometimes several gradations, as with "association" (though there we should probably drop A/SOESHN).  Just for reference, since I can't see a great way to display them all, though what I've got now basically works.
But between the "ending-folded-in" and the "ending-separate" versions, I've been starting to keep only the former. You can almost always do the ending separate, but it seems like there are more cases where you can't fold the ending in. So if I see KREEGT I feel safe stroking the -G separately, but if I see KREET/-G then folding it in always feels like a risk.
I didn't know about *S but I'm all for conventions. I think I would keep the SEFL versions as well though. So why don't you change those three (himself, myself, themselves) and drop the separated versions of limited, running, and suggests? "running" is maybe a little questionable, but I think it's farly obvious that you need the start because  RUNG is "rung" so it's ok.

It would be cool if we could offer two learning paths: one where people have less memorizing to do, and more strokes, and another path where it's more briefy.
But I don't know that that would be the best use of our time, or that we're in a position to do it well. Right now we're mostly working off of Mirabai's stats, and it seems she's the brief-heavy type of steno, so it seems like brief-heavy is the path we can do well and easily.
I've tried to leave two suggestions in the source code on the ones where the one-stroke version is particularly weird, in case we evolve to showing multiple suggestions, or presenting the user with an option to show the simpler/verbose strokes... but I have the feeling we may drop this... who knows


Define Navigator default route in MaterialApp constructor param?

Looking with @yjbanov at providing a default route name to our app other than '/', we went on a very long walk to here.  This doesn't provide a clear resolution -- it appears that this configuration is built to allow a Flutter app to receive a route from an intent to go to a new landing page.
For the leafy app, we'd like to be able to use a route such as '/trunk' as the default landing page for our app.  Is it feasible to allow this configuration?

The Navigator lets you specify the initial route:
https://docs.flutter.io/flutter/widgets/Navigator/initialRoute.html
The MaterialApp hard codes that to ui.window.defaultRouteName, but we can make that overridable as a parameter to MaterialApp.

https://github.com/flutter/flutter/pull/6216 has a fix.


False positive with SocketFactory.createSocket()

test case:
  @MustCall("closeSocket")
  class SocketField {
    protected @Owning Socket socket = null;

    @CreatesObligation("this")
    protected void setupConnection(javax.net.SocketFactory socketFactory) throws IOException {
      this.socket.close();
      //this.socket = new Socket(); // no error, code verifies
      this.socket = socketFactory.createSocket(); // error on this line
    }
    @EnsuresCalledMethods(value = "this.socket", methods = "close")
    private void closeSocket() throws IOException {
      this.socket.close();
    }
  }

With this test we get a false positive required.method.not.called error at the assignment to this.socket inside setupConnection().  If I comment that line and uncomment this.socket = new Socket() there is no error.  (The socket is never bound in this example, but I don't think that is relevant.)  Looking at SocketAccumulationFrames.astub I didn't see an obvious problem:
https://github.com/kelloggm/object-construction-checker/blob/always-call-checker/must-call-checker/src/main/java/org/checkerframework/checker/mustcall/SocketAccumulationFrames.astub
Not sure where to dig deeper.

@msridhar I've looked into this more. This bug is really insidious, and I'm not confident that I'll be able to produce a solution we can be happy with. What follows are my notes, and some ideas on how to work around this in real code.
The key problem here is that the Called Methods Checker is treating socketFactory.createSocket() as a possibly-impure operation. Because it does so, it clears information from its store, such as the fact that close has been called on the field this.socket. A short-term workaround is to extract the call to createSocket into its own method, which can be marked as @Pure:
    @Pure
    private Socket getSocket(javax.net.SocketFactory socketFactory) throws IOException {
        return socketFactory.createSocket();
    }

If the call to socketFactory.createSocket() in the code above is replaced with a call to this method, the code will typecheck.
Obviously this is unsatisfying: why does this call need to be wrapped in this way, but not e.g. the Socket constructor (since new Socket()) works just as well? I don't really know. I also tried adding @Pure to the stub file you referred to above, which also doesn't work (why? I also don't know.).
I also don't know why the store is cleared at all before the method is called. Calling getStoreBefore(Node) on the whole assignment node, for example, returns a store with no information about this.socket when the RHS is socketFactory.createSocket(), even though as the store before that operation shouldn't have executed yet. You can see this weirdness by e.g. inserting a local variable; the assignment to s below typechecks in the body of setupConnection, even though we issue an error on the next line:
    @CreatesObligation("this")
    protected void setupConnection(javax.net.SocketFactory socketFactory) throws IOException {
        this.socket.close();
        @CalledMethods("close") Socket s = this.socket;
        this.socket = socketFactory.createSocket();
    }

Unfortunately, I can't think of a work-around that exploits this particular quirk of the system.
This does, however, lead me to another work-around for the problem which does avoid issuing the error. Consider the following replacement for the body of setupConnection:
    @CreatesObligation("this")
    protected void setupConnection(javax.net.SocketFactory socketFactory) throws IOException {
        Socket s = socketFactory.createSocket();
        this.socket.close();
        this.socket = s;
    }

This code typechecks, because the call to close() comes after the call to createSocket(). This might be the easiest way to get around the problem in practice.
Ideally, we'd be able to get the store in a real "before" state in order to do this check, making these workarounds unnecessary. I haven't found a way to produce such a store, however, from the Node that's available when we do the check. I also tried to check the store before the block containing the assignment (using direct access to the flowResult in the type factory), but that store has similarly already had its value for this.socket cleared. That its possible to write an assignment directly before the relevant line that typechecks suggests to me that this should be possible somehow, but I don't have any other ideas on how. The only idea I have is that it might be necessary to move the check earlier (i.e. out of the CFG-post-processing stage and into one of the typechecking stages), but I don't think that's feasible since it needs to compare the results of both typecheckers (and it's logically part of the consistency checker).
What do you think? Should we just live with these workarounds? Should I engage Mike, Suzanne, or both on whether it might be possible to get access to a store before the purity check happens?

I also don't know why the store is cleared at all before the method is called. Calling getStoreBefore(Node) on the whole assignment node, for example, returns a store with no information about this.socket when the RHS is socketFactory.createSocket(), even though as the store before that operation shouldn't have executed yet. You can see this weirdness by e.g. inserting a local variable; the assignment to s below typechecks in the body of setupConnection, even though we issue an error on the next line:
    @CreatesObligation("this")
    protected void setupConnection(javax.net.SocketFactory socketFactory) throws IOException {
        this.socket.close();
        @CalledMethods("close") Socket s = this.socket;
        this.socket = socketFactory.createSocket();
    }

This seems to me like a clear bug.  Is there any way we can debug to figure out why the store before the assignment is getting information cleared out of it?  Or is that too nasty?

This seems to me like a clear bug

I agree that the behavior is undesirable, but it doesn't violate the contract of the store, which is permitted to "forget" information whenever convenient. I don't know why the store behaves this way; further investigation would have to look into the core CF rather than our checker. While that will likely be nasty, my bigger concern is that this behavior exists for a reason (i.e. some type system depends on it for soundness), so even if we discover the cause it may not be possible to fix.

fixed by #389


Floating bar chart and support on time scale?

Expected Behavior
As reported into issue #7356, my expectations was to be able to use floating bars on time scale.
The sample, created at that time by @kurkle , https://codepen.io/kurkle/pen/gOadBzy , works perfectly with CHART.JS 300.alpha.
My expectation is also that I can define data points with X: UTC, Y: [0,1] and not only with dates as strings.
Current Behavior
Going to dist/master, I've created another sample based on what @kurkle  created, changing only the link to CHART.JS, and doesn't work anymore.
But also changing the @kurkle sample, setting does not work.

Steps to Reproduce
https://codepen.io/stockinail/pen/LYGgyja
Environment

Chart.js version: dist/master
Browser name and version: FF 78.0.2

It mostly works with:
type: 'timeseries',
ticks: {
	source: 'data'
},

There's one empty data point in that case though, which is a bug. It looks like BarController.getMinMax isn't doing the right thing because TimeScale.min is being set to 50, which is nonsense. I think the issue is that BarController overrides updateRangeFromParsed and is always applying the range from custom regardless of which axis we're getting the min and max for. That's where the 50 is coming from because it's the min value on the y-axis.