Installer

Add installer project

Update webview2 initialization: By default, a webview uses the location of the .exe for creating its user data folder. However, when the application is installed to a protected system directory (such as C:\Program FIles), it fails to do so (moreover it does not raise any exceptions and fails silently). In order to fix this, now the WebView2 control is initialized with a path to its root UDF under /AppData/Local/.  The main issue with the above point is that the UDF should be set before the WebView2 starts navigation.
Change all .exe relative paths to absolutes: All relative paths are converted to proper absolute paths so that they are not broken when the application is installed with an msi and executed via a shortcut.


Configure qt dyntables

https://github.com/ytsaurus/ytsaurus/issues/905

Forgot to publish my review, sorry, everything looks good.

Shipped!

Do we want to merge this? @Krisha11


Remove SyncLoop from Sequencer

Same as audit issue:
The sequencer's store can render SyncLoop a no-op and the block cache
memory will never get cleared

Adding RetrieveLoop and BlockStoreRetrieveLoop for completeness.


Implement top_level_menu toggle

Hi,
would love (in comparison to other plugins) to have the ability to put the SLM on the top level menu instead below plugins.
Many other plugins already support this (as it is easier for navigation, IMHO). Should be a "standard" option for many.

This appears to be more or less the same as what was requested in issue #37. I'm not certain about the capabilities within Netbox or if it's possible to create a toggle to rearrange items in the menu. Could you reference any existing (open-source) plugins with similar features?


Call treeView.createView if not yet created.

This fixes a bug where @treeView is null when Atom is launched with the tree-view closed.

thank you :tada:


Splitting Snapshot Files

Do you want to request a feature or report a bug?
Request a feature
What is the current behavior?
Currently, when using snapshots, a snapshot file is created per test file. In cases where test cases are generated, the snapshot files can become thousands of lines, which makes them unwieldy.
What is the expected behavior?
It would be useful to be able to break up these large, complex test files. I’d propose either some sort of hook in the Jest API;
/// index.spec.js
import myCoolThing from './index';

const TEST_CONDITIONS = [
  {meow: true, nya: false},
  {meow: true, nya: true},
  {meow: false, nya: false}
];

describe('my cool thing', () => {
  TEST_CONDITIONS.forEach(({ meow, nya } => {
    it(`does some things when meow is ${meow} and nya is ${nya}`, () => {
      expect(myCoolThing(meow, nya)).toMatchSnapshot();
    });
    jest.splitSnapshotFile(); // here’s the new magic
  });
});

Should result in __snapshots__ containing;
index.spec.js-1.snap
index.spec.js-2.snap
index.spec.js-3.snap

Or the ability to specify the maximum size (actual interpretation of “size” open to opinions - bytes? lines? results?) of any given snapshot file.
For cases where Jest is used for integration testing or to test several different configurations within something complex, this would allow for nicer output, especially when testing large chunks of React component output!

Another option is to make toMatchSnapshot take a configuration object, in our iOS snapshot matchers we support passing in a filename, or (unimportant for this conversation) iOS specific options

What you can do right now, it's changing your test generator to make a single test file per expectation.
Another option could be using beforeAll and afterAll to manually setup the environment like you describe:
beforeAll(joinAllSnapshots)
afterAll(splitAllSnapshots)

where splitAllSnapshots can just require the generated snapshot file and then write each exports down in parts in a folder and then delete the main snapshot file.
joinAllSnapshots can just do a dir list with fs.readdirSync and create a single snap file where Jest will expect it to be.
This way you can keep the .split files on your version controlled system and Jest will just work as intended, I think as long as you don't use .snap as extension for the split file should work ok.

a single test file per expectation

This relies on all your tests having names which are valid file paths, or doing some sort of semi-destructive transform on them, and that’s not really the granularity I want, either!

using beforeAll and afterAll to manually setup the environment

This is more viable, but not exactly the nicest way to approach this. It’s bad enough to write complicated filesystem code just to write tests, so writing such a thing to make my test snapshots come out in a nice format seems like bad news! Likewise, having to create/delete files all the time feels like a bad move for SSD longevity 😉.

I'm heavily against this because it will make tracking of snapshot files harder and would require more static analysis. There are two questions you should ask yourself:

Do I really need snapshots that are this big?
Can I split these huge snapshots up into multiple test files that share common test utilities?

Answering one or both of these questions should lead to smaller snapshot files. Especially the second one is essentially a "user-land implementation" of your feature that comes at no additional complexity for Jest.
Also, SSDs don't suffer the longevity issues any more, so that isn't really a concern here.

Do I really need snapshots that are this big?

It’s less the big and more that I don’t necessarily need to store them repeatedly - there’s no way for me to declare, as it stands, “these combinations of situations should all map to this result,” which is what leads to the large snapshot file sizes.

Can I split these huge snapshots up into multiple test files that share common test utilities?

I mean, technically yes, but in the case of the example, what you end up with is three files which test slight variations on the same thing, and worse, would actually serve to make writing combinations of those cases more difficult.

I feel like the correct answer here would then be to write a diff engine that will make it so that your snapshot will only capture the difference between the items, rather than all the content. @xixixao actually just asked about this at FB last week.

I remember @pedrottimark was discussing somewhere about diffSnapshot thing.

I will eventually catch up to @pedrottimark's awesome issues where he discusses these things, mostly with himself (sorry I haven't been able to keep up, please keep posting issues. I see them :D )

See #2197 and #2202.

Having an option to store each snapshot to a separate file would be super useful for cases like NextJs pages snapshots where you can simply require all files from pages/ folder. At this moment I have a snapshot file of ~2Mb and it's even not a half of all pages. It looks like continuing adding snapshots this way isn't scalable. Splitting the single simple test with looping over pages-files into manually or auto-generated list of test files looks overcomplicated as well

we have similar issue at typescript-eslint , biggest one being ~4mb, ability to output them per test (or per option) will be really useful.

https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/typescript-estree/tests/lib/__snapshots__/javascript.ts.snap
https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/typescript-estree/tests/lib/__snapshots__/typescript.ts.snap
https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/parser/tests/lib/__snapshots__/typescript.ts.snap
https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/parser/tests/lib/__snapshots__/javascript.ts.snap

another use case:
reduce number of escapes / pretty-print snapshots / get human-readable snapshots
in my case, i generate JS source code, which looks ugly when stuffed into a string
solved by jest-specific-snapshot - thx @armano2 : )


Syntax highlighting - system handles

LanguageServerInfo: 1.16.0-SNAPSHOT-607d691 -- ClientInfo: Visual Studio Code 1.92.2 -- JVM: Oracle Corporation 17.0.6+9-LTS-190
I've noticed that system handles (file-information, session, error-status etc are not being parsed correctly). They are all coming through as variable.language.abl:
define variable p as character no-undo.
define variable x as character no-undo.
define variable y as logical no-undo.

// scope(session): variable.language.abl source.abl
p = session:temp-directory.

// scope(file-information): variable.language.abl source.abl
x = file-information:full-pathname.

// scope(error-status)variable.language.abl source.abl
y =
    error-status:error
    or error-status:num-messages gt 0.

// scope(log-manager): variable.language.abl source.abl
log-manager:write-message("Lorem ipsum").

I've tried to have a poke around the abl-tmllanguage repository, and the tests are expecting that this is the case. For example, in specs/misc-statements/return-statement.spec.js (below), the session token is expected to be variable.language.abl
describe('', () => {
  let statement = `RETURN session:exit-code.`;
  let expectedTokens = [
    { "startIndex": 0, "endIndex": 6, "scopes": ["source.abl", "keyword.other.abl"] },  // 'RETURN'
    { "startIndex": 6, "endIndex": 7, "scopes": ["source.abl"] },  // ' '
    { "startIndex": 7, "endIndex": 14, "scopes": ["source.abl", "variable.language.abl"] },  // 'session'
    { "startIndex": 14, "endIndex": 15, "scopes": ["source.abl", "punctuation.separator.colon.abl"] },  // ':'
    { "startIndex": 15, "endIndex": 24, "scopes": ["source.abl", "entity.name.function.abl"] },  // 'exit-code'
    { "startIndex": 24, "endIndex": 25, "scopes": ["source.abl", "punctuation.terminator.abl"] }  // '.'
  ];
  shared.itShouldMatchExpectedScopes(statement, expectedTokens);
})

I can see scenarios like SessionManager (spec/type-name/type-name.spec.js), where it would be parsed as a variable, since this is a class/package name, not a system handle:
describe('', () => {
  let statement = `SessionManager:ContestDataset:READ-XML("longchar":U,
  lcDataset,
  "EMPTY":U, ?, ?) . `;

  let expectedTokens = [
    [
      { "startIndex": 0, "endIndex": 14, "scopes": ["source.abl", "variable.other.abl"] },  // 'SessionManager'
      { "startIndex": 14, "endIndex": 15, "scopes": ["source.abl", "punctuation.separator.colon.abl"] },  // ':'
      { "startIndex": 15, "endIndex": 29, "scopes": ["source.abl", "entity.name.function.abl"] },  // 'ContestDataset'
      { "startIndex": 29, "endIndex": 30, "scopes": ["source.abl", "punctuation.separator.colon.abl"] },  // ':'
      { "startIndex": 30, "endIndex": 38, "scopes": ["source.abl", "entity.name.function.abl"] },  // 'READ-XML'
// snipped

I don't know if it's an "simple" as changing abl.tmLanguage.json to this, but that breaks alot of tests (as noted above).
    "abl-system-handles": {
      "match": "(?i)\\s*(this-object|super|self|this-procedure|target-procedure|source-procedure|session|error-status|compiler|audit-control|audit-policy|clipboard|codebase-locator|color-table|debugger|dslog-manager|file-information|file-info|font-table|last-event|log-manager|profiler|rcode-information|rcode-info|security-policy|session|web-context)\\s*(?=:)",
      "captures": {
        "1": {
          "name": "keyword.other.abl" <<<<<<< here
        },
        "2": {
          "name": "punctuation.separator.colon.abl"
        }
      }
    },

I've noticed that system handles (file-information, session, error-status etc are not being parsed correctly). They are all coming through as variable.language.abl:

@danielbecroft What is your expectation here?
These are deliberately scoped to variable.language.abl  , per the rules in https://macromates.com/manual/en/language_grammars#language_rules (which are used as a guideline for how to scope the many ABL statements and keywords ).
That page says

variable — variables. Not all languages allow easy identification (and thus markup) of these.
...
language — reserved language variables like this, super, self, etc.****

@PeterJudgeZA Good question. I guess I'm used to something like PDSOE that would highlight anything that's a keyword as a keyword. Contrast this to the parsing here, and it looks odd. It also look strange when this-object (on its own) is a keyword.other.abl, but as soon as it's got a colon after it, it becomes variable.language.abl:
// scope(this-procedure): keyword.other.abl source.abl (fore: keyword.other)
vHandle = this-procedure.

// scope(this-procedure):	variable.language.abl source.abl (fore: variable.language)
vHandle = this-procedure:first-sibling.

this-procedure hasn't changed from what it is, so I wouldn't be expecting a change to how it's highlighted.
It might just be what it is, and I'll have to get used to how it looks.

Contrast this to the parsing here, and it looks odd. It also look strange when this-object (on its own) is a keyword.other.abl, but as soon as it's got a colon after it, it becomes variable.language.abl:

Yes, good point. this-object and this-procedure (and the other system handles) should both always be scoped as variable.language.abl , regardless of any  trailing colons.
-- peter

From: Daniel Becroft @.>
Sent: Monday, September 9, 2024 12:05:41 AM
To: vscode-abl/vscode-abl @.>
Cc: Peter Judge @.>; Mention @.>
Subject: Re: [vscode-abl/vscode-abl] Syntax highlighting - system handles (Issue #183)
@PeterJudgeZAhttps://github.com/PeterJudgeZA Good question. I guess I'm used to something like PDSOE that would highlight anything that's a keyword as a keyword. Contrast this to the parsing here, and it looks odd. It also look strange when this-object (on its own) is a keyword.other.abl, but as soon as it's got a colon after it, it becomes variable.language.abl:
// scope(this-procedure): keyword.other.abl source.abl (fore: keyword.other)
vHandle = this-procedure.
// scope(this-procedure):       variable.language.abl source.abl (fore: variable.language)
vHandle = this-procedure:first-sibling.
this-procedure hasn't changed from what it is, so I wouldn't be expecting a change to how it's highlighted.
It might just be what it is, and I'll have to get used to how it looks.
—
Reply to this email directly, view it on GitHubhttps://github.com/vscode-abl/vscode-abl/issues/183#issuecomment-2336854720, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AB7IJ2OQASC57KRASDVKT4LZVTJ4LAVCNFSM6AAAAABNTSXYMOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMZWHA2TINZSGA.
You are receiving this because you were mentioned.

This is resolved in grammar release 1.3.8


Microsoft Excell ERROR: "found a problem with some content"

When using Export-excel with values that have formulas, Excel states: "found a problem with some content in ExcelSheetName.XLSX. Do you want us to recover as much as possible?"
This occurs 9/10 times. However, it never occurs when using Converto-CSV and opening the CSV in excel.

need are repro of data etc

Seeing the same error. Tested several times commenting out one parameter at a time. This seems to be related to the -Title parameter. Once that parameter was commented out, the file was created an opened as expected in 5 subsequent tests.

A couple of quick work arounds:

remove excel file before calling Export-Excel
use ClearSheet parameter

@scriptingstudio  - If you're saying to delete the excel file before using Export-Excel, then that defeats the purpose of creating an excel file with many worksheets. Do I understand you?

@RaysCars I need a simple repro I can run so I can look at the issue. A zip file with the current xlsx with data and a ps1 reproing the issue.

attached is one example:
On Fri, Nov 17, 2023 at 8:17 AM Doug Finke @.***> wrote:

@RaysCars https://github.com/RaysCars I need a simple repro I can run
so I can look at the issue. A zip file with the current xlsx with data and
a ps1 reproing the issue.
—
Reply to this email directly, view it on GitHub
https://github.com/dfinke/ImportExcel/issues/1532#issuecomment-1816411746,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAIHR2ZATP27D3QERF2NYNDYE5PU5AVCNFSM6AAAAAA6QHTNPSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMJWGQYTCNZUGY
.
You are receiving this because you were mentioned.Message ID:
@.***>

Sorry, don't see the attachment

RecoverIssue.zip
I duplicated the issue to a very simple case. I am converting a list of "fields" defined in XML to Excel. I ran into this issue a few years ago, and using -ReZip and -ClearSheet avoided the "recover" message.
Export-Excel 7.8.9
PSVersion                      5.1.22621.3672
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.22621.3672
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
The following reproduces the issue.
$_fieldDefinitionFilePath = 'A:\Temp\FieldDefinition.xml'

$_excelFilePath = 'A:\Temp\FieldDefinition.xlsx'

$_fields = [xml](Get-Content -Path $_fieldDefinitionFilePath)

$_fieldListing = $_fields.StaticResouce.Fields.Field | ForEach-Object {
    [pscustomobject]@{

        Name   = [string]$_.Name
        #Name = 'fred'

        # this will work
        # Name = 'fred'
        ##

        # this will fail
        # Name   = [string]$_.Name
        ##
    }
}

Remove-Item -Path  $_excelFilePath

Export-Excel -InputObject $_fieldListing -Path $_excelFilePath

I did the example at https://dfinke.github.io/powershell/2019/07/31/Creating-beautiful-Powershell-Reports-in-Excel.html with no issues
This example also works
Get-Process | Where Company | Export-Excel A:\Temp\ps.xlsx -Show -IncludePivotTable -PivotRows Company -PivotData @{Handles=”sum”} -IncludePivotChart -ChartType PieExploded3D

Found the issue. I ran into this question, and it reminded me about values that begin with = which are interpreted as formulas. I inserted ` to the Name, and the recovery message disappeared
FROM
<Field Number="7672" Name="= Borrower's closing cost" IsBorrowerSet="false" PRS="true" BRW="true" AuditLogged="true"/>
TOL
<Field Number="7672" Name="'= Borrower's closing cost" IsBorrowerSet="false" PRS="true" BRW="true" AuditLogged="true"/>

https://stackoverflow.com/questions/71335236/removed-records-formula-from-xl-worksheets-sheet1-xml-part

Wow. So I understand, the value being inserted is "= Borrower's closing cost" and you put a single quote ' in frot of the =. "'= Borrower's closing cost"
I recall that from way back is how you indicate to Excel the next parts are not a formula etc.
Good stuff!


Update "View open jobs" link in NewDot About page from Upwork to GH

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:
Clicked "View open jobs" link in About section of NewDot
Expected Result:
Opens to https://github.com/Expensify/App/issues?q=is%3Aopen+is%3Aissue+label%3A"Help+Wanted"
Actual Result:
Opens to https://www.upwork.com/ab/jobs/search/?q=Expensify React Native&sort=recency&user_location_match=2
Platform:

Where is this issue occurring?

Web
iOS
Android
Desktop App
Mobile Web

Version Number: v1.0.79-4
View all open jobs on Upwork

Triggered auto assignment to @trjExpensify (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

I think this is the easiest and quickest task from all of the issues on this repo.
Just need to update this Constant to a new URL and its name in all of its usages. https://github.com/Expensify/App/blob/50828ab6752324988fbfdc7020878c80adf174bd/src/CONST.js#L125

Sorry, playing catch-up guys! I agree, no point sending this to Upwork. I've sent a PR for it. 👍

Triggered auto assignment to @MonilBhavsar (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

Deployed to prod a little while ago, not sure why the issue didn't close.


Fix ActiveSupport 5.1 deprecation warnings

Notably, there are still 4 test failures on ActiveRecord-edge, having to do with the "chained activerecord association subroot" tests. Debugging those is beyond my level of acquaintance with the code base. But the deprecation warnings surrounding attribute_changed?, attribute_was, and changes have all been silenced here.

Oddly, the failures that are showing up under Travis for the edge appraisal are not the same ones that I'm getting on my machine. But they're too tough for me to parse, and there's no deprecation warnings (other than those coming out of database_cleaner, so I think this PR is doing its job.


Chat - Can't find  profile message for pay with paypal

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Issue found when executing PR https://github.com/Expensify/App/pull/24175
Action Performed:

Add Paypal as a payment method
Create a workspace
In your workspace expense chat, request money in USD (may require tweaking beta permissions to be able to do this)
Try to pay with paypal
Verify that the URL and the Paypal page shows the right amount in USD
Go to the workspace settings
Change the workspace's currency to JPY
In your workspace expense chat, request money in JPY (may require tweaking beta permissions to be able to do this)
Try to pay with paypal

Expected Result:
Verify that the URL and the Paypal page shows the right amount in JPY
Actual Result:
Can't find  profile message displayed
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[x] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.55-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/78819774/a68056e8-ac5d-4f60-a93c-c9b5fa476e4a
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub

I want to dig into this a bit more, it's edge case so it's not an immediate priority

Also.. thanks @rayane-djouah for sharing the link above!

I feel like the bug is on the Paypal side and not ours.  Or, it has to do with their API and potential limitations.
Going to close for now.


Fix/globals

[ ] I have tested my component
[ ] I have updated the documentation or there is no documentation needed

:tada: This PR is included in version 2.0.0-rc.3 :tada:
The release is available on:

npm package (@next dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Calendar jumps when using redux to manage selected dates

Hi there,
great calendar!
I have an issue with using it with redux-form however.
I'm building a create-event form and store selected dates in an array.
So when clicking a date I trigger this:
onChange={d => change('dates', d)}

Everything works but the calendar always jumps to the position of the current date! I'm assuming it has something to do with the selected array being changed?
Thanks!
David

Could you create a reproduction of this issue in JSFiddle or WebpackBin?
As a rule of thumb, you should always provide enough code for the issue to be replicated when you open issues in open source projects. There's really no way for me to help you otherwise.


Extend Enums before freezing?

Hi,
Possible to Extend an Enum before freezing it?
I have a use case:
I have a global npm module that has a set of Enums and is included in an application which has its own set of enums, can I somehow merge them together?
Also by merging as in the global module's Enum is already instantiated...
I wrote a piece of code that does the job, but It wont be as per the requirements i.e. I haven't take aspects like frozen into account yet.

Can't you create a new Enum containing all values?

No actually, when I require the global module the Enum comes as instantiated ... I didn't want the localized module to create the Enum rather just extend it with the enum coming from global module...
this is because the sequence values will get altered, and some of the code in the global module is using the Enum (without extension) and localized module is using the Enum (with extension)
If i create a new enum then the EnumItem sent by the Global module will have different values corresponding to the ones in the localized module

Like for eg:
var myModule = require('myModule');
var CODES = myModule.CODES; // Already comes as Enum, Say ['SUCCESS': 1, 'FAIL': 2]

// Later Ahead
CODES.extend(['PENDING']); // Becomes ['SUCCESS': 1, 'FAIL': 2, 'PENDING': 4]

If you could suggest another alternative would be great.. Another way I see is to get only the Array values from the global module and try to make an Enum and Pass it back into the global module.

Can you try to do a PR?

Yeah sure thing!

v2.3.0


If only one of camera or microphone are blocked, both are shown as blocked

Hello and thanks again for a great service and library!
Expected behavior
Device allowing either only microphone or only video can use the one allowed
Describe the bug (unexpected behavior)
When device denies access to video only both
daily.participants().local?.tracks.audio.blocked?.byPermissions // true
daily.participants().local?.tracks.video.blocked?.byPermissions // true

are true
Same is true for denying microphone only.
Same on both iOS and Android

@filipi87 This is probably a react native specific issue right? Or should we report this to daily-js too? Sort of a blocker for us.

Hi @swemail ,
Thanks for reporting this.
I have been able to reproduce It here, and we have already merged a fix for It. It will be available on the next release of react-native-daily-js.
We are also working to improve, if you are building an app that just needs audio or video, to just request the permission that is needed, but this change will come in another future release.

Makes sense @filipi87! We want the owner to be able to see which participants have denied permissions and to what. That's why we needed this functionality 😃
Thanks for fixing this 🙌

Hi @swemail ,
Thanks for reporting this.
I have been able to reproduce It here, and we have already merged a fix for It. It will be available on the next release of react-native-daily-js.
We are also working to improve, if you are building an app that just needs audio or video, to just request the permission that is needed, but this change will come in another future release.

Awesome news @filipi87! Thanks for fixing this!

I have confirmed that it works now, great work @filipi87! This issue could be closed now. Not sure if you like reporters to do that or you do it yourself?

Fixed already available in the version 0.36.0 of react-native-daily-js
Thanks @swemail and @gewfy for reporting this.


how to collect reviews textual data?

hi @tomslee !
thanks for makign this code available. I was looking at the insideairbnb website where you also have reviews and calendars for each listing id. How do you collect that data? I can't seem to find it in this script here. Thanks for your help!
florian

Hi Florian,
I am not affiliated with Inside Airbnb, although I have collaborated with
Murray Cox (who runs it) from time to time. His code and mine are separate,
so I am afraid I cannot help you with this.
On Tue, 26 Jul 2016 at 08:28 Florian Oswald<EMAIL_ADDRESS>wrote:

hi @tomslee https://github.com/tomslee !
thanks for makign this code available. I was looking at the insideairbnb
website where you also have reviews and calendars for each listing id. How
do you collect that data? I can't seem to find it in this script here.
Thanks for your help!
florian
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tomslee/airbnb-data-collection/issues/4, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AD8DnNm1ugjfoe1k0shEr1q96dcUlL2Eks5qZf1_gaJpZM4JVF7J
.


about preprocess.sh

Can you explain why you need to use preprocess.sh to process the predicted result?

Similar issue to #13.

@ycmin95 as my understand, you did not use preprocess.sh to preprocess train, dev, test (replacing certain words,  removing certain markers (like 'EMOTION', 'PU', 'LEFTHAND') )  at Data Preparation step, right?


Added leetcode solution for Problem number 1305

Related Issue
Issue number ; #2779
Issue number : # 2780
[Cite any related issue(s) this pull request addresses. If none, simply state "None”]
Description
[Please include a brief description of the changes or features added]
Type of PR

[ ] Bug fix
[ ] Feature enhancement
[x] Documentation update
[ ] Security enhancement
[ ] Other (specify): _______________

Screenshots / Videos (if applicable)
[Attach any relevant screenshots or videos demonstrating the changes]
Checklist

[x] I have performed a self-review of my code.
[x] I have read and followed the Contribution Guidelines.
[x] I have tested the changes thoroughly before submitting this pull request.
[x] I have provided relevant issue numbers, screenshots, and videos after making the changes.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] I have followed the code style guidelines of this project.
[x] I have checked for any existing open issues that my pull request may address.
[x] I have ensured that my changes do not break any existing functionality.
[x] Each contributor is allowed to create a maximum of 4 issues per day. This helps us manage and address issues efficiently.
[x] I have read the resources for guidance listed below.
[x] I have followed security best practices in my code changes.

Additional Context
[Include any additional information or context that might be helpful for reviewers.]
Resources for Guidance
Please read the following resources before submitting your contribution:

[ ] Code Harbor Hub Community Features
[ ] Docusaurus Documentation
[ ] React.js Documentation
[ ] Markdown Guide
[ ] MDX Documentation
[ ] Mermaid Documentation

Resources for DSA Features on Our Site:

[ ] Tabs: Switch Languages
[ ] Line Numbering
[ ] Math Equations

Contribution Guidelines
Thank you for considering contributing to our project! To ensure smooth collaboration and effective contribution management, please adhere to the following guidelines:
Issue Creation

Limit on Issues:

Each contributor is allowed to create a maximum of 4 issues per day. This helps us manage and address issues efficiently.

Contribution Levels

Basic Contributions:

This project is primarily focused on documentation. Most of the setup has been completed, so contributors will generally need to work on basic code tasks, such as writing tests.
For these tasks, issues will be assigned the level1 label.

Acknowledging Hard Work:

If a contributor puts in significant effort on a task, the issue will be upgraded to level2. This is our way of recognizing and appreciating extra effort.

Feature Additions and Component Work:

Contributors working on new features or components using JSX/TSX will be assigned a level based on the complexity and quality of their work.
The more complex and valuable the contribution, the higher the level assigned.

Level Definitions

Level1:

Tasks are straightforward, such as fixing minor bugs, writing tests, or making simple documentation updates.

Level2:

Tasks require more effort, such as addressing complex bugs, improving existing features, or making substantial documentation improvements.

Level3:

Tasks are highly complex and involve significant new feature development, major refactoring, or extensive contributions to the project’s core components.

We look forward to your contributions and appreciate your effort in helping us improve the project!

@sanjay-kv Sir i have solved 2 issuees in this PR both of level 1 so please give me 20 pointd for that :)

@UtkarshBirla28 anyhow this repo has limitation of 150 points giving 20 will reduce the no of PR you can issue.
anyhow admin has to decide on this.


Open Sauced needs a logo/favicon

I am thing a siracha or ketchup bottle, but open to suggestions. If you would like to take this, SVG would be needed, as well as a favicon.

Logo and Favicon:


minions do not appear on leaderboard

How do I make the minions appear on the leaderboard?

You would have to remove this line of code from PlayerTracker.js

@Hydra4dude you can actually now look in gameserver.ini and change the config minionsOnLeaderboard to 1, since my recent pull request got merged.


Don't ignore gravatar error

Related to (but does not fix) #2073.

LGTM

LGTM

I think on error it should return default avatar url

Hmm, guess you have a point there

@lafriks Good suggestion, updated

Let LG-TM work


Regex question

Describe the bug
How can I fix this regex? It worked before but suddenly doesn't anymore.
To Reproduce
Use: replaceMessages=[ ["<(?!img|a)[^>]*>",""], [" "," "] ]
Expected behavior
HTML Tags should be filtered out of the message.
Screenshots/debug logs
level=error msg="regexp in msteams.test-teams failed: error parsing regexp: invalid or unsupported Perl syntax: (?!" prefix=gateway
Environment (please complete the following information):

OS: Ubuntu 22.04
Matterbridge version: output of  1.26

This has never worked, golang doesn't support ?!
See https://github.com/google/re2/wiki/Syntax

Hi @42wim although I fully believe you I cannot explain then why it did seem to to work. See the following messages (one of many examples I can provide). The top one is sent before the regex, and the bottom one after:

Also I don't remember seeing the mentioned error message in the log.
Besides if it worked or not, is there any way I can edit this regex to make it work with Matterbridge?


👨🏫👔 [Style] (test) Modify the coding style of common modules in testing code.

Target

Modify the coding style of common modules in testing code.

Modify Code Scope

Testing Code

All common modules in testing.

Effecting Scope

Nothing.

Description

Modify the coding style to be same as PEP 8.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 94.313%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1078

Relevant Lines:
1143

💛  - Coveralls


Can't build on Fedora 23: "Error writing headers"

I performed a recursive Git clone of TrueCraft, ran nuget restore and got this:
WARNING: Error: SendFailure (Error writing headers)
WARNING: Error: SendFailure (Error writing headers)
WARNING: Error: SendFailure (Error writing headers)
WARNING: Error: SendFailure (Error writing headers)
WARNING: Error: SendFailure (Error writing headers)
WARNING: Error: SendFailure (Error writing headers)
WARNING: Error: SendFailure (Error writing headers)
WARNING: Error: SendFailure (Error writing headers)
Unable to find version '3.7.0' of package 'YamlDotNet'.
Unable to find version '7.0.1' of package 'Newtonsoft.Json'.
Unable to find version '<IP_ADDRESS>9' of package 'MonoGame.Framework.Linux'.
Unable to find version '<IP_ADDRESS>9' of package 'MonoGame.Framework.MacOS'.
Unable to find version '<IP_ADDRESS>9' of package 'MonoGame.Framework.WindowsGL'.
Unable to find version '<IP_ADDRESS>' of package 'NVorbis'.
Unable to find version '4.2.1507.0118' of package 'Moq'.
Unable to find version '2.6.4' of package 'NUnit'.

sudo nuget restore returns the same output, so it is probably not a permission error.
mono --version is Mono JIT compiler version 4.0.5 (Stable <IP_ADDRESS>/1d8d582 Mon Jan  4 11:09:45 UTC 2016). NuGet Version: <IP_ADDRESS>. Using Fedora 23 64-bit.
Maybe this is not TrueCraft's fault, I don't know.

mozroots --import --sync

Nuget works now, but xbuild gives me this:
XBuild Engine Version 12.0
Mono, Version <IP_ADDRESS>
Copyright (C) 2005-2013 Various Mono authors

Build started 13/01/2016 21:35:54.
__________________________________________________
Project "/home/hugo/Git/truecraft/TrueCraft.sln" (default target(s)):
	Target ValidateSolutionConfiguration:
		Building solution configuration "Debug|Any CPU".
	Target Build:
		Project "/home/hugo/Git/truecraft/externals/fNbt/fNbt/fNbt.csproj" (default target(s)):
			Target PrepareForBuild:
				Configuration: Debug Platform: AnyCPU
			Target GenerateSatelliteAssemblies:
			No input files were specified for target GenerateSatelliteAssemblies, skipping.
			Target GenerateTargetFrameworkMonikerAttribute:
			Skipping target "GenerateTargetFrameworkMonikerAttribute" because its outputs are up-to-date.
			Target CoreCompile:
				Tool /usr/lib/mono/4.5/mcs.exe execution started with arguments: /noconfig /debug:full /debug+ /optimize- /out:obj/Debug/fNbt.dll InvalidReaderStateException.cs JetBrains.Annotations.cs NbtCompression.cs NbtFormatException.cs NbtBinaryReader.cs NbtBinaryWriter.cs NbtParseState.cs NbtReader.cs NbtReaderNode.cs Properties/AssemblyInfo.cs NbtFile.cs Serialization/IgnoreOnNullAttribute.cs Serialization/INbtSerializable.cs Serialization/NbtIgnoreAttribute.cs Serialization/NbtSerializer.cs Serialization/TagNameAttribute.cs TagSelector.cs Tags/NbtIntArray.cs Tags/NbtByte.cs Tags/NbtByteArray.cs Tags/NbtCompound.cs Tags/NbtDouble.cs Tags/NbtFloat.cs Tags/NbtInt.cs Tags/NbtList.cs Tags/NbtLong.cs Tags/NbtShort.cs Tags/NbtString.cs Tags/NbtTag.cs NbtTagType.cs ZLibStream.cs /target:library /define:DEBUG /doc:../bin/Debug/fNbt.xml /nostdlib /reference:/usr/lib/mono/gac/System/<IP_ADDRESS>__b77a5c561934e089/System.dll /reference:/usr/lib/mono/gac/System.Core/<IP_ADDRESS>__b77a5c561934e089/System.Core.dll /warn:4
CSC: error CS0518: The predefined type `System.Object' is not defined or imported
CSC: error CS0518: The predefined type `System.ValueType' is not defined or imported
CSC: error CS0518: The predefined type `System.Attribute' is not defined or imported
CSC: error CS0518: The predefined type `System.Int32' is not defined or imported
CSC: error CS0518: The predefined type `System.UInt32' is not defined or imported
CSC: error CS0518: The predefined type `System.Int64' is not defined or imported
CSC: error CS0518: The predefined type `System.UInt64' is not defined or imported
CSC: error CS0518: The predefined type `System.Single' is not defined or imported
CSC: error CS0518: The predefined type `System.Double' is not defined or imported
CSC: error CS0518: The predefined type `System.Char' is not defined or imported
CSC: error CS0518: The predefined type `System.Int16' is not defined or imported
CSC: error CS0518: The predefined type `System.Decimal' is not defined or imported
CSC: error CS0518: The predefined type `System.Boolean' is not defined or imported
CSC: error CS0518: The predefined type `System.SByte' is not defined or imported
CSC: error CS0518: The predefined type `System.Byte' is not defined or imported
CSC: error CS0518: The predefined type `System.UInt16' is not defined or imported
CSC: error CS0518: The predefined type `System.String' is not defined or imported
CSC: error CS0518: The predefined type `System.Enum' is not defined or imported
CSC: error CS0518: The predefined type `System.Delegate' is not defined or imported
CSC: error CS0518: The predefined type `System.MulticastDelegate' is not defined or imported
CSC: error CS0518: The predefined type `System.Void' is not defined or imported
CSC: error CS0518: The predefined type `System.Array' is not defined or imported
CSC: error CS0518: The predefined type `System.Type' is not defined or imported
CSC: error CS0518: The predefined type `System.Collections.IEnumerator' is not defined or imported
CSC: error CS0518: The predefined type `System.Collections.IEnumerable' is not defined or imported
CSC: error CS0518: The predefined type `System.IDisposable' is not defined or imported
CSC: error CS0518: The predefined type `System.IntPtr' is not defined or imported
CSC: error CS0518: The predefined type `System.UIntPtr' is not defined or imported
CSC: error CS0518: The predefined type `System.RuntimeFieldHandle' is not defined or imported
CSC: error CS0518: The predefined type `System.RuntimeTypeHandle' is not defined or imported
CSC: error CS0518: The predefined type `System.Exception' is not defined or imported
			Task "Csc" execution -- FAILED
			Done building target "CoreCompile" in project "/home/hugo/Git/truecraft/externals/fNbt/fNbt/fNbt.csproj".-- FAILED
		Done building project "/home/hugo/Git/truecraft/externals/fNbt/fNbt/fNbt.csproj".-- FAILED
		Project "/home/hugo/Git/truecraft/TrueCraft.Profiling/TrueCraft.Profiling.csproj" (default target(s)):
			Target PrepareForBuild:
				Configuration: Debug Platform: AnyCPU
			Target GenerateSatelliteAssemblies:
			No input files were specified for target GenerateSatelliteAssemblies, skipping.
			Target GenerateTargetFrameworkMonikerAttribute:
			Skipping target "GenerateTargetFrameworkMonikerAttribute" because its outputs are up-to-date.
			Target CoreCompile:
			Skipping target "CoreCompile" because its outputs are up-to-date.
		Done building project "/home/hugo/Git/truecraft/TrueCraft.Profiling/TrueCraft.Profiling.csproj".
	Task "MSBuild" execution -- FAILED
	Done building target "Build" in project "/home/hugo/Git/truecraft/TrueCraft.sln".-- FAILED
Done building project "/home/hugo/Git/truecraft/TrueCraft.sln".-- FAILED

Build FAILED.
Errors:

/home/hugo/Git/truecraft/TrueCraft.sln (default targets) ->
(Build target) ->
/home/hugo/Git/truecraft/externals/fNbt/fNbt/fNbt.csproj (default targets) ->
/usr/lib/mono/4.5/Microsoft.CSharp.targets (CoreCompile target) ->

	CSC: error CS0518: The predefined type `System.Object' is not defined or imported
	CSC: error CS0518: The predefined type `System.ValueType' is not defined or imported
	CSC: error CS0518: The predefined type `System.Attribute' is not defined or imported
	CSC: error CS0518: The predefined type `System.Int32' is not defined or imported
	CSC: error CS0518: The predefined type `System.UInt32' is not defined or imported
	CSC: error CS0518: The predefined type `System.Int64' is not defined or imported
	CSC: error CS0518: The predefined type `System.UInt64' is not defined or imported
	CSC: error CS0518: The predefined type `System.Single' is not defined or imported
	CSC: error CS0518: The predefined type `System.Double' is not defined or imported
	CSC: error CS0518: The predefined type `System.Char' is not defined or imported
	CSC: error CS0518: The predefined type `System.Int16' is not defined or imported
	CSC: error CS0518: The predefined type `System.Decimal' is not defined or imported
	CSC: error CS0518: The predefined type `System.Boolean' is not defined or imported
	CSC: error CS0518: The predefined type `System.SByte' is not defined or imported
	CSC: error CS0518: The predefined type `System.Byte' is not defined or imported
	CSC: error CS0518: The predefined type `System.UInt16' is not defined or imported
	CSC: error CS0518: The predefined type `System.String' is not defined or imported
	CSC: error CS0518: The predefined type `System.Enum' is not defined or imported
	CSC: error CS0518: The predefined type `System.Delegate' is not defined or imported
	CSC: error CS0518: The predefined type `System.MulticastDelegate' is not defined or imported
	CSC: error CS0518: The predefined type `System.Void' is not defined or imported
	CSC: error CS0518: The predefined type `System.Array' is not defined or imported
	CSC: error CS0518: The predefined type `System.Type' is not defined or imported
	CSC: error CS0518: The predefined type `System.Collections.IEnumerator' is not defined or imported
	CSC: error CS0518: The predefined type `System.Collections.IEnumerable' is not defined or imported
	CSC: error CS0518: The predefined type `System.IDisposable' is not defined or imported
	CSC: error CS0518: The predefined type `System.IntPtr' is not defined or imported
	CSC: error CS0518: The predefined type `System.UIntPtr' is not defined or imported
	CSC: error CS0518: The predefined type `System.RuntimeFieldHandle' is not defined or imported
	CSC: error CS0518: The predefined type `System.RuntimeTypeHandle' is not defined or imported
	CSC: error CS0518: The predefined type `System.Exception' is not defined or imported

	 0 Warning(s)
	 31 Error(s)

Time Elapsed 00:00:00.6245190

That's ridiculous. I have no idea how that could happen. Your mono installation must be borked somehow.

Try re-referencing mscorlib.dll.

I've been getting this for various ports since moving up to F23's MonoDevelop version.
Double check the csproj XML, sometimes weird stuff like these lines like ProductVersion and SchemaVersion make a difference... in one case TargetFrameworkVersion mattered too, even when it shouldn't have.
The point is, if you compare the mcs build line to one that actually compiles (i.e. be sure that the runtime DLLs aren't in a ridiculous directory rather than /usr/lib/mono/4.5/) you should be able to pick out what's wrong and fix the csproj files accordingly.
(This is why my projects have Makefiles as alternatives... grumble)

Hey folks,
Try:
xbuild  /p:TargetFrameworkVersion="v4.5"


Footprint retention post a user is gone

Issue type
[X] Feature request
[X ] Bug report
[ ] Documentation
Environment

Python version: 3.5.2
NetBox version: 2.2.9

Description

Add a user in Netbox
Make some changes as the user
Delete the user
All the operations done by the user are gone along the way from "recent activity", and it is impossible to track them down in future.

What change are you proposing?

It would be nice if we could have all the activities archived in "recent activity" for both active and removed users.

Wrapping this into #1898.

Gr8, Thanks!


Add class with common code for scripting API unit tests

[x] This contribution adheres to CONTRIBUTING.md.

What does this Pull Request accomplish?
Move common code used by all scripting API unit tests into its own class.
Why should this Pull Request be merged?
I can't stand to see the same code for accessing the first target in a system definition copied into one more test case.
What testing has been done?
Modified the Routing and Faulting Scripting API unit tests to inherit from VeriStandScriptingTestCase and use the 2 protected VIs in setUp.vi and tearDown.vi. Used the accessor for Target and SystemDefinition instead of unbundling from the test class and ran all the tests. They all passed.

[ ] SetUpSystemDefinitionReferences.vi: There's an Open G VI that gets a reference to the parent of the calling VI, which can replace some of your call stack handling code. We use it elsewhere, so I'd prefer we just re-use it here:

[ ] (Optional) Do we expect SetUpSystemDefinitionReferences.vi to ever be wrapped by another VI in the testing tools repo? This path handling would break if it is. We've worked around this previously by including an optional terminal where a reference to the VI to use for path manipulation can be passed in; see AddConfigurationFiles.vi.

Why the Read accessor VIs? The unbundle is cleaner in the test VI. Unbundle is also familiar mechanism for getting public properties of the class without having to remember if/where there are specific accessor VIs? If we choose to keep Read accessors, should we should use them in VeriStandScriptingTestCase.lvclass:CloseSystemDefinitionReferences.vi.

Why the Read accessor VIs? The unbundle is cleaner in the test VI. Unbundle is also familiar mechanism for getting public properties of the class without having to remember if/where there are specific accessor VIs? If we choose to keep Read accessors, ~should~ we should use them in VeriStandScriptingTestCase.lvclass:CloseSystemDefinitionReferences.vi. If we want Read accessors, should we also provide Write accessors?

VeriStandScriptingTestCase is intended to be an abstract class from which the actual test cases inherit. You must still write the individual test cases utilizing the setUp and tearDown methods provided by the JKI Tester framework. What this provides is a common way to set up all the references that are needed and make the concrete tests require less work to create/maintain.
Class data is private, so you can't unbundle these items directly in the child class. This is why read accessors are required. We do not have write accessors because the child class should not need to change these references. I have never seen accessors used internal to the class, which is why I prefer the unbundle.


Cannot find module 'class-variance-authority/dist/types'

Describe the bug
I'm currently in the midst of migrating several internal applications to TypeScript's "moduleResolution": "bundler" setting. Within our organization, we maintain a crucial component library that's utilized across various applications. This library relies on the awesome cva package (thanks a lot for this 🙏 ). Unfortunately, we've encountered a type issue as we transition to the new bundler module resolution.
To Reproduce

Clone this minimal reproduction and run yarn build
Use an existing React TypeScript project (or create a new one) with "moduleResolution": "bundler" in tsconfig.json
Use yarn link (or similar) to create a symlink to the cloned repository
Insert the following code somewhere in the render tree of your application:

import { Button } from "cva-types-issue";
...
<Button>Test</Button>
...

If you type check (tsc) the project you will receive the following error:
../../cva-types-issue/dist/src/components/Button/Button.d.ts:6:12 - error TS2307: Cannot find module 'class-variance-authority/dist/types' or its corresponding type declarations.

} & import("class-variance-authority/dist/types").ClassProp) | undefined) => string;

Expected behavior
The cva build output should contain the correct type definitions/type exports to support "moduleResolution": "bundler".
Ideally, no change in userland should be required.
Additional context
Related issues:

https://github.com/joe-bell/cva/discussions/143
https://github.com/joe-bell/cva/issues/190

Related PR's:

Might be the reason this PR was created.

Hey @damianfrizzi! Appreciate the detailed write up 🙏
Please can you do me a huge favour and try using cva@beta instead? Do you still see the issue?
That'll help me determine next steps

Hey @joe-bell, I appreciate the speedy response! Just gave cva@beta a whirl, and everything seems to work 🎉. Thanks a bunch for your help!

Amazing! In that case I'll close this PR. Thanks again 🙏


Exceed 2GB limit for SQL queries

I have only made changes to the client side to achieve this. As it turns out the response has no limit in the amount of bytes. The limitation was due to the fact that we were saving the response in a byte[] array. I have made the changes to use an InputStream instead. After this change, there will be effectively no limit.

Nice change! It looks like you modified the auto-generated code? Is there a way we can automate this type of change?

It should be possible yes. As next steps I am planning to create a CI for this repo and then proceed to create an automated way to update based on the most recent spec. If I try to generate the repo from the spec now it will probably break. Thus, Ci is a priority.


Fixed Driver Macro compatibility for CPP

The macro DEVICE_DT_INST_DEFINE is not compatible with C++ source files.  This commit fixes the order initialization of macro Z_DEVICE_INIT and  declaration of Z_DEVICE_HANDLES_SECTION with extern keyword.
Signed-off-by: Victor Chavez<EMAIL_ADDRESS>

Hello @gmarull, I have checked the guidelines and decided to make a new pull request to accomodate the changes according to your suggestion. I have made a new commit with a more detailed explanation.
https://github.com/zephyrproject-rtos/zephyr/pull/54762

Hello @gmarull, I have checked the guidelines and decided to make a new pull request to accomodate the changes according to your suggestion. I have made a new commit with a more detailed explanation. #54762

PRs don't need to be closed, just force-push to the same branch.


test: add test for custom commands in CI

Description
This PR adds tests in CI for custom commands in CI

Thanks for the pull request, @Ian2012!  Please note that it may take us up to several weeks or months to complete a review and merge your PR.
Feel free to add as much of the following information to the ticket as you can:

supporting documentation
Open edX discussion forum threads
timeline information ("this must be merged by XX date", and why that is)
partner information ("this is a course on edx.org")
any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.
Please let us know once your PR is ready for our review and all tests are green.

@Ian2012 🎉 Your pull request was merged!  Please take a moment  to answer a two question survey so we can improve your experience in the future.


Added tests for svg2js behavior if passed in malformed svg

I don't know, actually what this test for. I've reworked some issues with errors and parsing errors now just show error instead of throwing (not released yet). However, error attribute is still being passed to callback.


Fixed Error on Shutdown

Application crashes on exit.

Fixed.

We need to test this with communication over different devices

Why is the test with different devices necessary? Do you expect different behaviour?
Why is the issue marked as bug?

Because currently, when the RTPListener receives an BYE-packet, it shuts down, but the recording/sending and playback on that program still runs. So we either need to shut the other program down completely or at least make sure, it doesn't throw any errors.
You marked it as bug:)

I havn't tested it with two computers, but the behavior I expect needs attention.
Computer 1                 | Computer2
audioObject.started     | audioObject.started
rtpListener.started       | rtpListener.started
Computer2 shuts down:
Computer 1                 | Computer2
audioObject.started     | audioObject.stopped
rtpListener.stopped     | rtpListener.stopped
On Computer1 the audioObject is still running, while its rtpListener has stopped because of the RTCP-Bye-Package.

A possible solution would be to enable communication between audioObject (RTAudioThread) and RTPListener (own Thread).


Tab title not appear

There is some bug, the title of tab not appear when we create FragmentStatePagerItemAdapter in fragment after get data from server (API response).

Hi, @encryptgo
Please show me the code the problem occurs.

Hi, @ogaclejapan this is the code in my fragment
FragmentPagerItemAdapter adapter = new FragmentPagerItemAdapter(
getChildFragmentManager(), FragmentPagerItems.with(getActivity())
.add("Tab 1", Tab1Fragment.class)
.add("Tab 2", Tab2Fragment.class)
.create());
viewpager.setAdapter(adapter);
viewPagerTab.setViewPager(viewpager);
The code above running with no problems if i put in onActivityCreated method. but get some problem (The tab title not showing ex : Tab 1) in some conditions.

when i put it after data request finish from server (ex : onSuccess Method in retrofit).
when go to new activity with fragment transaction in it.
ex : ActivityA -> call -> ActivityB where in onCreate method of ActivityB there is a fragment transaction. and in fragment i create the FragmentPagerItemAdapter like code above.

Hi, @encryptgo
Is this what you mean?

1 when i put it after data request finish from server

void onActivityCreated(...) {

  somethingAsyncRequest.call(new Callback() {

    @Override
    void onSuccess(...) {

      FragmentPagerItemAdapter adapter = new FragmentPagerItemAdapter(
      getChildFragmentManager(), FragmentPagerItems.with(getActivity())
      .add("Tab 1", Tab1Fragment.class)
      .add("Tab 2", Tab2Fragment.class)
      .create());
      viewpager.setAdapter(adapter);
      viewPagerTab.setViewPager(viewpager);

    }

  });

}

2 when go to new activity with fragment transaction in it.

class ActivityA {

  void onClickSomething() {
    ActivityB.startActivity(this);
  }

}

class ActivityB {

  void onCreate(...) {
      getSupportFragmentManager().beginTransaction()
          .add(android.R.id.content, new FragmentB())
          .commit();
  }

}

class FragmentB {

  void onCreateView(...) {

    ...

    FragmentPagerItemAdapter adapter = new FragmentPagerItemAdapter(
    getChildFragmentManager(), FragmentPagerItems.with(getActivity())
      .add("Tab 1", Tab1Fragment.class)
      .add("Tab 2", Tab2Fragment.class)
      .create());
    viewpager.setAdapter(adapter);
    viewPagerTab.setViewPager(viewpager);

    ...

    return root;

  }

}

Yes that's right! but, i have solved that case with give the delay when fragment commit.

Hi, @encryptgo
Did you have a problem in this library?
I want to share how to resolve the problem.

@ogaclejapan
Please let me know how do you resolve it.

Sorry, It was wrong English
I want to know your solutions.
It means that.

I just put out FragmentPagerItemAdapter from onSuccess method and create as normal and inject the data from server later.
I just give delay in fragment transaction
Handler handler = new Handler();
handler.posDelayed(....{
// fragment transaction here
}, 300);


Make XML generation locale-independent

The %f specifier for String.format depends on the current locale.
Since SVG paths always use a point as the decimal separator, this
code must not depend on the current locale.
Fixes #26

Looks good 👍


A question about visual debugging

Hi,
I have have a question about visual debugging
It is an error when i click GameObject named Systems
InvalidOperationException: Operation is not valid due to the current state of the object
System.Collections.Generic.Stack`1[System.Boolean].Pop ()
UnityEditor.EditorGUI.EndDisabledGroup () (at C:/buildslave/unity/build/Editor/Mono/EditorGUI.cs:211)
Entitas.VisualDebugging.Unity.Editor.DebugSystemsInspector.drawSystemInfos (Entitas.VisualDebugging.Unity.DebugSystems systems, SystemInterfaceFlags type)
Entitas.VisualDebugging.Unity.Editor.DebugSystemsInspector.drawSystemInfos (Entitas.VisualDebugging.Unity.DebugSystems systems, SystemInterfaceFlags type)
Entitas.VisualDebugging.Unity.Editor.DebugSystemsInspector.drawSystemList (Entitas.VisualDebugging.Unity.DebugSystems systems)
Entitas.VisualDebugging.Unity.Editor.DebugSystemsInspector.OnInspectorGUI ()
UnityEditor.InspectorWindow.DrawEditor (UnityEditor.Editor editor, Int32 editorIndex, Boolean rebuildOptimizedGUIBlock, System.Boolean& showImportedObjectBarNext, UnityEngine.Rect& importedObjectBarRect) (at C:/buildslave/unity/build/Editor/Mono/Inspector/InspectorWindow.cs:1231)
UnityEditor.DockArea:OnGUI()
InvalidOperationException: Operation is not valid due to the current state of the object
System.Collections.Generic.Stack`1[System.Boolean].Pop ()
UnityEditor.EditorGUI.EndDisabledGroup () (at C:/buildslave/unity/build/Editor/Mono/EditorGUI.cs:211)
UnityEditor.InspectorWindow.DrawEditor (UnityEditor.Editor editor, Int32 editorIndex, Boolean rebuildOptimizedGUIBlock, System.Boolean& showImportedObjectBarNext, UnityEngine.Rect& importedObjectBarRect) (at C:/buildslave/unity/build/Editor/Mono/Inspector/InspectorWindow.cs:1254)
UnityEditor.InspectorWindow.DrawEditors (UnityEditor.Editor[] editors) (at C:/buildslave/unity/build/Editor/Mono/Inspector/InspectorWindow.cs:1028)
UnityEditor.InspectorWindow.OnGUI () (at C:/buildslave/unity/build/Editor/Mono/Inspector/InspectorWindow.cs:352)
System.Reflection.MonoMethod.Invoke (System.Object obj, BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) (at /Users/builduser/buildslave/mono/build/mcs/class/corlib/System.Reflection/MonoMethod.cs:222)
Here's some code
How can I resolve this problem ?
thank you!

If it's relevant, I've seen this error preceded by another error:
Visual debugging sometimes crashes when switching windows.
Steps:

Mac laptop.

Play in editor.

Switch window away from Unity.

Edit an asset file.

Switch back to Unity.

Sometimes an error appears:
 NullReferenceException: Object reference not set to an instance of an object
 Entitas.VisualDebugging.Unity.ContextObserverBehaviour.OnDestroy () (at <7a3e32b56db949119387854a500d7000>:0)

After this, I might also see a GUI sort of like the one above, but I seem to recall the stack trace was different.

I haven't got any feedback so far, so I assume the issue is resolved? Feel free to re-open otherwise.


go-swagger error

go-swagger3: command not found
After installation via go get and execution of  go-swagger3 --module-path . --main-file-path ./cmd/main/main.go --output oas.json

Hey @elkarto91 , You will have to install the module first.
Please install the following command to install the go module.
go get -u github.com/parvez3019/go-swagger3


chore: bump version to v0.8.3

Update the package version and changelog for the 0.8.3 - 2024-05-08
release.
0.8.3 - 2024-05-08
Added

add support for region comments (526)
Bump Slang to 0.14.2 (565)

@SocketSecurity ignore<EMAIL_ADDRESS>


sigsegv crash

no core dump but in
Stack: [0x00007ff8384fc000,0x00007ff8385fd000],  sp=0x00007ff8385fb840,  free space=1022k
Native frames: (J=compiled Java code, j=interpreted, Vv=VM code, C=native code)
V  [libjvm.so+0x82e284]  Method::checked_resolve_jmethod_id(_jmethodID*)+0x34
V  [libjvm.so+0x6cc126]  jvmti_GetMethodName+0x1f6
C  [liblagent.so+0x8523]  Profiler::lookupFrameInformation(JVMPI_CallFrame const&, _jvmtiEnv*, MethodListener&)+0x43
C  [liblagent.so+0xb0ba]  LogWriter::record(JVMPI_CallTrace const&)+0x6a
C  [liblagent.so+0xa90a]  CircularQueue::pop()+0x2a
C  [liblagent.so+0xa959]  Processor::run()+0x19
V  [libjvm.so+0x736402]  JvmtiAgentThread::call_start_function()+0xc2
V  [libjvm.so+0x9e303f]  JavaThread::thread_main_inner()+0xdf
V  [libjvm.so+0x9e3205]  JavaThread::run()+0x1b5
V  [libjvm.so+0x8a00c8]  java_start(Thread*)+0x108

Could  #76 be related?

Given the lack of versioning this is a bit of difficult bug to match with repository state. Can one of the reporters reproduce the issue with a recent build and report back with the 'version' they used (i.e. the repository last commit checksum)?

@nitsanw there have been some more jvm fixes since my initial crash report (based on searching for checked_resolve_jmethod_id crashes) and @RichardWarburton 's review of related jvm bugs in 2014.
https://bugs.openjdk.java.net/browse/JDK-8147451
https://bugs.openjdk.java.net/browse/JDK-8149743
https://bugs.openjdk.java.net/browse/JDK-8152079
The comments seem to point in the direction of a high enough volume of classes and methods to provoke method unloading (which would have been the case with my workload I think being scala) triggering bugs in method lookup in the jvm. At least that would be one avenue to investigate a reproducer program that provokes method unloading to profile on different jdks (pre/post fixes).


Not able to download the weights

@MagicChuyi Thaks a lot for the great work, also the documentation is really helpful.
Unfortunately, I wasn't able to download the weights, is it possible to share those files through Google Drive/OneDrive?

You can check this repo, https://github.com/vaib-saxena/Slow-Fast-pytorch-implementation. I made some changes to this repo and it works fine.


[Feature][MLops] Support MLflow Models to deploy model service (MLflow models serve and Docker)

Purpose of the pull request
Update MLflow task plugin to enable Dolphin users to schedule MLflow.
This PR relates to https://github.com/apache/dolphinscheduler/issues/10149.
Because I want to continue enriching the capabilities of this plugin, leave the issue open for now.

[x] MLFLOW: Use MLflow models serve to deploy a model service
[x] Docker: Run the container after packaging the docker image

Brief change log

Add MLflow Models component
Update Doc
The MLFlow plugin code has been reworked to expand more functionality

Verify this pull request

This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:

Codecov Report

Merging #10150 (5258f2e) into dev (bf4b8ff) will increase coverage by 0.09%.
The diff coverage is 83.58%.

@@             Coverage Diff              @@
##                dev   #10150      +/-   ##
============================================
+ Coverage     40.83%   40.93%   +0.09%
- Complexity     4714     4729      +15
============================================
  Files           854      854
  Lines         34503    34552      +49
  Branches       3814     3818       +4
============================================
+ Hits          14090    14143      +53
+ Misses        19061    19056       -5
- Partials       1352     1353       +1

Impacted Files
Coverage Δ

...nscheduler/plugin/task/mlflow/MlflowConstants.java
0.00% <ø> (ø)

...scheduler/plugin/task/mlflow/MlflowParameters.java
63.09% <81.81%> (+9.47%)
:arrow_up:

...olphinscheduler/plugin/task/mlflow/MlflowTask.java
66.17% <84.44%> (+42.64%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf4b8ff...5258f2e. Read the comment docs.

PTAL @zhongjiajie @songjianet @labbomb , thanks

LGTM

LGTM

Thank you for your code review.


video broadcasting

can we use this server and flutter for video broadcasting? Has anyone done it?

This server is only used to demonstrate the use of flutter-webrtc to establish peer-to-peer video calls, video broadcasting requires SFU, you can take a look at https://livekit.io, https://mediasoup.org


Unable to run with own dataset

Hello,
I have a folder with *.ply files with the timestamps as filenames. These ply files have been generated from Ouster LiDAR. I am finding it difficult to run this package with my dataset even though I have changed a few things in the default config file like the root folder and the dataset option. I have set the dataset option to PLY_DIRECTORY .
I get a error which says:
terminate called after throwing an instance of 'std::runtime_error'
  what():  PLY Directory is not supported by read_pointcloud. See the DirectoryIterator.
Aborted (core dumped)

I'll appreciate help in fixing this issue.

Hi, following my answer to Issue #29,
I'll improve the API for the Dataset in order to define your own datasets.

Hi,
I committed a new version of the code, which should simplify your problem,
You should be able to run the code from the PLY directory,
If your schema is the different from the one we expect (vertex [x, y, z, timestamp / t]), there will be a bit of work to specify the schema of the point cloud (ie how to read the different properties from the point cloud)
Don't hesitate to let me know If you still have some problem.

Hello,
Write now Im using ouster LiDAR and i don't know how to lunch ct-icpon my Ouster pcap. I would like to understand how to do this.
Thank you;
Cordially.


inferred parametric types are not checked by the compiler

This compiles on the online playground, and tsc version 1.3.0 as well:
function foo():()=>Bar<string> {
    return ()=>{ return new Bar<number>(); };
}

update: a more simple example which should fail at compile time as well:
function foo():Bar<string> {
	return  new Bar<number>();
}

http://www.typescriptlang.org/Playground#src=class Bar<A>
{
}

function foo()%3A()%3D>Bar<string> {
	return ()%3D>{ return new Bar<number>()%3B }%3B
}%0A%0A

This is by design and an effect of TypeScript's structural type system. See #468.
In your example you declare the Bar as an empty class that never references its type parameter:
class Bar<T> { }

When a type parameter is never referenced, it doesn't matter what type you pass as a type argument--all generic instantiations of the class are structurally equivalent. If you change your declaration to
class Bar<T> {
    x: T;
}

the instantiations now differ by structure and you will see the expected errors.

and this is true for arrays as well,
function foo():Array<string> {
	var arr = [];
	arr.push(5);
	return  arr;
}

is there a best practice, apart from being explicit when instantiating a variable?

The array example is different. The type of arr is inferred as any[] because there is no type annotation on the declaration and  no elements in the array literal from which to infer an element type. And since an any[] is assignment compatible with any array type, including string[], there is no error.
If you compile with the -noImplicitAny flag (which disallows inferences of type any, requiring explicit type annotations in those cases) you will get an error on the declaration of arr because any[] was implicitly inferred.
The best way to write this particular example would be:
function foo() {
    var arr: string[] = [];
    arr.push(5);  // Error here
    return arr;
}

With or without -noImplicitAny this will give you an error.

Thanks.


Cleanup orphaned deploy items

How to categorize this PR?

/area quality
/kind bug
/priority 3
What this PR does / why we need it:
This pull request fixes the deletion of orhaned deploy items.
Suppose an installation has several deploy items. You apply an update of the installation, that removes some of the deploy items. Then the new reconcile algorithm has not triggered the deletion of the removed deploy items. Moreover, the status of the execution was not adjusted (fields DeployItemReferences and ExecutionGenerations.)
This is fixed in this PR.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note:

NONE

/test

/test


Revert "Return empty string from grabLog()"

Reverts vespa-engine/vespa#5552
Broke integration tests

@aressem FYI, would like to merge since it unbreaks integration tests

Go ahead. PRs that fixes test and builds are welcome.


test: add transform tests to v-once tests

refactor vOnce.spec.ts to use compileWithOnce

OK, I have added more tests.


what is the "annotation_dir" filed points to?

I found that there is a “annotation_dir” field in "lane_association.yaml" and "lane_mapping.yaml", which points to some data.
Is the data provided in the link [OneDrive][Baidu Cloud]? or do I need to generate it by some other method?
This field does not seem to be required to be modified in the readme, please check.

It contains extrisic parameters and lane marking labels of the original dataset Openlane. It's necessary to run the code and evaluate the method. Sorry for suggesting you not to download Openlane dataset. I have modified the readme.


Sequence conservation model described in the paper

Hi @mheinzinger, How do I get access to this 'Supervised learning: per-residue conservation' model described in the paper using ConSurf10k.

Hi; I did not upload the checkpoint for this specific model yet but can do if needed. I mostly trained it to get a more diverse perspective on the information accessible from the embeddings.
If you are really interested in conservation prediction, I would simply recommend using the following: https://github.com/Rostlab/VESPA?tab=readme-ov-file#step-2-conservation-prediction
This is conservation prediction based on our ProtT5 model (which performs better than ProstT5 for this task) which we have been successfully been using for SAV effect prediction.

Thanks. Let me try the tool you provided and see if it works.


bug: border radius not set on elements that have no p- class

Noticed the following bug where border-radius is not set when the overlying tag does not include p-0.
https://user-images.githubusercontent.com/2837147/201170671-50227281-e210-4f19-8ee8-e9ec4ee5c1ac.mov
Seems like this is the culprit:

On a sidenote: Does daisyui use visual testing ?

I will check the padding issue and I will update this issue.
About visual testing, there are no tests to compare each component based on their pixel measurements because that's unpractical in my opinion. Each component's visual representation depends on the theme, fonts and other factors but there is an accessibility test to make sure each color combination on each theme meets a required contrast value.

Fixed in latest version.
Menu Items will lose border radius when they have no padding or 0 padding (p-0).
here's and example: https://play.tailwindcss.com/2nJyj7OqfS

First off, thanks for the super quick response @saadeghi !
I think there's some misunderstanding however regarding the expected behaviour, and therefore I'd like to reopen this issue.
In my opinion, --rounded-btn should be applied independently of whether a p- class is present on the (preceding) element or not, so that it is self-dependent. For example, there are situations where you might have padding applied not on the menu itself but on an overarching element.
Also, in the new version, if you switch themes in the docs, none of the menu items have a rounded border applied anymore, whereas previously, depending on the theme's --rounded-btn setting, the menu item had roundings aligned with the btn class. Now, for all themes all menu items are 0px radius - which seems odd. I guess it also boils down whether you consider the menu's a links to be considered 'buttons'. In my opinion it would make sense, since a normal a link can also have a btn class.
What do you think?
Regarding the testing: It's great that accessibility is a priority and has proper tests! Yet, I think visual regression testing would also be highly useful and I shall add a new proposal for it.

I don't think the padding of list and the border radius of the list item should be independent from each other. That might sound a weird statement but here's the reason:

If our list has padding a list item with no border radius that wouldn't look good and wouldn't match the design language because it would be a sharp rectangle inside another:

If the list has 0 padding but the list item has border radius, the list item will be rectangle with border radius sticked to the border of list. That would not look good either:

So instead of putting everything on the shoulders of the developer, there's a style that detects if the list has padding or not and applies border radius for the list item only if there's no padding. That would make the menu look better and in sync with the overall design language.
As you can see, there are also specific rules about the first and last items and it gives them border radius and start and end if there's border radius for the list.
Also, each built-in daisyUI theme can have its own value for --rounded-btn so each theme can have a different look and feel. For example, --rounded-btn is rounder in valentine theme and it has no radius for black theme. So, as expected when we use black theme there would be no border radius at all.

I can understand your reasoning and I much appreciate the effort to reduce cognitive load.
I'm aware that --rounded-btn is settable per theme, yet you should be aware that the guide's side menu items now - no matter the theme - have all no radius. Previously, themes like "cupcake" which, uses rounded border for buttons, had the same rounding in the menu items, which made it feel much more in "sync" with the overall theme. Anyone using DaisyUI themes will also experience having their drawer / menu items 0px radius transformed. Maybe we need to add an exception here somewhere. I don't think it is what you intended.

I can understand your reasoning and I much appreciate the effort to reduce cognitive load.
I'm aware that --rounded-btn is settable per theme, yet you should be aware that the guide's side menu items now - no matter the theme - have all no radius. Previously, themes like "cupcake" which, uses rounded border for buttons, had the same rounding in the menu items, which made it feel much more in "sync" with the overall theme. Anyone using DaisyUI themes will also experience having their drawer / menu items 0px radius transformed. Maybe we need to add an exception here somewhere. I don't think it is what you intended.

I agree with your behaviour for the automated menu li rounding.
The only thing I wanted to note is that, in a full-page menu within a drawer, like the guide previously had rounded li items for themes with --rounded-btn > 0 whereas now all li items are the same, no matter the theme. Personally, I think the previous appearance was more in line for a global theme style.
Therefore I wondered, if it isn't better, at least for menus in drawers, to keep the rounding for menu items.

Yes you're right. The sidebar menu is fixed now.


Issue #34 Add unit and instrumentation tests to github action

Description
Ensure that unit tests and instrumentation tests are run as part of the PR
Fixes #34
Check list

[x] I do not need to update CHANGELOG.md.
[x] I do not need to update the documentation.

@CherryPerry I think it would be wise to still have the instrumentation tests in a separate job. The recommendation is to use a macOS machine (due to HAXM) for Android tests.
You only get one macOS agent per project (unless you pay for it), so it would prevent us from running multiple PRs in parallel

There is no easy way to reuse a cache between different jobs (the main job on Linux and UI tests job on macOS), so let's keep a separate job for android tests. Use connectedTest without module specification. The issue with compilation of unnecessary modules can be solved with custom Gradle config, I can implement it in the future if the current state will become a problem.

@CherryPerry done :)


Support discard uploaded file or loaded text function

Support discard uploaded file or loaded text function
discard_config: delete config from the remote or just flush the candidate temp. text.

@samerd please review


Deploy using flask

Trying to deploy on an ubuntu server, receiving this error
Unsupported mimetype: application/vnd.openxmlformats-officedocument.wordprocessingml.document

Hello, Thank for you feedback.
Can you give more information about the code you use that return you this issue and the type of file you are testing ?
Currently, the only builder in preview_generator able to handle application/vnd.openxmlformats-officedocument.wordprocessingml.document aka '.docx' is libreoffice based.
To support those type of file, you need to install it.

I have installed libreoffice and it’s working on localhost. When I setup a uwsgi server on Nginx and check the service status I get the unsupported mimtype error.

@anujchhabria1 did you fixed this issue on server? I am having same issue for Django.

@AtulCIS @anujchhabria1 what is the extension of the file on the disk?
Could you copy/paste log output of your uwsgi server (with errors)?

Hi @lebouquetin
This is my issue link which has all the details. I want to convert .docx file to .pdf.
https://github.com/algoo/preview-generator/issues/156

I'm having the identical issue as @AtulCIS. I was not able to find a solution for this. Any ideas @lebouquetin ?

Hi @anujchhabria1. If you have created service for your flask please remove path variable from it.

thanks @AtulCIS let me check this


stig: fix build

Motivation for this change
Fix build.
Things done

[X] Disabling failing test.
[X] Upstream issue: https://github.com/rndusr/stig/issues/214

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[X] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 147806 run on x86_64-linux 1

1 package built:

stig


Misc: Normal stand animation pos

Found a leg sprite in one of the animation sheets that would work and resolved this! closing


Keep throwing error

When the page is rerendered, this error is thrown:
Uncaught TypeError: store.completion is not a function

I have fixed this issue by calling the createMathjaxPlugin() on every render.

I have fixed this issue by calling the createMathjaxPlugin() on every render. Place this in the componentWillMount() or componentDidMount() in react component.

Could you please share a code example for what you've done. I am not able to get plugins to work of the const plugins[] is declared inside the function/class. So if the the plugins[] needs to   be outside the component, how can I createMathjaxPlugin onComponent Mount?

Hi there, I found the solution @gigincg m
You may get that error while use use two Editor with this plugin. Just create a plugin wrapper and then put the createMathjaxPlugin function in component'state. If you are using React-Hook, the code may look like this:
import React,{useState} from 'react'; export default function RichEditor(props) {     const {editorState, onChange} = props;     const [plugins, setPlugins] = useState([createMathjaxPlugin()]); ....  return (<Editor                 //...your other Props                     plugins={plugins}                 />)

@lehoangnam97 Thanks for sharing your solution! It worked like a charm. Previously i cloned the project and removed store completion to make it work. Which obviously want the best way to go.

Hi there, I found the solution @gigincg m
You may get that error while use use two Editor with this plugin. Just create a plugin wrapper and then put the createMathjaxPlugin function in component'state. If you are using React-Hook, the code may look like this:
import React,{useState} from 'react';
export default function RichEditor(props) {
    const {editorState, onChange} = props;
    const [plugins, setPlugins] = useState([createMathjaxPlugin()]);
....
 return (<Editor
                //...your other Props
                    plugins={plugins}
                />)

No such luck here :T

@lsmenicucci Hey Lucas,
I'm using this solution in a page with almost n number of editors. You're probably making a mistake somewhere. Putting the plugins in state definitely works.

Hi there, I found the solution @gigincg m
You may get that error while use use two Editor with this plugin. Just create a plugin wrapper and then put the createMathjaxPlugin function in component'state. If you are using React-Hook, the code may look like this:
import React,{useState} from 'react';
export default function RichEditor(props) {
    const {editorState, onChange} = props;
    const [plugins, setPlugins] = useState([createMathjaxPlugin()]);
....
 return (<Editor
                //...your other Props
                    plugins={plugins}
                />)

No such luck here :T

I can`t neither, but class component works for me, you can try that

Hi there, I found the solution @gigincg m
You may get that error while use use two Editor with this plugin. Just create a plugin wrapper and then put the createMathjaxPlugin function in component'state. If you are using React-Hook, the code may look like this:
import React,{useState} from 'react';
export default function RichEditor(props) {
    const {editorState, onChange} = props;
    const [plugins, setPlugins] = useState([createMathjaxPlugin()]);
....
 return (<Editor
                //...your other Props
                    plugins={plugins}
                />)

No such luck here :T

oops, my bad, just found out a bug that will cause the editor not rendered properly, which makes the mathjaxplugin unhappy


Implemented #872: add manufacturer URL

Added manufacture url to product entity
Implemented correct displaying of manufacture url (looks like link)
Implemented opening of url

issue: #872

It can be tested with the Big Mac


Add MS Docs content to reference documents.

Add the content of the Getting Started guides in MS Docs to Getting Started in the reference documentation.

Closing this issue in favor of https://github.com/Azure/azure-sdk-for-java/issues/27570


Enhancement: Be able to specify which version of CLI for Microsoft 365 you want to use

Right now doctor makes use of the local version installed in the tool itself. For testing out new versions, it would be great to be able to specify the actual command to execute. This way, you have the ability to override the localm365 version to the globally installed version on your machine.

Version 1.6.0 is released with this issue included.


[bluetooth]: [api]: Fixes issue#45968 struct bt_ots_init to struct bt_ots_init_param

Patch to rename struct bt_ots_init to struct bt_ots_init_param
fixes #45968

Could you fix the commit message prefix to be consistent with all other Bluetooth commit messages? Something like Bluetooth: OTS: Fix bt_ots_init parameter struct naming should be Ok.

Okay. Will work on it

Added the required changes @Thalley @jhedberg


Match appliance Ruby version on Travis, add 2.4.2

This sets the required Travis build to Ruby 2.3.1 to reflect the Ruby version actually shipped on ManageIQ appliances. It also adds the newest version of Ruby that developers of ManageIQ can use as an optional build so the platform team can keep an eye on future regressions.
Closes https://github.com/ManageIQ/manageiq/issues/14446

Checked commits<EMAIL_ADDRESS>with ruby 2.3.1, rubocop 0.47.1, and haml-lint 0.20.0

😍


[PLATOPS-1061] upgrading to the new bootstrap-play-25 library

Full DI to be implemented first and a new PR to be raised


Legend in Pie Chart

It is possible to remove legend in Pie Chart?

I don't think it is right now, but it should be an easy PR

I also needed to hide it while using the pie chart. I did it by disabling the code in library pie-chart.js

You can now use hasLegend={false} to do that

hasLegend={false} doesn't re-center the pie-chart, so now it looks silly and lopsided. I can hack it with margin but it's not really crossplatform as I won't know by how many pixels exactly to translate it without knowing the width of the circle itself in pixels

hasLegend={false} doesn't re-center the pie-chart, so now it looks silly and lopsided for me. I can hack it with margin but it's not really crossplatform / crossphonemodel as I won't know by how many pixels exactly to translate it

what is the right way to center a the pie chart with no legend?

Is not the way, but almost do it:
                    width={width}                     paddingLeft={Data.width / 4}                     hasLegend={false}


Rename the az_failed helper method for az_result to az_result_failed and remove az_succeeded.

Semantically, one is just a negation of the other.
https://github.com/Azure/azure-sdk-for-c/blob/9ce11465d167e512e1abdaa912bc0e5c5dec3346/sdk/inc/azure/core/az_result.h#L139-L156
Most of the coding patterns I have seen is:
if (az_failed(...))
{
   // log, early return, etc.
}
// Continue with expected success path and logic.

OR
AZ_RETURN_IF_FAILED(...);
// Continue with expected success path and logic.

From @JeffreyRichter

If we decide to keep one, I'd keep az_failed. az_suceess should return true if the code is >=0.  The idea is that the function is returning a reason for success. But the caller may only care that the function was successful and not care WHY it was successful.

We should leave both.  Developers often times prefer to NOT use the if(!(AZ_FAILED(...)){} pattern.  Code readability its cleaner and clearer to read `if(AZ_SUCEEDED(...)){}

I have seen folks use !az_succeeded in a few places. I don't necessarily buy the argument that developers prefer one over the other.
For example:
https://github.com/azure-rtos/azure-iot-preview/blob/d0343b59943d096da40feafec80ea7958e7dd8cf/samples/sample_pnp_temperature_controller/sample_pnp_thermostat_component.c#L62-L64
If we didn't have az_succeeded, the developer would have more cleanly written az_failed(...) instead. This goes back to the point that giving the user an extra choice/decision to make can be counter-productive here.
Since one is a negation of the other, users can always flip the condition not use the ! if they really wanted to. Also, there is nothing stopping them from creating their own az_succeeded(...) method that is !az_failed(...), but like I said, it introduces two ways to do the same thing which introduces brittleness in the customers code, making it harder to maintain and update, and to review for correctness.
if (!az_failed(...))
{
  // success path
}
else
{
  // fail path
}

Versus flipped:
if (az_failed(...))
{
  // fail path
}
else
{
  // success path
}

The overwhelmingly common pattern I have seen, at least in our code base and sample, is using the fail to do an early break and return or exit either via the az_failed method directly or the AZ_RETURN_IF_FAILED macro.
Use of az_failed:
src - 7
samples - 119
docs - 3
inc - 3
Ue of az_succeeded:
src - 11
samples - 14
docs - 3
inc - 2
Use of AZ_RETURN_IF_FAILED:
src - 14
samples - 156
docs - 0
inc - 1
I found no usages of !az_failed(...) and one use of !az_succeeded(...):
https://github.com/Azure/azure-sdk-for-c/blob/bc577de6d8a601f845e3b695dca26e5f88ee1f8c/sdk/src/azure/core/az_json_writer.c#L82-L85
Let me see what some of the coding patterns and samples look like without using az_succeeded and get back to you. I would be surprised if it looks less clean/readable or becomes too cumbersome, but if that's the case, I will leave them as is.

This issue has a rename of a public method and hence can't be in the backlog. Moving back to september.


Blank screen

Describe the bug
A clear and concise description of what the bug is.
after days of normal use, blank screen ...
Ubuntu 20.04 / tusk 0.23 (snap)

after the first installation I got the same problem with Mint 20.1 / tusk 0.23 snap

Please look at issue #308
You will find workarounds there :)
The official solution probably will arrive on the next release.
@metrorede @mauribertolini

thank you :-)
Maurizio Bertolini
mob: +393929016870
skype: mauribertolini
On Sat, 13 Feb 2021 at 15:20, Allan Freitas<EMAIL_ADDRESS>wrote:

Please look at issue #308 https://github.com/klaussinani/tusk/issues/308
You will find workarounds there :)
The official solution probably will arrive on the next release.
@metrorede https://github.com/metrorede @mauribertolini
https://github.com/mauribertolini
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/klaussinani/tusk/issues/321#issuecomment-778626096,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AS2UC6BWZCGOGLIXX4F75A3S62DD7ANCNFSM4XRHRCQA
.


Open other apps

As a NetworkBook user, I wish to be able to open the relevant social media platform from the NetworkBook app so that I can quickly contact them on social media.
As a NetworkBook user, I wish to be able to open my email app from my NetworkBook app, so that I can quickly send an email when needed.


OR filter fails with variables

Followup issue of: #1335
Describe the bug
If an OR filter is applied and a variable is inside the filters fail.
I am not sure if this is invalid and i didn't get this of the spec or if it is related to #192
After the argument is resolver with context.Argument<IValueNode>("argname") the variables in a object in a list are not replaced.
Working example with object:

Not working example with Array OR:[]:

If the variables are not resolved the operation handlers do not recognize the type because in this example Variable == String
https://github.com/ChilliCream/hotchocolate/blob/master/src/Core/Types.Filters/Expressions/OperationHandlers/String/StringOperationHandlerBase.cs#L20
This leads to an empty queue and therefore
Queue empty.
   at System.Collections.Generic.Queue`1.ThrowForEmptyQueue()
   at System.Collections.Generic.Queue`1.Peek()
   at HotChocolate.Types.Filters.QueryableFilterVisitor.CreateFilter[TSource]()
   at HotChocolate.Types.Filters.QueryableFilterMiddleware`1.InvokeAsync(IMiddlewareContext context)
   at HotChocolate.Execution.ExecutionStrategyBase.ExecuteMiddlewareAsync(ResolverContext resolverContext, IErrorHandler errorHandler)

To Reproduce
Executes the tests QueryableFilterTests.Execute_String_Filter_WithVariable_OR in this pull request: #1353
Expected behavior
A clear and concise description of what you expected to happen.
Desktop (please complete the following information):

OS: Windows 10
Version Master

Additional context
Thanks to @NickBeukema and @freever for reporting it

FYI this also applies to AND

Can you guys recheck with 10.3.3

I tried with 10.3.3 with the following query and still getting the Queue Empty error:
contactGetAll (where: { OR: [{ lastName_contains: $searchTerm }, { firstName_contains: $searchTerm }] }) {
    customer {
        name
    }
}

@PascalSenn has written some tests on the V11 branch ... so I hopefully get my PR tomorrow in. With that I can check what the issue still is.
It might now be something different since I have variables in lists that have objects now under test. There were was an issue the query rewriter regarding this.

@michaelstaib My case is working with 10.3.3:
query searchPatents($searchText: String!) {     patents(order_by: {applicationNumber: ASC, patentNumber: ASC, publicationNumber: ASC} where: {OR: [{applicationNumber: $searchText} {patentNumber: $searchText} {publicationNumber: $searchText}]}) {totalCount} }


Frequent errors sayings "Error while reading line from the server."

When migrate php from 5.6.40 to 7.4.7, php-fpm got connect lost frequently, especially in use pipeline command.
But with php 5.6.40, this happen less.
Versions:

Predis: 1.1.3
PHP 7.4.7
Redis Server 2.8.24
Ubuntu 18.04

Predis settings
timeout: 0.5
read_write_timeout: 1
persistent: true
redis use Amazon ElastiCache standalone mode

@tanqinwang Were you able to solve this? I'm experiencing something similar

updated the redis to 6.x version


remove encoder_sequence_length in seq2seq config so users can pass it

Hi, @fxmarty @echarlaix . The param of encoder_sequence_length does not need to be specified here. First, the parameter will be set to sequence_length if it is None, see DummySeq2SeqPastKeyValuesGenerator. Second, users can specify the encoder_sequence_length by themselves if we remove this code. Would you please help to review it? Thanks!

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

Hi @jiqing-feng , thank you for the PR. I'm not sure to understand what's the benefit of this. No matter the encoder_sequence_length passed, the controlflow captured should be the same by the PyTorch ONNX export, is that not?

Hi @jiqing-feng , thank you for the PR. I'm not sure to understand what's the benefit of this. No matter the encoder_sequence_length passed, the controlflow captured should be the same by the PyTorch ONNX export, is that not?
Moreover, I believe the encoder_outputs.last_hidden_states and the past key values length for cross-attention should be the same. Thus I believe it is better to hard code the cross-attention pkv length.

Hi @fxmarty , thanks for your comment. I notice that the DummySeq2SeqPastKeyValuesGenerator works for encoder-decoder models. The past_key_values is only the input of the decoder, so I think the encoder_sequence_length depends on the output of the encoder. If I just want to get the decoder inputs, the param of encoder_sequence_length would be better to manipulate by myself and it should be the same as the input sequence length. The decoder_sequence_length is always 1 for the decoder if we set use_cache=True in generation tasks because generation only uses the last token and the previous past_key_values. So for the decoder model, the encoder_sequence_length and the decoder_sequence_length could be different. I'm not sure I'm making it clear and would appreciate your advice. Thanks!

Hi @fxmarty thanks for your clarification. However, the encoder_outputs length should be the same as input_ids length, but in the function I see that both the length of input_ids and decoder_input_ids are set to 1. There are two facts: input_ids_length = encoder_outputs_length = encoder_sequence_length and decoder_ids_length = decoder_sequence_length. If I set sequence_length=5 in a generation task with past, I will get input_ids: torch.Size([1, **1**]); decoder_input_ids torch.Size([1, **1**]); past_key_values[0][0,1,2,3]: past_key_values torch.Size([1, 8, **5**, 64]) which is against this fact.

Thank you @fxmarty for the correction. I tried to set decoder_sequence_length and sequence_length to different values, but the encoder_sequence_length and the decoder_sequence_length still keep the same.

@jiqing-feng Yes, this option is missing!

@fxmarty Thanks
I think I know what you mean. If the encoder_sequence_length cannot be manipulated by users, could I add another PR to let the decoder_sequence_length can be manipulated by users?

cc @echarlaix

Hi @jiqing-feng ,
You would like to be able to specify the decoder_sequence_length where?

Hi @jiqing-feng , You would like to be able to specify the decoder_sequence_length where?

In my example, I wish I could pass a value to control decoder_sequence_length so I can get different decoder_sequence_length and encoder_sequence_length in the dummy inputs.


Enable the Flutter tool to change app id after project creation

The app id can be set when a project is created using --org.
It'd be great if the flutter tool could also update the app id after the project's been created, so that the Android and Xcode projects don't have to be manually edited.

second that.
Also, plz put Firebase enrollment in the app creation/app settings.

+1