fix(android): allowEdit not working when sourceType is PHOTOLIBRARY

Platforms affected
Android
Motivation and Context
allowEdit is not respected when source type is set to PHOTOLIBRARY. Looking into the code of the Camera plugin, I found that this case was never handled and allowEdit never launches cropping tool at all for Android versions >= Marshmallow.
This issue is reported in
#393
Description
In order to solve this issue, I made sure that performCrop is called when allowEdit is set to true for PHOTOALBUM and introduced an extra new parameter to  performCrop method in order to determine the source type to properly set request codes for Camera and Photo Album cropping cases.
Testing
I did manual testing to test all various test cases that I have and all pass fine. I also run paramedic unit tests and they runs perfectly in my emulator.
Checklist

[x] I've run the tests to see all new and existing tests pass
[ ] I added automated test coverage as appropriate for this change
[x] Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
[x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
[ ] I've updated the documentation if necessary

Is there any chance this will be included in the next build of the plugin?
Can I include this fix in my angular project?

Is there any chance this will be included in the next build of the plugin?
Can I include this fix in my angular project?

Please thumb it up so so it can be merged. thanks

Hope this can be reviewed and merged soon, @timbru31! We too are relying on a fix for this issue for our app. Thanks! 😊

hello @hazems,
My app is closed now when I choose load from gallery

hello @hazems,
My app is closed now when I choose load from gallery

This PR is not merged yet? which version of plugin are you using? What is your OS/device information? Do you have a sample that replicates the issue?
If yes, feel free to open a new issue, and we will look into it.
Thanks

@hazems I took the initiative to merge ARR-233, locally, but no effect. (android) allowEdit not working when sourceType is PHOTOLIBRARY error still exists. Can I help you?
Android 7.0

Stale


The "opts" arguments are not working

The optional parameters are not working, and it’s hard to come up with lambda values. Can there be a default list of lambda?

Now the necessary inputs are the predictor matrix X and response variable vector y. Both the lambda list and training ratio now have default settings.


Remove release flags and create release bar

Here's kinda what I had in mind.

You'll notice that there's a dotted square down below - that's to show what the releases are in the infobox. We can have hidden chiclets that group together the release data.


Fixes for pyproject.toml install issues

I don't normally use pyproject.toml-only builds, so I have no idea what I'm doing.

Just pulled and it seems to be working OK with a pip import via git!


Fixing #188 and #187 as well as replacing the image viewer with somet…

…hing that hopefully works better.

Also added new family type 'Oomycete'


TypeError: Cannot read property 'props' of null

Hello!
I tried to create dynamically accordion with condition.
But I got an ERROR:

accordion.js?96e3:69 Uncaught TypeError: Cannot read property 'props' of null
at eval (accordion.js?96e3:69)
at mapSingleChildIntoContext (react.development.js?99ee:914)
at traverseAllChildrenImpl (react.development.js?99ee:787)
at traverseAllChildrenImpl (react.development.js?99ee:803)
at traverseAllChildren (react.development.js?99ee:858)
at mapIntoWithKeyPrefixInternal (react.development.js?99ee:934)
at Object.mapChildren [as map] (react.development.js?99ee:956)
at Accordion.preExpandedItems (accordion.js?96e3:68)
at new Accordion (accordion.js?96e3:40)
at constructClassInstance (react-dom.development.js?cada:9760)

The example of my code:
const isCompany = false;

<Accordion>
  <AccordionItem>
    <AccordionItemTitle className={styles.item}>

        Accordion Header 1

    </AccordionItemTitle>
    <AccordionItemBody>

        Accordion Body Content 1

    </AccordionItemBody>
  </AccordionItem>

  {isCompany && (<AccordionItem>
    <AccordionItemTitle className={styles.item}>

        Accordion Header 2

    </AccordionItemTitle>
    <AccordionItemBody>

        Accordion Body Content 2

    </AccordionItemBody>
  </AccordionItem>)}
</Accordion>

Could you please help me to resolve this problem?

I have the same problem -- I think there is a bug in the code.  Any updates on this?

I sort of understand why this might happen given our current codebase, because the accordion Accordion component does some traversal of its 'children' and all of its children must be AccordionItem components. However, in this instance ^ there is a child where child === false (because {isCompany & foo} === false). Make sense?
A workaround would be to hide the AccordionItem with some additional className, rather than conditionally rendering it. We're currently working a big new release which should resolve this undesired behaviour, so hold tight :)

@ryami333 is right. Temporary workaround would be to use hideBodyClassName
Sorry about that. I'll leave this issue open as a reminder for the new version to support this case.

I guess I didn't explain how the problem shows up for me -- it shows up when trying to iterate over a list and dynamically build an Accordian based on the values in the list.
so
items.map((item) => {
   // build an accordian

})

Sounds like your problem might be unrelated then @EllaVader, even if it is the same error message. Could you please send me a snippet of your actual code?

@volkova-annie this should be solved in v2.0.0 😀
Let us know how you get on with the upgrade!


413 Add ACCTs to Risk to Self

Context
Trello card
Referrers need to be able to add to a list of ACCTs (Assessment, Care in Custody and Teamwork). Our current implementation will allow them to do this manually.

From the 'ACCT' page, they can open a form to add a new ACCT.
Once that form is submitted that data is saved and they are taken back to the 'ACCT' page to see it rendered.
'save and continue' on the ACCT page itself does not need to save anything but just continue to next page

Changes in this PR
ACCT Page

ACCT Data page

This is another case (like risk-to-self/guidance.njk) where we have to deviate from the regular flow of the "Task List system". When normal form pages are saved they will PUT the data from fields on the form and the controller will use it to update the data for that particular page in the application, overwriting the previous data saved.
In this case:

we need to change the regular data on a form to be an array instead of an object
and we need to preserve previously saved data

The riskToSelfGuidance page will always be the first ever page in a Task and it needs to update other pages - to do this it collates all the Task data as a hidden field on the form and PUTs it to the application (which is does when the form is submitted):
<form action="{{ paths.applications.update({ id: applicationId }) }}?_method=PUT" method="post">
          <input type="hidden" name="_csrf" value="{{ csrfToken }}"/>
          <input type="hidden" name="pageName" value="{{ page.name }}"/>
          <input type="hidden" name="taskData" value="{{ page.taskData }}"/>
          <input type="hidden" name="taskName" value="{{ page.taskName }}"/>
...

This ACCT data however could come at a point when there is already data against the Task. It also doesn't need to update any other pages in the Task, only it's own data.
I am suggesting in this PR that we use a custom form element and a new controller/service function to appendToList.
The acctData page will be responsible for sending over its task and page name, and the data it wants to append.
The controller and service will be do the data transformation and update required to append the form data to existing data.
When the acctData page is submitted, it will update the application data to look like this:
"risk-to-self: {
    "acct-data": [
        {
          "createdDate": ["10", "10", "2013"],
          "expiryDate": ["1", "2", "2012"],
          "referringInstitution": "HMPPS prison",
          "acctDetails": "ACCT details"
        }
      ]
}

Release checklist
As part of our continuous deployment strategy we must ensure that this work is
ready to be released at any point. Before merging to main we must first
confirm:
Pre merge checklist

[ ] Are any changes required to the e2e tests?
[ ] If you've added a new route, have you added a new
auditEvent? (see server/routes/apply.ts for examples)
[ ] Are there environment variables or other infrastructure configuration which needs to be included in this release?
[ ] Are there any data migrations required. Automatic or manual?
[ ] Does this rely on changes being deployed to the CAS API?

Post merge checklist
Once we've merged it will be auto-deployed to the dev environment.
Find the build-and-deploy job in CircleCI.
Should a release fail at any step, you as the author should now lead the work to
fix it as soon as possible.

Two types of form submission
I struggled initially to grasp the distinction here between the two types of form submission:
1. Regular 'page' submission to the pages controller
paths.applications.pages.update({
  id: applicationId,
  task: task,
  page: pageName
})

e.g.
PUT /applications/{applicationId}/tasks/confirm-eligibility/pages/confirm-eligibility
In this case the task and page information is in the path.
2. Special cases of submission direct to the applications controller
paths.applications.update({
  id: applicationId
})

e.g.
PUT /applications/{applicationId}
In this case the task and page data is supplied in hidden form fields.
We submit form data direct to the application controller in more complex scenarios e.g.

when we are importing data in bulk, behind the scenes, from upstream services like OASys
when we need to build up an arbitrarily long list of items, as in this case where the applicant can add one ACCT record after the other.

Naming of "guidance" page
Would "import" be clearer? I was initially struggling to understand why a guidance page (which perhaps sounds like pure content) would need special behaviour...

Thank you so much @edavey and @patrickjfl for your feedback!
I think we almost ready to go, there is just some kind of bug with the ability to submit the application because of the acct-data page 🤔  I think it's to do with the page being an array rather than object when we transform the data on submit...


memory leak in tabix

can't take that many hits until needs to restart itself.

Looks like a kubernetes thing instead of memory leak, much alleviated now via upgrading the kubernetes cluster


[Doc] Update "Hosting Authentication Endpoint on a Different Server" doc for IS 5.7.0

The jars mentioned in the doc in [1] are complying to IS 5.3.0. This needs to be updated with the relevant jars in IS 5.7.0.
[1]https://docs.wso2.com/display/IS570/Hosting+Authentication+Endpoint+on+a+Different+Server

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


LIN-736: Merge dvc_dag_PythonOperator.jinja into task_function.jinja

Description
Merges repeated logic in dvc_dag_PythonOperator.jinja into task_function.jinja.
Changes:

Rename localpickle to tmpdirpickle to better match the behavior of the serialization flavor.

Add CWD pickle flavor

Remove stages logic in DVC pipeline writer to directly use TaskDefinitions where possible and avoid intermediate task representation specific to DVC.

Change lineapy/plugins/jinja_templates/dvc/dvc_dag_StagePerArtifact.jinja to use Task Definitions as well.

Change dvc_dag_PythonOperator.jinja to use TASK_CODE block generated from the task_function template.

Fixes: LIN-736
Type of change
Please delete options that are not relevant.

[X] Refactor (non-breaking change which should not change functionality)

How Has This Been Tested?

Ensure snapshot tests for DVC do not change. DVC output has been prettified so the snapshot diff has a lot of changes which have been verified to be only spacing and formatting changes.

My. main query here is how does renaming LocalPickle to TmpDirPickle help in the PR. Most probably I'm missing some context here so a sync up would be helpful!

I renamed LocalPickle because it actually describes the newly added CWD pickle flavor. LocalPickle suggests we are using Pickle to a local directory but that doesnt distinguish between using local tmp vs local working directory. I renamed them both so that there is a distinction.


Add some information and break loop when a task failed incomplete

What changes are proposed in this pull request?
Add more information and break the taskId check loop when a task failed.
Why are the changes needed?
Not enough information for us to know which task failed , no need to check other taskId in the loop, just break.
Please clarify why the changes are needed. For instance,
Get more information when task failed, skip useless loop.
Does this PR introduce any user facing changes?
No
Please list the user-facing changes introduced by your change, including
No

Codecov Report

Merging #14024 (c0fbfbf) into master (d2e9472) will decrease coverage by 25.99%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             master   #14024       +/-   ##
=============================================
- Coverage     43.39%   17.39%   -26.00%
+ Complexity     9196     2692     -6504
=============================================
  Files          1417     1417
  Lines         82063    82064        +1
  Branches       9935     9935
=============================================
- Hits          35608    14278    -21330
- Misses        43501    66534    +23033
+ Partials       2954     1252     -1702

Impacted Files
Coverage Δ

.../java/alluxio/master/job/plan/PlanCoordinator.java
0.00% <0.00%> (-73.81%)
:arrow_down:

...mon/src/main/java/alluxio/shell/CommandReturn.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...mon/src/main/java/alluxio/util/ExceptionUtils.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...n/src/main/java/alluxio/wire/AlluxioProxyInfo.java
0.00% <0.00%> (-100.00%)
:arrow_down:

.../src/main/java/alluxio/wire/AlluxioMasterInfo.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...src/main/java/alluxio/job/meta/JobIdGenerator.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...n/src/main/java/alluxio/stress/BaseParameters.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...src/main/java/alluxio/client/UnderStorageType.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...main/java/alluxio/underfs/options/ListOptions.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...main/java/alluxio/worker/block/io/BlockReader.java
0.00% <0.00%> (-100.00%)
:arrow_down:

... and 672 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2e9472...c0fbfbf. Read the comment docs.

@apc999 @yuzhu PTAL, this pr seems ready to merge.

alluxio-bot, merge this please


Egg animation

Describe the project you want to add with tech stack

This project contains an egg animation.Can you assign this task to me?
Expected behavior

Screenshots (optional)

https://github.com/pranjay-poddar/Dev-Geeks/assets/128773151/947ab34d-8510-49a1-8074-52365497dd9d
Additional context (optional )

@MohitGupta121 ,
@TusharKesarwani Can you assign this task to me?

@MohitGupta121 ,@TusharKesarwani Can you Please assign this task to me?As Gssoc contribution period is going to end..this issues can level me up ..Please assign this issue to me...Please.


Wrong mailing list links are generated

Here is the example (generated with 2.0.0-beta2) https://builds.apache.org/view/M-R/view/OpenMeetings/job/openmeetings/site/openmeetings-server/mailing-lists.html
There is no mailto: prefix, so links are useless :(

Hello @solomax ,
I hope all is fine, I search to find the problem (nothing).
But, I discover how apache declares mailing list in pom.
https://github.com/apache/maven-parent/blob/master/pom.xml

got it
Will fix our build
sorry for the noise

No problem,
sla 24h 24/24 7/7.
Actually, you are same problem with contributor email.

Hmmm
the issue with mailing lists was fixed by adding mailto: prefix
The issue with contributor's email wasn't fixed :(
email addresses are displayed as mailto:real_mail instead of real_mail with mailto: in href :(

Thanks a million @devacfr for the investigation
I'll contact Maven team regarding this


Search config selection

Changed search checkbox to radio + tests

📝Changed routes:

/

(view full size)

Commit 28b37676518ab486e124aca02c2dfe4ba48ab4b0 (https://rookie-matchmaker-cd8ywfnfo-dca123.vercel.app).


[Issue] Dash doesn't start from VS Code Extension

I actually have a problem with VS Code to use Dash.
I have Dash full version on my Mac and it doesn't have any problem to use. But the extension for VS Code doesn't work for some reason. I just installed the extension on VS Code but "control+H", "control+alt+H" and any others don't start Dash app.
Dash version: 6.0.7
VS Code version: 1.59.0
macOS version: 11.5.1
Please let me know what I should do.

Actually the same as yours. I checked the shortcuts and I am pretty sure there isn't a conflict

The actual Dash app needs to be installed locally for this to work.

I think I have the same issue here:
Zeal 0.6.1 (definitely installed locally and works independently)
VS Code 1.78.1
Ubuntu 22.04.2 LTS
The extension doesn't respond whatsoever, not even through the command palette.

Same. I have the Dash app installed. Since there have been no responses or fixes, can it be assumed that this extension is unmaintained?

Not sure if this can help.
Apparently (under Windows) the VSCode plugin solicits the Zeal app through an URI scheme.
To enroll the App with this URI in my windows I had to run from command line "zeal --register".
This should be only done ONCE and works definitively.
OSX and Linux triggers work differently. Have a look here "https://github.com/deerawan/vscode-dash/blob/master/src/dash.ts"
and test manually why trigger may not open


build: Bump version to 0.9.0

As I note here https://github.com/PRQL/prql/pull/3015#discussion_r1272296132, the following version should be updated too.
https://github.com/PRQL/prql/blob/af3298fc0b902d9f26c3649403572c5106933a13/.github/workflows/check-links-book.yaml#L57

Thanks @eitsupi — fixed in https://github.com/PRQL/prql/pull/3049


[r1.15 Cherryick]:Install gast at known version and not the latest.

PiperOrigin-RevId: 267873409

the macos failure is due to the newly added tensorboard installation , and should not affect functionality. Merging this now.


Free text invoice correction configuration key

It may be useful to include information regarding how to turn on this configuration key or provide some specificity. Had to find the correct information using AX2012 official documentation from 2014
At least link to the License Codes Configuration Keys Report -  https://docs.microsoft.com/en-us/dynamics365/unified-operations/dev-itpro/sysadmin/license-codes-configuration-keys-report
Or a direct path to turn on: System Administration > Setup > License configuration - Configuration keys > General Ledger > Free text invoice correction select check box.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 463f56a8-323e-18c1-f1d0-fe641b920a5e
Version Independent ID: 11c68e7e-d46e-45b7-3d92-9cc86e688044
Content: Correct a free text invoice - Finance & Operations | Dynamics 365 | #MSDyn365FO
Content Source: articles/financials/accounts-receivable/correct-free-text-invoice.md
Service: dynamics-ax-applications
GitHub Login: @ShivamPandey-msft
Microsoft Alias: shpandey

Bug 300446 has been logged to track this issue.


a crack at solving #105

Oh wait, I missed #106

Reopening because #106 is only creating a new engine when a configFile prop is used. The config can also be passed as an object.

I like your more-robust solution over #106. One thing you might want to adjust however is the test:
"should report a single error because only one config causes an error" does not infer that "eslint-loader will create an engine for each unique config". Whether or not the second config is ignored, it will always report only one warning (not error). In my test I assured both configs were loading by throwing a unique warning from each: https://github.com/MoOx/eslint-loader/pull/106/files#diff-d1a0eb3a6e5c2e85a9cd54e5f92bfd7fR85
Feel free to borrow my solution or disregard!

Thanks!
Sorry, I'm not sure if I follow what you're saying... With my test, in the case where:

the first eslint config is used for both instances, there will be 2 warnings generated (and we're expecting 1)
the second eslint config is used for both instances, there will be 0 warnings generated (and we're expecting 1)
no eslint configs are used, there will be 0 warnings generated (and we're expecting 1)

What I mean to say is here, this rule will never throw an error so your assertion that stats.compilation.warnings.length === 1 is always true even if that second config object is never loaded or if there were another unforeseen problem with the webpack settings. So the test doesn't directly verify that "eslint-loader will create an engine for each unique config" as your test is named.
My suggestion around this would be to change the second config object rule from quotes: [1, "double"] to something that will throw a second warning, (semi: [1, "always"] for instance). You will know the second config is loading correctly if it throws the expected warning from the second config. You can then change the assertion to read stats.compilation.warnings.length === 2 instead of === 1.

Cool, I think I get you, however that introduces the problem where if only the first config is used, you'll still get two (quote) errors and the test will incorrectly pass. Do we need two separate tests? Got any ideas?

^^checking that I get two different types of warnings

I have closed PR #106 in favor of this one.

@MoOx thoughts?

Great work!

Releasing this as 1.6.1. Thanks you @jameslnewell and @jaythomas!


Set more accurate lower bound on base

Almost all (except for 4 which had a different but related issue) releases of deferred-folds suffer from the failure
Configuring library for deferred-folds-0.9.1..
Preprocessing library for deferred-folds-0.9.1..
Building library for deferred-folds-0.9.1..

library/DeferredFolds/Prelude.hs:41:8:
    Could not find module ‘Data.Semigroup’
    Use -v to see a list of the files searched for.
<<ghc: 120417240 bytes, 89 GCs, 3928144/8657080 avg/max bytes residency (6 samples), 22M in use, 0.001 INIT (0.001 elapsed), 0.040 MUT (0.045 elapsed), 0.110 GC (0.110 elapsed) :ghc>>

I've already revised all 33 affected versions,

https://hackage.haskell.org/package/deferred-folds-0.1/revisions/
https://hackage.haskell.org/package/deferred-folds-0.2/revisions/
https://hackage.haskell.org/package/deferred-folds-0.2.1/revisions/
https://hackage.haskell.org/package/deferred-folds-0.2.2/revisions/
https://hackage.haskell.org/package/deferred-folds-0.2.3/revisions/
https://hackage.haskell.org/package/deferred-folds-0.3/revisions/
https://hackage.haskell.org/package/deferred-folds-<IP_ADDRESS>/revisions/
https://hackage.haskell.org/package/deferred-folds-0.4/revisions/
https://hackage.haskell.org/package/deferred-folds-<IP_ADDRESS>/revisions/
https://hackage.haskell.org/package/deferred-folds-0.4.1/revisions/
https://hackage.haskell.org/package/deferred-folds-0.5/revisions/
https://hackage.haskell.org/package/deferred-folds-0.5.1/revisions/
https://hackage.haskell.org/package/deferred-folds-0.5.2/revisions/
https://hackage.haskell.org/package/deferred-folds-0.6/revisions/
https://hackage.haskell.org/package/deferred-folds-0.6.1/revisions/
https://hackage.haskell.org/package/deferred-folds-0.6.2/revisions/
https://hackage.haskell.org/package/deferred-folds-0.6.3/revisions/
https://hackage.haskell.org/package/deferred-folds-0.6.4/revisions/
https://hackage.haskell.org/package/deferred-folds-0.6.5/revisions/
https://hackage.haskell.org/package/deferred-folds-<IP_ADDRESS>/revisions/
https://hackage.haskell.org/package/deferred-folds-0.6.6/revisions/
https://hackage.haskell.org/package/deferred-folds-0.6.7/revisions/
https://hackage.haskell.org/package/deferred-folds-0.6.8/revisions/
https://hackage.haskell.org/package/deferred-folds-0.6.9/revisions/
https://hackage.haskell.org/package/deferred-folds-0.6.10/revisions/
https://hackage.haskell.org/package/deferred-folds-0.6.11/revisions/
https://hackage.haskell.org/package/deferred-folds-0.6.12/revisions/
https://hackage.haskell.org/package/deferred-folds-0.7/revisions/
https://hackage.haskell.org/package/deferred-folds-0.7.1/revisions/
https://hackage.haskell.org/package/deferred-folds-0.7.2/revisions/
https://hackage.haskell.org/package/deferred-folds-0.8/revisions/
https://hackage.haskell.org/package/deferred-folds-0.9/revisions/
https://hackage.haskell.org/package/deferred-folds-0.9.1/revisions/

@nikita-volkov I've just had to fixup yet another 4 releases being affected by inaccurate metadata via

https://hackage.haskell.org/package/deferred-folds-0.9.6/revisions/
https://hackage.haskell.org/package/deferred-folds-0.9.7/revisions/
https://hackage.haskell.org/package/deferred-folds-<IP_ADDRESS>/revisions/
https://hackage.haskell.org/package/deferred-folds-0.9.8/revisions/

please merge this PR so I don't have to spend time playing Whac-A-Mole with deferred-folds uploads... ;-)

Thanks. Didn't notice your previous post

@nikita-volkov thanks! btw, what's the best way to get your attention? :-)

I guess all of them are equal :) It's just sometimes when lots of messages pile up I may miss a few.


How to have different in and out animations?

Is it possible to define both in and out animations?
animate-in animate-out fade-in fade-out does not work as fade-in fade-out conflict.

https://github.com/jamiebuilds/tailwindcss-animate/issues/34#issuecomment-1569983854

+1
This would be very interesting, many times you want an element to enter and exit the page (modals, drawers, etc), and it is a pity to have to do it via javascript.

Hi there,
this feels like obvious and easy-to-implement behavior. Currently, using e.g. animate-in animate-out causes the latter class to overwrite the first one.
Any plans to add that to the lib?

I'd appreciate if we could have an example in the docs for manually handling this with JS (maybe a React / Svelte Example)

If anyone has one already ready, please send it so I can implement it directly

I managed to do it using hyperscript.

Toast Message


Make sure homologation is signed by March

doc to prepare the homologation : https://cyber.gouv.fr/sites/default/files/2014/06/guide_homologation_de_securite_en_9_etapes.pdf


Dynamic Filtering

Last September I messaged @diplojocus about wanting a filter like Extended's [vcf_bp6~], which takes audio input for the q-value, allowing for smooth, quick changes to the value. @diplojocus started writing about Heavy-compiled externals and I got a bit overwhelmed and put it aside. But during that conversation he sent me this patch, which uses Heavy-only objects and said that I could modify it to be take an audio input for the q: http://s000.tinyupload.com/?file_id=04582392836268290080
Looking at it now, I'm not sure how to do that since, as it is now, the q value goes straight into a [moses] and some triggers, which can't take audio data... if anyone has an idea of how to do that, or if any other solutions for this kind of filter have emerged, please let me know!

@diemildefreude yes! I actually did this recently! Let me find the patch

vcf~.zip

You can set frequency and q with signal rate inputs. I've been meaning to add this to heavylib but haven't come up with a good name yet. It requires a different object to load it, so something like:

[hv.filter filterType]
[hv.filter.gain filterType]
[hv.filter.sigq??? filterType]

That's great, Joe. I'll have a look at it soon, I just keep running into other problems. x)

OK, I just tried out your patch and I'm wondering how I can use it to approximate the [vcf_bp6~] I mentioned above. Here's a .zip with the files: http://s000.tinyupload.com/?file_id=21935706242746426856
Back then, @diplojocus , you wrote me that I should be able to hook up three of PD's [vcf~]s together to get a similar result... but I needed the audio inlet for q. Now, I'm not sure how to do it with your [vcf] and, if I were to link up multiple instances, what values to feed each one. If I feed three of your [vcf]s into eachother and put the same frequency and q values into each one, I do get a more nuanced filter, but it quickly becomes prone to amplitude spikes the higher I set the q. In contrast, both PD's [vcf~] and the [vcf_bp6] become quieter the higher the q is, which makes sense since sounds are being filtered out.
Just the one Heavy-[vcf] doesn't change much if you raise the q more than 1 * x, where x = the base frequency. Also, q = 0 is oddly quiet unlike the aforementioned PD objects, which, when set to q = 0, yield a sound of the same amplitude as the input. Is this behavior due to some kind of dynamic normalizer in your patch, or am I missing something else?

Is there source code for the vcf_filter~ object somewhere? If we know how they calculate the coefficients then you'll be able to re-create.
I never got round to checking if the output is the same with the signal controlled q version of vcf, looks like it is different, might be a bug somewhere.

Oh I doubled checked, that Q controlled vcf filter is only similar in name to Pd's version. It's actually just a signal rate copy of the hv.filter bandpass1. It's expected to sound different.

And, if your next question is can we make a signal rate Q controller version of Pd's [vcf~]? it's likely when I get round to it.

Could you make a s-

And, if your next question is can we make a signal rate Q controller version of Pd's [vcf~]? it's likely when I get round to it.

Oh, great, thanks. :D Also, any tips for using this one in the meantime? Specifically, I mean volume normalization, so that it gets louder when you decrease the q (or stays the same). I imagine the equation would vary depending on the sample though...

The usual way to tackle this is to create some volume mapping parameter from your q parameter. Either use a lookup table or some function to translate the range.
For example, it's similar to changing the volume of a synth when higher note pitches are played.

Yeah, I tried volume = 15 - ( q * 7), so that at a q of 0 it has about the same volume as the input and at a q of 2 it's also about the same volume, but difference is not linear, so it gets too loud at lower q levels. I'm not so great at math though...


[SPARK-8032] [PySpark] Make version checking for NumPy in MLlib more robust

The current checking does version 1.x' is less than 1.4' this will fail if x has greater than 1 digit, since x > 4, however 1.x < 1.4
It fails in my system since I have version 1.10 :P

ping @mengxr @jkbradley

Merged build triggered.

Merged build started.

Test build #33968 has started for   PR 6579 at commit 0929877.

Test build #33968 has finished for   PR 6579 at commit 0929877.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Merged build triggered.

Merged build started.

Test build #33986 has started for   PR 6579 at commit 3a3a639.

Test build #33986 has finished for   PR 6579 at commit 3a3a639.

This patch fails Python style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #33989 has started for   PR 6579 at commit 22703dd.

Test build #33989 has finished for   PR 6579 at commit 22703dd.

This patch fails MiMa tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

jenkins test this

Merged build triggered.

Merged build started.

Test build #33992 has started for   PR 6579 at commit 22703dd.

Test build #33992 has finished for   PR 6579 at commit 22703dd.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

done

Merged build triggered.

Merged build started.

Test build #34003 has started for   PR 6579 at commit e89376c.

Merged build triggered.

Merged build started.

Test build #34004 has started for   PR 6579 at commit e35f0d4.

Test build #34003 has finished for   PR 6579 at commit e89376c.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

@MechCoder Why it is <= instead of <? We do support numpy 1.4.x like 1.4.1.

Merged build finished. Test FAILed.

I see, I misunderstood the comment '"MLlib requires NumPy 1.4+"

Merged build triggered.

Merged build started.

Test build #34011 has started for   PR 6579 at commit 893fb7e.

@MechCoder please test it on your local and watch the Jenkins error message. For example,
In https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34003/consoleFull, you can see
Running test: pyspark.mllib.classification ... Traceback (most recent call last):
  File "/usr/lib64/python2.6/runpy.py", line 104, in _run_module_as_main
    loader, code, fname = _get_module_details(mod_name)
  File "/usr/lib64/python2.6/runpy.py", line 79, in _get_module_details
    loader = get_loader(mod_name)
  File "/usr/lib64/python2.6/pkgutil.py", line 456, in get_loader
    return find_loader(fullname)
  File "/usr/lib64/python2.6/pkgutil.py", line 466, in find_loader
    for importer in iter_importers(fullname):
  File "/usr/lib64/python2.6/pkgutil.py", line 422, in iter_importers
    __import__(pkg)
  File "pyspark/mllib/__init__.py", line 27
    ver = [int(x) for x in numpy.version.version.split(.)[:2]]

Merged build triggered.

Merged build started.

lol. sorry about the silly mistake.

Test build #34014 has started for   PR 6579 at commit 15430f8.

Test build #34004 has finished for   PR 6579 at commit e35f0d4.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test build #34011 has finished for   PR 6579 at commit 893fb7e.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test build #34014 has finished for   PR 6579 at commit 15430f8.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

LGTM. Merged into master and all branches since 1.0. Thanks!


Not all textures are extracted from xfbin file

xfbin contains two textures 3hanbody.nut and 3hanbody_lod1.nut with the same name, but only one of them is extracted.

Noesis can't convert them to dds and throws four error: WARNING: Unknown texture format 6.
Here is the file 3hanbod1.out.zip

This isn't really an issue. I just didn't include an option to also dump alternate textures yet.


Adds null safety.  Refresh example app.

Adds null safety.
Refreshes the example app.
Updates .gitignore and removes files that should not be tracked.

This PR depends on LuisThein/apple_maps_flutter#123 PR, which must be published first.
Rather that merge this PR, it would be better to git fetch to create a new 1.x branch instead so that fixes can be added easily to the non-null safe version of this package.

Thank you very much for the Pull requests!


ERROR: Cannot install launch==0.1.0, launch==0.1.1, launch==0.1.2 and launch==0.1.3 because these package versions have conflicting dependencies.

python install.py

Traceback (most recent call last):   File "/root/soft/sd_civitai_extension/install.py", line 7, in <module>     from launch import run ModuleNotFoundError: No module named 'launch'

pip install launch

(py310) root@ubuntu20:~/soft/sd_civitai_extension# python install.py
Traceback (most recent call last):
  File "/root/soft/sd_civitai_extension/install.py", line 7, in <module>
    from launch import run
ModuleNotFoundError: No module named 'launch'
(py310) root@ubuntu20:~/soft/sd_civitai_extension# pip install launch
Looking in indexes: http://mirrors.cloud.aliyuncs.com/pypi/simple/
Collecting launch
  Using cached http://mirrors.cloud.aliyuncs.com/pypi/packages/a9/c1/793768c803a25e2e101ed88fe3979f17d4d67d160aedb3c3bd143653f068/launch-0.1.3.tar.gz (10 kB)
  Preparing metadata (setup.py) ... done
  Using cached http://mirrors.cloud.aliyuncs.com/pypi/packages/4a/cd/ba5ade0b40ce222d49d25aa22c6741e5de4a3ce89a5d7db507c749144137/launch-0.1.2.tar.gz (10 kB)
  Preparing metadata (setup.py) ... done
  Using cached http://mirrors.cloud.aliyuncs.com/pypi/packages/02/ea/f08cc7605f62868c5bc8ba7d64a7292ea58739696f0d8016a264daeca186/launch-0.1.1.tar.gz (10 kB)
  Preparing metadata (setup.py) ... done
  Using cached http://mirrors.cloud.aliyuncs.com/pypi/packages/b0/ef/1b1bca20ef3a088dd6475d9733ef58fcc4db2ab34a19003063d931dc9a28/launch-0.1.0.tar.gz (7.2 kB)
  Preparing metadata (setup.py) ... done
ERROR: Cannot install launch==0.1.0, launch==0.1.1, launch==0.1.2 and launch==0.1.3 because these package versions have conflicting dependencies.

The conflict is caused by:
    launch 0.1.3 depends on flowdas-meta<1.1 and >=1.0.1
    launch 0.1.2 depends on flowdas-meta<1.1 and >=1.0.1
    launch 0.1.1 depends on flowdas-meta<1.1 and >=1.0.1
    launch 0.1.0 depends on flowdas-meta<1.1 and >=1.0.1

To fix this you could try to:
1. loosen the range of package versions you've specified
3. remove package versions to allow pip attempt to solve the dependency conflict

ERROR: ResolutionImpossible: for help visit https://pip.pypa.io/en/latest/topics/dependency-resolution/#dealing-with-dependency-conflicts

system info:
ubuntu 20.04
python 3.10
pip 22.3.1

same here

same here

Same issue here.

modify you install.py insert sys.path.append('../YOUR_PATH') the launch module is your launch.py  just import it

Same issue :(

modify you install.py insert sys.path.append('../YOUR_PATH') the launch module is your launch.py just import it

can you please explain your answer? adding this ( even using insert(0, doesn't seem to help me

modify you install.py insert sys.path.append('../YOUR_PATH') the launch module is your launch.py just import it

can you please explain your answer? adding this ( even using insert(0, doesn't seem to help me

add it to here, I guess the launch means launch.py in the folder.

Can someone properly explain how to fix it in English or make a pull request?

Python is failing to import a module. Usually, this can be solved by running "pip install " inside of the terminal but because "launch" is not a package defined in the pip repository, we cannot use pip for this. Instead, we need to specify a path where Python looks for the "launch" module. "launch.py" is a Python script in the webui and is what we need to import. So instead of finding and installing something on the internet using pip, the webui uses a file path on your computer to import the "launch.py" script.
To fix this we need to change where python is looking. Normally we would have to use pip to install a module from the internet using pip, but we want it to look on our computer. To do that simply in a Python program, we can import the "sys" package (which is defined by Python) and add a file path to where it is looking to import from. Go to the extensions folder, find this extension's folder, open the "launch.py" file (for the extension), and add this code to the top:
import sys
sys.append("your/file/path/to/a1111/here") #MAKE SURE YOU CHANGE THE FILE PATH BEFORE YOU IMPORT "LAUNCH"
Now, when the script does "from launch import run" later on, it will check the webui folder and try importing the module from there.
What "sys.append()" does, is take an input of the file path you want to add: set this to your "stable-diffusion-webui" folder (for a1111) path. Mine on Linux looks like "sys.append("/home/myname/stable-diffusion-webui")". Then after we have added the file path to a list that it checks when importing, we can import the "launch" module as done by the line later on: "from launch import run".
I find myself having to do this pretty often with new extensions if they fail to import "launch". I just go into the script and change the file path to include the a1111 webui folder and it usually works. Hope this helped. I am still learning too.

import sys
sys.append("your/file/path/to/a1111/here") #MAKE SURE YOU CHANGE THE FILE PATH BEFORE YOU IMPORT "LAUNCH"

works for me

import sys
sys.append("your/file/path/to/a1111/here") #MAKE SURE YOU CHANGE THE FILE PATH BEFORE YOU IMPORT "LAUNCH"

works for me

its work, thanks!

nothing work for me. but this may be helpful
https://stackoverflow.com/questions/71009659/message-note-this-error-originates-from-a-subprocess-and-is-likely-not-a-prob

cd to your sd webui root path, run this command:
PYTHONPATH=$(pwd) python extensions/sd-webui-segment-anything/install.py

I'm having a similar issue with batchlinks-webui, but It's much more complicated because I am trying to create a Docker image based on a modified version of this repository.. I can't reference sd webui's launch.py on my local machine, because it wouldn't mean anything to the docker image.

if the above solution isn't working for you...Windows
I like you was having many issues with 'pip install launch' and getting a reporting error of
"ERROR: Cannot install launch==0.1.0, launch==0.1.1, launch==0.1.2 and launch==0.1.3
because these package versions have conflicting dependencies. The conflict is caused by:
launch 0.1.3 depending on ,
flowdas-meta<1.1 and >=1.0.1
launch 0.1.2 depends on
flowdas-meta<1.1 and >=1.0.1
launch 0.1.1 depends on
flowdas-meta<1.1 and >=1.0.1
launch 0.1.0 depends on
flowdas-meta<1.1 and >=1.0.1
To fix this you could try to: 1. loosen the range of package versions you've specified 2. remove package versions to allow pip attempt to solve the dependen
I went ahead and downloaded the Downloading launch-0.1.3.tar.gz (10 kB) Downloading launch-0.1.2.tar.gz (10 kB) Downloading launch-0.1.1.tar.gz (10 kB) Downloading launch-0.1.0.tar.gz (7.2 kB) that the call was asking for, upon examination of the setup.py in the folder 'launch-0.1.3' the first line of 'install_requires' had the call to download flowdas to a defunct https://bitbucket.org/flowdas/launch, it simply is nonexistent and there are a lot of people that can't download it, but still need it.
I went ahead and emailed the author. After all that I went and updated my flowdas to 0.5.0 https://pypi.org/project/flowdas/
'pip install flowdas'
installed it then I went back to setup.py and changed the first three lines to update to
install_requires = [
'flowdas>=0.5.0,<0.6.0',
'click>=6.7,<6.8',
'PyYAML>=3.12,<3.13',
, to reflect all the new updated versions to be installed that includes all three lines, in the root folder of launch-0.1.3 I executed the
pip install -e .
, and wouldn't you know it installed, all of it...
Now I am not responsible for what happens if anything to your machine, as this works for me and my application and it may not work for you, best to do everything you can in a VENV. Hope that helps! bingo, bongo, bango, you're the rock star, get after it!

import sys
sys.append("your/file/path/to/a1111/here") #MAKE SURE YOU CHANGE THE FILE PATH BEFORE YOU IMPORT "LAUNCH"

works for me

Thanks for this. This helped me out!

pip install --upgrade setuptools

solved my problem.

add one line before "from lauch import run"
your stable-diffusion-webui repo
sys.path.append('/home/rrrr/stable-diffusion-webui')


Sub-protocol now separate with a comma

According to RFC 6455 and RFC 2616, the list of sub-protocols given to the server must be separated by a comma, and not a semi-colon as is currently implemented.
This pull request changes the delimiter to a comma.

Thanks Daniel. Great catch!


docker repo does not exist

Hello, just wanted to let you know the docker repo you mention in the installation step does not seem to exist. not only does it not show up on docker hub, but trying to pull it from the CLI results in the following error message:
Error response from daemon: pull access denied for gretel/gretel, repository does not exist or may require 'docker login': denied: requested access to the resource is denied
and yes, before you ask, I've successfully logged in using docker login before issuing the command.

@0ro8lu Yes, thank you. The docker is not updated at the moment. We updated the README shortly for the moment. More info and the new docker image will come in the future.


Add Degradations

How to use these degradations ? Should I set some params in the *.yml in options/train?


Support scoped packages

Thanks for making this awesome plugin! While trying to use it I ran into an issue where I found scoped packages are being ignored https://github.com/EddyVerbruggen/nativescript-nodeify/blob/master/patch-npm-packages.js#L213
I'm sure there must be a reason behind it. Is there a way to override that and maybe whitelist some scoped packages?

Just ran into the same issue today...
Had to work around it by putting a postinstall script that does
const fs = require('fs')

const toRemove = '&& !folderName.startsWith("@")'

const filePath = require.resolve('nativescript-nodeify/patch-npm-packages')

const initialScript = fs.readFileSync(filePath, 'utf8')

const repairedScript = initialScript.replace(toRemove, '')

if (initialScript === repairedScript) console.log('Nothing to patch.')
else console.log('Patched `patch-npm-packages.js` successfully')

fs.writeFileSync(filePath, repairedScript, 'utf8')

This is more than ugly, and I'd love to get rid of it.


PostgreSQL flexible server azure regions - UK West documentation shows no v3/v4 compute

The documentation says that UK West does not have v3/v4 compute available, but I was able to make a PostgreSQL flexible server in UK west on v4 compute, and v3 also appears to be available.
Does the documentation need updating?
It looks like it was changed recently with this commit but the commit message does not match the change that was made. The commit message says "Updated UK south Zone Redundant HA" but it was actually UK West v3/v4 compute that was changed.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 789139e9-15bb-58a9-7dc3-bd85c0bcfee5
Version Independent ID: cda59fed-f3ff-aa09-a13c-027a54e4141a
Content: Azure Database for PostgreSQL - Flexible Server
Content Source: articles/postgresql/flexible-server/overview.md
Service: postgresql
Sub-service: flexible-server
GitHub Login: @sunilagarwal
Microsoft Alias: sunila

Hi @ghelyar,
Thanks for sharing this feedback. We will look into this and update as appropriate.

Hi @sunilagarwal, @kabharati ,
Could you please look into this document request, thanks.

It appears to be a typo i have fixed it in https://github.com/MicrosoftDocs/azure-docs-pr/pull/217213.


GenericBrick background color won’t reset to clear

GenericBrick’s updateContent would clear the background colors. This caused a problem when reloading a cell with the actual reload via UICollectionView
Fixes #154

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@a78005e). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master     #155   +/-   ##
=========================================
  Coverage          ?   93.44%
=========================================
  Files             ?       39
  Lines             ?     3157
  Branches          ?        0
=========================================
  Hits              ?     2950
  Misses            ?      207
  Partials          ?        0

Impacted Files
Coverage Δ

Source/Bricks/Generic/GenericBrick.swift
100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a78005e...5fe6c00. Read the comment docs.


Don't require sudo when discovery is not needed

For instance, when running resin local push [ip] we could optimise the process and not require sudo

Want to try it yourself or want me to work on it? The key is to offload the minimal task that requires sudo to an internal command and sudo-spawn it when needed - see the os init command and the internal.js for examples

+1 on this. It also makes the .resin-sync.yml file owned by root, which is irritating.

Hey @emirotin , it would be great if you have time to look into this.

OK will do as soon as I have time

As @brownjohnf said ...

It also makes the .resin-sync.yml file owned by root, which is irritating.

👍

Related to #542

The resin local push command was replaced with balena push and a new implementation in CLI v11. It no longer requires sudo.


Introduce ClientVersion to request protos

The version is taken from new BuildConfig properties, that are in turn generated from the closest git tag to the current commit.
This is stacked upon #29.

Codecov Report

Merging #30 into master will increase coverage by 0.18%.
The diff coverage is 74.5%.

@@             Coverage Diff              @@
##             master      #30      +/-   ##
============================================
+ Coverage     67.84%   68.03%   +0.18%
- Complexity      325      337      +12
============================================
  Files            45       47       +2
  Lines          1807     1858      +51
  Branches        220      224       +4
============================================
+ Hits           1226     1264      +38
- Misses          513      524      +11
- Partials         68       70       +2

Impacted Files
Coverage Δ
Complexity Δ

bbq/java/com/google/bbq/BroadcastQueryClient.java
55.46% <100%> (+0.35%)
7 <0> (ø)
:arrow_down:

...ol/java/org/openyolo/protocol/RetrieveRequest.java
92.4% <100%> (+0.09%)
10 <0> (ø)
:arrow_down:

...otocol/java/org/openyolo/protocol/HintRequest.java
87.23% <100%> (+0.13%)
11 <0> (ø)
:arrow_down:

...ava/com/google/bbq/internal/ClientVersionUtil.java
50% <50%> (ø)
4 <4> (?)

.../openyolo/protocol/internal/ClientVersionUtil.java
95.83% <95.83%> (ø)
8 <8> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73dd2e9...03f1559. Read the comment docs.


Provide use-case tutorial and worked examples

Much of the information in the template notebooks presented simply as per-tool summary tables/graphics, but it would be nice to provide some more integrated views/visualisations of the data from the different tools to enable more complex querying e.g. “Show me unique polyketide BGCs (no big-fam, mibig hits) with a hit in ARTS”.
Include more fleshed out examples/case studies in the wiki, from the perspective of how to design BGCFlow projects to achieve certain goals, e.g. “I want to find out X, so I use tool Y”. Currently, Section 10 of the wiki is an example project, but just links to the example presented in the manuscript. It would be helpful to have more case studies going over common potential workflows in this way.

tutorial available in https://nbchub.github.io/bgcflow_report_demo/custom_tutorial/


Add Grace's caputring data change in dbt DevBlog

Checklist
If you added new pages (delete if not applicable):

[ ] The page has been added to website/sidebars.js
[x] The new page has a unique filename

@graciegoheen Hmm yeah that's a good point I didn't think of 😅 I don't have a strong opinion either way, so it's really up to you. It's your baby :)
If that's what you want to do, submit a design request ticket to the Design team. Unfortunately, I won't have time to create all of those images myself as I did with the first two tables. We would also need to push back the publishing date as the Design team requires at least 10 days to complete a request — and that's not the end of the world!
Let me know if that's what you want to do, and I'll push back the publishing date!

I'm curious what others think! One alternative would be to just make everything a table (and remove the images), though then we wouldn't have the highlighting pointing out the changes.

This is an awesome post Grace! Can definitely see a lot of practitioners referencing this.
RE the tables, I think my suggestion is to make the table images into actual tables and either bold and/or italicize the revenue column numbers to make them standout. Would be even better if we could make those column values a different color (may want to ask Jason K?).

Closes #1651

@graciegoheen I committed your changes and bolded the text in the changed records. Let me know if it looks good! On your point about the pros and cons table, there's unfortunately no way for me to change how the column sizing works on the page. We could use an image, but it sounds like the consensus here is that we should stick to tables vs. images. Let me know if that works for you and I can get this scheduled to publish this week!

@graciegoheen Hey, made all the changes you suggested! I also played around with the image size, but for whatever reason, the CMS still blows it up super big. Not really sure if it's possible to make it smaller as I think the image sizes adjust dynamically based on screen size. If that's okay though, I can get this merged now!


how to update ocelot configuration without downtime

when i update ocelot configuration，service must be closed. how to update Configuration.json online?
Startup.cs
services.AddOcelot(new ConfigurationBuilder()                 .AddJsonFile("configuration.json", optional: false, reloadOnChange: true)                 .Build());
@geffzhang
@TomPallister

One options would be use consul kv store as it is explained in the doc.
Hope it helps!

@Stronhold Thanks a lot！i will try it to slove ,
i saw #36 issue right now,  how to sloved it in #36 ?

Well, that is the other option, as it is stated in #36, here is the doc  you need to solve your problem. I have not tested yet, so I do not know how it works exactly.
Hope it helps!

@Stronhold I follow doc alter my code.
Startup.cs
`
        //services.AddOcelot(new ConfigurationBuilder()
        //    .AddJsonFile("configuration.json", optional: false, reloadOnChange: true)

        //    .AddEnvironmentVariables()
        //    .Build());

        services.AddOcelot().AddStoreOcelotConfigurationInConsul();`

configuration.json
{   "GlobalConfiguration": {     "ServiceDiscoveryProvider": {       "Host": "localhost",       "Port": 8500,       "ConfigurationKey": "Ocelot"     }   } }
consul KV

But i failed to run Ocelot successfully. Do I miss anything？
Thanks a lot!

@chenzhe014 is What error do you get from Ocelot?

@TomPallister Just 404...
This is my Reroutes on Consul KV
{"ReRoutes": [     {       "DownstreamPathTemplate": "/api/values",       "DownstreamScheme": "http",       "DownstreamHostAndPorts": [         {           "Host": "localhost",           "Port": 5001         }       ],       "UpstreamPathTemplate": "/webapia/values",       "UpstreamHttpMethod": [ "Get" ]     },     {       "DownstreamPathTemplate": "/api/values",       "DownstreamScheme": "http",       "DownstreamHostAndPorts": [         {           "Host": "localhost",           "Port": 5002         }       ],       "UpstreamPathTemplate": "/webapib/values",       "UpstreamHttpMethod": [ "Get" ]     },     {       "DownstreamPathTemplate": "/api/values/{id}",       "DownstreamScheme": "http",       "DownstreamHostAndPorts": [         {           "Host": "localhost",           "Port": 5001         }       ],       "UpstreamPathTemplate": "/WebApiA/values/{id}",       "UpstreamHttpMethod": [ "Get" ],       "ReRouteIsCaseSensitive": true     },     {       "DownstreamPathTemplate": "/api/values/{id}",       "DownstreamScheme": "http",       "DownstreamHostAndPorts": [         {           "Host": "localhost",           "Port": 5002         }       ],       "UpstreamPathTemplate": "/WebApib/values/{id}",       "UpstreamHttpMethod": [ "Get" ]     },     {       "DownstreamPathTemplate": "/api/User/GetSex",       "DownstreamScheme": "http",       "DownstreamHostAndPorts": [         {           "Host": "localhost",           "Port": 5001         }       ],       "UpstreamPathTemplate": "/Sex",       "UpstreamHttpMethod": [ "Get" ],       "Key": "Sex"     },     {       "DownstreamPathTemplate": "/api/User/GetAge",       "DownstreamScheme": "http",       "DownstreamHostAndPorts": [         {           "Host": "localhost",           "Port": 5001         }       ],       "UpstreamPathTemplate": "/Age",       "UpstreamHttpMethod": [ "Get" ],       "Key": "Age"     },     {       "DownstreamPathTemplate": "/api/User/GetID",       "DownstreamScheme": "http",       "DownstreamHostAndPorts": [         {           "Host": "localhost",           "Port": 5001         }       ],       "UpstreamPathTemplate": "/ID",       "UpstreamHttpMethod": [ "Get" ],       "Key": "ID"     },     {       "DownstreamPathTemplate": "/api/Counter/Count",       "DownstreamScheme": "http",       "UpstreamPathTemplate": "/count",       "UpstreamHttpMethod": [ "Get" ],       "ServiceName": "Count",       "LoadBalancer": "RoundRobin",       "UseServiceDiscovery": true     }   ]}

Do i miss anything?

If i store configuration in consul,did i need add Ocelot.json  in Startup.cs?

@chenzhe014 I think you need to add the service discovery information into the configuration. See the docs here
e.g.
"GlobalConfiguration": {
    "ServiceDiscoveryProvider": {
        "Host": "localhost",
        "Port": 9500
    }
}

Ocelot get's it initial configuration from json and then starts using Consul. I think this might be why it doesn't work. Can you let me know if this fixes the problem?
If it does I might need to improve the user experience here.

Yes, you need to add Ocelot.json in Startup.cs. I think that is the problem, as @TomPallister said. Moreover, remember that if you do not specify ConfigurationKey, ocelot will use as key InternalConfiguration

i try add Ocelot.json in Startup.cs
services.AddOcelot(new ConfigurationBuilder()
                .AddJsonFile("Ocelot.json", optional: false, reloadOnChange: true)
                .AddEnvironmentVariables()
                .Build()).AddStoreOcelotConfigurationInConsul();

it is still 404 ..
then i alert Program.cs
public static IWebHost BuildWebHost(string[] args) =>
                WebHost.CreateDefaultBuilder(args).ConfigureAppConfiguration((builderContext, config) =>
                {
                    config.AddJsonFile("Ocelot.json", optional: false, reloadOnChange: true);
                })
                .UseStartup<Startup>()
                .Build();

it is still 404 ..
How should I add..

@chenzhe014 have you added your service discovery configuration to Ocelot.json and your consul json?

@chenzhe014 in your ocelot.json you just need this. The configuration key is whatever you specified in for the Ocelot configuration in Consul.
"GlobalConfiguration": {
    "ServiceDiscoveryProvider": {
        "Host": "localhost",
        "Port": 9500,
         "ConfigurationKey": "XXXX"
    }
}

Remove below from Startup.cs but keep your entry in Program.cs
                .AddJsonFile("Ocelot.json", optional: false, reloadOnChange: true)

Now you should have configuration to start Ocelot. When Ocelot starts it will look up your configuration by ConfigurationKey in Consul.
You configuration in Consul must contain the following configuration...{Add Re ReRoutes Here} is just a place holder.
"ReRoutes": [{Add Re ReRoutes Here}],
"GlobalConfiguration": {
    "ServiceDiscoveryProvider": {
        "Host": "localhost",
        "Port": 9500,
         "ConfigurationKey": "XXXX"
    }
}

Let me know if you need more help! 😄

@chenzhe014 I will take a look ASAP :)

@chenzhe014 you need to have
"ServiceDiscoveryProvider": { "Host": "localhost", "Port": 8500, "ConfigurationKey": "Oceolot" }

in your ocelot.json otherwise Ocelot doesn't know which key to use to get the configuration from Consul. Give that a try and let me know if anything changes?
If it doesnt I will look again.

@TomPallister Thank you for your reply.
I'm sorry. the README.md is previous version. I forgot to update it .  I delete ConfigurationKey in json  and the key of configuration from Consul is default InternalConfiguration,In the latest version.

@chenzhe014 please can you push those changes to that repo so I can see exactly what you are testing with!

@TomPallister I give up storing the configuration in consul. i change configuration during runtime via an authenticated HTTP API successfully . this is more quickly.
in this issue,i add my demo to Ocelot Source Code for debug and i find it can get the configuration successfully.  I can't find a reason for 404  so far and i don't  want to continue  . my ability is limited,
but i will continue studying Ocelot.  Thanks for your help again !

@chenzhe014 OK I'm glad you were able to solve your problem.
I'm sure it would have been something small that was causing your problems! Good luck in the future :)

@chenzhe014 I would like to ask did your changes saved to the local "Ocelotconfiguration".json?
I followed every steps on the ocelot documents but the configuration json is cached.

@samsiu2014 i find in debug environment,it is  changed in Ocelotconfiguration.Development.json . if you publish your application,it is changed in 'Ocelotconfiguration.Production.json'

@samsiu2014 maybe you would follow the doc.
.AddJsonFile($"configuration.{hostingContext.HostingEnvironment.EnvironmentName}.json")

@chenzhe014 Thanks for your reply!
After I changed the configuration during runtime via an authenticated HTTP API. The new values would not reflect in the "Ocelot.json". If I try to restart the API Gateway, the previous settings will be applied in instead of the modified one.

@TomPallister Thank you so much! However, does the administration API work on "DownstreamHostAndPorts"? It didn't have any effects if i only modified the port number.

@samsiu2014 there was a bug with that until recently! What version of Ocelot are you using?

@TomPallister 7.0.5! Then, i just need to wait the new release right? Thanks!

@samsiu2014 I think it was fixed in 7.0.6!
Install-Package Ocelot -Version 7.0.6
For that a go!

@TomPallister It works! Thanks a lot!

@samsiu2014 no worries!

how can i update downstreampath and upstreampath of configuration.json file

how can i update downstreampath and upstreampath of configuration.json file with the help of angular

how can i update upstreampath and downstreampath of ocelot configuration.json file

you may need this @shubham0990
sample here:
            // PUT /ocelot/admin/configuration
            app.Map(new PathString("/ocelot/admin/configuration"), appBuilder =>
            {
                appBuilder.Use(async (context, next) =>
                {
                    if (context.Request.Method.ToUpper() != "PUT")
                    {
                        context.Response.StatusCode = 404;
                        return;
                    }
                    var authenticateResult = await context.AuthenticateAsync(AuthenticationProviderKey);
                    if (!authenticateResult.Succeeded)
                    {
                        context.Response.StatusCode = 401;
                        return;
                    }
                    if (authenticateResult.Principal.IsInRole("Admin"))
                    {
                        var configurationRepo =
                            context.RequestServices.GetRequiredService<IFileConfigurationRepository>();
                        var ocelotConfiguration = await configurationRepo.Get();
                        var logger = context.RequestServices.GetRequiredService<ILoggerFactory>().CreateLogger("OcelotConfiguration");
                        if (!ocelotConfiguration.IsError)
                        {
                            var internalConfigurationRepo = context.RequestServices.GetRequiredService<IInternalConfigurationRepository>();
                            var internalConfigurationCreator =
                                context.RequestServices.GetRequiredService<IInternalConfigurationCreator>();
                            var internalConfiguration = await internalConfigurationCreator.Create(ocelotConfiguration.Data);
                            if (!internalConfiguration.IsError)
                            {
                                internalConfigurationRepo.AddOrReplace(internalConfiguration.Data);
                                context.Response.StatusCode = 200;
                                return;
                            }
                            else
                            {
                                logger.LogError($"update ocelot configuration error, error in create ocelot internal configuration, error messages:{string.Join(", ", ocelotConfiguration.Errors)}");
                            }
                        }
                        else
                        {
                            logger.LogError($"update ocelot configuration error, error in get ocelot configuration from configurationRepo, error messages:{string.Join(", ", ocelotConfiguration.Errors)}");
                        }
                        context.Response.StatusCode = 500;
                    }
                    else
                    {
                        context.Response.StatusCode = 403;
                    }
                });
            });


Missing transit_enable_active_standby for transit gateway submodule

Hello,
I can't enable active-standby on Transit Gateway.
Docs: https://docs.aviatrix.com/documentation/v7.0/building-your-network/bgp-connection-settings.html#active-standby
I see module has only:
transit_enable_active_standby_preemptive
Setting this option to 'true' will still show Terraform plan to keep value of enable_active_standby as false and fail to deploy. See attached screen.

Can you add this property e.g. transit_enable_active_standby to pass it down to the module of transit gateway?

Sorry I just realized I did it on the same repo :(
I can't raise the Issue on the new one.

For some reason issues was disabled on that repo. Should be fixed. Please try again. Please include the controller/provider version you require this for.
Thanks,
Dennis


Don't work.

Install plugins in neovim + lua.
  use "nvim-treesitter/nvim-treesitter"
  use "windwp/nvim-ts-autotag"

Create a file tree-sitter.lua and include in init.lua
require 'nvim-treesitter.configs'.setup {
  -- A list of parser names, or "all"
  ensure_installed = { "lua" },
  -- Install parsers synchronously (only applied to `ensure_installed`)
  sync_install = false,

  autotag = {
    enable = true,
    filetypes = { "html", "xml", "php", "vue" },
  },

  highlight = {
    -- `false` will disable the whole extension
    enable = true,

    -- NOTE: these are the names of the parsers and not the filetype. (for example if you want to
    -- disable highlighting for the `tex` filetype, you need to include `latex` in this list as this is
    -- the name of the parser)
    -- list of language that will be disabled
    disable = { "c", "rust" },

    -- Setting this to true will run `:h syntax` and tree-sitter at the same time.
    -- Set this to `true` if you depend on 'syntax' being enabled (like for indentation).
    -- Using this option may slow down your editor, and you may see some duplicate highlights.
    -- Instead of true it can also be a list of languages
    additional_vim_regex_highlighting = false,
  },
}

In html file i can't rename html tag.

not working for me either, no errors, using the default set up. I am on a new version of NeoVim though.
neovim: NVIM v0.8.0-dev+406-g502f03fc0
windwp/nvim-ts-autotag: latest master

Same here.

Have you ran :TSInstall html?

Have you ran :TSInstall html?

@YoungeonLee I have, but still the same.
I'm trying to run on LunarVim.
$ lvim -v
NVIM v0.7.2
Build type: Release
LuaJIT 2.1.0-beta3
Compiled by<EMAIL_ADDRESS>

@danilobjr Try adding
lvim.builtin.treesitter.autotag.enable = true

to your config. If that doesn't work, try running :TSEnable autotag.

lvim.builtin.treesitter.autotag.enable = true

@YoungeonLee This works like a charm now. Thank you so much! 🎉

require("nvim-treesitter.configs").setup({ 	ensure_installed = { 		"c", 		"c_sharp", 		"css", 		"go", 		"graphql", 		"html", 		"json", 		"http", 		"javascript", 		"lua", 		"markdown", 		"python", 		"rust", 		"typescript", 		"yaml", 		"bash", 		"comment", 		"java", 	}, 	sync_install = false, 	highlight = { 		enable = true, 		additional_vim_regex_highlighting = true, 	}, 	indent = { enable = true, disable = { "yaml" } }, 	rainbow = { 		enable = true, 		extended_mode = true, 		max_file_lines = nil, 	}, 	context_commentstring = { 		enable = true, 		enable_autocmd = false, 	}, 	autotag = { 		enable = true, 	}, })
This is my Treesitter setup and it only works in html files, not in jsx or tsx files

require("nvim-treesitter.configs").setup({ 	ensure_installed = { 		"c", 		"c_sharp", 		"css", 		"go", 		"graphql", 		"html", 		"json", 		"http", 		"javascript", 		"lua", 		"markdown", 		"python", 		"rust", 		"typescript", 		"yaml", 		"bash", 		"comment", 		"java", 	}, 	sync_install = false, 	highlight = { 		enable = true, 		additional_vim_regex_highlighting = true, 	}, 	indent = { enable = true, disable = { "yaml" } }, 	rainbow = { 		enable = true, 		extended_mode = true, 		max_file_lines = nil, 	}, 	context_commentstring = { 		enable = true, 		enable_autocmd = false, 	}, 	autotag = { 		enable = true, 	}, })
This is my setup and it only works in html files, no jsx or tsx files

That worked, thanks man!

@danilobjr Try adding
lvim.builtin.treesitter.autotag.enable = true

to your config. If that doesn't work, try running :TSEnable autotag.

That worked, thanks man!

I'm having the same problem. It just doesn't work. I tried in html, and tsx. Neither autotagging nor autorenaming
Here is the setup I tried with.

Here is my treesitter setup.

I'm on nvim 0.8

Finally, I figured out how to make it work.

Content of plugins.configs.treesitter
local options = {
  auto_install = true,
  ensure_installed = {
    "lua",
    "vim",
    "go",
    "toml",
    "css",
    "tsx",
    "css",
    "html",
    "lua"
  },
  highlight = {
    enable = true,
    use_languagetree = true,
  },
  autotag = {
    enable = true,
    filetypes = {
      'html', 'javascript', 'typescript', 'javascriptreact', 'typescriptreact', 'svelte', 'vue', 'tsx', 'jsx', 'rescript',
      'css', 'lua', 'xml', 'php', 'markdown'
    },
  },
  indent = { enable = true },
}

require('nvim-treesitter.configs').setup(options)

I enabled auto install lang parsers.
I am on neovim 0.8

@danilobjr Try adding
lvim.builtin.treesitter.autotag.enable = true

to your config. If that doesn't work, try running :TSEnable autotag.

works well with html, how could i do it with jsx?

@danilobjr Try adding
lvim.builtin.treesitter.autotag.enable = true

to your config. If that doesn't work, try running :TSEnable autotag.

Where do i have to put this line?

Same for me. nvim-ts-autotag closes tags, but doesn't rename

Yeah, this isn't working for me either. I followed the instructions exactly as they are in the readme and nothing happens.

same here

Finally, I figured out how to make it work.

Content of plugins.configs.treesitter
local options = {
  auto_install = true,
  ensure_installed = {
    "lua",
    "vim",
    "go",
    "toml",
    "css",
    "tsx",
    "css",
    "html",
    "lua"
  },
  highlight = {
    enable = true,
    use_languagetree = true,
  },
  autotag = {
    enable = true,
    filetypes = {
      'html', 'javascript', 'typescript', 'javascriptreact', 'typescriptreact', 'svelte', 'vue', 'tsx', 'jsx', 'rescript',
      'css', 'lua', 'xml', 'php', 'markdown'
    },
  },
  indent = { enable = true },
}

require('nvim-treesitter.configs').setup(options)

I enabled auto install lang parsers.
I am on neovim 0.8

even tried this but nothing

it's sad, this plugin doesn't documented properly on how to install.. i need to find open ticket just to figure out on how to install it properly

Many people, including myself, initially believe that simply configuring nvim-treesitter with the following code will make it work:
  autotag = {
    enable = true
  }

However, to ensure it functions correctly, you also need to install the package using your Package Manager.
In my case, using NvChad and Lazy, the configuration should be:
{
    "nvim-treesitter/nvim-treesitter",
    opts = overrides.treesitter,
  },
  {
    "windwp/nvim-ts-autotag",
    dependencies = "nvim-treesitter/nvim-treesitter",
    config = function ()
      require('nvim-ts-autotag').setup({
        -- your config
      })
    end,
    lazy = true,
    event = "VeryLazy"
  },

It would be helpful to include this information in the documentation.

For me, I have to disable alvan/vim-closetag plugin to make this plug-in work.

This worked thank you, however i still have to manually enable it through TSEnable autotag any ideas on how to circumvent that?

I'm using lazy.nvim.
I could make it work on HTML files. But, it didn't work on ERB(Ruby template language)
Note the different attempts by using embedded_template, erb, and eruby.
  {
    'nvim-treesitter/nvim-treesitter',
    build = function()
      require("nvim-treesitter.install").update({ with_sync = true })
    end,
    dependencies = {
      "RRethy/nvim-treesitter-endwise", -- Needed to prevent treesitter ident issue with Ruby: https://github.com/tree-sitter/tree-sitter-ruby/issues/230#issuecomment-1312403487
      'windwp/nvim-ts-autotag'
    },
    config = function()
      require'nvim-treesitter.configs'.setup {
        ensure_installed = { "ruby", "html", "embedded_template", "css", "scss", "javascript" },
        highlight = {
          disable = { "lua" },
          enable  = { "ruby", "html", "embedded_template", "eruby", "css", "scss", "javascript" }
        },
        additional_vim_regex_highlighting = false,
        endwise = {
          enable = true,
        },
        autotag = {
          enable = true,
          filetypes = { "html" , "xml", "eruby", "erb", "embedded_template" },
        }
      }
    end
  },

I'm using lazy.nvim. I could make it work on HTML files. But, it didn't work on ERB(Ruby template language)...

If my tests are correct, this PR https://github.com/windwp/nvim-ts-autotag/pull/104 fixed the issue for eruby files.
I need to config it separately, this way:
  {
    'windwp/nvim-ts-autotag',
    config = function()
      require('nvim-ts-autotag').setup({
        filetypes = { "html" , "xml", "eruby", "embedded_template" }
      })
    end
  }

https://user-images.githubusercontent.com/97436/235331284-20b79b9e-c533-4a07-9334-9deeeaecde10.mov

Turn out, it missing the tsx module for treesitting for my case, make sure you have it installed by
:TSInstall tsx

Many people, including myself, initially believe that simply configuring nvim-treesitter with the following code will make it work:
  autotag = {
    enable = true
  }

However, to ensure it functions correctly, you also need to install the package using your Package Manager.
In my case, using NvChad and Lazy, the configuration should be:
{
    "nvim-treesitter/nvim-treesitter",
    opts = overrides.treesitter,
  },
  {
    "windwp/nvim-ts-autotag",
    dependencies = "nvim-treesitter/nvim-treesitter",
    config = function ()
      require('nvim-ts-autotag').setup({
        -- your config
      })
    end,
    lazy = true,
    event = "VeryLazy"
  },

It would be helpful to include this information in the documentation.

@hvquy001 if you would not mind, I would like to update README using your information. This will help in proper installation. I myself struggle with the installation process until found your comment. Thanks

Many people, including myself, initially believe that simply configuring nvim-treesitter with the following code will make it work:
  autotag = {
    enable = true
  }

However, to ensure it functions correctly, you also need to install the package using your Package Manager.
In my case, using NvChad and Lazy, the configuration should be:
{
    "nvim-treesitter/nvim-treesitter",
    opts = overrides.treesitter,
  },
  {
    "windwp/nvim-ts-autotag",
    dependencies = "nvim-treesitter/nvim-treesitter",
    config = function ()
      require('nvim-ts-autotag').setup({
        -- your config
      })
    end,
    lazy = true,
    event = "VeryLazy"
  },

It would be helpful to include this information in the documentation.

@hvquy001 if you would not mind, I would like to update README using your information. This will help in proper installation. I myself struggle with the installation process until found your comment. Thanks

Thank you for posting this. I got this to work immediately with lazy.nvim using this config.

This worked for me as well.
Something this crucial should be documented imo...

Hey there!
I have autotag = { enable = true, } in my treesitter config, but it works only after I run :TSEnable autotag after starting nvim.
How to enable it automatically?
Thanks!

This config worked for me by throwing it in my packer.lua:
use {         'windwp/nvim-ts-autotag',         config = function()             require('nvim-ts-autotag').setup({                 filetypes = { "html", "javascript", "javascriptreact", "typescriptreact"}             })

I'm facing the autotag issue in html, but it only happens when script tag is the buffer, weird behavior.

For me auto tag doesn't work in .html files, but it works in .ts files. haven't found a solution.
I have tried the proposed solution which worked for some here, but it doesn't work in my case.

I am using lazy vim
It does not work for xml files for me.
			ensure_installed = { "c", "query", "vimdoc", "vim", "lua", "xml", "javascript", "typescript", "css", "java", "html", "python", "vue" }, 			autotag = { 				enable = true, 				enable_rename = true, 				enable_close = true, 				enable_close_on_slash = true, 				filetypes = { "html", "xml", "vue", "typescript" }, 			},

Mine doesn't work yet,
custom/plugins.lua
...
{
    "windwp/nvim-ts-autotag",
    ft = {
      "javascript", "typescript", 'javascriptreact', 'typescriptreact'
    },
    config = function()
      require('nvim-ts-autotag').setup()
    end,
    lazy = true,
    event = "VeryLazy"
  },
  {
    "nvim-treesitter/nvim-treesitter",
    opts = function()
      opts = require "plugins.configs.treesitter"
      opts.ensure_installed = {
        "lua", "javascript", "typescript", "jsx", "tsx", "css", "ts", "js"
      }
      return opts
    end
  }
...

plugins/configs/treesitter.lua
local options = {
  ensure_installed = { "lua", "vim", "vimdoc" },

  highlight = {
    enable = true,
    use_languagetree = true,
  },

  indent = { enable = true },
  autotag = { enable = true },
}

return options

Please help, Thanks.

I managed to get it work inspired by https://github.com/windwp/nvim-ts-autotag/issues/64#issuecomment-1509722026
This config is working for me using NvChad and Lazy:
  {
    "nvim-treesitter/nvim-treesitter",
      opts = {
        auto_install = true,
        autotag = {
           enable = true,
           filetypes = {
            'html', 'javascript', 'typescript', 'svelte', 'vue', 'tsx', 'jsx', 'rescript',
            'css', 'lua', 'xml', 'php', 'markdown'
           },
        },
        indent = { enable = true },
        ensure_installed = {
           -- defaults
          "vim",
          "lua",
          "vimdoc",

          -- web dev
          "html",
          "css",
          "javascript",
          "typescript",
          "tsx",
          "astro",
          "vue",
          "svelte",
          "markdown",
          "markdown_inline",
          "json",
          "scss",
          "yaml"
        }
      }
    },
  },

  {
    "windwp/nvim-ts-autotag",
    dependencies = "nvim-treesitter/nvim-treesitter",
    config = function ()
      require('nvim-ts-autotag').setup()
    end,
    lazy = true,
    event = "VeryLazy"
  },

Mine isn't working with markdown, too.
local status_ok, configs = pcall(require, "nvim-treesitter.configs")
if not status_ok then
    return
end

local autotag_filetypes = {
    'html', 'javascript', 'typescript', 'javascriptreact', 'typescriptreact', 'svelte', 'vue', 'tsx', 'jsx', 'rescript',
    'xml',
    'php',
    'markdown',
    'glimmer','handlebars','hbs'
}

configs.setup {
    ensure_installed = { "c", "cpp", "lua", "python", "c_sharp", "typescript", "javascript", "markdown", "scss", "fish", "vim" },
    sync_install = false,
    ignore_install = { "" }, -- List of parsers to ignore installing
    autopairs = {
        enable = true,
    },
    autotag = {
        enable = true,
        filetypes = autotag_filetypes,
    },
    highlight = {
        enable = true, -- false will disable the whole extension
        disable = { "" }, -- list of language that will be disabled
        additional_vim_regex_highlighting = false,
    },
    indent = { enable = true, disable = { "yaml" } },
    rainbow = {
        enable = true,
        extended_mode = true, -- Also highlight non-bracket delimiters like html tags, boolean or table: lang -> boolean
        max_file_lines = nil, -- Do not enable for files with more than n lines, int
    }
}

Many people, including myself, initially believe that simply configuring nvim-treesitter with the following code will make it work:
  autotag = {
    enable = true
  }

However, to ensure it functions correctly, you also need to install the package using your Package Manager.
In my case, using NvChad and Lazy, the configuration should be:
{
    "nvim-treesitter/nvim-treesitter",
    opts = overrides.treesitter,
  },
  {
    "windwp/nvim-ts-autotag",
    dependencies = "nvim-treesitter/nvim-treesitter",
    config = function ()
      require('nvim-ts-autotag').setup({
        -- your config
      })
    end,
    lazy = true,
    event = "VeryLazy"
  },

It would be helpful to include this information in the documentation.

I am using vanilla NeoVim with lazy package manager, ans this does not work for me
(Stable) NVIM v0.9.6-dev-0ef2718  - Released: 19th Jan, 2024

Hey folks, I highly encourage you to check out the new changes on main.
This plugin will not work for certain filetypes unless you have their associated treesitter parser installed.
nvim-treesitter does include an auto_install flag in its config to automatically install parsers for known filetypes. Recommend you give that a shot or install the parsers as needed.
@windwp am I ok to close this issue? Been open since 2022 and the core solution is to install the correct parsers (or let nvim-treesitter auto install them).

We can close it. The old setting configuration will not work with the current version, so it's better to open a new issue.

Many people, including myself, initially believe that simply configuring nvim-treesitter with the following code will make it work:
  autotag = {
    enable = true
  }

However, to ensure it functions correctly, you also need to install the package using your Package Manager.
In my case, using NvChad and Lazy, the configuration should be:
{
    "nvim-treesitter/nvim-treesitter",
    opts = overrides.treesitter,
  },
  {
    "windwp/nvim-ts-autotag",
    dependencies = "nvim-treesitter/nvim-treesitter",
    config = function ()
      require('nvim-ts-autotag').setup({
        -- your config
      })
    end,
    lazy = true,
    event = "VeryLazy"
  },

It would be helpful to include this information in the documentation.

Thanks a lot! What's missing in this answer is to verify if your target language is in ensure_installed (I was missing html):

There's now a deprecation message when adding autotag inside treesitter.setup.
Correct usage is to add import nvim-ts-autotag inside the treesitter config:
require('nvim-ts-autotag').setup({
	enable = true,
	filetypes = { "html", "xml", "tsx" },
})

My full working setup:
return {
	"nvim-treesitter/nvim-treesitter",
	event = { "BufReadPre", "BufNewFile" },
	build = ":TSUpdate",
	dependencies = {
		"windwp/nvim-ts-autotag",
	},
	config = function()
		-- import nvim-treesitter plugin
		local treesitter = require("nvim-treesitter.configs")

		require('nvim-ts-autotag').setup({
			enable = true,
			filetypes = { "html", "xml", "tsx" },
		})

		-- configure treesitter
		treesitter.setup({ -- enable syntax highlighting
			highlight = {
				enable = true,
			},
			-- enable indentation
			indent = { enable = true },

			-- ensure these language parsers are installed
			ensure_installed = {
				"json", "html", -- add others here
			},
			incremental_selection = {
				enable = true,
				keymaps = {
					init_selection = "<C-space>",
					node_incremental = "<C-space>",
					scope_incremental = false,
					node_decremental = "<bs>",
				},
			},
		})
	end,
}


Getting Could not extract template events Warning when trying to squiggle

We ran the lambda burn in experiment and ran the Metrichor analysis which seems to have completed successfully.
When trying to run squiggle we get the following warning: Could not extract template events for read...
(same warning for all of the reads).
Conversion to fasta and fastq works fine.
Has anyone seen this warning?
Is there a way to get a more verbose report regarding this issue, to see if there is something wrong with the reads?

I got this error as well, it seems the data might be corrupt, curiously I was able to convert the data to fastq

Apparently the file structure changed in the latest version.
We did the following changes in Fast5File.py to fix it:
fastq_paths = {'template' : '/Analyses/Basecall_1D_000/BaseCalled_template',
'complement' : '/Analyses/Basecall_1D_000/BaseCalled_complement',
'twodirections' : '/Analyses/Basecall_2D_000/BaseCalled_2D'}
We also got an email from the company telling us it SHOULD work if we clone the latest version from github...

Yes, this should be fine with the version on github. We will be cutting a new formal release soon.


Python examples: please clarify which kinesis connector JAR should be used

In this codebase, the JAR listed in several application properties for python examples is one of:

amazon-kinesis-connector-flink-2.0.0.jar
flink-sql-connector-kinesis_2.12-1.13.2.jar
amazon-kinesis-sql-connector-flink-2.0.3.jar
and possibly other variations

For example: https://github.com/aws-samples/amazon-kinesis-data-analytics-examples/blob/master/python/S3Sink/application_properties.json
In the AWS documentation however, the JAR mentioned is flink-sql-connector-kinesis_2.12-1.13.1.jar in places, and also the 1.13.2 version within the same article
Located here: https://docs.aws.amazon.com/kinesisanalytics/latest/java/gs-python-createapp.html
Please clarify which of these dependencies should be included in the uploaded ZIP file

Hello!
You should use flink-sql-connector-kinesis_2.12-1.13.2.jar connector if you're planning to deploy it as a Flink 1.13 application (AWS documentation is correct). amazon-kinesis-connector-flink-2.0.0.jar connector (and later versions of it) are used for Flink 1.11 and DataStreamAPI, but python apps use TableAPI. amazon-kinesis-sql-connector-flink-2.0.3.jar is used for TableAPI and Flink 1.11.
Our python code examples still use a connector for Flink 1.11. We're planning to update examples soon together with Flink 1.15 release.


feat(Controls): add Released event

Add Released event to VRTK_Button.cs
Add OnReleased Button3DEvent to VRTK_Button_UnityEvents.cs

You will have to squash those to changes ot @thestonefox will refuse to merge : p

Sure I will :)

@bddckr I've squashed the two commits I made. That overrides the old review (and comments related to it). Should I close the pull request and reopen it, or it's ok to have it like this?

@Backer-Sultan You're fine! This is exactly how you should do it 😄