Documentation mentions the possibility of linking boost in as a static or dynamic library, but offers practically zero details on how to do so.

Problem
The overview mentions the possibility of linking boost::json in as a static or dynamic library, but offers practically zero details on how to do so. I've heard that you just chuck -lboost_system at your linker when you're building the executable, but this rumor is not confirmed by any of the documentation, and didn't seem to work for me (see error below). Do I have to build the library? Should I have installed boost with my package manager instead of getting the latest version directly from the boost website? Perhaps detailed instructions on how to build and link boost::json are outside the scope of the overview, but it would be helpful if there were a link to something that explained how to do it.
Steps necessary to reproduce the problem
Visit the boost::json docs overview.
All relevant compiler information
Platform/Architecture: 64-bit Linux Mint 21 (Cinnamon)
Compiler: g++ 11.3
Error output: /usr/bin/ld: cannot find -lboost_system: No such file or directory

detailed instructions on how to build and link boost::json are outside the scope of the overview

Yes, because there are many different ways to do this, and many different toolchains. But the easiest thing to do is just add this line to ONE of your new or existing .cpp files:
#include <boost/json/src.hpp>

and then you're done, no need to fiddle with building libraries or passing command line options. This is in the docs:
https://www.boost.org/doc/libs/1_80_0/libs/json/doc/html/json/overview.html#json.overview.requirements.header_only
As for getting Boost, that is also documented:
https://www.boost.org/doc/libs/1_80_0/more/getting_started/index.html

That's what I was using as a workaround, but if the option is presented, I should at least be given a place to start searching for answers. I don't even know what to pass to my linker besides a rumor and I don't even know whether or not I have to build the library.

Yeah, information on how to link Boost libraries is centralized. Rather than duplicating the same information for each library. You can also put together your own static library using your own build scripts by including the src.hpp file. This is very useful if for example you are not using b2 or cmake.

The information on how to build Boost is presented in the Boost documentation (https://www.boost.org/doc/libs/1_80_0/more/getting_started/unix-variants.html).
Boost.JSON assumes the reader of its documentation is proficient enough in C++ to make programs. This includes knowledge of how linking works in C++ and how that user's compiler and linker is invoked and how to control their behaviour (e.g. compiler/linker flags). Assuming otherwise would be insanity.
We mention that the library can be built as a static and shared library, because that's not true for some libraries. We also mention that the library can be used without linking (header-only) and describe how to do it, because the trick is specific to this library, and not a feature of compilers or linkers.

I've heard that you just chuck -lboost_system at your linker when you're building the executable, but this rumor is not confirmed by any of the documentation, and didn't seem to work for me...

This does work for me, because I've built Boost in a certain way. This may not work for you if you've built it in a certain different way. It depends on a million different things, including what linker you are using, because I assure you msvc does not use -l flag.

Do I have to build the library? Should I have installed boost with my package manager instead of getting the latest version directly from the boost website?

Wait, did you just download Boost sources and did not build Boost? What are you linking to then?
To summarize:

Getting started with Boost docs are: https://www.boost.org/doc/libs/1_80_0/more/getting_started/index.html.
Compiler and linker docs are out  out of scope.
C++ linking model docs are out of scope.

Why would you assume I'm on msvc? Why would you assume that I don't know how a linker works? All I ask is that https://www.boost.org/doc/libs/1_80_0/more/getting_started/index.html is included in the boost::json getting started page.
"Boost.JSON assumes the reader of its documentation is proficient enough in C++ to make programs." Elitism is alive and well in every facet of C++ it seems.

All I ask is that https://www.boost.org/doc/libs/1_80_0/more/getting_started/index.html is included in the boost::json getting started page.

Yeah, linking to that page is probably a good idea. I only didn't do it because I'm not sure how to form the proper "green link" (one that automatically links to the same version).

"Boost.JSON assumes the reader of its documentation is proficient enough in C++ to make programs."

I mean... you're not entirely wrong here but I don't think its fair to call this elitism. If every library developer had to solve every cross-cutting concern (like informing users how to link programs for every toolchain) that would produce a combinatorial explosion of duplicated effort.  That said, we should add the link :)

I took that quote as elitisim because @grisumbras clearly did not even read the post, since he assumed I use msvc…

I did not assume that, you did not read what my response very well. MSVC was only brought up as an example of a toolset that doesn't use the flag -l, to illuminate the fact that listing specific falgs for specific compilers and linkers is not very useful.
What I did assume is that you don't know what linking is, because you write

The overview mentions the possibility of linking boost::json in as a static or dynamic library

And then you write

Do I have to build the library?

Yes, in order to link to a library you need to build it. Otherwise what would you specify when you invoke the linker?
In general, I have a negative view of issues that complain about documentation quality, while simultaneously display lack of proper understanding of the things discussed in that documentation. If you'd phrased your issue as a request for help instead, I would have handled it differently.
Anyways, I do admit that linking to "Getting Started with Boost" will be an improvement. Did it help you link to the library @mcmuffin6o?

I think

Do I have to build the library?
was asking if the Boost distribution comes with binaries (it doesn't).

Yes, in order to link to a library you need to build it. Otherwise what would you specify when you invoke the linker?

@vinniefalco seems to have answered this question by understanding that some libraries come with binaries. I can't see how you accuse me of not understanding enough about building/linking libraries without understanding the above yourself @grisumbras:

In general, I have a negative view of issues that complain about documentation quality, while simultaneously display lack of proper understanding of the things discussed in that documentation.

I don't see how my particular criticism of the docs could be considered unfounded @grisumbras, especially since it seems like everyone agrees that adding a link to "Getting Started with Boost" closes this issue (even though you closed it before addressing my suggestion to do so).
It also doesn't help when people that don't have much experience building and linking libraries get this as their first web search hit: https://stackoverflow.com/questions/10262742/linking-boost-libraries
(As you may notice, I added the Boost Getting Started guide so that others don't come here to open similar issues.)

If you'd phrased your issue as a request for help instead, I would have handled it differently.

I think your best approach would have been to not handle the issue at all.
Your peers did a fantastic job of handling the issue. If this thread was purged of all of your input, we would have settled on the agreed-upon solution before closing the issue, instead of after. Because of your aggressive approach towards pruning unfounded issues, I have wasted hours of my time and some of yours just trying to establish validity for my issue when it was recognized almost immediately by the others after a short, productive exchange.

Anyways, I do admit that linking to "Getting Started with Boost" will be an improvement. Did it help you link to the library @mcmuffin6o?

Nope, I gave up after seeing how much of a fight was involved in even getting to that point. I've wasted too much time on this thread and I just need to finish my research. I had been using the header-only approach until I ran into multiple-inclusion issues, at which point I wanted to link the library and instead include a proper header that only had what the compiler needed to know about the types and functions of the library. I guess I should also mention that it was difficult to figure out what that header file was until I checked the examples. This could just be on me, but I never noticed any instructions for what header to include in source files when you have multiple source files using the library.

To link without having to build a separate library, add this line in exactly ONE .cpp file:
#include <boost/json/src.hpp>

our peers did a fantastic job of handling the issue.

I also have the benefit of 30+ years of experience :) Interacting with other developers diplomatically is a skill...


Running on Archlinux - python errror

when trying to run on archlinux "python bee.py"
error appears

File "bee.py", line 20
print '\n'
^
SyntaxError: Missing parentheses in call to 'print'. Did you mean print(int '\n')?

SOLVED
when installed python with different versions u need to use:

python2 bee.py


kpt live does not support YAML merging arrays

Hi,
I am trying to apply my kpt package (kpt live apply) and getting errror error: json: unsupported type: map[interface {}]interface {} for some of my manifests. For example I am getting this when I include following manifest into my KPT package: https://github.com/knative/eventing/releases/download/knative-v1.9.7/eventing-crds.yaml
I am using kpt 1.0.0-beta.29
Regards,
Premek

Thanks for filing the issue @remeq
I think the issue is that kpt live apply cannot support merging arrays in YAML.
In the CRD yaml file, the CustomResourceDefinition  pingsources.sources.knative.dev has the following lines that triggers the problem
spec:
  group: sources.knative.dev
  versions:
    - &version # HERE
      name: v1beta2
      served: true
      storage: false
      ... (IGNORED)
    - !!merge <<: *version # HERE
      name: v1
      served: true
      storage: true

@mortent This seems to be a nice feature to add to kpt live. I'm thinking of marking this as "first good issue", WDYT?

I would like to work on this issue.


Question: Why some annotations in stubs are different from the inline type annotations of the original packages?

Some annotations in python type stubs used by VSCode are a little different from the inline type annotations of the original packages.
Example:

The original matplotlib.pyplot.plot function has the following inline type annotation in its signature:
def plot(*args, scalex=True, scaley=True, data=None, **kwargs):

But the stub file pyplot.pyi (used by Pylance) has the following signature, with type annotations, for the same function.
def plot(*args: Any, scalex: bool = ..., scaley: bool = ..., data: Optional[Any] = ..., **kwargs: Any) -> List[Line2D]: ...

The last expression above is used by VS Code in autocompletions.
Some noted differences improves the usability, like the returned type List[Line2D], not present in the original.
But some of then seems not be right, like the default values of scalex and scaley which are True in the original, and not defined in the stub. I would like to know why is that.
Also, I would like to take this opportunity to ask: what means the Ellipsis ... in default values of python functions?
The original PEP documentation does not made it clear.
I apologize if this is not the right place to ask these questions. I couldn't find a more suitable.

The matplotlib sources don't contain any type annotations. Consider the function def plot(*args, scalex=True, scaley=True, data=None, **kwargs):. None of the parameters have declared types, and there is no return type annotation specified. The type stub provides types for each of the parameters and supplies a return type.
In stubs, the ellipsis is intended to indicate "some value". From the perspective of a type checker, the actual value of the default value isn't important.
To quote PEP 484:

In stubs it may be useful to declare an argument as having a default without specifying the actual default value. For example:

def foo(x: AnyStr, y: AnyStr = ...) -> AnyStr: ...

What should the default value look like? Any of the options "", b"" or None fails to satisfy the type constraint. In such cases the default value may be specified as a literal ellipsis, i.e. the above example is literally what you would write.

Most type stubs follow the convention spelled out in PEP 484. From the perspective of a type checker, this makes sense. However, type stubs are now used in ways that were not contemplated by the original authors of PEP 484. Namely, they're used for completion suggestions and tooltips during editing. From this perspective, it's useful to retain the default argument value in the signature. We've been advocating that providers of type stubs include these default argument values.
This documentation provides guidance to library authors. It says:

In many existing type stubs (such as those found in typeshed), default parameter values are replaced with with “...” and all docstrings are removed. We recommend that default values and docstrings remain within the type stub file so language servers can display this information to developers.

Most existing type stubs don't follow this guidance today. It will take time.

Thankyou very much for the quick reply @erictraut.
Sorry, I've understand it wrong: there are really no type annotation in that original example.
I was concerned about the function signature with default values, not followed entirely in the stub, which you explained perfectly.
Thankyou.

Unless I'm mistaken, this is a question issue that's been answered; this is just how stubs are.


"Invoke with caller credentials" option

Is it possible to specify this option in Swagger using the x-amazon-apigateway-auth and x-amazon-apigateway-integration extensions?

You can use this:
x-amazon-apigateway-integration:
type: aws
uri:
'arn:aws:apigateway:us-east-1:lambda:path/2015-03-31/functions/arn:aws:lambda:us-east-1:441276146445:function:users_subscriptions_get/invocations'
credentials: 'arn:aws:iam:::user/'
This will execute your Lambda function with the Users AWS Credentials
ᐧ
On Tue, Dec 15, 2015 at 5:38 AM, koryshev<EMAIL_ADDRESS>wrote:

Is it possible to specify this option in Swagger using the
x-amazon-apigateway-auth and x-amazon-apigateway-integration extensions?
[image: capture]
https://camo.githubusercontent.com/5be7a77ba72efefab3cc5a0831cf696a65d45590/68747470733a2f2f636c6f756467697468756275736572636f6e74656e74636f6d2f6173736574732f31343037303037302f31313830383334352f66613362336633342d613333302d313165352d393462382d616565396636356138386530504e47
—
Reply to this email directly or view it on GitHub
https://github.com/awslabs/aws-apigateway-importer/issues/125.

--
Nicolas Menciere
Co-Founder and CTO
Sport Archive Inc.

Api Gateway team here, @koxon is right. The credentials field would be 'arn:aws:iam:::user/' to enable caller credentials. Using caller credentials makes the most sense in the context of an app that uses Cognito to federate users, since Lambda can access the Cognito Identity context.

talking about this.
I have trouble signing an S3 URL with the User credentials.
The URL looks good but I get permission denied when accessing it.
Do I need to add a special policy to have my Cognito user sign S3 URLs?
I wonder if Ryan or other AWS members have an idea?
thanks
@koxon
ᐧ
On Tue, Dec 15, 2015 at 2:46 PM, Jack Kohn<EMAIL_ADDRESS>wrote:

Api Gateway team here, @koxon https://github.com/koxon is right. The
credentials field would be arn:aws:iam:::user/ to enable caller
credentials. Using caller credentials makes the most sense in the context
of an app that uses Cognito to federate users, since Lambda can access the
Cognito Identity context.
—
Reply to this email directly or view it on GitHub
https://github.com/awslabs/aws-apigateway-importer/issues/125#issuecomment-164873191
.

--
Nicolas Menciere
Co-Founder and CTO
Sport Archive Inc.

When using "caller credentials", the credentials you used to sign the request to your API Gateway API will also need permissions to the underlying service. In your case this would mean making sure you include permissions to your S3 bucket and the keys within it.

Thanks Bob.
That's what I did before asking for help. I added to my two Cognito roles:
s3:GetObject:*
So they should be able to Get any assets in my buckets.
As follow:
    {
        "Effect": "Allow",
        "Action": [
            "s3:ListBucket",
            "s3:GetObject"
        ],
        "Resource": [
            "*"
        ]
    }

It still doesn't do it though. The URL get signed but I get access denied.
ᐧ
On Tue, Dec 15, 2015 at 4:36 PM, Bob Kinney<EMAIL_ADDRESS>wrote:

When using "caller credentials", the credentials you used to sign the
request to your API Gateway API will also need permissions to the
underlying service. In your case this would mean making sure you include
permissions to your S3 bucket and the keys within it.
—
Reply to this email directly or view it on GitHub
https://github.com/awslabs/aws-apigateway-importer/issues/125#issuecomment-164904770
.

--
Nicolas Menciere
Co-Founder and CTO
Sport Archive Inc.

I get a signature as follow using the Temporary Cognito credentials:
https://sportarchive-dev-orgs.s3.amazonaws.com/uploads/mencie/202615269565aa21b5b7ee4.62805143?AWSAccessKeyId=ASIAIV64TMSF5OYAVNHQ&Expires=1465780800&x-amz-security-token=AQoDYXdzEE8awAKtHku9TK7nH0VComjDt7Dp0KmC%2B9tqFLMuTSzUfGecpd70aKU2UoUe%2BUFLnOr%2BVs4WIJa2zbtHLtGCgN%2BV83gQE%2FLNIL67NOnRWmnuMfOU1w9HbgRiymRhcjO39GMOAD95ywY7TmmXR8SvxUDTlokAqhMTqtj0nrbhRxmO%2F0mrew4xxxxxxxmXssqhokpXPYudWcULHjm8WeolRNEnO%2FfRIqNiwwC1pwNF9%2FaSdxOXNKdtF4we3L1Z94y3wT9EMLvgTWPpZpQUnWxJQdAxJsvFiBE6%2BwNZKEREyzelgJdKE7aYF0O2wEV%2F85%2FS8GVemk7YwHeSOOnQZ0Mg288qu%2BYOuc1Y%2F2aciAXjJ%2FwIq91QDwaJMIBfrt1srKwDqiYY1%2B51UZGEVp0MK2EMPsO9v3n2dPsJC9L3lgJWvTEUGdrFGyCKlcKzBQ%3D%3D&Signature=%2BudK6wTzikOli1JLOzV1bhbmPWA%3D
When I sign the with my local credentials I get this which works:
https://sportarchive-dev-orgs.s3.amazonaws.com/uploads/SteveTest/689815528565d98d5b01a83.52912256?AWSAccessKeyId=xxxxxxxxxxxxxxxxxxxxx&Expires=1465780857&Signature=LiObltpJl6R6TJDDRd6plNaRyb0%3D
"
ᐧ
On Tue, Dec 15, 2015 at 8:18 PM, Nicolas Menciere<EMAIL_ADDRESS>
wrote:

Thanks Bob.
That's what I did before asking for help. I added to my two Cognito roles:
s3:GetObject:*
So they should be able to Get any assets in my buckets.
As follow:
    {
        "Effect": "Allow",
        "Action": [
            "s3:ListBucket",
            "s3:GetObject"
        ],
        "Resource": [
            "*"
        ]
    }

It still doesn't do it though. The URL get signed but I get access denied.
ᐧ
On Tue, Dec 15, 2015 at 4:36 PM, Bob Kinney<EMAIL_ADDRESS>wrote:

When using "caller credentials", the credentials you used to sign the
request to your API Gateway API will also need permissions to the
underlying service. In your case this would mean making sure you include
permissions to your S3 bucket and the keys within it.
—
Reply to this email directly or view it on GitHub
https://github.com/awslabs/aws-apigateway-importer/issues/125#issuecomment-164904770
.

--
Nicolas Menciere
Co-Founder and CTO
Sport Archive Inc.

--
Nicolas Menciere
Co-Founder and CTO
Sport Archive Inc.

@koxon This looks like you are signing S3 requests, not API Gateway requests. If you can post more information about your issues in the AWS forums (the Amazon Cognito forums would be a good place to start) the engineers watching that forum will be able to inspect your resources.

right. I will thank you.
ᐧ
On Wed, Dec 16, 2015 at 6:17 PM, Bob Kinney<EMAIL_ADDRESS>wrote:

@koxon https://github.com/koxon This looks like you are signing S3
requests, not API Gateway requests. If you can post more information about
your issues in the AWS forums (the Amazon Cognito forums
https://forums.aws.amazon.com/forum.jspa?forumID=173 would be a good
place to start) the engineers watching that forum will be able to inspect
your resources.
—
Reply to this email directly or view it on GitHub
https://github.com/awslabs/aws-apigateway-importer/issues/125#issuecomment-165280258
.

--
Nicolas Menciere
Co-Founder and CTO
Sport Archive Inc.

I may be misunderstanding here, but wouldn't using API Gateway and invoking with caller credentials basically allow the user to access your AWS resources without going through API Gateway? If that's what you're looking for that's fine, but I don't want to give my Cognito roles access to DynamoDB, for example.

Invoking with caller credentials is simply a 'passthrough' of the request from the client's perspective. Using Cognito, you could have your clients get their Cognito temporary credentials and invoke a Lambda function in your account. The function would have access to the Cognito Identity context. The function is your AWS resource, but you control the permissions of the role associated with the Cognito creds. Cross-account access is not allowed when using the 'caller credentials' option; the API is still restricted to roles in your account, including any Cognito-managed roles.

Closing. Please reopen if still experiencing issues


Bug rendering paragraph inside unordered list with po2md

Fixed in master

[x] Maybe the same bug happens with ordered lists, check that.

Fixed in v0.3.34.


test: behaviors-message_on_lock_failure (2024-03-07 16:55:18.248980+00:00)

automatic test cleanup


Add dataset badges

Wanted to add the hugginface emoji as logo, but did not figure out how to do it. Should prob not delay efforts because of that 😆


Automated Package Upgrade

:tada: This PR is included in version 25.3.518 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Ensure having all required metadata attributes

Length
Description (including a warning on non-ascii characters)
image_url
Short Name: true/false, if it is a secondary domain. Example

[Optional]

Created date: date, the first time the name was minted
Registered date: date, if it is a secondary domain. The last time the name was registered
Expiration date: date, if it is a secondary domain


Paste connections

Fixes #2584.
Depends on #2984.
:eyes: @bhousel

Looks good!  I found #3008 while testing, but that is a separate issue.

merged as a853615


Interceptor chain should be run before the request is checked for method and body requirements

Since I can use Interceptors to completely change the request, it is kind of odd that Builder.method(String method, RequestBody body) is run before the chain of Interceptors. I can quite easily do some processing in an interceptor that either:

changes an invalid request into a valid one
changes a valid request into an invalid one

It seems to me that this check should be executed after the Interceptor chain has had its chance to run and fix/break things.

The request needs to be valid at each step.

The request needs to be valid at each step.


cmd/compile, cmd/internal/obj/ppc64: generate the likely/unlikely bit on branches for ppc64x

Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (go version)?
go version devel +375092b Mon Sep 26 15:46:44 2016 +0000 linux/ppc64le
What operating system and processor architecture are you using (go env)?
Ubuntu 16.04
What did you do?
Perused generated ppc64x code.
What did you expect to see?
Branch likely flag set for many commonly generated if-then-else sequences when the 'then' block should rarely be taken.
What did you see instead?
I don't see the likely/unlikely flag set it by golang generated code except in asm files.
The asm9.go file has support to set the likely/unlikely flag but the branch asm opcodes don't currently have an operand combination which indicates when it should be done.
I plan to add support for an operand with the branch that indicates when to set likely/unlikely, then update some of the sequences that should have the flag set.  This includes morestack_noctxt in the prolog, and the runtime checks that result in panics once I figure out where those are.

cmd/compile/internal/ssa/block.go:Block has a branch prediction field (called Likely).
You can use that in cmd/compile/internal/ppc64/ssa.go to populate a branch Prog with the right data.
For amd64 we use Prog.From=={Const,0} for unlikely taken and {Const,1} for likely taken.  Use that encoding for PPC as well if it makes sense.
See cmd/compile/internal/amd64/ssa.go for an example of how to do that.

I will not be submitting a change for this in Go 1.8.  The performance testing I've done for this had mixed results and will require more investigation to determine if it is worth it.

I've done some investigation on this, setting the likely bit based on the end of block information.  However that does not always provide an improvement, it varies quite a bit and in many cases gets worse.  I have not investigated further to try and determine if the information provided is not dependable for ppc64x or if there is some other reason.
If I were to set this at all, I'd prefer to only set it in the obvious cases, such as when there is an if check for a panic condition and then the panic path marked as unlikely.  Not sure what the best way is to determine that.

Thanks for the research.  I've done the analysis in the past (other languages, other compilers) to do the "this will certainly fail, so it's certainly not a critical path" likeliness check, and I think we could do that here, too.
I have an item on my to-do list to write up a list of little useful projects, and that's one of them.
(Tentative list: improve spill location in register allocation; improve escape analysis w/ interprocedural use info for interface-typed call args; spec out loop unrolling within SSA form for both optimization and the reschedule check; this finer-grained "likely" information.  I think Keith has a similar list).

I'm going to close this. It looks like the cases I was concerned with are now marked with the correct likely flag.


[$250] Right clicking and “Copy Link” on a link produced https://new.expensify.com//r/0/NaN when pasted

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

This Issue has been divided in 2 parts, as it evolved while it was being discusses, the solution to both the situations is similar, and it would be easier to keep them in one GH.
1st Situation
Action Performed:

Send any link (e.g. Google.com) to a chat on web.
Right-click on the link to open the context menu.
Check that you see 2 option, Copy link and Copy URL to clipboard

Expected Result:
We should only display the Copy URL to clipboard option
Actual Result:
We show both options and it's confusing
2nd Situation

Add an attachement to a chat on web.
Right-click on the link to open the context menu.
Check that you see several options including Copy link and Copy to clipboard

Expected Result:
We should only Download, Mark as unread, Delete comment
Actual Result:
We show all of the above option, and it's confusing
Workaround:
unknown
Platform:

Where is this issue occurring?

Web
iOS
Android
Desktop App
Mobile Web

Version Number: 1.1.79-9
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @marcaaron
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1656523285065139
View all open jobs on GitHub

Oh that one is hilarious.
This one feels like it can be an external

Proposal:
https://github.com/Expensify/App/blob/f19a4d94870fdc96ea032d90217a03f9f5b46674/src/pages/home/report/ContextMenu/ContextMenuActions.js#L125-L132
Here, we have to use the same onPress function as we are using for copyURLToClipboard
https://github.com/Expensify/App/blob/f19a4d94870fdc96ea032d90217a03f9f5b46674/src/pages/home/report/ContextMenu/ContextMenuActions.js#L67-L70

-        onPress: (closePopover, {reportAction, reportID}) => {
-            Environment.getEnvironmentURL()
-                .then((environmentURL) => {
-                    const reportActionID = parseInt(lodashGet(reportAction, 'reportActionID'), 10);
-                    Clipboard.setString(`${environmentURL}/r/${reportID}/${reportActionID}`);
-                });
-            hideContextMenu(true, ReportActionComposeFocusManager.focus);
-        },

+        onPress: (closePopover, {selection}) => {
+            Clipboard.setString(selection);
+            hideContextMenu(true, ReportActionComposeFocusManager.focus);
+        },

also this still needs to get the Help Wanted label first.

@sketchydroide I misunderstood this issue, and sure will comment on proposal one the issue has Help Wanted label

@jayeshmangwani I don't think that is what we are looking for, the Copy link is not the link of the url for that we have Copy URL to clipboard. Copy link is a link of the chat comment itself. the entire line. Like if you want to share that post with someone else

In the issue, Copy Link should return a link when pasted, and you write that it is a link to a comment. It's a contradiction! Is this an error in the description of the issue or an incomplete description?

It seems yes, issue details are incorrect.
@Christinadobrzyn Could you please fix the steps.

Send any link (e.g. Google.com) to a chat on web.
Right-click on the link to open the context menu.
Select Copy link option.

Expected Result:
The copied link should be the correct link to the comment.
Actual Result:
Right-clicking on “Copy Link” on a link produced new.expensify.com//r/0/NaN when pasted.

Proposal:
The issue occurs because to generate link we need reportAction and reportID, none of which are passed to showContextMenu method in BaseAnchorForCommentsOnly. Lets fix that

We can obtain reportID from navigation state using already existing getReportID function and pass it to showContextMenu

ReportActionContextMenu.showContextMenu(
    Str.isValidEmail(this.props.displayName) ? ContextMenuActions.CONTEXT_MENU_TYPES.EMAIL : ContextMenuActions.CONTEXT_MENU_TYPES.LINK,
    event,
    this.props.href,
    lodashGet(linkRef, 'current'),
+   getReportID(this.props.navigation.state),
);

Getting reportAction is a bit harder, but we don't need the whole action, only it's id (reportActionID). We pass it from ReportActionItemMessage to ReportActionItemFragment

<ReportActionItemFragment
    key={`actionFragment-${props.action.sequenceNumber}-${index}`}
    fragment={fragment}
    isAttachment={props.action.isAttachment}
    attachmentInfo={props.action.attachmentInfo}
    loading={props.action.loading}
+   reportActionID={props.action.reportActionID}
/>

And then in ReportActionItemFragment's render method we need to check if html is anchor (if tag is a) and if it is, add reportActionID to html (the same principle we use to add data-expensify-preview-modal-disabled param to images). This is not a final code, we probably will need to implement Str.isAnchor method, but just to illustrate:

  if (props.fragment.html.startsWith('<a')) {
      props.fragment.html = props.fragment.html.replace('<a', `<a reportActionID=${props.reportActionID}`)
  }

Now that we've added reportActionID to html, we need to parse it in AnchorRenderer and pass it to AnchorForCommentsOnly. In AnchorRenderer.js

+ const reportActionID = htmlAttribs['reportactionid'];
return (
    <AnchorForCommentsOnly
        href={attrHref}
        isAuthTokenRequired={isAttachment}
        target={htmlAttribs.target || '_blank'}
        rel={htmlAttribs.rel || 'noopener noreferrer'}
        style={{...props.style, ...parentStyle}}
        key={props.key}
        displayName={displayName}
+       reportActionID={reportActionID}
    >

And we finally can use reportActionID in showContextMenu method

ReportActionContextMenu.showContextMenu(
    Str.isValidEmail(this.props.displayName) ? ContextMenuActions.CONTEXT_MENU_TYPES.EMAIL : ContextMenuActions.CONTEXT_MENU_TYPES.LINK,
    event,
    this.props.href,
    lodashGet(linkRef, 'current'),
+   getReportID(this.props.navigation.state),
+   {reportActionID: this.props.reportActionID}
);

Result:
https://user-images.githubusercontent.com/9059945/177003781-173e61ae-895d-476f-a984-6d0409994927.mp4

Thanks @parasharrajat updated the OP with clearer details as you mentioned here: https://github.com/Expensify/App/issues/9660#issuecomment-1172698634

Discussing here https://expensify.slack.com/archives/C02NK2DQWUX/p1656925799345049

Looking for other possible proposals that do not include HTML manipulation.

@roryabraham any thoughts? And can you advise on how we could disable the option to "Copy link" when we are right-clicking on a hyperlink?
I'm not sure where in the code we'd be able to do that (looked for a bit, but couldn't find the logic that determines why some options show and others do not). That would be an easier solution IMO as it is pretty ambiguous what is even being copied when presented with these options:

I agree that Copy link vs Copy URL to clipboard is confusing. Reading up in the slack thread, I think @marcaaron made some really good arguments for why we should just display Copy URL to clipboard if you right-click on the link, so 👍 there. I also think that the same logic should apply if you right-click an email link, which has this same bug.

And can you advise on how we could disable the option to "Copy link" when we are right-clicking on a hyperlink?

Yep!

all the context menu actions are defined here
whether or not each one shows is determined by their shouldShow function
The BaseReportActionContextMenu component has a type prop that's passed to the shouldShow function for each context action.
So if we don't want to show Copy link if you right-click on a link or email, then all we have to do is change this line to shouldShow: type => type === CONTEXT_MENU_TYPES.REPORT_ACTION,

I'm going to be ooo so assigning this to another teammate.

@Christinadobrzyn Could you please update the Expected result section with following?
Copy link menu item should not be shown on ContextMenu for Attachments and links.

@Christinadobrzyn Could you please update the Expected result section with the following?
Copy link menu item should not be shown on ContextMenu for Attachments and links.

Proposal
Solution

To hide the menu options from context menu for links, we need to edit this line and add => type === CONTEXT_MENU_TYPES.REPORT_ACTION

To hide the menu options from context menu for attachments, we would add && !ReportUtils.isReportMessageAttachment(lodashGet(reportAction, ['message', 0], {})) to the same line and this will solve our issue.

The final code will look like this
    {
        textTranslateKey: 'reportActionContextMenu.copyLink',
        icon: Expensicons.LinkCopy,
        shouldShow: (type, reportAction) => type === CONTEXT_MENU_TYPES.REPORT_ACTION && !ReportUtils.isReportMessageAttachment(lodashGet(reportAction, ['message', 0], {})),
        onPress: (closePopover, {reportAction, reportID}) => {
            Environment.getEnvironmentURL()
                .then((environmentURL) => {
                    const reportActionID = parseInt(lodashGet(reportAction, 'reportActionID'), 10);
                    Clipboard.setString(`${environmentURL}/r/${reportID}/${reportActionID}`);
                });
            hideContextMenu(true, ReportActionComposeFocusManager.focus);
        },
        getDescription: () => {},
    },

Links

Attachments

Sure, sounds good

Based on the new requirements, @Harshdeepjoshi 's proposal looks good to me.
cc: @sketchydroide Could you please also update the expected result according to https://github.com/Expensify/App/issues/9660#issuecomment-1178020405
:ribbon: :eyes: :ribbon:  C+ reviewed

I updated the GH, @parasharrajat and @Harshdeepjoshi let me know if that makes sense as we end up having to very similar changes to do here, one for the link and another for the attachements.

@sketchydroide I understood the changes. Replacing && !ReportUtils.isReportMessageAttachment(lodashGet(reportAction, ['message', 0, 'text'], ''))), with && !ReportUtils.isReportMessageAttachment(lodashGet(reportAction, ['message', 0], {}))), in this line will hide Copy URL to clipboard from attachments.
when can I submit the PR?

Looks good @Harshdeepjoshi.

Am I eligible for reporting bonus of 2nd Situation in the OP? I reported this a few days back  https://github.com/Expensify/App/issues/9660#issuecomment-1179119307.
cc: @sketchydroide

I would say that yes you are @parasharrajat

@sketchydroide Should we show the copy Link option on the mini menu for attachments?

Any thoughts above?

@sketchydroide I think we should do https://github.com/Expensify/App/issues/9660#issuecomment-1188359112 as an attachment is also and message and the user might want to copy the comment URL.

Hired in Upwork @Harshdeepjoshi @parasharrajat

Sorry for being late, I was busy with my college exams,PR is ready for review.

Still in QA

I think this has not been deployed yet?

so it has been deployed now, and it's up for payment @arielgreen

@Harshdeepjoshi can you link me your Upwork profile please?

@arielgreen Here is my profile link
https://www.upwork.com/freelancers/~01e5d6057af1ee90ae

@arielgreen can we close this?

@Harshdeepjoshi just sent over an offer, once you accept I can remit payment and we can close this

@arielgreen I have accepted the offer.

Excellent, paid, closing.


[Bug]: Datasource icons are missing on templates when the user signs up via the Start with Templates flow

Is there an existing issue for this?

[X] I have searched the existing issues

Description
Datasource icons are missing on templates when the user signs up via the Start with Templates flow

Steps To Reproduce

Sign up as a new user
Choose to Start with templates
Notice that the icons are missing on the template cards and template info page

Public Sample App
No response
Environment
Production
Issue video log
No response
Version
Cloud

Start with template is no longer an option. We will create a task to clean up this from code as well.


Cannot read property 'recheck' of undefined

Hi,
Thanks for a great plugin.
Im a bit confused about how to use this part of you plugin:
$('.responsive-image').data('responsImg').recheck()

Im getting this error:
 Uncaught TypeError: Cannot read property 'recheck' of undefined

When using it in a call back function also the error occurs if I just test it out in the Chrome console.
Sorry, this is probably a total newbie question.
Thanks.

Thanks for getting back so quickly.
I probably not understanding completely what you mean but now I get a new error:
Uncaught TypeError: rimg.recheck is not a function

Here is a little more info. Im trying to call the function from a callback function:
$(function() {
  $.fn.almComplete = function(alm){

$.fn.matchHeight._maintainScroll = true;
$('.ajax_post').matchHeight({
  byRow: true
  });

var responsiveImages = $('.responsive-image').responsImg();
responsiveImages.recheck();

console.log("Ajax Load More Complete!");
  };
});

$(function() {
  $.fn.almDone = function(alm){

$.fn.matchHeight._maintainScroll = true;
$('.ajax_post').matchHeight({
    byRow: true
});

var responsiveImages = $('.responsive-image').responsImg();
responsiveImages.recheck();

console.log('All posts have been loaded!');
  };
});

Hi Etienne,
Did you have a chance to check it out?


Error pulling image configuration: connection reset by peer

Description
This has been reported multiple times already (#357, #2151, #4539, #5255, etc.) and has never been completely solved, it has just disappeared by itself. Since yesterday, some pull requests to docker registry fail with errors like error pulling image configuration: Get https://dseasb33srnrn.cloudfront.net/registry-v2/docker/registry/v2/blobs/sha256/36/368db5c51bcd5821a9503b7d8349af948eaee516602969fe50915fd19f511cc0/data?Expires=1477399254&Signature=es6-HoHrzMRF1GtjFkiOq8E1aMlSMZzAwTWZuAI9DsRs-hJEdfRGoSYBBwSWxfzt2jZz0tySRfvpVSY8ef~wRwourd~QkA9G-sOf7ptk0B1FfWJLr7rlsmRSIpgF5sHMjkwxKTh~Tv-NzeDaEpMRMvm6fbMwjIJuZ~hKWZaH4z8_&Key-Pair-Id=APKAJECH5M7VWIS5YZ6Q: read tcp <IP_ADDRESS>:35436-><IP_ADDRESS>:443: read: connection reset by peer
Steps to reproduce the issue:

Try to pull wordpress (latest). It will fail.

docker pull wordpress
Using default tag: latest
latest: Pulling from library/wordpress
43c265008fae: Pulling fs layer
6ee27d07994b: Pulling fs layer
d43536f442a0: Download complete
4d9469dadeb4: Waiting
4fc33aa1941b: Waiting
09b922600db1: Waiting
01805b6582a4: Waiting
ec43f09bb70c: Waiting
6568948eed6b: Waiting
2dc0094a10b5: Waiting
7142d56062ec: Waiting
7a44a9f63706: Waiting
9b7c9a7c3515: Waiting
59249fc11e6f: Waiting
31611c57ce32: Waiting
712c4eef2d95: Waiting
aaf3860b31ac: Waiting
b04c02901a3a: Waiting
eb9dd4eb321b: Waiting
error pulling image configuration: Get https://dseasb33srnrn.cloudfront.net/registry-v2/docker/registry/v2/blobs/sha256/36/368db5c51bcd5821a9503b7d8349af948eaee516602969fe50915fd19f511cc0/data?Expires=1477399254&Signature=es6-HoHrzMRF1GtjFkiOq8E1aMlSMZzAwTWZuAI9DsRs-hJEdfRGoSYBBwSWxfzt2jZz0tySRfvpVSY8ef~wRwourd~QkA9G-sOf7ptk0B1FfWJLr7rlsmRSIpgF5sHMjkwxKTh~Tv-NzeDaEpMRMvm6fbMwjIJuZ~hKWZaH4z8_&Key-Pair-Id=APKAJECH5M7VWIS5YZ6Q: read tcp <IP_ADDRESS>:35436-><IP_ADDRESS>:443: read: connection reset by peer

Try to pull wordpress:4.3.1.  This also happens for other images and other tags.
Describe the results you expected:
Obviously, I have expected to pull of the requested images.
Additional information you deem important (e.g. issue happens only occasionally):
I have first discovered the issue yesterday, a few hours after I got Virtualbox updated to VirtualBox-5.0.28-111378-Win. The issue stayed after upgrading to VirtualBox-5.1.8-111374-Win and also stayed after upgrading docker toolbox to latest (v1.12.2). Also, I am testing this in an office with other coworkers that are not hitting the issue, but use similar setup (differences in OS and software version is possible).
Output of docker version:
Client:
 Version:      1.12.2
 API version:  1.24
 Go version:   go1.6.3
 Git commit:   bb80604
 Built:        Tue Oct 11 17:00:50 2016
 OS/Arch:      linux/amd64

Server:
 Version:      1.12.2
 API version:  1.24
 Go version:   go1.6.3
 Git commit:   bb80604
 Built:        Tue Oct 11 17:00:50 2016
 OS/Arch:      linux/amd64

Output of docker info:
Containers: 0
 Running: 0
 Paused: 0
 Stopped: 0
Images: 1
Server Version: 1.12.2
Storage Driver: aufs
 Root Dir: /mnt/sda1/var/lib/docker/aufs
 Backing Filesystem: extfs
 Dirs: 32
 Dirperm1 Supported: true
Logging Driver: json-file
Cgroup Driver: cgroupfs
Plugins:
 Volume: local
 Network: bridge overlay null host
Swarm: inactive
Runtimes: runc
Default Runtime: runc
Security Options: seccomp
Kernel Version: 4.4.24-boot2docker
Operating System: Boot2Docker 1.12.2 (TCL 7.2); HEAD : 9d8e41b - Tue Oct 11 23:40:08 UTC 2016
OSType: linux
Architecture: x86_64
CPUs: 1
Total Memory: 995.9 MiB
Name: test-host-2
ID: QFKW:A5SR:LMSM:YO7X:GXTI:463S:4D2Q:OPRH:3TRX:KWK3:KNZA:6BVF
Docker Root Dir: /mnt/sda1/var/lib/docker
Debug Mode (client): false
Debug Mode (server): true
 File Descriptors: 13
 Goroutines: 23
 System Time: 2016-10-25T12:39:27.186690998Z
 EventsListeners: 0
Registry: https://index.docker.io/v1/
Labels:
 provider=virtualbox
Insecure Registries:
 <IP_ADDRESS>/8

Additional environment details (AWS, VirtualBox, physical, etc.):
Virtualbox on Windows. See used versions in the text above.

Having the same issue. We recently stood up a private registry with self-signed certs. From my local machine, I can login to the registry and push or pull images without problem.
When I attempt this from my Minikube instance, I get an error: Error response from daemon: read tcp <IP_ADDRESS>:60392-><IP_ADDRESS>:80: read: connection reset by peer. So for instance, I SSH into Minikube, do docker login , and then attempt to pull the image using "docker pull".
I have also set the --insecure-registry flag on the Minikube instance.
Here's my docker info:
Containers: 4
 Running: 4
 Paused: 0
 Stopped: 0
Images: 3
Server Version: 1.11.1
Storage Driver: aufs
 Root Dir: /mnt/sda1/var/lib/docker/aufs
 Backing Filesystem: extfs
 Dirs: 23
 Dirperm1 Supported: true
Logging Driver: json-file
Cgroup Driver: cgroupfs
Plugins:
 Volume: local
 Network: bridge null host
Kernel Version: 4.4.14-boot2docker
Operating System: Boot2Docker 1.11.1 (TCL 7.1); master : 901340f - Fri Jul  1 22:52:19 UTC 2016
OSType: linux
Architecture: x86_64
CPUs: 2
Total Memory: 1.955 GiB
Name: minikube
ID: 4ZDD:JSGQ:A5LZ:3DLA:T5SU:HO46:VU7P:IPQG:O426:3GET:HQ7R:4C67
Docker Root Dir: /mnt/sda1/var/lib/docker
Debug mode (client): false
Debug mode (server): true
 File Descriptors: 27
 Goroutines: 58
 System Time: 2016-10-26T16:28:44.158907473Z
 EventsListeners: 0
Registry: https://index.docker.io/v1/
Labels:
 provider=virtualbox

Docker version:
Client:
 Version:      1.11.1
 API version:  1.23
 Go version:   go1.5.4
 Git commit:   5604cbe
 Built:        Wed Apr 27 00:34:20 2016
 OS/Arch:      linux/amd64

Server:
 Version:      1.11.1
 API version:  1.23
 Go version:   go1.5.4
 Git commit:   5604cbe
 Built:        Wed Apr 27 00:34:20 2016
 OS/Arch:      linux/amd64

I'm having a similar issue where I get sporadic connection reset by peer errors when pulling images, fetching gpg key, etc. I was using the latest VirtualBox release in Windows, 5.1.8. The issue seems to have disappeared when I downgraded VirtualBox to 4.3.40.

@nirvana-msu, I have downgraded to VirtualBox-5.0.20-106931-Win and the issue seems to be missing as well. You might consider the upgrade, as VirtualBox 4.3 is already not supported.
The issue is also missing on CoreOS (not VBox managed), so I guess VBox really is the culprit here.

Confirmed, downgrading VirtualBox from 5.0.28-r111378 to 5.0.20-r106931 resolved the issue.
Info: MacOS Sierra, Docker version 1.12.1, build 6f9534c

Ditto... downgraded my VirtualBox to 5.0.20-r106931 as mentioned above and works fine now.

I had the same issue with the 5.2 version of Virtualbox runnin on OSX 10.11.6. Downgrading Virtualbox to 5.0.20-r106931 fixed the issue.

is everyone on this issue running boot2docker / VirtualBox?

I'm not running boot2docker. I was trying to reproduce a simple example with phusion/baseimage - third video from this vagrant docker provider demo. I don't think it matters at all - I was getting occasional connection reset by peer errors even when pulling phusion/baseimage image. It really seems to be an issue with VirtualBox itself.

Having same issue VirtualBox 5.1.8, boot2docker 1.12.3

I'm running into the same issue while pulling the image from Docker registry hosted on Gitlab onto a CoreOS machine booted using VirtualBox (5.0.28) on my Mac.
docker info

Containers: 4
Running: 2
Paused: 0
Stopped: 2
Images: 2
Server Version: 1.12.1
Storage Driver: overlay
Backing Filesystem: extfs
Logging Driver: json-file
Cgroup Driver: cgroupfs
Plugins:
Volume: local
Network: host bridge null overlay
Swarm: inactive
Runtimes: runc
Default Runtime: runc
Security Options: selinux
Kernel Version: 4.8.4-coreos
Operating System: CoreOS 1214.0.0 (MoreOS)
OSType: linux
Architecture: x86_64
CPUs: 1
Total Memory: 1.958 GiB
Name: w3
ID: YXRU:SRLX:QHPR:IWX5:4FB4:JSNH:GMGA:QNHF:CQOR:X5VO:SOX5:FAYC
Docker Root Dir: /var/lib/docker
Debug Mode (client): false
Debug Mode (server): false
Registry: https://index.docker.io/v1/
Insecure Registries:
<IP_ADDRESS>/8

docker --version

Docker version 1.12.1, build 7a86f89

Just an FYI - Clearly a few people having this problem. I upgraded to Virtualbox 5.1.8 a few days ago, and then encountered this problem today. I simply uninstalled 5.18 and reinstalled Virtualbox 5.1.6 and the problem was fixed.
Interesting to note that whilst running 5.1.8 all the other docker commands seemed to work, docker login, search etc, it was only the docker pull that threw the error.

Issue confirmed.
VirtualBox version 5.1.8
using Docker Machine on Windows 7
Everything works, exept for docker pull

I have the same issue:
VirtualBox Version 5.1.8 r111374 (Qt5.5.1)
Host OS: Mac OS X 10.12.1
Guest OS: Ubuntu 16.04
Run from Guest OS:
$ uname -a
Linux vagrant 4.4.0-31-generic #50-Ubuntu SMP Wed Jul 13 00:07:12 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux

$ docker -v
Docker version 1.12.3, build 6b644ec

Pulling certain containers fails with an error very similar to the on reported in this bug. However switching the VM to use Bridged Adapter rather than NAT fixed the issue. I shut down (not just suspended) the VM to make the change.

This appears to be the ticket with VirtualBox: https://www.virtualbox.org/ticket/16084
If you look at the comments and the linked duplicates, it actually isn't just an SSL issue.

@thoughtless you're a boss! for making that connection 👏
Disconnected Lan and used WiFi and it worked
Notes:
OSX: 10.11.6 (15G31)
VirtualBox: Oracle VM VirtualBox Manager 5.0.28 (5.0.28 r111378)
Docker: Docker version 1.12.3, build 6b644ec
Docker-compose: docker-compose version 1.8.1, build 878cff1

VirtualBox Version 5.1.10 has been released. So far that version has fixed the issue for me.

thanks for the update @thoughtless! Since this is not a bug in Docker, i'll close this issue, but i hope this helps others running into this issue

openstack vm
docker 1.12.6
uname -a :3.10.0-229.20.1.el7.x86_64 #1 SMP Tue Nov 3 19:10:07 UTC 2015 x86_64 x86_64 x86_64 GNU/Linux
v1.3.0-beta.1: Pulling from luxas/heapster-amd64
4b0bc1c4050b: Already exists
3061692e8995: Pulling fs layer
c5c797399e29: Pulling fs layer
error pulling image configuration: Get https://dseasb33srnrn.cloudfront.net/registry-v2/docker/registry/v2/blobs/sha256/4f/4ff6ad0ca64c7a065cd595a557b692a92b8ef4fe56bffd7c104eabed4c5a6d98/data?Expires=1487236221&Signature=gwjZrgpgffhBtPoZzIqqtM1p7HeX1SznLwpzc5wXRIyXQ4ax8XNw8oiznh6Ms-jeYyUroTS8v1yETuRqNQyh4MmKIsn5DiM6fyxZOKYU9s7Myn5MqqaKf7NiRPggCU8N95tyRKvm4bjZ8ArWY2dLVpxgX~6xET9n7yjCTvIPlN0_&Key-Pair-Id=APKAJECH5M7VWIS5YZ6Q: net/http: TLS handshake timeout

Had similar problem. VB 5.2.8 works.

@hupili, I have this issue and I'm using VB 5.2.8. Also, did you have to generate a .crt as suggested here: https://github.com/moby/moby/issues/23356#issuecomment-228490467 ? I am using Centos7 as the guest os.


Ignore error in QueryMultiple

I found the error that occurred in the QueryMultiple retry loop will return to the caller:
// QueryMultiple sends a provided dns request and return the data
func (c *Client) QueryMultiple(host string, requestTypes []uint16) (*DNSData, error) {
	// ... ...

	for _, requestType := range requestTypes {
		// ... ...

		for i := 0; i < c.maxRetries; i++ {
			resolver := c.resolvers[rand.Intn(len(c.resolvers))]
			var resp *dns.Msg
			resp, err = dns.Exchange(&msg, resolver)
			if err != nil {
                                 // This error will be returned if current request is the last request
				continue
			}

			dnsdata.Host = host
			dnsdata.Raw += resp.String()
			dnsdata.StatusCode = dns.RcodeToString[resp.Rcode]
			dnsdata.Resolver = append(dnsdata.Resolver, resolver)

			// In case we got some error from the server, return.
			if resp != nil && resp.Rcode != dns.RcodeSuccess {
				break
			}

			dnsdata.ParseFromMsg(resp)
			break
		}
	}

	dnsdata.dedupe()

        // return to the caller
	return &dnsdata, err

This behavior means QueryMultiple will fail just because the last DNS request got a network problem, even all DNS requests before the last one succeed.
And so dnsx will return nothing if give multiple DNS requests to dnsx:
// Try more time
echo github.com | dnsx -mx -a -cname -aaaa -ns -soa -json

Please see #16

Please see #16

The problem is within dnsx at https://github.com/projectdiscovery/dnsx/blob/cf9498dfb27e0e6cb36b76a26bed506baf872b53/internal/runner/runner.go#L308

The problem is within dnsx at https://github.com/projectdiscovery/dnsx/blob/cf9498dfb27e0e6cb36b76a26bed506baf872b53/internal/runner/runner.go#L308

Closing as the issue is addressed in dnsx at https://github.com/projectdiscovery/dnsx/pull/33 . Let us know if you still face problems, thanks!


Auto reconnect capability

It would be nice if it reconnects automatically when connection to HipChat has lost.
I run my bot on my laptop. Once I close my PC, lita never reconnects automatically so I need to stop and launch it again every time, which is a bit annoying.

I've written a poc. @jimmycuadra before I update specs, can you see my implementation?
s2ugimot/lita-hipchat@0d9369d1cc884384498279b9eafe910b6929324f

Thanks for the POC. I think trying to manage reconnection within the client like this is probably a little too complex. What do you think about making Lita crash (or just calling shut_down explicitly) when the connection is lost? Then it can easily be restarted by the user's preferred process manager/init system. I like the idea of just letting it crash and then starting up again with a totally clean slate.

@jimmycuadra Thank you. Your idea sounds better. I'll write a new poc on other branch.

Just an opinion, but it feels to me like you're hitting a nail with a sledgehammer by crashing lita.  What if lita is using more than 1 adapter, like slack and hipchat?  In this case, if hipchat goes down for more than a few seconds, lita will be in a join/leave cycle in slack until hipchat comes back up.
Also, many process managers will only attempt to restart a service a finite number of times before it gives up.  If hipchat were down for long enough, it wouldn't ever be restarted if the process manager gave up.

A single Lita process can't be used with more than one adapter, so that is not a problem in this case. I'm not aware of a process manager that can't keep attempting to restart a process infinitely – do you have examples? What would you suggest rather than letting the process exit?

While I'm not new to relying on external services from long running processes, I'm really new to lita.  Thanks for pointing out the single adapter thing.
systemd will often use restart=on-failure, which if lita exits with status 0, it wouldn't restart the service.  In upstart, there's respawn-limit.
As to how to deal with it, I'd think that applying graceful degradation similar to the way @s2ugimot did in s2ugimot/lita-hipchat@0d9369d would require less work from the sysadmin and would ultimately be a more "set-it-and-forget-it" approach.
Hubot does it similarly: https://github.com/hipchat/hubot-hipchat/pull/174
BTW: didn't get to thank you for your ChatOps panel at DevOpsDaysRox.  I was the one in the openspace that talked about the "clock in" feature that was the killer feature that got buy-in from the users.  I've been working on replacing Hubot with Lita this week and have been really happy so far.

Interesting... thanks for the additional details. I'm not sure how I feel about where/how this issue should be handled. I'll keep thinking about it.
Glad you've been enjoying Lita so far! Getting feedback about it that can lead to more improvements is the best thanks I could ask for. :}

Another point to consider - a process supervisor is not a given. sysvinit is still widely used.
I also imagine how I might feel if a Java or Rails app I manage simply exited because a 3rd party service went away for a moment and it didn't try to reconnect.
Thanks for continuing to think about this.

@jimmycuadra I'm not a huge fan of this approach. If the websocket is closed, its an error? We should handle errors right?
Would you be adverse to some retry logic that is configurable, perhaps an exponential backoff?

lita-hipchat doesn't use WebSockets, but in any case, what type of error are you referring to? If there's something specific that is recoverable, then probably yes. I'm still hesitant about adding reconnection logic inside the adapter. I'd love to hear more specifics on how letting a process manager restart it has been a problem for folks.

@jimmycuadra Do you have any examples of other applications that take this approach? I'm not sure you'll get many specifics on how it's worked for people because I'm not sure it's a common thing to do. Currently we use CentOS 6 and sysvinit so there is no process supervisor. We don't have any processes that routinely bomb out when external services fail and I would call it a bug if they did.

I guess I'm amenable to this feature after more thought (thank you for all the comments). I don't love the idea of having to maintain it, but clearly there is demand and the goal is to make users' lives easier. I'm really just kind of gun shy about handling additional complexity in the adapter since XMPP and the xmpp4r library are already quite nasty, and I don't want to introduce things that might create more subtle bugs in the future. But if someone wants to take this on, I will accept a really solid PR. I think it will need to handle reconnection with an exponential backoff and a maximum number of attempts to be safe.

We're running lita in kubernetes with built in process monitoring.  We have other processes running under God and even custom scripts.  While I appreciate the views about it reconnecting.  I also like simplicity.  I think process monitoring isn't that unusual and would suggest running lita under something even if it did handle this reconnect issue.  Afterall, this isn't only reason lita might fail and process monitors have a rich feature set for dealing with these events.  So practically, if making lita crash is an easy development task, I'd welcome it as an acceptable solution that moves lita forward.  When/if a pull request comes with reconnect feature, I'll heed Jimmy's caution and let it bake a while before upgrading.  Till then, it's manual intervention every time Hipchat's server's have a blip.  Thanks for everyone who's contributed to lita.


Add inactive replication slot count metric

What does this PR do?

This PR adds a new metric for postgresql: postgresql.replication_slot.inactive_slots. This metric checks the current number of inactive replication slots on the database.
Motivation

It's useful to monitor the current count of inactive replication slots: https://pgdash.io/blog/essential-postgres-monitoring-part1.html
Additional Notes

Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] Changelog entries must be created for modifications to shipped code
[ ] Add the qa/skip-qa label if the PR doesn't need to be tested during QA.

After discussing offline, this is a very niche metric for a niche use-case. If there's demand from more customers we can revisit this, but in this current state it is not worth it.

This seems like a very critical metric to monitor for everybody  using logical  replication (CDC,replications...etc) as orphan slots could create problems...

Not sure why do you consider this for niche? I find it very easy to detect inactive replication slot this way rather than counting bytes on replication slots which can be misleading when there is a lot of traffic on database.


Add email regex.

twitter-text/java/src/com/twitter/Regex.java misses Email Regex.

I would love to see this as well, I have created something like this using twitter-text's TLDs lists:
//copied over from twitter-text sources
  val VALID_GTLD = "(?:(?:" + TldLists.GTLDS.toList.mkString("|") + ")(?=[^\\p{Alnum}@]|$))"
  val VALID_CCTLD = "(?:(?:" + TldLists.CTLDS.toList.mkString("|") + ")(?=[^\\p{Alnum}@]|$))"
  val validTlds = "(?:" + VALID_GTLD + "|" + VALID_CCTLD + ")"
  val emailPattern = Pattern.compile("^[a-z0-9._%\\-+]+@(?:[a-z0-9\\-]+\\.)+" + validTlds)


Callback on Http.PutJsonAsync

Is there a callback or return on Http.PutJsonAsync in Blazor?
Describe the solution you'd like
A return of HttpResponse?

Thanks for contacting us, @mylifelineio.
We'll be tracking support for this as part of #11725


Update libraries and traces

-Update RF and SD drivers to the latest version
-Add Thread EUI64 trace to the application
-Update Thread config to use MBEDTLS config to reduce image size

@SeppoTakalo would you please review.
cc: @katariinaliehu


No devices found in Android X

Hey guys!
I tried to use this plugin in Android X.
I could build but no devices found always.
Isn't this plugin corresponding in Android X ?

Hi there,
Have you tested any other Bluetooth scanning app on your Android X device?
Honestly, I didn't test this plugin on Android X, but it seems here:  https://github.com/andrey-ushakov/flutter_bluetooth_basic/issues/2 there is at least one person using Android X.

Hi @andrey-ushakov ,
I tested flutter_blue plugin but didn't work too.
There is a possibility that my device has some problem.
I will investigate a little more and report here.

I tried the same code as the example one provided in this repo and i could not get the list of bluetooth devices. Tapping on the FAB will start the scan , and nothing happens. The FAB turns back to search icon. And i get the following in the log
D/BluetoothBasicPlugin(13651): start scan  D/BluetoothAdapter(13651): isLeEnabled(): ON D/BluetoothLeScanner(13651): onScannerRegistered() - status=0 scannerId=7 mScannerId=0 D/BluetoothAdapter(13651): isLeEnabled(): ON
I added the permissions in Android manifest
Device : Moto G5s plus
Android Version : 8.1.0
Am i missing something..?

couldn't get available devices

Same issue here.Unable to discover a  single bluetooth device.

Just a heads up, on my Android 9 phone both Bluetooth and Location have to be turned on in order to find bluetooth devices, so make sure Location is on (@yukitaka13-1110 , @akhilsomanvs , @abenezeryohannes @OmiWakode).

Hi guys I notice something all the flutter bluetooth packages are only for ble not for classic bluettoth that is why our phones are not discovered?

Same issue here, no devices found, location permission set to Fine (not Coarse as in earlier android versions).
btw, the example didn't built until I set the minSDKVersion to 21 (not 16) in android/app/build.gradle

I solved it.
Add BLUETOOTH_SCAN, BLUETOOTH_CONNECT permission to Android Manifest.
If you give BLUETOOTH_SCAN and BLUETOOTH_CONNECT permission as "permission_handler", it will be searched.


Upgrade rolling based into ubuntu nobel, and add jazzy workflow

ROS 2 Jazzy is under process to release in May.2024, and now rolling is upgraded to ubuntu 24.04 nobel base.
What to do

[ ] upgrade rolling with ubuntu nobel. (container image, github workflow)
[ ] add jazzy github workflow and container image.
[ ] add documentation related to above things.

https://github.com/fujitatomoya/ros2ai/commit/d365c3cfd494ba8678575efd5fbb8a5f989c380c addressed https://github.com/fujitatomoya/ros2ai/actions/runs/8835735881/job/24260633997 build issue for rolling branch.

Jazzy is not released yet, still under testing. so i will close this all tasks are completed and create another issue to track jazzy image.


Import status

This PR adds import status feedback to topaz ds import and topaz ds restore.
The Importer service will return an ImportStatus message when a content or model validation error occurs in the return stream to the import client.
For example:
❯ topaz ds import -i -d ./assets/acmecorp

>>> importing data from ./assets/acmecorp
error     : "object.id" cannot contain any spaces or other whitespace characters - InvalidArgument (3)
error     : "uses": object type not found - NotFound (5)
error     : "user:managers": relation not found - NotFound (5)
error     : "users": object type not found - NotFound (5)
error     : "relation.relation" must be all lowercase, start with a letter, can contain letters, digits, dots, underscores, and dashes, and must end with a letter or digit - InvalidArgument (3)
error     : "relation.object_type" must be all lowercase, start with a letter, can contain letters, digits, dots, underscores, and dashes, and must end with a letter or digit - InvalidArgument (3)
error     : "relation.relation" must be all lowercase, start with a letter, can contain letters, digits, dots, underscores, and dashes, and must end with a letter or digit - InvalidArgument (3)
error     : "relation.subject_type" must be all lowercase, start with a letter, can contain letters, digits, dots, underscores, and dashes, and must end with a letter or digit - InvalidArgument (3)
error     : "groups": object type not found - NotFound (5)
error     : "groups": object type not found - NotFound (5)
error     : "groups": object type not found - NotFound (5)
objects   : 839 (set:837 delete:0 error:2)
relations : 1905 (set:1896 delete:0 error:9)

Content validation errors appear as an InvalidArgument (status code 3) error with a description of the specific failed validation condition.
Model validation errors appear as an NotFound (status code 5) error with a description detailing the object or relation type not found in the manifest.
The summary counts reflect:
objects   : 839 (set:837 delete:0 error:2)
relations : 1905 (set:1896 delete:0 error:9)

How many messages were received by the importer service? In the above example, 839 object and 1905 relation messages were received, 837 of which were SetObject messages and 1896 SetRelation messages. 0 DeleteObject or DeleteRelation messages were received. There were 2 errors with Objects and 9 with Relations.
The total per type should always be the sum of Set + Delete  + Error.
The ImportStatus message contains the import request instance that caused the error, see:
https://buf.build/aserto-dev/directory/docs/v0.31.6:aserto.directory.importer.v3#aserto.directory.importer.v3.ImportStatus

Pull Request Test Coverage Report for Build<PHONE_NUMBER>1
Details

0 of 0   changed or added relevant lines in 0 files are covered.
6 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.1%) to 28.352%

Files with Coverage Reduction
New Missed Lines
%

pkg/cli/cc/ports.go
6
76.27%

Totals

Change from base Build<PHONE_NUMBER>7:
-0.1%

Covered Lines:
1326

Relevant Lines:
4677

💛  - Coveralls


Support for micro-mqtt

MQTT bindings over the esp32spi project.

We will start with ESP32

compatible with nina firmware? https://github.com/adafruit/nina-fw

@mmoskal ready to merge in esp32spi


fix(MyLedger): fix flickering of the connect manager action when device is locked

📝 Description
Since https://github.com/LedgerHQ/ledger-live/pull/3105 we've been sending a "deviceChange" event at each loop of the polling mode of device actions. This caused a flickering on the device action "locked" state when the device was locked on the connect manager action. This PR increases the debounce time of replaceable "deviceChange" events to be greater than the polling frequency, this way we don't have a flickering on the device action state.
❓ Context

Impacted projects: ledger-live-common
Linked resource(s): LIVE-7821

✅ Checklist

[N/A] Test coverage
[x] Atomic delivery
[x] No breaking changes

📸 Demo
Before the PR:
https://github.com/LedgerHQ/ledger-live/assets/6013294/bd9a28f3-c4bb-4db1-96c1-e902ab531c43
After the PR:
https://github.com/LedgerHQ/ledger-live/assets/6013294/e379b08d-b778-4051-915c-29df22eed6f5

👋  ESLint config has been unified on develop after we merged https://github.com/LedgerHQ/ledger-live/pull/3622 – this will improve the project consistency, remove eslint dependencies duplicates, and overall simplify the maintenance. This comes with a prettier library upgrade and unification of the prettierrc too, so you likely have conflicts with develop.
Hopefully, here is the procedure to easily fix this. please proceed as follow:
Step 1: sync your branch with develop up to the config changes:
2 cases

if your branch were continuously rebased with develop and don't have any merge commit, you can do

git rebase aa1e0ebc0a0498b4350754899b6a368fbd42e811

otherwise prefer

git merge aa1e0ebc0a0498b4350754899b6a368fbd42e811

then, apply the config
pnpm i
pnpm lint:fix --force

if there are remaining errors that lint couldn't fix, please fix them and pnpm lint again.
then commit in your branch.
git commit -a -m "chore: lint fixes"

Step 2: finalize the rebase/merge with develop
2 cases

if your branch were continuously rebased with develop and don't have any merge commit, you can do

git pull --rebase origin develop

otherwise prefer

git merge origin/develop

you should now be up to date. 👍

Thanks and sorry for the inconvenience,
gre


Linter results are updated dynamically in IDE without needed to close and re-open the topic

Describe the bug
When using the vale-at-red-hat linter in Atom, if I fix a content quality issue that is flagged by the linter, the error/warning/info highlight persists and does not disappear inline until I save AND reopen the module.
To Reproduce
Steps to reproduce the behavior:

Create a module with content that you know is non-compliant, for example. use SSL instead of SSL/TLS to generate a red error.
Open the content in the Atom editor (with atomic-vale installed and configured)
Open the bad topic to view the error flag and hover over the bad phrase/word to see the advice offered.
Modify the bad word/phrase that has either an error, warning or info message. Change SSL to SSL/TLS.
RESULT: No change to the vale-at-red-hat linter output highlight. The red warning persists. But if you hover over the word, the guidance pop-up message no longer displays.
Save the topic.
RESULT: No change to the vale-at-red-hat linter output. and result of step 4.
Close the topic and re-open.
RESULT: The error, warning, or info message correctly disappears as expected.

Expected behavior
Linter issues are updated dynamically without the need to reopen a module, similar to how a spell checker works.
Rerun the linter on a Save event.
Additional context
Sometimes, I need to completely restart my Atom client. This is not reproducible.

@michelle-purcell Atom being sunsetting, and everybody being told to switch to another IDE, do you agree on closing this issue without fixing it?

@themr0c I agree. Most folks have made the switch over to VS Code, IntelliJ or another IDE>
This issue is also intermittent and possibly specific to RHEL  CSB, It also depends on how many Atom windows are open too.


[SUGGESTION] Remove inline background-color for .modal-bg

Currently, the Theme Picker sets background-color: transparent inline for the .modal-bg when the theme picker prompt is selected.

This overrides (what I presume is new in Obsidian 1.0) the slightly dimmed background from app.css, giving it a different look from most other prompts.
Additionally, I believe .theme-picker-modal { box-shadow: 0px 0px 17px 0px rgb(0 0 0 / 25%); } can also be removed, as .prompt in itself has a box-shadow applied to it.
This would help reduce the complexity for theming for theme devs as well.

The reason I added background-color: transparent is so that you could see the true colors of the theme behind the modal, and so be able to make a selection while browsing themes, instead of having to select one in order to see what the true colors are.
You're right that the box-shadow is redundant -- thank you for the suggestions!

The reason I added background-color: transparent is so that you could see the true colors of the theme behind the modal, and so be able to make a selection while browsing themes, instead of having to select one in order to see what the true colors are.
You're right that the box-shadow is redundant -- thank you for the suggestions!

That's a fair point about the transparency - would it be possible to not make it inline though?

Sure, it should be possible -- are the inline styles getting in the way of something you're doing?

In general, inline styles are a pain for theme devs to override so it's not a great idea for any plugin to have them - personally for my own use-case, I rely on the theme-set background-color to set the modal background and differentiate it from the prompt, which I can override much easily if it isn't inline.


init fails despite entering in the correct Apple ID credentials: af8f4ab25f99135a69e22363ab0f291e

Please see crash report for af8f4ab25f99135a69e22363ab0f291e

Stacktrace
Spaceship::Client::UnexpectedResponse: {"data"=>nil, "messages"=>{"warn"=>nil, "error"=>["Unauthorized access"], "info"=>nil}, "statusCode"=>"ERROR"}
  from /usr/local/bin/fastlane:23:in `<main>'
  from /usr/local/bin/fastlane:23:in `load'
  from /Library/Ruby/Gems/2.0.0/gems/fastlane-1.53.0/bin/fastlane:155:in `<top (required)>'
  from /Library/Ruby/Gems/2.0.0/gems/fastlane-1.53.0/bin/fastlane:149:in `run'
  from commander/delegates.rb:15:in `run!'
  from commander/runner.rb:68:in `run!'
  from commander/runner.rb:428:in `run_active_command'
  from commander/command.rb:153:in `run'
  from commander/command.rb:178:in `call'
  from commander/command.rb:178:in `call'
  from /Library/Ruby/Gems/2.0.0/gems/fastlane-1.53.0/bin/fastlane:40:in `block (2 levels) in run'
  from fastlane/setup/setup.rb:19:in `run'
  from fastlane/setup/setup_ios.rb:29:in `run'
  from fastlane/setup/setup_ios.rb:134:in `detect_if_app_is_available'
  from spaceship/tunes/spaceship.rb:30:in `select_team'
  from spaceship/tunes/tunes_client.rb:83:in `select_team'
  from spaceship/tunes/tunes_client.rb:45:in `teams'
  from spaceship/client.rb:268:in `parse_response'

Also experiencing this issue with a similar stack trace. c4da24f26082420bedb16d9c2556112c

The unexpected response is coming from Spaceship::App.find(self.app_identifier) in detect_if_app_is_available in setup_ios.rb. What's strange though is that this call succeeds with the same account and bundle id if I run it with spaceship directly.

@Apocryphon If you try to log into iTunes Connect on the web, do you happen to get an error message? I was having this same problem and when attempting to log in, got an error saying "Your Apple ID isn't enabled for iTunes Connect". I have fixed the issue for me in this pull request: https://github.com/fastlane/fastlane/pull/1210.

I had the same issue on a new project, until I realized that I hadn't accepted the invitation to the team on ITC (only on developer). And fastlane isn't able to know that it seems :)

I have ran into this as well: 2e0b413e8e23d50631bdd2b25631e2fe

The problem here as @lacostej said is that the apple id doesn't have access to iTunes Connect for whatever reason. This results in a 401 in PortalClient which causes the exception. @samrobbins In this scenario, would we like to abort fastlane init with a sensible error message? Or notify the user and continue the process, skipping any iTunes Connect interactions (deliver, produce, etc).

I'm experiencing this problem and am not able to run "fastlane init". It's failing when I select between one of two teams. Both team's cause the same problem. Here's the event id: 6b49eb3acd5714e459520ba7cb21b4fd. I confirmed on Member Center, that the email address used has accepted the invitation. I am currently copying an old fastlane file into the directory for the time being. Any recommendations on work arounds?

I had a similar problem and decided that I don't need ITunes Connect. @patgoley made a good comment. I just ran sigh and it worked fine using the creds that caused fastlane init to fail.

+1
Same thing happening with me.

It looks like there hasn’t been any recent activity on this issue in some time, so I’m closing it. If this is still a problem, feel free to re-open a new issue and I’d be happy to help :+1:


OrmaListAdapter should override hasStableIds()

OrmaListAdapter does not override hasStableIds() method.
https://developer.android.com/reference/android/widget/BaseAdapter.html#hasStableIds()
And this cause getItemIds() of ListView always return empty when CHOIDE_MODE_MULTIPLE_MODAL.
https://developer.android.com/reference/android/widget/AbsListView.html#getCheckedItemIds()
I think OrmaListAdapter always have stable ids, so just override this method and always return true is enough.

I was wrong. getCheckedItemIds() also depend on getItemId().
It's not so easy as I thought.
Even though just call delegate.getItem(position).id would work, it cause a little performance degrade.
So delegate might need to support delegate.getItemId(pos).
Here is my workaround code.
        @Override
        public boolean hasStableIds() {
            return true;
        }

        @Override
        public long getItemId(int position) {
            return this.delegate.getItem(position).id;
        }

Thank you for the interesting suggestion, but I guess it is responsible for users, because Orma doesn't know the type of a primary key, which is typically long but possibly not. (there's ColumnDef#getSerialized(Model) to get the value of the primary key but its return type is Object. Getting long from Object is not an easy task in Java.).
Your workaround code is, I think, completely right and should work as expected.

I understand the situation. I didn't know it's not so easy to get PrimaryKey as long id,
For me, as a user, when ORM provides ListAdapter, it natural to guess the semantics is similar to CursorAdapter.
CursorAdapter requests that "_id" field must exist in the Cursor.
It's really dirty assumption. But that's why most of the ListView API works as expected.
Well... anyway, this issue is just close for a while.
For me, it's better to make  getItemId() abstract and implement hasStableIds() to return true, but more novice developer may not understand what getItemId() is and they might like current design.
May be it's enough to provide some example of ListView which support normal CRUD operation with standard Contextual ActionBar (in which case, you need getItemIds() for multiple delete).
Anyway, thank you for your response.


Hexadecimal numbers

I'd like to have support to write numbers in base 16.
address: 0x08000000

It'd be useful in configuration files of where to load software in embedded processors. Hex numbers would be the same data type so they could still be represented in JSON without losing information.

Is it just an address or would you also need to put binary data into a config file? I think it would make more sense to handle this in the application. That way you can support every use case (data that can't be interpreted, like hex/blob/etc., is available to the application as a string).

Same request, same reasons. The values are mostly addresses (64-bit at most), but sometimes configuration values that read better as hex numbers.
Handling this in the application is simple enough, but being able to read these as numbers in the file is more useful than reading them as strings (syntax highlighting assumed)

What about hex colours? I'd like to be able to use hex for those.

As Hjson already allows address: 0x08000000 (via quoteless strings), the conversion should be handled by the app.

@jminer @FHTheron @sbrl Hex is now supported by enabling the hex DSF (currently with JS/Java/C#).
e.g. for JS
Hjson.parse(text, { dsf: [ Hjson.dsf.hex() ] });


Easi 2364/operational needs be

EASI-2364
Changes and Description

Add Operational Needs
Add Operational Solutions

Note, the implementation currently does not support updating the name of custom needs or solutions. If there is a need without that name, it will insert, or it exists it will update it.

How to test this change

Make a model plan ( use the postman collection and request that stores ids)
Make some operational needs with the postman collection
Make some operational solutions with the postman collection

PR Author Review Checklist

[ ] Met the ticket's acceptance criteria, or will meet them in a subsequent PR.
[ ] Added or updated tests for backend resolvers or other functions as needed.
[ ] Added or updated client tests for new components, parent components, functions, or e2e tests as necessary.
[ ] Updated the Postman Collection if necessary.

PR Reviewer Guidelines

It's best to pull the branch locally and test it, rather than just looking at the code online!
Check that all code is adequately covered by tests - if it isn't feel free to suggest the addition of tests.
Always make comments, even if it's minor, or if you don't understand why something was done.

Canceling and making a new PR as it seems the cache might be bad for this PR


[fix](regression test)fix ci error

Proposed changes
http://<IP_ADDRESS>:8111/viewLog.html?buildId=236686&buildTypeId=Doris_DorisRegression_P0Regression
java.sql.SQLException: errCode = 2, detailMessage = There are still some transactions in the COMMITTED state waiting to be completed. The table [test_query_json_set] cannot be dropped. If you want to forcibly drop(cannot be recovered), please use "DROP table FORCE".

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


[Roadmap] Support more import data formats

root issue

WeOpen Star

[WeOpen star] Hello, I'm intrested in #7579, I am new to Open-Source, if there's any post remaining to assign , Please tell me. I want to contribute.


[SPARK-8015] [flume] Remove Guava dependency from flume-sink.

The minimal change would be to disable shading of Guava in the module,
and rely on the transitive dependency from other libraries instead. But
since Guava's use is so localized, I think it's better to just not use
it instead, so I replaced that code and removed all traces of Guava from
the module's build.

I verified that there are no references to Guava in the generated bytecode and that Guava does not show up in mvn dependency:tree.

Merged build triggered.

Merged build started.

Test build #33905 has started for   PR 6555 at commit 2d79260.

Test build #33905 has finished for   PR 6555 at commit 2d79260.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

jenkins, retest this please

Merged build triggered.

Merged build started.

Test build #33907 has started for   PR 6555 at commit 2d79260.

Test build #33907 has finished for   PR 6555 at commit 2d79260.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #33908 has started for   PR 6555 at commit 6e0942d.

+1. LGTM

Test build #33908 has finished for   PR 6555 at commit 6e0942d.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Hmm... the build failure doesn't seem related to the changes, but I'll take another look.

Merged build triggered.

Merged build started.

Test build #33909 has started for   PR 6555 at commit b7a0349.

Test build #33909 has finished for   PR 6555 at commit b7a0349.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Some of the test code's transitive dependencies seem to pull in Preconditions. How about including Guava as a test dependency? Does that complicate things?

Hmm. Wonder how those tests passed locally. Yeah, I'll add the dependency in test scope.

Merged build triggered.

Merged build started.

Test build #33914 has started for   PR 6555 at commit c38228d.

Test build #33914 has finished for   PR 6555 at commit c38228d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Merged build triggered.

Merged build started.

Test build #33994 has started for   PR 6555 at commit c0ceea8.

Lgtm pending tests

Test build #33994 has finished for   PR 6555 at commit c0ceea8.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

LGTM. Merging this, in master and branch 1.4.


Fix wrong argument in test case, missing argument in keyword call (deployment_mode)

Tested here rhoai-test-flow/120 PASSED

Verified in rhoai-test-flow/120


Use rekor client library from upstream

We have a home brew rekor client library as we just need to hit two API endpoints and we keep the data in a pretty unstructured format when passing it on to the Rego policies. That said, it might be better to use if the upstream rekor client library if we can.
@developer-guy

Ah sure ! Thank you for this @nsmith5. Would you mind assigning it to me then I'll start working on it ASAP (tonight 🥳) I'd love to help when I found a chances like this.😍

Yup, can you point me to the client library you're talking about? I found some client code in the rekor repo but it was pretty dense and importantly it was strongly typed which doesn't work well with Rego policy.

These are the ones I thought can help us to accomplish this:

https://github.com/sigstore/rekor/blob/97f2f392dda2500dfc3ca4f05d8fafcf16c0ab78/pkg/client/rekor_client.go?_pjax=%23js-repo-pjax-container%2C div[itemtype%3D"http%3A%2F%2Fschema.org%2FSoftwareSourceCode"] main%2C [data-pjax-container]#L28
https://github.com/sigstore/cosign/blob/ef380f01336989a4e6223d00b2a79db3daac99f3/pkg/cosign/tlog.go?_pjax=%23js-repo-pjax-container%2C div[itemtype%3D"http%3A%2F%2Fschema.org%2FSoftwareSourceCode"] main%2C [data-pjax-container]#L134

Does it make sense? @nsmith5

I don't know that this makes sense to me to be honest. It pulls in a lot of dependencies without a clear benefit in my eyes. Closing for now


Individual Issues (Team Stand-up Meeting)

.....

Finished Scrum Board, Agile Manifesto, and developed roles, Start working on 5 minute video


Use OK instead of skipping tasks.

Currently the tasks do a GET check then run/skip tasks according to the value of the check to implement pseudo idempotency. Would be more preferable if I can just use the response (either HTTP or the error code) to categorize the task as OK/Changed.

While this is nice, the current role is able to process 5 (existing) real server in 5 seconds since it only uses 1 GET request for all entry, while if I use "OK" it takes 16 seconds, since it will do HTTP POST/PUT request for every entry, even when the entry is already exist.


CI failure: test_function_id_complex_match

https://github.com/fireeye/capa/runs/2477663106

oh i had a stale .viv file (facepalm)

the common sig files weren't registered with our unit tests.


Update privesc15-PassExistingRoleToNewLambdaThenInvoke.tf

Shouldn't we need also the "lambda:CreateFunction" privilege here?
Card
Details

Thanks for catching this @pasqua1e!!


Allow flag to suppress idsvr.session cookie

@brockallen I want to remove idsvr.session on server side as i am unable to signout fron mvc application

Session Cookie on Server Side?
Session Cookies are never stored on Server. They are always stored on client machine only.

We emit that cookie as part of our support for the session management spec: https://openid.net/specs/openid-connect-session-1_0.html
Are you saying you would want a flag to disable it?

Yeah what if i want to clear that session..
I tried to edit idsvr.session value on client side but nothing changed

Right, as if today that's something you won't be able to change. I'll leave this open as a feature request.

It's possible that we rely upon the endpoint enabled/disabled to achieve this.

Great
Thankyou

Done


Added Stack and Queue in Python

Python
Stack
Using the list data type, implemented stack using the append() and pop() functions.
Queue
Using the list data type, made a queue using the append() and pop(0) functions.

Hey @aniketsharma00411. Thank you for your feedback. Generalized in what terms exactly?

Use classes to create a queue or stack object. Currently, we are working on a list only.

@aniketsharma00411 Thank you. Could you please check the code now?

Now its fine.


Fix CommonCrawlFetcher handling of path-only redirects

If the Location field in the response header contains a path (e.g. /ignite/), then we need to combine that with the original URL's hostname to build a new URL.
Currently we just use the path as a URL, which then triggers a MalformedURLException.

Fixed


Fix #16068: wrong return value in yii\web\CookieCollection::has

Q
A

Is bugfix?
yes

New feature?
no

Breaks BC?
no

Tests pass?
yes/no

Fixed issues
#16068

Please check the typos. Thanks.

Merged. Thank you!


Mark required fields

Currently it's not possible to differentiate between required fields, and fields with an empty string as the default (making them optional)
Fields without any default values at all, should be marked as required.
Either with a new column, or using a specific marker for the default values(eg an emoji)

I see that there is already an icon for an empty default (⛔).
In my opinion, a column "Required" would be clear and less ambiguous. For example, this is what GitLab uses to document their REST API (example: https://docs.gitlab.com/ee/api/groups.html#list-groups).


Another test failure on 32bit architectures

Hi,
I've got reports of prometheus 0.15.1 failing to build due to tests not passing on i386. armel, and armhf. In the three cases the message is the same:
=== RUN TestEvictAndLoadChunkDescsType0
time="2015-08-25T03:56:13Z" level=info msg="Loading series map and head chunks..." file=storage.go line=263
time="2015-08-25T03:56:13Z" level=info msg="0 series loaded." file=storage.go line=268
time="2015-08-25T03:56:13Z" level=info msg="Stopping local storage..." file=storage.go line=284
time="2015-08-25T03:56:13Z" level=info msg="Stopping maintenance loop..." file=storage.go line=286
time="2015-08-25T03:56:13Z" level=info msg="Maintenance loop stopped." file=storage.go line=858
time="2015-08-25T03:56:13Z" level=info msg="Stopping chunk eviction..." file=storage.go line=290
time="2015-08-25T03:56:13Z" level=info msg="Chunk eviction stopped." file=storage.go line=678
time="2015-08-25T03:56:13Z" level=info msg="Checkpointing in-memory metrics and chunks..." file=persistence.go line=541
time="2015-08-25T03:56:13Z" level=info msg="Done checkpointing in-memory metrics and chunks in 589.913µs." file=persistence.go line=561
time="2015-08-25T03:56:13Z" level=info msg="Local storage stopped." file=storage.go line=302
--- FAIL: TestEvictAndLoadChunkDescsType0 (0.21s)
	storage_test.go:1176: Expected number of chunkDescs to decrease, old number 79, current number 79.

Any idea of what can be causing this? Another unspecified behaviour maybe?
You can get the full logs here:
https://buildd.debian.org/status/fetch.php?pkg=prometheus&arch=armel&ver=0.15.1%2Bds-1&stamp=1440475230
https://buildd.debian.org/status/fetch.php?pkg=prometheus&arch=armhf&ver=0.15.1%2Bds-1&stamp=1440474989
https://buildd.debian.org/status/fetch.php?pkg=prometheus&arch=i386&ver=0.15.1%2Bds-1&stamp=1440474999

Thanks for the report. I guess I'm most qualified to investigate. As usual, very overloaded, so despite this being assigned to me, anybody feel free to jump in... :)

This happens on 64bit as well: #944 -- I hold a local patch that disables the test.

If this is a time-dependant test, then I guess I will disable it completely for the Debian build...

Closing this one, as it is a dupe of https://github.com/prometheus/prometheus/issues/944.


Admin user and logout not showing on dashboard

Describe the bug
I am using buildAuthenticatedRouter and that works fine, users can log in successfully.
const router = AdminBroExpressjs.buildAuthenticatedRouter(adminBro, {
authenticate: async (email, password) => {......}
The authentication function returns the email correctly, but it does not display the current logged-in user on the dashboard, hence there is also no "logout" option.
Any idea what I can be missing?
Installed libraries and their versions
"@admin-bro/express": "^3.1.0",
"@admin-bro/sequelize": "^1.2.1",
"admin-bro": "^4.0.1",
"admin-bro-expressjs": "^2.1.1",

@kosie99, did you figured out what was missing in your configuration? My setup isn't showing "logout" option too!


Error handling dates since 1/1/2022

The get_min_max_dates() function produces an error when original dates are later than 1/1/2022, based on hide_in_plain_sight.py Line 793:
        return max(min_date, datetime.datetime.strptime("1/1/2000", "%m/%d/%Y")), min(
            max_date, datetime.datetime.strptime("1/1/2022", "%m/%d/%Y")
        )

Instead of hard coding 1/1/2022, I suggest replacing this with datetime's date.today() functionality to address this issue.

@afamiliar how were you able to run the de-id code , can i pass the output from the transformer model to replace the identified entities with other values


C++ library issue

I am working on a MAC. yesterday i updated my OS to Big SUR 11.1, after i did i have getting error codes on my #include . These were not an issue prior to the upgrade.

this seems unrelated to vscode


Update sample files

Signed-off-by: Aadhitya A<EMAIL_ADDRESS>Description
This PR fixes #29
Notes for Reviewers
Signed commits

[x] Yes, I signed my commits.

#29

Looks good! Also next time in PR mention issue number so it could be tracked, #29

This PR is related to fix the issue, but some components still need update, that's why not mentioned yet

@alphaX86 approved, feel free to merge.

Copy that


Add route to show per-host volumes

The route is /servers/<server-id>/volumes.
It opens a page listing the volumes on the specified server.
Closes #1688.

Signed-off-by: Igor Pashev<EMAIL_ADDRESS>

This change is

Everything looks good overall, just create a separate variant for ServerVolume page.

Done!


Adding cdnPath for own CDN-Handling

Hi,
i added an option "cdnPath" for own, single CDN-Handling.
In one project i run an own, cookie-less CDN to avoid useless data transfer
and speed up responses, but building the site with a grunt workflow locally..
With this changes i can tell cachebust to rate paths with this prefix as local.
After busting i can upload the assets to the cdn and the html-files to the webserver
and everything works beautifully ;)
Maybe you want to implement it to your version.
Cheers,
lietzi

Really like this idea so thanks for the PR.
Could you add a test case for this please. You'll also have some merge conflicts to resolve.

Thank you for your great work!


Add some lines to avoid minor compilation errors when using PlatformIO.

Add a forward declaration in examples/common/sensors/RAK1903_Optical_OPT3001/RAK1903_Optical_OPT3001.ino for printError() because it's used in configureSensor() before its definition.
src\main.cpp: In function 'void configureSensor()':
src\main.cpp:29:5: error: 'printError' was not declared in this scope

Add #include <Arduino.h> in examples/common/sensors/RAK1904_Accelerate_LIS3DH/RAK1904_Accelerate_LIS3DH.ino to avoid messages like this:
src\main.cpp: In function 'void lis3dh_read_data()':
src\main.cpp:22:3: error: 'Serial' was not declared in this scope

@johansmacias
Thank you.


Manually assign nodes for group node.

Hi team. First of all, thank you for this great script. Is there any possibility to add nodes programmatically to a group node?
Appreciate your valuable response.
Tnanks

View:

https://github.com/jerosoler/Drawflow/issues/423

Here I have attached loop video for a great understanding. Can you please check that? Thanks
https://www.loom.com/share/919807af068c4addadcada530c28d810

I understand that you are not adding the node to the group until you move the node.