feat: [IDP]: Added the docs on GitHub PR Card

Thanks for contributing to the Harness Developer Hub! Our code owners will review your submission.
Description

Please describe your changes: __________________________________
Jira/GitHub Issue numbers (if any): ______________________________
Preview links/images (Internal contributors only): __________________

PR lifecycle
We aim to merge PRs within one week or less, but delays happen sometimes.
If your PR is open longer than two weeks without any human activity, please tag a code owner in a comment.
PRs must meet these requirements to be merged:

[ ] Successful preview build.
[ ] Code owner review.
[ ] No merge conflicts.
[ ] Release notes/new features docs: Feature/version released to at least one prod environment.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://6732f21e5c8bad56ae48fc19--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://6732f2a7a803a755ca8697c7--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://6732f5f48a62cd595487e6a2--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://67343e2534f7e7757e1e3bb3--harness-developer.netlify.app


Check for EK.Public

Current code only looks at EK.Certificate
Not all TPMs have EK Certificates, some of them only have EK.Public

LGTM.  This will be a great upstream contribution.  This documentation explains how not all manufacturers provide the certificate.  @cwkinard we need to document this in our reference arch.


Remove unneeded events

I removed events are not needed for correct cursor highlighting. Moreover, they cause issues when changing themes because the code remember colors once at startup.
Closes #5.

Oh, just realized that this may be expected behavior to highlight the cursor line?


Test explorer: "Run test" works while "Debug test" fails to build FSharp compiler tests

Describe the bug
In the situation detailed in "Steps to reproduce", I can run any test from the test explorer by clicking Run Test. However, if I click Debug Test, I get the error message shown below. Note that in both cases, I see a notification Running MSBuild 'Build' target on '/workspaces/fsharp/tests/FSharp.Compiler.ComponentTests/FSharp.Compiler.ComponentTests.fsproj'.
Error message in the TEST RESULTS window:
/workspaces/fsharp/FSharpBuild.Directory.Build.props(3,3): error : Could not resolve SDK "Microsoft.DotNet.Arcade.Sdk". Exactly one of the probing messages below indicates why we could not resolve the SDK. Investigate and resolve that message to correctly specify the SDK.
/workspaces/fsharp/FSharpBuild.Directory.Build.props(3,3): error :   SDK resolver "Microsoft.DotNet.MSBuildWorkloadSdkResolver" returned null.
/workspaces/fsharp/FSharpBuild.Directory.Build.props(3,3): error :   Failed to load NuGet settings. Required environment variable 'HOME' is not set. Try setting 'DOTNET_CLI_HOME' or 'HOME' and running the operation
/workspaces/fsharp/FSharpBuild.Directory.Build.props(3,3): error :   MSB4276: The default SDK resolver failed to resolve SDK "Microsoft.DotNet.Arcade.Sdk" because directory "/usr/share/dotnet/sdk/8.0.100-rc.1.23463.5/Sdks/Microsoft.DotNet.Arcade.Sdk/Sdk" did not exist.

/workspaces/fsharp/FSharpBuild.Directory.Build.props(3,31): error MSB4236: The SDK 'Microsoft.DotNet.Arcade.Sdk' specified could not be found. [/workspaces/fsharp/tests/FSharp.Compiler.ComponentTests/FSharp.Compiler.ComponentTests.fsproj]

Steps to reproduce

Run Dev Containers: Clone Repository in Named Container volume ... and clone the dotnet/fsharp repository.
Wait for the dev container to build and the test explorer to discover the tests
Run any test in FSharp.Compiler.ComponentTests (=> succeeds)
Debug a test (=> above error message)

Link to sample reproduction
FSharp
Expected behaviour
See the test running in the debugger
Machine info

OS: Windows 11 host with Docker; dev container as specified by the fsharp repository
.NET SDK version: 8.0.100-rc.1.23463.5
Ionide version: 7.13.0

Additional context
Work-around: create a .NET Core Test with debugger task that runs dotnet test. Run the task and attach the debugger.

This is probably related to BUILD_USING_DOTNET. I'm guessing we're not passing along environment variables when we set up for debugging
cc @farlee2121

@Martin521 can you try forcing BUILDING_USING_DOTNET to be true in the Directory.Build.props? It'll help us figure out if it's the root of the issue.

I'm still trying to get the fsharp repo building with the dotnet cli, but the env theory seems probable.

BUILDING_USING_DOTNET is set to true in the Dockerfile, and I can verify it in the terminal. At some point I also tested setting it in Directory.Build.props.user and that did not help. I can try that again.

I'm still trying to get the fsharp repo building with the dotnet cli, but the env theory seems probable.

You will probably know this, but just in case: Make sure you build FSharp.Compiler.Service.sln and not FSharp.sln

Actually, with BUILDING_USING_DOTNET set in Directory.Build.props.user, the build succeeds, but then I get runtime initialization error that I also had before, related to
            let pathToArtifacts = Path.GetFullPath(Path.Combine(Path.GetDirectoryName(Assembly.GetExecutingAssembly().Location), "../../../.."))
            if Path.GetFileName(pathToArtifacts) <> "artifacts" then failwith "CompilerAssert did not find artifacts directory --- has the location changed????"

in the test utilities. This comes from .../Debug/... missing in the artifacts path.

Troubles Running dotnet/fsharp
Good callout, but I am building with FSharp.Compiler.Service.sln.
I made sure I had the latest VisualStudio Preview, the latest .NET 7, the correct preview version of .NET, and pulled a clean copy of the repo.
I'm still getting the same behavior. It builds with arcade, but dotnet build .\FSharp.Compiler.Service.sln still throws
Microsoft.FSharp.Targets(331,9): error MSB6006: "dotnet.exe" exited with code 1.

It does this for 13 of the 19 projects. The referenced line (Microsoft.FSharp.Targets(331,9)) happens to be the Fsc invocation.
Env Experiment
Since the build props worked, that seems to confirm issues with environment variables not getting passed along.
While I currently can't test against the fsharp repo, I did draft a change you can test out.
Initialization Error
As for the initialization issue, it'd be worth checking the Assembly.GetExecutingAssembly(). Sounds like it might change when debugging. You might be able to get away with using preprocessor directives.

Thanks a lot. Unfortunately, I cannot test the draft right now as I don't have the necessary environment to build Ionide.
For building the compiler (the current fsharp/main), you probably need the .net8 sdk.
As for the initialization error, I assume it is also related to the environment variables.

Troubles Running dotnet/fsharp
Good callout, but I am building with FSharp.Compiler.Service.sln.
I made sure I had the latest VisualStudio Preview, the latest .NET 7, the correct preview version of .NET, and pulled a clean copy of the repo.
I'm still getting the same behavior. It builds with arcade, but dotnet build .\FSharp.Compiler.Service.sln still throws

Microsoft.FSharp.Targets(331,9): error MSB6006: "dotnet.exe" exited with code 1.

It does this for 13 of the 19 projects. The referenced line (Microsoft.FSharp.Targets(331,9)) happens to be the Fsc invocation.
Env Experiment
Since the build props worked, that seems to confirm issues with environment variables not getting passed along.
While I currently can't test against the fsharp repo, I did draft a change you can test out.
Initialization Error
As for the initialization issue, it'd be worth checking the Assembly.GetExecutingAssembly(). Sounds like it might change when debugging. You might be able to get away with using preprocessor directives.

You can either pass /bl switch which will generate binlog, or /v:n which will produce detailed logs

Thanks @vzarytovskii. That got me a more detailed error.
I'll have to dig when I get back from my trip.

I got the repo building and running tests via dotnet test, but the test explorer doesn't pick up any of the tests for me.
It doesn't think any of the projects are test projects because it doesn't seem to think any of them reference Microsoft.TestPlatform.TestHost or Microsoft.NET.Test.Sdk. Trying to explicitly add those packages references results in a duplicate reference build error.  I'm not sure why it would work for @Martin521 and not for me...

I have worked with the repo only in Dev Container, and there everything works like a breeze (including test discovery of the Test Explorer and running tests from the Test Explorer), except for debugging tests out of the Test Explorer.

If you follow the "Steps to reproduce" mentioned in the issue text (which takes only a few minutes), you should be able to see it.

I suppose I didn't truly follow the reproduction steps.
I wouldn't think the environment should affect the perceived packaged references this way, but the evidence seems to say otherwise...
Alas, while I've got the fsharp devcontainer running, it looks like the vscode debugging doesn't want to play nice with running against a dev container. You might need to get the Ionide repo running inside the dev container to further diagnose the issue / see if the env forwarding fixes the issue.
I did otherwise verify that accessing env variables behaves differently when running versus debugging. Seems like a bug in any case. The draft change does fix this issue, so I'm going to PR it.

Thanks!


Update 4_rowlevelsecuirty.md rename cudos to cid

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Hi @vmindru are you still working on this PR? If so can you address the requested changes and resolve the conflicts please.

will abandon this one, and pusha  a new one.


Dies after a few seconds.

This container seems to die after a few seconds. I had it working twice previously, both times it has died then continuously dies every time I start it in less than 5 seconds. This is the command I'm using to run docker:
docker run -d  --link postgres:postgres -p 22:22 -p 3000:3000 -v /var/gogs:/data codeskyblue/docker-gogs

Any idea what's causing this? I can't seem to find a helpful log (however the gogs log seems to be starting with sqlite3.)
Thank you!

Fixed ssh connect problem. Maybe this problem fix too.

The -d was causing the issue because I was starting it from within a systemd file. I only found documentation on it recently but it causes it to hang up. Thank you for your help!


TypeError: Cannot read property 'prototype' of undefined(Node.js)

This example showing creation of basic shapes using node.js ...
            var occ = require('occ')
			// construct a box
			var box = occ.makeBox([0,0,0],[100,100,50])
			// construct a cylinder
			var cyl = occ.makeCylinder([50,50,-10],[50,50,60],40)
			// cut the box with cylinder
			box = occ.cut(box,cyl)
			// save result to a STEP file
			occ.writeSTEP("somefile.step",box)

I am going to run the above program using node.js but I am getting this error ..
			D:\node-file>node test.js
			adding occ.Mesh.prototype.toJSON function
			D:\node-file\node_modules\occ\lib\mesh.js:17
			  occ.Mesh.prototype.toJSON = function() {
					  ^
			TypeError: Cannot read property 'prototype' of undefined
				at Object.exports.init (D:\node-file\node_modules\occ\lib\mesh.js:17:11)
				at Object.<anonymous> (D:\node-file\node_modules\occ\lib\occ.js:10:19)
				at Module._compile (module.js:460:26)
				at Object.Module._extensions..js (module.js:478:10)
				at Module.load (module.js:355:32)
				at Function.Module._load (module.js:310:12)
				at Module.require (module.js:365:17)
				at require (module.js:384:17)
				at Object.<anonymous> (D:\node-file\test.js:1:73)
				at Module._compile (module.js:460:26)

How to solve this issue? Any suggestion?

what is the result of:
git clone https://github.com/erossignon/node-occ.git
cd node-occ
npm install
npm test

Thanks for your quick response.
I have downloaded node-occ.git and followed your steps but not able to installed module. I have attached both cmd error and debug.log images.
CMD log:

Debug log:

From cmd error I found that it requires "VCBuild.exe" and for that it shows two options, either Microsoft Windows SDK or  Microsoft Visual Studio 2008.
I have already installed vs2012 and I open up "\build\binding.sln" and try to build project but gives numbers of files missing error at compile time and the below is what I get when tried to build project.

What I'm missing or doing wrong to install desire modules? Please help me out.

Hi,
I have improved the wiki page that describes the steps to follow to get the prerequisite installed on your computer ( Visual Studio , cmake, OpenCascade libraires )

I have downloaded all the pre-requistes software and followed your steps but not able to installed module.
c:\tools\cmake\bin\cmake  -D OCE_INSTALL_PREFIX:STRING='C:/OCE-13' -D OCE_DRAW:BOOLEAN=FALSE -D OCE_OCAF:BOOLEAN=FALSE -D  OCE_VISUALISATION:BOOLEAN=FALSE -D OCE_DISABLE_X11:BOOLEAN=TRUE -D OCE_USE_PCH:BOOLEAN=TRUE  ../oce
Above command ran successfully but when I fired msbuildoce.sln this command and its completed with 37 warning and one error. I have attached msbuild error..
MsBuils error:

a build.bat script has been provided, this script is used by the AppVeyor continuous integration platform but can also be used to build node-occ on your windows computer.
Make sure you have Visual Studio 2013 and git installed first.


Is the backbone Denoising Unet need training？

Is the backbone Denoising Unet need to be fine-tuned? Or it is frozen as the SD 1.5 model?
Since I only see the Temporal module/Appearence Net/Densepose ControlNet in the given checkpoints, I guess the Denoising Unet need not training?

yes, we didn't finetune the UNet.


Check for XSS, e.g. using https://github.com/hahwul/dalfox

what is better: xsser or dalfox?

what is better: xsser or dalfox?

I have had better experiences with dalfox. dalfox is still being maintained, I think the last commit from xxser was 2 years ago.

Hello,
thanks for the response! Would you be willing to integrate dalfox into Artemis?

Yes, i will give it a try 😄

Just learned that another contributor is integrating Dalfox into Artemis, so let's avoid duplicating work!


Specify order of list elements in list constructing functions

CIR-2017-220
Specify order of list elements in list constructing functions
Overview
Using the collect() aggregation function, one can create a list of items that fall in a certain group. Items come from the MATCHed graph objects or from previous subqueries. However, the order of elements is not explicitly specified neither in the function call, nor in the order of processing (which absolutely makes sense).
Request
Explicit specification for the list item sorting should be given using an optional ORDER BY specifier, sorting in ascending order, if explicit direction is not given.
For the sorting expression, the current restrictions apply: sorting can't be done on graph nodes and relationships, but it can indeed be done on their properties, or in general, on expressions that evaluate to comparable result.
Proposal for current syntax
collect( expression [ ORDER BY expression [ ASC[ENDING] | DESC[ENDING] ] ] )
Proposal for the new aggregation syntax proposed in CIP2017-04-13 (#218)
collect OF expression [ ORDER BY expression [ ASC[ENDING] | DESC[ENDING] ] ]
Examples
Example 1: collect items to a single list
For demonstration purposes, we use a locally created list as item source. By unwinding, 1st subquery streams its result of 10 records to the 2nd subquery which then collects it. Current Neo4j v3.1 seems to collect items in the same order the 1st subquery returned items. However, when it comes to parallel query execution, this assumption might be a bottleneck.
UNWIND range(1, 10) AS i     // 1st subquery
RETURN collect(i) AS l       // 2nd subquery

Explicit ordering could be done as follows.
For the current syntax:
UNWIND range(1, 10) as i                    // 1st subquery
RETURN collect(i ORDER BY i ASC) AS l       // 2nd subquery

For  CIP2017-04-13 syntax
UNWIND range(1, 10) as i                      // 1st subquery
RETURN collect OF i ORDER BY i ASC AS l       // 2nd subquery

Example 2: group graph objects based on parity of their id-s
We create 10 nodes with the label CollectExample having ids ranging from 1 to 10:
UNWIND range(1, 10) AS i
CREATE (:CollectExample {id: i})

Then we collect nodes grouped by parity of their id property:
MATCH (n:CollectExample)     // 1st subquery
WITH n.id%2=1 AS odd, n
RETURN odd, collect(n) AS l  // 2nd subquery

Explicit descending ordering on the node id could be done as follows.
For the current syntax:
MATCH (n:CollectExample)                         // 1st subquery
WITH n.id%2=1 AS odd, n
RETURN odd, collect(n ORDER BY n.id DESC ) AS l  // 2nd subquery

For  CIP2017-04-13 syntax
MATCH (n:CollectExample)                          // 1st subquery
WITH n.id%2=1 AS odd, n
RETURN odd, collect OF n ORDER BY n.id DESC AS l  // 2nd subquery

Related to #190

For the sorting expression, the current restrictions apply: sorting can't be done on graph nodes and relationships, but it can indeed be done on their properties, or in general, on expressions that evaluate to comparable result.

The comparability CIP actually defines that sorting/ordering is defined for all values, also entities.


[Fix]: Adding compatibility for the search shortcut to other keyboard layouts

If you're using a keyboard layout different to QWERTY  like Dvorak or Colemak the shortcut of CMD+K will not work since the k is in another position, but if we change from event.code to event.key it will work. The other possibility
is with event.keyCode that returns on all the layouts 75 but is not so clear what we are checking then.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

[ ] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
[ x] This message body should clearly illustrate what problems it solves.
[ ] Ideally, include a test that fails without this PR but passes with it.

Tests

[ ] Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

[ ] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

thanks!


how to  change a pod's bandwidth dynamically？

we can set a pod's bandwidth with a annotation kubernetes.io/ingress-bandwidth in k8s,but if the annotation  change, it cannot to be effective  right now,is there any solution in calico to make the change take effect right now without kill the pod?

Right now, Calico doesn't offer anything beyond the kubernetes annotation for this, so you would need to restart the pod.


Should sponge's have a reset() method

This is useful in low memory environments, but I'm not sure if its worth the complexity
Some related issues on golang: https://github.com/golang/go/issues/35633

I doubt low memory environments need much polymorphism, and snarks can never use reset themselves, so maybe default fn like below, or ignore it for now, or even an extension trait if the default fn messes up snark code somehow.
/// Reset state for re-use in low memory environments.
///
/// We expect rustc optimizes this well enough, so little reason for manual implementations,
/// but do benchmark your own use cases if working in a low memory environment.
fn reset(&mut self, params: &Self::Config) {
    let mut n = Self::new(params);
    core::mem::swap(self,&mut n);
}


FPT_ROT_EXT.3 Hardware component integrity

This one is objective, so the inclusion criteria are less important. This is more of a heads-up than an actual requirement.
Nevertheless, this requirement can invoke the admin authentication and management function requirements in the unlikely event that it is included in an ST.

It would be nice to reference more standards here. But they might not be very mature.

Yeah, whatever


support NUM_ENTER

The numlock enter key should work the same way as the regular enter key.

Fixed.


Fixed Chat Channel Switcher

It appears the command to change the chat channels has changed from the towny:g format to townychat:g. Thus the switcher button doesn't work anymore. This PR simply changes the chat channel commands to use townychat instead of towny.

Heyo! I'm generally dissatisfied with the way the Chat Channels feature currently works. I believe it's due for a rewrite, so I've purged the feature from the latest patch.


[MINOR][DOC] Add more built-in sources in sql-programming-guide.md

What changes were proposed in this pull request?
Add more built-in sources in sql-programming-guide.md.
How was this patch tested?
Manually.

Can one of the admins verify this patch?

Merging in master/branch-2.0. Thanks!


The webview find widget is focusable while hidden

Microsoft/vscode#67509
Repro:

Open PR ext description page
Focus something, shift+tab until you hit the start of the screen

There are 4 focusable items, close, next match, previous match and the find input.

@Tyriar
@mjbvz
FYI:  started on this and I can reproduce and see it.

simpleFind transitions in and out with animation, hidden only because of z-index and/or overflow.
The widget always has display type:flex , therefore the four tabs stops for the buttons and input are always in the tabIndex order
fix should be simple, however, there is an interaction between the animation and the display mode
such that simultaneously going from display:none => flex messes up the animation.  I'm working on separating the display mode from the transition to see if that will work.

I have to do more experiments , May have a question or two later...

See PR: #68463
Verification:
Use a screen reader with screen output on so you can see and track each tab stop

Open the new pull request extension page
Click on the upper pane to begin focus there
Tab through the various toolbar buttons , after dependencies the next tab SHOULD land on
With the webview not the simpleFind widget.

NVDA Output:  with visibility fix (correct output, no tab stops within the hidden simpleFind)
Extension: GitHub Pull Requests - vscode - Code - OSS Dev  document
 tool bar Disable▼  button Uninstall  button tool bar Contributions  button  Lists contributions to VS Code by this extension Changelog  button  Extension update history, rendered from the extension's 'CHANGELOG.md' file Dependencies  button  Lists extensions this extension depends on frame frame scroll to top button  data:text/html;charset=utf-8,%3C%21DOCTYPE%20html%3E%0D%0A%3Ch.... (truncated) graphic Extension: GitHub Pull Requests - vscode - Code - OSS Dev  document button scroll to top
NVDA Output: original scenario without fix (can see tabs stops in widget)
``
the marketplace
link  https://aka.ms/vscodepr-download
Extension: GitHub Pull Requests - vscode - Code - OSS Dev
tool bar
Disable▼  button
Uninstall  button
tool bar
Contributions  button  Lists contributions to VS Code by this extension
Changelog  button  Extension update history, rendered from the extension's 'CHANGELOG.md' file
Dependencies  button  Lists extensions this extension depends on
Find  edit  Find
Find
blank
Previous match
button  Previous match
Next match
button  Next match
Close
button  Close
frame
frame
list  with 7 items
the marketplace
link  https://aka.ms/vscodepr-download
scroll to top
button  data:text/html;charset=utf-8,%3C%21DOCTYPE%20html%3E%0D%0A%3Chtml%20lang%3D%22en%22%20style%3D%22width%3A%20100%25%3B%20height%3A%20100%25%22%3E%0D%0A%3Chead%3E%0D%0A%09%3Ctitle%3EVirtual%20Document%3C%2Ftitle%3E%0D%0A%3C%2Fhead%3E%0D%0A%3Cbody%20style%3D%22margin%3A%200%3B%20overflow%3A%20hidden%3B%20width%3A%20100%25%3B%20height%3A%20100%25%22%3E%0D%0A%3C%2Fbody%3E%0D%0A%3C%2Fhtml%3E#
list  with 7 items
``


Is this code compatible with SUD V6 ?

Hi,
Is this code compatible with SUD V6 ? If no, what modifications have to be done ? (productId ? ...)
Best regards.

That was what this was built to work with but I don't actively maintain this anymore, as I don't use Seneye with my tanks. You're welcome to take this code and continue to build on it if you want to


Fixed #386 - Go to Home Page on 404 page should have margin from footer

Before

After

@rohansx @k-deepak04 Merging this PR closes issue #386


Using the universal QR scanner to add Custom Token, the wallet doesn't load the token information

Using the universal QR scanner to add Custom Token, the wallet doesn't load the token information
after the above process, the scanner in ADD/Hide token stop working, don't pick up QR Code

after the above process, the scanner in ADD/Hide token stop working, don't pick up QR Code

Sounds like same problem as #2164


Add 'json stringifier' option

Fixes https://github.com/expressjs/express/issues/4453
Please direct all discussion to the issue page

Valecia G Rodriguez
On Thu, Dec 24, 2020, 16:30 Ray Hammond<EMAIL_ADDRESS>wrote:

@rheh approved this pull request.
LGTM
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/expressjs/express/pull/4454#pullrequestreview-558717146,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AO5BW2Z4D22467X3GW3WCPTSWOXJBANCNFSM4TICF4NQ
.

Why is this PR blocked? Could any reviewer have an eye on it?


Fix build on OSX with CMake version >= 3.4

The new CMake version 3.4 has split <FLAGS> into <FLAGS> <INCLUDES>, so the
assembler invocation was not passing include paths anymore.
This fix adds the <INCLUDES> to the CMAKE_ASM_COMPILE_OBJECT variable
in the root CMakeLists.txt.

Fixes #582

@dotnet-bot test this please

clang: error: no such file or directory: 'INCLUDES'

@janvorli PTLA

@gkhanna79 - I've hoped the older version could ignore the unknown "tag", but obviously it doesn't. I couldn't install older cmake on my mac anymore, so I have used the CI as a mean to verify that.
So we'll either have to set the cmake 3.4 as the minimum dependency or make this change conditionally based on cmake version.

make this change conditionally based on cmake version.

It would be nice to make this conditionally on cmake version.

I concur with Jan - it will be good to have it conditionally based upon CMake version.

As you can see, I have come to the same conclusion.

Could you update this as well, towards the end?
https://github.com/dotnet/corert/blob/master/Documentation/prerequisites-for-building.md

@schellap Do you mean to update it to say that any version would work?

Yes @janvorli.

@schellap done. I've removed the explicit version number from the text.

@dotnet-bot test this please

@janvorli this PR https://github.com/dotnet/corert/pull/580 needs to go in before your CI can be good, can you wait to test a few mins?

All the tests are failing unrelated to my change (they all passed, then I've updated the documentation file and now they are failing). @gkhanna79, do you have any idea what could be going on?
14:06:29 Time elapsed 00:00:03.0729787Input Assembly: d:\j\workspace\dotnet_corert\debug_prtest_windows_nt\tests\src\Simple\Add1\bin\Debug\dnxcore50\Add1.dll
14:06:29 Warning: No files matching d:\j\workspace\dotnet_corert\debug_prtest_windows_nt\tests\\..\bin\Product\Windows_NT.x64.Debug\.nuget\publish1\sdk\System.Private.CoreLib.dll
14:06:29
14:06:29 Unhandled Exception: System.IO.FileNotFoundException: Assembly not found: System.Private.CoreLib
14:06:29    at ILCompiler.CompilerTypeSystemContext.GetModuleForSimpleName(String simpleName)
14:06:29    at ILCompiler.Compilation..ctor(CompilationOptions options)
14:06:29    at ILCompiler.Program.SingleFileCompilation()
14:06:29    at ILCompiler.Program.Run(String[] args)
14:06:29    at ILCompiler.Program.Main(String[] args)
14:06:30 Microsoft .NET Development Utility CoreClr-x64-1.0.0-rc1-16231

@schellap Sure, thanks for the heads up. @gkhanna79, ignore my question then.

@schellap The error appears to indicate that --native-directory change from Bryan is kicking in. Can you confirm it? If so, why is System.Private.Corlib.dll moved to be under SDK?

@dotnet-bot test this please


Symbolic link loop for avatars/

The image was created with symbolic link loop for avatars/ folder
/opt/seafile# ls /shared/media/avatars
ls: cannot access '/shared/media/avatars': Too many levels of symbolic links

root@4454eb18a360:/opt/seafile# ls /shared/media/avatars -al
lrwxrwxrwx 1 seafile seafile 22 Mar 10 10:46 /shared/media/avatars -> ../seahub-data/avatars
root@4454eb18a360:/opt/seafile# ls /shared/media/custom -al
lrwxrwxrwx 1 seafile seafile 21 Mar 10 10:29 /shared/media/custom -> ../seahub-data/custom

Use absolute path should resolve the problem.

Hi,
This is something happening when Seafile is reinstalled without cleaning the old media folder, this should not appears with empty volumes. I will look if I can add a safeguard against this.
If you think this is unrelated, please provide your full run command so I can look further.

I think you are right. I used docker compose and created the named volume for media. I did not explicitly remove that named volume during reinstall.
Could you add a check that if such folder exist, clean it up or reuse it?


chore: add PR description requirements to contributing guide

On the last retrospective call, some team members raised a requirement that PR owners will provide some context to the PR within its description in order to facilitate the review process. This PR is updating the contributing guide accordingly.
Adding a paragraph to the contributing guide regarding PR description requirements. The idea is that contributors will provide some context to their PRs, so that reviewers work becomes more effective.

@eisraeli please provide an approval if you're satisfied with this change.


Seems not to work on mobile

Hello,
First of all, thank you for your work, this is really helpful for the project i'm working on.
Unfortunately, I have some issues on mobile devices : i can't click on the hotspots.
You can see an example of my issue on this website (not mine, but same issue) : http://alvaromurcia.es/Area51/bonsais/
I'm using v0.5.3, the same as your demo that seems to work. Any idea ?
Thank you in advance for your help.

+1

This seems to be due to an issue in the Marzipano tool that was fixed recently. You can probably fix it by replacing the tour's index.js by the latest version: http://www.marzipano.net/tool/template/app-files/index.js?3ba70d1

You close the issues before having a positive feedback from users :(
You recommended to update this file, however we do not use the demo file.
We did not open an issue to say that helloWorld does not work.
Everything works normally on desktop, clicking on the hotspot, loads the next scene well, however we notice a difference on mobile. Is there a different default behavior provided by the lib ?

I assumed that the issue was the same than on the provided link. Since apparently it is not, do you have a link of your own so I can investigate the issue?
Marzipano does not handle clicking or tapping on hotspots, it only positions the hotspots on the panoramas. The user needs to add the desired event handlers. In the sample-tour demo that is done here, for example.
That being said, the view control methods may interfere with these events unless stopPropagation() is called on them, since they call preventDefault() on some events.

Hi,
I have the same problem here. Getting a news index.js or the last marzipano.js does not fix the problem. It works perfectly on Desktop, but not on Android platform (neither Chrome nor Firefox). The hotspot is displayed, but it is impossible to click on it.
Do you have a fix ?
Best,
Jean


added loader and toast notification

added loader and toast notification when contact form is subimtted  #237
loader:

toast:

@Yashgabani845
please review this pr @Yashgabani845

added loader and toast notification when contact form is subimtted #237
loader:
toast:
@Yashgabani845 please review this pr @Yashgabani845

can you please review this pr @Yashgabani845

@AyushSharma72 remove unwanted packages files

@AyushSharma72 remove unwanted packages files

there are only package.json and package.lock.json files @Yashgabani845

@AyushSharma72 add package-lock.json in gitignore then make commit

@AyushSharma72 add package-lock.json in gitignore then make commit

right now i deleted the file next time i will add it to gitignore @Yashgabani845


About finetuning cost for CCM UNet.

Hi, thank you for your great work.
And I wonder how much time does it take to finetune the SD UNet to generate CCMs?
Also, I wanted to know if there are some automatic and quantitative metrics that can evaluate the effectiveness of a text-to-3D method, manually checking and user survey are two that we need to collect feedbacks ourselves.

BTW, when I am checking the codes, there are two sweetdreamer configs tagged 'stage1&2', would you please tell me what these two stages mean?

HI, we did some ablations about the source used to finetune the SD, and found that using about 20k-30k data with 1 day using 8 gpus already produces promising results. So I think finetuning the SD UNet is not a heavy work.
Evaluation text-to-3D is indeed non-trivial and needs to be explored more. User-study and evolving human as feedback are relatively reasonable metrics at present. Some works try to use GPT-4V to align the human feedback (https://arxiv.org/abs/2401.04092), and you can try it.
stage1: means using DeepFloyd-IF as the 2D diffusion prior which operates on a low resolution (64x64), which is more powerful and can align the text better
stage2: using SD21 and operated on 512 x 512 resolution
Best,
Weiyu

Thank you very much for your kind reply. I will close this one.


fix(cli): invalid plugin template

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Docs
[ ] New Binding issue #___
[ ] Code style update
[ ] Refactor
[ ] Build-related changes
[ ] Other, please describe:

Does this PR introduce a breaking change?

[ ] Yes, and the changes were approved in issue #___
[ ] No

Checklist

[ ] When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
[x] A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
[ ] I have added a convincing reason for adding this feature, if necessary

Other information

i think internal-ip is missing from the termplate's package.json

I wonder how the hell it worked on my demo plugin test.


[vm/ffi] Drive ecosystem, infra. and doc updates for FFI release

We need to flip the switch to turn on the API docs when the API is sufficiently stable.
/cc @kwalrath


Added database for plugins

Added database, cookie manager for plugins
Added copying from webview localstorage, sessionStorage

isnt cookie managed by React Native Network?

Yes they are managed, but you can't interact with them, I just made a react-native-cookies/cookies wrapper so that from the plugin you can add, modify, check, delete, clear cookies

Yes, they are managed, but you can't interact with them, I made a wrapper under react-native-cookies/cookies, so from the plugin you can add, modify, check, delete site cookies

But is cookie management that important. Instead of remove/edit one cookie, users can just open webview, old cookies will be overrided.

I don't know, but this process can be automated with these functions.

By the way, do you think I need to redo copying from webview of localStorage, essionStorage objects via java (directly).
Right now it is implemented through injecting js code

I don't know, but this process can be automated with these functions.

Cookies have been already autmatically added by React Native. So I think cookies management isnt neccessary at all.

I think it would be handy to have that option.
example
What if source has 2 APIs

with authorization only
without authorization
How to know if the user is authorized on the site?

Or another example, what if the site for some reason will store in cookies what is needed for queries?

for the authorization issue, I think you just force users to login via webview like how people are using Novel Updates.
there's no way a website would decode cookie in client site. security risks

there's no way a website would decode cookie in client site. security risks

If I'm not mistaken, there is a document. cookie.
Only it stores the cookie for the current page name=value; .
So the client has access to at least read the cookie.

There're some vulnerabilities,I can set/get/delete stored values in plugin A from plugin B code right?
Since we had plugin repositories feature, users could be nuked by some trollers

Yes, it's true, it can be fixed.
But I don't see the point of fixing it. The running plugin has too many permissions.
They could just write something like.
import { MMKV } from 'react-native-mmkv';

const store = new MMKV({ id: 'plugin_db' });
store.clearAll();

Yes, it's true, it can be fixed. But I don't see the point of fixing it. The running plugin has too many permissions. They could just write something like.
import { MMKV } from 'react-native-mmkv';

const store = new MMKV({ id: 'plugin_db' });
store.clearAll();

No, plugin does not have that privilege. They are literally standalone scripts and dont have module accesses.
The import keyword in plugin code is just a hack. import would be converted into declared require function which is refer to https://github.com/LNReader/lnreader/blob/e2d22a5b05a47b57e1f46ccfb6d8dd3ebb05bcc8/src/plugins/pluginManager.ts#L23C1-L38C3

LGTM, Im going to test in devices

You need to resolve Typescript errors. My editor is screaming


Readme.md refers to grunt but gulp is used.

Submit an Issue
Hi,
Thanks for helping us improve the Predix UI platform by submitting an issue.
Before you begin, please check the list of existing issues to avoid submitting a duplicate issue.
To help us solve this issue as fast as possible, please fill out the following sections:
Expected behavior and actual behavior:
Readme.md describes how to compile and run demo.
Steps to reproduce the problem:
git clone :)
Environment (component version number, Browser (including version), operating system, hardware, etc):
N/A

Fixed


Warnings associated with HA beta release 2021.12.0b0

Warnings after install of latest beta 2012.12.b0
https://rc.home-assistant.io/blog/2021/12/03/release-202112/#updates-for-custom-integration-developers
2021-12-04 08:29:05 WARNING (MainThread) [homeassistant.helpers.entity] Entity vacuum.robot_vac (<class 'custom_components.vorwerk.vacuum.VorwerkConnectedVacuum'>) implements device_state_attributes. Please report it to the custom component author.

Thanks, I created a patch for it.


minor text improvements

Great tutorial !
These are some fixes for the English language tutorials. I've corrected some typos and made a couple of changes to the grammar. I've tried to keep both the style or tone of your tutorials.

Thanks @jkbits1 :smile:


A dialog with message "[sprintf] unexpected placeholder" pops up when clicking 'Configure Soft Delete Policy...' for blob containers node

Storage Explorer Version: 1.23.0-dev
Build Number: 20220129.1
Branch: main
Platform/OS: Windows 10/Linux Ubuntu 20.04
Language: Chinese (simplified)
How Found: From running test case
Regression From: Previous release (1.20.0)
Steps to Reproduce

Launch Storage Explorer.
Open 'Settings' -> Application (Regional Settings) -> Select '中文(简体)' -> Restart Storage Explorer.
Expand one storage account -> Blob Containers.
Right click Blob Containers node -> Click 'Configure Soft Delete Policy...'.
Check whether the dialog 'Configure Soft Delete Policy' pops up.

Expected Experience
The dialog 'Configure Soft Delete Policy' pops up.
Actual Experience
A dialog with message "[sprintf] unexpected placeholder" pops up.

This is caused by an incorrectly translated string.

The fixed resource strings have been merged to main. This should have been fixed.

Hi @JasonYeMSFT, verified this issue on the build main/20220206.3, it also reproduces.

Verified this issue on the build main/20220212.2. Fixed.


Comparison between three values at the same time does not compile when one value comes from a Tuple

function timer() {
    return [10, "Hi"];
}

assert(0 < timer().first < 10);

The code above fails to compile in the assert line due to:
Cannot find symbol
 symbol:   method longValue()
  location: class java.lang.Object

If we use three numbers, as in 0 < 4 < 10, it works.

This one also causes the same error:
value ints = {1,2,3};
print("min is ``min(ints)``");

That was reported as ceylon/ceylon-compiler#2089 and fixed by @tombentley. This appears to also have fixed print("Time was ``timer().first``");; the original issue, three-way comparison, remains unfixed though.

It's a compiler bug, I've openned ceylon/ceylon-compiler#2096


Update Checkbox value inside Openlayers Sidebar after we change a layer visibility using JS Code

i use openlayers sidebar to manager my layers, however users can remove a layer using a button.
once the button is clicked JS changes the visibility of this layer and removes it from the map , the code used is :
item.setVisible(false);
this works however the checkbox inside sidebar remains unchanged (checked) even when the layer is no longer visibile, how can i refresh the vlaue of checkboxes (inside sidebar) knowing that openlayers generates different IDs for each box whenever its value is changed or a layer is added.
is there a code (openlayers code) to update or refresh checkboxes inside sidebar.
thank you

OpenLayers does not have a Sidebar component, are you using an extension?
Maybe this example will help with your issue: https://codesandbox.io/s/layermenu-with-state-53g4r

Sounds like you are using ol-ext, try reporting your issue there.

thanks
so true, i am using ol extension to manage my layers, i have just reported this issue there


Diferent map

Hi, I'd like to know if I can create diferente maps on diferente pages/screen. I've red that isn't multiple map, but if it's a map in page 1 and another one in page 2, is it posible ?
Thanks for helping
J

You need to create a map / destroy the map each time when you change your pages.

And how do you destroy the map ?!

map.remove()

I don´t know why, but I launch the map with
map.addEventListener(plugin.google.maps.event.MAP_READY, function ()
And it goes 3 or 4 time there, so I´ve got like 4 maps and got an error, do you have any idea why ?

map.one() insteadof map.addEventListener()


Reorganize readme

Closes #25

@homu r+

:pushpin: Commit dad9846 has been approved by poteto

:zap: Test exempted - status


Clean up ReimbursementAccountUtils

Details
There's some duplication in how errors are being set (introduced by me and so I'm making some effort to clean it up here).
This moves some of the methods in ReimbursementAccountUtils into a helper class to make them more accessible to other forms that we might be developing. All of this is subject to change depending on the forms doc - but feels like a good idea to do a quick cleanup while we figure out the next move.
Fixed Issues
$ None
Tests / QA Steps
There should be no material changes here so we're just looking for regressions

Re-test the VBA flows and make sure errors are still set
Re-test the Add personal bank account flow and make sure errors are still set

Tested On

[x] Web
[ ] Mobile Web
[ ] Desktop
[ ] iOS
[ ] Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

LGTM, tested well in both flows.

🚀 Deployed to staging by @aldo-expensify in version: 1.1.23-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
failure ❌

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to production by @francoisl in version: 1.1.24-8 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Use at least one new library, package, or technology that we haven’t discussed.

Lets review frameworks such as sass.


Add support for lazy attributes

You may defer calculation of your attributes, and even base one attribute upon another, by using functions:
def hero_factory do
  %{
    creature: "Bat",
    nickname: &"#{&1.creature}man",
    vehicle: &"#{&1.creature}mobile"
  }
end

build(:hero)
 # => %{creature: "Bat", nickname: "Batman", vehicle: "Batmobile"}
build(:hero, creature: "Spider", vehicle: "webs")
 # => %{creature: "Spider", nickname: "Spiderman", vehicle: "webs"}

This is especially helpful in complex object graphs where a record and its child both belong to the same parent.  This is common in multi-tenant apps, where many of the records belong to the same scope.  Consider a multi-site blog platform where Articles and Authors both belong to a Site, and Articles also belong to the User:
Site <---- Author
  ^          ^
  |          |
  +------- Article

Such factories would be:
def site_factory do
  %Site{
    name: "Awesome Blog"
  }
end

def author_factory do
  %Author{
    name: "Danny Tanner",
    email<EMAIL_ADDRESS>    site: build(:site)
  }
end

def article_factory do
  %Article{
    title: "The House is Full",
    site: create(:site), # Unfortunately, site creation can't be deferred or Author won't see it
    author: build(:author, site: &(&1.site))
  }
end

Without lazy attributes, this could be accomplished through something like:
def article_factory do
  # Don't do this
  site = create(:site) # Site gets created despite the attributes you pass in build/insert :(
  %Article{
    site: site,
    title: "The House is Full",
    author: build(:author, site: site)
  }
end

But with lazy attributes, we can pass in the Site, keeping your inserts to a minimum:
def article_factory do
  %Article{
    site: create(:site),
    title: "The House is Full",
    author: build(:author, site: &(&1.site))
  }
end

article_for_auto_generated_site = build(:article)
 # => %Article{site: %Site{id: 1, ...}, author: %Author{site: %Site{id: 1, ...}, ...}}

specific_site = create(:site, name: "Special Blog")
article_for_specific_site = build(:article, site: specific_site)
 # => %Article{site: %Site{id: 2, ...}, author: %Author{site: %Site{id: 2, ...}, ...}}

@moklett I've been a bit busy lately, but I like the idea of this PR. The one thing I'm concerned about is that I'm worried people will use abuse this and make some complicated factories. I think simplify the documentation and avoiding using it for associations would be the best bet. People can do that if they need to, but I think keeping the docs simpler will encourage simpler use cases. I think most of the time lazy attributes won't be needed for associations. What do you think?

👍  for this PR. I also agree this probably shouldn't be on the README but rather on the documentation for people looking for more advanced uses. I was just about to open a PR with the use case of basing attributes upon others. In my case there is correlation between the values of a couple attributes, this correlation is necessary for some tests to pass and it gets a little cumbersome at times.

@pablo-co:

I also agree this probably shouldn't be on the README but rather on the documentation

I might agree with that, if it were not for the fact that the documentation basically points users to the README for usage examples. FactoryGirl has dependent attributes documented very clearly in the [https://github.com/thoughtbot/factory_girl/blob/master/GETTING_STARTED.md](GETTING_STARTED file); since ex_machina doesn't have anything like that, the README is probably the best place.

@paulcsmith

The one thing I'm concerned about is that I'm worried people will use abuse this and make some complicated factories.

But when it's needed, it's really needed. Please merge this PR...

@moklett @paulcsmith apart from changes related to Readme.md & the branch being not up to date, is there anything specific that blocks this PR?

@moklett @gmile Sorry for the late response. We've been very busy and we can't really support a feature we're not sure we'd use, so for now we won't be merging this in, though we may in the future.
I think the best track forward would be to extract a library that uses ExMachina.Strategy. Maybe strategies for build_fn and insert_fn (not the best names, but I think you get the idea). That way the community can still use it, and if it gains enough traction we can consider moving it into core. What do you think?

@paulcsmith:

We've been very busy and we can't really support a feature we're not sure we'd use

Um, what? Clearly there's a lot of community demand for this, which means there would probably be a lot of community support. Anyway, the way that a library like this matures is for others in the community to add features that they would use, even if the original maintainer doesn't.
If you're too busy to provide this level of maintenance, perhaps an additional maintainer can step up from the community. (I'd volunteer if I actually had any experience with Elixir; since I'm a beginner with it, I think that's probably not a great idea.)

@marnen The problem is two-fold. We don't have much time, and we're not sure this is the best way to handle the problem. We don't want to add it, support it, and then find out later that it's not quite right and not be able to remove it. That is why I suggested someone making another library. That way it can be maintained separately, we can gauge how useful it is, and if it gains wide community adoption we can add it to ExMachina core. If it doesn't gain wide adoption or we find problems with it, we can think of some other way to solve the problem based on what we've learned from the other library.
I hope that makes sense

@paulcsmith I suppose it does, in the abstract, except that the idea of "not being able to remove it" seems potentially misguided to me: if code is sufficiently modular, misfeatures can always be removed (perhaps abstracted into their own libraries).
I do know that dependent attributes are one of Factory Girl's killer features as far as I'm concerned, so the idea that they might somehow not be appropriate for Ex Machina seems odd as well.


Add \U00000000 notation for large unicode literals

This matches Python and Rust
Read this section before submitting

Ensure your PR follows the External Contribution Guidelines.
Please make sure the PR has excellent documentation and tests. If we label it missing documentation or missing tests then it needs fixing!
Include the link to your RFC or bug issue in the description.
If the issue does not already have approval from a developer, submit the PR as draft.
The PR title/description will become the commit message. Keep it up-to-date as the PR evolves.
A toolchain of the form leanprover/lean4-pr-releases:pr-release-NNNN for Linux and M-series Macs will be generated upon build. To generate binaries for Windows and Intel-based Macs as well, write a comment containing release-ci on its own line.
If you rebase your PR onto nightly-with-mathlib then CI will test Mathlib against your PR.
You can manage the awaiting-review, awaiting-author, and WIP labels yourself, by writing a comment containing one of these labels on its own line.
Remove this section, up to and including the --- before submitting.

Closes #0000 (RFC or bug issue number fixed by this PR, if any)

Can we have rust's variadic syntax \u{12abc} instead? That would avoid the need to take more escape code letters.

Doesn't rust support both \U00123456 and \u{123456}?

nope, "\U00123456" yields Syntax Error: unknown character escape


'Open project in new tab' button flickers when hovering over it

Describe the bug
Sometimes the button to open a project in a new tab flickers.
To Reproduce
Steps to reproduce the behavior:

Click 'View All' next to Projects
Scroll down the page a little so the bar will overlap with some projects
Select a project, click the drop down on 'Open' at top, and click the 'New Tab'
The second time you hover on it it starts flickering wildly (it goes much faster than what the gif can show). Sometimes it does it on the first hover, sometimes it only shows on a second click. I can get it to repro easily if I right click it

Screenshots

Desktop (please complete the following information):

OS: Windows
Browser Chrome86

Fixed!


Tutorial on how to host a HTML report or website from a GitHub repo

Continuation of #222, which was solved wrt the GitHub-Zenodo integration (PR #321) but where the idea about gh-pages is still in need of another tutorial!
A volunteer with some experience and who likes to share this information is most welcome! :pray:

Officially add by @inbo/bmk to its official outputs of 2023, see https://inbojira.inbo.be/jira/browse/INBOPRJ-20578. So, added to JIRA milestone 2023.

@damianooldoni the following are the official ones for @inbo/bmk in 2023 (not this issue):

https://github.com/inbo/tutorials/issues/12 (https://inbojira.inbo.be/jira/browse/INBOPRJ-20285)
https://github.com/inbo/tutorials/issues/208 (https://inbojira.inbo.be/jira/browse/INBOPRJ-20286)
https://github.com/inbo/tutorials/issues/211 (https://inbojira.inbo.be/jira/browse/INBOPRJ-20578)

For those who can't reach JIRA easily, the output @damianooldoni refers to, is OUTPUT 2023: Tutorial bevraging soortenmeetnetten databank.
To be honest, I don't see any relation between this subject of this issue (tutorial on how to host a html report) and the referred output (if I remember well and plans haven't changed, the idea was to add some functions to inbodb to query the soortenmeetnetten database?)

I am very sorry. I was completely wrong! I think I have to stop using the keyboard of my laptop as it starts making strange shifts.


Fix plasmapy imports

Fixes the plasmapy.atomic imports by making them plasmapy.particles
Makes the peek_time_distance function a bit more flexible.

Pull Request Test Coverage Report for Build 183

5 of 12 (41.67%)  changed or added relevant lines in 3 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.4%) to 54.386%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pydrad/parse/parse.py
2
3
66.67%

pydrad/visualize/plot.py
0
6
0.0%

Files with Coverage Reduction
New Missed Lines
%

pydrad/visualize/plot.py
1
15.49%

Totals

Change from base Build 176:
-0.4%

Covered Lines:
310

Relevant Lines:
570

💛  - Coveralls


Certificates are submitted to AggLayer

As a CDK, I want to be able to submit a Certificate to the AggLayer through sendCertificate JSON-RPC so that it gets settled.
Pending questions and comments

[x] Certificate format need to be settled

Acceptance Criteria

[x] Send a Certificate to sendCertificate is possible

Definition of Done

[ ] All acceptance criteria are met.
[ ] Code is reviewed and approved.
[ ] Necessary tests are written and pass.
[ ] Documentation is updated, if applicable.
[ ] Feature is part of a release (created or planned).

Closing after successful test attempt by @hadjiszs


Not issue but how to question : need to add domain without restart container.

Hi!
Actually to add a new domain to my web app container I need to restart it to run the creation of the new cert let'sencrypt.
How can I add a new domain to proxy/ssl without restart my container?
My first idea is to add a new server{} settings in data/conf.d/default.conf. But if I restart or start another container that uses the proxy. My default.conf will be reload and my settings removed...
Thank you guys!

Hello @ben7244,
If you use docker-compose, you add your domain to the VIRTUAL_HOST and restart it... no downtime:
docker-compose restart
=)
Give it a try!

😓 I have already try that....
I will check and give news here.

Have you tried:
docker-compose create --force-recreate CONTAINER_NAME
?

Thank you @evertramos!
After docker-compose restart
Let'sEncrypt logs :
2018/09/16 14:53:52 Received event die for container 5c223379a47d 2018/09/16 14:53:52 Received event die for container d00e22843981 2018/09/16 14:53:53 Received event die for container c2055d3c11c5 2018/09/16 14:53:53 Received event stop for container 5c223379a47d 2018/09/16 14:53:53 Received event stop for container d00e22843981 2018/09/16 14:53:53 Received event stop for container c2055d3c11c5 2018/09/16 14:53:54 Received event start for container c2055d3c11c5 2018/09/16 14:53:54 Received event start for container 5c223379a47d 2018/09/16 14:53:55 Received event die for container 309fd3633ca8 2018/09/16 14:53:55 Received event stop for container 309fd3633ca8 2018/09/16 14:53:55 Received event start for container d00e22843981 2018/09/16 14:53:56 Received event start for container 309fd3633ca8 2018/09/16 14:54:11 Debounce minTimer fired 2018/09/16 14:54:12 Contents of /app/letsencrypt_service_data did not change. Skipping notification '/app/signal_le_service'
After docker-compose up -d --force-recreate
It's OK!
Certificats are renewed!
😎

Just on comment in order to do not recreate all services... depending on the size of your application you add the CONTAINER_NAME of you webserver (nginx/apache/traefik/etc) to only recreate one service.
Glad it worked!

Thank you for your comment.
But for more precisions, it not the container_name that is needed but the SERVICE_NAME.
php-apache for me :
version: '3.3' services:                                                                   php-apache:         image: xxxxxxxx/apache:${VERSION_APACHE}                                   ports:                                                                      - ${PORT_APACHE}:80         environment:             - TZ=Europe/Paris                                                       - VIRTUAL_HOST=${URL}             - LETSENCRYPT_HOST=${URL}                                               -<EMAIL_ADDRESS>           - HTTPS=${HTTPS}                                                    container_name: ${SELLER}_${CLIENT_NAME}_apache
Thank you @evertramos! Your help is precious!

sorry you are right! I miss that... I use the same name.. this is why it worked on my side, but you are right, service name!! thanks!

@ben7244
Just for the record this is the option for restarting a specific container without downtime.
docker-compose up -d --no-deps --build $CONTAINER

Nice! Effectively with docker-compose up -d --force-recreate I show than a little time down was. But that was acceptable compare to docker compose down & & docker compose up - d
I will try that!
Thanks for your back!


Failed to import -<EMAIL_ADDRESS>

Failing module

GitHub: https://github.com/alangpierce/sucrase
npm: https://www.npmjs.com/package/sucrase

import { transform } from<EMAIL_ADDRESS>
// This throws (esm.sh v59-v66)
transform("test();", { transforms: [] });

This used to work. I tried pinning a bunch of older versions and finally got it working with v58:
import { transform } from "https://esm.sh/sucrase@3.20.3?pin=v58";

// This works (esm.sh v58)
transform("test();", { transforms: [] });

Error message
After running deno run I got this:
error: Uncaught TypeError: Ki.default is not a constructor
    at Ui (https://cdn.esm.sh/v66/sucrase@3.20.3/deno/sucrase.js:133:4807)
    at vk (https://cdn.esm.sh/v66/sucrase@3.20.3/deno/sucrase.js:133:4138)
    at .../test.ts:3:1

Additional info

esm.sh version: v66
Deno version: 1.18.2 (release, x86_64-pc-windows-msvc)

I think it's the same issue as https://github.com/vitejs/vite/issues/7112, probably caused by esbuild

@elisee @nihgwu could you retry with the newer versions of both sucrase & esm.sh?


Steel Assault doesn't get past initial screens

Controller 0: X360 Controller, GUID: 5e048e02, Mapping: 030000005e0400008e02000014010000,X360 Controller,a:b0,b:b1,back:b6,dpdown:h0.4,dpleft:h0.8,dpright:h0.2,dpup:h0.1,guide:b8,leftshoulder:b4,leftstick:b9,lefttrigger:a2,leftx:a0,lefty:a1,rightshoulder:b5,rightstick:b10,righttrigger:a5,rightx:a3,righty:a4,start:b7,x:b2,y:b3,
FNA3D Driver: OpenGL
OpenGL Renderer: Mesa Intel(R) Xe Graphics (TGL GT2)
OpenGL Driver: OpenGL ES 3.2 Mesa 21.1.8
OpenGL Vendor: Intel
MojoShader Profile: glsles
Refresh rate: 60
Saving settings...
cant resolve internal call to "SteelAssaultCs.ConsolePorts::PRIVATE_CommitSaveIO" (tested without signature also)

Your mono runtime and class libraries are out of sync.
The out of sync library is: /home/thfr/games/fnaify/steel_assault/Steel_Assault/SteelAssaultCs.exe

When you update one from git you need to update, compile and install
the other too.
Do not report this as a bug unless you're sure you have updated correctly:
you probably have a broken mono install.
If you see other errors or faults after this message they are probably related
and you need to fix your mono install first.
[...]

this is fixed with an update to libtheorafile to 2021-04-03 checkout: https://github.com/FNA-XNA/Theorafile/commit/3f8bd6c77fccb45320de9af1f6b2ab55d2fca102. ... now need to check that this doesn't break other games.


Be able to disable vulnerable TLS versions in Ingress Gateway

Describe the feature request
Istio admins should be able to set a minimum TLS version of TLSv1_2 for the Istio ingressgateway proxy.
Here is the respective envoy configuration:
https://www.envoyproxy.io/docs/envoy/latest/api-v2/api/v2/auth/cert.proto.html?highlight=common_tls_context#envoy-api-msg-auth-tlsparameters
Please add a respective field in Gateway or any other appropriate entity.
Describe alternatives you've considered
None
Additional context
None

Would those changes include allowing to specify the cipher suites?

The request is to add the minimum TLS protocol field, which will cover most cases.
If we broaden the request we should add the following three fields:
"tls_minimum_protocol_version": "...",
"tls_maximum_protocol_version": "...",
"cipher_suites": [],
Implementation should be straightforward,

update gateway proto in istio/api repo -> networking/v1alpha3/gateway.proto
update pilot to use new fields in istio/istio repo ->  pilot/pkg/networking/core/v1alpha3/gateway.go

A related issue (cipher suite restriction):
https://github.com/istio/istio/issues/8769

To broaden the conversation quite a bit: If this TLS version feature is added, is it reasonable to expect other HTTP server options to be approved/added as well? One of my reservations about moving to Istio from something like the NGINX Ingress Controller is the lack of "traditional web server" options. I'm not suggesting full feature parity with something like Nginx, but a lot of these customizations could be must haves if Istio is on the edge of your network. I'm interesting in hearing from a maintainer about the larger scope and roadmap of the Istio Gateway. Thank you for all of your work.


Add missing struct keywords for ImVec2 and ImGuiListClipper arguments

Due to those missing struct, I could not compile on VS 2015.

thank you very much. i wish i had a windows machine to test these


Add third category and WCF Client area

Adds behavioral change category (see https://github.com/dotnet/docs/issues/25257#issuecomment-887095743)
Adds WCF Client as a feature area choice

Looks good to me. cc @marklio since behavioral change is added as a classification type and definitions have been slightly tweaked. cc @HongGit for area WCF Client addition.

cc @mconnew


System.OutOfMemoryException when Unpack

I am trying to uncompress the bundle files because I can't read the compressed files.
This code:
    AssetsManager helper = new AssetsManager();
    helper.LoadClassPackage("classdata.tpk");
    var inst = helper.LoadBundleFile(inputFilename, false);
    var file = inst.file;
    if (file.bundleHeader6.GetCompressionType() == 0) return;
    using (FileStream stream = File.Open(outputFilename, FileMode.Create, FileAccess.ReadWrite))
    {
        file.reader.Position = 0;
        file.Unpack(file.reader, new AssetsFileWriter(stream));
        stream.Position = 0;
    }

With reference from NuGet crash with message for a bundle file of 900MB but not with a bundle of 6MB
System.OutOfMemoryException in AssetsTools.NET.AssetBundleFile.Unpack(AssetsFileReader reader, AssetsFileWriter writer)
same error from version 2.0.7 to 2.0.9
but work correctly if i donwload the source code and add to my tool the AssetsTools.NET.csproj project

compile as 64 bit


Refactor Pod::queue

In Pod::queue, there's a huge method for running the Pod: run_pod. We should look into refactoring this code to make it a little simpler to read.

This ideally will be taken care of when I pull in the kube_runtime crate

This was taken care of in #396


Library Update

Having to restart the server to update the library is really annoying and it would interrupt any streams currently playing. Here are some possibilities:

Watch the videos directory for file changes and update (best)
Provide a way to force an update on demand
Update at a configurable interval

Resolved by b46830c8806fc1293bc8cfdf5496cd024fcde6c4
Ended up settling for the first option of watching the library directory using fsnotify.


Add the new Multi-Modal model of mistral AI: pixtral-12b

Add the new Multi-Modal model of mistral AI: pixtral-12b:
https://huggingface.co/mistral-community/pixtral-12b-240910

Since yesterday vllm has internVL2 support. :-)
vllm-project/vllm/releases/tag/v0.6.1

I guess that would work already with llama.cpp GGUF models if/when is getting supported in there. I'd change the focus of this one to be more generic and add support for multimodal with vLLM

vllm already has llama support https://github.com/vllm-project/vllm/pull/8811

See also: https://github.com/ggerganov/llama.cpp/issues/9455

BTW: "(Coming very soon) 11B and 90B Vision models
11B and 90B models support image reasoning use cases, such as document-level understanding including charts and graphs and captioning of images."
(https://ollama.com/blog/llama3.2)

BTW: "(Coming very soon) 11B and 90B Vision models
11B and 90B models support image reasoning use cases, such as document-level understanding including charts and graphs and captioning of images."
(https://ollama.com/blog/llama3.2)

that would be interesting to see given upstream(llama.cpp) is still working on it: https://github.com/ggerganov/llama.cpp/issues/9643

It seems they work independently on that ollama/ollama#6963

that looks only golang-side of things to fit the images. The real backend changes seems to be in https://github.com/ollama/ollama/pull/6965/files


GPU pod cuda-vector-add 0 nodes available!

Ubuntu 22.04
$ k version
WARNING: This version information is deprecated and will be replaced with the output from kubectl version --short.  Use --output=yaml|json to get the full version.
Client Version: version.Info{Major:"1", Minor:"24+", GitVersion:"v1.24.0-2+59bbb3530b6769", GitCommit:"59bbb3530b6769e4935a05ac0e13c9910c79253e", GitTreeState:"clean", BuildDate:"2022-05-13T06:43:45Z", GoVersion:"go1.18.1", Compiler:"gc", Platform:"linux/amd64"}
Kustomize Version: v4.5.4
Server Version: version.Info{Major:"1", Minor:"24+", GitVersion:"v1.24.0-2+59bbb3530b6769", GitCommit:"59bbb3530b6769e4935a05ac0e13c9910c79253e", GitTreeState:"clean", BuildDate:"2022-05-13T06:41:13Z", GoVersion:"go1.18.1", Compiler:"gc", Platform:"linux/amd64"}
$ k describe pod cuda-vector-add
Name:         cuda-vector-add
Namespace:    default
Priority:     0
Node:         <none>
Labels:       <none>
Annotations:  <none>
Status:       Pending
IP:
IPs:          <none>
Containers:
  cuda-vector-add:
    Image:      k8s.gcr.io/cuda-vector-add:v0.1
    Port:       <none>
    Host Port:  <none>
    Limits:
      nvidia.com/gpu:  1
    Requests:
      nvidia.com/gpu:  1
    Environment:       <none>
    Mounts:
      /var/run/secrets/kubernetes.io/serviceaccount from kube-api-access-rs59w (ro)
Conditions:
  Type           Status
  PodScheduled   False
Volumes:
  kube-api-access-rs59w:
    Type:                    Projected (a volume that contains injected data from multiple sources)
    TokenExpirationSeconds:  3607
    ConfigMapName:           kube-root-ca.crt
    ConfigMapOptional:       <nil>
    DownwardAPI:             true
QoS Class:                   BestEffort
Node-Selectors:              <none>
Tolerations:                 node.kubernetes.io/not-ready:NoExecute op=Exists for 300s
                             node.kubernetes.io/unreachable:NoExecute op=Exists for 300s
Events:
  Type     Reason            Age   From               Message
  ----     ------            ----  ----               -------
  Warning  FailedScheduling  78s   default-scheduler  0/1 nodes are available: 1 Insufficient nvidia.com/gpu. preemption: 0/1 nodes are available: 1 No preemption victims found for incoming pod.
$ m status
microk8s is running
high-availability: no
  datastore master nodes: <IP_ADDRESS>:19001
  datastore standby nodes: none
addons:
  enabled:
    dashboard            # (core) The Kubernetes dashboard
    dns                  # (core) CoreDNS
    gpu                  # (core) Automatic enablement of Nvidia CUDA
    ha-cluster           # (core) Configure high availability on the current node
    helm3                # (core) Helm 3 - Kubernetes package manager
    hostpath-storage     # (core) Storage class; allocates storage from host directory
    ingress              # (core) Ingress controller for external access
    metrics-server       # (core) K8s Metrics Server for API access to service metrics
    rbac                 # (core) Role-Based Access Control for authorisation
    storage              # (core) Alias to hostpath-storage add-on, deprecated
  disabled:
    community            # (core) The community addons repository
    helm                 # (core) Helm 2 - the package manager for Kubernetes
    host-access          # (core) Allow Pods connecting to Host services smoothly
    mayastor             # (core) OpenEBS MayaStor
    metallb              # (core) Loadbalancer for your Kubernetes cluster
    prometheus           # (core) Prometheus operator for monitoring and logging
    registry             # (core) Private image registry exposed on localhost:32000

$ nvidia-smi
Thu Jun  9 16:11:52 2022
+-----------------------------------------------------------------------------+
| NVIDIA-SMI 510.73.05    Driver Version: 510.73.05    CUDA Version: 11.6     |
|-------------------------------+----------------------+----------------------+
| GPU  Name        Persistence-M| Bus-Id        Disp.A | Volatile Uncorr. ECC |
| Fan  Temp  Perf  Pwr:Usage/Cap|         Memory-Usage | GPU-Util  Compute M. |
|                               |                      |               MIG M. |
|===============================+======================+======================|
|   0  NVIDIA RTX A200...  Off  | 00000000:01:00.0 Off |                  N/A |
| N/A   45C    P8    17W /  N/A |      5MiB /  4096MiB |      0%      Default |
|                               |                      |                  N/A |
+-------------------------------+----------------------+----------------------+

+-----------------------------------------------------------------------------+
| Processes:                                                                  |
|  GPU   GI   CI        PID   Type   Process name                  GPU Memory |
|        ID   ID                                                   Usage      |
|=============================================================================|
|    0   N/A  N/A      2302      G   /usr/lib/xorg/Xorg                  4MiB |
+-----------------------------------------------------------------------------+

Summary

What Should Happen Instead?

Reproduction Steps

...
...

Introspection Report

Can you suggest a fix?

Are you interested in contributing with a fix?

Hi @khteh could you share a microk8s inspect tarball so as for us to see the status of the cluster and the nvidia operator?

Looking at the logs of the crashlooping containers I see this error: "container error: cgroup subsystem devices not found: unknown".
We recently updated gpu addon but this update has not made it to the stable channel yet. Would it be possible to do a fresh installation with microk8s from --channel=1.24/edge ?

When will it be in stable?

It should be out in the next couple of weeks.

I will wait.


Error in readme

There is an typo in the readme file.
It says
nltk.download("averaged_perceptron_taggepython r")
instead of
nltk.download("averaged_perceptron_tagger")
It's generally not that easy to set this program up.
The instructions in procedure.txt are not very clear
and you have to find this file to begin with.
But besides that this projects is very interesting,
thanks for sharing!
Edit:
I also had to download these:
nltk.download('maxent_ne_chunker')
nltk.download('words')

@RisingOrange It would be great if you could add a PR for the necessary changes and merge it into the master, it would be useful for others.


[Test] Rename to Testing

Use of test as top level block is confusing

[ ] rename base Test to Testing.
[ ] deprecate test in config. Usage of this method should output a warning.
[ ] add testing accessor to config.
[ ] rename plugin Test to Testing.
[ ] add new plugin id org.kordamp.gradle.testing.
[ ] keep org.kordamp.gradle.test for compatibility.
[ ] update guide with new names.

The part "collides with inner node and hyeronimous' plugin" doesn't seem to apply in this case, is that right?

Indeed. The joys of copy&pasting when you’re falling asleep

As it happens base does not apply license but validates it eagerly, and that’s the problem, it should validate license just like publishing (conditionally).
Thank you very much for your feedback!

Thank you, and you're welcome!
PS. You might want to move the last two comment to #82 :wink:


[misc] fix builds

Coverage decreased (-0.09%) to 88.435% when pulling 7ddb3a3cb81757a1d3c2a242d5d8b8dbbd504b68 on dependabot into 52019f1dda47c3e598aaeaa4ac89d5a574641604 on develop.


Feature Request: Show all pages with current tag

At the moment, the tags serve only to filter pages, this is useful when we have one page with many child pages with different tags. But when our pages are structured by catalogs, the tags become almost useless.
Here it would be useful to display all pages (from the entire site or section) with the current tag.
For example, the user has found an interesting article and wants to read more materials on this topic.
The user clicks on the tag and gets a list of all materials on the site that have the same tag.
Almost all CMS that have tags have similar functions. And yes I know that with the help of crutches, this can be done in the template, but isn't it better to add this functionality to the grav itself?

Grav is designed to support many different use cases. The core is, by design, minimalist. All the default blog-style skeletons I've come across include the functionality you describe. And adding it to a fresh theme is straightforward. How would you prefer that this work?

On my site, all materials are categorized:
articles:
  catecory-1:
    child-catecory-1:
      material-1,
      material-2,
      material-3
    child-catecory-2:
      material-1,
      material-2
  catecory-2:
    material-1,
    material-2,
    material-3

And I have, really a lot of materials, arranged in their categories. How can I display all materials with the selected tag on one page?
The only option that came to my mind is to create a page that will show all the materials that are on the site, and already filter it by tag. But in my opinion, this method has two drawbacks:

I do not understand how to organize a crawl of all child categories, if I do not know in advance the depth of nesting.
I'm not sure about the performance of this method...

I found how to make it the most practical.


PHP formatting is not working

What did you expect to happen?
When I press SPC c f the prettier indentation works with php-cs-fixer as the documentation describes here.
What actually happened?
When I press SPC c f the console says LSP :: no formatting changes provided and the prettier formatting is not working.
Additional details:
If I turn off +format-with-lsp like the following then the correct formatter is being used:
(setq-hook! 'php-mode-hook
  +format-with-lsp nil)

Steps to reproduce:

Configure the php Doom module as the documentation describes
Install the required dependencies
Open a PHP file
Try to indent it with SPC c f

System information:
SYSTEM  type       darwin
        config     x86_64-apple-darwin19.5.0
        shell      /bin/zsh
        uname      Darwin 19.6.0 Darwin Kernel Version 19.6.0: Tue Jan 12 22:13:05 PST 2021; root:xnu-6153.141.16~1/RELEASE_X86_64 x86_64
        path       (~/.phpbrew/php/php-7.4.12/bin ~/.rbenv/shims ~/bin ~/.composer/vendor/bin /usr/local/bin /usr/bin /bin /usr/sbin /sbin /Applications/Wireshark.app/Contents/MacOS ~/.rbenv/shims ~/bin ~/.composer/vendor/bin /Applications/Emacs.app/Contents/MacOS/libexec /Applications/Emacs.app/Contents/MacOS/bin)
EMACS   dir        ~/.emacs.d.doom/
        version    27.1
        build      Nov 14, 2020
        buildopts  --with-mac --enable-mac-app=/Users/travis/build/railwaycat/homebrew-emacsmacport/build-scripts/emacs-source/tmproot --prefix=/Users/travis/build/railwaycat/homebrew-emacsmacport/build-scripts/emacs-source/tmproot --enable-mac-self-contained --with-modules
        features   NOTIFY KQUEUE ACL GNUTLS LIBXML2 ZLIB TOOLKIT_SCROLL_BARS MODULES THREADS JSON PDUMPER LCMS2 GMP
        traits     (batch server-running envvar-file)
DOOM    dir        ~/.doom.d/
        version    2.0.9
        build      HEAD -> develop 3a7be7bb4 2021-02-01 02:45:45 -0500
        elc-files  0
        modules    (:completion company (ivy +icons) :ui doom doom-dashboard hl-todo modeline ophints (popup +defaults) vc-gutter vi-tilde-fringe workspaces :editor (evil +everywhere) file-templates fold (format +onsave) snippets :emacs (dired +icons) electric undo vc :term vterm :checkers syntax spell :tools docker (eval +overlay) lookup lsp (magit +forge) :os macos :lang emacs-lisp (json +lsp) javascript markdown (org +pretty +roam) (php +lsp) (python +lsp) (ruby +rails) sh web yaml :config (default +bindings +smartparens))
        packages   ((graphviz-dot-mode) (ox-jira :disable t) (forge :recipe (:host github :repo raszi/forge :branch browse-file)))
        unpin      (forge)
        elpa       (ox-jira)

There is also an issue with php-cs-fixer-fix:
Wrote /var/folders/yv/11zfcxjd7x785b4w1srn6yg80000gn/T/PHP-CS-FixerbyyG6l.php
kill-append: Args out of range: 0, 0

The third thing I noticed is that instead of calling php-cs-fixer and let php-cs-fixer call prettier it is only calling prettier on save.
The prettier/plugin-php documentation supports the other way around, see here.


async-43: New LoaderPoolGroup

Description

New LoaderPoolGroup so ChunkLoader can have N LoaderPools at once:

One or more low-delayed ones for higher levels.
A higher delay one for the ideal level.

This seems better but it would take more analysis to really understand what's going on at run-time, and what settings are best, etc. But at least this gives us the ability to experiment. And it can be set back to a single pool if desired.
Rational
While we can cancel not-yet-started chunks if they fall out of view, we cannot cancel in-progress ones. So if we move the camera rapidly, a single LoaderPool becomes full with in-progress requests which are now all out of view.
Using a DelayQueue seems like a good solution. We can trivially cancel delayed requests if they fall out of view. Then when the user stops moving, the pool is empty and we can fill it up with requests.
However we want to avoid showing nothing whenever possible. So if all requests are delayed, nothing will load. So we have a pool that only loads higher levels. A single tile from a higher levels +1, +2, +3 will cover 4, 9, 16 ideal tiles. So we load those without a deal.
The end result is we load the higher levels as we move around, but then once we pause for 100ms or so, we start loading the ideal tiles rapidly.
Notes

Must use PySide2. Crashes with PyQt5.
Same as before, but just noting it.

Type of change

[x] New feature in experimental code

How has this been tested?

[x] Manual testing
[x] New test_loader.py

Marked this ready for review. As said in PR comment this gives us the ability to configure multiple pools, but just playing around with it, it's hard to say what the best settings are. It would take some pretty serious viz or other analysis to really figure things out. But at least this gets the machinery in place.


Running Bash under root has strange side-effects with filesystem

In installed bash for the first time. Once asked about the account I choose to use "root" The installer said "found account" and was done. So now I am running bash directly as root and don't seem to have to login (at home I followed a different path with a new user and password).
Anyway, I then wanted to show a co-worker how easy it was mixing files between windows and WSL so i went to look for the home folder (/root) I nano-ed my way into creating a test.txt file in bash and then looked at %LocalAppData%/lxss/root and low-and-behold the file was there. I then created a readme.txt file from windows in that folder and switched back to bash. ls-l and tada...... Hmmm no file?
I opened nano and tried to create a readme.txt file but could not save it. back in the command-prompt ls -l still did not show the file.
When I installed this at home and choose a different used I was able to do this in that use home folder under /home/username Als on my work PC I placed a file in the home folder which also did not show up in bash.

Actual results (with terminal output if applicable)
It looks like the root user session has som disconnect in de file system for which files are shown.

Your Windows build number
1607  build: 14393.693

Steps / All commands required to reproduce the error from a brand new installation
Install bash, choose root user once asked for an account
Navigate to %LocalAppData%/lxss/root in windows and put a file in that folder "readme.txt"
navigate to /root in bash en ls -l  (no file is shown)

P.S. I am logging into my windows 10 Pro PC with my Azure AD organizational account. I also uninstalled WSL and then reinstalled. Choose a non-root account went to /home/username put a file in there from windows but still don't see that file from bash ?

This is discussed elsewhere, but you're not supposed to modify files in %localappdata%\lxss.
https://blogs.msdn.microsoft.com/commandline/2016/11/17/do-not-change-linux-files-using-windows-apps-and-tools/


Building a jar with dependencies for PubSub

Coverage remained the same at 99.628% when pulling 7ff579d5bba37bdf7cf0e28e9d1f942d1c26266f on fat-jar into 5db4c9d1413c4c5e566b0e4822c939dc19bb52fa on master.


1797650: Remove '?view=azure-cli-latest' link syntax

No code or content changes. Part of an effort to remove unnecessary versioning link syntax.
See user story 1797650 for more information.

@dbradish-microsoft
Closing PR per instructions. No reviewer or repo owner available to merge for 30 days.

@dbradish-microsoft
Closing PR per instructions. No reviewer or repo owner available to merge for 30 days.


Visual Script Variable issue

Godot version:
Godot 3.2 Alpha official release
OS/device including version:
Windows 10
Issue description:
Some nodes when created pick "Any" as their type, instead of the types they should be (vector3 for translations, rotations etc) which limit the options when dragging the output to make new nodes in case of getter nodes, and in case of setter nodes force the use of variables even if you want to set a fixed value for that node
Steps to reproduce:

Create a Visual Script
Create a Getter or a Setter node (Some recognize type just fine, some don't, like most under spatial don't)
The result:

(The Deconstruction node was made via standard node creation, not via output creator for the get rotation node)

Minimal reproduction project:
Project.zip

This happens whenever the method originates from a parent class.
If you add "Get rotation_degrees" on a Spatial, the type is set as Vector3. If you add "Get rotation_degrees" on a MeshInstance, the type is set as Any.
I just opened #32673 which will make VisualScript check inheritance when getting type info.


Added the sync() function from unistd.h

This fixes #601.

Seems it fails in Android (the nightly failure seems unrelated to my changes). Should I add #[cfg(not(target_os = "android"))] to the function?

Ah that just means you'll want to push it further down the module hierarchy. That may required duplication but it's ok to do so.

@bors: r+
Thanks!

:pushpin: Commit 406b01a has been approved by alexcrichton

:hourglass: Testing commit 406b01a with merge 30b0ecc...

:sunny: Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 30b0ecc2e417b5da77a0dd2e69d552add1049701 to master...


Functions v2 ListLocations is failing in REGAPIC

The smoke test is failing with an exception:
Failed: System.InvalidOperationException: Type registry has no descriptor for type name 'google.cloud.functions.v2.LocationMetadata'
at Google.Protobuf.JsonParser.MergeAny(IMessage message, JsonTokenizer tokenizer)
at Google.Protobuf.JsonParser.<>c.<.cctor>b__41_6(JsonParser parser, IMessage message, JsonTokenizer tokenizer)
Investigating...

This will be resolved by the Functions team republishing their API. There's a deeper underlying issue with Any+REGAPIC, but that's much bigger than this...

Reported internally as b/283396160


One image missing and one additional at the end?

Discussed in https://github.com/nftchef/art-engine/discussions/85

Originally posted by ultraviolet007rainbow March  1, 2022
Hi,
I just generated 10K again starting with 1, and ended up with 10,001 as the final image.
I went through and found out that there was a missing image at 7630.
So I edited the JSON of 10,001 to become 7630 instead as it should have been and made sure all the filenames were changed as well (JSON and Image). Will this affect the _dna.json in any way? I did identify the correct DNA line in the _dna.json that corresponds to image 10,0001 which is now image 7630. But I do not see anything in the _dna.json that would directly link it other than the traits to a specific filename (JSON or image). So is there a way to regenerate the _dna.json from the JSON files now that I have fixed the problem manually?
In addition, I found an oddity looking at the _dna.json where one of my background images I used has a numerical filename, none of the other layer files have numerical names other than this one. So in the _dna.json each one of those that has that specific background layer has 0.0 at the head of the line, which clearly is wrong. So for some reason the 0.0 was set because of the numerical layer name, is my assumption.
Is there a good way to fix this problem?
My only idea is to rename the layer to something else in every JSON file as well as the actual layer name of that specific background PNG.
And also replace all instances in the _dna.json file of that numerical layer name.
Once again will this break anything, can I regenerate the _dna.json from the altered JSON files?
Thank you for your great improvements and enhancements to the original code.
Regards.

i have same problem.

fixed in #163


Licensing for schwatcher ?

Would it be ok if we add a license to schwatcher at the top level of the codebase ?

Good idea. Added.


NullPointerException when login via SSO without setting product flow priority

Library version: 0.10.0
Repro steps, stacktrace, screenshots:

Assign any application's certificate footprint in uber developer's settings to enable SSO.
Integrate the sdk in your project
call LoginManager.login()

Expected Behavior: launching of Uber app with login activity
Real result: NPE crash
java.lang.NullPointerException: collection == null
        at java.util.ArrayList.<init>(ArrayList.java:94)
        at com.uber.sdk.android.core.auth.LoginManager.login(LoginManager.java:180)

The cause is the default value of productFlowPriority collection which is null and therefore while constructing ArrayList it crashes the app.
I would like to know if it's ok to pass to setProductFlowPriority() Collections.emptyList() to bypass the crash ?

Yes, passing Collections.emptyList() should be fine.  This will default you to using only the Uber app.


remove or document use of ReferenceSet/Reference

ReferenceSet/Reference has an attribute isDerived which is an attempt to solve an unspecified problem.  Its description is:
"A sequence X is said to be derived from source sequence Y, if X and Y are of the same length and the per-base sequence divergence at A/C/G/T bases  is sufficiently small. Two sequences derived from the same official   sequence share the same coordinates and annotations, and can be replaced with the official sequence for certain use cases."
This seems like a highly unusually problem.  It's use case needs to be clearly define or this removed as it's is unclear why anyone would need this.

this would also remove Reference.sourceDivergence

See #130.

thank @lh3; very important use case, however an accession of the
source sequence seems far more useful than a boolean.
Reopened #130 until the documentation is in source rather than a ticket.
Heng Li<EMAIL_ADDRESS>writes:

See #130.
—
Reply to this email directly or view it on GitHub.*

We already have Reference::sourceAccessions[], or are you suggesting sourceAccession=[] implies isDerived=false? I am fine either way.

Suggesting that isDerived be replaced with derivedFrom which is the accession
that it is based.
I think being very explicit is important.
Heng Li<EMAIL_ADDRESS>writes:

We already have Reference::sourceAccessions[], or are you suggesting
sourceAccession=[] implies isDerived=false? I am fine either way.
—
Reply to this email directly or view it on GitHub.*

I think Heng introduced isDerived etc.  I think the reason is that some mapping references differ from the references actually
in the INSDC database, e.g. reference accessions contain IUPAC codes like R, Y etc. for unusual uncertain base combinations
({AG} and {CT} respectively in these cases), which are converted to N for mapping.  Also sometimes some bases are masked
out.  I don’t know how important/useful it is to track all these things.  In a way the critical property is whether the coordinate
system is the same, but that may not be easy to define absolutely.  e.g. a “derivedFrom” with an indel early in the chromosome
sequence would be very different from one changing a Y to N.
Richard

On 15 Jan 2016, at 05:45, Mark Diekhans<EMAIL_ADDRESS>wrote:
Suggesting that isDerived be replaced with derivedFrom which is the accession
that it is based.
I think being very explicit is important.
Heng Li<EMAIL_ADDRESS>writes:

We already have Reference::sourceAccessions[], or are you suggesting
sourceAccession=[] implies isDerived=false? I am fine either way.
—
Reply to this email directly or view it on GitHub.*

—
Reply to this email directly or view it on GitHub https://github.com/ga4gh/schemas/issues/536#issuecomment-171877065.

--
The Wellcome Trust Sanger Institute is operated by Genome Research
Limited, a charity registered in England with number 1021457 and a
company registered in England with number 2742969, whose registered
office is 215 Euston Road, London, NW1 2BE.


Remove Android MediaPlayer support #2656

Update the documentation
Remove MediaPlayer References (execpt in old release description)
Update the changelog Done
Provide an example of how to test the change
Tested in basic sample (path integration updated)
Focus the PR on only one area
Just ensure changing the exoplayer-android to exoplayer is enough
Describe the changes
remove deprecated Media Player implementation as requested here:
https://github.com/react-native-video/react-native-video/issues/2656

@freeboub can you rebase? I'll merge it when ready.

@freeboub can you rebase? I'll merge it when ready.

Yes, done!


nth-prime: use JUnit's @Rule feature

We've been migrating to using JUnit's ExpectedException @Rule feature instead of @Test(expected = SomeException.class). Change the occurrence of @Test(expected = SomeException.class) in PrimeTest to make it use the @Rule feature instead.

taking this one


FAUNADB_SERVER_SECRET injected without notice and with incorrect value

I use a FAUNADB_SERVER_SECRET environment variable specified in both my Netlify site's environment variables as well as in an .env file. I run a React application using npx --node-arg=--inspect netlify dev to start Netlify Dev. When it starts up, no mention is made of FAUNADB_SERVER_SECRET even though other assignments are. When I log out the value of FAUNADB_SERVER_SECRET from a lambda that uses it, a value is output that does not match either the assignment in my site configuration or within my .env file. I was able to workaround the issue by creating a new environment variable in site configuration with a different name (FAUNA_SECRET) and was able to see the value reported as injected and that value was available in the lambda.
I'm uncertain if I used the 'addon' functionality of Netlify to integrate Fauna with my site. Currently when I use netlify addons:list it shows none are active. It's possible I removed it afterward, but I would still expect the value to propagate to Netlify Dev.
To Reproduce
I have not taken steps to reproduce. It's possible it would present if a new Netlify project added an addon and then removed it.
Configuration
→ npx envinfo --system --binaries --npmPackages netlify-cli --npmGlobalPackages netlify-cli
npx: installed 1 in 0.802s

  System:
    OS: Linux 5.8 Manjaro Linux
    CPU: (4) x64 Intel(R) Core(TM) i5-6600K CPU @ 3.50GHz
    Memory: 3.58 GB / 15.56 GB
    Container: Yes
    Shell: 5.0.18 - /bin/bash
  Binaries:
    Node: 12.18.0 - ~/.nvm/versions/node/v12.18.0/bin/node
    Yarn: 1.22.10 - ~/.nvm/versions/node/v12.18.0/bin/yarn
    npm: 6.14.4 - ~/.nvm/versions/node/v12.18.0/bin/npm
  npmGlobalPackages:
    netlify-cli: 2.69.0

Expected behavior
The value for FAUNADB_SERVER_SECRET to match what is in my .env file.
The value for FAUNADB_SERVER_SECRET to match what is in my site configuration if the assignment is removed from the .env file
→ yarn start
yarn run v1.22.10
$ npx --node-arg=--inspect netlify dev
Debugger listening on ws://<IP_ADDRESS>:9229/7f7439a7-91c1-4fd8-8d17-473572649403
For help, see: https://nodejs.org/en/docs/inspector
◈ Netlify Dev ◈
◈ Injected .env file env var: REACT_APP_DATA_HOST
◈ Injected .env file env var: REACT_APP_LAMBDA_HOST
◈ Injected .env file env var: SESSION_SECRET
◈ Injected build setting env var: REACT_APP_DELIGHTED_ID
◈ Injected build setting env var: GENERATE_SOURCEMAP
◈ Injected build setting env var: REACT_APP_GOOGLE_ANALYTICS_ID
◈ Function builder netlify-lambda detected: Running npm script build:lambda
 ›   Warning: ◈ This is a beta feature, please give us feedback on how to improve at https://github.com/netlify/cli/
◈ Function builder netlify-lambda building functions from directory ./webpack.lambda.config.js
^C

→ netlify --version
netlify-cli/2.69.0 linux-x64 node-v12.18.0

→ netlify addons:list
No addons currently installed for dcs-x52-profile-maker
> Run `netlify addons:create addon-namespace` to install an addon

Hi @bdefore, thank you for reporting this issue.
Is it possible the FAUNADB_SERVER_SECRET env variable is set at the shell level? The CLI will node override any process level envs (this matches dotenv behavior).
You can verify it by running env | grep FAUNADB.

Thanks, indeed that was the issue. I'd mistakenly exported this variable in one of my dotfiles.
Perhaps Netlify Dev could alert the user if it detects a value is already assigned?

That's a good suggestion, open https://github.com/netlify/cli/issues/1598 for that


[feature-request] Vim plugin should provide option to search through currently open buffers

I really enjoy using FZF. It is blazingly fast, even faster than CtrlP paired with Ag. It would be nice if we could duplicate CtrlP's ability to list out the open buffers and search through them fuzzily. I am talking about CtrlP's :CtrlPBuffer command. It is very useful for working with large projects and having lots of files open at once.

I think there is already such a functionality. look at Buffers command here, it is provided by fzf.vim.

@khalidchawtany Thanks.
Yes, check out https://github.com/junegunn/fzf.vim

Wow, this provides significantly more functionality than the main project
docs are letting on. Thank you.
On Wed, Oct 7, 2015 at 3:41 AM Junegunn Choi<EMAIL_ADDRESS>wrote:

Closed #368 https://github.com/junegunn/fzf/issues/368.
—
Reply to this email directly or view it on GitHub
https://github.com/junegunn/fzf/issues/368#event-428651000.