A single JSON file containing all meta.json data would be useful

It should be easy to add. jq could be used:
find . -name meta.json | xargs jq -s '.' > all.json

Or it could be done by exhaust.py.

I think build/_exhaust-runs/dataframe.json might have what I need in a different format: https://github.com/SymbiFlow/fpga-tool-perf/blob/master/infrastructure/runner.py#L118-L141

I think build/_exhaust-runs/dataframe.json might have what I need in a different format: https://github.com/SymbiFlow/fpga-tool-perf/blob/master/infrastructure/runner.py#L118-L141


Use docker.for.mac.localhost

This is a quick workaround (as most devs at GDS use macOS) while I work out a better fix.

👀


[ssr] Error with KeepAlive: Cannot destructure property p of 'undefined' or 'null'

Version
3.0.5
Reproduction link
https://github.com/rstoenescu/vue3-ssr-bug-keepalive
Steps to reproduce

yarn
yarn dev
Error being reported (from src/pages/Home.js):

TypeError: Cannot destructure property `p` of 'undefined' or 'null'.
    at setup (/Users/Razvan/work/test/vue3-ssr-bug-keepalive/node_modules/@vue/runtime-core/dist/runtime-core.cjs.js:2498:27)
    at callWithErrorHandling (/Users/Razvan/work/test/vue3-ssr-bug-keepalive/node_modules/@vue/runtime-core/dist/runtime-core.cjs.js:156:22)
    at setupStatefulComponent (/Users/Razvan/work/test/vue3-ssr-bug-keepalive/node_modules/@vue/runtime-core/dist/runtime-core.cjs.js:6377:29)
    at setupComponent (/Users/Razvan/work/test/vue3-ssr-bug-keepalive/node_modules/@vue/runtime-core/dist/runtime-core.cjs.js:6338:11)
    at renderComponentVNode (/Users/Razvan/work/test/vue3-ssr-bug-keepalive/node_modules/@vue/server-renderer/dist/server-renderer.cjs.js:160:17)
    at renderVNode (/Users/Razvan/work/test/vue3-ssr-bug-keepalive/node_modules/@vue/server-renderer/dist/server-renderer.cjs.js:248:22)
    at renderVNodeChildren (/Users/Razvan/work/test/vue3-ssr-bug-keepalive/node_modules/@vue/server-renderer/dist/server-renderer.cjs.js:263:9)
    at renderElementVNode (/Users/Razvan/work/test/vue3-ssr-bug-keepalive/node_modules/@vue/server-renderer/dist/server-renderer.cjs.js:299:17)
    at renderVNode (/Users/Razvan/work/test/vue3-ssr-bug-keepalive/node_modules/@vue/server-renderer/dist/server-renderer.cjs.js:245:17)
    at renderComponentSubTree (/Users/Razvan/work/test/vue3-ssr-bug-keepalive/node_modules/@vue/server-renderer/dist/server-renderer.cjs.js:217:13)

What is expected?
Not to error out
What is actually happening?
Error from vue core

Oh, umm I just filed this same bug under vue-router: https://github.com/vuejs/vue-router-next/issues/778
You sure this is a core bug and not a bug with the implementation of  router-view?

Seems like it - I'll close my dupe. Sorry for the noise!


Error when changing the TextureRID of a Texture2DRD

Tested versions
v4.2.stable.official [46dc27791]
System information
Godot v4.2.stable - Vulkan (Forward+)
Issue description
If you free an RID associated with a Texture2DRD and then add a new RID to the texture, it outputs an error, saying it attempted to free an invalid RID.
Steps to reproduce
This code outputs an error on the last line. In my actual project, I needed to do this because you can't change the resolution of a texture without creating a new one.
var rd := RenderingServer.get_rendering_device()
var texture_rd := Texture2DRD.new()
var rid : RID

var fmt := RDTextureFormat.new()
fmt.width = 8
fmt.height = 8
fmt.format = RenderingDevice.DATA_FORMAT_R32G32B32A32_SFLOAT
fmt.usage_bits = RenderingDevice.TEXTURE_USAGE_SAMPLING_BIT + RenderingDevice.TEXTURE_USAGE_CAN_UPDATE_BIT

var image := Image.create(8, 8, false, Image.FORMAT_RGBAF)
image.fill(Color.BLACK)

rid = rd.texture_create(fmt, RDTextureView.new(), [image.get_data()])
texture_rd.texture_rd_rid = rid

rd.free_rid(rid)
rid = rd.texture_create(fmt, RDTextureView.new(), [image.get_data()])
texture_rd.texture_rd_rid = rid

There is a workaround for this, which is deleting the Texture2DRD and creating a new one. But that doesn't seem like the intended way of changing the RID of a texture.
Minimal reproduction project (MRP)
N/A

In this case I'd say you shouldn't handle the RID tracking and freeing manually, that's the whole point of using this type, but maybe the documentation should be improved to clarify how it operates

The only example of how to use Texture2DRD that I could find was the new compute texture demo in godot-demo-projects. In that project, the RIDs are tracked and freed manually, so if that's not the intended use then the demo should also be updated to clarify.

That code is different from yours though, it clears the RIDs manually and updates between runs, unlike yours

Thanks, that seems to be the solution I was looking for. Having to create an empty RID seems a bit unintuitive, but it's definitely better than the workaround I was using before. This should probably be clarified in the Texture2DRD class reference.

Well you are removing the control from the resource, you leave it as thinking it's in control, if you untrack it you signal it's no longer in charge

Seems like the error is coming from this line: https://github.com/godotengine/godot/blob/15a03ed98e63590c85dac62405d785e1b7ca7fed/servers/rendering/renderer_rd/storage_rd/texture_storage.cpp#L1375
Which is called by RenderingServer.texture_replace(), which is called by Texture2DRD.set_texture_rd_rid().
When assinging RID() we don't call texture_replace() and so we only free the RenderingServer copy of the texture.
I don't think we should be using texture_replace() for RD textures so we should switch to something else (i.e. free the RenderingServer texture and replace it). This would work the same as the workaround above (i.e. texture_rd.texture_rd_rid = RID()).
Alternatively, we can mark textures as TextureRDs in the RenderingServer. And then not free the internal RD texture within texture_replace().
What do you think @BastiaanOlij?


Only remote/local DRAM access is displayed in pcm-numa. What should I do if I want to observe the access status of pmm?

Only remote/local DRAM access is displayed in pcm-numa. What should I do if I want to observe the access status of pmm?
Thanks, Looking forward to your reply.

you can use pmu-query.py to query MEM_LOAD_RETIRED.LOCAL_PMM and MEM_LOAD_L3_MISS_RETIRED.REMOTE_PMM event encodings and then use them in pcm-core utility. This should give at least the distribution of local/remote loads for PMM.


V.0.0.3 - app closure when using previously set pin

eCBIS: v.0.0.3
Describe the bug
V.0.0.3

[ ] When I upgraded app from v 0.0.2 to 0.0.3, the app was able to redirect me to the pin login page. However, the app crashed the moment I entered the pin previously set. This is happening for the first 3 or so times I try to log in.
Other observations: this did not occur when I used the password and set the pin login again.
[ ] When I logged in using the password, I was prompted to set pin again, even though I had set this in the previous logins.

Expected behavior

[ ] When a user upgrades from any previous version of the app, if they had set the pin for login, they should be redirected to the pin log-in page. The app should not crash if the user enters a previously set pin.
[ ] If a user opts to use a password after setting the pin, once they are redirected to the username/password page, they will be required to enter the username and password. Once they enter the correct username and password, they are redirected to the register main page.

@AnnieMungai I tested first part of the issue, It's not occurring in the new build. and for the the second I have created a PR for that. CC: @dubdabasoduba


Router.currentRouteParams validate JSON.stringify before calling JSON.parse

Currently in the Router.currentRouteParams function, JSON.parse is being called without any validation on what is returned from JSON.stringify, thus, causing JS error preventing page from loading if value returned from JSON.stringify is undefined.
Here's the current function which has the bug in it:
Router.currentRouteParams = function() {
    var route = Router ? Router.current() : null;
    if(!route) {
        return {};
    }

    var params = {};
    for(var key in route.params) {
        params[key] = JSON.parse(JSON.stringify(route.params[key]));
    }

    return params;
};

This is what I had to modify the generated files with to fix this problem:
Router.currentRouteParams = function() {
	var route = Router ? Router.current() : null;
	if(!route) {
		return {};
	}

	var params = {};
	for(var key in route.params) {

	    var stringify = JSON.stringify( route.params[key] );

	    if( stringify ){
            params[key] = JSON.parse( stringify );
        }
	}

	return params;
};

Please can you fix this ASAP, this is a show stopper for me

Fixed long time ago, closing.


fixes for missing isbn

I had this issue with book id<PHONE_NUMBER>763
[-] Title: Neo4j in Action
[-] Authors: Aleksa Vukotic and Nicki Watt with Tareq Abedrabbo, Dominic Fox, and Jonas Partner
[-] Identifier:<PHONE_NUMBER>763
[-] ISBN: None

Logs:
[08/Mar/2018 19:31:31] Downloading book images... (233 files)
[08/Mar/2018 19:35:59] Creating EPUB file...
[08/Mar/2018 19:35:59]   File "safaribooks.py", line 1002, in <module>
    SafariBooks(args_parsed)
  File "safaribooks.py", line 347, in __init__
    self.create_epub()
  File "safaribooks.py", line 941, in create_epub
    self.create_content_opf().encode("utf-8", "xmlcharrefreplace")
  File "safaribooks.py", line 866, in create_content_opf
    (self.book_info["isbn"] if len(self.book_info["isbn"]) else self.book_id),

[08/Mar/2018 19:35:59] Unhandled Exception: object of type 'NoneType' has no len() (type: TypeError)
[08/Mar/2018 19:35:59] Last request done:
	URL: https://www.safaribooksonline.com/library/view/neo4j-in-action/9781617290763/268fig04.jpg

Thanks for the pull request.
I think it can be better to solve this problem with this statement:
self.book_info["isbn"] if self.book_info["isbn"] else self.book_id
What do you think?

@lorenzodifuccia I'm no expert in Python at all. Never written anything in Python. If you think that's better, I will change that :)
What I did is just googled how to verify variable type before calling len :D

It's ok ahaha
Thanks for the help!!!


New Hotfix <IP_ADDRESS> Is Live!

Today new update from HURTWORLD, and oxide dosent work.
Thanks for oxide update.

Just wait for it...
https://umod.org/faq#when-will-x-game-be-updated

Wulf is sleeping so you'll have to wait a few hours.

The GitHub issues are not used for discussions, please use the forums on https://umod.org/!


[CORE] Update Substrait to 0.24.0

What changes were proposed in this pull request?
Update Substrait to 0.24.0
I understand a lot of this is currently dead code, but would be nice to move things in the right direction.
How was this patch tested?
Existing tests.
Local Package Test:
mvn clean package -Pbackends-velox -Pspark-3.4 -Prss -DskipTests

@PHILO-HE please may I have a review?

The red CI may have been fixed in main branch. Please do a rebase. Thanks!

@baibaichen

I merged master and it broke 🥴

I merged master and it broke 🥴

Don't worry. It's not relevant to your pr. The log says the disk has no space. Let me handle it.

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query
log/native_4361_time.csv
log/native_master_01_14_2024_00db209eb_time.csv
difference
percentage

q1
32.61
33.95
1.339
104.11%

q2
24.80
24.88
0.074
100.30%

q3
38.09
38.01
-0.072
99.81%

q4
37.81
38.25
0.436
101.15%

q5
72.29
71.46
-0.827
98.86%

q6
5.68
7.30
1.621
128.54%

q7
82.67
85.49
2.829
103.42%

q8
85.76
85.37
-0.387
99.55%

q9
128.42
122.58
-5.841
95.45%

q10
47.61
44.98
-2.635
94.47%

q11
20.01
19.89
-0.122
99.39%

q12
28.30
28.31
0.015
100.05%

q13
47.17
47.25
0.077
100.16%

q14
21.19
19.45
-1.734
91.82%

q15
31.27
29.55
-1.716
94.51%

q16
14.18
14.42
0.242
101.70%

q17
101.82
102.43
0.607
100.60%

q18
148.16
148.49
0.330
100.22%

q19
15.06
13.56
-1.497
90.06%

q20
28.62
27.19
-1.436
94.98%

q21
226.58
228.47
1.890
100.83%

q22
13.74
13.86
0.120
100.87%

total
1251.83
1245.14
-6.688
99.47%


Foundation does not work with links using method delete

With links using data-method delete like following
<a rel="nofollow" href="/users/sign_out" data-method="delete">

I can't perform expected actions. Signing out and deleting records has stopped working.  ;-(
if you google for:
foundation rails o route matches [GET] "/users/sign_out"
you will get lots of SO questions without response. Is there a way to fix this problem?
Can somebody point me to working example Rails4 application that Uses Device and Foundation?

Not sure this is a Foundation question. Perhaps a pure rails forum could help you more.


Hints for more complex custom keywords

I would like to implement custom keyword, which allow to dispatch to different sub-schemas
based on value of some data attribute (for example data.type)
{schemaProperty: 'type',
 schemaMap: {
   Human: '#/definitions/Human',
   Hipster: '#/definitins/Hipster'}}

I've honestly spent half-day trying to do it by compile or inline, but definitely need your hints how to make it work :)

Does switch from v5 proposals look like something that you need? Because it is coming soon :)
Otherwise you have two options. If you want to do with compiled keyword it is definitely simpler, the only downside is that you'll have functions calling functions... You simply need to compile subschemas into separate functions and conditionally call them. If you want to use inlined keyword that's more tough - you'll need to do the same as ajv does - recursively call code generator for each schema and inline this code in a switch. Not easy, but much faster validation.
The trick here is in error reporting but all you have to is to pass through dataPath that is passed as a second parameter to validating function (I need to document it probably)
The compile option is here:
ajv.addKeyword('schemaMap', {compile: function(schema, parentSchema) {
  var validators = {};
  // I am assuming there are schemas inside schemaMap,
  // if you need to pass refs just use `{$ref: "ref"}`
  for (var key in schema) validators[key] = ajv.compile(schema[key]);
  var keyProperty = parentSchema. schemaProperty;

  return function validate(data, dataPath) {
    var key = data[keyProperty];
    var v = validators[key];
    var valid = v ? v(data, dataPath) : true; // if no match, assume passed
    validate.errors = valid ? null : v.errors;
    return valid;
  };
}});

And it works: https://tonicdev.com/esp/56579a6ae505840c00c1953b

I would say that your idea looks more like a JavaScript switch than v5 proposal

Thx,
I've also terribly hacked it like:
inline: function (it, data){
    var $data = 'data' + (it.dataLevel || '');
    var out = ""
    var pairs = []
    for(var k in data.schemas){
        var $refVal = it.resolveRef(it.baseId, data.schemas[k], it.isRoot)
        $refVal =  $refVal.code || $refVal
        if ($refVal === undefined) {
        throw new Error("Could not resolve" + data.schemas[k])
        }
        pairs.push([k, $refVal])
    }
    var attrs = pairs.map(function(p){
        return p[0] + ':' + p[1];
    }).join(',')
    return "(function(){ var ref = {" + attrs + "}[" + $data + ".resourceType]; "
        + " var res = ref("+ $data +", (dataPath || '')); "
        + " vErrors = ref.errors;"
        + " errors = ref.errors.lenght;"
        + " return true; })()"
}

it's similar to v5/switch, but little narrowed :)
Is it good idea to submit it to v5 draft? Because, it looks useful.

I think it should be a bit changed along the conventions... I'd put all the logic in one keyword and JSON pointer inside data instead of property name. E.g.:
{
    schemaSwitch: {
        switch: { $data: 'JSON pointer in data' },
        schemas: {
            Human: {...},
            Hipster: {...}
        }
    }
}

On the other hand it can be easily achieved with a combination of $data and $ref keywords so probably no need for this construct:
{
  id: 'http://myschemas.com/schema.json#',
  definitions: {
    schemas: {
      key1: { id: "key1", ...},
      key2: { id: "key2", ...}
    }
  }
  anyOf: [ { $ref: { $data: 'JSON path in data mapping to the key value } } ]
}

Re your inlined implementation, the whole point of it is to avoid using functions, you just have to use unique variable names...

Yes, $data would work.
Why not just
{
  id: 'http://myschemas.com/schema.json#',
  definitions: {
    schemas: {
      key1: { id: "key1", ...},
      key2: { id: "key2", ...}
    }
  }
  type: { $ref: { $data: 'JSON path in data mapping to the key value }
}

?

But type just checks type and this schema is invalid... You need to validate against schema.

Actually the better way to express it without any custom keywords is:
{
  anyOf: [
    {
      properties: {type: {enum: ['Human'] }},
      ...
    },
    {
      properties: {type: {enum: ['Hipster'] }},
      ...
    }
  ]
}

In swagger spec i found very similar idea:
discriminator  	Adds support for polymorphism. The discriminator is the schema property name that is used to differentiate between other schema that inherit this schema. The property name used MUST be defined at this schema and it MUST be in the required property list. When used, the value MUST be the name of this schema or any schema that inherits it.


operator.istio.io/version: 1.4.0 shows wrong version

This version looks to be hardcoded, and does not match the actual version that ends up being installed

We do use a hardcoded internal "charts version" to determine compatibility, regardless of which version is supplied through the build. Where are you seeing this exactly? We may need some way to display this differently.

I see this on some deployments after using istioctl.

I think this is resolved through https://github.com/istio/operator/pull/610 but not verified. We can see when 1.4.1 is released.

this is still hardcoded. Not sure if it's intended or not @elfinhe if it is feel free to close


libdream fixtures do not get universe

Fixtures only get context. Some need access to universe.
example:
func createAuthService(ctx context.Context, config *iface.ServiceConfig) (iface.Service, error)

should be
func createAuthService(u *libdream.Universe, config *iface.ServiceConfig) (iface.Service, error)

Also some odd behavior of auth under dream/dev  was fixed

Node meshing was also fixed.


Assignment6

Great work! You can also show some of the other vector operations like rotation, normalizing, absolute


fix url parsing with port numbers

String.get_slice_count is always at least 1 or 2 for bases with a port number.
Before this change the following URL would return ERR_INVALID_PARAMETER ws://<IP_ADDRESS>:8000/test
Bugsquad edit: Fixup to #48205. Fixes #49652.

Probably fixes #49652.

Thanks!

Cherry-picked for 3.4.

Cherry-picked for 3.3.3.


include actionCodeSettings in the sendUserEmailVerification function

add settings parameters to types/index
add actionCodeSettings as a command argument
use parameters for the actionCodeSettings values in both ios and android
update readme.md

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation  changes
[ ] Other... Please describe:

PR Checklist
Please check your PR fulfills the following requirements:
Bugfixes:

[ ] Regression testing has been carried out using the example project to ensure the intended bug is fixed and no regression bugs have been inadvertently introduced.

New features/enhancements:

[x] Exhaustive testing has been carried out for the new functionality
[x] Regression testing has been carried out to ensure no existing functionality is adversely affected
[x] Documentation has been added / updated
[ ] The example project has been update to validate/demonstrate the new functionality.

What is the purpose of this PR?
This change adds supports for including the action code settings that allows you to add certain parameters to the verification email link. e.g opening the link on mobile vs opening the link in the mobile app
Does this PR introduce a breaking change?

[ ] Yes
[x] No

What testing has been done on the changes in the PR?
This PR has been tested with sending verification emails with various settings.
What testing has been done on existing functionality?
This PR has been tested without including actionCodeSetting Parameters. The email verification function still worked.
Other information
The changes in this PR have been used in a production app available on both the App Store and Google Play Store.

Good timing, I'm literally just putting together the next release!
I'll give this a quick test and I think we can sneak it in 😀


Add topologySpreadConstraints in Helm chart

To use instead of pod anti-affinities.

Can you expand on this request?

Can you expand on this request?

For High Availability I'd like to use topologySpreadConstraints for karpenter.


scope script: Allow 'user' part of image name to be given by DOCKERHUB_USER env var

This allows alternate scope images to be used, and mirrors the option available for weave net.

LGTM


Page Not Found.

This Link
https://github.com/Azure-Samples/cognitive-services-speech-sdk/blob/master/quickstart/java/README.md#get-the-samples
Under this Label
"Download the sample code to your development PC".
Is not working.
It's returning the 404 Error.

Thanks for pointing this out.
In a recent re-shuffling of the quickstarts, updating the readme.md files was missed. I'll work on that in the next day or so.

Fixed.


IDE issues with project structure

PureScript IDEs do not play nice with the cookbook directory structure.
The IDEs usually expect to find these in the root directory:
root
  output/
  packages.dhall
  spago.dhall

We still have a common output/ and packages.dhall in root, but use a separate spago.dhall for each recipe.
root
  output/
  packages.dhall
  recipes
    RecipeFoo
      spago.dhall
    RecipeBar
      spago.dhall

So if you open your editor at the root, you'll see errors about a missing spago.dhall.
One workaround is to change your development root (where you open your IDE from) to the directory of the recipe you are editing:
cd recipes/RecipeFoo
spago build
code .

This workaround has a few issues:

output/ is duplicated in the recipe directory.
Automatic page refresh (from make RecipeFoo-web) will not pick-up this local output/, since it relies on output/ at root.

You can get page refresh to work by running make RecipeFoo-build-watch in another terminal, which will also build changes into output/ at root. This is not ideal, because now we're duplicating effort by building into two output/ locations.

A follow-up task is to document our recommended workaround in Contributing.md. Will do that after #228.


click logo after login

Clicking on the logo after login, redirects to '/dashboard' instead of '/'.

👏


Make TestStorage safe for async tests

We can't use Uploadex.TestStorage with async tests because of the following random error:
** (exit) exited in: GenServer.call(Uploadex.TestStorage, {:update, #Function<6.116564614/1 in Uploadex.TestStorage.store/2>}, 5000)
         ** (EXIT) no process: the process is not alive or there's no process currently associated with the given name, possibly because its application isn't started
     stacktrace:
       (elixir 1.12.3) lib/gen_server.ex:1014: GenServer.call/3
       (uploadex 3.0.0-rc.0) lib/storage/test_storage.ex:24: Uploadex.TestStorage.store/2

This probably happens because we use TestStorage.start_link() (which calls Agent.start_link(fn -> initial_value end, name: __MODULE__)) in the test setup, but the Agent process dies when the test is ended, but other tests relies on the same Agent instance, since it has the same name.
We could start only one instance of the Agent in the test_helper.ex, but all tests would use the same storage, causing other random errors, such as files from other tests in the stored state.
We want a completely isolated TestStorage per test. For that we need to have a unique name the Agent process. We could use the test module name, but this probably won't work because the TestStorage.store/2 and TestStorage.delete/2 are functions from behavior and are called from inside Uploadex, so we can't pass this names for this callback functions.
So probably a better approach would be using a name based on the current process pid.
What do you think? There's a better option here?

Haven't looked into it yet, but my suggestion is to see how other libraries are doing this, for example https://github.com/dashbitco/mox. The fact that we can assert how many times each function was called during the test makes me think they also use an Agent/GenServer, and they support async tests.

It seems mox has its own supervision tree: https://github.com/dashbitco/mox/blob/master/lib/mox/application.ex, so it's a global process not associated to any specific test process, and the GenServer keeps track of which processes are using it: https://github.com/dashbitco/mox/blob/be379dfcb256729cdf4ad76d50c937bc2202c5f2/lib/mox/server.ex#L235. That's in line with your first suggestion, but does seem more complicated because we need to handle the multiple asynchronous states in the code.
So if the idea of starting different processes based on the test pid works, that would be nice and simpler. If it doesn't, then we would probably need to follow a similar route from mox.


Error when trying to variant call using an R10 model

Hi Jared,
I have trained a basic k-mer model for R10.4.1 using your R10 branch in nanopolish, using the recent R10.4.1 base models provided by ONT. I am trying to evaluate some variant calls using that, but I am getting the following error
nanopolish variants -r reads.fastq -b reads.bam -g ~/scratch/hg38noAlt/hg38noAlt.fa -p2 --models-fofn=a.txt
Error: unknown model:

The contents of a.txt looks like:
../r10-models/r10.4.1_400bps.nucleotide.9mer.model

The head of the ../r10-models/r10.4.1_400bps.nucleotide.9mer.model is like:
#model_name     r9.4_450bps.nucleotide.6mer.template.model
#kit    r9.4_450bps
#k      9
#strand template
#alphabet       nucleotide
AAAAAAAAA       54.20490641     3.0     1.0     1.0
AAAAAAAAC       58.59079727     3.0     1.0     1.0
AAAAAAAAG       55.952068       3.0     1.0     1.0
AAAAAAAAT       58.43352009     3.0     1.0     1.0
AAAAAAACA       63.65995928     3.0     1.0     1.0

I initially had the following but changed the name to R9.4 to see if the name was the issue.
#model_name     r9.10.1_400bps.nucleotide.9mer.template.model
#kit    r10.4.1_40bps

Is there a way to test a new R10 9-mer model in nanopolish?
I manage to do an event alignment using f5c eventalign using this model and most reads successfully aligned. As I am not sure of the best way to check the accuracy of signal alignments, I thought perhaps using the nanopolish variant caller could be a solution. Your thoughts are welcome.

It would appear that nanopolish failed to parse the header for some reason. What you pasted looks fine, could you provide the model to me so I can look into this more closely?

Hi Jared,
Thanks for the quick response. The file is available here https://raw.githubusercontent.com/hasindu2008/f5c/r10/test/r10-models/r10.4.1_400bps.nucleotide.9mer.model

Also, when training for a large human dataset using the r10 branch, the nanopolish train seems to crash after some time:
/usr/bin/time -v nanopolish  train -r PGXX22563.pass.fastq -g hg38noAlt.fa -b PGXX22563_pass.bam  -t 64 --train-kmers=all --input-model-filename ../r10-models/r10.4.1_400bps.nucleotide.9mer.model -d ../pcr/
[train] initialized r10_450bps for alphabet nucleotide for 9-mers
[train] round 0
nanopolish: src/nanopolish_train.cpp:515: void add_aligned_events_for_read(const ReadDB&, const faidx_t*, std::vector<StateSummary>&, const string&, const string&, size_t, std::unordered_map<unsigned int, int>&, const std::vector<BedMethylRecord>&, const bam_hdr_t*, const bam1_t*, size_t, int, int): Assertion `training_kit == sr.get_model_kit_name(strand_idx)' failed.

Any idea how this can be fixed? Now I am trying to extract chromosome 1 and try running only on it.

The, training for chr1 did not crash, but unfortunately none of the k-mers have been trained.
[train] initialized r10_450bps for alphabet nucleotide for 9-mers
[train] round 0
[bam process] processed 566251 bam records in 590.00s (960 records/s). Latest: chr1:248882296
[train] trained 0/262144 k-mers in 0.00s
[train] round 1
[bam process] processed 566251 bam records in 589.00s (961 records/s). Latest: chr1:248882296
[train] trained 0/262144 k-mers in 1.00s
[train] round 2
[bam process] processed 566251 bam records in 587.00s (965 records/s). Latest: chr1:248882296
[train] trained 0/262144 k-mers in 1.00s
[train] round 3
[bam process] processed 566251 bam records in 589.00s (961 records/s). Latest: chr1:248882296
[train] trained 0/262144 k-mers in 0.00s
[train] round 4
[bam process] processed 566251 bam records in 589.00s (961 records/s). Latest: chr1:248882296
[train] trained 0/262144 k-mers in 0.00s

Could be some parameters? Incase you want to reproduce, all the necessary files are here as a tarball. To reproduce:
tar xf nanopolish-train.tar
cd nanopolish-train/PGXX22563_pcr/
../slow5-nanopolish-train/nanopolish  train -r PGXX22563.pass.fastq -g hg38noAlt.fa -b PGXX22563_pass.bam  -t 64 --train-kmers=all --input-model-filename ../r10-models/r10.4.1_400bps.nucleotide.9mer.model -d ../pcr/

This uses the SLOW5 integrated nanopolish r10 branch so we can do the training fast when signal files are residing on NFS and @hiruna72 has separately sent a PR.
Note: The training worked for R9.4.1 data when existing nanopolish R9.4 were used as base models (though the accuracy got worse because the existing pore-model for R9.4 was anyway good)

So, going back to the original issue when I run with your model I get this error:
Error, unrecognized model kit r10.4.1_400bps

This is because the metadata in nanopolish hasn't been set up for R10.4.1:
https://github.com/jts/nanopolish/blob/r10/src/pore_model/nanopolish_model_names.cpp#L17
If I change the model kit to be r10_450bps the model loads correctly but all the reads are discarded, likely because the signal calibration fails. This is probably why no training happens on chr1. I will try to look into why calibration fails.

Hi Jared,
After renaming as you said, the pore model seems to load. I added some debug prints and the alignment step seem to fail.
However, when I run f5c event align with the same model, most reads align and pass calibration (see attached if they look reasonable). Is the adaptive banded event alignment algorithm in the r10 branch different to the one that used to be in Nanopolish main branch (that I used 3 years ago when writing f5c)? I briefly looked at the r10 code and they look considerably different.
summary.tsv.gz
events.tsv.gz

The r10 branch training method re-uses the adaptive banded alignment code, which I made more generic to support this use. I thought it was functionally equivalent but I will look into it.

I've tried your f5c r10 branch on some local R10.4.1 data I generated but no reads aligned:
[meth_main] total entries: 4238, qc fail: 0, could not calibrate: 0, no alignment: 4238, bad fast5: 0

Could you provide me with the small set of reads that you used to generate eventalign.tsv and summary.tsv?

Hi Jared,
You can download a little dataset from here. Commandline should like like:
./f5c eventalign -b test/hg2_lsk114_reads_1000/PGXX22394_reads_1000_6.4.2_sup.bam -r test/hg2_lsk114_reads_1000/PGXX22394_reads_1000_6.4.2_sup.fastq -g hg38noAlt.fa --slow5 test/hg2_lsk114_reads_1000/PGXX22394_reads_1000.blow5 --kmer-model test/r10-models/r10.4.1_400bps.nucleotide.9mer.model

The output is like:
[meth_main] total entries: 1076, qc fail: 2, could not calibrate: 0, no alignment: 156, bad fast5: 0

@jts Could you also provide me with a little portion of your dataset? Would like to investigate what the difference is?

Ah, f5c does work for me - I was providing the model incorrectly before.

I needed to make two changes in https://github.com/jts/nanopolish/commit/5b6ac67ba94496164d2514b9a89fe4db4fc307de to make the reads load:

the R10 pore detection was failing due to the new flowcell type
the event detection parameters that I used for R10.0 do not seem to work for R10.4.1, so I have gone back to the r9 ed parameters for now (which I assume f5c is using)

Note that the r10 branch is now far out of date with master. Rebasing it seems messy so I will likely re-implement R10.4.1 support from scratch

Cool. Now it seems to actually do training some k-mers when I tested with chr1. Now let me run with the whole genome. For a PCR'ed dataset, does the following command look right to you?
nanopolish  train -r PGXX22563.pass.fastq -g hg38noAlt.fa -b PGXX22563_pass.bam  -t 64 --train-kmers=all --input-model-filename ../r10-models/r10.4.1_400bps.nucleotide.9mer.model -d ../kmers/

Hi @jts
After 5 training rounds, roc plots for snps look like this.

Do you think the accuracy has saturated and would it be beneficial to go for more rounds?
Or any idea how we could improve the accuracy further - for instance parameters and thresholds?


Add deserialize option to patch and reset

When the second argument of Microcosm::patch or Microcosm::reset is
true, Microcosm will call `deserialize on the provided data payload.
repo.reset({ users: [{ id: 'bob' ] }, true) // will deserialize
repo.patch({ users: [{ id: 'bob' ] }, true) // will deserialize

Fix #158

Coverage remained the same at 100.0% when pulling 4df28144b4df392e962aa2d54282933f5b9ebdcd on nh-deserialize-option into 85de3bdbf2e5fafa202c6902d0c0d1c16fc67ba3 on master.

Coverage remained the same at 100.0% when pulling 4df28144b4df392e962aa2d54282933f5b9ebdcd on nh-deserialize-option into 85de3bdbf2e5fafa202c6902d0c0d1c16fc67ba3 on master.

Coverage remained the same at 100.0% when pulling af4c41f926a72432a5384653bc5b7c788b675b7c on nh-deserialize-option into 0b7de84d5c89ea7817bdde592c4ef5b58312bb64 on master.


best way is only use transform,not fit_transform.

https://github.com/nfmcclure/tensorflow_cookbook/blob/master/07_Natural_Language_Processing/02_Working_with_Bag_of_Words/02_bag_of_words.py#L138

Fixed.


Teacher create tasks for the subject

Teacher create tasks for the subject

Task linked: CU-869319bbp Tasks

Task linked: CU-869319bbp Tasks


fix: improve descriptions

:tada: This PR is included in version 1.0.1 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:


The configured port is not used by the client

This line starts the client always using port 0 instead of the one from the configuration.

I think the port in the configuration is intended to be the target SSDP port on the network, not the originating bound port. Port 0 generates a random port number that is guaranteed to not be in use already. But setting it to _ssdpPort looks like it would break my usage as I have two discovery processes running and it would mean under default config one would fail to bind.
I'll hopefully raise a PR soon to allow it to be passed in as an additional configuration value which defaults to 0, maintaining current behaviour unless it's actually set.

@driskell is correct. I'll leave the current behavior as-is for now.


insertion data export revisions

added a deploy note about importing updated manifests to get corrected page labels from figgy
order canvases by item and label so that insertions within a work will group together

questions:

All book type values are book because only books can have insertions. Drop the field and note in the dataset readme?
the id field doesn't really look like an id to me; what if we call it label? (do we need an id?)

Codecov Report

Merging #282 (bdcc067) into develop (abc7523) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop     #282   +/-   ##
========================================
  Coverage    96.08%   96.08%
========================================
  Files           99       99
  Lines         5290     5290
========================================
  Hits          5083     5083
  Misses         207      207

I was just eyeballing the column and missed the journal article. I'll leave it.
Agree an id would be useful, will figure out something I can use.

Wait! we need to exclude pk 243.


chore: add refl annotations to List.IsPrefix etc

These lemmas are currently not working with the rfl tactic even after import Mathlib. Since they are declared in the core, it seems easiest to just provide the annotation afterwards.

bors merge


Package publication error

I'm a co-author of the oasislmf package
https://pypi.python.org/pypi?:action=display&name=oasislmf&version=1.0.8
but I'm unable to upload a new version of this 1.0.9. I normally use twine. I'm getting the following error message
HTTPError: 403 Client Error: Invalid or non-existent authentication information. for url: https://upload.pypi.org/legacy/

I have checked that my login credentials in the .pypirc file are correct, and this is the first time I've had problems in publishing the package.
I'm using twine version 1.10.0, Python 2.7.10 (in a virtual env.), on Mac OS X 10.13.3.

Hello @sr-murthy!
I see two upload attempts recently matching the environment you specified and a username that is associated with the oasislmf package. I also note that the username has successfully logged into PyPI recently.
Assuming you can log in to pypi.org with the username/password in your .pypirc, I'd first ask that you try the upload with the latest release of twine 1.11.0.
The error message you're receiving indeed indicates that the password being supplied to upload.pypi.org is incorrect, so it may be that the upload client (twine in this case) is sending the wrong username and password.

This is bizarre - the password I thought worked, and which was saved in the .pypirc file, did not work. So I requested a password reset. On clicking the link and setting the new password I receive the following error page

@sr-murthy this is very likely a breaking change in warehouse that broke password resets for pypi-legacy.
Please use https://pypi.org/account/request-password-reset/ to request a reset. Sorry for the confusion.

Thanks. Could you possibly check whether I have two separate emails associated with a single account, or whether there are two accouns with different emails? The password reset email from that last link was sent to my personal email, which is the primary email I use for commits to GitHub. Previously another password reset email I requested via pypi.org was sent to my work email.

After upgrading twine I managed to publish it. Thanks.

@sr-murthy once you're logged in to pypi.org, you can view and manage your email addresses at https://pypi.org/manage/account/. I see two addresses associated with one account. Resets are sent to the one marked as Primary.


[feat][store] serial refactor.

serial refactor.
The change include 3 parts:
store: for coprocessor and dingo-sdk
libexpr.
dingo-serial.

discard.


Button in the popup to export any time-based trend

This update ports over the "Export Daily History to CSV" button from my userscript now leveraging the API framework of Monarch's extension along with several other enhancements. Since inserting the export button into the page did not work out this pull request accomplishes the same with a "Download current trend daily balances" button in the popup. No content script so none of the insurmountable issues that derailed #23.
The button is enabled when viewing an exportable trend like Net Income Over Time or Spending Over Time for 5 selected accounts.

Export any time-based trend
The fetch functions have been generalized to work for any time-based trend which is pretty much just passing in a report type and a list of accounts that become filters. When working with trend state the extension fetches the daily balances for the exact time period you're looking at – no optimization to avoid fetching zero months. I had it in the original userscript but since the popup is such a nicer way to export all accounts I think the use cases for trend exporting would not demand that kind of optimization. Just use a custom date range if you're concerned about loading too much data 😉
The formatBalancesAsCSV function now supports the oddball net worth and net income trends that include extra columns. zipTrendEntries() handles the API response for those trends since they can contain two TrendEntry rows per date. Same trimming of zero values at the end of the CSV for all trend types.
Making API requests correspond to Mint trend state
The current trend state is sourced from a Redux store on a component in the Mint Trends page. It provides all of the data necessary to reproduce the same API queries that Mint used to chart the trend.
This Redux store was difficult to find and the original implementation used a different data source that was convoluted and unreliable. Original discussion is no longer relevant, but preserved below:

Okay, so... localStorage.trends-state-ASSETS and friends track the current state of the user's selections on the Trend page. As a user I select the accounts that I want to see but localStorage.trends-state-* lists only deselectedAccounts. The concept of "all accounts" differs based on the report type so it's inconvenient that we only know which are deselected.
Weird, but no problem since the trends API seems to support affirmative and negative filters [{ matchAll: true, filters: [...] }, { matchAll: false, filters: [...] }]. Except, taking that deselectedAccounts value and plugging it in to the matchAll: false filters results in a 400 bad request. I tried everything I could think of but was not able to figure out if the API supports filtering based on the deselected accounts.
So, getAccountTypeFilterForTrend() was born. We now have a mapping ACCOUNT_CATEGORY_BY_ACCOUNT_TYPE of all account types (from an enum in the Mint source) to category (asset or debt). That seems to work for most of the report types to determine which accounts are eligible but NET_INCOME is a special little darling.
I found some code in Mint that maps each trend report type to the specific account types that are automatically disabled. The code can be found by searching for accountsToFilter, it's in the trends ui library.
The CashAccount and InsuranceAccount types are always excluded if the trend is filtered by account. If "All accounts" are selected then these are both included (if the trends backend includes them, it at least does for NET_INCOME). I assume InsuranceAccount is a legacy thing, I do not have one and was unable to add one.
To test I compared the daily balances table shown for "Last Month" trends to the daily CSV. I exported the "All accounts" data and compared the numbers, then deselected one old account that has no transactions in the last month and compared those. Mint produces different numbers for these two cases not because my old savings account had transactions in the last month, but because CashAccount and InsuranceAccount are excluded only if some other account is excluded as described above.
Finally, the daily export button has been disabled on trends filtered by tag, category, or merchant. Those filters are not represented in localStorage.trend-state-* and there's not much value in trying to work something out. If anyone needs that functionality for some reason, the userscript can do it since it just repeats the last trend API request. We do not have access to that data since it required code modification that made the userscript very difficult to set up.

Can you please provide a simple summary of why and where we need to be clicking this new button?  It's easy to get lost in all the details in your OP.

Thanks for following up on this, it looks like Mint has pushed the sunset date so this might still have a chance to help people.
This adds a third button to the extension popup that should be visible when you click the extension icon. The button is enabled if you're viewing a Mint trend page and when clicked exports daily balances for that trend over the time period shown in Mint. Unlike the existing per-account export it allows combining accounts to export trends like "all student loan payoffs" or net worth.
When I was using this back in November to export very old trends I noticed that the Mint API took a lot longer to respond (and often timed out with no data at all) for old data. Severe rate limiting (like 1 request per 5 seconds) had no effect, it seemed to be a general Mint API issue. The Mint UI similarly failed to load trends most of the time.
If this is still an issue, a possible improvement would be to fetch data in the reverse order, collecting daily balances for the most recent transactions first moving back in time until the API gives up. A partial export could be more useful than no data at all.
Honestly though I don't know if anyone other than me finds this useful. I considered asking people on the subreddit but assumed that the Monarch dev team would not have time to review this one anyway.

Thank you for the quick follow-up and notes.  I'll definitely what you've said about old trends in-mind when I export my Mint data near the end of December.
When I'm ready to export, I plan to combine the active PRs into my own fork and then use that instead of the current version of the plugin.  I'm hoping (likely in vain) that Monarch addresses the open issues and PRs before then.

Thanks! I assumed you were from Monarch 😄
I'll do some more testing on this to see if it can be improved and to see if the Mint API is still in a woeful state.

Today's update addresses issues I was having with pulling the current trend state from localStorage. Mint tracks the trend there for the purposes of resuming it if you refresh the page, but it is extremely unreliable. Occasionally accounts get unset, dates change, and it is even more unpredictable if you have multiple tabs open. It often did not accurately reflect the UI state unless you had just recently configured the trend and you can see this in Mint by refreshing the trend page and occasionally ending up at a different trend.
Now after excessive digging around in the DOM to find the pieces that I needed, then discovering a Redux store with all of the data in one place, the extension instead pulls the current trend state from React. This works with multiple browser tabs open and avoids the debacle of transforming deselectedAccounts into the selected accounts.
This does not yet support category, tag, and merchant filters available on the Income and Spending trends. I have started working on that because I have several tags that I like to track with annual trends. I can just get the data from Monarch now but hopefully it will be helpful to others.

Earlier I had interpreted a response with no Trend array as a timeout, but after adding support for exporting trends filtered by tag or category I noticed that Trend is always omitted when every value in the time period is zero. I was exporting some very infrequent tags that had large gaps between old and new data. The old data loaded fine but the middle gap always errored out. Since there are no dates the extension generates the rows with zero amounts.
This was great news since my past experience with API issues may have just been due to exporting gappy data.

Here are some examples of things you can export with the "Download current trend daily balances" button:

Net worth
Credit card spending (e.g. select "All credit cards" in the Spending trend)
All investments (e.g. select "All investments" on the Assets trend)
Spending by category (e.g. select "Category: Groceries" under "Show the transactions that match" on the Spending trend)
Income by merchant (e.g. select "Merchant: FizzBuzz Ltd"  on the Income trend)
Spending by tag and merchant (e.g. select "Tag: My Tag" and "Merchant: Target" under "Show the transactions that match" on the Spending trend)
Single account balances, useful after fixing a problem seen in the all accounts export (e.g. select "My Bank Account" on the Assets trend)
Net income (though why would you want daily net income?)
Any trend you want, as long as one of the "over time" options is selected in the trends sidebar.

@idpaterson we're really sorry we're so behind on reviewing things here.. one thing that could help, could we split out any code in here related to rate-limiting of the existing functionality from the new functionality into separate PRs?

Good idea, at the time it was the only way I could make progress on this branch but it's a good idea to separate it.

Thanks for reviewing the small ones, I’ll rebase this PR when I get a chance!

@idpaterson Is this PR ready for review? Thanks!

Yep it is up to date with main and ready to review.

Any updates on this?

It’s not going to happen, Monarch definitely has more important work to do and we’re closing in on the Mint shutdown date.

It’s not going to happen

Seems you were right.  :
Thank you for trying to get this merged, regardless.

You’re welcome! Fortunately most of the improvements along the way to the trend button made it in via separate pull requests.
Monarch has been very nice to work with, they reached out recently offering to add more code review time for contributions to this extension. However, with the shutdown looming I decided it was not worth taking the risk of pushing new code. If an undetected mistake were introduced in the past couple weeks it could have left a lot of people with imperfect CSVs.
Thanks for following up, I hope your migration went well


TypeError: add_weight() got multiple values for argument 'name'

I got the following error when running python DEC.py
Using TensorFlow backend.
Namespace(ae_weights=None, batch_size=256, dataset='mnist', maxiter=20000.0, pretrain_epochs=None, save_dir='results', tol=0.001, update_interval=None)
MNIST samples (70000, 784)
Traceback (most recent call last):
File "DEC.py", line 321, in
dec = DEC(dims=[x.shape[-1], 500, 500, 2000, 10], n_clusters=n_clusters, init=init)
File "DEC.py", line 138, in init
clustering_layer = ClusteringLayer(self.n_clusters, name='clustering')(self.encoder.output)
File "/usr/local/lib/python3.5/dist-packages/keras/engine/base_layer.py", line 463, in call
self.build(unpack_singleton(input_shapes))
File "DEC.py", line 91, in build
self.clusters = self.add_weight((self.n_clusters, input_dim), initializer='glorot_uniform', name='clusters')
TypeError: add_weight() got multiple values for argument 'name'

I met the same problem, and I think I solve it.
line 91 in DEC.py
self.clusters = self.add_weight((self.n_clusters, input_dim), initializer='glorot_uniform', name='clusters')
change it to:
self.clusters = self.add_weight(shape=(self.n_clusters, input_dim), initializer='glorot_uniform', name='clusters')
Maybe it works for you, good luck

It worked for me, as well. @lazzyCloud

worked for me too.

This problem is caused by the difference of keras versions. @lazzyCloud has given the solution. Thanks.

Worked for me as well. @lazzyCloud, thanks.

TypeError: add_weight() got multiple values for argument 'name'
I have checked the keras/frcnn code. It is related to FixedBatchNormalization.py. It has four places where name is placed. So it incurs the above-mentioned TypeError.  But it is difficult to use the lazzyCloud method to correct the error. I take the original snippet of the application from the weblink for your refernece.

application: keras-frcnn:  https://github.com/kbardool/keras-frcnn/blob/master/keras_frcnn/FixedBatchNormalization.py

Snippet

def build(self, input_shape):
    self.input_spec = [InputSpec(shape=input_shape)]
    shape = (input_shape[self.axis],)

    self.gamma = self.add_weight(shape,
                                 initializer=self.gamma_init,
                                 regularizer=self.gamma_regularizer,
                                 name='{}_gamma'.format(self.name),
                                 trainable=False)
    self.beta = self.add_weight(shape,
                                initializer=self.beta_init,
                                regularizer=self.beta_regularizer,
                                name='{}_beta'.format(self.name),
                                trainable=False)
    self.running_mean = self.add_weight(shape, initializer='zero',
                                        name='{}_running_mean'.format(self.name),
                                        trainable=False)
    self.running_std = self.add_weight(shape, initializer='one',
                                       name='{}_running_std'.format(self.name),
                                       trainable=False)

    if self.initial_weights is not None:
        self.set_weights(self.initial_weights)
        del self.initial_weights

    self.built = True

Hope to get feedback from you.
Mike

Worked for me, thanks

I am having the same case as @mikechen66 mentions. Any workaround or solution for it?

any solution on it @mikechen66.. I tried to implement the same code .. but getting errors you mentioned


TypeCastError isn't raised when casting scalar value

https://play.crystal-lang.org/#/r/a1tf
1.as String

Showing last frame. Use --error-trace for full trace.

error in line 1
Error: can't cast Int32 to String

I would have expected this to work like the example in the API docs, where it actually raises a TypeCastError.

TypeCastError is a runtime error, it happens when resolving a union to a type that doesn't match its actual value at runtime.
You're looking at a compile error here.
Also remember, casting is interpreting the same value (the same bytes) as a different type. Conversion is producing an equivalent or comparable value in a different type. as does casting only.

Ahh rip, don't mind me 🙈.


Optionally store velocities

Description
This PR adds an optional velocities field to the core object model and updates some exporters accordingly.
Note that exporting to openmm.Context is not currently supported, so users will have to .setVelcoties() themselves.
Checklist

[x] Add velocities to Interchange model
[ ] Write velocities to .gro file
[ ] Write velocities to .inpcrd file
[ ] Write velocities to .lmp file
[ ] Add tests
[ ] Lint
[ ] Update docstrings

Will add this to exports later should they be used


Upgrade to Laravel 5.4.

What's this PR do?
This pull request upgrades Northstar to use Laravel 5.4!
References #148973145.
How should this be reviewed?
This follows the steps in the Upgrade Guide (cb51ad4), and then adds a slew of other miscellaneous fixes after tests broke, notably:
🤕 Adds more patches for problems in Laravel-MongoDB, since these changes have not been pulled into the upstream repo. (9a7b5e8, 254e4ac, and more updates in our patched fork).
📆 Removes some extra hacky stuff we were doing in the model around parsing strange date-times. We no longer store any dates in the database as strings or other weird stuff, so these are unnecessary. Instead, just using a standard mutator on birthdate to accept user-formatted dates. (d866488)
📍 Moves routes into routes/web.php and routes/api.php matching Laravel 5.4+ convention!
Checklist

[ ] Documentation added for changed endpoints.
[ ] Tests added for new features/bug fixes.
[ ] Post a message in #api if this includes something that causes a rebuild!

For now I've switched all the tests to use Taylor's "BrowserKit" Laravel 5.3 compatibility package so we don't have to re-write everything (but we should add a ticket to start updating these, since I'm sure this package won't be maintained forever).

😱


Remove traces of address book

Codecov Report

Merging #227 (bd71b6c) into master (c5f3711) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #227   +/-   ##
=========================================
  Coverage     77.96%   77.96%
  Complexity      699      699
=========================================
  Files            97       97
  Lines          2183     2183
  Branches        269      269
=========================================
  Hits           1702     1702
  Misses          384      384
  Partials         97       97

Impacted Files
Coverage Δ

...ss/logic/commands/exceptions/CommandException.java
100.00% <ø> (ø)

...ommands/modulelesson/ClearModuleLessonCommand.java
60.00% <ø> (ø)

...mmands/modulelesson/DeleteModuleLessonCommand.java
100.00% <ø> (ø)

...commands/modulelesson/FindModuleLessonCommand.java
100.00% <ø> (ø)

...commands/modulelesson/ListModuleLessonCommand.java
100.00% <ø> (ø)

...ddress/logic/commands/person/AddPersonCommand.java
100.00% <ø> (ø)

...ress/logic/commands/person/ClearPersonCommand.java
60.00% <ø> (ø)

...ess/logic/commands/person/DeletePersonCommand.java
98.56% <ø> (ø)

...dress/logic/commands/person/EditPersonCommand.java
97.29% <ø> (ø)

...dress/logic/commands/person/FindPersonCommand.java
100.00% <ø> (ø)

... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5f3711...bd71b6c. Read the comment docs.


Add Compact View Mode for User Tak Popup

Is your feature request related to a problem? Please describe
Actual User Task Popup takes a to much space on acreen
Describe the solution you'd like
Conpacted View that takes less space
Describe alternatives you've considered
Removing Popup, tray icon
Additional context

Mostly done within #75, #74, #72, #71, #70

Done enough for now.


Send to FSI / send line to FSI commands is not presented in settings, the latter does not work

Funnily enough I just came up against this this morning. It's EditorContextMenus.CodeWindow.ExecutiveInInteractive now.

Thanks! :)


python39Packages.tensorflow build failure on x86_64-linux as of 6140c314

Issue description
Build of python39Packages.tensorflow failed on x86_64-linux as of 6140c314d5850406dddc78e55dcc8716ea111ee4. This is currently breaking python3Packages.tensorflow-bin.
error: builder for '/nix/store/7ywkprr9hr5vm7i925hbx2f41acvg44l-python3.9-tensorflow-2.7.0.drv' failed with exit code 1;
       last 10 log lines:
       > Requirement already satisfied: protobuf>=3.9.2 in /nix/store/kxy6y3h8afiqgdm5p20xc59lc7gafcp2-python3.9-protobuf-3.19.3/lib/python3.9/site-packages (from tensorflow-cpu==2.7.0) (3.19.3)
       > Requirement already satisfied: numpy>=1.14.5 in /nix/store/wjbbv5qzda0amff05q5aw8k7xmsk90bl-python3.9-numpy-1.21.5/lib/python3.9/site-packages (from tensorflow-cpu==2.7.0) (1.21.5)
       > Requirement already satisfied: google-pasta>=0.1.1 in /nix/store/ml3m2rj3zddzycr5j1fczigqmdn5vyvf-python3.9-google-pasta-0.2.0/lib/python3.9/site-packages (from tensorflow-cpu==2.7.0) (0.2.0)
       > Requirement already satisfied: tensorboard~=2.6 in /nix/store/dxp7ngvslkphr97sg0zcyqcaygaq3s4p-python3.9-tensorboard-2.8.0/lib/python3.9/site-packages (from tensorflow-cpu==2.7.0) (2.8.0)
       > Requirement already satisfied: wrapt>=1.11.0 in /nix/store/27iwg8hcbjz8bdcxgi67dxj34sm6qsbg-python3.9-wrapt-1.13.3/lib/python3.9/site-packages (from tensorflow-cpu==2.7.0) (1.13.3)
       > Requirement already satisfied: absl-py>=0.4.0 in /nix/store/c9kzqwc42dknf89dmayp6ffqcxifv2v7-python3.9-absl-py-1.0.0/lib/python3.9/site-packages (from tensorflow-cpu==2.7.0) (1.0.0)
       > Requirement already satisfied: h5py>=2.9.0 in /nix/store/9sk9zcb96j6s5r5w6l4bc1y9s113ncx1-python3.9-h5py-3.6.0/lib/python3.9/site-packages (from tensorflow-cpu==2.7.0) (3.6.0)
       > ERROR: Could not find a version that satisfies the requirement tensorflow-estimator<2.8,~=2.7.0rc0 (from tensorflow-cpu) (from versions: none)
       > ERROR: No matching distribution found for tensorflow-estimator<2.8,~=2.7.0rc0
       >
       For full logs, run 'nix log /nix/store/7ywkprr9hr5vm7i925hbx2f41acvg44l-python3.9-tensorflow-2.7.0.drv'.

full build log
python3Packages.tensorflow-bin maintainers cc: @jyp @abbradar @cdepillabout
python39Packages.tensorflow maintainers cc: @jyp @abbradar
Other cc: n/a
Steps to reproduce

Checkout nixpkgs at commit 6140c314d5850406dddc78e55dcc8716ea111ee4
Run nix-build -A python39Packages.tensorflow

Technical details
 - system: `"x86_64-linux"`
 - host os: `Linux 5.13.0-1021-azure, Ubuntu, 20.04.4 LTS (Focal Fossa), nobuild`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.7.0`
 - nixpkgs: `/nix/store/79wp9dq2ph86bv75xaqmf891y9x5dhdq-source`

Misc.
This issue was automatically generated by nixpkgs-upkeep.

CI workflow that created this issue.
Internal tag:<PHONE_NUMBER>397204354

Looks like this is just the same tensorflow-bin issue as before.
I updated nixpkgs-upkeep to try to report on the actual package that is broken, and not on things in its reverse transitive dependency closure that are broken as a result. Unfortunately bc the nix store paths for tensorflow and tensorflow-bin look the same (have the same pname) it gives a slightly weird result in this case... I'll have to think if there's something that can be done to clean this up...

dup of https://github.com/NixOS/nixpkgs/issues/167442


tableau extension - getFilter/sAsync call returns error on real dashboards

tableau extension - getFilter/sAsync call returns Error:internal-error:Enum mapping not found for:undefined
I used the concepts in Filtering sample to monitor the state of several filters in a dashboard
and set value of a parameter based on the selections made by user for these filters.
On changing the value in any of the monitored filters, the filter change handler function gets triggered correctly. The subsequent logic gets the filter states, sets the parameter as expected and everything works as expected as long as the dashboard has limited content.
Once I load additional worksheets on there, desktop takes more time to run all the queries and starts bringing up the 'Computing visualization..' dialog after changes to filter values. Then, the call to either getFilterAsync (to get value of the specific filter) or getFiltersAsync (to get value of all sheet filters) from the filter change event handler function results in 'Error:internal-error:Enum mapping not found for:undefined' if the 'Computing visualization...' dialog box is still present. Tableau desktop also throws 'Unable to complete action' error box at this point.
(I haven't been able to test this on tableau server yet)
I tried putting the function on 10 second delay to give desktop the time to fetch data & close the 'Computing...' screen. This works as long as desktop is done in that 10s time. Also tried putting the function in a recursive time wait loop (for max of 10 calls) on hitting error. This also works as long as I close the 'Unable to complete action' pop ups.
However, both these workarounds are not satisfactory as it stands in way of getting a refreshed screen to user in the minimum amount of time.
Raised this issue in tableau support site; was told that tableau supports only the standard examples and that issues with custom usage should be raised on github. Ahead of posting here, I also tried with the standard filtering sample provided with the extensions bundle. Same issue exists there too. It works as long as the dashboard has minimal content. On any busy dashboard with more sheets and filters, the standard sample also hits the same issue. (Have replied on my original case with this info as well)
Something's got to change - Either these APIs should be able to work regardless of the state of tableau desktop or the triggering of the filter change handler function should be delayed till desktop is able to handle subsequent actions.
Please address at the earliest as this is a major blocker in using the power of tableau extensions. Thanks.
Regards,
Arun Santhosh

Hi John,
Appreciate the quick response.
Absolutely! You just made my day!
I'm in process of getting my scripts whitelisted by server admins
and have several corporate hurdles to tackle for the same.
Hope to test this out on server by next week.
Meanwhile, with your positive response, I can now ignore this error and proceed with further customization on desktop.
Thanks again..
I will watch for further updates so that I can pull latest extensions js / desktop version with the fix once available.
Regards,
Arun Santhosh


Need for requirements.txt

I can add requirements.txt file to make the setup and installation of the project easier.
(This issue is a follow up for the previously closed PR, kindly assign me this.)

yes it requires 3 packages to be installed, If you could assign me this issue I could work on it!


Add Ledger support

Hi guys,
Is it planned / would it be possible to add Ledger support?
Thanks!
Andrew

Hi, @andrewpaulicek !
Yes, it's possible and planned! 🙂
It will be ready this month.

Great news! Thanks @serh11p !

i think this can now be closed


ld: library not found for -lmysqlclient for architecture x86_64

$ swift build
Fetching https://github.com/IBM-Swift/Kitura.git
Fetching https://github.com/IBM-Swift/HeliumLogger.git
Fetching https://github.com/IBM-Swift/Swift-Kuery.git
Fetching https://github.com/IBM-Swift/Kitura-Request.git
Fetching https://github.com/IBM-Swift/SwiftKueryMySQL.git
Fetching https://github.com/IBM-Swift/Kitura-net.git
Fetching https://github.com/IBM-Swift/SwiftyJSON.git
Fetching https://github.com/IBM-Swift/Kitura-TemplateEngine.git
Fetching https://github.com/IBM-Swift/LoggerAPI.git
Fetching https://github.com/IBM-Swift/BlueSocket.git
Fetching https://github.com/IBM-Swift/CCurl.git
Fetching https://github.com/IBM-Swift/BlueSSLService.git
Fetching https://github.com/IBM-Swift/CMySQL.git
Cloning https://github.com/IBM-Swift/Swift-Kuery.git
Resolving https://github.com/IBM-Swift/Swift-Kuery.git at 0.13.3
Cloning https://github.com/IBM-Swift/Kitura-TemplateEngine.git
Resolving https://github.com/IBM-Swift/Kitura-TemplateEngine.git at 1.7.2
Cloning https://github.com/IBM-Swift/Kitura.git
Resolving https://github.com/IBM-Swift/Kitura.git at 1.7.9
Cloning https://github.com/IBM-Swift/CMySQL.git
Resolving https://github.com/IBM-Swift/CMySQL.git at 0.1.2
Cloning https://github.com/IBM-Swift/Kitura-net.git
Resolving https://github.com/IBM-Swift/Kitura-net.git at 1.7.16
Cloning https://github.com/IBM-Swift/CCurl.git
Resolving https://github.com/IBM-Swift/CCurl.git at 0.4.1
Cloning https://github.com/IBM-Swift/BlueSocket.git
Resolving https://github.com/IBM-Swift/BlueSocket.git at 0.12.68
Cloning https://github.com/IBM-Swift/LoggerAPI.git
Resolving https://github.com/IBM-Swift/LoggerAPI.git at 1.7.1
Cloning https://github.com/IBM-Swift/Kitura-Request.git
Resolving https://github.com/IBM-Swift/Kitura-Request.git at 0.8.2
Cloning https://github.com/IBM-Swift/SwiftKueryMySQL.git
Resolving https://github.com/IBM-Swift/SwiftKueryMySQL.git at 0.13.2
Cloning https://github.com/IBM-Swift/BlueSSLService.git
Resolving https://github.com/IBM-Swift/BlueSSLService.git at 0.12.55
Cloning https://github.com/IBM-Swift/HeliumLogger.git
Resolving https://github.com/IBM-Swift/HeliumLogger.git at 1.7.1
Cloning https://github.com/IBM-Swift/SwiftyJSON.git
Resolving https://github.com/IBM-Swift/SwiftyJSON.git at 17.0.0
Compile Swift Module 'Socket' (3 sources)
Compile Swift Module 'LoggerAPI' (1 sources)
Compile Swift Module 'SwiftKuery' (48 sources)
Compile Swift Module 'SwiftyJSON' (2 sources)
Compile Swift Module 'KituraTemplateEngine' (1 sources)
Compile Swift Module 'HeliumLogger' (2 sources)
Compile Swift Module 'SSLService' (1 sources)
Compile Swift Module 'SwiftKueryMySQL' (4 sources)
Compile CHTTPParser utils.c
Compile CHTTPParser http_parser.c
Linking CHTTPParser
Compile Swift Module 'KituraNet' (36 sources)
Compile Swift Module 'KituraRequest' (14 sources)
Compile Swift Module 'Kitura' (44 sources)
Compile Swift Module 'mustuserver' (1 sources)
Linking ./.build/debug/mustuserver
ld: library not found for -lmysqlclient for architecture x86_64
<unknown>:0: error: link command failed with exit code 1 (use -v to see invocation)
<unknown>:0: error: build had 1 command failures
error: exit(1): /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/swift-build-tool -f /Users/molly/mustuservermac/.build/debug.yaml

Similar to https://github.com/IBM-Swift/Kitura-CredentialsHTTP/issues/3

Did you see and follow the instructions on https://github.com/IBM-Swift/SwiftKueryMySQL#install-mysql?
That is: if you are on macOS, did you install mysql with brew install mysql and did you try compiling with swift build -Xlinker -L/usr/local/lib?
If not, and these instructions are not applicable to you (or they don't work for you) can you give more details of your platform, how/where you installed the mysql libraries and your Package.swift.
Thanks

Closing this as no response. Please reopen if necessary - thanks!


SET UP - MAIN MENU - organise a number system menu

could maybe look like this??
TO BE DISCUSSED
WELCOME
What would you like to see?
Please type a number from the following menu
1 The population of the world.
2 The population of a continent.
3 The population of a region.
4 The population of a country.
5 The population of a district.
6 The population of a city.
Please enter a number:
You selected 1 to view the population of the world.
How would you like the population to be arranged by?
1 By Country.
2 By Region.
3 By Continent.
4 By District.
5 By City.

You Selected 1 to view population By Country.
How would you like to view By Continent?
1 Smallest to Largest
2 Largest to Smallest
These will each lead on to their own menu

Menu looks good, captures the necessary information as laid out in our backlog

Looking good to me - just not sure whether we need to ask the last question - it seems that by default all reports should  display  results by largest population to smallest in which case this would be an additional feature not really requested by the customer...but then again you're the product owner ;)


Add guardian DFKs to Node, Preprint, and OSFGroup models

Purpose

Make django-guardian more performant.

Changes

Add DFKs to Node, Preprint, and OSFGroup models per https://django-guardian.readthedocs.io/en/stable/userguide/performance.html#direct-foreign-keys

Update SQL queries

Reference osf_nodegroupobjectpermission (and it's content_object_id field) instead of guardian_groupobjectpermission (and object_pk).
Remove content_type checks (no longer needed since DFKs replace GFKs)

@pattisdr, ready for review!


fix: update title length for notification_template table

Issue
https://gravitee.atlassian.net/browse/APIM-2136

📚  View the storybook of this branch here

@kamiiiel Can you rework this PR to target 3.19? as 3.18 is not supported anymore


Add QLPlayground v1.0

If the plugin is clearly called (by yourself, even) qlplayground, why are you giving the cask a different name?
A strict token reference must be followed, to avoid duplicates.
Since there is already a cask with this name, this one needs special naming. Call it inloop-qlplayground please squash your commits?

Sorry, first timer here. Should be correct now.

Many thanks for the tips. 👍

And what about the sha256 checksum? It won't be valid with the next version, or not?

I have replaced the sha256 checksum with :no_check

@jakubPetrik No, please don't remove the checksum. We only use :no_check in one of two cases: when the URL is not versioned (in which case we also use version :latest), and when the file is updated in-place despite having a versioned URL.
Neither of those appear to be the case here, so we need the checksum.

ok. will revert.

Thank you for the contribution. It was merged directly as 628cfe49a3dfc5f5e2a3fe8f2b8037b8c704d7a5 to keep commit history cleaner. Your contribution is still credited to you.


Allow commas in unquoted string + empty map

Hi Jakub,
thanks for the lib.
I found two minor issues with the libraries:

, is a valid character for unquoted string, except in flow

From: https://yaml.org/spec/1.2.2/#733-plain-style
inside flow collections, plain scalars must not contain the “[”, “]”, “{”, “}” and “,” characters.
To handle this the tokenizer need to tracks if it's within a flow or not.

{} is a valid map.

I can split the PR in two if you prefer, but also the two commits are easy to review independently.

@kubkon sorry, I forgot about this PR, I answered your question

I think there's also a problem when parsing unquoted strings containing colon.

@lunjon  do you mean a problem in this branch or on main ?

@kubkon sorry, I forgot about this PR, I answered your question

I think there's also a problem when parsing unquoted strings containing colon.

@lunjon  do you mean a problem in this branch or on main ?

In main, and I believe the issue could be related to the issue this PR fixes.

@lunjon it's not directly related, you can see previous PR #27 or my own more complete implem gwenzek#1

Oh I see. Is there any plans to integrate these changes to main anytime soon?


Please add arm64

Needed to implemnt arch64

@chaudharimanav looking into the matter arm is not based by any specific arch based but its a wholesome thus needed to compile for each and every arm hardware so currently pushing by x86 only will add this in future.


Missing parent: GO:0036336 dendritic cell migration

GO term ID and label for which you request a new superclass
GO:0036336 dendritic cell migration

New superclass (parent) suggested
GO:0072676 lymphocyte migration

The above two are siblings of the parent: GO:0071674 mononuclear cell migration

Reference(s), if appropriate
The following relation currently exists in GO.
GO:0044565 dendritic cell proliferation
is_a
GO:0046651 lymphocyte proliferation

It seems to me that dendritic cell is NOT a sub-type of lymphocyte (B, T, and NK cell), and thus the IS_A relationship between dendritic cell proliferation and lymphocyte proliferation should be REMOVED.
Ref: https://www.onlinebiologynotes.com/cells-immune-system-lymphocytes-phagocytic-cell-granulocytes-dendritic-cells/
@rashmie What do you think? Thanks.

Hi Raymond,
You are correct.  Dendritic cells are not a type of lymphocyte, and the is_a relationship between 'dendritic cell proliferation' and 'lymphocyte proliferation' should be removed.  The appropriate parent for 'dendritic cell proliferation' is 'mononuclear cell proliferation'.
The current parent of 'dendritic cell migration', 'mononuclear cell migration', is the correct parent and should not be changed.
-- Alex

Yes, the relationship to mononuclear cell migration is automatically inferred and will be kept. Thanks. @addiehl

@rashmie If it's OK with you, we can close this ticket. Thanks.

@raymond91125 and @addiehl Thanks for looking into this. I will close this now.


chore: add Neetcode in Competitive Programming category

Fixes Issue
Fixes #1918
Changes proposed
I have added the Neetcode youtube channel into the database of the Competitive Programming category and validated the JSON too.
Screenshots

@rupali-codes I'm really sorry for the mistake, I have rectified my mistake, kindly check it once.

@CBID2
Please review.


Remove description from both carousels and increase delay

I wanted to walk through the new process (not that new) for making a new change to the site so i can tough on the main parts:

Normally, new changes should have an 'issue' (task/todo) which generally maps to a git branch representing that issue
Make sure Netlify drawer works for comments and screen shots etc. and can authenticate between GitHub and Netlify
Review the new site folder structure (not that different, just way better organized now).


plz change to -h

https://github.com/adafruit/Adafruit-Pi-Finder/blob/master/pi_finder/src/ssh.js#L90
add -h for total halt plz so LED will blink n stuff.

added in v1.2.2-beta

it will be nice when the auto-update feature is finished so these releases are applied without having to re-download the giant atom-shell wrapper

fixed by f71fd38a08d071a5679a60d837e74f5d2822ecc4


feat(helm): Add service to chart and prometheus examples

The goal of this PR is to add the ability to enable a service for metacontroller via helm and provide examples of how to consume prometheus metrics.

I added two flags prometheus.serviceEnabled and prometheus.serviceMonitorEnabled to allow the user to enable them independently to avoid coupling the implementation to prometheus operator. Ready for review again 👍

hi @mjsmith1028 , thanks for PR. I think that Service should be delivered on flag, without referring specifically to prometheus (Service is regular k8s object).
Also, I would not see ServiceMonitor (external CRD) into this helm chart. Usually ops define some generic ServiceMonitor which pick up Services by labels

hi @mjsmith1028 , thanks for PR. I think that Service should be delivered on flag, without referring specifically to prometheus (Service is regular k8s object).
Also, I would not see ServiceMonitor (external CRD) into this helm chart. Usually ops define some generic ServiceMonitor which pick up Services by labels

HI @grzesuav gotcha. I can update this PR to only include Service into metacontroller's helm chart and decouple the prometheus/servicemonitor responsibility.

Hi @grzesuav , I have refactored the PR. Now, it is just to enable a Service for metacontroller. I updated the examples to show how one would use the service for prometheus metrics.
The failing Test / Release /Tests is due to flakiness. I was able to run it successfully locally. I have updated https://github.com/metacontroller/metacontroller/issues/509 with additional details regarding the flakiness.
Please let me know if this PR looks okay to you.

Also, added fix for integration test flakiness: https://github.com/metacontroller/metacontroller/pull/531/files#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52R36
This will run the tests sequentially to avoid to conflict between compositecontroller and decoratorcontroller tests.

:tada: This PR is included in version 4.2.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


reconnecting a player fails

Monitor.stop_all()
world.add_player("TransformerScorn")
no errors but sign monitoring is not restored

fixed in 84cb4c5fa8bf16de7531d7fa6f531cf8e4fe7c8f


[SPARK-16568][SQL][Documentation] update sql programming guide refreshTable API in python code

What changes were proposed in this pull request?
update refreshTable API in python code.
How was this patch tested?
N/A

Test build #62371 has started for PR 14220 at commit e772034.

Test build #62371 has finished for PR 14220 at commit e772034.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62371/
Test PASSed.

cc @liancheng Thanks!

cc @rxin Thanks!

Merging in master/2.0.


Pass state (opens/closes) as parameter to onChange callback function

My use case:
An AccordionItemBody contains an <input type="text">. Whenever this particular AccordionItem is opened the input field should be focussed automatically.
Possible solutions: (that I can think of)

In terms of programming economics I'd find it best if AccordionItem would also have a onChange event.
In any case the "global" onChange should pass whether the item is going to be opened or closed as a second function parameter (not just the UUID).

Any updates on this? onChange of input is not working.


Not validating minItem for enum

I have the following schema definition
        "user": {
            "title": "User",
            "type": "object",
            "additionalProperties": false,
            "properties": {
                "pNumber": {
                    "type": "string",
                    "minLength": 3,
                    "maxLength": 30
                },
                "org": {
                    "type": "string",
                    "minLength": 3,
                    "maxLength": 30
                },
                "enabled": {
                    "type": "boolean"
                },
                "userRoles": {
                    "type": "array",
                    "uniqueItems": true,
                    "minItems": 1,
                    "maxItems": 7,
                    "items": {
                        "type": "string",
                        "enum": [
                         "admin",
                        "orgadmin",
                        "superadmin",
                        "publisher",
                        "consumer"
                        ]
                    }
                }
            },
            "required": [
                "pNumber",
                "org"
            ],
            "example": {
                "pNumber": "Excepteur amet dolore elit au",
                "org": "anim ad",
                "enabled": true,
                "useRoles": [
                          "admin",
                        "orgadmin",
                        "superadmin",
                        "publisher",
                        "consumer"
                ]
            }
        },
        "users": {
            "title": "Users",
            "type": "array",
            "items": {
                "$ref": "#/definitions/user"
            },
            "example": [
                {
                    "pNumber": "proiden",
                    "org": "nisi"
                },
                {
                    "pNumber": "dolor qui",
                    "org": "cupidatat",
                    "userRoles": [
                        "admin",
                        "orgadmin",
                        "superadmin",
                        "publisher",
                        "consumer"
                    ],
                    "enabled": false
                },
                {
                    "pNumber": "occaecat in dolore ad",
                    "org": "ex cons",
                    "enabled": true,
                    "userRoles": [
                            "admin",
                        "orgadmin",
                        "superadmin",
                        "publisher",
                        "consumer"
                    ]
                },
                {
                    "pNumber": "tempor sed deserun",
                    "org": "labore Excepteur eiusmod qui e",
                    "userRoles": [
                         "admin",
                        "orgadmin",
                        "superadmin",
                        "publisher",
                        "consumer"
                    ]
                },
                {
                    "pNumber": "id v",
                    "org": "dolor q",
                    "userRoles": [
                         "admin",
                        "orgadmin",
                        "superadmin",
                        "publisher",
                        "consumer"
                    ]
                }
            ]
        }
    }

userRoles in an enum with minItems=1. The following should not validate as no values are present in userRoles.
{
"pNumber": generated_pNumber.toString(),
"org": "ese",
"enabled": true,
"userRoles": [
]
}
However this passes validation which is not correct behaviour

We do not currently validate against the minItems or maxItems of an array.  I'll look at how we can add that.

Hi @brodyd , can you please push this for 2.x as well?

3.0.4 is completely compatible with 2.x so you could update it.

I will test this today with 3.0.4.

Swagger 2.0 is working with all my test cases for version 3.0.4

Excellent!  I'll update the readme so it is clearer


Source 2 support

Please describe your feature
Is CS2 Supported?
(https://www.youtube.com/watch?v=zVfN6pVfmGM&ab_channel=CSGOClipsandMoments)
(Optional): Suggest a solution

Hey,
I want to mention that I currently don't have access to the CS2 beta, which is why I couldn't take a closer look. However, even if SourceMod becomes available for CS2 in the future, I think it's unlikely to work out of the box without some additional work.
At the moment, I'm unable to commit to a redevelopment as I'm unsure about my availability. Therefore, I cannot guarantee if I'll have the time to address this.
If anyone discovers any information about CS2 server modding, please feel free to share it here.

Has there been any update on the matter?

Unfortunately, as previously mentioned, I don't have any time left in my free time to start developing a source 2 version of this plugin.
Feel free to start developing it yourself. Maybe If sourcemod comes for cs2 it will become easy to update it but I didn't do any research about that.
Good Luck!

Unfortunately, as previously mentioned, I don't have any time left in my free time to start developing a source 2 version of this plugin.
Feel free to start developing it yourself. Maybe If sourcemod comes for cs2 it will become easy to update it but I didn't do any research about that.
Good Luck!

Thanks for the original mod though!

Unfortunately, as previously mentioned, I don't have any time left in my free time to start developing a source 2 version of this plugin.
Feel free to start developing it yourself. Maybe If sourcemod comes for cs2 it will become easy to update it but I didn't do any research about that.
Good Luck!

we all need it


Add template name guesser service

This change would help @schmittjoh's override of template name guessing in JMSDiExtraBundle  to be implemented in a way that does not disrupt FOSRestBundle as described in schmittjoh/JMSDiExtraBundle#14.

I implemented your suggestions. And added the changes to existing files I somehow managed to not-commit before.

This template guesser is used nowhere so it seems like part of your patch is missing


CI: Add site build step for PRs

As we are now specifying links with {% link ... %} Jekyll tags, which fail the site build if the link is incorrect, it makes sense to actually check these for PRs. This will prevent broken internal links to be merged in the repository and will save time in the long run.

We already build the site in pr ci?
https://github.com/szarnyasg/duckdb-web/blob/add-pr-site-build-step/.github/workflows/jekyll.yml#L58

We didn't do this for PRs. PRs only had two checks (linter), and did not attempt to build the site. See e.g. this PR yesterday: https://github.com/duckdb/duckdb-web/pull/3186


GSLUX-620: Traductions manquantes pour les layers

JIRA issue
https://jira.camptocamp.com/browse/GSLUX-620
Description
Translation files (for all lang) need an update.
Some translations are missing, especially for new layers, see image below:

Done:

[x] Updated all client.json (x4)
[x] Fix i18n key for layer panel title ("layers" instead of "Layers")
[x] Added <h1> for accessibility
[x] Fix missing translation when bg layer is blank in prod mode build for lib (in dev, empty translation - eg. "My translation": "" - is replaced by the key, in prod, empty translation is kept)

the PR breaks the V4 demo app, the themes fixture does not seem to be in line with the translations.


Added Russian translate for Prismarine Web Client (Not the best but how i see nobody did it here before)

Oof i'm sorry just my mouse is laggy, i didnt want to do it

Apologies for the delayed response time. We're still trying to decide whether translations are necessary. I'll get back to you once we make a decision.

Apologies for the delayed response time. We're still trying to decide whether translations are necessary. I'll get back to you once we make a decision.

Okay


[CS2113-T13-1]-sinteary-AddMemberFunctionality

Add Member and MemberList classes to track members in each project.

Ability to manage and add members to a project.

Ability to view all members details.

Ability to exit project to manage another one.

Resolve #89 #88 #87


ReceiveMiddleware in Future

@rogeralsing
Hey Roger, this PR is to allow Future received message be handled in relative middleware as well.
However the FutureContext and FutureActor seems a bit bulky, I didn't come up any nice way to handle that. Good thing is that it should have no perf impact = )
What's your opinion?

I'll have a look.
I just realized that there might be implications of doing this.
e.g. if you have a middleware that is very specific for your actor, e.g. holds some state or does any other per instance related things.


helmfile errors on valid yaml for vault configuration property:externalConfig.policies.rules

From vault chart documentation to show official documentation about the format of the policy:
https://github.com/banzaicloud/bank-vaults/blob/master/charts/vault/values.yaml
(note that the link above is an example to the way the property is formatted. We use the vault operator, so what I'm actually attempting to do is decrypt a configuration manifest which uses the exact same property.)
example yaml:
 0: releases:
 1:   - name: vault-operator
 2:     namespace: vault
 3:     createNamespace: true
 4:     labels:
 5:       app: vault-operator
 6:     chart: banzaicloud-stable/vault-operator
...
...
 56:         externalConfig:
 57:             policies:
 58:             -   name: allow_secrets
 59:                 rules: 'path "secret/*" { capabilities = ["create", "read", "update", "delete", "list"] }'. <<== fails
 60:             auth:
 61:            -   type: kubernetes
...
...

Causes the error (during template; not tested with any other functionality)
err: failed to read helmfile.yaml: reading document at index 1: yaml: line 68: did not find expected ',' or ']'
in ./helmfile.yaml: failed to read helmfile.yaml: reading document at index 1: yaml: line 68: did not find expected ',' or ']'

Noteworthy: in this setup, the file containing this is a secrets.yaml file getting decrypted by SOPS (helm secrets). To test, I removed that property from the file and was able to successfully template the project. When I returned that property back to the file, helmfile barfed again.
The manifest is valid yaml (yamllint passes it) but helmfile fails on it.

@notjames Hey! Sorry but this looks too vague to be investigated. At glance this is just a error in your values so there should be no helmfile fault. Can you give me a simple helmfile.yaml that ideally has only one release (bank-vaults?) that can reproduce the issue?

@mumoshu I've updated the comment. Hopefully it makes better sense.

Sorry but no. That basically says your values is incorrect. But I cant verify that as you have no example for reproduction..

vaultconfig: |-
    kind: Vault
      name: vault
      namespace: vault
    spec:
      size: 3
      image: vault:1.6.0
      bankVaultsImage: banzaicloud/bank-vaults:latest
      vaultPodSpec:
          priorityClassName: system-node-critical
      serviceAccount: vault
      serviceType: ClusterIP
      volumeClaimTemplates:
      -   metadata:
              name: vault-raft
          spec:
              storageClassName: persistent
              accessModes:
              - ReadWriteOnce
              volumeMode: Filesystem
              resources:
                  requests:
                      storage: 1Gi
      volumeMounts:
      -   name: vault-raft
          mountPath: /vault/file
      veleroEnabled: true
      caNamespaces:
      - '*'
      unsealConfig:
          options:
              preFlightChecks: true
          kubernetes:
              secretnamespace: vault
      config:
          storage:
              raft:
                  path: /vault/file
          listener:
              tcp:
                  address: <IP_ADDRESS>:8200
                  tls_cert_file: /vault/tls/server.crt
                  tls_key_file: /vault/tls/server.key
          api_addr: https://vault.vault.svc.cluster.local:8200
          cluster_addr: https://vault:8201
          ui: true
      statsdDisabled: true
      resources:
          vault:
              limits:
                  cpu: 2
                  memory: 1Gi
              requests:
                  cpu: 1
                  memory: 512Mi
      externalConfig:
          policies:
          -   name: allow_secrets
              rules: 'path "secret/*" { capabilities = ["create", "read", "update", "delete", "list"] }'
          auth:
         -   type: kubernetes
              roles:
              -   name: default
                  bound_service_account_names:
         secrets:
          -   path: secret
              type: kv
              description: General secrets.
              options:
                  version: 2
      vaultEnvsConfig:
      -   name: VAULT_LOG_LEVEL
          value: debug
      labels:
          app: vault

There's an example...

What's vaultconfig?  Why isn't externalConfig under thevault key as the default values file, but spec in your example?

Sorry, but this shouldn't really be discussed in GitHub issue. Let's use Slack and ask for the community for this kind of general guidance on how to use helm and helmfile.

Well anyway, the yaml snippet you pointed does look like a valid yaml. You can verify that with e.g.
releases:
- name: myapp
  chart: incubator/raw
  values:
  - externalConfig:
        policies:
        -   name: allow_secrets
            rules: 'path "secret/*" { capabilities = ["create", "read", "update", "delete", "list"] }'

and seeing it doesn't fail while parsing yaml. So you're very likely messed up with environment values or go template.
That's why I'm asking for a whole example for reproduction.

helmfile.yaml
values:
- values.yaml

---

releases:
 - name: vault-operator
   namespace: vault
   createNamespace: true
   labels:
     app: vault-operator
   chart: banzaicloud-stable/vault-operator
   values:
   - {{ .Values.vaultconfig | nindent 4 }}

values.yaml
vaultconfig: |-
    kind: Vault
    name: vault
    namespace: vault
    spec:
      size: 3
      image: vault:1.6.0
      bankVaultsImage: banzaicloud/bank-vaults:latest
      vaultPodSpec:
          priorityClassName: system-node-critical
      serviceAccount: vault
      serviceType: ClusterIP
      volumeClaimTemplates:
      -   metadata:
              name: vault-raft
          spec:
              storageClassName: persistent
              accessModes:
              - ReadWriteOnce
              volumeMode: Filesystem
              resources:
                  requests:
                      storage: 1Gi
      volumeMounts:
      -   name: vault-raft
          mountPath: /vault/file
      veleroEnabled: true
      caNamespaces:
      - '*'
      unsealConfig:
          options:
              preFlightChecks: true
          kubernetes:
              secretnamespace: vault
      config:
          storage:
              raft:
                  path: /vault/file
          listener:
              tcp:
                  address: <IP_ADDRESS>:8200
                  tls_cert_file: /vault/tls/server.crt
                  tls_key_file: /vault/tls/server.key
          api_addr: https://vault.vault.svc.cluster.local:8200
          cluster_addr: https://vault:8201
          ui: true
      statsdDisabled: true
      resources:
          vault:
              limits:
                  cpu: 2
                  memory: 1Gi
              requests:
                  cpu: 1
                  memory: 512Mi
      externalConfig:
          policies:
          -   name: allow_secrets
              rules: 'path "secret/*" { capabilities = ["create", "read", "update", "delete", "list"] }'
          auth:
          -   type: kubernetes
              roles:
              -   name: default
                  bound_service_account_names:
          secrets:
          -   path: secret
              type: kv
              description: General secrets.
              options:
                  version: 2
      vaultEnvsConfig:
      -   name: VAULT_LOG_LEVEL
          value: debug
      labels:
          app: vault

I've fixed several yaml errors in the yaml embedded vaultconfig in the yaml data you've shared, assuming it's a helmfile values file.
helmfile template runs successfully now. Is this what you tried/wanted?

for posterity sake, the problem with this was (but wasn't) the cr manifest. It was a lack of understanding about how helmfile processes the event hooks. The args property is supposed to be valid yaml. The documentation lost me on this point as the documentation uses traditional list syntax, which got my mind into programming mode a la system(cmd, [arg1,arg2, argn]) not yaml. Moreover, when helmfile processes the releases, it will process the entire releases object into a single yaml object (it seems). I was trying to use {{ .Values...}} as a gotmpl in my args and helmfile was transliterating it.
So, the primary fix was to use a gotmpl comment: {{ {{ .Values...}} }} in the args directive.


Update Badge number on Android

Hi, can I change the badge# on Android, I tried to pass the badge attribute but in the notification but nothing happened.

Also the notifications sent to the same device are getting overwritten instead of showing two or more notifications it only shows the last notification sent.

Hi @raysango I'm not 100% sure how to set the badge on Android devices, and, having a quick Google search on it, it looks like it is something the developer has to manage, check, for example, this SO thread.
Also, by having a look at the possible parameters to be sent to Android devices, it looks like the badge is an iOS only thing.
Finally, this gem internally uses ruby-push-notifications gem, and the android payload is actually composed here should you want to try modifying it a little bit for testing purposes.
Hope it helps.

Closing issue as stale. Please reopen if necessary