Text and arguments fields in the Settings UI are unreadable

The theme is causing black text on dark grey background in the settings menu, meaning you can only read the text by highlighting it.
Sublime VSCode theme

Builtin Monokai theme

There is a similar issue with highlighting in the argument array style settings fields, where you can add multiple arguments with the 'Add Item' button.

@ross-g Thanks for reporting!
I've managed to fix the contrast in the text and number fields (just published in v1.2.2). The "argument array" fields, however, are still broken when hovered. I'm looking into it, but it doesn't seem fixable at the moment.
If you encounter other problems relating to contrast, please report it in #1.


Adding restriction for Function App.

Cloning is not available for Function Apps.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: daf14087-1765-4636-805c-6faec03d8a9b
Version Independent ID: 4a6b910d-403e-997a-b010-0942e8ef624c
Content: Clone app with PowerShell - Azure App Service
Content Source: articles/app-service/app-service-web-app-cloning.md
Service: app-service
GitHub Login: @cephalin
Microsoft Alias: cephalin

Hi @hepiet,  thanks for your feedback! We will review and update this doc accordingly.

I have submitted a PR to update the doc, the change is merged internally and will go-live in the public docs shortly.


How to require use to update exact size

How I can set the exact size of the image that allow people to upload?
Also, here is my code, and the min and max is not working. I upload image exact 1400 and 630 and it return error of minWidth. I need to set the min to 1000 then that work. Very strange. Same as height, I can not set min to a set number like 630. I keep trying and only min 400 works. But all the max is not working. so like ngf-validate="{width: {min: 1000, max:2000}, height: {min: 400, max: 900}}", an image large than 2000 (like 3840) will allow upload.
<input id="pictures" label="Upload Images" name="pictures" ngf-select="admin.uploadFiles($files)" ng-model="pictures" accept="image/*" ngf-validate="{width: {min: 1400, max:2000}, height: {min: 630, max: 900}}" ngf-resize="{width: 1600, height: 720, quality: 1}"  ngf-keep="true" multiple>

                    Min Width has to be 1400.

                    Min height has to be 630.

It is working just fine for me.
Create a jsfiddle and attach the picture you are trying here.


feat: Updated Footer section bug

Title and Issue number

Title :Updated Footer section bug
Issue No. :837
Code Stack :
Lnguages:
HTML
CSS
JavaScript
Close #837

Description

Updated and improved the footer component and increased the orientation of Google translates Network Image and also improved the "Select Language" dropdown.
Video/Screenshots (mandatory)

Type of PR

[X] Bug fix
[X] Feature enhancement
[ ] Documentation update
[ ] Other (specify): _______________

Checklist:

[X] I have performed a self-review of my code.
[ ] I have commented my code, particularly in hard-to-understand areas.
[X] I have tested the changes thoroughly before submitting this pull request.
[X] I have provided relevant issue numbers, screenshots, and videos after making the changes.
[X] I have gone through the  contributing.md file before contributing

Additional context:

I have changed the size of google image and improved the footer section and also improved "Select Language" dropdown
##Are you contributing under any Open-source programme?

[X] I am contributing under GSSOC'24
[ ] I am contributing under VSOC'24

Okay sir

Done sir!

Done sir!

Don't call me Sir first of all .I  am Just a student
& secondly there is some recent changes in the footer section , so want to request you to please submit a new pR making a new branch that will help u to avoid the conflicts.


GEOMETRY-63: Various style issues

Fixes for various SonarQube and IDE warnings. Each commit refers to the kind of issue fix.

@darkma773r Let me know if any change is not consistent.


Fix JMEM_HEAP_END_OF_LIST for pointers larger than 32 bits

For 64 bit pointers, 0xffffffff as end-of-list marker pointer does
not work, as the marker is expected to be greater than the start
address of the heap area (and also max 0xffffffff away), but on 64
bit systems, the heap can start on higher addresses, i.e., above
0x100000000. This patch ensures that the marker is set correctly on
all systems.
JerryScript-DCO-1.0-Signed-off-by: Akos Kiss<EMAIL_ADDRESS>

Interestingly, this issue only appeared on OSX and did not occur on x64/Linux. When running ./build/bin/jerry tests/jerry/parser-oom.js, jerry crashed with the following message and stack trace:
ICE: Assertion 'jmem_is_heap_pointer (current_p)' failed at jerry-core/jmem/jmem-heap.c(jmem_heap_alloc_block_internal):242.
Error: ERR_FAILED_INTERNAL_ASSERTION

#0  jerry_fatal (code=ERR_FAILED_INTERNAL_ASSERTION)
    at jerry-core/jrt/jrt-fatals.c:37
#1  0x0000000100001eae in jerry_assert_fail (
    assertion=0x1000d666d "jmem_is_heap_pointer (current_p)",
    file=0x1000ce9bf "jerry-core/jmem/jmem-heap.c", function=0x1000d662a "jmem_heap_alloc_block_internal", line=242)
    at jerry-core/jrt/jrt-fatals.c:86
#2  0x00000001000ba9f6 in jmem_heap_alloc_block_internal (size=49168)
    at jerry-core/jmem/jmem-heap.c:242
#3  0x00000001000942c7 in jmem_heap_gc_and_alloc_block (size=49168,
    ret_null_on_error=true)
    at jerry-core/jmem/jmem-heap.c:346
#4  0x000000010009ee4a in jmem_heap_alloc_block_null_on_error (size=49168)
    at jerry-core/jmem/jmem-heap.c:408
#5  parser_malloc (context_p=0x7fff5fbfec30, size=49168)
    at jerry-core/parser/js/js-parser-mem.c:42

After instrumenting the loop of the slow path of jmem_heap_alloc_block_internal with printfs, I got the following output:
end_of_list	= 0xffffffff
current_p	= 0x104f06278
current_p	= 0x104f13fc0
current_p	= 0x104f7a340
current_p	= 0x1ffffffff

Clearly, we wanted to put the EOL marker into current_p just didn't succeed: heap was on high addresses, EOL address was lower, when the offset of the EOL was calculated (with JMEM_HEAP_GET_OFFSET_FROM_ADDR), it was truncated to 32 bits, and when it was transformed back to address again (with JMEM_HEAP_GET_ADDR_FROM_OFFSET`), it became different.

LGTM

I don't think this is the right approach. I think we should change
JMEM_HEAP_GET_OFFSET_FROM_ADDR (JMEM_HEAP_END_OF_LIST)

to
JMEM_HEAP_END_OF_LIST

There is one case where a few line needs to be changed as well.

patch updated according to the review (all CI jobs are green, OS X included!)

I like this much better, LGTM.


Can't stop animation

Hi!
I'm try play animation only once, but it doesn't work.
I try meany function, example:
armatureComponent.animation.GotoAndPlayByTime(dieAnimation, 0, 1); armatureComponent.animation.Play(dieAnimation, 1);
and etc.
armatureComponent is  private UnityArmatureComponent armatureComponent;

Sorry, my trouble in code


#224 - rearranging Vue tags

This should close #224.

@EwelinaLasowy, please resolve conflicts here.

@EwelinaLasowy, please resolve conflicts here.

In progress


Support cluster active health check

(This is used to request new product features, please visit https://discuss.istio.io for questions on using Istio)
Describe the feature request
We use envoy as router gateway，but istio  api does not support active health check configuration.
Is there any other way  to config active health check for upstream cluster.
Envoy upstream health check is https://www.envoyproxy.io/docs/envoy/latest/api-v3/config/core/v3/health_check.proto#envoy-v3-api-msg-config-core-v3-healthcheck-httphealthcheck
Describe alternatives you've considered
Is there any other way  to config active health check for upstream cluster.
Affected product area (please put an X in all that apply)
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[X ] User Experience
[ ] Developer Infrastructure
Affected features (please put an X in all that apply)
[ ] Multi Cluster
[X  ] Virtual Machine
[ ] Multi Control Plane

This is tracked at https://github.com/istio/istio/issues/10537 and you can find a EnvoyFilter example at https://github.com/istio/istio/issues/10537#issuecomment-555548652. You can track that issue instead and probably add your use case there if it is different from the ones mentioned.

Close as a dup for #10537 thanks!


Use svelte.config.js's extensions for plugin-svelte input

Changes
Uses svelte.config.js's extensions for plugin-svelte input if available (and not overridden by plugin config).  This will cut down on duplicated configuration.
Testing
I wasn't for certain how best to update the tests for this change.
Docs
Update input section of README

Can you share a link to where this is documented as correct in a svelte.config.js file? Does such docs even exist?
I'm +1 on this PR, but in the past we've been bitten by matching other plugins and then realizing that the Svelte team had a different recommended API/pattern.

There is no such doc nor recommendation inside of language-tools from what I can tell. Rollup plugin is the only thing I am aware of with an extensions field, webpack plugin uses a completely different method for finding svelte files and vscode requires changes via settings to support different extensions. I love standards, but I don't think this has even been on a path where standardization was an option up to this point

@FredKSchott  @firefish5000 When I look at the Webpack loader (https://github.com/sveltejs/svelte-loader#usage) I see it referencing extensions in the config, as well as in the mdsvex's docs.  I guess the main discussion is whether svelte.config.js having extensions is recommended.  I don't know if @Rich-Harris has any feedback.  It seems like you have to duplicate the input/extensions in both places if not, which seems prone to error.
fwiw, I was migrating to snowpack from svite and it had this convention.  I was actually baffled for a bit as to why my .svx files were not being handled by snowpack until I saw @firefish5000's PR.

Okay, I'm feeling good about this then! +1 to merging by EOD today or tomorrow, in case @Rich-Harris has any last minute thoughts

@techniq Note that webpack config only uses extensions for webpack's resolve, NOT for the svelte-loader which uses a test regex. Both must be configured for it to work. And while that sort of adds standard, webpack's resolve is for everything webpack can import, not just svelte stuff (as it is not a svelte project to begin with). So in practice webpack would need something like
const svelteExtensions = ['.svelte','.svx']
  ...
  resolve: {
    alias: {
      svelte: path.resolve('node_modules', 'svelte')
    },
    // Note this is not equivilent import the svelte rollup plugin as specifies all import statements webpack can resolve and is not svelte specific. Svelte is merely one of the things it can resolve
    extensions: ['.js','.ts','.css', ...svelteExtensions]
    mainFields: ['svelte', 'browser', 'module', 'main']
  },
  module: {
    rules: [
      ...
      {
        // This is the code for the svelte loader, it uses a regex. We could easily build this from the svelteExtensions, but its certainly not a direct relationship as this syntax is more powerful at the cost of being one of the causes for webpacks config hell
        test: /\.(html|svelte)$/,
        exclude: /node_modules/,
        use: 'svelte-loader'
      }
      ...
    ]
  }


reinstall is ignoring spec

Reinstall is just using the name as package name. But if the venv name is not usable (e.g. pipx install nonexistingpackage --spec "flake8==2.0.0") or if you installed a pinned version, this information is lost and reinstall is either not working (for the former) or is installing the wrong version (for the latter).
You should store spec information in a config file and use that on reinstall.

Oh, it's ignoring the base python as well. This should be in the config, too.

Fixed by #222.


python3Packages.sendgrid: 6.8.1 -> 6.8.2

Motivation for this change
Update to latest upstream release 6.8.2
Change log: https://github.com/sendgrid/sendgrid-python/releases/tag/6.8.2
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 139129 run on x86_64-linux 1

2 packages built:

python38Packages.sendgrid
python39Packages.sendgrid

Result of nixpkgs-review pr 139129 at b1ff8d9e run on aarch64-linux 1

2 packages built successfully:

python38Packages.sendgrid
python39Packages.sendgrid


Show used vscode version on code-server startup

I Would like to implament something to show the used vscode version for building on code-server startup

One idea would be to just run --version before starting code server. So if this was bash you could do something like:
version=$(code-server --version --format json | jq .vscodeVersion)
echo "VS Code version is $version"
code-server

so we should modify the CMD of the current image to code-server --version && code-server ? because the intent behind this is i just tested the one liner and was not sure if i will get v2 with latest.
I Think its essential to see on startup what version the docker image is running .

Essential?

@frank-dspeed Docker best practices is to use versioned tags. Our tags reflect our Docker deploys, hence we don't really need this implemented if you know what tag you used for deploying.

Closing this as wontfix. Just adhere to Docker best practices. If you don't like to do versioning, consider using latest instead.

@frank-dspeed yeah if you're just trying to find out what version the v2 or latest tags are running you could run the one-liner with the version flag to verify.
docker run --rm -it codercom/code-server:v2 --version

The VS Code version also appears in the Help > About menu in the IDE. Hope that helps. :hamburger:

so you all vote for not showing that on startup ? Ok as i now know what to do its ok for me thanks a lot.


Add separator to FieldList

As of right now there is no way of creating fully custom names and ids for nested forms that contain a field list since the FieldList contains a hardcoded separator. This PR adds the ability to set a custom separator for a FieldList similar to FormField.
This PR also fixes #681 and adds the relevant tests to verify the fix works.
For mixed separators (see test test_enclosed_subform_list_separator and test_enclosed_subform_mixed_separators) to work properly, the separator of the unbound field (in case it is a form field or another list) needs to be determined. For this we look into the kwargs used to construct the unbound field or default to -.

The implementation looks good so far, I added some comments to on the PR. Perhaps might be best to unify the two new attributes under the "separator" and drop the "field_separator". What do you think?

See my comment above, as far as I can tell there is no nice way of unifying those two in case of mixed separators.

Thank you for your contribution!


CE complete. Ready for SME.

Lab and LAK for Mod 12

LGTM
On Fri, Apr 13, 2018 at 10:26 VinayApposite<EMAIL_ADDRESS>wrote:

Lab and LAK for Mod 12
You can view, comment on, or merge this pull request online at:
https://github.com/MicrosoftLearning/20487-DevelopingWindowsAzureAndWebServices/pull/73
Commit Summary

CE complete. Ready for SME.

File Changes

M Instructions/20487C/20487C_MOD12_LAB_MANUAL.md
https://github.com/MicrosoftLearning/20487-DevelopingWindowsAzureAndWebServices/pull/73/files#diff-0
(41)
M Instructions/20487C/20487C_MOD12_LAK.md
https://github.com/MicrosoftLearning/20487-DevelopingWindowsAzureAndWebServices/pull/73/files#diff-1
(60)

Patch Links:

https://github.com/MicrosoftLearning/20487-DevelopingWindowsAzureAndWebServices/pull/73.patch
https://github.com/MicrosoftLearning/20487-DevelopingWindowsAzureAndWebServices/pull/73.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftLearning/20487-DevelopingWindowsAzureAndWebServices/pull/73,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABm3vYMDDq0C-DFddpBJOg3n5qXOGA-wks5toFMRgaJpZM4TS-Bu
.

--
Sasha Goldshtein | CTO, Sela Group | Microsoft C# MVP | blog.sashag.net |
@goldshtn http://twitter.com/goldshtn


Do not advertise TMP as "spec"

Page Affected: https://developers.google.com/web/tools/lighthouse/audits/first-meaningful-paint
What needs to be done?
TMP is called a Spec (with a link to a 2y old doc), which is can cause confusion.
TTI links to its Definition, which is a better wording. It might also be interesting to recommend/link First Contentful Paint for tracking it in the wild (similar to FID in TTI).

Looks like the "spec" wording has been fixed but have not yet linked to docs on how to track it in the wild.


major: Update dependencies and improve core logic

Update various dependencies, synchronize configuration files, and enhance the core logic of the application. The demo site has also been updated to reflect these changes.

Summary by CodeRabbit
Release Notes v2.0.0

New Features

Added OpenTelemetry integration for enhanced tracing
Introduced new Sentry SDK configuration options

Dependencies

Updated Sentry SDK to version 8.47.0
Updated SvelteKit peer dependency to version 2.x
Added OpenTelemetry instrumentation packages

Breaking Changes

Major version bump with potential API modifications
Updated import paths and type definitions
Removed some deprecated integration methods

Performance

Improved error handling and tracing capabilities
Enhanced serverless environment support

Chores

Updated multiple development dependencies
Streamlined SDK initialization process

@SocketSecurity ignore<EMAIL_ADDRESS>

@SocketSecurity ignore<EMAIL_ADDRESS>


Waterfall menu bottom row disappears when resizing

Problem:
When shrinking and then growing the window, the waterfall's bottom menu does not reappear if the user has scrolled between times.
Expected result:
When growing the window, the bottom row should always reappear once scrolled back to the top.
Steps to reproduce:

Visit http://getmdl.io/components/index.html#layout-section
Scroll down to "Waterfall header" sample
Shrink the window to < 1024px, but > 850px and scroll to the bottom of the Waterfall sample.
Grow the window to > 1024px again, and scroll to the top of the Waterfall sample: no bottom row with menu items will be visible.

Note: the issue doesn't seem to act quite the same way if you shrink below 850px.  When you do, the bottom bar can usually be restored in > 1024px by scrolling down to the bottom and back to the top.
Tested on:
Firefox 44 on Ubuntu 14.04
Chrome 48 on Ubuntu 14.04

Another interesting point I just discovered: if you double-click on the header's main "title" bar (with the title and search), the bottom row will with the menu items will magically reappear!

Nice catch, @listedegarde! I'll look into this.

Found while debugging: clicking the header seems to reset the incorrect behaviour, for some reason.

Found the issue. PR at #4064.

Awesome!  Thank you.

No worries, thank you for the clear bug description, @listedegarde! This has been merged into the mdl-1.1 branch and will be included in v1.1.1 when released.


opt add distribute specification to plan shape check and add distribute hint tests

Proposed changes
add test of distribute hint like [shuffle] or [broadcast] added to control join distribute strategy

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


Alternative for fish users

In several ways inspired by Bats too, but mostly as someone who favors and advocates for TAP, I wrote Fishtape to test fishshell scripts.
What about adding a note or link to the README for fish users?
@sstephenson @mislav

@bucaran What about adding alternatives for bats in Fishtape?

@pickfire What do you mean? Like bats, Fishtape is a TAP producer and test harness. Bats is cool and fish users that stumble upon this might wonder if there is something like that for fish.

@bucaran I mean add bats to the fishtape page so that people can refer to it probably.


Improvement/Suggestion: Better error handling

When working with collections, you need to verify the resolved response and look for errors (eg. HTTP 404).
  client.records.getOne("vault", "o4fq5kwf00amj7x")
    .then((record) => {
      if (record.code == 404) {
        handleError(record)
      }
      else {
        doSomething(record)
      }
    });

In my opinion, this is:

A bit cumbersome
Error-prone, as the expected record could have fields overlapping with the error object (eg. code, message)

Suggestion 1
An alternative could be that an error rejects the promise, resulting in:
  client.records.getOne("vault", "o4fq5kwf00amj7x")
    .then(doSomething)
    .catch(handleError)

This solves both issue 1 and 2 in my opinion, but has the drawback when using async/await syntax, as you would need to wrap everyting in a try/catch
  try {
    const record = await client.records.getOne("vault", "o4fq5kwf00amj7x")
  }
  catch(e) {
    handleError(e)
  }

Suggestion 2
another approach, could be something similar to Svelte Query (https://sveltequery.vercel.app/guides/queries), that you always return the same type of object, wrapping the returned data:
  const result = await client.records.getOne("vault", "o4fq5kwf00amj7x")

  result.code // always present, on success, a 200, on error 404
  result.error // an error object (message, data)
  result.data // the expected record

This does not really solve issue 1, but it does prevent possible errors in user code.

@mnorlin The first example is incorrect. On any response with status code >= 400 the SDK throws a ClientResponseError exception (see https://github.com/pocketbase/js-sdk#errors-handling), aka. we currently implement "Suggestion 1".
I don't agree with Suggestion 2, since it is non-idiomatic JS. In JS errors are usually thrown and not returned as value. In addition, Suggestion 2 also doesn't work well when the Promise based syntax is used because now you have to check for errors in 2 places - once in the then() callback and once in the catch() (in case something else has thrown in then()).

@mnorlin Just tested it and I cannot reproduce your first example. I'm not sure how you were able to access the error response object within the then callback. Or in other words, the following should work:
client.records.getOne("vault", "o4fq5kwf00amj7x").catch((err) => {
    console.log(err)
})

Here is the code where we throw and wrap the response errors - https://github.com/pocketbase/js-sdk/blob/master/src/Client.ts#L306-L318.
If the above doesn't work for you, feel free to let me know and I'll try investigate it further.

This is actually an error on my part, I only read the documentation in the "Preview API" in PocketBase, which does not mention the ClientResponseError. I should have done a more thorough read of your docs, and maybe tested my simple example before posting this issue... Thanks for the quick reply, and keep up the amazing work!


Column-based union

Suggestion for a commit message:
The previous code computed the result of the UNION row by row, copying the values from each row (first from the left, then from the right operand) to the right position in the result (the left and right operand may have different sets of variables). Now whole columns from the left and right operand are copied to the result (or parts of the result filled with UNDEF if the respective operand is missing the respective variable). The copying and filling happends in chunks so that we can have timeout checks inbetween the chunks.


SessionWizard not saving data between form steps

I asked this question on stackoverflow. My question is about saving information between fields.
I am trying to create a multi-step form wizard using django-formtools. I have a main model called Report and several ModelForms as follows:

class ReportFormP1(forms.ModelForm):
    class Meta:
        model = Report
        fields = [
            'company',
            'address_line_1',
            'address_line_2',
            'responsible_person',
            'person_consulted',
            'assessor_name',
            'previous_assessment_date',
            'review_date',
        ]

# section 1
class ReportFormP2(forms.ModelForm):
    class Meta:
        model = Report
        fields = [
            "premise_num_floors",
            "premise_floor_area",
            "premise_occupancy",
            "premise_occupancy_comments",
        ]

in my views, I have created the following view:
class ReportWizardView(SessionWizardView):
template_name = 'reporting/report_create2.html'
form_list = [ReportFormP1, ReportFormP2]
def done(self, form_list, **kwargs):
    return render(self.request, 'done.html', {
        'form_data': [form.cleaned_data for form in form_list],
    })

And my relevant template looks as follows:
{% extends '_base.html' %}
{% load static %}
{% load i18n %}
{% load crispy_forms_tags %}

{% load socialaccount %}

{% block title %}Create a report{% endblock title %}

{% block extra_css %}
    {{ wizard.form.media }}
{% endblock extra_css %}

{% block content %}

Create a report

Step {{ wizard.steps.step1 }} of {{ wizard.steps.count }}

    <form action="" method="post">
        {% csrf_token %}
        {{ wizard.management_form }}

        {% if wizard.form.forms %}
            {{ wizard.form.management_form }}
            {% for form in wizard.form.forms %}
                {{ form|crispy }}
            {% endfor %}
        {% else %}
            {{ wizard.form|crispy }}
        {% endif %}

            {% if wizard.steps.prev %}
            <button class="btn btn-lg btn-warning" name="wizard_goto_step" type="submit" value="{{ wizard.steps.first }}" formnovalidate>{% trans "first step" %}</button>
            <button class="btn btn-lg btn-primary" name="wizard_goto_step" type="submit" value="{{ wizard.steps.prev }}" formnovalidate>{% trans "prev step" %}</button>
            {% endif %}
            {% if wizard.steps.next %}
                <button class="btn  btn-lg btn-primary" name="wizard_goto_step" type="submit" value="{{ wizard.steps.next }}">{% trans "next step" %}</button>
            {% endif %}

            <input class="btn btn-lg btn-success" type="submit" name="Submit" value="Create report">

    </form>

{% endblock content %}

My urls.py look as follows:
    path('create_report2', ReportWizardView.as_view(), name="report_create2"),

My problem is that the form steps are not being saved when I click on next, and then previous (the form is valid). Bellow is an example
First form loaded:

After clicking on 'next':

Now when i click on 'previous', everything is gone:

I wonder what I have missed?

Hi Motatoes, did you get assistance with this problem? I am struggling with the same issue.

@BongzMD I did not get an answer regarding formtools and I don't remember if I found out what was wrong so I created my own wizard view
I made all the fields in my table nullable. I have a create report view which included:

class CreateReportView(LoginRequiredMixin,
                       ReportPermissionMixin,
                       RedirectView):
    def get_redirect_url(self, *args, **kwargs):
        # creating a draft report
        self.report_add_permission(self.request)
        report = Report.objects.create(user=self.request.user)
        return reverse('reporting:report_update', kwargs={"pk": report.id})

I also copied bits of the SesssionWizard for my UpdateReportView but instead of using a session I save the form records directly in the table at every step (provided the form is valid)

Okay thanks
On Sun, 3 May 2020, 12:52 Mohamed<EMAIL_ADDRESS>wrote:

@BongzMD https://github.com/BongzMD I did not get an answer regarding
formtools and I don't remember if I found out what was wrong so I created
my own wizard view
I made all the fields in my table nullable. I have a create report view
which included:
class CreateReportView(LoginRequiredMixin,
ReportPermissionMixin,
RedirectView):
def get_redirect_url(self, *args, **kwargs):
# creating a draft report
self.report_add_permission(self.request)
report = Report.objects.create(user=self.request.user)
return reverse('reporting:report_update', kwargs={"pk": report.id})
I also copied bits of the SesssionWizard for my UpdateReportView but
instead of using a session I save the form records directly in the table at
every step (provided the form is valid)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/jazzband/django-formtools/issues/147#issuecomment-623090882,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AOLJUSH7HJQXKPEEOO7X7H3RPVEHBANCNFSM4IMMV3JQ
.

From your template, the "next" button only takes you to the next page but doesn't actually 'save' the data. you can fix that by using an input field instead on the next button as seen below.
<input type="submit" value="{% trans "Next" %}"/>

Isn't there a way to save data in the session and reuse it in the steps? directly saving to DB seems a little wrong to me tbh...

I also have this issue

From your template, the "next" button only takes you to the next page but doesn't actually 'save' the data. you can fix that by using an input field instead on the next button as seen below.
<input type="submit" value="{% trans "Next" %}"/>

When trying this I get a SuspiciousOperation error saying "ManagementForm data is missing or has been tampered."


Add clingen linkouts to Mondo, one off

This adds all ClinGen linkouts to Mondo as an experimental feature using a Mondo internal relationship.
Looks good in Protege:

Note to reviewer:the 6 "removed lines" are the consequences of normalisation:

@matentzn is this intended for the August release?

No need to merge this, I can update this PR again right after the release and we have it for the next one. Up to you. The PR does not affect anything in Mondo (only adds some new relations) so I would personally wave it through, but I see the value to sticking to process.


digitally signing the pctl CLI for macOS

Expected vs actual behavior

digitally signing the pctl CLI for macOS, currently it shows an error saying it is not trust worthy.

Steps to reproduce the bug

Download pctl and true to execute any command like pctl get clusters after configuring it.

Are you using the latest version of the project?
You can check your version by running helm ls|grep '^<deployment-name>' or using pctl, pctl version, and provide the output.

Yes

What is your environment setup? Please tell us your cloud provider, operating system, and include the output of kubectl version --output=yaml and helm version. Any other information that you have, eg. logs and custom values, is highly appreciated!

Applicable to all

[x] I've described the bug, included steps to reproduce it, and included my environment setup with all customizations.

[x] I'm using the latest version of the project.

we can use this gon to sign and notorize the CLI. Also this blog can be handy. cc: @niravparikh05 @meain

Can we use cosign tool - https://docs.sigstore.dev/ , to sign the binary, vCluster project - https://github.com/loft-sh/vcluster , which has CLI uses the same method

@sandeep540 I don't think using cosign will help with the macOS warning IIUC if that is what the end goal is.


AddToOTG function to attr package

Adding AddToOTG function to internal/attrs/attrs.go
This is very useful for quick OTG configurations

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 72.664%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1462

Relevant Lines:
2012

💛  - Coveralls

/gcbrun


CSS internals vs externals

Description

Just a discussion opener, it's probably been talked about, but I'd be interested to know the history if it has been talked about already.
Should spectrum-css set margins on anything that would be 'external' to the component? What I mean by this is, in button css, there is .button + .button, which is contextual and only works between buttons. if there are two button next to each other, they should probably be wrapped in a button group which handles setting the margins between its children. button's css shouldn't know anything about it's siblings, only its internals.
Taking this a little further, should any component set a margin on it's outer most dom node? It may interfere with whatever is trying to compose it into a layout.

Sorry for the long delay in getting to this, Rob!  We're still discussing internally, since there are opinions and feels on this topic.  We can loop you into the conversation when it comes up again.  I'm going to close this and note to loop you into our IRL conversation via some Adobe internal venue.
❤


[BUG]: [UAT | "Number of Advocate" field is not appearing in review case and FSO.(should not have flag)]

Describe the bug
"Number of Advocate" field is not appearing in review case and FSO.
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

Tested in uat env, working as expected:

cc: @Ramu-kandimalla @rajeshcherukumalli


Better solution for settings.py for testing and production

Currently there is a "settings.py", however as some things need to be changed for production using Heroku there is a "settings_online.py" and "settings_offline.py" file. Currently, the idea is to subsitute "settings.py" with the content of one of the two files. There should be a better solution how to deal with this.

Improved the settings.py by implementing amazon S3, which can be deactived. However, this issue is not done yet. Further thought needs to be invested. Nevertheless the feature should be already merged with master with the improvements, which were developed until now.
In the future maybe the following points need to be addressed:

[ ] Switching the amazon bucket from development to production
[ ] Having another way than changing USE_S3 in the file (use environment variable for this?)


Do not uglify builds when running start-dev

Tweaks bundle paths (client vs client/js) to not confuse sourcemaps as much. Disables uglifyjs plugin when running with --watch. Also reduces production built file size a little more.

Playing a bit with the current state, we definitely cannot have configurations differ solely on build:webpack vs. watch. When you check out a branch and run npm install, this (at least until #737 gets addressed) this assumes prod.
I think our best bet is to rely on NODE_ENV to be production (which is also set when using --production).

I wanted to use env at first, but setting it in script and making it crossplatform is not easy.

I don't think we have a choice though. Could use https://www.npmjs.com/package/cross-env for cross-platform in scripts?

I think we can do a two liner js to set the environment.
On Tue, 3 Jan 2017, 19:59 Jérémie Astori<EMAIL_ADDRESS>wrote:

I don't think we have a choice though. Could use
https://www.npmjs.com/package/cross-env for cross-platform in scripts?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/thelounge/lounge/pull/858#issuecomment-270178682, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAlb07-f74NJIcIwtUt38PIRXuz0MAf4ks5rOoyIgaJpZM4LYIpH
.

You mean to emulate cross-env?
Anyway, it doesn't really matter I think, since it's mostly NODE_ENV=production npm install which will be useful. The rest should assume default NODE_ENV or use the one being set.

Using the process.env.NODE_ENV to determine what to build or not is how most of the webpack-built project does. I left a comment in the code if we want to include the uglify plugin only when in production (NODE_ENV == PRODUCTION)...

Alright, spent a looot of time on this, between reading docs and GitHub threads for Webpack, npm, etc. I believe this PR puts us in an optimal state regarding recent introduction of Webpack.
This PR resolves the first 2 items of https://github.com/thelounge/lounge/issues/857#issue-198109751.
Posting here my commit message details + extra info:
1. Use Webpack configuration based on NODE_ENV instead of watch/no-watch
Also, move the DedupePlugin to the prod-specific section. Webpack doc itself recommends to not run this outside of production.
Note that this currently breaks cross-OS support of npm run build. This will be fixed in a latter commit. This was temporary and on purpose to not mix the unrelated commits of Webpack-for-production and no-npm run build-on-npm install. It's fixed by the next commit.
This commit addresses my comments made in this PR. Non-cross-OS character of this commit is the reason why the next commits are part of this PR.
2. Make and document npm run build now a mandatory step of the install/build setup
This has several reasons, benefits and consequences:

When running on root (which is not recommended anyway), npm run build was already necessary.
This allows to not use the prepublish hook, whose behavior is going to change in npm v5 and again in npm v6.
This allows to create both production and development builds when running from source.
It makes npm run build compatible with Windows again for development environments (lost in previous commit).
It uses the prepublishOnly hook added in npm v4. Since this hook is not available prior to that, deployment to npm from Travis has to be done on the Node.js v7 environment.

This fixes https://github.com/thelounge/lounge/issues/737.
3. Add an extra Travis CI job to make sure production build succeeds and passes tests
This only adds one extra job to the build (which still runs all its jobs concurrently, so build time does not increase) to make sure what we deploy or will is actually correct.
This is highly desirable since we now produce 2 different files in development/testing and production.
4. Add a basic check for bundled application when starting the server
Note that this will not detect if the client application was built with an old version of the repo.
This partially addresses https://github.com/thelounge/lounge/issues/737#issuecomment-261702678, but a naive check is better than no checks!

Yeah I know but it's OK as it's only relevant when publishing, which we
only do from Travis builds.
If comes a time when we don't publish through Travis as a one-off, chances
are I'd publish myself (not Windows) and if not, one can tweak to use
Windows' set for this one-off.
All other commands, for day to day development, work on all platforms.

@thelounge/maintainers, yes, no, anyone? :)
v2.2.0 is sooo close... !

@astorije Sorry, didn't realise you guys had stopped messing around with this PR :-P I sort of phased out the notifications. I'll take a look now.

Fyi, building from git will most likely not minify (as you have to explicitly set node env to prod). The changes are fine for now.

Alright, I believe (well, I hope 😅) this one is finally good to go. @xPaw, are you happy with it?

:+1:

Well, I'll merge, then.


Improve Thy Documentation

I've aye had a hard time understanding Brandon and Stephen's documentation. 'tis quite incoherent at times, which I imagine is why many hast a hard time just migrating to TCA 'i  the first place. I figure I could doth 'em a favor and compose behoveful changes to help 'em out.

Happy belated April Fools!


chore: upgrade typescript to 4.5.2

Description
chore: upgrade typescript to 4.5.2 (was 4.4.4)
Notice
Before submitting a pull request, please make sure you have answered the following:

[ ] Have you followed the guidelines in our Contributing guide?
[ ] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
[ ] Do all new and existing tests pass? Does the linter pass?

Pull Request Type

[ ] :bug: Bug fix (Non-breaking Change: Fixes an issue)
[X] :hammer_and_wrench: Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
[ ] :nail_care: New Feature (Breaking/Non-breaking Change)

I assume all tests are passing and the build completes?

yepperooni!


CLiCkin2DaBeaT error: cannot fetch stages-url not found

What steps will reproduce the problem?
1. Launch any Jelly Bean AVD (emulator)
2. Build, install and launch CLiCkin2DaBeaT
3. Start playing

What is the expected output? What do you see instead?
Expected output:
Should be able to fetch stages and play the game.
Actual output:
First it shows message “No stages found."You don't seem to have any stages on
your SD card", which is as expected.
Next, when we click "Ok, fine. I'll go get some stages.", the app tries to
fetch the files from the
"http://groups.google.com/group/clickin-2-da-beat/files", but browser shows 404
error-The requested URL was not found on this server.

What version of the product are you using? On what operating system?
CLiCkin2DaBeaT application built from apps-for-android source.
Jelly bean based emulator. Tried both ARM-based and Intel Atom (x86-based)
emulator on Linux(Ubuntu) and Windows.

Please provide any additional information below.

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 26 Sep 2013 at 5:08

Original comment by<EMAIL_ADDRESS>on 3 Apr 2014 at 6:37
Attachments:

pref_key_personalize_bg.jpg


How to extend @configure.serializer?

Our requirements are asking for our show/edit views to be one in the same so that a user may toggle between a "unlocked" (editable) and "locked" state. I've tried the following approach, but it seems the serializer in the BaseResource is being ignored. Am I taking the wrong approach?
class BaseResource extends RailsResource
    @configure
        serializer: railsSerializer( ->
            @exclude( "$locked", "$snapshots" )
        )
   unlock: ->
        @snapshot()
        @$locked = false
   lock: ->
        @rollback()
        @$locked = true

class User extends BaseResource
    @configure
        url: "/manage/users"
        name: "user"
        serializer: railsSerializer( ->
            @exclude( "$selected" )
        )

The serializer of User would overwrite the base one.  It's an interesting scenario I've not real thought about so I don't have any immediate suggestions.

On Feb 25, 2015, at 8:02 PM, Brian<EMAIL_ADDRESS>wrote:
Our requirements are asking for our show/edit views to be one in the same so that a user may toggle between a "unlocked" (editable) and "locked" state. I've tried the following approach, but it seems the serializer in the BaseResource is being ignored. Am I taking the wrong approach?
class BaseResource extends RailsResource
@configure
serializer: railsSerializer( ->
@exclude( "$locked" )
)
unlock: ->
@snapshot()
@$locked = false
lock: ->
@rollback()
@$locked = true
class User extends BaseResource
@configure
url: "/manage/users"
name: "user"
serializer: railsSerializer( ->
@exclude( "$selected" )
)
—
Reply to this email directly or view it on GitHub.


CSDK-1413: Android Starter Kit

Thank you for reviewing this so soon @lazeratops! I believe all the feedback is now addressed.

Thanks for the review @lazeratops!


Is this normal behavior for a xiwi tab startup or am I doing something wrong...

My tab opens and works fine but
Here is what I see in the launching console...
chronos@localhost / $  sudo enter-chroot -b xiwi -T startxfce4
Password:
Enter encryption passphrase for precise.pws:
Entering /mnt/stateful_partition/crouton/chroots/precise.pws...
WARNING: /etc/rc.local failed with code 1
chronos@localhost / $

It means that you have added something to /etc/rc.local that isn't running properly.  It won't impact crouton unless you actually depend on whatever program you're trying to launch in there.


AvalonEdit showing null characters at the end of large file

We have the potential for some large text files, which has caused a few issues with AvalonEdit over the years, some still unresolved. But we just recently found this new one. For some reason, this specific file displays around 18 "NUL" characters at the end of the file. I can delete them, and when I reopen the file they're still there. If I put text after the NULs, and delete the NULs, the new NULs when I reopen the file are after the text I added, i.e. always at the end of the file.
When I open the file in NP++ or other similar editors, I don't see anything at the end of the file. This seems to just be NUL characters that are displayed in AvalonEdit, but don't actually exist in the file. I have attached an image of what's going on. As you can see, it's a decently-long file. I can't share the file since it's all proprietary data, but I will try and see if I can make a similar test file, to determine if it's length or specific file content that's triggering this. In the past when working on other AvalonEdit large file issues I never saw this, so I expect it's not just tied to file length. Also this behavior seems consistent, with multiple users seeing it on different machines.

What is the actual encoding of the file, and what does AvalonEdit think it is?

Encoding is ANSI. In some cases I get strings of content, some files are remotely hosted and contents are retrieved with web protocols, and in those cases I just set Document.Text to that string.
In order to read local files, I read the file into a char[] and then create a rope from that myself, then create a TextDocument with that rope. That was the best way I could find to deal with extremely large files, since 300+MB text files, while obscenely large, are not unheard of in our application. I used to create the TextDocument from an IEnumerable<char> which was just yield returning each character, but that kept too much in memory for large files and would cause out of memory crashes.
In testing today, I was able to see that it is actually adding the NUL characters to the end of the file every time I open. When I saved the file without deleting them, I got them to show up in NP++. Every time I open up the file it seems to add 18 NULs to the end. I started with 18, open, save, it has 36 (confirmed in NP++). Open, save, open, save, I'm at 72.
I can delete the NULs and save, and it persists fine. But if I open the file again, it will add 18 new NULs and so on. I have attached a screenshot showing the end of the file in Notepad++ after I deleted all NULs, opened the file in my application (which added the NULs), and saved it. Encoding, file length, and other information like that can also be seen.

What does AvalonEdit think the encoding is?

Sorry about that, I thought I included that info. When I checked, Encoding was null. So I assume whatever the default is?

When AvalonEdit opens a file and you haven't specified an encoding, it makes a best guess. Try setting the Encoding property on the TextEditor to Windows-1252 (which you can get with
Encoding.GetEncoding(1252);
before loading the file.

That did it! Thank you very much for the fix. Any idea what would cause the NULs? Does that mean something like I have 18 odd characters in my file that I should search for?

"NUL" is what AvalonEdit uses to display a character with the value of 0. If you want to dig further, I'd suggest first examining more closely what exactly is hiding at the end of your file (use an editor that will display what's there in hex). If matters still aren't clear, download the AvalonEdit source and build and debug to determine exactly how it's handling those bytes.


Add notes on possible architecture plans for Sensorium

Consideration: Sensors will need to live through app restarts. I may have to have a simple database to store that information, probably in CoreData.

Because the app is predicated on "listening," or subscribing to events I'd suggest exploring an event-bus kinda architecture.

Martin Fowler, "Event Sourcing"
Martin Fowler, "What do you mean by 'Event-Driven'?"

Thank you! I've bookmarked these all to be read ASAP.


RuntimeError: Failed to load audio: [WinError 2]

When using pyttsx3 example this error appears
Here's a log
2023-09-24 12:03:34 | INFO | comtypes.client._code_cache | Using writeable comtypes cache directory: 'M:\AIAssistant\venv\lib\site-packages\comtypes\gen'
Available voices:
0: Microsoft Irina Desktop - Russian
1: Microsoft Zira Desktop - English (United States)
audio file path: output/out.wav
loading pth Vega.pth
gin_channels: 256 self.spk_embed_dim: 109
<All keys matched successfully>
Traceback (most recent call last):
  File "m:\aiassistant\venv\src\rvc\lib\audio.py", line 14, in load_audio
    ffmpeg.input(file, threads=0)
  File "M:\AIAssistant\venv\lib\site-packages\ffmpeg\_run.py", line 313, in run
    process = run_async(
  File "M:\AIAssistant\venv\lib\site-packages\ffmpeg\_run.py", line 284, in run_async
    return subprocess.Popen(
  File "M:\Python310\lib\subprocess.py", line 966, in __init__
    self._execute_child(args, executable, preexec_fn, close_fds,
  File "M:\Python310\lib\subprocess.py", line 1435, in _execute_child
    hp, ht, pid, tid = _winapi.CreateProcess(executable, args,
FileNotFoundError: [WinError 2] Не удается найти указанный файл

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "M:\AIAssistant\main.py", line 51, in <module>
    rvc_convert(model_path="Vega.pth",
  File "m:\aiassistant\venv\src\rvc-tts-pipe\rvc_infer.py", line 337, in rvc_convert
    wav_opt=vc_single(0,input_path,f0_up_key,None,f0method,file_index,file_index2,index_rate,filter_radius,resample_sr,rms_mix_rate,protect)
  File "m:\aiassistant\venv\src\rvc-tts-pipe\rvc_infer.py", line 159, in vc_single
    audio = load_audio(input_audio_path, 16000)
  File "m:\aiassistant\venv\src\rvc\lib\audio.py", line 19, in load_audio
    raise RuntimeError(f"Failed to load audio: {e}")
RuntimeError: Failed to load audio: [WinError 2] Не удается найти указанный файл

Process finished with exit code 1

Fixed issue by replacing code in audio.py file. audio.py is located in venv/src/rvc/lib. Also you will need to install av using this command pip install av
Here is this code
import librosa
import numpy as np
import av
from io import BytesIO

def wav2(i, o, format):
    inp = av.open(i, "rb")
    if format == "m4a":
        format = "mp4"
    out = av.open(o, "wb", format=format)
    if format == "ogg":
        format = "libvorbis"
    if format == "mp4":
        format = "aac"

    ostream = out.add_stream(format)

    for frame in inp.decode(audio=0):
        for p in ostream.encode(frame):
            out.mux(p)

    for p in ostream.encode(None):
        out.mux(p)

    out.close()
    inp.close()

def audio2(i, o, format, sr):
    inp = av.open(i, "rb")
    out = av.open(o, "wb", format=format)
    if format == "ogg":
        format = "libvorbis"
    if format == "f32le":
        format = "pcm_f32le"

    ostream = out.add_stream(format, channels=1)
    ostream.sample_rate = sr

    for frame in inp.decode(audio=0):
        for p in ostream.encode(frame):
            out.mux(p)

    out.close()
    inp.close()

def load_audio(file, sr):
    try:
        file = (
            file.strip(" ").strip('"').strip("\n").strip('"').strip(" ")
        )  # 防止小白拷路径头尾带了空格和"和回车
        with open(file, "rb") as f:
            with BytesIO() as out:
                audio2(f, out, "f32le", sr)
                return np.frombuffer(out.getvalue(), np.float32).flatten()

    except AttributeError:
        audio = file[1] / 32768.0
        if len(audio.shape) == 2:
            audio = np.mean(audio, -1)
        return librosa.resample(audio, orig_sr=file[0], target_sr=16000)

    except Exception as e:
        raise RuntimeError(f"Failed to load audio: {e}")

Fixed issue by replacing code in audio.py file. audio.py is located in venv/src/rvc/lib. Also you will need to install av using this command pip install av Here is this code
import librosa
import numpy as np
import av
from io import BytesIO

def wav2(i, o, format):
    inp = av.open(i, "rb")
    if format == "m4a":
        format = "mp4"
    out = av.open(o, "wb", format=format)
    if format == "ogg":
        format = "libvorbis"
    if format == "mp4":
        format = "aac"

    ostream = out.add_stream(format)

    for frame in inp.decode(audio=0):
        for p in ostream.encode(frame):
            out.mux(p)

    for p in ostream.encode(None):
        out.mux(p)

    out.close()
    inp.close()

def audio2(i, o, format, sr):
    inp = av.open(i, "rb")
    out = av.open(o, "wb", format=format)
    if format == "ogg":
        format = "libvorbis"
    if format == "f32le":
        format = "pcm_f32le"

    ostream = out.add_stream(format, channels=1)
    ostream.sample_rate = sr

    for frame in inp.decode(audio=0):
        for p in ostream.encode(frame):
            out.mux(p)

    out.close()
    inp.close()

def load_audio(file, sr):
    try:
        file = (
            file.strip(" ").strip('"').strip("\n").strip('"').strip(" ")
        )  # 防止小白拷路径头尾带了空格和"和回车
        with open(file, "rb") as f:
            with BytesIO() as out:
                audio2(f, out, "f32le", sr)
                return np.frombuffer(out.getvalue(), np.float32).flatten()

    except AttributeError:
        audio = file[1] / 32768.0
        if len(audio.shape) == 2:
            audio = np.mean(audio, -1)
        return librosa.resample(audio, orig_sr=file[0], target_sr=16000)

    except Exception as e:
        raise RuntimeError(f"Failed to load audio: {e}")

Thank you so much, buddy! I've been fiddling with this error all damn day. It finally worked!


First Rendering using manual link rewrite POPs the last state instead of PUSHing the new state.

Possibly related issues:
https://github.com/supasate/connected-react-router/issues/301
https://github.com/supasate/connected-react-router/pull/76
Versions:
"engines": {
    "node": ">=10.15.1"
  },
"dependencies": {
    "connected-react-router": "6.5.0",
   "history": "4.6.1",
   "react": "^16.8.6",
    "react-redux": "7.1.0",
   "react-router-dom": "4.4.0-beta.8",
  "redux": "^4.0.1",

Routes:
return (
    <ConnectedRouter history={history}>
      <Switch>
        <Route path="/login" component={LoginScene}/>
        <Route path="/logout" component={LogoutScene}/>
        <Route path="/register" component={RegisterScene}/>
       ....
      </Switch>
    </ConnectedRouter>
)

Video Showcasing the issue:

As you can see from the video I start in the login route and I manually enter a new route for example Register to simulate a deep link action.
I would expect the page to render the RegisterScene component. Instead it renders the previous LoginScene component and I can see in the Redux dev tools there is a POP action.
Now when I do a navigation from within the application, for example Login -> Register then the same thing happens> Change to Login and I go back to Register again.
Is that intended?

We are also having this issue. Our oidc-client is not able to read the redirect back from our IdentityProvider before connected-react-router POPs the state off

@bpedersen This issue basically breaks deeplinking...🙁

I've had something similar happen to me. It was caused by not blacklisting the router history from redux-persist. I added router to the blacklist and my issue went away.

@sgermain06 thank you for the pointer

@sgermain06 I think that fixed the issue. I was not using redux-persist though but a custom localstorage service that does the same thing. Maybe it's important to include a question in the ISSUE_TEMPLATE if we store the router state somewhere using redux-persist just to weed out those issues in the future


Login with private key

Yo bro can u make using accounts with Private key instead of seed phrase. I have 20 wallets on the same seedphrase which i need to use, but even if i put another public key in "youAre" its always using only first wallet on seedphrase.
Also will be great if u can do multiple wallets running at the same time

And also its just stucking after some time and need to restart, without any error

Sorry, but this is just a simple demo app for a suidouble library. I am not going to add any features to it. Feel free to fork and adjust though.


Interest: How does this library differ from zustand?

Hey, I recently discovered this great library and want to ask how this library differs from the popular hook based library zustand, which also gives a pretty similar API to work with states.
I want to decide whether to use nanostores or zustand and don't want to figure out the nuances bits when it's almost too late.
I would really appreciate an answer and thank the maintainer and creator of this module for their awesome work. 💐

The main difference: Nano Stores was created to move logic from React component (or other UI library) into state manager.
This is why stores in Nano Stores have constructor (to bind event listeners), destructor and active/disabled mode.


Integration tests with staking contract

Targeted PR against correct branch (see CONTRIBUTING.md)

[ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.

[ ] Wrote tests

[ ] Updated relevant documentation (docs/)

[ ] Added  relevant godoc comments.

[ ] Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

[ ] Re-reviewed Files changed in the Github PR explorer

For admin use:

[ ] Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
[ ] Reviewers assigned
[ ] Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Codecov Report

Merging #112 into master will increase coverage by 2.75%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #112      +/-   ##
==========================================
+ Coverage   58.91%   61.67%   +2.75%
==========================================
  Files          20       20
  Lines        1587     1628      +41
==========================================
+ Hits          935     1004      +69
+ Misses        563      536      -27
+ Partials       89       88       -1

Impacted Files
Coverage Δ

x/wasm/internal/keeper/query_plugins.go
50.00% <100.00%> (+21.65%)
:arrow_up:

x/wasm/internal/keeper/test_common.go
84.16% <100.00%> (+6.78%)
:arrow_up:

x/wasm/internal/keeper/keeper.go
78.70% <0.00%> (+1.38%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95bd9e8...eed809c. Read the comment docs.


support sqlite3 module

+1 Since we don't have access to the Git repo, I'm trying to hack a solution to detect file changes and then insert the metadata for the changed files into the primary DB -- created a pre-commit hook that populates a local SQLite db to track the changes and pushed that to Heroku, only to discover you cannot import SQLite in Heroku, even though I only need it for readonly.


python312Packages.google-cloud-compute: 1.19.1 -> 1.19.2

Changelog: https://github.com/googleapis/google-cloud-python/blob/google-cloud-compute-v1.19.2/packages/google-cloud-compute/CHANGELOG.md
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.


href.li

Can you remove href.li from your list please? It's simply a redirection service to hide the referrer of a click in a browser. It doesn't host any malware.
Thanks.

data\someonewhocares.org\hosts:<IP_ADDRESS> href.li

It's possible someone caught it being abused and redirecting to malware, but I tend to agree that short link services are not inherently bad, especially ones trying to help you out by increasing your privacy. However, if it helps, if you are using Chrome, there are plenty of header modification extensions you can look into that will keep your referrer information empty/bogus all the time. If you're a web developer, such extensions also come in handy for quickly testing out vhosts, different browser agents, and other things you might need to test out while your checking your stuff.

I contacted Dan Pollack who compiles the original list this was on. A few hours after I opened this issue he replied saying he had removed it. I should have responded here saying that, so I hope it'll be removed the next time the list is refreshed. :)

No worries, thanks for doing all the legwork for us! It will definitely drop off the next time the lists are generated, but you can always run the Python script yourself to get a head start.


JdkHttpClient:  sendSync and sync response

API change check
API changes are not detected in this pull request.


Update the README's build instructions

I tested out building the project with both npm-only and yarn-only JS dependency installation steps and it worked a treat. :) Also fixed the subsection links as that was something I noticed on my way.
I think this closes #163, I don't think the page serving issues referenced there are an issue anymore?

Thanks!


Clean up docker references from Service documentations

For resolving https://github.com/kubernetes/website/issues/30966
What is changing?

Removing examples contrasting k8s networking with Docker networking from concept document explaining connecting applications using services
Remove reference to dockerlinks in favor of English description of the env vars autocreated for every Service. I chose the word "granular" to describe the kind of Dockerlink compatible variables.

Previews:

https://deploy-preview-31331--kubernetes-io-main-staging.netlify.app/docs/concepts/services-networking/connect-applications-service/
https://deploy-preview-31331--kubernetes-io-main-staging.netlify.app/docs/concepts/services-networking/service/#environment-variables

I think these changes look good and make the intro easier to follow!
/lgtm

/lgtm

Thank you for this PR
/approve


Multiple browser tests running simultaneously with same screenshot name fails

I think there is an issue with tests running on multiple browsers simultaneously if they use the same name. Here is my setup:
wdio.conf.js
capabilities: [{
    browserName: 'chrome'
}, {
    browserName: 'firefox'
}, {
    browserName: 'internet explorer'
}]

header.spec.js
describe('header', function () {
    it('should look the same', function (done) {
        browser
            .url('/')
            .webdrivercss('home', {
                name: 'header',
                elem: '.header'
            }, function (err, res) {
                expect(res.header[0].isWithinMisMatchTolerance).toBe(true);
            }).call(done);
    });
});

One browser always fails because they are sharing the same screenshot filename and running at the same time:

home.320px.png
home.header.320px.png

However if I make the name to be unique per browser. It seems to work every time:
describe('header', function () {
    it('should look the same', function (done) {
        browser
            .url('/')
            .webdrivercss('home.' + browser.desiredCapabilities.browserName, {
                name: 'header',
                elem: '.header'
            }, function (err, res) {
                expect(res.header[0].isWithinMisMatchTolerance).toBe(true);
            }).call(done);
    });
});

This then creates separate files per browser, which makes more sense to me:

home.chrome.320px.png
home.chrome.header.320px.baseline.png

Shouldn't this naming be done automatically by webdrivercss? Otherwise it fails for anyone using multiple browsers!
If you add it to webdrivercss, I would suggest we move the browser name to the end of the filename, after the user inputted name e.g.:

home.header.chrome.320px.baseline.png
home.header.firefox.320px.baseline.png

This allows screenshots of similar types to be grouped together, and you can easily see browser screenshots side by side.
Another point to notice is that "internet explorer" has a space in the browser name, this causes issue when naming screenshots. I would suggest using either:

internet-explorer
ie

I use a folder system that puts screenshots into different folders based on metadata. That works pretty well.

@JamEngulfer Nice, can you post an example of how that works? does it fix the bug mentioned above? or a workaround?

@kmturley Well, it's a pretty simple solution. I just generate a file path that takes into account things like the browser, element and url, then set it with the screenshotRoot option.

OK? that didn't really answer my questions though!? :)

Sorry, yeah. You're right.
From what I can see, you haven't really got a bug there, it's just reusing the same folder (unless you are actually making it use different folders).
You can set the folder that the screenshots are saved in with screenshotRoot: <folder> in the object you pass to webdrivercss.init(client, options).
When I run each of my tests, I have an object with all of the information like browser, url and element. I just use the built in path module's join method to quickly make a folder path from this information. I then use this in the aforementioned screenshotRoot option.

That sounds like a good approach, but does that mean you need to init() for each browser separately? to be able to change the screenshotRoot per browser? or you pass a dynamic variable?

I use something like:
.webdrivercss(browser.desiredCapabilities.browserName + ".TopLevel", [{
					name: "specificLevel",
					elem: "#SomeElem"
				}], handleScreenshots)

adds a bit to the boilerplate of the call, but it could be extracted if you really want...


[BUG]: drizzle-typebox infers integer() as TString

Report hasn't been filed before.

[X] I have verified that the bug I'm about to report hasn't been filed before.

What version of drizzle-orm are you using?
0.38.1
What version of drizzle-kit are you using?

Other packages
<EMAIL_ADDRESS>Describe the Bug
The integer() column from pg-core is being inferred as TString/String while it should be inferred as Number.
import * as t from '@sinclair/typebox';
import { createSchemaFactory } from 'drizzle-typebox';
import { integer, pgTable, text } from 'drizzle-orm/pg-core';
import type { __String } from 'typescript';

export const contactTable = pgTable('contact', {
  id: integer().primaryKey().generatedAlwaysAsIdentity(),
  name: text().notNull(),
  email: text(),
  phone: text(),
  title: text(),
});

const { createInsertSchema, createSelectSchema } = createSchemaFactory({
  typeboxInstance: t,
});

const _iS = createInsertSchema(contactTable, {
  email: t.String({ format: 'email' }),
});

type Test = typeof _iS.static;

Should be fixed in<EMAIL_ADDRESS>


New version: ChainRules v0.7.37

Registering package: ChainRules
Repository: https://github.com/JuliaDiff/ChainRules.jl
Created by: @oxinabox
Version: v0.7.37
Commit: 3cf5b8a9a8192f3b38813fabcccc39f35af692e3
Reviewed by: @oxinabox
Reference: https://github.com/JuliaDiff/ChainRules.jl/commit/3cf5b8a9a8192f3b38813fabcccc39f35af692e3#commitcomment-44876692

close in-favor of https://github.com/JuliaRegistries/General/pull/25961


robustify against 0 norm features

Something weird is happening: without this, the solver fails when X has a 0 column (which is normal, there is a division by 0)
But such a column should not be selected in the WS, right ?
Reproduce with
import libsvmdata
import numpy as np
from numpy.linalg import norm
from andersoncd import Lasso
X, y = libsvmdata.fetch_libsvm("rcv1.binary")
alpha_max = norm(X.T @ y, ord=np.inf) / len(y)
clf = Lasso(fit_intercept=False, alpha=alpha_max/10, verbose=1).fit(X, y)

Codecov Report

Merging #63 (ea11649) into master (b8ce7d3) will increase coverage by 8.90%.
The diff coverage is 67.84%.

@@            Coverage Diff             @@
##           master      #63      +/-   ##
==========================================
+ Coverage   56.19%   65.09%   +8.90%
==========================================
  Files          12       11       -1
  Lines        1098      742     -356
  Branches      242      117     -125
==========================================
- Hits          617      483     -134
+ Misses        406      228     -178
+ Partials       75       31      -44

Impacted Files
Coverage Δ

andersoncd/tests/test_docstring_parameters.py
73.91% <ø> (-0.73%)
:arrow_down:

andersoncd/penalties.py
44.76% <44.76%> (ø)

andersoncd/datafits.py
52.23% <52.23%> (ø)

andersoncd/solver.py
66.44% <66.44%> (ø)

andersoncd/data/synthetic.py
72.41% <69.23%> (-18.50%)
:arrow_down:

andersoncd/estimators.py
92.39% <92.39%> (ø)

andersoncd/__init__.py
100.00% <100.00%> (ø)

andersoncd/data/__init__.py
100.00% <100.00%> (ø)

andersoncd/tests/test_estimators.py
100.00% <100.00%> (ø)

andersoncd/utils.py
28.76% <0.00%> (-4.11%)
:arrow_down:

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d83596...ea11649. Read the comment docs.

Investigated a bit further : at the iteration where the solver fails, kkt has only 82 non zero values (I'm surprised)
by growth policy it turns out that we select 114 feats in subpb.. We are unlucky and amongst the 114 - 86 features with 0 kkt violation that we pick, there is one which is a 0 column, hence the failure.
It's wild that so many features have 0 kkt violation, no ?    I see the easy fix of selecting at most (kkt != 0).sum() features in the ws, but I'm surprised it's 0 for such a large number of features
Your take on this @QB3  ?

I'm surprised it's 0 for such a large number of features

I also already observed that uncleaned rcv1 has a large number of zero columns.
+1 for (kkt != 0).sum()


Remove Search Match Summary

On searches, each user has a tag-line of matching search results.  This needs to be hidden.  Will return when we can point to a search page showing these items:

@Vensberg this should be ready for review on test.

@UcDust , looks good; the match counts are gone.


Update mixer-rule-additional-telemetry.yaml

Needed to match: https://github.com/istio/mixer/pull/744

Jenkins job istio/presubmit passed


macOS build issue with tflite using make

Please make sure that this is a build/installation issue. As per our GitHub Policy, we only address code/doc bugs, performance issues, feature requests and build/installation issues on GitHub. tag:build_template
System information

OS Platform and Distribution (e.g., Linux Ubuntu 16.04): macOS 10.15.4 (Catalina)
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device:
TensorFlow installed from (source or binary): source
TensorFlow version:
Python version:
Installed using virtualenv? pip? conda?:
Bazel version (if compiling from source): N/A
GCC/Compiler version (if compiling from source): Apple clang version 11.0.3
CUDA/cuDNN version:
GPU model and memory:

Describe the problem
When attempting to build from source on macOS using make, the benchmark_model binary fails to build due to the --whole-archive flag
Provide the exact sequence of commands / steps that you executed before running into the problem
./tensorflow/lite/tools/make/download_dependencies.sh
./tensorflow/lite/tools/make/build_lib.sh

Any other info / logs
Include any logs or source code that would be helpful to diagnose the problem. If including tracebacks, please include the full traceback. Large logs and files should be attached.
$ ./tensorflow/lite/tools/make/build_lib.sh
+ set -e
+++ dirname ./tensorflow/lite/tools/make/build_lib.sh
++ cd ./tensorflow/lite/tools/make
++ pwd
+ SCRIPT_DIR=/Users/username/tensorflow-master/tensorflow/lite/tools/make
+ TENSORFLOW_DIR=/Users/username/tensorflow-master/tensorflow/lite/tools/make/../../../..
+ make -j 4 -C /Users/username/tensorflow-master/tensorflow/lite/tools/make/../../../.. -f tensorflow/lite/tools/make/Makefile
g++ -O3 -DNDEBUG -fPIC --std=c++11  -DTFLITE_WITHOUT_XNNPACK -I. -I/Users/username/tensorflow-master/tensorflow/lite/tools/make/../../../../../ -I/Users/username/tensorflow-master/tensorflow/lite/tools/make/../../../../../../ -I/Users/username/tensorflow-master/tensorflow/lite/tools/make/downloads/ -I/Users/username/tensorflow-master/tensorflow/lite/tools/make/downloads/eigen -I/Users/username/tensorflow-master/tensorflow/lite/tools/make/downloads/absl -I/Users/username/tensorflow-master/tensorflow/lite/tools/make/downloads/gemmlowp -I/Users/username/tensorflow-master/tensorflow/lite/tools/make/downloads/ruy -I/Users/username/tensorflow-master/tensorflow/lite/tools/make/downloads/neon_2_sse -I/Users/username/tensorflow-master/tensorflow/lite/tools/make/downloads/farmhash/src -I/Users/username/tensorflow-master/tensorflow/lite/tools/make/downloads/flatbuffers/include -I/Users/username/tensorflow-master/tensorflow/lite/tools/make/downloads/fp16/include -I -I/usr/local/include \
  -o /Users/username/tensorflow-master/tensorflow/lite/tools/make/gen/osx_x86_64/bin/benchmark_model /Users/username/tensorflow-master/tensorflow/lite/tools/make/gen/osx_x86_64/obj/tensorflow/lite/tools/benchmark/benchmark_main.o \
   -Wl,--whole-archive /Users/username/tensorflow-master/tensorflow/lite/tools/make/gen/osx_x86_64/lib/benchmark-lib.a -Wl,--no-whole-archive  -lstdc++ -lpthread -lm -lz -ldl
g++ -O3 -DNDEBUG -fPIC --std=c++11  -DTFLITE_WITHOUT_XNNPACK -I. -I/Users/username/tensorflow-master/tensorflow/lite/tools/make/../../../../../ -I/Users/username/tensorflow-master/tensorflow/lite/tools/make/../../../../../../ -I/Users/username/tensorflow-master/tensorflow/lite/tools/make/downloads/ -I/Users/username/tensorflow-master/tensorflow/lite/tools/make/downloads/eigen -I/Users/username/tensorflow-master/tensorflow/lite/tools/make/downloads/absl -I/Users/username/tensorflow-master/tensorflow/lite/tools/make/downloads/gemmlowp -I/Users/username/tensorflow-master/tensorflow/lite/tools/make/downloads/ruy -I/Users/username/tensorflow-master/tensorflow/lite/tools/make/downloads/neon_2_sse -I/Users/username/tensorflow-master/tensorflow/lite/tools/make/downloads/farmhash/src -I/Users/username/tensorflow-master/tensorflow/lite/tools/make/downloads/flatbuffers/include -I/Users/username/tensorflow-master/tensorflow/lite/tools/make/downloads/fp16/include -I -I/usr/local/include \
  -o /Users/username/tensorflow-master/tensorflow/lite/tools/make/gen/osx_x86_64/bin/benchmark_model_performance_options /Users/username/tensorflow-master/tensorflow/lite/tools/make/gen/osx_x86_64/obj/tensorflow/lite/tools/benchmark/benchmark_tflite_performance_options_main.o \
   /Users/username/tensorflow-master/tensorflow/lite/tools/make/gen/osx_x86_64/lib/benchmark-lib.a  -lstdc++ -lpthread -lm -lz -ldl
ld: unknown option: --whole-archive
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make: *** [/Users/username/tensorflow-master/tensorflow/lite/tools/make/gen/osx_x86_64/bin/benchmark_model] Error 1
make: *** Waiting for unfinished jobs....

@dtrodrigues
Can you please refer to below issues with similar error. and let us know if it helps
#31190 #30117 #25058 #39025 #29658 #30564 #28988 #26589

None of those are describing the same error. I believe the issue I'm having has to do with clang and the --whole-archive option.

You don't need to use Makefile since bazel is available for MacOS.
You can just use
$ bazel build tensorflow/lite:tensorflowlite

I was able to build it successfully using bazel. However, the Makefile implies that MacOS is an intended target when using plain make: https://github.com/tensorflow/tensorflow/blob/master/tensorflow/lite/tools/make/Makefile#L19 and the other make targets (such as libtensorflow-lite.a and the minimal binary) do build with the Makefile on MacOS -- just not the benchmark target which builds the benchmark_model binary.

Is there an update on this? Is MacOS supported as a make target for tensorflowlite?

Could you check it with master?
I've just checked it. There is an issue with building ruy now.
After reverting the change f15d6e1efc1c52d183882b51acd0ca304f7ba82e, I can run  ./tensorflow/lite/tools/make/build_lib.sh without any error.

I did a fresh checkout and build against master and it looks good now. Thanks!


docker, podman, etc: enable nixosTests on aarch64-linux

Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

@ofborg test cfssl

@ofborg test podman-dnsname

@ofborg test cfssl cri-o docker docker-rootless oci-containers.docker oci-containers.podman podman podman-dnsname podman-tls-ghostunnel traefik


Add "Build a reddit website with Next.JS"

Hope you enjoy

Thanks @frontcodelover for your contribution :)


Copy (Command-C) doesn't work in Visual Block mode

When I try to copy text with Command-C in Visual Block mode, I get a beep sound. It does work in Visual Character or Visual Line mode though. I think in the -copy: method, nvim.get_mode() is returning unknown instead of visual_block?

I think the issue is in to_mode(). If you change the case for visual_block from constant("CTRL-V") to constant("\u0016") it will return visual_mode. "\u0016" is unicode point for Ctrl-V.

Thanks for the bug report and the investigating. Can confirm the issue and that the suggested fix works. Wondering if this has always been broken, or if something changed in Neovim. I will look into it some more to see if any of the other mode strings are also wrong.

Turns out it's been broken this whole time. I misread the docs for the mode() function, didn't realize that the CTRL- characters are one Unicode codepoint. I believe it's fixed now.

Awesome. I'm very impressed with the work you've done. Admittedly, I don't understand most of it so it's a great opportunity to learn. Thanks for sharing it and I look forward to seeing where you take it.


check_subrc: False positive when after else/endif

/zfoobar.prog.abap[4, 3]: Check sy-subrc(check_subrc)
REPORT zfoobar.
DATA ls_t100 TYPE t100.
IF 1 = 1.
  UPDATE t100 FROM @ls_t100. "<<< check_subrc error
ELSE.
  WRITE: 'BAD'.
ENDIF.
IF sy-subrc = 0.  "<<< this is the next statement after UPDATE
  WRITE: 'OK'.
ENDIF.

I'm not sure about this specific example, there is one UPDATE, so the subrc check should be moved inside the IF
However, I think there are good examples for this scenario/bug

I reduced it to a minimum. The real case is actually quite common, I think:
SELECT...
IF sy-subrc = 0.
  UPDATE ...
ELSE.
  INSERT ...
ENDIF.
IF sy-subrc = 0.
  MESSAGE ...
ENDIF.

yeap 👍

also with case:
REPORT zfoobar.
CASE sy-index.
  WHEN 1.
    FIND 'TEST1' IN TABLE lt_code RESULTS lt_results. "<<< check_subrc error
  WHEN 2.
    FIND 'TEST2' IN TABLE lt_code RESULTS lt_results. "<<< check_subrc error
ENDCASE.
IF sy-subrc = 0. "<<<  next statement
  WRITE 'OK'.
ENDIF.


On certain TypeErrors, json-rpc fails to log and responds incorrectly

If application code raises a TypeError, json-rpc doesn't necessarily log the exception and stack trace. Instead, it responds with an "Invalid params" error with code "-32602".
This is also not a correct message in this case because the reason for the error is not invalid parameters sent by the caller.  It is an error in application code.
I believe this issue is due to the exception handling here, where the code bypasses exception logging if the exception has type TypeError. Or perhaps it is due to incorrect logic in is_invalid_params().

Suggestion: instead of the tricky logic in is_invalid_params(), is there any reason you couldn't do something like inspect the depth / level of the stack trace to see where the error is originating? It seems like that may be simpler, or more importantly more robust.

Another option could be to, inside is_invalid_params(), create a function on the fly with the same signature as obtained by inspect.getargspec(func) but with empty body pass. Then you could invoke the function and see if an error occurs. That way you will be using the same rules that Python uses.

@cjerdonek application is supposed to raise exceptions, inherited from JSONRPCDispatchException, so the manager could show a proper message. If an exception is not specified, then here would be a problem as you mentioned. is_invalid_params() could use inspect.getargspec(func). Any pull requests would be highly appreciated.

@cjerdonek application is supposed to raise exceptions, inherited from JSONRPCDispatchException, so the manager could show a proper message.

Okay, I was more referring to the case that arises if there is a bug in the application code, in which case the developer doesn't have control over the exception type. In this case, this issue is causing json-rpc's error handling not to help the developer as much in diagnosing the source of the bug. However, this may be addressable by providing a "catch-all" error handler in the application's code and re-raising with an exception type that json-rpc knows how to handle (so that json-rpc's logging kicks in).
Also, by the way, I believe that the assumptions being checked in is_invalid_params() are failing here and here. If func has signature func(*args, **kwargs), then len(funcargs) will be zero, which will cause the check to fail if the args or kwargs provided by the caller is non-empty.

Was anything decided regarding this? I am running into the same issue, where a TypeError in the application code is being caught and returned as a "Invalid params" error. Our function has a func(*args, **kwargs) signature and hence is_invalid_params() is returning True when it shouldn't.

Sorry for misuse the issue system as a chat ..

..is supposed to raise exceptions, inherited from JSONRPCDispatchException, so the manager could show a proper message.

Question to JSONRPCDispatchException : When I try to use it inside a dispatcher method, I always get a NameError. What I'm doing wrong??
Traceback (most recent call last):
  File "/usr/local/lib/python3.5/dist-packages/jsonrpc/manager.py", line 112, in _get_responses
    result = method(*request.args, **request.kwargs)
  File "webAPIEmulator.py", line 123, in read_registry
    raise jsonrpc.exceptions.JSONRPCDispatchException( -29999, "key not found")
NameError: name 'jsonrpc' is not defined


Dev-scripts

Description
Update scripts to sample with charmff and openff
Todos

[x] Streamline functions for openff and charmff

Status

[ ] Ready to go

Codecov Report

Merging #10 (b41c4e2) into main (c819e39) will decrease coverage by 2.89%.
The diff coverage is 100.00%.

:exclamation: Current head b41c4e2 differs from pull request most recent head 5e894a2. Consider uploading reports for the commit 5e894a2 to get more accurate results


[DNM] Use (feature-flagged) AWS creds endpoint

I don't expect any issues, but this is easy way to confirm that this works with all the ways we rely on AWS creds here.

just remember that I probably need to wait for conda-forge pr before running this


--signoff -> --gpg-sign

The --signoff (or -s) option and the --gpg-sign (also -S) are not interchangeable. We have the right short-cut (-S) but this slide has the wrong long option. I think it's confusing, anyway.
--signoff (or -s) does this:
commit c41aebe7363901aa08e8d48879063432e8617c6a
Author: Joshua Wehner<EMAIL_ADDRESS>Date:   Fri Jan 16 17:10:08 2015 -0600

    testing

    Signed-off-by: Joshua Wehner<EMAIL_ADDRESS>
--gpg-sign (or -S) does this:
commit 78c00b1441e0b1d03ef3271eb1cf6bdec05cb5ff
gpg: Signature made Fri Jan 16 17:11:08 2015 CST using RSA key ID A20F7983
gpg: Good signature from "Joshua Wehner<EMAIL_ADDRESS>Author: Joshua Wehner<EMAIL_ADDRESS>Date:   Fri Jan 16 17:11:08 2015 -0600

    testing

It might be worth re-visiting whether commit signing is a thing we should cover here (because, arguably, signing individual commits is low value, especially compared to tag signing) but that seems like a larger can of worms.

Argh! Can't believe this mistake has been sitting in here so long. It feels great to see all these tuneups coming in.
"re-visiting whether commit signing is a thing we should cover here" -> I'm supportive of moving this to our "extras" file that sits alongside each curriculum file without much risk. It is important to certain large, financial, or government customers we've spoke to recently, but not to many smaller firms.

:shipit:


Re-enable ClusterFuzzLite

Current difficulty: the fake Test.t provided by https://github.com/AdamKorcz/go-118-fuzz-build doesn't implement enough methods.

Closed as not having obvious benefits.


Move Javascript in /pages html files to External File

Currently each of the files in the /pages folder has Javascript to switch the theme.
Move this code to /pages/themeswitcher_subdir.js
Update thankyou.html and omicreativedev.html with the external script
If assigned, please fork immediately.
Comment within 2 days (at least leave a comment) if you haven't done a PR yet.
Resign yourself if you won't get to it so someone else can.??
Be creative.
Read the Docs.
Give a ⭐
Don't break anything. :)

Me.

@Creperi You are assigned.

@Creperi
I saw your previous pull. Nice work.
You don't have to update index.html as it's already done.
We need to just do thankyou.html and omicreativedev.html
Instead of main.js we want to use ./themeswitcher_subdir.js as the filename

Thanks. I was confused.

Anyway i solved the issue


Feature: print --spec output

It looks like you already started to do this in https://github.com/z3z1ma/tap-airbyte/blob/1a9d58c4ebfd4ee04b761d721ed19dc6d968d499/tap_airbyte/tap.py#L77 but it would be awesome if the tap was able to print out the airbyte config spec after an image is defined.
The sources have a --spec flag but I dont know how to access that right now. Since the tap is source agnostic it could be cool to allow someone to configure their source image then run some sort of spec command to list all config options for that source.
Another alternative (if its even possible) is to override the --about output with this info somehow. So given an image the --about output is specific to that image vs the generic top level config options i.e. airbyte_spec/connector_config.

This is done now via image-enhanced --about which required --config is passed too. In the event --config is not passed, about executes its normal non-enhanced behavior. meltano invoke tap-airbyte --about will implicitly pass config under the hood if its populated in meltano yml so most users will be oblivious to the change.

meltano invoke tap-airbyte --about will implicitly pass config under the hood if its populated in meltano yml so most users will be oblivious to the change.

Very slick!!


Edits needed

Add setting up and installation instructions for beginner level understanding
Add easier and more elaborate usage instructions
Structure the README properly
Add issues ranging from beginner to medium-high level
Add license
The contributing.md file doesn't contain any contributing guidelines at all

Working on them

Except the Windows integration for beginners everything has been managed. For the later an issue is being opened.


Fix #718

Haha, nice.
Think it merits a note in the changelog? Like, "Prevent space leak of prepared statements" or something.


Remove decimals from Backend API when unit is CCD

Bug Description
Upon calling backend REST API Ex http://localhost:5000/rest/balance-statistics/latest?field=totalamoununlocked&unit=ccd
The values returned have decimal places. When it should have any decimals.
Steps to Reproduce
Use postman to call the api
http://localhost:5000/rest/balance-statistics/latest?field=totalamoununlocked&unit=ccd
Or
https://api-ccdscan.mainnet.concordium.software/rest/balance-statistics/latest?field=totalamoununlocked&unit=ccd
Expected Result
7514470077
Actual Result
7514470077.45811
Versions

Software Version
OS
Browser
Mobile device, if applicable

I do not understand why this is the expected result. Can you explain why we don't want decimals?

Last information from the meeting today from @coolmagic is that it is unclear whether we want this change or not. Please provide details @coolmagic once they are clear.

@abizjak - This is overall explanation of this req.

Verified OK in Stagenet, on calling API, GET https://stagenet.api.ccdscan.io/rest/balance-statistics/latest?field=totalAmountReleased, result value is without decimal, please refer screenshot below -

Verified OK in Mainnet.


chore(gitsigns): Remove visual mappings from select mode

Hi!
What does this PR accomplish and why is this desirable? Could you please add some flavor text so I can understand what I'm merging?


Should button title tooltips apply to the entire button or just the label/icon?

Is your feature request related to a problem? Please describe.
In https://github.com/opensearch-project/oui/pull/1160, we fixed an issue where icon-only buttons didn't have a tooltip/title attribute to display text on hover. Now that we've fixed that, I noticed that, because the title attribute is only applied to the button content it only activates when hovering directly over the label text or icon. If you hover the part of the button that's mostly padding, you don't get the tooltip hint. See the demo:
https://github.com/opensearch-project/oui/assets/1679762/c286ab6a-a677-4e4b-97a1-4071e88a1ce6
Describe the solution you'd like
I think the tooltip is especially helpful in cases where users aren't familiar with the icon. But it seems like it would be better to trigger/apply it to the entire button, rather than just the contents. @kgcreative any thoughts or preferences from the UX side?

@joshuarrrr @BSFishy you can give me this tot ake a look

I'd like a little more validation that other folks think this is a good idea/worth doing before we invest in it.

for accessibility reasons, it should trigger on hover over the whole button element

Agree on that. Thinking that in terms of UX experience this better for a user


removing margin selector from popover and adding 'dont break out' mixin

@fieldsco review please

[ ] Go to: https://dev-react-ions.herokuapp.com/components/popover
[ ] The popover examples all look 👍
[ ] The top/bottom examples are centered above/below the button


"Not a valid semver version: 2.17" iOS

I have downloaded the app from the App store with the current version on production (2.3)
But always getting needsUpdate : true

What do to here?

Hi! Thanks for that, I thought we already dealt with non-semver versions, but apparently not.
I've just pushed a fix for the server component, it might take a few hours due to caching before it will show the expected response.


Broken build (master & release-2019)

Both master and release-2019 branches currently have broken builds due to dependency conflicts on the cryptography package.  Specifically, pyOpenSSL has bumped their minimum version to 3.2 due to a security concern, but the shell server's setup.py still pins cryptography to 2.9.2.
The automated solution from #480 appears to fix this issue.

Thanks, I had seen that dependabot PR hanging but hadn't had a chance to test it.
Updated cryptography references and also removed the pyOpenSSL dependency since nothing seems to actually require it anymore.


Finding words that are most predictive of a genre

Hi, This was an extremely useful document, and I learnt a lot from the tutorial. An interesting extension to the problem would be to identify the words in the synopses that most distinguish a genre from other genres in the model - I have an analogous task in my project.
Is there a way to find the words that are most predictive of a genre? For example, is there a way to identify that the words ‘battle’, ‘challenge’ and ‘fight’ (for example) are the most predictive of a movie falling into the ‘Action’ category, based on the model we trained? i.e. which are the words (in the synopsis) that most prominently indicate that the synopsis would fall under a particular genre? (Using the model we have fit).
This basically translates to decoding the algorithm to find out how it works “under the hood.” - what features (words?) it uses "under the hood" to classify a synopsis into a genre.
A solution I found online is in the code snippet below - Using the classifier coefficients from clf.coef_ (clf is the name of the model I fit) and picking the top 10 words (which the model uses to distinguish/identify a genre based on a given text).
def print_top10(vectorizer, clf, class_labels):
"""Prints features with the highest coefficient values, per class"""
feature_names = vectorizer.get_feature_names()
for i, class_label in enumerate(class_labels):
top10 = np.argsort(clf.coef_[i])[-10:]
print("%s: %s" % (class_label,
" ".join(feature_names[j] for j in top10)))
Please let me know if this is appropriate and if there is a better way of doing this.

Hi Sachin,
That's a nice problem! I think that the proposed solution will work for an SVM, but not for a deep model which is expected.
For the deep model there's some ways I can think of in which you could "try" to get the words. For example :-

Find samples that the model thinks are action with high probability (say 0.9 threshold or something), then compare it to samples the model does not think of as action. Compare the distribution of words in the two categories to find which ones are "action triggering" so to say.

Another way is to, for each sample, generate different versions by dropping 1 or 2 words and then seeing how the network's predictions change. As it is a model which takes a mean over all word's word2vec representation, it's basically a bag of words. If a word is an "action trigger" word, deleting it from the bag should reduce the network's confidence in thinking that the bag corresponds to the genre Action.

Other ways can be thought of but these would be good starting points.

@sachinsridhar  Were you able to make any progress on this front? Let me know if you need any help!


[SPARK-9103][WIP] Track Netty memory usage - take two

This patch resurrects #7753 by liyezhang556520 and #17625 by jsoltren.
What changes were proposed in this pull request?
Memory reporting is a much desired feature in Apache Spark. This change adds reporting for some memory used by netty. We introduce a new executorMetrics object to track this.
This is a backend only change. No UI is included with this change.
How was this patch tested?
Ran https://github.com/jsoltren/spark-demos/blob/master/src/main/scala/org/soltren/spark/examples/ShuffleGroupCount.scala

Can one of the admins verify this patch?

Jenkins, ok to test

Test build #76148 has started for PR 17762 at commit 550c2d8.

Test build #76148 has finished for PR 17762 at commit 550c2d8.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76148/
Test FAILed.

Merged build finished. Test FAILed.

Jenkins, retest this please

Test build #76197 has started for PR 17762 at commit 550c2d8.

Test build #76197 has finished for PR 17762 at commit 550c2d8.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76197/
Test PASSed.

Merged build finished. Test PASSed.

To close the loop here: I'm going to rework these ideas into a new JIRA that I'll file, to track total memory usage in the UI.


AEM as a Cloud Service support

Is there any level of AEM as a Cloud Service support with Demo Machine?
It would be helpful to have the support/lack of support documented.

Yes, I had it ready and forgot to push....