make codegen doesn't work outside of GOPATH

Repro:

clone the repo to somewhere outside of GOPATH
update some types.go to add a field, etc.
make codegen (succeeds)
deepcopy code isn't updated -- if you push a PR in this state, CI will fail (example)

This is using controller-gen v0.7.0, and ultimately I think it's a bug on their end.
We could either have make codegen detect you're not in GOPATH and fail more loudly, or do something like have it use a temp directory, make it GOPATH, do codegen and copy the result back to the original location.

I fixed this upstream. Couldn't fix it in our fork of kcp due to hack/update-vendor.sh issues. I think I know how to work around those, though.


test(installer): update snapshot testing

Snapshot Tests not updated in release

@erwaxler , @bo1984 - if I can be troublesome, can this please be looked at?
As it is using pull_request_target as the event, it clones from main and not my feature branch. Therefore, I can never fix this test!

Hey @richardkeit , thanks for creating this! I will get this reviewed and merged into the code base internally. I will also follow-up on:

Fixing the bug that allowed the snapshot to remain using v1.9.1
Updating the GitHub action tests to use the source branch commit

Thanks as always for your continued support it is very much appreciated!

Assume this can be closed @erwaxler


while preloading modules view will be struck

"@angular/animations": "^6.0.3",
"@angular/common": "^6.0.3",
"@angular/compiler": "^6.0.3",
"@angular/core": "^6.0.3",
"@angular/forms": "^6.0.3",
"@angular/http": "^6.0.3",
"@angular/platform-browser": "^6.0.3",
"@angular/platform-browser-dynamic": "^6.0.3",
"@angular/router": "^6.0.3",
"@angular-devkit/build-angular": "~0.6.6",
"@angular/cli": "~6.0.7",
"@angular/compiler-cli": "^6.0.3",
"@angular/language-service": "^6.0.3",
am using above packages
i have around 10 modules each module contains atleast of 25-30 components with very high complexity each component contains around 1500 lines of code, while preloading all the modules the login view will be struck m unable to fill the login credentials until it load all the module..
please add this feature..
please preload the modules background so that we can do our work on current view..

Hello @adityarw,
You file many similar issues on our repo. This is the fifth identical issue like this.
That behavior is abusive and costs us time. Please stop filing issues that are unactionable, do not follow the issue template, and are identical with your other issues, or else we will prevent you being able to interact with our project in the future.
Thanks!

Hello @alexeagle,
few months back it was accepted but now you are saying this is not come under your section, no problem.
sorry for making you to waste your time. No more issue will come on this topic on this.
Bug is always a bug you can't ignore.
I more thing one or other day you'll definitely work on my issue.
thanks for looking at my issue and support..
Buh-bye => while preloading modules view will be struck..


Implement up and down vote of issues using GitHub Reactions for bounty system.

Please vote on this first test issue for bounty payment.
Bounty Level: Important
Complexity: Medium
Bounty: 10 Ada
Increase increment: 1 week

hmm ... seems github allows both upvote and downvote from the same person ... probably not an issue as someone would basically cancel their own vote out

@kewlniss It seems that way - it's not an ideal method but it'll serve it's purpose for the time being. Thanks for testing it out everyone very much appreciated.

I've created a SS to track bounties. https://docs.google.com/spreadsheets/d/11vywFU4wEh_7aHnBwIL4NHKgXLYKu9MWurICNyloToM/edit#gid=0

Bounty updated to 50 Ada to reflect work undertaken. Discussion here: https://discord.com/channels/756943420660121600/815296407141220383/873290561619111977

Work is progressing, there was a break due to 2 weeks holidays.


minor release for new quay.io migtool image location.

minor release (1.8.0) with modified location of the Pelorus Quay images.
Current location for the four exporters:
https://quay.io/repository/migtools/pelorus-committime-exporter
https://quay.io/repository/migtools/pelorus-deploytime-exporter
https://quay.io/repository/migtools/pelorus-failure-exporter
Experimental exporter:
https://quay.io/repository/migtools/pelorus-releasetime-exporter
Signed-off-by: Michal Pryc<EMAIL_ADDRESS>@redhat-cop/mdt

/retest


Upgrade to PyTorch 2.2

Fixes https://github.com/Lightning-AI/lit-gpt/issues/911
Since there are no breaking changes, existing torch 2.1 environments will be able to still run without issues, but we want to suggest 2.2 going forward for Flash attention 2 and compile improvements

@carmocca when repo support flash attention 2?

Since this PR. You just need to install PyTorch 2.2


BUG: Scipy stats probability greater than 1

Describe your issue.
I am computing values of a binomial probability mass function and find that their sum exceeds 1 when passing extreme parameters to the pmf. stackoverflow question. No error is thrown, meaning the problem could easily go unnoticed.
Reproducing Code Example
from scipy.stats import binom
n =<PHONE_NUMBER>225563.0
p = 1.0477878413173978e-18
vals = [binom.pmf(n=n, p=p, k=i) for i in range(3)]
print(vals)  # -> [0.9983865609638467, 1.0, 0.060730098812886574]

Error message
.

SciPy/NumPy/Python version information
1.5.3 1.18.5 sys.version_info(major=3, minor=6, micro=9, releaselevel='final', serial=0)

A few versions ago, we replaced the implementation of binom.pmf with that of Boost. Now (in 1.9.1):
[1.0, 0.0016121367428128667, 1.3015924788782256e-06]

The sum is still greater than 1, but it's better.
It is possible to improve the accuracy of the calculation for k=0:
np.exp(binom.logpmf(n=n, p=p, k=0))  # 0.9983865609638467

But this strategy is poor for k=1.
np.exp(binom.logpmf(n=n, p=p, k=1)) #<PHONE_NUMBER>038472

If someone can reproduce this problem in C++ w/ Boost, it would be better to post this issue upstream.
In the meantime, note that we cannot guarantee the results of all distributions to floating point precision for all possible inputs. When working with extreme parameters, consider using arbitrary precision arithmetic (e.g. mpmath).

Thanks for the quick reply! Good to hear this is improved upon in newer versions. Interestingly, vals[0] is the one value that actually seems to be very close to accurate in the old version - I am surprised that one appears to be worse in the new one.
The new logpmf implementation you suggested looks like quite an improvement. I cannot tell if it would have any drawbacks for other values of n and p, but perhaps there are tests for that.
Seems like it would be a great change overall, and might save some people from accidentally ending up with funky variance values, especially since there is no error!
I will be switching between binom and poisson for my case, thanks for the suggestion!

Thanks for the report, @vincentvalton.  Unlike the OP, which seems to be a limitation of the numerical calculations when some of the parameters are extreme, the issue that you report is a pretty clear bug.  The probability mass function should take on nonzero values only at the integers in the support.  Could you create a new issue with this report?  It really is a different issue than the OP.

Thanks for the report, @vincentvalton. Unlike the OP, which seems to be a limitation of the numerical calculations when some of the parameters are extreme, the issue that you report is a pretty clear bug. The probability mass function should take on nonzero values only at the integers in the support. Could you create a new issue with this report? It really is a different issue than the OP.

Thanks @WarrenWeckesser, I've opened a bug report here: https://github.com/scipy/scipy/issues/17167#top

See: https://github.com/boostorg/math/pull/847.
I used @mdhaber suggested test values, and now we have the correct values and a sum <= 1.

Fix has been merged into Boost.Math. Let me know if you need anything else.


Helm chart does not allow "falsey" value in cmdOptions

What version of descheduler are you using?
descheduler version: v0.29.0
Does this issue reproduce with the latest release?
Yes
What did you do?
Tried to deploy the helm chart with cmdOptions.v equal to 0.
What did you expect to see?
The descheduler started with --v=0.
What did you see instead?
The descheduler started with --v.
Root Cause
This line is incorrect as it is not possible to provide a "falsey" value such as 0.

/assign


Overriding the HTMLCanvasElement prototype breaks layer rendering

Describe the bug
A more specific follow-up to #13117
To Reproduce
Although the problem seems to manifests itself only if preserveDrawingBuffer is set (regardless of whether OpenLayers provides an option an application can do that by overriding the HTMLCanvasElement prototype) this seems like a design flaw.  With layers sharing a context and the base layer fully opaque there is no problem https://codesandbox.io/s/simple-forked-novjn?file=/main.js  But if a layer which has some opacity such as a heatmap has its own context (e.g. change WebGLTile to Tile, or change the className of one of the layer) when panning the heatmap is redrawn over its previous image.  #12965 removed a gl.clear() call from the WebGLPostProcessingPass apply method, which makes sense when layers share a context, but should that now be replaced by clearing the context at the start of a render cycle?
Expected behavior
As before #12965, i.e. no ghosting from the previous image.

Fixed in #13126


Ubuntu 20.04: Harfbuzz version too old

(justmd:6251): Pango-ERROR **: 00:00:46.346: Harfbuzz version too old (1.4.2)
Will there be an updated version of justmd, or is the development stopped?

When did you see this error?

I saw this in September 2020 and also today, April 29th 2021. My system is GNU/Linux, distribution Xubuntu 20.10.

It seems that higher versions of linux are not downward compatible with lower versions of electron, here is a temporary solution：
https://github.com/electron/electron/issues/20348#issuecomment-635378964
I'll try to update to a new version of electron in a later release and maybe fix this issue as well.

v1.2.1 works on Xubuntu 21.04, thanks for updating!


Sticky Scroll: Adding height and emitter for height change event

for NES change

Thank you @aiday-mar !


Close button displayed under status bar on iPhone 14 Pro with dynamic island

Hello the Google Ads Team !
Unfortunately, some (not all) ads displayed on the new iPhone 14 Pro with the dynamic island have the close button stuck under the status bar. As a result, the user cannot close the ad and this makes the application completely inaccessible.
No error logs come up, even when overriding modalPresentationCapturesStatusBarAppearance.
Tested on iOS 16.0, with the latest release of Google Mobile Ads -> 9.11.0.
Some examples:

Screenshot 1
Screenshot 2

I am looking for a solution very quickly, thank you very much in advance.
Best regards,
Sascha Salles

Hi,
I have same issue in my applications. I found one solution. It's not perfect but it works.
You can hide status bar before show the ad and after when ad dismissed you can show status bar again. I can close ads like this.
if UIDevice.current.checkIfHasDynamicIsland() {
UIApplication.shared.isStatusBarHidden = true
}

Closing as this issue is not directly related to the swift-package-manager. If your issue still persists, please report your issue on the AdMob Developers Forum.


[DEFECT] Basic statistics results not fully reported

Defect Description
Using the statistical postprocessor Basic statistics, after the creation of a database (in our case using MELCOR with the input attached, but I think that the same defect is with other interfaces) the results are not fully reported. In particular, the results from the second point (0 s is reported) to 5000 s are not present in the output file (basicStatHistory_0.csv).
What did you expect to see happen?
This error begins after the end of the synchronization of the history sets, because the Synced CSVs are not affected by this problem (data from 0 to 5000 s reported).
What did you see instead?
BasicStatHistory_0.csv file does not contain the data from 0.. s to 5000 s.
Do you have a suggested fix for the development team?
Describe how to Reproduce
Steps to reproduce the behavior:

to create a database with any interface
to run a post input including the BasicStatistics
the obtained basicStatHistory_0.csv contains the output with the defect

Screenshots and Input Files
Please attach the input file(s) that generate this error.  The simpler the input, the faster we can find the issue.
Platform (please complete the following information):

OS: CENTOS
Ve

rsion: 7.9

Dependencies Installation: CONDA

For Change Control Board: Issue Review
This review should occur before any development is performed as a response to this issue.

[ ] 1. Is it tagged with a type: defect or task?
[ ] 2. Is it tagged with a priority: critical, normal or minor?
[ ] 3. If it will impact requirements or requirements tests, is it tagged with requirements?
[ ] 4. If it is a defect, can it cause wrong results for users? If so an email needs to be sent to the users.
[ ] 5. Is a rationale provided? (Such as explaining why the improvement is needed or why current code is wrong.)

For Change Control Board: Issue Closure
This review should occur when the issue is imminently going to be closed.

[ ] 1. If the issue is a defect, is the defect fixed?
[ ] 2. If the issue is a defect, is the defect tested for in the regression test system?  (If not explain why not.)
[ ] 3. If the issue can impact users, has an email to the users group been written (the email should specify if the defect impacts stable or master)?
[ ] 4. If the issue is a defect, does it impact the latest release branch? If yes, is there any issue tagged with release (create if needed)?
[ ] 5. If the issue is being closed without a pull request, has an explanation of why it is being closed been provided?

test.zip
@wangcj05 Here attached the test input and the synced data

@gianfabi Thanks for the input files. I have checked the input file and your SyncedData. The following is what I found:

There is no corresponding input parameter in your SyncedData (please check your file: SyncedData.csv)

You have requested input parameters "%CHI%,%GAM%,%FSL%,%STI%,%TUR%,%TKG%,%FTH%,%DEL%,%SC11321%,%SC11312%" that you want to perform the statistics analysis:

The code will error out with the following message:

My guess is that you do not generate the SyncedData correctly. Please check your calculation flows, or you can attach the Database so that I can run the whole case.

Hi @gianfabi, do you have a chance to take a look at my comment regarding this issue? Do you still have the problem with this issue?

Dear Congjian,
Regarding the Basic statistics results not reported in the first 5000 s,
this issue was present in all the cases with any input. I'm not able to
share with you all the database but in theory Andrea resolved the issue.
Thank you
Fabio
Il ven 23 apr 2021, 05:15 Congjian Wang - INL @.***> ha
scritto:

Hi @gianfabi https://github.com/gianfabi, do you have a chance to take
a look at my comment regarding this issue? Do you still have the problem
with this issue?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/idaholab/raven/issues/1509#issuecomment-825356414,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AGQBR7YGTOEP6RJXBQPXOE3TKDQ55ANCNFSM42X4VMTQ
.

--

Le informazioni
contenute in questo messaggio di posta elettronica sono strettamente
riservate e indirizzate esclusivamente al destinatario. Si prega di non
leggere, fare copia, inoltrare a terzi o conservare tale messaggio se non
si è il legittimo destinatario dello stesso. Qualora tale messaggio sia
stato ricevuto per errore, si prega di restituirlo al mittente e di
cancellarlo permanentemente dal proprio computer.
The information contained
in this e mail message is strictly confidential and intended for the use of
the addressee only.  If you are not the intended recipient, please do not
read, copy, forward or store it on your computer. If you have received the
message in error, please forward it back to the sender and delete it
permanently from your computer system.
--
Fai crescere i nostri giovani ricercatori
dona il 5 per mille alla
Sapienza
codice fiscale<PHONE_NUMBER>7

@alfoa Can this issue be closed?

@aalfonsi Can you comment on this issue?

archived


Migrate to new Html.Attributes.style API

This will be tested in 0.19 alpha, but potentially
style : List (String, String)

will become
style : String -> String -> Attribute

Fixed in 0.19.0-rc8


User1

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

all looks good thank you


Update Prettier to 2.3

Codecov Report

Merging #600 (7d64a96) into master (0d4dbc1) will decrease coverage by 0.19%.
The diff coverage is 42.85%.

:exclamation: Current head 7d64a96 differs from pull request most recent head 1e1e37c.


Bounding box should not accept 5 elements.

In the Model 2D, if the bounding box contains 5 coordinates, an exception is not raised while it should be.
https://github.com/pyansys/pyaedt/blob/42cd90e24cf3876f7c7f6818156d51559602276d/pyaedt/modeler/Model2D.py#L159

@gmalinve

@Samuelopez-ansys This was fixed in #1305 .
I updated the comment of the pull request to link it with this issue.
Thanks.


Add addtional data sections to configurations endpoint

Context
Add the following data to the configurations endpoint:
reporting frequency
unit capcity
unit control
unit fuel

Need to have more discussion on if this ticket is still needed

Based on 9/25 DSU need to have a discussion on adding more data to the configuration endpoint.The configuration endpoint is already performing slow. Need to have a discussion on splitting up the endpoint

@djw4erg This ticket is ready for your review

@djw4erg tested and verified.


create scripts for auto deploy

Please describe your feature request:
Create script for auto deploy instances in AWS and others like a this project https://github.com/Leoid/AWSBurpCollaborator
Describe the use case of this feature:
minimize implementation times, in addition to the fact that the margin of error would decrease for newer users.

Have already done something like that.
Interactsh deployment to AWS EC2 Instance with Terraform:
https://github.com/denniskniep/interactsh_deploy
Furthermore nameserver IP at Go Daddy will be automatically refreshed on (re)deployment


Feature/rtodling/add background 12aug2022

This brings the ability use real background in BCLIM - until now only use of a mock background was allowed.
This works for a simple case in the GMAO grid. There are still puzzles associated w/ the GFS grid. They will be tackled in a follow up update.
This also allows proper use of Q, and Ozone.
I am updating the issues tab to list the known pending issues.

One this is on develop I will tag it with a version number.


Added cluster link and unlink subcommands.

Also added a helper function to allow names when choosing a cluster, IsUniqueCluster(name string).

I think it would make sense to have a cluster linker client in its own package, or as part of the Client from the dcos package, as the API will be used in other places too. dcos cluster attach and dcos cluster list also depend on this API (linked clusters appear in the list and it is possible to attach to a linked cluster, this would trigger a setup using the login provider registered in the link).


Image Tagging Chrome Extension

Project Name
Auto Tagging images - Chrome Extension
Check for Existing Projects
Check in the Auto Tagging Image folder in the repo that whether the extension your are trying to built is already implemented.
Project Description
Given an image input this tool should generate a set of tags for that image. You can create your own models and use them to create a web based interactive tool or you can even use APIs from hugging face or other open-source models.
Project Type:

NLP, Text processing
Image generation

Mention the technology stack, and how your are going to go through with this project.

can i give this a try

Sure @UtkarshUmre give it a try! Let me know if you have any doubts. You can also take a project already available in the repo https://github.com/yagyesh-bobde/GenAI-Projects/tree/main/Auto-Image-Tagger


Add crumb support

This would apparently solve JENKINS-14372. It would be great if this could be merged since it's pretty bad security-wise that you're not able to enable CSRF protection if you want to use the build-publisher-plugin.

This change is

@ermshiperete Would it be better to cache the crumb headers by hudson instance?
so that no need to get crumbs per request

    private static Header getCrumbHeader(HudsonInstance hudsonInstance, HttpClient client) {
        Header crumbHeader = crumbCache.get(hudsonInstance);
        if(crumbHeader != null) return crumbHeader;
        String crumbProvider = hudsonInstance.getUrl() + "crumbIssuer/api/json";
        GetMethod method = new GetMethod(crumbProvider);

        try {
            client.executeMethod(method);
            String result = IOUtils.toString(method.getResponseBodyAsStream(), "UTF8");
            JSONObject js = JSONObject.fromObject(result);

            crumbHeader = new Header(js.getString("crumbRequestField"), js.getString("crumb"));
            crumbCache.put(hudsonInstance, crumbHeader);
        } catch (Exception e) {
            // If getting the crumb fails disable crumb support. Not all instances have crumbs enabled
            useCrumbs = false;
        } finally {
            method.releaseConnection();
        }

        return crumbHeader;
    }

Sure, if that works then it might be better.

@ermshiperete I tried that, but it didn't work properly. I don't know why the crumb header changed irregularly. On my browser, I got the same crumb every time.


[Support] What's the equivalent feature of ControlNet "Reference-only Control" in SwarmUI?

There is a new "reference-only" preprocessor months ago, which work really well in transferring style from a reference image to the generated images without using Controlnet Models: https://github.com/Mikubill/sd-webui-controlnet/discussions/1236
Is there equivalent feature of such "Reference-only Control" in SwarmUI?

Newer "reference_adain" and "reference_adain+attn" processors:
https://github.com/Mikubill/sd-webui-controlnet/discussions/1280

ReVision/IPAdapter are the modern versions.
There's a custom comfy node made by comfy himself lol for ReferenceOnly if you want it: https://github.com/comfyanonymous/ComfyUI_experiments/blob/master/reference_only.py
I could import to a proper feature in swarm if there's a reason to use it over the other options?

Hmm, I'm not sure how to explain, but I see different effects for each of them.
Reference-Only seems to me more easy, promising, adopting Latent Diffusion architectural approach, may be more close to Comfy structural approach? I like its simplicity, effectiveness and less prone to create artifacts.
ReVision/IPAdapter took some time to tune them to the best, slightly more advanced usage, but may require some trial & errors.
Not sure how much better for newer "reference_adain" and "reference_adain+attn" processors: https://github.com/Mikubill/sd-webui-controlnet/discussions/1280

So the comfy node doesn't even actually work apparently.
Gonna close this as "upstream from swarm" ie someone has to implement it properly in Comfy before it can be implemented into swarm

Update: after followup in another thread recently, Reference Only is available now!

I've enabled ReferenceOnly via comfy's experiment code (slightly adapted), with a new Use Reference Only param under ReVision (ie drag an image to prompt box and it will be included as an option)


raspi doesn't work consistently

I'm using raspi to control a motor but the module doesn't always connect to the motor.
I've made a test script which runs perfectly every time, but when I implement the code on server it doesn't always connect
Test script that works everytime
const raspi = require('raspi');
const PWM = require('raspi-pwm').PWM;
let speed = 9 ;
if(process.argv[2] ){
    speed = Number(process.argv[2])
    console.log('Speed ',speed);
    raspi.init(() => {
      let pin2 = 'GPIO13';
      const pwm2 = new PWM(pin2);
      pwm2.write(speed); // Center a servo
      console.log('speed On GPIO13 : ',speed);
    });
}else{
  console.log('fail')
}

server code
const raspi = require('raspi');
const PWM = require('raspi-pwm').PWM;
let pwm12,pwm13,pwm18;
let self = {
    init: () =>{
        raspi.init(() => {
            pwm12 = new PWM('GPIO12');
            pwm13 = new PWM('GPIO13');
            pwm18 = new PWM('GPIO18');
            self.motorsArr.push(pwm13);
            self.motorsArr.push(pwm12);
            self.motorsArr.push(pwm18);
            console.log(self.motorsArr[1]);
        });}
    throttle: (dutyCycle) {
        pwm13.write(dutyCycle);
}
}

Sometimes though it works after closing and reopening the terminal

Ah, the issue is that you're trying to drive 3 PWM motors using 2 PWM ports. It's kinda confusing, but GPIO12 and GPIO18 are both tied to PWM0, and GPIO13 and GPIO19 are both tied to PWM1. If you want to use three pins as PWM, you'll need to set enableSoftPwm to true in the Raspi IO constructor.

I'm new to this, so can you please show a small snippet or point me to some examples

Ack, sorry, I just realized you're not using Raspi IO, which is how most folks use this library instead of using it directly. OK, so ignore what I said above, sorry about the confusion 😅
Instead, what you'll need to do is use the raspi-soft-pwm so that you can use more than two PWM pins at a time. Try this:
const raspi = require('raspi');
const PWM = require('raspi-soft-pwm').SoftPWM;
let pwm12,pwm13,pwm18;
let self = {
    init: () => {
        raspi.init(() => {
            pwm12 = new PWM('GPIO12');
            pwm13 = new PWM('GPIO13');
            pwm18 = new PWM('GPIO18');
            self.motorsArr.push(pwm13);
            self.motorsArr.push(pwm12);
            self.motorsArr.push(pwm18);
            console.log(self.motorsArr[1]);
        });
    },
    throttle: (dutyCycle) => {
        pwm13.write(dutyCycle);
    }
}

Note: raspi-soft-pwm emulates PWM using some clever memory tricks on the Raspberry Pi. It works just fine for servo motors, but you will see slightly increased CPU usage.

Thank you. But can you add a terminate() like function like the pigpio library has. I think problem was caused by the pigpio C library not terminating when my script terminates

Thank you. But can you add a terminate() like function like the pigpio library has. I think problem was caused by the pigpio C library not terminating when my script terminates

Sorry for the delay, I've been at Burning Man and offline for a long time. Can you clarify what behavior you're seeing that makes you think the above is happening?
The way we're using pigpio, it terminates as soon as the Node process does, because we're not using the daemon and it runs in the same process. There's nothing that keeps on running, but perhaps something is being left in a state you wouldn't expect?


Error on FirebaseESP32.cpp str.erase(std::remove

Hi, i'm having the following error message when i compile my project:
...\Arduino\libraries\Firebase-ESP32-master\src\FirebaseESP32.cpp: In member function 'std::__cxx11::string FirebaseESP32::trim(std::__cxx11::string&)':
...\Arduino\libraries\Firebase-ESP32-master\src\FirebaseESP32.cpp:2030:13: error: 'remove' is not a member of 'std'
str.erase(std::remove(str.begin(), str.end(), '\r'), str.end());
I have commented the lines  2030 and 2031. Doing this i can compile and download. Everything seems to be ok with that.
mobizt Thaks for this amazing work you did and for sharing this great lib with us

You're welcome and thank you for let me know.
I will fix this in the next update.

I just update to version 2.3.3. Do you still get error when set data?

I just update to version 2.3.3. Do you still get error when set data?

Now everything works fine. Thanks again. Have a good day!


Moving the IServiceCollection extension into Microsoft.Framework.Depende...

...ncyInjection namespace
Fixes: https://github.com/aspnet/Routing/issues/160

@rynowak @muratg

:shipit:

:shipit:


Setting up template to use 1ES hosted pool.

This PR modifies the Python pipelines to use the 1ES hosted pools for WIndows/Linux build/test legs. It has a few aspects:

Change to the stage template to define a WindowsPool and LinuxPool.
Change to the job template to define a WindowsPool and LinuxPool
Maps WindowsLinux and LinuxPool to variables in the test job so that they can be used in the matrix.

/azp run python - core - ci

/azp run python - core - ci

/azp run python - core - ci

/azp run python - core - ci

/azp run python - storage

/azp run python - storage

/azp run python - cosmos

/azp run python - cosmos


heptio-ark: 0.9.0 -> 0.9.4

Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[x] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build heptio-ark

Success on aarch64-linux (full log)
Attempted: heptio-ark
Partial log (click to expand)
shrinking RPATHs of ELF executables and libraries in /nix/store/530lp55wnqax51grfcp9r50d20c01k5h-heptio-ark-0.9.4-bin
shrinking /nix/store/530lp55wnqax51grfcp9r50d20c01k5h-heptio-ark-0.9.4-bin/bin/ark-restic-restore-helper
cannot find section .dynamic
shrinking /nix/store/530lp55wnqax51grfcp9r50d20c01k5h-heptio-ark-0.9.4-bin/bin/ark
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/530lp55wnqax51grfcp9r50d20c01k5h-heptio-ark-0.9.4-bin/bin
patching script interpreter paths in /nix/store/530lp55wnqax51grfcp9r50d20c01k5h-heptio-ark-0.9.4-bin
checking for references to /build in /nix/store/530lp55wnqax51grfcp9r50d20c01k5h-heptio-ark-0.9.4-bin...
cannot find section .dynamic
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip

Success on x86_64-darwin (full log)
Attempted: heptio-ark
Partial log (click to expand)
find: '/nix/store/2hb23nzgqjmxrhrv5nsdga4pbjq0dwa7-heptio-ark-0.9.4': No such file or directory
find: '/nix/store/2hb23nzgqjmxrhrv5nsdga4pbjq0dwa7-heptio-ark-0.9.4': No such file or directory
find: '/nix/store/2hb23nzgqjmxrhrv5nsdga4pbjq0dwa7-heptio-ark-0.9.4': No such file or directory
find: '/nix/store/2hb23nzgqjmxrhrv5nsdga4pbjq0dwa7-heptio-ark-0.9.4': No such file or directory
find: '/nix/store/2hb23nzgqjmxrhrv5nsdga4pbjq0dwa7-heptio-ark-0.9.4': No such file or directory
find: '/nix/store/2hb23nzgqjmxrhrv5nsdga4pbjq0dwa7-heptio-ark-0.9.4': No such file or directory
find: '/nix/store/2hb23nzgqjmxrhrv5nsdga4pbjq0dwa7-heptio-ark-0.9.4': No such file or directory
find: '/nix/store/2hb23nzgqjmxrhrv5nsdga4pbjq0dwa7-heptio-ark-0.9.4': No such file or directory
find: '/nix/store/2hb23nzgqjmxrhrv5nsdga4pbjq0dwa7-heptio-ark-0.9.4': No such file or directory
/nix/store/i0d3xbzpavj658afgz2cxiqk6z8nw01y-heptio-ark-0.9.4-bin

Success on x86_64-linux (full log)
Attempted: heptio-ark
Partial log (click to expand)
shrinking /nix/store/rm17v7r3a52nxxcscwvlijb595n7aygl-heptio-ark-0.9.4-bin/bin/ark-restic-restore-helper
cannot find section .dynamic
shrinking /nix/store/rm17v7r3a52nxxcscwvlijb595n7aygl-heptio-ark-0.9.4-bin/bin/ark
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/rm17v7r3a52nxxcscwvlijb595n7aygl-heptio-ark-0.9.4-bin/bin
patching script interpreter paths in /nix/store/rm17v7r3a52nxxcscwvlijb595n7aygl-heptio-ark-0.9.4-bin
checking for references to /build in /nix/store/rm17v7r3a52nxxcscwvlijb595n7aygl-heptio-ark-0.9.4-bin...
cannot find section .dynamic
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
/nix/store/rm17v7r3a52nxxcscwvlijb595n7aygl-heptio-ark-0.9.4-bin


Django tests and linking

Please add a description. It's not clear what the task is.

Yea this does thank you


[SR SQL Planner Summer Camp] anltr4 for showCreateDbStmt

Signed-off-by: zombee0<EMAIL_ADDRESS>What type of PR is this：

[x] ShowCreateDbStmt

Which issues of this PR fixes ：

Fixes #7947
Problem Summary(Required) ：

Antlr4 for ShowCreateDbStmt

[FE PR Coverage check]
:heart_eyes: pass : 15 / 16 (93.75%)
file detail

path
covered line
new line
coverage

:large_blue_circle:
com/starrocks/sql/analyzer/PrivilegeChecker.java
4
5
80.00%

:large_blue_circle:
com/starrocks/sql/parser/AstBuilder.java
2
2
100.00%

:large_blue_circle:
com/starrocks/sql/ast/AstVisitor.java
1
1
100.00%

:large_blue_circle:
com/starrocks/sql/analyzer/ShowStmtAnalyzer.java
4
4
100.00%

:large_blue_circle:
com/starrocks/analysis/ShowCreateDbStmt.java
4
4
100.00%

[FE PR Coverage check]
:heart_eyes: pass : 15 / 16 (93.75%)
file detail

path
covered line
new line
coverage

:large_blue_circle:
com/starrocks/sql/analyzer/PrivilegeChecker.java
4
5
80.00%

:large_blue_circle:
com/starrocks/sql/parser/AstBuilder.java
2
2
100.00%

:large_blue_circle:
com/starrocks/sql/ast/AstVisitor.java
1
1
100.00%

:large_blue_circle:
com/starrocks/sql/analyzer/ShowStmtAnalyzer.java
4
4
100.00%

:large_blue_circle:
com/starrocks/analysis/ShowCreateDbStmt.java
4
4
100.00%

[FE PR Coverage check]
:heart_eyes: pass : 15 / 16 (93.75%)
file detail

path
covered line
new line
coverage

:large_blue_circle:
com/starrocks/sql/analyzer/PrivilegeChecker.java
4
5
80.00%

:large_blue_circle:
com/starrocks/sql/parser/AstBuilder.java
2
2
100.00%

:large_blue_circle:
com/starrocks/sql/ast/AstVisitor.java
1
1
100.00%

:large_blue_circle:
com/starrocks/sql/analyzer/ShowStmtAnalyzer.java
4
4
100.00%

:large_blue_circle:
com/starrocks/analysis/ShowCreateDbStmt.java
4
4
100.00%


Hotfix/issue-788

Fix for Issue #788

This change is

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


chore: true up logger comments and minor refactors

Description
Fix some comments that weren't updated when logger From was simplified and shuffle some impl. details around for readability, flow, vibes etc.
Checklist before merging

[x] Test, docs, adr added or updated as needed
[x] Contributor Guide Steps followed

Cleanup related to #3210


Precomputed specs to allow easy creation of new scales

A list of scales to be created would be provided as a separate argument
Optional reference scale would default to MIP0. (@trivoldus28 I was wrong before, having a reference scale would be useful in many scenarios)
chunk_size, dataset_size, and voxel_offset maps could be used to specify small deviations from the reference scale

Questions:

What if both new scale list and info_field_overrides: {'scales': ...} are provided? Should an exception be thrown, or should the new scales be created on top of the initial scales provided by the overrides?

Thanks for making the issue @supersergiy . I'm gonna write up some draft examples of how the interface is going to be like and yea I think having a ref scale would be useful. I'll take a look of how info_field_overrides are being used first tho to cover most common use cases.
On handling info_field_overrides with scales specified, I think we should just throw an exception for now unless it's useful to merge it and adding scales.

size, voxel_offset, key are the keys that are directly linked to resolution. At least during our current alignment and segmentations steps, the shrink factor is always [2,2,1]. For the final render step, we sometimes downsample in z as well to keep voxel size isotropic. chunk_sizes often stays the same across scales.
Ideally we would check that for all the requested scales, the reference values make sense.
E.g. requesting 3 scales with a voxel_offset of 30 at scale 0 will cause issues with the visualization at scale 3, because the image suddenly jumps half a pixel

Example of what I think could work:

{
    "@type": "build_cv_layer"
    path: #DST_PATH
    ref_info: ...

    // add_scales_ref can either be a dictionary
    add_scales_ref: {
        "key": "4_4_40",
        "resolution": [4, 4, 40],
        "chunk_sizes": [32, 32, 1],
        "encoding": "raw",
        "size": #OUTPUT_SIZE,
        "voxel_offset": [0, 0, 0]
    }
    // Or an existing key from `ref_info` from which the dict will be copied from
    // Throws an error if `ref_info` is not provided
    add_scales_ref: "4_4_40"

    // Example adding 3 scales
    add_scales: [
        {
            // full specs for this scale
            "key": "8_8_80",
            "resolution": [8, 8, 40],
            "chunk_sizes": [32, 32, 1],
            "encoding": "raw",
            "size": #OUTPUT_SIZE,
            "voxel_offset": [1, 2, 3]
        },

        {   // Fill in missing parameters using defaults. We check info_xxx_size/offset/_map for values.
            // We get values from `add_scales_ref` (with `size` & `offset` scaled proportionally to resolution) if avail.
            // Error cases:
            // 1. No values are available.
            // 2. Conflicting values.
            // 3. Values are not integer after scaling.
            // To resolve, just provide the errored parameters here.
            "key": "16_16_40",
            "resolution": [16, 16, 40],
        },

        [32, 32, 40],  // shorthand, equivalent to `{"key": 8_8_40, "resolution": [8, 8, 40]}`
        ]
}

@supersergiy Could also try setting the default scale to be mip0 but I wonder if it's better to not and let the user be more explicit. For one, theoretically there could be multiple keys with the same res right?

I'm still thinking there could be pitfalls with defaulting the ref scale to mip0. For instance, if the user adds a higher res scale on the first run, the next run may not be consistent to the first run.
As a middle ground we can let the user specify add_scales_ref: "mip0".

I would also appreciate not having to write and support a function to determine what is MIP0 ;). Maybe add_scales_ref: "mip0" can be a reach goal for later after the first implementation.

Fixed via #511

@trivoldus28 if you include Fixes #{Issue number in the PR text, it will automatically close the issue as complete on PR merge [reference]


Fix SPM support

Current Package.swift was broken, so I fixed it

While I'm not a huge fan of hiding all the UIKit code from SwiftPM to make it accept the package, I don't see any other way right now.
Until SwiftPM implements platform restrictions for packages (and that's probably not coming soon, I could not find any discussion on this topic) I'd say let's roll with that.
So +1, clever trick and seems to work well, thank you @MortyMerr !
I'd love to see this PR merged ☺

I guess it should be obvious from library description)
Sent with GitHawk

Thanks a lot for attention
Sent with GitHawk

I'm gonna merge this as it as it's usable but I wonder if in a subsequent PR it would make sense to add some #error "This library only supports UIKit" in the #else branch 🤔 😉

@AliSoftware Haven't tested it, but I suppose it would defeat the purpose of this PR as SPM would choke on the #error when trying to compile the package (it seems Xcode's SPM integration tries to compile the dependencies with macOS as the target, hence the UIKit error).


Add exclude feature

It would be good if pronto can omit some files based on glob patterns, such as db/schema.rb in Rails project which is always a generated file and should not be a subject of any check.

@hron84 some runners already provide that possibility. For example, pronto-rubocop just uses regular .rubocop.yml where you can specify exactly what you want. Does that help?

A bit. However, I would prefer a regular option, what can be maintained via pronto, and not directly via the underlying plugin. For example, if I exclude db/schema.rb from rubocop, it is not guarantee it will exclude from other runners. However, since the db/schema.rb is purely autogenerated, I would exclude it from all runners, not only from rubocop because errors reacting to this file are completelly unhelpful and unneccessary.


[website] minor tweaks to make it more mobile friendly

Make the table a bit narrower to make it fit mobile screens better. These tweaks make all columns almost fully visible in landscape mode on Pixel 5. In portrait mode, it's not possible to scroll all the way to the left to see the package name, but I have no idea how to fix that. :)

Before
After


use official zookeeper image for solr-drupal recipe

switch from bitnami to official for arm64 support

Thanks for doing this! I'm on vacation on a road trip with very limited internet, but hope to look soon.

Just a note that after v1.19.0 release this is high priority to get in and also to make into a ddev get addon.

Bitnami now has a multi-arch zookeeper image, https://hub.docker.com/r/bitnami/zookeeper/tags

This should be obsolete right? Just add pointer to your new add-on?


User flow to support different comms and add a general comms-based device

Building a generalised logic to add nfc/qr/file based devices and intelligently parse the received details.

Closing this issue as discussed with dev.


Swift 3.0 setting the avoidingview to self when self is still nil crash

Hi,
I've updated the version of IHKeyboardAvoiding to the latest Swift version. When executing the following code:
KeyboardAvoiding.avoidingView = self
And executing this in an AwakeFromNib which isn't showing itself yet (it's a popup which will show when pressing a button) it will crash saying the following:
fatal error: unexpectedly found nil while unwrapping an Optional value

In Objective C, when an object is nil, any method calls are ignored, but in Swift an exception is thrown.
I don't think I can fix IHKeyboarding entirely, but I can stop it from crashing - know which line it crashes on?
I think you'll have to change you code to call KeyboardAvoiding.avoidingView = self.cell.view in the ViewController instead

Hi,
The line it crashes is in KeyboardAvoiding.swift on line 245:

self.avoidingViewUsesAutoLayout = avoidingView != nil ? avoidingView!.superview!.constraints.count > 0 : false

Ah Im checking if the avoidingView is nil but not it's superview.  I'll have a quick look into it

Ok so checking if the superview != nil should fix the crash
self.avoidingViewUsesAutoLayout = (avoidingView != nil && avoidingView!.superview != nil) ? avoidingView!.superview!.constraints.count > 0 : false
But I don't know how to test your exact situation
I'd suggest not setting the avoidingView until its been added to the view hierarchy


first contrib

learning github

@qteen, I'm quite elated about your PR. I wanna evolve this project to addresses various problems faced by first-time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a PR and learned that I merged it?


protonup-qt: init at 2.7.4

Description of changes
Added ProtonUp-Qt package.
Things done
Created package using appimage wrapper. I attempted and am still attempting to package it in a standard format, but have been struggling with dependencies. For now, I feel this can do.

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Made a lot of mistakes so just going to draft it until its fixed.

Tested out and it works, used it to download a new version of wine-proton-ge for lutris.

Somehow after renaming with -bin it has stopped creating a desktop file. Not sure what's wrong.

Builds correctly and creates a .desktop file. Unless anything is wrong with naming or formatting, this should be complete.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/1353

I've packaged the binary for now because the source requires quite a few dependencies currently unavailable. I started packaging them, but ran into troube with some, mainly PySide6, which also required more unavailable dependencies.
I thought it may be worth packaging the binary to get it working for now, and then spend more time trying to get the source packaged.


Running download-atom-shell task fails with system cannot find the path specified (Windows)

After taking a fresh clone of the repository, I no longer have issues building ctags (#1950).
Now I am able to build the modules and de-dupe them.  Instead I'm getting this error:
Installing<EMAIL_ADDRESS>✓
Deduping modules ✓
Running "download-atom-shell" task
>> The system cannot find the path specified.
Aborted due to warnings.

@EpicDavi I also encounter this error aborted due to warnings when run install task.
When I run grunt install -v, the terminal tell me more information about this error.
In my situation, there are some modules can't be find and then I reinstall these modules and everything is OK.
So, you also can try it.


hello_world.cpp

If you can create a new folder for C++ language and put there. I have merged this one. for the next one you can do that.


fix(FirebaseListFactory): ref.off cannot be unbounded

Inside of the Subscriber function in FirebaseListFactory, the Firebase reference's off method is being returned to act as the disposal function:
let ref = new Firebase('...');
let obs = new FirebaseObservable(() => {
  return ref.off;
});

But when the Observable is unsubscribed, ref.off is being called with the wrong context.

The easiest solution for this would be to wrap ref.off in a closure:
In src/utils/firebase_list_factory.ts:
export function FirebaseListFactory (absoluteUrl:string): FirebaseObservable<any> {
// ...
return () => ref.off();
// ...
}

The test it('should call off on all events when disposed' in firebase_list_factory.spec.ts should be updated, but I'm not sure why the test is passing now while it doesn't actually work in real apps with the async pipe...


[Hoxfix] Upgrade dev version to 1.5.0-SNAPSHOT and fix some small issues

1.Upgrade dev version to 1.5.0-SNAPSHOT
2.Fix carbon-spark-sql issue
3.Remove hadoop 2.2 profile
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:

[X] Any interfaces changed?
NA

[Y] Any backward compatibility impacted?

[Y] Document update required?

[X] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.

[X] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

SDV Build Success , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/5208/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/6238/

LGTM


file comment info

VSCode Version:1.6
OS Version:macos 10.12

Steps to Reproduce:

when i create a file, like js file,it can be able to add the comment into the file.
these comment can be config in somewhere.

the comment like this:
/*
 * author:ling
 *<EMAIL_ADDRESS> * date:2016-10-01
 *...
 */

You can already do 1.
What do you mean by "these comment can be config in somewhere"?

Closing due to inactivity.


stale data - server.views.populate_csv

Describe the bug
While testing some views / sheets on tableau server,  I changed the underlying data source. After publishing the data sources (removing fields) I can see that the views / sheets of a given workbook are not populated anymore - because fields being selected do not exist anymore.
However when calling server.views.populate_csv(myView,1) I still get csv data returned representing the state of the view prior to change, containing data of fields that have been removed from the data source.
Versions
Details of your environment, including:

Tableau Server version 3.9
Python version 3.7.5
TSC library version tableauserverclient-0.15.0

To Reproduce
Results
No error msg is received, but the resulting data is out dated
NOTE: Be careful not to post user names, passwords, auth tokens or any other private or sensitive information.

solved, bug in own code


[Bug] 0x0 mm Measurements from SRs that Span Multiple Series

Describe the Bug
Loading SRs created from OHIF, but that spans multiple series, sometimes results in 0x0 mm measurements.
Steps to Reproduce

Add a measurement from Series 1.
Track Series 1 when prompted.
Add a measurement from Series 2.
"Add to existing report" when prompted.
Create SR Report.
All measurements can be read and navigated to in this study session.
Reload the study entirely with CTRL+F5.
Load the saved SR and say Yes to continue tracking measurements.
All measurements in list seem non-zero.
Start working your way down the measurement list, clicking each measurement one by one.
Upon clicking a Series 2 measurement, it turns to 0x0 mm and there are no annotation visible in the viewport. The session has crashed.

The current behavior
Not all measurements can be read and navigated to from an SR that includes measurements from multiple series.
The expected behavior
All measurements should be readable and navigated to from an SR that includes measurements from multiple series, since its creation is allowed in OHIF.
OS
OHIF demo local
Node version
OHIF demo local
Browser
Chrome 117.0.0

See OHIF PR #3696 and CS3D PR #810


[Request-for-external] Codeunit 90 Purch.-Post - FillInvoicePostBuffer

Hi, I was wondering if it would be possible to change the procedure FillInvoicePostBuffer Codeunit 90 from local to external.
My team and I use this procedure a lot in our code, and changing it to external would be a huge help.
Thanks

Let me inform you that we implement external changes in next version only, so it will not be available for 17.x or 18.x. We plan do refactor this implementation to make it extendable in 19.x, therefore we cannot make it external right now.


DOC: remove scpdt references from README

Update old scpdt references to the new scipy_doctest. Also updated the links.
doctest option was removed from SciPy dev.py, so I removed. If there's any suggestion to change this section I can put it back.
https://github.com/scipy/scipy/blob/de85b05990a475bfe04bd5f113511c4e9c2e2c8f/dev.py#L671-L681

I pushed from main. I'm going to push from a different branch and close this PR.


Non-alert-suppression despite code comment

Despite my having an alert-suppression comment (at https://lgtm.com/projects/g/brettz9/C2D2/snapshot/4f8a73b02cc0ff4bc44c09a3ee6de709195d5712/files/explorercanvas/silverlight/excanvas.js?sort=name&dir=ASC&mode=heatmap&showExcluded=false#V158 ) and despite your site having my latest code, I find the alert is still showing. I guess this is because it is a multiline comment, but as your docs refer to the semi-colon, I was expecting it needed to be at the end of the statement...
Update: In the meantime, I just added a commit to add the alert suppression comment on the same line as the document.write, so will see what happens...

Thank you for your report. For multi-line alerts, the suppression comment needs to go on the first line (so your follow-up commit worked). This isn't properly documented at the moment, apologies; we'll fix that.

The documentation has been updated to clarify this.


Use ci in travis

Part of the discussion in #11 was around how long it takes to npm i on windows.
This pr should be a test of that.

overall time is not that different .. still windows takes like 8x of Linux builds but whatevs

Looking at the build logs npm ci took 230ish and 290ish seconds and installation of chrome took 50 and 80ish seconds
For linux npm ci take 17ish seconds


[Bug]: Paint.NET has a new download URL

What happened?
With version 4.3.4 Paint.NET has a new github repo for the downloads:

exe (x86, x64, arm)
msi (x86, x64, arm)
portable (x86, x64, arm)

https://github.com/paintdotnet/release/releases
This is also the only way to get the MSI now (you can create it anymore from the "old" setup file)
Version
4.3.4
What PowerShell edition/s are you running Evergreen on?
Windows PowerShell
Which operating system/s are you running Evergreen on?
Windows 10
Have you reviewed the documentation?

[X] Troubleshooting at: https://stealthpuppy.com/evergreen/troubleshoot/
[X] Known issues at: https://stealthpuppy.com/evergreen/issues/

Verbose output
-

PaintDotNetOfflineInstaller pulls from that repo. The seperate PaintDotNet uses the old mechanism.

@aaronparker  thanks. I did not see that.

@aaronparker the Type should be exe / msi. Otherwise you can't filter for the download link.

Type is as-designed at the moment. This is the file type of the file in the URI property.
You could use this:
Get-EvergreenApp -Name "PaintDotNetOfflineInstaller" | Where-Object { $_.Uri -match "winmsi.x64" }

OK. thanks again. I added this to my script :)


Gene Search Tool and downstream issues encountered

I found this while developing a user guide; now work in progress at  https://dev.peanutbase.org/userguides/genefamily/geneToFamily.html
Go to gene family starting from a gene

Using Gene Search Tool

PeanutBase Home page (use left Tools panel or Tools dropdown in menubar) to [Gene Search Tool](/tools/gene-keyword    -search.html){:_blank}.
Use the Identifier/Description SEARCH boxex to type your gene name, id, or even partial id.
Arahy.H916D0 fails but H916D0 works while in ArachisMine both works. So confusing for user.
More confusing because the example  shows a Soy pattern that fails, e.g. Glyma.13G357700.
We need a Arahy example for PB.

If found the Result below will list all the genes and other features that has this id/name.
The 'GENE FAMILY ASSIGNMENTS' column will list the link to the Gene Family report page which has a link on the right panel named ,'View on the LIS Funnotate app'.
It appears under 'External Links' here while in the  alternate ArachisMines search it appears under ‘LIS Linkouts’ which is more appropriate.
This links to the Phylogram for the gene family and shows the Taxa  composition piechart and the tree diagram below with the searched gene highlighted.
This link (https://funnotate.legumeinfo.org/?family=legfed_v1_0.L_6RNLR0) is unproductive as it goes to Funnotate but shows  perpetual machine loading.
(This page is an interface to the ArachisMine from PeanutBase)

I've created an issue for allowing customization of the examples. I can't reproduce the issue with funnotate not displaying the tree for the linked family. I think we ought to use a gnm2.ann2 gene as the example, and just avoid the mess with "H916D0 vs Arahy.H916D0" which is more of a data issue than anything else. Let me know if there's something else that needs resolving here.

This link from the gene family report page is still perpetually loading. It is also labeled under External Links but should be LIS linkout.
https://funnotate.legumeinfo.org/?family=legfed_v1_0.L_6RNLR0

The URL you provided is still working on my end. Do you see any errors in the browser console?

1. Console error:
Uncaught SyntaxError: Identifier 'LINKOUTS_BASE_URL' has already been declared (at phylogram.js:1:1) sockjs.min.js:sourcemap:2 WebSocket connection to 'wss://funnotate.legumeinfo.org/__sockjs__/n=HXwiKZfOwB8vargttu/927/spt0mg1d/websocket' failed:  n.exports @ sockjs.min.js:sourcemap:2 shiny-server-client.min.js:1 Fri Nov 24 2023 12:22:44 GMT-0600 (Central Standard Time) [INF]: Connection opened. https://funnotate.legumeinfo.org/?family=legfed_v1_0.L_6RNLR0 shiny-server-client.min.js:1 Fri Nov 24 2023 12:22:44 GMT-0600 (Central Standard Time) [DBG]: Open channel 0 funnotate.legumeinfo.org/:1 Uncaught (in promise) Error: A listener indicated an asynchronous response by returning true, but the message channel closed before a response was received
2. When I opened the URL incognito it worked. So something at my end??

Yes, I'm not exactly sure how to interpret the error, but I think your browser must have gotten into a problematic state. Maybe try clearing the cache?

This link (https://funnotate.legumeinfo.org/?family=legfed_v1_0.L_6RNLR0) is unproductive as it goes to Funnotate but shows  perpetual machine loading.

It works for me too, I get a phylotree in a few seconds.


Wheels

I believe the CI built wheels are still wrong, we should have the same dependencies as pyarrow

on macos: 10.14 (for x86_64)
on linux: manylinux_2_17

ATM we have
macos 10.9 / manylinux_2_5

I guess for macos we need to set MACOSX_DEPLOYMENT_TARGET="10.14" in the env

I think what's happening here is that, since we ignore pyarrow, the repair tools can't know the dependency. The right way to do it would be a way to "scan dependencies" but choose what to copy.
The delocate tool for macOS seems to support this.

The wheel is built with the wrong platform tag, repairing does not change that
I don't understand why there isn't a min_macos kwargs in setuptools.

For what I understand, auditwheel relabels the wheel based on the minimum manylinux policy supported by the dependencies.
In our case, if there was a way of keeping libarrow in the dependencies, but avoid copying the library, it would create a manylinux_2_17 wheel.
I don't now how the macos minimum version work, but I guess it should work the same? If you build something compatible with macos 10.9+, that depends on something compatible macos 10.14+, if the ABI is backwards compatible, you should not need to recompile and the wheel should be relabeled for 10.14.

On my local build, if I just do pip install . -vv --no-build-isolation I get warnings:
ld: warning: dylib (/Users/xav/.micromamba/envs/pgeon-dev/lib/python3.11/site-packages/pyarrow/libarrow_python.dylib) was built for newer macOS version (10.14) than being linked (10.9)
  ld: warning: object file (build/temp.macosx-10.9-x86_64-cpython-311/libpgeon_cpp.a(api.o)) was built for newer macOS version (10.14) than being linked (10.9)
  ld: warning: object file (build/temp.macosx-10.9-x86_64-cpython-311/libpgeon_cpp.a(table_builder.o)) was built for newer macOS version (10.14) than being linked (10.9)
  ld: warning: object file (build/temp.macosx-10.9-x86_64-cpython-311/libpgeon_cpp.a(pg_interface.o)) was built for newer macOS version (10.14) than being linked (10.9)
  ld: warning: object file (build/temp.macosx-10.9-x86_64-cpython-311/libpgeon_cpp.a(builder.o)) was built for newer macOS version (10.14) than being linked (10.9)
  ld: warning: object file (build/
...

The wheel produced is tagged 10.9
Created wheel for pgeon: filename=pgeon-0.0.0-cp311-cp311-macosx_10_9_x86_64.whl size=98067
Setting MACOSX_DEPLOYMENT_TARGET removes the linker warnings and produce the expected wheel ilename=pgeon-0.0.0-cp311-cp311-macosx_10_14_x86_64.whl

https://cibuildwheel.readthedocs.io/en/stable/cpp_standards/


PUP-8983: use correct file mode for temp file when replacing a file

I was looking at the code to see if i could create a PR to address PUP-8983 and it looks like this is a bug.  im not the best ruby coder but my understanding is in the current behaviour  the mode[1][2] statements have no effect

Can one of the admins verify this patch?

Can one of the admins verify this patch?

CLA signed by all contributors.


Use new notification tile identifier for iOS 18

Fixes tapping on notification in iOS 18.
Looks like identifier changed in the latest iOS version:
iOS 17:

iOS 18:

Update changelog and version in pubspec

I've updated the changelog, but I didn't bump the version because I plan to release this change together with #2387.


code cleanup

Coverage decreased (-0.003%) to 92.447% when pulling cc9fddfcc274c54c00f7a7ac33c3562ba88effd7 on fix into 85b2a954f7d4da17e2f827b5e4a8256c81937f53 on geometries.


Issue with playback on LG TV

Describe the bug
Card retrieves movies and displays them OK. If I select a web player, it works, if I select my LG TV it fails. Both options are set as PlexPlayer from the device dropdown.
Expected behavior
Expect it to play the media on the TV
Checks
Please check below if true:
[ ] I am running Home Assistant on HTTP protocol
[X ] I am running BOTH Home Assistant AND Plex on HTTPS protocol
[X] My Plex server is accessible through protocol, port and ip/hostname I have specified for the card.
[X] My Plex server is running on HTTPS and has a valid certificate.
Card Configuration
type: custom:plex-meets-homeassistant
protocol: https
sort: titleSort:asc
displayType: ''
playTrailer: true
showExtras: true
showSearch: true
ip: plex.XXXXXXXXXXXXXXXX
token: XXXXXXXXXXXXXXX
port: ''
libraryName: Movies
maxCount: ''
maxRows: '10'
useHorizontalScroll: 'No'
displayTitleMain: 'Yes'
displaySubtitleMain: 'Yes'
minWidth: ''
minEpisodeWidth: ''
minExpandedWidth: ''
fontSize1: ''
fontSize2: ''
fontSize3: ''
fontSize4: ''
minExpandedHeight: ''
title: ''
entity:

plexPlayer | Chrome | <IP_ADDRESS> | XXXXXXXXXXXXXXXXXXX
plexPlayer | LG 43UK6400PLF | <IP_ADDRESS> | XXXXXXXXXXXXXXXXX

Card Version
3.3.1
Plex Version
<IP_ADDRESS>60

I think it's related to this:
https://www.reddit.com/r/PleX/comments/pzgc1f/lg_webos_plex_issues_started_yesterday/


Unifying all conversions to bytes.

Also making sure the _urlsafe_b64encode returns bytes and updating dependent code with the change in return type.
NOTE: This doesn't address the opposite direction, i.e. a.decode('utf-8') where is a bytes (or str) object.

As they are used throughout this commit what's the difference between "isinstance(value, bytes)" and "isinstance(value, six.binary_type)"? I imagine the distinction is subtle and tricky?

AFAIK the only difference is that bytes is an alias for str in Py2.6 and Py2.7 but it doesn't exist in Py2.5, so six.py just says:
if PY3:
    binary_type = bytes
else:
    binary_type = str

@nathanielmanistaatgoogle I rebased after some of the changes made it un-mergeable
Things that remain:

Use of ternary expression
Using .format instead of % (varname,).
Renaming _to_bytes to to_bytes (this will make it a public symbol in modules it gets used in)

Seems this will mostly cover #157

Yes to conditional expression
No, not unless I persuaded you, and I don't think I did because I think you persuaded me
Oh crap, that's because this codebase has a feel-free-to-import-elements-of-modules policy instead of import-only-modules-not-elements-of-modules policy. Oof, leave the underscore for now in that case.

@nathanielmanistaatgoogle I folded the ternary change into the original PR.
It's more common in Python to import the objects you need rather than the namespaces you need. That's just a Google rule. When unit testing, it's easier (maybe only marginally so, maybe a lot?) to monkey patch the objects in the module under test rather than tracking down the namespace which has that object and then monkey patching that other module.

I learned a little git-fu for anyone who wants to learn:
For #136:
$ # Visit: https://api.github.com/repos/google/oauth2client/pulls/136/commits
$ # parent in MASTER: 3c02a812165004aeb18cc89e10639694bf2d3b0f
$ git branch pr-136 3c02a812165004aeb18cc89e10639694bf2d3b0f
$ git checkout pr-136
$ wget https://patch-diff.githubusercontent.com/raw/google/oauth2client/pull/136.patch
$ git am 136.patch

For #157 :
$ # Visit: https://api.github.com/repos/google/oauth2client/pulls/157/commits
$ # parent in MASTER: 0a6241c792f0c833f2f176292b0c7ea5623eabfd
$ git branch pr-157 0a6241c792f0c833f2f176292b0c7ea5623eabfd
$ git checkout pr-157
$ wget https://patch-diff.githubusercontent.com/raw/google/oauth2client/pull/157.patch
$ git am 157.patch

Now I will try to rebase them onto master and see how it goes.


2022 april tremors to mob

merging fer per request from @Licenser https://github.com/tremor-rs/tremor-www/pull/174

resolving some conflicts...

Woooh woooh ! Thank you !!!

It looks like there are some merge conflicts with the branch :(

rebased manually 🤞


Parsing of image substitution incomplete

This is related to #23 in the sense that the symptom is that replacements don't work.
The regex used to parse an image identifier in the yaml is const imageKeyword = line.match(/^ *image:/);.
I had an issue where it was not working for me, because I had a config like this:
..
  containers:
    - image: test
      name: test

Which isn't correctly parsed by the regex.
The clean solution would be to use a real yaml parser, but an ugly quick fix could be to allow for this case.
If you want to have the quick fix I can make a PR, just let me know.
The correct regex is: /^ *(?:- )?image:/

That's a good catch. @SamMousa would you be willing to raise a fix for the same?

Do you want the quick fix? Because that I can do.
I'm not  not able to commit the time to implement the use of a proper yaml parser that just inspects the names of object properties...

You need to update the .ts files then locally run npm run-script build. I agree it's a little redundant, but this way we get to validate the unexpected compile changes too; which we can confidently take to our releases branch.
The quick fix should do.
cc: @shigupt202 could you validate how we missed this? I remember we solved this in the ADO task?

I agree it's a little redundant, but this way we get to validate the unexpected compile changes too

I think it's actually a risk, see #87.
I'll create a PR for the changed regex this week.

Cool. Tag @shigupt202 in your PR so he can take it forward. :)

You need to update the .ts files then locally run npm run-script build. I agree it's a little redundant, but this way we get to validate the unexpected compile changes too; which we can confidently take to our releases branch.
The quick fix should do.
cc: @shigupt202 could you validate how we missed this? I remember we solved this in the ADO task?

@ds-ms I can see the fix in ADO task was done in this PR.
Also, in this task we are using yaml parser for updateImagePullSecretsInManifestFiles. But somehow the change was missed for updateContainerImagesInManifestFiles.

Since this is something you guys have worked on internally; I'll refrain from making a PR for now and let you resolve this for yourselves :)


New version: JAMSoftware.TreeSize.Free version 4.6.1

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?

[x] Does your manifest conform to the 1.2 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

@ItzLevvie: Package version 4.6.1 is correct - the product version set is wrong unfortunately (we missed to update it along with the file version, which is set to 4.6.1 as intended). We will publish a corrected version shortly.

Corrected version has been published -> Revoking this PR, creating a new one with the correct information


fix: add realtime admin to reserved roles

What kind of change does this PR introduce?
Bug fix, feature, docs update, ...
What is the current behavior?
Please link any relevant issues here.
What is the new behavior?
Feel free to include screenshots if it includes visual changes.
Additional context
Add any other context or screenshots.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
5 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.03%) to 57.741%

Files with Coverage Reduction
New Missed Lines
%

internal/gen/keys/keys.go
5
11.76%

Totals

Change from base Build<PHONE_NUMBER>:
-0.03%

Covered Lines:
6385

Relevant Lines:
11058

💛  - Coveralls


Change all disabled buttons so they do not react on mouseover

Version: Master 2.2 (3/5/19)
RELATED ISSUE: rancher/rancher#18592
What kind of request is this (question/bug/enhancement/feature request):
Enhancement Request
Proposal:
Currently any / all disabled buttons react on mouseover. The button will slightly phase into a new color and the color of the text changes. In my opinion, this is not typical of most user interfaces the buttons are usually unreactive upon mouseover when they are disabled / unusable buttons.
I propose changing any /all disabled button classes so that there is no reaction upon hover. We can keep the "No" mouse cursor change to make it extra clear it is a disabled button but I do not like that an unusable button changes color / text color which gives it an appearance that it is in fact usable / actionable.
Result:

Less likely to confuse end-users.
More in alignment with other products user interfaces (buttons typically have no reaction upon mouseover when disabled.

Additional Notes:
There are also classes for dark theme buttons. These too should not react on mouseover, except the "No" mouse cursor change is okay here as well.

Closing in favor of #18592 that issue already addressed this. There is now no reaction at all upon hover over disabled buttons and we show the "no" cursor to make it very clear you cannot take action on such buttons.


Device charger instead of pvinverter possible? :-P

Hello,
first thanks again for the great project.
Might it be possible to add also the charger?
com.victronenergy.evcharger
Then I would be able to set the right stats via MQTT :-)
Best regards
Sebastian

I found already a project which seems more close to my request, so I will close this issue here.
https://github.com/vikt0rm/dbus-goecharger

We would have a look to add it, to have all possibilities in one universal driver.

maybe this helps, here it is already working
https://github.com/freakent/dbus-mqtt-devices/pull/33/files


Scrolling

What is the best method to scroll a page with the library? I have tried addPreScript and addScriptTag to try and inject javascript and then run it, but without success.

Im also attempting this! Have you had any luck? Ive tried injecting js functions with promises and Im getting the full page scrolled just no images in my returned screenshots :/

Add to Input/Mouse.php
` public function scrollY(int $distance, array $options = null)
{
$this->page->assertNotClosed();
    // get origin of the move
    $originX = $this->x;
    $originY = $this->y;

    // set new position after move
    $this->y = $this->y+$distance;

    // scroll
    $this->page->getSession()->sendMessageSync(new Message('Input.dispatchMouseEvent', [
        'type'              => 'mouseWheel',
        'x'                 => $originX,
        'y'                 => $originY,
        'deltaX'            => 0,
        'deltaY'            => $distance
        ]
    ));
    return $this;
}`


Can't use routerLink w/o a explicit route config (even if routes are defined in the app component)

The Tour-of-Heroes tutorial part 5 is an app with a dashboard and a heroes view. We're trying to switch over to using routerLink's in the dashboard. RouterLinks are already used in the app template. When I try to use a routerLink in the dashboard template I get the error:
Uncaught Unhandled exception:
Component "DashboardComponent" has no route config.
The only routes in the app are those defined in the app_component. The dashboard defines no routes itself. If I try to add an empty @RouteConfig(const []) then I get an error about child routes.
This problem is illustrate in the code changes in PR https://github.com/angular/angular.io/pull/2744.
cc @kwalrath

Probably you have to remove at the string './HeroDetail' part ./ (two beginning chars). But for me It led to another "Invalid argument" exception

@matanlurey - any update on this?  I'd like to wrap up the new router chapter soon and it would be nice to have this resolved before then.
cc @kwalrath @filiph

@arshvin, you were right about the router name; either /, ../ or nothing is correct, but (now in retrospect), it is obvious that './' is not. As for the typing issue, the fix was to further tweak the router link to be:
[routerLink]="['HeroDetail', {id: hero.id.toString()}]"

Notice the toString() call on hero.id.
@matanlurey - I've created #203 and #204 as followup issues.


Which line is which series?

I have a line chart with some series. How can I determine which line is which. I've added name to the series but that doesn't show anywhere. I want a list of the colors (of the lines) and the matching series name. How do I get that?
{
      labels: ['Maio', 'Junho', 'Julho', 'Agosto'],
      series: [
        {
          name: 'oleo',
          data: [2.7, 2.6, 1.9, 1.5]
        },
        {
          name: 'margarina',
          data: [4.2, 4.5, 3.4, 2.8]
        },
        {
          name: 'acucar',
          data: [11.3, 11.2, 7.2, 5.7]
        }
      ]
    }

Thanks

Hi there, you can use this plugin: https://github.com/CodeYellowBV/chartist-plugin-legend


Emmet completion missing if there errors in file

Verifying #33115
1.20.1 Shows a completion:

where 1.21.0-insiders doesn't:

Not sure if that intended.

Emmet completions have moved to the css extension in 1.21
The above content has errors and the css extension doesn't provide completions in a position that comes after a place that has errors. In this case there is error in line 3, so all css features stop there.
Closing as by design for now.
We'll see what the user reaction is.

On second thoughts, this might not be desirable.
One advantage of emmet completions is that they work even if css completions don't.
Will revert the move to css extension until we resolve the upstream issue of the css language service not able to parse the complete document when there are errors.


2.6.0 - workloads not added as service (service discovery)

Rancher Server Setup

Rancher version: 2.6.0
Installation option (Docker install/Helm Chart): Docker Install (Single)
Proxy/Cert Details: none

Information about the Cluster

Kubernetes version: 1.21
Cluster Type (Local/Downstream): Custom

Describe the bug
Created workloads are not listed as service inside Kubernetes and cannot be selected in service-related configurations (such as Ingress). This happens on a brand new and empty cluster. Created two workloads (named nginx and test) in the UI, services for them are not created.
To Reproduce

Create a workload (tested with both Deployment and DaemonSet)
Go to Service -> Ingress, try to create a new Ingress rule

Result
"Target Service" (for target selection in Ingress) does not show anything. Only shows "Sorry, no matching options".
When manually entering the workload name, a yellow warning indicates that "The selected service does not exist".
Expected Result
The workloads create a service in the background (Kubernetes), as stated in the documentation (https://rancher.com/docs/rancher/v2.6/en/k8s-in-rancher/service-discovery/):

For every workload created, a complementing Service Discovery entry is created.

Screenshots

Additional context
Rancher 2.6 service list with kubectl is clearly missing the workloads (nginx and test):
> kubectl get services --all-namespaces
NAMESPACE       NAME                                 TYPE        CLUSTER-IP      EXTERNAL-IP   PORT(S)                  AGE
cattle-system   cattle-cluster-agent                 ClusterIP   <IP_ADDRESS>    <none>        80/TCP,443/TCP           79m
default         kubernetes                           ClusterIP   <IP_ADDRESS>       <none>        443/TCP                  81m
ingress-nginx   ingress-nginx-controller-admission   ClusterIP   <IP_ADDRESS>   <none>        443/TCP                  79m
kube-system     kube-dns                             ClusterIP   <IP_ADDRESS>      <none>        53/UDP,53/TCP,9153/TCP   80m
kube-system     metrics-server                       ClusterIP   <IP_ADDRESS>   <none>        443/TCP                  80m

maybe related: https://github.com/rancher/rancher/issues/34639

@Napsty while creating a workload, in the Ports section if we select the type of Service, an SD will be created
Docs reference: https://rancher.com/docs/rancher/v2.6/en/k8s-in-rancher/workloads/deploy-workloads/

cc: @vincent99

Thank you @anupama2501 for that very important hint! I could not spot this in the upgrade/release notes and is clearly a different behaviour than in the other releases.
I will try and report back.

@vincent99 Right but the point is, this is not documented anywhere. If this UI is going to be forced onto people who have never seen it before (I really hate it, but that is beside the point) and they expect one thing but it does something else, there should be documentation about that.


feature: OSIS-7 Delete OSIS S3 credentials

Description:

Delete IAM User's S3 Credentials
Remove the secretkey from the Redis cache
Delete S3 Credentials unit tests
Refactor User tests and S3Credential tests

Codecov Report

Merging #73 (1ed99fd) into development/1.0 (dad1e27) will decrease coverage by 0.46%.
The diff coverage is 69.69%.

@@                  Coverage Diff                  @@
##             development/1.0      #73      +/-   ##
=====================================================
- Coverage              86.30%   85.84%   -0.47%
- Complexity               248      253       +5
=====================================================
  Files                     16       16
  Lines                   1154     1187      +33
  Branches                  89       94       +5
=====================================================
+ Hits                     996     1019      +23
- Misses                    99      108       +9
- Partials                  59       60       +1

Impacted Files
Coverage Δ

.../com/scality/osis/utils/ScalityModelConverter.java
96.18% <ø> (ø)

...lity/osis/service/impl/ScalityOsisServiceImpl.java
86.91% <69.69%> (-1.29%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dad1e27...1ed99fd. Read the comment docs.

Waiting for approval
The following approvals are needed before I can proceed with the merge:

the author

2 peers

/approve

In the queue
The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.
The changeset will be merged in:

:heavy_check_mark: development/1.0

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.
IMPORTANT
Please do not attempt to modify this pull request.

Any commit you add on the source branch will trigger a new cycle after the
current queue is merged.
Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.
The following options are set: approve

I have successfully merged the changeset of this pull request
into targetted development branches:

:heavy_check_mark: development/1.0

Please check the status of the associated issue OSIS-7.
Goodbye saitharunthodupunuru.


Documentation:  Establish way of working for Superseded functions from Imported/Suggested Packages

Please select a category the issue is focused on?
Developer Guides
Let us know where something needs a refresh or put your idea here!
To minimize headaches and rushed fixes, we should move admiral functions that are using superseded functions to the recommended functions, e.g. see https://github.com/pharmaverse/admiral/issues/2274 for transmute.
Particular concern should be placed on functions that are from the IMPORTED list of packages, as these could be deprecated overtime and impact the core functionality of admiral.  The functions used from SUGGEST should also be replaced, but this might be less urgent.

Definition of Done
Establish short policy in the developer guides on replacing superseded

We have decided to update on an ad-hoc basic, that is if we have the time then we can update, but decided against having a stated policy around this issue.. Also, it is a low priority as even if something is superseded and maybe deprecated it will be a long time so no rush on this!!


Update to Kicad 6, fix DRC errors

Update to Kicad 6. I fixed the missing symbol libraries and resolved the DRC errors. I had to create a custom rule for the edge connectors and shrink the courtyards for some capacitors to fix them. There are a few left that I think are genuine errors that you might wanna look at.


Audio Background Playback Question

What version of Shaka Player are you using?
"devDependencies": {
"@teppeis/clutz": "^1.0.29-4c95e12.v20190929",
"awesomplete": "^1.1.4",
"babel-core": "^6.26.3",
"babel-plugin-istanbul": "^4.1.6",
"babel-polyfill": "^6.26.0",
"babel-preset-env": "^1.7.0",
"cajon": "^0.4.4",
"core-js": "^3.6.5",
"dialog-polyfill": "^0.5.0",
"es6-promise-polyfill": "^1.2.0",
"eslint": "^5.16.0",
"eslint-config-google": "^0.13.0",
"eslint-plugin-shaka-rules": "file:./build/eslint-plugin-shaka-rules",
"esprima": "^4.0.1",
"fastestsmallesttextencoderdecoder": "^1.0.22",
"fontfaceonload": "^1.0.2",
"google-closure-compiler-java": "^20201006.0.0",
"google-closure-library": "^20200830.0.0",
"htmlhint": "^0.11.0",
"jasmine-ajax": "^4.0.0",
"jimp": "^0.11.0",
"jsdoc": "github:joeyparrish/jsdoc#45c271fa",
"karma": "^5.1.1",
"karma-babel-preprocessor": "^7.0.0",
"karma-chrome-launcher": "^2.2.0",
"karma-coverage": "^1.1.2",
"karma-edge-launcher": "^0.4.2",
"karma-firefox-launcher": "^1.1.0",
"karma-ie-launcher": "^1.0.0",
"karma-jasmine": "^3.3.1",
"karma-jasmine-ajax": "^0.1.13",
"karma-opera-launcher": "^1.0.0",
"karma-safari-launcher": "^1.0.0",
"karma-sourcemap-loader": "^0.3.7",
"karma-spec-reporter": "0.0.32",
"karma-webdriver-launcher": "^1.0.8",
"less": "^3.13.1",
"less-plugin-clean-css": "^1.5.1",
"material-design-lite": "^1.3.0",
"mux.js": "^5.7.0",
"pwacompat": "^2.0.10",
"rimraf": "^2.6.3",
"sprintf-js": "^1.1.2",
"stylelint": "^13.8.0",
"stylelint-config-standard": "^20.0.0",
"tippy.js": "^4.3.1",
"ua-parser-js": "github:joeyparrish/ua-parser-js#develop",
"which": "^1.3.1"
Please ask your question
**Is there a way to play the Shakya player only audio without video playback?
Or, I wonder if you have these options or api.
In other words, I'm curious how the content plays only audio without the screen.
Code, api, let me know if you have a link for reference. please...!
These are necessary for work to synchronize.
thank you :)**

If the manifest is audio-only, we can play it normally.  If your content normally has video and you want to remove it, you can set the following configuration.
player.configure('manifest.disableVideo', true);

If the manifest is audio-only, we can play it normally.  If your content normally has video and you want to remove it, you can set the following configuration.
player.configure('manifest.disableVideo', true);

You can also use an <audio> element instead of a <video> element to get audio-only playback of any content.

You can also use an <audio> element instead of a <video> element to get audio-only playback of any content.

Can I play audio only with the Shaka player? The principle of this program is that YouTube provides audio and video streams separately. I wonder how Shaka players can only play audio.
Link: https://github.com/Ashish-Bansal/audio-only-youtube

Can I play audio only with the Shaka player? The principle of this program is that YouTube provides audio and video streams separately. I wonder how Shaka players can only play audio.
Link: https://github.com/Ashish-Bansal/audio-only-youtube

Shaka Player has a configuration value that makes it ignore any video stream:
player.configure('manifest.disableVideo', true);

Shaka Player has a configuration value that makes it ignore any video stream:
player.configure('manifest.disableVideo', true);


Resend Activation Email

Sorry to be a pest again.  There seem to be a problem when one asks to resend the activation email.  It seems that is not posting the token so it is always returning the error that account is not found.
Thanks
Good Day

Please try 1.3.1. I might solve this one too.

Hi, test your script today,
variable token is empty from Activate your account, example link:
https://panel.cluster.pocketcloud.io/index.php/activate-account?token=
I upgraded to 1.3.1 one hour ago. not working.
Good job glewe, is a cool tool :)

Hi @stezam ,
I tried on my end and the token is set. The mail is sent too and activation worked.
What are the exact steps you did?
Best regards,
George

Hi Glewe
Thank you for your promp reply.
This is what I am doing.

Login with an admin account
Using one of the seeded users in this case dduck
go to the edit tab and update the password and group etc
When I try to login with the updated user I get the message to have the system to resend the activation email
Receive the email (using Mail Trap for now.  But therer is no token assigned to the parameter token=

Thank you

Hi @stezam ,
the reason for that is that the user is not active yet. I actually forgot to put that setting onto the user edit dialog.
I done that now in 1.4.0.
Best regards,
George

Thank you will try that tomorrow


Antiquarian Gets a Free Drug-Running Ship Narcos Style

This gives the Antiquarian a special Warthog LPC with the intention that he flies it around to meet with clients.
He also gets some memorabilia from his time at an Imperial penal colony.
Fulfills ticket: https://discord.com/channels/1194256269792510022/1307823868810887270/1307823868810887270
Also, ambrosia vulgaris sells for a pretty penny now.

+1 Finally an Antiquarian buff

add a SpaceCash350 entity as well so this doesnt return null when trying to sell ambrosia

SpaceCash350

Just added this to my big greasy repo


Edit css 'z-index' parameter to raise the calendar above the bootstrap modal window

Hey. I am trying to use datepicker with this modal library:
https://github.com/nakupanda/bootstrap3-dialog
https://nakupanda.github.io/bootstrap3-dialog/
but unfortunatelly calendar shows under the dialog window.
Please help me

which version of the datepicker do you use? And can you provide an example using this jsfiddle to show if this is still an issue on the 1.4.0 release

Hey. After You post, I've checked version. I've used 1.3.0. Now after update to 1.4.0 version the problem is gone. Thanks For Your help.


Dotnet Core Task V2: Command Test: If no projects found it doesn't state the pattern that was searched for

Environment
VSTS

Agent - Hosted

Issue Description
Dotnet Core Task in version 2. Command test.
If no projects are found, it only states that nothing is found.

##[warning]Project file(s) matching the specified pattern were not found.

I think it would help if the pattern would get mentioned so you can see if a typo was made or you can see other issues without opening the build definition, e.g.
##[warning]Project file(s) matching the specified pattern '*UnitTets' were not found.

This is same pattern followed by most of the VSTS tasks. It is not difficult to switch to "edit" view and look the task inputs.
@sachinma @ds-ms What's your opinion?

Does not seem important enough to me.

it could be helpful it shows how it run the command, or how it did consume the directory path.


#[test] macro

inventory is not cross-platform

Options

who should own the macro?

I'd like to have my own test attributes

Stablize inventory-like thing?

Can't have tests in functions today because rustc can't collect it
A linked-based solution would be better
People not fans of a proc-macro solution

linkme is closer to what dtolany wants to see merged

Splitting proper test enumeration into #40.  We can use linkme in the short term


Add new special collections locations

closes #2022

Deployed on bibdata-staging.

Locations look great on https://bibdata-staging.princeton.edu/locations/holding_locations; thanks @christinach !


brpc在macos上make的问题

sh config_brpc.sh --headers="/usr/local/include /usr/local/Cellar" --libs="/usr/local/lib /usr/local/Cellar" --cc=clang --cxx clang++
之后执行make，出现如下问题：
（问题发生在MacOS，High Sierra Version 10.13.6）
Compiling src/brpc/policy/weighted_round_robin_load_balancer.o
Packing libbrpc.a
/Library/Developer/CommandLineTools/usr/bin/ranlib: file: libbrpc.a(atomicops_internals_x86_gcc.o) has no symbols
/Library/Developer/CommandLineTools/usr/bin/ranlib: file: libbrpc.a(asan_invalid_access.o) has no symbols
/Library/Developer/CommandLineTools/usr/bin/ranlib: file: libbrpc.a(thread_restrictions.o) has no symbols
/Library/Developer/CommandLineTools/usr/bin/ranlib: file: libbrpc.a(baidu_naming_service.o) has no symbols
/Library/Developer/CommandLineTools/usr/bin/ranlib: file: libbrpc.a(giano_authenticator.o) has no symbols
Linking protoc-gen-mcpack
In file included from src/idl_options.pb.cc:4:
In file included from ./src/idl_options.pb.h:25:
In file included from /usr/local/include/google/protobuf/generated_message_table_driven.h:34:
In file included from /usr/local/include/google/protobuf/map.h:49:
In file included from /usr/local/include/google/protobuf/map_type_handler.h:35:
In file included from /usr/local/include/google/protobuf/wire_format_lite_inl.h:43:
/usr/local/include/google/protobuf/message_lite.h:117:3: error: unknown type name 'constexpr'
constexpr const T& get() const { return reinterpret_cast<const T&>(union_); }
^
/usr/local/include/google/protobuf/message_lite.h:117:13: error: expected member name or ';' after declaration specifiers
constexpr const T& get() const { return reinterpret_cast<const T&>(union_); }
/usr/local/include/google/protobuf/message_lite.h:110:11: error: use of undeclared identifier 'union_'
  new (&union_) T();
        ^
/usr/local/include/google/protobuf/message_lite.h:114:5: error: use of undeclared identifier 'get_mutable'
  get_mutable()->~T();
  ^
/usr/local/include/google/protobuf/message_lite.h:131:48: error: found '<::' after a template name which forms the digraph '<:' (aka '[') and a ':', did you mean '< ::'?
LIBPROTOBUF_EXPORT extern ExplicitlyConstructed<::std::string> fixed_address_empty_string;
                                             ^
/usr/local/include/google/protobuf/message_lite.h:137:37: error: no member named 'get' in 'google::protobuf::internal::ExplicitlyConstructed<std::__1::basic_string<char> >'
return fixed_address_empty_string.get();
       ~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
In file included from src/idl_options.pb.cc:4:
In file included from ./src/idl_options.pb.h:25:
In file included from /usr/local/include/google/protobuf/generated_message_table_driven.h:34:
In file included from /usr/local/include/google/protobuf/map.h:49:
In file included from /usr/local/include/google/protobuf/map_type_handler.h:35:
In file included from /usr/local/include/google/protobuf/wire_format_lite_inl.h:44:
/usr/local/include/google/protobuf/repeated_field.h:123:39: error: expected ';' at end of declaration list
RepeatedField(RepeatedField&& other) noexcept;
                                    ^
/usr/local/include/google/protobuf/repeated_field.h:124:50: error: expected ';' at end of declaration list
RepeatedField& operator=(RepeatedField&& other) noexcept;
                                               ^
/usr/local/include/google/protobuf/repeated_field.h:778:45: error: expected ';' at end of declaration list
RepeatedPtrField(RepeatedPtrField&& other) noexcept;
                                          ^
/usr/local/include/google/protobuf/repeated_field.h:779:56: error: expected ';' at end of declaration list
RepeatedPtrField& operator=(RepeatedPtrField&& other) noexcept;
                                                     ^
/usr/local/include/google/protobuf/repeated_field.h:1090:68: error: expected ';' at end of declaration
inline RepeatedField<Element>::RepeatedField(RepeatedField&& other) noexcept
                                                                 ^
/usr/local/include/google/protobuf/repeated_field.h:1090:69: error: unknown type name 'noexcept'
inline RepeatedField<Element>::RepeatedField(RepeatedField&& other) noexcept
                                                                  ^
/usr/local/include/google/protobuf/repeated_field.h:1091:5: error: expected unqualified-id
  : RepeatedField() {
  ^
/usr/local/include/google/protobuf/repeated_field.h:1103:27: error: expected ';' at end of declaration
  RepeatedField&& other) noexcept {
                        ^
/usr/local/include/google/protobuf/repeated_field.h:1103:28: error: C++ requires a type specifier for all declarations
  RepeatedField&& other) noexcept {
                         ^
/usr/local/include/google/protobuf/repeated_field.h:1103:36: error: expected ';' after top level declarator
  RepeatedField&& other) noexcept {
                                 ^
/usr/local/include/google/protobuf/repeated_field.h:1928:30: error: expected ';' at end of declaration
  RepeatedPtrField&& other) noexcept
                           ^
/usr/local/include/google/protobuf/repeated_field.h:1928:31: error: unknown type name 'noexcept'
  RepeatedPtrField&& other) noexcept
                            ^
/usr/local/include/google/protobuf/repeated_field.h:1929:5: error: expected unqualified-id
  : RepeatedPtrField() {
  ^
fatal error: too many errors emitted, stopping now [-ferror-limit=]
20 errors generated.
make: *** [protoc-gen-mcpack] Error 1

看看你的clang是不是支持c++11

clang --version
Apple LLVM version 9.1.0 (clang-9<IP_ADDRESS>)
Target: x86_64-apple-darwin17.7.0
Thread model: posix
InstalledDir: /Library/Developer/CommandLineTools/usr/bin
然后在.bashrc里加上下面三行：
alias g++='g++ -std=c++11'
alias gcc='gcc -std=c++11'
alias clang='clang -std=c++11'
再make还是一样的问题。

贴一下brpc根目录下的config.mk内容

Generated by config_brpc.sh, don't modify manually
SYSTEM=Darwin
HDRS=/usr/local/Cellar/openssl/1.0.2p/include/ /usr/local/include/
LIBS=/usr/local/lib
PROTOC=/usr/local/bin/protoc
PROTOBUF_HDR=/usr/local/include/
CC=clang
CXX=clang++
GCC_VERSION=40800
STATIC_LINKINGS= /usr/local/lib/libprotobuf.a /usr/local/lib/libleveldb.a /usr/local/lib/libsnappy.a
DYNAMIC_LINKINGS=-lpthread -lssl -lcrypto -ldl -lz -framework CoreFoundation -framework CoreGraphics -framework CoreData -framework CoreText -framework Security -framework Foundation -Wl,-U,_MallocExtension_ReleaseFreeMemory -Wl,-U,_ProfilerStart -Wl,-U,_ProfilerStop -Wl,-U,_RegisterThriftProtocol -lgflags
CPPFLAGS=-DBRPC_WITH_GLOG=0 -DGFLAGS_NS=google -g -Wno-deprecated-declarations
ifeq ($(NEED_LIBPROTOC), 1)
STATIC_LINKINGS+=/usr/local/lib/libprotoc.a
endif
ifeq ($(NEED_GPERFTOOLS), 1)
DYNAMIC_LINKINGS+=-ltcmalloc_and_profiler
endif
ifeq ($(NEED_GTEST), 1)
$(error "Fail to find gtest")
endif

我本地High Sierra Version 10.13.5，clang版本和你一样，没有复现相同的问题。看你的错误表象是编译器C++11相关的问题


Return builder from setHostnameVerificationPolicy

Currently, it is impossible to add  setHostnameVerificationPolicy to a call chain

@osipxd Damn. This is an API breaking change. We will have to deprecate this method and add another one with a different name. What is even more worrisome is the API breakage has not been detected by the build.

@osipxd I suppose I was wrong. The return type is not a part of method name signature and changing return type from void to something else does not cause compile incompatibility. japicmp apparently handles the case correctly.

Cherry-picked to 5.4.x

I tried changing the return type on a static method in a different project (Apache Commons IO) and JApiCmp failed with:
[ERROR] Failed to execute goal com.github.siom79.japicmp:japicmp-maven-plugin:0.23.0:cmp (default-cli) on project commons-io: There is at least one incompatibility: org.apache.commons.io.FileUtils.touch(java.io.File):METHOD_RETURN_TYPE_CHANGED -> [Help 1]

We are not using the latest version in HC parent, so this could be a bug in an old version of JApiCmp.
The JLS says that changing a return type is the same as removing and adding a method.
See 13.4.15. Method Result Type

@garydgregory

We are using version 0.21.2 of JApiCmp which almost the latest.
The change-set does not change the return type. It changes from void (no return type)  to a return type. Logically this should compile as before.

I'm still skeptical, this looks to me like 2 bugs in JApiCmp  😞

The change from non-final to final breaks subclasses since the containing class is public and non-final.
The return type change

After I run:
mvn -DskipTests -pl httpclient5 -Dhc.japicmp.version=0.23.0

JApiCmp thinks the method is "NEW" and "METHOD_ADDED_TO_PUBLIC_CLASS". Instead, I think it should report "METHOD_RETURN_TYPE_CHANGED". It should also note the change from non-final to final but it doesn't since it considers the method new, which according to the JLS it is.
There's been a few bugs in this area: https://github.com/siom79/japicmp/issues?q=is%3Aissue++return+

@garydgregory Do you want me to revert the commit and ask @osipxd to re-spin the PR with a more conservative fix?

Hi @ok2c
Tl;dr: Yes.
I think we need to decide whether we want 100% binary compatibility or not. If it were my decision alone I would strive for 100% BC. Jar hell is too painful.

@garydgregory @osipxd  Commit reverted and replaced by 891ccc6
Please take a look

LGTM, TY.