Noise layer sigma modification capabality in runtime

Often we want to progressively add random noise to the input of an NN in order to train it for unseen data and yet keep the prediction in the allowed data manifold. Having to set the noise sigma in the very beginning and only once is thus not desirable. This is especially true for RNNs. I am not completely sure this is the best way to introduce this functionality by I invite all to have a discussion. May be a callback could be a better approach.

test this please

As written, your approach wouldn't work. The correct thing to do here is to pass a symbolic variable to the layer's constructor and use a callback to modify its value during training.
Note that it would prevent serialization, the way serialization is currently written. But it would allow you to do what you want.


Undo/redo doesn't scroll to the changed line if the change was done externally (i.e. via devtools)

Does this issue occur when all extensions are disabled?: Yes

When file modified externally, vscode doesn't scroll to the changed line during undo, which makes it very difficult to detect what exactly is being changed.
Steps to Reproduce:

open a file in VSCode with enough lines to scroll. Scroll to the top
add something to the end of the file via another non-vscode editor and save it.
vscode should show the change in the minimap
use undo in vscode, it will undo the change, but will not scroll to the changed line

Version: 1.85.1
Commit: 0ee08df0cf4527e40edc9aa28f4b5bd38bbff2b2
Date: 2023-12-13T09:49:37.021Z
Electron: 25.9.7
ElectronBuildId: 25551756
Chromium: 114.0.5735.289
Node.js: 18.15.0
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.19045

Any news on this?

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!


Allow cusomizing the hotkey that shows/hides inlay hints

Currently the setting "editor.inlayHints.enabled": "{on,off}UnlessPressed", forces you to use CtrlAlt to show/hide the inlay hints.
I think it would be great to support customizing this hotkey, for example I'd bind one of the F keys to it.

Yes, this would be amazing to have. Currently I have them set to offUnlessPressed, but I sometimes want to turn them on  - because I'm teaching or need a screenshot.
A command to toggle them on, and then back to off / offUtillPressed would be very helpful.

Would be great, because on my system Ctrl+Alt activates the menu bar, places the focus there (I have just enabled the feature, I don't know how normal this is?). Seems kinda buggy to me.
I am working on the Xfce desktop on Linux. I believe not so many people are working with VS Code here or are testing it here.

I've tried this feature for 15 minutes, and my hand already hurts. Ctrl-Alt is an ok combination to press once, but for holding it's terrible.
The losing focus issue also doesn't increase happiness. You can keep focus by using Alt-Ctrl instead of Ctrl-Alt, but this is even more awkward.

Hi, I'm still looking forward to this feature! Any updates?

I don't see why this wasn't a toggle in the first place. Type hints are most useful when you actually have a type error, or want to refactor the types, or are trying to understand someone else's code. Those are activities that take up a low proportion of my time overall, but when I'm doing them I don't want to have to hold down an awkward key combination, which prevents actually modifying the code while seeing the hints!

Related on Stack Overflow: How can I change the inlay hints keyboard shortcut in Visual Studio Code?

I'm on MacOS and my keyboard workflow heavily relies upon the HYPER key using Karabiner-Elements. And my setup is using Left Shift + Right Control + Right Option as the HYPER key. In VS Code, I have set the editor.inlayHints.enabled to offUnlessPressed.
As you can see, because the the show/hide inlay shortcut is also using Control + Option so it's somewhat conflicting with my HYPER key setup. This means that every time I use my HYPER key, it also triggers the inlay hints causing text in the editor flashing/flickering.
For example, in this video I have HYPER + I mapped to Arrow Up and HYPER + K mapped to Arrow Down key for moving cursor. When I move cursor using HYPER key, the text in the editor area flashes.
https://github.com/user-attachments/assets/26476e9b-d981-4852-987b-00910fcbaeaa

Video Recorded from

MacOS Sonoma 14.6.1
VS Code Version: 1.93.1 Commit: 38c31bc77e0dd6ae88a4e9cc93428cc27a56ba40


Invalid SCCS in _white-content.scss

I presume it's meant to be box-shadow: 0 1px 15px 0 rgba(0, 0, 0, 0.05); ?
https://github.com/creativetimofficial/black-dashboard/blob/master/assets/scss/black-dashboard/custom/_white-content.scss#L165

Hi @nobodyshome and thank you for working with our products! We verified and it should be     box-shadow: 0 1px 15px 0 rgba(123, 123, 123, 0.05);. Thank you for pointing us this issue. We added it to the list of our next update. All the best, Rares!


Add support for PostgreSQL Listen/Notify mechanism

Use Database.PostgreSQL.Simple.Notification to implement the pattern outlined in this &yet blog post.
Do so in an exclusive thread with a separate connection to the Postgres DB. Then, I'll be able to implement the pub/sub pattern to send change notifications via WebSockets to clients while concurrently handling REST requests.

Use Go channels with go-broadcast to stream to Server-Sent Events when the app itself detects that records changed.


bug: Fix Potential Nil Reference in GetLabels Implementation

The policyIdentityLabelLookup wrapper for Endpoint implements the GetLabels interface method. This is necessary for constructing the MapState of the policy engine. This implementation incorrectly did not check if the identity returned by LookupIdentityByID was nil. This fixes this bug, which heretofore has not caused any issues.

/test


Support for timeout Settings

HI @chad122,
Thank you so much for contributing here! Indeed, offering the possibility to define a timeout is interesting. I think there's another way to do it.
Currently, we pass the timeout to each IClient, then to ApiRequest. I believe it causes many plumbing and side effects (15 files). As we don't pass the timeout value to every call, why not have it in ApiRequest directly? The value could be stored in the settings and be reused from there, as it already has access to Configuration. What do you think?

HI @chad122, Thank you so much for contributing here! Indeed, offering the possibility to define a timeout is interesting. I think there's another way to do it. Currently, we pass the timeout to each IClient, then to ApiRequest. I believe it causes many plumbing and side effects (15 files). As we don't pass the timeout value to every call, why not have it in ApiRequest directly? The value could be stored in the settings and be reused from there, as it already has access to Configuration. What do you think?

That's a good idea. It can also save a lot of time.
But one of the disadvantages of it is that it can be hidden.

It's ok. Thanks for your reply.


Ensure that gRPC metrics headers are in the order requested by the spec.

The present order in api.core is:
core/0.27.1 gl-python/3.6.0 grpc/0.27.1 gapic/0.27.2

The order per spec should be:
gl-python/2.7.12 gccl/0.21.0 gapic/0.1.0 core/0.14.1 grpc/1.0.1

And core should be spelled gax.

Related: https://github.com/grpc/grpc/pull/12778/files

Part of me kind of wants to sit on this until intercepters are ready.


⚠ Spryr has degraded performance

In dd4458d, Spryr (https://spryr.com) experienced degraded performance:

HTTP code: 200
Response time: 4334 ms

Resolved: Spryr performance has improved in 1c34c81 after 7 minutes.


Refs #30426 -- Changed default SECURE_CONTENT_TYPE_NOSNIFF to True.

Removed the SECURE_BROWSER_XSS_FILTER part as per https://code.djangoproject.com/ticket/30680

@claudep Thanks!


List operation in KV TBD?

Are there any plans to implement list operation for KV?
If not, I would be keen to help out in this open source repository.

Sorry, didn't see it was implemented.


Add MUSDB18 corpus

See:
https://sigsep.github.io/datasets/musdb.html
Seems like a very valuable dataset that is worth adding if someone has the time!

Thanks for the hint!
It is already on the list of datasets (#44). Currently I am busy with other stuff. But if you want to give it a try, see https://audiomate.readthedocs.io/en/latest/documentation/new_dataset_format.html. Any contributions are welcomed.

Ah, my bad! Looking a little into it, it might be difficult since they have to vet individuals requesting the data set

Great Project!
Concerning musdb, we now have a 30s and a 7s preview version of the dataset under creative commons (currently only as WAV files https://zenodo.org/record/1256003 at https://zenodo.org/record/1256064). As soon as I have uploaded the compressed dataset I can make a PR.


"No active campaigns to mine drops for. Waiting for an active campaign..."

I logged in, it scanned the campaigns but it says "No active campaigns to mine drops for. Waiting for an active campaign..." and it's just earning points
I have my accounts linked for the campaigns that are active
I'm using the dev build on Windows https://github.com/DevilXD/TwitchDropsMiner/releases/tag/dev-build
Any assistance?

Hello.
Please use the Inventory tab of the miner to find the relevant campaign you're trying to mine. You may need to fiddle around the filters - to show all campaigns, simply check all of the options and hit Refresh. Once you find the campaign, take a picture/screenshot of it and post here.
Alternatively, ensure that the campaign you're trying to mine:

Is active, so it already started and hasn't finished yet
The drop within the campaign hasn't expired
Your account is linked to the campaign's game
There is at least one channel which can be watched to progress the campaign

https://i.imgur.com/NimMfTb.png

Everything seems to be in order. Make sure you have setup your Priority list properly - you can find it in the Settings tab. Use it to setup a list of games you'd like to mine, then hit the Reload button and it should work.

Thank you, I didn't even know you needed to add the games through the priority list.

It would be great if the application just began mining the games that you have already linked.

You can do that by simply unticking the "Priority only" option. It's ticked by default specifically because I didn't want the miner to start mining seemingly random games/campaigns for a reason yet unknown for the user. Unticking this option though, is mentioned on the Help tab, in the usage instructional.

I think games which don't have linked are default not priority for people mining.

Games that aren't linked, aren't mined at all. This is because mining unlinked games leads to abuse. You can read more about this in the project goals: https://github.com/DevilXD/TwitchDropsMiner#project-goals

ngl the "Priority only" option should really not be ticked at default, it only made confusion for me and i started and is making confusion for others too

The only confusion I can see here, is the "no campaigns" message not being specific enough. If it said something like "none of the selected campaigns are able to be mined" (which is what it truly means), then the first thing you'd wonder as a new user, is how to select them in the first place. The current message is a result of continuous changes and development - it may have made sense at some point, but now it'd be good to change it.
I won't be making the "priority only" option unticked by default, because I don't want it to mine anything right after opening the application. The user should be able to first select what they're interested in, and then mine only what they want. Furthermore, the setup of Priority list is already explained in the Help tab, so I'll leave it at that.

I can see what you mean, it's just still really confusing as a new user to have it not just work when you start it up, even if you change the print
Would having a startup message box of some sort (one that only would show first time you open the app) maybe help with both making it more user-friendly and also allowing the user to select what games they're interested in before it starts, kinda like a popup window or a setup guide with the settings first time you open the app

Its been a while, but way back when I started using this. I too was trying to figure out why it was not working. Turns out the "Priority" list is not a "Priority" list, but a match these campaigns to watch list. Not reordering a matching list or downloaded matching linked games list from the server.

No active campaigns to mine drops for. Waiting for an active campaign...
Got this error, says that Overwatch 2 isn't ljnked when it is, I have reloaded the miner and everything and it still says no active campaigns.

No active campaigns to mine drops for. Waiting for an active campaign...
Got this error, says that Overwatch 2 isn't ljnked when it is, I have reloaded the miner and everything and it still says no active campaigns.

Found a fix, sorry: #430

I think this issue can be closed now.


use the checklist for a couple of existing software packages

https://github.com/ardc-fair-checklist/test


Issue with Buttons on Site

The "Set Sources", "Manage Content", and even "Clear Local Storage" buttons aren't working for me at all. I'm on Firefox and have already tried clearing my history and cache. I apologize if this is a simple fix, I'm honestly not great at these things.

They're working for me on Firefox 74.0 on Windows 10. Is your Firefox up to
date? What OS are you using?
On Thu, Mar 19, 2020, 1:37 PM Lunos8<EMAIL_ADDRESS>wrote:

The "Set Sources", "Manage Content", and even "Clear Local Storage"
buttons aren't working for me at all. I'm on Firefox and have already tried
clearing my history and cache. I apologize if this is a simple fix, I'm
honestly not great at these things.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Asmor/5e-monsters/issues/187, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAKWURAGUTGBWMA6ZOFXSN3RIJQ7PANCNFSM4LPQTXZA
.

I'm using Firefox 74.0 as well, but using a Mac 10.14.6
On Thursday, March 19, 2020, 4:18:29 PM EDT, SeanCooney<EMAIL_ADDRESS>wrote:

They're working for me on Firefox 74.0 on Windows 10. Is your Firefox up to
date? What OS are you using?
On Thu, Mar 19, 2020, 1:37 PM Lunos8<EMAIL_ADDRESS>wrote:

The "Set Sources", "Manage Content", and even "Clear Local Storage"
buttons aren't working for me at all. I'm on Firefox and have already tried
clearing my history and cache. I apologize if this is a simple fix, I'm
honestly not great at these things.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Asmor/5e-monsters/issues/187, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAKWURAGUTGBWMA6ZOFXSN3RIJQ7PANCNFSM4LPQTXZA
.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

So I just updated my mac to 10.15.3 and it now all appears to be working correctly. Honestly happy that it was on my end. Thank you very much!
On Thursday, March 19, 2020, 6:28:49 PM EDT, Jamie Neeley<EMAIL_ADDRESS>wrote:

I'm using Firefox 74.0 as well, but using a Mac 10.14.6
On Thursday, March 19, 2020, 4:18:29 PM EDT, SeanCooney<EMAIL_ADDRESS>wrote:

They're working for me on Firefox 74.0 on Windows 10. Is your Firefox up to
date? What OS are you using?
On Thu, Mar 19, 2020, 1:37 PM Lunos8<EMAIL_ADDRESS>wrote:

The "Set Sources", "Manage Content", and even "Clear Local Storage"
buttons aren't working for me at all. I'm on Firefox and have already tried
clearing my history and cache. I apologize if this is a simple fix, I'm
honestly not great at these things.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Asmor/5e-monsters/issues/187, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAKWURAGUTGBWMA6ZOFXSN3RIJQ7PANCNFSM4LPQTXZA
.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.


Resolves #71 including fixes from downstream depenedencies

This PR resolved #71 by forcing fixes suggested due to an error in downstream dependencies in all injection modes Root Only | Chain.

@lazaroclapp Unfortunately we cant have a separate unit test for this as it is only possible to do it if we test end to end source code comparison. Will check the actual generated code and confirm if all expected annotations are added.

@lazaroclapp Yes exactly that is a DAG. I actually updated our implementation to construct trees as a DAG and its output is as you requested and is ready. I can update this PR, or can have it as a follow up PR after the release. Please let me know how you prefer to approach this according to your priorities.


[FR] FR-32: Make deepflow agent support for host with Suse os linux kernel 3 or update the agent deploy documents for different os host.

Search before asking

[X] I had searched in the issues and found no similar feature requirement.

Description
start failed as following info:
more /var/log/deepflow-agent/deepflow-agent.log

[2023-04-14 17:34:31.105656 +08:00] WARN [src/trident.rs:421] initialize cgroup controller failed, CpuControllerSetFailed("maybe cgroup is not installed"), agent restart...

OS: Suse11 sp3/Suse11 sp4
kernel: 3.0.101
Use case
we try to install the rpm of cgroup:
suse11sp3:

rpm -ivh libcgroup1-0.37.1-5.16.1

suse11sp4:

rpm -ivh libcgroup1-0.41.rc1-2.34

then start cgconfig service:

service cgconfig start

but agent still starts failed with the same error.
next, we add some configurations and restart the service:

mount {
cpu = /mnt/cgroups/cpu;
cpuacct = /mnt/cgroups/cpuacct;
memory = /mnt/cgroups/memory;
}

agent starts successfully.
we start the agent with the above temporary measures, but we don't know what negative impact it will produce.
Related issues
No response
Are you willing to submit a PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

When there are no cgroups in the system, we will only periodically check the CPU and memory usage without forcing deepflow-agent to restart.
@TomatoMr will fix this issue

https://github.com/deepflowio/deepflow/pull/3327

done.
https://github.com/deepflowio/deepflow/pull/3371


Fix repo URL and indentation

This project is a really nice effort. However, when i tried to check it out (a little blindly following the installation instructions) it took me a while to realize the repo URL still points to the outdated version.
Relates to #1

Appreciate the PR🙏


Display user progress stats in the support console

Context
The product and support team needs a snapshot view of where candidates are in the application process.
Changes proposed in this pull request
Add a table of service stats in the support console:

Guidance to review

These are the initial stats for right this minute. Subsequent PRs will add:

more stats for later stages of the application process
some kind of Slack integration so the stats can be automatically posted on a daily basis

We try not to count DfE users in the stats since they're very unlikely to be lodging real applications, but rather exploring the service

Link to Trello card
https://trello.com/c/asLhnXMe/398-show-performance-metrics-in-the-support-console

Specs coming shortly.


segfault

File

Releases: 1.0.0 (db499c64ceba2cf0d53b021880e3a6eeda46805e)
File: pscp-project-2022-x11-64.7z

System Spec.

OS: Devuan GNU/Linux 4 (chimaera) x86_64
Kernel: 5.10.0-9-amd64

What Happened
Opens the pscp binary with non-root user on terminal
Loading screen shows up
Finishes loading
Menu screen shows up
Clicks Open Python Interactive Console
Some kind of console shows up
Types c to the console
Segmentation fault and gets kick out to terminal
Output
Godot Engine v3.5.1.stable.official.6fed1ffa3 - https://godotengine.org
OpenGL ES 3.0 Renderer: AMD OLAND (DRM 2.50.0, 5.10.0-9-amd64, LLVM 11.0.1)
Async. shader compilation: OFF

Pythonscript 0.50.0 (CPython 3.8.5.final.0)
ERROR: Failed to retrieve non-existent singleton 'VisualScriptEditor'.
   at: get_singleton_object (core/engine.cpp:201)
Cannot retreive singleton VisualScriptEditor
Segmentation fault

seckfoalt

Maybe the issue from the plugin causes a seckfoalt. Better to wait for their new refactoring for Godot 4 or rewrite all Python works to GDScript. (Or C++ if our collaborators prefer. But they can cause more seckfoalt than this plugin lmao)

The collaborators were bored with their old works. andd yes, me too.
And I'm also tired of waiting for the update.
will go to your house later and fix it with a sledgehammer.


[stable/lamp] adding myself as an owner

I am the maintainer of this chart and per #13869 would like to add myself to the OWNERS file.

@unguiculus as the main maintainer of this chart I'd like to be added as an owner.

/assign @cpanato

/ok-to-test
/verify-owners

/lgtm

/verify-owners


Deduplicate string encoding functions in engine/embedders

We currently have a variety of functions named Utf8ToUtf16, Utf16FromUtf8, StringToWideString in various places throughout the codebase. Now that FML can be used in the platform-specific desktop embedders, move string-encoding functionality to FML and use that.
Windows APIs use wchar_t-based strings and as a result, we'll need to continue to keep Windows-specific functions in fml/platform/win/wstring_conversion.h. This does, however let us reduce our use of _SILENCE_CXX17_CODECVT_HEADER_DEPRECATION_WARNING to a single instance.
Related: https://github.com/flutter/flutter/issues/50053

As of https://github.com/flutter/engine/pull/31334, this is done for everything except //third_party/accessibility and the Android embedder.

This is now complete.


Store number of open Dialogs

Maintain a Object with number of dialogues currently opened, (useful while stacking dialogues).
and also Maintain a Object with number of dialogues closed. (for reference).

Added in the release v.1.5.3


HMR fails to update if accept module name has file extension and main import doesn't

Do you want to request a feature or report a bug?
Bug...possibly

What is the current behavior?
If you add an extension to either the main app module name import App from './App' or accept module name  module.hot.accept('./App.js', () => { render(App); }); HMR fails to update.
import App from './App';

const render = Component => {
    ReactDOM.render(
        <AppContainer>
            <Component />
        </AppContainer>,
        document.getElementById('root')
    );
};

...

if (module.hot) {
    module.hot.accept('./App.js', () => { render(App); });
}

Further detail here: https://github.com/leesaxby/webpack-hmr-issue.
If the current behavior is a bug, please provide the steps to reproduce.
Reproduceable repo here: https://github.com/leesaxby/webpack-hmr-issue

What is the expected behavior?
Not sure if this would be considered a bug, but can be a bit of a gotcha if you accidentally add a file extension to one of the module names as the HMR console output is the same with or without the extension.
If this is a feature request, what is motivation or use case for changing the behavior?
Please mention other relevant information such as the browser version, Node.js version, webpack version and Operating System.
Chrome
Node v9
Ubuntu
Webpack 3.10.0
webpack-dev-server  2.9.5

It must be the same string content. You are literally accepting this import selected by source.

Thanks for the reply.
When the accept name contains the extension (differing from the main app import string).
You update the App module and the accept callback will fire once but App will be the old version (without changes), then any further changes to App won't trigger the accept callback.
Would you be able to  clarify what webpack is doing here, to help in understanding?
Thanks

We have docs https://webpack.js.org/concepts/hot-module-replacement/


Fixed Attribute "data-row-key" not found bug

Addressed issue #1707
Changed event.target to event.currentTarget in onRowMouseEnter
Issue seems to be the target being the child element(dropdown) rather than the row. This isn't an issue when you hover over a cell because it has the data-row-key property but it is an issue when we hover over a dropdown.

Hey @jabbapen, thank you for the contribution.
We require all contributors to JPMC projects to complete our Contribution Licence Agreement (CLA). You can sign as an individual or as representing your company. You only need to do this once, and it covers all current and future projects managed under our GitHub organization.
The contribution agreement can be found here JPMC CLA, if you could follow the instructions to complete and return via email we can get this merged.
Thanks!

Awesome! I've attached the agreement to this email. Thanks Josh.
On Tue, Jun 6, 2023 at 4:48 AM Josh Wooding @.***>
wrote:

Hey @jabbapen https://github.com/jabbapen, thank you for the
contribution.
We require all contributors to JPMC projects to complete our Contribution
Licence Agreement (CLA). You can sign as an individual or as representing
your company. You only need to do this once, and it covers all current and
future projects managed under our GitHub organization.
The contribution agreement can be found here JPMC CLA
https://github.com/jpmorganchase/.github/blob/main/jpmc-cla-20230406.md,
if you could follow the instructions to complete and return via email we
can get this merged.
Thanks!
—
Reply to this email directly, view it on GitHub
https://github.com/jpmorganchase/salt-ds/pull/1762#issuecomment-1578593754,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARDIVYJLJRIE4X2PM3YEKHTXJ4KJLANCNFSM6AAAAAAYZYROSE
.
You are receiving this because you were mentioned.Message ID:
@.***>

Awesome! I've attached the agreement to this email. Thanks Josh.

Hi @jabbapen,
Did you send the CLA to<EMAIL_ADDRESS>Thanks,
Josh

Ah my apologies. I sent it to that email. Sorry for the confusion.
On Mon, Jun 12, 2023 at 6:10 AM Josh Wooding @.***>
wrote:

Awesome! I've attached the agreement to this email. Thanks Josh.
Hi @jabbapen https://github.com/jabbapen,
Did you send the CLA to @.***?
Thanks,
Josh
—
Reply to this email directly, view it on GitHub
https://github.com/jpmorganchase/salt-ds/pull/1762#issuecomment-1587316027,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARDIVYIX62N2I3LRCH7NBUTXK4IM3ANCNFSM6AAAAAAYZYROSE
.
You are receiving this because you were mentioned.Message ID:
@.***>

Thank you for your contribution @jabbapen :tada:


feat: add controller concurrency

The controller is now working with 4 concurrent workers by default.
This value is configurable through the --concurrent flag.
Signed-off-by: Max Jonas Werner<EMAIL_ADDRESS>

@squaremo Thanks for the review! I addressed your comment.


Is there a way to determine where the comment tree should display "Load more comments"?

Currently, my comment tree only displays comments that Reddit originally provides, but I am not sure how to make it find the right place to show "load more comments". Does Reddit (or JRAW) provide any help with that?
I see that we have #getReplies and #getMoreChildren. What is the difference between them, when the children ARE the replies, or am I missing something?
My test example:

How it should be:

Current code for loading comments:
// Request comments from submission...
// On success:
Iterator<CommentNode<PublicContribution<?>>> commentIterator = root.walkTree().iterator();

while (commentIterator.hasNext()) {
    CommentNode commentNode = commentIterator.next();
    CommentItem commentItem = new CommentItem(commentNode);

    commentItems.add(commentItem);

    // Add this "load more comments" item if you know where to put it:
    //commentItems.add(new LoadMoreCommentsItem());
}

((CommentsAdapter) commentsRV.getAdapter()).updateItems(commentItems);

In the second screenshot each "...load more comments" represents a MoreChildren. Here's the documentation:
/**
 * A MoreChildren is a model used by reddit to represent comments that exist, but could not be presented in the response
 * due to the large amounts of other, higher priority comments already being shown in the thread. On the website, a
 * MoreChildren is represented by the text "load more comments (x replies)". The average user shouldn't have to
 * deal with this class directly as {@link net.dean.jraw.tree.CommentNode} will handle loading more comments for you.
 *
 * MoreChildren instances can appear anywhere in a comment tree except at the very root.
 */

Thanks for the information. I will get back to this in a few weeks

I'm going to close this for now, please let me know if you need any more help!

It says that CommentNode will handle loading more comments but it doesn't, and it doesn't show a "load more comments" item on its own. I am not sure how to add this myself, since these "load more comments" items have to appear in very specific places, like at the start of a new depth of comments, or previous depths.
This is what I currently have:
   Iterator<CommentNode<PublicContribution<?>>> commentIterator = root.walkTree().iterator();

                        root.visualize();

                        while (commentIterator.hasNext()) {
                            CommentNode commentNode = commentIterator.next();
                            CommentItem commentItem = new CommentItem(commentNode);

                            commentItems.add(commentItem);

                            if (commentNode.getDepth() > 1) {

                                if (commentNode.hasMoreChildren()) {
                                    commentItems.add(new LoadMoreCommentsItem(2));
                                }
                            }

I'm sorry, I really don't understand this.
Do I need to use your example for  this to work:
Iterator<CommentNode<PublicContribution<?>>> commentIterator = root.walkTree().iterator(); which makes a proper comment tree but can't tell me if at the end of a specific node there should be more comments.
The problem is, it builds all the hierarchy but doesn't tell me at which point in it there should be more comments.

Figured it out. getReplies is the direct children which returns the children that are showing, while hasMoreChildren returns true if there are additional children that are hidden by the API.
Took me more than I expected to figure it out :D


Update the game over message

Update the game over message so people know how to play again!

Final

1


duplicated code removed

Current coverage is 95.51%

Merging #988 into master will increase coverage by +0.04% as of 67ca059

@@            master    #988   diff @@
======================================
  Files           74      74
  Stmts         8908    8869    -39
  Branches      1718    1700    -18
  Methods          0       0
======================================
- Hit           8505    8471    -34
+ Partial        136     134     -2
+ Missed         267     264     -3

Review entire Coverage Diff as of 67ca059

Powered by Codecov. Updated on successful CI builds.

Thx!


objects_maker.py: make_organism_creators()

I learned about the GASP code at an IPAM workshop and I currently try to feed random clusters with specific space groups, like the ones generated from https://github.com/psavery/randSpg to GASP. This means I do not have the whole configuration range included in my input data therefore I removed the corresponding check. Or is there a particular reason to keep it?
Best regards
Jan

Hi Jan,
Thanks for your interest in GASP. I included that check because pymatgen's tool for constructing phase diagrams requires at least one structure at each endpoint of the composition space. In phase diagram searches, GASP uses this tool to construct a phase diagram from the structures in the initial population once it's complete. Therefore, the initial population must contain at least one structure from each endpoint of the composition space.
For your searches, is it possible to include clusters with the endpoint compositions? They don't have to have low energies, because GASP can subsequently search for structures at those compositions and find better ones. It just needs something to get started.
If have any questions or run into any problems, please let me know.
Cheers,
Ben

Thx for the quick response and explanation, I noticed the requirement for the endpoints at a later stage - that is something which was not clear to me from the documentation in the beginning.

Maybe a quick addition on this topic - is it possible to randomly generate the endpoints if they are not included in the provided input files? I basically try to build an automated workflow creating the initial population with randspg and then automatically load this one in gasp so at the moment I get the endpoints from the materialsproject website - but as you already have the code to generate endpoints for your random distributions, it should be rather quick to generate those automatically if they are not included in the input files as well.

Yes you're right - generating random structures at the endpoints isn't difficult. The problem is that often randomly generated structures don't survive to be added to the initial population. For example, there could be an unforeseen problem with the energy calculation, or perhaps the relaxed structure no longer satisfies the constraints. If something like this happens, the structure won't be added to initial population, and a phase diagram cannot be constructed (causing the search to be terminated).
To get around this problem, we decided to place the burden on the user to provide viable initial structures at each endpoint of the composition space so that a phase diagram can be built from the initial population.
In your automated workflow, is it possible to get structures at the endpoints (either from materials project or randspg) as a first step? The files for these endpoint structures could be placed into a directory where the rest of the structures for the initial population will go, and the path to the directory can be written to GASP's input file.


oAuth problems with Salesforce sandboxes since Spring 15 preview began

Is anyone else experiencing "login looping" with workbench and SFDC sandboxes?
Ever since Jan 8th (roughly when Spring 15 preview started) the oAuth behavior in Workbench is failing frequently.
(sandboxes only, production is fine)
Steps to reproduce:

Login to my sandbox as a System Admin
Open a new tab, navigate to https://workbench.developerforce.com
Select "Sandbox" and agree to Terms of Service
Click "Login with Salesforce"

Result:
I arrive at SFDC login page again.  Upon entering valid credentials, I am redirected to SFDC home page, not into workbench.
Expected Result:
Arrive at workbench screen.
Sometimes this "login loop" repeats 2 to 6 times before workbench finally opens.
I'm positive this is an SFDC "login host" issue because - identical behavior can be seen with "PermComparator" app.
The same oAuth failure occurs: https://perm-comparator.herokuapp.com
I've opened a premier case with SFDC, but they will not support anything to do with 3rd party apps.
Even though I've 80% proven it's a problem at their side - I'm not getting any traction with their support team.
Any insight or assistance would be much appreciated!!
Jason

It's looking like this issue is only happening for SFDC sandboxes created specifically from my company's production org.
I created a 30-day trial org "for advanced admins", and it came with 2 sandbox licenses.
Those sandboxes (on CS18) do not reproduce the issue, but my company's sandboxes (also on CS18 and on other hosts) easily reproduce the issue.

I am also experiencing this issue with my client's org.  They are using a custom domain and I can't get into Workbench, CS10...

Here's a workaround I've found (albeit - painful).
Assuming you're already logged into SFDC in Chrome for example...
Open a new Incognito window and go directly to workbench.   Select sandbox, then login as usual to SFDC.  Workbench should open.
I've become accustomed to this now - I can only use workbench following the above procedure.  (sigh)..

Hmm...that doesn't work for me.  My org is https://clientname--environment.cs10.my.salesforce.com/ and the incognito window still isn't allowing me into the workbench, it keeps re-directing me into the org.  Do you think it has to do with the fact that I have cs10 in the url or something?

Hmm, odd - which browser out of curiosity?  (I've tried them all).
How about this variation on the test...

Close all browser instances.
Launch a fresh browser session to https://workbench.developerforce.com
Select sandbox and login to your destination sandbox
Workbench should load

Our domain setup is the same.   i.e.
https://clientdomain--sandboxname.cs10.my.salesforce.com
I had a lengthy ticket open with SFDC on this issue because I was positive it began right at the start of Spring 15 preview window.  During troubleshooting we found that by disabling the domains feature it started working.  Only SFDC can disable it for you.

Hi All
Even i am facing the same issue.. I am usiing Chrome browser. My Org is  https://clientname--environment.cs14.my.salesforce.com/. Whenever i am trying to open The workbench it redirects me to Login page which in turn opens up the Sandbox homepage instead of Workbench tool.
San

I am experiencing this as well in my org sandbox.
Am using the latest version of chrome.
SF Domain is on CS21.

Great to hear I'm not the only one experiencing it - I thought I was alone :-)
I spent a long time with Salesforce Tier 2 & 3 support (almost two months) and several support cases, but they would not look into the issue purely based on the fact that a 3rd party app is involved.
I then demonstrated a different third party app (PermComparator) which exhibits the identical behavior.
The only way they (SF) might help support this issue is as a development issue.  i.e. Some developer who has the source code for a third party app (like workbench or perm comparator) who understands the oAuth workflow and how it's failing in this scenario.
I'm 99% sure the failure is at SFDC end of things, but I am not fluent enough in PHP to debug SFDC workbench code at this level.

I found a workaround that worked for me:
a) For posterity, I cleared all of browser (chrome) settings (cache/cookies,etc.) earlier
b) All browser sessions shutdown and restarted
c) Using icognito mode, launched developer workbench site (selecting sandbox, api 32)
d) Entered full credentials
e) Before submitting, I changed "test.salesforce.com" in the url to my org domain
(ie, OrgName--SandBoxNameuat.cs21.my.salesforce.com) - this was actually suggested to me by Puneet @ SFDC
f) Workbench came up as expected
g) Closed incognito session
h) Opened new browser session to UAT instance (non-incognito mode)
i) Authenticated as normal; launched workbench site
j) A user username page displayed; clicked active/desired user name
k) Workbench came up as expected

Not sure if I follow step e).
Changing the URL in the address bar before submitting the login form will not change where the form is submitted to (unless you also hit ENTER in the URL bar on step e)?
I've found that step not to be necessary.  Bottom line for me is:

if the browser already has an authenticated SFDC session, cannot get into workbench
if the browser has no session with SFDC, workbench login succeeds

The identical behavior can be observed with this application as well.
https://perm-comparator.herokuapp.com/


Fix auto-scrolling after resizing window

See #176
I'm not sure how the build works so it's not tested yet.

thanks!


Rename _dyn_reloc

I can't see any reason why _dyn_reloc needs to be #[no_mangle] or start with an underscore. It is always called by passing a sym argument to an asm! block. We should just let the compiler mangle this.

agreed .. see #4


I don't understand the benefits of this project

"K8s complexity" is an over statement  - Developers have a hard time understanding the life/complexity of an Ops guy, it's just like the early ages of window managers SDK.

Are you completely abstracting from k8s? for all use cases?
Are you solving the complexities around building the docker image?
Are you solving the complexities around logging?
Are you solving the complexities around observability?
Are you solving the complexities around dependencies and deployment strategies?
Are you solving the complexities around debugging?
Sorry, I don't see how your solution helps.
It's just a facade that poorly criticizes a full featured product at the cost of an opinionated architecture with heavy limitations.
My 2c.

Hi Olivier,
Thank you for your feedback. This project intends to solve deployment complexities faced by developers and DevOps with an app-centric abstraction framework over Kubernetes. Some of the use cases ( building Dockerfile, debugging) you have mentioned are already covered by HyScale, and some are on our roadmap. We are a small team trying to bring K8s close to the dev community. You can read more about our approach towards abstraction here


Compiler Error CS0518 - Alternative Solution Not Listed in Help Article

This issue has been moved from a ticket on Developer Community.

I occasionally receive CS0518 in Visual Studio 2022. The help link directes here: https://learn.microsoft.com/en-us/dotnet/csharp/language-reference/compiler-messages/cs0518
To resolve the issue, I simply unloaded and reloaded the project in Visual Studio.  This is not listed as one of the possible solutions to try. I suggest this be added to the article.
Thanks!

Original Comments
Feedback Bot on 11/13/2023, 07:27 AM:
(private comment, text removed)
Feedback Bot on 11/17/2023, 01:14 AM:
(private comment, text removed)

Original Solutions
(no solutions)

I remember I was affected by this error several times back in the days, and I confirm reloading the project often solves it (and other bizarre issues as well).
Let me add that suggestion as an optional way.


A2DP And DF Mini Player

Hardware:
Board: ESP-WROOM-32
Core Installation/update date: 01/SEP/2021
IDE name: Arduino IDE
Dear,
I have a project with a "DF mini player" that plays music from a SD card and output in a 24bit DAC format on an amp.
Documentation
I am interested in your code and I am able to run your example without no problem. Now I want to implement it to my project.
How do I stitch those two projects together with only one amp? Do I connect the dac output of the "DF mini player" to the ESP32? And how do I handle that audio format data?
Kind regards
Dave

I came to the conclusion that an audio mixing cable would be the best solution.

Yes but is really depends on what you want to achieve: This board is pretty cool because it already provides all the audio functionality itself

True, soo it would be not that smart to send it back to the esp32 and converted back to digital. At first my solution was another sd boards, but that diden't give some satisfying results because of the lack of mp3 . Soo the best thing for me is a mixing cable or even an adapter.

You could try to use I2S input using the built in ADC mode to sample the output from your board.

I prefere also the I2S communication, but the board I am using has only uart and it only can be used to send commands.


Add a LICENSE

Hi!
We're looking to use your plugin, but I noticed this repo is not fully licensed (only MIT marker in setup.py) as opposed to https://github.com/best-doctor/flake8-expression-complexity.
Could you add the MIT license to this repo and make a new release?
Thanks in advance,
David

Thanks for the report. Done in 0.1.0.

Thanks for the quick response! 💥


[core] File extension case sensitivity

On Windows file systems, file names are usually treated as case-insensitive. IsFileExtension could use stricmp instead of strcmp in the Windows build. Although, I think this function, like Unix's strcasecmp, may be non-standard and/or non-portable.

Sounds good to me. Would you like to submit a pull request for it? (add a static my_stricmp(const char *, const char*) and adjust IsFileExtension to use it. You may think of a better name than my_stricmp...).

I prefer to include all the required code in the same function, I try to avoid any additional function if possible.

I was pointing at this function particularly, but any file name (i.e., title and extension) comparison on Windows should be case insensitive.
Anyway, this is quite ugly but you could try this...
bool IsFileExtension(const char *fileName, const char *ext)
{
    bool result = false;
    const char *fileExt;

    if ((fileExt = strrchr(fileName, '.')) != NULL)
    {
    #if defined(_WIN32)
        const int fileExtLen = MultiByteToWideChar (CP_UTF8, MB_ERR_INVALID_CHARS, fileExt, -1, NULL, 0);
        const int extLen = MultiByteToWideChar (CP_UTF8, MB_ERR_INVALID_CHARS, ext, -1, NULL, 0);

        if (fileExtLen == 0 || extLen == 0)
        {
            goto fallback;
        }

        wchar_t *fileExtW = (wchar_t*)malloc(fileExtLen * sizeof(wchar_t));
        wchar_t *extW = (wchar_t*)malloc(extLen * sizeof(wchar_t));

        if (fileExtW == NULL || extW == NULL)
        {
            if (fileExtW != NULL) free (fileExtW);
            if (extW != NULL) free (extW);

            goto fallback;
        }

        MultiByteToWideChar (CP_UTF8, MB_ERR_INVALID_CHARS, fileExt, -1, fileExtW, fileExtLen);
        MultiByteToWideChar (CP_UTF8, MB_ERR_INVALID_CHARS, ext, -1, extW, extLen);

        if (lstrcmpi(fileExtW, extW) == 0) result = true;

        free (fileExtW);
        free (extW);

        return result;
    fallback:
    #endif
        if (strcmp(fileExt, ext) == 0) result = true;
    }

    return result;
}

@TakoNekko If we do this, I think it should behave the same on all platforms for consistency. Also why not compare the UTF-8 strings directly, without UTF-16 conversion?
@raysan5 I believe it can be useful elsewhere, so makes sense to have it as separate function.

@a3f The macro lstrcmpi expands to lstrcmpiW if the preprocessor definition UNICODE is defined, and to lstrcmpiW otherwise. lstrcmpiA works with narrow strings (ANSI, not UTF-8), while lstrcmpiW works with wide strings (UTF-16).
lstrcmpiA can be used directly if support for international languages in file names is not a requirement.
bool IsFileExtension(const char *fileName, const char *ext)
{
    bool result = false;
    const char *fileExt;

    if ((fileExt = strrchr(fileName, '.')) != NULL)
    {
    #if defined(_WIN32)
        #if defined(UNICODE)
            const int fileExtLen = MultiByteToWideChar (CP_UTF8, MB_ERR_INVALID_CHARS, fileExt, -1, NULL, 0);
            const int extLen = MultiByteToWideChar (CP_UTF8, MB_ERR_INVALID_CHARS, ext, -1, NULL, 0);

            if (fileExtLen == 0 || extLen == 0)
            {
                goto fallback;
            }

            wchar_t *fileExtW = (wchar_t*)malloc(fileExtLen * sizeof(wchar_t));
            wchar_t *extW = (wchar_t*)malloc(extLen * sizeof(wchar_t));

            if (fileExtW == NULL || extW == NULL)
            {
                if (fileExtW != NULL) free (fileExtW);
                if (extW != NULL) free (extW);

                goto fallback;
            }

            MultiByteToWideChar (CP_UTF8, MB_ERR_INVALID_CHARS, fileExt, -1, fileExtW, fileExtLen);
            MultiByteToWideChar (CP_UTF8, MB_ERR_INVALID_CHARS, ext, -1, extW, extLen);

            if (lstrcmpiW(fileExtW, extW) == 0) result = true;

            free (fileExtW);
            free (extW);

            return result;
        fallback:
        #else
            if (lstrcmpiA(fileExt, ext) == 0) result = true;
        #endif
    #endif
        if (strcmp(fileExt, ext) == 0) result = true;
    }

    return result;
}

Wow... what a piece of code... do we really need to consider UTF8?
I always try to keep things as simple as posible, despite losing some functionality or performance... I mean, I understand we are supposed to consider all possible situations and try to preview user missuses... but I'd go for a simpler solution to this specific case:
    if ((fileExt = strrchr(fileName, '.')) != NULL)
    {
        result = true;
        int extLen = strlen(ext);
        for (int i = 0; i < extLen; i++)
        {
            if (fileExt[i] != tolower(ext[i]))
            {
                result = false;
                break;
            }
        }
    }

I think this is good enough for comparing file extensions since they're usually made of 0-9 digits and a-z letters!
Should there be a length comparison as well? (i.e., if (strlen (fileExt) == extLen)), otherwise "name.mdl" will match ".md", for example.

Hey @TakoNekko! Good catch! I'll update it asap!

Implemented in commit https://github.com/raysan5/raylib/commit/9318dc98ce647acd9a718243555996618e95b959


fix: disable app sandbox when --no-sandbox is present

Refs https://github.com/microsoft/vscode/issues/184687

Thanks!


Remove hard dependence on ruby

The dep will get pulled in by gz-tools

follow-up: https://github.com/gazebo-release/sdformat14-release/pull/2


More loggers: A maybe-like combinator, and screen-specific loggers

Description
I added some more loggers:

For multi-monitor setups:

logWhenActive to have loggers active only when a certain screen is active.
logTitleOnScreen, logLayoutOnScreen and logCurrentOnScreen as screen-specific versions of logTitle, logLayout and logCurrent

A "combinator": logMaybe which works like maybe (and an infix version for it (.|)
logConst to log a constant String (I find that it feels better than writing return . Just repeatedly, but I didn't change it in the file... maybe see first what people feel about it?)
Minor cleanups (documentation fix, one hlint suggestion)

Checklist

[x] I've read CONTRIBUTING.md

[x] I tested my changes with xmonad-testing

[x] I updated the CHANGES.md file

[x] I updated the XMonad.Doc.Extending file (if appropriate)

@liskin  @slotThe  Thank you for the reviews! I'll try to resolve the comments ASAP

@liskin  @slotThe  Thank you for the reviews! I'll try to resolve the comments ASAP

@liskin  @slotThe  Thank you for the reviews! I'll try to resolve the comments ASAP

@liskin  @slotThe  Thank you for the reviews! I'll try to resolve the comments ASAP

This seems fine to me now and all other objections also seem to have been fixed; will merge in a few days if there are no further objections

This seems fine to me now and all other objections also seem to have been fixed; will merge in a few days if there are no further objections

Awesome, thank you all for the review!

Awesome, thank you all for the review!


[TEST] Cache test data

Fix #2911. Cache the test data to avoid redundant download from internet.
Currently only cache the test data, not the tutorial data.
cc @tqchen @srkreddy1238

Thanks @icemelon9 this is now merged

@icemelon9 I think it also makes sense to use the same tool to download tutorial data(because they also run everytime in CI) can you bring that change in?

Sure. I'll follow up with a new PR.


Memory leaking bug

Hi, Thanks for your work.
I found the train process got slower and slower during running. After inspection, I suspect
there's memory leaking problem in your code. In "train.py", model.summary() is called, which will
add the computing graph new node each training step. This will make the computational graph larger and larger and leading to slower training. Actually, this function is already called and added to the graph at the model.py init() the last line "... = self.summary()".
If you check the leimao's original code, you'll find it doesn't have this line.
Removing this model.summary() at train.py will fix the memory leaking bug.

Thanks to your comment
I fixed and commit
Best,


KubernetesClientException: too old resource version

Image used  : gcr.io/spark-operator/spark:v3.1.1
kubernetes client jar: kubernetes-client-4.12.0.jar
We are getting this issue intermittently
Relevant Logs:
 io.fabric8.kubernetes.client.KubernetesClientException: too old resource version
	at io.fabric8.kubernetes.client.dsl.internal.WatchConnectionManager$1.onMessage(WatchConnectionManager.java:258)
	at okhttp3.internal.ws.RealWebSocket.onReadMessage(RealWebSocket.java:323)
	at okhttp3.internal.ws.WebSocketReader.readMessageFrame(WebSocketReader.java:219)
	at okhttp3.internal.ws.WebSocketReader.processNextFrame(WebSocketReader.java:105)
	at okhttp3.internal.ws.RealWebSocket.loopReader(RealWebSocket.java:274)
	at okhttp3.internal.ws.RealWebSocket$2.onResponse(RealWebSocket.java:214)
	at okhttp3.RealCall$AsyncCall.execute(RealCall.java:203)
	at okhttp3.internal.NamedRunnable.run(NamedRunnable.java:32)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
	at java.base/java.lang.Thread.run(Unknown Source)

Any pointers on how to fix this?

Relevant discussion - https://issues.apache.org/jira/browse/SPARK-33349

We're seeing the exact same issue with pyspark v3.2.1. The streaming jobs are just stalling instead of the driver quitting so the job can start again.
22/03/28 19:57:19 WARN ExecutorPodsWatchSnapshotSource: Kubernetes client has been closed (this is expected if the application is shutting down.)
io.fabric8.kubernetes.client.WatcherException: too old resource version:<PHONE_NUMBER><PHONE_NUMBER>)
	at io.fabric8.kubernetes.client.dsl.internal.WatchConnectionManager$TypedWatcherWebSocketListener.onMessage(WatchConnectionManager.java:103)
	at okhttp3.internal.ws.RealWebSocket.onReadMessage(RealWebSocket.java:323)
	at okhttp3.internal.ws.WebSocketReader.readMessageFrame(WebSocketReader.java:219)
	at okhttp3.internal.ws.WebSocketReader.processNextFrame(WebSocketReader.java:105)
	at okhttp3.internal.ws.RealWebSocket.loopReader(RealWebSocket.java:274)
	at okhttp3.internal.ws.RealWebSocket$2.onResponse(RealWebSocket.java:214)
	at okhttp3.RealCall$AsyncCall.execute(RealCall.java:203)
	at okhttp3.internal.NamedRunnable.run(NamedRunnable.java:32)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
	at java.base/java.lang.Thread.run(Unknown Source)
Caused by: io.fabric8.kubernetes.client.KubernetesClientException: too old resource version:<PHONE_NUMBER><PHONE_NUMBER>)
	... 11 more

@cmoad what's your k8 client and server version?

Server version: v1.21.9
Client version: kubernetes-client-5.4.1.jar
Should be good based on the compatibility matrix: https://github.com/fabric8io/kubernetes-client#kubernetes-compatibility-matrix

Faced the same issue.
Spark hangs forever right after the writing to parquet stage ended.
kubernetes-client-5.4.1
Server Version: version.Info{

Major:"1",
Minor:"21+",
GitVersion:"v1.21.5-eks-bc4871b",
GitCommit:"5236faf39f1b7a7dabea8df12726f25608131aa9"

Fwiw, we now believe this error was a red herring. We found the true cause to be a quiet OOM on an executor and this error seemed to happen a while later in the driver logs. Anyone else seeing this should heavily look for errors happening ~20-30 seconds before.

Server version: v1.20.15-eks-84b4fe6
Client version: kubernetes-client-5.4.1.jar
We are getting this issue intermittently

2022/08/28 19:51:20 INFO SparkTBinaryFrontendService: Client protocol version: HIVE_CLI_SERVICE_PROTOCOL_V6
2022/08/28 19:51:20 INFO SparkSQLSessionManager: Opening session for<EMAIL_ADDRESS>2022/08/28 19:51:20 WARN SparkSessionImpl: Cannot modify the value of a Spark config: spark.driver.memory
2022/08/28 19:51:20 INFO SparkSQLSessionManager: hive's session with SessionHandle [4465a33f-8ac6-4f0b-bccd-dd4702ee0b7b] is opened, current opening sessions 1
2022/08/28 20:42:34 WARN ExecutorPodsWatchSnapshotSource: Kubernetes client has been closed (this is expected if the application is shutting down.)
io.fabric8.kubernetes.client.WatcherException: too old resource version: 61967434 (62009935)
at io.fabric8.kubernetes.client.dsl.internal.WatchConnectionManager$TypedWatcherWebSocketListener.onMessage(WatchConnectionManager.java:103)
at okhttp3.internal.ws.RealWebSocket.onReadMessage(RealWebSocket.java:323)
at okhttp3.internal.ws.WebSocketReader.readMessageFrame(WebSocketReader.java:219)
at okhttp3.internal.ws.WebSocketReader.processNextFrame(WebSocketReader.java:105)
at okhttp3.internal.ws.RealWebSocket.loopReader(RealWebSocket.java:274)
at okhttp3.internal.ws.RealWebSocket$2.onResponse(RealWebSocket.java:214)
at okhttp3.RealCall$AsyncCall.execute(RealCall.java:203)
at okhttp3.internal.NamedRunnable.run(NamedRunnable.java:32)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
at java.base/java.lang.Thread.run(Unknown Source)
Caused by: io.fabric8.kubernetes.client.KubernetesClientException: too old resource version: 61967434 (62009935)
... 11 more

Are your set AllowWatchBookmarks param for watch opt ？
https://kubernetes.io/docs/reference/using-api/api-concepts/

Hello,
I have a similar situation with my spark application, here are the relevant logs:
22/10/20 11:10:33 INFO SharedState: Warehouse path is 'file:/opt/spark/work-dir/spark-warehouse'.
22/10/20 11:44:46 WARN ExecutorPodsWatchSnapshotSource: Kubernetes client has been closed (this is expected if the application is shutting down.)
io.fabric8.kubernetes.client.WatcherException: too old resource version: 58557205 (58564779)
	at io.fabric8.kubernetes.client.dsl.internal.WatchConnectionManager$TypedWatcherWebSocketListener.onMessage(WatchConnectionManager.java:103)
	at okhttp3.internal.ws.RealWebSocket.onReadMessage(RealWebSocket.java:323)
	at okhttp3.internal.ws.WebSocketReader.readMessageFrame(WebSocketReader.java:219)
	at okhttp3.internal.ws.WebSocketReader.processNextFrame(WebSocketReader.java:105)
	at okhttp3.internal.ws.RealWebSocket.loopReader(RealWebSocket.java:274)
	at okhttp3.internal.ws.RealWebSocket$2.onResponse(RealWebSocket.java:214)
	at okhttp3.RealCall$AsyncCall.execute(RealCall.java:203)
	at okhttp3.internal.NamedRunnable.run(NamedRunnable.java:32)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
	at java.base/java.lang.Thread.run(Unknown Source)
Caused by: io.fabric8.kubernetes.client.KubernetesClientException: too old resource version: 58557205 (58564779)
	... 11 more
22/10/20 12:01:37 INFO CodeGenerator: Code generated in 516.484966 ms

I don't have any other exception or error message in my logs, driver or executors.
Is there something I can try?
Thank you.

I would recommend we close this issue. Several of us have reported this error message as downstream from the true, critical failure.

@cmoad what is the solution for this?

if you are using gcs, I got no logs on spark 3.0.0. After upgrading to 3.3.0 I no longer say the too old resource version and started seeing see that the "hanging" behavior was actually spark repairing a bunch of directories in my bucket. https://groups.google.com/g/cloud-dataproc-discuss/c/JKcimdnskJc recommends setting "fs.gs.implicit.dir.repair.enable" to False


chore: introduce eslint-plugin-spellcheck

I added eslint-plugin-spellcheck and configured it (a bit)
Then I fixed some typos https://github.com/vitejs/vite/commit/f7d69f4216f22b2f70a37fb16e7162c50f30e226
Also I renamed some wordings https://github.com/vitejs/vite/commit/1675b3cf546cd661dae066c58da3ed72697fa2e0
If preferred I can revert the renames
It's also arguable if you want eslint-plugin-spellcheck in the project and have such a "huge" config of words
I may contact @aotaduy so they can adept some common words. That could also help other projects out there :slightly_smiling_face:

My first reaction was to reject it because of renames like segs to segments, but I imagine that we could live with longer variable names or even add the most commonly used short versions to the skip list.
I also think that this would be positive. Is there something similar for markdown files so the docs are checked?

I also think that this would be positive. Is there something similar for markdown files so the docs are checked?

I'm not directly sure. Currently it may be possible to configure eslint to not only check js,ts etc.
But (if it is possible) we should do this in a further step/issue/pr.

For the plugin, I'd actually prefer one-time CLI tools or IDE extensions as I don't think spell check is something that important to persistent live in the CI process. We can run spell check once a while and fix them in a single commit so we don't need to sacrifice anything while keeping the commit history cleaner.

A nice thing using the lint step could be to show it directly in the review
I opened a discussion about that here: https://github.com/vitejs/vite/discussions/2604

There is a VSCode Plugin: https://marketplace.visualstudio.com/items?itemName=streetsidesoftware.code-spell-checker
But it differs a bit and know some other worlds as the lint plugin

We could extract an additional lint script that specifically lint the project for spell-check. But in the end it is kinda the same as just running it in the normal lint step and otherwise folks would just forget to run it / the forget it.

For the plugin, I'd actually prefer one-time CLI tools or IDE extensions as I don't think spell check is something that important to persistent live in the CI process. We can run spell check once a while and fix them in a single commit so we don't need to sacrifice anything while keeping the commit history cleaner.

^ I agree with this - we could just run a typecheck tool once in a while. I don't really want spellcheckers to lint/affect source code variable names.

@Shinigami92 Maybe let's close this for now?


VirtualService uri rewrite is ignored when routing between internal services

Bug description
Uri rewrite for a VirtualService resource where the host is an internal service and the destination is also an internal service does not work. (See steps to reproduce for an example of the VirtualService)
Affected product area (please put an X in all that apply)
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[X] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Expected behavior
Uri should be rewritten as expected.
Steps to reproduce the bug
When a VirtualService like the following is created:
apiVersion: networking.istio.io/v1alpha3
kind: VirtualService
metadata:
  name: first-hop
spec:
  gateways:
    - default
  hosts:
    - my-load-balancer-host
  http:
    - match:
        - uri:
            exact: /app.js
      # working
      rewrite:
        uri: /first-rewrite-uri
      route:
        - destination:
            host: foo-service.default.svc.cluster.local
            port:
              number: 8080
---
apiVersion: networking.istio.io/v1alpha3
kind: VirtualService
metadata:
 name: second-hop
spec:
  hosts:
    - foo-service.default.svc.cluster.local
  http:
    - match:
        - uri:
            exact: /first-rewrite-uri
          port: 8080
      # Not working
      rewrite:
        uri: /second-rewrite-uri
      route:
        - destination:
            host: my-app.default.svc.cluster.local
            port:
              number: 8080

When we curl my-load-balancer-host/app.js, the uri is correctly re-written to /first-rewrite-uri as seen in the first-hop VirtualService. However, even though the request is correctly routed to my-app.default.svc.cluster.local at the end, the uri is not re-written to /second-rewrite-uri .  (I can see the request path of incoming requests from the logs of my-app)
When I run the istioctl proxy-config routes <my-app-pod-name> -o json command, I can see that the rewrite configuration is correct reflected, but just not taking effect:
{
  ...
  ...
  "name": "foo-service.default.svc.cluster.local:8080",
  "domains": [
      "foo-service.default.svc.cluster.local",
      "foo-service.default.svc.cluster.local:8080",
  ],
  "routes": [
      {
          "match": {
              "exact": "/first-rewrite-uri",
              "caseSensitive": true
          },
          "route": {
              "cluster": "outbound|8080||my-app.default.svc.cluster.local",
              "prefixRewrite": "/second-rewrite-uri",
              "hostRewrite": "",
              "timeout": "0s",
              "retryPolicy": {
                  "retryOn": "connect-failure,refused-stream,unavailable,cancelled,resource-exhausted,retriable-status-codes",
                  "numRetries": 2,
                  "retryHostPredicate": [
                      {
                          "name": "envoy.retry_host_predicates.previous_hosts"
                      }
                  ]
...
...
}

Version (include the output of istioctl version --remote and kubectl version)
citadel version: 1.3.0
egressgateway version: 1.3.0
galley version: 1.3.0
ingressgateway version: 1.3.0
pilot version: 1.3.0
policy version: 1.3.0
sidecar-injector version: 1.3.0
telemetry version: 1.3.0
Using EKS with Kubernetes v1.13

I see that it doesn't work, but I don't think this is or should be a valid config in the first place. Logically you are trying to make a virtual service with "two hops" -- but in reality there will only be one hop.
Is there any reason you cannot just make a single VirtualService here? If it wasn't clear, VS only apply on the client side, so you are never actually getting two hops -- it is all done by the gateway

I tried this out with a single virtual service that is not attached to any gateway, and the uri rewrite is not happening too. Below is an example of the virtualservice i used:
apiVersion: networking.istio.io/v1alpha3
kind: VirtualService
metadata:
  name: test-route
spec:
  hosts:
  - service-one.default.svc.cluster.local
  http:
  - match:
    - uri:
        prefix: /
    rewrite:
      uri: /written-uri
    route:
    - destination:
        host: service-two.default.svc.cluster.local

To give more context, we are trying to use Istio VirtualService uri rewrites and weighted routes to load balance traffic between 2 endpoints served by a single Kubernetes service.
Example:
apiVersion: networking.istio.io/v1alpha3
kind: VirtualService
metadata:
  name: first-hop
spec:
  gateways:
    - default
  hosts:
    - my-load-balancer-host
  http:
    - match:
        - uri:
            exact: /app.js
      route:
        - destination:
              host: dummy-service-for-new-script.default.svc.cluster.local
            weight: 90
        - destination:
              host: dummy-service-for-old-script.default.svc.cluster.local
            weight: 10
---
apiVersion: networking.istio.io/v1alpha3
kind: VirtualService
metadata:
 name: new-script-route
spec:
  hosts:
    - dummy-service-for-new-script.default.svc.cluster.local
  http:
    - match:
        - uri:
            exact: /app.js
      rewrite:
        uri: /static/new-app.js
      route:
        - destination:
            host: my-app.default.svc.cluster.local
---
apiVersion: networking.istio.io/v1alpha3
kind: VirtualService
metadata:
 name: old-script-route
spec:
  hosts:
    - dummy-service-for-old-script.default.svc.cluster.local
  http:
    - match:
        - uri:
            exact: /app.js
      rewrite:
        uri: /static/old-app.js
      route:
        - destination:
            host: my-app.default.svc.cluster.local

While trying out the configuration above, we realised that even though traffic was still routed to my-app correctly, the uri was not re-written.
Sorry could you also explain further what you mean by VS routing never actually getting two hops?  Thank you!

It seem to me in your original config you expected the request to go from Ingress ---- rewrite1 ---> foo ----- rewrite2 ---> my-app but that doesn't actually happen. It will just go directly from ingress to my-app
@Janesee3 I tried out the example you gave, slightly modified to my services:
cat <<EOF | kaf -
apiVersion: networking.istio.io/v1alpha3
kind: VirtualService
metadata:
  name: test-route
spec:
  hosts:
  - productpage.default.svc.cluster.local
  http:
  - match:
    - uri:
        prefix: /
    rewrite:
      uri: /get
    route:
    - destination:
        host: httpbin.default.svc.cluster.local
EOF

and it worked as expected.
I am not sure if the first case of multiple hops should work (I suspect not), but the above definitely should

Oh I see, so as long as we have a VirtualService entry from Ingress --- my-app, all other VS applied to host: my-app would not apply?
Also, can I clarify that uri rewrite wouldn't work for "self-routing" VS? Like for example:
# Assuming that my-app is not routed from another VS via the Ingress
apiVersion: networking.istio.io/v1alpha3
kind: VirtualService
metadata:
  name: self-route
  namespace: services
spec:
  hosts:
  - my-app.default.svc.cluster.local
  http:
  - match:
    - uri:
        prefix: /
    rewrite:
      uri: /written-uri
    route:
    - destination:
        host: my-app.default.svc.cluster.local

The above should work. If not please open an issue with a config dump from envoy attached. Thanks!


content update | fix typo

In the
< Contributing to codes.wmo >
section
provide information on how to propose an update fixing a typographical change

If you notice a typo in the register, for example, you notice ‘velocity’ is spelled ‘vecolity’, this is how you can get it changed:

The first step is to get the text so you can change it - so download the content in the RDF ttl-plain format.
Open the file with a text editor, find the typo and fix all instances of it.

Make a new file.
Name the file, ending in .ttl
Copy and paste all the amended text into the new file.
When you are proposing the new file, add an extended description so we know what you’ve changed.
Hit the green ‘propose new file’ button.
Review your change and hit the green ‘create pull request’ button.
That’s it - thanks!
Next up we’ll talk to our experts about the change you’ve suggested then evaluate it in our test system.
We’ll get back to you through GitHub with an update to let you know what’s happening and if there’s further input we’d like from you.

During IPET-MDRD-4 meeting, folks spotted a typo ... so I thought I'd try out your process to fix. At step (8) I had the option to 'commit direct to master' ... I guess that's because I've got commit privilege? Other than that, it was quite simple. I'll share this processing with folks tomorrow, time permitting.

Jeremy just demonstrated this - good work! I questioned whether instead of requiring download from the registry and upload of a new file whether it would be better to use the 'normal' github workflow directly on the .ttl files in github.
i..e find ttl file that is broken,
fork > edit > pull request - discuss, merge
(if you try to edit a file you don't have access to github automatically offers to create a fork)


download_llvm bad URL

Could be a temporary problem. Or some sort of the Github site changed.
The premake script fails because of a bad Github URL. This process worked a few days ago.
~/src/CppSharp/build$ ./premake5-linux-64 --file=scripts/LLVM.lua download_llvm
Downloading: https://github.com/mono/CppSharp/releases/download/CppSharp/llvm-815d4b-linux-x64-gcc-7-Release.tar.xz

Error: /home/polar/src/CppSharp/build/scripts/Utils.lua:98: HTTP response code said error
The requested URL returned error: 404 Not Found

I'm guessing @ddobrev deleted some previous LLVM packages when updating to the most recent LLVM this week.

Same here, there's nothing LLVM related on the release page. Is anyone into that?

@tritao I did. @befedo @polar we don't like keeping too old packages around because we don't want to encourage people to keep using old versions. Is there anything preventing you from using our newer code?

@ddobrev Yes, for now. I have a branch on my own fork with "enhancements" to do specific things, like address the generic use of std::vector and other classes specific templates to my application. I just don't yet have the time to merge your master back into it yet and check to see if it works. :) I'll get around to it eventually, but right now I've got other fires to address.

@polar I understand. I might have some of the packages lying around so I'll try finding them tomorrow. This way the build will be restored.
Could you please tell more about your support for std::vector<T>. We intend to support it ourselves, we already support templates and we just need to generate convenient wrappers for it. I would be curious to compare our approach to yours.

@befedo You need to go to the last page of releases to find the LLVM packages: https://github.com/mono/CppSharp/releases/tag/CppSharp
Sorry for the breakage, we certainly don't want to break folk who are still using earlier versions. I've discussed with @ddobrev and we will make sure going forward we will do a better job of keeping earlier versions around.
I've also restored the macOS version package llvm-815d4b-macosx-x64-Release.tar.xz that I had still on my local machine.

@polar I've restored the Linux package, let me know if it fails to work.

@tritao Thanks for the hint ...
In the meantime I've build LLVM from source, and all CppSharp test went through.
Thanks for your time and best regards,
Befedo


Show examples in not working after build

Hi,
I deployed docbox locally using npm run build and everything works just fine. However, "Show examples in: cURL cli Python JS Java ObjC Swift" toggles are not working.
Toggles are working fine using npm start.
Any clue why when deployed locally toggles are not working?

Possibly you cloned docbox before feb 22, when a fix for publishing was rolled out?

Not really. I cloned recently and still same problem

Hi again, any update on this issue?
Note: the issue happens only when I run the build. If I do npm start it works as expected.
Also running the build the second time for updating the content, the documentations becomes a mess. I have to reset the index page to the empty one and run the build again.


Download ISO from SeedImage menu

I wonder if it would make sense to be able to download ISO directly from the SeedImage menu:

Something like adding a Download button.
I'm asking because if you trigger a build in machine registration endpoint and then you navigate to another menu, you lose the ability to download and you have to build again.
@aalves08 @fgiudici WDYT?

Yep, looks a great idea to me! If it is not that hard to implement (only @aalves08 could tell!), that could be a smart way to allow to re-download built ISO.

It's not hard to implement, since the url is there (if the iso build succeeds).
One comment is that the Seed Image resource wasn't even supposed to appear "as a page" under Elemental and now we are putting "more" effort into it.
We should have a discussion with @kwwii during an Elemental sync just to make sure the user experience for the next version (not the one about to release) is going to leverage the usage of this resource as a "usable interface" because I was under the impression that we were supposed to "kill" this once we have a way to clean up the seed images automatically.

It's not hard to implement, since the url is there (if the iso build succeeds).
One comment is that the Seed Image resource wasn't even supposed to appear "as a page" under Elemental and now we are putting "more" effort into it.
We should have a discussion with @kwwii during an Elemental sync just to make sure the user experience for the next version (not the one about to release) is going to leverage the usage of this resource as a "usable interface" because I was under the impression that we were supposed to "kill" this once we have a way to clean up the seed images automatically.

Ah, so maybe I can postpone this https://github.com/rancher/elemental/issues/788

Could be also valuable to keep SeedImage menu and leverage it to configure cloud-init (I know we said to keep advanced usage like that one to cmdline but...), I'm thinking about a form like we have to create a registration endpoint. Let's add @kkaempf and @agracey  to the discussion.

Re-building a SeedImage is cheap and will happen as you iterate to create the perfect ISO image for your hardware/usecase.

This is going to be especially true once the base isos are coming from an OCI artifact that can be better cached

Ok let's close it then and as we discussed during the sync meeting, SeedImage menu will be removed in favor of adding a list in Registration Endpoint, I can also close the automation task around the SeedImage menu.


Implement Verify Test

gofmt - all the files
golint - all the files
fix imports
Added the verify script for below tests

verify-boilerplate.sh
verify-godeps.sh
verify-gofmt.sh
verify-golint.sh
verify-govet.sh
Currently we skip golint (internally)  our source code as it needs fixing, we should re-enable it after the errors have been fixed.

/assign @shivramsrivastava

Thanks.
/lgtm

@ICGog

I have verified the changes.
/approve

/lgtm
/approve

/lgtm

@dhilipkumars Can you please explain why we had to bring in the hack directory?

I am assuming this is somewhat of a convention in Kubernetes community to have a temporary directory for storing commonly used scripts in, I think.
@dhilipkumars Could you please confirm it. Thanks.

@ICGog Yes, that contains all the makefiles and verification script, its basically like a framework verification script, this is adopted from kubernetes/kubernetes to other projects also eg: federation, kops , etc., all have similar hack directory.
Currently we have these verification steps, (we may add a couple more)
verify-all.sh  verify-boilerplate.sh  verify-godeps.sh  verify-gofmt.sh  verify-golint.sh  verify-govet.sh  verify-linkcheck.sh

but kubernetes has this many, we dont need most of them.
verify-all.sh                 verify-cloudprovider-gce.sh        verify-generated-files-remake.sh  verify-gofmt.sh        verify-no-vendor-cycles.sh   verify-symbols.sh
verify-api-groups.sh          verify-codegen.sh                  verify-generated-protobuf.sh      verify-golint.sh       verify-openapi-spec.sh       verify-test-images.sh
verify-api-reference-docs.sh  verify-description.sh              verify-generated-runtime.sh       verify-govet.sh        verify-pkg-names.sh          verify-test-owners.sh
verify-bazel.sh               verify-flags-underscore.py         verify-generated-swagger-docs.sh  verify-import-boss.sh  verify-readonly-packages.sh
verify-boilerplate.sh         verify-generated-device-plugin.sh  verify-godep-licenses.sh          verify-imports.sh      verify-staging-godeps.sh
verify-cli-conventions.sh     verify-generated-docs.sh           verify-godeps.sh                  verify-linkcheck.sh    verify-swagger-spec.sh


Add translations for NN and EN

Tried adding some JSDoc to FormProgress.step and seems to work ok. While we might not need JSDoc on each entry, adding it to the ones with "replacements" would be nice 📝

Good idea! While most texts don't need any explanation, what about including the English translation in the JSDoc for each key? I think it would be very useful to see the default text when adding a custom translation. Makes it easier to see what text you are translating/replacing.
If you agree with this, do you think we should use the English or the Norwegian text in the JSDoc? Norwegian is the default language, but we write JSDoc in English otherwise...
If we decide to use English then maybe we should also make en.ts the "master" (i.e. replace typeof nb with typeof en). This makes it easier when updating the English text.

AkselLanguageProvider has no autocomplete now, making it kind of hard to use. Think it would make sense to explore some solutions making it easier to use. One consequence now is that you won't get any errors even when the input data is invalid 💥

This should be fixed now. For the most part, only the types based on typeof nb should be used. Are the names of the types ok, or can you think of better names?

AkselLanguageProvider has no autocomplete now, making it kind of hard to use. Think it would make sense to explore some solutions making it easier to use. One consequence now is that you won't get any errors even when the input data is invalid 💥

This should be fixed now. For the most part, only the types based on typeof nb should be used. Are the names of the types ok, or can you think of better names?

Autocomplete works well now 🎉 But im getting no errors when inputting wrong values

This should be fixed now. For the most part, only the types based on typeof nb should be used. Are the names of the types ok, or can you think of better names?

Not any strong opinions on the types, but "Generic" tells me very little. But have few good alternatives. Would "Record" make more sense than "Object" suffix?

Maybe
- export type TranslationObject = typeof nb;
+ export type LocaleTranslations = typeof nb;

- export interface GenericTranslationObject {
-  [key: string]: GenericNestedTranslationObject;
- }
+ export interface TranslationMap {
+  [key: string]: NestedTranslationMap;
+ }

To me, "Record" doesn't say more than "Object", but should be redundant anyways.
The thought behind "generic" was to emphasize that the type accepts any keys, to distinguish it from the typeof nb type that accepts only specific keys.
I think "LocaleTranslations" is a bit redundant, so I suggest just "Translations". I've also moved the types that was only used in one file, to that file. This should make things clearer. I also liked "TranslationMap", but the name for that one is not as important when it's not exported anymore.


HDDS-3795. No coverage reported for Ozone FS

What changes were proposed in this pull request?
Ozone FS has some tests, but 0% coverage.  This change fixes the problem.
https://issues.apache.org/jira/browse/HDDS-3795
How was this patch tested?
Ran TestOzoneFSInputStream, verified that non-zero coverage is reported for OzoneFSInputStream (coverage.sh is taken from HDDS-3796):
mvn -Dskip.npx -Dskip.installnpx -DskipShade clean package
hadoop-ozone/dev-support/checks/unit.sh -DfailIfNoTests=false -Dtest=TestOzoneFSInputStream
hadoop-ozone/dev-support/checks/coverage.sh
open target/coverage/all/org.apache.hadoop.fs.ozone/OzoneFSInputStream.html

Now the package has 70% coverage.
https://github.com/adoroszlai/hadoop-ozone/runs/767653969

Codecov Report

Merging #1071 into master will increase coverage by 0.98%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1071      +/-   ##
============================================
+ Coverage     69.36%   70.35%   +0.98%
- Complexity     9097     9225     +128
============================================
  Files           961      961
  Lines         48127    48127
  Branches       4676     4676
============================================
+ Hits          33383    33858     +475
+ Misses        12524    12009     -515
- Partials       2220     2260      +40

Impacted Files
Coverage Δ
Complexity Δ

.../apache/hadoop/hdds/scm/node/StaleNodeHandler.java
88.88% <0.00%> (-11.12%)
4.00% <0.00%> (ø%)

...hdds/scm/container/common/helpers/ExcludeList.java
75.51% <0.00%> (-10.21%)
18.00% <0.00%> (-3.00%)

...g/apache/hadoop/hdds/utils/ResourceLimitCache.java
84.37% <0.00%> (-9.38%)
7.00% <0.00%> (-1.00%)

...apache/hadoop/hdds/scm/block/BlockManagerImpl.java
66.66% <0.00%> (-5.41%)
18.00% <0.00%> (ø%)

...apache/hadoop/ozone/client/io/KeyOutputStream.java
78.75% <0.00%> (-1.67%)
45.00% <0.00%> (-2.00%)

...he/hadoop/ozone/om/ha/OMFailoverProxyProvider.java
82.03% <0.00%> (-0.79%)
33.00% <0.00%> (-1.00%)

...iner/common/statemachine/DatanodeStateMachine.java
82.87% <0.00%> (-0.56%)
29.00% <0.00%> (-1.00%)

.../transport/server/ratis/ContainerStateMachine.java
69.36% <0.00%> (+0.22%)
59.00% <0.00%> (+1.00%)

.../apache/hadoop/ozone/om/OmMetadataManagerImpl.java
82.52% <0.00%> (+0.26%)
92.00% <0.00%> (+1.00%)

.../ozone/container/common/volume/AbstractFuture.java
30.38% <0.00%> (+0.51%)
20.00% <0.00%> (+1.00%)

... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd88eec...73371ce. Read the comment docs.

@adoroszlai Thanks for catching this and working on the fix! +1 LGTM

Thank You @adoroszlai for the contribution and @vivekratnavel for the review.

Thanks @vivekratnavel for the review, and @bharatviswa504 for reviewing and committing it.


Switch our private npm registry from Sinopia to Verdaccio

Sinopia has been abandoned and we're running into npm/yarn dependency issues. I think it might be time to switch to Verdaccio, an updated fork of the project.

Do we host private packages? how's the current sinopia configuration?

As a default, we've settled on pulling dependencies straight from npm.


Redo of Message Queue

Functionality moved to a base class CallQueue, which will be used for inter-thread communication within the scene.
MessageQueue now uses growing pages, starts from a single 4k page.
Limit still exists, but because its not allocated by default, it can be much higher.

Fixes #35653
Supersedes #62303 and #65740.

You're missing an empty line before the closing header guard :) This prevents the rest of the builds from running.

Also looks fine to me.

Thanks!


[GHSA-hfrp-5qw2-x2qm] A CWE-120: Buffer Copy without Checking Size of Input...

Updates

Affected products
References
Source code location
Summary

Comments
I am an Ethical Hacker but people want see me become a writer, a science fiction writer and I'll show you my job when I'll have money, I draw magnificent spaceships and I'll be the Canadian JK Rowling of space science fiction

I am an Ethical Hacker but I'll became A Writer of Science Fiction, my Mother want to see me a Canadian JK Rowling of Science Fiction Space, look up my Uncle's Spaceships, he lives in Montreal and I'll draw magnificent spaceships too


show if component extends other component

I've implemented small feature to show if component extends other component. This PR has it shown as below.

But I would consider showing it like this:

Then it would be possible to show it in component tree as well.
Closes #337

I forgot to ask in the issue 😆  but how does it help debugging?

You don't have to open up component file to look up where your data/methods come from. I guess we could also mark from which component certain parts of state come from directly in the inspector panel.

I've updated the PR to show full extension hierarchy

But how does that help? It doesn't tell where the data comes from either
On Wed, 11 Oct 2017, 19:06 Bartek Iwańczuk<EMAIL_ADDRESS>wrote:

I've updated the PR to show full extension hierarchy
[image: zrzut ekranu 2017-10-11 o 19 05 46]
https://user-images.githubusercontent.com/13602871/31454890-44d91b22-aeb7-11e7-9d93-dc0dc85a9e12.png
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/vuejs/vue-devtools/pull/429#issuecomment-335879391,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAoicVjzYv_pmX4G0mFb7SQ1h07b6vCYks5srPWsgaJpZM4P1ojI
.

--
Eduardo San Martin Morote


group sync not working with private organizations

Hi, group sync not working with private gitea organizations, only with public orgs. Is there is any way to import LDAP groups into gitea private org?

It does not matter whether the organization is private or public, the user will be added if the user is registered with the corresponding organization on your LDAP server and the user is included in the group of users who have access to your gitea server

gitea 1.15.0
i have admin user and some private orgs(not owner of them). i create gitea token and configure groupsync script. it works only with public orgs. i try to use gitea api(api/swagger) and check which orgs i can view(admin/orgs). but it shows same public orgs as a groupsync script.
groupsync with public orgs works perfectly

Do you use the gitea admin token? Try creating and adding a new comma-separated key. GITEA_TOKEN=c00c810bb668c63ce7cd8057411d2f560eac469c,2c02df6959d012dee8f5da3539f63223417c4bbe

Yes, i do. Recreating new admin token does not work.

I checked on the test server, adding users to a private organization is successful

did you use gitea 1.15.0?

Change the version to 1.15.1 or 1.15.2. The Gitea API version 1.15.0 does not return private organizations. I do not know why, it seems there was a bug

Gitea API 1.15.0

Gitea API 1.15.2

upgrade gitea to 1.15.2 fix problem. thanks


docs: Add coverage documentation

Getting coverage working on cross-arch environment is currently
not documented at all. Also coverage presentation in the web-ui
is unclear. This document addition addresses these
Signed-off-by: Jouni Hogander<EMAIL_ADDRESS>
Before sending a pull request, please review Contribution Guidelines:
https://github.com/google/syzkaller/blob/master/docs/contributing.md

Codecov Report

Merging #1585 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1585   +/-   ##
=======================================
  Coverage   56.91%   56.91%
=======================================
  Files         144      144
  Lines       26856    26856
=======================================
  Hits        15285    15285
  Misses      10791    10791
  Partials      780      780

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93e5e33...cd91259. Read the comment docs.


httpx.HTTPStatusError: Server error '502 Bad Gateway' for url 'http://ADDRESS:11434/api/chat'

I have OpenWebUI running fine with Ollama on another machine. I am trying to use the same endpoint with PrivateGPT but it gives me 502.
When attempting to query just the Ollama LLM:
HTTP Request: POST http://ADDRESS:11434/api/chat "HTTP/1.1 502 Bad Gateway"
But this works fine from the bash prompt on the same machine that PrivateGPT is running:
curl  http://ADDRESS:11434/api/chat -d '{ "model": "llama3-chatqa", "prompt": "What is water made of?" }'
embedding_api_base is set to the same as api_base which are both set to http://ADDRESS:11434
This page: https://docs.privategpt.dev/installation/getting-started/installation
Local, Ollama-powered setup - RECOMMENDED - this does not work out of the box. Ontop of the 502 error, now it gives me tons of other errors in the background. I have changed nothing except the API URL.

Can you confirm us your ollama version? I'm using 0.1.48 without any issue

Has you pulled last changes? Has you reinstalled dependencies and extras?


mod: bump<EMAIL_ADDRESS>

Fixes https://github.com/containerd/containerd/issues/10085

cc @acurtiz @bobbypage

LGTM

/cherrypick release/1.7
(Not sure this will work, but at least I can try...)

I expect the automated cherrypick to fail because it won't also update integration/client.  I'll prep a manual cherrypick as well.


couldn't parse external etcd version

I did a kubeadm init --config=kubeadm-init.yaml and got the below error while initialising.
[ERROR ExternalEtcdVersion]: couldn't parse external etcd version "": Version string empty

@rajesh-dcis can you show me your kubeadm-init.yaml file?

you get that error if kubeadm cant reach etcd during initialization. most likely the etcd endpoints given in the kubeadm-init.yaml  file are incorrect or ETCD is down.

Since it support v1.11.x now, we should close it