Advanced Notice: Nested Container support will be removed soon

This is just a heads-up for those who track issues that support for nested Containers will be removed from a forthcoming version of Phaser (not 3.12, but probably 3.13).
The ability to create and use Containers will remain, but you will no longer be able to add a Container as a child of another.
The reasons are two-fold:

It will improve speed as we'll no longer need to do any iteration during matrix or bounds calculations.

It will reduce API complexity (both internally and externally) - there are edge-cases where, for example, a deeply nested Game Object doesn't inherit the correct blend mode. Or issues like input handling needing to crawl up a container tree to find its ultimate position, all of which are adding un-needed code into the API and causing issues (both for you and me).

It's no secret that I never actually wanted Containers to be added as a feature at all. Look at the quality games made in Construct or Game Maker, for example, neither of which offer the feature. They have caused so much branching and additional work in the API that I really question their value, but at the same time, I know some devs like using them. So I won't outright nuke them (although, believe me, I've come close many times!) - but I do question their implementation. I think there is room to explore recoding the feature entirely, but in the meantime stopping the use of nested Containers will help mitigate a number of problems.

Construct2 has 'container' feature, but it worked different from container of phaser3 (or other framework) totally, it did not keep the related position and angle between parent and child object.
In the other hand, construct2 has an official behavior plugin named 'pin' which  did the container job -- keep the related position and angle between parent and child object, but it lacked of responding to scaling of parent object.
I don't know the state of 'container' feature in Construct3.

I’m curious but if it didn’t keep the transform related to the container, what did it actually do? 🙂 I suspect you can’t pin a pin onto another pin either?

Official pin behavior plugin of construct2 is added to child object. Every tick it will

calculate angle of child object related to parent object.
calculate position of child object by new angle and initial distance when pined to parent object.

It does not use transform  matrix like phaser3 does.
Since the executing order of behaviors is the same as the order of objects creating, nested pining might be worked only if child was created later than parent. In this condition, objects will calculate their position from root to leaf. Otherwise, the pining will not work well as you said.

Bad news for me... I was using Phaser.Group (Phaser 2) and Phaser.Containers a lot. In fact, currently I do not know how to code without it :-(
What is possible replacement of parent-child transform approach? If you need some child object move together with its parent, you again have to calculate its position (rotation, scale, ...)?
It was always great, that Phaser supported for example alpha in hierarchy, but even Unity does not have this. In Unity, if using Sprites and 2D features you can build hierarchies of sprites, but only position, rotation and scale (Transform) are propagated down to children. If you set alpha on parent, it does not affect alpha on child.
More, Phaser container are maintaining their lists of children and rendering all of them recursively, if containers are nested. Nice, but it breaks single flat display list, right? Unity 2D has two parameters for sprite: Sorting Layer and Order in Layer. Combination of these determines order of rendering regardless of sprites hierarchy. I do not know internal implementation, but for this you can maintain only single flat list - combination of Sorting Layer and Order in Layer is more or less setDepth in Phaser. Of course, in Unity, you can also use Z coordinate even with 2D sprites, but if using Sorting Layer and Order in Layer, then it has only 3rd level importance (1. Sorting Layer, 2. Order in Layer, 3. Z coordinate)
Let's look on this initial Unity setup:

Here are two hierarchies (like 2 containers) - first one with pillar and stone - both are on the same sorting layer (default) with the same sorting order (0), so stone is rendered over pillar. Second one is pumpkins with default sorting layer, but parent pumpkin has order in layer -5 and child has order in layer 5. If I move pumpkins over first group I get this:

Parent pumpkin is rendered below pillar and pumpkin child is rendered over pillar - single flat display list would handle this. Of course setting depth as combination of Sorting Layer and Order in Layer is very convenient - you can have for example UI layer and you always know its depth is over for example GameBoard layer.
Here is how changing alpha on pillar does not affect child stone:

There are no issues with different blend mode...
So, hierarchy changes in position/rotation/scale are separated from rendering, for which single flat list can be maintained.
What if Phaser adopted similar approach?:

single list for rendering,
some convenient way how to manage depth (like Sorting layer +  Order in Layer),
every gameobject could have zero or many child gameobjects,
before rendering, those gameobject with children would recalculate their world positions (it is up to game programmer, how complex hierarchy he uses - as well it is his responsibility for performance)
input then could go through single flat list and use world coordinates,
sacriface features like non-exlusive containers

Containers will remain, it's the ability to nest them that I'm going to remove.
The problem with the 'calculate world positions before rendering' approach is that it's too late by that point. There are lots of reasons you need the world positions to be perfectly accurate all the time. Input checks, bounds checks, intersection checks, camera culling, etc. They all need perfectly accurate transforms at every stage, not just before rendering, and what's more - they need to be perfect for every single camera in every Scene, as each one potentially needs different results :(
So the moment any transform aspect changes, in any child, or any of its parents, every single part of that ancestry tree needs recalculating, and it needs to happen every time, not just once, which means it's entirely possible to need many tree updates in just a single frame. This was the same issue that plagued v2 to be honest, except there were no multiple cameras or states so it wasn't as bad.
There were so many v2 issues over the years related to incorrect body positions and the like. Part of that problem is that Arcade Physics uses the Sprites position and scale for its body. Scale the sprite and the body scales with it. A real physics system would never do this. The body would be entirely independent and it would be up to you to reflect any changes made to the sprite into it. p2, for example, doesn't even let you scale bodies (and for good reason, scale doesn't really exist in physics simulations in the way we visually think of it) And don't get me started on the issues with containers and tilemaps :)
I actually think the early versions of Lazer had the best transform approach in it. I spent a long time working on it, ensuring values were properly cached up and down the tree, removing un-needed calculations where possible. It never made it into v3 and the Container system in there currently isn't ideal. In time I think I'd much rather revert back to the transform system I originally built. Yet it still requires constant iteration to work.
But at the same time, I find it, and the approach v2 had, is actually very limiting. Having the alpha or blend modes impact the whole tree is as equally useful as it is annoying. What if you don't want to alpha out every child? What is just part of the container should have a blend mode set, not all the children? What if you want to scale a containers background but not have the children scale at all? None of these things are possible and it just feels wrong.
In the meantime though, removing nested Containers will fix a number of issues and simplify the internals a lot, which will make the transition to something better a lot easier in the future.

Also forgot to add, it's not up to the developer how complex the hierarchy gets. The very fact the API supports it means all the iteration checks have to be run anyway, even if you never use it. The very existence of the feature negatively impacts all games, even those that never use a single Container. This is the biggest issue I have with them I think.

Lack of time is a good reason. No person who can be responsible for support of nested containers => get rid of them.

If nested containers are removed, how we can do "bones" like animations? Something like this?

Skeletal animations will use their own animation format / handler, they won't be containers.

Whoever will make good enough custom plugin for nested tree that doesnt change phaser internals much, will be a hero. That way it wont be "removed", just out-sourced to third-party contributor.

I'll gladly put some funds towards a solid implementation, but it would need to be discussed in depth with me beforehand, because it would literally touch every single system in the API.

@photonstorm Rich, thanks for detailed explanation above. You wrote: "The problem with the 'calculate world positions before rendering' approach is that it's too late by that point. There are lots of reasons you need the world positions to be perfectly accurate all the time. Input checks, bounds checks, intersection checks, camera culling, etc."
Is it because input can come in the middle of update? Any chance, that caching input during frame and then processing it all at once after (or before - next frame) gameobjects changes would help? I had something similar in my very old and crappy framework for Android/iOS/bada. I was not processing input immediatelly, but just recorded it and than processed it before scene update in next frame. Of course, there was up to 1 frame delay, but it was so negligible, that I did not even feel any delay as user.
Similar for camera culling. I always thought, that culling is applied after objects are transformed into world and during culling you are deciding, whether object is visible for that camera or not. Does it mean, that culling in Phaser 3 is somehow "distributed" during scene update?

Nested containers seems an important issue as a way of grouping some GameObject instances and having ability to control this group the same way.
It's seems very hard to implement some kind of situations, for example tables. With a help of containers I can have each row as a positioned vertically container and all its children as a game objects (any kind of, not only sprites as it possible for Groups) horizontally having vertical position of a row as a reference. And this group of containers may be included into another container which may be positioned at correct place with one command.
And this is only one example becoming completely horrible in terms of additional calculations without containers. So, disabling nested containers is not seems very good for implementing complex objects.
May be there is another solution supported to reach the desired behavior but I could not find it? But for now in terms of creation of complex objects containers seems like the best solution to use ¯\_(ツ)_/¯

@aahz
I had made a simple container plugin which could control the position and angle of children game objects. And it supports nested container.

@rexrainbow
Sounds great, will test it soon, I suppose, thanks!)

it sounds that Richard simply could not cope with elementary math.
I can not imagine how you can work without containers, when you do something more than tetris.

it sounds that Richard simply could not cope with elementary math.

Its not a math problem, its invalidation problem.

I can not imagine how you can work without nested containers, when you do something more than tetris.

Meet pure ECS fans, ask them about nesting entities.

This is about getting the topology and topography correct. As it stands now, it's too tied into the rendering. It should be fully abstracted from that.
Having said that, if the only issue is a bit of elementary math, you have absolutely no reason not to implement it yourself, right?

for now I use container to implement the Phaser version of DragonBones, I'm curiose what will be the replacement of the container for it.

Is it possible to leave nestable Containers in the package as optional (maybe under a different name)? So if someone wanted to use them, they would compile their own Phaser package and those who don't need them would use the new implementation.
I currently have some nested containers and I can't imagine writing all the coordinate/scaling transform code for every nested container I would want to remove. Any advice how to proceed with that?

Deal-breaker for me coming from Unity and using a hierarchy of transforms to maintain a fluid user-interface.

Yes, coming from flash, it is very hard not to think in terms of nested children. I just started a virtual world in Phaser 3 that relies on nested containers. I knew I had to be careful with them, but they are so useful.  This is going to set things back a bit.

Ouch. Just looking over my code this is going to set back 2 ebooks and an online course :( Is there anything else I should work around?

After a restless night of coding in my sleep, it is not as bad as I thought. I only need a few functions like setting child positions and visibility. I've been able to write a class that extends group to take care of that. I can live without nested containers, especially if it improves performance.

Containers will be removed and fully recoded in 3.14. I'm fed up with their limitations and the issues the current implementation has. They will remain untouched (and un bug-fixed) until then.

Oh god... nested containers were so nice for complex developments... Same as William, I got used from Flash / AS3, with their nice nested movieclips, and all complex collision system, and... i admit right now, it seems like I'm back to the 2000's ....

Sometimes, I wonder... are things really get better with new 'technologies' ? Maybe Flash is old, maybe it has its problems, but still... it is years ahead of ES6/HTML5 in term of pure development..

@ElMacBgl  http://pixijs.io/pixi-swf/demos/ninja-cat.html http://pixijs.io/pixi-swf/demos/ninja-cat.js I'm making new renderer that has all flash capabilities. @photonstorm knows about it, everything will be all right ;)

@ivanpopelyshev Just went to your demo: it's quite impressive actually, and if it uses quite same dev logic than what was available on AS3, it can be great. Question remains to me: how can we mix phaser and pixiJS ? Or maybe we'll have to manage that as 2 different development tools, being 99.99% compatible ?
I guess this will be the subject of another topic (don't want to pollute that one)

This issue has been mentioned on Phaser. There might be relevant details there:
https://phaser.discourse.group/t/nested-containers-moving-and-rotating-sprites/5599/3


Clarify purpose in comments, fix removal of 'UpdateFolderPermissions' default action

Comment in line 1 is true but misleading:
#This script will enable non-owner mailbox access auditing on every mailbox in your tenancy
It does, in fact, enable auditing of some (but not all) non-owner (i.e., administrator or delegate) mailbox actions, but it also enables auditing for some (but not all) owner actions as well.
So if the purpose is to only enable non-owner mailbox auditing (and its associated default logging actions), then this snippet should be removed:
-AuditOwner Create,HardDelete,MailboxLogin,MoveToDeletedItems,SoftDelete,Update
But if the purpose is to enable both non-owner and owner mailbox auditing, the description of the script should be adjusted to clarify its purpose and the code should be revised so that it doesn't overwrite/remove a default logging action ('UpdateFolderPermissions') that is otherwise turned on for mailbox owners when mailbox auditing is enabled.
This article has a handy table showing available mailbox auditing options for the three user logon types:
https://support.office.com/en-us/article/Enable-mailbox-auditing-in-Office-365-aaca8987-5b62-458b-9882-c28476a66918#ID0EABAAA=Mailbox_auditing_actions
To keep the default logging action ('UpdateFolderPermissions') and add the other actions contemplated by the existing script, replace the snippet above with:
-AuditOwner @{Add="Create","HardDelete","MailboxLogin","MoveToDeletedItems","SoftDelete","Update"}
But perhaps a more comprehensive approach is desirable to enable logging of every auditable action across all user logon types (as listed in the MS Support article)?  (I also noticed that the existing code inexplicably leaves out the 'Move' action for owner auditing.)  So maybe something like:
-AuditOwner @{Add="Create","HardDelete","MailboxLogin","Move","MoveToDeletedItems","SoftDelete","Update"} -AuditAdmin @{Add="Copy","MessageBind"} -AuditDelegate @{Add="Move","MoveToDeletedItems","SendOnBehalf"}
In any case, the comment should clarify that this script is only enabling logging for certain actions and is not comprehensively doing so for all auditable mailbox actions across all user login types.  Users should be cautioned that they may need to add or remove options to fit their auditing objectives.
(Thanks for all the effort thus far!  I stumbled across this script from the Secure Score dashboard in O365 which was a pleasant surprise but also somewhat concerning as being officially-sanctioned guidance...)

+1 above.
I'm assuming this is meant as a baseline auditing rule set. It'd be much clearer if you used splatting to define the options you are setting:
   $mbxauditpolicies = @{         'AuditEnabled' = $true;         'AuditLogAgeLimit' = 180;         'AuditAdmin'    =  @('Update', 'MoveToDeletedItems', 'SoftDelete', 'HardDelete', 'SendAs', 'SendOnBehalf', 'Create', 'UpdateFolderPermissions');         'AuditDelegate' =  @('Update', 'MoveToDeletedItems', 'SoftDelete', 'HardDelete', 'SendAs', 'SendOnBehalf', 'Create', 'UpdateFolderPermissions');         'AuditOwner'    =  @('MailboxLogin', 'MoveToDeletedItems', 'HardDelete','SoftDelete', 'Create', 'Update', 'UpdateFolderPermissions');     } Set-Mailbox -identity <> @mbxauditpolicies;


fix syntax issue

fixes warning with syntax in jruby-9.1.* #19
The warning was
`-' after local variable or literal is interpreted as binary operator

For reference:
Related error
https://github.com/colbygk/log4r/issues/52

@stevehodgkiss any update on this?


use alternate build of Alpine JS that doesn't violate "unsafe-eval"

Hi there,
I noticed that the current version of Alpine.js bundled in the source code does not comply with CSP principles. However, this page suggests an alternative version of Alpine.js that adheres to CSP rules.

Interesting, thanks for raising this.
Don't see a reason to not use the CSP build, but hard to say how much work is required without digging further. This will probably be a good one to do alongside an Alpine upgrade at some point - I'll raise an issue for that.


Pilot fails immediately when waiting for itunes to process the build and an error occurs

New Issue Checklist

[X] Updated fastlane to the latest version
[X] I have read the Contribution Guidelines

Issue Description
Pilot immediately gives up when waiting for itunes connect to process the build encountering an error (e.g. 404 response from itunes connect; happens a lot).
Combined with a CI system that retries failed builds automatically this leads to the same build uploaded multiple times.
My proposal is that pilot retries failed requests after uploading the build.
Complete output when running fastlane, including the stack trace and command used
relevant log output:
18:52:19 INFO [2016-05-30 18:52:19.79]: iTunes Transporter successfully finished its job
18:52:19 DEBUG [2016-05-30 18:52:19.79]: [Transporter]: DBG-X: Returning 0
18:52:20 INFO [2016-05-30 18:52:20.00]: ------------------------------------------------------------------------------------------------------
18:52:20 INFO [2016-05-30 18:52:20.00]: Successfully uploaded package to iTunes Connect. It might take a few minutes until it's visible online.
18:52:20 INFO [2016-05-30 18:52:20.00]: ------------------------------------------------------------------------------------------------------
18:52:20 INFO [2016-05-30 18:52:20.00]: Successfully uploaded the new binary to iTunes Connect
18:52:20 INFO [2016-05-30 18:52:20.00]: If you want to skip waiting for the processing to be finished, use the `skip_waiting_for_build_processing` option
18:52:20 INFO [2016-05-30 18:52:20.00]: Waiting for iTunes Connect to process the new build
18:52:56 INFO [2016-05-30 18:52:56.51]: Waiting for iTunes Connect to finish processing the new build (1.0 - 4098)
18:53:29 INFO [2016-05-30 18:53:29.91]: Waiting for iTunes Connect to finish processing the new build (1.0 - 4098)
18:54:02 INFO [2016-05-30 18:54:02.88]: Waiting for iTunes Connect to finish processing the new build (1.0 - 4098)
18:54:36 INFO [2016-05-30 18:54:36.36]: Waiting for iTunes Connect to finish processing the new build (1.0 - 4098)
18:55:09 INFO [2016-05-30 18:55:09.53]: Waiting for iTunes Connect to finish processing the new build (1.0 - 4098)
18:55:42 INFO [2016-05-30 18:55:42.71]: Waiting for iTunes Connect to finish processing the new build (1.0 - 4098)
18:56:15 INFO [2016-05-30 18:56:15.89]: Waiting for iTunes Connect to finish processing the new build (1.0 - 4098)
18:56:49 INFO [2016-05-30 18:56:49.07]: Waiting for iTunes Connect to finish processing the new build (1.0 - 4098)
18:57:22 INFO [2016-05-30 18:57:22.25]: Waiting for iTunes Connect to finish processing the new build (1.0 - 4098)
18:57:56 INFO [2016-05-30 18:57:56.51]: Waiting for iTunes Connect to finish processing the new build (1.0 - 4098)
18:58:29 INFO [2016-05-30 18:58:29.78]: Waiting for iTunes Connect to finish processing the new build (1.0 - 4098)
18:59:03 INFO [2016-05-30 18:59:03.47]: Waiting for iTunes Connect to finish processing the new build (1.0 - 4098)
18:59:36 INFO [2016-05-30 18:59:36.50]: Waiting for iTunes Connect to finish processing the new build (1.0 - 4098)
19:00:09 INFO [2016-05-30 19:00:09.94]: Waiting for iTunes Connect to finish processing the new build (1.0 - 4098)
19:00:43 INFO [2016-05-30 19:00:43.77]: Waiting for iTunes Connect to finish processing the new build (1.0 - 4098)
19:01:17 INFO [2016-05-30 19:01:17.57]: Waiting for iTunes Connect to finish processing the new build (1.0 - 4098)
19:01:50 INFO [2016-05-30 19:01:50.97]: Waiting for iTunes Connect to finish processing the new build (1.0 - 4098)
19:02:24 INFO [2016-05-30 19:02:24.54]: Waiting for iTunes Connect to finish processing the new build (1.0 - 4098)
19:02:58 INFO [2016-05-30 19:02:58.35]: Waiting for iTunes Connect to finish processing the new build (1.0 - 4098)
19:03:32 INFO [2016-05-30 19:03:32.18]: Waiting for iTunes Connect to finish processing the new build (1.0 - 4098)
19:04:05 INFO [2016-05-30 19:04:05.91]: Waiting for iTunes Connect to finish processing the new build (1.0 - 4098)
19:04:39 INFO [2016-05-30 19:04:39.71]: Waiting for iTunes Connect to finish processing the new build (1.0 - 4098)
19:05:13 INFO [2016-05-30 19:05:13.27]: Waiting for iTunes Connect to finish processing the new build (1.0 - 4098)
19:05:46 INFO [2016-05-30 19:05:46.68]: Waiting for iTunes Connect to finish processing the new build (1.0 - 4098)
19:06:20 INFO [2016-05-30 19:06:20.47]: Waiting for iTunes Connect to finish processing the new build (1.0 - 4098)
19:06:54 INFO [2016-05-30 19:06:54.26]: Waiting for iTunes Connect to finish processing the new build (1.0 - 4098)
19:07:27 INFO [2016-05-30 19:07:27.66]: Waiting for iTunes Connect to finish processing the new build (1.0 - 4098)
19:08:00 INFO [2016-05-30 19:08:00.93]: Waiting for iTunes Connect to finish processing the new build (1.0 - 4098)
19:08:34 INFO [2016-05-30 19:08:34.87]: Waiting for iTunes Connect to finish processing the new build (1.0 - 4098)
19:09:08 INFO [2016-05-30 19:09:08.51]: Waiting for iTunes Connect to finish processing the new build (1.0 - 4098)
19:09:41 INFO [2016-05-30 19:09:41.69]: Waiting for iTunes Connect to finish processing the new build (1.0 - 4098)
19:10:12 WARN [2016-05-30 19:10:12.49]: Variable Dump:
19:10:12 INFO [2016-05-30 19:10:12.49]: {:DEFAULT_PLATFORM=>:ios, :PLATFORM_NAME=>:ios, :LANE_NAME=>"ios appstore", :ORIGINAL_DEFAULT_KEYCHAIN=>"\"/Users/jenkins/Library/Keychains/fastlane.keychain\"", :LATEST_TESTFLIGHT_BUILD_NUMBER=>4097, :BUILD_NUMBER=>"There does not seem to be a CURRENT_PROJECT_VERSION key set for this project.  Add this key to your target's expert build settings.", :SIGH_PROFILE_TYPE=>"app-store", :IPA_OUTPUT_PATH=>"/Users/jenkins/.jenkins/jobs/iOS Appstore/workspace/output/xxxxxxxx.ipa", :DSYM_OUTPUT_PATH=>"/Users/jenkins/.jenkins/jobs/iOS Appstore/workspace/output/xxxxxxxx.app.dSYM.zip", :XCODEBUILD_ARCHIVE=>"/Users/jenkins/.jenkins/jobs/iOS Appstore/workspace/output/xxxxxxxx 2016-05-30 18.21.35.xcarchive"}
19:10:12 ERROR [2016-05-30 19:10:12.49]: <!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN">
19:10:12
19:10:12 <title>404 Not Found</title>
19:10:12
19:10:12
Not Found

19:10:12
The requested URL /WebObjects/iTunesConnect.woa/ra/apps/0000000000/trains/ was not found on this server.

19:10:12

Configuration Files
Please copy the complete content of your Fastfile and any other configuration files you use below:
Fastfile:
def info_plist_to_hash(path)
  require 'json'
  JSON.parse! %x[plutil -convert json -o - "#{path}"]
end

# Hack to read app version from Info.plist
def get_version_short_string(path)
  plist_hash = info_plist_to_hash path
  plist_hash['CFBundleShortVersionString']
end

def get_contents_of_file(path)
  file = File.open(path, "r")
  file.read
end

def get_current_version(scheme)
  plist_file = File.expand_path(File.join(ENV['PWD'], 'xxxxxxxx-iOS/' + scheme + '-Info.plist'))
  get_version_short_string(plist_file)
end

def get_changelog_for_pilot()
  release_notes_file = File.expand_path(File.join(ENV['PWD'], "fastlane/metadata/en-US/release_notes.txt"))
  print release_notes_file
  ENV['PILOT_CHANGELOG'] or get_contents_of_file(release_notes_file) or "Bug fixes and performance improvements."
end

update_fastlane

fastlane_version "1.87.0"

platform :ios do
  before_all do
    clean_build_artifacts
    setup_jenkins
  end

  desc "Deploy a new version to the App Store"
  lane :appstore do
    scheme = "xxxxxxxx"

    increment_build_number({
      build_number: latest_testflight_build_number(version: get_current_version(scheme)) + 1
    })

    match(type: "appstore", force: true)
    gym(scheme: scheme) # Build your app - more options available
    pilot(changelog: get_changelog_for_pilot())
    deliver(force: true, skip_binary_upload: true, app_icon: "fastlane/metadata/iTunesArtwork.png") # pilot did already upload our binary
  end
  after_all do |lane|
  end

  error do |lane, exception|
  end
end

Environment
fastlane version (run fastlane -v): fastlane 1.91.0
Do you use bundler to execute fastlane (i.e. bundle exec fastlane)? NO
Do you use a Ruby environment manager (e.g. chruby, rbenv, rvm)? YES

Thanks the report, keeping this open for upvotes and comments.

Does the URL really contain<PHONE_NUMBER>, or did you remove your number?

@KrauseFx I have removed the number / anonymized the logs. sorry I didn't mention that.

@stefreak I've marked this as help wanted in case anyone from the community wants to make a PR. Thanks!

Seeing the same (or very similar) problem. It did upload correctly and ended up being processed OK.
/Library/Ruby/Gems/2.0.0/gems/spaceship-0.32.1/lib/spaceship/client.rb:446:in `parse_response': [!]  (Spaceship::Client::UnexpectedResponse)

404 Not Found

Not Found
The requested URL /WebObjects/iTunesConnect.woa/ra/apps/<<>>/trains/ was not found on this server.

This seems like something we could handle by auto retrying on 404 Not Found


Auth doesn't work

I've added BASIC_AUTH_USER and BASIC_AUTH_PASS but when I go to http://localhost:8000 it doesn't ask for credentials - just show the directory listing.
My docker-compose
proxy:
  image: pottava/s3-proxy
  restart: always
  ports:
    - 8000:80
  environment:
    - AWS_REGION=us-east-1
    - AWS_ACCESS_KEY_ID=
    - AWS_SECRET_ACCESS_KEY=
    - AWS_S3_BUCKET=
    - ACCESS_LOG=true
    - DIRECTORY_LISTINGS=true
    - DIRECTORY_LISTINGS_FORMAT=html
    - BASIC_AUTH_USER=admin
    - BASIC_AUTH_PASS=pass
  container_name: proxy
``

Yup, same here, doesn't ask for credentials when providing BASIC_AUTH_USER and BASIC_AUTH_PASSWORD
Here are my logs-

Issue seems to be fixed in version 1, but broken in version 2.0.0 and 2.0.1

Do you want to try my fork? I tried to find why it wasn't working, but for me it works. Not sure what change I did that might have fixed it.


TypeError undefined is not an object (evaluating 't.targetTouches[0].pageX')

Seems to be specific to iOS > v13

fixed in 2.0.9 thank you for reporting it


Fix fragment encoding

In the OAuth spec (https://tools.ietf.org/html/rfc6749#section-4.2.2), the fragment component
of the redirection URI is supposed to be constructed using the application/x-www-form-urlencoded
format.
The golang stdlib does not make it easy to include values encoded that way in a URL fragment (it
messes with some %-escaped values), and the way osin was trying to work around that (encode
query params, then unescape, then assign to the url fragment, then let the url stringify the fragment)
led to some special characters in the state param not getting escaped correctly.
This PR simplifies the fragment-building to construct the URI with the encoded params directly, and
adds test cases for both the query and fragment cases.
Additionally, any pre-existing query parameters on the redirect_uri are supposed to be preserved in the redirect. They were being moved to the fragment in a redirect case, instead of remaining in the query string.

The query test case passes against master, running the fragment test case against master fails with this, which clearly is not escaping the special characters in the state param correctly:
--- FAIL: TestGetRedirectUrl (0.00s)
	response_test.go:49: fragment: expected
			https://foo.com/path#access_token=12345&state=%7B%22then%22%3A+%22%2Findex.html%3Fa%3D1%26b%3D%252B%23fragment%22%2C+%22nonce%22%3A+%22014f%3Abff9a07c%22%7D, got
			https://foo.com/path#access_token=12345&state=%7B%22then%22:%20%22/index.html?a=1&b=%252B%23fragment%22,%20%22nonce%22:%20%22014f:bff9a07c%22%7D
FAIL
FAIL	github.com/RangelReale/osin	0.010s

actually, hold on this... testing a state param containing these chars in Firefox, a fragment encoded this way is not parsed correctly by the browser...

this is ready


Video playback speed hook.

Can we also hook video playbackrate to the step? When we add a video to THREEJS Scene the video loses frames while getting captured.

A repeat of issue #20


Addition of AngularJS Notes

Feature Request Title
Adding AngularJS notes to the collection.
Description
The AngularJS notes in the repository are currently not available. This issue aims to track the completion of notes for Angularjs.
Tagging Reviewers
Requesting review from maintainers who can provide guidance and/or permission: @allanoguis
If this issue seems valid, kindly assign me this under Hacktoberfest label. Thanks!

go ahead please. @anjali-vaish  follow the markdown format and the table of contents. or if you have a better way let i eill personally approve pr

On it!

dont forget to leave a star if you haven't yet. thanks!


How To Change Franka Limits?

Hello, I am aware of two separate safety controllers: 1) the polymetis one, 2) the underlying franka one
I am using the robot to open physical drawers and cabinets, and I keep getting a cartesian_reflex complaint from the underlying franka safety controller.
On their website, they say that if you are working with physical objects this is expected, and the safety value should be raised with some command (see Reflex Errors): https://frankaemika.github.io/docs/libfranka.html
How would I go about changing these values, since I assume all this stuff is wrapped up in polymetis?
Thank you as always!

Generally, I am running into torque issues when working with hinged objects. This happens even when moving the robot very slowly, but the movement of the robot arm isn’t perfect (Ie. It pushes against the door in a non-giving way). I was wondering you guys have advice for how to address this?

You can increase these tolerances by increasing the collision behavior values within the config file here. If you are installing through conda, you can override the values with launch_robot.py robot_client=franka_hardware robot_client.executable_cfg.collision_behavior=[......]
To give your robot more compliance, you can trying tuning down the Kq_default, Kqd_default, Kx_default, and Kxd_default values within RobotInterface, then re-launching start_cartesian_impedance. This will give your robot more compliance, but at the sacrifice of accuracy and will result in different dynamics.

When I change these values, I seem to get a tau_j_range_violation. When I print out the commanded toques, they don't actually have a magnitude greater than 6, so I'm not sure why it keeps freezing the robot due to range violates... Do you guys happen to have any ideas? I'm currently not able to reliably use the controller to interact with hinged objects


[NUI] samples - minor changes

depreceted functions changed to new ones,
new screenshots

NuiFlexLayout moved to a separate pr


fix(package.json): add files field to remove unnecessary files in published package

First of all, I really wanted to say thank you so so much for providing this cool package! 👍
I've been waiting too long for a package that can replace npx sort-package-json to be released.
This package completely eliminated my annoyance with running npx sort-package-json for every package in my monorepo:suspensive/react. Thank you thank you so much!
but I found some unnecessary files. so I make this Pull Request.
Remove unncessary files in published package
You can see below link to check unnecessary files in published packlint.
https://www.npmjs.com/package/packlint?activeTab=explore
and installed package

Package.json's files field will remove them. check it please

Actually, I was planning to rewrite this library. Here is a proposal. Any feedbacks will be wellcomed!


updates required for TensorFlow 0.12.1

Hi, interesting examples and presentation.
I would like to give a try.
So I have just clone the git in my Ubuntu 16.04 and installed the most recent version of TensorFlow with pip.
But I get the following error:
root@ubumate:/opt/tensorflow/TensorFlow-Tutorials-for-Time-Series# python3 lstm-for-epf.py  WARNING:tensorflow:From lstm-for-epf.py:34 in <module>.: calling BaseEstimator.evaluate (from tensorflow.contrib.learn.python.learn.estimators.estimator) with batch_size is deprecated and will be removed after 2016-12-01. Instructions for updating: Estimator is decoupled from Scikit Learn interface by moving into separate class SKCompat. Arguments x, y and batch_size are only available in the SKCompat class, Estimator will only accept input_fn. Example conversion:   est = Estimator(...) -> est = SKCompat(Estimator(...))
Do you have an idea how I should change the following line:
regressor = learn.TensorFlowEstimator(model_fn=lstm_model(TIMESTEPS, RNN_LAYERS, DENSE_LAYERS),                                        n_classes=0,                                       verbose=1,                                         steps=TRAINING_STEPS,                                        optimizer='Adagrad',                                       learning_rate=0.03,                                        batch_size=BATCH_SIZE))
in order to make it working?
Thanks.
Regards.

I met the same problem. TensorFlowEstimator is instead by Estimator or BaseEstimator in the newest tensorflow version. I also hope for the resolution. Thanks.

Thanks for author's work. But these examples confused me for a long time. To be honest, they make no sense when I work with TensorFlow 0.12.1. Maybe I should read the guide of https://www.tensorflow.org/api_docs/python/contrib.learn/estimators and search a new solution.....


Implement saved pin feature

Currently after adding marker to map, clicking save button generates an alert notifying user of the marker location.
Code snippet from LeafletOsmMap component:
    L.DomEvent.on(saveBtn, 'click', function() {
      // TODO - save marker location to db if possible or queue to
      // save when backend server is available
      alert(`Save marker at: ${event.latlng}!`);
    });

Refactor code so that it actually saves the given marker to the backend database. Note - accessing saved pins db requires user authentication; if needed feel free to relax that requirement for now. You can do so by commenting out
router.post('/savedpins', verifyToken, savedPinsController.postSavedPins);
with note needs to be added back for user authentication and adding a similar code snippet without the 'verifyToken' part.

completed in #185

Hey @jkwening I'm working on #183 (loading saved pins) and I need to be able to save pins to really test the code.  I'll use generated pins until then, but just wanted to know if there was an ETA on this task?
Not sure how far along you are but maybe this snippet will help you:
import { makeRequest } from "../../js/server-requests-utils";

      let place_id = 'THIS PLACE LABEL';

      makeRequest('GET','user')
      .then(res => {
          //user signed in, generate pin data
          let pinData = {
            lat: event.latlng.lat,
            lng: e.latlng.lng,
            place_id: '',
            user: res.data._id
            };

          return pinData;

        }
      )
      .then(pinData =>{

        //post saved pin
        makeRequest('POST','savedPin',pinData)
        .then(res=>{
          //pin saved
        })
        .catch(err=>{
          //pin not saved
        });

      })
      .catch(err=>{
        //USER NOT SIGNED IN...

        //redirect to sign in page? or overlay signin?

      });

@shiolovesgod the save pin feature was merged into development last night (PR #203). If you pull down from upstream development branch into your local development branch and then merge into the branch you're working in for this issue, you'll be all synced up. Thanks.

Great! Checked last night, should have checked again this morning. Thanks.


drive pull runs out of space

I ran drive init on an s3fs mounted directory, so it should have unlimited space, but when I do drive pull it fills up my local drive.
I'm guessing it is copying a file to the local drive first, is there a way to make it use a different directory so it doesn't fill up the local one?
Cool project though!

Actually I can't reproduce this problem.  Maybe I was running two versions of drive pull at the same time...


Make use of subvolumeinfo's state field

cephfs: make use of subvolumeInfo.state to determine quota
https://github.com/ceph/go-ceph/pull/455/ added state field
to subvolume info struct which helps to identify the snapshot
retention state in the caller.
This PR also address few typos in cephfs driver code
Signed-off-by: Humble Chirammal<EMAIL_ADDRESS>

/retest ci/centos/mini-e2e/k8s-1.20

/retest ci/centos/mini-e2e/k8s-1.20

#2362
Aug 17 17:02:49.309: INFO: attach command running after restart, runningAttachCmd: rbd-nbd --id cephcsi-rbd-node -m rook-ceph-mon-a.rook-ceph.svc.cluster.local:6789 --keyfile=/tmp/csi/keys/keyfile-157305445 attach replicapool/csi-vol-78054408-ff74-11eb-b3db-9651800b2411 --device /dev/nbd0 --try-netlink --reattach-timeout=300

Aug 17 17:02:49.314: INFO: ExecWithOptions {Command:[/bin/sh -c echo 'Hello World' > /var/lib/www/html/test] Namespace:rbd-694 PodName:csi-rbd-demo-pod ContainerName:web-server Stdin:<nil> CaptureStdout:true CaptureStderr:true PreserveWhitespace:true Quiet:false}
Aug 17 17:02:49.314: INFO: >>> kubeConfig: /root/.kube/config
Aug 17 17:02:51.532: INFO: stdErr occurred: /bin/sh: 1: cannot create /var/lib/www/html/test: Read-only file system

Aug 17 17:02:51.532: FAIL: failed to write IO, err: command terminated with exit code 2, stdErr: /bin/sh: 1: cannot create /var/lib/www/html/test: Read-only file system

[AfterEach] RBD


Fix the navlink issue

Fixes #1742
Describe the changes you have made in this PR -
Bug
The navigation button of the current page in the navigation bar is not disabled.
view get reloaded on clicking the button leading to the same view again.
Changes:
To disable the link, check the request.path if it is equal to the href of the link, then update the href='#'.
example  :
<a class="nav-link navbar-item navbar-text <%= request.path == '/teachers' ? 'active' : '' %>" href="<%= request.path == '/teachers' ? '#' : '/teachers' %>">Teachers
Screenshots of the changes (If any) -
https://user-images.githubusercontent.com/76155456/142721923-108c83bb-26bb-416f-aa19-48c25377d040.mp4
Please provide me with appropriate feedback/review so that I can continue working on this.

Hey @gr455 ,
Please review this PR.

Closing as linked issue is closed


crypto/tls: advertise full SHA suite in SignatureHashAlgorithm

A simple Go client connecting to a server via TLS1.2 advertises supported algorithms as the equivalent of openssl s_client -sigalgs RSA+SHA256:ECDSA+SHA256:RSA+SHA1:ECDSA+SHA1 -tls1_2, while it should be capable of more.  An excerpt of the ClientHello sent from the client is below:

The server (a web load balancing appliance), which has an RSA+SHA256 certificate and a bundled RSA+SHA384 intermediary perhaps reasonably responds with an alert(40) (handshake_failure), whilst internally logging "[h]andshake failure selecting certificate for foo.example.com: Certificate chain uses algorithms not supported by client".  On the face of what's presented by the client, this is true.
I believe this is the same issue previously reported by Michael Daffin on the golang-nuts mailing list.  In that case, connecting to the specified server using a simulated string of
# "OpenSSL 1.0.2 22 Jan 2015" for `-sigalgs` support
$ openssl s_client \
    -sigalgs RSA+SHA384:RSA+SHA256 \
    -cipher AES256-SHA \
    -tls1_2 \
    -servername foo.example.com \
    -connect foo.example.com:443 -showcerts

yields success.
I believe the GoLang TLS library should advertise the full SHA suite it supports in the SignatureHashAlgorithm.

Please take a look at https://github.com/golang/go/blob/master/CONTRIBUTING.md.

What version of Go are you using (go version)?
What operating system and processor architecture are you using?

Seems like this issue is similar to #8190.

go version go1.4 darwin/amd64

on OS X 10.9.5.  That issue points to a fix, however you can check the source to see that it didn't make it into go1.4.1.

I think the reason sha512/384 arr not advised is that they are rarely used,
so crypto/TLS chooses not to import the sha512 package.
However, it makes sense that if the program does import crypto/sha512,
crypto/tls should detect that and advise those hash algorithms.

crypto/tls may not import crypto/sha512, but crypto/x509 does, with the intent of supporting intermediate certificates such as this.  Since the support is there to read verify these certs, the support should be there to advertise the capability to in TLS1.2.


[Feature Request] Choice of one of two ingredients

It would be nice to have the ability to select one of two crafting items, for example: we have a sword craft, and the players have, say, steel, iron, and bronze ingots, the sword made from them should be the same, and you need the player to be able to choose, what material of these three will he make the sword.
Maybe it will be useful only for me, because I have a group of engineers who constantly make something from iron, steel, or armored alloys, often it does not matter what they make, say, nuts and bolts, and create three times as many recipes for me it would be inconvenient.
Another option is priority for use with AnyOf maybe :)

Not quite sure what it is you want exactly.
If you want to create a sword from one of three items steel item and bronze and you do not want to create three diffrent recipes as all create the same sword. Then you could go for anyOfs, the player can drag and drop the ingredient they want on the recipe before they craft to choose which ingredient they want.
anyOf
not supported are ingredients with anyOf as result you can however drop a rollTable in the results.
but when i look at your title this should be working with anyOf.
Just update to the latest version 2.3.4 i had some issues with anyOf latly.


Supports specifying multiple package products

Adds support for specifying multiple products for when adding a package dependency to a target.
With this change dependencies that were previously written as
dependencies:
- package: FooFeature
  product: FooDomain
- package: FooFeature
  product: FooUI

can now be written as
dependencies:
- package: FooFeature
  products:
  - FooDomain
  - FooUI

This makes it easier to add multiple products of a single package.

👍
Please add some test case under Fixtures, like: https://github.com/yonaskolb/XcodeGen/blob/master/Tests/Fixtures/SPM/project.yml

Sure! I'v added that in https://github.com/yonaskolb/XcodeGen/pull/1395/commits/be92f16155eed8dbe4a6e1f68f1fe847be131852.

Looks good! Thanks @simonbs!


mobile: Rename addLogger to setLogger for Android

This is similar to https://github.com/envoyproxy/envoy/pull/33576, but for the Android API.
Risk Level: low
Testing: unit tests
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: mobile

/assign @abeyad


chore(paeckchen): switch to cz-customizable to improve 'git cz' messages

Coverage remained the same at 100.0% when pulling f3c3e2df87af8edca08bed7bf5c1971fba332640 on cz-customizable into 2af41cb5c6d9eabe171b76b957ec283bed92d9f7 on master.


Fresh install issues

Hello, I have a fresh install of CentOS, I have followed all the install instructions in the readme, and the recommendations from issue #5  for good measure. But I've run into two issues.
First a mismatch version between front end and simulator
after installing the front end using pip, pip install -e ./RedDrum-Frontend  I go to install the simulator, using pip install -e ./RedDrum-Simulator
But get the following version error:
Could not find a version that satisfies the requirement RedDrum-Frontend==0.9.5 (from RedDrum-Simulator==0.9.5) (from versions: ) No matching distribution found for RedDrum-Frontend==0.9.5 (from RedDrum-Simulator==0.9.5)
Assuming backwards compatibly, I opted modify setup.py and update the requirement to version 2.0, which then allowed the pip install to work as expected.
Second an AttributeError
Once everything was said and done, and I tried to run  ./runSimulator BaseServer1 only to eventually be greeted by the following error:
 File "/home/jeffdev/RD/RedDrum-Simulator/reddrum_simulator/simulatorLoadResources.py", line 42, in loadStaticResourceDatabases     if self.rdr.root.managers.managersDbDiscovered is False: AttributeError: 'RfServiceRoot' object has no attribute 'managers'
I'm lead to believe I've followed all the steps (at least mostly) correct, could anyone shed some light on what might be wrong?

It seems like My assumption was wrong, and version 2.0 of the front-end is NOT compatible with 0.9.5 simulator. This is mentioned in the frontend readme, but not in the simulator readme.

Sorry for the problem.
The "Simulator" Readme was not properly updated when the Frontend moved to v2.
The Simulator currently required Frontend v1.0.0.
The Frontend documentation is correct.
to install the v1.0.0 frontend run:
      git clone -b v1.0.0 --single-branch  https://github.com/RedDrum-Redfish-Project/RedDrum-Frontend  RedDrum-Frontend
      # this will get all of the code, data files, documentation, tools, and README.txts for version v1.0.0
     #  then  to install in "editible mode" where any changes you make to the Frontend Repo will show up in the site pkg
    pip install -e ./RedDrum-Frontend

I'll leave the issue open and have the Simulator doc fixed and re-tested.
thanks

I've got it working and I'm writing a patch for the docs, should it be pip3 not pip? the readme claims it works in python3, no mention of python2

everything is python3


ci: remove typescript from CodeQL config

Unnecessary, javascript also processes our TypeScript code. See slack convo and related app PR.
Sounds like we can leave the cron too, which could catch updates to dependencies that happen in between PRs.

Duplicates #579


[Nav menu] Update style and show profile info in the side panel menu and sign out

https://www.figma.com/file/r2uGtyOiWoDa29za7DNuUc/Ground-Acacia-UX?type=design&node-id=5234%3A20396&mode=design&t=awQtAX2VmKHcituF-1

@amegantz Is "Profile information" the correct header here?

I'd move the user's name to the header and get rid of the "Profile information" line entirely

Like this? I kept the name in the dialog because if a name is super long, it might not look as nice in the header area

Yes, exactly, though you do raise a good point about super-long names. We can truncate if needed. I think if this menu becomes more robust, we can revisit a header like "Profile details," but for now, it seems superfluous.
Also, "Sign out" should be two words if used as a verb, like in a CTA (I updated it in the Figma).

Duplicate of #2397


some question about the normalize operation

hello!    Congratulations on your work ！I noticed that in your white-box attack code, the combined image was normalized again, as follows：
normalized_images = normalize(combined_images).to(torch.float16)
Isn't this equivalent to normalizing the original image twice?
data_dict = item_process_func(question, target_words, image_file, tokenizer, data_args)
This code has already normalized the image once

Hello @yuese1234 , in our HADES white box images, we concatenate the black box images with the generated white box images. The item_process_func is used to process the black box images generated in the second stage, and normalized_images = normalize(combined_images).to(torch.float16) is used for normalizing the white box images. Therefore, the images will not be normalized twice.


Azure DevOps Wish List

We're using this epic to parent all of the issues we think we should do which are blocked on Azure DevOps features.

All associated issues are closed.  Closing epic.


pine: Use VDAF test driver from the prio crate

Based on #632 (merge that first).
Partially addresses #618.

Rebased.


Newly added connection doesn't get auto-populated in schema compare dialog

Steps to Reproduce:

Open schema compare dialog from within a server/server>database
Click ... to open schema compare dialog.
Add a new connection using + sign beside the server information.

Expected: New connection gets added to the server dropdown in schema compare dialog and auto populates as the Server information.
Actual: New connection auto populate as the Server information.

I see the source connection staying as the original connection and the target connection getting updated to the new connection:

It is working when the new connection is been added to the Target server, but not for Source server. I will investigate it further if this is really a code issue or some problem with my machine.

Here is a gif capturing the issue.

It only happens when Schema compare extension starts from within a database/server context. If no context is provided while starting SC, and new connections are added, they work as expected. In the attached gif, SC starts from server context, and when new connection is added at the source, the connection gets added to the drop down but doesn't get populated as the server info.


MoistAir function argument names changed in a non-backwards compatible way

Reported by otter on 12 May 2013 19:52 UTC
The following function input arguments of Modelica.Media.Air.MoistAir has been changed in a non-backwards compatible way:

saturationPressureLiquid_der: dTsat -> Tsat_der
sublimationPressureIce_der: dTsat -> Tsat_der

When these input arguments are accessed as named arguments (as usually performed, especially also in the examples of MSL), then the existing models will not work

Migrated-From: https://trac.modelica.org/Modelica/ticket/1093

Comment by otter on 12 May 2013 19:56 UTC
Fixed in 02826c50ba9d41562723d9607bd337af0f962ef2 by renaming to the function input argument names of MSL 3.2

Changelog modified by otter on 12 May 2013 19:56 UTC
Renamed function input arguments of two MoistAir functions to the names from MSL 3.2 for backwards compatibility

Modified by dietmarw on 12 May 2013 22:37 UTC

Modified by otter on 20 Dec 2016 15:10 UTC


Misc. adjustments

Hey @tombentley, this does some preparations for packaging this as a Maven plug-in later on:

Retrieving input files from dependency artifact rather than sub module
Making sure tests are run via Maven
Making sure generated sources end up under target/generated-test-sources rather than tmp dir

Since you're mentioning mvn ... I didn't mention it before, but I did wonder whether having a separate module for the maven tooling made sense. That would allow, for example, later addition of support for gradle or other toolchains, without things getting too messy. Wdyt?

For now I don't see (m)any other users than ourselves in kproxy, so let's cross that bridge when we get there?

Not for us, perhaps, but I think there could be value for non-Java Kafka client libs (e.g. Sarama) which currently have hand-coded serialization and deserialization code. For some people the more closely something is associated with Java (yuk!) and maven (Eugh!!) the more easy it is to discount it. Having a native quarkus tool which could be used e.g. from make would be nice. And I see there is a freemarker extension for quarkus. So while I accept it'll probably never happen, this was my line of thinking for why supporting more than maven would be a nice-to-have. But let's keep it simple for now as you say.


Add Faker::HalfLife

Faker::HalfLife.character

Returns a character from Half-Life 1 or 2 and expansions.

Faker::HalfLife.enemy

Returns an enemy from Half-Life 1 or 2 and expansions.

Faker::HalfLife.location

Returns a location from Half-Life 1 or 2 and expansions.

You also need to update the README.md and add the new module @jthomp

Added the namespace and updated the README :+1:


Parallel Processing in KernelExplainer

Hello slundberg!
I can see that KernelExplainer iterates over samples(given '# samples x # features')  to get shap_value.
I think it is possible to parallel this part for better computation. What do you think?

I use 18k features for NN, and it takes 3 min to run shap.KernelExplainer(...). So shap performance is still good but there is a room for improvement!

Hi miaekim,
just some intuitive thoughts on that. They might be wrong and biased, please let me know if you have any comments.
Each time when KernelExplaination.explain is called (e.g. here), there are around nsamples samples generated for each single instance (see from this line on). Therefore parallelizing the instances processing might barely improve the performance. A better way instead is, IMO, designing a more generalizable feature attribution function to map your 'real' features into a interpretable feature space. Which can modify the count of interpretable features (i.e. the M) to as low as you want it be.

@JoshuaGhost's suggestion is the best way to go about this. Since nsamples are passed to your evaluation function as a batch I think the best place to parallelize is inside the model evaluation function, not the KernelExplainer itself (and most NN packages already do that). That being said we are also working on NN specific approximation methods like DeepExplainer that can handle 18k inputs.

Thank you @JoshuaGhost and @slundberg !!

@slundberg
Do you have any update on the "NN specific approximation.." you mentioned in your reply above? Looking for a way to speed up shap computation for a shap.KernelExplainer(...) taking ages...


toJSON error on drag event

Providing this as the data emitted with the drag-[start|end] event causes an error...
https://github.com/NightCatSama/vue-slider-component/blob/master/src/vue2-slider.vue#L486

How do you call toJSON methods, the component itself is not the method.

I'm using Vue 2.3.4..I wonder if it's something to do with the Vue dev tools. I'll get back to you asap

Yeah, seems to be the dev tools...and there is an existing (closed) error..
https://github.com/vuejs/vue-devtools/issues/333

I have this issue too.
Same dependency with package-lock.json and same dev tools version
but only mac chrome display this error. windows chrome shows nothing


[BREAKING] Adds custom animation support as well as more button states

Sort of an RFC
This handles #5 as well as #4.
This is a breaking change and will require users to better manage states.
Instead of a simple isLoading boolean to check the state of the button, users will instead be provided a sealed union for the button state -- either idling, loading, erroring, or completing. The setter for isLoading will also be removed as it does not provide as much customizability asI would have liked

I might follow this other library's conventions and rename things successWidget, errorWidget, loadingWidget.
Ah! Just found this other package and it looks like I'll just copy their naming convention. Good amount of stars and we seem to be trying to solve the same problem

I might follow this other library's conventions and rename things successWidget, errorWidget, loadingWidget.
Ah! Just found this other package and it looks like I'll just copy their naming convention. Good amount of stars and we seem to be trying to solve the same problem

I feel like it's down to naming these:
idle
load
success
fail

OR
idling
loading
succeeding
failing

The second pair denote a continuous form of a verb which is more accurate but man does it not look right.

I feel like it's down to naming these:
idle
load
success
fail

OR
idling
loading
succeeding
failing

The second pair denote a continuous form of a verb which is more accurate but man does it not look right.


badmatch, {error,closed} when closing the connection with loop handler

After the loop has started, if connection gets closed (eg:close the browser while waiting for response) I get the following error report:
=ERROR REPORT==== 25-Mar-2015::11:26:18 ===
Error in process <0.167.0> with exit value: {{badmatch,{error,closed}},[{cowboy_req,response,6,[{file,"src/cowboy_req.erl"},{line,1049}]},{cowboy_req,reply_no_compress,8,[{file,"src/cowboy_req.erl"},{line,796}]},{cowboy_req,reply,4,[{file,"src/cowboy_req.erl"},{line,751}]},{cowboy_req...

=ERROR REPORT==== 25-Mar-2015::11:26:18 ===
Ranch listener my_http_listener had connection process started with cowboy_protocol:start_link/4 at <0.167.0> exit with reason: {{badmatch,{error,closed}},[{cowboy_req,response,6,[{file,"src/cowboy_req.erl"},{line,1049}]},{cowboy_req,reply_no_compress,8,[{file,"src/cowboy_req.erl"},{line,796}]},{cowboy_req,reply,4,[{file,"src/cowboy_req.erl"},{line,751}]},{cowboy_req,ensure_response,2,[{file,"src/cowboy_req.erl"},{line,883}]},{cowboy_protocol,next_request,3,[{file,"src/cowboy_protocol.erl"},{line,488}]}]}

This one is "normal", ie the crash happened when trying to send data. However I agree the error message is a bit annoying.

Shouldn't be a problem in 2.0.


 At the moment it uses a lot of jQuery functions and re-implementing those might render the plugin a little heavy.

...and yet much faster!
I'd like to help, maybe I'll do a PR in the spare time :)

Yes please, that would be appreciated.


nixos-version: output configurationRevision

It would be nice to be able to get the configurationRevision of the current system.
This allows the user to figure out more information about the generation.
Motivation for this change
It might also be used for #105910 to show additional information for generations in the list of all generations so that the user can have a better understanding of which generation is what.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] Tested, as applicable: => could not find relevant tests

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[x] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

So sorry it did not get any attention, can you fix the conflicts? I'm interested into getting this merged.

So sorry it did not get any attention, can you fix the conflicts? I'm interested into getting this merged.

Absolutely no problem :) I rebased it and switched it from --configurationRevision to --configuration-revision, since that feels a lot better from my perspective

@RaitoBezarius @ncfavier Do you know who can merge this? Apart from commits by Eelco, the earliest thing apart from treewide shellcheck/shebang changes in this file are from 2016, so I don't really know who to ping...


Adapt to Google selflink changes

The self link for Google images was transformed twice (Frontend and backend).
As this is really inefficient, the selflink property now contains the unaltered Google API link.
The Frontend now needs to be adapted to parse the selflink from the API link instead.
Further thoughts: the API link should be passed as value of the imageID property as this is the reference to run the image.
Reference: https://github.com/redhatcloudx/transformer/pull/581

Solved in: https://github.com/redhatcloudx/cloud-image-directory-frontend/pull/116


Add KFP to the new html2parquet and HAP transforms

Search before asking

[X] I searched the issues and found no similar issues.

Component
KFP workflows
Feature
Two new transforms need to have the KFP pipeline added.

html2parquet: https://github.com/IBM/data-prep-kit/pull/666 which has been merged
HAP: https://github.com/IBM/data-prep-kit/pull/685 This one (the Ray version) is still under review and has not been merged yet.  It will be merged in a few days.

Are you willing to submit a PR?

[ ] Yes I am willing to submit a PR!

Thank you, @revit13 and @roytman. Nice job in such a short time!


Ahnafahamed

Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

[x] checked whether my profile appears in the website

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] Any dependent changes have been merged and published in downstream modules

@vikasganiga05 thank you for the feedback I have added the changes


26336 - more global variables

In this PR, included some more variable like company name and the user attributes fields to the existing globaldata

@hrombach please merge

The implementation had to be reworked because the protected fields being cast to array caused the field names to contain corrupt characters which made them practically inaccessible.
Because the fields are now always loaded from DB, a fact which could not easily be changed due to limitations in doctrine, @sbrueggenolte and me decided it would be better to remove the option to choose which attribute data sets to load and instead make it a catch-all boolean option. This improves performance by removing a loop and some conditions.

One more performance tweak: I removed the config option to assign "sUserLoggedIn" to the template since it is always initialised, so the if-condition is a waste of performance.


CVEs still showing up in latest version of Go 1.22.2

govulncheck version
go version (v1.22.2)
Does this issue reproduce at the latest version of golang.org/x/vuln?
Yes
Output of go env in your module/workspace:
na

What did you do?
The following CVE's are still showing up in our container scans although they are reported as patched. We downloaded the latest go version (v1.22.2), but we still see the stdib CVEs being reported for latest golang version.
•	CVE-2023-29405 patched ;
•	CVE-2023-29402 patch;
•	CVE-2023-29404 patch;
HIGH:
•	CVE-2023-29403 patch
•	CVE-2023-39323 info ;
•	CVE-2023-39325 info;
•	CVE-2023-44487 info;
•	CVE-2023-45285 info;
What did you see happen?
CVE's noted above still show up in scans
What did you expect to see?
Scans showing these CVEs as remediated in latest version

Note that Go 1.22.2 is not the current latest version. That version is Go 1.22.3, released 10 days: https://groups.google.com/g/golang-announce/c/wkkO4P9stm0. Go 1.22.3 includes fixes for CVE-2024-24787 and CVE-2024-24788, but you're referring to other CVEs.
CC @golang/vulndb.

CVE 2023-29040 -> https://pkg.go.dev/vuln/GO-2023-1842 fixed in go1.20.5
CVE 2023-29402 -> https://pkg.go.dev/vuln/GO-2023-1839 fixed in go1.20.5
CVE 2023-29404 -> https://pkg.go.dev/vuln/GO-2023-1841 fixed in go1.20.5
CVE 2023-29403 -> https://pkg.go.dev/vuln/GO-2023-1840 fixed in go1.20.5
CVE 2023-39323 -> https://pkg.go.dev/vuln/GO-2023-2095 fixed in go1.21.2
CVE 2023-39325 -> https://pkg.go.dev/vuln/GO-2023-2102 fixed in go1.21.3
CVE 2023-44487 -> not found from pkg.go.dev/vuln. From Snyk https://security.snyk.io/vuln/SNYK-GOLANG-GOLANGORGXNETHTTP2-5953327 it's an old issue
CVE 2023-45285 -> https://pkg.go.dev/vuln/GO-2023-2383 fixed in go1.21.5
@MyDogIsMyPersonality I don't know what vuln scanner you are using, but can you please contact your vulnerability scanning service provider for this issue?

 If you are scanning binaries, downloading a newer version of Go is not sufficient. Binaries need to be recompiled.


chore: restructure the getting started guide

Explanation
Restructure the getting started guide.
Related issue
Fixes #

/cherry-pick release-0.2


Add Reporting Begins to sports templates based off of estimated start time

No longer allow inputs of reporting begins on certain sports templates....This time will be preset based off of the event start time

I need to know the number of hours added to estimated start time per sport.

Will get you them soon....calculating longest games/matches ever played for each sport

NFL 8 hrs
NCAA FB 6 hrs
MLB 9 hrs
NBA 6 hrs
NCAA BB 6 hrs
WNBA 6 hrs
NHL  6 hrs
soccer 6 hrs
Mens Tennis 9 hrs
Women's Tennis 6 hrs

Some weird behavior....
If I enter the date and time (but not the time zone) into est start time....the event expiration only updates to 2 hrs ahead
And If I hit next at the bottom I can create the market with the unupdated wrong info in the reporting begins

closing


Add flag to "clean" command to target only messages with attachments.

Adds a new "-attachments" switch to the clean command, which if provided limits the clean operation to messages with attachments

Absolutely true, I'll shorten it

Absolutely true, I'll shorten it

All done, gave it a quick test on my self-hosted instance

All done, gave it a quick test on my self-hosted instance


Will this work as an audio only player?

I have several audio files I want to provide and need to apply DRM protection on them while they stream. Will this player suffice?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 29324688-d2e7-71ad-7ada-ab561d97fb23
Version Independent ID: a06a4949-870d-07d4-2ac4-8f54727b53bf
Content: Playback with Azure Media Player - Azure
Content Source: articles/media-services/latest/use-azure-media-player.md
Service: media-services
GitHub Login: @Juliako
Microsoft Alias: juliako

@aszalacinski Thank you for your feedback! We will review and provide an update as appropriate.

@aszalacinski , Please follow the steps mentioned here to apply DRM protection to the audio files while they stream. Please let me know if this helps.

@aszalacinski , I will go ahead with the closure of this issue. Feel free to re-open the issue if you have further queries.


Improve Capacity usage on AIX boxes

Ref https://github.com/AdoptOpenJDK/openjdk-infrastructure/issues/1151
We resolved this resource limit problem by reducing the amount of RAM which the builds script uses for it's calculation. This isn't ideal, and I suspect a preferable solution would be to make use of the NUM_JOBS variable to cap the number of things that can be run in parallel, as this can be controlled more effectively on a per-machine basis using the NUM_PROCESSORS variable we have on most of the machines in jenkins (Although at the moment I'm not sure if this is used by the build processes other than for arm32)

Commenting - because it is still open (here). Maybe it just needs closing. However, now that the ramdisk is not supposed to be used - the 16G that was used for the RAM disk is available for other work - maybe allowing more memory again.

Yeah can close this and open a new one if required.


update kurbo dependency

druid seems locked on version 0.14.x of usvg and resvg pings kurbo to vs 0.8.0. unfortunately druid uses 0.8.1 which caused a perceived regression in resvg. unfortunately this state of affairs has prevent upgrading usvg in druid and as a result I can't investigate if the newer versions of usvg make it possible to resolve the majority of the issues with svg rendering.

@RazrFalcon do you have a test case for the issue caused by the kurbo regression? only place I could find in here that seems related is this line should be a simple adjust of the value to something like ~0.0041 to fix the value change between 0.8 and 0.8.1. but I don't have any samples handy that trigger that code path.

Just update kurbo and run tests. Some text-on-paths will fail.
The "regression" should be fixed by inverting precession based on the current scale.


httplib: 0.14.1 -> 0.14.2

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/yhirose/cpp-httplib/releases.
meta.description for httplib is: A C++ header-only HTTP/HTTPS server and client library
meta.homepage for httplib is: https://github.com/yhirose/cpp-httplib
meta.changelog for httplib is: https://github.com/yhirose/cpp-httplib/releases/tag/v0.14.2
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.14.2 with grep in /nix/store/vl4i1jc0mp1p2naz8ynvn11i1sfcvg3k-httplib-0.14.2
found 0.14.2 in filename of file in /nix/store/vl4i1jc0mp1p2naz8ynvn11i1sfcvg3k-httplib-0.14.2

Rebuild report (if merged into master) (click to expand)

7 total rebuild path(s)

7 package rebuild(s)

First fifty rebuilds by attrpath
citra-canary
citra-nightly
httplib
obs-studio-plugins.advanced-scene-switcher
soundux
yuzu-early-access
yuzu-mainline

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/vl4i1jc0mp1p2naz8ynvn11i1sfcvg3k-httplib-0.14.2 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A httplib https://github.com/r-ryantm/nixpkgs/archive/eb9018d59225a5c3044922946c0cd6f56e8e2c53.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/eb9018d59225a5c3044922946c0cd6f56e8e2c53#httplib

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/vl4i1jc0mp1p2naz8ynvn11i1sfcvg3k-httplib-0.14.2
ls -la /nix/store/vl4i1jc0mp1p2naz8ynvn11i1sfcvg3k-httplib-0.14.2/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

7 packages built:

citra-canary
citra-nightly
httplib
obs-studio-plugins.advanced-scene-switcher
soundux
yuzu-early-access
yuzu-mainline

Maintainer pings
cc @aidalgol for testing.

Result of nixpkgs-review pr 274527 run on aarch64-darwin 1

1 package built:

httplib


repost : pug is undefined no-undef (already tried existing issues related to this)

Sorry that I had to post an issue which has already been posted several times here.I have seen the other issues related to this, and i tried almost all the solutions provided to those issues. This is what I have done so far :

Created a new react app using "create-react-app"

eject the app using "npm run eject"

install  https://github.com/pugjs/babel-plugin-transform-react-pug. Added a .babelrc file in root director and added the following to .babelrc file :

{
    "plugins": [
      "transform-react-pug",
      "transform-react-jsx"
    ]
}

installed https://github.com/ezhlobo/eslint-plugin-react-pug  from the github documentation  and created a .eslintrc file and added the following to the .eslintrc file

{
    "plugins": [
        "react-pug"
    ],
    "extends": [
        "plugin:react-pug/all"
    ],
    "globals": {
        "pug": "readonly"

    }
}

In App.js I added the following simple pug code

import React from 'react';
class App extends React.Component {
  render() {
    return pug`
      div
        h1 My Component
        p This is my component using pug.
    `;
  }
}
export default App;

After that I've uninstalled the node-modules and re-installed it. And then run npm-start. But no matter what I am getting "pug is undefined no-undef" error message in the compiler.

What went wrong here ?

I was able to make it work. You can check it out here

@zami45 your solution is actually right ;). If you have any ideas how we can make it more clear here in documentation for other people, let me know.


Remove virtual from ToBytes method

No need to mock the method call as it is not a service call.

API change check
APIView has identified API level changes in this PR and created following API reviews.
Azure.Core.Amqp

Approving to unblock, probably good to get architect feedback on whether it's needed.

/cc @KrzysztofCwalina @tg-msft thoughts?

Approving to unblock, probably good to get architect feedback on whether it's needed.

/cc @KrzysztofCwalina @tg-msft thoughts?

Approving to unblock, probably good to get architect feedback on whether it's needed.

/cc @KrzysztofCwalina @tg-msft thoughts?

Confirmed that it is correct to leave off virtual here since there are public methods to create the type.


hostname must not be used for Exchange 2010 OWA

Hello.
In order to have letsencrypt-win-simple run and find the hostname of my owa instance (outlook web app), I have to set a hostname in the IIS bindings of the default website. However, this configuration makes owa fail.
Thoughts?

This is going to be possible with phase 3 of #398, which will allow you to chain manual input of hostname(s) to IIS site installation. The upcoming v1.9.7 release represents phase 2 of that rework.
In the meantime, there is a workaround with v1.9.7.

Create a separate website with port 80 binding(s) for the domain(s) your OWA is accessible from.
Optional: redirect the root of the separate site to https:// for your users
Use LEWS to generate a certificate for the separate site
Delete the generated https binding(s) from the separate site (as they take priority over your default site)
Link the generated certificate to the https bindings of your default site

LEWS should then be able to detect and renew the certificate on the default website.

So,
This means there is currently no way to automate the process at this time?

No, though after those steps the renewal should be able to run automatically. You just have to keep that separate site up and running.

Ok,
Thanks!

This is a duplicate of #349 also, so I'll close it for the overview.


Fix FormSubmissionsPanel on Django 5.0 when creating a new form page

Fixes #11405
Django 5.0 rejects FormSubmission.objects.filter(page=page) when page is an unsaved in-memory instance. Since these can clearly not have any submissions, return an empty queryset in this case.
Also add end-to-end tests for the create and edit views with FormSubmissionsPanel in place.
Please check the following:

[ ] Do the tests still pass?[^1]
[x] Does the code comply with the style guide?

[x] Run make lint from the Wagtail root.

[x] For Python changes: Have you added tests to cover the new/fixed behaviour?

[^1]: Development Testing

Backported & tested on stable/5.2.x


Update alleycats-core, cats-core to 2.6.0

Updates

org.typelevel:alleycats-core
org.typelevel:cats-core

from 2.5.0 to 2.6.0.
GitHub Release Notes - Changelog - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.typelevel" } ]

labels: library-update, semver-minor

Superseded by #244.


Ian Campbell: Watch icustomboxes.com

Ian Campbell requests the watch of the watch_keyword icustomboxes\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

Approved by Cody Gray in Charcoal HQ

icustomboxes\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.


Fix pageResultListener leak

A PageDownstreamContext that is being killed may still receive
setBucket calls because the context is still accessible until the kill
operation is completed.
The response listeners that happened between this "kill already in
progress" and "context is removed" window where never released.

This is more or less the same as in https://github.com/crate/crate/pull/5128 but adopted for 1.0

Jenkins failed because of Task 'pmdMain' not found in root project 'sql_tests_on_PR'. :(


Displaying the type and shape of an array in the call stack during debugging

Hello
During debug, the call stack in PyCharm display the type and shape of an array variable next to its name (e.g., in np.ndarray and torch.Tensor).
Attached is the call stack in VScode and in PyCharm for two np.ndarrays:

This feature saves a lot of mouse-work (finding the variable in the call stack, opening it, scrolling to the shape, etc.), especially in N-dimensional arrays that are usually used in optimization tasks (ML, DL, etc.).
For example, in matrix multiplication the elements of the intermediate matrices are usually less interesting than the N-dim shapes of the matrices themselves. which are crucial to for the multiplication operation.
Thanks for all your effort and time on the product, I really enjoy working with it.

https://github.com/microsoft/vscode/issues/146748


Update Mantine package to 6.0

Can confirm that the the plugin currently in fact does not work with the latest version of mantine. Maybe it might also be a good idea to move gatsby-ssr into a peer dependency in the future?


Remove dependency - pandas_datareader

Probably this is not required. pandas is good enough.
If none of us uses pandas_datareader, we may remove it from the dependency list.

Use this command to remove the dependency
poetry remove pandas-datareader

Done already


The merging of facilities is not reflected in the "facility claims" dashboard

Overview
Through the facility claims process, the stakeholder management team becomes aware of duplicate facilities in the tool. (There are some instances in which facility owners / senior management claim duplicate profiles without reporting them as duplicates. The need to merge is confirmed through an exchange with the individual that's claimed the profiles.)
Once the facilities have been merged, they only partially update in the Facility Claims Dashboard. These two claims now both point to the same facility:

Expected Behavior
Should one of the facility claims disappear?
Although both facility claims remain in the tool, the Facility Claim Review Notes do not duplicate across both claims. It is also not possible to Approve both instances of the Facility Claim.
Actual Behavior
An error message appears following attempts to approve the claim on the second entry:

The second facility claim remains in the "Pending" state.

This issue has been encountered with an additional set of duplicate facilities which were claimed and then merged following consultation with the claimant:

This issue has been encountered with an additional set of duplicate facilities which were claimed and then merged following consultation with the claimant:


Data by US state?

I noticed that you have created another file breaking it down by region within China. Any interest or possibility on doing something across each US state?

The data source used does not differentiate by US state unfortunately

Fair - is your script set up so that if the data source makes it available, it would be available here as well?

Not my script however this is a quite rigid attempt so I guess the authors might have ideas about how to add that. Maybe generating a separate file with US data is a good solution. The problem is that JHU didn't really make it to stick to a meaningful US data representation. They kept changing things pretty often :\

Yes, I'd love to add another file for US data like we do for China. I'm actively looking for a good source of US state-level data. I found that the CDC publishes a CSV file daily, but only during weekdays and they only report cases, not deaths. If I don't find anything better than that, then I guess that's what we'll have to do.

I just added state-level USA data, can you please take a look and confirm it's good? We even get total count of tests for this dataset: https://github.com/open-covid-19/data/blob/master/output/usa.csv

That looks fantastic, well done.


Add countErrorMargin to WaitForControlledPods

Add countErrorMargin option to WaitForControlledPods
When using preemptibles on large scale, number of nodes do not become stable, so Running pods never reaches DesiredPodCount.

Tested manually, work as expected.
/cc @mm4tt
/cc @wojtek-t

/unhold


Empty university author list breaks page

Corner case here, but if no university authors are specified (see isOtherUniversity flag), the query and page breaks here:
https://github.com/ucd-library/rp-ucd-client/blob/3a83ac68a17a54797a3f01ea2797c63a81e0a62b/client/public/elements/pages/work/rp-page-work.js#L156
Followup the isOtherUniversity is a little off, it's just checking for FacultyMember which doesn't include staff.  loop could use a little tlc as well:
https://github.com/ucd-library/rp-ucd-client/blob/sandbox/client/public/src/models/WorkModel.js#L182-L198

has been fixed here: https://github.com/ucd-library/rp-ucd-client/blob/sandbox/client/public/elements/pages/work/rp-page-work.js#L170


Data model validation won't accept empty strings

Describe the bug
ASP.NET Core 3 (3.0.0-preview8.19405.7)
In my data model I get a Dictionary<string, string> form the client and unless all the keys have a Value (not just empty string, but actual content) it comes up as invalid model.
This part of my code was working before I upgraded to .net 3, so i suspect that there are some changes to that part of asp.net core.
I tried adding the [Required(AllowEmptyStrings =true)] atribute but it has no effect.
The Dictionary is needed because I have a list of fiealds that are configurable from json. I'm also trying to find a easy solution to validate the fields based on the json (requiered, is it a email or phone number etc).

@dpeter99 Thanks for reporting this issue! Could you please provide a minimal project that reproduces this issue so that we can investigate?


feat: add unit testing support

What is it?
@builder.io/qwik/testing
The main idea is to create a layer/library to expose differences methods for writing unit testing in Qwik.
Below it you have an example of how it should look

[ X ] Feature / enhancement
[ ] Bug
[ ] Docs / tests

Description
@builder.io/qwik/testing
The main idea is to create a layer/library to expose differences methods for writing unit testing in Qwik.
Below it you have an example of how it should look
User API:

createDOM: Generate a DOM for every unit test and expose screen,render.userEvent
screen: Return a DOM
render: Is the same function that inside @builder.io/qwik
userEvent: Is a wrapper friendly of trigger  same function that inside './element-fixture'

//vite.config.ts
import { defineConfig } from 'vite';
import { qwikVite } from<EMAIL_ADDRESS>import { qwikCity } from<EMAIL_ADDRESS>import tsconfigPaths from 'vite-tsconfig-paths';

export default defineConfig(() => {
  return {
    plugins: [qwikCity(), qwikVite(), tsconfigPaths()],
    define: {
      'globalThis.qTest': true,
      'globalThis.qDev': true,
    },
  };
});

// card.test.tsx

import { createDOM } from<EMAIL_ADDRESS>import { test, expect } from 'vitest';
import Card from './card.tsx';

test(`[Card Component]: Only render`, async () => {
  const { screen, render } = createDOM();
  await render(<Card />);
  expect(screen.outerHTML).toCointain('Counter_0');
});

test(`[Card Component]: Click counter +1`, async () => {
  const { screen, render, userEvent } = createDOM();
  await render(<Card />);
  expect(screen.outerHTML).toCointain('Counter_0');
  await userEvent('button.btn-counter', 'click');
  expect(screen.outerHTML).toCointain('Counter_1');
});

PD: Thnks @manucorporat  for the support!
Checklist:

[x ] My code follows the developer guidelines of this project
[x ] I have performed a self-review of my own code
[x ] I have made corresponding changes to the documentation
[ x] Added new tests to cover the fix / functionality

one unit test is failing, i am happy to merge this as it is (phase 1)

one unit test is failing, i am happy to merge this as it is (phase 1)

:) yeah! , I don't know Why failed the pipeline ?

@manucorporat I updated the component.unit.test with the new implementation and work fine it locally but the pipeline doesn't pass

I know why it does not pass, it's tricky, tomorrow lets talk in our scheduled meeting and figure it out

everything pass 🙌


[PORT] Fix for issue #2913 - Log and trace activity don't let you set the Label property

Port this change from botbuilder-dotnet/master branch:
https://github.com/microsoft/botbuilder-dotnet/pull/3183

#2913

added Label property to LogAction and TraceActivity

resolved


Feature: Hub & Spoke

What is the context of this PR?
Implements the basic functionality of the hub and spoke feature. This does not cater for repeating sections.
For now, the hub is defined as a top-level schema object but this is subject to change once https://trello.com/c/BJPC98fW/3086-move-final-summary-block-out-of-sections is implemented. We should potentially have a single selection of the submission type for a schema ie Summary/Confirmation/Hub.
Trello
How to review
Ensure:

The functionality is as expected using the test_hub_and_spoke.json file.
The different scenarios highlighted by the Google Slides are as expected. (Link in Trello)
Non hub schemas behave the same.

Will reopen once new changes are complete.

@bitdivision @ajmaddaford @JamesGardiner
I may have missed stuff but here is an update of the recent changes:
CompletedStore is now ProgressStore, this new store will keep track of the 'progress' of sections in the survey and its completed location. Prior to this change, the Hub was calculating the routing path for each section so that it could work out the sections status and the URL the section is supposed to link to. Storing the state of each section now means that this is no longer necessary and should be much more efficient.
Since each section also needs to link to its relevant location ie summary, first incomplete location etc, we have created an endpoint /hub/<section_id>/ that will be used to redirect to the correct location for a given section. This eliminates having to calculate the path on the hub for each section.
Progress Store's structure is now hierarchical, previously, the completed location and completed sections were both flat but a location always belongs to a section, therefore to make certain aspects such as calculating whether a section is complete or not, the location has been nested by the section it belongs to.
The new structure is:
{
    'section-1': {
        'status': 'COMPLETED',
        'locations': ['location-1', 'location-2'],
    }
}

Only complete and in-progress sections are stored. If the one and only location for a section is removed, then the section is also removed from the progress store, ie not storing sections with empty locations.
For repeating section, the idea was to potentially store it same/similarly to the answer store, where the key is a tuple of section_id and the list_item_id. The hub's section endpoint could become /hub/<section_id>/<list_items_id/


Check if tenant has a business M365 license

Corso only supports tenants with M365 business licenses.
Adding a check in Corso for this would avoid any confusion. See #3298 for context.

+1
Also worth adding it to the Quick Start guide under a Prerequisites section https://corsobackup.io/docs/quickstart/ .
We do have this information under FAQ section, but no harm in adding it to quickstart guide as well

+1
Also worth adding it to the Quick Start guide under a Prerequisites section https://corsobackup.io/docs/quickstart/ .
We do have this information under FAQ section, but no harm in adding it to quickstart guide as well

@pandeyabs great opportunity to familiarize yourself with the docs tooling. It is very well documented easy to get started. Happy to help if you run into issues.

Thanks! I'll take a stab at the doc changes sometime this week.


fix(nuxt): add @types/node as a peerDep

🔗 Linked issue
❓ Type of change

[ ] 📖 Documentation (updates to the documentation or readme)
[x] 🐞 Bug fix (a non-breaking change that fixes an issue)
[ ] 👌 Enhancement (improving an existing functionality like performance)
[ ] ✨ New feature (a non-breaking change that adds functionality)
[ ] 🧹 Chore (updates to the build process or auxiliary tools and libraries)
[ ] ⚠ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description
This aims to improve DX by installing @types/node by default (but respecting user's preference if they install a different version, to match their own node version).
📝 Checklist

[ ] I have linked an issue or discussion.
[ ] I have updated the documentation accordingly.

Could we do both? @types/node is really required for the types to work (e.g. process.dev), but we ideally want to defer to the user to pick which version (16/18/etc.). Even if package manager force installs @types/node, I don't see an issue with it.

I think it would fix the issue for new projects, but not affect existing ones.
What are you worried that this change might do?

We could simply instruct old projects to install both typescript and @types/node packages as currently documented if this change is purely for them.
I am even up to supporting nuxi typescript setup command to automate local ts setup :)
Package managers never had a persistent and predictable behavior with peer dependency handling. We might need to always keep updating a new range for supported node and for (even small!) fragment of users are not using typescript, it is just an additional dependency forced to install (or see warn)

You're right, we would need to keep updating the range. But we currently need to do the exact same thing for engines.node, which is a couple of lines further down the file. I think keeping them in sync isn't too much.
Of course we can tell people to add the dependency themselves. But I think this is exactly the purpose for which we have peerDeps, right?
I'm still not sure what disadvantages there would be to this. I'm not suggesting adding typescript which would definitely be too much for those not using type-checking. But @types/node is used and picked up by IDEs even if users don't use type-checking, and will result in a broken experience if missing. See, for example https://github.com/nuxt/nuxt/issues/20040#issuecomment-1494804429.
I am very happy to revert this change if we experience any negative issues.

@kpetrillo I'm not sure what issue you're referring to. Would you create a new issue - with a reproduction?


Cannot create pods properly on Ubuntu with k8s v1.0.0

The cluster is created via Docker, and i have only one machine acting as master node currently.
The components talk to each other via HTTPS, certs stuff i mean.
Everything seems fine to me unless i try to deploy dns (v8).
It complains as
$ kubectl --namespace=kube-system create -f skydns-rc.yaml
Error from server: error when creating "skydns-rc.yaml": ReplicationController "kube-dns-v8" is forbidden: Namespace kube-system does not exist
/cc @antoineco

Made some progress by changing the parm "--admission-control" of api-server to be less sensitive.
And then came across a new one as #8734. I added the "--containerized" for kubelet and enforcing the SElinux, which leads me to
docker logs for kubelet
E0719 05:56:34.501091       1 kubelet.go:1190] Unable to mount volumes for pod "kube-dns-v8-cjlqc_kube-system": fork/exec /nsenter: no such file or directory; skipping pod
E0719 05:56:34.507480       1 pod_workers.go:111] Error syncing pod c57b6408-2dda-11e5-b392-f8bc1298bf7c, skipping: fork/exec /nsenter: no such file or directory
docker version:1.7.1
k8s version:1.0.0
/cc @pmorie

Also I bet "--containerized" may not be ready currently?

Regarding the first post, with the recommended admission controls you're expected to create namespaces manually, bit apparently you figured that out.
Are you running your kubelet in privileged mode?

U R a great help@antoineco
I did fix it myself yesterday though ;-) Thx anyway.
Closing it.

@antoineco I'm new to kubernets, and I got the same problem.
$ cluster/kubectl.sh create -f cluster/addons/kube-ui/kube-ui-rc.yaml --namespace=kube-system
Error from server: error when creating "cluster/addons/kube-ui/kube-ui-rc.yaml": ReplicationController "kube-ui-v1" is forbidden: Namespace kube-system does not exist

and I can not find  'kube-system' in namespace.
$ cluster/kubectl.sh get namespace
NAME      LABELS    STATUS
default   <none>    Active

So you mean I should create the kube-system manualy?
If so , how to create a namespace ?

You need to create this namespace beforehand indeed (at least with the default admission control).
Take a look at this: https://github.com/kubernetes/kubernetes/blob/master/cluster/saltbase/salt/kube-addons/namespace.yaml


xautolock: fix compilation

Motivation for this change
fix compiler error, because storage size of status argument was unknown.
Things done

[x] Tested using sandboxing
(nix.useChroot on NixOS,
or option build-use-chroot in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] OS X
[ ] Linux

[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Did you make this patch yourself, or did it come from an upstream?

I did this on my own. A similar patch is in Alpine Linux: http://git.alpinelinux.org/cgit/aports/tree/main/xautolock?id=fc17bb1e8f1a45a14396d48d8d69857446850204
xautolock also does not compile on Archlinux, but there is a still a binary package...
I heard that xautolock upstream is kind of dead.

I have also a different version, which works without patching, by defining SYSV

seems to be already fixed in unstable...


go/importer: lacking a way to pass a build.Context to obtained srcimporter

What version of Go are you using (go version)?
go version go1.9rc2 linux/amd64

What operating system and processor architecture are you using (go env)?
GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/michael/go"
GORACE=""
GOROOT="/home/michael/sdk/go1.9rc2"
GOTOOLDIR="/home/michael/sdk/go1.9rc2/pkg/tool/linux_amd64"
GCCGO="/usr/bin/gccgo"
CC="gcc"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build444004786=/tmp/go-build -gno-record-gcc-switches"
CXX="g++"
CGO_ENABLED="1"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"

What did you do?
I’m writing a unit test where I construct a custom GOPATH for each test case. I use types.Config{Importer: importer.For("source", nil)}, but see no way to pass my per-test custom GOPATH to that importer: importer.For calls srcimporter.New as follows:
return srcimporter.New(&build.Default, token.NewFileSet(), make(map[string]*types.Package))

As srcimporter is internal, calling importer.For is the only way of obtaining one.
My current workaround is to overwrite build.Default, but that precludes my unit tests from running in parallel.
Could we add a way to obtain a source importer which allows passing in a build.Context?
cc @griesemer

Specialized lookup should be supported via the lookup interface - which is currently not supported. It's a known issue. I'm going to close this as a duplicate of #13847, fixing that issue will enable this request as well. The problem is that we may have to change the API (again), and that means adding yet another entry point because we cannot change what's here due to the Go 1.0 guarantee.


Release 1.1.0 macOS

[x] macos: see if I can self sign to get around broken app warning
[ ] macos: test upgrading/downgrading (overwriting with dmg)

@ethanaobrien The app got approved and is now available on the Mac App Store: https://apps.apple.com/app/id1625925255
However, the mac app store version currently has an issue and does work, so it's going to take me a bit longer to fix that.

Awesome!