[WIP] Merge coverage checks with the unit tests

Proposed changes
This PR merges the coverage checks with unit tests and removes the extra test coverage CI run
Fixes
If it fixes a bug or resolves a feature request, be sure to link to that issue.
Types of changes
What types of changes does your code introduce to agents-aea?
Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist
Put an x in the boxes that apply.

[ ] I have read the CONTRIBUTING doc
[ ] I am making a pull request against the develop branch (left side). Also you should start your branch off our develop.
[ ] Lint and unit tests pass locally with my changes and CI passes too
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have checked that code coverage does not decrease.
[ ] I have added necessary documentation (if appropriate)
[ ] Any dependent changes have been merged and published in downstream modules

Codecov Report
Base: 97.31% // Head: 87.25% // Decreases project coverage by -10.06% :warning:

Coverage data is based on head (d5ea12b) compared to base (630d9ba).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #494       +/-   ##
===========================================
- Coverage   97.31%   87.25%   -10.07%
===========================================
  Files         221      363      +142
  Lines       19484    29389     +9905
===========================================
+ Hits        18961    25643     +6682
- Misses        523     3746     +3223

Flag
Coverage Δ

unittests
87.25% <100.00%> (-10.07%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

aea/__version__.py
100.00% <100.00%> (ø)

aea/package_manager/base.py
98.93% <100.00%> (+0.28%)
:arrow_up:

aea/package_manager/v0.py
87.87% <100.00%> (+0.51%)
:arrow_up:

aea/package_manager/v1.py
90.00% <100.00%> (-0.39%)
:arrow_down:

aea/cli/check_packages.py
96.49% <0.00%> (-0.32%)
:arrow_down:

aea/skills/base.py
100.00% <0.00%> (ø)

aea/configurations/base.py
100.00% <0.00%> (ø)

aea/helpers/search/models.py
100.00% <0.00%> (ø)

aea/crypto/registries/base.py
100.00% <0.00%> (ø)

... and 145 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

I cannot see the coverage report so I cannot judge. One thing I will note is that protocols need not to be 100% covered. These are auto-generated from the spec contained in the README.md file. Only the dialogues are 100% covered in the other protocols
---------- coverage: platform linux, python 3.10.4-final-0 -----------
Name                                              Stmts   Miss  Cover
---------------------------------------------------------------------
packages/valory/protocols/abci/__init__.py            4      4     0%
packages/valory/protocols/abci/abci_pb2.py          264    264     0%
packages/valory/protocols/abci/custom_types.py      536    227    58%
packages/valory/protocols/abci/dialogues.py          23      0   100%
packages/valory/protocols/abci/message.py           480    191    60%
packages/valory/protocols/abci/serialization.py     536     13    98%
---------------------------------------------------------------------
TOTAL                                              1843    699    62%

---------- coverage: platform linux, python 3.10.4-final-0 -----------
Name                                             Stmts   Miss  Cover
--------------------------------------------------------------------
packages/valory/protocols/acn/__init__.py            4      4     0%
packages/valory/protocols/acn/acn_pb2.py            46     46     0%
packages/valory/protocols/acn/custom_types.py       80     49    39%
packages/valory/protocols/acn/dialogues.py          23      0   100%
packages/valory/protocols/acn/message.py            97     46    53%
packages/valory/protocols/acn/serialization.py      88     13    85%
--------------------------------------------------------------------
TOTAL                                              338    158    53%

---------- coverage: platform linux, python 3.10.4-final-0 -----------
Name                                                         Stmts   Miss  Cover
--------------------------------------------------------------------------------
packages/valory/protocols/contract_api/__init__.py               4      4     0%
packages/valory/protocols/contract_api/contract_api_pb2.py      63     63     0%
packages/valory/protocols/contract_api/custom_types.py          32     23    28%
packages/valory/protocols/contract_api/dialogues.py             24      0   100%
packages/valory/protocols/contract_api/message.py              161     67    58%
packages/valory/protocols/contract_api/serialization.py        185     13    93%
--------------------------------------------------------------------------------
TOTAL                                                          469    170    64%

---------- coverage: platform linux, python 3.10.4-final-0 -----------
Name                                                     Stmts   Miss  Cover
----------------------------------------------------------------------------
packages/valory/protocols/ledger_api/__init__.py             4      4     0%
packages/valory/protocols/ledger_api/custom_types.py        38     29    24%
packages/valory/protocols/ledger_api/dialogues.py           23      0   100%
packages/valory/protocols/ledger_api/ledger_api_pb2.py      87     87     0%
packages/valory/protocols/ledger_api/message.py            201     88    56%
packages/valory/protocols/ledger_api/serialization.py      189     13    93%
----------------------------------------------------------------------------
TOTAL                                                      542    221    59%

---------- coverage: platform linux, python 3.10.4-final-0 -----------
Name                                              Stmts   Miss  Cover
---------------------------------------------------------------------
packages/valory/protocols/abci/__init__.py            4      4     0%
packages/valory/protocols/abci/abci_pb2.py          264    264     0%
packages/valory/protocols/abci/custom_types.py      536    227    58%
packages/valory/protocols/abci/dialogues.py          23      0   100%
packages/valory/protocols/abci/message.py           480    191    60%
packages/valory/protocols/abci/serialization.py     536     13    98%
---------------------------------------------------------------------
TOTAL                                              1843    699    62%

I believe these and any __init__.py or _pb2.py files should not contribute to the loss of coverage, in case they currently do.


Rewards and actually claimed rewards values discrepancy.

Describe the bug
"Claim Rewards" in staking protocol show 0.261251874 SHDW available to claim which is less than I saw couple days ago ~1.0.
When "Claim rewards" pressed shows 1.088114 SHDW to claim.
To Reproduce
Steps to reproduce the behavior:

Go to 'testnet.shdwdrive.com'
Click on 'Claim Rewards'
Click on button 'CLAIM REWARDS'
See values discrepancy between point 2 and 3.

Expected behavior
I would expect values from 'Claim Rewards' and when actually claiming rewards to be equal.
Screenshots

Desktop (please complete the following information):

OS: Windows 11
Brave
v1.62.162 (Feb 7, 2024)

Smartphone (please complete the following information):

Device: OnePlus 8 Pro
OS: Android OxygenOS 13.1
Brave
v1,62,156

Additional context
my wallet address: 6iksFnb5BmnGrFmyisEt3oCXaD7Qnuy5tCkmAdFhL3Zv
I have now claimed rewards.

Thank you for this report! We will investigate.

hi! This should now be resolved. If there's still a discrepancy in the UI vs when you claim, the claim value in the wallet simulation is correct and the UI will self-correct after your next claim transaction is processed.


Fix crash when round-tripping a GSFeaturePrefix containing only a comment

Thanks for the fast review!

reviews are faster when a test accompanies them ;)

feel free to tag 3.0.2
"continuous delivery" FTW! :+1:


[Question] How can I read 'Line(s)' from a dxf file from a specific 'Layer'?

I need to know the dimensions of all the Lines from a specific Layer(s).
Thanks for your time.

So, what have you tried so far?
It should be a simple matter of:

Loading the dxf file,
Getting all entities on that layer,
Then iterate through them and get the vector points for each line, and then do some quick math to get the dimensions you want.

Ah..Thanks! I was just not sure how to check the Layer (the 3rd point you mentioned)


.Net 5 no longer supported - Refactor for 6 LTS?

Hello!
.Net 5 fell out of support in May 2022, would anyone mind if I refactor for 6 LTS?
Also, follow-up questions:

IdentityServer4 is being depreciated for a new product called Duende.IdentityServer, which requires a license for commercial use. With this knowledge, should this library drop support for Duende.IdentityServer (i.e PersistedGrantEntityTypeConfiguration in the class ModelBuilderExtensions)?
Last question, do unit tests exist for this project?

Thanks,
-Eric

Hello again,
I had an immediate need to refactor this for 6, I decided to create a new repo based on your work Piero.  I love your work!
Here is that repo:
https://github.com/CosmosSoftware/AspNetCore.Identity.CosmosDb
Thank you for your hard work!
-Eric

Hi Eric!
Thank you very much for your kind words, and I apologize for the late reply but this has been (and still is) a very busy period and unfortunately I didn't have the chance to reply in time.
Please feel free to merge back your work to this repo if you wish.
Cheers,
Piero


files: setup a channel for manually "merge and upload"'ing of Transfers

This setup allows us to trigger the process for converting paygate Transfer objects into ACH files which are uploaded to their ODFI. Initially this is exposed over an admin HTTP endpoint.
Issue: https://github.com/moov-io/paygate/issues/200

Codecov Report

Merging #207 into master will decrease coverage by 0.09%.
The diff coverage is 20%.

@@            Coverage Diff            @@
##           master     #207     +/-   ##
=========================================
- Coverage   56.16%   56.07%   -0.1%
=========================================
  Files          30       31      +1
  Lines        4020     4034     +14
=========================================
+ Hits         2258     2262      +4
- Misses       1299     1307      +8
- Partials      463      465      +2

Impacted Files
Coverage Δ

main.go
0% <0%> (ø)
:arrow_up:

file_transfer_async.go
41.28% <0%> (-0.34%)
:arrow_down:

file_transfer_sync.go
66.66% <66.66%> (ø)

internal/database/mysql.go
61.11% <0%> (-2.78%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8277586...846dded. Read the comment docs.


Refactoring typing imports / usage

We have a lot of typing imports like from typing import this, that, ...
Sometimes they are really long:
https://github.com/viur-framework/viur-core/blob/8809c5077403462b89ea5105bcbfcbeed6c301f9/src/viur/core/skeleton.py#L12
I saw in other projects they import typing aliased with t (ìmport typing as t) and write argument: t.Any.
Maybe we should do this in the viur-core too. What do you think, should this be part of our coding conventions?

I think that's a good idea. Let's do it this way, it's much cleaner.

We should also decide for one task decorator syntax. Currently we have
this (where we import the entire task module):
https://github.com/viur-framework/viur-core/blob/09312ee545da8275c10834a1e92047bab62b7395/src/viur/core/skeleton.py#L1317
and this (where we import every member of the module):
https://github.com/viur-framework/viur-core/blob/09312ee545da8275c10834a1e92047bab62b7395/src/viur/core/securitykey.py#L114

We should use t for Typing and tasks.* for task-related decorators, but not for standard decorators.

fixed by #986


Move tas-client to umd version and adopt in web

refs #92164

@sbatten I would prefer if we only depend on the UMD version of the module and nothing else. For that reason, e.g. semver-umd includes typings:
https://github.com/microsoft/semver-umd/blob/master/semver-umd.d.ts


Sound starts stuttering after approx 10 minutes of local playback (mp3)

Every 5 minutes a new issue... now that the box works again + spotify I have a new issue that only occurs when an MP3 is playing for longer than ~10 minutes, sometimes 11, sometimes 13, sometimes 9 minutes. The sound suddenly starts stuttering/hickups. I can "fix" this temporarily by pausing the audio for a second, but it will reoccur after a few minutes. This is annoying as my kid cannot listen to audiobooks alone.
Here is what I tried:
Added: sdhci-bcm2708.missing_status=0 sdhci-bcm2708.sync_after_dma=0
to: /boot/cmdline.txt
Changed the position of the box.
Re-uploaded and played different MP3 files that have over 10 minutes playtime.
Used htop to see if the cpu has trouble, but no. No changed when the stuttering begins (20% CPU).
Installed ncmpc because a friend said I should try another interface, but I can't even get this running, so no results here I'm afraid.
Used mpg123 to play the file.
There is NO STUTTERING when using mpg123...!?
So I assume it is not about the kernel or hardware, but mpd or so, but I have no idea at all how to fix this. Does anyone have a good idea?
Many thanks in advance!

just to clarify: this does not occur when you play 3 mp3s with each 5 minutes in length in a row?

I can't think why this would have anything to do with the client that's controlling the mpd/mopidy. But I deem it very likely to be an issue with mopidy.

@hoodvisions do you currently use mopidy 3?
If yes, please check, if you used all the changes from #804.

@ZyanKLee exactly, playing multiple files in a row is fine.
@s-martin I have run the installation on friday, so it's likely it is not the v3. I am very hesitant to run sudo apt upgrade though as it took me days and days of work to finally get it up and running :)
Is there a way to make a "snapshot" of my current setup? Could I make an image of the SD card so I could get back to this point whenever I want?
What I haven't tested yet is what happens if I play a spotify track that lasts for longer than 12 minutes. Will do this today.
Many thanks to you and your help, guys!!!

sure, you can just copy the filesystem from the SD card to an image file on your computer. On linux for example you could run:
sudo dd if=/dev/mmcblk0 > Phoniebox-Backup.img

Can you check if memory consumption is increasing while playing the large file?
I suspect that the file is slowly loaded into RAM by mopidy and kept there for some strange reasons.
If you could verify that suspicion, we should see if that issue has been solved in newer versions of the mopidy server (read: mopidy3 perhaps?).

Okay so memory consumption is pretty much stable at 20-30%. I am using a Raspberry 3B, by the way. I haven't made a backup yet - thanks a lot for the hint at how to do it.
I have also tested it playing "large" files from spotify (Tool, Metallica songs etc.) to see if local/spotify makes a difference. So yeah, it works when playing anything from spotify.
Okay, so now upgraded to mopidy 3 and now spotify doesn't work anymore, as the mopidy service stays dead for some reason. Damn! I need this box to run so I'd rather have crackling sound than nothing. I will resume (hopefully it works) to the image I just made and live with a faulty box I guess :)

Could you post tail -n /var/log/syslog and journalctl -u mopidy?

Sure, journalctl -u mopidy returns this: https://pastebin.com/8ADb7mzJ
And the other one returns tail: invalid number of lines: ‘/var/log/syslog’
When I add a 500 to it the output looks pretty much the same as the other one. Hundreds of lines with
Mar  4 16:15:07 raspberrypi mopidy[457]: INFO     New MPD connection from [::ffff:<IP_ADDRESS>]:6600
Hm. Is this supposed to be filled to the brim with these lines?

Well, that seems like some mpd-client polling the mpd all the time for the current status (the phoniebox webinterface perhaps?).
It's ugly, but should not be a problem per sé.

There are messages in the pastebin about the Spotify account data not being readable, though?

You are still using Mopidy 2.2

Mar 02 20:17:06 raspberrypi systemd[1]: Started Mopidy music server.
Mar 02 20:17:10 raspberrypi mopidy[457]: /usr/lib/python2.7/dist-packages/mopidy/ext.py:202: PkgResourcesDeprecationWarn
Mar 02 20:17:10 raspberrypi mopidy[457]:   extension_class = entry_point.load(require=False)
Mar 02 20:17:12 raspberrypi mopidy[457]: INFO     Starting Mopidy 2.2.2

If you are on Buster, you could try to use Mopidy 3. See PR #804
Please use
cd; rm buster-install-*; wget https://raw.githubusercontent.com/MiczFlor/RPi-Jukebox-RFID/develop/scripts/installscripts/buster-install-mopidy3.sh; chmod +x buster-install-mopidy3.sh; GIT_BRANCH=develop bash ./buster-install-mopidy3.sh

I am using it again :)
When I update to mopidy3 nothing works anymore, neither local playback nor can I reach the spotify (IRIS) interface, so I reverted back to the prior backup point. A friend of mine purchased the exact same hardware as I have and will try it this or next weekend.

So if you have any results and log files on your new machine that would be great.

I am using it again :)
When I update to mopidy3 nothing works anymore, neither local playback nor can I reach the spotify (IRIS) interface, so I reverted back to the prior backup point. A friend of mine purchased the exact same hardware as I have and will try it this or next weekend.

Did you try this and this?

We released 2.0 a couple of days ago with many improvements, so you might want to check, if this fixes your issue.

I’m closing this now, feel free to reopen the issue, if the problem still persists in 2.2


Remove the remains of "contrib"

As part of the reorganization effort listed in #1386 this PR removes the "contrib" directory tree and all references to the contrib adapters.
With exception of some of the documentation, all references to contrib should be removed.
make test passes locally

Codecov Report

Merging #1583 (65aa594) into extract_adapters (b9581f5) will decrease coverage by 0.03%.
The diff coverage is n/a.

Additional details and impacted files

@@                 Coverage Diff                  @@
##           extract_adapters    #1583      +/-   ##
====================================================
- Coverage             74.64%   74.61%   -0.03%
====================================================
  Files                   176      175       -1
  Lines                 11997    11977      -20
  Branches               2733     2732       -1
====================================================
- Hits                   8955     8937      -18
+ Misses                 1293     1292       -1
+ Partials               1749     1748       -1

Flag
Coverage Δ

py-unittests
74.61% <ø> (-0.03%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...timelineio/console/autogen_plugin_documentation.py
65.21% <ø> (-2.58%)
:arrow_down:

...-opentimelineio/opentimelineio/plugins/manifest.py
92.95% <ø> (+1.45%)
:arrow_up:

tests/test_plugin_detection.py
91.46% <ø> (ø)

... and 1 file with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9581f5...65aa594. Read the comment docs.


Conditional argument not accepted for dbt_constraints_enabled var

When we want to use conditional logic for dbt_constraints_enabled var it simply doesn't work.
When used the classic way, it works eg.
vars:     dbt_constraints_enabled: true (or false)
But when I pass some conditions, it doesn't work - it gets build just like if dbt_constraints were enabled (true)
This is my config:
vars:     dbt_constraints_enabled: {%- if target.name in ['dev_airflow','dev_local'] -%} false         {%- else -%} true         {%- endif -%}
I tried it on different projects (also clean version of jaffle_shop from dbt) but it didn't help, I started thinking it's not the issue of the config and conditional if else statement, but the package itself, I'd be glad if you could look into it.
I'm also including Stackoverflow question for more context.

I'm relying on dbt core's features for how values are set for variables so I don't think it is any of my code. However, you might want to try setting it a slightly different way using a conditional expression:
vars:
  dbt_constraints_enabled: "{{ 'true' if target.name in ['dev_airflow','dev_local'] else 'false' }}"


Getting the gripper working on AR4-MK2

Hi @ycheng517, thanks for your efforts in adding the gripper! I just thought I'd post my findings when testing this on the AR4-MK2
First, it was not working at all for but I eventually figured out I had to install ros-iron-gripper-controllers using apt.
sudo apt install ros-iron-gripper-controllers

Second, the gripper moves in reverse - that is, the closed state in MoveIt actually opens the gipper, and vice-versa. I'm not sure if this is related to my servo though - it is a HITEC HS-311.
To fix this I just inverted the values in ar_gripper_macro.sdrf.xacro.
See https://github.com/se1exin/ar4_ros_driver/commit/aee4e189507db1bc71a552c59ab89b9721278384

An update to the gripper direction issue. I've replaced my servo with an MG995 and now the original direction is correct.
The gearbox in the HITEC HS-311 must in the opposite direction...

Thanks for pointing out the need to install ros-iron-gripper-controllers, I've added gripper_controllers as a dependency in de761b1954506996d9f08a6ce815fa24f2a04460
Regarding the gripper direction issue, glad you were able to figure it out!


Rav's wishlist #2: Select which ores it may use

So i've noticed that some ores barely get sold in the Jita market, eventhough the prices on them are decent.
Specifically to build a few Dreadnoughts it told me to buy 2000 Compressed Hemorphite.
The Jita market however, only had about 1500 Compressed Hemorphite available.
The easiest way to get around this, is likely to allow the user to tickbox out which ores the solver is allowed to use.

Done in https://github.com/Ramit110/Ramit110.github.io/commit/604f11cbd06981e87f78c12fc5535413f0f8ab60


CodeMirror not building

I downloaded CodeMirror-5.31.0 and extracted it.  Then I entered the root directory of the project ~/CodeMirror-5.31.0/ Once there I ran npm build and npm install but there is still no codemirror.js file in the lib directory ~/CodeMirror-5.31.0/lib/ Am I doing something wrong or is there an issue with the project?  I am running Ubuntu 17.04 with NodeJS v6.12.0.  There is no errors and best I can tell it runs successfully.

What was the output of running npm install and npm run build? Note that you have to run them in that order.

Npm install showed some output about installing phantomjs but no errors.
npm build didn't give any output.
On Sat, Nov 18, 2017, 02:31 Adrian Heine né Lang<EMAIL_ADDRESS>wrote:

What was the output of running npm install and npm run build? Note that
you have to run them in that order.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/codemirror/CodeMirror/issues/5091#issuecomment-345430409,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AB3F9wrl2X1c2qxb0J6qAfcDDrQtdIGHks5s3qQOgaJpZM4Qi26R
.

There has to be some output of npm run build. What's the output of npm -v?

run npm install and npm run build, not npm build


Updated README.md

Removed sentences not finished ( you can finish the sentence after )
Capitalize the README.md to match the file name on github
Removed "However"  to combine the sentence
Removed some pronoun to increase formality and readability

This is a class assignment where students must modify existing documents online to improve readability


Gamma example WebGL support

Weirdly, even the triangle example is failing link now. May be an obscure Rustc bug... will file shortly.

error: failed to write dep-graph to /home/travis/build/gfx-rs/gfx/target/debug/incremental/mipmap-ji74ebttqtcy/s-ews5lr3r3g-hrukv6-working/dep-graph.bin: No space left on device (os error 28)

ugh...
bors r=msiglreith

We probably should disable incremental compilation for nightly builds..

Yes, exactly. Unless Travis allows us to get more space.

On Dec 27, 2017, at 07:14, msiglreith<EMAIL_ADDRESS>wrote:
We probably should disable incremental compilation for nightly builds..
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

bors r+

bors r=msiglreith

And now I wonder if bors is doing anything...

probably needs a rebase

bors r=msiglreith


test: Wait for Docker to start before using it

Tests were intermittently failing in CI with:
dial unix /var/run/docker.sock: no such file or directory
Closes #1102
Closes #1104

LGTM


started refining network config chapter

I need to finish the IPAM assembly on Friday: https://issues.redhat.com/browse/RHOSPDOC-2014

I am going to merge this PR. The rest of the comments that have been addressed or yet to be addressed will be added in a a new PR.


fix: remove DOM api in rendering

Fixes SSR issue, related #2

Thanks for the fix, I added it in a commit because to make it work with gatsby I have to fix how it was compiling the files
https://github.com/linkstrifer/react-rough-notation/commit/7382fd06a57b4dea74d5afd6d0bb14e37f0fabd1
Also added you as a co-author.


BUG: Dark mode button is not working on About Page

The dark mode button is currently not active on the About Page. The dark mode button is also unavailable for the contact page.
##Current Behaviour
https://github.com/codervivek5/VigyBag/assets/109288720/32c391ba-4028-4bab-b818-42e6080b9dc6
##Excepted Behaviour
You can add the toggle button on the Contact Page and make it active for the About page.
Please assign me this issue under gssoc with its appropriate level .

@BTANISHA11  Hey, Please label this issue under gssoc and its appropriate level . Also Please do checkout further issues I have  been raised in the same repo.

hey, Please assign me this issue under gssoc

Hey @codervivek5 I am GSSOC contributor can you please assign this issue to me. I would be glad to work on it!


Simple division yields error

The following gives an error here:
(/ 1 1)

This is with 67b320a0e23cd03a0ab1c5c9d8b4188bcb1caca6

This seems fixed in fab96d5ef55d2c4bd297f4fde1dbc2861d6f88b9

Yay :tada:


do we need to add flat-fielding correction for MC analysis?

In the MC analysis, does anyone know if the gain factor we get from libhessio is just the PE/DC ratio (absolute pixel calibration), or a combination of that plus the flat-fielding coefficient (relative pixel calibration)?  If the former, we still need to multiply the FF coefficients before calculating hillas parameters and image cleaning to get better results.

We are not sure. @moralejo

We do not apply any additional flatfield coefficients in the MARS-based
analysis of simtelarray output. As far as I can see,thatt is also the case
in simtelarray's internal analysis. Either the flatfielding is incorporated
in the provided factors, or all pixels' gains are the same in the
simulation, rendering it unnecessary.
On Tue, 11 Dec 2018 at 14:56, Kai Brügge<EMAIL_ADDRESS>wrote:

We are not sure. @moralejo https://github.com/moralejo
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/cta-observatory/ctapipe/issues/685#issuecomment-446210628,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ANghOk1Ot2Ywl_zFdhVpDUp43CRRZrqrks5u37mGgaJpZM4Su_Km
.

--
Abelardo Moralejo Olaizola
Institut de Física d'Altes Energies
Tel : +34 931641662
Fax: +34 935811938
Avís - Aviso - Legal Notice - (LOPD) - http://legal.ifae.es
--
Avís -
Aviso - Legal Notice - (LOPD) - http://legal.ifae.es
http://legal.ifae.es/

I believe there is a gain variation between pixels in the simtelarray simulation, and it is corrected for in the dc_to_pe factor.

On Tue, 11 Dec 2018 at 15:13, Jason Watson<EMAIL_ADDRESS>wrote:

I believe there is a gain variation between pixels in the simtelarray
simulation, and it is corrected for in the dc_to_pe factor.

The gain variation must indeed be corrected, because it goes in the
pixel-wise pe to ADC counts factor. But simtelarray also simulates a
gaussian spread of the pixel-wise photodetector efficiencies , which is of
3.5% (std dev) for the LST. So in principle one could achieve a more
uniform response by applying a relative calibration of the pixels. I do not
know if simtelarray's calibration factors already include such flatfielding
(hence the correction would be not ADC to p.e. in the specific pixel, but
rather "ADC to average p.e."). This is a question for Konrad, I'll ask him.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/cta-observatory/ctapipe/issues/685#issuecomment-446216220,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ANghOhWWw40b4fM6xa1P5hK0Zbe8BNSJks5u372dgaJpZM4Su_Km
.

--
Abelardo Moralejo Olaizola
Institut de Física d'Altes Energies
Tel : +34 931641662
Fax: +34 935811938
Avís - Aviso - Legal Notice - (LOPD) - http://legal.ifae.es
--
Avís -
Aviso - Legal Notice - (LOPD) - http://legal.ifae.es
http://legal.ifae.es/

@moralejo did you receive an answer?

Hi,
in sim_telarray there is a "flatfielding" card that if set to 1 applies the flat-field equalisation to the coefficients. This card is set to 1 by default. I think this is the case for prod3 (can somebody else confirm this?)

Konrad wrote a mail on this (copied below), following discussions in a
recent LST camera MC model update call.
If I got it right, the "usual" set of conversion factors, which I think are
those we use in the various analyses of the CTA MC, include complete
flatfielding (I put the relevant sentence in bold below).  In that case, no
additional flatfielding would be needed to process the MC.
A.
Konrad Bernloehr wrote:

The gain_variation parameter with
a) flatfielding = 0: a signal amplitude r.m.s. (common to all
channels/gains on a photosensor), in addition to the
QE variation.
b) flatfielding = 1: after signal amplitudes are adjusted to
perfectly balance any QE variation (uniform flatfield),
gain_variation corresponds to the r.m.s. in flatfield
response you get (from perfectly flat illumination).
Where things started to be a bit fuzzy in my memory was if
there is also ADC sensitivity variation involved (2% assumed
from compiled-in defaults are in effect). After reviewing my
code for initialising the electronics parameters, I decided
to change the logic a bit. Instead of a perfect flatfield
having constant QE * gain, it should rather have constant
QE * gain * sensitivity.

The usual calibration coefficients    reported in the simtel files always
included complete    flatfielding - but there is a second set of
coefficients
in the data without flatfielding. So the answer depends on
which set got applied - or if you applied your own calibration.
Assuming flatfielding=1, qe_variation=0.035, gain_variation=0.03,
and fadc_var_sensitivity=0.02, you should have got a
sqrt(0.03^2+0.02^2) = 0.036 r.m.s. in relative flatfield signals
and would in future simulations only get 0.03.
With flatfielding=0, it would be sqrt(0.035^2+0.03^2+0.02^2),
both the old and the new way.

On Fri, 20 Mar 2020 at 11:45, Maximilian Nöthe<EMAIL_ADDRESS>wrote:

@moralejo https://github.com/moralejo did you receive an answer?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/cta-observatory/ctapipe/issues/685#issuecomment-601635857,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADMCCOU3T6DTSCHDHC3OUXDRINCK7ANCNFSM4EV36KTA
.

--
Abelardo Moralejo Olaizola
Institut de Física d'Altes Energies
Tel : +34 931641662
Fax: +34 935811938
Avís - Aviso - Legal Notice - (LOPD) - http://legal.ifae.es
--
Avís -
Aviso - Legal Notice - (LOPD) - http://legal.ifae.es
http://legal.ifae.es/

ok so it sounds like it's included in the multiplicative calibration factor already, so no need to do more.  I'll close this then


Different input shape of model and dataset does not matter

I use pre-trained architecture from https://keras.io/applications/ with default input shape, but my images have different dimensions. I think that prediction must fail because of wrong input shape, but nothing happens and model has started predicting.
Is it bug or Keras does any weird things behind that I don't know?

Tell me if I misunderstood
You built a model with input shape (x1, x2) and gave as input something different ? And it didn't fail ?
I already tried that out and I got issues. Didn't you use a generator and set parameters to have a resize ?

Yeah, that's exactly what I did, but how is it possible to resize smaller image to bigger one?
Does keras fill rest with zeros or something like that?

Could you show your code ? I'm not exactly sure what you did

I have already resolve it.
In ImageDataGenerator class is argument fill_mode, which does that miracle.


[DOC] Add Documentation for how to configure ISM with Data Streams

What do you want to do?

[X] Request a change to existing documentation
[X] Add new documentation
[ ] Report a technical problem with the documentation
[ ] Other

Tell us about your request.
I'm looking at switching to data streams for managing the logs. The documentation for Data Streams explains how to create a data stream and how to set up the index template for it in a good way, with examples on this page: https://opensearch.org/docs/latest/opensearch/data-streams/
It then goes on to show how to manually trigger rollovers, after which a recommendation is made to use Index State Management to handle rollovers. There is no example how to do this though and there's no information relating to data streams in the ISM documentation, which would be very useful. Then I wouldn't have to figure out by trial and error that ISM actually is aware of the data streams and can accept the data stream as index pattern.
I think it would also be useful to show a full example with rollover configuration clearly showing that this is an action in the hot phase and not a transition.

@albgus: This is a great suggestion. For additional context, do you have an Data Stream example configuration we could use for reference?

This is the policy that I've tried with:
{
    "policy": {
        "description": "Managed by Terraform for data stream: ${data_stream_name}",
        "default_state": "hot",
        "states": [
            {
                "name": "hot",
                "actions": [
                    {
                        "rollover": {
                            "min_index_age": "${rollover_age}d",
                            "min_primary_shard_size": "${rollover_size}gb"
                        },
                        "retry": {
                            "backoff": "exponential",
                            "count": 3,
                            "delay": "1m"
                        }
                    }
                ],
                "transitions": [
                    {
                    "state_name": "warm"
                    }
                ]
            },
            {
                "name": "warm",
                "actions": [
                    {
                        "force_merge": {
                            "max_num_segments": 1
                        },
                        "retry": {
                            "backoff": "exponential",
                            "count": 3,
                            "delay": "1m"
                        }
                    },
                    {
                        "read_write": {},
                        "retry": {
                            "backoff": "exponential",
                            "count": 3,
                            "delay": "1m"
                        }
                    }
                ],
                "transitions": [
                    {
                        "state_name": "delete",
                        "conditions": {
                            "min_index_age": "${index_max_age}d"
                        }
                    }
                ]
            },
            {
                "name": "delete",
                "actions": [
                    {
                        "delete": {},
                        "retry": {
                            "backoff": "exponential",
                            "count": 3,
                            "delay": "1m"
                        }
                    }
                ],
                "transitions": []
            }
        ],
        "ism_template": [
            {
                "index_patterns": [
                    "${data_stream_name}"
                ],
                "priority": 100
            }
        ]
    }
}

That said I haven't had time to actually test the rollover yet so I'm not 100% sure it's correct, but at least the data stream indices show up as managed by the policy in the web ui.

There is some documentation around auto rollover. However, this isn't specifically for the data stream case, and goes on to show how to create an index template with an alias and create indexes from that template. I believe data streams automates much of this process.
@albgus I know it's been awhile but did come up with a policy that works correctly and can possibly share as an example?


Pinning pennylane version

[ ] I have added the tests to cover my changes.
[x] I have updated the documentation and CHANGELOG accordingly.
[x] I have read the CONTRIBUTING document.

@kessler-frost, @ArunPsiog: Just saw this after opening #1864. Could you explain the rationale behind pinning the pennylane version? The current pin is indirectly putting an upper-limit on the version of numpy.


Update Korean locale

Add missing translations.

The 1.3 strings have been uploaded. Please redo the PR if you are still interested in translating.


publish fails, daemon shows "invalid name given to publish"

I don't even see the publish all in the daemon logs, so something must not be getting passed correctly.

This isn't happening anymore...not sure if one of the commits fixed it, or something else was wrong locally. Will re-open if I run across it again.


New package: TrustCAT v0.1.0

Registering package: TrustCAT
Repository: https://github.com/fadihamad94/TrustCAT
Created by: @fadihamad94
Version: v0.1.0
Commit: 6a195fb2785b7260c95257ea4770b9c9faae1d3c
Git reference: HEAD
Description: This package is the implementation of a simple and practical adaptive trust-region method for finding stationary points of nonconvex functions with L-Lipschitz Hessians and bounded optimality gap.
Release notes:

Release notes:

First version of the CAT Solver

[noblock]
My 2 cents: It's unclear what "CAT" stands for. If I dig into the papers, I see it stands for "Consistently Adaptive Trust". But then "TrustCAT" stands for "Trust Consistently Adaptive Trust"? Maybe there's a better name for the package? I don't know what that would be, I don't even know what "consistently adaptive" means anyway, but maybe something more informative? Maybe the fact that it's a solver for finding stationary points could be somehow included in the name? Regardless of the package name you chose, if it includes the "CAT" acronym, then it would be good to define that acronym in the ReadMe at least.

@briochemc Thank you for your comment.  We decided to name the package CATrustRegionMethod and we included in the package readme an explanation of the name.
We opened another pull request. Can you please close this pull request.

Thank you for your comment.  We decided to name the package CATrustRegionMethod and we included in the package readme an explanation of the name.
We opened another pull request. Can you please close this pull request.

That sounds better to me. (I'm just a commenter here, I can't close or merge PRs, but I don't think you need to do anything.)


[BACKLOG-36967] updating swt version from 4.6 to 3.122 to resolve win…

…dows11 issue

:white_check_mark: Build finished in 2m 23s
Build command:
mvn clean verify -B -e -Daudit -amd -pl assemblies/core/client

:exclamation: No tests found!
:information_source:  This is an automatic message

@srallapa I believe you need to change the assembly file in assemblies/core/client/src/assembly-common/component.xml to match your change from "swt" to "platform" in the GAV.
https://github.com/pentaho/pentaho-kettle/blob/725f9bd7f21cfdca78fb15f025a2d09cc55d7b29/assemblies/core/client/src/assembly-common/component.xml#L51


Use custom headers to render RSC / remote components

Description
The rendering logic is using the standard Accept HTTP header to drive the response type and caching used by the framework. This is not ideal for proxies and caching. See some additional information at https://github.com/lazarv/react-server/pull/49
Suggested solution
Use custom HTTP headers to drive the rendering logic and to choose the response type and framework level caching type.

use React-Server-RSC header to request an RSC payload response
use React-Server-Remote header to request an RSC delegation response
use React-Server-Standalone header to request standalone type routing logic

Existence of the above HTTP headers will drive the rendering logic.
Possible combinations are:

React-Server-RSC with an optional React-Server-Standalone
React-Server-Remote with an optional React-Server-Standalone

React-Server-RSC and React-Server-Remote can't be used in the same request!
Alternative
No response
Additional context
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

This is now superseded by using a URL pattern instead of HTTP headers to select the response type.


Fix XML escaping

Description
Six characters in a Service Reference .targets file are invalid and must be escaped. msbuild cannot load this file due to unescaped '<' characters. Once those are fixed, msbuild is unable to evaluate two conditions due to nested unescaped single-quote characters.
Customer impact
Customers will be unable to build their projects after upgrading their projects to use the latest Microsoft.Extensions.ApiDescription.Server.nupkg package.
We added new warnings and errors to this package in 3.0.0-preview8 (helping customers avoid silent failures) and would like customers to give us feedback on the improved experience.
Regression?
Yes, did not have this issue in the '3.0.0-preview7' release.
Risk
Very low.

/fyi @glennc

:up::date: to target 'release/3.0', squash previous commits, and mention #12786

we should file a separate issue to add functional tests for this to avoid this kind of thing in the future

#4914 has existed for a while ☹


documentation issue

supplement notice of installation or uninstallation  for multus issue
https://github.com/spidernet-io/spiderpool/issues/2182

Reference #2182


v1.14.1 update

Second attempt at rebasing (#290)

Lets continue the attempt on rebasing when the build and release works as expected.


[React Native] Cannot capture exception as global option shouldSendCallback not defined by default

I was following the helpful React Native integration read me and stumbled on an error when attempting to call the Raven.captureException() API:
Raven.captureException(ex, {
    extra: context
})

The error is specifically in the react-native.js plugin and the error is:

However, if I specify the shouldSendCallback when initialising Raven, the error disappears.
Raven.config(
    ...,
    { release: '...', shouldSendCallback: () => { ... }}
).install();

Is there a sensible default we can define for shouldSendCallback? Or can we document that it is a required config parameter?
Many thanks!

Dupe of #692. Patch incoming.

Thanks!


RUMM-1807 Handle App launch events

What does this PR do?
Distinguish view-less event's happening early during the app's lifetime as AppLaunch instead of just Background

Codecov Report

Merging #791 (a66f1ea) into master (1cce72d) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #791      +/-   ##
============================================
+ Coverage     88.30%   88.34%   +0.04%
- Complexity     1822     1826       +4
============================================
  Files           196      196
  Lines          6402     6433      +31
  Branches        741      743       +2
============================================
+ Hits           5653     5683      +30
- Misses          504      507       +3
+ Partials        245      243       -2

Impacted Files
Coverage Δ

.../android/rum/internal/domain/scope/RumViewScope.kt
96.03% <ø> (ø)

...n/com/datadog/android/core/internal/CoreFeature.kt
93.03% <100.00%> (+0.14%)
:arrow_up:

...droid/rum/internal/domain/scope/RumSessionScope.kt
100.00% <100.00%> (+2.06%)
:arrow_up:

...nternal/tracking/OreoFragmentLifecycleCallbacks.kt
92.16% <0.00%> (-3.92%)
:arrow_down:

.../android/error/internal/DatadogExceptionHandler.kt
93.55% <0.00%> (-3.23%)
:arrow_down:

...id/rum/internal/domain/event/RumEventSerializer.kt
91.67% <0.00%> (-2.08%)
:arrow_down:

...l/net/info/BroadcastReceiverNetworkInfoProvider.kt
77.32% <0.00%> (-2.06%)
:arrow_down:

...oid/src/main/kotlin/com/datadog/android/Datadog.kt
74.34% <0.00%> (-1.77%)
:arrow_down:

...atadog/android/core/configuration/Configuration.kt
97.45% <0.00%> (-0.73%)
:arrow_down:

...g/android/rum/internal/domain/scope/RumEventExt.kt
86.09% <0.00%> (ø)

... and 5 more


Remove constraint on pyparsing version

Codecov Report
Patch coverage: 96.42% and no project coverage change.

Comparison is base (90b4413) 86.89% compared to head (0e4747a) 86.89%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #375   +/-   ##
=======================================
  Coverage   86.89%   86.89%
=======================================
  Files         184      184
  Lines       23110    23121   +11
=======================================
+ Hits        20081    20091   +10
- Misses       3029     3030    +1

Impacted Files
Coverage Δ

unified_planning/io/pddl_reader.py
78.99% <94.73%> (+0.17%)
:arrow_up:

unified_planning/io/anml_grammar.py
100.00% <100.00%> (ø)

unified_planning/io/anml_reader.py
87.14% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

@g-gemignani now the code should work fine with both pyparsing 2 and 3.

@alvalentini yep, looks good to me. Thank you so much for the quick fix!


Calling cancel() does not close the connection/stream

I am trying to cancel a HTTP/2.0 stream (by calling its cancel() function) after downloading/reading first half of the file, but when I look at the pcap trace, I see that it keeps downloading the whole file.
Call call=client.newCall(request);
Response response = call.execute();
byte[] readBuffer = new byte[1024];
if(response.isSuccessful()){
                InputStream inputStream = response.body().byteStream();
                int totalLen=0;
                ...
                //reading the first half of the file
                ...
                call.cancel();
                inputStream.close();
                response.close();
}

after calling cancel(), both call.isCanceled() and call.isExecuted() return true.
Okhttp 3.9.0, Android 6, Nexus 5, server: nginx with http2.0 enabled

I changed the web server from nginx to apache2 and the problem still exist.
I also added debugging code to the okhttp source code and here is the function call trace when I call cancel():
RealCall.java->cancel()
RetryAndFollowUpInterceptor.java->cancel()
StreamAllocation.java->cancel()
Http2Codec.java->cancel()
Http2Stream.java->closeLater()
Http2Connection.java->writeSynResetLater() with Error code: CANCEL
Http2Writer.java->rstStream() with Error code CANCEL
and then several:
Http2Writer.java->rstStream() with error code: PROTOCOL_ERROR
Any idea how I can fix this problem?

It would help a lot if you made a reproducible test case for this.  Specifically if we test against different URLs, negotiate a different protocol then results may differ.

I got very similar problem.
My case is even simple.

Set connect/read/write timeout to a large number, like 30 seconds.
I was with emulator with wifi settings on, but my pc's network is off.
When I create a new thread to start a http call.
And then wait 1-2 seconds to cancel the call.
The thread will still run for many seconds, it seems, it would not stop the thread until the 30s connection timeout happen.

@yschimke I realized that the problem is not caused by okhttp implementation. In fact, okhttp can not fix this problem. Please take a look at this paper for more info, if you are interested.


Error after writing file and quiting nvim

Describe the bug
When I write a file and exit nvim with :wq, I get an error in the shell after nvim closes.
Steps to reproduce

Open a file with nvim in a project with a tags file (it has to be nvim, with vim I can't reproduce).
Write and close the file with :wq (without the write I can't reproduce).
The errors will be shown in the shell after nvim exited.

Share your setup

What OS and version of Vim are you using?

Ubuntu 20.04.3 LTS
NVIM v0.5.1

What version of ctags, gtags, or whatever do you have installed?

Universal Ctags 5.9.0

Are you using g:gutentags_cache_dir?

No

Post the logs
I get this error in my shell after nvim exits:
Error detected while processing DirChanged Autocommands for "*":
E475: Invalid argument: Channel doesn't exist
E475: Invalid argument: Channel doesn't exist
Error detected while processing function <SNR>143_nvim_job_exit_wrapper[1]..gutentags#ctags#on_job_exit[1]..gutentags#remove_job_by_data[2]..gutentags#remove_job:
line   22:
E171: Missing :endif%

This seems like a duplicate of #269. It has some activity, but it is not resolved.


Run a command which was passed via command line arguments

The user should be able to call the program like this:
gcron --comand="echo hello world" --pattern="* */5 * * * *"

This should run the command every 5 minutes.

Added in #5


chore: pin nodejs version to 22.4

This reverts commit 69ae688bed4b17f93801494aa16919888935c780.
Motivation

poor performance on 1.24.0-rc.0

after the revert I see gc pause time rate reduced while gossip traffic volume is the same. It's only been tested 7h on the unstable mainnet node so need more time to monitor, posting here so that we can trace back later

we should revert this again


Add register/unregister to DiscoveryClient

I would argue that register/unregister is a "registry" concern not a "discovery" concern. New interface?

Sure s-c-commons-client-registry.Registry?   I don't like that client is in the package structure in commons.

ServiceRegistry is what most people call it I guess? We can take the "client" out of the package name if you prefer, but isn't it better to be explicit about that (in case someone thinks they can use that package to implement a server)?

ServiceRegistry it is.  I was worried about having "client" in the package, just second guessing myself.

hmm, there doesn't seem to be a way to arbitrarily register services with eureka v1.  All their usage of statics limits registration to the current instance.  I saw register looking something like
public void register(ServerInstance);


Remove mima exclusion

By putting the call to makeError inside Eval.later we can avoid the mima exclusion, which simplifies the build.
This is in preparation for publishing a new version hopefully today.

Codecov Report

Merging #302 (d433bab) into main (a0ec067) will increase coverage by 0.19%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #302      +/-   ##
==========================================
+ Coverage   96.34%   96.53%   +0.19%
==========================================
  Files           8        8
  Lines        1011     1010       -1
  Branches       81       81
==========================================
+ Hits          974      975       +1
+ Misses         37       35       -2

Impacted Files
Coverage Δ

core/shared/src/main/scala/cats/parse/Parser.scala
96.43% <100.00%> (+0.23%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0ec067...d433bab. Read the comment docs.


Fix/context is missing in the arguments of subscription.NewExecutorV2Pool in the federation example

fix(example): add context.Backgrount() to the arguments of subscription.NewExecutorV2Pool
It's a regression bug introduced int 83a5ad29 of #148.

After running go get -u the federation package, it's fixed.


resources/postagger.model not found when working with the POSTagger

i get the following error when i try to use the POSTagger:
error: cannot open input model file: resources/postagger.model

I just realized i havnt installed the models!

No I think there is an another problem in the source code since although I have installed the package, I am getting the same error.

Hi,
In the installation section of hazm main page you can find simple instruction on how to download and extract resources folder.

Thanks for your response.
On Thu, Jan 2, 2020, 1:50 PM Alireza Nourian<EMAIL_ADDRESS>wrote:

Hi,
In the installation section of hazm main page http://www.sobhe.ir/hazm/
you can find simple instruction on how to download and extract resources
folder.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/sobhe/hazm/issues/25?email_source=notifications&email_token=AENFC7TP7GCZDWVI4YRKW43Q3W5YHA5CNFSM4BC6KNI2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEH6A6ZY#issuecomment-570167143,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AENFC7RWFLPGDHXOZ6D5XDLQ3W5YHANCNFSM4BC6KNIQ
.


Adopt common timeout/retry/backoff strategy for system tests.

From https://github.com/GoogleCloudPlatform/gcloud-python/pull/1609#discussion_r56220537
We have a number of sporadic system test failures (#1085, #1089, #1100, #1104) due to "eventual consistency" in the tested APIs.  We have adopted a set of ad-hoc (and obviously not 100% reliable) strategies for working around the delays involved.
The point of this issue is to  adopt a consistent policy / mechanism across all system tests for addressing delays caused by eventual consistency.
@jonparrott can you comment here, collecting your thoughts expressed elsewhere?

In python-docs-samples we're using a combination of flaky and not running flaky tests on travis (we have a jenkins instance).

#1391 is related.

I have an old branch around from #535 when I made the first stab at this.

Maybe one of the following libraries would be useful:

https://pypi.python.org/pypi/retrying
https://pypi.python.org/pypi/backoff

So now, in the systems-tests path we have retry.py.
from retry import Retry

@Retry(SomeException, tries=3, delay=30)
def method_to_retry():
    ...

I added classes to handle two other cases in #2050:

Retry until method result passes a predicate.
Retry until method's __self__ passes a predicate.

@tseaver What about this issue? And the novel failures?

I think we should create separate issues for the failures we still see, and resolve them one by one as we add backoff/retry  for them.  E.g., today's BQ failure should be its own issue, rather than reopening #1104.  Likewise todays happybase failure should be a separate issue.

@tseaver 500, 502 and 503 are just unavoidable for a general service. gcloud-node just retries them by default

@dhermes #2075 tracks the BQ failure.  #2076 tracks the Happybase one.  I assigned the first to me, and the second to you, somewhat arbitrarily.


[Docs] "Espanol" link on the docs home page not working.

Current State
after clicking on "Espanol" which is on the top right corner, we cant go to the Spanish language page of our docs.

Desired State
We should be able to go on the Spanish language page after clicking on it.

Contributor Guides and Resources

🛠 Meshery Build & Release Strategy
📚 Instructions for contributing to documentation

Meshery documentation site and source

🎨 Wireframes and designs for Meshery UI in Figma
🙋🏾🙋🏼 Questions: Layer5 Discussion Forum and Layer5 Community Slack

The 0.5 version of doc have this snippet (in github)

🇲🇽 Español

which is correct , if we visit  https://docs.meshery.io/es or https://docs.meshery.io/v0.5/es we get correct documentation
but on the serving website ,

        🇲🇽 Español

the link is broken , that means it's not it sync with correct code. I'm new to jeykll but this is the issue i found

After learning about jeykll , i tried looking for the loop of navbar so i can correct the links , but it was not in index.md nor in layout folder(i thought it available on each page so it must be applied through layout) , if someone find it , please fix it . I'm trying to look for it for past 12 hours :)

Hey @varunsaral, thanks for taking the time and looking into this, but you're looking in the wrong place😅, the header is actually an _includes file (since it is on every page). You might want to take a look at header.html that's where you'll find this.
Also, if you have any other problems you could join our slack workspace and ask there: https://join.slack.com/t/layer5io/shared_invite/zt-rgbyt4kj-6PUUyqY9SfQGRSt_oZV9yQ

hey @varunsaral, thanks for your time, you will have to edit the file https://github.com/meshery/meshery/blob/master/docs/_includes/header.html to be able to solve the issue.

Also, I just took a look, the code under  is actually useless, it's complicated for no reason at all. We could change that entire portion to just be,
{% for link in site.data.navigation %}

          {{ link.title }}

        {% endfor %}

@warunicorn19 I agree, It is very complicated. To solve this issue I initially used a flag variable, making the code more complicated (though working) 😂
{% for link in site.data.navigation %}
          {%- if link.url== 'es' -%}
            {% assign urlSliced = site.url | split: "/" %}

            {% assign pageUrl = page.url %}
            {% assign verString = "" %}
            {% assign flag = false %}
            {% comment %} get which version we are on {% endcomment %}
            {% for version in site.data.versions %}
              {% if page.url contains version.url %}
                {% assign verString = version.url %}
                {% comment %} get the sting with the version in the PAGE URL {% endcomment %}
                {% capture verString %}/{{verString}}/{% endcapture %}
                {% capture verStringEs %}{{verString}}/es/{% endcapture %}
                {% assign flag = true %}
              {% endif %}
            {% endfor %}

            {% comment %} get the new url with the 'es' on it {% endcomment %}
            {% if flag == true %}
            {%- capture newPageUrl -%}{{ pageUrl }}/es{%- endcapture -%}
            {% else %}
            {%- capture newPageUrl -%}{{ pageUrl | replace: verString, verStringEs }}{%- endcapture -%}
            {% endif %}

Hey @varunsaral, if you understood what exactly is needed to be done. would you like to submit a PR for this issue?

yeah, this makes sense as well, but not really required, I think it'd be best if we remove it. I assume you have docs running could you please check what I wrote works or not? I haven't actually tested it out😅.

yes, it does work. I just tested it @warunicorn19

Hey @varunsaral, if you understood what exactly is needed to be done. would you like to submit a PR for this issue?

Yes i understood it now , submiting a PR right away

@varunsaral Thanks for taking this up.


Set up a "Hello world" project as one app with Webpack

In this project I:

Created a new Rails app called 'hello-rails-react'.
Created a babel.config.js in the root folder.
Updated webpack.config.js to include the babel-loader.
Implemented a connection between a Ruby on Rails back-end and React front-end.

Hi, @Ismailco thanks for the review and I will make the changes. I don't understand the second change because if you refresh the page a random message is displayed as a string but not as an array.

Hi, @Ismailco thanks for the review and I will make the changes. I don't understand the second change because if you refresh the page a random message is displayed as a string but not as an array.

@Paul-js-hub, Sorry for this You're using Array.map() because the returned greeting is an array, that's totally fine. I confused this with something else. You just need to Fix the application.js and create an App component

@Ismailco, thanks for your favorable response. I have made the changes you asked for.


Offer non-interactive equivalents for interactive tutorials

Page: https://kubernetes.io/docs/tutorials/kubernetes-basics/create-cluster/cluster-interactive/
It takes ages to start the interactive session.
I think it would be better to have pure text and show the commands which you need to enter in
your local minikube.
The "Hello Minikube" page is better in this regards, since you see the commands and execute them in your local
minikube. See related issue #32753.
Story from the past: IIRC I had a look at the kubernetes docs three years ago. The Katacoda terminal was way to slow, so I stopped. Then came daily work, and I did not learn Kubernetes. Just some months ago I started again, and I am sorry that I did not start to learn Kubernetes earlier.
Related thread in #sig-docs https://kubernetes.slack.com/archives/C1J0BPD2M/p1648739540122659
And it is not stable. I was some minutes away from keyboard, now I get:

Sorry, invalid request was made

/retitle Interactive tutorial sessions slow to start
/team katacoda

I think it would be better to have pure text and show the commands which you need to enter in
your local minikube.

We could not then call that an “interactive tutorial”. I think maybe @guettli you would like to request that we add a non-interactive version of each interactive tutorial?

@sftim yes, this makes sense. So that the user can decide if he wants to use his own minikube or a minikube in the browser.

/kind feature
/retitle Offer non-interactive equivalents for interactive tutorials
/priority awaiting-more-evidence
I'd like to see some +1 reactions on this issue before we accept it - that'd create a significant extra work backlog for our 13 or so localization teams.

sftim is right, this creates a lot of work. There are already several free ways to learn Kubernetes.


DataCloneError: WebAssembly.Memory object could not be cloned.

I'm very new to Rust so please assume the worst.
Describe the bug
I'm getting WebAssembly.Memory object could not be cloned in Firefox and Chrome on the latest Main and the latest human commit for shared-memory.
separate-memory and separate-memory-transfer work as expected, presumably because they don't use wasm_bindgen::memory() which I assume cannot be cloned.
To Reproduce
I pinned wasm-bindgen to "=0.2.81" here (for both the latest Main and human commit) because otherwise it kept trying to use 0.2.83 - I blame the workspace lock file.
error:

it looks like the Rust project used to create this wasm file was linked against
version of wasm-bindgen that uses a different bindgen format than this binary:

  rust wasm file schema version: 0.2.83
     this binary schema version: 0.2.81

(I've no idea how Nix (flakes) works.) I then ran
cargo install --version 0.2.81 wasm-bindgen-cli --force
cd shared-memory
cargo build --release
wasm-bindgen ../target/wasm32-unknown-unknown/release/shared_memory.wasm --target=no-modules --out-dir=pkg
python ../server.py`

which resulted in the stacktrace at the bottom of this issue.
Expected behavior
No error.
Environment

OS name + version: Ubuntu 20.04.4 LTS (really using WSL though)
Chrome <IP_ADDRESS>
Firefox 119.0

Additional context
I found this potentially relevant SO question, but reading the generated pkg/shared_memory.js file doesn't reveal any new WebAssembly.Memory calls.
Complete stacktrace:
panicked at shared-memory/src/lib.rs:41:6:
failed to start worker 1: JsValue(DataCloneError: WebAssembly.Memory object could not be cloned.
getImports/imports.wbg.__wbg_postMessage_8a8f33d997e17e7b/<@http://localhost:8000/pkg/shared_memory.js:282:25
handleError@http://localhost:8000/pkg/shared_memory.js:201:18
getImports/imports.wbg.__wbg_postMessage_8a8f33d997e17e7b@http://localhost:8000/pkg/shared_memory.js:281:74
web_sys::features::gen_Worker::Worker::post_message::hfc0de0597810731c@http://localhost:8000/pkg/shared_memory_bg.wasm:wasm-function[138]:0x10d01
run@http://localhost:8000/pkg/shared_memory_bg.wasm:wasm-function[22]:0x5938
__exports.run@http://localhost:8000/pkg/shared_memory.js:189:10
promise callback*@http://localhost:8000/index.js:2:45
)

Stack:

getImports/imports.wbg.__wbg_new_abda76e883ba8a5f@http://localhost:8000/pkg/shared_memory.js:256:21
console_error_panic_hook::hook::h2d269cc0da8a6d49@http://localhost:8000/pkg/shared_memory_bg.wasm:wasm-function[50]:0xbcee
core::ops::function::Fn::call::h4825d0fc11fc7cfd@http://localhost:8000/pkg/shared_memory_bg.wasm:wasm-function[246]:0x1196f
std::panicking::rust_panic_with_hook::h3aa054d35a0817d7@http://localhost:8000/pkg/shared_memory_bg.wasm:wasm-function[89]:0xf3ba
std::panicking::begin_panic_handler::{{closure}}::h2f73e4cf6cd6319a@http://localhost:8000/pkg/shared_memory_bg.wasm:wasm-function[105]:0x10075
std::sys_common::backtrace::__rust_end_short_backtrace::h98ac61a6abbff7e9@http://localhost:8000/pkg/shared_memory_bg.wasm:wasm-function[241]:0x11947
rust_begin_unwind@http://localhost:8000/pkg/shared_memory_bg.wasm:wasm-function[123]:0x1088c
core::panicking::panic_fmt::h3e1dd3d08288569e@http://localhost:8000/pkg/shared_memory_bg.wasm:wasm-function[145]:0x10ee4
core::result::unwrap_failed::h8b3db0f11171b57b@http://localhost:8000/pkg/shared_memory_bg.wasm:wasm-function[113]:0x104c7
run@http://localhost:8000/pkg/shared_memory_bg.wasm:wasm-function[22]:0x5c41
__exports.run@http://localhost:8000/pkg/shared_memory.js:189:10
promise callback*@http://localhost:8000/index.js:2:45

Ah, I need to use nightly, as mentioned in the blog:
rustup override set nightly
RUSTFLAGS="-C target-feature=+atomics,+bulk-memory,+mutable-globals" cargo build --target=wasm32-unknown-unknown --release -Z build-std=panic_abort,std

After that, shared_memory.js contains
function __wbg_init_memory(imports, maybe_memory) {
    imports.wbg.memory = maybe_memory || new WebAssembly.Memory({initial:18,maximum:16384,shared:true});
}

when previously it contained
function __wbg_init_memory(imports, maybe_memory) {

}

Thanks for the report! I'll fix the wasm-bindgen version pinning and make the nightly thing clearer in the README.


Update styling for free response validator error message so it's not red on orange

Fixed via https://github.com/cosmicds/hubbleds/pull/488


gltfpack: support preserving UV sets

Currently there is (afaict) no option to preserve additional sets of UVs.
I have meshes with separate albedo and lightmap UVs which, due to the lightmapper being external, reference a texture in a separate file. Either way, even when the second UV set references a dummy 1px texture in Blender, gltfpack strips that UV set off and breaks the assets.
Please consider adding a flag to preserve UV sets, similar to the flags to preserve node hierarchy / materials / extras, etc.

when the second UV set references a dummy 1px texture in Blender, gltfpack strips that UV set off and breaks the assets.

This should not be the case. Feel free to provide a reproduction for this. gltfpack will preserve all UV sets that are referenced by textures.

Please consider adding a flag

If you use the latest pre-release gltfpack (any recent build from https://github.com/zeux/meshoptimizer/actions), you can specify -kv to keep unused vertex attributes. Note that for this to work with UV coordinates, you need to additionally specify -vtf - by default, gltfpack uses KHR_texture_transform extension to store UV transform required for quantization, and without a texture bound there is nowhere to save this transform.

Sorry to clarify, no reference to a texture exists in the .glb file, since blender fails to correctly export such a material despite it being using in the shader explicitly, so gltfpack is working correctly there. I will take a look at using -kv with a more recent build.

Ah yeah, that makes sense. FWIW the flag was added in https://github.com/zeux/meshoptimizer/pull/719.


Add a d3d11 wrapper

Bindings to d3d11 (including the Video API) and the structs/enums/constants.
I tested it with a small demo application with a msvc rust build. (MinGW needs additional libraries?)
NOTE: Requires changes to the interface macro RIDL! and https://github.com/retep998/winapi-rs/pull/164 for building.

Temporary workaround for an univariant enum(https://github.com/rust-lang/rust/issues/10292)
https://github.com/msiglreith/winapi-rs/blob/8210ef6df600abe9f77d65aa9c2b9e5697dbe383/src/d3d11.rs#L1263

Some of the flags are wrapped in enums. Should I change them to pub const for easier use?

Thanks! Reverted the version change and rebased onto master. Building should be successful.

Please use #[repr(i32)] for the enums.

Thanks for reviewing.

Fixed EOF newline
Used the new ENUM! and FLAGS! macros (at some places I had to use .0)
Added some enum fields and structs from the latest Win10 SDK (Direct3D 11.3)


Add standalone pom

To compile and run the project from command line, I suggest to add a standalone pom file similar to the one found in the examples project.
With this, I can compile with:
./mvnw clean package --file planetiler-custommap/standalone.pom.xml

And I can run with:
java -cp planetiler-custommap/target/*-with-deps.jar com.onthegomap.planetiler.custommap.ConfiguredMapMain --schema=planetiler-custommap/samples/owg_simple.yml --download --mbtiles=data/output.mbtiles

@ZeLonewolf @msbarry

@wipfli The way I've been doing this so far is through the planetiler-dist package. It's a simple package that just depends on each of the other ones:
https://github.com/onthegomap/planetiler/blob/422c6c0fcb56ee7e85b38a166155eb7599697949/planetiler-dist/pom.xml#L24-L40
And a main class that figures out which main class to run based on the first argument supplied:
https://github.com/onthegomap/planetiler/blob/422c6c0fcb56ee7e85b38a166155eb7599697949/planetiler-dist/src/main/java/com/onthegomap/planetiler/Main.java#L21-L51
That package is used to build the docker container and runnable jar file.  @ZeLonewolf hooked up the custommap package into that in this commit: https://github.com/onthegomap/planetiler/pull/160/commits/562046acf15b3bd76553443da8f4026e96d72fa1
So now you can just run
./scripts/build.sh
java -jar planetiler-dist/target/*-with-deps.jar generate-custom <rest of args...>


Ambiguous use of 'getString()'

Hi,
with version 2.1.0 I am unable to use the framework as for example
jsonDecoder["MyKey"].getString()
fails, as there is one getString() that throws and one that returns an optional.
EDIT: This is also true for getInt() etc.
Best regards

Having the same error

I solved the issue and submittied a pull request, so there may be a quick fix for that :)

Thanks for the report and PR. I ended up refactor the library to be simpler and much cleaner imho. Version 3.0.0, let me know if you have any issues or concerns.


Vessel initialization fails because of division by zero (m(t=0)=0 is the default)

Reported by mwetter on 13 Jan 2009 00:15 UTC
The newly added test model
Modelica_Fluid.Test.TestComponents.Vessels.TestInitialization
fails with
Error: Singular inconsistent scalar system for der(vol1.medium.u) = (der(vol1.m)*vol1.medium.u-der(vol1.U))/( -vol1.m) = -1.85962e+007/-0
The reason is that it assumes a fixed default value for vol1.m(start=0).
This model uses default parameters for the volume initialization and therefore we should fix the problem.
Changing in Modelica_Fluid.Vessels.Volume the code snippet
extends Modelica_Fluid.Vessels.BaseClasses.PartialLumpedVessel(
final fluidVolume = V,
heatTransfer(surfaceAreas={4*pi*(3/4*V/pi)^(2/3)}));
to
extends Modelica_Fluid.Vessels.BaseClasses.PartialLumpedVessel(
final fluidVolume = V,
m(start=V*rho0, fixed=false),
heatTransfer(surfaceAreas={4*pi*(3/4*V/pi)^(2/3)}));
protected
parameter Medium.ThermodynamicState sta0 = Medium.setState_pTX(T=T_start,
p=p_start, X=X_start[1:Medium.nXi]);
parameter Modelica.SIunits.Density rho0=Medium.density(sta0)
"Density, used to compute fluid mass";
fixes the division by zero.
Is this the correct place to provide the start value, or is there a better solution? I would prefer to set the start value at a sub class, but the parameter V is only known at this level of the class hierarchy.

Migrated-From: https://trac.modelica.org/Modelica/ticket/321

Comment by fcasella on 13 Jan 2009 00:42 UTC
The root cause of this problem is that the SimpleAir medium, which extends PartialSimpleIdealGasMedium, does not set p as preferred state, so Dymola selects m,T as states instead of p,T, and then m is uninitialized.
partial package PartialSimpleIdealGasMedium
  ...
  redeclare replaceable model extends BaseProperties(
            T(stateSelect=StateSelect.prefer))

I guess this is a bug that should be fixed in MSL 3.0.1...

Comment by dietmarw on 13 Jan 2009 07:38 UTC
depends on #m138.

Comment by otter on 13 Jan 2009 07:54 UTC
In several media the stateSelect.prefer is wrongly set. Fixed this in e23315906346073a269a937131fd10a224c8dc69:

Media.Interfaces.PartialSimpleMedium
(stateSelect.prefer on p + stateSelect.default if preferredMediumState

false)

Media.Interfaces.PartialSimpleIdealGasMedium
(stateSelect.prefer on p + stateSelect.default if preferredMediumState

false)

Media.Incompressible.TableBased
(stateSelect.prefer on p)

Comment by hubertus on 13 Jan 2009 08:39 UTC

Media.Incompressible.TableBased
(stateSelect.prefer on p) is wrong, p is not a stated for incompressible Media. This might work, but has good chances to mess up state selection so I will revert it.

Comment by hubertus on 13 Jan 2009 08:44 UTC
Fixed stateSelect attribute on p for Media.Incompressible.TableBased
Another comment: SimpleAir (and many other media) could potentially also be used as an incompressible medium, in that case p should have stateSelect=default. This issue will be addressed more systematically in Modelica.Media 3.1

Comment by hubertus on 13 Jan 2009 08:45 UTC
Replying to [comment:5 hubertus]:

Fixed stateSelect attribute on p for Media.Incompressible.TableBased
Another comment: SimpleAir (and many other media) could potentially also be used as an incompressible medium, in that case p should have stateSelect=default. This issue will be addressed more systematically in Modelica.Media 3.1
Missing revision added: fixed in ccd8054973fa48cb45bc9258d52c9620ccff3866

Comment by otter on 13 Jan 2009 08:57 UTC
If p is not a state in TableBased, then there are fichy things:

Modelica.Media.Incompressible.Common.BaseProps_Tpoly
states that the ThermodynamicState is "p" and "T".

ThermoStates = Choices.IndependentVariables.pT

This seems to be contradictory.

Comment by hubertus on 13 Jan 2009 12:11 UTC
Proposed solution: add IndependentVariables.T to enumeration and use that in incompressible seems to be a good compromise. That is how I handle the situation in 3.1 development.

Modified by dietmarw on 22 Jan 2009 16:58 UTC

Modified by rfranke on 25 Jan 2009 10:59 UTC

Comment by fcasella on 28 Jan 2009 15:07 UTC
Fails with Dymola 7.1, works with Dymola 7.2. There is interaction with Fluid. Will have to be reconsidered with the new Media library

Comment by msielemann on 23 Mar 2010 10:47 UTC
moved from https://trac.modelica.org/Modelica_Fluid/ticket/63

Comment by hubertus on 23 Aug 2010 23:13 UTC
preferredMediumState is true for SImpleAir now, so it should work.

Modified by dietmarw on 24 Aug 2010 06:27 UTC


Psec 1654 refactor log groups

There are no changes to the "aws_scanner_test_config.ini" at the root level. Don't [logs] config parameters need refactoring too?


Junit tests for split

@abellogin this is what's left for a 0.2 release. Any thoughts on when/if you'll have time for this?

I'd say one or two weeks at most. I'll give it high priority.
Thanks for pointing this out!

:+1:


Add notebook extension for automatically adding imports to first cell

I made a notebook extension that automatically adds lazy imports to the top cell as they're imported:

How to use it:

Install pyforest from this branch: pip install git+https://github.com/valtron/pyforest.git@nbextension
jupyter nbextension install --py pyforest
jupyter nbextension enable pyforest --py
Run jupyter notebook and import some stuff

The implementation is hacky (this is my first notebook extension and documentation is lacking) but this is a proof-of-concept anyway.

Wow, first of all, thank you for your contribution! It looks really nice and is a great improvement of pyforest!
Does the notebook extension also work for JupyterLab? Or what would be necessary to also make it work in Jupyter Lab?
It would be great to have support for both Jupyter Notebook and Jupyter Lab.

Glad you like it!
I added a labextension. But I'm still trying to figure out a convenient way for users to install it. (I've been using jupyter labextension install . from inside the project dir.)

Done, and added installation instructions to the README.

It's now using an "invisible" widget instead of the window.update_imports_cell hack. There's still a few major things I need to do:

setup.py is from the widget cookiecutter, but it doesn't handle building the nbextension during install
the widget isn't invisible in ipython
delimit imports on both sides

What's the status of this? Looks very useful in the demo, at least. :)

@henryiii All the major parts are finished; I never did figure out how to not show the widget in IPython, though:


Variational Inference Design

Here is to discuss about the design concerning variational inference methods.
So far in AugmentedGaussianProcesses.jl things are done this way:

There are two functions ∇E_μ and ∇E_Σ which return the gradient of the expected log likelihood given mu and Sigma (the second one returns an arrays as usually you don't need the covariance terms of Sigma).
Then the gradient given the ELBO is actually given the natural gradient because there is the relationship nat. grad. of ELBO given natural parameters (eta_1 (Sigma^-1 mu), eta_2 (-0.5Sigma^-1)) is equal to normal grad. of ELBO given normal parameters (mu, Sigma).

With the augmentation procedure it's possible to get analytical gradients and set the gradient to 0 and it becomes a coordinate ascent update (or a partial one with a learning rate for the stochastic case)
Without it, I just use a natural grad. ascent scheme.

Then natural parameters are mapped back to normal parameters.

Note that for the non-analytic case and for 1-D likelihood (needing only one GP), one can use the Opper and Archambeau (2009) equality :
grad_mu = expec[dlogp/df]
grad_sig = 0.5 expec[d^2logp/d^2f]


WDK moved to Finos Github organization

Update Maven coordinates (group id changed)
Update URLs
Also drop an outdated section in CONTRIBUTING.md

Let's wait for the repository transfer to merge it though

The transfer has been done, I merge this PR.


ikea tradfri dimmer

My tradfri dimmer worked fine for about a week, but it stopped working yesterday.
I tried reconnecting it, but after is is connected again I get an error like this:
zigbee2mqtt:error 2018-12-14 12:55:45 Failed to configure Zigbee Dimmer WZ 0x00XXXXX.
I also changed the battery.
I don't know what else I can do. Any suggestions welcome!

I deleted the related lines in the database.db file and readded the device again.
It seems to work again. But I got this message
zigbee2mqtt:warn 2018-12-14 13:52:19 No converter available for 'ICTC-G-1' with cid 'genLevelCtrl', type 'cmdMoveWithOnOff' and data '{"cid":"genLevelCtrl","data":{"movemode":0,"rate":70}}'
zigbee2mqtt:warn 2018-12-14 13:52:19 Please see: https://github.com/Koenkk/zigbee2mqtt/wiki/How-to-support-new-devices.
This is a known device. So why do I get "No converter available?"
Also I got this messages for my CC2530 Routers, but the work fine (at leat I think they do)


Update main.tf

project - (Required) The project id of the target project. This is not inferred from the provider. https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/google_project_iam#project Cloud run service name change--Resource name must use only lowercase letters, numbers and '-'. Must begin with a letter and cannot end with a '-'. Maximum length is 63 characters

It looks like the issue with the name attribute has already been resolved in another PR.


How to deploy both Container and Microfrontend for production?

Hey I clone the microfronend and container app and now i am thinking of deploying it and as it is integrated on the run time how can i deploy both the app into production?

Hi Amish,
For the production mode, you can do it in three steps:

Publish the micro frontend app to be a NPM package.
Install the package into the container app.
The container app  loads the package from the local node module.

Thanks,
Jennifer

hey one more thing I am adding two microfrontends but one render and one does not.how can I add more than one micro frontend

Thanks GOT it works great 👍🏻

Thanks GOT it works great 👍🏻


"Configure Do Not Disturb" menu doesn't seem to provide value

Testing #202924
The "Configure Do Not Disturb" menu seems to contain a fixed number of entries followed by a "More..." entry. I'm not a huge fan of this because it is ordered alphabetically, I believe, and that makes its utility limited. I'm likely to always click more since I probably have more extensions than are listed and the chance of the one I want to configure being in the top X is small. If the list were sorted by "recently sent a notification", maybe that would make it more useful. But I would probably just prefer the cleaner single entry approach of "Configure extension notifications..."

Not sure on this one...
I think the jump from bottom right corner to quick pick is always brutal because its totally not in-context. We often hear this feedback when people click on the status bar and do not realise that quick pick has opened as a result.
I somewhat like the idea of sorting the filters by recency, I would even argue to put the most recent one to the bottom to make it appear close to the mouse. I wonder if people would actually understand this or if people would think the list is always random.
The current limit is to show 10 extensions at max.

I will leave it as is.

I think the jump from bottom right corner to quick pick is always brutal because its totally not in-context.

Yea that makes sense. Though, I would argue that this is more of a configuration step that you do for all your extension at once. If you were doing this in response to a notification, the gear on that notification is the nicer approach.
I feel like there are a lot of cases where we use the quick pick as a somewhat modal form. Should we explore UX of the quick pick that functions that way? e.g. A centered view with dimmed background like custom dialogs?
We would still make it super keyboard friendly but give some focus to it and room to add context.


[SPARK-10034][SQL] add regression test for Sort on Aggregate

Before #8371, there was a bug for Sort on Aggregate that we can't use aggregate expressions named _aggOrdering and can't use more than one ordering expressions which contains aggregate functions. The reason of this bug is that: The aggregate expression in SortOrder never get resolved, we alias it with _aggOrdering and call toAttribute which gives us an UnresolvedAttribute. So actually we are referencing aggregate expression by name, not by exprId like we thought. And if there is already an aggregate expression named _aggOrdering or there are more than one ordering expressions having aggregate functions, we will have conflict names and can't search by name.
However, after #8371 got merged, the SortOrders are guaranteed to be resolved and we are always referencing aggregate expression by exprId. The Bug doesn't exist anymore and this PR add regression tests for it.

cc @marmbrus

Merged build triggered.

Merged build started.

Test build #40996 has started for   PR 8231 at commit c660a7b.

Test build #40996 has finished for   PR 8231 at commit c660a7b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40996/
Test PASSed.

Merged build triggered.

Merged build started.

Test build #41306 has started for   PR 8231 at commit f2fdfac.

Test build #41306 has finished for   PR 8231 at commit f2fdfac.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41306/
Test PASSed.

The issue has been fixed by https://github.com/apache/spark/pull/8371, so this PR only added the regression test.
cc @marmbrus

Merged build triggered.

Merged build started.

Test build #41532 has started for   PR 8231 at commit 36c11c6.

Test build #41532 has finished for   PR 8231 at commit 36c11c6.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41532/
Test PASSed.

Merged build finished. Test PASSed.

@cloud-fan could you update the title of this PR to mention that it adds regression tests only? @marmbrus does this LGTY?

_aggOrdering works, but thats not terribly interesting to test.  After my PR there is likely a different alias that will cause problems.  Either way, an optimal solution would add a field to Attribute that prevents it from being resolved by name.  We can set this to true in artificially created aliases.

Merged build triggered.

Merged build started.

Test build #41906 has started for   PR 8231 at commit 845b161.

Hi @marmbrus @andrewor14 , I have updated the description and title of this PR, to explain what was the problem before and why it disappeared. Is this LGTY?
@marmbrus , I think we don't need to add a field to Attribute anymore as now we only reference pushed down aggregate expressions by exprId, not by name.

Test build #41906 has finished for   PR 8231 at commit 845b161.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41906/
Test PASSed.

I am fairly confident that given enough time, we could find another case where you can reference an artificial name and cause analysis to fail.  We can merge this test though.


UI Progress bar not completing correctly

Java Version and Operating System: Ubuntu 18.04 Oracle Java 1.8.0_171
Reproduce the Error: Buying things on the grand exchange will sometimes cause this issue in which the progress bar is not completed.
This is what I'm talking about:

I'm not exactly sure how to reproduce this as it's intermittent and sometimes it just works correctly

Duplicate (?) of #2341, assuming this is still valid after the UI update.


#15: Add storage.batch.Batch

Step #2 in https://github.com/GoogleCloudPlatform/gcloud-python/issues/15#issuecomment-74151347

Changes Unknown when pulling 5fed4d24a81826c40d7fa85d987b7890ef0e0747 on tseaver:15-add_storage_batch into ** on GoogleCloudPlatform:master**.

@craigcitro, @dhermes I'm willing to do the work to vendor in and use the apitools batch module, if Craig doesn't think it will have a PyPI release soon.  I can also work on getting it up-to-speed in terms of test coverage and Py3k straddling in the canonical repository, if that would help.

Should I review this or rely on the vendored in code?

@dhermes we don't have a vendored-in version of that module yet.  My earlier question was whether we should go ahead and vendor that code in, given that it has no coverage and does not straddle Py3k yet.
The amount of code in the new storage/batch.py module which would be replaced if we chose to vendor the apitools module is relatively small (135 out of 544 lines):

The MIMEApplicationHTTP class and its tests

The bits of `Batch.finish()' which build, send, and process the response for the multipart request and corresponding tests.

Coverage remained the same at 100.0% when pulling ae0e9cf9457dfd607e1a98208e07a39860721a37 on tseaver:15-add_storage_batch into 8e68a20cce2306f055557362b0c4a34909a36d1e on GoogleCloudPlatform:master.

Coverage remained the same at 100.0% when pulling 6261272eb95e7844332c697394283fdbebbf2223 on tseaver:15-add_storage_batch into 8e68a20cce2306f055557362b0c4a34909a36d1e on GoogleCloudPlatform:master.

Coverage remained the same at 100.0% when pulling af2a3825e2ab965dd6f865587ff3e46b3664b9f0 on tseaver:15-add_storage_batch into 8e68a20cce2306f055557362b0c4a34909a36d1e on GoogleCloudPlatform:master.

@dhermes PTAL.
Rebased on top of master, squashing all previous commits;  then implemented subclassing per our discussion today.

one quick note: @dhermes was asking about batch+upload. at least according to the docs, this is not supported:
https://cloud.google.com/storage/docs/json_api/v1/how-tos/batch
(last line in "overview")

RE: https://github.com/GoogleCloudPlatform/gcloud-python/pull/654#issuecomment-74552171
@craigcitro can we help get apitools:

In PyPI
Supporting Py3
Merging upstream changes from places like gsutil

replying to myself for posterity: i believe neither uploads nor downloads work in a batch.

@dhermes yes! so here's the current apitools plan:

i'm working on merging the gsutil fork today
once i do that, i'm going to submit to pypi
after that, help getting it py3 ready would be AWESOME
even right now, py3 support for protorpc would be super

For posterity (RE: Craig's comment):

Note: Currently, Google Cloud Storage does not support batch operations for
media, either for upload or download.

Coverage remained the same at 100.0% when pulling de6fd4806d2f4fe939440bddbd18b073ed4c4115 on tseaver:15-add_storage_batch into 808c38b59556b03efce73ab7ed3028c0ae7f5a63 on GoogleCloudPlatform:master.

I think everything looks good except removing that unused sys import.
LGTM

@craigcitro Can we start a new issue to discuss apitools / protorpc? Should the issue be here or in one (or both) of those repos?

@dhermes yeah, new issue wherever sgtm. maybe a "py3 support" issue in each of protorpc/apitools, and an issue here for "better apitools dependency" blocked by those two?

Coverage remained the same at 100.0% when pulling c828bda0dd8d21a680090811575e4467a787582f on tseaver:15-add_storage_batch into d43c4a0b24b45d8c6a2a12373e6dff3ad884b915 on GoogleCloudPlatform:master.

@tseaver We discussed using the apitools batch support when this went in. We should discuss if / how that's possible (in light of #811).


fixed charts again - comparison chart was consuming api wrong

changed the construction of the comparison data to use the new format where the data is an array of arrays rather than an array of objects. changes are pretty straight forward, everything that was a 'y' is now '[1]' and everything that was 'name' is now '[0]' on the data elements of each chart data.

:eyes:

:+1: merging then tagging. new release. :)


AxiosError: unable to verify the first certificate

how can i fix it?

This is likely an issue with your local network, or it could be censorship from your ISP.  Is https://translate.google.com accessible and does it show HTTPS errors?  If google.com isn't accessible you can change the top level domain(tld), google.[tld], by setting the tld in the options to whatever your countries tld is.


Fix tip spacing on api keys article

Description of the change: Fixes spacing on two of the tips in this article
Reason for the change: The spacing was off due to how the md was written
Link to original source: https://sendgrid.com/docs/ui/account-and-settings/api-keys/

Hello @katieporter,Thanks again for the PR! It's HACKTOBERFEST! We want to show our appreciation by sending                                              you some special Hacktoberfest swag. If you have not already, could you please fill out                                              this form so we can send it to you? Thanks!                                             Team SendGrid DX

Hello @katieporter,Thanks again for the PR!                                         You have earned 9 out of the 5 points needed to receive glorious SendGrid Hacktoberfest swag.                                         Please take a moment to checkout this link to find more issues to get you past the required threshold or to simply continue the celebration.                                         Also, please be sure you have officially registered with us here by November 1, 2018 to qualify.                                         If you have any questions you can email us at<EMAIL_ADDRESS>                                        Thank you and Happy Hacktobering!                                         Team SendGrid


Unknown variable _global in webapis-media-query.js

dist/webapis-media-query.js & dist/webapis-notification.js. How are those supposed to be embedded? When I just load them, webpack complains that _global is unknown. Or is it just an error in the file and it should read global?
webapis-media-query.js

--
webapis-notification.js

@sod , it should be a mistake, I will fix it.


docs(cluster): update docs for clusters

hello

@wuhuizuo: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

debug/prow-call-nested-jenkins-job
5aea9ebf202d7a2ac5fa628047ab569d211b19f0
link
true
/test prow-call-nested-jenkins-job

Full PR test history.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wuhuizuo: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

debug/prow-call-nested-jenkins-job
5aea9ebf202d7a2ac5fa628047ab569d211b19f0
link
true
/test prow-call-nested-jenkins-job

debug/prow-call-jenkins
5aea9ebf202d7a2ac5fa628047ab569d211b19f0
link
true
/test prow-call-jenkins

Full PR test history.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Title
LGTM timeline

Agreed by wuhuizuo at 2023-01-01


gateway-api: completely decouple template from code for managed-by label

Please provide a description of this PR:
Follow-up on #43067 - this is a simpler version, now entirely independent of the templates. We simply add the managed-by label after generating the resources, directly in ApplyTemplate(). Sorry for the noise- I came up with this one only after the previous PR was already merged.

@dgn: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
1d50efc60974d0a7a278533232797fa28f1d7494
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dgn: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-distroless_istio
2d2c3df6c56c2ed7e9b6826482aacdab7151d855
link
unknown
/test integ-distroless

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest