Fix test/recipes/80-test_ca.t to skip_all properly in a subtest

It's perfectlt ok to 'plan skip_all' in a subtest, but in that case,
it must really be inside the subtest.
Fixes #13330

Works for me, thanks!

24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set.  Please review the updates and set the label manually.

Merged
914079d1c33cd775f15801663c36ee31c66554fa Fix test/recipes/80-test_ca.t to skip_all properly in a subtest


skipSx should update shouldForwardProps

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Summary 💡
The skipSx doesn't work as expected when shouldForwardProp default mechanism is overwritten and does not include 'sx' directly
shouldForwardProp: (prop) => !["isEven"].includes(prop as string),
skipSx: true

This will send sx to the underlying component
Examples 🌈
I made a code sandbox using the latest released material
https://codesandbox.io/s/goofy-phoebe-xc99x
Motivation 🔦
making a custom component that only changes in CSS layer duo to props is a common practice
also, sx seems to be a little bit slow, and skipping it may gain some performance tips
so because we are working mostly with the Mui component and they pass the props to the underling dom node, it makes sense to have it as a core feature of the material

I seared on skipSx tags in the issue list and could not find an open issue, so posted a new one.

@mnajdova correct me if I'm wrong, but I think it works as it's supposed to. skipSx does not evaluate the sx prop in a component but does not control whether it's passed to the underlying components.
I can imagine a use case where you don't want to use the sx implementation provided by styled but still propagate the prop to the underlying component.
If you don't want to ignore the sx completely, set skipSx to true and add sx to the list of excluded props in shouldForwardProp.

Hi @michaldudak
My understanding was similarly the same, but there is an issue with this mindset
  shouldForwardProp: (prop) => !["isEven"].includes(prop as string),
  skipSx: true

this should not apply the sx but it does!
could you take a look at an example https://codesandbox.io/s/goofy-phoebe-xc99x

This is expected. In this example the sx prop is not handled by the styled wrapper, but by Typography itself. Try wrapping a host component, such as <p> in styled (styled('p', {) instead of Typography to see that the sx prop has no effect if skipSx is set to true.

That's okay, I know it prevents the sx to go deeper from the created component (styled one)
But I believe differences happen to exist because of our expectations of shouldForwardProp and skipSx priority, for me skipSx is more prior to shouldForwardProps, and vice versa
Anyway, I post it as a feature request, not a bug, and the discussion was exactly what I was looking for.

It would be a breaking change, though, so we could think about it for the v6 release.


Get-RSCVsphereVm Fails to Find Some VMs Using Name

Description:
I noticed that Get-RSCVsphereVm -Name 'Example VM Name' was not finding the VM in question. After manually getting the Object ID from RSC I was able to get the VM information using Get-RSCVsphereVm -Id 'Example ID' . When trying to send the Name back to the cmdlet I received the below error.

Output:

Raw Error Text:
One or more errors occurred. (Could not serialize variables : System.ArgumentException: Object serialized to Array. JObject instance expected.    at Newtonsoft.Json.Linq.JObject.FromObject(Object o, JsonSerializer jsonSerializer) at RubrikSecurityCloud.OperationVariableSet.AsJson(IRscLogger logger) in /Users/guirava/src/sdmain/polaris/src/rubrik/clients/sdks/rubrik-powershell-sdk/rubrik-powershell-sdk/RubrikSecurityCloud/RubrikSecurityCloud.CommonSerializer) at/OperationVariableSet.cs:line 86 at                                                                                /OperationVariableSet.cs:line 86 at RubrikSecurityCloud.NetSDK.Client.RscGraphQLClient.InvokeGenericCallAsync[T](GraphQLRequest request, OperationVariableSet variables, IRscLogger logger, Dictionary`2 metricsTags) in /Users/guirava/src/sdmain/polaris/src/rubrik/clients/sdks/rubrik-powershell-sdk/rubrik-powershell-sdk/RubrikSecurityCloud/RubrikSecurityCloud.Client/RscGraphQLClientGenericCall.cs:line 137)

Additionally, Get-RscVsphereVm | Where-Object { $.Name -eq $vmFromID.Name }_  does not return any results.

Hi @therealgill
We did pick up on this issue internally earlier this week, and I am happy to report that this issue has been addressed and the fix will be included in the next increment of the beta release.
Regards
Rynardt

Issue resolved in 0.8.0


ShareJS not defined in Meteor 1.6

I get the following error when I try to use ShareJS in Meteor 1.6.
W20171204-11:23:01.111(-8)? (STDERR) /Users/iwojtowicz/.meteor/packages/meteor-tool/.<IP_ADDRESS>n9mub++os.osx.x86_64+web.browser+web.cordova/mt-os.osx.x86_64/dev_bundle/server-lib/node_modules/fibers/future.js:280
W20171204-11:23:01.112(-8)? (STDERR) 						throw(ex);
W20171204-11:23:01.112(-8)? (STDERR) 						^
W20171204-11:23:01.112(-8)? (STDERR)
W20171204-11:23:01.112(-8)? (STDERR) ReferenceError: ShareJS is not defined
W20171204-11:23:01.112(-8)? (STDERR)     at sharejs-server.js (packages/mizzao:sharejs/sharejs-server.js:8:24)
W20171204-11:23:01.113(-8)? (STDERR)     at fileEvaluate (packages/modules-runtime.js:343:9)
W20171204-11:23:01.113(-8)? (STDERR)     at require (packages/modules-runtime.js:238:16)
W20171204-11:23:01.113(-8)? (STDERR)     at /Users/iwojtowicz/Documents/Projects/Misc/Design Cards/Source Code/.meteor/local/build/programs/server/packages/mizzao_sharejs.js:126:15
W20171204-11:23:01.113(-8)? (STDERR)     at /Users/iwojtowicz/Documents/Projects/Misc/Design Cards/Source Code/.meteor/local/build/programs/server/packages/mizzao_sharejs.js:132:3
W20171204-11:23:01.114(-8)? (STDERR)     at infos.forEach.info (/Users/iwojtowicz/Documents/Projects/Misc/Design Cards/Source Code/.meteor/local/build/programs/server/boot.js:414:13)
W20171204-11:23:01.114(-8)? (STDERR)     at Array.forEach (<anonymous>)
W20171204-11:23:01.114(-8)? (STDERR)     at /Users/iwojtowicz/Documents/Projects/Misc/Design Cards/Source Code/.meteor/local/build/programs/server/boot.js:413:9
W20171204-11:23:01.114(-8)? (STDERR)     at /Users/iwojtowicz/Documents/Projects/Misc/Design Cards/Source Code/.meteor/local/build/programs/server/boot.js:463:5
W20171204-11:23:01.114(-8)? (STDERR)     at Function.run (/Users/iwojtowicz/Documents/Projects/Misc/Design Cards/Source Code/.meteor/local/build/programs/server/profile.js:510:12)

I installed it with meteor add mizzao:sharejs
The demo app from the repo works fine, but breaks if I run meteor update.

You just need to add a line of JavaScript:
import { ShareJS } from 'meteor/mizzao:sharejs'

I'm getting the same error. That line doesn't fix it either.

Where did you add it? You need to make sure it's getting executed before ShareJS gets used. Do you get a different error?
I haven't tried the demo in a while, but I can confirm that this package works (in my own project) with Meteor 1.6.

I added it to the packages and I haven't added it to any templates. It's the same error.
W20171215-12:26:26.527(-8)? (STDERR) /home/.meteor/packages/meteor-tool/.1.6.0_1.ff6ofd.xp1u++os.linux.x86_64+web.browser+web.cordova/mt-os.linux.x86_64/dev_bundle/server-lib/node_modules/fibers/future.js:280 W20171215-12:26:26.529(-8)? (STDERR) 						throw(ex); W20171215-12:26:26.529(-8)? (STDERR) 						^ W20171215-12:26:26.530(-8)? (STDERR)  W20171215-12:26:26.530(-8)? (STDERR) ReferenceError: ShareJS is not defined W20171215-12:26:26.531(-8)? (STDERR)     at sharejs-server.js (packages/mizzao:sharejs/sharejs-server.js:8:24) W20171215-12:26:26.531(-8)? (STDERR)     at fileEvaluate (packages/modules-runtime.js:343:9) W20171215-12:26:26.532(-8)? (STDERR)     at require (packages/modules-runtime.js:238:16) W20171215-12:26:26.533(-8)? (STDERR)     at /media/files/application/election/.meteor/local/build/programs/server/packages/mizzao_sharejs.js:126:15 W20171215-12:26:26.533(-8)? (STDERR)     at /media/files/application/election/.meteor/local/build/programs/server/packages/mizzao_sharejs.js:132:3 W20171215-12:26:26.534(-8)? (STDERR)     at infos.forEach.info (/media/files/application/election/.meteor/local/build/programs/server/boot.js:414:13) W20171215-12:26:26.534(-8)? (STDERR)     at Array.forEach (<anonymous>) W20171215-12:26:26.535(-8)? (STDERR)     at /media/files/application/election/.meteor/local/build/programs/server/boot.js:413:9 W20171215-12:26:26.536(-8)? (STDERR)     at /media/files/application/election/.meteor/local/build/programs/server/boot.js:463:5 W20171215-12:26:26.536(-8)? (STDERR)     at Function.run (/media/files/application/election/.meteor/local/build/programs/server/profile.js:510:12)

Oops, sorry, I'm mixing up version upgrades.  You're right, this is broken.  PR #94 fixes this issue.  You can also replace package mizzao:sharejs with edemaine:sharejs in the meanwhile (which also includes PR #93).

That's what I ended up doing to get this working.
Nice work on the time traveller conference, by the way. Legendary.

@iwoj Did you attend the time traveler convention recently? ;-) It was awesome participating!

I go back from time to time.

is this being fix ?

Great! I removed mizzao:sharejs and used edemaine:sharejs, now it works!


fix: google_secret_manager_secret_iam_binding.binding for_each

Fixed a warning:
╷
│ Error: Invalid for_each argument
│
│   on ../modules/secret-manager/main.tf line 101, in resource "google_secret_manager_secret_iam_binding" "binding":
│  101:   for_each  = { for secret in google_secret_manager_secret.secrets : secret.name => secret if length(var.secret_accessors_list) > 0 }
│     ├────────────────
│     │ google_secret_manager_secret.secrets is object with 1 attribute "hogehoge"
│     │ var.secret_accessors_list is list of string with 1 element
│
│ The "for_each" map includes keys derived from resource attributes that cannot be determined until apply, and so Terraform cannot determine the full set of keys that will identify the instances of this resource.
│
│ When working with unknown values in for_each, it's better to define the map keys statically in your configuration and place apply-time results only in the map values.
│
│ Alternatively, you could use the -target planning option to first apply only the resources that the for_each value depends on, and then apply a second time to fully converge.

I signed the CLA.

/gcbrun


fix(publish): regex doesn't match double digit releases

regex in craft.yml doesn't match releases with double digits e.g 0.10.0 which would replace the aar name
#skip-changelog

also I feel you :D https://github.com/getsentry/sentry-java/pull/2433

ahh lol 🤣


Comments are incorrectly placed in presence of extension points

The following is formatted correctly:
let _ =
  switch (expr) {
  | A =>
    /* Comment under A */
    ()
  | B => ()
  };

Add %ext to the switch and it formats to:
let _ =
  switch%ext (expr)
    {
    | A => ()
    | B => ()
    };
    /* Comment under A */

which is both generally formatted worse and moves the comment far away from its intended location.

A concrete example of code this impacts is anything using Lwt's ppx.  This issue prevents commenting the branches under a switch%lwt.

This case does format properly:
let _ =
  switch%ext (expr) {
  | A => /* Line end comment under A */ ()
  | B => ()
  };


Feeqt-rq : Support for HTML in tooltip

feature request:
What is the expected behavior?
Tooltip should be able to render HTML for advance/custom tooltips. See attached image as an example.
What is the current behavior?
HTML is not supported inside tooltip
What is the use-case or motivation for changing an existing behavior?
To have dynamic templates under tooltip which is required in some complex applications.
EXAMPLE

I think this would be contrary to material design specs which states that:
Tooltips don’t display rich information including images and formatted text.
Tooltips are different than ALT-attributes, which are intended primarily for static images.
Tooltips don’t have directional arrows; instead, they rely on motion emanating from the source to convey direction.
I didn't see any thing in the specs like bootstrap's popover, so I'm not sure there will be such a component someday in the official set.
But, as soon as CDK is out, I think it probably will be done by community projects.

@julianobrasil
I've already implemented a demo (in the demo app) and the implementation support on my fork.
I didn't want to include another library for the HTML support for my project so i'll probably use my fork in the project. And yes there isn't anything like popover in material.
I might be creating a pull request anyway. You can at least run it and see how that looks :)

I cloned your feat-tooltip-cust-html, but couldn't see anything different in the tooltip. Have I cloned the wrong branch?

@julianobrasil I have changed the src/lib/tooltip/tooltip.ts which can be seen in the changes in the PR. I've also modified the demo of tooltip inside the src/demo-app/tooltip.
After you've cloned the branch, you should be able to do gulp serve:devapp and see two buttons as can be seen in the attachment. One working with our regular old message string and other with html. L

Please let me know if that's not the case.

My mistake. I was building the master instead of the feat-tooltip-cust-html branch. Now I see it. Well, I think the change is nice (although, in the demo page it raises expectations that the html tooltip will change color if you click on the "Toogle tooltipClass" button as it happens with the master branch demo).
The pros:

There's no need for a whole new component
All you need is a class to make things up and running

The cons:

It doesn't follow the material specs (maybe it should be a whole new component for this reason - the official set should stick to the specs as much as possible)

Sugestion:

There's no need for the little arrow, as the animation source works as the origin of the popup. As stated in material guide lines for the original tooltip: "(...) rely on motion emanating from the source to convey direction."

@andrewseguin is this something we want to support in tooltip?

When designing the tooltip we deliberately decided not to support this. The Material Design spec is rather prescriptive about only text appearing in tooltips. Rich content also presents a challenge for a11y.

@AhsanAyaz how you add arrow on tooltip?

using unicode, on the other hand works.
so there's a lot you can do there including controlling where your text line-breaks with \u00A0 instead of a space.


Fix: Remove event validation

This PR

[x] removes the event validation entirely

💁♂ This is an alternative to #317 - I have tried using this action with the deployment event, and as far as I understand, the event validation currently serves no real purpose. The action currently verifies that the GITHUB_REF environment variable is set, but never uses its value.

👋 Hey @localheinz, thanks for your contribution and feedback.

I have tried using this action with the deployment event, and as far as I understand, the event validation currently serves no real purpose.

The event validation mirrors the validation done on the server when creating and restoring caches. Every cache is associated with a scope, which is equivalent to the branch it is created on. These scopes are stored on the JWT token used to authenticate with the backing cache service. The reason we do this validation in the cache action is to provide a better error message to users and save time from creating a cache that will not be saved by the server. See https://github.com/actions/cache/pull/68
We'd need to do some more work on the backend cache service to support caching for events without a scope/ref attached to them. Please file an issue in this repository explaining your use-case and workflow.

Thank you, @joshmgross!


Release 1.0.12

For next time:

Would be nice to report changes relevant for users in a history.md
There are new features in this release so it should be a minor release (1.1.0) and not a patch release

@rom1504 Ah, sorry. I'll update History in another PR


Need index to allow efficiently deleting notifications

def destroy_singular_notifications(klass)
  klass.select('notify_user_notifications.*')
    .from("notify_user_notifications, to_json(notify_user_notifications.params -> 'user') user_entry")
    .where("user_entry ->> 'id' = ?", user.id).destroy_all
end

Need to be able to efficiently query on the subject of a notification, not just the target to whom the notification is sent. So that we can delete notifications for content that has been deleted or no longer warrants a notification.

We also need to be able to destroy all notifications related to a particular object:
notification_classes.each do |klass|
  klass.public_send(:where, 'params ->> \'group_id\' = ?', vent.id).destroy_all
end


Decrypt Text on Linux or Windows

Hello Jan,
I am using your great App https://f-droid.org/de/packages/dk.meznik.jan.encrypttext since a while.
It would be very helpful, if you can give me a hint how to encrypt/decrypt the text from the App
on a PC with Linux or Windows (I send very often Text between my Smartphone and a PC)
I found a Web page https://encode-decode.com/aes256-encrypt-online/
where it is possible to encrypt/decrypt AES256 Text but it does not work.
Or is it maybe compatible with https://www.aescrypt.com/download/ ?
Best Regards
Thor

I'm facing the same prob;em, did you get a solution for this?

In case someone needs it, here's the changed Encryption class to support decode in Windows/ Linux/MacOS via python:
Encryption.java
https://gist.github.com/d95ec199824bff8600c0665b9f89c27d
android_decode_text.py
https://gist.github.com/x011/5565d3fe2dcece3fe91db61edd1cc7f3

I'm also looking for a way to decrypt outside of the app. Have been playing around with openssl a bit, after having done some reading, but no luck.
As far as I understand Encryption.java, specific predefined values for salt and IV are supplied, as well as PKCS7 for padding (which afaict is non-standard in openssl?).
Unfortunately I'm not a programmer, so I really have no clue. :) If i were, I guess a Java CLI decrypter could be hacked together using the code of this project, circumventing problems with differing schemes of other encryption tools.
That aside, I'd like to say that EncryptText is a really cool app with imho a flawless interface - unobtrusive, simple yet fully functional. This could really provide useful real-world encryption security for messages and text notes (the latter prompting me to search for desktop decryption options...). Thanks for creating it!
@x011 Thanks for sharing your Python solution. Do I understand correctly that the app would have to be re-built using the java source files provided by you? (which use PKCS5 and no predefined salt and IV, as far as I can understand the differences)


[Task] Supports querying metrics from nebula Graph using NGQL

Description
Supports querying metrics from nebula Graph using NGQL , about #1866
Task List

[ ] Define a protocol implementation to support querying data from nebula Graph via NGQL
[ ] Add monitoring template  use this protocol to monitoring NebulaGraph cluster

Hello,please assign it to me, I can complete it.


Clarify "acquisition time" in scans file

In the description for the scans file, the specification says:

If acquisition time is included it should be under acq_time header.

It would helpful to specify that the acquisition time should correspond to the beginning of acquisition (i.e., when the first data point for the run was acquired).
NOTE: This issue stems from https://github.com/nipy/heudiconv/issues/450#issuecomment-644923590.

I agree that this should be clarified and it seems fairly uncontroversial to specfiy as "when the first data point for the run was acquired". PR welcome!


refactor query caching docs

Refactor Query Caching docs.

Separates caching concepts and strategy from instructions to enable the cache
Includes some more context and examples

Description
Clarify caching concepts, strategy, and configuration
This PR has:

[x] been self-reviewed.

@sthetland PTAL

@sthetland I think I got most of your suggestions, but had reorganized the doc, PTAL.
@suneet-s ,based upon our conversation I improved (or tried to) the context and organization of the caching topic. Still waiting for the list of scenarios where segment caching doesn't work.
FYI @2bethere

Overall looks great! Looks like the docs job is failing. I've offered a few minor touchups. I'll leave it to you to decide which ones you think we should add. Once CI is passes I can take another look and merge 🎉


fake commit for post merge review

@marc-hb pushed an update version

At the end of the version you could just:
-    [ $DIRTY_PR = 0 ] || exit 1;
+    exit $DIRTY_PR


[Test] Update SymbolGraphGen test to handle nondeterminism

The test SymbolGraph/Relationships/Synthesized/ConditionalConformance.swift is currently failing on CI, due to the presence of unexpected conformances to Copyable and Escapable appearing first on x86. As a quick fix to unblock CI, this PR updates the test to check multiple lines at once when fetching the relationship for the desired conformance.

preset=buildbot,tools=R,stdlib=RD
@swift-ci Please test with preset macOS

preset=buildbot,tools=R,stdlib=RD
@swift-ci Please test with preset macOS

@swift-ci Please smoke test


Missing primary keys from a few tables

Describe the bug
There are missing primary keys in 3 tables. The cause seems to be due to using @jointable rather than @collectiontable
- UP_EVENT_AGGR_CONF_INTRVL_EXC
- UP_EVENT_AGGR_CONF_INTRVL_INC
- UP_SS_DESC_LAY_ATTR_ELMS

To Reproduce
Steps to reproduce the behavior:

run gradlew dataInit

Expected behavior
All uPortal tables have primary keys defined

https://www.logicbig.com/tutorials/java-ee-tutorial/jpa/collection-table.html
https://github.com/Jasig/uPortal/blob/271f309ed71d57396737ef0c56f2a2dff4b61a73/uPortal-layout/uPortal-layout-core/src/main/java/org/apereo/portal/layout/dao/jpa/LayoutAttributeDescriptorImpl.java

Good catch ! The thing is that the ID column exist but they aren't defined as PrimaryKeys !
The patch is easy, like the migration for existing datas.


docs: fix simple typo, rumtime -> runtime

There is a small typo in rune/docs/pal_programming_guide.md.
Should read runtime rather than rumtime.
Semi-automated pull request generated by
https://github.com/timgates42/meticulous/blob/master/docs/NOTE.md

@timgates42 Thanks to address this typo!


yaml block scalars

I deploy kibana from the repository https://github.com/elastic/helm-charts
My values.yaml has the following lines
# Allows you to add any config files in /usr/share/kibana/config/
# such as kibana.yml
kibanaConfig:
  kibana.yml: |
    xpack.encryptedSavedObjects.encryptionKey: 71b27fd486e05***********
    xpack.reporting.encryptionKey: 8546a1e036a***********
    xpack.security.encryptionKey: 2e648b8f246e***********
    server.publicBaseUrl: https://***********.com
    elasticsearch.username: "***********"
    elasticsearch.password: "ref+awsssm://staging/elastic-tt-credentials?mode=singleparam"

I get the data from SSM. Only vals breaks this block.
When running
cat values.yaml | vals eval -f -

outputs
kibanaConfig:
  kibana.yml: "xpack.encryptedSavedObjects.encryptionKey: 71b27fd486e05***********\nxpack.reporting.encryptionKey: 8546a1e036a***********  \nxpack.security.encryptionKey: 2e648b8f246e***********\nserver.publicBaseUrl: https://***********.com\nelasticsearch.username: \""***********"\"\nelasticsearch.password: \"zKM1tg***********\"\n"

Deploy as follows
helm secrets --evaluate-templates upgrade --install -n testsecret kibana-tt-staging helm-charts/kibana/ --set imageTag=7.17.9 -f staging/values.yaml

When deploy via helm, the kibana.yml file in the pod does not contain this data
Expectation:
vals should save yaml blocks according to the documentation https://yaml-multiline.info/ or https://yaml.org/spec/1.2.2/#81-block-scalar-styles

When writing the post I noticed an extra space at the end of the line xpack.reporting.encryptionKey
When I removed that, everything worked as expected
I don't know if this is a bug. Maybe this information will be helpful to someone.


Icon Size - Keep original size or let enter the size

Hello,
thanks for this great plasmoid ;-)
I have one little suggestion: Currently the icon is fitted to panel hight. This is not optimal:

Left: Darwin Menu
Right: Plasma Launcher
So it would be great to keep the original icon size or the add an function for entering the height.
Thank you
Tom

Hello!

add an function for entering the height

I think, that this is more optimal solution. And I also think, that relative size will be better. Something like entering size in percent (relative to root element) with max size at 90% (for padding).

Your suggestion is also OK. The main thing is a way to adjust the size :-)
Thank you

Both methods added in last update.


my account was banned

I logged in to the same account on different clients at the same time, but the account was banned

Did I trigger any risk control rules ？

If your account was banned, try to log in from an official app and follow instructions provided by the app.


Add Lint check to CI

Enhancement
Add kclvm lint check to Github action, and fix exist lint warnings

it's done.
/close


feat(text-field): expose focusTextField() method

Describe pull-request
Exposes focusTextField method for the text field component.
Issue Linking:

GitHub: https://github.com/scania-digital-design-system/tegel/issues/896

How to test
Call the focusTextField() method programmatically for a tds-text-field element.
Checklist before submission

[x] I have added unit tests for my changes (if applicable)
[x] All existing tests pass
[x] Not breaking production behavior

@patrikhultgren thank you for this contribution! 🎉  Just to keep you in the loop, the majority of IXIB will be off during the holidays so it might take longer than usual to get this approved. But rest assure that more people will look into this once they are back from vacation :)


Fix megamenu typo: should be "Fraud" not "Frauds"

This is a correction to #3856 that added a link to /consumer-tools/fraud from the mega menu. Instead of being "Frauds & Scams" it should have been "Fraud & Scams". See GHE#2524 for details.
Screenshots

Checklist

[X] PR has an informative and human-readable title
[X] Changes are limited to a single goal (no scope creep)
[X] Code can be automatically merged (no conflicts)
[X] Code follows the standards laid out in the development playbook
[X] Passes all existing automated tests
[X] Any change in functionality is tested
[X] New functions are documented (with a description, list of inputs, and expected output)
[X] Placeholder code is flagged
[X] Visually tested in supported browsers and devices
[X] Project documentation has been updated
[X] Reviewers requested with the Reviewer tool :arrow_right:

Thanks for the review @accesslint! As this is a one-character change I'm going to self-merge.

Thanks for the review @AccessLint! As this is a one-character change I'm going to self-merge.

😆


Run Build ReactPWA but only show like dir with item list folder

Hello, i am interesting with this boilerplate.
But when i am trying to build for production only show like dir with list folder.
I am trying too with default create-react-app and running well.
I am use boilerplate in this git https://github.com/Atyantik/react-pwa and npm run build.
When trying to access it with server not display well like in development.

Please help. Thank you

Hey @alhiro you need to run server.js via node, i.e.
cd <project-build>
node server.js

Once you run server.js, then the node server will start at the port specified.

Awesome. It's working. Thank you so much!


[type:fix]add First Leve Menu  failed parentId  not allow null

Make sure that:

[x] You have read the contribution guidelines.
[x] You submit test cases (unit or integration tests) that back your changes.
[x] Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

add First Leve Menu  failed parentId  not allow null

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (c6c7fdb) 61.16% compared to head (fa07cd6) 61.00%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5398      +/-   ##
============================================
- Coverage     61.16%   61.00%   -0.16%
+ Complexity     8597     8579      -18
============================================
  Files          1248     1248
  Lines         38017    38016       -1
  Branches       3647     3644       -3
============================================
- Hits          23253    23192      -61
- Misses        12666    12719      +53
- Partials       2098     2105       +7

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Create a Next.js/Vercel Template

Create a Next.js/Vercel Template
Summary
The key to this integration is to go to the Next.js developer community (js Community. With over 5 million weekly downloads, Next.js has a large and active community of developers around the world.) with a proposal where, with one click, they can deploy a complete AI solution with Voice, Backend, and Frontend.
Outcome

Facilitate faster adoption and improved 'time to value' for developers experienced with Next.js and looking to integrate with Python backends.

Technical Details
Design and release a Next.js/Vercel template that integrates with Vocode's FastAPI Python backend. The template should facilitate seamless communication between the Next.js frontend hosted on Vercel and the FastAPI backend. This involves:

Setting up Serverless Functions in Vercel: Configure serverless functions using Python, ensuring compatibility with the FastAPI framework.
Integrating FastAPI with Vercel: Establish a connection between the Vercel-hosted Next.js frontend and the FastAPI Python backend, ensuring efficient data exchange.

Subtasks

[x] Design the Next.js/Vercel template for Python backend integration.
[x] Implement Vocode Python backend functions in the template.
[ ] Establish and configure the repository under the vocodedev organization.
[ ] Conduct thorough testing to ensure seamless integration.
[ ] Document the setup process and release the template.

https://github.com/ArtisanLabs/vocode-next-vercel-template


⚠ Secret Website 3 has degraded performance

In da9e8f0, Secret Website 3 ($SECRET_WEBSITE_3) experienced degraded performance:

HTTP code: 200
Response time: 2083 ms

Resolved: Secret Website 3 performance has improved in 3983e9e.


Fixes Issue #2 and #3

Fixed issue #2
Since the articles are being parsed based on their created timestamp, and the year is not being monkeyed-about with, there's no reason for the code to monkey-about with the incoming month data either. Removed the random + and - 1's~~, as well as the unknown-purpose %12. Restart rails server and bob's-your-uncle.~~
Edit:
Upon further review, this also resolves issue #3 :
Removing the %12 fixes the disorder which was causing the months to appear out-of-order

Excellent :+1:


Minor: context/theme-detailed-app.js broken

Today I tested out the new Context API using using CRA.
I copy/pasted the example in, and was surprised to encounter a runtime exception.
So this tiny PR is intended to make things easier for future Context API learners.

ReferenceError: Must call super constructor in derived class before accessing 'this' or returning from derived constructor

Looks like it worked. Courtesy of Netlify:

Thanks!


Not working on Android 19

The trustkit setup works perfectly on Android 21 and above but it fails in Android 19.
here is my network-security config file:
<network-security-config>     <domain-config>         <domain includeSubdomains="true">endpoint</domain>          <pin-set>             <pin digest="SHA-256">hash1</pin>             <pin digest="SHA-256">hash2</pin>         </pin-set>         <trustkit-config enforcePinning="true" />     </domain-config> </network-security-config>
The issue is when a different pin hash is provided, it still allows connection.

Works only with certificates and if the flag is debug (look at the source code, there's a tremor)


Add Fuchs Mizrachi

Requesting to add Fuchs Mizrachi School:
https://www.fuchsmizrachi.org/

@Yona168 Pull request merged. Thank you!

Thank you JetBrains!


Create README-HINDI.md

Solved #32

@A91y this is clearly a low quality machine translated version for the main readme which honestly is automatically done my most browsers. So whats the point of creating a separate file for a different language if you are going to use some automatic translators anyway?


ssh connection hang after VM migrated

Is this a BUG REPORT or FEATURE REQUEST?:

Uncomment only one, leave it on its own line:

/kind bug

/kind enhancement

What happened:
ssh to a VM hang after VM migrated.
What you expected to happen:
How to reproduce it (as minimally and precisely as possible):
ssh to a VM(Masquerade to pod network) via service IP from terminal, then migrate the VM, after migrated, the ssh connection hang(can't make any operation), and I have to open a new ssh connection.
Anything else we need to know?:
Environment:

KubeVirt version (use virtctl version): v0.35.0
Kubernetes version (use kubectl version): 1.19.4
VM or VMI specifications:
Cloud provider or hardware configuration:
OS (e.g. from /etc/os-release):
Kernel (e.g. uname -a):
Linux k8s-2 4.18.0-147.el8.x86_64 #1 SMP Wed Dec 4 21:51:45 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Install tools:
Others:

@scuzhanglei this is expected and there is no way around it. Due to limitations of underlying Kubernetes Pod network, external IP address of the VM changes once it lands on a different host.
If you want to preserve open connections, you have to use secondary multus network and handle IP management there yourself.


Make topology configurable in anti-affinity.libsonnet

Slack dicussion : https://kubernetes.slack.com/archives/CAX9GU941/p1612883283008900
What is missing?
Today, it is possible to add pod anti-affinity by using this lib :
 (import 'kube-prometheus/kube-prometheus-anti-affinity.libsonnet') +

but the topology value is hard-coded to hostname
It would be useeful to allow users to choose the topology constraint, to choose to schedule the pods in different zones or region for example.
Why do we need it?
With only a hostname anti-affinity, Prometheus and AlertManager replicas can be scheduled in the same AZ today, and as they are linked to PVCs, they are bound to stay in this AZ and when the number of workers is not high in one AZ, it can lead to potential issues.
Environment
k8s 1.18.2

kube-prometheus version:
release-0.6

Anything else we need to know?:
For now, the solution proposed by @paulfantom in Slack is working :
(import 'kube-prometheus/kube-prometheus.libsonnet') +
(import 'kube-prometheus/kube-prometheus-anti-affinity.libsonnet') + {
  prometheus+:: {
    prometheus+: {
      spec+: {
        affinity+: {
          podAntiAffinity+: {
            preferredDuringSchedulingIgnoredDuringExecution: std.map(
              function(e) e {
                podAffinityTerm+: {
                  topologyKey: 'kubernetes.io/zone',
                },
              },
              super.preferredDuringSchedulingIgnoredDuringExecution,
            )
          },
        },
      }
    },
  },
}

but make the topology configurable would be nicer.

Done in https://github.com/prometheus-operator/kube-prometheus/pull/961.


Model trained and saved on GPU fails at model open on CPU

Hi, this does not seem right. I have been training some models on TS-877 Ryzen-based NAS with 8 cores and 16 threads, and a GeForce GTX 1060 6GB graphics card, in a gpu-docker container Tensorflow:2.1.1-gpu-notebook (with CUDA version V10.1.243); then I have saved them as usual with model.save(). When I open them inside the container, everything works fine:
new_model.summary()
Model: "model"
_________________________________________________________________
Layer (type)                 Output Shape              Param #
=================================================================
input_word_ids (InputLayer)  [(None, 192)]             0
_________________________________________________________________
tf_distil_bert_model (TFDist multiple                  134734080
_________________________________________________________________
tf_op_layer_strided_slice (T multiple                  0
_________________________________________________________________
dense (Dense)                multiple                  769
=================================================================
Total params: 134,734,849
Trainable params: 134,734,849
Non-trainable params: 0
_________________________________________________________________

Describe the current behavior
However, when I try to open this model in my computer, it fails tremendously, the summary shows all empty:
2020-06-14 21:38:07.495770: I tensorflow/core/platform/cpu_feature_guard.cc:143] Your CPU supports instructions that this TensorFlow binary was not compiled to use: AVX2 FMA
2020-06-14 21:38:07.509869: I tensorflow/compiler/xla/service/service.cc:168] XLA service 0x7fb6ff0417a0 initialized for platform Host (this does not guarantee that XLA will be used). Devices:
2020-06-14 21:38:07.509888: I tensorflow/compiler/xla/service/service.cc:176]   StreamExecutor device (0): Host, Default Version
Model: "model"
_________________________________________________________________
Layer (type)                 Output Shape              Param #
=================================================================
Total params: 0
Trainable params: 0
Non-trainable params: 0
_________________________________________________________________

And trying to get any prediction yields all this:
2020-06-14 21:38:50.852268: W tensorflow/python/util/util.cc:329] Sets are not currently considered sequences, but this may change in the future, so consider avoiding using them.
Traceback (most recent call last):
  File "open-model.py", line 16, in <module>
    model.save(f'models/CPU_distilbert_batch16_epochs3_maxlen192')
  File "/Users/Margi7/anaconda3/lib/python3.6/site-packages/tensorflow/python/keras/engine/network.py", line 1052, in save
    signatures, options)
  File "/Users/Margi7/anaconda3/lib/python3.6/site-packages/tensorflow/python/keras/saving/save.py", line 138, in save_model
    signatures, options)
  File "/Users/Margi7/anaconda3/lib/python3.6/site-packages/tensorflow/python/keras/saving/saved_model/save.py", line 78, in save
    save_lib.save(model, filepath, signatures, options)
  File "/Users/Margi7/anaconda3/lib/python3.6/site-packages/tensorflow/python/saved_model/save.py", line 951, in save
    obj, export_dir, signatures, options, meta_graph_def)
  File "/Users/Margi7/anaconda3/lib/python3.6/site-packages/tensorflow/python/saved_model/save.py", line 1027, in _build_meta_graph
    options.namespace_whitelist)
  File "/Users/Margi7/anaconda3/lib/python3.6/site-packages/tensorflow/python/saved_model/save.py", line 629, in _fill_meta_graph_def
    signatures = _generate_signatures(signature_functions, resource_map)
  File "/Users/Margi7/anaconda3/lib/python3.6/site-packages/tensorflow/python/saved_model/save.py", line 497, in _generate_signatures
    function, mapped_inputs, resource_map)
  File "/Users/Margi7/anaconda3/lib/python3.6/site-packages/tensorflow/python/saved_model/save.py", line 449, in _call_function_with_mapped_captures
    resource_map)
  File "/Users/Margi7/anaconda3/lib/python3.6/site-packages/tensorflow/python/saved_model/save.py", line 372, in _map_captures_to_created_tensors
    ).format(interior))
AssertionError: Tried to export a function which references untracked object Tensor("26682:0", shape=(), dtype=resource).TensorFlow objects (e.g. tf.Variable) captured by functions must be tracked by assigning them to an attribute of a tracked object or assigned to an attribute of the main object directly.

Which is really odd. How can I load and do inference, predictions on a CPU machine with a model trained on GPU on another machine?
Describe the expected behavior
I expected to be able to open the trained model and make predictions.
System information where I try to OPEN the model

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): No, I followed the examples of Tensorflow docs.
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): macOS Catalina 10.15.5
TensorFlow installed from (source or binary): binary
TensorFlow version (use command below): v2.2.0-rc4-8-g2b96f3662b 2.2.0
Python version: Python 3.6.4
CUDA/cuDNN version: no
GPU model and memory: AMD Radeon Pro 580 (but not used)

Standalone code to reproduce the issue
import os
import numpy as np
import tensorflow as tf
from tensorflow.keras.layers import Dense, Input
from tensorflow.keras.optimizers import Adam
from tensorflow.keras.models import Model
from tensorflow.keras.callbacks import ModelCheckpoint

print(tf.version.VERSION)
print("Num GPUs Available: ", len(tf.config.experimental.list_physical_devices('GPU')))

model = tf.keras.models.load_model(f'models/distilbert_batch16_epochs3_maxlen192')
print(model.summary())

with tf.device('cpu:0'):
    model.save(f'models/CPU_distilbert_batch16_epochs3_maxlen192')

with tf.device('cpu:0'):
    new_model = tf.keras.models.load_model(f'models/CPU_distilbert_batch16_epochs3_maxlen192')
print(new_model.summary())

I cannot upload the model itself because its more than 1 GB, but the summary is shown above.

@margaritageleta,
In order to expedite the trouble-shooting process, could you please provide the complete code to generate the model or upload the files to Google Drive and share the link with us. Thanks!

Yesterday I had a crazy night trying to figure out what was going on. And I found it. @amahendrakar the versions of tensorflow in the machine were I trained the model and were I tried to retrieve the model were diferent, I switched to an older version (2.1.0) and it worked, yet it was really weird.


Add wiki entry about $_REMOTE_USER and sudo stuff

Others have also had problems with root user vs normal user.

https://github.com/devcontainers/spec/issues/91
https://github.com/devcontainers-contrib/features/pull/149
https://github.com/devcontainers-contrib/features/pull/144
https://github.com/devcontainers-contrib/features/pull/139
https://github.com/devcontainers-contrib/features/pull/137
https://github.com/devcontainers-contrib/features/pull/94
https://github.com/devcontainers-contrib/features/issues/80
https://github.com/devcontainers-contrib/features/pull/74
https://github.com/devcontainers/spec/blob/main/proposals/features-user-env-variables.md

It would be beneficial to have documentation on how to fix it and why it happens.
/assign @jcbhmr

Will be closed by #165 which...


walinuxagent should be waagent

I think and approved "walinuxagent" should be "waagent" in all commands.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e86655f9-6d0b-106b-7b88-edbd20ee4544
Version Independent ID: cf60b900-6f8a-4b28-a86b-39daadd876f5
Content: Update the Azure Linux Agent from GitHub
Content Source: articles/virtual-machines/extensions/update-linux-agent.md
Service: virtual-machines-linux
GitHub Login: @roiyz-msft
Microsoft Alias: roiyz

@wbpluto for ubuntu and debian its walinuxagent and for redhat and centos its waagent.
The terminologies used in the doc is correct.

@wbpluto for ubuntu and debian its walinuxagent and for redhat and centos its waagent.
The terminologies used in the doc is correct.

Thanks. I thought my VM is Ubuntu, but it in fact CentOS. So you're right and this issue should be closed.


Bits.h and cmake big endian check can be removed

Since we use endian library from boost, there seems to be no longer need for the Bits.h file and cmake big endian check .

fixed by #721


$:/config/tiddlyweb/host gets written to filesystem

$:/config/tiddlyweb/host gets written to the file system when it is set on startup. If it would be a preloaded tiddler or shadow tiddler, could this be prevented?

Fixed as of 2.0.4. It will now preload the tiddler instead of adding it after boot. Preloaded tiddlers overwrite any wiki tiddlers with the same name, so it will still work correctly on TiddlyServer. The easiest way to use it with NodeJS server again would be to just load it in TiddlyServer and delete the tiddler $:/config/tiddlyweb/host. This will tell the sync adaptor to delete the tiddler from the file system. The tiddler will stay deleted until the next time you load the datafolder.


Allow certain audio thread operations to hard-block until completion

This is a slightly alternative path to #1120. Note that the second argument has not been set for any operations yet. Before merging we should probably set it to true for at least Stop.

Closing this as not-required for now.


visual range select unexpected when use AIEdit

For the most part, AIEdit works; but I found a problem in one case: if the cursor is on the c of "abc", using AIEdit on vi "will affect the entire line. I found that the following code is always 0 in this case.
    autocmd CursorMoved *
          \ let g:vim_ai_is_selection_pending = mode() =~# "^[vV\<C-v>]"

@madox2 @Konfekt

Did the cursor move? Can you give the entire line?

Uploading 录屏2024-07-22 下午7.39.33.mov…

https://github.com/user-attachments/assets/b4c24576-fe0f-4296-82d8-13b308968b68

@Konfekt

I cannot reproduce. Selecting "bbb" in the line reading
aaa"bbb"ccc

and entering '<,'>AIEdit replace by synonym called
" autoload/vim_ai.vim (lines 114-115)
function! s:GetVisualSelection()
  echoerr 1

as the error message showed and replaced the text with
aaa"Sorry, I couldn't find any synonyms for "bbb". Could you please provide more context or clarify the expression?"ccc

There is an important point here, the cursor needs to be located one letter before the second ", otherwise there is no problem @Konfekt

Yes, true, thank you for the reminder, though here it does not affect the result, the output is the same as above. Could you give a minimal vimrc ?

The smallest vimrc can't be reproduced. It may be my vimrc problem. I'll find my own problem first. @Konfekt

set nocompatible
let &rtp = '/vim-ai/' . ',' . &rtp
set signcolumn=yes
filetype plugin indent on
syntax on

2024-07-22 下午8.48.08.mov.zip

Are you using 「vi"」 to select? @Konfekt

Are you using 「vi"」 to select? @Konfekt

Okay, here's how to reproduce: Put the cursor on the last letter of the letters surrounded by " and " and type vi". Then the cursor does not move and the selection is not correctly recognized.
I don't see an obvious solution, since the autocmd hinging on CursorMove must fail, and other more suitable approaches failed: https://github.com/madox2/vim-ai/pull/77#issuecomment-1965216792


Issue #0: Upgrade black formatting to 24.1.1

Description
Fixes failing tests due to upgrades to the black standard..
Type of change

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

How should this pull request be reviewed?

[ ] By commit
[ ] All changes at once

How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Passes Tests

[X] Unit tests (General Environment only) pytest --cov bsk_rl/envs/general_satellite_tasking --cov-report term-missing tests/unittest
[X] Integrated tests (General Environment only) pytest --cov bsk_rl/envs/general_satellite_tasking --cov-report term-missing tests/integration
[X] Examples (General Environment only) pytest tests/examples

Test Configuration

Python: 3.10.11
Basilisk: 2.2.2
Platform: MacOS

Checklist:

[X] My code follows the style guidelines of this project (passes Black, ruff, and isort)
[X] I have performed a self-review of my code
[X] I have commented my code, particularly in hard-to-understand areas
[X] I have made corresponding changes to the documentation
[X] Commit messages are atomic, are in the form Issue #XXX: Message and have a useful message
[X] My changes generate no new warnings
[X] I have added tests that prove my fix is effective or that my feature works

Bypassing protections for routine maintenance


Documentation confusing on whether SSD and RetinaNet count background as class object

The documentation for the SSD class mentions that we should not count the background as an object class when passing the number of classes as a parameter to instantiate an SSD object.
https://github.com/pytorch/vision/blob/959666891589c35e6d225943253f523cffbae4cc/torchvision/models/detection/ssd.py#L144
However, further down in the same file, an SSD object is instantiated in a function that explicitly says that the background should be counted as an object class, but this is not taken into account in the code (i.e. I did not see num_classes be decremented by one when creating the SSD object).
https://github.com/pytorch/vision/blob/959666891589c35e6d225943253f523cffbae4cc/torchvision/models/detection/ssd.py#L589
Here is the documentation for this function, which says we should include the background in the number of classes.
https://github.com/pytorch/vision/blob/959666891589c35e6d225943253f523cffbae4cc/torchvision/models/detection/ssd.py#L563
This is confusing. Should we or should we not count the background as an object class when instantiating the SSD? In either case, how should object classes be ID'd during training?
As an example, with Faster RCNN, the background is counted as an object class (with ID 0 reserved for it) and actual object classes are identified during training starting from ID 1. What should be the procedure for SSD?
I have also opened a topic in the forums, since this is both a personal question of mine as well as a possible issue in the docs (or the code).

@douglasrizzo Thanks for reporting.
Blame me for copy-pasting the doc string of RetinaNet which had exactly the same issue. The num_classes should include the background. I've issued a PR that fixes the problem.

@datumbox Thanks for the reply. I actually believe the RetinaNet documentation suffers from a similar problem.
The documentation for the RetinaNet class tells us to exclude the background as an object class:
https://github.com/pytorch/vision/blob/1962fddb116f697d7059fd11c2f204839460b214/torchvision/models/detection/retinanet.py#L259
The function retinanet_resnet50_fpn tells us to include the background as an object class:
https://github.com/pytorch/vision/blob/1962fddb116f697d7059fd11c2f204839460b214/torchvision/models/detection/retinanet.py#L608
But when a RetinaNet object is created inside of retinanet_resnet50_fpn, the number of classes passed to retinanet_resnet50_fpn (which counts the background) is not decremented by 1 before being used in RetinaNet:
https://github.com/pytorch/vision/blob/1962fddb116f697d7059fd11c2f204839460b214/torchvision/models/detection/retinanet.py#L622
Since num_classes is only used inside retinanet_resnet50_fpn to instantiate a RetinaNet object, my bet is that the documentation for retinanet_resnet50_fpn is wrong.

I just saw your PR fixes both documents.

@datumbox
hi, I think num_classes in retinanet should exclude the background.
because in classification loss using binary_cross_entropy_with_logits, don't need to consider background.

Sorry to reopen the issue, but the other question was not answered:
how should the labels be numbered during training (for custom datasets) - starting from 0 or from 1?
And then during inference, does the model return the labels starting from 0 or from 1?


Complete name of OAuth flow to include PKCE

Want to specifically specify that the flow that's being used is the Auth Code with PCKE instead of just Auth Code. Important distinction for SPAs where PCKE is needed.

Do not merge yet. I see one more place I can update it on this page.

@Dickson-Mwendia
IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

Changed. Thank you!

Thank you so much @MaxProfit
#sign-off


Move all sources one level up

I think this helps discoverability and suppresses redundancies.

Please don't merge this one before the other PRs or I'll have to rebase them…

Please don't merge this one before the other PRs or I'll have to rebase them…

Could you draft it ?

I've changed my mind, you can merge it if you want, and I'll rebase the others.

We need to go further.  To move the files from service/bin and service/lib to  service, do the same with worker.

I think that's ok honestly :)

I think that's ok honestly :-)

Please do

When you're happy I suggest you squash and merge.


Issue with variable Slides/Images Widths

If you're referring to having equal height and variable width slides, that's not possible at the moment.

Ok! thanks @davidghi

No problem. I plan to add this in the near future.


Test performance different from that of HCI benchmark

Hi Dr. Shin,
Thank you very much for your excellent works, it really helps me a lot. But I got a little confused when I tested HCI light field scene (boxes, cotton, dino, sideboard) with offered model (pretrained model 9x9 and 5x5), I found that the performances of estimates (MSE and Bad pixel ratio) is different from that published on HCI benchmark website, I guess maybe that the models you offered is different from that you used for HCI benchmark test? Do you have any idea about the difference?  Thank you for your attention!
Yours sincerely,
Jinglei

The provided pretrained weights in Github is same with the weights(epinet9x9, epinet5x5) in our paper. But we didn't use a ensemble technique in github, but the performance is little different with the performance in the paper. Thanks.

Thank you very much for your response, have you ever tested your method on old  HCI data(stilllife, buddha, butterfly, monasRoom)? I have found that the estimated disparity map has many artifacts for these scenes, so I'm not sure this is due to the model itself or other reasons?
Yours sincerely,
Jinglei

I just tested it, and I think it works well.
The ordering(numbering) of old HCI dataset is little different with ours.
So you need to convert them into our format like below.
f=h5py.File('stillLife/lf.h5','r')
LF=f['LF'] // load LF images (768,768,9,9,3)
LF=np.transpose(LF,(2,3,0,1,5)) // converted to (9,9,768,768,3)
LF=LF[:,:,:,::-1,:] // reverse order
LF=LF[np.newaxis,:,:,:,:,:] // add one dimension

I just tested it, and I think it works well.
The ordering(numbering) of old HCI dataset is little different with ours.
So you need to convert them into our format like below.
f=h5py.File('stillLife/lf.h5','r')
LF=f['LF'] // load LF images (768,768,9,9,3)
LF=np.transpose(LF,(2,3,0,1,5)) // converted to (9,9,768,768,3)
LF=LF[:,:,:,::-1,:] // reverse order
LF=LF[np.newaxis,:,:,:,:,:] // add one dimension

Hi Dr. Shin,
Thank you very much for your advice, I'll retest these scenes. If this doesn't bother you, could you please send me the disparity map of stillLife you have got, which can help me to verify if I give input images order correctly. And could you please give me your model 7x7 (jlshi@outlook.com), I'm very interested in the performance evolution when increasing stream length. Thank you for your attention.
Yours sincerely,
Jinglei SHI

Diparity result of stillLife -->stillLife_9x9.zip
Sorry, I think we have only the checkpoint file with 5x5 and 9x9 viewpoints.
Now I'm re-train the model, and I will upload it soon.

Thank you very much!

We emailed him to request their code and dataset, and received their dataset link.


Nodes connect and disconnect radom

It looks like the nodes in NR are disconnectiong and reconnecting every 5s. No clue what is the issue.

You can only have 1 instance of Node-RED running with a given user
And you can only have 1 Configuration node (where you entered the username/password) that must be shared by all the device nodes.
Ensure you only have 1 instance of Node-RED running and delete duplicate config nodes

From the docs:

Configure Nodes
When you drag the first Google Home node on to the canvas you will need to create a config node. To do this, click on the pencil icon next to the first input. This will open a new dialog, where you can enter the same username/password from the first step and hit the "Add" button. For all subsequent nodes you should just pick the entry from the drop down that matches your username.


Support overriding an override

Fixes #987.
Now we get a stderr message on override add, which indicates if an override is changed, new, or already exists.
If the channel is not installed, it gives the same error as julialauncher.
Please check carefully since I'm new to Rust. Especially not sure if the iter_mut pattern is idiomatic.

Bump :)


Mouse pointer hiding ignored when used with SDL

I apologize in advance if this bug report isn't up to standards, as I'm not quite sure what information to give.
We've recently added a BGFX renderer plugin to MAME, but one issue is happening when using SDL for window and input management - the mouse cursor does not go away, regardless of calls to SDL_ShowCursor.
I'm not sure what to give in terms of reproduction steps, but we have a pretty straightforward build setup in our MAME repo here: https://github.com/mamedev/mame
Run it on Linux or OS X, and you'll quickly see the issue with regards to the mouse pointer. Again, this doesn't happen on a standard Windows build, as MAME uses the usual Windows-based APIs for window and input management when available.

This is probably SDL problem. bgfx doesn't touch mouse at all, just window handle it gets from SDL, or OS.

It seems to be a specific interaction with BGFX though, the mouse pointer is hidden properly if we draw to the window using OpenGL or SDL accelerated drawing.  Does BGFX do anything strange when creating views that could be causing this?

I grab native window handle from SDL and just use it. Are you using your own SDL or you're using entry_sdl.cpp from bgfx?

We have our own entry point and we call bgfx::sdlSetWindow, then bgfx::createFrameBuffer on it.

Ok, that should just create swap chain in D3D / shared context on GL, for GLX specifically code is called from here:
https://github.com/bkaradzic/bgfx/blob/master/src/glcontext_glx.cpp#L254
You can see there is nothing special:
https://github.com/bkaradzic/bgfx/blob/master/src/glcontext_glx.cpp#L29

Yeah, I'm quite confused by it, too.

All this happens on the same thread? Where you create window and turn on/off mouse?

Don't worry, it's an issue with SDL2 itself doing something silly that's fixed in recent SDL2 source.  Please close this issue.

Cool!


Weird Issue: angular nvd3 line chart with ionic

@krispo , I have added line chart in web and ionic both. In web chart is working fine, but same chart not showing properly in ionic. It cuts vertically in ionic not showing higher values.
I have tried lot but not able to fix.
You can see in image there are higher values like 150,100,200etc. but not able to see those values.

anyone there to help. I have tried a lot, but not able to fix.

I found something, " tag inside  tag getting more height than given" I think that is creating this issue. I dont know why is it happening? same code is working on web application.

@krispo Please help me facing weird issue

It's maybe resize issue.. Which ionic platform are you trying to use? I tested a simple example in ionic 'browser' platform, it works fine for me.
Can you please put some code to demonstrates this issue.

@krispo Thanks for response and for this wonderful directive.
my chart options:
$scope.options = {
		    chart: {
		        type: 'lineChart',
		        height: 350,
		        transitionDuration: 500,
		        margin : {
		            top: 10,
		            right: 20,
		            bottom: 10,
		            left: 55
		        },
		        x: function(d){ return d.label; },
		        y: function(d){ return d.value; },
		        showValues: true,
		        useInteractiveGuideline: false,
		        xAxis: {
		            axisLabel: 'Time',
		            tickFormat: function(d) {
                        return d3.time.format('%b %e, %Y')(new Date(d))
                    },
                    showMaxMin: false,
                    staggerLabels: true
		        },
		        yAxis: {
		            axisLabel: 'Values',
		            axisLabelDistance: 30,
		            tickFormat: function(d) {
                        return d
                    },
		            showMaxMin: false,
		        },
		        tooltipContent:function(key, x, y, e, graph){
		        	return '

' + d3.time.format('%b %e, %I:%M %p')(new Date(e.point.label)) + '
' +
		               '
' +  key + ' : ' + y + '

';
                },
                useVoronoi: false
		    }
		};

adding values in chart
$scope.data[val.code].values.push({label: val.observationAddedAt, value: val.value});

Same thing I have used in Web application, it is working fine.

html code please. and what platform?

<ion-view view-title="{{currentJournal.prompt}}">
  	 <ion-scroll zooming="true" direction="xy" style="width: 100%;height:100%;margin-top:50px">

			<nvd3 options='options' data='newData'></nvd3>

	</ion-scroll>

</ion-view>

tested in browser platform

also which nvd3 and directive versions?

/*! nvd3 - v0.0.1 - 2014-08-18 */
Dont know about directive version. I got file from your git repo.
Angular directive from src/ folder
and other files from lib/ folder

try with the recent versions:
https://cdnjs.cloudflare.com/ajax/libs/nvd3/1.8.1/nv.d3.css
https://cdnjs.cloudflare.com/ajax/libs/nvd3/1.8.1/nv.d3.js
https://rawgit.com/krispo/angular-nvd3/v1.0.2/dist/angular-nvd3.js

Same issue.

I couldn't catch this issue from my side...
Try to update or refresh the chart directive after adding data:
$scope.data[val.code].values.push({label: val.observationAddedAt, value: val.value});
$scope.api.update(); //or $scope.api.refresh();

it may need $timeout(function(){ /*code with data manipulation and chart updating*/ }, 50) wrapping.
add api to html:
<nvd3 options='options' data='newData' api='api'></nvd3>

Thanks for your time. Let me try

No luck with refresh and update. Same issue

@krispo can you provide your test code ?? So I can try exactly same.

here live example.

Finally got solution. Its really very weird.
In values object, You have to make sure values are going as int OR float not string.
With string, values are being plotted on page but it creates this issue only in ionic platform, I think.
Because on web application, it always works fine.
Thanks @krispo for your time.

Hi, I'm new to ionic, can you suggest me a basic chart system that can be implemented in ionic 2(+typescript+html+scss) ?
or can you help me to convert this nvd3 line chart to ionic 2(typescript)? Because I tried this but don't works for me.


Display some highlight on the 'current' class (i.e. the one occurring at the current time)

Consider https://github.com/tehapo/progress-bubble

See #200, but this feature won't be added.


robot_localization: 2.7.3-1 in 'noetic/distribution.yaml' [bloom]

Increasing version of package(s) in repository robot_localization to 2.7.3-1:

upstream repository: https://github.com/cra-ros-pkg/robot_localization.git
release repository: https://github.com/cra-ros-pkg/robot_localization-release.git
distro file: noetic/distribution.yaml
bloom version: 0.10.7
previous version for package: 2.7.2-1

robot_localization
* Prevent node from crashing on invalid UTM zone, but throw ROS_ERROR to notify user (#682 <https://github.com/cra-ros-pkg/robot_localization/issues/682>)
* changed geographiclib to <depend> tag (#684 <https://github.com/cra-ros-pkg/robot_localization/issues/684>)
* Small formatting and content change (#677 <https://github.com/cra-ros-pkg/robot_localization/issues/677>)
* Fixed state transition for sigma points. The state transition function for each sigma point now uses its sigma point's posteriori state instead of always the posteriori state. (#628 <https://github.com/cra-ros-pkg/robot_localization/issues/628>)
  Co-authored-by: jola6897<EMAIL_ADDRESS>* Contributors: John Stechschulte, Jonas, MCFurry, Vivek Mhatre

Holding for Noetic sync


Fees should not be displayed as mBTC

Fees in the Transaction Detail view are currently always 0,0 mBTC. There should be a lower denomination for the fees in order for the user to be able to see them.

somethimes lnd returns 0 fees for transactions. maybe its better to not show a fee at all in those cases to avoid confusion?

I just assumed the fee was just a few satoshis so that it was rounded to 0 mBTC. When it is truely 0 I am not sure how to handle it best. 0 satoshi would be more clear to me that there were really no fees but then showing satoshis next to mBTC may also not be great because of the inconsistency. Maybe fall back to "free" if it is really 0 sat. But I am not sure which one of these I prefer myself to be honest.


Run with --once but the test runner does not quit after finishing

I want to run the tests only once so that I can use it on a CI server. However, it just keep showing App running at: http://localhost:8000/ and no test was actually run
TEST_BROWSER_DRIVER=phantomjs TEST_SERVER=0 CLIENT_TEST_REPORTER=dot meteor test --once --driver-package dispatch:mocha --port 8000 --settings .settings/localhost.json
Using DSV custom oauth package               /
Using DSV custom oauth package               /
[[[[[ Tests ]]]]]

=> Started proxy.
=> Started MongoDB.

Unable to resolve some modules:

  "react/addons" in /Users/hungvo/Projects/songnhi/webapp/node_modules/enzyme/build/react-compat.js (web.browser)
  "react/lib/ReactContext" in /Users/hungvo/Projects/songnhi/webapp/node_modules/enzyme/build/react-compat.js (web.browser)
  "react/lib/ExecutionEnvironment" in /Users/hungvo/Projects/songnhi/webapp/node_modules/enzyme/build/react-compat.js (web.browser)
  "react-test-renderer/shallow" in /Users/hungvo/Projects/songnhi/webapp/node_modules/enzyme/build/react-compat.js (web.browser)

If you notice problems related to these missing modules, consider running:

  meteor npm install --save react react-test-renderer

W20170704-09:43:59.064(7)? (STDERR) Module load hook: transform [/private/var/folders/rp/0935lss16970__qmvmth8kzc0000gn/T/meteor-test-run1ar3j9v/.meteor/local/build/programs/server/app/app.js]
I20170704-09:44:07.272(7)? SKIPPING SERVER TESTS BECAUSE TEST_SERVER=0
=> Started your app.

=> App running at: http://localhost:8000/

I think there was an issue like this that was fixed at some point. Another possibility is that the "dot" reporter might not work properly on CI. I'd also recommend using nightmare or chrome instead of phantomjs, which is buggy.
Since this issue is old, I'll close, but we can reopen if still broken after trying these things.


Add Restore jobs to the rewrite

Add the check job logic to the new implementation: https://github.com/vshn/k8up/tree/master/service/restore
The controller is already implemented for that. Now we need to implement an Executor that actually triggers the job.
With #114 merged the new implementation lives on the development branch.

I'll take that over 👍

wondering - is a restore exclusive?
It sounds like it should but I can't seem to find it in the existing code.


fix: fetch results cached st not getting latest data

Description
The attestations are cached for long time, which causes user not getting the latest approved attestations.
Related Issues
close #213

Problem
Currently already tried several ways to refetch the latest data, now already made sure it would call refetch right after succeeds, but no latest data loaded. Right now I think reload the current page is the best way to complete this PR, we could find another way to solve this problem in the future, but I think it's important to make sure user get the instant update on data status and prevent them from approving same applications.


kernel: consider writable/clean pages as evictable

The PnorRP maps "readonly" PNOR sections as WRITABLE so that
procedures can scribble on the memory if necessary.  But this
causes the kernel to never cast out these (usually) read-only
pages and eventually run out of memory.
To fix this only consider a writable+dirty page as actually
unevictable, and treat a writable+clean page as readonly similarly
to other logic in this file.

This change is

so that procedures can scribble on the memory if necessary
There shouldn't be any HWPs (or any code) that is modifying readonly pnor data.  The reason the pages are marked writable is because that is how the data gets loaded into the memory itself from the flash.  If the pages weren't writable, the pnor driver couldn't copy the page in as needed.

However, the issue you pointed out still seems valid.  The change seems fine at face-value.  My one concern is that we might take a performance hit because we end up having to refetch the data from PNOR again.  But maybe that is balanced out by having more free pages.  I'll run a quick test to check the evictions.
I'd like @williamspatrick to weigh in too.


Make CI smarter: run certain tests, based on what files are changed.

As mentioned by amazing @yeya24 here in GitHub Action we can do magic like this:
on:
  push:
    paths-ignore:
    - 'docs/**'

Wonder if we can improve our CI (make it faster) for just docs changes etc. WDYT?
The only problem is that it's easy to miss that some tests were skipped if some code will move around to docs for some reason etc.

If some code is moved to docs, current test would fail but it is normal, so that ignore doc path is safe, do i miss something?

For circle CI, we can use skip ci in the commit message instead of checking for updated files. GH actions currently don't skip based on commit messages, but there is a workaround shown here.

still needed
On Tue, 19 May 2020 at 12:30, stale[bot]<EMAIL_ADDRESS>wrote:

Hello 👋 Looks like there was no activity on this issue for last 30 days.
Do you mind updating us on the status? Is this still reproducible or
needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity for next week, this issue will be closed (we
can always reopen an issue if we need!). Alternatively, use remind command
https://probot.github.io/apps/reminders/ if you wish to be reminded at
some point in future.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/thanos-io/thanos/issues/2257#issuecomment-630759497,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABVA3OYQA62LKXKNOPCJUITRSJUVJANCNFSM4LF3MXCQ
.


Update LinkedIn Connector to support v2 of API

Hi,
Thank you for creating these connectors, they have been invaluable to me. Recently the LinkedIn connector has stopped working. I'm getting a (410):Gone error message (screenshot attached) and I'm wondering if it's because this is using v1 of the API, which is no longer supported? Can you update this to use v2 please?

You're welcome and thank you for updating me on this issue.
I will plan an update soon

Is there any update on V2 api ?


Compiler support for calling functions

It should be possible to call a simple function from another function.
Example:
func Get() int32 {
  return 10
}
func Main() int32 {
  return Get()
}

Differentiating functions are done by name today, but we should add support for "signatures". For example: Calc(int32,int32)(int32)

I have to decide what I want the signature too be for all types. Thoughts:

Package Name = The name of the package. Example: Game
Package Full Name = Name, including parent package names with a . delimiter. Example: My.Company.Game
Package Signature = Can be considered the same as the Full Name at the beginning. Might change this to File.arlib#My.Company.Game in the future if I want to have support for library files


Improve UndoCommand code quality

https://www.codacy.com/app/evilmtv/main/dashboard
click on error prone

Thanks!


Added specific reference to 'master' version in mom5 and oasis packages

[x] Fixes #152.
[x] Fixed "f-string withoug placeholders" issue with Ruff in oassis.

Hi @atteggiani , Please leave the 'f' strings as-is. I need the to modify the compiler flags more dynamically in the future.

Sorry, just remembered why we shouldn't do this change. We need the first with when() to work with the development branch.


Header improvement

I would like to improve the header bar of your site and make it more user friendly, please assign me this task under hactoberfest tag.

Thanks, @kushaltalati! That sounds great. I’ve assigned this task to you under the Hacktoberfest tag. Looking forward to your improvements!


fix: set timeout for subprocess for update ticket krb

Maybe it's worth adding separate note in sphynx docs about kerberos-related problems and fixes for specific versions of librdkafka.


feat: support GatewayAPI multi tenant capabilities

Please describe the Improvement and/or Feature Request

Scope (please mark with X where applicable)

New Functionality          [ ]
Install                    [ ]
SMI Traffic Access Policy  [ ]
SMI Traffic Specs Policy   [ ]
SMI Traffic Split Policy   [ ]
Permissive Traffic Policy  [ ]
Ingress                    [ ]
Egress                     [ ]
Envoy Control Plane        [ ]
CLI Tool                   [ ]
Metrics                    [ ]
Certificate Management     [ ]
Sidecar Injection          [ ]
Logging                    [ ]
Debugging                  [ ]
Tests                      [ ]
CI System                  [ ]
Demo                       [ ]
Project Release            [ ]

Possible use cases

both AllowedRoutes and ReferenceGrant are supported


Option to hide scroll bar in buffers that fit on screen

I'd like the scroll bar to only be shown when I would need to scroll to see something that isn't on screen. This could probably be done with some clever configuration once #10 is implemented, but to me, this seems like a sensible option to bake in.

This sounds like a good idea. Definitely a sensible option that should just be baked in

That'd be my preference - this is how VS Code behaves with the minimap disabled

Done


Add READMEs based on the respective webpages

This README files are based on the redscientist webpages. Adding the two files will help users recognize the source, understand it, and help contribute to it.

@ircluzar I have now added a README for the Windows Glitch Harvester.


feat(Performance): Add redis support

Don't you need some kind of settings.php changes to make this actually working?

Oh yeah. That and enabling the module. However the build is acting up again


store/event/lock placeholder

@velvia I was hoping you could help scope what we plan to get done by DevNet time :)

Oh got it.  Yes absolutely, will be added soon.

On Apr 26, 2022, at 8:57 AM, Xun Li @.***> wrote:
@velvia https://github.com/velvia I was hoping you could help scope what we plan to get done by DevNet time :)
—
Reply to this email directly, view it on GitHub https://github.com/MystenLabs/sui/issues/1562#issuecomment-1109970113, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIDPW5HNVPRONH2GMAQ5IDVHAG5LANCNFSM5UHOVDZQ.
You are receiving this because you were mentioned.

@velvia Please take a look and flesh out more details on the plans/issues in this domain. Thanks!

@lxfind yes 100% but dev.net deploys is taking up all my spare time.

Done.

FWIW I have roadmap of Storage related tasks here: https://www.notion.so/mystenlabs/Sui-Storage-Roadmap-Tasks-Timeline-b68bfedcfefc42c6a96e39af983c2c67


ElectronicCats

We are trying to get some watchdog around the communication between the node and the gateway.
To get this working, we are monitoring getRssi(), and although any case, the response of this method is always the first rssi witch got when the node was joined for the first time.
We tryed to get that information about the status of the communication with the method join() and, we understood that the node always would return 1, because it was already joined at the initialization time.

Hi @gpaul-dev !
Thank you for contacting us!
Our library as its descriptions indicate is a simple LoRaWAN library able to modify a few settings as the frequency. If you are using a third-party library to get some information about the status of the connection we are not capable of providing you support since we don't have the knowledge.
Hope you are having a nice day!


Leaf nodes changes

Codecov Report

Merging #483 into release-2.2.0 will increase coverage by 0.01%.
The diff coverage is n/a.

@@                Coverage Diff                 @@
##             release-2.2.0    #483      +/-   ##
==================================================
+ Coverage            31.99%     32%   +0.01%
  Complexity            1210    1210
==================================================
  Files                  172     172
  Lines                15116   15116
  Branches              2396    2396
==================================================
+ Hits                  4836    4838       +2
+ Misses                9557    9555       -2
  Partials               723     723

Impacted Files
Coverage Δ
Complexity Δ

...p/searchindex/elasticsearch/ElasticSearchUtil.java
48.61% <0%> (+0.55%)
51% <0%> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01d3d93...85f351a. Read the comment docs.


Cannot use Faker::String with v1.8.7

I cannot access Faker::String.
require 'faker'

Faker::String

returns this error:
NameError: uninitialized constant Faker::String
Did you mean?  String
               StringIO
               StringScanner
               STDIN

ruby 2.3.3

When I cloned the repo and load the app in irb using require './lib/faker', I was able to get a random string by running  Faker::String.random.
ruby 2.5.1

#1277

Faker::String hasn't been released yet and I believe we may release a new version soon. Since this is a duplicated issue, I'm closing it. Thanks.


Copy ETH addresses to clipboard

What does this PR do and why?
Adds icon to ETH address tooltips to copy address to clipboard.
Design channel thread: https://discord.com/channels/775859454780244028/930063712444887071
Screenshots or screen recordings
https://user-images.githubusercontent.com/96150256/149033340-310ec0e9-1ed0-49f0-ad95-da36b3fd4b09.mp4
Acceptance checklist

[x] I have evaluated the Approval Guidelines for this PR.
[ ] I have tested this PR in all supported browsers.

@peripheralist thanks done!


Add orientation option for tray module

Add the orientation option for the tray module, giving the ability for vertical trays.

Note: This also sets the direction top_to_bottom by default for vertical bars. This is technically a breaking change, but I imagine nobody actually wants a horizontal tray on a vertical bar.

Add the orientation option for the tray module, giving the ability for vertical trays.
Note: This also sets the direction top_to_bottom by default for vertical bars. This is technically a breaking change, but I imagine nobody actually wants a horizontal tray on a vertical bar.

if it's breaking, don't you have to do ! with conventional commits, eg. feat(tray)!: add orientation option

if it's breaking, don't you have to do ! with conventional commits, eg. feat(tray)!: add orientation option

Absolutely, this slipped my mind. Let me amend that real quick.

Yeah that's fair enough, I'm fine with considering that part a bugfix. I'll amend this later today.


Plug-in architecture for custom scenarios and metrics

It would be nice to enable users to run helm-run using their own scenarios and metrics without having to fork the repository.
Currently this requires the user to fork the repository and add their own scenarios and metrics. They would then register a new run spec function in run_specs.py. This has the following disadvantages:

Packaging: the user would have to maintain a forked repository and merge changes from upstream, rather than simply installing updated packages.
Ease of use: adding a new scenario or metric is a complicated multi-step process that requires understanding and modifying existing code.
Licensing encumbrance: the forked repository would be considered a revision and derivative work of the original, which would trigger licensing requirements; this would make HELM unusable in some corporate environments.
Research code publication: to publish code for a paper, the user would either have to republish their entire fork, or they would have to work with us to merge their fork upstream. Republishing their entire fork makes it hard to understand by paper readers.

Merging: Generally, merging new scenarios is slow because we're busy and this is usually lower-priority. Also we may reject merge requests that are not generally useful enough, or take on too many additional dependencies.

Ideally, a user would just pip install crfm-helm, and then write their own module that contains their own scenarios and metrics.
We already use ObjectSpec for scenarios (ScenarioSpec) and metrics (MetricSpec), and ObjectSpec allows HELM to load any scenario or metric that is discoverable by Python. Therefore, the user can define their own module that contains their custom scenario or metric classes, and these scenarios and metrics would be usable by setting the class name in ObjectSpec to the user's classes.
The problem is that currently there is no way to run a RunSpec containing the ObjectSpec with the custom classes, so we need an API for that. My suggestion would be to have a @run_spec_function decorator, which will be used as such:
@run_spec_function("myscenario")
def get_myscenario_spec(myparameter) -> RunSpec:
    scenario_spec = ScenarioSpec(
        class_name="mymodule.MyScenario",
        args={"myparameter": myparameter},
    )
    metric_specs = [MetricSpec(class_name="mymodule.MyMetric")]
    return RunSpec(
        name=f"myscenario:myparameter={myparameter}",
        scenario_spec=scenario_spec,
        adapter_spec=get_generation_adapter_spec(),
        metric_specs=metric_specs,
        groups=["myscenario"],
    )

Then a user could run helm-run --local -m 10 --suite custom --run-specs myscenario:myparameter=42,model=openai/text-davinci-002 --run-spec-function-modules my_run_spec_functions, where my_run_spec_functions is the module containing get_myscenario_spec.

cc @percyliang @teetone
This is the writeup for the plug-in scenario / metrics idea that I brought up yesterday.

Thanks, this looks good to me!  I think we could also use this mechanism to deal with run_specs.py so that we can split that into multiple files.


Incorrect behavior of LastInsertId

Now LastInsertId returns int64(0) and error with message that propose to get last sequence value but not ID of element that inserted at last transaction.

Hey, thanks for opening this issue.
What do you propose to be the expected behavior? According to https://golang.org/pkg/database/sql/driver/#Result, LastInsertId should return the last value of the auto generated value. In Phoenix, auto generated ids are implemented as sequences(https://phoenix.apache.org/sequences.html). However, the server does not provide a mechanism to return this value, and the only way to get this value is to SELECT from the sequence.
Unfortunately, this is not something that can be easily automated, because the sequence is separate from the table, and the name of the sequence is selected during the UPSERT by the user.


Build failure during the PDF slides build

https://github.com/lesteve/scikit-learn-tutorial/issues/23

superseded by #22.


proposal: x/exp/maps: Shrink

I propose to add, to partially address #20135 and #19094 (and the many external issues linked in those discussions), a Shrink function to x/exp/maps[^1] with the following semantics:
// Shrink attempts to shrink the provided map to release unneeded memory.
// It can be used by applications when they expect the map to not
// significantly grow in the near future.
// Shrink never modifies the contents of the map, only its internal capacity.
// Whether the map is shrunk depends on the runtime and the internal
// state of the map (including e.g. how big and full the map is).
// Large, mostly-empty maps are likely to be shrunk, whereas mostly-full
// maps are unlikely to be shrunk.
// No concurrent read or write operation should be performed on the map
// by other goroutines during a call to Shrink.
func Shrink[M ~map[K, V], K comparable, V any](m M)

As an initial implementation, Shrink would likely just check if any of the following conditions is true, in which case it would perform the appropriate action:

the map is mostly empty (e.g. average load factor < 6.5/4) -> appropriate action: clone map and assign in-place
the map is growing -> appropriate action: complete map growth

In the future, this may be potentially extended to consider memory pressure, or alternatively turned into a no-op if the runtime were to fully address both #20135 and #19094 (although even with those implemented, Shrink could still be used to handle the case of a map that receives no reads and writes).
Users today can either use Clone or perform a manual clone operation of an existing map, but they have no visibility over the internal state of the map, so they can not know whether doing so will actually decrease memory usage, or if they are just wasting CPU cycles. Users could approximate this by manually keeping track of the high watermark and comparing it to the current length of the map, but this 1) can be quite difficult to do, as all map writes need to be instrumented and 2) it still does not address the "map is growing" case.
With the proposed addition, users could instead periodically simply call Shrink when the map is not in use to ensure that memory is not leaked. Note that this proposal also addresses the case in which a map stops receiving writes (or reads+writes) completely (that would not be covered by any existing or proposed built-in runtime mechanism, as they all require at least some operation to piggyback on).
[^1]: While this would be exposed in x/exp/maps, it will likely require the bulk of the implementation to be in runtime.

Currently the maps package has no package dependencies. Presumably the implementation of this would at least require unsafe and possibly some hooks into runtime as well, right?

I think I'd rather fix #20135 and #19094, then we wouldn't need this.

I think I'd rather fix #20135 and #19094, then we wouldn't need this.

Definitely agree that directly fixing the underlying issues would be better, but it's also true that the issues have been opened for years, and there seem to be no consensus on how to proceed (or even whether we can proceed).

Presumably the implementation of this would at least require unsafe and possibly some hooks into runtime as well, right?

I think the simplest way is to implement it in runtime, and just expose it via x/exp/maps. This would require a single method (AFAICT no hooks) to be exported via go:linkname from the runtime and into x/exp/maps (and you are correct, this would require importing unsafe in x/exp/maps)
This proposal should be seen as an effective intermediate step, as it offers a clean way forward even if at a later date we actually fix #20135 and/or #19094.

and there seem to be no consensus on how to proceed (or even whether we can proceed).

Shrink-on-delete seems straightforward, we just need someone to implement it. Josh already checked in most of the mechanism needed for the tooManyOverflowBuckets change. "can" = yes, "how" = allocate a person to it.
Grow-on-read seems harder, but I don't see any obvious blockers. We'd need a design sketch first, I think, before "can" is certain. Once we have that, "how" is again people-limited.

Shrink-on-delete seems straightforward, we just need someone to implement it. Josh already checked in most of the mechanism needed for the tooManyOverflowBuckets change.

My interpretation of Josh's comment was the opposite, i.e. that the mechanisms needed for the tooManyOverflowBuckets were unlikely to help with #20135.
As an additional hurdle, mapclear currently does not change the bucket count. Would the fix for #20135 change this, even though #20138 explicitly argued against changing the bucket count?
And, while I haven't given this too much thought, I can imagine some tricky tradeoffs when dealing with how to deal with the case of a map that starts growing in the middle of a shrink operation.
Mind you, I am not saying these are insurmountable issues, or that this proposal is an actual alternative to solving them properly. I am just arguing that it has been 5+ years, and that maybe we shouldn't let perfect be the enemy of good (especially in case good won't hurt us in the future, as we would have an easy way to guarantee compatibility across versions).

I'm just advocating that we've long avoided adding API for situations where we could fix the issue without adding API. I understand that could lead to long delays in getting things implemented, but that's the tradeoff we have historically made. Top of mind recently, see #29951.

My interpretation of https://github.com/golang/go/issues/20135#issuecomment-297490415 was the opposite, i.e. that the mechanisms needed for the tooManyOverflowBuckets were somewhat unlikely to help with https://github.com/golang/go/issues/20135.

It is a good question. I remember when reviewing that change that it seemed applicable to me. Maybe Josh was seeing something I didn't.

As an additional hurdle, mapclear currently does not change the bucket count. Would the fix for https://github.com/golang/go/issues/20135 change this, even though https://github.com/golang/go/issues/20138 explicitly argued against changing the bucket count?

That is a good point. We probably don't want to shrink if people do the map clear idiom + reinsert a new set of stuff. Perhaps we only start shrinking after 2N operations, so that N delete + N add involves no shrinking. There's definitely a tradeoff here between responsiveness when you use fewer entries and extra work that needs to be done to regrow.

And, while I haven't given this too much thought, I can imagine some tricky tradeoffs when dealing with how to deal with the case of a map that starts growing in the middle of a shrink operation.

I suspect we could deal with this the way inserts work. When we grow from capacity N to 2N, we do enough work at each insert that the grow work is guaranteed to be done by the time the number of entries reaches 2N.
Similarly, when there are fewer than N/4 entries in an N-capacity map, we could shrink to capacity N/2. If we move at least 1 of the N/4 entries on each subsequent operation, then we're guaranteed we won't exceed our new N/2 capacity before the shrink is done. And if we move 2 entries per operation, and we could guarantee that the shrink is done before we'd want to shrink again (@ N/8 entries in our new N/2 capacity map).

On the topic of capacity, and intersecting with the previous point, what should the map do with a map with a high hint while it's growing? What if the hint was too large, and the map length never reaches anywhere close to that capacity hint?

I think this is a case of tuning a heuristic. We do at some point need to give up on the hint and start shrinking. (I guess the other option is to always respect the hint, but I think that overassumes accurate hints.)
We may need to remember the hint for a period of time. But maybe that's not necessary.  Maybe as long as inserts, or (inserts-deletes), are happening at a sufficient positive rate, we don't shrink.

Lastly, how do we plan to ensure that the fix for https://github.com/golang/go/issues/20135 won't hurt workloads some people may care about, especially since there may be no available workaround for them?

It's going to hurt someone, I'm not too hung up on that. Performance optimization is seldom a win-win. I'm looking for something as good or better than an 80% win / 20% lose.

It sounds like we believe this need can be addressed with better tuning, rather than adding new API. That would suggest we should decline this proposal. Do I have that right?

This proposal has been added to the active column of the proposals project
and will now be reviewed at the weekly proposal review meetings.
— rsc for the proposal review group

Based on the discussion above, this proposal seems like a likely decline.
— rsc for the proposal review group

No change in consensus, so declined.
— rsc for the proposal review group


Audit all use-case connections between Flutter systems and iOS framework

Audit all use-case connections between Flutter systems and iOS framework

I believe this is better captured under some of the issues I've opened, but please let me know if you had something else in mind for this.


Load image from USB input source

Describe the bug
Unable to switch to USB on a Samsung TV (UN70TU7000BXZA) with Tizen firmware using the following service.
Environment details:

Home Assistant version installed: 1.19.3
Component version installed: 0.4.11
TV model: UN70TU7000BXZA

I don't have any configuration options in the configuration.yaml file.  Do I need to?

ST_USB is not a valid SmartThings key.
The only way that you should try to select the USB input could be creating a Key Chaining pattern.
Please close this issue if you don't have additional requests.


$Diff not working with intersection type

Consider this example snippet:
type X = { a: number };

type Y = { b: boolean };

type Z = {
    a: number,
    b: boolean,
    c: string,
};

type Provided = X & Y;

type W = $Diff<Z, Provided>

const inst: W = {
    c: '123',
};

tryflow.org
The above snippet fails the type-check complaining that inst don't have a property b defined.
The error seems to dependent on the order in which we create the intersection type, as changing to type Provided = Y & X; get it to complain about a missing property a instead.
Removing the intersection (type Provided = { a: number, b: boolean };) makes the code behave as expected.

I noticed that if we use $Diff<$Diff<Z, X>, Y> instead of $Diff<Z, X & Y> it seems to work as expected.
Not suitable for all scenarios, but helped in my use case.

Flow-maintainers, I'm interested in contributing in my spare time, any direction to the fix for this bug would be welcome.

No longer replicable on master branch. Nice!


Option to enable right mouse click using control or command + click

It seems right mouse click on a (single click configured mouse) is not possible on macOS host using qemu guests.
I am able to right click using my touchpad on the macBook with a two-finger-click.
It would be nice to have an option to enable a "more macOS native way" to have a right click available inside the guests using control or command + left click.
If it is not possible to implement as a feature option it would be nice to know how to enable this with a qemu option. I was looking around and could not find a solution.
Thanks

Thanks, this option is disabled on purpose as we all use control Keyboard click + mouse click to have a right mouse click.
It would be nice to see this implemented as option or always enabled as this works on all macs regardless if using mouse, internal or external trackpad.
Can this be enabled with a qemu option?
Thanks

Thanks, this option is disabled on purpose as we all use control Keyboard click + mouse click to have a right mouse click.
It would be nice to see this implemented as option or always enabled as this works on all macs regardless if using mouse, internal or external trackpad.
Can this be enabled with a qemu option?
Thanks

@osy Thanks a lot.
Works in Windows10.
Unfortunately it does not work in Archlinux guest. Two Finger Trackpad click works but ctrl+click does not work.
Thanks for reopening the issue and looking into it again.

Is this console mode?

@osy ok, I just re-checked. It is working everywhere but on the right click on the desktop in openbox to bring up the menu.
It works in every app using openbox but it does not work using it clicking on the desktop.
I use the same vdi image in virtualbox and it works without re-configuring anything.
I had a look at the configuration and the options. Everything seems fine.
Do you think it's something you can fix?
I searched and tried different solutions but could not get it to work to click on the desktop and bring up the openbox menu.

I case my previous post was not clear. In general the right mouse click using control+ click works in linux.
But it does not work bringing up the openbox menu when clicking on the desktop.

Two-Finger click on the trackpad on the desktop works and brings up the openbox menu.

I suspect what’s happening is the Ctrl+Right click is being inhibited by open box. I translate Ctrl+left click to ctrl+right click but because I can’t stop the Ctrl event from firing before the left click is translated, you get Ctrl+right click. Is there anything you can do on the VM to check raw mouse+keyboard inputs and see if this is the case? If so I don’t know if there’s a good way around it without delaying keyboard events.

Sorry, I don't know how to check that. Would it help to just use command + click instead of control + click? This is the way it works on virtualbox.

It doesn’t change the fact that Linux will see both the keyboard key AND the mouse click. I would advise you to configure Linux to ignore the Ctrl key. I’m sure there’s someone out there who’s done that.
Cmd key probably works because it happens to be ignored by default. Anyways all this is outside the scope of UTM/QEMU and I advise you seek help from openbox support community.

I searched through a lot of possibilities tonight and could not find a solution after hours. Would it be a lot of work to duplicate the control + click option and also allow command + click? I think a lot of people are used to use this who used virtualbox before.
I would really like to see if this is working. Thanks a lot.
Appreciating all the great work.

Sorry I’m not going to make a new feature for every edge use case. This is definitely possible to do on Linux side. You can ask for help there.