Deleting a type that doesn't exist returns Internal Server Error

I'm submitting a ...

[X] bug report
[ ] new feature / enhancement request
[ ] improvement request (usability, performance, tech debt, etc.)
[ ] other

Traffic Control components affected ...

[ ] CDN in a Box
[ ] Documentation
[ ] Grove
[ ] Traffic Control Client
[ ] Traffic Monitor
[X] Traffic Ops
[ ] Traffic Ops ORT
[ ] Traffic Portal
[ ] Traffic Router
[ ] Traffic Stats
[ ] Traffic Vault
[ ] unknown

Current behavior:

When making a DELETE request to types/{id} where the id doesn't belong to any existing type the response returned is:
HTTP/1.1 500 Internal Server Error
Content-Type: application/json
{
    "alerts": [
        {
            "text": "Internal Server Error",
            "level": "error"
        }
    ]
}

Expected / new behavior:

Should return:
HTTP/1.1 404 Not Found
Content-Type: application/json
{
    "alerts": [
        {
            "text": "no type found with this id",
            "level": "error"
        }
    ]
}

Minimal reproduction of the problem with instructions:

Anything else:

Error logs show:
ERROR: api.go:180: .... sql: no rows in result set

Fixed the Internal server error in delete types by invalid id.
DELETE: https://localhost/api/4.0/types/42222
Response:
{
"alerts": [
{
"text": "no type with that key found",
"level": "error"
}
]
}
Status Code: 404 Status Not Found


Feat/timer icon

Purpose

Add timer icon for WebSDK

Approach
Detail the approach (How?)
Testing
Describe the testing performed to verify the change. (or N/A)
Risks
Any significant risks, e.g. customer impact, backward compatibility, new tech debt. (or N/A)

Duplicate, apparently, as timer is already available.


[WIP] 2092 annual survey csv

Resolves #2092
Description
This is an updated version of PR #2565. That PR includes some work in progress for a number of other issues that are sub-tasks of #2073 . I've left that code in for now, some of it commented out, to focus on the overall framework and the functionality of the first report (which is also the largest). The relevant report is acquisition_report_service.
There are also some updates to the installation instructions I came across.
For now this PR is in progress - I still need to work on specs, but I wanted to put it up to get feedback on the approach.
Type of change

New feature (non-breaking change which adds functionality)

How Has This Been Tested?
With specs and local testing. The new page is behind the reports feature flag, under "Reporting and Auditing -> Annual Survey".
Screenshots

Thanks for the great feedback! I can't take all of the credit or the blame for this, since about 70% of it came from the original PR by @patmccler . I'll definitely look at persisting this as a saved report, and seeing if I can detect any N+1 issues (bullet should do that for me I believe?) I'll also clean up / implement the remaining specs.

I've made the reports into a model and added a "Recalculate" route if necessary. Specs are also complete. Ready for review!

So very awesome!

Very happy to see this picked up - thanks @dorner !


Always enable clustering

Resolves https://github.com/apple/swift-distributed-actors/issues/880

Seeing Fatal error: Somehow attempted to load system.cluster before it was initialized! in different tests and not sure how to track down the cause.

Seeing Fatal error: Somehow attempted to load system.cluster before it was initialized! in different tests and not sure how to track down the cause.

I've seen that a few times and track it as https://github.com/apple/swift-distributed-actors/issues/840
It is about the actor starting "early" before the cluster var is initialized; this should not ever happen, so I'll look into it. If you see that failure ignore it for now

Actually let's merge -- and I'll fix one test after this


Remove arithmetic optimizer to keep Reshape op in the output graph.

Fix #14

This PR is more of a tentative fix until the optimization issue in TensorFlow.js converter is fixed. Let's hold this from merging to master until we get clear ETA for the upstream issue.


PHP SDK for Tenable.io

A customer has indicated potential use cases for a direct integration of Tenable.io if a PHP SDK were made available

This request has been noted by Tenable Product Management.


Change variables spelled *Lenght to *Length

@TopherLee513 Thanks for the fix!

My pleasure. Glad I could help, even this tiny bit. Thank you for everything you do for the community. :D


add mutation set and mutation schema to kwargs-syntax

Also mutation delete.

mutation set and mutation schema add in commit b45e4bb

added mutation delete in 87c76f3
test "mutation set works" do
    assert mutation([
      set: %Person{
        name: "jason",
        age: 33,
      }
    ])
    |> render
    |> clean_format == clean_format("""
      mutation {
        set {
          _:person <name> \"jason\"^^<xs:string> .
          _:person <age> \"33\"^^<xs:int> .
        }
      }
    """)
  end

  test "mutation schema works" do
    assert mutation([
      schema: Person
    ])
    |> render
    |> clean_format == clean_format("""
      mutation {
        schema {
          name: string .
          age: int .
          works_at: uid .
        }
      }
    """)
  end

  test "mutation delete works for a field" do
    assert mutation([
      delete: field(uid("1234567"), "*", "*")
    ])
    |> render
    |> clean_format == clean_format("""
      mutation {
        delete {
          <1234567> * * .
        }
      }
    """)
  end

  test "mutation delete works for tuple of fields " do
    assert mutation([
      delete: {
        field(uid("1234567"), "*", "*"),
        field(uid("1234567890"), "*", "*"),
      }
    ])
    |> render
    |> clean_format == clean_format("""
      mutation {
        delete {
          <1234567> * * .
          <1234567890> * * .
        }
      }
    """)
  end

  test "a complex mutation" do
    assert mutation([
      delete: {
        field(uid("0x123"), :name, "Jason"),
      },
      set: %Person{
        name: "Not Jason",
      },
      schema: Person,
    ])
    |> render
    |> clean_format == clean_format("""
      mutation {
        delete {
          <0x123> <name> \"Jason\" .
        }
        set {
          _:person <name> \"Not Jason\"^^<xs:string> .
        }
        schema {
          name: string .
          age: int .
          works_at: uid .
        }
      }
    """)
  end


i3lock-fancy: 2016-05-05 -> 2016-10-13

Motivation for this change
Update
Things done

[X] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[X] NixOS
[ ] OS X
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[X] Fits CONTRIBUTING.md.

Merged in 5e1c84e.


kmeans

I get this error when training on the Tamil treebank:
File "/project/piqasso/tools/biaffine-parser/parser/utils/alg.py", line 18, in kmeans
assert len(d) >= k, f"unable to assign {len(d)} datapoints to {k} clusters"
AssertionError: unable to assign 25 datapoints to 32 clusters
With the debugger I found that in the invocation of kmeans(x, k)
with len(x) = 80, k = 32
at line
10  	    d, indices, f = x.unique(return_inverse=True, return_counts=True)
d = tensor([ 6.,  7.,  8., 10., 11., 12., 13., 14., 15., 16., 17., 18., 19., 20.,
21., 22., 23., 24., 26., 27., 32., 33., 35., 45., 51.])
len(d) = 25
f =tensor([4, 1, 1, 5, 1, 7, 6, 4, 8, 8, 2, 2, 1, 8, 5, 2, 1, 2, 3, 3, 1, 2, 1, 1, 1])
len(f) = 25
With other treebanks it work fine.
Thank you for the nice and useful project.

Hi, thanks for reporting this issue.
This is because the sentence lengths are uniformly distributed, and sentences can only be assigned to no more than 25 buckets (as shown in the error log).
You can fix this error by setting a smaller number of buckets, e.g., --buckets=16.


Header reloading issue on login/logout

Want to work on this issue

Great! This issue is caused to use KeyManager.isLoggedIn() and KeyManager.getPubkeyKey() in Header and Menu components. These methods should be observable.


Add Tag type

This relates to Issue #178.
I'm still trying out a few ideas, but I figured I should get this up now for review and for CI purposes.

Ok, I think I'm done playing around with this. The final commit is a bit of an experiment to compare having a full Tag class, as opposed to a simple using Tag alias. It adds a bit more code to do it that way, and the result is largely similar, though it does perhaps lead to a cleaner global namespace, and allow some additional conveniences, such as automatic conversion to std::string.

I added the new source code files to the VS project files so the tag test cases are running now on MSVC builds. I've tested by extracting from and creating both CLM and VOL files. No problems noticed yet.
I still need to test creating/reading bitmap files since this code affects bitmaps.
I ran into another bug in XFile that I will push before continuing testing. Bug is unrelated to the TAG code, just found it when testing.
-Brett

When I fixed the merge conflicts I used notepad++ instead of VS, so probably my fault on the spacing.


Improve docs for BlockUntil and waiters

The docs don't sufficiently explain the behavior of BlockUntil, at least when it comes to using Timers and Tickers.
I've found the behavior of BlockUntil for After and Sleep to be intuitive due to their blocking nature.
I'd be pleased to take a stab at contributing these improvements, but I wanted to check-in first to get a read on the attitude of the maintainers towards both the behavior of BlockUntil, and general documentation philosophy.
Existing Documentation
Here are the existing references to BlockUntil in the docs:

// BlockUntil blocks until the FakeClock has the given number of waiters.

Users can call BlockUntil to block until the clock has an expected number of waiters.

Here are the existing references to waiters in the docs:

// Advance advances the FakeClock to a new point in time, ensuring any existing
// waiters are notified appropriately before returning.

FakeClock maintains a list of "waiters," which consists of all callers waiting on the underlying clock (i.e. Tickers and Timers including callers of Sleep or After).

Example of Undocumented Behavior
When I was recently using BlockUntil with Timer, I discovered that creating a NewTimer immediately created a waiter, rather than say, the call to the Chan. When I went to the docs to understand more, it was hardly discussed.
Here's some example code that I initially found unexpected, which I'd like the documentation to explain:
fakeClock := clockwork.NewFakeClock()
timer := fakeClock.NewTimer(5 * time.Second)
fakeClock.BlockUntil(1) // does not block because NewTimer created a waiter

Similarly, explaining how Stop deregisters a waiter, and Reset reregisters it again.
Again, for Tickers I haven't tested it, but my understanding is that a Ticker behave similarly wrt to Stop and Reset.
Suggested Improvements
Doing all of the following may be overkill, but here are some ideas:

Add a few sentences defining waiters with respect to the different operation on Timers and Tickers.
Add a warning/note that BlockUntil doesn't consider calls to Chan, and only reacts to construction/Stop/Reset.
Add example code documenting the use of BlockUntil for each operation (e.g., Sleep/Await, NewTimer, NewTicker, Stop, and Reset).
Discuss the implications of the BlockUntil behavior.

Timers are ideally constructed in the test's main thread to ensure potential future Advance calls don't race with construction (but that BlockUntil can be used to wait for the construction of Timers and Tickers).
BlockUntil is not sufficient to test Timers (e.g., unable to distinguish between before the Stop call and after the Reset call).

Despite being a maintainer, I don't particularly love BlockUntilContext, because in concurrent code it can be racey. I have not found a great way to use it in my own complex code.
That said, "Add a warning/note that BlockUntil doesn't consider calls to Chan, and only reacts to construction/Stop/Reset." is intentional per the comment on FakeClock. Chan() can't be considered a isn't a waiter, consider: If a single Timer has 2 callers of Chan() this is only 1 only 1 will receive the time on expiration, therefore there is only 1 waiter, regardless of the number of callers of Chan().
I'm supportive of updating/improving the documentation around BlockUnitl, Stop(), and Reset(), but I don't think we need to warn that Chan() is not waiter, because it cannot be.

because it cannot be.

That's intuitive to you because you're a maintainer, and it might be reasonable to assume that most Go programmers would be able to conclude this as well. I'd suggest it's our job as documentation writers to help users of varying experience to build the right models to use our libraries effectively, so I'd personally lean towards explaining this.
I might have time in the comings while to contribute updates to the docs, not sure yet. Thanks for all your hard work.

Make sense. I admit I have a lot of... I guess the term is "maintainer bias"(?) Happy to accept contributions, particularly on documentation because of that bias.


⚠ Bofrost.at has degraded performance

In 8e0fbb4, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1886 ms

Resolved: Bofrost.at performance has improved in f3c8831 after 19 minutes.


add fuzz target for 'image' crate

https://github.com/PistonDevelopers/image
there are multiple formats it can read, so we'll probably want a different fuzz target for each format. those can be separate PRs

Maybe it's better to fuzz the underlying libraries where possible? https://github.com/PistonDevelopers/image/blob/59cf88a704bf13e0e2d7c02003ed2e54f7e6c9bb/Cargo.toml#L31-L41


feat(core)!: remove no merge control

Previously, the CONTROL_SHORTCUT_NO_MERGE was added to address shortcut merging with rules that have "base" properties (#429) like transforms, filters, etc. Now that those rules are refactored to use separate layer (#1028, #1033) this control is not necessary inside the core anymore.
The breaking change is for developer/user that use the control in their codebase. This can closed too if the control is deemed necessary.

I see there is no harm to keep supporting it, an escape hatch is better than not being able to do. Thanks.


feat: use existing timestamps when available

When an integration such as Flex generates an event that contains a timestamp do not overwrite the timestamp.
If the timestamp is nil generate the timestamp with time.Now().Unix() as it does currently.
Tested changes with a custom build of the agent, functionality works as intended.
cc/ @carlosroman @jfjoly @fryckbos

replace field check to avoid panicking https://github.com/newrelic/infrastructure-agent/pull/29/files#r448923627

@varas replace field check with what? I don't understand your request, If the timestamp key is not present it is nil which is the whole point of that check.


[BUG] Generated files for spark350db143 are missing and incomplete

Describe the bug
/tools/generated_files/350db143 should contain supported CSV files. It is missing operatorScore.csv, supportedExecs.csv, supportedExprs.csv, and the only existing supportedDataSource.csv in the folder is empty. These files should be automatically generated by the build.

@cindyyuanjiang if it is for 24.12 , DBR 14.3 is not building for the release. It will "come back" for 25.02 #11749

Closing as dup of https://github.com/NVIDIA/spark-rapids/issues/11749


Invalid prop type supplied to Accordion. Expected single when defaultValue or value is type string.

Bug report
Current Behavior
Switching the accordion type type="multiple" will throw the warning. Completely reproducible in the actual codesandbox.
Expected behavior
No warning.
Reproducible example
[CodeSandbox Template](https://codesandbox.io/s/summer-browser-qmlzki?file=/App.js)
Suggested solution
Clearly this condition is met: https://github.com/radix-ui/primitives/blob/main/packages/react/accordion/src/Accordion.tsx#L70 but I am not super clear how it falls into that condition.
Additional context
N/A
Your environment

Software
Name(s)
Version

Radix Package(s)
@radix-ui/react-accordion
1.1.0

Didn't realize the default value has to be an array when we use multiple.


fix obfuscator not capturing secretkey and keytab

Codecov Report

Merging #7794 (ddfd4c8) into master (d1606cd) will decrease coverage by 57.04%.
The diff coverage is 50.00%.

:exclamation: Current head ddfd4c8 differs from pull request most recent head 41d44ff. Consider uploading reports for the commit 41d44ff to get more accurate results

@@              Coverage Diff              @@
##             master    #7794       +/-   ##
=============================================
- Coverage     71.66%   14.62%   -57.05%
+ Complexity     4083       80     -4003
=============================================
  Files          1578     1533       -45
  Lines         80639    78772     -1867
  Branches      11986    11784      -202
=============================================
- Hits          57790    11518    -46272
- Misses        18956    66411    +47455
+ Partials       3893      843     -3050

Flag
Coverage Δ

integration1
?

integration2
?

unittests1
?

unittests2
14.62% <50.00%> (+0.03%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...in/java/org/apache/pinot/spi/utils/Obfuscator.java
0.00% <0.00%> (-82.76%)
:arrow_down:

...on/tasks/mergerollup/MergeRollupTaskGenerator.java
75.32% <75.00%> (-10.30%)
:arrow_down:

...ain/java/org/apache/pinot/core/data/table/Key.java
0.00% <0.00%> (-100.00%)
:arrow_down:

.../java/org/apache/pinot/spi/utils/BooleanUtils.java
0.00% <0.00%> (-100.00%)
:arrow_down:

.../java/org/apache/pinot/core/data/table/Record.java
0.00% <0.00%> (-100.00%)
:arrow_down:

.../java/org/apache/pinot/core/util/GroupByUtils.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...ava/org/apache/pinot/spi/config/table/FSTType.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...ava/org/apache/pinot/spi/data/MetricFieldSpec.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...va/org/apache/pinot/spi/utils/BigDecimalUtils.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...java/org/apache/pinot/common/tier/TierFactory.java
0.00% <0.00%> (-100.00%)
:arrow_down:

... and 1251 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1606cd...41d44ff. Read the comment docs.


Autocomplete not working as expected

From @lejun on September 3, 2016 16:5

VSCode Version:1.4.0
OS Version:mac os 10.11.5

Ready to work:
typings install --global --save dt~react
typings install --global --save dt~react-native

tsconfig.json
{
    "compilerOptions": {
        "target": "es6",
        "module": "es6",
        "jsx": "react",
        "outDir": "built",
        "rootDir": "src",
        "sourceMap": true,
        "noImplicitAny": true,
        "allowJs": true,
        "allowSyntheticDefaultImports": true
    },
    "filesGlob": [
        "typings/index.d.ts",
        "typings/globals/**/*.d.ts",
        "src/**/*.ts",
        "src/**/*.tsx"
    ],
    "exclude": [
        "node_modules",
        ".vscode/launchReactNative.js",
        "built",
        "index.android.js",
        "index.ios.js"
    ]
}

example:
1.
import * as RN from 'react-native';
const{View,Text,Navigator} = RN;

import {View,Text,Navigator} from 'react-native';

question:
###Why can normally prompt mode 1, and mode 2 not?
Copied from original issue: Microsoft/vscode#11498

I apologize for the spam. Strange issue on my end with the comment button.

@lejun thank you for opening this issue. To make sure I understand correctly... you are asking why you are prompted to choose Navigator in screenshot 1 but not in screenshot 2?

From @leaxoy on September 10, 2016 15:59
+1

From @lejun on September 7, 2016 1:30
Thank you for your reply.
The screenshot 1 is correctly.(react component). The second method can not be normal prompt.

From @preetb123 on September 14, 2016 9:45
@lejun how are you able to get autocomplete  for ReactNative components, as in the above fig.

From @lejun on September 15, 2016 4:3
@preetb123
import * as RN from 'react-native';
const{View,Text,Navigator} = RN;

@DanielRosenwasser can you advise me and OP on this issue?
There seems to be something strange with the import system. I would expect auto complete to suggest Navigation in both of the above screenshots.

From @DanielRosenwasser on September 29, 2016 18:10
I'm not totally sure why that happens. If VS Code only displays items as returned, and you're using our prefix logic, this might be a bug on us.

I'll move this over then to have help investigating.

@lejun do you have a minimal repo we could copy and paste to test this out? Also can you try this with the latest bits by downloading Insiders?

This looks a lot like https://github.com/Microsoft/TypeScript/issues/4577, can you verify you are still seeing this issue on TS 2.0 or later?

closing for now. please reopen if this is still an issue.


Support non-service account based authentication in the driver pod

Currently we make the driver pod use the service account token that is mounted by Kubernetes into /var/run/secrets/kubernetes.io/serviceaccount/token as well as the certificate file under /var/run/secrets/kubernetes.io/serviceaccount/ca.crt. However, in an internal application we are looking to prefer authentication over user-provided OAuth tokens instead of relying on a service account token.
The proposal is to support a second mode of operation where the driver pod is provided a secret volume containing all of the data provided through  spark.kubernetes.submit.clientCertFile, spark.kubernetes.submit.clientKeyFile, etc. In such a mode, the driver pod authenticates to the Kubernetes API server in the same way the driver launcher process itself does.
An extension of this is to allow the driver pod to use distinct credentials from the driver submission client. The driver submission client currently requires the ability to create and access secrets, create+delete services, and create+delete pods. The driver however has no need for permissions to handle the secrets and the services in the namespace, so presumably the driver can use credentials with the appropriate restricted set of permissions. We can default to making the credentials set identical between the driver submission and the driver itself, resolve the overridden credentials that the driver pod should use, and mount the secret volume with the resolved credentials.

@foxish @robert3005 thoughts on this?


Dashboard does not show the API endpoint URL in the API Keys page

In Cluster Manager, the API Keys page showed the API endpoint and allowed you to copy it to the clipboard.
The new UI does not offer the asme - we should add this in.

Internal reference: SURE-3861
Docs: https://rancher.com/docs/rancher/v2.6/en/api/#how-to-use-the-api
Repro steps:
Navigate to Avatar
Click "Account and API keys"
API endpoint is not present in the UI , but doc says its present

Submitted a PR in the doc with API URL.
Adding it here for backtracking.
https://github.com/rancher/docs/pull/3765


SAMZA-2455: Validate the argument types in SamzaSQL UDF on execution planning phase

@weiqingy Can you please take a look at this PR?

@santhoshvenkat1988  Couple of things that you could look at in future

If adding validations with UDF polymorphism is hard, We could disable/remove it.
May be an end to end planning test UDf type validation test would be great.

Thanks for the review @srinipunuru

I've updated the PR description.
I have added the end-to-end integration test for mismatched SamzaSQL UDF type.
Created a follow-up ticket to disallow the UDF polymorphism.


Cancel an Redo

Hi,
Thanks for this great software. This is really a wonderful tool, although for me, it has several minor problems.
The most missing feature in my opinion is a Cancel command. (And redo would of course be fine to). But the main problem is that although not listed in the doc, Cmd + Z (on a Mac) shuts the current document without any confirmation being asked. (Fortunately, it saves the current state, although this could be unfortunate if this is not what is wanted.) More generally, AsciidocFX lacks the standard interface (menu bar and so on).

Hi @fpinjava ;
Thanks for nice words and suggestions. I didn't know Cmd + Z shuts down the application. What kind of keyboard are you using ? AsciidocFX saves the documents automatically when closing the app or focusing-out the app. This behaviour comes from Intellij IDEA's saving strategy.
Actually we dont have a complex menubar. But, I'm open to all suggestions. What is the most menu actions you need and suggest for AsciidocFX ?
Thanks.

I am using a French keyboard with numeric pad.
A menu bar is interesting because it is like a help system where you can find which commands are available. Anyway, this is much less important than having a an Undo command (I incorrectly called it Cancel).
I have other suggestions:

I would prefer the Hide File Browser command to be similar to the button used to show the File browser, for example letting the button in place, making it a toggle control.

It would be great to have the source pane scrolling when you scroll the preview pane.

When pasting from LibreOffice, the html representation of the text is pasted. It should be raw text, or better, the asciidoc translation.

Pasting from IntelliJ, on the other hand, is converted to asccidoc code bloc. This is ok when pasting into text, but not when pasting inside a code block, which results in nested code blocks.

Numbering chapters don't work, but I suppose this is an asciidoc bug.

Thank you @fpinjava ;

I would prefer the Hide File Browser command to be similar to the button used to show the File browser, for example letting the button in place, making it a toggle control.

Yes, I'm working on new UI scheme for increasign flexibility

It would be great to have the source pane scrolling when you scroll the preview pane.

When you click right side elements, editor will find related Asciidoc component, but we can improve this feature like you said.

When pasting from LibreOffice, the html representation of the text is pasted. It should be raw text, or better, the asciidoc translation

For raw paste, you should use Ctrl+Shift+V

Pasting from IntelliJ, on the other hand, is converted to asccidoc code bloc. This is ok when pasting into text, but not when pasting inside a code block, which results in nested code blocks.

Yes, we can fix it

Numbering chapters don't work, but I suppose this is an asciidoc bug.

For numbering you should add :numbered: attribute to document header.


LG B8 confirmation to allow access

Hello,
I have installed homebridge, added and configured my tv. It is working, but I have this issue that on every initial interaction with it after power cycle (i.e. after electricity being down), on the TV appears confirmation to allow remote access. Once confirmed with physical tv remote, it is not appearing until next power cycle.
Today I got in the situation where I am not at home, I opened Home app and noticed electricity was somewhere during the night. I switched TV on with the idea to check if homebridge is still running on the Mac after reboot. Now I am not able to shut the TV off or do anything with it as that confirmation appeared on the screen (I can see it with my Circle camera). The other problem is that the volume is a bit high and I cannot lower it also...
So I am not in home, TV is on and loud and I cannot do anything until someone confirms with the physical remote :(
Is there a way to permanently allow this and avoid that message?

Hi,
I’m no expert on this or home ridge but it sounds like to me that you’re having an issue with the keyfile, try specifying a specific location in your config file as I don’t think the default address in the example works on mac, it should only work on raspberry pi or linux systems, but again I’m no expert in this but to me it really seems like it lacks the keyfile hence the prompt on each startup.
Hope this helps!

like @perrintong325  said, this is an issue with your keyfile. Most probably the location which you specified has no write rights.


2.8 Delete private event on Sporta [backend]

As a Sporta User, I want to be able to delete a private event I am hosting so I am no longer required to organize it
Story Points:
Priority:
Risk: High
Child of: https://github.com/SOEN490-SportsApp/SportsApp/issues/1
Task Breakdown:
front-end :
backend :
Blackbox Testing:
Regression Testing:
Precondition:

To be successfully logged in to your Sporta account with a valid username and password.
To already be hosting a private event

Demo Steps:
Step 1: Go to Sporta dashboard
Step 2: Click on a specific event
Step 3: Click on the edit event button
Step 5: Click on delete event button
Step 6: Click on confirm delete

Was merged to #81


fix: exit with correct exit code

What does this pull request do?

[x] Bug fix
[ ] Refractor
[ ] Custom

In order to be merged, each piece of this code must be released under public domain or under the Unilicense. Check one of the following options:

[x] I am the original author of this code and I am willing to release it under Unlicense
[ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

LGTM


Only scans 3 characters

Current Behavior
I'll post a picture of my preferences and scanner output below, where you can see I have it set to only scan my characters; however, it initially happened while I was doing a full account scan. Note that it does not report any errors. After one of these bugged scans, it failed to determine the level of the Traveler, but only once. Additionally, it seems to only actually scan 2 characters (skips the first one, Cyno), which can be seen in the screenshot and in the JSONs (posted below).
Expected Behavior
The scanner continues to scan
Reproducing a Behavior
I tried to record a video but OBS and the scanner don't seem to work at the same time.

Device OS
Windows 10
Genshin Impact Version
3.1
Inventory Kamera Version
1.3
Screen resolution, screen mode, and UI scale
1920x1080 fullscreen
Additional notes and remarks
{"format":"GOOD","version":1,"kamera_version":"1.3","source":"Inventory_Kamera","characters":[{"key":"Traveler","level":90,"constellation":0,"ascension":6,"talent":{"auto":2,"skill":7,"burst":8}},{"key":"KukiShinobu","level":70,"constellation":4,"ascension":4,"talent":{"auto":1,"skill":6,"burst":1}}]}
Every JSON reads the same. Also evidenced in the JSONs is an incorrect read on the Traveler's constellation, which should be 5; it did this all 5 times I scanned.
Evidence
No response
Preflight Checklist

[X] I have checked for similar issues in the issue page, and I have not found any similar to mine.
[X] I am using the latest version of the scanner.
[X] I tried setting the scanning delay to maximum, and it still doesn't work.
[ ] I have attached the video recording to the bug report.
[ ] I have attached the error log to the bug report.
[X] I am available to later explains the issue.
[X] I have disabled all screen filtering software or plugins (i.e. HDR, Image Sharpening) while scanning.
[X] I use default in-game keybindings or have configured keybindings for the scanner.

This issue is very old and has likely been resolved.


Optimize collections by caching hashes

This isn't ready for merging, primarily because classes like IdentitySet need a Cell impl without the new keyHash attribute.
For HashSet, the following are results for a benchmark that creates and populates sets with 3M Strings using default values for initialCapacity and loadFactor (16 and 0.75):
Summary min/max/avg/rstddev/pct
Java 50/58/54/6% (100%)
OPT  60/68/64/4% (120%)
SDK  105/126/114/5% (209%)

And for HashMap with the same settings:
Summary min/max/avg/rstddev/pct
Java 52/64/58/7% (100%)
OPT  89/104/93/5% (170%)
SDK  137/156/147/4% (260%)

The results are in nanos per element added.
For #515 and related to #517

Can one of the admins verify this patch? (see README)

Does the JDK also cache hash codes? What is the memory usage comparison before/after this? Trading speed for memory is not always the best thing.

Does the JDK also cache hash codes?

Yes.

Indeed I see that.

@CeylonBuildBot ok to test

Crappy build integration. I wish I could prevent it from adding those definitions contianing the entire issue message, they only cause problems.

Looks like somethings not being quoted somewhere. How does this work for other people using jenkins and ant?

Ok update the plugin, let's see how it does:
@CeylonBuildBot retest this please

@tombentley equally bad https://github.com/jenkinsci/ghprb-plugin/issues/237 ;)

Ok, seems to have worked this time

I really think it would be good to get this work into 1.2.2. @jvasileff?

It's worth noting that while the performance improvement w/this benchmark is clear, I don't fully understand it. We are 1) avoiding redundant hash calculations, and 2) optimizing ==. But java.lang.String already caches hashes, and, as a test, implementing only 2 does not provide the same benefit as this patch.
It's also interesting that the author of Java's collections apparently recommends against this caching. But of course, we're going to be compared to j.u.c's performance in micro benchmarks, and the JDK still does cache hashes.
Finally, there appears be some very strange interactions with JVM optimizations of long vs int (we're using longs, but they are eventually narrowed to int for array access). Altering the hashCode() function (currently h.xor(h.rightLogicalShift(16))) to something like this can result a dramatic and hard to explain degradation of performance. And then anding the result of the alter hashcode with something like #ffff restores the performance. Perhaps part of the remaining performance delta is related.
Overall I think we should merge. But there's also more to explore.

The last two commits restore storage efficiency for IdentitySet, IdentityMap, and LinkedList. I suppose this makes sense, but they could also be rolled back to simplify the code/reduce copy-and-paste.

Should this be merged now for the imminent release of 1.2.2? @jvasileff ?

@quintesse yes, I'm comfortable with this being merged.

Okidokidone

Would this all be simpler if CachingCell extended Cell?

There was a concern about size with the extra field for the hash, and having CachingCell extend Cell would incur a similar size penalty as both would have a field for the reified type parameter. So I went with two independent classes.
If we don't care about an extra 64bits or whatever, we could just have Cell and leave the hashKey field unused when we don't need it.

ok.

BTW, it's very easy to do if you'd prefer just one Cell class. We can just revert the last two commits.

Well, no, I agree that we should try to utilize memory efficiently.


File & folder Chooser permissions on API 19 and Up

Hello there, thanks for this great library :)
There are many app out there (one is mine) which app's permissions are very strict & important !
Referring to Android official documentation when an application request files or folder into its external file directory, permissions are not required since Android Kitkat (Level 19).

Starting in Build.VERSION_CODES.KITKAT, no permissions are required to read or write to the returned path; it's always accessible to the calling app. This only applies to paths generated for package name of the calling application. To access paths belonging to other packages, Manifest.permission.WRITE_EXTERNAL_STORAGE and/or Manifest.permission.READ_EXTERNAL_STORAGE are required.

But regardless of this we are forced to use permissions anyway...
So, i think it is better to just to add an if-else to check for requested path, and if it's the path of calling app don't request Read Permission (or Write Permission for folder creation)
Thanks, best regards

I'm not really sure what you mean. If you're using an OS below Android Marshmallow (API 23), then the permission check should always return true as long as you have the permission declared in your manifest. There is no special case that Material Dialogs should be handling there - if it's returning false that's an OS bug.

@afollestad , thanks for your reply. Sorry for my low English, maybe this is why you don't understand me well. I will try to write a use case for e.x if we want to open file chooser like following
MaterialDialog(this@paneli_kryesor).show {
                    fileChooser(initialDirectory = getExternalFilesDir(null)!!) { _, file ->

                    }
                }

it always check for permission access, and if not found permissions, it crash with message "You should grant read permission first", but in fact as i said in first message according to Android Documentation, permissions are not required for Read & Write access to App's External File Dirs since API 19
So, i mean this library better to make a check to see if the path belongs to the app dir itself, and if so, skip permission check.
If you still don't understand my low English, i will try to attach a very sample project to make you understand better.
This is very important in some cases when we need this library support without permissions, if only call app's internal/external directories

But again, KitKat doesn't use runtime permissions. So the permission check that Google provides should always return true on KitKat. I don't want to add condition special cases for API 19 in my code.

@afollestad , you are still not understanding me. Runtime permissions required from Android 6 and Up. And i said from Android 16 (KitKat) and Up permissions are not required for App internal or external directories. You don't have to add special condition. Just you should check if the path is about app's directory just skip. If it is not directory of app you can request as normal.
If you have to open a chooser within app private directory or app's external directory no need for permissions. Are you understanding me or not ?
If you open a chooser in that place no need for permission check. Anyway i have to edit this lib myself but it is very weird that you are not getting me

That's a special case. If you do not do a check for the app directory, a check would have to be done later if the user goes out of an app directory.
You don't need to fork the library, just make a custom view dialog.


Integration with huggingface

If somehow we can integrate this with hugging face models while doing inference then its job is done for production-level deployments.

Agreed. Will work on it when I have the time.


Ambiguity in Operation.message field

Hi everybody,
I've intercepted a possible ambiguity and un-clarity within the specification (2.1.0) regarding Operation.message fixed field.
Type of Operation.message fixed field is defined as [Message Object | Reference Object] which means that the field is going to be a list and either Message Object or Reference Object is allowed within it.
Inconsistent description
First sentence in the description then says A definition of the message that will be published or received on this channel. Other fields descriptions containing list of union types start with following sentence: A list of .... So I propose we change the first sentence of description to A list of Message Objects that will be published or received on this channel.
Allowing additional type in union not specified in Type field
Second sentence in description says: oneOf is allowed here to specify multiple messages. This has very serious implications. In order for this to be true we have to amend the Type of Operation.message to [Message Object | Reference Object | Schema Object]. From the perspective of usage this doesn't really make sense as we already have this mechanism in [Message Object | Reference Object]. I suggest to eliminate this sentence entirely to reduce complexity. The alternative ca be defining the type as [Message Object | Reference Object | Schema Object], but as argued there is no additional value in this.
Invalid example
This example contains invalid usage of Operation.message field. The value of the field in example is defined as Message Object. This shouldn't be possible according to the current spec.
{
  "operationId": "registerUser",
  "summary": "Action to sign a user up.",
  "description": "A longer description",
  "tags": [
    { "name": "user" },
    { "name": "signup" },
    { "name": "register" }
  ],
  "message": {
    "headers": {
      "type": "object",
      "properties": {
        "applicationInstanceId": {
          "description": "Unique identifier for a given instance of the publishing application",
          "type": "string"
        }
      }
    },
    "payload": {
      "type": "object",
      "properties": {
        "user": {
          "$ref": "#/components/schemas/userCreate"
        },
        "signup": {
          "$ref": "#/components/schemas/signup"
        }
      }
    }
  },
  "bindings": {
    "amqp": {
      "ack": false
    },
  },
  "traits": [
    { "$ref": "#/components/operationTraits/kafka" }
  ]
}

I can issue a PR with the changeset if we agree on these points.

Exactly, we have a bug with type of Operation.message field, but

So I propose we change the first sentence of description to A list of Message Objects that will be published or received on this channel.

we cannot use this description, because you can use here single Message Object or list of Message Objects, so:
A definition of single Message Object or list of Message Objects that will be published or received on this channel.

is be better.
According to your suggestion with type:Message Object | Reference Object | Schema Object: it isn't correct, because using Schema Object you tell that you can also use the another keyword from Schema Object, like anyOf, allOf etc., which isn't true. I think that Message Object | Reference Object | { oneOf: [Message Object] } describe it clearer.

On the other hand, I wonder why we are using the oneOf keyword here if we could use a normal array without using that keyword...
@fmvilas I need your help here. Why even from 1.1.0 version of spec we use the oneOf field to define multiple messages? Due to fact that message field can be extended by extension or another decision?

we cannot use this description, because you can use here single Message Object or list of Message Objects, so:

Then the Type definition should be Message Object | Reference Object | [Message Object | Reference Object] and then we need to extend the description field to say the it allows either list of Message Object or Message Object itself.

Map["oneOf", [Message Object]]

What would be the semantics of this? If other to this be in spec, we have to define it's behavior. oneOf is a keyword from JSON Schema.

On the other hand, I wonder why we are using the oneOf keyword here if we could use a normal array without using that keyword...

IMHO it doesn't make any sense, as I already pointed out in my issue description and now you realizing it.

What would be the semantics of this? In order for this to be in spec, we have to define it's behavior. oneOf is a keyword from JSON Schema.

oneOf is already in spec, but we haven't any example of it in the spec, only a single difficult sentence to understand:

oneOf is allowed here to specify multiple messages, however, a message MUST be valid only against one of the referenced message objects.

Currently you can define message as:
message:
  payload: ...

or
message:
  oneOf:
    - payload: ... # message 1
    - payload: ... # message 2

so Map["oneOf", [Message Object | Reference Object]] is exactly the second case.

IMHO it doesn't make any sense, as I already pointed out in my issue description and now you realizing it.

TBH I don't know, maybe as I wrote, oneOf is easier to understand than the normal array itself, but let's wait for Fran's answer, because he defined it 2 years ago.

oneOf is already in spec, but we haven't any example of it in the spec, only a single difficult sentence to understand:

Found an example here: https://github.com/asyncapi/spec/blob/master/spec/asyncapi.md#channel-item-object-example (third and forth example). I agree it's difficult to understand and figure it out, looking at currently defined Type.

TBH I don't know, maybe as I wrote, oneOf is easier to understand than the normal array itself, but let's wait for Fran's answer, because he defined it 2 years ago.

I assume that the intention was to indicate that only one of defined messages apply here and not all. Having it defined as an array ([Message Object | Reference Object]) doesn't indicate that. Let's wait for author to clarify.

Yes, the intention behind having oneOf is to indicate that the message will be one of the listed messages. The reason it's not an array is that we were considering adding anyOf as well, where the message must match 1 or more instances of the messages. With an array type, we could only do either oneOf or anyOf, therefore the verbosity.
I'd like to clarify that oneOf here is not taken from JSON Schema. Its name is the same but it's not implying you can use a Schema Object or a subset of it.
I think the definition should be something like Message Object | Reference Object | Map["oneOf", [Message Object | Reference Object]].
@char0n would you mind opening a PR clarifying it? Also explaining the meaning of oneOf so it's clearer.

@fmvilas sure I'll handle it, now that I understand the original intention, it shouldn't be a problem.

I'd like to clarify that oneOf here is not taken from JSON Schema. Its name is the same but it's not implying you can use a Schema Object or a subset of it.

In practice for tooling implementations, can be translated to a Schema with only a oneOf field containing all those messages?

@smoya

In practice for tooling implementations, can be translated to a Schema with only a oneOf field containing all those messages?

I don't think so, because Message Object has different shape that JSON Schema. The behaviour is very similar, but another purpose. But to be clear: you can use the custom keywords inside JSON Schema so in theory you can use our Message Object, but from JSON Schema point of view, this use case is invalid.

I don't think so, because Message Object has different shape that JSON Schema

Sorry my bad. I meant for validating, to use a Schema with only a oneOf field containing all message payloads.

You can do that, but this operation should retrieves all payloads from possible messages and concatenate them in the oneOf array. The other solution/use case I don't see.

you can use the custom keywords inside JSON Schema so in theory you can use our Message Object, but from JSON Schema point of view, this use case is invalid.

Yep, exactly, JSON Schema should only include another JSON Schema; every unrecognized keyword is ignored. The situation changes in Draft 2020-12 where addition keywords can be given semantics by metaschemas. From the perspective of AsyncAPI spec it would be more than improper to include arbitrary object within JSON Schema, like Message Object; so we must clearly communicate that oneOf in this particular case is not a keyword from JSON Schema draft 07.

Sorry my bad. I meant for validating, to use a Schema with only a oneOf field containing all message payloads, which are actually Schemas.

I'm not sure this would be possible. oneOf MUST reference Message Objects and not one of its fields.

PR provided: https://github.com/asyncapi/spec/pull/603

The PR is waiting for approval. All the requested changes has been processed.

The PR has landed 2.3.0-2022-01-release.2. Should I close the issue or should I leave it to you (maintainers) to manage it's life cycle further?

hey, in theory, https://github.com/asyncapi/spec/pull/681 should close it once merged and bot should add a comment here that it is included in 2.3 🤞🏼 😄


CI: remove a redundant mvn compile on push

Signed-off-by: Roy Golan<EMAIL_ADDRESS>

good catch

/approve


Update Haskell package set to LTS 16.11 (plus other fixes)

This PR is test-built by Hydra at https://hydra.nixos.org/jobset/nixpkgs/haskell-updates. I'll fix up the remaining errors and merge it on Friday, 2020-08-28 20:00 +02:00. You can watch this live on Twitch at https://www.twitch.tv/peti343. In addition to the chat features offered by Twitch, there is also a voice conference at https://discord.gg/YTEa3XR that viewers can use to chat with me and with each other.

Completely irrelevant fun fact: If I didn’t overlook anything we have now for the first time since the switch to 8.8 more than 6000 working Haskell packages. :muscle:

If I didn’t overlook anything we have now for the first time since the switch to 8.8 more than 6000 working Haskell packages.

Good timing for the 20.09 release!

We'll merge https://github.com/NixOS/nixpkgs/pull/96560 next week.


additional tests

Codecov Report

Merging #70 (7fa2d31) into master (94eca90) will increase coverage by 2.24%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #70      +/-   ##
==========================================
+ Coverage   81.46%   83.71%   +2.24%
==========================================
  Files          15       15
  Lines        2223     2063     -160
==========================================
- Hits         1811     1727      -84
+ Misses        412      336      -76

Impacted Files
Coverage Δ

src/QuantumClifford.jl
88.56% <100.00%> (+8.50%)
:arrow_up:

src/precompiles.jl
0.00% <0.00%> (-5.89%)
:arrow_down:

src/experimental/NoisyCircuits.jl
53.36% <0.00%> (-1.71%)
:arrow_down:

src/useful_states.jl
59.01% <0.00%> (-0.36%)
:arrow_down:

src/project_trace_reset.jl
92.33% <0.00%> (-0.33%)
:arrow_down:

src/enumeration.jl
96.93% <0.00%> (-0.31%)
:arrow_down:

src/graphs.jl
100.00% <0.00%> (ø)

src/entanglement.jl
100.00% <0.00%> (ø)

src/canonicalization.jl
100.00% <0.00%> (ø)

src/randoms.jl
89.28% <0.00%> (+0.02%)
:arrow_up:

... and 4 more


Selected Fill in the blank input gets cut off

Describe the Issue
When the blanks in a fill in a blank challenge overlap vertically, the top selection box gets cut off:

^ See the two blanks in the sentence are above and below one another. When you click the first blank, the blue selection box is cut off - presumably because the input below is in front of the first input.
Affected Page
https://www.freecodecamp.org/learn/a2-english-for-developers/learn-how-to-clarify-information-in-different-interactions/task-36
Steps to Reproduce

Go to https://www.freecodecamp.org/learn/a2-english-for-developers/learn-how-to-clarify-information-in-different-interactions/task-36
Click on the first blank in the sentence
See the blank get cut off

Expected behavior
The box to be visible
Solutions
We could adjust the spacing so the input doesn't get cut off,
or move the z-index of the input to the front when it's selected.

We might also consider increasing the line-height. The lines are pretty close together.
Not sure why we are using rem for the unit, usually line-height is set using unitless values, which would make the 1.5 we have on the p elements work much better.
Also, the font-size is set using em for whatever reason (unlike most if not all other p font styles I have seen in our CSS). Not that changing it to rem does anything (currently at least).


Install with pytorch own cudatoolkit?

I'm using a server with Ubuntu 20.04.6 LTS with a V100 GPU.  I'm not admin, and I can't install cudatoolkit at system level. I installed pytorch (with conda), which uses its own cudatoolkit. I have no problem using hf models with Langchain HuggingFacePipeline, they use the GPU, but I have problem with llama-cpp-python.  I did:
CMAKE_ARGS="-DLLAMA_CUBLAS=on" pip install llama-cpp-python
and it goes without error, but when I load the model, it doesn't say:  found 1 CUDA devices.
I see that BLAS =0 and it doesn't use the GPU.
My impression is that it is not compiled using cuda.  Should I set some more env variables when I install  llama-cpp-python, so that it knowns that the cuda libraries are in /.conda/envs/llama/lib?
I already tried, in the notebook:
!export LLAMA_CPP_LIB=~/.conda/envs/llama/lib/libllama.so
from llama_cpp import Llama
but the GPU is still not used. This is why I think the problem is at install level, and not import level.

Hey @fcivardi I'm not too familiar with the conda cuda packages but is it possible set your CUDA_HOME and CUDA_TOOLKIT_ROOT_DIR environment variables to point to them before doing the installation. You'll likely need to reinstall with --force-reinstall --no-cache-dir --verbose and make sure there's a CUDA Found or CUBLAS Found in the cmake logs.


Solidify a surface voxel

I'm having a point cloud. After converting it to a FloatGrid, I have a surface voxel model. I want to obtain a solid voxel model. Is there any way I can do that with OpenVDB? I'm thinking of Floodfill 3D algorithm with a requirement that the surface voxel model needs to be watertight. Any suggestion is appreciated

There are signed flood fill methods available in openvdb/tools/SignedFloodFill.h

I tried that but I didn't receive what I expected. The VDBs before and after applying SignedFloodFill are exactly similar, still only surface voxels. I don't know what SignedFloodFill actually does here. I wonder does it really FloodFill algorithm: https://en.wikipedia.org/wiki/Flood_fill

Thank @Idclip, yes, I want to activate the interior bound by the surface voxel. I tried
ls = levelSetRebuild(*ls, 0, /*ext=*/halfWidth, /*interior=*/std::numeric_limits<float>::max()); // LevelSetRebuild.h
and saw the increase in the number of active voxels, but when I visualize it by vdb_view.exe, I didn't see the difference.

@SimonNgj: I tried the problem you're describing by scattering points on the Stanford's bunny model.

In the example that I showed, I use this dilate function

Hi @apradhana, I followed your instruction, but end up with an empty VDB. Could you please help me to check what is wrong here:

It seems like signedFloodFill function is to estimate the distance value, not to fill the watertight surface

Hi @apradhana, I want to achieve a solid voxelization like this: https://orbilu.uni.lu/bitstream/10993/16275/1/GARCIA_Frederic_ICPR2014.pdf
After converting a point cloud to voxels, we get a surface voxel representation of the point cloud.

This image shows what I want to achieve: starting from a point cloud (particles) => surface voxelization (level set) => solid voxelization


Calculated fields with non existing field references failing to provision

Which PnP repository to report the issue?

PnP Sites Core - https://github.com/OfficeDev/PnP-Sites-Core

Category
[X] Bug
[ ] Enhancement
Environment
[X] Office 365 / SharePoint Online
[ ] SharePoint 2016
[ ] SharePoint 2013
Expected or Desired Behavior
When a calculated field references a field in the Formula that hasn't been created yet (because it is created lower in the template XML) then the creation of the calculated field should be delayed.
Observed Behavior
When a calculated field references a field in the Formula that hasn't been created yet (because it is created lower in the template XML) then the created of the calculated field fails with the following error:
Apply-SPOProvisioningTemplate : The field was found invalid:  {fieldtitle:Done_x0020_Date}
Steps to Reproduce
used latest release available. Exported a site with calculated field and imported it to a clean site. Reproducing this issues might need a bit of luck as there isn't a specified order in the fields being exported.

Fixed by #817


Migrate to .graphqlconfig

The graphql.config.json file is deprecated. Migrate to .graphqlconfig.

Fixed with PR #35


Fix tipping contract on testnet

Running on testnet I have an error:
Error: Contract with address ct_2AfnEfCSZCTEkxL5Yoi4Yfq6fF7YapHRaFKDJK3THMXMBspp5z not found on-chain or not active

Probably this address is wrong or outdated
https://github.com/aeternity/superhero-wallet/blob/e1c2ebb5918704401b04193bf4be2391f310d384/src/popup/utils/constants.js#L103

Current version of wallet doesn't have such problems. Feel free to reopen this issue, if it will pop up in next versions.


Forms with dynamic content impossible in featherlight?

As far as I can tell, when you open existing (but hidden) DOM content in a featherlight modal, you completely duplicate the target DOM elements--without removing or renaming those elements?
Form fields which have to be referred to by ID (for example, to attach an editor to) cannot be updated in the featherlight window, as duplicate IDs exist in the DOM at that point.
I'm probably just missing something crucial here.

The DOM content duplication issue is real and has been causing quite a few problems for me as well.
One way to solve it is to write relative javascript, not using ids. Say you have a button which needs to take the value of an input and then display it. Instead of using the input id, traverse the DOM from the button itself. Something like this:
$(this).prev("input").val()

I do wonder however if it's already possible or how easy it would be to add a feature to featherlight where you define your DOM content in a specific area that featherlight knows how to handle, thus removing the need for any duplication.

Another quick thought regarding removing duplication.
Perhaps there's an option, or one could be added, which when set would move the specified content instead of copying it. Then there will only be a single copy.
Future hide/show could be done exactly that way - by hiding/showing the already moved content.

It's true that the ID thing can be problematic.
Featherlight could move instead of copy, and move back when done

I also have a need to reopen a featherlight with the previous content (valid for all contentFilters though, not just jquery), so now I'm wondering what's the best API for this.

I ended up removing the hidden DOM elements once featherlight opens, and instead of having them in a static hidden div, using a javascript template engine to generate them on the fly. Seems like a number of extra steps, and, of course, precludes having an easily accessed "show me the last version of this" copy hanging around.
The relative idea has merit, but in my case I need to attach tinymce editors to some textareas, and that requires IDs. If you don't have to use IDs, you can use the .featherlight-content class as a selector to grab featherlight version.
Moving the content would be ideal, of course.

Ok, so here's the two behaviors I'm thinking about:

(current)
-jquery content filter uses clone(true)
-content refreshed each time the dialog is opened, getContent & setContent called each time, with the callbacks beforeContent, and afterContent.
(new option)

jquery content filter moves instead of clone
content is kept intact. If the dialog is reopened, the same content is displayed. getContent & setContent are not called again. beforeContent and afterContent should probably not be called again, only beforeOpen and afterOpen are called each time. Probably no need for an additional callback like refreshContent.

When binding many items with that new option, I imagine the content would be unique to each item (instead of shared for all items). But $('many items').featherlight('#someId', {newOption: true}) would not work...
The big question is how do we name the new option... Ideas?

I think a good option name would be something that gives a good idea of what it does without looking at the docs. Perhaps something like moveAndPersist?

I think the featherlight content reflecting ongoing modifications is the expected behavior, and that subsequent changes to the target DOM would be my own problem to deal with (for example, clearing a form before presenting it again).
So maybe the option should just be cloneContent or cloneTarget with the default being "true" to reflect the current behavior?
That would make it fairly clear (to me, anyway) that featherlight clones content by default. The documentation can note, if the option is set to false, that the content-setting functions are only called the first time the modal is invoked.

Thanks for the comments so far. I like the persist name actually. The problem I see with clone is that it applies only for the jquery content filter. But think of the ajax content filter, it doesn't clone anything but there's potentially a big difference between doing the ajax call on first open vs at each open, or the iframe filter generating and loading the <iframe> once vs for each trigger...
That's why the idea of persisting is really what's going on here. If you don't persist, then it makes sense to clone, otherwise the second click wouldn't work :-) So move /  clone are just side effects of persist for one particular content filter.
I'm still not 100% if binding on a selection should persist for each item or all of them as a group. Let me see when implementing.

Ok, it took only a half a dozen LOC to get it going.
I've used the name persist for the option, and shared is a special value if more than one button should share the same content. I have a feeling that usually, individual persist will be more common than shared.
Anyways, if there's a bunch of <a data-featherlight data-featherlight-persist> in a page, I think it makes sense they don't share their content...
What do you guys thing of this API and the following doc?
persist - Boolean or 'shared': false;
If set, the content persist and will be shown again when opened again.
In case where multiple buttons need to persist the same content, use the special value 'shared'.
The content filter jquery (used for links like .some-class or #some-id) will clone the given content if and only if it is not persisted. Otherwise it will be moved in the lightbox.

The API looks just fine. The doc is also mostly fine, however I guess I can point out some minor issues.
Your editor's tab seems to be configured at 2 spaces so it looks fine for you, but in other cases the new persist option's comments in README.md and src/featherlight.js look misaligned. All the previous comments have been aligned by spaces, so I think the persist option's comments should be aligned using spaces as well.
Some minor grammar corrections:
README.md

L102 & L196
-If set, the content persist and will
+If set, the content will persist and will

L198
-it will be moved in the lightbox
+it will be moved into the lightbox

src/featherlight.js

L112
-If set, the content persist and will
+If set, the content will persist and will

I took the persist branch out for a test run. Now you never said that the functionality is ready, but I'll mention this just in case anyway. With the persist option set, the content got moved instead of copied, however it still got deleted upon closing the lightbox and thus could no longer be opened again.

Awesome, thanks for the corrections

With the persist option set, the content got moved instead of copied, however it still got deleted upon closing the lightbox and thus could no longer be opened again.

What did you try, exactly? If you call $.featherlight directly, you need to keep the result in a variable and call open() on it the other times.

I do call $.featherlight manually yes. Saving the return value and calling open on it later does work.
However the content is still missing from the DOM while the lightbox is closed. Some lighter content modifying workloads could easily be moved into the beforeOpen event handler, however I also have some pretty heavy workloads that were keeping the hidden content up-to-date and invoking featherlight would just reveal the already calculated content.
I did notice the $content property. Would using/modifying that be safe & provide the same results?
    // Old update code, while lightbox is closed
    $("#foo p").text("bar");

    // New update code, is it equivalent?
    // Elsewhere:
    app.foo = $.featherlight($("#foo"), {persist: true});
    // While lightbox is closed
    app.foo.$content.find("p").text("bar");

Is there something that is blocking this branch from being merged to the master and if so, can I do anything to help move it along?
(ping @marcandre)

Sorry, forgot about this.
So, IIC, by "however it still got deleted upon closing the lightbox", you meant it doesn't get moved back, but it's not deleted.
Yes, you can access it with  app.foo.$content, or this.$content in callbacks.
So that seems like a good solution, right?

Seems so. I'll try rewriting my usage with this branch on Monday and then I can let you know if I ran into any trouble.

I have now rewritten my code to use this persist option. Thus far things seem to be working nicely and I saw a nice 40% performance gain in my specific usage as well, as measured by the Chrome profiler.

:+1: from me for merging.
I put a WordPress Ninja Form (submitting via AJAX) in a Featherlight modal and it broke completely because of the cloning.

This has been released as v1.3.0 :fireworks:
Thanks for your patience, input and review everyone :smiley_cat:

If anyone is googling why their Hubspot Form embed isn't loading in the Featherlight JS modal popup, it's because you don't have data-featherlight-persist setting. Thanks, this fixed it for me.


Microsoft.DotNet.Interactive.ExtensionLab

Describe the bug
Hi I am trying to follow along with the amazing showcase on dotnetconf right now of the use of SQL inside notebooks, however I am unable to run the following command: #r "nuget:Microsoft.DotNet.Interactive.ExtensionLab"
I get the following error in the output:
Installing package Microsoft.DotNet.Interactive.ExtensionLab.........
Error: C:\Users\dfitz\AppData\Local\Temp\nuget\7548--fbde0a9e-8cb9-4904-85a9-cfa3bcf198b6\Project.fsproj : error NU1103: Unable to find a stable package Microsoft.DotNet.Interactive.ExtensionLab with version (>= 0.0.0)
C:\Users\dfitz\AppData\Local\Temp\nuget\7548--fbde0a9e-8cb9-4904-85a9-cfa3bcf198b6\Project.fsproj : error NU1103: - Found 87 version(s) in https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-tools/nuget/v3/index.json [ Nearest version: 1.0.0-beta.20561.1 ]
C:\Users\dfitz\AppData\Local\Temp\nuget\7548--fbde0a9e-8cb9-4904-85a9-cfa3bcf198b6\Project.fsproj : error NU1103: - Found 4 version(s) in nuget.org [ Nearest version: 1.0.0-beta.20553.2 ]

Thanks!
Please complete the following:
Which version of .NET Interactive are you using? There are a few ways to find this out:

In a notebook, run the #!about magic command.
At the command line, run dotnet interactive --version.
In VS Code, run "Report installed version for .NET Interactive` and copy the version number from the status popup.

OS

[x] Windows 10
[ ] macOS
[ ] Linux (Please specify distro)
[ ] iOS
[ ] Android

Browser

[ ] Chrome
[ ] Edge
[ ] Firefox
[ ] Safari

Frontend

[ ] Jupyter Notebook
[ ] Jupyter Lab
[ ] nteract
[x] Visual Studio Code
[ ] Other (please specify)

Screenshots
If applicable, add screenshots to help explain your problem.

Thanks, I was also wondering if the interactive notebook is available somewhere online?

I tried with asterisks, and still received the same error as the above. Thanks

We'll add the full sample to that PR or one shortly after.
The published version of the ExtensionLab is here so if the wildcards aren't working, you should be able to specify the exact version, e.g. #r "nuget:Microsoft.DotNet.Interactive.ExtensionLab,1.0.0-beta.20553.2

Hi, I still get the same error as @sanchez with
#r "nuget:Microsoft.DotNet.Interactive.ExtensionLab,1.0.0-beta.20553.2"
I'd love to try it...

After reonpening Visual Studio Code Insiders the nuget include seems to work but I get another error, System.CommandLine seems to be unavailable in version 2.0.0-beta1.20478.1:
Error: AppData\Local\Temp\nuget\30148--d65cd857-3d98-414d-87fb-bca833ccb787\Project.fsproj : error NU1102: Das Paket "System.CommandLine" der Version (>= 2.0.0-beta1.20478.1) wurde nicht gefunden.
AppData\Local\Temp\nuget\30148--d65cd857-3d98-414d-87fb-bca833ccb787\Project.fsproj : error NU1102: - 15 Version(en) gefunden in "nuget.org" [ N�chste Version: 2.0.0-beta1.20427.1 ]
AppData\Local\Temp\nuget\30148--d65cd857-3d98-414d-87fb-bca833ccb787\Project.fsproj : error NU1102: - 0 Version(en) gefunden in Microsoft Visual Studio Offline Packages.
AppData\Local\Temp\nuget\30148--d65cd857-3d98-414d-87fb-bca833ccb787\Project.fsproj : error NU1102: - 0 Version(en) gefunden in https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-tools/nuget/v3/index.json.

I seem to be able to fix it by putting: #r "nuget:System.CommandLine,2.0.0-*" in a cell then in the same cell after running the above add the following below it: #r "nuget:Microsoft.DotNet.Interactive.ExtensionLab,1.0.0-beta.20553.2". You will need to do this in a blank notebook because of nuget trying to cache the previous requests or something

It worked, thanks!


Automated cherry pick of #11738

Cherry pick of #11738 on release-7.6.
/cc  @mylonsuren
NONE

Trying to auto merge this PR.

Pull Request successfully merged
SHA: a3eff25f67e787aee978f23765f629c71660d0ea


Issue/2194 desired state details page (#2196)

Pull request opened by the merge tool on behalf of #2196

Merged in 66016397c21f97c668f4c9b4b513732354e6b51e


store apt_repo cache once per job

to avoid caching the same package in each cache across stages, thus reducing maximum storage on CI.
At the moment all packages built in the first stage will appear in each subsequent cache file.

It seems this is not nicely possible because actions/cache can only restore one key at a time and there is no good/standard way to call action steps for a list of values to restore keys from multiple caches.
Instead, I modified the ccache storage to store one cache for all build jobs.
Thus we can rely on github's mechanism to delete old caches upon hitting the storage space and will still never loose the ccache.

This does not solve the problem yet for a prospective parallel workflow where we would duplicate caches for now reason...


Brightness slider not available in mobile view

Hi Matt thanks for all your hard work!
In case you didn't know:
The brightness slider button card does not work in the app or mobile view. It does work in desktop mode.
Reproduce:

open light button in mobile mode vs desktop ( tested on Android / Windows )

On iphone it only works while tapping on the slider bar.


Long environment names mess up display

v0.16.3
Steps:

Create an Environment with a long name (Environment1234567890123)

Results
The name in the left pane is bleeding into the icon and if longer bleeds into the the main page.

Expected:
Should not overwrite icon or page

v0.18.1
Verified fixed


Support larger jwt tokens

Solves part of #215, but there's likely still work to do for staging/prod.

@myieye did you get a chance to test out staging and see how it responds with a big jwt? I'm not sure that staging will just automatically pickup the ConfigMap that you defined, so I'm not sure if it's any better.

@hahn-kev No, I haven't tested anything in staging yet.
For the record, the ingress-nginx docs address our exact scenario: they have a readme page about increasing the proxy-buffer for large JWT tokens.

@hahn-kev So I:

Removed my config map from /base
Used the available annotation and
Reworded and edited the issue to no longer be a bug for MVP, but an engineering issue for v1


policy refactor

remove "Policy" suffixes, as they are redundant
rename PolicyBase to DefaultPolicy
export all policies on the top level of the module as e.g. Policy.Default, Policy.EventHub

... or I could just read the rest of the review.


Generating docs for a function.

There is another idea for the next refactoring feature.
One could implement automatic documentation generation for a function. Based on its signature and body it could include:

Summary
Input parameters description
Output description
Raised exceptions description

I think there maybe a plugin to do this.  I'll have to look into it before I do something with comments :)

I think there maybe a plugin to do this. I'll have to look into it before I do something with comments :)

I think it will be matched in one pass instead of two (for two queries).
Here is docs:
https://tree-sitter.github.io/tree-sitter/using-parsers#query-syntax

I think there maybe a plugin to do this. I'll have to look into it before I do something with comments :)

There is one. I'll look a the plugin more.
https://github.com/nvim-treesitter/nvim-tree-docs

See also https://github.com/danymat/neogen


[SPARK-45951][INFRA] Upgrade buf to v1.28.1

What changes were proposed in this pull request?
Upgrade buf to v1.28.1
Why are the changes needed?
buf was upgraded to 1.26.1 two months ago, so I think it is time to upgrade it again.
this upgrade cause no change in generated codes, and it fixed multiple issues:
https://github.com/bufbuild/buf/releases
Does this PR introduce any user-facing change?
no
How was this patch tested?
ci
Was this patch authored or co-authored using generative AI tooling?
no

Merged into master for Spark 4.0. Thanks @zhengruifeng @dongjoon-hyun @HyukjinKwon @yaooqinn and @panbingkun


reshape function

Hi @willow-ahrens,
I wanted to discuss feasibility of eager only (and simplest possible) reshape function in Finch.
It looks like most of the Array API test suites require reshape to run (test_signatures.py test suite that I ran to count the number of supported functions is an exception).
To run them locally I used a crude/test only implementation:
def reshape(x: Tensor, shape: tuple[int, ...]) -> Tensor:
    arr = x.todense()
    arr = arr.reshape(shape)
    return Tensor(arr)

Do you think it would be feasible to have an eager only reshape(::SwizzleArray, ...)? Even if it would be as simple as copy to a dense format ([EDIT] or COO?), reshape and then copy back to the original format?

copy to a dense format

This is exactly what I'd like to avoid -- COO should be doable though.

I believe we can do this. The main challenge I have a hard time designing for is the selection of an appropriate output format. If we know the appropriate output format, I don't think it would be so hard to do a direct copy. We would need to use one of the randomly accessible sparse formats if the swizzles don't match up, but I think we could implement something similar to our getindex kernel.

Is this is a blocker for you?

@willow-ahrens It's needed for doing https://github.com/willow-ahrens/finch-tensor/pull/48 cleanly.

hmm. Okay! I'll do it today then.


Lineweight for Block

If EntityObject.Lineweight == Lineweight.ByBlock
Were can I find Lineweight in this case?
Vadim.

It is missing, I will add it. On my defense I will say that it does not appear in the documentation. Something similar happens with the Color, Linetype, and a few other properties. I need investigate it further.

I was wrong the code is ok. When a Color, a Lineweight, a Linetype, and/or Transparency is set ByBlock it means that it will inherit the properties of the block reference (Insert) not the actual Block definition. I used AutoCad for, I do not know how many years, and never used a ByBlock property.


chore(renovate): update renovate.json - bump @kubernetes/client-node to 0.22.1

chore(renovate): update renovate.json - bump @kubernetes/client-node to 0.22.1

for context, this is for the [redacted] CVE fix.
Kim: "We can merge it but we may have to close the PR that gets opened in favour of @Karthik’s fix"


ADD ip in log file

not really an issue ;)
It would be great if you can include IP Visitors in the log file.

I really can't see how the request source IP address is useful for 404 error statistics. @Erreur32, Could you please describe some use cases.

Thanks for the reply , and thank you for your plugin  ;)
But  i have already modified on my side to have it. ( really dirty way )
It's just to have some statsistic from IP Visitor + URL
To know  which IP  and how many times  ( to exclude some bad BOTs and USERs  with my own script).
I love Grav but  security  it's a pain to check, i mean with FAIL2ban it's not possible to parse the log file correctly.


Add BigQueryExtractor

Let's add support for extracting metadata from BigQueryOperator

@sreev Assigning to you and please add any details if needed.


draft composite template

I've put together a draft template for specifying composite parts as well as basic parts. Please look and see if you think that you can incorporate it.

I think it would be nicer to do something like what I have attached (it is more tabular which tends to be easier for people to deal with and this makes it more similar to the basic parts sheet). We might want to at source information too (incase people aren't creating composites simply uploading them from pubmed articles or something). Additionally, if this is reasonable then I can move the examples up so they aren't in the sheet itself and prefill the table only with the false and engineered_region.
I was unclear if commas are a combinatorial part or just several parts being uploaded at once but should all be individual sbol parts?
template_blank_with_composites_v002.xlsx

Jet showed me this today, and I concur that making each build a single line looks much cleaner to me.

I think that we can make the horizontal format work, but I found the version that you'd uploaded problematic because it's pushing the parts themselves way off to the side --- on my screen, at least, the parts and the displayID weren't able to be on the screen at the same time, which was bring problematic for me.
I've updated with a slight variation on your proposal that you made. In this version, I've dropped the Role, Target Organism, and Circular columns as redundant.

Role and circular (and type too!) should be computed from the parts + backbone + strain
When there's a strain, that's the target organism.  When there isn't a strain, target organism is taken from the individual parts (if coherent) and otherwise omitted.

This then leaves most of the screen real estate for the parts. Please let me know what you think.

Separately addressing the question of commas: in my conception, the commas specify a CombinatorialDerivation. Whether that library also gets enumerated is a separate question that could go either way, depending on the workflow.
For example, if I'm using this as an input for an experiment in SD2 protocol automation, I'd want to interpret it as a CombinatorialDerivation. If I'm specifying a set of parts for a build request, however, they're ultimately going to need to be turned into all of the individual members, whether by this tool or by a downstream tool in the build workflow.
I would thus tend to say that the baseline would be to specify a CombinatorialDerivation, and leave the enumeration of elements for later.

I'm not so sure about role and circular.  For Role, I'm guessing you assume it is always Engineered Region.  However, could it not also be other things such as Terminator when you are specify say a double terminator?
As for circular, I'm not sure how you infer that from the parts.  You can have all linear parts that are composed into a circular plasmid.

Role being engineered region only makes sense when your product is DNA. If your product is a modified strain, then that's a cell type and an NCIT strain role.
As for linear vs. circular: you don't get a circular plasmid without the plasmid backbone, which contains the origin.

Yes, I think you are making my point.  It takes some inference to get these things right, so it likely is good to have the ability to specify them in the table.

Right --- and I believe that I've got them there in the "strain" and "backbone" columns.

I've added a couple more things that are useful for me in the iGEM context, which I'd like your opinions on:

A "final product" column on both basic and composite parts, indicating whether in a build order this is intended to be one of the things actually getting shipped, or if it's just an intermediate
A constraints part column for combinatorial derivations, e.g., saying two parts are the same or different
For composites, modulation annotations RP(X) and X(A,-B) to reverse and trim parts going into composites, respectively.


Support for dropdown menus

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Not really a problem, but its annoying to have many options in a selector rather than a dropdown menu.
Describe the solution you'd like
Custom feature for dropdown menus, very similar to the selector feature where the custom feature allows you to select the options and apply css to each option.
... would even be nice to be able to have an icon for each option...
Describe alternatives you've considered
You can use the selector instead of a dropdown, but dropdown is better for options that need text explainers and for more options than looks good with a selector.
Additional context
Default dropdown feature:

I've been procrastinating on adding this since no one else has requested it yet. It should work like a simpler selector in that it has options but they only support a single action rather than being buttons. I should be able to use a generic HTML select element.

Bad news - I can't use the HTML select element for this as it's very limited in what styles it'll select. I'll have to create something more custom to mimic the styles of the default dropdown features.

Dropdowns are in beta! Download the latest 4.2.0 beta and give it a try! They should look and behave exactly like the default feature dropdowns. Feedback wanted!

Dropdowns are in beta! Download the latest 4.2.0 beta and give it a try! They should look and behave exactly like the default feature dropdowns. Feedback wanted!

Works great! I have had 0 issues so far and they function just like the regular dropdown. Love that icons are supported.
CSS seems super simple to modify too, so 0 complaints from me :)
Great job!

Released 4.2.0!


[$250] Android - Chat - Both parentheses and code block alignment is not same

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.41-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression t sting, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team
Action Performed:

Launch app in both Android and mweb
Open a chat
Paste the text - def test_code(): print(ode block test)
Send the message
Note code block and Parentheses alignment

Expected Result:
Both parentheses and code block alignment must be same
Actual Result:
In Android, slightly above parentheses, code block is displayed. In mweb, both parentheses and code block display in same line
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021844887140240525614
Upwork Job ID:<PHONE_NUMBER>240525614
Last Price Increase: 2024-10-11

Issue OwnerCurrent Issue Owner: @hungvu193

We think that this bug might be related to #Live Markdown

Adding this one to my test list and will get to it later this week.

No update yet

@hungvu193 - when you get a chance, can you see if this proposal will fix this issue? Thanks! I'm able to replicate on my Android device. Thanks!

@hungvu193 - when you get a chance, can you see if this proposal will fix this issue? Thanks! I'm able to replicate on my Android device. Thanks!

Oops let's reopen it 😂

I can reproduce this one, reviewing shortly

Hi @kushu7, your proposal worked. However please elaborate a bit more about your RCA.
The height of codeWordWrapper style was added a long time ago and it was increased to 20 to fix this issue.
My question here is what are the recent changes that introduced this bug?

🤦🏼♂ whoops, reopening again.

I don't think we can go forward without a clear RCA.

This is actually an old issue.

hmm linked facebook PR was closed :/

Heads up, I will be offline until Tuesday, October 22, 2024, and will not actively watch over this GitHub during that period.
If this GitHub requires an urgent update, please ask for help in the #expensify-open-source Slack Room. If the inquiry can wait, I'll review it when I return online.

Not overdue.

@alexpensify nope, I just want to link to the RCA of the issue 😅

Not overdue, waiting for proposals here

Same

According to https://github.com/Expensify/App/issues/8132#issuecomment-2450727023, it looks like we don't have plan to fix this bug yet. We can close this one @alexpensify

Thanks, closing in favor of https://github.com/Expensify/App/issues/8132#issuecomment-2450727023.


Example array is not displayed correctly in the Test request.

What happens?
in Reference

in Test request

What did you expect to happen?
Should display the Example array correctly in the API client.
OpenAPI Document
https://sandbox.scalar.com/p/lK1I9#tag/templates/POST/template

hey @inyourtime, allowing myself to close this in favor of #3782 - feel free to jump back in if need!


Fixing Layout, Adding BaseFragment, etc

Hi, Thanks a lot for setting this arch up. This looks good. I have not yet ran the app but code looks fine after reviewing. I'll add the tags and if I find any bugs, will revert back.


Initial Admin users - add any country value.

In last update field country was added to User model.
Value in field country for initial admin users:

<EMAIL_ADDRESS><EMAIL_ADDRESS>Defaultly don't have any country set for it.

So we don't get any cars in response.
https://i.imgur.com/eXM8e4f.png
After updating field country for any of this users with proper Country value, things getting back to normal.
https://i.imgur.com/ZQVXGmr.png
Will it work if we modify create_admin.py to accept one more argument specifying country. And update docker-entrypoint.sh to set any country for this users? Is there better solution?

How about we remove this command entirely and use "populate database" instead.
I don't think we need two seeding mechanisms.

I'm all in for Adam's change, though I'd also want to distinguish the default users somehow because these accounts shouldn't appear in exports.
Maybe we could use separate group? We could also use already existing fields in User model for hiding them - for example is_staff or some custom one.

How about this?
https://github.com/CodeForPoznan/pah-fm/pull/298

Ok, just found that one (after doing a review in #298).

I don't think we need two seeding mechanisms.
make populate_database is for the generation of factories and python manage.py create_admin is right now used only in docker-entrypoint.sh to create to the initial superusers. From my perspective, these serve two separate purposes.

these accounts shouldn't appear in exports.
Unless they create drive, they should not be visible in an export. And would be strange, if we would exclude them even if they added some drives.

We had yesterday refinement regarding passenger's signing drives (still waiting for @monikakrawczak to transfer them to GitHub) and we agreed then to migrate Passenger model to User. We also agreed (way before yesterday) that passenger may belong to one country, but don't need to. Users (passengers) without country set should be listed for every driver list.
I would assume, that superusers should be treated as a passenger (not a driver) so Add new drive form is not intended for them.
@Ctilhs protip: you can paste graphics files directly into GitHub comments/description.

I agree - lets keep it as simple as we can. If user has a drive, it will show in report. No matter who the user is.
In regards to model migration - I believe that will left to be done as a last step. We prepare certificates, frontend, etc first.
I am continuing discussion about migration scripts here
https://github.com/CodeForPoznan/pah-fm/pull/298/files/fd6c69cacb6af00c27224ef804fd3130c90560fa#diff-096359d9dbf21d9492d718f9363ea5e5

AFAIR on refinement, we figure it out that migration of Passenger model into Users will be one of the first steps that will proceed. We just need to ensure, that:

we use different serializer for passengers list and for the current user
we ensure a smooth transition for in serializer and endpoint.

After that, we have migration on User mode to add fields for cryptographic keys. I believe we need to wait for @monikakrawczak to prepare that backlog.

That sounds good!
Before we change passengers into users, we need ability to separate them into groups
https://github.com/CodeForPoznan/pah-fm/pull/293 ;)

#293 is next on my list to review. :)

Related issue: #352
Related PR: #353
Closing.


Windows: fatal: Unable to read current working directory: No such file or directory

After running Scooter on Windows/zsh I get this error:
➜  Desktop scooter
fatal: Unable to read current working directory: No such file or directory

This happens regardless of whether I finish the replace action or abandon it by pressing Esc.
I tried this on Windows/bash and got a different error:
Administrator@Turing MSYS ~/Dropbox/Desktop
$ scooter
thread 'tokio-runtime-worker' panicked at src\event.rs:44:67:
called `Result::unwrap()` on an `Err` value: SendError { .. }
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Thanks for reporting this - are you able to run both examples with RUST_BACKTRACE=1 i.e.
RUST_BACKTRACE=1 scooter

and let me know what the results are? Also, do these issues happen every time or only under certain conditions? At what point exactly do these issues occur, it sounds like the first is at startup and the second is when replacing?

I am now unable to reproduce this bug, with or without the flag. If you want to close the issue that's okay with me.

I'm happy to leave it open so that if others run in to the same issue they can post here, and of course if you do run in to it again let me know! In the meantime I'll try and improve error handling so that we have a better idea of what might be going on if it does reoccur


Add withTheme higher order component

What: Add withTheme higher order component

Why: Enables developers to use themes while using glamorous.Div.

How: created withTheme file and tests.

This is really just a proof of concept to get a feel for interest, albeit a working and documented one 😄 . I need to get 100% coverage still. Since most of the code is copy/pasted from GlamorousComponent I can just use those tests as guides.

#45 is a much more comprehensive PR. 👍

Thanks for this anyway!


should psycopg2  be listed as dependency?

Hi
I am wondering if psycopg2 should be listed in requirements.txt or as extra dependencies in sub-folders?
As we can see, psycopg2 is used in django-extensions/django_extensions/management/commands/reset_db.py. So maybe it is necessary to list psycopg2 explicitly?

mysqlclient
https://github.com/django-extensions/django-extensions/blob/30790483db0ac00b421d0b29ad9a0ac71ec76c7e/django_extensions/management/commands/reset_db.py#L122


Filter out SGs using ec2 resource.

I have succeeded in filtering out SGs which have open RDP and SSH ports using the below policy.
policies:
  - name: Open-security-groups
    resource: security-group
    comment: |
      security groups that have SSH and RDP access from everywhere
    filters:
      - type: ingress
        Ports: [22, 3389]
      - type: ingress
        Cidr:
          value_type: cidr
          op: eq
          value: <IP_ADDRESS>/0

I wanted to know if this level of filtering is possible using the ec2 resource? I want to print out the instances which have open RDP and SSH connections rather than the security-group ids.

we can write policy like this:-
policies:
- name: ec2-remove-group
resource: ec2
filters:
- type: security-group
match-resource: true
key: FromPort
value: 22
actions:
- type: remove-groups
groups: matched
isolation-group: sg-01ab23c4

Traceback (most recent call last):
File "/usr/local/bin/custodian", line 9, in
load_entry_point('c7n==<IP_ADDRESS>', 'console_scripts', 'custodian')()
File "/usr/local/lib/python2.7/site-packages/c7n/cli.py", line 398, in main
command(options)
File "/usr/local/lib/python2.7/site-packages/c7n/commands.py", line 166, in validate
conf_policy_names = {p['name'] for p in data.get('policies', ())}
AttributeError: 'list' object has no attribute 'get
When I tried to @srinivas-anant policy I get the above error can you help me fix the issue

@SrikanthSoma this error may be due to you have not used hyphen somewhere. so make sure you have written policy in the correct way.

name: Open-security-groups
resource: security-group
comment: |
security groups that have SSH and RDP access from everywhere
filters:

type: ingress
Ports: [22, 3389]
type: ingress
Cidr:
value_type: cidr
op: eq
value: <IP_ADDRESS>/0
This is the same policy I just copied and pasted @pawanaichra-datagrokr

The cloud custodian policy should start with policies:' @SrikanthSoma check out how Pawan's policy is and make the necessary changes, your policy is missing the policies:part, the policy I pasted does not have thepolicies:` part.

Yes, I realised that and added that line this time it gave me different error like this error Traceback (most recent call last):
File "/usr/local/bin/custodian", line 9, in
load_entry_point('c7n==<IP_ADDRESS>', 'console_scripts', 'custodian')()
File "/usr/local/lib/python2.7/site-packages/c7n/cli.py", line 398, in main
command(options)
File "/usr/local/lib/python2.7/site-packages/c7n/commands.py", line 183, in validate
p.get('name', 'unknown'), e)
AttributeError: 'Policy' object has no attribute 'get'

policies:
  - name: Open-security-groups
    resource: security-group
    comment: |
      security groups that have SSH and RDP access from everywhere
    filters:
      - type: ingress
        Ports: [22, 3389]
      - type: ingress
        Cidr:
          value_type: cidr
          op: eq
          value: <IP_ADDRESS>/0

Try this one

This worked but if I want to run this a config rule what events do I need to choose ? currently I wrote this policies:

name: Open-security-groups
resource: security-group
comment: |
security groups that have SSH and RDP access from everywhere
mode:

type: config-rule
role: arn:aws:iam::123456789012:role/Lambda-Custodian
filters:
type: ingress
Ports: [22, 3389]
type: ingress
Cidr:
value_type: cidr
op: eq
value: <IP_ADDRESS>/0

@srinivas-anant can you please help me with the policy.
I want to check if any of the 22 or 3389 port having cidr value as <IP_ADDRESS>/0 specifically.


Client-Side PropertySource Order Different between Spring Boot 2.1.x and 2.2.x

@spencergibb @ryanjbaxter
We are in the process of upgrading from Spring Boot 2.1.x (Greenwich.SR1) -> 2.2.x (Hoxton.SR1)
We are using the configuration server for externalized configuration and BOTH versions are hitting the same configuration server and the configuration being served is in the correct order.
However, if we hit the environment actuator endpoint on the client:
In this example, the application name is "build-api" and the profile is set to "local":
The 2.1.x version (which is working):
{
"activeProfiles": ["local"],
"propertySources": [
{"name": "server.ports","properties": {}},
{"name": "commandLineArgs","properties": {}},
{"name": "servletContextInitParams","properties": {}},
{"name": "systemProperties","properties": {}},
{"name": "systemEnvironment","properties": {}},
{"name": "configService:configClient","properties": {}},
{"name": "configService:https://github.com/buildcom/config.git/apps/build-api-local.yml","properties": {}},
{"name": "configService:https://github.com/buildcom/config.git/global/application-local.yml","properties": {}},
{"name": "configService:https://github.com/buildcom/config.git/apps/build-api.yml","properties": {}},
{"name": "configService:https://github.com/buildcom/config.git/global/application.yml","properties": {}},
{"name": "applicationConfig: [classpath:/application.yml]","properties": {}},
{"name": "springCloudClientHostInfo","properties": {}},
{"name": "applicationConfig: [classpath:/bootstrap.yml] (document #0)","properties": {}},
{"name": "class path resource [api-client-rest.properties]","properties": {}},
{"name": "defaultProperties","properties": {}}
]}

The 2.2.x version (it is ordering the default properties BEFORE the profile specific ones):
{
"activeProfiles": ["local"],
"propertySources": [
{"name": "server.ports","properties": {}},
{"name": "commandLineArgs","properties": {}},
{"name": "servletContextInitParams","properties": {}},
{"name": "systemProperties","properties": {}},
{"name": "systemEnvironment","properties": {}},
{"name": "bootstrapProperties-https://github.com/buildcom/config.git/global/application.yml","properties": {}},
{"name": "bootstrapProperties-https://github.com/buildcom/config.git/apps/build-api.yml","properties": {}},
{"name": "bootstrapProperties-https://github.com/buildcom/config.git/global/application-local.yml","properties": {}},
{"name": "bootstrapProperties-https://github.com/buildcom/config.git/apps/build-api-local.yml","properties": {}},
{"name": "bootstrapProperties-configClient","properties": {}},
{"name": "springCloudClientHostInfo","properties": {}},
{"name": "applicationConfig: [classpath:/application.yml]","properties": {}},
{"name": "applicationConfig: [classpath:/bootstrap.yml] (document #0)","properties": {}},
{"name": "springCloudDefaultProperties","properties": {}},
{"name": "class path resource [api-client-rest.properties]","properties": {}}
]}

We just fixed something like that in commons, can you try with snapshots?

Yep, it is fixed on the snapshots build, I think this is the PR that fixed it: https://github.com/spring-cloud/spring-cloud-commons/pull/670
It looks like we will have to wait until Huxton.SR2. Thanks. I will close this.

I can confirm, this issue is fixed when I load dependencies from the current org.springframework.cloud:spring-cloud-dependencies:Hoxton.BUILD-SNAPSHOT (but not with Hoxton.SR2).
Would be cool to get Hoxton.SR3 released soon.

The next few days