Switch to SplittableRandom in ProducerPerformance utility

Why:
Using java.util.Random to generate every byte sent from the ProducerPerformance appears to be a limiting factor. Throughput of the ProducerPerformance script is higher with a file of example records as compared to randomly generated records with --record-size.
On my machine a single thread can generate ~100MB/second of uppercase letters using java.util.Random and ~300MB/sec using java.util.SplittableRandom. This is a limit on throughput.
Note: you can optimise further by expanding it from 26 letters to 32 letter generated as it is more efficient to generate a nicely distributed int when the bound is a power of two.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

This is a follow-on PR from a prior closed one #13410. Switching to SplittableRandom is probably enough to stop random character generation being a limiting factor.

Comparison with trunk:
./core/build/distributions/kafka_2.13-3.5.0-SNAPSHOT/bin/kafka-producer-perf-test.sh \
--topic demo_p30 \
--num-records 5000000 \
--record-size 512 \
--throughput -1 \
--print-metrics \
--producer-props \
  bootstrap.servers=localhost:9092 \
  batch.size=512000 \
  linger.ms=100 \
  buffer.memory=128000000 \
  compression.type=zstd

Trunk
5000000 records sent,<PHONE_NUMBER>60 records/sec (50.56 MB/sec), 10.22 ms avg latency, 371.00 ms max latency, 10 ms 50th, 16 ms 95th, 21 ms 99th, 48 ms 99.9th.
...
producer-metrics:compression-rate-avg:{client-id=perf-producer-client}                      : 0.611

SplittableRandom
5000000 records sent,<PHONE_NUMBER>04 records/sec (79.69 MB/sec), 7.34 ms avg latency, 305.00 ms max latency, 7 ms 50th, 11 ms 95th, 17 ms 99th, 28 ms 99.9th.
...
producer-metrics:compression-rate-avg:{client-id=perf-producer-client}                      : 0.610

Environment:
java -version
openjdk version "11.0.18" 2023-01-17 LTS
OpenJDK Runtime Environment Corretto-<IP_ADDRESS>.1 (build 11.0.18+10-LTS)
OpenJDK 64-Bit Server VM Corretto-<IP_ADDRESS>.1 (build 11.0.18+10-LTS, mixed mode)

Intel(R) Core(TM) i7-10750H CPU @ 2.60GHz

Failed tests are unrelated:
Build / JDK 11 and Scala 2.13 / kafka.security.authorizer.AuthorizerTest.testAddAclsOnPrefixedResource(String).quorum=kraft
Build / JDK 11 and Scala 2.13 / kafka.server.metadata.BrokerMetadataPublisherTest.testExceptionInUpdateCoordinator()
Build / JDK 11 and Scala 2.13 / kafka.server.metadata.BrokerMetadataPublisherTest.testExceptionInUpdateCoordinator()
Build / JDK 8 and Scala 2.12 / org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationSSLTest.testRestartReplication()
Build / JDK 8 and Scala 2.12 / org.apache.kafka.connect.integration.ConnectorRestartApiIntegrationTest.testMultiWorkerRestartOnlyConnector
Build / JDK 8 and Scala 2.12 / kafka.admin.TopicCommandIntegrationTest.testDescribeUnderMinIsrPartitionsMixed(String).quorum=kraft
Build / JDK 8 and Scala 2.12 / kafka.server.metadata.BrokerMetadataPublisherTest.testExceptionInUpdateCoordinator()
Build / JDK 8 and Scala 2.12 / kafka.server.metadata.BrokerMetadataPublisherTest.testExceptionInUpdateCoordinator()
Build / JDK 17 and Scala 2.13 / kafka.security.authorizer.AuthorizerTest.testAclsFilter(String).quorum=kraft
Build / JDK 17 and Scala 2.13 / kafka.server.metadata.BrokerMetadataPublisherTest.testExceptionInUpdateCoordinator()


Add autocomplete to Options

I already suggested this in the discord server but I will put it here too so it doesn't get lost.
It's quite simple, in JDA 5 alpha 5, autocomplete for options got added. You can check #jda5-changes in the JDA discord server for more information.

Added in #84.


React Query keys no longer exported?

Discussed in https://github.com/anymaniax/orval/discussions/1436

Originally posted by tlqvst June  5, 2024
After updating from 6.24.0 to 6.29.1, all react query keys in the generated code are no longer exported. I couldn't find antything about this in the documentation, is there a way to enable this again? Or am I just misunderstanding how to handle query invalidations now? I often find myself needing the generated query keys.
Reproducer
Made a codesandbox
https://codesandbox.io/p/devbox/xy6ffl
Check the getListPetsQueryKey function in pets.ts, then remove the override section in orval.config.cjs, notice that getListPetsQueryKey is now being exported.

cc @tlqvst @mironbalcerzak

Should be fixed with the last one

It is indeed fixed in 6.30.2. Thanks!


How does user searching work?

How does user searching works? When I type a name there is no autocompletion. When I hit Enter, there is not searching happening, but a new PM is started with the first user on the list.
I am using LDAP for users login.

Is the name you type the name of a user that has already signed up for Zulip?
Even if they exist in LDAP, there's no bulk auto-creation of LDAP users in Zulip.

What does 'sign up' mean in this context? All of the users just logged in on the login screen using their credentials from LDAP. They did not go through Register process. And I am typing a name of such user.
I can see them all on the right hand side, on the scrollable list.
Are you saying they are not 'full' users then? Should they all register first?

I meant they've logged in to Zulip, specifically, at least once.

When I type a name there is no autocompletion.
Oh, I see. Autocompletion happens in the PM compose window; the sidebar is just a filter action.

So, yeah, they;ve logged at least once, and are present and available on the user list.

How exactly is the filtering supposed to work? Becasue again, nothing actually happens when I use the field.

Running in dev, this is what it looks like for me:

I then type "C", and see:

Thanks for exaplanation! For some reason it started working now... I think we can close the issue.


[fastlane, action] reset_simulator - add :ios version flag

as requested here: https://github.com/fastlane/fastlane/issues/7192
initially i tried: FastlaneCore::Simulator::reset(udid: nil, name: nil, os_version: nil)  but it depends on either udid, or name, and i think in this case its ok to get those few more lines in the action itself.
lane :sim do
        reset_simulators(
                ios: ["8.1", "10.1"]
        )
        reset_simulators
end

@mgrebenets
continued in:

1/2 -> https://github.com/fastlane/fastlane/pull/7196
2/2 -> https://github.com/fastlane/fastlane/pull/7197


Multi branch

This PR is almost ready, some further tests are in progress, but the structure of the main algorithm is correct.

I've finished testing this branch by using a comparison test; compare the number of mismatches as computed by doing all of the alignments at the same time via compute_mismatches (that compares the read against the entire graph), vs manual_mismatches that first reconstructs the sequence at at a given position (for each allele) and then compares against the read.
Specifically, I've tested all of the previously aligned (for the Optitype runs) reads (120 fasta files with around 1000 reads each) against the A_nuc, A_gen, B_nuc, B_gen, C_nuc, C_gen, DRB_nuc, and DRB1_gen, IMGTHLA alignment files.


Reap failed agent

This change reaps runners that appear as offline in github and have their RUNNER STATUS set to failed. Runners that are in this state have registered themselves in GutHub, but failed at a later stage in the setup process. We reap them if no new updates have been made to the instance after the configured pool timeout.
This change also adds a retry when running config.sh via userdata. Hopefully in future releases we can switch to using jit runners but for the time being, this is not available for GHE.
Fixes: https://github.com/cloudbase/garm/issues/104

I'm going to go ahead and merge this. @SystemKeeper if the problem persists after using this patch, feel free to re-open the issue.

Thanks @gabriel-samfira! I’ll try to install it as soon as possible :)

No rush! This needed to be done anyway. It should resolve your issue on two fronts:

configure is retried 5 times before we give up
failed agent is reaped when the pool bootstrap timeout is reached (this is configurable per pool via garm-cli pool update --runner-bootstrap-timeout)

So either way, you should see no more runners linger.

Apropos, this also added a make build target which just builds the binaries using go build and sets the proper version. This is set as a default, so you can just run make. The build-static target is still there in case you need it.

Quick feedback after this PR: no issues to report 🙂


[REFACTOR] : [Payeezy] Error Message For Connector Implementation

:memo: Feature Description

In terms of errors, we are currently throwing a 'not supported' message, which shouldn't be the case as we are yet to decide on the implementation.

:hammer: Possible Implementation

In order to manage payment methods that are not implemented by Hyperswitch or yet to be implemented, the connector transformers file should make use of the NotImplemented ConnectorError enum variant.
By doing so, we will throw same error message for all the Connector Implementation
You can check this PR for further reference https://github.com/juspay/hyperswitch/pull/2831

:bookmark: Note: All the changes needed should be contained within hyperswitch/crates/router/src/connector/
:package: Have you spent some time checking if this feature request has been raised before?

[X] I checked and didn't find a similar issue

:package: Have you read the Contributing Guidelines?

[X] I have read the Contributing Guidelines

:sparkles: Are you willing to submit a PR?

@swangi-kumari can you please assign me this issue, as i have already made the PR for the previously assigned issue.

Sure @HeetVekariya ,
I have assigned this to you. Please let us know if you need any help.

@swangi-kumari Made the PR for this issue.

Completed in this PR


Margin & Padding Utility Classes

Checklist

[x] Have you asked the contributors if a similar effort is already in process or has been solved?
[x] You've reviewed the contribution guidelines?
[x] Your pull request uses staging as its base branch. (All PRs using production as its base branch will be declined).
[x] All gulp scripts successfully compile.
[x] Any affected documentation has been updated, removed, or extended.
[x] Provide a description what is being changed, extended, or removed.
[x] Link to any issue(s) this request is resolving.
[x] Request a review from Joshua Hynes, Ted Goas, or David Becher.

Description
Add immutable margin and padding classes and update the documentation accordingly. This keeps all pre-existing d-margin[-dir][#][--negative] and  d-padding[-dir][#], but adds immutable margin (.d-m[t|r|b|l][n][#]) and padding (.d-p[t|r|b|l][#]). It also updates the auto margin classes in the same way and adds in margin and padding reset classes.
Also the documentation has been updated to better illustrate what these classes do.
This PR helps us with #101 .

@hynes-dialpad Also feels like a good time to fill out the spacing variables section since it's referenced in these pages.

@TedGoas Well I did a spacing variables page. It could probably use more, but it's a start.

@hynes-dialpad Nice, great start. We can always improve it later!


Integration of Protocol-Multiplex (sslh) for using same port on different protocols

Is your feature request related to a problem? Please describe.

heyho..
often, people are inside networks which have port-restrictions and it is not possible to directly use ssh/openvpn/etc. on their default ports to reach (home)servers - but usually ports 80 and 443 are opened to surf the web.
Describe the solution you'd like
sslh is a nice solution/successor for managing different protocols parallel on only one port. for sure it would be possible to use sslh one step before NPM.. but it would be nice to configure protocol-multiplexing inside NPM instead of manually/outside of NPM
Describe alternatives you've considered
maybe an alternative would be to manage the problem totaly on clientside by using corkskrew for ssh-connections and put other protocols ontop of this connection.. but thats 1. complex 2. inefficient 3. not platform-independent (linux, windows, mac-os, iOS, BSD, Android, whatever..) usable.

stalebot does stale-things


[ContainerApp] az containerapp env: Add argument --enable-peer-to-peer-encryption.

Related command
az containerapp env create/update
Description
Support peer-to-peer traffic encryption with --enable-peer-to-peer-encryption.
Testing Guide

History Notes
[ContainerApp] 'az containerapp env create/update': support peer-to-peer traffic encryption with --enable-peer-to-peer-encryption.

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR title and description has followed the guideline in Submitting Pull Requests.

[ ] I adhere to the Command Guidelines.

[ ] I adhere to the Error Handling Guidelines.

pending on 2024-03-01 upgrade.

cherrypicked from https://github.com/Azure/azure-cli-extensions/pull/7464

/azp run


Error stringify

Fixes error stringify issues by using a JSON replacer function.
Resolves #26 and #27.

Coverage remained the same at 100.0% when pulling 09c8c275ece46442038f3f4e73cc1ae56009be5f on lrezek:errorStringify into c633a29ccc2947a74cf43088ff92cbda40425ab0 on miratronix:master.


Version 1.0.0

New feature: cacheProviders :rocket:
You are no longer binded to node-cache, you can now choose the following cache providers:

LRU
mmap
redis
node-cache
native (local variable assignment)

Coverage increased (+2.9%) to 95.536% when pulling 175b8e62e5b4a1b6b56d23ae373541af4f789c85 on newupdate into 87a917fd23f8645f26ae3ad711adcaa002c19ed8 on master.


DryIocServiceHostFactory.SetContainer static state and/or lollipop immutability problem

Hi,
DryIocServiceHostFactory.SetContainer currently throws, when called more than once and also stores the container in static attribute, which complicates integration tests.
Could either static state or lollipop immutability be removed?
(While removing static state is way more preffered, lollipop immutability here seems like a good idea)
When integration testing, the method (AutoFixture Customization for me) which configures container often gets called more than once (as not all test can reuse the DI context due some mutable state in it) and possibly with completely different containers.
Like I have tests, which use 2 set ups - one with DI container with caching things and other without and I test the service behaves still the same, regardless of kind implementations being used.But on the level of WCF service I can't do that now.

Hi @igand, the short answer is no.
Changing the container instance is an error. Allowing it would cause more harm than good. If you need different containers for your tests you could use seperate AppDomains or use self-hosted WCF services and instantiate DryIocServiceHost directly in your test setup.


Update Composer dependencies (2023-06-23-00-10)

Visual regression test passed!
View the visual regression test report


Bump cert-manager helm chart to version 0.6.6

The version 0.6 of the helm chart for cert-manager no longer works and will throw an error when applying the ClusterIssuer
Internal error occurred: failed calling admission webhook "clusterissuers.admission.certmanager.k8s.io": the server is currently unable to handle the request

The issue thread is over at: https://github.com/jetstack/cert-manager/issues/1255#issuecomment-461579864
The solution right now is to use the latest helm chart (v0.6.6)

@sebnyberg : Thanks for your contribution! The author, @iainfoulds, has been notified to review your proposed change.

Thanks, @sebnyberg. Sorry you ran into problems.
#sign-off


Would be possible to specify the x and y of the window?

What OS are you using (uname -a, or Windows version)?

What programming language are you using (C/C++/Go/Rust)?

What did you expect to see and what you saw instead?

on Windows, you can call
SetWindowPos(static_cast<HWND>(webview.window()), 0, x, y, width, height, 0);
just before webview.run().
If anyone has the equivalent for Mac and/or Linux please post

how to change initial position via Go?


Inhibit saving tags if the max_input_vars PHP.ini value is reached

Bug tracker: https://www.concrete5.org/developers/bugs/5-7-5-8/changing-tags-settings-results-in-deleted-tags

Here's the shown dialog when there are 3065 tags and the user tries to hit [Save]:

It seems like it might be a better option for us to refactor how this form works so it won't ever POST that many variables. Thoughts?

It seems like it might be a better option for us to refactor how this form works so it won't ever POST that many variables. Thoughts?

I always prefer small ajax calls compared to big form submissions

It would be nice to refactor this but this will help in the meantime


Troubles with Oauth

Hello,
I'm trying to create a client-side web app but I have troubles with authentication.
I followed the Authentication part from the Readme file: I created credentials for Drive API on Google Developers Console, downloaded the json file.
But when I use it in my client-side app, I have an error:
Fetch API cannot load https://accounts.google.com/o/oauth2/token. No 'Access-Control-Allow-Origin' header is present on the requested resource. Origin 'http://localhost:3000' is therefore not allowed access. If an opaque response serves your needs, set the request's mode to 'no-cors' to fetch the resource with CORS disabled.

In fact it's only working when I use a plugin which adds Allow-Control-Allow-Origin: * in response headers (for instance: https://chrome.google.com/webstore/detail/allow-control-allow-origi/nlfbmbojpeacfghkpbjhddihlkkiljbi)
According to Google documentation here, for client-side web application I need to create an OAuth client ID instead of a Service account like mentioned in Readme file. This step allows to specify a list of domain origins.
But this solution doesn't return a client_email + private_key I can use but returns a clientId + apiKey.
My question is: how could I use this clientId + apiKey to authenticate my requests to my spreadsheet?
Thanks for your help.

Hi! I was wondered that this lib supports only service accounts auth. I've created PR with support of auth flow by preconfigured OAuth client with refresh token. You can take a look if you want.
https://github.com/theoephraim/node-google-spreadsheet/pull/180

Thanks @alexkorsun, I will :)

Adding client-side oauth support and an example is on my to-do list, should get to it soon.
FYI - I've just a published a new version of this module which is a complete rewrite using Google's V4 Sheets API (v3 is being deprecated on March 3, 2020).
Docs available here - https://theoephraim.github.io/node-google-spreadsheet
Thanks! 😄


Wiki

I suggest to add an little and simple module for wiki, if server need it.

Someone has contacted me and this module is under development using the rules module as base code.

This module has been added, can an admin please close the issue

This module has been added, can an admin please close the issue

https://namelessmc.com/resources/resource/145-wiki/

https://namelessmc.com/resources/resource/145-wiki/


Remove non-existent module.

It looks like that there is no spring-cloud-vault-core anymore.

Good catch, thank you.

That's merged and polished now.


Run time of job "run_change_reporter" was missed

I have a few accounts (5) that fail to get data into Security Monkey.  There are 30+ accounts in total, so I'm suspecting that it's taking "too long" by some standard to get to these ones, and they are considered missed.  For each of them I get this message:
2016-02-17 17:59:23,370 WARNING: Run time of job "run_change_reporter (trigger: interval[1:00:00], next run at: 2016-02-17 18:55:05.401693)" was missed by 0:04:17.968895 [in build/bdist.linux-x86_64/egg/apscheduler/scheduler.py:496]
I tried disabling some of the larger accounts, but even though they are gotten to sooner, they still get skipped:
2016-02-17 18:07:42,125 WARNING: Run time of job "run_change_reporter (trigger: interval[1:00:00], next run at: 2016-02-17 19:07:06.027129)" was missed by 0:00:36.098024 [in build/bdist.linux-x86_64/egg/apscheduler/scheduler.py:496]
Note:  Due to the number of accounts/length of time it takes do do a full crawl, I've been backing the interval out to an hour.

Hey @DataSquid
The current architecture requires a thread/account:
https://github.com/Netflix/security_monkey/blob/master/env-config/config-deploy.py#L68
Up CORE_THREADS to like 45 and MAX_THREADS up to like 65ish and let me know if that "fixes" it.  I'd love to find a more elegant solution.

Many thanks.  That worked.  Had been a while since the initial deployment so that knowledge was long-gone from my brain.


[DRAFT] Initial Docs

Description
Initial repository docs, WIP
Which issue(s) does this PR fix or relate to
related to #28

After a quick sync with the docs team, let's continue moving fwd on this PR, so that they can have something they can rely upon as soon as possible.

we should really remove the arches that are not being built/supported -- in the CSV, see lines 167-169.
                        - arm64
                        - ppc64le
                        - s390x

+1


TypeError: null is not an object (evaluating 'context.plugin.urlForResourceNamed(frameLocation).path')

Using skpm and the example code from the sketch-module-web-view Readme, I get the following error when running my-command:
TypeError: null is not an object (evaluating 'context.plugin.urlForResourceNamed(frameLocation).path')
line: 214
stack: WebUI

__webpack_require__

run
run@[native code]
column: 70
 «Plugin Output»

Looking at the plugin package, I see that the Resources folder is missing. Maybe that's the reason? How do I add the Resources folder so it gets included to the plugin on build?

you can specify resources in your package.json: https://github.com/mathieudutour/git-sketch-plugin/blob/master/package.json#L7-L10

Thanks! Now I'm getting:
🖨  Copied src/manifest.json in 7ms
error Error while building Resources/test.html
./Resources/test.html
Module parse failed: /Users/xyz/Development/woozle/Resources/test.html Unexpected token (1:0)
You may need an appropriate loader to handle this file type.
| <!DOCTYPE html>
| <html>
|   <head>

oh my bad, it should only be javascript files in the package.json. just put the html file directly in myplugin.sketchplugin/Contents/Resources. You can open an issue on skpm/skpm if you think it would be useful to copy the non-js files specified in the package.json (which I tend to agree)

Still doesn't work. I put test.html here: myplugin.sketchplugin/Contents/Resources and removed the resources statement from package.json. Build works, but when executing my-command, I get the same error as in the beginning:
TypeError: null is not an object (evaluating 'context.plugin.urlForResourceNamed(frameLocation).path')
line: 214
stack: WebUI

__webpack_require__

run
run@[native code]
column: 70
 «Plugin Output»

my-command.js looks like this:
import WebUI from 'sketch-module-web-view'

const options = {
  identifier: 'unique.id', // to reuse the UI
  x: 0,
  y: 0,
  width: 240,
  height: 180,
  background: NSColor.whiteColor(),
  onlyShowCloseButton: false,
  title: 'My ui',
  hideTitleBar: false,
  shouldKeepAround: true,
  frameLoadDelegate: { // https://developer.apple.com/reference/webkit/webframeloaddelegate?language=objc
    'webView:didFinishLoadForFrame:': function (webView, webFrame) {
      context.document.showMessage('UI loaded!')
      WebUI.clear()
    }
  },
  uiDelegate: {}, // https://developer.apple.com/reference/webkit/webuidelegate?language=objc
  onPanelClose: function () {
    // Stuff
  }
}

const webUI = new WebUI(context, 'test.html', options)

It works now. Turns out, Sketch doesn't always reload the script even though I set it up with
defaults write ~/Library/Preferences/com.bohemiancoding.sketch3.plist AlwaysReloadScript -bool YES
To reliably reload the script after building, I need to restart Sketch.


Recently started facing one issue while running build-and-run.sh or running server jar

Please find below logs and suggest
org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'apiViolationsController' defined in URL [jar:file:server/build/libs/zally.jar!/BOOT-INF/classes!/de/zalando/zally/apireview/ApiViolationsController.class]: Unsatisfied dependency expressed through constructor parameter 0;

Could this be the same as fixed yesterday in #1120? (caused by https://rawgit.com reaching end of life)

It worked for me after replacing the url in rules-config.conf https://cdn.rawgit.com/googleapis/gnostic/master/OpenAPIv3/openapi-3.0.json with https://raw.githubusercontent.com/OAI/OpenAPI-Specification/master/schemas/v3.0/schema.json
Please suggest if this is the right approach.

Yes, this should be a viable workaround if you can't move to a more recent build.


Inexact wording in Quiz M4.03 Q1

As mentioned in this forum post, both answers are valid depending on how we set the PolynomialFeatures parameters.

@lfarhi @MarieCollin I merged #591 with the new wording. I let you propagate the change on the Fun platform. Since it only changes the phrasing of a question I think we can do this change in the current session.

@lfarhi @MarieCollin actually we think there is a better wording for this question you may want to wait before changing it in FUN

I corrected the question in FUN, you can close

:thinking: miscommunication we are still not happy about the wording (as I tried to say in my previous message)
Wait first until https://gitlab.inria.fr/learninglab/mooc-scikit-learn/mooc-scikit-learn-coordination/-/merge_requests/65 is merged (soon), and then this would be great if you could propagate the change in FUN. Sorry for the duplicated work ...

Thanks @lfarhi! Sorry to bother you again but you corrected the question using #591 and the correct wording is in #592

Sorry, as https://gitlab.inria.fr/learninglab/mooc-scikit-learn/mooc-scikit-learn-coordination/-/merge_requests/64 has been merged, I deduced that it was good !

Don't worry @lfarhi, it is good for now (no need to undo the change), but it can be improved!

I merged the new version. Let's close this issue once fun is updated again. Sorry @lfarhi  :)

This aws done in FUN. I am closing the issue. Thanks @lfarhi @MarieCollin !


There is a mismatch in number of comments in actual post to the shared post.

Environment-staging
Device used-Samsung Galaxy s8
Browser-Google chrome
1.login with valid user name and password
2.share your post to watsapp / email.
3.log out from the account.
4.click on the link from the watsapp/email.
Result:
There is a mismatch in number of comments from the actual post to the shared post.
Always shared post comments shows as 0 irrespective of any number of comments the post has.

duplicate(?) of #1987

@Zaydme #1987 is a loading issue.
#2017 is a issue with showing number of comments from the shared link .

@nivetheatha both fixed in #2041 :+1:


Fix #24193: Allow nullable discriminants

Fixes #24193
This is technically a breaking change because it enables excessing property checking for certain kinds of unions (with null discriminant), when the check was previously disabled.
Example:
type Foo = { a: null; b: string } | { a: string, c: number };
const x: Foo = { a: null, b: "foo", c: 4};

Before: No error
Now:
Type '{ a: null; c: number; b: string; }' is not assignable to type 'Foo'.
  Object literal may only specify known properties, and 'c' does not exist in type '{ a: null; b: string; }'. [2322]

Let me propose a simpler and more general approach.
We currently consider a property of a union type to be a discriminant property if it has a non-uniform type and that type is a union of only unit types. I think we could slightly relax this to say it must be a union containing at least one unit type. This would allow us to discriminate in other cases such as
type Result<T> = { error?: undefined, value: T } | { error: Error };

function test(x: Result<number>) {
    if (!x.error) {
        x.value;
    }
    else {
        x.error.message;
    }
}

test({ value: 10 });
test({ error: new Error("boom") });

I put up the proposed (very simple) change in a branch named mixedDiscriminantTypes. This is only one minor difference in the test baselines and one minor difference in the RWC tests, so I think it is workable.

@ahejlsberg I like your approach better (but to be pedantic your example does work with my fix). For your suggestion I think we need an additional constraint that says the union does not contain an instantiable type. Without so, the wrong narrowings are produced. For example, I think your fix produces the following behaviour:
type GenericA<T> = { a: 3; c: string } | { a: T; c: number };
function narrowT<T>(x: GenericA<T>) {
    if (x.a === 3) {
        // x: { a: 3; c: string }
        const aString: string = x.c; // ok, probably shouldn't be
    }
}
narrowT({ a: 3, c: 4 });

So a proposed alternative is:

it must be a union containing at least one unit type and no instatiable types

However this approach does have one drawback in that it prevents some useful narrowings:
type GenericA<T> = { a: 3; c: string } | { a: T; c: number }
function narrowT<T>(x: GenericA<T>) {
    if (x.a !== 3) {
        // in master (or my change) x: Generic<T>
        // the assignment is not ok, but probably should be
        // ok, in mixedDiscriminantTypes
        const aNumber: number = x.c;
    }
}
narrowT({ a: 3, c: 4 });

I think maybe the root of the problem is that the filtering done by discriminant narrowing uses the comparable relation, which does not relate type parameters to literals [1]. This filters out types with generic discriminates which shouldn't be filtered unless their base constraint is not comparable.
Changing the comparable relation seems really scary, though I would argue a generic T should be comparable to a unit type unless the base constraint of T is definitely not comparable.
Not sure how to proceed, but here is a summary:

I like your solution better but we should make sure to not filter union members that could be instantiated to a matching type. The simple fix would be rejecting a union with an instantiable type.
The more complete solution seems to be changing the filtering done by narrowTypeByDiscriminant, either by changing the filter, or changing the comparable relation. I'm starting to get abit out of my depth at this point, so I defer to your judgment (and anyone else's on this for that matter).
I'm happy to proceed however: whether you just want to want to merge your branch and drop this, or pull changes into this.

[1] I'm not sure of the full details of the comparable relation, I used the behaviour of the following to guide me:
function foo<X>(x: X) {
  if (x === 3) { // error

  }
}

I think we need an additional constraint that says the union does not contain an instantiable type.

Good point. I think that would be a reasonable rule to add.

I think maybe the root of the problem is that the filtering done by discriminant narrowing uses the comparable relation, which does not relate type parameters to literals [1]. This filters out types with generic discriminates which shouldn't be filtered unless their base constraint is not comparable.

Yes, that's the root of the problem We only allow relating type parameters to undefined, null, and compatible type parameters. Since an unconstrained type parameter could be anything, it would technically be correct to allow it to be compared to anything. Yet, the current rules are very helpful in preventing inadvertent mixing of apples and bananas in expressions, and for that reason I think they're worth keeping.
I will put up a PR later today.

Would it be sufficient to only exclude unconstrained type parameters?

@jack-williams PR is up in #27695.


Test enhancement and homogenization

One of the changes is possible because we upgraded to Go 1.9 - https://golang.org/doc/go1.9#test-helper
The other change is to follow what's commented in the commit message.

Coverage remained the same at 80.374% when pulling 0add35e8156795c35b71b15cd70f4b7e077a1a90 on if-set-test-helper into b7afb8027a69b9717c00909807d143424b9dac21 on master.

I also added a new commit which fixes the test helper function to report an error when an error isn't returned but one it's expected.

Open an issue please, if you're interested in swapping, that's out of the context of this PR.


ERROR: (gcloud.app.deploy) Error Response: [4] App Engine Flexible timed out while configuring resources, internal operation projects/

I am not able to deploy even the Google's .NetCore demo Hello World application to my App Engine in asia-south region. It is showing error as

ERROR: (gcloud.app.deploy) Error Response: [4] App Engine Flexible timed out while configuring resources, internal operation projects/  *************/******/

while deploying. I normally use Visual Studio + Google Cloud tool for deploying. I tried using gcloud cli also. But the issue persist. When try hitting server with the url, it is showing

"The server encountered a temporary error and could not complete your request. Please try again after 30 sec."

It was working fine till 21-April which I deploy at last. Yesterday when I try deploying first it prevented with BACKEND_SERVICES quota excceds.  Updated Quota. Then trying deploying, I am seeing this issue. Able to see version as deployed, but no instance is getting created.

Tried Creating a new App Engine in another region and deployed the code, but iit is showing as Internal Error Occured.
Tried Deploying from latest gCloud Cli tool
Tried to deploy Hello World app in the GCP doc
Checked all the communities. Somebody opens a thread in SO, but not answered

Environment details

OS: Windows 10
.NET  Core version: 2.1/ 2.2
Package name and version:
Google Cloud for Visual Studio 2.0.4
Google Cloud SDK 290.0.0
bq 2.0.56
core 2020.04.21
gsutil 4.49

Attaching Verbose Logs
Updating service [default] (this may take several minutes)...|DEBUG: Operation [apps/**projectid**/operations/c46a17bd-d4a8-468f-b40b-47a7fdd03067] not complete. Waiting to retry.
Updating service [default] (this may take several minutes)...|DEBUG: Operation [apps/**projectid**/operations/c46a17bd-d4a8-468f-b40b-47a7fdd03067] not complete. Waiting to retry.
Updating service [default] (this may take several minutes)...\DEBUG: Operation [apps/**projectid**/operations/c46a17bd-d4a8-468f-b40b-47a7fdd03067] not complete. Waiting to retry.
Updating service [default] (this may take several minutes)...\DEBUG: Operation [apps/**projectid**/operations/c46a17bd-d4a8-468f-b40b-47a7fdd03067] not complete. Waiting to retry.
Updating service [default] (this may take several minutes)...-DEBUG: Operation [apps/**projectid**/operations/c46a17bd-d4a8-468f-b40b-47a7fdd03067] complete. Result: {
    "done": true,
    "error": {
        "code": 4,
        "message": "App Engine Flexible timed out while configuring resources, internal operation projects/**projectid**/regions/asia-south1/operations/700238de-3add-4281-80f8-6dc66948a715"
    },
    "metadata": {
        "@type": "type.googleapis.com/google.appengine.v1.OperationMetadataV1",
        "createVersionMetadata": {
            "cloudBuildId": "38b57f34-3b23-4484-9d69-0c581995947f"
        },
        "endTime": "2020-04-23T23:40:50.335Z",
        "insertTime": "2020-04-23T23:29:10.164Z",
        "method": "google.appengine.v1.Versions.CreateVersion",
        "target": "apps/**projectid**/services/default/versions/20200424t045856",
        "user"<EMAIL_ADDRESS>    },
    "name": "apps/**projectid**/operations/c46a17bd-d4a8-468f-b40b-47a7fdd03067"
}
Updating service [default] (this may take several minutes)...failed.
DEBUG: (gcloud.app.deploy) Error Response: [4] App Engine Flexible timed out while configuring resources, internal operation projects/**projectid**/regions/asia-south1/operations/700238de-3add-4281-80f8-6dc66948a715
Traceback (most recent call last):
  File "C:\Google\CloudSDK\google-cloud-sdk\lib\googlecloudsdk\calliope\cli.py", line 983, in Execute
    resources = calliope_command.Run(cli=self, args=args)
  File "C:\Google\CloudSDK\google-cloud-sdk\lib\googlecloudsdk\calliope\backend.py", line 807, in Run
    resources = command_instance.Run(args)
  File "C:\Google\CloudSDK\google-cloud-sdk\lib\surface\app\deploy.py", line 111, in Run
    return deploy_util.RunDeploy(
  File "C:\Google\CloudSDK\google-cloud-sdk\lib\googlecloudsdk\command_lib\app\deploy_util.py", line 634, in RunDeploy
    deployer.Deploy(
  File "C:\Google\CloudSDK\google-cloud-sdk\lib\googlecloudsdk\command_lib\app\deploy_util.py", line 431, in Deploy
    self.api_client.DeployService(new_version.service, new_version.id,
  File "C:\Google\CloudSDK\google-cloud-sdk\lib\googlecloudsdk\api_lib\app\appengine_api_client.py", line 204, in DeployService
    return operations_util.WaitForOperation(
  File "C:\Google\CloudSDK\google-cloud-sdk\lib\googlecloudsdk\api_lib\app\operations_util.py", line 307, in WaitForOperation
    completed_operation = waiter.WaitFor(
  File "C:\Google\CloudSDK\google-cloud-sdk\lib\googlecloudsdk\api_lib\util\waiter.py", line 261, in WaitFor
    operation = PollUntilDone(
  File "C:\Google\CloudSDK\google-cloud-sdk\lib\googlecloudsdk\api_lib\util\waiter.py", line 322, in PollUntilDone
    operation = retryer.RetryOnResult(
  File "C:\Google\CloudSDK\google-cloud-sdk\lib\googlecloudsdk\core\util\retry.py", line 229, in RetryOnResult
    if not should_retry(result, state):
  File "C:\Google\CloudSDK\google-cloud-sdk\lib\googlecloudsdk\api_lib\util\waiter.py", line 320, in _IsNotDone
    return not poller.IsDone(operation)
  File "C:\Google\CloudSDK\google-cloud-sdk\lib\googlecloudsdk\api_lib\app\operations_util.py", line 182, in IsDone
    raise OperationError(requests.ExtractErrorMessage(
googlecloudsdk.api_lib.app.operations_util.OperationError: Error Response: [4] App Engine Flexible timed out while configuring resources, internal operation projects/**projectid**/regions/asia-south1/operations/700238de-3add-4281-80f8-6dc66948a715
ERROR: (gcloud.app.deploy) Error Response: [4] App Engine Flexible timed out while configuring resources, internal operation projects/**projectid**/regions/asia-south1/operations/700238de-3add-4281-80f8-6dc66948a715

Thanks for the report. I'm not very familiar with AppEngine flex, but I'll see what I can find out.

Hmm... I've just tried to reproduce this, using exactly the "Hello World" sample in dotnet-docs-samples, and it worked for me.
Are you able to try this again? I wonder whether it was a transient error.

@jskeet,  Really Appreciate your effort. Still I am getting the same error while deploying. I am still able to see msg as "The server encountered a temporary error and could not complete your request." while hitting this server url directly.
But now I  am able to deploy the changes in a GAE Project running US East, and is working fine for now.

But now I am able to deploy the changes in a GAE Project running US East, and is working fine for now.

Ah, so you're only seeing the problem in the asia-south region? I'll see if I can reproduce that next week - although it'll probably involve creating a new project...

I can share the Project details privately If you want. I am really sorrry to say that it will be difficult in my position to give you the access.

If at all possible, it'll be best to do this without access to your project :) If it's only in a single region, that may well be something that's transient, too... if you're able to try again on Monday too, that would be helpful. But otherwise I should be able to create a project - it'll just take a little longer.

Hi @Shanmt,
Before I start creating a project in asia-south, have you been able to check whether this is still an issue?

I tried again on the same project. It is still showing timeout issue while deploying. Showing 502 while hitting this server url directly. But the project that I created in region US-East is working fine as of now. I don't know if it is a particular issue with this app engine/ region wise server issue. Adding to the current issue,  I am having the problem  in Project X(asia-south) and Project Y(US east) is working fine . If Iocally init the gcloud with Project X (which is having 502 problem) and if I try to deploy Project Y from Visual Studio Google Cloud tools, even selected correct Project in the tools, it is failing to deploy.

Okay, thanks. I'll create a project with AppEngine in asia-south and see if I can reproduce the problem.

I've somewhat reproduced this problem, but with a different error message. Mine ended with just:
Updating service [default] (this may take several minutes)...failed.
ERROR: (gcloud.app.deploy) Error Response: [4] Timed out waiting for the app infrastructure to become healthy.

That may be because I didn't ask for verbose logs.
Trying with Python now.

Just received the exact same issue for Python, so this is at least not .NET specific. Will chase it internally.

@jskeet , Thanks man, I am not sure, but the issue you are facing is probably due to some quota issues. . I think, I am facing Error 13 issue.

Hmm... will check, thanks. This is a brand new project, so I'd hope that wasn't the problem. Interestingly, despite the timeout error, it has managed to create the version of the .NET application.

yes same here, But no instance is created. Right ?

Yes. I'm running it again with --verbosity=debug. The Cloud Build part finished okay. No sign of quota issues yet.
(I've pinged a Product Manager internally, as he's likely to have a better idea of what's going on - I'm not an AppEngine specialist by any means.)

Hmmm... that finished with a different verbose error to yours:
Result: {
    "done": true,
    "error": {
        "code": 4,
        "message": "Timed out waiting for the app infrastructure to become healthy."
    },
    "metadata": {
        "@type": "type.googleapis.com/google.appengine.v1.OperationMetadataV1",
        "insertTime": "2020-04-28T09:40:41.554Z",
        "method": "google.appengine.v1.Versions.CreateVersion",
        "target": "apps/jonskeet-issue-4903b/services/default/versions/20200428t103934",
        "user": "[...]"
    },
    "name": "apps/[...]/operations/26277863-31d5-4ae6-82df-02ab463afbe7"
}

(Just to keep you informed, I'm talking about this with folks internally. I haven't forgotten about it!)

Thanks Jon Skeet..
Sent from Mailhttps://go.microsoft.com/fwlink/?LinkId=550986 for Windows 10
From: Jon<EMAIL_ADDRESS>Sent: 01 May 2020 22:26
To<EMAIL_ADDRESS>Cc<EMAIL_ADDRESS><EMAIL_ADDRESS>Subject: Re: [googleapis/google-cloud-dotnet] ERROR: (gcloud.app.deploy) Error Response: [4] App Engine Flexible timed out while configuring resources, internal operation projects/ (#4903)
(Just to keep you informed, I'm talking about this with folks internally. I haven't forgotten about it!)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/googleapis/google-cloud-dotnet/issues/4903#issuecomment-622469409, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACT2QG5HU2L6AA4VKFW7JADRPL5KPANCNFSM4MPTOF7A.

I'm afraid I can't reveal too much of the inner workings, but we understand why it's failing (and it looks like it is still failing).
The error message we should be getting is this:

The region asia-south1 does not have enough resources available to fulfill the request. Please try again later.

That would at least be slightly clearer than the timeout. I'm afraid I don't have any information as to when more resources will be available in that region.
At this point, I think we're at the limit of how I can help you. Are you happy for me to close this issue?

(I didn't actually mean to close it until you'd confirmed you were happy for me to do so... I hit the wrong button. But I'll leave it that way for now...)

I am already running this on region Us East. I really appreciate what you are doing and very much thanks for your time. But other than  that I've logged this issue on GCP bugsilla. I am not getting any response yet. I don't know what to say.

I think everything's basically understood now:

The asia-south1 region is apparently short of resources right now, at least in some respect. (There are complexities there I don't fully understand.)
The deployment should fail quickly with an error message as per my earlier comment; we have an internal bug open for that.

I don't think you need to chase this any further on the GCP bug tracking - I think everything is covered internally now. I'm sorry that there's nothing we can do to make more resources available, but that's a somewhat different matter.

HI @jskeet ,
are south asia region facing same issue, still ?

@rahulkadam: I don't know whether it's "still" or "again" - but if you're seeing the same results, I expect it's due to the same cause.

@jskeet  thanks for quick reply,
can you provide some info from below error,  that will be helpful
GCLOUD: ERROR: (gcloud.app.deploy) Error Response: [4] App Engine Flexible timed out while configuring resources, internal operation projects/sattafantasy/regions/asia-south1/operations/cde8fe7f-5a57-40be-a49d-269cb2ed5cde

@rahulkadam: I don't have any more information I can give, I'm afraid. I strongly suspect you'll see exactly the same error if you try deploying a Java or Python application; it's an App Engine issue rather than anything to do with .NET, and I really only know about the .NET client libraries.
You can try using --verbosity=debug as I did earlier in this thread and see what the result is, but I'm afraid I wouldn't have any more information for you. You'd be better off asking on one of the App Engine-specific support areas where the readers are likely to have more App Engine knowledge.

thanks @jskeet , appreciate your help

I have the same problem :
RROR: (gcloud.app.deploy) Error Response: [4] Timed out waiting for the app infrastructure to become healthy.


style(Tab): update style according to design

name: 'TabComponent'
about: Restyle TabComponent according to design
New Pull Request
Checklist

[x] I am not disclosing a vulnerability.
[x] My code is conform the code style
[x] I have made corresponding changes to the documentation
[x] I have updated Typescript definitions when needed

Issue Description

Related issue: #664
Updated <Tab /> States styling:

Default
Active
Hover
Disabled

@BillyG83 please have a look again :)


Allow configuring a base uri for MarkdownString

Feature request
Allow configuring a base uri that is used when rendering the contents of a MarkdownString. This uri would be used when resolving relative paths that appear as links or image links within the markdown string
Example use case
const md = new vscode.MarkdownString(`
[link](toSiblingFile.md)

![img](./image/from/dir.gif)
`);

md.baseUri = vscode.window.activeTextEditor.document.uri

When rendered, link and img should both resolve to files next to the currently active file
Related issues

#130968

The alternative today is that extensions have to parse the markdown and transform the uris themselves. This is difficult to get correct

@dbaeumer is this something that should be in the LSP spec (for servers to set), or the client (assuming they should be relative to the document the request relates to)?


Services: Not clear you need to pass JSON-compatible data with MessageResponse.send(String)

FlutterView.MessageResponse.send() takes a String, but sometimes it actually has to be passed JSON-compatible strings, when the Dart side called sendJSON.
If you pass a non-JSON string in response to sendJSON, you will get an exception.
For API navigation and clarity when code completing, it would be really nice if there was something like MessageResponse.send(JSON json) in response to Dart's sendJSON. This makes it very clear that the response must be JSON.
Thanks!

fyi @faisalabid

@mravn I think this doesn't apply in the new framework?

No longer applies.


Refactor Elastic conf to not require S3 credentials for development deployment

Currently, the elastic-conf service throws an error when any of the args is missing, this includes ~ELASTICSEARCH_SNAPSHOT_REPO, which is an S3 repository. As mentioned by @philbudne it isn't a necessity to have S3 credentials for a dev deployment.
To do; refactor the elastic-conf to capture the above
Question: Should we have a dev.sh file in private config repo to maintain any dev deployment secrets?

If we want to continue running/testing SLM in dev, using a filesystem repository rather than S3 is probably the better approach; should eliminate the need of S3 credentials in dev.

Question: Should we have a dev.sh file in private config repo to maintain any dev deployment secrets?

My preference: no.  People should be able to test/develop code without access to any secrets.

Resolved in #295


Updates ingress manifests for docs/examples to networking.k8s.io/v1

Checklist

[X] The title of the PR is clear and informative
[ ] If applicable, the changes made in the PR have proper test coverage
[ ] Issues addressed by the PR are mentioned in the description followed by Fixes.

Description

Updates ingress manifests for docs/examples to networking.k8s.io/v1
Fixes

This overlaps with #1185 (does not include all) and #790 (open for some time now and focuses on the whole project)

https://github.com/Azure/application-gateway-kubernetes-ingress/pull/1197 got merged to add support for V1 ingress. Still more tests need to be added to validate that it works on all cluster versions and ingress api versions.

Closing as docs/examples have been updated.


Added W2019_1809_17763-2061

@nasbench I'm thinking we should probably add build numbers to our folders. Thoughts? I have lots of ISOs with various build numbers, so we could get that far into the weeds, if we want.

Great idea. As you said this will give us great details when want to dig that deep.


Xcode 7 bate3 many error

Array String Dictionary

+1

+1
Some API become unavailable, it's quite hard to fix it on own way

+1

+1

+1

https://github.com/ayn/ExSwift/tree/Swift-2.0


[Misc] Debugging React Native in browser

The good thing about front-end web technologies is that there are a lots of people who know how to quickly debug them just in the browser using DOM inspector. What is the point about making mobile application with CSS, if I can't use the benefit of DOM inspector? Alright, I can just follow the docs + common sense and hope that everything will always just work, but there will be for sure situations where inspecting CSS might be really helpful. There are already toolkits out there (Cordova/Ionic), where you can run your mobile app directly in the browser and debug it from there.
So we need to be able to open React Native app in the browser, develop it from there, and then run it in xCode. That would probably mean to incorporate React.js components to substitute React Native component's inside browser, using some CSS/JavaScript similar to what http://touchstonejs.io/ or http://www.idangero.us/framework7/ are making.

The good thing about front-end web technologies is that there are a lots of people who know how to quickly debug them just in the browser using DOM inspector. What is the point about making mobile application with CSS, if I can't use the benefit of DOM inspector? Alright, I can just follow the docs + common sense and hope that everything will always just work, but there will be for sure situations where inspecting CSS might be really helpful.

I would argue that is not the good thing but one of the good things about it. You get many benefits of using CSS-like styles in React Native :smile: - such as familiar syntax, Flexbox layout, etc. Additionally, inspecting CSS should be much less of an issue in React Native where you must use inline styles, because you don't have to worry about the cascade - so you should just be able to look at your component file and see the styles right there.
That said, inspecting elements is certainly useful and efforts are underway to add an element inspector to React Native. You can try it right now by installing from master npm i facebook/react-native#master --save. You can expect it to become more fully featured over time!

There are already toolkits out there (Cordova/Ionic), where you can run your mobile app directly in the browser and debug it from there.

This works fantastic for them, and the reason is that the only context the app ever runs in is inside of a browser, so whether that's a WebView on an iPhone in Chrome, it's the same thing. React Native does not run inside of a WebView - you are interacting with real native UI components.

So we need to be able to open React Native app in the browser, develop it from there, and then run it in xCode. That would probably mean to incorporate React.js components to substitute React Native component's inside browser, using some CSS/JavaScript similar to what http://touchstonejs.io/ or http://www.idangero.us/framework7/ are making.

As far as I know, this is not on the roadmap. You're more than welcome to investigate yourself and try to make this work!

cc @vjeux

@Dharmoslap - #182

@Dharmoslap - also see #770

@brentvatne: can you consolidate all those issues into one that's about implementing core components on web? Not going to happen anytime soon but should be tracked somewhere

Consolidating this issue into #182 :smile:


Hide window on start up macos

Hi,
How can I hide the window and remove the icon from the dock  on startup on macos?
thanks.

In the example in main()->doWhenWindowReady() I commented out win.show(); and the app starts without showing the window.
PS:
and if you want to start the application without having an icon in the task bar on macos you have to add in macos/Runner/Info.plist in your project directory:
<key>LSUIElement</key>
<true/>


Incorrect parsing of "0 0 2/4 * * ?"

"0 0 2/4 * * ?" is parsed like "Every 4 hours". There is no "starting from 2.00am every day".

I might be missing something but I can't tell what the issue is...
Starting from 2:00 AM Every Day is "0 2 * * *" which the library will just output as:

At 2:00 AM


Improve FormData logging (or documentation)

Describe the problem
I'm always frustrated when working with await event.request.formData() because it is not easily log-able.
export async function post(event) {
    const body = await event.request.formData()
    console.log('body', body)
    console.log('body', body.entries())
    console.log('body', body.keys())
    console.log('body', body.values())
    ...

All those simple measures during development to see if form data arrives and what values are contained do not work with current SvelteKit:
body FormData {}
body Object [Generator] {}
body Object [Generator] {}
body Object [Generator] {}

Especially the fact that a simple console.log(body) yields no sense-making output is very irritating to me. As a SvelteKit newbie it took me an hour to understand that it's not a problem with the data transfer but only with the way I want to display the data.
Describe the proposed solution
const body = await event.request.formData();
console.log(body);

should show body content, formatting doesn't really matter.
[ [ "name": "Rich Harris" ], [ "hobbies", "svelte" ], [ "hobbies": "journalism" ] ]

Alternatives considered
Add an example to the endpoint body parsing documentation.
const body = await event.request.formData();
const entries = [...body.entries()];
// [ [ "name": "Rich Harris" ], [ "hobbies", "svelte" ], [ "hobbies": "journalism" ] ]

Importance
would make my life easier
Additional Information
No response

I don't think we want to mess with the toString on this polyfill (nor on the native FormData in environments where we can use that). I have mixed feelings about whether we should include an example of this, rather than just linking to MDN.

Yeah, we definitely don't want to be monkey-patching or mucking about with prototypes. The MDN FormData documentation also isn't much help in this regard though.
Logging is pretty straightforward once you know how...
const body = await event.request.formData();

// to get everything
console.log(...body); // ["name", "Rich Harris"] ["hobbies", "svelte"], ["hobbies", "journalism"]

// if you know you don't have duplicates
console.log(Object.fromEntries(body)); // { name: "Rich Harris", hobbies: "journalism" }

...and the same thing applies to lots of similarly-shaped objects (Map, URLSearchParams, etc).
I'm always a little torn in situations like this. If Svelte/SvelteKit docs need to show how to use various web APIs (including things like Request and Response) then they'll quickly get bloated. At the same time, many developers will encounter those APIs for the first time while using Svelte, and it can be hard to find relevant/high quality documentation elsewhere. There's no right answer.

I just learned something from that solution but I am not in favor of putting general javascript recipes into the Svelte (Kit) docs. imho.

Just had a similar experience with request.headers. This time I could log it, but not pass it around.
console.log(request.headers) works, JSON.stringify(request.headers) returns {}.
console.log(...request.headers) works, JSON.stringify(...request.headers) returns only parts, JSON.stringify([...request.headers]) works again.
Object.fromEntries(request.headers) works perfectly, you just need to know about is.

Thanks for clarification, will close issue.


[SPARK-43495][BUILD] Upgrade RoaringBitmap to 0.9.44

What changes were proposed in this pull request?

Why are the changes needed?

Does this PR introduce any user-facing change?

How was this patch tested?

Will update bench result and pr description later

Merged to master

Thanks @srowen


feat(1818): sales table for better engagement

feat: page for sale engagement
feat: saels feed query
feat: init page for sales
refactor: update time format
refactor: using basic image
feat: popup for larger nft image

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.
PR type

[ ] Bugfix
[x] Feature
[ ] Refactoring

What's new?

[x] PR closes #1818
[ ] <brief_description_of_what_I've_added>

Before submitting Pull Request, please make sure:

[x] My contribution builds clean without any errors or warnings
[x] I've merged recent default branch -- main and I've no conflicts
[x] I've tried to respect high code quality standards
[x] I've didn't break any original functionality
[x] I've posted a screenshot of demonstrated change in this PR

Optional

[ ] I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
[ ] I've tested PR on mobile and everything seems works
[ ] I found edge cases
[ ] I've written some unit tests 🧪

Had issue bounty label?

[x] Fill up your KSM address: Payout

Community participation

[x] Are you at KodaDot Discord?

Screenshot

[x] My fix has changed something on UI; a screenshot is best to understand changes for others.

https://user-images.githubusercontent.com/11361147/168977069-7b0001b9-cfca-4a2f-97fc-84d920dbfd29.mov

lgtm, cant merge yet though because of merge conflict ☹

pay 500

😍 Perfect, I’ve sent the payout
💵 $500 @ 74.68 USD/KSM ~ 6.695 $KSM
🧗 DaWoVNNhBTdqJ5iPN3UcaLeamkPpJeGWdrs8LhvX9TQbadc
🔗 0x4c7928d8c9f2701a557e59701ab05c76aef7323eb4f011709892d55dfa10b158
🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues


"BuildStarted" status

Dummy pod name from #519 appears in pod Get response while startPodForBuild is being processed (which may take few seconds in rare cases).
Fixes https://github.com/knative/build/issues/542#issuecomment-459802297
Proposed Changes

BuildStarted condition instead of dummy status and non-existent pod name

Release Note
NONE

/ok-to-test

cc @rawlingsj as author of #519

I'm a bit worried this PR has started to solve three problems:

increasing the resync time
enforcing timeouts
handling duplicate pod creation cleaner

For now the PR is fairly small and easy to follow, but I'm worried about how much bigger it will get when there are tests. If it's possible to split this into three PRs that might be easier to review.

@ImJasonH thanks for review, I'm totally agree with it. Going to close this PR and open new ones with all comments taken into consideration.


fix: make lake exe cache get in post-update hook conditional

This is required for projects that want to run lake update without lake exe cache get, until lake gets the ability to turn off post-update hooks.

bors merge


Delete mocha.js

Requirements

Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
All new code requires tests to ensure against regressions.

Description of the Change

Alternate Designs

Why should this be in core?

Benefits

Possible Drawbacks

Applicable issues

.

It is mocha's one of entry points. Don't delete it.


feat(travis): upload docs and client to S3

This change uses Travis CI's artifact feature to store build information
in S3. Specifically we'd like a client and a doc build so that we can test
and view changes for a specific build with these artifacts, as the rest of
the build artifacts are Docker images, uploaded to Quay.io and DockerHub.
We need to some new environment variables to the workflow job in order for this to work:

ARTIFACTS_KEY
ARTIFACTS_SECRET
ARTIFACTS_BUCKET
ARTIFACTS_S3_REGION

closes #61

note that we still need to also update the relevant documentation. I'll file a followup PR for that :)

also one more thing yet to be checked out: how to symlink the latest artifact built. That way devs won't have to go check what the latest travis build on master said the download URL is for the client.
this seems relevant: https://github.com/travis-ci/artifacts#example-multiple-target-paths

I've also updated the documentation so it should be mostly correct once we get this PR up and running.

keys have been added to the job. Here goes nothing!


Update remote state docs to recommend generate first

The comment in https://github.com/gruntwork-io/terragrunt/issues/2104 made me realize that our remote state documentation is a bit misleading. We default to recommending the remote_state block for setting up your remote state configuration, but in reality, that may not be the best option for all use cases.
For example, one could use generate blocks instead to manage the backend config, which works well just like remote_state; the main difference being that terragrunt does not try to manage the remote state objects when using generate, whereas the design of remote_state blocks is to have terragrunt manage your state buckets.
For this reason, this PR proposes to revamp the remote state docs to instead recommend:

Using generate blocks to generate a terraform block containing the backend subblock.
Recommend using remote_state block if users want to additionally have terragrunt manage the state resources, like automatically creating and updating them.

Thanks for review! Going to merge this in now.


Add contributing to community post

Hey @theo-england, could you give this a review and let me know if we can post it? :) Thanks!

@jaysonesmith This reads really nicely. Feel free to push!


refactor: lazy loading for greengrass data client as pcks plugin not available during the factory creation.

Issue #, if available:
GG-37592
Description of changes:
pkcs11 crypto key service is not running during the factory creation so configuring it during the get call.
Why is this change necessary:
pkcs plugin won't work without this
How was this change tested:
manual testing
Any additional information or context required to review the change:
Checklist:

[ ] Updated the README if applicable
[ ] Updated or added new unit tests
[ ] Updated or added new integration tests
[ ] Updated or added new end-to-end tests
[ ] If your code makes a remote network call, it was tested with a proxy
[ ] You confirm that the change is backwards compatible

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Verify that there are no additional places that call the newly-blocking methods


Update to gradle 8.0.2

Description
Starting a draft pull request to understand required efforts for migration to gradle 8. Reference PR from core: https://github.com/opensearch-project/OpenSearch/pull/5666

Category (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)

Maintenance
Issues Resolved
N/A
Check List

[ ] New functionality includes testing
[ ] New functionality has been documented
[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

The failing tasks come from the OpenSearch repo, seems like we should open an issue to resolve?
* What went wrong:
Some problems were found with the configuration of task ':validateMavenPom' (type 'PomValidationTask').
  - Gradle detected a problem with the following location: '/home/runner/work/security/security/build/distributions/opensearch-security-<IP_ADDRESS>.pom'.

    Reason: Task ':validateMavenPom' uses this output of task ':generatePomFileForPluginZipPublication' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed.

    Possible solutions:
      1. Declare task ':generatePomFileForPluginZipPublication' as an input of ':validateMavenPom'.
      2. Declare an explicit dependency on ':generatePomFileForPluginZipPublication' from ':validateMavenPom' using Task#dependsOn.
      3. Declare an explicit dependency on ':generatePomFileForPluginZipPublication' from ':validateMavenPom' using Task#mustRunAfter.

    Please refer to https://docs.gradle.org/8.0.2/userguide/validation_problems.html#implicit_dependency for more details about this problem.
  - Gradle detected a problem with the following location: '/home/runner/work/security/security/build/distributions/opensearch-security-<IP_ADDRESS>.pom'.

    Reason: Task ':validateMavenPom' uses this output of task ':generatePomFileForNebulaPublication' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed.

    Possible solutions:
      1. Declare task ':generatePomFileForNebulaPublication' as an input of ':validateMavenPom'.
      2. Declare an explicit dependency on ':generatePomFileForNebulaPublication' from ':validateMavenPom' using Task#dependsOn.
      3. Declare an explicit dependency on ':generatePomFileForNebulaPublication' from ':validateMavenPom' using Task#mustRunAfter.

    Please refer to https://docs.gradle.org/8.0.2/userguide/validation_problems.html#implicit_dependency for more details about this problem.

Codecov Report

Merging #2520 (7ba64bb) into main (8d7b904) will decrease coverage by 0.08%.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@             Coverage Diff              @@
##               main    #2520      +/-   ##
============================================
- Coverage     61.27%   61.20%   -0.08%
+ Complexity     3332     3327       -5
============================================
  Files           260      260
  Lines         18504    18504
  Branches       3268     3268
============================================
- Hits          11339    11326      -13
- Misses         5571     5579       +8
- Partials       1594     1599       +5

Impacted Files
Coverage Δ

...ecurity/configuration/StaticResourceException.java
0.00% <0.00%> (-25.00%)
:arrow_down:

...urity/ssl/transport/SecuritySSLNettyTransport.java
62.36% <0.00%> (-4.31%)
:arrow_down:

...nsearch/security/dlic/rest/api/AuditApiAction.java
64.58% <0.00%> (-4.17%)
:arrow_down:

...earch/security/ssl/util/SSLConnectionTestUtil.java
93.18% <0.00%> (-2.28%)
:arrow_down:

...ensearch/security/compliance/ComplianceConfig.java
81.94% <0.00%> (-1.39%)
:arrow_down:

...search/security/transport/SecurityInterceptor.java
75.38% <0.00%> (-0.77%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Chrome extension build example

Would you please point me in the right direction?  I would like to build the hive-keychain chrome extension..

Hi! We re refactoring the extension to use React but as of now there is nothing to build.
You just need to clone from github, go to your browser extension page, activate dev mode and select "Load unpacked" (might vary depending on browser).

Thank you

I'm trying to get to a build that I can verify as much of the code as possible.  Some "vendor" libraries are not clear by looking at the start of the file.
Do all of these libraries in "vendor" have builds on npm?  What package and version are you using?
crypto-js
decode
hive
md5
ssc

decode is created via browserify (see the decode_wrapper folder), the rest have builds on npm but I'm guessing its not up to date by now.
The current code is a mess, it started as a simple project and grew a lot, that's why we are refactoring. If you want to contribute, I would strongly suggest that you wait a couple of months until we're done (see the refactor branch that uses React)

Thanks .. I just wanted to verify the code before I put my private key in..


Add support for a two-Qubit swap gate

Add support for a two-Qubit swap gate (not to be confused with an entanglement swap)
The Qubit class defined in netqasm.sdk.qubit currently supports the CNOT and CZ two-qubit gates.
The SWAP two-qubit gate is not natively supported by NetQASM.
As a temporary work-around, we can construct a SWAP gate out of three CNOT gates as described here: https://algassert.com/post/1717

'mov' is actually a swap, from looking over the code.


Add collection_methods_unrelated_type to core

This new rule guards against a super-set of code which iterable_contains_unrelated_type and list_remove_unrelated_type guard against. These two rules are in core.yaml, and could be replaced by collection_methods_unrelated_type.
https://dart-lang.github.io/linter/lints/collection_methods_unrelated_type.html

All for adding this, with the same reasoning as the existing related lints (which then become unnecessary, #118).

Approved for core.


changefeedccl: support connecting to kafka with ssl

PR: https://github.com/cockroachdb/cockroach/pull/35510
From release notes:

CHANGEFEEDs now support TLS connections to Kafka. [#35510][#35510] {% comment %}doc{% endcomment %}

Closing - part of #3992.


Accessing google.maps.Map Object

I'm running into a little bit of a snag right now, because I'm changing the size of a map's container which means I need to call google.maps.event.trigger(map, 'resize'), where map is the google.maps.Map instance associated with the map, to get Google's JS to recognize the newly resized container.  What I'm doing now is using refToMyGoogleMapInstance.props.map, which is a horrible hack that's reaching into your component's internal state (and also I'm not exactly sure how it's working at all, because I'm accessing a prop that I never put there myself.  I assume it has something to do with all the component cloning you're doing in your render methods).  Would you consider adding (or welcome a PR to add) a getMap() method on GoogleMap to get easier access to the instance you need for triggering events and whatnot?

I'm actually not a big fan of exposing a map instance to public. However, this is definitely an issue. How about having a triggerEvent utils exposed? Something like:
import {triggerEvent} from "react-google-maps/libs/utils";

function componentDidResized () {
  triggerEvent(this._googleMapComponent, "resize");
}
// and you'll get `this._googleMapComponent` like this:
<GoogleMap ref={(it) => this._googleMapComponent = it} />

// The implementation of `triggerEvent` is quite simple
function triggerEvent (component, ...args) {
  const instance = null /* some magic to get Google Maps instance from react-google-maps component */;
  return google.maps.event.trigger(instance, ...args);
}

That would also be great.  Anything that can save me from having to do
this kludgy hack in my own code is a plus in my book :p
On 11/30/2015 09:21 PM, Tom Chen wrote:

I'm actually not a big fan of exposing a map instance to public.
However, this is definitely an issue. How about having a
|triggerEvent| utils exposed? Something like:
import  {triggerEvent}from  "react-google-maps/libs/utils";
function  componentDidResized  () {
triggerEvent(this._googleMapComponent,"resize");
}
// and you'll get this._googleMapComponent like this:
<GoogleMap ref={(it)=>  this._googleMapComponent  =  it}/>
// The implementation of triggerEvent is quite simple
function  triggerEvent  (component, ...args) {
const  instance  =  null  /* some magic to get Google Maps instance from react-google-maps
component */;
return  google.maps.event.trigger(instance, ...args);
}
—
Reply to this email directly or view it on GitHub
https://github.com/tomchentw/react-google-maps/issues/161#issuecomment-160827083.

Oh cool! Are you writing a book for React? Looking forward to it.

 Are you writing a book for React? Looking forward to it.
—
Reply to this email directly or view it on GitHub
https://github.com/tomchentw/react-google-maps/issues/161#issuecomment-160839030.

Hahaha, okay. This happen to me.

I'd appreciate this as well. I'm trying to set the center of the map in a "fire-and-forget" way, where certain events might set the map center, but the user is free to move the map around after that. I'm unable to see how to get the "real" current center in handlers for events like onCenterChanged. I can only get the center that I initially set in props.
The only way I can see to set the center through React is through props or state. This setting gets reapplied whenever the component gets updated. So, any time the user clicks on a marker, the map jumps back to the last location the map center was programmatically set.

Released v4.7.0

Hello!
New message, please read http://alvisfashion.co.uk/handsome.php?q
Robert Bieber

@bieber what the hell is this?

The gmail app is reporting the notification email from GitHub as spam.

It is, sorry, my email apparently got cracked :/

Sorry to hear this :( @bieber

Hello,
Sorry if this is not the place for the question im about to make. Im struggling with the same problem that has been talked on this thread, but im not able to fix it. Trying to reach the the map object with ref did not work, and im wondering if some sample or help code might be available.
Thanks

Hello!
New message, please read http://stock-bazar.ir/conversation.php?w8
Robert Bieber

The Map object obtained through the ref is not a google.maps.Map Object, it is a react component? Storing this object in a redux store results in a cyclic data structure I think. Is there any way we could obtain the actual google.maps.Map Object?

@jenyckee yes, it's a React component of course.
There is a hacky way to get underlying google.maps.Map object but it's just an implementation detail. Please check the source code, thanks!

If you use a flux architecture you'll probably want to have access to the map in other components, how can I do this then a not hacky way?

@jenyckee If you use flux architecture, you can define actions to control the map. The components that wants to update the map can dispatch those actions to fire map updates.
The actions are handled by a store that contains the state of the map.
Finally the component that renders the map would just use the state in your store to implement the logic to render the map. If you need some programmatic updates that use the original google map object, you can place them in this component in the componentWillMount or componentWillUpdate hook or componentWillReceiveProps hook, depending how you bind your component to store updates.
I believe such an approach is usually well decoupled, and not hacky, as your components will not have to rely on implementation details about how to access the original google map instance.

Hi so what is the hacky way to get the google map instance ?, I'v looked through the code but can't figure it out

I think this is not convenient way to work with this library, but...
const service = new google.maps.places.PlacesService(map.context.__SECRET_MAP_DO_NOT_USE_OR_YOU_WILL_BE_FIRED)
service.nearbySearch({
    location: map.getCenter(),
    radius: 500,
    type: ['store']
}, processResults)

function processResults(results, status, pagination) {
    // ...
}

Is there any better way to get PlacesService from Google Places API working with react-google-maps?

@michaltakac find a better way?

@andrewdamelio no. And didn't get fired yet.

@tomchentw
Perhaps I've missed something, but I just realized that the getMap() method is not publicly exposed anymore after upgrading to 6.3.
What was the reason behind hiding it?
Like other people have mentioned it's still possible to access it through __SECRET_MAP_DO_NOT_USE_OR_YOU_WILL_BE_FIRED, but is obviously discourage by the name.
So what's the preferred way of accessing the underlying map for creating custom controls etc?

Ok, so it seems like there is a cleaner way.
A list of constants referring to the underlying deprecated identifiers seems to have been added in version 7.0, so we can import the map constant like this:
import { MAP } from 'react-google-maps/lib/constants
And since its exposed through context we can access it in the child components like this:
static  contextTypes = {     [MAP]: PropTypes.object   };
Still not an ideal solution, but cleaner than using the reference directly through its deprecated name.

import { MAP } from 'react-google-maps/lib/constants

@sjovall good catch!

import { MAP } from 'react-google-maps/lib/constants';  just gives me a ____SECRET_MAP_DO_NOT_USE_OR_YOU_WILL_BE_FIRED --what am I  supposed to do with this?

@studio174 if you must do such thing, read the source code of v8.0.0. It should be intuitive.
https://github.com/tomchentw/react-google-maps/blob/030c6748f8b3521a23fc1165c24f3e5faab6c96f/src/components/GoogleMap.jsx#L229-L239

@j-quelly that is the constant used to represent the ominous name of the map instance.  You can use it to access the map instance and control is as needed.  For example you can disable and enable map controsl like this:
import React, {Component} from 'react'
import {withScriptjs, withGoogleMap, GoogleMap} from 'react-google-maps'
import {MAP} from 'react-google-maps/lib/constants'

@withScriptjs
@withGoogleMap
export default class MyGMap extends Component {
  state = {
    disabled: false
  }

  componentDidMount () {
    this.mapInstance = this.mapNode.context[MAP]
  }

  componentDidUpdate (prevProps, prevState) {
    if (prevState.disabled !== this.state.disabled) {
      if (this.state.disabled) {
        this.mapInstance.setOptions({
          disableDoubleClickZoom: false,
          draggable: false,
          scrollwheel: false,
          zoomControl: false
        })
      } else {
        this.mapInstance.setOptions({
          disableDoubleClickZoom: true,
          draggable: true,
          scrollwheel: true,
          zoomControl: true
        })
      }
    }
  }

  render () {
    return (

         ({
          disabled: !currentState.disabled
        }))}>toggle disabled

        <GoogleMap ref={(el) => { this.mapNode = el }} />

    )
  }
}

@sjovall Could you please give an example? I have started to learn React recnetly, and can not see what you mean.

@sjovall Here is an example.
export class MyPolygon extends React.Component {

    static contextTypes = { [MAP]: PropTypes.object };
    constructor(props, context) {
        super(props, context);
        this.myRef = React.createRef();
    }

    handleRightClick = () => {
        console.log(this.context[MAP]);
    };

    render() {
        return (
            <Polygon ref={this.myRef} path={this.props.path} onRightClick={this.handleRightClick}/>
        )
    }
}

I learned from How to handle React context in a reliable way. Thanks

const google = window.google;
it will work please try it .


Job does not run at the specified time Delayed job.

Hi,
Using the Delayed job, have been set to start 30 minutes later, the job will not start even at that time.
What time zone settings that?
Environment is Heroku, are set to Asia / Tokyo time zone.

Can you include a little more information?
Are you running the required rake resque:scheduler job?  If so, what is the output, if any?  Which version of resque, resque-scheduler, redis are you using?

I've run into a similar issue. I enqueue_at a job, it shows up as a Delayed Job in the web interface (timestamp is 2011-10-22 16:30:00 -0700), but it never gets queued. I'm running rake resque:scheduler, the output is:
2011-10-22 16:42:31 Reloading Schedule
2011-10-22 16:42:31 Loading Schedule
2011-10-22 16:42:31 Schedule empty! Set Resque.schedule
2011-10-22 16:42:31 Schedules Loaded

I've tried restarting the scheduler rake task to see if it would then notice the 'past due' delayed job, but it does not. I'm running resque (1.19.0), resque-scheduler (2.0.0.e), redis (2.2.2). My rake file is like so (the lack of an initial schedule is intentional):
namespace :resque do
  task :setup do
    require 'resque'
    require 'resque_scheduler'
    require 'resque/scheduler'

    Resque.before_fork = Proc.new {ActiveRecord::Base.establish_connection}
    Resque::Scheduler.dynamic = true
    Resque.schedule = {}

  end
end

Figure out my problem. Running rake resque:scheduler does not pickup the rails environment, where I have an initializer for pointing Resque to the proper Redis instance. So, my scheduler was pointing to localhost while my web site was pointing to a remote Redis. To fix the problem, I switched to using this command rake environment resque:scheduler. See: http://news.ycombinator.com/item?id=1555136

You can also modify the rake task definition for resque:setup to
include the environment.
On Oct 22, 2011, at 2:16 PM, Scott Bonds
<EMAIL_ADDRESS>wrote:

Figure out my problem. Running rake resque:scheduler does not pickup the rails environment, where I have an initializer for pointing Resque to the proper Redis instance. So, my scheduler was pointing to localhost while my web site was pointing to a remote Redis. To fix the problem, I switched to using this command rake environment resque:scheduler. See: http://news.ycombinator.com/item?id=1555136
--
Reply to this email directly or view it on GitHub:
https://github.com/bvandenbos/resque-scheduler/issues/114#issuecomment-2493345

Closing this ticket.


Finalize implementation of AddMessage form & method

Should be fixed by React front-end, Implement MessageController, and Implement MessageService in Kanbamps.


revert: remove .vscode folder and add to .gitignore

I don't know if this was added on purpose or by accident. I don't think we should include files in the repo that interfere with local IDE configuration.

yeah agreed - would be nice to have these files still defined and referenced in the documentation somewhere for others to know how to setup sig + vscode before we remove them

fixed this in #201


Removes Python 2.6 and Python 3.1-3.3 code, Improves Python 3.5 syntax

Changed shebang to be more platform-neutral.
Warnings encountered with Python 3.5 were fixed.
Old Python 2.6 and Python 3.1-3.2 code was removed.

I also took the liberty of removing Python 3.3 but am happy to put that back in if anybody is actually using nltk on Python 3.3.  I suspect that the numbers are very small and don't reflect anything more than people playing around since most real work is probably happening on 2.7 or 3.5.
PIP is also discussing the removal of Python 3.3.

Removing dead code from Python2.6 looks good but we might have to run some tests to check that it doesn't break something else.

Thanks @adamn, @alvations. I'm going to merge this and then try to deal with whatever our CI server shows up.

I've dropped 3.3 from our CI server config.

Thanks for the merge.  I'm happy to look into Python 3.6 when it's in beta.  Since 3.6 is still alpha and the changes will be minimal there's no point to do it too soon.


[FreeRDP] update to 2.3.2

Describe the pull request
Update FreeRDP to the latest version 2.3.2
Note : no feature need to test

@zhongjohnson, could you check the cla? may need resign again?

I didn't find where to "resign" the CLA, let's just cancel this PR.

Related to https://github.com/microsoft/vcpkg/pull/18242


[MastodonBridge] Add support for GoToSocial

GoToSocial expects URLs in HTTP Signatures to include the query string; Mastodon does not. To provide support for both types of ActivityPub services, define a new parameter for signature types, defaulting to Mastodon's format.
This change also introduces auto-resolution of linked objects, which GoToSocial uses instead of including content directly in a user's outbox.
Resolves #3008

I haven't tested but looks fine. Thanks.


The pretrained model of STL-10

In table13, the reported pretrained model of STL-10 is ViT-B-P16-96. But in your code, the pretrained backbone is mae_pretrain_vit_base. I am curious which one is used in your paper?

The backbone is ViT-B-P16-96 and the pretrained checkpoint used is "mae_pretrain_vit_base".
This is not conflict because the difference between them is only the position embedding which will be resized from 196 (224 images) to 36 (96 images), with the same patch size of 16.

Thanks to your quickly response.


Add general measurement entry

This PR solves https://github.com/nomad-hzb/nomad-chemical-energy/issues/20
I decided to exclude .py .pynb and .archive.json from possible file endings. Because I could not solve it otherwise I also  excluded .json files.
For files who do not match any other parser the HZB_GeneralMeasurement entry is created. This entry links to the sample if the filename is SampleID.fileending or SampleID-somename.fileending and the sample with the specified ID already exists.
For already existing parsers the name has to be SampleID.fileending otherwise the sample gets not linked automatically. I am not sure if I should change that behavior in all existing parsers. Maybe you can comment on that.

I somehow can't add anak-velazquez as a reviewer. Maybe she does not have the permission?

I added ana with write access

This is sth we need to test properly. I think we need to test that this parsing happens last or only if no other parser is matching. For example what happens if we have a .dta file from CE_NOME with an id at the beginning etc. did you think about this already? i am not 100% sure how to do it.

I agree that we need to test it properly. I thought that this general thing should be the very last parser that is used. Nomad says in the documentation that

The nomad infrastructure keep a list of parser objects (in nomad/parsing/parsers.py::parsers). These parser are considered in the order they appear in the list. The first matching parser is used to parse a given file.

So I imagined this new parser to always be the last in the list.

Hey how about adding the sample reference as a reference with out edit to ParsedGeneralMeasurementFile
to this section?

This is sth we need to test properly. I think we need to test that this parsing happens last or only if no other parser is matching. For example what happens if we have a .dta file from CE_NOME with an id at the beginning etc. did you think about this already? i am not 100% sure how to do it.

I agree that we need to test it properly. I thought that this general thing should be the very last parser that is used. Nomad says in the documentation that

The nomad infrastructure keep a list of parser objects (in nomad/parsing/parsers.py::parsers). These parser are considered in the order they appear in the list. The first matching parser is used to parse a given file.

So I imagined this new parser to always be the last in the list.

did you test it a bit? that would be perfect :)
i ddnt know that

ok cool

it somehow looks longer then i expected but it is what i meant. thanks :) i think this is a nice mechanism, i still have to test locally

Yes, somehow I am not sure if this is really the shortest/fastest way to do it. But I could not think of a way where you don't need a seach query in at least one of the entries because you need info from the old and also the new. And with search it directly gets quite long.

I think all requests are resolved from my side.
The only open question I can remember: When uploading new files the filename should start with the sampleID. At the moment we check for sampleID.fileending or sampleID-somename.fileending and then automatically link to the sample. Since the ID at the moment is always AaBb0001 (8 characters) I could also read out the first 8 characters and don't deal with the - instead. If you have any opinions on this, please let me know.

Otherwise, I think everything is done for this PR. Of course you are also welcome to test.


Lock into provider version for DA

Description
DAs should be locked into an exact provider version instead of using a range to ensure the same version is used in a specific version of a DA. By using >= it means the latest will always be pulled and something could break in a later version of a provider on a DA version that had been working fine.
Release required?

[ ] No release
[x] Patch release (x.x.X)
[ ] Minor release (x.X.x)
[ ] Major release (X.x.x)

Release notes content

Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
/run pipeline

Checklist for reviewers

[ ] If relevant, a test for the change is included or updated with this PR.
[ ] If relevant, documentation for the change is included or updated with this PR.

For mergers

Use a conventional commit message to set the release level. Follow the guidelines.
Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
Use the Squash and merge option.

/run pipeline

:tada: This PR is included in version 2.4.1 :tada:
The release is available on:

GitHub release
v2.4.1

Your semantic-release bot :package::rocket:


Probably: Fixes broken notifs

I'm not very good at rust and this code is a little hard to read, so I'm not sure if I did all of this right - would appreciate a code review. Basically, slack allows you to pass a value to the text parameter after you have already passed a value to blocks, and it will send that as what it calls "fallback text". Slack will use this in places they can't display blocks, like in notifications or the mentions tab of the mobile app.
I changed some indenting on this to conform with existing formatting - I recommend appending ?w=1 to the GitHub URL so that it shows non-whitespace changes.

the build is failing due to rocket but i didn't mess with rocket - not sure why that's happening.

Current master fails because of Rocket. It's not anything to do with
you.

Please run cargo fmt on this PR.

Since Travis isn't working I'm going to run tests locally - please hold

LGTM

I think the changes you requested were for an old version? I don't see any merge conflicts committed on the version you reviewed... I've merged master in for the hotfix from a few days ago, but I don't see where I would fix any committed merge conflicts.