Cannot limit number of rerolls for a die using "o" operatior

So, in Legend of the Five Rings 4e, there is a mechanic called Emphases that allow the player to reroll any dice that roll a 1, but only the first time they roll a 1.
Roll20 has an "o" operator which its documentation states is an "only once" operator, which is used in tandem with the "r" reroll operator., so e.g. /r 10d10k10ro1 would roll 10 d10, keep all of them, and reroll1s the first time they come up.
I just tested Sidekick on a server on 2019-07-29, and the "r" operator seems to exist and behave as I'd expect, but the "o" operator results in an error message.
Since a LOT of L5R 4e games I'm lately tend to use Discord and Sidekick, I think this will be a useful feature, especially as it is a generic operator that could be utilized by any system with a "reroll only once" mechanic.
(Also, per the Patreon page, it seems issues lodged by patrons get priority, and I am a Patron and can validate this if needed.)

@ryushinji , we're currently working on #195, will look into the o operator and Five Rings right after the internal communication rewrite. Thanks for your support.

Sorry for the delay. I've checked the code and we're currently only rerolling once.
// #31: Parse https://wiki.roll20.net/Dice_Reference#Rerolling_Dice.
named! (reroll (&str) -> DiceOp,
  do_parse! (char! ('r') >> spec: nom_le_ge >>
    (DiceOp::Reroll {le_ge: spec.0, face: spec.1, lim: 1})));

      DiceOp::Reroll {le_ge, face, lim} => {
        let mut idx = 0;
        let mut recurrent = 0;
        loop {
          if idx >= rolls.len() {break}
          if recurrent >= lim {recurrent = 0; idx += 1; continue}  // Protect against an infinite loop, "1d1r1".
          if !rolls[idx].counts {recurrent = 0; idx += 1; continue}
          if !le_ge_match (rolls[idx].face, le_ge, face) {recurrent = 0; idx += 1; continue}
          rolls[idx].counts = false;
          let new_face = roll (dice.faces);
          rolls.insert (idx + 1, Roll {face: new_face, counts: true, failure: false});
          recurrent += 1;
          idx += 1}},

E.g. [A = 1, B = 2, C = 1] will become [A = ~1~, Ar = x, B = 2, C = ~1~, Cr = x].
I think we can reroll more than once by increasing the lim, but I'm not sure what the actual lim should be. Rerolling indefinitely doesn't sound right to me. E.g. /r 1d1r1 would not compute.


[feature] support wildcard or dynamic prompt to output more different results

maybe Read the input field of the prompt directly as llm prompt will be a good way
and vision llm seems not working, with error log:
Traceback (most recent call last):
  File "E:\stable-diffusion-webui-forge\venv\lib\site-packages\gradio\queueing.py", line 536, in process_events
    response = await route_utils.call_process_api(
  File "E:\stable-diffusion-webui-forge\venv\lib\site-packages\gradio\route_utils.py", line 285, in call_process_api
    output = await app.get_blocks().process_api(
  File "E:\stable-diffusion-webui-forge\venv\lib\site-packages\gradio\blocks.py", line 1919, in process_api
    inputs = await self.preprocess_data(
  File "E:\stable-diffusion-webui-forge\venv\lib\site-packages\gradio\blocks.py", line 1650, in preprocess_data
    processed_input.append(block.preprocess(inputs_cached))
  File "E:\stable-diffusion-webui-forge\venv\lib\site-packages\gradio\components\image.py", line 197, in preprocess
    return image_utils.format_image(
  File "E:\stable-diffusion-webui-forge\venv\lib\site-packages\gradio\image_utils.py", line 30, in format_image
    path = processing_utils.save_pil_to_cache(
TypeError: save_pil_to_file() got an unexpected keyword argument 'name'

thanks for your great work！

a new problems. when multi batch will use the 1 prompt from the first batch. i can't just roll many image in different scene.

and import setting seems not work

maybe Read the input field of the prompt directly as llm prompt will be a good way

do u mean sd-prompt directly for llm-user-prompt?
I feel sd-prompt leave for pytorch vae lanten space keyword. Ex 1girl. llm-user-prompt leave for human us use. Is it better right?

yes, sd-prompt directly for llm-user-prompt maybe easier to support wildcard. pytorch vae lanten space keyword seems not that important for flux. only use the Natural language could also get a great image

okie, after FLUX i seems have the same feeling too, therfor add a checkbox like  [USE SD-PROMPT AS LLM-PROMPT]?

the vision issue, sd-web-ui work well but forge show the error above(TypeError: save_pil_to_file() got an unexpected keyword argument 'name')? let me install forge try it.

okie, after FLUX i seems have the same feeling too, therfor add a checkbox like  [USE SD-PROMPT AS LLM-PROMPT]?
the vision issue, sd-web-ui work well but forge show the error above(TypeError: save_pil_to_file() got an unexpected keyword argument 'name')? let me install forge try it.

issue2 should be ok now. [hotfix] change gradio.Image type from path to PIL.Image avoid copy paste img source wo a real file obj.

import setting and vision llm work after update! 🎉🎉

okie, after FLUX i seems have the same feeling too, therfor add a checkbox like  [USE SD-PROMPT AS LLM-PROMPT]

oh! we still need a place to input  and lora tag.
add a checkbox like  [USE SD-PROMPT AS LLM-PROMPT] seems not the best way to do. my bad

okie, after FLUX i seems have the same feeling too, therfor add a checkbox like  [USE SD-PROMPT AS LLM-PROMPT]

oh! we still need a place to input lora name and lora tag. add a checkbox like [USE SD-PROMPT AS LLM-PROMPT] seems not the best way to do. my bad

oh~ i forgot it too;
u can try new feature LLM-Text-Loop

okie, after FLUX i seems have the same feeling too, therfor add a checkbox like  [USE SD-PROMPT AS LLM-PROMPT]

oh! we still need a place to input lora name and lora tag. add a checkbox like [USE SD-PROMPT AS LLM-PROMPT] seems not the best way to do. my bad

oh~Lora... i forgot it too;
u can try new feature LLM-Text-Loop

i tried that feature, but i don't understand how it work🥲, and it seems to break the system prompt of [LLM-text]

a new problems. when multi batch will use the 1 prompt from the first batch. i can't just roll many image in different scene.

I use a js to do this job😂
let clickCount = 0;
function clickButton() {
    var generateButton = document.querySelector("#txt2img_generate");

    if (generateButton) {
        generateButton.click();
        console.log('clicked');

        clickCount++;

        //       click times ↓
        if (clickCount < 10) {
            setTimeout(clickButton, 90000); // wait 90s to next click
        } else {
            console.log('done!');
        }
    } else {
        console.warn('button not found');
    }
}

clickButton();

batch mean same prompt with different random seed.
u can try Before after action
whats ur purpose ?
why not just rightClick on Generate  choice Generate forever

every image with Different LLM-Answer prompt was best, or in every batch count have Different prompt from LLM-Answer, not different random seed
I tried Before after action. it need user to write a file to replace [LLM-Your-Prompt]
I want in the same [LLM-Your-Prompt]，but each batch count or single image could have Different prompt from LLM-Answer
I tried rightClick on Generate choice Generate forever, but all the image use the same LLM-Answer prompt. And with js scripts single click will be more LLM-Answer for each batch of t2i gen

batch=2 -> click gen -> llm-ans1 -> image1(llm-ans-1) , image2(llm-ans-1) | same content but different style.
next time gen click -> llm-ans2 got 2 image same prompt 2 style
work like above, that is not u expect？

batch=2 -> click gen -> llm-ans1 -> image1(llm-ans-1) , image2(llm-ans-1) | different content same style.
next time gen click -> llm-ans2 got 2 image same prompt same style
work like above, that is not u expect？

i expect: set batch count=3 -> click gen -> llm-ans1>batch1, llm-ans2>batch2, llm-ans3>batch3

but now was: batch count=3 -> click gen -> llm-ans1>batch1,2,3 (3image in completely same prompt), //not expect

I think the Advantages of Auto LLM is to generate many prompts. More batches should get more different prompts. Not many pictures in a same prompt. is not much different from using llm externally and copy into the webui.


Clean up panel tabs and icons

This PR cleans up the following items in the panel:
Tabs

Adjusts font-size and line-height so that are consistent with the tabs in settings
Adjusts margin on first item so that the spacing equals 20px
Reduces the spacing between tab titles so they equal 20px (instead of 36px)
Adjusts vertical padding so they align horizontally with right actions

Actions

Aligns input items vertically via flex-box instead of margins
Reduces the height of the filter input so it is vertically centered
Adjusts margin/padding so they are even with action icons

Icons

Adjusts icons so they fit on a 16x16 square
Makes the clear icons identical across tabs
Adjusts color of icons that are not consistent

Example showing adjustments:

Fixes #19052
/cc @bpasero

@misolori it looks like the close button is now larger, could that be? I think actions should be aligned to the editor toolbar (when tabs are disabled):

@bpasero yes, I did slightly increase the close button from 8.717 px to 10px to closer align with the other icons that are 14px.
I'm not following on the actions being aligned to the toolbar, can you elaborate?

@misolori I just thought if we change the size of icons in a toolbar, the size should be changed in other places too, no? We use the close action also in the editor toolbar to close an editor and if tabs are disabled it will show up in a quite similar location as the panel actions.

Looks great The only thing I notice is that overflow active/focus underlines aren't working sometimes in this build. I don't see this on insiders:

@misolori thanks a lot for this great PR. Here's some feedback after trying it out:

Same as @Tyriar I noticed that the blue focus sometimes disapears - this is due to the fact that it is a couple of pixels below the title and now there is probable not enough space for it to be rendered.
when dragging a panel tab  the tab image is very blurry compared to the insiders
Clear icon is not the same in the panel area and in the search and extensions. We should use the same icon everywhere especialy since the search can be moved to the panel and then it is particularly inconsistent.   "search.location": "panel" if you want to do that
off topic: panel icons still feel too heavy and out of place to me (look at that giant plus). Though I think you have a differnt PR where you look into icons

Nice work!

@bpasero I updated the rest of the close icons. I noticed that you had previously updated the icon color for the close-inverse.svg (from #C5C5C5 to #e8e8e8 ). I updated the color to be consistent with the rest of the toolbar icons (#c5c5c5 ). Let me know if you want to change that back.
@Tyriar I updated the height of the toggle more button that was causing the border to be cut off so it should work now:

@isidorn

See response above for border getting cut off
I'm not able to repro this blurriness, can you send a video example? What would cause this to be blurry?.
Updated the clear icon for the search + extension views
Completely agree with the heaviness of the icons, hoping to address this in another PR soon 😁

I also updated the spacing on the tabs so that they're uniform when they're dragged (still equals 20px). Here's a before and after:

@misolori looks great and if others agree I will merge this in.
Here's a gif showin the blurry tab. First is your branch - notice how it is not so crisp, second is stable. I do not find this to be a big issue, so we can merge even if you plan to fix this later.

@isidorn thanks, I'll create an issue to track the blurry problem and make a fix later.


Add a possibility to work as a vertical slider

#684
Added option vertical(default false) to switch lory to work as a vertical slider.

Nice work! I will check it out and test if everything works as expected. Please align your commits to https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md#commit, otherwise semantic release doesnt know what to do.

@lacedon Did you try this out with the examples in the index file because it seems to me that this does not work at all?

Actualy, no, I didn't, but I'm using it on my project as vertical and as horizontal slider.
I'll try to check it and fix my commits tomorrow.

Pull request was redone here: #693.


add tests using https://travis-ci.org

add tests using https://travis-ci.org and create a document on how to integrate with Travis.

@alanzchen add reference to PR if any. If we use selenium later on in tests, refer to https://github.com/udmis/flasky/pull/5 on how to set it up.

@alanzchen can you just add one test using selenium (such as login) so that we can setup travis and close this one.

Here is an example from Conference: https://gist.github.com/harrywang/b805dc3d1316b8576596390699bc4771


Fix mesosphere apt fingerprint key id > 40 chars

Updates the mesosphere apt key fingerprint to be 40 characters for new puppet changes
Apt_key[Add key: E56151BF from Apt::Source mesosphere] (warning): The id should be a full fingerprint (40 characters), see README.

Thanks, looks good. Could you just fix the specs. It ain't very intelligent test, but it's good to check that the key value is set.

closing for now and will get tests added, thanks

Just pushing more commits to the same branch would be enough :)


BLE GATT notification: no information about the state of the notifications queue

I can schedule notifications and they are queued up to some point. When queue is full data is lost but I am not notified about it. Also as there is no callback informing notification was sent, I cannot tell if there is place on the queue to put a new notification.
Is there a way to get information about state of the queue where notifications are stored, or even better get a callback when notification is being send?

There is no such thing as a queue limit, the TX will keep queueing forever, what it should happen instead is if there are no buffer available which means bt_gatt_notify can block until a buffer becomes available. Obviously, if a thread is blocked it won't be able to queue more data, in which case I would see a point of having a timeout, which is something that perhaps applies to more than bt_gatt_notify so the thread can give up or retry if the notification is not sent within that time.
Btw, I don't think HCI provides an event to when a specific packet is sent, we assume that is on Packet Complete but afaik that doesn't guarantee it was sent over the air, anyway for a transaction that actually has a response that perhaps is not needed and those that don't need response do normally block so waiting for a complete event maybe tricky because the callback might be called from a different context, possible RX thread.

@pdunaj is this a duplicate of #7659 ?

I don't think HCI provides an event to when a specific packet is sent, we assume that is on Packet Complete but afaik that doesn't guarantee it was sent over the air

Well, the spec does say that it has either been sent over the air or flushed (which is not possible for BLE):
The Number Of Completed Packets event is used by the Controller to indicate
to the Host how many HCI Data Packets have been completed (transmitted or
flushed) for each Connection_Handle since the previous Number Of
Completed Packets event was sent to the Host.


Cannot install bleno with nodejs 10.x in a raspberry pi zero. V8_DEPRECATED error

Hi,
I'm trying to install the bleno module for node 10.15.0 using either a package.json file or just by running the npm install bleno I'm getting the following error:
 binding.target.mk:99: recipe for target 'Release/obj.target/binding/src/BluetoothHciSocket.o' failed
make: *** [Release/obj.target/binding/src/BluetoothHciSocket.o] Error 1
make: Leaving directory '/home/pi/dev/nodejs/node_modules/bluetooth-hci-socket/build'
gyp ERR! build error
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/opt/nodejs/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:262:23)
gyp ERR! stack     at ChildProcess.emit (events.js:182:13)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:240:12)
gyp ERR! System Linux 4.14.79+
gyp ERR! command "/opt/nodejs/bin/node" "/opt/nodejs/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /home/pi/dev/nodejs/node_modules/bluetooth-hci-socket
gyp ERR! node -v v10.15.0
gyp ERR! node-gyp -v v3.8.0
gyp ERR! not ok
npm notice created a lockfile as package-lock.json. You should commit this file.
npm WARN<EMAIL_ADDRESS>No description
npm WARN<EMAIL_ADDRESS>No repository field.
npm WARN<EMAIL_ADDRESS>license should be a valid SPDX license expression
npm WARN optional SKIPPING OPTIONAL DEPENDENCY<EMAIL_ADDRESS>(node_modules/xpc-connection):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for<EMAIL_ADDRESS>wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"arm"})
npm WARN optional SKIPPING OPTIONAL DEPENDENCY<EMAIL_ADDRESS>(node_modules/bluetooth-hci-socket):
npm WARN optional SKIPPING OPTIONAL DEPENDENCY<EMAIL_ADDRESS>install: `node-gyp rebuild`
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: Exit status 1

It seems that it's trying to use an old bluetooth-hci-socket version that using the deprercated V8 macro
While compiling it emmited this error:
../src/BluetoothHciSocket.cpp: In member function ‘void BluetoothHciSocket::emitErrnoError()’:
../src/BluetoothHciSocket.cpp:275:72: error: no matching function for call to ‘v8::Function::NewInstance(int, v8::Local<v8::Value> [1])’
   Local<Value> error = errorConstructor->NewInstance(1, constructorArgs);

Any idea?
Maybe the package.json should be changed in order to use the @abandonware/bluetooth-hci-socket module.

This is not an issue with bleno but with one of the used packages:
https://github.com/noble/node-bluetooth-hci-socket/issues/84
https://github.com/noble/node-bluetooth-hci-socket/pull/91

An update to Node10 would be great!

A quick solution is to point bleno's package.json dep for node-bluetooth-hci-socket to "@abandonware/bluetooth-hci-socket": "^0.5.3-5"
Got it building on my raspi 4, after having the exact error posted in the OP.
https://github.com/arthare/bleno/commit/596acd9f32f889b8757f66bde23e25f488644259

I'm using @abandonware/bleno with node.js 12.19 and so far everything works well.

I followed @arthare advices, I'm running it with NodeJs 15 like a charm, thank you.

I followed @arthare advices, I'm running it with NodeJs 15 like a charm, thank you.


Update Vision to V1.1

Both @quartzmo and @swcloud have contributed these changes, but are unfortunately out for the next several days. So I'm submitting this PR for them.

What is causing the circle CI to be yellow? It looks to pass to me.

Not sure. Maybe an upstream dependency on S3? Too soon? :trollface:


MyPy Type Checking in CI

Add static type checking to the ci pipeline using MyPy. Since the codebase already utilises the typing module, it would be useful  to ensure type safety by integrating Mypy checks. Improvement to Ref #12 .

@suzanneEmbury As this issue is mainly an incremental improvement to the CI pipeline workflow, I can wait until the previous PR addressing Ref #12 has been merged before I create a new PR. If you would instead prefer a separate file for type checking I can create a PR by the end of this week.

Just in case @nigelmj or anyone is interested in picking up this suggested change, PR #12 has been merged now.


AzureCliCredential.get_token failed: Please run 'az login' to set up an account

azure.identity:
azure-identity==1.14.1:
Ubuntu 22.04.3 LTS / Linux <IP_ADDRESS>-microsoft-standard-WSL2:
Python 3.10.12 :

Describe the bug
I have AZ CLI installed
{
  "azure-cli": "2.53.1",
  "azure-cli-core": "2.53.1",
  "azure-cli-telemetry": "1.1.0",
  "extensions": {}
}

Here is my simple Python script I am running as python3 test.py after performing successful az login
test.py
import os
import pandas as pd
from datetime import datetime, timezone
from azure.monitor.query import LogsQueryClient, LogsQueryStatus
from azure.identity import AzureCliCredential
from azure.core.exceptions import HttpResponseError

endpoint = "https://ade.loganalytics.io"
workspace = "/subscriptions/<workspace ID>"
credential = AzureCliCredential()
client = LogsQueryClient(credential, endpoint=endpoint)

query = """MyCustomTable_CL | take 1"""

start_time=datetime(2023, 10, 20, tzinfo=timezone.utc)
end_time=datetime(2023, 10, 21, tzinfo=timezone.utc)

try:
    response = client.query_workspace(
        workspace_id=workspace,
        query=query,
        timespan=(start_time, end_time)
        )
    if response.status == LogsQueryStatus.PARTIAL:
        error = response.partial_error
        data = response.partial_data
        print(error)
    elif response.status == LogsQueryStatus.SUCCESS:
        data = response.tables
    for table in data:
        df = pd.DataFrame(data=table.rows, columns=table.columns)
        print(df)
except HttpResponseError as err:
    print("something fatal happened")
    print(err)

I am getting
AzureCliCredential.get_token failed: Please run 'az login' to set up an account
something fatal happened
Please run 'az login' to set up an account

To Reproduce
Steps to reproduce the behavior:

See above

Expected behavior
AzureCliCredential does not throw an error

Hey, @alukyan. Can you try rerunning the script after adding the following two lines near the top?
import logging
logging.basicConfig(level=logging.DEBUG)

Hopefully this might show a bit more information.
In any case, seems like the endpoint that you are specifying could be causing issues. If you are using Azure public cloud, you shouldn't need to specify any endpoint as the default endpoint (https://api.loganalytics.io/v1) will be used. I'm not familiar with the https://ade.loganalytics.io endpoint or if it's even serving the Monitor query API, but that very likely could be the culprit since the audience for token authentication is derived from that endpoint
Another observation is that workspace should be in the format of UUID (e.g. XXXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXX), but it looks like you are passing in an Azure resource D. This is doable, but you'd use a different method as shown in this sample.

@pvaneck
Thanks a lot for your response and guidance.
I changed the code to use query_resource() method and used default endpoint and the code now works.
I think we can close this issue, however I think that the error message can be improved. Right now the error message is misleading. It made me think that there is a problem with the credential, not the input data to the query_workspace() method.
Also, if the workspace ID is expected to be a GUID it makes sense for the Monitor query API to validate the input and return an informative error message back.

@alukyan, glad you got it working, and I appreciate the feedback. Not really sure why the error message wasn't giving more information in your case. Typically, you'd get some AAD error message saying there were issues with the audience.
However, I can look into adding some validation for the workspace_id. While it's not always a GUID (i.e. DEMO_WORKSPACE is valid), it still might be worthwhile to check if the string passed in follows the resource ID format, then suggesting the correct method in the error.


Timetable v1.2

[x] Display empty resizable timetable
[x] Add and remove timeslots on backend
[x] Parse add and remove commands on backend
[x] Make unit tests for add and remove timeslots
[x] Display timeslots in timetable
[x] Make timetable with timeslots resizable
[ ] Create deconflicted timetable (moved to v1.3)
[ ] Parse deconflict command on backend (moved to v1.3)
[ ] Make unit tests for timetable deconflicting methods (moved to v1.3)

closes issue #25 . this wound up much much longer than i expected it to be


[bug] IE11 ngf-select gets called twice.

This is happening with IE11 version 11.212.10586.0
I caught this when calling a function on my model in the nfg-select directive.
here's what it looks like:
<div style="padding: 2px 12px 2px 10px;"
       class="btn btn-success pull-left"
       ngf-select="item.imageChanged($file);"
       ng-model="item.imagefile"
       type="file"
       accept=".jpg,.jpeg,.png, image/jpg, image/png, image/jpeg"
       ngf-pattern="'.jpg,.jpeg,.png'"
       ngf-min-height="1080"
       ngf-max-height="1080"
       ngf-min-width="1920"
       ngf-max-width="1920">

and the model from my service:
var imageItem = {
    imagefile: [],
    image: new fileAsset(null, '', '', '', '', false),

    imageChanged: function imageChanged(file) {
        if (file == null) { return;}
         //if (file == null) {
         //    this.image.file = null;
         //    return;
         //}
        this.image.file = file;
    }
}

I added the line "if(file == null) {return ;}" to catch the bug, but the commented area is what should happen when ngf-select calls item.imageChanged($file); .
In FF, Chrome, Edge...  everything works as should, ngf-select gets called once, the file data is set..
However, in IE, it gets called twice.. basically nullifying "this.image.file", which is not what is intended.

I am now using ng-device-detector to check for IE, with this workaround (and having to add a call counter because of the double call in ngf-select, also happens with nfg-change for IE):
if (internalDevice.browser == 'ie') { //workaround for IE11
                        if (this.changeCounter == 0 && file == null) {
                            this.changeCounter++;
                            return;
                        };
                        if (this.changeCounter > 0 && file != null) {
                            this.changeCounter = 0;
                        };
                        if (this.changeCounter > 0 && file == null) {
                            this.changeCounter = 0;
                            this.image.file = null;
                            return;
                        };
                    } else {
                        if (file == null) {
                            this.image.file = null;
                            return;
                        }
                    };

Fixed at 12.1.0


Standalone mode for clients

The idea is to have a special model like the safe mode which forbids the client to receive anything from the queue. The subscriptions are only used for a better handling in uchiwa.
https://github.com/sensu/sensu/pull/1364
Unfortunately nobody has responded to my pull request.

https://github.com/sensu/sensu/pull/1364 was closed as the SQS transport now includes a fix https://github.com/SimpleFinance/sensu-transport-snssqs/pull/8


fdp-play does not install via npm

OS: pop-os (ubuntu)
See screenshot:

Following instructions in readme, fdp-play does not start after npm install.

Can't reproduce

A reboot solved the issue for me.


angularCompile as a option in column def

Hello
is it possible to have an angularCompile option at the column definition level ? I have some use case where it's not really interesting to have angular compile at row level because of the number of columns and it is much more interesting to have at column level in order to use a directive in the first column for example.

in my understanding, you only have one new shared scope for every columns in a row, so having scope in different columns won't be different from performance side in my opinion.

not possible. the compiling is done when the entire row is created. as s-you says, the child scope is created for the row, so there would be no gain in having it done multiple times for different columns.

ok, thanks for you explanations!


FlatPak support

Vote for this feature if you'd like to see support for FlatPak repositories on Linux.
NB: Please only vote for one new package format at a time, so we can get an idea of which ones matter most.

I hope support for the Flathub store will be considered as well. :+1:

@Merrit Looks like it's accumulating votes so we may take a look soon. What's your goal with the Flathub store - is it getting updates/installs on non-Debian/Ubuntu distributions?

@mikehearn Yes, I personally use Fedora on my machines and I get my software from either RPM repos or Flathub.
For my apps on Linux I've had the best luck so far publishing on Flathub since it gives discoverability in app stores with things like a description, screenshots, links, reviews, automatic updates, etc - not to mention that packaging this way means my app is now available to essentially all linux users regardless of distro.

Right - we have some half-finished RPM support already, that's why I was asking. It might be easier to ship that first. The problem with Flatpak is the mandatory sandboxing, it can break frameworks that weren't updated to use the portals APIs. I'd worry that if we offered it, people would find it just doesn't work. Perhaps this view is behind the times though. We'd also need to implement the ostree format (or, create OCI/container flatpaks). RPMs in contrast are relatively low risk and there's a JVM library that makes them already, we just have to use it and maybe expose some metadata via the config file.

The way we do it with debs is that the deb drops a file into /etc/apt/sources.list.d so installing the deb also configures automatic updates. I guess the same is possible on Red Hat based distros. Updates are applied in the same way as normal. I think in Ubuntu at least you don't have to enter the password to apply updates, or at least, if you do then you do it once for all updates in a batch (don't quite recall). It's the system UI at any rate, we don't do any custom update UI on Linux.
Automatic background updates are pretty nice indeed. I wonder how much control the app has over them? E.g. on windows/macos we offer a feature called "aggressive updates" where the app forces an update check on every start, and any pending updates apply synchronously. So devs and users get a kind of almost web-like experience where the app is always fresh as long as it gets restarted from time to time, equivalent to the user closing and reopening a tab for a SPA. We don't currently offer that on Linux but in theory it'd be easy enough with system package managers: just run words to the effect of gsudo apt-get update && apt-get upgrade package-name if we detect the app is out of date. Perhaps Flatpak offers a portal to the same. Not a big deal if not either way, we can always just ask the user to force an update if the app finds itself to be stale.

Ah ha, there is indeed a portal API for that:
https://flatpak.github.io/xdg-desktop-portal/#gdbus-org.freedesktop.portal.Flatpak.UpdateMonitor
So with flatpak we can implement aggressive updates, super duper.

Any plans to work towards this in the near future?

Not in the near future unfortunately. The next feature priority is to expose manual updates and an update control API.

It seems like a lot of momentum is moving towards this.

Any update on this?

We've started doing some experiments and research into this, but unfortunately we can't make any promises about when or if this feature will ship.


Is there any way to change the text in a node?

Hello, I am trying to figure out if there is any way of changing the text contents of a node?
like this:

 to
Changed
.
I am aware that there is a way to get text get_node_text, but is there any way of changing it, even if you have to replace it with another node or something?
EDIT:
I have forked the library and have been able to add this (among other things). Will upload once I figure out how to get git push to work on MSYS2 .

Sorry for the delay. Do let me know or submit a pull request when you get the changes uploaded!

Done it, check Pull requests now.


WIP zathura: Enable synctex support

Things done

[x] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] OS X
[x] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Zathura has synctex support. It's enabled by passing WITH_SYNCTEX=1 to the make.
I would like to prepare the patch myself but has an issue. After adding WITH_SYNCTEX=1 to the makeFlags I get next error:
zathura/synctex.c:8:36: fatal error: synctex/synctex_parser.h: No such file or directory

I looked through Gentoo's ebuild for zathura and found it adds app-text/texlive-core to dependencies.
Adding texlive.synctex to the buildInputs doesn't help.
/cc @garbas

@rasendubi i'm a bit short on time this week, i can look at it over the coming weekend, if nobody else will pitch in.

Try to use texlive-bin as a build input, it contains this header.

@abbradar thanks for the help and valuable tip!
Fixed the patch, so it's ready for review.

Fixed

Merged, thanks! One thing that I've changed is pass texlive.bin.core by itself, not in list, to lib.optional. optional is defined like this (in Haskell-like language):
optional :: Bool -> a -> [a]
optional False _ = []
optional True a = [a]

So additional list encasing is not needed. When you need to make several items optional, use optionals:
optionals :: Bool -> [a] -> [a]
optionals False _ = []
optionals True as = as


Discord option ignores enabled checkmark

If credentials are there, it will attempt to connect.  The enabled checkbox in settings is ignored.

See also #747

Fixed in 4.0.4


fixed the upload of image for docker extension

Signed-off-by: harkiratsm<EMAIL_ADDRESS>Description
This PR fixes #5747
Notes for Reviewers
When a user try top upload image the error msg is displayed .

Signed commits

[x] Yes, I signed my commits.

@warunicorn19  Try to upload a PNG file , then it will show uploaded , but instead it should throw a error . This PR fixes that issue .


Add persistent discord link to documentation where the link to github is.

This is the link: https://discord.gg/zbCUzuxe2B

Closed with #508


Graphcool pull case sensitivity

@marktani Please enable graphcool-cli to ignore case sensitivity when pulling a project.
Currently, only a lowercase y, and an uppercase N are accepted. It would make sense to accept either for developer's preference.
If it is decided that you wish to retain the case sensitivity, some user-friendly logging should be added to request a proper response. For example, pressing Y just kills the script, no output is made, and one could be confused if it was accepted (it was not). Should be fairly simple to modify the prompt commands.

Hey @eruby94, could you help me understand which prompts you are talking about? 🙂

If I entered 'Y' as opposed to 'y', the script does not accept the input and aborts with no output

All confirmation prompts are case-insensitive in the latest CLI version.


what is DroneCores's uuid with multiple vehicles?

I don't understand UUID is  became AUTOPILOT_VERSION's uid.
To explain my situation I have five drones.
According to the example, when dronecore make a system that need UUID.
like below
DroneCore dc;
//...
//Use UUID named uuid to get the associated System
System &system = dc.system(uuid);
But in dronecore's UUID is declared AUTOPILOT_VERSION's uid. My five drones have same AUTOPILOT_VERSION's uid and have different system ID. So, my five drones collision each others.
I have question, my AUTOPILOT_VERSION's uid are same is strange or dronecore's uuid is strange?
I would be grateful if you could help with this phenomenon.

Thanks for the question. In my opinion, the issue here is that each drone simulated by SITL has the same UUID. UUID stands "Universally unique identifier", which means they should be unique 😄 .
One workaround for you would be to add something to the UUID in each of your instances, so that they differ from each other.
And note that you also need to set different system IDs for each of the drones.

Um.. in my case I don't use SITL.
My five drones in real case.  My five different drones have same UUID.....

Um.. in my case I don't use SITL.

Oh, sorry. I was just assuming that. Ok, so what PX4 version are you using on them?
And could the issue be that DroneCore is still using the field uid instead of uid2 in http://mavlink.org/messages/common#AUTOPILOT_VERSION? You can check if the uid2 field is actually different.
We are planning to move to uid2 in the future.

Good question 😄 . So I have a couple of drones but I have not used DroneCore with multiple drones at the same time. We've implemented it in a way to potentially support more than one but there might be some work left to get it to work properly.

this is my two drones.
these two drones have same uid. It is my  wondering. The situation that two drones have same value is  normal?
below two pictures are my drones version

Any my drones have PixRacer. AUTOPILOT_VERSION's uid and uid2 are same. But, ver'UIDs are different.

That's odd, the uid and uid2 should be taken from the STM32 UUID of the chip, so that shouldn't happen.
I suggest you create an issue in PX4/Firmware and add all the detail for the two Pixracers.

Thanks. I create an issue in PX4/Firmware.
What isUUID's role in dronecore? It is important?
If is not, I try to replace UUID to system ID.

yer, system ID should work too. Thea idea was to use UUID to be able to refer to individual vehicles over time and not just per session but that's currently not used yet anyway.

@Seunghwan17 Did you manage to use Dronecode SDK with multiple drones?
I am trying to do the same, and I actually would like to use system ID (MAVLink ID which can be set by QGC), but I don't even see it available in the System class
@julianoes Is the MAVLink ID provided some how by the SDK?
Thanks.

@julianoes Is the MAVLink ID provided some how by the SDK?

No, only the UUID for now. Let's close this because the PX4 Firmware issue has been fixed and follow up in #486.

@mzahana oops.. I missed your message. In my case, I edit dronecode SDK to use sys ID not a UUID. As you see this post, UUID has some problem to me. If you want, I will show this code.

Could you describe the problem that you are facing?

I am working with a set of ordered drones. They have unique NAVLink IDs. So, it is easier for me to deal with system IDs than UUIDs.

@Seunghwan17 I saw that system_id is available here
The discussion is moved to https://github.com/Dronecode/DronecodeSDK/issues/486


canvas zooming out further

would help moving along the canvas.
The mini-map helps, but it is still different from moving along the main canvas itself, specially when you have many nodes and have to segment them to different spots of the canvas

Prior to the Godot 3.4 the grid zoom functionality was quite limited specially regarding zoom.
Arrow uses the latest stable version, which now includes grid updates. I also revised the grid's default settings to allow from 10 to 400 percent zoom (0.1x to 4x.)


Need a GrantVmGroupAccess.exe utility

Note to self - will be needed for @kevpar in the SF deployment stuff to ACL initrd.img and rootfs.vhd.

Lets put it in hcsshim/tools instead of here?


provisionng failed could you support? - providing the following provisioning action correlation ID: 8fbd7c34-1b62-430e-9c53-34eb22c3e82a

Describe the issue
A clear and concise description of what the issue is.
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Details (please complete the following information):

PnP Correlation ID: [Provide a correlation ID for the provisioning action]
Reference Template: [please provide the URL of the template in the Look book site. It should be something like: https://lookbook.microsoft.com/details/{Template-ID}]
Primary language of the target tenant: [provide the LCID of the primary language of the target tenant]
Are you using a Tenant Global Admin account to provision the template: [Yes/No]

Additional context
Add any other context about the problem here.

Hi,
Thanks for using the Look Book site. Based on the event log, we can see - based on the provided Correlation ID - that you targeted an already existing site and the exception was "Forbidden". Could you please try to provision the solution to a different site URL? In case of any issue, please create another item and provide the corresponding Correlation ID for further investigation. Thanks for your cooperation.


⚠ Feedaty widget has degraded performance

In e218298, Feedaty widget (https://widget.feedaty.com/public/js/feedaty.js?merchant=10213975&style_ver=2021&data-sku=36263) experienced degraded performance:

HTTP code: 200
Response time: 5251 ms

Resolved: Feedaty widget performance has improved in 89b9d3c after 11 minutes.


Unable to open 'test.wasm': Unsupported node in printModule: Elem.

In the latest VS Code version 1.22.2, the "Show WebAssembly" function seems to be broken.
When I right click a test.wasm file and click Show WebAssembly, I get the error:
Unable to open 'test.wasm': Unsupported node in printModule: Elem.

@bitjson v1.1.0 used webassemblyjs as parser / printer. This issue related to webassemblyjs. I will try to fix this soon.
Sorry for long answer. I missed the notification :(

This has been fixed in webassemblyjs.


nonlocal value is not updated correctly

Reporting a bug

[x] I have tried using the latest released version of Numba (most recent is
visible in the change log (https://github.com/numba/numba/blob/master/CHANGE_LOG).
[x] I have included a self contained code sample to reproduce the problem.
i.e. it's possible to run as 'python bug.py'.

In inner function, nonlocal value is not updated correctly.
import sys
import numba
from numba import njit

@njit
def main():
    x = 0
    def add():
        nonlocal x
        x += 1
        x += 10
    add()
    return x

print(sys.version)
print(numba.__version__)
print(main())

The result of code above is:
3.8.10 (default, Jun  2 2021, 10:49:15)
[GCC 9.4.0]
0.53.1
1

As we can see, x += 10 does not work.

Thanks for the report. I think this is a duplicate of https://github.com/numba/numba/issues/7109


update build.rs: expose libbpf include directory

This allows user of this crate to retrieve the libbpf include dir via DEP_LIBBPF_INCLUDE environment variable.
Example of build.rs:
   let output = Command::new("clang")
        .arg("-g")
        .arg("-O2")
        .arg("-target")
        .arg("bpf")
        .arg("-c")
        .arg("./src/bpf/example.bpf.c")
        .arg("-o")
        .arg(&obj_path)
        .arg("-I")
        .arg(env::var("DEP_LIBBPF_INCLUDE").expect("Missing DEP_LIBBPF_INCLUDE environment variable"))
        .output()?;

Cool, lgtm!

Published on Crates.io as version 0.0.9-2


Relative links not work normal

What version of starlight are you using?
0.25.4
What version of astro are you using?
4.13.3
What package manager are you using?
npm
What operating system are you using?
windows
What browser are you using?
chrome
Describe the Bug
example https://github.com/testomatio/docs/blob/docs/src/content/docs/reference/reporter/pipes.md#built-in-pipes links work
But on site not https://docs.testomat.io/reference/reporter/pipes/#custom-pipe
There is no way to correct the path since the content is taken from another repository.
Link to Minimal Reproducible Example
https://docs.testomat.io/reference/reporter/pipes/#custom-pipe
Participation

[ ] I am willing to submit a pull request for this issue.

I looked in your repository and it doesn't understand .md files either.
Example https://github.com/withastro/starlight/blob/main/docs/src/content/docs/getting-started.mdx
manual setup instructions
But on site work https://starlight.astro.build/getting-started/

Hi @Arhell! Thanks for the issue.
Starlight doesn’t transform links at all, so the exact way you author them is how they are also built in the published site. For example, here’s the HTML of one of your links from the page you shared:
Testomat.io

But the built page will not include the .md extension, so you get a 404.
Additionally, in HTML, the behaviour of relative links depends on the current URL.
If the current URL is /reference/reporter/pipes, then the relative link above resolves to /reference/reporter/pipes/testomatio.md.
But if the current URL is /reference/reporter/pipes/ with a trailing slash, then the relative link above resolves to /reference/reporter/pipes/pipes/testomatio.md.
If it is important for you to keep the .md links in your Markdown, you could use something like https://github.com/rjanjic/remark-link-rewrite to transform these to the correct output when building.

Including the link to a utility that may help with this for future reference that I posted in Discord. But again, haven't tried it myself and over time I've preferred using absolute-style links as they're a lot easier to understand later for me when coming back later.
https://github.com/withastro/astro/issues/5680#issuecomment-1535211867

Including the link to a utility that may help with this for future reference that I posted in Discord. But again, haven't tried it myself and over time I've preferred using absolute-style links as they're a lot easier to understand later for me when coming back later.
withastro/astro#5680 (comment)

Thank you, in principle I agree, but I would like the site to have correct links and in the repository, so that both would open without a 404 error, as for me it is more convenient for a person


OpKernel errors after building tensorflow from sources

Instead of using pip to install pre-built tensorflow library, I downloaded the sources and manually built the library to support using my machine's CPU SIMD instructions (SSE4.1, SSE4.2, AVX, AVX2, FMA).
I've installed tensorflow from sources using the official documentation (https://www.tensorflow.org/install/install_sources#PrepareMac)
But now I'm facing an array of OpKernel errors when I use tensorflow, here is a screenshot of my terminal...

Although I ran the following commands,
pip3 install --upgrade '/tmp/tensorflow_pkg/tensorflow-1.4.0-cp35-cp35m-macosx_10_6_intel.whl'
pip3 install --upgrade 'https://storage.googleapis.com/tensorflow/mac/cpu/protobuf-3.1.0-cp35m-none-macosx_10_11_x86_64.whl'
tensorflow still raises the same errors when being imported in a session. Any help?
Operating System: OS X El Captain 10.+
Versions of installed libraries
nltk (3.2.1)
numpy (1.13.3)
olefile (0.44)
pandas (0.20.0)
pigar (0.7.1)
Pillow (4.0.0)
pip (9.0.1)
pipreqs (0.4.9)
protobuf (3.4.0)
pyparsing (2.1.10)
python-dateutil (2.6.0)
python-xlib (0.18)
pytz (2016.10)
PyYAML (3.12)
requests (2.18.4)
scikit-learn (0.18.1)
scipy (0.18.1)
setuptools (36.7.0)
six (1.11.0)
sklearn (0.0)
tensorboard (1.0.0a5)
tensorflow (1.4.0)
tensorflow-tensorboard (0.4.0rc2)
Theano (0.8.2)
urllib3 (1.22)
Werkzeug (0.12.2)
wheel (0.30.0)
yarg (0.1.9)

This has been fixed in https://github.com/tensorflow/tensorflow/commit/f0b1e65b0ac9e587c117485a96a0eaf40675c518. If you pull the latest HEAD and build again, these warnings should not appear.


{storage-preview} Add support for queue service using track2 sdk

Add az storage queue command group and its sub command groups using Python sdk track2
Add az storage message command group using Python sdk track2
This checklist is used to make sure that common guidelines for a pull request are followed.

For new extensions:

[ ] My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

storage-preview


Focus on first item by default

Hey, Great work on this. i work in Android TV aps and adapted it for TV, i was wondering if there is a way to dynamicly set focus on a program ?
By default first program or from history last channel..
Thx

ah great! il test out the different ways.thx!👍
On Mon, Jun 5, 2023, 4:08 p.m. Oleksandr Balan @.***>
wrote:

Hi 👋 Thank you!
if there is a way to dynamicly set focus on a program
Yes, first of all you can use state to scroll to the offset you need.
For example to scroll to the current time line (the vertical one):
val scope = rememberCoroutineScope()val state = rememberProgramGuideState()Button(
onClick = {
scope.launch {
state.animateToCurrentTime()
}
}
) {
Text("Focus current time")
}
There also methods to scroll to the channel, program or timeline:
state.animateToChannel(index = ...)
state.animateToProgram(index = ...)
state.animateToTimeline(index = ...)
You may also use snapTo* methods to scroll immediately without animation.
Each method accepts alignment to control where item is positioned after
scroll, by default alignment is set to center.
Secondly, when state is created you could also specify the initial offset:
val state = rememberProgramGuideState(
initialOffset = { getProgramOffset(index = ...) }
)
The initialOffset lambda should return Offset where scroll position is
initialized. This way you may control which item is focused when
ProgramGuide is loaded.  These methods also accept alignment which works the
same as in animateTo* and snapTo* methods.
getProgramOffset(index = ...)
getChannelPosition(index = ...)
getTimelinePosition(index = ...)
getCurrentTimePosition()
Also do not forget to pass the state instance to the ProgramGuide.
ProgramGuide(
state = state,
) { ... }
Check the ProgramGuideStateScreen
https://github.com/oleksandrbalan/programguide/blob/main/demo/src/main/java/eu/wewox/programguide/demo/screens/ProgramGuideStateScreen.kt
sample to see how it could be used.
—
Reply to this email directly, view it on GitHub
https://github.com/oleksandrbalan/programguide/issues/1#issuecomment-1577406634,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABOFGYTHWY3HTOCQXKULS73XJY4DLANCNFSM6AAAAAAY27S4II
.
You are receiving this because you authored the thread.Message ID:
@.***>


TypeString Bug

今天新装的系统 ，环境版本都是最新的，主要TypeString存在问题

TypeString（str） str首字母必须大写， 否则无限输出第一个字母
TypeString 不输出中文

e.g.
robotgo.TypeString("hello xxx") // hhhhhhhhhhhhhhhhh endless robotgo.TypeString("E水电费水电费") // output: E without chinese

The first question did not recur in mac, what Operating System are you using? Utf-8 is not yet supported.

OS：Linux 4.4.0-3-deepin-amd64  , the os base on ubuntu or debian
is there a plan to support UTF-8, recently?

Yep, it's in the plan.

The first question did not recur on my Ubuntu 15.04, there may be some system version of the problem.

many thanks to you

what can i do to support UTF-8, if i want to join the job.

Fork -> Patch -> Push -> Test -> Pull Request.If i want to join the job, give me a PR, thank you.

i read the source:
void typeString(const char *str)
{
	while (*str != '\0') {
		tapUniKey(*str++);
	}
}

it seems not fit to type in UTF-8 character, like Chinese .

may the repos "github.com/atotto/clipboard" can help solve this problem, i am using it to type UTF-8 character. :)

Thank you for your recommend. It 's busy in life now, wait for it, I solved it.

It's easy to solve.
`import "github.com/atotto/clipboard"
clipboard.WriteAll(text_chinese)
robot.KeyTap("v", "command")`

Good, I will use it as a transitional plan.


codesandbox template has a TypeError

🐛 Bug Report

When navigating to template for code sandbox provided in bug template, i am getting an error that prevents it from loading the preview. I tried in firefox, chrome, and waterfox and all three had the same issue.

To Reproduce
Steps to reproduce the behavior:
go to https://codesandbox.io/s/ui-kitten-welcome-x8q8z
Expected behavior

Preview should load with no errors
Link to runnable example or repository (highly encouraged)
https://codesandbox.io/s/ui-kitten-welcome-x8q8z

UI Kitten and Eva version

Package
Version

@eva-design/eva

@ui-kitten/components

Environment information

@wigleyj did you resolve this? I guess this is not UI Kitten problem, but maybe with react-native-svg or even codesandbox itself. Because UI Kitten requires includes react-native-svg as a peerDependency which means you should install both @ui-kitten/components and react-native-svg packages.

I have not been able to resolve it. I tried changing the packages versioning around to see if it was a version issue, but no go. I cant seem to get it to work on any of my browsers. I agree now that it seems more likely to be a react-native-svg or codesandbox issue, so i will go ahead and close this issue.


"Recent commits" section does not show if there are unmerged commits

Description
This is what Neogit looks like without unmerged commits:

As soon as there are unmerged commits, I see that the "Recent commits" sections is out:

I want the "Recent commits" section to show always, like it did before recent updates.
Neovim version
~/Development/memfault => nvim --version
NVIM v0.10.0
Build type: Release
LuaJIT 2.1.1713773202
Run "nvim -V1 -v" for more info
Operating system and version
Linux feanor 6.8.12 #1-NixOS SMP PREEMPT_DYNAMIC Thu May 30 07:49:53 UTC 2024 x86_64 GNU/Linux
Steps to reproduce

Create a commit
See Neogit no longer shows "Recent commits"

Expected behavior
No response
Actual behavior
No "Recent commits" section if unmerged commits exist
Minimal config
-- NOTE: See the end of this file if you are reporting an issue, etc. Ignore all the "scary" functions up top, those are
-- used for setup and other operations.
local M = {}

local base_root_path = vim.fn.fnamemodify(debug.getinfo(1, "S").source:sub(2), ":p:h") .. "/.min"
function M.root(path)
  return base_root_path .. "/" .. (path or "")
end

function M.load_plugin(plugin_name, plugin_url)
  local package_root = M.root("plugins/")
  local install_destination = package_root .. plugin_name
  vim.opt.runtimepath:append(install_destination)

  if not vim.loop.fs_stat(package_root) then
    vim.fn.mkdir(package_root, "p")
  end

  if not vim.loop.fs_stat(install_destination) then
    print(string.format("> Downloading plugin '%s' to '%s'", plugin_name, install_destination))
    vim.fn.system({
      "git",
      "clone",
      "--depth=1",
      plugin_url,
      install_destination,
    })
    if vim.v.shell_error > 0 then
      error(string.format("> Failed to clone plugin: '%s' in '%s'!", plugin_name, install_destination),
        vim.log.levels.ERROR)
    end
  end
end

---@alias PluginName string The plugin name, will be used as part of the git clone destination
---@alias PluginUrl string The git url at which a plugin is located, can be a path. See https://git-scm.com/book/en/v2/Git-on-the-Server-The-Protocols for details
---@alias MinPlugins table<PluginName, PluginUrl>

---Do the initial setup. Downloads plugins, ensures the minimal init does not pollute the filesystem by keeping
---everything self contained to the CWD of the minimal init file. Run prior to running tests, reproducing issues, etc.
---@param plugins? table<PluginName, PluginUrl>
function M.setup(plugins)
  vim.opt.packpath = {}                      -- Empty the package path so we use only the plugins specified
  vim.opt.runtimepath:append(M.root(".min")) -- Ensure the runtime detects the root min dir

  -- Install required plugins
  if plugins ~= nil then
    for plugin_name, plugin_url in pairs(plugins) do
      M.load_plugin(plugin_name, plugin_url)
    end
  end

  vim.env.XDG_CONFIG_HOME = M.root("xdg/config")
  vim.env.XDG_DATA_HOME = M.root("xdg/data")
  vim.env.XDG_STATE_HOME = M.root("xdg/state")
  vim.env.XDG_CACHE_HOME = M.root("xdg/cache")

  -- NOTE: Cleanup the xdg cache on exit so new runs of the minimal init doesn't share any previous state, e.g. shada
  vim.api.nvim_create_autocmd("VimLeave", {
    callback = function()
      vim.fn.system({
        "rm",
        "-r",
        "-f",
        M.root("xdg")
      })
    end
  })
end

-- NOTE: If you have additional plugins you need to install to reproduce your issue, include them in the plugins
-- table within the setup call below.
M.setup({
  plenary = "https://github.com/nvim-lua/plenary.nvim.git",
  telescope = "https://github.com/nvim-telescope/telescope.nvim",
  diffview = "https://github.com/sindrets/diffview.nvim",
  neogit = "https://github.com/NeogitOrg/neogit"
})
-- WARN: Do all plugin setup, test runs, reproductions, etc. AFTER calling setup with a list of plugins!
-- Basically, do all that stuff AFTER this line.
require("neogit").setup({}) -- For instance, setup Neogit

Not a bug; this is how Magit renders the status buffer with unmerged commits. You could add a "show_recent_despite_unmerged_commits" config option if you're so inclined :)

I see, sorry to have characterized it as such. I did so because the previous behavior was to keep showing "Recent commits".
If this is the design, then :+1:
THX!

No worries :)

Please consider the following.
I have list of recent commits and I would like to rebase

Go to the commit
Hit r to rebase
Rebase

Now, I commit a change and I would like to rebase to previous commit

Move away from the commit (or the below is not possible)
Hit r for rebase
There is a list of commits, but I am at the bottom of the screen, therefore move to the top of the screen
Select the commit
Rebase

Is there a way to simplify the 2nd scenario without list of recent commits?

I'm not sure if this answers your question, but you can invoke the rebase popup from both the reflog and log buffers to use the commit under your cursor as the "selection" for rebasing.

@CKolkey It seems then, after a commit, the flow could be

Enter log buffer
I am at the bottom of the screen, move to the top of the screen
Select commit
Rebase

IMHO, if there was simply list of recent commits, there would be less friction.
Alternatively, when my cursor is on "Head", "Merge" or other top-lines in the neogit buffer, then hitting r could directly go to rebase screen selecting that commit. At the moment, hitting r opens log buffer (with cursor located at the bottom).

BTW. For last couple of weeks rebasing from log buffer is broken (ll) - first line is empty instead of showing selected commit. Works as expected when using recent commits.


Added Zoom example to examples directory

I have created an example of implementing a zoom with slider feature with wavesurfer. I copied the annotations example and appended my zoom slider. I used the annotations example because this will also work with annotations. They also redraw and scale correctly with the zoom.
Please look over everything and make sure it's good to go. I built it out quickly in a separate application and copied the code over into the example/zoom directory.

Coverage remained the same at 4.17% when pulling f83ef3ddae65a161d4bf15507aec9d91d86d4ba1 on maxehnert:master into f826c167741a673e6187af17c599a8ee166209d5 on katspaugh:master.

Hi Max!
I liked your simple and elegant solution so much that I added it as a new method zoom in cc2ad8f. Will update the readme soon.
Thanks!

That's awesome! Glad I could give back to the project.


CXX-Interop: Fix missing header deps edge

The custom target dependency was an order-only dependency edge. As a result, changing the swift file wouldn't result in the header getting regenerated at the right time because nothing actually depended on it being up-to-date. This patch should fix that and ties it into the fibonacci target a little more cleanly. The generated header is marked as being one of the target sources, so the target itself depends on the header getting built. This ensures that the C++ file gets rebuilt if the header changes. The header still depends on the Swift sources in the target. We're now extracting that list directly from the target itself instead of needing to pass it in explicitly. The module is also extracted from the target itself. We're also automatically adding the location of the header include directory so that dependees can find it as part of the target interface.
Fixes #8

@afabri, I think this should fix the issue. I've tied the header generation into the target itself a little more tightly and am now seeing the header recognized as one of the dependencies in the generated dependency file from clang.
I'm also seeing that modifying the Swift file marks the header as dirty, which then cascades to the C++ file and onward resulting in a full rebuild as expected.
ninja explain: restat of output lib/fibonacci/include/fibonacci/fibonacci-swift.h older than most recent input /Users/ewilde/Work/swift-cmake-examples/3_bidirectional_cxx_interop/lib/fibonacci/fibonacci.swift<PHONE_NUMBER>121029567 vs<PHONE_NUMBER>687477075)
ninja explain: /Users/ewilde/Work/swift-cmake-examples/3_bidirectional_cxx_interop/build/lib/fibonacci/include/fibonacci/fibonacci-swift.h is dirty
ninja explain: lib/fibonacci/CMakeFiles/fibonacci.dir/fibonacci.cpp.o is dirty
ninja explain: lib/fibonacci/libfibonacci.a is dirty
...


Incorrect Information Regarding Azure DevOps IP Addresses

Regarding this documentation:
https://docs.microsoft.com/en-us/azure/devops/pipelines/agents/hosted?view=azure-devops
I have VM's at Rackspace that I deploy to from Azure DevOps. For a long time I had my firewall at Rackspace allowing inbound connections from Azure for port 5986 (WinRM SSL port). But I only whitelisted IP address ranges from the following file, but only for my region (East US 2).
Recently my deployments stopped working. I spent an hour on the phone with Rackspace, and they watched the inbound traffic from Azure. We collected 5 different samples to see what the originating IP address was. Every single time the IP address not only changed, but it changed regoin.
The documentation states that the hosted agent will be one from your region. I have proof that this is NOT the case.
Here's where I get the IP address ranges:
https://www.microsoft.com/en-us/download/details.aspx?id=56519
This documentation should be updated OR the implementation should be fixed so that it's true that you always get a hosted agent from your region.
Feel free to reach out to me by email<EMAIL_ADDRESS>Regards,
Brian Eriksen
CTO, GetYourPet.com

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 99af681d-41ad-da15-0b72-08b5cd5a11ac
Version Independent ID: 2fa0df36-a437-8cbb-b019-b49b31b1e116
Content: Microsoft-hosted agents for Azure Pipelines - Azure Pipelines
Content Source: docs/pipelines/agents/hosted.md
Product: devops
Technology: devops-cicd
GitHub Login: @thejoebourneidentity
Microsoft Alias: jobourne

Hi @eriksendc. We tried to make the documentation clear that your hosted agent can run inside any region in your geography. https://docs.microsoft.com/en-us/azure/devops/pipelines/agents/hosted?view=azure-devops#agent-ip-ranges

Your hosted agents run in the same Azure geography as your organization. Each geography contains one or more regions, and while your agent may run in the same region as your organization, it is not guaranteed to do so. To obtain the complete list of possible IP ranges for your agent, you must use the IP ranges from all of the regions that are contained in your geography. For example, if your organization is located in the United States geography, you must use the IP ranges for all of the regions in that geography.
To determine your geography, navigate to https://dev.azure.com/<your_organization>/_settings/organizationOverview, get your region, and find the associated geography from the Azure geography table. Once you have identified your geography, use the IP ranges from the weekly file for all regions in that geography.

Once you identify all the regions in your geography, The IP JSON file contains an array called values. Inside that array, you can find the supported IP addresses in an object with a name in the following format: AzureCloud.{your-azure-region}

@thejoebourneidentity thanks for the help.
When I go to https://dev.azure.com/getyourpet/_settings/ I see that my Region is East US 2. Can you tell me where to find the official, definitive Azure geography table so I know all the regions I need to deal with? I've googled around and I can't figure out whether US or North America is a geography.
this is something I found on github:
https://github.com/MicrosoftDocs/azure-docs/blob/master/articles/best-practices-availability-paired-regions.md
this https://azure.microsoft.com/en-us/global-infrastructure/geographies/
seems to be a more "brochure ware" page.
But it seems like there should be something in a JSON file or some very specific table, but I googled "azure geography table" and I can't seem to find a good resource.
Thanks,
-Brian

@thejoebourneidentity Sorry Joe, I wrote a reply but I didn't read the online doc again and there's a link to the Azure Geography table. So, if I understand the table, then if my region is East US 2, then my Geography is Americas, right? Does that mean I need to whitelist all the regions in the UNITED STATES, AZURE GOVERNMENT, CANADA and BRAZIL columns? Or just those in the UNITED STATES column? The way that table reads with those columns, I'm still confused.

United States is the geography. "America's" is just a visual grouping for the geographies page.


add a verbose parameter

Fix #196

/ok-to-test sha=

/ok-to-test sha=33684eb

/ok-to-test

@12rambau I am testing a GitHub workflow for automated testing for pull requests. I have not fully figured out how to do it yet. Therefore, it might take a day or two to resolve this issue unless this is an urgent pull request that you want immediate action. Thanks.

I am also having issues with Github workflow in my repo since travis-CI ended its support to open-source projects. Take all the time you need I'm in no rush

/ok-to-test sha=558cb5b

/ok-to-test sha=33684eb


Bumped PHPUnit version for better 7.x support, sticking to 5.x for La…

…ravel 5.3.x support

Coverage remained the same at 35.556% when pulling c39cb8ef1aea5ab166de0dfa2d1ab84486132ab5 on kevindierkx:phpunit into cb085e8aff856e19bdd72fc9d2343990d2b99a02 on PCextreme:master.


[Feature Request] –  batch change baseurl

the app server maybe in different site, for example, maybe:<IP_ADDRESS>:8080 or <IP_ADDRESS>:8090,, etc,  while change the test server, user will be need to change all of the request's base url one by one, sometime will be forget change the base url and get the wrong result.
maybe can set a baseurl in globel, and all of the request in the workspace could use the globel baseurl.

You can use Insomnia's Environment Variables to accomplish this


Gallery tweaks

Allow a denser gallery by specifying a class for the sections
Adds an only_use_existing flag that prevents gallery from trying to generate a thumbnail if it doesn't find one on thumbnail_url or in the dir.

For example, with this PR we can do:

TODO:

[ ] Make sure that the tooltips don't get cut off


No icons for back and forward

The Touch Bar has icons for back and forward but those icons are not in this repository. They are needed by any extension that wants to add back or forward buttons to the tool bar.

They are needed by any extension that wants to add back or forward buttons to the tool bar
I don't understand why an extension would need to provide icons for what already exists on the toolbar. Can you please elaborate?

And these are just using the same chevrons as chevron-left and chevron-right.

Ah, the chevrons are the ones! I will close this issue.
But a question: I cannot find a way to add back and forward buttons to the VS toolbar without an extension. Is there a way to do it?
I am using the Back and Forth extension for this purpose. I asked the developer to change the icons to the chevrons, as they are currently using the arrows.
Thanks for your time.

@phatmann we don't offer this natively so it would need to be added via an extension, besides using the command palette as well.


Check all keys before progressing index

Codecov Report
Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (85580bb) 37.39% compared to head (718d7a3) 37.38%.

Files
Patch %
Lines

src/bitcoin/signer.rs
0.00%
6 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #277      +/-   ##
===========================================
- Coverage    37.39%   37.38%   -0.01%
===========================================
  Files           26       26
  Lines         9317     9319       +2
===========================================
  Hits          3484     3484
- Misses        5833     5835       +2

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


v1alpha2 routerule -> virtualservice

corresponding change to vendor: https://github.com/istio/vendor-istio/pull/17

@GregHanson: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
4054a093a35b7fb54cf96f347160cf875dbce936
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@GregHanson: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
4054a093a35b7fb54cf96f347160cf875dbce936
link
/test istio-unit-tests

prow/istio-presubmit.sh
4054a093a35b7fb54cf96f347160cf875dbce936
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

There's one more in pkg/xds/translate.go

@kyessenov where?
/go/src/istio.io/istio$ find -name translate.go
./vendor/github.com/huandu/xstrings/translate.go

Pull upstream, file pkg/xds/translate.go
On Wed, Feb 28, 2018 at 3:45 PM Gregory Hanson<EMAIL_ADDRESS>wrote:

@kyessenov https://github.com/kyessenov where?
/go/src/istio.io/istio$ find -name translate.go
./vendor/github.com/huandu/xstrings/translate.go
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/3843#issuecomment-369423494, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AJGIxnrYtFZqQdAziMwNn1FyPAzQDbmuks5tZeUsgaJpZM4SXhdk
.

@GregHanson: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
4054a093a35b7fb54cf96f347160cf875dbce936
link
/test istio-presubmit

prow/istio-unit-tests.sh
8c8ed3ba715ffe4b482cbfae5d21a9ae8e228953
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@GregHanson: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
8c8ed3ba715ffe4b482cbfae5d21a9ae8e228953
link
/test istio-unit-tests

prow/istio-presubmit.sh
8c8ed3ba715ffe4b482cbfae5d21a9ae8e228953
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/hold
all PRs touching Gopkg* / vendor need two phase commits
first green tests using the sha from other PR, then merge other PR, then change sha here, then merge

please make sure both PR are in sync by running make depend.update

consider combining with or redoing after #3862

point to new vendor PR:
https://github.com/istio/vendor-istio/pull/19

greg my apologies - the bot merged my other PR
can you
make pull
and redo
make depend.update
and redo (sorry!) 1 more time the vendor pr

@GregHanson: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
8c8ed3ba715ffe4b482cbfae5d21a9ae8e228953
link
/test istio-presubmit

prow/istio-unit-tests.sh
34f212aa5aaceeef9992147f97f16f62db2d266b
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@GregHanson: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
34f212aa5aaceeef9992147f97f16f62db2d266b
link
/test istio-unit-tests

prow/istio-presubmit.sh
34f212aa5aaceeef9992147f97f16f62db2d266b
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

PR is in a bad state, tracking files with changes that were not modified - like Makefile
going to cherry pick my commit and open new PR

@GregHanson: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
34f212aa5aaceeef9992147f97f16f62db2d266b
link
/test istio-presubmit

prow/istio-unit-tests.sh
ddde67e0b0e1331380e89157b4f3bf768e0d3bb3
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@GregHanson: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
ddde67e0b0e1331380e89157b4f3bf768e0d3bb3
link
/test istio-unit-tests

prow/istio-pilot-e2e.sh
ddde67e0b0e1331380e89157b4f3bf768e0d3bb3
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


feat(cross-filters): add option to clear set cross filters

SUMMARY
This adds the option to clear emitted cross filters by adding an onClick to the cross filter indicator.
SCREENSHOT

TESTING INSTRUCTIONS

Enable the DASHBOARD_CROSS_FILTERS feature flag
create a chart that supports cross filters and check the "emit cross filters" control
add the chart to a dashboard
emit a cross filter
Hover on the cross filter indicator, see the updated tooltip and click on the indicator to clear emitted filters

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

/testenv up

/testenv up FEATURE_DASHBOARD_CROSS_FILTERS=true FEATURE_DASHBOARD_NATIVE_FILTERS=true

/testenv up FEATURE_DASHBOARD_CROSS_FILTERS=true FEATURE_DASHBOARD_NATIVE_FILTERS=true

/testenv up FEATURE_DASHBOARD_CROSS_FILTERS=true FEATURE_DASHBOARD_NATIVE_FILTERS=true

@villebro Some suggestions:

Vertical align the emit icon and the filter icon
Make the emit icon and the filter icon the same size (emit is bigger)
I think "Click to clear emitted filter" does not need to be bold because it's secondary information. After the first interaction, the user won't even read that anymore.

@villebro Some suggestions:

Vertical align the emit icon and the filter icon
Make the emit icon and the filter icon the same size (emit is bigger)

Good catch, I hadn't noticed that.

I think "Click to clear emitted filter" does not need to be bold because it's secondary information. After the first interaction, the user won't even read that anymore.

I agree, will make the change

/testenv down

/testenv up FEATURE_DASHBOARD_CROSS_FILTERS=true FEATURE_DASHBOARD_NATIVE_FILTERS=true


Feature request: Support for Safari

Are there plans to make an Safari Extension?

I can't really create a Safari extension as I don't own any Apple products. I'd appreciate it if someone could help out! 😸

Hmm, and now after reading this article, granted it is from Jan of this year, it sounds like it truly isn't worth the effort — at least for me — since the barrier (buying a MAC, and paying $100 to develop the extension) is too great to overcome for this free extension.

Having it on this repo wouldn't be too hard, those that are interested could come and update/install/maintain. There's already a Nightlight extension though. https://www.gofake1.net/projects/nightlight.html

There's already a Nightlight extension though.

As I mentioned in Product Hunt, Nightlight uses a generic method to darken websites. While it is nice for overall browsing, this extension specifically targets and styles Medium stories.

Hi @Mottie I can help you with the extension for safari.

Awesome @AadityaDev! I've invited you to be a collaborator 😸

Hi @Mottie I would also like to work on getting it on safari

Hey @Mottie, I'm also available for help/testing as I'm a registered Apple developer. Let me know if I can be of any help.

There is a lovely app of the Mac App store called Cascadea - it works like a charm.
For anyone who would like to complain that it's not free -  I paid around 3 EUR (in my local currency) for it, so it's less than a coffee out in town. If you want people to make quality software - pay them, simple :)


bowling: propose tests for err semantics

Specifically: if a call to roll() is made that results in an error,
the game state should not be altered, so that future calls to
roll() will proceed as if the erroneous roll never happened.
This is only a proposal because there was doubt in #213 about whether
they should be added.
Since it was suggested, after seeing it in my Exercism submission, that
I open an issue for it, I will, because I can let code speak to
accompany my words.
Right now there's no good way to express this kind of semantics in
x-common, but maybe a general discussion on it would be OK to brainstorm
some ways to do it.
TODO:

The current example solution needs to be fixed.
It is possible we can add more tests of this type - basically any time
we expect an is_err() from a roll.

I would only want to put in the work to proceed with these if we decide
we do want these kinds of tests.

I still think this adds new behavior to the exercise that I don't think is necessary. It gets into the territory of "If I were to implement a real bowling scorer", and I think exercises shouldn't worry about what 'real world' solutions; instead they should be focused on a single thing.

It can sometimes be hard to know where to draw the line. We have seen before at https://github.com/exercism/xrust/pull/178#issuecomment-240705220

But if people are using these exercises to learn how to write Rust and the exercises encourage smelly Rust code, then won't most of the students go off and write smelly Rust code in production?

I think currently we draw the line at essential behaviour, and we can't really say that this behaviour is essential to scoring a bowling game.
Another comfort we can take is that even though the exercise doesn't enforce the kind of discipline in error handling that we would be asking for in this test, at least it is not encouraging smelly code. We're leaving it open. So the stance we take is not inconsistent with the above quote.
I think if someone is very interested in error handling, they should help us implement the https://github.com/exercism/x-common/tree/master/exercises/error-handling exercise... where everything discussed here would suddenly become essential to the problem... since it's the entire problem.


Java: proto and grpc artifacts are not preserving license headers

The license headers should be preserved from the license headers present in the proto files.

@chingor13 proto and grpc stubs are generated by protoc directly (grpc using grpc plugin from grpc-java repository). Gapic generator is not used. Most probably this request should go to https://github.com/protocolbuffers/protobuf

Doesn't seem executable.


Cannot install on .NET v4.5 projects

I cannot install Microsoft.Extensions.Configuration.FileExtensions & Microsoft.Extensions.Configuration.Ini in .NET v4.5 projects. Both of the packages are in version v1.1.0. The error message from Nuget is as following:

Could not install package'Microsoft.Extensions.Configuration.FileExtensions 1.1.0'. You are trying to install this package into a project that targets'.NETFramework, Version=v4.5', but the package does not contain any assembly references or content files that are compatible with that framework. For more information, contact the package author.

We don't support net45, try upgrading to net451.

I cannot upgrade it to net451, is there any workaround?

Nope.

Recompile the code in your own project?

Is there anything special that it must attach to net451? Is it because one of the dependency or itself need a new feature bring from net451?

We target frameworks based on API usage. Some APIs are only available on higher .NET Framework versions. Also FYI, net45 and net451 are out of support and we are looking at moving to requiring net46 for some of our libraries.
Why can't you move to .NET 4.5.1 or .NET 4.6?

Because the build system is not under my control.

As the reason is by design, I'll close this thread. Thanks David for help!


[SPARK-43921] Generate Protobuf descriptor files at build time.

Generates descriptor files for Protobuf files at build time. Removes manually generated .desc filed from test-resources directory.
Note that Maven & SBT plugins generate descriptor files differently:

Maven builds one descriptor file for each proto file (catalyst_types.desc, functions_suite.desc etc).

This matches with manually generated file before this PR.

SBT plugin build single descriptor file for all the proto files.
It not feasible to change the behavior of either. So the tests work around it by picking either version of the descriptor file.

How was this patch tested?

Existing tests are updated to use these files.

This is now ready for review. cc: @LuciferYang, @gengliangwang, @SandishKumarHN

@LuciferYang could you merge this?

@rangadi Could you resolve the conflict?

Fixed. The conflict was because of descriptor file updated in #41481

I checked this one with maven and Scala 2.13, all test passed.
Merged to master. Thanks @rangadi


Improving tests for the new rspec utils

@robwise we could verify the puts statements for the updates to the rspec utils that ensure the JS assets are generated: https://www.relishapp.com/rspec/rspec-expectations/docs/built-in-matchers/output-matcher

The only reason we'll get to this one is if we're working on some bug related to this.


MM-11232 Fix table column width to better support wide tables

This makes it so that the columns in Markdown tables are a fixed width instead of fitting all columns into the available space so that tables with more columns be readable. A few things to note with this:

I'm unable to make the tables scroll horizontally in the post view as requested, but you can scroll horizontally once tapping on the table for the full view
When viewing the whole table, Android does not support diagonal scrolling so you can only scroll horizontally and then vertically.
I've increased the max height of tables in the post list from 120 to 300 points

As part of this ticket, I've also made a small change to commonmark-react-renderer to make it so that the MarkdownTable component knows the number of rows and columns to be rendered. Those changes are here: https://github.com/mattermost/commonmark-react-renderer/commit/3a2ac19cab725ad28b170fdc1d397dddedcf87eb
Ticket Link
https://mattermost.atlassian.net/browse/MM-11232
Checklist

Has UI changes

Device Information
This PR was tested on: iOS Simulator (iPhone X, iOS 12.1), Nexus 5 (Android 6.0)
Screenshots
New behaviour:

Old behaviour:

@esethna Adding you for review to ensure that the fixed column width and the max height changes look good

@hmhealey code looks good, but should we add some tests to this PR?

The only ones I can think to add is to make sure that it renders the moreRight and moreBelow when triggered by the state, but I don't know how useful those are. Most of the logic that I'd want to test here would need to be tested manually like checking whether or not RN gives the table the correct dimensions from onLayout.

Build Apps for PR label detected. Will generate the app if build succeeds (checks pass and no conflicts with base branch).

Build the App failed. See the logs for more information.


Can't change cursor size

I use cage on ArchLinux on high resolution TV. Default cursor is too small.
But settings:
Environment="XCURSOR_SIZE=64"

And
Environment="XCURSOR_SIZE=64"
Environment="XCURSOR_THEME=xcursor-vanilla-dmz"

Did not get any effect.
Full unit:
[Unit]
Description=Start Firefox in Cage
After=network.target
Wants=display-manager.service

[Service]
User=root
Environment=XDG_RUNTIME_DIR=/cache/firefox/
Environment="XCURSOR_SIZE=64"
Environment="GDK_SCALE=3"
Environment="GDK_DPI_SCALE=2"
ExecStartPre=/bin/sleep 1
ExecStart=/usr/bin/cage -s firefox
Restart=always

[Install]
WantedBy=graphical.target

But how to pass them to it?
Пн, 26 авг. 2024 г. в 19:12, Simon Ser @.***>:

cage does not read the XCURSOR_SIZE nor XCURSOR_THEME env vars at the
moment.
—
Reply to this email directly, view it on GitHub
https://github.com/cage-kiosk/cage/issues/353#issuecomment-2310570655,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABRWNFREU2XHSCL2VQOISRLZTNHVFAVCNFSM6AAAAABNDQHR6GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMJQGU3TANRVGU
.
You are receiving this because you authored the thread.Message ID:
@.***>

This feature is not yet supported: there is no way to configure the Xcursor theme/size used by cage currently.

Are there any temporal solutions? Can I replace the cursor file?
вт, 27 авг. 2024 г. в 11:07, Simon Ser @.***>:

This feature is not yet supported: there is no way to configure the
Xcursor theme/size used by cage currently.
—
Reply to this email directly, view it on GitHub
https://github.com/cage-kiosk/cage/issues/353#issuecomment-2311841111,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABRWNFTZYUN3WY5HBDBWWOTZTQXTHAVCNFSM6AAAAABNDQHR6GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMJRHA2DCMJRGE
.
You are receiving this because you authored the thread.Message ID:
@.***>


Failure to build Jexpresso for CPU on Linux

I am running Jexpresso commit (bb3c42d) on Centos 7, Julia 1.10.5. When I try to install with the cpu only instructions:
cd Jexpresso
sed -i '/Metal/d' ./Project.toml
sed -i '/CUDA/d' ./Project.toml
julia --project=. -e "using Pkg; Pkg.instantiate(); Pkg.API.precompile()"

I get the following error:
ERROR: LoadError: ArgumentError: Package Jexpresso does not have CUDA in its dependencies:
- You may have a partially installed environment. Try `Pkg.instantiate()`
  to ensure all packages in the environment are installed.
- Or, if you have Jexpresso checked out for development and have
  added CUDA as a dependency but haven't updated your primary
  environment's manifest file, try `Pkg.resolve()`.
- Otherwise you may need to report an issue with Jexpresso

Should I not be removing the CUDA and Metal dependencies even though I am on Linux and attempting a CPU-only build?
TIA!

hi @jennyfothergill first of all, thanks for being interested in the code and testing it.
Since we mostly develop on Mac, it's good to have Linux users to point out issues. We will fix this ASAP (in the next 2 days) and let you know

I am running Jexpresso commit (bb3c42d) on Centos 7, Julia 1.10.5. When I try to install with the cpu only instructions:
cd Jexpresso
sed -i '/Metal/d' ./Project.toml
sed -i '/CUDA/d' ./Project.toml
julia --project=. -e "using Pkg; Pkg.instantiate(); Pkg.API.precompile()"

I get the following error:
ERROR: LoadError: ArgumentError: Package Jexpresso does not have CUDA in its dependencies:
- You may have a partially installed environment. Try `Pkg.instantiate()`
  to ensure all packages in the environment are installed.
- Or, if you have Jexpresso checked out for development and have
  added CUDA as a dependency but haven't updated your primary
  environment's manifest file, try `Pkg.resolve()`.
- Otherwise you may need to report an issue with Jexpresso

Should I not be removing the CUDA and Metal dependencies even though I am on Linux and attempting a CPU-only build?
TIA!

@jennyfothergill why are you using sed to add the Metal and CUDA strings to Project?

Thank you for your reply. I am attempting to test a build of Jexpresso that does not use CUDA or Metal, so I am using sed to remove their lines from Project.toml.
Sorry if I am misunderstanding your question. I am not too familiar with how Julia knows its dependencies.


Tests - ON not including pending tests

Although I don't see it stated anywhere, you seem to be reporting on the total number of tests performed, including pending tests.
If that's the case, your reporting for Ontario seems to be off. For example, yesterday, on April 22, ON reported these numbers:

Total tests completed 184,531
Currently under investigation 6,845  (Samples with testing in progress.)

Your reported testing number for ON for that day is 184,531. If you are indeed reporting completed+pending, shouldn't you be reporting the sum of the above two numbers?

Hi John,
Thanks for flagging this. I took a moment to look into this - our original intention is indeed to include the total number of tests done.
When Ontario switched to their new website at the end of March, they initially stopped reporting the number of tests that were pending - they reported only "Total tested".
https://web.archive.org/web/20200330021143/https://www.ontario.ca/page/2019-novel-coronavirus
By March 31 (the beginning of your archive) this was changed to "Total tested" and "Currently under investigation" (not entirely clear if the former includes the latter). This has since been changed to "Total tests completed" and "Currently under investigation", which has removed the ambiguity.
Of course, Ontario recently started reporting samples taken rather than patients tested, which is partly responsible for the sharp spike in daily numbers from Ontario in the past week. We should probably add a methodology note to explicitly address the variation in the definition of this quantity across time and geography.
Regarding the Ontario testing numbers, we will make a determination whether to go back and update them to include total + pending.
Jean-Paul

Hi John,
Thanks for flagging this. I took a moment to look into this - our original intention is indeed to include the total number of tests done.
Originally, Ontario reported "Total number of patients approved for COVID-19 testing to date", which included negative, positive, and under investigation. Near the end of March, they briefly stopped reporting the number of tests that were pending - they reported only "Total tested".
https://web.archive.org/web/20200330171616/https://www.ontario.ca/page/2019-novel-coronavirus
By March 31 (the beginning of your archive) this was changed to "Total tested" and "Currently under investigation" (not entirely clear if the former includes the latter, as it did under the previous wording). This has since been changed to "Total tests completed" and "Currently under investigation", which has removed the ambiguity - the total tested number no longer includes those under investigation.
On a related note, Ontario recently started reporting samples taken rather than patients tested, which is partly responsible for the sharp spike in daily numbers from Ontario in the past week. We should probably add a methodology note to explicitly address the variation in the definition of this quantity across time and geography.
Regarding the Ontario testing numbers, I will make a point to go back and update the numbers. We can use your archive (easier than Wayback Machine), since it begins almost precisely after the apparently change in reporting.
Thanks again.
Jean-Paul

Glad to help out.
These testing numbers are pretty confusing to me....

I think in the rear-view mirror, it's going to be extremely important to get the testing numbers right (particularly the positivity rate) in order to really figure out what worked and what didn't in terms of interventions.


Any chance of Scala 2.13 support?

Hey, Damian! 😄
Unfortunately, I don't think I'll have the time (or patience for the Scala 2 macro system) to do that.


Will this work with Doctrine?

I know you mention Eloquent, but was just curious if this has already been done with Doctrine?

In theory, Yes. You would just need to write a trait for your Doctrine entities so that they could implement the Staplerable Interface (probably using Lifecycle callbacks, etc). I haven't written this due to the fact that I haven't had a need for it (yet). If you want to take a stab at implementing it, be my guest. I'll help where I can.