Add dist mnist model for e2e test

Hi, after v1alpha2 code merged, we need some e2e test for this new API.
This PR import distributed mnist model for e2e test, @gaocegege @jlewi PTAL, thanks!

This change is

@gaocegege Just a little change in args parsing: read args from ENV TF_CONFIG.

OK, could we place the file in examples/v1alpha2/mnist/? I think we do not run e2e test for v1alpha2 in short term.

Coverage decreased (-0.08%) to 50.317% when pulling 9be81fe440124b004f5b211cf7f486310fd4ac19 on ScorpioCPH:add-dist-mnist-for-e2e-test into 42ff961a525eab42d9495b537d04a8fb61eec9d8 on kubeflow:master.

Why do we need to use mnist for testing?
Why can't we use the current E2E tests?
The current E2E tests verify that ops can be assigned to all of the workers and that those ops are executed successfully
https://github.com/kubeflow/tf-operator/blob/master/examples/tf_sample/tf_sample/tf_smoke.py#L52
How does using a model like mnist help? Are you actually verifying that distributed training is working and that ops are properly assigned and executed on multiple workers?
For E2E tests, I think the thing we want to test is not that we can train mnist but that all the TFServers are created and properly configured to talk to each other. Can we create  simpler tests that explicitly test this?
For GPUs for example we can log device placement and then check that ops are actually assigned to the GPU. I thought we were already doing this but looks like we aren't. We should open an issue to track that.

/assign jlewi

@jlewi Hi, tf_smoke.py is good, i think mnist training is simple enough and we need some real training which running a while to verify

Are you actually verifying that distributed training is working and that ops are properly assigned and executed on multiple workers?

We can achieve this goal by launching a real distributed training not just a smoke test.

@jlewi We need more tests including GPUs of course. I will add more tests later.

@jlewi Thanks, any concerns about this PR?
@gaocegege By the way, CI failed as this command "gometalinter --config=linter_config.json ./pkg/..." exited with 1. Maybe not related to this PR.

@ScorpioCPH no
/lgtm
/hold
Hold to let @gaocegege approve

Yeah, Travis CI failed but the presubmit should passed.
BTW lgtm.

gometalinter is a little werid, seems that it is false negative. Sometimes there are errors but it won't report to us.

/hold cancel

After the rebase, Travis should pass.

@gaocegege Rebase is done, but the CI is still failed, could you take a look please?

/retest
OK, sure.

I think the CI is fixed, please rebase the master :smile:

/lgtm

/retest

************* Module dist_mnist
W: 97, 9: Unused argument 'unused_argv' (unused-argument)
R: 97, 0: Too many branches (21/12) (too-many-branches)
R: 97, 0: Too many statements (104/50) (too-many-statements)
-----------------------------------
Your code has been rated at 9.77/10

/retest

Hi @ScorpioCPH
I think we should fix the linting issues in the python module dist_mnist.

Hi, could you please fix the linting issues? The second failure is not caused by your code, IMO.

I met an error when I run the build script: https://pastebin.ubuntu.com/p/Z8Xv3NNhss/
:thinking: Do you have any idea about it?

@gaocegege Hi, please try the latest code, the Dockerfile is more simpler:
FROM tensorflow/tensorflow:1.5.0

ADD . /var/tf_dist_mnist
ENTRYPOINT ["python", "/var/tf_dist_mnist/dist_mnist.py"]

And can we ignore the python lint warning? I think it is not the critical thing and will take some time to fix all of the warnings.

Then we could add it into pylint ignore.

Could you do it or we could merge it and I can add it for you.

I will merge it first since I rely on the PR to test. Then I will file a PR to fix the presubmit test.

Thanks for your contribution!


No define ptr_t，u16

rmp_test_STM32F030F4.c not define ptr_t，u16，need to change。

This is a problem with old typedefs not being upgraded to the new version. Fixed.


Server Nmodbus4 don't send TCP FIN after client is disconnected

Hello ,
I have a problem with NModbus Library.
When my client is disconnected :
CLIENT           SERVER
FIN, ACK  ---->
          <----  ACK

and nothing else...!
The server don't send FIN to client.
After timeout, client send RST to server.
And when client try to reconnect, server send a bad SEQ number.
CLIENT           SERVER
SYN seq0  ---->
          <----  ACK seq1 (Wireshark said TCP ACKed unseen segment)
RST seq0  ---->

Result, just the first connection after the start of server is done.
Please, do you have any idea ?
My code
class ModbusServer
    {
        #region Variables
        private Sql sql;
        private int port;
        TcpListener tcp;
        ModbusSlave slave;

        #endregion

        #region Constructeur
        public ModbusServer(int port = 502)
        {
            this.port = port;

            IPHostEntry ipEntry = Dns.GetHostEntry(Dns.GetHostName());
            IPAddress[] addr = ipEntry.AddressList;
            tcp = new TcpListener(addr[0], port);
            slave = ModbusTcpSlave.CreateTcp(255, tcp);
            slave.DataStore = DataStoreFactory.CreateDefaultDataStore();

            slave.DataStore.DataStoreWrittenTo += new EventHandler<DataStoreEventArgs>(DataStore_DataStoreWrittenTo);
        }

        #endregion

        #region Public
        public void start()
        {
            try
            {

                slave.Listen();
                Console.WriteLine("[MODBUS] Server started");
                Console.WriteLine("[MODBUS] Port " + port);

            }
            catch (Exception ex)
            {
                Console.WriteLine(ex.Message);

            }

        }
        #endregion

        #region Private
        private void DataStore_DataStoreWrittenTo(object sender, DataStoreEventArgs e)
        {
            Console.WriteLine("[MODBUS] Reception of values");

            int iAddress = e.StartAddress;
            List<ushort> data = new List<ushort>();

            if (e.ModbusDataType == ModbusDataType.HoldingRegister)
            {

                for (int i = 0; i < e.Data.B.Count; i++)
                {
                    data.Add(e.Data.B[i]);
                    Console.WriteLine("[" + i + "] " + e.Data.B[i]);
                }

            }
        }
        #endregion
    }

Thanks !
Aurélien
from France

Could you try to Dispose slave instance?

Thank you for your response.
Oh, since I use NModbus version 4, my PLC can't connect to the server...
PLC      SERVER       502 → 502 [SYN] Seq=0 Win=1024 Len=0 MSS=1024
SERVER   PLC          502 → 502 [RST, ACK] Seq=1 Ack=1 Win=0 Len=0

I don't know how I can proceed...
` public ModbusServer(int port = 502)
{
        this.port = port;
        IPAddress address = new IPAddress(new byte[] { 127, 0, 0, 1 });

        tcp = new TcpListener(address, port);

        slave = ModbusTcpSlave.CreateTcp(255, tcp);

        slave.DataStore = DataStoreFactory.CreateDefaultDataStore();

        slave.DataStore.DataStoreWrittenTo += new EventHandler<DataStoreEventArgs>(DataStore_DataStoreWrittenTo);

        tcp.Start();
        slave.ListenAsync();

    }`

When the connection is OK :
WireShark

@AurelienC
In the first code example you gave (4 messages up), I don't see a call to 'tcp.Start()'.
Later you mention using NModbus 4 v3.0.0 - that's labeled as an 'alpha' release. Maybe try to go to the 'Latest Release'? which is v2.1.0
I'm using v2.1.0 with no issues (starting over 60 slaves on one pc) as long as things are Disposed properly (as @Maxwe11 said) between one startup and the next. For reference, here's the core of my startup code:
`                slaveTcpListener = new TcpListener(ip, TcpPort);
            slaveTcpListener.Start();

            slave = ModbusTcpSlave.CreateTcp(SlaveID, slaveTcpListener);
            slave.DataStore = DataStoreFactory.CreateDefaultDataStore();

            slave.Listen();

`
Hope this helps. :)

Sorry, no much time.
I made a new project with Node.js and, thus, an other package for Modbus communication. :-)


Support panorma pictures taken by smartphone.

Issue
#231
Details
It's not final.
First PR is just prototyping level.
it's WIP (Working in progress). I will progress more by PR review.

Coverage decreased (-2.2%) to 91.168% when pulling 20833c58cfd89e56938dd3174a2f618b60ca2da3 on jongmoon:panorama#231 into 8d4a22cab79ceb1d31330a62a1b68f9410bfecc5 on naver:master.

LGTM


[BUG] chip-tool unable to comission vendor lightbulb

Reproduction steps
I am using the metrics docker release. I successfully built chip-tool on amd x64 cpu ubuntu linux.
When I run chip-tool pairing code-wifi 1 mypersonalssid mypersonalssidpasswd 139xxxxxxxx, for a working vendor matter enabled lightbulb, I am not able to pair the device. It all works fine from Google Home with my android and nest2, but chip-tool is failing. I had attempted to use pariing ble-wifi but would need setup pin code and discriminator args which I am not sure how to pick up from a vendor matter lightbulb given that I only have the matter code visible.
1710958145.791386][114824:114824] CHIP:DL: ChipLinuxStorage::Init: Using KVS config file: /tmp/chip_kvs
[1710958145.791566][114824:114824] CHIP:DL: ChipLinuxStorage::Init: Using KVS config file: /tmp/chip_factory.ini
[1710958145.791639][114824:114824] CHIP:DL: ChipLinuxStorage::Init: Using KVS config file: /tmp/chip_config.ini
[1710958145.791665][114824:114824] CHIP:DL: ChipLinuxStorage::Init: Using KVS config file: /tmp/chip_counters.ini
[1710958145.791988][114824:114824] CHIP:DL: writing settings to file (/tmp/chip_counters.ini-xsmifE)
[1710958145.792204][114824:114824] CHIP:DL: renamed tmp file to file (/tmp/chip_counters.ini)
[1710958145.792242][114824:114824] CHIP:DL: NVS set: chip-counters/reboot-count = 5 (0x5)
[1710958145.792798][114824:114824] CHIP:DL: Got Ethernet interface: eth0
[1710958145.792879][114824:114824] CHIP:DL: Found the primary Ethernet interface:eth0
[1710958145.792990][114824:114824] CHIP:DL: Failed to get WiFi interface
[1710958145.793014][114824:114824] CHIP:DL: Failed to reset WiFi statistic counts
[1710958145.793039][114824:114824] CHIP:IN: UDP::Init bind&listen port=0
[1710958145.793079][114824:114824] CHIP:IN: UDP::Init bound to port=59416
[1710958145.793105][114824:114824] CHIP:IN: UDP::Init bind&listen port=0
[1710958145.793122][114824:114824] CHIP:IN: UDP::Init bound to port=41404
[1710958145.793128][114824:114824] CHIP:IN: BLEBase::Init - setting/overriding transport
[1710958145.793152][114824:114824] CHIP:IN: TransportMgr initialized
[1710958145.793163][114824:114824] CHIP:FP: Initializing FabricTable from persistent storage
[1710958145.793219][114824:114824] CHIP:TS: Last Known Good Time: 2024-03-20T15:29:37
[1710958145.793370][114824:114824] CHIP:FP: Fabric index 0x1 was retrieved from storage. Compressed FabricId 0x5A319A2B2BA2D6FC, FabricId 0x0000000000000001, NodeId 0x000000000001B669, VendorId 0xFFF1
[1710958145.803497][114824:114824] CHIP:ZCL: Using ZAP configuration...
[1710958145.997547][114824:114824] CHIP:CTL: System State Initialized...
[1710958145.997607][114824:114824] CHIP:CTL: Stopping commissioning discovery over DNS-SD
[1710958145.997654][114824:114824] CHIP:CTL: Setting attestation nonce to random value
[1710958145.997691][114824:114824] CHIP:CTL: Setting CSR nonce to random value
[1710958145.997730][114824:114824] CHIP:IN: UDP::Init bind&listen port=5550
[1710958145.997763][114824:114824] CHIP:IN: UDP::Init bound to port=5550
[1710958145.997771][114824:114824] CHIP:IN: UDP::Init bind&listen port=5550
[1710958145.997856][114824:114824] CHIP:IN: UDP::Init bound to port=5550
[1710958145.997880][114824:114824] CHIP:IN: TransportMgr initialized
[1710958145.998054][114824:114832] CHIP:DL: CHIP task running
[1710958145.998198][114824:114832] CHIP:CTL: Stopping commissioning discovery over DNS-SD
[1710958145.998233][114824:114832] CHIP:CTL: Setting attestation nonce to random value
[1710958145.998250][114824:114832] CHIP:CTL: Setting CSR nonce to random value
[1710958145.999184][114824:114832] CHIP:CTL: Generating NOC
[1710958145.999484][114824:114832] CHIP:FP: Validating NOC chain
[1710958145.999939][114824:114832] CHIP:FP: NOC chain validation successful
[1710958146.000007][114824:114832] CHIP:FP: Updated fabric at index: 0x1, Node ID: 0x000000000001B669
[1710958146.000036][114824:114832] CHIP:TS: Last Known Good Time: 2024-03-20T15:29:37
[1710958146.000059][114824:114832] CHIP:TS: New proposed Last Known Good Time: 2021-01-01T00:00:00
[1710958146.000063][114824:114832] CHIP:TS: Retaining current Last Known Good Time
[1710958146.000927][114824:114832] CHIP:FP: Metadata for Fabric 0x1 persisted to storage.
[1710958146.001612][114824:114832] CHIP:TS: Committing Last Known Good Time to storage: 2024-03-20T15:29:37
[1710958146.002110][114824:114832] CHIP:CTL: Joined the fabric at index 1. Compressed fabric ID is: 0x0000000000000000
[1710958146.002125][114824:114832] CHIP:IN: UDP::Init bind&listen port=5550
[1710958146.002237][114824:114832] CHIP:IN: UDP::Init bound to port=5550
[1710958146.002266][114824:114832] CHIP:IN: UDP::Init bind&listen port=5550
[1710958146.002282][114824:114832] CHIP:IN: UDP::Init bound to port=5550
[1710958146.002285][114824:114832] CHIP:IN: TransportMgr initialized
[1710958146.004857][114824:114832] CHIP:CTL: Setting wifi credentials from parameters
[1710958146.004897][114824:114832] CHIP:CTL: Setting attestation nonce to random value
[1710958146.004914][114824:114832] CHIP:CTL: Setting CSR nonce to random value
[1710958146.004968][114824:114832] CHIP:CTL: Stopping commissioning discovery over DNS-SD
[1710958146.004974][114824:114832] CHIP:CTL: Starting commissioning discovery over BLE
[1710958146.004984][114824:114832] CHIP:CTL: Starting commissioning discovery over DNS-SD
[1710958146.005163][114824:114832] CHIP:DIS: Warning: Attempt to mDNS broadcast failed on docker0:  ../examples/chip-tool/third_party/connectedhomeip/src/inet/UDPEndPointImplSockets.cpp:409: OS Error 0x02000065: Network is unreachable
[1710958146.005191][114824:114832] CHIP:DIS: mDNS broadcast had only partial success: 5 successes and 1 failures.
[1710958146.005351][114824:114833] CHIP:DL: TRACE: Bluez mainloop starting Thread
[1710958146.005658][114824:114826] CHIP:DL: FAIL: get bus sync in StartupEndpointBindings, error: Could not connect: No such file or directory
[1710958146.005739][114824:114832] CHIP:DL: PlatformBlueZInit init success
[1710958146.005785][114824:114832] CHIP:CTL: Commissioning discovery over BLE failed: ../examples/chip-tool/third_party/connectedhomeip/src/platform/Linux/BLEManagerImpl.cpp:655: CHIP Error 0x00000003: Incorrect state
[1710958146.005791][114824:114832] CHIP:-: ../examples/chip-tool/third_party/connectedhomeip/src/platform/Linux/BLEManagerImpl.cpp:655: CHIP Error 0x00000003: Incorrect state at ../examples/chip-tool/third_party/connectedhomeip/src/controller/SetUpCodePairer.cpp:283
[1710958146.005796][114824:114832] CHIP:BLE: No adapter available for new connection establishment
[1710958147.006216][114824:114832] CHIP:DIS: Warning: Attempt to mDNS broadcast failed on docker0:  ../examples/chip-tool/third_party/connectedhomeip/src/inet/UDPEndPointImplSockets.cpp:409: OS Error 0x02000065: Network is unreachable
[1710958147.006253][114824:114832] CHIP:DIS: mDNS broadcast had only partial success: 5 successes and 1 failures.
[1710958149.007815][114824:114832] CHIP:DIS: Warning: Attempt to mDNS broadcast failed on docker0:  ../examples/chip-tool/third_party/connectedhomeip/src/inet/UDPEndPointImplSockets.cpp:409: OS Error 0x02000065: Network is unreachable
[1710958149.007883][114824:114832] CHIP:DIS: mDNS broadcast had only partial success: 5 successes and 1 failures.
[1710958153.012729][114824:114832] CHIP:DIS: Warning: Attempt to mDNS broadcast failed on docker0:  ../examples/chip-tool/third_party/connectedhomeip/src/inet/UDPEndPointImplSockets.cpp:409: OS Error 0x02000065: Network is unreachable
[1710958153.012839][114824:114832] CHIP:DIS: mDNS broadcast had only partial success: 5 successes and 1 failures.
[1710958161.017067][114824:114832] CHIP:DIS: Warning: Attempt to mDNS broadcast failed on docker0:  ../examples/chip-tool/third_party/connectedhomeip/src/inet/UDPEndPointImplSockets.cpp:409: OS Error 0x02000065: Network is unreachable
[1710958161.017145][114824:114832] CHIP:DIS: mDNS broadcast had only partial success: 5 successes and 1 failures.
CHIP:CTL: Discovery timed out
[1710960171.821269][133152:133156] CHIP:CTL: Stopping commissioning discovery over DNS-SD
[1710960171.821276][133152:133156] CHIP:TOO: Secure Pairing Failed
[1710960171.821547][133152:133152] CHIP:CTL: Shutting down the commissioner
[1710960171.821578][133152:133152] CHIP:CTL: Stopping commissioning discovery over DNS-SD
[1710960171.821605][133152:133152] CHIP:CTL: Shutting down the controller
[1710960171.821610][133152:133152] CHIP:IN: Expiring all sessions for fabric 0x1!!
[1710960171.821613][133152:133152] CHIP:FP: Forgetting fabric 0x1
[1710960171.821620][133152:133152] CHIP:TS: Pending Last Known Good Time: 2024-03-20T15:29:37
[1710960171.821661][133152:133152] CHIP:TS: Previous Last Known Good Time: 2024-03-20T15:29:37
[1710960171.821665][133152:133152] CHIP:TS: Reverted Last Known Good Time to previous value
[1710960171.821676][133152:133152] CHIP:CTL: Shutting down the commissioner
[1710960171.821698][133152:133152] CHIP:CTL: Stopping commissioning discovery over DNS-SD
[1710960171.821711][133152:133152] CHIP:CTL: Shutting down the controller
[1710960171.821714][133152:133152] CHIP:CTL: Shutting down the System State, this will teardown the CHIP Stack
[1710960171.821815][133152:133152] CHIP:DMG: IM WH moving to [Uninitialized]
[1710960171.821838][133152:133152] CHIP:DMG: IM WH moving to [Uninitialized]
[1710960171.821842][133152:133152] CHIP:DMG: IM WH moving to [Uninitialized]
[1710960171.821843][133152:133152] CHIP:DMG: IM WH moving to [Uninitialized]
[1710960171.821864][133152:133152] CHIP:DMG: All ReadHandler-s are clean, clear GlobalDirtySet
[1710960171.821879][133152:133152] CHIP:BLE: BleConnectionDelegate::CancelConnection is not implemented.
[1710960171.821989][133152:133152] CHIP:DL: writing settings to file (/tmp/chip_counters.ini-yUDH6u)
[1710960171.822140][133152:133152] CHIP:DL: renamed tmp file to file (/tmp/chip_counters.ini)
[1710960171.822170][133152:133152] CHIP:DL: NVS set: chip-counters/total-operational-hours = 0 (0x0)
[1710960171.822175][133152:133152] CHIP:DL: Inet Layer shutdown
[1710960171.822177][133152:133152] CHIP:DL: BLE shutdown
[1710960171.822179][133152:133152] CHIP:DL: System Layer shutdown
[1710960171.822193][133152:133152] CHIP:TOO: Run command failure: ../examples/chip-tool/commands/pairing/PairingCommand.cpp:164: CHIP Error 0x00000003: Incorrect state
Bug prevalence
every time
GitHub hash of the SDK that was being used
not sure.  came from us-docker.pkg.dev/nest-matter/docker-repo/virtual-device-image:latest
Platform
windows
Platform Version(s)
No response
Anything else?
No response

CHIP:CTL: Discovery timed out
[1710960171.821269][133152:133156] CHIP:CTL: Stopping commissioning discovery over DNS-SD
[1710960171.821276][133152:133156] CHIP:TOO: Secure Pairing Failed
[1710960171.821547][133152:133152] CHIP:CTL: Shutting down the commissioner
[1710960171.821578][133152:133152] CHIP:CTL: Stopping commissioning discovery over DNS-SD
[1710960171.821605][133152:133152] CHIP:CTL: Shutting down the controller
[1710960171.821610][133152:133152] CHIP:IN: Expiring all sessions for fabric 0x1!!
[1710960171.821613][133152:133152] CHIP:FP: Forgetting fabric 0x1
[1710960171.821620][133152:133152] CHIP:TS: Pending Last Known Good Time: 2024-03-20T15:29:37
[1710960171.821661][133152:133152] CHIP:TS: Previous Last Known Good Time: 2024-03-20T15:29:37
[1710960171.821665][133152:133152] CHIP:TS: Reverted Last Known Good Time to previous value
[1710960171.821676][133152:133152] CHIP:CTL: Shutting down the commissioner
[1710960171.821698][133152:133152] CHIP:CTL: Stopping commissioning discovery over DNS-SD
[1710960171.821711][133152:133152] CHIP:CTL: Shutting down the controller
[1710960171.821714][133152:133152] CHIP:CTL: Shutting down the System State, this will teardown the CHIP Stack
[1710960171.821815][133152:133152] CHIP:DMG: IM WH moving to [Uninitialized]
[1710960171.821838][133152:133152] CHIP:DMG: IM WH moving to [Uninitialized]
[1710960171.821842][133152:133152] CHIP:DMG: IM WH moving to [Uninitialized]
[1710960171.821843][133152:133152] CHIP:DMG: IM WH moving to [Uninitialized]
[1710960171.821864][133152:133152] CHIP:DMG: All ReadHandler-s are clean, clear GlobalDirtySet
[1710960171.821879][133152:133152] CHIP:BLE: BleConnectionDelegate::CancelConnection is not implemented.
[1710960171.821989][133152:133152] CHIP:DL: writing settings to file (/tmp/chip_counters.ini-yUDH6u)
[1710960171.822140][133152:133152] CHIP:DL: renamed tmp file to file (/tmp/chip_counters.ini)
[1710960171.822170][133152:133152] CHIP:DL: NVS set: chip-counters/total-operational-hours = 0 (0x0)
[1710960171.822175][133152:133152] CHIP:DL: Inet Layer shutdown
[1710960171.822177][133152:133152] CHIP:DL: BLE shutdown
[1710960171.822179][133152:133152] CHIP:DL: System Layer shutdown
[1710960171.822193][133152:133152] CHIP:TOO: Run command failure: ../examples/chip-tool/commands/pairing/PairingCommand.cpp:164: CHIP Error 0x00000003: Incorrect state

It's not clear to me from the above logs whether chip-tool is being run inside a docker container here, by the way, but if it is that could definitely be an issue; you would need to look into how to configure things so the docker container has BLE access...


Does telepresence solve my problem?

Sorry, This isn't an issue but didn't know where else to put it. I'm developing an application but my laptop can no longer handle development. Does telepresence allow me to develop locally but have my remote services run the code, reducing the workload on my machine? Thanks!!

Yes, Telepresence would be able to handle your use case, assuming your remote services running in a remote Kubernetes cluster? This is certainly one of the use cases. If you have specific questions, hop on our Gitter chat here: https://gitter.im/datawire/telepresence.


Update git ignore for VScode / metals settings

Some ignores for opening the project in VSCode with metals

Thanks!
You probably know this, but you can make a global gitignore for yourself. Still happy to merge in common editor/IDE stuff.


Return empty string if token does not exist in request context

Fixes issue https://github.com/justinas/nosurf/issues/39.
Feel free to close if you want to take an alternative approach to the problem.

It's about damn time to merge this.

Thanks!


⚠ Spryr has degraded performance

In af71766, Spryr (https://spryr.com) experienced degraded performance:

HTTP code: 200
Response time: 4057 ms

Resolved: Spryr performance has improved in 7407a16 after 7 minutes.


Interactive Calendar Widget for Community Page

The mockup of the redesigned community page shows an interactive widget that shows when the next Paketo meetings are:

The CNB community page already includes such a widget.
This issue is to find out what service the CNB site uses for this calendar and add one to the Paketo site.

This seems to be backed by the website teamup.com

Here is the shortcode used on buildpacks.io: https://github.com/buildpacks/docs/blob/f66a95f5befd21594effe7ac6ea244f0af783262/themes/buildpacks/layouts/shortcodes/calendar.html

Let's also follow the request in #263

Currently, the layout of the community page has the section about the Working Group Meeting a the bottom of the page. I think that is would be better if that sections was moved closer to the top to ensure that newcomers see our WG meeting. I think something similar to the buildpacks.io/community would be ideal.

Closing since we currently only host one community event per week. We can revisit this if we've got more meetings to display on a calendar.


Don't require setting asset_host

Previously, croppable used asset_host in the image processing job to know where to find the uploaded image blob. This requires a team to all run the application on the same port in development, and might complicate CDN deployments if assets aren't yet available on the CDN.
This passes the full root URL all the way down from the controller to the job, which is a lot of handing off but seems workable.

I figured out how to get the image without having to explicitly get its url and download it. You just call image.open and rails does that for you. check this commit https://github.com/stevenbarragan/croppable/commit/53c6b4833f3401d0474316fe6b69ee8645569e9f.
Closing this PR since it's not needed any more.


Use the atom-workspace tag instead of the workspace class.

In keymaps\tag.cson: Use the atom-workspace tag instead of the workspace class.

This issue should be fixed now with v0.3.0.
Please update.


[Fix Docs] Improve code formatting

Removed input text "mesheryctl system dashboard"
This PR fixes #9897
Signed commits

[x] Yes, I signed my commits.

🚀 Preview for commit 614875993c52198dbb25a16903eb461df164b437 at: https://659ee81bfd23e814effba654--meshery-docs-preview.netlify.app

@sandramsc I think I wasn't clearly descriptive of rhe ask here, but please find the note in the Issue description which says, don't modify the actual content ( commnds/code snippets ).
The ask is to remove the extra whitespace from the terminal, which finally will look like similar to the desired screenshot.

Thanks for clarifying as the current state screenshot did include the text mesheryctl system dashboard, however, the desired screenshot did not include this text.


Revert "fix(osio): always use jenkins proxy"

Reverts fabric8-launcher/launcher-backend#387

Ike Plugins (test-keeper)
Thank you @gastaldi for this contribution!

It appears that no tests have been added or updated in this PR.
Automated tests give us confidence in shipping reliable software. Please add some as part of this change.
If you are an admin or the reviewer of this PR and you are sure that no test is needed then you can use the command /ok-without-tests as a comment to make the status green.
For more information please head over to official documentation. You can find there how to configure the plugin - for example exclude certain file types so if PR contains only them it won't be checked.


Add the SSL_OP_NO_RENEGOTIATE option to 1.1.0

This is based on a heavily modified version of commit db0f35dda by Todd
Short from the master branch.
We are adding this because it used to be possible to disable reneg using
the flag SSL3_FLAGS_NO_RENEGOTIATE_CIPHERS in 1.0.2. This is no longer
possible because of the opacity work.
A point to note about this is that if an application built against new
1.1.0 headers (that know about the new option SSL_OP_NO_RENEGOTIATE
option) is run using an older version of 1.1.0 (that doesn't know about
the option) then the option will be accepted but nothing will happen, i.e.
renegotiation will not be prevented. There's probably not much we can do
about that.
Fixes #4739

Checklist

[ ] documentation is added or updated
[ ] tests are added or updated

It occurred to me that this is probably worth of a CHANGES entry so I pushed a new commit to add one.

Should we give an error when someone tries to set an unknown option?

+1 from me

FYI: I was confused for a short moment, because the flag is mispelled twice in the commit log of 261088a (also in the title and description of this pr).

Fixed

Should we give an error when someone tries to set an unknown option?

Not sure...that sounds like a change of behaviour, so I'm not sure if we are "allowed". Not in scope for this PR anyway.

Updated to fix the nit identified by @FdaSilvaYY which I somehow missed before. Ping @openssl/committers.


Not enough CI tests

Hi,
Currently, we are facing a lot of issues, we need to have unit tests for

API server & Database
Yaml files functionality
core functionalities

Bests, Ali.

Hi,
Currently, we are facing a lot of issues, we need to have unit tests for

API server & Database
Yaml files functionality
core functionalities

Bests, Ali.

I want to take up this issue

I want to take up this issue too.


Fix NPE when resources have the @Path annotation just on method level

Referring this https://github.com/dropwizard/dropwizard/issues/1066 and consequently this: https://github.com/federecio/dropwizard-swagger/issues/52
This pull request fixes this referred NPE. Basically, what I've found is that resources without @Path annotation on class level the method org.glassfish.jersey.server.model.Resource#getPath returns null, so, causing the issue in EndpointLogger#normalizePath. I've just wrote a defensive code to avoid this NPE.

Thanks!

The NPE also shows up if you're missing<EMAIL_ADDRESS>annotation on a resource method that has a @Produces annotation. This is in Dropwizard 1.0.0. Thanks!

@Lael-Costa, could you file a separate issue and provide an example stacktrace from the NPE you're seeing, please? I don't see how it could be the exact NPE tracked by this issue, since the specific case is now guarded by a null check.


from fastai.vision import * raise error,no module found

Probelm:
I learned fastai deeplearning courseV3. I came across a problem like this:
from fastai.vision import *
from fastai.metrics import error_rate

Output:
ModuleNotFoundError                       Traceback (most recent call last)
<ipython-input-30-283c0d40bede> in <module>
----> 1 from fastai.vision import *
      2 from fastai.metrics import error_rate

ModuleNotFoundError: No module named 'fastai.vision'

What is the problem?
I almost try every version combination of torch,torchvision and fastai, things still goes wrong...
I think the instructor of deep learning course did not give us the specific version of each package to install. If I have a setup.txt storing each version of packages this course needed, I can install packages in a new environment automatically!
My device or software versions:
OS = win10
Python = 3.6
torch = 1.1.0
torchvision = 0.2.2
fastai=1.0.52
I will very appreciate if someone can help me !

likely you have but have you made sure you've selected the correct kernel if you're running it in jupyter?

Please use the forums.


Update Travis config to use Python version that's on our servers

We should be running the same version of Python on Travis that we are on our CF.gov servers, if possible.
Checklist

[ ] PR has an informative and human-readable title
[ ] Changes are limited to a single goal (no scope creep)
[ ] Code can be automatically merged (no conflicts)
[ ] Code follows the standards laid out in the development playbook
[ ] Passes all existing automated tests
[ ] Any change in functionality is tested
[ ] New functions are documented (with a description, list of inputs, and expected output)
[ ] Placeholder code is flagged / future todos are captured in comments
[ ] Visually tested in supported browsers and devices (see checklist below :point_down:)
[ ] Project documentation has been updated
[ ] Reviewers requested with the Reviewers tool :arrow_right:

No dice :(
https://travis-ci.org/cfpb/cfgov-refresh/jobs/439700183#L406-L411


let function (*Cmder).name() be public

for the purpose of recording metrics , we expect to be able to get the name of each cmder ,  this function seems a  good way but is currently private

Makes sense - released v6.3.2


[Feature Request] May I suggest you allow the buttons to wrap

.mantine-1g3xmou {
    flex-flow: wrap;
}

this allow the site to retain its form as the no wrap that is used is a bit janked

vs

Sure, it's easy enough and makes sense.

Added - https://github.com/tehrobber/civitai-one-click-dl/commit/7d6f7bcc35ddbf819ada6455c12c7328a43c89bc


[EventHubs] update event processor livetest

Can one of the admins verify this patch?

/azp run python - eventhubs - tests


SEO: Add default canonical links to pages

Context
After discoving that the plugin we're using isn't working and that we don't have any canonical tags on the blog, I fixed it by building a small plugin.
What's in the PR

Remove non functioning canonical plugin
Add custom plugin to add the canonical tag to blog posts

How to test
One of the quick ways to test/check canonical tags is https://seominion.com/ a browser plugin that you can run on any page.
If you run it on https://blog.ipfs.tech/ currently, you will see there's none.

This PR fixes it for every blog post while still allowing to override via the frontmatter.canonicalUrl

This makes sense but I'm not as familiar with specifics, so looping in @johnnymatthews as a reviewer instead of me. It might be good to include him as a reviewer for all platform-related changes generally.
Also tagging @jennijuju for visibility.

Hey @2color, thanks for flagging this and kicking off a solution - really appreciate that! I've refactored the plugin/config and tested with each scenario and believe this to be resolved now.
Please double check and let me know, then I can deploy to production 😎

Thanks for cleaning it up @cwaring. Looks much cleaner now.
One thing I noticed is that all pages without a trailing slash get 302ed to the version with a trailing slash.
I've added a trailing slash to ensure that pages with a [permalink that doesn't have a trailing slash have it added.

Oh nice @2color, which page did you notice that on? I checked the output log and it seems that they all had trailing slashes here, however an extra safety net doesn't hurt to catch any errors in the user defined permaLink

Everything looks good here, shipping! 🛳

Oh nice @2color, which page did you notice that on?

This was the one: https://bafybeiahz36qlmb43qi6azd72iopbslj2lecfat6ytnkhg2ymawhueplmy.on.fleek.co/17-distributions/
(See that the canonical link in the preview of your last commit is without the trailing slash)
https://github.com/ipfs/ipfs-blog/blob/2b60628e82f5c5819bbfb9bfc04372c381e99c36/src/_blog/006-distributions.md?plain=1#L3


Make leaving change reason customizable via method overriding.

Make leaving change reason customizable via method overriding.
Description
I wanted to leave the request info as change reason for each history change record automatically.
Previous code structure didn't support this.
So I did minor code refactoring.
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have run the pre-commit run command to format and lint.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] I have added my name and/or github handle to AUTHORS.rst
[x] I have added my change to CHANGES.rst
[x] All new and existing tests passed.

@amartis if you rebase on master it should clear up the CI issues

Thank you @jeking3
So can I click "Merge pull request" now?
Right now I'm developing a product and I'm not sure what changes are made in master branch apart from v3.0.0.
So what I feel is master branch is more like beta, and many guys are still interested in stable version (which is v3.0.0).
So I decided to make a patch to v3.0.0
I couldn't find what master branch is about. So if you can explain, I'll try to patch on master branch as well.

@amartis if you rebase on master it should clear up the CI issues

@jeking3 it's merged onto master branch, as you requested. ( PR #962 )


Add PublishReadyToRun to DotNetRestoreSettings

Discussed in https://github.com/orgs/cake-build/discussions/4108

Originally posted by Trisped January 19, 2023
According to https://learn.microsoft.com/en-us/dotnet/core/compatibility/sdk/6.0/publish-readytorun-requires-restore-change#recommended-action :

In .NET 6, dotnet restore followed by dotnet publish -p:PublishReadyToRun=true --no-restore will fail with the NETSDK1095 error. This is because the crossgen binary is now shipped as a separate NuGet package, and so needs to be part of the restore operation for publishing to succeed.

According to https://cakebuild.net/api/Cake.Common.Tools.DotNet.Restore/DotNetRestoreSettings/ , there is not a PublishReadyToRun property like there is in DotNetPublishSettings.
There is a work around (set NoRestore to false), but it requires restoring twice, if you have already restored (for example, so you could test before publishing).

Is it up for contribution?

Hey @SARAVANA1501, no this one already has a pull-request that is waiting to be merged - https://github.com/cake-build/cake/pull/4110

Assigned to @Marusyk


[Gekidou] [MM-39936] Add Select Team Screen

Summary
Add Select Team Screen
Ticket Link
https://mattermost.atlassian.net/browse/MM-39936
Device Information
This PR was tested on:

Android Emulator

Screenshots

Release Note
NONE

Pending iOS and Tablet testing / fixes.

Ready to review, just missing using the right illustration.

Artifact links:
https://output.circle-artifacts.com/output/job/7b4b5d1c-e88b-41bf-a8f9-b4ba5885a58b/artifacts/0/tmp/artifacts/Mattermost_Beta.ipa
https://output.circle-artifacts.com/output/job/2df160dc-076a-4ab5-9ab4-b1e9dd798057/artifacts/0/tmp/artifacts/Mattermost_Beta.apk

Thanks for the thorough review! I will address all your points. It seems there is some transitions that I have not handled well yet (like switching between servers). Also, feels like something is weird with the permissions (not sure if websocket related, or observables related). A "hard refresh" (closing the app and opening) should solve the permission issues (I hope).
The server touchable I have to look a bit deeper. The component is shared in other places, so I have to make sure the changes "make sense" everywhere.
For the cosmetic changes, they should be no problem.

Successfully building:
https://circleci.com/gh/mattermost/mattermost-mobile/21906
https://circleci.com/gh/mattermost/mattermost-mobile/21905

Artifact links:
https://output.circle-artifacts.com/output/job/cf87775a-467e-442f-b7b1-e7b3a57d1aaa/artifacts/0/tmp/artifacts/Mattermost_Beta.ipa
https://output.circle-artifacts.com/output/job/69bf2d75-7c2b-4110-aa28-d6dc01ca42ca/artifacts/0/tmp/artifacts/Mattermost_Beta.apk

@matthewbirtch
Regarding 2 and 4:
This seems to be working on my side. Do you mind sharing more in depth steps? (In case I am missing something)
Regardin 7:
Just solved. CSS was being unruly here :sweat_smile:. If I set 16 margin, one more word fitted the space, and made the space the "expected width". But if I set the margin to 24, that word had to go in the next line, and suddenly the width just hugged the text, and since it was centered (specially for tablets), it got "lots of margin" instead of just 24. Now should be fine.
Regarding 10:
With this you mean the errors from 2 and 4? Or you mean something different?

Regarding 2 and 4: This seems to be working on my side. Do you mind sharing more in depth steps? (In case I am missing something)

Here's what I did:

Admin user: go to System console > Teams and remove the end user from all teams, then save.
Admin user: go to System Console > Permissions > Edit Scheme and under All Members uncheck Create Teams, then save.
End user: Open RNv2 app and switch to server that changes occurred in. I get the 'No teams available' screen, but it shows the 'Create a new team' button

Regarding 2 and 4, the issue was that the roles were not updating correctly on startup. I saw it working right with the websockets, but didn't think about testing the "entry route". Should be fixed now.
Regarding 10, I also fixed a few small things. The only thing that should not update "instantly" is if you are in the select teams screen, and a new public (or accessible) team is created (it won't show in the list until you "refresh" (close the app, or go and back from other server)) or deleted (it won't disappear from the list). This is because there is no "a new accessible team has been created in the system" websocket event. If you get added to a team by any mean (added by other user, join in a different client...), it should go without warning into the team you just were added to.

Building app in separate branch.

Successfully building:
https://circleci.com/gh/mattermost/mattermost-mobile/21918
https://circleci.com/gh/mattermost/mattermost-mobile/21917

Artifact links:
https://output.circle-artifacts.com/output/job/97940960-9326-4c22-8e88-deab4b56f579/artifacts/0/tmp/artifacts/Mattermost_Beta.ipa
https://output.circle-artifacts.com/output/job/367188f8-08d0-41f2-b0a3-b41b45ad8553/artifacts/0/tmp/artifacts/Mattermost_Beta.apk

Regarding 2 and 4, the issue was that the roles were not updating correctly on startup. I saw it working right with the websockets, but didn't think about testing the "entry route". Should be fixed now.

Yep, the above is fixed now.

Regarding 10, I also fixed a few small things. The only thing that should not update "instantly" is if you are in the select teams screen, and a new public (or accessible) team is created (it won't show in the list until you "refresh" (close the app, or go and back from other server)) or deleted (it won't disappear from the list). This is because there is no "a new accessible team has been created in the system" websocket event. If you get added to a team by any mean (added by other user, join in a different client...), it should go without warning into the team you just were added to.

I'm still not seeing instantaneous updates on anything to do with teams. Can we create a separate ticket to look in to this? I think we can merge this as-is and then look at the websocket issues separately. I don't want to block this merge.


Custom Domain URI

Looks like I can only set a domain to go directly to a bucket.  Because of this, the ->url() method will return https://domain.com/domain.com/file.ext. -- the second domain.com being the bucket.
If I try to do domain.com/bucket_name/file.ext, I get permission denied even though the file is public.
Am I missing something?

@michaelaguiar In your custom domain remove the s from httpS
Similar issue here. I get http://custom.domain.com/BUCKET/path/to/file.ext
Any way to remove the bucket name from the url entirely. Even if I put null in the bucket config, I still get an empty "/", which gives me:
http://customdomain.com//path/to/file.ext , which fails to load the file due to the incorrect absolute path.

@evinkuraga My bucket name is a custom domain static.domain.com which point to directly to my bucket.
Setting GOOGLE_CLOUD_STORAGE_API_URI=null,  $disk->url('my_file.ext'); returns correctly with https://storage.googleapis.com/static.domain.com/my_file.ext
When  this is set GOOGLE_CLOUD_STORAGE_API_URI=http://static.domain.com, it returns http://static.domain.com/static.domain.com/my_file.ext which is not valid instead of http://static.domain.com/my_file.ext.
Any fix?

@victorybiz You can set GOOGLE_CLOUD_STORAGE_API_URI=http://static.domain.com/
/ at the end

Thanks everyone, this issue is closed.


bounty: BLAKE3 implementation

This is my attempt at the BLAKE3 bounty.

closing in favour of https://github.com/tinygrad/tinygrad/pull/7773


[Freetype] Actually prevent linking HarfBuzz on POSIX

Correctly fixes #10041
Fixes three typos in #10073
The important environments to test are x64-osx and x64-linux. On macOS, I have freetype and harfbuzz already installed from Homebrew and noticed that harfbuzz was still being linked and this now correctly prevents Freetype's CMake from finding harfbuzz.

Does your PR follow the maintainer guide? Yes

Thanks for the PR!


Can’t use kwargs on legends

With the following template
<%= f.govuk_fieldset
  legend: {
    text: 'Question title',
    size: 'xl',
    tag: 'h1',
    a: 'b'
  },
  caption: {
    text: 'Section title',
    a: 'b'
  }
do %>
  …
<% end %>

the following HTML is output:
<fieldset class="govuk-fieldset">
  <legend class="govuk-fieldset__legend govuk-fieldset__legend--xl">

      Section title
      Question title

  </legend>
  …
</fieldset>

Note how a=b does not appear on the <legend> element, as suggested in the documentation, and as shown to work as an option for caption.
https://github.com/DFE-Digital/govuk_design_system_formbuilder/blob/d269218348fd976af8f05850664cd38699a22370/lib/govuk_design_system_formbuilder/elements/legend.rb#L7-L28
I’m wondering if @html_attributes = kwargs should appear within the clause when Hash (but that’s just a wild and uninformed stab in the dark).

Yeah, definitely a bug here. You identified the line at fault but the reason is that the custom attributes are in the legend hash and not in kwargs. This class is a bit out of step with its siblings due to the way it used to be structured, I'll bring it inline and add some tests on this behaviour. Thanks for reporting :+1:


keycloak test script: use env to launch bash

This minor change allows users to use the latest version of bash on Mac OS.
/bin/bash is very old on Mac OS, and many users will have bash from MacPorts or Homebrew. This change allows such users to be able to use the newer bash installation.

Nice, thanks!

Releasing new version


Plots do not render in jupyter notebooks on remote container

Environment data

VS Code version: 1.57.0 (Universal)
Jupyter Extension version (available under the Extensions sidebar): v2021.6.999406279
Python Extension version (available under the Extensions sidebar): v2021.6.944021595
OS (Mac) and version: Darwin x64 20.4.0
Python and/or Anaconda version: conda 4.10.0
Type of virtual environment used (virtualenv): Kubernetes Pod
Jupyter server running: Remote

Expected behaviour
Plot rendering normally like:

Actual behaviour
Error loading preloads: Failed to execute 'fetch' on 'Window': Failed to parse URL from ...

(When rendering plots locally instead of on a remote container weird behaviour can also be observed)

Steps to reproduce:
from matplotlib import pyplot as plt
import numpy as np
img = np.random.rand(32*32*3).reshape(32,32,3)
plt.imshow(img)

Execute cell in a remote container.
Current workaround: choosing different output mimetype manually

Sadly changing the default display order for mimetypes in settings.json did not solve the problem for me.

@daniel-scheliga Do you still see this issue in the latest VS Code release?

This is still happening for me

Version: 1.59.0
Commit: 379476f0e13988d90fab105c5c19e7abc8b1dea8
Date: 2021-08-04T23:14:40.191Z
Electron: 13.1.7
Chrome: 91.0.4472.124
Node.js: 14.16.0
V8: 9.1.269.36-electron.0
OS: Darwin x64 20.5.0

After restarting my pod, I'm seeing a different error message.

Of the following mime-types, the built-in ones work as expected. However, like @daniel-scheliga, changing the priority order with "notebook.displayOrder": ["image/pngkajsd"], doesn't fix the issue.

Version: 1.59.0
Commit: 379476f0e13988d90fab105c5c19e7abc8b1dea8
Date: 2021-08-04T23:14:40.191Z
Electron: 13.1.7
Chrome: 91.0.4472.124
Node.js: 14.16.0
V8: 9.1.269.36-electron.0
OS: Darwin x64 20.5.0

Possible a duplicate of #123494. Can you please testing this in the latest VS Code insiders build? This should be listed as VS Code 1.60

Possible a duplicate of #123494. Can you please testing this in the latest VS Code insiders build? This should be listed as VS Code 1.60

Works for me. Thank you!


How do I remove HTML, CSS, JS temporary files

This library internally creates temporary files if we provide contents against 'html' , 'css', 'js' fields in option. But they are not removed after generating pdf file. However it provides a path to pdf's temporary file and also an option 'deleteOnAction' (not working for me though) to remove the temporary pdf file. It would be nice to have a clean method in PDFResult class which removes all the auto-generated temporary files including html, css, js, runnings, pdf.

Hi, this lib only creates one temporary pdf-file, which will be automatically removed afterwards. You can control this with deleteOnAction.
You need to delete your input files by your own.
If you think deleting input files is a good feature, please create a PR.
I hope I understood your question correctly. Otherwise please explain it with more detail.
Cheers Dustin.

Hoping this is solved. Otherwise please reopen.


Combine ttyd and tmux

Hi there,
I think it might be easy but I have already tried everything possible.
I just want to run ttyd connecting to a tmux session and be able to use arrow keys (up and down) to navigate thru the past inputs/commands
I test both alone, tmux and ttyd works to save and browse historical data. The problem I m facing is when I connect both, then every thing I got when using arrow keys are ^[[A...
Do someone know how to make this connection works?
it is my commands being used to start the services:
tmux new-session -d -s server -e TERM=xterm-256color "zsh -c 'trap \"\" SIGINT; cd /app/server; exec ./server'"
exec /server/system/ttyd -W -p 8080 -T xterm-256color bash -c 'tmux attach-session -t server'

tmux new-session -d -s server "less /etc/passwd"
ttyd -W -p 8080 "tmux att -s server"

the arrow key works fine in browser.


PVC switches to read only when running out of free space

When running out of free space, pvc switches to readonly mode
How to reproduce:
Create 4Gb PVC
Mount to pod, then try to write to mounted pvc more than 4Gb (with dd, for example)
pvc switches to R/O mode. Can't delete data from it. Can't remount.

Have you tried to read-only remount?

@xriser is this ONTAP, Element, CVS, (which driver are you using)? NFS or iSCSI?

@xriser  can you please answer to the question asked by @korenaren ?

ONTAP, iSCSI

Have you tried to read-only remount?

no

Is space allocation enabled on the LUN? This is most likely the issue reported in #135.

Closing, as this is most likely fixed (#135) in 19.07.


Vim.exe HiDPI buffer size / cursor positioning

From @parkovski on November 28, 2017 18:56
Originally posted here.
I'm on Win10 build 1709, having an issue with a recent vim patch enabling termguicolors when maximized on a HiDPI scaled screen.
Here is what it looks like opening a file and typing k to move up a line (should do nothing on the first line):

Here is what it looks like scrolling down and trying to use the command line:

I'm using PowerShell 6 RC, but this happens in Windows PowerShell too. You can see how maximizing the console cuts off a line at the bottom of the screen, and the scroll bar on the right is spilling over onto the next screen.
My setup is a Surface Pro 4 with a standard DPI external monitor - the issue only happens when I start vim in an unmaximized console and then maximize it on the Surface (HiDPI) screen. The console spills over to the next screen and it seems like the buffer is shifted up by one line - ggk shows a white line at the top with no line number, and Goj makes inserted text appear on the line above where it's supposed to be.
After it's glitched out like this, unmaximizing the Window makes it even worse, kind of like @9a3eedi's tmux in the thread linked at the top, and Ctrl-L to redraw the screen doesn't fix it.
I noticed a similar off-by-one bug at the bottom of the console buffer while working on ANSI input for PSReadLine, but can't be sure if it's my bug or this one.
Here is a copy of my patched vim.exe - hopefully this will help diagnose the problem. You may need these commands to make tgc work:
set t_Co=256
set t_8f="\e[38;2;%lu;%lu;%lum"
set t_8b="\e[48;2;%lu;%lu;%lum"
noremap! <Char-0x7F> <BS>
set tgc

Copied from original issue: Microsoft/WSL#2704

From @zadjii-msft on November 28, 2017 19:7
Hmm.
Am I correct that the unpatched version of vim.exe doesn't repro the issue?
I know there's some weird off-by-one-ness in SetConsoleScreenBufferInfo* - If you're calling that, you almost certainly need to increment srWindow.Bottom when roundtripping the CONSOLE_SCREEN_BUFFER_INFO_EX. See
https://github.com/Microsoft/console/blob/master/tools/ColorTool/ColorTool/Program.cs#L187
for an example.

From @parkovski on November 28, 2017 19:37
Sure, it's this vim PR. If that patch has an off-by-one bug, I'm still confused by the maximizing behavior. If I maximize the Window on a standard DPI screen, it fills the whole screen area like I'd expect, but on the Surface screen there's a gap at the bottom and the right edge spills off the side (screenshots show this). And the fact that the glitch only happens on the HiDPI screen makes it seem like it might have to do with the maximizing behavior doing one thing but reporting another.

From @parkovski on November 30, 2017 18:38
It runs inside conhost, and it uses an alternate screen buffer to not overwrite the main one used by the shell, which is something else I've noticed - if you maximize the window with vim open and then exit vim, the console window shrinks back to the pre-maximized size because (I think) the original screen buffer doesn't resize when the window changes size. That happens regardless of DPI scaling, but only on Windows vim, not Linux/WSL.

From @zadjii-msft on November 28, 2017 20:34
Okay, sorry for my lack of knowledge on the specifics, but does vim.exe run inside of conhost.exe (responsible for cmd.exe, powershell.exe, wsl.exe, ubuntu.exe, etc) or does it draw it's own UI and window?
HiDPI is one of the great banes of our existence, and these kinds of bugs are terribly notorious to track down and often times change wildly from build to build, so I just want to get as much detail as I can.

From @zadjii-msft on November 30, 2017 19:24
Thanks for clearing that up! I didn't realize that anyone really used the CreateConsoleScreenBuffer API in the wild. That would explain the behavior you referenced, seperate buffers created with CreateConsoleScreenBuffer are pretty much left alone from one another, while alternate buffers created by WSL are more closely tied to the buffer that created them.
I've filed a bug to investigate further. We'll keep you posted :)

From @miniksa on December 4, 2017 17:52
@parkovski, I'm not seeing the gap at the bottom on my High DPI display.
Can you tell me the exact pixel dimensions of the monitor and the scaling factor being used?

From @parkovski on December 4, 2017 19:40
Sure, it's a Surface Pro 4, 2736x1824px, 200% scaling, and I'm using the Fira Mono font, console size 16.
My second screen is 1920x1080, 100% scaling, and it's set to the primary monitor. I'll check if it happens when that one isn't attached, just have to log out first.

From @parkovski on December 4, 2017 20:6
Ok - when I log in with the standard DPI screen as primary, the screenshots I posted above are what happen.
When I log in without the extra monitor attached, everything works fine until I attach the second screen - then I get the buffer glitches on the second screen, but not on the surface screen (so this seems to happen for DPI scales that are not the one the login session was started with). The window maximizes to the right size though in this case on the second (standard DPI) screen, even though the buffer is glitchy. The buffer is not glitchy on the Surface screen, but the window maximizes to the wrong size, but a different wrong size than when I start my login session on the second screen:

So it's kind of the opposite from before - instead of hanging over the right edge, there's a gap at the right now, and a tiny, maybe 1px gap at the bottom instead of a whole line.
Hope this helps.

From @parkovski on December 5, 2017 19:6
It does happen with regular Windows PowerShell and cmd, interestingly there are no gaps or buffer glitches on my Surface screen with my font set to Consolas although I get a horizontal scroll bar instead and the ex (:) command line is behind the scroll bar. With Consolas the maximized window has gaps on my external standard DPI monitor. There are no buffer glitches with stock vim (or my patched vim with tgc off), but the window still maximizes to the wrong size with with gaps.
I also tested the console mode with this utility. Stock vim is
Attached to process 5004.
cur[in]  = 0x1F8
         = ENABLE_WINDOW_INPUT | ENABLE_MOUSE_INPUT | ENABLE_INSERT_MODE | ENABLE_QUICK_EDIT_MODE | ENABLE_AUTO_POSITION
cur[out] = 0x4
         = ENABLE_VIRTUAL_TERMINAL_PROCESSING

My patched vim is
Attached to process 948.
cur[in]  = 0x1F8
         = ENABLE_WINDOW_INPUT | ENABLE_MOUSE_INPUT | ENABLE_INSERT_MODE | ENABLE_QUICK_EDIT_MODE | ENABLE_AUTO_POSITION
cur[out] = 0x5
         = ENABLE_PROCESSED_OUTPUT | ENABLE_VIRTUAL_TERMINAL_PROCESSING

From @miniksa on December 5, 2017 17:15
Can you get this to happen with a standard console host running stock CMD/Powershell or with a production version of Vim?

From @parkovski on December 5, 2017 21:36
Sorry it's getting so complicated. I'll try to make this as reproducible as possible. This is the stock vim I'm using
First issue - stock cmd, stock font (Consolas 14), stock vim from above link. I'm running vim with "-u nul -i nul" so it doesn't load my .vimrc or .viminfo. Move the console to the primary standard DPI monitor, then move it back to the HiDPI Surface screen and maximize it. Then run "vim -u nul -i nul" after maximizing the window. I'm seeing gaps around the window at this point. If I leave the window on the surface screen, quit vim and start it again, the size is fine. If I move it to the standard DPI screen and back to the HiDPI screen, maximize, and then start vim again, the gaps come back. After some more testing, it looks like the font does not affect this - the same happens with Consolas and Fira Mono (exact same steps). It looks like this:

When I mentioned that quitting vim and starting it again with the window still maximized has the correct size - that is true, every other time. Leaving the window in place, on the surface screen, after it has been on the standard DPI screen, start vim and quit repeatedly. It alternates between the correct maximized size and gaps as I posted in the screenshot.
Second issue with the scroll bars seems related to the "Wrap text on output" option. My cmd window does not have that option set; my PowerShell (Windows, not Core) does. In this case, using PowerShell with the option set, same steps as above, move the console to the standard DPI screen and then back to the HiDPI screen. Maximize it, and then open vim (-u nul -i nul). The first time, Consolas has only a horizontal scrollbar; Fira Mono has both horizontal and vertical scrollbars, but no part of vim is hidden behind them. I think that had to do with the patched vim, I'll look into that later. Exiting and restarting vim with the window unmoved, it will alternate between the correct size and gaps like above. Moving it to the standard DPI screen and back again will show the scroll bars one more time. This is Windows PowerShell, Consolas 14, vim from above link with no vimrc/viminfo, wrap text on output enabled, first time opened on HiDPI screen after coming from standard DPI screen:

I'll try to come up with reproducible steps for the patched vim/glitchy buffer issue later. This covers everything I'm seeing with stock everything.

From @miniksa on December 5, 2017 19:43
OK let me try to unpack all of this.
There's one issue with the stock everything. Stock CMD, stock font (Consolas), stock Vim (of some version, please provide me the version number/download link). And that's that maximizing the window on a High DPI monitor (2736x1824px, 200% scaling) with a screen buffer created with CreateConsoleScreenBuffer() API seems to leave a gap around the frame of the window. Correct?
Then there's a second issue. Stock CMD, custom font (Fira Mono), stock Vim (hopefully same version). And maximizing that window on a High DPI monitor (2736x1824px, 200% scaling) with a screen buffer created with CreateConsoleScreenBuffer() API hides part of the buffer behind the scroll bar. Correct?
Then there's a third issue. Stock CMD, stock font (Consolas), custom built Vim (of your own patch). And maximizing that window on the High DPI monitor with the CreateConsoleScreenBuffer() buffer has a problem with the scrolling. Correct?

From @miniksa on December 5, 2017 21:39
Wonderful, thanks. I moved on to stare at another bug at this exact moment, but I'll circle back to this when that one is done. Your effort on laying this out cleanly is much appreciated!

From @miniksa on December 8, 2017 18:9
@parkovski I just want to let you know that I'm still finishing up the other bug I'm working on and probably won't get to this one by the time I leave today. I have some scheduled vacation coming up starting Monday as do many of my co-workers and peers for the holiday season. As such, I'd just like to instill that this bug is still on our queue of things to do, but we may not get to it for a few weeks. I apologize for the inconvenience and would like to reiterate my appreciation for your efforts in helping us narrow this down to an easily reproducible set of steps.

From @parkovski on December 8, 2017 19:34
No problem, it's pretty easy to work around for now. I probably won't get the fix until the next major update anyways since I'm not running insider builds.

Just wanted to bring this back up - I am still getting gaps when moving the console to the other screen. There is another issue I've noticed around secondary buffer size that may/may not be related, going to open another issue for it.

This bug is still parked on my plate. It's just been too low a priority versus other things I have going on (visual graphical glitch is a way lower priority than crashes and API processing issues.)
I intend to look at it, but it's going to just take time.

No problem, just noticed it again recently and wanted to make sure it didn't get lost.

It's cool. We don't really lose things as much as we have literally thousands of voices talking to us all the time. We appreciate your patience here.

i remember there being a similar issue with cmder i'm 90% sure this was related to some changes windows made in 1709 and it should be fixed now.

Hey so I'm playing with a fairly recent vim (8.2.3412), on Windows 11, in conhost (not the Terminal), and I can't seem to get any of the repros in this thread to happen anymore. given the thread's more than 4 years old at this point, who knows what could have fixed this. @parkovski You still seeing this?


chore: regular update

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.01%. Comparing base (7810f0f) to head (d5a845c).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #142   +/-   ##
=======================================
  Coverage   90.01%   90.01%
=======================================
  Files          14       14
  Lines         851      851
=======================================
  Hits          766      766
  Misses         85       85

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


np (NullPropagation) throws NullReferenceException with property on .NET Core 3.1

After upgrading to .NET Core 3.1 from .NET Core 2.2, it seems that the np() operator now throws an NullReferenceException, even on properties. Here's a little piece of code that I run on LinqPad 6 that produces the bug :
void Main()
{
	var users = new[] { new User() { FirstName = "John" } }.AsQueryable();

	// Act
	var resultDynamic = users.Any("c => np(c.LastName, string.Empty).ToUpper() == \"Doe\"");
	resultDynamic.Dump();
}

public class User
{
	public string FirstName { get; set; }
	public string LastName { get; set; }
	public string EmailAddress { get; set; }
}

@ahocquet Can you provide a full EF 3.1 example project please?

I don't use Entity Framework, or maybe you mean .NET Core 3.1 ?

I see.
The problem is that the code np(c.LastName, string.Empty) does not work correctly, the string.empty is not applied, so you get null-pointer exception.
Note that nested properties work fine:
public static void Main()
        {
            var users = new[] { new User() { FirstName = "John" } }.AsQueryable();

            var resultDynamic = users.Any("c => np(c.Permission.Name, string.Empty).ToUpper() == \"Doe\"");
            Console.WriteLine(resultDynamic);
        }

        public class User
        {
            public string FirstName { get; set; }
            public string LastName { get; set; }
            public string EmailAddress { get; set; }

            public Permission Permission { get; set; }
        }

        public class Permission
        {
            public string Name { get; set; }
        }

I will investigate and try to fix.

Sounds great, thank you!

@ahocquet can you try MyGet version System.Linq.Dynamic.Core.1.0.20-ci-12438.nupkg ?

Works great, thanks for fixing it so fast!

PR will be merged to master https://github.com/StefH/System.Linq.Dynamic.Core/pull/338
And a new official NuGet will be released.


Summary for Classes should not start with meaningless phrases

Summaries of classes should describe the functionalitities which are provided / implemented by the class, but not how it it used or which interface it implements.
So phrases like the followings should not be used:

Class that is used to
Class used to
Class to
Implements ...
XYZClassName ...
Used to
Viewmodel which is used for
Used for
The
A
An
...

Comments that start with a < have to be also reported

Use message Be more descriptive. Do not use meaningless phrase ...


Check Type error when loading yolo node.

I have been using Github Actions to run an inference pipeline. One part of it is to load model, which always downloads the weights and proceed to run inference on some images. It was running fine for a few weeks but three days back I encountered the following error.
Run python -m src.main
2023-03-1[7](https://github.com/tappyness1/causion/actions/runs/4448171378/jobs/7810623692#step:7:8) 21:50:47.316131: W tensorflow/stream_executor/platform/default/dso_loader.cc:64] Could not load dynamic library 'libcudart.so.11.0'; dlerror: libcudart.so.11.0: cannot open shared object file: No such file or directory; LD_LIBRARY_PATH: /usr/share/miniconda/lib/python3.[8](https://github.com/tappyness1/causion/actions/runs/4448171378/jobs/7810623692#step:7:9)/site-packages/cv2/../../lib64:/opt/hostedtoolcache/Python/3.8.16/x64/lib
2023-03-17 21:50:47.316156: I tensorflow/stream_executor/cuda/cudart_stub.cc:2[9](https://github.com/tappyness1/causion/actions/runs/4448171378/jobs/7810623692#step:7:10)] Ignore above cudart dlerror if you do not have a GPU set up on your machine.
2023-03-17 21:50:48 peekingduck.pipeline.nodes.model.yolo  INFO:  Config for node model.yolo is updated to: 'model_type': v4
2023-03-17 21:50:48 peekingduck.pipeline.nodes.model.yolo  INFO:  Config for node model.yolo is updated to: 'detect': ['car', 'motorcycle', 'truck', 'bus']
2023-03-17 21:50:48 root  ERROR:  Traceback (most recent call last):
   File "/usr/share/miniconda/lib/python3.8/runpy.py", line 194, in _run_module_as_main
    return _run_code(code, main_globals, None,
   File "/usr/share/miniconda/lib/python3.8/runpy.py", line 87, in _run_code
    exec(code, run_globals)
   File "/home/runner/work/causion/causion/src/main.py", line 67, in <module>
    main()
   File "/home/runner/work/causion/causion/src/main.py", line 17, in main
    inference_obj = inference()
   File "/home/runner/work/causion/causion/src/inference.py", line 63, in __init__
    self.yolo_node = pkd_yolo.Node(model_type = "v4", detect= ["car", "motorcycle", "truck", "bus"])
   File "/usr/share/miniconda/lib/python3.8/site-packages/peekingduck/pipeline/nodes/model/yolo.py", line 80, in __init__
    super().__init__(config, node_path=__name__, **kwargs)
   File "/usr/share/miniconda/lib/python3.8/site-packages/peekingduck/pipeline/nodes/abstract_node.py", line 68, in __init__
    self.load_node_config(config, kwargs)  # type: ignore
   File "/usr/share/miniconda/lib/python3.8/site-packages/peekingduck/pipeline/nodes/abstract_node.py", line [13](https://github.com/tappyness1/causion/actions/runs/4448171378/jobs/7810623692#step:7:14)5, in load_node_config
    self._check_type(self.config, self._get_config_types())
   File "/usr/share/miniconda/lib/python3.8/site-packages/peekingduck/pipeline/nodes/abstract_node.py", line [15](https://github.com/tappyness1/causion/actions/runs/4448171378/jobs/7810623692#step:7:16)1, in _check_type
    check_type(f"{self.node_name}'s `{full_key}`", config[key], config_type)

2023-03-[17](https://github.com/tappyness1/causion/actions/runs/4448171378/jobs/7810623692#step:7:18) [21](https://github.com/tappyness1/causion/actions/runs/4448171378/jobs/7810623692#step:7:22):50:48 root  ERROR:  TypeError: check_type() takes 2 positional arguments but 3 were given

Error: Process completed with exit code 1.

peekingduck==1.3.0.post1

Issue has to do with typeguard recently updating to 3.0.1, where in 3.0.0, check_type() is no longer backward compatible.
https://typeguard.readthedocs.io/en/latest/versionhistory.html
3.0.0 (2023-03-15)

BACKWARD INCOMPATIBLE Dropped the argname, memo, globals and locals arguments from check_type()

Suggested fix is to set requirement.txt to:
typeguard==2.13.3 # currently : typeguard >= 2.13.3

Thanks for flagging this issue.
This will be updated and fixed in the next PeekingDuck release.
For now, users will have to use the above typeguard fix that you suggested.


Add event listener providers

closes #109
PR deploys some testsuite providers, so they are available for the server in the testsuite. The provider, which is referenced in the test, caused the test failure.
The keycloak-client should not have any dependency on the Keycloak-server, but it is probably fine to have dependency on the server in the testsuite? Could it be any issue (like productization or something else) why adding dependency on keycloak server artifacts in testsuite/providers can cause issues?

@jonkoops Thanks for the review!


hue.ini world-readable

Hello hue team,
I would like to report a security vulnerability.
The hue.ini configuration file, where service credentials are stored, is by default (from the tarball release) accessible to anyone with the other permission set to read:
$ tar tvf hue-cdh5.8.3-release.tar.gz | grep hue\.ini
-rw-rw-r-- root/root     50852 2016-10-12 19:44 hue-cdh5.8.3-release/desktop/conf.dist/hue.ini

That finding can be seen on the Cloudera QuickstartVM:
[cloudera@quickstart ~]$ ls -al /etc/hue/conf/hue.ini
-rw-rw-r-- 1 root root 22813 Nov 18  2015 /etc/hue/conf/hue.ini

I know that you put some guidelines for password management here but relying on the user to restrict permissions post-installation is not a good security measure.
Hence I recommend that you restrict permissions for that file to only the hue user (600) or the hue group in the release tarball: with that measure, lowering the security is the user's responsibility.
If possible, it would be cool to have a CVE number to track that vulnerability.
Cheers.

/etc/hue/conf is done at the CDH level not Hue.
We can however have a look at the makefile to chmod the hue.ini when doing 'make prod'.

/etc/hue/conf is done at the CDH level not Hue.

I haven't looked at the installation script of CDH but I doubt that it does more than a tar xvf

We can however have a look at the makefile to chmod the hue.ini when doing 'make prod'.

Yes that would be one possible solution.
Cheers

It is fixed ?


Consume vsts-task-tool-lib 0.9 to fix race condition

related to this issue: https://github.com/Microsoft/vsts-tasks/issues/7413

@bishal-pdMSFT @arjgupta

@keithrob ? who can approve this PR?


.deb's won't install on 18.04 chroot

Please paste the output of the following command here: sudo edit-chroot -all
name: bionic
encrypted: no
Entering /mnt/stateful_partition/crouton/chroots/bionic...
crouton: version 1-20200724165050~master:08dac970
release: bionic
architecture: arm64
xmethod: xiwi
targets: gnome-desktop,x11,core,touch,audio,keyboard,cli-extra,extension,xiwi,gtk-extra
host: version 13499.0.0 (Official Build) canary-channel kukui
kernel: Linux localhost 4.19.147-10385-g11e2f8e1c066 #1 SMP PREEMPT Tue Sep 29 04:00:35 PDT 2020 aarch64 aarch64 aarch64 GNU/Linux
freon: yes
Not unmounting /mnt/stateful_partition/crouton/chroots/bionic as another instance is using it.

name: eoan
encrypted: no
Entering /mnt/stateful_partition/crouton/chroots/eoan...
crouton: version 1-20200724165050~master:08dac970
release: eoan
architecture: arm64
xmethod: xiwi
targets: lxde,x11,core,touch,audio,keyboard,cli-extra,extension,xiwi,xorg,gtk-extra
host: version 13499.0.0 (Official Build) canary-channel kukui
kernel: Linux localhost 4.19.147-10385-g11e2f8e1c066 #1 SMP PREEMPT Tue Sep 29 04:00:35 PDT 2020 aarch64 aarch64 aarch64 GNU/Linux
freon: yes
Unmounting /mnt/stateful_partition/crouton/chroots/eoan...

Please describe your issue:
.deb packages won't install on my 18.04 chroot.
If known, describe the steps to reproduce the issue:
Ctrl+Alt+T to bring up the terminal.
(bionic)o_x@localhost:~$ sudo gdebi ~/Minecraft.deb
Reading package lists... Done
Building dependency tree
Reading start information... Done
Failed to open the software package
The package might be corrupted or you are not allowed to open this file. Check the permissions of the file.
(bionic)o_x@localhost:~$

Discord was an amd64 file, and I'm using the Lenovo Duet, so I had to add the architecture.
Any solutions? I'm not that good with Linux yet, but I'm willing to learn what I need to fix this.

Have you tried anything other than 'gdebi' ?
Maybe try: cd; sudo apt install ./Minecraft.deb -or- sudo dpkg -i ~/Minecraft.deb
If neither of those work and give you the same error then perhaps download the .deb file again and use a checksum if they offer one.
Hope this helps,
-DennisLfromGA

I Will try, thanks!
Sorry for the late reply.

It didn't work; here's the output:
(bionic)o_x@localhost:~$ cd; sudo apt install ./Minecraft.deb [sudo] password for o_x:  Segmentation fault (bionic)o_x@localhost:~$ sudo dpkg -i ~/Minecraft.deb dpkg-deb: error: '/home/o_x/Minecraft.deb' is not a Debian format archive dpkg: error processing archive /home/o_x/Minecraft.deb (--install): dpkg-deb --control subprocess returned error exit status 2 Errors were encountered while processing:  /home/o_x/Minecraft.deb (bionic)o_x@localhost:~$
I then did a checksum:
(bionic)o_x@localhost:~$ sudo cksum Minecraft.deb<PHONE_NUMBER> 96380 Minecraft.deb (bionic)o_x@localhost:~$
I'm not the most experienced Linux user, so I don't really understand the cksum command.

@marauder316,
Those errors seem to point to a corrupt or incomplete Minecraft.deb file.
Perhaps download a fresh copy or, maybe even better, try to find another source for it.
Hope this helps,
-DennisLfromGA

@marauder316
Did a fresh copy work? If it didn't work then try something other then Minecraft.deb... Alternatively try another source as @DennisLfromGA  said (like flatpak or snap).
Also I don't believe arm64 devices running Linux can run Minecraft... although that being said if you are very advanced you might be able to build OpenJDK for ARM, Microsoft did it for the ARM version of Windows, check out this post.

@MrHallway0 It didn't. Minecraft Java Edition isn't supported on arm64 devices.
I'm not smart enough yet to make a build. Maybe someday down the line :D
I'll close the issue. Thanks for your advice, guys.


cleanup utils and remove unused dependencies

Codecov Report

Merging #130 (864a9a7) into main (35481f5) will decrease coverage by 1.46%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #130      +/-   ##
==========================================
- Coverage   69.31%   67.85%   -1.47%
==========================================
  Files          25       25
  Lines        1571     1543      -28
  Branches      218      214       -4
==========================================
- Hits         1089     1047      -42
- Misses        453      468      +15
+ Partials       29       28       -1

Impacted Files
Coverage Δ

src/dvc_objects/fs/base.py
55.98% <ø> (ø)

src/dvc_objects/fs/utils.py
37.50% <ø> (-4.42%)
:arrow_down:

tests/fs/test_utils.py
100.00% <ø> (ø)

src/dvc_objects/fs/system.py
63.23% <0.00%> (-20.59%)
:arrow_down:

tests/test_reflink.py
87.50% <0.00%> (-12.50%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


request: bootstrap-version=4 should setup sass by default

Thank you for taking the time to open an issue!
For general questions please use the #e-bootstrap channel on the Ember
community Slack.
For bug reports please include the following section in your issue details.
If you include instructions on how to reproduce the bug or a failing test case
it will make it easier for us to track down the issue you're having.

Output from ember bootstrap:info (available since 1.0.0-alpha.9):
ember-bootstrap: ^1.0.0-rc.2 -> 1.0.0-rc.2
ember-cli: ~2.14.2 -> 2.14.2
bootstrap: ^4.0.0-beta -> 4.0.0-beta
bootstrap-sass: n/a
ember-cli-sass: ^7.0.0 -> 7.0.0
ember-cli-less: n/a
Bower packages:
bootstrap: n/a
bootstrap-sass: n/a
ember-bootstrap configuration:
bootstrapVersion: 4
importBootstrapFont: false
importBootstrapCSS: false

Since bootstrap v4 is using sass by default, it might be helpful & expected to include sass setup when the generator is run with --bootstrap-version=4
first I ran:
ember g ember-bootstrap --bootstrap-version=4

but then I realized what I wanted to run was:
ember g ember-bootstrap --bootstrap-version=4 --preprocessor=sass

so maybe (?) the first should imply the second. But then again, maybe not.

To install ember-bootstrap with bootstrap v4beta and ember-cli-sass
ember install ember-bootstrap --bootstrap-version=4 --preprocessor=sass

It defaults to SASS if you were already using it. We didn't want to default it for compatibility with the defaults for people migrating from BS3, and we thought that the choice of a new  tool should be an explicit rather than implicit choice. That's just the rationale for the original implementation, but it needs to be considered at least until BS4 comes out of "experimental."

I still believe adding Sass to your project should be an explicit choice by the user, as stated by @srvance. But the work in #569 to add an interactive installer will make this choice much more apparent. So will close this for now. Thanks for your feedback!

ok thank you


My custom filter is not working

In my spring boot application, there is a requirement to retrieve two tokens (type 1 and type 2)one is the bearer and other is a custom one and authenticate both and logical AND the result. For this, My idea is to override the doFilter() of OAuth2AuthenticationProcessingFilter and use a custom authentication manager to authenticate both tokens.
For this I just created a custom filter, code snippet is given below
@Override
	public void configure(HttpSecurity httpSecurity) throws Exception {
		httpSecurity.csrf().disable();
		httpSecurity.authorizeRequests().anyRequest().authenticated();
		httpSecurity.sessionManagement().sessionCreationPolicy(SessionCreationPolicy.STATELESS);
		httpSecurity.addFilterAfter(new CantizOauth2Authenticationfilter(),AbstractPreAuthenticatedProcessingFilter.class);
		super.configure(httpSecurity);
	}

my custom filter is given below
public class CantizOauth2Authenticationfilter extends OAuth2AuthenticationProcessingFilter{
	private final static Log logger = LogFactory.getLog(OAuth2AuthenticationProcessingFilter.class);
	private NucleusTokenExtractor tokenExtractor = new NucleusTokenExtractor();
	private AuthenticationDetailsSource<HttpServletRequest, ?> authenticationDetailsSource = new OAuth2AuthenticationDetailsSource();
	private boolean stateless = true;
	private AuthenticationManager authenticationManager=new CantizAuthenticator();
	private AuthenticationEventPublisher eventPublisher = new NullEventPublisher();

	public void setAuthenticationManager(AuthenticationManager authenticationManager) {
		this.authenticationManager = authenticationManager;
	}

	public void doFilter(ServletRequest req, ServletResponse res, FilterChain chain)
			throws IOException, ServletException {

		List<Authentication> authList = tokenExtractor.extract((HttpServletRequest) req);

		if(authList!=null)
		{
			for (Authentication authenticate: authList) {

				authenticate(authenticate,(HttpServletRequest) req);
			}
		}
		chain.doFilter(req, res);
	}

	private void authenticate(Authentication authentication,HttpServletRequest request ) {
		final boolean debug = logger.isDebugEnabled();
		if (authentication == null) {
			if (stateless && isAuthenticated()) {
				if (debug) {
					logger.debug("Clearing security context.");
				}
				SecurityContextHolder.clearContext();
			}
			if (debug) {
				logger.debug("No token in request, will continue chain.");
			}
		}
		else {
			request.setAttribute(OAuth2AuthenticationDetails.ACCESS_TOKEN_VALUE, authentication.getPrincipal());
			if (authentication instanceof AbstractAuthenticationToken) {
				AbstractAuthenticationToken needsDetails = (AbstractAuthenticationToken) authentication;
				needsDetails.setDetails(authenticationDetailsSource.buildDetails(request));
			}
			Authentication authResult = authenticationManager.authenticate(authentication);

			if (debug) {
				logger.debug("Authentication success: " + authResult);
			}

			eventPublisher.publishAuthenticationSuccess(authResult);
			SecurityContextHolder.getContext().setAuthentication(authResult);

		}

	}

	private boolean isAuthenticated() {
		Authentication authentication = SecurityContextHolder.getContext().getAuthentication();
		if (authentication == null || authentication instanceof AnonymousAuthenticationToken) {
			return false;
		}
		return true;
	}
	private static final class NullEventPublisher implements AuthenticationEventPublisher {
		public void publishAuthenticationFailure(AuthenticationException exception, Authentication authentication) {
		}

		public void publishAuthenticationSuccess(Authentication authentication) {
		}
	}

	protected static  class CantizAuthenticator extends OAuth2AuthenticationManager  {

		private static Log logger = LogFactory.getLog(CantizAuthenticator.class);

		@Override
		public Authentication authenticate(Authentication authentication) throws AuthenticationException {
			try {
				return super.authenticate(authentication);
			}
			catch (Exception e) {
				e.printStackTrace();
			}
			return authentication;
		}}

}
```While processing Iam getting a null pointer as my authentication manager 's dependencies are not injected.Please help

I am also trying to do the same custom filter, are there any solutions for this ?


Add support for multi-post messages

Fixes #11
Summary
Adds the ability to split events over multiple Slack messages to skirt around Slack's message size restrictions.

Each message can have a maximum text length of 3000 characters. This is 3/4 of Slack's recommended max of 4k. I wanted to play it safe, but am open to tweaking this. This should keep us well below the block count limit also.
If a new event is added after initial posts are made for the week that cause there to be a need for additional messages (called "spillover" in the code/comments), then for each Slack channel that doesn't have posts yet for the following week a new message is created. The events will still be sorted in their usual order and spread across the n+1 messages.

If a Slack channel DOES have messages for the following week posted already and this scenario is hit, then an error will be logged. The new event will not be posted to Slack. This is because there isn't a way to add messages before existing ones. Maybe in the future we can send out separate messages for any of these stragglers to let viewers know about them.

https://github.com/hackgvl/slack-events-bot/assets/44626690/0792c026-d33d-416c-952e-17f02486505f
Testing

Step
Instructions
Expected Results

1
Download the following test data files: part_1.json part_2.json1
Test data files are downloaded to your project root.

2
Change https://events.openupstate.org/api/gtc on this line of code to the following: http://localhost:5544/events
The URL for where to grab events from is updated.

3
Start json-server with the contents of part_1.json as the data source: npx json-server --port 5544 --watch part_1.json
json-server is running. Navigating to  http://localhost:5544/events should show all of the events from the JSON file.

4
Load up your local instance of the Slack bot
You should see two messages appear in your subscribed channel(s). See the video attachment above for a sampling of roughly what you should see.

5
Shut down json-server. Reload it with part_2.json this time. Restart your Slack bot.
You should see the second message having been updated, and a third one added, in your channel from before.

6
Change some of the value in part_2.json for events that are set to take place this week. Restart the Slack bot
Your changes should take effect the messages that had been previously posted.

7
Delete (rm slack-events-bot.db) or move (mv slack-events-bot.db something-different.db) your sqlite DB.
The DB is reset.

8
Repeat steps 3 and 4
Two new messages, with the same contents as before, have been posted into your Slack channel.

9
Add a message to your messages table with a week value that's the datetime of the next week.2
You should have a new message in your messages table for the next week.

10
Repeat step 5
You should see an error reported to STDERR.

1 curl commands for convenience:
curl -L https://raw.githubusercontent.com/ThorntonMatthewD/slack-events-bot/chunk-messages-test-samples/tests/data/part_1.json -o part_1.json

curl -L https://raw.githubusercontent.com/ThorntonMatthewD/slack-events-bot/chunk-messages-test-samples/tests/data/part_2.json -o part_2.json

2 Query for adding a new message for next week (at the time of posting this):
INSERT INTO messages (
  week, message, message_timestamp, channel_id, sequence_position
) VALUES (
  '2023-10-29 00:00:00+00:00',
  'I am here to be an impediment',
  '1698591600.954199',
  1,
  1
 )

Deployment Considerations
A new column has been added to the messages table. The following query will need to be executed.
ALTER TABLE messages ADD sequence_position INTEGER DEFAULT 0 NOT NULL;

This looks great, but we'll need to hold off on merging this until we can reinitialize the db on Jim's instance for a proper deploy

Thank you so much! :smile:

If you want to drop some commands to run on the production app, then I can run them whenever.

@allella Thank you!
Does the VM already have sqlite3 installed?
If not, and if it's running a Debian-based OS, then sudo apt instal sqlite3 should take care of that.
Opening the SQLite console:
sqlite3 path/to/slack-events-bot.db

Queries to execute
-- Add the new sequence_position column to the messages table.
ALTER TABLE messages ADD sequence_position INTEGER DEFAULT 0 NOT NULL;

-- Backfill sequence_position values for messages created prior to this release.
UPDATE messages SET sequence_position = 0 WHERE sequence_position IS NULL;

After those queries are run then these set of changes should be good to deploy! I think watchtower should pick up on them automatically once they are merged.

Yes, we have SQLite3 installed.
It sounds like Olivia said we'd do this in person at the HG Labs event, but I'll double-check in the Slack.

If this works with you all, I think next week may be an opportune time to deploy this piece. Something that may occur whenever these changes are shipped is that any weeks still in range could have their events posts "chunked", which could cause things to become slightly out of order (a post 2 of 2 being newly placed at the end of the channel). Since next week should be light on events due to Thanksgiving it should make it less jarring.

I can run the SQLite commands now, or early tomorrow, if that's the pre-requisite for the merge and deployment of the image.

@allella Thank you! That would be wonderful. Adding the new column will not affect the bot as it stands currently, and we could then merge in these changes maybe Sunday morning? I think if it were merged prior then the second half of the events for the week of the 12th would be reposted.

@ThorntonMatthewD I've run the two SQL commands above.

@allella Thank you! I will proceed with the merge. 🙌


Fix #153: Fixing sql snippets that failed on a DB with case-sensitive collation.

Fix #153 : Fixed snippets that failed on SQL Server databases that are configured to use a case-sensitive collation.
Also added a .gitignore for the .vs/ folder.

@stebet thanks for submitting this. Could you push an extra commit for this? I have enabled our LCA webhook which decides if you need to sign a Contributor License Agreement (CLA) for this PR or not.
@erickangMSFT this looks like a nice catch - we should take this and also apply it to the https://github.com/Microsoft/vscode-mssql/blob/master/snippets/mssql.json file so it's fixed in the VSCode extension too. I can take that on.

Sure, I'll l go over again and fix the typos.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: stebet sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


Fix typos

As in https://github.com/open-contracting/ocds-shareholders-extension/pull/3, not sure how the references here got mis-cased?

Ping for 1.1.1 release, @duncandewhurst


web: fix a non-portable svg

Hello @nicks,
Please review the following commits I made in branch nicks/filter:
0ab9b62d09888acfe3219dcee4952e8f5b529a95 (2019-11-04 22:30:42 -0500)
web: fix a non-portable svg

this svg includes a link to an internal filter with the id "a", which was breaking when it was embedded in a larger page


[WIP] Port to .NET Core 2.0

Submitting this as a Work in Progress just so you know I'm working on it - ported AggregateSource/Core and AggregateSource/Testing to .NET Core 2.0.  SampleSource, Recipes, EventStore, and NEventStore haven't been ported so this would break those builds.  Also need to make the command line build use .NET Core tooling.  This PR is pointing to master, but maybe could work on a netcore branch and split up into smaller PRs to that branch.

Closing temporarily, will submit a new one asap


feat(IRC): add WebsocketKit support

Hi there! Hope all is well 😄 I bring goodies!
I wanted to use this to deploy a small app to Docker. Unfortunately, I came across the same issue you had reported in FoundationNetworking: https://github.com/swiftlang/swift-corelibs-foundation/issues/4730 (it was kind of amusing realizing both of us arrived at it lol). I even went ahead and compiled libcurl from source to enable the websocket support, but it turns out that it still produces errors...
So I went ahead and did the next best thing: add support for using WebsocketKit instead of URLSession (I think this may've already been in your plans, since it was a dependency).
I did it in such a way that switching between the two just involves changing a generic parameter, which I thought was neat. I also added the implementation in a different module so it's totally optional.
Some caveats is that I had to change some internal interfaces, and expose some. Let me know if you can come up with something else!
Finally, I have tested it in a simple client application, but I wouldn't say it is battle tested at all, so there's that. Although it's better than nothing, maybe?
Anyways, let me know if this makes sense to you to merge, or about any issues/comments you have about the implementation itself.
Cheers!

Ah, seems like they fixed https://github.com/swiftlang/swift-corelibs-foundation/issues/4730 so building libcurl from source may be a solution now. Although I'm not sure when the fix will actually ship ¯_(ツ)_/¯

Hey, sorry for the late response, very busy with university so far sadly.
You guessed correctly, WebSocketKit für Linux has definitely been a goal and the overall idea of your implementation looks good to me on first glance, it should definitely be an option for platforms where URLSession doesn't work, while the default still stays URLSession.
I'll take a closer look at the implementation this evening or tomorrow and get back to you again.

Ah, seems like they fixed swiftlang/swift-corelibs-foundation#4730 so building libcurl from source may be a solution now. Although I'm not sure when the fix will actually ship ¯_(ツ)_/¯

Even when the fix ships, building libcurl from source is imo not the ideal state, so I'd still like WebSocketKit to be an option.

Yeah, no worries, take as much as you need. If I need to use it I can point to my branch while this is in review 😄

Okay, so I've looked at all the changes now and in general the code looks pretty much good to go.
But I am not sure if extracting it to a separate target is a big benefit, I think it'd make more sense to just move all of the WebSocketTask/TaskProvider stuff into /Shared/WebSocket and conditionally include the WebSocketKit part in the build when running on Linux.
I'd like to use this implementation for EventSub as well, since that would have the same issues and just having a shared WebSocket implementation that can differentiate between the 2 platforms seems the simplest to me.
I do like that the separate target gives you the ability to use WebSocketKit on macOS/iOS/etc. as well, without carrying around the extra dependency if not needed and including it conditionally on Linux only would take that option away, but realistically I don't see a reason why you'd actually need it on Apple platforms.
The generics should definitely stay though, so you can switch to the URLSession version on Linux, if libcurl was compiled with WS support. The URLSession specific extension to TwitchIRCClient is really nice as well, the same thing for Linux, making WebSocketKit the 'default' there would make sense imo.


different behavior in windows for odo when KUBECONFIG is not set

[kind/bug]

What versions of software are you using?

Operating System: Windows 10
Output of odo version: odo v1-beta

How did you run odo exactly?
odo login
Actual behavior
 X not authorized
Expected behavior
Server URL [http://localhost:8443]: interactive mode should be triggered
Any logs, error output, etc?
One of the way to resolve this error is to set KUBECONFIG to   using ENV variable GUI window in windows

This also happens on Linux, but on linux it hangs, as it's probably "eating" the message due to other login related issues.
cc/ @kadel

"eating"  the message should be fixed in https://github.com/openshift/odo/pull/1652
@cdrage can you check if your PR is also going to resolve this issue?

Yeah, looks like a separate bug:
admin@DESKTOP-A3JTM25 C:\Users\admin>odo.exe login
Connecting to the OpenShift cluster

 X  not authorized

admin@DESKTOP-A3JTM25 C:\Users\admin>oc.exe login
Login failed (401 Unauthorized)
Verify you have provided correct credentials.
You must obtain an API token by visiting https://api.engint.openshift.com/oauth/token/request

My PR does not fix the issue on Windows, it is however the same on Linux:
github.com/openshift/odo  add-show-log-to-watch ✔                                                                                4d
▶ odo login
 ✗  not authorized

I'll investigate this!

I have gone ahead and fixed this in PR #1652
make bin && ./odo login
go build -ldflags="-w -X github.com/openshift/odo/pkg/odo/cli/version.GITCOMMIT=2044e562" cmd/odo/odo.go
Connecting to the OpenShift cluster

Login failed (401 Unauthorized)
Verify you have provided correct credentials.
You must obtain an API token by visiting https://api.engint.openshift.com/oauth/token/request

 ✗  not authorized

This was fixed by adding information from oc: https://github.com/openshift/origin/blob/master/pkg/oc/cli/login/login.go#L60

Hey @girishramnani did #1652 fix your issue? I can no longer replicate this.

sure, closing this issue


Ensure rdkafka logging feeds into pykafka loggers

Closing to cut down on issue noise. This is a listed task in #176


(Zendesk/12094) Update claims email copy

Amend email copy for "claim submitted" and "claim approved"

Yes, that’s correct. The existing copy was wrong but nobody noticed! 🤭
On Fri, 23 Oct 2020 at 12:34, Robert Lee-Cann<EMAIL_ADDRESS>wrote:

@leeky commented on this pull request.
In app/views/claim_mailer/approved.text.erb
https://github.com/DFE-Digital/claim-additional-payments-for-teaching/pull/1177#discussion_r510820865
:

@@ -2,14 +2,14 @@ Dear <%= @display_name %>,

Your claim <%= @claim_description %> has been approved.
-We will send you another email when we have processed your payment, which may take up to <%= claim_decision_deadline_in_weeks %>.
+You will receive your payment within <%= claim_decision_deadline_in_weeks %>. We will send you another email when we make your payment.
@jacksonj04 https://github.com/jacksonj04 The actual copy I was given
specifically states "6 weeks" and I substituted in
claim_decision_deadline_in_weeks because that was used in the current
live version of the copy, which may have been a mistake.
I'm assuming that the 'approved' email goes out at the point the decision
has been made, and therefore claimants will be paid within 6 weeks of
receipt of it?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/DFE-Digital/claim-additional-payments-for-teaching/pull/1177#discussion_r510820865,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEXESRWGBSLVOHZNFU6JPLSMFS3JANCNFSM4S4L3DTA
.

--
Nick Jackson
Developer
<EMAIL_ADDRESS>www.dxw.com :: 0345 2577520 :: @dxw :: creating better digital public
services


Python package build; License; Changelog; tox tests

Simplify installation and add meta data:

Set up python package build via pyproject.toml, setup.cfg and setup.py (for dev build) files --> install via pip install -e .
Add MIT license (can be changed for an alternative one if preferred)
Add bayesflow/version.py and CHANGELOG.rst for versioning

Tests:

Add tox.ini to run tests

To finalize:

What should be the minimum python version? Currently 3.8
What version? Currently 0.0.0 beta 1.

What could be done next:

Add bayesflow as package to pypi (and add auto deploy via GitHub Actions)
Run tests e.g. on GitHub Actions
Add quality checks, e.g. flake8, black
Some tests are failing

@stefanradev93 Here are some modifications to facilitate a simpler, standardized installation and testing, which appeared not available yet. Happy to discuss!

@yannikschaelte Hey Yannick, soon, the base branch will be completely overwritten by the Future branch, which will feature major qualitative and conceptual changes. Your suggestions are great and I will make sure they are part of the upcoming Future branch.

@yannikschaelte Hey Yannick, soon, the base branch will be completely overwritten by the Future branch, which will feature major qualitative and conceptual changes.

Great, looking forward to it!


Add pick mode

-Single image mode
-Multiple images mode
Right now it's only multiple images

Implemented single image mode