Extract a shared dependency for libgdx utility classes to reduce coupling

I just wanted to add this promise into the tracker, where you would extract some common functionality like the Collections and Reflection helpers geared towards mobile and put them in a separate reusable project by modules like libgdx-ai in order to reduce their complete dependency on libgdx.
http://www.reddit.com/r/gamedev/comments/2u8ytc/gdxai_150_released/co6b3hx

Frankly, that's one of my main problems with libGDX at the moment - it tries to be "everything in one", in result being barely extendable or modifiable without recompiling the whole artifact from the scratch and the core modules are coupled together so tightly it's impossible to fix even the simplest of bugs without either commiting a PR patch to trunk & waiting for a pull (which can take up to 1 year AFAIK) or rewriting the entire lib... the private/protected/public members are mixed, making extending a real PITA, while at the same time Gradle dependencies management combo'ed with Android APK compiler essentially prevents "overriding" single class files by requiring an artifact to be included as a whole, with no option to e.g. use the package/class name in your project to "disable" the core class and replace it with your own; javac compiler works OK, just providing duplicate files in JAR, allowing to delete them with post-compile hook.
The only working solution for me was to manually create a lib with updated files, and manually update it every time new major version comes out. Yugh.
What I'm virtually dreaming of is a set of interfaces or abstract base classes with implementations instead of current concrete classes, allowing easy decoupling of all the basic libGDX functionalities - math/vector, 3D OpenGL interface, audio, 2D interface, particle effects, data input helpers (JSON, XML etc).
Well, time to get back to reality.

I hear you, and we had some efforts to decouple things (e.g. move things out into "extensions", etc.). We also have interfaces in places where they make sense (where you say we don't, e.g. vectors, GL, batchers, etc.). I'd be very curious for a link to a library that you can fix without recompiling it.
End of the day it's a question of resources.

Frankly, I say there ain't interfaces because there ain't... While Vector is a interface, it can't be used for nothing, because everything depends on Vector3/Vector2 implementations, and there ain't an interface for them - making switching core classes to different implementation with conforming interface (e.g. with optimized operations) not possible. Similarly, while there is an interface for e.g. ShaderProvider, Shader & GL20, there's no interface for Matrix3/4, RenderContext, ModelBatch or Renderable, the last one being a class with public fields, essentially making an interface for it impossible without rewriting entire 3D code.
As to fixing lib without recompiling - it's extremely easy if the library has code points that allow easy class extension or code pluging-in; e.g. I was able to create a wicked fix for a wicked bug in Bullet just because a few versions before (2.72 AFAIR) EC created a couple of hooks (gContactAddedCallback, gContactProcessedCallback & gContactDestroyedCallback), allowing me to filter those contacts later on... it was essentially unfixable without manual recompilation in the versions prior to that (i.e. 2.0), because it didn't have all that hooks coded. Same applies to any other lib - if I can replace a fixed element by creating a subclass or reimplementation and plug it into existing lib code - everything's completely fine. If I can't - it's a strong signal that the lib's internals are too strongly coupled.
Still, I completety understand & empathize with the "resource" part.

It is over design to make everything abstract before there is a need for customization. It's as bad as premature optimization. @vaxquis You are hijacking this issue with your ranting walls of text.
Collections are useful outside of libgdx and could be separated nicely. The reflection utilities are for GWT, I'm not sure they can be easily separated.

Interfacing Matrix3/4 does not make a lot of sense. If you want to extend Matrix3/4 it's likely you want to override only a handful of methods with optimized/specialized versions and reuse the rest of the methods. In 99.9% of cases users of the lib will not ever want to touch any code in Matrix3/4. By interfacing it, the majority of users would pay a performance penalty (vcall) on something that is invoked at a very high frequency. I don't think that's a good trade-off at all. The same is true for Vector2/3.
If you see public members then you can assume that we have a reason for them existing. In 99% of cases the reason is Dalvik, which imposes a penalty of field access via (virtual) getters/setters. Using public fields in those places can be a sensible option if these fields get accessed a lot per frame, as is the case with Renderable and other struct-likes.
There's a case to be made for interfacing RenderContext and ModelBatch. As Nate said, preemptively interfacing is something we do not do. As with SpriteBatch, it becomes clear after a while what should be interfaced and what shouldn't based on usage patterns that we observe over time in our own code and the code of our users. Trying to anticipate this from the inception of an API like the 3D API is a tough cookie to crack, and you'll always have some unhappy people one way or the other.
We do employ the visitor pattern you cited in Bullet (along with other patterns) in a lot of places in libGDX, be it scene2d or box2d. There's places where it makes sense. And there's places where it doesn't make sense.
If you have concrete suggestions for decoupling oportunities i'm all ears. Just dropping the names of a few classes is not enough though. One has to analyse:

concrete usage scenarios (decoupling for the sake of decoupling is time wasted)
additional maintainance burden vs. #users that will benefit from it
impact on performance

My suggestion is the issue linked atop of the request, mostly about libgdx-ai depending on the whole library.
I believe we discussed this two years ago, I was not allowed to leverage the library on the apps our company is working on because of that overhead. I'd love to use your collections, OGL wrappers and such without bringing the rest of it.
I understand that resource allocation is the issue here, so maybe one step at a time, freeing libgdx-ai would be a good starting point :)

Putting the utils package into a separate project is totally feasible and a good idea imo. The GL wrappers will be a bit tougher. I'm afraid that we fragment the core so heavily (one project becomes 4-6 projects) that maintainance becomes a huge burden (build system, etc.)

I've mixed feelings about a utils package. Could be useful for bullet as well (I don't think there's another comparable jni wrapper). But that would mean separating (the native and gwt emulated) Matrix4 as well (and probably BufferUtils)... Not sure if that defeats the need for such utils package. Also, that might have an extra impact on maintenance. I wonder how broad the need is for such package and what the pros vs cons are (is it nice-to-have or a deal-breaker e.g.).
@vaxquis interfaces are not a requirement for an extendable api, but please don't hijack issues. Open a new issue if you want to report a new issue. If you need help on how to do (customize) something then use the forum or irc. If you just want to rant then go to pastebin.com or alike.

FWIW, I use libgdx collections in Kryo, KryoNet, JsonBeans. I only use 2-3
collections though, so just copy and paste them. Of course a copy paste
isn't interoperable with libgdx's classes, for that they need to be
separated as the OP proposes. Even then, that is only a requirement for
non-libgdx projects that want to use libgdx collections, which seems like
it is pretty niche.
On Tue, Feb 3, 2015 at 12:06 AM, Xoppa<EMAIL_ADDRESS>wrote:

I've mixed feelings about a utils package. Could be useful for bullet as
well (I don't think there's another comparable jni wrapper). But that would
mean separating (the native and gwt emulated) Matrix4 as well (and probably
BufferUtils)... Not sure if that defeats the need for such utils package.
Also, that might have an extra impact on maintenance. I wonder how broad
the need is for such package and what the pros vs cons are (is it
nice-to-have or a deal-breaker e.g.).
@vaxquis https://github.com/vaxquis interfaces are not a requirement
for an extendable api https://github.com/libgdx/libgdx/wiki/ModelBatch,
but please don't hijack issues. Open a new issue if you want to report a
new issue. If you need help
https://github.com/libgdx/libgdx/wiki/Getting-Help on how to do
(customize) something then use the forum or irc. If you just want to rant
then go to pastebin.com or alike.
—
Reply to this email directly or view it on GitHub
https://github.com/libgdx/libgdx/issues/2793#issuecomment-72558273.

actually, we use some libGDX collections in RoboVM, and i've seen a few
other projects using them as well outside of gaming.
On Feb 3, 2015 12:18 AM, "Nathan Sweet"<EMAIL_ADDRESS>wrote:

FWIW, I use libgdx collections in Kryo, KryoNet, JsonBeans. I only use 2-3
collections though, so just copy and paste them. Of course a copy paste
isn't interoperable with libgdx's classes, for that they need to be
separated as the OP proposes. Even then, that is only a requirement for
non-libgdx projects that want to use libgdx collections, which seems like
it is pretty niche.
On Tue, Feb 3, 2015 at 12:06 AM, Xoppa<EMAIL_ADDRESS>wrote:

I've mixed feelings about a utils package. Could be useful for bullet as
well (I don't think there's another comparable jni wrapper). But that
would
mean separating (the native and gwt emulated) Matrix4 as well (and
probably
BufferUtils)... Not sure if that defeats the need for such utils
package.
Also, that might have an extra impact on maintenance. I wonder how broad
the need is for such package and what the pros vs cons are (is it
nice-to-have or a deal-breaker e.g.).
@vaxquis https://github.com/vaxquis interfaces are not a requirement
for an extendable api https://github.com/libgdx/libgdx/wiki/ModelBatch,

but please don't hijack issues. Open a new issue if you want to report a
new issue. If you need help
https://github.com/libgdx/libgdx/wiki/Getting-Help on how to do
(customize) something then use the forum or irc. If you just want to
rant
then go to pastebin.com or alike.
—
Reply to this email directly or view it on GitHub
https://github.com/libgdx/libgdx/issues/2793#issuecomment-72558273.

—
Reply to this email directly or view it on GitHub
https://github.com/libgdx/libgdx/issues/2793#issuecomment-72559914.

On Tue, Feb 3, 2015 at 12:23 AM, Mario Zechner<EMAIL_ADDRESS>wrote:

actually, we use some libGDX collections in RoboVM, and i've seen a few
other projects using them as well outside of gaming.

Sorry, I muddied my point at the end. Outside of libgdx it's easy to
copy/pasta, only when you want a lib to work both with libgdx and without
libgdx (like gdx-ai) would copy paste not be reasonable.

Not sure, but I think that Ashley might benefit as well from putting the utils package into a separate project.
@siondream, is this correct? :)

As said in above issue, I would love for a Separate Util Library. However, I would view the implementation as one that just publishes it as a separate library, which shouldn't be hard to build and publish separately. Even if it was left inside libGDX, it would be nice to have the separate download for the util classes.

+1 I want to use gdx-ai with mini2Dx but they have conflicting libgdx versions and I have to update mini2Dx to use a matching version.

Ashley's core uses Libgdx collections and ReflectionPool. We depend on Libgdx rather than copying classes over.
It'd be awesome if we had a gdx-utils library containing just the utils package we could depend on. Like @davebaol said, that would benefit quite a few extensions, libraries and users.
@badlogic you seem to agree to that as well right?

LibGDX 2.0! HYPE :+1:

Hello!
You have a new message, please read http://dimsedutte.dk/within.php?i
<EMAIL_ADDRESS>

I think we can close this now. There was not much interest in this topic for the last five years and the issue is very generic. If someone has a specific suggestion what to extract in an own lib, we can discuss it in an own issue.


Yosys and OCU35 or other CMOS synthesis and placement/routed examples

Dear,
can onyone point me to synthesis generated for OCU35 or other CMOS technologies (e.g. OpenPDK45)
and required configuration (how-to) ?
Maybe there are also placement/routed examples available ?
Greetings,
Patrick Pelgrims

There is an example synthesis script for OSU035 here: https://github.com/YosysHQ/yosys/tree/master/examples/osu035


Unable to initialize main class when generating the source code with IDL file [14044]

root@LAPTOP-QR0CP0KH:~/dds/workspace_HelloWorld# ~/Fast-DDS/FastDDS-Gen/scripts/fastddsgen -python HelloWorld.idl
openjdk version "13.0.7" 2021-04-20
OpenJDK Runtime Environment (build 13.0.7+5-Ubuntu-0ubuntu120.04)
OpenJDK 64-Bit Server VM (build 13.0.7+5-Ubuntu-0ubuntu120.04, mixed mode)
Error: Unable to initialize main class com.eprosima.fastdds.fastddsgen
Caused by: java.lang.NoClassDefFoundError: com/eprosima/idl/parser/typecode/TypeCode

Hi @yeah635007,
I have just installed in a clean Ubuntu Focal docker Fast DDS-Gen and OpenJDK 13. I have followed the instructions in the documentation using the executable script gradlew. I have not been able to reproduce your issue. Which Fast DDS-Gen version are you using? Maybe you should clean your workspace, fetch the repository and rebuild Fast DDS-Gen.

Fast DDS-Gen version is v2.1.1. gradle version is 6.4. java version is 13.0.7. I try again, but get a same result.

Sorry, @yeah635007,
With the provided information I am unable to reproduce your issue. I leave you with the steps to reproduce what I have done. In case you want more support you will need to provide us with similar steps so we can reproduce the issue.
Here is the Dockerfile I have used:
FROM ubuntu:focal

ENV TZ=Europe/Madrid
RUN ln -snf /usr/share/zoneinfo/$TZ /etc/localtime && echo $TZ > /etc/timezone
RUN apt update && \
    apt install -y git gcc openjdk-13-jdk

WORKDIR /home
RUN git clone --branch v2.1.1 https://github.com/eProsima/Fast-DDS-Gen.git && \
    cd Fast-DDS-Gen && \
    ./gradlew assemble

As you can see it installs the required dependencies and builds Fast DDS-Gen v2.1.1.
Running this docker, I can generate the TypeSupport for the following HelloWorld.idl IDL without any issue:
struct HelloWorld
{
    char a;
};

The command run is:
./Fast-DDS-Gen/scripts/fastddsgen -python HelloWorld.idl

You can try and follow these steps and see if it works for you. In case your issue is still happening, let me know what are you doing differently so I can reproduce at my side. If your issue is solved, please, proceed and close the issue.

Not having received any feedback in the last few months I am going to proceed and close this issue. Please, feel free to reopen if the issue is still happening providing information about how to reproduce it.


Grid Filter Button CSS

Hello,
First of all, I appreciate your work on this library, it's quickly become my favorite go-to.
Is there a way to add additional classes to the grid's filter column button? The light color doesn't look so good on my theme. There's definitely other workarounds I can explore but wanted to check first.
If that's not possible, but seems valuable, and also not a priority, I could try and throw a PR together for it at some point, I imagine it'd be as simple as exposing a property through Grid, GridColumn, or GridColumnFilter?
Either way,
Thanks

@thatplatypus Thank you for using BlazorBootstrap. Can you share a sample screenshot of your theme and the filter button's color? This is only for our better understanding. Please mask any sensitive information in the screenshot.

@thatplatypus We are planning to release this enhancement in the next release.


Fix BitBucketLocal not respecting target branch parameter

:sparkles: What kind of change does this PR introduce? (Bug fix, feature, docs update...)
Bug Fix
:arrow_heading_down: What is the current behavior?
--targetBranch option does not work against locally hosted BitBucket repositories. PRs are pointed at default branch instead of specified branch.
:new: What is the new behavior (if this is a feature change)?
PRs to locally hosted BitBucket repositories point to the specified branch when --targetBranch is specified.
:boom: Does this PR introduce a breaking change?
No
:bug: Recommendations for testing
Pass --target-branch <branchname> to NuKeeper.
:memo: Links to relevant issues/docs
N/A
:thinking: Checklist before submitting

[X] All projects build
[X] Relevant documentation was updated

Looks like there's something wrong with the build? I didn't change any tested areas.

Still relevant

Looks good. Thanks!


Please update the home page interface to be compatible with mobile browsers

I hope that the UI interface of index will be updated next time, and it will be compatible with Android and IOS mobile phones. The interface is too ugly, please.

Hi, what's incompatible with mobile browsers in the UI?
Concrete suggestions are welcome (with no guarantee that they'll lead to any change), but "too ugly" isn't actionable.
I just took a screenshot in firefox and possible improvements I see are:

vertically centering the box
removing the whiteband at the bottom (where the URL bar is before it hides on firefox)

If you want a different design you can also completely customize it with the -t my_custom_template.html parameter.

working for me on mobile as well

So I try vertically centering the box and I actually like it less than the current version. I'm closing this issue, if you have more specific feedback feel free to chime in.


Occulus / HTC

Thank you so much for this incredible work- fantastic!
However, I just failed to implement your teleporting example into a oculus experience (instead of using SteamVR cameraRig). Any idea how to proceed? Thank you so much!

Hi, you're welcome!
Unfortunately, we won't be porting any of the example code to new VR APIs like OVR. The main reason the Toolkit exists is to help you bring Tilt Brush .fbx files into Unity. Those examples are meant as inspiration only.
However, the SteamVR API does work with all major headsets that I know of, including Oculus and Windows Mixed Reality; so at least you can try out the example and see how it works.

Ok, thank you very much for your help!
Looking forward working with the toolkit.
Best,
Diana

Am 20.04.2018 um 23:30 schrieb Paul Du Bois<EMAIL_ADDRESS>Hi, you're welcome!
Unfortunately, we won't be porting any of the example code to new VR APIs like OVR. The main reason the Toolkit exists is to help you bring Tilt Brush .fbx files into Unity. Those examples are meant as inspiration only.
However, the SteamVR API does work with all major headsets that I know of, including Oculus and Windows Mixed Reality; so at least you can try out the example and see how it works.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/googlevr/tilt-brush-toolkit/issues/20#issuecomment-383227988, or mute the thread https://github.com/notifications/unsubscribe-auth/Aatpu7sdWqnyDGa_V5y3LlsKW0zwiN_6ks5tqlN3gaJpZM4TC4Wl.


Breakpoint in vendor package crash the proxy

The proxy crash is a breakpoint is set in a Vendor package (Library folder). As Flow exclude those package by default in recent version, we can improve the situation by skipping the proxy mapping.

Fixed by 5420211f0ea1147b592cf09649a694ec1f47c47f


README.md

README.md

Originally posted by @Trade-Help in https://github.com/suren-atoyan/react-pwa/issues/12#issuecomment-1059464116

answered in PR


Add Live Chatbot

Issue Type:

[x] Feature Request

Describe the bug
Not a bug it's a feature, I want to add a live chatbot with chatwoot

A clear and concise description of what the bug is.

Screenshots
Something like this I added in gssoc website PR not merged so you can't see their

@arpit456jain @DEEPALI-SUK https://github.com/girlscript/gssoc-website-new/issues/70

@sampavaranasi  This PR is already tagged invalid... Don't worry


Fix the titles in PDF transcripts that are titled "Unilateral Visual Loss"

See associated Slack thread: https://wellcome.slack.com/archives/CBT40CMKQ/p1609936975153100
tl;dr: We have ~200 PDF transcripts from a project in 2009 that all have the same title "Unilateral Visual Loss". These titles are wrong – they should probably use the title of the film, which can be obtained from the associated METS file.
It should be possible to fix this programatically.
The associated Slack thread has a CSV with a list of all the affected PDFs.

We should probably roll files that have titles like "Microsoft Word - 0055-0000-3816-0000-0-0000-0000-.doc" into the mix.

We should probably roll files that have titles like "Microsoft Word - 0055-0000-3816-0000-0-0000-0000-.doc" into the mix.

Ah, this isn't completely trivial – we'd need to regenerate the METS files so the checksums were correct.
I've attached a CSV with the relevant data.
broken_pdf_data.txt

Ah, this isn't completely trivial – we'd need to regenerate the METS files so the checksums were correct.
I've attached a CSV with the relevant data.
broken_pdf_data.txt


User guide in HTML

Current user guide is PDF only. Lorna or Dave will provide copy and assets for an HTML version

@MalcolmShazell Any thoughts on this? The current user guide is a bit out of date, and pdf is not a very accessible format

Migrated to https://github.com/epimorphics/hmlr-linked-data/issues/40


Move qwik packages qwik-themes to devDependencies error after install

Hey everyone,
after starting a new qwik app (blank project v1 and v2)
I run "npm install qwik-themes" when I try to load the dev server I get the below error
failed to load config from {location of stuff on my computer} \qwik-app\vite.config.ts
11:26:51 [vite] Move qwik packages qwik-themes to devDependencies
11:26:51 [vite] server restart failed
package.json file file after install
  "dependencies": {
    "qwik-themes": "^0.3.0"
  }

solution in root package.json move from "dependencies" to "devDependencies"
  "devDependencies": {
    "qwik-themes": "^0.3.0",
{... default packages}
  }

System info below
System:
OS: Windows 11 10.0.22631
CPU: (8) x64 Intel(R) Core(TM) i5-1035G1 CPU @ 1.00GHz
Memory: 522.20 MB / 7.74 GB
Binaries:
Node: 22.11.0 - C:\Program Files\nodejs\node.EXE
Yarn: 1.22.21 - ~\AppData\Roaming\npm\yarn.CMD
npm: 10.9.0 - C:\Program Files\nodejs\npm.CMD
pnpm: 9.14.2 - ~\AppData\Roaming\npm\pnpm.CMD
Browsers:
Edge: Chromium (127.0.2651.74)
Internet Explorer: 11.0.22621.3527
npmPackages:
@builder.io/qwik: ^1.11.0 => 1.11.0
@builder.io/qwik-city: ^1.11.0 => 1.11.0
typescript: 5.4.5 => 5.4.5
undici: * => 7.1.0
vite: 5.3.5 => 5.3.5

Also the live example in the readme goes to a 404 page.
https://github.com/Makisuo/qwik-themes/blob/main/TODO


Why JedisSentinelPool is not support separation of reading and writing?

Why JedisSentinelPool is not support separation of reading and writing?just like read from Slaves/Master ,write to Master.
In some systems with more reads and fewer writes, using only the master node for read and writ will cause the master node to be busy and the slave node to be too idle.

@violetgo sounds like a nice idea, would you consider submitting a PR?

Closed due to inactivity.


Updates

A11y: announce app list refreshing state
Update Gradle Wrapper, dependencies and verification metadata

There could be more minor accessibility improvements but I will try to add them if they are ready and tested.

Thank you!


Allow disabling the VPN session disabling through OIDC

Fixes #724
Fixes #721
cc @princemaple

Adding this here for reference: https://wjw465150.gitbooks.io/keycloak-documentation/content/server_admin/topics/sessions/offline.html


slskd wants to generate acme certs despite nginx being disabled

Describe the bug
A clear and concise description of what the bug is.
Steps To Reproduce
Steps to reproduce the behavior:

Enable slskd
set nginx.enabled=false;
rebuild

Expected behavior
Hosting the web ui on standard port without nginx as a webserver
Screenshots

Additional context
Notify maintainers
@ppom0

Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 6.1.77, NixOS, 24.05 (Uakari), 24.05.20240215.a4d4fe8`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.18.1`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

Add a :+1: reaction to issues you find important.

This is also my first time working with slskd, so I'm not entirely sure if I'm missing something here

The behavior of the module will be changed (and will fix your problem) in #281075.
Meanwhile, can you try disabling nginx with services.nginx.enable = lib.mkForce false;?
Currently there is an issue in the module, which always enables nginx. So you must override its behavior with lib.mkForce.


Vacuum chest causing lags

Issue Description:
Vacuum chest causing lags
Screens
https://i.ibb.co/y5Qcwr7/javaw-2019-09-18-18-36-31-842.jpg
https://i.ibb.co/4JxFRNs/javaw-2019-09-15-19-37-42-610.jpg
What you expected to happen:
No errors
Steps to reproduce:
Unknown. :(
Affected Versions:
EnderIO - EnderIO-1.12.2-5.1.51
EnderCore - EnderCore-1.12.2-0.5.69.jar
Minecraft - 1.12.2
Forge - forge-1.12.2-<IP_ADDRESS>47-universal.jar
SpongeForge? - spongeforge-1.12.2-2838-7.1.7-RC3924.jar
Optifine? - no
Single Player and/or Server? - server

Try using the vanilla profiler
Vanilla's profiler is ran using /debug start, waiting a few minutes (while somewhere where the game is lagging), and then /debug stop.  It creates a text file in a debug folder in the pack instance folder.


Pull, push, build and create interruption

The Docker engine allows the client to cancel these requests by dropping the connection. (see https://docs.docker.com/engine/api/v1.25/)
This PR is a rebased version of https://github.com/spotify/docker-client/pull/703

Codecov Report

Merging #929 into master will increase coverage by 0.4%.
The diff coverage is 90%.

@@            Coverage Diff             @@
##             master    #929     +/-   ##
==========================================
+ Coverage     66.89%   67.3%   +0.4%
- Complexity      757     760      +3
==========================================
  Files           170     170
  Lines          3157    3184     +27
  Branches        370     370
==========================================
+ Hits           2112    2143     +31
+ Misses          890     887      -3
+ Partials        155     154      -1

Anything I can do to help get this merged?

@mk Thanks for your offer and sorry this has been so delayed. You can help me test that it works as expected and also review the code.

cc @CGNonofr

@davidxia cool, thanks. I won't have time the next few days but my colleague @bharendt will take a look and make sure it works. Thanks a lot for your work on this library btw!

I tested interruption of pull and push operations and it works great. When interrupted, they both throw an InterruptedException and the operation stop as expected, so this is good to merge from our side. Thanks a lot!


spec #include_gon how it escapes a string

current master is broken. commit c32ed890bdcf1e630125995038488055b446c250 "Added helper from rails 3-2-stable for escaping javascript" escapes at least strings too much and breaks functionality. I added a test to spec the broken behavior.

Thanks for your investigation! Helper was added only for a while, as fast fix from airport - today-tomorrow i'll rewrite it for properly working with strings

You're welcome and thanks for this great project btw!


Add documentation for the cli_city field on the LempCd database model

Your mission
Add documentation for the cli_city field on the LempCd database model.
Here's how
Step 1: Claim this ticket by leaving a comment below. Tell everyone you're ON IT!
Step 2: Open up the file that contains this model. It should be in calaccess_raw.models.lobbying.py.
Step 3: Hit the little pencil button in the upper-right corner of the code box to begin editing the file.

Step 4: Find this model and field in the file. (Clicking into the box and searching with CTRL-F can help you here.) Once you find it, we expect the field to lack the help_text field typically used in Django to explain what a field contains.
effect_dt = fields.DateField(
    null=True,
    db_column="EFFECT_DT"
)

Step 5: In a separate tab, open up the official state documentation and find the page that defines all the fields in this model.

Step 6: Find the row in that table's definition table that spells out what this field contains. If it lacks documentation. Note that in the ticket and close it now.

Step 7: Return to the GitHub tab.
Step 8: Add the state's label explaining what's in the field, to our field definition by inserting it a help_text argument. That should look something like this:
effect_dt = fields.DateField(
    null=True,
    db_column="EFFECT_DT",
    # Add a help_text argument like the one here, but put your string in instead.
    help_text="The other values in record were effective as of this date"
)

Step 9: Scroll down below the code box and describe the change you've made in the commit message. Press the button below.

Step 10:  Review your changes and create a pull request submitting them to the core team for inclusion.

That's it! Mission accomplished!

I got that


Fix extend paths in router and store

Allows the plugin to work with newer versions of vue-cli past 2a195f0 (beta 11).
Edit: I'm not sure if you want to change how the router and store are implemented entirely, as since the linked change, the store and router have been optional in newly-generated projects.

As linking doesn't appear to work properly, to use the fork:

Clone the repo (git clone https://github.com/md678685/vue-cli-plugin-nativescript-vue)
Generate a new project with vue ui or vue create
cd <project>
Run either yarn add -D <path to cloned repo>  or npm i -D <path to cloned repo>
Run vue invoke nativescript-vue


New tags

@mutoe could you add this tags: composition-api and realworld to repository description, please?

Thanks for your remainder, added.

Thanks for your remainder, added.


Landscape review

TODO

[x] Navigation :fire:
[x] Categorization :fire:
[ ] ~Home page~ :fire:
[ ] Form patterns? - like error handling / validation / use of tooltips etc.? check in with @SmartMouthWords as well :fire:

Outcomes

Deep dive into a particular design system element meant to inform the hands-on work on that specific element (a category, a page, a component).
This is meant to inform the hands-on work of designers and developers on specific design system elements.

Deliverables

Deep dives/expert review documents focused on specific parts of the design system and how they are treated in other design systems.

Estimated Effort

[ ] XS: 1 to 2 hours
[ ] S: half a day
[ ] M: 1-2 day
[ ] L: 1 week
[ ] XL: Move to an epic

Out of scope

This is not a general overview of design systems.
This is not user research, but an expert overview.

Navigation exploration complete, documentation and decisions will be updated here by end of the week :)
Form patterns to be continued into the next sprint :)


delay to open camera on android

The camera is delaying to open and to take the photo on android devices. In ios, it's working great.
Take a look in the screen recorded below.
Steps to reproduce

Clone the repo: https://github.com/ronaldozanoni/react-native-camera-test-android
Click on "New" on header
Check the 1 second delay to open

Environment

** react-native-cli: 2.0.1
Node.js version: 7.0.0
React Native version: 0.42.3

Tested on Motorola Moto X 1, Android 5.1
Am I doing anything wrong?
Thanks.
Ronaldo Zanoni

Similar with my Android 4.4 device.

Delay in opening camera for me as well

Delay in opening camera for me as well, i want to have a solution

When i click to navigate camera it makes appx. 500 ms delay !

Hi,guys,I have found this issue before and modified the android native code to solve it by adding a prop called "onRecordVideoStarted" ,so that we can know when does the camera is ready for work. I make a PR but the author haven't merge it yet. see it here : #703  :)

This issue is closed because of inactivity.
Furthermore RCTCamera is deprecated now, use RNCamera instead. If this issue is also related to RNCamera, please open a new one.


ENH: pipeline function to make a topography periodic by mirroring

this branch fails because of problems with empty subdomains in muFFT.
test_sphere with a communicator of length 4 is failing.
https://github.com/ComputationalMechanics/SurfaceTopography/pull/52/checks?check_run_id=1577117646
a fix is planned inside muFFT, correct @pastewka  ?

this branch fails because of problems with empty subdomains in muFFT.
test_sphere with a communicator of length 4 is failing.
https://github.com/ComputationalMechanics/SurfaceTopography/pull/52/checks?check_run_id=1577117646
a fix is planned inside muFFT, correct @pastewka  ?

Let's see if this passes. Do you want to update the requirements to muFFT 0.13.0?

Actually besides of some number of MPI processes, the code is still compatible with the earlier muFFT. Only the test needs the newer  muFFT.
So it depends what the philosphy behind "requirements" is.


Check for Cordova Support

Check cordova (already did a mini-test, works fine) and document support and add tests

Done.


Custom size CameraView is distorted

When I create custom size CameraView, I expect that CameraView will be masked by size properties.
<App>
	<Panel>
		<NativeViewHost>
			<CameraView ux:Name="cameraView" Facing="Back" Height="200"/>
		</NativeViewHost>
	</Panel>
</App>

but it is distorted like below photos.
(100% x 100%)

(100% * 400px)

are you sure this is the right repository? 🤔

Oh, my. Sorry :( It isn't


Base image for container packaged lambda functions?

Will there be a container base image that we can use instead of public.ecr.aws/lambda/nodejs:20 ?

We'll add a Lambda OCI (Container) example as well :)

Thanks!  I was playing around with copying bootstrap into the al2023 provided image, but got lost adding node_modules.

@JonHolman it would be helpful if you could give a bit of context of what are you trying to do? Why are you looking to package LLRT in a container?

@richarddavison sure.  I think having a container option would assist in making LLRT available for more use cases.  In what I am trying to do right now and would like to evaluate if LLRT is an option and would improve performance.  I'm trying to run llama.cpp with a small LLM within a lambda function.  My simple WIP can be seen at https://github.com/JonHolman/wip-sam-node-llama-cpp

@JonHolman when we release a new version, you should be able to deploy a container optimized version of LLRT. This should have significantly lower cold starts compared with adding the once that exists today.

Released in https://github.com/awslabs/llrt/releases/tag/v0.1.11-beta


demo resize issue

The emulator demo doesnt seem to propagate resize back to the pty which leads to weird behavior when you input something lengthy (pty sends '\r' and you just overwrite the current line). It also prevents commands like top from using the whole container.

Thanks for reporting. This will need some work to be implemented. Right now the websocket stream exchanges raw bytes with the back-end pty.
We will either have to change the way the stream works in order to include control commands like resize or create an HTTP endpoint for this particular reason. The latter needs more work to be done (including identifying the current pty), but IMO is the best solution.

We could also follow the approach of takluyver/terminado, which exchanges messages with specific commands. Also, features a Terminal creation API and I think is based on Term.js.
Alternatively, we could check if they're interested in switching to Xterm.js and then use that as a more complete demo.

Hmm no clue which path to take here, IMO the problem can be reduced to the question if the websocket is solely used as a transport layer for the pty pipe or if it can transport any emulator related data. The latter would require to introduce some structured data layer over the websocket while the first would need to establish a side communication with the backend (and some type of emulator lock until the side comminucation got processed).

I think we should stick with the websocket serving as a transport layer only as well. This way we are able to test the attach addon also, through the demo and it will keep the transmission throughput to the maximum with the current means.

Btw, @jerch given that Xterm.js supports add-ons, we could create this implementation as a separate add-on which users could use. This way, we can keep the core functionality of the project here which should cover most of the use cases.
Creating such as add-on with the attach add-on as a reference should not be that hard.

Although all downvoted the websocket protocol idea (including myself), here is a quick hack with it (was just easier to implement partly hardcoded :wink:). The impact on the throughput is to my own surprise neglectable.


[Feature] Emotion support

Options

[ ] Related to an issue: (Mention the issue)
[ ] Breaking change(s).
[X] Related to a cog. CleverBot

Contents
async_cleverbot is supporting emotionnal answers (Answering happy, with anger, sadly, etc...). Actually answering as a neutral person.

Archiving repo.


Explain how to report issue with your profile

Versions of Ruby, Terraforming and Terraform are required to investigate problems.

Coverage remained the same at 100.0% when pulling a22bf7f9c444efff7a19eaa8343627dc586eb05b on explain-version into ede94eb47649387c96b2cbbdce4183cd8675ae3d on master.

Coverage remained the same at 100.0% when pulling ef1e9257ee6ca9b6c877bdb40abbed0c650d8e0e on explain-version into ede94eb47649387c96b2cbbdce4183cd8675ae3d on master.


[DOCS] Development community showcase page

Reference Issues/PRs
Fixes #1313

What does this implement/fix? Explain your changes.

This PR adds a community showcase page for blog posts
Does your contribution introduce a new dependency? If yes, which one?
No

What should a reviewer concentrate their feedback on?

Any other comments?

PR checklist

For all contributions

[ ] I've added myself to the list of contributors.
[ ] Optionally, I've updated sktime's CODEOWNERS to receive notifications about future changes to these files.
[x] I've added unit tests and made sure they pass locally.

For new estimators

[ ] I've added the estimator to the online documentation.
[ ] I've updated the existing example notebooks or provided a new one to showcase how my estimator works.

@afzal442 it looks like the links might not be rendering in the table. I think the one linking the name and github link is missing the trailing underscore.
Note sure what is up with the other one.

something issues with sphinx-build error with md files.

hi @RNKuhns, could you help me out why this got failed? Or any other suggestions if you have. https://sktime--1337.org.readthedocs.build/en/1337/about/showcase.html

Alternatively we could use panels instead of a table, that would allow to add images too.

Sounds good. will look into it.

@mloning https://sktime--1337.org.readthedocs.build/en/1337/about/showcase.html

Now merged @afzal442 🎉


Transition region between stratified/unstratified regimes

The current implementation has a on/off transition between using the "adaptive" or "smoothing" behaviour, depending on the coordinate slope. A proposed alternative is to widen this transition region, using i.e. a tanh profile. This would add another parameter, defining the (half-) width of the profile.

Any luck on this one?

Further to this, it turned out that the idea of the tanh(slope) function failed. The reason is that the vertical temperature gradient transitions so suddenly from weak to strong at the mixed layer base. See image below, which pulls apart the vertical density gradient, horizontal gradient and estimated slope:

Our conjecture is that it is this sudden transition that causes problems in the transition from pressure adaptivity to density adaptivity. We need to smooth it out. Will a vertical filter on the slope estimate be sufficient?

Will a vertical filter on the slope estimate be sufficient?

This is the next thing to try, but it will be a little bit of implementation effort. The current structure of the code works with k as the outer loop, but to do the vertical filter it'll have to become the inner loop, or add another loop after keeping the entire slope field.

Will a vertical filter on the slope estimate be sufficient?

This is the next thing to try, but it will be a little bit of implementation effort. The current structure of the code works with k as the outer loop, but to do the vertical filter it'll have to become the inner loop, or add another loop after keeping the entire slope field.

Would it be easier to implement a limit on the vertical gradient of calculated slope? Or is the slope calculation discarded as soon as it's done.
If not, perhaps an additional loop would be OK for testing purposes -- it would be simpler to code, and if the test fails we might be back to square 1 anyways!

PS. I had another thought here. Could we do a horizontal smoothing? I was leaning away from this purely because I was worried about tiling, but with current halos I think we can do a 7-point smoothing easily enough, which may be sufficient to make a difference?

I've made a first attempt at this implementation in the adaptive-coordinate-horizontal-filter branch. I'll build this on Gadi now.

Nice. Quick feedback - I ran my default case (no sensitivity on S_crit yet) and it looks a lot better. Here is the original without weight smoothing:

and here is the updated version:

Maybe I'll play around a little more, but this does look to have made a big difference!

I've done a few more tests with the horizontally filtered version of the code.  There are a few plots here:
https://github.com/AndyHoggANU/anu-tub/blob/master/diagnostics/AG_Diagnostic_Smoothed.ipynb
The general summary:

This 3-point smoother is surprisingly efficient at eliminating noise in the transition between stratified and unstratified regions.
With this filter in play and no minimum smoothing, the only parameter to play with in the scheme is the cut-off slope, S_crit.
When the cutoff slope is large, you get more quasi-isopycnal coordinates, at the expense of more noisy behaviour.
When the cutoff slope is small you get more regions of geopotential coordinates but a nicer-looking field overall.
The optimal value seems to be a slope cutoff of 0.002 (noting that this might actually be the square of the slope, or perhaps it is squared afterwards??)
For this value of cutoff slope, over large parts of the interior of the ocean, the AG coordinate is quasi-isopycnal.

I think I'm going to close this issue now, noting that the next text is to do a long run with this coordinate.


Fail notification

Is there any way how to setup Azure DevOps to send out notification when service hook fails?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4806b641-fdb1-c0e9-081c-c007807c7cdb
Version Independent ID: f59d8501-1285-be79-b084-8371ed8395bb
Content: WebHooks with Azure DevOps Services
Content Source: docs/service-hooks/services/webhooks.md
Product: devops
Technology: devops-collab
GitHub Login: @chasewilson
Microsoft Alias: phwilson

@JanSera  Thank you for the question.
You will probably need to use the REST API task with a call to the service hook diagnostics endpoint, then send the notification if any status errors are detected.
For an overview of status errors, see Troubleshooting.

I am closing this issue now.  You are welcome to @ mention me for any followup.
We hope to hear from you again.


[feature request] adding {percent_precise} style key

The existing {percent} is rendered as an integer, which means it is not very useful for large data sets, as it rarely changes.
I suggest adding a new {percent_precise} (a non-breaking change?) that would render it with additional precision. For example 3 fraction digits, as demonstrated by the test added here.
An earlier proposal to add precision to variables was rejected (#552), and AFAIK, there is no way to customize this without taking over rendering. I think this proposal would work well with existing variables like elapsed_precise, eta_precise.
Thanks for considering!

Seems okay. @chris-laplante what do you think?
(Note that this can be done using a custom ProgressTracker implementation.)

I think it's a common enough use case that we shouldn't force people to use ProgressTracker. So +1 from me.

Thank you!

@djc @chris-laplante
Thanks for looking into this! I wonder when do new released get pushed to crates.io?

More or less by request: https://github.com/console-rs/indicatif/pull/629.

@djc looks like the deployment failed (job) 😞
Looks like one test (style::tests::wide_element_style) randomly failed. Not sure why, although it succeeded in other jobs in the matrix, and with the same toolchain on the previous commit. I don't have permissions to rerun the job, but please let me know if I can debug/help with anything otherwise to unblock publishing.

@djc looks like the deployment failed (job) 😞 One test (style::tests::wide_element_style) randomly failed. Not sure why, although it succeeded in other jobs in the matrix, and with the same toolchain on the previous commit. I don't have permissions to rerun the job, but please let me know if I can debug/help with anything otherwise to unblock publishing.

It is unrelated to your changes - it failed a few days ago as well: https://github.com/console-rs/indicatif/issues/631


Performance with 150+ fields, 2000 line json config.

I'm currently working on a solution for an Angular 15 application that has many large forms (100+ fields in some cases, maybe more) and am looking at formly as a solution. I've noticed that rendering these large pages takes about 5 seconds or more, which violates my requirements.
I'm wondering if I'm using the wrong tool and trying to fit a square peg through a round hole, or if there's something I'm doing wrong on my end. If needed I can try to put together a demo on stack blitz.
Is the performance I'm seeing expected for forms of this size?

As a developer who has used formly for many large forms I can confirm it
can be used for them. Here are a few thoughts on this subject.
Have you been able to make sure it is the format rendering engine that is
causing a slow down and not the browser draw? Do you have any example or
something you can share that specifies the perf issue with formly?
From our usage of formly we have not found performance issues for
rendering. In general it was an odd usage of conditionals that caused many
recalls on the fields so it was our configurations not formly itself.
We also found performance problems with the css engine for chrome 2-3 years
ago when using flex box with a lot of fields.
There have already been solutions proposed in formly issues to have things
like virtual scroll
https://github.com/ngx-formly/ngx-formly/issues/3398#issuecomment-1197837488
This allows for forms to be large single configurations.
Last note here:
It might be a good idea to split your forms into sections to have better
load performance as well.
On Mon, Sep 11, 2023, 3:41 PM Alex Johnson @.***> wrote:

I'm currently working on a solution for an application that has many large
forms (100+ fields in some cases, maybe more) and am looking at formly as a
solution. I've noticed that rendering these large pages takes about 5
seconds or more, which violates my requirements.
I'm wondering if I'm using the wrong tool and trying to fit a square peg
through a round hole, or if there's something I'm doing wrong on my end. If
needed I can try to put together a demo on stack blitz.
Is the performance I'm seeing expected for forms of that size?
A clear and concise description of what the question is.
—
Reply to this email directly, view it on GitHub
https://github.com/ngx-formly/ngx-formly/issues/3779, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADB4XNOTCFMNWOKLKZB4G53XZ5ZN7ANCNFSM6AAAAAA4T4LPI4
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


[BUG] Artifact sets being incorrectly set

Several artifacts scanned in as the wrong set, seemed to be especially gladiators finale pieces turning into gambler's dice set. I was using windowed 1280x720, when I changed to windowed 1600x900 that seemed to solve the problem. If the new recommended setting is 1600x900 and I missed it then my bad. Thanks for the great program!

Have the same issue, tried 1280x800 (now that i think of it its wrong ratio 😅) and 1920x1080.  I now tried it with 1280x720 AA off and it still read it as gamblers.

Image filtering and post-processing will probably mess with the scanner. Please disable any before running a scan.

Tried scanning with anti-aliasing off, in 1280x800 window (the largest 16:9 ratio my 1680x1050 screen can do).

These pieces scanned as Gambler

Fixed in V1.3.0


npm 2.6 missing

update npm plz =)

@sergeevpasha thank you for pointing that out... turns out npm wrongly was showing success on publish even though nothing was being published. See here:
https://github.com/npm/registry/issues/333
I have now published the newer version (v2.6.1) to npm registry.


loadReferenceFile missing from Java API

Additionally, we should add loadTwoBit and loadContigMap functions to the Scala API. loadReferenceFile just loads these manually.

+1 to adding new loadTwoBit and loadContigMap functions.
I'm not sure JavaADAMContext.loadReferenceFile is necessary, as there aren't any options or default values in its method signature.


fix(script): CI is not failing when the script commit-filter-check.sh finishes with an error

Motivation
What
CI is not failing when the script commit-filter-check.sh finishes with an error
Why
The set -o errexit will not return 1 to CI.
How
Replace set -o errexit for ``
Verification Steps
Add the steps required to check this change. Following an example.

Go to XX >> YY >> SS
Create a new item N with the info X
Try to edit this item
Check if in the left menu the feature X is not so long present.

Checklist:

[ ] Code has been tested locally by PR requester
[ ] Changes have been successfully verified by another team member

Progress

[x] Finished task
[ ] TODO

Additional Notes
PS.: Add images and/or .gifs to illustrate what was changed if this pull request modifies the appearance/output of something presented to the users.

Coverage remained the same at 64.769% when pulling b96fb1e6cd8f582d02ee7f3953e105e0be93a79b on camilamacedo86:FIX_SCRIPT into aeebd9ce8fa0b3d218acbd504edc8ee2b0e08520 on aerogear:master.


"Please enter 1 or more characters" message overlapping the input box

Prerequisites

[x] I have searched for similar issues in both open and closed tickets and cannot find a duplicate
[x] The issue still exists against the latest master branch of Select2
I am able to replicate it on your examples page.
[x] This is not a usage question (Those should be directed to the [community]
(https://select2.github.io/community.html))
[x] I have attempted to find the simplest possible steps to reproduce the issue

Steps to reproduce the issue

Go to
Reduce your browser window width till the message "Please enter 1 or more characters" appears in two lines.
Scroll the page up to the extent that the select2-dropdown--above is opened.
Now try clicking select2 - you will see the select2-dropdown overlapping the input box.

Expected behavior and actual behavior
When I follow those steps, I see...
The select2 dropdown overlapping the input box of the component when the message "Please enter 1 or more characters" appears in two lines.
I was expecting...
The select2 dropdown to be placed above the input box and not overlap it.
Environment
Browsers

[x] Google Chrome
[x] Mozilla Firefox
[ ] Internet Explorer

Operating System

[ ] Windows
[x] Mac OS X
[ ] Linux
[ ] Mobile

Libraries

jQuery version:
Select2 version:

Isolating the problem

[x] This bug happens on the examples page
[x] The bug happens consistently across all tested browsers
[x] This bug happens when using Select2 without other plugins
[ ] I can reproduce this bug in a jsbin

Chrome Issue Capture
When message appears in two lines

Firefox Issue Capture
When message appears in two lines

Expected behaviour
When message appears in single line

Was this only happening on the old documentation site?  On the new documentation site, it seems to look OK:

No, this issue is replicable on the new website as well. Apart from this current issue, I found a new issue as well on the new website. When we search by entering any string and the ajax call is made, we then remove the string searched and the suggestion list placeholder jumps up. Please find attached gif for your reference

.

Ok.  The other issue you reference is actually an already known bug.  See #3905.


We only need one initialization component for now.

The reason it lives outside of core is the end state can either be:
1- uber plugin module that depends on core+everything else with one initialization component handling everything. (+ this is nice to see what's going on)
or
2- initialization component in each vertical module.
We definitely don't want it in core as core should not depend on anything upstream. (verticals or uber plugin)

I'm actually second-guessing myself here. I was really thinking that all the initialization would happen in the uber-plugin, but maybe it'll be more manageable for the application components of each module to handle their own business (including login and analytics setup in the core)...
You guys have thoughts on this?

just so I understand - would what you are second-guessing affect this PR? In other words, are you now thinking that maybe the account plugin should have its own initialization?

em. kinda yeah.  Let's say I'm on the fence. I guess I just thought I'd waste everybody's time.

maybe the account plugin should have its own initialization?
As far as I understand, we don't have account plugin, it's part of core? Do we talk here about account login component of core then and the separate initialization component for it?

yeah sorry each module will often have it's own plugin.xml so I have the
tendency to think of them as plugins.
On Thu, Feb 15, 2018 at 3:31 PM, Ivan Portyankin<EMAIL_ADDRESS>wrote:

maybe the account plugin should have its own initialization?
As far as I understand, we don't have account plugin, it's part of core?
Do we talk here about account login component of core then and the
separate initialization component for it?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/GoogleCloudPlatform/google-cloud-intellij/pull/1913#issuecomment-366052383,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHf5HV5VKyzhWo1OPqx9Pu0VdU0Tig1Wks5tVJQqgaJpZM4SHF7P
.


Wait for all initialization steps on all nodes to complete before proceeding with tests

When running tests using multiple nodes (to generate traffic), tasks are not really performed in parallel, since node is single threaded. The result is that some nodes may still be busy being set up (accounts created/unlocked) when others have started generating traffic. Try waiting for all set up steps to complete before starting to generate traffic...

The way multiple nodes are used has been changed from single-threaded (async.parallel) to multi-threaded (using node's cluster).


Update PR template

We currently have a PR template with checklist for the different tests.
Completing the tests can be checked by the reviewers To simplify for external contributor, we should describe the command to run.
Name:

Running smoke test command
Running make generate

One more after cloning the repo when I ran make install-testnet I get
fatal: No names found, cannot describe anything.
make: *** No rule to make target 'install-testnet'.  Stop.

So I ran make install and it installed the the zetacored and zetaclientd

We currently have a PR template with checklist for the different tests.
Completing the tests can be checked by the reviewers To simplify for external contributor, we should describe the command to run. Name:

Running smoke test command
Running make generate

Hey @lumtis,  I am fixing it along with my PR


emu2-gen A100 OOM

`pipe = DiffusionPipeline.from_pretrained(
path,
custom_pipeline="pipeline_emu2_gen",
torch_dtype=torch.bfloat16,
use_safetensors=True,
variant="bf16",
low_cpu_mem_usage=True
)
pipe.to("cuda")
print(pipe)
prompt = "impressionist painting of an astronaut in a jungle"
ret = pipe(prompt)
prompt = [image, "wearing a red hat on the head."]
ret = pipe(prompt)
`
OutOfMemoryError: CUDA out of memory. Tried to allocate 512.00 MiB
A100 80G Memorty is OOM
can be load in multi gpu ? or cpu offload

OOM issue
Could you please provide more information about your environment? We've test the huggingface version of Emu2-Gen on A800-80G GPU. In bfloat16 precision, it occupies 77GB of GPU memory and can run all the examples in README.md successfully.
Multi-GPU support

Since the EmuVisualGenerationPipeline inherited from diffusers.DiffusionPipeline, you can use any multi-gpu techniques supported by diffusers or accelerate.
Besides, we just uploaded the native PyTorch version of models and the corresponding inference codes, in which we provide a simple multi device strategy. You can try it out by following the instruction. Model weights are available at link.

cuda:
nvcc: NVIDIA (R) Cuda compiler driver
Copyright (c) 2005-2022 NVIDIA Corporation
Built on Wed_Sep_21_10:33:58_PDT_2022
Cuda compilation tools, release 11.8, V11.8.89
Build cuda_11.8.r11.8/compiler.31833905_0
torch: Version: 2.1.2+cu118
nvidia:
GPU 0: NVIDIA A100 80GB PCIe
GPU 1: NVIDIA A100 80GB PCIe
GPU 2: NVIDIA A100 80GB PCIe
GPU 3: NVIDIA A100 80GB PCIe
The model can be load success, when finish from_pretrained(emu2_gen) in bfloat16 precision, it occupies 78GB of GPU memory

Then, run the generate code:

process text2image : pipe("impressionist painting of an astronaut in a jungle"), it work fine.
but
process image editing:
image = Image.open("tmp_file.png").convert('RGB').resize((256,256))
prompt = [image, "wearing a red hat on the beach."]
ret = pipe(prompt)
The model will OOM:

OutOfMemoryError: CUDA out of memory. Tried to allocate 512.00 MiB. GPU 0 has a total capacty of 79.10 GiB of which 505.94 MiB is free. Process 2861798 has 78.60 GiB memory in use. Of the allocated memory 75.77 GiB is allocated by PyTorch, and 1.11 GiB is reserved by PyTorch but unallocated. If reserved but unallocated memory is large try setting max_split_size_mb to avoid fragmentation.  See documentation for Memory Management and PYTORCH_CUDA_ALLOC_CONF

update:
export PYTORCH_CUDA_ALLOC_CONF=max_split_size_mb:32
source ~/.bashrc
限制显存一次分配的最大单位可以解决这个问题. 目前能正常运行

Great! I'll close this issue. Feel free to open it again when encountering any other problems.


Performance suggestions

Greetings. I saw someone mention this library in a Reddit post, and upon checking it out I noticed that the factories for your types could be implemented in a more performant way.
By creating plain-old-objects in your factory functions, you're actually creating new functions for those object methods for every single instance created. The Result type, for example, defines 12 methods, which means that every Result that is created during a program's execution also creates 12 brand new function objects in memory, most of which probably aren't ever even going to be called, and most of which are implementing the same exact logic. For example, the isOk() method on an Ok object returns true. If I run my program and create 100 Oks, we'll be creating 100 functions that always return true instead of sharing one function that always returns true.
A trivial change that will improve this situation is to simply define some private classes for these factory functions. For example:
export function Ok<T, E = never>(val: T): ResOk<T, E> {
  return new OkImpl(val);
}

class OkImpl<T> implements ResOk<T> {
  #val: T;
  constructor(val: T) {
    this.#val = val;
  }
  get type(): typeof ResultType.Ok {
    return ResultType.Ok;
  }
  isOk(): boolean {
    return true;
  }
  isErr(): boolean {
    return false;
  }
  ok(): Option<T> {
    return Some(this.#val);
  }
  err(): OptNone<T> {
    return None;
  }
  unwrap(): T {
    return this.#val;
  }
  unwrapOr(_optb: never): T {
    return this.#val;
  }
  unwrapOrElse(_fn: never): T {
    return this.#val;
  }
  unwrapErr(): never {
    throw new ReferenceError('Cannot unwrap Err value of Result.Ok');
  }
  match<U>(matchObject: Match<T, never, U>): U {
    return matchObject.ok(this.#val);
  }
  map<U>(fn: (val: T) => U): ResOk<U> {
    return new OkImpl(fn(this.#val));
  }
  mapErr<U>(_fn: never): ResOk<T> {
    return this; // Why create a new instance when this is (shallow) immutable, anyway?
  }
  andThen<U>(fn: (val: T) => Result<U, never>): Result<U, never> { // I think the type on your ResOk interface is incorrect, but I'll do a different issue for that.
    return fn(this.#val);
  }
  orElse<U>(_fn: never): ResOk<T> {
    return this; // Why create a new instance when this is (shallow) immutable, anyway?
  }
}

This approach will be much more efficient, since every instance of an Ok object will share the same methods through the prototyope, instead of each carrying around 12 unique function instances and a Symbol.
I'll post some other suggestions as separate issues.
Cheers!

This should be addressed in https://github.com/sniptt-official/monads/pull/121 - please take a look!


[alpaka] Host and device memory caching allocator

Implement a caching allocator based on the cuda/cudadev one for device memory and pinned host memory.
The performance profile of the alpaka --cuda program now follows the one of the cuda program, while still having a ~5% performance degradation (shown in the plot after merging #307 and #308):

This is a first working implementation of a caching allocator written using alpaka buffers as its backend.
It does achieve better performance than using native CUDA memory allocations (in large part because of the caching of the host-side pinned buffers), even though the performance is not as good as that of the native CUDA version:

Rebased after merging #302 and #307 .

Rebased after merging #308.

The part about the statistics needs to be reorganised... the rest should be ready to go.

I've decided to descope the addition of the statistics to a follow up PR.


incorprate git bash to tertminal

so what am proposing that in current version only git cmd is  working properly and i would like to better working of seamless look of git bash
currently

and while doing so

and would like it to be like:

like so
hope to make this a reality
and sorry for any mistakes in advance

In command line put this:
C:/Program Files/Git/bin/bash.exe -login -i

You can set up git bash in windows terminal as mentioned in above. Also, git's installer also provides you with an option to add this into windows terminal for you.

Yep, as @KaranKad mentioned, git can already do this for you.


fix do not generate compare between Date to Date

Proposed changes
BE storage Engine has some bug in Date comparison, and hence if we push down predicates like Date'x' < Date 'y', we get error results.
This pr just convert expr like ’Date'x' < Date 'y',‘ to DateTime'x' < DateTime 'y'
Issue Number: close #xxx
Problem summary
Describe your changes.
Checklist(Required)

Does it affect the original behavior:

[ ] Yes
[ ] No
[ ] I don't know

Has unit tests been added:

[ ] Yes
[ ] No
[ ] No Need

Has document been added or modified:

[ ] Yes
[ ] No
[ ] No Need

Does it need to update dependencies:

[ ] Yes
[ ] No

Are there any changes that cannot be rolled back:

[ ] Yes (If Yes, please explain WHY)
[ ] No

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.69 seconds
load time: 493 seconds
storage size:<PHONE_NUMBER>7 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230118150233_clickbench_pr_83206.html


[S2GRAPH-32]: Support variable such as now, day, hour on query.

add TemplateHelper to deal with custom variable on query.

+1

+1

+1


long syntax for device mapping

introduce long syntax for device mapping, to help disambiguate path with colons
closes https://github.com/docker/compose/issues/12052

cc @idsulik


Fix next tag to be used when cutting a release on a release branch [release-0.12]

What this PR does / why we need it

This is a cherry pick of this PR https://github.com/vmware-tanzu/community-edition/pull/4361 which fixes the tagging on release branches
Which issue(s) this PR fixes

NA
Describe testing done for PR

NA
Special notes for your reviewer

NA

@jpmcb need to merge this before cutting the release


Fix workspace switcher creating new workspace

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/35680
PROPOSAL: https://github.com/Expensify/App/issues/35680#issuecomment-1924408425
Tests

Open workspace switcher
Click +
Click browser back button
Make sure the workspace switcher does not open again.

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

Open workspace switcher
Click +
Click browser back button
Make sure the workspace switcher does not open again.

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

https://github.com/Expensify/App/assets/77237602/63747345-881d-49df-903f-0a46d9d3644f

iOS: Native

iOS: mWeb Safari

https://github.com/Expensify/App/assets/77237602/e1474e01-de6f-4aa4-9749-5b702c3389bf

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/77237602/2a6e521c-1347-42ed-9948-a170561f8687

MacOS: Desktop

Bump @esh-g to fix the conflict so this review can proceed

@situchan Fixed the conflict. Be sure to tag if any conflict occurs in future! Thanks

I am getting unexpected bug. After click +, switcher doesn't get dismissed with this console error:

https://github.com/Expensify/App/assets/108292595/ac269a45-eb8d-4ed2-bbf8-2c59ea781ae1
@esh-g do you experience the same?

Yes, I see the error as well... Seems like because of https://github.com/Expensify/App/pull/36397

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome
https://github.com/Expensify/App/assets/108292595/aecfff55-5098-4f47-8885-52ee04efd1f3

iOS: Native

iOS: mWeb Safari
https://github.com/Expensify/App/assets/108292595/4006e740-06e9-4139-ab6d-4c578482c968

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/108292595/2afcfced-3170-4627-9b20-81a03eabd1c1

MacOS: Desktop

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/amyevans in version: 1.4.44-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.44-13 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


SARSA

To implement SARSA with experience replay:

The memory module should not compute "targets" or TD error. Memory should just store state/action/reward/next state information, and provide it in batches upon request.
The memory module should have a provide a large number of options for how batches are returned. For the case of SARSA, state/action/reward/next state/next state action can be returned.
For q-learning, just state/action/reward/next state is required
It might be more efficient and easier in some ways to store memory in separate state, action, reward vectors.
"Targets" should be computed by the models themselves, perhaps calling q-learning / sarsa classes to help compute.
Policy should not be used to compute TD error. Policy and td-error are unrelated. Given enough time, you could compute an optimal Q-function using a completely random policy.

It might be more efficient and easier in some ways to store memory in separate state, action, reward vectors.

What do you mean by that? There is one memory that is a list of state-actions-reward information. Why would be better to split that and how to sync them up?

"Targets" should be computed by the models themselves, perhaps calling q-learning / sarsa classes to help compute.

Aren't they already? https://github.com/EderSantana/X/blob/master/x/memory.py#L120-L121 Also we can always use the memory callback for a functional modification on the go: https://github.com/EderSantana/X/blob/master/x/memory.py#L118


Test invoke static

#199  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rbro112 and the rest of your teammates on  Graphite


Encoding for modularChangeFamily covered 100%

Encoding for modularChangeFamily covered 100%

glad to see the coverage improvement. I think one thing to look out for when we're adding these is to audit the non-persisted types to see if there are any fields not mentioned in the codec file. Yann recently caught a bug of this sort and fixed it in #16013, and we wouldn't have noticed this if looking strictly at the codecs/persisted format.


BST - remove root node error

The following test (that doesn't exist in codebase) fails with the current BST remove()
  it('should insert and remove single node properly', function () {
    var bTree = new BinaryTree();
    bTree.insert(15);
    var node = bTree.find(15);
    bTree.remove(node);
    expect(bTree._root).toBe(null);
  });

Here's the issue explained in comments
// this is called in .remove()
this._replaceChild(node._parent, node, null); // node._parent is null since the node is the root, node is valid
..
..
..
   function (parent, oldChild, newChild) {
    if (!parent) { //parent param is null, enter if
      this._root = newChild; //assigns null to root
      this._root._parent = null; // null._parent throws error
    } else {
      if (parent._left === oldChild) {
        parent._left = newChild;
      } else {
        parent._right = newChild;
      }

      if (newChild) {
        newChild._parent = parent;
      }
    }

I've got a fix in place, a bunch of tests for BST, and will submit a PR once https://github.com/mgechev/javascript-algorithms/pull/45 clears (changes are on my local master).

Fixed as of https://github.com/mgechev/javascript-algorithms/issues/47 , closing.


No Data No Crash

If you try to hit endpoints with no ODK submissions, the server crashes, because it's missing directories. Don't crash in this situation, it's ok.

fixed


getReduxDispatches is not a function

First time to use it and got
(anonymous function)	@	index.js?c41d:3972

Hey! Can you show the code you're using? Tough to know what's going on with what you provided

import React, {Component} from "react"
import {render} from "react-dom"
import {createStore, combineReducers} from "redux"
import {Provider} from "react-redux"
import {relateReducer, rootDataConnect, dataConnect} from "relate-js"

@rootDataConnect()
class App extends Component {
  render() {
    return (

        <Users />
        Hello

    )
  }
}

@dataConnect(null, {},
  props => ({
    fragments: {
      pages: { _id: 1, title: 1}
    },
    variablesTypes: {
      pages: { order: 'String' }
    },
    initialVariables: {
      pages: { order: props.order }
    },
    mutations: {
      addPage: [{ type: 'PREPEND', field: 'pages'} ]
    }
  }))
class Users extends Component {
  render() {
    return (

Users

    )
  }
}

var store = createStore(combineReducers({relateReducer}))
render(<Provider store={store}><App /></Provider>, document.querySelector("#app"))

If you're not using redux's state/dispatch functions you can simply remove them:
@dataConnect(
  props => ({
    fragments: {
      pages: { _id: 1, title: 1}
    },
    variablesTypes: {
      pages: { order: 'String' }
    },
    initialVariables: {
      pages: { order: props.order }
    },
    mutations: {
      addPage: [{ type: 'PREPEND', field: 'pages'} ]
    }
  }))

I get same error after remove them.
Also, I follow http://relax.github.io/relate/data-connect.html, and get this error if pass null as second argument.
Actions must be plain objects. Use custom middleware for async actions.

@dataConnect(
  (state) => ({
    sort: state.router.location.query.sort || '_id',
    order: state.router.location.query.order || 'desc'
  }),
  null,
  ...

Change null to {}, still get the getReduxDispatches is not a function error.
my react-relate version is 0.6.8

All the arguments need to be a function or null. That's the same with redux.


coreutils: disable tests which fail in sandbox

Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Is coreutils broken currently? I don't see a failing build on Hydra.

I don't think this is broken for hydra but when building it on my machine it is broken. I needed to rebuild the full stdenv for testing futile coreutils stdenv and this prevented me from doing that.

"futile"? future? Is this for a version bump? I still don't understand, sorry.

"futile"? future? Is this for a version bump? I still don't understand, sorry.

I meant to write uutils coreutils stdenv which I was trying at the time.


"Failed to import the required Python library (kubernetes)" when attempting to backup AWX

Environment

OS: Ubuntu 22.04
Kubernetes/K3s: k3s version v1.24.8+k3s1 (648004e4)
AWX Operator: 1.1.0

Description
Hello! I'm trying to make a wrapper for your project which can be found here: https://github.com/PC-Admin/awx-ansible
I've got the latest AWX up and running and was trying to first automate the backup of AWX using AWX. But I've hit a roadblock, I was able to get the manual backup steps here to work: https://github.com/kurokobo/awx-on-k3s/blob/main/backup/README.md
But I've run into trouble getting this running from AWX following these steps: https://github.com/kurokobo/awx-on-k3s/tree/main/backup/ansible
First I copied the custom pod specification into Instance Groups:

Secondly I configured this repository as a project:

Thirdly I configure the job template:

But when I run the job it fails with:
TASK [Create new AWXBackup resource and wait for complete] *********************
An exception occurred during task execution. To see the full traceback, use -vvv. The error was: ModuleNotFoundError: No module named 'kubernetes'
fatal: [localhost]: FAILED! => {"ansible_facts": {"discovered_interpreter_python": "/usr/libexec/platform-python"}, "changed": false, "error": "No module named 'kubernetes'", "msg": "Failed to import the required Python library (kubernetes) on automation-job-199-vd9gz's Python /usr/libexec/platform-python. Please read the module documentation and install it in the appropriate location. If the required library is installed, but Ansible is using the wrong Python interpreter, please consult the documentation on ansible_python_interpreter"}

TASK [Clean up failed AWXBackup resource] **************************************
An exception occurred during task execution. To see the full traceback, use -vvv. The error was: ModuleNotFoundError: No module named 'kubernetes'
fatal: [localhost]: FAILED! => {"ansible_facts": {"discovered_interpreter_python": "/usr/libexec/platform-python"}, "changed": false, "error": "No module named 'kubernetes'", "msg": "Failed to import the required Python library (kubernetes) on automation-job-199-vd9gz's Python /usr/libexec/platform-python. Please read the module documentation and install it in the appropriate location. If the required library is installed, but Ansible is using the wrong Python interpreter, please consult the documentation on ansible_python_interpreter"}

Any idea what I'm missing here? Sorry if this is a noob question.. :S

@PC-Admin
Hi, thanks for reporting.
/usr/libexec/platform-python is incorrect python interpreter for awx-ee image. I guess you missed ansible_python_interpreter variable for localhost in your inventory Pen_Holder.
Try adding following variables for your localhost in Pen_Holder, as default localhost in default Demo Inventory has.
ansible_connection: local
ansible_python_interpreter: '{{ ansible_playbook_python }}'

Thanks for the quick response, that worked. :)
I'll be closing this ticket for now, it could be a good idea to add a note about this to this page: https://github.com/kurokobo/awx-on-k3s/tree/main/backup/ansible#use-with-ansible

@PC-Admin
Thanks for updating and providing an idea to improve my guide. That's good idea, I'll add some description for the inventory to be used with my playbook.
Have fun! :)

Added note for inventory by #167


feat(toml)!: Update generator by using toml_edit

This is the other main half of #340.  Still have deprecations and tests left
Note that strings are rendered differently, see #287
By extension this also finishes up #396.
BREAKING CHANGES

impl Display for toml::Value now renders as values, not documents, see instead Table
toml::ser::Serializer only serializes documents, instead see toml::ser::ValueSerializer
toml::ser::tables_last is removed, no longer needed
toml::ser::to_vec is removed to mirror the loss of from_slice
atm toml::ser::to_string_pretty just causes larger arrays to be indented
toml::ser::Error is now opaque
toml::ser::Serializer::pretty_string was removed
toml::ser::Serializer::pretty_string_literal was removed
toml::ser::Serializer::pretty_array was removed
toml::ser::Serializer::pretty_array_indent was removed
toml::ser::Serializer::pretty_array_trailing_comma was removed
toml::ser::Serializer is now used used by value, rather than &mut

Fixes #396

what should be used instead of toml::to_vec?

toml::to_string(&data).into_bytes()


Can't run example.cpp

Hi, I'm trying to run your example.cpp file but I am getting a ton of errors when I try to compile it. Can you please check that it is functioning?
Thanks!

Omg. Somehow missed this issue, sorry.
Yes it is working, what kind of errors do you get? How do you run it?


Cpalmer2

Adding "getting started" subsections for each of the NWChem scenarios and adding pointers to the concept docs.

:warning: Validation status: warnings

File
Status
Preview URL
Details

articles/libraries/chemistry/installation.md
:warning:Warning

Details

articles/libraries/chemistry/schema/broombridge.md
:warning:Warning

Details

articles/libraries/chemistry/schema/index.md
:white_check_mark:Succeeded

articles/libraries/chemistry/toc.yml
:white_check_mark:Succeeded

articles/quickstart.md
:white_check_mark:Succeeded

articles/libraries/chemistry/installation.md

Line 19: [Warning] Invalid file link:(~/media/vs2017-nuget-manage-packages.png).
Line 26: [Warning] Invalid file link:(~/media/vs2017-nuget-package-search.png).
Line 31: [Warning] Invalid file link:(~/media/vs2017-nuget-select-chem.png).
Line 37: [Warning] Invalid file link:(~/media/vs2017-nuger-console-menu.png).

articles/libraries/chemistry/schema/broombridge.md

[Warning] 1 invalid cross reference(s) "here".
Line 24: [Warning] Invalid file link:(~/media/broombridge.png).

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.