This doesn't work

What do you do when your existing Azure app services do not show up and when creating a new one creates a new service, but will not publish. All attempts to publish the web app result in a 405 (Method not allowed) error. This worked before with vs2019, and I had no issues in vs2017, but has since stopped working in vs2019.
I really wish Microsoft would proof their code a bit better before releasing it. This version of VS for the Mac is REALLY buggy and REALLLLLLLLLLYYYYYYYYY SLLOOOOOOOOOWWWWW

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 92da5d51-dd0e-f62e-c453-8bdaafe04776
Version Independent ID: 645d4899-f7c6-ffcd-53fa-3b6fb64be765
Content: Publish to Azure App Service - Visual Studio 2019 for Mac
Content Source: mac/publish-app-svc.md
Product: visual-studio-mac
Technology: vs-ide-general
GitHub Login: @sayedihashimi
Microsoft Alias: sayedha

@echuck66 Thank you for the feedback, we appreciate it.
To make sure that this is logged in the right place, please use the Report a Problem tool to report the issue.
The report is then listed in the in the Visual Studio Developer Community and allows you to engage directly with the engineering team as they address and fix the problem.

Please explain why you closed this without providing a working solution or even a comment about what is wrong... It's starting to look like everyone is closing tickets because you have no desire to crack open a rabbit hole of problems..

@echuck66 Please provide a specific example and I will re-open the issue and have the engineering team diagnose.

I have reported bugs via Visual Studio. What do you need? Log files? Screenshots? Azure portal info? Please elaborate.
If you google issues for publish to Azure and look for '405 Method Not Authorized', or Azure App Services do not show up in the list, or any variety of publishing issues, you'll find ticket after ticket that was closed with no explanation of the cause or a solution.
I run a development firm and we are deciding on a development platform going forward, getting ready to purchase hardware and software, but we cannot get the basic functions to work as advertised and it's making it very difficult to recommend either Visual Studio (Mac) or Azure.

At a very minimum, this documentation should provide links to troubleshooting guidance, lists of issues related to the deployment process, and what to do if things don't go as advertised. This documentation is nothing but a happy-path scenario.

@echuck66 Okay, let's have the article re-tested then.

Hi @echuck66, I'm sorry that you are running into these issues. I'm a PM working in this area. I'd like to get more info to see what's going on. If you have some time, perhaps we can have a quick meeting so that I can see what you're experiencing. Please email me at sayedha at MICROSOFT dot COM.

Thank you. It appears as if the problem was the App Service OS type. I had chosen Linux, and those services never displayed in Visual Studio (Mac). Once I created Windows app services, I was able to see and deploy to them. It took a while last night, but I was able to get things configured.
I was suggesting someone add some type of FAQ or troubleshooting guide because I see a lot of people had the same type of issues and the tickets were just closed with no real explanation.
Thanks,
Charlie

On Jul 30, 2019, at 1:18 PM, Sayed Ibrahim Hashimi<EMAIL_ADDRESS>wrote:
Hi @echuck66 https://github.com/echuck66, I'm sorry that you are running into these issues. I'm a PM working in this area. I'd like to get more info to see what's going on. If you have some time, perhaps we can have a quick meeting so that I can see what you're experiencing. Please email me at sayedha at MICROSOFT dot COM.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/MicrosoftDocs/visualstudio-docs/issues/3692?email_source=notifications&email_token=AG6CS6S7T3LHDSWSQ5SNXDLQCBZV7A5CNFSM4IHP5QL2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3EVUCA#issuecomment-516512264, or mute the thread https://github.com/notifications/unsubscribe-auth/AG6CS6VOJSIUIQH5Z2AXEXLQCBZV7ANCNFSM4IHP5QLQ.

I am also having the same issue, I am running VS for Mac 8.5.1 and the Azure services running on Linux are not displayed and when I try to make a .net core web api service with .net core 3.1 on the Azure portal it allows me to choose only Linux as operating systems, this is very odd

I quit Azure. Terrible platform.
Sent from my iPhone

On Apr 7, 2020, at 6:21 AM, WarBorg<EMAIL_ADDRESS>wrote:

I am also having the same issue, I am running VS for Mac 8.5.1 and the Azure services running on Linux are not displayed and when I try to make a .net core web api service with .net core 3.1 on the Azure portal it allows me to choose only Linux as operating systems, this is very odd
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

We do not support publishing to Linux App Service instances yet. It is on our backlog, but we are still working through some more fundamental issue at the moment. Sorry about that.

@sayedihashimi ok, understood that, maybe add this info somewhere in the docs, but  still a question is left unanswered, why can't I create a web api app running core 3.1 on a windows server on the azure portal? any thoughts on that? the windows button is disabled :(

@WarBorg sounds good, I will get it updated.
@bradygaster you familiar with the new issue that WarBorg bring up?

why can't I create a web api app running core 3.1 on a windows server on the azure portal?

@sayedihashimi there was a known and long-running issue in which the .NET 3.1 SDK wasn't installed on App Service. That has been mitigated. It's there now so publish should work for folks.


Support for all archs

i forget open pr jskwodoowodowskso x86_64 is unstable (i doin stuff on termux its normal and if u gonna use)

This is good idea, i will merge it xd


Beaengine x32 project lacks BeaEngine_s_stdcall project

The Beaengine project for 32Bit lacks the .\obj... folder.
The project is supposed to compile and include the BeaEngine_s_stdcall project.

see #11


support for multiple Fabric Version in Integration test

update azp
update integration sh support fabric image as parameter.
Signed-off-by: SamYuan1990<EMAIL_ADDRESS>

@guoger , this is for https://github.com/guoger/stupid/issues/42


Allow disabled TextInput to still be interacted with

Resolves #1880
Follows Firefox's text selection usage (i.e. no blinking cursor, arrow keys don't do anything unless shift is pressed, cursor click position is remembered).
Draft for the following reasons:

Should the placeholder text be selectable?
Should this apply to TextEditors as well?
Currently, the allowed operations when disabled are copy and select all in addition to the selection primitives. Should there be more?

Should this apply to TextEditors as well?

Yes please, imo TextEditor is a TextInput on steroids, it should have all the behavior of TextInput plus more features.
There are many befits to have this behavior for TextEditor as well, for example using it to display long informational text that can be copied without editing it.

Should this apply to TextEditors as well?

Yes please, imo TextEditor is a TextInput on steroids, it should have all the behavior of TextInput plus more features. There are many befits to have this behavior for TextEditor as well, for example using it to display long informational text that can be copied without editing it.

Now that I've taken a closer look at the TextEditor architecture, it seems impossible to add this, as the TextEditor's state is held by the user. This means that the user has to provide a way to manipulate the state via the set_action method, but that would enable the text input instead.
What would be more appropriate would be to have a separate TextDisplay or similar widget that provides copy/paste capabilities and maybe some additional customisation options.

@Koranir
I understand, thank you for taking a closer look.


Add start_time to system.runtime.node

Fixes #3406

Already a PR:  #3413

@cawallin aha thanks, I somehow missed that.


feat(backtracking): N-Queens II

Coverage remained the same at 100.0% when pulling 6b5f87228a25bc5f51fbed20ead20c9b2d4cc3ba on n-queens-ii into dc23cda02fccb9b01a86575909cb4c687632ef2f on master.


Test and container env are too tightly coupled

The tests are too tightly coupled to the environment provided by the "micro-osd.sh" script. It currently hard-codes some names, and assumes some other things.
We should avoid hard coding as much as possible and pass expected configuration into both the setup script, to set up ceph server components that the tests needs, and then to the tests themselves.
To start simple we could just pass these to both programs as a set of environment variables.

I started cleaning up some of this a while back, but should probably continue it!


Fix typo in constant_doubles.c

Thanks for opening this! Looks like there's a CI issue I need to sort out to get these checks passing.


The webserver function is not working in the bot.py

Bug Report
Project: HadesConnect
Repository URL: https://github.com/haydenbanz/HadesConnect
Description
When the /start_server command is given, the server fails to start and returns a socket error.

now it's been fixed`@bot.command()
async def start_server(ctx):
# Create an asyncio loop for the web server and WebSocket server
loop = asyncio.get_event_loop()
# Create and start the web server
async def web_server():
    app = web.Application()
    async def hello(_):
        return web.Response(text="Hello, world")
    app.add_routes([web.get('/', hello)])
    runner = web.AppRunner(app)
    await runner.setup()
    site = web.TCPSite(runner, 'localhost', 8080)
    await site.start()
    await ctx.send("Web server started at http://localhost:8080")

# Create and start the WebSocket server
async def websocket_server(websocket, _):
    while True:
        message = await websocket.recv()
        print(f"Received message: {message}")
        await websocket.send(f"Echo: {message}")

# Run both servers concurrently
loop.create_task(web_server())
start_server = websockets.serve(websocket_server, "localhost", 8765)
loop.run_until_complete(start_server)
await ctx.send("WebSocket server started at ws://localhost:8765")`

fixed now`@bot.command()
async def start_server(ctx):
# Create an asyncio loop for the web server and WebSocket server
loop = asyncio.get_event_loop()
# Create and start the web server
async def web_server():
    app = web.Application()
    async def hello(_):
        return web.Response(text="Hello, world")
    app.add_routes([web.get('/', hello)])
    runner = web.AppRunner(app)
    await runner.setup()
    site = web.TCPSite(runner, 'localhost', 8080)
    await site.start()
    await ctx.send("Web server started at http://localhost:8080")

# Create and start the WebSocket server
async def websocket_server(websocket, _):
    while True:
        message = await websocket.recv()
        print(f"Received message: {message}")
        await websocket.send(f"Echo: {message}")

# Run both servers concurrently
loop.create_task(web_server())
start_server = websockets.serve(websocket_server, "localhost", 8765)
loop.run_until_complete(start_server)
await ctx.send("WebSocket server started at ws://localhost:8765")`


i18n(de): update guides/authoring-content.mdx

Description

update guides/authoring-content.mdx
#2612

Lunaria Status Overview
🌕 This pull request will trigger status changes.

Learn more
By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.
You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale
File
Note

de
guides/authoring-content.mdx
Localization changed, will be marked as complete.

Warnings reference

Icon
Description

🔄
The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.


Issue related to postgres newrelic plugin

As per the below link and instructions installed plugin and configured but the host is not visible in newrelic web console under plugin tab. As per the logs from /var/log/newrelic the error is "no metrics to send to newrelic this interval"
https://github.com/MeetMe/newrelic-plugin-agent#installation-instructions
can anyone suggest how to fix?  I have restarted the agent and plugin service. Also presents latest pip version , pyhton 2.7 & psycopg2.

no metrics means it probably failed to connect to the database. Our installation somehow got corrupted and would not start back up with segmentation fault as the symptom.  Depends on which OS, you may experience different behaviors.  Our installation was on Ubuntu which did not require a password for psql connection to the DB as the postgres user, but the script required username, password, DB schema, and the user must have superuser DB access before it would connect.  After the first connection, it may be caching the original DB connection internally which may have caused some havoc troubleshooting it as the behavior was inconsistent.

I was having the same issue with this postgresql plugin.  We provided the user and password that has power user privilege.  The plugin is still not visible in the newrelic web console under plugin tab. Here is the log content:
INFO       2017-05-10 15:33:14,247 415626 MainProcess     MainThread newrelic_plugin_agent.agent                   init                  L55    : Agent v1.3.0 initialized, Linux-2.6.32-573.22.1.el6.x86_64-x86_64-with-glibc2.2.5 (Red Hat Enterprise Linux Server 6.7 Santiago) CPython v2.6.6
WARNING    2017-05-10 15:33:14,351 415802 MainProcess     MainThread newrelic_plugin_agent.agent                   send_components           L217   : No metrics to send to NewRelic this interval
INFO       2017-05-10 15:33:14,351 415802 MainProcess     MainThread newrelic_plugin_agent.agent                   process                   L133   : Stats processed in 0.00 seconds, next wake in 119 seconds
WARNING    2017-05-10 15:35:14,351 415802 MainProcess     MainThread newrelic_plugin_agent.agent                   send_components           L217   : No metrics to send to NewRelic this interval
INFO       2017-05-10 15:35:14,352 415802 MainProcess     MainThread newrelic_plugin_agent.agent                   process                   L133   : Stats processed in 0.00 seconds, next wake in 119 seconds
WARNING    2017-05-10 15:37:14,352 415802 MainProcess     MainThread newrelic_plugin_agent.agent                   send_components           L217   : No metrics to send to NewRelic this interval
INFO       2017-05-10 15:37:14,364 415802 MainProcess     MainThread newrelic_plugin_agent.agent                   process                   L133   : Stats processed in 0.01 seconds, next wake in 119 seconds
Please could someone provide some assistant. Thank you


Feature loader, result counter

Addition of loader to give searchinator a more prompt sense of interaction, included result counter to help users get an indication of the performance of their search
How to test this change

[x] has automated tests
[ ] at least one a reviewer ran the code
[x] tested in small screen
[x] i18n
[x] tested in screen reader/contrast <-- remove this if no UX change

Approved. Dana is having a look at the code now. I ran and tested the functionality.


Azs.Backup.Admin: nextBackupTime and lastBackupTime should be treated as DateTime

@deathly809
The "nextBackupTime" and "lastBackupTime" in BackupLocation.json are treated as string. In C# SDK these will be deserialized into format losing time zone info.
We need to treat these as DateTime, just as createdDateTime in Backups.json

@sarangan12 Please assign to me and knithinc.  This is for the Azure Stack admin modules which we will be handling.
This is a bug in the spec and we will have to propagate changes forward.  Will be a minor breaking change and will have to ask on how to handle this one.

Fixed in #3225


React Select onChange should match signature of other form fields

Currently the onChange handler for Input looks like this:
<Input onChange={(value, event) => {
    console.log(value, event); // "text" SyntheticEvent{}
}} />

But the onChange for Select only receives the value and never receives the event:
<Select onChange={(value, event) => {
    console.log(value, event); // "text" undefined
}} />

I'd like to propose we modify the signature of Select's onChange to match that of Input.

Thanks for the issue, @zboman!
Out of curiosity, what's the use case you ran into where this is helpful?
I'd be happy to accept a PR for this one.

We've got a <form> of fields and the form has a single onFieldChange handler that we'd like to pass to all of the field elements to track changes. One of the things we need from each of the fields is the event.target.name attribute off of the element in order to uniquely identify it. This works great for <Input> but obviously fails for <Select>.
The handler looks roughly like this (though I've simplified it some):
onFieldChange = (value, e) => {
    this.setState({ [e.target.name]: value });
}

I'd be happy to whip up a PR in the morning 👍

Ah, cool. Thanks for the info! Take a look at the CONTRIBUTING.md file for tips on how to work in this codebase. Feel free to ping me if you run into issues.


Update tests after backing image refactoring & enhancement

longhorn/longhorn#2530

Just to understand, if the backing image download fails on 1st disk, are there retries?

@shuo-wu is this updated?

@innobead YES. BTW, we need to update the upgrade image after merging this PR.


Commands

Text Commands for Twitch Chat. Consist of a Command part, that does something when a message matches some conditions.
A Text Command (normal twitch style command) is a specific kind of command, one that send just directly sends a template ins response, without doing anything else.

[X] #25
[X] #49
[X] Patterns
[X] Commands Panel List
[X] Commands Panel Edit
[x] In-Code Command registration
[ ] #57

fast tracked because of phantombot issues


navigationBarTitleImage won't display

react-native-router-flux v3.37.0
react-native v0.41.2

I'm trying to use navigationBarTitleImage to put an image in the nav bar of a few scenes. It was working up until a few days ago, but now the image won't display. I'm not sure why it stopped working. I didn't make  changes to that part of my project.
Steps to reproduce
    <Scene sceneStyle={styles.pageStyle} key="home" component={Home}
      navigationBarTitleImage={require('./images/logo.png')}
      navigationBarTitleImageStyle={{  width:125, height: 35}}
     />

pageStyle:{
backgroundColor:'white',
marginTop:78,
}

Upgrade to  3.39.1

Thanks. I was hoping there was an another way because when I tried to upgrade it, I got an error, which would probably be resolved by upgrading react native, but upgrading react native leads to more errors. So, I was hoping there was a temporary work around. Oh well. Thanks for the reply!

You could try react-native-git-upgrade to upgrade react-native. That could help

There isn't other way no. It was a bug on the version you're using. And it was fixed on 3.39.0


jpg to jxl convert does not work

Describe the bug
Selected 2 jpg files to convert to jxl. Got an error message.
Screenshots

Smartphone (please complete the following information):

Device: Fairphone 5
OS: Android 13

Which error?

#1047 #1039


Add CI on pull requests / merges

Hey @jamis , it would be nice to have some code checks on PR and pushes.
created a dummy default travis config file to integrate the repo in travis. Please feel free to close this PR if you prefer any other CI tool

Great suggestion! Thanks!

You may need to create the project o Travis CI ad well

Okay, well, I'll admit my experience with Travis CI is pretty minimal. I've set it up and got it to run a build, and the jobs for Ruby versions 2.2, 2.3, 2.4, and 2.5 all pass just fine. However, the job for "latest" fails, because "Unknown ruby interpreter version (do not know how to handle): latest."
I don't see any provision for "latest" in the Travis docs, but it's entirely possibly I'm misreading them. If you're aware of something I might have done wrong, or if there was a typo in the commit you made, let me know. Otherwise I'll just yank that "latest" line from the travis config.

Actually this was my mistake. As I did in this gem https://github.com/mberlanda/jsonschema_serializer/blob/master/.travis.yml I should have put ruby-head instead of latest. Sorry. It was a silly error. It may be useful to make a small commit to correct it

It looks fine now: https://travis-ci.org/jamis/bulk_insert
:sunglasses:


Windows Build?

Just wondering whether you have any plans for either including a windows build or making it so it's compilable on windows.
I get
[ 11%] Building CXX object CMakeFiles/imx.dir/src/main.cpp.o
In file included from /cygdrive/c/Users/Tori/Downloads/imx-downloader-main/src/main.cpp:3:
/cygdrive/c/Users/Tori/Downloads/imx-downloader-main/src/./Downloader.hpp:5:10: fatal error: curl/curl.h: No such file or directory
    5 | #include <curl/curl.h>
      |          ^~~~~~~~~~~~~
compilation terminated.
make[2]: *** [CMakeFiles/imx.dir/build.make:76: CMakeFiles/imx.dir/src/main.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:83: CMakeFiles/imx.dir/all] Error 2
make: *** [Makefile:91: all] Error 2

when I try to compile on windows. going to try compiling on linux later

Unfortunately I have only used it on Linux (there it should compile fine). I don't have much experience writing cross-platform C++ applications so porting it to windows is not on the books right now.

That's fair, thanks for the reply though.


mnist tutorial l2 typo

Hello!
ran into this in a tutorial and it was bugging me, and since github now makes it impressively easy to submit such a fix, I did.
I tried it during the tutorial and it actually improved accuracy a tiny bit :)
enjoyed the tutorial and jax+haiku though, thanks for sharing.

@googlebot I signed it!

Hi Endre,
This is not a typo: the implementation of L2 regularization is correct, and there should not be a sqrt anywhere. The quantity which is being regularized is not actually the Euclidean norm (which would indeed have the sqrt) but the squared Euclidean norm.
An easy way to prove this to oneself is to recognize that the gradient of L2 parameter regularization is simply the value of the parameter itself. This is why, in frameworks like PyTorch where L2 reg is implemented as weight decay inside the optimizer, it takes the form:
param = param - (grad + lambda * param)
where lambda is the weight decay strength. Thus, the gradient of the L2 loss should be the parameter term. Consider this snippet to demonstrate:
import jax
import jax.numpy as jnp
def l2_nosqrt(x):
  return 0.5 * jnp.sum(x**2)
def l2(x):
  return jnp.sum(x**2)**0.5
l2_nosqrt_grad = jax.grad(l2_nosqrt)
l2_grad = jax.grad(l2)
key = jax.random.PRNGKey(0)
shape = (8, 8)
x = jax.random.normal(key, shape)
print(f'L2 with sqrt provides correct grads: {jnp.allclose(l2_grad(x), x)}')
print(f'L2 without sqrt provides correct grads: {jnp.allclose(l2_nosqrt_grad(x), x)}')

which yields:
L2 with sqrt provides correct grads: False
L2 without sqrt provides correct grads: True

Another way you can build intuition here is to recognize that if you apply the square root to the summed terms, the strength of regularization will vary with the size of x (e.g. the dimensionality of all the tensors being summed), because the square root is outside the enclosing sum. While you certainly can do this if you want (other techniques like global gradient norm clipping also have their effective strength vary with the dimensionality of the parameters), it would differ from the standard implementation.
This can also be seen historically if you look at Lasagne's implementation of L2 loss, or at Tensorflow's Implementation.

Thank you for taking the time to explain so quickly. I looked into it a little further, it's a bit frustrating not being able to tell why this works in some cases, but I think I see the evolution of the convention now and it is at least certainly simpler.


classes UI : table calendar format

Description
Change in classes UI. In this release, the calendar format is completely changed and classes are shown according to the date selected in the calendar.
I have added basic design and colors. Please let me know if you have anything specific in mind.
Fixes #142
Have you read the Contributing Guidelines on Pull Requests?

[x] Yes
[ ] No

Type of change
Please delete options that are not relevant.

[x] New feature (non-breaking change which adds functionality)

Checklist:

[x] My code follows the style guidelines(Clean Code) of this project
[x] I have performed a self-review of my own code
[x] My changes generate no new warnings
[x] I have added tests/screenshots(if any) that prove my fix is effective or that my feature works.

Screenshots
When we have selected a date that has classes(events).

When we have selected a date that has no classes(events).

Nice work @nicks101 , @avinashkranjan  please merge the PR.


fix(run-script-against-repos): add support for capital letters for user&repo

📝 Summary

Improve pattern of repositories to give support for user/org and repository with capital letters

⛱ Motivation and Context

Repository names and Organization/User names for GitHub are case insensitive.
Fix #41
📊 How Has This Been Tested?

Modifying a local script with these changes:
Before

After

Opening a new issue to discuss testing for this: https://github.com/octoherd/cli/issues/43


JAC00028:  Issue with working preferences displaying to candidate.

Describe the bug
Exercise JAC00028 has just launched but there is going to be an issue with candidates submitting their applications.
On the admin side there are no "working preferences" set up.  However, they are showing on the apply side.
We need to remove the option from the candidate side so that they can submit their applications.
To Reproduce
Steps to reproduce the behavior:

Go to 'apply'
Click on 'vacancies'
Select JAC00028
Start application
Go to working preferences
Try to save and leave the screen

Expected behavior
Remove working preferences from the "apply for the role" list
Screenshots
If applicable, add screenshots to help explain your problem.
Admin Side

Apply side

I think this is a data issue. For this exercise, in the database locationQuestion is set to the string "None" and the test in taskList (and other places), as to whether to display these questions or not, is if locationQuestion is Null or not (which it isn't here).
(This also applies to jurisidictionQuestion in the same way)
Proposed Resolution

Modify the two fields (locationQuestion and jurisdictionQuestion) to be Null. This will allow candidates to progress the form.
We then need to find out how it was set to "None" rather than Null , which will be an Admin bug.

Thank you @crablab for a great commentary.
@Claire for this exercise the actual text “None” had been inserted in the question title fields.
Thus on Apply we are asking the candidate for their answer to the question “None”!
To not ask questions in Apply the team should simply empty the question title field(s) in Admin.
We have emptied the question title fields for JAC00028.
Please can you verify all is ok now for this exercise.

Thanks @Warren Searle and @Hugh I have told the team directly.  I will also post in feedback.  I can confirm that its all working now.


mass function

MASS version: 0.1.3
Python version: 2.7
Operating System: Ubuntu

Description
I was trying to compare two time series query=X and ts=XY, i.e. time series has identical beginnings
What I Did
I ran actual = mts.mass(ts, query)
I noticed that the algorithm doesn't return a score of query along the first position of ts. A hot fix seems to add some random number in front of ts

@albertasdvirnas Thank you for submitting the issue. I am actually unable to reproduce the missing first distance with the MASS algorithm. However, I do see the issue with MASS2. Did you use MASS2 instead of MASS?
If you can provide some data to reproduce the issue, it would help me out a lot.

ts = np.array([ 2, 1, 1, 4, 5])
query = np.array([2, 1, 1, 4])
actual = mts.mass(ts, query)

returns array([1.85113597]), while I expect it to return something like
array([0, 1.85113597]) ?

Generally, MASS2 is the preferred algorithm over MASS. I simply implemented MASS to try to have a complete module. The original author's implementation of MASS has this same caveat.

If you have a solution to fix this, then feel free to make a contribution. The original MASS implementation is here:
https://www.cs.unm.edu/~mueen/findNN.html


Apply File.expand_path to all apk paths

Make GRADLE_ALL_APK_OUTPUT_PATHS have absolute path names like GRADLE_ALL_APK_OUTPUT_PATH

:+1:


References to external fragments via $ref are not properly supported

See attached files: if they are placed in the subdirectory within a workspace, it causes error.
In my case both files are inside openapi/test directory while linter searches the referred file in workspace root.
ref-issue.zip

I cannot reproduce the issue. It doesn't tell me that it cannot find the file.

See

Fixed, please try version 0.3.0


Update README.md

The objective of image registration is to find the spatial relationship between two or more images. In the last decades numerous image registration methods and tools have emerged from the research community. Implementation of these methods, however, are scattered over a plethora of toolboxes each with their own interface, limitations and modus operandi.
SuperElastix is an image registration toolbox written in C++ that incorporates a diverse set of registration algorithms from third-party sources. Its modular and flexible architecture enables the integration of algorithms from any registration paradigm, while fully supporting cross-fertilization. It provides a unified user-interface by means of a configuration file. Commandline as well as library interfaces are readily available. SuperElastix leverages social coding practices from GitHub, so that the toolbox becomes a collaborative effort from the image registration community.
SuperElastix is developed in conjunction with the Continuous Registration Challengehttps://continuousregistration.grand-challenge.org/, in which all the methods that are included in SuperElastix are automatically and continuously benchmarked on a diverse dataset.
Perhaps the sentence “SuperElastix leverages social coding practices from GitHub, so that the toolbox becomes a collaborative effort from the image registration community.” Can be formulated a bit more strongly still
Best, Marius
From: Floris Berendsen<EMAIL_ADDRESS>Sent: dinsdag 20 februari 2018 16:41
To: SuperElastix/SuperElastix
Cc: Staring, M. (RADI); Review requested
Subject: Re: [SuperElastix/SuperElastix] Update README.md (#170)
@FBerendsenhttps://github.com/fberendsen requested your review on: SuperElastix/SuperElastix#170https://github.com/SuperElastix/SuperElastix/pull/170 Update README.md.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHubhttps://github.com/SuperElastix/SuperElastix/pull/170#event-1482696971, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAsWFLxcwrhDFoVYKCCMLutRbQUust5Kks5tWuecgaJpZM4SMKQl.


Upgrade Ubuntu to fix the build

You update "runs-on" for the main.yml workflow. But you keep it at "18.04" for the codeql.yaml and backport.yaml workflow. Is this intended?
Could you please make ensure that formatting is kept intact when commiting, or if necessary separate formatting and code changes? Otherwise it makes a one-liner into a great challenge :-) Thanks [OK for this one, I found the relevant line].

I update the Ubuntu version of the main workflow because one of the deep version is no more installable on the old Ubuntu version
See also: https://github.com/mapfish/mapfish-print/runs/1867702834?check_suite_focus=true

Could you please make ensure that formatting is kept intact when commiting, or if necessary separate formatting and code changes? Otherwise it makes a one-liner into a great challenge :-) Thanks [OK for this one, I found the relevant line].

Yes, sure :-/

And not the CodeQL because his java version didn't yet work on the new Ubuntu version...

Ah, OK then.


The keywords for some options are absent in syntax/vim.vim

The keywords for the options 'varsofttabstop'/'vsts' and  'vartabstop'/'vts' are absent from syntax/vim.vim, and, consequently, don't get highlighted.
Gvim: gvim_8.1.0224_x86.zip

syntax/vim.vim won't be updated so frequently.
See the comment from the maintainer to a similar issue.
(I really don't understand why he post an answer for GitHub issues to win_use (or somewhere else). People who read the issue cannot find the comment in vim_use.)
If you need more frequently updated one, please use this fork: https://github.com/vim-jp/syntax-vim-ex

I see, thank you for the link to the fork! Not sure if I should close the issue, so leaving it open.

The issue will go away, once a newer syntax file is distributed with Vim. So closing.


[composer] inferring document title from first line doesn't work until another doc is created

See video below, document titles are not inferred until another doc is created. The document title should be inferred from the first line as you type.
https://github.com/dxos/dxos/assets/3398896/f7619a2e-a196-49f3-86be-661ef2b2c266

Currently blocked by #3675


Unknown error when adding Washing Machine

Receiving an unknown error when adding a washing machine
Manufacturer: Beko
Model: 888093200
Digital ID: F999 9208 4454 0494 1948 56
I can see this message in the logs.
dacite.exceptions.WrongTypeError: wrong value type for field "appliances.applianceSerialNumber" - should be "str" instead of value "None" of type "NoneType"

I was able to get the cloud componenet loaded and the Washing Machine added to HA by changing applianceSerialNumber on line 74 of api.py to applianceSerialNumber: Optional[str].
The device now shows up in HA but all entities show unavailable.
I am unable to add the Washing Machine via Bluetooth, I am using an ESPHome BTProxy.
In the logs of the BTProxy I can see it is sending the BT device to HA.
[00:44:51][V][bluetooth_proxy:033]: Proxying packet from HwZ_fb1149e742000b2506 - 00:A0:50:85:19:46. RSSI: -88 dB
[00:44:51][V][esp32_ble:178]: (BLE) gap_event_handler - 3
[00:44:51][V][esp32_ble:178]: (BLE) gap_event_handler - 3
[00:44:51][V][bluetooth_proxy:033]: Proxying packet from  - 16:EC:64:D2:17:51. RSSI: -97 dB
[00:44:52][V][bluetooth_proxy:033]: Proxying packet from HwZ_fb1149e742000b2506 - 00:A0:50:85:19:46. RSSI: -78 dB
[00:44:52][V][esp32_ble:178]: (BLE) gap_event_handler - 3
[00:44:52][V][bluetooth_proxy:033]: Proxying packet from  - 0C:DE:87:40:9D:0D. RSSI: -89 dB
[00:44:52][V][esp32_ble:178]: (BLE) gap_event_handler - 3
[00:44:52][V][bluetooth_proxy:033]: Proxying packet from  - C1:EF:5B:7E:8E:1C. RSSI: -87 dB
[00:44:52][V][esp32_ble:178]: (BLE) gap_event_handler - 3
[00:44:52][V][bluetooth_proxy:033]: Proxying packet from  - 16:EC:64:D2:17:51. RSSI: -96 dB
[00:44:52][V][esp32_ble:178]: (BLE) gap_event_handler - 3
[00:44:52][V][bluetooth_proxy:033]: Proxying packet from HwZ_fb1149e742000b2506 - 00:A0:50:85:19:46. RSSI: -78 dB

More detail on the BTProxy logs.
[09:14:04][V][component:204]: Component esp32_ble_tracker took a long time for an operation (0.08 s).
[09:14:04][V][component:205]: Components should block for at most 20-30ms.
[09:14:04][V][esp32_ble:178]: (BLE) gap_event_handler - 3
[09:14:04][VV][esp32_ble_tracker:369]: Parse Result:
[09:14:04][VV][esp32_ble_tracker:386]:   Address: 00:A0:50:85:19:46 (PUBLIC)
[09:14:04][VV][esp32_ble_tracker:388]:   RSSI: -98
[09:14:04][VV][esp32_ble_tracker:389]:   Name: 'HwZ_fb1149e742000b2506'
[09:14:04][VV][esp32_ble_tracker:397]:   Ad Flag: 6
[09:14:04][VV][esp32_ble_tracker:419]: Adv data: <IP_ADDRESS>.<IP_ADDRESS>A.5F.<IP_ADDRESS>.<IP_ADDRESS>.<IP_ADDRESS>.<IP_ADDRESS>.30.36 (27)
[09:14:04][V][bluetooth_proxy:033]: Proxying packet from HwZ_fb1149e742000b2506 - 00:A0:50:85:19:46. RSSI: -98 dB
[09:14:04][VV][api.service:336]: send_bluetooth_le_advertisement_response: BluetoothLEAdvertisementResponse {
address:<PHONE_NUMBER>98
name: 'HwZ_fb1149e742000b2506'
rssi: -98
address_type: 0
}
[09:14:04][V][esp32_ble:178]: (BLE) gap_event_handler - 3

Just an update.
I was able to get the Washing Machine connected now.
I updated ESPHome and the BTProxy to the latest 2023.6.3 and HA to 2023.7.0b0.
I removed the washing machine from the HomeWhiz app and re-added.
I still needed to comment out the serial number requirement and I checked the api to confirm it infact doesn't have a serial number. But it is now talking to Home assistant as expected.
"appliances": [             {                 "id": 130293,                 "applianceId": "F999920844540494194856",                 "brand": 3,                 "model": "8888093200",                 "applianceType": 1,                 "emulated": false,                 "platformType": "FABIO",                 "applianceSerialNumber": null,                 "shipped": true,                 "groupName": null,                 "autoController": null,                 "purpose": "NONE",                 "applianceComponents": [],                 "name": "Washer",


Removal of non-necessary includes in the engine

@OriolSors Thank you very much for your nice comment Oriol!

The conflicts have been solved!

@gerard-queralt Thank you Gerard! I appreciate it.

@OriolSors I'm sorry to bother you again, would you mind checking the pull request again? I don't think there should be any conflict anymore!

@OriolSors Thank you very much Oriol!


Lazy load profile images for past prime ministers

What
This PR updates the person presenter to lazy load profile images.
Why
Chrome shipped lazy loading support in version 76. The 'Past Prime Ministers' page is a good use case for this feature having 76 profile images that could be saved from being downloaded straight away. This attribute doesn't harm any browser and improves experience for users of Chrome 76 and further. The standard is awaiting implementation from other major players so this change will hopefully have more reach in future.

Excellent work Alex. This simple change makes quite a difference to the user-centric performance metrics for this page due to the large number of images:

Metric
Without LL (ms)
With LL (ms)
diff (%)

First Contentful Paint
3271
2520
-22

First Meaningful Paint
3393
2578
-24

Time to Interactive
3325
2840
-15

Speed Index
3564
3240
-9

Fully Loaded
7280
5821
-20

WPT comparison on a 3G Fast connection, Chrome version 78.0.3880.4.


Improve support for mocking futures and pageable operations

The futures currently expose the polling method and URL, but reconstructing a future or otherwise using some of the utility functions is difficult due to the structure of the package and the constructor.
What I'd like to be able to do is take a future and instead of calling WaitForCompletionRef, I want to extract some minimal data (pollingMethod, URL presumably), store that, and later do something like NewFutureFromURL(URL, method) (ignoring the naming).
I want to do this so that instead of blocking on WaitForCompletionRef I can call DoneWithContext and handle waiting/requeuing on a more granular basis myself.
The reason I do not want to use WaitForCompletionRef is that I am running in the context of a Kubernetes custom controller. I'd like to spawn as few workers as possible to deal with a potentially large number of resources in my workqueue, and calling this is a blocking operation for potentially long-provisioning resources. This will lead to blocking reconciliation of other objects in my work queue. I would much prefer to check the status of the operation, persist some polling metadata, and re-check the status at a later time I control.
This is also why I can't store the entire future -- persisting the future (and/or the full http response) across reconciliation runs is prohibitive. At the same time, I'd like to be as true as possible to the ARM API without reimplementing a large portion of that particular package.
thoughts?

The inner workings of WaitForCompletionRef() is built on public surface area of the Future type to allow consumers to build their own polling loop.  Please take a look and let me know if the available APIs will work for you.
In addition, futures support marshalling/unmarshalling (JSON format) so you could marshal the future into a byte slice for storage, then unmarshal it back into its concrete type when you're ready to check the status.

I opened this issue after my experience trying to do the first. I'm trying to work up an example of the behavior i'd like, it's taking some time though.
The second option is actually okay, but I'd like to avoid persisting the full HTTP response (embedded in the tracker) to the database on every function invocation. From what I can tell, the futures only use a very limited set of fields from the full response -- mostly the original request method, to know what polling behavior is correct.
I'd really like to be able to e.g. get a response back from an initial request using the SDK, call something like CheckInitialResponse(), and store a handful of fields which would let me poll again in the future to CheckStatus() or something like that. This behavior is difficult to implement on top of the current Future API without marshaling/unmarshaling the full HTTP response as you pointed out and storing it, but the current API could be implemented on top of that functionality.
The issue really boils down to the fact that, if I call a CreateOrUpdate or other LRO, and then exit that function context, it's very difficult for me to reconstruct the status of that operation and track it from other places without persisting a pretty sizable number of bytes somewhere. I can use the resources API to try and get a list of ARM operations on that resources, I can list activity history, etc, but really I just want to store minimal metadata from the original request and track it again in the future.

Looking at the code, marshalling the future doesn't persist the entire HTTP response, just the state necessary to recreate it and start polling.  If you are seeing this happen it's a bug.

Played around with this a bit more. Marshaling/Unmarshaling works perfectly, you're right. It'd be nice if the polling tracker struct/fields were public so I can (re)use them properly instead of embedding a byte array, but now I'm nit picking 🙂
Thanks for a great library!

This came up in a recent issue regarding mocking, i.e. it's difficult to mock an API that returns a future since you can't directly construct one.  If you'd like to see this functionality added we can recycle this issue to track it.

That would be really useful. I've ended up e2e testing or else wrapping the behavior under a client facade that's easier to mock.
cc @frodopwns

@jhendrixMSFT thanks for referencing the mock issue here.

+1
I'm trying to mock Delete/CreateOrUpdate functions and I'm running this exact issue https://github.com/Azure/azure-sdk-for-go/issues/409#issuecomment-538586232.  For example, I'm not able to mock VirtualMachinesClientAPI (github.com/Azure/azure-sdk-for-go/services/compute/mgmt/2019-07-01/compute/computeapi).
The only way I found to go around this would be to create a new interface and put the CreateOrUpdate + wait for future completion functionality inside its own function so I can then mock that interface, but that would require significant refactoring and I wouldn't be able to mock the Azure compute/network APIs directly.

@jhendrixMSFT is mocking / testability going to be addressed with next version of the Golang SDKs?

Given that Future is a struct type which no exported fields and a fairly small method set, turning Future into an interface, while breaking, doesn't seem awful. Perhaps we could have an exported field on the base client which is func(...stuff) Future (i.e., constructor for a Future) and we could mock the constructor on the client? Similar to how the SDK already treats Senders, Inspectors, etc.
Something like this:
https://github.com/kubernetes-sigs/controller-runtime/blob/efbeb2728794b105247bbf27c76a5c4949a73010/pkg/manager/manager.go#L177-L184
https://github.com/kubernetes-sigs/controller-runtime/blob/efbeb2728794b105247bbf27c76a5c4949a73010/pkg/manager/manager.go#L362-L370
https://github.com/kubernetes-sigs/controller-runtime/blob/efbeb2728794b105247bbf27c76a5c4949a73010/pkg/manager/manager.go#L244-L248

Illustrative examples of the sub-optimal workaround Cecile described, for reference:
Wrapper client which waits for completion: https://github.com/CecileRobertMichon/cluster-api-provider-azure/blob/cf66ed1ffffc6e09cf4ac019984839650071a76a/cloud/services/virtualmachines/client.go#L61-L72
Wrapper client which simulates async behavior and polls the future itself:
https://github.com/alexeldeib/incendiary-iguana/blob/b43ee7a2e32378eb6ed49e4b49a08a8dac992e9f/pkg/services/group.go#L46-L88

@devigned yeah we explicitly call this out in the design guidelines for track 2.
As to a solution, for the APIs that return a future I think we can have the mock interfaces return an interface; i.e. the real APIs still return a struct but the mock interfaces return an interface (GCP does the same thing).  I haven't had a chance to prototype this to see if it has any holes though.

Here's the implementation for track 2.
VM client BeginCreateOrUpdate returns a VirtualMachinePollerResponse.  This type exposes a PollUntilDone() func that can be user-defined for mocking as well as a VirtualMachinePoller interface if you need to mock the individual async polling methods.  Any feedback on the new design is welcome, please feel free to open an issue in the SDK repo an add the track 2 label.
Given that we won't be changing this for track 1 I'm closing this issue.


docs: add Jon as a contributor

LOL. I fixed the inconsistent naming of myself, but also just realized that my GitHub has me as Jonathan. I've made them all Jon now.


Autoregistration locality broken for VM workloads

Is this the right place to submit this?

[X] This is not a security vulnerability or a crashing bug
[X] This is not a question about how to use Istio

Bug Description
In https://github.com/istio/istio/pull/45476, there were two conceptual changes made:

The locality label was deleted from entry.Labels as the new locality format (which contains / is not a valid label)
The WorkloadEntry's locality was changed from being set via proxy.Locality instead of proxy.XdsNode.Locality.

The second change appears to have resulted in dropping the locality information from our WorkloadEntries. We've tested a patch reverting this change to retrieve locality from proxy.XdsNode.Locality, and we see the locality set again. It is unclear why this change was made in the first place, so we'd like to a) fix this bug, and b) make sure we understand when proxy.Locality is being set.
Version
We're using 1.19.7.

Additional Information
No response

cc @hzxuzhonghu

/assign 👀

@hzxuzhonghu Send a fix here, would love a review! We're testing this patch on top of 1.19, and it results in WLEs with locality information set correctly.


Swift cannot assign subscript on NSMutableArray property from Obj-C, FLEX 4.1.1

As title states, FLEX causes some weird behavior on Obj-C interoperability when Swift tries to mutate NSMutableArray property read from Obj-C source. The full error message is:
Cannot assign through subscript: subscript is get-only

Repro Steps

Add FLEX to project.
Create an Objective-C file with NSMutableArray property, e.g.

@interface Foo
@property (strong, nonatomic) NSMutableArray<NSString *> *strings;
@end

Use Objective-C class above in Swift, and mutate its property, e.g.

class TestCase {
  let foo: Foo = Foo()

  func doSomething {
    foo.strings[0] = "Hello, world!" // triggers the error.
  }
}

Expected Output
The code should compile just fine.
Notes

Confirmed that without FLEX, the code compiled just fine.
Tested on FLEX version 4.0.0 and 4.1.1.
Can be reproduced in Xcode 11.4 and 11.3.1.
May be related to #398?

Standalone Project
Repro.zip

Hi,
I'm still unable to determine whether this is really FLEX's fault or something wrong with the Swift compiler. FLEX doesn't declare any methods or properties named strings and frankly I'm not sure how FLEX could break Swift code like this.
I think you should file a bug on bugs.swift.org and send them your example project! I bet someone there will know what's going on. That or you found a bug in the compiler.
I'll leave this open

Hello, and thanks for the reply!

FLEX doesn't declare any methods or properties named strings and frankly I'm not sure how FLEX could break Swift code like this.

To clarify, the generic type and the variable name can be anything on the Obj-C side. The issue is that somehow, Swift compiler throws error when property of type NSMutableArray (defined in Obj-C) is mutated on the Swift side.

I think you should file a bug on bugs.swift.org and send them your example project!

Sure, I'll try to post there and will post any updates from there if any.
Thanks!

I'm facing the same issue. I think it has to do with the extension on NSArray/NSMutableArray FLEXCollection. This declares something that's a subscript but it's get only, so for some reason swift now can't see the get/set subscript.

This should be fixed in the next update. I'm going to close this, please reopen it if the issue persists! The current version is 4.1.1, so it will be the next one after that.


Weavescope manifest json & yml for k8s throwing 404

While following the k8s guide I got 404 on the following urls:
https://scope.weave.works/k8s-gen/weavescope.json
https://scope.weave.works/k8s-gen/weavescope.yaml

@StephenCharles thanks for reporting this, the docs went out before URL became operational. Please hangon, we are going to fix it shortly.

Closed via #1464.

@StephenCharles the URL has changed slightly, please refer to the updated docs.

Thank you!

@errordeveloper New URL still doesn't work

If you check the docs, the URL is https://scope.weave.works/launch/k8s/weavescope.json.

It was not working due maintenance. Thanks for checking it out :-)


Create backup copy of the destination file on a sync

For extra safety, create a copy of the destination file date/time stamped, juuuuust in case. This would support an eventual inbuilt "undo" feature in case someone does a sync in a way they didn't intend.

Implemented with v0.6.1


[Feature] Add metrics

I opened https://github.com/kyverno/reports-server/pull/159 to enable the builtin metrics. I can imagine database metrics becoming useful eventually (maybe from sqlstats), but the need isn't entirely clear yet.


feat(RELEASE-1044): add requireInternalServices parameter to verify-a…

Added a new parameter, requireInternalServices, to the verify-access-to-resources task. This allows pipelines that don't need access to internal service to skip the check.
Changes:

Added a new parameter requireInternalServices
Set the default value of requireInternalServices to false.
Updated existing pipelines to use the new parameter.
Updated README to document the new parameter and its usage.

/test all

/test all

/test all

/retest

/test release-pipelines-e2e-suite

/test release-pipelines-e2e-suite


use Release over RelWithDebInfo for ci

This will necessetate changing the "required tests" setting on the GitHub repo

Release is -O3 and RelWithDebInfo is -O2. This may technically lead to tests passing in CI but failing with prebuilt release. For example, -O3 will optimize using assume but -O2 will not. We need to make sure the prebuilt release is using the exact same config as CI.

that's what this PR is doing, releases are already switched to Release, this is correcting an oversight not making CI do this already

I see. Thanks for the clarification!


Bump proc-macro2 to fix build under recent nightly Rust

We build in recent nightly Rust?

I do locally.


Runtime information

as discussed here: https://github.com/getsentry/sentry-php/issues/562
this one adds a context containing the current php version.
running the examples/vanilla/index.php  results in a exception like this:
( i wanted to upload via github (seems to 503 right now, hope they have sentry))
https://imgur.com/Hs6FDYm
i really would appreciate if we can get this in an 1.8.* release (atleast a release in a short time) - i really would love to have this in production. let me know if you need me to backport it somewhere.

@ste93cry feedback adressed.

Thank you for the good work, patch looks good for me

@stayallive feedback addressd with: https://github.com/getsentry/sentry-php/pull/564/commits/59909d7c1c2ceb08c3327f3508c5d1be4528dc5a
verifies that custom contextes and runtime get merged

@Jean85 thx! - added a test to verify that on can override [runtime][name]  and [runtime][version]
had to change the order of the array_merge :D
also fixed tests on 5.3 :rage3:  ([]  vs array())

thx, you folks rock! 🍺

you want me to port it into 1.8 branch ? really would love to see this released.

@hjanuschka that's not necessary, the master branch is still for the 1.x series. The porting to that branch is done when tagging and releasing.


Adafactor: Update Clipping vs Gradient Clipping

The Adafactor paper (section 6) suggests "update clipping" instead of the usual "gradient clipping".

"Update clipping" here means clipping the update after all the fancy moment stuff has been applied (line 9 above)
However, the alias defined in alias.py clips the initial gradients:
https://github.com/deepmind/optax/blob/master/optax/_src/alias.py#L132-L140
Is this deliberate? FWIW, t5x's adafactor implements update clipping: https://github.com/google-research/t5x/blob/03dfc44be7f9a93d34c1d7fd6f896d1c364a7d4d/t5x/adafactor.py#L470-L476

Thanks for the question!
@mtthss could you comment on this, since you're the one who ported Adafactor from Flax?


Back-up Plan for Documents

Come up with a way to back up all our documents in google drive`

I think I’m going to backup the documents twice a week, and send out the backup from later in the week for everyone (before Monday meetings).


Themes: Fix shellcheck (SC2154); Part C

Please review commit notes as appropriate.
Description
As a follow on to my work removing .shellcheckrc (#1947) from hiding problems, this PR addresses these problems inside individual themes.
Motivation and Context
Due to the nature of themes, they use a huge number of variables from the themes lib and colors lib, but shellcheck is unable to follow the code flow so can't tell if these variables are defined or not. This patchset is meant to improve code so that shellcheck can either see the variables properly, or can trust that we have it under control.
NOTE: All the commits in this PR are single-file changes, so it may be easier to review per commit rather than all at once. I'm open to pulling some files out to separate PRs if needed.
How Has This Been Tested?
VIRTUAL_ENV= THEME_SHOW_CLOCK= RBFU_RUBY_VERSION= BASH_IT_THEME=teh_them bash -u and all tests pass.
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)

Checklist:

[x] My code follows the code style of this project.
[x] If my change requires a change to the documentation, I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
[x] I have added tests to cover my changes, and all the new and existing tests pass.

This is ready to review and hopefully ready to merge 😃

After going through all these themes, I have this suspicion that a lot of the themes are broken.

@davidpfarrell, @cornfeedhobo, @NoahGorny, I'd love to get some feedback on this one when any of you have time!
I've used ? for everything that seems pretty rock-solid definitely already defined (e.g. colors), and :- for everything that looks like a user-configurable preference (so everything still works no matter whether it exists or not). I've alsö run shfmt using current project settings and added to clean_files.txt. There shouldn't be any behavior changes at all (except perhaps if there were an unexpectedly failing conditional due to missing parameter).
A couple of things I've noticed:

some of the logic in some themes is copy/pasta from another, with slight divergence
some of the logic does not make sense to me; I don't understand what it's supposed to do.
in a few places, variables are references which exist nowhere else in the codebase...
something like half of the special characters in the themes show as the Unicode box on my system; is this normal? Is there a reference which shows them correctly (screenshots)?

@davidpfarrell, @NoahGorny, this PR is now much smaller since the intermediate PRs have been merged.

Hi @gaelicWizard, I think we should probably split this up for even more parts, this will make it much easier to review for me (the changes are unrelated to each other)

@NoahGorny, most of these already have open PRs. The "base" theme has #2038, pure has #2068, &c. I expect this PR to shrink even more as those are merged and leave only a few tidbits after.

This bad boy has shrunk down pretty small. Three files left: bargbuk, binaryanomaly, and modern. I think that's fair to review together.

I'll gladly review it if you could please merge the latest master, there are some conflicts in barbuk.


246

Please see notes in #246  - this ended up being a substantial refactor of all metrics.
This will also contain some doc work from #273 and #270 since it is the most up to date branch and isn't likely to get merged over the weekend.

:white_check_mark: Build healthcareai-py 1.0.433 completed (commit https://github.com/HealthCatalyst/healthcareai-py/commit/cb5f2c1720 by @Aylr)

:white_check_mark: Build healthcareai-py 1.0.435 completed (commit https://github.com/HealthCatalyst/healthcareai-py/commit/120217f77c by @Aylr)

:white_check_mark: Build healthcareai-py 1.0.437 completed (commit https://github.com/HealthCatalyst/healthcareai-py/commit/d7b5ff83f7 by @Aylr)

:white_check_mark: Build healthcareai-py 1.0.439 completed (commit https://github.com/HealthCatalyst/healthcareai-py/commit/7323787eb1 by @Aylr)

:white_check_mark: Build healthcareai-py 1.0.441 completed (commit https://github.com/HealthCatalyst/healthcareai-py/commit/e5c1d5db9a by @Aylr)

:white_check_mark: Build healthcareai-py 1.0.443 completed (commit https://github.com/HealthCatalyst/healthcareai-py/commit/2ad9df4a7c by @Aylr)

:white_check_mark: Build healthcareai-py 1.0.445 completed (commit https://github.com/HealthCatalyst/healthcareai-py/commit/12c9ec7f69 by @Aylr)


[TranslateBundle] Export Bundle Packages back to the bundles

By @marcelmoosbrugger from https://github.com/sulu-cmf/SuluTranslateBundle/issues/51
Like with the import task, which imports the export files from all bundles, it would be great to have an export task which exports the packages back to the bundles

@marcelmoosbrugger Isn't that already solved?

@danrot - no this is still open. At least i haven't done it.


Every other reconciliation batch fails in 3.5

With the current development version, every other reconciliation call fails with a NoHttpResponseException, apparently because it's attempting to reuse a closed connection.
To Reproduce
Reconcile a project with more than 20-30 rows and observe that the console logs failures on every other call.
Current Results
Every other batch fails with an HTTP error.
Expected Behavior
All batches get reconciled
Versions

OpenRefine: current development version

I think some defensiveness is a good idea, but it's worth noting that HTTP/1.1 has been available for 20 years.  TBH, I'm surprised that flask doesn't have some protocol check.  In any event, I think it's probably fair to classify this as a non-critical bug.

I will try to reproduce this. Do I understand correctly that this happens with csv-reconcile?

It does if you remove this line.  Honestly I don’t believe any real production services still close connections after each request any more.  The server that comes with Flask is not meant to be production ready.  Instead it should be wrapped with gunicorn or uwsgi.  The line pointed to above is a cheap hack meant to make the project as easy as possible to get up and running.
For clarity, this is all stuff I’ve learned along the way.
OTOH, as mentioned above while this sort of pathological closing of connections with each request is unlikely, the odd broken connection is not.  I’m guessing you’d like to test against broken connections.  If so, removing that line is one way to guarantee connections will be broken.
I hope this helps.  Let me know if you have any questions.

Great!  I take it you were able to make use of the service as described above?


Openshift-ACME stopped working

What happened:
I used the openshift-acme (v2) successfully a month ago. Today I added the annotation to a new route, but nothing happened.
What you expected to happen:
a certificate should be assigned or some kind of error/status message in the logs regarding this
How to reproduce it (as minimally and precisely as possible):

Add new Route
Add to route's yaml:
  annotations:  kubernetes.io/tls-acme: 'true'

Anything else we need to know?:
Since I made no changes, I checked the openshift-acme installation.
2 pods running:
the logs of the first one shows:

I0512 16:00:28.678950       1 reflector.go:188] Listing and watching *v1.LimitRange from k8s.io/client-go@v0.17.0/tools/cache/reflector.go:108
I0512 16:00:28.680075       1 reflector.go:188] Listing and watching *v1.LimitRange from k8s.io/client-go@v0.17.0/tools/cache/reflector.go:108
E0512 16:00:28.681679       1 reflector.go:156] k8s.io/client-go@v0.17.0/tools/cache/reflector.go:108: Failed to list *v1.LimitRange: limitranges is forbidden: User "system:serviceaccount:acme:openshift-acme" cannot list limitranges in the namespace "acme": no RBAC policy matched
E0512 16:00:28.681918       1 reflector.go:156] k8s.io/client-go@v0.17.0/tools/cache/reflector.go:108: Failed to list *v1.LimitRange: limitranges is forbidden: User "system:serviceaccount:acme:openshift-acme" cannot list limitranges at the cluster scope: no RBAC policy matched
I0512 16:00:29.115803       1 reflector.go:432] k8s.io/client-go@v0.17.0/tools/cache/reflector.go:108: Watch close - *v1.Secret total 0 items received
I0512 16:00:29.166473       1 reflector.go:338] k8s.io/client-go@v0.17.0/tools/cache/reflector.go:108: watch of *v1.Secret ended with: The resourceVersion for the provided watch is too old.

Second pod

I0512 05:19:18.406025       1 leaderelection.go:352] lock is held by openshift-acme-68f96bc4cf-9shhs_a11c13be-72c7-4201-a241-f38728d5371e and has not yet expired
I0512 05:19:18.406072       1 leaderelection.go:247] failed to acquire lease acme/acme-controller-locks
I0512 05:19:30.366674       1 leaderelection.go:352] lock is held by openshift-acme-68f96bc4cf-9shhs_a11c13be-72c7-4201-a241-f38728d5371e and has not yet expired
I0512 05:19:30.366778       1 leaderelection.go:247] failed to acquire lease acme/acme-controller-locks

Environment:

OpenShift/Kubernetes version (use oc/kubectl version):#
oc v3.11.0+0cbc58b
kubernetes v1.11.0+d4cacc0

@tnozicka

or some kind of error/status message in the logs regarding this

E0512 16:00:28.681679 1 reflector.go:156] k8s.io/client-go@v0.17.0/tools/cache/reflector.go:108: Failed to list *v1.LimitRange: limitranges is forbidden: User "system:serviceaccount:acme:openshift-acme" cannot list limitranges in the namespace "acme": no RBAC policy matched
E0512 16:00:28.681918 1 reflector.go:156] k8s.io/client-go@v0.17.0/tools/cache/reflector.go:108: Failed to list *v1.LimitRange: limitranges is forbidden: User "system:serviceaccount:acme:openshift-acme" cannot list limitranges at the cluster scope: no RBAC policy matched
I assume this was redeployed with newer version of openshift-acme and not updating RBAC role https://github.com/tnozicka/openshift-acme/blob/master/deploy/cluster-wide/clusterrole.yaml

Great, it works! Thank you very much for this fast reply!


Fixes #13211 linkLocalIPv6FromMac

Kudos to @gissehel for his great work on investigation and the fabulous bug report!
fixes #13211

thanks @MalteJ!
ping @mrjana to check if Libnetwork doesn't have the same bug.

In libnetwork we are deprecating this as inspect value. The eth0 interface inside the container will have this linklocal ipv6 address assigned to the interface itself. So if you do ip -6 addr show dev eth0 you should see the link local ipv6 address.

so I think this needs to be opened on libnetwork now? then pulled in here am i correct

@jfrazelle according to @mrjana's https://github.com/docker/docker/pull/13226#issuecomment-102257975 this shouldn't be a problem in Libnetwork. But I'm interested to hear if there's a regression test in place

cool @MalteJ can you rebase please :)

@jfrazelle well, it looks like the files I have edited disappeared from master branch :smile:

@MalteJ is the test case still useful for libnetwork?

@mrjana can you suggest the course of action for this PR ?

@MalteJ @thaJeztah @jfrazelle @mavenugo This test is moot because in the libnetwork bridge driver we don't generate the linklocal address from MAC at all. We leave it to the kernel to do it for us because of the way we plumb the interfaces. So this(the generation part) doesn't need to be tested. What may be tested is add an integration-cli to ensure that this is the case when container is brought up and the the container eth0 address has the linklocalFromMac setup correctly.
But, we should probably remove the linklocalFromMAC field from NetworkSettings because it's not populated any more.

Sorry @MalteJ, another one that we seem to have dropped with the big move to libnetwork =/ I'm closing this as my understanding from the above comments is that it's not relevant anymore.

no problem. I am happy we have the new network stack!

<3


Definition for inflected forms

Major Change

In the importing process, definitions for inflected forms are now correctly attributed to individual inflected wordforms, instead of lemmas.

Minor Change

filed lemma of model Definition now have related_name=definitions. wordform.definitions should be used now instead of `wordform.

Added unit test for lemma merging in importing process. Added integration test to make sure lemma nipaw only show 2 correct definition.

Note
Before merging this I need to

change push-db script to fix permission issues
build and push new database to Sapir

and I need to fix ci real quick

As far as I understand, the overall design has rather been that the dictionaries and their electronic versions contain Cree dictionary entries (whatever they are), for which English translations are given. Sometimes, these dictionary entries are lemmas, sometimes they are inflected forms, and sometimes they are multiword expressions. If the dictionary entry is a lemma, then POS information and paradigms should be provided.  This isn't necessarily the case for inflected forms not for multiword expressions.
On the longer term, dictionary entries that are inflected forms can be linked with the dictionary entry that represents the lemma given by the linguistic analysis of the inflected form.
But the reason for this approach is that by default one does not have an FST for analysis nor generation, and often the first FST is only partially implemented, at least in the initial stages. Thus, for a new language, one may not be able to rely on the FST to link dictionary entries that are inflected forms with ones that are lemmas.

@Madoshakalaka please fix the test failure before review

Codecov Report

Merging #200 into master will increase coverage by 0.34%.
The diff coverage is 93.1%.

@@            Coverage Diff             @@
##           master     #200      +/-   ##
==========================================
+ Coverage   79.89%   80.23%   +0.34%
==========================================
  Files          55       56       +1
  Lines        2019     2034      +15
==========================================
+ Hits         1613     1632      +19
+ Misses        406      402       -4

Impacted Files
Coverage Δ

CreeDictionary/tests/API_tests/model_test.py
74.68% <ø> (ø)
:arrow_up:

CreeDictionary/API/admin.py
46.15% <0%> (-0.69%)
:arrow_down:

CreeDictionary/DatabaseManager/xml_importer.py
94.34% <100%> (+1.34%)
:arrow_up:

.../API/migrations/0004_rename_definition_fk_lemma.py
100% <100%> (ø)

CreeDictionary/API/models.py
82.14% <100%> (ø)
:arrow_up:

...aseManager_tests/test_xml_importer_regression_0.py
100% <100%> (ø)
:arrow_up:

...y/tests/DatabaseManager_tests/xml_importer_test.py
100% <100%> (ø)
:arrow_up:

...Dictionary/tests/utils_tests/test_cree_lev_dist.py
100% <0%> (ø)
:arrow_up:

CreeDictionary/utils/cree_lev_dist.py
99.04% <0%> (+0.19%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0209936...2610ea6. Read the comment docs.

@aarppe Thanks for the insight, I'll keep these philosophy in mind.


django module raises TypeError if the instance show up without an ip, handle that

Discussed with Caglar, unable to reproduce bug, closing for now.


refactor: handle invalid environment key

👋 I've had a go at resolving #6. Please let me know what you think. I've changed the return type of NewClient. Alternatively, it can panic, but I think it is more idiomatic to return the error. I've also updated the example in example/server.go.
Fixes #6.

I've changed the return type of NewClient. Alternatively, it can panic, but I think it is more idiomatic to return the error.

I do agree with you, but we can't change the return type without doing a major release

Good point! I've avoided the breaking change. I suppose the changes in example/server.go are not as applicable now. Please let me know if you would like me to revert them. Thanks!

Good point! I've avoided the breaking change. I suppose the changes in example/server.go are not as applicable now. Please let me know if you would like me to revert them. Thanks!

Yeah, it would be better if we can revert them

Example reverted. (Although isn't it quite bad to have a function that may panic in a handler?)

Example reverted. (Although isn't it quite bad to have a function that may panic in a handler?)

It is, but we just want to keep it as simple as possible...(even for a person who does not understand go). It is definately not something the user should pick as it is and start using in production


Display images with comments

Add the imageURL to the list along with comment text so they can be displayed together

Could you change the base branch [1] so that it hides the changes from the other pull request?
[1] https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/changing-the-base-branch-of-a-pull-request

Could you change the base branch [1] so that it hides the changes from the other pull request?
[1] https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/changing-the-base-branch-of-a-pull-request

should I change the base branch to handle-blobstore-request?

Could you change the base branch [1] so that it hides the changes from the other pull request?
[1] https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/changing-the-base-branch-of-a-pull-request

should I change the base branch to handle-blobstore-request?

Yes.

Could you change the base branch [1] so that it hides the changes from the other pull request?
[1] https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/changing-the-base-branch-of-a-pull-request

should I change the base branch to handle-blobstore-request?

Yes.

done. Should I merge the two branches?


Bump packages - CVE

Signed-off-by: kaddy645<EMAIL_ADDRESS>Description
GSD-2022-25758 : All versions of the package scss-tokenizer prior to 0.4.3 are vulnerable to Regular Expression Denial of Service
GSD-2022-33987 : The got package before 12.1.0 (also fixed in 11.8.5) for Node.js allows a redirect to a UNIX socket.
GSD-2020-7789 : node-notifier before 8.0.1 allows attacker to run arbitrary commands on Linux machines due to the options parameters not being sanitised when being passed an array.
Issues Resolved

Check List

[ ] New functionality includes testing.
[ ] New functionality has been documented.
[ ] All tests pass

[ ] yarn lint
[ ] yarn test-unit

[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Does yarn lint and yarn test pass?

Yes it does!


Build broken from pip with last commit

pip3 install https://github.com/merckgroup/awscli-s3touch/archive/master.zip
results in:
Collecting https://github.com/merckgroup/awscli-s3touch/archive/master.zip
  Downloading https://github.com/merckgroup/awscli-s3touch/archive/master.zip
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/pip-k2hjnjzr-build/setup.py", line 5, in <module>
        long_description=open('README.rst').read(),
    FileNotFoundError: [Errno 2] No such file or directory: 'README.rst'

This appears to be due to this line:
https://github.com/emdgroup/awscli-s3touch/blob/master/setup.py#L5
caused by this commit which renamed it:
https://github.com/emdgroup/awscli-s3touch/commit/e3b1989afbf1fe52a94d885f25afc5c9cf4bf70b

you can just rename the .zip archive before you install it with pip3, it works fine then ;)

wait not the archive the README.md file to README.rst

Hi I have rename the Readme file as. MD format then it is stsrted working. But when I run the s3 touch help in command prompt. It is saying the plugins is not found

addressed with fef8f40edc457b945139b14bb2c88bde66b2f3d7


Update README.md

Adds instructions to use a custom font for a letter, as discussed in #1.

Thank you, much appreciated!


users. doc fixes

Specifically list had a bad description and createToken's example had the wrong return structure.

And I'm possibly cloning https://github.com/RocketChat/Rocket.Chat.Docs/pull/281 with regards to users.list...


Hide announcements code behind feature flag

What's changed and why?
The announcements UI is being hidden behind a user permission "Unreleased feature" to stop
them seeing and interacting with announcements, however there is nothing to stop the backend
code from running.
This has caused problems recently where the announcements section was removed 1 because the
code to populate publishing-api was looking for the announcements in the wrong place. We added
a flag to check if there are any existing announcements to get around the problem but since found that
this has a knock-on effect when drafts are discarded.
When the draft is discarded, announcements are retrieved from publishing-api and populated in the
database. As the local database has announcements, any changes made to the announcements section
via Github won't be picked because the flag we added will be true.
To fix both of these problems a feature class has been added that sets the conditions for when the backend
code associated with an unreleased feature should be run.
Idea "borrowed" from 2

This is a fancy looking technique, nice digging around.
I'd be a bit concerned about using Rails.env as the flag as that'll mean that you'd need to mock that if you wanted to test the feature flag being off, and I'm not sure if that causes other problems for a Rails test. Perhaps an env var would be more conventional?
When we wrestled with this on Content Publisher we wondered if we'd ever need something that listed individual features (as how this lists announcements) as we'd basically only need the flag until we gave it to users and then remove it. So rather than being a feature flag per-se it was more a flag to mark bits of the app that weren't ready. I wonder if that might be more applicable to this use case here?

So rather than being a feature flag per-se it was more a flag to mark bits of the app that weren't ready. I wonder if that might be more applicable to this use case here?

I thought that that was what this is doing! Is there another of setting the flag that I'm missing?

I'd be a bit concerned about using Rails.env as the flag as that'll mean that you'd need to mock that if you wanted to test the feature flag being off, and I'm not sure if that causes other problems for a Rails test. Perhaps an env var would be more conventional?

I suppose I'm trying to avoid having to do any puppet changes for something that's going to be relatively short-lived, hence not setting an env var. We have used Rails.env in the past though we were probably being super unconventional then too 😅

So rather than being a feature flag per-se it was more a flag to mark bits of the app that weren't ready. I wonder if that might be more applicable to this use case here?

@kevindew I thought that that was what this is doing! Is there another of setting the flag that I'm missing?

Sorry, I'll try rephrase to be more clear.
It seems unnecessary to be asking the question in code "is the announcements  feature turned on" because once announcements is ready you'll no longer need to ask the question. So the code of
data["announcements"] = announcements_data if Feature.enabled?(:announcements)
is basically the same as:
data["announcements"] = announcements_data if Feature.live_features?

I'd be a bit concerned about using Rails.env as the flag as that'll mean that you'd need to mock that if you wanted to test the feature flag being off, and I'm not sure if that causes other problems for a Rails test. Perhaps an env var would be more conventional?

I suppose I'm trying to avoid having to do any puppet changes for something that's going to be relatively short-lived, hence not setting an env var. We have used Rails.env in the past though we were probably being super unconventional then too 😅

Yeah, I see it as a 12 factor violation using Rails.env.production? to indicate an aspect of the deployment destinations configuration. There is some information on that in https://12factor.net/config. GOV.UK's past usage of that pattern causes all sort of problems, many of those needed to be resolved for the introduction of publishing-e2e-tests. It can still lead to lingering problems too, I noticed only yesterday that we can't test the postcode check on the heroku preview app due to a similar conditional.
I don't find it too much of a pain to add environment variables but if you really wanted to avoid it you could use environment variables to turn on the feature - e.g data["announcements"] = announcements_data if ENV["USE_DB_ANNOUNCEMENTS"] and then you'd only need to turn this env var on during the test process and it could be removed from the code once the live environment is ready.

It seems unnecessary to be asking the question in code "is the announcements feature turned on" because once announcements is ready you'll no longer need to ask the question. So the code of
data["announcements"] = announcements_data if Feature.enabled?(:announcements)
is basically the same as:
data["announcements"] = announcements_data if Feature.live_features?

@kevindew The idea of naming the features is so that we could potentially work on more than one at a time. Of course now that announcements is live, that's not going to be a problem. I'll have a think about how this can be made more generic.

It seems unnecessary to be asking the question in code "is the announcements feature turned on" because once announcements is ready you'll no longer need to ask the question. So the code of
data["announcements"] = announcements_data if Feature.enabled?(:announcements)
is basically the same as:
data["announcements"] = announcements_data if Feature.live_features?

@kevindew The idea of naming the features is so that we could potentially work on more than one at a time. Of course now that announcements is live, that's not going to be a problem. I'll have a think about how this can be made more generic.

Sure, I'm not sure we have a scenario where we want a feature flag to remain for a feature once it's out of pre-release. So if we have multiple features but they all end up with the condition Rails.env.production? do we actually benefit from listing them individually?

It seems unnecessary to be asking the question in code "is the announcements feature turned on" because once announcements is ready you'll no longer need to ask the question. So the code of
data["announcements"] = announcements_data if Feature.enabled?(:announcements)
is basically the same as:
data["announcements"] = announcements_data if Feature.live_features?

@kevindew The idea of naming the features is so that we could potentially work on more than one at a time. Of course now that announcements is live, that's not going to be a problem. I'll have a think about how this can be made more generic.

Sure, I'm not sure we have a scenario where we want a feature flag to remain for a feature once it's out of pre-release. So if we have multiple features but they all end up with the condition Rails.env.production? do we actually benefit from listing them individually?

That's a good point. I've had a stab at changing the approach to use and ENV var instead. If this looks ok, I'll start looking at the puppet bit.


Deprecate Py37

Python 3.7  reaches it's EOL in ~2 weeks https://endoflife.date/python
This PR deprecated our support for the same

Was the logic here just changing the Python version until the tests pass?

Yes!


Change default language to english

Excellent library!!
Could you make english the default language to display in labels?
I tried overriding the strings.xml tags from my application but had no success.
Thanks!

I am preparing a new version, three to four hours after the release.

Or making the language of the app configurable? Like http://stackoverflow.com/a/32037685
In the initialization at AlbumConfig seems to be a good place.

The default language has been modified in English and the Locale configuration is provided. And the new version provides the camera's ability to use alone, Album will be getting better and better, thank you for your feedback.

Thank you!!

thanks for support to this stage
now this lib have different bug
if i changed app lang and open album activity it call locale method so app reverse to previous lang
in other way to explaing it if your lang in en and  open album after that change app lang to chines and open album app with back to english cause it will call locale method
i think solution to updae local in seprate method to call it when change app lang
thanks for support


bump iptables version to v1.8.8

Description
Currently, the iptables version of calico-node is 1.8.4, The iptables-nft-save -t raw are incompatible. This patch will bump iptables to 1.8.8, which can solve the incompatible issue.

Related issues/PRs
fixes https://github.com/projectcalico/calico/issues/8403

Todos

[ ] Tests
[ ] Documentation
[ ] Release note

Release Note

Bump iptables version of calico-node to 1.8.8

Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one docs-* label.

docs-pr-required: This change requires a change to the documentation that has not been completed yet.
docs-completed: This change has all necessary documentation completed.
docs-not-required: This change has no user-facing impact and requires no docs.

Every PR needs one release-note-* label.

release-note-required: This PR has user-facing changes. Most PRs should have this label.
release-note-not-required: This PR has no user-facing changes.

Other optional labels:

cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.
needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.

/sem-approve

Thanks a lot @cyclinder, I've kicked off CI.

Failing with this error:
#45 ERROR: executor failed running [/bin/sh -c /clean-up-filesystem.sh]: exit code: 1
------
 > [ubi 25/26] RUN /clean-up-filesystem.sh:
#45 10.22 warning: file /usr/share/locale/en_GB/LC_MESSAGES/chkconfig.mo: remove failed: No such file or directory
#45 10.22 warning: file /usr/lib/systemd/systemd-sysv-install: remove failed: No such file or directory
#45 10.50 Failed to disable unit, unit systemd-readahead-replay.service does not exist.
#45 10.50 Failed to disable unit, unit systemd-readahead-collect.service does not exist.
#45 10.53 warning: file /etc/rc.local: remove failed: No such file or directory
#45 10.83 install-info: No such file or directory for /usr/share/info/nettle.info
#45 10.89 install-info: No such file or directory for /usr/share/info/history.info
#45 10.89 install-info: No such file or directory for /usr/share/info/rluserman.info
#45 11.01 warning: file /usr/share/locale/en_GB/LC_MESSAGES/p11-kit.mo: remove failed: No such file or directory
#45 11.85 Binary is missing after RPM cleanup: /usr/sbin/ip6tables
------
error: failed to solve: executor failed running [/bin/sh -c /clean-up-filesystem.sh]: exit code: 1

Thanks @fasaxc

Failing with this error:

Yeah, This is the issue I mentioned in https://github.com/projectcalico/calico/issues/8403#issuecomment-1895850802, and I'm trying to fix it now...

➜  node git:(6503dfeb6) ✗ docker run --rm -it a21da52eb5b1 bash
[root@73874e0b42fe /]# ls /usr/sbin/ip6tables
/usr/sbin/ip6tables
[root@73874e0b42fe /]#

In fact we can be sure that ip6tables is there, but I wonder why this script is complaining that it has been deleted.

@cyclinder ip6tables is present as a symlink to /usr/sbin/ip6tables-legacy, which is not found, right? On https://github.com/projectcalico/calico/issues/8403 @defo89 mentioned that the "legacy case is not covered". Is ip6tables-legacy included in version 1.8.4 (what we currently have), but not in 1.8.9? I wonder if there's an extra package that needs to be installed that will include it

ip6tables is present as a symlink to /usr/sbin/ip6tables-legacy, which is not found, right? On https://github.com/projectcalico/calico/issues/8403 @defo89 mentioned that the "legacy case is not covered". Is ip6tables-legacy included in version 1.8.4 (what we currently have), but not in 1.8.9?

@coutinhop Yes, We have not found ip6tables-legacy in 1.8.8

I wonder if there's an extra package that needs to be installed that will include it

I'm more inclined to say that the symlink is incorrect, and ip6tables-nft is there. so it should be ip6tables -> /usr/sbin/ip6tables-nft?

It think the whole point of that custom build logic is to build the legacy and nft versions of iptables.  Normally, RPMs contain one or the other with the same name iptables but we need to install both and select at runtime.

We may need to get iptables legacy from a different source to iptables-nft - I think that's OK, and probably inevitable given the deprecation progress of iptables.

thanks @matthewdupre .yeah, We really should build both legacy and NFT and then let Runtime choose which one to use.
I verified the latest changes locally for me, It works well.
@fasaxc Can you help trigger the CI and then see what happens with the CI?

/sem-approve

/sem-approve


[textanalytics] updating docs for release

WIP

API change check
APIView has identified API level changes in this PR and created following API reviews.
azure-ai-textanalytics


aaaaxy: 1.3.421 -> 1.3.436

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/divVerent/aaaaxy/releases.
meta.description for aaaaxy is: A nonlinear 2D puzzle platformer taking place in impossible spaces
meta.homepage for aaaaxy is: https://divverent.github.io/aaaaxy/
Updates performed

Golang update

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.3.436 with grep in /nix/store/fp3v9pdmqllsblcy8jnv9bqyn0wjama9-aaaaxy-1.3.436
found 1.3.436 in filename of file in /nix/store/fp3v9pdmqllsblcy8jnv9bqyn0wjama9-aaaaxy-1.3.436

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
aaaaxy

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/fp3v9pdmqllsblcy8jnv9bqyn0wjama9-aaaaxy-1.3.436 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A aaaaxy https://github.com/r-ryantm/nixpkgs/archive/4350c5584effaa4e005e3056079e2006aa1e8679.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/fp3v9pdmqllsblcy8jnv9bqyn0wjama9-aaaaxy-1.3.436
ls -la /nix/store/fp3v9pdmqllsblcy8jnv9bqyn0wjama9-aaaaxy-1.3.436/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

aaaaxy

Maintainer pings
cc @Luflosi for testing.

I'd like to get https://github.com/NixOS/nixpkgs/pull/225222 merged first for better testing.

@ofborg build aaaaxy aaaaxy.passthru.tests

FYI: a new version is already out: https://github.com/divVerent/aaaaxy/releases/tag/v1.3.457
I'll make a PR this weekend.


Fix handling of root route when query params present

Hey, I just made a Pull Request!

:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[x] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

Thanks will there be a 1.33.4 with this included?

Pretty sure you're hitting this in the E2E test: https://github.com/swagger-api/apidom/issues/4539


Add console_link library to migration console, implement cat-indices

Description
Unintentionally pulled in @gregschohn 's jenkins changes, will rebase branch to get those out.
But the actual content:
the beginnings of a python library that serves as the link between a frontend (CLI in this case, though web API works too) and various backends (source & target clusters, replayer & backfill services, etc.).

What's included in this PR specifically
Docker env support for cat indices:
root@ad3133b6248d:~# console_link cat-indices
SOURCE CLUSTER
green open searchguard lpxD3MRARnmbEXmmaqELJQ 1 0 8 0 45.4kb 45.4kb

TARGET CLUSTER
green  open .plugins-ml-config           zibQKJ8HTCuKuK53BSe_2g 1 0    1 0   3.9kb   3.9kb
green  open .opensearch-observability    GZSXkl41RvSVUnXMIAa2Wg 1 0    0 0    208b    208b
green  open sonested                     SFq9CcuhQp-FMK84TvbtvA 1 0 5954 0 950.3kb 950.3kb
yellow open security-auditlog-2024.05.15 6VmmdJjOS9q8QU-GZDCwdg 1 1   27 0   156kb   156kb
yellow open security-auditlog-2024.04.26 b5Ut-5rQQrq5PwYJ5Np5Mg 1 1   30 0 170.5kb 170.5kb
green  open .opendistro_security         phu-ZEoRTGmFWARaxx7O3w 1 0   10 0    79kb    79kb

Issues Resolved
[List any issues this PR will resolve]
Is this a backport? If so, please add backport PR # and/or commits #
Testing
[Please provide details of testing done: unit testing, integration testing and manual testing]
Check List

[ ] New functionality includes testing

[ ] All tests pass, including unit test, integration test and doctest

[ ] New functionality has been documented
[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.
Setup a docker-compose environment to run jenkins and have a couple build options to build with local (current) changes.
I'm also setting up/testing some changes for loading the Jenkinsfile from the repo.
Signed-off-by: Greg Schohn<EMAIL_ADDRESS>

Couple high level thoughts from scanning over:

Can we move this console_link folder under our lib folder on the migration console, as I imagine we may have a few libraries
What does console_link mean, I think I'm just missing something? Naming is hard though so I'll leave to your discretion, does using a cli command name like console (this could be confusing) or mconsole sound appealing at all?

@lewijacn

Can we move this console_link folder under our lib folder on the migration console, as I imagine we may have a few libraries

Yep, that works! It can really be anywhere as long as we can pip install it.

What does console_link mean, I think I'm just missing something? Naming is hard though so I'll leave to your discretion, does using a cli command name like console (this could be confusing) or mconsole sound appealing at all?

Yeah, I ended up at console link as I'm thinking of this as the piece that links our frontends and backends, but I have zero attachment to it. And at the very least, I like the idea of the cli command being console. If you're logging onto the migration console, it makes sense to then "speak" to the console.

Okay, changed the name of the cli, so the example from above is now:
root@ad3133b6248d:~# console cat-indices
SOURCE CLUSTER
green open searchguard lpxD3MRARnmbEXmmaqELJQ 1 0 8 0 45.4kb 45.4kb

TARGET CLUSTER
green  open .plugins-ml-config           zibQKJ8HTCuKuK53BSe_2g 1 0    1 0   3.9kb   3.9kb
green  open .opensearch-observability    GZSXkl41RvSVUnXMIAa2Wg 1 0    0 0    208b    208b
green  open sonested                     SFq9CcuhQp-FMK84TvbtvA 1 0 5954 0 950.3kb 950.3kb
yellow open security-auditlog-2024.05.15 6VmmdJjOS9q8QU-GZDCwdg 1 1   27 0   156kb   156kb
yellow open security-auditlog-2024.04.26 b5Ut-5rQQrq5PwYJ5Np5Mg 1 1   30 0 170.5kb 170.5kb
green  open .opendistro_security         phu-ZEoRTGmFWARaxx7O3w 1 0   10 0    79kb    79kb


Add timezone into PDF report

It is always better to have the timezone explicitly described, especially when the service targets the international community

Fixed in the #31


Now button that also sets time to current time

Hi,
Thanks for creating this widget! I was wondering if the default Today button could be extended with a Now button that not only sets the current date of the picker, but also the current time. Right now, the today button sets the time at 00:00.
Regards,
Kevin

Hi Kevin,
You can accomplish this using the current widget.

Enable Custom Content in the Customization tab
disable the today button
Add a button to the new custom content section

Have the button call a nanoflow that sets your datetime attribute using '{%CurrentDateTime%}'