Unwanted numba rounding vs native sum

Hey,
I get an unwanted round up issue with numba when parallelizing.
I noticed that this also happens when I use np.sum.
So, I explicitly tried to avoid using np.sum but still get different results when using parallel = True.
(both numba and numpy seem to overestimate w.r.t. native)

@nb.njit(nb.float64(nb.float64[:]))
def nb_sum(a):
    return sum(a)

@nb.njit(nb.float64[:](nb.float64[:,:]), parallel=True)
def nb_sum_parallel(a):

    a0 = np.zeros(a.shape[1], dtype=nb.float64)

    for i in nb.prange(a.shape[1]):
        a0[i] = sum(a[:,i])

    return a0

# random array
rng = np.random.default_rng(seed=0)
a = rng.random((100000, 1), dtype=np.float64)

In this case, numba works as intended - i.e. it's consistent with the native sum:
Numpy
np.sum(a[:,0])
# 50078.714844845796

Native
sum(a[:,0])
# 50078.71484484553

Numba with Native
nb_sum(a[:,0])
# 50078.71484484553

Numba with Native and being called from another function /w nb.prange:
nb_sum_parallel(a)
# array([50078.71484485, 49779.23691987, 49989.58522751])

Versions:
numpy = '1.22.4'
numba = '0.55.2'
Any idea how I could avoid this behavour?

I am able to reproduce on a Mac M1 with the current numba. I think this is just compounding floating point error and there's probably not much that can be done.
For instance, if I take your program and shuffle the input, and then re-run the sums, like this:
import numba as nb
import numpy as np

@nb.njit(nb.float64(nb.float64[:]))
def nb_sum(a):
    return sum(a)

@nb.njit(nb.float64[:](nb.float64[:,:]), parallel=True)
def nb_sum_parallel(a):

    a0 = np.zeros(a.shape[1], dtype=nb.float64)

    for i in nb.prange(a.shape[1]):
        a0[i] = sum(a[:,i])

    return a0

# random array
rng = np.random.default_rng(seed=0)
a = rng.random((100000, 1), dtype=np.float64)

print(np.sum(a[:,0]))
print(sum(a[:,0]))
print(nb_sum(a[:,0]))
print(nb_sum_parallel(a))

np.random.shuffle(a)
print(np.sum(a[:,0]))
print(sum(a[:,0]))
print(nb_sum(a[:,0]))
print(nb_sum_parallel(a))

I get slightly different values:
49957.42678160858
49957.42678160842
49957.42678160842
[49957.42678161]
49957.42678160859
49957.42678160871
49957.42678160871
[49957.42678161]

Floating point arithmetic isn't truly commutative and doing it in parallel will make the error much larger. It also depends on the magnitude differences between the numbers.

IIRC NumPy uses pairwise summation which still achieves good performance but exhibits better properties in rounding error than a naive summation loop. Implementing that might be another option to mitigate the behaviour in the OP. xref: #3046.


Dataset

Hello,
The dataset (11572 utts) in your paper is inconsistent with that (23075 utts) in the script prepare_data.py, and I can't get the result or similar results in your paper using the dataset in your paper. Can you give some guidance？
Thank you very much!

You can use the train_wav.txt to choose the 11572 utterances used for training SERGAN.


Indentation prompt for multiline edits

I am currently working on creating a REPL for my own language. For multiline editing I just use the matching bracket validator for now, but that puts the cursor to the very front of the next line:
>> fun greet(name) {
    printl('Hello, ' + name + '!')
}
>>

Comparing this to other REPLs like node or bpython, I would want it to look like this:
>> fun greet(name) {
..     printl('Hello, ' + name + '!')
.. }
>>

Auto-indentation is not needed, just the placeholder dots in front to align the next lines with the prompt.
I think this would fit best as a config setting like indent_text which is "" by default.
If there already is a way to achieve this, please let me know

Are there any plans on merging that PR? reedline seems a bit unfinished and less mature to me and I dont't really want to switch the whole library for that one feature

Not in its current state.


Lodash error

Hello, when I try to view my treebeard component in chrome, I receive the following the error in the console:
TypeError: (0, _lodash.castArray) is not a function (bundle.js:1235)
at TreeBeard (bundle.js:90263)
I’ve tried updating some dependencies to their latest versions, but it is still occurring. Does anyone know where this could be coming from?
Thank you in advance!

Hi @rachelaroberts ! Could you upload an example please? (codesanbox)
Thanks

Hi, I have been having the same issue since recently, I haven't updated or modified my code, it worked for a year up until now....
IMPLEMENTATION:
`const TreeExample = (props) => {
const [data, setData] = useState({});
const [cursor, setCursor] = useState(false);
useEffect(() => {
const getUsers = async () => {
const result = await axios(
"example.org/userData"
);
let pom = result.data[0];
setData(pom);
};
getUsers();
}, []);
const onToggle = (node, toggled) => {
globalnaResetStranica = 0;

if (cursor) {
  cursor.active = false;
}
node.active = true;
if (node.children) {
  node.toggled = toggled;
}
setCursor(node);
setData(Object.assign({}, data));

};
globalnaPromenljiva = cursor.name;
return ;
};`
as I said, this worked for a year until a few days ago...


Bug: Rendering frames from dump file with render_dump.py

I have some dump files (with no frame saved) and I am trying to render the frames.
I tried to use the script render_dump.py but I get the following error:
Traceback (most recent call last):
  File "/usr/lib/python3.6/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/usr/lib/python3.6/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/home/alessandroserena/.local/lib/python3.6/site-packages/gfootball/render_dump.py", line 43, in <module>
    app.run(main)
  File "/home/alessandroserena/.local/lib/python3.6/site-packages/absl/app.py", line 300, in run
    _run_main(main, args)
  File "/home/alessandroserena/.local/lib/python3.6/site-packages/absl/app.py", line 251, in _run_main
    sys.exit(main(argv))
  File "/home/alessandroserena/.local/lib/python3.6/site-packages/gfootball/render_dump.py", line 40, in main
    processor.write_dump('episode_done')
  File "/home/alessandroserena/.local/lib/python3.6/site-packages/gfootball/env/observation_processor.py", line 381, in write_dump
    self.process_pending_dumps(True)
  File "/home/alessandroserena/.local/lib/python3.6/site-packages/gfootball/env/observation_processor.py", line 393, in process_pending_dumps
    self._config)
  File "/home/alessandroserena/.local/lib/python3.6/site-packages/gfootball/env/observation_processor.py", line 163, in write_dump
    frame = frame[..., ::-1]
TypeError: string indices must be integers
I0725 16:55:57.314935<PHONE_NUMBER>74816 observation_processor.py:390] Start dump episode_done
Exception ignored in: <bound method ObservationProcessor.__del__ of <gfootball.env.observation_processor.ObservationProcessor object at 0x7f7dd0174048>>
Traceback (most recent call last):
  File "/home/alessandroserena/.local/lib/python3.6/site-packages/gfootball/env/observation_processor.py", line 320, in __del__
    self.process_pending_dumps(True)
  File "/home/alessandroserena/.local/lib/python3.6/site-packages/gfootball/env/observation_processor.py", line 393, in process_pending_dumps
    self._config)
  File "/home/alessandroserena/.local/lib/python3.6/site-packages/gfootball/env/observation_processor.py", line 163, in write_dump
    frame = frame[..., ::-1]
TypeError: string indices must be integers

After a closer inspection I have found out that this error occurs because frame is set to the string 'deleted' and the code therefore fails because it is expecting a pixel matrix. This looks like a loop to me since the script that is supposed to generate the frames expects the frames to be there already.

Update: is render_dump.py meant to generate the frames? Or, is its purpose only to generate the .avi file when the frames are already present?

If you want to render video from a dump you should use replay.py script.
render_dump.py was supposed for converting dumps into visual version with "fake" game rendering, but needs a small fix to not fail on the "deleted" string.

Thanks for your answer :)
What do you mean as "fake" game rendering?
If the fix for the "deleted" string is applied, would render_dump.py be able to generate the frames when these are not already in the dump? Or which kind of visual version would it create?

It would render 2D field with dots representing players, so it is easier to interpret than the row dump, but there will be no real game rendering. To see rendering you need to use replay script.


Remove Nodejs16 support

Description
Changes proposed in this pull request:

Remove Nodejs16 support

Related issue(s)

https://github.com/kyma-project/serverless/issues/747

/retest


Bad in content jump with Markdown link

Describe the bug
Markdown link which linked into a subtitle in the .dib notebook such as: [Environment setup](#environment-setup)，
behave not so accurate in jumping.
It will jump to one or two blocks behind the target title.
Please complete the following:
Which version of .NET Interactive are you using? (In a notebook, run the #!about magic command. ):
1.0.522904+cdfa48b2ea1a27dfe0f545c42a34fd3ec7119074

OS: Windows 11
Frontend: Visual Studio Code

Screenshots

In my current environment, this issue no longer exist, so I'm closing this ISSUE.
If anyone encounter the same issue, feel free to reopen it.


Switch for offline work

Is there any "switch" to turn off all http requests? Some systems doesn't have connection to outside world and gui is loading very slowly (probably because of waiting for http requests to have timeouts).

Systems, are you referring to backend or frontend?
The frontend(client PC) does some http calls to fetch external libraries, also see https://github.com/larshp/abapGit/issues/1479

Hmmm... the client PC doesn't have and internet access and the SAP system. Every refresh of the main page takes sooo long.

This is the example. If I run abapgit from SE38 It shows the code for some time even the session is responsible (blinking cursor in the transaction field).

try commenting the following line to see if it helps, https://github.com/larshp/abapGit/blob/master/src/ui/zcl_abapgit_gui_asset_manager.clas.abap#L268

Yup! that solved the issue 👍

problem is just that the icons are not shown, I would like to have custom abapGit icons, so the dependency to https://github.com/larshp/abapGit/issues/1479 can be removed

Thank you for immediate response and for help to resolve this frustrating problem 👍


Interrupt drop_idle_publisher?

Is it possible, in any way, to interrupt an active drop_idle_publisher that has not yet timed out, to accept a new incoming connection?
A lot of devices do not reconnect, if connection is closed in case of network issues. To avoid this, ill set the drop_idle_publisher to like 1 min or so. But if the same device just changes from eg. WiFi to mobile broadband, its not allowed to connect until the drop_idle_publisher times out.
Any suggestions ?

Why hasn't anyone commented on this?!? It would've been helpful for me this morning


Added convenience functions for row handling, height and improve performance for rendering

I added a function to delete all rows, get height, width in a table as my application requires loads different data sets.
Furthermore i added a constraint to only display visible content, which greatly improves renderperformance with row data (e.g. 10 kb or more)

thanks for contributing! ⚡

Hi @76creates i added further things, I'm eager for some feedback especially on 209072a

there are still pending changes

stale, closing


Communication Inclusivity: Technical Jargon Question

As I'm aligning the D&I work with the metrics repo, the question associated with this metric is not clear.

Sorry Matt, I think I see where you are going with these issues, would you mind linking the resource you are referring to, for quicker lookup?  Thank you

Hi @emmairwin. This is like Alternatives in the Communication focus area. Just a note to finalize the question.

For clarity, I'm assuming this issue refers to communication-inclusivity-technical-jargon.md

I am closing the issue as it has been labeled as a metric idea. The idea is that we can capture all metric ideas (either new metrics or additions to existing metrics). We can then look at all Metric Ideas collectively.


Fix a few links in the notebook

Related to #3522

See my updated description in the issue.
This needs to be applied to all notebooks.....

Thanks! This is good. But can you fix all links?
The String features ones also appear to be broken.

We'll fix the other ones differently. Thanks for this

Thanks for merging the PR @karlnapf. I would like to finish up fixing the rest of the notebooks.

the opencv one is the only one failing for now I think, this is due to an API change arising from re-structuring the opencv codebase....


Make a Navbar

A navbar should have these features

home
my songs
liked songs
my account (pictorial)( at rightmost )
logout

i can do that till tomorrow can you assign it to me

Hey Sam, can I continue on this?

kindly assign it to me

@AniruddhaGawali OK go for it ❤

@17rawat @CoderRedwing you can raise another issue and then asking for assigning 👍


Date range input: Clicking on the second date field opens the first one

I don't know if it's something we want but there's an other way to do a date range in only one input. https://github.com/kekeh/angular-mydatepicker/wiki/limit-date-range
This solution seems to be the perfect one because as we can't give an other dp.name to the calendars than "angular-mydatepicker".
Otherwise, we can use angular material which can be a more efficient and strong way because more stable than the date-picker package
https://material.angular.io/components/datepicker/overview


clipboard: api to list supported types, reading and writing markup

Fixes #1729
Have removed has(format) api , since its no use with availableFormats . Also  we have a generic Read api which can read to the supported type but doesnt respond what type it is, can we remove that  and just leave with the explicit types [text, html, bitmap, rtf] ?

Thanks!


Prerequisite are not clear

[Enter feedback here] here is it mentioned: "An admin role with read/write permissions on your Azure tenant."
Is it possible to mention some roles? Admin role is very generic
Thanks

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 82f8dd20-599d-ab7f-a1db-7e2b5310abb1
Version Independent ID: 897a9588-8a69-dc64-6722-fd2c731f0f03
Content: Connect to the Emissions Impact Dashboard - Power BI
Content Source: powerbi-docs/connect-data/service-connect-to-emissions-impact-dashboard.md
Service: powerbi
Sub-service: powerbi-template-apps
GitHub Login: @rosode
Microsoft Alias: rosode

Hi @zincob, I am going to close this issue for now. Please feel free to reopen if you feel further clarification is necessary.
@gabsklad, did you or are you planning to add those examples to the doc? Thanks!


Master

Looks invalid. 0.11 is an old branch for AA12.09. Current Luci trunk will not be backported to that branch.


Release 1 : New Layout UI

Summary by CodeRabbit

New Features

Implemented a new layout for the properties panel.
Enhanced zoom functionality after importing BPMN models.
Introduced new tabs and buttons in the UI for improved navigation and modeler interaction.
Added new CSS file for extended styling options.
Updated the properties panel to automatically prioritize certain groups.

Style Updates

Refined the appearance of the search bar, buttons, and other UI components for a more cohesive look.
Adjusted the layout and styling of the BPMN palette for better usability.
Overhauled CSS to improve readability and maintainability.

Bug Fixes

Corrected titles for Data Input and Data Output in the BPMN modeler.

Documentation

Updated charset meta tag in the HTML for better standards compliance.

Refactor

Streamlined event listeners and tab setup in the BPMN modeler for efficiency.
Simplified logic in extension helper functions for clarity.

Chores

Reorganized import statements and aligned code for better project structure.

@coderabbitai review

@burnettk , the issue of active properties panel is resolved.


Enter Improve the text at the top of the home page.

Enter Received the latest home page text from the product team.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: NVasilakop sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


build: Add verify-release script

verify-release

Builds a release from current commit
Warns if git describe does not match built version (in other words we're building from a commit that is not release tagged)
Warns if built version is not the latest GitHub or PyPI version
Errors if GitHub or PyPI release artifacts for this version do not match the built
release artifacts

This should be useful after release as any developer (or a CI job) can
easily verify that the release matches the sources in git.
Note that the last checks currently fail as the 1.0 build was not
reproducible. They should succeed after next release.
Signed-off-by: Jussi Kukkonen<EMAIL_ADDRESS>
Some comments:

this commit adds a file to root directory, I don't like it... but I didn't know where else to put it
signatures are not checked because it's so painful. This could be a future improvement if someone has good ideas...
if the release files do not match, there is an error but no details are printed and the downloaded files are not left available: I did not want to add this complexity to the script

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 98.312%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1179

Relevant Lines:
1195

💛  - Coveralls

Issue is fixed. The testing is obviously not quite 100.0% (since we dont have a positive test case on pypi.org yet) but I have done the manual testing I could.


Infrastructure as code for (temporary) GCP Services?

When creating infrastructure like the GCP pub/sub message queue and spinning up any managed database instances - do we want to do this manually in the GUI for each environment (test/staging/production) or do we want to use something like terraform to make this more consistent and well defined?

Do we have the necessary skills in the team to support a tool like terraform? And if so, who's responsible for maintaining it?
Will there be problems if we use terraform but no one else in IDP-D does? Will we end up ruining/deleting their configurations? Would we need a separate cloud instance?

@SyedZulfikarAH @scheung38 Did you guys decide on the best approach for this when configuring the GCP pub/sub queues?

Hi Rob, so far everything has been helm/kubectl/gcloud
from cluster creation, update, patches, installations of k10 backup/restore,
installation of CICD ArgoCD/Devtron for auto CD from docker pushed to Kubernetes cluster automation.
Installation previously for Jenkins was also helm based.
Now testing PubSub with Python client also didn’t use terraform. So never had to terraform for all these config and source code to repo.
Sent from my iPhone

On 20 Jan 2022, at 11:33, Rob B @.***> wrote:

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.


Save moves Current to Default

Issue: Save Current color scheme changes the Current selection to Default.
I like to make one adjustment,  apply,  save, then make another.   But,  it auto switches to default scheme, so my next change is applied to 'custom' instead - and I have to find the tab again to continue working.  IMO the scheme and tab I'm working on should remain in focus.

Select Halloween
Select Buttons
Change "Default hue' to a cyan color
Apply
Observe 'Current color scheme' remains on Halloween (good)
Save
Observe 'Current color scheme' switched to Default,  (and 'Buttons' is no longer in focus!)
Click Buttons (assuming we're still on Halloween, we're not!)
Set Hue to Orange
Observe 'Current color scheme' switched to Custom (?!)
Apply
Observe Save button missing (no need to save custom, but this seems weird)
Select Halloween
Observe that Button hue is not Orange.
Set Hue to Orange (again...)
Apply/Save
Observe Scheme Default again...

Did I make that Orange 15 or Orange 21?  I'll have to click a few times to get back to that page!

You should not press Apply before color scheme is saved otherwise it will create custom unnamed color scheme and loose reference to the original color scheme you were editing. It is dome because people asked to be able to apply custom color scheme on a particular website without necessity to add this color scheme to the global list.

   I use ctrl-z all the time, not sure if it's possible here...

Midnight Lizard does not keep track of all changes so there is no way to undo changes. But you can export color schemes in order to back them up.


build: adjust linking for Crypto

The package DLL Crypto.dll was building the BoringSSL wrapper (CryptoBoringWrapper) in the style that the user requested (static or shared).  However, there is a single user of the library and is not directly included by the SPM client.  Furthermore, the library was not setup for installation which makes redistribution of it impossible. Always build the library in a static mode to allow compaction into the Crypto target.

CC: @yim-lee @tomerd

@compnerd Is this change required for https://github.com/apple/swift-package-manager/pull/5920?

I think that it will be needed, otherwise we will not be able to use the swift-package bits due to missing files.

@Lukasa Can we merge this and cut a new release so we can update SwiftPM? Thanks.

2.2.3 released.


Temperature/Humidity/Luminance not updating values in HA

Describe the bug
I have a Temperature/Humidity/Luminance sensor installed. HA recognizes the device and its initial state values, but they do not refresh or update, so the information cannot be used for automation or information.
Expected behavior
Temperature/Humidity/Luminance value changes should be shown in real time and accurately.
Screenshots
If applicable, add screenshots to help explain your problem.
Home Assistant Version
Home Assistant 2021.6.6
Device info (please complete the following information, which can be found in log):
"active_time":<PHONE_NUMBER>,
"biz_type": 18,
"category": "wsdcg",
"create_time":<PHONE_NUMBER>,
"icon": "smart/icon/ay1503986080106Gppjy/04b538bf5c86c8394ed187d0941ae8af.png",
"id": "eb4f18af23046ad23bzhbd",
"ip": "",
"lat": "4.6578628",
"local_key": "0b41a35230b5a4d2",
"lon": "-74.1133391",
"name": "Sensor Estudio",
"node_id": "b4e3f9fffe0c4a50",
"online": true,
"owner_id": "13892437",
"product_id": "qaaysllp",
"product_name": "Temperature Humidity Sensor",
"status": [
{
"code": "va_temperature",
"value": 234
},
{
"code": "va_humidity",
"value": 528
},
{
"code": "battery_percentage",
"value": 20
},
{
"code": "temp_unit_convert",
"value": "c"
},
{
"code": "maxtemp_set",
"value": 40
},
{
"code": "minitemp_set",
"value": 10
},
{
"code": "maxhum_set",
"value": 90
},
{
"code": "minihum_set",
"value": 20
},
{
"code": "temp_alarm",
"value": "cancel"
},
{
"code": "hum_alarm",
"value": "cancel"
},
{
"code": "bright_value",
"value": 42
}
],
"sub": true,
"time_zone": "+08:00",
"uid": "az1580355797792RnGLw",
"update_time":<PHONE_NUMBER>,
"uuid": "eb4f18af23046ad23bzhbd"
},
Device specifications (please complete the following information, which can be found in log):
}
2021-07-07 19:40:43 DEBUG (SyncWorker_5) [tuya iot] Request: method = GET, url = https://openapi.tuyaus.com/v1.0/devices/eb4f18af23046ad23bzhbd/specifications, params = None, body = None, headers = {'client_id': 'cyaqesnvaqg46x4g1ekm', 'sign': '54702BEC2D003038F303DCF4783A9E9154AA3D9B3DBD1755BD9813F959D45C15', 'sign_method': 'HMAC-SHA256', 'access_token': 'XXX---XXXX', 't': '1625704843895', 'lang': 'en'}
2021-07-07 19:40:44 DEBUG (SyncWorker_5) [tuya iot] Response: {
"result": {
"category": "wsdcg",
"functions": [
{
"code": "temp_unit_convert",
"type": "Enum",
"values": "{"range":["c","f"]}"
},
{
"code": "maxtemp_set",
"type": "Integer",
"values": "{"unit":"℃","min":-10,"max":60,"scale":0,"step":1}"
},
{
"code": "minitemp_set",
"type": "Integer",
"values": "{"unit":"℃","min":-10,"max":60,"scale":0,"step":1}"
},
{
"code": "maxhum_set",
"type": "Integer",
"values": "{"unit":"%","min":0,"max":100,"scale":0,"step":1}"
},
{
"code": "minihum_set",
"type": "Integer",
"values": "{"unit":"%","min":0,"max":100,"scale":0,"step":1}"
}
],
"status": [
{
"code": "va_temperature",
"type": "Integer",
"values": "{"unit":"℃","min":-100,"max":600,"scale":1,"step":1}"
},
{
"code": "va_humidity",
"type": "Integer",
"values": "{"unit":"%","min":0,"max":1000,"scale":1,"step":1}"
},
{
"code": "battery_percentage",
"type": "Integer",
"values": "{"unit":"%","min":0,"max":100,"scale":0,"step":1}"
},
{
"code": "temp_unit_convert",
"type": "Enum",
"values": "{"range":["c","f"]}"
},
{
"code": "maxtemp_set",
"type": "Integer",
"values": "{"unit":"℃","min":-10,"max":60,"scale":0,"step":1}"
},
{
"code": "minitemp_set",
"type": "Integer",
"values": "{"unit":"℃","min":-10,"max":60,"scale":0,"step":1}"
},
{
"code": "maxhum_set",
"type": "Integer",
"values": "{"unit":"%","min":0,"max":100,"scale":0,"step":1}"
},
{
"code": "minihum_set",
"type": "Integer",
"values": "{"unit":"%","min":0,"max":100,"scale":0,"step":1}"
},
{
"code": "temp_alarm",
"type": "Enum",
"values": "{"range":["loweralarm","upperalarm","cancel"]}"
},
{
"code": "hum_alarm",
"type": "Enum",
"values": "{"range":["loweralarm","upperalarm","cancel"]}"
},
{
"code": "bright_value",
"type": "Integer",
"values": "{"unit":"lux","min":0,"max":1000000,"scale":0,"step":1}"
}
]
},
"success": true,
"t":<PHONE_NUMBER>996
}
Additional context
Add any other context or logs about the problem here.

I forgot to mention that the device is connected through a Zigbee Gaeteway. Does this affect?

I forgot to mention that the device is connected through a Zigbee Gaeteway. Does this affect?

Do your devices show as offline in the Tuya IoT Platform? I've got a similar issue to you and i feel like it has something to do with the fact that the devices show offline until they go online for a split second, talk back to the hub and then the hub does the updating, then they go back offline again.

I forgot to mention that the device is connected through a Zigbee Gaeteway. Does this affect?

Do your devices show as offline in the Tuya IoT Platform? I've got a similar issue to you and i feel like it has something to do with the fact that the devices show offline until they go online for a split second, talk back to the hub and then the hub does the updating, then they go back offline again.

Hello. No, they show online. The original TUYA integration didn't recognize the device, so I couldn't use it for automations.
With Tuya 2 integration I was happy because the devices are now supported... bad luck they do not update.
All I want is for HA to turn on the lights automatically when lux levels are low... :(

I just noticed that my Tuya Contact/Door sensors are not updating automatically. Checking other issues posted... I think is a generalized problem with sensors.

@sanshengshui https://github.com/tuya/tuya-home-assistant/discussions/113

Digging a little deeper... I also noticed that all my status devices do not update. I can control them, but the device/entity status always remain the same. So right now, according to HA, my door is always closed, my robot is always cleaning, my curtains are always closed... and my luminance level is always 100 lux.. I guess the issue is not only with sensors states.

@sanshengshui #113

Perfect. That was it. Thanks for the heads tip.


WIP: Barplot enhancements

I've been using this code for many months (I used this branch when doing the recent JASA plots) so I think it's pretty safe, but I want to double-check that the tests are adequate before giving the go-ahead for merge.  Feel free to review the code changes now though.

This all looks reasonable to me, and we can iterate in master if we find problems in use later

Ahh crap, just noticed that it was WIP. Sorry about that... feel free to beef up tests in a subsequent PR if the current ones are inadequate.


bugfix: fix the failure of RemotingParser to prevent AT mode from executing

[ ] I have registered the PR changes.

Ⅰ. Describe what this PR did
fix the failure of RemotingParser to prevent AT mode from executing
Ⅱ. Does this pull request fix one issue?

fixes #6407
fixes #6408
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

Codecov Report
Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 48.67%. Comparing base (6b7e1e1) to head (616e057).

Additional details and impacted files

@@              Coverage Diff              @@
##             develop    #6409      +/-   ##
=============================================
+ Coverage      48.42%   48.67%   +0.24%
- Complexity      4157     4172      +15
=============================================
  Files            794      794
  Lines          28084    28087       +3
  Branches        3426     3426
=============================================
+ Hits           13601    13672      +71
+ Misses         13054    12981      -73
- Partials        1429     1434       +5

Files
Coverage Δ

.../rm/tcc/remoting/parser/DefaultRemotingParser.java
22.98% <0.00%> (-0.83%)
:arrow_down:

... and 13 files with indirect coverage changes


是否支持对GPT2的lora微调

Reminder

[X] I have read the README and searched the existing issues.

Reproduction
是否支持对GPT2的lora微调
Expected behavior
No response
System Info
No response
Others
No response

支持


Subsites return 404 on every request

Main domain - company.example.com
Created a sub site with host as company.example.com/nz
Created a new page with parent as NZ site, but every page comes up with 404 error.

You'll need to create it as a subdomain (or separate domain), not as a separate path.
In other words - nz.company.example.com instead of company.example.com/nz

Thanks. Do you know of any module which creates subsites as sub directories just like wordpress environment does?

Thank you for your contribution here. I just wanted to let you know that we’re looking to improve our management of issues and pull requests, with a goal to providing clear direction on how Symbiote contributes to the open source community. As part of this ongoing effort:

issues and pull requests that have been open prior to December 2017 with no recent activity are being closed

this is included

if you can confirm this remains applicable for SS3.6+ please do open it again

remaining issues and pull requests will be

categorised

on a clear path to resolution (whatever the next step may be).

This ultimately brings us one step closer to our ambition; being able to prioritise current issues and contributions in a timely manner. If you have any questions, please see https://www.symbiote.com.au/contributing for further information.


fix: ensure strict checks are all recommended and related to

Description

strictPropertyInitialization and alwaysStrict were missing from
recommended even though the other Strict Checks were in there and all
of them are enabled if strict is enabled

alwaysStrict, strictNullChecks, noImplicitAny, and noImplicitThis were
missing from strict's relatedTo even though all are enabled if strict
is enabled

Tags
Found while working on #970.
Related to another PR I had on the topic of Strict Checks, #500
Review Notes
They're all listed as "recommended", but strict enables all of them and is the only one turned on in @tsconfig/recommend and by tsc --init, so maybe all of them should be removed from "recommended" except for strict instead? Thoughts?

I'm in favor of this change, I agree that it could encourage redundant tsconfig entries ( which does make me wonder if we could make a page which helps you trim / understand your tsconfig visually #972  ) but I think it helps folks who aren't going to jump straight to strict

but I think it helps folks who aren't going to jump straight to strict

Doesn't the relatedTo help with that or the "Default false, unless strict enabled" handle that case?

I'm in favor of this change, I agree that it could encourage redundant tsconfig entries

TSDX itself had that too until I fixed it in https://github.com/formium/tsdx/pull/475. And I didn't notice the templates had them too until a user pointed it out in https://github.com/formium/tsdx/issues/619 and I fixed in https://github.com/formium/tsdx/pull/673, https://github.com/formium/tsdx/pull/690. The draft PR for monorepo template has redundancies https://github.com/formium/tsdx/pull/778#discussion_r457492085.
That is to say it seems to be super common with TS users and a lot don't seem to know how all the options work (e.g. paths and baseUrl too). Though I'm sure you've experienced the latter too.

( which does make me wonder if we could make a page which helps you trim / understand your tsconfig visually #972 )

Yea that could be pretty helpful if enough folks know of it and use it. I was thinking a tsc --trim command or something. Or other ways of recommending config -- I think the bases repo definitely helps as a reference point.


Bump prometheus/client_golang to v0.9.3

It should help to get https://github.com/prometheus/client_golang/pull/568 in the next release.

Closing as @beorn7 will pack it with the tsdb update.


[Storage] V4 Signature POST Policies

Tracking issue for work defined in companion document.
GCS - POST with SigV4

Closed by #2750, #2803.


Support switching Issuer on Certificate resource

Currently, the check for Certificate validity only takes into account the start/expiry date on the Certificate. Therefore, if a user were to update the Issuer field on a Certificate resource (e.g. to switch from letsencrypt-staging to letsencrypt-prod), cert-manager would still see the Certificate as valid.
By adding a Verify(Certificate) (bool, error) method to the Issuer interface, we should be able to support arbitrary additional certificate verification on a per-issuer basis. This would allow an Issuer to 'force' a Certificate to be re-issued.
Relevant tweet: https://twitter.com/lmarsden/status/901095129045499904

/lifecycle frozen

This is an issue that we just tripped over, but it looks very old.  Is there now a different approach to this?

Is there any way to use letsencrypt-prod? (it was letsencrypt-staging)
I've changed acme server to https://acme-v02.api.letsencrypt.org/directory in order to issue new prod certificate, but nothing changed. I've tried to recreate issuer and certificate (kubectl delete & kubectl apply) but staging certificate is still used. Also there are no events in certificate (kubectl describe certificate cert) in this case.
Any ideas?


create simple intermediate gui endpoints for resetpassword, change email ect that build the dto

show reset pass endpoint needs to get code as url param and append code to form post request to reset pass endpoint

can only send dto url encoded in body, would like to have json body

switch to js and send post request with json body with it

modify resetPassword tests


Fix checkstyle warnings

Moving toward CSS issue #1055
Reduces checkstyle warnings from 2926 to 577

@berryma4

Further clean-up of the test classes reduces checkstyle warnings to 12.


Add generic banner infrastructure

Builds on https://github.com/reactjs/reactjs.org/pull/3275.
This adds generic infra so that we can run banners similar to the Black Lives Matter banner we've been running from June to September. It has a few enhancements compared to the original one:

All styling changes are centralized so we won't have problems with the banner breaking the layout.
The banner can now be dismissable (the setting is kept in localStorage).
Its height can be customized in a single place.

For now I'm commenting out the actual banner, so it's not on by default. To review, you'll need to comment it out in BannerContextManager. I have a stub there but it's unstyled. We'll replace it with a new banner when there is an occasion.

Thanks for extracting this! I've got a survey banner to go up!

(Also, @rickhanlonii, I'll make the change you suggested and push it separately :)


Pretty URLs

Evaluation if I can implement the use of pretty URLs like https://perlite.secure77.de/folder name/note name

I badly need this!
Can we also please implement Open Graph? OG markup can be implemented using content from the YAML front matter.
At the very least, can we please have the page title in the main HTML  tag?
What we now have is a generic Perlite text in all the page titles, which I presume is due to the way iframes are used.
Thanks as always.

Hey @rsubr

Can we also please implement Open Graph? OG markup can be implemented using content from the YAML front matter.

Open Graph is already implemented, you can define the settings via variables, take a look at: https://github.com/secure-77/Perlite/wiki/03---Perlite-Settings#social-media-settings
you can see them for example here: view-source:https://perlite.secure77.de/
However, these are fixed for the setup and not yet variable for each note. Defining them via the frontmetter is a good idea, I will check if I can implement it

At the very least, can we please have the page title in the main HTML  tag?

This is already implemented, the Title will be updated after clicking to a note as following:   $("title").text(title + ' - ' + $("p.vault").text() + ' - ' + $("p.perliteTitle").text());
for example it looks like this for Markdown Samples <title>Markdown Samples - Demo - Perlite</title>

What we now have is a generic Perlite text in all the page titles, which I presume is due to the way iframes are used.

As above explained, this isn't the case. Also the page doesn't use iframes at all, the content is updated via javascript and ajax calls.


Contact avatars aren't showing up (nightly)

Is this fixed?

I haven't had this issue in a while. I think I'm going to close it until further notice.

Ran into this issue again. Re-opening. Happened when opening from fully closed via a notification

Yeah I'm gonna fix this today

I got this.

Fixed. ContactAvatarWidget needed to use getCachedContact() instead of getContact()


TextField not getting onSubmitted callback - Flutter Web

TextField not getting submitted on Android Chrome.  Works just fine on Desktop chrome (though no OS keyboard) and Android native.
Setup
Add a single TextField with an onSubmit:
 TextField(
              controller: controller,
              autocorrect: false,
              enableSuggestions: false,
              maxLength: 5,
              autofocus: false,
              textInputAction: TextInputAction.search,
              onSubmitted: (String text) {
                setState(() {
  /// do stuff with `text`!

Expected
When hitting "enter" on the keyboard, the keyboard is dismissed and the input fed to onSubmitted.
Actual

Keyboard remains
onSubmitted never called
"suggestions" above input flicker

Horrible work around
Click on the first suggestion; then click enter. This produces the desired outcome.

  flutter doctor
[√] Flutter (Channel master, 2.10.0-1.0.pre.307, on Microsoft Windows [Version 10.0.19044.1586], locale en-US)
[√] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
[√] Chrome - develop for the web
[√] Visual Studio - develop for Windows (Visual Studio Community 2019 16.11.2)
[√] Android Studio (version 2020.3)
[√] VS Code (version 1.65.2)
[√] Connected device (4 available)
[√] HTTP Host Availability

• No issues found!

Hi @jtmcdole, there's a similar issue already open describing what you're experiencing in https://github.com/flutter/flutter/issues/89384. Kindly follow up there for updates.
Closing from here as duplicate.
Thank you


NoClipsFound exception

I receive this error when trying to run TwitchTube, just 3 weeks ago it worked fine, and i also checked and it should have more than enough clips to work with.
Traceback (most recent call last):
  File "/home/romek/yt-automation/twitch_main.py", line 80, in <module>
    make_video(**parameters)
  File "/home/romek/yt-automation/twitchtube/video.py", line 138, in make_video
    raise NoClipsFound("Did not find any clips")
twitchtube.exceptions.NoClipsFound: Did not find any clips

This is 2 things in my config that i think are relevant, the video only needs to be 4 minutes and from one of the most popular and active "Games" on twitch so i think the problem isnt really that it couldn't find any clips.
VIDEO_LENGTH = 4  # Minimum video length in minutes (doesn't always work)
DATA = ["g Just Chatting"]

Could someone point me in a direction on what else i might be missing?

Regen your token
https://github.com/offish/twitchtube#creating-your-twitch-application


Initializer does not override a designated initializer from its superclass

I got this error after updated xcode 6.3.1.
/Users/MNurdin/Documents/iOS/xxxxx/Pods/CVCalendar/CVCalendar/CVCalendarView.swift:112:14: Initializer does not override a designated initializer from its superclass

This code
 override init() {
        super.init() //error here

        hidden = true
        loadCalendarMode()
        contentController = CVCalendarContentViewController(calendarView: self, frame: bounds)
    }

+1
Same here,
Got this issue right after i updated my XCode to 6.3.1 .
The readme says this project supports Swift 1.2 .
So this should not happen right?

Hello @datomnurdin,
You're using the outdated CVCalendar version from the master branch. The most recent code is pushed to the develop branch. By the way I've updated the README document which says:

GLOBAL CHANGES

The project is currently being under an active maintenance. We're going to bring a lot of new features  as well as fix all bugs and optimize the library to make it incredibly efficient and fast (see the full list). API isn't changed so you don't pay anything for the update. The code can be found in this branch. It supports Swift 1.2.

Note that the code directory is: CVCalendar-develop / CVCalendar Demo / CVCalendar.
In case of any issues or questions leave a comment here.
Regards,
Eugene


[T4A7][T09-A1] Ken Oung Yong Quan

Ready for review

Accepting this PR without a review because another of your PRs for this tutorial was reviewed in detail.


Provide configuration parameter to set samtools sort memory per thread

The user doc has a section on Troubleshooting: samtools sort: couldn't allocate memory for bam_mem...
If using more than one process (nprocesses > 1) you might get the error:
samtools sort: couldn't allocate memory for bam_mem

This leads to a failure to create .bam and .bam.bai files.
In this case, you may need to explicitly set the amount of memory per thread in calls to samtools sort.
Check how much free memory you have e.g.
$ free --mega
              total        used        free      shared  buff/cache   available
Mem:           2017         684        1028           2         303        1181
Swap:           969         619         350

Divide the free memory by the number of processes, nprocesses e.g. 1024/4 = 256 MB.
Edit riboviz/workflow.py and change the lines:
cmd_sort = ["samtools", "sort", "-@", str(run_config.nprocesses),
            "-O", "bam", "-o", bam_file, "-"]

to include the samtools flag -m <MEMORY_DIV_PROCESSES>M e.g.:
cmd_sort = ["samtools", "sort", "-@", str(run_config.nprocesses),
            "-m", "256M",
            "-O", "bam", "-o", bam_file, "-"]

...this involves the user editing the source code which is not good! Add support for a configuration parameter (samtools_memory: <MEMORY>). If this configuration flag is present then add -m <MEMORY> to the samtools sort call.

Is this something that's worth fixing for the nextflow method rather than python (since we're now moving to Nextflow as the main method after riboviz version 2.0)?
Perhaps something to do after specifying nprocesses for cutadapt in #216 ?


Reconnecting accounts still include authCode in logOn request.

When signing into a Steam Guard protected account without a sentry file or authCode.
debug: connected
debug: encrypt request
debug: handshake complete
debug: logon fail: 63, sessionID: 8359443
error: Error: Logon fail: 63

Logging in again after providing the authCode in logOnDetails.
debug: connected
debug: encrypt request
debug: handshake complete

Some time later the connection to Steam is lost. authCode is still present in the logOnDetails so the account will never reconnect. (#77)
debug: socket ended
debug: socket closed
debug: connecting to <IP_ADDRESS>:27019
debug: connected
debug: encrypt request
debug: handshake complete
debug: logon fail: 65, sessionID: 5654491
error: Error: Logon fail: 65

I suspect dropping authCode and adding shaSentryfile to .logOnDetails once connected would work but I wonder if there's a better way.

Could authCode be deleted in the sentry event?

This won't work if the user logs on with both authCode and shaSentryFile, as there would be no sentry event.
It could delete authCode immediately if shaSentryFile is present and otherwise wait for sentry, but I don't like such inconsistency.
I will try to trigger a disconnection with an actual Steam client and see what it does when I have time. (Or maybe someone else can do it)

node-steam master no longer auto-reconnects, so this no longer applies.


Backport reindex rethrottle to 2.x

See https://github.com/elastic/elasticsearch-net/pull/2083

Now Elasticsearch 2.4 is out we can backport it

merged into 2.x in #2278


LSP: diagnostics for files opened in the editor are not updating correctly on Windows

The Sprocket VSCode extension on Windows is not working correctly.
When a file is opened in the editor, the current set of diagnostics for the file (correctly) remains unchanged. However, if the file's buffer becomes dirty, the diagnostics disappear completely and remain cleared until the file is closed.
There also appears to be quite a few requests for the file's diagnostics, which are completing in < 10us, presumably with an empty set of diagnostics.

So the document URI being received on Windows from the LSP client has a percent-encoded : in the file path, e.g. file:///C%3A/....
This is tripping up the resolution of the document in the document graph as it was added to the graph with URI file:///C:/....
The fix is to normalize what's coming from the LSP client.

Additionally, the requests from VS Code are sending lowercase drive letters, whereas Rust paths are using upper case drive letters.
It looks like RA fixed this by also normalizing what's coming it from VS Code to have upper case drive letters.


Crestron component doesn't load - missing version key

"The custom integration 'crestron' does not have a valid version key (None) in the manifest file and was blocked from loading. See https://developers.home-assistant.io/blog/2021/01/29/custom-integration-changes#versions for more details"
"The version key is required from Home Assistant version 2021.6"
This cost me a couple hours of frustration.
Just add a version key in the manifest.json and it will load properly

Updated the manifest.json starting with version 0.2.4

Updated the manifest.json with the correct key starting with version 0.2.4


Horizontal description list lacks sufficient left-hand margin/padding

On small screens, horizontal description lists http://v4-alpha.getbootstrap.com/content/typography/#horizontal-description are flush against the left edge of the viewport.

Do we really need .dl-horizontal anymore? Seems like just using .row would be logical, and it doesn't suffer from this rendering problem.

Seems like just using .row would be logical

I'd buy that for a dollar. Would it be sufficient to replace the classname in place on the existing documentation, or would that look weird (as the rest of the section on lists has special classes)? I think it would be good to document this usage of rows and cols, so completely removing this would probably be too confusing...

The flushing against the left edge of the viewport is due to the .dl-horizontal (or .row now) now wrapped in the required .container.
I also wonder if using grid classes in stead of .horizontal-list, .horizontal-list-item etc, ... is consistent with the bootstrap4 strategy for class naming which should make your HTML more flexible while bringing along increased extensibility. But i do understand that the ability to use grid classes for sizing is very flexible.
Using grid classes also introduces the ""problem" of having grid columns in the row taller than the next one, see the picture below:

According to http://www.the-art-of-web.com/css/format-dl/ to above can be fixed when applying the CSS code beneath (clearfix variant);
  clear: left;
}
dt::after {
  content: "";
  display: table;
} ```

Closing, as the original problem with the left-hand margin/padding has been addressed.


sam local start with custom template is not working as expected

I have a custom template created and i gave below command to start sam locally
sam local start-api --template .\templates\new-template.yaml
in this case, I am getting no module name *** error. Basically some problem with the deployment
Observed below while using template

Building image...
Requested to skip pulling images ...
Mounting <folder containing lambda> as /var/task:ro,delegated inside runtime container

while if i have the same template as "template.yml" and start the same with "sam local start-api".
I observe below

Building image...
Requested to skip pulling images ...
Mounting .aws-sam\build<lambda_name> as /var/task:ro,delegated inside runtime container

I have a windows 10 machine and using 0.52 version of sam.

Hi @swamigmv,
Can you please share your template with us? I tried same thing and it worked for me. Please see my logs below:
❯ sam build -t templates/new-template.yaml
Building function 'HelloWorldFunction'
Running PythonPipBuilder:ResolveDependencies
Running PythonPipBuilder:CopySource

Build Succeeded

Built Artifacts  : .aws-sam/build
Built Template   : .aws-sam/build/template.yaml

Commands you can use next
=========================
[*] Invoke Function: sam local invoke
[*] Deploy: sam deploy --guided

❯ sam local start-api -t templates/new-template.yaml
Mounting HelloWorldFunction at http://<IP_ADDRESS>:3000/hello [GET]
You can now browse to the above endpoints to invoke your functions. You do not need to restart/reload SAM CLI while working on your functions, changes will be reflected instantly/automatically. You only need to restart SAM CLI if you update your AWS SAM template
2020-07-17 14:08:32  * Running on http://<IP_ADDRESS>:3000/ (Press CTRL+C to quit)

My templates/new-template.yaml:
AWSTemplateFormatVersion: '2010-09-09'
Transform: AWS::Serverless-2016-10-31
Description: >
  issue-2073

  Sample SAM Template for issue-2073

# More info about Globals: https://github.com/awslabs/serverless-application-model/blob/master/docs/globals.rst
Globals:
  Function:
    Timeout: 3

Resources:
  HelloWorldFunction:
    Type: AWS::Serverless::Function # More info about Function Resource: https://github.com/awslabs/serverless-application-model/blob/master/versions/2016-10-31.md#awsserverlessfunction
    Properties:
      CodeUri: ../hello_world/
      Handler: app.lambda_handler
      Runtime: python3.8
      Events:
        HelloWorld:
          Type: Api # More info about API Event Source: https://github.com/awslabs/serverless-application-model/blob/master/versions/2016-10-31.md#api
          Properties:
            Path: /hello
            Method: get

Closing.
Feel free to reopen is there is further information or issue.


Backport of 2739 in stable-3.1

Backport of #2739 in stable-3.1

jenkins test luminous-ansible2.4-ooo_collocation

jenkins test luminous-ansible2.4-ooo_collocation


Upgrade jshint version to 2.8.0

2.8.0 version contains improvements related to ES6 syntax. So, think it's worth to upgrade it. For instance I need module option

We're on 2.9.6, now....


External OAuth2 works for login once, but shows login page again after reopening browser

Gitea Version
Docker image ( 1.15.4 built with GNU Make 4.3, go1.16.9 : bindata, timetzdata, sqlite, sqlite_unlock_notify )
Git Version
2.30.2
Operating System
Docker, Ubuntu 21.10
How are you running Gitea?
  gitea:
    restart: always
    image: gitea/gitea:latest
    environment:
      GITEA__database__DB_TYPE: sqlite3
    ports:
      - 3000:3000
    volumes:
      - ./_data:/data

Database
SQLite
Can you reproduce the bug on the Gitea demo site?
Yes
Log Gist
https://gist.github.com/darkguy2008/56599c6f4ea65056b30196856d6c4c00
Description
What the title says, using OAuth login works during a browser session. Once you close the browser and go to the gitea site again, it shows the homepage asking you to login again. Doesn't make sense if I'm already logged in? I have other apps in the same server (i.e. Outline, DroneCI, etc.) and they don't have this behavior.
It works as intended if I do it within the same browser session (a new tab) but if I fully close Chrome and open it again, I get the login page.
Screenshots
Nothing special, just logging in using the OpenID provider:

Same issue using gitea 1.16.0 and authentik as OAuth2 provider

Should we remember the device for some days?

@lunny for sure! This bug even sparkled my interest in making my own OAuth2 provider with auto-remember feature, so I could just click the "Sign in with OpenID" icon, and after a couple refreshes I'm back in.
There was someone in the Discord channel by the name of "Melonie" who made a fix for this, but back then (and now) didn't have much time to spend making a PR, but here's a screenshot about the code he/she wrote:

Maybe it's useful?
But yeah, it would be really cool if Gitea can remember the OpenID auth, it's a bit confusing to log in everytime you open a new browser instance/window.

I thought an OAuth2 login should honour SESSION_LIFE_TIME.

If we start remembering we really need to check the grant that comes back from the oauth provider to see how long they're willing to give us a grant for.
I also wonder how often we're supposed to poll the oauth provider to ensure that we're still logged in

yup I suspect we should be following the refresh/expiry part of the spec properly - which is something we're not doing at present.


If IgnoreCollectionOrder is true then it does not consider 'AttributesToIgnore' while matching list of a item

If IgnoreCollectionOrder is true then it does not consider 'AttributesToIgnore' while matching list of a item

Thank you for reporting this issue.

Please create a fix with a unit test.

@GregFinzer ...I am getting while pushing the changes
"Error encountered while pushing branch to the remote repository: Git failed with a fatal error.
Could not read from remote repository.
Please make sure you have the correct access rights
and the repository exists."
I think I don't have access.

Please create a pull request.

I am not able to push the branch

https://docs.github.com/en/free-pro-team@latest/github/collaborating-with-issues-and-pull-requests/creating-a-pull-request

Do I have write access?

I always get 'Permission to GregFinzer/Compare-Net-Objects.git denied to mahendra25aug', whenever I try to push a branch

@mahendra25aug I am not giving you write access to check directly into the master branch.  You will need to create a pull request.  Everyone in the world has access to create a pull request.

To create a PR, I need to push a branch...but when I push a newly created branch , I get 'Permission to GregFinzer/Compare-Net-Objects.git denied to mahendra25aug'. I am not sure what I am doing wrong here.
Is there a way to create a PR without pushing the branch?


RTL Toggle - It is toggled off after changing tabs.

RTL Toggle - If RTL is toggled on and the user change the tab and return to RTL tab, the toggle turns off, but the component remain in RTL.
It is happening for all components.
Browsers: Chrome, Safari, FF
I found this during some test on storybook of Maximo React Component and could reproduce it in Carbon because we are using Carbon (10)
Steps to reproduce the issue

Enter this url: http://react.carbondesignsystem.com/
Select any component
Select "RTL" tab
Turn on the Left-to-right toggle
Note that component is now RTL
Change to another tab. For example "Readme" tab
Return to "RTL" tab

Actual Result:  Left-to-Right is toggled off, but the component remains in RTL.
Expected Result: Left-to-Right Toggle should remains selected after the user change to other tab and then returns to RTL
Workaround to really toggle off the RTL after the action above: The user select toggle on again, then toggle off.

Duplicate of: #2314.


chore: update orchestrator proto definition

Description

The protobuf definitions needed an update after the recent changes to the compute plan and model services.
How has this been tested?

e2e.

/e2e --mode=standalone --refs orchestrator=SUB-22-remove-delete-intermediary-model-property-from-the-compute-plan-protobuf-message-2

End to end tests: :hourglass_flowing_sand: STARTING


Improve marketplace listing

Describe your use-case which is not covered by existing documentation.
Listing: https://plugins.jetbrains.com/plugin/1885-jenkins-development-support/

Features on the marketplace, too high level right now
Add screenshots

Maybe gif?

Improve getting started section

Plugin description is taken from the README.
Most of the rest of it is uploaded directly in the marketplace UI.
All text formatting is done with HTML
Pictures can't have alt+text or captions so any text must be manually overlayed.
Reference any relevant documentation, other materials or issues/pull requests that can be used for inspiration.
https://plugins.jetbrains.com/docs/marketplace/best-practices-for-listing.html#plugin-description
Look at other listings for inspiration: https://plugins.jetbrains.com/
Are you interested in contributing to the documentation?
No response

I've uploaded some images.
I've used 48pt Arial added with https://jspaint.app/

I've added an initial getting started section

cc @janfaracik in case you have any ideas

I added the community forum link: https://community.jenkins.io/


Adding Keyboard Manager Features

Description of the new feature / enhancement
Please add keyboard manager activation shortcuts.
Mouse Manager is convenient because you don't have to exit the program or click the activation button through the activation shortcut.
The keyboard manager does not have an activation shortcut, so it is inconvenient to turn off the exit or activation buttons directly each time.
Scenario when this would be used?
It is inconvenient to turn off the keyboard manager every time I have to change the key when I need to rewrite it while I am using a keyboard with a different arrangement.
Supporting information
No response

hi @krlee9334. i understand your frustation but i think you might find the better customisability of ahk(auto hot key) to be better suited for your needs. if you decide to go down this route and need help, i'm more than happy to offer help with it.

Please help me customize the ahk(auto hot key).
-----Original Message-----
From: @.>
To: @.>;
Cc: @.>; @.>;
Sent: 2023-03-09 (목) 19:14:40 (GMT+09:00)
Subject: Re: [microsoft/PowerToys] Adding Keyboard Manager Features (Issue #24694)
hi @krlee9334. i understand your frustation but i think you might find the better customisability of ahk(auto hot key) to be better suited for your needs. if you decide to go down this route and need help, i'm more than happy to offer help with it.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: @.***>

you'll want to download autohotkey and vs code(with autohotkey plus plus extension). this section on the ahk docs is probably what you're looking for https://www.autohotkey.com/docs/v1/misc/Remap.htm.

You can use system tray flyout (left-click once PowerToys icon), then navigate to "More" and you can enable/disable PowerToys modules

/dup #4879


Replication task processor shutdown improvements and start/stop unit tests

What changed?
Replication task processor was not waiting for underlying goroutines when stopped. Added a waitgroup to fix that and validated with a unit test using goleak.VerifyNone
Also added similar leak check in history engine's start/stop test.

Why?
Improve shutdowns and code coverage

How did you test it?
unit test

Pull Request Test Coverage Report for Build 018f5bab-298d-44df-b8e1-67f02e0ff1df
Details

19 of 20 (95.0%)  changed or added relevant lines in 1 file are covered.
83 unchanged lines in 12 files lost coverage.
Overall coverage decreased (-0.02%) to 68.676%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

service/history/replication/task_processor.go
19
20
95.0%

Files with Coverage Reduction
New Missed Lines
%

service/history/queue/timer_queue_processor_base.go
1
77.66%

service/matching/taskReader.go
2
84.88%

common/persistence/execution_manager.go
2
83.74%

common/util.go
2
91.78%

service/history/execution/mutable_state_builder.go
2
71.29%

common/persistence/statsComputer.go
2
96.07%

service/history/task/task.go
3
84.81%

common/task/fifo_task_scheduler.go
3
84.54%

service/history/task/timer_active_task_executor.go
3
79.33%

service/history/task/fetcher.go
4
85.05%

Totals

Change from base Build 018f5aff-b7c8-4ac8-9e0c-a14d52f0ae0a:
-0.02%

Covered Lines:
100889

Relevant Lines:
146905

💛  - Coveralls


Added release action

Repurposed Fabulist's Build GH Action to allow for manually requesting a build and packaging of NovelRT's Engine.
Also fixed/tweaked a few areas as They were found during testing.

Closing PR temporarily so that I can test on my fork and re-open once complete


embassy-nrf: New Event/Task types

So I've just tried the new updates and found no way to link up timer compare events to PPI, as ppi::Event is not implemented for the timer events and Event::from_reg is private.
Will Event::from_reg eventually become public or be implemented for the rest of the peripherals?
For now I will just make from_reg public and use it like in BufferedUarte, but I might be missing something

The inner pointer in Task and Event is public, so you can implement a from_reg equivalent in your crate.
pub struct Task(pub NonNull<()>);
pub struct Event(pub NonNull<()>);

This is intentional, because I want to remove all references to the PAC from the public API, so it can be bumped or replaced without breaking the public API.
I'm aware short-term it's less usable. This would also be improved by implementing a Timer HAL in embassy.
(tldr of the reasons for that: We may switch to something else due to a few problems with the PAC design: slow compile, can only link one major version in the binary, almost all PAC changes are breaking so require a major version, the owned singletons can't be semver-tricked due to Deref impl, https://github.com/rust-embedded/wg/pull/387, and for stm32 https://github.com/stm32-rs/meta/issues/4)


Add podSecurityContext to helm chart deployments

Is your feature request related to a problem? Please describe.
WIZ (cloud security scanning tool) is flagging Dynatrace pods managed by Helm with the violation: "GKE cluster with pod using the default security context"
Describe the solution you'd like
Add the ability to pass in pod level securityContext values through Helm for all Dynatrace K8s pods.
https://kubernetes.io/docs/tasks/configure-pod-container/security-context/
Example usage:
values.yaml
webhook:
...
  securityContext:
    runAsGroup: 1000
    runAsNonRoot: true
    runAsUser: 1000

Describe alternatives you've considered
Additional context
It is noted that the Dynakube containers already have securityContext policies.  It would be valuable to allow this at the pod level as well.

Hi, thanks for reaching out :) Our webhook pod (and all other internal components) already specifiy a security context on container level. e.g Webhook Security Context
This means that setting a pod security context would be in useless as the containers security context would be the one used in the end. For reference here: Kubernetes Documentation
Therefor this feature request would not improve things from a security standpoint.
Thanks!


Save card feature is not working in Test Mode.

I am trying to save card on the Razorpay and as per the documentation i am supposed to follow 2 major steps.

Create customer on Razorpay.
Pass save as "1" and customer_id which start with cust_.

After following these 2 steps the payment for the order gets successfully completed but the cards are not saved.
Card No: 4111 1111 1111 1111
CVV: 123
Exp. Date: 01/39
OTP: 1111
Card Network: Visa
Map<String,dynamic> params = {       'key': secreteKey,       'amount': amount,       'card[cvv]': cvv,       'card[expiry_month]': expMonth,       'card[expiry_year]': expYear,       'card[name]': cardName,       'card[number]': cardNumber,       'currency': currency,       'email': email,       'contact': contactNumber,       'description': desc,       'method': 'card',       "order_id": orderId,       'customer_id':'cust_',       'save':'1'     };
_razorpay.submit(params);

+1

+1


Add support for Google Cloud Identity

If the name of the service account secret is kept
empty, this means we want to use Google Cloud Identity
to authenticate against the GCP project

I did not know that the client just falls down to workload identity by default, which makes it very clean at the end.
I am thinking here and maybe it would make sense to just make auth key optional for gcp then? Like:

And then when we want to use GCP-WI we just create a store passing just the projectID.

What do you think?
Please run make check-diff and make fmt whenever you open a PR :)

@knelasevero you are right, if we make the auth key optional this is cleaner, I will modify the code today and update the PR

/ok-to-test sha=03f3622c2c905f002391c3b945878afcf15aa263

@moolen do we want to have a field to explicitly choose that the user wants to use GCP-WI, or omitting credentials fields is enough?

/approve

Just checked again and we just omit it for was with pod identity. I guess we can just omit here. :+1:

Gonna merge this one cause I have some people in need of this feature :smile: Please re-open the issue if you feel that something is missing. (I will take care of e2e tests for this)

/merge

Fantastic stuff @mouhsen-ibrahim @knelasevero !
When can we expect a new release that includes this ?

@renaudguerin it's out already! v0.3.4 here or on artifacthub.
https://artifacthub.io/packages/helm/external-secrets-operator/external-secrets


Adds an environment hook for testing

Test to see how the environment hook is called with a pipeline that has multiple steps.

This is called per step :'(


Return type not inferred for Array.prototype.reduce (NTI+old)

Here I'd expect the compiler to know that the return type was {number}:
function func(/** Array<number> */ a) {

  return a.reduce(
    (prev, row) => Math.max(prev, row[1]),
    0
  );

}

let test = func([1,2,3]);

console.log(test);

Current version externs for Array.prototype.reduce:
/**
 * Apply a function simultaneously against two values of the array (from
 * left-to-right) as to reduce it to a single value.
 *
 * @param {?function(?, T, number, !Array<T>) : R} callback
 * @param {*=} opt_initialValue
 * @return {R}
 * @this {{length: number}|Array<T>|string}
 * @template T,R
 * @see http://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/reduce
 */
Array.prototype.reduce = function(callback, opt_initialValue) {};

But it's unknown:
...
CALL 12 [source_file: input0] : ?
    GETPROP 12 [source_file: input0] : function (this:Console, ...*): ?
        NAME console 12 [source_file: input0] : Console
        STRING log 12 [source_file: input0] : string
    NAME test 12 [source_file: input0] : ?

https://closure-compiler-debugger.appspot.com/#input0%3Dfunction%2520func(%252F**%2520Array%253Cnumber%253E%2520*%252F%2520a)%2520%257B%250A%250A%2520%2520return%2520a.reduce(%250A%2520%2520%2520%2520(prev%252C%2520row)%2520%253D%253E%2520Math.max(prev%252C%2520row%255B1%255D)%252C%250A%2520%2520%2520%25200%250A%2520%2520)%253B%250A%250A%257D%250A%250Alet%2520test%2520%253D%2520func(%255B1%252C2%252C3%255D)%253B%250A%250Aconsole.log(test)%253B%26input1%26conformanceConfig%26externs%26refasterjs-template%26includeDefaultExterns%3D1%26CHECK_SYMBOLS%3D1%26CHECK_TYPES%3D1%26CHECK_TYPES_NEW_INFERENCE%3D1%26CLOSURE_PASS%3D1%26LANG_IN_IS_ES6%3D1%26MISSING_PROPERTIES%3D1%26TRANSPILE%3D1
I've seen a number of similar cases today (e.g. https://github.com/google/closure-compiler/issues/1194#issuecomment-146224619), and in my (soon-to-expire) experimental quest for 100% typing I've worked around these by adding type annotations to the passed function.

Strangely, this works:
https://closure-compiler-debugger.appspot.com/#input0%3D%252F**%2520%2540const%2520*%252F%2520var%2520ns%2520%253D%2520%257B%257D%253B%250A%252F**%2520%2540return%2520%257Bnumber%257D%2520*%252F%250Avar%2520g%2520%253D%2520function%2520(a%252Cb)%2520%257B%2520return%2520x%257D%253B%250A%250Afunction%2520func(%252F**%2520!Array%253Cnumber%253E%2520*%252F%2520a)%2520%257B%250A%2520%2520%2520%2520%252F**%2520%2540type%2520%257Bnull%257D%2520*%252F%2520var%2520x%2520%253D%2520null%253B%250A%2520%2520%2520%2520x%2520%253D%2520a.reduce(function(prev%252C%2520row)%2520%257B%2520return%2520g(1%252C2)%253B%2520%257D%252C%25200)%253B%250A%257D%250A%250Alet%2520test%2520%253D%2520func(%255B1%252C2%252C3%255D)%253B%250A%250Aconsole.log(test)%253B%26input1%26conformanceConfig%26externs%3D%250A%250A%252F**%250A%2520*%2520Apply%2520a%2520function%2520simultaneously%2520against%2520two%2520values%2520of%2520the%2520array%2520(from%250A%2520*%2520left-to-right)%2520as%2520to%2520reduce%2520it%2520to%2520a%2520single%2520value.%250A%2520*%250A%2520*%2520%2540param%2520%257B%253Ffunction(%253F%252C%2520T%252C%2520number%252C%2520!Array%253CT%253E)%2520%253A%2520R%257D%2520callback%250A%2520*%2520%2540param%2520%257B*%253D%257D%2520opt_initialValue%250A%2520*%2520%2540return%2520%257BR%257D%250A%2520*%2520%2540this%2520%257B%257Blength%253A%2520number%257D%257CArray%253CT%253E%257Cstring%257D%250A%2520*%2520%2540template%2520T%252CR%250A%2520*%252F%250AArray.prototype.reduce2%2520%253D%2520function(callback%252C%2520opt_initialValue)%2520%257B%257D%253B%250A%250Avar%2520x%250A%250A%26refasterjs-template%26includeDefaultExterns%3D1%26CHECK_SYMBOLS%3D1%26CHECK_TYPES%3D1%26CHECK_TYPES_NEW_INFERENCE%3D1%26CLOSURE_PASS%3D1%26LANG_IN_IS_ES6%3D1%26MISSING_PROPERTIES%3D1%26PRETTY_PRINT%3D1%26TRANSPILE%3D1

Not sure what I was writing in the original debugger link. Here's a better example (NTI):
https://closure-compiler-debugger.appspot.com/#input0%3Dfunction%2520func(%252F**%2520Array%253Cnumber%253E%2520*%252F%2520a)%2520%257B%250A%250A%2520%2520return%2520a.reduce(%250A%2520%2520%2520%2520(previousValue%252C%2520currentValue)%2520%253D%253E%2520%250A%2520%2520%2520%2520%2520%2520%2520%2520Math.max(previousValue%252C%2520currentValue)%252C%250A%2520%2520%2520%25200%250A%2520%2520)%253B%250A%250A%257D%250A%250Alet%2520test%2520%253D%2520func(%255B1%252C2%252C3%255D)%253B%250A%250Aconsole.log(test)%253B%26input1%26conformanceConfig%26externs%26refasterjs-template%26includeDefaultExterns%3D1%26CHECK_SYMBOLS%3D1%26CHECK_TYPES%3D1%26CHECK_TYPES_NEW_INFERENCE%3D1%26CLOSURE_PASS%3D1%26LANG_IN_IS_ES6%3D1%26MISSING_PROPERTIES%3D1%26TRANSPILE%3D1
Still the function result is unknown type, but should be number.
Here's a MUCH simpler example. The return type of this function in NTI is unknown:
function f() {return 42;}
https://closure-compiler-debugger.appspot.com/#input0%3Dfunction%2520f()%2520%257Breturn%252042%253B%257D%250A%26input1%26conformanceConfig%26externs%26refasterjs-template%26includeDefaultExterns%3D1%26CHECK_SYMBOLS%3D1%26CHECK_TYPES%3D1%26CHECK_TYPES_NEW_INFERENCE%3D1%26MISSING_PROPERTIES%3D1%26PRESERVE_TYPE_ANNOTATIONS%3D1%26PRETTY_PRINT%3D1

In the last example NTI infers the return type correctly.
https://closure-compiler-debugger.appspot.com/#input0%3Dfunction%2520f()%2520%257Breturn%252042%253B%257D%250Avar%2520%252F**%2520string%2520*%252F%2520s%2520%253D%2520f()%253B%26input1%26conformanceConfig%26externs%26refasterjs-template%26includeDefaultExterns%3D1%26CHECK_SYMBOLS%3D1%26CHECK_TYPES%3D1%26CHECK_TYPES_NEW_INFERENCE%3D1%26MISSING_PROPERTIES%3D1%26PRESERVE_TYPE_ANNOTATIONS%3D1%26PRETTY_PRINT%3D1

OK, I take back the "MUCH simpler example".
(The AST dump in the debugger shows "?" as the return type for the function. Presumably this is wrong?)
I've narrowed down the original problem with Array.reduce much further. Here's a succinct example:
Extern
/**
 * @param {function(?, T) : R} callback
 * @param {*} initial
 * @return {R}
 * @template T,R
 */
var reduce = function(callback, initial) {};

Code
var /** string */ s = reduce((p, c) => Math.max(p, c), 0);

Should infer number result, doesn't. Compiles successfully, but should not.
https://closure-compiler-debugger.appspot.com/#input0%3Dvar%2520%252F**%2520string%2520*%252F%2520s%2520%253D%2520reduce((p%252Cc)%253D%253EMath.max(p%252Cc)%252C%25200)%253B%26input1%26conformanceConfig%26externs%3D%252F**%250A%2520*%2520%2540param%2520%257Bfunction(%253F%252C%2520T)%2520%253A%2520R%257D%2520callback%250A%2520*%2520%2540param%2520%257B*%257D%2520initial%250A%2520*%2520%2540return%2520%257BR%257D%250A%2520*%2520%2540template%2520T%252CR%250A%2520*%252F%250Avar%2520reduce%2520%253D%2520function(callback%252C%2520initial)%2520%257B%257D%253B%26refasterjs-template%26includeDefaultExterns%3D1%26CHECK_SYMBOLS%3D1%26CHECK_TYPES%3D1%26CHECK_TYPES_NEW_INFERENCE%3D1%26CLOSURE_PASS%3D1%26LANG_IN_IS_ES6%3D1%26MISSING_PROPERTIES%3D1%26TRANSPILE%3D1

Great, thanks for the small example, that was much easier to debug. So, the problem isn't bad inference by NTI, it's that Math.max has a bad signature, that doesn't allow us to infer that its arguments are numbers.
https://github.com/google/closure-compiler/blob/master/externs/es3.js#L997
If instead there was some other operation that uses numbers, NTI would find the type error with reduce.
https://closure-compiler-debugger.appspot.com/#input0%3Dfunction%2520f(p%252Cc)%2520%257B%250A%2520%2520return%2520p%2520-%2520c%253B%250A%257D%250A%250Avar%2520%252F**%2520string%2520*%252F%2520s%2520%253D%2520reduce(f%252C%25200)%253B%250A%250Avar%2520%252F**%2520null%2520*%252F%2520n%2520%253D%2520f%253B%26input1%26conformanceConfig%26externs%3D%252F**%250A%2520*%2520%2540param%2520%257Bfunction(%253F%252C%2520T)%2520%253A%2520R%257D%2520callback%250A%2520*%2520%2540param%2520%257B*%257D%2520initial%250A%2520*%2520%2540return%2520%257BR%257D%250A%2520*%2520%2540template%2520T%252CR%250A%2520*%252F%250Avar%2520reduce%2520%253D%2520function(callback%252C%2520initial)%2520%257B%257D%253B%26refasterjs-template%26includeDefaultExterns%3D1%26CHECK_SYMBOLS%3D1%26CHECK_TYPES%3D1%26CHECK_TYPES_NEW_INFERENCE%3D1%26CLOSURE_PASS%3D1%26LANG_IN_IS_ES6%3D1%26MISSING_PROPERTIES%3D1%26TRANSPILE%3D1
Also, a useful trick when you're debugging these things: If you want to know the type of something, you can usually assign it to null, and then see the type in the error message.

What's bad about the signature of Math.max?
This correctly fails:
https://closure-compiler-debugger.appspot.com/#input0%3Dvar%2520%252F**%2520string%2520*%252F%2520s%2520%253D%2520reduce((p%252Cc)%253D%253Emax2(p%252Cc)%252C%25200)%253B%26input1%26conformanceConfig%26externs%3D%252F**%250A%2520*%2520%2540param%2520%257Bfunction(%253F%252C%2520T)%2520%253A%2520R%257D%2520callback%250A%2520*%2520%2540param%2520%257B*%257D%2520initial%250A%2520*%2520%2540return%2520%257BR%257D%250A%2520*%2520%2540template%2520T%252CR%250A%2520*%252F%250Avar%2520reduce%2520%253D%2520function(callback%252C%2520initial)%2520%257B%257D%253B%250A%250A%252F**%250A%2520*%2520%2540param%2520%257B...%257D%2520var_args%250A%2520%2520%2540return%2520%257Bnumber%257D%250A%2520*%252F%250Avar%2520max2%2520%253D%2520function(var_args)%2520%257B%257D%253B%250A%26refasterjs-template%26includeDefaultExterns%3D1%26CHECK_SYMBOLS%3D1%26CHECK_TYPES%3D1%26CHECK_TYPES_NEW_INFERENCE%3D1%26CLOSURE_PASS%3D1%26LANG_IN_IS_ES6%3D1%26MISSING_PROPERTIES%3D1%26TRANSPILE%3D1
This doesn't:
https://closure-compiler-debugger.appspot.com/#input0%3Dvar%2520%252F**%2520string%2520*%252F%2520s%2520%253D%2520reduce((p%252Cc)%253D%253EMath.max2(p%252Cc)%252C%25200)%253B%26input1%26conformanceConfig%26externs%3D%252F**%250A%2520*%2520%2540param%2520%257Bfunction(%253F%252C%2520T)%2520%253A%2520R%257D%2520callback%250A%2520*%2520%2540param%2520%257B*%257D%2520initial%250A%2520*%2520%2540return%2520%257BR%257D%250A%2520*%2520%2540template%2520T%252CR%250A%2520*%252F%250Avar%2520reduce%2520%253D%2520function(callback%252C%2520initial)%2520%257B%257D%253B%250A%250A%252F**%250A%2520*%2520%2540param%2520%257B...%257D%2520var_args%250A%2520%2520%2540return%2520%257Bnumber%257D%250A%2520*%252F%250AMath.max2%2520%253D%2520function(var_args)%2520%257B%257D%253B%250A%26refasterjs-template%26includeDefaultExterns%3D1%26CHECK_SYMBOLS%3D1%26CHECK_TYPES%3D1%26CHECK_TYPES_NEW_INFERENCE%3D1%26CLOSURE_PASS%3D1%26LANG_IN_IS_ES6%3D1%26MISSING_PROPERTIES%3D1%26TRANSPILE%3D1

Oh, you're right, I was looking at the argument types being * and I missed that the return type is number. So, the reason is a bug that has been fixed at commit 822853505a1da753f170a61b14defc501138c188, but it looks like the debugger hasn't been updated.

Great. Does the debugger expose the github revision? I can only see some numeric ID.

The number after the @ should roughly correspond to a github revision via the "MOE_MIGRATED_REVID" in the commit message. So for example d3c669a598134e08d22ab6263b3c9b442e86bc17 is equivalent to @112496453 so the current debugger was built after that commit.

FYI, I updated the debugger and now your Math.max2 example works as expected.

Confirmed, as are all examples above. Thanks.
Do you have unit coverage for this case? If not - should you / a contributor add them when issues like this are filed and subsequently fixed?

We add unit tests every time we fix a bug, so we should be OK.


Publish report viewer: Report items sorting

Changelog Description
Proposal of items sorting in Publish report viewer tool. Items are sorted by report creation time. Creation time is also added to publish report data when saved from publisher tool.
Additional info
For older report items is used file modification time as 'created_at'. Possible issues with this approach is that new dropped report may not be as last but in the middle, which may not be ideal. ISO timestamp should be probably used instead of "current timezone" timestamp.
Other possible approaches:

Add 'stored_at' information when report file is dropped to the UI, and use the 'stored_at' for sorting instead.
Completelly ignore value (column) sorting but use "custom sorting". User can manually move items around and int with sort value is stored for each item.

Testing notes:

New reports from publisher contain 'created_at'.

Open Publish report viewer.
Existing items should work as before.
Drop new report item. Which should load just fine.
UI should show 2 columns: 'Reports' and 'Created'. Second column is used for sorting by default.

Out of curiosity - why wouldn't we just use the Create timestamp or Date modified timestamp of the file on disk?

Out of curiosity - why wouldn't we just use the Create timestamp or Date modified timestamp of the file on disk?

I don't think those metadata are helpfull. UI will create and modify the file at the moment you drop the file in, or change label. Also create time of a file is usually not easy to pass to a different machine (especially to different OS).

With this PR I'm unable to drop new error reports onto the left panel to load new reports if I remove an entry and try to drag 'n' drop it in directly again. I then need to first close the UI and restart it. (it migth be that this behavior is similar as before)

That sounds like I've added a bug. Will look into it.

Also, if I drop in a file that's ALREADY in the UI then the UI appears to do nothing (no warning/error). I'd expect that if it should not add existing entries again, that instead it's best to highlight what matching entry already exists?

What if you'd drop 3 reports, 1 is new and 2 were already there, what should happen?
I can imagine that new entries are highlighted in some way, maybe? Probably not in this PR.

But maybe better is being able to load a file, again and again, as new entries?

That was actually a bug that you could do that. Each report has id, which is used for mapping in backend and also to store the report into file. Practically it is not possible to have 2 different reports with same id, until you manually modify them.


[backport] Disable some constexpr only for windows

Backport of #4735

[automatic post] Jenkins, test this please.

Jenkins CI test (for commit 548af44267b45f1f44e5afd41e7b146e85233bcf, target branch v8) failed with status FAILURE.

CIs unrelated


Ignore Empty Sheets

ExcelDataReader is trying to read empty sheets in my Excel files. i.e. I have a file with 3 sheets (Sheet1, Sheet2, Sheet3). Only Sheet1 contains data, and it tries to read the other sheets, and returns an error "Cannot find column 0"
Is there a way to ignore the sheets with no data?

Hi
Good question actually, it could be in the part of code that parses the dataset. I’ll check the code tomorrow and get back to you. Thanks for the quick response.

My apologies, it was the part that was reading the data tables.
Thanks :)


⚠ HDBits has degraded performance

In 50d9230, HDBits ($HDB) experienced degraded performance:

HTTP code: 200
Response time: 3081 ms

Resolved: HDBits performance has improved in 00ffea4 after 12 minutes.


Add plan summary to PR comment

Summary
Add a summary of changes to the PR plan comment.  This could be done using a tool like dineshba/tf-summarize or by parsing the changes from the plan using OPA.
Related

#112

Some other options for generating plan summaries:

hashicorp/terraform#10507

Confirmed to be working.


add codesample plugin/toolbar to TinyMCE

This PR adds support for TinyMCE's codesample plugin, allowing for formatted blocks of code to be displayed. The plugin and toolbar are both necessary.
For full formatting functionality, PrismJS needs to be installed as detailed here. However, not having it installed won't break anything. It will still create tags that can be styled using CSS.
Screenshot without PrismJS (no custom styling applied):

Screenshot with PrismJS:

I added the JS & CSS files to the asset pipeline. Example use:
<%= stylesheet_link_tag 'camaleon_cms/prismjs/prism' %>
<%= javascript_include_tag 'camaleon_cms/prism' %>

PrismJS has various themes that can be used by swapping the CSS file. The available files are:
camaleon_cms/prismjs/prism
camaleon_cms/prismjs/prism-dark
camaleon_cms/prismjs/prism-funky
camaleon_cms/prismjs/prism-okaidia
camaleon_cms/prismjs/prism-twilight
camaleon_cms/prismjs/prism-coy
camaleon_cms/prismjs/prism-solarizedlight
camaleon_cms/prismjs/prism-tomorrow

I should clarify, using PrismJS is only used for the frontend formatting, and only if someone actually uses codesample blocks in their content. PrismJS is not used in the backend. In other words, this shouldn't break anything.
If this PR is accepted, though, I think the documentation should be updated to show how to include PrismJS files in the frontend as shown in my comment above. I didn't put anything in the README because it seems to belong here instead, but I'd be happy to write something up if it would help.

Hi @brian-kephart I am sorry, but this should be a new camaleon cms plugin like: https://github.com/owen2345/Camaleon-Tinymce-Templates
To be installed by users who need this feature.

Thanks, I've gotten it working. Could the documentation be updated to refer to that plugin? My first thought was to write a plugin to do this, but I couldn't figure out how without that to guide me.


Implement press release & "in the news" overview pages

[ ] setup index containing the press release & in the news docs, index the template field
[ ] create separate, filtered sheets for press releases & in the news entries
[ ] implement "list block" used on both pages, with pre filtering config in the doc for types to be displayed

See Press Releases: https://www.moleculardevices.com/newsroom/news
See in the news: https://www.moleculardevices.com/newsroom/in-the-news

WIP in https://github.com/hlxsites/moleculardevices/tree/publication-overview


Question: Problem installing on Fedora, report missing java though I have java?

I downloaded: https://dbeaver.jkiss.org/files/dbeaver-ce-latest-stable.x86_64.rpm
and, according to the instructions, ran: sudo rpm -ivh dbeaver-ce-5.0.2-stable.x86_64.rpm
It replied: error: Failed dependencies: jre >= 1.8 is needed by dbeaver-ce-0:5.0.2-stable.x86_64
I checked that I had a relevant java jre: java -version
openjdk version "1.8.0_162"
OpenJDK Runtime Environment (build 1.8.0_162-b12)
OpenJDK 64-Bit Server VM (build 25.162-b12, mixed mode)
Is OpenJDK not good enough, can it be a path, or naming, issue?
For the record
I did read the one-line document: https://github.com/dbeaver/dbeaver/blob/devel/CONTRIBUTING.md

Well, it works ok on CentOS. However current dependency (jre) isn't quite correct.
It should be "java >= 1.8". You copuld try it in EA version or in 5.0.3 release.
Thanks for report

Could you check how it works in 5.0.3?


Refactor readLocal to avoid try catch

Instead, use the version of the function that returns an optional and check if it is empty.

This is superseded by https://github.com/lampepfl/dotty/pull/18012


build fails ubunutu 21.04

been searching but can not find the answer on this one
`CMake Error in CMakeLists.txt:
Imported target "pybind11::module" includes non-existent path
"/usr/include/python3.9"

in its INTERFACE_INCLUDE_DIRECTORIES.  Possible reasons include:

The path was deleted, renamed, or moved to another location.

An install or uninstall procedure did not complete successfully.

The installation package was faulty and references files it does not
provide.

 cmake --version
cmake version 3.18.4`

never mind didnt have pip3 installed hahah


Use RootHooks and hook simple

Prerequisites

[x] Checked that your issue hasn't already been filed by cross-referencing issues with the faq label
[ ] Checked next-gen ES issues and syntax problems by using the same environment and/or transpiler configuration without Mocha to ensure it isn't just a feature that actually isn't supported in the environment in question or a bug in your code.
[ ] 'Smoke tested' the code to be tested by running it outside the real test suite to get a better sense of whether the problem is in the code under test, your usage of Mocha, or Mocha itself
[ ] Ensured that there is no discrepancy between the locally and globally installed versions of Mocha. You can find them with: node node_modules/.bin/mocha --version(Local) and mocha --version(Global). We recommend that you not install Mocha globally.

Description
I have several test files, I would like to use the rootHooks in parallel mode, to restart the test server with each test file, and keep in parallel the beforeEach that already exist in the test files
Steps to Reproduce

Instance mochajs with, parallel mode and file rootHooks
Run tests that contain beforeEach in test files

Expected behavior: passed tests
Actual behavior:

Reproduces how often: 100%
Versions

Additional Information
Instance mochaJS

hooks.js

one of the tests (note that in other test files I do not have the same beforeEach)

the error comes from the mongo database, it seems that the db is empty... when i remove clearAllCollections, it work, because clearAllCollections, delete collection, but when i use mode parallel, the collection is undefined..

@Wessun75 With your information given I have no idea how you are doing what you are vaguely describing. There is no way to reproduce anything with this issue description. So please add a reproducable sample/repo.
Mocha@9 does not support Node@10. fgrep and grep are exclusive.

@juergba it's my bad, but now i have another problem, i need to run my server before each file of test
in RootHooks.js, but when i use
spawn('node', [
        path.join(ROOT_DIR, 'kimono-importer.js'),
        '--port', KIMONO_IMPORTER_PORT,
        '--disableRsync',
        '--enableTestApi',
    ], {
        env: _.defaults({
            remoteRequestRedirectTo: `http://localhost:${mockServerPort}${REMOTE_URL_PREFIX}`,
            realEstateAds: REAL_ESTATE_ADS_FOLDER, // set the import base folder
        }, process.env),
    });

I have this error


Update request: kapacitor 1.5.7 → 1.7.0

Package name: kapacitor
Latest released version: 1.7.0

Current version on the unstable channel: 1.5.7
Current version on the stable/release channel: 1.5.7

[ ] Checked the nixpkgs pull requests

Notify maintainers
@offline

Note for maintainers: Please tag this issue in your PR.

When you request for the update to 1.7.0 to you by any chance mean 1.7.0-rc2? Because the lastest non-prerelease I see is 1.6.6 and I can also see that the package haven't been updated in three years so I think it is time (;
Notify maintainers:
@offlinehacker

@totoroot when looking in the  maintainer list it shows that "offline" actually uses "offlinehacker" as their handle.
I'm on my phone but here a screenshot showing it:

Done in #259152


Change the type of custom queue label from String to optional String

Hi, @JohnEstropia
Thanks for your great lib.
I changed the type of label of the function that creates custom queue to UnsafePointer<Int8>, and applied the initial value to nil.
This changes is based on the following description in the 481-483 lines of dispatch/queue.h:
* @param label
* A string label to attach to the queue.
* This parameter is optional and may be NULL.

But it's OK to close this PR without merge, if you feel not good :bow:

@ra1028 Thanks for the pull request!
Will it work if we use optional strings instead?
public static func createSerial(label: String? = nil) -> GCDQueue

@JohnEstropia
Indeed, label just works for debugging purposes, so we should use optional string.
It will implements are following, because Optional type isn't convertible with UnsafePointer.
private static func createCustom(isConcurrent isConcurrent: Bool, label: String? = nil, targetQueue: GCDQueue?) -> GCDQueue {

        let attr = isConcurrent ? DISPATCH_QUEUE_CONCURRENT : DISPATCH_QUEUE_SERIAL
        let dispatchQueue = label.map {

            dispatch_queue_create($0, attr)
        } ?? dispatch_queue_create(nil, attr)
        let queue = GCDQueue.Custom(dispatchQueue)

        if let target = targetQueue {

            dispatch_set_target_queue(queue.dispatchQueue(), target.dispatchQueue())
        }
        return queue
    }

Will that be OK?

And, have you thought about adding the case to GCDQueue like this?
public enum GCDQueue {
   ...
   // Has no label and the target queue
   case Serial
    case Concurrent
}

I think just casting the string to NSString should be shorter.
let queue = GCDQueue.Custom(
    dispatch_queue_create(
        (label as? NSString)?.UTF8String,
        (isConcurrent ? DISPATCH_QUEUE_CONCURRENT : DISPATCH_QUEUE_SERIAL)
    )
)

And, have you thought about adding the case to GCDQueue like this?

We can't make Serial and Concurrent enum values because we need to keep a reference to the created dispatch_queue_t.
The rest of the queues (.Main, .Default, .Background, etc) are all global queues, so we can get their dispatch_queue_ts with dispatch_get_main_queue() and dispatch_get_global_queue(...).

@JohnEstropia
I see, thanks !
Just one thing:
(label as? NSString)?.UTF8String

A compile-error will also occur from this line.
I've change it to following:
(label as NSString?)?.UTF8String ?? nil

Please confirm that.

@ra1028 Thanks!


Add fakeBoundedEnum combinator

@jappeace I have released 0.7.1 with your changes. Thanks for the PR!

Thanks for the responsiveness 😉


Terramine Incompatibility because of architectury fabric required however architectury fabric is Incompatible

Mod Links here:
https://www.curseforge.com/minecraft/mc-mods/terramine
https://www.curseforge.com/minecraft/mc-mods/architectury-api
Crash report here:

Pojav launcher is not supported

Am not even using pojavlauncher

Doesn't matter; FCL and pojav are both non-standard launchers that won't receive support

The Connector mod and Forgified Fabric API work with them.


Fix checks for configuration keys in the DB

This fixes an issue with our DB checks to ensure we don't open a database with an incompatible configuration. @baude found this while working up a test executable using libpod.
Right now, we don't explicitly set a containers/storage config, so many of the config check keys in the DB will populate with the empty string. Currently, this will throw errors if you explicitly use a storage configuration with the containers/storage defaults (which would be the same as the empty string, given c/storage will just use the default in that case). This resolves this issue by checking against the c/storage defaults as well.

LGTM

@baude @umohnani8 PTAL

LGTM

@rh-atomic-bot r+

LGTM


NIFI-9170 Upgrade commons-beanutils to 1.9.4 to mitigate CVE-2019-10086

Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
Enables X functionality; fixes bug NIFI-YYYY.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[x] Has your PR been rebased against the latest commit within the target branch (typically main)?

[x] Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

[x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[x] Have you written or updated unit tests to verify your changes?
[x] Have you verified that the full build is successful on JDK 8?
[x] Have you verified that the full build is successful on JDK 11?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

I think I found a few stray references to previous releases. I'll clean them up and merge.

Looks good locally with a line or two fixing after testing with the maven dependency plugin.

Thanks @MikeThomsen for the review and merge,