Including this plasmoid cause Plasma to stop rendering the Task Bar.

How to reproduce :

Install DDCCI Plasmoid
Add it to the taskbar
Kill and relaunch Plasma
Taskbar is no longer visible
If the plasma config is change to what it was before adding it, the taskbar is visible again.

System information :
Linux version 6.6.9-arch1-1
plasmashell 5.27.10

I'm unable to reproduce this myself. Please post the relevant output of journalctl when reproducing this (e.g. run sudo journalctl -f before killing and relaunching plasmashell).

Here is my log :
hecking screens: available: (QScreen(0x5631eb96c160, name="HDMI-0"), QScreen(0x5631eb96c250, name="DP-5")) redundant: QHash() fake: QSet() all: (QScreen(0x5631eb96c160, name="HDMI-0"), QScreen(0x5631eb96c250, name="DP-5")) Checking screens: available: (QScreen(0x5631eb96c160, name="HDMI-0"), QScreen(0x5631eb96c250, name="DP-5")) redundant: QHash() fake: QSet() all: (QScreen(0x5631eb96c160, name="HDMI-0"), QScreen(0x5631eb96c250, name="DP-5")) kf.plasma.quick: Applet preload policy set to 1 kf.coreaddons: Expected JSON property "X-Plasma-NotificationArea" to be a single string. but it is a bool file:///usr/lib/qt/qml/org/kde/kirigami.2/templates/InlineMessage.qml:265:13: QML SelectableLabel: Binding loop detected for property "implicitWidth" file:///usr/lib/qt/qml/org/kde/kirigami.2/templates/InlineMessage.qml:265:13: QML SelectableLabel: Binding loop detected for property "implicitWidth" QObject::connect: No such slot DesktopProtocol::_k_slotRedirection(KIO::Job *, QUrl) org.kde.plasma.containmentlayoutmanager: Error: cannot change the containment to AppletsLayout Both point size and pixel size set. Using pixel size. file:///usr/share/plasma/plasmoids/org.kde.plasma.digitalclock/contents/ui/Tooltip.qml:78:9: QML GridLayout (parent or ancestor of QQuickLayoutAttached): Binding loop detected for property "minimumWidth" org.kde.plasma.containmentlayoutmanager: Error: cannot change the containment to AppletsLayout qt.gui.icc: fromIccProfile: failed minimal tag size sanity qml: PlasmaExtras.ScrollArea is deprecated. Use PlasmaComponents3.ScrollView instead. Module '.home.Azervivi..local.share.plasma.plasmoids.org.kde.contents.ui' does not contain a module identifier directive - it cannot be protected from external registrations. file:///usr/share/plasma/plasmoids/org.kde.milou/contents/ui/main.qml:47:17: Unable to assign double to QQuickAnchorLine org.kde.plasma.kicker: DragHelper is deprecated and will be removed in Plasma 6. Use Qt Quick Drag instead. org.kde.plasma.kicker: Entry is not valid "kontact.desktop" QSharedPointer(0x5631edb39e40) org.kde.plasma.kicker: Entry is not valid "ktp-contactlist.desktop" QSharedPointer(0x5631edb39310) org.kde.plasma.kicker: Entry is not valid "org.kde.kate.desktop" QSharedPointer(0x5631edb3a180) org.kde.plasma.kicker: Entry is not valid "org.kde.discover.desktop" QSharedPointer(0x5631edb38d80) org.kde.plasma.kicker: Entry is not valid "kontact.desktop" QSharedPointer(0x5631edb39580) org.kde.plasma.kicker: Entry is not valid "ktp-contactlist.desktop" QSharedPointer(0x5631edaf9fc0) org.kde.plasma.kicker: Entry is not valid "org.kde.kate.desktop" QSharedPointer(0x5631edb3a8f0) org.kde.plasma.kicker: Entry is not valid "org.kde.discover.desktop" QSharedPointer(0x5631edb38ef0) file:///home/Azervivi/.local/share/plasma/plasmoids/org.kde.plasma.kickoff/contents/ui/Kickoff.qml:87: TypeError: Cannot read property 'height' of null file:///home/Azervivi/.local/share/plasma/plasmoids/org.kde.plasma.kickoff/contents/ui/Kickoff.qml:63: TypeError: Cannot read property 'height' of null QObject::connect: No such slot DesktopProtocol::_k_slotRedirection(KIO::Job *, QUrl) file:///usr/share/plasma/plasmoids/org.kde.kscreen/contents/ui/main.qml:30:5: Unable to assign [undefined] to bool Cyclic dependency detected between "file:///usr/share/plasma/plasmoids/org.kde.plasma.notifications/contents/ui/global/Globals.qml" and "file:///usr/share/plasma/plasmoids/org.kde.plasma.notifications/contents/ui/ThumbnailStrip.qml" Cyclic dependency detected between "file:///usr/share/plasma/plasmoids/org.kde.plasma.notifications/contents/ui/global/Globals.qml" and "file:///usr/share/plasma/plasmoids/org.kde.plasma.notifications/contents/ui/NotificationHeader.qml" file:///usr/share/plasma/plasmoids/org.kde.plasma.networkmanagement/contents/ui/main.qml:95: TypeError: Cannot read property 'airplaneModeAvailable' of null kf.coreaddons: Expected JSON property "X-Plasma-NotificationArea" to be a single string. but it is a bool file:///usr/share/plasma/plasmoids/org.kde.plasma.mediacontroller/contents/ui/CompactRepresentation.qml:136:5: QML Loader: Binding loop detected for property "width" file:///usr/share/plasma/plasmoids/org.kde.plasma.networkmanagement/contents/ui/main.qml:95: TypeError: Cannot read property 'airplaneModeAvailable' of null file:///usr/share/plasma/plasmoids/org.kde.kscreen/contents/ui/main.qml:30:5: Unable to assign [undefined] to bool file:///usr/share/plasma/plasmoids/org.kde.plasma.private.systemtray/contents/ui/main.qml:18:1: QML MouseArea (parent or ancestor of QQuickLayoutAttached): Binding loop detected for property "minimumWidth" org.kde.plasma.containmentlayoutmanager: Error: cannot change the containment to AppletsLayout file:///usr/share/plasma/plasmoids/org.kde.milou/contents/ui/main.qml:47:17: Unable to assign double to QQuickAnchorLine file:///home/Azervivi/.local/share/plasma/plasmoids/org.kde.plasma.kickoff/contents/ui/LeaveButtons.qml:64:5: QML ToolButton: Binding loop detected for property "display" Both point size and pixel size set. Using pixel size. file:///usr/share/plasma/plasmoids/org.kde.plasma.digitalclock/contents/ui/Tooltip.qml:78:9: QML GridLayout (parent or ancestor of QQuickLayoutAttached): Binding loop detected for property "minimumWidth" Both point size and pixel size set. Using pixel size. org.kde.plasma.containmentlayoutmanager: Error: cannot change the containment to AppletsLayout QObject::connect: No such slot DesktopProtocol::_k_slotRedirection(KIO::Job *, QUrl) org.kde.plasma.pulseaudio: No object for name "bluez_output.AC_80_0A_6D_5B_81.1.monitor" file:///usr/lib/qt/qml/org/kde/plasma/extras/PlaceholderMessage.qml:238:5: QML Heading: Binding loop detected for property "verticalAlignment" file:///usr/lib/qt/qml/org/kde/plasma/extras/PlaceholderMessage.qml:238:5: QML Heading: Binding loop detected for property "verticalAlignment" file:///usr/lib/qt/qml/org/kde/plasma/extras/PlaceholderMessage.qml:238:5: QML Heading: Binding loop detected for property "verticalAlignment"
To compare, here is the log without the Plasmaoid (the taskbar does show up)
Checking screens: available: (QScreen(0x5600f262bb10, name="HDMI-0"), QScreen(0x5600f262bc00, name="DP-5")) redundant: QHash() fake: QSet() all: (QScreen(0x5600f262bb10, name="HDMI-0"), QScreen(0x5600f262bc00, name="DP-5")) Checking screens: available: (QScreen(0x5600f262bb10, name="HDMI-0"), QScreen(0x5600f262bc00, name="DP-5")) redundant: QHash() fake: QSet() all: (QScreen(0x5600f262bb10, name="HDMI-0"), QScreen(0x5600f262bc00, name="DP-5")) kf.plasma.quick: Applet preload policy set to 1 kf.coreaddons: Expected JSON property "X-Plasma-NotificationArea" to be a single string. but it is a bool file:///usr/lib/qt/qml/org/kde/kirigami.2/templates/InlineMessage.qml:265:13: QML SelectableLabel: Binding loop detected for property "implicitWidth" file:///usr/lib/qt/qml/org/kde/kirigami.2/templates/InlineMessage.qml:265:13: QML SelectableLabel: Binding loop detected for property "implicitWidth" QObject::connect: No such slot DesktopProtocol::_k_slotRedirection(KIO::Job *, QUrl) org.kde.plasma.containmentlayoutmanager: Error: cannot change the containment to AppletsLayout Both point size and pixel size set. Using pixel size. file:///usr/share/plasma/plasmoids/org.kde.plasma.digitalclock/contents/ui/Tooltip.qml:78:9: QML GridLayout (parent or ancestor of QQuickLayoutAttached): Binding loop detected for property "minimumWidth" org.kde.plasma.containmentlayoutmanager: Error: cannot change the containment to AppletsLayout qt.gui.icc: fromIccProfile: failed minimal tag size sanity qml: PlasmaExtras.ScrollArea is deprecated. Use PlasmaComponents3.ScrollView instead. Module '.home.Azervivi..local.share.plasma.plasmoids.org.kde.contents.ui' does not contain a module identifier directive - it cannot be protected from external registrations. file:///usr/share/plasma/plasmoids/org.kde.milou/contents/ui/main.qml:47:17: Unable to assign double to QQuickAnchorLine org.kde.plasma.kicker: DragHelper is deprecated and will be removed in Plasma 6. Use Qt Quick Drag instead. org.kde.plasma.kicker: Entry is not valid "kontact.desktop" QSharedPointer(0x5600f47103c0) org.kde.plasma.kicker: Entry is not valid "ktp-contactlist.desktop" QSharedPointer(0x5600f470f890) org.kde.plasma.kicker: Entry is not valid "org.kde.kate.desktop" QSharedPointer(0x5600f4710700) org.kde.plasma.kicker: Entry is not valid "org.kde.discover.desktop" QSharedPointer(0x5600f470f300) org.kde.plasma.kicker: Entry is not valid "kontact.desktop" QSharedPointer(0x5600f470fb00) org.kde.plasma.kicker: Entry is not valid "ktp-contactlist.desktop" QSharedPointer(0x5600f46d0440) org.kde.plasma.kicker: Entry is not valid "org.kde.kate.desktop" QSharedPointer(0x5600f4710e70) org.kde.plasma.kicker: Entry is not valid "org.kde.discover.desktop" QSharedPointer(0x5600f470f470) file:///home/Azervivi/.local/share/plasma/plasmoids/org.kde.plasma.kickoff/contents/ui/Kickoff.qml:87: TypeError: Cannot read property 'height' of null file:///home/Azervivi/.local/share/plasma/plasmoids/org.kde.plasma.kickoff/contents/ui/Kickoff.qml:63: TypeError: Cannot read property 'height' of null QObject::connect: No such slot DesktopProtocol::_k_slotRedirection(KIO::Job *, QUrl) file:///usr/share/plasma/plasmoids/org.kde.kscreen/contents/ui/main.qml:30:5: Unable to assign [undefined] to bool Cyclic dependency detected between "file:///usr/share/plasma/plasmoids/org.kde.plasma.notifications/contents/ui/global/Globals.qml" and "file:///usr/share/plasma/plasmoids/org.kde.plasma.notifications/contents/ui/ThumbnailStrip.qml" Cyclic dependency detected between "file:///usr/share/plasma/plasmoids/org.kde.plasma.notifications/contents/ui/global/Globals.qml" and "file:///usr/share/plasma/plasmoids/org.kde.plasma.notifications/contents/ui/NotificationHeader.qml" file:///usr/share/plasma/plasmoids/org.kde.plasma.networkmanagement/contents/ui/main.qml:95: TypeError: Cannot read property 'airplaneModeAvailable' of null kf.coreaddons: Expected JSON property "X-Plasma-NotificationArea" to be a single string. but it is a bool file:///usr/share/plasma/plasmoids/org.kde.plasma.mediacontroller/contents/ui/CompactRepresentation.qml:136:5: QML Loader: Binding loop detected for property "width" file:///usr/share/plasma/plasmoids/org.kde.plasma.networkmanagement/contents/ui/main.qml:95: TypeError: Cannot read property 'airplaneModeAvailable' of null org.kde.plasma.containmentlayoutmanager: Error: cannot change the containment to AppletsLayout file:///usr/share/plasma/plasmoids/org.kde.kscreen/contents/ui/main.qml:30:5: Unable to assign [undefined] to bool file:///usr/share/plasma/plasmoids/org.kde.plasma.private.systemtray/contents/ui/main.qml:18:1: QML MouseArea (parent or ancestor of QQuickLayoutAttached): Binding loop detected for property "minimumWidth" file:///usr/share/plasma/plasmoids/org.kde.milou/contents/ui/main.qml:47:17: Unable to assign double to QQuickAnchorLine file:///home/Azervivi/.local/share/plasma/plasmoids/org.kde.plasma.kickoff/contents/ui/LeaveButtons.qml:64:5: QML ToolButton: Binding loop detected for property "display" Both point size and pixel size set. Using pixel size. file:///usr/share/plasma/plasmoids/org.kde.plasma.digitalclock/contents/ui/Tooltip.qml:78:9: QML GridLayout (parent or ancestor of QQuickLayoutAttached): Binding loop detected for property "minimumWidth" Both point size and pixel size set. Using pixel size. org.kde.plasma.containmentlayoutmanager: Error: cannot change the containment to AppletsLayout QObject::connect: No such slot DesktopProtocol::_k_slotRedirection(KIO::Job *, QUrl) org.kde.plasma.pulseaudio: No object for name "bluez_output.AC_80_0A_6D_5B_81.1.monitor"
Also when, adding the plasmoid, it is not visible. What is strange is that I did not encountered issue until yesterday, and then it stopped working. I suspect a package update did cause the issue.
Here are the package I updated just before encountering the issue :
[2024-01-04T19:38:52+0100] [ALPM] upgraded c-ares (1.24.0-1 -> 1.25.0-1) [2024-01-04T19:38:52+0100] [ALPM] installed electron28 (28.1.1-1) [2024-01-04T19:38:52+0100] [ALPM] upgraded electron (1:25-1 -> 1:28-1) [2024-01-04T19:38:52+0100] [ALPM] upgraded electron25 (25.9.6-1 -> 25.9.8-1) [2024-01-04T19:38:52+0100] [ALPM] upgraded leptonica (1.84.0-1 -> 1.84.1-1) [2024-01-04T19:38:53+0100] [ALPM] upgraded linux (6.6.8.arch1-1 -> 6.6.9.arch1-1) [2024-01-04T19:38:54+0100] [ALPM] upgraded linux-headers (6.6.8.arch1-1 -> 6.6.9.arch1-1) [2024-01-04T19:38:54+0100] [ALPM] upgraded nvidia (545.29.06-7 -> 545.29.06-8) [2024-01-04T19:38:54+0100] [ALPM] upgraded python-pydantic-core (1:2.14.5-1 -> 1:2.14.6-1) [2024-01-04T19:38:54+0100] [ALPM] upgraded python-pydantic (2.5.2-1 -> 2.5.3-1) [2024-01-04T19:38:54+0100] [ALPM] upgraded python-jaraco.text (3.11.1-3 -> 3.12.0-1) [2024-01-04T19:38:54+0100] [ALPM] upgraded rust (1:1.74.1-1 -> 1:1.75.0-1) [2024-01-04T19:38:54+0100] [ALPM] upgraded starship (1.17.0-1 -> 1.17.1-1)

I don't see any mentions of the widget in the log. Even if the widget was broken, Plasma should handle the errors instead of failing to launch. You might want to file a bug report for Plasmashell instead.


Test quadratic optimal transport

I've added a test for quadreg(). As with the other functions, I compare against the output of POT. The relevant function here is smooth_ot_dual from POT, and I've needed to implement another wrapper for it. (I agree that eventually it would be nice to strip the python dependencies, but we can talk about how to do testing in #42).

Pull Request Test Coverage Report for Build 852326875

5 of 5 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+19.4%) to 75.984%

Totals

Change from base Build 852149592:
19.4%

Covered Lines:
193

Relevant Lines:
254

💛  - Coveralls

Codecov Report

Merging #55 (00c04ac) into master (3bbc0d5) will increase coverage by 19.44%.
The diff coverage is 100.00%.

:exclamation: Current head 00c04ac differs from pull request most recent head 9d00030. Consider uploading reports for the commit 9d00030 to get more accurate results

@@             Coverage Diff             @@
##           master      #55       +/-   ##
===========================================
+ Coverage   56.53%   75.98%   +19.44%
===========================================
  Files           2        2
  Lines         260      254        -6
===========================================
+ Hits          147      193       +46
+ Misses        113       61       -52

Impacted Files
Coverage Δ

src/OptimalTransport.jl
74.36% <100.00%> (+20.30%)
:arrow_up:

src/pot.jl
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bbc0d5...9d00030. Read the comment docs.


Align symbol with amount

At the moment, amounts in the value view are not really lined up with the token symbol. The amount is too "high" comparatively.

This PR drops it by a few pixels so they share the same baseline

Not related to this PR, but noticed a new warning in logs


Travis CI

it would be great to have Travis integration for PR's

preums issue!

https://travis-ci.org/aesteve/vertx-aws-sdk
The AsyncHttpClientTest are failing only on travis. They run fine locally.
    io.netty.channel.AbstractChannel$AnnotatedConnectException: Connection refused: localhost/<IP_ADDRESS>:8000
```


encrypted password bind

using the client.bind function
with an encrypted password results to a StrongAuthRequiredError
is this feature already available or is there another approach?
Thanks

I am unsure what you meant by "with an encrypted password". Do you simply mean you're using SSL/TLS (ldaps) ? In any case:

The bind API only allows LDAP 'simple' binds (equivalent to HTTP Basic Authentication) for now.
http://ldapjs.org/client.html

I believe StrongAuthRequiredError indicates the server does want to use something else than plaintext  (there are other option such as DIGEST-MD5 or GSS authentication)
Normally if you're connecting using SSL/TLS using 'simple' bind is fine as the password is encrypted in transit. You might want to check with the admin of the ldap server you're connecting to.

Yes that would be fine and I don't really see a better solution.
Important thing is to use a good password hash (for example SHA2) on the LDAP server side.
My understanding is that most (all?) system that transmit a hash instead of the actually password have a significant disadvantage: password must be store in clear text on the server side.
(that might be file for a shared random PSK but a bad idea for user password)

⚠ This issue has been locked due to age. If you have encountered a recent
problem that seems to be covered by this issue, please open a new issue.
Please include a minimal reproducible example
when opening a new issue.


Upgrade Azurite container image to version 3.27.0

Description

Target

[x] I checked that the commit is targeting the correct branch (note that Camel 3 uses camel-3.x, whereas Camel 4 uses the main branch)

Tracking

[ ] If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

[x] I checked that each commit in the pull request has a meaningful subject line and body.

[x] I have run mvn clean install -DskipTests locally and I have committed all auto-generated changes

/component-test azure

/component-test azure

/component-test azure

/component-test azure

/component-test azure

/component-test azure

/component-test azure

/component-test azure


feat(EMI-1766): Show partner offer details on Artwork screeen

This PR resolves EMI-1766

[!NOTE]
This work is hidden behind AREnablePartnerOfferV1Improvements feature flag

Description
This PR adds the partner offer details in the artwork screen
It also removes the Exclude shipping and taxes label from the artwork screen
And refactors a few tests
Screenshots
Removing excl. shipping and taxes label

Before
After

Android

iOS

New Partner Offer details statuses

Android
iOS

Exact Price

Expiring soon + range

Hidden price

Large price display

PR Checklist

[X] I have tested my changes on iOS and Android.
[x] I hid my changes behind a feature flag, or they don't need one.
[X] I have included screenshots or videos, or I have not changed the UI.
[X] I have added tests, or my changes don't require any.
[X] I added an app state migration, or my changes do not require one.
[X] I have documented any follow-up work that this PR will require, or it does not require any.
[X] I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

[ ] I would like at least one of the reviewers to run this PR on the simulator or device.

Changelog updates
Changelog updates

Cross-platform user-facing changes

Adds partner offer details to artwork screen (behind FF: AREnablePartnerOfferV1Improvements) - mrsltun

iOS user-facing changes

Android user-facing changes

Dev changes

@artsy/emerald-devs

Need help with something? Have a look at our docs, or get in touch with us.

This PR contains the following changes:

Cross-platform user-facing changes (Adds partner offer details to artwork screen (behind FF: AREnablePartnerOfferV1Improvements) - mrsltun)

  Generated by :no_entry_sign: dangerJS against 818e7dde3c675db62b8d2fde11ba09655ebd43ed

(also non-blocking): another thing that I noticed (minor but design wise) looks like when the list price is on the same line as the artwork price it feels a bit off to me, when it is under the price it does look better

(also non-blocking): another thing that I noticed (minor but design wise) looks like when the list price is on the same line as the artwork price it feels a bit off to me, when it is under the price it does look better

@gkartalis I believe this is by design, as you can see in this screenshot


Refactor probes and repair all syntax errors

Need to update the probe module to operate with the newly refactored ops package, and fix remaining syntax errors throughout the docs and unit tests.

Most resolved by 724f1294c072caa227c1b796b64b6864e971ac1d.  Still need to update the OpenAI gym example.


Revert Custom Volumes/VolumeMounts

Issue link

What changes have been made

Reverting custom Volumes/VolumeMounts in favour of template patch in #564
Verification steps

Checks

[ ] I've made sure the tests are passing.
Testing Strategy

[ ] Unit tests
[ ] Manual tests
[ ] Testing is not required for this change

/hold
Until we have the replacement for it.

/unhold
As discussed.

/lgtm


After refreshing the page get this error

it's working perfectly fine but when i'm refreshing the page getting this issues.
"_vm.$moment is not a function"
i'm using the nuxt (vue.js)

thanks for reporting this, do you have more details on how you declare this lib as a plugin in your nuxt config? You may find some more info there https://medium.com/@codebeast_/why-your-third-party-plugin-dont-work-in-nuxt-and-how-to-fix-it-d1a8caadf422 you may try to disable the ssr mode for this plugin


Output export

In an "Export publications" dropdown button, propose

Export in csv (same columns as in displayed table)
Export in jsonl (all the underlying data)
Custom export for local BSO (.csv)

In an "Export datasets" dropdown button, propose

Export in csv (same columns as in displayed table)
Export in jsonl (all the underlying data)

Exported filename shoud be explicit, like
works_finder_publications_HASH_YYYY1_YYYY2_timestamp (.csv / .jsonl / _bso.csv)
where HASH is a hash of the query ?

csv not always valid for datasets
works_finder_datasets_198131042_2016_2023_1707307768945.csv
==> ParserError: Error tokenizing data. C error: Expected 7 fields in line 144, saw 8

To test title error for DOI 10.5281/zenodo.1196303 and 10.57745/z4rpdk, use this query https://works-magnet.dataesr.ovh/?affiliations=université+de+lorraine&datasets=true&endYear=2024&startYear=2010&view=datasets then choose tab "List of datasets" and export datasets in CSV (minimal data).


feat(python): add support for Pydantic v2 forward-compatibility

This PR makes the Pydantic implementation forwards-compatible for Pydantic 2.x.

Ran into a small blocker and logged here:

https://github.com/koxudaxi/datamodel-code-generator/issues/1950

Superceded by (now merged 🙌 )

https://github.com/airbytehq/airbyte-protocol/pull/81


Reduce the generated code size when using Fragments

Question
Are there any recommendations that will help in reducing the size of classes that are generated by apollo-android.
In our code base we use fragments extensively. We see there are ton of "Impl_ResponseAdapter" classes generated for fragments wherever the specific fragments are referenced. That seems to "bloat" the overall size.
I am using apollo version 3.7.5
Would appreciate any tips to reduce size of generated classes.

There's no silver bullet unfortunately. The Impl_ResponseAdapter are the JSON parsers. They're needed to parse the response into typesafe models and last time I checked, the bytecode was in the similar range as other alternative JSON parsers.
The one thing that comes to mind is disabling data classes with generateMethods:
apollo {
  service("api") {
    generateMethods.set(emptyList())
  }
}

See https://github.com/apollographql/apollo-kotlin/pull/5212 for more details.
Other thing that comes to mind is make sure you're shrinking your code with R8 or proguard.
Besides that, we're trying quite hard not to generate unused code. If you can share an APK Analyzer (In Android Studio: Build -> Analyze APK), we'll look into it but saving more bytecode will probably be challenging without dropping some typesafety.

Thanks @martinbonnin as always for suggestion.
Yes we do use fullR8mode for app.
Will explore proper use of generateMethods option.

@snijsure Something else I just remembered if you want to shave on the bytecode size, another interesting thing would be to use persisted queries. Using persisted queries is also more secure and saves network bandwidth so it really has mostly upsides at the cost of some build setup.
Using generateQueryDocument.set(false) you can remove the queries from your app completely. You can read more about persisted queries here

We do use persisted queries in our app, I will explore the generateQueryDocument.set(false)  option as well.
I see all of these options are available in Apollo 4.0.X which is currently in beta-4, is there a "time line" in mind when 4.0 is likely to become officia?
In the meantime I am actively migrating our app from 3.x to 4.x-beta for testing.

You can get latest estimates in the ROADMAP.
4.0 will build with K2 so it'll require a stable version of K2 but overall the goal is early 2024.
PS: generateQueryDocument is in 3.x as well (but not generateMethods)
PS2: in terms of stability, 4.x is pretty stable. The API is not but if you're building in app (and not a lib), using it should be pretty safe.


Add/tag users by unique id.

The hubot brain identifies each user by a unique ID. It would be nice if when you added someone to the group, it instead adds their unique ID to the group, so that when you ping someone who changes their name, it still shows up as a ping

Worth doing at some point. I'm not sure if the API exposes these IDs, and I'm not sure if this would work with other chat services that people use Hubot with (e.g. Campfire).

superseded by #11


Deploy on multiple bricks simultaneously using gradle tasks

Is there a way to deploy a program onto two bricks without having to change the config.gradle file for each additional brick? I want to test remote method calls between two or more bricks, but changing the config.gradle file to deploy on a specific brick seems very inefficient. Can I add multiple configs, preferrably with different main classes to be used in the gradle tasks?

Hi @mrkrizic,
the gradle plugin does not support this feature yet. However, there is a way how to work it around. In build.gradle, the config file is loaded using this syntax:
apply from: './config.gradle'

With the help of Gradle [-P switch][gradle], it should be possible to parameterize it:
apply from: "./${brickname}/config.gradle"

(run as:)
gradle build -P brickname=alonso

This way, it will load config from the alonso subdirectory.
To provide support for multiple bricks, it is necessary to add a wrapper script (example for Linux shell):
for name in alonso barbara charlie; do
    gradle build -P brickname=$name
done

Similar scripts should be possible to write with Batch and Powershell scripts too.
Regards,
Jakub
[gradle]: https://docs.gradle.org/current/userguide/build_environment.html#sec:project_properties

EDIT: it is necessary to use the deploy gradle subtask instead of the build one. The JAR file will be overwritten each time.

Hmmm, looking back at this, a better convention than per-brick directories might be a common directory for configs an per-brick configs: <project>/bricks/alonso.gradle.

Wow,
the idea from @mrkrizic is pretty nice!

Hello sorry for the late response. Thank you for considering this feature. I have created two seperate config files and put them into a folder named configs. I have a problem running the gradle task from the command line as it does not translate ${brickname} to the input I provide with -P.
Currently I am still commenting the one I don't need out as I don't have that much time to look into it. If I make any progress I will get back to you.


Community Forum Signup is busted... and how to chain pixel shader?

Any attempt to create a new account on http://www.html5gamedevs.com fails because a captcha problem -- I've tried this on Chrome and Firefox from both Windows and OSX.  So, I can't ask this question there....

I wanted to ask how to create a chain of effects to do iterative processing -- effectively, render an effect into an RT then pass the result of that back to a copy of the same effect.
I originally envisioned it as a pair of CustomProceduralTextures that alternated with each other, but that doesn't work. Postprocesses seem to be tied to cameras, but in this case I don't need to render the effect in 3d, it's just a chain of pixel shaders.
Is this something I can do out the box? If not, what would the appropriate strategy? It's not conceptually very difficult but the implementation details are kind of gnarly.

You can rely on rendering pipeline which are exactly designed for that:
http://doc.babylonjs.com/how_to/how_to_use_postprocessrenderpipeline
Example:
http://doc.babylonjs.com/how_to/using_default_rendering_pipeline
You will see if you check the code of the default rendering pipeline that you can easily control which effect is applied to which rtt. And even reuse rtt multiple time.


Needs to be clearer that BOMS are not meant to be updated continously

I have this requirement for two reasons:

Force students to finish designs before buying anything.
Reduce the time we have to spend on reviewing BOMs.

It is possible that I should relax this, but not sure. We can also think about a better way to codify it.

Let's do the change order and we could even only allow them at specific times to prevent change orders every week.

Change order is implemented and seems to be working!


Fix installSbtn for apple silicon

Handle ARM architecture for non-Linux architectures
Provide a Rosetta fallback if the ARM binary is not available for Apple Silicon

(2) is possibly controversial, because using sbtn through rosetta is always problematic.
But I'm just replicating current behaviour

Closing this in favor of https://github.com/sbt/sbt/pull/7551


Circleci editor/615/circleci project setup

Hey @ramkumareinstein, In the future, please keep little tests like this on your own fork! It generates noise for anyone getting notifications on this repo.


HIVE-27786: Iceberg: Eliminate engine.hive.enabled table property.

What changes were proposed in this pull request?
Eliminate the need for engines to explicitly specify the hive.engine.enabled property, If anyone doesn't want this enabled, there is a conf which can be set to false in that cluster
Why are the changes needed?
Adds overhead for other engines, (trino still has issues I believe)
Does this PR introduce any user-facing change?
No
Is the change a dependency upgrade?
No
How was this patch tested?
UT

As far as I know, other engines, e.g.

Trino has its own customized HMS catalog and Trino does't use the property,  and so the iceberg table created by trino cann't be queried by HS2.  I have submitted an immature PR about this before: https://github.com/apache/hive/pull/3726
Spark uses the HMS catalog which is from iceberg's code repository, so this change has no effect on Spark engine, and if user want HS2 to query iceberg table created by Spark, they still need add property  --hiveconf iceberg.engine.hive.enabled=true.

We made that conf default true in this PR, so that shouldn’t be required here & maintaining this TBLPROPERTIES is becoming an overhead for us

We made that conf default true in this PR, so that shouldn’t be required here & maintaining this TBLPROPERTIES is becoming an overhead for us

I see. :)  I may be overthinking this change a bit. I think It's a good to remove it.

The hive.engine.enabled configuration drives if the SerDe is set on the Iceberg table, or not.
The HMS client tries to instantiate the SerDe if it is set, and fails if it is not on the classpath.
So the flag is necessary for Spark users who does not have the IcebergSerDe on the classpath to access the table through the HMS client.

This flag is set during table create, so if it is true.
any client after that reading the table if it doesn’t have iceberg jars on classpath will always fail, right?
But if we remove this TBLPROPERTIES and rely just on conf, the client which doesn’t have iceberg jars on classpath can set the config to false and he can succeed now?
cc. @deniskuzZ

I have asked the spark folks to check on this, not sure how spark is working. This config stuff came from that side only :-)
Though I am still not sure, if we don't set this config & if spark uses old code, if the table property isn't set here:
https://github.com/apache/iceberg/blob/main/hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java#L595-L596
it will still fallback on the config & if false, it will not set these params, so we should be safe & sorted.

Maybe I'm missing something or my understanding is incorrect, but I don't see how this change enables Hive to read Iceberg tables written by other engines that do not set engine.hive.enabled to true. Other engines that use HiveCatalog use HiveTableOperations from the Iceberg project, not the one here, so if they don't set engine.hive.enabled to true, then the Hive client does not set the storage handler and the SerDe, InputFormat and OutputFormat to the ones used by Hive for Iceberg tables. Unless there is separate change that enables Hive to read Iceberg tables without relying on those things being set correctly in the HMS.
To @pvary's comment, I am not sure if Spark needs to have a jar with HiveIcebergStorageHandler, HiveIcebergSerDe, etc in its classpath when its Hive client makes requests to the HMS on an Iceberg table. In Cloudera's platform, we put the Iceberg Hive runtime jar in Spark's classpath, so it in fact does have those classes in its classpath (but obviously that's not necessarily true for other vendors/platforms). However, we didn't used to do that in earlier days, and Spark was still able to work with Iceberg tables with engine.hive.enabled set to true then (the one problem I recall is with DROP DATABASE ... CASCADE, which fails for some reason).

To @pvary's comment, I am not sure if Spark needs to have a jar with HiveIcebergStorageHandler, HiveIcebergSerDe [..] the one problem I recall is with DROP DATABASE ... CASCADE, which fails for some reason

IIRC the issue is not just with the DROP DATABASE, but DROP TABLE as well. The HMC Client tried to instantiate the StorageHandler set for the dropped table. It is done to make sure that the StorageHandler defined drop methods are called. If the StorageHandler is not on the classpath, then this will fail, and the table could not be dropped.


KeyError: 'state_dicts' when running inference.py

F:\DaChuang\EmoGen>python inference.py --checkpoint_path face_detection/detection/sfd/s3fd.pth --face data/0.mp4 --audio data/1.mp3 --emotion HAP --resize_factor 2
Using cuda for inference.
Reading video frames...
Number of frames available for inference: 1997
Extracting raw audio...
Traceback (most recent call last):
File "inference.py", line 315, in
main()
File "inference.py", line 282, in main
model = load_model(args.checkpoint_path)
File "inference.py", line 184, in load_model
s = checkpoint["state_dict"]
KeyError: 'state_dict'
I prepare data 0.mp4 and 1.mp3, I try to inference on laptop with one 1650Ti. But something went wrong.
Could you please tell me how to resolve this.Thank you very much.

Hi @MMMDY, the checkpoint_path "face_detection/detection/sfd/s3fd.pth" is the checkpoint path for the face detection model that is just required for data preprocessing. It's not the checkpoint for the full model.

Hi @MMMDY, the path "face_detection/detection/sfd/s3fd.pth" is the checkpoint path for the face detection model that is just required for data preprocessing. It's not the checkpoint for the full model.

I got it.There is no pretrained inference model.Thank you very much.


Emojis break markdown links

The readme.md links that start with emojis do not correctly jump me down to the anchor point on the page.
e.g. I click on "💁 What do all these files do?" and my url changes to https://github.com/liferay-design/liferay.design#💁-what-do-all-these-files-do but I am not redirected to that section on the page.

nice — thanks for reporting Alex! that's why nobody has been reading the documentation.... 😂

thanks again for reporting @alexandervalencia — finally fixed by 263


fix on 4.2.2 with django 1.7 : is_hidden = True

with django 1.7, is hidden in no loger an attribute
but a property which compare input_type with "hidden"
this commit make sur that is_hidden will always be False
can be merged in 4.2.2
close #155

You could have used a class attribute I guess, but could you rebase your branch to the latest master for tests?

I will. git always result by a headarch.
to answer your response, I used a property because django did it that way, and so I am sure it won't break any lib that can rely upon this. even if a property is made to be transparent.
I try to run your test with py.test, and i write my own, and then I push

@onysos thanks!


Cannot plot scatter plot in chart having multiple x-axis labels

Expected behavior
Scatter plot is not working for multiple x axis labels.
Current behavior
While plotting scatter plot with single labels(labels will be an array of string or numbers eg: [1,2,3] or ['a','b','c']  ) its working properly, but with multiple x axis labels(labels will be an array of array  eg:  ["['a1','a2']","['a3','a4']","['a5','a6']"]  ) scatter plot is not working.
Reproducible sample
https://codepen.io/ajmalmajeed/pen/xxzyzNM?editors=0010
Optional extra steps/info to reproduce
No response
Possible solution
No response
Context
No response
chart.js version
v4.2.0
Browser name and version
No response
Link to your project
No response

It seems to be working fine with your test input


Which branch should I be working with for extending? [Question]

Issue description:
I've been working on extending the project to add some new controls and additional functionality, but I'm unsure which branch I should be forking.
I initially worked in develop, but I am also working with extending postMessage for said controls, so I'm not sure if I should be working with develop or postMessage-refractor.
Can you give some insight?
Thanks
Version used:
(Did you try using the develop branch from github? There's a chance your issue has already been adressed there)
N/A
Using theme_mods or options?
N/A
Code to reproduce the issue (config + field(s))
N/A

Ah, I see. Yeah, after I got most of the controls working and after making the edits to class-kirki-modules-postmessage.php, I remembered the postMessage-refractor branch.
I forked the project and once I have everything working/cleaned up to match or somewhat match the coding style of the project, I was planning on doing a pull request for you to overlook.
I've been adding a few more controls to the project such as: border, slider-advanced (users can select different suffixes with media queries for multiple devices. Similar to Elementor), etc. I'm working on typography advanced which allows media queries for line height, etc.

can this be closed? #2026

can this be closed?

Nope, I'm keeping it open as a reminder to contact @CaptJiggly and ask about his customizations, implementation etc :+1:


Products supported in MCAS are not clear in specification on site

The products listed in the article are umbrella products (like office). We want to rollout apps to our end users but I need to know they are explicitly protected by MCAS before I roll them out. These are for the web versions and the products I would like clarification on are:

Visio Web
Project Web
Planner
Whiteboard (If I load attachments)
Forms
OneNote
Lists
Office (are all products covered? the office suite entails Publisher and Access and so on..)
Power Platform in general

Could you please add a product specific list as we cannot use the service without knowing it is supported.
Thanks

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 82c7ec0b-8a9e-1aec-f8a6-97864b401aef
Version Independent ID: dc977df5-36a8-0371-c7fa-8f745df452ba
Content: Connect Office 365 to Cloud App Security
Content Source: CloudAppSecurityDocs/connect-office-365-to-microsoft-cloud-app-security.md
Service: cloud-app-security
GitHub Login: @dcurwin
Microsoft Alias: dacurwin

Thanks for your question. We'll investigate and get back to you.

@Scurry-DLG - Thanks again for your question. After investigating the issue, we can now share the that the official list of supported services is here:
https://docs.microsoft.com/en-us/microsoft-365/compliance/search-the-audit-log-in-security-and-compliance?view=o365-worldwide#microsoft-365-services-that-support-auditing
We've updated the MCAS documents to link to that page instead of providing a partial list of supported services. Please check that page for information about which services provide the required logs that MCAS uses.

Thank you for the assistance but that would imply  word/excel/powerpoint/oulook/Project/Visio are not included or is there another list to append?
Stephen

@idbasre @markjjo  - Any thoughts on this?


Custom SignInManager

Hi,
Messing around with a .net core and identity in the MVC projects and i'm attempting to see how we'd use/re-create existing things we already do and how you might implement them.
First,
I see extension methods for .AddUserManager and .AddRoleManager, are there any plans to expose this to the sign in manager too?
I understand the reservations behind not exposing it, however, we would like to track the last login date of any particular user.  In previous generations i was simply inheriting from signinmanager<> and overriding the signinasync functions and after checking their results from base.signinasync, updating the value on the user property before returning back.
However, it doesn't look like i can actually register my own signinmanager.  Is this true?
Second,
If this is true, is there a way for me to register/watch an event or something on the sign in manager that allows me to update values or make additional final decisions before allowing a user to sign in or validate?
I apologize if I missed this in another issue, searching 'signin' only came back with two results on the issues list.
Thanks for your help!
Brent

Upon further looking i see #650 and #646 are apart of this too.
I personally think that the best approach is how the IdentityServer3 team (maybe that's you guys too) did their events.  So on the startup class, i can watch the return even and based on all the passed in information, i.e. SignInResult, or something execute my own project specific code.
the #650 sounds promising, but i'd never store just the time, and as a Company, we've decided to always have 'Utc' on the end of each of our property names if they're dates or 'local' if they're local dates.  Since everyone has their own conventions, I'd personally leave it up to the users to add their own properties and watch this event.
However, should you choose to do #650 my vote would be adding all three as DateCreatedUtc, LastLoginDateUtc and LastActivityDateUtc (this property feels like i'd constantly be hitting the database, might want to leave that one out).
Just my two cents.
Happy Coding,
Brent

I'm not exactly sure what the main issue with this bug is, but if its just about how to override SignInManager, you can just do services.AddScoped<SignInManager<YourUser>, YourSignInManager>() or the equivalent to ensure your custom sign in manager is used instead of the default one.

@brentdavid2008 does the last comment by @HaoK answer your question?

it does, but i still would rather see it as one of the default .AddSignInManager(); functions to add my own type in the <> to be consistent with the rest of the methods that are .AddUserManager() and .AddRoleManager()

Thanks @brentdavid2008. I agree that would be a nice addition although it isn't high priority to do it so moving to backlog for now.
cc @HaoK @blowdart

Dupe of https://github.com/aspnet/Identity/issues/565


Changes feed does not work with couchbase sync gateway

In Couchbase sync gateway's changes feed, chunks don't necessarily correspond to documents, i.e. a JSON object can be truncated. However, couchdb-python calls iterchunks() and tries do decode each single element using JSON which obviously will fail as the JSON object may be truncated.
In order to fix this, I created a quick fix:
https://github.com/djc/couchdb-python/pull/289/commits/25b164e547673de3807a42e7ee0793dfbaf57844
The new iterdocs method tries to decode each chunk, if this fails due to truncation, the current line is saved in a buffer and decoding is retried once the next chunk is there.
However, this is probably not the best / most elegant way to do this.

aiocouchdb apparently had the same issue, was fixed like this: https://github.com/aio-libs/aiocouchdb/commit/6e63d05ce7131feb4f15df31d63d3265d1d34504

Fixed in #289.


The viewer remains sometimes empty when running from IDE

This is a weird one: when running a simple script from an IDE, the viewer sometimes remains empty. I've experienced this repeated with PyCharm, and something similar has recently been reported by a Discord user using VSCode (discord convo).
I can reproduce with a certain reliability using this:
import time
import rerun as rr

rr.init("test", spawn=True)
#time.sleep(2)
rr.log_points("points", [(0, 0), (2, 2), (2, 2.5), (2.5, 2), (3, 4)], radii=0.5)

Uncommenting the sleep() call appears to reduce the rate of occurence.
I've never seen that when launching from the CLI, same for the discord user.
This resemble #2124, but is probably different, as the sleep call is before the logging call, rather than at the end. It's as if the viewer takes too long to start and the logged messages are dropped.

I'm seeing this issue more prominently when I stream to a file instead of connecting to a viewer - the first call (typically view_coordinates -.-) may be lost then.
Critical issue imho, nothing worse than getting flaky behavior

We should investigate this before the release, but timebox the investigation.


Download SRS if it doesn't exist on disk

Reminder for us:

[ ] update README, remove necessity of running download_srs_aztec.sh
[ ] add a new tag (don't have to have a new release, just reuse the same release assets as v0.2.0
[ ] push to crates-io


Juliya/init augur tests false pos

We'll bring over the update jest tests from augur-ui v1

the one from


Missing vouchers

Much like many others, I am missing some vouchers. A particle voucher and a size voucher. IGN is Ze_Penguino

Refunded.


Glassmorphism Form

Description
I would like to add Glassmorphism form component to this repository.  I am a participant of script winter of code.
Screenshots
No response
Additional information
No response

Description
I would like to add Glassmorphism form component to this repository. I am a participant of script winter of code.
Screenshots
No response
Additional information
No response

sure @siddhi-244 go for it. 🚀

Please check my pr!

Please check my pr!

According to the program guidelines no PRs should be accepted before Dec 11.
@Ovenoboyo has suggested some changes.
Also, avoid making your changes in the main branch, always create a new branch and make your desired changes in that branch.

Please check my pr!

According to the program guidelines no PRs should be accepted before Dec 11. @Ovenoboyo has suggested some changes. Also, avoid making your changes in the main branch, always create a new branch and make your desired changes in that branch.

Ok sure. Will do that.


[Bug] Conversion metric with window fails on BigQuery

Is this a new bug in dbt-core?

[X] I believe this is a new bug in dbt-core
[X] I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior
Conversion metrics without a window seem to work as expected with the bigquery adapter.
Adding a window e.g. window: 7 days causes the following error:
Encountered an error: error querying against the semantic layer: INVALID_ARGUMENT: [FlightSQL] [Simba][BigQueryJDBCDriver](100032) Error executing query job. Message: 400 Bad Request
POST https://bigquery.googleapis.com/bigquery/v2/projects/myproject/jobs
{
  "code": 400,
  "errors": [
    {
      "domain": "global",
      "location": "q",
      "locationType": "parameter",
      "message": "No matching signature for operator > for argument types: TIMESTAMP, DATETIME. Supported signature: ANY > ANY at [46:11]",
      "reason": "invalidQuery"
    }
  ],
  "message": "No matching signature for operator > for argument types: TIMESTAMP, DATETIME. Supported signature: ANY > ANY at [46:11]",
  "status": "INVALID_ARGUMENT"
} (InvalidArgument; Prepare)

Expected Behavior
No error occurs
Steps To Reproduce

Create a simple conversion metric. Our exact metric:

- name: conv_completetrial_to_purchases
  description: "Conversion rate from completing trial to purchasing within 7 days"
  type: conversion
  label: Completed First Trial to Purchase Conversion Rate (7-day window)
  type_params:
    conversion_type_params:
      entity: customer
      base_measure:
        name: customers_firsttrialdt
      conversion_measure:
        name: customers_firstpurchdt
      window: 7 days

Note that the agg_time_dimension field for both customers_firsttrialdt and customers_firstpurchdt is of type TIMESTAMP.

Query this metric, and you'll reproduce the error
Remove the window, and the query will be successful

Relevant log output
No response
Environment
dbt Cloud=1.7.8
Registered adapter: bigquery=1.7.6

Which database adapter are you using with dbt?
No response
Additional Context
No response

Thanks for reaching out @KayakinKoder.

Note that the agg_time_dimension field for both customers_firsttrialdt and customers_firstpurchdt is of type TIMESTAMP.

Out of curiosity, did you try an example using columns with the DATETIME data type instead of the TIMESTAMP data type?
The former is equivalent to WITHOUT TIME ZONE from the SQL standard, whereas the latter is equivalent to WITH TIME ZONE, and I'm wondering if that is involved in the issue that you are experiencing.

@dbeatty10 we don't have any DATETIMEs in our warehouse, but I'll try to set up a test. That is likely the issue -- but I believe dbt should be using a different date diff function here. TIMESTAMP is (by far) the most commonly used data type: https://stackoverflow.com/a/47724366/3650835

So: yes converting the measures from TIMESTAMP to DATETIME types resolves this issue. That said -- and I'm definitely not a BigQuery expert by any stretch -- I think TIMESTAMP types are much more commonly used that DATETIME

Thanks for trying that out and confirming that DATETIME works whereas TIMESTAMP does not 👍
Short story
Here's the short story:

MetricFlow currently uses timezone-agnostic types for all date/time operations

In the case of BigQuery, this means MetricFlow uses DATETIME ("naive") rather than TIMESTAMP ("aware").
So you may need to convert your time zone aware TIMESTAMPs into the equivalent in UTC and then cast to time zone naive DATETIMEs.
More detail
In my experience, naive timestamps are quite common. They align with the approach that dbt has recommended since at least 2018 in relation to date/times. You can read more background here.
However, we do have an open issue to allow a configurable time zone in MetricFlow:

https://github.com/dbt-labs/metricflow/issues/733#issuecomment-1726411113

I'm going to transfer this issue to our metricflow project for further follow-up.


WIP Indicate when the contact details were last updated

One option is to have this in the model as done here. I don't think this justifies a cube. On the other hand this is a (cheap) query per cube.
The idea with last_updated is to be a partial ISO8061 time where the rest can be parsed as zeros - perhaps it's worth just having the full timestamp but that's kinda saying more than we can?
This is the precursor to being able to indicate somewhere "The contact details are correct as at xxxx and is updated quarterly"
The update_cycle values can match values in "period_length" which are currently year and month although "quarterly" and "annual" are really the terms used for this kind of thing

@longhotsummer what do you think? About the priority of this and the solution. If you like this part of the solution and think it's a prio I'll do something for the frontend. I'm worried adding this to the scorecard makes it too much info but perhaps it's ok under contacts and for the rest it can be under "how calculated"

Sounds good to me. I'm happy with semi-static metadata on the model, I think it's a good approach.

Tweaked - @jbothma can I merge?


[BUG] All placeholders need a non-null sender even if it its not used

What is the bug?
Placeholders such as %betterTeams_position_etc% need a online sender, which is not required.
Expected Behaviour
Return good value, even with a null sender.
How to Reproduce
/papi parse --null %betterTeams_position_name_1% -> returns "" instead of team's name.
Error message
No response
Output of /teama version
[BetterTeams] Storage Method: com.booksaw.betterTeams.team.storage.storageManager.SeparatedYamlStorageManager
[BetterTeams] Minecraft Version: git-Paper-55 (MC: 1.20.1)
[BetterTeams] Language Selected: messages
[BetterTeams] Current plugin version: 4.6.7
Additional Information
No response

This feature has been implemented and will be included in the next update. Thank you for the suggestion.


Better Sync'ing of Translations on Updates

The workflow defined now for new translations works okay. When we add new chapters that works as well. There isn't a good workflow for when the documentation is updated.
Other documentation projects HOT is involved in use Transifex to track the changes and make it easier to contribute translations when strings change. I looked into what we might need to do if we were to use Transifex.
Questions:
Other applications HOT is involved in documentation for use PO files, is there a path to switch to this or should we be doing something else?
Other possible file formats: http://support.transifex.com/customer/portal/articles/971979-supported-file-formats
Workflow InaSAFE is using as reference using QTLinguist (has been since moved to Transifex): https://github.com/aifdr/inasafe-doc
Any suggestions on a workflow for this? Or is there another tool we should be using? My major concern is now that we are updating LearnOSM that the translations are getting away from us.
@lxbarth @jeffhaack @mikelmaron

Using Transifex has mitigated this.  Update the source version and as the translations are done it removes the old versions.


Documentation CI is not working

Looking at the CI fail

julia_cmd=( julia --color=yes --code-coverage --project=docs/ -e 'using Pkg; Pkg.develop(PackageSpec(path=pwd())); Pkg.instantiate()' )

Is erroring because the path should be to the EpiAware subdir.

I think we want this

I think we don't need an issue for this as that feature is in a draft PR!


JavaScript

JavaScript
User Story
As a boot camp student
I want the prework notes to be structured on a webpage
So that I can Easily find and read the information
Acceptance Criteria
GIVEN a Prework Study Guide Website
WHEN I view the study guide
THEN I can see the four topics I learned listed along with a suggestion on what I should study first

Done and done!


A functional test to verify VM to VM connectivity

Signed-off-by: Vladik Romanovsky<EMAIL_ADDRESS>

@vladikr I can see that all runs have failure
[Fail] Networking VirtualMachine with nodeNetwork definition given should be able to reach [It] the Inbound VM
/root/go/src/kubevirt.io/kubevirt/tests/vm_networking_test.go:133

Can you please check it?

Can you please check it?

Yea, I'm still trying to figure this out...
This test works fine when I'm running only the networking related tests but fails when running all functional tests together.

Looking good so far. @vladikr As far as the errChan--I think the issue is that the "defer GinkoRecover" call is also inside a goroutine.

I realized that the problem is really with the cirros image that we are testing on.
Apparently, the version of netcat get stuck waiting for I/O, even after the set timeout - also there is no bash, but this is less of a problem.
I'm going to change the test to just test vm to vm ping instead of netcat.

retest this please

retest this please

@vladikr We still have two failures on dev manifests
[Fail] Networking VirtualMachine with nodeNetwork definition given should be reachable via the propagated IP from a Pod [It] on a different node from Pod
/root/go/src/kubevirt.io/kubevirt/tests/vm_networking_test.go:178

[Fail] Networking VirtualMachine with nodeNetwork definition given should be reachable via the propagated IP from a Pod [It] on a different node from Node
/root/go/src/kubevirt.io/kubevirt/tests/vm_networking_test.go:178


Support for immutability checks

When I write JavaScript code, I try to treat objects and arrays as immutable, and I prefer writing pure functions whenever possible. I find this makes code much easier to reason about and avoids lots of subtle bugs. (I learned about the practical benefits of immutable collections from Clojure.)
So it would be nice if Flow could have some sort of immutability checking. With a "const" annotation, the programmer could:

Annotate a variable to indicate it is not supposed to change after initialization
Annotate a function parameter (say an Object or an Array) to guarantee that it won't be modified by the function
Annotate a returned Object to indicate it is not supposed to be altered by the calling code. (This is important for closures or classes that might use the returned Object internally in the future.)

Additionally, a function could have a "pure" annotation to indicate that Flow should check that a function has no side effects. Of course, all functions called by a pure function would need to be checked for purity as well.
Preferably, immutability should apply to nested objects, such as { a : { b : 'c' }}. (In JavaScript, unfortunately, the Object.freeze() function does not prevent nested objects from being modified.)
Flow looks extremely nice, BTW. Thank you for making it open source.

I think the important thing here is the const annotation.  Persistent data structures are a whole different topic.

Idea: a contract of immutability for objects and arrays.
E.g.
function foo <T> (x : Immutable<T>) : number {
  x.value = 1; // ERROR: `x` is Immutable<T>
  return x.value;
}

the contract is also considered broken if you call any function that doesn't implement the contract:
function bar <T> (x : T) : number {
  x.value = 1;
  return x.value;
}

function foo <T> (x : Immutable<T>) : number {
  return bar(x); // ERROR: `x` is Immutable<T>, bar expects mutable T
}

function qoo <T> (x : Immutable<T>) : number {
  return x.value;
}

function doo <T> (x : Immutable<T>) : number {
  return qoo(x); // this is OK
}

function too <T> (x : T) : number {
  return x.value;
}

function hoo <T> (x : Immutable<T>) : number {
  return qoo(x); // this is OK too, b/c can be statically analysed
}

Thank you for reporting this issue and appreciate your patience. We've  notified the core team for an update on this issue. We're looking for a response within the next 30 days or the issue may be closed.

I'd say that if starting of scratch the bias here would be to assume all arguments are read-only, since this is the common and safe case, and require annotations when an argument can be mutated .
function append(a: string[], b: string) {
  return a.push(b)
}
==> ERROR: Call to push mutates a read-only argument

function append(a: var string[], b: string) {
  return a.push(b)
}
==> Flow checks sucessfully.

In any case having a way to express this would be a clear win for type-safety.

I just ran into a related mistake that ideally flow would be able to catch:
function thingy(x) {
  var foo = Immutable.Map({bar: 'baz'});
  if (x) foo.merge({foo: 1});
  return foo;
}

The mistake here is that the line should read return foo.merge, because the .merge function is entirely pure it must be an error to not use the return value in any way.

+1, but -1 to overloading the keyword const.

I like the proposal from @jussi-kalliokoski to solve the syntax issue. Just add a magic type called Immutable or NoMutate or something else. (Immutable is probably not a good idea since Immutable.js exists)
But further, it's very important to add a way to annotate object and class methods as non-mutating.
So that this is no longer a type error:
var map: Immutable.Map<string, number>
var x = map.get('x') && map.get('x') > 10

As of right now, Flow thinks that .get could mutate the object map itself, and so the && doesn't work.
Instead, the workaround for now is:
var map: Immutable.Map<string, number>
var xVal = map.get('x')
var x = xVal && xVal > 10

However, it's not the end of the world to have to define a few extra variables for type-safety. So I support the team focussing on the general use case before tackling these features.

An other use case for  Immutabilty would also be to solve type casting errors
like in this example:
/* @flow */
type Foo = { foo: boolean }
type Bar = Foo & { bar: boolean }

const bars: { [key: string]: Bar } = Object.freeze({})
const foos: { [key: string]: Foo } = bars //  generate an error

/* @flow */
type Foo = { foo: boolean }
type Bar = Foo & { bar: boolean }

const bars: { [key: string]: Bar } = {}
const foos: { [key: string]: Foo } = { ... bars } //  work around

/* @flow */
type Foo = { foo: boolean }
type Bar = Foo & { bar: boolean }

const bars: Array<Bar> = []
const foos: Array<Foo> = bars.slice() //  generate an error

/* @flow */
type Foo = { foo: boolean }
type Bar = Foo & { bar: boolean }

const bars: Array<Bar> = []
const foos: Array<Foo> = [...bars] //  workaround

The caveat with a special Immutable type (or any way to signify immutability) would be that it only works shallowly.
type ImmutableRecordSomething = $Immutable<{ value: ?string, child: { value: ?string } }>;
const record: ImmutableRecordSomething = {
  value: 'a',
  child: { value: 'b' },
};

record.value = null // Flow error, record is immutable
record.child.value = null // Just fine, only record is protected normally

although that could be solved by doing child: Immutable<{ value: ?string }> I guess.
Another issue would be passing it to other functions. If they are not set up to use flow, they would invalidate the immutability.
type ImmutableRecord = $Immutable<{ value: ?string }>;
const record: ImmutableRecord = { value: 'a' };

record.value = null // Flow error, record is immutable

// Assuming that lodash' mapValues has no flow types and it can't infer immutability
const newRecord: ImmutableRecord = _.mapValues(record, (x) => x);

record.value = null // No error, record is downgraded to mutable because of mapValues

What about creating something similar to inout parameter in swift

Function parameters are immutable by default.
Trying to change the value of a function parameter from within the body of that function results in a flow error.
If you want a function to modify a parameter’s value, define that parameter as an in-out

In terms of naming, would like to throw another option into the hat $Frozen<type>
eg
$Frozen<{ value: ?string }>
$Frozen<Array<number>>

@cloudkite that could be confusing, or maybe colliding with a possible type for objects that have actually been Object.freeze()-ed
@pgherveou As much as I would love to have explicit mutability like this, I think flow should typecheck on working javascript code, and in javascript you are allowed to mutate your parameters :-/

I know that saying '+1' is extremely annoying, but... +1 here :) I would love this feature.
I wanted to somehow use Immutable Record for this, but it seems it's not very flexible no matter how I try to hack it to work with Flow (no way to capture disjoint unions, for example).

I think $Frozen<T> makes sense as it would just be a way to describe the result of Object.freeze(T), which is already supported by Flow.
Then the definition of Object.freeze could be updated like so:
declare class Object {
    static freeze<T>(o: T): $Frozen<T>;
}

Might try to make a PR for this just to get discussion going and also as a good excuse to learn OCaml 😄

This feature basically exists now.
When using an object, you can mark all keys as covariant which makes them read-only. Plus, use an exact type to avoid allowing extra keys as well.
type ImmutablePerson = {|
  +name: string,
  +age: number
|};

As for Arrays, you can use $ReadOnlyArray instead of Array.
There are still edge-cases when dealing with other in-built Objects such as Date, Function etc. but that seems like enough of an edge-case.

I think it would still be useful to mark an argument as read-only, as opposed to properties.

@glenjamin That can easily be done with a lint rule.

I was thinking about having a type which is normally mutable, but defining a function which uses that type in a read-only way. I don't think that can be done with per-property covariance or a lint rule?

Immutability is now supported!
Please let us know if this does not cover all of your use cases.
If you want to assume that all function arguments are immutable we have an experimental option experimental.const_params. We want to explore making params constant by default and then disable that assumption if you assign to the function argument.
const a: {
  +prop: number
} = {
  prop: 42,
};

const b: $ReadOnlyArray<number> = [1, 2, 3];

const c = Object.freeze({
  prop: 42,
});

a.prop = 1; // Error
b[0] = 2; // Error
c.prop = 3; // Error

Thanks! This sounds great. Does it enforce the immutability of nested objects and arrays? And is it possible to annotate a function declaration to guarantee that a return value will be constant?

Is it possible to declare an object as being frozen without using Object.freeze?


Implement Loan Liquidation

Liquidations view #2

LiquidateView

LiquidateReserveView

Remaining tasks:

Calculate LTV for liquidatable loans
Wire liquidate() request to LiquidayeReserveView
Support partial liquidation in LiquidayeReserveView


Include object id in output

I often work with similar objects and var_dump with xdebug has the neat feature of outputting the spl_object_id which makes it easy to find out if two outputs belong to the same object or not. Can you include the object id into the output?

I have added a pull request #335 that implements this rendering

Done in b5841ee834121b5f3399184466b8ac43956885fa


Add listStatuses repo endpoint

Adds the Repo endpoint for https://api.github.com/repos/<user>/<repo>/statuses/<sha>
edit: Build is failing but this seems unrelated -
npm ERR<EMAIL_ADDRESS>install: `node install.js`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script 'node install.js'.```

Hi @pik and thank you for your PR. Can you please add a test for your method and also update the README to document it?

Updated tests and readme - also I switched to getStatuses from listStatuses since that seems more consistent with the endpoint taking a single sha for an argument.

Thank you for the update. I'm going to merge this PR.

Merged with a minor update. Thank you for contributing.


Feature/#1 Base migrations and models for Feedback

Added required models for feedback under config/feedback.php
Added Feedback migration with up/down methods
Added Feedback model
Added FeedbackFactory

@drewroberts the FeedbackFactory may need some additional refactoring. Most likely either/or:

Update comments to reflect usage of $this->faker->boolean at the different steps
Refactor to better walk through the different cases of user feedback

I'm going to go ahead and merge this and then you can do the refactoring on the factory.
This package should also contain some commands that are in the main application.


fix bugs in bufExpl.py and rgExpl.py

When using
:Leaderf buffer --nameOnly --auto-preview

if the input does not match any buffer, string variable line is empty and the method _previewInPopup will raise a ValueError.

When using
:Leaderf rg --nameOnly --auto-preview

if the input does not match any buffer, variable m is None and the method should return (None, None).

Thanks.


Request feature

the possibility to grab the page's main color.
aliyss

I'm sorry I don't understand what do you mean by "main color" is there a specific html property defined for this?

I'm so sorry for the quite unreasonable request.
No what I mean't was, it would be nice to get the icon of the page, the color itself would be something I would have to do seperately

ah, the favicon, sure, sounds like a good idea, I don't know when I will have time to integrate this, feel free to submit a pull request though.

sry, but I'm not using GitHub very often what does a pull request do?


Update switch-to-microsoft-defender-setup.md

@JohanFreelancer9 - kindly do the copy editor review for this PR. Thanks


Request: Support LEDE 17.x

I recently upgraded to LEDE 17.01, and I was able to install luci-app-access-control_0.4.1_all.ipk, it did not appear under the Network menu, even after a page refresh or a reboot. Would you consider supporting your package in LEDE?

Sorry, after a second reboot, it appeared. I don't know if it was a delay in luci making it ready or what.


Make sensor.ring to handle scan_interval option as expected.

Description:
Makes ring.sensor to handle properly the scan_interval option.
This patch also adds a debug statement for troubleshooting purposes.
17-03-18 02:11:31 ERROR (MainThread) [homeassistant.bootstrap] Invalid config for [sensor.ring]:
expected int for dictionary value @ data['scan_interval']. Got datetime.timedelta(0, 10). (See ?, line ?).
Please check the docs at https://home-assistant.io/components/sensor.ring/

With this patch now is possible to assign a value to scan_interval as expected.
Checklist:
If the code communicates with devices, web services, or third-party tools:

[x] Local tests with tox run successfully. Your PR cannot be merged unless tests pass

I tested with different 1scan_interval values and worked as expected.

💃 🐬


cli works but crashes at the end

After running trimage with:
trimage -d .
It seems to successfully process all files, but ends with a crash:
Exception ignored in: <function Worker.__del__ at 0x7fd26857d9d0>
Traceback (most recent call last):
  File "/usr/lib/python3.8/site-packages/trimage/trimage.py", line 414, in __del__
  File "/usr/lib/python3.8/site-packages/trimage/ThreadPool/ThreadPool.py", line 172, in shutdown
TypeError: 'NoneType' object is not callable

Running the newest version, installed with yay -S trimage on Arch Linux.

Can confirm, this is happening to me as well with trimage 1.0.6 and Python 3.8.5 on Ubuntu 20.04.1 LTS.

I had the same issue, worked after buidling trimage from sources. This issue was fixed in #76 so it probably can be closed now.

@diklimchuk The current version in the Ubuntu package repo is 1.0.6, which was released before the fix. So anyone installing from there will still experience the issue.

Can we get a new release for Ubuntu?
Incidentally the "Download for Ubuntu" link on trimage.org is now broken; it gets redirected to snapcraft.io, and Trimage isn't there. (apt install still works)

Oh, and it's confusing because when building from source, the version reported is still 1.0.6 -- would be helpful to get a version bump too.


Added new developer for 'calender-view-plugin'

Description

Requesting access to develop on the 'calendar-view-plugin' as discussed in https://groups.google.com/g/jenkinsci-dev/c/I03rPPkYSTY/m/1Tul1kwJBAAJ.
Repo: https://github.com/jenkinsci/calendar-view-plugin
@svenschoenung
@malice00
Submitter checklist for adding or changing permissions

Always

[X] Add link to plugin/component Git repository in description above

For a newly hosted plugin only

[ ] Add link to resolved HOSTING issue in description above

For a new permissions file only

[ ] Make sure the file is created in permissions/ directory
[ ] artifactId (pom.xml) is used for name (permissions YAML file).
[ ] groupId / artifactId (pom.xml) are correctly represented in path (permissions YAML file)
[ ] Check that the file is named plugin-${artifactId}.yml for plugins

When adding new uploaders (this includes newly created permissions files)

[X] Make sure to @mention an existing maintainer to confirm the permissions request, if applicable
[X] Use the Jenkins community (LDAP) account name in the YAML file, not the GitHub account name
[X] Make sure to @mention the users being added so their GitHub account names are known if they require GitHub merge access (see below).
[X] All newly added users have logged in to Artifactory at least once

Reviewer checklist (not for requesters!)

[ ] Check this if newly added person also needs to be given merge permission to the GitHub repo (please @ the people/person with their GitHub username in this issue as well). If needed, it can be done using an IRC Bot command
[ ] Check that the $pluginId Developers team has Admin permissions while granting the access.
[ ] In the case of plugin adoption, ensure that the Jenkins Jira default assignee is either removed or changed to the new maintainer.
[ ] If security contacts are changed (this includes add/remove), ping the security officer (currently @daniel-beck) in this pull request. If an email contact is changed, wait for approval from the security officer.

There are IRC Bot commands for it

see https://github.com/jenkins-infra/repository-permissions-updater/pull/1995/checks?check_run_id=2865603150

Welcome aboard


HOCS-3251 save foi topic in data input stage

Added a step to add the primary topic to the current case in the FOI Data Input stage

Hi @abarker66, the workflow phase to register the Primary Topic doesn't seem to activate, nor is it in the case. That being said, the selected Topics is saved fine,  it's just the primaryTopic that isn't. Furthermore, as it's not part of the new schema defined for FOI Data Input, so there's no visibility of the variable after submission. I think it's worth asking what value this holds for FOI and potentially we could remove the workflow stage entirely.

I rebuilt the workflow and it does save the primary topic and it is in the case. The data input stage will likely change but the FOI Topic defined in this ticket) can be reinserted in the updated stage/screen.


Opening the changelog causes JavaScript error

Expected Behavior
When opening the changelog from the menu bar, I would expect to see the changelog for insomnium (https://github.com/ArchGPT/insomnium/releases)
Actual Behavior
A javascript error is thrown:

Reproduction Steps

From the menu bar, click "Application" > "Changelog"

Is there an existing issue for this?

[X] I have searched the issue tracker for this problem.

Additional Information
No response
Insomnium Version
0.2.0
What operating system are you using?
Other (specify below)
Operating System Version
Operating System: Arch Linux,  KDE Plasma Version: 5.27.8, KDE Frameworks Version: 5.110.0, Qt Version: 5.15.11, Kernel Version: 6.1.57-1-lts (64-bit), Graphics Platform: X11
Installation method
AUR
Last Known Working Insomnium version
No response

aw good find; this is fixed in the next release

Opening the changelog from the menu now leads to https://github.com/ArchGPT/insomnium/releases/tag/core, which gives a 404 error. The correct URL would be https://github.com/ArchGPT/insomnium/releases/tag/core%400.2.2

oh yeah thanks for spotting this out; I was deciding whether to show user the versioned one, or the full changelog of all versions. I think later would would be better (so ppl can see the latest release as well as old ones, in case they are in an older ver) but I put the wrong url with /tag/core


Add support for detecting EngineX, used by many 2001+ Eurocom games

SteamDB app page links to a few games using this

Sphinx and the Cursed Mummy
Pirates of the Caribbean: At World's End
G-Force
Beijing 2008
Vancouver 2010
Disney Universe
007 Legends

Brief explanation of the change
Add support for detecting EngineX, used by many 2001+ Eurocom games, from Pirates of the Caribbean, to 007, to adventure games like G-Force, Robots (2005), and Sphinx and the Cursed Mummy as well as Olympic games.
https://sphinxandthecursedmummy.fandom.com/wiki/EngineX
RegExr test filenames
data/Filelist.bin
_bin_PC/BuildData/Filelist.bin
_bin_PC/BuildData/Filelist.cfi
PCAudio.dll

Some other unique files worth scanning for: PCGamePadDB.dll, PCXMLParser.dll, DATA/filelist.000.

Let me know if there is anything else I should be doing. Happy to squash it or narrow the patterns down.

PCAudio.dll only matches one game that already has data/Filelist.bin, so it can be removed.

Thanks for taking a look.
I wasn't sure (searching the depots via Google advanced query misses plenty of pages, especially for delisted stuff) and given that this should only search for those specific files in specific folders I don't think there's going to be many false positives.
The idea is that if other PC games get eventually brought to Steam in the future by more publishers, with each doing something slightly different (the main asset package doesn't need to be called Filelist.bin), at least we have that DLL as fallback.
I can try to find some time to remove .CFI from there, and whatever is needed to get this merged.
--
PS: Would be neat to have the full list of games that match this, not sure if I have missed anything. ¯\_(ツ)_/¯

@xPaw Should be done, leaving only the Filelist.bin pattern. Let me know what you think.

Hi, @xPaw. Quick question, when can we expect these changes to reach the main site? I see the Current rule set hash is 2fd9ab6 thingie, but it's not clear if this is re-run manually, monthly or after enough new things are added.
Very low-priority stuff, but I'm still interested in seeing the results. Thanks in advance.


simulate mouse event second button

how to simulate mouse event second button?

Or you can pass the button value using simulates second argument:
wrapper.simulate('click', { button: 1 })

I'm going to close this issue as it reports nothing wrong with enzyme itself. Feel free to keep the conversation going however!

Just for reference, right mouse button triggers 'contextmenu' event, so this is also can be simulated as:
wrapper.simulate('contextmenu');


Fix test_format_xml with dot in path

When the path contains dot ".", replacing all dots will generate a non-exist result and raises a FileNotFoundError. Replacing only the last dot fixes this.

Uh, thanks!


feat: add logos for curve pools

Please review the following token assets:
📑 Description
add missing logos for several curve factory vaults

✅ Checks

[x] I created a new folder with the token address, all in lowercase
[x] I added the token's logo as a 32x32 PNG file, named logo-32.png
[x] I added the token's logo as a 128x128 PNG file, named logo-128.png
[x] I added the token's logo as a SVG file, named logo.svg
[x] My SVG logo is a proper SVG and not some base64 stuff
[x] My documentation/website clearly display the token address somewhere

1


Fixed dag id of tf 2.16 DAGs

Description
The DAG id was the same as the nightlies and was causing a collision. This change fixes that.
Tests
Please describe the tests that you ran on Cloud VM to verify changes.
Instruction and/or command lines to reproduce your tests: ...
List links for your tests (use go/shortn-gen for any internal link): ...
Checklist
Before submitting this PR, please make sure (put X in square brackets):

[ X ] I have performed a self-review of my code.
[ X ] I have necessary comments in my code, particularly in hard-to-understand areas.
[ X ] I have run one-shot tests and provided workload links above if applicable.
[ X ] I have made or will make corresponding changes to the doc if needed.

Please run the test this time.


Franz does not work anymore

A few days ago, I was logged out of all services, only prompting me to "get started". Clicking this led me to choose my services. However, no services were found whatsoever (I normally use Whatsapp, Facebook Messenger and Gmail).
I logged out and tried to log in again. Upon logging in, the wheel turned for a while and stopped, leaving me logged out and saying "Can't connect to Franz online services". Reinstalling didn't resolve the issue.
This happened on three computers and on Mac OS X High Sierra and Windows 10 64-bit, both current versions and in several networks.
I tried logging in on the website without success. I was also unable to create a new account. I used Chrome browser current version for website use.

Same issue here. Already created an issue for it, which was completely ignored.
https://github.com/meetfranz/franz/issues/1438#issue-446214199

Franz inicializa o serviço porém não carrega e fica como inicializado no Gerenciador de Tarefas.


Added Contribution

This is my first contribution, so I apologize if I did anything wrong!
Here's my p5 code (which I made by pasting my Processing code and changing the syntax around): https://editor.p5js.org/Veta314/sketches/Skm8IvjxV

Awesome ❤ Thank you for this contribution.

Amazing, you did great!!!

Thank you guys! <3


Fix text overflow on extension cards and extension detail pages

Resolves #25.
To fix crowding on the extension detail page, I relaxed the requirement that all rows be the same height.
Fixing overflow on the cards took a bit more thought. Getting ellipses to show on a single line of text is straightforward, because there’s a well-supported css property for it. For multi-line text, it’s less obvious what the right solution is. I didn't want to do pre-processing of the actual data before rendering, because it would require a lot of assumptions about text size and character width and seemed error-prone.
I started working through the instructions in https://css-tricks.com/recreating-mdns-truncated-text-effect/ and it was looking quite smart, with a neat fade on the quinoa card. It was a bit fiddly, though, so it would have needed a fair bit of debugging and multi-browser testing. I decided, after reading the comments, that adding gradients all over would slow the page render. What’s worst, almost all of them would never show.
https://kiranworkspace.com/ellipsis-to-multiline-text-in-css/ suggests that a -line-clamp property would work. This is a new property, so support is patchy. For me, it didn’t work, and I was cursing my life and trying to decide on a backup plan … and then I realised I was making changes locally and then checking against the live site.
caniuse.com suggests the version without the -webkit prefix has slightly more support than with. For me, only the -webkit version worked. I’ve included both, for belt-and-braces. If neither works, the worst that happens is that the text is cut off without an ellipsis.
I set a line height to make calculations easier, but I’ve checked and the line spacing is the same before and after my changes.

I take back the comment about belt-and-braces, since I realised when checking the preview that adding line-clamp seems to stop -webkit-line-clamp from working.
Before:

After:

With these changes, I should now be ready to do #97 .


add contributing guide

added CONTRIBUTING.md file and updated README contributing section to reference it.
Signed-off-by: Bryce Palmer<EMAIL_ADDRESS>

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+3.3%) to 70.962%

Totals

Change from base Build<PHONE_NUMBER>:
3.3%

Covered Lines:
391

Relevant Lines:
551

💛  - Coveralls


iOS TextField crash when using speech-to-text

Describe the bug
When using the builtin iOS speech-to-text feature to enter text into a TextField the app crashes with a stack trace pointing to Compose Multiplatform.
Affected platforms

iOS

Versions

Kotlin version*: 1.9.22
Compose Multiplatform version*: 1.6.0
OS version(s)*: confirmed on iOS 15.8 and 17.3.1
OS architecture: arm64
Device: confirmed on iPhone 7 (iOS 15.8) and iPhone XR (iOS 17.3.1)

To Reproduce

Run an iOS app with a Compose Multiplatform TextField
Tap the TextField to bring up the keyboard
Tap the microphone icon to start speech-to-text
Say something and wait for speech-to-text recognition
App crashes

Expected behavior
No crash, and speech-to-text recognized text entered into TextField.
Additional context
It seems speech-to-text did work at some point: https://github.com/JetBrains/compose-multiplatform/issues/2984
We have two similar but slightly different stack traces from production builds. The first one looks like this:
0   App             0x102e341d0 kfun:androidx.compose.ui.platform.toTextIterator#internal + 1040 (UIKitTextInputService.uikit.kt:0)
1   App             0x102e334a4 kfun:androidx.compose.ui.platform.UIKitTextInputService.object-2.isPositionAtBoundary#internal + 180 (UIKitTextInputService.uikit.kt:568)
2   App             0x102e57c78 kfun:androidx.compose.ui.platform.IOSSkikoInput#isPositionAtBoundary(kotlin.Int;platform.UIKit.UITextGranularity;kotlin.Long){}kotlin.Boolean-trampoline + 200 (IOSSkikoInput.uikit.kt:140)
3   App             0x102e57c78 kfun:androidx.compose.ui.window.IntermediateTextInputUIView.object-1.isPosition#internal + 492 (IntermediateTextInputUIView.uikit.kt:554)
4   App             0x1035def7c _6f72672e6a6574627261696e732e636f6d706f73652e75693a75692f6f70742f6275696c644167656e742f776f726b2f383339343731666333323931333563372f636f6d706f73652f75692f75692f7372632f75696b69744d61696e2f6b6f746c69... + 336
5   UIKitCore       0x184545094 +[UIDictationUtilities needsTrailingSpaceForPhrases:secureInput:] + 556 (UIDictationUtilities.m:388)
....

The second kind is almost identical, but the UIDictationUtilities method that calls into Compose is selectionStartInfoWithBlock instead.
In a debug build, we couldn't tell what UIKit method calls into Compose, but we found that a kotlin.NotImplementedError is thrown here:
https://github.com/JetBrains/compose-multiplatform-core/blob/99c5d1d3bd7eba7dbebcd42af0897f8862291822/compose/ui/ui/src/uikitMain/kotlin/androidx/compose/ui/platform/UIKitTextInputService.uikit.kt#L614
UITextGranularity.UITextGranularityParagraph -> TODO("UITextGranularityParagraph iterator")

Is there any way for us to work around this issue, or is speech-to-text broken until Compose Multiplatform implements these TODOs?

I also encountered the same problem. When I use voice input, the iOS app crashes. I'm using iOS 17.4.

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.


Broken bookmarks

Local builds indicate broken bookmarks. I'd patch these myself, but I'm 🏃😅 on Blazor issues for the foreseeable future and don't have time right now. Please close this issue if this will be tracked in some other way.

(security/authorization/secure-data.md#L52)Invalid link: 'scaffolding'. The file tutorials/first-mvc-app/adding-model.md doesn't contain a bookmark named 'scaffold-the-movie-model'.
(security/authorization/secure-data.md#L408)Invalid link: 'scaffolding'. The file tutorials/first-mvc-app/adding-model.md doesn't contain a bookmark named 'scaffold-the-movie-model'.
(tutorials/first-web-api.md#L1420)Invalid link: 'Attribute routing with Http[Verb] attributes'. The file mvc/controllers/routing.md doesn't contain a bookmark named 'attribute-routing-with-httpverb-attributes'.
(tutorials/first-web-api.md#L1517)Invalid link: 'Attribute routing with Http[Verb] attributes'. The file mvc/controllers/routing.md doesn't contain a bookmark named 'attribute-routing-with-httpverb-attributes'.
(host-and-deploy/health-checks.md#L2241)Invalid link: '<xref:fundamentals/middleware/index#use-run-and-map>'. The file fundamentals/middleware/index.md doesn't contain a bookmark named 'use-run-and-map'.
(migration/http-modules.md#L65)Invalid link: 'Pipeline branching'. The file fundamentals/middleware/index.md doesn't contain a bookmark named 'use-run-and-map'.
(fundamentals/configuration/index.md#L835)Invalid link: '<xref:fundamentals/environments#development>'. The file fundamentals/environments.md doesn't contain a bookmark named 'development'.
(fundamentals/configuration/index.md#L1683)Invalid link: '<xref:fundamentals/environments#development>'. The file fundamentals/environments.md doesn't contain a bookmark named 'development'.

@wadepickett  can you get this friction removed?


When the data A in data is object type, the getter method of A repeatedly collects unnecessary dependencies, and the subs in watcher saves unnecessary Deps.

Version
2.6.10
Reproduction link
https://codepen.io/anon/pen/GbBbwJ
Steps to reproduce
jump link  https://codepen.io/anon/pen/GbBbwJ, Open the console to view _watcher in the Vue instance
What is expected?
Remove Dep's unnecessary collection of Watchers
What is actually happening?
...

The subs in watcher should have only two Deps, and now the object type is collected twice

Please be clear when reporting a bug, talk about expected behaviors in terms of public API. For example, you could say something rendered more than expected or didn't render when it should and provide the corresponding repro.

The subs in watcher should have only two Deps, and now the object type is collected twice

dep for message
dep for emptyObj, intend to detect changing when assign it (this.emptyObj = anotherObject)
dep for rerender when assigning attribute in the emptyObj and emptyObj.a is used in template (Vue.set(this.emptyObj, 'a', 1))

so it works as expected. @ganbowengo

EmptyObj is only used once in template, but Watcher will think that there are two getter calls, deps in watcher collect dep twice. If the dependency collection method of get method in defineReactive is modified to determine whether there is childOb first and then trigger the depend method of dep, the current unnecessary dep can be obtained. Remove dep from watcher without affecting emptyObj's set and attributes in template calls
Look at the code. You can try it. https://codepen.io/anon/pen/GbBbwJ
@zrh122


Cleaner UI

Makes the settings button look less cluttered especially with the new "Features" panel and upcoming "Navigation" panel.

Hmm not sure why this PR showed that I closed it. I will add this in the next release and mention this PR for sure! Thanks for the PR! :)


Configure message buffer (#82)

Add arguments for configuring message queue size and maximum message size.
The closing code is needlessly complex and made the message size code very difficult to write, so I opened up #90 to refactor the way that closing is handled.
The only other thing that stands out to me is that the connection APIs have a lot of repeated arguments now. I know I could use **kwargs to make this more DRY, but then I think (?) that the docs would show kwargs instead of the actual argument names, and that doesn't seem very user-friendly. Thoughts?

Pull Request Test Coverage Report for Build 101

32 of 32 (100.0%)  changed or added relevant lines in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.4%) to 92.892%

Files with Coverage Reduction
New Missed Lines
%

trio_websocket/_impl.py
1
92.86%

Totals

Change from base Build 97:
0.4%

Covered Lines:
379

Relevant Lines:
408

💛  - Coveralls


Uncaught ReferenceError: WindowsAzure is not defined

I did everything in this tutorial correctly. But when I run this app on a device(Android) or on a device emulator(Android) I'm getting "Uncaught ReferenceError: WindowsAzure is not defined" error. Help please as this is a base tutorial for the subsequent ones.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6dc0b51e-07e8-b217-3dab-60d43336bf1c
Version Independent ID: 6ab73749-3503-d3b1-2b84-c3e3d7c6c0d2
Content: Create a Cordova app on Azure App Service Mobile Apps
Content Source: articles/app-service-mobile/app-service-mobile-cordova-get-started.md
Service: app-service-mobile
Product: unspecified
GitHub Login: @conceptdev
Microsoft Alias: crdun

I am getting the same error

@kkaczmarzyk @TPNI Have you installed all the "TACO" tools & Visual Studio Workloads? You can simply re-run the VS201* installer and get prompted for installing the said tools:

Here are some useful links:
TACO tools: https://docs.microsoft.com/en-us/visualstudio/cross-platform/tools-for-cordova/?view=toolsforcordova-2017
We will now proceed to close this thread. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.


prometheus k8s pod state is CrashLoopBackOff, warn"component=tsdb msg="unknown series references""

level=warn ts=2019-12-23T01:49:58.164Z caller=wal.go:116 component=tsdb msg="last page of the wal is torn, filling it with zeros" segment=/prometheus/wal/00000121

The pod can't get up all the time, what is a good solution?

We need more logs than that to work off, that message is not unusual.

My image is based on version 2.10.0.  I have created three pods on three different nodes, and only one pod has this situation, and it is constantly restarting and reporting the same error.
Finally, I deleted all the wal-related log files stored locally and restarted the pod. The error disappeared. Analyze that there are problems when writing wal files that cause constant restarts.

There'll be no debugging data then, and it was probably an OOM in any case. If it happens again and isn't OOM related please let us know.


example link does not load

Over at https://github.com/golang/proposal/blob/master/design/15292-generics.md#generic-arguments-in-favor-of-generics
(even C has generics, where they are called preprocessor macros; example). link https://gcc.gnu.org/viewcvs/gcc/trunk/gcc/vec.h?revision=165314&view=markup&pathrev=165314 returns forbidden

@morenoh149, it loads for me. You might be behind a proxy blocking it.
/cc @ianlancetaylor

I have nothing to add except that it works for me too.
Can you access http://gcc.gnu.org at all?

nope. And I can on my phone. I'm probably behind a proxy then. thanks.


Implement code QL analysis

Implement Code QL analysis through github action.
PR started in #149

Code QL is working in actions
https://github.com/tiki/tiki-sdk-android/actions/runs/4872985063/jobs/8691926979


Error in upgrading-deis.rst

In the docs this is the procedure to do a manual update:

$ ssh core@
$ sudo su
$ echo GROUP=stable > /etc/coreos/update.conf
$ systemctl unmask update-engine.service
$ systemctl start update-engine.service
$ update_engine_client -update
$ systemctl stop update-engine.service
$ systemctl mask update-engine.service
$ reboot

this is wrong (at least now).
Why? https://github.com/coreos/bugs/issues/262
the boot partition is updated after the reboot so if the update-engine service is disabled it will not run and update the boot flags.
Only after this output from journalctl -u update-engine.service
[0226/232543:INFO:update_attempter.cc(674)] Updating boot flags...
is safe to disable the update-engine service. (after the next update it will use the updated version)
This means that https://github.com/deis/deis/blob/master/contrib/coreos/user-data.example#L25 must be remove so after the reboot with the update update-engine.service will start automatically
reference https://github.com/coreos/bugs/issues/262

Thanks @aledbf. So we have to somehow allow it to run once after a reboot before disabling it? That sounds difficult :(


Allow for adding a client command notify callback

This PR allows mods to add a callback to Client Commands that's used to notify a mod that the command was called, without being the callback handling the command.
Before this, mods could only AddClientCommandCallback which only allows one script to handle any command.
example usage:
void function init(){
    AddClientCommandNotifyCallback("PrivateMatchLaunch", started)
}

void function started(entity player, array<string> args){
    print(player + " started the match")
}

@abarichello i see you made a 1.5 branch, any chance to get this merged before 1.5 releases?


this.proxy is null in Firefox

Hello. I hope you are doing well today.
I have a rather strange TypeError that comes up that's hard to reproduce.
https://seventhcycle.net/mejs/jsbug/
Specifically, I'm getting this error:
TypeError: this.proxy is null  mediaelement-and-player.min.js:13:99945
TypeError: this.proxy is null  mediaelement-and-player.min.js:13:102518
I believe it is a timing issue.
Some notes on the page:

This appears to happen when I try to extend the system. You'll see at the top of the page this:

(function($) {
  $.extend(MediaElementPlayer.prototype, {
    buildtimerailthumbnails : function(player, controls, layers, media) {
		alert("Build called")
    }
  });
})(mejs.$);

I paired this down as much as possible. The alert is put there specifically to pause things. If I comment this part out, the javascript error does not show up.
I do have production code that has this error without the alert box, but there's a lot more going on (VTT parsing, etc), so this part only seems to happen if there's a delay introduced.
What I'm guessing here is that any sort of delay prevents one part of the player from being fully initiated, which causes this error.
Is there any way this can be mitigated in the player itself?
Thanks.

Thanks for reporting this. I'll look at this soon and keep you posted

Please download the master branch and confirm this issue is solved please

@rafa8626 Looks like it! Thank you so much!
https://seventhcycle.net/mejs/jsbug/
Will this be in 4.3.0, or will there be a 4.2.4 that covers this?

Glad to know it worked! It will be a 4.2.4 that is being prepared already


Feature request: Ingress resources

I'm experimenting with deploying existing Swarm stacks to Kubernetes via the Compose on Kubernetes controller. On Docker Swarm, the services are using Traefik for http/https ingress, configured with labels on Swarm services. Is there some way to adapt this to Ingress resources on Kubernetes via the Compose controller?

Hi! Thanks for your feedback. Unfortunately we're no longer maintaining this repository so I will close this issue.


"/questadmin purge" blacklisted everyone?

I wanted to clear someone's quest data so I used /questadmin purge [name], which worked, however it also appears to have blacklisted everyone. No normal players or even ops are able to use and /quest commands and are greeted by the message that they are blacklisted and should contact a server admin if it is in error. How can I un-blacklist everyone from this "blacklist" and prevent this from happening in the future?

Remove their UUIDs from config.yml

Same bug

Closed due to lack of response from OP. If this is still an issue, feel free to create a new ticket with more information.

@FlyingPikachu  i just have the same issue in latest version

@ScuroK Please see my last comment where I said to make a new ticket if this is still an issue.


Cannot open cpuacct.stat file

Hi!
I'm getting Cannot open cpuacct.stat file error on systemd.cgroup.cpu[{#SERVICE.NAME},total] item with latest zabbix and centos 7.3

Could you check solution in issue #5 please?