Different sesults on 7scenes dataset, chess

I want to reproduce the results and test the released code with the following command:
python test_e2e_DLT.py <dataset path> --dataset 7Scenes --scene chess --config_file configs/single_frame.ini --model DenseSC_GNN --pretrained-model checkpoints/7scenes_unsup_model/chess/model.pkl
The code run successfuly, and the output is:
val loader:  2000
median t,r error for DLT: 0.021533024 0.6407075225990593
ptc5 for DLT: 0.886
I noticed that the result in the paper is "Ours (dlt) 0.029/0.78". The results are differen. Can you show the right command of the paper's results?
Update:
I also test another command and it seems that the results of end-to-end model is OK:
python test_e2e_DLT.py /home/pengzhexi/camera_relocalization/dataset/7scenes --dataset 7Scenes --scene pumpkin -b 1 --config_file configs/single_frame.ini --model DenseSC_GNN --pretrained-model checkpoints/7scenes_e2e_model/pumpkin/model.pkl
The outputs are equal to paper
Update 4.18:
I try to run SC-wLS on my dataset and I have processed my data in 7Scene format. I want to use the 7Scene dataloader but the code need  coords_mean.txt file. Can you tell me the influence if I use zero instead, and how can I compute this file?
Update 4.19:
I try to use 7Scene  dataloader to run my data and I have done the following steps: first, resize my rgb images to 640*480; second, change the camera K  to my resized camera ([[373.3, 0, 308.67], [0, 497.7, 249.2], [0, 0, 1]]); third, compute the mean of gt camera pose translation as scene_mean. I only use 50 reference images as a simple test but the result is not good. Here scene coordinate initialization network best output:
t_median	q_median	lr  3.5635636	1.4805614300851522	0.0001
I also test 50 reference in 7scene chess dataset:
t_median	q_median	lr  0.05904792	0.815205435638383	0.0001
Are there other important parameters that I should change?
Sincerely, thank you.

你好，我想问一下我在执行setup.py这个文件时出现
`FAILED: /home/benben/code/SC-wLS/dsacstar/build/temp.linux-x86_64-cpython-38/dsacstar.o
c++ -MMD -MF /home/benben/code/SC-wLS/dsacstar/build/temp.linux-x86_64-cpython-38/dsacstar.o.d -pthread -B /home/benben/anaconda3/envs/SCwLS/compiler_compat -Wl,--sysroot=/ -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -fPIC -I/usr/local/opencv3.4/include -I/home/benben/anaconda3/envs/SCwLS/lib/python3.8/site-packages/torch/include -I/home/benben/anaconda3/envs/SCwLS/lib/python3.8/site-packages/torch/include/torch/csrc/api/include -I/home/benben/anaconda3/envs/SCwLS/lib/python3.8/site-packages/torch/include/TH -I/home/benben/anaconda3/envs/SCwLS/lib/python3.8/site-packages/torch/include/THC -I/home/benben/anaconda3/envs/SCwLS/include/python3.8 -c -c /home/benben/code/SC-wLS/dsacstar/dsacstar.cpp -o /home/benben/code/SC-wLS/dsacstar/build/temp.linux-x86_64-cpython-38/dsacstar.o -fopenmp -DTORCH_API_INCLUDE_EXTENSION_H '-DPYBIND11_COMPILER_TYPE="_gcc"' '-DPYBIND11_STDLIB="_libstdcpp"' '-DPYBIND11_BUILD_ABI="_cxxabi1011"' -DTORCH_EXTENSION_NAME=dsacstar -D_GLIBCXX_USE_CXX11_ABI=0 -std=c++14
cc1plus: warning: command line option ‘-Wstrict-prototypes’ is valid for C/ObjC but not for C++
In file included from /home/benben/code/SC-wLS/dsacstar/dsacstar_util.h:37:0,
from /home/benben/code/SC-wLS/dsacstar/dsacstar.cpp:42:
/home/benben/code/SC-wLS/dsacstar/dsacstar_util_rgbd.h: In function ‘void matMulDerivWrapper(cv::InputArray, cv::InputArray, cv::OutputArray, cv::OutputArray)’:
/home/benben/code/SC-wLS/dsacstar/dsacstar_util_rgbd.h:222:22: error: cannot convert ‘cv::Mat’ to ‘int’ for argument ‘1’ to ‘CvMat cvMat(int, int, int, void*)’
CvMat matA = cvMat(A), matB = cvMat(B),  c_dABdA = cvMat(_dABdA.getMat()), c_dABdB = cvMat(_dABdB.getMat());
^
/home/benben/code/SC-wLS/dsacstar/dsacstar_util_rgbd.h:223:28: error: ‘matB’ was not declared in this scope
cvCalcMatMulDeriv(&matA, &matB, _dABdA.needed() ? &c_dABdA : 0, _dABdB.needed() ? &c_dABdB : 0);
^~~~
/home/benben/code/SC-wLS/dsacstar/dsacstar_util_rgbd.h:223:28: note: suggested alternative: ‘matA’
cvCalcMatMulDeriv(&matA, &matB, _dABdA.needed() ? &c_dABdA : 0, _dABdB.needed() ? &c_dABdB : 0);
^~~~
matA
/home/benben/code/SC-wLS/dsacstar/dsacstar_util_rgbd.h:223:53: error: ‘c_dABdA’ was not declared in this scope
cvCalcMatMulDeriv(&matA, &matB, _dABdA.needed() ? &c_dABdA : 0, _dABdB.needed() ? &c_dABdB : 0);
^~~~~~~
/home/benben/code/SC-wLS/dsacstar/dsacstar_util_rgbd.h:223:53: note: suggested alternative: ‘_dABdA’
cvCalcMatMulDeriv(&matA, &matB, _dABdA.needed() ? &c_dABdA : 0, _dABdB.needed() ? &c_dABdB : 0);
^~~~~~~
_dABdA
/home/benben/code/SC-wLS/dsacstar/dsacstar_util_rgbd.h:223:85: error: ‘c_dABdB’ was not declared in this scope
cvCalcMatMulDeriv(&matA, &matB, _dABdA.needed() ? &c_dABdA : 0, dABdB.needed() ? &c_dABdB : 0);
^~~~~~~
/home/benben/code/SC-wLS/dsacstar/dsacstar_util_rgbd.h:223:85: note: suggested alternative: ‘dABdB’
cvCalcMatMulDeriv(&matA, &matB, dABdA.needed() ? &c_dABdA : 0, dABdB.needed() ? &c_dABdB : 0);
^~~~~~~
dABdB
In file included from /home/benben/code/SC-wLS/dsacstar/dsacstar.cpp:42:0:
/home/benben/code/SC-wLS/dsacstar/dsacstar_util.h: In function ‘std::vector<cv::Point > dsacstar::createSampling_seq(dsacstar::p_ts&, int)’:
/home/benben/code/SC-wLS/dsacstar/dsacstar_util.h:94:25: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
for(unsigned x = 0; x < N; x++)
^
/home/benben/code/SC-wLS/dsacstar/dsacstar_util.h: In function ‘std::vector dsacstar::getHypScores_seq(const std::vector<std::vector<float, std::allocator > >&, float, float)’:
/home/benben/code/SC-wLS/dsacstar/dsacstar_util.h:711:20: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
for(int x = 0; x < reproErrs[h].size(); x++)
^~~~~~~~~~~~~~~~~~~
/home/benben/code/SC-wLS/dsacstar/dsacstar_util.h: In function ‘std::vector<float, std::allocator > dsacstar::getReproErrs_seq(dsacstar::coord_ts&, const pose_t&, const std::vector<cv::Point >&, const cv::Mat&, float, cv::Mat&, bool)’:
/home/benben/code/SC-wLS/dsacstar/dsacstar_util.h:862:20: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
for(int x = 0; x < sampling.size(); x++)
^~~~~~~~~~~~~~~
/home/benben/code/SC-wLS/dsacstar/dsacstar_util.h: In function ‘void dsacstar::refineHyp_seq(dsacstar::coord_ts&, const std::vector<float, std::allocator >&, const std::vector<cv::Point >&, const cv::Mat&, float, unsigned int, float, dsacstar::pose_t&, std::vector<int, std::allocator >&)’:
/home/benben/code/SC-wLS/dsacstar/dsacstar_util.h:1125:21: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
for(int x = 0; x < sampling.size(); x++)
^~~~~~~~~~~~~~~
/home/benben/code/SC-wLS/dsacstar/dsacstar.cpp: In function ‘void dsacstar_rgb_forward(at::Tensor, at::Tensor, int, float, float, float, float, float, float, int)’:
/home/benben/code/SC-wLS/dsacstar/dsacstar.cpp:302:9: warning: unused variable ‘hypEntropy’ [-Wunused-variable]
double hypEntropy = dsacstar::entropy(hypProbs); // measure distribution entropy
^~~~~~~~~~
/home/benben/code/SC-wLS/dsacstar/dsacstar.cpp: In function ‘double dsacstar_rgb_backward(at::Tensor, at::Tensor, at::Tensor, int, float, float, float, float, float, float, float, float, float, int, int)’:
/home/benben/code/SC-wLS/dsacstar/dsacstar.cpp:456:9: warning: unused variable ‘hypEntropy’ [-Wunused-variable]
double hypEntropy = dsacstar::entropy(hypProbs); // measure distribution entropy
^~~~~~~~~~
ninja: build stopped: subcommand failed.
Traceback (most recent call last):
File "/home/benben/anaconda3/envs/SCwLS/lib/python3.8/site-packages/torch/utils/cpp_extension.py", line 1666, in _run_ninja_build
subprocess.run(
File "/home/benben/anaconda3/envs/SCwLS/lib/python3.8/subprocess.py", line 512, in run
raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['ninja', '-v']' returned non-zero exit status 1.
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "setup.py", line 36, in
setup(
File "/home/benben/anaconda3/envs/SCwLS/lib/python3.8/site-packages/setuptools/init.py", line 87, in setup
return distutils.core.setup(**attrs)
File "/home/benben/anaconda3/envs/SCwLS/lib/python3.8/site-packages/setuptools/_distutils/core.py", line 185, in setup
return run_commands(dist)
File "/home/benben/anaconda3/envs/SCwLS/lib/python3.8/site-packages/setuptools/_distutils/core.py", line 201, in run_commands
dist.run_commands()
File "/home/benben/anaconda3/envs/SCwLS/lib/python3.8/site-packages/setuptools/_distutils/dist.py", line 969, in run_commands
self.run_command(cmd)
File "/home/benben/anaconda3/envs/SCwLS/lib/python3.8/site-packages/setuptools/dist.py", line 1208, in run_command
super().run_command(command)
File "/home/benben/anaconda3/envs/SCwLS/lib/python3.8/site-packages/setuptools/_distutils/dist.py", line 988, in run_command
cmd_obj.run()
File "/home/benben/anaconda3/envs/SCwLS/lib/python3.8/site-packages/setuptools/command/install.py", line 74, in run
self.do_egg_install()
File "/home/benben/anaconda3/envs/SCwLS/lib/python3.8/site-packages/setuptools/command/install.py", line 123, in do_egg_install
self.run_command('bdist_egg')
File "/home/benben/anaconda3/envs/SCwLS/lib/python3.8/site-packages/setuptools/_distutils/cmd.py", line 318, in run_command
self.distribution.run_command(command)
File "/home/benben/anaconda3/envs/SCwLS/lib/python3.8/site-packages/setuptools/dist.py", line 1208, in run_command
super().run_command(command)
File "/home/benben/anaconda3/envs/SCwLS/lib/python3.8/site-packages/setuptools/_distutils/dist.py", line 988, in run_command
cmd_obj.run()
File "/home/benben/anaconda3/envs/SCwLS/lib/python3.8/site-packages/setuptools/command/bdist_egg.py", line 165, in run
cmd = self.call_command('install_lib', warn_dir=0)
File "/home/benben/anaconda3/envs/SCwLS/lib/python3.8/site-packages/setuptools/command/bdist_egg.py", line 151, in call_command
self.run_command(cmdname)
File "/home/benben/anaconda3/envs/SCwLS/lib/python3.8/site-packages/setuptools/_distutils/cmd.py", line 318, in run_command
self.distribution.run_command(command)
File "/home/benben/anaconda3/envs/SCwLS/lib/python3.8/site-packages/setuptools/dist.py", line 1208, in run_command
super().run_command(command)
File "/home/benben/anaconda3/envs/SCwLS/lib/python3.8/site-packages/setuptools/_distutils/dist.py", line 988, in run_command
cmd_obj.run()
File "/home/benben/anaconda3/envs/SCwLS/lib/python3.8/site-packages/setuptools/command/install_lib.py", line 11, in run
self.build()
File "/home/benben/anaconda3/envs/SCwLS/lib/python3.8/site-packages/setuptools/_distutils/command/install_lib.py", line 112, in build
self.run_command('build_ext')
File "/home/benben/anaconda3/envs/SCwLS/lib/python3.8/site-packages/setuptools/_distutils/cmd.py", line 318, in run_command
self.distribution.run_command(command)
File "/home/benben/anaconda3/envs/SCwLS/lib/python3.8/site-packages/setuptools/dist.py", line 1208, in run_command
super().run_command(command)
File "/home/benben/anaconda3/envs/SCwLS/lib/python3.8/site-packages/setuptools/_distutils/dist.py", line 988, in run_command
cmd_obj.run()
File "/home/benben/anaconda3/envs/SCwLS/lib/python3.8/site-packages/setuptools/command/build_ext.py", line 84, in run
_build_ext.run(self)
File "/home/benben/anaconda3/envs/SCwLS/lib/python3.8/site-packages/setuptools/_distutils/command/build_ext.py", line 346, in run
self.build_extensions()
File "/home/benben/anaconda3/envs/SCwLS/lib/python3.8/site-packages/torch/utils/cpp_extension.py", line 709, in build_extensions
build_ext.build_extensions(self)
File "/home/benben/anaconda3/envs/SCwLS/lib/python3.8/site-packages/setuptools/_distutils/command/build_ext.py", line 468, in build_extensions
self._build_extensions_serial()
File "/home/benben/anaconda3/envs/SCwLS/lib/python3.8/site-packages/setuptools/_distutils/command/build_ext.py", line 494, in _build_extensions_serial
self.build_extension(ext)
File "/home/benben/anaconda3/envs/SCwLS/lib/python3.8/site-packages/setuptools/command/build_ext.py", line 246, in build_extension
_build_ext.build_extension(self, ext)
File "/home/benben/anaconda3/envs/SCwLS/lib/python3.8/site-packages/setuptools/_distutils/command/build_ext.py", line 549, in build_extension
objects = self.compiler.compile(
File "/home/benben/anaconda3/envs/SCwLS/lib/python3.8/site-packages/torch/utils/cpp_extension.py", line 530, in unix_wrap_ninja_compile
_write_ninja_file_and_compile_objects(
File "/home/benben/anaconda3/envs/SCwLS/lib/python3.8/site-packages/torch/utils/cpp_extension.py", line 1355, in _write_ninja_file_and_compile_objects
_run_ninja_build(
File "/home/benben/anaconda3/envs/SCwLS/lib/python3.8/site-packages/torch/utils/cpp_extension.py", line 1682, in _run_ninja_build
raise RuntimeError(message) from e
RuntimeError: Error compiling objects for extension`
请问一下之前你在之前复现的过程中遇到这个问题了吗？
请问一下是我的配置问题吗？
打扰了，感谢！

应该是opencv版本的问题，按照readme所说，您应该先安装opencv=3.4.15版本并且在setup.py中设置对应的路径，再进行编译

I want to reproduce the results and test the released code with the following command: python test_e2e_DLT.py <dataset path> --dataset 7Scenes --scene chess --config_file configs/single_frame.ini --model DenseSC_GNN --pretrained-model checkpoints/7scenes_unsup_model/chess/model.pkl The code run successfuly, and the output is:
val loader: 2000 median t,r error for DLT: 0.021533024 0.6407075225990593 ptc5 for DLT: 0.886
I noticed that the result in the paper is "Ours (dlt) 0.029/0.78". The results are differen. Can you show the right command of the paper's results?
Update: I also test another command and it seems that the results of end-to-end model is OK: python test_e2e_DLT.py /home/pengzhexi/camera_relocalization/dataset/7scenes --dataset 7Scenes --scene pumpkin -b 1 --config_file configs/single_frame.ini --model DenseSC_GNN --pretrained-model checkpoints/7scenes_e2e_model/pumpkin/model.pkl The outputs are equal to paper
Update 4.18: I try to run SC-wLS on my dataset and I have processed my data in 7Scene format. I want to use the 7Scene dataloader but the code need coords_mean.txt file. Can you tell me the influence if I use zero instead, and how can I compute this file?
Update 4.19: I try to use 7Scene dataloader to run my data and I have done the following steps: first, resize my rgb images to 640*480; second, change the camera K to my resized camera ([[373.3, 0, 308.67], [0, 497.7, 249.2], [0, 0, 1]]); third, compute the mean of gt camera pose translation as scene_mean. I only use 50 reference images as a simple test but the result is not good. Here scene coordinate initialization network best output: t_median q_median lr 3.5635636 1.4805614300851522 0.0001 I also test 50 reference in 7scene chess dataset: t_median q_median lr 0.05904792 0.815205435638383 0.0001 Are there other important parameters that I should change?
Sincerely, thank you.

Hi, thanks for your attention! To be clear, I would answer the questions in order:

The commands for test
We provide two types of models for --pretrained-model here . One is *_e2e_model, which is the model for Ours (dlt+e2e) (The command you need). The other is *_unsup_model for Ours (dlt+e2e+self),  which is finetuned using test set (after self-supervised test-time adaptation).

coords_mean.txt
We follow Dsac* to use the mean value of scene coordinates for training scene coordinate regression network. It's used here, and then the network could learn the residual of scene coordinate instead.  The motivation of using the mean value is illustrated in this issue.

To calculate the mean coordinate value of your scenes, you could refer to these code.

For your own datasets, make sure the camera K is right for your resized images.
Besides, could you give more details of your datasets? Such as whether they are indoor scenes or outdoor, and the size of training set and test test. You could also debug following these steps:

Firstly, you could change the pose solver to RANSAC to see whether the problem happens on the training step of scene coordinate network initialization. If the views are too sparse, or the scene is too chanllenge, the training of scene coordinate network could fail.

Secondly, if the RANSAC results are good, you could turn to train our OANet-like weight network for each scene, and calculate dlt results finally.

Thanks for your reply. The test demo of my dataset is an outdoor scene of 50 images for reference and 1 image for query. I will debug my code as you suggest and update the results!


NameError: uninitialized constant CreateErrors

Hello everyone,
i have an error when running rake db:migrate after generating migration file.
My migration file looks like this
create_table :false do |t|
  t.references  :usable, polymorphic: true
  t.text        :class_name
  t.text        :message
  t.text        :trace
  t.text        :target_url
  t.text        :referer_url
  t.text        :params
  t.text        :user_agent
  t.timestamps
end

This is the error
NameError: uninitialized constant CreateErrors
Thanks in advance for your help

Thanks for the report, are you using the latest version?

hello i'm using exception_handler (0.5.1) with rails 4.1.8 and ruby 2.0.0

If you update to the latest version (0.7.5), you'll be able to run the migration without putting the migration file in your app. As long as db has a value in the config, you'll be able to run rails db:migrate and it will pull the file from the gem. If you use a different table name to the standard, it will infer that from the config:
# config/application.rb
config.exception_handler = {
  db: "TEST" #=> will create "TEST" db in migration
}

If you give me a repo name, I can take a look if you want

i'm now on my comuter with a windows 10 and ruby 2.2.4 with rails 5.0.1.
But i can't generate migration even with exception_bandler <IP_ADDRESS>
Could not find generator 'exception_handler:migration'. Maybe you meant 'exception_handler:views', 'active_record:migration' or 'test_unit:integration'
Run rails generate --help for more options.
Any idea?

You don't need to generate the migration - you just need to run rails db:migrate and it will include the exception handler migration in your app!
It's an experiment - works okay for us - https://github.com/richpeck/exception_handler#migrations-deprecated

Thanks richpeck it works nicely. Very good job


Goon Dialogue System

Description
Added DialogueUpdate script in Scenes/Joseph Britt. This will replace the HealthTextUpdate script for goons/enemies to allow them to talk at random intervals.
There are options for the duration the text is displayed, the minimum delay between dialogue, and the average delay between dialogue, all in seconds. There is also a list to enter text options in the inspector. Cases with 0 or 1 elements are handled and will not cause errors.
If there are multiple dialogue options available, the same one will not be repeated back-to-back.
Related Task
https://app.clickup.com/t/8678uh9dr
Testing
I logged the actual delay between dialogue to ensure it was working properly. I created 3 goons to test scenarios with 0 items, 1 item, and multiple items in the dialogue list to ensure all cases were handled properly.
Screenshots (if appropriate):

yay looks good thank you!!


Feature: Use node-fetch-retry and add retry attempts for 429 responses

Description
Curently, there is no retry logic in case of 5xx or 429 error responses.  This adds retry with exponential backoff (1 sec, 2 sec, 4 sec).  The final retry results in the same standard throwing behavior as before ala @adobe/node-fetch-retry
Also fixed:
If you try to build the project right after checking out, you will get failures because of version discrepancies, requiring you to use --force.
Motivation and Context
Adobe.IO will throttle back if there are too many requests and clients receive 429 responses.  This spaces out retries to prevent throttling as well as recover from 429s a little better.
How Has This Been Tested?
Empty out the node_modules folder and attempt to run npm i before applying this patch.  Then try after applying this patch.
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)

Checklist:

[x] I have signed the Adobe Open Source CLA.
[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

also, since this adds an option to the api, you may want/need to update the read me

The jest configuration file is in a slightly different directory than where
the Jest tooling normally expects it.  This helps IDE jest plugins a little
with working, but then again it's probably better to omit IDE
configurations in general.  Bob had already checked something in the
.vscode folder so I figured it was par for the course.  If preferred I can
remove this file from the PR also.
On Wed, Oct 13, 2021 at 1:10 PM tmathern @.***> wrote:

@.**** commented on this pull request.
In .vscode/launch.json
https://github.com/adobe/aio-lib-photoshop-api/pull/17#discussion_r728328975
:

@@ -0,0 +1,29 @@
+{

Do we really want this file checked in?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/adobe/aio-lib-photoshop-api/pull/17#pullrequestreview-778933688,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABHH5BVMBTNUSQCXFC77O7LUGXDSPANCNFSM5FSMY2TQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Since the comment identifies the delay is 1 second and the value is 1000 I
think the conversion is pretty obvious in this case.  But yes if I were
using different values (like 30 seconds, etc) then I'd definitely make it
clearer.
On Wed, Oct 13, 2021 at 1:15 PM tmathern @.***> wrote:

@.**** commented on this pull request.
In src/helpers.js
https://github.com/adobe/aio-lib-photoshop-api/pull/17#discussion_r728329770
:

@@ -13,6 +13,13 @@ governing permissions and limitations under the License.

const loggerNamespace = 'aio-lib-photoshop-api'
const logger = @.***/aio-lib-core-logging')(loggerNamespace, { level: process.env.LOG_LEVEL })
+const NodeFetchRetry = @.***/node-fetch-retry')

+// Wait 1 second for first retry, then 2, 4, etc
+const RETRY_INITIAL_DELAY = 1000
Maybe add a comment that the unit is milliseconds? Or _MS in the variable
name?
In src/helpers.js
https://github.com/adobe/aio-lib-photoshop-api/pull/17#discussion_r728329818
:

@@ -13,6 +13,13 @@ governing permissions and limitations under the License.

const loggerNamespace = 'aio-lib-photoshop-api'
const logger = @.***/aio-lib-core-logging')(loggerNamespace, { level: process.env.LOG_LEVEL })
+const NodeFetchRetry = @.***/node-fetch-retry')

+// Wait 1 second for first retry, then 2, 4, etc
+const RETRY_INITIAL_DELAY = 1000

+// Retry for up to 14 seconds
+const RETRY_MAX_DURATON = 14000
Maybe add a comment that the unit is milliseconds? Or _MS in the variable
name?
In src/helpers.js
https://github.com/adobe/aio-lib-photoshop-api/pull/17#discussion_r728330164
:

@@ -32,6 +39,57 @@ function reduceError (error = {}) {

return error
}
+/**

Determine if we should retry fetch due to Server errors (server busy or other application errors)

@param {*} response Fetch response object, should at least have a status property which is the HTTP status code received

@returns {boolean} true if we should retry or false if not

*/

+function shouldRetryFetch (response = {}) {

return (response.status >= 500) || response.status === 429

Nitpick, so it reads nicer:
⬇ Suggested change

return (response.status >= 500) || response.status === 429

return (response.status >= 500) || (response.status === 429)

In src/helpers.js
https://github.com/adobe/aio-lib-photoshop-api/pull/17#discussion_r728330977
:

...retryOptions

}

const fetchFunction = (url, opts) => NodeFetchRetry(url, { ...options, ...opts })

// This is helpful for unit testing purposes

fetchFunction.isNodeFetchRetry = true

return fetchFunction

+}

+/**

Parse through options object and determine correct parameters to Swagger for desired fetch approach

@param {*} options Photoshop API options object

@returns {*} Swagger options object with relevant settings for fetch module

*/

+function getFetchOptions (options) {

if (options !== undefined && options.useSwaggerFetch) { // << TEST

I would also verify options isn't null (or use !!options).
In src/helpers.js
https://github.com/adobe/aio-lib-photoshop-api/pull/17#discussion_r728331040
:

// This is helpful for unit testing purposes

fetchFunction.isNodeFetchRetry = true

return fetchFunction

+}

+/**

Parse through options object and determine correct parameters to Swagger for desired fetch approach

@param {*} options Photoshop API options object

@returns {*} Swagger options object with relevant settings for fetch module

*/

+function getFetchOptions (options) {

if (options !== undefined && options.useSwaggerFetch) { // << TEST

logger.debug('Using swagger fetch')

return {}

} else if (options !== undefined && options.userFetch !== undefined) { // << TEST

I would also verify options isn't null (or use !!options).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/adobe/aio-lib-photoshop-api/pull/17#pullrequestreview-778934688,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABHH5BX4GBOAWFN7HZ72Y43UGXEDJANCNFSM5FSMY2TQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

@kmikawa, @bobvanmanen -- I am unable to merge this PR, can one of you folks see if you have the ability?   Thanks!  :)

Hi @badvision
#1. I think you need to run npm run generate-docs before merge to update readme.  (@bobvanmanen, please correct me if I’m wrong.)
#2. I just run unit test, and the coverage is decreased.  Could you please check and add unit tests to meet 100% coverage?

Hey there @kmikawa !  Thanks for the quick reply.  :)
#1: Done.  PR is updated with that
#2: This is a strange one.  The coverage shows 100% of the lines are covered but 49 of 50 statements are covered in the helper.js file.  The line itself is executed over 60 times in the testing.  What this is doing is concatenating objects and it is clear by the testing that this actually works in reality.  So I'm not really sure how to get better coverage for this bit (line 68 which is: const fetchFunction = (url, opts) => NodeFetchRetry(url, { ...options, ...opts })
Is it acceptable to press forward with this PR or can you think of a way to cover this lambda statement?

Hey there @kmikawa ! Thanks for the quick reply. :)
#1: Done. PR is updated with that #2: This is a strange one. The coverage shows 100% of the lines are covered but 49 of 50 statements are covered in the helper.js file. The line itself is executed over 60 times in the testing. What this is doing is concatenating objects and it is clear by the testing that this actually works in reality. So I'm not really sure how to get better coverage for this bit (line 68 which is: const fetchFunction = (url, opts) => NodeFetchRetry(url, { ...options, ...opts })
Is it acceptable to press forward with this PR or can you think of a way to cover this lambda statement?

Thank you for the update, @badvision!
@khound, can BYS help on this?


[WIP] ci(travis): adjust for testcafe

An attempt to get tests working more reliably on travis

Coverage remained the same at 19.824% when pulling 5ecb0c47efcac2e6beeb5e89e008337c68c284bb on mrfelton:ci/travis-testcafe into 77b4cba4b496f053a295a4c9602221c6a9b713bf on LN-Zap:master.


config: validate mirrors directory when starting snapshotter

Codecov Report
Base: 27.81% // Head: 27.64% // Decreases project coverage by -0.17% :warning:

Coverage data is based on head (ea2280c) compared to base (222d2b1).
Patch coverage: 12.50% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #378      +/-   ##
==========================================
- Coverage   27.81%   27.64%   -0.17%
==========================================
  Files          40       40
  Lines        4088     4087       -1
==========================================
- Hits         1137     1130       -7
- Misses       2819     2825       +6
  Partials      132      132

Impacted Files
Coverage Δ

config/config.go
18.18% <0.00%> (-1.12%)
:arrow_down:

config/daemonconfig/mirrors.go
67.30% <100.00%> (-1.45%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Gives empty string in result

I'm always getting the empty string in result.

you should check your network

@chnouman DId you solve this issue, i m getting same problem.


Added entire new portfolio page design with left side menu and social icons

This PR Closes #2
Done

Added styles.css
Added navigation menu
Added fontawsome icons
Added social icons and the profile image.

To Do

[ ] Add responsiveness for the whole page
[ ] add your own image
[ ] Add What I do section
[ ] Add Portfolio Section
[ ] Add Blog Section
[ ] Add Contact section

You could add a section for the skills under the "What I Do section"


Error in deconv output shape estimation

Here is a modified version of the variational_autoencoder_deconv.py file. It does downsampling in the input and upsampling in the output it compiles and converges as expected but the estimated output shape is wrong it says 1, 27, 27 instead of 1, 28, 28. There may be an error in the deconv layer output shape estimation
I'll look into this now @yaringal , but if you already have the solution let me know.
Copy paste the code below to reproduce results
'''This script demonstrates how to build a variational autoencoder with Keras and deconvolution layers.

Reference: "Auto-Encoding Variational Bayes" https://arxiv.org/abs/1312.6114
'''
import numpy as np
import matplotlib.pyplot as plt

from keras.layers import Input, Dense, Lambda, Flatten, Reshape
from keras.layers import Convolution2D, Deconvolution2D, MaxPooling2D
from keras.models import Model
from keras import backend as K
from keras import objectives
from keras.datasets import mnist

# input image dimensions
img_rows, img_cols, img_chns = 28, 28, 1
# number of convolutional filters to use
nb_filters = 32
# convolution kernel size
nb_conv = 3

batch_size = 16
original_dim = (img_chns, img_rows, img_cols)
latent_dim = 2
intermediate_dim = 128
epsilon_std = 0.01
nb_epoch = 5

x = Input(batch_shape=(batch_size,) + original_dim)
c = Convolution2D(nb_filters, nb_conv, nb_conv, subsample=(2, 2), border_mode='same', activation='relu')(x)
f = Flatten()(c)
h = Dense(intermediate_dim, activation='relu')(f)

z_mean = Dense(latent_dim)(h)
z_log_var = Dense(latent_dim)(h)

def sampling(args):
    z_mean, z_log_var = args
    epsilon = K.random_normal(shape=(batch_size, latent_dim),
                              mean=0., std=epsilon_std)
    return z_mean + K.exp(z_log_var) * epsilon

# note that "output_shape" isn't necessary with the TensorFlow backend
# so you could write `Lambda(sampling)([z_mean, z_log_var])`
z = Lambda(sampling, output_shape=(latent_dim,))([z_mean, z_log_var])

# we instantiate these layers separately so as to reuse them later
decoder_h = Dense(intermediate_dim, activation='relu')
decoder_f = Dense(nb_filters*img_rows*img_cols/4, activation='relu')
decoder_c = Reshape((nb_filters, img_rows/2, img_cols/2))
decoder_mean = Deconvolution2D(img_chns, nb_conv, nb_conv,
                               (batch_size, img_chns, img_rows, img_cols),
                               subsample=(2, 2),
                               border_mode='same')

h_decoded = decoder_h(z)
f_decoded = decoder_f(h_decoded)
c_decoded = decoder_c(f_decoded)
x_decoded_mean = decoder_mean(c_decoded)

def vae_loss(x, x_decoded_mean):
    # NOTE: binary_crossentropy expects a batch_size by dim for x and x_decoded_mean, so we MUST flatten these!
    x = K.flatten(x)
    x_decoded_mean = K.flatten(x_decoded_mean)
    xent_loss = objectives.binary_crossentropy(x, x_decoded_mean)
    kl_loss = - 0.5 * K.mean(1 + z_log_var - K.square(z_mean) - K.exp(z_log_var), axis=-1)
    return xent_loss + kl_loss

vae = Model(x, x_decoded_mean)
vae.compile(optimizer='rmsprop', loss=vae_loss)
vae.summary()

# train the VAE on MNIST digits
(x_train, y_train), (x_test, y_test) = mnist.load_data()

x_train = x_train.astype('float32')[:, None, :, :] / 255.
x_test = x_test.astype('float32')[:, None, :, :] / 255.

vae.fit(x_train, x_train,
        shuffle=True,
        nb_epoch=nb_epoch,
        batch_size=batch_size,
        validation_data=(x_test, x_test))

# build a model to project inputs on the latent space
encoder = Model(x, z_mean)

# display a 2D plot of the digit classes in the latent space
x_test_encoded = encoder.predict(x_test, batch_size=batch_size)
plt.figure(figsize=(6, 6))
plt.scatter(x_test_encoded[:, 0], x_test_encoded[:, 1], c=y_test)
plt.colorbar()
plt.show()

# build a digit generator that can sample from the learned distribution
decoder_input = Input(shape=(latent_dim,))
_h_decoded = decoder_h(decoder_input)
_f_decoded = decoder_f(_h_decoded)
_c_decoded = decoder_c(_f_decoded)
_x_decoded_mean = decoder_mean(_c_decoded)
generator = Model(decoder_input, _x_decoded_mean)

# display a 2D manifold of the digits
n = 15  # figure with 15x15 digits
digit_size = 28
figure = np.zeros((digit_size * n, digit_size * n))
# we will sample n points within [-15, 15] standard deviations
grid_x = np.linspace(-15, 15, n)
grid_y = np.linspace(-15, 15, n)

for i, yi in enumerate(grid_x):
    for j, xi in enumerate(grid_y):
        z_sample = np.array([[xi, yi]])
        x_decoded = generator.predict(z_sample)
        digit = x_decoded[0].reshape(digit_size, digit_size)
        figure[i * digit_size: (i + 1) * digit_size,
               j * digit_size: (j + 1) * digit_size] = digit

plt.figure(figsize=(10, 10))
plt.imshow(figure)
plt.show()

as a quick fix, we can just return output_shape_ in the get_output_shape_for_ function. But it would be nice if we use shape inference once and for all. You mentioned you wanted to help out @lukovkin ?

I've made a PR on this to the @yaringal fork.
It seems to be working, but there's a Theano-specific issue there - output_shape becomes Theano expression, but Theano doesn't accept it as the input shape. Evaluation fails too.
I was AFK today, will try to clarify tomorrow, but you can take a look at Deconv PR - my PR is mentioned there and I've commented there on this issue.
Code is not clean yet as soon as I was working to solve this issue.
-----Original Message-----
From: "Eder Santana"<EMAIL_ADDRESS>Sent: 26.07.2016 1:16
To: "fchollet/keras"<EMAIL_ADDRESS>Cc: "Dmitry Lukovkin"<EMAIL_ADDRESS>"Mention"<EMAIL_ADDRESS>Subject: Re: [fchollet/keras] Error in deconv output shape estimation (#3311)
as a quick fix, we can just return output_shape_ in the get_output_shape_for_ function. But it would be nice if we use shape inference once and for all. You mentioned you wanted to help out @lukovkin ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

deconv was merged here. you can work directly on master now

Hi @EderSantana , what's the version of keras you use? I can't import deconvolution2d layer in updated version.


Favicon is not displayed

Favicon is not displayed
When going on the website, there is no favicon displayed. This is also an issue when saving the bookmark.

Thanks for the heads up! We'll get one in there shortly. Cheers!

Thank you for taking care of it, it will greatly enhance my experience 😄
I'm happy if my "contribution" was useful 👍

its a beauty


How to initialize the javasctipt in Vue3 using the option api?

i am using flowbite in a laravel/vue project.
After i noticed that the flowbite javascript does not work in my Vue components i added this:
<script setup>
import { onMounted } from 'vue'
import { initFlowbite } from 'flowbite'

// initialize components based on data attribute selectors
onMounted(() => {
    initFlowbite();
})
</script>

The javascript now works fine.
The problem is that i don't like using the composotion api and i use the option api instead. so i tried initializing flowbite js using several ways and none seems to work.
attempt 1:
<script>
  import { onMounted } from 'vue'
  import { initFlowbite } from 'flowbite'

  export default {
    setup() {
      onMounted(() => {

        initFlowbite();
      })
    }
  }
</script>

attempt 2:
<script>
    import { initFlowbite } from 'flowbite'

    export default {
        mounted() {
            initFlowbite();
        }
    }
</script>

sorry, the issue has nothing with this library :)


Make \yii\rest\Serializer::addPaginationHeaders() public.

I don't want to use Serializer (I am optimizing RESTful end-point by avoiding PHP loop through models) but I need to apply filters to data provider and then set pagination headers. So in RESTful controller I use a hook for prepareDataProvider and then call
$pagination = $dataProvider->getPagination();

after that I'd like to call
(new \yii\rest\Serializer())->addPaginationHeaders($pagination);

but addPaginationHeaders() is not public. Probably it should also get Response as a parameter.
Maybe it makes sense to make it static and turn properties like $totalCountHeader into const.
Additional info

Q
A

Yii version
2.0.21?

PHP version
7.1.33

Operating system
Amazon Linux AMI 2018.03

It doesn't seem that using Serializer like that would save much code for you so I'd suggest to copy this piece into your own custom implementation. This is internal detail that is not meant to be exposed.

@samdark  It's unfortunate that WET is recommended here. It wouldn't be much work to make that function public and those pagination headers are custom Yii headers so it would be reasonable to set them up through Yii function.


Fixing IDENTITY-3628

$subject

Please note I have encode only the URL I modified since XSS fixes for this component are covered in #1008 and #1009.


xfce.thunar: 4.16.8 -> 4.16.9

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for xfce.thunar is: "Xfce file manager"
meta.homepage for xfce.thunar is: "https://gitlab.xfce.org/xfce/thunar"
meta.changelog for xfce.thunar is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

/nix/store/lw1ws986slvjdzc9w9g997xsypvf0506-thunar-4.16.9/bin/thunar passed the binary check.

/nix/store/lw1ws986slvjdzc9w9g997xsypvf0506-thunar-4.16.9/bin/thunar-settings passed the binary check.

/nix/store/lw1ws986slvjdzc9w9g997xsypvf0506-thunar-4.16.9/bin/Thunar passed the binary check.

/nix/store/lw1ws986slvjdzc9w9g997xsypvf0506-thunar-4.16.9/bin/.thunar-wrapped passed the binary check.

/nix/store/lw1ws986slvjdzc9w9g997xsypvf0506-thunar-4.16.9/bin/.thunar-settings-wrapped passed the binary check.

3 of 5 passed binary check by having a zero exit code.

5 of 5 passed binary check by having the new version present in output.

found 4.16.9 with grep in /nix/store/lw1ws986slvjdzc9w9g997xsypvf0506-thunar-4.16.9

found 4.16.9 in filename of file in /nix/store/lw1ws986slvjdzc9w9g997xsypvf0506-thunar-4.16.9

directory tree listing: https://gist.github.com/877cc6c1fb2660ed57d35c2f9cdfb25d

du listing: https://gist.github.com/dd36c36ec5934a40fc0621522ae5fd2b

Rebuild report (if merged into master) (click to expand)

24 total rebuild path(s)

8 package rebuild(s)

8 x86_64-linux rebuild(s)
8 i686-linux rebuild(s)
0 x86_64-darwin rebuild(s)
8 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
xfce.thunar
xfce.thunar-archive-plugin
xfce.thunar-bare
xfce.thunar-build
xfce.thunar-dropbox-plugin
xfce.thunar-media-tags-plugin
xfce.thunarx-2-dev
xfce.xfdesktop

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/lw1ws986slvjdzc9w9g997xsypvf0506-thunar-4.16.9 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A xfce.thunar https://github.com/r-ryantm/nixpkgs/archive/7bd5754a353b12bf53df824c59281e56703f0c89.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/lw1ws986slvjdzc9w9g997xsypvf0506-thunar-4.16.9
ls -la /nix/store/lw1ws986slvjdzc9w9g997xsypvf0506-thunar-4.16.9/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

5 packages built:

xfce.thunar
xfce.thunar-archive-plugin
xfce.thunar-dropbox-plugin
xfce.thunar-media-tags-plugin
xfce.xfdesktop

Maintainer pings

Result of nixpkgs-review pr 137711 at 7bd5754a run on aarch64-linux 1

5 packages built successfully:

xfce.thunar (xfce.thunar-bare ,xfce.thunar-build ,xfce.thunarx-2-dev)
xfce.thunar-archive-plugin
xfce.thunar-dropbox-plugin
xfce.thunar-media-tags-plugin
xfce.xfdesktop

Result of nixpkgs-review pr 137711 run on x86_64-linux 1

5 packages built:

xfce.thunar (xfce.thunar-bare ,xfce.thunar-build ,xfce.thunarx-2-dev)
xfce.thunar-archive-plugin
xfce.thunar-dropbox-plugin
xfce.thunar-media-tags-plugin
xfce.xfdesktop


kdelibs has propagated dependency on cmake, automoc

Such propagated dependencies are bad because they cause unnecessary bloat of the runtime closure (e.g. cmake is ~47 MB).
@ttuegel Can you change the propagatedNativeBuildInputs to regular build inputs in pkgs/applications/kde-apps-15.04/default.nix?

It's likely that would break compilation of some reverse dependencies. I believe such problems are more about splitting the $dev output – that's what's supposed to "propagate" build-time dependencies (either through *.pc files, this way, or some other way).

It would definitely break some builds, but those could be manually propagated.

Probably cmake can be added to buildInputs by the kdePackage function, since I guess every KDE package requires cmake.

Yes, I think that would suffice.

This is fixed.


Copy local address doesn't include protocol

Testing #124976
http or https are not included in the address when run copy local address.

After looking more, I think this is the correct behavior. We deliberately don't include the protocol in the cell of the table, so if we change the copy to include the protocol, then it will not match what is shown.


ShadowEndpointSlice controller check for foreign API server status

Description
This PR modifies the ShadowEndpointSlice controller to also check the status of the foreign API server.
In the remote cluster, the controller sets the status of the local pods endpoints to Ready/NotReady depending on whether the local API server is ready or not.
Ref #1705
How Has This Been Tested?

[x] Locally on Kind
[x] Unit tests
[x] e2e tests

/test


Fix voldemort types in public interface

The Fds struct used in ListenFds in the pingora::services::Service trait is not nameable. See https://rust-lang.github.io/rfcs/2145-type-privacy.html#lint-3-voldemort-types-its-reachable-but-i-cant-name-it
This change makes both ListenFds and Fds public.
As a side-effect all of the methods on Fds are now public as well but are not documented.
Fixes: https://github.com/cloudflare/pingora/issues/145

Thank you for your contribution, this has been synced.


Running Variant Analysis Across Multiple Organizations with a Single Controller Repository

👋 Folks,
Scenario:
We have several internal organizations (e.g., org1, org2, org3), and we want to run variant analysis across all different repositories within these organizations. However, we only want to maintain a single controller repository in org1. Currently, when attempting to do this, we are facing issues.
Request:
Is there a way to run variant analysis across different organizations (where the repositories are private) while having only one controller repository in org1?

Hi @BullHacks3.

Currently, when attempting to do this, we are facing issues.

Can you please elaborate on this? What issues are you seeing? Are there any error logs that you can share?

Let's consider from an example:
There are two different orgs:
org 1 --> staging
org 2 --> production
controller repository is present in org1 --> staging/controller
I'm trying to run the variant analysis on a repo available in production org (i.e production/sample-mp).

I'm getting error repostiory not found

RequestError [HttpError]: Repository not found for variant analysis
Error: Repository not found for variant analysis
    at /home/runner/work/_actions/github/codeql-variant-analysis-action/main/dist/query.js:41352:26
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async updateVariantAnalysisStatus (/home/runner/work/_actions/github/codeql-variant-analysis-action/main/dist/query.js:79458:5)
    at async setVariantAnalysisRepoInProgress (/home/runner/work/_actions/github/codeql-variant-analysis-action/main/dist/query.js:79418:3)
    at async run (/home/runner/work/_actions/github/codeql-variant-analysis-action/main/dist/query.js:80527:7) {
  status: 404,
  response: {
    url: 'https://api.github.com/repositories/829375434/code-scanning/codeql/variant-analyses/11470/repositories/660872967/status',
    status: 404,
    headers: {
      'access-control-allow-origin': '*',
      'access-control-expose-headers': 'ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Resource, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, X-GitHub-SSO, X-GitHub-Request-Id, Deprecation, Sunset',
      'content-encoding': 'gzip',
      'content-security-policy': "default-src 'none'",
      'content-type': 'application/json; charset=utf-8',
      date: 'Thu, 22 Aug 2024 09:48:22 GMT',
      'referrer-policy': 'origin-when-cross-origin, strict-origin-when-cross-origin',
      server: 'github.com',
      'strict-transport-security': 'max-age=31536000; includeSubdomains; preload',
      'transfer-encoding': 'chunked',
      vary: 'Accept-Encoding, Accept, X-Requested-With',
      'x-content-type-options': 'nosniff',
      'x-frame-options': 'deny',
      'x-github-api-version-selected': '2022-11-28',
      'x-github-media-type': 'github.v3; format=json',
      'x-github-request-id': '0400:3C1FAC:3DB1490:3E2C7BD:66C70966',
      'x-ratelimit-limit': '15000',
      'x-ratelimit-remaining': '14999',
      'x-ratelimit-reset': '1724323702',
      'x-ratelimit-resource': 'code_scanning_variant_analysis_update',
      'x-ratelimit-used': '1',
      'x-xss-protection': '0'
    },
    data: {
      message: 'Repository not found for variant analysis',
      documentation_url: 'https://docs.github.com/rest/code-scanning/code-scanning#update-the-analysis-status-of-a-repository-in-a-codeql-variant-analysis',
      status: '404'
    }
  },
  request: {
    method: 'PATCH',
    url: 'https://api.github.com/repositories/829375434/code-scanning/codeql/variant-analyses/[114](https://github.com/linkedin-staging/bagupta-mrva-controller/actions/runs/10505755931/job/29103977747#step:8:114)70/repositories/660872967/status',
    headers: {
      accept: 'application/vnd.github.v3+json',
      'user-agent': 'GitHub multi-repository variant analysis action octokit-core.js/5.0.1 Node.js/20.13.1 (linux; x64)',
      authorization: 'RemoteAuth [REDACTED]',
      'content-type': 'application/json; charset=utf-8'
    },
    body: '{"status":"in_progress"}',
    request: {
      fetch: [AsyncFunction: customFetch],
      hook: [Function: bound bound register]
    }
  }
}
Request to PATCH /repositories/829375434/code-scanning/codeql/variant-analyses/11470/repositories/660872967/status failed with status code 404
/home/runner/work/_actions/github/codeql-variant-analysis-action/main/dist/query.js:41352
          const error2 = new import_request_error.RequestError(toErrorMessage(data), status, {
                         ^
RequestError [HttpError]: Repository not found for variant analysis
    at /home/runner/work/_actions/github/codeql-variant-analysis-action/main/dist/query.js:41352:26
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async updateVariantAnalysisStatus (/home/runner/work/_actions/github/codeql-variant-analysis-action/main/dist/query.js:79458:5)
    at async setVariantAnalysisFailed (/home/runner/work/_actions/github/codeql-variant-analysis-action/main/dist/query.js:79441:3)
    at async run (/home/runner/work/_actions/github/codeql-variant-analysis-action/main/dist/query.js:80567:7) {
  status: 404,
  response: {
    url: 'https://api.github.com/repositories/829375434/code-scanning/codeql/variant-analyses/11470/repositories/660872967/status',
    status: 404,
    headers: {
      'access-control-allow-origin': '*',
      'access-control-expose-headers': 'ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Resource, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, X-GitHub-SSO, X-GitHub-Request-Id, Deprecation, Sunset',
      'content-encoding': 'gzip',
      'content-security-policy': "default-src 'none'",
      'content-type': 'application/json; charset=utf-8',
      date: 'Thu, 22 Aug 2024 09:48:23 GMT',
      'referrer-policy': 'origin-when-cross-origin, strict-origin-when-cross-origin',
      server: 'github.com',
      'strict-transport-security': 'max-age=31536000; includeSubdomains; preload',
      'transfer-encoding': 'chunked',
      vary: 'Accept-Encoding, Accept, X-Requested-With',
      'x-content-type-options': 'nosniff',
      'x-frame-options': 'deny',
      'x-github-api-version-selected': '2022-11-28',
      'x-github-media-type': 'github.v3; format=json',
      'x-github-request-id': '0400:3C1FAC:3DB153B:3E2C85D:66C70966',
      'x-ratelimit-limit': '15000',
      'x-ratelimit-remaining': '14998',
      'x-ratelimit-reset': '1724323702',
      'x-ratelimit-resource': 'code_scanning_variant_analysis_update',
      'x-ratelimit-used': '2',
      'x-xss-protection': '0'
    },
    data: {
      message: 'Repository not found for variant analysis',
      documentation_url: 'https://docs.github.com/rest/code-scanning/code-scanning#update-the-analysis-status-of-a-repository-in-a-codeql-variant-analysis',
      status: '404'
    }
  },
  request: {
    method: 'PATCH',
    url: 'https://api.github.com/repositories/829375434/code-scanning/codeql/variant-analyses/11470/repositories/660872967/status',
    headers: {
      accept: 'application/vnd.github.v3+json',
      'user-agent': 'GitHub multi-repository variant analysis action octokit-core.js/5.0.1 Node.js/20.13.1 (linux; x64)',
      authorization: 'RemoteAuth [REDACTED]',
      'content-type': 'application/json; charset=utf-8'
    },
    body: '{"status":"failed","failure_message":"Repository not found for variant analysis"}',
    request: {
      fetch: [AsyncFunction: customFetch],
      hook: [Function: bound bound register]
    }
  }
}

ERROR: Repository not found for variant analysis
Issue:

We are unable to perform variant analysis across cross organizations (private) repositories, using single controller repository.

Thanks @BullHacks3 for the additional information.
I've tried this locally and I can confirm I'm able to run a variant analysis that covers repos against different orgs. Both my repos were private.
Can you confirm whether you're able to run variant analysis against those repos individually? I wonder if there is something special around your access to those repos.
Also can you tell us about how you're logged in to the VS Code extension?


Unable to use web workers using a JS entry point

Describe the bug
Using the backend integration for a web server (http://localhost:80), trying to use an external Web Worker (monaco-editor) returns 404 errors.
import { defineConfig } from "vite"
import vue from "@vitejs/plugin-vue"

export default defineConfig({
    plugins: [
        vue(),
    ],
    build: {
        polyfillModulePreload: false,
        manifest: true,
        rollupOptions: {
            input: 'resources/js/app.js',
        },
    },
});

<template>

</template>

Loading the developer server, with the web server already running on port 80:
npm run dev

VITE v3.0.4  ready in 1392 ms

➜  Local:   http://localhost:5173/
➜  Network: use --host to expose

Once done, the browser opens at http://localhost. The network tab shows it 404 for loading the web worker:
HTTP 1.0 GET http://localhost/node_modules/monaco-editor/esm/vs/editor/editor.worker.js?type=module&worker_file

404

If I try adding the worker manually by replacing return new EditorWorker() with:
return new Worker(
    "http://localhost:5173/node_modules/monaco-editor/esm/vs/editor/editor.worker.js?type=module&worker_file"
)

Chrome will report that the script in http://localhost:5173 cannot be accessed by http://localhost.
Reproduction
https://github.com/DarkGhostHunter/bug-vite-no-web-worker
System Info
System:
    OS: Windows 10 10.0.19044
    CPU: (4) x64 Intel(R) Core(TM) i5 CPU 750  @ 2.67GHz
    Memory: 851.92 MB / 7.97 GB
  Binaries:
    Node: 17.2.0 - C:\Program Files\nodejs\node.EXE
    npm: 8.15.1 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Edge: Spartan (44.19041.1266.0), Chromium (103.0.1264.77), ChromiumDev (105.0.1336.2)
  npmPackages:
    @vitejs/plugin-vue: ^3.0.0 => 3.0.1
    vite: ^3.0.0 => 3.0.4

Used Package Manager
npm
Logs
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

related #13680

Same workaround with #13680 would work: https://github.com/vitejs/vite/issues/13680#issuecomment-1819274694


fix(deps): update terraform-module

This PR contains the following updates:

Package
Type
Update
Change

terraform-ibm-modules/cbr/ibm (source)
module
minor
1.2.0 -> 1.9.0

terraform-ibm-modules/observability-instances/ibm (source)
module
minor
2.7.0 -> 2.9.0

terraform-ibm-modules/resource-group/ibm (source)
module
patch
1.0.5 -> 1.0.6

Release Notes

terraform-ibm-modules/terraform-ibm-cbr (terraform-ibm-modules/cbr/ibm)
v1.9.0
Compare Source
Features

add regionality support in fscloud submodule (#271) (66374b9)

v1.8.2
Compare Source
Bug Fixes

update required ibm provider version to >= 1.56.1 (#277) (e2dd42f)

v1.8.1
Compare Source
Bug Fixes

added instance id support to the target_service_details variable in the fscloud profile (#275) (8b84293)

v1.8.0
Compare Source
Features

update required ibm provider version to >= 1.56.1 (#276) (71bd929)

v1.7.1
Compare Source
Bug Fixes

fix link in README.md (#274) (80245e1)

v1.7.0
Compare Source
Refactor

All the terraform submodules are now moved to the directory modules including FScloud profile. (#273) (89ea824)

Features

Added an option in the fscloud module to skip zone creation for specific service (#273) (89ea824)

v1.6.1
Compare Source
Bug Fixes

Minor fix to update some missing module documentation (#272) (2be6082)

v1.6.0
Compare Source
Features

adds regionality for services in zone (#240) (ee9efc1)

v1.5.0
Compare Source
Features

New sub-module under the directory profiles/fscloud . The module lays out a secure-by-default CBR topology at the account level.

v1.4.0
Compare Source
Features

give flexibility on endpoint configuration in cbr service module (#265) (4ec347e)

v1.3.2
Compare Source
Bug Fixes

update prefix variable description in cbr-service-profile submodule (#261) (139d98d)

v1.3.1
Compare Source
Bug Fixes

Adjust multi-service-profile example to demonstrate a real-world scenario (#258) (0f6de93)

v1.3.0
Compare Source
Features

update list of supported services (#264) (14ceabc)

v1.2.1
Compare Source
Bug Fixes

update modules references to point to hashicorp module registry (#231) (e6b3d34)

terraform-ibm-modules/terraform-ibm-observability-instances (terraform-ibm-modules/observability-instances/ibm)
v2.9.0
Compare Source
Features

update required ibm provider version to >= 1.56.1 (#335) (2a53543)

v2.8.0
Compare Source
Updates (#259) (928d4bd)

The submodule directories formerly referred to as logdna and sysdig have been renamed as log_analysis and cloud_monitoring respectively. In addition all variables with the name logdna & sysdig have been renamed to log_analysis and cloud_monitoring respectively. The following are the list of variable names renamed:

logdna_instance_name ->  log_analysis_instance_name
logdna_plan -> log_analysis_plan
logdna_tags -> log_analysis_tags
logdna_manager_key_name -> log_analysis_manager_key_name
logdna_manager_key_tags -> log_analysis_manager_key_tags
logdna_access_tags -> log_analysis_access_tags
logdna_cos_instance_id -> log_analysis_cos_instance_id
logdna_cos_bucket_name -> log_analysis_cos_bucket_name
logdna_cos_bucket_endpoint -> log_analysis_cos_bucket_endpoint
logdna_targets -> log_analysis_targets
logdna_provision ->  log_analysis_provision
logdna_resource_key_role -> log_analysis_resource_key_role
logdna_service_endpoints -> log_analysis_service_endpoints
sysdig_crn -> cloud_monitoring_crn
sysdig_plan -> cloud_monitoring_plan
sysdig_instance_name -> cloud_monitoring_instance_name
sysdig_tags -> cloud_monitoring_tags
sysdig_manager_key_name -> cloud_monitoring_manager_key_name
sysdig_manager_key_tags -> cloud_monitoring_manager_key_tags
sysdig_access_tags -> cloud_monitoring_access_tags
sysdig_provision -> cloud_monitoring_provision
sysdig_service_endpoints -> cloud_monitoring_service_endpoints

v2.7.1
Compare Source
Bug Fixes

update modules references to point to hashicorp module registry (b23feca)

terraform-ibm-modules/terraform-ibm-resource-group (terraform-ibm-modules/resource-group/ibm)
v1.0.6
Compare Source
Bug Fixes

update usage to show hashicorp syntax instead of github (#435) (9469adf)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline

Edited/Blocked Notification
Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.
You can manually request rebase by checking the rebase/retry box above.
⚠ Warning: custom changes will be lost.

The CBR module moved the sub modules into a modules folder. The paths had to be updated.
The Observability module renamed the logdna (log_analysis) and sysdig (cloud_monitoring) inputs and outputs. These had to be renamed where passed or used.

/run pipeline

:tada: This PR is included in version 6.11.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Fix issue #39: Ensure new files are consistently added under folders …

Fix: Issue #39 - File-tree View Add New File Bug

This fix ensures that new folders and files can be added even when the folder's state is open. I verified that the folder state is correctly updated to handle this behavior consistently.
Refer to the video for more context.

Video :
https://github.com/user-attachments/assets/3e9dc42a-f783-4d45-8687-25f58de6a122
Please review and let me know if any additional changes are needed.

@SahilLamba0008 this looks good, but can you add details about the bug, why it happens and how your solution handles all cases?

@SahilLamba0008 this looks good, but can you add details about the bug, why it happens and how your solution handles all cases?

As per my understanding of the code :

Clicking the "Add New File" button while the folder is open prevents adding new files. To address this, we temporarily close the folder by setting opened to false using setOpened((open) => !open), and we can also directly set it using setOpened(false).

This allows users to add files even when the folder is open. Once the file is created successfully, the opened state will be set to false again, as this time it refers to the newly created folder or file.

If a user cancels the action after clicking "Add New File," the opened state will revert to false. These automatic updates are managed by useEffects and their dependencies, ensuring everything works smoothly.

This temporary change to the opened state is brief, enabling the getAddNewComponent() function to work properly without impacting other functionalities of the app.  Opting for a different solution can result in unexpected behavior throughout the entire file-tree.

Sorry for the delay @SahilLamba0008! I have added a small comment, please take a look.

Hi @iostreamer-X , sorry for the delay, got busy with some office work. Talking about the issue, upon further debugging it caught my eye that actually, the functionality of adding folders is working completey fine already. It is not dependent on any state as  it is calling add-new-component.tsx regardless opened state being true or false, as after making a few changes in styles we can see it clearly. (Refer the attached video...) . Maybe the issue is with stylings and states !
https://github.com/user-attachments/assets/2df73592-5772-45ed-830f-4ba29b0a09de
Will update soon with a PR, meanwhile if have any insights that can help feel free to share.

Hi @iostreamer-X , sorry for the delay, got busy with some office work. Talking about the issue, upon further debugging it caught my eye that actually, the functionality of adding folders is working completey fine already. It is not dependent on any state as it is calling add-new-component.tsx regardless opened state being true or false, as after making a few changes in styles we can see it clearly. (Refer the attached video...) . Maybe the issue is with stylings and states !
Screen.Recording.2024-10-23.at.12.06.58.PM.1.mp4
Will update soon with a PR, meanwhile if have any insights that can help feel free to share.

Ohh, good eye. To be honest,  I am not really sure of its root cause. Let me check this as well. Thank you sharing this!


Fix #95: replace \ with / on Windows when saving file paths.

... and do vice versa on restore.
This is an alternative fix for #95 to  #100 (so if we apply #100 this fix is going to be unnecessary).
I haven't tested it on Windows yet, so I'm going to ask someone on Discord.

I was afraid of going this route because I feared it would break session restores between versions, but it looks like it might be fine. I can give it a try later this week if you want.

I took the liberty of pushing a couple fixes (one of which was a Trie build mistake on windows where it would forget the drive root). I'll try the Windows -> Unix path now.

So it does seem to work out but you need to resave the projects for the transfer to work. OTOH, these projects did not properly transfer before so it's not like anything's lost.
In the end, it's probably a more elegant solution. I'll pull in the packages commit in this branch for testing.

Sorry, late reply here. I definitely do not want to have it breaking old data for newer versions. But having state from newer versions unable to load on older version would be alright IMO.


Reference to app theme in docs

Hi there!
The Button doc page states:

"A button  clearly communicates what action will occur when the user touches it. It consists of text, an image, or both, designed in accordance with your app’s color theme".

It's also evident in the example that the accent buttons get the accent color in what seems to be a "standard" indigo-pink Material Design theme.
Is there any way to define themes? If there's not, how do we set the primary and accented colors? Via style sheets? Or is there a different mechanism to it?

Hi!
Of course, I've written in the installation page how themes are going to be defined. As you can see, if you want to take the most of React Toolbox you should be using CSS Modules with webpack workflow. Being that the case, you will be able to include SASS Loader and a little loader we are writing to inject a custom SASS variables file with your custom settings prepending the builds of the modules included in your project.
That means that defining a new theme will be as easy as setting the color variables of the project a SASS configuration. By default we have (taken from MDL):
$color-primary: $palette-indigo-500 !default;
$color-primary-dark: $palette-indigo-700 !default;
$color-accent: $palette-pink-a200 !default;
$color-accent-dark: $palette-pink-700 !default;
$color-primary-contrast: $color-dark-contrast !default;
$color-accent-contrast: $color-dark-contrast !default;

You'll just need to write a file defining your custom colors. We just went live today and the loader is not ready yet, but it will be soon with a configuration section explaining the setup. 😁

Cool, thank you!


Update French translation for v1.14.0

See #306

@CastagnaIT I am not able to run the add-on on Matrix for now so I was not able to check how the strings to translate are actually used.
For instance for strings 30039 you added the ID substring: does it mean that the parameter which uses 300039 has a different value than in v1.13.0? If the value is the same as in v1.13.0 I think I will reuse the same translation as in v1.13.0 because it was shorter.

As I have removed the double menu, it is no longer specified that it is the view's ID value
then i have add the ID word

@CastagnaIT

As I have removed the double menu, it is no longer specified that it is the view's ID value
then i have add the ID word
a short version should be better, but i do not know what it is better for your language

Thanks for the clarification. I think mentionning the "ID" is probably better in French too as it will limit the confusion.
I think I will be able to check on Matrix if it is too long for the next release. If it is I will update these strings.

it is good thanks


Fix examples involving script for the JS browser in chapter 9+

There were several bugs:

The lab*.hints files for certain chapters unnecessarily hinted that open should map to filesystem.open. While that is correct, it caused code in compiler.py to detect calls to open and insert files on disk into the top of the JS file.
lab13.hints had incorrect hints for dispatching JS. Since the code was unchanged from lab9, I just deleted it.
lab*-browser.html for chapters 12+ reset needs_animation_frame after calling render rather than before. This is incorrect if rAF callbacks set it during render's callouts to JS.
localhost was not whitelisted for allowing direct fetching from rt.js (only affects debugging flows).

For good measure, I modified rt.js to special-case URLs with "example" in them so that they didn't cause localhost URLs to end up going to server*.js. (Alternatively one could run the localhost server at a port other than 8000.)
Now examples/lab13-opacity-raf.html works correctly in the JS cross-compiled browser.

?


Mutation execution parameters

Hi,
as explained in https://github.com/ckimes89/graphql-net/pull/57, we use graphql-net in a web API application.
The schema is built once and for every request ExecuteQuery is called with a context which is injected into the controller. This works pretty well for queries.
We have a service layer containing the business logic for create/update/delete actions. Mutations simply consist of method calls of a service which is injected into the controller as well.
Currently, in mutation actions the arugments object and the context are accessible.
It seems not a good idea to make those services accessible through any of these objects.
Therefore, this PR introduces a thid object which is (optionally) passed to mutation actions.
No breaking API changes are introduced, there is another AddMutation overload variation:
schema.AddMutation("mutate",
   new { id = 0, newVal = 0 },
   (db, args, execParams) =>
   {
      var mutateMe = db.MutateMes.AsQueryable().FirstOrDefault(a => a.Id == args.id);
      execParams.MutateMeService.Update(execParams.authenticatedUserId, mutateMe, args.newVal);
      db.SaveChanges();
   },
   (db, args) => db.MutateMes.AsQueryable().FirstOrDefault(a => a.Id == args.id));

Please let me know what you think about the changes :)

Hi Marian, thanks for the pull request!
I've thought about this for a while and I've come to the conclusion that I don't think this is a necessary general addition to the library. The main reason I think that is because I believe that your use case can already be handled by existing functionality. I'm gonna offer two suggestions that I think will work for you, and if they don't then we can use that to work towards a solution (which may very well be this pull request).
The key insight is that, while the TContext type will usually be the actual database context from whatever ORM the user is using, there's no reason that it has to be just that. TContext can in fact be a wrapper class that contains your database context in addition to anything else you want to include. Using that idea we can get to my first suggestion, which is to include your DI container with the context:
public class ContextWrapper
{
    public DatabaseContext Context { get; set; }
    public DIContainer Container { get; set; }
}

// schema setup
var schema = GraphQL<ContextWrapper>.CreateDefaultSchema(() => new ContextWrapper
{
    Context = new DatabaseContext(),
    Container = DIContainer.StaticInstance,
});

// mutation setup
schema.AddMutation("mutate",
   new { id = 0, newVal = 0 },
   (db, args) =>
   {
      var mutateMe = db.Context.MutateMes.AsQueryable().FirstOrDefault(a => a.Id == args.id);
      var mutateService = db.Container.Resolve<IMutateMeService>();
      var securityService = db.Container.Resolve<ISecurityService>();
      mutateService.Update(securityService.AuthenticatedUserId, mutateMe, args.newVal);
      db.Context.SaveChanges();
   },
   (db, args) => db.MutateMes.AsQueryable().FirstOrDefault(a => a.Id == args.id));

This lets you have access to any service by requesting it from the DI container during your mutation.
The other option that I would suggest would be to wrap your execution parameters rather than the DI container. This is useful if you don't want all your code exposed to the DI container, and it's more functionally similar to the code in your pull request:
public class ContextWrapper
{
    public DatabaseContext Context { get; set; }
    public int AuthenticatedUserId { get; set; }
    public IMutateMeService MutateMeService { get; set; }
}

// mutation setup
var schema = new GraphQLSchema<ContextWrapper>();
schema.AddMutation("mutate",
   new { id = 0, newVal = 0 },
   (db, args) =>
   {
      var mutateMe = db.Context.MutateMes.AsQueryable().FirstOrDefault(a => a.Id == args.id);
      db.MutateMeService.Update(db.AuthenticatedUserId, mutateMe, args.newVal);
      db.Context.SaveChanges();
   },
   (db, args) => db.MutateMes.AsQueryable().FirstOrDefault(a => a.Id == args.id));

// mutation usage
var context = new ContextWrapper
{
    Context = _injectedContext,
    MutateMeService = _mutateMeService,
    AuthenticatedUserId = _userId,
}
var gql = new GraphQL<ContextWrapper>(schema);
gql.Execute(query, context);

Do you think one of these options will work for you? If not, I'd be interested to hear why and see what we can do to make it work.

Hi Chad,
thanks for the response, your suggested solutions are exactly what i was looking for.
I didn't thought about wrapping the db context.
This PR is obsolet, i will close it.


Update manual-installation.md

Gave manual-installation a minor facelift and added a link at the start of the page to send Linux users to the right spot.
For the time being, I've left the Origin content alone, though we should consider dropping it and changing some errors to reflect EA App since Origin probably won't be around much longer, since EA has already replaced the original installer in every game, and scrubbed anything Origin related off its website.
Closes #102

That's a fair point, considering the average Northstar user isn't exactly proficient in reading, I'll edit that line out later (or you can since it won't be for a few hours) and probably just merge the two install pages together in a different pr.


when using The props  or button loading  will  get a error , and other is work.

Element type is invalid: expected a string (for built-in components) or a class/function (for composite components) but got: undifined. Check the  render method of 'Button'.
<Button
isLoading={true}
style={styles.buttonStyle7} textStyle={styles.textStyle6}
onPress={() => {
console.log('world!')
}}>
Hello

it   can"t  work.
<Button
style={styles.buttonStyle6} textStyle={styles.textStyle}
onPress={() => {
console.log('world!')
}}>
Hello

it  can work

Hello @feaverfei!
I need more info to debug, RN version, platform, button version, etc.
Checking the example, the isLoading prop works perfectly.

thanks
{
"name": "Project",
"version": "0.0.1",
"private": true,
"scripts": {
"start": "react-native start"
},
"dependencies": {
"react": "^15.1.0",
"react-native": "^0.27.2"
}
}

i think i should update  this version

Hey is this issue solved because I am also facing the same issue
"react": "^15.1.0",
"react-native": "^0.27.2"
is what am I also using!
<Button
style={{backgroundColor: color, marginTop: 40.5, borderWidth: 0, borderRadius: 0}} textStyle={{fontSize: 15, color: 'white', fontFamily: 'Montserrat-Regular', letterSpacing: 0.3}}
isLoading = { true }
onPress={this.continuePressed.bind(this)}
>
CONTINUE

gives error:
React.createElement: type should not be null, undefined, boolean, or number. It should be a string (for DOM elements) or a ReactClass (for composite components).%s"


loading class wont work when button  has tooltip class

If there is a button with tooltip and also loading classes, the loading circle is not visible.
I checked only buttons, maybe problem exist also for other elements.

Hi,
I have fixed it in https://github.com/picturepan2/spectre/pull/578

@renegat59  perfect


Fix errors with custom theme and custom font in project settings.

Load custom theme after required classes are registered to make the custom theme works again.
Fix crash with dynamic custom font.
Define text selection color for editor theme so this color don't relys on the default color any more.

@volzhs As the editor theme doesn't defined this color so the color of the
default theme is passed for that. After I changed the default theme of my
project this color is wrong.
volzhs<EMAIL_ADDRESS>周一22:49写道：

@volzhs commented on this pull request.
In editor/editor_themes.cpp
https://github.com/godotengine/godot/pull/15186#discussion_r159157252:

@@ -332,6 +332,7 @@ Ref create_editor_theme(const Ref p_theme) {
const Color font_color = mono_color.linear_interpolate(base_color, 0.25);
const Color font_color_hl = mono_color.linear_interpolate(base_color, 0.15);
const Color font_color_disabled = Color(mono_color.r, mono_color.g, mono_color.b, 0.3);

const Color font_color_selection = Color::html("#7d7d7d");

how this hardcoded is related PR stands for?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/pull/15186#pullrequestreview-86063707,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGpFTAygqJxTwtvAGs_9G8xd1bXc1tEgks5tGPCAgaJpZM4RPi6y
.


Incorrect node variable values for homepage in custom sitemap.xml template

$ hugo version
Hugo Static Site Generator v0.16 BuildDate: 2016-06-06T05:37:59-07:00

I've been trying to get an accurate <lastmod> value for my homepage in my sitemap.xml.  I'm working on a non-blog site that so far has just a homepage and one other content page.  Hugo seems to default the .Lastmod and .Date values for the homepage to that of the other content page.  This doesn't make sense in my use case.
Since there doesn't appear to be a way to provide front matter for the homepage, I figured I'd have to resort to a custom sitemap.xml template to hardcode <lastmod> for the homepage.  In doing so I've found that some of the node variables for the homepage are not what I as expecting.  I added the following debug code to 'layouts/sitemap.xml':
<urlset xmlns="http://www.sitemaps.org/schemas/sitemap/0.9">
	{{ range .Data.Pages }}
	URL: {{ .URL }}
	Title: {{ .Title }}
	Type: {{ .Type }}
	IsPage: {{ .IsPage }}
	IsNode: {{ .IsNode }}
	IsHome: {{ .IsHome }}
[...]

This was the result for the homepage:
.URL: /
.Title:
.Type: page
.IsPage: true
.IsNode: false
.IsHome: false

Instead I expected the .Type value to be "node", with corresponding .IsNode and .IsPage values.  I also expected the .IsHome value to be true.
For now I'm calling out the homepage in my template with {{ if eq .URL "/" }} instead of {{ if .IsHome }}.

There is only one sitemap and it is of type page, not home and not node. For any other questions, take it at the forum.

@bep Hi, sorry, my report perhaps could have been more clear.  I'm referring to the values for the current iteration of a {{ range .Data.Pages }} action, not those for the top-level sitemap.xml template context.  In the iteration context I'm expecting the result of {{ .IsHome }}, etc. to be that of the homepage and the other content pages, not that of the sitemap page.  Is that not correct?
For reference here is the full content of my current sitemap.xml template, where I would expect to be able to use {{ if .IsHome }} in place of {{ if eq .URL "/" }}:
<urlset xmlns="http://www.sitemaps.org/schemas/sitemap/0.9">
	{{- range .Data.Pages }}
	{{- if eq .URL "/" }}
	<url>
		<loc>{{ .Permalink }}</loc>
		<lastmod>2016-07-03T19:43:46-07:00</lastmod>
	</url>
	{{- else if not .Params.private }}
	<url>
		<loc>{{ .Permalink }}</loc>
		<lastmod>{{ safeHTML ( .Lastmod.Format "2006-01-02T15:04:05-07:00" ) }}</lastmod>
		{{- with .Sitemap.ChangeFreq }}
		<changefreq>{{ . }}</changefreq>
		{{- end }}
		{{- if ge .Sitemap.Priority 0.0 }}
		<priority>{{ .Sitemap.Priority }}</priority>
		{{- end }}
	</url>
	{{- end }}
	{{- end }}
</urlset>


DateTimeFieldSpec validation in schema validate

Added validations to SchemaUtils#validate for checking format of DateTimeFieldSpec
https://github.com/apache/incubator-pinot/issues/5640

Recommend using exception to pass the failure message instead of passing in a logger for both simplicity and better control on the logging level

The Schema validation code already was using a logger, and I was just trying to work around that. I'm not sure why it was done this way in Schema in the first place. I can change it to exception based throughout the Schema validation code path

Recommend using exception to pass the failure message instead of passing in a logger for both simplicity and better control on the logging level

The Schema validation code already was using a logger, and I was just trying to work around that. I'm not sure why it was done this way in Schema in the first place. I can change it to exception based throughout the Schema validation code path

Yes, ideally we should also change Schema validation to exception based to prevent the unnecessary error log

Recommend using exception to pass the failure message instead of passing in a logger for both simplicity and better control on the logging level

The Schema validation code already was using a logger, and I was just trying to work around that. I'm not sure why it was done this way in Schema in the first place. I can change it to exception based throughout the Schema validation code path

Yes, ideally we should also change Schema validation to exception based to prevent the unnecessary error log

Changed the PR to use exceptions instead of logger in all of schema validations. @Jackie-Jiang


fix: fix data preview error

Proposed changes
https://github.com/apache/doris/pull/34521

fix data preview error
fix playground layout & scroll error
codemirror theme changed

run buildall


Persona Claudia: Add forced-color mode

Feedback: "For Claudia, I would suggest to add an extension creating a forced-color mode. Many users relying on magnification also use high contrast mode. I believe this should be added to the persona, as this kind of assistive technology is rarely tested."

This is deprioritized and won't be in scope for now. Specialized extensions (e.g., Midnight Lizard) will handle this better.


Christopher Hein left AWS, is there someone else to continue the work ?

This project is really important to better integrate AWS to Kubernetes but so far the scope is too limited and so this project is still a POC.
What are the plans for the next weeks ?

See https://github.com/aws/containers-roadmap/issues/456

Thanks I did not see the following up!


Remove "Download" buttons on "Samsung Gear VR" and "Oculus Browser" pages

These browsers come preinstalled with SVR app, which is sideloaded when you insert your Android phone and download the package/update.

@fernandojsg you are a recent GearVR user. Can you please confirm that Samsung Internet was installed by default or did you install it yourself?


RPC - Implement block related handlers

Describe the feature
List of endpoints related to blocks:
- [ ] eth_getBlockByHash
- [ ] eth_getBlockByNumber
- [ ] eth_getBlockTransactionCountByHash
- [ ] eth_getBlockTransactionCountByNumber

Additional context
Related tracking issue: https://github.com/paradigmxyz/reth/issues/1225
I can start working on these endpoints

awesome, tysm for taking this on!

@fkrause98 do you guys have a draft by any chance? eth_getBlockByNumber seems to be everywhere in Hive and would love if we could have a quick PR that impls it

Bump @fkrause98 if you can push the current progress, we'd like to get unblocked on this ASAP and ideally have @mattsse take over as it's a blocker

Sorry, just saw this. I see that block_by_hash and block_by_number were implemented on the linked PR, I can continue with the TODO here and the other 3 endpoints if that's ok.

this has been completed

@fkrause98 yep go for that TODO :+1:


Host not getting blacklisted

In this example, the preferred host is rh7v-intel64-90-test-19 and the blacklist contains rh7v-intel64-90-test-19.marklogic.com . Hence the host is not blacklisted as can be seen in the log
	@Test
	public void testBlackList() throws Exception{
		Assume.assumeTrue(hostNames.length > 1);

		final String query1 = "fn:count(fn:doc())";

		FilteredForestConfiguration forestConfig = null;
		DocumentMetadataHandle meta6 = new DocumentMetadataHandle().withCollections("NoHost").withQuality(0);

		Assert.assertTrue(dbClient.newServerEval().xquery(query1).eval().next().getNumber().intValue() == 0);

		WriteBatcher ihb2 =  dmManager.newWriteBatcher();
	forestConfig  = new   FilteredForestConfiguration(dmManager.readForestConfig()).withBlackList(hostNames[0]);
			ihb2.withBatchSize(50).withForestConfig(forestConfig);

	ihb2.onBatchSuccess(
		        batch -> {
		        	}
		        )
		        .onBatchFailure(
		          (batch, throwable) -> {
		        	  throwable.printStackTrace();

		          }
		);
		for (int j =0 ;j < 1000; j++){
			String uri ="/local/string-"+ j;
			ihb2.addAs(uri, meta6 , jsonNode);
		}

		ihb2.flushAndWait();
		Assert.assertTrue(dbClient.newServerEval().xquery(query1).eval().next().getNumber().intValue() == 1000);

	}

Log:

19:12:18.836 [main] DEBUG c.m.client.impl.JerseyServices - Connecting to rh7v-intel64-90-test-19 at 8000 as admin
19:12:19.492 [main] DEBUG c.m.client.impl.JerseyServices - Getting internal/forestinfo as application/json
19:12:19.789 [main] DEBUG c.m.client.impl.JerseyServices - Posting eval
19:12:19.914 [main] DEBUG c.m.client.impl.JerseyServices - Getting internal/forestinfo as application/json
19:12:19.946 [main] INFO  c.m.c.d.impl.WriteBatcherImpl - (withForestConfig) Using [rh7v-intel64-90-test-21.marklogic.com, rh7v-intel64-90-test-19, rh7v-intel64-90-test-20.marklogic.com] hosts with forests for "WriteHostBatcher"
19:12:19.946 [main] DEBUG c.m.client.impl.JerseyServices - Connecting to rh7v-intel64-90-test-21.marklogic.com at 8000 as admin
19:12:20.133 [main] INFO  c.m.c.d.impl.WriteBatcherImpl - Adding DatabaseClient on port 8000 for host "rh7v-intel64-90-test-21.marklogic.com" to the rotation
19:12:20.133 [main] INFO  c.m.c.d.impl.WriteBatcherImpl - Adding DatabaseClient on port 8000 for host "rh7v-intel64-90-test-19" to the rotation
19:12:20.133 [main] DEBUG c.m.client.impl.JerseyServices - Connecting to rh7v-intel64-90-test-20.marklogic.com at 8000 as admin
19:12:20.351 [main] INFO  c.m.c.d.impl.WriteBatcherImpl - Adding DatabaseClient on port 8000 for host "rh7v-intel64-90-test-20.marklogic.com" to the rotation
19:12:20.367 [main] DEBUG c.m.client.impl.JerseyServices - Getting internal/forestinfo as application/json
19:12:20.429 [main] INFO  c.m.c.d.impl.WriteBatcherImpl - (withForestConfig) Using [rh7v-intel64-90-test-21.marklogic.com, rh7v-intel64-90-test-19, rh7v-intel64-90-test-20.marklogic.com] hosts with forests for "WriteHostBatcher"
19:12:20.445 [main] INFO  c.m.c.d.impl.WriteBatcherImpl - threadCount=1
19:12:20.445 [main] INFO  c.m.c.d.impl.WriteBatcherImpl - batchSize=50
19:12:20.492 [main] DEBUG c.m.client.impl.JerseyServices - Posting documents
19:12:20.492 [main] DEBUG c.m.client.impl.JerseyServices - Sending multipart for /v1/documents
19:12:20.492 [pool-1-thread-1] DEBUG c.m.client.impl.JerseyServices - Posting documents
19:12:20.492 [pool-1-thread-1] DEBUG c.m.client.impl.JerseyServices - Sending multipart for /v1/documents
19:12:22.428 [pool-1-thread-1] DEBUG c.m.client.impl.JerseyServices - Posting documents
19:12:22.428 [pool-1-thread-1] DEBUG c.m.client.impl.JerseyServices - Sending multipart for /v1/documents
19:12:22.428 [main] DEBUG c.m.client.impl.JerseyServices - Posting documents
19:12:22.428 [main] DEBUG c.m.client.impl.JerseyServices - Sending multipart for /v1/documents
19:12:24.427 [pool-1-thread-1] DEBUG c.m.client.impl.JerseyServices - Posting documents
19:12:24.427 [pool-1-thread-1] DEBUG c.m.client.impl.JerseyServices - Sending multipart for /v1/documents
19:12:24.428 [main] DEBUG c.m.client.impl.JerseyServices - Posting documents
19:12:24.428 [main] DEBUG c.m.client.impl.JerseyServices - Sending multipart for /v1/documents
19:12:24.974 [pool-1-thread-1] DEBUG c.m.client.impl.JerseyServices - Posting documents
19:12:24.974 [pool-1-thread-1] DEBUG c.m.client.impl.JerseyServices - Sending multipart for /v1/documents
19:12:25.037 [main] DEBUG c.m.client.impl.JerseyServices - Posting documents
19:12:25.037 [main] DEBUG c.m.client.impl.JerseyServices - Sending multipart for /v1/documents
19:12:25.318 [pool-1-thread-1] DEBUG c.m.client.impl.JerseyServices - Posting documents
19:12:25.318 [pool-1-thread-1] DEBUG c.m.client.impl.JerseyServices - Sending multipart for /v1/documents
19:12:25.442 [main] DEBUG c.m.client.impl.JerseyServices - Posting documents
19:12:25.442 [main] DEBUG c.m.client.impl.JerseyServices - Sending multipart for /v1/documents
19:12:25.553 [pool-1-thread-1] DEBUG c.m.client.impl.JerseyServices - Posting documents
19:12:25.553 [pool-1-thread-1] DEBUG c.m.client.impl.JerseyServices - Sending multipart for /v1/documents
19:12:25.802 [main] DEBUG c.m.client.impl.JerseyServices - Posting documents
19:12:25.802 [main] DEBUG c.m.client.impl.JerseyServices - Sending multipart for /v1/documents
19:12:25.849 [pool-1-thread-1] DEBUG c.m.client.impl.JerseyServices - Posting documents
19:12:25.849 [pool-1-thread-1] DEBUG c.m.client.impl.JerseyServices - Sending multipart for /v1/documents
19:12:26.161 [main] DEBUG c.m.client.impl.JerseyServices - Posting documents
19:12:26.161 [main] DEBUG c.m.client.impl.JerseyServices - Sending multipart for /v1/documents
19:12:26.255 [pool-1-thread-1] DEBUG c.m.client.impl.JerseyServices - Posting documents
19:12:26.255 [pool-1-thread-1] DEBUG c.m.client.impl.JerseyServices - Sending multipart for /v1/documents
19:12:26.660 [main] INFO  c.m.c.d.impl.WriteBatcherImpl - flushing 0 queued docs
19:12:26.660 [pool-3-thread-1] DEBUG c.m.client.impl.JerseyServices - Posting documents
19:12:26.660 [pool-3-thread-1] DEBUG c.m.client.impl.JerseyServices - Sending multipart for /v1/documents
19:12:26.708 [pool-1-thread-1] DEBUG c.m.client.impl.JerseyServices - Posting documents
19:12:26.708 [pool-1-thread-1] DEBUG c.m.client.impl.JerseyServices - Sending multipart for /v1/documents
19:12:27.473 [pool-1-thread-1] DEBUG c.m.client.impl.JerseyServices - Posting documents
19:12:27.473 [pool-1-thread-1] DEBUG c.m.client.impl.JerseyServices - Sending multipart for /v1/documents
19:12:27.566 [pool-3-thread-1] DEBUG c.m.client.impl.JerseyServices - Posting documents
19:12:27.566 [pool-3-thread-1] DEBUG c.m.client.impl.JerseyServices - Sending multipart for /v1/documents
19:12:27.831 [pool-1-thread-1] DEBUG c.m.client.impl.JerseyServices - Posting documents
19:12:27.831 [pool-1-thread-1] DEBUG c.m.client.impl.JerseyServices - Sending multipart for /v1/documents
19:12:28.086 [main] DEBUG c.m.client.impl.JerseyServices - Posting eval
S is true
WriteHostBatcher-1

WriteHostBatcher-2

WriteHostBatcher-3

If I understand correctly, you're asking for a feature that allows us to black-list a host using an alternate hostname to the one used by the server.  We won't be going that far.  If a customer would like that feature, they're welcome to write their own implementation of ForestConfiguration.  FilteredForestConfiguration was always just intended as a convenience and an example of what's possible.

Sam,
I see a discrepancy between the behavior of withWhitelist and withBlacklist methods. I create the client using hostname "rh7v-intel64-90-test-16" . The other hosts in the cluster are rh7v-intel64-90-test-17.marklogic.com, rh7v-intel64-90-test-18.marklogic.com.

When I blacklist "rh7v-intel64-90-test-16.marklogic.com", the forest configuration is

11:54:59.994 [main] INFO  c.m.c.d.impl.WriteBatcherImpl - (withForestConfig) Using [rh7v-intel64-90-test-17.marklogic.com, rh7v-intel64-90-test-16, rh7v-intel64-90-test-18.marklogic.com] hosts with forests for "WriteHostBatcher"

When I whitelist "rh7v-intel64-90-test-16.marklogic.com", the forest configuration is

11:45:26.494 [main] INFO  c.m.c.d.impl.WriteBatcherImpl - (withForestConfig) Using [rh7v-intel64-90-test-16.marklogic.com] hosts with forests for "WriteHostBatcher"
@Test
	public void testBlackWhiteList() throws Exception{
		Assume.assumeTrue(hostNames.length > 1);
		final String query1 = "fn:count(fn:doc())";
		DatabaseClient dbClient = DatabaseClientFactory.newClient("rh7v-intel64-90-test-16", 8000, "admin", "admin", Authentication.DIGEST);
		DataMovementManager dmManager = dbClient.newDataMovementManager();
		FilteredForestConfiguration forestConfig = null;
		DocumentMetadataHandle meta6 = new DocumentMetadataHandle().withCollections("NoHost").withQuality(0);

		WriteBatcher ihb2 =  dmManager.newWriteBatcher();
		forestConfig  = new   FilteredForestConfiguration(dmManager.readForestConfig()).withWhiteList("rh7v-intel64-90-test-16.marklogic.com");
		//forestConfig  = new   FilteredForestConfiguration(dmManager.readForestConfig()).withBlackList("rh7v-intel64-90-test-16.marklogic.com");
		ihb2.withBatchSize(50).withForestConfig(forestConfig);

		ihb2.onBatchSuccess(
		        batch -> {
		        	}
		        )
		        .onBatchFailure(
		          (batch, throwable) -> {
		        	  throwable.printStackTrace();

		          }
		);
		for (int j =0 ;j < 1000; j++){
			String uri ="/local/string-"+ j;
			ihb2.addAs(uri, meta6 , jsonNode);
		}

		ihb2.flushAndWait();
		Assert.assertTrue(dbClient.newServerEval().xquery(query1).eval().next().getNumber().intValue() == 1000);

	}

That's an interesting discrepancy, and may point to a future flaw.  At the moment I don't see it as a problem.  It probably has something to do with the feature we added to /v1/internal/forestinfo which attempts to rename the host you're talking to with the hostname you used for the connection.  Could you log this info in another issue so we can keep this one closed?  Unless you'd like to make a case for how they are the same issue.

I have restated the original issue (host not getting blacklisted) differently in my previous comment.  If db client is created using
DatabaseClient dbClient = DatabaseClientFactory.newClient("rh7v-intel64-90-test-16", 8000, "admin", "admin", Authentication.DIGEST);
preferred host is:  rh7v-intel64-90-test-16
Forest host (forest.getHost()):   rh7v-intel64-90-test-16.marklogic.com
Alternate :null
Open replica :rh7v-intel64-90-test-16
BlackList logic:
Since the preferred host is "rh7v-intel64-90-test-16" and the blacklist host is "rh7v-intel64-90-test-16.marklogic.com",  the  if ( blackList.contains(forest.getPreferredHost()) ) condition fails and hence the host is not blacklisted
if ( blackList.size() > 0 ) {
      replaced = replaced.map( forest -> {
        if ( blackList.contains(forest.getPreferredHost()) ) {
------
                 } else {
          return forest;
        }

WhiteList logic:
"rh7v-intel64-90-test-16.marklogic.com" is part of validHosts array and
following the code below, it determines the host using
String host = forest.getHost();
and returns the ForestImpl instance created with "rh7v-intel64-90-test-16.marklogic.com"
 if ( whiteList.size() > 0 ) {
      replaced = replaced.map( forest -> {
        if ( ! whiteList.contains(forest.getPreferredHost()) ) {
          if ( validHosts.length == 0 ) {
            throw new IllegalStateException("White list or black list rules are too restrictive:" +
              " no valid hosts are left");
          }
          // this forest has a preferred host which is not white-listed, so let's
          // replace it with an acceptable (valid) host
          String openReplicaHost = forest.getOpenReplicaHost();
          if ( ! whiteList.contains(openReplicaHost) ) {
            openReplicaHost = replaceHost(openReplicaHost, validHosts);
          }
          String alternateHost = forest.getAlternateHost();
          if ( ! whiteList.contains(alternateHost) ) {
            alternateHost = replaceHost(alternateHost, validHosts);
          }
          String host = forest.getHost();
          if ( ! whiteList.contains(host) ) {
            host = replaceHost(host, validHosts);
          }
          return new ForestImpl(host, openReplicaHost, alternateHost, forest.getDatabaseName(),
            forest.getForestName(), forest.getForestId(), forest.isUpdateable(), false);
        } else {
          return forest;
        }

Closing this issue and opening a new issue for discrepancy in behavior between white and black listing


Make more detailed and non confusing output for ModelCheckpoint callback

🚀 Feature
Show result of the best model selection algorithm inside ModelCheckpoint callback
Motivation
Its unclear and sometimes confusing what has been 'checkpointed' and why, especially in combination with mlflow autolog: you have no idea what model has been sent into mlflow
Pitch
Typical claaback creation looks like this:
checkpoint_callback = ModelCheckpoint(monitor='precision_val')

And it gonna be very helpful to produce output like this:
Best result for precision_val is 0.894 at epoch no. 45, model saved in $path or $logger you're using

Alternatives
My regular train/test cycle utilizes bestmodel selection algo and produces output like i've proposed

Dear @notonlyvandalzzz,
Sounds definitely interesting. Would you like to open a PR with this addition ?
Best,
T.C


Application is broken on Safari

Seems like the SWAN example doesn't work on Safari

Note:
@doktordirk:
safari windows gives: Unhandled rejection Error: HttpClient requires a Fetch API implementation, but the current environment doesn't support it. You may need to load a polyfill such as https://github.com/github/fetch.
@RWOverdijk:
Perhaps if we import the fetch client it's fixed

works for me https://github.com/SpoonX/swan-example-client/pull/35

http://aurelia.io/hub.html#/doc/article/aurelia/framework/latest/app-configuration-and-startup/3

@jeremyvergnas Does it work now?

Last time I tried, it did...

Can you close the issue then? :)


Device back button doesn't work when android_closeOnBackPress={true}

When android_closeOnBackPress={true}, device backbuttons don't work in Android devices. (in every screen)

@Riverknight0 Thanks for pointing this out, I'll check it out ASAP