fix(STONEINTG-1066): retry when finding application for ITS

retry when getting application for ITS to avoid race condition when application and ITS are created at the same time

Signed-off-by: Hongwei Liu<EMAIL_ADDRESS>Maintainers will complete the following section

[ ] Commit messages are descriptive enough (hints)
[ ] Code coverage from testing does not decrease and new code is covered (check the PR coverage on codecov)
[ ] Controllers diagrams are updated when PR changes controllers code  (if applicable)

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (main@da08d76). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #915   +/-   ##
=======================================
  Coverage        ?   66.32%
=======================================
  Files           ?       43
  Lines           ?     5693
  Branches        ?        0
=======================================
  Hits            ?     3776
  Misses          ?     1583
  Partials        ?      334

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

/retest


Update SnapshotTaskInputsBuildOperationResult to convey new attributes, and do not traverse empty directories when the sensitivity ignores them

Expose DirectorySensitivity and LineEndingSensitivity to SnapshotTaskInputsBuildOperationResult

This is done by a lose Set, built from the NormalizationStrategy, the DirectorySensitivity, the LineEndingSensitivity, in order to make the contract more stable for future changes
We aggregate all those attributes in a single enum, declared by the build operation result, to ensure there are no duplicates coming from the various sources. Consumers (build scan plugin) have to know this logic to fetch the things they are interested in, from the aggregate enum

Do not continue traversing empty directories when the sensitivity ignores directories

Return SKIP_SUBTREE when entering such a directory, to avoid pre/post-Visiting the directory

Nice work @facewindu

Superseded by #18278


const Set.empty constructor

Could be nice to have  const Set.empty constructor to be able to declare fields with Set type.

const {} constructs an empty set if used in a place where Set<T> is expected, e.g.
final Set<String> x = const {};  // const {} is an empty constant Set

to be able to declare fields with Set type

It is a bit unclear how this is related? Could you clarify? You can declare fields just fine - you just need to make sure they are initialised or nullable or late, e.g.
class X {
  final Set<String> s;
  X(this.s);  // ok
  X({required this.s}); // also ok
  X() : s = something; // also ok
}

@mraleph
final Set<T> x = const <T>{};

awesome, thanks a lot


username AND password ?

Is there any way to supply username and password ? There is only password textbox for entering connection info.

Supported in the latest version(beta-0.9.0)


[move-prover] add strong edges for vector writebacks

…

Motivation
Strong edges for vector writebacks should further improve verification runtime. This commit also fixes a bug in the previous version of strong direct reference writebacks.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Plan to add some unit tests in to the bytecode test suite in future commit. This was tested on all existing benchmarks. Also recall that strong writebacks are off by default when using the move-prover, so this won't affect any integration testing at this time.

\land

/land


Tip

Hi,
Nice work
I think u should try to create the linux version using appimage , it will be easier to use and install.
https://appimage.org/
Also, Please add https://subscene.com/ because it is the only one on which subtitles of the latest episodes are uploaded within minutes after the release

Also https://subs4me.net is amazing


Expiring cache

Overview
This implements an FDB backed key value cache, where each entry has a "stale" and "expires" time associated with it. Once the current time exceeds the "expires" time, the entry is automatically removed.
Potentially useful for implementing e.g. interfaces to external systems such as OAuth 2.

Testing recommendations
make check apps=couch_expiring_cache

Related Issues or Pull Requests

Checklist

[x] Code is written and works correctly
[x] Changes are covered by tests
[x] Any new configurable parameters are documented in rel/overlay/etc/default.ini
[ ] A PR for documentation changes has been made in https://github.com/apache/couchdb-documentation

@jaydoane nice works, small and easy to understand!
Made a few comments in-line.
Was also wondering if you thought about building it more as a library, such that it would plug into to another application's supervisor with something like:
couch_expiring_cache:start_link(Name, Options) when is_atom(Name) ->
    gen_server:start_link({local, Name}, ...) -> ets:new(Name, [named_table, ...]).

Then we wouldn't need a way to disable or enable the whole application and it would be started only as needed. What do you think? If you'd rather keep it as is, that'll work just. Just thought to explore another option.

Was also wondering if you thought about building it more as a library, such that it would plug into to another application's supervisor something like:

couch_expiring_cache:start_link(Name, Options) when is_atom(Name) ->
    gen_server:start_link({local, Name}, ...) -> ets:new(Name, [named_table, ...]).

@nickva this is an interesting idea, and I hadn't considered adding the cache to an existing supervisor tree, as your snippet seems to imply. I'm guessing that Options could be a map containing optional overrides for period, jitter, and batch size. I think this would also imply a subtle change to the data model, where each Name gets its own gen_server on each node, and
(?EXPIRING_CACHE, ?EXP, ExpiresTS, Name, Key) := ()
would become
(?EXPIRING_CACHE, ?EXP, Name, ExpiresTS, Key) := ()

The main drawback I could think of with such an approach is that unexpired entries of abandoned/changed Names. would never be cleared without some explicit garbage collection mechanism. Alternately, it could use a system like couch_jobs, and explicitly manage names, but that adds complexity.

@jaydoane I was thinking it would be like having N expiring caches, one for each application that needs it. Each would have its own timeouts, etc. Presumably the expiring cache for OAuth2 vs some other auth mechanism could need different expiry and stale timeouts. The model would then look like:
(?EXPIRING_CACHE, Name, ?PK, Key) := (Val, StaleTS, ExpireTS)
(?EXPIRING_CACHE, Name, ?EXP, ExpireTS, Key) := ()

So there would be one for OAuth2 with something like Name = oauth2_xcache. If there another auth library application it would have Name = otherlib_xcache. Each application would then be in charge of starting its own expiry cache child in its supervisor, cleaning up stale entries, updating entries, etc.

(?EXPIRING_CACHE, Name, ?PK, Key) := (Val, StaleTS, ExpireTS)
(?EXPIRING_CACHE, Name, ?EXP, ExpireTS, Key) := ()

@nickva I think the main issue with this schema is that if application Name is retired, or changes its name while there are still unexpired cache entries, those entries will remain as garbage indefinitely in FDB without a way to get cleaned up. We could of course create a registry for cache names similar to how job types are registered, but that adds complexity. Not sure if there's a simpler way to do it, or whether it's even a real concern. I suppose we could just create a cleanup function that should be called (manually) when a Name is retired/changed?

@jaydoane Looks great. See a few minor notes.
To run tests I had to add it to the subdirs in rebar:
--- a/rebar.config.script
+++ b/rebar.config.script
@@ -92,6 +92,7 @@ SubDirs = [
     "src/fabric",
     "src/couch_jobs",
+    "src/couch_expiring_cache",

Otherwise tests ran and passed.
Created an expiring cache manually and saw that entries were being returned as fresh, stale, expired then cleaned up and returned as non_found.
 couch_expiring_cache:insert(<<"auth-decision">>, <<"a">>, <<"x">>, erlang:system_time(millisecond) + 6000, erlang:system_time(millisecond) + 10000), couch_expiring_cache:lookup(<<"auth-decision">>, <<"a">>).
{fresh,<<"x">>}
(node1@<IP_ADDRESS>)79> couch_expiring_cache:lookup(<<"auth-decision">>, <<"a">>).                        {fresh,<<"x">>}                                                                                couch_expiring_cache:lookup(<<"auth-decision">>, <<"a">>).
{fresh,<<"x">>}
(node1@<IP_ADDRESS>)81> couch_expiring_cache:lookup(<<"auth-decision">>, <<"a">>).
{fresh,<<"x">>}
(node1@<IP_ADDRESS>)89> couch_expiring_cache:lookup(<<"auth-decision">>, <<"a">>).
{stale,<<"x">>}
(node1@<IP_ADDRESS>)90> couch_expiring_cache:lookup(<<"auth-decision">>, <<"a">>).
{stale,<<"x">>}
(node1@<IP_ADDRESS>)91> couch_expiring_cache:lookup(<<"auth-decision">>, <<"a">>).
{stale,<<"x">>}
(node1@<IP_ADDRESS>)92> couch_expiring_cache:lookup(<<"auth-decision">>, <<"a">>).
{stale,<<"x">>}
(node1@<IP_ADDRESS>)93> couch_expiring_cache:lookup(<<"auth-decision">>, <<"a">>).
{stale,<<"x">>}
(node1@<IP_ADDRESS>)94> couch_expiring_cache:lookup(<<"auth-decision">>, <<"a">>).
{stale,<<"x">>}
(node1@<IP_ADDRESS>)103> couch_expiring_cache:lookup(<<"auth-decision">>, <<"a">>).
{stale,<<"x">>}
(node1@<IP_ADDRESS>)104> couch_expiring_cache:lookup(<<"auth-decision">>, <<"a">>).
{stale,<<"x">>}
(node1@<IP_ADDRESS>)105> couch_expiring_cache:lookup(<<"auth-decision">>, <<"a">>).
expired
(node1@<IP_ADDRESS>)106> couch_expiring_cache:lookup(<<"auth-decision">>, <<"a">>).
expired
(node1@<IP_ADDRESS>)107> couch_expiring_cache:lookup(<<"auth-decision">>, <<"a">>).
not_found
(node1@<IP_ADDRESS>)109> couch_expiring_cache:lookup(<<"auth-decision">>, <<"a">>).
not_found

Nice work!
+1 (after the minor fixes from the comments)


Update reserved-word-limitations.md

(My 2nd edit) Hopefully a link to the mentioned document is allowed here and this is the correct syntax?
(Am I overlooking an MS Docs Standard Formatting Guide somewhere?)

@ashleedawg : Thanks for your contribution! The author, @MightyPen, has been notified to review your proposed change.

#hold-off
.
@ashleedawg  I am looking at your public PR 598, and I like its idea of adding a good link! In fact, I am going to steal it.  :-)
.
I would like to integrate the addition of this link with other improvements to the article. I might even have a more up-to-date and more long-term link to use instead. So...
.
I am going to Close this PR 598 (and it will not be merged to master). And...
.
I am now implementing its idea in private PR 5730. The effects of 5730 should be live on late Tuesday 2018/May/01, or at least before the end of this week.
.
Thank you very much for submitting this PR.


fix(app): Support to present multi credentials based on the input descriptors matched vc ids

Codecov Report
Patch and project coverage have no change.

Comparison is base (6cbfd34) 90.56% compared to head (a684575) 90.56%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #299   +/-   ##
=======================================
  Coverage   90.56%   90.56%
=======================================
  Files          54       54
  Lines        2278     2278
=======================================
  Hits         2063     2063
  Misses        148      148
  Partials       67       67

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


[improve][client] cleaned client grabCnx connection logic

Fixes #xyz

Main Issue: #xyz

PIP: #xyz

Motivation

Modifications

Verifying this change

[ ] Make sure that the change passes the CI checks.

(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end deployment with large payloads (10MB)
Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

[ ] Dependencies (add or upgrade a dependency)
[ ] The public API
[ ] The schema
[ ] The default values of configurations
[ ] The threading model
[ ] The binary protocol
[ ] The REST endpoints
[ ] The admin CLI options
[ ] The metrics
[ ] Anything that affects deployment

Documentation

[ ] doc
[ ] doc-required
[ ] doc-not-needed
[ ] doc-complete

Matching PR in forked repository
PR in forked repository:

note: lookups for getPartitionedTopicMetadata, createProducerAsync, and patternTopicSubscribeAsync client operations still go to the old cluster.


Partial finds on searching

This method of querying can be quite useful when constructing a query out of user-supplied query text. For example, you could support prefix based queries (for example, searching for ca* to match cat), how can I do this? Thanks in advance.

Hello, team.
Have the same question as reporter. Any ideas for it?

@OxidBurn in the meantime that they answer, would you have any idea to go about it?

The README contains an example of searching for ca* to using predicate based queries. If you're using the string-based query methods, you can simply search for the string ca* (this is simply passed to the CLucene query parser).
In the README predicate query example, the NSBeginsWithPredicateOperatorType performs prefix-based matching. The NSLikePredicateOperatorType parses the predicate value using the CLucene query parser. The docs talk a bit more about this, and include a link more information on the CLuene query parser syntax.

@msqr thanks for your message, as you can see below in my code, I already use

NSBeginsWithPredicateOperatorType and is not working for me when I perform prefix-based marching.

`func predicteForSearch(withQery query:String) -> NSCompoundPredicate {
    var ValueExpression:NSExpression! = nil

    if ValueExpression == nil {
        ValueExpression = NSExpression(forKeyPath: kBRSearchFieldNameValue)
    }
    let tokens = [query.trimmingCharacters(in: CharacterSet.whitespacesAndNewlines).components(separatedBy: CharacterSet.whitespacesAndNewlines)]
    var predicates:[NSComparisonPredicate] = []
    for token in tokens {

        let p1 = NSComparisonPredicate(leftExpression: ValueExpression,
                              rightExpression: NSExpression(forConstantValue: token),
                              modifier: NSComparisonPredicate.Modifier.direct,
                              type: NSComparisonPredicate.Operator.like,
                              options: NSComparisonPredicate.Options(rawValue: 0))

        predicates.append(p1)

        let p2 = NSComparisonPredicate(leftExpression: ValueExpression,
                                       rightExpression: NSExpression(forConstantValue: token),
                                       modifier: NSComparisonPredicate.Modifier.direct,
                                       type: NSComparisonPredicate.Operator.beginsWith,
                                       options: NSComparisonPredicate.Options(rawValue: 0))

        predicates.append(p2)

        let p3 = NSComparisonPredicate(leftExpression: ValueExpression,
                                       rightExpression: NSExpression(forConstantValue: token),
                                       modifier: NSComparisonPredicate.Modifier.direct,
                                       type: NSComparisonPredicate.Operator.matches,
                                       options: NSComparisonPredicate.Options(rawValue: 0))

        predicates.append(p3)

    }

    return NSCompoundPredicate(orPredicateWithSubpredicates: predicates)

}`

It's hard for me to know what you're not seeing that you expect to see, because I don't know what you're indexing and adding to the search index. From this code sample, in theory the prefix matching will be utilized and I haven't experienced problems with that myself. I should add that the predicate types NSLikePredicateOperatorType and NSMatchesPredicateOperatorType both produce parsed query terms, so you're adding duplicate terms to your overall compound query. I don't know that would prevent it from matching, however.
I've used the Luke tool to examine the index created by BRFullTextSearch in the past. It can help you at least see what is in the index, and try out some searches to see what a query does/does not match. If you print the description of your search results object it will also show you the overall query, which you can then try out in Luke.

@msqr Thank you for your response, I have used Luke tool as you mentioned to further debug and examine my situation. This is what I noticed: When I pass the lucene index that is created by BRFullTextSearch and pass the query v:contro* I get search result. Now what I have noticed, is when I pass the print out of the description of my search result object (from the search services on Xcode) and trying out in Luke it does not output any result.
This is the description of my search result object query: "CLuceneSearchResults{hits=0, query=(v:contro) v:(\n    \"Contro*\"\n)* (v:contro)}"
Please pay attention to the attached images.

So what does this mean? hope that you can guide me to a path that I could solve this issue.

Those \n newline characters in the query look odd; I don't think the output of the description method can be used directly as a Lucene query. I'd expect the query to be more like v:contro v:contro*. The second v:contro I believe would be eliminated if you dropped the NSMatchesPredicateOperatorType predicate from your code.
Does it make any difference in Luke if you search for v:contro v:contro* instead?

@msqr This

@msqr After some investigation and thanks to your reply, figure what was causing the issues:
1. Fix the tokens query array (the fix is mentioned below)
2. For prefix queries need to be in lowercase as you mentioned otherwise it would not return any results.

Those \n newline characters in the query look odd; I don't think the output of the description method can be used directly as a Lucene query. I'd expect the query to be more like v:contro v:Contro(*). The second v:contro I believe would be eliminated if you dropped the NSMatchesPredicateOperatorType predicate from your code.

The output of the description method can not be used directly as a Lucene query. It was not eliminated if I dropped  NSMatchesPredicateOperatorType predicate from my code, in fact it was removed when I changed my code from
let tokens = [query.trimmingCharacters(in:CharacterSet.whitespacesAndNewlines).components(separatedBy: CharacterSet.whitespacesAndNewlines)]

to :
let tokens = query.trimmingCharacters(in:CharacterSet.whitespacesAndNewlines).components(separatedBy: CharacterSet.whitespacesAndNewlines)

Does it make any difference in Luke if you search for v:contro v:Contro(*) instead?

This way it would not return any results, because for prefix values it should be in lower case, so v:contro* does yield results in Luke
Also, noticed for searching prefix queries, I noticed that I do not need to put * at the end of my search term, because after calling searchService.search and displaying its description it already puts it at the end of the string. Now if I explicitly in my search put *, in my query there will be for example contro** which does not yield any result.

Also, noticed for searching prefix queries, I noticed that I do not need to put * at the end of my search term, because after calling searchService.search and displaying its description it already puts it at the end of the string. Now if I explicitly in my search put , in my query there will be for example contro* which does not yield any result.

Yes, the * should not be added when using predicate based queries, that is simply the query parser syntax for representing prefix-based searches when you use the string-based query methods.
Does this mean you are seeing the expected results now?

@msqr good to know, just wanted to clear it out.

Does this mean you are seeing the expected results now?

Yes, the expected results are shown. Thank you for the support.

Excellent! Glad to know it is sorted now.

Haha - good pun!
On Thu, Oct 12, 2017 at 3:26 PM, Matt Magoffin<EMAIL_ADDRESS>wrote:

Excellent! Glad to know it is sorted now.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Blue-Rocket/BRFullTextSearch/issues/26#issuecomment-336294354,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABfXMyG3EBbyvB0_66HQg3yGxvGBmC1tks5srpITgaJpZM4PyThQ
.

--
Wm Jess Taylor
CEO & Founder
Blue Rocket
Mobile is our Mission
Tel:<PHONE_NUMBER> | Skype: wmjesstaylor
233 Sansome Street, 11th Floor
San Francisco, CA 94104
www.bluerocket.us
Follow us on:
LinkedIn http://www.linkedin.com/company/bluerocketinc
Twitter https://twitter.com/BlueRocketInc
Facebook https://www.facebook.com/BlueRocketInc


Escaping custom tag as vue component

Hey,
I want to ignore a custom tag eg:  to treat or count as a vue component.
How can I do that?
It is giving warning now.
Is there any way to change commonTagRE as below
commonTagRE = /^(div|p|span|img|a|b|i|br|ul|ol|li|h1|h2|h3|h4|h5|h6|code|pre|table|th|td|tr|form|label|input|select|option|nav|article|section|header|footer|my-tag)$/;

Or it can be done via Vue.util.extend() ?

Are you trying to use a native element as a Vue component? If that's the case - you shouldn't, that's why there's a warning.

No I was trying with a custom element "" and that causing the warning.
Is there any way to ignore or escape the warning for a tag (if I set in config) ?

There's currently no built-in mechanism for that - however you can register an empty elementDirective:
Vue.elementDirective('trix-editor', {})

This also makes Vue skip any content inside that element.

Thanks a lot @yyx990803 we're all planned to use VueJs in our company (wedevs.com)[wedevs.com]
It's really cool and simpler thing you've made.


DEC-243: V1/Controller caching

These changes should capture all needed data for all v1 controllers when generating etags.

Coverage remained the same at 93.76% when pulling f11227993b9f4ad03d224042a33535b3e0d9c556 on DEC-243 into 6714b3d5715190f96ba2c539420dcec59693266c on master.

:+1:

:+1:


how to add support for other languages?

hi! i've added a bunch of texts in russian for learning, just to see what will happen, but seems like there is some kind of limitation in the my_txtutils.py on utf8
how can i remove this limitations?
or is there any way around?

ok i've looked into this fork and just be tweaking the letter dictionary seems to be working fine https://github.com/mapmeld/tensorflow-rnn-esperanto
thanks for your amazing work, and those jokes at day 2 where really amazing, man!


[WIP] Special patterns of inequality to equality converters

Summary
Resolves https://github.com/Qiskit/qiskit-optimization/issues/40
Details and comments
Owned by Amano-san and me

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: knamba-jp:x: ibmamntYou have signed the CLA already but the status is still pending? Let us recheck it.

We need a more intuitive name than SpecialConstraintToPenalty because there might be other types of inequality to equality converters in the future.

 See #117 for details.

We will run black command as suggested. As for the name of the class.
@t-imamichi How about this name ?
KnownConstraintConverter

Thanks. The code format looks good. The naming is a bit difficult. What is the best name for this converter...? Maybe we can leave it later.

LinearInequalityToPenalty may work.
FYI, you don't have to implement patterns x+y=1 and x=y because LinearEqualityToPenalty can handle them.

Since some errors can't be fixed, we'll open another PR.


Field "chat_history" in prompt uses a MessagesPlaceholder, which expects an array of BaseMessages as an input value.

The code below throws an unexpected error:
  const json = [
    {
      type: "human",
      data: { content: "hi my name is Mario", additional_kwargs: {} },
    },
    {
      type: "ai",
      data: {
        content: "Hello, Mario! How can I assist you today?",
        additional_kwargs: {},
      },
    },
  ] as StoredMessage[];
  const messages = json.map((x) => mapStoredMessageToChatMessage(x));
  const ok = messages.every((x) => isBaseMessage(x));
  console.log("ok", ok); // prints true
  const memory = new BufferMemory({
    chatHistory: new ChatMessageHistory(messages),
    memoryKey: "chat_history",
  });
  const executor = await initializeAgentExecutorWithOptions(tools, model, {
    agentType: "chat-conversational-react-description",
    memory,
  });
await executor.call({ input: "what is my name?" })

It looks like this may be related to #2871 ... see stack trace below
Error [InputFormatError]: Error: Field "chat_history" in prompt uses a MessagesPlaceholder, which expects an array of BaseMessages as an input value. Received: Human: hi my name is Mario
AI: Hello, Mario! How can I assist you today?
    at MessagesPlaceholder.validateInputOrThrow (langchain/node_modules/langchain/dist/prompts/chat.cjs:120:27)
    at MessagesPlaceholder.formatMessages (langchain/node_modules/langchain/dist/prompts/chat.cjs:127:14)
    at ChatPromptTemplate.formatMessages (langchain/node_modules/langchain/dist/prompts/chat.cjs:356:53)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async ChatPromptTemplate.formatPromptValue (langchain/node_modules/langchain/dist/prompts/chat.cjs:171:32)
    at async LLMChain._call (langchain/node_modules/langchain/dist/chains/llm_chain.cjs:123:29)
    at async LLMChain.call (langchain/node_modules/langchain/dist/chains/base.cjs:104:28)
    at async LLMChain.predict (langchain/node_modules/langchain/dist/chains/llm_chain.cjs:142:24)
    at async ChatConversationalAgent._plan (langchain/node_modules/langchain/dist/agents/agent.cjs:234:24)
    at async AgentExecutor._call (langchain/node_modules/langchain/dist/agents/executor.cjs:144:26)

hi just wanted to confirm that this issue does not happen in version 0.0.165 of the langchain package, but it happens in versions 0.0.166 and later (including the latest, 0.0.169). thanks.
@bracesproul @jacoblee93

This is expected, you'll need to set returnMessages: true on your buffer memory instance.
I'm surprised it was working properly before?

ok, it works now with 0.0.169. thanks @jacoblee93

@jacoblee93 I have a conversationChain
const chain = new ConversationChain({
    llm: model,
    memory: chatPromptMemory,
    prompt: chatPrompt,
  });

The chatPromptMemory is a ConversationSummaryBufferMemory. You are correct in that you have to have returnMessages:true for it to work, but doesn't that defeat the purpose of using ConversationSummaryBufferMemory since it is returning all messages and using lots of tokens? Is there any way to make it work without returning messages?
 const chatPromptMemory = new ConversationSummaryBufferMemory({
    llm: new ChatOpenAI({
      modelName: "gpt-3.5-turbo-0125",
      temperature: 0,
      openAIApiKey: "OPENAI_API_KEY",
    }),
    maxTokenLimit: 10,
    returnMessages: true,
    chatHistory: messageHistory,
  });

When I tried it said field "history" in prompt uses a messagesplaceholder, which expects an array of basemessages as an input value.
For context, my chatHistory is a FirestoreChatMessageHistory.
This is my prompt template:
 const chatPrompt = ChatPromptTemplate.fromMessages([
    SystemMessagePromptTemplate.fromTemplate(
      "You are a helpful assistant"
    ),
    new MessagesPlaceholder("history"),
    HumanMessagePromptTemplate.fromTemplate("{input}"),
  ]);

Thanks in advance!

Yeah that looks right - if returnMessages is true it should serialize the summary as a message as well.
We're moving away from these memory and chain classes in general as they're a bit tricky to use. See:
https://js.langchain.com/docs/use_cases/chatbots/


virtual-pointer: Add request for mapping to specific output

Can you open a wlr-protocols pull request for the protocol changes too?

Can do. The wayvnc branch for this is here: https://github.com/any1/wayvnc/tree/input-output-mapping

Overall looks good. Can you update this patch to use the latest protocol proposal?

Thanks!


Make plugin controls and render components replaceable

Let's first talk about this.
Right now I am working on the client app, place where the content is rendered but not modified. Problem is right now I am forced to install material-ui which I would like to avoid. It seems that in order for the HTML (and later react-native) renderer, this lib is not required but as both serialize/deserialize and the rest of UI is in one file, you need it even when it's not used. My thinking is we could separate it away into another file (renderer.js for example) then the plugin index.js could load and include this but you would also have an option to just load the bare-bones necessary for the rendering. It sounds simple but it seems like I might be forgetting about something, plus I am doing this AFK so I am almost sure I definitely am. Let me know your thoughts. (also this would make implementing RN much simpler)

Why is it a problem to have it in the dependencies? Maybe some plugin actually needs MUI for rendering! I'm not sure how this would work as a separate file, depending on how the plugin is packaged you might just get a single file (bundle).

Your plugin can export StaticComponent alongside Component which is the component to be used for (HTML) rendering. I'm not sure if we can avoid Component from being loaded completely, but shouldn't something like tree-shaking do that for us?

Yeah that's true but like you've said, it would still include that in the bundle. We would have to load it dynamically in order for the tree shaking to work. I have some other solution in mind. Will get my hands dirty and put together a POC. I think that's the best way to explain what I am after. Also the way I want to do it will allow for RN implementation later.

Hey the video was great for understanding what you're up to. This concept is really amazing, I love it! This will greatly improve the API of the plugins and again we see how react shines here!
I think it would even be an option to have the editor-ui renamed to ory-editor-mui-ui which ships UI components for the default plugins. This will make it a breaking change but it will also significantly improve the packaging. This is awesome!

Once we have typescript, it will be a no-brainer to couple mui-ui with the typedefs of the plugins and maybe even add some tests or whatever. This is really great, excited to see this!

Awesome! I though the video would help, it's just easier to explain stuff like that when you can see what I had in mind. At the moment, we made a decision to postpone react-native app for android and IOS. We will only have the web version for now. That means there's less pressure and we can think about this more. I will be out of office from 21st of September till 7th of October, I think you mentioned on another issue you are gone for the next 2 weeks. That means we can focus on this after 7th of October I guess. It's not a great deal of work, it just needs to be though of and done properly the first time around. I would also like to make sure all plugins are functions (not objects) plus like you've said, typescript will just make this an amazing, strongly typed, easy to use suite of powerful and modifiable ecosystem. Can't wait!
I also like the ory-editor-mui-ui, we could maybe do a "withMuiControls" and "withHtmlRendering" high order functions that you could use to wrap plugins (and inject UI automatically). Existing stuff ahead!

Yeah, this really sounds like a major improvement to this project. I really, really like this change :) Yes, I'm ooo, Oct 7 sounds like a perfect start :) Enjoy your time off!

Likewise mate, I am happy with the direction this is going. You are also very open minded compared to some other open-source maintainers and thanks god for that! I think this way we can take a great lib and make it even better! Enjoy your time off as well, I just hope we'll be able to make sure all the slate lists stuff is fixed before you go as discussed in #585 :)

i have now the same problem: i have an admin page that allows editing content and a frontend page that should only show the content using the HTMLRenderer.
Because the plugins pull in material-ui, i need to install that and it will even be bundled.
@PeterKottas how did you proceed after this discussion here? did you find any good solution?

Hey man, it was indeed merged in. Check out https://github.com/react-page/react-page/pull/634 . All plugins except for slate expose createPlugin function. It's not well documented but it's pretty powerful. I didn't have time to finish slate though. Would be great if you could look into it. I can give you some guidance. It's pretty straight forward. It just requires some high-level API thinking. The main idea behind the whole thing is to separate the rendering and editing pipeline.
Alternatively, I recommend looking at null-loader that can help you reduce the size of the lib. But not always. There are places where the code does something like
import foo from 'bar';
// This would be fixable by using null-loader. But then further down the road comes
foo.something = bla bla;
// Which obviously throws null reference.

At some point, I'll like get to a point when I get pissed off and rewrite the whole slate plugin (it's a mess in general). But no soon as I am pretty busy.
Sidenote, @aeneasr we should also update material-ui to v4

@PeterKottas thx for the info.
null-loader is a cool trick, thx for that!
My current plan is to integrate react-page in a nextjs app, on some pages it should just render, on others it should be editable. So null-loader would not work, because i would need the ui at some point ;-)
for my use case the most easy way would probably dynamic import (await import("module")), but i am not sure if that works if the dynamic import happens inside a node_module. Also this would limit usage of react-page to frameworks that support dynamic loading... 🤔

speaking about slate, i made some modifications there as well: https://github.com/react-page/react-page/pull/695, can you take a look?

@PeterKottas thx for the info.
null-loader is a cool trick, thx for that!
My current plan is to integrate react-page in a nextjs app, on some pages it should just render, on others it should be editable. So null-loader would not work, because i would need the ui at some point ;-)
for my use case the most easy way would probably dynamic import (await import("module")), but i am not sure if that works if the dynamic import happens inside a node_module. Also this would limit usage of react-page to frameworks that support dynamic loading... 🤔

What you're describing sounds like it could be solvable quite nicely with https://www.smooth-code.com/open-source/loadable-components/docs/getting-started/ .
You will need to be a little careful when doing so to separate all imports of said modules into separate reusable component. If you forget as little as one, e.g.
import {Value} from 'slate';

The junks won't work as expected. I am just saying cause it happened to me. I used Value from slate to check if a text field was empty. And it broke everything. Another thing that we need to look at in this lib is making the whole thing smaller.
I will take a look at #695 and let you know.

now controls are lazy-loaded. Material-ui still needs to be installed, but most of it is not bundled when you only use the editor in read-only mode (or with htmlrenderer).
react-native support is still a long way though. A react-native-renderer (without editing) would be a first step, but its probably best to write that from scratch and you would need to tell it how to render every plugin.

Yep @macrozone all of this makes perfect sense, that being said, if somebody reads this, please check https://github.com/react-page/react-page/issues/698#issuecomment-522684278 for more details.

I close that for now.
I think even if we support react-native, it would first just be rendering. You would still need to edit it on web.
I also think it would be more important to provide good default controls and a good default ui, instead of making it easy to replace it. The editor-ui should be opinionated. It also makes it easier to maintain.
The renderer on the other hand can be anything, we can also later add a reactNativeRenderer support, although that would need to have a shared code-base between react-native and web, which is probably not a good idea. It's probably up to the developer how plugins should be organized and shared between the webbased editor and the react-native renderer. The renderer would only need to know all plugins names and the component to render based on the plugin's state and name.


build qtdrv on windows7 x64 failed

when execute the follow cmd, it failed to build go-ui on Windows 7 64 bit system.
$ cd go-ui/ui
$ go install
The error message is as below:
In file included from $WORK\github.com\vanloswang\go-ui\ui_obj_cgo_export.c:2:
0:
.\cdrv.go:64:14: error: conflicting types for 'drv_result'
Data uintptr
^
.\cdrv.go:25:13: note: previous declaration of 'drv_result' was here
extern int drv_result(void*,int);
^
.\cdrv.go:68:14: error: conflicting types for 'drv_callback'
          ^

.\cdrv.go:13:13: note: previous declaration of 'drv_callback' was here
extern int drv_callback(void*,void*,void*,void*,void*);
^
F:\GoLang\GoDev\src\github.com\vanloswang\go-ui\ui>go install
github.com/vanloswang/go-ui/ui
In file included from $WORK\github.com\vanloswang\go-ui\ui_obj_cgo_export.c:2:
0:
.\cdrv.go:64:14: error: conflicting types for 'drv_result'
Data uintptr
^
.\cdrv.go:25:13: note: previous declaration of 'drv_result' was here
extern int drv_result(void*,int);
^
.\cdrv.go:68:14: error: conflicting types for 'drv_callback'
          ^

.\cdrv.go:13:13: note: previous declaration of 'drv_callback' was here
extern int drv_callback(void*,void*,void*,void*,void*);
^
anyone have some suggestions?

fixed


Support React V18.1.0

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving<EMAIL_ADDRESS>npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/react
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer<EMAIL_ADDRESS>|| ^15.0.0-rc || ^15.0.0 || ^16.0.0" from<EMAIL_ADDRESS>npm ERR! node_modules/react-select2-wrapper
npm ERR!   react-select2-wrapper@"*" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

Did you solve this?

Was this resolved?


Improve filtering of getFeatures

Currently, requests to /linked-data/{featureSource} are not very feasible due to the amount of data that is returned from most sources. Adding filter parameters could make the endpoint more useful.
A use case that I have is that I want to retrieve features from nwissite so that I know whether to make subsequent calls rather than attempting calls that will potentially be 404.
Some options would include:
pagination - allows me to get every source, but increases service calls
?identifier={id1},{id2},...,{idn} - only returns features in this list of identifiers, limited by url/param length limits

A few ideas we've had on this.

return only ids if you did /linked-data/{featureSource}/ids as suggested in #20
there's been discussion of supporting the offset={x}&limit={y} paging pattern as supported by OGC API Features.
a bbox filter as supported in the core of API features might be a good way to go.
there's interest in a multi-ID request pattern in #237 maybe we support a ids={1,2,3,4} pattern where the list of patterns can be a form encoded post if it gets too long?

I think option 1 works best for my use case. Thinking about it again, if I were to makes requests with ?identifier= for all of the identifiers I have, then I might as well be calling the regular endpoint to see if I get a 404. The time save is not likely to be significant. (still useful for smaller use cases) Option 1 could still run into the same size issue depending on the size of the dataset, although it'll be an improvement over returning all data.

@dblodgett-usgs I think we can close this issue. Adding pagination and other OGC features would resolve this in a more formal way.


[Request]: Add VeraCrypt

Prerequisites

[X] I have searched all issues/PRs to ensure it has not already been reported or fixed.

Criteria

[X] Reasonably well-known and widely used (e.g. if it's a GitHub project, it should have at least 100 stars and/or 50 forks)
[X] English interface (or at least English documentation)
[X] Latest stable version
[X] Full version (i.e. not a trial version)
[X] Fairly standard install (e.g. uses a version-specific download URL, no elaborate pre/post install scripts)

Name
VeraCrypt
Description
VeraCrypt is a free open source disk encryption software for Windows, Mac OSX and Linux.
Homepage
https://veracrypt.fr/en/Home.html
Download Link(s)
https://veracrypt.fr/en/Downloads.html
Some Indication of Popularity/Repute
https://alternativeto.net/software/veracrypt/about/

duplicate of #2381


broadcom-sta: fixes for kernel version >= 3.18

This replaces our patches with those from Arch's package [1]. Further
discussion can be found on the Arch forum [2].
This patch set is a superset of the previous set, and resolves the
immediate and consistent kernel panics I've seen on my MacBook Pro
Retina since switching from version 3.16 to 3.18 of the Linux kernel.
1: https://aur.archlinux.org/packages/broadcom-wl/
2: https://bbs.archlinux.org/viewtopic.php?id=192287

I plan to merge this shortly, if there are no objections.


SCRD-5901 Switch to parcel

Tests:
:heavy_check_mark: dev build
:heavy_check_mark: Hot module reloading
:heavy_check_mark: less compilation
:heavy_check_mark: Asset management
:heavy_check_mark: locale bundle loading
Pros:

Fewer direct dependencies
Fewer configuration
Faster (26 seconds vs 50 seconds)

Cons:

localization bundle won't be easily editable on a deployed system
This is all automagic, we may end up in a place where some customization we need to make is difficult or impossible.

I haven't tried this yet. Have you tested it with all of the things we need: production builds, development builds with hot reloading, sccs compilations, etc.?

@eapodaca  I am still testing ...but it doesn't seem to hot reload when I changed the file

Looks like, first time change , the hot reload works...but second time it stops working...

Looks like, first time change , the hot reload works...but second time it stops working...

I can't seem to replicate this issue, it works many times for me.

For me, this is failing to even start. I wiped out my node_modules directory, then ran npm install and npm start, and I just get a stack dump:
$ npm start

><EMAIL_ADDRESS>start /home/gary/projects/ui
> NODE_ENV=development parcel serve -p 2209 index.html

Server running at http://localhost:2209
🚨  Maximum call stack size exceeded
    at String.replace (<anonymous>)
    at /home/gary/projects/ui/node_modules/dotenv-expand/lib/main.js:8:23
    at Array.forEach (<anonymous>)
    at interpolate (/home/gary/projects/ui/node_modules/dotenv-expand/lib/main.js:7:13)
    at /home/gary/projects/ui/node_modules/dotenv-expand/lib/main.js:14:18
    at Array.forEach (<anonymous>)
    at interpolate (/home/gary/projects/ui/node_modules/dotenv-expand/lib/main.js:7:13)
    at /home/gary/projects/ui/node_modules/dotenv-expand/lib/main.js:14:18
    at Array.forEach (<anonymous>)
    at interpolate (/home/gary/projects/ui/node_modules/dotenv-expand/lib/main.js:7:13)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>start: `NODE_ENV=development parcel serve -p 2209 index.html`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>start script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

I also tried the same exercise with yarn instead of npm and got the  same results.
Any ideas?

One more question: does it do source maps so that you can debug the original source in the browser?

As a followup, the stack dump was cause by the application incorrectly loading $HOME/.env, even though it had nothing to do with node. The workaround was to create an empty .env in the project directory.
And source maps are supported automatically.

When I run day2, I get errors on every translate call. My browser console is filled with warnings like:
localize.js:86 Unable to translate Model committed
localize.js:86 Unable to translate Config Processor Run
localize.js:86 Unable to translate Ready Deployment
localize.js:86 Unable to translate Remove system from cobbler
localize.js:86 Unable to translate Remove server from known_hosts
localize.js:86 Unable to translate Rebuild monasca pretasks
localize.js:86 Unable to translate Performing OS configuration
localize.js:86 Unable to translate Running ardana-deploy

...

Also the main menu bar on the left in day 2 (service, topology, servers) seems to be in all lowercase, presumably because of this same problem.

@GarySmith I went through every page of the installer and day-2 cannot reproduce those messages that you saw. Was able to fix the localization of the items in the left menu in day-2.

I cleaned and rebuilt, and I'm still seeing those "Unable to translate" console warnings in the flow to replace a controller node.

OK, I see. You changed the interface so that it expects a string to translate rather than a translated string.

So you'll need to also modify all of the lines in ReplaceController.js that look like label: translate('somestring') to just label: 'somestring'

@GarySmith Changes addressing double translation have landed.

Works for me now

As Gloria noticed, the hot reload doesn't work for me, neither for javascript nor css. Worse yet, even cold reloading doesn't work on the less file.

For example, I changed all colors in palette.less to #888888 , and nothing changed, even after reloading the page. The only way to get the new colors (basically all gray) was to stop parcel and restart it.

@GarySmith All those scenarios work fine for me. here is my procedure when switching to this branch:
rm -rf node_modules/ yarn.lock package-lock.json; yarn; yarn start

if you don't have yarn installed:
rm -rf node_modules/ yarn.lock package-lock.json; npm install; npm run start

We might have been bit by the lock files.

I have marked this Do Not Merge unless and until all team members have migrated away from opensuse 42.3

I am using node 8.14.0 now ...rm -rf node_modules package-lock.json ...npm install.
The issue for me is :
It only hot load once per file. Modify any file ..1st time hot reload works, 2nd time , it stops working.
I seems to be particular in my environment :(. everyone else has no issues.

We can revisit in the future.


fix #31, update reveal to 3.6.0 and ace to 1.3.1

@servusoft Great work man ✋ I will roll out a new docker image today


fixes spark history server helm chart can't execute when ingress is enabled.

Signed-off-by: von1994<EMAIL_ADDRESS>What this PR does / why we need it:
fixes spark history server helm chart can't execute when ingress is enabled.
Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md

/lgtm


Regarding the issue of the cropping box following the rotation of the image

No matter how the image is rotated, we need to keep the cropping frame fixed to landscape mode. Is it possible to provide a method to prevent the cropping frame from rotating with the image?
Thanks

@HanX1ao
Please check PR #357 to see if it works for you.
To test the new feature, you need to set CropViewConfig.fixCropBoxWhenRotating90Degree = true

@guoyingtao it looks like fine

@HanX1ao
I rename fixCropBoxWhenRotating90Degree to rotateCropBoxFor90DegreeRotation, now you need to set CropViewConfig. rotateCropBoxFor90DegreeRotation to false for tests.
I just released Mantis 1.7.0 which includes this feature. Please let me know if it works for you.

@HanX1ao
I closed this ticket since the latest release includes this feature. You can reopen it if it does not work for you.


Images being cached from URLImages are too large

The images the app downloads are quite large. I've figured out a work around that can improve the app's performance by changing the UIImage instance by resizing it. That should improve the rendering process of the ScrollView.

Project images area cached and resized for better scrolling and offline use. Closing this issue.
Will be added to TestFlight 1.1(6)


Change setupAndRunAgent to use an explicit type instead of one based on NewRun

So that it is less likely that we'll accidentally add mandatory fields to setupAndRunAgent's request body and break existing clients. Right now, it's pretty easy because the request type is based on NewRun, the type used to insert rows into the runs_t table.

While we're at it, we could consider if there's a way to prevent this from happening on other endpoints, too.
Maybe we shouldn't allow arbitrary zod schemas as request body types, and instead only allow z.object({...}). We might be able to do that with the type system.
Or we could make it mandatory that all request fields are optional.


Capturing Output fails

When running a Plan, it fails to capture the output after a successful plan run. Not sure what can cause this, but it might be some characters that are not supported.
Might it be an option to make it tweakable to capture output or not? so the step is being skipped.
Error: Unable to process file command 'output' successfully.
Error: Invalid format 'tg_action_output=time=2023-07-25T09:45:43Z level=warning msg=No double-slash (//)
.... (rest of output)

Versions
  tf_version: 1.3.7
  tg_version: 0.43.2

Hi @stokkie90, please provide an example to reproduce.

Hi @stokkie90, please provide an example to reproduce.


[DAPHNE-#77] Avoid stack overflow in long-running DaphneDSL loops.

As described in #77, DaphneDSL loops with many iterations (e.g., >100k) crash DAPHNE.
The reason is that LowerToLLVMPass creates LLVM::AllocaOp in several places and for various purposes.
These AllocaOps could also be inside a loop, which means that the memory they allocate piles up until the stack is exhausted, because it is only freed at the end of the "scope" (function).
This commit solves the problem by ensuring that all AllocaOps created in LowerToLLVMPass are inserted at the beginning of the function surrounding the currently considered operation.
With that, there are no AllocaOps in loops anymore.
Note that the memory allocated by the AllocaOps can safely be reused by repeated kernel calls in different loop iterations.
Added script-level test cases employing loops with many iterations.
This bug has existed for a long time (partly because it wasn't a blocking issue until recently).

Thanks to @corepointer and @philipportner for investigating the causes (this fix is based upon their insights).
Thanks to @J-Brest and @borkob for providing a work-around for DAPHNE users.

Closes #77.

I think, in the future, we could even reduce the number of AllocaOps by making different kernel calls use the same memory slots for their result pointers. However, the most important goal for now is to get this bug fixed on main.

Awesome @pdamme
Will test it right away :+1:

I've been playing around with various memory profilers to test the issue and the solution. Stack usage looks quite normal with your changes applied. Also the explain_llvm output shows the improvements nicely. Thx for fixing this long standing bug at last @pdamme


Add me as reviewer, default ServiceMonitor to false

What this PR does / why we need it:
Not everyone uses Prometheus Operator
Special notes for your reviewer:
@integrii @lolimjake
Checklist

[x] DCO signed
[x] Variables are documented in the README.md

I'm going to hold off on version bump for when there's more features

/lgtm

/lgtm

Thanks Ian!


prevent accidental yolo merges

Description
There's now a github award called 'yolo' 'achieved' by merging an un-reviewed PR.
I often end up accidentally closing an issue and re-opening or other accidental actions that I can undo, however 'earning' this award will cause permanent damage to my account.
So I'd like for all of these possible merge buttons to be disabled, or put behind a "danger zone" box where I would need to type "earn yolo on ${username}"
Screenshot
No response
Example URLs
https://github.com/[\w-]+/[\w-]+b/pull/\d+

however 'earning' this award will cause permanent damage to my account.

I don’t think this is an issue that most people are concerned with, so I don’t think it belongs to Refined GitHub.
As for a generic "confirm to close", it has already been asked and rejected:

https://github.com/refined-github/refined-github/issues/5887
https://github.com/refined-github/refined-github/issues/3884

Good news! Achievements can now be hidden from your profile:
https://github.blog/changelog/2022-10-07-visibility-settings-for-individual-achievements/


suggestion for documentation

Apologies if I have placed this suggestion in the wrong spot.
Being new to much of this, I struggled mightily with the lowly console app on page 33 of the current documentation (7.9 Protecting an API)
There was not much to read on the page itself, and what I finally got to work after combing through multiple examples provided in the IdentityServer demos here (but none specifically referenced in the documentation!) is the below code, which is a fair bit more elaborate than what is provided in the documentation.
The documentation lead me to believe I could simply add a console project to my solution, add the IdentityModel NuGet package, slap in a few lines of code as shown on p.33-34, and be off to the races.
Unless I'm mistaken, this is not so.
If there were a link in the documentation that pointed specifically to a particular demo project, I would not be offering this suggestion. But I didn't see one. So the below code is cobbled together from what I found in the provided demos... but there are many of them, and it's not always obvious which to try first.
I am am wondering how, for the next user, this code that specifically fits the documentation can be made more accessible.
Also, I found (again, by studying one of the demos that worked) that the following must be in the console .csproj file:
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
   <LangVersion>latest</LangVersion>
 </PropertyGroup>

This below is what worked for me in the Program.cs file. (And yes, I also found myself pulling in that Constants project as well. (The one that has Constants, ConsoleExtensions, etc.)
using IdentityModel.Client;
using Newtonsoft.Json.Linq;
using System;
using System.Net.Http;
using System.Threading.Tasks;

namespace IdSvr
{
    public class Program
    {
        public static async Task Main()
        {
            Console.Title = "Console Client Credentials Flow";

            try
            {
                var response = await RequestTokenAsync();

                if (response.IsError)
                {
                    response.Error.ConsoleRed();
                    //return;
                }
                else
                {
                    "\n\nServer Token Received:".ConsoleGreen();
                    Console.WriteLine(response.Json);
                }

                await CallServiceAsync(response.AccessToken);

            }
            catch (Exception ex)
            {
                // oh well
                ex.ToString().ConsoleRed();
            }
            finally
            {
                "\n\nPress Any Key To Close Console...".ConsoleGreen();
                Console.ReadKey();
            }
        }

        static async Task<TokenResponse> RequestTokenAsync()
        {
            try
            {
                var disco = await DiscoveryClient.GetAsync(Constants.Authority);
                if (disco.IsError)
                    throw new Exception(disco.Error);

                var client = new TokenClient(
                    disco.TokenEndpoint,
                    "client",
                    "secret");

                return await client.RequestClientCredentialsAsync("api1");
            }
            catch (Exception ex)
            {
                // oh well
                //ex.ToString().ConsoleRed();
                throw ex;
            }
        }

        static async Task CallServiceAsync(string token)
        {
            try
            {

                var client = new HttpClient
                {
                    BaseAddress = new Uri(Constants.SampleApi)
                };

                client.SetBearerToken(token);
                var response = await client.GetAsync("identity");

                if (response.IsSuccessStatusCode)
                {
                    var content = await response.Content.ReadAsStringAsync();
                    "\n\nService claims:".ConsoleGreen();
                    Console.WriteLine(JArray.Parse(content));
                }
                else
                {
                    response.StatusCode.ToString().ConsoleRed();
                }
            }
            catch (Exception ex)
            {
                // oh well
                //ex.ToString().ConsoleRed();
                throw ex;
            }

        }
    }
}

Thanks for your feedback - writing docs is hard.
You have probably noticed the "Edit" button on the docs. Feel free to improve the docs yourself. Thanks!

Haha, I will try that out, but after you see the edits, you will certainly want to fix them up, as I will be dancing around the fact that I do not know what the csproj edits, for example, mean. Good documentation is hard. I appreciate all you have put into this project.


flutter_tester_test.dart sometimes times out

Log
06:35 +337 ~1 -1: test/integration/flutter_tester_test.dart: FlutterTesterDevice start [E]

Flutter Doctor
[✓] Flutter (Channel unknown, v0.3.6-pre.103, on Mac OS X 10.13.4 17E202, locale en-AU)
    • Flutter version 0.3.6-pre.103 at /Users/cbracken/src/flutter/flutter
    • Framework revision 0726af3ecc (58 minutes ago), 2018-05-03 14:26:44 -0700
    • Engine revision ae0d3a5536
    • Dart version 2.0.0-dev.52.0.flutter-2765fcf2ae

Dupe of #17133


Where pseudo class

Hello.
I couldn't find the :where() pseudo class in the webpage, I think that now it is relevant to include it
https://webkit.org/blog/10580/release-notes-for-safari-technology-preview-106/#:~:text=Added support for :where

Already on the site: https://caniuse.com/#feat=mdn-css_selectors_where


should rename account for 'EBUSY' on Windows?

along with EACCESS and EPERM errors, EBUSY can bubble up if a file is temporarily locked in windows (for example during AV scan or Dropbox sync).
rimraf treats them the same, shouldnt graceful-fs as well?

Unlink

This should be fixed now.


Parsing error cause app crash

Seems that value "light" (which was stored somewhere in cache by previous version app web app) didn't parse correct. It should not cause app crash. Better to handle it via try/catch and write correct value.

@s3rbug please have a look


Bug with permuting fft directions in athena_fft.cpp

Hello,
I believe there is a small bug in the fft implementation, which has a minor effect on the turbulence driver.
In the functions AthenaFFTIndex::SwapAxis, AthenaFFTIndex::PermuteAxis, AthenaFFTIndex::RemapAxis, the variable Nx is swapped (or permuted), but the variable Lx is not. The effect of this is that pfb->dkx[i] can be permuted with respect to what it should be (in a non-cubic box), depending on the exact layout of meshblocks and the number of processors. This can affect the turbulence driver.
I think this is easily fixed by adding Swap_(Lx,ref_axis); to the AthenaFFTIndex::SwapAxis function (and similarly for PermuteAxis and RemapAxis), as well as either making Real versions or templating the Swap_, Permute_ and RemapArray_ functions. But I'm not super familiar with the inner workings of the fft classes, so hope this doesn't break something else.
Thanks,
Jono

Thanks for reporting a potential bug. For now, I don't quite have time to look into the details. Before digging into the code, I'd like to ask you whether this actually was a problem. Did you see a real problem in your tests or applications? If so, what was a configuration you used (Lx, Nx, nx)? or do you think it can be a problem while you are reading the code?
The reason why I'm asking is that the whole purpose of such functions is to reduce global communications for transpose operations before and after the FFTs. So, they shouldn't be called if your domain decomposition is not really a pencil. This means that even in a non-cubic box, it will not be called if you have at least two meshblocks in each direction. I still think that your point is reasonable and I have to think it more carefully.  For now, if you are not intentionally use a pencil decomposition for 3D sims with a non-cubic box, you can simply use the 3D block decomposition with more than one meshbock in all directions.

Thanks for your contribution, @jonosquire! I will transfer this Issue to our development repository.


Delayed Jobs logging

In Delayed Jobs 4.0.6, I am noticing that logs are being added to ENV log (IE stage.log or production.log) rather then defaulting to delayed_jobs.log unless I setup an initializer.  I was wondering if this was intended and, if so, when the README.md will be updated to reflect this.
Thanks.

Log redirection only occurs if you are using bin/delayed_job. The rake task does not and has never redirected the loggers.

@albus522 Apologies for the miscommunication, but I am starting delayed_jobs with bin/delayed_job.

We have not changed anything. The logs are updated as part of https://github.com/collectiveidea/delayed_job/blob/master/lib/delayed/command.rb#L126
but if some other library update changed how the logs files are used then the log files may not be open when https://github.com/collectiveidea/delayed_job/blob/master/lib/delayed/command.rb#L116 is run and won't be updated by the after_fork

Thanks for the explanation.  I'll see what other library might be causing the problem.


Move gracc-apel to opensciencegrid/images (SOFTWARE-5054)

Could you also remove the .github subdirectory?


Highlight https://k8s.dev/ guides from most pages in website contributor guide

This is a Feature Request

What would you like to be added
Add a callout or banner to pages such as https://kubernetes.io/docs/contribute/participate/. The callout or banner should prominently signpost the existence of an equivalent page that's not just for SIG Docs.
Why is this needed
https://github.com/kubernetes/contributor-site/issues/167 - about localization for https://k8s.dev - (somewhat) blocks a wholesale migration of https://kubernetes.io/docs/contribute/ to within https://k8s.dev/
Nevertheless, people encounter https://kubernetes.io/docs/contribute/ and then don't spot the links to https://k8s.dev/
Let's put those links on every page in the section, or nearly every page. I'd use a shortcode for this.
Comments
/language en
/sig contributor-experience
As part of adding the extra prominent banner(s) / alerts / callout, we should drop the existing callouts that aim to achieve the same thing.

/triage accepted

/remove-lifecycle rotten

/remove-lifecycle rotten
/lifecycle stale


186 DeathsPerHospitalized renamed in DeathsPerICU

Merge Request - GuideLine Checklist
Guideline to check code before resolve WIP and approval, respectively.
As many checkboxes as possible should be ticked.
Checks by code author:

[x] There is at least one issue associated with the pull request.
[x] The branch follows the naming conventions as defined in the git workflow.
[x] New code adheres with the coding guidelines
[ ] Tests for new functionality has been added
[ ] A local test was succesful
[ ] There is appropriate documentation of your work. (use doxygen style comments)
[ ] If new third party software is used, did you pay attention to its license? Please remember to add it to the wiki after successful merging.
[ ] If new mathematical methods or epidemiological terms are used, has the glossary been updated ? Did you provide further documentation ?
is present or referenced. Please provide your references.
[ ] The following questions are addressed in the documentation*:  Developers (what did you do?, how can it be maintained?), For users (how to use your work?), For admins (how to install and configure your work?)
For documentation: Please write or update the Readme in the current working directory!

Checks by code reviewer(s):

[ ] Is the code clean of development artifacts e.g., unnecessary comments, prints, ...
[ ] The ticket goals for each associated issue are reached or problems are clearly addressed (i.e., a new issue was introduced).
[ ] There are appropriate unit tests and they pass.
[ ] The git history is clean and linearized for the merge request.
[ ] Coverage report for new code is acceptable.

Closes #186

Codecov Report

Merging #188 (947be4d) into main (2e1c6c3) will decrease coverage by 0.41%.
The diff coverage is 82.67%.

@@            Coverage Diff             @@
##             main     #188      +/-   ##
==========================================
- Coverage   91.70%   91.29%   -0.42%
==========================================
  Files          76       76
  Lines        4653     4697      +44
==========================================
+ Hits         4267     4288      +21
- Misses        386      409      +23

Impacted Files
Coverage Δ

cpp/models/secir/secir_params.h
73.57% <63.90%> (-6.24%)
:arrow_down:

cpp/models/secir/analyze_result.h
100.00% <100.00%> (ø)

cpp/models/secir/implicit_euler.cpp
100.00% <100.00%> (ø)

cpp/models/secir/parameter_space.cpp
100.00% <100.00%> (ø)

cpp/models/secir/secir.h
99.31% <100.00%> (-0.02%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e1c6c3...947be4d. Read the comment docs.


Questions for Jeanne

An applicant can request a property that the City of Chicago does not own. Do you want a view to explicitly check for this?

Should a "bulk deny" send automated emails?

These are answered.


feat: increase dashboard name limit from 40 characters to 100 characters

Description
Dashboard name should have a limit of 100 characters instead of 40. Added some documentation for generating types and finding local cognito credentials.
Fixes https://app.asana.com/0/1203518413061418/1204350041304188/f
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[x] Updated tests for dashboard name in core
[x] Updated tests for dashboard description in core
[x] Updated create dashboard tests in client

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

Legal
This project is available under the Apache 2.0 License.

@boweihan Playwright is expected to fail, but it looks like you have some linting issue?

@tracy-french oops, my prettier plugin didn't like these files :) - should be fixed


How can I resent verify email

Kitematic(Beta) for Mac.
Login is ok, but when I try to create a container, it tells me:
Error: Status 403 trying to pull repository library/mongo: "Account is not Active"
I noticed there is a "I've Verified My Email Address" item in the account menu, but it does nothing.
My question is how to resent a verify email?

My mistake, noticed kitematic is using docker hub account. It's ok now.


Getting Started translated into Russian

Closes #10355

please get someone else in one of the Russian chat rooms to peer review this, thanks :+1:

@atjonathan hopefully someone will review this soon

I've looked at the translation and everything looks right to me.

Merging. If someone else finds a spelling mistake, they can open a new issue or pull request :+1:
Thanks @rfprod :tada:


Automatic update of sub-repo for templating

#86
#83

https://github.com/marketplace/actions/push-directory-to-another-repository

Requires secrets. I'll do it.


[CodeClean/Handle] internal struct for handle

Code clean, move definition for internal data struct and cleanup headers.
Signed-off-by: Jaeyun<EMAIL_ADDRESS>

:memo: TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #140. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/.


refactor(core): node watcher

Description:

BREAKING CHANGE:

Related issue (if exists):

The new wacher should work with newServer instead of the existing server

I see. Before it was because I saw that the code in core's index.ts wasn't completely implemented (especially start2 confused me a bit), then I'll rewrite that part of the code next.


Release v0.3.0

Release Notes
Another day, another release. These are the release notes for the version v0.3.0.
Features

feat(api): implement account information endpoint (#349) (Salim Afiune)(1392ecb)

Other Changes

chore: ran make prepare (Salim Afiune Maya)(662b220)
ci: fix prepare-test-resources job (#348) (Darren)(a071c04)
ci: open release pull request automatically (Salim Afiune Maya)(f227182)
ci: automatic minor version bump (Salim Afiune Maya)(73e2cb9)
test: change target for container vuln scanning (#343) (Darren)(c348b01)

Docker Images

docker pull lacework/lacework-cli:latest
docker pull lacework/lacework-cli:scratch
docker pull lacework/lacework-cli:ubi-8
docker pull lacework/lacework-cli:centos-8
docker pull lacework/lacework-cli:debian-10
docker pull lacework/lacework-cli:ubuntu-1804
docker pull lacework/lacework-cli:amazonlinux-2

We will come back to this latter in this week! 😉


Move ListEventSessionFilter to impl

🆕🐥:dog: First Timers Only
This issue is reserved for people who never contributed to Open Source before. We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝
:space_invader: Description of the issue
The functionality of this filter can be created by using the EventSessionFilterFactory that is part of the public API. The ListEventSessionFilter should be moved to the private API.
📋 Step by Step

🙋 Claim this issue: Comment below.
🔄 replace the up for grabs label with in progress.
:fork_and_knife: fork the repository in github by simply clicking the 'fork' button.
:arrow_heading_down: check out the forked repository
:twisted_rightwards_arrows: create a feature branch for the issue. We do not have any naming definition for branches.
💾 Commit your changes.
🔀 Start a Pull Request.
🏁 Done 👍 Ask in comments for a review :)
🔬 If the reviewer find some missing peaces or a problem he will start a discussion with you and describe the next steps how the problem can be solved.
:boom: you did it! We will merge the fix in the master of the Dolphin Platform project.
:bouquet: Thanks, thanks, thanks for being part as an open source contributor for Dolphin Platform

🤔❓ Questions
You can join our community chat at Slack

Hey i'd like to claim this issue if that's alright! is this process just moving the file from one folder to another or is it moving the functionality? Thanks!

Hi @BadJukeBox
the functionally is already wrapped in the EventSessionFilterFactory class. Based on this the class must only be moved to another package (the private API).


Control Side line UI

Feature description
As a client I would like to have ability to control colours and look of side bar of folds.

Background (In case if I would like to make it transparent)
Show / Hide side bar of folds
Show or Hide fold level of side bar
Change icons of side bar

Side bar:

Describe the solution you'd like
Create separate configuration object for UI: eg change higlights, and other ui configuration for flexibility
Additional context
No response

There're some limitations to the UI.
https://github.com/kevinhwang91/nvim-ufo/issues/4
This feature is the closest to what you want, ufo should make sure the regression of perf is acceptable for customized UI components, need a lot of time to explore.
https://github.com/kevinhwang91/nvim-ufo/issues/24


TextView GestureListener

I'm struggling a bit to get this to work as expected with a dynamically created TextView (or any View other than the ImageView). For the 'move' detector, the TextView appears to be 'lagging' behind my finger. Two finger gestures cause the view to 'split' in two until I let go of one of the fingers.
Any help on figuring this out would be much appreciated. (I've also tried using Matrix transformations with the TextView by overriding OnDraw, but had little luck with that as well).
Here's the modification from the Sample (View instantiation not shown):
public boolean onTouch(View v, MotionEvent event)
    {
        mScaleDetector.onTouchEvent(event);
        mRotateDetector.onTouchEvent(event);
        mMoveDetector.onTouchEvent(event);
        mShoveDetector.onTouchEvent(event);

        float scaledViewCenterX = (_originalWidth * mScaleFactor)/2;
        float scaledViewCenterY = (_originalHeight * mScaleFactor) /2;

        // also attempted to translate with the difference to no avail
        //float diffX = mFocusX - scaledViewCenterX;
        //float diffY = mFocusY - scaledViewCenterY;
        //v.setTranslationX(diffX*mScaleFactor);
        //v.setTranslationY(diffY*mScaleFactor);

        // Scale : Splits view in two. Jitters
        v.setScaleX(mScaleFactor);
        v.setScaleY(mScaleFactor);

        // Translate : Lags behind finger. Jitters
        v.setX(mFocusX);
        v.setY(mFocusY);

        // Set pivot joint
        v.setPivotX(scaledViewCenterX);
        v.setPivotY(scaledViewCenterY);

        // Rotate : Splits view in two. Jitters
        v.setRotation(mRotationDegrees);
}

I'm sorry, this looks like it is out of scope for the library itself and therefor not an issue that should be fixed in the library. Perhaps you can ask on stackoverflow?


Allow any number of Wastes in decks

Wastes are basic lands, so decks can run any number of them.

Thanks!  Sorry for taking so long to merge, my newest kid was born on the day you submitted.  :)

Haha, not a problem. Certainly no rush from me. :)


"editor.formatOnSaveMode": "modifications" not working as expected

VSCode Version: 1.49.2 (user setup)
OS Version: Windows 10 64-bit (build 10.0.19041)

Steps to Reproduce:

Ensure settings.json has this:

    "editor.formatOnSaveMode": "modifications",
    "[javascript]": {
        "editor.formatOnPaste": true,
        "editor.formatOnSave": true
    }

Open the attached JS file in the zip: test.zip
Change line 3 to: function component(){

Since I modified line 3, I was expecting it to format line 3 to function component() { on save.

Does this issue occur when all extensions are disabled?: Yes

What formatter extension are you using? Default or something like prettier?

I don't have any formatters installed -- using default.
On Fri, Oct 2, 2020, 12:23 AM Johannes Rieken<EMAIL_ADDRESS>wrote:

What formatter extension are you using? Default or something like prettier?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/vscode/issues/107940#issuecomment-702571989,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA7LRZ5J5W7NLJJJDUFIDQ3SIV5YNANCNFSM4SBCQEIQ
.

Please try the follow: manually select the modified text in the editor and then execute "format selection"

Please try the follow: manually select the modified text in the editor and then execute "format selection"

This worked -- the selection was formatted correctly.
If I remove "editor.formatOnSaveMode": "modifications" and save, the code is also formatted correctly.
For your reference, here is my full settings.json:
{
    "breadcrumbs.enabled": true,
    "css.lint.ieHack": "warning",
    "editor.acceptSuggestionOnEnter": "off",
    "editor.autoClosingBrackets": "never",
    "editor.autoClosingQuotes": "never",
    "editor.codeLens": false,
    "editor.comments.insertSpace": false,
    "editor.dragAndDrop": false,
    "editor.find.autoFindInSelection": "multiline",
    "editor.find.cursorMoveOnType": false,
    "editor.formatOnSaveMode": "modifications",
    "editor.hover.enabled": false,
    "editor.minimap.enabled": false,
    "editor.multiCursorModifier": "ctrlCmd",
    "editor.renameOnType": true,
    "editor.renderLineHighlight": "gutter",
    "editor.snippetSuggestions": "top",
    "editor.unusualLineTerminators": "auto",
    "explorer.confirmDelete": false,
    "files.exclude": {
        "**/__pycache__": true,
        "**/.vscode": true
    },
    "files.restoreUndoStack": false,
    "files.trimFinalNewlines": true,
    "files.trimTrailingWhitespace": true,
    "git.enableSmartCommit": true,
    "html.format.wrapLineLength": 0,
    "javascript.format.insertSpaceAfterFunctionKeywordForAnonymousFunctions": false,
    "javascript.preferences.quoteStyle": "single",
    "javascript.updateImportsOnFileMove.enabled": "always",
    "python.linting.enabled": true,
    "python.linting.pylintEnabled": true,
    "python.pythonPath": "C:\\dev\\Miniconda3",
    "search.searchEditor.reusePriorSearchConfiguration": true,
    "sortLines.sortEntireFile": true,
    "task.problemMatchers.neverPrompt": {
        "shell": true
    },
    "telemetry.enableCrashReporter": false,
    "telemetry.enableTelemetry": false,
    "terminal.integrated.fontSize": 12,
    "terminal.integrated.shell.windows": "C:\\Windows\\System32\\cmd.exe",
    "workbench.colorCustomizations": {
        "editor.selectionBackground": "#135564",
        "editor.selectionHighlightBackground": "#135564"
    },
    "workbench.editor.highlightModifiedTabs": true,
    "workbench.enableExperiments": false,
    "[javascript]": {
        "editor.formatOnPaste": true,
        "editor.formatOnSave": true
    }
}

Is it possible one of the settings is the culprit?

This worked -- the selection was formatted correctly.

That's funny. Format modified does exactly that - it takes the modified (line) range and formats that, using the same mechanics as format selection

This worked -- the selection was formatted correctly.

That's funny. Format modified does exactly that - it takes the modified (line) range and formats that, using the same mechanics as format selection

That's why I'm baffled. Can you see if you can replicate using my settings above and the test file?

Is the file in source control? Do you see the change indicator bar alongside the line you modified?

The file is not in source control.
On Sat, Oct 3, 2020, 12:39 AM John Murray<EMAIL_ADDRESS>wrote:

Is the file in source control? Do you see the change indicator bar
alongside the line you modified?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/vscode/issues/107940#issuecomment-703062409,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA7LRZ5NTVYF2AC6VHBYK23SI3IMNANCNFSM4SBCQEIQ
.

That's the reason then. See documentation for this feature at https://code.visualstudio.com/updates/v1_49#_only-format-modified-text

@gjsjohnmurray ah that explains it -- thanks! I don't know the innerworkings of VS Code, but would it be possible to have this useful feature for files that are not in source control?
If not, then do you know if there's a way for me to automatically set "editor.formatOnSaveMode": "file" for files that are no source controlled?

My file is source controlled and I have the same issue

Shall I open a new issue?

Yes - after having tried "format selection" on same range


Stringer : runtime: goroutine stack exceeds<PHONE_NUMBER>-byte limit

Hello,
I want to use go-spew into String() string.

Thx

That causes infinite recursion in the exact same way as the following would:
type Example struct {
    foo string
}

func (e Example) String() string {
  return fmt.Sprintf("%v", e)
}

I'd recommend not using spew in a stringer like this.  The elegant way to handle it is to simply move the call to spew outside of the stringer to the caller like so:
package main

import "github.com/davecgh/go-spew/spew"

type Example struct {
	foo string
}

func main() {
	e := Example{"foostring"}
	spew.Printf("%+v\n", e)
}

Output:

{foo:foostring}

ok, thx again for this confirmation

I know this is a user error and should not be supported by spew, but I wonder if it's possible and a good idea for spew to detect when it's indirectly calling itself a second time, and print a more helpful error message?
Or is the overhead of doing that too much (in terms of code to maintain and run-time performance) to outweigh the benefit?

@shurcooL: That's not a bad idea, but I'm really not sure if that could be done without having undesirable side effects.
spew does detect recursion within in a single call by keeping track of the pointers in a local map that is part of the instance, but the issue here is it's effectively calling the upper-level print routine over and over.
Adding some type of global tracking to detect this would mean that code such as the following wouldn't work:
e := &Example{"foostring"}
spew.Println(foo)
e.foo = "Something new"
spew.Println(foo)   //  <---  spew would now filter this because it would be in the global already printed map

I don't have it completely thought out, it was just a thought.
I was imagining something that would look at the stack trace whenever a top-level spew function is called, to check that it's not being called a second time (from spew).

I wonder if it's possible and a good idea for spew to detect when it's indirectly calling itself a second time, and print a more helpful error message?

If this modification is possible, is it applicable to print directly the structure as spew usually rather than to display this helpful error message?
Or let to user by configuration the choice to display helpful error or print the structure directly without error.


[FEATURE] Add .dockerignore file

Detailed description
Adding a .dockerignore file and ignoring the files which don't play role in building the image will reduce the build size.
Context
Fast development and testing

[X] I agree to follow this project's Code of Conduct

I would like to work on this issue. Thank you.

Hi sure i'll assign you, Pradumna. ✨

Thank you!


Pass caller identity from API GW to execute lambda

I'm using temporary credentials from cognito to call API gateway:
var apigClient = apigClientFactory.newClient(
{
accessKey: AWS.config.credentials.accessKeyId,
secretKey: AWS.config.credentials.secretAccessKey,
sessionToken: AWS.config.credentials.sessionToken,
region: AWS.config.region
}
);
Is it possible to forward these credentials from API GW to Lambda?
I see the option "Invoke with caller credentials" in the console, but after using serverless-cors-plugin to update my API, this option is always disabled. So I guess there is a parameter for this?
When I manually check "Invoke with caller credentials" in the console after all CORS were correct, I think the function messes up the CORS settings because then I get "No 'Access-Control-Allow-Origin' header is present on the requested resource.".
I tried with "allowCredentials": true, but does not seem to work.

@brainframe-me the plugin should only modify the following:

It adds some CORS response headers to each endpoint response, but it preserves existing headers.
It adds OPTIONS endpoints for preflighted requests. These are MOCK endpoint so they should not call a Lambda.

I'm not sure if your issue is related to the plugin, since it does not touch one of the above. It could however be related to https://github.com/joostfarla/serverless-cors-plugin/issues/2.
Are you still experiencing this issue?

No thanks

@brainframe-me where you ever able to get this property set in serverless?

I didn and if I remember well it was part of the s-function.json. But I'm not sure, and it is a bit to far away at the moment. This is how the relevant part of my s-funciton looked:
beginning of the file omitted
"endpoints": [
{
"path": "auth/{operation}",
"method": "POST",
"type": "AWS",
"authorizationType": "none",
"apiKeyRequired": false,
"requestParameters": {},
"requestTemplates": {
"application/json": {
"operation": "$input.params('operation')",
"authorization": "$input.params().header.get('Authorization')",
"payload": "$input.json('$')",
"identity": "$context.authorizer.princialId"
}
},
"responses": {
"Bad Request.": {
"statusCode": "400"
},
"Unauthorized.": {
"statusCode": "401"
},
"Not Found.": {
"statusCode": "404"
},
"Conflict.": {
"statusCode": "409"
},
"default": {
"statusCode": "200",
"responseParameters": {},
"responseModels": {
"application/json": "Empty"
},
"responseTemplates": {
"application/json": ""
}
}
}
},
{
"path": "auth/{operation}",
"method": "OPTIONS",
"type": "MOCK",
"requestTemplates": {
"application/json": "{"statusCode": 200}"
},
"responses": {
"default": {
"statusCode": "200",
"responseParameters": {
"method.response.header.Access-Control-Allow-Headers": "'Content-Type,X-Amz-Date,Authorization,X-Api-Key,Cache-Control'",
"method.response.header.Access-Control-Allow-Methods": "''",
"method.response.header.Access-Control-Allow-Origin": "''"
},
"responseModels": {},
"responseTemplates": {
"application/json": ""
}
}
}
}
],
rest of the file omitted
And I think it is passed somewhere with "authorization": "$input.params().header.get('Authorization')", OR "identity": "$context.authorizer.princialId", but I'm not sure anymore.
Your handler can then look a bit like this;
function createJWT(userId, expiresIn) {
var exp;
if (config.EXPIRES_IN) {
exp = moment().add(config.EXPIRES_IN, 'seconds');
}
else if (expiresIn) {
exp = moment().add(expiresIn, 'seconds');
}
else {
exp = moment().add(14, 'days');
}
console.log('createJWT exp', exp.format());
var payload = {
    sub: userId,
    iat: moment().unix(),
    exp: exp.unix(),
};
console.log('createJWT payload', payload);

return jwt.encode(payload, config.TOKEN_SECRET);

}
module.exports.handler = function (event, context) {
var tokenCallback = function (err, data) {
if (err) {
context.fail(makeError(err));
}
else {
context.succeed({token: createJWT(data.id)});
}
};
function checkAuthenticated(callback) {
var authorization = event.authorization;
delete event.authorization;
    var t = checkJWT(authorization);
    if (t.message) {
        callback('SecurityGroup:Public');
    }
    else {
        callback(t);
    }
}

var ensureAuthenticated = function (callback) {
var authorization = event.authorization;
delete event.authorization;
    var t = checkJWT(authorization);
    if (t.message) {
        context.fail(new Error('Unauthorized: ' + t.message));
    }
    else {
        callback(t);
    }
};

Main program:
checkAuthenticated(function (userId) {
 #do something with either public or userId
}

#Or

ensureAuthenticated(function (userId) {
 #only continues if you were authenticated
}

}
Definitely not the best code, but I finally got it working.
Hope it works for you. If not I won't be able to help any further, sorry...


Fail on train-ticket

System fails to analyze train-ticket.
Request:
{
	"repositories": [
		{
			"path": "https://github.com/FudanSELab/train-ticket",
			"isMonolith": false
		}
	],
	"systemName" : "tms"
}

Received response:
{
    "global": null,
    "ms": null
}

Expected response:
Not null.

Log from the app:
Cloning https://github.com/cloudhubs/train-ticket into repos-1587775012/train-ticket
Completed Cloning
Failed to process project!

I am unable to replicate this error. Does it still happen with the latest 0.0.8-dev versions of utils-app, utils, and dto?

Resolved, should no longer return nulls for anything unless an error is indicated (no Java, can't clone, etc.)


Incorrect Documentation on DataModules

The current documentation on Datamodules link appears to be incorrect.
The initial MNIST example in the "What is a DataModule" section places the transforms under setup and feed them as arguments to the dataset constructor.
However, in the "LightningDataModule API" documentation, all the {train,val,test}_dataloader examples create a transform and feed it into a DataLoader. This is incorrect, since PyTorch's DataLoader does not take any transform argument.
More generally, it seems that the {train,val,test}_dataloader API examples suggest that LightingDataModules can deal with different transformations for all these three sets but there isn't a correct example for doing so and making it work that way seems a bit cumbersome with the current torchvision VisionDataset API that takes transforms on Dataset creation.

I agree that in the case of the dataloader, the transform is misplaced. The MNIST dataset however takes transforms, that should be correct, yes?
Would you like to send a PR with suggested doc fixes?
I'm removing the bug label, as I understand it's just documentation.

I could send a PR fixing the {train,val,test}_dataloader examples but then they would be trivial (i.e. just calling and returning the DataLoader.
However, the current docs seem to have a goal in mind to "decouple your data from transforms" (quoting directly from the docs). So ideally, the docs should provide examples on how to do that. This seems not trivial from the current LightningDataModule API. A potential fix would be to construct separate MNIST datasets for train, val and test and carefully Subset the train and val to ensure there is no common intersection.
However, I was thinking whether some part of that logic could be offloaded to PyTorch Lightning itself.
Let me know your thoughts


Add toggleable theme button and ability to swap between compacted and expanded PersonCards

Fixes #118 and fixes #119.
Added 2 new buttons under the Appearance tab and removed Theme tab.

Button that toggles between light theme and dark theme
Button that toggles between compacted and expanded PersonCards. If in compact mode, all cards are by default in their compact mode and vice versa.

Codecov Report
Base: 68.12% // Head: 67.66% // Decreases project coverage by -0.46% :warning:

Coverage data is based on head (8283f5c) compared to base (95f4ea0).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #120      +/-   ##
============================================
- Coverage     68.12%   67.66%   -0.47%
  Complexity      514      514
============================================
  Files            84       84
  Lines          1732     1744      +12
  Branches        208      205       -3
============================================
  Hits           1180     1180
- Misses          463      475      +12
  Partials         89       89

Impacted Files
Coverage Δ

src/main/java/seedu/address/ui/HelpWindow.java
0.00% <0.00%> (ø)

src/main/java/seedu/address/ui/MainWindow.java
0.00% <0.00%> (ø)

src/main/java/seedu/address/ui/PersonCard.java
0.00% <0.00%> (ø)

...rc/main/java/seedu/address/ui/PersonListPanel.java
0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Missing "Create new page icon" from sidebar

The sidebar does not show the "create new page" icon and action at the bottom of the sidebar.
Env: macOS Monterey (12.4)

Again, purposefully removed. To make it visible before I add customization options, edit line 380 of custom.css

Ok nice. I see where you are going.
Will change my workflow to create a new page from the Search dialog.


Switch to GitHub Actions

Given Travis's push away from open source, I'm moving things over to GitHub actions

It works, so I'll go ahead and merge this in!


Fix/abis handle contracts 08

Handles the new contracts folder (build/contracts, build/contracts-08, build/contracts-mento) in a nicer way. Refactors the published package to support both esm and commonjs modules.
This PR also changes the published abis to be ONLY core contracts as it's what devs will want to interact with, and not random internal abis (eg: Math.json)

sorry i want to release packages before making big update to master


[ FIX ]  enable controller in SLOT env

Changes

[x] set rpc propery to work controller in slot as well
[x] fix interaction problem

@0xshora
NOTE:
Somehow provider.excute() function is so snsitive about the params order we passes, and when I pass the defaultParams incorrect order, it parse the color to 0, and inside contract, fade() called instead of pu_color(), that's why we cannot paint any pixels by newer systems calls but now fixed. and please be carefull about params order


Use inflection to produce tablenames

It would be nice if you used the inflection library to generate table names instead of your own regex.
There is already a function called 'tableize' in the inflection package that converts to snake_case and pluralizes the table name.
In any case, it would be nice to be able to either control behavior of the automatic table name generation or override it

I'm aware of the library but do not plan to add an external dependency.  We do plan on addressing this.  Duplicate of #406.


[MB-3557] SupportAPI: Unneeded ReferenceID on creation of move task order

Description
Removes test checking for ReferenceID that is not used since it is automatically generated
Setup
make server_test
Code Review Verification Steps

[ ] Request review from a member of a different team.
[ ] Have the Jira acceptance criteria been met for this change?

References

Jira story for this change

Should we add readOnly: true to the other places referenceID is defined in prime.yaml and ghc.yaml?

After looking at this more closely, I can understand why that test was added. It's because the post endpoint is referencing the same MoveTaskOrder definition that is reused in the GET request as well. And even though we want to return the referenceID in GET requests, we don't want to allow passing it in when creating a Move, so we set it to readOnly: true. However, it looks like Swagger doesn't enforce that. On line 51 of /pkg/services/support/move_task_order/move_task_order_creator.go, I added this line:
fmt.Println("payload.ReferenceID:", payload.ReferenceID)

and then ran the test that you deleted in this PR, and I can see "some terrible reference id" that was passed in the Payload.
So, what we're really testing here is that the InternalCreateMoveTaskOrder ignores the reference ID in the payload
I am surprised that readOnly: true doesn't do anything. Did we think that it did?
In general, I prefer to be explicit in the swagger definitions, and instead of reusing Model definitions, I would rather duplicate some items but make it clear which fields can be passed in. But that's beyond the scope of this PR.
So, for now, maybe we should keep the test?
Pinging @shimonacarvalho who last touched this test.

Yeah, it looks like this test was added because we were actually using the reference ID from the payload instead of generating it ourselves. Here's the PR Shimona opened about 3 months ago: https://github.com/transcom/mymove/pull/5939/files
I think Shimona updated this test after I wrote the original JIRA ticket. The way the test was originally written, it seemed like we didn't need it, but now that it's testing something that was broken, it seems valid.
Having said that, we don't have similar tests for other read-only fields, like the Move Locator. I think it's easier to test fields that are not allowed by specifying a specific set of allowed fields only, and then if we try to pass in something that's not allowed in the Body, then we can use the Body validation and expect that it returns an error:
suite.NoError(params.Body.Validate(strfmt.Default))

@monfresh I think intuitively the expectation was that readOnly would give some sort of validation error. You're right though in that in other tests we aren't really testing fields that are provided but never used. I can see it going either way

It turns out it was a bug in go-swagger, which has since been fixed I think 6 months ago, but we're still on an older version. Hopefully, we'll upgrade soon and we should be able to see an error now.


Post Processing implementation for Wrappers.

We've been testing out the D435 and have notices quite a noisy feed from the depth. Based on similar issues, it's recommended to use the post processing filters to smooth the results.
Are these filters available via the Unity wrapper?

Will be added to the example scene. All the required components are already exposed in the C# wrapper, so this should not be much different from Align. However, there are couple pressing bugs we are trying to address in the Unity wrapper before we can handle this.

Added to 2.14.1

[Realsense Customer Engineering Team Comment]
hi @marklundin,
since 2.14.1 alread released, let me close this ticket here, and if any question, please open new ticket.