Adopting resources into a new release leads to unexpected merge behaviour

Output of helm version: version.BuildInfo{Version:"v3.6.3", GitCommit:"d506314abfb5d21419df8c7e7e68012379db2354", GitTreeState:"clean", GoVersion:"go1.16.5"}
Output of kubectl version: Client Version: version.Info{Major:"1", Minor:"19", GitVersion:"v1.19.1", GitCommit:"206bcadf021e76c27513500ca24182692aabd17e", GitTreeState:"clean", BuildDate:"2020-09-09T11:26:42Z", GoVersion:"go1.15", Compiler:"gc", Platform:"linux/amd64"}
Cloud Provider/Platform (AKS, GKE, Minikube etc.): Reproducable on AKS and GKE
I am trying to make the following use case successful. It is to move objects from one old helm release to another new helm release, followed by subsequent upgrades of that new helm release. I have been using the feature outline on the following page.
https://github.com/helm/helm/pull/7649
This feature involves annotating and labelling objects that you wish to 'move' to a new helm release.
    metadata:       annotations:         meta.helm.sh/release-name: <release>         meta.helm.sh/release-namespace: <namespace>       labels:         app.kubernetes.io/managed-by: Helm
This feature allows me to do the following

Install an old helm chart, into an old helm release (release1)
Annotate/label some of the objects that are in that release, with the name of a new / target release (release2)
Perform a helm install of the new target chart into the new / target (release2) and see it not throw errors that the objects exist.

This does work. However I have spotted one issue, that is causing this to not work on certain objects. I noticed an issue when running through these steps on a deployment, whos container had changed its liveness probe from using a httpGet to using a exec. Only one of these can be used at any time, so this is expected to work. In the old chart/helm release, its using httpGet. In the new chart / release its using exec. However after running through this upgrade procedure, helm is somehow leaving both httpGet and the exec blocks in the resulting object.
To me this is not desirable, as I want whatever is in the new/target chart to be exactly reflected in the cluster, not some merge of the old and new manifests. Other users seemed to have noticed this issue, for example on this comment.
https://github.com/helm/helm/issues/6561#issuecomment-687382740
I have reproduced this with a very small example. If we create two charts, the old chart and the new chart.
Within the old chart, put a small Service object like below.
apiVersion: v1 kind: Service metadata:   name: myservice   labels:     labela: a spec:   ports:     - port: 80       targetPort: http       protocol: TCP       name: http   selector:     a: b
helm install that chart into a namespace, giving it a release name of release1.
Now prepare the second helm chart, with the very same Service object, however change the label from labela, to labelb as follows.
apiVersion: v1 kind: Service metadata:   name: myservice   labels:     labelb: b spec:   ports:     - port: 80       targetPort: http       protocol: TCP       name: http   selector:     a: b
Now annotate and label the existing Service within the cluster to indicate its going to be part of release2.
Perform a helm install of the new / target chart into release2.
The upgrade will be successful however both labela an labelb will be present. I assume this is not intended as it will of course corrupt many objects in the process. In my case any objects that decided to change liveness probes for example, from using httpGet, to using 'exec', will now have both, and fail to upgrade because of this.
Is this a bug or expected behavior? Any suggestions to get around it are very welcome.

Hey @jlegrone. You might be best placed to provide some feedback on this?

I will set to a bug in the meantime.

@marcosdiez I think #2730 is the issue for that functionality.

Closing in favour of #2730. That issue encompasses any discussion around introducing resource adoption as a helper command.
At this time, adopting existing resources into a release is not a workflow we support.


[GLUTEN-4350][CH] Improve NativeReader's performance for small blocks

What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
Fixes: #4350
After this modification.

How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
unit tests
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

Notice that when parse aggregate data, there are a lot of virtual function call to initialize an aggregate data place. Reduce these virtual function call should bring some improvement.
Run a test on this.
static void readFixedSizeAggregateData(DB::ReadBuffer &in, DB::ColumnPtr & column, size_t rows, NativeReader::ColumnParseUtil & column_parse_util)
{
    ColumnAggregateFunction & real_column = typeid_cast<ColumnAggregateFunction &>(*column->assumeMutable());
    auto & arena = real_column.createOrGetArena();
    ColumnAggregateFunction::Container & vec = real_column.getData();
    size_t initial_size = vec.size();
    vec.reserve(initial_size + rows);
    #if 0
    for (size_t i = 0; i < rows; ++i)
    {
        AggregateDataPtr place = arena.alignedAlloc(column_parse_util.aggregate_state_size, column_parse_util.aggregate_state_align);
        column_parse_util.aggregate_function->create(place);
        auto n = in.read(place, column_parse_util.aggregate_state_size);
        chassert(n == column_parse_util.aggregate_state_size);
        vec.push_back(place);
    }
    #else
    AggregateDataPtr places = arena.alignedAlloc(column_parse_util.aggregate_state_align_size * rows, column_parse_util.aggregate_state_align);
    column_parse_util.aggregate_function->createPlaces(places, rows, column_parse_util.aggregate_state_align_size);
    for (size_t i = 0; i < rows; ++i)
    {
        auto n = in.read(places, column_parse_util.aggregate_state_size);
        chassert(n == column_parse_util.aggregate_state_size);
        places += column_parse_util.aggregate_state_align_size;
        vec.push_back(places);
    }
    #endif
}

Got result


Does not work with javascript disabled

Edit: I'm talking about the example

Its a javascript library that works on the client... How could one be so obtuse?

What if someone disables javascript?

@FliegendeWurst noscript is your friend...

I think that this is an important point to make — it’s not just a JavaScript library, it’s a custom HTML element, that without JavaScript, has none of the associated behaviours of a standard  element - e.g. alt attributes.
The Readme suggests you should just use  elements in your HTML instead of  elements, then just let the JavaScript do its job, but doesn’t mention any kind of progressive enhancement methods (like noscript tags) for those users with JavaScript disabled. It would be nice to see this covered in the Readme.

It's JS lib. If you have knowledge to use stuff like that, you probably know that, if JavaScript is disabled, you must use <noscript></noscript>.
We're talking about the obvious here.

And that shows the importance of providing context and submitting a proper bug report.
Although I think it should be obvious to any developer working with a JS library on custom elements - it wouldn't hurt to add a <noscript> fallback to the examples.

Thank you all for your comments. I think the README should be updated to provides some information regarding this and also suggest the noscript approach. However, I would like to tackle this problem using customized built-in elements instead of the autonomous custom elements it currently uses as this would allow img-2 to basically fallback to a standard img element as a progressive enhancement 👍


A couple bugs related to Shape

Running df (v 3.0) |> DT.Eval (or similar) from dsl-live.fsx results in an error:
Cannot compute the partial derivative for node 'BroadcastTo' as it's unreachable from the output node(s).
As far as I can tell, this occurs only when evaluating scalar -> scalar derivatives. I've been able to narrow the error down to: https://github.com/fsprojects/TensorFlow.FSharp/blob/master/src/TensorFlow.FSharp/dsl.fs#L929

This tf { return (vec [1.0; 2.0]).[0..0] } no longer works as it returns a shape mismatch error. I guess maybe it's expecting a vector and is receiving a scalar?

Also, a question, it seems like tensor4 and tensor3 require that all dimensions are equal, is that correct?
Thanks

Thanks, will check all these.  Even more motivation to add systematic testing

Running df (v 3.0) |> DT.Eval (or similar) from dsl-live.fsx results in an error:

Looks like we need to eliminate a BroadcastTo (which is likely scalar -> scalar)

This tf { return (vec [1.0; 2.0]).[0..0] } no longer works as it returns a shape mismatch error. I guess maybe it's expecting a vector and is receiving a scalar?

This sounds like a bug from the recent rewrite of the indexing logic

This tf { return (vec [1.0; 2.0]).[0..0] } no longer works as it returns a shape mismatch error. I guess maybe it's expecting a vector and is receiving a scalar?

That sounds like a bug.

Thanks for reporting this, I've fixed the issues and added basic set of tests


Add support for data that is not JSON

The LISTING_STATUS function returns a list in CSV format.  It would be nice to be able to do that with this library.
https://www.alphavantage.co/documentation/#listing-status

Error is : invalid json response body at https://www.alphavantage.co/query?apikey=xxx&function=LISTING_STATUS reason: Unexpected token s in JSON at position 0

It's possible to make conversion on the fly using library like https://github.com/Keyang/node-csvtojson.

Sorry for the delay, my notifications got turned off for github.... I just added basic support for this by using the additional param datatype=csv
// example if not supported already
alpha.experimental('ENDPOINT_WITH_CSV_RETURN', { symbol: 'XYZ', datatype: 'csv'});

This was just published with<EMAIL_ADDRESS>


Include SReclaimable memory in Cache+Buffer memory

By default the SReclaimable memory is counted into the Used memory, which is not correct (and is a reason why the default output differs from free).
Some references / sources: https://stackoverflow.com/a/66644946 https://www.logicmonitor.com/blog/right-way-to-monitor-linux-memory-again

Hi Tomáš,
Thanks for improve the dashboard.
Regards,


Add hal::mock::stall_detector

It should look like this:
hal::mock::stall_detector detector(10ms);

// Do the actions that may cause a stall to occur like polling a register or waiting a duration of time.
detector.operation_finished();

The stall detector should spawn a thread that waits the amount of time specified in the constructor. That thread should throw an exception if the operation_finished() has not been called in the amount of time specified. That thrown exception object is not accessible by the rest of the code ensuring that it terminates the test. It would also be good to take a std::source_location as well in order for the developer to know where the deadlock occurred in the code. Maybe even a stack trace as well from the termination site. The destructor should join the thread.

Should replace the kind of code hand written here:
https://github.com/libhal/libhal-soft/blob/main/tests/atomic_spin_lock.test.cpp#L132-L162


Turn Takeoff analysis into an MTOW estimator

Make the file a method that is imported and used from an outside test_Takeoff.py, which passes the Plane instance and the takeoff_parameters.

I certify that I am right myself


SRP auth fails with NoCredentialsError

Though this project appears to be dead, I'll post the issue for others who may run into it.
While SRP does not use AWS IAM credentials, if you don't have any in your credential store, the SRP call will fail with a NoCredentialsError exception.
You can create dummy/false credentials, and the call will succeed.  Clearly a defect.
For more details (from somebody else, not me) see
https://stackoverflow.com/questions/47849702/aws-boto-warrant-library-srp-authentication-and-credentials-error

I figured out an easy solution.  The problem is that the boto3 libraries are trying to sign the request to aws, but this request is not supposed to be signed.  To prevent that, create the identity pool client with a config that specifies no signing.  Use the form of AWSSRP that accepts a pre-created client, rather than letting it create its own.
client = boto3.client('cognito-idp', region_name='us-east-1', config=Config(signature_version=UNSIGNED))
aws = aws_srp.AWSSRP(username=args.user_id, password=args.password, pool_id=args.user_pool_id,
                         client_id=args.client_id, client=client)
srp_result = aws.authenticate_user()

This is actually true. We're now fixing it. Right now, I'm still looking into AWS cognito docs for functions that does not require signed signature as the initialization of the class does create a client its own with the use of [access_key, secret_key, user_pool_region], meaning it does not specify the configuration of the request whether it is unsigned or not.
Though right now, or rather, in the next version, we're removing the aws_srp class in favor of warrant-lite.

Next release would fix this issue. By simply not providing the AWS access key and secret, the signature would automatically be unsigned.

@Zuiluj, I just ran into this issue as well, and would really want a fix that does not involve me monkey patching :)
Any ideas when to release the next version? Maybe an interim hot-fix would be to use the unsigned signature just in the calls to Cognito.authenticate...


[ci] Add Vivado tools for splicing cached bitstreams

Forgot to get the tools on the path before preparing the cached bitstream.

Since the relevant job has run, I'm going to go ahead and merge. Queuing time for FPGA and Xcelium tests has reached over 4 hours, so this can at least get out of line.


Upgrade Kotlin to 1.9.20 and Ktlint to 1.0.1

This PR upgrades Kotlin to 1.9.20, and Ktlint to 1.0.1.
I had to abandon the pretty-format-kotlin pre-commit hook since it was ignoring our .editorconfig, which made it impossible to suppress some of the newer lints that would be difficult and undesirable to fix. Now all Ktlint runs go through gradle, so there isn't any way for inconsistencies to creep in.
 When reviewing the Ktlint formatting changes, be sure to hide whitespace changes to reduce how much needs to be examined.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

the codegen changes appear to be whitespace only although the whitespace ignoring link is broken

I unintentionally merged this into jdisanti-upgrade-nightly rather into main. Going to post a new PR to merge this to the correct branch once jdisanti-upgrade-nightly is merged to main.


Allow setting publish connection timeouts

When publishing, one should be able to set a timeout on establishing the connection so that the timeout does not default to :infinity
I've been experiencing intermittent "lock ups" of a genserver client of Tortoise. I could not identify the precise cause but this PR would remove a potential cause.

Pull Request Test Coverage Report for Build 1

3 of 3 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.2%) to 88.006%

Totals

Change from base Build 43:
0.2%

Covered Lines:
565

Relevant Lines:
642

💛  - Coveralls

I tried running the tests but I get
** (Protocol.UndefinedError) protocol Enumerable not implemented for nil of type Atom. This protocol is implemented for the following type(s): Tortoise.Package.Subscribe, Date.Range, GenEvent.Stream, Map, Function, Range, List, IO.Stream, MapSet, File.Stream, Stream, HashDict, HashSet
    (elixir 1.10.4) lib/enum.ex:1: Enumerable.impl_for!/1
    (elixir 1.10.4) lib/enum.ex:166: Enumerable.member?/2
    (elixir 1.10.4) lib/enum.ex:1682: Enum.member?/2
    (ex_unit 1.10.4) lib/ex_unit/case.ex:660: anonymous fn/5 in ExUnit.Case.validate_registered_attribute!/3
    (elixir 1.10.4) lib/enum.ex:2111: Enum."-reduce/3-lists^foldl/2-0-"/3
    (ex_unit 1.10.4) lib/ex_unit/case.ex:659: ExUnit.Case.validate_registered_attribute!/3
    (ex_unit 1.10.4) lib/ex_unit/case.ex:647: ExUnit.Case.register_attribute/4
    test/test_helper.exs:8: (module)

Runtime is
$ asdf current
elixir         1.10.4-otp-23 (set by /home/jf/.tool-versions)
erlang         23.0.3   (set by /home/jf/.tool-versions)

The failing test does not involve, as far as I can tell, the changes in the commit.

One thing though; this timeout will in the sync version of the call be used for the entire life-cycle of the publish, not just getting the connection—for the async version the timeout will only count for the time it takes to obtain the connection, not the time it takes before the messages has been delivered and acknowledged—this might cause some confusion, but let's get it in; Note to self: the MQTT 5 version of Tortoise should not have any :infinity defaults, and instead default to 5_000


Fix the load_model() bug by sorting weights by names

Weights must be sorted by names for save_model() and load_model() work properly.
This pull request fixes https://github.com/fchollet/keras/issues/3964 , https://github.com/fchollet/keras/issues/4044 and https://github.com/fchollet/keras/issues/4143 .
The discussion is https://github.com/fchollet/keras/issues/4044 .

I cannot pass the integration test becuase https://github.com/fchollet/keras/commit/cb3de665d18c579fa36fe8b6b2e2c084ace0bd12 is broken.


Skew Normal Truncation Term Bugfix

Conform to requirement that inputs passed into PyTorch's log() function must be tensors.

There's a git conflict in this PR.
Also, I believe you did this PR from your main, which means I can't edit the PR.
PRs should originate from feature branches so they don't mess up your main branch.
After this is merged you probably want to rewrite your git history so that your main branch matches the main branch of this repo.

Thanks for letting me know, I think I might've set the remote incorrectly.

Great! Merging.


关于多语言支持

如果这个需求强烈的话，我们应该如何去做呢？
gettext 还是 新分支 ？

I maintain my [own English branch] (https://github.com/lakid/musicbox/tree/english_translation) with  English translation. I rebase it on your master everytime you push new content to  project :smile: .
But I believe maybe a gettext like solution would be best for long term as when you make changes you don't have to worry about making changes in multiple places.

Would vote for gettext
It may cost efforts at first, but shall be easier to maintain

@lakid @chaserhkj please review the 14d8a6647427a0e77a7cf1661c3cbb66408c49a3

Somehow or other, can not load translated documents

After running msgfmt translate.po -o translate.mo I was able to get the code running.
But it still shows the program in Chinese characters. Maybe I have problems with the encoding?
My computer runs on ascii encoding by default.


chore: remove tsc from precommit

:tada: This PR is included in version 2.0.4 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


chore(i18n/de): Improved translations.

Improved some wording so it works better in the german language.

Thank you!


[BUG] switch in grid delete delete value of slug field

Laravel Version: 7.2.0
PHP Version: 7.2.19
Laravel-admin: 1.7.14
Description:
When I add switch element in grid and in form then each click on that makes slug field empty.
I don't understand why SLUG field is touched.
        $states = [
            'Да' => ['value' => 1],
            'Нет' => ['value' => 0],
        ];
$grid->column('is_published', 'published')->switch($states);
$form->switch('is_published', 'published');

here is my table schema in DB
        Schema::create('news_posts', function (Blueprint $table) {
            $table->increments('id')->unsigned();
            $table->integer('category_id')->unsigned();
            $table->string('title', 255);
            $table->string('slug', 255)->unique();
            $table->text('fulltext')->nullable();
            $table->string('image', 255)->nullable();
            $table->string('metatitle', 255)->nullable();
            $table->string('metakey', 255)->nullable();
            $table->string('metadesc', 255)->nullable();
            $table->integer('hits')->nullable();
            $table->boolean('is_published')->default(false);
            $table->timestamp('published_at')->nullable();
            $table->timestamps();
            $table->softDeletes();

            $table->foreign('category_id')->references('id')->on('news_categories');
            $table->index('is_published');

If switch field editable only in form page and in grid page it is readonly there is no problems.
Problem appears only when switch field editable in grid page.


[Bug] Failure to install without --ignore-scripts on first install

Not 100% on the why here, but on both my desktop and Vercel I ran into this issue coming up when trying to install the first time
[22:45:54.756] Cloning completed: 332.007ms
[22:45:57.306] Restored build cache
[22:45:57.357] Running "vercel build"
[22:45:57.805] Vercel CLI 32.4.1
[22:45:58.941] Running "install" command: `npm install`...
[22:46:06.677] npm ERR! code 127
[22:46:06.678] npm ERR! path /vercel/path0/node_modules/ulidx
[22:46:06.679] npm ERR! command failed
[22:46:06.679] npm ERR! command sh -c simple-git-hooks
[22:46:06.679] npm ERR! sh: simple-git-hooks: command not found
[22:46:06.680]
[22:46:06.681] npm ERR! A complete log of this run can be found in: /vercel/.npm/_logs/2023-10-13T05_46_01_797Z-debug-0.log
[22:46:06.698] Error: Command "npm install" exited with 127

Edit
Looks like the prepare script is run on local install?
https://docs.npmjs.com/cli/v10/using-npm/scripts#life-cycle-scripts

Runs on local npm install without any arguments

But I don't think prepare should run when it's a dependency, only on local install or publishing. It was changed to prepare instead of post install due to this issue.
https://docs.npmjs.com/cli/v10/using-npm/scripts

I just re-tested the 2.2.1 build on a fresh project, and it worked fine. Node 18, npm 8. I suspect that you installed an old version (2.2.0 was bugged). Will reopen if it's something else.


Create README

Feature Request
Is your feature request related to a problem? Please describe.
Users need to know how the karbon14 api works. For this we need to have a README.
Describe the solution you'd like
Write a README that explains the api works.

Done in commit 56f6e124c14ee0e46a37bb903b5eacdeb59235db


add exact word analyzer and tests

Took a stab at #164

Pull Request Test Coverage Report for Build 415

141 of 142 (99.3%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.7%) to 80.876%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pastepwn/analyzers/tests/exactwordanalyzer_test.py
104
105
99.05%

Totals

Change from base Build 412:
0.7%

Covered Lines:
3307

Relevant Lines:
4089

💛  - Coveralls

Hi @colinlcrawford thanks for your contribution. Is there a reason to why you closed this PR?

@d-Rickyy-b sorry about that, just some confusion on my end - I reopened the PR


use pictures instead of camera

There is any way to use pictures instead of the camera?
Thanks

yes, correct, some devices like Amazon Tablets don't have a camera barcode scan. Would be nice to be able to take a photo and use it to decode.

On one of the other html5-qrcode libraries, they use file input as a fallback which seemed a good way to handle this (additionally as another callback for debugging this would also be helpful).

It's a good idea. What do you have in mind? To upload an image and decode it?

An easier idea would be to allow passing a ref to an img element instead of only being able to pass it to a video element -- that way you wouldn't have to worry about implementing any sort of upload input/element


README updated with extra usage instructions

I thought it would be helpful for newcomers to get a better idea of how to use InstagramKit. I know the sample project has code that can be experimented with but I think a little explanation would help people get their code up and running a bit faster.

Thanks @emondai . Created a separate Wiki page with the information you added.


V2 -- Upgrading to react-hot-loader v3?

@weblogixx I remember talking about HMR/hot-reloading briefly. Did you consider or have any experience with using v3 (currently in beta) with the template? I am starting a test on one project now but was curious because I remember that you were talking about some HMR issues while working on the new repos.

Hi @sthzg, yes, indeed we did. I have not tried v3 as there is currently no documentation (at least not officially, there seems to exist a pr on the repo which shows how to configure). The reasons I thought about canceling support for hmr was:

When using flux or datasources, you will use them on componentWillMount, making hot reloading pointless (see https://github.com/react-webpack-generators/generator-react-webpack/issues/281#issuecomment-243826453)
When using pure components, it will not work and you have to reload by yourself.

However there are still cases where it is a nice feature - thats the reason it is still in there. If you want we could include it (maybe in a feature branch?) and test if it works better now :)

@weblogixx I have to admit that I don't have a deep understanding of the hot reloading infrastructure. V3 is reported to support hot reloading with

Redux reducers
stateless components (haven't found sth. about pure render mixin/PureComponent)
react-router (but not with async routes as this seems blocked by a react-router issue)

I don't know enough yet if 1. means that it can be made to work with real Flux implementations (like FB's flux or AltJS).
The documentation consists of two or three issues with lots of information. Will watch that for a while and experiment with it, but I don't think that any other immediate action than following its progress makes sense right now.
Closing it for now. Feel free to open it again anytime (or request to open it again if you see urgent use cases).


Do not rebalance partitions that do not have in-sync replicas

Rebalance operation can not be completed for partitions, that do not have any in sync replica online.
That means, that no one broker can provide data for these partitions. Therefore, it's better not even try to rebalance these partitions

I would say that it would help future maintainers to add a comment explaining why this is important.

:shipit:


Not Recording System Audio

Steps to Reproduce:

brew tap louis030195/screen-pipe https://github.com/louis030195/screen-pipe.git
brew install screenpipe
screenpipe

Seems to only be recording audio from my mac or airpods, but not system audio.

thanks for reporting
yes it's a known issue caused by latest macos release (15.0)
we're will be working on a fix soon
workaround for you is not to wear airpods in a meeting for example so the output will be "heard" by the input (mac mic)
other work around is to install 1.38 or 1.39 i believe should work if you are not on macos 15.0 (14.5 for example should work)
should work fine on windows & linux

I am on Mac 14.4.1 by the way, so I think perhaps there is another issue?

@DmacMcgreg btw macos audio output works since last week on macos <15.0
there is a $100 bounty to make it work on macos 15.0 https://github.com/mediar-ai/screenpipe/issues/199


CI improvements

The CI runs different checks that validates stuff such as: commit message, unit-tests, images built, e2e tests, backward compatibility tests, and so on.
The checks are split into workflows.
For example, see workflows runs here: https://github.com/metallb/metallb/actions
The workflows running are defined under the /.github/workflows dir.
The goal of this story is to improve metallb-operator's CI by bringing few features we have in metallb's CI.
The features we want to bring are:

combine workflows under one workflow, leveraging the "needs"  option for code reuse and requiring successful dependent jobs, thus improving readability.
merge_group: this is an event we add in the workflow yaml and it allows us to have merge queue that speeds up the process of merging PRs. see more here
composite: we use a composite action to reduce duplication, currently
we have composite for setup and for collecting logs. we can benefit from it
also in the metallb-operator CI.

Thank you for the PR! I added a couple of comments, some are just proposing renaming, notice that some comments apply also to other places in the yaml that I didn't repeat. Also, please add commit message that describes what and why we're doing in this change, you can take inspiration from the description in Jira.

Thanks for the excellent review, I solved the comments.

LGTM. good work! thanks!

@fedepaol @oribon can you please review? :)

can you make sure all of the stuff related to the second commit is there? the commits got a bit mixed together other than that LGTM, I guess we can resolve the bumps / removing the checkout from the setup in another PR

Yes, all the stuff related to the second commit is there.
I agree we will can do it in another PR

@oribon I see we hit the known verify bundle flake in the olm lane. can you please re-run it?


Can I affect UIEffect for All children of an UI Object ?

Can I affect UIEffect for All children of an UI Object ?

Yes please

Sorry for my late reply.
UIEffect v5 is now released.
Please try it. :+1:
🔄 Upgrading from v4 to v5


[T2A4][T16-A1]Lai Zhiyuan

Ready for review

@zyjames some comments added.
Avoid accumulating unrelated changes into a single PR.
Tip: If you are currently on branch1 and want to create a new branch2, you need to switch back to master branch before creating branch2. If not, changes in branch1 will appear in the PR created from branch2 later.
please close the PR once you have noted the comments.


Mark the project as unmaintained

I would like to get a patch for 0.19 released first, but we need libraw to release a fix for some upstream bugs first or restructure our loader to know to skip 0.19.0.
Afterwards, should we merge this and mark the project as officially unmaintained, or seek a new maintainer?

Holding in case @campaul wants to pick this back up.

Going ahead and merging this; I will still attempt to do a release at some point if someone fixes the 0.19 structs (I doubt I'll get to it anytime soon, but if someone else wants to do it sooner I'll verify and cut a release).


fix creating dict with JIT disabled

When using NUMBA_DISABLE_JIT=1 we still want dictobject.new_dict to
work, for example to measure coverage and such things.

Seems reasonable to me.

Following on Stuart's suggestion from #4920, the test could be made to more directly verify the DISABLE_JIT behavior with this test pattern:
https://github.com/numba/numba/blob/92dbdb90e34402f99d158c035f5a1806378161d3/numba/tests/test_debug.py#L184-L188

So the dictobject.new_dict and Dict.empty 'constructors' work now. Dict() also works with the JIT disabled but returns a Dict instance rather than a dict instance. While this might look O.K. from a testing perspective, any attempt to mutate the Dict instance when DISABLE_JIT is active will most likely lead to an error, so the test for that is an expected failure for now.

Fixed Dict too cc @seibert

looks good!


overrideStyleFunction does not set styles

Describe the bug
I'm trying to set a style for selected features on a map. I need to set text on top of a feature icon. But I can't just specify the icon src again, since it is dynamically specified at the rendering stage using a v-for.
<ol-vector-layer ref="picketsVL">
  <ol-source-vector ref="picketsVS">
    <ol-feature
      v-for="picket in pickets"
      :key="picket.properties.RecordId"
      :properties="{
              uuid: picket.properties.RecordId,
              colorId: picketsData[picket.properties.RecordId].color_id || 0,
              logicStatuses: picketsData[picket.properties.RecordId].logic_statuses || [],
            }"
    >
      <ol-geom-point
        :coordinates="Object.values(picket.geometry.coordinates[0])"
      />
      <ol-style>
        <ol-style-icon
          :src="
                  getImageSrc({
                    colorId: picketsData[picket.properties.RecordId].color_id || 0,
                    logicStatuses: picketsData[picket.properties.RecordId].logic_statuses || [],
                  })
                "
          :scale="0.7"
        />
      </ol-style>
    </ol-feature>
  </ol-source-vector>
</ol-vector-layer>

Therefore, I decided to rewrite the styles function and give it to the component.
<ol-interaction-select
  @select="featureSelected"
  :condition="selectCondition"
  :filter="selectInteractionFilter"
>
  <ol-style :overrideStyleFunction="selectedStyleFunction" />
</ol-interaction-select>

<script setup>
.........
const selectedStyleFunction = (feature) => {
  const style = new Style({
    image: new Icon({
      src: getImageSrc({
        logicStatuses: feature.get('logicStatuses'),
        colorId: feature.get('colorId'),
      }),
      scale: 0.7,
    }),
    text: new Text({
      text: '✔',
      font: '14px sans-serif',
      zIndex: 2,
    }),
  });
  return style;
};
</script>

But it does not set the style, because there is an mistake in the ol-style component on 64 line. Missing return for computed property.
const styleFunc = computed<StyleLike>(() => {
  return (feature, resolution) => {
    if (properties.overrideStyleFunction) {
      // the next line must have a return
      properties.overrideStyleFunction(feature, style.value, resolution);
    }
    return style.value;
  };
});

Yes, I would

fixed with #305


redirecting log file in the python script

Hello,
I am using the python script to do docking and I need the binding energy which outputs to the terminal to be saved to a file. One way is to do python dock.py > log.out, but I was wondering if I can get the log file by changing something in the python script. The python script that I am using is the same as first_example.py in your github.
Thank you

Hi @SoodabehGhaffari,
One possible way is to run "python first_example.py" as a subprocess in a parent python script. The parent script:
import subprocess with open('myfile.log', "w") as outfile:     subprocess.run(["python","first_example.py"], stdout=outfile)

@SoodabehGhaffari I believe that all information in the STDOUT (a.k.a log.out) is also available directly from Python.


MSW tab not populating

Currently I have handlers set up, and they are returning data for the outputted components, but for some reason the MSW tab shows "No mock data". Please let me know what you need provided to debug.

Hi @kpervin could you share some of the handlers you are using? msw and storybook versions will also help?
storybook-msw-addon has been updated to work with storybook 8 and MSW 2.3.3 ( using http instead of rest to define handlers)

@offbeat-dev All Storybook packages are updated to v8, and msw is ^2.2.7. The handlers are pretty simple:
const parameters = {
  msw: {
      handlers: [
        http.post("/api/auth", () => HttpResponse.json(mockedSession)),
        http.get("/api/auth/session", () => HttpResponse.json(mockedSession)),
      ],
    },
}

hi @kpervin can you try with the latest version 2.0.5 and msw 2.2.8 + npx msw init
It could have been an issue with the package build. Let me know if that helps.
thank you

@offbeat-dev Tried it with the versions specified, but no luck.
Here's a screenshot of the output logs:

Do you trigger any request on page load? Or are requests triggered by other actions?

All requests are triggered via the parameters.msw.handlers array.

All requests are triggered on page load, yes. No interaction on the page is occurring apart from clicking on the MSW tab.

Interestingly, also navigating between pages doesn't allow for those pages to load MSW data. Only the initially loaded page will work until you refresh the browser (unsure if related).

Got it @kpervin. Thank you for the details. Are you using something similar to the React Router + React Query example from the original addon  https://msw-sb.vercel.app/?path=/story/demos-react-router-rq--mocked-app?
If that is the case I still have to work on implementing that example for this package. I remembered it being challenging to implement even with MSW 1.0 but I'll give it another try with MSW 2.0 since it made things a little bit easier to synch handler with the addon panel.

I am not. I am using Apollo Client, NextJS, but not loading any of the SSR methods.

Ok. I'll try to replicate it. Or if you can share a sandbox reproducing the story and setup you are using would be great so I can debug. Let me know.

I can attempt to replicate. Might be a while before I can get to it, however.

Hi, having the exact same issue, as well as the page reload thing in MSW 2.2.10 and v2.1.1 of the addon.
Any progress on this?

hi @dorsharonfuse are you using NextJs as well?

Nope, using vite v4 and  @storybook/react-vite v8.0.5

@dorsharonfuse
can you check this sandbox please: https://codesandbox.io/p/github/offbeat-dev/storybook-v7-msw-addon-test/main?workspaceId=cc559a65-8dad-4b32-b221-6921707f47a5
I used vite 4, storybook v8.0.5, msw 2.1.0 and  storybook-msw-addon v2.1.1 and it seems to be working fine.
let me know. ty

@offbeat-dev I think that sandbox is private, as I cannot gain access.

Hi @kpervin can you try now please? I edited the link.

@offbeat-dev Thanks for the sandbox.
thanks to it, I was able to realize that I was missing the storybook-msw-addon in the addons array in main.ts.
Probably my bad, but the docs of this addon never mentioned it.
Thanks

@offbeat-dev I am having another issue though now, some of the listeners aren't getting properly registers and this warning appears in the console:
Emitter.ts:173 MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 response:mocked listeners added. Use emitter.setMaxListeners() to increase limit

Sorry, seems the listeners warning happened even before, its the withRoundTrip error that seems to mess up the listeners.
Removing the addon from the addons array fixes the interceptors for some reason

hi @dorsharonfuse sorry about the miss in the documentation. I'll add it for the next version.
Regarding the Listeners issue, is there any chance you can share a sandbox reproducing the issue so I can take a look? otherwise an example of your stories could also help to debug. ty!

I was having this same issue, it seems to be loading now.
Not sure what I did to get the panel to load, but now it seems the edits aren't updating the component. The component reloads when I make an edit (in panel), but the component still uses the old data.

hi @vinny1575 can you share the versions of addon, storybook and MSW you are using. Which framework are you using? React? A reproduction link/sandbox would be helpful too.
Thank you

@offbeat-dev This is the error I'm currently getting.
I can't provide a repro, as my setup is pretty complex.
I'm using Vite v4 and the latest Storybook, MSW and the addon.
Because of this error, the request handlers aren't registering properly, and my requests are not being intercepted.


Figure out why the Actions aren't running

It seems it is running ?_?

Action is not reaching the pytest stage. It counters errors when it's installing the environment from environment.yml.


Feature: Preserve file extension when duplicating files

VSCode Version: 1.20.1
OS Version: macOS High Sierra 10.13.2

Needed behavior:
When duplicating a file it would be nice to have it append the "-copy" just before the file extension.
Current behavior:
Duplication overrides file extension with "-copy".
Discussion:
As can be seen in the example image below, I choose to duplicate a file named "calendar.apib" and the default duplicate file-name is "calendar-copy" where "calendar-copy.apib" would be much more useful.

The duplicate action is contributed by an extension. Please file this issue in that extension github repository


Index (or some other syntax) when location is guaranteed to exist, get otherwise

For example, when looping through const generics R and C, we are guaranteed to stay within the bounds of the layer, layout, etc.

Went through and did this


Add back pyarrow-legacy test coverage for pyarrow>=5

This PR addresses the discussion in #7967 - Since it is still possible to use the "pyarrow-legacy" engine in parquet, it seems clear that we still need test coverage for this engine (even if it is "deprecated").

Do we have a test which makes sure datasets which were written with the pyarrow-legacy engine can be read using the pyarrow-dataset engine?

Yes - Unless I am making a mistake (possible), all tests parameterized with write_read_engines should test this.

Ah, great! You're correct, it looks like the double for-loop here
https://github.com/dask/dask/blob/ecd834a6b456a3579ce67752325a7d1bb0fd61b9/dask/dataframe/io/tests/test_parquet.py#L122
is where we end up with the Cartesian product over all the parquet backends. And when I run dask/dataframe/io/tests/test_parquet.py::test_local locally I end up with the expected combinations of read and write backends (both with pyarrow>=5 and pyarrow<5)
(dask) ➜  dask git:(add-back-legacy-tests) ✗ pytest dask/dataframe/io/tests/test_parquet.py::test_local
======================================================================================= test session starts ========================================================================================
platform darwin -- Python 3.9.6, pytest-6.2.4, py-1.10.0, pluggy-0.13.1 -- /Users/james/mambaforge/envs/dask/bin/python
cachedir: .pytest_cache
rootdir: /Users/james/projects/dask/dask, configfile: setup.cfg
plugins: cov-2.12.1, xdist-2.3.0, check-links-0.5.2, rerunfailures-10.1, forked-1.3.0
collected 9 items

dask/dataframe/io/tests/test_parquet.py::test_local[fastparquet-fastparquet] PASSED                                                                                [ 11%]
dask/dataframe/io/tests/test_parquet.py::test_local[fastparquet-pyarrow-dataset] PASSED                                                                                [ 22%]
dask/dataframe/io/tests/test_parquet.py::test_local[fastparquet-pyarrow-legacy] PASSED                                                                                [ 33%]
dask/dataframe/io/tests/test_parquet.py::test_local[pyarrow-dataset-fastparquet] PASSED                                                                                [ 44%]
dask/dataframe/io/tests/test_parquet.py::test_local[pyarrow-dataset-pyarrow-dataset] PASSED                                                                                [ 55%]
dask/dataframe/io/tests/test_parquet.py::test_local[pyarrow-dataset-pyarrow-legacy] PASSED                                                                                [ 66%]
dask/dataframe/io/tests/test_parquet.py::test_local[pyarrow-legacy-fastparquet] PASSED                                                                                [ 77%]
dask/dataframe/io/tests/test_parquet.py::test_local[pyarrow-legacy-pyarrow-dataset] PASSED                                                                                [ 88%]
dask/dataframe/io/tests/test_parquet.py::test_local[pyarrow-legacy-pyarrow-legacy] PASSED                                                                                [100%]

The changes here LGTM, but let's wait a bit in case @jorisvandenbossche has some additional thoughts


No device found

Running homebridge on a docker container on a synology
Put homebridge in debug mode and added haiku-senseme:* in DEBUG environment variables. I see the following:
2021-02-12T15:09:28.634Z haiku-senseme:observable woohoo! observables!
[2/12/2021, 10:09:28 AM] Loaded plugin<EMAIL_ADDRESS>[2/12/2021, 10:09:28 AM] Registering platform 'homebridge-haiku-senseme.haiku'
SenseME server listening <IP_ADDRESS>:31415
Setup Payload:
2021-02-12T15:09:29.375Z haiku-senseme:senseme Discovery request for IP: <IP_ADDRESS>
2021-02-12T15:09:39.375Z haiku-senseme:senseme Discovery request for IP: <IP_ADDRESS>
2021-02-12T15:09:49.375Z haiku-senseme:senseme Discovery request for IP: <IP_ADDRESS>
2021-02-12T15:09:59.275Z haiku-senseme:senseme Discovery cancelled
SenseME discovery server shutting down
The IP is correct, verified via the Haiku app and my network.
Any ideas what I might be doing incorrectly?

Fan appeared today. I didn't do anything though :) Anyway I'll close.


Add an automated build process

Add an automated build process:

[ ] With proper versioning and everything.
[ ] The branding, is it ImPact or Impact?

 Publish Impact QGIS plugin

 Publish Impact QGIS plugin


fix#31:Handle external context received by NewApp

What does this PR do?
This PR addresses issue #31 by ensuring that if the application errors out during startup, it will log the error and return appropriately.
Fix #31

thankyou!


Write up experimental design and performance against Norris et al. label set

Carried from #92.

Preliminaries for this in 14b20fc12776f6eade94685147b5700d5ce49a4a.

I've written a bunch of pipeline stuff into the thesis document. Going to roll on through into the experimental stuff.

Currently working on some writing on this topic (mainly because I need a break from staring at Python).

Present the distribution of confidences (of all data points) as a violin plot.

Can I get a clarification on this? I'm not entirely sure what you meant.

To do:

Make ROC/precision-recall curves
Make confusion matrix
Document performance against the majority vote labels
Repeat all of this for the radio-based experiments

Regarding presenting performances as violin plots. You have 10 repeats (random splits of training/testing). Each split gives you a test error. The standard way (which you follow) is to report the mean and standard error or these 10 numbers.  Instead, plot the violin plot (or box and whisker plot) of these 10 numbers. This tells you about outliers, skewness, etc.

Alright, sounds good.


Append all Eventbrite ticketing links with a campaign parameter

What?
Appending all Eventbrite ticketing links with a campaign parameter that indicates the booking has come from wellcomecollection.org.
The parameter is ?aff=WCWebsitelink
URLs will look like this: [https://www.eventbrite.co.uk/e/relaxed-opening-of-milk-exhibition-tickets-597650788597?aff=WCWebsitelink
We want to automate this so content editors, when adding the event link in the Prismic content type, don't need to remember to add this parameter each time.
Why?
To enable better use of Eventbrite analytics for the Marketing team
Background
Requested by Alice Evans
Done when

Parameter applied automatically to eventbrite links from wellcomecollection.org
Editorial team to QA

@jennpb : @georgiaewhitney and I are trying to investigate a bit more. From what we get so far, for each event, a tracking link will need to be created in Eventbrite called "WCWebsitelink" in order for it to be tracked, which I think confirms Daniela's comments. (See documentation here)
The numbers don't update in real time, so it's difficult to confirm some of the results of our tests. Some events that already have the affiliate in their Prismic link are marked as having had 0 views. We decided to wait until Monday and see if any of our testing had come through then, as it's flagged as taking a couple hours.

@rcantin-w @georgiaewhitney On second thought, can we hold off on this until next week? If I have time/energy to follow up with the various other people to try to understand a bit more, it's probably better for everyone. Do you know if there's a way I can get a login to understand the EB interface myself?

Oops I've just merged it. I'll revert.
I think you'll have to ask them for access, or have a little ride-a-long with Georgia?

Moving to blocked until @jennpb can talk to Marketing about their requirements

Emailed Alice E on 25/8

Meeting booked for 18/9

Now in production


Set up languagedepot namespace in task setup

This will avoid Skaffold deleting the languagedepot namespace when you run skaffold delete, so it doesn't have to be re-created each time.
The change to the ingress-deployment.yaml file is necessary because Kustomize was changing the ingress-nginx namespaces in there to languagedepot anyway, and therefore Skaffold was still deleting the languagedepot namespace when running skaffold delete because it was being created by ingress-deployment.yaml. Now that ingress-deployment.yaml uses the languagedepot namespace instead, and assumes it already exists, running skaffold delete; task up goes a lot faster.
Fixes #605.

There's one thing that's still slow about running skaffold delete; task up, which is redownloading the large .zip files from Google Drive. I tried to fix that in #758, but discovered that it's just not possible (AFAICT) to get a file from your dev machine into a Kubernetes volume running under Docker Desktop. If anyone knows how to do that, please let me know.


Speed up brew list

Similarly to have we have with other commands, use Bash to speed it up.
Before:
$ hyperfine "brew list"
Benchmark 1: brew list
  Time (mean ± σ):     559.9 ms ± 122.8 ms    [User: 176.2 ms, System: 126.2 ms]
  Range (min … max):   503.2 ms … 907.3 ms    10 runs

After:
$ hyperfine "brew list"
Benchmark 1: brew list
  Time (mean ± σ):     223.7 ms ±  31.9 ms    [User: 35.0 ms, System: 53.4 ms]
  Range (min … max):   198.1 ms … 302.4 ms    10

Petty after comparison because someone on Homebrew/discussions compared them:
$ hyperfine "brew list" "pip3 list"
Benchmark 1: brew list
  Time (mean ± σ):     213.1 ms ±  22.8 ms    [User: 34.2 ms, System: 49.2 ms]
  Range (min … max):   191.2 ms … 272.3 ms    13 runs

Benchmark 2: pip3 list
  Time (mean ± σ):     271.7 ms ±   4.6 ms    [User: 191.9 ms, System: 40.0 ms]
  Range (min … max):   264.7 ms … 281.4 ms    10 runs

Summary
  brew list ran
    1.28 ± 0.14 times faster than pip3 list

While we're here, also add the HOMEBREW_CASKROOM environment variable to make things a bit cleaner and use --caskroom in documentation.

Thanks for the help @carlocab!


Re-using Builder instance between builds lead to builds with stale file content

If
var builder = new Builder({
    paths: {
      'angular2/*': 'node_modules/angular2/*.js',
      'rx': require.resolve('rx/dist/rx.js'),
    },
    packages: {
      'node_modules/angular2': {
        defaultExtension: 'js',
        format: 'cjs',
      },
      'app': {
        defaultExtension: 'js',
        format: 'register',
      }
    },
  });

is only used once (at the top of gulpfile), and
  return builder.buildStatic(PATH.tmp + 'bootstrap.js', PATH.tmp + '_bundle.js', {
    sourceMaps: options.minify,
    runtime: false,
  });

is used for building (inside gulp-watch), then any gulp-watch induced build after the first one will use the stale (same as for the first build) file content of files under app/.
Moving new Builder right before buildStatic fixes the issue.
systemjs-builder 0.14.7

Yes, the builder maintains an internal cache state. To clear the builder state use builder.reset().

Hm, this behavior is a bit unexpected (and currently undocumented, I believe). What is the rationale for default caching model which will cause broken builds? IMHO it will be better to make this an opt-in.
Is there a way for a more fine-grained (file-level) manual cache invalidation?

@flyingmutant are you bundling from transpiled code or are your transpiling during the bundling process?

This was added today which may be of interest here - https://github.com/systemjs/builder/pull/341.

@carlosagsmendes I am bundling from transpiled code.

Thank you @flyingmutant  and @guybedford. I have a problem when bundling multiple bundles using the same builder instance.
If I transpile the code beforehand it works fine. If I bundle from the src folder there seems to be an issue with the babelOptions. The following two lines get invalid values throughout multiple bundles. https://github.com/systemjs/builder/blob/master/compilers/esm.js#L129-L130 (i.e. filenameRelative gets a file name which is not even related to the current bundle).
@guybedford in my case this is a bug since I use the same instance to do several bundles using gulp but outside a gulp watch task - there are no changes to my code between calls.

Apparently filenameRelative and  sourceFileName are only being updated when using the builder https://github.com/systemjs/builder/blob/master/compilers/esm.js#L129-L130
When using babelTranspile from system.src.js only the options.filename is being updated
https://github.com/systemjs/systemjs/blob/1bba480be922f55c788f06a9d6091f7575a08b1f/dist/system.src.js#L1155
This is causing some issues since apparently they are sharing babelOptions on the second case we are getting some wrong data that has been set by the builder.

@carlosagsmendes thanks I've added https://github.com/systemjs/builder/commit/cb038c2a6f3aac9ef0c63fee144ede31595d1fbb let me know if that covers this for you.
The invalidation API has been merged now, so marking this as a documentation issue.

Thks. I replied there

@guybedford I have just upgraded to try the new invalidate() API, but it does not seem to do what I want. I have the following code set up:
  let watcher;

  function watch(changed) {
    console.log(builder.invalidate('path/to/my/file.js'));
    builder.trace(mainDotJs).then((tree) => {
      if (watcher) {
        watcher.end();
      }

      console.log(tree['path/to/my/file.js'].metadata.originalSource);
      watcher = gulp.watch('/absolute/path/to/my/file.js', watch);
    });
  }
  watch();

Every time I change my file, I console.log() the output of builder.invalidate(), which results in a non-empty array with a path that looks correct, but the second log message which logs the originalSource of my file in the tree is stale and never changes no matter how many times I change it.

@onlywei builder.setCache({}) would clear all trace stores, so there wouldn't be any state left containing the trace after that. Are you sure the file contents are being modified?

@guybedford Sorry, my example code was slightly inaccurate. Also I've now updated to the newer version (0.14.9) and I've noticed some differences.
Here's what the code I meant to show you:
  let watcher;

  function watch(changed) {
    console.log(builder.invalidate('path/to/my/file.js'));
    builder.trace('path/to/my/mainFile.js').then((tree) => {
      if (watcher) {
        watcher.end();
      }

      console.log(tree['path/to/my/file.js'].source);
      watcher = gulp.watch('/absolute/path/to/my/file.js', watch);
    });
  }
  watch();

The difference between my previous example is that I am calling builder.trace('mainFile.js') - where mainFile.js imports the file that I am watching for changes.
Previously, in 0.14.8 I was doing the above, and my console.log() statement would log the original source of the file correctly, but once I modified the file, it would continue to log the unchanged original source.
Now, in 0.14.9, changing the file causes my console.log() statement to log an empty string when I change the file. I just tried builder.setCache({}) again, and this is also logging empty string when I modify my file.

@guybedford I did some more looking into your commits, and it looks like applying this change you have already merged into master fixes my issue:
https://github.com/systemjs/builder/commit/a1c15201698dd7cf01813285767da2a2e178fd31


[locale] fix apostrophe typo for ukrainian

Fixes #6182

Maintainer: @ichernev
Reporter: @GeorgeSteshenko
Authors: @zemlanin @Oire
Have referred to https://github.com/unicode-org/cldr/blob/main/common/main/uk.xml#L1930C24-L1930C32 and updated the character accordingly.
Please review.


TargetMachineFactory should be scope per component to remove invalid target by default

Expected Behavior

When declaring target machines for Swift components, it should not be possible to declare a target machine for Windows OS or event the x86 architecture.
Current Behavior

It is possible to declare Windows target or even a Linux x86 target both of which are invalid target.

Also, the default for machines.linux or machines.macOS for Swift component should always default to x86_64 architecture.


Fix absolute paths issue on Windows

Using realpath and abspath in a makefile that is invoked from another makefile seems to not work on Windows in at least Make 3.8.1 (version included in Git Bash for me).
Using abspath/realpath in this case will append to an existing path, producing a path such as D:/STWorkspace/racecar/firmware/projects/DemoProject/platforms/stm32f767/cubemx/D:/STWorkspace/racecar/firmware/cmake.
Haven't tested this fix on Linux since I don't have a setup for it right now, but it should still produce the correct filepath. Not sure how common this issue would be for building on windows but it's only a minor inconvenience anyway.
For bug report: https://lists.gnu.org/archive/html/bug-make/2008-06/msg00054.html

I made a minimum working example to summarize the setup.
C:\
|-- racecar\
|   |-- generate_cubemx.mk
|   |-- inner_dir
|   |   |-- Makefile

[generate_cubemx.mk]
DIR = $(dir $(MAKEFILE_LIST))

all:
	@echo $(DIR)

[inner_dir/Makefile] (replicating firmware/cmake/build_cubemx.cmake)
all:
	@make --file ../generate_cubemx.mk --no-print-directory

First, do you think this is an accurate mock-up of the build setup?
With $(dir $(MAKEFILE_LIST)), running the inner Makefile prints ../, so it appears to be the relative path of generate_cubemx.mk. Works on both Windows and Linux (Ubuntu WSL).
Using $(abspath $(dir $(MAKEFILE_LIST))) gets an absolute filepath. Is this where the error comes from? Just curious since the current code is quite different with
$(shell dirname $(realpath $(firstword $(MAKEFILE_LIST))))

If you don't get an error with the abspath version, lets do it. If there is, then I still like your PR suggestion better than the current

I agree that an absolute filepath seems safer, but also there really shouldn't be any error with a relative one. I'll leave the choice up to you, and worst case if someone has an error we will know exactly where to look.
If you go with relative, update the makefile as required. If you choose absolute, also specify the version requirements in firmware/readme

I ended up testing it some more with newer versions of Make and got the same bug, I guess it has more to do with who's distributing that Windows-ported version of make rather than the actual version number. I also noticed that if you call another makefile with an absolute path (like how I had @make --file C:/racecar/generate_cubemx.mk --no-print-directory ) then the issue persists, but if I used a relative path like ./generate_cubemx.mk then it would be fine when using abspath.
For compatibility, I think I'll stick to the $(dir $(MAKEFILE_LIST)) method, I can't see the cubemx generation files being changed much so it hopefully won't cause any issues down the line


Health check and continues logStartupInfo statements each 10 sec

Combining my Cloud Config Server, wrapped into a war, together with the Cloud Consul ends up filling the log with continues log statements from info from the StartupInfoLogger that the SpringApplication started.
Setting the logStartupInfo(false) using the SpringApplicationBuilder seems not to properagte downwards to the ConfigServerHealthIndicator.doHealthCheck(Builder builder)...
I like to silent that logging, but not disable the health check (spring.cloud.config.server.health.enabled=false), which do stop the logging...
Using
Spring core 4.2.6
Spring boot 1.3.5
Spring cloud-config 1.1.0
Spring cloud-consul 1.0.0

Is it anything to do with consul (if you remove that does it make a difference)? What is the actual symptom you see anyway? Is it logging caused by someone pinging your /health endpoint? Does it go away if you run the app on its own?
I wouldn't expect the main application logStartupInfo flag to get anywhere near the health indicator, so I doubt that would ever have helped.

This is what I get every 10 secs:
_applicationEvent = ServletRequestHandledEvent: url=[/health]; client=[fe80:0:0:0:d983:ea6f:a23d:8bcb%11]; method=[GET]; servlet=[dispatcherServlet]; session=[null]; user=[null]; time=[1038ms]; status=[OK]
2016-05-20 08:24:03.180  INFO 11056 --- [nio-8888-exec-3] o.s.boot.SpringApplication               : Starting application on A-DK-001046 with PID 11056 (C:\environment\mavenrepo\main\org\springframework\boot\spring-boot\1.3.5.RELEASE\spring-boot-1.3.5.RELEASE.jar started by mhh in C:\projects\asyscommons\configurations\cloudconfig\branches\prod)
2016-05-20 08:24:03.180  INFO 11056 --- [nio-8888-exec-3] o.s.boot.SpringApplication               : The following profiles are active: default
2016-05-20 08:24:03.182  INFO 11056 --- [nio-8888-exec-3] s.c.a.AnnotationConfigApplicationContext : Refreshing org.springframework.context.annotation.AnnotationConfigApplicationContext@1f68ff32: startup date [Fri May 20 08:24:03 CEST 2016]; root of context hierarchy
2016-05-20 08:24:03.185  INFO 11056 --- [nio-8888-exec-3] f.a.AutowiredAnnotationBeanPostProcessor : JSR-330 'javax.inject.Inject' annotation found and supported for autowiring
2016-05-20 08:24:03.190  INFO 11056 --- [nio-8888-exec-3] o.s.boot.SpringApplication               : Started application in 0.084 seconds (JVM running for 148.299)
2016-05-20 08:24:03.190  INFO 11056 --- [nio-8888-exec-3] o.s.c.c.s.e.NativeEnvironmentRepository  : Adding property source: file:/C:/Users/mhh/AppData/Local/Temp/config-repo-5311451693102722307/trunk/application.yml
2016-05-20 08:24:03.190  INFO 11056 --- [nio-8888-exec-3] s.c.a.AnnotationConfigApplicationContext : Closing org.springframework.context.annotation.AnnotationConfigApplicationContext@1f68ff32: startup date [Fri May 20 08:24:03 CEST 2016]; root of context hierarchy
_applicationEvent = ServletRequestHandledEvent: url=[/health]; client=[fe80:0:0:0:d983:ea6f:a23d:8bcb%11]; method=[GET]; servlet=[dispatcherServlet]; session=[null]; user=[null]; time=[947ms]; status=[OK]
_applicationEvent = org.springframework.cloud.client.discovery.event.HeartbeatEvent[source=org.springframework.cloud.consul.discovery.ConsulCatalogWatch@1efa5e53]
2016-05-20 08:24:14.179  INFO 11056 --- [nio-8888-exec-4] o.s.boot.SpringApplication               : Starting application on A-DK-001046 with PID 11056 (C:\environment\mavenrepo\main\org\springframework\boot\spring-boot\1.3.5.RELEASE\spring-boot-1.3.5.RELEASE.jar started by mhh in C:\projects\asyscommons\configurations\cloudconfig\branches\prod)
2016-05-20 08:24:14.179  INFO 11056 --- [nio-8888-exec-4] o.s.boot.SpringApplication               : The following profiles are active: default
2016-05-20 08:24:14.181  INFO 11056 --- [nio-8888-exec-4] s.c.a.AnnotationConfigApplicationContext : Refreshing org.springframework.context.annotation.AnnotationConfigApplicationContext@177addf1: startup date [Fri May 20 08:24:14 CEST 2016]; root of context hierarchy
2016-05-20 08:24:14.185  INFO 11056 --- [nio-8888-exec-4] f.a.AutowiredAnnotationBeanPostProcessor : JSR-330 'javax.inject.Inject' annotation found and supported for autowiring
2016-05-20 08:24:14.190  INFO 11056 --- [nio-8888-exec-4] o.s.boot.SpringApplication               : Started application in 0.081 seconds (JVM running for 159.299)
2016-05-20 08:24:14.190  INFO 11056 --- [nio-8888-exec-4] o.s.c.c.s.e.NativeEnvironmentRepository  : Adding property source: file:/C:/Users/mhh/AppData/Local/Temp/config-repo-5311451693102722307/trunk/application.yml
2016-05-20 08:24:14.190  INFO 11056 --- [nio-8888-exec-4] s.c.a.AnnotationConfigApplicationContext : Closing org.springframework.context.annotation.AnnotationConfigApplicationContext@177addf1: startup date [Fri May 20 08:24:14 CEST 2016]; root of context hierarchy
_applicationEvent = ServletRequestHandledEvent: url=[/health]; client=[fe80:0:0:0:d983:ea6f:a23d:8bcb%11]; method=[GET]; servlet=[dispatcherServlet]; session=[null]; user=[null]; time=[992ms]; status=[OK]

I added the application event and rewrote my application to be jar based - which didn't change the output... If I disable the consul part, it still logs...
BUT... looking in the consul logging I noticed that each time the consul server do a GET I get the startupInfo logging in the cloud config server log... consul remembers that it should do a health check ping... which it of course also do even if I remove all the consul parts from my cloud config server.
2016/05/20 08:46:48 [DEBUG] http: Request GET /v1/kv/config/application,subversion/?recurse&wait=2s&index=1 (2.0268225s) from=<IP_ADDRESS>:50160
2016/05/20 08:46:49 [DEBUG] agent: check 'service:cloud-config-service-subversion-8888' is passing

So... bottom line is that it's the health pinging from the consul server that trigger the startupInfo logging in the cloud config server and I can't disable the logging.

So you have a health indicator that checks it is alive by creating an application context. I guess that's the config client one. You can disable that if you want (health.config.enabled=false). Does that fix it for you (if so we can probably turn it off there by default)?

Actually, I don't think that's it. This is what I see from the /health endpoint being pinged in a vanilla config client:
2016-05-20 10:15:11.594  INFO 23713 --- [nio-8080-exec-3] c.c.c.ConfigServicePropertySourceLocator : Fetching config from server at: http://localhost:8888
2016-05-20 10:15:14.362  INFO 23713 --- [nio-8080-exec-3] c.c.c.ConfigServicePropertySourceLocator : Located environment: name=application, profiles=[default], label=null, version=115be7a7479730e59568d70bac1377a692142dd7

As I wrote, disabling the health check stops the logging, but... well, that stops the health check, which isn't what I wanted...

I'm using just the Spring Cloud Config Server in a POM with Spring Boot as parent and seeing the same thing when hitting the /admin/health endpoint. Here are the logs:
2016-05-25 21:05:32.241  INFO 1 --- [nio-6010-exec-8] o.s.boot.SpringApplication               : Starting application on 9cbc18675a60 with PID 1 (started by root in /)
2016-05-25 21:05:32.241  INFO 1 --- [nio-6010-exec-8] o.s.boot.SpringApplication               : The following profiles are active: default
2016-05-25 21:05:32.243  INFO 1 --- [nio-6010-exec-8] s.c.a.AnnotationConfigApplicationContext : Refreshing org.springframework.context.annotation.AnnotationConfigApplicationContext@5dd17947: startup date [Wed May 25 21:05:32 UTC 2016]; root of context hierarchy
2016-05-25 21:05:32.251  INFO 1 --- [nio-6010-exec-8] o.s.boot.SpringApplication               : Started application in 0.037 seconds (JVM running for 211.737)
2016-05-25 21:05:32.251  INFO 1 --- [nio-6010-exec-8] o.s.c.c.s.e.NativeEnvironmentRepository  : Adding property source: file:/tmp/config-repo-1519679784810548648/application.yml
2016-05-25 21:05:32.251  INFO 1 --- [nio-6010-exec-8] s.c.a.AnnotationConfigApplicationContext : Closing org.springframework.context.annotation.AnnotationConfigApplicationContext@5dd17947: startup date [Wed May 25 21:05:32 UTC 2016]; root of context hierarchy

Ideally, I'd also like to silence these.

@andyshinn you can disable the health indicator with spring.cloud.config.server.health.enabled=false.

Ah, I understand what is going on now. The app has to start to clone the git repo and there is a health check for the git repo so it is triggered every poll of the health check. I guess I can relax the interval at which I check health since this is indeed desirable behavior.


Vectors do not work

I like this package and I am testing to see if I can use it in class together with Unitful. I hit several problems one is:
I use Jupyter in vscode
@handcalcs x = [1, 2];
@handcalcs a = x[1] * 2
MethodError: no method matching convert_subscript(::LaTeXStrings.LaTeXString; function_name::Bool, convert_unicode::Bool, env::Symbol)
The first command works, but the second gives the error above
@handcalcs x = [1, 2];
#@handcalcs a = x[1] * 2

Good catch. I think the issue is my package is trying (somewhat) to do:
@latexdefine a = $x[1] * 2

This will error. However, this works:
@latexdefine a = $(x[1]) * 2

So I think it is just a matter of wrapping it in parenthesis correctly. I will try to find some time this week to fix this.

As far as Unitful goes, that should be coming soon. Latexify.jl has a fix for the bug I mention in the documentation. However, it is taking some time for them to release it. I have some good enhancements ready once they release the update.

Hi @DrDanon. I have released a patch for the bug mentioned above. Do you want to try out the new release and see if that fixes it?

It works well thank you.


try/poi/serialize test is broken

@fsc8000 @peter-ahe-google
The --no-opt change broke serialization in try/poi.  The test is in tests/try/poi/serialize_test.dart, and the status is in tests/try/try.status.
The failure can be reproduced with tools/test.py -mrelease -rvm -cnone try/poi/serialize
The expected string has line breaks, and the produced one doesn't, or vice versa.
The commits where the test started failing on the buildbot are:
Change #43285
Changed by<EMAIL_ADDRESS>Changed at	Fri 04 Dec 2015 04:08:14
Repository	https://chromium.googlesource.com/external/github.com/dart-lang/sdk.git
Project	sdk-master
Branch	master
Revision	2b7ff6dfaba9723ee1fa467554b8c2fd4b42ae29
Comments
Fix test by removing the --noopt flag from the test file.
Not all platforms (ia32) support --noopt, and test.py --noopt will run the test
with this option anyway.
<EMAIL_ADDRESS>BUG=
Review URL: https://codereview.chromium.org/1497213002 .
Changed files
tests/language/vm/precompiled_static_initializer_test.dart

I don't see how my change affected that test. Are you sure that you bisected correctly?

bisected to fc868df0045d67de8fe5feb81264e839dd5a9b05 @sigurdm

Proposed fix: https://codereview.chromium.org/1498963004/
On Mon, Dec 7, 2015 at 3:39 PM, Florian Schneider<EMAIL_ADDRESS>wrote:

bisected to fc868df
https://github.com/dart-lang/sdk/commit/fc868df0045d67de8fe5feb81264e839dd5a9b05
@sigurdm https://github.com/sigurdm
—
Reply to this email directly or view it on GitHub
https://github.com/dart-lang/sdk/issues/25125#issuecomment-162543294.


views.open does not work in view submission on PC client

Description
Hello.
I tried to open view in other view submission, but it doesn't work.
code is below
// handle view submission
app.view({ callback_id: 'callback_id' }, async ({ ack, body, view, client }) => {
  await ack()

  // ...

  // open view
  const opRes = await client.views.open({
    trigger_id: body.trigger_id,
    view: view()
  })
  console.info(`viewsOpenResponse: ${JSON.stringify(opRes)}`)

  // send message
  await client.chat.postMessage({
    token: slackAppToken,
    channel: body.user.id,
    text: text,
    icon_url: slackAppIconUrl,
    username: slackAppUsername
  })
}

const view = (): View => {
/...
}

The log show success, but view was not open.
In the PC client (application / browser) view does not open, but it opened in the iOS Slack app.
viewsOpenResponse: {"ok":true,"view":{"id":"viewID","team_id":"teamID","type":"modal","blocks":[{"type":"section","block_id":"9fV","text":{"type":"plain_text","text":"text","emoji":true}},{"type":"divider","block_id":"CAK"},{"type":"section","block_id":"DUgy","text":{"type":"plain_text","text":"text","emoji":true}},{"type":"section","block_id":"WMzF","text":{"type":"mrkdwn","text":text","verbatim":false}}],"private_metadata":"","callback_id":"","state":{"values":{}},"hash":"1629568070.T8dOi9Il","title":{"type":"plain_text","text":"title","emoji":true},"clear_on_close":false,"notify_on_close":false,"close":{"type":"plain_text","text":"Close","emoji":true},"submit":null,"previous_view_id":null,"root_view_id":"viewID","app_id":"appID","external_id":"","app_installed_team_id":"teamID","bot_id":"botID"},"response_metadata":{"scopes":["chat:write","users:read","users:read.email","commands"]}}

How I can open view on PC client?
(At 08/13, it worked with the same code... maybe)
What type of issue is this? (place an x in one of the [ ])

[ ] bug
[ ] enhancement (feature request)
[x] question
[ ] documentation related
[ ] example code related
[ ] testing related
[ ] discussion

Requirements (place an x in each of the [ ])

[x] I've read and understood the Contributing guidelines and have done my best effort to follow them.
[x] I've read and agree to the Code of Conduct.
[x] I've searched for any related issues and avoided creating a duplicate issue.

Bug Report
Filling out the following details about bugs will help us solve your issue sooner.
Reproducible in:
package version: 3.5.0
node version:
OS version(s): macOS BigSur 11.5.2

Hi @yuuis, thanks for asking the question!
Indeed, view_submission payload includes trigger_id. However. it is not guaranteed that calling view.open in response to view_submission works in any situation. If your app would like to continue the interactions with the same user in a modal, a recommended way is to use response_action: update in ack() method as below:
app.view('callback_id', async ({ ack, body, view, client }) => {

  // do anything within 3 seconds

  // replace the modal with a new one
  await ack({
    response_action: 'update',
    view: { } // new modal view
  });

  // do anything asynchronously
}

Note that your app need to call ack() within 3 seconds to avoid timeout errors. Also, refer to the document as well: https://api.slack.com/surfaces/modals/using#updating_views to learn more about modal interactions.
I hope this was helpful to you!

Indeed, view_submission payload includes trigger_id. However. it is not guaranteed that calling view.open in response to view_submission works in any situation.

I didn't know that!
I changed my code to update view in ack(),  working as expected now, thank you @seratch !!

I'm glad to hear that my suggestion was helpful 🎉


Tensorflow Docker Image with Jupyter Notebook Runs in HTTP

Looks like the official image in here runs the container as root and runs jupyter notebook with http. Is there a version that does not run as a root and also supports https (self signed certs would be fine)?

Anyway, I created my own in here: https://github.com/bulutmf/tf-jupyter-https-2.0.1


New sensu-install command

How does this handle plugin updates? Do we have to rerun install on the plugin we want to update it?

@NeckBeardPrince you can specify versions, e.g. network-checks:0.0.8, and it will upgrade the plugins.
This PR makes further improvements to sensu-install https://github.com/sensu/sensu/pull/1110


Encrypt session passwords once

Issue type
[X] Feature request
[ ] Bug report
[ ] Documentation

Environment

Python version:   3.5.3
Peering Manager version:   0.99-dev

Description
It makes sense to be able to retrieve the unencrypted passwords from PM incase they are required.  However, any time a configuration is deployed, the password is re-hashed which creates a config diff.  If you get regular email reports of config diffs, that can get noisy :)
I think the fix is to have PM hash the password for each supported device type and store the clear text password as well as the device-specific hashed password(s). Whenever a configuration is deployed, it inserted the pre-hashed password.

Can we add a hook for IOS-XR platform type which does not use 7 ${encrypted string}?
IOS-XR uses the following:
If entered clear, config is: password clear mysecurepassword
If entered encrypted, configs is: password encrypted 045612150A22595C0C090404011C03162E

Oh Cisco it's a pain trying to automate things with you 😄
Can you open a new issue (bug report) to track this?


The missing file is ..\packages\Microsoft.Bcl.Build.1.0.21\build\Microsoft.Bcl.Build.targets.	Sensor Telemetry

I am doing an application when i am trying to add the bcl library into packages using nuget package manager console i am getting this error when debugging the code.

I'm very sorry but I don't know how to help/support. What kind of project are you creating? What platform are you targeting? Lots of additional information needed. Going to close pending additional updates from you.


Main feature gamedata

Implement bepinex root gamedata path with legacy support
changed project settings
cleaned up some classes

Please note this is a half baked implementation, there are plans to reduce the codebase in the future


"this undefined" error when using npm link and webpack

Since 1.2.0 I read that webpack and require statements should work nicely. I use webpack with babel. I tried
npm install sigma
and
import sigma from 'sigma';
and it works.
Since I would like to start hacking on sigma itself I thought I could use npm link. so I did:
git clone https://github.com/jacomyal/sigma.js.git outside of my project dir and changed into the sigma directory, then:
npm install && npm run build
sudo npm link # i'm on ubuntu
then back into my project folder I uninstall the sigma module from npm and do:
npm link sigma
when starting my webpack build I now get this error:
ERROR in ../sigma.js/build/sigma.require.js
Module build failed: Error: Couldn't find preset "es2015" relative to directory "/home/christophe/workspace/velona/sigma.js/build"
    at /home/christophe/workspace/velona/velona/node_modules/babel-core/lib/transformation/file/options/option-manager.js:299:19
    at Array.map (native)
    at OptionManager.resolvePresets (/home/christophe/workspace/velona/velona/node_modules/babel-core/lib/transformation/file/options/option-manager.js:270:20)
    at OptionManager.mergePresets (/home/christophe/workspace/velona/velona/node_modules/babel-core/lib/transformation/file/options/option-manager.js:259:10)
    at OptionManager.mergeOptions (/home/christophe/workspace/velona/velona/node_modules/babel-core/lib/transformation/file/options/option-manager.js:244:14)
    at OptionManager.init (/home/christophe/workspace/velona/velona/node_modules/babel-core/lib/transformation/file/options/option-manager.js:374:12)
    at File.initOptions (/home/christophe/workspace/velona/velona/node_modules/babel-core/lib/transformation/file/index.js:216:65)
    at new File (/home/christophe/workspace/velona/velona/node_modules/babel-core/lib/transformation/file/index.js:139:24)
    at Pipeline.transform (/home/christophe/workspace/velona/velona/node_modules/babel-core/lib/transformation/pipeline.js:46:16)
    at transpile (/home/christophe/workspace/velona/velona/node_modules/babel-loader/lib/index.js:41:20)
 @ ./src/public/app/genseqhub/genseqhub.component.js 24:13-29

I change back into the sigma folder and do
npm install babel-preset-es2015
now the webpack build step works
my chrome console shows:
Cannot read property 'sigma' of undefined
the responsible part in sigma.core.js is:
  /**
   * EXPORT:
   * *******
   */
  if (typeof this.sigma !== 'undefined')
    throw 'An object called sigma is already in the global scope.';

  this.sigma = sigma;

}).call(this);

Would anybody have a solution for this? How come the same code works in the npm version but not the linked version?

This is strange indeed and seems to be a babel bug rather than a sigma one since sigma does not use babel whatsoever.


Fully Automated Release

In theory this should work, however...

I have not tested that the calculatings for the major and minor versions actually work the way I think they do
The text of the release is not properly set.  We probably want logic to do different release text depending on if it's a major release, or a minor.

In the case of a major we (IMO) have something very vague and ensure the RMs come back and update that text
In the case of a minor we (IMO) have something static like "This is a maintenance release for X.y", and the RMs can come back to update it if they feel like they need to.

The release is still set to be a draft.  Before this goes in we should remove that.

Any other issues or objections people can see?
Your pull request should…

[x] have a concise title
[x] close an accompanying issue if one exists
[x] be against the correct branch
[ ] ~include migration scripts and documentation, if appropriate~
[x] pass automated tests
[x] have a clean commit history
[x] have proper commit messages (title and body) for all commits

Looks good. Once tested, we should also switch from draft mode to release mode.

#4091 is cleaner :P


Add missing packages to setup.py

to be able to install from zip archive.
Though tinygrad/llops/ops_triton.py symlink breaks import tinygrad if installed from zip, I just rm ops_triton.py post install

Want to fix the symlink breaking it too?


Transactions remain pending on metamask

Describe the bug
Description of the bug here. Transactions for Eth remain pending on Taiko Katla for several days , even after increasing gas transactions are still pending. This happens for both while bridging and swapping
Steps to reproduce
Steps to reproduce here.
Spam policy

[X] I verify that this issue is NOT SPAM and understand SPAM issues will be closed and reported to GitHub, resulting in ACCOUNT TERMINATION.

Network is congested and we are working to increase the bandwidth of the chain 💪

I Used rabby wallet and the transactions were confirmed withing seconds


Update views-and-stored-procedures.md

Want to add a note to the documentation to highlight DAB only supporting stored procedures for MSSQL and not for non-relational databases (i.e. NoSQL).
This is to highlight the findings of issue 1915

Thanks for your contribution, @jacksorjacksor
The repo has changed significantly since this pull request, so I pulled your changes into a new pull request, so you care appropriately credited with your contribution. Thank you again for your patience and effort!


WIP - Handle user commentChar

Related to #320

I am going to close this. I am not a daily user of neogit and so I don't think I will be the one to add this feature.


Percentage text should be localisable

Percentage sign usage differs from language to language. Most languages use a basic 100% format, that immediately follows the number; however some languages use different notations, and even different percent signs.
In newsboat code, it looks like there are two instances of percent sign use; one in itemviewformaction.cpp, and the other one in configcontainer.cpp. Ideally, these strings should be marked as translatable and follow the 100% format for the C locale.

I wasn't aware of the different notations, thanks! (and thank you for the direct links to the relevant sources)
Will be fixed by https://github.com/newsboat/newsboat/pull/2444

Thanks for the quick fix. There is a slight issue though, since there is padding attached to the placeholder, in my case it will lead to output like %  1, when it has to be %1 (I need to put the sign before the number).
I have a similar patch for apt, that addresses this. Might be useful.

I think it is okay for different translations to have different padding.
The only important part is that the types of specifiers are still the same (so %3u can be changed to %u or %-2u in translations)
In your case, you could choose to add a few spaces in front, and then show the percentage without padding, e.g.:   %%%u
Does that resolve your issue?
I think the percentage field is 6 characters wide: https://github.com/newsboat/newsboat/blob/c0ed70475ddf50ade51479d16fd3395d42231144/stfl/itemview.stfl#L38
It might expand if the translated content is bigger than 6 characters, but it is best not to depend on that (behavior could change when we switch to a different terminal UI library)

If we can change the padding in the translations, then it's all good, thank you for the clarification. I will submit new translations accordingly. So is it okay if I push   %%%p and   %%%u respectively?
My language is the rare one out here, if I ascertain this, I think the rest of the languages will be fine. :)

Yes, that should be fine.
In the case of the podlist-format translation, you could choose to use negative padding on the %p. (e.g. %%%-5p)
That results in padding to the right of the number (making sure that the total width is constant, irrespective of the exact percentage number).
However, I'm not sure if that is what you want in your language (or preference).


Dynamically adapt to noisy neighbors

User Story
As an application developer, I want my applications to be resilient to noisy neighbor effects. My log queries should not fail because other users of my AWS account are performing Insights log queries at the same time.
Background
Although Incite is currently very resilient to temporary service errors (it will currently retry up to 10 temporary failures to start a chunk query and 10 temporary errors to poll a chunk for results), persistent lack of query capacity and/or persistent throttling by the AWS CloudWatch Logs Insights service can eventually cause a chunk to fail completely, and when that happens it brings down the query.
Tasks

Introduce a dynamic adaptive adjustment to mgr's Parallel value that goes down, to a minimum value of, say ,1 in response to service quota limit errors and goes back up at a more gradual rate, to a maximum value of Parallel, in response to successful chunk starts.
Introduce a dynamic adaptive RPS adjustment to mgr's request regulator so the requests per second go down in response to throttling errors and rise back up at a more gradual rate in response to non-throttled API calls.

Commit 8416966 fixes the second half of the problem, the RPS/throttling problem (labeled as task #2 above).
An upcoming commit will fix the first half, the parallel chunk/query concurrency limit problem (labeled as task #1 above).

Commit 9bac15c fixes the first half of the problem, the parallel chunk/query concurrency limit problem (labeled as task #1 above).
Work for this issue is now complete and ready for release as v1.4.0.


color contrast is not accessible

The contrast of text versus the background is an important usability consideration as it makes it difficult or impossible for people to read. If the contrast is too low it will fail web accessibility standards. There are are few places where the current color combinations will fail accessibility tests for color contrast.

The most critical is the use of the yellow color (#FED136) for body links over a white background (here is the failing contrast check. I think a different color choice for body links with more contrast is important.

The reverse combination used on "buttons" in the navigation will also fail the tests, but appears more readable because of the larger text size. One simple higher contrast option would be to have the active navigation item to use black text (#000000) with the theme yellow (#FED136) (passing test).

The other low contrast area I noted was the dark gray LC logo (#7B7979) in the upper left with a light black background (#222) in the nav bar (failing test). A higher contrast option would be to push the LC logo closer to white.

I hate to do this but I am actually colourblind and that blue is much less obvious in links to me than the yellow. I would go so far as to say it is not very clear what is a link :(
There must be a colour that is both nice and completely visible to genetic defects like me!

Do you have a suggestion for a colour that would work @richyvk ?

I have tried red now @richyvk @jezcope @evanwill

The red contrast passes the accessibility tests. However, the blue is still on :hover (?) and messing things up if you hover or click, then scroll around.
Do we have an official color scheme?
The general "rule-of-thumb" color-blind accessibility guideline is avoid these combos:

Green & Red
Green & Brown
Blue & Purple
Green & Blue
Light Green & Yellow
Blue & Grey
Green & Grey
Green & Black


Fixed some translation errors

Some keywords should not be translated.

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

Closed and Reopened this PR to attempt to resolve a specific Travis build failure.

@yi-ge I know why I closed an reopened this PR, but why did you do the same on this a 3-4 other of your PRs?

@RandellDawson  I'm sorry.I got it wrong.

Thank you for your contribution to the page! 👍
We're happy to accept these changes, and look forward to future contributions. 🎉


Some small updates to improve speed and readability

Let me know if you would like me to change anything. I would like to fully convert the print statements to logging outputs which gives you a lot more room for use.

I'm not sure the best way you want the try statement so let me know if I need to change it again

Closing. Updated script to 3.2. Addresses readability  and print statements highlighted in this pull. ujson was not added in the new release. Feel free to pull again to add ujson support if you like.