Fix unnecessary COM initialization

I tracked the issue #2577  back to this commit and the file winit/src/program.rs:L273, where the window is first initialized with default() window options instead of the provided ones.
I am not going to lie, I don't know why we need to create a window with default attributes first and then initialize it again with proper attributes later, but if I change the first initialization to be without drag-and-drop support, then COM is initialized later only when it is really required.
I tested this change with examples/events and the reproduction code from the issue and everything works as I would expect it to on Windows.

I would also consider using the window options provided when creating the application in this place, because it would be hard to track all of the flags causing similar side effects.


How is offline installation way

Is there a way you can offline installation, I am Chinese users, I have been troubled for a long time in the first step is the network problem, there is a normal files have not been able to download.I hope to have an offline installation way, like all the other software
8:50:29.057 [ERROR] [org.gradle.BuildExceptionReporter] FAILURE: Build failed with an exception.
18:50:29.058 [ERROR] [org.gradle.BuildExceptionReporter]
18:50:29.059 [ERROR] [org.gradle.BuildExceptionReporter] * What went wrong:
18:50:29.060 [ERROR] [org.gradle.BuildExceptionReporter] A problem occurred configuring root project 'gobblin'.
18:50:29.060 [ERROR] [org.gradle.BuildExceptionReporter] > Could not resolve all dependencies for configuration ':classpath'.
18:50:29.061 [ERROR] [org.gradle.BuildExceptionReporter]    > Could not download artifact 'gradle.plugin.org.inferred:gradle-processors:1.1.2:gradle-processors.jar'
18:50:29.063 [ERROR] [org.gradle.BuildExceptionReporter]       > Could not GET 'https://plugins.gradle.org/m2/gradle/plugin/org/inferred/gradle-processors/1.1.2/gradle-processors-1.1.2.jar'.
18:50:29.064 [ERROR] [org.gradle.BuildExceptionReporter]          > peer not authenticated
18:50:29.066 [ERROR] [org.gradle.BuildExceptionReporter]
18:50:29.067 [ERROR] [org.gradle.BuildExceptionReporter] * Exception is:

You can directly download the Gobblin distribution package, it is a tar ball that contains everything needed to run Gobblin
The link is: https://github.com/linkedin/gobblin/releases/download/gobblin_0.7.0/gobblin-distribution-0.7.0.tar.gz

@heqin5136 I believe @sahilTakiar answer would have helped you. Please reopen the issue if you still need any help.


Is Circuit Relay V1 Supported?

The only JS examples I can find for connecting a libp2p node via circuit relay is this one. When I try to connect my libp2p node through a v1 Circuit Relay, I get this error:

Failure reason: protocol selection failed

From looking through the circuit relay source code for js-libp2p, it appears that only v2 Circuit Relays are supported?
For my use case, v2 Circuit Relays do not seem to succeed. I need the file passing that only v1 Circuit Relays are capable of. Are there any plan to support v1 Circuit Relays? If they do support v1, how would the config differ from this example?

I should clarify: I have some standalone v1 Circuit Relays set up. I'm not trying to create a v1 Circuit Relay with the libp2p node. I'm trying connect two libp2p nodes through a standalone v1 Circuit Relay.

For my use case, v2 Circuit Relays do not seem to succeed. I need the file passing that only v1 Circuit Relays are capable of.

The key difference between v1 and v2 is that every v1 relay is an open relay with no limits on connections or data transfer so are open for abuse.
v2 places limits on the amount of data that can be sent so it's only suitable for signalling while establishing a direct connection.
For example if you have a node with a file and it's listening on WebRTC, you'll notice that the reported WebRTC address has a p2p-circuit component.
Another node wishing to fetch the file will dial the WebRTC address - this opens a connection to the relay, the relay opens a stream to the node with the file, WebRTC handshake data is exchanged, a direct connection is established between the two nodes and a file transfer can take place.
Are you able to use WebRTC in this fashion?

After digging through Issues and documentation the last week, it dawned on me that WebRTC is getting a lot of attention in the js-libp2p and helia projects. I'm just starting to work on integrating that transport into my project. I'll try that and report back if it doesn't seem to fix the issues.
I'm optimistic that with the combination of v2 Circuit Relays and WebRTC, my project can achieve its goals.


What is the option : Clear NVRAM exacly ?

i cant find info please help :(

the option does not exist when not running my UEFI firmware (and no UEFI firmware is available for Apollolake devices). Since you are running stock firmware, there is no NVRAM to clear.


env var for config file added

Overview
Use the CONFIG environment variable to load the config file, but it currently doesn't allow custom file paths. Kubevuln always defaults to searching for the config file in the /etc/config path, regardless of the CONFIG env value.
How to Test
Build kubevuln using make
Load config file using the CONFIG environment variable
export CONFIG=path/to/clusterData.json
Set the PORT environment variable to 8081
export PORT=8080
Related issues/PRs:
Resolved #129
Checklist before requesting a review

[x] My code follows the style guidelines of this project
[x] I have commented on my code, particularly in hard-to-understand areas
[x] I have performed a self-review of my code
[x] If it is a core feature, I have added thorough tests.
[x] New and existing unit tests pass locally with my changes

/improve

@dwertent  @matthyx I understand that config.LoadConfig function to load configurations from multiple JSON files so we can also load configurations from multiple JSON files in the "/etc/config" directory using the filepath.Glob approach  but viper.AddConfigPath(path) is look for config in the mentioned "/etc/config" directory  so What should I do then? because I think your approach is right then to handle loading configurations from multiple directories specified through environment variable is not correct which I have tried.   Thank you.


support an optional custom escape

This adds an option to override the default escaping, allowing you to use handlebars to render things which are not HTML. It both alters the public API—is a breaking change—and adds a feature that might not be the common use case for this library, but I wanted to PR these changes against the canonical repo before creating a fork, just in case you thought they would be useful!
This does the following:

Adds a new Escaper interface, which defines an Escape method that can be used to escape unsafe text
Modifies the existing Escape into HTMLEscaper which satisfies the Escaper interface
Adds a TemplateOptions struct, which defines options for a template, such as its Escaper
Adds TemplateOptions as an optional parameter to template parsing functions; when nil, the old behavior is maintained
Fixes escape_tests.go which had no asserts, and adds a test for the new feature.

Let me know what you think, or maybe if you like the idea but would prefer it implemented in a different way. It won't hurt my feelings if you close this PR; it's an unnecessary addition for most users, changes the public API, and I don't mind maintaining a fork for my purposes.

sorry about that, missed updating some tests; fixed now


How can I enable udp support ?

Am I missing a trick here ?
It would require a subsection like this, but I cannot see a way of providing this in the class initialisation.
[input_plugins]
  # Configure the udp api
  [input_plugins.udp]
  enabled = true
  port = <port>
  database = <database_name>

I believe this can be handled now with the 0.9 branch. I will merge this to master and release a new version to the Forge after some feedback. Let me know what you think! #18

This project is no longer maintained. I recommend you check out golja/influxdb for an updated Puppet module for InfluxDB.


Remove Reindexer.recreateTargetIndex

That method allowed the caller to specify the index settings for
number_of_shards and number_of_replicas, but otherwise prevented the
user from specifying a mapping.
Removed the method and the two settings.
Now the caller must setup the target index any way he likes before
invoking the reindexer (this is in conformity with the reindexer
package comment)

You are correct. It has unexpected side-effects for users. It is better to leave it up to the end-user to set up the target index. Sorry for that.

Thanks for merging, and thanks for a library that tackles the huge feature-set of elasticsearch.


Alert Tool Doesn't Support Read Only Mode.

Hello, When i try to apply read only setting to editorjs, I get below error.

The fix for this issue is released in v1.0.3.


Fixing issue on restarting after setting permissions

On first run permissions need to be changed. Once that happens
minikube is supposed to try again. This was failing. This change
fixes that situation.

@mook-as can you please take another look. I updated per your suggestion.

@mook-as can you please take another look. I updated per your suggestion.


Popup suggestion window always shows upon other application windows

Description
As the title says,
When I clicked other applications and their windows were upon the DBevaer's windows, the suggestion window of DBevaer still show up. When I clicked back to DBeaver, the suggestion windows was at the right place near the cursor.

This problems annoyed me when I started to use ver 23.
DBeaver Version
23.0.4
Operating System
windows 10 22H2
Database and driver
No response
Steps to reproduce

When I place the cursor at the end of the SQL sentence (maybe other places).
I switch to another application.
Waite for a while.
The suggestion pops up.

Additional context
No response

Thank you for the report. The issue often happens if a popup takes a lot of time to load due to a large number of elements. It could be shown over other applications.


Change layout for the index page

Expanding one table doesn't force the neighbouring one to be expanded also

@SchrodingersGat I can still expand one table at the time:

It's a fine behavior for me, not sure why would someone want the neighbor table to expand to? :thinking:

Yes, this is the new and desired behaviour.
With the old layout, if you expanded (for example) the second row in the left column, then the second row in the right column would expand to. It was due to the ordering or rows / columns in the layout.

Umm ok, it did not have this effect when I tested it. But good that you fixed it then!


ImageUtils always uses PNG for base64 conversion

As the title says:
https://github.com/AoElite/claude4j/blob/defb948d7600caf89759717a05415932fc1db90b/src/main/java/com/aoelite/claude/utils/ImageUtils.java#L23
I tried to upload JPG images but all of them failed. As soon as I converted them to PNG it worked.
Cool lib though! Thanks for making it public! ;)

@laxika Should be fixed


Using Angular Formly in an Angular Workspace

Hey guys!
I'm new to Formly - and from what I see on the web, IT's AMAZING!!!!!
Trying to install it in an Angular workspace... No errers during installation (using the ng add command).
Manually importing the modules (to a lazy loaded module), but nothing works, I keep getting the "cant bind" errors.
Can't bind to 'formGroup' since it isn't a known property of 'form'.
&&
'formly-form' is not a known element:
imported .forRoot() in global app.module...
imported.forRoot() & .forChild() in the lazy module...
and even created a completely separate shared module for the form sections:
@NgModule({
  declarations: [],
  imports: [
    FormsModule,
    ReactiveFormsModule,
    FormlyModule.forRoot(),
    FormlyMaterialModule
  ],
  exports: [
    FormsModule,
    ReactiveFormsModule,
    FormlyModule,
    FormlyMaterialModule
  ]
})
export class FormlySharedModule { }

To make sure I get the basics right (this is my first time with formly after all 0_o) I installed it in a stand alone Angular project. Took all of...3 minutes to set up and confirm it's working.
Any other folks having issues running in a workspace?
And more importantly, ideas of where to start looking to fix it?
  "dependencies": {
    "@angular/animations": "~9.0.7",
    "@angular/cdk": "^9.2.3",
    "@angular/common": "~9.0.7",
    "@angular/compiler": "~9.0.7",
    "@angular/core": "~9.0.7",
    "@angular/fire": "^6.0.0",
    "@angular/forms": "~9.0.7",
    "@angular/material": "^9.2.3",
    "@angular/platform-browser": "~9.0.7",
    "@angular/platform-browser-dynamic": "~9.0.7",
    "@angular/router": "~9.0.7",
    "@angular/service-worker": "~9.0.7",
    "@fortawesome/angular-fontawesome": "^0.6.1",
    "@fortawesome/fontawesome-svg-core": "^1.2.28",
    "@fortawesome/free-brands-svg-icons": "^5.13.0",
    "@fortawesome/free-regular-svg-icons": "^5.13.0",
    "@fortawesome/free-solid-svg-icons": "^5.13.0",
    "@ngx-formly/schematics": "^5.6.1",
    "hammerjs": "^2.0.8",
    "rxjs": "~6.5.4",
    "tslib": "^1.10.0",
    "zone.js": "~0.10.2",
    "@ngx-formly/core": "^5.0.0",
    "@ngx-formly/material": "^5.0.0"
  },

Thanks to who ever looks at this!

Problem solved...
Weirdest thing - the lazy component was loading just fine and renders "lazy component works!" when you route to it. And as soon as you add the form & formly html etc, the application run time complains.
Turns out the lazy module component import statement had a typo... How in the world was it rendering in the first place 0_o
Thanks guys, and a day later... looking forward to diving into Formly...formerly! :D


Nick: Watch chnwetwipes.com

Nick requests the watch of the watch_keyword chnwetwipes\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

chnwetwipes\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Jeff Schaller in Charcoal HQ


Build fails for Xcode 15  for 17 version

Description
In Hash file I got in these set of line of code
#else
template
struct hash_base : std::unary_function<T, std::size_t> {};
#endif
I modified underscore as suggested
#else
template
struct hash_base : std::__unary_function<T, std::size_t> {};
#endif
After this, I am getting errors in FBReactnativeSpec file

As you can see in this image.
why this error is coming? Is it new error or I am missing something?
Steps to reproduce

Install New version Somona.
Install xcode latest version - 15.1
Install latest emulator - < 17 verion , I am running iPhone 15 pro max.
try to build from xocde.

React Native Version
0.70.0
Affected Platforms
Runtime - iOS
Output of npx react-native info
I can not print the output, as mentioned in the above image getting a build error.

Stacktrace or Logs
Value is unavailable introduced in ios 12.0.

Reproducer
https://github.com/below/react-Xcode15Bug
Screenshots and Videos

You report about v0.70.0, but 2 reproducers are 0.71.8 (copied from https://github.com/facebook/react-native/issues/37748) and 0.73.1 (which is never failed with xcode 15). If you want to run v0.70 with xcode 15, use v0.70.14 or latest version

How do you upgrade? If you only bump version in package.json, it fails 100%. And 0.72.8 isn't the latest

That isn't how to upgrade react native version, use upgrade helper. Your screenshot didn't finish uploading

to fix the problem you are facing you need to open project in xcode , inside the targets select react-codegen , go to build settings , make sure iOS deployment target is minimum 12.4.

Closing as you received relevant answers already.
React Native 0.70 was not compatible with XCode 15.
If you upgrade to the latest stable (0.73) you should be able to build correctly


Require login for Medicine Commands

Require login status for the following commands:

AddMedicineCommand

Pull Request Test Coverage Report for Build 1016

7 of 7 (100.0%)  changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.04%) to 70.164%

Totals

Change from base Build 1001:
0.04%

Covered Lines:
3116

Relevant Lines:
4441

💛  - Coveralls


Implement Tests

Implement tests for the following:

Tests of all successful outcomes of the init subcommand

with just name argument
with name and sdk path
with name, sdk path, and nimbase path
ensure --overwrite works as intended.

Tests of all successful outcomes of the `build subcommand
Tests which of all likely events where error messages have been defined

I plan on starting this on the weekend

after some pondering, I now realize that testing all possible outcomes of the command line args is a little overboard. And I also didn't mention creating any tests for the actual wrappers themselves, which I think I will also try to do.


[feat] Gadget Metadata

This PR introduces an easier way to define your gadget sources in your Cargo.toml
It is not, However, a new way that we created, it is actually encouraged by Cargo to let other tools embed extra metadata that could be later on used by these tools, see:  for more information.
In our case, you can define your gadget metadata related to where we find your gadget binaries like the following:
[[package.metadata.gadget.Native.sources]]
owner = "webb-tools"
repo = "incredible-squaring"
tag = "0.1.0"
binaries = [
    { arch = "Amd64", os = "Linux", name = "amd64-linux-incredible-squaring-gadget" },
    { arch = "Arm64", os = "Linux", name = "arm64-linux-incredible-squaring-gadget" },
]

Open Questions

In Github CI, we should update the blueprint.json with the SHA256 of the release binaries, that could be a separate task, or we could create our own github action.
Blueprint Specification (blueprint.json), potentially, should be attached to each github release.

What task is this for?

One more CI task to fix.

@drewstone it is failing since #246 I would mention @Serial-ATA here to investigate more in his PR.

Yeah, #246 wasn't tested on the CI changes in #284. I'll take a look.


xextents of overlay of raster and HLine

When drawing a line outside the extents of an Raster/Image, the extents of the overlay grow such that the line is also visible.
Works for VLine
hv.Raster(np.random.rand(100,100))*hv.VLine(x=120)

Does not work for HLine: xaxis extended instead of yaxis
hv.Raster(np.random.rand(100,100))*hv.HLine(y=120)

Definitely seems to be a bug. Thanks for reporting this.

It seems the HLine and VLine plots classes have never implemented a custom get_extents method. Should be trivial to implement one.

Actually had we not decided that certain annotations should not be considered when computing the bounds? If that regressed then that would explain why we hadn't noticed this before.

We did discuss it before but I can't remember what we decided. Personally I would quite like for annotations to be included in the bounds calculation but there could be a good reason not to. I don't mind either way as long as we are consistent.

There is certainly an argument for not considering line annotations when computing the bounds (though of course it would need to be both types of such annotations).  E.g. one may want to provide a red line to mark a danger threshold, and as long as that threshold is never reached, there's no reason to enlarge the display to include it.  But there are also other cases when one might want to include the location of the annotation, so maybe there should be a configuration option to determine whether annotations affect the extents.


Clipboard

clipboard to variables
changed icons from pure extending to mixin
started work on z-index

LGTM, nice one regarding z-index


[Task]: GraphQL plugin: check if UQI datastructures can be used

Is there an existing issue for this?

[X] I have searched the existing issues

SubTasks

This task has come as a result of code review comment.
Ask is to check if we can use UQI data structures with GraphQL plugin so that a migration could be prevented in future.

It does not seem feasible to do without including REST API plugin within the scope since both GraphQL plugin shares common component classes with the REST API plugin. Some of these common classes would be directly impacted. Either these common classes have to be made GraphQL specific (which defeats the goal of REST API refactor and code re-use) or we have to migrate REST API plugin as well. Hence, not moving forward with this task at the moment.


Cross-Platform Issues with Npm Scripts

🤔 What's the problem you've observed?
Our npm scripts use shell commands, working on Unix-like systems (Mac & Linux). To expand user reach and simplify support, let's discuss migrating them to Node.js for truly cross-platform compatibility. Share your insights & preferred approaches!

cp command is not work on regular Windows systems.
https://github.com/cucumber/vscode/blob/c3ed82d412241b996776b17b40d1603f96ad22ce/package.json#L92
sh scripts is not compatible with Windows systems.
https://github.com/cucumber/vscode/blob/c3ed82d412241b996776b17b40d1603f96ad22ce/package.json#L98-L99

✨ Do you have a proposal for making it better?
Since Node.js is our development environment, migrating all complex scripts to Node.js will ensure cross-platform compatibility. This leverages built-in modules like fs for file operations, documentation generation, and more.
📚 Any additional context?
This problem also occurs in cucumber/language-server and cucumber/language-service

This text was originally generated from a template, then edited by hand. You can modify the template here.

Cheers for raising - agree on cross-compatibility; making it easy for anyone to contribute to the project is incredibly important.
The first thing I would suggest to check is what conventions are applied across Cucumber: whether there are other scripts in use and what format they take. Ensuring a consistent contributing experience across our repositories is important for maintainability. Perhaps you can take a lot at our other repositories and advise?
Secondly, I would weigh up the prospects of containerisation - which would standardise development environments and may be comparatively easier to set up and maintain.
Interested in your thoughts on the above @binhtran432k. What do you think?

Hi @kieran-ryan,
Thanks for the thoughful response and your agreement on the importance of cross-platform compatiblity! I definitely share your sentiments about making contribution easy and accessible.
In response to your suggestion, I agree that other Node.js scripts used in Cucumber projects also lack Windows compatibility. While containerization holds promise, I propose keeping it a lower priority for now due to the following factors:

Windows users can leverage WSL or orther virtual machines for building and deploying to their actual machines.
Certain repositories, such as cucumber/language-service, rely on Docker within their build processes, posing significant challenges for further containerization.

I'll keep this issue open to link it with future cross-platform development efforts. Feel free to close it if it is not planned!

@binhtran432k, thanks for your valuable input and discussion on this issue. Given the polyglot nature of Cucumber projects, suggest we continue with scripts for present moment. However, we can absolutely continue further discussion and revisit this decision if new information comes to light.
Introducing Node scripts would add a Node installation dependency to workflow jobs beyond JavaScript. This may affect contributors working with different languages more than ourselves, who may be without a Node installation (for example, see the makefile for the Python implementation of the gherkin parser). As these scripts are more related to maintenance than the JavaScript implementation itself, they could be worked on by any member of the community.
Although the current script format is not perfect, it seems to be the accessible option for the moment, as you've also pointed out alternatives for Windows users (Windows users can leverage WSL or other virtual machines).
Appreciate your continued contributions and ideas - you're doing excellent work!


windows-0.43.0: When use the match then find the constant values were the same, so I wondered whether this is a bug.

when use match for NetworkAuthenticationType get warning: unreachable pattern, that I found the same value of Wpa3Enterprise and Wpa3Enterprise192Bits , so I wondered whether this is a bug.
// windows::Networking::Connectivity::NetworkAuthenticationType
let desc = match nss.NetworkAuthenticationType().expect("Failure") {
      NetworkAuthenticationType::Wpa3Enterprise => "Wpa3Enterprise",
      NetworkAuthenticationType::Wpa3Enterprise192Bits => "Wpa3Enterprise192Bits",
      //...
      _ => "Unknown",
  };

That's consistent with the metadata in the Windows SDK as well as the documentation:
https://learn.microsoft.com/en-us/uwp/api/windows.networking.connectivity.networkauthenticationtype?view=winrt-22621
For what it's worth, the documentation gives a rationale for the two identical constants.
Incidentally, this is a good example for why Rust enums can't be used since it is an error for two variants to share the same discriminant, or value, in Rust.
fyi @jonwis


v2.0.0

Coverage decreased (-11.2%) to 88.785% when pulling 5c4f469624129841a2033779b5b1e2f7bda079ab on dev into d06e5d758ba4e61ffcb355d33a285476c364054c on master.

Coverage decreased (-11.2%) to 88.785% when pulling 5c4f469624129841a2033779b5b1e2f7bda079ab on dev into d06e5d758ba4e61ffcb355d33a285476c364054c on master.


Converting 2.5 criteria files to 3.0 criteria files

It came up at the workshop that it would be handy if the PmagPy 2.5 --> 3.0 conversion could handle criteria files, so I took a stab at it.
I didn’t have all the data I need in acceptance_criteria to write a valid 3.0 criteria file.
{'samples.int_n_specimens': {'category': None,
  'decimal_points': -999,
  'threshold_type': 'inherited',
  'value': '3'},
 ….

So I modified pmag.read_criteria_from_file to include some additional data (‘pmag_criteria_code’, ‘er_citation_names’, and ‘criteria_definition’ if available):
{'sample_int_n': {'category': None,
  'criteria_definition': 'acceptance criteria for study',
  'decimal_points': -999,
  'er_citation_names': 'This study',
  'pmag_criteria_code': 'ACCEPT',
  'threshold_type': 'inherited',
  'value': '3'},

Then I wrote a new function, pmag.convert_criteria_file_2_to_3, which:

uses the data from pmag.read_criteria_from_file
get criterion_operation from the data model
and assembles everything into proper 3.0 format.

Everything looked good, but then I realized that I was missing a few items.  My conversion script works properly if there is only one criterion (ACCEPT, IE-SPEC, etc), but can break with multiple criteria.
The problem is that pmag.read_criteria_from_file stores values in a dictionary, and so if a table-column is used in more than one place, the value will be overwritten.
i.e., if a criteria file looks like this (McMurdo 2.5):
criteria_definition	er_citation_names	pmag_criteria_code    site_polarity

Criteria for inclusion in normal mean	This study	NPOLE	    n
Criteria for inclusion in reverse mean	This study	RPOLE	    r

pmag.read_criteria_from_file will munch it and end up with only one of the two rows needed for site_polarity, since you can't have a dictionary with two 'site_polarity' keys.
I could write a second version of pmag.read_criteria_from_file that stores those data differently, but that seems a bit redundant.  I could also re-write pmag.read_criteria_from_file to store the data a little differently {"site_polarity": {}, "site_polarity2": {}}, or something like that, and then rename them at the very end.  I'm just a bit nervous about breaking criteria functionality elsewhere.
@ltauxe, I know you are out and about but maybe we can discuss this when you get back?

I've implemented what I have in Pmag GUI step 1a.  I now warn users which files are and aren't translated, and also translate criteria files.  This translation still has some problems as explained above, but it will work for many pmag_criteria files.

@ltauxe and I concluded that this minor munching of the upgrade isn't a big issue.  If it comes up in the future, we'll fix it then.


Add a javascript code to implement Merge Sort

@sachin-duhan26  sir, I would like to work on this issue


Update_231024_1

Fixed a typo (missing comma) in SNS topic policy, amended AWS source owner, re-enabled SNS bucket notification.

@nbuckingham72 Terraform plan evaluation detected changes to resources that require approval from a member of @ministryofjustice/modernisation-platform - please contact #ask-modernisation-platform for assistance
Guidance on approving these PRs is available at https://user-guide.modernisation-platform.service.justice.gov.uk/runbooks/reviewing-mp-environments-prs.html#process-for-approving-prs

@nbuckingham72 Terraform plan evaluation detected changes to resources that require approval from a member of @ministryofjustice/modernisation-platform - please contact #ask-modernisation-platform for assistance
Guidance on approving these PRs is available at https://user-guide.modernisation-platform.service.justice.gov.uk/runbooks/reviewing-mp-environments-prs.html#process-for-approving-prs

@nbuckingham72 Terraform plan evaluation detected changes to resources that require approval from a member of @ministryofjustice/modernisation-platform - please contact #ask-modernisation-platform for assistance
Guidance on approving these PRs is available at https://user-guide.modernisation-platform.service.justice.gov.uk/runbooks/reviewing-mp-environments-prs.html#process-for-approving-prs


Fix the shared library build for :grpc++_unsecure

@vjpai

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Jenkins, this is ok to test

Can you describe the issue that these changes resolve? AFAIK, none of the changes being made require security and that should be the only difference between grpc and grpc_unsecure. Maybe we need a new more trimmed target for your purposes?

[trickle] No significant performance differences

[microbenchmarks] No significant performance differences

Probably the main issue is that these aren't being linked into the grpc++_unsecure rule, but should be. They're missing dependencies.

@nicolasnoble : what's the path forward on combining #11933 and #11944 ?

Superceded by #11978


rework queue updates

closes #1386 - rework queue updates (enqueue / dequeue) to be driven by the calling context and extracted to ruby land. Instead of calling updates via sql using update_all update the state on the specific known queues when we are using them.

@marten is good to review again, turns out i hadn't re applied the seens remover, thanks!

LGTM


Support bootstrap configs in text proto format, and improve errors.

This commit allows .pb_text configs to be parsed as text, and improves
the parse failure error message to include (1) text or binary mode, and
(2) the message type being parsed.
I was trying to use the new --bootstrap-path flag to get away from
JSON so the config could have comments, and got stuck for a while before
realizing the protobuf was being parsed in binary mode.

@jmillikin-stripe will defer to @htuch but I thought there was some reason we didn't want to support text PB (vs. JSON/YAML). He can advise.
If we do stick with this we will need a test.

Yes, since text PB is not standardized (it's not even consistent across languages in some corner cases), we decided to use YAML as the standardized textual representation of proto. That said, this is a small PR to give us support for this, which might be useful in some test situation, so sure, why not. We won't be officially supporting it though.

BTW, text PB is super ugly for the opaque filter configs, take a look at https://gist.github.com/htuch/aa273c9bf01ba9c6b18353ec8799695e#file-listeners_generated-pb. JSON/YAML representations hide this.

OK, tests added.

Yes, since text PB is not standardized (it's not even consistent across languages in some corner cases)

As one datapoint: text_format encoding of proto3 consistency across {C++, Go, Python, Java} is Good Enough™ for what we'll be using it for, and has strong advantages over YAML (simpler semantics/grammar) and JSON (comments). It's also more practical to generate than binary protobufs for environments that can't easily have protoc plumbed into them.

Dev experience note: Tests won't build on my MacOS machine because it's missing some Linux tools (realpath?), and won't build in a lyft/envoy-build container for...mysterious reasons:
WARNING: /src/bazel/repositories.bzl:24:5:
WARNING: /src/bazel/repositories.bzl:25:5: Process terminated by signal 15; also encountered an error while attempting to retrieve output
WARNING: /src/bazel/repositories.bzl:26:5: External dep build exited with return code: 256
WARNING: /src/bazel/repositories.bzl:28:9:  External dependency build failed, check above log for errors and ensure all prerequisites at https://github.com/lyft/envoy/blob/master/bazel/README.md#quick-start-bazel-build-for-developers are met.

@htuch, I understand a lot of the current Bazel weirdness is due to constraints from fitting the Envoy build into Google's external infra. At some point I'd like to see if it could be simplified so it's easier to build dependencies in a more Bazel-y way.

@jmillikin-stripe we're open to improvements to the build, as long as they don't involve creating a parallel Bazel build system for external deps (e.g. our own custom injected BUILD files via new_git_repository for every dependency). That was the state we started in earlier this year, and it was hard to maintain and had questionable build products (none of the tests for these dependencies were run with the hacked up BUILD files).
A pure Bazel dependency tree would be amazing, but I think it's a bit of a long term goal, given that dependencies seem to keep growing and very few projects are Bazel native.
That said, if we could move some parts out of the recursive make step to Bazel for dependencies where there is native Bazel support already (e.g. BoringSSL), which you previously expressed interest in, definitely open to that. We should have a better CI setup soon without the Travis resource limits, so that would open up the opportunity to having less done in prebuilts in CI.


cannot sync mail: IMAP protocol error.

Are there any related issues?

could not find any obvious ones
What operating system are you using?
Debian GNU/Linux 9 (stretch)
What version of Nylas Mail are you using?
2.0.15
Bug?
Do you have any third-party plugins installed? If so, which ones?
no
Is the issue related to a specific email provider (Gmail, Exchange, etc.)?
IMAP
Is the issue reproducible with a particular attachment, message, signature, etc?

Attempting to connect to Courier IMAP 4.8.0 running on my own server
I was able to login far enough for it to load the folder list, but it hasn't been able to load the contents of any folders yet. Each time it gives me a red warning that says, "Encountered an error syncing [my email address]" with a "Try Again" button.
{ Error: Error: Error in IMAP command received by server.
    at NylasError (errors.es6:1:8)
    at IMAPProtocolError (imap-errors.es6:22:5)
    at convertImapError (imap-errors.es6:140:15)
    at wrappedReject (imap-connection.es6:245:34)
    at imap-connection.es6:264:11
    at throw (<anonymous>)
From previous event:
    at imap-connection.es6:234:20
    at next (<anonymous>)
    at step (imap-connection.es6:9:1)
From previous event:
    at imap-connection.es6:9:1
    at imap-box.es6:55:17
    at next (<anonymous>)
    at step (/usr/share/nylas-mail/resources/app.asar/node_modules/isomorphic-core/src/imap-box.es6:3:191)
From previous event:
    at /usr/share/nylas-mail/resources/app.asar/node_modules/isomorphic-core/src/imap-box.es6:3:99
    at /internal_packages/client-sync/src/local-sync-worker/sync-tasks/fetch-messages-in-folder.imap.es6:255:21
    at next (<anonymous>)
    at resume (/usr/share/nylas-mail/resources/app.asar/internal_packages/client-sync/src/local-sync-worker/sync-tasks/fetch-messages-in-folder.imap.js:3:448)
    at /usr/share/nylas-mail/resources/app.asar/internal_packages/client-sync/src/local-sync-worker/sync-tasks/fetch-messages-in-folder.imap.js:3:367
From previous event:
    at AsyncGenerator.send [as _invoke] (/usr/share/nylas-mail/resources/app.asar/internal_packages/client-sync/src/local-sync-worker/sync-tasks/fetch-messages-in-folder.imap.js:3:169)
    at advance (/usr/share/nylas-mail/resources/app.asar/internal_packages/client-sync/src/shared/interruptible.js:78:31)
    at err (/usr/share/nylas-mail/resources/app.asar/internal_packages/client-sync/src/shared/interruptible.js:110:17)
From previous event:
    at FetchMessagesInFolderIMAP._runGenerator (/usr/share/nylas-mail/resources/app.asar/internal_packages/client-sync/src/shared/interruptible.js:63:12)
    at advance (/usr/share/nylas-mail/resources/app.asar/internal_packages/client-sync/src/shared/interruptible.js:94:30)
  message: 'Error: Error in IMAP command received by server.',
  userMessage: 'IMAP protocol error. Please contact<EMAIL_ADDRESS>  statusCode: 401,
  source: 'protocol',
  __stackCleaned__: true } { fingerprint:
   [ '{{ default }}',
     'sync loop',
     'Error: Error in IMAP command received by server.' ],
  rateLimit:
   { ratePerHour: 30,
     key: 'SyncError:SyncLoop:Error: Error in IMAP command received by server.' },
  pluginIds: [ 'client-sync' ] }

Got the same error (Ubuntu 16.04). What Mailserser you are using. We use courier. Maybe related...

Also using Courier IMAP, similar issues....
 Error: Error: Invalid mailbox name.
    at NylasError (errors.es6:1:8)
    at IMAPProtocolError (imap-errors.es6:22:5)
    at convertImapError (imap-errors.es6:147:15)
    at wrappedReject (imap-connection.es6:245:34)
    at imap-connection.es6:264:11
    at throw (<anonymous>)
    at step (imap-connection.es6:9:1)
    at imap-connection.es6:9:1
    at tryCatcher (/usr/share/nylas-mail/resources/app.asar/node_modules/bluebird/js/release/util.js:16:23)
    at Promise._settlePromiseFromHandler (/usr/share/nylas-mail/resources/app.asar/node_modules/bluebird/js/release/promise.js:510:31)
    at Promise._settlePromise (/usr/share/nylas-mail/resources/app.asar/node_modules/bluebird/js/release/promise.js:567:18)
    at Promise._settlePromise0 (/usr/share/nylas-mail/resources/app.asar/node_modules/bluebird/js/release/promise.js:612:10)
    at Promise._settlePromises (/usr/share/nylas-mail/resources/app.asar/node_modules/bluebird/js/release/promise.js:687:18)
    at Async._drainQueue (/usr/share/nylas-mail/resources/app.asar/node_modules/bluebird/js/release/async.js:133:16)
    at Async._drainQueues (/usr/share/nylas-mail/resources/app.asar/node_modules/bluebird/js/release/async.js:143:10)
    at Async.drainQueues (/usr/share/nylas-mail/resources/app.asar/node_modules/bluebird/js/release/async.js:17:14)
  message: 'Error: Invalid mailbox name.',
  userMessage: 'IMAP protocol error. Try to first remove your account from Nylas Mail, then re-add it and try again.',
  statusCode: 401,
  source: 'protocol' } { pluginIds: [] }
{ Error: Error: Error in IMAP command received by server.
    at NylasError (errors.es6:1:8)
    at IMAPProtocolError (imap-errors.es6:22:5)
    at convertImapError (imap-errors.es6:147:15)
    at wrappedReject (imap-connection.es6:245:34)
    at imap-connection.es6:264:11
    at throw (<anonymous>)
    at step (imap-connection.es6:9:1)
    at imap-connection.es6:9:1
    at tryCatcher (/usr/share/nylas-mail/resources/app.asar/node_modules/bluebird/js/release/util.js:16:23)
    at Promise._settlePromiseFromHandler (/usr/share/nylas-mail/resources/app.asar/node_modules/bluebird/js/release/promise.js:510:31)
    at Promise._settlePromise (/usr/share/nylas-mail/resources/app.asar/node_modules/bluebird/js/release/promise.js:567:18)
    at Promise._settlePromise0 (/usr/share/nylas-mail/resources/app.asar/node_modules/bluebird/js/release/promise.js:612:10)
    at Promise._settlePromises (/usr/share/nylas-mail/resources/app.asar/node_modules/bluebird/js/release/promise.js:687:18)
    at Async._drainQueue (/usr/share/nylas-mail/resources/app.asar/node_modules/bluebird/js/release/async.js:133:16)
    at Async._drainQueues (/usr/share/nylas-mail/resources/app.asar/node_modules/bluebird/js/release/async.js:143:10)
    at Async.drainQueues (/usr/share/nylas-mail/resources/app.asar/node_modules/bluebird/js/release/async.js:17:14)
  message: 'Error: Error in IMAP command received by server.',
  userMessage: 'IMAP protocol error. Try to first remove your account from Nylas Mail, then re-add it and try again.',
  statusCode: 401,
  source: 'protocol' } { pluginIds: [] }

Same issue here. Ubuntu 16.04 LTS, trying to connect to my Mail Service Provider. Also the folder list gets loaded, but emails are not synched.

+1
Got the same error (Archlinux).
nylas-mail-bin 2.0.32-1

They won't or can do maybe anything to solve. Sorry to say but the mem/cpu footprint/load is anyway ridiculous. But nice gui and interface.

I havent looked into the error but I have issues retrieving mail.com IMAP after a few days. The emails cant be retrieved any more.


Java "import static"

(Original issue 1228 created by benromberg on 2016-04-13T16:37:32.119879+00:00)
In Java, when using a so-called static import, the static keyword should be highlighted as well. Example:
import static java.util.Arrays.asList;

Not even Bitbucket highlights this correctly - are they using Pygments? It seems that GitHub is able to do this though.
Not sure how this would be implemented, maybe by changing the line
(r'(import)(\s+)', bygroups(Keyword.Namespace, Text), 'import'),

to
(r'(import|import static)(\s+)', bygroups(Keyword.Namespace, Text), 'import'),

I'm not proficient with python though...

(Original issue 1228 last updated on 2016-04-14T07:39:35.683271+00:00)
(Issue automaticaly closed due to status in Bitbucket: resolved)

(Original comment by birkenfeld on 2016-04-14T06:19:54.640590+00:00)
Java lexer: add "import static" (fixes #1228)
→ <>

(Original comment by benromberg on 2016-04-14T07:39:35.675563+00:00)
Splendid, thanks for the swift resolution!


[FEATURE] Submit RetryPushData immediately encountering DIRECT_MEMORY exceeding of worker

Is your feature request related to a problem? Please describe.
I'm always frustrated when DIRECT_MEMORY_COUNTER of netty exceeds the offheapMemoryCriticalThreshold, worker will set AutoRead from true to false in GlobalChannelLimiter, which will not fire ChannelRead, and, in turn, worker won't reply any message to executor, so shuffle writer will wait until timeout without reviving and requesting for new slots to submit RetryPushData.
Describe the solution you'd like
Shall we reply some specific message to executor when worker finds the exceeding of DIRECT_MEMORY, so executor can  submit RetryPushData immediately?
Describe alternatives you've considered
I just expand RSS_WORKER_OFFHEAP_MEMORY of worker for now.
/cc @who-need-to-know
@FMX
/assign @who-can-help-you

@miaoxf
The worker`s minimum direct memory should be larger than num of cores * 16(MB). Because we use pooled memory allocator.
Can you share your host information and configurations?

Seems like a bug, I think we should add more test cases @FMX

@miaoxf
If you are convenient, you can join the chat.
I think there is an alternative solution rather than changing RSS_WORKER_OFFHEAP_MEMORY.

with pleasure


Fixed table of contents

Weird, it's still not working for me. I tested via https://github.com/robusta-dev/robusta/blob/a7274551e34d2312cb84681a09b4be9da77bd47f/README.md#📒-installing-robusta
I click on links in the table of contents, but I don't jump to the new location.

Weird, it's still not working for me. I tested via https://github.com/robusta-dev/robusta/blob/a7274551e34d2312cb84681a09b4be9da77bd47f/README.md#📒-installing-robusta
I click on links in the table of contents, but I don't jump to the new location.

We'll yea, it worked locally and the "emojies" are messing up, guess that's why I did not add them in the first place when I changed the README.
Here is a slightly modified version, except "How it works” and "Contacts" the others are working. Not sure why. https://github.com/robusta-dev/robusta/blob/readmefixtest/README.md#-installing-robusta. Let me know how to proceed.

Can we just get rid of the table of contents then? Better to leave it out then have something broken.

Yes, let's take it out. Looks like GitHub gives you a ToC by default. Closing this issues, will create a new PR.


BugFix-blocking of blank values insertion on the Credential page.

What is this PR for?
This PR blocks the blank values insertion on the Credential page and
changes the success message box to zeppelin's dialog box.
What type of PR is it?
Bug Fix
How should this be tested?
Try to save with blank values on the Credential page.
Screenshots (if appropriate)

before

after

Questions:

Does the licenses files need update? no
Is there breaking changes for older versions? no
Does this needs documentation? no

@bzz I fixed as your comments. please review.

LGTM 👍

Thank you!
Looks good to me, mering if there is no further discussion


Work around coveralls parallel upload issue

This is an attempt to work around an issue with coveralls where push CI builds don't seem to handle parallel uploads correctly.
https://github.com/lemurheavy/coveralls-public/issues/1403 seems to be the same/a similar type of issue
So instead of using parallel upload I'm just having it merge all the files together before doing the upload.

Go for it! This seems like it'd be a good solution


Contribution guide

Problem: This is a great package and people like me want to contribute while fitting into the current flow of the existing contributors.
Solution: CONTRIBUTING.md or some other approach to providing a guide (however brief) into what is expected for an effective contribution. 🎉

This is a fine idea. I've canvassed some examples for perusal:
Node
Gutenberg

I've pushed a quick write up of a contribution guide, which I'll add to over time.


generate voucher button is disabled

steps:

generate a voucher
copy to clipboard
click on the generate voucher
form has the generate disabled

update, issue happens when you set length to 3

tested again on a more modern setup, works without issues.


[ALLUXIO-1916] Increase waitForPersist timeout

https://alluxio.atlassian.net/browse/ALLUXIO-1916
We'll see if increasing this timeout prevents flakiness

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/9533/
Test PASSed.

Merged build finished. Test PASSed.

LGTM


sequence comparison not working properly

Comparing sequences with different types should work. The following code is failing:
assert (1,) < (1.2,)
assert [1,] < [1.2,]

TypeError: unsupported operand type(s) for <: 'int' and 'float'

Ran into this while running ipy -m pip list -v where the failing code is basically as follows:
class Infinity(object):
    def __gt__(self, other):
        return True

assert (tuple(),) < (Infinity(),)

TypeError: unsupported operand type(s) for <: 'tuple' and 'Infinity'

Looks like this is failing because (1).__lt__(1.2) is NotImplemented (as it should be), however once that fails it should be trying the reversed comparison (1.2).__gt__(1).


chore(update):

update to work with the aurelia-framework 0.15.0 release
@PWKad One more issue to make it work with the updated aurelia release - updated the dependencies.  (It's not just cosmetic, it was actually causing issues for me)

Hey was testing these changes out to see why it was making changes to System.config on the config.js file.  Looks good, re-opening and merging.

:+1:

If you get a chance can you verify the tests are running for you after the upgrade?  I can't seem to get them to with the newest JSPM.

Sure, I'll do that now


feat(windows): add subzone worker subprocess crate from abandoned IPC branch

I wasn't sure if we should try to preserve the Git history at all, so I just stuck it in a folder in the same repo.
This branch is identical to main but has the crate. The subzone branch has a version of the Windows client that builds on top of subzone.

It would be more useful on its own, I agree we probably won't need it. If we get stuck on webrtc-rs we can just use this crate as a dependency

If we get stuck on webrtc-rs we can just use this crate as a dependency

I'll do what is within my powers to avoid this!

My vote would go down for moving this into a separate repo

Ah yeah, that sgtm. We can always choose to publish later on crates.io but not the other way around.  @ReactorScram made you admin on https://github.com/firezone/subzone so you should be able to stick it there.

Okay I'll move the code there, link this PR for the Git history, and then close this

It's up and I copied some of the clippy / fmt / test CI from the main Firezone repo https://github.com/firezone/subzone


Issue with canceling XHR request using promises - fixed

Fixes #10890 and #9332.

Done

This fix will be add in a next version ?

Hi
We're also experiencing this problem(#9332). See this plunker: http://plnkr.co/edit/vk9HUd?p=preview . With angular 1.2.28, it work as expected (i.e. the pending request is cancelled. I use the throttling control feature in DevTools to easily observe this).
The PR proposed here works fine for us. What is the status on this?
Please let us know if we can help you in any way.

The patch looks good. It would be nice to get it merged in the next release. I checked the logs, I'm not sure why Travis CI is complaining.

What's the timeline on reviewing / merging this? We're hitting this problem too; made a local workaround but it would be nice to have it baked in.

+1 to @bborowin's comment running into this issue as well. How did you work around it?

Can somebody merge this?

Looks good to me. Make sure subsequent requests can be cancelled start the first one has been,i recall there was an issue with that before

@caitp Can you give me an example? I did not understand your answer.

Hi @caitp
I created a jsbin example (From PR #12525 ) to show how this fix works. Please have a look at http://jsbin.com/hoxuhotupe/edit?html,js,console,output
If multiple requests are running, resolving the promise will cancel them all (Try clicking the 'create button' multiple times quickly and then click the 'cancel request' button. See the console output).
After you cancel a request, you can create a new request and it will not be interrupted. (Click the 'create request' button, then click the 'cancel request' button. Click the 'create request' button again and wait a few seconds. See that the request completed successfully).
This is the same behavior as was present in 1.2.x. It would be very helpful if the regression was fixed.

this PR has gotten extremely hard to understand, I'm not entirely sure which comments apply to the pr/issue and which ones apply to the other commits. Do you think you could rebase this and force push just so it's easier to read?

@caitp see #12525 . It contains just the relevant commit

Okay, thanks for the verification @okiss. The diff has gotten really screwed up and the PR has been closed, so it can't really be reviewed or merged.

What about the #12525 ? It is more recent, is it messed up as well?

Probably, it's the matter branch, bad idea

@caitp Can you have a look at #12657. @netman92 has rebased properly.


clientv3/integration: test lease closed connection

Tests if lease operations return ErrConnClosed when
the client is closed.

/cc @heyitsanthony Thanks!

lgtm


Error 'no timestamp' when using using url to load external javascripts

When I configure require.js to use an external javascript like:
// on require-config.js
paths: {
'jquery': 'http://code.jquery.com/jquery-2.0.3'
}
I get: ERROR: 'There is no timestamp for http://code.jquery.com/jquery-2.0.3.js!
Should I do something different to make it work?

What would the impact be of changing the regex to also allow external links that don't specify protocol? One of my tests is loading a file that then loads an external resource from //example.com/file.js and I haven't been able to track down if it is Karma, karma-requirejs, or jasmine that is having trouble with it.

Try changing the regex in your local karma installation and look if it works out. I think if you want to make a PR to also match // I'll consider. ( I don't think it will break anything, at least nothing that I know of)


Use Pylint message names instead of codes

For #2906

[x] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
[x] Title summarizes what is changing
[x] Has a news entry file (remember to thank yourself!)
[x] ~Unit tests & system/integration tests are added/updated~
[x] ~Test plan is updated as appropriate~
[x] ~package-lock.json has been regenerated by running npm install (if dependencies have changed)~

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: RomanKornev sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Thanks for the PR @RomanKornev. We will review this PR and have feedback for you at minimum by the end of December.

Thanks for the super fast answer! I'm glad to contribute.

Update CI

Much nicer experience for everyone using pylint. I've tested this locally, and since it is passing the PR-validation checks, I'm going to accept this PR.
Thanks @RomanKornev!


Use Builder for code generation

Switch from the manual code generation step to using Builder. An example for this scenario (thanks @kevmoo) can be found here:
https://github.com/dart-lang/build/blob/master/example/lib/example.dart#L11-L30
A few notes for myself:

Input will be a file (tool/win32api.json or similar)
Output will be *.g.dart or similar
Need to keep the buildExtensions and build.yaml entries consistent
Can write multiple output files from one input file in the build() method

Jake is the right go-to person.

From https://github.com/dart-lang/build/blob/master/docs/writing_a_builder.md:

A Builder must have outputs that are known statically based on input paths and file extensions. For example an input named foo.dart always results in an output named foo.something.dart. Builders are not allowed to read the input in order to determine outputs. The only outputs that can be produced are those which share a file base name with an input.

https://github.com/dart-lang/build/blame/master/docs/writing_an_aggregate_builder.md suggests that a builder can take multiple inputs, but still only one output. This may invalidate build as a useful way for us to create our projection, since we don't really want to either a) create a separate input file for every output file, or b) create a single output file for all inputs.

Yes, I noticed that too, and was about to tell you about it.


E_ILLEGAL_DELEGATE_ASSIGNMENT when using futures::future::join_all on multiple IAsyncOperations

I was testing the newly added async support and noticed that when using futures::future::join_all on multiple IAsyncOperations, I'm getting the E_ILLEGAL_DELEGATE_ASSIGNMENT errors frequently (but not always).
As an example, the following works every time in C#:
static async Task Main(string[] args)
{
    var devices = await Task.WhenAll(args.Select(a => BluetoothLEDevice.FromBluetoothAddressAsync(ParseBtAddress(a)).AsTask()));
    Array.ForEach(devices, Console.WriteLine);
}

but the following in Rust:
async fn async_main() {
    let futures = std::env::args().skip(1)
        .map(|arg| {
            let addr = parse_bt_address(&arg);
            BluetoothLEDevice::from_bluetooth_address_async(addr).unwrap()
        });

    let results = join_all(futures).await;
    println!("{:?}", results);
}

frequently fails with something like:
[Ok(BluetoothLEDevice(Some(0x197cde26070))), Err(Error { code: 0x80000018, message: "A delegate was assigned when not allowed." })]

The full sample programs are available here:

C#: https://gist.github.com/chenxiaolong/ce5a924357212599b579928ba9c38e2d#file-async_csharp-cs
Rust: https://gist.github.com/chenxiaolong/ce5a924357212599b579928ba9c38e2d#file-async_rust-rs

I'm testing with ./<prog>.exe aa:bb:cc:dd:ee:ff 00:11:22:33:44:55 (except with valid bluetooth addresses). I'm using the latest commit of winrt-rs (currently 2edcccde71df2a33bd4fe5355751b8507a9d5b49). With the Rust version, sometimes the first future errors out, sometimes the second. Very rarely, both succeed.
Any ideas what might be going on?

The WinRT async pattern forbids multiple completed callbacks. The second atttempt to set a completed callback returns E_ILLEGAL_DELEGATE_ASSIGNMENT. C# avoids this by wrapping and abstracting away the async pattern entirely. This is convenient but rather costly. I'll look into why this is happening in Rust. It may be that the Future trait implementation may need a check to avoid this in some cases.
https://github.com/microsoft/winrt-rs/blob/2edcccde71df2a33bd4fe5355751b8507a9d5b49/crates/gen/src/types/futures.rs#L93-L96

Would using Once::call_once be a way to ensure that the callback is set only once?

Probably, I'd just like to understand why poll is being called twice to cause this to happen. Ideally, the Future is only called once and then the Waker brings it back to life.

I asked on the Rust Community Server, and apparently Future executors are allowed to poll Futures without wakeups. The join_all function in particular takes advantage of this and polls every future given to it when even one is woken up, leading to the callback being registered twice. Furthermore, every call to poll must update stored Waker values, like the one in the callback handler. The Rust Async Book confirms this. I also created a simple example on Rust Playground to demonstrate this behavior.
Since we need to somehow update the Waker inside the callback, simply using Once is not enough. Instead of dealing with Wakers direcly, maybe we could use something like futures's oneshot channel to bridge the gap between Winrt's and Rust's async systems. However, that we would need a place to store the reciever. I think it would make the most sense to provide something like a get_future method that returns a Rust struct  that wraps an IAsyncOperation instead of directly implementing Future for IAsyncOperations.

Yes, it may be best simply to hide the IAsyncXxx from Rust completely and only expose a Rust-friendly wrapper at the API boundary. Sorry for the delay, I've been occupied with other issues but I hope to look at this issue again soon.

I came up with a simpler fix: https://github.com/microsoft/winrt-rs/pull/340

That looks like a good fix for the short term. In the future though we should find a way to somehow update the Waker in that handler function to properly integrate with the Rust async system.

The waker will still be used - just from the first poll.

According to the Rust Async book, the Waker used in future polls may be different from the one from past polls.
The import part:
"Importantly, we have to update the Waker every time the future is polled because the future may have moved to a different task with a different Waker. This will happen when futures are passed around between tasks after being polled."
So I guess if you pass the current futures between tasks, they'll just won't be polled and never complete.

Hmm that seems very implementation specific. 😕 Hopefully, this works reliably in practice.

Well it's hopefully an improvement. Do take it for a spin and let me know how it works. We can continue to improve it as needed.

Hmm that seems very implementation specific.

Yeah it seems kind of annoying. I think the general idea was to give future executor devs a lot of freedom since there isn't really one target runtime for futures.

Well it's hopefully an improvement. Do take it for a spin and let me know how it works. We can continue to improve it as needed.

Ok, thanks for the fix!


Crash: Non [a-z0-9/._-] character in path of location: forgero:forgero_guide_book_recipe_forgero:bindings

version: forgero-fabric-full-0.10.4-BETA-1.19.2.jar

Seems like there's a typo in the patchouli guidebook recipe generator. I'll upload a patched version and set up a Gametest to run on the compat module to catch these errors.


Timeline Configuration

A configuration tool for combing multiple timeline graphs and sections into the same view stacked on top of each other:

Ability to add multiple attribute graphs as well as track graphs to the same view stacked on top of each other
Can have a setting to hide/show sub graphs in the list by the user
Possibily have the detection/event viewer in the customization as well.
Some sort of configuration tool for injecting and displaying multiple graphs.

TODO:

[ ] The Timeline Configuration on ControlsContainer.vue needs to be swapped out for I believe a few custom components:
[ ] Timeline Button - will display standard buttons for individual items and a custom interface for a custom stacked timeline.  This will incorporate the Event/Detections, Attribute Timelines, Swimlanes, and Filter Timelines.  If too many are visible on screen (>3) it will turn into a dropdown.
[ ] The Timeline itself will be swapped to a new component that can switch between the visible timelines or display a stacked timeline
[ ] Stacked Timelines needs to have a way to turn invidiual sections on/off as well as provide a Key for each timeline.


Error - One of your plugins requires a parameter: SENDER_ID

Iam using  https://build.phonegap.com/apps for builds.  After uploading source code to the site. It gives me  below error for Android build.

Error - One of your plugins requires a parameter: SENDER_ID - You can fix this here

But in my config.xml  file .
<plugin name="phonegap-plugin-push" source="npm">
    <param name="SENDER_ID" value="123456789" />
</plugin>

and on
var push = PushNotification.init({
                    "android": {
                        "senderID": "123456789"
                    },
                    "ios": {"alert": "true", "badge": "true", "sound": "true"},
                    "windows": {}
                });

can anybold help me to solve the issue. Thanks.

I can't remember where I found this, but maybe that's what you are looking for?
cordova plugin add phonegap-plugin-push --variable SENDER_ID=123456789

@sreereddymenon that looks correct to me.

I can confirm that!
I've just opened this issue (don't know if it might be related).  https://github.com/phonegap/phonegap-plugin-push/issues/745
After modifying config.xml to update to cli 6.0.0 to see if I can get version 1.6.0 to work, PGB now gives me that error (although right now my problem is in iOS)

I have been having this issue with exactly the same content. I installed with cli 6.1 Does this have to do with the cli version? It shouldn't affect the install right? I specify
 <preference name="phonegap-version"           value="cli-5.2.0" />
but i am still getting the same error from the build. I would also like to note that did install the plugin using the --variable SENDER_ID because it is required through the cli and I have
"Android Support Library version 23 or greater
Android Support Repository version 20 or greater
Google Play Services version 27 or greater
Google Repository version 22 or greater"
Installed as well. I would really appreciate any help with this. I havent attempted downgrading my cli version but I am kinda hoping to avoid that.

@sreereddymenon any update on this issue? I have been having the same issue in phonegap build with the same content I tried installing the 1.6.0 version and the 1.5.2 just in case. I have everything installed in the android sdk manager, installing the plugin through the cli which requires the --variable SENDER_ID, and have the same config and js, even used the example www/ for the content portion to get something going.

any solution for this?

Also having this issue with PhoneGap Build. Looking for a solution.

Setting params worked.. Thanks


[docker] simplify the log handling of sshd

By default sshd forwards any log messages to the syslog. As docker containers do not have access to the syslog daemon on the docker-host, a new daemon was added into the container https://github.com/gogs/gogs/pull/1898.
This indirection is actually not needed. We can get the log messages directly into the docker container log.
Using the -e flag for sshd forwards the output to stderr and with a stream redirect we can get the output to stdout.
Startup and invalid auth before and after applying this patch:
# docker logs --timestamps gitea_container_syslogd | grep -e ' Server listening' -e ' user'
2019-04-06T18:15:29.117905987Z Apr  6 18:15:29 sshd[72]: Server listening on :: port 22.
2019-04-06T18:15:29.117945956Z Apr  6 18:15:29 sshd[72]: Server listening on <IP_ADDRESS> port 22.
2019-04-06T18:18:43.162626992Z Apr  6 18:18:43 sshd[84]: Connection closed by invalid user nobody 172.x.x.x port 39836 [preauth]

# docker logs --timestamps gitea_container_direct | grep -e ' Server listening' -e ' user'
2019-04-06T18:30:01.538122152Z Server listening on :: port 22.
2019-04-06T18:30:01.538175245Z Server listening on <IP_ADDRESS> port 22.
2019-04-06T18:30:41.454457822Z Connection closed by invalid user nobody 172.x.x.x port 41812 [preauth]

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@d1b8840). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #6529   +/-   ##
=========================================
  Coverage          ?   40.26%
=========================================
  Files             ?      403
  Lines             ?    54079
  Branches          ?        0
=========================================
  Hits              ?    21777
  Misses            ?    29284
  Partials          ?     3018

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1b8840...7a8b624. Read the comment docs.


Nearby caches: mixed units and not sorted by distance

I am providing a screenshot. The sort mode is set as "distance".
I am using CyanogenMod 7.1 and latest c:geo.
https://p.twimg.com/Am_BADKCAAAbSYM.png:large
Thanks so much!

Thank you for your reply: I get a coherent reply to the query now.
This leads me to two suggestions.
The first: just enable "Show captcha if necessary" by default. Why? Because one can still remove it (when appears the first time there's an explanation about what it is and how to remove it if unwanted), while if it's not "ON" by default it's quite hard to understand what is about and that it is related to get a more accurate "show nearby caches" result!
Second. Would it be possible to convert miles to meters automatically when meters are the units used in the rest of the program?
Thank you so much!

There are different opinions about the usefulness of the captcha. Most basic members use it VERY seldom if at all as it is quite tedious to use, so I fear there will not be many supporters for your suggestion.
If you have set c:geo to use meters, all units displayed by c:geo will be in meters. The miles in your screenshot are part of the graphic sent by geocaching.com, so we can't do anything about it.

As all questions are answered, I'll close this issue. Please feel free to re-open or open a new one if you experience bugs. Please consider our website (http://www.cgeo.org) as well to get more information about c:geo.

Ah! It is graphic, now I got it.
About the captcha:
Are you sure that basic members won't use it to bypass the new limitations on the live map? That's why I ended up using the "nearby caches" function, so to store caches around and be able to see them in the map. Then get there and have fun. :)
Thank you for listening either way. Cheers!

Are you sure that basic members won't use it to bypass the new limitations on the live map?

Yes. The captcha is used for several years now, it's no new limitation. We asked some basic members and they're using the captcha only really seldom.

Are you sure that basic members won't use it to bypass the new limitations on the live map?

Regarding this, let us wait and see how the new live-map (which is under development) will "look and feel" first to decide next possible steps.


Rename --mender-professional setup flag to --hosted-mender

I also went through some of the Mender Professional references in the
docs and added links to hosted mender where it seemed reasonable.
changelog: none
Signed-off-by: Alf-Rune Siqveland<EMAIL_ADDRESS>

Sorry, too late for this one but this looks ok.
In general we should not be afraid of saying "hosted Mender" I think -- just like we are saying "onpremise Mender". The only change is that we added some plans on top of it which are called "Professional" (and we should rarely refer to the plans themselves, only if we ask people to sign up or it is a prerequisite for following a tutorial).


Pass over the acquisition documentation.

I did another pass over the documentation of the acquisition function fixing typo's, added some missing doc strings, etc. Also fixed #51
I have some more question/comments which I will add as comments in the change list.

Codecov Report

Merging #55 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master      #55   +/-   ##
=======================================
  Coverage   99.73%   99.73%
=======================================
  Files          14       14
  Lines         757      757
=======================================
  Hits          755      755
  Misses          2        2

Impacted Files
Coverage Δ

GPflowOpt/acquisition/ei.py
100% <ø> (ø)
:arrow_up:

GPflowOpt/acquisition/lcb.py
100% <ø> (ø)
:arrow_up:

GPflowOpt/acquisition/pof.py
100% <ø> (ø)
:arrow_up:

GPflowOpt/acquisition/poi.py
100% <ø> (ø)
:arrow_up:

GPflowOpt/acquisition/acquisition.py
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8cc6fc...74b6fcf. Read the comment docs.


LazyFn::load needs refactoring

The LinkType::Vulkan branch needs to be refactored into another function to de-obfuscate the code.

done. moved the code to vulkan_loader.


I miss "CLEAR QUERY/VIEW" button in the new sql editor

Like we do in the current one:

Don't you @nobuti @urbanphes @saleiva ?

When we have a query applied we have the button to clear.

Ok, then I guess undo-redo buttons are close to the clear button ;). @nobuti could you take care of this?

@urbanphes but then the undo/redo?

I thought that this version we couldn't integrate the undo/redo buttons. In that case the clear button disappears and show the undo/redo.

But them the clear is simply pressing in undo?
2016-06-20 15:38 GMT+02:00 Juanma<EMAIL_ADDRESS>
I thought that this version we couldn't integrate the undo/redo buttons.
In that case the clear button disappears and show the undo/redo.
[image: image]
https://cloud.githubusercontent.com/assets/14546701/16196104/d8d3e1f6-36fc-11e6-8ec0-35dd7fdf4fc3.png
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/CartoDB/cartodb/issues/7941#issuecomment-227144246,
or mute the thread
https://github.com/notifications/unsubscribe/AAIENXRvfkf2ie5XpAH4AsCV_FiX3DZcks5qNpfZgaJpZM4I5d9X
.

--
Sergio Alvarez Leiva

Yes it is, in my opinion

Than that would imply that you apply a query automatically without pressing
the button,... and that's dangerous IMHO. Imagine clicking 10 times on undo.
2016-06-20 15:48 GMT+02:00 Juanma<EMAIL_ADDRESS>
Yes it is, in my opinion
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/CartoDB/cartodb/issues/7941#issuecomment-227146995,
or mute the thread
https://github.com/notifications/unsubscribe/AAIENQ9IEKSdkdteyQ8iST8RtwEqtrEzks5qNpo_gaJpZM4I5d9X
.

--
Sergio Alvarez Leiva

Agree with @saleiva, a bit dangerous. Let's add the clear button, is there any problem with that?

No problem but only 2 buttons. "Clear" and "Apply"

Undo, redo, clear and apply, come on @urbanphes!

Here the footer bar


OSX: fix background cell drawing (and cursor drawing)

only happens on osx, but cell backgrounds and cursor aren't rendered.

Old Input Mono.zip
Here's the version of Input Mono that seems to be causing the issue for me.

Cell background (and cursor) fixed. (with the great help of NVIDIA Nsight Graphics debugger) :)


Add explanatory comment to header.html

See #3387

r? @steveklabnik
(rust_highfive has picked a reviewer for you, use r? to override)

Nice. @bors: r+ rollup

:pushpin: Commit c9b3788 has been approved by steveklabnik

:hourglass: Testing commit c9b3788 with merge a14ddf3...

:sunny: Test successful - status-appveyor, status-travis
Approved by: steveklabnik
Pushing a14ddf39efe8d413f4e25a3b84fe0f7071d4ea6e to master...


Create pages-en_GB.json

Localised British English language file.

Sorry, I closed this PR by accident.

Hi Justin,
thanks for your contribution. would you like to change some phrases too ? it doesn't sounds very british imho ?!
br, Andi

I'd be more than happy to! I agree the passing found change, I just wasn't sure if I was allowed to. I will get in it! On 19 Feb 2018 12:03 p.m., Andi Dittrich<EMAIL_ADDRESS>wrote:Hi Justin,
thanks for your contribution. would you like to change some phrases too ? it doesn't sounds very british imho ?!
br, Andi
—You are receiving this because you modified the open/close state.Reply to this email directly, view it on GitHub, or mute the thread.

PS: Forgive my typos in the comment above. Here I am, talking about changing text grammatically yet my comment is almost incoherent :-D
I was on the go when typing my response and my auto-correct really let me down.


[android] Minor: Non-translatable string

Good find!

Now if you translated it in others you might have to delete it from all of them.


Fix to save zero length data to column via isam cursor

Currently it is not possible to store zero length data via isam cursors because ColumnAccessor.SetColumn does not respect/set SetColumnGrbit.ZeroLength (like  EsentInterop.SetColumnHelpers does). Therefore System.DBNull is returned e. g. in the case if String.Empty is stored to a column.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: tom-lei sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


[Feature Request] On manual URLs, populate metadata from icy-* headers

Hi there - I have a private Icecast stream running that I'd like to add to the app, and still display a name, description, etc.
It would be great if, when using a custom URL, the app could parse the various icy- headers and use that to populate the title, bitrate etc, so it displays in the radio station list with the title rather than the URL without the need to edit.

Hi,
This does not sound bad.
Can you paste me your stream link to test here ?


Install NUT to NUT with my Eaton PX5 2200

Make a new vm and install NUT there or install NUT zabbix
make sure NUT uses local interface eg 127.xxx.xxx.xxx
Steal Get a usb b-type cable from work.
https://www.zabbix.com/integrations/ups
https://github.com/delin/Zabbix-NUT-Template
https://networkupstools.org/documentation.html
https://tripplite.eaton.com/products/power-alert-local
NUT

Done.


Cloud init

It's clean and beautiful, love it!

Before merging I want to add some comments to explain why it is done this way. I'll do it this evening

Great, thanks!
Removing the ignition config also removes
sshAuthorizedKeys = concat([local.ssh_public_key], var.additional_public_keys) in there. But I see no equivalent inside the new cloud init files  - am I overlooking it or is it missing in this PR?

Good catch. I need to add it to cloud-init config.Il 27 Feb 2022 19:34, Paul Haerle @.***> ha scritto:
Great, thanks!
Removing the ignition config also removes
sshAuthorizedKeys = concat([local.ssh_public_key], var.additional_public_keys) in there. But I see no equivalent inside the new cloud init files  - am I overlooking it or is it missing in this PR?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

So @mnencia @phaer, just to clarify, qemu-img writes the image to the whole disk and even expands the partitions? No need for btrfs filesystem resize max?

So @mnencia @phaer, just to clarify, qemu-img writes the image to the whole disk and even expands the partitions? No need for btrfs filesystem resize max?

It is done automatically by cloud-init at the first start. The same is true also with combustion: if you search the startup logs you see it tries to expand /var partition to maximum size.

Oh wow, ok, thanks for the explanation!


why not support the Python3

Hi, I use the Python3 and run your code, I find must change something, like / to //, print 'xxx' to print('xxx').
why not import  _future_  and make sure the code can support 2.7 and 3?
and in GridWorld, the env take action, it always return done is False?

Hi,
Adding Python3 support is something I would definitely like to do when I have time. Unfortunately when I began the series I did it purely with Python2. If you have happened to convert any of the notebooks to python 3, please consider a pull request, as I would be happy to integrate them into the notebook.
In Gridworld this functionality exists in case you might want to add a block which causes the episode to end early. For example, having the episode end once finding a goal.

Hi,
I change some file to support the py3. Some error when I install vizdoom, so I don't change it.
And you ues targetOps = updateTargetGraph(trainables,tau) in Deep-Recurrent-Q-Network.
But in helper.py you just create the updateTargetGraph(tfVars). so I don't know how to change this file.

I will go through the A3C myself to ensure it is python 3 compatible. Thanks again for making the changes that you did.

@wwxFromTju , if you have successfully installed vizdoom under Python3, I think the code is compatible under Python3 if you change print to print() in helper.py. I can run the code under Python3.x. If you are a Chinese user, make sure you can download freedoom-0.10.1.zip due to GFW.


[DataTiling] Add supports for materializing elementwise ops. (#15446)

This PR adds a conversion case for element-wise linalg.generic ops and fixes a bug where the element type of original_type was used for conversion in some places.

Reintroducing https://github.com/openxla/iree/pull/15446. Collision at head caused the test introduced by this commit to fail. The test is fixed in this PR.


Update common-jvm for CommandLineTesting.

This change is

Depends on https://github.com/world-federation-of-advertisers/common-jvm/pull/210


Update attachments-and-ews-in-exchange.md

Docs Build status updates of commit bbc7767:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/exchange-web-services/attachments-and-ews-in-exchange.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Activefield->checkbox() causes browser to link label to wrong input

Yii Version 2.0.0
Browser Firefox 31.2.0 on Linux
Activefield->checkbox() generates, with the default behaviour, a hidden input additionally to the checkbox input.
The label for the checkbox input though isn't connected via for, but by enclosing the input by the label tag. What follows is a label linked to a hidden input (well, at least it isn't linked to the visible one, I think ff just takes the first input tag):
View code:
<?=$form->field($model, 'ignoreWeakPassword')->checkbox() ?>

Generated HTML:

	<input type="hidden" value="0" name="SignupForm[ignoreWeakPassword]">
	<input type="checkbox" value="1" name="SignupForm[ignoreWeakPassword]" id="signupform-ignoreweakpassword">
	Ignore Weak Password

Fixed, thanks for reporting!


CB-8500 Documentation update for signing property name change

Do we still want this change given that both gradle and ant-style are accepted? I'm thinking no since I find gradle-style makes more sense. If so, though, need to fix key.storeType -> key.store.type

I'm OK with not changing the docs here. I'll close this PR.


Cleaner whitespace

I read your article and tried it out. One thing that bothered me were all the empty lines in the generated service. ERB has a great feature to suppress those, so I put it to use. I also added the magic comment for modern Ruby 2 conventions, so Rubocop won't complain and add it.

@walterdavis Thank you so much for you contribution! You are absolutely right about this. I will merge it, I just have some question about indentation that I will leave as a comment in the PR.
Once again, I appreciate your great remarks :)

I'm going to go out on a limb here and guess that you are using tabs in your editor. That's another beef that Rubocop will have with you...

You're right, tabs were the issue. Okay, I'm merging this, thanks a lot for your help! 👍

I just pushed a couple more changes, I started looking deeper into the code and found some more opportunities for improvement. Please let me know if you'd like a separate MR for those, as they stray from the topic of whitespace.

It will be fine as is regarding separate PRs. Great changes, it really improved readability and cleaned up the code real nice. It will be merged in few minutes.


Define Tooltip width decoupling from parent

Follow up ticket to #762
Analyze whether it is possible to make the tooltip adjust to a component width while the parent/tooltip trigger is inside the above component. The arrow still points to the tooltip trigger.
See:

https://github.com/SchwarzIT/onyx/issues/574


Movies are black screen after In-Game

Main Menu>Play Movie = Movie works!
Main Menu>In-Game>Main Menu>Play Movie = Black screen with audio

Solved by 5b2abe8ebb34338b5b0f576fd66e4887a939a47b.


[BUG] The lock supplied is invalid. Either the lock expired, or the message has already been removed from the queue.

Describe the bug
I am getting the following error in Kotlin Spring Boot application:
The lock supplied is invalid. Either the lock expired, or the message has already been removed from the queue. The Message lock duration of the queue is set to 1 minute, but it happens that the same message gets received 3 times in one minute.
I assume this happens while trying to complete a message. I found similar issue on Stackoverflow and the solution was to set prefetchCount=0, disableAutoComplete, maxAutoLockRenewDuration to 0 which I already use. We have never had this problem before and it started happening when we switched to the com.azure:azure-messaging-servicebus:7.15.0.
Exception or Stack Trace
com.azure.messaging.servicebus.ServiceBusException: The lock supplied is invalid. Either the lock expired, or the message has already been removed from the queue. For more information please see https://aka.ms/ServiceBusExceptions . Reference:53d2e560-59e6-4e3a-8336-b6bedd2e7f20, TrackingId:57a278b30000004d0000315a6666e4e0_G0_B15, SystemTracker:gi::G0:38162340:vil-command-queue_3064e8_1718019170742, bi::in-connection934(G0-2749081)::session935::link12634, Timestamp:2024-06-13T11:47:31, errorContext[NAMESPACE: westeurope-eu-e-servicebus.servicebus.windows.net. ERROR CONTEXT: N/A, PATH: vil-command-queue, REFERENCE_ID: vil-command-queue_3064e8_1718019170742, LINK_CREDIT: 9]
	at com.azure.messaging.servicebus.ServiceBusReceiverAsyncClient.lambda$updateDisposition$50(ServiceBusReceiverAsyncClient.java:1659)
	at reactor.core.publisher.Mono.lambda$onErrorMap$28(Mono.java:3783)
	at reactor.core.publisher.FluxOnErrorResume$ResumeSubscriber.onError(FluxOnErrorResume.java:94)
	at io.opentelemetry.javaagent.shaded.instrumentation.reactor.v3_1.TracingSubscriber.onError(TracingSubscriber.java:85)
	at io.opentelemetry.javaagent.shaded.instrumentation.reactor.v3_1.TracingSubscriber.onError(TracingSubscriber.java:85)
	at reactor.core.publisher.FluxPeek$PeekSubscriber.onError(FluxPeek.java:222)
	at io.opentelemetry.javaagent.shaded.instrumentation.reactor.v3_1.TracingSubscriber.onError(TracingSubscriber.java:85)
	at reactor.core.publisher.FluxDoOnEach$DoOnEachSubscriber.onError(FluxDoOnEach.java:195)
	at io.opentelemetry.javaagent.shaded.instrumentation.reactor.v3_1.TracingSubscriber.onError(TracingSubscriber.java:85)
	at reactor.core.publisher.FluxOnErrorResume$ResumeSubscriber.onError(FluxOnErrorResume.java:106)
	at reactor.core.publisher.Operators.error(Operators.java:198)
	at reactor.core.publisher.MonoError.subscribe(MonoError.java:53)
	at reactor.core.publisher.Mono.subscribe(Mono.java:4495)
	at reactor.core.publisher.FluxOnErrorResume$ResumeSubscriber.onError(FluxOnErrorResume.java:103)
	at io.opentelemetry.javaagent.shaded.instrumentation.reactor.v3_1.TracingSubscriber.onError(TracingSubscriber.java:85)
	at reactor.core.publisher.MonoIgnoreThen$ThenIgnoreMain.onError(MonoIgnoreThen.java:278)
	at io.opentelemetry.javaagent.shaded.instrumentation.reactor.v3_1.TracingSubscriber.onError(TracingSubscriber.java:85)
	at reactor.core.publisher.Operators$MonoSubscriber.onError(Operators.java:1886)
	at reactor.core.publisher.MonoCacheTime$CoordinatorSubscriber.signalCached(MonoCacheTime.java:340)
	at reactor.core.publisher.MonoCacheTime$CoordinatorSubscriber.onError(MonoCacheTime.java:363)
	at io.opentelemetry.javaagent.shaded.instrumentation.reactor.v3_1.TracingSubscriber.onError(TracingSubscriber.java:85)
	at reactor.core.publisher.MonoCreate$DefaultMonoSink.error(MonoCreate.java:201)
	at com.azure.core.amqp.implementation.handler.ReceiverUnsettledDeliveries$DispositionWork.onComplete(ReceiverUnsettledDeliveries.java:782)
	at com.azure.core.amqp.implementation.handler.ReceiverUnsettledDeliveries.completeDispositionWorkWithSettle(ReceiverUnsettledDeliveries.java:575)
	at com.azure.core.amqp.implementation.handler.ReceiverUnsettledDeliveries.handleRetriableRejectedRemoteOutcome(ReceiverUnsettledDeliveries.java:431)
	at com.azure.core.amqp.implementation.handler.ReceiverUnsettledDeliveries.onDispositionAck(ReceiverUnsettledDeliveries.java:255)
	at com.azure.core.amqp.implementation.handler.ReceiverDeliveryHandler.handleSettleViaDisposition(ReceiverDeliveryHandler.java:304)
	at com.azure.core.amqp.implementation.handler.ReceiverDeliveryHandler.onDelivery(ReceiverDeliveryHandler.java:113)
	at com.azure.core.amqp.implementation.handler.ReceiveLinkHandler2.onDelivery(ReceiveLinkHandler2.java:152)
	at org.apache.qpid.proton.engine.BaseHandler.handle(BaseHandler.java:185)
	at org.apache.qpid.proton.engine.impl.EventImpl.dispatch(EventImpl.java:108)
	at org.apache.qpid.proton.reactor.impl.ReactorImpl.dispatch(ReactorImpl.java:324)
	at org.apache.qpid.proton.reactor.impl.ReactorImpl.process(ReactorImpl.java:291)
	at com.azure.core.amqp.implementation.ReactorExecutor.run(ReactorExecutor.java:91)
	at io.opentelemetry.javaagent.shaded.instrumentation.reactor.v3_1.ContextPropagationOperator$RunnableWrapper.run(ContextPropagationOperator.java:358)
	at reactor.core.scheduler.SchedulerTask.call(SchedulerTask.java:68)
	at reactor.core.scheduler.SchedulerTask.call(SchedulerTask.java:28)
	at java.base/java.util.concurrent.FutureTask.run(Unknown Source)
	at java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(Unknown Source)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
	at java.base/java.lang.Thread.run(Unknown Source)
	Suppressed: java.lang.Exception: #block terminated with an error
		at reactor.core.publisher.BlockingSingleSubscriber.blockingGet(BlockingSingleSubscriber.java:103)
		at reactor.core.publisher.Mono.block(Mono.java:1712)
		at com.azure.messaging.servicebus.ServiceBusReceivedMessageContext.complete(ServiceBusReceivedMessageContext.java:104)
		at infrastructure.adapters.inbound.consumers.messagebroker.AzureServiceBusMessageProcessor$processMessageInTenantAndMdcContext$1.invoke(AzureServiceBusMessageProcessor.kt:58)
		at infrastructure.adapters.inbound.consumers.messagebroker.AzureServiceBusMessageProcessor$processMessageInTenantAndMdcContext$1.invoke(AzureServiceBusMessageProcessor.kt:55)
		at infrastructure.adapters.inbound.consumers.command.messagebroker.ServiceBusMessageInVehicleContextExecutor.processMessageInVehicleContext(ServiceBusMessageInVehicleContextExecutor.kt:38)
		at infrastructure.adapters.inbound.consumers.messagebroker.AzureServiceBusMessageProcessor.processMessageInTenantAndMdcContext(AzureServiceBusMessageProcessor.kt:55)
		at infrastructure.adapters.inbound.consumers.messagebroker.AzureServiceBusMessageListener.registerMessageListener$lambda$0(AzureServiceBusMessageListener.kt:42)
		at com.azure.messaging.servicebus.MessagePump.notifyMessage(MessagePump.java:157)
		at com.azure.messaging.servicebus.MessagePump.lambda$handleMessage$3(MessagePump.java:142)
		at com.azure.messaging.servicebus.implementation.instrumentation.ServiceBusReceiverInstrumentation.instrumentProcess(ServiceBusReceiverInstrumentation.java:94)
		at com.azure.messaging.servicebus.MessagePump.handleMessage(MessagePump.java:135)
		at com.azure.messaging.servicebus.MessagePump$RunOnWorker.lambda$apply$0(MessagePump.java:212)
		at reactor.core.publisher.MonoRunnable.subscribe(MonoRunnable.java:49)
		at reactor.core.publisher.Mono.subscribe(Mono.java:4495)
		at reactor.core.publisher.MonoSubscribeOn$SubscribeOnSubscriber.run(MonoSubscribeOn.java:126)
		at io.opentelemetry.javaagent.shaded.instrumentation.reactor.v3_1.ContextPropagationOperator$RunnableWrapper.run(ContextPropagationOperator.java:358)
		at reactor.core.scheduler.WorkerTask.call(WorkerTask.java:84)
		at reactor.core.scheduler.WorkerTask.call(WorkerTask.java:37)
		... 5 more
Caused by: com.azure.core.amqp.exception.AmqpException: The lock supplied is invalid. Either the lock expired, or the message has already been removed from the queue. For more information please see https://aka.ms/ServiceBusExceptions . Reference:53d2e560-59e6-4e3a-8336-b6bedd2e7f20, TrackingId:57a278b30000004d0000315a6666e4e0_G0_B15, SystemTracker:gi::G0:38162340:vil-command-queue_3064e8_1718019170742, bi::in-connection934(G0-2749081)::session935::link12634, Timestamp:2024-06-13T11:47:31, errorContext[NAMESPACE: westeurope-eu-e-servicebus.servicebus.windows.net. ERROR CONTEXT: N/A, PATH: vil-command-queue, REFERENCE_ID: vil-command-queue_3064e8_1718019170742, LINK_CREDIT: 9]
	at com.azure.core.amqp.implementation.ExceptionUtil.toException(ExceptionUtil.java:90)
	at com.azure.core.amqp.implementation.handler.ReceiverUnsettledDeliveries.handleRetriableRejectedRemoteOutcome(ReceiverUnsettledDeliveries.java:408)
	... 17 more

To Reproduce
I was not able to reproduce this bug locally. It happens only during the application usage in an AKS.
Code Snippet
This is the code I am using to configure service bus client:
val processorClient: ServiceBusProcessorClient = serviceBusClientBuilder
            .credential(serviceBusFullyQualifiedName, DefaultAzureCredentialBuilder().build())
            .processor()
            .queueName(queueName)
            .processMessage(handler)
            .processError { context -> processError(context) }
            .maxConcurrentCalls(10)
            .disableAutoComplete()
            .maxAutoLockRenewDuration(Duration.ZERO)
            .prefetchCount(0)
            .buildProcessorClient()
processorClient.start()

Expected behavior
I am not expecting to receive such an error and the same message should not be received three times in one minute when the lock interval is 1 minute.
Setup (please complete the following information):

OS: Linux
Library/Libraries: com.azure:azure-messaging-servicebus:7.15.0
Java version: 21
App Server/Environment: AKS
Frameworks: Spring Boot

Observing the same on 7.15.1 for subscription workers

Thank you for reporting this!
As a first step, could you please try updating to the latest (stable) azure-messaging-servicebus version which is 7.17.0 at the moment. It has improvements around internal errors reporting and would help to investigate the issue.
Also, we just published an update to the troubleshooting guide regarding lock being lost. Please take a look.
While some level of such errors caused by transient issues is inevitable, this

Message lock duration of the queue is set to 1 minute, but it happens that the same message gets received 3 times in one minute.

does not look like a transient issue.
Do you happen to have some logs related to such messages? Are there any errors in the logs around that time?
Also, it seems you have OTel enabled (based on the stack trace) - do you happen to have some spans for these message processings recorded? They should have correlated calls for completions/abandonment/lock renewal operations.
Please share logs and traces that you have.
Here's the details on how to enable logs and distributed tracing.


Keyword 'tfn' mssing from Australian Tax File Number definition

Keyword 'tfn' mssing from Australian Tax File Number definition documentation, but is in the policy definition:

australian business number
marginal tax rate
medicare levy
portfolio number
service veterans
withholding tax
individual tax return
tax file number
tfn

---
#### Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0c16b548-1fc9-2765-3e8a-7559be41fd9d
Version Independent ID: 7fe5f4ba-e53d-d86d-4ab9-64e872e33069
Content: Sensitive information type entity definitions - Microsoft 365 Compliance
Content Source: microsoft-365/compliance/sensitive-information-type-entity-definitions.md
Service: o365-seccomp
GitHub Login: @chrfox
Microsoft Alias: chrfox

@acmcg Thank you for your feedback. We have added tfn to the keywords via PR#https://github.com/MicrosoftDocs/microsoft-365-docs/pull/2257
Thanks
Sri

queried PM for accuracy


fix(Navisworks): Adds support for Navisworks 2024

Closes #2356
Changes:
All.sln - adds ConnectorNavisworks2024 and ConverterNavisworks2024
Adds release flags for NAVMAN21 (v2024)

@AlanRynne seems good to go


ci: Setup auto release

Pull Request Test Coverage Report for Build 425886707

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 93.593%

Totals

Change from base Build 425827870:
0.0%

Covered Lines:
237

Relevant Lines:
252

💛  - Coveralls


[DE DateTimeV2] time + weekday range behaviour is inconsistent with English

Cases like "7 Uhr von Montag bis Freitag" incorrectly split the entities mixing time and the range start.
In English time and date range are returned separately, but correctly.
In other cases the interpretation is even more incomplete.
Examples:

7 Uhr von Montag bis Freitag
von Montag 7 Uhr bis Freitag 15 Uhr

@LionbridgeCSII, can you prioritize this one?


POC latest version of React-Diagrams

https://www.npmjs.com/package/@projectstorm/react-diagrams
https://github.com/projectstorm/react-diagrams
We are currently using version 5.3.2. Latest versionof 6.3.0 came out in December

Hey @LucasGrimauth when I am gone next week, this could be an interesting proof of concept to take a look into. I haven't done any preliminary reading on a migration guide - but this package is what handles all of the designer rendering logic for us. So it would be good if we can see what is new with the latest version and if there are many breaking changes (i.e. maybe the dag structure could have possibly been updated when you serialize the graph for submitting a revision).