Process error: Delivery has failed to these recipients or groups

Hello, my mail can not send  mess for everyone. And I  reciept response as:
This message couldn't be delivered because the sending email address was not recognized as a valid sender. The most common reason for this error is that the email address is, or was, suspected of sending spam. Contact the organization's email admin for help and give them this error message
How to fix it! Please process fast. I'm very need use mail

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 4c17e50d-aa8f-bd30-66af-ef4d63f02402
Version Independent ID: 92cbda3f-c3a9-ed20-2038-7e966f491934
Content: Remove blocked users from the Restricted entities page
Content Source: microsoft-365/security/office-365-security/removing-user-from-restricted-users-portal-after-spam.md
Service: microsoft-365-security
Sub-service: mdo
GitHub Login: @chrisda
Microsoft Alias: chrisda

@huyvu15, you are a non-Microsoft 365 person trying to send email into Microsoft 365? If so, see this article:
https://learn.microsoft.com/microsoft-365/security/office-365-security/mail-flow-troubleshooting
If you're a Microsoft 365 customer trying to send email, then you should open a support ticket.

To make it easier for you to submit feedback on articles on learn.microsoft.com, we're transitioning our feedback system from GitHub Issues to a new experience.
As part of the transition, this GitHub Issue will be moved to a private repository. We're moving Issues to another repository so we can continue working on Issues that were open at the time of the transition. When this Issue is moved, you'll no longer be able to access it.
If you want to provide additional information before this Issue is moved, please update this Issue before December 15th, 2023.
With the new experience, you no longer need to sign in to GitHub to enter and submit your feedback. Instead, you can choose directly on each article's page whether the article was helpful. Then you can then choose one or more reasons for your feedback and optionally provide additional context before you select Submit.
Here's what the new experience looks like.
Note: The new experience is being rolled out across learn.microsoft.com in phases. If you don't see the new experience on an article, please check back later.
First, select whether the article was helpful:

Then, choose at least one reason for your feedback and optionally provide additional details about your feedback:

Article was helpful
Article was unhelpful

Finally, select Submit and you're done!


[ADDED]: Date Picker Button

Fixes Issue
Closes #1620

Changes proposed

Added Date picker button
Screenshots

Checklist

[X] You've linked this PR to the correct issue.
[X] You have checked that the code is working correctly.
[X] You ⭐ the repository!

@TANYA-CHAN
Can you please review the PR :)


Fix for Moment depreciation.

Moment was throwing a warning about depreciated code, this should fix it.

Thx for this, I did not look at this repo for a long time. The new version 1.0.0 removed the depreciation notice, so I will close this.


images won't load in Markdown cells

Applies To

[X] Notebooks (.ipynb files)
[ ] Interactive Window and/or Cell Scripts (.py files with #%% markers)

What happened?
I've tried to insert an image in Markdown cell. All I got is a broken link. The same notebook works fine in Jupyter Notebook in a browser, and the image is clearly shown.
The image file really is in that location.
![binary](images/binary.png)

Also tried:
![binary](./images/binary.png)

VS Code Version
Version: 1.69.2 (user setup) Commit: 3b889b090b5ad5793f524b5d1d39fda662b96a2a Date: 2022-07-18T16:12:52.460Z Electron: 18.3.5 Chromium: 100.0.4896.160 Node.js: 16.13.2 V8: <IP_ADDRESS>-electron.0 OS: Windows_NT x64 10.0.19044
Jupyter Extension Version
v2022.6.1201981810
Jupyter logs
info 11:30:48.301: Got new session ab582116-10dc-4c16-8f17-a7728ad78d74
info 11:30:48.301: Started new restart session
info 11:30:48.302: kill daemon
info 11:30:48.305: Executing silently Code (idle) = import sys\nprint(sys.executable)
info 11:30:48.309: Widget Message: Received IPyWidgetMessages.IPyWidgets_onRestartKernel
info 11:30:48.310: Widget Message: Received IPyWidgetMessages.IPyWidgets_onRestartKernel
info 11:30:48.310: Widget Message: Received IPyWidgets_kernelOptions in ScriptManager
info 11:30:48.310: Widget Message: Received IPyWidgetMessages.IPyWidgets_kernelOptions
info 11:30:48.320: Widget Message: Received IPyWidgets_kernelOptions in ScriptManager
info 11:30:48.322: Widget Message: Received IPyWidgetMessages.IPyWidgets_kernelOptions
info 11:30:48.442: Executing silently Code (completed) = import sys\nprint(sys.executable) with 1 output(s)
info 11:30:48.443: UpdateWorkingDirectoryAndPath in Kernel
info 11:30:48.443: Executing silently Code (idle) = import os\nimport sys\n%cd "c:\Users\flori\Dropbox\notebooks\qiskit"\nif os.getcwd() not in sys.path:
info 11:30:48.458: Executing silently Code (completed) = import os\nimport sys\n%cd "c:\Users\flori\Dropbox\notebooks\qiskit"\nif os.getcwd() not in sys.path: with 1 output(s)
info 11:30:48.458: Waiting for idle on (kernel): ab582116-10dc-4c16-8f17-a7728ad78d74 -> idle
info 11:30:48.458: Finished waiting for idle on (kernel): ab582116-10dc-4c16-8f17-a7728ad78d74 -> idle

Coding Language and Runtime Version
Python v3.10.5
Language Extension Version (if applicable)
No response
Anaconda Version (if applicable)
No response
Running Jupyter locally or remotely?
Local

seems to be working for me. Does it render if you use the full filepath?
Can you try just running some python from that same notebook to see if it can access the file?
import os
os.path.getsize('./images/binary.png')

Keep in mind, all of this works just fine in Jupyter Notebook in a browser. It just doesn't work in VSCode.
os.path.getsize() works just fine.
The outcomes are the same on Win10 and MacOS.
This is the notebook. Keep in mind the path for the PNG is wrong in the notebook as-is in the repo.
https://github.com/Qiskit/qiskit-tutorials/tree/master/tutorials/textbook

I see a problem when the file is opened by itself. Can you try opening the entire qiskit-tutorials folder (File Open Folder...), that should let the images render (even the original, since that image is in two places). It also works on github.dev: https://github.dev/Qiskit/qiskit-tutorials/tree/master/tutorials/textbook
Not being able to render images with paths outside the workspace seems like a bug though, I'll transfer to core, since they control markdown rendering.


dart format support for records

$ dart analyze --enable-experiment=records record.dart
Analyzing record.dart...               0.4s
No issues found!

$ dart format --enable-experiment=records record.dart
Could not find an option named "enable-experiment".

$ dart --enable-experiment=records format record.dart
# and
$ dart format record.dart
# choke on record types.

Snippet that causes issues:
final returnStruct3BytesHomogeneousUint8VariadicLeaf =
    ffiTestFunctions.lookupFunction<
        Struct3BytesHomogeneousUint8 Function(Uint8, VarArgs<(Uint8, Uint8)>),
        Struct3BytesHomogeneousUint8 Function(int, int,
              int)>("ReturnStruct3BytesHomogeneousUint8Variadic", isLeaf: true);

@munificent

Duplicate of https://github.com/dart-lang/dart_style/issues/1128.


Ensure at least 1 commit

Description
This PR fixes errors by adding a check to ensure at least one commit is found before proceeding with the rest of the function.
Changes

Added import statement for sys module and added a check to ensure that at least one commit is found before proceeding with the rest of the function.

LGTM  🚀


Using SwinjectStoryboard and SwinjectPropertyLoader in one project

At the moment it is not possible to use SwinjectStoryboard and SwinjectPropertyLoader in one project through CocoaPods, because the projects depend on a different version of Swinject.
Is this project still maintained and could this be easily fixed?
As a reference, the CocoaPods error:
[!] CocoaPods could not find compatible versions for pod "Swinject":
  In snapshot (Podfile.lock):
    Swinject (= 2.5.0, ~> 2.4)

  In Podfile:
    Swinject (= 2.5.0)

    SwinjectPropertyLoader (= 1.0.0) was resolved to 1.0.0, which depends on
      Swinject (~> 2.0.0)

Specs satisfying the `Swinject (= 2.5.0), Swinject (= 2.5.0, > 2.4), Swinject (> 2.0.0)` dependency were found, but they required a higher minimum deployment target.

@yoichitgy , @jakubvano , @gasthana0 , is the library still supported? We need to plan if we can go with Swinject or Typhoon, but we will need PropertyLoader.


make sure docstrings are visible in JetBrains Rider

Verified the in IDE docstrings are visible in Rider

Inheritdoc does not appear to work in Rider when loading external DLLs: https://youtrack.jetbrains.com/issue/RSRP-478940


added files for Urdu language

What does this PR do?
Add resource(s) and Improve repository
For resources
Added resources for the Urdu language
Description
I made it easy for the people who understand Urdu to contribute to this repo by uploading the Urdu language materials.
Why is this valuable (or not)?
This is valuable because Urdu is a famous and worldwide spoken and read language. There is also a lot of data in the Urdu language available, so everyone can contribute by adding Urdu materials.
How do we know it's really free?
Yes, it is free and there are many books, podcasts, and courses free of cost available in Urdu.
For book lists, is it a book? For course lists, is it a course? etc.
I made it easy for users to upload or add the files for Urdu language as well.
Checklist:

[x] Read our contributing guidelines.
[x] Search for duplicates.
[x] Include author(s) and platform where appropriate.
[x] Put lists in alphabetical order, correct spacing.
[x] Add needed indications (PDF, access notes, under construction).
[x] Used an informative name for this pull request.

Follow-up
Yes.

Check the status of GitHub Actions and resolve any reported warnings!

Added resources for Urdu Language

please split this PR into separate PRs (from separate branches) for the resources, and each of the translated doc files. the review for each is quite different.


Ability to set a default column name for the primary time column in the datasource config. This would be used by the $timeFilter etc. macros unless overridden in the query builder

add to ConfigEditor

datetime
datetime64
uint32
date / date32

What would be really fantastic would be to able to define multiple default time columns which could be used in order of precedence.
For example, if the config has _time, _time64 as default time columns then the _time column would be used if found (and is a suitable type). If not, then _time64 would be searched for. In case both columns are present, then the first one in the list would be used.

What would be really fantastic would be to able to define multiple default time columns which could be used in order of precedence.

@oplehto
No, it will define only only one field for each related field type per connection


[KBM Bug Bash] Remapping Ctrl+A to Ctrl+C doesn't work

Here's my settings page:

Closing this issue. Need to clear up direction of remapping


[BUG] Failed to recover node.kubernetes.io/disk-pressure:NoSchedule  on single-node Harvester

Describe the bug
I deployed a single node harvester instance and I was testing to import some VMs from another KVM-based infra (oVirt). I quickly realized that uploading large-size images is not efficient with the UI and I decided to copy the image to the host and upload from there locally, Unfortunately I did not pay attention to the disk usage and therefore I now have a taint in my single node
ultron:~ # kubectl describe nodes ultr
Name:               ultron
Roles:              control-plane,etcd,master
.....
CreationTimestamp:  Sun, 16 Oct 2022 15:08:47 +0000
Taints:             node.kubernetes.io/disk-pressure:NoSchedule
Unschedulable:      false
Lease:
  HolderIdentity:  ultron
  AcquireTime:     <unset>
  RenewTime:       Mon, 17 Oct 2022 09:15:29 +0000

and after the taint, obviously, Kubernetes killed the pods and I realized that something is wrong with the cluster :rofl:. After I deleted the big image and free up the space, I was expecting to taint to go away and the cluster to recover. But what I realized is that in order to remove the taint, it needs to send a request to the harvester-webhook pod, which is running under the harvester-system namespace.
ultron:~ # kubectl get pods -n harvester-system
NAME                                                    READY   STATUS                   RESTARTS      AGE
harvester-797b59b958-sx6rn                              0/1     Pending                  0             97m
harvester-load-balancer-686957bdfc-p4tbz                0/1     Pending                  0             97m
harvester-network-controller-manager-5c455bdc66-648mv   0/1     Pending                  0             97m
harvester-network-controller-wwn7g                      1/1     Running                  0             93m
harvester-node-disk-manager-t24q9                       1/1     Running                  0             93m
harvester-webhook-6449bdf6fb-d9wkr                      0/1     Pending                  0             97m
kube-vip-cloud-provider-0                               0/1     Pending                  0             97m
kube-vip-w6nz9                                          1/1     Running                  0             90m
virt-api-79bc89595-6rqj8                                0/1     Pending                  0             97m
virt-api-79bc89595-7nkcs                                0/1     ContainerStatusUnknown   1 (13h ago)   18h
virt-api-79bc89595-bm6nx                                0/1     Completed                1 (13h ago)   18h
virt-api-79bc89595-l5wmn                                0/1     Pending                  0             96m
virt-controller-6c76d8659-955qb                         0/1     Pending                  0             96m
virt-controller-6c76d8659-hxj4b                         0/1     Pending                  0             96m
virt-handler-bzcf7                                      1/1     Running                  0             90m
virt-operator-78b84587c9-2ng6f                          0/1     Pending                  0             96m

but as you can see, the pod is in the Pending state. Why? Because the only node they can run is the one with the taint, and in order to remove the taint, it needs to reach the pod :smile:
ultron:~ # kubectl taint nodes --all node.kubernetes.io/disk-pressure:NoSchedule-
Error from server (InternalError): Internal error occurred: failed calling webhook "validator.harvesterhci.io": Post "https://harvester-webhook.harvester-system.svc:443/v1/webhook/validation?timeout=10s": no endpoints available for service "harvester-webhook"

as far as I understand, there is no way to recover the host, instead of reinstalling it. I know that single-node clusters are not the way to build a production Harvester cluster, but this will also be the case where you have 3 nodes and you exhaust the disks on all of them at the same time, less likely, but it is possible.
So I wonder if there is any way to recover it from its current state and if there is anything to improve this check to avoid it in the future.
We can see from the events that kubelet already says there is no disk pressure anymore so maybe there might be an improvement to rely on that information instead of the webhook.
ultron:~ # kubectl describe nodes ultr
...
Events:
  Type     Reason                   Age                    From     Message
  ----     ------                   ----                   ----     -------
  Normal   Starting                 5m2s                   kubelet  Starting kubelet.
  Warning  InvalidDiskCapacity      5m2s                   kubelet  invalid capacity 0 on image filesystem
  Normal   NodeAllocatableEnforced  5m1s                   kubelet  Updated Node Allocatable limit across pods
  Normal   NodeHasSufficientMemory  4m52s (x2 over 4m56s)  kubelet  Node ultron status is now: NodeHasSufficientMemory
  Normal   NodeHasNoDiskPressure    4m52s (x2 over 4m56s)  kubelet  Node ultron status is now: NodeHasNoDiskPressure
  Normal   NodeHasSufficientPID     4m52s (x2 over 4m56s)  kubelet  Node ultron status is now: NodeHasSufficientPID
  Normal   NodeReady                4m52s                  kubelet  Node ultron status is now: NodeReady

To Reproduce
Steps to reproduce the behavior:

Fill your root volume with some data (random with dd, or copy something)
Watch your cluster go down
Free up the space
Wait for your cluster to fail to recover

Expected behavior
To cluster/node to recover after freeing up the space.
Environment

Harvester ISO version: v1.0.3
Underlying Infrastructure: Ryzen 5700G with 80GB RAM 500G NVME SSD.

@armagankaratosun After free up the space, did you try to reboot the NODE ?

yes, i tried several times and it didn't work.

@armagankaratosun Seems the solution here https://github.com/harvester/harvester/issues/2821#issuecomment-1383429966 also fit in your scenario, but I guess you have already recoverd long ago.
cc @FrankYang0529 @bk201

@w13915984028 yes, it looks like it is applicable to my scenario as well. I can actually test this and confirm it in my home lab. Will look into it once I have some free time.

After freeing up disk space, the taint was not automatically removed. Manually removing the taint resulted in the following error: failed to call webhook: Post [https://harvester-webhook.harvester-system.svc:443/v1/webhook/validation?timeout=10s](https://harvester-webhook.harvester-system.svc/v1/webhook/validation?timeout=10s): no endpoints available for service "harvester-webhook"

Hi @janeczku, this looks like a dead lock. Nodes have taints, so pods can't be scheduled. However, we also have a validation webhook, so removing taint request should be processed by webhook. I tried following test steps, we can fix this by removing Validatingwebhookconfigurations.

Add NoSchedule taints on all nodes.
Remove all harvester-webhook pods. Now, new harvester-webhook pods can't be scheduled.
Remove harvester-validator Validatingwebhookconfigurations.
Remove taints on all nodes. Now, new harvester-webhhok pods can be scheduled.

Originally posted by @FrankYang0529 in https://github.com/harvester/harvester/issues/2821#issuecomment-1383429966


Proposal for WiFiAccessPoint class.

Description
Proposal for WiFiAccessPoint class to be able use ESP32 targer as access point.
Motivation and Context

How Has This Been Tested?

Screenshots
Types of changes

[ ] Improvement (non-breaking change that improves a feature, code or algorithm)
[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Config and build (change in the configuration and build system, has no impact on code or features)
[ ] Dependencies (update dependencies and changes associated, has no impact on code or features)
[ ] Unit Tests (work on Unit Tests, has no impact on code or features)

Checklist:

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

Considering all that's required with this, I leave 2 suggestions for thought:

Maybe this should depend on System.Net because all that's required from there, now duplicated here. Plus, I feel that IP addresses are coming, so....
As this is growing it would be wise to have a second NuGet with Wi-Fi + Access Point. That way we keep the current one as slim as possible and don't force the AP to people not needing it.

Considering all that's required with this, I leave 2 suggestions for thought:

Maybe this should depend on System.Net because all that's required from there, now duplicated here. Plus, I feel that IP addresses are coming, so....
Ok. I will look for the code. With dependency on System.Net i think will be much easier,
As this is growing it would be wise to have a second NuGet with Wi-Fi + Access Point. That way we keep the current one as slim as possible and don't force the AP to people not needing it.
What about creating a separate class as Windows.Devices.WiFiAccessPoint. Or is that way too much ? :-)

What about creating a separate class as Windows.Devices.WiFiAccessPoint. Or is that way too much ? :-)

Really dependes on where this is going... If the AP class brings in a lot of stuff and distinct of what is here, that could make sense. If not, then a separate package with the AP feature should be good enough.

@AdrianSoundy thoughts on all this?

Most usage of WiFiAccessPoint is for the device configuration. Connecting the devices to the wifi network without hardcoded credentials. On the Arduino platform WifiManager is very much in demand.

What about creating a separate class as Windows.Devices.WiFiAccessPoint. Or is that way too much ? :-)

Really dependes on where this is going... If the AP class brings in a lot of stuff and distinct of what is here, that could make sense. If not, then a separate package with the AP feature should be good enough.

Its a good idea to have a simpler way to start the SoftAp but maybe we should try and get away from the Windows.Devices UWP namespace.  I would rather look at extending the existing System.Net support as in:-

Changes to allow configuration changes without having to reload, keeping backward compatibility
Simple call to start SoftAP in the same way as Open method here. This also applies to Wifi station.
As a separate assembly that extends on the current System.Net / System.NetInformation. Something like System.Net.SoftAP or WiFi

We already have a most of the SoftAP implementation which you are duplicating here, the main problem is the need to reload to start it running.


Add support for no-shape

https://de.wikipedia.org/wiki/Straßenbahn_München#Linie_E7

If a line has no shape, I guess then it shouldn't be listed in this repo? 🤔

IDK would be weird if the repo lists every line but one


Fix the OptimisticCart type to properly retain the generic of line items

WHY are these changes introduced?
@brookslybrand reported an issue where the the generic on OptimisticCart did not propagate to line items. For example, this would produce a type of the default cart lines, not the generic api fragment provided.
type CartLine = OptimisticCart<CartApiQueryFragment>['lines']['nodes'];

With this change, now the CartAPIQueryFragment is preserved.

Checklist

[X] I've read the Contributing Guidelines
[X] I've considered possible cross-platform impacts (Mac, Linux, Windows)
[X] I've added a changeset if this PR contains user-facing or noteworthy changes
[X] I've added tests to cover my changes
[X] I've added or updated the documentation

/snapit

I've experienced this as well! Would love to see it come in the next release :)


feature: add interval on AI backend request

📑 Description
This commit introduces the ability to send the requests to the backend AI server at set intervals, independent of the reconciler's requeue requests.
To utilize this feature, the Interval field in the AI settings must be set in the k8sgpt configuration object. Also, the specified interval must be greater than or equal to the reconciler's requeue interval as the llm requests should be called after the reconciler executes k8sgpt analyze.
Fixes: https://github.com/k8sgpt-ai/k8sgpt-operator/issues/419
✅ Checks

[x] My pull request adheres to the code style of this project
[x] My code requires changes to the documentation
[ ] I have updated the documentation as required
[x] All the tests have passed

@AlexsJones, @JuHyung-Son, where do we intend to use the response obtained from the AI backend?

what do you mean repeatedly calling the AI backend ?

I'm sorry, but I don't think I understand the situation very well. what is the situation that ai backend is called outside the reconciler loop? do we have that situation?

No problem, I'll try again. So we're working on this feature to support calling the AI backend at set intervals independent of the reconciler loop.
I approached this feature in the following manner:

Check if the user has set the k8sgptConfig.Spec.AI.Interval field and its duration is greater than k8sgptClient.ProcessAnalysis(k8sgptConfig, allowBackendAIRequest). If yes, then call repeatBackendRequest.
repeatBackendRequest will call time.AfterFunc to call k8sgptClient.ProcessAnalysis(k8sgptConfig, allowBackendAIRequest) and obtain the results outside the reconciler loop at set intervals.
At this step, we'll have the response obtained from the AI backend.
What to do next??


Ztring.cpp: Explicitly state that fallthrough is wanted; remove unused variable

Follow up to #115
Same setup as #115. But enabled a few more warnings.
@JeromeMartinez PreviousSize is unused. I can't see any use for it or where it could have been used before.
Regarding "fallthrough" (commit message):
GCC10 warns about this switch case because cases "fall through" the
bottom. Adding a simple comment fixes the warning.
Note: C++17 has [[fallthrough]] but ZenLib supports older C++ versions
as well.

Note: C++17 has [[fallthrough]] but ZenLib supports older C++ versions as well.

We are not yet at C++11 with this lib (we still support old platforms like CentOS 6 and macOS 10.6, and more complex to use C++11 or upper with them), so C++17 is at very long term :)


[FLINK-7854] [table] Reject lateral table outer joins with predicates in SQL

What is the purpose of the change
Due to CALCITE-2004, this PR aims to temporarily restrict the predicates for left outer join against the lateral table to be literal TRUE.
Brief change log

Override the validateJoin() method in FlinkCalciteSqlValidator to check the join conditions.
Update the tests.
Refine the documents.

Verifying this change
This change is already covered by existing tests CorrelateTest.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (docs)

Hi @xccui, are you working on this right now?
FLINK-7854 is a blocker for the release and we should try to fix it before end of next week.
Thanks, Fabian

Hi @fhueske. I am working on it now.

Hi @fhueske, the PR has been updated.

Great thanks a lot! The PR looks good. Will merge it.


Use union for epoll_event user data (epoll_data_t)?

It would make working with epoll a bit more pleasant, but I'm concerned about backcompat problems.
There's no way to make this change in a non-breaking way.
I'd be glad to implement, but I'm checking here first whether it's worth it...

Would be great to do! But yes backwards compatible is required

Hm, well, I don't really see a way of doing this without breaking compatibility, so I'm gonna close (at least for now).


Unable to process buying and selling Future contracts

The following entries could not be processed with the error ValueError(f'Unknown openclose: {openclose}'):
03/04/2024 02:16 PM,Trade,Sell,/CLJ4,Sell,Sell,1,,,,160,1.820,-160,Sold 1 /CLJ4 @ 79.53,Individual...39
03/04/2024 02:12 PM,Trade,Buy,/CLJ4,Buy,Buy,1,,,,0,1.820,0,Bought 1 /CLJ4 @ 79.69,Individual...39

I created the line with the legacy.py referenced from issue #39. But I guess it would also not be processed successfully by the script.
New Format would look like:
2024-03-04T14:16:27+0100,Trade,Sell,SELL,/CLJ4,Future,Sold 1 /CLJ4 @ 79.53,-160.00,1,-160.00,-1.25,-1.82,,,,,,,310910163,USD
2024-03-04T14:12:32+0100,Trade,Buy,BUY,/CLJ4,Future,Bought 1 /CLJ4 @ 79.69,0.00,1,0.00,-1.25,-1.82,,,,,,,310909959,USD

I ran your transactions with the adjusted code for reading the new Tasty data format. There was no issue. It has been processed successfully. So we should may be wait until the Pull Request #24 is incorporated.

/CL seems to be included with a multiplier of 1000. I've not looked at this issue in detail.
Can you test this again and report back if the current version works ok or if this issueis still open?
Thanks a lot,
Florian La Roche


Run Tests on macOS Application

It would be very useful to be able to run tests on the macOS application artifact.
This would greatly help identify any issues that may impact the macOS application but can't be identified by running tests on source code.
Is it possible to run pytest on the spyder module inside the artifact?

Up to you to figure this one out. I really don't know if it's possible.

Yes, I expected to be assigned.

Thanks a lot for your help. I think it's a very good idea, by the way.


Support of send operation for single resource data with TLV format ?

I dont know if it's normal or a bug, but when I run the wakaama client demo with the "send 123 /3/0/9" command, I can see today the supported format is only SENML JSON or SENML CBOR.
Would it be possible to support TLV as well ?

Ok in that case that makes sense, thank you for confirmation.
Is the SenML CBOR more efficient than TLV in term of data size ?

I don't know. :shrug:
TLV is a binary format so it should be pretty efficient.
In LWM2M v1.0.x, it was the only binary format and probably the most used as you can do anything with it and it was mandatory at client and server side.
LWM2M v1.1.x more or less deprecates TLV :

LwM2M Clients supporting LwM2M TS 1.1 or newer SHOULD NOT use the legacy TLV or JSON formats.

And introduces SenML-CBOR which is based on CBOR described as :

The Concise Binary Object Representation (CBOR) is a data format whose design goals include the possibility of extremely small code size, fairly small message size, and extensibility without the need for version negotiation

(source : RFC8949 § Abstract)
So I guess it should be pretty efficient too but I don't know compare to TLV
I suppose that authors add this format because this is an IETF standard (See RFC8428) contrary to TLV which is LWM2M only ?
(It also seems that SenML-CBOR support timestamped value but don't know if this is supported by Wakaama)
But the funny part, in LWM2M v1.2.x , authors introduce another format called LwM2M CBOR which is suppose to be more efficient but is NOT an IETF standard and WITHOUT timestamped value support ... (probably not supported by Wakaama because if I remember well Wakaama is about LWM2M v1.1.x )

Thanks again.
I suppose yes that CBOR is efficient too, I will compare the data part when doing a read with TLV and a send with senml CBOR.
Actually I would like to use LWM2M for embedded systems to send binary payloads most of the time ... so I was looking for something efficient !!
I hope the LWM2M standards will converge with something supported by many constructors. Today I am using Wakaama but in the final commercial product maybe we will use the embedded LWM2M stack from modem ...
BTW, what are the legal rules in term of commercial reuse of Wakaama code in a finished sold product ??

BTW, what are the legal rules in term of commercial reuse of Wakaama code in a finished sold product ??

Wakaama is dual licensing so you can choose to use one or another of those 2 licenses :

https://github.com/eclipse/wakaama/blob/main/LICENSE.EPL-2
https://github.com/eclipse/wakaama/blob/main/LICENSE.BSD-3-Clause

Thanks.
What is the rule to send unsolicited data using send method without always refreshing connection ?
I noticed that sometimes I have to update registration before to send Coap/CBOR data but sometimes it's not needed ...
Sorry for asking that, I am a rookie in LwM2M ...
De : Simon @.>
Envoyé : mercredi 20 mars 2024 15:10
À : eclipse/wakaama @.>
Cc : Panetto David-Alexandre @.>; Author @.>
Objet : Re: [eclipse/wakaama] Support of send operation for single resource data with TLV format ? (Issue #761)
Vous ne recevez pas souvent de courriers de la part de @.*** Découvrez pourquoi cela est importanthttps://m365.eu.vadesecure.com/safeproxy/v4?f=NoAppMsgH_ERAJfv__0tLF24E33kU8CUIWCKBz_LYxgCmlE2D3pbep9ZnAElTi5Q&i=5ny-Lt5_hnTv8dlh6FvqbxRT3jtH2kpmJ4KDIWuGQUJwOkLefXp-PRoSEatkqTnGsj7TFldDif4ws_gBU4RDYA&k=kSlz&r=pchtF3gk1tLMh_HLowDfBv29toLWnsI1smgahg0izrrzlwaD_DaxrQXgT3N5j8UV&s=108352cde2704709759290b0f746f5074440cb085e4df5b835fcc7efc1851366&u=https%3A%2F%2Faka.ms%2FLearnAboutSenderIdentification
CAUTION: This message comes from an external server, do not click on links or open attachments unless you know the sender and are sure the content is safe.
BTW, what are the legal rules in term of commercial reuse of Wakaama code in a finished sold product ??
Wakaama is dual licensing so you can choose to use one or another of those 2 licenses :

https://github.com/eclipse/wakaama/blob/main/LICENSE.EPL-2https://m365.eu.vadesecure.com/safeproxy/v4?f=U21uafJxChxzA0VchrGP4bKQYJUIzIeuQpatQkuZanLb4WflDDkiNgqO2_sjXh6z&i=9Z5cYF8RhijqbBLWu24g50_LeK3k2iIkV7lUGQbSK2uU9yn-l5yLz2omCrrgFUFUeYYVNyJ42Rdslap-C2UFOg&k=71Eg&r=p6IymSogfNeWHq3sODbFpv9Eir8FxKDw6eZYQIBNq9fewXplsqCydMav4jPMVFnK&s=b626a9b63b7ae5637423ad4610965f02f89c7447811df7a644ada304935658ad&u=https%3A%2F%2Fgithub.com%2Feclipse%2Fwakaama%2Fblob%2Fmain%2FLICENSE.EPL-2
https://github.com/eclipse/wakaama/blob/main/LICENSE.BSD-3-Clausehttps://m365.eu.vadesecure.com/safeproxy/v4?f=YqWvvo1Z32-xtnm8gBxc2LTd0y57styuaQ6_-lVvoUi7_5zbfg5U2MWje-oYN2-_&i=Zj6etCQY9VzAaCc2XXAZsvEQnXtlXrTSoGA1FQDoSynJMsEm00ht5z2Taooou3Rm2f1QDGajDUZ7s63WThFzig&k=eV1W&r=A1qf0M-SwYN7p148dwCQmZBRflL5VxqhOtl1Xr9TCmAJMNJIN-IIVr8hiR1kEq7P&s=3c0c59001213e6bd3880568542671eb13b7f23f02f1eb40b756d2763b256cdfc&u=https%3A%2F%2Fgithub.com%2Feclipse%2Fwakaama%2Fblob%2Fmain%2FLICENSE.BSD-3-Clause

Reply to this email directly, view it on GitHubhttps://m365.eu.vadesecure.com/safeproxy/v4?f=UQPdVpqM6bKOZVyU58rLdl62-PGVvnWCgnWO30kClifH8BoJIVdNb-Pz389X5k6U&i=gyoHDaYpd-us2LfCLKPsnhEAGoTeKSAfwKp1t5QWNo9LeHgcNe56NhLXObs8NvprQQKnMxKGquhm0ZS7VCovOg&k=tiZG&r=r90C6UAQidSLmXu3v3ckxWuIfnrAnC3y_tCuWXFozvjEAlHuUmxnFuvKXTm-RuWH&s=9e37856f944c315c2033b6f24996b86fc2020cbabc003eef6898e9b1d10526f0&u=https%3A%2F%2Fgithub.com%2Feclipse%2Fwakaama%2Fissues%2F761%23issuecomment-2009664264, or unsubscribehttps://m365.eu.vadesecure.com/safeproxy/v4?f=VnP7WYmUutwk7azYS7F9F2rf_2tTy6swUfSuPUIZvloWbaGtb7je281JPeDhDIx0&i=H5Qp0swdKVKlFzquvSbvHgV6ucac0S1FvKiHhomIYy7bYFeojo3_VjSAf-iIqrynuFm9DqOYIsJBU8TXtMs0qg&k=Wq2u&r=JCv1LUCNNkUHHhOX5_FGSTmcFRQUH3IgHlQeoDfycC6YYYX0YVmI2opBBjqXj0dg&s=1d3e14de150aeecd70c160447fa10a26514b55f00254013787d28bc4f108297a&u=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FBD3FFPIDCW2N3EFBONDATI3YZGKBVAVCNFSM6AAAAABE7GZX2CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBZGY3DIMRWGQ.
You are receiving this because you authored the thread.Message ID: @.***>

Ce message et toutes les pièces jointes (ci-après le "message") sont établis à l'intention exclusive de ses destinataires et sont confidentiels. Si vous recevez ce message par erreur ou s'il ne vous est pas destiné, merci de le détruire ainsi que toute copie de votre système et d'en avertir immédiatement l'expéditeur. Toute lecture non autorisée, toute utilisation de ce message qui n'est pas conforme à sa destination, toute diffusion ou toute publication, totale ou partielle, est interdite. L'Internet ne permettant pas d'assurer l'intégrité de ce message électronique susceptible d'altération, l'expéditeur (et ses filiales) décline(nt) toute responsabilité au titre de ce message dans l'hypothèse où il aurait été modifié ou falsifié.
This message and any attachments (the "message") is intended solely for the intended recipient(s) and is confidential. If you receive this message in error, or are not the intended recipient(s), please delete it and any copies from your systems and immediately notify the sender. Any unauthorized view, use that does not comply with its purpose, dissemination or disclosure, either whole or partial, is prohibited. Since the internet cannot guarantee the integrity of this message which may not be reliable, the sender (and its subsidiaries) shall not be liable for the message if modified or falsified.

I don't know what you called "connection".

I noticed that sometimes I have to update registration before to send Coap/CBOR data but sometimes it's not needed ...

Hard to say but maybe you behind NAT and so from a Server point of view your client IP changes and so you need to do an update ?
See : https://github.com/eclipse-leshan/leshan/issues/1544

I am using Wakaama client "update 123" command to refresh the registration.
Maybe it is due to NAT, I don't now, but sometimes if I don't do the "update 123" then the server sends an error response telling I am not registered.
It's not always 1 or 2 minutes, it depends. Is there a session timeout exposed during first registration or registration update ?
De : Simon @.>
Envoyé : vendredi 22 mars 2024 17:33
À : eclipse/wakaama @.>
Cc : Panetto David-Alexandre @.>; Author @.>
Objet : Re: [eclipse/wakaama] Support of send operation for single resource data with TLV format ? (Issue #761)
CAUTION: This message comes from an external server, do not click on links or open attachments unless you know the sender and are sure the content is safe.
I don't know what you called "connection".
I noticed that sometimes I have to update registration before to send Coap/CBOR data but sometimes it's not needed ...
Hard to say but maybe you behind NAT and so from a Server point of view your client IP changes and so you need to do an update ?
See : eclipse-leshan/leshan#1544https://m365.eu.vadesecure.com/safeproxy/v4?f=jtp-M6_I1eSup0Ti86MnmezpWs2YQeJeV1GDyf4DsGf-GzmskyAIS02QkzYKN5B_&i=FBdn06er9ksbUfSuY145rzMztHg6ymmwGRspK36qwlXf5dTb5yos_e4mvK1qftmIAdS45vQ_cwykR7SoSJ4s2w&k=DDKQ&r=EgXKhEgSKjGWaQJvJZaQ1dcBHzbCRo7BhXo-dRn6_arccANpBZGSzY0nKdJp-xsJ&s=d30dc36d0a6f3f9e330d9969964109e720017045b1e89b1a35811d37b3de0fc6&u=https%3A%2F%2Fgithub.com%2Feclipse-leshan%2Fleshan%2Fissues%2F1544

Reply to this email directly, view it on GitHubhttps://m365.eu.vadesecure.com/safeproxy/v4?f=jU-1FhTZXZd7h2DdFL98Ldhoqw2Ki4KPVKNIY0m3ZZYFUXPQ25IakeaMO68L0RD6&i=iTgkjEcJ--C88Cs2U5rsj3Qu7LFKmfa1iPdEyIiizUiJs0GUBrla4AUv8NKD_Pe6qNnJ1n_eC5HV4eksHa4sUA&k=rg5M&r=foldOSYocQmDOb97QTy42tAXPoRZ6E4V4xTV27YJYvYKINFT7w1vgBntD5T6VXk3&s=fb015181d005638c13695732603df6dcda06f2aa22a7eaa2ed2dfcc8bea8eaa9&u=https%3A%2F%2Fgithub.com%2Feclipse%2Fwakaama%2Fissues%2F761%23issuecomment-2015467384, or unsubscribehttps://m365.eu.vadesecure.com/safeproxy/v4?f=WDGXo9d3SFvwBptacV27kwjGXTj48-pGuOcYkpZ3r-teW1GNkIGxWcjxd05QT0bP&i=Ai1lZT-vZRDiD7_W9LDCys6sagzp7jjZf2K_-2YxyoGi8pWDk2Lg_jXK5BIGJfRJIt3sjJ6B6t9EnBRvixEPCw&k=8efL&r=Awp1Uu4v9bWhsefbZbDGkhVg5cgeN6CWjnG5_aTWflm-GQED4q5eTwasxSRDvsdU&s=4aeb2324f24b260710d067e457ef48c04af5cb1433d61a237147c9d2afbe98ee&u=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FBD3FFPKW5MPQ5X6LQ4RY4FTYZRMLZAVCNFSM6AAAAABE7GZX2CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJVGQ3DOMZYGQ.
You are receiving this because you authored the thread.Message ID: @.***>

Ce message et toutes les pièces jointes (ci-après le "message") sont établis à l'intention exclusive de ses destinataires et sont confidentiels. Si vous recevez ce message par erreur ou s'il ne vous est pas destiné, merci de le détruire ainsi que toute copie de votre système et d'en avertir immédiatement l'expéditeur. Toute lecture non autorisée, toute utilisation de ce message qui n'est pas conforme à sa destination, toute diffusion ou toute publication, totale ou partielle, est interdite. L'Internet ne permettant pas d'assurer l'intégrité de ce message électronique susceptible d'altération, l'expéditeur (et ses filiales) décline(nt) toute responsabilité au titre de ce message dans l'hypothèse où il aurait été modifié ou falsifié.
This message and any attachments (the "message") is intended solely for the intended recipient(s) and is confidential. If you receive this message in error, or are not the intended recipient(s), please delete it and any copies from your systems and immediately notify the sender. Any unauthorized view, use that does not comply with its purpose, dissemination or disclosure, either whole or partial, is prohibited. Since the internet cannot guarantee the integrity of this message which may not be reliable, the sender (and its subsidiaries) shall not be liable for the message if modified or falsified.

Please read all answers about :  https://github.com/eclipse-leshan/leshan/issues/1544
And also links provided in those answers.

@EmbGangsta Can we close this issue? As mentioned by @sbernard31 TLV is not allowed in send commands. So we will not implement that in Wakaama. You should probably use SENML CBOR for your case.


Resizable "Opened Editors"

Please, add ability to resize (vertically) "working files" area.

@bpasero Are you working on this issue meow?

No, we just decided to give issues an owner.

I started to look at this one (because it's something I really wanted), but found there is a setting ("explorer.workingFiles.maxVisible": 50) that handles it perfectly. Personally, I don't think this feature should be implemented.

I'd either like it to be resizable with the mouse or a corresponding "explorer.workingFiles.minVisible" get added. So, for example, I could set "explorer.workingFiles.dynamicHeight" to true, minVisible to 10, maxVisible to 20.

From 0-10 files, I'd have buffer (empty space) between working files and the folder explorer
From 11-20 files, it'd dynamically grow
At 20+ files, I'd see a scrollbar

I don't understand the need to have a "explorer.workingFiles.minVisible". What advantage of having a buffer between working files and the folder explorer? That scenario essentially exists already (other than having the buffer, which like you said, is just adding empty, unusable space into the sidebar).
I could see why people want a resizable working files, but I think the current implementation satisfies the need. I'd almost bet that when @h2u created the issue that they didn't know about the "explorer.workingFiles.maxVisible" setting.

What advantage of having a buffer between working files and the folder explorer?

I see two advantages. It reduces clutter and thus cognitive load. It improves muscle memory: if I know file X isn't open but is roughly Y pixels down the list, I can open it faster. With the buffer, its location doesn't change (often). Sure, I could use Ctrl+P but I might also know my current ignore settings won't find it, or there are many similarly named files so I'll have to filter through stuff. If we had tabs, this wouldn't be an issue for me: there'd be less clutter and my project files wouldn't be constantly moving on me.

@bpasero is this going to be implemented any soon? Now the "Opened Editors" area takes about 20% of vertical space while the project tree beneath it takes the rest 80%.
I intuitively tried to "click and drag to resize" but for some reason it doesn't work.

@acutexyz the new owner of this feature is @isidorn

@acutexyz not planned to be implemented soon (there is 'explorer.openEditors.visible' as a somewhat of a workaround in the meantime)

+1

For me, when I close (minimize) the Folder Explorer and Gitlens Explorer, I'd just wish they floated to the bottom and let that naturally open up all the available room for the Open Editors explorer.  Right now, I just see a bunch of empty space below the last closed explorer and the bottom of my screen, and the Open Editors explorer is a tiny window over a small number of files and I'm forced to scroll a large list of open files through this small view.

This open editors area is a great idea.
I hope you guys take it a step further and make it easily resizable.
There was a suggestion that "explorer.openEditors.visible" was enough.
The trouble with this is that it applies to all projects and instances of vscode.
I always have more than one instance of vscode running with different number of files open in each.
It would just be great if I could adjust the size of this area and the Folder area as I wish, without having to always scroll one of them in instances of vscode.

Yes I really miss this feature, having to scroll up and down all the time affects my focus needed elsewhere.

Fixed by @ironyman in https://github.com/Microsoft/vscode/issues/491


getBoundingClientRect disables CSS transitions

If used inside CSSTransitionGroup react-slick prevents the transition from happening. The issue seems to only happen in Chrome.
Apparently (maybe) React has an issue with getBoundingClientRect (https://github.com/facebook/react/issues/3672) and it is used in initialize method here https://github.com/akiran/react-slick/blob/c6b612fa5c05e49572db97c13ab0af9c50aaa702/src/mixins/helpers.js#L65
Wrapping the entire body of the initialize method into a 0 settimeout seems to fix the problem.

This issue is fixed in latest release.
Can you check.


Hybrid solver prone to slow convergence

I've noticed lately that Siconos seems slower than it used to, and in fact I find it strange that some simulations tend to max out the iterations even when the object is motionless, for example, if you run,
cd examples/Mechanics/GeometricPrimitives
python cube.py

which has very high precision settings for some reason (itermax=100000, h=0.0005, Newton_max_iter=20, tolerance=1e-8), you will see that around step 4000 and above, when the cube has come to a stop, the output is,
step 4381 of 20000
TimeStepping::DefaultCheckSolverOutput:
Non smooth solver warning : output message from numerics solver is equal to 1
output in hdf5 file at step  4381
number of contacts 3
SolverInfos at time : 2.1905 iterations=  100000 precision= 1.18097972381e-08

step 4382 of 20000
TimeStepping::DefaultCheckSolverOutput:
Non smooth solver warning : output message from numerics solver is equal to 1
output in hdf5 file at step  4382
number of contacts 3
SolverInfos at time : 2.191 iterations=  100000 precision= 1.18099657438e-08

etc.  The contacts are not changing.  The solutions change only slightly between steps.  I have printed out the lambda vectors and the solution only changes by about 1e-4, and yet it takes 100000 iterations to get the precision down to 1e-8, at every step.
I verified a few things:

contacts are preserved between steps, not generated new
lambda values are copied correctly between the Interactions and the OSNSP

So then I started playing with the default settings for numerics, and I found what had impact was changing
fcOptions.solverId = Numerics.SICONOS_FRICTION_3D_ONECONTACT_NSN_GP_HYBRID

to
fcOptions.solverId = Numerics.SICONOS_FRICTION_3D_ONECONTACT_NSN_GP

Now the number of iterations when the cube is stable average around 2 or 3.
With such a high maxiter, the difference in total simulation time really adds up.  Time for cube.py with NSN_GP_HYBRID:
$ time python3 cube.py 2>&1 >/dev/null

real	43m52,463s
user	52m49,208s
sys	52m3,040s

very long for just a cube simulation!  Compared with if I change to NSN_GP,
$ time python3 cube.py 2>&1 >/dev/null

real	0m41,067s
user	0m52,516s
sys	1m9,864s

Thanks for reporting that. Let's try to save some of those examples and create a benchmark dataset.

The hybrid was slow for two main reasons:

the measure of error between PLI solver and NSN solver is not the same. Therefore, an improvement of the residual in the NSN method may lead to an increase of the absolute error and finally to destabilize the local solver
by default, the solver starts by the PLI solver and then may deteriorate the quality of the solution.

In e140907d22067b75672ff256bb37995f385119f1, I tried to fix this problem. With NSN_GP_HYBRID, we get similar performance as for NSN_GP on the simple cube example.
I propose to close the issue. Feel free to reopen if needed

Finally, I found another bug in the hybrid solver. The value of the rho parameter in the PLI approach was not initialized leading to possibly negative rho and nan results in the PLI algorithm.
Rather than stabilizing the solution, the PLI  iterations was destabilizing the local solver !!!
This is fixed in 01b5424d389e6b0724b652766a6f397dc8334db0


Lazy automatic detection of possible next nodes

Previously the possible node keys returned by a next_node block had to be specified explicitly using the permitted keyword argument. This PR introduces a mechanism for automatically detecting the possible node keys by parsing the source code in the next_node block.
In order to make use of this mechanism, you should set the permitted keyword argument to :auto and wrap the node keys returned by the next_node block with calls to #question or #outcome as appropriate. See the example below for details.
Note that if you fail to wrap the node key, you will see an exception when that node is chosen much as you would've done if a node not in the list of permitted next nodes was chosen. Note also that at the moment the #question and #outcome methods are identical i.e. it doesn't actually matter which you use. However, I think using them improves the readability of the code and if we thought it was useful, we could later introduce a check that the chosen node is of the correct type.
Before
multiple_choice :question? do
  option :option_one
  option :option_two

  permitted_next_nodes = [
    :solution_one,
    :solution_two
  ]

  next_node(permitted: permitted_next_nodes) do |response|
    case response
    when :option_one
      :solution_one
    when :option_two
      :solution_two
    end
  end
end

After
multiple_choice :question? do
  option :option_one
  option :option_two

  next_node(permitted: :auto) do |response|
    case response
    when :option_one
      outcome :solution_one
    when :option_two
      outcome :solution_two
    end
  end
end

This work follows on from #2311 and makes use of the changes in #2319 & #2340.
However, in contrast to #2311, the automatic detection of possible next nodes is now only triggered when a flow is being visualised via the GraphPresenter. Also this implementation does not use throw & catch. Hopefully this allays the concerns about a possible deterioration in performance.
Unfortunately the logic in SmartAnswer::Question::Base is more complicated than I would like, but much of that complexity is due to having to support both the old and new styles of next_node blocks. I'm confident that it'll be possible to simplify the logic considerably once we've converted all the flows over to the new style. We should also be able to remove the permitted: :auto option once all the flows have been converted.
I did contemplate adding a new engine/integration test for the new behaviour. However, in the end I decided that updating all the fixtures for the existing engine/integration tests gave enough coverage and was more in keeping with the current state of affairs. Also I was pleased to see that the GraphPresenterTest uses one of these fixture flows - now that the fixture has been updated, the fact that the test still passes gives me confidence that the automatic detection of possible next nodes is working OK.
I have not updated any published flows to use the new style next_node blocks in this PR. I'm imagining doing that in one or more subsequent PRs. It should be easy to do flow-by-flow or even question-by-question, because of the support for the old style syntax.
For further details, please see the individual commit notes.
Trello card

I think we might have problems using this approach if we also want to use next to return early from the next_node block. Fortunately, it looks as though the only Smart Answer using next is check-uk-visa, and the work that @erikse did in PR #2310 should mean that we can easily remove that use of next.

This all looks good to me. It took me quite a while to understand what was going on but I think I've got it now! As you've already mentioned, the code should be easier to understand once we've removed support for supplying the permitted next nodes via the permitted argument.
Great work, @floehopper!

@chrisroos: Can you explain why we might have problems using this approach in flows which use next to exit early from a next_node block? I just changed the first such occurrence in check-uk-visa to:
if calculator.study_visit? || calculator.work_visit?
  next question(:staying_for_how_long?)
end

And ran its regression test and they all passed. Am I missing something?

@chrisroos: Thanks for reviewing. I think I've addressed all your comments. It'd be great if you could review the latest state of play so I can try to get this merged tomorrow.

Can you explain why we might have problems using this approach in flows which use next to exit early from a next_node block?

@floehopper: Sorry - my mistake! When I was trying this branch locally I ran into problems visualising the check-uk-visa flow after updating it to use the question and outcome methods. I obviously didn't investigate properly because I've just done the same thing again and the visualisation works as expected. Sorry for the confusion.

Your changes look good to me, @floehopper.

@chrisroos: Thanks for reviewing again.
I'm going to rebase this against master, apply the fixup & squash commits, and force-push.


[SPARK-22933][SPARKR] R Structured Streaming API for withWatermark, trigger, partitionBy

What changes were proposed in this pull request?
R Structured Streaming API for withWatermark, trigger, partitionBy
How was this patch tested?
manual, unit tests

Test build #85563 has started for PR 20129 at commit 3843395.

Test build #85564 has started for PR 20129 at commit 2d26bd8.

Test build #85563 has finished for PR 20129 at commit 3843395.

This patch fails SparkR unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85563/
Test FAILed.

Test build #85566 has started for PR 20129 at commit 73e0def.

Test build #85564 has finished for PR 20129 at commit 2d26bd8.

This patch fails SparkR unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85564/
Test FAILed.

Test build #85566 has finished for PR 20129 at commit 73e0def.

This patch fails SparkR unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85566/
Test FAILed.

Merged build finished. Test FAILed.

Test build #85577 has started for PR 20129 at commit 137d1cb.

Test build #85577 has finished for PR 20129 at commit 137d1cb.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85577/
Test PASSed.


refactor(cdk): use overloads to indicate deprecated constructor signatures

Historically we've been using @deprecated on constructor paramters to indicate when they're going to become required. This is incorrect, because it won't show up in tooling that looks for breaking changes.
These changes reworks all of the deprecated constructor signatures in the CDK to use overloads.
This PR is intended as a test run to see if there are any issues with the approach, before we can roll it out to Material which has a lot more constructor deprecations.

Looks like the ViewEngine compiler doesn't support constructor overloads. Closing and we can revisit this once ViewEngine is removed.

@crisbeto can you add a jira item for this (marked as blocked)?


Add math.tile

Here's my initial commit of math.tile mirroring https://docs.scipy.org/doc/numpy-1.13.0/reference/generated/numpy.tile.html and https://www.tensorflow.org/api_docs/python/tf/tile.

This change is

This is an awesome contribution, thank you! Few comments below.

Review status: 0 of 5 files reviewed at latest revision, 4 unresolved discussions, some commit checks failed.

src/math/math.ts, line 934 at r1 (raw file):

   */
  tile<D extends keyof DataTypes, T extends NDArray<D>>(
      a: T, multiples: number[]): T {

can you call this reps for consistency with numpy?

src/math/tile_test.ts, line 24 at r1 (raw file):

// math.tile
{

can you write some tests for ints and bools since you also support tiling those?

src/math/webgl/tile_gpu.ts, line 37 at r1 (raw file):

    this.userCode = `
    void main() {

indent this block 2 more

src/math/webgl/tile_gpu.ts, line 63 at r1 (raw file):

}

function getDataType(rank: number): string {

since we use this in another place, can you move this to a common place: shader_compiler.ts?
You should also rename this to something like getCoordsDataType

Comments from Reviewable

I've addressed your other comments except for the last one pending some clarifications.
Do you want getCoordsDataType to be some kind of utility function that could be called with shader_compiler.getCoordsDataType?
Or do you want it to be included in the compiler code itself? Would calling ${dtype} resRC = getOutputCoords(); outside the main block work? This way we'd be able to directly call resRC without getOutputCoords. Although there's probably a reason you made it a function instead of a constant.

getCoordsDataType should be identical to what you're doing, just move the function location itself to shader_compiler as a util function. It should be a javascript function that returns a string for use in the spliced shader.
You can't put getOutputCoords() outside the main block, the main() block is the actual execution function of the fragment shader itself. Yep, it's a function because it's dynamically computed based on gl_FragCoord!
We're going to write a little more about how we actually do some of the WebGL stuff in a tutorial soon, will keep you posted.
Hope this helps.

Reviewed 2 of 5 files at r2, 1 of 1 files at r3.
Review status: 3 of 5 files reviewed at latest revision, 3 unresolved discussions, some commit checks failed.

src/math/tile_test.ts, line 78 at r3 (raw file):

      expect(t2.shape).toEqual([6]);
      expect(t2.dtype).toBe('bool');
      expect(t2.getValues()).toEqual(new Uint8Array([1, 0, 1, 1, 0, 1]));

sorry to be a pain, can you just replicate the Float tests for Int / Bool (make sure we also are checking for NaNs, there are subtle NaN details for non-floats)

Comments from Reviewable

Done!

Reviewed 6 of 6 files at r4.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from Reviewable


First Application.update dt == 0.

First update has 0 dt. It is due to initially _time is 0.
https://github.com/playcanvas/engine/blob/master/src/framework/application.js#L694
Consider skipping update if dt === 0?

My opinion here is that an initial call to update with dt as 0 means that the first frame rendered will be the start state as specified by scripts' initialize function. This is a good thing IMHO. So I'm going to close this.


Ugly hack while Scryfall set data is buggy.

That's more like it.

Hey @bakert,
Your changes look good to me!
View build log
TravisBuddy Request Identifier: 3df75000-0ebc-11ea-97d2-e7d533c125a8


Make the Janus CLI work on backstage upstream plugins

Make the Janus CLI work on backstage upstream backend plugins, without requiring any change in code.

implemented on the backstage-plugins side in PRs https://github.com/janus-idp/backstage-plugins/pull/967 and https://github.com/janus-idp/backstage-plugins/pull/971.
On the showcase side, PR https://github.com/janus-idp/backstage-showcase/pull/836 switches to this new CLI.


cleanup(tests,virtctl): Refactor and cleanup imageupload functests

What this PR does
Refactor and cleanup the imageupload functests by:

Using tables where possible and adding missing test cases
Removing the storage-req decorator as it looks to be not required
Avoiding the need for the tests to run in Serial
Avoiding lambdas where not required
Simplifying helper functions
Dropping test cases that are covered by unit tests:

[test_id:10674]Should fail with invalid volume-mode
Upload fails creating a DV when using a non-existent storageClass
Upload fails creating a PVC when using a non-existent storageClass

Change the existing unit test that verifies an upload fails on using a
non existent storageClass to be a Table, so it covers both DVs and PVCs.
This was previously a functional test.
Before this PR:
virtctl image-upload functests run in Serial and duplicate unit tests
After this PR:
virtctl image-upload functests run in Parallel and do not duplicate unit tests

Fixes #
Why we need it and why it was done in this way
The following tradeoffs were made:
The following alternatives were considered:
Links to places where the discussion took place:
Special notes for your reviewer
Wait for #12880 to merge first

Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

[ ] Design: A design document was considered and is present (link) or not required
[ ] PR: The PR description is expressive enough and will help future contributors
[ ] Code: Write code that humans can understand and Keep it simple
[ ] Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
[ ] Upgrade: Impact of this change on upgrade flows was considered and addressed if required
[ ] Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
[ ] Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
[ ] Community: Announcement to kubevirt-dev was considered

Release note

None

@mhenriks @awels Can you help me find out what is causing the test flakes?

unexpected return value 502, error in upload-proxy: http: proxy error: dial tcp <IP_ADDRESS>:443: connect: connection refused

Looks like the upload proxy is unavailable from time to time?

The issue looks to be CDI marking the upload Pod as ready too fast: https://github.com/kubevirt/containerized-data-importer/issues/3450

@mhenriks @awels Can you please take a look at this?

@mhenriks @awels Do you want me to quarantine the flaky tests?

Ping @mhenriks Can you PTAL?

/retest

@0xFelix apoligies for the delay, looks good, rebase and I will take another look

@mhenriks I rebased the PR, but I expect the flakes to still be an issue.
I saw your https://github.com/kubevirt/containerized-data-importer/issues/3450#issuecomment-2426515784. I need to have a look again this.

Nice job!
Nothing to add in my side.
/lgtm

/approve

So a while ago I experimented with running the imageupload tests in parallel, and it didn't go very well:
https://github.com/kubevirt/kubevirt/pull/11716#issuecomment-2373256509
I am pretty sure this is also why this PR is introducing flaking in the imageupload tests:
https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_kubevirt/12800/pull-kubevirt-e2e-k8s-1.29-sig-storage/1857478378622291968
I will open a PR to put them back to Serial for now as the gain in runtime is not very drastic


feat:H1022-L3 - Payment Refund and sync for Forte

formatted
Type of Change

[ ] Bugfix
[ ] New feature
[ ] Enhancement
[ ] Refactoring
[ ] Dependency updates

Description

Additional Changes

[ ] This PR modifies the database schema
[ ] This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

[ ] I formatted the code cargo +nightly fmt --all
[ ] I addressed lints thrown by cargo clippy
[ ] I reviewed submitted code
[ ] I added unit tests for my changes where possible
[ ] I added a CHANGELOG entry if applicable

Thanks for the contribution @sridattayalla  , We are merging the changes from different participant as it has more flows implemented. You can still continue your contributions on the open issues.

Thanks for the contribution @sridattayalla  , We are merging the changes from different participant as it has more flows implemented. You can still continue your contributions on the open issues.


Jitsi ask for user and password

jitsi show dialog to login.
sorry guy I don't know the user to login to room conference.
thank you.

You must use jwt token to login.

thank you.


fix(config): map Basic Set to Binary Sensor Reports for Fibaro FGK101

Fibaro FGK101 with firmware version lower than 2.3 does not report properly state change and uses BasicCC:Set to do so.
As per discussed in #2417, enabling compat flag to treat the basic set report as a status change (similar to what has been done on #2386).
After applying the patch, I have got the following in logs, confirmed working on two FGK101-2.1 devices
2021-04-22T06:31:25.722Z CNTRLR [Node 024] treating BasicCC::Set as a report
2021-04-22 08:31:25.736 INFO ZWAVE: Node 24: value updated: 48-0-Any false => true
2021-04-22T06:31:29.816Z CNTRLR [Node 024] treating BasicCC::Set as a report
2021-04-22 08:31:29.823 INFO ZWAVE: Node 24: value updated: 48-0-Any true => false

fixes: #2417

Thanks!


default relation in GO "qualifier" field

All of our processes will have "involved_in"
All of our components will have "part_of" in the first instance.
(Slowly we will  convert to a new not yet existing qualifier , meaning "enables activity of")
I think we can do some conversion of the "weaker" component qualifier of the strong one eventually.
The involved_in for process is the strongest.

(I think GO fills these in automatically, and we don't really need them yet)

I'm removing "discuss" from this because we won't implement until  it is mandated, and then hopefully there will be docs (probably won't happen until we move to GPAD, so not imminent).
In fact,  I'll put "waiting for external change" instead  and we can forget about it for a while...

closing, out of date


Drop Travis [1.1.1]

At this point, we have transitioned completely from Travis to GitHub Actions

This pull request is ready to merge

This pull request is ready to merge

Merged
a7222fc14d5977210d2b4673a68039824a039dc2 Drop Travis

Merged
a7222fc14d5977210d2b4673a68039824a039dc2 Drop Travis


Update Debugger to v2.30.0

This updates the debugger to v2.30.0. Among other things, this addresses #3173

The launch options schema needs to be updated


cli: add option to also write client key in PKCS#8 format.

PR: https://github.com/cockroachdb/cockroach/pull/29008
From release notes:

The cockroach cert create-client now offers the --also-generate-pkcs8-key flag for writing a client key in PKCS#8 format. [#29008][#29008] {% comment %}doc{% endcomment %}

@Amruta-Ranade, @rmloveland, not sure which of you wants to take this.

I can take this up (if that's okay, @rmloveland ?)

@Amruta-Ranade stealing it back! :-)

Humbled by the Java rabbit holes, handing the issue back to @rmloveland :)


Added some more test cases

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Flag
Coverage Δ

unittests
86.24% <100.00%> (+2.13%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines
Coverage Δ

backend/test_app.py
100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes


logging - reduce es memory limit for testing

Use a 4Gi memory limit for logging testing.  This will allow us
to test with https://github.com/openshift/openshift-ansible/pull/5119
Once this PR merges, then we can merge 5119 and logging tests should
be able to resume.
@stevekuznetsov @portante @jcantrill @sdodson ptal

So the default in openshift-ansible would still be 8GiB but we'll override it to 4GiB here? Do we have a cluster size that we feel 4GiB is acceptable for or is this truly limited to the scope of a cluster sized to just run CI tests?

please place into sjb/inventory/group_vars/OSEv3/logging.yml

@stevekuznetsov done


A new example Notebook that plots Discrete Sampling Geometry Data

In the spirit of providing more examples of using xarray here's a Notebook that makes some simple plots of oceanographic measurement data. I expect that I'll come back to this myself when I need to be reminded of some of the special incantations needed to quickly get some nice plots.

@MBARIMike thanks for the PR and apologies no one has reviewed it.
Do you happen to know why we can't see it in GH? Is the notebook well-formed?

I just got it to render fine--I blame general GitHub flakiness around notebooks lately.

@MBARIMike - sorry this never got wrapped up. If you have interest in finishing this, please feel free to reopen this PR or start a new one.


504 Gateway timeout after client exits

The localtunnel server still seems to look for the old client which is no longer active and starting it again doesn't change anything (custom subdomain)

The server has undergone a refactor; if this issue persists please post steps to reproduce in the localtunnel/server repository.

Same happening to me. Last day I restarted my server & from then I'm not getting my custom domain again. And when Im opening the url in browser it says 504.


Update AGP to 7.3.0

What does this PR do?
This change updates AGP version to 7.3.0, because we didn't update AGP for quite a long time.
The notable change is that package attribute shouldn't be used in the manifest, instead namespace property should be used in the module-level build.gradle. More here.
Also bumps Realm version.
Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] Make sure you discussed the feature or bugfix with the maintaining team in an Issue
[ ] Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

Codecov Report

Merging #1060 (fd6bff9) into develop (df4b21c) will increase coverage by 0.04%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #1060      +/-   ##
===========================================
+ Coverage    83.19%   83.23%   +0.04%
===========================================
  Files          272      272
  Lines         9268     9279      +11
  Branches      1488     1494       +6
===========================================
+ Hits          7710     7723      +13
+ Misses        1144     1140       -4
- Partials       414      416       +2

Impacted Files
Coverage Δ

...n/kotlin/com/datadog/android/timber/DatadogTree.kt
50.00% <0.00%> (-5.56%)
:arrow_down:

...tadog/android/tv/LeanbackViewAttributesProvider.kt
86.21% <0.00%> (-2.68%)
:arrow_down:

...main/java/com/datadog/exec/CommonTaskExecutor.java
47.92% <0.00%> (-2.08%)
:arrow_down:

...android/rum/internal/ndk/DatadogNdkCrashHandler.kt
87.57% <0.00%> (-1.08%)
:arrow_down:

.../android/rum/internal/monitor/DatadogRumMonitor.kt
91.33% <0.00%> (-0.58%)
:arrow_down:

...main/kotlin/com/datadog/android/rx/DatadogRxExt.kt
100.00% <0.00%> (ø)

...tadog/android/fresco/DatadogFrescoCacheListener.kt
100.00% <0.00%> (ø)

...kotlin/com/datadog/android/DatadogEventListener.kt
98.51% <0.00%> (+0.02%)
:arrow_up:

.../src/main/kotlin/com/datadog/android/log/Logger.kt
96.03% <0.00%> (+0.03%)
:arrow_up:

...rc/main/java/com/datadog/opentracing/DDTracer.java
55.65% <0.00%> (+0.84%)
:arrow_up:

... and 3 more


[ISSUE #8544] Restore retry mechanism in unit test pipeline

Which Issue(s) This PR Fixes

Fixes #8544
Brief Description
This PR reintroduces the retry mechanism for the CI workflow, which was inadvertently removed due to a merge conflict

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 47.19%. Comparing base (e8d87b1) to head (55283fd).

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8581      +/-   ##
=============================================
- Coverage      47.22%   47.19%   -0.04%
+ Complexity     11446    11439       -7
=============================================
  Files           1275     1275
  Lines          89242    89242
  Branches       11470    11470
=============================================
- Hits           42148    42114      -34
- Misses         41895    41922      +27
- Partials        5199     5206       +7

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


adding dynamic assets

also adds tooltips for app type and components, for example:

@mswiderski added -DruntimeStrategy=PER_CASE for dynamic asset choice to go along with
https://github.com/kiegroup/droolsjbpm-knowledge/pull/338

merged manually after testing, thanks


Unable to use go-mode in emacs

Debugger entered--Lisp error: (wrong-type-argument keymapp go-mode-map)
  map-keymap(#[514 "\304\303\242GI\210\305\300\301\304\302%\207" [go-import-add helm-go-package go-mode-map ("") [nil] substitute-key-definition-key] 8 "\n\n(fn CHAR DEFN)"] go-mode-map)
  substitute-key-definition(go-import-add helm-go-package go-mode-map)
  #[nil "\300\301\302\303#\207" [substitute-key-definition go-import-add helm-go-package go-mode-map] 4]()
  eval-after-load-helper("/Users/rconover/.emacs.d/elpa/go-mode-20150817.2318/go-mode.elc")
  run-hook-with-args(eval-after-load-helper "/Users/rconover/.emacs.d/elpa/go-mode-20150817.2318/go-mode.elc")
  do-after-load-evaluation("/Users/rconover/.emacs.d/elpa/go-mode-20150817.2318/go-mode.elc")
  autoload-do-load((autoload "go-mode" "Major mode for editing Go source text.\n\nThis mode provides (not just) basic editing capabilities for\nworking with Go code. It offers almost complete syntax\nhighlighting, indentation that is almost identical to gofmt and\nproper parsing of the buffer content to allow features such as\nnavigation by function, manipulation of comments or detection of\nstrings.\n\nIn addition to these core features, it offers various features to\nhelp with writing Go code. You can directly run buffer content\nthrough gofmt, read godoc documentation from within Emacs, modify\nand clean up the list of package imports or interact with the\nPlayground (uploading and downloading pastes).\n\nThe following extra functions are defined:\n\n- `gofmt'\n- `godoc'\n- `go-import-add'\n- `go-remove-unused-imports'\n- `go-goto-imports'\n- `go-play-buffer' and `go-play-region'\n- `go-download-play'\n- `godef-describe' and `godef-jump'\n- `go-coverage'\n\nIf you want to automatically run `gofmt' before saving a file,\nadd the following hook to your emacs configuration:\n\n(add-hook 'before-save-hook #'gofmt-before-save)\n\nIf you want to use `godef-jump' instead of etags (or similar),\nconsider binding godef-jump to `M-.', which is the default key\nfor `find-tag':\n\n(add-hook 'go-mode-hook (lambda ()\n                          (local-set-key (kbd \"M-.\") #'godef-jump)))\n\nPlease note that godef is an external dependency. You can install\nit with\n\ngo get github.com/rogpeppe/godef\n\n\nIf you're looking for even more integration with Go, namely\non-the-fly syntax checking, auto-completion and snippets, it is\nrecommended that you look at flycheck\n(see URL `https://github.com/flycheck/flycheck') or flymake in combination\nwith goflymake (see URL `https://github.com/dougm/goflymake'), gocode\n(see URL `https://github.com/nsf/gocode'), go-eldoc\n(see URL `github.com/syohex/emacs-go-eldoc') and yasnippet-go\n(see URL `https://github.com/dominikh/yasnippet-go')\n\n(fn)" t nil) go-mode)
  command-execute(go-mode record)
  execute-extended-command(nil "go-mode")
  call-interactively(execute-extended-command nil nil)
  command-execute(execute-extended-command)

Looks like an issue with helm, or helm-related functionality to me:

substitute-key-definition(go-import-add helm-go-package go-mode-map)

So not an issue with go-mode itself. Also, (keymapp go-mode-map) returns t here, so I have no idea why helm is breaking. Either way, report the issue with whoever is responsible for helm-go-package.

Okay, asking the helm people


[BUG] Agentflow stopped working

Describe the bug
To understand the BUG I've created a simple Agentflow with ChatOllama, supervisor and 2 workers.
Using model llama3.1 - all works perfect!
Then changed the model to qwen2.5-coder - again worked fine
Then I changed the model to qwen2.5-coder:14b-base-q8_0 and all stopped working.
Very strange, because the model llama3.1:8b-instruct-q2_K works too
When I write a message and click sen - I see "message stopped".
But I can only think about it because there's no errors or any logs about it in Ollama or Flowise
To Reproduce
Steps to reproduce the behavior:

Go to 'Agentflows'
Create new Agentflow or use template with supoervisor and workers
Use model qwen2.5-coder:14b-base-q8_0
See green popup "message stopped"

Expected behavior
This should work like with any other model
Screenshots
If applicable, add screenshots to help explain your problem.
Flow
If applicable, add exported flow in order to help replicating the problem.
Setup

Installation [docker]
Flowise Version [2.2.1]
OS: [Windows]
Browser [doesn't matter]

Additional context

Hey, looks like this is a known compatibility issue with certain model variants. The green "message stopped" popup without logs typically happens when there are model compatibility problems.
From a similar issue (#2557), this seems to be related to how different model variants handle agent-based workflows. Could you try using the base qwen2.5-coder model without the quantization suffix (14b-base-q8_0)? That version was shown to work in your testing.
If you absolutely need to use the quantized version, you might want to test with llama3.2 since it has better support for agent-based workflows, similar to what was resolved in #3361.
Let me know if either of those options helps!

@Cirr0e Hello. Yes - other models works. But from where this problem is?
Maybe we can turn on additional logs?

@Cirr0e Interesting...
On my another instance I reproduced this bug with llama3.2 and animal template like in https://github.com/FlowiseAI/Flowise/issues/3361
Animal Agents.json

Hmm, that is interesting. Let's try to get more visibility into what's happening:

First, let's enable debug logging to see what's happening under the hood. Add this to your Docker environment:

DEBUG=true

You can do this by either:

Adding it to your docker-compose.yml file
Or setting it as an environment variable: docker run -e DEBUG=true ...

The silent failure suggests there might be an incompatibility between the quantized model format and the agent's message parsing. This typically happens when the model output doesn't match the expected format that the agent executor expects.

About the sync button issue: When you sync, it's likely updating the ChatOllama node to a newer version that might have different expectations for model responses. Try this:

Before clicking sync, export your working flow
After sync fails, compare the ChatOllama node configurations

The code shows that agent execution is controlled by this sequence:
const executor = AgentExecutor.fromAgentAndTools({
    agent,
    tools,
    verbose: process.env.DEBUG === 'true' ? true : false,
    maxIterations: maxIterations ? parseFloat(maxIterations) : undefined
})

Can you try enabling debug logging and share:

What errors/logs you see in the console?
The exact ChatOllama node configuration before and after sync?

This will help us pinpoint exactly where the communication is breaking down between the model and the agent framework.
Be careful with:

Keep a backup of your working flows before experimenting
The debug logs might contain sensitive information, so review them before sharing

References:

Worker.ts shows the agent execution setup that's failing silently
Similar agent implementation patterns in XMLAgent.ts and ConversationalAgent.ts suggest this is a model compatibility issue rather than a template problem

Let me know what the debug logs show and we can dig deeper into the specific cause.

What errors/logs you see in the console?

2024-12-03 06:36:31 [INFO]: Starting Flowise...
2024-12-03 06:36:31 [INFO]: 📦 [server]: Data Source is initializing...
2024-12-03 06:36:38 [INFO]: 📦 [server]: Data Source has been initialized!
2024-12-03 06:36:38 [INFO]: ⚡ [server]: Flowise Server is listening at :3003
2024-12-03 06:37:02 [INFO]: ❌ DELETE /api/v1/chatmessage/68c8e197-29c1-4ec5-a1a7-008e729b79d4?chatId=fb1d048c-373b-436c-9ded-bbf3af4b31b1&chatType=INTERNAL
2024-12-03 06:37:14 [INFO]: ⬆ POST /api/v1/internal-prediction/68c8e197-29c1-4ec5-a1a7-008e729b79d4
2024-12-03 06:37:14 [INFO]: [server]: Chatflow 68c8e197-29c1-4ec5-a1a7-008e729b79d4_10531078-7041-4867-a229-0df8566f0c23 added into ChatflowPool

Animal Agents.json

I can't reproduce any bug on my second instance after adding DEBUG=true.
Placebo effect? :)

looks like this is a known compatibility issue with certain model variants

So, if this is a known BUG - it's better to close the issue?

DEBUG=true

Added this to my .env file.
Still no logs...
Any ideas?
Testing Q4, Q4_K_M, Q8 models - nothing works.

qwen2.5-coder:14b-base-q8_0 does not support tool calls, thats why
Only models that support tool calling can work with supervisor worker flow
Closing for now


<IP_ADDRESS> crashes xash-rt

0.200.6 was working fine.
Tested with: https://github.com/sultim-t/xash-rt/releases/tag/1.0.5a

Ah might have found the cause, because we had to add new _nvngx.dll exports to support Cyberpunk RR, that made the vulkan code try calling into a different _nvngx-only func, did add some code to try and wrap that func too, but was missing the lines to actually copy the funcptr for it over for our hook funcs to use... added fix for it in 327c631eaaa92279056ce784a692d9d69db98662
Could you see if it works with this build for you? DLSSTweaks_<IP_ADDRESS>-beta1.zip

Seems working now. Thank you!


update CMake module to work with Connext 5.2

This makes it build against Connext 5.2.
But currently the unit tests covering interoperability between different vendors fails with Connext 5.2.

+1

Please review.

+1


Enable keyboard navigation in notebooks

This PR fixes #6259
https://user-images.githubusercontent.com/34872381/151432354-188001dc-620a-4b7f-906a-de10ae5a0fbd.mov

Still seeing some behavior issues:

If I press enter on a text cell to "enter" it then the mode changes but the icon in the toolbar doesn't change to match (same with pressing escape to get out)
If I press enter on a code cell after navigating to it via arrow keys then it puts the cursor in the cell but also adds a newline as well - I would expect it to behave like the text cell where pressing enter brings you into "edit" mode but doesn't actually type anything
Once I'm editing in a code cell I can't seem to exit it - pressing esc does nothing
If I click once on a code cell then the cursor is put in there but I can still navigate via arrow keys. If I click a second time though then arrow keys navigate within the cell
If I click once on a code cell and navigate to a different cell the cursor stays on the first cell - and so if I start typing it puts the text in the first cell

Single click on code cell, cursor is put in there immediately and I can start typing. If I press up/down arrows then the "active" cell is moved and the cursor ALSO moves.
Click on a code cell - the cursor is put there immediately. Pressing the escape key does nothing at this point. Press enter and nothing appears to change (no newline is added, which given that the cursor is in there would be the expected behavior). Now if I press the escape key it "exits" the cell as expected. (behavior here should be that clicking on a code cell doesn't enter "edit" mode for the cell until you press enter/double click)
If you're at the top/bottom of a long notebook and move up/down (so it rolls back to the other end of the notebook) then the view doesn't change - you have to scroll to the new cell yourself.

Navigating using the arrow keys moves the view window slightly within the Notebook, but doesn't necessarily scroll the new "active" cell into view (easy to see if you make a couple really long cells and navigate down). This and the previous one are likely the same fix - scroll new cell into view when navigated to

If I'm in "browse" mode (not editing any cell) and press tab then we start tabbing through the elements (expected). But if I tab into a code editor than the cursor is put into the editor and we're now "editing" that cell even if the current "active" cell is still the original one I had selected. We should discuss what the behavior we want here - but given the other issues it seems like we may want to have the code cells also have a separate state from active and if not in edit mode then tabbing over them won't enter edit mode


django version is a bit old

Right now, we want the ability to use the newest 4.x version but having django 5 maybe commented out in requirements.in?

Taken care of in #7


[WIP] Load previous messages from the logs

This is highly WIP. I'm not sure how successful it will be, but it's sad we have (almost) everything in the logs and we can't read from them when we restart the app (I know, I know, , but this is really just an attempt to read from what we have at minimal cost.
TODO
I'm sure there are many TODOs before I could call this remotely reviewable, so I'll be listing them here to keep track of stuff.

[x] Replay previous messages:

[x] At startup
[x] When joining a channel
[x] When clicking on a nick (/whois)
[x] When querying someone (/query)
[x] When receiving a message from someone that opens a new window

[ ] Display all types of messages:

[x] Messages
[x] Actions
[x] Joins
[x] Modes
[x] Nick changes
[x] Parts
[x] Quits
[x] Topics
[ ] Others

[ ] Use the history limit to not load everything from files
[ ] Display actual timestamp instead of time when logs were read
[ ] Clean up that uuuugly repeated code for parsing messages...

Load previous messages at startup
Load previous messages at join
Load previous messages when starting a private discussion

All these can be fixed by doing log reading in Chan constructor, after #664 is fixed.

All these can be fixed by doing log reading in Chan

Yeah, but I had no access to thing like username in there, so I put it where it is right now for convenience. Most likely not a definitive solution.
Also, putting it in the constructor means backlog loading is done all the time by default, which may not be what we want? I'm thinking if we need to instantiate an empty Chan, or in tests, etc. I don't know, I'm still playing with this :)

This made my instance unresponsive (no response from server). I do have 5,656,482 lines of logs (360M) though.
CLI output looked normal, i.e. User Impaloo loaded. yada yada.

Welp, I wouldn't expect anything different from a PR that loads all 360M of logs, in a sync fashion, and doesn't try anything smart about it 😅.
I knew there are serious issues regarding performance for now, I would not recommend this PR in production at the moment!
This is something I'm planning to tackle very soon though, now that feature itself is almost ok.

@astorije Is this still something you want to get done in this PR? I think it would be great if we got this or mysql done for the next version (not 2.3)

@YaManicKill, I definitely want this to happen. It's not on the top of my todolist, but I will get back to it, yes :)
We already have all these log files hanging around, it's a shame not to display them at startup :D

+1 for getting this done - it would make patching underlying operating systems much less noisy event  :)
Thanks for all your great work!

Is this functioning?


docs: adding dark-mode setup page, resolves #236

I'm not really familiar with astro or laravel integration, so I left them for others to help.

Thanks Saeid, I'll add Astro part from shadcn-ui


included glfw source does not build with MSVC

I'm using MSVC version 19.00.2306 for x64 (the version included with visual studio 2015) on windows and compiling a project using nim-glfw without -d:glfwDynlib results in linker errors for pretty much every GLFW function.
Perhaps glfwDynlib should be the default for some configurations

I do agree that dynamic linking by default is better

It is the default now


Update system-requirements.md

Issue #2698 - Updated the document with the reason for NAS support limitation.

@nenonix @JohanFreelancer9 Copy editing is needed for this PR. Thanks.

@MicrosoftHeidi PR has been copyedited and is ready for final review, could you please check and merge? Thanks!


Revert "Revert "(maint) Update Gemfile to use beaker 3.1 in acceptance tests""

Reverts puppetlabs/facter#1442
Jenkins jobs now use ruby 2.3.1

👍

CLA signed by all contributors.


file body extended glob test for multiple extensions

I have just discovered there is a missing test scenario. There are tests for multiple extensions, eg for

"*|mp3,flac"

which means * applies to the folder naming meaning match any directory, and "mp3,flac" matching files with either of these extensions. But what about multiple extensions including a body element to the filter, eg files begining with A, which would be represented with any of the following

"|A.jpg,flac"
"|A.jpg,.flac"

When the suffix list constist of entries that do not contain a dot, then they are assumed to be extensions:

"*|mp3,flac"

This means that the dot is optional. The dot can be stated explicitly eg:

"*|.mp3,.flac"

If you wanted to also specify a body component, then the dot must be specified as it acts as a demarkation between the body and the suffix.

"|A.jpg,.flac"

Since the sub filteres are composed by splitting by comma, the "A" in the above example only applies to .jpg files, not .flac files. The flac files would have to have it's own body element if so required.

This test has exposed an issue:
func filterFileByGlobEx(name, base, exclusion string,
	suffixes []string, anyExtension bool,
) bool {
	extension := filepath.Ext(name)
	baseName := strings.ToLower(strings.TrimSuffix(name, extension))

	if baseMatch, _ := filepath.Match(base, baseName); !baseMatch {
		return false
	}

	if excluded, _ := filepath.Match(exclusion, baseName); excluded {
		return false
	}

	return cmp.Or(
		func() bool {
			return anyExtension
		}(),
		func() bool {
			return extension == "" && len(suffixes) == 0
		}(),
		func() bool {
			return lo.Contains(
				suffixes, strings.ToLower(strings.TrimPrefix(extension, ".")),
			)
		}(),
	)
}

assumes that the filter is an extension filter.


Shift Left/Right greater than size of underlying integer results in undefined behaviour

According to the spec (and in practice) shifting left/right greater than the number of bits in the underlying integer results in strange results, rather than the 0 that you might expect. It would be useful if this page called that out.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 02b8f7c2-379e-7876-0d36-25b06a294baa
Version Independent ID: 2410c828-0c66-9efe-ae87-9b07708aa731
Content: Bitwise and shift operators - C# reference
Content Source: docs/csharp/language-reference/operators/bitwise-and-shift-operators.md
Product: dotnet-csharp
Technology: csharp-language-reference
GitHub Login: @pkulikov
Microsoft Alias: wiwagn

@NichUK could you please provide an example of such a behavior

Currently, the actual number of bits to shift is described in the article in this section:
https://docs.microsoft.com/en-us/dotnet/csharp/language-reference/operators/bitwise-and-shift-operators#shift-count-of-the-shift-operators

@NichUK Have you checked the text in the preceding comment? I think the linked reference addresses your concern.
I believe this can be closed as addressed, I'll close it, but if you think there should be more clarification, reopen it and add your thoughts.

Thanks Bill, I hadn't noticed the section at the bottom of the document. It might be sensible to move it directly adjacent to the shift left/right sections, as it's important information which should really be read as part of those sections.
Also, since it's a potential pain point if it's missed, personally I'd pull it out and make the meaning a little more obvious, but I agree that there is sufficient info there if the reader examines it carefully.

@NichUK what do you think of changes in #16656? Rather than moving the section, I've referenced it from the beginnings of the shift operator sections.