Brave browser does not start

Issue description
Brave browser installation succeeds but cannot start:
$ journalctl -b | grep [b]rave
Feb 26 14:57:36 acyuta-nixos0 kernel: traps: brave[2446] trap int3 ip:555883b8e8e7 sp:7fff20e26400 error:0 in brave[55587fedc000+6962000]

Steps to reproduce
$ nix-env -i brave
warning: there are multiple derivations named 'brave-0.59.34'; using the first one
installing 'brave-0.59.34'

$ ls -la `which brave`
lrwxrwxrwx 1 root root 67 Dec 31  1969 /home/acyuta/.nix-profile/bin/brave -> /nix/store/2sh5sjlxsivni380xhd27n9wk3bzha47-bra
$ brave
Trace/breakpoint trap

Technical details
nix-shell -p nix-info --run "nix-info -m"

system: "x86_64-linux"
host os: Linux 4.14.98, NixOS, 19.03pre169108.36f31600749 (Koi)
multi-user?: yes
sandbox: yes
version: nix-env (Nix) 2.2
channels(root): "nixos-19.03pre169108.36f31600749"
channels(acyuta): "nixos-18.09-18.09.2203.9bd45dddf81, nixpkgs-19.03pre169106.1a88aa9e0cd"
nixpkgs: /home/acyuta/.nix-defexpr/channels/nixpkgs

I can't reproduce this on master or with the version you have installed.
I think the issue might be with  nix-env because of the warning
warning: there are multiple derivations named 'brave-0.59.34'; using the first one

I've been using Brave successfully on Koi and now on Loris. However, I install it via configuration.nix. Try using the nix-shell verbosity options to troubleshoot further.

Nope. Reinstalled from configuration.nix did not work and install into nix-shell no difference either:
$ nix-shell '<nixpkgs>' -i brave --verbose --pure
.... # a lot of out put from installation
$ brave
Trace/breakpoint trap

I'm total Nix noob so I'm not sure how to troubleshoot this further and I'm not sure what you mean by

Try using the nix-shell verbosity options to troubleshoot further.

Thanks for your help

Bam! Fixed it:
strace /nix/store/2sh5sjlxsivni380xhd27n9wk3bzha47-brave-0.59.34/bin/brave
...
stat("/home/acyuta/.config/BraveSoftware/Brave-Browser", 0x7fff2669a870) = -1 EACCES (Permission denied)
...

Fixed permissions: sudo chown acyuta: ~/.config/BraveSoftware
Not sure how the permissions where messed up but this fixed it.


Bounding box app: demo using imshow with binary_string / source

This PR shows how to modify existing apps on image processing in order to use imshow with the "fast mode". Note that binary_string is True by default for RGB images so it is not specified here.

Really excited to try out the improved px.imshow!
Also sorry about the conflicts; i accidentally modified the config.yml on master rather than on my branch. oops!

Closing favor of #498


Fix compression in the awskinesisexporter and thread safe

Description
There are two main changes in this PR:

Fixing a bug relating to the compression with EOF markers added in
Adding sync.pool for the compressor so that it is thread safe

1st bug
When checking the output of the gzip compressed data, there are errors such as:
EOFError: Compressed file ended before the end-of-stream marker was reached

Received unexpected error: unexpected EOF

This affects zlib, flate and gzip
This is because the Flush does not added the EOF markers. Close() is required be called to mark the EOF.
Fix: Changed Flush to Close so that EOF markers are added to end of compressed payload
2nd bug
There is a race condition with the compressor because the queued retry allows multiple consumers - see here for documentation
Hence, when there is a retry in the kinesis exporter, it can cause a race condition as the concurrent consumers are reusing the same compressor object
│ compress/flate.(*huffmanBitWriter).indexTokens(0xc0000523c0, {0xc04ed22000, 0x4e4, 0xd?})                                                                                │
│     GOROOT/src/compress/flate/huffman_bit_writer.go:551 +0x2a5                                                                                │
│ compress/flate.(*huffmanBitWriter).writeBlockDynamic(0xc0000523c0, {0xc04ed22000?, 0xc0580b75e0?, 0x6b90a2?}, 0x0?, {0xc04ecac000, 0x31aa, 0xffff})                                                                                │
│     GOROOT/src/compress/flate/huffman_bit_writer.go:509 +0xc5                                                                                │
│ compress/flate.(*compressor).encSpeed(0xc04ec02000)                                                                                │
│     GOROOT/src/compress/flate/deflate.go:362 +0x259                                                                                │
│ compress/flate.(*compressor).close(0xc04ec02000)                                                                                │
│     GOROOT/src/compress/flate/deflate.go:638 +0x76                                                                                │
│ compress/flate.(*Writer).Close(...)                                                                                │
│     GOROOT/src/compress/flate/deflate.go:730                                                                                │
│ compress/gzip.(*Writer).Close(0xc000a548f0)                                                                                │
│     GOROOT/src/compress/gzip/gzip.go:242 +0x87                                                                                │
│ github.com/open-telemetry/opentelemetry-collector-contrib/exporter/awskinesisexporter/internal/compress.(*compressor).Do(0xc0005205d0, {0xc07ed42000, 0x31aa, 0x31aa})                                                                                │
│     external/com_github_open_telemetry_opentelemetry_collector_contrib_exporter_awskinesisexporter/internal/compress/compresser.go:84 +0x99                                                                                │
│ github.com/open-telemetry/opentelemetry-collector-contrib/exporter/awskinesisexporter/internal/batch.(*Batch).AddRecord(0xc07a1f6740, {0xc07ed42000?, 0xc0580b7748?, 0xc0580b7748?}, {0xc07e7cce70, 0x24})                                                                    │
│     external/com_github_open_telemetry_opentelemetry_collector_contrib_exporter_awskinesisexporter/internal/batch/batch.go:92 +0x57                                                                                │
│ github.com/open-telemetry/opentelemetry-collector-contrib/exporter/awskinesisexporter/internal/batch.(*batchMarshaller).Logs(0xc00051e460, {0x49bfa0?})                                                                                │
│     external/com_github_open_telemetry_opentelemetry_collector_contrib_exporter_awskinesisexporter/internal/batch/encode_marshaler.go:64 +0x1ef                                                                                │
│ github.com/open-telemetry/opentelemetry-collector-contrib/exporter/awskinesisexporter.Exporter.consumeLogs({{0x4575ce0?, 0xc0002ee940?}, {0x4580b10?, 0xc00051e460?}}, {0x4594908, 0xc07625acc0}, {0x4594940?})                                                               │
│     external/com_github_open_telemetry_opentelemetry_collector_contrib_exporter_awskinesisexporter/exporter.go:152 +0x48                                                                                │
│ go.opentelemetry.io/collector/exporter/exporterhelper.(*logsRequest).Export(0x4594940?, {0x4594908?, 0xc07625acc0?})                                                                                │
│     external/io_opentelemetry_go_collector_exporter/exporterhelper/logs.go:65 +0x34                                                                                │
│ go.opentelemetry.io/collector/exporter/exporterhelper.(*timeoutSender).send(0xc000443778, {0x45a4208, 0xc07ea37440})                                                                                │
│     external/io_opentelemetry_go_collector_exporter/exporterhelper/common.go:208 +0x96                                                                                │
│ go.opentelemetry.io/collector/exporter/exporterhelper.(*retrySender).send(0xc00068f900, {0x45a4208, 0xc07ea37440})                                                                                │
│     external/io_opentelemetry_go_collector_exporter/exporterhelper/queued_retry.go:394 +0x596                                                                                │
│ go.opentelemetry.io/collector/exporter/exporterhelper.(*logsExporterWithObservability).send(0xc0003c6b10, {0x45a4208, 0xc07ea37440})                                                                                │
│     external/io_opentelemetry_go_collector_exporter/exporterhelper/logs.go:135 +0x88                                                                                │
│ go.opentelemetry.io/collector/exporter/exporterhelper.(*queuedRetrySender).start.func1({0x45a4208, 0xc07ea37440})                                                                                │
│     external/io_opentelemetry_go_collector_exporter/exporterhelper/queued_retry.go:205 +0x39                                                                                │
│ go.opentelemetry.io/collector/exporter/exporterhelper/internal.(*boundedMemoryQueue).StartConsumers.func1()                                                                                │
│     external/io_opentelemetry_go_collector_exporter/exporterhelper/internal/bounded_memory_queue.go:58 +0xb6                                                                                │
│ created by go.opentelemetry.io/collector/exporter/exporterhelper/internal.(*boundedMemoryQueue).StartConsumers                                                                                │
│     external/io_opentelemetry_go_collector_exporter/exporterhelper/internal/bounded_memory_queue.go:53 +0x45

Fix: Used sync.pool to instantiate the compress writers so that it is goroutine safe

A suggestion:
Break it down into 2 PRs. 1 PR per bug. Upstream is somewhat sensitive about PR being small and addressing a single bug!
The compressor pool should be super easy to merge into upstream. The error message is self-explanatory.

A suggestion: Break it down into 2 PRs. 1 PR per bug. Upstream is somewhat sensitive about PR being small and addressing a single bug! The compressor pool should be super easy to merge into upstream. The error message is self-explanatory.

Sounds good! Thanks Foad! I will merge this in so i can build the otel collector and have 2 separate PRs to raise for upstream


[Performance]: [Speculative Decoding] Measurement of Cost Coefficient through vLLM

Proposal to improve performance
Recently, vLLM has been conducting a lot of work related to Speculative Decoding, and we often see remarkable achievements.
For the Speculative Decoding algorithm to achieve maximum efficiency, it is important to consider not only the performance of the draft and target models but also the speed of each model.
According to the Definition 3.7 from original Speculative Decoding paper, the latency ratio between the target model  and the draft model is referred to as the Cost Coefficient c. And it is assumed that the c value is very small.
🤔 However, when I examined the vLLM github repo as far as I can, I could not find any information related to the Cost Coefficient.
I have attempted various methods to obtain the Cost Coefficient value for each model on my own. For example:
VLLM_ATTENTION_BACKEND=FLASH_ATTN nsys profile -t cuda,nvtx,osrt,cudnn,cublas -o llama_7b_nsight_report ./venv/bin/python3 ./benchmarks/benchmark_latency.py --model NousResearch/Llama-2-7b-hf --enforce-eager --input-len 128 --output-len 2 --batch-size 1 --num-iters-warmup 5 --num-iters 5
VLLM_ATTENTION_BACKEND=FLASH_ATTN nsys profile -t cuda,nvtx,osrt,cudnn,cublas -o llama_1.1b_nsight_report ./venv/bin/python3 ./benchmarks/benchmark_latency.py --model TinyLlama/TinyLlama-1.1B-Chat-v1.0 --enforce-eager  --input-len 128 --output-len 2 --batch-size 1 --num-iters-warmup 5 --num-iters 5
VLLM_ATTENTION_BACKEND=FLASH_ATTN nsys profile -t cuda,nvtx,osrt,cudnn,cublas -o llama_160m_nsight_report ./venv/bin/python3 ./benchmarks/benchmark_latency.py --model JackFram/llama-160m --enforce-eager  --input-len 128 --output-len 2 --batch-size 1 --num-iters-warmup 5 --num-iters 5
VLLM_ATTENTION_BACKEND=FLASH_ATTN nsys profile -t cuda,nvtx,osrt,cudnn,cublas -o llama_68m_nsight_report ./venv/bin/python3 ./benchmarks/benchmark_latency.py --model JackFram/llama-68m --enforce-eager  --input-len 128 --output-len 2 --batch-size 1 --num-iters-warmup 5 --num-iters 5

Additionally, I used NVTX to mark the model running part. Below is the modified part of model_runner.py
torch.cuda.nvtx.range_push("model_executable()")
hidden_or_intermediate_states = model_executable(
    input_ids=model_input.input_tokens,
    positions=model_input.input_positions,
    kv_caches=kv_caches,
    attn_metadata=model_input.attn_metadata,
    intermediate_tensors=intermediate_tensors,
    **multi_modal_kwargs,
    **seqlen_agnostic_kwargs)
torch.cuda.nvtx.range_pop()

(I will upload the profile image for LLaMA-68 only.)

🤔 Here is the profile results obtained using Nsight System.

Model
Profiled Time (ms)
Cost Coefficient

LLaMA 7B
16.607
1.00

LLaMA 1.1B
11.427
0.68

LLaMA 160M
5.635
0.33

LLaMA 68M
1.099
0.06

One of the most notable point here is that, when comparing LLaMA-7B and LLaMA-160m, the Cost Coefficient was measured to be 0.33. I assume that this result suggests that when applying Speculative Decoding with the combination of these two models, the efficient range of num_speculative_tokens is constrained to approximately 3 or 4.
In the original Speculative Decoding paper and the recently published paper (Online Speculaitve Decoding), the Cost Coefficient is used at a much smaller value, around 0.05 or 0.13.
Therefore, I am curious if vLLM has considered such Cost Coefficients when implementing Speculative Decoding, or if it is something that can be disregarded during the vLLM Speculative Decoding serving. Additionally, I would kike to know if the measurement process I did was correct! 🙏
Report of performance regression
No response
Misc discussion on performance
No response
Your current environment (if you think it is necessary)
The output of `python collect_env.py`

Speculative decoding might be slower than non-speculative if the drafter model is too slow or inaccurate. Using a simple simulation, we get the following heatmap:

@bong-furiosa the cost coefficient is more like a configuration by users, meaning that you could refer to this criteria when selecting the draft model. vLLM just executes whatever you configured, because it cannot select the draft model for you, after all.
For your measurement, although this doesn't include other system overheads such as scheduling and sampling, I'd say it's generally ok, because @cadedaniel is leading community efforts to resolve such overheads as possible. Please keep an eye on related updates on issues and PRs and you would see obvious improvements over time.

Hello @keyboardAnt ! I have read your DSI paper before (also DISCO, recently). At that time, I didn't pay close attention to it because I wasn't considering Specuding Decoding. It's happy to be reminded of your paper and to meet the author.
The table you provided from the paper seems like it will be a great reference when using Speculative Decoding in vLLM!
@comaniac, Thank you for understanding my interest in the Cost Coefficient values for Speculative Decoding in vLLM!
Indeed, through PRs and ISSUEs, I have observed that many experts, including @cadedaniel, are making efforts to reduce serving overhead during Speculative Decoding. I will keep looking forward to seeing further improvements in vLLM.
Since I received excellent response to this ISSUE, I will close it.

By the way, it would be great to measure the cost coefficient in vLLM and report it in the metrics. I can direct you to the relevant code sections if that interests you.

Hello @cadedaniel !
Thank you for understanding my interest in the Cost Coefficient impact on the vLLM serving system. 🙇
I have reached out to you via email regarding this concern.
I would appreciate it if you could check it.


Adding public API test coverage for Aspire.Hosting.Nats

Initial issues #2649
Issues Check List: Validate arguments of public methods
Microsoft Reviewers: Open in CodeFlow

/azp run


⚠ Jenkins Plugins Artifactory has degraded performance

In ccecabb, Jenkins Plugins Artifactory (https://get.jenkins.io/plugins/artifactory/) experienced degraded performance:

HTTP code: 200
Response time: 1223 ms

Resolved: Jenkins Plugins Artifactory performance has improved in 34923d7 after 32 minutes.


Can categories be displayed via dataLabels?

I see that series can, but how would I display categories in bar as well?

@diomed I failed to understand what you mean. Can you please elaborate?
Are you looking for something like this?

yes

I will put the above example in website demo pages soon.
For now, you can try the following code to achieve the same result
{
  plotOptions: {
    bar: {
      horizontal: true,
      dataLabels: {
          position: 'bottom'
      },
    }
  },
  dataLabels: {
    enabled: true,
    textAnchor: 'start',
    style: {
        colors: ['#fff']
    },
    formatter: function(val, opt) {
        return opt.globals.labels[opt.dataPointIndex] + ":  " + val
    },
    offsetX: 0,
  },
  yaxis: {
    labels: {
      show: false
    }
  }
}

Added example on website https://apexcharts.com/javascript-chart-demos/bar-charts/custom-datalabels/


added camunda spec changes again

JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/CIV-5245
Change description
Updates needed to Specified  - Camunda/BPMN for integrating the PBAv3 Service
Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[x] No

No longer needed. This was handled in CIV-6204 and its PRs.


chore: Add nightly test of large repos

I’m concerned the clone cost of Docs may be too large, even just daily. But maybe not. Could you please start with a PR to test-repos.yml to use clone-large instead (like you did here)? That will give us a comparison against the current 40s run time today: https://github.com/DavidAnson/markdownlint/actions?query=workflow%3ATestRepos
If it’s pretty close to the 2m time that CI runs now, we can feel good about going with that change instead of a new workflow.

@DavidAnson I through an extra commit in this PR to get the timings you were looking for. I can just rebase it off afterwards

Perfect.

It’s still faster than CI! Let’s just make it part of the existing action. Thanks for doing this!

OK, I'll rebase out the first commit and fix the commit message

Done, unless you just want to flatten down the "large" with the normal. I'm guessing the CI might be getting some download/cache bump that won't be as quick locally though

Right. “Large” takes a while to run on my Raspberry Pi.


bump core latest stable to 15.5.0

Merging because testing tag was already checked in https://github.com/stellar/docker-stellar-core-horizon/pull/237.


 value gets overwritten on every redraw

...regardless of whether it has changed or not.
It's as if input.value bypasses the diff algorithm altogether, whereas other types of properties only seem to be reapplied when they change.
Demonstration: https://jsfiddle.net/tezo5c2q/
This is surprising + annoying because it requires hacky special-casing for inputs - if you're not working outside the classic oninput: m.withAttr('value', gettersetter) pattern - or alike.

It does this because the model may change differently from what was typed. Under what case is this problematic?

I'm comfortable with the diff-engine updating input.value when the vElm's attrs.value has changed between redraws - but that is not the case. Instead the input.value is overwritten/updated on every redraw.
This means input.value behaves differently from any other DOM property, attribute or nodeValue.

As far I know it only does that if the input is in focus AND its vdom node has a value property defined.
It needs to ensure that what's in the DOM mirrors what's in the virtual DOM. Here's an example:
var data = ""
function update(e) {
  if (data.length < 5) data = e.target.value
}

m.mount(document.body, {
  view: function() {
    return m("input", {oninput: update, value: data})
  }
})

In the case above, typing will clamp data to be 5 chars long at most, but if the DOM isn't synced to data, it will display wrong a value that doesn't match what's in data because typing in a input changes the DOM element's state on its own.
I don't understand what problem your jsfiddle is supposed to be demonstrating.

I guess my jsfiddle could have been more clear.
Steps to replicate:

Focus the  and type in some text.
Click anywhere inside the mithril rendered DOM.

Result:
The  value returns to its initial value - as soon as redraw is triggered by the no-op onclick handler on the containing .
Expected result:
No change to the  displayed value - as the vdom node's value hasn't changed.
Note how if you focus the <div class="input" contenteditable="true"> element below and type some text into it and then click, the redraw does not return the <div>'s innerHTML to its initial value.

My real-world use case involves a mithril-generated <input> that I want to allow user's to type freely and only parse and update the value property in the model onchange.
However, while I'm typing (and the input field is still focued) I move my mouse and trigger an onmouseover handler elsewhere in the DOM, my field's value gets returned to the last-saved value.
As I said, I know of at least two different ways I can work around this problem - but having to do that seems awkward and inconsistent with how mithril handles other similar cases (as illustrated in the jsfiddle) where the real DOM is left untouched as long as the vdom properties are unchanged.
I find myself unable to explain to my team-members, why mithril behaves this way only with input values. It feels like a bug - or an arbitrary inconsistency at best.

Ah I see. To be honest, that's behaving as it should. The code literally says to set the value to "Default input value" on every redraw.
There are two ways to deal with it: one is to setup a variable to track the input value and update it on the oninput event, and the other is to set the initial value via config
A third slightly different option would be to use the placeholder attribute (but this one may or may not work for your specific case)

I find myself unable to explain to my team-members, why mithril behaves this way only with input values.

The explanation is the snippet I posted above. Basically, there's no way to support that use case and what you're expecting at the same time.

But why the difference between input.value and div.innerHTML ?
Why the difference between input.value and any other property – like for instance a div with a config function that updates the div's properties on the first draw (i.e. when isInit===false). The modified properties stay intact across all 'diff' redraws until the vdom property changes.

Or is my mistake, perhaps, to make any assumptions at all about the diff behavior?
Should I not be taking advantage of the 'diff' behavior, ever?
If so, how do config functions that initialize third-party plugins/etc. factor into that?

input value almost always changes if the user types so it's relatively common to run into that use case. innerHTML typically doesn't react to user input. In the case of a contenteditable div, it might make sense for it to update like input value does, but the code currently doesn't special case it.
config breaks out of the diff engine and allows you to modify the DOM however you want. Ideally you should prefer to use the oninput solution if you're going to be tracking the data in input value.

Thank you for the help understanding.

Lessons learned:

Don't make any hard assumptions about redraw not updating DOM properties/nodes on next redraw - regardless of if the state has changed or not.
Assigning "static" initial value via a config function is the proper way to accomplish what I was trying.  Updated jsfiddle: https://jsfiddle.net/tezo5c2q/1/


Accessing all trees with branch lengths often fails on many entries

Need to update/improve the XML crawling and handling of errors from the database.

Fixed.  Can make multiple attempts if a read fails.


Can DiCE support any regression model?

Hi,
Can DiCE support any regression model? E.g., just specifiy the loss function as the MSE loss?
Thanks

You can use the l2_loss' option for yloss_type' parameter in generate_counterfactuals() method and it will find counterfactuals. However, there will be some inconsistencies with the print summary and some variables of the explanation class because this part of the code was written with classification models in mind. Specifically, the code needs a little tweaking in the areas where target_cf_class variable of dice explanation object occurs. I will update them soon but feel free to raise a PR to contribute. Thanks!


Integrate arg parser

Description
Please include a summary of the changes and the related issue. Explain the motivation behind the changes and any relevant context.
Related Issue
Link to the related issue(s) using the format Fixes #<issue_number>.
Commits

${{ github.event.pull_request.commits }}
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Include any relevant details for your test configuration.

This needs some updates to build properly.

New test results


Hacks and fixes to enable picolibc CI on MSP430

Here's a series of hacks I wrote which allow me to use mspsim to run picolibc tests. There's only one actual fix here -- extending the CG3 -1 value to 20 bits. Everything else just makes the Tyndall emulator capable of working in picolibc CI.

All the changes look reasonable from a quick glance, but the source code for MSPSim silently moved into the Cooja repository (https://github.com/contiki-ng/cooja) a while ago. We need to update README.md with that information.
I started writing some explanations, but the MSPSim entry-point is only half-integrated with the Cooja entrypoint. That headache is not yours, can we gradually cherry-pick these patches (or equivalents) into the MSPSim that lives in the Cooja repository?

I'm probably going to abandon this series as the binutils-gdb simulator is already integrated into the crosstool-ng toolchain, making that far easier to add to the picolibc CI environment. Please feel free to do whatever you like to these patches.


Feature request / development query

I just found this extension and it's great! I have a feature request but I don't see it being actively developed recently. Is it still being worked on and is the dev open to feature requests? Thanks.

please add another issue if you want, thanks 😁


[build] Cannot build for Android due to missing "logo" image files

Issue description
Trying to build an APK file for the Android system tracking instructions given here: https://github.com/raysan5/raylib/wiki/Working-for-Android
I cannot successfully compile it due to error consisting of missing some "logo" files (I'm stuck after the step 1 of the "Compiling a raylib game for Android"). I even tried to add some junk images manually, but still with no success... I was using also "xcopy" command as it was suggested and even looking at Discord discussion, but I haven't found any solution. May I ask for any attention?
Environment
Compilation for Android on Windows 10 64-bit operating system. Using "raylib" v. 3.0 taken from the official installer.
Issue Screenshot

@JasonNumberThirteen It seems the issue is related to logo images not installed by the default raylib installer, you can find them in GitHub raylib/logo.
Also note that Makefile should be reviewed to point to your Android SDK/NDK paths and API version.

@raysan5 Thanks for your answer. Indeed, adding the "logo" directory solved the problem, but after all it should be provided by main installer. It's only my suggestion.


Allow for dual stack services to use when enabling experimental dual …

…stack support
Please provide a description of this PR:
Part of the blog https://github.com/istio/istio.io/pull/12253 will reference these files to allow for user experimentation to provide feedback for developers doing dual stack work.

@jacob-delgado: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
b180f6354110d44f785128e5a570b07b3b63f4c8
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test unit-tests-arm64


Open label on the position is confusing

User feedback:

This is a minor wording issue: "Open" in the UI expands this box, but could also indicate this position is open/active. "Expand" or "View Details" would avoid the confusion.

As we can see, open was confusing to the user.
Given we don't have closed positions, I propose to simply remove this label.

are you sure we don't want to keep closed positions for historical reasons? I always found it very useful to be able to see through historical positions, and how they went. (wallet history does not substitute it, because we there might be other transactions in between the open / close position ones).

I think this ticket is not about whether we want to keep a history of positions, but that the label on top of the position card (open) currently doesn't make much sense. Removing that label is easy and can be done quickly.
I would create a separate ticket for showing a history of closed positions.

are you sure we don't want to keep closed positions for historical reasons?

In the danger of starting a whole new discussion:
In the concept of a combined position I don't see a closed position being a useful thing. What you want to see is your trade executions, ideally with PnL per trade. The original idea was to show this kind of information in the History tab which has been removed from the scope for now.

are you sure we don't want to keep closed positions for historical reasons?

In the danger of starting a whole new discussion:
In the concept of a combined position I don't see a closed position being a useful thing. What you want to see is your trade executions, ideally with PnL per trade. The original idea was to show this kind of information in the History tab which has been removed from the scope for now.

that would work indeed! thank you for the explanation, it makes sense.

this seems to be fixed in the issue linked above.


Fatal error on startup

stacks-cli version: 0.1.42
node version: 8.9.1 32bits
steps to reproduce: simply run stacks-cli after installing it with npm i -g stacks-cli
error:
/usr/local/lib/node_modules/stacks-cli/bin/cli.js:16
const wappalyzer = require('wappalyzer')(options);

TypeError: Class constructor Driver cannot be invoked without 'new'
    at Object.<anonymous> (/usr/local/lib/node_modules/stacks-cli/bin/cli.js:16:41)
    at Module._compile (module.js:635:30)
    at Object.Module._extensions..js (module.js:646:10)
    at Module.load (module.js:554:32)
    at tryModuleLoad (module.js:497:12)
    at Function.Module._load (module.js:489:3)
    at Function.Module.runMain (module.js:676:10)
    at startup (bootstrap_node.js:187:16)
    at bootstrap_node.js:608:3

installed versions of dependencies:
npm ls --depth=0
<EMAIL_ADDRESS>/usr/local/lib/node_modules/stacks-cli
├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>└──<EMAIL_ADDRESS>
mitigation: if I downgrade to wappalyzer 5.1.6 it works.

Same error with node 9.2.0 x64 on Windows 10

same error with node v7.10.0 on Ubuntu Linux 16.04

I faced the same issue with node v8.7.0. The suggested mitigation worked for me. Seems like this is a compatibility issue with<EMAIL_ADDRESS>

same for for me:
/usr/local/lib/node_modules/stacks-cli/bin/cli.js:16
const wappalyzer = require('wappalyzer')(options);
                                        ^

TypeError: Class constructor Driver cannot be invoked without 'new'
    at Object.<anonymous> (/usr/local/lib/node_modules/stacks-cli/bin/cli.js:16:41)
    at Module._compile (module.js:635:30)
    at Object.Module._extensions..js (module.js:646:10)
    at Module.load (module.js:554:32)
    at tryModuleLoad (module.js:497:12)
    at Function.Module._load (module.js:489:3)
    at Function.Module.runMain (module.js:676:10)
    at startup (bootstrap_node.js:187:16)
    at bootstrap_node.js:608:3
➜  ~ node -v
v8.9.1```

Same here.

Same here running on Mac OS 10.12.6
➜ node -v
v7.8.0

Same here on OSX 10.13.1 / Node v8.9.1

Same for OSX 10.12.6 / Node v7.5.0

Same on Ubuntu 16.04 / Node v8.2.1

Same for OSX 10.12.16 / Node v8.9.1

I think by now we know it is not related to any Node version or OS :)
As @sbmthakur said, it looks like it is<EMAIL_ADDRESS>

Hello all, thanks for all of your time and patience at first 🙏, just like @sbmthakur and @karli2000  said, it seems have some conflict with<EMAIL_ADDRESS>this version, so I just downgraded it to @5.1.6 and released<EMAIL_ADDRESS>already. Actually I didn't expect this side project can receive such a huge attentions, so if there's still some potential issues, Pull Request or opening a new issue always welcome, and I will try to figure it out in my spare time, thanks everybody again.

Nice work @WeiChiaChang, fixed over here 👍


cgosqlite: import SQLite amalgamation v3.43.0

I ran go test ./... locally. We could put that in the CI.
The bigger set of tests are when the go.mod change is imported into corp, and we see if semantics have changed with our main set of tests.


Adding mrs_uav_trackers to existing projects

Hi there,
I have currently an working project that I have been working on it for some time. I added already some functionalities and I would like now to try some other things like pure pursuit / path following. This seems to be well developed and tested on this package. Which I would love to test on my system.
Is there an "easy" way to integrate this package in existing "non-mrs" projects? I mean is there an generic interface where I could provide my pose/odom input and get a pose output for the offboard controller?
Many thanks and great work guys!

Hey, with a little bit of work and refactoring I think you can use mrs_uav_trackers outside of mrs system. I assume that you are most interested in the MpcTracker. The trackers within this package follow this interface (https://github.com/ctu-mrs/mrs_uav_managers/blob/master/include/mrs_uav_managers/tracker.h)[https://github.com/ctu-mrs/mrs_uav_managers/blob/master/include/mrs_uav_managers/tracker.h]. So if you will emulate the actions of the ControlManager, the code will work for you. Which means:

call the initialize() method first.
call the activate() method, this starts timers within the tracker and sets up the initial conditions for the inner states
cal the update() method repeatedly to get the current reference for your offboard controller
call setReference(), setTrajectoryReference(), ..., on demand to set the references

There is also stuff that the tracker needs from the ControlManager, mainly this (https://github.com/ctu-mrs/mrs_uav_managers/blob/master/include/mrs_uav_managers/common_handlers.h)[https://github.com/ctu-mrs/mrs_uav_managers/blob/master/include/mrs_uav_managers/common_handlers.h) but I would just cut this out being you. So for the beginning, I would make all the function implementations to "be happy" and return true to not cause problems.

Hi @klaxalk, thanks for your prompt reply and sorry for my late reply ;-) .Yes, I am most definitely interested in the MPC tracker. I have my system currently up and running with V-SLAM, CAS and some other stuff all in off-board mode. I can load a set of waypoints and "very very rudimentary" go from one to the next. But as you might imagine this is quite primitive. I need a smoother and reliable controlled approach. Therefor the MPC tracker. Like you wrote this is the workhorse :-)!
Quick questions:
How is the interface with the PX4/ UAV? Set position? Velocity ? acceleration?
The  libMpcTrackerSolver.so is closed source?
Do I need the https://github.com/ctu-mrs/mrs_uav_trajectory_generation in order to run this? Or can I just provide the setpoint with my existing node?
I will be performing the integration/adaptation from your project to our system at the moment. I will keep you posted.
Keep up the good work!

Hi @klaxalk, thanks for your prompt reply and sorry for my late reply ;-) .Yes, I am most definitely interested in the MPC tracker. I have my system currently up and running with V-SLAM, CAS and some other stuff all in off-board mode. I can load a set of waypoints and "very very rudimentary" go from one to the next. But as you might imagine this is quite primitive. I need a smoother and reliable controlled approach. Therefor the MPC tracker. Like you wrote this is the workhorse :-)!
Quick questions:
How is the interface with the PX4/ UAV? Set position? Velocity ? acceleration?
The  libMpcTrackerSolver.so is closed source?
Do I need the https://github.com/ctu-mrs/mrs_uav_trajectory_generation in order to run this? Or can I just provide the setpoint with my existing node?
I will be performing the integration/adaptation from your project to our system at the moment. I will keep you posted.
Keep up the good work!

Hey @dookei. So you could technically use the MPC tracker as you suggest, meaning for supplying a reference to PX4. In that case, the reference should definitely be the desired position, and its derivatives, the more the better (you can get smooth derivatives up to jerk with the tracker). However, I am not sure how this form of supplying reference works with PX4, we have never tried it. Instead, we do our own position+velocity control together with our own attitude control. See our paper for more info. Therefore, we only supply the attitude rate + thrust reference to PX4.
The libMpcTrackerSolver.so as well as the libMpcControllerSolver.so are pre-compiled for two reasons. First, they take approx. 10 minutes to compile and since rarely anything changes in them (they are just solver wrappers), we just have those .sos prepared in advance. Moreover, we are not permitted to share the sources of the solver we use.
You don't need the mrs_uav_trajectory_generation package for single setpoints. The MPC tracker will handle setpoint references just fine (via the setReference() routine). But where the MPC tracker shines is with dynamic trajectories. Those can be however created in many ways, the  mrs_uav_trajectory_generation package is just one of them.
Thanks, let me know how your work goes.

Hey @dookei. So you could technically use the MPC tracker as you suggest, meaning for supplying a reference to PX4. In that case, the reference should definitely be the desired position, and its derivatives, the more the better (you can get smooth derivatives up to jerk with the tracker). However, I am not sure how this form of supplying reference works with PX4, we have never tried it. Instead, we do our own position+velocity control together with our own attitude control. See our paper for more info. Therefore, we only supply the attitude rate + thrust reference to PX4.
The libMpcTrackerSolver.so as well as the libMpcControllerSolver.so are pre-compiled for two reasons. First, they take approx. 10 minutes to compile and since rarely anything changes in them (they are just solver wrappers), we just have those .sos prepared in advance. Moreover, we are not permitted to share the sources of the solver we use.
You don't need the mrs_uav_trajectory_generation package for single setpoints. The MPC tracker will handle setpoint references just fine (via the setReference() routine). But where the MPC tracker shines is with dynamic trajectories. Those can be however created in many ways, the  mrs_uav_trajectory_generation package is just one of them.
Thanks, let me know how your work goes.

Hi @klaxalk , thanks for the previous messages.
Currently I am just going through all the code to understand it and adapt it. I dunno if position or velocity instead of attitude  control is better but to me it sounds more easy to start from. And my goal was to leave the final stabilization and attitude control to the Px4.
Have you ever bench marked the inear mrs-MPC   tracker against others ? Like the one described by ETH Zürich  Linear vs Nonlinear MPC for Trajectory Tracking? According to the conclusions this seems to have a slightly better performance.

Hi @klaxalk , thanks for the previous messages.
Currently I am just going through all the code to understand it and adapt it. I dunno if position or velocity instead of attitude  control is better but to me it sounds more easy to start from. And my goal was to leave the final stabilization and attitude control to the Px4.
Have you ever bench marked the inear mrs-MPC   tracker against others ? Like the one described by ETH Zürich  Linear vs Nonlinear MPC for Trajectory Tracking? According to the conclusions this seems to have a slightly better performance.

Hi @klaxalk, I believe I managed to port successfully the mrs_uav_trackers/ mpc_tracker.cpp with only dependencies being on the  packages mrs_lib and mrs_msg.
Under the initialize() I left the following out. Hope this not needed. Or ?
https://github.com/ctu-mrs/mrs_uav_trackers/blob/ab0dc6698ba5735abbfcc79e2b079525cdc15bd2/src/mpc_tracker/mpc_tracker.cpp#L396
https://github.com/ctu-mrs/mrs_uav_trackers/blob/ab0dc6698ba5735abbfcc79e2b079525cdc15bd2/src/mpc_tracker/mpc_tracker.cpp#L570
It loads the mpc_tracker.yaml parameters, creates the timers etc etc etc . So far so good.
I am following the interface https://github.com/ctu-mrs/mrs_uav_managers/blob/master/include/mrs_uav_managers/tracker.h  like you recommended.
But now I am having some difficulties under the activate (const mrs_msgs::PositionCommand::ConstPtr& last_position_cmd).
Perhaps you could explain me better how is the interface to this mpc_tracker made? What do I need to provide what comes out and in what format? Black-Box style ;-)
I am following the control_manager.cpp in order to try to produce the same results.
My objective is to make this package portable( independent from mrs_uav_controller/manager/ and ) to other projects. So that basically you just copy it and provide the parameters, reference trajectory, inputs, etc and "magically" get the trajectory to track. I know is a little more complex  than that. But that is my  goal at the moment.
Many thanks!

Hi @klaxalk, I believe I managed to port successfully the mrs_uav_trackers/ mpc_tracker.cpp with only dependencies being on the  packages mrs_lib and mrs_msg.
Under the initialize() I left the following out. Hope this not needed. Or ?
https://github.com/ctu-mrs/mrs_uav_trackers/blob/ab0dc6698ba5735abbfcc79e2b079525cdc15bd2/src/mpc_tracker/mpc_tracker.cpp#L396
https://github.com/ctu-mrs/mrs_uav_trackers/blob/ab0dc6698ba5735abbfcc79e2b079525cdc15bd2/src/mpc_tracker/mpc_tracker.cpp#L570
It loads the mpc_tracker.yaml parameters, creates the timers etc etc etc . So far so good.
I am following the interface https://github.com/ctu-mrs/mrs_uav_managers/blob/master/include/mrs_uav_managers/tracker.h  like you recommended.
But now I am having some difficulties under the activate (const mrs_msgs::PositionCommand::ConstPtr& last_position_cmd).
Perhaps you could explain me better how is the interface to this mpc_tracker made? What do I need to provide what comes out and in what format? Black-Box style ;-)
I am following the control_manager.cpp in order to try to produce the same results.
My objective is to make this package portable( independent from mrs_uav_controller/manager/ and ) to other projects. So that basically you just copy it and provide the parameters, reference trajectory, inputs, etc and "magically" get the trajectory to track. I know is a little more complex  than that. But that is my  goal at the moment.
Many thanks!

Hey, great qestions, we will make it work, that should not be a problem. I will get back to you on monday, I am away of pc currently.

Hey, great qestions, we will make it work, that should not be a problem. I will get back to you on monday, I am away of pc currently.

Great many Thanks!

Great many Thanks!

Hey, sorry for the delay. I am not sure if I fully understand your environment and if you fully understand what the MPC tracker does.

Is your package in ROS? If yes, then you don't have to leave out the param_loader. You can, if you want, load the parameters the normal way, i.e. nh_.load_params(...), but I would just copy the param loader's header into your package. The same could be done with the message definition which is baked into the tracker. Those are the PositionCommand, Reference, ReferenceStamped, TrackerTrajectory, etc. You can just copy the message definitions from the mrs_msgs package and build them within your package. However, if you don't use ROS at all, you will need to load the params somehow manually (maybe using some c++ yaml library). Regarding the message objects, you can create custom classes that will contain the same data as the message classes, such that the tracker code does not need to change much.
the activate() method is supposed to be called just before the tracker is meant to be put to work. The argument of the method is the last command produced by a previously active tracker. The command is passed to the next active tracker, so the tracker can set its internal state into the same state as the last tracker left it. This is to ensure that the generated reference will be smooth even when trackers switch. The tracker state is set to the current odometry If the command is unavailable. If you are not going to implement a tracker switching mechanism, just make sure your initial condition (the internal state set in the activate() method is set to whatever the true state of the UAV is.
You write "reference trajectory, inputs, etc and "magically" get the trajectory to track". The tracker will not give you a trajectory to track, not in a complete form. It will, however, generate a reference in real-time for a controller. As time goes this will in fact draw a trajectory that resembles the desired trajectory and is feasible in all states. If you want to generate whole trajectories beforehand (which can be tracker by this tracker), you can use, e.g., the trajectory generator. You could use the MPC tracker to generate trajectories beforehand, but you would need to change the internal loop from the real-time varianto into some "pre-computation" variant that would run without delays (not in timers). You would then record the internal state until it reaches the desired end. But the intended cascade is the following:

Create a desired trajectory (not necessarily feasible), e.g., by this tool
Give the trajectory (one-time event, or repeatedly if it changes in real time) to the MPC Tracker.
The MPC tracker follows the trajectory in real-time in the least-square position error manner while satisfying state constraints. The result is 100 Hz real-time all-state reference for controllers.
The controllers use the reference for feedback and feed forward to move the vehicle.

Hey, sorry for the delay. I am not sure if I fully understand your environment and if you fully understand what the MPC tracker does.

Is your package in ROS? If yes, then you don't have to leave out the param_loader. You can, if you want, load the parameters the normal way, i.e. nh_.load_params(...), but I would just copy the param loader's header into your package. The same could be done with the message definition which is baked into the tracker. Those are the PositionCommand, Reference, ReferenceStamped, TrackerTrajectory, etc. You can just copy the message definitions from the mrs_msgs package and build them within your package. However, if you don't use ROS at all, you will need to load the params somehow manually (maybe using some c++ yaml library). Regarding the message objects, you can create custom classes that will contain the same data as the message classes, such that the tracker code does not need to change much.
the activate() method is supposed to be called just before the tracker is meant to be put to work. The argument of the method is the last command produced by a previously active tracker. The command is passed to the next active tracker, so the tracker can set its internal state into the same state as the last tracker left it. This is to ensure that the generated reference will be smooth even when trackers switch. The tracker state is set to the current odometry If the command is unavailable. If you are not going to implement a tracker switching mechanism, just make sure your initial condition (the internal state set in the activate() method is set to whatever the true state of the UAV is.
You write "reference trajectory, inputs, etc and "magically" get the trajectory to track". The tracker will not give you a trajectory to track, not in a complete form. It will, however, generate a reference in real-time for a controller. As time goes this will in fact draw a trajectory that resembles the desired trajectory and is feasible in all states. If you want to generate whole trajectories beforehand (which can be tracker by this tracker), you can use, e.g., the trajectory generator. You could use the MPC tracker to generate trajectories beforehand, but you would need to change the internal loop from the real-time varianto into some "pre-computation" variant that would run without delays (not in timers). You would then record the internal state until it reaches the desired end. But the intended cascade is the following:

Create a desired trajectory (not necessarily feasible), e.g., by this tool
Give the trajectory (one-time event, or repeatedly if it changes in real time) to the MPC Tracker.
The MPC tracker follows the trajectory in real-time in the least-square position error manner while satisfying state constraints. The result is 100 Hz real-time all-state reference for controllers.
The controllers use the reference for feedback and feed forward to move the vehicle.

Hi Tomas,
many thanks for your detailed reply. Perhaps I will start to explain my case scenario. I started developing a "Framework" a "couple" months ago that aims indoor delivery drones.
The development and simulation environment is done under ROS(noetic) with Gazebo with Visual Studio Code(I like the debugging/customization/json interface on this). The target(UAV, also ROS) is a Nvidia Jetson with a Px4-FC connected over 2 serials(will change to ethernet/CAN later on).
At the moment I have one package(w/GUI) that manages the path(load, add/remove more  waypoints etc) during run time.  My goal now is to integrate the MRS-tracker (the MPC tracker is the best choice here, I assume) that feeds the setpoint dynamically to the Px4 (either position or velocity, I would like to leave the attitude control to the Px4). In between I have another middle layer(packages), that make the Interface with the PX4 convention and the trackers(landing/liftoff, MPC, etc) .  Some checks, mainly safety, are performed while feeding the dynamic-setpoint.

What is  running so far.
I was able to port the mpc_tracker.cpp and modify some parts in order to load the parameters(that are loaded from the control_manager.cpp) I am not sure what is needed at the moment so I just loaded all. From the MPC_tracker package I can run already:

[x] Path_MPC_tracker.initialize(nh, "test_UAV", Path_MPC_tracker.mpc_CommonHandlers );

[x] Path_MPC_tracker.loadConstraints(nh, Path_MPC_tracker.mpc_constraints);

[x] Path_MPC_tracker.setConstraints(mrs_msgs::DynamicsConstraints::ConstPtr(std::make_unique<mrs_msgs::DynamicsConstraints>(Path_MPC_tracker.mpc_constraints)));

[ ] Path_MPC_tracker.activate(last_position_cmd_);

When I call activate()the timers start to run and I get(as expected) and exception at:
https://github.com/ctu-mrs/mrs_lib/blob/9778a1a03fd8ab6a28d76373df228e0a4653032f/src/attitude_converter/attitude_converter.cpp#L459
There still a lot of things that I am missing at the moment, until I get this working.
What I am currently still going through:

[ ] switchOdometrySource()

[ ] setReference()

[ ] setTrajectoryReference()

[ ] startTrajectoryTracking()

[ ] stopTrajectoryTracking()

[ ] resumeTrajectoryTracking()

[ ] enableCallbacks

[x] hover() this will be performed in my other package

[ ] getStatus

[ ] update

Open Questions:
I have a lot of open questions at the moment as you might understand. Some I answer my self (sometimes while writing here) or while going through the code.

Update()

The Odometry-input is feed on the update(const  mrs_msgs::UavState::ConstPtr  &  uav_state) right?  geometry_msgs/Pose ? is enough?
From the return. What could I use? Position? or velocity ? To be honest here I am kinda lost.

For later but nice to have
Do you believe it is possible to add  surrounding collision avoidance (when having a point-cloud, octomap)
I also have a realtime feed from the trajectory from the other UAVs that could be used for UAV collision avoidance. I believe you have already this running right?
Is this the right order to start the MPC Trackers ?

initialize
loadConstraints
setConstraints
setTrajectoryReference
setReference ... not sure here
startTrajectoryTracking
activate

Greetings,
Pedro

Hi Tomas,
many thanks for your detailed reply. Perhaps I will start to explain my case scenario. I started developing a "Framework" a "couple" months ago that aims indoor delivery drones.
The development and simulation environment is done under ROS(noetic) with Gazebo with Visual Studio Code(I like the debugging/customization/json interface on this). The target(UAV, also ROS) is a Nvidia Jetson with a Px4-FC connected over 2 serials(will change to ethernet/CAN later on).
At the moment I have one package(w/GUI) that manages the path(load, add/remove more  waypoints etc) during run time.  My goal now is to integrate the MRS-tracker (the MPC tracker is the best choice here, I assume) that feeds the setpoint dynamically to the Px4 (either position or velocity, I would like to leave the attitude control to the Px4). In between I have another middle layer(packages), that make the Interface with the PX4 convention and the trackers(landing/liftoff, MPC, etc) .  Some checks, mainly safety, are performed while feeding the dynamic-setpoint.

What is  running so far.
I was able to port the mpc_tracker.cpp and modify some parts in order to load the parameters(that are loaded from the control_manager.cpp) I am not sure what is needed at the moment so I just loaded all. From the MPC_tracker package I can run already:

[x] Path_MPC_tracker.initialize(nh, "test_UAV", Path_MPC_tracker.mpc_CommonHandlers );

[x] Path_MPC_tracker.loadConstraints(nh, Path_MPC_tracker.mpc_constraints);

[x] Path_MPC_tracker.setConstraints(mrs_msgs::DynamicsConstraints::ConstPtr(std::make_unique<mrs_msgs::DynamicsConstraints>(Path_MPC_tracker.mpc_constraints)));

[ ] Path_MPC_tracker.activate(last_position_cmd_);

When I call activate()the timers start to run and I get(as expected) and exception at:
https://github.com/ctu-mrs/mrs_lib/blob/9778a1a03fd8ab6a28d76373df228e0a4653032f/src/attitude_converter/attitude_converter.cpp#L459
There still a lot of things that I am missing at the moment, until I get this working.
What I am currently still going through:

[ ] switchOdometrySource()

[ ] setReference()

[ ] setTrajectoryReference()

[ ] startTrajectoryTracking()

[ ] stopTrajectoryTracking()

[ ] resumeTrajectoryTracking()

[ ] enableCallbacks

[x] hover() this will be performed in my other package

[ ] getStatus

[ ] update

Open Questions:
I have a lot of open questions at the moment as you might understand. Some I answer my self (sometimes while writing here) or while going through the code.

Update()

The Odometry-input is feed on the update(const  mrs_msgs::UavState::ConstPtr  &  uav_state) right?  geometry_msgs/Pose ? is enough?
From the return. What could I use? Position? or velocity ? To be honest here I am kinda lost.

For later but nice to have
Do you believe it is possible to add  surrounding collision avoidance (when having a point-cloud, octomap)
I also have a realtime feed from the trajectory from the other UAVs that could be used for UAV collision avoidance. I believe you have already this running right?
Is this the right order to start the MPC Trackers ?

initialize
loadConstraints
setConstraints
setTrajectoryReference
setReference ... not sure here
startTrajectoryTracking
activate

Greetings,
Pedro

Hey, sorry for the delayed answer. I see you have been updating your reply, which is good. Regarding the open question:

The input to the update() method is the UavState with all available information on the current state of the UAV, inc. speed, acceleration, etc. The update() method just saves the information and potentially uses it to set up initial conditions. You can substitute it with just the Pose if you wish.
The return value of the update() is the most important thing about a tracker. It contains the desired position, acceleration, velocity, snap, heading, heading, rate, etc.  This reference is given to feedback controllers (e.g., the SE(3) geometric feedback). Some of it (acceleration, jerk) is used to calculate feed-forward control actions, which is a very important aspect of controlling a UAV. However, your feedback controller might not utilize all of the states in the reference. That is up to you. The MPC tracker makes sure all the states in the reference follow the model and are within the dynamics constraints.

The order of the routines should be the following:

initialize()
setConstraints() (however, you can just set the right constraints in the trackers yaml file, this setConstraints() routine is here for updating the constraints dynamically during the flight which you might not need)
activate()
!! now the tracker is active and producing a reference, so the update() is called repeatedly and its return value is supposed to be used !!.. no you can give the tracker commands, such as setReference() (rough goto coordinates), setTrajectoryReference() (sets time-parametrized trajectory), hover() (smoothly stops current motion)
deactivate() before you switch to another tracker

Adding a collision avoidance is outside of the scope of this tracker. This tracker just produces a feasible reference at a high rate for controllers with limited (and potentially infeasible) reference trajectories from a user. If you want to avoid obstacles,  design your desired trajectory (the input to the tracker) accordingly. The MPC Tracker will make sure the UAV's controllers are getting a feasible reference to follow your trajectory.
The mutual collision avoidance between the UAV's can be realized by the tracker, as described in the publication. It is meant for outside where the altitude flight level is not limited (the UAV's avoid by climbing higher). The tracker already subscribes to topics of other UAVs containing the future prediction of the UAV motion. I admit the code for the avoidance is far from nice and far from elegant, but it works. The trajectories are supposed to be transmitted in GPS Latitude+Longitude coordinates to avoid any confusion regarding coordinate frames (each UAV can potentially fly using a different localization system and having a different origin).

Hi Tomáš,
many thanks for you reply. I managed yesteday to make it work on my setup!
There are a few things that I still need to change to fit my needs. At the moment I just provided a few waypoints to check the predicted trajectory and visualize it under Rviz. Looks exactly like what I need.
I didnt test yet with dynamic odometry input. But I assume it should work without much hassle.
I woul like to thank you once again for your detailed replies. They helped me tremendously to understand how it works and where to look for.
Many thanks! and keep up the good work!


openlayers support for map features

Coverage increased (+0.08%) to 83.35% when pulling 1d9c8dc08ff713a8fea061934a9e3fee9913bad6 on itowtips:map-features into e089b778091fee037ca0e5cfcea7d28eda1364c6 on shirasagi:master.

Coverage increased (+0.07%) to 83.339% when pulling fb2a75d189a5fd60bf7c1bd0862e24ebef669730 on itowtips:map-features into e089b778091fee037ca0e5cfcea7d28eda1364c6 on shirasagi:master.


Pin protobuf in tests below 3.18.0.

The 3.18.0 release brought a new py2.py3 wheel that has Python 3 syntax
code in it; so avoid this release in tests.
See: https://github.com/protocolbuffers/protobuf/issues/8984

Errors look like:
...
E         File "/home/jsirois/.pex/installed_wheels/bf8142e23318f6e4cb64d1a90579762ac79a7532/protobuf-3.18.0-py2.py3-none-any.whl/google/protobuf/descriptor.py", line 113
E           class DescriptorBase(metaclass=DescriptorMetaclass):
E                                         ^
E       SyntaxError: invalid syntax
...


Stick at yolox.core.trainer:152 - init prefetcher

When I run the algorithm, if often sticks at this point
2021-08-03 07:55:34 | INFO     | yolox.core.trainer:152 - init prefetcher, this might take one minute or less...
And I debug this approach, find the program stopped at random picture. I have 2000 pics for train, It may stick at 1720/2000 or 1080/2000, and never go forward even waiting for several hours.
I have tried to change the data_num_workers to 0/4/16, but it didn't work

I also used the latest version of code

You can change this line to:
self.prefetcher = iter(self.train_loader)

And don't forget to replace this line with:
inps, targets, _, _ = self.prefetcher.next()

Thank you, but It still don't work.

Sometimes, the program can run normally in the same configuration.

I guess you may have limited RAM or GPU mem for meeting this issue. Reducing the batchsize may be helpfule

I guess you may have limited RAM or GPU mem for meeting this issue. Reducing the batchsize may be helpfule

I have 500 GB RAM( 60 GB used), and  4x spare 2080TI in my server. It can train with batchsize 16(sometimes it can work, and I have trained for 10+ epochs ).
I tried batchsize 4/8, and still had problems!

If you have time, you can debug in my computer by remote connection.

This may have related to the nums of GPU I used.
When I use 4x GPUs, it sticks.
When I switch to 2x GPUs, it work well??

It might be caused by less resources, you could modify data_num_worker in Exp, 2x GPU only start 2 subprocess  to train and 4x GPU requires double resources.
BTW, less num_workers might cause more data_time.

It might be caused by less resources, you could modify data_num_worker in Exp, 2x GPU only start 2 subprocess to train and 4x GPU requires double resources.
BTW, less num_workers might cause more data_time.

When I used 4x GPU(CUDA_VISIBLE_DEVICES=0,2,4,6), I tried different nums of  data_num_worker, and It always sticked.
But I used 5x GPU(CUDA_VISIBLE_DEVICES=0,2,3,4,6), and it works at any num of data_num_worker.

I think this problem may be related to this, one of the process was defunct!

I met the same problem when i tried to set CUDA_VISIBLE_DEVICES to 1,2,3, it cannot work, while it worked when set to 0,1,2;
and the run command is :
nohup python tools/train.py -expn yolox_rddc -f exps/example/yolox_voc/yolox_rddc.py -d 3 -b 4 --fp16 -o -c models/yolox_x.pth>nohup.out&


Flumine seems stuck in orderstream handle_output

It seems like Flumine does not return currently active market.
Little debugging from my side suggests the issue comes from orderstream.py where the handle output does not really handle live events as it should.
Likely I am missing something here but cant get around the issue.
Any idea of what is happening?

Have any more information / code related to this problem? Not sure I understand.

Delayed key issue / oos.


General: Search exercises of a course

Checklist
General

[ ] I tested all changes and their related features with all corresponding user types on a test server.
[x] Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
[x] I chose a title conforming to the naming conventions for pull requests.

Server

[x] I followed the coding and design guidelines.
[x] I added multiple integration tests (Spring) related to the features (with a high test coverage).
[x] I added @PreAuthorize and checked the course groups for all new REST Calls (security).
[x] I implemented the changes with a good performance and prevented too many database calls.
[x] I documented the Java code using JavaDoc style.

Client

[x] I followed the coding and design guidelines and ensured that the layout is responsive.
[x] Following the theming guidelines, I specified colors only in the theming variable files and checked that the changes look consistent in both the light and the dark theme.
[x] I added multiple integration tests (Jest) related to the features (with a high test coverage), while following the test guidelines.
[x] I documented the TypeScript code using JSDoc style.
[ ] I added multiple screenshots/screencasts of my UI changes.
[x] I translated all newly inserted strings into English and German.

Motivation and Context

#5573
Description

Steps for Testing

Prerequisites:

1 Instructor
2 Students
1 Programming Exercise with Complaints enabled

Log in to Artemis
Navigate to Course Administration
...

Review Progress

Code Review

[ ] Review 1
[ ] Review 2

Manual Tests

[ ] Test 1
[ ] Test 2

Test Coverage

Class/File
Branch
Line

Screenshots

Please add a screenshot / screencast into the PR description so I can provide feedback about the usability

Good job but left some change requests:
 The course information panel is affected by this change.
I am unsure if we should do this server side. Currently we get the list of exercises from the for-dashboard call, and cache this information nicely. So we always have the list of all exercises already loaded in the client. Why not do simple client side filtering? Any opinions here

Hi @stefanwaldhauser , I changed the search to client side since I couldn't find any benefit of server side searching for this case.

I agree with @stefanwaldhauser, filtering the exercises based on the search term (when we have them already loaded) should be done client side.

Yes, I changed the searching to client side.

The search button worked great but you need to click on the button to search. Clicking enter doesn't work.

Yes, I added the trigger when enter key is pressed. It should work now.

Tested on TS1, everything worked as expected. However, it would be great to also trigger the search functionality by pressing the enter key.

Thanks for the suggestion! I added the trigger when enter key is pressed.

Codecov Report
Base: 79.77% // Head: 75.41% // Decreases project coverage by -4.35% :warning:

Coverage data is based on head (e379c88) compared to base (5841a1e).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #5717      +/-   ##
=============================================
- Coverage      79.77%   75.41%   -4.36%
=============================================
  Files           2035     1073     -962
  Lines          81411    42619   -38792
  Branches       12277     8071    -4206
=============================================
- Hits           64944    32143   -32801
+ Misses          9149     5459    -3690
+ Partials        7318     5017    -2301

Flag
Coverage Δ

client
75.41% <100.00%> (+<0.01%)
:arrow_up:

server
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...iew/course-exercises/course-exercises.component.ts
85.79% <100.00%> (-0.01%)
:arrow_down:

...um/in/www1/artemis/service/TutorEffortService.java

...1/artemis/domain/enumeration/NotificationType.java

.../in/www1/artemis/service/BuildLogEntryService.java

...mis/domain/enumeration/ParticipationLifecycle.java

...in/www1/artemis/domain/AbstractAuditingEntity.java

...mis/service/programming/TemplateUpgradePolicy.java

.../www1/artemis/service/CourseExamExportService.java

...emis/repository/hestia/ExerciseHintRepository.java

... and 954 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Modal: Content is covered by background

I gues the class modal-content was not set which gives the error

View the docs.
The problem only occurs in the context of the Bulma theme.

Also the close icon has a wrong position while the modal is opening:


No templates matched the input template name: webApp.

Problem encountered on https://dotnet.microsoft.com/learn/aspnet/hello-world-tutorial/create
Operating System: windows
I ran following command
"dotnet new webApp -o CoreApiDockerDemo1 --no-https"
and find this error message
"No templates matched the input template name: webApp."

Could you run dotnet --info paste the output here so we can see what you have installed?

Closing due to issue going stale. Please re-open if you're still having troubles.


The Relationship Between Canonical and Signature in BCS

I am really confused about Why must the serialized object for signing be canonical.
The process of signing involves the sender's object being serialized into a byte array, which is then signed. The data transmitted is just byte data, and when the receiver verifies the signature, they simply retrieve the same byte data and perform signature verification. It seems like there is no connection to canonical at all during this process.
So, what is the actual impact of canonical on signature verification ?
I look forward to your response. Thank you!

My question is: I’m using proto buffer, a non-canonical serialization format, and it still works as expected. When I sign the data, I’m signing the hash of the serialized byte array. On the receiving side, the same exact byte array is transmitted and received. The recipient hashes the identical byte array and verifies the signature.
It seems to me that there’s no strict need for canonical serialization here, because the signature verification operates directly on the same byte array transmitted over the network, not on an object that is first deserialized and then re-serialized before verification.
This has left me quite confused.  Thank you!


[AIRFLOW-1661] modify taskinstance list link, sort taskinstance  by "Start Date" descending

Dear Airflow maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA

[ ] My PR addresses the following Airflow JIRA issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"

https://issues.apache.org/jira/browse/AIRFLOW-1661

Description

[ ] Here are some details about my PR, including screenshots of any UI changes:

modify taskinstance list link, sort taskinstance  by "Start Date" descending
Tests

[ ] My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

[ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Codecov Report

Merging #2647 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2647   +/-   ##
=======================================
  Coverage   71.75%   71.75%
=======================================
  Files         152      152
  Lines       11749    11749
=======================================
  Hits         8431     8431
  Misses       3318     3318

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1b2c0f...d68bff5. Read the comment docs.

This could potentially be pretty slow since the ordering is happening on an unindexed column, even though this will only be for TIs within a DAG, some DAGs could have lots of TIs on different states.


build transforms==0.2.3.dev0 release with toolkit==0.2.2

Why are these changes needed?
Adjust versions to build and deploy build transforms==0.2.3.dev0 with dependency on toolkit==0.2.2
Related issue number (if any).

@cmadam When you get a chance, please review and approve so I can build and publish the transforms 0.2.3.dev0 to pypi. You will need this to use on the inner. Thanks


Invalid SPIRV with debug information in a release build

Try running the minimaltestcase with set CARGO_PROFILE_RELEASE_DEBUG=true (I only tried the wgpu runner).
The test case is written in https://github.com/EmbarkStudios/rust-gpu/blob/minimaltestcase/examples/shaders/sky-shader/src/lib.rs (The vertex shader)
It segfaults on windows.
Making it even more interesting:
Removing this comment block fixes it https://github.com/EmbarkStudios/rust-gpu/blob/minimaltestcase/examples/shaders/sky-shader/src/lib.rs#L183

Hum. I just tried to port this to "modern" rust-gpu, and didn't get a segfault. I did, though, get quite a few validation issues (as expected, I think?):
[2021-12-08T11:37:02Z ERROR wgpu_hal::vulkan::instance] VALIDATION [UNASSIGNED-CoreValidation-Shader-InputNotProduced (0x23e43bb7)]
    	Validation Error: [ UNASSIGNED-CoreValidation-Shader-InputNotProduced ] Object 0: handle = 0xead9370000000008, type = VK_OBJECT_TYPE_SHADER_MODULE; | MessageID = 0x23e43bb7 | Vertex shader consumes input at location 0 but not provided
[2021-12-08T11:37:02Z ERROR wgpu_hal::vulkan::instance] 	objects: (type: SHADER_MODULE, hndl: 0xead9370000000008, name: ?)
[2021-12-08T11:37:02Z ERROR wgpu_hal::vulkan::instance] VALIDATION [UNASSIGNED-CoreValidation-Shader-InputNotProduced (0x23e43bb7)]
    	Validation Error: [ UNASSIGNED-CoreValidation-Shader-InputNotProduced ] Object 0: handle = 0xead9370000000008, type = VK_OBJECT_TYPE_SHADER_MODULE; | MessageID = 0x23e43bb7 | Vertex shader consumes input at location 1 but not provided
[2021-12-08T11:37:02Z ERROR wgpu_hal::vulkan::instance] 	objects: (type: SHADER_MODULE, hndl: 0xead9370000000008, name: ?)
[2021-12-08T11:37:02Z ERROR wgpu_hal::vulkan::instance] VALIDATION [UNASSIGNED-CoreValidation-Shader-InputNotProduced (0x23e43bb7)]
    	Validation Error: [ UNASSIGNED-CoreValidation-Shader-InputNotProduced ] Object 0: handle = 0xead9370000000008, type = VK_OBJECT_TYPE_SHADER_MODULE; | MessageID = 0x23e43bb7 | Vertex shader consumes input at location 2 but not provided
[2021-12-08T11:37:02Z ERROR wgpu_hal::vulkan::instance] 	objects: (type: SHADER_MODULE, hndl: 0xead9370000000008, name: ?)
[2021-12-08T11:37:02Z ERROR wgpu_hal::vulkan::instance] VALIDATION [UNASSIGNED-CoreValidation-Shader-InputNotProduced (0x23e43bb7)]
    	Validation Error: [ UNASSIGNED-CoreValidation-Shader-InputNotProduced ] Object 0: handle = 0xead9370000000008, type = VK_OBJECT_TYPE_SHADER_MODULE; | MessageID = 0x23e43bb7 | Vertex shader consumes input at location 3 but not provided
[2021-12-08T11:37:02Z ERROR wgpu_hal::vulkan::instance] 	objects: (type: SHADER_MODULE, hndl: 0xead9370000000008, name: ?)

Closing this for now, if you can get it to repro again, feel free to reopen.


Change back to POST after Bitfinex workaround

In PR #51 we needed to modify the curl options when looking at the Bitfinex books. However we need to change the settings back after this has been completed.

Hi @sdrelton, just a question: did you get any error without the change back to POST? Thanks

Hey @butor , yes I did end up getting an error later on in Kraken which was fixed when moving back to POST.

Updated to make less calls to the Kraken API too.


Default input text theme fails a11y scanner checks

b/157870633
It seems like for label text we are using grey[600] which fails the minimum contrast test with the white background. It seems that it needs to be at least grey[700]. I could not find Material specification for this.
Setting as a critical issue as there's no workaround for this. InputDecoration does indeed has labelStyle property such as labelStyle: Theme.of(context).textTheme.bodyText1.copyWith(color: Colors.grey[700]), .
However, this style will override on every state(unfocused, focused, and error). This means we require a logic to get the state of the TextField. This comes to our second problem. TextField doesn't have a straightforward way to get its own state. This has been a long going discussion here https://github.com/flutter/flutter/issues/48876

Setting as a critical issue as there's no workaround for this.

Should this issue have a priority?

Hi @mehmetf, If we provide the API to set the text color based on different state, will that resolve this issue?

We should just fix the default.

We currently uses the hint color const Color(0x8A000000) for the labelText.
Is there a spec on which text color to use?

If "just fixing the default" is enough, we should just do that. I'm sure that @willlarche et al. can help with getting the correct default color.
The issue's description implies the need for specifying different labelStyle colors, depending on the text field's state.

Setting as a critical issue as there's no workaround for this. InputDecoration does indeed has labelStyle property such as labelStyle: Theme.of(context).textTheme.bodyText1.copyWith(color: Colors.grey[700]), .
However, this style will override on every state(unfocused, focused, and error). This means we require a logic to get the state of the TextField. This comes to our second problem. TextField doesn't have a straightforward way to get its own state. This has been a long going discussion here #48876

That said, the issue being referred to  (#48876), is about input validation, which need not be roped into this one.
@mehmetf - what's needed to close this issue? I assume that tweaking the floating label's color would be enough?

I assume that tweaking the floating label's color would be enough?

Yes. Fixing the default will fix this problem.

@johnsonmh Can you assist?

A temporary workaround can be overriding the hintcolor for the TextField
import 'package:flutter/material.dart';

void main() => runApp(new MyApp());

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return  MaterialApp(home: new MyHomePage());
  }
}

class MyHomePage extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    ThemeData data = Theme.of(context).copyWith(hintColor: Colors.green);
    return new Scaffold(
      appBar: AppBar(title: Text('scaffold')),
      body: Column(
        children: [
          // a simple baseline for comparison. scales OK + wraps OK
          Theme(
            data: data,
            child: TextField(
              decoration: InputDecoration(labelText: 'label text'),
            ),
          )
        ],
      ),
    );
  }
}

Talked with @willlarche and @johnsonmh offline. We would like to update the hintcolor to be 60% black(#99000000) in light mode and 60% of white(#99FFFFFF) in dark mode

After a little bit more investigation, it turns out it may because of the textfield border that failed the accessibility test

Our default color for border is themeData.colorScheme.onSurface.withOpacity(0.38).  We do have the ability to override the color
TextField(decoration: InputDecoration(labelText: 'test', enabledBorder: UnderlineInputBorder(borderSide: BorderSide(width: 1, color: Colors.black))),)

and i believe that should solve the customers use case. @HansMuller do you think we should fix the default color for the border in this case?

I would prefer to do these minor fixes if possible since they can make a
slight impact in a11y support.
On Wed, Jun 24, 2020 at 5:24 PM chunhtai<EMAIL_ADDRESS>wrote:

After a little bit more investigation, it turns out it may because of the
textfield border that failed the accessibility test
[image: Screen Shot 2020-06-24 at 2 20 20 PM]
https://user-images.githubusercontent.com/47866232/85629025-f7766c80-b625-11ea-95b5-c71e19415135.png
Our default color for border is
themeData.colorScheme.onSurface.withOpacity(0.38). We do have the ability
to override the color
TextField(decoration: InputDecoration(labelText: 'test', enabledBorder: UnderlineInputBorder(borderSide: BorderSide(width: 1, color: Colors.black))),)
and i believe that should solve the customers use case. @HansMuller
https://github.com/HansMuller do you think we should fix the default
color for the border in this case?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/flutter/flutter/issues/58941#issuecomment-649079859,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJWNZKSBTTMSFG3FOWCST3RYJVHLANCNFSM4NXYBGFQ
.

Current status: Waiting for the customer to confirm the textfield border is actually the problem in their test.

Closed as there will be no action item for flutter team, the issue is is on the accessibility scanning tool. internal tracking bug
b/79165151


Move source styles

Just wondering what you all think about moving the source styles from /public to somewhere like /assets/styles?
This would ensure that source styles aren't publicly accessible. I'm happy to submit a PR for this if the change is acceptable.

I think it's fine the way it is. It won't do any harm if someone stumbles upon Sass files by going to http://yoursite.com/css/main.scss, assuming one knows that is the actual directory structure on a server.
It would make more sense to have assets folder if there was a gulp or webpack compiling, minifying, optimizing both CSS and JS files, and then copying them to public folder.
I am also trying to avoid adding more top-level directories to the project. Not to bash on other's work, but this is what happens when you add, add, and keeping adding more stuff until it becomes hard to understand what is what anymore: https://github.com/meanjs/mean.


Edit Service dialog doesn't show existing links

I've created a service (app) in a stack with links to another service (db) in the same stack. When I use the Edit link from the dropdown for the "app" service, the Service Links section in the dialog is empty and it says "This service has no service links". However, if I view the docker-compose config for the stack, the "app" service has a link defined to the "db" service as expected.

Duplicate of https://github.com/rancher/rancher/issues/1294

@gordontyler Do you have multiple environments?

Yes, but these are all in the same environment.

Reconciling issues. This is definitely a duplicate of https://github.com/rancher/rancher/issues/1389


Feat: Anvil Drag Preview

Description
Adding Drag preview

Creating a portal and using widget cards to depict a widget.
Add Widget count when multiple widgets are being dragged.

Fixes #32141
or
Fixes Issue URL

[!WARNING]
If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation
/ok-to-test tags=""
:mag: Cypress test results

[!CAUTION]
If you modify the content in this section, you are likely to disrupt the CI result for your PR.

Communication
Should the DevRel and Marketing teams inform users about this change?

[ ] Yes
[ ] No

/build-deploy-preview skip-tests=true


Intellisense on EventSubscriber Procedure

Intellisense on EventSubscriber Procedure
For Example:
  [EventSubscriber(ObjectType::Table, database::"Sales Line", 'OnAfterAssignItemValues', '', true, true)]
New procedure: local procedure OnAfterAssignItemValues( STRG+SPACE now you get here first all the snippets from the crs.al-language extension... and in the end... SalesLine and Item...
The crs-snippets should not open here.

You are very right...
I noticed this as well - but no idea on how to fix this.  I have been trying to go through the package.json of the al-extension, but nothing helpful found ...
Do you happen to have an idea?

Unfortunately, I don't have a solution here either. The question is how the AL Extension from Microsoft implemented their own snippets? The problem also affects other AL extensions :-) but that makes the list even longer until you finally get to the "right" parameters.

small tip, just press arrow up ;-)
In a way, they have just some snippets like I have, but they are able to avoid showing them on some places..  so i guess I'll need to figure out how they do that :-/

small workaround... simply enter a point, then the snippets are not listed and only the correct parameters are displayed.

Thanks :-).
I will still search for a way to see how I can avoid showing the snippets on the places we don't want. If Microsoft isn't showing them, we should be able to hide them as well..


Can't add my music, link is unclickable

OS: Windows 10
GPMDP Version: 4.6.1
Issue Descriptions: Trying to click 'Add your music' results in nothing. Mousing over it doesn't have the normal cursor that shows up for links, instead it's the one for selecting text, though the link for the GPM trial also has that cursor and is clickable.
Steps to Reproduce: Start GPMDP > click music library in the sidebar > click 'Add your music'

For what its worth this link is meant to be hidden, and for some reason it recently became visible. The proper fix is to hide this again, as the "add your music" function only works with the desktop software or chrome extension.


Update 3d correlation function to allow for specification of Pk

Right now, 3d Pk appears to only allow the standard nonlinear Pk. We want to allow for any Pk to be passed. Copying a summary from @sukhdeep1989

I just looked into ccl_correlation.c . The projected correlation functions take power spectra as input but the 3d_correlation does not. Within the function, it should be an easy change to move the power spectrum to the arguments. Will require some care for upstream functions that might be calling it. I also noticed that the projected correlation function assume angular coordinates. I think we can easily generalize it to use physical coordinates as well. Shouldn’t require much change in the code and could be as  simple as passing it  k, pk and rp, and then checking the output.

@jablazek I just started a branch, correlation_issue743, for this issue. To begin with, I modified the ccl_correlation_3d function. I couldn't quickly figure out how to compile the current CCL version. Can you please check it or point me to the instructions. If changes to ccl_correlation_3d is acceptable, then we can modify the subsequent functions as well.
For the projected correlation function, I noticed that ccl_tracer_corr_fftlog function is hard coded to assume angular (ell) space. I think we can add a new flag to the function call, e.g. int ell_k_space, and then select k or ell spline inputs based on that. As to how this can be exposed to user, we can either add the same flag to ccl_correlation function or we can create two copies of this function, ccl_correlation2D_angular and ccl_correlation2D_physical. I think we should also add 2D to the function name. I prefer the latter (creating 2 functions). In ccl_correlation2D_physical, we can also add the method to account for RSD effects (eq. 15-18 in https://arxiv.org/pdf/2001.07700.pdf ).

linking to #815 and #219

Was speaking with @sukhdeep1989 earlier today about these related issues. It appears that there are two routes in CCL to calculate the correlation function.

the standard ccl.correlation which takes C_ell as input rather than Pk and so is currently only able to do angular correlation functions. However, it can handle general correlations using the general Pk functionality.
the 3d correlation function, which is hard-coded to use the CAMB nonlinear Pk (I believe). We will need to re-write this to be exposed to the general Pk.

We also want w_p(r_p) functionality, which can be done easily from (2), if the call to FFTLog can use different bessel functions.

We already do this!


[Feature] HTTPS and CA Certificates

Old behavior
Cannot have authentication without HTTPS.
New behavior

[x] Installed user CA cerificates into the production Docker image
[x] Generated CA certificates for development
[x] Added HTTPS to Go server
[x] Change port number from 8080 to 8443
[ ] Upgrade HTTP to HTTPS

Additional info (related issues, images, etc.)
Closes #62

Might need to do
RUN apk --no-cache add ca-certificates && update-ca-certificates

https://gist.github.com/knibals/5280f245f1f7c7017d457c5544635b3d


Router should pass its own props to Route's on subsequent renders

I have the following scenario:

I have a Router with its routes inside a presentational component, which I want to be totally unaware of state.
In a few routes of this router, I need to receive new redux state from my container.
The container re-renders the Router with my new state as props.
But since Router is not a React Component, it does not re-render the routes and does not pass the new props to the component.

Here is a Gist with a simple example (in the example I try passing props both to Router and Route): https://gist.github.com/danielweinmann/09a2c980fe2fa405eb39
What I suggest is the following:

Add a passProps prop to Router
Change the following block on ExRouter to pass these props manually to the route: https://github.com/aksonov/react-native-router-flux/blob/master/ExRouter.js#L293

I'm gonna send a PR with this soon, probably tonight, but wanted to document the issue first ;)

Actually, I've now noticed that Router already passes its own props to Route on the first render. I think I wont create passProps prop and just use the router's prop.
What do you think, @aksonov?

@aksonov, I don't think you understand the problem I fixed. I am actually astonished that nobody else has run into it! I'm thinking everybody is implementing the default Router-as-first-component-in-the-render-stack approach.
This change broke it: https://github.com/aksonov/react-native-router-flux/commit/2724b8163a1798775046926c70ade4e4fcfe8066#diff-07ab94a626d050c4a73fb7272713b477R294
The problem was that the original Route component had static props that didn't change on subsequent renders.
I know it's ugly, and I know it would be better to use react's component lifecycle. But it just didn't work. I'm thinking the problem is on the way we "store" the routes on a non-react class and then try to pass them around. I think we'll have to made an architectural change to make it more elegant.

I have a redux provider wrapping the router, and it's not passing the store props down to the route with the 3.2.7 react-native-router-flux version.

@shakdoesgithub unfortunately I had to focus on launching my project (which will happen later this month), so I couldn't keep up with the changes here.
I'm using a fork right now, with 1 commit that I didn't try to merge with @aksonov's version. Here is my version: https://github.com/danielweinmann/react-native-router-flux/tree/d88aa3b84ee908aca3aa3a5ef6edad4180ee820b
I don't recommend using my fork, though. @aksonov is probably better, mine is 2 months old, but maybe you can take a look at my commits and see if you can create a PR here for fixing this issue if it is still present.

@danielweinmann I got it to work by using the latest version and using the compiled version of your scenes.
const scenes = Actions.create(
  <Scene key="root">
    <Scene key="login" {...this.props} component={Login} title="Login" />
  </Scene>
);

class RouterContainer extends Component {
  render() {
    console.log('RouterContainer render', this.props)
    return(
      <Router {...this.props} scenes={scenes}>
      </Router>
    )
  }
}

class ConnectedRouter extends Component {
  render() {
    return (
      <RouterContainer {...this.props} />
    )
  }
}

ConnectedRouter = connect(state => ({
  todo: state,
}))(ConnectedRouter)


@loadable/webpack-plugin hangs in production mode

🐛 Bug Report
Hi,
I'm trying to use loadable with setup similar to razzle one (two webpacks running, client and server), it looks promising, but have an issue with running it in production mode (it hangs the webpack build).
I've just cloned the repo and it seems that razzle example perfectly reproduces it.
To Reproduce
In examples/razzle run yarn build command.
Expected behavior
Should finish the build successfully.
I did some digging, and it happens only when adding filename option in plugin  that is set to absolute path (https://github.com/smooth-code/loadable-components/blob/master/examples/razzle/razzle.config.js#L11) . If no filename is set then it doesn't hang (but still fails as server side code does not find the file).
I'm not really faimilar with webpack plugins, but if I remove code that adds the file to the compiler assets it seems to be fixing the issue (removed https://github.com/smooth-code/loadable-components/blob/master/packages/webpack-plugin/src/index.js#L25) . I know it may not be the best option.
What would love to have is that LoadablePlugin would work in production mode given (writeToDisk and filename path options - path that is resolved).
Love the lib so far btw - especially preload/prefetch feature!.
Thanks!

Hello @tadeuszwojcik, I am sorry I don't have the time to dive in right now. I added "Help Wanted" flag, so if someone could help it would be nice!

@neoziro thanks for quick reply, fully understand.
I think current webpack plugin logic is a little bit  incorrect (introduced when adding writeToDisk ), as it doesn't seem that one can add assets to  compiler.assets as absolute path key (https://github.com/smooth-code/loadable-components/blob/master/packages/webpack-plugin/src/index.js#L25).
Filename should allow specifying only filename not full path, and there should be additional option (path? ) that would allow specifying where file should be saved (when writeToDisk is set). Would that make sense? If so I'll try to implement it when find some time, shouldn't be that hard. Thanks!

@tadeuszwojcik yes you are right, the logic is a bit incorrect. I think we should not accept an absolute path. Webpack has an output path and we should respect it. So I think the best thing would be to warn if an absolute path is used and to remove that logic (https://github.com/smooth-code/loadable-components/blob/master/packages/webpack-plugin/src/index.js#L64).
What do you think?

@neoziro  I gave it a shot at with https://github.com/smooth-code/loadable-components/pull/187 that solves all my issues currently .

I believe absolute path is actually required here. At least once I wrote this it was needed for webpack dev server to actually output file.

🐛 Bug Report
Hi,
I'm trying to use loadable with setup similar to razzle one (two webpacks running, client and server), it looks promising, but have an issue with running it in production mode (it hangs the webpack build).
I've just cloned the repo and it seems that razzle example perfectly reproduces it.
To Reproduce
In examples/razzle run yarn build command.
Expected behavior
Should finish the build successfully.
I did some digging, and it happens only when adding filename option in plugin that is set to absolute path (https://github.com/smooth-code/loadable-components/blob/master/examples/razzle/razzle.config.js#L11) . If no filename is set then it doesn't hang (but still fails as server side code does not find the file).
I'm not really faimilar with webpack plugins, but if I remove code that adds the file to the compiler assets it seems to be fixing the issue (removed https://github.com/smooth-code/loadable-components/blob/master/packages/webpack-plugin/src/index.js#L25) . I know it may not be the best option.
What would love to have is that LoadablePlugin would work in production mode given (writeToDisk and filename path options - path that is resolved).
Love the lib so far btw - especially preload/prefetch feature!.
Thanks!

Thanks to help me to find the root cause of this hanging issue. :-)
Using relative path solved my issue.
I replaced filename: path.join(__dirname, "build/react-loadable.json") to filename: "../react-loadable.json"


use all files in GIT repo for finding compute resources

Currently only the firs *.tf file is used to calculate the compute resources. This must be changed. The repo can have any number of files and we must extract the information for all terraform files.
https://github.com/swaroopar/osc/blob/f482bef4433ac5286a9fe954f9bc2ae1f766a77f/modules/servicetemplate/src/main/java/org/eclipse/xpanse/modules/servicetemplate/utils/ServiceConfigurationParameterValidator.java#L88

let me do it


[TVMC][UMA] Support using UMA with TVMC

This change introduces:

A TVMExtension interface to extend TVMC with custom code. Currently its only use is to add UMABackends.
A command line option --experimental-tvm-extension <dir> to point to extension modules.
An envvar $TVM_EXTENSION_DIR for the same purpose.

See discussion thread: https://discuss.tvm.apache.org/t/tvmc-uma-integration/14309
@Mousius @cgerum @MichaelJKlaiber @PhilippvK

@tvm-bot rerun

Sorry for the late update.
The outstanding test failure is likely because of the outstanding issue that the sys.path is modified in order to support all module loading. This probably inteferres with running the tests in parallel.
https://github.com/tum-ei-eda/tvm/blob/c1c2d3ca2db1c56d3cc8d695530ab7aa8b90ea00/python/tvm/driver/tvmc/extensions.py#L24-L34
I'm not sure how to resolve this as I did not find another method to achieve the same kind of module loading. Do we need to compromise here and settle for a simple module load? I unresolved the relevant discussion with @lhutton1.
@cgerum @PhilippvK


Add Haskell Platform to Windows page

Need to be there as MinGHC doesn't seem to come in both 32 and 64-bit flavors.

Merged. Related: #55


[Enhancement]: Move cliffy-provider-gh-releases to jsr.io

Version
cndi v2.5.0
kubeseal v0.26.0
terraform v1.5.5
Please provide a summary of the enhancement you are proposing:
We've built an Cliffy upgrade Provider and Command, and we would like to publish this on jsr.io but we depend on cliffy making the migration first.
https://github.com/c4spar/deno-cliffy/pull/679
Please provide the motivation or use case for this enhancement:
If we can isolate the Upgrade Provider it can live on it's own, be leveraged by others, and I believe the health of the module would improve.
Even better if we can move it upstream to the cliffy repo itself!
How can we best workaround this issue so far?
we've moved the entire upgrade module into the CNDI repo
How would you approach solving this problem within CNDI?
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

#815


Update dockerfile to use base image from mcr

CLosing this PR due to last inactive state being long ago and the image was moved to mariner's distroless in the last PR. Thank you.