item variable's conditionals crash the game

when trying to use any of the item variables as a conditional, the game crashes

i have the same issue, cant use item::max_dur as a condition

Can both of you provide logs?

https://paste.ee/p/ICzdb
here is log, i made a new instance, put mod menu, custom hud, and fabric api on it, then launched and added "{{item:weapon.mainhand:dur, "item has durablility"}}" to profile1

Interesting, apparently I didn't add "." to the list of characters a variable could have in conditionals. I'll fix that for the next update.
In the meantime, you can avoid this by using the "shortcut" names like "mainhand" or "main" instead of "weapon.mainhand"

Fixed in v3.1


[SMALLFIX] Add comments for confused logic in checkPermission method

Add comments for the confused logic in FileSystemMaster.checkPermission() method.
@apc999 , please let me know if any more comments is needed to help readers to understand easily.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Tachyon-Pull-Request-Builder/7705/
Test PASSed.

LGTM

LGTM


DogeCoin是否能改成pos出块？

我在想，目前旷工对dogecoin的帮助已经不是很大，是否将dogecoin改成pos算法来增加市场热度？或者是一个分叉，类似比特币现金？

Sorry I dont speak chinese, but If you understand some english, perhaps dogeducation is a better place to ask your question as it seems to be a general question about what dogecoin actually is in comparison to bitcoin.

现在是怎么挖狗狗币？

找了几个矿池都打不开网站了。。


Remove unnecessary calc() from media query

Summary of proposed changes
I've ran into issues compiling my styling using the gulp-group-css-media-queries plugin:

I discovered the error was in times.scss, specifically the line where the media query uses calc(). Removing calc() solved the compiling error. I guess this should also be fixed in the gulp-group-css-media-queries plugin, but since this particular media query works just fine without the calc(), I went ahead and removed it :)
Checklist

[x] Use develop as the base branch
[x] Exclude the gulp build (/dist changes) from the PR
[x] Test on supported browsers

Thanks! 👍


Added 05_BAGELS in Go.

Intend to develop more of the others, this is just a start.
Any feedback is welcome, thanks in advance.

My bad, just realized Go probably doesn't fit the bill for "memory safe" language.  I was wondering why it wasn't already included in the repo.
Will continue to develop others for my own entertainment.  Very cool repo you have here!

Sure! Please link it from the readme.md, that is definitely encouraged! 🙌


Add checksum validation for non-chunked non-composite downloads

This partially addresses https://github.com/GoogleCloudPlatform/google-resumable-media-python/issues/22
Note current limitations:

doesn't handle chunked download case
doesn't handle case of downloading composite objects
doesn't do anything about upload checksumming

I ran the unit and system tests only against Python 2.7, because my current OS doesn't support Python 3.6.

Hi - I'd appreciate if we could draw this review to a close soon because the lack of checksumming support in this library is causing customer problems. Thanks.

@mfschwartz I am happy to maintainer-ify this PR if you are OK with it? I think it may be easier than a nit-picky review.

Yes please.

@mfschwartz I'm closing this PR in favor of #32 (which uses your 3 commits as a diffbase).
Usually GitHub allows maintainers to push into a PR branch, but I couldn't for some reason (possibly because you used the master branch).
As for not being able to install Python 3 on your machine, if you are on Mac OS X or Linux, I highly recommend pyenv (it does not require root privileges). If you are on Windows, I recommend conda or Miniconda (ditto on admin privileges). I'm happy to help if it's relevant to you. If not, no worries.

... the lack of checksumming support in this library is causing customer problems

If you are referring to https://github.com/GoogleCloudPlatform/google-cloud-python/issues/4129, it seems that the checksumming is a theory for that breakage, but we have not been able to reproduce the customer's report.

Thanks for the commits Danny.
The problem I was referring to was not GoogleCloudPlatform/google-cloud-python#4129, but rather a customer who reached out to the GCS team directly.

Can you please tell me when you have the two libraries in a state where it's possible to build new releases (at a min I think that means updated version #s and dependencies)? Thanks!

Yes. I'm worried that google-cloud-core will make releasing painful. Hopefully not.

@mfschwartz Am I correct in assuming you are OK with a release with the partial support implemented?

Yes, a release with partial support would be good.
I'm sure you're going to but can you please make sure all the tests pass? I tried to fix the test failure on python 3.6 but since I don't currently have a python 3.6 installed I can't test it.
(I saw your note about installing 3.6 on various platforms. I could do that on my Mac; I just did this development on an Ubuntu version that currently doesn't yet support 3.6.)

Yes, they are all passing: https://circleci.com/gh/GoogleCloudPlatform/google-resumable-media-python/198

My primary dev machine is Ubuntu and I use pyenv and never looked back. It's as easy as:
git clone https://github.com/pyenv/pyenv.git ~/.pyenv
~/.pyenv/bin/pyenv install 3.6.3
~/.pyenv/versions/3.6.3/bin/python3.6

If you want to just type python3.6, check out the README on the GitHub repo for things to add to your bashrc (or zshrc, etc.)

Ah, thanks, that was quite easy!


suggestion: enable automatic light/dark theme

The dark theme can be wrapped in a media query for automatic theme switch.
@media (prefers-color-scheme: dark) ...
Maybe I would change the command for dark mode to be something like --theme=light/dark/auto

sounds good!


Chatter example

This is a very simple chat example using the pyramid framework. I took it from the original gevent-socketio from @abourget.

This works with socketio 0.9, right ? not 1.0+
so it basically fixes the compat. with the latest gevent-websocket is that right ?

hmm.. so this just adds a new example, is that right ? :) heehee

No it works with socketio 1.0+.

oh cool !

oh so gevent_socketio2 is the revamp to support Socket.IO 1.0+ ? that's great.. I didn't have much time to continue gevent-socketio.. glad you're taking over! good luck!


Can't open any cosmetics.

Heyo, this project fuckin rocks, but I have a feeling I didn't set something up properly, and I am kinda stuck when it comes to troubleshooting.

I have been getting this error whenever I try to deploy a cosmetic.
Any idea what could be causing this? Is there any more info I could bring here?
Sorry to bother, have a good day.

Sorry for the late reply. For the first screenshot, the error means that the object that was supposed to be spawned was not found. This may be due to a corrupted .blend file. I know this could happen when downloading the entire TF2 Collection as a .zip file, instead of manually downloading each file individually. Alternatively, if you have entries setup for each required asset path, you can just download each asset through the updater panel in Scene Properties.
As for the second screenshot, this is caused by a duplicate class being created. Registering two classes will work just fine, as you are essentially just overwriting the original with a duplicate, but trying to unregister one twice is what causes the issue. This issue was fixed in the latest update. Apologies for it saying that it is still 2.0.4, I forgot to move it up to 2.0.5.

Please do not apologize, this isnt any urgent manner.
As for the error I will try reinstalling the TF2 Blender Port cosmetics.
Thank you a LOT for your work. Blender is much more fun than SFM, and I would have never tried it out had it not been for this project. (and splatoon 3 lol)
Have a great rest of your day.

After reinstalling all the files and setting up the paths again, the IK rigs work fine and actually rotate. But the cosmetic error persists.

Have I done something wrong?

If I dont figure this problem out, Im probably just gonna find the cosmetics manually, no biggie.

Make sure your TF2-V3 entry is set as a folder, do not add entries for each file inside of TF2-V3. It may not be working due to the entries overlapping their names, like "engineer" may be pointing to TF2-V3\engineer.blend, not engineercosmetics.blend.
I don't mind continuing this on discord, but it would be good to keep this visible so that others may find the solution through this.

Ok I have fixed ze problem. Here are the changes I made:

I already have set my asset library to the same drive "The TF2 Collection" is in so I guess that was what was over lapping. I also added entries for the cosmetics in the trifecta plugin and I changed the name of  the entries so that it matched what the plugin needed. And now it works!
Thanks a TON for your help, wouldn't have made it otherwise.

I will now close this Issue, since it has been fixed.


Create stiteknas.txt

Hello Philip.
This is a request for jetbrains academic license from Sekolah Tinggi Teknologi Nasional Jambi, Indonesia, (www.stiteknas.ac.id).
Thank you.

@ad-riyan I am sorry for a delay with processing your request.
Pull request merged. Thank you!


Fix client_postfix option when not set

According to the documentation:

Optional. Set postfix for client folder and Class. Works if there is only a single class or squish_clients is true. Default: ApiClient

However, when attempting to set an empty postfix in swagger_parser.yaml:
client_postfix: ''

Results in an incorrect output (assume the client file name is api_operations):
part 'api_operations_.g.dart';

There is a trailing underscore when there should not be. Removing the underscore resolves the issue.
Expected Result:
part 'api_operations.g.dart';

Thanks, I'll fix it sometime later


[Identity] Investigate and update Identity on Azure Functions manual tests

The status of the Azure Functions manual tests is uncertain.  In any case, instructions should be revisited to ensure functionality and also updated to use Azure Functions Core Tools 4.x.

The base image in the Dockerfile should be updated to use something like mcr.microsoft.com/azure-functions/python:4-python3.10
Update instructions to use the Azure CLI to assign the managed identity to the user-assigned function app.
If possible, convert individual manual provisioning steps to an ARM/Bicep template.

Label prediction was below confidence level 0.6 for Model:ServiceLabels: 'Functions:0.5212863,Azure.Identity:0.18259099,App Services:0.075521074'


ICFAR-311 [Xconf] Remove legacy code from firmware section

Don't merge until Xconf 3.5 is released.

01-20-2021: All files up to and including commit 3ace1dd have been reviewed.

01-20-2021: All files up to and including commit 3ace1dd have been reviewed.

Holding on merge until 3.5 work is completed.

Holding on merge until 3.5 work is completed.


Fact not displayed in changes

In https://knooppuntnet.nl/en/analysis/changes smiley seem not updated according facts added or resolved.

For Changeset 114838068, there is no sad emoticon to show an issue for route no-name
For Changeset 114838147, nothing show that facts are resolved

Changeset 114838068 don't display facts for route no-name

Route changes

Resolved facts are displayed 😃

Changeset 114838147
Route changes

Seem solved 😃
See changeset 114880446


Possible to add animations?

Hello guys. Any idea how I would add animation to this pie chart?

Hi @kilgarenone, it could be possible with css animations and let user enable it with a prop. You are welcome if you want to do a PR 👍🏻
Thank you

Ok I will see what I can do! Thanks!


How many hits I have accumulated

I want to know how many hits I accumulated in a 7 day free trail app that has been lost?

Like; any one of the websites I've been too that has been past my 7 days trial.

Not relevant to this project.


[bug] - TypeError: Right side of assignment cannot be destructured

Is there an existing issue for this?

[X] I have searched the existing issues

RainbowKit Version
1.0.2
wagmi Version
1.2.0
Current Behavior
This happens when I hit a wallet button.

the error seems to be referring to this line

Expected Behavior
No response
Steps To Reproduce
This only happens when I ask to use walletConnectVersion: '2':
const projectId = 'xxx'

export const wagmiConnectors = connectorsForWallets([
  {
    groupName: 'My app',
    wallets: [
      rainbowWallet({ chains: [], projectId, walletConnectVersion: '2'}),
      walletConnectWallet({ chains: [], version: '2', projectId}),
    ],
  },
]);

export const wagmiConfig = createConfig({
  autoConnect: true,
  connectors: wagmiConnectors,
  publicClient,
});

Have you ever seen this error before? Not sure if I'm following what is going on.
Thank you!
Link to Minimal Reproducible Example (CodeSandbox, StackBlitz, etc.)
No response
Anything else?
No response

this error is gone. Not sure what happened.


Load PDB debug info (path, guid, age) from PE/COFF object files

We add loading of PDB debug info (path, guid, age) to our PE/COFF
object file class so that we can uniquely match PDB files to COFF files.
Tested: Unit tests.
Bug: https://b/194497774

@dimitry- Thanks for the review. I think I addressed all your comments. PTAL. I force pushed after rebasing on main due to the llvm revert. Hope this doesn't make it too hard to track the change.
@beckerhe Thanks for the review!


Docker task running Prowler cannot find ./output/prowler-output-./include/whoami

I'm running prowler scans in an ECS container. My local copy of prowler can pick-up the whoami file but the task cannot.
The outputted csv file has './include/whoami: line 47: jq: command not found' in the ACCOUNT_NUM field and the task outputs an 'tee: './output/prowler-output-./include/whoami:': No such file or directory' error message for every check.
I can provide the dockerfile used to replicate if helpful, thanks.

I had this same issue. I was running Kali linux and the error was caused by not having the jq command installed as standard.

As @FishermansEnemy says, that seems to me that jq is not installed in the image instead of an issue with include/whoami. Are you using the official image (toniblyx/prowler:latest) or building your own with the existing Dockerfile https://github.com/toniblyx/prowler/blob/master/util/Dockerfile? You can see here all dependencies https://github.com/toniblyx/prowler/blob/583cffaefb067e8fbd81a5300db11a0a841102b2/util/Dockerfile#L8-L10

Closing it. There are no further comments in this issue.


[FLINK-18191] Rename jobmanager.memory.* configuration options into master.memory.*

This commit renames the jobmanager.memory.* config options into master.memory.* to
align it better with the overall Flink terminology.
cc @zentol.

Thanks for the quick review @zentol. Unfortunately, there is currently a discussion about renaming the "Flink Master" back into the "JobManager" again. Until this discussion is resolved, we need to put this effort on halt, unfortunately.

@tillrohrmann Where is this discussion? I only saw one comment by @aljoscha in FLINK-18209.

https://lists.apache.org/thread.html/red9d18f7173d53d016f6826410841b2726b9293ceefaea2de0cdeafb%40<dev.flink.apache.org>

Closing this PR since it seems to be no longer relevant.


Can't see deleted spaces in the Diff

It's hard to know when spaces are deleted because they aren't marked in the diff (can't color a space red).
To fix this, we'd need to do an improved diffing view that colored the background, similar to Sublime Text's find and replace (which looks awesome).

Hey @edwardrowe,
I am not so sure how you imagine this working, but I tried to replicate the Sublime Text's find and replace, here is it:

The first file is called "_[]b[][][]a" and the second "a[][]b", being [] whitespaces
It is like this that you were imagining this feature?

It's very helpful to have another pair of eyes on this. I used SublimeText
as reference too, so it's good to hear that's where you're looking. I do
like the background highlight in SublimeText, but found it hard to
replicate. Is that what you were going for here?
This is hard to do I think within Unity, but I was hoping it would
highlight only the spaces. What do you think about that? Here's a mockup:
[image: image.png]
On Sun, Oct 13, 2019 at 3:28 PM Murillo Pugliesi Lopes <
<EMAIL_ADDRESS>wrote:

Hey @edwardrowe https://github.com/edwardrowe,
I am not so sure how you imagine this working, but I tried to replicate
the Sublime Text's find and replace, here is it:
[image: Example]
https://camo.githubusercontent.com/d485185053cff990eaa5b8e295f3f77d49df99dd/68747470733a2f2f692e696d6775722e636f6d2f4f356a59566a6f2e706e67
The first file is called "_[]b[][][]a" and the second "a[][]b", being []
whitespaces
It is like this that you were imagining this feature?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/redbluegames/unity-mulligan-renamer/issues/160?email_source=notifications&email_token=AADBIKIWUJB7DM75B2LYBP3QONZHLA5CNFSM4E2NZ2TKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBC56BY#issuecomment-541449991,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AADBIKK7EJMGKP2TH7IBVLLQONZHLANCNFSM4E2NZ2TA
.

I am sorry, but I can't see the attachment.
Do you mind uploading the image somewhere else and posting the link here?

Does this work? I did that via email, must not have liked it.

Oh, now I see, thanks!
I think I can replicate this with a bit of creativity. Let me try something.

Hey @edwardrowe,
I think I got it working the way you imagined it

Was that how you thought it would work?

Yes, it looks like I envisioned, and I think your style measurement method,
to measure the areas with style.CalcSize seems solid.
Again I'll have to give you some thorough time for review later this week
or next. But thank you very much in the meantime. I don't think I'd have
tackled this for a long time but it's a really big value add!
On Mon, Oct 14, 2019 at 2:50 AM Murillo Pugliesi Lopes <
<EMAIL_ADDRESS>wrote:

Hey @edwardrowe https://github.com/edwardrowe,
I think I got it working the way you imagined it
[image: Example]
https://camo.githubusercontent.com/c8533968088ba77146e5e8436540f5e0b4452589/68747470733a2f2f692e696d6775722e636f6d2f386730324c6c582e676966
Was that how you thought it would work?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/redbluegames/unity-mulligan-renamer/issues/160?email_source=notifications&email_token=AADBIKPXQJ6M7RHZBMISXETQOQJDXA5CNFSM4E2NZ2TKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBDPULA#issuecomment-541522476,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AADBIKNLK2UMQS3ISWVKYJLQOQJDXANCNFSM4E2NZ2TA
.

No problem at all @edwardrowe, take your time.
I am glad that I am adding value to this project :)


Generate faculty field from department field during LibreCat export

The faculty field was previously generated from the department tree sub-field by ElasticSearch using the copy_to function in the ES schema (publication.json)  However, this does not work properly in tree context where a tree sub-field looks like this:
{
    "id": "GE10",
    "tree": [
        {
            "id": "UGent"
        },
        {
            "id": "GE"
        },
        {
            "id": "GE10"
        }
    ]
}

In this example, we want to move the GE value out of the field and into the  faculty field.  ElasticSearch doesn't allow such fine-grained control. The ES community seems to recommends to solve this in the source data, rather then as a stored field in the indexed document.
As a result, previously, the faculty field wasn't populated during indexation. The  faculty facet remained empty, and the dashboard didn't work at all.
So far, this has been solved in the GRPC command line tool. Adding JSON records with a department field having a tree subfield will extract the faculty data from said ŧree field.
Still to do:
Importing data via the regular go run main.go publication add < export.json command (non-GRPC) doesn't take this into account. It expects that the faculty field is already present in the records exported from LibreCat.

[ ] Add faculty field to the export from LibreCat based off the department field
[ ] Test the regular go run main.go publication add command. Make sure that the faculty field is present.

See also: 7ad06978

Now that we have a model "IndexedPublication", we can add faculty only in the indexed version of the publication,
rather than auto-updating faculty internally also in the source record?

@nicolasfranck yes

@nicolasfranck I have added a faculty property to models.Publication. But maybe that could be moved to es6.indexedPublication? If we do this, probably also needs some adjustments in the facets, right?


added script to search for unused files

@tradej @inoxx03 @gastaldi let me know what you think.

@tradej let me know what you think

LGTM.


Read Support for JSON column

Summary:
This commit contains changes necessary for reading a JSON column using SqlDataReader.GetString(i).
Tests will be added for read and write when we finalize our approach for testing this against custom build of SqlServer that has JSON support.

@dotnet-policy-service agree company="Microsoft"


"base" in the INI file of a Tatin server

Setting this is only required when a Tatin server hides behind an Apache (or any other) server and no proxy is involved.
Therefore it should be allowed to set "base" to an empty vector, and GetBaseForHTML should in such a case return an empty vector.

Removed altogether in 0.114.0


Ran CPP check on a few files while prodding around

Another example of some of the changes it recommends, I think
it would be useful to try to work on getting us CPPCheck "free".

Removed the ternary operators. FYI, we have about 4,800 of those :)

Looks good to me. I especially like the minimization of variable scopes because we have a lot of very large functions. It helps reading the code.
@zwoop Do you want an approval on this PR, or is this just a preview?

@maskit  yeh, please approve if you agree with this.

And yes, minimizing variable scope is one of the nice things with CPPCheck.


Banner not updated for STRKFarm

Hey team, it's been 3 days since the PR to add STRKFarm was merged: https://github.com/419Labs/starknet-ecosystem.com/pull/675, but the banner is not updated yet.
I've read the previous issue on the same problem and found out that it takes up to 24 hours for the cache update: https://github.com/419Labs/starknet-ecosystem.com/issues/168
Since it's been more than 72 hours, I am raising this issue to get some clarity on how we can fix this. Let me know if there's anything we can do from our end!
Project link: https://www.starknet-ecosystem.com/projects/0f2ecfe3-1212-4157-9176-aeeb4204294f
Attaching images here:

Starknet-db was not synced correctly, fixed now


Clean dependencies and simply build.gradle files

This PR is to clean all the unused dependencies and simplify build.gradle files.
Tested by building it.

Thanks for the PR @ljfgem!
Changes look good to be checked in.


add sync module

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

51 of 53 (96.23%)  changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.4%) to 91.692%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/subscriptions/subscriptions.service.ts
24
26
92.31%

Totals

Change from base Build<PHONE_NUMBER>:
0.4%

Covered Lines:
508

Relevant Lines:
531

💛  - Coveralls


1215 CachingCachingRegistryClient stores data by wrong keys resulting in fetch operations always missing.

1215  CachingCachingRegistryClient stores data by wrong keys resulting in fetch operations always missing.

Codecov Report

Merging #1216 into master will increase coverage by 0.08%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master    #1216      +/-   ##
============================================
+ Coverage     64.59%   64.68%   +0.08%
- Complexity      804      806       +2
============================================
  Files           129      129
  Lines          3692     3692
  Branches        529      529
============================================
+ Hits           2385     2388       +3
+ Misses         1034     1032       -2
+ Partials        273      272       -1

Impacted Files
Coverage Δ
Complexity Δ

...ud/stream/schema/client/CachingRegistryClient.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...gframework/cloud/stream/binder/DefaultBinding.java
66.66% <0%> (+16.66%)
4% <0%> (+2%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0463f79...88a21c3. Read the comment docs.

@jmax01 I'll start reviewing, polishing and merging it, but wanted to make one general comment. As you have probably noticed especially with this issue in particular, this could have been easily caught if there was a test for it, but I gather there wasn't. I'll write one up as part of polishing unless you're willing to contribute one, then I'll wait. LMK. Cheers

I would love to but am hyper busy at the moment. I will try if I can get a few.


CVE-2024-6119 found by Wiz in DataDog Agent latest version

Hey, we got an issue in Wiz about CVE-2024-6119 which was rated High.
In the latest version openssl was updated to version 3.3.1 and this CVE is fixed in version 3.3.2.
Can you please say if it's planned to be updated in the upcoming version and when it's planned to be released?
Thank you.

Any update about it?

Any update here?


⚠ Bofrost.fr has degraded performance

In 248071f, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1677 ms

Resolved: Bofrost.fr performance has improved in 47878de.


pull request for e2e test at 12/23/2016 15:56:06

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Is it possible to reference query parameter to enum defined in definitions ?

Is it possible to reference query parameter to enum defined in definitions ? For example consider following example:
paths:
  /users/test:
    get:
      summary: Test endpoint
      parameters:
        - name: osType
          in: query
          description: Client's OS type.
          required: true
          type: string
          enum:
          - ios
          - android

then I define this
definitions:
  OsTypes:
    type: string
    enum:
    - ios
    - android

Can I reference it from endpoint to avoid defining allowed values of the enum in every endpoint that uses it ?
I tried
schema:
  $ref: '#/definitions/OsTypes'

Thanks!

There's currently no way to reference definitions that are not body parameters. We're definitely considering changing that in a future version, which is covered by #301.


Use resource id as dialog id only if the dialog doesn't have an id

Fixes #2579
Description

If a dialog does not have an id in JSON file, resource id would be used as dialog id.
Specific Changes

Updated loadType in resource explorer to assign dialog id.

Testing

Updated test case to verify this feature.

Pull Request Test Coverage Report for Build 158413

6 of 6 (100.0%)  changed or added relevant lines in 1 file are covered.
9 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.06%) to 82.798%

Files with Coverage Reduction
New Missed Lines
%

libraries/botframework-streaming/src/webSocket/webSocketTransport.ts
2
80.65%

libraries/botframework-streaming/src/webSocket/webSocketServer.ts
7
66.67%

Totals

Change from base Build 158344:
-0.06%

Covered Lines:
15145

Relevant Lines:
17394

💛  - Coveralls

https://github.com/microsoft/botbuilder-js/pull/2742 will fix the CI issues related to the release of TypeScript 4.x


Deadlock cause by "hidden" panics in metrics

Unfortunately is not possible to retrieve the exact cilium commit has this was tested of a branch.
goroutine 175044 [semacquire, 484 minutes]:
sync.runtime_SemacquireMutex(0xc42020b208, 0xfda300)
	/usr/local/go/src/runtime/sema.go:71 +0x3d
sync.(*Mutex).Lock(0xc42020b204)
	/usr/local/go/src/sync/mutex.go:134 +0x108
sync.(*RWMutex).Lock(0xc42020b204)
	/usr/local/go/src/sync/rwmutex.go:93 +0x2d
github.com/cilium/cilium/pkg/endpoint.(*Endpoint).UnconditionalLock(0xc42020b200)
	/go/src/github.com/cilium/cilium/pkg/endpoint/lock.go:55 +0x31
github.com/cilium/cilium/pkg/endpoint.(*Endpoint).regenerateBPF.func2(0xc42556daf8, 0xc42020b200, 0xc42556d920, 0xc42556d908)
	/go/src/github.com/cilium/cilium/pkg/endpoint/bpf.go:569 +0x234
panic(0x26c8cc0, 0xc425fe6ed0)
	/usr/local/go/src/runtime/panic.go:502 +0x229
github.com/cilium/cilium/vendor/github.com/prometheus/client_golang/prometheus.(*counter).Add(0xc4202da540, 0xbef4a2cf4d5aa6c0)
	/go/src/github.com/cilium/cilium/vendor/github.com/prometheus/client_golang/prometheus/counter.go:63 +0xb2
github.com/cilium/cilium/pkg/endpoint.(*Endpoint).regeneratePolicy(0xc42020b200, 0x2c0a8a0, 0xc4222f7400, 0x0, 0x0)
	/go/src/github.com/cilium/cilium/pkg/endpoint/policy.go:582 +0x609
github.com/cilium/cilium/pkg/endpoint.(*Endpoint).regenerateBPF(0xc42020b200, 0x2c0a8a0, 0xc4222f7400, 0xc4214b7600, 0x1b, 0xc4239f9760, 0xa, 0xc425df16c0, 0x0, 0xf87200, ...)
	/go/src/github.com/cilium/cilium/pkg/endpoint/bpf.go:591 +0x19c2
github.com/cilium/cilium/pkg/endpoint.(*Endpoint).regenerate(0xc42020b200, 0x2c0a8a0, 0xc4222f7400, 0xc425df16c0, 0x0, 0x0)
	/go/src/github.com/cilium/cilium/pkg/endpoint/policy.go:763 +0x7a6
github.com/cilium/cilium/pkg/endpoint.(*Endpoint).Regenerate.func1(0xc425df16c0, 0x2c0a8a0, 0xc4222f7400, 0xc421881780, 0xc42020b200)
	/go/src/github.com/cilium/cilium/pkg/endpoint/policy.go:842 +0x1fc
created by github.com/cilium/cilium/pkg/endpoint.(*Endpoint).Regenerate
	/go/src/github.com/cilium/cilium/pkg/endpoint/policy.go:820 +0x123

The panic above was inside the "Add" of this line: https://github.com/cilium/cilium/blob/ccd371c9acc761f0d37c045ff344f71341c91dcc/pkg/endpoint/policy.go#L584
Which was called inside this function
https://github.com/cilium/cilium/blob/ccd371c9acc761f0d37c045ff344f71341c91dcc/pkg/endpoint/policy.go#L483-L484
As we can see, the function can only be called with the endpoint mutex held, as the function panicked, the mutex was still held. Although we have a "defer" function, that defer function also wanted to Lock the endpoint. Unfortunately, the endpoint mutex was not Unlocked because of the panic, the defer is never executed and the mutex is never unlocked.

When the function F calls panic, execution of F stops, any deferred functions in F are executed normally, and then F returns to its caller.

I think @jrajahalme's PR
https://github.com/cilium/cilium/pull/5616 is meant to solve the problem of acquiring endpoint locks in defer statements within regenerateBPF.

Invalid regenerateTimeSec ?

regenerateTimeSec := float64(time.Since(regenerateStart)) / float64(time.Second)
...
metrics.PolicyRegenerationTime.Add(regenerateTimeSec)

https://godoc.org/github.com/prometheus/client_golang/prometheus#Counter

// Add adds the given value to the counter. It panics if the value is <
// 0.

Unfortunately #5616 seems impossible to rebase without basically re-doing it from scratch. I closed it for now.

https://github.com/cilium/cilium/issues/6209 appears related.

goroutine 49164 [semacquire, 608 minutes]:
sync.runtime_SemacquireMutex(0xc0003ae6c8, 0xc005074000)
	/usr/local/go/src/runtime/sema.go:71 +0x3d
sync.(*Mutex).Lock(0xc0003ae6c4)
	/usr/local/go/src/sync/mutex.go:134 +0xff
sync.(*RWMutex).Lock(0xc0003ae6c4)
	/usr/local/go/src/sync/rwmutex.go:93 +0x2d
github.com/cilium/cilium/pkg/endpoint.(*Endpoint).UnconditionalLock(0xc0003ae6c0)
	/go/src/github.com/cilium/cilium/pkg/endpoint/lock.go:55 +0x31
github.com/cilium/cilium/pkg/endpoint.(*Endpoint).regenerateBPF.func2(0xc006257b00, 0xc0003ae6c0, 0xc006257928, 0xc006257910)
	/go/src/github.com/cilium/cilium/pkg/endpoint/bpf.go:571 +0x232
panic(0x27b3480, 0xc005074100)
	/usr/local/go/src/runtime/panic.go:513 +0x1b9
github.com/cilium/cilium/vendor/github.com/prometheus/client_golang/prometheus.(*counter).Add(0xc0000e4300, 0xbee83c9dfc3b0aa9)
	/go/src/github.com/cilium/cilium/vendor/github.com/prometheus/client_golang/prometheus/counter.go:63 +0xa3
github.com/cilium/cilium/pkg/endpoint.(*Endpoint).regeneratePolicy(0xc0003ae6c0, 0x2d97640, 0xc001984f20, 0x0, 0x0)
	/go/src/github.com/cilium/cilium/pkg/endpoint/policy.go:584 +0x5e3
github.com/cilium/cilium/pkg/endpoint.(*Endpoint).regenerateBPF(0xc0003ae6c0, 0x2d97640, 0xc001984f20, 0xc001eac000, 0x1a, 0xc0034da040, 0x9, 0xc004dba000, 0x0, 0xc00195eb00, ...)
	/go/src/github.com/cilium/cilium/pkg/endpoint/bpf.go:593 +0x1a6f
github.com/cilium/cilium/pkg/endpoint.(*Endpoint).regenerate(0xc0003ae6c0, 0x2d97640, 0xc001984f20, 0xc004dba000, 0x0, 0x0)
	/go/src/github.com/cilium/cilium/pkg/endpoint/policy.go:765 +0x782
github.com/cilium/cilium/pkg/endpoint.(*Endpoint).Regenerate.func1(0xc004dba000, 0x2d97640, 0xc001984f20, 0xc0017e03c0, 0xc0003ae6c0)
	/go/src/github.com/cilium/cilium/pkg/endpoint/policy.go:851 +0x1fe
created by github.com/cilium/cilium/pkg/endpoint.(*Endpoint).Regenerate
	/go/src/github.com/cilium/cilium/pkg/endpoint/policy.go:822 +0x116

as we can see in the stack trace the value is really negative at the point the Add is called. bee83c9dfc3b0aa9 or -0.00001968000000000000131172850359462245251052081585 seconds to be precise

@ianvernon Yes, floats are not 100% accurate. The division can obviously result in a very small number. What is new to me is that a very small number can become negative.

@tgraf that's why I'm wondering if there's some type of problem with division that is causing some type of underflow problem :/ I see no other possible explanation . The log that @aanm pasted above  shows the time is logged before any floating point calculations are performed.
Looking at the following:
regenerateTimeSec := float64(time.Since(regenerateStart)) / float64(time.Second)

time.Since(Time) returns a duration as a Duration (int64), which we then divide by float64(time.Second). Dividing int64 by float64 seems fishy to me.


Change default values for Navigation

Change
    public $nav_left = false;
    public $nav_right = false;

to
    public $nav_left = true;
    public $nav_right = true;

That way if you hook into the action there is no extra settings to turn them on, and you can still disable them if you want.

these had been removed from the class in my last commit - https://github.com/OCG-labs/one-theme/commit/b6cc068b52743af8510299eddc046b7418bafa5d


Doc warnings

Fixes #2576
Add <> to links where needed, fix typo and refactored names, and add docs.rs links for external items.

bors try

bors try

@cart Could I get the workflow run for this? I can't do it since I'm a first time contributor.

bors try

What should I do to get that to work?
It says to run cargo fmt --all, which modifies uh... 408 files, it looks like.
And whatever the dependencies issue is?

@Hoidigan, clicking through, I'm seeing

error: failed to download from https://crates.io/api/v1/crates/ab_glyph_rasterizer/0.1.4/download

Caused by:
[55] Failed sending data to the peer (Connection died, tried 5 times before giving up)
Error: Process completed with exit code 101.

Looks like a networking error that isn't your fault. https://github.com/bevyengine/bevy/pull/2040 has more contributing advice for you though; it's just waiting on final review now <3

bors try

@Hoidigan could you run cargo fmt to fix format?

I should be able to this Sunday, sorry about the wait. I'm away and don't have my computer

(Sorry I'm a bit slow)
Running cargo fmt --all modifies all 408 files. I only committed the changes in the 3 ci complained about, but that was little weird. I think it was newline issues, but I don't actually know.

bors r+


Prefill security API key

Hi!
Thank you for your awesome web component, it does its job very well!
I just encountered a bug (I guess). I have an API which has a specific HTTP header, here is the definition of the security scheme (extract of my openapi.json):
{
    "securitySchemes": {
        "bearerAuth": {
            "type": "apiKey",
            "in": "header",
            "name": "X-Authorization",
            "description": "Value format: \"Bearer xxxxx\" where xxxxx is replaced by a valid JWT token issued from Firebase. See: https://firebase.google.com/docs/auth"
        }
    }
}

I would have liked to prefill the API key field:

But it seems that it cannot be set, even if I use the api-key-value attribute on the <rapi-doc> element.
Thanks for your help!

thanks for pointing out that regression. I will get it fixed soon

this is now been fixed in release 7.0.0
below 3 attributes can be used to make it work

api-key-name
api-key-value
api-key-location

feel free to reopen in case it is not working as you were expecting it to be

@mrin9 It works fine! Thanks for the quick fix 👍


TEST PULL REQUEST. DO NOT MERGE.

Rebuild after update in master

Rebuild after update in master

Rebuild after update in master


Better tests

Fixes #196
Make test really as Unit and starts to create scenarios.

Codecov Report

Merging #337 into master will increase coverage by 1.48%.
The diff coverage is 100%.


Support for Windows in version 2.0.0

Hi, is the new version planned to be able for Windows?
Thanks

Hi,
it should already work for Windows but someone needs to create Windows executable on a Windows machine. I only have a Mac and I currently don't have the time to setup a Windows VM and do it.
It should work by running the Quasar build command: https://quasar.dev/quasar-cli-vite/developing-electron-apps/build-commands


Bump google-api-services-cloudkms to latest

Problem
tink-gcpkms:1.7.0 has dependencies to google-api-services-cloudkms:v1-rev108-1.25.0 and google-api-client:1.33.2. When trying to bump google-api-client to a version later than 1.35.2, this error appears:
You are currently running with version 2.2.0 of google-api-client. You need at least version 1.15 of google-api-client to run version 1.25.0 of the Cloud Key Management Service (KMS) API library.

google-api-services-cloudkms README points to a version different from latest which also gives the same error:
google-api-java-client-services
In Maven Central, latest version of google-api-services-cloudkms appears somewhere in the middle of the list of releases:
https://mvnrepository.com/artifact/com.google.apis/google-api-services-cloudkms
Desired solution
Bump google-api-services-cloudkms to a version that supports google-api-client:2.x
google-api-services-cloudkms:v1-rev20221107-2.0.0 appears to work with google-api-client:2.2.0 and tink-gcpkms:1.7.0.

Hi @roar-skinderviken, thanks for pointing this out. I've upgraded this in https://github.com/google/tink/commit/6c29d611f4c4c7656fe791741722a5e9b5b5ef64. Could you please try com.google.crypto.tink:HEAD?

Hi @morambro
Thanks for super-quick response! Just tested com.google.crypto.tink:tink:HEAD-SNAPSHOT, works great.
I spotted a few conflicts that you may want to resolve when at this:

Resolved these conflicts in my POM by adding the following deps to dependencyManagement:
<dependency>
    <groupId>com.google.http-client</groupId>
    <artifactId>google-http-client</artifactId>
    <version>1.42.3</version>
</dependency>
<dependency>
    <groupId>com.google.http-client</groupId>
    <artifactId>google-http-client-gson</artifactId>
    <version>1.42.3</version>
</dependency>
<dependency>
    <groupId>com.google.oauth-client</groupId>
    <artifactId>google-oauth-client</artifactId>
    <version>1.34.1</version>
</dependency>
<dependency>
    <groupId>com.google.api-client</groupId>
    <artifactId>google-api-client</artifactId>
    <version>2.2.0</version>
</dependency>

Thanks for the feedback. This should be fixed by https://github.com/google/tink/commit/f1267db697e6c176aa4bdc2417ed3ed8ae714252. I've upgraded google-oauth-client to 1.34.1. com.google.crypto.tink:tink:HEAD-SNAPSHOT should be up-to-date with this commit.

You are currently running with version 2.2.0 of google-api-client. You need at least version 1.31.1 of google-api-client to run version 1.32.1 of the Cloud SQL Admin API library.

You are currently running with version 2.2.0 of google-api-client. You need at least version 1.31.1 of google-api-client to run version 1.32.1 of the Cloud SQL Admin API library.

google-api-client:2.2.0 is a newer version than 1.31.1, I don't see your concern here.

This was included in the latest release.


Predicate generation while having an string array over relation

I have an string array over relation and unable to generate predicate with querydsl.
Consider the following scenario,
NODE {id: 10} --- [LINKS_WITH {markets: ['US', 'France']}] ---> NODE {id: 21}
NODE {id: 10} --- [LINKS_WITH {markets: ['UK']}] ---> NODE {id: 22}
NODE {id: 10} --- [LINKS_WITH {markets: ['Canada']}] ---> NODE {id: 23}
NODE {id: 10} --- [LINKS_WITH {markets: ['Germany']}] ---> NODE {id: 24}
Now I have to get all nodes associated with the node having id 10 if the relation contains France in it.
I am unable to generate its predicate. Any help would be highly appreciated.

Thanks @msanadeem for your interest. We are rebooting this project. With the upcoming version you'll be able to do the following:
var src = anyNode().withProperties("id", literalOf(10));
var n = anyNode().named("n");
var statement = Cypher.match(src.relationshipTo(n, "LINKS_WITH").named("r"))
	.where(literalOf("France").in(property("r", "markets")))
	.returning(n)
	.build();

assertThat(cypherRenderer.render(statement))
	.isEqualTo("MATCH ( {id: 10})-[r:`LINKS_WITH`]->(n) WHERE 'France' IN r.markets RETURN n");

Which gives to required cypher for your use case (MATCH ( {id: 10})-[r:LINKS_WITH]->(n) WHERE 'France' IN r.markets RETURN n").


Tenable VM function app 3.0.1 points to invalid URL function app does not run

Describe the bug
The Tenable App, Tenable Vulnerability Management (using Azure Function) fail to download zip package and does not run
To Reproduce
Steps to reproduce the behavior:

Go to 'Content Hub in Sentinel'
Click on 'Install Tenable App Solution v3.0.1'
Scroll down to 'Data Connectors'
Open and Deploy the function app from within the Tenable Vulnerability Management (using Azure Functions)
Check the URL used in the Environment variables "WEBSITE_RUN_FROM_PACKAGE"
Try to access the URL and find it redirects to a blank page and no zip file is downloaded. https://aka.ms/sentinel-TenableVMAzureSentinelConnector310-functionapp

Expected behavior
Previous deployments downloaded a zip file from https://aka.ms/sentinel-TenableIO-functionapp and function app would start and run correctly.
Screenshots
Errors in browser when trying to access https://aka.ms/sentinel-TenableVMAzureSentinelConnector310-functionapp

Deployment of function app shows URL

Desktop (please complete the following information):
Smartphone (please complete the following information):
Additional context
Please update this URL to direct to a zip file
https://aka.ms/sentinel-TenableVMAzureSentinelConnector310-functionapp
or change the code on this page to point to a valid URL https://github.com/Azure/Azure-Sentinel/blob/master/Solutions/Tenable App/Data Connectors/TenableVM/azuredeploy_Connector_TenableVM_AzureFunction.json

Hi @PCNZ, Thanks for flagging this issue, we will investigate this issue and get back to you with some updates. Thanks!

@PCNZ, We have fixed the issue, could you please redeploy / restart the fun app and confirm once. Thanks!

@PCNZ, This issue has been fixed, please let us know/ reopen the case if still it occurred. Many Thanks!

@PCNZ, This issue has been fixed, please let us know/ reopen the case if still it occurred. Many Thanks!

Thanks for the quick action on this @v-sudkharat, yes it's fixed and the package is downloading now on new deployments of the function app.


Search is a pain to remember the attempts and delays

I also noticed how much of a pain playbook is now you have to keep defining these on the search actions as well as the start action - we need to find a nicer more user friendly way to do this. I expect we need to include it in the playbook data and then when you change the values it does a mass update on the database for all existing playbook entries by x name

Why dont we have an option to load from an existing trigger?

That would make sense, so it loads the maxAttempts and delayBetweenAttempts from the object instead? I guess we'd have to let it poll the object when it runs in the flow to maybe make sure the values were still accurate?

If we poll it as part of the init loading then jimi will cache the value until he rebuilds the trigger which by default is every 60 seconds.


Abbreviations update and adding Scope and User Interaction

Howdy,
Submitting as a potential fix for issues #12 and #13. Please let me know if I missed something or need to change something.
I'm also down to add fields for the temporal and environmental metrics if you think it would help out.
Thanks!
-Jake

Hello!
Thanks for the contribution, if you see the cve.py file the script is currently gathering data from CVSSv2, so I think to add those fields we should move to cvssv3.
And see that you have changed the "nb_risk/migrations/0002_vulnerability_cvssaccesscomplexity_and_more.py" file, that's a migration file that is managed by Django, so those files shoudn't be changed mannually because they do database changes and changing they may break the module updates.
Finnaly adding new fields to models requires changes in almost all files, to setup tables, filters and the api.


README.md

Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] Documentation update

Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] I have not reduced the existing code coverage
[ ] I have added docstrings following the Python style guidelines of this project to all new modules, classes, methods and functions are documented with docstrings following; I have updated any previously existing docstrings, if applicable
[ ] I have updated any sections of the app's documentation that are affected by the proposed changes, if applicable

updated readme file

I am not even sure, how this is a README update, you have just removed empty lines??

Hi @janni-03: you are very welcome to contribute PRs to our repos, and there are quite a number of issues that are labeled with the "Hacktoberfest" or "Good first issue" labels, if you are interested to do so. Wny not take one of these up, read through our contribution guidelines and address them? That is likely going to be valuable for both you and us. As it is, I had to of course mark the PR as "spam".


log error if wasi:http/incoming-handler#handle fails post-response

Previously, we were simply ignoring the result of the guest invocation once it produced a response, which meant if it trapped after that point nothing would be logged.  Now we always log if there's any kind of error.

Is this a v2.0 backport candidate?

Yes; it's on my todo list to create a backport PR, but haven't gotten to it yet.

I got u fam: https://github.com/fermyon/spin/pull/2034

Thanks @vdice!  I wish there was a backport button in GitHub.


Epinio apps don't have a sidecar

Reproduce:

Install epinio
Push an app (the sample app will do)

Although the namespace is annotated for linkerd, the application pod doesn't get a sidecar. This is because we create the application with automountServiceAccountToken: false (see here: https://github.com/linkerd/linkerd2/issues/3183). We do this because we don't want the code inside the application pods to be able to talk to kubernetes (which is what the servicetoken is allowing). Linkerd on the other side needs this.
We need to find a way to have a sidecar without allowing application code to do nasty things on the cluster.

btw, staging pods have sidecars which means they don't have the automountServiceAccountToken set to false. Maybe they should? Should the staging pods be meshed? (if they only need to talk to the registry and the registry is not meshed then maybe they shouldn't).

Renamed the story. Currently the workload namespaces are annotated (so they are part of the mesh) but the app pods don't get a sidecar because of the above issue. We want them to be part of the mesh because:

Traefik will send the requests unencrypted to the apps (because TLS is terminated on Traefik so the request is flying unencrypted from there on)
Minibroker service (or generally services running inside the cluster) are (or may be) part of the mesh. When the application is talking to the service, the traffic should be encrypted.

Since we get the default service account of the namespace by default, automountServiceAccountToken: true should not be too bad?

I'm trying to find proof that the default service account doesn't get any permissions. I only found this: https://stackoverflow.com/questions/52995962/kubernetes-namespace-default-service-account
but I'm looking for some official docs instead. Otherwise it's the code... :D

I still see this in the events of the application pods:
Normal  InjectionSkipped   2m26s (x4 over 95m)  linkerd-proxy-injector  Linkerd sidecar proxy injection skipped: automountServiceAccountToken set to "false"                                                                             │

(and no sidecar exists)


pure prop passed to a redux form at runtime not working.

The documentation states:

IMPORTANT: All of these configuration options may be passed into reduxForm() at "design time" or passed in as props to your component at runtime.

However, the shouldComponentUpdate method of Form (line 241 in reduxForm.js in version 6.5.0)
reads: if (!config.pure) return true;, completely ignoring the pure prop.

Feel free to send us a PR to either fix this sentence in the docs or to fix the behavior of the code.

I believe fixing the code is best

Sorry, inadvertent click...

Fix published in v6.6.0.


Allow Post to trust a provided CA on requests to OIDC token endpoint

[Fixes #54]

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Changdrew
To complete the pull request process, please assign liminw
You can assign the PR to them by writing /assign @liminw in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/assign @cfryanr @tylerschultz @andrewedstrom

/lgtm


Scroll to previous selected images

Scenario:
A user selects a couple of images from a couple of weeks ago (he has to scroll a while to find 'em).
After he clicks Done he wants to add another image from the same time and opens the image picker again.
Actual State:
The image picker shows the latest pictures (scrollOffsetY == 0)
Target State:
The image picker scrolls to the youngest image of defaultSelectedAssets

@LucidityDesign Did you able to set your Target State ?

I think the problem was that I initialized a new instance instead of re-using the old one. But I'm not sure anymore.

There is currently no way to scroll to a specific asset in a new instance. Do you have any ideas?

Just use the old instance :)


max value error in console

If i try to raise the value of the slider above the max value i get an error in the console. as intended.
However, if i dynamicly change the max level before i increase the value of the slider i still get the message:
"vue-slider.tsx:538 [VueSlider error]: The "value" must be less than or equal to the "max".
Everything works fine. i can increase the max value and also increase the slider value to follow the max value. its just that the error should not apear in console.
this hapens both in vue 2 and vue 3 using respectivie slider packages

duplicate https://github.com/NightCatSama/vue-slider-component/issues/343


[Earthdawn (FASA Official)] Fixed result style menu enum map

Selecting 'Vague Success (not recommended)' now returns 1
Selecting 'Full' now returns 0

If this is going to take more than 2 minutes to merge, don’t bother; it’s a super minor fix, and will be fixed soon with a larger update anyway.


Release 1.12.0

Due: February 10th, 2020
Check this query for all issues.

:tada: This PR is included in version 1.13.0 :tada:
The release is available on:

npm package (@latest dist-tag)
Visual Studio Marketplace
GitHub release

Your semantic-release bot :package::rocket:


Explore DVC with Minio for versioning

Look at the possibility of leveraging DVC instead of Pachyderm as it would help having all the versioning under the data product repo.
Good article showing end to end setup and use:
https://rachidbenouini.medium.com/data-version-control-from-zero-to-one-fcea7a1c48b3

Completed with pull request


WIP: Add ur5 ignition demo

Add a demo featuring UR5 and Ignition Gazebo. Documentation on the way

@davetcoleman it ended up being in a separate repo: https://github.com/UniversalRobots/Universal_Robots_ROS2_Gazebo_Simulation


[docs] Accelerator API

Related to #2456. This PR:
➖  removes redundant content already covered in the Quicktour or tutorials from the Accelerator API page, making finding a specific method or function in the API easier.
➕ adds docstrings for GradientAccumulationPlugin because they're currently hidden in the metadata help field.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.


Add .gitignore

Hi. Hope it's fine I send some PRs. I use traceflow and would like to help make a few small improvements.
This one simply adds a .gitignore to hide some build files, which should be obvious.

Of course it's ok! Thank you very much for the PR!


The link for the pretrained weight is not working

Hello.
Thank you for sharing great work with community.
I tried to download pre-trained weight but I got time-out error.
So, I tried to visit your lab website but it is also not working.
Would you please check this issue?
Thank you.
Best,
CK

Hi,
You are right, sorry for that.
In the meantime - please downlowd the checkpoimt from here.
Thanks for letting us know.


Add CGManifest Entry with CVE to Test it

Test PR to verify CGManifest is functioning correctly.

API change check
API changes are not detected in this pull request.

Closing as CGManifest with CVE was correctly detected:


Enable audible notifications

Fixes #8
Why not just use the audio notification already build into node-notify?

I did see that option, but couldn't decipher what the doc about it meant:
sound: true, // Only Notification Center or Windows Toasters

but at least we get some sounds for some people. right? that's what it means?

I think it translates to: "This works on OS X and on Windows 8"
It leaves Linux and earlier Windows out in the cold, which sucks. So we should ideally come up with a solution that works on all target platforms.
I think that makes more sense as a PR for node-notify, though, rather than adding the functionality to yakyak.

+1. go for it.


nginx relative root problem

I'm using NGINX with jingo. First I defined a server block:
server {
    listen 8080;
    server_name wiki;
    location / {
        proxy_pass http://<IP_ADDRESS>:6067/;
    }
}

Now if I browse to http://<server domain>:8080 everything works fine. I'd like to move this to http://<server domain>/wiki, however. But when I do this:
server {
    listen 80;
    server_name <server name>
    ...
    location /wiki {
        proxy_pass http://localhost:6067/;
    }
}

All of the urls in the jingo page are relative to the server root, and so no css/js files are loaded. Additionally it defaults to http://<server domain>/wiki/Home instead of http://<server domain>/wiki/wiki/Home.
Is there a way around this?
Thanks

I suppose we can safely assume serving Jingo from non-root URL fragment is just not supported. One way for Jingo to be aware of such setups and be able to render different URLS could be an environment variable. This would be in accordance with http://12factor.net.
Also I remember fiddling around with some baseUrl variable once, too.
On the other side, seperating different applications by subdomains is not only helpful regarding CSRF or XSS attacks. I propose not to support this scenario.

It'd probably enough to make Jingo aware of being served ("mounted") in a subdirectory, the way WordPress does with WP_SITEURL configuration variable. As @almereyda mentioned, I am not really sure about all the consequences (WP introduced that option only from version 2.2), so I am not thinking to implement it right now. It should be easy to hack something in your local setup though.

I propose to close this issue. nginx supports rewrite rules for proxy_pass. See https://raymii.org/s/tutorials/NGINX_proxy_folder_to_different_root.html for details.

I re-tried using rewrite rules:
location /wiki/ {
    rewrite ^/wiki(/.*)$ $1 break;
    proxy_pass http://<IP_ADDRESS>:6067/;
    proxy_set_header Host $host;
    proxy_set_header X-Real-IP $remote_addr;
    proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
    proxy_redirect off;
}

The wiki pages are served correctly as far as I can tell, but the resources still fail to load (*.css, *.js, etc.). I guess this makes sense... I don't think there's a way to do this from NGINX.
I have another idea: could you add a config variable to specify the location of static files? A lot of other frameworks do this (e.g. Django).

Closed in favor of #124


cloudera is not an easy application

Cloudera should be removed from this repository because their application form is long and because the tos are unfriendly to job seekers.
Cloudera's application is long.  It is  a multi-step form that requires the applicant to manually fill in data about previous employers and school background.
Cloudera's tos are unfriendly to job seekers.  Cloudera's tos include an NDA, which job seekers must agree to before submitting their application.  The application obfuscates the fact that applicants are submitting to an NDA in two ways.  First, the next button scrolls down automatically so the applicant does not see NDA in the title "Cloudera Employment Application and NDA".  Second, the application combines this NDA as part of another form possibly making it unclear to applicants that they are submitting to an NDA.

@121onto Thanks for opening up this issue! I definitely want to make sure every company on this list is easy to apply to and provides a great experience for job-seekers and I really appreciate that you're helping with that!
Could you please attach some screenshots of the page(s) where you have to manually fill in information? I want to make sure I always have good documentation as to why a company is being removed to keep things fair.

Ping @121onto

@121onto @j-delaney
following @121onto  issue I tried to apply to cloudera and it was really simple.
More simpler than others I have seen. You just have to read the NDA, accept and
then you go to a form where you fill in your name, place, email.
The resume and the cover letter also comes in different formats.
You can copy and paste, select from a cloud or upload from you computer.
Even though I have not gotten any response as to the status of my application, I
think it is very easy to apply to Cloudera.
Hope this helps

I was unable to replicate my initial experience.  The application looks different from what I remember.  Hard to say what happened there.  Closing the issue for now.


Spawning an inspector in a new window uses a naive print string

Inspect:
String
	streamContents: [ :s |
		1
			to: 200000
			do: [ :each |
				s
					nextPutAll: each asString;
					cr ] ].

Then spawn in a new window
==> crash

https://user-images.githubusercontent.com/249595/216392219-6ecd2d19-8f57-4172-8a1a-50333e559d71.mp4


Applied formatting and punctuation cleanup to code comments

This work completes the changes started in #683.  The fork underlying #683 was deleted, so the patch from the original pr was applied to a fork of the project's current master.  PR #683 has been closed with a reference to this work which includes all code review comments previously made.

Thank you @WilliamBerryiii for these fixes.


fix: NODE_LOADER_CONFIG for absolute paths

When specifying an absolute system path for NODE_LOADER_CONFIG, this change allows that path to be used, instead of joining it with process.cwd().
Tests ✅ after this change.

Ah this added a package-lock.json file, which it should not have. I will remove that in a subsequent commit.

I fixed the issues with the lock files, among a couple other small maintenance things, in #3. Everything's released in https://github.com/node-loader/node-loader-core/releases/tag/v1.0.4

Thanks so much for the speedy release! Also, I appreciate your great work on this and your other import maps packages.
In case it's of interest, I'm using this and @node-loader/import-maps in https://github.com/johnloy/static-shadow-dom. I hope to be publishing within a few days, and will be sure to give you a README thanks there once I do.
If you'd like, I could also contribute a test for the env variable?
Cheers!

Great to hear you are using this project in static-shadow-dom. Yes, if you'd like to add a test for the NODE_LOADER_CONFIG env variable that would be great.


Nis br method review

I've changed some reviews like orientation by @Arkni.
I've removed some spaces then I've chanced creation of date the new method nisBr.
Thank you!

@csmendonca,
By the way, you don't need to close a PR and create a new one with the new changes everytime a maintainer requested something. You can just do the changes and push your commit and they will be visible on the PR.
I recommend watching this ~38 minutes lessons from Kent C. Dodds, they are the best getting started on contributing to Open Source on GitHub: https://egghead.io/courses/how-to-contribute-to-an-open-source-project-on-github
And, thank you again for your contribution :)

Hi @Arkni,
Sorry about that, it's happing because that was my first contribution to Open Source on GitHub.
Thank you so much, I'll watch that video which you recommended.

Ah ok. I didn't pay attention.
Congratulation on your first contribution and Good luck :)

Hi @Arkni,
Thank you :)


NBT tag

While a gui is an indispensable element to make CT useful and efficient and you are contributing greatly to the community making this mod, I am sorely missing the ability to add nbt tags to the output of recipes. This capability is very important and if only it could be put into regular crafting table crafting it would be tremendously useful.

You can already do this, you just need to have the Item with NBT in your hotbar and drag it into the output slot.
In 1.20.4 some mods like Mekanism use data attachments for items which crafttweaker itself doesn't support, so maybe that is actually the problem you have.


Restored docs page on roles in security, executed other touchups, and…

… renamed docs readme.txt to readme.md
SUMMARY
Main change was restoring & tidying up the Roles / Security page.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN
Fire up docs:

cd docs/
npm install
npm run start

navigate to localhost:8000`

Test /docs/security page

ADDITIONAL INFORMATION
No change to Superset (just docs!)

Codecov Report

Merging #11978 (b27b32f) into master (2b9695c) will decrease coverage by 13.81%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master   #11978       +/-   ##
===========================================
- Coverage   67.70%   53.88%   -13.82%
===========================================
  Files         938      431      -507
  Lines       45437    15194    -30243
  Branches     4358     3885      -473
===========================================
- Hits        30761     8188    -22573
+ Misses      14573     7006     -7567
+ Partials      103        0      -103

Flag
Coverage Δ

cypress
53.88% <ø> (-1.12%)
:arrow_down:

javascript
?

python
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...uperset-frontend/src/dashboard/util/dnd-reorder.js
0.00% <0.00%> (-100.00%)
:arrow_down:

...rset-frontend/src/dashboard/util/getEmptyLayout.js
0.00% <0.00%> (-100.00%)
:arrow_down:

...dashboard/components/resizable/ResizableHandle.jsx
0.00% <0.00%> (-100.00%)
:arrow_down:

.../src/dashboard/util/getFilterScopeFromNodesTree.js
0.00% <0.00%> (-93.48%)
:arrow_down:

...src/dashboard/components/gridComponents/Header.jsx
10.52% <0.00%> (-86.85%)
:arrow_down:

...rc/dashboard/components/gridComponents/Divider.jsx
13.33% <0.00%> (-86.67%)
:arrow_down:

...ontend/src/dashboard/util/getDashboardFilterKey.ts
14.28% <0.00%> (-85.72%)
:arrow_down:

...nd/src/views/CRUD/data/query/QueryPreviewModal.tsx
14.70% <0.00%> (-82.97%)
:arrow_down:

...set-frontend/src/views/CRUD/welcome/EmptyState.tsx
5.71% <0.00%> (-82.10%)
:arrow_down:

...et-frontend/src/SqlLab/components/TableElement.jsx
4.70% <0.00%> (-81.35%)
:arrow_down:

... and 789 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b9695c...b27b32f. Read the comment docs.


Should Java Post4.repl() support  SETJMP()?

Should the Post4.repl() setup a SETJMP() signal handler similar to the one in the Post4 CLI.
https://github.com/SirWumpus/post4/blob/d00e59c33d0ed606c245be5996721965ded8d7e7/src/post4.c#L3232-L3235
Java probably has its own signal handlers for SIGSEGV, SIGFPE, SIGBUS, in which case the Java handler should be saved and restored on return.
https://github.com/SirWumpus/post4/blob/d00e59c33d0ed606c245be5996721965ded8d7e7/jni/Post4.c#L124-L130
Should there be a boolean flag to denote this a primary interpreter, when not primary skip SETJMP();  maybe overloaded methods: Post4.repl() Post4.repl(Boolean).

#18 commit ea84e335553fdf7c6700e162ad826d56ab93e639 separate context errors from process signals.

Now SIGINT and others should work.  At some future date the signals will probably have to be revisited in order to deal with multiple interpreters running in separate threads.


Analyze prebuilts for Tools

The following prebuilt packages are included as dependencies in source-build by Tools.  These need to be analyzed to determine how to avoid requiring packages that source-build doesn’t build.

Change to use the source-built version
Package is not critical to product and can be removed.  (i.e.test-specific, windows-specific, etc)
The package is used as reference only
The package should be built in source-build
Other – please elaborate on what you think should be done.

For more detailed usage information for these, please see the Usage Exploration tab of the SourceBuildPrebuiltReport.
All package dependencies are BuildTools dependencies and should be removed when BuildTools is removed.
Prebuilt Status Updated 2019-06-24
Up to date prebuilt status can now be found in the SourceBuildPrebuiltReport in the Repo Status Data tab.
Prebuilt Table Updated 2019-05-07

PackageName
PackageVersion
SourceBuiltVersion
Category

Microsoft.Cci
4.0.0-rc3-24214-00

Microsoft.Net.Compilers.Toolset
3.1.0-beta2-19206-01
3.1.0-beta2-19067-14

Microsoft.Net.Compilers.netcore
2.6.0-beta3-62316-02

Newtonsoft.Json
10.0.3

Original Prebuilt Table

PackageName
PackageVersion
SourceBuiltVersion
Category

Microsoft.Cci
4.0.0-rc3-24214-00

BuildTools

Microsoft.NETCore.Compilers
2.9.0
3.0.0-beta3-19067-14
BuildTools

Microsoft.Net.Compilers.netcore
2.6.0-beta3-62316-02

BuildTools

Newtonsoft.Json
10.0.3
9.0.1
BuildTools

System.Diagnostics.FileVersionInfo
4.3.0

BuildTools

System.Diagnostics.TraceSource
4.3.0

BuildTools

System.IO.FileSystem
4.3.0

BuildTools

All prebuilts removed.


Shade protobuf-java dependency

Other dependencies (in our case Kinesis-client) depend on a specific version of protobuf-java, which we can't change. It'd be great if we can provide a shade version for the generated code and a shaded ScalaPB-runtime which uses a shaded version of protobuf-java.

Is this something you can do within your own build? We do something similar for SparkSQL and we shade our fat jar like this http://trueaccord.github.io/ScalaPB/sparksql.html

As we don't use Sbt, another way of doing this in ScalaPbc as an option would be great.

The shading step should be performed at the application's site when building a fat jar - not by individual library publisher. The reason is that anything that depends on ScalaPB (including software we have no control over) would have to be shaded in order to work with the shaded version.


New Underlined variant

@crdo @baradam05 I guess we do not want to merge this into master but rather v4?

@crdo @baradam05 In Bootstrap the variant name is nav-underline not nav-underlined
=> correct CSS class has to be used
=> I will align the enum member name with Bootstrap to NavVariant.Underline (although Underlined sounds more natural for me).


Optimize/profile cypher - (Part 2)

Created by: Bohumil Pospíšil Nov 08 2021 at 18:27 CET
Updated: Jul 18 2022 at 15:33 CET
ClickUp ID: IK-1765
Assigned in ClickUp to: Bohumil Pospíšil
From @laszlo.hordos via Slack message
The trace is split into two,
1: “transaction” - The time it takes to connect/get 1 connection from pool of 100 and reach the point in neo4j Driver to be able send the first Cypher query and close and relaase the connection back to the pull. So overall the all operation.
2: “cypher.run” - The time is takes to execute that cypher inside the transaction and get the response.
In step 1 we can fine-tune the pool size the connection timeout, etc to gain more performance. The health check uses this so usually it takes always 15s to get any response +/- and takes to - -  to report unhealthy so the system could restart. To decrease the 15s wait time the timeout has to be decreased.
In step 2 where Marek and Bohumil could profile the cypher and optimise more if possible before we look into increase the DB resources.
This trace means it took so long time to get a connection from pool. Maybe increase the pool size will (but where is the limit to how many connection we can open from one instance) could decrease that time. If you see long time after the run and transaction finish that’s where we are not releasing the connection fast enough.
Analyses
Trace list – Trace – JARVIS Development – Google Cloud Platform
Trace ID 001662cfbc0350c1e9a90a9bbc62752b
TransactionExecutionLimit: Timeout after 2 attempts, last error: ConnectivityError: Timeout while waiting for connection to any of [[neo4j-test.indykite.com:443]]: context deadline exceeded
Trace ID 0014f591721bab5957c62f6cab686354
insufficient permission to perform requested action: Customer.UPDATE
Attachment(s):
https://github.com/indykite/clickup-attachments/blob/master/83294175-dc8b-41ba-85d0-738856786343.png
https://github.com/indykite/clickup-attachments/blob/master/bf1791d4-abae-413a-8e7e-a8ef95b1ea5c.png

Commented by: @bayegan Nov 03 2021 at 22:54 CET
from @maprokes : might you need access to the neo4j-node you can use  kubectl exec --stdin --tty neo4j-neo4j-core-1 -- /bin/bash  core-1 is the LEAD for the noe4j db, logs and db files are at  /data/log/  and  /data/databases/

Commented by: @Bohumil Pospíšil Jan 04 2022 at 09:58 CET
@bayegan on the database side we (@yetizer and me) did some investigation in the task 1umw743 and we did't find a problem on the database side:
Marek in his comment mentioned @bakkelim (Marius B is going to look at in the atlas service) and I don't know if there is any progress.
@bakkelim please have you any info?
Attachment(s):
https://github.com/indykite/clickup-attachments/blob/master/83294175-dc8b-41ba-85d0-738856786343.png


API rate limit is reached when migrating from the cloud to onPrem

When migrating from the cloud to an onPrem store, the rate limit of the cloud is reached, and it then rejects the requests for 5 minutes.
As a result, the migration is aborted.

[public] Shopware automated response: This issue is linked to the internal issue: MIG-1030
[created from MIG-1030, comment 514447]


my ad block dose not block any thing

🔍 Is there already an issue for your problem?

[X] I have checked older issues, open and closed

ℹ Environment / Computer Info
- Spotify version:
- Spicetify version:2.22.1

📝 Description
.
📸 Screenshots
.

Not an issue with the marketplace, go to the extension's repo CharlieS1103/spicetify-extensions

Not a Marketplace issue


ginaudit: Set Audit ID prior to calling next handler and add to context

This proposes we generate the audit id prior to passing control to the next handler in the audit middleware and adding the audit id to the context.  This allows downstream systems (NATS events, etc) to attach those IDs when they write audit logs.  I also added a new func to generate the audit event so we don't break backwards compatibility for folks already using the library.

Codecov Report

Merging #98 (2900bbe) into main (17e5229) will decrease coverage by 3.48%.
The diff coverage is 29.41%.

@@            Coverage Diff             @@
##             main      #98      +/-   ##
==========================================
- Coverage   96.81%   93.33%   -3.49%
==========================================
  Files           9        9
  Lines         314      330      +16
==========================================
+ Hits          304      308       +4
- Misses          7       19      +12
  Partials        3        3

Flag
Coverage Δ

unittests
93.33% <29.41%> (-3.49%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

auditevent.go
63.63% <0.00%> (-36.37%)
:arrow_down:

ginaudit/mdw.go
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Also, I suggest squashing the commits.


added support for multiple-compose files

Fix #275
$ kompose -f docker-compose.yml,docker-guestbook.yml convert
INFO[0000] file "redis-master-service.json" created
INFO[0000] file "redis-slave-service.json" created
INFO[0000] file "redis-service.json" created
INFO[0000] file "web-service.json" created
INFO[0000] file "frontend-service.json" created
INFO[0000] file "redis-master-deployment.json" created
INFO[0000] file "redis-slave-deployment.json" created
INFO[0000] file "redis-deployment.json" created
INFO[0000] file "web-deployment.json" created
INFO[0000] file "frontend-deployment.json" created

cc @kadel @surajssd

I'm not sure if comma separated list is right here :-(
With docker-compose it looks like this - docker-compose -f docker-compose.yml -f docker-guestbook.yml up
I think that we should do it in the same way as docker-compose does it.
@cdrage how would this work with https://github.com/kubernetes-incubator/kompose/pull/304 ?
Comma separated or multiple -f arguments?

@kadel would be easy to implement via #304 once it's merged. But yes, multiple -f arguments would work with it.

Lets wait for #304. Thank we can revisit this.

Coverage increased (+0.03%) to 45.768% when pulling 68a3361392bef6b2e22379d21e13772222bfa752 on procrypt:multiple_files into 0370d66357ca3198f492457355b093356ba7d522 on kubernetes-incubator:master.

@procrypt unit tests, docs needed as well!
Also I thought we are trying to implement this the docker-compose cli way which is
docker-compose -f foo.yml -f bar.yml up

as opposed to
docker-compose -f foo.yml,bar.yml up

Coverage increased (+1.8%) to 48.38% when pulling 1ff9136107495e1e8ee7e7eb90c0d249c26bca56 on procrypt:multiple_files into 9c3fdaa48d5e871ab83a3cad95b27fb13dc1f98c on kubernetes-incubator:master.

Coverage increased (+1.8%) to 48.38% when pulling 1ff9136107495e1e8ee7e7eb90c0d249c26bca56 on procrypt:multiple_files into 9c3fdaa48d5e871ab83a3cad95b27fb13dc1f98c on kubernetes-incubator:master.

@surajssd @containscafeine I have updated the PR. Please review
$ kompose -f docker-compose.yml -f docker-guestbook.yml convert
INFO[0000] file "frontend-service.json" created
INFO[0000] file "mlbparks-service.json" created
INFO[0000] file "mongodb-service.json" created
INFO[0000] file "redis-master-service.json" created
INFO[0000] file "redis-slave-service.json" created
INFO[0000] file "frontend-deployment.json" created
INFO[0000] file "mlbparks-deployment.json" created
INFO[0000] file "mongodb-deployment.json" created
INFO[0000] file "mongodb-claim0-persistentvolumeclaim.json" created
INFO[0000] file "redis-master-deployment.json" created
INFO[0000] file "redis-slave-deployment.json" created

$ kompose -f docker-compose.yml -f docker-guestbook.yml convert
INFO[0000] file "mlbparks-service.json" created
INFO[0000] file "frontend-service.json" created
INFO[0000] file "mongodb-service.json" created
INFO[0000] file "redis-master-service.json" created
INFO[0000] file "redis-slave-service.json" created
INFO[0000] file "frontend-deployment.json" created
INFO[0000] file "mlbparks-deployment.json" created
INFO[0000] file "mongodb-deployment.json" created
INFO[0000] file "mongodb-claim0-persistentvolumeclaim.json" created
INFO[0000] file "redis-master-deployment.json" created
INFO[0000] file "redis-slave-deployment.json" created

The test are failing for this particular feature because the artifacts created are not in any particular order. When we run the kompose convert command sometimes mlbparks-service.json will be crated first and sometimes frontend-service.jsonand this makes it difficult to match the output in the tests for this feature. We need to think of a different testing strategy to test this rather than matching the output.

Coverage increased (+1.8%) to 48.38% when pulling f91837ecd936fd660317648832c2333cf568c998 on procrypt:multiple_files into 9c3fdaa48d5e871ab83a3cad95b27fb13dc1f98c on kubernetes-incubator:master.

@procrypt even if the order is upside down, it should not cause any problems, because that is what happens for other conversion also, the order may not be same and still jq does the matching.

Coverage increased (+1.8%) to 48.38% when pulling 04a281106550437aedd202a1c6a74f3313feaf7c on procrypt:multiple_files into 9c3fdaa48d5e871ab83a3cad95b27fb13dc1f98c on kubernetes-incubator:master.

Coverage increased (+1.8%) to 48.38% when pulling 8e7bb176b548f6437812fe6121b36d016bb27d70 on procrypt:multiple_files into 9c3fdaa48d5e871ab83a3cad95b27fb13dc1f98c on kubernetes-incubator:master.

Coverage increased (+1.8%) to 48.38% when pulling 8e7bb176b548f6437812fe6121b36d016bb27d70 on procrypt:multiple_files into 9c3fdaa48d5e871ab83a3cad95b27fb13dc1f98c on kubernetes-incubator:master.

Coverage increased (+1.8%) to 48.38% when pulling 07fbe013802a6007afbfd552f0f14572105d9d1f on procrypt:multiple_files into 9c3fdaa48d5e871ab83a3cad95b27fb13dc1f98c on kubernetes-incubator:master.

Coverage increased (+0.03%) to 46.617% when pulling 8ea7c9728d268117b0c2bf8226334a291979550d on procrypt:multiple_files into 9c3fdaa48d5e871ab83a3cad95b27fb13dc1f98c on kubernetes-incubator:master.

Coverage increased (+0.03%) to 46.617% when pulling 8ea7c9728d268117b0c2bf8226334a291979550d on procrypt:multiple_files into 9c3fdaa48d5e871ab83a3cad95b27fb13dc1f98c on kubernetes-incubator:master.

@procrypt one last bit, add info about this awesome fetaure to docs! Rest LGTM

@surajssd Thanks I'll update the docs.

Coverage increased (+0.03%) to 46.617% when pulling e8af6f15cdebbe517ee67c0cc2a3bb87329a4ca0 on procrypt:multiple_files into 9c3fdaa48d5e871ab83a3cad95b27fb13dc1f98c on kubernetes-incubator:master.

Coverage increased (+0.03%) to 46.617% when pulling de2b448b2f8346c0f7ed5c916b763079f2a9f89c on procrypt:multiple_files into 9c3fdaa48d5e871ab83a3cad95b27fb13dc1f98c on kubernetes-incubator:master.

Coverage increased (+0.03%) to 46.617% when pulling a5a3805760737f52c363635257c1ee991be8ce70 on procrypt:multiple_files into 9c3fdaa48d5e871ab83a3cad95b27fb13dc1f98c on kubernetes-incubator:master.

@procrypt thanks for awesome work, code + tests + docs :+1: :tada:

@surajssd Thank you all your help 😄


Trigger on typing

I have set trigger: '@', Is it possible to trigger it after typing each character?

setting keepTrigger: true


Usage with ember-cli-deploy-gzip might be confusing

Just writing it here, as it bit me: When trying to use this with ember-cli-deploy-gzip, it will not include any .html and image files (.png, .gif, .jpg), as those are by default not processed by ember-cli-deploy-gzip.
This led to all the images not being uploaded for me (as well as the index.html). I removed ember-cli-deploy-gzip - maybe it would make sense to note this in the readme?

Oh, thank you for heads up. Probably the behavior of -gzip changed. I'll provide a fix soon, so it would merge gzipped content with regular content.

Great!
By the way, I'm using this on a Windows machine, and it is working perfectly when used in Git Bash.

I assume it's posix? If yes, it's not really relevant, cause I was wondering about path generation under Windows.

In the regular cmd, I get this error:
Error: Unexpected disconnection from agent
Error: Unexpected disconnection from agent
    at PageantSock.onclose (C:\...\node_modules\ssh2\lib\agent.js:179:10)
    at Object.onceWrapper (events.js:316:30)
    at emitOne (events.js:115:13)
    at PageantSock.emit (events.js:210:7)
    at ChildProcess.<anonymous> (C:\...\node_modules\ssh2\lib\agent.js:398:12)
    at Object.onceWrapper (events.js:318:30)
    at emitTwo (events.js:125:13)
    at ChildProcess.emit (events.js:213:7)
    at maybeClose (internal/child_process.js:927:16)
Pipeline aborted

(with agent='pageant' - the same config that works in Git Bash).

Yeah, need to install windows and try. If you can figure out what's wrong with ssh2 when called under cmd, PR will be appreciated. I guess some tweaks to connection params needed.


Igor8282 patch 1

Hi Igor. Thank you so much for your contribution. Could you help clarify the intended goal of these additions by updating the description of this Pull request?


Avoid running publish-go-tester-task if tag is set

publish-go-tester-task runs when a tag is pushed. Since the tag has priority when version is defined, the workflow fails because it does not find any build named test-XXX-git-snapshot when calculating the checksums. It recently happened here: https://github.com/arduino/arduino-cli/actions/runs/3480562942/jobs/5820576240#step:3:16
To fix this issue, during run-determination, the presence of a tag is checked comparing github.ref with TAG_REGEX. If there is a match, the other jobs are skipped, preventing the workflow from failing at later stages.

@MatteoPologruto I see the merge is blocked because the required spellcheck workflow job run didn't trigger on the last push. I have no idea why it didn't run. It is likely just a transient glitch in GitHub Actions.
Please let me know if you are ready to merge this and I'll take care of overriding the requirement and  merging it (you have the permissions to do it also, but I already am familiar with what needs to be done so it will be most efficient for me to take care of it in this case).

Hi @per1234, I'm ready to merge. I could also try to re-trigger a spellcheck workflow run by force pushing the same commit.


Translate between EGraph types

Addresses issue #305.
I use some pretty complicated trait bounds in the EGraph::map function to handle converting between analyses. If the analysis stays the same (EGraph<L, T> -> EGraph<L2, T>) these are automatically implemented which makes it more convenient to use in what I imagine is the common case. However, let me know if you think the conversion should be explicitly handled with a passed in closure.

Here's an alternative idea that might ease some of the trait bounds, and it would make things a little more flexbile than requiring From. Make LangMapper a trait or something:
trait LangMapper<L, A> {
  type L2: Language;
  type A2: Analysis<Self::L2>;
  fn map_node(&self, node: L) -> Self::L2;
  fn map_analysis(&self, ...)  {
    // should maybe be able to provide a default impl?
  }
  fn map_egraph(&self, egraph: EGraph<L, A>) -> EGraph<L2, A2>
}

If you wanted to go crazy, those methods could all take in the src and dst egraphs? What do you think?

I liked that idea and implemented it. I couldn't figure out a nice way to provide default implementations in the LanguageMapper trait, so I wrote a SimpleLanguageMapper struct that provides a LanguageMapper implementation when there are the necessary From<..> impls. Those type constraints are still pretty gnarly, but they aren't on the default interface. Let me know what you think of that.

Looks good to me! Thanks for the contribution. Seems like some doctests are failing. Could you patch that up? Try cargo test --doc. Btw make test does everything the CI does.

Okay, should be good to go

Thanks for the contribution!


Grammar updates per the Spec review suggestions

https://github.com/UAVCAN/specification/pull/46/files/fffe93b4a9dc1f3cd08a8687eabcb3caa28b5e95#diff-bb96d7d7b8581e33b30e1601337eb450

Pull Request Test Coverage Report for Build 219

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 194:
0.0%

Covered Lines:
2480

Relevant Lines:
2480

💛  - Coveralls


Add files_and_groups generator

@MobileNativeFoundation/rules_xcodeproj-maintainers This isn't done yet, but the shell of it is in place. It's already pretty big as well, so I would love if I could get some eyes on it starting now, as feedback can impact how I finish fleshing out the rest of the generator.
https://github.com/MobileNativeFoundation/rules_xcodeproj/blob/3b2bc683358b924e9dfc70f85ca9341efa167ff2/tools/generators/legacy/src/Generator/CreateFilesAndGroups.swift is where the logic is mostly being sourced from, in case you want to compare to what we are currently doing. Some renames: FilePath -> BazelPath, FileTreeNode -> PathTreeNode.


Wpfui.common's icons display abnormal

Description:
I try to add a notifyicon by using Titlebar's property. I write them correctly, but when I execute it, the bug appears. The icon in the ContextMenu cannot display itself well. I also try to rebuild my cache, but in vain.
Reproduce :
I just use this in xaml :
<MenuItem                         Header="Setting"                         Tag="Setting"                         Icon="{x:Static wpfuiCommon:Icon.Settings24}"                         Click="MenuItem_Click"/>
It seems absolutely right ,but the icon doesn't work.
Here is my enviorment:

OS: Windows 11
.NET: net6.0
Version: 1.2.2


Create Self Hosted Runners

We want to be able to have more control over the runners of github actions and it would be nice if we had our own preconfigured self hosted runners. Add them and set them up with access to the repo.

Was able to explore this but moving forward without this since it is so much simplier this way until we need to have a specific self hosted runner for testing mobile apps.


Feature: Don't save values that haven't been modified.

As the title says, for the sake of reliability, it may be a good idea to only save values that were directly modified so as to minimize the risk of issues cropping up.

Good idea! I'll get on that when I have time.


[MINOR][DOCS][3.0] Fix fabric8 version in documentation

What changes were proposed in this pull request?

Fix fabric8 version in doc
Why are the changes needed?

correct doc
Does this PR introduce any user-facing change?

no
How was this patch tested?

Nah

Test build #118576 has started for PR 27606 at commit 2ac7559.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23330/
Test PASSed.

Test build #118577 has started for PR 27606 at commit f8387fa.

Why is it a hotfix?

Test build #118576 has finished for PR 27606 at commit 2ac7559.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118576/
Test PASSed.

Test build #118577 has finished for PR 27606 at commit f8387fa.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118577/
Test PASSed.

If/when https://github.com/apache/spark/pull/27605 is merged, it can easily be backported. This isn't necessary.


Start with "what is Azure AD Conditional Access Policy"

Recommend that you start with "what is ..." and then move into the scenarios.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ffdaa549-8f3b-75e0-9d27-a1a10417d86b
Version Independent ID: aff533db-3ac6-5f9a-0134-812f7d488670
Content: Azure Active Directory conditional access
Content Source: articles/active-directory/active-directory-conditional-access-azure-portal.md
Service: active-directory
GitHub Login: @MarkusVi
Microsoft Alias: markvi

@TomShinder Thanks for your feedback! I find the flow of the document fine. The start of the document does introduce what Azure AD Conditional Access Policy is. And then common scenario helps with what Conditional Access Policy could help resolve. Then it helps with more details on how implementation works and how to interpret Conditional Access Policy.

@TomShinder We will now proceed to close this thread. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.


Reduce overhead in conn_pool_map by fixing alignment

Commit Message: Reduce overhead in conn_pool_map by fixing alignment
Additional Description: Moves many of the smaller members of the class to the end to save small amounts of memory
Risk Level: Low

/retest

/assign-from @envoyproxy/senior-maintainers