Naming inline modules

I was referred here to discuss this.  Apologies if I'm going about it wrong.  :)
The idea is to allow inline modules to be cached within the loader just like any other module by giving <module> a name attribute.
Suppose you have some inline module within HTML like so:
<!DOCTYPE html>
<html>
  <head>
    <meta http-equiv='Content-type' content='text/html; charset=utf-8'>
    <title>Example</title>
  </head>
  <body>
    <module name="main">

        import App from 'some/dynamic/location';
        var ImmediateBlob = {"maybe": "some JSON stringified by server upon request"};

        App.doSomething();
        export { App, ImmediateBlob };

    </module>
    <script src="some/static/script.js"></script>
  </body>
</html>

And some/static/script.js might look for the main module:
import main from 'main';

main.App.looksLikeADuck();

if (main.ImmediateBlob.quacks == 'like a duck') {
    console.log('It is a duck!');
}

Two other relevant discussions:
https://github.com/ModuleLoader/es6-module-loader/pull/343
https://github.com/jorendorff/js-loaders/issues/83#issuecomment-33991024

This would not be possible under the current spec due to there not being a concept of module names any more.  Everything is keyed by url so virtual modules are an awkward fit now (hopefully this decision will be reconsidered, read #28). Add this to the pile of benefits of module ids over urls.
Also, neither System.define nor System.module have counterparts in the current spec.

Surely it makes the most sense, as @dherman pointed out at https://github.com/jorendorff/js-loaders/issues/83#issuecomment-33991024, to do the following:

Associate inline modules without a name attribute with System.module.
Associate inline modules with a name attribute with System.define, but only if a path is not set for that name.  (This should have the added advantage of showing up within the sources panel as something other than <Anonymous Module>.)
For any modules with a src, use the address-normalized path as usual.  And for any modules with a name, use the name-normalized path as long as it does not yet exist.  It should also be possible to have both the name and the src paths.

I can't imagine any conflicts occurring with this system.

@matthewp that's not accurate, you can have any arbitrary entry in the registry.
Loader.install() will allow you to define new entries in the registry: https://whatwg.github.io/loader/#reflect-loader-install
The normalization process (to a final url), including the sites() configuration will happen if there is no entry available in the registry for arbitrary values in the module specifier.

@caridy Interesting, install() doesn't specify a return value, this means it could be a Promise.  This differs from the old System.set / System.get.

@timbur This spec is quite a bit different from the one referenced in that thread, we need a Loader.define and Loader.module first.  I'm not sure what the authors' opinion is on .define, I remember there was some problems with the old version.  .module will almost definitely be needed to support <module>.  Maybe a separate issue to track that?

In my opinion, https://github.com/ModuleLoader/es6-module-loader and https://github.com/systemjs/systemjs is handling everything perfectly and intuitively, so it would make sense to model anything missing from this spec after their functionality.  Plus, those projects are designed to match this spec, so it's a bit of a win-win for everyone.

@timbur systemjs should not dictate what we do here, it is the other way around. We are considering those ideas that we have tried, and play around with in systemjs, but ultimately we have to be pragmatic.
@matthewp I think you're confused. install() does not fetch deps since you have to provide a [[Module]] instance, which produces a new entry in the registry with [[State]]: "ready", there is nothing to return.

I didn't mean to imply that SystemJS should dictate anything here.  I was only saying that there is some extra functionality present within SystemJS which makes a lot of sense, and this functionality exists because of practical, real-world necessity/usefulness.  I'll provide an example of said necessity shortly (in addition to the example I provided above).

This spec has a loader.provide which actually gives more flexible behaviour than the System.define, System.module. See https://github.com/ModuleLoader/es6-module-loader/blob/1.0/src/loader.js#L429 for how it works.
@timbur note that name is deprecated in this spec, and modules are only src based.

@caridy I might be confused, let's break this down:

The normalization process (to a url), including the sites() configuration will happen if there is no entry available in the registry for an arbitrary values in the module specifier.

This normalization process is (potentially) asynchronous, if it goes through the resolve hook.  If that's the case it should return something.

@matthewp the normalization process only happens when importing a module (or a dep), not when installing a new entry in the registry.

Ok, then I did misunderstand you.  So this mean keys are really just arbitrary strings, I can do:
System.install("@@foobar", { default: { function() { return "bar"; } });

And anyone importing that will get the correct module, cool.

@guybedford Can that same flexible behavior be achieved directly through System?  Or is it currently limited to methods within loader?
As for the real-world necessity, it makes no sense to render inline modules inaccessible.  They're modules, too, right?  It should be possible to import them.  It also doesn't make sense to give them the src attribute since the source is contained within itself.  The only logical conclusion, in my opinion, is to use name so that said inline modules can be imported by their names.
The way I see it, from a simple point of view and for predictability's sake, internally, when paths are set and modules are cached, all that matters in the end is the corresponding key.  A few simple rules and everything gets insanely simple:

Is there a path match?  If so, use it and adjust the key to its full path name.
Are there any identifiers that would indicate it's a file (src, has a file extension, etc.)?  If so, use it and adjust the key to its full path name.
A single word with no extension?  Don't do anything fancy.  Don't change it.  Just use it.  At this point in these 3 steps, it's safe to assume we're looking for an inline module that was cached using <module name="..."> or explicitly defined some other way.  And if it isn't already cached, hit the server without appending .js to it.

Anything beyond that would be convoluted, adding unnecessary complexity and wasting everyone's time.  Keep it as simple and predictable as that and the only conceivable way developers could screw up is if they purposely shoot themselves in the foot.

I like the simplicity of having just src.
What about this:
<module src="hello.js">
export default 'I am a module'
</module>

@MajorBreakfast that means src has a different meaning depending on whether there is inner text or not.  Would also different from every other use of src attributes in html.

@matthewp Hmm, yes. Maybe <script> tag + System.install() comes close enough already. Likely, there even should not be a more convenient way to do this.

@timbur no. we have discarded that a while ago, and we've settled on the idea that inline modules will probably be focus on initialization (just like inline scripts are today), and therefore there is really no need to export things into the runtime from them, instead they just import other modules, and carry on with some initialization routines. I'm curious about what sort of inline script code you have today that modifies the runtime to extend the available functionality.

@guybedford I missed your comment but you're right that .provide is a better .define. Don't we still need a key-less form, though?  By default a <module> shouldn't be part of the registry.

@caridy My issue with that line of thinking is that if developers want to do something, they'll figure out a way to do it.  It's always better to provide an elegant, predictable solution for people to use, rather than imposing arbitrary restrictions that will lead developers to create ugly hacks/workarounds.  And for this particular case I'm 100% certain that will happen.
Consider this scenario:  Users load some module specific to their profile.  We'll refer to it as a duck.  Every user has their own duck with custom functionality that could not be easily defined in any form other than JavaScript.  It's initialized upon loading the page, and many other modules want to use that particular duck, expecting a quack method that is potentially custom (different) for each user.
Suppose we have my duck at timbur/duck.js:
export function quack () {
    // let's pretend this is all kinds of complex logic
    console.log('quack!');
}

And we have your duck at caridy/duck.js:
export function quack () {
    // let's pretend this is all kinds of complex logic
    alert('quack!');
}

And when I load the page, the HTML generated for me looks something like this:
<module>
    import duck from 'timbur/duck.js';
    duck.quack();
</module>

And yours of course looks something like this:
<module>
    import duck from 'caridy/duck.js';
    duck.quack();
</module>

And later on, perhaps some other module wants to make the user's particular duck quack, we'll call it goose.js.  There are of course many different ways to make this happen, so let's consider a few.
Without the ability to name (and register) the <module> above, it's really not even a module.  It's just a script.  So, as a script, if we want to maintain some reference to the user's duck, the script itself will need to assign the duck to some global variable.
<script>
    import duck from 'caridy/duck.js';
    duck.quack();
    window.main = {duck: duck};
</script>

Or for the sake of consistency and "elegance" (if you could call it that), one might pull some other module designed specifically for storing this information:
<script>
    import store from 'store.js';
    import duck from 'caridy/duck.js';
    duck.quack();
    store.set('duck', duck);
</script>

And then for our goose.js module to use the user's particular duck:
window.main.duck.quack();

Or:
import store from 'store.js';
store.get('duck').quack();

Now let's be honest.
Of course, all of this so far might seem like a contrived example, and most people might find this particular usage an edge case.  But again, it's never a good idea to impose restrictions on what should or shouldn't be possible only because it isn't some scenario that is easy to imagine.  People are obviously already aware of these possibilities, so why limit them?  It's much better to provide an elegant solution at the core.
And finally, let's consider a solution that I would probably use if naming an inline module was not built into the core of <module>'s functionality.  I realize this solution relies on System.define, but let's not be pedantic.  The analogy remains.
HTML snippet:
<module name="main">
    import duck from 'timbur/duck.js';
    duck.quack();
    export duck;
</module>
<script src="register-inline-modules.js"></script>

register-inline-modules.js:
var modules = document.getElementsByTagName('module');

for (var i = 0; i < modules.length; i++) {

    var module = modules[i];

    if (module.hasAttribute('name')) {
        var name = module.getAttribute('name');
        var source = module.innerHTML.substr(1);
        System.define(name, source);
    }

}

Then goose.js would very predictably look like this:
import main from 'main';
main.duck.quack();

That is way simpler and follows the module paradigm much more consistently.  But we aren't finished yet.
Last but certainly not least, consider that the name attribute is supported.  The following is all we need.  No global pollution.  No modules to designed specifically to remember duck.  No unnecessary extra scripts.  It's intuitive and succinct.  Just use the registry.
HTML snippet:
<module name="main">
    import duck from 'timbur/duck.js';
    duck.quack();
    export duck;
</module>

goose.js:
import main from 'main';
main.duck.quack();

It's entirely possible that I'm being stupid and completely overlooking an easier way to achieve this.    Either way, I think there are more than enough use cases out there that we haven't thought of which will resemble the above functionality, so why not make it elegant?

@timbur I think the idea is to have a main.js file (Directly or indirectly through the use of a bundling mechanism like in SystemJS). The module tag then simply imports that module.

It's always better to provide an elegant, predictable solution for people to use [...]

Not if the solution can be considered a dead end.

But it isn't a dead end.  The key point is that it should be possible to elegantly register dynamic modules under some common name without resorting to extra scripts.  Yes, in production, all static modules will be minified and bundled.  But it would be stupid to create separate bundles for each user due to some dynamic module reference.  The dynamic module would obviously automatically be excluded from the bundle, and the most efficient way for modules within the bundle to use it is to have its reference exported upon initialization.  I don't know how I can make it any clearer, and I've yet to see a reasonable argument against this functionality along, nor a more elegant solution to the problem.

Can the same effect be created with

?
Like Tim's example, this would be a per user specific page script. Like
Tim's example, the effect is to cause goose.js to see a different main
module dynamically, when it runs import. Like Tim's example it makes
development more challenging because the module is dynamic.
Unlike Tim's example it does not require a  with a name.
(To be sure, IMO we don't need a  tag without a name either. A

That's a pretty solid suggestion @johnjbarton, albeit still not nearly as elegant and intuitive as it could be.  And I actually agree that a <script> tag with System calls is more than sufficient.  However, I personally feel that web development in the future will take place almost entirely within the browser itself.  I'll explain my reasoning and what it has to do with modules.
We're already seeing a ton of movement towards minimizing the feedback loop with development - e.g., webpack hot module replacement, react-hot-loader, workspaces within dev tools that automatically save changes to CSS within the inspector, etc., etc.  So how can we get the feedback loop to an absolute minimum?  By having all of our development tools directly in the browser.  And of course, modules are undoubtedly the future, so we need a really solid module system that works seamlessly with this paradigm.  It needs to be effortless to develop modules and make them work together, and even inline modules should be identifiable.  It's important to know what's what.
With that said, let's compare what an in-browser development environment would look like without named modules.  Also consider that there might end up being more than a handful of anonymous modules in the development environment, for whatever purposes.

And this is what it looks like with the named inline module.  It's more intuitive, much easier to decipher.

@timbur are you talking about bucket testing? jejejeje
Anyway, @johnjbarton is righty, loader.sites() is really the way to go for those use-cases.

@timbur Each HTML file should only contain one module tag. The named file that shows up in the dev tools cannot be edited because it exists on disk inside the index.html. Why not use a main.js file?

@caridy I'm not talking about bucket testing at all, but that's a perfect example of one of the many possibilities that would be easier (or more elegant, at least) if naming inline modules is supported.  Can you provide an example using loader.sites()?
@MajorBreakfast You're thinking inside the box.  In an ideal in-browser development workflow, there are all kinds of possibilities that could potentially result in multiple html files and thus, multiple inline modules.  As for using a main.js file, the code would be different for every user, so it makes much more sense to be an inline script.

@timbur and co, our goal is not to provide sugar for every use case but for the most common ones, and make sure that the rest can be implemented in userland. This use case can be implemented in userland, no doubt about it, and We haven't seen this one very often when people embrace the ES module philosophy, It is really more like a side effect of trying to make modules to behave like scripts, which is fine but ... it is not really something we will promote or try to provide sugar for. If you really want to continue this conversation, you should demontrate that the currect spec does not allow you to do it on userland, or came up with a real very common use case that will requiere named inline modules. Makes sense?

Of course just about anything can be achieved in userland.  The point I've made is that including this functionality within the spec would only result in one or two lines extra of code at core of <module>, and these one or two lines would result in more than enough predicted benefits to warrant its inclusion, along with possibly many many more unpredicted benefits and no downsides whatsoever.

came up with a real very common use case that will requiere named inline modules

one that I've just been investigating is HTML Imports. Currently most existing web components that I've seen that use HTML Import have an inline template plus an inline script to deal with the template. In some cases, that script will just be an initialisation of some sort, but in others the component can be interactive and expose some sort of API - getThis, setThat. If these scripts are converted to modules, either there will have to be a rule that they should always link to an outside file (which might make sense from CSP point of view), or they will have to be named, so other modules can import them.

a simple example of this is Polymer. https://github.com/Polymer/polymer/blob/master/dist/polymer.html is the main component which runs a script to load the Polymer class function which all Polymer components use. This is currently a global. If you change this structure to modules, then all components have to import the Polymer module. To do that, it has to be named.

Custom elements are also global.

One could imagine that script being upgraded to a module:
<script type="module" src="polymer.js"></script>

Where 'src' above is an unnormalized module name (it may be called 'key' or something else though).
There is no need to name the module in the above, it is loaded anonymously and stored in the registry like any normal module load. Defining how modules affect rendering is the next question there though.

@guybedford You're saying that <module src="x.js"> would be handled differently from <script src="x.js">? See the comments from Apr 2. And what about inline modules in HTML Imports? If they export values, they need to have an identifier.
The basic issue here is that you are not importing a module file with a url, you are importing a document fragment which contains one or more module definitions which may need to be loaded in the registry, System.define() in the old spec, loader.install() in the new.

@MajorBreakfast HTML imports don't have to be custom elements. They could be a form or a bunch of divs or whatever grouping of html elements you like.

Having raised this issue, I'm not sure there is actually a problem. :-) The simple solution for the case where a component has to export values is to split the code in two: the <module>, whether inline or external, does the initial setting up, and if there's a need for exporting, then that code can be put in a separate js file which can be imported in the usual way. A disadvantage of this would be that the separate js file would be detached from the HTML Import and not necessarily linked to from it. But this is also the case with the main document: you can't tell from the html which modules are loaded (form part of the app). In the Polymer case, I don't think you need a Polymer component with a <module>, just a standard module for the Polymer class that can be imported by Polymer components.
In summary, a web app is an html document that can import stylesheets and components, and can contain an anonymous <module> to bootstrap the app. A component is an html document fragment that can ... to bootstrap the component.

correct, none of these examples really require an inline module to be named, lets keep it that way for now. We can always revisit this if needed :)


Backport: Silence the deprecated warning in generated code

impl_runtime_apis! is not only implementing the apis, it also calls
them internally and thus generates the warning. So, we just allow
depracted calls in the generated code.
Backport of: https://github.com/paritytech/substrate/pull/2513

Looks good to me, but it needs a runtime version bump.


Warning: componentWillReceiveProps has been renamed.

I am using react-credit-cards plugin, and having warnings with the latest version of react js.
build.umd.js:499 Warning: componentWillReceiveProps has been renamed, and is not recommended for use. See https://fb.me/react-async-component-lifecycle-hooks for details.

* Move data fetching code or side effects to componentDidUpdate.
* If you're updating state whenever props change, refactor your code to use memoization techniques or move it to static getDerivedStateFromProps. Learn more at: https://fb.me/react-derived-state
* Rename componentWillReceiveProps to UNSAFE_componentWillReceiveProps to suppress this warning in non-strict mode. In React 17.x, only the UNSAFE_ name will work. To rename all deprecated lifecycles to their new names, you can run `npx react-codemod rename-unsafe-lifecycles` in your project source folder.

Please update the following components: ReactCreditCards

The environment I am following::
"react": "16.9.0",
"react-credit-cards": "0.7.0",
How can I resolve this warning? Please suggest

Fixed in 0.8.0


File upload not working

Uploading a file on windows does not work, the file doesn't appear in the list

This is caused by some browsers sending the entire (win) path as filename, which is uninterpretable on the server. The file name needs to be supplied by the uploader manually.


Fix a11y: Inputs do not have a visible focus state when HC Light theme is applied

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: Stable 1.71.0 / Insiders 1.72.0-insider
OS Version: macOS 12.5.1

Steps to Reproduce:

Change editor to use the VS Code High Contrast default light theme
Open the settings page
Find a setting that uses a checkbox
Tab to focus on the checkbox (you should see no visible change when focused)

Reference/Comparison Screenshots
Default Dark Theme:

Default Light Theme:

Default HC Dark Theme:

Default HC Light Theme (note lack of difference between non-focused/focused states):

cc @daviddossett

Oh, looks like this issue seems to apply to dropdown and text field elements as well. I can file separate issues for each UI element if that's helpful/desired.

There's a difference now, but it's very slight, imo. I'm wondering if another colour like orange could be used instead for the focus border, like in the HC dark theme?


Command "mgradm support config" should save the support file with a date to avoid collisions

The support config command should save the file and avoid collisions with other older support configs instead of overwrite. To archive this we can add the date to the export file.
File name should follow the same name structure as before: SCC_<HOSTNAME>_DATE.txz
example: scc_stfpospap10_240412_1217.txz

@rjmateus I am moving this issue under GMC here https://github.com/SUSE/spacewalk/issues/24298 for now. It would be good if we can fix it for GMC. We still have a week for branch freeze.

PR has been merged. Feel free to close the issue.


cucumber trapping SIGINT behavior

Hello, I observe the following behavior.
= regular cucumber vs SIGINT

test is running
hit ctrl+c
test continue to be running and program exits only after it completes fully
hit ctrl+c again
cucumber exits without any clean-up taking place

= cucumber with Signal.trap('SIGINT') { exit(false) }

test running
hit ctrl+c
test terminates and cucumber switches to After hook

I think that the latter behavior makes much more sense. If user wants to interrupt, then ideally that will happen as soon as possible while After hook is executed to clean-up any underlying test environment. This is current behavior for SIGTERM.
So I was wondering what was the idea behind default SIGINT trap behavior. Why not keep same as SIGTERM? Not a big issue for me as I have a workaround. But would be nice to make behavior more convenient OOB for other users.
btw very nice cucumber takes care to run After hook on SIGTERM. I made some effort to put clean-up in at_exit when After is skipped but it seems After is never skipped. Or was the idea to have single Ctrl+C terminate after scenario finish, second Ctrl+C to drop into After hook? In such case it is not working like that.
moved from cucumber/cucumber-ruby-core/issues/108

@mattwynne @brasmusson @tooky What do you think about this suggestion? Shouldn't be hard to implement but I'm not sure if it's what we want to do.

bump

bump

@olleolleolle, do you have any thoughts on this?

I came late to the codebase. I can’t offer archeological evidence for “why” things are the way they are.
That said, I like the clarity offered by having the effects of the current TERM signal at Ctrl-c in the example.

Thanks Olle. I agree, and can't really think of any real downsides to implementing this. If someone were to create a PR to change this (including any tests etc),  do you think the core team would be open to merging it?

@xtrasimplicity I believe they would, but I wouldn't merge it myself, on account of not having "the full picture".

Yep, totally understandable. Thanks for clarifying. :)

Just to add, it's not just hitting ctrl+c, it's other "kill and stop", for example on RubyMine or other IDE's when you want to stop the process.
@akostadinov - What's the issue with the current functionality, are you just wanting to add the "Run After hooks" bit. Because If you're wanting to kill something manually, in my eyes you perhaps should be checking other things manually (in other words, don't kill things manually)
On the other hand, it wouldn't hurt / be problematic to add extra bits in, considering all of the code is already here.

@luke-hill , I assume RubyMine sends SIGTERM. What I was trying to explain is that Ctrl+c (SIGINT) should by default behave the same as SIGTERM. When I hit Ctrl+c I want program to stop, not continue running. Default behaviour is breaking this basic expectation.
wrt clean-up - I assume everybody wants it to have the clean-up most of the times. If somebody wants it skipped, they can do Ctrl+c twice to exit immediately.

So your ideal scenario is Ctrl+c says it's stopping (And starts running the After hook), and ctrl+c again during this time completely kills everything? If so I guess this makes a little bit of sense (Assuming at the moment it does nothing after the first ctrl+c).
Although I don't have enough knowledge of this area of the codebase.

Exactly, thanks.

Is this something you think you could work on solo, you want to pair on over github? or you want someone else to take a look.
Just so I know where we need to go forwards on this.

Not sure about latest code. It was a simple change for the version I reported with (my bad for not writing which exactly version it was).
Is there an agreement that SIGINT and SIGTERM should behave the same? If so I guess it would be easy for me to do it.

Honestly not sure. To me they're both interruptions, and in the context of cucumber we don't really "pause" stuff, so my 2cents is they're both kill commands. But I would probably defer to whoever wrote the original code (Probably one of the main members of cucumber)

I'm not sure of the history here, but I wonder if the idea is that initially we want to try and execute as cleanly as possible, but if there's something hanging we have a way to just abort.
With the proposed change what happens if the After hook is the problem and Cucumber hangs there?

@tooky , then you hit Ctrl+C a second time.

@akostadinov right - so the UX we're aiming for is:
ctrl-c 👉 cancel the test run where it is, but run after hooks to clean up
ctrl-c again 👉 just stop everything
That seems good to me.

I think given Tooky's knowledge of the codebase and that we're in a kind of consensus here with some contributors / collaborators; that's an essential "green-light" to make the changes you want @akostadinov - If you're comfortable doing it.
I'd happily review alongside others

Thank you, see #1353


Build fails after upgrading to Xcode 6.3 (6D570)

Hi @stephencelis
I upgraded my Xcode to 6.3 (6D570) and now i get a lot of errors when trying to build the app.

Lots of: 'autoclosure' attribute is now an attribute of the parameter declaration, not its type
SQLite.swift-master/SQLite/Value.swift:42:11: Class properties are only allowed within classes; use 'static' to declare a static property
SQLite.swift-master/SQLite/Statement.swift:39:68: Cannot assign to immutable value of type 'COpaquePointer'
SQLite.swift-master/SQLite/Statement.swift:39:18: Cannot invoke 'try' with an argument list of type '(Int32)'
SQLite.swift-master/SQLite/Statement.swift:192:27: Closure use of @noescape parameter 'block' may allow it to escape

Xcode 6.3 introduced Swift 1.2 and a lot of changes. You'll need to update to the latest version of SQLite.swift.

Sorry @stephencelis,
I thought I had the latest version, is not the be in the master branch? That's the one I have.
Cheers
Alex

@Alexof Please verify against GitHub. The issues you list above were corrected on a swift-1-2 branch awhile ago, which was merged into master the day the GM was released.


Added solidityKeccak256 Function

Closes #66

[x] Added solidityKeccak256 function

To Do

[ ] Fix tests
[ ] Add docs
[ ] Look for optimizations?
[ ] Add toTwos method onto TinyBig -- @dawsbot
~Polyfill buffer~ - No longer needed as other essential-eth functions aren't polyfilled

@dawsbot I added a task to add the toTwos method onto the TinyBig class, which is needed for the pack helper function


Fixed jruby head tests related with bigdecimal

Removed jruby-9000 from travis and use only jruby-head.
Fixed tests related with BigDecimal and jruby-head

@AlfonsoUceda Can you please link here the jruby bug? and explain the reason of this? As future memory. TY!

@AlfonsoUceda Can you please link here the jruby bug? and explain the reason of this? As future memory. TY!

@jodosha we can support lotus/utils from jruby <IP_ADDRESS> (jruby-head) because in previous versions complex are broken if we pass a complex to a big decimal.

@AlfonsoUceda I am with you on this

For reference, I've checked which jruby version introduced this change and it was <IP_ADDRESS>. I'm :+1: to bump to <IP_ADDRESS> as minimum supported version.

@jodosha thanks! sorry I saw the message but I forgot apply it.

@AlfonsoUceda No worries, man :+1:


Remove all pre-filled CityGML 2.0 namesapces from the namespace table

Wenn importing CityGML 2.0 data into database, the importer should map CityGML 2.0 -> 3.0 on-the-fly and write the data into the database. So, CityGML 2.0 namespaces are not needed anymore.
Of course, we need a documentation about how the mapping of 2.0 -> 3.0 works.

done with 4386fe8


Compiling problems on Linux

I have troubles with compiling this program on Linux (Debian 11 stable, gcc 10.2.1-6). I tried to compile this with different C++ versions (C++14, C++17, C++20) but I had those error messages every time:
error: the value of ‘DEBRUIJN64’ is not usable in a constant expression
note: ‘DEBRUIJN64’ was not declared ‘constexpr’

error: the value of ‘ROOK_ATTACKS’ is not usable in a constant expression
note: ‘ROOK_ATTACKS’ was not declared ‘constexpr’

error: the value of ‘BISHOP_ATTACKS’ is not usable in a constant expression
note: ‘BISHOP_ATTACKS’ was not declared ‘constexpr'

P.S. Sorry for my bad english.

Hello! I am not a C++ expert, but here is how I solved the issue for me.
I removed the word constexp in several places:

tables.cpp:160: /*constexpr*/ Bitboard get_rook_attacks(Square square, Bitboard occ) {
tables.cpp:226: /*constexpr*/ Bitboard get_bishop_attacks(Square square, Bitboard occ) {
tables.h:21: extern /*constexpr*/ Bitboard get_rook_attacks(Square square, Bitboard occ);
tables.h:32: extern /*constexpr*/ Bitboard get_bishop_attacks(Square square, Bitboard occ);
types.cpp:125: /*constexpr*/ Square bsf(Bitboard b) {
types.h:113: extern /*constexpr*/ Square bsf(Bitboard b);

I removed the word inline in several places:
types.cpp:86: /*inline*/ int pop_count(Bitboard x) {
types.cpp:95: /*inline*/ int sparse_pop_count(Bitboard x) {
types.cpp:118: /*inline*/ Square pop_lsb(Bitboard* b) {
types.h:107: extern /*inline*/ int pop_count(Bitboard x);
types.h:108: extern /*inline*/ int sparse_pop_count(Bitboard x);
types.h:109: extern /*inline*/ Square pop_lsb(Bitboard* b);

After that, I could compile with g++ -o surge *.cpp -lstdc++.

Thank you!


API product delete button need to be compatible with API delete

API Product delete button need to align to right side corner.

This has been resolved


feat(EMS-2746): No PDF - Policy - Broker details - Email validation. DRY E2E email validation assertions

Introduction :pencil2:
This PR adds email validation to the Broker details form in the Policy section of a No PDF application.
As part of this PR, have also created some new DRY E2E functions to assert email validation rules.
Resolution :heavy_check_mark:

Update email examples E2E constants to include ABOVE_MAXIMUM and VALID_EMAIL examples.
Update error messages content strings.
Create new shared test assertion function, assertEmailFieldValidation.
Add E2E test coverage for Broker details email validation.
Update "Company or ogranisation" and "Account details" email validation E2E tests to use assertEmailFieldValidation.
Update all email DB fields to have a VarChar of 300, update DB dump.
Create a new POST route and controller for Broker details.
Create initial Broker details validation rules, with email calling the shared email validation helper.
Update the shared email validation helper to:

Accept an object of error messages, instead of a single error message.
Return maxLengthValidation.

Update all calls to the shared email validation helper to pass ERROR_MESSAGES_OBJECT.

Miscellaneous :heavy_plus_sign:

Fix some typos.
Add a missing async/await to a unit test.
Re-order some imports.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (main-application-no-pdf@d54619a). Click here to learn what that means.

Additional details and impacted files
@@                    Coverage Diff                     @@
##             main-application-no-pdf    #1875   +/-   ##
==========================================================
  Coverage                           ?   98.39%
==========================================================
  Files                              ?      513
  Lines                              ?     8559
  Branches                           ?      924
==========================================================
  Hits                               ?     8422
  Misses                             ?      137
  Partials                           ?        0

Flag
Coverage Δ

unit-test
98.39% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Proper layout for unions

Currently union layout is ignored. Instead fields are flattened into the parent structure.
Proper layout should be implemented at some point if we want to transpile ~anything that touches the disk/network.

Sorry, missed the notification somehow.
Yes, that's a good option. The only downside is that it breaks Go pointers, so GC can miss them.
Because of this we might want to make it optional or use some other approach, for example:
type Data interface{
  isDataUnion()
}

type DataI int32
func (*DataI) isDataUnion() {}

type DataF float32
func (*DataF) isDataUnion() {}

type DataStr [20]byte
func (*DataStr) isDataUnion() {}

Setters and getters will get weird, but they will at least preserve pointers and will verify that the access is using the correct part of the union:
var d Data
// ...
*d.(*DataF) = DataF(v)

I know that there are cases when unions are intentionally used to read the same data via two or more different representations, so we might need both modes.


Country rank # doesn't update when country is changed.

If you change your country on the site your rank # doesn't update in game.

It will update with the next score upload or on the restart. Real-time update is not planned because of the added complexity for such a rare occasion.

i travel full time, when I'm staying in a country for longer than 30 days I update the country. i've updated this multiple times and even on restart / next score upload it doesn't update. It doesn't update from the original # rank the first country was put in on account creation.


Add codecov

Add codecov
Add codecov badge to README

Description

Motivation and Context

Closes #
How Has This Been Tested?

[ ] I have tested using MacOS
[ ] I have tested using Linux
[ ] I have tested using Windows

Checklist

[ ] I have updated the documentation accordingly.
[ ] I have updated the tests accordingly.

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@427d7eb). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff            @@
##             main        #2   +/-   ##
========================================
  Coverage        ?   100.00%
========================================
  Files           ?         1
  Lines           ?        46
  Branches        ?         0
========================================
  Hits            ?        46
  Misses          ?         0
  Partials        ?         0

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Adding note about events

Office Scripts don't have events, like VBA macros do. This PR adds a statement to that effect in the VBA vs. Scripts doc.
Review site link: https://review.docs.microsoft.com/en-us/office/dev/scripts/resources/vba-differences?branch=AlexJ-EventNote

Docs Build status updates of commit c733015:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/resources/vba-differences.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit a8a82c4:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/resources/vba-differences.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Label U2OS cells

Hi,
I tried to segment U2OS cells with HPA-cell-Segmentation, but could not get good results(As you can see from the image). I think the reason is that U2OS cells are smaller than normal cells. I have tried to change the scale_factor or resize the image according to the HPA dataset, but without any improvement. I would like to ask, do you have any suggestions to achieve better segmentation?

Thanks in advance and happy new year!
Best regards,
Xin.

Hello Xin!
The model has worked well for U-2 OS cells before, but I believe we have only tested it on data from the HPA.
My spontaneous guess is that the issue here is that your image contains much smaller cells (in terms of pixel area per cell) than what the model has originally been trained for. You might need to retrain the model for your specific case by manually labeling some images and using that as training data. As the model is already trained on similar data, it should require much less training data than if you were to train the model from scratch.
Another possibility could be to upscale your images to make sure that the pixels represent the same distances as in the HPA (0.08μm per pixel), but I am unsure on how well this would work in practice.
Best regards,
Casper

Hi Casper,
Thanks for your reply and your explanation!
According to your suggestions, I have tried to upscale my images and make the pixels represent the same distances as in the HPA. At present, the segmentation is much better!
Thank you once again!
Xin.

Awesome! Let me know if there are any other issues that you find. I will close this issue for now.


Draw backgrounds over editors

The editors currently just draw numerals over numerals, making it very hard to read in places.

Fixed a while back.


Warning: createRoot(): Creating roots directly with document.body is discouraged

Describe the bug
When creating a content script with React it shows a warning:
react-dom.development.js:86 Warning: createRoot(): Creating roots directly with document.body is discouraged, since its children are often manipulated by third-party scripts and browser extensions. This may lead to subtle reconciliation issues. Try using a container element created for your app.
To Reproduce
Share minimal reproduction. Examples of a minimal reproduction:
temp.zip
Steps to reproduce the bug using the reproduction:

Install dependencies: pnpm i
Start dev mode: pnpm dev
Wait for the browser open and try to go to any website or just google
F12 and look at the console tab

Screenshots

Environment

  System:
    OS: Windows 11 10.0.22631
    CPU: (16) x64 12th Gen Intel(R) Core(TM) i5-12500H
    Memory: 4.58 GB / 15.73 GB
  Binaries:
    Node: 20.11.0 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.22.21 - C:\Program Files\nodejs\yarn.CMD
    npm: 10.2.4 - C:\Program Files\nodejs\npm.CMD
    pnpm: 8.15.3 - C:\Program Files\nodejs\pnpm.CMD
  Browsers:
    Edge: Chromium (121.0.2277.112)
    Internet Explorer: 11.0.22621.1
  npmPackages:
    wxt: ^0.16.8 => 0.16.8

Additional context
Everything still works fine, I think. But the warning is just annoying.

Yes, container is a body element. For CSS frameworks like tailwind to properly work, I mimic a regular document inside the ShadowRoot. You can see this by inspecting the DOM.
For the react example, I made the react example as simple as possible, but I can update it since it's a little misleading.
      onMount: (container) => {
-        const root = ReactDOM.createRoot(container);
+        const app = document.createElement('div');
+        container.append(app);
+        const root = ReactDOM.createRoot(app);
        root.render(<Main />);
        return root;
      },

Docs updated 👍


kube-apiserver manpage outdated

When running kube-apiserver (0.8.0)
$ /opt/bin/kube-apiserver --address=<IP_ADDRESS> --port=8080 --etcd_servers=http://<IP_ADDRESS>:4001 --logtostderr=true
F0108 22:59:42.400928    3080 apiserver.go:99] No -portal_net specified

But manpage doesn't refer to said flag and what it does.

When did we grow man pages?  Yikes..
On Thu, Jan 8, 2015 at 3:00 PM, Paulo Pires<EMAIL_ADDRESS>wrote:

When running kube-apiserver (0.8.0)
$ /opt/bin/kube-apiserver --address=<IP_ADDRESS> --port=8080 --etcd_servers=http://<IP_ADDRESS>:4001 --logtostderr=true
F0108 22:59:42.400928    3080 apiserver.go:99] No -portal_net specified
But manpage doesn't refer to said flag and what it does.
--
Reply to this email directly or view it on GitHub
https://github.com/GoogleCloudPlatform/kubernetes/issues/3340.

@thockin you should now better :P #1759

Hmm, I feel pretty sheepish.  Man pages are great, but clearly we're not
keeping them in sync.  Are they worth the effort at this point in the
development cycle?
On Thu, Jan 8, 2015 at 3:06 PM, Paulo Pires<EMAIL_ADDRESS>wrote:

@thockin https://github.com/thockin you should now better :P #1759
https://github.com/GoogleCloudPlatform/kubernetes/pull/1759
--
Reply to this email directly or view it on GitHub
https://github.com/GoogleCloudPlatform/kubernetes/issues/3340#issuecomment-69266742
.

Closing this in favor of #3924 which is more general; that is to say, fixing #3924 will fix this, and there's no real advantage to fixing this without examining the broader issue.


[BUG] Metadata information update fault for two data sets

Bug Description
I have tried to update the metadata for the following two data sets and even after the update the license information is not updated.
Image 1 : before updating
Image 2; meta data editing page

Image 3: data table without the licence updated

Bug Reproduction
Visit the Data page and you will see the aforementioned datasets.Click on the edit Meta data
Bug Impact
Licence information doesnot get updated
Bug Screenshots
No response
Bug References
No response
Bug System Information

OS: [e.g. Windows 10]
Browser: [e.g. Google Chrome, Firefox]

it is solved now


[$500] Chat - Font size is smaller in single backtick code block

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: <IP_ADDRESS>
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4278628
**Email or phone of affected tester (no<EMAIL_ADDRESS>Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:
Pre-condition: user must be logged in

Go to any chat
On the compose box, enter " text " and send it
On the compose box, enter " text " and send it

Expected Result:
The single backtick code block should have the same font size as the triple backtick
Actual Result:
The single backtick code block does not have the same font size as the triple backtick
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[x] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/a0bfda7d-000f-4ddd-aac8-48b3a61c3d2e
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01e903c4ce4d32d16f
Upwork Job ID:<PHONE_NUMBER>382381056
Last Price Increase: 2024-02-03

We think that this bug might be related to #vip-vsp
CC @quinthar

Proposal
Please re-state the problem that we are trying to solve in this issue
The single backtick code block does not have the same font size as the triple backtick.
What is the root cause of that problem?
The issue comes from the CodeRenderer component where as a result of a previous issue https://github.com/Expensify/App/issues/30203 where the accepted solution PR was to add the isInsideH1 logic which returns a larger fontSize (15) when the single backtick code block is inside an h1 element (# 'code block') by using this function:
function getCodeFontSize(isInsideH1: boolean) {
    return isInsideH1 ? 15 : 13;
}

This logic gives our regular single backtick code block the smaller fontSize 13 while code blocks wrapped in an h1 element will have fontSize 15 which is the same as the regular triple backtick code block has currently.
What changes do you think we should make in order to solve the problem?
Given this issue's expected result, this means that the logic added by the mentioned PR does not apply anymore and returning fontSize 13 for the non-h1-wrapped code block is not valid anymore:

remove the isInsideH1/getCodeFontSize redundant logic from the CodeRenderer component and set fontSize: variables.fontSizeNormal directly in the textStyleOverride object.

With this change -> both regular single backtick code block and the h1 wrapped single backtick code block will have fontSize: variables.fontSizeNormal (15) which is calculated correctly via getValueUsingPixelRatio(15, 21) instead of the hardcoded numeric values 15 and 13.
Screenshots

iOS: Native

Before
After

What alternative solutions did you explore? (Optional)
If the expected result is what we want here but we need to keep the redundant logic added by the mentioned PR (for whatever reason) then within the CodeRenderer component, use the isInsideH1 variable to conditionally pass the fontSize object to the textStyleOverride like so:
    const textStyleOverride = {
        ...(isInsideH1 && fontSize),
        // ...rest of the variables

this will have our regular single backtick code block default to the normal fontSize 15 instead of being set to 13 - while keeping the isInsideH1 fontSize 15 logic when that is true.
Additional improvement in case we go w/ this solution: within the getCodeFontSize function, replace the hardcoded numeric values of 15 and 13 with variables.fontSizeNormal respectively variables.fontSizeLabel in order to get the correct values based on getValueUsingPixelRatio.
Screenshots

iOS: Native

Before
After

cc @Expensify/design

Totally agree, optically it feels like 13px in our mono font matches 15px of our regular font.

I think the main idea here is that:

the monospaced font feels bigger than our normal font, so we should manually back it down so that optically they feel the same
ideally the font size we use for the inline code & the code blocks are the same exact size
perhaps we take away some of the vertical padding of the code block too so it feels less like an outlier
now what size do we use for mono? What is it currently in the inline code lines? Is it 13 or 14?

Okay cool, that logic could probably remain but we should make the normal code blocks use 13px as well then.

Can you share screenshots with more context? Like full app screenshots that include other chat messages too? It's a bit hard to judge this in such isolation. Thanks!

☝ I think that looks good, but agree with Shawn, it'd be nice to see it with a bit more context.

I think I like the 4px personally, curious what the other design homies think though!

Y'all are quick! That text size looks great. I like the 4px of padding, and honestly I would probably like 8px too haha. I don't feel SUPER strongly about choosing between 4 and 8 for the padding.

I think we would want both the horizontal and vertical padding to be the same though. It looks like just the vertical padding is updated there.

Got it, so maybe to be more clear, can you show us two screenshots:

one where we use 4px for both vertical and horizontal padding
one where we use 8px for both vertical and horizontal padding

Thanks!

@shawnborton I think there's just a discrepancy being created by the baked-in spacing of the font itself. I think this screenshot is with 8px of padding on all sides.
We might need to make the top and bottom get 8px padding, and left and right get 12px padding to visually make them appear the same.

Updated proposal

added alternative solution as per recent design team discussions

We might need to make the top and bottom get 8px padding, and left and right get 12px padding to visually make them appear the same.

Ahhhh you are right indeed, thanks for clarifying!

@dannymcclain do you have a favorite combo from above?

Can somebody from the team update the OP Expected result or create a new issue based on the latest discussions around this issue ?
Asking in order to have clear expectations for everybody and to update our proposals accordingly ✌

@shawnborton I'm diggin' the first option (Vertical Padding: 8px, Horizontal Padding: 12px) the most, but I would also be happy with the third (Vertical Padding: 4px, Horizontal Padding: 8px) if you all prefer that one.
Basically I just want to balance out the vertical and horizontal padding haha, and whichever way everyone likes doing that is good with me!

Cool cool, I can totally get down with that and agree on balancing out the padding!

@dubielzyk-expensify curious for your opinion too of course!

Yeah, I'm okay with both options you mentioned Danny as it gives it the right spacing padding wise.

Sounds good to me, let's go with that. Thanks!

Thanks for the proposal everyone.
Alternative 2 Proposal (with the changes decided by design team) from @Krishna2323  looks good to me.
🎀 👀 🎀 C+ reviewed

@strepanier03 This is ready for payment. PR deployed to production on 29th Feb.

Sorry everyone, the automation failed here and the urgency label wasn't updated so this fell through the cracks. I'm working on this now and will have an update in a few minutes.

Payment Summary

[x] $500 - @Krishna2323 - Paid via Upwork
[ ] $500 - @sobitneupane - Via Manual Requests

@JmillsExpensify - Payment request incoming from @sobitneupane

@Krishna2323 - I've paid you via Upwork and close your contract, thank you again!
@sobitneupane - The payment summary is above for your payment request and I've assigned Jason as well.
Cheers!

$500 approved for @sobitneupane


update eigen to 3.3.4

Testing:

https://ci.appveyor.com/project/ingenue/hunter/build/1.0.1874
https://travis-ci.org/ingenue/hunter/builds/247421289?utm_source=github_status&utm_medium=notification

Uploading:

https://ci.appveyor.com/project/ingenue/hunter/build/1.0.1878
https://travis-ci.org/ingenue/hunter/builds/247492597?utm_source=github_status&utm_medium=notification

Released: https://github.com/ruslo/hunter/releases/tag/v0.19.20


Remove FIXME for de-duping matches

Per the ticket, I'm not able to reproduce the issue. It may have been fixed already, so closing out the ticket and removing the FIXME. If it pops up again in the future, we can reopen.
Closes #662

[x] I have read the CONTRIBUTING doc
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have checked that all unit tests pass after adding my changes
[ ] I have updated necessary documentation
[x] I have rebased my branch onto main
[x] I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

here is an example of to reproduce duplicated matches:
apiVersion: gateway.networking.k8s.io/v1beta1
kind: HTTPRoute
metadata:
  name: test
spec:
  parentRefs:
    - name: gateway
  hostnames:
    - "cafe.example.com"
  rules:
    - matches:
        - path:
            type: PathPrefix
            value: /coffee
          headers:
            - name: version
              value: v2
      backendRefs:
        - name: coffee-v2-svc
          port: 80
    - matches: # same matches
        - path:
            type: PathPrefix
            value: /coffee
          headers:
            - name: version
              value: v2
      backendRefs:
        - name: coffee-v1-svc # different destination
          port: 80

leads to:
    location /coffee_prefix_route0 {
        internal;

        proxy_set_header Host $gw_api_compliant_host;
        proxy_pass http://default_coffee-v2-svc_80$request_uri;
    }

    location /coffee_prefix_route1 {
        internal;

        proxy_set_header Host $gw_api_compliant_host;
        proxy_pass http://default_coffee-v1-svc_80$request_uri;
    }

    location /coffee/ {
        set $http_matches "[{\"redirectPath\":\"/coffee_prefix_route0\",\"headers\":[\"version:v2\"]},{\"redirectPath\":\"/coffee_prefix_route1\",\"headers\":[\"version:v2\"]}]";
        js_content httpmatches.redirect;

    }

    location = /coffee {
        set $http_matches "[{\"redirectPath\":\"/coffee_prefix_route0\",\"headers\":[\"version:v2\"]},{\"redirectPath\":\"/coffee_prefix_route1\",\"headers\":[\"version:v2\"]}]";
        js_content httpmatches.redirect;

    }

where $http_matches includes duplicated matches (they test the same header for the same value).
if you put the conflicting rules above in different HTTPRoutes resources, you will duplicate matches too.
Also, it looks like we have a bug here. I would expect that for resolving conflicting rules, because the rule coffee-v2-svc goes before  the rule coffee-1-svc in the HTTPRoute, it will win.   @kate-osborn  thoughts?

@pleshakov Good find, I think the example you provided is different from what caused the original bug to be found. In that case, we had duplicate matches forwarding to the same place, so they were redundant. In this case, they are different backends, so technically not redundant, but more of a conflict defined by the user. The ordering may be a bug as you mentioned, and the duplicate matches should be taken care of in this case so only the winning backend is forwarded to.
Since this was intended to be an unscheduled, one-day task, I can close this PR and copy your comment into the bug so we can better schedule it in the future since there appears to be real work to be done here.


return string doesn't work when using function as expact paramter

return string will not throw error, and it incorrectly pass the test:
.expect(function (res) {
  if (true) {
    return 'not correctly';
  }
})

Only throw error works:
.expect(function (res) {
  if (true) {
    throw new Error('not correctly');
  }
})

Doesn't match the usage in Readme https://github.com/visionmedia/supertest#expectfunctionres-

Also seeing this.

It seems that _assertFunction only handle return Error, throw Error, but not string..
if (err instanceof Error) return err;

https://github.com/visionmedia/supertest/blob/master/lib/test.js#L269
It maybe works if we do something like this:
if (typeof err === 'string') err = new Error(err);
if (err instanceof Error) return err;
```js

see the same issue.

This is a dup of PR #262 I just merged that in.


HTTPS cert for aclu.codeforhawaii.com

@felimartina Done. The certificate for the aclu.codeforhawaii.org subdomain is in the aclu's aws certificate manager (region us-west-1). I've also setup the CNAME for that name to point at d3t0l1kpp6myc4.cloudfront.net

FYI https://aclu.codeforhawaii.org produces a cert error and the unsecure page produces a cloudfront error

okay yeah, I had closed the issue as I had obtained the cert, but it still needs to be deployed.  We'll also want to make sure http on port 80 of aclu.codeforhawaii.org correctly redirects to the https:// url

Ah ok, I'll close this and keep #67 open then.

@mckaydavis site is running on region us-west-2 (Oregon)...would you mind uploading the cert into that region instead?

@mckaydavis Actually...seems like we need to store certificate in US-EAST-1
If you want to require HTTPS between viewers and CloudFront, you must change the AWS region to US East (N. Virginia) in the AWS Certificate Manager console before you request or import a certificate.

Source => http://docs.aws.amazon.com/AmazonCloudFront/latest/DeveloperGuide/cnames-and-https-requirements.html
Also says the same in the web console:
ou can use a certificate stored in AWS Certificate Manager (ACM) in the US East
(N. Virginia) Region, or you can use a certificate stored in IAM.

@felimartina :ok_hand: cert issued in us-east-1

@mckaydavis can we get an api.aclu.codeforhawaii.org for the API? we need the API to be HTTPS as well, don't we?

@felimartina :ok: cert issued in us-east-1 for 	aclu.codeforhawaii.org,	api.aclu.codeforhawaii.org, api.codeforhawaii.org, and www.aclu.codeforhawaii.org

@mckaydavis We will also need the certs in the oregon region us-west-2...seems like cloudfront (since it is a global service) uses us-east-1 and then other region-based services (such as ELB) use certs in the current region. Would you mind doing the process again on us-west-2? I did request the certs so you should have gotten an email already.

@felimartina the request emails went to my spam folder and I missed them so I re-requested and the cert is now issued in us-west-2


Update dev_1.7.0 with main

Description
This pull request updates branch dev_1.7.0 with branch main.

Codecov Report

Merging #982 (5495421) into dev_1.7.0 (7c63269) will decrease coverage by 38.87%.
The diff coverage is 30.04%.

:exclamation: Current head 5495421 differs from pull request most recent head 6ea039c. Consider uploading reports for the commit 6ea039c to get more accurate results

@@              Coverage Diff               @@
##           dev_1.7.0     #982       +/-   ##
==============================================
- Coverage      65.56%   26.69%   -38.88%
==============================================
  Files            201      220       +19
  Lines          17875    19008     +1133
  Branches        3275     3451      +176
==============================================
- Hits           11720     5074     -6646
- Misses          4866    13448     +8582
+ Partials        1289      486      -803

Impacted Files
Coverage Δ

art/attacks/evasion/adversarial_asr.py
33.33% <0.00%> (-57.98%)
:arrow_down:

...attacks/evasion/auto_projected_gradient_descent.py
7.25% <0.00%> (-45.42%)
:arrow_down:

art/attacks/evasion/dpatch.py
13.20% <ø> (-12.55%)
:arrow_down:

art/attacks/evasion/dpatch_robust.py
11.22% <ø> (-35.30%)
:arrow_down:

art/attacks/evasion/frame_saliency.py
21.00% <0.00%> (-54.00%)
:arrow_down:

...ted_gradient_descent/projected_gradient_descent.py
48.61% <0.00%> (-9.29%)
:arrow_down:

...adient_descent/projected_gradient_descent_numpy.py
43.10% <0.00%> (-29.73%)
:arrow_down:

...ient_descent/projected_gradient_descent_pytorch.py
16.27% <0.00%> (-78.89%)
:arrow_down:

...escent/projected_gradient_descent_tensorflow_v2.py
17.60% <0.00%> (-77.41%)
:arrow_down:

art/attacks/evasion/shapeshifter.py
5.86% <0.00%> (ø)

... and 244 more


Needs to be more practical and user friendly

This description needs to be better related to metadata use such as lists with case studies/examples. There is a lot of assumed knowledge. I have just read the SharePoint Maven's metadata blog from 2016 and it was more user friendly. Your metadata jargon, although simple, doesn't seem to gel.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c4d14723-ab30-719c-c69d-e42f94a680b5
Version Independent ID: 182bf188-87f6-f966-4e86-77ef8927905c
Content: Introduction to managed metadata - SharePoint Online
Content Source: SharePoint/SharePointOnline/managed-metadata.md
Service: sharepoint-online
GitHub Login: @MikePlumleyMSFT
Microsoft Alias: mikeplum

@Jabfag2356 Thank you for submitting feedback and contributing to the docs. We are currently investigating this.

Hello @MikePlumleyMSFT Mike 👍 I need to kindly ask you to step in, as designated author of the article to review @Jabfag2356 comments, do you see something can be improved based on them? Thank you.

@scanum Manuela, we can close this issue now.

@Jabfag2356 Thank you for submitting feedback. We understand that this issue has been resolved.
Please feel free to re-open this issue if there is a specific area of the docs that we can improve or make better. Thank you.


Recipe Problems

When crafting the Honey Glazed Ham or Steak and Potatoes, you usually get the bowl back one has used to craft the cooked rice. In contrary, when crafting those recipes using the recipe sequences you just lose the bowl. I think this should be avoided, for example by placing the cooked rice at the beginning instead of the empty bowl. I think these are the only two recipes but I don't know if I missed something.
I also realized that for example the Stuffed Pumpkin usually gets cooked using the Cooking Pot but this also is ignored in the Recipe Sequence. Maybe one could add bulk smoking as a last step (although I am not sure if this is possible as no other recipe does that afaik, and I haven't taken a look at the recipe sequence code myself).
Besides these two things, there are 11 missing recipes which can't be automated using recipe sequences or heated mixing (If I counted correctly).
Those recipes are:

Dumplings
Cabbage Rolls
Cooked Rice
Bone Broth
Fired Rice
Baked Cod Stew
Mushroom Rice
Vegetable Noodles
Ratatouille
Squid Ink Pasta
Dog Food

I am currently adding those recipes as simple heated mixing recipes with kubejs, but a real implementation (heated mixing or recipe sequence) would of course be better. Fixing the first two problems with kubejs feels quite janky as I would have to modify (replace?) existing recipe sequences, I definitly don't know to which degree that is possible (and should be ideally not need when they are fixed).
Besides these things I very much prefer this mod over slice and dice (not because of the other stuff it adds but because all of the fluid this one adds, it is just way more interesting), although I currently have to use both to a certain degree as there is currently no way to automate cutting with this mod, but I have seen there is already another issue opened for that.
All in all, it would be really nice if all of the above could be fixed/added somehow.

to use both to a certain degree as there is currently no way to automate cutting with this

Okay, I heard your point. I will think about it and think in the next update I will implement it

Although the automation of cutting, log stripping, etc. is an issue, I personally think it's a minor one (as you can just use slice and dice atm till its implemented). But I think it's still important to consider how to set this apart from Slice and Dice (maybe make the block more like the saw or the chisel from rechiseled create).
To me personally the other issues are more important, especially the rice bowl situation as resources just vanish into thin air. The missing recipes are also nothing small to overlook, the heating in recipe sequences in contrary is just me being petty lol.

Heating in recipe sequences is not possible as far as I know. I will fix your problems in the release for 1.20.1, and then for 1.19.2, because at the moment it is not convenient


Feat/389

Related Issue
resolves #389
Description
Designed and integrated the modal for Cover Letter Generation.
Type of PR

[ ] Bug fix
[X] Feature enhancement
[ ] Documentation update
[ ] Other (specify): _______________

Screenshots / videos (if applicable)
https://github.com/user-attachments/assets/e291e9ea-bc06-4c4d-ab03-86d470094363
Checklist:

[X] I have performed a self-review of my code
[X] I have read and followed the Contribution Guidelines.
[X] I have tested the changes thoroughly before submitting this pull request.
[X] I have provided relevant issue numbers, screenshots, and videos after making the changes.
[X] I have commented my code, particularly in hard-to-understand areas.

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@ashutosh-rath02 Resolved!!


Overcommit hook supplants Git-Lfs hook, thereby breaking Git-Lfs

After running overcommit --install, if git-lfs was previously installed, it's pre_push hook is moved to .git/hooks/old_hooks directory.  This breaks usage of Git-Lfs.
I've put together a custom PrePush hook named GitLfs that re-adds the Git-Lfs functionality, available as a gist.
I'm not sure if this should be a Feature Request in this project to add a template_dir/sample_hooks/ directory or something to that effect, or possibly an addition to Git-Lfs project.

You could just submit a pull request with your hook, we'd be happy to review it.
I don't think it will work as you expect right now, since shelling out to git lfs pre-push with backticks will swallow any errors and not prevent a push.

Will do.  And yeah, thought about that as I was getting this ready but decided to hear what the direction was first.  Won't be able to get to that until tomorrow.  Thanks.

Submitted PR #369

Solution in #369 (comment) should take care of this. Feel free to reopen if you have any trouble.


Save sessions in database rather than in filesystem

To achieve this we leverage the PdoSessionHandler.
Also while at it we should increase the session lifetime as a convenience hack requested by swapp users.

The node version on travis' php image was incompatible to it's yarn version. So we needed to manually install node with a yarn compatible version.


Tentative support for new (user-defined) types in P4Info

We update P4DataTypeSpec to be able to represent user-defined types in
P4Info. Translation (when the control-plane view differes from the
underlying data-plane type) may be required for new types through the
@p4runtime_translation annotation and this information is preserved in
P4Info. As decided previously, we do not break backward-compatibility
for action parameters and match fields. For these we do not use
P4DataTypeSpec but instead we add a new Protobuf field ("type_name")
which is set if the action parameter / match field is a user-defined
type (which must map to an underlying bit vector in this case).

@jafingerhut Could I get a second review on this? Please let me know if there is something I didn't reply to or address. Thanks.

@antoninbas I have done a second review now.  I've been more thorough with the text than the Google Protobuf code.

@jafingerhut thanks for the thorough review. PTAL and approve if I didn't miss anything so I can merge.


enable needed systcl settings on the infra stacks/containers

Related:
https://github.com/rancher/rancher/issues/7280#issuecomment-294596799
https://github.com/rancher/rancher/issues/8203

@niusmallnan I have taken care of ipsec/vxlan/metadata. Can you please check for other infra stacks?

Does this still need work? @leodotcloud @niusmallnan


Invalid importing model with skeleton only

Godot version
3.3.4.stable.mono.offical (faf3f883d)
System information
Windows 10, GLSL3, Geforce 3090
Issue description
In case when model doesn't have mesh glb import to godot as several spatials nodes.
And if add any mesh to skeleton godot will import as mesh + skeleton with bones.
Steps to reproduce
In blender create any skeleton and then export it to glb or fbx. Import exported file to godot. Look that godot shows several spatial instead of skeleton.
And then add any mesh to you skeleton on blender and export again. And in this
Minimal reproduction project
Test.zip

Blender can only export its armature if it is part of a mesh. I'm not sure what to do in Godot to guess.

This was a bug in Blender, not a bug in Godot, and this is now fixed in Blender.
In the attached project, fail.glb does not contain skins.
However, with Blender 4.2, if using Godot's .blend file import feature, or re-exporting a .glb or .gltf` from Blender, the resulting file has skin data, indicating that this file contains a skeleton:
    "skins": [
        {
            "inverseBindMatrices": 0,
            "joints": [6, 5, 4, 3, 2, 1, 0],
            "name": "Armature"
        }
    ],

And now that the data in the file is correct, the file correctly imports into Godot:

Thanks for investigating. We can close shortly.


Nuxt 3 generate 500 error

Environment
npm run generate
Describe the bug
After install i18n in my project, I got 500 error on page in npm run generate

My i18n configuration like this:

Additional context
No response
Logs
No response

In Project was error on header popper. I fixed it

Answering here just for googling purposes, i was struggling with the same kind of problem: error 500 on prerendering pages who works and builds correctly.
After a few hours, discovered the problem was a missing .env (or correct env appointment) during generate, because my nuxt config were receiving the variables.

Hello, how are you, I also have that same error but what do you mean, environment variables, on the i18n?


Failed storing Block loop after upgrade

I just upgraded to v0.5.1. Was running main branch before that and not sure exactly what version that was at the time, sorry.
After building and running, I am stuck in a loop like this. Notice the block height is not advancing.
e@node03:~/r/nm/juno$ ./build/juno   --db-path /data/juno/mainnet   --http-port 6060 --log-level DEBUG

       _
      | |
      | |_   _ _ __   ___
  _   | | | | | '_ \ / _ \
 | |__| | |_| | | | | (_) |
  \____/ \__,_|_| |_|\___/

Juno is a Go implementation of a Starknet full node client created by Nethermind.

21:13:22.683 17/08/2023 +00:00  WARN    node/node.go:120        Ethereum node address not found; will not verify against L1
21:13:22.683 17/08/2023 +00:00  INFO    node/node.go:337        Starting Juno...        {"config": "{LogLevel:debug HTTPPort:6060 WSPort:6061 GRPCPort:0 DatabasePath:/data/juno/mainnet Network:mainnet EthNode: Pprof:false Colour:true PendingPollInterval:0s Metrics:false MetricsPort:9090 P2P:false P2PAddr: P2PBootPeers:}", "version": "v0.5.1"}
21:13:25.075 17/08/2023 +00:00  WARN    sync/sync.go:185        Failed storing Block    {"number": 159018, "hash": "0x51aa...f5a9", "err": "unexpected EOF"}
21:13:25.075 17/08/2023 +00:00  WARN    sync/sync.go:253        Restarting sync process {"height": 159018, "catchUpMode": false}
21:13:26.977 17/08/2023 +00:00  WARN    sync/sync.go:185        Failed storing Block    {"number": 159018, "hash": "0x51aa...f5a9", "err": "unexpected EOF"}
21:13:26.977 17/08/2023 +00:00  WARN    sync/sync.go:253        Restarting sync process {"height": 159018, "catchUpMode": false}
21:13:29.068 17/08/2023 +00:00  WARN    sync/sync.go:185        Failed storing Block    {"number": 159018, "hash": "0x51aa...f5a9", "err": "unexpected EOF"}
21:13:29.068 17/08/2023 +00:00  WARN    sync/sync.go:253        Restarting sync process {"height": 159018, "catchUpMode": false}

Guessing I'll have to resync, but it would be nice if we didn't loop like this and we told the user "sorry, you're going to have to resync".

It appears you've encountered a database mismatch issue due to downgrading Juno from the main branch to v0.5.1 which has different db structure. Juno doesn't support backward db migrations which probably cause this error. To resolve this, you'll need to resync from the start or run Juno again using version from main branch.

Got it. Makes sense that we don't support downgrades at this stage, particularly from unreleased versions. Thanks.


add allowManualNc option

replaced $ with jQuery to allow noConflict() versions where the default jQuery alias $ is used by another application

I've added a 'allowManualNc' setting to create a way where the user can not manually select the default/no value option.

Hello,
First of all, thank you for contribution. You have 2 differents points on this pull request, can you create 2 branches with this 2 contributions ? In this way, i can merge separatly this issues.
For the first point, i don't think the replacement of $ by jQuery is the best way for the noConflict(). I see it on diffrent jQuery plugin, they used
(function($) {
    Plugin code
}(jQuery));

Maybe is the "use strict" the problem.
You use jQuery and what other javascript library ? You have tried this different possibilities ?
Second point, when you separate it, i will try this.

Palloquin,
My commit 2d58110 fix the noConflict() problem.

Clear, I'll recreate a sepperate pull


Update service-fabric-diagnostic-how-to-use-elasticsearch.md

Fix that's required for it to build with today's ElasticSearchListener

Hi @ishepherd, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

@ishepherd : Thanks for your contribution to the Azure documentation! The author, @karolz-ms, has been notified to review your proposed change.

Thank you for the fix, @ishepherd, much appreciated!

#sign-off


Added certification tests for azure service bus pubsub

Signed-off-by: Amulya Varote<EMAIL_ADDRESS>Description
Please explain the changes you've made
Added certification tests for azure service bus for pubsub
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1922
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:

[ ] Code compiles correctly
[ ] Created/updated tests
[ ] Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

@amulyavarote I marked this PR as a draft until the remaining tests have been added

/ok-to-test

Because this workflow was not previously enabled I need to merge this PR to make sure tests are passing. If they do not pass after merging, there will be a follow up item for you @amulyavarote. FYI

@amulyavarote after discussing with you it seems you followed a lot of the structured created by the Kafka certification test. I find that test not readable and unmaintainable as is. My feedback here should make it easier to understand at a quick glance what is being tested and why / how.

/ok-to-test


unity Intel D415 PointCloudMat

The depth data of the camera is defective and incomplete

Could you provide an image of your point cloud from the Unity wrapper please?   Thanks!

Hi @LITONG12345,
Any update? Do you try the latest librealsense? Still need any support for this issue?

Hi @LITONG12345,
I will close this if no additional support required.


newrelic_plugin_agent wont start

hi
Could any one help me on this issue regarding installation. Please see error below.
/usr/bin/newrelic_plugin_agent: not running

Same here with RHEL6
I know it's quite old but this is still the actual version right ?
Any ideas ?


Bugfix/cyrush/2019 05 bv fixes from 3.0 rel can

Description
Applies changes from #3508  to develop

@biagas -- thanks, I fixed the formatting on develop!


Load wav from resource

Hi,
Is it possible to read short wave files (sound effects) from embedded resources files (Properties.Resource.)?
The WaveFilereader only works from physical file.
Resources ares stored as UnmanagedMemoryStream.

You can do it like this:
            var assembly = Assembly.GetExecutingAssembly();
            var assemblyName = assembly.FullName.Split(',')[0] ?? string.Empty;
            var resourceName = $"{assemblyName}.{fileName}";
            var resource = assembly.GetManifestResourceStream(resourceName);

            if (resource != null)
            {
                lock (_mutex)
                {
                    using (var audioFile = new WaveFileReader(resource))
                    using (var outputDevice = new WaveOutEvent())
                    {
                        outputDevice.Init(audioFile);
                        outputDevice.Play();
                        while (outputDevice.PlaybackState == PlaybackState.Playing)
                        {
                            Thread.Sleep(500);
                        }
                    }
                }
            }

I think there is a simpler way:
var importer = new RawSourceWaveStream(Properties.Resources.click, new WaveFormat();
var soundFx  = new WaveOut();
soundFx.Init(importer);
soundFx.Play();


CNN example question

Hi, first thanks for the videos on youtube and the code here. Enjoyed the learning experience a lot!
Just a question, I tried to follow your video about building CNN with Keras (link). And some of the apis of Keras seem to be changed after you record the video, thus I directly reused your code here.
But my training and testing accuracy are both around 0.4 only. I saw in your video it is 0.976. Could you suggest some possible reasons behind? Thanks!

I figured out the issue. Never mind.


PDF converted is not that Good

In my local machine pdf is converted fine and looks good but my deployment server ubuntu converts pdf not properly. It cuts 30% width and also text formatting is also changed. I am facing this issue on production and not on my local. Someone please help on priority basis.

I have the same issue, i just discovered :( it looked perfect on my machine, but when running it on a server it looks terrible

Same problem. any idea how to fix it?

I have the same issue. any idea how to fix it?

Same here, I am trying to create a pdf doc and server it on server. Somehow like most of you, the result is different between local development and the production. https://github.com/tanhauhau/express-pdf/issues/2#issuecomment-934660822

@onelifeodyssey which OS are you running locally?
try to play around with the zoomFactor config. default is 1, reduce this to around 0.75 or 0.8.

+1

did you found the solution?

Same problem. any idea how to fix it?

did you found the solution ?


IdentationError

File "/content/learning3d/data_utils/dataloaders.py", line 259
source = np.concatenate([source, self.get_rri(source - source.mean(axis=0), self.nearest_neighbors)], axis=1)
^
IndentationError: unindent does not match any outer indentation level

Thank you for pointing out the error. I have resolved that error.


Must be in powers of two, so 32768 not 32000

Thanks!

Np, glad I could assist in anyway at all. Thanks for writing and sharing cool software


Adicionado cobertura de testes

close #17

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@bdb14ea). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #18   +/-   ##
=========================================
  Coverage          ?   72.50%
=========================================
  Files             ?        7
  Lines             ?       40
  Branches          ?        0
=========================================
  Hits              ?       29
  Misses            ?       11
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdb14ea...0fc0bb7. Read the comment docs.


Trade interface: Add a GET /market/price

We should introduce a new method on the public Trader interface that returns the current spot price, how much 1 unit of the base is worth in quote, and the minimum amount needed to be bought/sold for it.
All strategies should return these two datas under the hood.
This will allow clients (ie. tdex app or tdex analytics) to fetch spot price for any possible trading pair combination, regardless of different precisions.
This requires a change to trade protocol and the TDEX specs, although in NOT a breaking change since clients are (ab)using the /trade/preview for the purpose of knowing the spot price of a market

All strategies should return these two datas under the hood.

Strategies already implement an API for the spot price but it's basically not used in the rest of the codebase, therefore adding this should be straightforward.
IMO, to support the min traded amount, it's more correct to add new fields to the market domain rather than making changes to the formula interface. It's something related to a market more than it is to a strategy.
But beside that, shall we make this info required for opening a market? Otherwise, what should a client do in case a market's min traded amount is 0 when it fetches the spot price?

It's something related to a market more than it is to a strategy.

Yes but I mean this public API should return it.

shall we make this info required for opening a market?

Ideally, we should calculate and infer based on the precision of the assets given when creating a market

A new method in the trade protocol was added https://github.com/tdex-network/tdex-protobuf/pull/73
A PR for the tdex daemon is currently being reviewed https://github.com/tdex-network/tdex-daemon/pull/669
It's not breaking change, eventually we will have it in tdex-analytics as well

closed by #669.


Apktool v2.3.4 -  has no default translation

Information

Apktool Version (apktool -version) - 2.3.4
Operating System (Mac, Linux, Windows) - Linux
APK From? (Playstore, ROM, Other) - ROM - OxygenOS 5.1.7

Steps to Reproduce

apktool d framework-res.apk
apktool b -c framework-res

I've been testing booting up a decompiled/complied framework-res.apk, because I realized I needed to sign it before it could boot, so in this process, when I compile it back, I run into these messages;
Could not find sources is my understanding is normal, as framework-res.apk is the source of all apk, is this a normal message? Then since I'm only running the 2 commands I get all these has no default translation is this ok, or a problem?

./apktool b -c framework-res
I: Using Apktool 2.3.4
W: Could not find sources
I: Checking whether resources has changed...
I: Building resources...
W: warning: string 'BIND_OEMEX_SERVICE' has no default translation.
W: warning: string 'adb_active_generic_notification_message' has no default translation.
W: warning: string 'adb_both_active_notification_title' has no default translation.
W: warning: string 'adb_net_active_notification_title' has no default translation.
W: warning: string 'close' has no default translation.
W: warning: string 'color_picker_blue_label' has no default translation.
W: warning: string 'color_picker_champagne_label' has no default translation.
W: warning: string 'color_picker_default' has no default translation.
W: warning: string 'color_picker_flamingo_label' has no default translation.
W: warning: string 'color_picker_gray_label' has no default translation.
W: warning: string 'color_picker_green_label' has no default translation.
W: warning: string 'color_picker_message_default' has no default translation.
W: warning: string 'color_picker_orange_label' has no default translation.
W: warning: string 'color_picker_pear_label' has no default translation.
W: warning: string 'color_picker_pink_label' has no default translation.
W: warning: string 'color_picker_purple_label' has no default translation.
W: warning: string 'color_picker_red_label' has no default translation.
W: warning: string 'color_picker_turquoise_label' has no default translation.
W: warning: string 'color_picker_unknown_label' has no default translation.
W: warning: string 'color_picker_yellow_label' has no default translation.
W: warning: string 'ext_media_ready_notification_title' has no default translation.
W: warning: string 'global_action_reboot' has no default translation.
W: warning: string 'global_action_screenshot' has no default translation.
W: warning: string 'high_definition_tag' has no default translation.
W: warning: string 'install_fail_oplib_not_satisfied' has no default translation.
W: warning: string 'kg_fingerprint_verification_failed' has no default translation.
W: warning: string 'lock_to_app_description_hardware' has no default translation.
W: warning: string 'lock_to_app_toast_hardware' has no default translation.
W: warning: string 'op_applying' has no default translation.
W: warning: string 'oxygen_system_label' has no default translation.
W: warning: string 'permdesc_modifyWavesSettings' has no default translation.
W: warning: string 'permdesc_setKeyguardWallpaper' has no default translation.
W: warning: string 'permdesc_switchMaterialTheme' has no default translation.
W: warning: string 'permlab_modifyWavesSettings' has no default translation.
W: warning: string 'permlab_setKeyguardWallpaper' has no default translation.
W: warning: string 'permlab_switchMaterialTheme' has no default translation.
W: warning: string 'power_intensive_notificaton_string' has no default translation.
W: warning: string 'reboot' has no default translation.
W: warning: string 'reboot_bootloader' has no default translation.
W: warning: string 'reboot_confirm' has no default translation.
W: warning: string 'reboot_progress' has no default translation.
W: warning: string 'reboot_recovery' has no default translation.
W: warning: string 'reboot_title' has no default translation.
W: warning: string 'reset_retail_demo_mode_text' has no default translation.
W: warning: string 'reset_retail_demo_mode_title' has no default translation.
W: warning: string 'top_app_killed_message' has no default translation.
W: warning: string 'top_app_killed_title' has no default translation.
W: warning: string 'wfcSpnFormat' has no default translation.
W: warning: string 'zzz_op_global_action_confirm_poweroff' has no default translation.
W: warning: string 'zzz_op_global_action_confirm_reboot' has no default translation.
I: Copy original files...
I: Copy AndroidManifest.xml...
I: Copy META-INF...
I: Building apk file...
I: Copying unknown files/dir...
I: Built apk...

Frameworks
If this APK is from an OEM ROM (Samsung, HTC, LG). Please attach framework files
(.apks that live in /system/framework or /system/priv-app)
framework-res.apk.zip
Questions to ask before submission

Have you tried apktool d, apktool b without changing anything?
Yes, as I mentioned above, I only tested this by only running two commands and then signing it to make sure it will boot;

apktool d framework-res.apk

apktool b -c framework-res

If you are trying to install a modified apk, did you resign it?
Yes
java -jar signapk.jar certificate.pem key.pk8 framework-res.apk test.apk

Are you using the latest apktool version? Yes - 2.3.4

Pretty sure this is because a String exists in a values-language folder but not the actual values folder

Well all I did was these cmds;
apktool d framework-res.apk
Then edited the framework for what I wanted to do, which was simple change in /valuesbool.xml, I changed two lines that were listed as false to true, then compiled it back
apktool b -c framework-res
Then I signed it and put it back into the ROM and the support I wanted out of it is working, the ROM seems to run fine, but if this is not correct I'd like to fix it, but I have not idea here.
If I pasted the framework-res.apk, would you know what is going on, how to fix this?
Thanks

Well all I did was these cmds;
apktool d framework-res.apk
Then edited the framework for what I wanted to do, which was in /values/bool.xml, I changed two lines that were listed as false to true, then compiled it back
apktool b -c framework-res
Then I signed it and put it back into the ROM and the support I wanted out of it is working, the ROM seems to run fine.
If I just run these commands only, and make no changes;
apktool d framework-res.apk
apktool b framework-res
or
apktool b -c framework-res
I still see this output; has no default translation.
I'm assuming just running these commands is correct and doesn't cause anything like this, and it's just simply the way this framework-res.apk came from OnePlus, it's just something on their part they did, or forgot to do etc...?
Thanks

@iBotPeaches ok, but as I mentioned, all did was decompile it, then compile it back with no changes, so I assumed that meant this is just the way it is from OpenPlus who created it?
Thanks

That is correct. Many applications are built with outdated tools or simply ignore warnings.

Those BASTARDS! LOL
Makes ya think they don't know what they are doing...
Happy Holidays


Add httpTestingController.verify() to every HTTP based test

There should be no unexpected HTTP requests.

Done


Nest Thermostat (Climate) "Target Temperature" is 0.1C above what the device states.

Make sure you are running the latest version of Home Assistant before reporting an issue.
You should only file an issue if you found a bug. Feature and enhancement requests should go in the Feature Requests section of our community forum:
Home Assistant release (hass --version):
0.32.2
Python release (python3 --version):
3.4.2
Component/platform:
Nest/Climate - thermostat
Description of problem:
I'm in the UK, so I'm running in Celsius but it's reporting both the current temperature and the temp it's heating to to be exactly 0.1 degree above what it actually is.
For example, when the thermostat is set to 21C, HASS says 21.1C. Likewise, the slider to select the temperature does increments of 0.5C, but 0.1 and 0.6, so I can set it to 21.1C, or 21.6C when the Nest actually accepts it as 21C and 21.5C.
Expected:
The temperature on the Next thermostat to match that in HASS
Here are some screenshots to show what I mean..

FYi, this is what my Nest displays..

Nest rounds off the temperatures in celsius it shows in the app and on the screen of the device to a whole number or .5 decimals. So the temperature can be set to 20.6 while the device or app shows 20.5. Home-assistent reads the specific temperature the device is set to and not the rounded temperature nest shows.
You can see the specific temperature Nest is set to in the settings menu of your device and will probably see Home-assistant shows the right temperature.

It's not the room temperature that's displayed that I'm saying is wrong though, it's the increments you can set the target temperature to from within Home Assistant. When changing the temperature on the Nest itself, as you turn the dial, it goes 19, 19.5, 20, 20.5, etc. However, in Home Assistant the slider "Target temperature" does it 0.1 degree above that - so 19.1, 19.6, 20.1, 20.6, etc.
It means Home Assistant doesn't match the Nest. So why does Home Assistant increment at 0.1 and 0.6  per degree and not 0.0 and 0.5 as you'd expect and as the Nest itself does?

Renamed the issue so it makes a bit more sense.

I can't unfortunately screen grab the slider while in use, but when sliding it, it uses the 0.1 and 0.6 increments I spoke about, whereas the Nest is 0.0 and 0.5.

Hmmm yeah the slider is actually a bit strange. For me it increments only to .3 and .8 values. I think it based on the min_temp that has been set by the user for the Nest device. For me it is 9.3, while the Nest app shows the rounded as 9. So the .3 and .8 temperatures are .5 increments of the min_temp for me. I will see if I can find a fix for the slider so it is a bit more user friendly.

@R1chardTM Thanks, appreciate the help :)
If it's any additional help, but I set my slider to .1 or .6, the Nest does interpret it at 0.0 and 0.5 respectively, though I can't say if that's cause it's rounding it's own display, or what it receives.
Interestingly my min temp in HASS shows as being 10.1, however I cannot set 10.1 on the Nest itself. I set it to 10C on the Nest so I'm not sure where the .1 comes from..

Since the switch to the API, this issue is now resolved so I'm going to close it.


batchedUpdates?

import { batchedSubscribe } from 'redux-batched-subscribe'
import { unstable_batchedUpdates as batchedUpdates } from 'react-dom' // eslint-disable-line camelcase

enhancers = enhancers.concat([
    // Batch React updates that occur as a result of Redux dispatches,
    // to prevent cascading renders.
    // https://github.com/gaearon/redux/issues/125
    // https://github.com/tappleby/redux-batched-subscribe
    batchedSubscribe(batchedUpdates)
])

@steida ?

No, it's tricky. Weird cursor rendering issues for controlled components. It's up to React itself to do that.


Using templates in html files?

I was looking into how lit-html works and I couldn't find anything on using templates in html files. If lit-html takes the template literals and creates html templates, I think the possibility to use existing templates defined in <template> tags in html files would eliminate the first step. And it would allow the template to be editor friendly (syntax highlighting etc., which is what I'm actually interested in) since it is mixed with the other html content.

lit-html templates are necessarily JavaScript because the expressions reference JavaScript objects. For a template system to be authored in HTML you need to provide data objects to the template being rendered and have some sort of expression syntax and control flow. lit-html is small in part because it just uses JavaScript for that.
You can however build a in-HTML template system on top of lit-html's core. I have a side project where I've done this called Stampino: https://www.npmjs.com/package/stampino warning it's not production ready and has some API warts, but it's an example of what can be done with Lit 2.
If you're looking for syntax highlighting, there are plugins for various editors like VS Code. lit-plugin provides syntax highlighting, code completion, linting, hover-over docs and more.


update dom to use newer methods

This can be split into separate PRs if that is desired.
This PR fixes #113517

Adding @alexdima esp for the isInDom changes

Adding @alexdima esp for the isInDom changes

Thanks @nrayburn-tech

Thanks @nrayburn-tech


feat: support preloadScript

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license
This pull request adds a new prop to the ConstructHub class to support a preload.js script on the webapp. This addition will allow us to remove our analytics script from our npm package, as well as allow construct hub instances to have their own javascript run before the webapp is served (if needed)

@gabewomble Can you add a short description to what this PR does?

@gabewomble Can you add a short description to what this PR does?

Scratch that, its below the license disclaimer, which confused me :)


test: api tests do not make the build fail, though they should

@radare as written on Telegram, there's a bug in the sdb_array_add_num api, so this is probably going to be red.

why not fix the bug before making this change?

Sorry, i'm not that much into sdb neither that interested in it :( We can things as they were if you prefer.

should be good to merge now, please rebase


ADD VAO CLASS

to add i need to add the VERTICES along  with the def of VAO VBO inside the class no need for float* arguments ETC...
--- when adding i need to add a model loader too .. assimp instead of vertices... eTC

not needed anymore


 It was like 3 AM and I diden't care about nothing so I made some lists lol

This and #13 are getting solved on new branch