esp_vfs_l2tap_intf_register() not implemented. (IDFGH-6909)

I am trying to implement PTP using Netif as per documentation regarding L2 TAP interface.
google esp_vfs_l2tap_intf_register() returns hits only refering to the documentation. Am I supposed to implement esp_vfs_l2tap_intf_register() myself? Any clues?

Hi @djmordor we are currently unfortunately missing an example related to L2 TAP interface. I have opened tasks to create it but I am busy with other issues. However, you could get better picture of how to use it in L2 TAP unit test.
Anyway, implementing PTP on ESP32 sounds interesting, it would be nice if you shared if you were successful. Are you planning to port PTPd?

I am but a novice really kostaond. I have done a little programming in D and python and swerved C and C ++. I have a couple of Olimex POE boards which I have been tinkering with for a few months. Most of that has been just learning the build system using WSL under Visual Studio Code on Windows11. Its taken me two days just to get the master branch working (cmake and intellisence problems).
I have PTPd for inspiration but I am hopefully going to build something more lightweight and direct than going through the entire lwip TCP/IP stack. Reading the L2 TAP documentation indicates that this is possible but I don't know if I am on the right track. I still haven't solved the mystery of the hardware timestamp yet but I have spent days looking at the ESP32 Technical Reference manual. Am I right in thinking that the timestamp is automatically inserted on frame reception/transmission? How do I access the outgoing timestamp? I have more questions than answers, most of what I have been looking at is completely new and alien, so don't expect any timely or professional results ; ) End goal is AES67 cos I'm an audio nut. The I2S concept makes more sense to me coming from an audio background. Ethernet is a new topic for me, but I like the challenge.

@djmordor 1588 standard defines various transport layers to be used. Ethernet (accessed via L2 TAP on ESP) is among them and PTPd has support for it but the implementation is platform specific. However, that's just a part of the problem. To be able to provide precise time stamping, the HW support is needed. ESP32 EMAC should have support for 1588 time stamping but I am not exactly sure about its capabilities. I haven't had time to fully investigate (test) yet since PTP does not have high priority for us right now. In general, time stamps should be available in Tx/Rx Ethernet DMA descriptors when time stamping enabled. It is straight forward for Rx. For Tx, you firstly copy data and configure the Tx descriptor, then command to transmit and read back the same descriptor which should be updated with the status of previous Tx operation. However, as I said, I've never tried it so I don't know how exactly it behaves. Therefore, the first thing to do should be ensuring ESP32 time stamping capabilities, then update Ethernet driver to be able to provide time stamps to SW layer and then port PTPd. In any case, it is quite complex task...


some style cleanup

pip score increaby for this module from 3.67/10 to 4.43/10

LGTM. What is a pip score and how do you calculate it?

i meant pylint. got confused, sorry.

Thanks for the clean up!  I haven't done a complete review; I'm just jumping in to say that "antiderivative" should not be changed to "anti-derivative".

Actually, I'll just make the last revert and squash/push now. The NotImplementedError question isn't that relevant, because that's all dead code anyway. Will send a follow-up PR to remove that all.

Merged in fed1ae5, thanks @mherkazandjian, all.

follow up in gh-6741


Add flexible failure handling

Hi Chris,
We've tried to come up with some modest changes that would allow us to implement the different kinds of failure behaviours that we currently use at GoCardless. This pull request contains everything that is necessary to get us going, and we've actually got a Job running on this in production right now.
We've written a gem called que-retry that makes use of these changes.  We're hoping to open source it soon, but it's not quite ready.  Looking at it might provide better context for our changes, so let us know if you'd like to take a look.
The current changes are:

The failure handling code from the work loop has been extracted into a method of it's own.
A retryable field has been introduced to stop "failed" jobs from being re-run constantly.
A retryable argument has been added to Job.
The new migration sets retryable to true for all existing jobs.  This ensures users with existing jobs will be unaffected.
The lock_job query has been updated to only select jobs that are retryable.
A failed_at field has been added for introspection/diagnostic purposes.
The freeze on Que::SQL has been removed, because we needed to introduce more queries in our que-retry gem.

The last point is one we've been unsure about, it could be avoided by including one of our queries in Que itself, but by default it wouldn't be used by Que.  It would be great to hear how you feel about this, and we'd be happy to show you que-retry.  It's not quite finished, but it's pretty close, and will be open-sourced.
Another change that starts to make sense when you look at que-retry is the possibility of passing instances of Jobs to the handlers, rather than hashes.  It would end up being a bit cleaner.
One last thing to note, is that we have been running our branch in queue-shootout against your master to make sure we've not had a detrimental impact on performance, so far it's a close match and seems like we've had literally no impact.

I'll look at this more closely tomorrow, when it's open-source day at work, but is there a reason you decided to get this route rather than inserting failed jobs into a separate table? That feels like it'd be cleaner to me than adding columns and leaving non-retryable jobs in the main job table. I like the idea of allowing failure/error behavior to be more customizable on a per-class basis, though.
Passing job objects themselves to the error handlers is something I had considered, but there will be some errors where it won't be possible to do so (like if a job class is renamed and rows with the old class are left in the DB, which could happen easily), and it felt more reasonable to just always pass hashes rather than sometimes jobs and sometimes hashes.
Anyway, I'll investigate more tomorrow afternoon. Thanks for the PR and the discussion!

We felt this way was slightly simpler, but there really wasn't much in it. With the separate table, change the query to an INSERT/DELETE wrapped in a transaction, which I think would be safe.

I just wrote a section for the customizing Que doc on how you might configure certain failed jobs to be moved to a separate table. I actually found writing and implementing it to be helpful in feeling out the problem. So, my various thoughts:

I'm not a fan of keeping these jobs that won't be retried in the main table. I worry it'll bloat the queue and its index unnecessarily, and I don't like the idea of complicating the job lock query to handle their presence, even if it doesn't result in a noticeable performance issue most of the time.
The enqueue command feels like a bad place to be declaring whether a particular job is retryable or not - that logic feels like it belongs in the job class. If you decide you want to maintain a fork that keeps failed jobs in the same table, that's one thing I'd rethink if I were you.
I like the idea of making error handling overridable on the class or job instance level. That would allow for a lot more flexibility, though I'm not sure exactly what use cases you're looking to support. I guess I'm thinking an interface that would allow for things like (pseudocode):

class MyJob < Que::Job
  def handle_error(error)
    case error
    when NetworkError
      # Transient problem, default to exponential backoff technique.
      super
    when HostNotFoundError
      # Permanent problem, don't retry.
      destroy
    else
      # Other unknown problem. Wait one hour for a developer
      # to fix, but if it happens five times, just give up.
      if error_count =< 5
        retry_in(3600)
      else
        # Stash failed jobs somewhere they can be examined later.
        $redis.lpush "uncaught_errors", JSON.dump(@attrs)
      end
    end
  end
end

I think this would all be orthogonal to the error_handler proc, which is meant to hook into Honeybadger or another monitoring system, and which should always be engaged, regardless of the nature of the error.
What do you think? Does this pseudocode address the kinds of things you were wanting to be able to do? I'm of course also interested in any opinions anyone else has on what they'd like to be able to do with retry logic.

Sorry for the delayed response on this. I spent some of last week thinking through the retryable part of the query, but mostly setting up monitoring for Que on our live systems.
We've got 2 use cases so far, both using the failure callback. They're currently sat in a private repo, but I'll get that opened up in the next day or two (pending a bit of cleanup). Those use cases are:

A type of job which is executed with at-most-once delivery, reports any errors on failure, and remains in the queue if it fails at any point.
A type of job which does (customisable) backoff for a known list of exceptions. Other exceptions report a failure. Once the backoff schedule has been exhausted, the job is either destroyed, or a failure is reported.

As you pointed out, the failure handling here is separate to the global Que.error_handler. The reason we did that is that we don't want exception reports for things we're going to retry. For example, if a webhook isn't sent because of some transient network issue, it should be retried silently (perhaps incrementing a counter in a metrics system).
Job failure/retry
Going back to the retryable flag, a big part of the use case there is to provide the at-most-once semantics for non-retryable jobs. To do that, in the at-most-once job type, we issue an UPDATE query which sets the job as non-retryable before calling the job's run method. This means that if the job fails after being started by one worker, it won't be picked up by another.
Single vs multiple tables
There's a bit of a tradeoff for that query if you split it up into multiple tables. You have to run it in a transaction so that the INSERT/DELETE become visible at the same time. I kinda prefer the simplicity of the single UPDATE query, though I can see how having two tables would make things clearer.
I'm not too worried about table bloat with jobs that can't be run. For the non-retryable job type, failure is loud (calls a failure handler which in our case sends alerts). The idea there is that failures should be dealt with quickly, and that non-retryable jobs should be rare anyway, with most jobs being written with idempotence in mind.
I'm going to review the last changes to que-retry before we open it up now. I'll reply in here with a link once it's done. Keen to hear your thoughts. I'm sure there's places we can improve it!

As promised: https://github.com/gocardless/que-failure
Sorry for the delay. We were just tweaking a few last things before opening it up.

@chanks Wondering if you've had a chance to look through this. We've been using it in production for a few weeks now, and it's all looking stable.

I'm not really feeling any better about the design of adding another column to mark jobs that aren't to be retried and then leaving failed jobs in the same table. It may make sense for your use case, but it doesn't feel like a reasonable general default to me, so I don't think I'll be merging this PR as it is.
I'd like to get to some changes to make error/retry logic more flexible on a class/instance level before I ship 0.11.0 - I think that'll help everyone (including you) out a lot. And then if somebody wants to implement a custom solution that stashes failed jobs elsewhere (in another table, in Redis, emailing them, whatever) that should be easy to support without needing to modify Que itself.
I don't really have a clear vision of what I want those error/retry changes to look like yet, but I imagine I'll be working on it in the next week or two. I skimmed your use case discussion above back when you posted it, but I honestly haven't put a lot of time and thought into what the problems you're facing are and how more flexible error handling can address them, so I was leaving this open until I did that.

Ah, I'm sorry to hear that, though I understand you've got to weigh these things up in the context of other people using Que.
If it's the difference between getting this merged and maintaining a fork, I'm willing to reconsider the table structure. The objection to the flag on the job table comes as a bit of a surprise, as you seemed to have a preference towards an active flag (which we ended up calling retryable) when we chatted by email.
I understand if you don't want to merge these changes though. If that's the case, we'll carry on with our fork.

Yeah, I brought it up as a possible solution for your use case, but in
general I expect people will wind up leaving failed jobs hanging around
indefinitely and bloating the jobs table. If you have processes in place to
inspect failed jobs and clear them out every once in a while, it's an
easier sell, but I doubt most people will expend that effort.
On Mon, May 18, 2015 at 12:32 PM, Chris Sinjakli<EMAIL_ADDRESS>wrote:

Ah, I'm sorry to hear that, though I understand you've got to weigh these
things up in the context of other people using Que.
If it's the difference between getting this merged and maintaining a fork,
I'm willing to reconsider the table structure. The objection to the flag on
the job table comes as a bit of a surprise, as you seemed to have a
preference towards an active flag (which we ended up calling retryable)
when we chatted by email.
I understand if you don't want to merge these changes though. If that's
the case, we'll carry on with our fork.
—
Reply to this email directly or view it on GitHub
https://github.com/chanks/que/pull/106#issuecomment-103119966.

Ah, that makes more sense. We're adding an audit job to detect any stale non-retryable jobs left in the queue, and notify developers.
If it makes any difference - the default behaviour when running Que is unchanged. Jobs are only marked as non-retryable if you implement a custom failure handler, such as the ones we've released in Que::Failure.

Another thing I'm asking myself regarding this PR is, how many right ways
to do this are there? For example, I had the example code for how to do a
recurring job in the "customizing que" documentation for a while, since I
initially envisioned it as a simple hack on top of Que that would take ten
lines and could be easily customized, so we might as well give some example
code and then let people tweak it themselves for their exact situation. And
then, over time, as people started to use that example and comment on how
it could be fixed, I started to feel that recurring jobs were harder to
implement correctly than I thought, and that there was one way to implement
them that was most correct. So I changed my mind and wrote a
Que::RecurringJob class for 1.0 that people can just descend from, and it
does most of the work for them.
So far, I'm not convinced that this approach meets that bar. I don't think
there's just one correct way to do it (I think people could just as easily
want their failed jobs emailed to them or removed entirely as they would
keeping them around in the same table). And in the event that somebody does
want to safely stash their failed jobs in the database, I think the example
I put together in the customizing Que document of how to move a failed job
to a separate table is concise and will work just fine, without adding any
complexity to the library itself. I might be wrong, we'll see how people
use it and respond to it in the future. But for now I think the better
answer is to just make the error and retry logic as flexible as possible
and see what people want to do with it.
On Mon, May 18, 2015 at 1:01 PM, Chris Sinjakli<EMAIL_ADDRESS>wrote:

Ah, that makes more sense. We're adding an audit job to detect any stale
non-retryable jobs left in the queue, and notify developers.
If it makes any difference - the default behaviour when running Que is
unchanged. Jobs are only marked as non-retryable if you implement a custom
failure handler, such as the ones we've released in Que::Failure.
—
Reply to this email directly or view it on GitHub
https://github.com/chanks/que/pull/106#issuecomment-103129968.

Done some more thinking on this. I don't feel like are goals are so far apart. While we chose the two failure handling strategies which we put in Que::Failure, our intention was to make the API used for that flexible.
There's no reason other users have to implement handle_job_failure the way we do. By default, they'll get the behaviour Que has always had. If they choose to, they can move the job to a secondary store like Redis, send an email and destroy the job, or store it in a non-runnable state in Postgres and send out an alert as we do.
That hook is the core of the changes we've made, and the bit which opens up these options. The extra migration facilitates the option of storing the job in Postgres in a non-runnable state. We're happy to reconsider what that storage looks like. There are certainly advantages to it being a separate table, and the only downside I can think of is that you need to wrap an INSERT/DELETE in a transaction.
If you'd rather that part lived separately to Que, we can rejig our PR. It'll be a bit tougher on our side as we're in production now, but nothing we can't figure out.

Hey, I'm glad. I made an error-handling branch last week and pushed a couple small additions to support custom retry logic to it (https://github.com/chanks/que/compare/error-handling). The paint's not really dry on it, I'd love some feedback. I don't know how different it is from what you have in mind. It basically implements the pseudocode I included in my second reply above.
I'm actually a little iffy on how it tries to use the same method to customize retrying and error reporting - the handle_error method can do whatever it wants to destroy or reschedule the job (there's now a retry_in method to specify an amount of time to wait for a retry), and the method's return value dictates whether the error_handler (renamed to error_notifier, for clarity) is called or not. I don't know whether this scheme is elegant or confusing, though. :stuck_out_tongue:
My plan is to work on it some more on Friday. I'll try to look at your code then and figure out what's missing and if this is a good direction to go in.

Sorry about the silence on this. Been working on other things.
I've just looked over the error-handling branch, and the per-job handle_error method (handle_job_failure in our code) is the main reason we created a fork of Que.
Our que-failure gem provides two modules which implement that method, and fit our use case. We kept them separate as we didn't feel they needed to be in Que itself.
I'm still interested in the concept of failed jobs which won't be automatically retried, and where that functionality belongs. In a way, it'd be nice if it were part of Que, and it was just another method you could call. Having it in Que would mean people didn't have to think about subtle tradeoffs like separate tables vs an extra column in the main table. This work can be done in a separate branch. It depends on the per-job failure handling, but doesn't have to be added at the same time.

We discussed an alternate system in #147 that was just released in version 0.12.0.


Add Chibuokem Egbuchulam to the list of names

For some reason I cannot merge this. Please check for conflicts and adjust.

I just checked and realized there was a conflict which I have been able to resolve


Fix Svelte dumps in development

These need to either be fixed, or ignored.

almost fixed. Waitin on a new version https://github.com/syntaxfm/website/pull/1421

These have all been cleaned up, can load the site without any warnings now.


Receiving error in pipeline

Hello,
Thank you for creating and sharing this software. I tried running the pipeline but am receiving an error after some time. Here's the traceback:
Traceback (most recent call last):
File "run_segment.py", line 183, in
main(args)
File "run_segment.py", line 102, in main
softmax = load_softmax(pred_softmax_path, volume_info_path)
File "/workspace/trustworthy-ai-fetal-brain-segmentation/src/deep_learning/inference_nnunet.py", line 34, in load_softmax
softmax_cropped = np.load(softmax_path)['softmax'][None][0,...]
File "/opt/conda/lib/python3.8/site-packages/numpy/lib/npyio.py", line 417, in load
fid = stack.enter_context(open(os_fspath(file), "rb"))
FileNotFoundError: [Errno 2] No such file or directory: '/data/M003/backboneAI/.npz'
Note: M003 is the subject directory. In the backboneAI folder, there are three files listed:

M004.nii.gz
M004.npz
M004.pkl

The error seems as though it's not able to find .npz. Would you know how this can be resolved?
Thanks,
Ramana

Okay, I figured this out. I put a forward slash ( / ) at the end of the output_folder. Once I removed this extra slash, it worked.
Keeping this here in case anyone else makes the same mistake


Ascii characters without a unicode mapping cause resource creation to fail

í
In a name causes resource creation to fail.  Fix this and add perhaps add some useful logging within resource creation.

see this one
#3324


Updated tests for security analytics

Description
Updated tests for security analytics
Check List

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Merge only one of the two, this or : https://github.com/opensearch-project/opensearch-dashboards-functional-test/pull/1087

@amsiglan Let us know when this is ready to merge

@amsiglan Let us know when this is ready to merge

@ashwin-pc Please go ahead and merge this


Playwright setup

Well that didn't work as expected.
There was no default browser set for the --project option, so it failed.


Confusion about input image types.

个人感觉：
照片(rgb,rgba): 90%，草图(手工简单绘制): 10%，这两种是比较自然的输入形态。
为什么要将depth(难道是3D sensor)，normal，canny, scribble这种作为输入呢？
Thanks

如果将“彩图”处理为“深度”等，丢失了大量的信息，作为条件，得到的大概率就是其他的类别了。
当然，还有可能就是训练集数据多样性不够，只能往见过的类别上靠。  多样性先验：现在一是objavese等，二是image2video，这两个见多识广。

Thanks for your question. Actually our work is the multi-view (MV)/3D scenerio of 2D ControlNet, which fills the gap between text- and image-to-MV/3D. In most of this scenerio, the user may want to generate a series of diverse assets of the same shape with an origin image (object) but of different content (textual description). And the shape is controlled by its corresponding depth map, canny edge, normal map, or scribble, which are easy to extract using pretrained models.

thanks, got it.
trend to 'diverse' generate.
but not 'copy-like' reconstrction.
thanks again.


[Bug][Framework] Report panic: interface conversion: interface {} is nil, not *helper.ListBaseNode

Search before asking

[X] I had searched in the issues and found no similar issues.

What happened
When I tried to use jenkins to collect jobs, it reported panic: interface conversion: interface {} is nil, not *helper.ListBaseNode
I found this is caused by pr #2401
@keon94 Please take a look at that, thanks
What you expected to happen
It should collect successfully
How to reproduce
just collect jenkins jobs
Anything else
No response
Version
main
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

@warren830 please run a quick test again and let me know if PR #2634 fixed it.


certificate_pem, _, _ = _do_request() missing items

The certificate_pem, _, _ = _do_request() has some items not working with the switch to v02 a ways back. Any way to easily get this back even if I have to change the code myself? I need it to install to cpanel automatically as the signed_chain.crt isn't enough on its own for the cpanel api. In particular, I need the second variable returned previously called result used in the following. Unless someone knows of a equal or better way to do this than mine. Thanks.
-    code, result = _send_signed_request(CA + "/acme/new-cert", {
-        "resource": "new-cert",
...
+    # download the certificate
+    certificate_pem, _, _ = _do_request(order['certificate'], err_msg="Certificate download failed")
    log.info("Certificate signed!")
-    return """-----BEGIN CERTIFICATE-----\n{0}\n-----END CERTIFICATE-----\n""".format(
-        "\n".join(textwrap.wrap(base64.b64encode(result).decode('utf8'), 64)))
+    return certificate_pem

https://github.com/diafygi/acme-tiny/commit/bb248e00125728e6f15806d6408ebd9ac5251cbf#diff-7d802cf8b579d90e224a041b9e054757a417bf1fc394fde3ea2db37d0fba3922

Got a non-implemented test working. Implementing what I need back again is apparently easy. Looks like the only way I have available just needs the first two blocks separately saved from the signed_chain.crt and is compatible with cpanel's uapi SSL install_ssl.
Whether or not you feel like that should be provided by this script or another is up to you. At the very least this info will be archived here.


Add yet another step in test.yaml - black formatting check.

Goal is to introduce yet another step in pipeline declared in test.yaml  that is checking proper black formatting.
Command to check:
black --check envcloak/

This command returns non zero code if code is not correctly formated and it should fail pipeline.

I believe this PR addresses the changes requested, however, I haven't run the Black formatter to see what changes need to be made to the rest of the repo to make the formatter pass and therefore not fail the pipeline.

Hi @Failte327 👋,
Thanks for contributing, I manually run black before each commit but this is rather "guardian of style" for PRs 😀.
Looks good to me, 👍


Selecting items without a mouse click does not update the lastShiftRoot and can cause an unhandled exception if the lastShiftRoot was deleted

Steps to reproduce the exception in the Demo app:

Select a node with a mouse click
Right click that node and delete it
Click the "Select some" button in the Selection section
Shift + click on any node
"Sequence contains no elements" exception is thrown because lastShiftRoot is still the node that was
deleted but SelectedItems.Count is > 0

Sounds reasonable, I'll look into it. This may take a while though.

Thank you very much for pushing a fix! Any chance you would be able to push an update to the NuGet package?

Oh yes, sorry, I forgot about that. It's now uploaded and should be available in a moment.


Inheritance mapping with null source

Hello
I am experiencing an error with an edge-case of inheritance mapping.
When mapping between two abstract classes, Mapster cannot handle when the source-object is null.
An example of this can be seen with the following code
using Mapster;

public class Program
{

   public abstract class DomainBase {}
   public abstract class DtoBase {}

   public class DomainDerived : DomainBase
   {
   	public int Number { get; set; }
   }

   public class DtoDerived : DtoBase
   {
   	public int Number { get; set; }
   }

   public static void Main(string[] args)
   {
   	TypeAdapterConfig.GlobalSettings.NewConfig<DomainBase, DtoBase>()
   		.TwoWays()
   		.Include<DomainDerived, DtoDerived>();

   	DtoBase dto = null;
   	DomainBase mapped = dto.Adapt<DtoBase, DomainBase>();

   }
}

where Mapster will complain that instantiating DomainBase is not possible.
Using ExpressionDebugger to show the mapping logic, i can see why this is a problem - see generated script below.
public Program.DomainBase Main(Program.DtoBase p1)
{
    Program.DtoDerived p2 = p1 as Program.DtoDerived;

    if (p2 != null)
    {
        return p2 == null ? null : new Program.DomainDerived() {Number = p2.Number};
    }
    throw new InvalidOperationException("Cannot instantiate type: DomainBase");
}

Is this intended behavior or a small bug?
To me it seems that returning null could be a sane solution - but maybe some more logic is needed.
If anyone knows a workaround or something of the sorts, advice is appreciated.
It should be avoidable with null-checks but that gets ugly fast.
Thank you for maintaining this project!

It is not clear what do you want to do in the first place. Add a use case, please.
Make DomainBase not abstarct if you want to adapt from DerivedDto to DomainBase, like:
DomainBase mapped = dto.Adapt<DtoDerived, DomainBase>();
or you can do
DomainBase mapped = dto.Adapt<DtoDerived, DomainDerived>();
I am not sure that passing null to adapt as a source is a Mapster problem.

Thank you for the reply.
I will try to elaborate my use case as well as i can.
Essentially i have two abstract classes (one domain and one dto) like in the example, but they both have several inheritors.
They are used in a method that takes an object of (my equivalent of) DtoBase and returns a type that contains several others, one of them being DomainBase.
For this reason, i cannot just make any of the classes concrete.
Regarding whether it is a Mapster problem to handle null source objects, this is indeed some of what my original question tries to understand. However, it seems that this is handled fine in other cases e.g. when mapping directly between two concrete classes.
When using the following syntax, "mapped" is just null.
DtoBase dto = null;
var mapped = dto.Adapt<DomainBase>();

but that produces an exception on runtime if dto is an actual instance of a subclass.
Experiencing that led me to read the docs where i found out about the syntax that gives two type arguments to Adapt, which works fine in all cases except for when source is null.
I hope that this make it more clear.

DtoBase dto = null;
var mapped = dto.Adapt();

but that produces an exception on runtime if dto is an actual instance of a subclass. Experiencing that led me to read the docs where i found out about the syntax that gives two type arguments to Adapt, which works fine in all cases except for when source is null.

I hope that this make it more clear.

I think that is a bad design. Although it is perfectly fine to call extention methods on null references in C# you should never do that. If your business logic implies that there are nulls then handle them in your code.


Missing characters

In trying to use this library, we found it was truncating the values from the binlog and we didn't take the time to figure out why.  Switched to using: https://github.com/siddontang/go-mysql instead.

@drasch Hello. Can you give example of query where missing characters? Thank you

The last character of strings were truncated.   This is fixed in some of
the forks of the repo, we found.
On Jun 4, 2016 03:39, "Pavel <Ven> Gulbin"<EMAIL_ADDRESS>wrote:

@drasch https://github.com/drasch Hello. Can you give example of query
where missing characters? Thank you
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/2tvenom/myreplication/issues/1#issuecomment-223742136,
or mute the thread
https://github.com/notifications/unsubscribe/AANhpSLahWVTR-3pXYgA7TKsRIgLK6wPks5qISupgaJpZM4IuADm
.

@drasch please make pull request

@drasch About https://github.com/siddontang/go-mysql ， if I use this library, can we dump this record detail if we insert a line?
@2tvenom  there are some mistakes when I dump the values from the binlog,  the type of uint8 is always wrong.
some log is as bellow:
BEGIN
Write t_live2odv2_kuwo
uint32 0 0 3 40
string 0 1 254 8e9addd82febf91d0fffead1760b5001
string 0 2 15
string 0 3 254
uint8 0 4 150   -----------this type is uint8 and the actual value is 0, but log always print 50, I do not know why


Revert "[flow] no-unused-modules: add flow type support"

#1542 was intended to fix issue #1540 but introduced a more critical issue, #1564. In my case, it blocks upgrading to the latest version with all the fancy features like alphabetical sorting.
This PR just reverts it
Fixes #1564. Reopens #1542.

Coverage decreased (-0.001%) to 97.738% when pulling a1e9dc0391e72a25d07234a8c103cf785d0c6c57 on Hypnosphi:revert-flow-types into 92caa3594e0f8d7bf143dedba0c7c2b47b541f34 on benmosher:master.


Any workable example of exporting  and inferencing with GPU?

System Info
Been tried many methods, but never successfully done it. Thanks.

Who can help?
No response
Information

[ ] The official example scripts
[ ] My own modified scripts

Tasks

[ ] An officially supported task in the examples folder (such as GLUE/SQuAD, ...)
[ ] My own task or dataset (give details below)

Reproduction
model = ORTModelForSequenceClassification.from_pretrained(model_checkpoint, from_transformers=True)
tokenizer = AutoTokenizer.from_pretrained(model_checkpoint)
model.save_pretrained(save_directory, file_name=file_name)
tokenizer.save_pretrained(save_directory)

optimization_config = OptimizationConfig(optimization_level=99, optimize_for_gpu=True)
optimizer = ORTOptimizer.from_pretrained(
    model_checkpoint,
    feature="sequence-classification",
)

optimizer.export(
    onnx_model_path=onnx_path,
    onnx_optimized_model_output_path=os.path.join(save_directory, "model-optimized.onnx"),
    optimization_config=optimization_config,
)```

### Expected behavior

NA

solved./


Formating don't work for module under the #[cfg(feature = "test_feature")]

I noticed that formating of file don't work for module under the #[cfg(feature = "test_feature")] macro.
#[cfg(feature = "test_feature")]
pub mod module1;

[package]
name = "package"
version = "0.1.0"
edition = "2018"

[features]
default = []
test_feature = []

Code in module1 won't be formatted ... at the same time, analyzer shows errors in this module.
I'm not sure if this is an analyzer issue, maybe is rustfmt issue?

I fixed it, that was issue with another crate.


Improve Drag and Drop of Components

Describe what problem your feature request solves:

I have to select the text of a component in the components view in order to drag and drop it into the canvas.
It is not possible to drag and drop by clicking other parts of the component.
Environment
Version 2.2
Windows 11
Desktop App
4K Monitor
Describe the solution you'd like:

I want to select any part of the component for drag and drop.
Additional context:

The is behavior inherited from the AntV/X6 drawing package. When we tried to change it the rubberbanding stopped working, but it may be worth trying again, or it may be solved when the migration to AntV/X6 happens ( see #722 )
planning for version 2.4 due for release in Q4 2024

For me personally, it's not too important. Reported it in case it's a low hanging fruit.

does not apply to process, trust boundary box or trust boundary curve
only applies to actor, store and data flow
not sure why, but probably means there is a fix


Add TPS (1m, 5m, 15m) and MSPT to ServerHealth using Paper API

Uses the existing TPS data from org.bukkit.Bukkit which includes 1m, 5m and 15m (instead of just 1m) and also average MS per tick. Probably better to use the existing implementation for this than implementing it again in Lag(). I also moved these metrics to ServerHealth instead of Server.

@jegt can you add a description to the PR? What problem does this solve, why is it better than the existing Lag() code etc. Thank you!

@phybros Added a description. Hope this is clearer.

This PR would alienate any non-Paper users... hard pass from me. While Paper is certainly popular, not everyone who runs a Bukkit API-compatible server will be running a Paper one.
The old Lag code needs to stay in place as a fallback.

I can understand that you want to keep it backward compatible.  I'm not sure exactly how to make it compatible with non Paper servers since I need to specify the new Paper API in pom.xml. Its been 10+ years since I did any Java coding =)

Doesn't spigot also have a TPS API?

@matteoturini  No it seems to only be available for Paper.

Just looked it up, and you can use NMS and Reflection to get the TPS. Seems better than Paper API.

Unfortunately I don't have the time to do that. I guess I will just have to maintain this branch for my own use.


Download does not complete

When trying to download an album,
it is not completely downloaded,
since songs that cannot be downloaded,
and when retrying the problem persists

Please follow our issue templates when reporting bugs or requesting features.
The devs put in hours of effort, and you should show enough respect to put in a few minutes & follow the template.
Following the template also provides us all the information we need, without having to ask for it.
Closing. Please create a new issue following the template if you would like assistance.

Please follow our issue templates when reporting bugs or requesting features.
The devs put in hours of effort, and you should show enough respect to put in a few minutes & follow the template.
Following the template also provides us all the information we need, without having to ask for it.
Closing. Please create a new issue following the template if you would like assistance.


Implements SetCursorColor

Summary of the Pull Request
Implements the SetCursorColor VT sequence

References
Relevant to #7102

PR Checklist

[X] Closes #7102
[ ] CLA signed. If not, go over here and sign the CLA
[ ] Tests added/passed
[ ] Documentation updated. If checked, please file a pull request on our docs repo and link it here: #xxx
[ ] Schema updated.
[ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Validation Steps Performed
Cursor color changes, cannot reproduce the issue

I'm missing something here... this is the handler for the color setting in the terminal and the interface... but where's the dispatch? Was it already implemented and the default from the VT parser/adapter nullrouted it to do nothing and return true?

I believe so - ITermDispatch.hpp has a list of VT sequence declarations but many of them (including SetCursorColor before this PR goes through) don't have implementations anywhere.

Was it already implemented and the default from the VT parser/adapter nullrouted it to do nothing and return true?

YUP

Was it already implemented and the default from the VT parser/adapter nullrouted it to do nothing and return true?

YUP

WELP. OKAY THEN.


Refactoring  class ColumnSchema and added class ColumnExtendedSchema

Q
A

Is bugfix?
❌

New feature?
✔

Breaks BC?
✔

Fixed issues

For the ColumnSchema.php class, all setters have a set added.

For class ColumnSchema.php added fields $schemaName, $tableName;

For the ColumnSchema.php class, the setters for the properties field $name are removed, their setting has been moved to the constructor.

Added class ColumnExtendedSchema:

class ColumnExtendedSchema extends ColumnSchema
{
    private ?int $maxChars = null;
    private ?int $maxBytes = null;
    private ?string $charset = null;
    private ?string $check = null;

    ...
}

It would be nice if components like gii could request this information to better generate models. Not all drivers will be able to give this information, but it is better to make it common so that components like gii would not think about what driver is.
PS: If the PR is accepted, I will PR for other packages that used these setters.

closed due to inactivity


[WIP] Minor fixes

Unselect all pods when a codeNode or richNode is focused.
Enlarge the difference when comparing the position value. Number.EPSILON is too small.

Update:
Enable debug mode for richNode, clean up the hard code hacking of disabling selection on focus for richNode (because it is solved in the latest reactflow by default, we no longer need to listen to keyboard event).
Known issues:

I suggest moving toggles in "site settings" into the right-click menu to make the sidebar looks more light.
nodes are re-rendered every time their position changes because xPos and yPos changes, causing a lot of overhead, which is even worse in richNode because we don't memo the editor.

Let's solve them in the future work if necessary.


Examine TaskLogEntry database table size

Lots of repetitive code related to logging. Should be condensed.

Reworking this issue: the actual contents are probably fine (we have to take a snapshot of the PSA JSON, because they don't keep it on their side); just double-check the database space being used.


Reduce the example size and update mbed-os version

Reduce the example size and update mbed-os version
CC @SenRamakri @anotherbutler

@SenRamakri Whenever you get a chance, could you please review this from a content perspective?


Add socialMediaURLs to Mural model

Summary
Added socialMediaURLs field to mural model as a string array.
Fixed inconsistency in imgURLs (?)
I noticed imgURLs was typed as an array in the export but as a single string in the init and interface. I changed the typing to be a string array everywhere as the prototype in #66 shows that the gallery can contain multiple images.
Test Plan
No additional tests were added. All tests still pass.
Related Issues
#70 #66

Thanks for catching the imgURLs inconsistency

Thanks for catching the imgURLs inconsistency


Improve temporal type handling

part of: https://github.com/creek-service/creek-kafka/issues/463

Instant now serialized as string, inline with Jackson, with date-time format
LocalTime no longer marked as time format, as serialized form is missing offset.
OffsetTime now supported: string with time format
OffsetDateTime now supported: string with date-time format
MonthDay now supported: string
YearMonth now supported: string
Year now supported: string
Duration now supported: number, inline with Jackson
Period now supported: string with duration format, inline with Jackson

The changes to how Instant and LocalTime are handled are breaking changes, but as they were incompatible with Jackson, this is seen more as a bugfix.

coverage: 93.704% (+0.2%) from 93.511%
when pulling 7f184b26b92d627a04db6a35957a5a0daa0577e7 on temporal-types
into e434ddb405a28ee530f6a72524978f93a687e301 on main.


186811130 enable sort work listeners

This makes it so we only start listening to offering users' personal doc changes if a sort-work tab is specified for the unit we are in, as described in PT-186811130

@bacalj , is there any obvious way I can test this apart from the performance boost for non-sort-work-enabled units?

@bacalj , is there any obvious way I can test this apart from the performance boost for non-sort-work-enabled units?

@tejal-shah I think the only other test would be to ensure that it continues to work for a teacher using 'example-config-suntans'


Support prompt in addition to approval-prompt

Fix #380 - add the config option prompt in addition to the legacy approval-prompt.
Description
Add and use a new config option. If present, ignored the old approval-prompt option.
To be able to see whether prompt has been provided, I default it to "" (thus I know that if p.Prompt != "" the user has explicitly provided it and it is safe to not be backwards-compatible and to ignore the old approval-prompt).
Ideally, we would default prompt to "login" (or perhaps "consent"?) but we would then have no way of knowing whether to send prompt or approval-prompt.
Alternatively, we could default it to "login" and simply send both prompt (ignored by older providers) and approval-prompt (ignored by newer providers). However this assumes that all providers are sane and only take one of these options and do not error or do something weird when provided with both. Can we risk it?
Motivation and Context
See #380. I have not been able to track down where approval-prompt originates from. OIDC 1.0 only mentions prompt. I have not been able to find out anything related in the oauth 2 core spec. (Even https://www.iana.org/assignments/oauth-parameters/oauth-parameters.xhtml only mentions prompt.)
How Has This Been Tested?
Running the proxy, accessing it with an unauthenticated users, and verifying the redirect URL. I have tested these cases:

Config
Redirect contained
Why?

none
approval_prompt=force
Same default as before

-prompt login
prompt=login
-prompt works, replaces approval_prompt

-approval-prompt xxxx
approval_prompt=xxxx
-approval-prompt works

Checklist:

[x] My change requires a change to the documentation or CHANGELOG.
[x] I have updated the documentation/CHANGELOG accordingly.
[x] I have created a feature (non-master) branch for my PR.

@JoelSpeed Thx, conflict fixed

Thanks @holyjak


fix: reconnect after all idle connections close

When all connnections attached to the connector closed then the spanner
client and admin client was closed. This is a problem, because the
database may still hold on to the connector and may want to make new
connections.
This changes the logic such that the connector can reconnect the client
when necessary.

@egonelbre I made a small change to this PR, as removing/adding the connector from the map of driver connectors when all connections were closed caused some flaky test failures, probably due to underlying connections being closed right at the same time as that a new connection was being requested for the same connector.
Instead, I've added a Close() method to connector, so it now implements the Closer interface. This method will automatically be called when Database.Close() is called, and this method removes a connector from the map of active connectors.


put an example and some sample usage shell session

put an example and some sample usage shell session

done


Cannot Modify or Change the Application Gateway Associated Rule under Listeners.

[Enter feedback here]
This page does not show how to assign "Associated Rule" and shows that it's already set.
The problem is and it's a major oversight on the documentation is you never show how
to update or change the associated rule using powershell.  In fact, using the portal if you
create a new rule and listener there is no option to manually assign the assocated rule column.
This has been a major slowdown for our team.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 77782ee2-e389-8851-3061-02a8f70aeb41
Version Independent ID: ade812e5-f5a9-348a-a022-94c5966e87e7
Content: Azure Application Gateway listener configuration
Content Source: articles/application-gateway/configuration-listeners.md
Service: application-gateway
GitHub Login: @vhorne
Microsoft Alias: surmb

An "Associated Rule" column is available in the Azure Portal, but I cannot find any powershell support for modifying this column setting.  At the very least you should have a -AssociatedRule switch as part of the Set-AzApplicationGatewayHttpListener command or something similar.  As it stands now, i believe most people struggle with updating or modifying the Associated Rule.

Hello @coffeebeantraining
Thank you for your feedback! We have assigned this issue to the author to review further and take the next course of action.

Thanks!
I looked over this document: https://github.com/Azure/azure-powershell/blob/main/src/Network/Network/help/Set-AzApplicationGatewayRequestRoutingRule.md
and, there is only one spot where one could possibly figure out how to update the Associated Rule column under Example 1: Update a request routing rule.
I think very few people would be able to figure out how to do it based on that example or even find the example in the first place.
Thanks,
Mark

I am closing issues that have not been updated in over a year. I will cross reference and research them individually. I am recording each issue and compiling a list of articles to review. If you feel there is an urgent need to address something related to this GitHub issue, please open a new issue and I will reply in the new thread. Please also reference this GitHub issue number in the new issue. Thanks. #please-close


Add pod stats

Add a way to display the number of contributions between fellows. Make a little leaderboard or similar to motivate people to add new issues!

@wrussell1999 @NoahCardoza can you assign me this issue.


Bugfix in apache httpd

Motivation for this change
This fixes an inconsistency when the attribute name doesn't match the hostName.
See https://github.com/NixOS/nixpkgs/pull/96910#discussion_r481358226
@aanderse
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

ping @arianvp I haven't looked but does nginx suffer the same problem here?

@mohe2015 please follow CONTRIBUTING.md for the commit message: nixos/httpd: respect hostName when provisioning certificates, or something like that.

@mohe2015 please follow CONTRIBUTING.md for the commit message: nixos/httpd: respect hostName when provisioning certificates, or something like that.

I can only do that in about 12 hours - feel free to just do it yourself if you want. I don't need the attribution in this case.

@mohe2015 please follow CONTRIBUTING.md for the commit message: nixos/httpd: respect hostName when provisioning certificates, or something like that.

Done. Hope this is fine now.

@mohe2015 great! Thanks!

https://github.com/NixOS/nixpkgs/blob/master/nixos/modules/services/web-servers/nginx/default.nix#L775 nginx seems fine.

Maybe don't merge in favor of https://github.com/NixOS/nixpkgs/pull/91121?

@mohe2015 sorry, this is obviously on me. I was aware of that PR, but missed the certificates part... Sorry :bow: How about we leave this open until #91121 is merged?

It's up to you people - the change in https://github.com/NixOS/nixpkgs/pull/91121/files#diff-67cf2394795df903410ca0d6de1fa388R658 is a little bit different but I don't know what's the actual difference. I just don't want to prevent getting #91121 merged quickly. But it seems like it may not make it into 20.09 so getting this in may be benefical.

It's up to you people - the change in https://github.com/NixOS/nixpkgs/pull/91121/files#diff-67cf2394795df903410ca0d6de1fa388R658 is a little bit different but I don't know what's the actual difference. I just don't want to prevent getting #91121 merged quickly. But it seems like it may not make it into 20.09 so getting this in may be benefical.

I looked at this a day ago and I think the only difference is that I used builtins.map instead of mapAttrs', as to match the nginx code. The functionality is the same.

Congrats for getting the other or merged!

Thanks Moritz :D
On Mon 7 Sep 2020, 12:44 a.m. Moritz Hedtke<EMAIL_ADDRESS>wrote:

Congrats for getting the other or merged!
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/NixOS/nixpkgs/pull/96923#issuecomment-687935962, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAXHIVWY4QQZNCWQTM66X2LSEQNELANCNFSM4QSFHGKQ
.


chore: update repo by service bot

This is a routine update from cc-service-bot based on the service.yml in your repo. This PR
should be approved and merged as soon as CI passes.

CHANGELOG
FILE NAME - CHANGED BY - COMMIT MESSAGE
Makefile - framework - chore: update repo Makefile cc-mk-include v0.1188.0
cc-mk-include/compare/v0.1187.0...v0.1188.0


Add Haaf's Game Engine

SteamDB app page links to a few games using this

Global Soccer: A Management Game 2017
Global Soccer: A Management Game 2017 Demo
Global Soccer: A Management Game 2018
Global Soccer: A Management Game 2019
Murder On The Island

Brief explanation of the change
Find Haaf's Game Engine by it's dll file.

After running changed rules in this pull request (this bot only tests rules.ini changes):
Changed technologies: Engine.HGE
These apps now match: (58) 38190 41100 41110 49600 49610<PHONE_NUMBER>80<PHONE_NUMBER>50<PHONE_NUMBER>70<PHONE_NUMBER>70<PHONE_NUMBER>00<PHONE_NUMBER>70<PHONE_NUMBER>90<PHONE_NUMBER>60<PHONE_NUMBER>20 1052550 1052560 1058940 1158260 1207310 1381730 1422780 1428040 1437120 1460870 1471470 1605290 1738870 1740260 1740340 1747800 1882730 2086820 2285860 2309890 2314790 2314980 2316690 2330320 2330990 2338130 2339550 2364390 2376070 2416720 2541070 2584630 2622750 2800440 3006320
Please confirm that all these changed apps are correct.

Nevermind.

hey, why'd you close this PR? I've checked DLLs on some demos/free games and they all seem to be this engine, so is there any reason for it being closed?


zh, en: add is-sharding config item

First-time contributors' checklist

[ ] I've signed Contributor License Agreement that's required for repo owners to accept my contribution.

What is changed, added, or deleted? (Required)
add missing config item

Which DM version(s) do your changes apply to? (Required)

[x] master (the latest development version)
[x] v2.0 (TiDB DM 2.0 versions)
[ ] v1.0 (TiDB DM 1.0 versions)

What is the related PR or file link(s)?

This PR is translated from:
Other reference link(s):

Do your changes match any of the following descriptions?

[ ] Delete files
[ ] Change aliases
[ ] Need modification after applied to another branch
[ ] Might cause conflicts after applied to another branch

is-sharding has lower priority than shard-mode, maybe we could only address shard-mode has three values and default is ""

is-sharding seems like a prerequisite for shard-mode. I don't understand why is-sharding has lower priority than shard-mode. So three values seem a little bit confusing to me. @lance6716

is-sharding seems like a prerequisite for shard-mode. I don't understand why is-sharding has lower priority than shard-mode. So three values seem a little bit confusing to me. @lance6716

currently is-sharding is an alias for shard-mode = "pessimistic" if not set shard-mode, and shard-mode is the actually setting that takes effect. is-sharding is a historical field which in my mind it should be deprecated. 🤔

is-sharding seems like a prerequisite for shard-mode. I don't understand why is-sharding has lower priority than shard-mode. So three values seem a little bit confusing to me. @lance6716

currently is-sharding is an alias for shard-mode = "pessimistic" if not set shard-mode, and shard-mode is the actually setting that takes effect. is-sharding is a historical field which in my mind it should be deprecated. 🤔

PTAL~ @GMHDBJD


Cosmos DB: Add schema inference

This PR enables schema inference on the connector. Inference is achieved by sampling a number of documents from the source collection and used them to define the schema.
Schema inference kicks in if the user does not explicitly define the schema when performing a read
New configurations

spark.cosmos.read.inferSchemaSamplingSize: Defines the sampling size (default 1000)
spark.cosmos.read.inferSchemaEnabled: Disables or enables schema inference (default disabled)

If spark.cosmos.read.inferSchemaEnabled is disabled ("false") and the user did not specify a schema, a simple default schema is generated which contains:

_ts field for the timestamp value (LongType)
id field (StringType)
_rawBody field, which when ran through the RowConverter, contains the raw json for the whole document (StringType)

This is useful in cases where the raw Json is expected to be sent somewhere else.
If spark.cosmos.read.inferSchemaEnabled is enabled ("true") and the user did not specify a schema, then the documents from the source will be sampled in order to infer one.
Schema is defined as a list of unique fields and types used across all sampled documents. For example, if the source contains:
{
    "field1": "aString"
},
{
    "field2": 10
}

Then the schema will have both fields, one as a StringType, the other as an Integer type. When the Rows are generated, each one will have a null value on the missing attribute.
Tests
Added Specs for the new inference code, some new tests for the Converter to cover raw json conversion, and E2E with inferSchemaEnabled = false
Closes #18152

great work.
Could you please also add a basic end to end test for utilizing schema inference in the following files:

SparkE2EQuerySpec
SparkE2EWriteSpec

Thanks @moderakh, I addressed your rename comments and also added more tests, to SparkE2EQuerySpec. SparkE2EWriteSpec is not affected.

great work.
Could you please also add a basic end to end test for utilizing schema inference in the following files:

SparkE2EQuerySpec
SparkE2EWriteSpec

Thanks @moderakh, I addressed your rename comments and also added more tests, to SparkE2EQuerySpec. SparkE2EWriteSpec is not affected.


[HOTFIX] CLI test case failed during release because of space differences

CLI test case is failed if the release name is short and without snapshot, it adds more space .
That's why changed test check the individual contains instead of a batch of lines
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:

[ ] Any interfaces changed?

[ ] Any backward compatibility impacted?

[ ] Document update required?

[ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.1/192/

LGTM..merging as only CLI test case is changed

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.2/186/

Build Success with Spark 2.3.2, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/190/


Migrations not running

New phinx user. Hoping someone can help.
I've installed with composer in Windows. I created a migration class, but migrations don't run and none are listed under pending.
$ vendor/bin/phinx migrate -e development
Phinx by CakePHP - https://phinx.org. 0.10.8

using config file .\phinx.php
using config parser php
using migration paths
 - C:\xampp\htdocs\pixapad\db\migrations
using environment development
using adapter mysql
using database pixapad_local

At that point it just hangs. I have to use Ctrl+Break to exit.
No migrations show up with the status check:
$ vendor/bin/phinx status -e development
Phinx by CakePHP - https://phinx.org. 0.10.8

using config file .\phinx.php
using config parser php
using migration paths
 - C:\xampp\htdocs\pixapad\db\migrations
using environment development
ordering by creation time

 Status  [Migration ID]  Started              Finished             Migration Name
----------------------------------------------------------------------------------

Again, it hangs.
Here's my migration script (/db/migrations/20190806193906_page_table.php):
{
    public function change()
    {
        $tableName = 'page';

        $exists = $this->hasTable($tableName);
        if (!$exists) {
        // create the table
            $table = $this->table($tableName);
            $table->addColumn('PageHtml', 'text')
                  ->addColumn('DateCreated', 'datetime')
                  ->addColumn('name', 'varchar', ['limit' => 100])
                  ->create();
        }
    }

    /**
     * Migrate Up.
     */
    public function up()
    {

    }
}

On a whim, I tried vendor/bin/phinx create PageTable but Phinx advised the migration class already exists. I'm not sure what to check next.
Suggestions?

@paulmiller3000 Was the phinxlog table created in your database "pixapad_local". If not can you make sure credentials are valid

@paulmiller3000
also
->addColumn('name', 'varchar', ['limit' => 100])
should be
->addColumn('name', 'string', ['limit' => 100])

@paulmiller3000 Was the phinxlog table created in your database "pixapad_local". If not can you make sure credentials are valid

Well, chalk another one up to user error! Credentials were right, but your suggestion prompted me to check my other entries. Turns out I'd set my database port to 81 instead of the correct database port of 3306.
Oops. Fixing that corrected my issue.
I also updated the addColumn statement per your guidance.
Thank you!


License?

Could you upload the license of this repository?

@zhenheny

Hi,
I just updated the license file.


IME Candidate Word Box Error

Describe the bug
On Windows 7, I encountered an issue where the Input Method Editors candidate word box cannot be located. Regardless of the search bar, webpage input box, search, and other places where input can be made, the input method candidate word box will default to the top left corner of the browser and will not change position with character input. Tested to be normal on Chrome and other Chromium browsers.
The similar problem: https://github.com/win32ss/supermium/issues/118
The attachment is an IME application that can be used for verification.
Please help to see how to solve it, thank you.
To Reproduce
Steps to reproduce the behavior:

Install the IME （unzip ‘Sample__IME1.zip’ files, run registry.exe, and click the ‘升级极点’ button）
Open browser ， switch to the installed IME
Input some keys.
See error

Expected behavior
The IME candidate word box will default to the top left corner of the browser and will not change position with character input.  And the box position will not change, always on the top left. I guess the pos is set to (0, 0) ?
Screenshots

Desktop (please complete the following information):

OS: Windows 7
Browser version: v122 R6

Offline IME program
Sample__IME1.zip
Sample__IME2__Setup.zip

Thank you for providing a sample application. In the previous case, I was unable to find any Google IME application that had this bug, only new ones that didn't..
In this case it appears that the Baidu IME does not work too well with the TSF API, but works better with the IMM32 one instead. So I will move the cutoff for IMM32/TSF from Vista to Windows 8. The switch --disable-features=TSFImeSupport can also be used to disable TSF in favour of IMM32.


HBASE-25362 Fix quoting in hbase-vote to avoid voting build failures

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
2m 34s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
shelldocs
0m  1s
Shelldocs was not available.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 34s
Maven dependency ordering for branch

_ Patch Compile Tests _

+0 :ok:
mvndep
0m  8s
Maven dependency ordering for patch

-0 :warning:
shellcheck
0m  1s
The patch generated 4 new + 0 unchanged - 0 fixed = 4 total (was 0)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

FYI @ndimiduk @taklwu
Btw the shell check is calling out the lines I changed saying they should be double quoted, but I'm not sure how to make that actually work since with the double quotes it fails for me.

Maven properties should be an array and then it should be included as an expanded array, i.e. "${MVN_PROPERTIES[@]}"

Maven profiles too

Bah, sorry I didn't see this one and instead filed HBASE-25369 / #2746 . I think @busbey 's proposed solution is more correct than my eval solution.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
shelldocs
0m  1s
Shelldocs was not available.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for branch

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

-0 :warning:
shellcheck
0m  1s
The patch generated 4 new + 0 unchanged - 0 fixed = 4 total (was 0)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
shelldocs
0m  0s
Shelldocs was not available.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m  8s
Maven dependency ordering for branch

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

-0 :warning:
shellcheck
0m  0s
The patch generated 4 new + 0 unchanged - 0 fixed = 4 total (was 0)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

Should be good to review now.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
shelldocs
0m  0s
Shelldocs was not available.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 10s
Maven dependency ordering for branch

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

-0 :warning:
shellcheck
0m  1s
The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
shelldocs
0m  0s
Shelldocs was not available.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 10s
Maven dependency ordering for branch

_ Patch Compile Tests _

+0 :ok:
mvndep
0m  8s
Maven dependency ordering for patch

+1 :green_heart:
shellcheck
0m  2s
There were no new shellcheck issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

_ Other Tests _

+0 :ok:
asflicense
0m  0s
ASF License check generated no output?

3m 46s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2737/5/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2737

Optional Tests
dupname asflicense shellcheck shelldocs

uname
Linux ecefdeef4286 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / fb6e498b32

Max. process+thread count
43 (vs. ulimit of 30000)

modules
C:  U:

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2737/5/console

versions
git=2.17.1 maven=3.6.3 shellcheck=0.4.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

I think this isn't right either, @z-york .
$ caffeinate env JAVA_HOME=/Library/Java/JavaVirtualMachines/adoptopenjdk-11.jdk/Contents/Home bash -x ~/repos/apache/hbase/dev-support/hbase-vote.sh --source 'https://dist.apache.org/repos/dist/dev/hbase/2.4.0RC1/' -D hadoop.profile=3.0
...
+ cd hbase-2.4.0
+ execute rat_test
+ rat_test
+ rm -f /Users/ndimiduk/tmp/hbase-2.4.0RC1/2.4.0RC1_rat_test
+ mvn clean apache-rat:check '-D hadoop.profile=3.0 '
+ tee /Users/ndimiduk/tmp/hbase-2.4.0RC1/2.4.0RC1_rat_test
[INFO] Scanning for projects...
[ERROR] [ERROR] Some problems were encountered while processing the POMs:
[ERROR] 'dependencies.dependency.version' for org.apache.hadoop:hadoop-mapreduce-client-jobclient:test-jar is missing. @ line 224, column 17
[ERROR] 'dependencies.dependency.version' for org.apache.hadoop:hadoop-hdfs:test-jar is missing. @ line 248, column 17
[ERROR] 'dependencies.dependency.version' for org.apache.hadoop:hadoop-minikdc:jar is missing. @ line 228, column 17

Looks like the -D argument isn't being passed to maven correctly... maybe that trailing space is causing issue?

Weird, it was working when I tested it before, but must have been broken by some of the shellcheck changes I did. Let me dig in.

Looks like the -D argument isn't being passed to maven correctly... maybe that trailing space is causing issue?

Yup, looks like when I switched it to +=() it is now correctly passing in the string (where it wasn't before ;) ) so the space is no longer necessary

UNIT_TEST_PASSED=1
popd
~/workspace/apache/rctest
print_when_exit
cat
++ (( SIGNATURE_PASSED ))
++ echo ok
++ (( CHECKSUM_PASSED ))
++ echo ok
++ (( RAT_CHECK_PASSED ))
++ echo ok
++ (( BUILD_FROM_SOURCE_PASSED ))
++ echo ok
++ (( UNIT_TEST_PASSED ))
++ echo ok
* Signature: ok
* Checksum : ok
* Rat check (1.8.0_92): ok
- mvn clean apache-rat:check -D skipTests -D hadoop.profile=3.0
* Built from source (1.8.0_92): ok
- mvn clean install -DskipTests -D skipTests -D hadoop.profile=3.0
* Unit tests pass (1.8.0_92): ok
- mvn package -P runSmallTests -D skipTests -D hadoop.profile=3.0 -Dsurefire.rerunFailingTestsCount=3
(( CHECKSUM_PASSED ))
(( SIGNATURE_PASSED ))
(( RAT_CHECK_PASSED ))
(( BUILD_FROM_SOURCE_PASSED ))
(( UNIT_TEST_PASSED ))
exit 0

Passed in skipTests for speed, it looks like everything got passed correctly.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 50s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for branch

_ Patch Compile Tests _

+0 :ok:
mvndep
0m  8s
Maven dependency ordering for patch

_ Other Tests _

2m 16s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2737/6/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2737

Optional Tests

uname
Linux e578d698d06c 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / fb6e498b32

Max. process+thread count
45 (vs. ulimit of 30000)

modules
C:  U:

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2737/6/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  9s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
shelldocs
0m  0s
Shelldocs was not available.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m  7s
Maven dependency ordering for branch

_ Patch Compile Tests _

+0 :ok:
mvndep
0m  6s
Maven dependency ordering for patch

+1 :green_heart:
shellcheck
0m  0s
There were no new shellcheck issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
shelldocs
0m  0s
Shelldocs was not available.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for branch

_ Patch Compile Tests _

+0 :ok:
mvndep
0m  9s
Maven dependency ordering for patch

+1 :green_heart:
shellcheck
0m  1s
There were no new shellcheck issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

_ Other Tests _

+0 :ok:
asflicense
0m  0s
ASF License check generated no output?

3m 36s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2737/7/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2737

Optional Tests
dupname asflicense shellcheck shelldocs

uname
Linux 1bee38db033a 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 56dd3eba81

Max. process+thread count
44 (vs. ulimit of 30000)

modules
C:  U:

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2737/7/console

versions
git=2.17.1 maven=3.6.3 shellcheck=0.4.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


Preview without borders

Repeat step：
1：Set solid mode
2：input red = 255, green 255, blue = 255
Bug cause:
Because code spaces in  p === 'rgba(255,255,255, 1)' and rgba(${newVal}, ${g}, ${b}, ${a})  is different

#118

@Qiu-Jun thank you for creating the PR, I will merge now


Parameter panelId is actually paneId in AppSidePane class

Parameter panelId is actually paneId (no "l") in AppSidePane class

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3ade424d-c9be-9c91-e40f-f1f0a1900572
Version Independent ID: 0e680fea-adb3-f241-61ab-c320759344b1
Content: AppSidePane (Client API reference) in model-driven apps - Power Apps
Content Source: powerapps-docs/developer/model-driven-apps/clientapi/reference/xrm-app-appsidepane.md
Service: powerapps
GitHub Login: @adrianorth
Microsoft Alias: jdaly

@phyle
Thanks for letting us know.
I've fixed this and it will be live by this evening.


[Federation] Document simplified federation control plane deployment via kubefed.

Documentation for https://github.com/kubernetes/features/issues/97.
cc @kubernetes/sig-cluster-federation @nikhiljindal @irfanurrehman @shashidharatd

This change is

cc @kubernetes/docs

I took a quick look and looks good to me.

Just couple nits. Feel free to apply the label once fixed.

Just couple nits. Feel free to apply the label once fixed.

Oops, seeing this now. Adding the label.

Awesome, thanks. This one looks good to go.


restoring the ability of reverse-engineering views

please, see my comment here

Can you check Propel2 as well ?

Actually, it's wrong. I missed the previous fix. It was correct. So I reverted this PR.

sorry for the mess caused by this PR.
So, Views will not be supported by OM task?

Thanks for your answer Will. It's a shame, because it was working
pretty well until now.I suggest to state that somewhere in the docs,
if you don't mind, it's very common to see Propel projects using
views.
2012/1/7 William DURAND
<EMAIL_ADDRESS>
Not in Propel 1.6. You can request this feature in Propel2.

Reply to this email directly or view it on GitHub:
https://github.com/propelorm/Propel/pull/250#issuecomment-3396233

--
Lic. Martín Palacio Pentucci

So there was a side effect until now… Because the SQL query to get tables information had a condition to just get "BASE TABLE".

haha right, errata: it was working pretty well until August/2011
OK, so it's not supported because it breaks a test.
I will try to wrote about that on the Cookbok.

First of all, sorry for the insistence. Let me perform a quick recap with errata:
Before this commit (and not this one as I stated first) it was possible to propel-gen reverse some database, including views. From that commit on, that's not possible anymore: propel-gen just ignores the views.
@willdurand, you asked to request this feature for Propel2, but as @fzaninotto said "A justification of this change, which breaks BC, is necessary.".
Can anyone clarify why that test fails? It seems to be intentional, since "One table and one view defined should return one as we exclude views".


Async middleware in 1.0.0

Before, I could do:
networkInterface.use([
  {
    applyMiddleware(req, next) {
      storage.get(STORAGE_KEYS.TOKEN).then(token => {
        req.options.headers['Authorization'] = token ? `Bearer ${token}` : null;
        next();
      });
    }
  }
]);

Now, if I do:
const authMiddleware = new ApolloLink((operation, forward) => {
  return storage.get(STORAGE_KEYS.TOKEN).then(token => {
    operation.setContext({
      headers: new HttpHeaders().set('Authorization', token ? `Bearer ${token}` : null)
    });

    return forward(operation);
  });
});

I get a typescript error:
Argument of type '(operation: Operation, forward: NextLink) => Promise<Observable<any>>' is not assignable to parameter of type 'RequestHandler'.
  Type 'Promise<Observable<any>>' is not assignable to type 'Observable<any>'.
    Property 'subscribe' is missing in type 'Promise<Observable<any>>'.

How would I return a promise properly, or execute async code inside the middleware? I know I could get the token first and then apply the middleware, but I want to retrieve the token from storage for each request, i. e. inside the middleware.

Instead of a Promise, return an Observable.
Now you have a Promise that returns an Observable which would cause an error.

Would be nice to have an example somewhere of how to do it with an Observable, but anyway I figured out another way using setContext() from apollo-link-context, which allows to be used with an async function/promise:
import { setContext } from 'apollo-link-context';

const link = this.httpLink.create({ uri: '/graphql' });

const auth = setContext(async (operation, prevContext) => {
  const token = await storage.get(STORAGE_KEYS.TOKEN);
  return {
    headers: new HttpHeaders().set('Authorization', token ? `Bearer ${token}` : null),
    // or prevContext.headers.append() if they were already set by a previous middleware
  };
});

this.apollo.create({
  link: auth.concat(link),
  cache: new InMemoryCache(),
});

Related Docs Link

Thanks @simonhaenisch, that was helpful


Quarantine flaky test of migration over dedicated network

What this PR does / why we need it:
This test has flaked 6% of the time over the past 14 days[1] which means that it qualifies for quarantine[2].
It is also one of the top tests in the recent flakefinder report[3]
[1] https://search.ci.kubevirt.io/?search=dedicated+migration+network&maxAge=336h&context=1&type=bug%2Bissue%2Bjunit&name=&excludeName=&maxMatches=5&maxBytes=20971520&groupBy=job
[2] https://github.com/kubevirt/kubevirt/blob/main/docs/quarantine.md#putting-tests-in-quarantine
[3] https://storage.googleapis.com/kubevirt-prow/reports/flakefinder/kubevirt/kubevirt/flakefinder-2023-11-13-168h.html#row3
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
/cc @dhiller @xpivarc
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

~[ ] Design: A design document was considered and is present (link) or not required~
~[ ] PR: The PR description is expressive enough and will help future contributors~
~[ ] Code: Write code that humans can understand and Keep it simple~
~[ ] Refactor: You have left the code cleaner than you found it (Boy Scout Rule)~
~[ ] Upgrade: Impact of this change on upgrade flows was considered and addressed if required~
~[ ] Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test~
~[ ] Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.~
~[ ] Community: Announcement to kubevirt-dev was considered~

Release note:
NONE

FYI, we have a fix in fly https://github.com/kubevirt/kubevirt/pull/10600

FYI, we have a fix in fly #10600

OK as the fix is in the merge queue - lets place this on hold and see if helps with the flakes.
/hold

This test has dropped off the flakefinder report since https://github.com/kubevirt/kubevirt/pull/10600 was merged. Thanks @jean-edouard @xpivarc !
/close


multiple captchas on page and widget IDs

Hello,
as a result of using multiple captchas on a page i use GetExplictHtml method but is it possible to get the created widget id to use as parameter when validating captcha via js by grecaptcha.getresponse method ?
thank you

fixed on version 1.2.3
closing 💯


[WIP] Add redirect checker

For https://trello.com/c/Rn6Z8W7d/227-add-automated-checks-for-world-redirects
We'll be redirecting all worldwide related content from /government/world to /world. This checker class will test that the redirects are correct, by making a http request through the whole stack. The idea is that you can add arrays of hashes with a url to check and the expected redirect_url.

@gpeng considering the output will only print an error message for those entries, we'll know to ignore those when we run this before the available_locales patch has been reverted?

Yep... that's fair enough.

@gpeng I've added https://github.com/alphagov/whitehall/pull/3308/commits/e2607c80c9907e5163157a93ef546384bdbaff0c to address your comment, is that what you had in mind?

Yes, that's pretty much it. I was thinking you could maybe break out a method for getting the (available|translated)_locales that uses original_available_locales if it is there or falls back to translated_locales if not as that would always work. That said, the patch is now in the first stuff we'll be deploying so I suspect it will be there throughout the process.


[SPARK-6700] disable flaky test

Test build #29696 has started for   PR 5356 at commit 08955f4.

cc @andrewor14

Merging this in master 1.3 since it's breaking builds.

Test build #29696 has finished for   PR 5356 at commit 08955f4.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.
This patch does not change any dependencies.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29696/
Test PASSed.


v-server-table data is not sortable or filterable

Vue.js version: 1.0.26
consumed using: webpack
FULL error message: n/a
relevant code: see below
steps for reproducing the issue: Create a new component with a server-side table, create an endpoint that serves up some JSON data, and add an "orderBy" option to the table's options object.

This is undoubtedly user error. The JSON data is properly formatted and is fetched OK, but the orderBy option is ignored. Typing in the "search query" filter box does nothing. From the network panel in the Chrome console, I can see the GET requests being sent with the proper query and orderBy params, but the data is not updated.
I tried v-ref:table as described in the docs and in #37 but... there isn't enough information for me to figure out where to put  this.$refs.table.refresh(); and it also doesn't seem like I want to programmatically refresh the data - shouldn't it happen automatically with each GET request?
I tried this with a client-side table, and sorting/filtering works as expected. My code:
main.js
import Datatable from '../components/datatable.vue'
Vue.component('datatable', Datatable);

var VueTables = require('vue-tables');
Vue.use(require('vue-resource'));
Vue.use(VueTables.server, {});

new Vue({
	el: 'body'
});

datatable.vue
<template>
    <div class="datatable-wrapper">
        <v-server-table url="path/to/local/json.php" :columns="columns" :options="options"></v-server-table>
    </div>
</template>

<script>
    export default {
        data: function () {
            return {
                columns: ['id', 'name', 'age'],
                options: {
                    orderBy: {
                        column: 'age'
                    }
                }
            }
        }
    }
</script>

index.html
<datatable></datatable>

As its name implies the server component doesn't handle any data manipulation itself. It merely sends the requested operations to the server, where the consumer - that would be you - is expected to handle the request and return the correct dataset, which is then displayed by the component.  Check out the example implementation that I've included for guidelines.


Implement getPullRequestsMergedBetween function

@roryabraham @arielgreen will you please review this?
Added GitUtils class and implemented getPullRequestsMergedBetween with unit tests.
Fixed Issues
$ https://github.com/Expensify/Expensify.cash/issues/1576
Tests

What unit/integration tests cover your change? What autoQA tests cover your change?
I added unit test for getPullRequestNumberFromCommitMessage function

What tests did you perform that validates your changed worked?
I manually executed following command and got expected result.

https://github.com/tugbadogan/expensify-common/blob/37f21ea035930a80282822f3dea6cd25e502d70b/index.js#L61-L67
QA

What does QA need to do to validate your changes?
What areas to they need to test for regressions?

I have read the CLA Document and I hereby sign the CLA


PacketBroker::WaitForPlayers soft locks when called in quick succession

This is preventing synchronization of rand() calls for Emerald Hunting (although I want to properly reverse engineer the emerald manager), as well as aggressive frame synchronization.

Looks like the actual issue is that one game instance can be any number of frames ahead or behind, and if another hook calls WaitForPlayers, they both get stuck waiting for messages they'll never receive. The moral of the story is to inject in a better locations, or not call it so frequently.


Vulkano tutorial isn't compiling for me

Template

Version of vulkano: 0.13
OS: Manjaro 19.0.2 Kyria
GPU (the selected PhysicalDevice): GeForce GTX 970
GPU Driver: video-nvidia-440xx
Upload of a reasonably minimal complete main.rs file that demonstrates the issue: https://github.com/vulkano-rs/vulkano-www/blob/master/examples/guide-compute-operations.rs

Issue
If I type cargo run I get the following output:
   Compiling shaderc-sys v0.5.1
   Compiling shaderc v0.5.1
error: could not find native static library `SPIRV-Tools-opt`, perhaps an -L flag is missing?

error: aborting due to previous error

The following warnings were emitted during compilation:

warning: Checking for system installed libraries.  Use --features = build-from-source to disable this behavior
warning: Found SPIRV.  Linking libSPIRV & libglslang

error: could not compile `shaderc-sys`.
warning: build failed, waiting for other jobs to finish...
error: build failed

Tutorial was updated to vulkano version 0.18 and now everything works.


DevExtreme Angular components force Angular change detection

To help us process the issue more efficiently, please provide the following information:

Specify the version of the devextreme-angular and devextreme packages you are using.
devexteme version: 17.1.4
devextreme-angular version:  17.1.4

Specify the type of the issue (check one with "x"):
[x] bug Report
[ ] feature request
[ ] support inquiry

The Angular change detection strategy checks changes on every mouse event on the page when the DevExtreme Angular module is imported in the lazily loaded view. With DevExtreme components, the Angular change detection strategy also makes more checks than it should be.
It can be reproduced in the Plunker sample. Just check the console.
This issue is based on DevExpress/DevExtreme#756

This issue occurs when DevExtreme is being initialized in the context of the Angular zone. Currently, we are improving our integration with Angular, and this issue will be resolved in that context.
As a workaround, some of the DevExtreme modules can be imported in the root of the application. Please check the sample on Plunker.

After additional testing, we found regression in the existing code. We reverted these changes and will make an update here once we find a more efficient solution.

I still have the problem as soon as I move the mouse over the dxdatagrid.
Here is an example: https://stackblitz.com/edit/angular-o6xaio


printing base64 image is taking too much time to print

@tulparyazilim  I am trying to print a base64 image . And it is taking too much time while printing. I mean it does not print fast. It prints slowly . How to increase the speed of printing same like we print text, or barcode etc

@Rehankhalil462 You can try less KB images.


Mystical class cast errors

[16:05:21] [Server thread/INFO]: Player11 lost connection: Internal Exception: java.lang.ClassCastException: net.minecraft.server.network.ServerPlayNetworkHandler cannot be cast to net.minecraft.network.listener.ClientPlayPacketListener

Apparently vanilla swallows the stacktrace.

Any update on this?

Not really, since a) I can't reproduce it consistently and b) I don't have a stacktrace.


Listing/showing nodes associated with a nodepool

Could you please document how nodes associated with a nodepool can be listed/shown?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 39fce7ab-ab56-44c6-b9a8-405444247a0b
Version Independent ID: dabbb6c6-c616-a6ec-61f6-1b9d3bb069e8
Content: az aks nodepool
Content Source: latest/docs-ref-autogen/aks/nodepool.yml
GitHub Login: @rloutlaw
Microsoft Alias: routlaw

route to service team

@kmathewmk Apologies for the late reply. Thanks for the feedback. We have created the above PR for the same and it is pending on review. In the meantime, if you have any questions, please feel free to ask.


[Workflow] Improve Contribution Guidelines for Pull Requests

What workflow needs to be updated?
The current contribution workflow for submitting pull requests lacks clarity and detail, which can lead to confusion among contributors. Specifically, the guidelines do not provide sufficient information on code formatting, testing requirements, and the review process.
Describe the proposed changes
Update Contribution Guidelines: Revise the CONTRIBUTING.md file to include:
Code Formatting: Specify the code style guide (e.g., PEP 8 for Python) and any tools to enforce it (like black or prettier).
Testing Requirements: Clearly outline the expectation for writing unit tests for any new features or bug fixes. Include instructions on how to run existing tests before submitting a pull request.
Pull Request Template: Introduce a pull request template that requires contributors to fill out sections about the changes made, related issues, and testing done.
Review Process: Detail the expected timeline for reviews and any labels that contributors should use to categorize their pull requests (e.g., bug, enhancement, feature).
Add a CI/CD Pipeline: Set up a Continuous Integration/Continuous Deployment (CI/CD) pipeline to automatically run tests on all pull requests. This will ensure that any new code meets the project’s quality standards before being merged.
Motivation
Improving the contribution workflow is necessary to streamline the process for contributors and maintain code quality. Clear guidelines will help reduce misunderstandings, ensure consistency across contributions, and encourage more developers to participate in the project. Additionally, implementing a CI/CD pipeline will help catch errors early, making the review process smoother and more efficient.
Additional context
By enhancing the contribution guidelines and integrating CI/CD practices, we can foster a more collaborative and productive environment for contributors. This change is particularly important as the project grows and more developers begin contributing. Better workflows will ultimately lead to higher-quality code and a more robust application.

please assign this issue to me under gssoc or hacktoberfest so that i can contribute . thankyou .

And this turned from a workflow issue to another doc issue. This is your first warning @Jaswithadabbiru , we are strictly against point farming. Closing this issue on account of being invalid.


Prevent thread from being blocked by JDK-8 ConcurrentHashMap#computeIfAbsent()

This is a workaround for JDK-8161372.
Related to ...

https://github.com/mybatis/mybatis-3/issues/1929
https://groups.google.com/g/mybatis-user/c/iBTN98c0dP4/m/H6IJS-LzAQAJ

We should drop this workaround once we drop Java 8 support (or the fix is backported).

Coverage decreased (-0.008%) to 87.248% when pulling 2fc8ec060dd2042cc4ab22ab60ed8accedf1e903 on harawata:workaround-jdk-8161372 into f6caf12f951cc5dc7c79fb6bf03a3d060d0d3839 on mybatis:master.


Add support for trailing and leading visual icons in Primer::Beta::Link (second try)

What are you trying to accomplish?
This is a follow-up of https://github.com/primer/view_components/pull/3040. It re-adds the with_leading_icon and with_trailing_icon slots to Links. The original PR was reverted, because:

The underlined text (initially and on hover) extends past the beginning and end of the text.

This is a result of the additional spacing that is added in between inline elements by the browser.
Screenshots
Before

After

List the issues that this change affects.
Closes #2981
What approach did you choose and why?
One possible solution is to render the icons outside the  tag itself and set their foreground color to the link color. In my eyes, this approach has two main disadvantages:

The icons would look like they are part of the link, but they are not clickable.
We would have to duplicate/inherit all different possible link styles ("primary", "secondary", "default", "muted") for the icons

I tried out a different approach, which is also not ideal, but still better in my eyes: I added a span around the whole content (including the icons) resulting in the following HTML:

     <svg class="octicon octicon-accessibility"><path  ...></path></svg>
     This is a link!
      <svg class="octicon octicon-bell"><path ...></path></svg>

Thus, I can set display: inline-flex on the Link-content span which omits all additional white spaces that inline elements normally have while leaving the acutal  tag unchanged.
Merge checklist

[x] Added/updated tests
[ ] Added/updated documentation
[ ] Added/updated previews (Lookbook)
[x] Tested in Chrome
[x] Tested in Firefox
[x] Tested in Safari
[x] Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

Hi @camertron I addressed your feedback from https://github.com/primer/view_components/pull/3040. I chose however a different approach which I tried to explain above. I would be intereseted in your opinion on this.

Hi @camertron any news on this?

Hey folks :) is it possible to get any feedback on this? /cc @camertron

Hey @HDinger my sincere apologies for letting this lapse for so long 😬 I'll try to follow up more quickly next time!
I copied this PR into the primer org so our visual regression tests (VRT) would run, and I'm seeing a number of issues in this PR that I'm hoping can be addressed before merge. Could you take a look at these? https://github.com/primer/view_components/pull/3150/files
You should be able to run the VRT tests and generate snapshots locally by running npx playwright install --with-deps followed by ./script/run-playwright. The generated screenshots in the repo were generated on a Linux machine and look slightly different if generated on a Mac (so annoying, I know 🙄) so you might have to spin up an Ubuntu container to effectively compare before/after screenshots. Happy to help figure that out, please let me know 👍

Thanks for detailed explanation 🙇 I will have a look in the next days 👍

Hi @camertron there was indeed a change in the line-height. Locally the images now look fine. Could you please check here?

@HDinger Ok, the snapshots are looking much better, thank you 😄 Could you rebase this PR on https://github.com/primer/view_components/pull/3150 and address the remaining build failures? Thanks!

@HDinger Ok, the snapshots are looking much better, thank you 😄 Could you rebase this PR on #3150 and address the remaining build failures? Thanks!

@camertron Done 👍  The semver label run is still red, but I honestly don't know what to do about that

Hi @camertron 👋 Is there anything left I can do to get this finished?

Ah shoot, I thought I had approved this already 😓


How can It make fast?

login
Already connected to a voice channel.
[youtube] AV3XSxEbxL0: Downloading webpage
[download] Destination: file\AV3XSxEbxL0.f137
[download]  29.1% of 75.24MiB at 83.40KiB/s ETA 10:55
It been very slow for two days

Sometimes it's fast, sometimes it's slow, sometimes it's slow.

i use youtube-dl to discord bot
discord bot play the music but It's very slow I don't use it

Try https://github.com/yt-dlp/yt-dlp, the problem is mostly gone with it.


Accept/Reject Buttons in ResponsivePopover: only green/red on phone and not on Desktop

Please compare the ResponsivePopover in http://output.jsbin.com/xitasaquya and http://output.jsbin.com/xitasaquya?sap-ui-xx-fakeOS=android
The Buttons are only colored in the latter (seems Desktop still lives in the b/w tv era and Phone are in the color tv era :wink:).
If this is by intention, please document it!

Hi,
thanks for your message - just copied your jsbin sample to a new one, as the latter told me it was expired and didn't want to just show me the output:
http://output.jsbin.com/maqawu/?sap-ui-xx-fakeOS=android
The issue is tracked internally under
1580222699
Kind regards,
Christiane


[WIP] Initial Commit - Publish Cross-Connect Status to CRD

Description

Motivation and Context

How Has This Been Tested?

[ ] Covered by existing integration testing
[ ] Added integration testing to cover
[ ] Tested locally
[x] Have not tested

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[x] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

Outdated


Lab 8 level 5 test case

Summary
My constructor Room(String roomName) creates a default value of false for swordPickedUp. So when I pass a function through go(func) , to the other room, my sword goes from picked up to NOT picked up. Is anyone facing the same issue and knows how to fix this
Screenshots
Screenshots (if any

)

hi! if I understand your question correctly, you storing swordPickedUp as a boolean inside your Room class yes? perhaps you can consider storing that in your Sword class instead? so that whenever you go from one room to another, you can loop through the items in the previous room and check if any of them were 'picked up', and if they were, bring it along to the new room by adding it to the new room after that new room is constructed.

hi! if I understand your question correctly, you storing swordPickedUp as a boolean inside your Room class yes? perhaps you can consider storing that in your Sword class instead? so that whenever you go from one room to another, you can loop through the items in the previous room and check if any of them were 'picked up', and if they were, bring it along to the new room by adding it to the new room after that new room is constructed.

Thanks will try that out