Can't enable dynamic scripting

First off, thanks Toptal for building and open sourcing this gem. Working with it has been great.
I have an issue with getting dynamic scripting to work. I may be missing something, but I can't find any reference to this in the docs. I've also looked at the elasticsearch gem that this wraps, thinking there may be instructions in there.
Here is an example of my query and the error.
MyIndex.script_score("_score * doc['rating'].value").load.to_a
{:body=>{:query=>{:function_score=>{:functions=>[{:script_score=>{:script=>"_score * doc['id'].value"}}]}}}, :index=>["my_index"], :type=>[]}
Elasticsearch::Transport::Transport::Errors::BadRequest: [400] {"error":{"root_cause":[{"type":"script_exception","reason":"scripts of type [inline], operation [search] and lang [groovy] are disabled"}],"type":"search_phase_execution_exception","reason":"all shards failed","phase":"query","grouped":true,"failed_shards":[{"shard":0,"index":"my_index","node":"Y-znyXOfQRWN1KxbM2PDhQ","reason":{"type":"query_parsing_exception","reason":"script_score the script could not be loaded","index":"my_index","line":1,"col":94,"caused_by":{"type":"script_exception","reason":"scripts of type [inline], operation [search] and lang [groovy] are disabled"}}}]},"status":400}

The error message makes me think that scripting is disabled, specifically because it says "scripts of type [inline], operation [search] and lang [groovy] are disabled"
I've read through this article and can't determine where to configure the ES settings. (https://www.elastic.co/guide/en/elasticsearch/reference/current/modules-scripting.html#modules-scriptin) I have tried using the chewy.yml and chewy.rb files.
script.inline: on
script.indexed: on

I'm running:
chewy 0.8.3
elastic search 2.0.0
rails 3.2.22
If I am doing something incorrectly or these settings are easy to configure, I'm happy to add to the docs to make it clearer to others how to do this.

Did you try even google it? The first page of google gives additionally:
script.engine.groovy.inline.search: on
script.search: on
script.groovy.sandbox.enabled: true

Yes, I have spent many hours searching for a solution before creating an issue. I'm hoping this really isn't an issue and it's just a case of it not being clear how to set these configurations. If someone can let if I'm setting these configurations correctly, then I would be able to really tell if there is an issue with the gem. If it happens that I'm setting the configurations incorrectly, then I'll submit a PR to add some more instructions to the docs.
I have tried using chewy.yml and chewy.rb and set these configurations. Neither of them have worked for me. I've tried including the configurations that you posted as well. Any help would be much appreciated.
# chewy.yml
test:
  host: 'localhost:9250'
  prefix: 'test'
development:
  host: 'localhost:9200'
  script:
    engine:
      groovy:
        inline:
          search: on
    search: on
    groovy:
      sandbox:
        enabled: true
    inline: on
    indexed: on

# chewy.rb
Chewy.settings = {
  host: 'localhost:9200',
  script: {
    inline: 'on',
    indexed: 'on',
    search: 'on',
    engine: {
      groovy: {
        inline: {
          search: 'on'
        }
      }
    },
    groovy: {
      sandbox: {
        enabled: true
      }
    }
  }
}

You have to set it up in elasticsearch.yml, this is not per-index configuration

Ok, thanks


Suggestion: add an option to only calculate everything when a button is clicked

I'm playing a fairly low-population server where many folks do multiple jobs. Trying to check prices on all of it, however, makes the site INCREDIBLY laggy, as everything is re-evaluated with every single change I make.
It would be much easier if I could go through the entire middle column and input prices, and then click "calculate" at the end, instead of it working through the entire set every time I do anything at all.

I like this idea a lot. App performance is pretty bad


Update "SSL Test" documentation

Fix link to code
Add screenshots
Add link to setup

Ref https://github.com/abapGit/docs.abapgit.org/issues/60

:+1:
Maybe it makes sense to specify that one can change the urls. E.g. to gitlab or azure to check their connectivity. The github is just a default

yep. we could add the most common urls as f4-help

@sbcgua Enhanced version at https://github.com/abapGit/docs.abapgit.org/pull/65


Debounce asyncValidator

I'm submitting an enhancement for asyncValidator in formly field config. Async validator mostly access server to valid data, so it costs a lot when it triggers every-time user changes the input.
Current behavior
async validator will trigger every time input value changes (despite the debounce setting)
Expected behavior
async validator will not trigger until user stoping change input after debounce time (in the debounce setting).
Environment
Angular: 4.4.6
Formly : 8.4.1
Browser: Chrome 63.0.3239.132
Language: Typescript 2.8.1
Node: 6.11.3

related to https://github.com/formly-js/ngx-formly/issues/528  and https://github.com/angular/angular/issues/19705

added support of updateOn, for now you can use updateOn: 'blur' see the example https://formly-js.github.io/ngx-formly/examples/validation/async-validation-update-on
for debounce we should wait until angular/angular#19705 is added.


Support Github/Bitbucket/Gitlab in Desktop

I am unclear why we would not support the various repositories in Desktop mode, so proposing enabling.
Welcome feedback.

good point @steve-winter
up to now it is because of the configuration needed for Github/Bitbucket/Gitlab, and working out how to do that for the desktop version

I am undecided if this or #828 is the appropriate outcome. I suspect #828 is the right outcome for desktop, but will have a think on both.


chore: remove deprecated aux alias with typoed name

The code in question was barely three days old by the time it was deprecated anyway.

The completion of the port does not seem relevant. We've come to a rough consensus that deprecated aliases are cheap and hence should be added by default when renaming.

Cheap, yes – but it is overkill to add a full deprecation alias for a one-character capitalisation mistake by @MichaelStollBayreuth (I admit that neither me or anyone else checked this before the merge). The deprecated name shows up in the docs too, which causes unnecessary duplication.
Indeed I am against your adding of the deprecation aliases in #11118. They were to code which is very new to mathlib and hence whose probability of being relied on in the meantime was essentially zero.

Mea culpa.
I have no strong feelings about this, but would slighlty tend to side with @Parcly-Taxel and consider this to be a quick fix of a recently merged PR, without the need to document the renaming for posterity.

IMHO, _aux lemmas should be considered private in the sense that they can disappear at any time.

bors merge
More discussion might be needed about when deprecations can be skipped in general, but I certainly agree that we can for aux lemmas.


Add Option to Download/Copy Other Formats of Icons

Summary
It would be very useful to have a quick download/copy option for other file formats of the icons.  Many times, we are using the icons in PowerPoints or other documents where SVG is not the easiest to work with and we just need a quick way to copy/paste from Carbon's website into another application/document.  This is a "development" request to the current website.
Justification
This is an extremely helpful feature that would save both development, and particularly non-development, team members a lot of time and hassle.  Most of us non-developers (and non-designers) are not super familiar with using SVG's in applications, but more importantly it's a giant time saver to be able to quickly copy/paste a PNG (for example) than having to find an icon, download it, open up an editor, save the SVG as another format for PPT, then bringing it into PPT.
Desired UX and success metrics
The biggest benefits are higher use of Carbon icons in other areas such as documents and presentations, consistency with the IBM brand/Carbon across all documents, and saving a large amount of time for the practitioner.
Must-have functionality
Ability to quickly download/copy a transparent background version of an icon in a universally accepted format other than SVG (PNG for example). (ideally, both light and dark variants...maybe a gradient color one, too!)
Specific timeline issues / requests
No specific timeline, but when available this would be great for the other IBMers using Carbon!
Available extra resources
Font Awesome does a great job with Light/Dark as well as displaying options and different download file types.
https://fontawesome.com/v5/icons/flag?style=solid&s=solid

@pswiekibm It looks like the newest version of powerpoint supports insertion of SVG's. It also might be worthwhile to look at a browser extension to facilitate the use case of saving the svgs as .png, here's an example for chrome

@tay1orjones Thanks.  This is indeed an option, but for most consultants at IBM that are using the icons, this is a very difficult and tedious task to go through.  Often, we are trying to browse the icon library for a keyword ("cloud", for example) in order to quickly drop an icon in.  Not being able to quickly copy the latest icons out of the website where we can search makes this not easy.  Browsing through a long list of SVG's (assuming you even have them downloaded) is also equally tough.  Most folks at IBM that use these in PPT are not design professionals and are services/consulting professionals that do not use SVG's and related applications.  I hope this helps with context.  If you have time, send me a Slack and I can walk you through the use case more.


Add footer to login page with dynamic text

A footer should be added to the login page.
This can be used as reference:

We don't need the social-media icons.
The logo should be a black and white version of our logo:
Traefik Guardian Logo.zip
The copyright text should be modifiable via an environment variable (injected via go template).

I would like to add this feature

Sure, I've assigned you to this one :)


Start working on VRM support

Closing as this is no longer relevant for the current codebase. There changes might still be merged but in a different form.


HasKey and ValueGeneratedOnAdd have a declaration order dependency

Steps to reproduce
PropertyClassEntity
    public class PropertyClassEntity
    {
        public override PropertyClassEntityTypeEnum Id { get; set; }
    }

PropertyEntity.cs
    public sealed class PropertyEntity : Entity
    {
        public PropertyClassEntity PropertyClass { get; set; }
    }

PropertyClassEntityTypeEnum
    public enum PropertyClassEntityTypeEnum : byte
    {
        A = 1,
        B,
        C
    }

CommonMapping (works)
            builder.Property(t => t.Id).ValueGeneratedOnAdd();
            builder.HasKey(t => t.Id);

CommonMapping (does not work)
            builder.HasKey(t => t.Id);
            builder.Property(t => t.Id).ValueGeneratedOnAdd();

The issue
When trying to save the PropertyEntity it will throw the following error:
Result Message:	The property 'Id' on entity type 'PropertyClassEntity' has a temporary value while attempting to change the entity's state to 'Unchanged'. Either set a permanent value explicitly or ensure that the database is configured to generate values for this property.

Further technical details
EF Core version: 1.0.0-rc2-final
Operating system: Win10
Visual Studio version: VS 2015

Notes for triage: I wasn't able to reproduce the exact exception, probably because there is a lot of missing information in the repro code, but I did find the likely root cause. When ValueGeneratedOnAdd is set a check is made for whether the property is part of a key. If it is, then it gets the RequiresValueGenerator flag set so that the stack will know to generate temporary key values. For non-key properties this does not happen. But if something is made a key, then there is no code that goes back and checks whether any properties have OnAdd set, so in this case the temporary keys are not created.
I think there may be other issues around byte and/or enum keys, so I am going to do further investigation.


Feature/add backgrounds and licences

Requires #251

Codecov Report

Merging #265 (d777e99) into master (940b2fc) will decrease coverage by 0.84%.
The diff coverage is 0.00%.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 940b2fc...d777e99. Read the comment docs.


Version checking thinks "RELEASE" is not up-to-date

This is kind of a follow on from #7 but for the checking side of Depot, rather than the updating side: the version checker reports that "RELEASE" is out of date compared to whatever the latest stable release actually is.
As noted in that other ticket, we only use "RELEASE" for dev/test tooling where we always want to ensure we're always on the most recent release, without needing any manual process to update dependencies.

Sorry I completely forgot about this issue and the changes @lverns submitted, I need to get this across the line really so the master branch has a released tag. Wondering what needs to be done to finish it off, guessing it's still an issue?

It's no longer an issue for me -- I no longer use Depot.

Completely understandable! :smile: this tool definitely needs some love, just got to find the time and energy to do it. I'll leave this open as a note for now, would be worth bearing in mind with any changes or rewrites.

In case you're curious, I ended up doing it via a fairly simple shell script that ran clojure -Stree on my code and edited the output into a new deps.edn in a temp folder with "RELEASE" in place of the actual versions, then ran clojure -Stree on that "project" and compared the output with the original deps tree (I can filter deps by depth so I can exclusive some or all transient deps).

Oooo I really like that! Thanks for the tip!
On Tue, 26 May 2020, 16:32 Sean Corfield<EMAIL_ADDRESS>wrote:

In case you're curious, I ended up doing it via a fairly simple shell
script that ran clojure -Stree on my code and edited the output into a
new deps.edn in a temp folder with "RELEASE" in place of the actual
versions, then ran clojure -Stree on that "project" and compared the
output with the original deps tree (I can filter deps by depth so I can
exclusive some or all transient deps).
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/Olical/depot/issues/11#issuecomment-634100093, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AACM6XPXSCHI3AMUKZDKUMTRTPOIBANCNFSM4GFGNF2A
.


[bug]:  Getting print rd error

Is there an existing issue for this?

[X] I have searched the existing issues

OS
Windows
GPU
cuda
VRAM
4GB
What happened?
File "F:\InvokeAI\installer_files\env\Lib\site-packages\ldm.py", line 408
print rd
^^^^^^^^
SyntaxError: Missing parentheses in call to 'print'. Did you mean print(...)?
Screenshots
No response
Additional context
No response
Contact Details
No response

It seems to be working now after running update.bat


Overwritten generate-panchAnga output

Observing history of https://github.com/jyotisham/jyotisha/commits/generated-output/sahakAra nagar%2C bengaLUru/SOLSTICE_POST_DARK_10_ADHIKA__CHITRA_AT_180/gregorian/2000s/2020s , https://github.com/jyotisham/jyotisha/commit/0d519c9bb161b308d965ceed256c10400917c0d0 seems to have deleted 2023 calendars, while in https://github.com/jyotisham/jyotisha/commit/975c551f3862ddf32312a16a9ee40dedaf9513c1 it seems to have been introduced and 2022 stuff is deleted.

सद्यः समीकृतम् इति भाति। "अद्यतिथि"सङ्ग्रहय् इह च workflow-yml-सञ्चिकाः परिवर्तिताः।


Access Required for the User

Can you please specify what privileges' ( minimum and not an admin :))  is required for the user ( SQL DB on prem ) to do the migration from the Source DB for SSIS packages.
Also any other ports apart from 1433 that needs to be opened when connecting to our source SQL on prem DB.
Document Link : - https://docs.microsoft.com/en-us/azure/dms/how-to-migrate-ssis-packages
Thank you!
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 852779ca-7b0a-2200-bc7f-31eb6d5830ce
Version Independent ID: a1e6408c-e9f8-dd98-879e-4669c12d6ddc
Content: Redeploy SSIS packages to SQL single database - Azure Database Migration Service
Content Source: articles/dms/how-to-migrate-ssis-packages.md
Service: dms
GitHub Login: @pochiraju
Microsoft Alias: rajpo

@pochiraju Raj, is this something we could note to improve in the article in the future? @chaisen2006 Thanks for the suggestion, and apologies for the long delay.

hello,
You need to have a "CONTROL SERVER" privilege on the source SQL Server migrating to Azure SQL DB.  We try to reduce the scope of the permissions further in our upcoming releases.
You need to make sure to open TCP/IP port inbound on your windows and any other firewalls between the DMS network and on-prem SQL Server.  You can find the complete list of ports here,  https://docs.microsoft.com/en-us/azure/dms/resource-network-topologies

Hi @AnuragSharma-MSFT, since this issue was already solved, let's close it.
Thanks!

#please-close


Random connection failure in readInitialHandshake()

Hello there,
First of all, thank you for your work!
I'm currently using the latest commit of the driver (https://github.com/go-mysql-org/go-mysql/commit/eb2c6d100ad80877ec2b88026cad8cf005442f51) with Go 1.22.2, and I get an error randomly when I try to open a database connection.
4 times over 5, it works, but sometimes it ends up with this error: runtime error: slice bounds out of range [:9] with capacity 8.
The MySQL server version is: 8.0.37. I'm using MySQL in a docker container (mysql:8.0 image).
I open the connection in a very old-fashion way:
	dsn := fmt.Sprintf("%s:%s@%s/%s?ssl=true", mySqlUsername, mySqlPassword, mySqlHost, mySqlSchema)
	db, err := sql.Open("mysql", dsn)
	if err != nil {
		t.Fatalf("failed to connect to mysql: %s", err)
	}
	defer db.Close()

and do a simple select count(1) query.
And here is the stacktrace I have 1 time over 5:
panic: runtime error: slice bounds out of range [:9] with capacity 8

goroutine 1542 [running]:
github.com/go-mysql-org/go-mysql/client.(*Conn).readInitialHandshake(0xc002bb8c30)
	/home/runner/go/pkg/mod/github.com/go-mysql-org/go-mysql@v1.7.1-0.20240508103851-eb2c6d100ad8/client/auth.go:57 +0x8c6
github.com/go-mysql-org/go-mysql/client.(*Conn).handshake(0xc002bb8c30)
	/home/runner/go/pkg/mod/github.com/go-mysql-org/go-mysql@v1.7.1-0.20240508103851-eb2c6d100ad8/client/conn.go:157 +0x1c
github.com/go-mysql-org/go-mysql/client.ConnectWithDialer({0xcad3f0, 0xc0002c3340}, {0x0, 0x0}, {0xc002cc53dd, 0xf}, {0xc002cc53c8, 0x7}, {0xc002cc53d0, 0xc}, ...)
	/home/runner/go/pkg/mod/github.com/go-mysql-org/go-mysql@v1.7.1-0.20240508103851-eb2c6d100ad8/client/conn.go:127 +0x545
github.com/go-mysql-org/go-mysql/client.ConnectWithContext({0xcad3f0?, 0xc0002c3340?}, {0xc002cc53dd?, 0x1?}, {0xc002cc53c8?, 0xf?}, {0xc002cc53d0?, 0x7?}, {0xc002cc53ed, 0x6}, ...)
	/home/runner/go/pkg/mod/github.com/go-mysql-org/go-mysql@v1.7.1-0.20240508103851-eb2c6d100ad8/client/conn.go:79 +0x105
github.com/go-mysql-org/go-mysql/client.Connect({0xc002cc53dd, 0xf}, {0xc002cc53c8, 0x7}, {0xc002cc53d0, 0xc}, {0xc002cc53ed, 0x6}, {0xc000051948, 0x1, ...})
	/home/runner/go/pkg/mod/github.com/go-mysql-org/go-mysql@v1.7.1-0.20240508103851-eb2c6d100ad8/client/conn.go:73 +0x11a
github.com/go-mysql-org/go-mysql/driver.driver.Open({}, {0xc002cc5380?, 0xc002e10001?})
	/home/runner/go/pkg/mod/github.com/go-mysql-org/go-mysql@v1.7.1-0.20240508103851-eb2c6d100ad8/driver/driver.go:102 +0x19b
database/sql.dsnConnector.Connect(...)
	/opt/hostedtoolcache/go/1.22.2/x64/src/database/sql/sql.go:791
database/sql.(*DB).conn(0xc002bb8b60, {0xcad2a0, 0x114e4c0}, 0x1)
	/opt/hostedtoolcache/go/1.22.2/x64/src/database/sql/sql.go:1415 +0x71e
database/sql.(*DB).query(0xc002bb8b60, {0xcad2a0, 0x114e4c0}, {0xb8f886, 0x10}, {0x0, 0x0, 0x0}, 0xa0?)
	/opt/hostedtoolcache/go/1.22.2/x64/src/database/sql/sql.go:1749 +0x57
database/sql.(*DB).QueryContext.func1(0xa0?)
	/opt/hostedtoolcache/go/1.22.2/x64/src/database/sql/sql.go:1732 +0x4f
database/sql.(*DB).retry(0xc000051d28?, 0xc000051cd0)
	/opt/hostedtoolcache/go/1.22.2/x64/src/database/sql/sql.go:1566 +0x42
database/sql.(*DB).QueryContext(0xb88d5d?, {0xcad2a0?, 0x114e4c0?}, {0xb8f886?, 0x3?}, {0x0?, 0x41097b?, 0x7f3a2a14c5b8?})
	/opt/hostedtoolcache/go/1.22.2/x64/src/database/sql/sql.go:1731 +0xc5
database/sql.(*DB).Query(...)
	/opt/hostedtoolcache/go/1.22.2/x64/src/database/sql/sql.go:1745

I managed to debug the readInitialHandshake() and capture the data value which cause this issue, and data contains only this: <0x0b><0x08><0x05><0x1a><0x00>:

Any clue?
I don't know if it's related to recent changes. Let me know if I can add some flags or verbosity to have much information to share.
Thanks!

Thanks for reporting, I'll take a look soon

As the document says, the first byte in data should be 10 https://dev.mysql.com/doc/dev/mysql-server/latest/page_protocol_connection_phase_packets_protocol_handshake_v10.html but in your case it's 11 🤔 I think I need more time to read the source code of MySQL server to locate it.
And this package should check it's 10 rather than >= 10

I also didn't find 11 in source code, can you repeatedly check the failed data is always <0x0b><0x08><0x05><0x1a><0x00>?

Hello @lance6716,
Thank you for taking a look.
I reproduced this issue 5 times, and I always had <0x0b><0x08><0x05><0x1a><0x00> in data variable.

Can you try https://github.com/go-sql-driver/mysql ? I must say that driver is more popular if you don't need binlog replication and compression.

I was using this library at first, but I encountered some issues (maybe the same, but the error messages were not as explicit as yours), that's why I shifted. If it's difficult to tackle, I guess we can act that it will be a known issue / won't fix.

Good point, I'm using the official latest image, but I'll try to downgrade the version and I'll let you know.

The 'Classic' MySQL protocol always has version 10. There was a version 9, but that's really really old.
And X Protocol use version 11.
dvaneeden@dve-carbon:~$ echo | nc <IP_ADDRESS> 3307 | hexdump -C
00000000  49 00 00 00 0a 38 2e 34  2e 30 00 09 00 00 00 74  |I....8.4.0.....t|
00000010  28 76 05 29 54 32 11 00  ff ff ff 02 00 ff df 15  |(v.)T2..........|
00000020  00 00 00 00 00 00 00 00  00 00 36 45 14 06 66 57  |..........6E..fW|
00000030  06 1d 4e 6e 0a 4f 00 63  61 63 68 69 6e 67 5f 73  |..Nn.O.caching_s|
00000040  68 61 32 5f 70 61 73 73  77 6f 72 64 00 33 00 00  |ha2_password.3..|
00000050  01 ff 86 04 23 30 38 53  30 31 47 6f 74 20 61 6e  |....#08S01Got an|
00000060  20 65 72 72 6f 72 20 72  65 61 64 69 6e 67 20 63  | error reading c|
00000070  6f 6d 6d 75 6e 69 63 61  74 69 6f 6e 20 70 61 63  |ommunication pac|
00000080  6b 65 74 73                                       |kets|
00000084
dvaneeden@dve-carbon:~$ echo | nc <IP_ADDRESS> 33070 | hexdump -C
00000000  05 00 00 00 0b 08 05 1a  00                       |.........|
00000009

This is with:
podman run -p 3307:3306 -p 33070:33060 --env MYSQL_ALLOW_EMPTY_PASSWORD=1 -it mysql:8.4.0

Note that the classic protocol should be on port 3306 and X Protocol on 33060.

@dveeden From what I understand, I could mean that the issue I'm experiencing is due to the wrong port usage?
In the code I'm working on, the host/port is loaded dynamically since it can change for every container, and I noticed that the method to do that returns the first exposed port. I guess sometimes 33060could be exposed before 3306. I'm gonna check this and get back to you.

I think we should make sure go-mysql returns a clear error instead of a "slice bounds out of range".


Test

Description

Checklist
Please feel free to remove inapplicable items for your PR.

[ ] The PR title starts with [$CATEGORY] (such as [Model], [Doc], [Feature]])
[ ] Changes are complete (i.e. I finished coding on this PR)
[ ] All changes have test coverage
[ ] Code is well-documented
[ ] To the my best knowledge, examples are either not affected by this change,
or have been fixed to be compatible with this change
[ ] Related issue is referred in this PR

Changes

@dgl-bot

@dgl-bot test

@dgl-bot Test


command: wg show, shows a different public key than imported to the client

Describe the issue
I followed the instructions and used the qr code to setup the peer on my android which displays 2 public keys:
SzZkNHW... and
bC4Dsw8...

My wg0.conf file on the server:
`[Interface]
Address = <IP_ADDRESS>/24, fddd:2c4:2c4:2c4::1/64
PrivateKey = 8D...
ListenPort = 51820
BEGIN_PEER client
[Peer]
PublicKey = SzZkNHWC...
PresharedKey = vE...
AllowedIPs = <IP_ADDRESS>/32, fddd:2c4:2c4:2c4::2/128
END_PEER client`
So far seems to be OK until I run wg show on the server:
interface: wg0   public key: 7TyDV3k/7I5pR4ARYaPhtfoRRWvcWvAMNLcmcwoLiiI=   private key: (hidden)   listening port: 51820
Running wg syncconf or wg setconf both return this error:
scott@scottlounge:~$ sudo wg setconf wg0 /etc/wireguard/wg0.conf Line unrecognized:  Address=<IP_ADDRESS>/24,fddd:2c4:2c4:2c4::1/64 Configuration parsing error
I believe the public key, 7TyDV3k/7I5pR4ARYaPhtfoRRWvcWvAMNLcmcwoLiiI= was a key created by an earlier key generation attempt by me.
Expected behavior
That the wg0.conf file that did not exist prior to running the install script contains the server key that the script generated.
Logs
Add error logs to help explain the problem, if applicable.
Server (please complete the following information)

OS: Kubuntu 23.04
Hosting provider: N/A

Client (please complete the following information)

Device: Redmi Note 12 pro plus
OS:  MIUI <IP_ADDRESS> / Android 12 SP1A.210812.016

@shag00 Hello! From the details you provided, it looks like you have multiple wireguard binaries, configuration files or services running on your server. This doesn't look like a bug in wireguard-install.sh.
While I can't help you troubleshoot on your server, I would suggest that you search for and uninstall all wireguard instances from the server along with their configurations (you can check e.g. ps aux to see the running instances), then re-install using the script in this repo.

Thanks for your reply, an uninstall and restart seems to have fixed the problem.


Possible missing dependencies iso8601

Hi, in src/axiom_py/utilpy you import "iso8601" but the package is not listed among the dependencies which breaks builds not already including said package.
Workaround, till this is fixed, is is to manually (pip) install iso8601.
Thank you, g.

Hi @glarec, Thank you for taking the time to point out the bug, confirmed!


fix(table): update information to be included in single div

fix #1491

Deploy preview for pf-next ready!
Built with commit a5434e2d7db197cbfd692ddc14f855baef6fe1d6
https://deploy-preview-1496--pf-next.netlify.com

This looks good to me, though is it intuitive to the user that they have to have a wrapping element to put their content in, or are they going to put something like this in and wonder why their layout is broken?

I wonder if the td's and th's create grid children that start in column 2 like this, if the child of the td/th's should be a <div>, and maybe that even has a BEM name, and that's where you put your content, whether it's a single word or a few elements. That would also allow us to write a cleaner selector to target this element so it starts in the 2nd grid column.

The downside is it adds an extra HTML element that would be unnecessary if you only have a single word in the th/td.
Another way of doing this would be to make the td/th position: relative, then absolutely position the ::before in the top/left, assign a width of 30% or whatever, then assign padding-left: 30% to the td/th. Then you wouldn't need a child wrapper on the content in the td/th, and wouldn't need to use grid, either.

@srambach do you mind taking another look at this one?

I will be honest, I don't love having to wrap the cell contents.  ;-P But lacking any better ideas, this implementation all looks fine to me.


Porting development environment to Docker

Hello all,
This would skip other OSes dependencies shenanigans as docker containerization is supported in all of them.
Please let me know.
Regards,
Miguel

I just created this. Here.

Pull requested.

This might need to be updated and completed. Features like bridging the USB interface into docker so one can flash the device from inside the docker container.


Add changes in peer dependencies for RN 64+

Since version 64 of react-native, the react version is set to 17 and we have versions mismatch when use react-native-scalable-image. So change react peer dependency and remove prop-types peer dependency

Please consider this pull request for merging

+1, currently impossible to npm install react-native-fit-image in the latest version of RN.

@TheWebartist Why did you remove prop-types from package.json ? isn't it going to cause conflict since it is being used in the package?

There is a fork that already merged this PR here if you need this to work after upgrading RN: https://github.com/uugengiven/react-native-scalable-image

Any updates for this?

any updates?

I also need this change. Any updates?

https://github.com/ihor/react-native-scalable-image/issues/41 check this one it might help you , I just got the same problem ( i'm working with react 18 )


add incrementOf(color) to clock trait

RunningClock.incrementOf already exists. Make it available on the Clock trait for convenience.

nvm, i don't really need it for my time management pr. you can't berserk vs the engine anyway. the rest is trivial

For https://github.com/ornicar/lila/commit/12b833fcd2d4401ec07d1f38126f921311dfbe18


MFMT command is not setting time properly

I am executing a low level command after each file upload
client.Execute("MFMT " + file.LastWriteTime.ToString("yyyyMMddHHmmss") + " " +                                                    remoteRelativePath);
It is setting Date properly, but for time it is changing the value, while debug I have seen that date time string which I am passing to the command is not setting it is setting some other value.
I have to preserve date time of the file to the local date time, so that if there is any new files coming in at Source or if there is any changes in existing files which have uploaded could be syncUp with the Ftp (destination) server while I trigger Syncronization between source and destination.
In log it is showing proper value
Status:   Connecting to <IP_ADDRESS>:58662
Response: 226 Successfully transferred "/UploadFolder/Upload1/1401.data"
Response: 221 Goodbye
Command:  MFMT<PHONE_NUMBER>5458 /UploadFolder/Upload1/1401.data
Status:   Disposing FtpSocketStream...
Command:  STOR /UploadFolder/Upload1/New folder/1404.data
Response: 213 modify=20170411135458; /UploadFolder/Upload1/1401.data

I have converted my datetime to UTC and it is working fine now, So I am closing this query.

In the latest version there is a new SetModifiedTime API to change modified date of a server file in local timezone/UTC. Can you check it and see if it works for you??
https://www.nuget.org/packages/FluentFTP/

With the latest version of FluentFtp it's working fine,

Thats great, thanks.


delta-xDS doesn't update the known resource version for wildcard resources

Title: delta-xDS doesn't update the known resource version for wildcard resources
Description:
The current implementation of the delta-xDS for wildcard responses only stores the initial version for a resource name that Envoy observes, instead of the version of the latest update.
See here:
https://github.com/envoyproxy/envoy/blob/04aae9f17b0223013cff7285539b5ee2485c5bc1/source/common/config/new_delta_subscription_state.cc#L378
and here:
https://github.com/envoyproxy/envoy/blob/04aae9f17b0223013cff7285539b5ee2485c5bc1/source/common/config/new_delta_subscription_state.cc#L81
This can lead to using a stale resource without the server knowing about it.
For example:

Envoy receives resource_A v1 from server (updates the map to v1).
Envoy receives resource_A v2 from server (doesn't update the map, because it already has a resource with the same name).
Envoy reconnects to a new server (that only knows about v1), and publishes it has v1, although the actual resource is of v2. -> The server won't send Envoy an update until that resource is updated on the server.

Using insert_or_assign should solve the issue.

/cc stevenzzzz


Remove pry-byebug development dependency

It's not required, but not compatible with JRuby.

Done in 80189df2812bac06f83fe89a55b1c2719c5e0f97 and 8fae64614d9b7ed2865212f35292e50d27001e61


Remove temporary project conversion

This project conversion affects only projects, that were edited after #97707 (v4.4-dev4) and provides an easy way to upgrade these projects.
It seems reasonable to assume, that at that time of the next stable Godot-release all affected projects have been converted.
So I would like to suggest to merge this PR and remove the project conversion shortly before the next stable release,
For projects, that haven't been converted, we can provide an upgrade-strategy, that that consists of opening the project once with v4.4-dev5.
Follow-up to/Implements https://github.com/godotengine/godot/pull/99449#pullrequestreview-2449032498

I have updated the PR to additionally revert #100334.


[Feature] Progress bar, stepper, multi-stage form component

Summary
A progress bar indicator which shows the status of a particular process.
Motivation
A progress bar is useful in many cases:

File upload status
Waiting for a long-running API or query
Showing status of a long process which involves many people, many days, etc.
Showing the different stages of a form and current status

Additional Context

https://krutsch.work/design-patterns

An internal user was looking for this - https://www.notion.so/appsmith/Rishabh-Kashyap-85ea180b031b42e58ef0f7a4910580cf

Any estimates where do you think this could be implemented? I'm only evaluating your product for our internal use but it's a must-have for our use cases.

Hey @bilus unfortunately this is not yet prioritised. You can check how to build this using a workaround here - https://app.appsmith.com/applications/62148aabda926877eb2749c1/pages/62ea6cf44003a7259a310d91

This progress bar widget should solve the problem right @dilippitchika?


Remove unused CDC logic that prints warnings

Cassandra and Scylla have totally different CDC implementations. Logic
removed by this patch is relevant only to Cassandra CDC which is never present
when working with Scylla. The code prints warnings that are confusing for
the users so it's better to remove it especially that the code is effectively
useless.
Signed-off-by: Piotr Jastrzebski<EMAIL_ADDRESS>

@elcallio @penberg please review (unfortunately I can't add reviewers in this project)

I'm ok with this, though removing the lines completely might cause merge issues down the road. But it is a risk I am willing to take. :-)

I was thinking about commenting it out but I think it will create merge conflicts too.

Yeah, I was more onto changing the config generation instead, to always set the cdc size. But that is probably more error prone, so this (remove) is good.

I agree. The alternative is to set some magic value to some magic option that's never used. It would be really confusing for a reader. Moreover, any changes to this Cassandra CDC logic in the future could break miserably due to the magic value we pick to set the option to. Much safer to just remove it.

@penberg can you please merge?

@penberg please

Queued as 26a8d662a4d28575a0fb828145feacbcf0eb26d5, thanks @haaawk!


Prevent concurrent executions of same task

Hi, I've setup a django-q2 cluster and I have a task that runs every 10 minutes.
Usually it takes only 2-3 minutes to complete but in some circumnstances it could take more than 10 minutes.
Is there any way to prevent the task from starting if the previous instance is still running?
Here is my configuration:
Q_CLUSTER = {
    'name': 'Mondrian',
    'workers': 8,
    'recycle': 500,
    #'max_attempts': 10,
    'timeout': 600,  # in seconds (MUST be < retry)
    'retry': 3600,  # in seconds (3600 secs = 1 hour)
    'compress': True,
    'save_limit': 500,  # number of successful tasks saved to Django (failures are always saved)
    'queue_limit': 16,
    'cpu_affinity': 1,
    'label': 'Task Scheduler',
    'catch_up': False,
    'scheduler': True,
    'redis': 'redis://<IP_ADDRESS>:6379',
    #'time_zone': 'Europe/Rome',
}

Thanks!

Could you set the worker to 1? If you have more jobs that the cluster should do, then I think your best bet would be to setup a second cluster with one worker, which only processes that job. That way, they would always finish before starting a new one: https://django-q2.readthedocs.io/en/master/cluster.html#multiple-queues

I have a similar situation. Would it be possible to implement a lock mechanism for a certain task, released when the results are finished? In my case a task will fire a multi-core long running slurm job (2-3hours, 24 cpu's). There is something similar described here:http://loose-bits.com/2010/10/distributed-task-locking-in-celery.html

One suggestion could be what @coleifer does with Huey: https://huey.readthedocs.io/en/latest/guide.html#locking-tasks


Add docs for custom signin page

Oh awesome, thanks!
I'll try and get round to adding the NextAuth.providers() method but this gives us some breathing room, it's great have this actually documented :D
Will leave a couple of inline-suggestions!


Update azure dedicated-plan ASE v2 link to ASE v3

azure function dedicated-plan page link to ASE pointing to v2 instead of v3 which is the latest version

@ggailey777
Can you review the proposed changes?
Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@danialtham thanks for this fix! #sign-off


improve packaging, migrate to setup.cfg

declarative config (putting all the packaging information into the setup.cfg) is superior to imperative config (using code in setup.py) (source: setuptools themselve)
You lose the ability to do python setup.py test but managing tests with setup.py is deprecated and so is calling setup.py via the command line.

#398 should be merged first

Shouldn't this entirely setup.py just be removed? As far as I can tell all the packing info is already in pyproject.toml and poetry-based. I found out about this the hard way in our fork, and there's a serious lack of documentation on how to actually build and publish the package:
poetry build
poetry publish

The relevant info is here:
https://github.com/SAML-Toolkits/python3-saml/blob/a1211a8695c855b74591a607cf589682307572a6/pyproject.toml#L79-L85
the build backend points to Poetry so any setuptools related files (setup.py, setup.cfg) is currently/will be ignored.
If you want to stick with Poetry, I would suggest using:
[build-system]
requires = ["poetry-core>=1.0.0"]
build-backend = "poetry.core.masonry.api"

There's no need to require poetry and all the dependencies when building

Ah damn. All this work for almost nothing! I wasn't sure Poetry was the way to go, because it's not used in CI, so I was mislead thinking Poetry was not used (and actually it might not be, since setup.py metadata are still relevant. But since the package is not built in the CI, we can't know).
Is the maintainer still out there? @pitbulk ?

Yeah I don't know a lot about poetry, but it looks like the pip install -e . in the makefile does somehow use pyproject.toml and poetry build systems etc.
I've recently gone through the same surprises and frustrations - so some documentation improvements and cleanups (removing setup.py completely) would definitely clarify the situation.

I was mislead thinking Poetry was not used (and actually it might not be, since setup.py metadata are still relevant)

Build frontend tools such as pip will make use the build-system.build-backend key if present in pyproject.toml. So doing a plain pip install . locally will use poetry to install it (if the key is not present, build frontends should default to setuptools iirc).
However, the CI doesn't seem to handle packaging and publishing (as you mentioned), so maintainers might be forcing setuptools to be used in some way.
The metadata and packaging configuration would probably benefit from a large cleanup. We couldn't really do it in our fork to avoid merge conflicts

Agreed. I will do all these cleanup if the maintainer comes back

Maintainer here, what do you need?

To build the release I use setup.py
python setup.py sdist bdist_wheel upload -r pypi

or

python setup.py sdist bdist_wheel
twine upload dist/<package_name_and_version>-py3-none-any.whl

But the setup.py is not picked up for local development due to the presence of pyproject.toml which specifies poetry as build tool.
In the current situation you need to make the same change to setup.py and pyproject.toml (e.g. when specifying new or newer dependencies, as that's how I found this out).
Please pick one method.

When I was porting from setup.py to pyproject.toml I experienced some challenges, that why I ended with both.
You can read this thread where people experienced similar issues:
https://discuss.python.org/t/user-experience-with-porting-off-setup-py/37502/18

I can give it a shot if you are ok with it?

I'll let @Viicos do the work on his PR.


Add fields for message attributes, send when producing.

Currently the message and producer do not allow for using Sns message attributes.
Message attributes are provided to the AwsSnsClient as described here:
https://docs.aws.amazon.com/aws-sdk-php/v3/api/api-sns-2010-03-31.html#publish
These are needed to use the Message Filtering feature, something that is a main feature of SNS
https://docs.aws.amazon.com/sns/latest/dg/sns-message-filtering.html

oh, read only repo.  closing.


Enum in MultiPart request

Describe the bug
When you want to use enum in MultiPart request, the generated code is incorrect.
To Reproduce
Create request with enum
enum TestEnum {
  test;
}

@MultiPart()
@POST('/')
Future<void> testPost(
  @Part() TestEnum test,
);

it throws Exception: toJson() method have to add to TestEnum
And if you add toJson()
enum TestEnum {
  test;

  String toJson() => ''; // simplified for demonstration purposes
}

the generated code is
_data.fields.add(MapEntry('test', jsonEncode(test)));

Expected behavior
The best solution would be to update retrofit to SDK 2.17 and use xyz.name enum property.
Or at least use the toJson() method.

Ah, nevermind, my fingers are faster than my brain. jsonEncode uses toJson() method and so it works.

Ok, it in fact does not work.
jsonEncode puts the resulting value in double quotes, so instead of test it puts "test" in the _data.fields.

It would be great if you submit a PR here.


Added handling of server side problem reports

Problem reports from the cloud agent were not handled by the wallet.
This PR adds handling of problem reports so that they can be received and processed by the application layer.
Tested against aca-py

@conanoc please review and help merge this.

Could you make a general handler for several problem-report messages? We could also define an AgentEvent with BaseProblemReportMessage.
It would be nice if we had some tests for problem-report.

Presently, there are 4 end-points in aca-py that can be used to send problem reports:

Each of these end-points has a different message type - as an example the issue credential problem report looks like:
{"@type": "https://didcomm.org/issue-credential/1.0/problem-report", "@id": "850b7b82-a8c0-41df-a588-e2ea623caf78", "~thread": {"thid": "321b8c94-4c02-4511-804c-727bacb4aff3"}, "description": {"en": "ERR_TEST", "code": "issuance-abandoned"}}

Thus, there are four message types for problem reports:

https://didcomm.org/issue-credential/1.0/problem-report
https://didcomm.org/present-proof/1.0/problem-report
https://didcomm.org/issue-credential/2.0/problem-report
https://didcomm.org/present-proof/2.0/problem-report

In the present Kotlin framework, a handler can only handle one type of message.
Thus, writing a generic handler is not possible in the present framework.
We can, however, implement a single AgentEvent with BaseProblemReportMessage.
How do you suggest we proceed?

In the present Kotlin framework, a handler can only handle one type of message.

Yes. But, there are several ways to overcome this restriction.

Make MessageHandler.messageType [String] instead of String
Give the message type as a parameter for ProblemReportMessageHandler instead of assigning a fixed type
Register it in the constructor of Dispatcher with multiple types

I think the last one is the easiest.

@conanoc  as per your suggestion, I have consolidated problem reports and created its own command. Thus, the MediationProblemReport is also moved there to be more generic.
For the tests, how do you propose we write the tests for this?

Thank you for the changes. They look good.
For the tests, we could simply send some problem reports and check if the events occurred.
There is a method for preparing two connected agents and a method for waiting for an event.

@conanoc I have tried to add tests too. Please do verify if they are correct. Waiting for an event did not work. However, subscribing to the events and having assertions in the subscription does work. I am not sure if this is the correct approach.

It's okay if the subscription worked. It looks wonderful.
Now, I think we could also update the readme: https://github.com/hyperledger/aries-framework-kotlin/blob/main/README.md#not-supported-yet

@conanoc unfortunately this PR still doesn't implement the RFC 0035. In the RFC, the official message type is:
https://didcomm.org/report-problem/1.0
At least in aca-py the problem reports do not yet use this message type.
However, the present mechanism of reporting problems (1.0) in aca-py has been supported through this PR.

Alright. I'll merge this as it is.


Performance of executeDatabaseContextExpr

For context, I'm currently assessing whether I can use project-m36 as the persistence layer for a web application (I'm hoping that I will be able to!).
I'm currently struggling with the performance of executeDatabaseContextExpr. My test case runs using the NoPersistence strategy (so nothing is being written to the file system or anything).
My test first inserts 100k records in one big batch and then tries inserting records one by one. The simplest case defines no constraints on the data at all. The second case defines just a single unique key (inclusion dependency) for the relvar.
No constraints single insert: ~1s
Single unique key inclusion dependency: ~7s
My target response time to POST requests for a web app would be something like 200ms total, so at the moment, even without any constraints, and only a single relvar, the performance is an order of magnitude away from usability. If scaled up to the context of a full application model (say 20 relvars, each with 10k-1m records, with multiple unique and foreign key constraints) then presumably I'd be looking at insert times of around 60-300s.
I understand that a new persistence layer with constant time transaction commits is in the works, which is definitely necessary, but if anything executeDatabaseContextExpr seems to be a much bigger performance problem.

Excellent info! Would you be able to perform the performance analysis with the GHC profiler?
Currently, our constraints are quite naively implemented so each constraint check likely costs a relation scan. I suspect there is much low-hanging fruit to be found in optimizations, but there may be even lower-hanging fruit in protocol overhead. Are you using the websocket or native Haskell interface?

I will try to do that - is there any particular settings you'd be looking for with the profiler?
I'm actually less concerned about the constraint checking (though that is obviously something that needs to be addressed) than in the no constraint case. For a pure memory insert I was expecting something more in the range of 1ms.
By the way, is this in line with what you would expect, performance wise? It may be the case that I am doing something wrong in the way I am inserting.

If you provide a sample driver script or snippet, I'll take a look. I would also like to include such a script in our performance test suite to catch regressions as well.
There is probably low-hanging fruit to be found in strictness annotations, so this issue might be quick to fix.

@matchwood I ran your benchmark with the patch applied (that I just sent) and I get
benchmarking insertRecord
time                 7.068 ms   (5.479 ms .. 8.400 ms)
                     0.840 R²   (0.791 R² .. 0.898 R²)
mean                 3.796 ms   (3.066 ms .. 4.762 ms)
std dev              2.105 ms   (1.621 ms .. 2.785 ms)
variance introduced by outliers: 98% (severely inflated)

Benchmark project-m36-benchmark: FINISH

Have I measured correctly? Is it the 8,4 ms you'd like to get down below 1 ms, assuming it was changed to have persistence, more relvars and constraints?

@matchwood I ran your benchmark with the patch applied (that I just sent) and I get
benchmarking insertRecord
time                 7.068 ms   (5.479 ms .. 8.400 ms)
                     0.840 R²   (0.791 R² .. 0.898 R²)
mean                 3.796 ms   (3.066 ms .. 4.762 ms)
std dev              2.105 ms   (1.621 ms .. 2.785 ms)
variance introduced by outliers: 98% (severely inflated)

Benchmark project-m36-benchmark: FINISH

Have I measured correctly? Is it the 8,4 ms you'd like to get down below 1 ms, assuming it was changed to have persistence, more relvars and constraints?

I am also working on improving these performance numbers and am integrating matchwood's benchmarks into Project:M36 proper so that we can track these numbers over time. There is definitely low-hanging performance fruit to find and address.

I am also working on improving these performance numbers and am integrating matchwood's benchmarks into Project:M36 proper so that we can track these numbers over time. There is definitely low-hanging performance fruit to find and address.


two sample indices but only one sample output

Version info

bcbio version (bcbio_nextgen.py --version):latest
OS name and version: o2

To Reproduce

Exact bcbio command you have used
Your sample configuration file

Observed behavior
Error message or bcbio output.
Expected behavior
A clear and concise description of what you expected to happen.
I have two sample indices for my indrops sequences, after running bcbio pipeline, I only got one output for one sample. Do you know what my problem is . I have attached all log files
bcbio-nextgen-commands.log
bcbio-nextgen-debug.log
bcbio-nextgen.log
barcode_sample.csv is below:
AGAGGATA,S02
ATAGAGAG,S01
yaml file:
details:

algorithm:
cellular_barcode_correction: 1
minimum_barcode_depth: 1000
sample_barcodes: /n/scratch2/ls360/sc_zebra/config/sample_barcodes.csv
transcriptome_fasta: /n/shared_db/bcbio/biodata/genomes/Drerio/Zv10/rnaseq-2018-03-02/ref-transcripts.fa
transcriptome_gtf: /n/shared_db/bcbio/biodata/genomes/Drerio/Zv10/rnaseq-2018-03-02/ref-transcripts.gtf
umi_type: harvard-indrop-v3
analysis: scRNA-seq
description: Burns
files:

/n/scratch2/ls360/sc_zebra/input/Burns_1.fq.gz
/n/scratch2/ls360/sc_zebra/input/Burns_2.fq.gz
/n/scratch2/ls360/sc_zebra/input/Burns_3.fq.gz
/n/scratch2/ls360/sc_zebra/input/Burns_4.fq.gz
genome_build: Zv10

Log files
Please attach (10MB max): bcbio-nextgen.log, bcbio-nextgen-commands.log, and bcbio-nextgen-debug.log.
Additional context
Add any other context about the problem here.

Sorry about that, I think our documentation might be a little off. Do you end up with this problem if you take the barcode_sample.csv file and just make it one line per barcode?
AGAGGATA
ATAGAGAG

Thank you for your reply. I just tried and only got the last sample (ATAGGAG) result also.

Thanks, ok I can reproduce the problem-- I'm pretty sure it is an issue with umis, I'll fix it today.

Was the barcodes.csv file created on Windows? I figured out the problem. The barcodes.csv file has a byte order heading up front:
file barcodes.csv
barcodes.csv: UTF-8 Unicode (with BOM) text

which causes the barcodes to get parsed incorrectly:
ipdb> [x.strip() for x in barcodes]
['\ufeffAGAGGATA', 'ATAGAGAG']

if I make the same file on UNIX, I don't see this problem. You can fix the barcode your file by doing:
dos2unix /n/scratch2/ls360/sc_zebra/config/sample_barcodes.csv

and you should be all set. I'll catch this and fix this in the umis repository, but that should get you going. Thanks!

Thank you so much! I am going to re-run it based on your suggestion and will update to you the result. Can I ask one question? Does BCBIO provide the total number of cells for each sample, information such as how many reads trimmed and mapped from the output folder? It seems I cannot find this type of information.

Hi Liang,
It doesn't, if we need to know that stuff we usually just do it by using the alignment files and what ended up in the work/umis directory. It would be good to calculate those things and make a MultiQC report with them in it though, we just have not gotten around to doing it.

Got it. Thank you Rory. Does bcbio provide gene symbol for all genes ID in features.tsv.gz file (or mtx.rowname file)? It seems that I only have Ensembl gene ID but no symbol (10x has gene symbols) in this output file.  If there is no mitochondria gene symbol there, it seems percent.mt of volinplot in Seurat is alway 0. Just wondering if this is normal for bcbio pipeline? Thank you so much.

Hi Liang,
It's normal-- there isn't really a 1-1 mapping between symbols and gene IDs so we keep everything at the level of the ID and let the user decide how they want to annotate the IDs later on.

Hi Rory,
I confirm that your solution worked for me. Thank you Rory.

Thanks for following up!


nfd: Update NFD CR's to support SGX EPC

Fixes https://github.com/intel/intel-technology-enabling-for-openshift/issues/255
Removed SGX extraLabelNs and resourceLabels from NodeFeatureDiscovery CR. Added SGX EPC as
extendedResources:
        sgx.intel.com/epc<EMAIL_ADDRESS>
in the NodeFeatureRule CR.
With these changes, initContainer in SGXDevicePlugin CR wont be used (in Intel device plugins 0.29.0)
Signed-off-by: vbedida79<EMAIL_ADDRESS>

It is a good job. Could you add more technical detail about this PR in the commit log? It is great if we have a github issue in the commit log for detail about this fixing. Thanks!

Created https://github.com/intel/intel-technology-enabling-for-openshift/issues/255, added in commit log


[Snyk] Fix for 1 vulnerabilities

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to fix one or more vulnerable packages in the `npm` dependencies of this project.
Changes included in this PR

Changes to the following files to upgrade the vulnerable dependencies to a fixed version:

package.json
package-lock.json

Vulnerabilities that will be fixed
With an upgrade:

Severity
Priority Score (*)
Issue
Breaking Change
Exploit Maturity

696/1000  Why? Proof of Concept exploit, Has a fix available, CVSS 7.5
Regular Expression Denial of Service (ReDoS) SNYK-JS-ANSIREGEX-1583908
Yes
Proof of Concept

(*) Note that the real score may have changed since the PR was raised.

Commit messages

Package name: html-webpack-plugin
    The new version differs by 93 commits.

873d75b chore(release): 5.5.0
ddeb774 chore: update examples
1e42625 feat: Support type=module via scriptLoading option
7d3645b Bump pretty-error to 4.0.0 to fix transitive vuln for ansi-regex CVE-2021-3807
79be779 [chore] changes actions to run on pull_requests
b7e5859 [chore] fixes CI to avoid race conditions
48131d3 chore(release): 5.4.0
16a841a [chore] rebuild examples
3bb7c17 Update index.js
e38ac97 Update index.js
f08bd02 [chore] updates fixtures
d62a10f [chore] upgrades<EMAIL_ADDRESS>-> 6.0.2
2f5de7a Remove archived plugin
8f8f7c5 chore(release): 5.3.2
053c6e6 chore: update snapshot tests for webpack 5.4.0
9c7fba0 Fix security vulnerabilities
b98fbeb Fix security vulnerabilities
25cdfc7 Added inject-body-webpack-plugin to readme
0e4c1fb Update README to document actual behavior
0a6568d chore(release): 5.3.1
82d0ee8 fix: remove loader-utils from plugin core
6f39192 chore(release): 5.3.0
d654f5b feat: allow to modify the interpolation options in webpack config
41d7a50 feat: drop loader-utils dependency

See the full diff

Package name: webpack-dev-server
    The new version differs by 250 commits.

c9271b9 chore(release): 4.0.0
18bf369 test: fix stability (#3676)
cdcabb2 fix: respect protocol from browser for manual setup (#3675)
1768d6b fix: initial reloading for lazy compilation (#3662)
4f5bab1 docs: improve examples (#3672)
f2d87fb fix: improve https CLI output (#3673)
0277c5e chore: remove redundant console statements (#3671)
16fcdbc docs: add `ipc` example (#3667)
8915fb8 test: add e2e tests for built in routes (#3669)
4d1cbe1 docs: ask `version` information in issue template (#3668)
b6c1881 chore(deps-dev): bump core-js from 3.16.1 to 3.16.2 (#3666)
ffa8cc5 chore(deps-dev): bump supertest from 6.1.5 to 6.1.6 (#3665)
f1fdaa7 chore(release): 4.0.0-rc.1
c4678bc fix: legacy API (#3660)
d8bdd03 test: fix stability (#3661)
22b1414 refactor: remove `killable` (#3657)
75bafbf test: add e2e tests for module federation (#3658)
493ccbd chore(deps): update `ws` (#3652)
ae8c523 test: add e2e test for universal compiler (#3656)
f94b84f chore(deps): update (#3655)
1923132 test: fix cli
2adfd01 test: fix todo (#3653)
6e2cbde fix: proxy logging and allow to pass options without the `target` option (#3651)
c9ccc96 fix: respect infastructureLogging.level for client.logging (#3613)

See the full diff

Check the changes in this PR to ensure they won't cause issues with your project.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
🛠 Adjust project settings
📚 Read more about Snyk's upgrade and patch logic

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.

These packages are already updated - closing


Add an SPF record for email handling

This record is recommended by the ImprovMX setup procedures, which we are using for managing dandiarchive.org email addresses.

@dchiquito you can review if you like, but it looks like I got the syntax etc. right so it's optional.
@brianhelba can you advise on whether this is likely to be needed or not? It looks like we may be having trouble with ImprovMX forwarding mail sent to dandiarchive.org addresses along to mit.edu. The web app says our setup is incomplete and recommends adding this record. Does this look like something that is (1) needed and/or (2) would explain why messages are not being delivered?

This makes sense. Typically, having an SPF for a service which only handles incoming mail (normal outgoing mail from the server is still sent via AWS SES) wouldn't make sense. However as you note, ImprovMX is also the source of outgoing email for anything it forwards, so this seems like it might help deliverability.
The other technology option for email verification is DKIM, which maybe ImprovMX also supports?


Allow replacing part of changelogs or commit message using replace_command

Is there an existing issue or pull request for this?

[X] I have searched the existing issues and pull requests

Feature description
Currently the behaviour of replace and replace_command are inconsistent. replace will replace all matches of pattern with a given string, whereas replace_command replaces the entire string as long as at least one match was found.
See TextProcessor.run:228 for references.
For example, the following changelog.postprocessor will replace the entire changelog instead of only the matched occurrences of <REPO>.
postprocessors = [
  { pattern = '<REPO>', replace_command = 'echo "https://github.com/orhun/git-cliff"' }
]

Desired solution
This issue is intended to serve as a place to discuss possible solutions.
Alternatives considered
None
Additional context
No response

The inconsistent behaviour in TextProcessor.run:228 makes coming up with a non-breaking and clean solution difficult. Thus I think we need to decide whether we are willing to do a breaking change. If we are, we could change replace_command to replace each match like replace does.
The switch between the old and new behaviour could be reintroduced by having an alternative match to the current pattern. If pattern is used, the entire string is replaced. If match is used, only the matches are replaced.

Let's not make a breaking change with this one. Can you share some config snippets / usage examples about how the new match option will look like? I would say let's agree on something simple and document both behaviors.

definitely interested in this functionality as I would like to be able to switch out the repo url dynamically from our build system and would rather not have to call another script post changelog generation.  I understand the desire to not to introduce a breaking change but surely that's the point of semver. Alternatively adding an additional parameter, or a different replace_  option makes it non breaking but allows introduction of the requested functionality?
And obv supporting env var / shell commands as replace_command does would be key too.

I've done some more thinking on this since opening the issue, and I strongly believe that a breaking change would be the best case of action. The inconsistent behaviour of replace and replace_command is difficult to reason for. Any attempts I have made to introduce additional parameters that would allow replacing just part of the changelog using external commands were unsuccessful.
The current behaviour of replace_command is needed for use cases like running the entire changelog through external tools like typos. This functionality could easily be achieved by changing the pattern used from .* to (?s:.*). The flag s allows . to match newlines, thus making the pattern match the entire string.

@orhun, could you chime in on this? If a breaking changes is permissible, I'd give implementing it a shot.

I gave this another thought and I guess making a breaking change is tolerable for the sake of having a more consistent functionality. @Cyclonit sure, go ahead!

I don't really see a reason for an immediate breaking change if a simple additional field could solve the issue in a backward-compatible way:
postprocessors = [
  { pattern = '<REPO>', replace_command = 'echo "https://github.com/orhun/git-cliff"', local_replace = true }
]

or similar. AFAIU local_replace would default to true for replace and to false for replace_command, which is obviously confusing, but it could be a temporary workaround and the breaking change could be added to a queue for a 3.0 release

I don't think a breaking change is necessary, and I get some millage out of the existing behavior. I think this is just a case of Naming Is Hard™ and a poorly named API. The existing replace and replace_command sound like they are related, when really one is a linewise filter and one is a search and replace. Maybe replace_command should have been called pipe_line or something. In any case it sounds like what you guys want is just another new mode, and either a new command that operates on the pattern match instead of lines where a match was made or a new flag changing the meaning of the current command sound like better options than rug-pulling the feature some of like the way it is now.

I think this is just a case of Naming Is Hard™ and a poorly named API.

Unfortunately yes 😔


Implement from_reader deserialization without loading all content in memory

The purpose to use a reader is to not have to load/wait all content to start processing.
For the moment, a call to de::from_reader call read_to_end on the reader, and fill a Vec<u8> with the content.
It could be bad, especially with large file.
I have take a look at serde json crate : they have a more adapted implementation.
It could be possible to take their implementation as inspiration to implement it ?
Or even extract the part of the code that manage Read to share it ? (If there is nothing specific to JSON) ?
I could be interested to tried to implement it, but I prefer ask before start to do some stuff if there is some started work on this, or preference about how to implement this.

I think my immediate answer would be yes and no.
All low-level deserialization is handled by the Parser struct, which internally manages the full &str, which is only accessed in four lines of code. So it might be relatively easy to instead allow the Parser to manage to potentially incomplete buffered string that is read in further if more content is required.
On the other hand, the parser currently has to support (almost) arbitrary backtracking (in the worst case across the entire document), so at some point it needs to have read all content in. The backtracking is required for deserialize_any, where RON needs to sometimes peek quite far ahead to see if we're parsing a struct, tuple, etc.
Since we currently need to at some point have the full RON string in memory to support the worst case, reading it all in in the beginning simplifies the code (and is faster than reading it in bit by bit).
If we really want to support streaming (where possible, again there are cases where we cannot prevent needing access to the full document in memory, but that worst case would be triggered by a user of RON), the first step would be to establish a second cursor in the Parser that tracks the lower bound of content that we still need to access. Once we would have both this new lower bound (never read anything earlier than this again) and the current upper bound (read in more when we try to read beyond it), the parser's inner state could then become a buffer that really on tracks the bytes in between those two. In most cases, both cursors would be the same, and RON would be able to support proper streaming.
I'd be really happy to review your contributions towards this!

Thank you @juntyr .
I'm keeping this on my to-do list and will try to do some testing on this shortly.


Manage the elasticsearch service file (systemd) via the elasticsearch module

Module version: 6.4.0
Puppet version: 5.3
OS and version: centos7.6

Feature Description
The Elasticsearch service systemd file is deployed by the elasticsearch puppet module.
At the moment it is not possible to apply systemd directives (https://www.freedesktop.org/software/systemd/man/systemd.directives.html) to the configuration file from the Elasticsearch class.
My workaround right now is updating elasticsearch.systemd.erb:

[Unit]
Description=Elasticsearch instance <%= @resource[:instance] %>
Documentation=http://www.elastic.co
Wants=network-online.target
After=network-online.target
< my change is the line below >
<% if SOME_CONDITION %>AssertPathIsMountPoint=<%= Facter.value('SOME_VALUE') %><% end %>

In my case, I need to make sure that my data dir is mounted on data nodes before I start the service.
Adding a parameter to send these directives to the template will be enough in my opinion, maybe something like this:

[Unit]
Description=Elasticsearch instance <%= @resource[:instance] %>
Documentation=http://www.elastic.co
Wants=network-online.target
After=network-online.target
<% directives.each do |key,value| -%>
<%= key %>=<%= value %>
<% end %>

You can achieve this with a systemd drop-in in your profile etc.


add PIM for Groups to AAD baseline instructions for 7.6 through 7.9

🗣 Description
Modify the AAD baseline document instructions for policies 7.6 through 7.9 to incorporate PIM for Groups. There is a coding issue that is currently in the works that aligns with these changes as well.
Closes #920
✅ Pre-approval checklist

[x] This PR has an informative and human-readable title.
[x] PR targets the correct parent branch (e.g., main or release-name) for merge.
[x] Changes are limited to a single goal - eschew scope creep!
[x] Changes are sized such that they do not touch excessive number of files.
[x] All future TODOs are captured in issues, which are referenced in code comments.
[x] These code changes follow the ScubaGear content style guide.
[x] Related issues these changes resolve are linked preferably via closing keywords.
[x] All relevant type-of-change labels added.
[x] All relevant project fields are set.
[x] All relevant repo and/or project documentation updated to reflect these changes.
[x] Unit tests added/updated to cover PowerShell and Rego changes.
[x] Functional tests added/updated to cover PowerShell and Rego changes.
[x] All relevant functional tests passed.
[ ] All automated checks (e.g., linting, static analysis, unit/smoke tests) passed.

✅ Pre-merge checklist

[ ] PR passed smoke test check.

[ ] Feature branch has been rebased against changes from parent branch, as needed
Use Rebase branch button below or use this reference to rebase from the command line.

[ ] Resolved all merge conflicts on branch

[ ] Notified merge coordinator that PR is ready for merge via comment mention

✅ Post-merge checklist

[ ] Feature branch deleted after merge to clean up repository.
[ ] Verified that all checks pass on parent branch (e.g., main or release-name) after merge.

@nanda-katikaneni ready for merge


Set Terragrunt defaults in terragrunt.hcl file

this is a duplicate of https://github.com/gruntwork-io/terragrunt/issues/2849
Currently, Terragrunt is able to pass extra arguments and set environment variables for Terraform using hooks or run_cmd() command. However, this does not work for Terragrunt itself.
For example, we constantly have to type terragrunt run-all plan --terragrunt-non-interactive, whereas I would want to set this flag in terragrunt.hcl file (or as an env var TERRAGRUNT_NON_INTERACTIVE=true) and have Terragrunt honour it.
Describe alternatives you've considered

Wrapper for terragrunt executables, such as Makefiles and bash scripts - but those are messy.
Setting TERRAGRUNT_ variables manually on the CLI before running Terragrunt but, again, yet another step and more typing that shouldn't be needed.

Additional context If there's any way to set Terragrunt defaults within itself, that would be great as the number of options is growing and can make for a messy and long command line.

Hey @mossad-zika , we've talked about this internally, and we have some designs in mind.
The design that we're considering right now is basically to have a .terragruntrc.json file that can go in places you would typically expect it:

Current working directory.
Root of repository.
In .config directory at root of repository.
Home directory of user.

The file would be parsed, then set Terragrunt flags with names that match the names of flags, so it would be pretty easy to guess how configurations would be set.
In the future there may be other configurations that we'd add to this, but that's our general thought process right now.
Marking the issue as preserved, as we plan to address this, but it's just not a top priority right now.
If you would like this issue resolved earlier, consider cutting a pull request to deliver this.

Yes! This!
And please please please use JSON and not yaml 😅

Something to consider is that this is becoming more important, as we're evaluating changing some defaults in how Terragrunt behaves.
This flag, for example, is not a great default for Terragrunt to have, but is also non-trivial to remove. It's nice for users to have that check happen whenever they try to destroy something, and it's only useful when users don't know that there's a dependency on something they're destroying, so it's not great to opt-in to that functionality. We could have some recommended .terragruntrc.json files in the docs for that feature that explicitly enable the check for users that are willing to accept the performance penalty.


Transaction Receipts do not include logsBloom

The transaction receipts are missing the logsBloom property. Below are outputs from a non-specific transaction using testrpc and parity where the property is available.
Test with testrpc
truffle(development)> web3.eth.getTransactionReceipt("0x14e5bd5756ce051493736bb003e1ac9c738d276aa6b732accf90b636c6d2e5c8")
{ transactionHash: '0x14e5bd5756ce051493736bb003e1ac9c738d276aa6b732accf90b636c6d2e5c8',
  transactionIndex: 0,
  blockHash: '0xddb832236ccc486adbdae6282432b2363dd9995ded167573d950c9c9e11568ef',
  blockNumber: 57,
  gasUsed: 2401314,
  cumulativeGasUsed: 2401314,
  contractAddress: null,
  logs:
   [ { logIndex: 0,
       transactionIndex: 0,
       transactionHash: '0x14e5bd5756ce051493736bb003e1ac9c738d276aa6b732accf90b636c6d2e5c8',
       blockHash: '0xddb832236ccc486adbdae6282432b2363dd9995ded167573d950c9c9e11568ef',
       blockNumber: 57,
       address: '0x09a8c3968b660d9c9646aefe420f741a5e891e1b',
       data: '0x0',
       topics: [Array],
       type: 'mined' },
     { logIndex: 1,
       transactionIndex: 0,
       transactionHash: '0x14e5bd5756ce051493736bb003e1ac9c738d276aa6b732accf90b636c6d2e5c8',
       blockHash: '0xddb832236ccc486adbdae6282432b2363dd9995ded167573d950c9c9e11568ef',
       blockNumber: 57,
       address: '0x557227efe117a5fd3ba0f0df559694fb8cbb9e0b',
       data: '0x0',
       topics: [Array],
       type: 'mined' },
     { logIndex: 2,
       transactionIndex: 0,
       transactionHash: '0x14e5bd5756ce051493736bb003e1ac9c738d276aa6b732accf90b636c6d2e5c8',
       blockHash: '0xddb832236ccc486adbdae6282432b2363dd9995ded167573d950c9c9e11568ef',
       blockNumber: 57,
       address: '0x09a8c3968b660d9c9646aefe420f741a5e891e1b',
       data: '0x0',
       topics: [Array],
       type: 'mined' },
     { logIndex: 3,
       transactionIndex: 0,
       transactionHash: '0x14e5bd5756ce051493736bb003e1ac9c738d276aa6b732accf90b636c6d2e5c8',
       blockHash: '0xddb832236ccc486adbdae6282432b2363dd9995ded167573d950c9c9e11568ef',
       blockNumber: 57,
       address: '0x1fd3a85a88ea6b1416024017f8fc32bf2f92bab1',
       data: '0x0',
       topics: [Array],
       type: 'mined' },
     { logIndex: 4,
       transactionIndex: 0,
       transactionHash: '0x14e5bd5756ce051493736bb003e1ac9c738d276aa6b732accf90b636c6d2e5c8',
       blockHash: '0xddb832236ccc486adbdae6282432b2363dd9995ded167573d950c9c9e11568ef',
       blockNumber: 57,
       address: '0x557227efe117a5fd3ba0f0df559694fb8cbb9e0b',
       data: '0x0',
       topics: [Array],
       type: 'mined' },
     { logIndex: 5,
       transactionIndex: 0,
       transactionHash: '0x14e5bd5756ce051493736bb003e1ac9c738d276aa6b732accf90b636c6d2e5c8',
       blockHash: '0xddb832236ccc486adbdae6282432b2363dd9995ded167573d950c9c9e11568ef',
       blockNumber: 57,
       address: '0x1fd3a85a88ea6b1416024017f8fc32bf2f92bab1',
       data: '0x0',
       topics: [Array],
       type: 'mined' } ],
  status: 1 }

Test against Parity:
truffle(development)> web3.eth.getTransactionReceipt("0x0ecedc318e0650f6c9e4c209866dac3f6629b6f9b3f0e663f061531add4e3b87")
{ blockHash: '0xdf268557e3ab89c4312f1f6b2b479a0a8d2bcc8e61310b6652a20afb2d7e0de9',
  blockNumber: 3928,
  contractAddress: null,
  cumulativeGasUsed: 2401314,
  gasUsed: 2401314,
  logs:
   [ { address: '0x9d62edd98de4b87b5a533b9a25b0087128f92ac3',
       blockHash: '0xdf268557e3ab89c4312f1f6b2b479a0a8d2bcc8e61310b6652a20afb2d7e0de9',
       blockNumber: 3928,
       data: '0x',
       logIndex: 0,
       topics: [Array],
       transactionHash: '0x0ecedc318e0650f6c9e4c209866dac3f6629b6f9b3f0e663f061531add4e3b87',
       transactionIndex: 0,
       transactionLogIndex: '0x0',
       type: 'mined' },
     { address: '0xfe70de0ed1c5b77be4f1c3fd70cfd5ec3c61b810',
       blockHash: '0xdf268557e3ab89c4312f1f6b2b479a0a8d2bcc8e61310b6652a20afb2d7e0de9',
       blockNumber: 3928,
       data: '0x',
       logIndex: 1,
       topics: [Array],
       transactionHash: '0x0ecedc318e0650f6c9e4c209866dac3f6629b6f9b3f0e663f061531add4e3b87',
       transactionIndex: 0,
       transactionLogIndex: '0x1',
       type: 'mined' },
     { address: '0x9d62edd98de4b87b5a533b9a25b0087128f92ac3',
       blockHash: '0xdf268557e3ab89c4312f1f6b2b479a0a8d2bcc8e61310b6652a20afb2d7e0de9',
       blockNumber: 3928,
       data: '0x',
       logIndex: 2,
       topics: [Array],
       transactionHash: '0x0ecedc318e0650f6c9e4c209866dac3f6629b6f9b3f0e663f061531add4e3b87',
       transactionIndex: 0,
       transactionLogIndex: '0x2',
       type: 'mined' },
     { address: '0x7d3f80eaadbc9df1e2f0a5142473f8e6502d2cef',
       blockHash: '0xdf268557e3ab89c4312f1f6b2b479a0a8d2bcc8e61310b6652a20afb2d7e0de9',
       blockNumber: 3928,
       data: '0x',
       logIndex: 3,
       topics: [Array],
       transactionHash: '0x0ecedc318e0650f6c9e4c209866dac3f6629b6f9b3f0e663f061531add4e3b87',
       transactionIndex: 0,
       transactionLogIndex: '0x3',
       type: 'mined' },
     { address: '0xfe70de0ed1c5b77be4f1c3fd70cfd5ec3c61b810',
       blockHash: '0xdf268557e3ab89c4312f1f6b2b479a0a8d2bcc8e61310b6652a20afb2d7e0de9',
       blockNumber: 3928,
       data: '0x',
       logIndex: 4,
       topics: [Array],
       transactionHash: '0x0ecedc318e0650f6c9e4c209866dac3f6629b6f9b3f0e663f061531add4e3b87',
       transactionIndex: 0,
       transactionLogIndex: '0x4',
       type: 'mined' },
     { address: '0x7d3f80eaadbc9df1e2f0a5142473f8e6502d2cef',
       blockHash: '0xdf268557e3ab89c4312f1f6b2b479a0a8d2bcc8e61310b6652a20afb2d7e0de9',
       blockNumber: 3928,
       data: '0x',
       logIndex: 5,
       topics: [Array],
       transactionHash: '0x0ecedc318e0650f6c9e4c209866dac3f6629b6f9b3f0e663f061531add4e3b87',
       transactionIndex: 0,
       transactionLogIndex: '0x5',
       type: 'mined' } ],
  logsBloom: '0x08000800040000000000000000000000000000200000020000000001000000000000000040050000000020010000000000000000000000080000000000000000000001000000000000000000000000000000000000080000000000000000000000000000000000000000000000008000000000000001000000000000000800020000000000000000000000000002000000000000000000000040000000000080100000000000000000000000000000000000000000000000000000000080000000000000000000020000000020000000000000001000000000000000000000000000000800000000000000000000000000000000000000000000000000000000',
  root: '0x265e46500c11b96b190c6284b9e8aae8ff6f0d1f0516898450a569db74916c62',
  transactionHash: '0x0ecedc318e0650f6c9e4c209866dac3f6629b6f9b3f0e663f061531add4e3b87',
  transactionIndex: 0 }

The property is otherwise available on the block using testrpc.
truffle(development)> web3.eth.getBlock(57)
{ number: 57,
  hash: '0x6bfae935b6405c854aa743c7cbbc084def16feb0c7891de2a48ca49b94ad4219',
  parentHash: '0xd1eb4098b32f0340a90c03f7806f592c2c77f868b9545f9cde619a8abf3a813e',
  nonce: '0x0',
  sha3Uncles: '0x1dcc4de8dec75d7aab85b567b6ccd41ad312451b948a7413f0a142fd40d49347',
  logsBloom: '0x00000000001000000000000000000000000000000000020000000000000100000000000000000000000020010000000000000240000000080004000000000800000000000000000000000000000000000000000000080001000002000000000000000000000000000000000000000000000000000000002000400000000001020000000000000000000000000000000000000000000000000000000000000100000000000000002000000009000000500000000000000080000000000000000000000000000000000000000000000000000000000000000000000000000000000000000001000000000100000000000000000400000000000000000000000000',
  transactionsRoot: '0x56e81f171bcc55a6ff8345e692c0f86e5b48e01b996cadc001622fb5e363b421',
  stateRoot: '0x25d0fdcd5c9fafc00f7a7f474cdb223fe383feaf8b55370abf7430ddfc0f98cb',
  receiptsRoot: '0x56e81f171bcc55a6ff8345e692c0f86e5b48e01b996cadc001622fb5e363b421',
  miner: '0x0000000000000000000000000000000000000000',
  difficulty: BigNumber { s: 1, e: 0, c: [ 0 ] },
  totalDifficulty: BigNumber { s: 1, e: 0, c: [ 0 ] },
  extraData: '0x0',
  size: 1000,
  gasLimit: 6721975,
  gasUsed: 2401314,
  timestamp:<PHONE_NUMBER>,
  transactions:
   [ '0x322b5c0eed38e5f226881b366bef40709125eeeab3f3216b42cc8a220aa02106' ],
  uncles: [] }

According to the yellow paper, both the block and the transaction receipt define logsBloom in their properties.

@elenadimitrova per the JSON RPC wiki, the logsBloom field is meant to be defined on the eth_getBlock* responses, but not on eth_getTransactionReceipt.
That said, I'm still uncertain as to how much we should treat that wiki page as a spec. Further, I need to balance the goal of adhering to the spec (weakly-defined as it is) so that people write dapps which are portable across ethereum clients, against supplying people what they need in order to test their Dapps adequately for their environments.
As a rule, we usually do our best to follow the RPC wiki page unless there's disagreement amongst major client implementations. In that case, we tend to take the intersection of functionality between Parity and geth rather than the union.
To help me make the decision:

Can you work around not having this field, or does this block your progress in some way?
Do you know whether geth or any other clients provide this field on eth_getTransactionReceipt?

It is breaking for ethers which expects this in the transaction receipt
https://github.com/ethers-io/ethers.js/blob/511fff1390ba56ba56237053fd00ae0ec87b1e7b/providers/provider.js#L296
As for geth this also returns logsBloom in the transaction receipt:
truffle(development)> web3.eth.getTransactionReceipt('0x485bacde24723e24c6eb278000c08cb95094f0c69e205aa39cfa9353f97db869')
{ blockHash: '0x2d43d6141761537eef97e00eb4f919cd8da4d27fa580cbc6f02981d77756a468',
  blockNumber: 5317,
  contractAddress: '0xab56c45847c68007cffe7d80cabdb24043d1b08f',
  cumulativeGasUsed: 630488,
  from: '0xc46fbd443feca41354c6ebfd36cea7d89c555bea',
  gasUsed: 630488,
  logs:
   [ { address: '0xab56c45847c68007cffe7d80cabdb24043d1b08f',
       topics: [Array],
       data: '0x',
       blockNumber: 5317,
       transactionHash: '0x485bacde24723e24c6eb278000c08cb95094f0c69e205aa39cfa9353f97db869',
       transactionIndex: 0,
       blockHash: '0x2d43d6141761537eef97e00eb4f919cd8da4d27fa580cbc6f02981d77756a468',
       logIndex: 0,
       removed: false } ],
  logsBloom: '0x00000002000000000010000000000000000000000000020000000000000000000000000000000000000000000000000000000000000000080000000000000000000000000000000000000000000000000000000000080000000000000000000004000000000000000000000000000000000000000000002000000080000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000080000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000',
  root: '0x8c78a5f75f32094b64befcd08b1890c05c6d6f64a33557289ebd3548bb1b7fe3',
  to: null,
  transactionHash: '0x485bacde24723e24c6eb278000c08cb95094f0c69e205aa39cfa9353f97db869',
  transactionIndex: 0 }

This points to omission in the JSON RPC wiki but the yellow paper clearly defines it.

That's good enough for me, then - we'll go ahead and add it.

From comparison of both objects you submitted, it seems we also don't respond with the root field.

As per the JSON RPC this is actually correct as it states the transaction receipt returns either the root (pre Byzantium) or the status. The latter is returned in testrpc.
To enable that in parity we had to switch to 1.8.3-beta and turn the "eip658Transition": 0 parameter in config. We haven't tried in geth yet.

@elenadimitrova what version of geth was that output from above? It seems strange that it also has the root field but is missing the status field. Looks like I need to fire up a light client for myself...

I'm on geth Version: 1.7.3-stable

I've installed Ganache v1.2.0-beta.0 and I am still getting this problem when using Ethers.js
Should this fix be included in the v1.20 release?
Thanks

I caught up with @naddison36 offline, but for those reading along, this is in the v1.1.0-beta.1 release which is up now.

Thanks, @benjamincburns. I can confirm that the new version fixed this problem


Make ScriptVersion.Latest default for JS files

As just discussed we should make sure that Latest becomes the default for JS files when fed into the TypeScript compiler/language service.

we talked about a new option "JSLanguageVersion" (or some better name), that if present will enforce some "restrictions" on the syntax allowed in JS files. If you agree, i think this is already tracked by #4556.

Makes sense to me.


Build Issue - WSL - Cannot create GLFW window.

This could be an OHS problem.  I'm on windows 10 with Ubuntu 18.04 installed in WSL.  I made it through the build instructions and have (eventually, I believe) installed everything I need to get OpenGL working.
When I try to run djv, I get:  "ERROR:  Cannot create GLFW window."
I did:  sudo apt install ubuntu-desktop mesa-utils
and prior to doing that I had X-windows apps working with VcXsrv.
I tested glxgears and it works, so I believe that, in addetion X-windows,  the OpenGL stuff is all in order.
I also tried installing djv directly from the .deb file, and I'm seeing the same error, so this is probably some complexity in using djv with WSL.

Hi, thanks for the bug report, I actually never considered running DJV via WSL. Are you running WSL 1 or 2?

WSL 1!  I thought I was on 2, I'll update that and retry - didn't realize I
had to upgrade that by hand.  Thanks :-)
PS C:\Users\sqeva> wsl -l -v
NAME            STATE           VERSION

Ubuntu-18.04    Running         1
PS C:\Users\sqeva> systeminfo | Select-String "^OS Name","^OS Version"

OS Name:                   Microsoft Windows 10 Home
OS Version:                10.0.19041 N/A Build 19041
On Mon, Aug 31, 2020 at 9:24 AM Darby Johnston<EMAIL_ADDRESS>wrote:

Hi, thanks for the bug report, I actually never considered running DJV via
WSL. Are you running WSL 1 or 2?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/darbyjohnston/DJV/issues/350#issuecomment-683884387,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AOUGKQUABO4IOEKTNAFHDQ3SDPFEFANCNFSM4QQC6FXQ
.

Oh, sorry, I'm not sure WSL 2 will fix the issue, I just wanted to check which one you are using.
Doing a quick search, it looks like this issue might have some leads?
https://github.com/alecjacobson/computer-graphics-bounding-volume-hierarchy/issues/43

Yeah, I'm not confident it's even do'able :-)
I'll dig into that github thread and see if I can get anything from it.
"Bounding Volume Hierarchy" - haha!
BTW, I'm just hacking around, really.  I haven't really done much
development for years, so I'm a bit rusty.  I did notice, after I submitted
the bug, that that error is coming from within DJV, so, at some point, I'll
just drop into the debugger and see if I can tell what's choking :-)
sk....
On Mon, Aug 31, 2020 at 1:07 PM Darby Johnston<EMAIL_ADDRESS>wrote:

Oh, sorry, I'm not sure WSL 2 will fix the issue, I just wanted to check
which one you are using.
Doing a quick search, it looks like this issue might have some leads?
alecjacobson/computer-graphics-bounding-volume-hierarchy#43
https://github.com/alecjacobson/computer-graphics-bounding-volume-hierarchy/issues/43
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/darbyjohnston/DJV/issues/350#issuecomment-684009612,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AOUGKQSSIDORHHW7LFX7OWDSDP7IBANCNFSM4QQC6FXQ
.

No problem, I'm happy to answer any questions or help with troubleshooting. Also if there are parts of the documentation that aren't clear let me know and I'll try and fix them up.

Sorry - i've been offline for a bit.  Yes - I just got the WSLg stuff working so I was going to be taking a look at this again soon.


Add tiling to speed CPU code

Past versions relied on sharing of memory between core.
Make this explicit now.

CC @wasade

On a EPYC 7302, computing 50k EMP+AG:
The Unweighted goes from 370s to 300s.
The Weighted Normalize goes from 1.3ks to 1.1ks.


Average out line counter

If >= 8/10 line counters are valid, use it to iterate the next frame

Maybe two rounds of correction?
One sure shot (8/10) round, corrects every next block
Second majority vote (current implementation)


feat(trading): portfolio assets tab

Related issues 🔗
Closes #6683
Description ℹ

removes other tabs on Portfolio sidebar
adds Search field to the assets breakdown
adds combined deposit button

Demo 📺

Technical 👨🔧
N/A

Reviewed connected to mainner to excuse the dead icons.
Tabs are gone ... Sort looks good

Search works

I do wonder if it is not obvious enough that you need to click to expand it, and this is compounded by that little menu in the top right which a user might think is where they should click rather than anywhere else and when they do ultimately they get a less nice experience.

On the deposit, I think this little dropdown works reasonably well. Probably better than a whole dedicated screen just to make the choice

BUT ... I do think there are two issues:

If you just click and dont notice the dropdown you end up on same chain deposit and might not realise the cross chain is there
If you select cross-chain it doesnt remember that for next time and the button still will take you to same chain

I think either:

A simple click should just open that little dropdown menu so you always have to make the selection, then you dont need seperate button for the dropdown
The button should remember your last selection and take you there again next time.  If we went with this we should consider adding a button maybe in the top right that says "Switch to same-chain deposit" / "Switch to cross-chain deposit" so its easy to swap if you'ce been stickily led to somethig you didnt want to be

This all looks good to me now
Lets merge it and if we decide we need to rename the deposit types we can easily do that later


chore: remove chaincode mention

Description

How has this been tested?

Checklist

[ ] changelog was updated with notable changes
[ ] documentation was updated

/e2e --tests sdk


Show diff only once

As you can nicely see in the diff, the condition
if show_diff or self.config.get('show_diff', False) is True:

exists twice and results in printing the diff twice if there are any differences. Remove one of them.

Looks great, thanks!


restore hive clusters information during activation

Signed-off-by: Valentina Birsan<EMAIL_ADDRESS>https://github.com/stolostron/backlog/issues/26541
Hive is actively reconciling managed clusters even on passive hubs
https://coreos.slack.com/archives/CTZTHFQRH/p1666365271051289?thread_ts=1666345043.694069&cid=CTZTHFQRH
Move hive.openshift.io backed up resources to the activation stage

/cherry-pick release-2.6


Bibliography

I am not sure if this will be a problem, it just my professor from other before told us it better not put Wikipedia as reference.

Thanks. Agreed, but the documentation is somewhat lacking... I did finally find one good reference to explain the algorithm... It's a very old technique from the 1980s and is now a low level operation on GPUs. I left the wiki ref alongside it for further reading as it contains some images explaining the method.


single zot server instance should support multiple storage backends

At present a single zot instance have only one single storage i.e being specified in config file e.g
"storage":{
    "rootDirectory":"/tmp/zot"
  }

but now we want zot to be scalable in terms of storage and restriction is to be done using single zot server instance.

Implementation details:-

Adding SubPaths section in storage section of config file, now storage config on top level will act as global storage. This way we are keeping our old config intact.
Each element of SubPaths will have RootDirectory, Dedupe and GC field same as storage section.
There will be total n+1 instance of zot running in background (n - elements of subpath section and +1 global).

e.g. storage section now look like this if we add subpath
"storage": {
       "rootDirectory": "/tmp/zot",
       "dedupe": true,
       "gc": true,
       "subPaths": {
           "/a": {
               "rootDirectory": "/a/zot1",
               "dedupe": true
           },
           "/b": {
               "rootDirectory": "/b/zot2",
               "dedupe": true
           },
           "/c": {
               "rootDirectory": "/c/zot3",
               "dedupe": false
           }
       }
   }

As per above config now there will be four instances of zot running under one server (3 subpath(a,b,c) and 1 global)
Image copy example to multiple routes as per above config:-

skopeo copy docker://aci-docker-reg.cisco.com/atomix/apic-rfs:7-dev7  docker://<zot-address>/zot-atomix-test:7-dev7, this will upload image to global storage i.e /tmp/zot
skopeo copy docker://aci-docker-reg.cisco.com/atomix/apic-rfs:7-dev7  docker://<zot-address>/a/zot-atomix-test:7-dev7, this will upload image to storage /a/zot1 because we are using /a prefix.
skopeo copy docker://aci-docker-reg.cisco.com/atomix/apic-rfs:7-dev7  docker://<zot-address>/b/a/zot-atomix-test:7-dev7, this will upload image to storage /b/zot2.

If extension is being provided, it will be configure for all, global as well as subpath level.


Using fixed version of Z3 and EMSCRIPTEN.

Building the Z3.wasm with the current versions of the scripts and the dependencies does not work. I have adjusted the script to use particular versions of Z3 and EMSCRIPTEN to allow for  more predictable build results. This also fixes #4.
Nevertheless, while the build seems to work fine up to a certain point, there is still a problem when building in the provided Vagrant environment:
* Z3: Linking (slow!)
shared:ERROR: legacy setting used in strict mode: BINARYEN_ASYNC_COMPILATION
* Z3 smt2 client: Linking (slow!)
shared:ERROR: /home/vagrant/z3smt2.c: No such file or directory ("/home/vagrant/z3smt2.c" was expected to be an input file, based on the commandline arguments provided)

Updated the pull request: The ECMSCRIPTEN option BINARYEN_ASYNC_COMPILATION was renamed to WASM_ASYNC_COMPILATION.


There is no option to provide our own api Key for google reverse geo location.

I want to provide my own api key to your library and there is no option for that .

+1 for the ability to add Google API Key. Without it, Google will impose stricter quota.

You are right, I've added a googleAPIKey. I'll post a new update in few days.
Thanks you for your suggestion.


adding more tests

Coverage increased (+33.81%) to 40.35% when pulling 72bddf1c88c53b5ed29b6c087e06ce7e3a54a9d5 on lukasoppermann:mocha into 15f303a1592b02ed9019328ee9705447b23f6542 on voidberg:master.


Why PickleSaveStage can't be called in zigzag-imc section even if these parts are intergrated in zigzag?

I want to use the interface energy, latency, cme = get_hardware_performance_zigzag(workload,
accelerator,
mapping,
opt='latency',
dump_filename_pattern="outputs/{datetime}.json",
pickle_filename="outputs/list_of_cmes.pickle")
However, I can only get the dump_file in json format when I run the onnx workloads on aimc or dimc hardware, so how can I call the get_hardware_performance_zigzag interface only in dump_file in json format?
thanks!

Hi,
I didn't fully understand the meaning of your description. However, if you run the API without making any changes, the pickle file will be saved at outputs/list_of_cmes.pickle. Please note that the information for all layers is saved within this pickle file, rather than saving each layer's information as a separate pickle file (as is done with JSON files).
It would be helpful if you could provide some context about what you are doing and what changes you have made.

Hi,
I didn't fully understand the meaning of your description. However, if you run the API without making any changes, the pickle file will be saved at outputs/list_of_cmes.pickle. Please note that the information for all layers is saved within this pickle file, rather than saving each layer's information as a separate pickle file (as is done with JSON files).
It would be helpful if you could provide some context about what you are doing and what changes you have made.

Thanks for replying me so quickly!
Hello, JiacongSun. I want to use aimc and dimc simulations on example models and visualize the performance png generated by your end-to-end api, but I cannot run main-onnx.py successfully, the error is either "list out of range" or "cannot unpack non-iterable LayerNode object" on this code "all cmes = [cme for (cme, extra) in extra_info]" in SaveStage.py, hence I cannot get the pickle file and json file both.

Hi,
I didn't fully understand the meaning of your description. However, if you run the API without making any changes, the pickle file will be saved at outputs/list_of_cmes.pickle. Please note that the information for all layers is saved within this pickle file, rather than saving each layer's information as a separate pickle file (as is done with JSON files).
It would be helpful if you could provide some context about what you are doing and what changes you have made.

What's more, I met with an exception"zigzag.classes.opt.temporal.loma.engine.NoValidLoopOrderingFoundException: No valid loop ordering was found for layer LayerNode_4. Please make sure the spatial mapping is compatible with the architecture." when I run the main-onnx.py, I comment out the searchunusedmemorystage and removeunusedmomorystage on the main code and get the  layer LayerNode_4.json, but when I use the api "get hardware performance zigzag()",the same exception happened again, and I don't know how to solve this exception, thanks!

Close due to no response.


Loss calc

Divide by 1 when there is no assigned boxes, instead of dividing by keras.backend.epsilon(). Stabilises training significantly.

Looks good, thanks!


Fix missing publish task

My apologies, I forgot to apply the new publishing convention plugin to the build. This is why we were missing the publish task in the master action. I validated that the task is available from the project root using ./gradlew tasks --all. Everything should be good now for publishing.

@tcrawford-figure @jonasg13 Do you think you could give the snapshot a go with Kotest 5.5.5 before a proper release?

@Kantis  should we expect to see a new snapshot here: https://oss.sonatype.org/content/repositories/snapshots/io/kotest/extensions/kotest-extensions-embedded-kafka/ ... or did you mean to build it locally and run with kotest 5.5.5?

@Kantis  should we expect to see a new snapshot here: https://oss.sonatype.org/content/repositories/snapshots/io/kotest/extensions/kotest-extensions-embedded-kafka/ ... or did you mean to build it locally and run with kotest 5.5.5?

Its here: https://s01.oss.sonatype.org/content/repositories/snapshots/io/kotest/extensions/kotest-extensions-embedded-kafka/
(Badge in readme needs to be updated to the new snapshot url)

I just found that actually and talked to @jonasg13 about updating the README. I can create a PR tomorrow to update the links. We'll test with the snapshot on our side tomorrow as well and let you know how that goes.