https://new.expensify.com/concierge doesn't redirect to Concierge chat after sign-up/sign-in

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Ensure you're not logged in
Open https://new.expensify.com/concierge
Sign-up or sign-in

Expected Result:
The user should be redirected to the Concierge chat
Actual Result:
The user is redirected to the last opened chat
Workaround:
Open Concierge manually or open https://new.expensify.com/concierge if the user is logged in
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

Version Number: v1.2.80-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://user-images.githubusercontent.com/6829422/224113686-7a88f0d4-1a32-4369-bc0b-1f08474b56b1.mov
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:
View all open jobs on GitHub

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)

If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead

[ ] This bug is reproducible using the reproduction steps in the OP. S/O

If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
If the reproduction steps aren't clear and you determine the correct steps, please update the OP.

[ ] This issue is filled out as thoroughly and clearly as possible

Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.

[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Checking to see if this should be put on hold pending Nav reboot
https://github.com/Expensify/App/issues/11768#issuecomment-1464236130

From a quick glance -  I'd guess it has more to do with some API issue than a navigation issue. Though, we need to understand the root cause in order to say for sure whether it is or isn't related.

Looks like something related to react-navigation may have been mentioned in this issue discussion.
As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.
Feel free to drop a note in #expensify-open-source with any questions.

Current assignee @marcochavezf is eligible for the Engineering assigner, not assigning anyone new.

Thanks @marcaaron , @marcochavezf , I added the engineering label, as you're already assigned, it's back to you.  Not sure if it should be internal or external

I agree with Marc, I think this is not strictly an issue of the navigation, I will give this on the Callstack list for investigation

Job added to Upwork: https://www.upwork.com/jobs/~01693e7548c561524b

Current assignee @mallenexpensify is eligible for the External assigner, not assigning anyone new.

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

Current assignee @marcochavezf is eligible for the External assigner, not assigning anyone new.

@marcochavezf btw asked here and they might get back with someone to look at this on Monday, thanks

Proposal
Please re-state the problem that we are trying to solve in this issue.
The user is redirected to the last opened chat rather than the Concierge chat when go to /concierge route when unauthenticated, then login.
What is the root cause of that problem?
The root cause is that we're having the ConciergePage in the PublicScreens here https://github.com/Expensify/App/blob/2f72ad018ba55d29b106e42959f16955eef8fd70/src/libs/Navigation/AppNavigator/PublicScreens.js#L36. I believe the intention was to have the logic of re-route to the login page if the user is unauthenticated inside the ConciergePage, as mentioned in this comment https://github.com/Expensify/App/blob/2f72ad018ba55d29b106e42959f16955eef8fd70/src/pages/ConciergePage.js#L25.
When we go to the /concierge route, it's a public route so we don't have the logic of saving the route and navigate to it after logging in, thus this issue occurs.
What changes do you think we should make in order to solve the problem?

We shouldn't have the  ConciergePage in the PublicScreens since we always need to be logged in to chat to Concierge, so it should be in the AuthScreens only.
We need to remove the ConciergePage from the PublicScreens here https://github.com/Expensify/App/blob/2f72ad018ba55d29b106e42959f16955eef8fd70/src/libs/Navigation/AppNavigator/PublicScreens.js#L36, and optionally remove the redirect to login logic inside ConciergePage as well since it's not necessary now because that logic is built in when we navigate to any screen in the AuthScreens .
After this change, it will redirect to /concierge correctly after logging in.
What alternative solutions did you explore?
NA
Result
Working well after the fix:
https://user-images.githubusercontent.com/113963320/224472887-edc0d11f-23fd-44bd-a5d9-b7afbb3a345a.mov

Ah @mountiny @mallenexpensify I already created a PR to fix this https://github.com/Expensify/App/pull/15788, the problem is that we're not handling the concierge route after the app is launched

@marcochavezf what do you think about the solution mentioned above? I think the root cause there is more accurate and the fix is more straight-forward as well.

we're not handling the concierge route after the app is launched

This should be handled by default for all routes (not just Concierge), the issue is just that the Concierge screen is on the incorrect navigation stack (Public). So I don't think we should add custom handling logic for Concierge, just correcting its location in the navigation stack is enough.

Hi @tienifr, thanks for stating the solution, but I think the ConciergePage was added to handle the deep link on native platforms. Also for mobile web, we want to open the Concierge chat by default when the user opens the /concierge link. Could you also test the proposed solution and post screenshots for deep link /concierge working on native apps and mobile web?

I have tested my proposal and here are screenshots for deep link /concierge working on native apps, mobile web and desktop also.

Mobile Web - Chrome
https://user-images.githubusercontent.com/113963320/224605533-18fb5781-d211-4fdb-b24f-6678848b15ac.mp4

Mobile Web - Safari
https://user-images.githubusercontent.com/113963320/224605555-3a3bc8db-65a7-4d9e-ba50-6b169b40df8e.mp4

Desktop
https://user-images.githubusercontent.com/113963320/224605566-b2572ea9-6428-49cb-8f35-3454163d0228.mp4

iOS
https://user-images.githubusercontent.com/113963320/224605582-77350759-c03a-44b1-9ace-d8e2ca9c9fa9.mp4

Android
https://user-images.githubusercontent.com/113963320/224605612-5c4cc332-5878-488d-9c8d-0196483858d4.mp4

@marcochavezf, @mallenexpensify, @mollfpr Whoops! This issue is 2 days overdue. Let's get this updated quick!

@tienifr! whoa, sorry for the delay here and thanks for testing it! Yeah, looks like that's the cleanest solution, let's do it! 🚀

📣 @tienifr You have been assigned to this job by @marcochavezf!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖

Hi @marcochavezf @mollfpr the PR is ready for review!

@tienifr @mollfpr can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~01693e7548c561524b

@mallenexpensify accepted, thank you!

Hi @marcochavezf @mollfpr, I created the PR and I'm waiting for the review. Thank you!

Regression Test Proposal
Bug: Couldn’t copy by command C on the placeholder in the Search Page after selecting it
Proposed Test Steps:

Ensure you're not logged in
Open https://new.expensify.com/concierge
Sign-up or sign-in
Verify that the user should be redirected to the Concierge chat

Do we :+1: or :-1:

Reviewing label has been removed, please complete the "BugZero Checklist".

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.2.87-1 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/15974
https://github.com/Expensify/App/pull/15788

If no regressions arise, payment will be issued on 2023-03-28. :confetti_ball:
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

[ ] External issue reporter
[ ] Contributor that fixed the issue
[ ] Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[ ] [@mollfpr / @marcochavezf] The PR that introduced the bug has been identified. Link to the PR:
[ ] [@mollfpr / @marcochavezf] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[ ] [@mollfpr / @marcochavezf] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[ ] [@mallenexpensify] Determine if we should create a regression test for the bug.
[ ] [@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to the appropriate location to ensure the same bug will not reach production again.
[ ] [@mallenexpensify] Review the proposed regression test steps and location.
[ ] [@mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[ ] [@mollfpr / @marcochavezf] The PR that introduced the bug has been identified. Link to the PR:
[ ] [@mollfpr / @marcochavezf] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[ ] [@mollfpr / @marcochavezf] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[ ] [@mallenexpensify] Determine if we should create a regression test for this bug.
[ ] [@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[ ] [@mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

This issue's a lil tricky but.. it appears
@tienifr assigned on March 15th.
Merged on March 16th.
From what I can tell, the other linked issue and PR don't affect payment here, please comment if that's not accurate. So both @tienifr and @mollfpr should be due $1500 which includes the $500 timeliness bonus.
Gonna leave this open for a couple days before I pay to be sure the above is accurate. Everyone's already hired for the job here

@marcochavezf, @mallenexpensify, @mollfpr, @tienifr Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

For this one, the proposed solution was merged, but there was an uncovered edge case that was fixed in another PR. The steps to catch that case were a bit tricky, so I agree we can consider it as a different issue and don't affect payment here.


Wrong encoding for new files

VSCode Version: Code 1.11.2 (6eaebe3b9c70406d67c97779468c324a7a95db0e, 2017-04-13T08:03:11.395Z)
OS Version: Windows_NT ia32 10.0.14393
Extensions:

Extension
Author
Version

html-snippets
abusaidm
0.1.0

python
donjayamanne
0.6.0

xml
DotJoshJohnson
1.7.0

csharp
ms-vscode
1.8.1

PowerShell
ms-vscode
0.12.1

debugger-for-chrome
msjsdiag
2.7.3

vscode-icons
robertohuertasm
7.5.1

Steps to Reproduce:

In settings set "files.encoding" to "utf8",
Save any new file,
Untitled-2.txt
Saved file is in ANSI encoding.

That is expected unless you are using characters that are outside of the ASCII range.

Is there any possibility to force encoding when saving new file?
If not, then I'd like to know where I can suggest such option in settings?


Doesn't Recognize wsl --set-version Ubuntu 2 & wsl -l - v even after setup

Hello there,
I have the latest windows build (1909), I've turned on Virtualization and the Linux System (via pannel, bios and code)
Enable-WindowsOptionalFeature -Online -FeatureName Microsoft-Windows-Subsystem-Linux
dism.exe /online /enable-feature /featurename:Microsoft-Windows-Subsystem-Linux /all /norestart
dism.exe /online /enable-feature /featurename:VirtualMachinePlatform /all /norestart
So I managed to Install Ubuntu, but when I try to update to WSL I get:

Manually (though here): I get a message "The update only applies to machine with Windows subsystem for Linux"
Through Powershell: It doesn't recognize wsl --set-version Ubuntu & wsl -l - v even after setup .

How should I move forward? I already tried to remove all the installation and begin from 0 but still getting these errors!

For WSL2 you need at least Windows 10 version 2004 (not released yet).

Hello there I am on windows insider programs, everyone on my team managed to install wls2 following the same steps, my machine was the only one that bugged  /:

https://www.thomasmaurer.ch/2019/06/install-wsl-2-on-windows-10/
Build 18917 or superior, my one is 1909

https://www.thomasmaurer.ch/2019/06/install-wsl-2-on-windows-10/
Build 18917 or superior, my one is 1909

type winver on cmd to know the exact build number. What it shows?

That's it bud!
I thought I had hight build but I still on 18.363, going though updates the whole day to try to get to the highest one, thanks very much!!


Execution failed for task ':app:compileDebugJavaWithJavac'.

Environment
OS: Windows 10
Node: 10.11.0
Yarn: 1.10.1
npm: 6.4.1
Watchman: Not Found
Xcode: N/A
Android Studio: Version  <IP_ADDRESS> AI-181.55<IP_ADDRESS>14246
Packages: (wanted => installed)
react: 16.3.1 => 16.3.1
react-native: https://github.com/expo/react-native/archive/sdk-30.0.0.tar.gz => 0.55.4
Description
I'm trying react-native run-android and its not working. I always get this error:
8 errors
:app:compileDebugJavaWithJavac FAILED
FAILURE: Build failed with an exception.

What went wrong:
Execution failed for task ':app:compileDebugJavaWithJavac'.

Compilation failed; see the compiler error output for details.

Reproducible Demo
Empty project, just trying this tutorial: https://www.youtube.com/watch?v=6ZnfsJ6mM5c&t=398s

That's because you are using Expo/CRNA, so I don't think that react-native run-android can work.


A full implementation of CSSharp's permission system

Thanks for adding basic CSSharp admin, however, as I said in the original Issue Request you should bite the bullet and add proper granular support for admin commands as supported by CSSharp.
Delaying it and doing the fudge fix you've implemented will cause way more work in the longer term. I'm looking to the future for this plugin and can see where it can go and how it can not only support teams but also community servers (I know that's not currently a focus)
As you'll already know the CSSharp admin permission system does all the work for you. You just need to specify the admin level needed for a command and it will allow or block access as needed. No need for adding extra code inside every admin command you add.
Here's a suggestion for a full and proper fix that's extremely powerful (inspired by @crashzk in the original Issue request).
Each admin command is grouped into the standard levels CSSharp provides.
eg .map and .prac are grouped into @css/changemap so more junior members of a team can practice.
Match commands eg .start and .reloadadmins should be reserved for more senior admins.
Each command also has an additional admin setting based on its name.eg @custom/prac
[RequiresPermissionsOr("@css/map", "@custom/prac")]
public void OnPracCommand(CCSPlayerController? player, CommandInfo? command)

An admin could now be given access to just the practice command without the ability to change the map (it's an example only - you probably wouldn't do this)
This gives complete control in assigning actions to admins. Users that need basic functionality have it, but also provides extremely powerful control for minimal coding effort. You could even add @custom/generic to each admin command and keep the same admin system you have now where every admin has access to everything (I don't think this is a good idea personally).  @css/generic shouldn't be used as CCSharp should use this as enabling other admin levels.
You will of course need to rip out the current admin checks in commands - looking at the code most are simply removing a couple of lines in about a dozen commands. pause and unpause require the biggest changes.
It's alpha and people should be prepared for changes.
I'm happy to help in anyway I can. Even if it's just grouping commands.

Hey!
Thanks for the detailed explanation, helps a lot!
Initially I thought that having the generic permission would be just fine, but it seems that is not the case.
So as you've mentioned, we can do the bifurcation based on roles and commands
But shouldn't there be a super-user kind off permission as well which grands access to all commands (like @css/root or @css/generic)?
[RequiresPermissionsOr("@css/generic", "@css/map", "@custom/prac")]
public void OnPracCommand(CCSPlayerController? player, CommandInfo? command)

I think this way, a generic admin can access all the commands, or a junior admin with @css/map or a player with @custom/prac can access this command as well.
We can decide the roles for all of the commands (like starting/restarting the match, admin pause/unpause, restore, etc)

Hey!
Thanks for the detailed explanation, helps a lot! Initially I thought that having the generic permission would be just fine, but it seems that is not the case.
So as you've mentioned, we can do the bifurcation based on roles and commands But shouldn't there be a super-user kind-of permission as well which grants access to all the commands (like @css/root or @css/generic)?
[RequiresPermissionsOr("@css/generic", "@css/map", "@custom/prac")]
public void OnPracCommand(CCSPlayerController? player, CommandInfo? command)

I think this way, a generic admin can access all the commands, or a junior admin with @css/map or a player with @custom/prac can access this command as well. We can decide the roles for all of the commands (like starting/restarting the match, admin pause/unpause, restore, etc)

@css/root would be best in this case to have access to everything as mentioned, and if you don't have root access check the other flag.

CSSharp has  introduced admin overrides so there is no longer a need to have additional flags based on flags as in my original post.
eg the example I gave would now just be
[ConsoleCommand("css_prac", "Starts practice mode")]
[RequiresPermissionsOr("@css/map")]
public void OnPracCommand(CCSPlayerController? player, CommandInfo? command)

and for the override giving access to .prac it would be
  "Admins_name": {
    "identity": "123456789123456",
    "flags": [ "@css/whatever_flags"
		 ]
   "command_overrides": {
      "css_prac": true
   }

This also applies to groups.
As @crashzk stated @css/root grants access to all admin flags.
Incidentally, @css/generic in sourcemod made a player admin but you also had to give them extra permission flags.  eg if you wanted them access to change map they would need both @css/generic and @css/map (using CSSharp terminology). I don't know if this is still the case in CSSharp

Here's my suggestion sfor grouping commands into the various admin flags.
No admin restrictions. This is as it is currently.
.ready
.unready
.pause
.tech
.unpause
.stay
.switch
.stop
.tac
.coach
.settings This is currently admin protected, but since it just shows the server settings it could be removed from admin
Practice commands. No admin restrictions except for .deletenade
.spawn
.ctspawn
.tspawn
.bot
.nobots
.clear
.fastforward
.god
.savenade
.loadnade
.importnade
.listnades
.deletenade make admin protected with flags @css/config A bit too powerful for regular players I feel.
Admin flag @css/changemap
.map
.prac         Having prac here allows players to practice without having full match command access
.exitprac   Isn't prac now togable or there's a pr for it? If so this is no longer required.
Admin flag @css/config
.knife
.readyrequired
.reload_admins
.restart
.restore
.start
.team1
.team2
.whitelist
The following require implementation of https://github.com/shobhit-pathak/MatchZy/issues/28
Without it you'll end up rewriting the admin work-around for .pause and .unpause. Easier to separate them as part of this. Less code as well.
.forcepause
.forceunpause
Admin flag @css/chat
.asay
@css/rcon
.rcon

Incidentally, @css/generic in sourcemod made a player admin but you also had to give them extra permission flags. eg if you wanted them access to change map they would need both @css/generic and @css/changemap (using CSSharp terminology). I don't know if this is still the case in CSSharp

Tested @css/generic and it isn't required for other admin levels in CSSharp

Hey guys!
I've updated the admin system as per our discussion here

@css/root: Grants access to all admin commands
@css/config: Grants access to config related admin commands
@custom/prac: Grants access to practice related admin commands
@css/map: Grants access to change map and toggle practice mode
@css/rcon: Grants access to trigger RCON commands using !rcon <command>
@css/chat: Grants access to send admin chat messages using !asay <message>

Do let me know your thoughts here, and whether we are good to close this issue!
Thanks :D

Hey guys!
I've updated the admin system as per our discussion here

@css/root: Grants access to all admin commands
@css/config: Grants access to config related admin commands
@custom/prac: Grants access to practice related admin commands
@css/map: Grants access to change map and toggle practice mode
@css/rcon: Grants access to trigger RCON commands using !rcon <command>
@css/chat: Grants access to send admin chat messages using !asay <message>

Do let me know your thoughts here, and whether we are good to close this issue!
Thanks :D

For me perfect, now it's time to test everything but I believe this is more than perfect. ❤

Hey guys!
I've updated the admin system as per our discussion here

@css/root: Grants access to all admin commands
@css/config: Grants access to config related admin commands
@custom/prac: Grants access to practice related admin commands
@css/map: Grants access to change map and toggle practice mode
@css/rcon: Grants access to trigger RCON commands using !rcon <command>
@css/chat: Grants access to send admin chat messages using !asay <message>

Do let me know your thoughts here, and whether we are good to close this issue!
Thanks :D

Great job :)
Everything seems to work. I concentrated my testing on admin overrides and groups.
Overrides work perfectly.
Admin groups don't work but I think it's an issue with CSSharp not your implementation. I'll do some further testing.
I'm curious though, why did you effectively create your own admin system rather than use the built in CSSharp admin system?
There's less code using the CSSharp's system and all admin flags are linked to the command's definition making it more readable.
Excellent job though. For me this issue can be closed.

Hey, thanks for the feedback and testing! :D
When I started working on MatchZy, CSSharp didn't had an admin system, that is why I had to develop my own.
Thanks for the confirmation, I'll close this issue!


Text in Editbox

if there was a way to pull information out of the editbox that would be great, and if there is can anyone show me an example.

Hi, I have added documentation in the KW_editbox.h file. The function you are looking for is KW_GetEditboxText()

oh ok thank u
On Sun, Aug 5, 2018 at 2:30 PM Leonardo Guilherme de Freitas <
<EMAIL_ADDRESS>wrote:

Hi, I have added documentation in the KW_editbox.h file. The function you
are looking for is KW_GetEditboxText()
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/mobius3/KiWi/issues/32#issuecomment-410542192, or mute
the thread
https://github.com/notifications/unsubscribe-auth/Ankwpi7qCFYGRA--uOksSNFyPjn0B74uks5uN0e7gaJpZM4VoZRg
.


Dataset problem about msl datasets

Hello, thank you very much for your work. This paper and code have inspired me a lot. Thank you very much!
In the process of code reproduction, I met some problems. I am not quite clear about the source of MSL data set, and I wonder if you could give a more detailed explanation. I am a beginner of Python and neural networks. I am a novice, so I can't read the code, so I use your code as a black box. For MSL data sets, the F1 score is about 0.88-0.90 after multiple runs. I made some boring attempts to keep the label of your data set unchanged, change all other data to RAND (), random number, and then run the same F1 score as 0.88-0.90. I'm not quite sure why, and I wonder if you could enlighten me. Thank you very much.
 I sincerely want to get in touch with you and hope to get some advice from you. I didn't find your email address, so I don't know how to contact you easily. My email is<EMAIL_ADDRESS>and I look forward to contacting you.

You could just take the MSL data as demo/toy data to help check if the environment or setup is ready for running the repo bug-free. In addition, you could follow the demo data and replace it with your custom data.
Everyone once started from a novice so that is totally fine. Maybe I could not help with the very detailed problems but if you have any other issues or questions with the paper, you could contact me at<EMAIL_ADDRESS>Thanks and Good luck :)

Hi, I found that my code also came out with results that stayed consistent, although I tried to change some parameters. May I ask if you solved this problem


Introduce workspace

This makes the repository a Cargo workspace and moves everything into the libcnb crate in this repo.
This is required to tackle #20, #97 and the general wish to be able to use data without the whole framework. Later down the line we will introduce additional crates that will be part of the workspace. This includes libcnb-testing, libcnb-cargo (Cargo plugin to package buildpacks and generate scaffolds for new ones), libcnb-macros (procedual macros which must be in their own crate) and more.
For end-users, nothing changes since libcnb is still the same crate as it was before. It just lives in a different directory in the repository.

I kept this PR as simple as possible since it changes the layout so drastically. Examples in the root do work, but there are some caveats I haven't fully worked out yet. I think the examples need some love anyway so that would be a good opportunity to review how they work. See:

https://github.com/rust-lang/cargo/issues/7467
#20


wip: bidirectional stream observer

@igorbernstein2 Am I on the right track? Apart from making the tests look more like ServerStreamingCallableTest I'm not sure what else I have to do.
As-is, the code is good enough that pubsub integration test passes. I'll load-test pubsub before committing this.

Codecov Report

Merging #498 into master will increase coverage by 0.04%.
The diff coverage is 82.6%.

@@             Coverage Diff              @@
##             master     #498      +/-   ##
============================================
+ Coverage     70.43%   70.48%   +0.04%
+ Complexity      813      812       -1
============================================
  Files           165      165
  Lines          3782     3798      +16
  Branches        293      295       +2
============================================
+ Hits           2664     2677      +13
- Misses          992      994       +2
- Partials        126      127       +1

Impacted Files
Coverage Δ
Complexity Δ

...om/google/api/gax/rpc/ServerStreamingCallable.java
71.87% <ø> (+21.87%)
7 <0> (ø)
:arrow_down:

...gax/grpc/GrpcExceptionServerStreamingCallable.java
100% <100%> (ø)
2 <1> (ø)
:arrow_down:

...i/gax/grpc/GrpcExceptionBidiStreamingCallable.java
100% <100%> (ø)
2 <1> (ø)
:arrow_down:

...pi/gax/grpc/GrpcDirectServerStreamingCallable.java
100% <100%> (ø)
2 <0> (ø)
:arrow_down:

.../api/gax/grpc/GrpcDirectBidiStreamingCallable.java
100% <100%> (ø)
2 <0> (ø)
:arrow_down:

.../com/google/api/gax/rpc/BidiStreamingCallable.java
85.71% <50%> (-14.29%)
4 <1> (+1)

...oogle/api/gax/grpc/GrpcDirectStreamController.java
90.19% <78.57%> (-4.4%)
9 <1> (+1)

...om/google/api/gax/grpc/StreamObserverDelegate.java
77.77% <0%> (-22.23%)
3% <0%> (-1%)

...google/api/gax/grpc/ApiStreamObserverDelegate.java
77.77% <0%> (-22.23%)
3% <0%> (-1%)

...x/grpc/GrpcExceptionTranslatingStreamObserver.java
80% <0%> (-20%)
3% <0%> (-1%)

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e11861...5cf5cca. Read the comment docs.


Decoder breaks if "Set Dynamic Table Capacity" instruction doesn't match its initial capacity

If the other side chooses a smaller dynamic table size than what we initialized the decoder with, decoding headers will fail or get corrupted.
We think it’s because qpd_max_entries isn’t updated in qdec_update_max_capacity.
Reproducing project attached: qpack_bug_repro.zip If you increase the initial dynamic table capacity by even 1 from 16383 to 16384, decoding starts failing.

Thank, we will add it as a test case.
The fix to this particular case is easy, like you said, just update qpd_max_entries accordingly.
However, more complicate logic is related to qpd_max_entries and qpd_largest_known_id, those also need to be updated, I believe.  RFC allows changing dynamic table size up and down at anytime, make it more tricky. may need bigger change to get it right.

Please check the fix.

Looks good, thanks!


world guard

How do i prevent people from using all spells/certain spells in a region?

I found this on the wiki.

Thank you, @martdamp !
@T13m3n please re-open if you still have questions.


URL is not exported with BBT Export

Debug log ID
87ZD2PTH-refs-euc/6.7.136-6
What happened?
I was looking to export a collection of references to build an online bibliography, so I needed the URL to the non-paywalled version, which is stored in the URL field in Zotero.
When I export using Better Bibtex, I get:
@incollection{almond2019a,
  title = {Identifying Observable Outcomes in Game-Based Assessments},
  booktitle = {Innovative {{Psychometric Modeling}} and {{Methods}}},
  author = {Almond, Russell G. and Shute, Valerie J. and Tingir, Seyfullah and Rahimi, Seyedahmad},
  editor = {Lisstz, R. and Jiao, H.},
  year = {2019},
  month = may,
  pages = {163--192},
  publisher = {{Information Age Publishing}},
  annotation = {Backup Publisher: Maryland Assessment Research Center (MARC)}
}

When I use the ordinary bibtex export, I get:

@incollection{almond2019a,
	title = {Identifying observable outcomes in game-based assessments},
	url = {https://myweb.fsu.edu/vshute/pdf/marcs2020.pdf},
	booktitle = {Innovative {Psychometric} {Modeling} and {Methods}},
	publisher = {Information Age Publishing},
	author = {Almond, Russell G. and Shute, Valerie J. and Tingir, Seyfullah,  and Rahimi, Seyedahmad},
	editor = {Lisstz, R. and Jiao, H.},
	month = may,
	year = {2019},
	note = {Backup Publisher: Maryland Assessment Research Center (MARC)},
	pages = {163--192},
}

So BBT is not exporting the URL field.

https://retorque.re/zotero-better-bibtex/installation/preferences/export/index.html#add-urls-to-bibtex-export

Thanks.  It wasn't obvious to me that the string of text along the top of the preference pane was a tabset, so I missed that.


Fix one unit test and cripple the DBS2 emulator a little more

This should fix WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase.testRunWhitelist and also change listRunLumis in the DBS2 emulator to match what we get from DBS3. Adapt both unit tests to match this.
Of course, we really need to get DBS2 emulator killed, chopped into little pieces and buried. And a proper DBS3 emulator.

Beginning pylint and unit tests.
See https://cmssdt.cern.ch/jenkins/job/DMWM-PR-test/427/ for details

No pylint warnings for pull request 6173:

Unit test changes for pull request 6173:

WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testRunWhitelist changed from error to success