[Bug] Some icons are not displayed in version 5.5.1

Describe the bug
Some icons are not displayed in version 5.5.1

The config folder icon show when I open it, but seeders and other folders are not displayed even when opened

To Reproduce
Steps to reproduce the behavior:

Go to 'extensions'
Click on config in 'Material Icon Theme'
Click on 'Install Another Version'
install 5.5.1 version
See the bug.

Expected behavior
display the icons as always.
One way to get around this is to install another version, in this case 5.5.0 works correctly.
Computer information (please complete the following information)

OS edition: Windows 10 PRO
OS build: 19045.4651
VSCode version: 1.91.1

Other information
I've already uninstalled and installed the extension, I've selected the icon theme, I've enabled and re-enabled it, I've restarted the extensions, I've closed and opened vscode, I've restarted my computer and nothing has changed.

@jassriver do you have any customizations enabled for the extension? Like custom icon associations or other settings? Or are you using it right out of the box without any customizations? If yes, can you please tell us which and try to disable them? You can also run the command "Material Icons: Restore Default Configuration".
If it's not the case, can you post the "material-icons.json" file here?
You can find it under this path on your machine: ~/.vscode/extensions/pkief.material-icon-theme-5.5.1/dist/material-icons.json

I don't have customizations enabled.
I ran the command and nothing changed.
This is my material-icons.json
material-icons.json
mirror pastebin
(I couldn't post the content because it exceeds the number of characters that github allows, so I uploaded it here and on pastebin)

I have same issue

hey @karinzaa if you install another version, like 5.5.0, works correctly or the bug remains?

It works correctly.

I don't have customizations enabled. I ran the command and nothing changed.
This is my material-icons.json material-icons.json mirror pastebin (I couldn't post the content because it exceeds the number of characters that github allows, so I uploaded it here and on pastebin)

Thanks a lot, I compared it with the expected JSON file and it looks 100% the same, which is already a good sign.
As I can't reproduce it right now on my machine, could you please check if there's an error in the developer tools of your vscode and send me a screenshot or error message.
You can toggle the developer tools like this:

In the "console' tab, can you see some error message regarding some SVG files or something which is related to the "PKief.material-icon-theme" extension?

In consol has nothing like .svg error but in network tab is error.

@PKief
Same for me, there are no errors in the console, the svgs have nothing, when checking my explorer I noticed that a lot of files are empty (0kb)

@karinzaa @jassriver Thanks for that information.
@jassriver Then the files in your extension folder (~/.vscode/extensions/pkief.material-icon-theme-5.5.1/icons) are empty too, right? It's weird because I've checked the extension bundle (the .vsix file) and it contains the icons as expected:
https://github.com/material-extensions/vscode-material-icon-theme/releases/download/v5.5.1/material-icon-theme-5.5.1.vsix

You can install that extension directly via file:

Can you please try that out if it helps?

Ok it back to working 👍

for me too, works now, thanks.

@PKief Ok it back to working 👍 Thanks 🙏 But in future it bug again, I have to repair it myself?

I need to investigate if there's a process which clears the content of some SVG file. I can't really explain it right now, why it's removing the content of the files and why it seems to work for most of the people. I'll go through it and analyse if I can find some suspicious parts of code which can be responsible for that behavior.

@karinzaa @jassriver I've just published a version 5.6.0 on the VS Code Marketplace. I've changed two settings in the build configuration which have been changed between 5.5.0 and 5.5.1. Maybe it fixes your issue. Feel free to try it out once it's available for you to install it via VS Code Marketplace.

@karinzaa @jassriver I've just published a version 5.6.0 on the VS Code Marketplace. I've changed two settings in the build configuration which have been changed between 5.5.0 and 5.5.1. Maybe it fixes your issue. Feel free to try it out once it's available for you to install it via VS Code Marketplace.

Now I update via VS Code Marketplace it work well. Thank 🙏

@karinzaa @jassriver I've just published a version 5.6.0 on the VS Code Marketplace. I've changed two settings in the build configuration which have been changed between 5.5.0 and 5.5.1. Maybe it fixes your issue. Feel free to try it out once it's available for you to install it via VS Code Marketplace.

Now I update via VS Code Marketplace it work well. Thank 🙏

Awesome 👍

@PKief To perform the final test, I completely deleted the extension and installed it through the vscode marketplace, I installed version 5.5.1 and all the icons were working normally (strange, right?) so I removed the extension folder from my file explorer and installed it the extension again and again, the 5.5.1 icons were there without any problem O.o What???
Anyway, 5.6.0 seems to have fixed the problem, or else downloading the VSIX you provided resolved the problem in some magical way (I would need someone who was having the problem to not download VSIX file and directly install version 5.6.0 to say that this actually solved the problem) But, you can close this Issue now, I think.
Thanks for the resolution PKief 🙏

I still have this issuein version 5.6.0
I changed to version v5.5.1 via the VSIX file and it's working, but when I update to the new version, the problem comes back.

It seems vscode couldn't find the folder-i18n svg in our extension, which introduced this bug, while folder svg works fine~ if missed several icons when build the vsix?

@Cecil0o0 I've checked the vsix file as well, but it contains the files correctly:

I've tested the extension on three different machines (Windows, MacOS) and everywhere it's working fine with the latest version. That's why I'm a bit confused why for some people it's not working as expected 🧐
Can you try to bring your VS Code instance to the latest version and also delete the material-icon-theme from the extension folder  manually and install it again?

I had the same problem and it happened within a week. 😂

This problem is still persisting in version 5.6.0. At least on macOS. After installing v5.5.1 on macOS the icons show up.
v5.6.0

v5.5.1

I don't know why, but for some reason, some icons just mysteriously disappeared from me too
https://github.com/user-attachments/assets/fa30b3b2-b8ba-40b1-a53b-323254081b78

@PKief Now I back the same issues that used to be has randomly returned again.

I don't know why, but for some reason, some icons just mysteriously disappeared from me too
https://github.com/user-attachments/assets/fa30b3b2-b8ba-40b1-a53b-323254081b78

It looks weird. Like a rendering issue or something... I double checked the code that was changed between the versions 5.5.0 and 5.6.0 and still can't figure out what causes this issue.

I don't know why, but for some reason, some icons just mysteriously disappeared from me too
2024-07-18.175342.mp4

It looks weird. Like a rendering issue or something... I double checked the code that was changed between the versions 5.5.0 and 5.6.0 and still can't figure out what causes this issue.

Quite likely. This is most likely a vscode issue, so I think we should move this issue to the vscode repo

This just started happening for me as well. The Ruby icons for .rb files are no longer displaying. A few others like .ruby-version and config.ru are also missing.

I think it started happening after applying latest VSCode update.
macOS 14.5
Material Icon Theme: v5.6.0
VSCode:
Version: 1.91.1 (Universal)
Commit: f1e16e1e6214d7c44d078b1f0607b2388f29d729
Date: 2024-07-09T22:07:54.982Z
Electron: 29.4.0
ElectronBuildId: 9728852
Chromium: 122.0.6261.156
Node.js: 20.9.0
V8: 12.2.281.27-electron.0
OS: Darwin arm64 23.5.0

This just started happening for me as well. The Ruby icons for .rb files are no longer displaying. A few others like .ruby-version and config.ru are also missing.

I think it started happening after applying latest VSCode update.
macOS 14.5
Material Icon Theme: v5.6.0
VSCode:
Version: 1.91.1 (Universal)
Commit: f1e16e1e6214d7c44d078b1f0607b2388f29d729
Date: 2024-07-09T22:07:54.982Z
Electron: 29.4.0
ElectronBuildId: 9728852
Chromium: 122.0.6261.156
Node.js: 20.9.0
V8: 12.2.281.27-electron.0
OS: Darwin arm64 23.5.0

Create this issue in the vscode repo

Just want to report that this is happening for me in 5.6.0 on one of my machines but not another. On the machine it is happening, regressing to 5.5.1 addresses the issue!

@Cecil0o0 I've checked the vsix file as well, but it contains the files correctly:

I've tested the extension on three different machines (Windows, MacOS) and everywhere it's working fine with the latest version. That's why I'm a bit confused why for some people it's not working as expected 🧐
Can you try to bring your VS Code instance to the latest version and also delete the material-icon-theme from the extension folder manually and install it again?

Version: 1.91.1 (Universal)
Commit: f1e16e1e6214d7c44d078b1f0607b2388f29d729
Date: 2024-07-09T22:07:54.982Z
Electron: 29.4.0
ElectronBuildId: 9728852
Chromium: 122.0.6261.156
Node.js: 20.9.0
V8: 12.2.281.27-electron.0
OS: Darwin x64 23.5.0
@PKief Copied about my VS Code instance, and I do this manually, downloading from your link at release page, but finally reproduce this is issue again...
here is my finder on my machine, folder.svg exists but folder-i18n.svg not.

totally 936 items in icons folder of vsix, is this count right?

@Cecil0o0 I've checked the vsix file as well, but it contains the files correctly:

I've tested the extension on three different machines (Windows, MacOS) and everywhere it's working fine with the latest version. That's why I'm a bit confused why for some people it's not working as expected 🧐
Can you try to bring your VS Code instance to the latest version and also delete the material-icon-theme from the extension folder manually and install it again?

Version: 1.91.1 (Universal) Commit: f1e16e1e6214d7c44d078b1f0607b2388f29d729 Date: 2024-07-09T22:07:54.982Z Electron: 29.4.0 ElectronBuildId: 9728852 Chromium: 122.0.6261.156 Node.js: 20.9.0 V8: 12.2.281.27-electron.0 OS: Darwin x64 23.5.0
@PKief Copied about my VS Code instance, and I do this manually, downloading from your link at release page, but finally reproduce this is issue again...
here is my finder on my machine, folder.svg exists but folder-i18n.svg not.

totally 936 items in icons folder of vsix, is this count right?

yes 936 is the correct amount at this moment.

This just started happening for me as well. The Ruby icons for .rb files are no longer displaying. A few others like .ruby-version and config.ru are also missing.

I think it started happening after applying latest VSCode update.
macOS 14.5
Material Icon Theme: v5.6.0
VSCode:
Version: 1.91.1 (Universal)
Commit: f1e16e1e6214d7c44d078b1f0607b2388f29d729
Date: 2024-07-09T22:07:54.982Z
Electron: 29.4.0
ElectronBuildId: 9728852
Chromium: 122.0.6261.156
Node.js: 20.9.0
V8: 12.2.281.27-electron.0
OS: Darwin arm64 23.5.0

Create this issue in the vscode repo

As this issue was happening for you too, would you mind creating an issue at the VS Code repository with the video which you posted here? And if some of the icons are not shown properly, can you check if these icons are either present or do have content in the extensions directory? E.g. extension folder icon is not shown -> is the folder-plugin.svg file present in the ~/.vscode/extensions/pkief.material-icon-theme-5.6.0/icons directory? It would be a valuable information, also for the VS Code team to figure out what the issue is. At the moment, I'm a bit confused what to do from extension owner perspective, as the problem is just occuring sometimes, on some machines. It's pretty much hard to reproduce.

For now I would install another version that is 5.5.1

For now I would install another version that is 5.5.1

You mean 5.5.1 is working, but 5.6.0 is not? But as the first post of this issue shows this issue also occurred with v5.5.1. Will it also happen with 5.5.0? It seems like this issue started with 5.5.1, not with 5.6.0

For now I would install another version that is 5.5.1

You mean 5.5.1 is working, but 5.6.0 is not? But as the first post of this issue shows this issue also occurred with v5.5.1. Will it also happen with 5.5.0? It seems like this issue started with 5.5.1, not with 5.6.0

Yep, the previous version 5.5.1 working well for me.
The latest 5.6.0, shows no icon for some files, in my case .php

Having the same issue. Downgrading to 5.5.1 seemed to fix it.
5.6.0

5.5.1

Could it be due to a download failure?
I wonder if vscode checks the checksum of the extension before installing

@okineadev are the icons empty or missing in the extensions folder?

At least for me svg files exist, they are empty

@okineadev are the icons empty or missing in the extensions folder?

The extensions icon is missing, but the open folder icon is present

For me, reverting to 5.5.1 brings back all the icons.

This is a long shot but, have you guys tried completely uninstalling the extension (making sure that ~/user/.vscode/pkief.material-icon-theme-x.x.x was removed, and manually removing it if it wasn't) and installing it again? Also try to remove all settings related with the extension before reinstalling. Since the extension manipulates the .svg files depending on some of the settings, maybe one of them might be causing an issue causing the icons to be empty).
Also, sharing your settings.json might help on trying to reproduce it. So far, I wasn't able to reproduce this issue at all.

@Cecil0o0 I've checked the vsix file as well, but it contains the files correctly:

I've tested the extension on three different machines (Windows, MacOS) and everywhere it's working fine with the latest version. That's why I'm a bit confused why for some people it's not working as expected 🧐
Can you try to bring your VS Code instance to the latest version and also delete the material-icon-theme from the extension folder manually and install it again?

Version: 1.91.1 (Universal) Commit: f1e16e1e6214d7c44d078b1f0607b2388f29d729 Date: 2024-07-09T22:07:54.982Z Electron: 29.4.0 ElectronBuildId: 9728852 Chromium: 122.0.6261.156 Node.js: 20.9.0 V8: 12.2.281.27-electron.0 OS: Darwin x64 23.5.0
@PKief Copied about my VS Code instance, and I do this manually, downloading from your link at release page, but finally reproduce this is issue again...
here is my finder on my machine, folder.svg exists but folder-i18n.svg not.

totally 936 items in icons folder of vsix, is this count right?

yes 936 is the correct amount at this moment.

@PKief, after I came home and opened my machine, folder-i18n.svg just appears in pkief.material-icon-theme-5.6.0/icons....
Now I couldn't reproduce this again even toggling between 5.6.0 and 5.5.1, I guess my problem just disappeared, 🙏 thanks for reply.

This is a long shot but, have you guys tried completely uninstalling the extension (making sure that ~/user/.vscode/pkief.material-icon-theme-x.x.x was removed, and manually removing it if it wasn't) and installing it again? Also try to remove all settings related with the extension before reinstalling. Since the extension manipulates the .svg files depending on some of the settings, maybe one of them might be causing an issue causing the icons to be empty).
Also, sharing your settings.json might help on trying to reproduce it. So far, I wasn't able to reproduce this issue at all.

I can confirm that uninstalling the extension, removing the folder ~/user/.vscode/pkief.material-icon-theme-x.x.x and reinstalling the extension resolves the problem of disappearing icons in ver. 5.6.0.

I can also confirm this

Hi there! Also happened to me just right now. Some of the icons were 0kb, deleting folders and reinstalling extension helped. Looks like some VS Code issue that break assets inside the VSIX extension.

All my icons were missing except for standard folder icons for a few days, but it seems the issue only applies to 5.6.0. Downgrading to 5.5.1 resolves the issue for me. Additionally, my VS Code is up to date.

Maybe you should revert the updates for now as this makes a lot of confusion as to why icons are not showing...

Encountering the same issue here, VSCode 1.91.1 Windows 11. With 5.6.0 several icons (e.g. src folder, gitattributes, gitignore, md, cfg) are missing. Reverted back to 5.5.1 and the issue is resolved.

~/user/.vscode/pkief.material-icon-theme-x.x.x

This solution is work

I can confirm that uninstalling the extension, removing the folder ~/user/.vscode/pkief.material-icon-theme-x.x.x and reinstalling the extension resolves the problem of disappearing icons in ver. 5.6.0.

ya! it works for me too!
it was just like:
# at the current user's root
cd .vscode/extensions
sudo rm -r pkief.material-icon-theme-5.6.0

Had the same issue with 5.6.0
Uninstall and reinstalling via VSIX solved the problem for me

Same problem for me.
Some icons randomly disappear. If I uninstall the ext and then install it back it fixes the issue for a short while and then they disappear again.
VSC Version: 1.91.1 (Universal)
OS: Darwin arm64 23.5.0
Material Icon Theme: v5.7.0

Same problem for me.
Some icons randomly disappear. If I uninstall the ext and then install it back it fixes the issue for a short while and then they disappear again.
VSC Version: 1.91.1 (Universal)
OS: Darwin arm64 23.5.0
Material Icon Theme: v5.7.0

With "uninstall" do you mean just clicking the "Uninstall"-button in the UI or the proposed delete commands:
# at the current user's root
cd .vscode/extensions
sudo rm -r pkief.material-icon-theme-5.7.0

Would be helpful if you could specify your steps.

@PKief, after I came home and opened my machine, folder-i18n.svg just appears in pkief.material-icon-theme-5.6.0/icons....
Now I couldn't reproduce this again even toggling between 5.6.0 and 5.5.1, I guess my problem just disappeared, 🙏 thanks for reply.

Did the issue occur again or is it solved for you completely and didn't come back? 🧐

Same problem for me.
Some icons randomly disappear. If I uninstall the ext and then install it back it fixes the issue for a short while and then they disappear again.
VSC Version: 1.91.1 (Universal)
OS: Darwin arm64 23.5.0
Material Icon Theme: v5.7.0

With "uninstall" do you mean just clicking the "Uninstall"-button in the UI or the proposed delete commands:
# at the current user's root
cd .vscode/extensions
sudo rm -r pkief.material-icon-theme-5.7.0

Would be helpful if you could specify your steps.

Initially I uninstalled it from VSC, restarted and then installed it back.
Then I deleted the whole ~/.vscode folder and installed the extension back.
And now I've uninstalled it from the VSC UI, and then installed it back from .vsix file.
For now it works. I'll update if icons start disappearing again.

It just disappeared again.

Also the timestamp of the files changed as well (Jul 23 01:33 when I reinstalled the extension vs Jul 23 01:48 when files broke).

Well, this is clearly a vscode problem

With "uninstall" do you mean just clicking the "Uninstall"-button in the UI or the proposed delete commands:
# at the current user's root
cd .vscode/extensions
sudo rm -r pkief.material-icon-theme-5.7.0

*
cd ~/.vscode/extensions
sudo rm -rf pkief.material-icon-theme-5.7.0

@danechitoaie are you using any of the settings for the extension?

Well, this is clearly a vscode problem

Yeah even I'm thinking that. It's weird that 15min after installing the extension some icons are with 0 bytes 😕

Well, this is clearly a vscode problem

Yeah even I'm thinking that. It's weird that 15min after installing the extension some icons are with 0 bytes 😕

Has anyone even created an issue in vscode with this bug?

@danechitoaie are you using any of the settings for the extension?

No. Just default install without changing any settings.

Well, this is clearly a vscode problem

Yeah even I'm thinking that. It's weird that 15min after installing the extension some icons are with 0 bytes 😕

Even more weird is that the files keep being accessed by something and randomly emptying some of them.
 The files timestamp still remains that of when I installed it:
-rw-r--r--     1 daniels  staff   1.0K Jul 23 03:35 folder_type_vscode_test_opened.svg
-rw-r--r--     1 daniels  staff   887B Jul 23 03:35 folder_type_webpack.svg
-rw-r--r--     1 daniels  staff   1.0K Jul 23 03:35 folder_type_webpack_opened.svg
-rw-r--r--     1 daniels  staff   366B Jul 23 03:35 folder_type_windows.svg
-rw-r--r--     1 daniels  staff   467B Jul 23 03:35 folder_type_windows_opened.svg
-rw-r--r--     1 daniels  staff   810B Jul 23 03:35 folder_type_wit.svg
-rw-r--r--     1 daniels  staff   862B Jul 23 03:35 folder_type_wit_opened.svg
-rw-r--r--     1 daniels  staff   8.9K Jul 23 03:35 folder_type_www.svg
-rw-r--r--     1 daniels  staff   9.0K Jul 23 03:35 folder_type_www_opened.svg

Even more weird is that the files keep being accessed by something and randomly emptying
some of them even though since last night I installed and activated different extension
for icons.

Sadly, I wasn't able to reproduce anything that has been reported in this issue so far. It's weird. If I understood this correctly, the issue happens even when the extension is disabled? If that's the case, it cannot be this extension what's causing it, since the code from this extensions can't run if the extension is disabled... It has to either be vscode itself or another extension accessing the files.
In my case, the timestamp haven't changed since I installed.
.rwxrwx--- lucas  398B 19 Jul 24 19:41:03 3d.svg
.rwxrwx--- lucas  110B 19 Jul 24 19:41:03 abap.svg
.rwxrwx--- lucas  768B 19 Jul 24 19:41:03 abc.svg
.rwxrwx--- lucas  766B 19 Jul 24 19:41:03 actionscript.svg
.rwxrwx--- lucas  360B 19 Jul 24 19:41:03 ada.svg
.rwxrwx--- lucas  262B 19 Jul 24 19:41:03 adonis.svg
...

@Pkief, note aside, have you ever thought of adding logging to the extension using a vscode output channel?

Image

It could help to easily identify issues in the future. We could make it disabled by default and ask people reporting issues to activate it and share their logs.

@PKief, note aside, have you ever thought of adding logging to the extension using a vscode output channel?
Image

It could help to easily identify issues in the future. We could make it disabled by default and ask people reporting issues to activate it and share their logs.

Even I'm not able to reproduce any of the reported issues here so far (I'm using different machines and all are fine). That's why I think adding a logging functionality is a super good idea. I'm working on it and will provide a solution soon!

This happened to me today. I removed the Material Icon Theme extenstion then quit and restarted VS Code and then reinstalled the extension and it fixed everything. My suspicion is that it has something to do with VS Code moving toward a "Restart Extensions" instead of "Restart VS Code" when updating extensions.

When I updated to v5.7.0 I found it worked very well.

@PKief  Issues is not fix it randon bug again.

Just throwing my two cents in here, I seem to be having this problem in version 5.7.0. If I downgrade to 5.6.0 and press "restart extensions", it seems to fix itself.

🔉I've just released v.5.8.0 with a few fixes. While analysing the code, I noticed that a couple of operations have been performed too much on the SVG icons, even though there were no settings at all. So if you use the extension out of the box, you should no longer have any problems with the latest update.
I would like to thank everyone who has actively participated here and hope that the problem will no longer occur with the new version. Please let us know if you continue to have problems with this.

Just installed, it seems to have fixed the problem for me. Thanks!

I've updated to v5.8.0 as well. I'll report if I notice any issues anymore. For now it seems good.
Thank you.

5.8.0 fixed the bug for me

Closing the ticket as v5.8.0 has resolved it.


HBASE-24713 RS startup with FSHLog throws NPE after HBASE-21751

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 33s
Docker mode activated.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m  4s
the patch passed

+1 :green_heart:
compile
1m  4s
the patch passed

+1 :green_heart:
javac
1m  4s
the patch passed

+1 :green_heart:
shadedjars
5m 45s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 40s
hbase-server in the patch failed.

_ Other Tests _

-1 :x:
unit
32m 51s
hbase-server in the patch failed.

62m 42s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2125/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2125

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 529b39821bc0 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 8191fbdd7d

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2125/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2125/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2125/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2125/1/testReport/

Max. process+thread count
747 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2125/1/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 26s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+1 :green_heart:
mvninstall
4m  1s
master passed

+1 :green_heart:
compile
0m 55s
master passed

+1 :green_heart:
shadedjars
6m  1s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 37s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 45s
the patch passed

+1 :green_heart:
compile
0m 55s
the patch passed

+1 :green_heart:
javac
0m 55s
the patch passed

+1 :green_heart:
shadedjars
6m  1s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 36s
the patch passed

_ Other Tests _

-1 :x:
unit
43m 10s
hbase-server in the patch failed.

67m 39s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2125/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2125

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux ceef5e5fcdd9 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 8191fbdd7d

Default Java
1.8.0_232

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2125/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2125/1/testReport/

Max. process+thread count
441 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2125/1/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Seems the null check was causing some issues as the finally was not getting executed.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  2s
Docker mode activated.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m 52s
the patch passed

+1 :green_heart:
compile
1m 17s
the patch passed

+1 :green_heart:
javac
1m 17s
the patch passed

+1 :green_heart:
shadedjars
7m  9s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 49s
hbase-server in the patch failed.

_ Other Tests _

-1 :x:
unit
143m 15s
hbase-server in the patch failed.

174m 23s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2125/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2125

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 6fe797610be1 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 8191fbdd7d

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2125/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2125/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2125/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2125/2/testReport/

Max. process+thread count
4868 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2125/2/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 29s
Docker mode activated.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m 40s
the patch passed

+1 :green_heart:
compile
1m 16s
the patch passed

+1 :green_heart:
javac
1m 16s
the patch passed

+1 :green_heart:
shadedjars
6m 49s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 52s
hbase-server in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
222m 20s
hbase-server in the patch passed.

253m 28s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2125/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2125

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 4cfb3f3f1b1c 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 8191fbdd7d

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2125/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2125/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2125/3/testReport/

Max. process+thread count
3201 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2125/3/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 33s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+1 :green_heart:
mvninstall
4m 18s
master passed

+1 :green_heart:
compile
1m  1s
master passed

+1 :green_heart:
shadedjars
6m 19s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 40s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m  0s
the patch passed

+1 :green_heart:
compile
1m  0s
the patch passed

+1 :green_heart:
javac
1m  0s
the patch passed

+1 :green_heart:
shadedjars
6m  7s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 37s
the patch passed

_ Other Tests _

-1 :x:
unit
237m  7s
hbase-server in the patch failed.

264m 41s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2125/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2125

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 2814c65b9306 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 8191fbdd7d

Default Java
1.8.0_232

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2125/3/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2125/3/testReport/

Max. process+thread count
2906 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2125/3/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Think that the test case failures are unrelated. Will commit this in a day or two unless there are any more comments.
@anoopsjohn , @saintstack .

Hasn't the NPE been fixed by:
HBASE-24034 [Flakey Tests] A couple of fixes and cleanups
In FSHLog.java, I see the FSHLog.java:582 mentioned in a comment.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  6s
Docker mode activated.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m 12s
the patch passed

+1 :green_heart:
compile
1m  5s
the patch passed

+1 :green_heart:
javac
1m  5s
the patch passed

+1 :green_heart:
shadedjars
5m 49s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 41s
hbase-server in the patch failed.

_ Other Tests _

-1 :x:
unit
150m 30s
hbase-server in the patch failed.

176m 50s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2125/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2125

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 082941c710d1 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 7c4d66a277

Default Java
2020-01-14

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2125/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2125/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2125/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2125/3/testReport/

Max. process+thread count
4114 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2125/3/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Hasn't the NPE been fixed by:
HBASE-24034 [Flakey Tests] A couple of fixes and cleanups
In FSHLog.java, I see the FSHLog.java:582 mentioned in a comment.

No.. Here the NPE comes as the writer is null.  As part of the initial writer create (that happens via rollWriter call), we ended up attaining a safe point and so publish a sync. This in turn try to call writer.sync() and so the NPE.

Test case failure is unrelated to this fix.


Key docs

closes https://github.com/react-navigation/react-navigation.github.io/issues/50

thank you! this will be very helpful for people


[release-1.8] Use variable for curl, add retries

Manual backport of #5272
This adds multiple retries on every attempt we make to use curl, which should help to reduce flakes. Uses a $(CURL) variable where possible so that we have the same invocation everywhere.
Also switches to using the more verbose curl arguments, in an attempt to make it easier to reason about how curl is configured.
The backport of this was manual because of conflicts relating to $(BINDIR), and our new methods of installing kubebuilder tools and the gatewayapi code
Kind
/kind feature
Release Note
Use multiple retries when provisioning tools using `curl`, to reduce flakes in tests and development environments

thanks @SgtCoDFish !
/lgtm
/approve

/test pull-cert-manager-e2e-v1-24

/test pull-cert-manager-e2e-v1-23


SoapFault - Could not connect to host

Hi!
When is try the sample code (on localhost), I get this error: SoapFault - Could not connect to host.
(I have .pem file in curl.cainfo, in php.ini)
What is the problem? Thanks!

Hi @anonymuos1,
It's difficult for me to help you debugging soapfaults in your local development environment. Also it doesn't relate directly to this package - I recommend that you open a thread on stackoverflow instead. To make it easier for others to help you should also include more details such as phpinfo etc.


Make Kamelet Catalog examples to use Camel JBang

I think that we should change the template used to show a user how to run a Kamelet/KameletBinding. Ideally we should change it to use Camel JBang instead, as now Kamelet technology is not specifically bound to Camel K. It would also simplify a lot the user to try them out, not requiring to have installed a Kubernetes cluster.

I added a section with a little explanation. Still need to work on the javascript for generating specific examples.


-is:retweet rules not working as described

See the following script:

import json
from searchtweets import ResultStream, load_credentials, gen_rule_payload

from_date = "2020-03-31 00:00"
to_date = "2020-04-01 00:00"

login = load_credentials(filename="./src/search_tweets_creds_example.yaml",
                         yaml_key="search_tweets_ent_example",
                         env_overwrite=False)

rule = gen_rule_payload('beyonce -is:retweet',
                        results_per_call=100,
                        from_date=from_date,
                        to_date=to_date
                        )

rs = ResultStream(rule_payload=rule,
                  max_results=100,
                  **login)

results = list(rs.stream())
print(results)

with open('./data/first/tweets_{}_{}.json'.format(from_date, to_date), 'w') as fp:
    json.dump(results, fp)

Now, using a premium sandbox subscription, the -is:retweet argument in the rule should exclude retweets. Instead, I get a requests.exceptions.HTTPError. Why?
Removing the -is:retweet argument from the rule payload makes the script run without error, by the way.

Hey there, the is:retweet operator is not supported in 'sandbox' levels of Premium.
See https://developer.twitter.com/en/docs/tweets/rules-and-filtering/overview/operators-by-product for reference.


Added Links to Corresponding Profiles

🔗 Issue
#429
✍ Description

Added corresponding profile links to both pet and adopter names
Asserted the presence of link in controller test

📷 Screenshots/Demos

@atbalaji please resolve conflicts :)

Done @kasugaijin . Resolved conflicts arised because of new PR changes

@atbalaji thank you for that!


Analytics event: CHANGE_CONTENT_TYPE

Fixes

Fixes #1071 by @dhruvkb
Description

Adds a new useComponentName composable
Adds the CHANGE_CONTENT_TYPE event and fires it on use of the VSearchType and VContentLink components
Adds dev logging to the sendCustomEvent method

TODO

[x] Add tests
[x] Figure out the terrible VLink click event situation

Testing Instructions

Checklist

[ ] My pull request has a descriptive title (not a vague title like
Update index.md).
[ ] My pull request targets the default branch of the repository (main) or
a parent feature branch.
[ ] My commit messages follow best practices.
[ ] My code follows the established code style of the repository.
[ ] I added or updated tests for the changes I made (if applicable).
[ ] I added or updated documentation (if applicable).
[ ] I tried running the project locally and verified that there are no visible
errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@zackkrida Is this PR blocked?

@WordPress/openverse-frontend apologies but I am going to need to hand this off to someone else. We can assign in the team meeting tomorrow 👍

Thanks for working on this, @obulat 😄

@obulat this has two approving reviews despite some dangling feedback from Sara. Could you review and merge, making any necessary follow-up issues?


Missing module error with the babelification

@floatdrop after 1d5ef4c5f6fcb70f9e90e584dfd08865db1e93b4 landed I'm now getting this error when testing got using master.
~/dev/got master
❯ ava

module.js:339
    throw err;
    ^

Error: Cannot find module 'babel-runtime/helpers/async-to-generator'
    at Function.Module._resolveFilename (module.js:337:15)
    at Function.Module._load (module.js:287:25)
    at Module.require (module.js:366:17)
    at require (module.js:385:17)
    at Object.<anonymous> (/Users/sindresorhus/dev/got/test/unix-socket.js:3:25)
    at Module._compile (module.js:435:26)
    at requireFromString (/Users/sindresorhus/dev/ava/node_modules/require-from-string/index.js:14:4)
    at Object.<anonymous> (/Users/sindresorhus/dev/ava/lib/babel.js:28:1)
    at Module._compile (module.js:435:26)
    at Object.Module._extensions..js (module.js:442:10)
module.js:339
    throw err;
    ^

Error: Cannot find module 'babel-runtime/helpers/async-to-generator'
    at Function.Module._resolveFilename (module.js:337:15)
    at Function.Module._load (module.js:287:25)
    at Module.require (module.js:366:17)
    at require (module.js:385:17)
    at Object.<anonymous> (/Users/sindresorhus/dev/got/test/retry.js:3:25)
    at Module._compile (module.js:435:26)
    at requireFromString (/Users/sindresorhus/dev/ava/node_modules/require-from-string/index.js:14:4)
    at Object.<anonymous> (/Users/sindresorhus/dev/ava/lib/babel.js:28:1)
    at Module._compile (module.js:435:26)
    at Object.Module._extensions..js (module.js:442:10)
TypeError: Cannot read property 'stack' of undefined
    at error (/Users/sindresorhus/dev/ava/cli.js:51:19)
From previous event:
    at Object.<anonymous> (/Users/sindresorhus/dev/ava/cli.js:218:34)
    at Module._compile (module.js:435:26)
    at Object.Module._extensions..js (module.js:442:10)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:311:12)
    at Function.Module.runMain (module.js:467:10)
    at startup (node.js:134:18)
    at node.js:961:3

@sindresorhus babel transpile files with async and add
var _asyncToGenerator = require('babel-runtime/helpers/async-to-generator')['default'];

At the top, but in module.paths of test there is no babel-runtime module:
Module {
  id: '/Users/floatdrop/github.com/got/test/unix-socket.js',
  exports: {},
  parent:
   Module {
     id: '/Users/floatdrop/github.com/got/node_modules/ava/node_modules/require-from-string/index.js',
     exports: [Function: requireFromString],
     parent:
      Module {
        id: '.',
        exports: {},
        parent: null,
        filename: '/Users/floatdrop/github.com/got/node_modules/ava/lib/babel.js',
        loaded: false,
        children: [Object],
        paths: [Object] },
     filename: '/Users/floatdrop/github.com/got/node_modules/ava/node_modules/require-from-string/index.js',
     loaded: true,
     children: [ [Circular] ],
     paths:
      [ '/Users/floatdrop/github.com/got/node_modules/ava/node_modules/require-from-string/node_modules',
        '/Users/floatdrop/github.com/got/node_modules/ava/node_modules',
        '/Users/floatdrop/github.com/got/node_modules',
        '/Users/floatdrop/github.com/node_modules',
        '/Users/floatdrop/node_modules',
        '/Users/node_modules',
        '/node_modules' ] },
  filename: '/Users/floatdrop/github.com/got/test/unix-socket.js',
  loaded: false,
  children: [],
  paths:
   [ '/Users/floatdrop/github.com/got/test/node_modules',
     '/Users/floatdrop/github.com/got/node_modules',
     '/Users/floatdrop/github.com/node_modules',
     '/Users/floatdrop/node_modules',
     '/Users/node_modules',
     '/node_modules' ] }

It looks like we should add some paths to paths property, but Node.js behaves the same way. Will look further in require hook for solution.

Removing runtime from optional helps.

So including runtime into optional makes Babel place require at the top. Removing it will work for Node.js with generators.
For Node.js 0.10.x we need regenerator runtime, which is depends on global Promise - https://github.com/facebook/regenerator/issues/142 (like co). Babel includes regenerator runtime + core.js polyfills, when used with babel-core/register.
We could append regenerator runtime before test code, but if we append Promise polyfill - it will leak into test code scope, which is bad (but not in module which is good).
@sindresorhus wdyt?

Or make Promise local to regenerator with function wrapping.

This sounds like the best solution, but I would say we go with the fastest solution now. We can do it properly later. This issue is blocking AVA 0.4.0, so would be nice to get it fixed as fast as possible.

core.js polyfills

Are we including this now? If not, that's a regression too.

Simply installing babel-runtime locally fixed.
It seems to me the requireFromString line is causing the error.
requires in the transpiled code are trying to resolve from the wrong directory to get access to babel-runtime. The resolution is happening from the base directory, but the runtime is in ./node_modules/ava/node_modules/babel-runtime, which won't resolve.
It should be possible to use derequire to change all the require(...) to ___uniquederquirename__ the transpiled code to  else, then prefix the generated code with:
function ___uniquederequirename___(path) {
   try {
      return require(path);
   } catch (e) {
       if (/^babel/.test(path)) {
          // resolve from ava's root directory
       }  else {
           throw e;
       }
   }
}

Are we including this now? If not, that's a regression too.

@sindresorhus all polyfills now excluded from tests, because they affect tested code. I guess fastest way is to revet this commit and use babel/register.
@jamestalmage resolution is happening in right directory, but yes, there is no babel-runtime around, so we either need to append parts of it to code (regenerator and Promise).

all polyfills now excluded from tests, because they affect tested code

With Babel 6 we can use https://github.com/babel/babel/tree/master/packages/babel-plugin-transform-runtime, right?

Externalise references to helpers and builtins, automatically polyfilling your code without polluting globals

Actually, in the Babel 5 docs it says that the runtime plugin does not pollute globals:

Basically, you can use built-ins such as Promise, Set, Symbol etc as well use all the Babel features that require a polyfill seamlessly, without global pollution, making it extremely suitable for libraries.

https://github.com/babel/babel.github.io/blob/862b43db93e48762671267034a50c30c00e433e2/docs/usage/runtime.md

@sindresorhus then it is worth to workaround require somehow:

install babel-runtime as peer-dependency
hack on m.paths in require-from-string
replace runtime require path with resolved one

install babel-runtime as peer-dependency

Are you sure you meant peerDependency? They don't install anything, but rather only warns the user to manually install it. I don't think we'd want that.

@sindresorhus yeah. I think I give a m.paths a shot, because I don't want to mess with replacing require statements.

Agreed.


Various improvements to the verification system

In addition to the currently allowed allowed_names, there's also close_names now, which are SHA1 hashes of:

@name (such as @ao)
name (such as ao)
#discrim (such as #5755)
discrim (such as 5755)

and their newlined versions.

Also, now instead of adding uppercase version of hashes to the hashed names list, I'm just making message content lowercase now.

There's more checks and warnings now:

The close name hashes, as mentioned before.
MD5 hashes of the allowed names.
The username#discrim check also checks for member id, username or discrim alone.

I'm not super confident in the strings I wrote for the 2 new checks, and I wouldn't mind getting some help about them.

Maybe for a future commit, but string concatenation is a heavy operation. Maybe use format()?

@noirscape format is ugly.
If I ever get around to rewriting robocop, I'll move minimum requirement to 3.6/3.7 where I'll have access to fstrings.


dimension names

@s-scherrer is there a function for getting dimension names from the gridded reader? If not can we add something like that:
def dimension_names(self) -> Mapping[str, Mapping]:
        ncfiles = glob.glob(str(Path(self.path) / "*.nc"))
        fname = next(filter(lambda s: not s.endswith("grid.nc"), ncfiles))
        with xr.open_dataset(fname) as ds:
            dimensions = {
                'longitude': ds.lon.name,
                'latitude': ds.lat.name,
                'time': ds.time.name
            }
        return dimensions

And please do a release :)

As discussed, this does not bring a lot of information because the processed data files have standardized dimension names.
The release is now published :)


Investigate reduce

Maybe some expressions over the quantifiers (any, all) can be combined with 'reduce' (functools).
Measure performance impact

Reduce has no end-condition and in general is at least 5 times as slow as the all/any equivalent


Sonoff SNZB-03 Motion Sensor needs Zigbee Bridge?

Hi, I'm interested in buying the Motion Sensor SNZB-03 and integrate in in HA. I've seen under tested devices that it says "Tested ZigBee (only Cloud)". Does this mean that i can integrate it in HA only via the SONOFF ZBBridge - Smart Zigbee Bridge?
Thanks.

Yes it needs a bridge. I would suggest to buy a zigbee transmitter like Conbee II (I have that, works with SNZB-03 and other sonoff zigbee devices) or similar to give your HA zigbee capability and integrate devices directly.

You need gateway or stick to work with zigbee devices
https://www.itead.cc/cc2531-usb-dongle.html


Create OMG.LOL WHOIS

This can now be handled via the omg.lol API.

Specifically: https://api.omg.lol/#noauth-get-address-retrieve-public-information-about-an-address

A new Lookup page is now live, which also does this: https://home.omg.lol/lookup


babel-runtime and react-hot-loader dependencies

Description
Module requires dev-dependencies "babel-runtime" and "react-hot-loader" that should not be required in production mode.

yes but no one deal with the problem

react-hot-loader can be added to production safely as long environment is set correctly during build See https://github.com/gaearon/react-hot-loader#what-about-production


Fix/components proto typo

Description
As the title says it adds plural on features response (which is actually a list)
Issue reference

Please reference the issue this PR will close: #5272
Checklist
Please make sure you've  completed the relevant tasks for this PR, out of the following list:

[ ] Code compiles correctly
[ ] Created/updated tests
[ ] Unit tests passing
[ ] End-to-end tests passing
[ ] Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]
[ ] Specification has been updated / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]
[ ] Provided sample for the feature / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

/ok-to-test

/ok-to-test


s/gowasm/go1.11beta1/g

Replace all references in makefiles and documentation of gowasm checkout and insert go1.11beta1.

fixed by #49


docs: example snippet to concat dp and results

Linked issue(s):
What change does this PR introduce and why?

Please check if the PR fulfills these requirements

[ ] Include reference to internal ticket and/or GitHub issue "Fixes #NNNN" (if applicable)
[ ] Relevant tests for the changes have been added
[ ] Relevant docs have been added / updated

Wait, why is this a documentation problem vs changing the output of download_results?


[Bug]

Search before asking

[X] I had searched in the issues and found no similar issues.

Apache SkyWalking Component
UI (apache/skywalking-booster-ui)
What happened
with v9 ui, in general dashboard, when pick a end date on the navbar, will set the start date with same value at same time, and cause a series of query error

What you expected to happen
should only set the end date.
How to reproduce

General Service
click any service to get General Dashboard
Navbar, right top, pick any end date

Anything else
Not really familiar with VueJS, has check the source code,

TimePicker.vue
setDates() emit twice, one with positon right, one without as position is undified, thus further set the start date
tricky walkround, double check left position

Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Everything on demo works. You could try that and recheck.

The errors should relate to your backend not working well.


Increased maximum number of fields from 100 to 256.

Closes #154 by increasing the number of supported fields.

@danielmohansahu , thanks for your initiative and your contribution!


Analyze network with subnetwork trace

Description
PR to add a new Kotlin sample "Analyze network with subnetwork trace" in Utility Networks category. This sample gets a server-defined trace configuration for a given tier and modify its traversability scope, add new condition barriers and control what is included in the subnetwork trace result.
Links and Data
Sample Epic: runtime/kotlin/issues/1693
What To Review

Review the code to make sure it is easy to follow like other samples on Android
Review that Kotlin code for suitable sample implementation of the Maps SDK

@shubham7109 looks good, a few comments...

@changanxian Thanks for the helpful feedback. I've gone through and added them in, and the sample has gone through a little bit of a refactor and it's looking better! Ready for your review.

A scroll view is required here since any number of conditions can be added to the expression. Decreased the margins to help fit the "Barrier Conditions" text and the expressionTextView text view.


[T4A2][F11-B1] Justin Ng

Please refer to commits de06e61 and 	f848ff6 for T4A2. On hindsight, I should not have merged my previous branches into master.
Ready for review.

Hi! Yupp Yupp, i've taken note of your comment above ~ but for official purposes I still have to mention this - Do note in the future to not include in activities commits ~
Otherwise :+1: for implementation.

Some comments added. Please close the PR after reading comments.


Package yiisoft/jquery is abandoned, you should avoid using it. No replacement was suggested.

Hi all, i update Yii2 (basic) with composer (just updated).
First i have this error:
Problem 1
- yiisoft/yii2 dev-master requires bower-asset/jquery.inputmask 3.1.* -

no matching package found.
- yiisoft/yii2 2.0.x-dev requires bower-asset/jquery.inputmask 3.1.* ->
no matching package found.
- Installation request for yiisoft/yii2 * -> satisfiable by yiisoft/yii
2[2.0.x-dev, dev-master].

So i read in another issue to try to update the composer asset plugin. I did it:

Removing fxp/composer-asset-plugin (v1.0.0-beta3)
Installing fxp/composer-asset-plugin (v1.0.0)

when i re-launch yii2 update with composer i have now this error:
Package yiisoft/jquery is abandoned, you should avoid using it. No replacement was suggested.
Writing lock file
Generating autoload files
What can i do?
Thank's

Remove vendor dir and try again.

composer clear-cache
rm -rf vendor
composer update

@samdark I am getting the same error
Package yiisoft/jquery is abandoned, you should avoid using it. No replacement was suggested.

Removed vendor folder and reran composer but same error appears again! any help?

Have you installed global composer plugin as mentioned in docs? http://www.yiiframework.com/doc-2.0/guide-start-installation.html#installing-via-composer

@samdark of course, I tried doing it again but same error
also self-updated the composer

please paste your composer.json in full.

I get also this error but only on my linux machine not on windows.
here my composer.json
{
	"name": "Hundekauf.de",
	"description": "Yii 2 Basic Application hundekauf.de",
	"keywords": ["hundekauf", "Anzeigenmarkt", "Kleinanzeigen", "Welpen und Hunde kaufen und verkaufen"],
	"homepage": "http://www.hundekauf.de/",
	"type": "project",
	"license": "Privat",

	"minimum-stability": "dev",
	"require": {
		"php": ">=5.4.0",
		"yiisoft/yii2": "*",
		"yiisoft/yii2-bootstrap": "*",
		"yiisoft/yii2-swiftmailer": "*",
        "yiisoft/yii2-imagine": "*",
        "kmergen/yii2-widgets": "dev-master",
		"kartik-v/yii2-date-range": "*",
        "kmergen/yii2-feed": "dev-master"
	},
	"require-dev": {
		"yiisoft/yii2-codeception": "*",
		"yiisoft/yii2-debug": "*",
		"yiisoft/yii2-gii": "*",
        "yiisoft/yii2-faker": "*"
	},
	 "scripts": {
        "post-create-project-cmd": [
            "yii\\composer\\Installer::postCreateProject"
        ]
    },
	"config": {
		"process-timeout": 1800
	},
	"extra": {
        "yii\\composer\\Installer::postCreateProject": {
            "setPermission": [
                {
                    "runtime": "0777",
                    "web/assets": "0777",
                    "yii": "0755"
                }
            ],
            "generateCookieValidationKey": [
                "config/web.php"
            ]
        },
        "asset-installer-paths": {
            "npm-asset-library": "vendor/npm",
            "bower-asset-library": "vendor/bower"
        }
    }
}

In my case I have solve the problem.
I have run composer as sudo and than the lock file owner is root.
You should run composer without sudo so that all file owner is logged in user.

I have this problem too. Global composer plugin installed. composer.json from yiisoft/yii2-app-basic basic installation.

any more resolution for this same error, i also got this error, and cannot fix it for serveral days?

I also have the same problem.How to solve it?

@kmergen @Lordfef you have an outdated version of the composer plugin asset, run
composer global require "fxp/composer-asset-plugin:~1.0.0"
The 1.0.0 at the end is the most important part.

Same problem for me.
Removed vendor & composer.lock, re-ran composer, and
Package yiisoft/jquery is abandoned, you should avoid using it. No replacement was suggested.
Isn't it because yiisoft/jquery-pjax depends on yiisoft/jquery ?

No. Seems you're missing composer asset plugin: https://github.com/yiisoft/yii2/issues/8094#issuecomment-121707254

Hmm, I have the composer asset plugin... I even updated it to v1.1.1 to avoid deprecated warnings.
If I remove yiisoft/jquery-pjax from my composer.json, I don't have the warning message anymore.

@samdark if you check https://packagist.org/packages/yiisoft/jquery-pjax you will notice that indeed if you load pjax from composer it will ask you to install yiisoft/jquery
@tof06 if you require to use pjax I advice to install it using bower adding
"bower-asset/yii2-pjax": "*"
to your composer.json

@Faryshta Thanks, works fine now!

@Faryshta thanks! https://github.com/yiisoft/jquery-pjax/commit/593b9d694b80e6832ca1fcbcd34627372b689329

Why the heck should yiisoft/jquery and yiisoft/jquery-pjax be installed if I use Yii as a RESTful API? Maybe you should consider moving all UI stuff out?

Absolutely. It's already planned for next major versions.

Will it be Yii 3.x or 2.x?

2.1.x or 2.2.x.


Backstage Working Group - DevOps Automation - Sep 28, 2023

Date
Thursday, Sep 28, 2023 - 11am ET; 3pm UK
Untracked attendees

Name
Firm
Comment

Meeting notices

FINOS Project leads are responsible for observing the FINOS guidelines for running project meetings. Project maintainers can find additional resources in the FINOS Maintainers Cheatsheet.

All participants in FINOS project meetings are subject to the LF Antitrust Policy, the FINOS Community Code of Conduct and all other FINOS policies.

FINOS meetings involve participation by industry competitors, and it is the intention of FINOS and the Linux Foundation to conduct all of its activities in accordance with applicable antitrust and competition laws. It is therefore extremely important that attendees adhere to meeting agendas, and be aware of, and not participate in, any activities that are prohibited under applicable US state, federal or foreign antitrust and competition laws. Please contact<EMAIL_ADDRESS>with any questions.

FINOS project meetings may be recorded for use solely by the FINOS team for administration purposes. In very limited instances, and with explicit approval, recordings may be made more widely available.

Agenda

[ ] Convene, roll call, welcome new people
[ ] Approve previous meeting minutes
[ ] Review DevOps SIG project board
[ ] Guest speaker, Christophe Fargette, RedHat
[ ] AOB, Q&A & Adjourn (5mins)

Decisions Made

[ ] Decision 1
[ ] Decision 2
[ ] ...

Action Items

[ ] Action 1
[ ] Action 2
[ ] ...

Zoom info
Join Zoom Meeting

https://zoom.us/j/95521041942?pwd=dHgwREU2TzBsS242ak1zYWZsUW9OUT09
Meeting ID: 955 2104 1942
Passcode: 443820
Find your local number: https://zoom.us/u/aesEqmNODb

Github Repo: https://github.com/finos/devops-automation/
Project Board: https://github.com/orgs/finos/projects/33
Mailing List: Email<EMAIL_ADDRESS>to subscribe to our mailing list

👋 Cara Delia / Red Hat


Support communication with the debugged process over UNIX-domain sockets

I'd like to add the option for the debugger to listen on an Unix-domain socket, to avoid having a TCP port open by the debugger on a shared server (I can restrict access to the Unix-domain socket via Unix permissions).
The patch also updates the documentation.

It has not been merged; I'm using the patched version

It has not been merged; I'm using the patched version

Yeah, either way I'm not sure this works for xdebug php module anyway. I did not see any socket communication options for configuration.

Yeah, either way I'm not sure this works for xdebug php module anyway. I did not see any socket communication options for configuration.

Hi,
I've done some playing around with this and I'm pretty sure @lkraav is right about Xdebug not supporting unix sockets. @mbarbon what language are you debugging with?

I'm using a patched version of ActiveState Komodo debuggin helper for Perl

Ah I see. Do you need to use Unix sockets instead of tcp sockets?
Basically, what's your inspiration behind this PR? Thanks
On Mon, 24 Aug 2015 19:10 Mattia Barbon<EMAIL_ADDRESS>wrote:

I'm using a patched version of ActiveState Komodo debuggin helper for Perl
—
Reply to this email directly or view it on GitHub
https://github.com/joonty/vdebug/pull/190#issuecomment-134321827.

I want the option of not having an "execute arbitrary code as a different user" port open while I am debugging (because of a partially shared development environment).
I realize it's not the common case, it just seemed a nice option to have.

I'm going to keep this one on ice for now - I'll look at implementing it in version 2, as I don't want to add any more features to version 1. Thanks again.


[BUG] Class-names created from wrong attributes

I checked one of the generated CSS files from using unocss, and noticed that there were a lot of weird classnames. After searching for similar names throughout my codebase i found that unocss was generating classnames from a "d" attribute on a path element.
This behaviour heavily pollutes the bundled CSS.
I've created a repo that reproduces the bug with minimal setup: https://github.com/MathiasWP/unocss-attribute-bug

try this
  presetAttributify({
    strict: true,
  }),


Failure with recursive add with binary in sub directory

When adding a tree like this
$ ipfs add -r src/test/resources/html
added QmVts3YjmhsCSqMv8Thk1CCy1nnpCbqEFjbkjS7PEzthZE html/README.html
added QmYpbSXyiCTYCbyMpzrQNix72nBYB8WRv6i39JqRc8C1rx html/chap/ch01.html
added QmT1cVKZQPvKhS8Rg9ek7UgThwFC8gC6gAJBiRwMKMnYyg html/css/default.css
added QmaMgvGJjZU511pzH1fSwh9RRnKckyujoRxVeDSEaEGM5N html/img/logo.png
added QmeaY5WQKs3iB5UrgobERnTamHwJYMcCLRWhHK42KtVt1b html/chap
added QmfPRsChuVCsnN4PGLaDCngvjqCoc9KGkxea4hgiq6qitk html/css
added QmYhaNnLGtFDEc559T9bVkqYqaXLGojMWDzVqjFZgrmnCi html/img
added QmWVMRbFTrA6pMhsfXzsyoWqmrhy5FPd4VitfX79R5bguw html

I see the java client fail like this
java.lang.IllegalStateException: Remote IPFS error: http: invalid Read on closed Body
	at io.ipfs.api.MerkleNode.fromJSON(MerkleNode.java:74)
	at io.ipfs.api.IPFS.lambda$0(IPFS.java:91)
	at java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:193)
	at java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1382)
	at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:481)
	at java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:471)
	at java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:708)
	at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
	at java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:499)
	at io.ipfs.api.IPFS.add(IPFS.java:92)
	at io.ipfs.api.IPFS.add(IPFS.java:78)
	at io.ipfs.api.IPFS.add(IPFS.java:74)
	at io.ipfs.api.IPFS.add(IPFS.java:70)
	at io.ipfs.api.RecursiveAddTest.testAdd(RecursiveAddTest.java:21)

This is caused by html/img/logo.png
Here is a PR that should help to reproduce this: https://github.com/ipfs/java-ipfs-api/pull/80

This still seems to work with 0.4.13 but fails with 0.4.14 and above

This is a blocking issue for our Blockchain + IPFS effort

This seems to be a problem with the server side impl. I replaced all of the multipart and named stream impl with Apache HttpClient and byte[]. It now does not fail as reliably any more, but it still fails ca. 50% of the time. The cmd line client must somehow construct/send the multipart request in a different way, such that the server reliably accepts it - I'm puzzled.
Any idea, any one?
https://github.com/tdiesler/java-ipfs-api/blob/ghi79/src/test/java/io/ipfs/api/RecursiveAddTest.java#L69

Done.
PR #91 replaces the existing Multipart implementation with Apache HttpClient. I believe the problem was with an incorrect implementation of chunked encoding, which is indeed not trivial to do.
This now pulls in additional dependencies
[tdiesler@macbook java-ipfs-api]$ mvn dependency:tree
[INFO] Scanning for projects...
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] Building java-ipfs-api v1.2.1-SNAPSHOT
[INFO] ------------------------------------------------------------------------
[INFO]
[INFO] --- maven-dependency-plugin:2.8:tree (default-cli) @ api ---
[INFO] io.ipfs:api:jar:v1.2.1-SNAPSHOT
[INFO] +- com.github.multiformats:java-multiaddr:jar:v1.3.0:compile
[INFO] |  +- com.github.multiformats:java-multibase:jar:v1.0.0:compile
[INFO] |  +- com.github.multiformats:java-multihash:jar:v1.1.0:compile
[INFO] |  \- com.github.ipld:java-cid:jar:v1.1.0:compile
[INFO] +- org.apache.httpcomponents:httpmime:jar:4.5.6:compile
[INFO] |  \- org.apache.httpcomponents:httpclient:jar:4.5.6:compile
[INFO] |     +- org.apache.httpcomponents:httpcore:jar:4.4.10:compile
[INFO] |     +- commons-logging:commons-logging:jar:1.2:compile
[INFO] |     \- commons-codec:commons-codec:jar:1.10:compile
[INFO] +- junit:junit:jar:4.12:test
[INFO] \- org.hamcrest:hamcrest-core:jar:1.3:test
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------

and will likely break the non-maven build. However, it removes the maintenance cost for a correct multipart implementation and perhaps more importantly should work with very large files in directory structures.
Tested with
> ipfs daemon --enable-pubsub-experiment &
> mvn clean install

Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.799 sec - in io.ipfs.api.IPFSAddTest
Tests run: 36, Failures: 0, Errors: 0, Skipped: 2, Time elapsed: 21.839 sec - in io.ipfs.api.APITest

Thanks.
This is now out of date


refactor: change all serial id columns to be GENERATED AS IDENTITY ones

/deploy

This change is part of the following stack:

#461 ◀

Change managed by git-spice.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>9
Details

66 of 67 (98.51%)  changed or added relevant lines in 7 files are covered.
No unchanged relevant lines lost coverage.
Overall first build on refactor-change-all-serial-id at 90.78%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

components/renku_data_services/migrations/versions/ce54fdbb40fe_change_serial_to_generated_identity_for_.py
47
48
97.92%

Totals

Change from base Build<PHONE_NUMBER>4:
90.8%

Covered Lines:
10801

Relevant Lines:
11898

💛  - Coveralls

Can we make sure this works on an already-populated deployment? Make a test PR in renku, deploy prior to this migration, then add some data (e.g. add a resource class), then migrate and check that items can still be created.

I did that in the original PR before splitting off this change and locally, but just did it again in https://github.com/SwissDataScienceCenter/renku/pull/3820 to double check (Adding projects with repositories) and it works fine.

Tearing down the temporary RenkuLab deplyoment for this PR.


[BUG] The profile information on the bottom left corner of Discord no longer fits w/ Zelk.

Describe the bug
Title describes it all.
Use Zelk, and look at the bottom left corner of Discord.
Both any plugin that goes with the profile information thingy and the thing itself no longer fits with Zelk.
To Reproduce
Steps to reproduce the behavior:

Install Powercord.
Get Theme Toggler & Zelk.
Look at the bottom left corner.

Screenshots
https://i.imgur.com/2MfGAZO.png
https://i.imgur.com/52mNtwg.png
Setup

OS: Windows 10 21H1 (OS Build 19043.1052)
Client Mod: Powercord.... unknown version.
Release Channel: Discord Canary 88877 (91ec52d)
Enabled Themes: Zelk 1.1.1 | Better Badges 1.2 | Discolored 1.0.0
Enabled Plugins: Default Powercord Plugins | BDFDB | BetterImageViewer | BlurNSFW | CopyRawMessage | CreationDate | GoogleTranslateOption | MessageLoggerV2 | MultiUploads | QuickDeleteMessages | bdCompact | Theme Toggler | Reacter

fixed it

Oh yeah and thanks for fixing it but on the bottom of it, it still has a square shape instead of a rounded shape.
https://i.imgur.com/YCfx8Qi.png
very picky ik cri

hmmm, not in my experience, where exactly is it (channel list, dms etc)?

both lol, going to a server, dm's, anywhere, it still has a square shape and such.


Using HTML for challenge descriptions

The current challenge descriptions are plain text, or are being auto escaped. It would be helpful if this field accepted HTML, for simple markup such as links and bullet points. I don't think it needs a full HTML editor in Mission Control to make this useful, but it might be a direction to go.
If you think this is a good idea I would be happy to work on it.

So in lieu of using HTML we were trying the approach of using Markdown in GRA 4. You can see the Markdown editor we're using in the "Pages" section of the software (though it needs a little more work, e.g. maybe tabbed preview rather than text on top and preview on bottom). The upshot of using Markdown is that HTML can be included in Markdown without any sort of escaping or qualification.
I was kind-of hoping to keep the descriptions of things like challenges as text so that on the details page they'd all be formatted the same but maybe it makes sense to use Markdown for those. It should be trivial to use the same Markdown editor for Challenge descriptions as we use for Pages.
@iafb - was there any reason we didn't use HTML in Challenge descriptions that you can think of?

I don't think there was any reason discussed for not doing it that way. If we do add HTML/Markdown to Challenge descriptions it'd probably make sense to use it for Events as well.

Agree with @iafb - we can do Markdown for Challenge and Event descriptions using the built-in Markdown editor. We may need to expand description fields to accept more text for this. If possible we should improve the Markdown editor and ensure it's pluggable so that as we improve it those improvements are reflected everywhere that it's used.

Thanks for the replies to all my questions. I am a big fan of Markdown so It sounds like what you are proposing would work perfect.

This issue was resolved in #452 Add Challenge improvements


Error while trying to build prompts for Tamil language

In my lexicon file, words are in the format as follows
("அ" nil (((a) 1)))
I'm actually trying to build Tamil voices using festival.
But when I'm trying to build prompts using " ./bin/do_build $PARALLEL build_prompts " , it gives errors as " ta_1566 PROMPTS
LEXICON: Word ஆண்டாள் (plus features) not found in lexicon " for all the sentences in txt.done.data file.
But all those words are in my lexicon.scm file. How to get over with this error?

The lexicon is probably not sorted correctly.
Though we have open sourced a Tamil dataset, we don't have festival recipes for Tamil


Can't add new styles in python2

Hi,
When adding a new style to the subtitles I get the following error:
Traceback (most recent call last):
  File "colorset.py", line 20, in <module>
    subs1.save(foutput,format_='ass')
  File "/home/mohammad/.local/lib/python2.7/site-packages/pysubs2/ssafile.py", line 190, in save
    self.to_file(fp, format_, fps=fps, **kwargs)
  File "/home/mohammad/.local/lib/python2.7/site-packages/pysubs2/ssafile.py", line 222, in to_file
    impl.to_file(self, fp, format_, fps=fps, **kwargs)
  File "/home/mohammad/.local/lib/python2.7/site-packages/pysubs2/substation.py", line 253, in to_file
    fields = [field_to_string(f, getattr(ev, f)) for f in EVENT_FIELDS[format_]]
  File "/home/mohammad/.local/lib/python2.7/site-packages/pysubs2/substation.py", line 242, in field_to_string
    raise TypeError("Unexpected type when writing a SubStation field")
TypeError: Unexpected type when writing a SubStation field

If I run the same code in python3 it runs fine but if i run it under python2 i get the error,
I'm trying to use pysubs2 in kodi which currently only support python2.
The code I used
import pysubs2
import chardet

finput='en.srt'
foutput='en.ass'
with open(finput,'rb') as fi:
	rawdata = fi.read()
	encoding = chardet.detect(rawdata)['encoding']
fi.close()

subs1 = pysubs2.load(finput)
top_style = pysubs2.SSAStyle()
top_style.alignment=8
subs1.styles['top-style'] = top_style
subs1[0].style='top-style'
for line in subs1:
	line.style='top-style'
subs1.save(foutput,format_='ass')

I think this project is not maintained anymore :(
I was able to find the problem so I'm leaving this for anyone who might encounter the same problem or might want to fix the library.
The problem is in the field_to_string function
https://github.com/tkarabela/pysubs2/blob/ddd0c2e79bcf4fcb497feaf8afc22c5d70334aa5/pysubs2/substation.py#L225-L242
At line 234 It checks whether the field ('style' in our case ) is of type text, but it does this differently in python3 and python2, In Py3 it compares it to 'str' type while in Py2 it compares it to Unicode type.
This can probably be fixed in the library but I didn't bother changing it.
So I just changed the input to unicode like so:
import pysubs2
import chardet

finput='en.srt'
foutput='en.ass'
with open(finput,'rb') as fi:
	rawdata = fi.read()
	encoding = chardet.detect(rawdata)['encoding']
fi.close()

subs1 = pysubs2.load(finput)
top_style = pysubs2.SSAStyle()
top_style.alignment=8
subs1.styles['top-style'] = top_style
subs1[0].style= u'top-style'
for line in subs1:
	line.style='top-style'
subs1.save(foutput,format_='ass')

I don't have much time to develop this library anymore, but every now and then I manage to release a new version, so it's not quite dead :)
The best way to use pysubs2 is from Python 3 or Python 2 with from __future__ import unicode_literals. I was able to fix your particular issue, so your original code now works as expected with Python 2.7 and newly released 0.2.3 version of the library.

@tkarabela, unfortunately, The problem is not fixed, as a matter of fact, I now get the exception even if I passed the style as a Unicode string.
Thank you for your great work

I'm sorry to hear that, @moham96. I've tested the change and seems to be working on my end (Ubuntu 17.10, Python 2.7.14):
import pysubs2
import chardet

finput='en.srt'
foutput='en.ass'

# check pysubs2 version
print "using pysubs2 version", pysubs2.VERSION

# create dummy input data
with open(finput, "w") as fi:
    print >>fi, "1"
    print >>fi, "00:00:00,00 --> 00:01:00,00"
    print >>fi, "Hello world"

with open(finput,'rb') as fi:
    rawdata = fi.read()
    encoding = chardet.detect(rawdata)['encoding']
fi.close()

subs1 = pysubs2.load(finput)
top_style = pysubs2.SSAStyle()
top_style.alignment=8
subs1.styles['top-style'] = top_style
for line in subs1:
    line.style='top-style'
subs1.save(foutput,format_='ass')

# check output file
with open(foutput) as fo:
    print fo.read()

Output:
using pysubs2 version 0.2.3
[Script Info]
; Script generated by pysubs2
; https://pypi.python.org/pypi/pysubs2
WrapStyle: 0
ScaledBorderAndShadow: yes
Collisions: Normal
ScriptType: v4.00+

[V4+ Styles]
Format: Name, Fontname, Fontsize, PrimaryColour, SecondaryColour, OutlineColour, BackColour, Bold, Italic, Underline, StrikeOut, ScaleX, ScaleY, Spacing, Angle, BorderStyle, Outline, Shadow, Alignment, MarginL, MarginR, MarginV, Encoding
Style: Default,Arial,20.0,&H00FFFFFF,&H000000FF,&H00000000,&H00000000,0,0,0,0,100.0,100.0,0.0,0.0,1,2.0,2.0,2,10,10,10,1
Style: top-style,Arial,20.0,&H00FFFFFF,&H000000FF,&H00000000,&H00000000,0,0,0,0,100.0,100.0,0.0,0.0,1,2.0,2.0,8,10,10,10,1

[Events]
Format: Layer, Start, End, Style, Name, MarginL, MarginR, MarginV, Effect, Text
Dialogue: 0,0:00:00.00,0:01:00.00,top-style,,0,0,0,,Hello world

Can you send me your exact script and stack trace that is still throwing exception in pysubs2 v0.2.3?

@tkarabela
It  is solved, I upgraded the library in the python3 site-packages and tested on the python2  :sweat_smile:
It was a stupid mistake on my end.
Thank you very much for your help


Possibility to use different AWS profile than default

Is there any solution how to pass AWS profile to kube-aws? We have 2 separate clusters in two separate AWS accounts and it's not so easy to do something with these to cluster because every time i need to check which account i currently have set as default.

I run it like this:
AWS_PROFILE=.... kube-aws update
and my default profile is empty, so that it cant' run at all unless I set it. Would it work for you?

Thank you @redbaron it works as expected. But I think it should be documented somewhere.

@Vrtak-CZ @redbaron Thanks for taking your time 👍 Yes, it should be documented. Perhaps adding a FAQ.md containing this would help?


Create a Guide for adding a "break-glass" account

Overview
We would like to make a guide that helps demonstrate how to create a "break-glass" account for the HackForLA's AWS platform. This guide should convey how to add an emergency account that could be used in exceptional circumstances.
This guide should reside in the Ops Wiki.
The Wiki is located at this URL https://github.com/hackforla/ops/wiki
Action Items

[ ] Clarify who should be able to have an access for this account
[ ] Document best security practices
[ ] Draft 'Adding a "break-glass" account Guide

Prior version of issue

Overview
We would like to make a guide that helps demonstrate how to create a "break-glass" account for the HackForLA's AWS platform. This guide should convey how to add an emergency account that could be used in exceptional circumstances.
This guide should reside in the Ops Wiki.
The Wiki is located at this URL https://github.com/hackforla/ops/wiki
Action Items

[ ] Clarify who should be able to have an access for this account
[ ] Document best security practices
[ ] Draft 'Adding a "break-glass" account Guide

Assignee, Labels, Project Board Placement, and Milestones for this issue in the [INSERT COP NAME] Repo:

@VAntonina  This guide issue is moving to the knowledgebase-content repo. If you would like to maintain edit access to the issue and its associated files, please fill out the Google Drive Access Form.


Chrome 57.0.2987.133 (64-bit) breaks charts

Updating chrome to latest version 57.0.2987.133, suddenly my charts are broken.
Ref: http://ec2.buser.net/bnforecast/meteogramv2/#!/app/dashboard?start=KBTP&product=MAV
Reason being this always give 0px in return.
d3.select('#bntextrefmeteo').style("height")
This gives correct results though
d3.select('#bntextrefmeteo').style("height")
D3 version used is:
"d3": "4.7.3",

Your two code snippets are identical, so I can’t speculate what the problem is here. In any event, your code likely depends on some browser quirk, or you have discovered a bug in Chrome 57; the behavior you describe is not likely to be a bug in D3, as the implementation of selection.style is simply to return the computed value of whatever style property you specify.
Please use Stack Overflow tag d3.js to ask for help. Although I make an effort to assist everyone that asks, I am not always available to provide help promptly or directly. Stack Overflow provides a better collaborative forum for self-help: tens of thousands of D3-related questions have already been asked there, and some answered questions may be relevant to you.
When asking for help, please include a link to a live example that demonstrates the issue, preferably on bl.ocks.org. It is often impossible to debug from code snippets alone. Isolate the issue and reduce your code as much as possible before asking for help. The less code you post, the easier it is for someone to debug, and the more likely you are to get a helpful response.
If you have a question about D3’s behavior and want to discuss it with other users, also consider the d3-js Google Group or joining the d3-js Slack.
Thank you! 🤗

Roger that I'll ask this on stackoverflow with more information.
Correction:
This gives correct results though
d3.select('#bntextrefmeteo').style("width")
Thank You!
:-)

I was having the same issue. A newer version of chrome fixed it.


Scaling issues

Which operating system does the issue occur on?
Fedora 27

If on linux, are you using X11 or Wayland?

Wayland

I have tried to look for the configuration on .allacrity.yml but could not find the correct configuration. Tried to increase the font size as well, but doesn't work. Did I miss something?

Try increasing the font size but start alacritty from a different terminal emulator.
If the font size doesn't change when changing it it the config, there's probably something wrong with the config.

changing the font to a larger number (30.0) helps. The window size is smaller than the text though, which makes some text goes to the new line. Is it because my screen resolution?

I mean there's only so much text that can fit into one line, if it doesn't fit, it will flow over into the next on.

I'm having the same issue on macOS whe my laptop is connected to an external monitor. When the monitor is not connected, alacritty's font rendering is normal. However, when the monitor is attached (iTerm for comparison):

This is a current issue with glutin, it does not allow getting the DPI on a per-monitor-basis. So having two very different monitors can lead to issues with font scaling.

Sorry for the late reply and for the unclear comment. What I meant was, I need to change my font size into size 30+ to get the same size as font size 18 on gnome-terminal.
I am using XPS 13.3” QHD+ (3200 x 1800)  if that helps

Same issue here on Macos.
I need these settings to make the fonts similar on both screens:
Retina screen: 12px
2k 27inch external screen: 18px

Sounds like it might be related to https://github.com/jwilm/alacritty/issues/964
can you try this to see if it fixes your issue?


two question about call-home  keepalive

hi，
I user netopeer2-server-0.7.0 in my uCPE and use call-home feature to connect the ODL(OpenDaylight) controller. some times, Odl show uCPE's  status is offline, and use netstat  -ant command to view the tcp link does not exist. but ssh to the uCPE，use netstat -ant command show link is OK as below, so uCPE  will not reconnect to ODL.
tcp        0      0 <IP_ADDRESS>:39510          <IP_ADDRESS>:6666      ESTABLISHED
two  questions are as follow:

how to keep(or check) this netconf link between uCPE and ODL?
I configure callhome with connection-type parameters max-wait, max-attempts for keepalive，but failed to hit any packets to ODL using wireshark.

Sincerely.

Hi,
keep-alive is the responsibility of libnetconf2 and it should be enabled by default, in the current version 0.12.55. It was added quite some time ago but maybe you have an older version where it is not, so please update.
Regards,
Michal


More docs in configuration example

I love that you have a docker compose with full configuration example for this!
Can we put more docs inline in this configuration example in comments?
https://github.com/educational-technology-collective/jupyterlab-pioneer/blob/main/configuration_examples/jupyter_jupyterlab_pioneer_config.py
For instance, what does the activeEvents mean vs. the logNotebookContentEvents? When would I have some things active and logged and some things not? For each of the exporters can you have a description of what it means inline with it?

https://github.com/educational-technology-collective/jupyterlab-pioneer/blob/283c554f7b8a7692ff5f1ea6f6c7e0fb1606d1c2/configuration_examples/all_exporters/jupyter_jupyterlab_pioneer_config.py


Enable coveralls.io

@evanmiller the travis file should already submit coverage info to coveralls.io, so probably enough if you just switch it on at https://coveralls.io/.

What is the motivation here?

It will tell us (and track) which lines are run by the tests and give an indication which parts of the code are not actually tested.

Ok, I've enabled it. Will add a badge to the README for kicks.

Ha, there are only three lines that aren't covered by the tests :+1:


Document that Debian-based iCub Live and pc104 icub-head are not supported anymore since robotology-distro 2024.11

Since https://github.com/robotology/robotology-superbuild/pull/1547 new versions of the robotology-superbuild do not support Debian 10 and 11 (that is the version available in latest iCubOS). I guess it could be a good idea to mention this in related documentation pages:

https://icub-tech-iit.github.io/documentation/icub_operating_systems/pc104/icub-live/

Or directly remove this pages to simplify documentation (if somebody needs them they can be found in git history).

If I am not wrong, this means dropping support for newer distro for the following non-iceboxed robots (I checked the robots that still use cfw2can:

iCubLondon01
iCubDijon01
iCubGrenoble01
iCubGenova03
iCubHertfordshire01

Probably we can discuss in person before taking a decision.

Or directly remove this pages to simplify documentation

Right because you spotted old robots not in the icebox, perhaps a better option is rather to add a note in the present documentation.

Probably we can discuss in person before taking a decision.

Yep 👍🏻

iCubGrenoble01 is under upgrade and we will use the COM-EXPRESS removing the CFW2 board

iCubHertfordshire02 as well.

Relevant robots moved to icebox:

https://github.com/robotology/robots-configuration/pull/687

cc @traversaro

Thanks!

Hi @reafrancesco

@maggia80 would it be possible to start similar upgrade procedure for the iCubGenova03?

This is kind of off-topic here. Would you mind reaching out to @maggia80 using other channels?


Fix a spelling mistake in the DonutVend's advertisments

About the PR
For probably a year or so, this spelling mistake has existed. And for about a few months or so, nobody went and fixed it.
So, here I am, fixing another two letters.
Requirements

[X] I have read and am following the Pull Request and Changelog Guidelines.
[X] I have added media to this PR or it does not require an ingame showcase.

Changelog
a 2 character change really shouldn't need one

Thanks for the cleanup!


Create methods to view admins, owners and operators

Currently the only way to read admins, owners or operators for given epoch (and their threshold values) is through reading specific eternal storage slots.
We should create methods to easily access that data. There are several ways to do this:

Adding according methods to the Gateway itself (this will increate the contract size that is already close to the limit)
Adding the methods to our JavaScript library so the according storage slots can be computed locally and then read from the contract
Accessing that data from the Gateway event history. For each operator/ownership transfer we emit events containing required information

    event OperatorshipTransferred(
        address[] preOperators,
        uint256 prevThreshold,
        address[] newOperators,
        uint256 newThreshold
    );

The gas saving approach would be reading the data from events and eventually stop saving the list of operators to the gateway storage. Event history can be considered as such storage that is also costly. End simplifying the event structure by dropping preOperators could save gas even more as this data can be found in the previous event:
    event OperatorshipTransferred(
        uint256 newEpoch,
        address[] newOperators,
        uint256 newThreshold
    );

Owners and operators can be read through external methods currently. But admins cannot and all the thresholds cannot. At the least, for transparency we should allow reading admins from the contract/explorer itself. Maybe we can save space in another way.

Fixed #81


Add new Component Date-Range to the statistics consumption

If it's validate technically/functionally, we can integrate it, in the rest of the project.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Ben Romdhane seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Here is my feedbacks:
1\ Input field is not visible when date selector is shown

2\ Icon is missing

3\ Only when icon is clicked the selector should be displayed
4\ If I click in the input field, I should be able to change the date/time manually

Done, but the popup will still open while we type


dns/bind - use separate tables for master and slave domains

Accidentally deleted the branch assuming the PR was long closed. Here's the reconstructed changes by @8191 and me.

Merged, thanks!

The changes from PR #2874 did not get put into the secondary zone dialog, only the primary for some reason. Submitting a PR to fix this shortly...

Also why are all the secondary zone options still present in dialogEditBindMasterDomain.xml if the idea was to create separate dialogs?


Make the code generator generate header files by reading IDL files.

After this patch, ./bacardi build command will print generated header file by
code generator. It has the same shape with calculator_bridge.h.
ISSUE=#51

@yjaeseok Thank you for review.