Fix, and document, some table/paragraph interrupt corner cases

Fixes #540
interrupting paragraphs with tables
Pulldown-cmark gives "heavy" tables (with a leading |) higher priority than "light" tables for paragraph interruption. This is compatible with older versions of GitHub, but 2023-06-21 GitHub treats them the same.
A quick run through https://babelmark.github.io shows, of the implementations that support pipe tables at all[^1]:

Implementation     ->
a
b
c
d
e
f
g
h
i
j

pulldown-cmark
✓
x
x
x
x
✓
x
x
✓
x

github/cmark-gfm
✓
x
✓
x
✓
✓
✓
✓
✓
x

pycmarkgfm
✓
x
✓
x
✓
✓
✓
✓
✓
x

DFM[^2]
✓
✓
✓
✓
✓
✓
✓
-
-
x

league/commonmark GFM
✓
✓
✓
✓
✓
✓
✓
x
✓
x

s9e/TextFormatter
✓
✓
✓
✓
✓
✓
✓
x
x
x

markdown-it[^3][^4]
✓
x
✓
x
✓
✓
✓
x
-
-

php-markdown-extra
✓
x
✓
x
✓
✓
✓
x
x
x

markdig
x
x
x
x
x
x
x
x
x
x

MD4C
x
x
x
x
x
x
x
x
x
x

parsedown
x
x
x
x
x
x
x
x
x
x

maruku[^3]
x
x
x
x
x
x
x
x
x
-

cebe
x
x
x
x
x
x
x
x
x
x

pandoc
x
x
x
x
x
x
x
x
x
x

multimarkdown
x
x
x
x
x
x
x
x
x
x

A lot of Extended Markdown parsers don't allow tables to interrupt paragraphs at all, even if they support pipe tables in general.

Out of the ones that do, about half of them do what GitHub does and disallow it when the table is indented by four or more spaces.

[^1]:
Implementations that "support pipe tables at all" were identified by
including "table a" without a preceding paragraph and seeing if it
produced an HTML table for that.
[^2]:
On "table h" and "table i", DFM sees a table with no cells, followed
by a paragraph with b in it.
[^3]:
On "table j", maruku and markdown-it see a table with no cells, followed
by a paragraph with b in it.
[^4]:
On "table i", markdown-it sees a table with no cells, followed
by a paragraph with b in it.

ambiguity between "light" tables and h2
This PR also changes scan_table_head to refuse any table with zero pipes at all in its header line. This resolves an ambiguity with settext-style <h2>, and matches every other Markdown implementation I could fine in Babelmark (see interrupting paragraphs with tables, "table j"), except maruku and markdown-it, which behave very strangely.

ambiguity with "light" tables and bulleted lists with -
This PR adds a test case for the existing behavior on tables like this:
a | b
- | -
1 | 2

It doesn't change the behavior, but it does document it.

Implementation     ->
parsed as

pulldown-cmark
table

github/cmark-gfm
list

pycmarkgfm
list

markdown-it
table

php-markdown-extra
table

DFM
table

league/commonmark GFM
list

s9e/TextFormatter
table

markdig
table

MD4C
list

parsedown
table

maruku
table

cebe
table

pandoc
table

multimarkdown
table

hard line breaks are not allowed at the end of table header lines
Hard line breaks are not allowed at the end of table header lines. It's about a 50:50 split on babelmark, but this change makes pulldown-cmark consistent with GFM and Pandoc.

Implementation     ->
parsed as

pulldown-cmark
paragraph

github/cmark-gfm
paragraph

pycmarkgfm
paragraph

markdown-it
table

php-markdown-extra
table

DFM
table

league/commonmark GFM
paragraph

s9e/TextFormatter
table

markdig
paragraph

MD4C
paragraph

parsedown
table

maruku
table

cebe
paragraph

pandoc
paragraph

multimarkdown
table

Thanks!, I will try to review it this week.

It looks fine, thanks!


Rename FastHotStuffEventLoop Recevier to fe

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#1312  👈
#1311
feature/proof-of-stake

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @tholonious and the rest of your teammates on  Graphite

Merge activity

May 14, 5:33 PM EDT: @tholonious started a stack merge that includes this pull request via Graphite.


Create itisavogadro.txt

Is this a secondary school or a post-secondary school?

This is mainly a secondary school,
but are teached post-secondary courses
and evening classes for worker students too.
Now we teach using netbeans (easier than Eclipse) but recently we began to try IntellijIdea
and we realized that it’s easier to learn, and more fast and powerful, so we would like to migrate to it
as soon as we can have the free education licence
This is our school web site   http://www.itisavogadro.it/ http://www.itisavogadro.it/
thanks in advance
Lorenzo Nazario

Il giorno 27/mar/2015, alle ore 01:17, Lyzi Diamond<EMAIL_ADDRESS>ha scritto:
Is this a secondary school or a post-secondary school?
—
Reply to this email directly or view it on GitHub https://github.com/leereilly/swot/pull/558#issuecomment-86767586.


Update version docs

Make it clear that you should not attempt to get the version before the
first handshake is complete.
Fixes #2893

Checklist

[ ] documentation is added or updated
[ ] tests are added or updated

@kroeckx are you ok with this now?

Feel free to merge this.

@levitte please can you reconfirm this (as well as #6014 and #6015)?

Pushed. Thanks.


Update SetTitleBar documentation to point out issue with grid

When a grid has its background unset, it does not take part in hit testing. That's why you need to set the background, however that is not trivial. That's why we should point that out.
See this issue for more context:
https://github.com/microsoft/microsoft-ui-xaml/issues/1004

@chingucoding : Thanks for your contribution! The author(s) have been notified to review your proposed change.


[Bug] KVM input not recognized by win-vind on remote machine

About Bug

The software does not recognize network inputs from KVM client software.
Steps to reproduce

I'm presently using InputDirector to manage a two computer setup
win-vind works correctly on remote computer with hardware keyboard, but KVM keyboard inputs from InputDirector are ignored.

Interestingly, if win-vind is in a blocking mode on the remote system], it will still block the KVM input
Environments

Environments

Windows Edition
10 Home

64 bit

most recent build

@qaptoR
I'm not very familiar with that virtual machine, but maybe the InputDirector uses SendInput to create keycode messages. The win-vind has only keycode capture but also the emulation of input with external macros. And then, to avoid receiving own created messages and falling into the infinite dead lock, win-vind ignore injection with SendInput at here.
Therefore, every program to create key messages except for the physical keyboard driver, probably will not work well.
Thanks for using it.

@pit-ray
Thank you for letting me know.
I really like your software, I'm still trying to work it into my day-to-day routine.
I'll look into seeing what kind of messaging InputDirector uses, maybe I can create a patch?
Most likely would depend on whether or not we could detect where the input is coming from, and then maybe create a white-list for programs.
On a somewhat unrelated note, does the 'EasyClick' feature rely on .NET UI Automation library?
I noticed that applications which run their GUI with electron don't work with 'EasyClick'.
Also, neither does the Godot game engine, but that's for an entirely different reason (they use their own GUI library).
So I want to figure out how to hook into Electron, and what to expose in godot that will enable win-vind to hook in to that as well. (I develop games with VSCode, which uses electron, and Godot)

Thank you!
my apologies. Yes, I have now gotten easyclick to work with vscode and microsoft edge.
as I'm trying to consider, from a purely mathematically logic pov how to handle KVM emulated input over a network, is it possible to create a 'mode' for win-vind that does not allow it to use external macros, and which also exposes it to emulated input.
this could be called something like "network limited device" mode, assuming that win-vind is being used as on a controlled network computer.

@qaptoR
Thanks for your many contributions. I'll reply all little by little since I'm busy this month.
About "network limited device" mode, we must detect the key message where come from.
If we enable the mode manually like set vmmode (virtual machine mode) and ignore all SendInput API of win-vind, we cannot use shortcut macros (e.g., Vim emulation mode uses <left> key or <right> key). In other words, the infinite loop problem for SendInput is not only external macros but also all key message generation functions.
Therefore, we must detect the type of application inside LowLevelKeyboardProc.
Win32API: https://learn.microsoft.com/en-us/windows/win32/winmsg/lowlevelkeyboardproc
win-vind implementation: https://github.com/pit-ray/win-vind/blob/master/src/core/inputgate.cpp#L137-L182
Thanks.

@pit-ray
Thankyou for the links! I will look into them as I have time as well.


Optimize sign extension via shifts

This commit adds egraph optimization patterns for left-shifting a value and then right-shifting it as a form of sign extending its lower bits. This matches the behavior of the WebAssembly i32.extend8_s instruction, for example. Note that the lowering of that WebAssembly instruction does not use shifts, but historical versions of LLVM that didn't support the instruction, or versions with the instruction disabled, will use shifts instead.
A second rule for reduction-of-extend being the same as the original value was added to keep an existing shift-related test passing as well.

Indeed! This is inspired by LLVM's alternate lowerings for casts in Rust which produce different sequences of wasm instructions. Piping these through Cranelift the old shift-based lowering generates two shifts while the "new" i32.extend8_s generates a single movsx instruction. Given that ireduce is typically a noop with respect to backends I figured it'd be good to get this two-instruction folding into a single-instruction folding. Additionally I figured that the purpose of adding i32.extend8_s was to be a bit more optimal/compact and we may as well try to represent both of these equivalently in the IR.
I'll add some tests though to the backend for the codegen too!


difference between tf hub and native tf code for efficientnet

I originally was using the efficientnet B0 module (https://tfhub.dev/google/efficientnet/b0/feature-vector/1) in TF1.15.2 (nvcr.io/nvidia/tensorflow:20.03-tf1-py3 ). At some point I wanted to do an experiment where I needed access to certain hidden layers, and decided to swap the tf.hub module with the native tf code. Based on the documentation, I found that training of the hub module is supposed to be done using the official efficientnet repo (https://github.com/tensorflow/tpu/tree/master/models/official/efficientnet) with auto-augment preprocessing (so I assume with the following checkpoint: https://storage.googleapis.com/cloud-tpu-checkpoints/efficientnet/ckptsaug/efficientnet-b0.tar.gz) However when I try to train this new implementation I receive NaN errors during training, which I never received in the tf hub implementation. Btw his observation is not based on a single run.
I know I can solve this by lowering the learning rate, but I don't understand why I would need to adjust my hyperparameters as I expect both implementations to execute the same network. Is this a bug or is their a logical explanation to this different behavior?
The code snippet for the native TF code:
model_builder = model_builder_factory.get_model_builder("efficientnet-b0")
net, _ = model_builder.build_model(
    input_tensor,
    model_name="efficientnet-b0",
    training=mode == tf.estimator.ModeKeys.TRAIN,
    model_dir="/scratch/checkpoints/efficientnet-b0-aa/efficientnet-b0")
net = tf.expand_dims(net, 1)
net = tf.expand_dims(net, 1)
with tf.variable_scope('classification_head'):
    drop = tf.layers.dropout(
        net, rate=self.configuration.get("dropout"),
        seed=self.configuration.get("random_seed"),
        training=mode == tf.estimator.ModeKeys.TRAIN
    )
logits_classification = tf.layers.conv2d(drop,9, 1, activation=None, name='fc_logits')
logits_classification = tf.squeeze(logits_classification, [1, 2], name='SpatialSqueeze')
…

Where warm variables in the estimator are defined using ".efficientnet-b." and all trainable variable either contain “classification_head” or “efficientnet”
De code snippet voor de tf hub versie:
if mode == tf.estimator.ModeKeys.TRAIN:
    tags_ = {"train"}
else:
    tags_ = {}
module = hub.Module("https://tfhub.dev/google/efficientnet/b0/feature-vector/1", trainable=True, tags=tags_)
net = module(input_tensor)
with tf.variable_scope('classification_head'):
    drop = tf.layers.dropout(
        net, rate=self.configuration.get("dropout"),
        seed=self.configuration.get("random_seed"),
        training=mode == tf.estimator.ModeKeys.TRAIN
     )
logits_classification = tf.layers.conv2d(drop,9, 1, activation=None, name='fc_logits')
logits_classification = tf.squeeze(logits_classification, [1, 2], name='SpatialSqueeze')
…

With warm variables in the estimator are defined using ".*" and all trainable variables either contain “classification_head” or “efficientnet”
Thanks for looking into this.
Kr
Jonas

Hello @jdvylder, thank you for reaching out. Both the TF Hub and native code should provide similar results. One thing to note is that the TF Hub version expects inputs in the range from [0,1], following Hub's common image input conventions. However, the native code expects image values in the range [0, 255].
Can you confirm if that resolves your issue?

Closing due to lack of response. Please reopen if further discussion is required.


etcd daemon: creates member directory if cluster config is not valid

$ etcd2 --version
etcd Version: 2.2.1
Git SHA: 75f8282
Go Version: go1.5.1
Go OS/Arch: linux/amd64

Let's simulate situation when we bootstrap 4 etcd members but with size=3 discovery token. First three members bootstrap without any issue. But last one does. It creates /var/lib/etcd2/member even when it can not be started (for example DNS record is still not updated). Here is the gist:
$ rm -rf /var/lib/etcd2/member/
$ ls -la /var/lib/etcd2/
total 16
drwxr-xr-x  2 etcd etcd 4096 Nov  6 16:09 .
drwxr-xr-x 21 root root 4096 Nov  6 15:58 ..
$ export ETCD_ADVERTISE_CLIENT_URLS=http://coreos4:2379
$ export ETCD_DATA_DIR=/var/lib/etcd2
$ export ETCD_DISCOVERY=https://discovery.etcd.io/d21a838dd608ab1831a9d84cdea2f7d1
$ export ETCD_INITIAL_ADVERTISE_PEER_URLS=http://coreos4:2380
$ export ETCD_LISTEN_CLIENT_URLS=http://<IP_ADDRESS>:2379,http://<IP_ADDRESS>:4001
$ export ETCD_LISTEN_PEER_URLS=http://<IP_ADDRESS>:2380
$ export ETCD_NAME=2769da4ab46d3b310a3fcc6b06fa9b6e
$ etcd2
2015-11-06 16:04:22.871587 I | flags: recognized and used environment variable ETCD_ADVERTISE_CLIENT_URLS=http://coreos4:2379
2015-11-06 16:04:22.871773 I | flags: recognized and used environment variable ETCD_DATA_DIR=/var/lib/etcd2
2015-11-06 16:04:22.871924 I | flags: recognized and used environment variable ETCD_DISCOVERY=https://discovery.etcd.io/d21a838dd608ab1831a9d84cdea2f7d1
2015-11-06 16:04:22.872065 I | flags: recognized and used environment variable ETCD_INITIAL_ADVERTISE_PEER_URLS=http://coreos4:2380
2015-11-06 16:04:22.872207 I | flags: recognized and used environment variable ETCD_LISTEN_CLIENT_URLS=http://<IP_ADDRESS>:2379,http://<IP_ADDRESS>:4001
2015-11-06 16:04:22.872330 I | flags: recognized and used environment variable ETCD_LISTEN_PEER_URLS=http://<IP_ADDRESS>:2380
2015-11-06 16:04:22.872498 I | flags: recognized and used environment variable ETCD_NAME=2769da4ab46d3b310a3fcc6b06fa9b6e
2015-11-06 16:04:22.872781 I | etcdmain: etcd Version: 2.2.1
2015-11-06 16:04:22.872889 I | etcdmain: Git SHA: 75f8282
2015-11-06 16:04:22.873031 I | etcdmain: Go Version: go1.5.1
2015-11-06 16:04:22.873138 I | etcdmain: Go OS/Arch: linux/amd64
2015-11-06 16:04:22.873254 I | etcdmain: setting maximum number of CPUs to 1, total number of available CPUs is 1
2015-11-06 16:04:22.873509 I | etcdmain: listening for peers on http://<IP_ADDRESS>:2380
2015-11-06 16:04:22.873663 I | etcdmain: listening for client requests on http://<IP_ADDRESS>:2379
2015-11-06 16:04:22.873826 I | etcdmain: listening for client requests on http://<IP_ADDRESS>:4001
2015-11-06 16:04:23.070391 E | netutil: could not resolve host coreos4:2380
2015-11-06 16:04:23.070751 I | etcdmain: stopping listening for client requests on http://<IP_ADDRESS>:4001
2015-11-06 16:04:23.071103 I | etcdmain: stopping listening for client requests on http://<IP_ADDRESS>:2379
2015-11-06 16:04:23.071343 I | etcdmain: stopping listening for peers on http://<IP_ADDRESS>:2380
2015-11-06 16:04:23.071562 I | etcdmain: --initial-cluster must include 2769da4ab46d3b310a3fcc6b06fa9b6e=http://coreos4:2380 given --initial-advertise-peer-urls=http://coreos4:2380
2015-11-06 16:04:23.071747 I | etcdmain: forgot to set --initial-cluster flag?

We can see that /var/lib/etcd2/member/ was created and it is empty:
$ ls -la /var/lib/etcd2
total 24
drwxr-xr-x  3 etcd etcd 4096 Nov  6 16:12 .
drwxr-xr-x 21 root root 4096 Nov  6 15:58 ..
drwx------  2 root root 4096 Nov  6 16:12 member

And etcd2 daemon can not switch to proxy mode automatically even when DNS record is already valid:
etcd2
2015-11-06 16:14:48.232621 I | flags: recognized and used environment variable ETCD_ADVERTISE_CLIENT_URLS=http://coreos4:2379
2015-11-06 16:14:48.233075 I | flags: recognized and used environment variable ETCD_DATA_DIR=/var/lib/etcd2
2015-11-06 16:14:48.233270 I | flags: recognized and used environment variable ETCD_DISCOVERY=https://discovery.etcd.io/d21a838dd608ab1831a9d84cdea2f7d1
2015-11-06 16:14:48.233583 I | flags: recognized and used environment variable ETCD_INITIAL_ADVERTISE_PEER_URLS=http://coreos4:2380
2015-11-06 16:14:48.233794 I | flags: recognized and used environment variable ETCD_LISTEN_CLIENT_URLS=http://<IP_ADDRESS>:2379,http://<IP_ADDRESS>:4001
2015-11-06 16:14:48.234095 I | flags: recognized and used environment variable ETCD_LISTEN_PEER_URLS=http://<IP_ADDRESS>:2380
2015-11-06 16:14:48.234286 I | flags: recognized and used environment variable ETCD_NAME=2769da4ab46d3b310a3fcc6b06fa9b6e
2015-11-06 16:14:48.234720 I | etcdmain: etcd Version: 2.2.1
2015-11-06 16:14:48.234896 I | etcdmain: Git SHA: 75f8282
2015-11-06 16:14:48.235032 I | etcdmain: Go Version: go1.5.1
2015-11-06 16:14:48.235231 I | etcdmain: Go OS/Arch: linux/amd64
2015-11-06 16:14:48.235496 I | etcdmain: setting maximum number of CPUs to 1, total number of available CPUs is 1
2015-11-06 16:14:48.235772 N | etcdmain: the server is already initialized as member before, starting as etcd member...
2015-11-06 16:14:48.236047 I | etcdmain: listening for peers on http://<IP_ADDRESS>:2380
2015-11-06 16:14:48.236300 I | etcdmain: listening for client requests on http://<IP_ADDRESS>:2379
2015-11-06 16:14:48.236576 I | etcdmain: listening for client requests on http://<IP_ADDRESS>:4001
2015-11-06 16:14:48.238058 I | netutil: resolving coreos4:2380 to <IP_ADDRESS>:2380
2015-11-06 16:14:48.238692 I | netutil: resolving coreos4:2380 to <IP_ADDRESS>:2380
2015-11-06 16:14:49.250359 I | etcdmain: stopping listening for client requests on http://<IP_ADDRESS>:4001
2015-11-06 16:14:49.250660 I | etcdmain: stopping listening for client requests on http://<IP_ADDRESS>:2379
2015-11-06 16:14:49.251300 I | etcdmain: stopping listening for peers on http://<IP_ADDRESS>:2380
2015-11-06 16:14:49.251593 C | etcdmain: discovery: cluster is full

and in addition, even when etcd2 runs as proxy - it still creates /var/lib/etcd2/member directory. and if you restart it will fail with the following message:
invalid datadir. Both member and proxy directories exist.

partly relates to #3713

+1 I'm seeing the same problem - although my extra member fall back to proxy as expected initially, on any subsequent restart I get this error

Thanks for reporting. I will investigate and try to resolve this.

+1, all proxies failed to start after reboot. Running CoreOS 845.
Nov 22 08:53:40 sigma etcd2[822]: etcd Version: 2.2.1
Nov 22 08:53:40 sigma etcd2[822]: Git SHA: 75f8282
Nov 22 08:53:40 sigma etcd2[822]: Go Version: go1.5.1
Nov 22 08:53:40 sigma etcd2[822]: Go OS/Arch: linux/amd64
Nov 22 08:53:40 sigma etcd2[822]: setting maximum number of CPUs to 2, total number of available
Nov 22 08:53:40 sigma etcd2[822]: invalid datadir. Both member and proxy directories exist.
Nov 22 08:53:40 sigma systemd[1]: etcd2.service: Main process exited, code=exited, status=1/FAILURE
Nov 22 08:53:40 sigma systemd[1]: Failed to start etcd2.
Nov 22 08:53:40 sigma systemd[1]: etcd2.service: Unit entered failed state.
Nov 22 08:53:40 sigma systemd[1]: etcd2.service: Failed with result 'exit-code'.

@xcompass I got the service to startup after removing only the directory with nothing in it (based on your etcd settings).
Removing both directories for some reason breaks it on the second startup/reboot.
Not sure why both are being created...

@gyuho could a possible solution to the problem be to change https://github.com/coreos/etcd/blob/master/etcdmain/etcd.go#L488 to check for the file in the cfg dir instead of the directory itself?

@nikfoundas Sorry for being slack on this issue. I will look into it and give you updates on that.

@nikkomiu I found a workaround by setting proxy=1 to force node to running in proxy mode. It will never create the member directory. Then there is no problem after rebooting.

My first approach can be found here https://github.com/coreos/etcd/pull/3949 in order to overwrite proxy setting by deleting member directory. If anybody has feedback, please let me know!

With CoreOS a simple workaround is to create a drop-in in the cloud-config for etcd2.service which deletes the empty member directory before etc2 start up:
- name: etcd2.service
  command: start
  drop-ins:
    - name: 50-cleanup-data.conf
      content: |
        [Service]
        ExecStartPre=-/usr/bin/rmdir /var/lib/etcd2/member

Afterwards etcd2 servers and proxies start as expected.

@geku Cool! And thanks for posting here.

FYI. I am working to improve our discover function to not write any conflicting directories unless the whole operation succeeds. Will keep you updated on this issue.

I believe https://github.com/coreos/etcd/pull/4087 fixes this issue, which removes member directory when bootstrap fails. Closing this. Please let us know if you still have the same issue.


Bugfix/um 801 hip gitlab ci error (+UM-800-windows-ci-error)

[x] Need the radiusssss PR to go through (scripts are updated there too)

(NOTE: Needed to combine this with the windows error ticket so that they can both pass all the tests when fixed. JIRA ticket will be updated.)

LGTM

LGTM

LGTM

LGTM

LGTM

LGTM


Schema type is missing for the inline schema

Swagger 2.0.1-SNAPSHOT
Parser does not specify schema type for the inline schema
Specification:
 openapi: 3.0.0
 info:
  version: 1.0.0
  title: Swagger Petstore
  license:
    name: MIT
paths:
  /pets:
    get:
      summary: List all pets
      operationId: listPets
      tags:
        - pets
      parameters:
        - name: limit
          in: query
          description: How many items to return at one time (max 100)
          required: false
          schema:
            type: integer
            format: int32
      responses:
        '200':
          description: An paged array of pets
          headers:
            x-next:
              description: A link to the next page of responses
              schema:
                type: string
          content:
            application/json:
              schema:
                 type: object
                 properties:
                    id:
                      type: integer
                      format: int64
                    name:
                      type: string
                    tag:
                      type: string

In InlineModelResolver.java, modelFromProperty(), there is no type being set for the model.
 Schema model = new Schema();//TODO Verify this!
model.setDescription(description);
model.setExample(example);
model.setName(name);
model.setXml(xml);

Could you look into it please?

Added PR which might solve the issue. Could you check please?

@wimjongman, yes, you are right.
From the OAS sample (1st post), it shows as class Schema only.

Hi, @ipsujinuy, I created a PR, using you commit, please check if this solves the issue. branch: fix-issue-705-OAS3

Hi @gracekarina,
Thank you for the commit. I have checked that it solved the issue.

@ipsujinuy I just merged!, please let us know if this keep happening.
Thank you!

@gracekarina, thank you!


Fix for socket reusing

Coverage increased (+0.02%) to 98.369% when pulling 72d8e59d764b63604f1f714eb364a7b7f5039140 on fix-for-socket-reusing into 84f3985eb922ece662a77c89df54ab63f97534f3 on master.

Coverage increased (+0.02%) to 98.369% when pulling 72d8e59d764b63604f1f714eb364a7b7f5039140 on fix-for-socket-reusing into 84f3985eb922ece662a77c89df54ab63f97534f3 on master.

Coverage increased (+0.02%) to 98.369% when pulling 72d8e59d764b63604f1f714eb364a7b7f5039140 on fix-for-socket-reusing into 84f3985eb922ece662a77c89df54ab63f97534f3 on master.


Disabling Typescript validation also misses Javascript validation

VSCode Version: 1.32.3 (1.32.3)
OS Version: MacOS 10.14.3

Steps to Reproduce:
I have a project on which I'm using flow. When I write type definitions on my files I get the 'type aliases' can only be used in a .ts file. (ts8008) validation.
I would expect that validation goes away if I uncheck typescript.validate.enabled on the settings, however it only goes away if I uncheck javascript.validate.enabled, which in turn makes me lose some very useful validations, for example declaration of variables that are never used, etc.
Expected behavior would be to either:

make ts8008 enable/disable based on typescript.validate.enabled OR
have a specific setting to enable/disable ts8008 (so I could uncheck that but still have javascript.validate.enabled)

VS Code does not ship with built-in Flow support. To get proper flow support, install the flow extension and follow these instructions

@mjbvz my problem is not with flow support, I installed the plugins and that is working fine. My problem is I need to disable the Typescript validation (because it would complain about the flow syntax) but I'd like to keep the validation on unused variables and other validations that coming from the javascript validation, which are very useful.
In other words, my request is why ts8008 depends on the javascript.enabled setting when IMHO it clearly should depend on the typescript.enabled setting. Even the prefix of the rule is ts :P.
I think there are clear use cases (like mine, or every other person using flow instead of typescript, but may be others not necessarily using flow and needing the same thing) on which you want to disable ts8008 together with the other typescript validations but you DO want to keep all the actual javascript (not typescript related) validations. It just seems ts8008 is on the wrong bucket here.

Happening to me too. Please, fix this.


chore(changeset): remove edge-config changeset

As it's not ready to ship, let's remove it

@luismeyer this will allow you to release 👍


Create how-to contribute docs

A guide for making contributions might make junior devs new to collaborative development (like myself : ) ) more likely to participate.

We were talking about this very thing in Slack last night. We'll work on it. :)


Dockerfile with Python 3, Jupyter and R-studio

I have created the pull request here regarding my Dockerfile.

Closed pull request as this is not the right branch (this is the main branch).


Runtime debug log (getenv way )

Added getenv() call in debug macro.
Checks only existence of variable.
Start with admin to use.
Add set DEBUG_GDPI=

Can cause some performance decrease due to the getenv call. Not much, but testing on huge loads is necessary.

No-no, that isn't great.
Please make a pointer to a debug print function, and a macros which checks whether the pointer is NULL and calls the function.
The arguments parser then sets the function pointer to a debug print function if this option is enabled (or if environment variable is set, etc).

Do we really need environment variable? This seems less convenient, given that none other options are set with envs.

Do we really need environment variable? This seems less convenient, given that none other options are set with envs.

I know, this is one of the options that I was able to test quickly. It's more complicated with the cmd argument, but  it needs to be passed on, and I don't really want to create a global variable for this (even as func pointer). I'll look at other ways. It would be better to cancel the pull request then.


Storyboard flow large file cannot open on android studio

Example:

/Users/Samuel/AndroidStudioProjects/tolotra_mg/lib/admin/pages/storyboard/storyboard_flows/annotation_flow.dart

Solved


Sound can be listened only for first time for user

I've tested MumbleClient app with local Murmur server and Plumble client on my smartphone.
Each time I've started speaking via Plumble I had new sequence of voice packages that started from 0 sequence number.
Because of this check
https://github.com/martindevans/MumbleSharp/blob/f145fed118c2327089f2b3ff4a03fea69440f458/MumbleSharp/Audio/AudioDecodingBuffer.cs#L68
I able to hear voice via MumbleClient only from first transmission. Or then new transmission is longer than previous

fixed in PR #47 by resetting the _nextSequenceToDecode  when sequence == 0

Hi @buldo ,
Can you please report if our fix did effectively solve your issue with Plumble client. Thanks.

Unfortunately I can not because I use heavily modified version of this library in my project.


UpdateCLI runs every 30 min, regular apply/lint happens on all branches

Unless your watching the CI jobs, its pretty hard to see when something was changed (for example chatbot).
Split the updatecli job and the helmfile job so one is cron based, one is commit based.
Could setup helmfile to pin chart versions and get updatecli to bump the chart version.

 I'll totally clean this up tomorrow

Unless your watching the CI jobs, its pretty hard to see when something was changed (for example chatbot).
I definitely agree with you even though I didn't find a good approach to solve this with helmfile

IMHO the Helmfile apply should be run on a regular basis to ensure that any manual configuration change is reverted.
I agree that it's hard to catch when something changed but I don't think running Helmfile from a different job will help.
I don't think a Jenkins job could detect if Helmfile apply changes or not because the command doesn't return a different RC in c are of a change.
I have been wondering if it's not something that change be detected by prometheus by watching helm release changes.

IMHO the Helmfile apply should be run on a regular basis to ensure that any manual configuration change is reverted.

Maybe less often? Like once a day?
I'm going to check Loki tomorrow, was just trying to figure out why chatbot wasn't deploying

Ok then let split the two and run updatecli every 15min and helmfile once a day
Ideally, I would like to get something similar to puppet notifications` in IRC like
00:33 < infra-butler> Puppet production run for bounce changed at Fri Dec  4 00:32:59 2020.

So IRC notifications for helmfile? Is that available on infra.ci?
I'll get the changes cleaned up asap

So IRC notifications for helmfile? Is that available on infra.ci?
I'll get the changes cleaned up asap

The closest solution that I could think of would be to use helmfile hooks base on prepare event
https://github.com/roboll/helmfile#hooks

Now updatecli is only executed when the job is triggered with a cronjob as defined here by @dduportal
So I am closing this PR

MMmh the "conditional execution when triggered by a cron" had been a first step towards error-less helmfile apply.
But it feels like that this PR, which object is to split the updatecli and helm in 2 separated pipelines, should be the next step.
What do you think about having a pipeline library for this? E.g. defining an updateCli process (input parameter: frequency, and a collection of branches) for this repository. it would simplify a lot of our pipeline and would provide a kind of "dependanbot" for us.


[Bug] :noh causes: E5500: autocmd has thrown an exception: Vim(lua):E5108: Error executing lua ...r/start/nvim-scrollbar/lua/scrollbar/handlers/search.lua:35: attempt to call upvalue 'render' (a nil value)

Describe the bug
Run :noh will cause an error:
E5500: autocmd has thrown an exception: Vim(lua):E5108: Error executing lua ...r/start/nvim-scrollbar/lua/scrollbar/handlers/search.lua:35: attempt to call upvalue 'render' (a nil value)^@stack <EMAIL_ADDRESS>ndlers/search.lua:35: in function 'hide'^@^I...r/start/nvim-scrollbar/lua/scrollbar/handlers/search.lua:43: in function 'hide_all'^@^I...r/start/nvim-scrollbar/lua/scrollbar/handlers/search.lua:67: in function 'nohlsearch'^@^I[string ":lua"]:1: in ma
in chunk

To Reproduce
Steps to reproduce the behavior:

Type / to highlight some word in your current document.
Run :noh

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Version Info (please complete the following information):
NVIM v0.9.0-dev-459+gad244a865
Build type: Release

Additional context
I guess a377bb6 might be the cause of it.

You did it, love you. Closing.


ProgrammingError at / relation "threadedcomments_comment" does not exist

context[self.as_varname] = self.get_context_value_from_queryset(context, qs)

context: [{'True': True, 'False': False, 'None': None}, {}, {}, {'paginator': None, 'page_obj': None, 'is_paginated': False, 'object_list': <QuerySet [<Set: Wed, 24 Apr 2019>, <Set: Wed, 24 Apr 2019>, <Set: Tue, 23 Apr 2019>, <Set: Mon, 22 Apr 2019>]>, 'set_list': <QuerySet [<Set: Wed, 24 Apr 2019>, <Set: Wed, 24 Apr 2019>, <Set: Tue, 23 Apr 2019>, <Set: Mon, 22 Apr 2019>]>, 'view': <curate.views.SetListView object at 0x000001D4CA9EB518>}]

qs Error in formatting: ProgrammingError: relation "threadedcomments_comment" does not exist
LINE 1: ...user"."is_active", "auth_user"."date_joined" FROM "threadedc...

self <django_comments.templatetags.comments.CommentCountNode object at 0x000001D4CA9F22E8>

I actually have it working now. But I don't quite know how it renders - the output on the template is not actually threaded. All comments appear to be in the original UL, no matter if it was a reply to a reply... I've used the HTML in your template here:
https://github.com/HonzaKral/django-threadedcomments/blob/master/examples/core/templates/core/message_inline_sample.html


Add tox support

Add tox.ini file to run tests on python 3.7, 3.8, 3.9, 3.10

Hi @harelwa - this PR was targeted to the development environment rather than the CI/CD environment.  I am mostly interested in being able to type "tox" on the command line and have it do all of the things.   The CI/CD problem is much larger, as you have seen, and is complicated by pipenv.  My personal opinion is that pipenv is fine for applications that only need to support one python version but it doesn't work well with libraries that need to support many versions.

hi @bobh66
Thanks for replying.
In #93 I've added the run of tox to the CI flow as well, and it's running successfully on all python versions. please see https://github.com/argoproj-labs/hera-workflows/pull/93/commits/895c4bc6c98d00cbfa78b96a0296775f586e998e
As for pipenv -
I think it's partly off topic as far as tox is considered. Or at least can be, for now.
In #93 I've tritted pipenv as what takes care of installing tox and nothing more. Hence not using pipenv in tox.ini. and the addition to dev-packages
Thus you get to run tox and have do all the things for you locally regardless of pipenv, having tox taking care of dependencies. This is also one of the reasons I avoided using pipenv in tox.ini in #93
Can please address the essential differences between tox.ini in #93 than the one proposed here ? [ choosing to use pipenv in tox.ini etc. ]

@bobh66
As for the your observation regarding the difference between py apps supporting a single version, as opposed to py libs supporting multiple versions I tend do agree.
As for alternatives, I don't know if poetry provides a good alternative with the required elasticity for our use case. Nevertheless, I made the necessary pipenv changes as it's currently hera's project choice.
On a different note, I see the recommended way of using tox + pipenv in pipenv docs is similar to what you proposed -
https://pipenv.pypa.io/en/latest/advanced/#tox-automation-project
I must say I'm a bit confused -
The motivation is of not having to manage test deps in two places is clear and agreeable.
However, If your dev env is to be managed with pipenv, then tox needs to be listed as a dev-package. following their docs, doing --
commands=
    pipenv install --dev

will install tox in a venv created by tox. which is just a bit strange to me :\

Hi @harelwa
I don't have a lot of experience with poetry, we came across it once when building dependencies for another project and found that it created a number of issues, so we have tried to stay away from it.  I would need to do more research to understand it better.
I think the general expectation for tox is that you don't install it as a dependency of the project, rather it is installed in your base python environment (like pip), so it is common to all projects and is just always there.  Otherwise you run into the chicken-egg problem of needing tox to install tox.

tox was introduced in #93 so closing this one for now! Thank you for the efforts and the discussions @bobh66 🙂


Multilingual -> Page Report - MySQL error

Trying to get Page Report but I am getting MySQL error:

An exception occurred while executing 'SELECT p.cID, (SELECT mpRelationID FROM MultilingualPageRelations mppr WHERE cID = p.cID LIMIT 1) as mpr, (SELECT count(mpRelationID) FROM MultilingualPageRelations mppr WHERE (mpRelationID = mpr) AND (mpLocale = ?)) as relationCount1, (SELECT count(mpRelationID) FROM MultilingualPageRelations mppr WHERE (mpRelationID = mpr) AND (mpLocale = ?)) as relationCount469 FROM Pages p LEFT JOIN PagePaths pp ON (p.cID = pp.cID and pp.ppIsCanonical = true) LEFT JOIN PageSearchIndex psi ON p.cID = psi.cID LEFT JOIN PageTypes pt ON p.ptID = pt.ptID INNER JOIN Collections c ON p.cID = c.cID INNER JOIN CollectionVersions cv ON p.cID = cv.cID LEFT JOIN CollectionSearchIndexAttributes csi ON c.cID = csi.cID WHERE (p.cPointerID < 1) AND (p.cIsTemplate = 0) AND (cvIsApproved = 1) AND (p.cIsActive = ?) AND (p.cIsSystemPage = ?)  AND (pp.ppIsCanonical = 1) AND (p.cPointerID < 1) AND (p.cIsTemplate = 0) AND (cvIsApproved = 1) AND (p.cIsActive = ?) AND (p.cIsSystemPage = ?) HAVING relationCount190 = 0 LIMIT 1000' with params ["fr_FR", "en_GB", "/fr/%", true, false]: SQLSTATE[42S22]: Column not found: 1054 Unknown column 'mpr' in 'where clause'

This problem occurs when MySQL runs with the ONLY_FULL_GROUP_BY flag turned on (same problem as https://github.com/concrete5/concrete5/pull/4168  )

@aembler Are you going to fix the affected query?

I assumed this was fixed in your previous pull request.

This problem occurs when MySQL runs with the ONLY_FULL_GROUP_BY flag turned on

Not true, this error manifests on my configuration even without ONLY_FULL_GROUP_BY sql mode. My sql mode flags on my mySQL 5.7.9 instance are NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER

@ket4z Could you try if https://github.com/concrete5/concrete5/pull/4260 fixes the problem for you?

@mlocati: Yes, that does the trick, Page Report now renders just fine

Nice! Thanks for checking!!
If you see any problem please let me know: it's quite a complex query and I'm almost sure it's correct :wink:


Add midenVM verifier

MidenVM verifier implementation with an example.
Proof can be verified like this:
target/debug/midenvm-verifier 78d31702eb946e1817e3c0881fcb3739562f08fbddf202de2eae241b9968ab3b ./midenvm-verifier/example/fib.proof ./midenvm-verifier/example/fib.inputs ./midenvm-verifier/example/fib.outputs
My question is what should I return for HyleOutput<()>, are there any docs related to this? And is there anything that I missed?

ready for a review @wraitii

@wraitii @maximilien-hyle I've added some instructions to README.md file. In order to generate necessary files (and a program hash) for the proof, user needs to install https://github.com/0xPolygonMiden/miden-vm (meaning they need rust and whole setup etc. - should be trivial) and follow their instructions from here: https://0xpolygonmiden.github.io/miden-vm/intro/usage.html#running-miden-vm so I've just put the link to official miden-vm tutorial.
I still didn't remove the example folder since this can't be generated from inside this repo, so I left it so somebody can run the example, lmk if you still want it removed.
Regarding HyleOutput object, it needs all fields populated (I can't just pass stack_outputs to next_state and that's it). So I'm still not sure what to put for other fields (maybe I'm still missing something).

Regarding HyleOutput object, it needs all fields populated (I can't just pass stack_outputs to next_state and that's it). So I'm still not sure what to put for other fields (maybe I'm still missing something).

You could actually, but we'll probably need to change them at a later point anyways. I think as far as we're concerned the PR is relatively good to go, but I'll do another pass with @maximilien-hyle

@maximilien-hyle  @wraitii Thank you! Let me know about the follow-up task too. By the way, how can I contact you on telegram? This is my nick: @djaganche


Add support for Az module and update README.md

I updated following:

Add support for Az module and update README.md

If you want to maintain support AzureRM module, please decline this pull request.

Hi @tsubasaxZZZ, I'm sorry for overlooked your pull request. I'm will run your code in my environment then merge it. Wait a moment.


 I tried to revise it to actually work - but hopefully someone checks this work.

S2 is down of course


Add a dark theme and toggle to switch between themes

About
The page is completely in light theme right now, add a toggle at the top right corner of the home page to switch to dark theme.
You will also need to make the required CSS changes for the dark theme. You can use Tailwind CSS. Extra points for adding Tailwind CSS.
Bounty 70-80

Hey @bun137, can you assign me this issue

hey, really sorry, but this issue is to be solved for an internal hacktoberfest event

hey, can i be assigned to this?

yepp assigned

can i get assigned?

can I get assigned??plssss

@akdino , sorry, its first come first serve basis, @mokshablr is already assigned

@mokshablr , please open a draft pr, its almost 30 mins since assignment

opened one rn @bun137

@mokshablr , great work, couple things pending to do:

once the dark theme button is clicked on the entire website needs to set to dark theme, right now on going to another page, user needs to manually set to dark them
please make the button to suit the minimal theme

@mokshablr updates? its been over 30 mins

i made the button
will work on keeping the theme choice throughout all the pages now

@mokshablr please commit your latest changes!

I'll commit in a bit... Came out to eat

Cool cool

I made a svelte component and js implementation for toggling the dark mode globally but I havent figured out how to add it to the main html. I can spend more time on this if you'll let me.

can i get assigned if this is still open?

@mokshablr you can work on this issue!

@mokshablr any updates? the global js file working?

can i get assigned?

@ssether04 sorry this issue has been assigned and the contributor is showing constant progress

okay lmk

@bun137 was listening to the performances... Thought this was a break?

@mokshablr nps, but could you show me your progress on this issue in the next 30 mins?

can i get it?

can i get it assigned #2

@mokshablr any new updates?

Can i get assigned ?

can this be assigned to me?

@Sidharth-k-2004  you can start working on this issue, do open a draft PR in 30 mins to show your progress


autoSeek does not work with<EMAIL_ADDRESS>(breaking change)

After package.json was updated from "hls.js": "^0.5.45" to "hls.js": "^0.6.7 the video always start at time 00:00:00 regarless #t=02m30s param in the URL.
It took me a while to figure this out. But I tested with several releases until get where the bug was introduced. And the bug in the hls.js starts at v0.6.9 release.
I tested with the lasted 5.x.x version, the v0.5.52 and it's safe to update to it, works fine.

@kafeltz can you test #1254 and check if it fixe your issue ?

@kslimani tested and it does work!

@kslimani well, well safari macos does not work, i forgot to test it.
Since it uses native hls i have no ideia where to report.

That's odd because safari uses html5_video and it has that implemented there

I tested this code with Safari 10.0.2 on MAC OSX at http://cdn.clappr.io/ and it does not seems to work.
var playerElement = document.getElementById("player-wrapper");

var player = new Clappr.Player({
  source: 'http://www.streambox.fr/playlists/x36xhzz/x36xhzz.m3u8?t=20',
  baseUrl: '/latest',
  height: 360,
  width: 640
});

player.attachTo(playerElement);

I never used this feature, can someone confirm that correct syntax is to add ?t=n in URL (where n is integer the number of seconds) ?

@kslimani no, you add t=n in the browser url, not the source url. You can either specify an integer, and in that case it will be interpreted as seconds or in the format of e.g. 2h35m10s.

Thank you @NicholasAsimov !
Then according this part of code, if i go to page http://cdn.clappr.io/?t=20 and open javascript console and type :
Clappr.Utils.seekStringToSeconds(window.location.href)

Does it should print 20 as result ? or do i miss something ? (currently it display 0 for me)

Yep I think this is it :)
https://github.com/clappr/clappr/pull/1254#issuecomment-272616368


Publish script.

@dvdplm yeah that could be nice. Even better if tagging a release would be the only thing we need to do and publishing is done by the CI. Currently I tag manually but will add it here.

@tomusdrw tried this today and it didn't quite work. The error came from derive: it couldn't find ethabi version 8. Checking shows that v8 was indeed published so I suspect there's a delay between publication and update of the registry so derive didn't "see" the new ethabi as published. Perhaps we can just pause 5-10secs after each?
Also, re-running it doesn't work because execution halts at ethabi: "already published"...

@dvdplm your machine is just too fast :P Indeed we can add a delay and maybe cargo clean at start.

lol

see https://github.com/paritytech/ethabi/pull/153/files


Variable in URL

The new variables support is great, however in my case,  using the environment to set a separate authorization header is basically useless, since the URL for our different environments is different.  When I try to put a variable in the URL, it works initially but then ends up getting encoded.
It would really be helpful if the new variable system worked consistently inside the URL and not just in the headers and body, as this would save me from needing to create and maintain duplicate projects.

Or alternately, an feature where we can attach a base URL to an environment along with variables would also work... :-)

Hi,
Thank you for the bug report.
Well, definitely it requires fixing it so the variables will work in the URL panel as well.
Base URL is an actually great idea. I think I'll implement it.
It would work as follows:

if the current environment has {HOST} variable defined then it will apply the host value to the URL automatically if the URL entered in the panel is relative. No need to put ${HOST} into the field.
if the URL editor has absolute URL nothing changes
if the URL has the ${HOST} value it will be replaced as in case 1.

I'll put it into the tasks list.

That would be awesome, and would greatly help out my youth of the this great tool!
Sent from my Verizon, Samsung Galaxy smartphone
-------- Original message --------From: Paweł Psztyć<EMAIL_ADDRESS>Date: 12/13/16  9:35 AM  (GMT-07:00) To: jarrodek/ChromeRestClient<EMAIL_ADDRESS>Cc: the-rockkk<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [jarrodek/ChromeRestClient] Variable in URL (#926)
Hi,
Thank you for the bug report.
Well, definitely it requires fixing it so the variables will work in the URL panel as well.
Base URL is an actually great idea. I think I'll implement it.
It would work as follows:
if the current environment has {HOST} variable defined then it will apply the host value to the URL automatically if the URL entered in the panel is relative. No need to put ${HOST} into the field.
if the URL editor has absolute URL nothing changes
if the URL has the ${HOST} value it will be replaced as in case 1.
I'll put it into the tasks list.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/jarrodek/ChromeRestClient","title":"jarrodek/ChromeRestClient","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/jarrodek/ChromeRestClient"}},"updates":{"snippets":[{"icon":"PERSON","message":"@jarrodek in #926: Hi,\r\n\r\nThank you for the bug report.\r\nWell, definitely it requires fixing it so the variables will work in the URL panel as well.\r\n\r\nBase URL is an actually great idea. I think I'll implement it.\r\n\r\nIt would work as follows:\r\n- if the current environment has {HOST} variable defined then it will apply the host value to the URL automatically if the URL entered in the panel is relative. No need to put ${HOST} into the field.\r\n- if the URL editor has absolute URL nothing changes \r\n- if the URL has the ${HOST} value it will be replaced as in case 1.\r\n\r\nI'll put it into the tasks list.\r\n"}],"action":{"name":"View Issue","url":"https://github.com/jarrodek/ChromeRestClient/issues/926#issuecomment-266788589"}}}

Actually, using variables DOES work:

But if you try to expand the URL section, OR if you hit enter to run the query, it escapes the values.  As long as I don't expand the URL section and remember to always hit the "Send" button, this does work now.  So maybe it's a easy fix then to not encode if there is a variable match?


I don't know what Flow is telling me

Flow 0.38, Windows
WHAT error? It mentions a project file and when I remove the flow-check comment from it there is no error, but I have changed every single Flow type in that file to read any and still get that error, An error that only contains Flow-internal information, apart from the file name nothing about my project at all.
The sentence "This type is incompatible with." has a nice touch too.... incompatible with what exactly? Why go to the movies when you can get all the tension and excitement from a Flow type check? "This error report will be further expanded on in the next episode."
lib/storage-unversioned-objects.js:0
inconsistent use of library definitions
645:     static all<Elem, T:Iterable<Elem>>(promises: T): Promise<$TupleMap<T, typeof $await>>;
                                                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^ array type. This type is incompatible with. See lib: ../../../AppData/Local/Temp/flow/flowlib_17592b4/core.js:645
630:       resolve: (result: Promise<R> | R) => void,
                             ^^^^^^^^^^ Promise. See lib: ../../../AppData/Local/Temp/flow/flowlib_17592b4/core.js:630

Found 1 error

@WhyEvenTry can you leave an example of code that caused this error?
Here is some related examples of usage.

The problem is I have not changed anything in that particular file for quite some time, and since I run Flow regularly and this error is new (I always have zero errors), fresh as of this evening, I don't see how it even could be anything in that file. Also, since I declared every single item "any", if it really was something in that file, the error should have gone away, no? And if it was something in that file, why doesn't Flow give me a place?
It's not the first time I get a Flow error that doesn't point to a place, but it's the first time I was unable to find the location by trial and error, removing files and functions from Flow inspection and checking when it starts to complain. Doesn't work here, if the file is out, no error (but the file is unchanged and never caused an error before!), if it's in but with ALL its types set to "any" the error is there.

If you run flow check --traces 100 each error will be printed with a pretty unreadable trace of what Flow is doing. If you scan through the trace, it should mention a file that you have touched recently. That should help you debug.
If you figure out how to trigger this error, we'd love to know! @mroch has done a lot of work getting rid of these terrible "inconsistent use of library definitions" errors, but there are a few more hanging around that we'd love to kill!

Yes that's valuable.
Found it, in a different file, an unusual construct to be sure but nothing too horrible I'd say (the least important function of the whole project).
I don't have a promise to return to the caller so I create a new one, but then I have a promise inside the callback because I call my already promisified delete function. Definitely inconsistent, I would not leave it like that if it wasn't really the last significant function of all, and otherwise it's correct and not even hard to read either I think - something I care more about than "elegance".
module.exports.cleanTempFiles = function (): Promise<string[]> {
    return new Promise((/**Function*/ resolve, /**Function*/ reject) => {
        fs.readdir(STORAGE_DIR, (err: ?ErrnoError, files: string[]) => {
            if (err && err.code === 'ENOENT') {
                reject(new FileNotFoundError(err, STORAGE_DIR));
            } else if (err) {
                reject(new StorageError(err));
            } else {
                Promise.all(
                    // Temp. file names start with "tmp-", see createTempFileName()
                    files
                    .filter(f => f.startsWith('tmp-') === 0)
                    .map(deleteFile)
                )
                .then(resolve)
                .catch((err: Error) => reject(new StorageError(err)));
            }
        });
    });
};


Yang/issue#1

The model is pretrainable now.
Major changes:

in dataloader.py, added a DataLoaderPubchemContext to handle the new dataset format with substructs. The new data loader uses a new collate function, BatchPubchemContext (in batch.py), to add some attributes to the mini-batch.
in dataloader.py, added an ExtractPubchemSubstructs, which is majorly the same as the original ExtractSubstructureContextPair class. The x_substruct is based on a root_substructure instead of a root_atom now.
the new training logic is in pretrain_contextsub.py. The way to handle outputs from the context model and the substructure model is slightly changed.
the MoleculeDataset is completely refactored. The main logic remains the same. Each Data object now contains a substructs attribute.
move all helper functions in loader.py to util.py. Move data loading related functions/classes from util.py to dataloader.py.

Minor changes include but not limited to linting and a few changes to the variable names.

Jimmy,
If you have questions, we can have a discussion whenever you have time. Please write unit tests to make sure my new data are correctly generated and handled during the training process if possible. Thank you!

Thanks. I am reviewing this code now.


Update dependencies to ensure no known issues

The solr_faceted_search_react library has a number of known issues with dependencies. We need to build our own version of the library to remove update those dependencies.
Fork the original library in the iSamplesOrg git workspace
Enable access to the repo
Squash dependency issues

@datadavev I update the package.json from babel 6 to 7 and outdated packages. It works when we use browserify to build a solr search webapp.


Add c# sample project and scripts to build / run tests from ide and c…

…mdline

@dhashrath-msft,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


Add a functionality to download the XSD schema files from the ISO website

Describe your changes
Adding an ISO XSD schema downloader.
With the additional argument the user automatically accepts the ISO license with downloading the XSD schemas
Issue ticket number and link
#11
Checklist before requesting a review

[x] I have performed a self-review of my code
[ ] I have made corresponding changes to the documentation
[x] I read the contribution documentation and made sure that my changes meet its requirements

@SebaLukas, please review my doc changes and, if okay, feel free to merge.


Google Tag Connector Track for Admin Issues

Description of bug
When you first set up a Google Tag Manager Connection and enter a GTM id and hit save without checking the track for administrators. GTM will still load for admins. But if you check track for admins, hit save. Reload and go back and uncheck track for admins it finally stops loading GTM for admins.
Steps to reproduce

Go to Settings > Connectors > Google Tag Manager
Ensure a tracking code is added
Leave change track for admins to false (default)
Press save
Check dom and see GTM still loads

Current behavior
GTM is still loading for admins even though track for admins is false (not checked)
Expected behavior
Expect it to not load GTM if that is not checked.
Error information
No errors, just does not what one expects.
Additional context
Wondering if this is related to #2782?
Affected version

[ ] 10.00.00 alpha build
[ ] 09.10.02 release candidate
[X] 09.10.01 latest supported release

Affected browser

[X] Chrome
[X] Firefox
[X] Safari
[ ] Internet Explorer 11
[X] Microsoft Edge (Classic)
[X] Microsoft Edge Chromium

Still an issue.
Thanks
-Cameron

Can we re-open this one? It's still an issue.
Thanks
-Cameron

Just in case someone needs it: I've created a duplicate (didn't find this one in search), where I've described what I've found out in the xml file in settings which seems to be a root cause. So whoever's going to work on it check it out if you need it:
https://github.com/dnnsoftware/Dnn.Platform/issues/5198
P.S. Hope it's going to be fixed sooner then closed automatically for inactivity. ) It's been a long time already...

Reopened sir

This was fixed in https://github.com/dnnsoftware/Dnn.Platform/pull/5669 Please test v9.12.0 latest rc and report back if you find any issues.


Update unit tests so they don't litter console

console.warn and console.error disabled in various tests
tweak to top-nav so that it no longer produces a warning
closes #631
Checklist:

[ ] Documentation N/A
[x] Tests
[x] Ready to be merged

Deploy preview for govuk-react processing.
Building with commit 79d9683d0f4d56717310fbfc46049b3648c0de26
https://app.netlify.com/sites/govuk-react/deploys/5c98cb6762785f0007d7d525

Codecov Report

Merging #644 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #644   +/-   ##
=======================================
  Coverage   99.66%   99.66%
=======================================
  Files         104      104
  Lines         604      604
  Branches       69       69
=======================================
  Hits          602      602
  Misses          2        2

Impacted Files
Coverage Δ

components/top-nav/src/index.js
88.88% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bc73f2...79d9683. Read the comment docs.

maybe revert the top nav change for now and open a new ticket to review the console message at some point

PR good with me other than top nav change

Topnav change reverted


Return None for unknown Rustc versions

I think rbi should not return the latest rustc version when it cannot determine the actual version. This can be misleading. Some binaries might be built with custom (non-community) Rust toolchains such as Ferrocene, HighTec RDP or any other modified toolchains.
What do you think?
$ rbi -f ~/git-repos/tmp/rust-rayon/rust-rayon-unknown
TargetRustInfo(
    rustc_version=None,
    rustc_commit_hash='g6e511eec7342f59a25f7c0534f1dbea00d01b14',
    dependencies=[
        Crate(
            name='crossbeam-deque',
            version='0.8.5',
            features=['default', 'std'],
            repository='https://github.com/crossbeam-rs/crossbeam'
        ),
        Crate(
            name='crossbeam-epoch',
            version='0.9.18',
            features=['alloc', 'default', 'loom', 'nightly', 'std'],
            repository='https://github.com/crossbeam-rs/crossbeam'
        ),
        Crate(
            name='rayon',
            version='1.10.0',
            features=['web_spin_lock'],
            repository='https://github.com/rayon-rs/rayon'
        ),
        Crate(
            name='rayon-core',
            version='1.12.1',
            features=['web_spin_lock'],
            repository='https://github.com/rayon-rs/rayon'
        )
    ],
    rust_dependencies_imphash='448bbc16eb0dc31aa085c896d6ba2585',
    guessed_toolchain=None
)

Hello,
Thanks for your interest in this project ! I would love to try out and test your PR, but those toolchains seems to be private / needs a payment. I'd be glad to search for artifacts if I had an access.
For now, rbi stay focused on official rust toolchains, as those are the only ones I have access to.

I see. Ferrocene is open-source, so technically we should be able to build their toolchain ourselves but it may not be straightforward. Maybe I will give it a shot in the future.

I see. Ferrocene is open-source, so technically we should be able to build their toolchain ourselves but it may not be straightforward. Maybe I will give it a shot in the future.

It is, but building their toolchain requieres s3 auth on their server to pull some build stuff, so I guess you are forced to create an account and maybe pay to get access to it.

Lets close this. I have access to the HighTec Rust toolchains since I work there but I cant discuss or distribute them. One thing is for sure: they have their own Git history with different commit hashes compared to the upstream Rust community version. I think the same goes for Ferrocene, though I did not check that one.

If you could grant me access to those toolchains, I'd be glad to work on it. However, without access, it will remain out of scope.
This issue highlights an interesting problem: rbi should not return the latest rustc version if it cannot find the proper version.
I suggest you reopen the issue (I'm unable to do so since you deleted the source branch).

Ah okay, reopened it.


issue while updating a record in cosmosdb using this nodejs example

Hi Team,
There are issues in the specified code while updating a record in cosmos DB.
Please refer to the details below :
Issue statement:  The issue is in executing the following line of code. As per the example, It created the record "Created new item: 3 - Complete Cosmos DB Node.js Quickstart ⚡". But while updating the record, It is unable to find the id, though the record is there in the cosmos DB SQL API DB
const { resource: updatedItem } = await container
.item(id, category)
.replace(createdItem);
Stack Trace :
"Entity with the specified id does not exist in the system.,
RequestStartTime: 2020-04-20T01:23:59.7499533Z, RequestEndTime: 2020-04-20T01:23:59.8799741Z,  Number of regions attempted:1
ResponseTime: 2020-04-20T01:23:59.8799741Z, StoreResult: StorePhysicalAddress: rntbd://byaprdddc01-docdb-2.documents.azure.com:14527/apps/3aad1623-2e98-4588-b6fd-3ec68b500699/services/837f4f87-00e5-4d5b-a27b-ad9bc7b37ec2/partitions/16e006db-8563-458d-bd49-f20da7badeb3/replicas/132316158060007705p/, LSN: 2, GlobalCommittedLsn: 2, PartitionKeyRangeId: 0, IsValid: True, StatusCode: 404, SubStatusCode: 0, RequestCharge: 1.24, ItemLSN: -1, SessionToken: -1#2, UsingLocalLSN: False, TransportException: null, ResourceType: Document, OperationType: Replace
, Microsoft.Azure.Documents.Common/2.10.0"
Let me know if you need any further information.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c37e9125-19f4-ed9c-5b69-a42dfb6d42b8
Version Independent ID: bd2b39bc-ed3d-8c21-f620-5e094b491aee
Content: Quickstart- Use Node.js to query from Azure Cosmos DB SQL API account
Content Source: articles/cosmos-db/create-sql-api-nodejs.md
Service: cosmos-db
Sub-service: cosmosdb-sql
GitHub Login: @deborahc
Microsoft Alias: dech

@rajukmr Thanks for your comment. We will review the issue and get back to you shortly.

Fix is in https://github.com/Azure-Samples/azure-cosmos-db-sql-api-nodejs-getting-started/pull/5

@rajukmr The sample works fine now, I just tested it.

We will now close this issue if there aren't further questions.

#please-close


Add shisui's story blog

Fix #17

Do you have a website, github or any docs you could link out to @GrapeBaBa ?


Issue 1998 integration guide updates

First pass on improving the integration guide and webhook example. My purpose is to clarify some confusing points, but not be a major re-write.
Feedback on Zulip-ish or Pythonic wording is particularly appreciated.

Automated message from Dropbox CLA bot
@feorlen, it looks like you've already signed the Dropbox CLA. Thanks!

Cool, this looks great @feorlen!  A couple pieces of feedback:

stylistically, we try to write the first lines of commit messages so that it's clear what part of the project is being worked on, since that makes life easier for folks skimming the commit history to understand what could have changed (a typical application is trying to figure out which commit might have introduced a particular bug when it's too time-consuming to do a git bisect).  For these, I'd probably just add "docs: " at the start of each of the commit messages.
In the last commit, I might also link to e.g. https://zulipchat.com/integrations to show what it looks like.

The other changes all look like great improvements and I'm happy to merge them once you're ready for me to (if you don't get to adding docs: to the commit messages, I can easily do that as I merge)

I fixed the commit message on the last one, since it was easy while adding the link mentioned. (I was looking for something like that, thanks.) There's also one commit that's just typos, which I expected would be squashed. I wasn't sure if the whole thing would get squashed, actually. And then updating the other messages.
Is there an easy way to do all that together? I started reading git docs and what I'm seeing I'd want to test the suggested rebase commands before doing it for real. I can do that, but not immediately. If you are ok otherwise and want to wrap this up asap, be my guest. (I'm busy all day tomorrow else I would.)

I would use git rebase -i and then tag each commit with r for reword.
We generally are happy to merge fairly fine-grained commits; they do a lot better job of explaining why one is doing something than one gets if you squash a bunch of stuff.

Cool, merged, thanks @feorlen!  One note -- I had to fix a few lint errors due to trailing whitespace on some lines of your doc changes; you probably want to configure your editor to not do trailing whitespace.
I hope this will make a big different for folks working on webhook integrations in the future!

That's weird. I found a bunch of whitespace earlier, and lint is still fine locally. I'll check later to confirm. Thanks for fixing it.


not using the Xbox-like but keyboard

how to solve the problem

You can check gamepad_reader.py and use the same library to read your keyboard inputs and map to corresponding commands.
Welcome to open a PR for that once you solve it!

As you say, I check gamepad_reader.py and use the same lib to read my keyboard inputs, but it cant not map to corresponding commands. I am sure read my keyboard inputs successfully but can not control the robot in sim.

Could you be more specific by "it cant not map to corresponding commands"? What fields did you fill in with the keyboard inputs ingamepad_reader.py and what's the entry script of your "robot in sim" (like RL_MPC_Locomotion.py)?

Close due to inactivity.

Close due to inactivity.


macos not raising OOM error

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): yes
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): MacOS Catalina 10.15
TensorFlow installed from (source or binary): binary
TensorFlow version (use command below): 2.2.0
Python version: 3.x

Describe the current behavior
When allocating a large tensor on macos the code is killed by the kernel instead of raising a OOM error.
Describe the expected behavior
The code above should raise a Resource Exhausted OOM error, as it does on Linux.
Standalone code to reproduce the issue
Here a minimal example:
import tensorflow as tf
tf.ones(2**40, dtype=tf.complex128)

It is likely macos throws a different error that we don't manage to capture. Thanks for pointing the issue out

Hi @scarrazza!
We are checking to see whether you still need help in this issue . Have you tried this thread for Tensorflow installation in Mac OS yet? . Thanks!


ValueError when calling RunTS calibrate() method in version 0.4.8 (works in earlier releases)

Our application using mth5 worked properly with the past several releases, but now crashes when version 0.4.8 is used.  Here's a traceback:
Error
Traceback (most recent call last):
  File "/Users/jwl/PycharmProjects/pyspedas/pyspedas/mth5/tests/test_load_fdsn.py", line 118, in test02_load_fdsn_basic
    load_fdsn(network="4P", station="REU49", trange=[date_start, date_end])
  File "/Users/jwl/PycharmProjects/pyspedas/pyspedas/mth5/load_fdsn.py", line 264, in load_fdsn
    run_ts = run_ts.calibrate()
  File "/Users/jwl/PycharmProjects/pyspedas/venv/lib/python3.9/site-packages/mth5/timeseries/run_ts.py", line 1051, in calibrate
    new_run.add_channel(calibrated_ch_ts)
  File "/Users/jwl/PycharmProjects/pyspedas/venv/lib/python3.9/site-packages/mth5/timeseries/run_ts.py", line 765, in add_channel
    raise ValueError(msg)
ValueError: Channel sample rate is not correct, current 0.0 input 1.0

I think I see what the problem might be: in the calibrate() method, we have this code:
        new_run = RunTS()
        new_run.run_metadata = self.run_metadata
        new_run.station_metadata = self.station_metadata

        for channel in self.channels:
            ch_ts = getattr(self, channel)
            calibrated_ch_ts = ch_ts.remove_instrument_response(**kwargs)
            new_run.add_channel(calibrated_ch_ts)
        return new_run

And in the add_channel() method:
        ### need to validate the channel to make sure sample rate is the same
        if c.sample_rate != self.sample_rate:
            msg = (
                f"Channel sample rate is not correct, current {self.sample_rate} "
                + f"input {c.sample_rate}"
            )
            self.logger.error(msg)
            raise ValueError(msg)

add_channel() is being called on the newly constructed RunTS object new_run in calibrate().  The run_metadata and station_metadata fields are initialized from the original RunTS object, but it looks to me like the sample_rate field is defaulting to 0.0, rather than being assigned from the original RunTS object self.sample_rate .
I will test this theory and submit a PR if I can get it working again....
Update:   After forking the repo and using it for my test code, I see that JP committed some changes yesterday that seem to have fixed the issue.  I hope there will be a new release coming soon!

Confirmed fixed in version 0.4.9


Make code match behavior as defined in RFC 2818 and RFC 6125 and documented behavior

The CN should be checked if no dNSName exist in subjectAltNames. The code treated a IP address as DNS name by appending it to dnsnames. This way CN was not checked in a certificate which contained the hostname as CN but only IP addresses as SAN.
See also http://stackoverflow.com/questions/41089539/authentication-issue-with-ssl-certificate-using-python-requests-lib

Thanks for this! For the moment, I'm not going to merge this, for the following reasons.

This patch affects urllib3, which we vendor without changes. It would need to be proposed to that project.
The inclusion of match_hostname is currently intended to behave the same way on all platforms. Thus, if we edit it, we'd also have to stop preferring the stdlib until they matched our behaviour. This patch is therefore incomplete.
Your assertion about the incorrectness of our logic is not as clear-cut as it seems. Our behaviour currently matches curl, Firefox, and Chrome, which is some good company to be in (see curl/curl#1065).
It seems the Python crypto experts aren't convinced of this either, and ordinarily I'd default to respecting their logic.
There is basically no good reason to have a cert that fails in this manner. CN has been deprecated for years, SAN has been around forever. Just put the hostname in the SAN field as well.


Raise chronological period exception more often

Hi! Not an issue, but perhaps an enhancement to make fitting RV data for multi-planet systems more user-friendly. The docs specify that for multi-planet systems, the planetary periods must be in 'chronological order'. So lets say I have a two-planet system with planet b having a 10-day period and planet c a 30-day period. If I try to fit RV data for this system, fixing the periods to those 'literature' values, and choose planet c to be p1, I get the following error:
Exception: INPUT ERROR: planetary periods in the priors are not ordered in chronological order. Planet p2 has a period of 9.0 days, while planet p1 has a period of 32.939614 days (P_p2<P_p1).

which is great and self-explanatory.
Instead, if I fix the period of planet c (p1) but put a prior on the period of planet b (p2) this exception is no longer raised - even when the prior constrains the period to always be shorter than 30-days (e.g. U(9,11) ). In this case, dataset.fit will run without error, but finish in one iteration and return nonsense, e.g., this printed output:
1it [00:00, 63.27it/s, +300 | bound: 0 | nc: 1 | ncall: 301 | eff(%): 100.000 | loglstar:   -inf <   -inf <    inf | logz:   -inf +/-    nan | dlogz:  0.000 >  0.309]

In situations like this, I think it would be helpful to raise the same exception as above.

Hi @radicamc,
Thanks for opening this issue! I see your point, and I think you are right --- at least a warning should be raised indeed based on the support of the prior if it is disjoint with the others (including fixed periods).
Cheers,
Néstor


Support eslint (as well as --fix)

Support eslint_d and eslint along with the --fix argument to automatically fix changes.

--fix should be the default for eslint(_d) when performed with formatting - diagnostics shouldn't have this flag.

why not use eslint lsp ?


[DPP-54] Fix build status

Issue:
The Travis CI build is broken because of the change in name of the repository. Fix the build and add the badge to the README.md file

The Travis build step is now deprecated.
Issue:

The build automation with Travis CI does not allow pushing the final artifact to a server, so it can be considered a dead-end.

The tightly defined dependency tree in the cabal file only works with the Nix dependency manager, but creates problems with all other environments. Interestingly all environments have slightly different issues, so fixing one does not guarantee fixing the others.

Resolution.
As the automation part seems useless it is now considered deprecated and will be removed from the codebase.


Multiple categories and labels for chart

I'm trying to build a stacked bar chart for one of the requirement. The chart should look like as follows:

The problem here is kind of multiple categories.
The first level of categorization is Proj1 and Proj2 and the next level is R1.0 and R2.0. I've tried the following:
var chart = c3.generate({
    bindto: '#chart',
    data: {
      columns: [
        ['Proj1Item1', 30, 200, 100],
        ['Proj1Item2', 50, 20, 10],
        ['Proj2Item1', 20, 120, 50],
        ['Proj2Item2', 30, 20, 80],
      ],
      type: 'bar',
        groups: [
            ['Proj1Item1', 'Proj1Item2'],
            ['Proj2Item1', 'Proj2Item2']
        ]

    },
    axis: {
        x: {
            type: 'category',
            categories: ['R1.0', 'R2.0', 'R3.0']
        }
    }
});

Is it not possible with C3 to achieve this? I tried googling around and not able to find the solution for it.

any luck with this?

No, not yet. I have just kept that project on hold for time being and will be taking up again in couple of weeks.
Sent from my iPhone

On Jul 26, 2016, at 10:47 PM, Cesar<EMAIL_ADDRESS>wrote:
any luck with this?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

I am also looking for this functionality. Is there a way out?

I am also looking for this functionality. hzzzz


Infinite loop in Paged.js

When following the instructions to install using the command:
npm i -g @asciidoctor/core asciidoctor-pdf

I get errors about needing to copy ghostscript files from my system. I finally figured out that these weren't being compiled, but were to be copied from a specific location on my drive. I didn't have this installed by default, so it failed without me understanding why several times (I was checking for where the files were being copied to, not where they were coming from).
You should have something in the instructions that specify that ghostscript needs to be installed prior to running the npm installation command as it will fail otherwise. I was able to get to the other parts about the Windows build stuff, but there was nothing about ghostscript anywhere except in the error messages.
This may not be a problem on Linux (I haven't bothered to try there), but is definitely one on Windows.

Hello @woodbe I think it's the same error/warning as https://github.com/Mogztter/asciidoctor-pdf.js/issues/162
As far as I understand ghostscript is not required, it's actually an optional development dependency in Paged.js. We are currently discussing the best approach to fix this warning.
Can you please confirm that you can use asciidoctor-pdf (without installing ghostscript) and copy-paste the install log?

I can send the install log, but at the moment it has ghostscript installed (I'm not sure where the install log is either). As for using it, no, I was not able to use it before installing ghostscript. I was getting timeout errors when the code ran which is what made me focus more on the install error messages.

I can send the install log, but at the moment it has ghostscript installed (I'm not sure where the install log is either).

Ok. Is that possible to uninstall both ghostscript and asciidoctor-pdf?

As for using it, no, I was not able to use it before installing ghostscript. I was getting timeout errors when the code ran which is what made me focus more on the install error messages.

I think it's unrelated (or at least I hope it's unrelated) because ghostscript is not used when you convert an AsciiDoc document to PDF.
So if you uninstall ghostscript it should work. Not sure why you were getting timeout errors though...

Ok, I have to admit a lot of ignorance here. I am unable to get it to uninstall using npm (the ghostscript I can do easily, but I'm not really familiar with npm). I am running powershell as admin and get this error when I am trying to uninstall (I also tried with just "asciidoctor-pdf" with the same result).
PS C:\WINDOWS\system32> npm uninstall @asciidoctor/core asciidoctor-pdf
npm WARN saveError ENOENT: no such file or directory, open 'C:\WINDOWS\system32\package.json'
npm WARN enoent ENOENT: no such file or directory, open 'C:\WINDOWS\system32\package.json'
npm WARN system32 No description
npm WARN system32 No repository field.
npm WARN system32 No README data
npm WARN system32 No license field.
up to date in 0.271s
found 0 vulnerabilities
I will be glad to help, I'm just not sure exactly what I need to do (sorry).

OK, I figured out the uninstall (I was missing the "-g").
install_logs.zip
I uninstalled everything, moved the gs folder and re-ran the installation. When I run it after getting the errors during install I get this message
Unable to generate the PDF - Error: TimeoutError: Navigation timeout of 30000 ms exceeded
I have attached the logs from the installation attempts during the last week. Let me know if you need something else.

OK, I figured out the uninstall (I was missing the "-g").

Indeed, if you've installed asciidoctor-pdf globally you need the -g option to uninstall it.

I have attached the logs from the installation attempts during the last week.

I can't find the error about ghoscript in your logs but I found other errors:
6 February
711 error code ENOENT
712 error syscall spawn git
713 error path git
714 error errno ENOENT
715 error enoent Error while executing:
715 error enoent undefined ls-remote -h -t git://github.com/mathjax/MathJax-src.git
715 error enoent
715 error enoent
715 error enoent spawn git ENOENT
716 error enoent This is related to npm not being able to find a file.
717 verbose exit [ 1, true ]

MathJax is using a git dependency and as a consequence git is required. See: https://github.com/Mogztter/asciidoctor-pdf.js/issues/124
I've reported this issue upstream and it should be fixed in the next version of MathJax (so git won't be required anymore).
Did you install git?
8 February
699 error code EEXIST
1700 error path C:\Program Files\nodejs\asciidoctor-pdf
1701 error Refusing to delete C:\Program Files\nodejs\asciidoctor-pdf: is outside C:\Program Files\nodejs\node_modules\asciidoctor-pdf and not a link
1702 error File exists: C:\Program Files\nodejs\asciidoctor-pdf
1703 error Remove the existing file and try again, or run npm
1704 error with --force to overwrite files recklessly.

I think you are trying to reinstall asciidoctor-pdf but it's already installed.

Unable to generate the PDF - Error: TimeoutError: Navigation timeout of 30000 ms exceeded

You get this error every time?
Could you try to run with --verbose and copy the output? Could you also try to run with --preview and then open the developer tools in Chrome to debug it further?
Thanks for all this information, hopefully we will soon find the root cause :wink:

Thanks. I did eventually install git, and I hadn't been sure about the installation, so yes, I definitely tried installing several times (and I wasn't sure how to uninstall, hence the problems.
I just ran the --verbose and got this:
require undefined
backend undefined
doctype undefined
standalone true
section-numbers false
failure-level FATAL
quiet false
verbose true
timings false
trace false
base-dir undefined
destination-dir undefined
verbose-mode 2
attributes
options {"safe":"unsafe","standalone":true,"failure_level":4,"verbose":2,"timings":false,"trace":false,"mkdirs":true,"attributes":[]}
converting file .\cPP-template.adoc
Unable to generate the PDF - Error: TimeoutError: Navigation timeout of 30000 ms exceeded
The preview just gave the timeout error (after launching the Chrome window). It does generate the HTML.
Templates.zip
On the off chance it could help, I'm attaching the adoc file and he HTML that is being generated. There are some custom admonitions (which is a different question since I don't know how to get those to be properly included here though I can do it in the "normal" asciidoctor).

Thanks for sharing.
I've noticed that Paged.js is looping:

As you can see, Paged.js is in an infinite loop.
But I was still able to generate a PDF from your file (on Linux): cPP-template.pdf
Not sure why on your machine Chrome is not able to navigate to the page within 30 seconds. Maybe on Windows Chrome is waiting for the JavaScript to complete but since it never completes... or maybe your machine is performing poorly?
We could increase the timeout (or disable the timeout completely) but I feel like 30 seconds is already a lot.
Would you be able to check on another machine or on Linux?

Yeah, I opened the file and noticed the infinite loop, thought that was odd.
I probably can't try on a Linux box until later this week, but I will see if I can get a Linux VM working (not sure, I'm on a business trip at the moment). The system is otherwise OK, so I'm not sure what is going on (but I figured providing both files would help show what is going on anyway).

@woodbe I've released a new version with a new version of Paged.js. Could you please give it a try and report back?

Closing, feel free to open a new issue (ideally with a reproduction case) if you still have problems with the latest release.


Add a flag to enable recommendations

Other pr's will build upon this base flag and layout.

Nows the time to have a discussion on what to name this flag (naming's hard). Originally I had something like:
    useRecommended:
      securityContexts: false
      priorityClasses: false
      ...

Which makes sense grammatically. Your using the recommended security context, for example.
Then I added 'enabled' to it, so you could enable all the flags at once:
    useRecommended:
      enabled: false
      securityContexts: true
      priorityClasses: true
      ...

User typically only sets userRecommended.enabled=true
But useRecommended.enabled sounds a little weird.
What do you think? There are probably other ways of doing it....
  useRecommendations: false
  useRecommended:
    securityContexts: true
    priorityClasses: true
    ...

User typically only sets useRecommendations=true
or
recommendations:
  enabled: false
  securityContexts: true
  priorityClasses: true
  ...

User typically only sets recommendations.enabled=true

Nows the time to have a discussion on what to name this flag (naming's hard). Originally I had something like:
    useRecommended:
      securityContexts: false
      priorityClasses: false
      ...

Which makes sense grammatically. Your using the recommended security context, for example.
Then I added 'enabled' to it, so you could enable all the flags at once:
    useRecommended:
      enabled: false
      securityContexts: true
      priorityClasses: true
      ...

User typically only sets userRecommended.enabled=true
But useRecommended.enabled sounds a little weird.
What do you think? There are probably other ways of doing it....
  useRecommendations: false
  useRecommended:
    securityContexts: true
    priorityClasses: true
    ...

User typically only sets useRecommendations=true
or
recommendations:
  enabled: false
  securityContexts: true
  priorityClasses: true
  ...

User typically only sets recommendations.enabled=true

I personally like the last option the most:
recommendations:
  enabled: false
  securityContexts: true
  priorityClasses: true

I agree as well. Its much simpler

what about the following:
recommendations:
  enabled: false
  securityContexts: true
  priorityClasses: true

This way people can opt in on the recommendations by setting recommendations.enabled=true and opt out of specific ones by setting them to false.`
This nicely groups the entire feature in a single yaml block.

Looks like consensus is for:
recommendations
Updating the pr for that layout.


Add basic regexp for shellcheck gcc output

abandoned in favour of https://github.com/bottle-garden/octonote/pull/3


View Hierarchy Issue in TabBar Controller

Hi,
When used to highlight UITabBarController tabs , The current elements highlighting rectangle is behind the tabbar item.
Image attached

Could you please share he code that you are using to highlight the exact tab bar item? Then I might be able to help you.

Thanks for your help @o15a3d4l11s2, since there hasn't been any update after your comment, I'm going to close the issue for now.


Tracking enhacements for Elasticsearch.search

Currently in https://github.com/elastic/apm-agent-python/blob/master/elasticapm/instrumentation/packages/elasticsearch.py#L47 we are discarding everything but the query in the body which can cover some very important (from a performance point of view) aspects of the operation for example pagination - large from/size can have severe impact - and aggregations - if present can severely impact everything.
It would also be great to track the statistics on the response:
took, hits.total, _shards.total/failed/successful information
which can expose badly structured code/queries or performance issues in elasticsearch
Thank you!

@HonzaKral (or @sethmlarson) can you clarify why including aggs can be problematic for collecting the query? I recently "fixed" this in #940 because a user was complaining about the lack of aggs which were the important part of the query for his debugging.
For the additional information we could collect, I'm not sure where we would put it. We currently don't populate any custom context ourselves, we leave that for the user. We also don't collect service-specific data like this for anything else we instrument.
Unless @beniwohli has any bright ideas I think I'm going to probably close this issue (once we resolve the above question about aggs and other query data).

I don't see how including the whole body could be problematic, quite the opposite. The _search API is used for many other things besides just running a query (aggregations, suggestions, sorting, script fields, pagination, ... ...) all of which can have significant impact on performance and behavior and are therefore important to track.

We also don't collect service-specific data like this for anything else we instrument.

We do provide information for rows_affected for SQL for example, this would be similar and would belong in the same place.

Ah, I misread your original issue, I thought you were saying that we purposely only include the query because including the whole payload could be problematic. Glad my fix was a good one!
And thank you for pointing out rows_affected on the span context. I hadn't actually internalized that spans have their own context, and it doesn't have a standalone spec in the apm server repo. Rather, span context is here: https://github.com/elastic/apm-server/blob/master/docs/spec/spans/span.json
I think hits.total could probably go under the existing rows_affected, and we could easily add something for took. I'm trying to figure out  what field we might use for the _shards.total/failed/successful information. Ideally it would be a field other db providers could use for similar context. I'll have to think on this (and we'll need a PR against that spec before we can add these new context pieces).

I'm adding http.status_code and db.row_affected but I can't find relevenant field for _shards.total/failed/successful in the APM span specification https://github.com/elastic/apm-server/blob/master/docs/spec/v2/span.json
Could you check the APM span specification and suggest me the field mapping please if exists?
Guess the field took(response time) is not important because span measures it by default from the client side, or?


Add custom exporter support for all pillars

Enable console exporting and such via env vars. While we still won't be able to allow custom metrics readers, this is close.

Migrating to azure sdk: https://github.com/Azure/azure-sdk-for-python/issues/32498


Migrate developers over to new CDK per developer envionments

Story
We now have pipelines that are capable of deploying a CDK per developer. We need to migrate developers over to this pipeline. However, currently those pipelines are dependent on the old 'initialise.yml' pipeline having run first. That pipeline runs the terraform stage that creates the infrastructure into which all the developer environments are deployed. So, the following tasks need to be done to make this happen;
Acceptance criteria

All developers have their own SBAT environment that uses their own CDK

Tasks
OPTIONAL
List of tasks required to implement this story

[x] Create a pipeline (create_cluster.yml) that creates the infrastructure. i.e. split out the terraform stage of the initialise.yml pipeline into a new pipeline
[x] Create a new pipeline that runs on a cron job similar to the build.yml pipeline. This pipeline should trigger the following pipelines in order;

[ ] create_cluster.yml
[ ] initialise_cluster.yml
[ ] deploy_cdks.yml
[ ] initialise_sbat.yml (rename this to deploy_sbat.yml)

[x]  migrate developers github account names from NAMESPACES.md to DEV_ENVS.md

Consideration needs to be given to how dev and nightly sbat environments are deployed.

New pipelines in place and old pipeline triggers have been removed and added dep- to their names
Some functional tests are also going to run after the deployment which is extra scope than what is in the description
Will need to look at some conditions for the deployment.yaml and see about what notifications we do and don't want to happen


Reorder management command arguments in --help output

…to prioritize command-specific arguments
Trac ticket: https://code.djangoproject.com/ticket/29301

I think we should at least add a comment in the code explaining the position of the call.

I added the comment, rebased and adjusted the commit message to use the past tense.

Nice

@carltongibson Thanks for adding the explaining comment and the test.


Add last changed commit in footer

Feature Request
As discussed and suggested by @scottyeager, we could use mdbook-last-changed to show last commit date.

Fix when #367 is merged.


Spyder - Inspect Object Shortcut Not Working

Description of your problem
The command-I shortcut does not work in the editor. When using the combo, nothing happens.
What steps will reproduce the problem?

Open Spyder 3.2.4
Create a new .py file
Write basic code and begin using a function that can be inspected. (Ex.

import pandas as pd
dataset = pd.read_csv('x.csv')
)
What is the expected output? What do you see instead?
A definition of the object, with all expected parameters, appears in the Help window.
Please provide any additional information below
Versions and main components

Spyder Version: 3.2.4
Python Version: 3.6.3
Qt Version: 5.6.2
PyQt Version: 5.6
Operating system: macOS High Sierra (10.13.2 (17C88))

Dependencies
Please go to the menu entry Help > Optional Dependencies (or
Help > Dependencies), press the button Copy to clipboard
and paste the contents below:
IPython >=4.0    :  6.2.1 (OK)
cython >=0.21    :  0.27.3 (OK)
jedi >=0.9.0     :  0.11.0 (OK)
nbconvert >=4.0  :  5.3.1 (OK)
numpy >=1.7      :  1.13.3 (OK)
pandas >=0.13.1  :  0.21.1 (OK)
psutil >=0.3     :  5.4.1 (OK)
pycodestyle >=2.3:  2.3.1 (OK)
pyflakes >=0.6.0 :  1.6.0 (OK)
pygments >=2.0   :  2.2.0 (OK)
pylint >=0.25    :  1.7.4 (OK)
qtconsole >=4.2.0:  4.3.1 (OK)
rope >=0.9.4     :  0.10.7 (OK)
sphinx >=0.6.6   :  1.6.3 (OK)
sympy >=0.7.3    :  1.1.1 (OK)

Thanks for reporting. Your specific example appears to be a duplicate of #5998 , which is a specific problem with pandas and jedi, not Spyder. Therefore, this issue will be closed. If this occurs on anything you try to complete from a variety of packages, then please reopen and provide any pertinent details unique to your setup, as well as try spyder --reset and reinstalling Anaconda.


Automated PR: Cookstyle Changes

Hey!
I ran Cookstyle 7.23.0 against this repo and here are the results.
This repo was selected due to the topics of chef-cookbook
Changes
Issues found and resolved with resources/delete_from_list.rb

32:1 refactor: Chef/Modernize/ClassEvalActionClass - In Chef Infra Client 12.9 and later it is no longer necessary to call the class_eval method on the action class block. (https://docs.chef.io/workstation/cookstyle/chef_modernize_classevalactionclass)

Released as: 4.4.0


MDTZ-1153: Update /entities endpoint to take user ID from query parameters

Changes

refactor: Updates /entities endpoint to take user ID from query parameters.
refactor: Removes extractUserIdFromHeadersMiddleware as unused.

Bug: You'll also have to update the action template URLs in atlassian-connect.ts

Oh, my goldfish memory in action. Thank you, Sam, for your careful review and double reminder about this change!