Project state: it's time to fork

After trying my best to maintain as good as possible this project, it is time for me to stop there.
I am facing several issues now:

the build / merge system is broken due to an error (as you may found here for example) between Travis and the Github API - based on the solution described here, it seems I have to modify the settings of the project in order bypass an outdated setting... unfortunately, I don't have the right accesses to go into the project settings. I tried to contact several times the original creator / maintainer of cargo-generate to do something here but I did not received any news from her.
I don't use cargo-generate enough anymore to know "what is good for the project". To me, the best maintainer of a project is a person who uses it (almost) every day, and I think also that some project contributors (@sassman for example) would be better maintainers than me today. Unfortunately, as I don't have any access to the settings, I can't give this role to someone...
I had hard times to maintain my own projects last year, and I will have less time to maintain them this new year, so it's time for me to focus on something I want to use and maintain.
I am not the only maintainer of this project, but it became very difficult to obtain responses from other maintainers the last months unfortunately.

Those are the reasons I think it is time to fork this project now.
Note for the comments: I don't blame anyone for the maintenance and you should not blame anyone too. Open Source is great to develop and share new ideas, features, remarks... and share different "versions" (forks) of a given project.
Also, we all had a shitty year...
It's time to move on, but not the time to blame anyone here 😉
If you want to maintain a fork of cargo-generate (warning: be aware before that maintaining an open-source project is a lot of responsabilities), please respond to this thread with the crate name & github URL of your fork.
If you are an existing maintainer of this project, have an access to the project settings to fix the current issue(s), and want to maintain back this project, feel free! 😃
All the best 👋

What a sad day for the project. But of course totally understandable. So all the best for your future projects.
I'd like to avoid the forking if possible, and would rather ask the maintainers or the owner @ashleygwilliams to support me on that matters to maybe hand over some capabilities (meaning access to the settings etc).
The reason is IMO too many abandoned crates does not contribute well to the health of the rust ecosystem and that's why I prefer to invest into the future of a crate rather than let it rot.
If those things can be arranged I'd be more than happy to step up and keep this project alive.

What a sad day for the project. But of course totally understandable. So all the best for your future projects.
I'd like to avoid the forking if possible, and would rather ask the maintainers or the owner @ashleygwilliams to support me on that matters to maybe hand over some capabilities (meaning access to the settings etc).
The reason is IMO too many abandoned crates does not contribute well to the health of the rust ecosystem and that's why I prefer to invest into the future of a crate rather than let it rot.
If those things can be arranged I'd be more than happy to step up and keep this project alive.

I totally agree: avoid to fork and continue to maintain the project is way better than a fork...
Unfortunately, it seems my comments & mails did not reached the original maintainer.
Thanks in advance @sassman :)

I totally agree: avoid to fork and continue to maintain the project is way better than a fork...
Unfortunately, it seems my comments & mails did not reached the original maintainer.
Thanks in advance @sassman :)

@k0pernicus I reached out to @ashleygwilliams and she proposes a handover / kickoff call this weekend, you wanna participate or are completely out?

@k0pernicus I reached out to @ashleygwilliams and she proposes a handover / kickoff call this weekend, you wanna participate or are completely out?

Anyone else interested?
@EverlastingBugstopper

Anyone else interested?
@EverlastingBugstopper

hey! i appreciate the ping but i'm not really working on any projects tangential to cargo-generate anymore and like @k0pernicus said it likely makes sense for folks a bit more invested in the project/open to maintenance responsibilities to take the reins on this.

hey! i appreciate the ping but i'm not really working on any projects tangential to cargo-generate anymore and like @k0pernicus said it likely makes sense for folks a bit more invested in the project/open to maintenance responsibilities to take the reins on this.

Awesome @sassman, thanks. I discussed a bit with @ashleygwilliams and I may be available this weekend.
Do not hesitate to invite me, but if I don't answer I will certainly be busy with the family :)

Awesome @sassman, thanks. I discussed a bit with @ashleygwilliams and I may be available this weekend.
Do not hesitate to invite me, but if I don't answer I will certainly be busy with the family :)

I think we have successfully prevented the forking, thanks to @ashleygwilliams we got now an own gh org for cargo-generate, that allows us to operate more independently and make faster decisions.
Also the ci/cd issues is currently WIP and hopefully soon fixed.
If that would be ok for you @k0pernicus we may can close this issue :)

I think we have successfully prevented the forking, thanks to @ashleygwilliams we got now an own gh org for cargo-generate, that allows us to operate more independently and make faster decisions.
Also the ci/cd issues is currently WIP and hopefully soon fixed.
If that would be ok for you @k0pernicus we may can close this issue :)

Thanks all for this awesome work :)
Long life to cargo-generate 🎉

Thanks all for this awesome work :)
Long life to cargo-generate 🎉


Add options to disable repo resources when desired

Is there a specific use case for this request? It's pretty verbose to wrap every resource in the module with if ! defined(). If you're using another module to manage a given yumrepo reesource, it seems like the user should probably not both modules at the same time, rather than forcing all modules to be so defensive about their coding practices.

You may also want to look at the epel_*_enabled params, that already exist to let you control which of the repos are enabled via this module.

The issue is when other modules have a dependency on something like (https://github.com/example42/puppet-yum) and then define another epel repo (because everyone has decided that having a different solution for implementing epel repos is necessary). I've also opened a PR with that module to try to stem off collisions at the source rather than having to chase down and modify a few dozen other modules we're using in our environment.
Essentially, this is to try to inhibit bad code from being bad during compilation. We have a single Puppetfile for our environment so all modules need to play nice together and epel is a major pain.

It seems like the solution would be to have whatever is requiring a
specific epel module to stop that. This module can't control what uses it
as a dependency or not. The !defined methods will only work if the
resources are named identically, which certainly isn't guaranteed. On top
of that, that check happens at catalog compilation time, so without strict
flow control, one version of a catalog to another could get different
results. (If two competing resources are coded with if ! defined, which one
loads first?)
I think there's a better way. Honestly, it's a shame there isn't an
abstraction at a higher level to say something like "my stuff needs epel
and I don't care how" that many modules could satisfy.
On Thu, Jun 2, 2016 at 11:54 AM, Riccardo Calixte<EMAIL_ADDRESS>wrote:

The issue is when other modules have a dependency on something like (
https://github.com/example42/puppet-yum) and then define another epel
repo (because everyone has decided that having a different solution for
implementing epel repos is necessary). I've also opened a PR with that
module to try to stem off collisions at the source rather than having to
chase down and modify a few dozen other modules we're using in our
environment.
Essentially, this is to try to inhibit bad code from being bad during
compilation. We have a single Puppetfile for our environment so all modules
need to play nice together and epel is a major pain.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/stahnma/puppet-module-epel/pull/54#issuecomment-223387454,
or mute the thread
https://github.com/notifications/unsubscribe/AAAbMfKi4w6sP5DFjMS9Q1ZwoD8887Cnks5qHybVgaJpZM4Isxkt
.

The issue becomes when multiple modules have different dependencies for including/defining a yumrepo resource named epel. The catalog issue isn't much of one as they're all defining the same underlying repo (but it should compile consistently and not weave between the configuration).
To address it at a higher level would require the community to decide on one epel puppet module rather than the non-standardization.
Are you okay with the notion of including the defined checks for at least the epel repo resource?

We're not comfortable with that, because if you have two modules that contain a resource Yum['epel'] that are both protected with a defined() check, a user is guaranteed to receive ONE of the yum resources, but there is no guarantee WHICH yum resource is received.

Would it be better to implement this solution with a class variable for each yumrepo resource instead and wrapped each resource with that conditional?
Having no way to turn these off really sets a lot of expectations for every other module.

Do you mean something like 'epel_managed and 'epel_testing_managed'? That might hold value, so long as those default to true. I'm still not convinced this module is what you want if something else is providing epel repos, though.

Those options are precisely defined now. I've updated the PR to reflect those changes.
The issue of choice comes down to other modules that have declared this module as a dependency and then yet more modules that declare other epel modules as a dependency. In our environment, we have a single Puppetfile with our modules listed and these issues have been a source of frustration for some time. Hopefully, this can address those problems.

Merged in #68. Sorry this took so long to accept, and thank you for your contribution!


Fix few recurring test failures for v12

There are some failures that need addressing:
https://gist.github.com/wojtek0806/175851f02716db979bc3389400e8f923#file-test_device_group-py
Next failure is for failover state resource:
https://gist.github.com/wojtek0806/d12b399d8541cc8099611acac9314fe7
We also fail HTTPD tests:
https://gist.github.com/wojtek0806/ebb8167111ac83cd9d2284e36def6bbf

Another error, seems to be related to change in behavior:
https://gist.github.com/wojtek0806/f62ce855c540cf2737e2fd25c65cecae

added to 0.1.8 closing


added more analysis, fixed minor grammar formatting issues

have added more desktop analysis - @a-shmyg if you could review the section where it details about the processing crashing during integration (sprint 6?); i also changed the bullet points to make it flow a bit better with the paragraphs rather than just having DONE in capital letters.

also removed all bullet points from the last sprint and reworked into paragraph


Can't work with monorepo mode

It does not work after I move to monorepo mode:
https://docs.nestjs.com/cli/monorepo
Version: typescript 3.6.4
Time: 96ms
Hash: 636664306cf42961350d
Version: webpack 4.41.0
Time: 104ms
Built at: 2019-10-18 23:57:22
Entrypoint main = apps/admin/main.js
[Nest] 46523   - 2019-10-18 23:57:22   [NestFactory] Starting Nest application...
[Nest] 46523   - 2019-10-18 23:57:22   [InstanceLoader] DbModule dependencies initialized +14ms
[Nest] 46523   - 2019-10-18 23:57:22   [InstanceLoader] AppModule dependencies initialized +1ms
/Users/johnny/projects/test/topfullstack-test/server/libs/db/src/db.config.ts:1
export default {
^^^^^^

SyntaxError: Unexpected token export
    at Module._compile (internal/modules/cjs/loader.js:720:23)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:787:10)
    at Module.load (internal/modules/cjs/loader.js:643:32)
    at Function.Module._load (internal/modules/cjs/loader.js:556:12)
    at Module.require (internal/modules/cjs/loader.js:683:19)
    at require (internal/modules/cjs/helpers.js:16:16)
    at /Users/johnny/projects/test/topfullstack-test/server/node_modules/nestjs-config/dist/module/config.service.js:224:28
    at Array.reduce (<anonymous>)
    at Function.configGraph (/Users/johnny/projects/test/topfullstack-test/server/node_modules/nestjs-config/dist/module/config.service.js:223:28)
    at /Users/johnny/projects/test/topfullstack-test/server/node_modules/nestjs-config/dist/module/config.service.js:198:42

It's not about nestjs-config for sure.
Your entry point is apps/admin/main.js and the problem is here ...libs/db/src/db.config.ts
So are you sure you compile libs/db/src folder? I pretty sure that you don't

@zMotivat0r Thanks for your reply, but how could I fix it in monorepo mode?

/config/app.ts
export default {
  name: 'APP',
  secret: process.env.SECRET
}

It throws an error:
C:\work\code\nest-test\config\app.ts:1
export default {
^^^^^^

SyntaxError: Unexpected token export
...

If I move app.ts to app.js with module.exports it works.
module.exports = {
  name: 'APP',
  secret: process.env.SECRET
}

How could I use typescript in my configuration files?

What's your config glob? Looks like it's using ts files in prod.

ConfigModule.load(path.resolve('config', '**/!(*.d).{ts,js}'))

Your path includes every file from where the process is run from Which is not what you want to do because this will include any file ending with .ts or .js. It's best to use a relative dir using ___dirname to only pick the files relative to where your main file is being called. I would use this instead ConfigModule.load(path.resolve(__dirname, 'config', '**/!(*.d).{ts,js}'))


netdev-linux: respect configure result when including net/if_packet.h

The configure script already tests whether net/if_packet.h is
available. Respect the test result to fix build issues with musl
libc.

I don't think that #include is good for anything anyhow.  How about the following instead: https://patchwork.ozlabs.org/patch/978591/

Alternative patch looks good.


Chore: Applications addon

Changelog Description
Move applications logic from lib to addon. And modified related code accordingly.
Additional info
Applications addon does contain everything what applications.py in lib did. Moved extractenvironments command to the addon as it is his responsibility to implement it. Moved collect plugin which cares about collection of app name/label, or host name based on application name. Modified deadline and royalrender to support both options of arguments. Marked global command extractenvironments as deprecated.
Core changes: Created folder addons inside core addon which can be used for converted addons that are not yet in different repository. The first subfolder is name of an addon which is added to sys.path. So any content in the folder will be added to sys path and can be imported as with addons client code. This approach was chosen as future prove approach, to be able to skip addons which already are separated into repository, but older version of ayon core is used. This approach does not add the addons to PYTHONPATH so it may have issues with host addons as they might not be able to just import their code directly.
Opened questions:

Should global prelaunch hooks be in applications addon or in core addon?
Should we split prelaunch hooks that are specific for limited amount of hosts into the hosts?

Testing notes:
There is no visible change, all should work as before.

For farm publishing update plugins accordingly.
Launch application of your choice.
Run publishing.
Run publishing through farm.
All should work.

PR partially collides with changes in https://github.com/ynput/ayon-core/pull/197 . The PR will be modified accordingly after this PR merge.

Do we need to already set reviewers for this PR, or still WIP?

Do we need to already set reviewers for this PR, or still WIP?

I forgot to set them.


Change doit in minimum working example

Metadata extraction is working, included in doit and a respective test is added.
The CI still has problems with the environment but we will fix that later.

Just as a general information, apparently there is a problem with conda-forg, which probably causes most of the errors that we have seen in the actions on Monday. I currently have the same problem e.g. if I want to install fenics in an empty environment locally. I dont think there is much else to do except wait till something gets fixed...


Cross platform frameworks

This is by specifying multiple platforms for a target in the spec, which would generate multiple targets, each with a different platform

Just to add a comment on this -- you can actually generate a cross platform framework w/o duplicating it.
http://promisekit.org/news/2016/08/Multiplatform-Single-Scheme-Xcode-Projects/

Thanks for the info @robertjpayne. As the article mentions that are some issues with such an approach. If we're generating these targets automatically anyway, we may as well do it in a recommend and supported way.
This has now been added in #35


Consider floating point widths and heights of parent node

In some cases (like having a dynamic grid layout on the page) parent nodes have floating point widths and heights. offsetWidth and offsetHeight does not consider this, it just delivers integers. This results in wrong layouting. getBoundingClientRect considers floating point values, and therefore fixes the wrong layouting.
Sidenote: According to some research i've done, getBoundingClientRect returns the same values for width and height as offsetWidth and offsetHeight, except for the case when a parent node uses transform: scale(...).

Thinking about adding a fallback to offsetWidth and offsetHeight for older browsers ... 🤔
What do you think?
https://caniuse.com/getboundingclientrect


Hey look the TermControl needs to depend on the UIA renderer

Carlos unintentionally broke the build in #2930. If you're building the entire solution, then you won't have any problems, because the UiaRenderer project will get built before the TerminalControl. However, if you're like me and you only really build the solution one project at a time, you'll find that building TerminalControl won't build UiaRenderer automagically.
This fixes that.
s/o to @Rrogntudju for catching this

I hate the solution dependency resolver. Like: the project literally says "I depend on UiaRenderer", but the build system somehow can't figure that out with additional sidecar info?

@DHowett-MSFT I know. You'd think it'd be able to build that tree itself 😑


CIM Class does not resolve correctly when specifying DSC resources in Import-DSCResource

Hi,
I am not sure if this is an issue or not as this is my first time reporting anything, so my apologies upfront if I a reporting something incorrectly. If there is a document on how to correctly report issues, please send the link my way.
Anyhow, in my example below the CIM class "MSFT_xWebAuthenticationInformation" does not resolve correctly if I specify the name of individual DSC resource(s) I am importing. This does not allow me to generate a .mof file. If I remove the individual name(s) then the CIM class works correctly and I am able to successfully create a .mof file.
`
Configuration Test {
Import-DscResource -ModuleName @{ModuleName="xWebAdministration";ModuleVersion="<IP_ADDRESS>"} -Name xWebsite

Node localhost {

    xWebsite MainHTTPWebsite
    {
        Ensure          = "Present"
        Name            = "Test"
        ApplicationPool = "MainAppPool"
        State           = "Started"
        PhysicalPath    = "C:\path\to\files"
        BindingInfo     = @(
                            @(MSFT_xWebBindingInformation
                                {
                                    Protocol              = "HTTP"
                                    Port                  =  80
                                    HostName              = "www.domain.tld"
                                }
                            );
                            @(MSFT_xWebBindingInformation
                                {
                                    Protocol              = "HTTPS"
                                    Port                  = 443
                                    HostName              = "www.domain.tld"
                                }
                            )
                          )
    }
}

}
Test -output "C:\Temp"
`
The error I receive is "PSDesiredStateConfiguration\Node : The term 'MSFT_xWebBindingInformation' is not recognized as the name of a cmdlet, function, script file, or operable program. Check the spelling of the name, or if a path was included, verify that the path is correct and try again."
Below I have removed the -name parameter which allows me to generate a .mof file.
`
Configuration Test {
Import-DscResource -ModuleName @{ModuleName="xWebAdministration";ModuleVersion="<IP_ADDRESS>"}
Node localhost {

    xWebsite MainHTTPWebsite
    {
        Ensure          = "Present"
        Name            = "Test"
        ApplicationPool = "MainAppPool"
        State           = "Started"
        PhysicalPath    = "C:\path\to\files"
        BindingInfo     = @(
                            @(MSFT_xWebBindingInformation
                                {
                                    Protocol              = "HTTP"
                                    Port                  =  80
                                    HostName              = "www.domain.tld"
                                }
                            );
                            @(MSFT_xWebBindingInformation
                                {
                                    Protocol              = "HTTPS"
                                    Port                  = 443
                                    HostName              = "www.domain.tld"
                                }
                            )
                          )
    }
}

}
Test -output "C:\Temp"`
My setup:

2012R2
PS 5.0
-xWebAdministration <IP_ADDRESS>

Sorry that nobody answered your question for so long. You did everything correct adding this issue.
I think this was a problem in how Import-DscResource was loading resource when using -Name. 🤔 I have seen it reported before in other resource modules. I think it resolved now in newer builds? I know this has nothing to with this resource module. But do you still have a problem with this, let me know.
I'm closing this for now as it is an external issue.


Support GCF through a 'initialization completed promise'

This PR is to support Google Cloud Function (GCF) through initialization stackdriver debugger through a initialization of a promise and resolve the promise after breakpointfetch being scheduled.

Opened another PR https://github.com/GoogleCloudPlatform/cloud-debug-nodejs/pull/358
Close this one.


Add getting started notebook

What I Changed
Add eoAPI generic getting started notebook
How to Test It
Read and execute the code blocks of the notebook

@vincentsarago: There is minor issue once I get call the mosaic/register endpoint, getting detail not found. I converted it to a draft until I figure this out, hopefully tomorrow.

@zacharyDez mosaic endpoint has been moved to /searches https://raster.eoapi.dev/docs#/STAC Search/register_search_searches_register_post

@vincentsarago: I updated the endpoints on the other notebooks, also.


Adding exempting method annotations

Partially fixes https://github.com/google/error-prone/issues/2881

Some of these got added in https://github.com/google/error-prone/commit/ac0bbb046f5bcbdcb1e86523812b50040339b084, I'll get the rest of this merged soon


[DOCFIX] Fix formatting in docs

alluxio-bot, merge this please

alluxio-bot, cherry-pick this to branch-2.4 please


support small caps

It'd be cool if KaTeX supported \textsc.  I think it's just a matter of adding the style font-variant: small-caps in the right place.  If someone can suggest to me the right place(s) to change in buildHTML.js, I could potentially take a crack at it sometime.

If anyone is interested in the picking this up, the PR was a good start.  There were a couple of issues that still need to be resolved, see the notes in #472.

Recently got a feature request for this.  I think the right approach is probably to add to our font, as in https://github.com/KaTeX/katex-fonts/issues/28

We would love if you could implement this!  We use KaTeX through Gradescope and would really like to mention algorithms in a nice font for our online exams.
- Design and Analysis of Algorithms teaching team at MIT

According to http://ctan.forsale.plus/fonts/amsfonts/doc/amsfndoc.pdf cmcsc10 is used for small caps.

Originally posted by @kevinbarabash in https://github.com/KaTeX/katex-fonts/issues/28#issuecomment-362783677

Any update on this?

Also hoping for this to be reviewed soon.
Small caps are important!


docs(scan): add inline docs to scan

I'm going to end up having a whole lot of these doc PRs. Should I open a PR for each one so tracking changes/editing is easier, or smash them into a big commit/series of commits in this PR?
Also, is there a convention we should use for these docs? oldRxJS docs use a variety of terms like "source/observable/sequence/stream" and "input/output/element/event" and "trigger/emit(?)". Maybe I just missed where these conventions are defined.

Thinking about PR like https://github.com/ReactiveX/RxJS/pull/989, I think it makes sense to create aggregated PR for this as initial check in, then adding separate following PR if there's missing.

Closing this in favor of #1079, unless someone prefers this PR instead.


Hide modified expense message

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/25997
PROPOSAL: https://github.com/Expensify/App/issues/25997#issuecomment-1735874400
Tests

Create a money request
Go to the transaction thread report
Change the description
Delete the request
Verify that modified expense messages are also deleted

[x] Verify that no errors appear in the JS console

Offline tests

Same as above
QA Steps

Create a money request
Go to the transaction thread report
Change the description
Delete the request
Verify that modified expense messages are also deleted

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes

[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)

[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://github.com/Expensify/App/assets/129500732/01341066-2bed-4045-a3cb-1e2355f4ddf4

Mobile Web - Chrome
https://github.com/Expensify/App/assets/129500732/b947b6e3-56c2-4b29-aaf3-c2e5978dff35

Mobile Web - Safari
https://github.com/Expensify/App/assets/129500732/1fb66a16-1c0e-4319-afe8-66a9c7bf6bf4

Desktop
https://github.com/Expensify/App/assets/129500732/5734b78d-3b9e-4ab7-acdf-9bdceccf47f7

iOS
https://github.com/Expensify/App/assets/129500732/ea8920d3-a17c-40b7-ae74-03d664592946

Android
25997.webm

https://github.com/Expensify/App/assets/25520267/187b654b-56d8-4567-9d95-60b21e63aa47
@dukenv0307 After signing out and signing in again, it's showing No activity yet.

@dukenv0307 The same with after you sign in again, No activity yet.

Sorry for the delay 🙏
@dukenv0307 Could you help resolve the conflict? I'll do another test round.

@dukenv0307 Have you tried the result in your local? The money request report is deleted in my test when it should not.
https://github.com/Expensify/App/assets/25520267/14b22d6c-d272-479b-a4e2-adb1c1aaf052

Here's the result from staging.

And the expectation should be.

The money request report is not deleted
Hide the modified actions
The alternate text in LHN should be showing No activity yet

Sorry for the delay, I'll do the review tonight 🙏

@dukenv0307 I'm testing the latest commit, but it seems the report actions are not removed after deleting the request. Could you check? Thanks!
https://github.com/Expensify/App/assets/25520267/12bcfaaa-caed-466e-b79c-d2a8a45b4621

@dukenv0307 The report actions still persist, but it was removed after refresh. Could you check? Thanks!
https://github.com/Expensify/App/assets/25520267/b4439237-1173-44cb-9051-5df70bc55c1d

@mollfpr bump on this review

The API DeleteMoneyRequest seems to be deleting the report if there's no message.
https://github.com/Expensify/App/assets/25520267/b246d4e0-f2d8-40eb-a07d-5871d3bf87b9
The offline is working fine.
https://github.com/Expensify/App/assets/25520267/42954fdb-0870-4ad2-9937-3b9282287fab

@jasperhuangg Could you help confirm it? If it's the implementation now, we can't reproduce the issue.

@dukenv0307 Based on the API response, yes.

@mollfpr We seem to delete the transaction thread report if it exists and there are not visible comments on it. Does that answer your question?

The original issue is not reproduceable because the thread report is now deleted if there's no comment, but we still have an issue with the optimistic delete request money is not deleting the thread report. Should we fix that instead?

Yeah, we should definitely make sure that the optimistic data still works as expected since we want things to behave correctly if the user is offline.


Clean up resources ? --No "delete" option for specific anchors in the DB ?

The article only describes how to completely delete all resources like for examples all the Spatial Anchors in the Cosmos DB by deleting the whole resource group.
But I'd also like to know, optimally in this demo, how to delete specific Spatial Anchors in the Cosmos DB from within the Unity app.
Are there any examples or documentation available yet ?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f5ab74c7-be94-69c4-04c9-312ed85213b7
Version Independent ID: 2fd3427b-794e-e10e-3d7e-5950647288d3
Content: Tutorial - Share Azure Spatial Anchors across sessions and devices with an Azure Cosmos DB back end
Content Source: articles/spatial-anchors/tutorials/tutorial-use-cosmos-db-to-store-anchors.md
Service: azure-spatial-anchors
GitHub Login: @RamonArguelles
Microsoft Alias: rgarcia

@TiNovTec Thank you for the valuable feedback,we are investigating the issue.

Hey @TiNovTec! I'm afraid that is beyond the scope of this tutorial and more in the web service realm. To be clear, what you've set up in this tutorial is a simple ASP.NET Core website with an Azure Cosmos DB data store to share anchor ids between devices, which is all yours. My advice would be to take a look at the ASP.NET Core and Azure Cosmos DB documentation to add an API to the sharing service that will delete an entry in your Cosmos DB. You would then need to call that API from the app.
I hope that helps, but again, that functionality is out of scope for this Azure Spatial Anchors tutorial.
One other thing that might be interesting is the Unity API to delete an anchor from Azure Spatial Anchors: CloudSpatialAnchorsSession.DeleteAnchorAsync(CloudSpatialAnchor). If you want to delete an anchor from Azure Spatial Anchors, you'll need to call that as well.

@TiNovTec We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.

@craigktreasure ( but not only )
Thank you for the hints. But I am afraid I can't agree with you!
I see two big problems:
*The code quality of the Spatial Anchor Demo for Unity is sadly not good. At least not for a tutorial / demo. Especially the user interface integration is pretty horrible. One button for all functionality with a dictionary may seem to be elegant to the author but in my opinion a demo, to show how things work, should have a simpler architecture. In general: The demo is to unnecessary too difficult to understand and even misleading. ( https://github.com/Azure/azure-spatial-anchors-samples/issues/55 )
*The demo is incomplete because the delete feature is missing. It seems like only 1/2 of the demo is done. Like someone just decided to stop the development at a very early prototype status. Without to add the missing basic delete feature and without to at least clean up the code to make it beginner friendly.


Low quality Image

Is there an existing issue for this?

[X] I have searched the existing issues

What went down?

Adding high quality image.
Adding some 3D hovering effect.
Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

@Apurv7777 assigned ✔

add high quality image instead of current


Performance problem with toJS function in Immutable 4.0.0-rc.8

What happened
Converting Immutable Map to pure JS object via toJS function in release 4.0.0-rc.9 is very slow as compared to previous release (3.8.2) and 4.0.0-rc.7
How to reproduce
Please take a look at project created below to ilustrate the issue. Running toJS on large Map object is more than 2x slower with rc.8 (as compared to rc.7).
https://github.com/hopeisnear/immutable-v4-toJS-speed-test
release 4.0.0-rc.7: TOTAL toJS: 446.493ms
release 4.0.0-rc.8: TOTAL toJS: 947.584ms
Tested on:
node: 8.9.1
npm: 5.3.0
Execution time measured using console.time.

After doing some investigating, it looks like the changes here are to blame.
This change in particular is what caught my eye; the isDataStructure function results in a lot of conditional function calls if the data is a primitive value.
Checking if the value is an object before calling isDataStructure helps quite a bit. The following results in comparable performance to 4.0.0-rc.7:
function toJS(value) {
  return (typeof value === 'object' && isDataStructure(value))
    ? Seq(value)
      .map(toJS)
      .toJSON()
    : value;
}
// > TOTAL toJS: 457.498ms

Ultimately, I think it would be better to just do the check inside of the isDataStructure function. This approach is cleaner and yields the same performance.
function isDataStructure(value) {
  return typeof value === 'object' && (isImmutable(value) || Array.isArray(value) || isPlainObj(value));
}

With that change and a little more experimenting, I managed to implement toJS that is ~33% faster than 4.0.0-rc.7 and ~69% faster than 4.0.0-rc.8 & 4.0.0-rc.9.
function toJS(value) {
  if(isDataStructure(value)) {
    value = Seq(value);
    const result = isIndexed(value) ? [] : {};
    value.forEach((v, k) => {
      result[k] = toJS(v);
    });
    return result;
  }
  return value;
}
// > TOTAL toJS: 295.861ms

Not as pretty, but probably worth the performance gains.


feature: create Kong Enterprise workspace when one doesn't exist

If a user supplies a workspace and it doesn't exist, then KIC should create it.

Done in https://github.com/Kong/kubernetes-ingress-controller/pull/429


Vim mode: '*' motion doesn't work in visual line select mode

Repro:

Open any file and enable Vim keybindings.
Enter visual line select mode through "shift-v"
Hit the * character

Expected:
The cursor should go to the next instance of the word under the cursor.
Actual:
The cursor doesn't move.

'#' symbol is not work in visual line mode. Also 'n' and 'shift-n' is unpredictable in this case.

The vim code is now being maintained at https://github.com/replit/codemirror-vim/ . If this is still important, check whether there is an issue open for it there.


iterate loops forever if too many seen in one repo

@rultor release, tag is 0.0.13

@rultor release, tag is 0.0.13

@yegor256 OK, I will release it now. Please check the progress here

@rultor release, tag is 0.0.13

@yegor256 Done! FYI, the full log is here (took me 8min)


AssetConverter & Asset Manager doesn't update assets after changing sources

What steps will reproduce the problem?
Create AssetBundle with scss source;
Config scss compilation in AssetConverter;
Publish resources once;
Change scss;
Nothing happend;
What is the expected result?
After change sources Its should update css file.
What do you get instead?
Nothing change in css
Additional info
It's check filemtime for 2 files before converting. For example assets/{hash}/main.css and assets/{hash}/main.scss.
https://github.com/yiisoft/yii2/blob/09eacd8dc1120113032976099fd07290a4d37cd3/framework/web/AssetConverter.php#L68
But!
It's check only !is_dir and forceCopy option before publish. Maybe it's should compare filemtime for source *.scss file and published *.scss file.
https://github.com/yiisoft/yii2/blob/09eacd8dc1120113032976099fd07290a4d37cd3/framework/web/AssetManager.php#L545

Q
A

Yii version
2.0.27-dev

PHP version
PHP 7.1.26-1+ubuntu14.04.1+deb.sury.org+1

Operating system
ubuntu14.04.1

Adjusting computation of last modification time may affect performance for the cases when there are many asset files in the directory.

But the issue overall makes sense to me.

You can override $publishOptions from AssetBundle
Try it in your asset bundle class:
class AppAsset extends AssetBundle {
// ....
public $publishOptions = [
'forceCopy' => true
];
// ....
}


Provide an example of testing precompiled script plugins using GradleTestKit and ProjectBuilder

Provide examples of testing the precompiled script plugins using GradleTestKit and separately using ProjectBuilder, show casing pros/cons of each approach.

Thanks for the suggestion. This is something I also want to explore and understand better.

The updated setup now shows how to test using TestKit:
https://github.com/jjohannes/gradle-project-setup-howto#testing-plugins
Thanks again for suggesting to add something in this area.

Regarding TestKit vs. ProjectBuilder: I don't think using ProjectBuilder is very useful when we talk about testing convention plugins. TestKit is closer to the real thing and I think that is what you want to do here: Test your configuration and not "unit test" small pieces of functionality. Therefore, a comparison of both approaches is out of scope of this repo. Maybe it is something to discuss elsewhere (will keep it mind if I should do more content in this area).
ProjectBuilder might be helpful when developing full scale functional plugins to write tests for Gradle types – such as tasks – which are closer to Unit Tests than Function Tests. (But even then, I never use it...)


k8s local deploy mode

Upstream SPARK-XXXXX ticket and PR link (if not applicable, explain)
What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)
Please review http://spark.apache.org/contributing.html before opening a pull request.

An elegant approach for a reasonable use case - nice work.


docs: correcting issues related to 18, 24, 25, 10, 9 in DXWT#1

PR Checklist

[ ] Leverages formatting as provided by https://squidfunk.github.io/mkdocs-material/reference/abbreviations/
[ ] Have viewed and verified edits in rendered form ensuring proper formatting

What are you changing?

    modified:   docs/APIs/indexRPS.md
    modified:   docs/General/buildRPC.md
    modified:   docs/General/createCIRAConfig.md
    modified:   docs/General/createProfileACM.md
    modified:   docs/General/createProfileCCM.md
    modified:   docs/Local/installMPS.md
    modified:   docs/assets/images/OOBManagement.png
    modified:   docs/index.md

Untracked files:
docs/assets/images/HiLevelArchitecture.png
docs/assets/images/ScallingDetails.png
docs/assets/images/ScallingHighLevel.png
Hopefully these are things that won’t effect our upcoming DXWTs. I tried to choose neutral issues.
•	Relates to DXWT #1, Issues 18, 24, 25, 10, 9, 31
•	Scaling diagrams can be used by anyone who wants to use them.
•	Modified OOBManagement diagram and index page to include discussion of Call home per Corey’s suggestion. That explanation has been notoriously complex.
•	Simplified introductory content ACM/CCM
•	For CIRA, I created a slightly less formal explanation so that it might be "accessible" to users.
•	Added cds into dirs.
Anything the reviewer should know when reviewing this PR?

Hey @kimberlyxdavis, NBD but in the future please squash your commits, I've gone ahead and fixed the master branch to squash them there.


Release latest version to npm

There is a commit with removing logs when not in debug, but this version is not released to NPM, could you release it?

There is a commit with removing logs when not in debug, but this version is not released to NPM, could you release it?

As mentioned by @MaxChal, the minified version does not have this update and the logs are always printed to the console, regardless of the option enableDebug being set to false.

And it seems to be fixed in the code at ApplicationInsightsModule.ts

@tamilvasan is it possible to release this to NPM to remove the log?


This should be updated to include the post rename code fix

When a type is renamed, it gets surrounded by a white (in dark theme) dotted box. As long as the user doesn't leave the symbol name while editing, they can use ctrl + . to invoke a code fix  to rename.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d231e9f6-7c0c-7073-6727-81a08019e589
Version Independent ID: d0078914-0fc3-e988-ce0e-559c09f0b4c8
Content: Refactor rename - Visual Studio
Content Source: docs/ide/reference/rename.md
Product: visual-studio-windows
Technology: vs-ide-general
GitHub Login: @gewarren
Microsoft Alias: gewarren

@ryzngard Thanks, I'm adding this now.


feat(workflows): implement retry backoff for activity errors

Changes

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#999  👈
#998
#996
#995
#988
#986
#974
#987
#977
#965
#964
#963
#962
#957
#956
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @MasterPtato and the rest of your teammates on  Graphite


my js or css

how i can add js or css

If you are using Fuel v1, see the documentation: http://fuelphp.com/docs/classes/asset/usage.html

@des1roer please dont spam the issue tracker. If you have questions, use StackOverflow or IRC or the forum.


Resolve the default zoom and full screen zoom ratio is not correct BUG

This PR incorporates:

The fix implemented by @luyixin in PR-193 when an image with irregular size (row/col pixel spacing are not the same) is fit to screen.

Update the "resize" example to allow setting the image row and column pixel spacing and applied when zooming or fitting to the screen

Coverage increased (+0.1%) to 63.943% when pulling 76c1af578af8880f499259067908db8a5342f5ec on PR193-default-zoom into e682990ad26037d01e9b7747f75942f76f5c62b5 on master.

thanks 410780496<EMAIL_ADDRESS>签名由 网易邮箱大师 定制 在2018年04月10日 15:48，Erik Ziegler 写道： Merged #255. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.


Link Render Mode locked to STRAIGHT and won't save SPLINE preferences

Hey hey!
Updated to your latest a couple days ago, and currently, can not get SPLINE saved as my default.
link:
https://www.dropbox.com/s/b3jnaj82lsw8i7y/Pythongosssss_Link_Render_Mode_02.mp4?dl=0

Are you getting any errors in the browser console (F12 or ctrl+shift+i on most browsers) either on startup or when changing/saving the setting?

Here's the log:
I haven't gotten MTB Roop working just yet, and that's the error below..
 WARN: This is an experimental extension. Extremely unstable. !!
Comfyroll Custom Nodes: Loaded
Davemane42 Custom Nodes: Loaded
[tinyterraNodes] Loaded
Log level: 20
[comfy_mtb] | WARNING -> cv2.ximgproc.guidedFilter not found, use opencv-contrib-python
[comfy_mtb] | ERROR -> Some nodes failed to load:
Failed to import faceenhance because ModuleNotFoundError: No module named 'basicsr'
Failed to import faceswap because ModuleNotFoundError: No module named 'insightface'
Failed to import fun because ModuleNotFoundError: No module named 'qrcode'
Failed to import image_interpolation because ModuleNotFoundError: No module named 'tensorflow'
Check that you properly installed the dependencies.
If you think this is a bug, please report it on the github page (https://github.com/melMass/comfy_mtb/issues)
[comfy_mtb] | INFO -> Loaded the following nodes:
Smart Step (mtb): Utils to control the steps start/stop of the KAdvancedSampler in percentage
Text To Image (mtb): Utils to convert text to image using a font
Styles Loader (mtb): Load csv files and populate a dropdown from the rows (à la A111)
B Box From Mask (mtb): From a mask extract the bounding box
Bounding Box (mtb): The bounding box (BBOX) custom type used by other nodes
Crop (mtb): Crops an image and an optional mask to a given bounding box
Uncrop (mtb): Uncrops an image to a given bounding box
Deep Bump (mtb): Normal & height maps generation from single pictures
Save Tensors (mtb): Debug node that will probably be removed in the future
Color Correct (mtb): Various color correction methods
Hsv To Rgb (mtb): Convert HSV image to RGB
Rgb To Hsv (mtb): Convert RGB image to HSV
Image Compare (mtb): Compare two images and return a difference image
Denoise (mtb): Denoise an image using total variation minimization.
Blur (mtb): Blur an image using a Gaussian filter.
Deglaze Image (mtb): Remove adversarial noise from images
Mask To Image (mtb): Converts a mask (alpha) to an RGB image with a color and background
Colored Image (mtb): Constant color image of given size
Image Premultiply (mtb): Premultiply image with mask
Image Resize Factor (mtb): Extracted mostly from WAS Node Suite, with a few edits (most notably multiple image support) and less features.
Save Image Grid (mtb): Save all the images in the input batch as a grid of images.
Latent Lerp (mtb): Linear interpolation (blend) between two latent vectors
Image Remove Background Rembg (mtb): -
Int To Number (mtb): Node addon for the WAS Suite. Converts a "comfy" INT to a NUMBER.
Load Image Sequence (mtb): Load an image sequence from a folder. The current frame is used to determine which image to load.
Save Image Sequence (mtb): Save an image sequence to a folder. The current frame is used to determine which image to save.
Total VRAM 24564 MB, total RAM 130813 MB
xformers version: 0.0.20
Set vram state to: NORMAL_VRAM
Device: cuda:0 NVIDIA GeForce RTX 4090 : cudaMallocAsync
WAS Node Suite: BlenderNeko's Advanced CLIP Text Encode found, attempting to enable CLIPTextEncode support.
WAS Node Suite: CLIPTextEncode (BlenderNeko Advanced + NSP) node enabled under WAS Suite/Conditioning menu.
WAS Node Suite: OpenCV Python FFMPEG support is enabled
WAS Node Suite Warning: ffmpeg_bin_path is not set in D:\ComfyUI\ComfyUI\custom_nodes\was-node-suite-comfyui\was_suite_config.json config file. Will attempt to use system ffmpeg binaries if available.
WAS Node Suite: Finished. Loaded 190 nodes successfully.
    "Success is not just about making money. It's about making a difference." - Unknown

Import times for custom nodes:
0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\SDXLAspectRatio.py
0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\sampler_tonemap.py
0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\sampler_rescalecfg.py
0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\Textnode.py
0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\advanced_model_merging.py
0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\ComfyUI_Noise
0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\ComfyUI_ADV_CLIP_emb
0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\ComfyUI_TiledKSampler
0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\ComfyUI_Comfyroll_CustomNodes
0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\ComfyUI_SeeCoder
0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\ComfyUI_Dave_CustomNode
0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\ComfyUI-QualityOfLifeSuit_Omar92
0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\ComfyUI-Custom-Scripts
0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\comfyui-animatediff
0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\images-grid-comfy-plugin
0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\ComfyUI_UltimateSDUpscale
0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\Derfuu_ComfyUI_ModdedNodes
0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\ComfyUI-Workflow-Component
0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\ComfyUI-WD14-Tagger
0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\comfy_mtb
0.2 seconds: D:\ComfyUI\ComfyUI\custom_nodes\clipseg.py
0.2 seconds: D:\ComfyUI\ComfyUI\custom_nodes\ComfyUI-Manager
0.3 seconds: D:\ComfyUI\ComfyUI\custom_nodes\comfy_controlnet_preprocessors
0.4 seconds: D:\ComfyUI\ComfyUI\custom_nodes\ComfyUI_tinyterraNodes
0.4 seconds: D:\ComfyUI\ComfyUI\custom_nodes\efficiency-nodes-comfyui
0.5 seconds: D:\ComfyUI\ComfyUI\custom_nodes\ComfyUI-Impact-Pack
0.6 seconds: D:\ComfyUI\ComfyUI\custom_nodes\ComfyUI-Vextra-Nodes
0.8 seconds: D:\ComfyUI\ComfyUI\custom_nodes\was-node-suite-comfyui
Starting server
To see the GUI go to: http://<IP_ADDRESS>:8188
QualityOfLifeSuit_Omar92::NSP ready

Ah, thats the output from your ComfyUI console rather than from your browser
Here is how to open the browser console in Chrome:
https://support.google.com/docs/thread/1873663/collecting-console-logs-chrome-browser-only?hl=en

Gotchu!
This is what I see in the console:

I have the same issue, and I don't get any error messages in the console throughout the process of changing the links/wires to 'spline' or any other type, nor during the load of a new workspace (which defaults back to 'straight).'

I have the same symptoms.

Looks like this will almost certainly be due to another extension setting the value to something else, the default I have set is spline
Form a quick search looks like: https://github.com/TinyTerra/ComfyUI_tinyterraNodes/tree/main
Has its own system for changing the link render mode via right click on the canvas, and their default is straight.
There may be other custom nodes that also change it

I uninstalled tinyTerraNodes and I still get the links reverting to 'straight.'
I had uninstalled tinyTerraNodes and anything else reporting an issue of loading in the Import times for custom nodes list, which included ComfyUI_Custom-Scripts.
Then after restart there were no reported import issues.
Then I re-installed Custom-Scripts only.
No reported import issue after that.
But the links revert to 'straight,' now.

Same here, as of this morning.
On Wed, Aug 2, 2023, 1:50 PM Aunalise @.***> wrote:

I uninstalled tinyTerraNodes and I still get the links reverting to
'straight.'
I had uninstalled tinyTerraNodes and anything else reporting an issue of
loading in the Import times for custom nodes list, which included
ComfyUI_Custom-Scripts.
Then after restart there were no reported import issues.
Then I re-installed Custom-Scripts only.
No reported import issue after that.
But the links revert to 'straight,' now.
—
Reply to this email directly, view it on GitHub
https://github.com/pythongosssss/ComfyUI-Custom-Scripts/issues/30#issuecomment-1662782414,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AOKR6W6CJVKRBHMLVBU3MJ3XTKOP7ANCNFSM6AAAAAA3AAJEWQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

Can you please try changing the value using the tinyTerraNodes option, another user on the Comfy element channel has confirmed their issue was due to that overriding my setting

tinyTerraNodes overrides the settings of the Pythongosssss Custom-Scripts extension.
It defaults to 'straight,' not 'spline' probably due to uninitialized value of '0' equalling 'straight' links.
This can be set permanently to 'spline' by going to a node, and right-clicking right on a node-link dot.
Select Link Style (ttN) and then 'Spline'
The links will update to the chosen style upon the first click on the workspace.
See below:

tinyTerraNodes overrides the settings of the Pythongosssss Custom-Scripts extension. It defaults to 'straight,' not 'spline' probably due to uninitialized value of '0' equalling 'straight' links. This can be set permanently to 'spline' by going to a node, and right-clicking right on a node-link dot. Select Link Style (ttN) and then 'Spline' The links will update to the chosen style upon the first click on the workspace.
See below:

This fixed it for me too! Hopefully this concludes the issue for everyone

Thumbs!
Thanks for the screenshot, as well. I had no idea! :)
Closing...


Show target language on REPL mode

The prompt shows the SOURCE language ("Italiano> "), but not the target language.
Config the prompt to show both the SOURCE and TARGET languages ("Italiano:English> ")
Thanks

I don't remember if it's documented, but this can be easily done by setting your own theme file.
If you don't have a theme, create a new file such as ~/.translate-shell/my_prompt.trans with following content:
{
 :fmt-prompt "%s:%t> "
}

(%s for names of source languages, %t for names of target languages, %S for English names of source languages, %T for English names of target languages, etc.)
Then add this theme to your config file:
{
 :theme "my_prompt.trans"
}

If you already have a theme, then just change that ":fmt-prompt" value to the wanted prompt string.

The command to set the source language to automatic is
:set sl auto

Simply :pt will change only the target language to pt and leave the source language as is. Similarly, it: will change only the source language to it and leave the target language as is. This was the intended behavior, I think, as it enables you to change only the source or the target lang conveniently, without having to specify the full language pair.


merge from template-kronos-app

package.json

chore(deps): add ^13.0.4 remove ^13.0.3 (devDependencies.npm-pkgbuild)

:tada: This PR is included in version 1.11.0 :tada:
The release is available on:

npm package (@latest dist-tag)
v1.11.0
GitHub release

Your semantic-release bot :package::rocket:


Support Json Object with non-unique keys

Circe doesn't support duplicate key names in JSON objects like:
{
  "foo": 1,
  "bar": 2,
  "foo": 3
}

There are several tools that require this kind of functionality and it's causing problems not being able to utilize it.

@darkfrog26 I'm not sure circe will ever support multi-valued keys (although I've considered it), but one much easier solution would be to have a special parser that would parse this case as { "foo": [1, 3], "bar" }. Would that work for you?

@darkfrog26 if all keys are String and values are Int then you can use Seq[(String, Int)] to keep the ordering untouched.


need article on how the razor view engine discovery process works

See https://github.com/aspnet/Docs/pull/1135/

I think this is a duplicate of #137


At least read the BogoMIPS figure on ARM

Use the capitalization of BogoMIPS that is used by ARM architecture CPUs.

Pretty much a dup of #46643

Pretty much a dup of #46643


Set TARGET_OS=Windows when building for Windows

As documented in https://luajit.org/install.html. Fixes cross-compiling from Linux to Windows.
See https://github.com/khvzak/mlua/issues/133.
Hopefully this doesn't break native Windows build; let's see what the CI says.
Ideally I guess the Linux->Windows cross-compile should be added to the CI as well.

I believe this is no longer needed, TARGET_SYS is derived from TARGET env


temporary workaround to compile failure on CentOS

This PR is just a workaround to enable Peng to make progress with other build issues.
The compile error that he is running into needs to be fixed. Basically the new GCC (in combination with the machine on which we were doing the build) enables the support for AVX512F (SIMD?) instructions. As a consequence code within the Eigen/src/Core/arch/AVX512/ dir becomes enabled and it seems that it needs to be updated for Eigen::half support as it is lacking the routine to cast a vector of floats to packet of halfs (using simd instructions?). We may run into other similar compile errors once we fix this one.

Could you help briefly summarize additional changes needed to tame CentOS?

For #2, we have been using -march=haswell in TF1.3.
https://github.com/ROCmSoftwarePlatform/tensorflow/commit/615e6cd4cc3b5c52080726e709a1bebeb421fbd2


[QUESTION] SkElement or skiaSharp is not working in some windows PC's

We used skia in our project to draw lines on . a bitmap based on user Input(at runtime). We then used the timer to trigger skElement PaintSurface Event( by calling InvalidateVisual() API). In the PaintSurface Event handler, we draw the skBitmap on the canvas.
This approach is working for most of the windows users. But only a couple of customer this approach is not working.
We tried to look for any settings change but couldn't find any.
We tried below skia's sample project which updates the frame number. This example project working fine for us i.e, we could see the frame number keeps increasing. This sample project also is not working for our customers. The frame number stops with number 1 and is not updating further.
https://lostindetails.com/articles/skiasharp-with-wpf
Could you please help us to understand why above solution is not working in some PC's please?
Please let us know if you are in need of more information.
Thanks

Excuse me, have you solved this problem
I encountered the same problem. I tested the program on my laptop and found that using Invalidate Visual cannot re render, but changing the window size can be done.
When I test on a desktop computer, he can trigger a re rendering using InvalidateVisual
Notebook is i5-1135G7, XE gpu, without independent graphics card
Desktop has a separate graphics card

Issue has been resolved.
This issue is not a Skia issue.
It was a VGA Driver issue.
laptop model : SAMSUNG NT950XDB
VGA : Intel(R) Iris(R) Xe Graphics
[before driver version]
<IP_ADDRESS>15(2021-03-22 AM 9:00:00)
[after driver version]
<IP_ADDRESS>77(2023-07-24 AM 9:00:00)


Create a job to import stores

Is your feature request related to a problem? Please describe.
Accepting stores should be imported from CSV the same way as in SozialPass
Additional context
TBD?

this will be done instead
#1475


Provide a way to customize the landing page

At the moment we have the default Shiny application. There is also a nginx site content deployed to the server, but never gets used as we remove the default site.

Done!


Add Swift application plugin reference chapter

Context

Add Swift Application plugin reference chapter.
Gradle Core Team Checklist

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation
[ ] Recognize contributor in release notes

It is scheduled to be merged into the DSL reference branch but that is just to namespace the review and make sure the merge happens in order.

merged here https://github.com/gradle/gradle/commit/407e1089f57a5fe19361e13205e9548879f94a78


We are investigating a potential issue introduced by this change. To be safe, we are reverting the changes while we look into it.


Create a readme for the core package

@Dhaiwat10 happy to take this up ^ - trying to use web3-ui/core in a side-project, will be digging through the code anyway :)

@akshatamohanty Thanks!! ❤

Feel free to use the README for the components package as a reference.

@Dhaiwat10 raised a PR - https://github.com/Developer-DAO/web3-ui/pull/201
btw, what's the difference between components and core - both seem to be a set of React components right now?

Hey @akshatamohanty, happy new year!
The main difference between those packages is that the core package is supposed to be plug-and-play & opinionated. The components package is supposed to just provide the general UI layout but it won't 'fetch' anything or 'do' anything for you. Basically: if you want to get started quickly -> go with core, if you want to have more control -> go with components and/or hooks.
As more stuff gets added to the core package, this will hopefully become more clear.


exports.Actions is undefined?

Hi there,
I tried using your constants from Actions (which seem to be exported), but it seems that it is undefined.
Is there another way to use the same consts?

How do you import them? This should work:
import { Actions } from 'history';
const { PUSH, REPLACE, POP } = Actions;

hi @jmurzy,
That's exactly what I tried. I'm getting this error.
Uncaught TypeError: Cannot read property 'PUSH' of undefined

This was fixed on v3 in https://github.com/ReactTraining/history/commit/b3db5e14b2b707993627833af3089ec09007376f.


tr-links of lower size if no torrent link & some other stuff

tr-links: Reduced size if no torrent link, but should be aligned with all the others
Also fix padding that didn't apply because of missing !important
last fixes for refine that visually somewhat broke at some very specific resolution
On IE & low res, refine & profile user to be quite broken because of display: inline-grid not being supported, it now works

Coverage remained the same at 24.341% when pulling 15f0996367dc0ce3f95a400b0f3a1a1d9a2d8f92 on Kiloutre:patch-22 into ab9e3906e2d7cbe51251e3440d279eddd6bbb14e on NyaaPantsu:dev.

Coverage remained the same at 24.341% when pulling 15f0996367dc0ce3f95a400b0f3a1a1d9a2d8f92 on Kiloutre:patch-22 into ab9e3906e2d7cbe51251e3440d279eddd6bbb14e on NyaaPantsu:dev.

Coverage remained the same at 24.341% when pulling 15f0996367dc0ce3f95a400b0f3a1a1d9a2d8f92 on Kiloutre:patch-22 into ab9e3906e2d7cbe51251e3440d279eddd6bbb14e on NyaaPantsu:dev.

Coverage remained the same at 24.341% when pulling 15f0996367dc0ce3f95a400b0f3a1a1d9a2d8f92 on Kiloutre:patch-22 into ab9e3906e2d7cbe51251e3440d279eddd6bbb14e on NyaaPantsu:dev.

Coverage remained the same at 24.341% when pulling 958996c850cad8958bae725cbeb1dba9b9996860 on Kiloutre:patch-22 into ab9e3906e2d7cbe51251e3440d279eddd6bbb14e on NyaaPantsu:dev.

Coverage remained the same at 24.341% when pulling 958996c850cad8958bae725cbeb1dba9b9996860 on Kiloutre:patch-22 into ab9e3906e2d7cbe51251e3440d279eddd6bbb14e on NyaaPantsu:dev.

Coverage remained the same at 24.341% when pulling 958996c850cad8958bae725cbeb1dba9b9996860 on Kiloutre:patch-22 into ab9e3906e2d7cbe51251e3440d279eddd6bbb14e on NyaaPantsu:dev.

Coverage remained the same at 24.341% when pulling<PHONE_NUMBER>7a7aa8ccbff56463cc674e86e8bb04 on Kiloutre:patch-22 into ab9e3906e2d7cbe51251e3440d279eddd6bbb14e on NyaaPantsu:dev.

Coverage remained the same at 24.341% when pulling 4c980897ac3d979b7b105f8c07b1e00ea4625564 on Kiloutre:patch-22 into ab9e3906e2d7cbe51251e3440d279eddd6bbb14e on NyaaPantsu:dev.

Coverage remained the same at 24.341% when pulling 4c980897ac3d979b7b105f8c07b1e00ea4625564 on Kiloutre:patch-22 into ab9e3906e2d7cbe51251e3440d279eddd6bbb14e on NyaaPantsu:dev.

Coverage remained the same at 24.341% when pulling 744abd52780ea33b8c0d287e1dacf3452c2ce2f1 on Kiloutre:patch-22 into ab9e3906e2d7cbe51251e3440d279eddd6bbb14e on NyaaPantsu:dev.

Coverage remained the same at 24.341% when pulling 744abd52780ea33b8c0d287e1dacf3452c2ce2f1 on Kiloutre:patch-22 into ab9e3906e2d7cbe51251e3440d279eddd6bbb14e on NyaaPantsu:dev.

Coverage remained the same at 24.341% when pulling 024cdf589ab219233b0274a18e99cba22685c1d5 on Kiloutre:patch-22 into ab9e3906e2d7cbe51251e3440d279eddd6bbb14e on NyaaPantsu:dev.

Coverage remained the same at 24.341% when pulling 024cdf589ab219233b0274a18e99cba22685c1d5 on Kiloutre:patch-22 into ab9e3906e2d7cbe51251e3440d279eddd6bbb14e on NyaaPantsu:dev.

Coverage remained the same at 24.341% when pulling 024cdf589ab219233b0274a18e99cba22685c1d5 on Kiloutre:patch-22 into ab9e3906e2d7cbe51251e3440d279eddd6bbb14e on NyaaPantsu:dev.

Coverage remained the same at 24.341% when pulling c9b219dc32db25177e76bc64e86914e002c5f61e on Kiloutre:patch-22 into ab9e3906e2d7cbe51251e3440d279eddd6bbb14e on NyaaPantsu:dev.

Coverage remained the same at 24.341% when pulling 63422f2e53650957c392a9c1747430639177e3bb on Kiloutre:patch-22 into 88bea245f147fc39afdd02e47489adb14f811a99 on NyaaPantsu:dev.

Coverage remained the same at 24.341% when pulling e9793c7c3b195eca05f0c213152d4e4638ee09ec on Kiloutre:patch-22 into ff2efb347d7373c3646c50b5d7829e294a1d257a on NyaaPantsu:dev.


Inconsistency between Documentation & Code @ Event Name

The documentation in section Events is not consistent with the code.
Documentation tells that on stop/pause an event named 'stop' is send.
What's being really send out is an event named 'stoped'. See Line 151 in countdown.js
Maybe you want to correct the documentation here :-)

Great catch man! Thank you for that!


i18n for zh-HANS

i18n for zh-HANS

Hello, @itcbx! Thank you for contributing. Could you sign our CLA so that I can merge your pull request?

@Imperadeiro98 OK，sign up already.

Thanks


Please commit Russian translation

Hello, I've completed the translation Jitsi and Jitsi Meet to russian language. Please commit my changes in next build!
URL: http://translate.jitsi.org/ru/

Committed, thanks! Could you please write to the dev-mailinglist next time instead of opening an issue?


Some metrics are missing in v3

Welcome!

[X] Yes, I've searched similar issues on GitHub and didn't find any.
[X] Yes, I've searched similar issues on the Traefik community forum and didn't find any.

What did you do?
I'm using traefik v3.0.1 while debugging my application, I noticed that traefik is missing some metrics and it seems it started with v3.
I noticed that the following metrics are missing:
traefik_config_reloads_failure_total
traefik_config_last_reload_failure
traefik_entrypoint_open_connections
traefik_service_open_connections
traefik_service_retries_total
traefik_service_server_up

In particular, I was most interested in
traefik_service_open_connections

but these metrics are not in the versions v3.0.0 , v3.0.1 , v3.1.0
In version v2.11.6 there is
What did you see instead?
There is no part of the metrics in versions v3+
What version of Traefik are you using?

v3.0.0
v3.0.1
v3.1.0
v2.11.6

What is your environment & configuration?
Static:
entryPoints:
  web:
    address: ":8081"

api:
  dashboard: true
  insecure: true

metrics:
  prometheus: {}

providers:
  file:
    directory: conf
    watch: true

Dynamic:
http:
  services:
    test:
      loadBalancer:
        servers:
          - url: http://<IP_ADDRESS>:8080
  routers:
    test:
      rule: "PathPrefix(`/`)"
      entryPoints:
        - "web"
      service: "test"

If applicable, please paste the log output in DEBUG level
No response

Hello @jidckii,
Metrics have been reworked in v3, and notably with https://github.com/traefik/traefik/pull/9656.
The equivalent to traefik_service_open_connections metrics is now a global metric: traefik_open_connections.
We are keeping this issue as a request for a fix of our documentation in that regard in the migration guide.

Additionally to my previous comment:
The traefik_config_reloads_failure_total and traefik_config_last_reload_failure metrics have been suppressed since they could not be implemented: https://github.com/traefik/traefik/pull/9660.
The traefik_service_retries_total metric, it has never been implemented as well: https://github.com/traefik/traefik/blob/6b1adabeb593446351b94966f6673058ab58564f/pkg/server/middleware/middlewares.go#L333
Regarding this one, I think we could stop documenting it, or fix it.
The traefik_service_server_up metric should work for service configured with healthcheck.


Georeferenced field

Georeferenced field is being filled with data from an unknown source:
https://sandwich.taxonworks.org/tasks/collection_objects/browse?collection_object_id=1273163
Georeferenced | 2021-06-02 | Georeference::VerbatimData | 237806
Where did the value "237806" originate?

Quick response, I will dig further.  That's the internal ID of the Georeference I think.  It's generated by a crummy render/model method georeference_tag in georeference_helpers.rb I think.


Snapshot: "Could not find option 'xcconfig' in the list of available options"

New Issue Checklist

[x] Updated fastlane to the latest version
[x] I read the Contribution Guidelines
[x] I read docs.fastlane.tools
[x] I searched for existing GitHub issues

Issue Description

I am trying to get started with Snapshot. I've successfully done the snapshot init, but when I try to run fastlane snapshot and select a target, I get
Building and running project - this might take some time...
[17:57:42]: snapshot run 1 of 64
[17:57:42]: Patching '/Users/james/Library/Preferences/com.apple.iphonesimulator.plist' to scale simulator to 100%
[17:57:46]: Could not find option 'xcconfig' in the list of available options: workspace, project, devices, languages, launch_arguments, output_directory, ios_version, skip_open_summary, clear_previous_screenshots, reinstall_app, erase_simulator, localize_simulator, app_identifier, add_photos, add_videos, buildlog_path, clean, configuration, xcpretty_args, sdk, scheme, number_of_retries, stop_after_first_error, derived_data_path
[17:57:46]: Tests failed, re-trying 1 out of 2 times
Last time I tried to get this to work (before giving up), I think it worked in 1.48.0 and failed in 1.49.0 or so, but I am not able to get those to work for different reasons now.
Complete output when running fastlane, including the stack trace and command used

~/git/xxx: fastlane snapshot
[✔] 🚀
[17:57:39]: Successfully loaded '/Users/xxx/git/xxx/fastlane/Snapfile' 📄
+-----------+----------------------------------------------+
|        Detected Values from './fastlane/Snapfile'        |
+-----------+----------------------------------------------+
| languages | ["en-US", "de-DE", "it-IT", ["pt", "pt_BR"]] |
+-----------+----------------------------------------------+
[17:57:39]: Successfully loaded '/Users/james/git/gss-app/fastlane/Snapfile' 📄
+-----------+----------------------------------------------+
|        Detected Values from './fastlane/Snapfile'        |
+-----------+----------------------------------------------+
| languages | ["en-US", "de-DE", "it-IT", ["pt", "pt_BR"]] |
+-----------+----------------------------------------------+
Select Scheme:

xxx
yyy
?  1

+----------------------------+------------------------------------------------------------------------------------------+
|                                              Summary for snapshot 2.0.0                                               |
+----------------------------+------------------------------------------------------------------------------------------+
| workspace                  | ./xxx.xcworkspace                                                           |
| scheme                     | UITests-Live                                                                             |
| devices                    | ["iPhone 6", "iPhone 6 Plus", "iPhone 7", "iPhone 7 Plus", "iPhone 8", "iPhone 8 Plus",  |
|                            | "iPhone SE", "iPhone X", "Simulator", "iPad Air", "iPad (5th generation)", "iPad Pro     |
|                            | (9.7-inch)", "iPad Pro (12.9-inch)", "iPad Pro (12.9-inch) (2nd generation)", "iPad Pro  |
|                            | (10.5-inch)", "iPad (6th generation)"]                                                   |
| output_directory           | /Users/xxx/git/xxx/fastlane/screenshots                                            |
| languages                  | ["en-US", "de-DE", "it-IT", ["pt", "pt_BR"]]                                             |
| launch_arguments           | [""]                                                                                |
| skip_open_summary          | false                                                                                |
| clear_previous_screenshots | false                                                                                |
| reinstall_app              | false                                                                                |
| erase_simulator            | false                                                                                |
| localize_simulator         | false                                                                                |
| buildlog_path              | ~/Library/Logs/snapshot                                                                  |
| clean                      | false                                                                                |
| number_of_retries          | 1                                                                                |
| stop_after_first_error     | false                                                                                |
| xcode_path                 | /Applications/Xcode.app                                                                  |
+----------------------------+------------------------------------------------------------------------------------------+
[17:57:42]: Building and running project - this might take some time...
[17:57:42]: snapshot run 1 of 64
[17:57:42]: Patching '/Users/xxx/Library/Preferences/com.apple.iphonesimulator.plist' to scale simulator to 100%
[17:57:46]: Could not find option 'xcconfig' in the list of available options: workspace, project, devices, languages, launch_arguments, output_directory, ios_version, skip_open_summary, clear_previous_screenshots, reinstall_app, erase_simulator, localize_simulator, app_identifier, add_photos, add_videos, buildlog_path, clean, configuration, xcpretty_args, sdk, scheme, number_of_retries, stop_after_first_error, derived_data_path

Environment

✅ fastlane environment ✅
Stack

Key
Value

OS
10.13.5

Ruby
2.5.1

Bundler?
true

Git
git version 2.18.0

Installation Source
~/.rbenv/versions/2.5.1/bin/fastlane

Host
Mac OS X 10.13.5 (17F77)

Ruby Lib Dir
~/.rbenv/versions/2.5.1/lib

OpenSSL Version
OpenSSL 1.0.2o  27 Mar 2018

Is contained
false

Is homebrew
false

Is installed via Fabric.app
false

Xcode Path
/Applications/Xcode.app/Contents/Developer/

Xcode Version
9.4.1

System Locale

Variable
Value

LANG
en_US.UTF-8
✅

LC_ALL

LANGUAGE

fastlane files:
`./fastlane/Fastfile`
[redacted, it's a mess]

fastlane gems

Gem
Version
Update-Status

fastlane
2.101.1
✅ Up-To-Date

snapshot
2.0.0
✅ Up-To-Date

Loaded fastlane plugins:
No plugins Loaded
Loaded gems

Gem
Version

bundler
1.16.3

rake
12.3.1

CFPropertyList
3.0.0

public_suffix
2.0.5

addressable
2.5.2

atomos
0.1.2

babosa
1.0.2

curb
0.9.6

fastimage
2.1.3

colored
1.2

highline
1.7.10

commander-fastlane
4.4.6

dotenv
2.5.0

emoji_regex
0.1.1

excon
0.62.0

multipart-post
2.0.0

faraday
0.15.2

unf_ext
<IP_ADDRESS>

unf
0.1.4

domain_name
0.5.20180417

http-cookie
1.0.3

faraday-cookie_jar
0.0.6

faraday_middleware
0.12.2

gh_inspector
1.1.3

jwt
2.1.0

memoist
0.16.0

multi_json
1.13.1

os
1.0.0

signet
0.8.1

googleauth
0.6.4

httpclient
2.8.3

mime-types-data
3.2016.0521

mime-types
3.1

declarative
0.0.10

declarative-option
0.1.0

uber
0.1.0

representable
3.0.4

retriable
3.1.2

google-api-client
0.23.4

json
2.1.0

mini_magick
4.5.1

multi_xml
0.6.0

plist
3.4.0

rubyzip
1.2.1

security
0.1.3

naturally
2.2.0

simctl
1.6.5

slack-notifier
2.3.2

terminal-notifier
1.8.0

unicode-display_width
1.4.0

terminal-table
1.8.0

tty-screen
0.6.5

tty-cursor
0.6.0

tty-spinner
0.8.0

word_wrap
1.0.0

claide
1.0.2

colored2
3.1.2

nanaimo
0.2.6

xcodeproj
1.5.9

rouge
2.0.7

xcpretty
0.2.8

xcpretty-travis-formatter
1.0.0

badge
0.9.1

build-environment
1.1.4

build-files
1.3.0

process-group
1.1.0

rainbow
2.2.2

build-graph
1.0.6

build-makefile
1.0.1

process-pipeline
1.0.1

graphviz
1.0.0

build
1.1.1

io-console
0.4.6

xcov
1.4.3

generated on: 2018-08-06

@blastum Heyyy 👋 This is really weird because xcconfig totes an option and was added in version 2.86.0 (https://github.com/fastlane/fastlane/pull/12067/files). Your fastlane env shows that you have 2.101.1 but it doesn't seem like 2.101.1 is being used when you are calling fastlane because your output has Summary for snapshot 2.0.0 when it really should say Summary for snapshot 2.101.1. So things should work once you figure out why fastlane 2.101.1 isn't being run 😊


Update CloudWatch Metrics for AWS IoT SiteWise

Update CloudWatch Metrics for AWS IoT SiteWise

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hi @Deepali1211 , thanks for the pr! Based on the AWS docs, it looks like the the old Gateway metrics were also valid, so I think we should put those back and have both the Gateway and the IoTSiteWisePublisher metrics. Also could you add the other metrics from the docs so that we have all of them?

I have added all the Version 1 and Version 2 metrics.

Done.
Also, there are entries like "OpcUaCollector.Heartbeat" and "OPCUACollector.Heartbeat".
Considering keys to be case insensitive, I have kept single entry.
Do you want me to keep metrics with both keys OpcUaCollector and OPCUACollector?

Done. Also, there are entries like "OpcUaCollector.Heartbeat" and "OPCUACollector.Heartbeat". Considering keys to be case insensitive, I have kept single entry. Do you want me to keep metrics with both keys OpcUaCollector and OPCUACollector?

Thanks! I think we've found in the past that metrics are case sensitive, so can you keep both keys?

Added two metrics with OPCUACollector as per their docs.
They only have two metrics with OPCUACollector and have duplicate entries with OpcUaCollector.


fix registerGDPRConsent hook

Questions
Answers

Description?
If there is only one module using the registerGDPRConsent hook, it is ignored

Type?
bug fix

BC breaks?
no

Deprecations?
no

Fixed ticket?
Fixes PrestaShop/Prestashop#29513

How to test?
See PrestaShop/Prestashop#29513

Thanks @rsoulard-prolaser and @sLorenzini


Scoped tailwind preflight - website styles fix

I copied tailwind's preflight to a custom base.css and wrapped it in .squiggle { ... }

and tailwindcss-forms base styles too
wrapping it with postcss-nested didn't work, unfortunately: https://github.com/tailwindlabs/tailwindcss/blob/3f2e570ed49f1863a3b0d2a4cb3634fe2b1561d6/src/lib/detectNesting.js#L13
but preflight doesn't update often, and we don't have to update it at all, so this is not that bad

css specificity rules caused an annoying bug with react-ace, where .squiggle * { border-width: 0 } turned out to have a higher priority than .ace_cursor { border-left: 2px }, so cursor got hidden; I patched it with some custom css
.squiggle selector is added to all other tailwind styles with the important selector config option (this might not even be necessary, but might help with integrating squiggle-components to the websites with custom tailwind configs)
<SquiggleContainer> adds a wrapper <div className="squiggle"> once (see the implementation)

so it won't hurt much to add it to every squiggle component, but for now I only added it to SquiggleEditor and SquigglePlayground
since storybook uses all tiny squiggle components, I added a decorator to all stories

this PR also adds clsx dep to squiggle-components; this is accidental, I initially tried an approach with a custom tw function and it made sense to adopt clsx at the same time; then I removed tw but didn't want to roll back the code for clsx I already written

Note: run yarn run format in the correct packages, to fix the linting issue

Yeah, thanks! I prettierignored base.css, though, since formatting it would just complicate diffs with upstream in the future.

This seems pretty strong to me. I definitely agree that some things are kind of hacky, but given the complexity and time constraints, the solutions seem justified. I appreciate the explanations of in the story and in some of the codebase. Nice work!


App crash when rerender:  Exception thrown while executing UI block: * -[__NSDictionaryM setObject:forKeyedSubscript:]: key cannot be nil

Summary
I'm trying to build a map with clustering. At first, render everything works fine, but as soon as a user tries to move map or zoom, I'm recalculating markers/clusters postions, and app breaks on iOS with error: Exception thrown while executing UI block: * -[__NSDictionaryM setObject:forKeyedSubscript:]: key cannot be nil

Reproducible sample code
export const Map: React.FunctionComponent = () => {
    const { styles } = useStyles(stylesheet)
    const mapData = useMapData()
    const [region, setRegion] = useState<Region>(INITIAL_REGION)
    const [, setZoomLevel] = useState(0)
    const [points] = useClusterer(mapData, MAP_DIMENSIONS, region, {
        maxZoom: 15,
        radius: 20,
        minPoints: 5,
    })

    const handleRegionChange = async (newRegion: Region) => {
        setRegion(newRegion)
        setZoomLevel(Math.log2(360 * ((Measurements.WindowWidth / 256) / region.longitudeDelta)) + 1)
    }

    return (
        <MapView
            style={styles.map}
            provider={PROVIDER_GOOGLE}
            initialRegion={INITIAL_REGION}
            onRegionChangeComplete={handleRegionChange}
        >
            {points.map(item => (
                <Point
                    key={item.properties?.cluster_id ?? `point-${item.properties?.id}`}
                    item={item}
                />
            ))}
        </MapView>
    )
}

Steps to reproduce

View map
Zoom in and move

Expected result
I would expect to rerender map markers without crashing.
Actual result
App crash
React Native Maps Version
1.1.0
What platforms are you seeing the problem on?
iOS (Google Maps)
React Native Version
0.68.2
What version of Expo are you using?
Not using Expo
Device(s)
iPhone 13 (15.5)
Additional information
No response

Uploading Simulator Screen Recording - iPhone 13 - 2022-07-24 at 16.08.55.mp4…

https://user-images.githubusercontent.com/28902144/180651000-5fc80507-7ba5-45e8-a89f-0625de96af23.mp4

Hi @schriker 👋. Thank you for reporting this. Can I have you trim down the sample code to exclude anything not related to reproducing the issue, and include everything needed to run it as is? :) I can't run your custom hooks etc. :)

same issue here

I use Markers with childrens for this cluster markers with numbers, if I change them to regular markers the App doesn't crash. It looks like iOS have some problems with rendering markers with childrens?

Ok, it looks like in my case using Animated.View with layout animation caused this issue, after removing it everything works fine.
Code that caused this problem:
return (
    <Animated.View
        style={{
            ...styles.wrapper,
            ...containerStyles
        }}
        exiting={FadeOut.duration(200)}
    >
        {children}
    </Animated.View>
)

I'm glad you got it working 👍

I have the same issue, when Marker has children in it.
I want to render a custom marker with Text and icon in it.
This is how my code looks like:
<MapView
        initialRegion={INITIAL_REGION}
        style={{ flex: 1 }}
        provider={PROVIDER_GOOGLE}>
        {eventLocations?.map((item, index) => {
          const [longitude, latitude] = item.location.coordinates;
          return (
            <Marker coordinate={{ latitude, longitude }}>
              <RenderSvg
                xml={svg.currentLocationMarker}
                width={42}
                height={42}
              />
              <Text>{item?.category}</Text>
            </Marker>
          );
        })}
      </MapView>

The issue happens when i switch to another component in the same screen after the map is loaded.
When i remove the children from the marker, it works fine.
When i remove provider={PROVIDER_GOOGLE} it works fine, even if there is children in the Marker.
I'm not using Animated anywhere in the screen.

i got the same problem and i did not find any solution so i used apple map
in ios instead google map
On Tue, Nov 22, 2022 at 1:08 PM Akash @.***> wrote:

I have the same issue, when Marker has children in it.
I want to render a custom marker with Text and icon in it.
This is how my code looks like:
<MapView
initialRegion={INITIAL_REGION}
style={{ flex: 1 }}
provider={PROVIDER_GOOGLE}>
{eventLocations?.map((item, index) => {
const [longitude, latitude] = item.location.coordinates;
return (
<Marker coordinate={{ latitude, longitude }}>

{item?.category}

);
})}

The issue happens when i switch to another component in the same screen
after the map is loaded.
When i remove the children from the marker, it works fine.
When i remove provider={PROVIDER_GOOGLE} it works fine, even if there is
children in the Marker.
I'm not using Animated anywhere in the screen.
—
Reply to this email directly, view it on GitHub
https://github.com/react-native-maps/react-native-maps/issues/4351#issuecomment-1323234319,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AOMKLVMV4ZLM4MHE7IH5P5TWJRZ6BANCNFSM54PUC74A
.
You are receiving this because you commented.Message ID:
@.***>

I also had to use apple map in my project

@Akash-Hubspire have you found a fix for the issue, getting exactly the same issue.

@Simon-TechForm Please reopen the issue, please


Add grants program to community section

Inspired by the FLIP section, we should add grant wishlists to the portal

https://github.com/onflow/developer-grants

https://github.com/onflow/docs/issues/258


[Question] Is there way to try..catch error in browser?

Is there way to handle Abort in browser with try..catch block?

Why do you want to do this?

To handle errors on frontend, nvm i found solution. Is there way to throw Abort with custom status atleast not with 403?

Is there way to throw Abort with custom status atleast not with 403?

Why do you want to do this? The idea of Telefunc is you shouldn't care about these kinds of things. (But the docs may be lacking to properly explain common use cases.)

Currently, telefunc throws 403 and 500 errors, idea is to send 400 and 500 for different logic errors instead of sending the exact 403 code and 500 for internal issues. For example for access denied I wanna call abort with 403, for validation abort with logic code, and for fatal i will leave it for telefunc handler and i expect it will throw 500 .

Added docs about error handling: https://telefunc.com/error-handling.
Let me know if you have questions!


Handle setdefault on proxy dicts

With 2.0.0, the following pattern I was using is broken:
command.environment.setdefault('variables', []).append(value)

The idea here is that command['environment']['variables'] is a list of dicts, but any part of that path might or might not exist. In 1.x, the command.environment would actually insert a environment key into command. In 2.0.0, the environment dict is created but not inserted into the parent, because there is no setitem.
Proposal: all mutating member functions of Dict (specifically including setdefault) should insert into the parent.

Hey @bmerry, thanks for reporting this.
This is interesting, I've never actually used setdefault, and I tried reading up on the implementation in CPython. Anyways, I ended up implementing something in #84 which I think works. Please have a look.

Thank you again @bmerry. 👍


"Send" button should also react on "Enter" key.

"Send" button should also react on "Enter" key.
As stated by comments by jeetland.

Fix will be shipped with v0.3


Try to fix sourcemaps with urls

Previous to this sourcemap's and filenames were only considered as urls
when sourcemap location was calculated for the purposes of loading it
but when it was reported (for example in a stacktrace) it will just path
which leads to URLs with scheme getting mangled.
Also fixes some cases where the source map loader will not get a url
even though it should've

I have tested this predominantly with my WIP sourcemap support for k6, so there are likely bugs, although hopefully, the tests would have caught most.
From my understanding, the sourcemaps will always parse as URL and if you have sourcemaps they will again always parse as url so only the base name has a chance of being something not URL-y and the previous code as well likely didn't work great on windows (backwards slashes and C:/ are PITA from my experience tackling them in k6, my advice is - just require URLs :P ), but there might need to be some more catching of corner cases in those cases.
I also decided against DRY-ing the code as I would've needed to export the parsing somewhere and there are some ... specifics ;)

Hi. I don't have much time to look into this closely, but I think it should work as follows:

If the base is a URL and the location is not absolute, it should be converted into a URL path (using filepath.ToSlash()) and resolved against the base.
If the base is not a URL and the location is not absolute, it should be resolved against the base using the current OS rules.

Not sure I understand the problem with DRY. To me it makes perfect sense to keep this in one place.

If the base is a URL and the location is not absolute, it should be converted into a URL path (using filepath.ToSlash()) and resolved against the base.

if the base is https://example.com/cool/foolder/something.js and the location is /cool/folder/something.js.map isn't the location absolute ? But I would still argue that it should be resolved against the base URL. So from that perspective, the algorithm should be :

if the location is URL and has a scheme - use it
if the base is URL  parse it and resolve location against it  and use that
if location is an absolute path (either defined by the path or filepath package) - use that
if not Join base and location and :crossed_fingers:

The thing is that url.ResolveReference does in practice all the steps 1-4 and the rest of the code is there in the case somehow nothing is parsed as URL and the  && path.IsAbs(baseURL.Path) is because in the case base is something.js and the location is somewhere.js it would result in /somewhere.js (with a slash in front which is likely not what we want (and also try to base as base in case it's somehow a path but not a parable by url.Parse).

It would be nice to base it on a specification, or at least on an industry standard.

a specification, or at least on an industry standard.

That is exactly why I went directly with using URLs as much as possible and only fallback to not URLs in the cases where for some reason both base and location are not.
Arguably source map location is a URL by the specification and in the case of k6 at least all our files are also URLs (as we decided that it will be nice them to be something portable 2 years+ ago ;) ) so for my particular case the problem is that in some cases goja just decided they are paths and this patch specifically looks at them as much as URLs and using standard URLs resolution to get the end result as possible.
Here of course is the problem that Windows file system paths aren't really URLs as they generally use \ but this should only be a problem with the base I guess :shrug: .


Provide web-based frontend for repository lookup

It's ok to release V0.1 without any web-based repository (i.e. using http://cpmiscregistry.couchappy.com/ directly in their raw form), but later on w eshould provide some web frontend for repository.
NPM's https://github.com/npm/newww may be of a good start, though it's a little bit more complex than I'd expect for our case

OTOH we might start from few simple, static web-pages where npm code will be injected using browserify, that might allow to implement code very cheaply (i.e. as a github web page) and very simply (without any necessity to run actual backend on virtual machine).


To deploy

[x] Setup, as always, gh-pages settings from GitHub repository website

[x] Be sure to merge/pull all changes to main branch

[x] Be sure to add all src files and dist output to webpack.config.js:
in my case, for example:

[x] checkout to main branch

[x] Delete existing gh-pages branch (if any)
run:
git branch -D gh-pages
git push --delete origin gh-pages

[x] build all dist folders,
run:
npm run build

[x] Commit dist subtree and push it to new branch,
run:
git add dist -f
git commit -m "dist Subtree deployment using webpack"
git subtree push --prefix dist origin gh-pages

Thank you.... Very helpful 😄


IGVF-320 Updated not-submittable true for all calculated properties

Updated not submittable true for all calculated properties

Closing pull request for a new branch with a shorter name.