Add readiness probe for pilot agent.

Overview of the changes:

Adding new flag to the pilot agent "--statusPort". Defaults to 15003.

Adding an HttpGet readiness probe to the pilot-agent
on the new status port. The agent (not Envoy) will
open this port. When receiving an HTTP GET on the readiness path,
the agent will probe Envoy, checking that it has received dynamic
listeners and clusters. If so, it's "ready".

Poking a hole in the sidecar iptables for the new status port
(via the -d option).

Updated both webhook and manual injection paths to generate the
readiness probe. A lot of changes here for the test files.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: nmittler
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: linsun
If they are not already assigned, you can assign the PR to them by writing /assign @linsun in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS
istioctl/OWNERS [nmittler]
pilot/OWNERS [nmittler]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

I'm sending out the PR a little early because I'd like to get feedback on the general approach.  We still need to determine whether we should allow opt-in/out, what should be the default, and how to configure it (annotations?).  We can use this issue for discussion.

@nmittler: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
10434f88553985525ee81702805ea73b61486629
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Issues with exec probes:

It is very k8s centric.
Running exec curl  from the proxy container will mark the proxy container bad even though the app container needs restarting. Every container needs its own dedicated liveness / readiness checks for this reason.
You may not have the ability to execute code in the environment.
There is a work around by mounting a statically linked curl like binary into the application container. Even that may not always work if you are using alpine or similar.

network probes address all these problems.

Update /health to /health/liveness  and /health/readiness
Per design doc we actually need /health/<container>/liveness, both can be services by agent  or proxy.
For readiness, we do want it to be AND of proxy ready and application ready.
We don't want to start receiving traffic when only proxy is ready but application is not.

@nmittler: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
2b2a930e811d858ba09152eb3bd75e2aef08fd28
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mandarjog

Update /health to /health/liveness  and /health/readiness

makes sense.

Per design doc we actually need /health/<container>/liveness, both can be services by agent  or proxy.

Do you have a link to the doc?

For readiness, we do want it to be AND of proxy ready and application ready.
We don't want to start receiving traffic when only proxy is ready but application is not.

IIUC, this is how readiness works in k8s already (i.e. traffic won't be received by the pod until all containers are "ready"). So adding just a readiness probe to the proxy container should be sufficient for this PR.  Application-level readiness is up to the developer.

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
2b2a930e811d858ba09152eb3bd75e2aef08fd28
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-mixer-no_auth.sh
b769b400d1ba26d5a34c35f62c1e6dcea60d9ea8
link
/test e2e-mixer-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
2b2a930e811d858ba09152eb3bd75e2aef08fd28
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-mixer-no_auth.sh
b769b400d1ba26d5a34c35f62c1e6dcea60d9ea8
link
/test e2e-mixer-no_auth

prow/e2e-dashboard.sh
b769b400d1ba26d5a34c35f62c1e6dcea60d9ea8
link
/test e2e-dashboard

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
2b2a930e811d858ba09152eb3bd75e2aef08fd28
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-mixer-no_auth.sh
b769b400d1ba26d5a34c35f62c1e6dcea60d9ea8
link
/test e2e-mixer-no_auth

prow/e2e-dashboard.sh
b769b400d1ba26d5a34c35f62c1e6dcea60d9ea8
link
/test e2e-dashboard

prow/e2e-simpleTests.sh
b769b400d1ba26d5a34c35f62c1e6dcea60d9ea8
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
2b2a930e811d858ba09152eb3bd75e2aef08fd28
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-mixer-no_auth.sh
b769b400d1ba26d5a34c35f62c1e6dcea60d9ea8
link
/test e2e-mixer-no_auth

prow/e2e-dashboard.sh
b769b400d1ba26d5a34c35f62c1e6dcea60d9ea8
link
/test e2e-dashboard

prow/e2e-simpleTests.sh
b769b400d1ba26d5a34c35f62c1e6dcea60d9ea8
link
/test e2e-simple

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
b769b400d1ba26d5a34c35f62c1e6dcea60d9ea8
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth.sh
b769b400d1ba26d5a34c35f62c1e6dcea60d9ea8
link
/test e2e-mixer-no_auth

prow/e2e-dashboard.sh
b769b400d1ba26d5a34c35f62c1e6dcea60d9ea8
link
/test e2e-dashboard

prow/e2e-simpleTests.sh
b769b400d1ba26d5a34c35f62c1e6dcea60d9ea8
link
/test e2e-simple

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
b769b400d1ba26d5a34c35f62c1e6dcea60d9ea8
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-bookInfoTests-v1alpha3.sh
b769b400d1ba26d5a34c35f62c1e6dcea60d9ea8
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth.sh
b769b400d1ba26d5a34c35f62c1e6dcea60d9ea8
link
/test e2e-mixer-no_auth

prow/e2e-dashboard.sh
b769b400d1ba26d5a34c35f62c1e6dcea60d9ea8
link
/test e2e-dashboard

prow/e2e-simpleTests.sh
b769b400d1ba26d5a34c35f62c1e6dcea60d9ea8
link
/test e2e-simple

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
b769b400d1ba26d5a34c35f62c1e6dcea60d9ea8
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-bookInfoTests-v1alpha3.sh
b769b400d1ba26d5a34c35f62c1e6dcea60d9ea8
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-multicluster-e2e.sh
b769b400d1ba26d5a34c35f62c1e6dcea60d9ea8
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: linsun
If they are not already assigned, you can assign the PR to them by writing /assign @linsun in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS
istioctl/OWNERS
pilot/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth.sh
b769b400d1ba26d5a34c35f62c1e6dcea60d9ea8
link
/test e2e-mixer-no_auth

prow/e2e-dashboard.sh
b769b400d1ba26d5a34c35f62c1e6dcea60d9ea8
link
/test e2e-dashboard

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
b769b400d1ba26d5a34c35f62c1e6dcea60d9ea8
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-bookInfoTests-v1alpha3.sh
b769b400d1ba26d5a34c35f62c1e6dcea60d9ea8
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-multicluster-e2e.sh
b769b400d1ba26d5a34c35f62c1e6dcea60d9ea8
link
/test istio-pilot-multicluster-e2e

prow/e2e-simpleTests.sh
b3fadb5b28d29955d47454013ca7cf8f2a79a899
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-dashboard.sh
b769b400d1ba26d5a34c35f62c1e6dcea60d9ea8
link
/test e2e-dashboard

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
b769b400d1ba26d5a34c35f62c1e6dcea60d9ea8
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-bookInfoTests-v1alpha3.sh
b769b400d1ba26d5a34c35f62c1e6dcea60d9ea8
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-multicluster-e2e.sh
b769b400d1ba26d5a34c35f62c1e6dcea60d9ea8
link
/test istio-pilot-multicluster-e2e

prow/e2e-simpleTests.sh
b3fadb5b28d29955d47454013ca7cf8f2a79a899
link
/test e2e-simple

prow/e2e-mixer-no_auth.sh
b3fadb5b28d29955d47454013ca7cf8f2a79a899
link
/test e2e-mixer-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-dashboard.sh
b769b400d1ba26d5a34c35f62c1e6dcea60d9ea8
link
/test e2e-dashboard

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
b769b400d1ba26d5a34c35f62c1e6dcea60d9ea8
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-multicluster-e2e.sh
b769b400d1ba26d5a34c35f62c1e6dcea60d9ea8
link
/test istio-pilot-multicluster-e2e

prow/e2e-simpleTests.sh
b3fadb5b28d29955d47454013ca7cf8f2a79a899
link
/test e2e-simple

prow/e2e-mixer-no_auth.sh
b3fadb5b28d29955d47454013ca7cf8f2a79a899
link
/test e2e-mixer-no_auth

prow/e2e-bookInfoTests-v1alpha3.sh
b3fadb5b28d29955d47454013ca7cf8f2a79a899
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-dashboard.sh
b769b400d1ba26d5a34c35f62c1e6dcea60d9ea8
link
/test e2e-dashboard

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
b769b400d1ba26d5a34c35f62c1e6dcea60d9ea8
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-simpleTests.sh
b3fadb5b28d29955d47454013ca7cf8f2a79a899
link
/test e2e-simple

prow/e2e-mixer-no_auth.sh
b3fadb5b28d29955d47454013ca7cf8f2a79a899
link
/test e2e-mixer-no_auth

prow/e2e-bookInfoTests-v1alpha3.sh
b3fadb5b28d29955d47454013ca7cf8f2a79a899
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-multicluster-e2e.sh
b3fadb5b28d29955d47454013ca7cf8f2a79a899
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
b769b400d1ba26d5a34c35f62c1e6dcea60d9ea8
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-simpleTests.sh
b3fadb5b28d29955d47454013ca7cf8f2a79a899
link
/test e2e-simple

prow/e2e-mixer-no_auth.sh
b3fadb5b28d29955d47454013ca7cf8f2a79a899
link
/test e2e-mixer-no_auth

prow/e2e-bookInfoTests-v1alpha3.sh
b3fadb5b28d29955d47454013ca7cf8f2a79a899
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-multicluster-e2e.sh
b3fadb5b28d29955d47454013ca7cf8f2a79a899
link
/test istio-pilot-multicluster-e2e

prow/e2e-dashboard.sh
b3fadb5b28d29955d47454013ca7cf8f2a79a899
link
/test e2e-dashboard

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
b3fadb5b28d29955d47454013ca7cf8f2a79a899
link
/test e2e-simple

prow/e2e-mixer-no_auth.sh
b3fadb5b28d29955d47454013ca7cf8f2a79a899
link
/test e2e-mixer-no_auth

prow/e2e-bookInfoTests-v1alpha3.sh
b3fadb5b28d29955d47454013ca7cf8f2a79a899
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-multicluster-e2e.sh
b3fadb5b28d29955d47454013ca7cf8f2a79a899
link
/test istio-pilot-multicluster-e2e

prow/e2e-dashboard.sh
b3fadb5b28d29955d47454013ca7cf8f2a79a899
link
/test e2e-dashboard

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
b3fadb5b28d29955d47454013ca7cf8f2a79a899
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth.sh
b3fadb5b28d29955d47454013ca7cf8f2a79a899
link
/test e2e-mixer-no_auth

prow/istio-pilot-multicluster-e2e.sh
b3fadb5b28d29955d47454013ca7cf8f2a79a899
link
/test istio-pilot-multicluster-e2e

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
b3fadb5b28d29955d47454013ca7cf8f2a79a899
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-bookInfoTests-v1alpha3.sh
a39b7b296c2dc50e4afca6c5208885ba2d7d4b4f
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Hey,
Is this going to be in 1.0.1?  As it'd help me / give visibility of https://github.com/istio/istio/issues/7817

It will definitely be in 1.1.  This PR is pretty close.  @costinm when is 1.0.1 scheduled for?

@nmittler: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
3dfba0b752689624ed62f6e5e40f65ca8fffd8f3
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
93e5666e58d58339c4dfa32152a90f398838fc78
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram @costinm @mandarjog the readiness probes seem to always fail when auth is enabled. I exec'ed onto a pod and got a cluster dump, but it seemed that there were no clusters/listeners received from Pilot.  Any ideas what might be different when using auth?

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: costinm
If they are not already assigned, you can assign the PR to them by writing /assign @costinm in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS
istioctl/OWNERS
pilot/OWNERS
tests/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
93e5666e58d58339c4dfa32152a90f398838fc78
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-unit-tests.sh
1c05386b8082e05f848c373d5d35224c6ac843e6
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
1c05386b8082e05f848c373d5d35224c6ac843e6
link
/test istio-unit-tests

prow/e2e-bookInfoTests-v1alpha3.sh
1c05386b8082e05f848c373d5d35224c6ac843e6
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler humor me and change your health check to be:
            exec:
              command:
                - "curl"
                - "-f"
                - "http://<IP_ADDRESS>:15003/healthz/ready

Presuming the istio-proxy pods have curl.

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
1c05386b8082e05f848c373d5d35224c6ac843e6
link
/test istio-unit-tests

prow/e2e-bookInfoTests-v1alpha3.sh
1c05386b8082e05f848c373d5d35224c6ac843e6
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-multicluster-e2e.sh
1c05386b8082e05f848c373d5d35224c6ac843e6
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler were all clusters missing? or just inbound clusters ?

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
1c05386b8082e05f848c373d5d35224c6ac843e6
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-multicluster-e2e.sh
964ffa61b2bc098aeb34dcc5e9069d228a3941ff
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
964ffa61b2bc098aeb34dcc5e9069d228a3941ff
link
/test istio-pilot-multicluster-e2e

prow/e2e-bookInfoTests-v1alpha3.sh
964ffa61b2bc098aeb34dcc5e9069d228a3941ff
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
964ffa61b2bc098aeb34dcc5e9069d228a3941ff
link
/test istio-pilot-multicluster-e2e

prow/e2e-bookInfoTests-v1alpha3.sh
964ffa61b2bc098aeb34dcc5e9069d228a3941ff
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-mixer-no_auth.sh
964ffa61b2bc098aeb34dcc5e9069d228a3941ff
link
/test e2e-mixer-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

I think I figured out what was going on.  This PR was previously assigning the pilot_agent a default status port of 15003 unless explicitly set (--statusPort=0 to disable). This was fine for the sidecars but Pilot's sidecar explicitly defines port 15003, causing a port conflict. Somehow this was interfering with the ADS requests from the sidecars, which go through Pilot's agent.  By switching the default port back to 0 (disabled), every seems to work fine.

@costinm @rshriram @mandarjog PTAL

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
964ffa61b2bc098aeb34dcc5e9069d228a3941ff
link
/test istio-pilot-multicluster-e2e

prow/e2e-bookInfoTests-v1alpha3.sh
964ffa61b2bc098aeb34dcc5e9069d228a3941ff
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-mixer-no_auth.sh
964ffa61b2bc098aeb34dcc5e9069d228a3941ff
link
/test e2e-mixer-no_auth

prow/istio-unit-tests.sh
fb6de8faeaa2e5985d14b9f7e78314777339bebf
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
964ffa61b2bc098aeb34dcc5e9069d228a3941ff
link
/test istio-pilot-multicluster-e2e

prow/istio-unit-tests.sh
fb6de8faeaa2e5985d14b9f7e78314777339bebf
link
/test istio-unit-tests

prow/e2e-bookInfoTests-v1alpha3.sh
fb6de8faeaa2e5985d14b9f7e78314777339bebf
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
fb6de8faeaa2e5985d14b9f7e78314777339bebf
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-unit-tests.sh
7357a5df8d6d14886b4a0654f6fbc48dd8947bf1
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm @rshriram @mandarjog PTAL.  I've updated the readiness probes to use Envoy stats rather than cluster_dump.

So the newly opened port is still http and not secured?
I thought we would use TLS sniffing and making  it secure.

@nmittler: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
3a35514eba7f5df8f2afd64c97ee4f68bec5340a
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
3a35514eba7f5df8f2afd64c97ee4f68bec5340a
link
/test istio-unit-tests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
3a35514eba7f5df8f2afd64c97ee4f68bec5340a
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
3a35514eba7f5df8f2afd64c97ee4f68bec5340a
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-unit-tests.sh
20f05dea96334b35429e87d0c438e19e32479f2f
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
20f05dea96334b35429e87d0c438e19e32479f2f
link
/test istio-unit-tests

prow/istio-pilot-multicluster-e2e.sh
20f05dea96334b35429e87d0c438e19e32479f2f
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Re http vs https: it's called by k8s - which doesn't have istio certs.
And only returns a status code, nothing confidential.

@nmittler: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
679c27a17ca2433ccceae7a2f77aa43f0f007405
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
d5c38d3d9ee80dcd3e4bdb28116ca3a2e71021f9
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mandarjog @costinm @rshriram
There was a suggestion to make the new parameters part of the configmap, rather than including them as injector params. What are the pros/cons of doing this? Will manual injection still be able to modify the values on a per-deployment basis without annotations?

Quick drive-by comment.
One consideration to be made is that all outbound clusters can be loaded in, but the inbound ones can take a lot longer due to Kube slowness. This will mean Envoy is ready to handle the requests but it will 404 NR them all because it doesn't know where to send them.
This isn't hypothetical either, I'm seeing this with my prototyping of our Istio cluster.

@liamawhite good point. In your example, there were already a few inbound clusters present. Just the important inbound cluster was missing.
In order to detect this, we should wait for all inbound clusters corresponding to declared container ports to show up.

@mandarjog @liamawhite In this case, are you saying that only a subset of the clusters were received from an ADS update? Or was everything received, but not all clusters/listeners were warmed?

All things have been received as far as Envoy/Pilot are concerned. However, Kubernetes hasn't yet added the endpoints so Pilot doesn't know it needs to add the correct inbound clusters.

@liamawhite got it ... makes sense.  And good catch!  Should be an easy fix, but will require that I use config_dump rather than stats.

@mandarjog @liamawhite @PiotrSikora PTAL. I've added the exposed application ports to the readiness check.

@nmittler: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
a9f02e22b1a99e3b0a88a54e3fa1b54c29b27d0c
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
a9f02e22b1a99e3b0a88a54e3fa1b54c29b27d0c
link
/test istio-unit-tests

prow/e2e-mixer-no_auth.sh
a9f02e22b1a99e3b0a88a54e3fa1b54c29b27d0c
link
/test e2e-mixer-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
a9f02e22b1a99e3b0a88a54e3fa1b54c29b27d0c
link
/test istio-unit-tests

prow/e2e-mixer-no_auth.sh
a9f02e22b1a99e3b0a88a54e3fa1b54c29b27d0c
link
/test e2e-mixer-no_auth

prow/e2e-dashboard.sh
a9f02e22b1a99e3b0a88a54e3fa1b54c29b27d0c
link
/test e2e-dashboard

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
a9f02e22b1a99e3b0a88a54e3fa1b54c29b27d0c
link
/test istio-unit-tests

prow/e2e-mixer-no_auth.sh
a9f02e22b1a99e3b0a88a54e3fa1b54c29b27d0c
link
/test e2e-mixer-no_auth

prow/e2e-dashboard.sh
a9f02e22b1a99e3b0a88a54e3fa1b54c29b27d0c
link
/test e2e-dashboard

prow/e2e-simpleTests.sh
a9f02e22b1a99e3b0a88a54e3fa1b54c29b27d0c
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth.sh
a9f02e22b1a99e3b0a88a54e3fa1b54c29b27d0c
link
/test e2e-mixer-no_auth

prow/e2e-dashboard.sh
a9f02e22b1a99e3b0a88a54e3fa1b54c29b27d0c
link
/test e2e-dashboard

prow/e2e-simpleTests.sh
a9f02e22b1a99e3b0a88a54e3fa1b54c29b27d0c
link
/test e2e-simple

prow/istio-unit-tests.sh
3273af30541c37688f1a49c3d1d851534c2abccc
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth.sh
a9f02e22b1a99e3b0a88a54e3fa1b54c29b27d0c
link
/test e2e-mixer-no_auth

prow/e2e-simpleTests.sh
a9f02e22b1a99e3b0a88a54e3fa1b54c29b27d0c
link
/test e2e-simple

prow/istio-unit-tests.sh
3273af30541c37688f1a49c3d1d851534c2abccc
link
/test istio-unit-tests

prow/e2e-dashboard.sh
3273af30541c37688f1a49c3d1d851534c2abccc
link
/test e2e-dashboard

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth.sh
a9f02e22b1a99e3b0a88a54e3fa1b54c29b27d0c
link
/test e2e-mixer-no_auth

prow/e2e-simpleTests.sh
a9f02e22b1a99e3b0a88a54e3fa1b54c29b27d0c
link
/test e2e-simple

prow/istio-unit-tests.sh
3273af30541c37688f1a49c3d1d851534c2abccc
link
/test istio-unit-tests

prow/e2e-dashboard.sh
3273af30541c37688f1a49c3d1d851534c2abccc
link
/test e2e-dashboard

prow/istio-pilot-multicluster-e2e.sh
3273af30541c37688f1a49c3d1d851534c2abccc
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
a9f02e22b1a99e3b0a88a54e3fa1b54c29b27d0c
link
/test e2e-simple

prow/istio-unit-tests.sh
3273af30541c37688f1a49c3d1d851534c2abccc
link
/test istio-unit-tests

prow/e2e-dashboard.sh
3273af30541c37688f1a49c3d1d851534c2abccc
link
/test e2e-dashboard

prow/istio-pilot-multicluster-e2e.sh
3273af30541c37688f1a49c3d1d851534c2abccc
link
/test istio-pilot-multicluster-e2e

prow/e2e-mixer-no_auth.sh
3273af30541c37688f1a49c3d1d851534c2abccc
link
/test e2e-mixer-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
3273af30541c37688f1a49c3d1d851534c2abccc
link
/test istio-unit-tests

prow/e2e-dashboard.sh
3273af30541c37688f1a49c3d1d851534c2abccc
link
/test e2e-dashboard

prow/istio-pilot-multicluster-e2e.sh
3273af30541c37688f1a49c3d1d851534c2abccc
link
/test istio-pilot-multicluster-e2e

prow/e2e-mixer-no_auth.sh
3273af30541c37688f1a49c3d1d851534c2abccc
link
/test e2e-mixer-no_auth

prow/e2e-simpleTests.sh
3273af30541c37688f1a49c3d1d851534c2abccc
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
3273af30541c37688f1a49c3d1d851534c2abccc
link
/test istio-unit-tests

prow/e2e-dashboard.sh
3273af30541c37688f1a49c3d1d851534c2abccc
link
/test e2e-dashboard

prow/istio-pilot-multicluster-e2e.sh
3273af30541c37688f1a49c3d1d851534c2abccc
link
/test istio-pilot-multicluster-e2e

prow/e2e-mixer-no_auth.sh
3273af30541c37688f1a49c3d1d851534c2abccc
link
/test e2e-mixer-no_auth

prow/e2e-simpleTests.sh
3273af30541c37688f1a49c3d1d851534c2abccc
link
/test e2e-simple

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
3273af30541c37688f1a49c3d1d851534c2abccc
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liamawhite k8s should be equally slow for inbound and outbound clusters, what do you mean? There was also a fix to generate listeners for endpoints not ready #6992

andraxylia@ the requested check has already been added to this PR. See https://github.com/istio/istio/pull/7465/files#diff-293528584c1dc78a315e29fb2df2bc1a

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-dashboard.sh
3273af30541c37688f1a49c3d1d851534c2abccc
link
/test e2e-dashboard

prow/istio-pilot-multicluster-e2e.sh
3273af30541c37688f1a49c3d1d851534c2abccc
link
/test istio-pilot-multicluster-e2e

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
3273af30541c37688f1a49c3d1d851534c2abccc
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-unit-tests.sh
2f5e564ee429c9826da05c9d65a6db0c411d1215
link
/test istio-unit-tests

prow/e2e-mixer-no_auth.sh
2f5e564ee429c9826da05c9d65a6db0c411d1215
link
/test e2e-mixer-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
3273af30541c37688f1a49c3d1d851534c2abccc
link
/test istio-pilot-multicluster-e2e

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
3273af30541c37688f1a49c3d1d851534c2abccc
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-unit-tests.sh
2f5e564ee429c9826da05c9d65a6db0c411d1215
link
/test istio-unit-tests

prow/e2e-mixer-no_auth.sh
2f5e564ee429c9826da05c9d65a6db0c411d1215
link
/test e2e-mixer-no_auth

prow/e2e-dashboard.sh
2f5e564ee429c9826da05c9d65a6db0c411d1215
link
/test e2e-dashboard

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
3273af30541c37688f1a49c3d1d851534c2abccc
link
/test istio-pilot-multicluster-e2e

prow/e2e-mixer-no_auth.sh
2f5e564ee429c9826da05c9d65a6db0c411d1215
link
/test e2e-mixer-no_auth

prow/e2e-dashboard.sh
2f5e564ee429c9826da05c9d65a6db0c411d1215
link
/test e2e-dashboard

prow/istio-unit-tests.sh
9a981aabb064f723ae1800058a005c977ad13bad
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth.sh
2f5e564ee429c9826da05c9d65a6db0c411d1215
link
/test e2e-mixer-no_auth

prow/e2e-dashboard.sh
2f5e564ee429c9826da05c9d65a6db0c411d1215
link
/test e2e-dashboard

prow/istio-unit-tests.sh
9a981aabb064f723ae1800058a005c977ad13bad
link
/test istio-unit-tests

prow/istio-pilot-multicluster-e2e.sh
2f5e564ee429c9826da05c9d65a6db0c411d1215
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-dashboard.sh
2f5e564ee429c9826da05c9d65a6db0c411d1215
link
/test e2e-dashboard

prow/istio-unit-tests.sh
9a981aabb064f723ae1800058a005c977ad13bad
link
/test istio-unit-tests

prow/istio-pilot-multicluster-e2e.sh
2f5e564ee429c9826da05c9d65a6db0c411d1215
link
/test istio-pilot-multicluster-e2e

prow/e2e-mixer-no_auth.sh
9a981aabb064f723ae1800058a005c977ad13bad
link
/test e2e-mixer-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
9a981aabb064f723ae1800058a005c977ad13bad
link
/test istio-unit-tests

prow/istio-pilot-multicluster-e2e.sh
2f5e564ee429c9826da05c9d65a6db0c411d1215
link
/test istio-pilot-multicluster-e2e

prow/e2e-mixer-no_auth.sh
9a981aabb064f723ae1800058a005c977ad13bad
link
/test e2e-mixer-no_auth

prow/e2e-dashboard.sh
9a981aabb064f723ae1800058a005c977ad13bad
link
/test e2e-dashboard

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
9a981aabb064f723ae1800058a005c977ad13bad
link
/test istio-unit-tests

prow/e2e-mixer-no_auth.sh
9a981aabb064f723ae1800058a005c977ad13bad
link
/test e2e-mixer-no_auth

prow/e2e-dashboard.sh
9a981aabb064f723ae1800058a005c977ad13bad
link
/test e2e-dashboard

prow/istio-pilot-multicluster-e2e.sh
9a981aabb064f723ae1800058a005c977ad13bad
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth.sh
9a981aabb064f723ae1800058a005c977ad13bad
link
/test e2e-mixer-no_auth

prow/e2e-dashboard.sh
9a981aabb064f723ae1800058a005c977ad13bad
link
/test e2e-dashboard

prow/istio-pilot-multicluster-e2e.sh
9a981aabb064f723ae1800058a005c977ad13bad
link
/test istio-pilot-multicluster-e2e

prow/istio-unit-tests.sh
42f284434d5021f41083e0dd329f4b03dbe86a10
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@andraxylia In some cases, it takes Kube a while to add an endpoint for the pod. Until Kube adds that endpoint Pilot doesn't know which inbound clusters to add so the pod can't correctly handle incoming requests.

For those interested, I've shared a design doc for Istio Proxy liveness/readiness.

@nmittler: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
667f4b6780c98a0a20238511183f78a6f166c9d6
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: linsun
If they are not already assigned, you can assign the PR to them by writing /assign @linsun in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS
istioctl/OWNERS
pilot/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: costinm
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS [costinm]
istioctl/OWNERS [costinm]
pilot/OWNERS [costinm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/lgtm

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: costinm, mandarjog
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS [costinm,mandarjog]
istioctl/OWNERS [costinm,mandarjog]
pilot/OWNERS [costinm,mandarjog]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-dashboard.sh
842c111a88b4e7125b8b1fa2bb32165da5e086b4
link
/test e2e-dashboard

prow/istio-pilot-multicluster-e2e.sh
842c111a88b4e7125b8b1fa2bb32165da5e086b4
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-dashboard.sh
842c111a88b4e7125b8b1fa2bb32165da5e086b4
link
/test e2e-dashboard

prow/istio-pilot-multicluster-e2e.sh
842c111a88b4e7125b8b1fa2bb32165da5e086b4
link
/test istio-pilot-multicluster-e2e

prow/e2e-mixer-no_auth.sh
842c111a88b4e7125b8b1fa2bb32165da5e086b4
link
/test e2e-mixer-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test e2e-mixer-no_auth
/test e2e-dashboard


Improvements to GridFindField

Suggesting the following changes:

Store the value on a specifiable 'model', or the grid itself.  This is what StoreFilterField does, and it's important if you ever want to control/persist this value, but also because local state can easily be "lost" in toolbar controls.  (Toolbar will remount more than it should -- a separate issue).

Added keyboard handling for up/down arrow.

Stacked the buttons -- looking just to make the thing visually a bit tighter.

Hide the buttons when no search in place -- again, looking to make things visually tighter, especially when control is not in use.

SelectOnFocus : true, for this control. Don't feel strongly about this, but seemed like generally a worthwhile default.

Minor re-org to hide implemenation class

Hoist P/R Checklist
Pull request authors: Review and check off the below. Items that do not apply can also be
checked off to indicate they have been considered. If unclear if a step is relevant, please leave
unchecked and note in comments.

[X] Caught up with develop branch as of last change.
[X] Added CHANGELOG entry, or determined not required.
[X] Reviewed for breaking changes, added breaking-change label + CHANGELOG if so.
[X] Updated doc comments / prop-types, or determined not required.
[X] Reviewed and tested on Mobile, or determined not required.
[X] Created Toolbox branch / PR, or determined not required.

If your change is still a WIP, please use the "Create draft pull request" option in the split
button below to indicate it is not ready yet for a final review.

Pull request reviewers: when merging this P/R, please consider using a squash commit to
collapse multiple intermediate commits into a single commit representing the overall feature
change. This helps keep the commit log clean and easy to scan across releases. PRs containing a
single commit should be rebased when possible.

Overall, these a great enhancements and I'm eager to get them in, particularly the binding to not lose the local state.
The only part I'm not sure about is the 'Up' / 'Down' keys for navigation - these feel pretty non-standard to me. I'm used to using the arrow keys to control the caret within editable text, and noticed that other implementations of similar controls (e.g. browser find) don't support it.
If we keep them, we could consider not doing anything if you're holding the Shift key. Shift+Up is a selection shortcut I use pretty instinctively to select-all then retype a field, and I immediately noticed its absence here.

Intellij find supports up down key nav.  Try it!.  Seems natural to me.
On Mon, Oct 4, 2021, 6:21 AM Tom Tirapani @.***> wrote:

Overall, these a great enhancements and I'm eager to get them in,
particularly the binding to not lose the local state.
The only part I'm not sure about is the 'Up' / 'Down' keys for navigation

these feel pretty non-standard to me. I'm used to using the arrow keys to
control the caret within editable text, and noticed that other
implementations of similar controls (e.g. browser find) don't support it.

If we keep them, we could consider not doing anything if you're holding
the Shift key. Shift+Up is a selection shortcut I use pretty instinctively
to select-all then retype a field, and I immediately noticed its absence
here.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/xh/hoist-react/pull/2714#issuecomment-933346487, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AARTL2JXK6I64SA6GIGILADUFF53TANCNFSM5FH7GSWA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Okay, fair enough :)
Still think we shouldn't swallow the shift+arrow key selection though (unless I'm the only person who uses those shortcuts)


Pull kernel functions out of operator classes

Following https://github.com/lockshaw/FlexFlow/blob/feat/candle_split/include/flexflow/ops/linear_kernels.h
See discussion at https://github.com/flexflow/FlexFlow/pull/298#discussion_r956470999

A more up-to-date example is shown in #320

List of operators:

BatchMatmul
Conv2D (#434)
Concat
Cast
ElementBinary
ElementUnary
Dropout
Embedding
Flat
LayerNorm
Linear
MultiHeadAttention
NoOp/Input
Pool2D
Reshape
Split
Softmax
Transpose
Repartition
Replicate
Reduction
Combine
FusedParallelOp

Closed by #622.


Switching to chrome headless

Switching from phatomJS to Chrome headless

Coverage remained the same at 100.0% when pulling 056b3ba5bd028ea4def6cc06267f82f791e1b93d on chromeHeadless into ff313ca9d7bba848fbd8a4b17fb69a5d06e1644d on master.

Coverage remained the same at 100.0% when pulling 056b3ba5bd028ea4def6cc06267f82f791e1b93d on chromeHeadless into ff313ca9d7bba848fbd8a4b17fb69a5d06e1644d on master.

Coverage remained the same at 100.0% when pulling 056b3ba5bd028ea4def6cc06267f82f791e1b93d on chromeHeadless into ff313ca9d7bba848fbd8a4b17fb69a5d06e1644d on master.


error: The attribute email on the user model uses an invalid type - email.

Hallo, the Internet cant find out some with this problem, because the commity is to small, what im think about a new framework to use.!
really, help me please with the last steps...
error: The attribute email on the user model uses an invalid type - email.
and my last issue !
i dont have time to wast. im try to fix these steps since 24 hours ago, and anoym me to work more with "sails"...
Sails version:
Node version:
NPM version:
DB adapter name: N/A
DB adapter version: N/A
Operating system:

ok, fixed
for everybody : checkout :
module.exports = {

  attributes: {
      email: {
        type: 'string',
        isEmail: true,
      },

and link to sails: Validation LinK : https://sailsjs.com/documentation/concepts/models-and-orm/validations


Crash when disconnecting a monitor that's mirroring an active monitor

Hyprland Version
 System/Version info
Hyprland, built from branch  at commit 9f1604e4b0afec40cfa9bc095d6613a7f749b2c1  ().
Date: 2024-04-07
Tag: , commits: @COMMITS@

flags: (if any)

System Information:
System name: Linux
Node name: ncase-m1
Release: 6.7.12
Version: #1-NixOS SMP PREEMPT_DYNAMIC Wed Apr  3 13:11:59 UTC 2024

GPU information:
09:00.0 VGA compatible controller [0300]: Advanced Micro Devices, Inc. [AMD/ATI] Navi 31 [Radeon RX 7900 XT/7900 XTX/7900M] [1002:744c] (rev cc) (prog-if 00 [VGA controller])

os-release: ANSI_COLOR="1;34"
BUG_REPORT_URL="https://github.com/NixOS/nixpkgs/issues"
BUILD_ID="24.05.20240405.e37b005"
DOCUMENTATION_URL="https://nixos.org/learn.html"
HOME_URL="https://nixos.org/"
ID=nixos
IMAGE_ID=""
IMAGE_VERSION=""
LOGO="nix-snowflake"
NAME=NixOS
PRETTY_NAME="NixOS 24.05 (Uakari)"
SUPPORT_URL="https://nixos.org/community.html"
VERSION="24.05 (Uakari)"
VERSION_CODENAME=uakari
VERSION_ID="24.05"

plugins:
  hyprexpo by Vaxry ver 1.0

Bug or Regression?
Bug
Description
I think it's due to this line:
https://github.com/hyprwm/Hyprland/blob/1343aa865d04d80313b0e674c28ecfdbeb90e876/src/helpers/Monitor.cpp#L306
How to reproduce
Disconnect a monitor that's mirroring an active monitor
Crash reports, logs, images, videos
hyprlandCrashReport51192.txt

try now

That fixes it, thanks


Re-register gateway after updating the configuration

As @TonyGiorgio pointed out here, when updating a gateway's routing fees, the operator either needs to wait for ~10 minutes for the gateway to re-register, or leave the federation and re-join for it to show up immediately. This is a bad experience and unnecessary, config changes should just trigger re-registration with all of the connected federations.

I'm not even sure if it's only a problem with registration. Last time I changed fee levels re-registering didn't help because the global config that can be changed via the CLI or env variables is duplicated into the per-federation client config, re-joining helped. I think the way we handle malleable gateway config has to change fundamentally.

Last time I changed fee levels re-registering didn't help because the global config that can be changed via the CLI or env variables is duplicated into the per-federation client config

Good catch, this is just a bug imo, leftover from before we had a database for the gateway. Gateway fees are a gateway-level setting, there shouldn't be any need to replicate it into each individual client db.
I think the fix is pretty easy, unfortunately it will require a database migration (currently working on this) if we want to remove it from the client databases.

I think the way we handle malleable gateway config has to change fundamentally

Let me know if you have additional thoughts on this. My intention with the original design was to have a simple API that stored gateway-level configs in the gateway's db, which could just be re-read at runtime. It wasn't intended for per-federation client level configs.

I think long-term we will want some per-federation config options because gateway operators may charge higher fees for less-active or higher-risk federations.

Sure, I think we can still support that inside gatewayd's database. I don't think those kind of settings need to be replicated into each individual client's db.


How do I get multi-part data from mock config file

Hello guys,
From the below, how do I get the content of formData in a mock config file.
var formData = new FormData();
formData.append('image', file);

superagent( "POST", `<some-url>` )
		.send(formData)

here is what I have.
{
            pattern: `<some-url>`,
            fixtures: function (match, params, headers) {
                console.log(match, params, headers);
            },
            post: function (match, data) {
}

when the content of match, params and headers gets logged, the value of formData is not present.
Thanks

Your formData is stored in the currentLog object but it's named data :wink:
Request.prototype.send = function (data) {
    if (logEnabled) {
      currentLog.data = data;
    }

@andela-joyebanji can we close this issue ?


Full width search bar + explicit action buttons for search facets

Sync up master with release_search_ui
This one will basically introduce full width search bar, instead of having it in the facets, see #1147

I believe the remaining failing test is elastic search bound:
index-ec1c3da3.js:133634 CypressError: `cy.request()` failed on:

http://localhost:3000/api/v3/elastic-search/delete-index?index=test

The response we received from your web server was:

  > 400: Bad Request

This was considered a failure because the status code was not `2xx` or `3xx`.

If you do not want status codes to cause failures pass the option: `failOnStatusCode: false`

-----------------------------------------------------------

The request we sent was:

Method: POST
URL: http://localhost:3000/api/v3/elastic-search/delete-index?index=test
Headers: {
  "Connection": "keep-alive",
  "Authorization": "Bearer eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJfaWQiOiI2NjNmMmRlNTY4NDczOWZmZGYwZWMxMmUiLCJ1c2VybmFtZSI6ImFkbWluIiwiZW1haWwiOiJhZG1pbkB5b3VyLnNpdGUiLCJhdXRoU3RyYXRlZ3kiOiJsb2NhbCIsIl9fdiI6MCwiaWQiOiI2NjNmMmRlNTY4NDczOWZmZGYwZWMxMmUiLCJpYXQiOjE3MTU0MTY2MDAsImV4cCI6MTcxNTQyMDIwMH0.X6V5RR6sSXEdy7QkaLsko4p1q6_Y3ucvz_IiwKi23YM",
  "Content-Type": "application/json",
  "user-agent": "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36",
  "accept": "application/json",
  "accept-encoding": "gzip, deflate",
  "content-length": 0
}

-----------------------------------------------------------

The response we got was:

Status: 400 - Bad Request
Headers: {
  "x-powered-by": "Express",
  "access-control-allow-origin": "*",
  "content-type": "application/json; charset=utf-8",
  "content-length": "139",
  "etag": "W/\"8b-GT2GRHXQxRi8Bfyq4HNnE6sHijM\"",
  "date": "Sat, 11 May 2024 08:36:40 GMT",
  "connection": "keep-alive",
  "keep-alive": "timeout=5"
}
Body: {
  "statusCode": 400,
  "message": "deleteIndex failed-> ElasticSearchService TypeError: Cannot read properties of undefined (reading 'indices')"
}

Because this error occurred during a `after each` hook we are skipping the remaining tests in the current suite: `Elastic search`
    at <unknown> (http://<IP_ADDRESS>:4200/__cypress/runner/cypress_runner.js:133028:72)
    at tryCatcher (http://<IP_ADDRESS>:4200/__cypress/runner/cypress_runner.js:1807:23)
    at Promise._settlePromiseFromHandler (http://<IP_ADDRESS>:4200/__cypress/runner/cypress_runner.js:1519:31)
    at Promise._settlePromise (http://<IP_ADDRESS>:4200/__cypress/runner/cypress_runner.js:1576:18)
    at Promise._settlePromise0 (http://<IP_ADDRESS>:4200/__cypress/runner/cypress_runner.js:1621:10)
    at Promise._settlePromises (http://<IP_ADDRESS>:4200/__cypress/runner/cypress_runner.js:1701:18)
    at <unknown> (http://<IP_ADDRESS>:4200/__cypress/runner/cypress_runner.js:2392:25)
From previous event:
    at Promise.longStackTracesCaptureStackTrace [as _captureStackTrace] (http://<IP_ADDRESS>:4200/__cypress/runner/cypress_runner.js:3486:19)
    at Promise._then (http://<IP_ADDRESS>:4200/__cypress/runner/cypress_runner.js:1239:17)
    at Promise.then (http://<IP_ADDRESS>:4200/__cypress/runner/cypress_runner.js:1132:17)
    at next (http://<IP_ADDRESS>:4200/__cypress/runner/cypress_runner.js:144353:64)
    at <unknown> (http://<IP_ADDRESS>:4200/__cypress/runner/cypress_runner.js:144374:16)
    at tryCatcher (http://<IP_ADDRESS>:4200/__cypress/runner/cypress_runner.js:1807:23)
    at Promise._settlePromiseFromHandler (http://<IP_ADDRESS>:4200/__cypress/runner/cypress_runner.js:1519:31)
    at Promise._settlePromise (http://<IP_ADDRESS>:4200/__cypress/runner/cypress_runner.js:1576:18)
    at Promise._settlePromise0 (http://<IP_ADDRESS>:4200/__cypress/runner/cypress_runner.js:1621:10)
    at Promise._settlePromises (http://<IP_ADDRESS>:4200/__cypress/runner/cypress_runner.js:1701:18)
    at <unknown> (http://<IP_ADDRESS>:4200/__cypress/runner/cypress_runner.js:2392:25)
From Your Spec Code:
    at Context.eval (webpack://scicat-frontend/./cypress/support/commands.js:371:7)

Let's discuss this at the upcoming meeting

@Junjiequan I have implemented a few fixes including facets count and clicking the search button, however elastic search still fails. Will it be possible to have a zoom chat, so I can learn how to setup and run elastic search tests locally? Thanks

@Junjiequan I have implemented a few fixes including facets count and clicking the search button, however elastic search still fails. Will it be possible to have a zoom chat, so I can learn how to setup and run elastic search tests locally? Thanks

Yes I will be available all day tomorrow or next week after Monday if you prefer<EMAIL_ADDRESS>is my email you can send me an invite

@nitrosx , @Junjiequan Thanks for your efforts dedicated to this PR! First of all, I have finally managed to deal with the test.
Concerning the design. I do not have strong opinion on that, to my taste though your proposal seems a bit too dense.  But I agree that the design is not final, and this PR is more about functionality not look-n-feel.
So I agree - let's ask the community. But I would love to merge this one anyway, and then create another PR focused on the design aspect. Otherwise we risk to stuck in an endless limbo of moving inputs and buttons around ;)
Your thoughts?

@Junjiequan will review the PR tomorrow and if nothing major comes up, we will merge, although we should work quickly to address the address the need to optimize the space usage.
I created a new issue to collect feedback about the image that I posted above: #1479

I have two comments would love to hear your thoughts before we merge this.

Wouldn't it be better to fully stretch the search bar + button to align with content width below? I agree that we should make major layout improvements in another PR.
Two clear button works differently. one resets dataset table, the other one clear filter texts only. I wonder wouldn't it be better that both buttons work the same.

@Junjiequan thanks for your comments!

The truth is that css is still a voodoo magic for me. If you could commit directly into this branch the way you want it, that would be great! You will save tons of my nerve cells, and I will learn something 🤠

As a user I would be confused if innocent clear action on the input will reload the whole table. Maybe we should name the other button "Reset" or something,  to avoid mental mapping between these two


length() returning 0 for Dynamic object with keys

Pkl 0.26.0 (macOS 13.6.6, native)

I have the following json file
cat source.json
{ "topic": "hello" }

and the following pkl file
cat p.pkl
import "pkl:json"

hidden f = read?("file:./source.json") ?? "{}"
hidden p = new json.Parser {}.parse(f)

a = trace(p)
b = trace(p.length())

the output of the trace is
pkl eval p.pkl
pkl: TRACE: p = new Dynamic { topic = "hello" }
pkl: TRACE: p.length() = 0
a {
  topic = "hello"
}
b = 0

What could be going on?
The documentation of length() in Dynamic states

function length(): Int
Returns the number of elements in this object.

Pkl has three types of object members: properties, elements, and entries (see explanation here).
Dynamic.length, as you pointed out, will count the number of elements, and your object there has a property and no elements.
Try parsing into Mapping instead of Dynamic. This will parse JSON objects as Mapping, where Mapping#length counts the number of entries (note, this isn't the same thing as properties).
 import "pkl:json"

 hidden f = read?("file:./source.json") ?? "{}"
-hidden p = new json.Parser {}.parse(f)
+hidden p = new json.Parser { useMapping = true }.parse(f)

a = trace(p)
b = trace(p.length())

this worked ! thank you :)


Twig Migration: Run new twig tests in github actions

Currently the tests are run against the legacy twig it should be changed to run against the new twig

@bashlk so can we close this?

Yeah we can close this @justintemps


Update D6-Implementation2.md

Added additional implementation.

Accidentally made a pull request for the project not to my branch, oopsie.


Loading screens

Okay so, lets say for start just 1 loading frame for the summary right side table

I'm unsure on what size but i'll attach one option here

solved


Licensing Issue

Dear Repository Owners,
I was reading your preprint and was happy to see that you open sourced your code, but going through it I noticed that there are large parts of it that were taken from the napari-cluster-plotter, albeit with some modification. The colormap generation is identical napari-cluster-plotter colormap, napari-spatial-correlation-plottter colormap as well as some functions that were present in older versions of the cluster plotter, that are identical to lines of code in this repository: here and here
The napari-cluster-plotter is released under the BSD-3 License, which permits copying and reusing the code, given that the Copyright License including authors is reproduced as stated here. We ask you to add the copyright license to the respective files, where code was reused by adding a header reading:
"""
Copyright (c) 2022, DFG Cluster of Excellence "Physics of Life" TU Dresden: Robert Haase, Laura Zigutyte, Marcello Zoccoler, Ryan Savill, Johannes Müller and Max Planck Institute of Molecular Physiology Dortmund: Thorsten Wagner
"""
as well as maintaining the copyright license during further development and distribution. We also would be grateful if you cite the zenodo DOI as inspiration for your plugin in the manuscript. Thank you in advance!
Ryan Savill

Dear Ryan,
I unfortunately missed this issue and thus only partially rectified my mistake as explained in my email. I just pushed and released a new version with the headers, and an updated preprint should be uploaded in the new weeks.
Again, I apologize for the oversight and any inconvenience this may have caused. I'll keep this issue opened for now, please feel free to notify me if I have missed anything.
Best,
Jules Vanaret

Hey Jules,
No problem, these things can happen. Going through the files I think everything is fine and in agreement with the license. Thank you for taking action so quickly and updating the preprint as well! All the best for your publication and have a nice weekend.
Best, Ryan


Allow any timzone object keys for scheduler setValue

Create jQuery selection string for timezone object based on data-attributes and pass to time zone selectlist. Would love to test if it is an object first, but this is JavaScript.
Fixes #1471.

Correct that one thing, and I can verify that this works in AS :)

Updated. https://github.com/ExactTarget/fuelux/pull/1472/files#diff-8bc171525b04a15b620ce751fc57a0a8R466


allow ContextualData to be polyglot

If https://github.com/reactiverse/reactiverse-contextual-logging/blob/main/src/main/java/io/reactiverse/contextual/logging/ContextualData.java could be converted to interface and the right annotations would be in place, this module could also be used from a polyglot context.

Good point @pmlopes


Support for Bluetooth Tracker component

Bluetooth Tracker component is not working.
I think it requires bluetooth and libbluetooth-dev packages (see: https://github.com/home-assistant/home-assistant/pull/3423). Would it possible to add these packages to the image?

@uyorum - Would you mind pulling lroguet/rpi-home-assistant:latest-bt which has Home Assistant 0.50.2 with the packages you mentioned and tell me whether or not the Bluetooth Tracker component works with that image?

Thank you for your work! I tried the image and it works well. It recognizes the both of online and offline of a bluetooth device.
My environment:
$ cat /etc/issue
Raspbian GNU/Linux 8 \n \l
$ cat /etc/debian_version
8.0
$ docker version
Client:
 Version:      17.05.0-ce
 API version:  1.29
 Go version:   go1.7.5
 Git commit:   89658be
 Built:        Thu May  4 22:30:54 2017
 OS/Arch:      linux/arm

Server:
 Version:      17.05.0-ce
 API version:  1.29 (minimum version 1.12)
 Go version:   go1.7.5
 Git commit:   89658be
 Built:        Thu May  4 22:30:54 2017
 OS/Arch:      linux/arm
 Experimental: false

Command: docker run -d --name hass-bt --net=host lroguet/rpi-home-assistant:latest-bt
Tested with built-in bluetooth adapter on RaspberryPi 3B


[question] subprocVecEnv with curriculum or difficulty settings

Hello,
Is there some extension of SubProcVecEnv that allows for a "shared" datastructure? I am building environments with a curriculum structure / difficulty algorithm, so it would be nice if each parallel environment can come to a consensus about what difficulty level to be on, based on performance data. I'm thinking something like a multiprocess queue. I could implement this myself, but wondering if someone has already made elegant extensions of this nature.

Duplicate of #and https://github.com/hill-a/stable-baselines/issues/691


Reduce duplicate icons

The default view shows the same icon repeated 3x, in the tree, items and machines column. This seems cluttered, and wastes space. I'd like to show a single product icon per row (plus the machine icon). An icon column could be added and shown if the tree column is hidden, ensuring that one of the two is always visible.

Well.. the machines column shows a recipe icon, which may or may not be the same as the item icon. Though I could try to hide the recipe icon if it's the same, but it's actually not totally straightforward to know up front if it has the same icon.
Could hide the item column icon if tree column is present though, that much is definitely reasonable

An additional request: move the machine column next to the tree so that the machine/recipe/product icons are all grouped together.


couple more questions for onboarding

I rule and have completed some work on Case Manager that's ready for review!
two more onboarding questions I always ask and should document
no views
no issues
For reviewer:

Adjust the title to explain what it does for the notification email to the listserv.
Tag this PR:

feature if it contains a feature, fix, or similar. This is anything that contains a user-facing fix in some way, such as frontend changes, alterations to backend behavior, or bug fixes.
dependencies if it contains library upgrades or similar. This is anything that upgrades any dependency, such as a Gemfile update or npm package upgrade.

If it contains neither, no need to tag this PR.

godmode because docs


Increase the threshold for disk cleanup to 5GB free for 4.3

e97921cc74e8a69fccbe98ebcc6ee0f50a9ccbcf on master increased the DISK_MIN_AVAILABLE threshold to 5GB a few months ago, but it doesn't seem to be in the 4.3.5 release that happened since then.
The 1GB threshold is causing us problems (https://github.com/buildkite/elastic-ci-stack-for-aws/issues/465#issuecomment-555846619) so this PR cherrypicks that existing commit onto the 4.3 series branch, as a temporary work-around while waiting for the stalled #623 and/or #639.

Hi @lox, could I ask you to take a look at this PR? We're currently using a custom AMI built from this PR, instead of the 4.3.5 release.


Fix XML parsing error in Firefox

Fix for the issue #263 in Firefox (XML Parsing Error: not well-formed ...).

published in<EMAIL_ADDRESS>


Landing page re-work

Currently the landing page emphasizes tokenomics and "buy klima". We have matured, and with the launch of carbonmark, it's time to update the page.
KlimaDAO.finance should be reworked to emphasize

Our mission and vision
Our role as an org that builds products and infrastructure
? Governance, other benefits of a DAO?
? Participation and exposure via the KLIMA token?
Hiring / join us etc.

[ ] ideally with no changes to layout, just content :)
[ ] Make sure to connect Carbonmark and link users to it
[ ] Re-visit the content in /community and /contact
[ ] What to do about love letters and infinity? I say, scrap em'

The klimadao homepage is being redesigned


Autobahn Failure: Many failures when in non-Windows over SSL

From @anurse on Friday, July 15, 2016 10:14:56 AM
Most of the test cases fail when running on a non-Windows platform using Kestrel's built-in SSL implementation.
Copied from original issue: aspnet/WebSockets#102

From @Tratcher on Friday, July 15, 2016 10:16:55 AM
'Most'? Does the client just not like the self-signed cert?

From @anurse on Friday, July 15, 2016 10:18:32 AM
No, the handshake completes and then the connection terminates abruptly at some point. Some tests do succeed though.

From @muratg on Wednesday, July 27, 2016 12:51:39 PM
Putting in 1.1 for now for further investigation to see if there are possible product bugs in the stack


[FEAT]: Pen icon on dropdown selection

Is your feature request related to a problem? Please describe.
Whether I choose 'solid' , 'dotted' or any other, the pen icons stays same, it does not give any feel that a different style has been selected.

Describe the solution you'd like
When i select say 'solid', the pen icon should change to the corresponding icon that depicts that Solid pen option has been se;ected. same applies to all other options too.
@singodiyashubham87 , kindly assign the issue to me.

@AMANVISHWAKARMA27 Assigned you the issue, Best of Luck :)

I want to work in this issue. Please assign me this task.

I want to work in this issue. Please assign me this task.

@Mahimatestgithub Already assigned, An issue can't be assigned to multiple person.

closing due to inactivity.


Some auv2 changes for clap saw demo test case

identifier _ vs -
plist created correctly

I can now run the clap saw demo in the debugger with tracktion pluginval to see what fails, at least

oh shoot don't merge this i left a debug in

OK this is ready for merge now thanks!


Unable to parse reactions

Hi there. Appreciate for the good works!
I've tried this crate and it almost works fine! :+1:
One thing, it raises an error when it's received reactions.
Unable to deserialize slack message, error: Json Error: Error("missing field `message`", line: 0, column: 0): json: {"type":"reaction_added","user":"U69XXXXXX","item":{"type":"message","channel":"C6XXXXXXX","ts":"1547099852.002900"},"reaction":"+1","i
tem_user":"U69XXXXXX","event_ts":"1547112278.003200","ts":"1547112278.003200"}

Could you fix this?
Regards.

When I match on the Event::ReactionAdded I don't get anything, but for some reason the reaction_added event matches on Event::PrefChange.


Api documentation link is not working

Hi
This is not really an  issue but can you please enable the Api documentation link.

@subratafouzder In the meantime you can use this link http://www.capitalone.io/Hygieia/getting_started.html   and scroll down to the "API Layer"

@subratafouzder - The API documentation link is updated: https://github.com/capitalone/Hygieia/blob/gh-pages/pages/hygieia/setup.md


Updated validations.py python script. Closes: #1

Updated validations.py python script.
Fixed the behavior of validate_user function in validations.py.
Fixes #<issue_number_goes_here>

It's a good idea to open an issue first for discussion.

[ ] Tests pass
[ ] Appropriate changes to README are included in PR

Hello, CLA has been signed from my side.


fix(graph_building): change add_initializer to return a Tensor; make shape inference optional

Initializer must be an input. Otherwise, there is no torch._C.Value to repreent it in torch._C.Graph.
Shape inference fails for custom op, so it should be optional until we fix it.

Curious when would an initializer be an input?

It'd be nice to have a more informative title

I am going to work on the same PR.

@BowenBao ptal

unexpected success 😃

@justinchuby We still need the exporter side changes. Input is added twice for initializer.
This PR LGTM. It'd be great to add unittest covering the desired use case of adding initializer and using its returned value. Non blocking.

@titaiwangms could you help making this change in https://github.com/pytorch/pytorch/pull/96350?

This PR LGTM. It'd be great to add unittest covering the desired use case of adding initializer and using its returned value. Non blocking.


Get report for a time period, not a single day.

Hi.
Im getting the report with this code snipped. $request = $client->requestReport(
"campaigns",
array(
"reportDate" => "20210815",
// "campaignType" => "sponsoredProducts",
"metrics" => "campaignName,impressions,clicks,cost"
)
);`
Is there any way to get report for a time range, for example last 7 days or last 30 days?
Thank you.

Hi
The ads api does not support time ranges at the moment. You need to call the api per day. Is there a reason you prefer time ranges vs calling the API per day?


Startrails Program Doesn't Accept Brightness parameter

The startrails program does not appear to accept the -b brightness parameter and only used the default value stored in the program.

Right you are!  I'm fixing it now and submitting a PR.   Nice find, thanks!


Document the API

Migrated from https://github.com/bilaalrashid/ReadBeeb/issues/16
As we move towards making this project open-source, we will want to increase documentation of how the APIs used by this app works. This was started in https://github.com/bilaalrashid/ReadBeeb/blob/main/Docs/API.md, however, a simple markdown file doesn't allow us to easily capture all the nuances and options of the API. Perhaps defining it in OpenAPI specfile may be a better option. This would also allow us to easily auto-generate human-readable docs in HTML. We would want to investigate how best to host those docs.

This has now been deployed to https://bilaalrashid.github.io/bbc-news-swift/


enemies communicate target

Enemies communicate the target with neighbours.
Alert neighbours.

npc manager class?

propagates messages to all registered npcs

Maybe sensing areas on enemies are the way to do it?

when an enemy goes into attack state, find other enemy sensing areas that overlap and send a signal or call a method?

Do sensing areas detect the state of other nodes, or do they become eligible to receive notifications from other sensing areas?

Reverse to idea above, have a self area, and check for others' overlapping sensing areas, and call a method on them.

an NPC's sensing area is for sensing events and objects, not for deciding who to send a sense to.
so if a sensable's self-area overlaps NPC's sensing areas, they can sense a sense being sent.

Different sensables

visible source
sound source
scent source
message source (like enemies being able to talk to allies)


🐻❄ Building NFT Projects with Limited/No Investment !

Description :
🖼 I'll discuss how to build, sell NFT, and partner with companies and celebrities with limited/no investment. I will also talk about roadmaps, utilities, collaborations, artwork, giveaways, auditing, discord, and Twitter to help build a stable NFT project.
Talk Style:
10 min-Ted Style Talks, 30 min Regular Talks
Talk Audience Type:
Beginner to Intermediate
About the speaker:
I'm Rahul Arepaka. 19 y/o with a passion for robotics, agriculture, and blockchain. Co-founder of Ice Bear Society and building Agri-tech with Web3.0.
About Ice Bear Society :
❄ The Ice Bear Society is a collection of 3333 unique Ice Bears shilling on the Fantom Blockchain that strives to be the highest value NFT project.
🐻❄  An NFT project that aims to conserve polar bears by donating 33% of the total sales to improve their den conditions and protect them from extinction.
🚨Built on the Fantom Network, they have also established a bridge to ensure a smooth transition from other blockchain platforms such as Polygon, Ethereum, etc.
😊With a doxxed team and experience team from India which aims to become one of the most significant mission-driven NFT projects from India.
🤝 To further broaden the scope of the Ice Bear Society, Ice Bear Society has collaborated with renowned Telugu film director Tharun Bhascker, Indian stylist Neeraja Kona, numerologist Sheelaa M Bajaj, and model Liudmyla Tkachenko.
🦄 Additionally, Partnered with Hoodoi.com, Umbria Network – Defi, and NFT Garage and is also listed on NFTKey - Marketplace, TOFUNFT, and Paintswap Marketplace (The biggest marketplace for Fantom Based NFT Projects).

@adiig7 any update on my proposal?


Footer version number invisible (1% opacity) on live website

Observed on master at tag 1.1.0.
When running on the local machine, the version number is clearly visible:

However, on the live site, it is not:

Note that the opacity is 50% on the local version (as it should be), but 1% on the live version.
CSS for footer version label (found in ui/src/App.css):

Fixed by a6297df
Replaced opacity properties with rgba.


Dummy WIndow not working

The new feature is not creating the new dummy window. It does not even appear on the log.

My bad indeed. I made it work only with remote_desktop=1. Will fix.

Fixed in 425e26e

Thx. Working perfectly now.


Example App Causes Error When Installed Beneath an Existing App

Just a heads-up about installing this within an existing Phoenix app, for example inside of the web/elm directory...
After running elm-github-install the "example" app ends up in web/elm/elm-stuff. Then if you run "mix compile" from the root directory of the Phoenix app you're embedding Elm within, the gettext compiler isn't happy with the "example" app that comes with "elm-phoenix". You get the following error:
== Compilation error on file web/elm/elm-stuff/packages/saschatimme/elm-phoenix/0.2.0/example/web/gettext.ex ==
** (ArgumentError) unknown application: :elm_phoenix
A work-around is simply to remove the web/elm/elm-stuff/packages/saschatimme/elm-phoenix/0.2.0/example directory. I wonder if perhaps there's a way to not include the "example" app in these situations. In the meantime, it may be worth mentioning this on the README.
Thanks you for this great library!
Mike

@clarkware I ran into this, this was my solution, https://github.com/opsb/elm-optimist/commit/3ae1bb71b285e75fe92b7599d867765182a84044

Sorry that you run into a problem. Since the example app is also quite useful for integration tests it is not so easy to remove it at the moment. As an intermediate solution I will add a hint to the README.

Thanks, @opsb! That works great.

I suspect the directory structure in 1.3 will help with this.

https://gist.github.com/chrismccord/71ab10d433c98b714b75c886eff17357#move-static-assets-inside-self-contained-assets-directory


⚠ ClamAV has degraded performance

In 4ac6232, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 170 ms

Resolved: ClamAV performance has improved in ffd89a2.


Check attached status in removeVMDK before trying to remove volume

fixes #719 #716

In the absence of our own locking framework around vmdk + key/val and the existing bug, this seems like a reasonable fix that will reduce the probability of hitting the bug.
@brunotm did you run any tests for this change locally? Can you update the results?

I ran a quick test for this code change.
ESX log on delete when volume is in use
07/14/16 03:40:13 2760808 [photon.vsan.2-storage2] [DEBUG  ] lib.vmci_reply: VMCI replied with errcode 0
07/14/16 03:40:13 2760808 [photon.vsan.2-storage2] [DEBUG  ] Released lock: storage2
07/14/16 03:40:13 2760808 [MainThread] [DEBUG  ] lib.vmci_get_one_op returns 4, buffer '{"cmd":"remove","details":{"Name":"storage2"}}'
07/14/16 03:40:13 2760808 [photon.vsan.2-storage2] [DEBUG  ] LockManager.get_lock: new lock: storage2, <thread.lock object at 0xfffa9770>
07/14/16 03:40:13 2760808 [photon.vsan.2-storage2] [DEBUG  ] LockManager existing locks in store: [u'storage2']
07/14/16 03:40:13 2760808 [photon.vsan.2-storage2] [DEBUG  ] Trying to aquire lock: storage2
07/14/16 03:40:13 2760808 [photon.vsan.2-storage2] [DEBUG  ] Aquired lock: storage2
07/14/16 03:40:13 2760808 [photon.vsan.2-storage2] [DEBUG  ] get_datastore_name: path=vsan:5201dd577fe793bd-112186a6c2b42e0c name=['vsanDatastore']
07/14/16 03:40:13 2760808 [photon.vsan.2-storage2] [DEBUG  ] get tenant vm_uuid=564d6f23-eabb-1b63-c79d-2086cca704d5 tenant_id=4acd19ee-1ed6-4716-bcda-c8637c9658f2
07/14/16 03:40:13 2760808 [photon.vsan.2-storage2] [DEBUG  ] Authorize: vm_uuid=564d6f23-eabb-1b63-c79d-2086cca704d5
07/14/16 03:40:13 2760808 [photon.vsan.2-storage2] [DEBUG  ] Authorize: datastore=vsanDatastore
07/14/16 03:40:13 2760808 [photon.vsan.2-storage2] [DEBUG  ] Authorize: cmd=remove
07/14/16 03:40:13 2760808 [photon.vsan.2-storage2] [DEBUG  ] Authorize: opt={}
07/14/16 03:40:13 2760808 [photon.vsan.2-storage2] [DEBUG  ] get tenant vm_uuid=564d6f23-eabb-1b63-c79d-2086cca704d5 tenant_id=4acd19ee-1ed6-4716-bcda-c8637c9658f2
07/14/16 03:40:13 2760808 [photon.vsan.2-storage2] [DEBUG  ] get_privileges tenant_uuid=4acd19ee-1ed6-4716-bcda-c8637c9658f2 datastore=vsanDatastore
07/14/16 03:40:13 2760808 [photon.vsan.2-storage2] [DEBUG  ] delete_volume=1
07/14/16 03:40:13 2760808 [photon.vsan.2-storage2] [INFO   ] cmd remove with opts {} on tenant_uuid 4acd19ee-1ed6-4716-bcda-c8637c9658f2 datastore vsanDatastore is allowed to execute
07/14/16 03:40:13 2760808 [photon.vsan.2-storage2] [DEBUG  ] Found /vmfs/volumes/vsanDatastore/dockvols/tenant1, returning
07/14/16 03:40:13 2760808 [photon.vsan.2-storage2] [DEBUG  ] executeRequest tenant1 /vmfs/volumes/vsanDatastore/dockvols/tenant1
07/14/16 03:40:13 2760808 [photon.vsan.2-storage2] [INFO   ] *** removeVMDK: /vmfs/volumes/vsanDatastore/dockvols/tenant1/storage2.vmdk
07/14/16 03:40:13 2760808 [photon.vsan.2-storage2] [DEBUG  ] Trying to acquire lock: <_RLock owner=None count=0> @ 0x5cc76d0c, caller: load, args: (u'/vmfs/volumes/vsanDatastore/dockvols/tenant1/storage2.vmdk',) {}
07/14/16 03:40:13 2760808 [photon.vsan.2-storage2] [DEBUG  ] Aquired lock: <_RLock owner='photon.vsan.2-storage2' count=1> @ 0x5cc76d0c, caller: load, args: (u'/vmfs/volumes/vsanDatastore/dockvols/tenant1/storage2.vmdk',) {}
07/14/16 03:40:13 2760808 [photon.vsan.2-storage2] [INFO   ] *** removeVMDK: /vmfs/volumes/vsanDatastore/dockvols/tenant1/storage2.vmdk is in use, VM uuid = 564d672f-0576-8906-7ba0-a42317328499
07/14/16 03:40:13 2760808 [photon.vsan.2-storage2] [INFO   ] executeRequest 'remove' completed with ret={u'Error': 'Failed to remove volume /vmfs/volumes/vsanDatastore/dockvols/tenant1/storage2.vmdk, is in use by VM uuid = 564d672f-0576-8906-7ba0-a42317328499.'}
07/14/16 03:40:13 2760808 [photon.vsan.2-storage2] [DEBUG  ] lib.vmci_reply: VMCI replied with errcode 0
07/14/16 03:40:13 2760808 [photon.vsan.2-storage2] [DEBUG  ] Released lock: storage2

The volume continues to be in good state on reattach and remove fails if the volume is attached.

@kerneltime, sorry for not posting the tests earlier.
from host1:
root@dev01:/usr/lib/go/src/github.com/vmware/docker-volume-vsphere# docker volume create -d vmdk --name vol$$-1
vol115475-1
root@dev01:/usr/lib/go/src/github.com/vmware/docker-volume-vsphere# docker run -it -v vol$$-1:/mnt busybox
/ #

from host2:
root@vsc01:~# docker volume rm vol115475-1
Error response from daemon: Error while removing volume vol115475-1: remove vol115475-1: VolumeDriver.Remove: Failed to remove volume /vmfs/volumes/datastore2/dockvols/vol115475-1.vmdk, is in use by VM uuid = 4236919a-d0fd-831b-4c58-4e8bf8b0cfff.

from esx:
11/08/16 19:02:01 829948 [vsc01-vol115475-1] [INFO   ] *** removeVMDK: /vmfs/volumes/datastore2/dockvols/vol115475-1.vmdk is in use, VM uuid = 4236919a-d0fd-831b-4c58-4e8bf8b0cfff
11/08/16 19:02:01 829948 [vsc01-vol115475-1] [INFO   ] executeRequest 'remove' completed with ret={u'Error': 'Failed to remove volume /vmfs/volumes/datastore2/dockvols/vol115475-1.vmdk, is in use by VM uuid = 4236919a-d0fd-831b-4c58-4e8bf8b0cfff.'}
11/08/16 19:02:01 829948 [vsc01-vol115475-1] [DEBUG  ] lib.vmci_reply: VMCI replied with errcode 0
11/08/16 19:02:01 829948 [vsc01-vol115475-1] [DEBUG  ] Released lock: vol115475-1

from host1:
/ # root@dev01:/usr/lib/go/src/github.com/vmware/docker-volume-vsphere# docker ps -a
CONTAINER ID        IMAGE               COMMAND             CREATED             STATUS                     PORTS               NAMES
0046fbd8ce5f        busybox             "sh"                3 minutes ago       Exited (0) 6 seconds ago                       pensive_lumiere
root@dev01:/usr/lib/go/src/github.com/vmware/docker-volume-vsphere# docker rm 0046fbd8ce5f
0046fbd8ce5f
root@dev01:/usr/lib/go/src/github.com/vmware/docker-volume-vsphere# docker volume ls
DRIVER              VOLUME NAME
vmdk                vol115475-1
root@dev01:/usr/lib/go/src/github.com/vmware/docker-volume-vsphere# docker volume rm vol$$-1
vol115475-1
root@dev01:/usr/lib/go/src/github.com/vmware/docker-volume-vsphere#

from esx:
11/08/16 19:05:48 829948 [dev01-vol115475-1] [INFO   ] *** removeVMDK: /vmfs/volumes/datastore2/dockvols/vol115475-1.vmdk
11/08/16 19:05:48 829948 [dev01-vol115475-1] [DEBUG  ] Trying to acquire lock: <_RLock owner=None count=0> @ 0x58463dec, caller: load, args: ('/vmfs/volumes/datastore2/dockvols/vol115475-1.vmdk',) {}
11/08/16 19:05:48 829948 [dev01-vol115475-1] [DEBUG  ] Aquired lock: <_RLock owner='dev01-vol115475-1' count=1> @ 0x58463dec, caller: load, args: ('/vmfs/volumes/datastore2/dockvols/vol115475-1.vmdk',) {}
11/08/16 19:05:48 829948 [dev01-vol115475-1] [DEBUG  ] Running cmd /sbin/vmkfstools -U  /vmfs/volumes/datastore2/dockvols/vol115475-1.vmdk
11/08/16 19:05:49 829948 [dev01-vol115475-1] [INFO   ] executeRequest 'remove' completed with ret=None
11/08/16 19:05:49 829948 [dev01-vol115475-1] [DEBUG  ] lib.vmci_reply: VMCI replied with errcode 0
11/08/16 19:05:49 829948 [dev01-vol115475-1] [DEBUG  ] Released lock: vol115475-1

As mentioned before, this PR is not a fix but a way to reduce the probability of getting into a bad state. The code change here is straightforward with the caveat that the kv store is not authoritative for locking state. To make the source authoritative I would recommend vmfsfilelockinfo
[root@localhost:/vmfs/volumes/57302fae-961b9cf9-2e49-000c29acb565/dockvols/tenant1] vmfsfilelockinfo -p storage-flat.vmdk
vmfsfilelockinfo Version 1.0
Looking for lock owners on "storage-flat.vmdk"
"storage-flat.vmdk" is locked in Exclusive mode by host having mac address ['00:0c:29:ac:b5:65']
Please configure ESXi firewall to connect to Virtual Center
[root@localhost:/vmfs/volumes/57302fae-961b9cf9-2e49-000c29acb565/dockvols/tenant1] vmfsfilelockinfo -p storage-flat.vmdk
vmfsfilelockinfo Version 1.0
Looking for lock owners on "storage-flat.vmdk"
"storage-flat.vmdk" is not locked by any ESX host and is Free

The fix is good and a missing check on the removeVMDK() path. With tenant based auth and multiple VMs in a tenant and no guarantee on all those VMs running on the same host this check on the remove path is really the bug.

@govint
Done.


[13.0] Shorten Filters

Is your feature request related to a problem? Please describe.
It seems strange to me to specify HTTP filters and Eloquent filter separately, for example:
public function query(): iterable
{
    return [
        'users' => User::with('roles')
            ->filters(UserFiltersLayout::class)
            ->filtersApplySelection(UserFiltersLayout::class)
            ->defaultSort('id', 'desc')
            ->paginate(),
    ];
}

Describe the solution you'd like
We could use an argument to automatically call it later inside the class:
public function query(): iterable
{
    return [
        'users' => User::with('roles')
            ->filters(UserFiltersLayout::class)
            ->defaultSort('id', 'desc')
            ->paginate(),
    ];
}

Additional context
I find the risk of current and future problems very small. This will also work with passing a separate array with filters:
public function query(): iterable
{
    return [
        'users' => User::with('roles')
            ->filters([
                RoleFilter::class,
            ])
            ->defaultSort('id', 'desc')
            ->paginate(),
    ];
}

As this issue is referenced in a commit I will close it.


Add respone time to monitor list with bottom heartbeat bar mode

⚠ Please verify that this feature request has NOT been suggested before.

[X] I checked and didn't find similar feature request

🏷 Feature Request Type
UI Feature
🔖 Feature description
When "bottom heartbeat bar" is enabled, the monitoring lines are very thick and not informative
✔ Solution
Add respone time to monitor list with bottom heartbeat bar,
Example
❓ Alternatives
No response
📝 Additional Context
No response

@Tirarex the example you linked to does not exist anymore.
Could you attach it as a github attachment instead?


New release for some safe-apps ( transaction builder...)

New release for some safe-apps ( transaction builder...)
Compound app
WalletConnect app
Tx Builder App
Drain Account App

@francovenica , while testing some of the issues related to changes in Transaction builder, I updated our "Transaction builder"  test cases with additional cases. The cases contain contracts addresses that may be used for testing

So I tried the test cases that Liliya left with some contracts there (Thanks Liliya)

Tried the ETH field to send multiple ETH tx to accounts non-owners and owners.
Tried queue tx where tx with eth were sent to a contract and a tx that would fail if executed. Even though the tx says it fails, the "send eth" action actually is executed (which is fine, check snapshot bellow)
Tried and ERC20 contract to send Dai to several accounts and it worked fine
Tried a Mintable token contract that works on rinkeby and minted some tokens: 0x029b4ec0e1a01bceffb64591b23315b1d81bd82a
Checked the ETH field only shows for payable methods or for account addresses

Keep repeating these and queuing 6 or 7 tx at the same time checking they work. Also checking anything I could get my hands on, but on rinkeby there only so much you can do since contracts are just dummies
Didn't had issues, but Is hard to say that this will be 100% bug free. I will check it again in the regression
Snapshots
The tx failed because one of the actions was created to fail, but the action 1 was a "send eth" type of tx and that one went through fine


Add ESLint for better code readability and uphelding set coding rules

Is your feature request related to a problem? Please describe.
The current project lacks consistent formatting standards or code formatters and linters, leading to potential readability issues and difficulties in maintaining the codebase.
Describe the solution you'd like
Implement ESLint for the project to enforce consistent coding standards, identify potential errors, and maintain code quality across the codebase. ESLint will help ensure adherence to predefined coding conventions, enhancing code readability and reducing the likelihood of bugs or inconsistencies.
Describe alternatives you've considered
Prettier can be implemented which is just a code formatter, so it would only check discrepancies in code through pre-set rules.However, ESLint is widely adopted and provides robust customization options and extensibility, making it a versatile and popular choice for code analysis and enforcement.

@mendacium-a11y are you interested in working on the above issue?

yes

@mendacium-a11y assigning you the issue, go ahead please


please send tv hdim1 to hdim2

please send me script tv hdim1 or hdim2

I do not understand what you are asking for.

I do not understand what you are asking for.

Hello ollo69,
I can only think that he wants to know how to integrate more than just TV and HDMI.
Like: TV, HDMI 1, HDMI2, HDMI3

Should close this issue. OP doesn't clarify his cryptic post


The pad is not empty after clearOnDoubleClick

After using the clearOnDoubleClick feature, the pad is not empty (isEmpty() == false).
I want to use the OnSignedListener to toggle a button state but onSigned is always called after the double click gesture.
If you look at this line, you can see that something is drawn after MotionEvent.ACTION_UP events preventing the pad to be cleared properly.

I've made a PR to fix this. As you can see on #91

FYI: #107  fixes this issue and also introduces better double click handling.