Install Rasa_Core 0.8.3 fails on Windows10 with Python version 3.6.4 due to tensorflow version not available

Rasa Core version:0.8.3
Python version: 3.6.4
Operating system (windows, osx, ...):Windows 10
Issue:
When I tried to install rasa_core using pip install rasa_core the following output comes and the rasa_core installation stops
Collecting rasa_core   Downloading rasa_core-0.8.3.tar.gz (76kB)     100% |████████████████████████████████| 81kB 173kB/s Collecting jsonpickle (from rasa_core)   Downloading jsonpickle-0.9.6.tar.gz (67kB)     100% |████████████████████████████████| 71kB 341kB/s Collecting six (from rasa_core)   Downloading six-1.11.0-py2.py3-none-any.whl Collecting redis (from rasa_core)   Downloading redis-2.10.6-py2.py3-none-any.whl (64kB)     100% |████████████████████████████████| 71kB 355kB/s Collecting fakeredis (from rasa_core)   Downloading fakeredis-0.9.0-py2.py3-none-any.whl Collecting nbsphinx (from rasa_core)   Downloading nbsphinx-0.3.1-py2.py3-none-any.whl Collecting pandoc (from rasa_core)   Downloading pandoc-1.0.2.tar.gz (488kB)     100% |████████████████████████████████| 491kB 1.2MB/s Collecting future (from rasa_core)   Downloading future-0.16.0.tar.gz (824kB)     100% |████████████████████████████████| 829kB 420kB/s Collecting numpy>=1.13 (from rasa_core)   Downloading numpy-1.14.1-cp36-none-win32.whl (9.8MB)     100% |████████████████████████████████| 9.8MB 99kB/s Collecting typing>=3.6 (from rasa_core)   Downloading typing-3.6.4-py3-none-any.whl Collecting requests (from rasa_core)   Downloading requests-2.18.4-py2.py3-none-any.whl (88kB)     100% |████████████████████████████████| 92kB 592kB/s Collecting graphviz (from rasa_core)   Downloading graphviz-0.8.2-py2.py3-none-any.whl Collecting Keras (from rasa_core)   Downloading Keras-2.1.4-py2.py3-none-any.whl (322kB)     100% |████████████████████████████████| 327kB 425kB/s Collecting tensorflow (from rasa_core)   Could not find a version that satisfies the requirement tensorflow (from rasa_core) (from versions: ) No matching distribution found for tensorflow (from rasa_core)
Content of domain file (if used & relevant):

Try installing tensorflow separately.

I had the same problem. This project references tensorflow 1.4.1. But there was no windows pip package for tensorflow released in this version. I needed to install manually.
pip install tensorflow==1.5.0

I also needded to install pypiwin manually.
pip install pypiwin32

I got more problems with unsupported instructions on windows tensorflow.
For example I got errors:
Your CPU supports instructions that this TensorFlow binary was not compiled to use: AVX AVX2
So in the ended I started to use docker linux machine for development.
Developing in windows for these cases simply sux :(

But the above CPU message is just a warning, so that should be fine. Was there any other error? If the only issue is the missing release for the 1.4.1 version, we can surely update to 1.5.0

Yes, there were a lot of deprecation messages, when I tried to run the project based on official tutorial https://core.rasa.ai/tutorial_basics.html .
(botLibs) C:\GIT\simplebot>python -m rasa_core.run -d models/dialogue -u models/nlu/default/current
C:\GIT\simplebot\botLibs\lib\site-packages\h5py\__init__.py:36: FutureWarning: Conversion of the second argument of issubdtype from `float` to `np.floating` is deprecated. In future, it will be treated as `np.float64 == np.dtype(float).type`.
  from ._conv import register_converters as _register_converters
Using TensorFlow backend.
2018-03-13 15:24:59.700580: I C:\tf_jenkins\workspace\rel-win\M\windows\PY\36\tensorflow\core\platform\cpu_feature_guard.cc:137] Your CPU supports instructions that this TensorFlow binary was not compiled to use: AVX AVX2
Bot loaded. Type a message and press enter:

Hey! How are you?
1: great (great)
2: super sad (super sad)
1
C:\GIT\simplebot\botLibs\lib\site-packages\sklearn\preprocessing\label.py:151: DeprecationWarning: The truth value of an empty array is ambiguous. Returning False, but in future this will result in an error. Use `array.size > 0` to check that an array is not empty.
  if diff:
Bye

Hey! How are you?
1: great (great)
2: super sad (super sad)
2
C:\GIT\simplebot\botLibs\lib\site-packages\sklearn\preprocessing\label.py:151: DeprecationWarning: The truth value of an empty array is ambiguous. Returning False, but in future this will result in an error. Use `array.size > 0` to check that an array is not empty.
  if diff:
Bye
2
C:\GIT\simplebot\botLibs\lib\site-packages\sklearn\preprocessing\label.py:151: DeprecationWarning: The truth value of an empty array is ambiguous. Returning False, but in future this will result in an error. Use `array.size > 0` to check that an array is not empty.
  if diff:
Bye
2
C:\GIT\simplebot\botLibs\lib\site-packages\sklearn\preprocessing\label.py:151: DeprecationWarning: The truth value of an empty array is ambiguous. Returning False, but in future this will result in an error. Use `array.size > 0` to check that an array is not empty.
  if diff:
Bye
hey
C:\GIT\simplebot\botLibs\lib\site-packages\sklearn\preprocessing\label.py:151: DeprecationWarning: The truth value of an empty array is ambiguous. Returning False, but in future this will result in an error. Use `array.size > 0` to check that an array is not empty.
  if diff:
Hey! How are you?
1: great (great)
2: super sad (super sad)
2
C:\GIT\simplebot\botLibs\lib\site-packages\sklearn\preprocessing\label.py:151: DeprecationWarning: The truth value of an empty array is ambiguous. Returning False, but in future this will result in an error. Use `array.size > 0` to check that an array is not empty.
  if diff:
Great carry on!

Chatbot in this case did not behave as described in tutorial.

Try installimg the below wheel file manually.
tensorflow-1.6.0-cp36-cp36m-win_amd64.whl
This one worked for me!

what is the fix?

@ratheeshgit if you're getting an error, please create a new issue.


ConsoleConfigureAction: Use rich output for Cygwin's mintty by default

Previously, when running Gradle from Cygwin's / MSYS' mintty terminal,
Gradle did use plain output with --console=auto. Fix this by in fact
forcing ANSI output if the TERM environment variable is set to xterm and
no --color=plain is given.

@adammurdoch Mind having a look?

@sschuberth Thanks for making the console output more robust for mintty.
All those poor tortured souls out there forced to develop software on Windows, will soon be in a little less pain because of your kindness,
Pepper

@sschuberth Bad news. https://github.com/gradle/gradle/commit/f3ed866b502aec6b73ce80e0f6f94ae4ae2fe06d
As the commit message explains:

This code isn't actually sensitive to whether or not there is a tty attached to STDOUT and STDIN.
If we run ./gradlew tasks > out.log our TERM variable will still say xterm, but the STDOUT stream will not be a tty, and we shouldn't be formatting the output for a terminal.

The advice given internally by @adammurdoch is that you could provide an implementation of ConsoleDetector which forks a process to run tty -s which would reliably detect that the process has a tty connection. Adam also stresses that the logic of detection should really live in the ConsoleDetector, and not in ConsoleConfigureAction.

@eljobe Thanks for the feedback and thorough testing. I'll try to find the time to improve this over the next weeks.

Looks like the same functionality was now implemented by https://github.com/gradle/gradle/pull/8189 🎉


Spyder Tutorial font too small to read

Description
On my Surface Pro 4, the font is too small to read, I suppose because it's not sized according to display PPI.  There is a zoom control, but the font shrinks again as soon as I click on a link to visit a different page of the tutorial.  This is on Windows 10.
Version and main components

Spyder Version: 3.1.4
Python Version: 3.5.3
Qt Versions: 5.6.2, PyQt5 5.6 on Windows

Dependencies
pyflakes >=0.6.0 :  1.5.0 (OK)
pep8 >=0.6       :  1.7.0 (OK)
pygments >=2.0   :  2.2.0 (OK)
qtconsole >=4.2.0:  4.3.0 (OK)
nbconvert >=4.0  :  5.2.1 (OK)
pandas >=0.13.1  :  0.20.1 (OK)
numpy >=1.7      :  1.12.1 (OK)
sphinx >=0.6.6   :  1.5.6 (OK)
rope >=0.9.4     :  0.9.4-1 (OK)
jedi >=0.9.0     :  0.10.2 (OK)
matplotlib >=1.0 :  2.0.2 (OK)
sympy >=0.7.3    :  1.0 (OK)
pylint >=0.25    :  1.6.4 (OK)

Actually, after I restarted Spyder, the tutorial fonts were somewhat bigger -- I guess it's necessary to restart after changing the High DPI preference.  Would be nice to get a notification when that control is set.

This will be fixed in Spyder 3.2, I think. Please reopen this issue if that's not the case once we release it (in two or three weeks).


Create an allocate_buffer(std::string) function

The constructor mqtt::buffer(std::string) is disabled to avoid people using mqtt::buffer thinking that it won't allocate-and-copy.
We should also provide an allocate_buffer() function for std::string, in addition to iterators.

I think that
buffer allocate_buffer(string_view)

is better.
That can support both string and string_view. And thanks to its name, user can understand it apparently allocates memory.
What do you think?

I agree with you

I will sent a PR to add it.
I just noticed that allocate_buffer() is in literals (inline) namespace. I will move it outside of literals namespace.

I noticed the comment of allocate_buffer() is bad. I will fix it too.

Implemented as #349


Add homebrew path for macOS

In order to use this library on Mac, we need to add the homebrew path to use azure function core tools.
You can find the azure core tools installation guide for mac HERE.

@briandunnington / @kendaleiv
Do you think we can add capabilities from macOS?

like @kendaleiv mentioned, not every piece supports non-Windows machines. i dont have a Mac to test on, but only the DebugProcess stuff should be Windows-specific (all of the rest of the code just relies on func.exe running and then making HTTP calls so should be cross-platform).
that said, if you are not using the DebugProcess stuff, you should be able to use the rest of the pieces, and this PR only adds a path to try so it wont hurt anything on non-Mac devices


Tiny fix to getPercentiles

Added two lines to utilities.getPercentiles to correctly handle case when data has size 0 or 1: return NaN vector of same size as requested percentiles of data.  That is, there is no such thing as "percentiles" of an empty dataset or a singleton.  This can come up when simulated or empirical moments are calculated, but no observations qualify.

This is a very tiny PR that can be merged immediately.  Adds two lines that prevent a certain error from arising.


viewConfig is not defined: 0.37 seems to have broken a lot of native modules

Creating an Animated component for a lot of packages throws a viewConfig is not defined error. Seems to be caused by https://github.com/facebook/react-native/commit/c9960817eea008b2703657066212002557e0d939
So far I've had it happen with https://github.com/react-native-community/react-native-video and https://github.com/react-native-community/react-native-svg
Should native modules be defining their own viewConfigs? (Don't seem to be docs on that?) Or is this something react-native should fix?

https://github.com/facebook/react-native/pull/10827


Add colour customisation to react components

brain dump todos

[ ] add 'XXXXX' prop to components that takes a set of colours
[ ] deprecate current 'theme' exports?

[ ] understand rationale for current theme stuff first

[ ] align design and code names for style object
[ ] only allow palette members in in the style object (too much? maybe just needs to be a CSS colour - check with akemi)

duplicate


reseting window over time

Hi,
I'm using Kapacitor in order to alert when a rate of some increasing value changes over time.
For example: The disconnection of servers on the last 10 minutes.
var windows = stream
	|from()
		.measurment('DisconnectionsCounter')
	|where(labmda: "server_name" == 'TestServer' and "path" =~ /^(.*)\.DisconnectionsCounter$/)
	|window()
		.period(10m)
		.every(10s)
		.align()

var previous = windows
	|first('value')

var current = windows
	|last('value')

previous
	|join(current)
		.as('previous', 'current')
	|eval(lambda: "current.last" - "previous.first")
		.as('rate')
	|alert()
		.id('DisconnectionsCounterOnTestServer')
		.info(labmda: "rate" == 0 OR "rate" > 0)
		.crit(labmda: "rate" > 0)
		.post('http://MyTestServer:8323')

Now, if i reset the value once a day the rate value is negative, bacause the last value is higher than the value after reseting(zero),
and so for the period(10m) of the window i have no way to tell if there were any disconnections.
The optimal solution for me is to "somehow" reset the window when i reset my disconnections counter or do the next logic
previous
	|join(current, min)
		.as('previous', 'current', 'min_value')
	|eval(lambda:"current.last" > "previous.first" ? windows|min())
		.as('current_value')
	|eval(lambda: "current.last" - "current_value")
		.as('rate')
	|alert()
		.id('DisconnectionsCounterOnTestServer')
		.info(labmda: "rate" == 0 OR "rate" > 0)
		.crit(labmda: "rate" > 0)
		.post('http://MyTestServer:8323')

As you can see, I need to do some if logic in eval. is it possible? or is there any patch i can to in order to achieve such behavior?

Use derivative with the nonNegative flag so that is skips negative results. This will compute the difference between each pair of points. Skipping the one pair of points where the rate is negative. Then you can sum or average the rate across the whole batch in order to get back the rate for the whole window. Its not exactly the same but it should work well.

For exmaple:
var windows = stream
    |from()
        .measurment('DisconnectionsCounter')
    |where(labmda: "server_name" == 'TestServer' and "path" =~ /^(.*)\.DisconnectionsCounter$/)
    |window()
        .period(10m)
        .every(10s)
        .align()
    |derivative()
      .as('rate')
      .nonNegative()
    |sum('rate')
      .as('rate')
    |alert()
        .id('DisconnectionsCounterOnTestServer')
        .info(labmda: "rate" >= 0)
        .crit(labmda: "rate" > 0)
        .post('http://MyTestServer:8323')

This might work for disconnection counters where the value needed is zero or more.
I tried this on my db insertion values but was unable to tell the difference between 10 insertion to 100 insertions. If i need the value of insertions in 10 seconds to be over 100 and reset the counter once a day i still encounter the same problem

The derivative also has a unit property that allows you to scale the rate but some denominator of time, in your case 10s. Can you share your TICKscript for db insertion values? Seems like we should be able to get this working.

var windows = stream
    |from()
        .measurment('InsertionsCounter')
    |where(labmda: "server_name" == 'TestServer' and "path" =~ /^(.*)\.InsertionsCounter$/)
    |window()
        .period(10m)
        .every(10s)
        .align()
    |derivative()
      .as('rate')
      .nonNegative()
    |sum('rate')
      .as('rate')
    |alert()
        .id('DisconnectionsCounterOnTestServer')
        .info(labmda: "rate" >= 100)
        .crit(labmda: "rate" > 100)
        .post('http://MyTestServer:8323')

It's pretty close to the disconnection counter. The only difference is that I need it to be more a 100 and not just something or nothing

If you add a unit(10s) to the derivative does that make it over 100?
var windows = stream
    |from()
        .measurment('InsertionsCounter')
    |where(labmda: "server_name" == 'TestServer' and "path" =~ /^(.*)\.InsertionsCounter$/)
    |window()
        .period(10m)
        .every(10s)
        .align()
    |derivative()
      .as('rate')
      .nonNegative()
      .unit(10s)
    |sum('rate')
      .as('rate')
    |alert()
        .id('DisconnectionsCounterOnTestServer')
        .info(labmda: "rate" >= 100)
        .crit(labmda: "rate" > 100)
        .post('http://MyTestServer:8323')

I am going to test this out locally to make sure I am understanding this correctly.

Playing around with the derivative I see that it doesn't quite work well as you don't know the elapsed time of the window. There are ways to get the elapsed time but it gets overly complicated fast.
But I had another idea that is simpler. What about always using the min of the window. In the case that no reset has occurred then it is the first point. In the case a reset occurred somewhere in the window it will start from there. You loose the first part of your window during the reset but since you suggested that it seems like that would be ok with you.
var windows = stream
    |from()
        .measurment('DisconnectionsCounter')
    |where(labmda: "server_name" == 'TestServer' and "path" =~ /^(.*)\.DisconnectionsCounter$/)
    |window()
        .period(10m)
        .every(10s)
        .align()

var previous = windows
    |min('value')

var current = windows
    |last('value')

previous
    |join(current)
        .as('previous', 'current')
    |eval(lambda: "current.last" - "previous.min")
        .as('rate')
    |alert()
        .id('DisconnectionsCounterOnTestServer')
        .info(labmda: "rate" == 0 OR "rate" > 0)
        .crit(labmda: "rate" > 0)
        .post('http://MyTestServer:8323')

Will that work?
Also #745 is adding if logic to evals.


Update contact info for advice for unmarried couples.

Affects all scenarios where the child was born before 1 July 2006 and father is unmarried,
for example: /register-a-birth/y/austria/father/no/2006-06-30
The tool used to say: 'Contact your local British embassy...' This has changed.
Users can contact the Overseas Registration Unit for advice at
<EMAIL_ADDRESS>

Looks good to me.


Performance change with NC_SHARE

As documented in nc_open, the NC_SHARE mode often enhances read speeds for NetCDF3 files with many (e.g. 100+) variables with large dimension sizes (t=UNLIMITED, z=50, y=300, x=500). This has been true for me on many systems with different versions of the netcdf library. My understanding is that this was related to buffering of variables along the unlimited dimension that was inefficient.
In a recent test, I found that I could not reproduce the speed enhancements with v4.4.1. Has this speed enhancement changed or can someone describe a test case known to reproduce the enhancements?

environmental information (i.e. Operating System, compiler info, java version, python version, etc.)
Operating System: Red Hat Enterprise Linux
CPE OS Name: cpe:/o:redhat:enterprise_linux:7.8:GA:server
Kernel: Linux 3.10.0-1062.12.1.el7.x86_64
Architecture: x86-64
Tested in python and nco via 4.9.4-alpha02..

a description of the issue with the steps needed to reproduce it

The commands below will reproduce the similar performance (not faster) using the netdf4-python bindings on a linux system using bash.
cat << EOF > test.py
import sys
import netCDF4 as ncf
import numpy as np
import os

writemode = sys.argv[1]
readmode = sys.argv[2]
keys = ['test%03d' % i for i in range(100)]
replications = 1

for i in range(replications):
    os.remove('test.nc')

    testf = ncf.Dataset('test.nc', format='NETCDF3_CLASSIC', mode=writemode)
    testf.createDimension('t', None)
    testf.createDimension('z', 10)
    testf.createDimension('y', 100)
    testf.createDimension('x', 100)
    getlen = lambda k: len(testf.dimensions[k])
    outshape = (24, getlen('z'), getlen('y'), getlen('x'))
    for key in keys:
        var = testf.createVariable(key, 'f', ('t', 'z', 'y', 'x'))
        var.units = 'none'
        var.long_name = key

    for key in keys:
        print(key, flush=True, end='.')
        vals = np.random.random(size=np.prod(outshape))
        var = testf.variables[key]
        var[:outshape[0]] = vals.reshape(outshape)

    print()
    testf.close()

testf = ncf.Dataset('test.nc', mode=readmode)
for key in keys:
    a = testf.variables[key][:]
    b = a + 2
    del a, b
EOF
time python test.py ws rs
time python test.py w r

Related discussion https://sourceforge.net/p/nco/discussion/9829/thread/85b29e80c7/?limit=25

My suspicion is that the issue is not NC_SHARE directly; as near as I can tell
that is the same between 4.4.1 and 4.7.4.
Rather,I think we (me?) mistakenly removed the LOCKNUMREC code
and that is the cause of the slowdown.

THe LOCKNUMREC code causes the use of the shmem package.
Is there any way for you to tell if your faster version is using shmem?

I’m on vacation, so can’t check that until next week (VPN etc). I’m not familiar with shmem . What should I do to check when I get back?

It appears that shmem is CRAY specific, which I assume you are not using.
So I am not sure what is going on. Do use use nc_set_base_pe() or nc_inq_base_pe( )?


Add possibility of marking multiple nested states as possible exit states

I'm making a souls inspired 3rd person fighting game right now, and I have a bunch of states, for movement as well as combat
problem is I need to be able to transition from most state to the fall state when my player is no longer touching the ground
Right now, afaik if I use nested states for combos & whatnot, my character won't go to the fall state until the combo ends, since it won't exit the combo state until its exit state is reached
the other solution is to not use nested states, but then I have to make a transition for the majority of states to the fall state, which isn't great
being able to mark nested states as "exitable" or something would mean being able to have a single "combo to fall" transition, and I'd even be able to exclude some moves from transitioning to fall if needed

root with "Fall" state and "Combo" nested state:

"Combo" nested state:

Let say when the current_state is "Combo/Combo2" and falling, it should directly transit to "Fall", am I right?
This is interesting, and it can potentially reduce a lot of unnecessary transitions.
Right now, I can think of 2 solutions:

Add exit() function to StateMachinePlayer, that allows to manually exit current nested state
Support marking any state as "exitable" with conditions attached(just like a transition), so that the state can directly transit to exit when conditions met

yes, this is what I meant, thank you


Remove generated NewClient factory method for C#.

Fixes #6986.
-- add better comments for generated client constructors.
-- Update examples.
Will need to remove occurences of "NewClient" from grpc.io docs.

LGTM, I believe this is on par with Node and PHP and other languages.

grpc.io documentation is already up to date.


Polish execution engine API invocation API

@bot-gradle test QFL please.

OK, I've already triggered QuickFeedbackLinux build for you.

@bot-gradle test QFL please.

OK, I've already triggered QuickFeedbackLinux build for you.


Publish Seq.Syntax package to NuGet

This will allow it to be consumed downstream, e.g. by Seq.App.HttpRequest and other packages.
(We should consider publishing Seq.Mail soon, too, to support third-party mail system integrations.)

Done!


prop-types: change NODE_ENV check for webpack 5

reported comment

Webpack 5 remove polyfill for node global variables when targeting browser. PSDS has a usage that check the process variable, it is causing an error to be thrown in webpack 5 because the process global variable is not available anymore.
However, I am wondering if the usage of process && process.env && process.env.NODE_ENV === 'production' is necessary from the beginning as the  process.env.NODE_ENV will be string replace at 'compile' time.
Could you guys help me take a look and see if the process && process.env && process.env.NODE_ENV can be removed?

suggest something more in line with the core prop-types pkg check https://github.com/facebook/prop-types/blob/master/index.js#L8

Triage: Will use just process.env.NODE_ENV to be compat with webpack@5.


Validation error when using non-consecutive vertex binding numbers

If I bind vertex buffers using binding numbers 0 and 2, leaving binding 1 unused
vkCmdBindVertexBuffers(cmdbuf, 0, 1, &buf1, &offset1;
vkCmdBindVertexBuffers(cmdbuf, 2, 1, &buf2, &offset2);

then I get this warning from validation layer:
ERROR:   DEFAULT: [DS] (0x0000000B) Cannot submit cmd buffer using deleted buffer 0x0.
Analyzing core_validation.cpp code it seems this warning appears because the layer finds that nothing is bound to binding 1. More specificially when we bind vertex buffer for binding 2 in updateResourceTracking the following lines of code are executed :
uint32_t end = firstBinding + bindingCount;
if (pCB->currentDrawData.buffers.size() < end) {
        pCB->currentDrawData.buffers.resize(end);
}

For binding 2 we have that end==3 and after resize element with index 1 is set to VK_NULL_HANDLE.
Then in validateResources we report a warning when we find VK_NULL_HANDLE for binding 1.

Hi, @kennyalive ,
This looks like a duplicate of issue #2371, which was recently fixed in PR #2372. It's merged into master here now, and will be included in the next SDK release.
I'm closing this issue assuming this is the case. Please re-open if you find otherwise.

Thanks! My bad I didn't check existing issues.


Run the first checkAndUpdate also asynchronously

When there are more than BufferSize (100) resources in the
file system, the first call will fill up the event channel
and block. Thus the server won't start properly.
Co-authored-by: Holger Oehm<EMAIL_ADDRESS>

I signed it!

I signed it!

@kyessenov @GregHanson gentle bump. Mind giving this an okay-to-test? This change is really tiny.

/ok-to-test
/assign @ozevren

Is there a 1.1 tracking bug?

@holgero: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
9f7ee9ac92bdf2c3e6974b693d6a5458d1bd22be
link
/test e2e-simpleTests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@holgero: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
9f7ee9ac92bdf2c3e6974b693d6a5458d1bd22be
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@holgero: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
9f7ee9ac92bdf2c3e6974b693d6a5458d1bd22be
link
/test istio-integ-k8s-tests

prow/istio-pilot-multicluster-e2e.sh
9f7ee9ac92bdf2c3e6974b693d6a5458d1bd22be
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Is there a 1.1 tracking bug?

I have changed the base to master, the fix is probably not important enough to include it in 1.1.

@holgero: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
9f7ee9ac92bdf2c3e6974b693d6a5458d1bd22be
link
/test istio-pilot-multicluster-e2e

prow/e2e-simpleTests-cni.sh
9f7ee9ac92bdf2c3e6974b693d6a5458d1bd22be
link
/test e2e-simpleTests-cni

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@holgero: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
9f7ee9ac92bdf2c3e6974b693d6a5458d1bd22be
link
/test istio-pilot-multicluster-e2e

prow/e2e-simpleTests-cni.sh
9f7ee9ac92bdf2c3e6974b693d6a5458d1bd22be
link
/test e2e-simpleTests-cni

prow/e2e_pilotv2_auth_sds.sh
9f7ee9ac92bdf2c3e6974b693d6a5458d1bd22be
link
/test istio_auth_sds_e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test istio_auth_sds_e2e

@holgero: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests-cni.sh
9f7ee9ac92bdf2c3e6974b693d6a5458d1bd22be
link
/test e2e-simpleTests-cni

prow/e2e_pilotv2_auth_sds.sh
9f7ee9ac92bdf2c3e6974b693d6a5458d1bd22be
link
/test istio_auth_sds_e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test e2e-simpleTests-cni
/test istio_auth_sds_e2e

@holgero: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e_pilotv2_auth_sds.sh
9f7ee9ac92bdf2c3e6974b693d6a5458d1bd22be
link
/test istio_auth_sds_e2e

prow/e2e-simpleTests-cni.sh
9f7ee9ac92bdf2c3e6974b693d6a5458d1bd22be
link
/test e2e-simpleTests-cni

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: holgero
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: diemtvu
If they are not already assigned, you can assign the PR to them by writing /assign @diemtvu in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@holgero: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e_pilotv2_auth_sds.sh
9f7ee9ac92bdf2c3e6974b693d6a5458d1bd22be
link
/test istio_auth_sds_e2e

prow/e2e-simpleTests-cni.sh
b20461a7c2f6efc5e336b99ac35378b1addd5438
link
/test e2e-simpleTests-cni

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@holgero: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e_pilotv2_auth_sds.sh
9f7ee9ac92bdf2c3e6974b693d6a5458d1bd22be
link
/test istio_auth_sds_e2e

prow/e2e-simpleTests-cni.sh
b20461a7c2f6efc5e336b99ac35378b1addd5438
link
/test e2e-simpleTests-cni

prow/istio-integ-k8s-tests.sh
b20461a7c2f6efc5e336b99ac35378b1addd5438
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wenchenglu Is there something to do, to get this PR merged?

@axel7born
you need an approval from someone in pilot/OWNERS. added Costin

/assign @diemtvu

/assign @GregHanson
/assign @rshriram

@axel7born: GitHub didn't allow me to assign the following users: rshriram.
Note that only istio members and repo collaborators can be assigned.
For more information please see the contributor guide

In response to this:

/assign @GregHanson
/assign @rshriram

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/not stale

/notstale

Hmm, seems there is no interest in this. Perhaps I should just allow the stale bot to close it?

Ah well, we have written our own mcp server in the mean time and do no longer need the ability to not block execution during startup when there exist more than 100 resources in the file system. This means I'll definitely allow the stale bot to close this next time it comes around...

Let's not wait for the stale bot.


Security: Protect against slow-loris attacks via WebSockets & gRPC

Web sockets should be disabled by default as they don't have limits on connection time or throughput, so can be used as the basis for a slow-loris attack.

User experience: WebSocket (and SDPY) requests should be refused with a specific status code and possibly a message that indicates they are disabled.
I'm not seeing an obvious status code for this purpose. The closest I see is 403 Forbidden:
The request contained valid data and was understood by the server, but the server is refusing action. (Usually used for auth so that might be confusing).
Alternatively we could use a custom status code which would make searching for the error easier. It should be a 5xx error since the issue is on the proxy config, not with the client request. E.g. 567 Upgrade Disabled

Is this normal proxy behavior? What about HTTP/2 requests doing gRPC streaming?

Also gRPC streaming: https://github.com/microsoft/reverse-proxy/issues/118#issuecomment-846309536

So you turn these on and then what?

Conclusion: We should have a timeout where we look for traffic from the server before closing the connections. Both WS and gRPC support ping/pong keep alive semantics, where the server can send a ping to keep the connection alive.

slow-loris wasn't the only consideration. For WebSockets there was concern about even allowing long-running protocols by default.
For gRPC streaming we also currently disable request body size limits.


Can we sort language programming select box by alphabetical ?

If you go http://github-awards.com/users?country=united+states example.
We will get select box that list programming language, but somehow I dont see its already sort.
Can we make that sorted ?

@mazipan, You can give a pull request 😄
Here's the file: languages.json
Not sure if the first few languages are kept there intentional @vdaubry

I think alphabetical sort is good for user.
But is there any concern why it sort like that ?

The first languages were sorted like thank to reflect most common ones according to github. The API also allows for an alphabetically sorted list.

Or can we change the component to show list of programming language to autocomplete input text, not dropdown like now ?
Because Its hard to me as user to change the selection if many data showing in dropdown that not sorted alphabeticaly.


update imprint and privacy policy (Datenschutzerklärung & Impressum) to match okfn.de/impressum

outdated. Contact email for Datenschutzbeschwerden needs to be<EMAIL_ADDRESS>(like on okfn.de/impressum).

please copy and paste from okfn.de/impressum - the part with Datenschutzerklärung is still outdated on codefor.de (imprint is already a-okay! ) thanks :)


NPE #11567

调用dubbo接口时如果参数为null则抛出异常调用失败。

Codecov Report

Merging #11572 (b1db50a) into 3.2 (551ff4a) will decrease coverage by 1.27%.
The diff coverage is n/a.

:exclamation: Current head b1db50a differs from pull request most recent head 8a540f7. Consider uploading reports for the commit 8a540f7 to get more accurate results

@@             Coverage Diff              @@
##                3.2   #11572      +/-   ##
============================================
- Coverage     68.67%   67.41%   -1.27%
+ Complexity      340        2     -338
============================================
  Files          3073     1508    -1565
  Lines        146695    62689   -84006
  Branches      24435     9189   -15246
============================================
- Hits         100745    42261   -58484
+ Misses        36882    16272   -20610
+ Partials       9068     4156    -4912

Impacted Files
Coverage Δ

...dubbo/common/status/support/LoadStatusChecker.java
41.66% <0.00%> (-16.67%)
:arrow_down:

...ting/exchange/support/header/HeartbeatHandler.java
59.52% <0.00%> (-7.15%)
:arrow_down:

...rg/apache/dubbo/rpc/protocol/dubbo/DubboCodec.java
72.35% <0.00%> (-4.88%)
:arrow_down:

.../apache/dubbo/remoting/transport/AbstractPeer.java
67.39% <0.00%> (-4.35%)
:arrow_down:

...c/main/java/org/apache/dubbo/rpc/RpcException.java
80.64% <0.00%> (-3.23%)
:arrow_down:

...moting/transport/netty4/NettyConnectionClient.java
75.48% <0.00%> (-2.59%)
:arrow_down:

.../remoting/transport/netty4/NettyClientHandler.java
80.95% <0.00%> (-2.39%)
:arrow_down:

...ache/dubbo/rpc/protocol/AbstractProxyProtocol.java
52.00% <0.00%> (-2.00%)
:arrow_down:

...bo/registry/client/OverrideInstanceAddressURL.java
33.73% <0.00%> (-1.21%)
:arrow_down:

.../src/main/java/org/apache/dubbo/rpc/RpcStatus.java
80.95% <0.00%> (-1.20%)
:arrow_down:

... and 1588 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

other pr fix it so close


Address apk update pause

Small bugfix to address specific apk update issue.
Running apk update does not close the DataDone channel unlike most other commands, leading to waiting for prompt from user before continuing. To address this use a goroutine to call op.Wait and close a channel to signal completion to select call instead.

This is probably unrelated to this pull request, but my current tests are failing with:
# github.com/bravetools/bravetools/platform [github.com/bravetools/bravetools/platform.test]
./host_api_test.go:110:24: not enough arguments in call to host.Postdeploy
	have (*"github.com/bravetools/bravetools/shared".Bravefile)
	want (context.Context, *"github.com/bravetools/bravetools/shared".Bravefile)

Thanks - good fix for the tests. The issue encountered in this PR (apk update freezing) doesn't seem to happen to me on Linux, but it did on Windows, so good to have it fixed.


Remove/replace/deprecate questionable macros in SB

Is your feature request related to a problem? Please describe.
https://github.com/nasa/cFE/blob/06c08268f2d7a7fe72aceec8c33201ce6ccba2f4/fsw/cfe-core/src/inc/cfe_sb.h#L122-L138
Describe the solution you'd like
Consider replacing or removing (deprecating).
Describe alternatives you've considered
None
Additional context
Trying to write specific tickets related to #172
Requester Info
Jacob Hageman - NASA/GSFC

@jphickey do you have background on these?  I only see CFE_SB_GET_MEMADDR used in CFE_ES_SendMemPoolStatsCmd, which I assume will go away once that's updated to use a reference.  Should CFE_SB_SET_MEMADDR be an inline function... or what's the concept behind it?  I'm not sure what a "safe" memory address is...

Fixed by #1003

Fixed by #1003


Deployment

Deployment
User Story
As a boot camp student,
I want the prework notes to be structured on a webpage,
So that I can easily find and read the information.
Acceptance Criteria
GIVEN a Prework Study Guide website,
WHEN I visit the website using the URL,
THEN I can access my website from any browser

Deployed! https://richardeknes.github.io/prework-study-guide/


DX12 Support

Hello,
I am currently experimenting with Rust and DX12 using this crate.
I am trying to port some samples from C++ to Rust (currently this one https://github.com/microsoft/DirectX-Graphics-Samples/blob/master/Samples/Desktop/D3D12HelloWorld/src/HelloWindow/D3D12HelloWindow.cpp).
I am having weird debug layer messages so maybe something is wrong with the bindings?
My code is fairly close to the C++ sample: https://gist.github.com/Vincent-P/4692d93cd3716878992e2c60e033f6fe.
Here are the error messages:
D3D12 WARNING: ID3D12CommandList::Dispatch: No threads will be dispatched, because at least one of {ThreadGroupCountX, ThreadGroupCountY, ThreadGroupCountZ} is 0. [ EXECUTION WARNING #1254: EMPTY_DISPATCH]
D3D12 ERROR: ID3D12CommandList::Dispatch: No pipeline state has been set in this command list.  The runtime will use a default no-op pipeline state. [ EXECUTION ERROR #1045: COMMAND_LIST_PIPELINE_STATE_NOT_SET]
D3D12 ERROR: ID3D12GraphicsCommandList::Reset: Reset fails because the command list was not closed. [ EXECUTION ERROR #544: COMMAND_LIST_OPEN]
D3D12 ERROR: ID3D12CommandList::ResourceBarrier: D3D12_RESOURCE_STATES has bits that mismatch support required from D3D12_RESOURCE_FLAGS. [ RESOURCE_MANIPULATION ERROR #524: RESOURCE_BARRIER_MISMATCHING_MISC_FLAGS]

I don't understand why there are messages about Dispatch() when the only commands are some ResourceBarriers and a ClearRenderTargetView...
The Reset() also is weird because I am definitely closing the command list before resetting it.
When starting the executable in Visual Studio, I am getting an exception in the first ResourceBarrier call.
let barrier = D3D12_RESOURCE_BARRIER {
    Type: D3D12_RESOURCE_BARRIER_TYPE::D3D12_RESOURCE_BARRIER_TYPE_TRANSITION,
    Flags: D3D12_RESOURCE_BARRIER_FLAGS::D3D12_RESOURCE_BARRIER_FLAG_NONE,
    Anonymous: D3D12_RESOURCE_BARRIER_0 {
        Transition: D3D12_RESOURCE_TRANSITION_BARRIER_abi {
            pResource: self.render_targets[self.frame_index as usize].as_mut().unwrap() as *mut _ as _,
            StateBefore: D3D12_RESOURCE_STATES::D3D12_RESOURCE_STATE_PRESENT,
            StateAfter: D3D12_RESOURCE_STATES::D3D12_RESOURCE_STATE_RENDER_TARGET,
            Subresource: D3D12_RESOURCE_BARRIER_ALL_SUBRESOURCES,
        },
    },
};
self.command_list.as_ref().unwrap().ResourceBarrier(1, &barrier);

Maybe the union or the call itself isn't working?
I am sorry if this isn't the right place to post this, but I am somewhat confident that the problem shouldn't be in my code as it is almost the same as the C++ sample which is running fine on my machine.

Sorry, I don't know anything about D3D12. It's possible there is a bug in the win32 metadata for those APIs but you'd have to root cause the issue first.
Perhaps @robmikh or @damyanp can spot something obvious.

Superficially the code looks correct.  My suspicion at this moment is that for some reason the vtables don't line up, so that, for example, your call to ResourceBarrier (or similar) actually becomes a call to Dispatch, with essentially garbage parameters.
If you're able to share a full project that I can easily compile and run it myself to see if I can reproduce the problem and confirm (or refute) my hypothesis.

I have linked a gist to a full file but here is a full project: https://github.com/Vincent-P/rust-dx12
One thing to add is that the application actually runs (with synchronization errors) when the ResourceBarrier are commented.

Thank you - I can repro your issue on my machine and fortunately (or unfortunately depending on your perspective) it's not the problem I thought it was.  I'll keep digging.

The problem seems to be that the pResource field in the resource barrier is not getting set to the correct value.  If I replace:
pResource: self.render_targets[self.frame_index as usize].as_mut().unwrap() as *mut _ as _,

with:
pResource: self.render_targets[self.frame_index as usize].abi(),

Then it seems to work. I'm afraid I'm very much a rust beginner (day 2) so this may be accidentally correct.  I'm guessing that the first one ends up casting the wrong thing to a *mut c_void.
Another way I've found to write it, which might be nicer, is:
            let barrier = D3D12_RESOURCE_BARRIER {
                Type: D3D12_RESOURCE_BARRIER_TYPE::D3D12_RESOURCE_BARRIER_TYPE_TRANSITION,
                Flags: D3D12_RESOURCE_BARRIER_FLAGS::D3D12_RESOURCE_BARRIER_FLAG_NONE,
                Anonymous: D3D12_RESOURCE_BARRIER_0 {
                    Transition: D3D12_RESOURCE_TRANSITION_BARRIER {
                        pResource: self.render_targets[self.frame_index as usize].clone(),
                        StateBefore: D3D12_RESOURCE_STATES::D3D12_RESOURCE_STATE_PRESENT,
                        StateAfter: D3D12_RESOURCE_STATES::D3D12_RESOURCE_STATE_RENDER_TARGET,
                        Subresource: D3D12_RESOURCE_BARRIER_ALL_SUBRESOURCES,
                    }.abi(),
                },
            };

Note this uses the non-ABI version of D3D12_RESOURCE_TRANSITION_BARRIER and then calls abi() on it.
I'd be very interested to hear from someone more expert on rust and windows-rs comment on what the preferable approach would be here.

Yeah, so this is overly hard in Rust because unions in Rust are very limited. Nested types also don't exist in Rust, so I have to simulate those as well. I'd like to come up with a better way of projecting such structs into Rust but at the moment when the code generator comes across a C-style union it has to revert to using ABI types for its fields.
I'll see if I can come up with a simple example for how best to manage this sort of thing and ideally how to convince Rust to support this more elegantly.

Many of the d3d types follow a pattern where there's a type-selector and then the union picks a single type.  So in the case of resource barriers, maybe the right approach would be to have a D3D12_RESOURCE_BARRIER_TRANSITION and a D3D12_RESOURCE_BARRIER_ALIASING etc. which have the right byte layout / padding to match the D3D12_RESOURCE_BARRIER + union.  Resource Barrier is a more simple one - look at D3D12_SHADER_RESOURCE_VIEW_DESC for a more extreme example of this pattern.
You'd want some way to make a heterogenous array of them as well.

We could add hints to the metadata to help Rust (and other languages) model this better. The metadata is generated by this project. Have a look at the metadata for the D3D types in a tool like ILSpy and let me know if you think there's potential.

Unfortunately there doesn't seem to be anything in the auto generated metadata that would help here - which isn't too surprising, since there's nothing in d3d12.h that the metadata would be able to key off. I think we'd need to add something to Direct3D12.manual.cs.  Maybe an attribute on each member of the anonymous union indicating how that one is chosen.  Something like (warning, naive "I've forgotten how attributes in winmd work" code follows):
public struct D3D12_RESOURCE_BARRIER
{
	[StructLayout(LayoutKind.Explicit)]
	public struct _Anonymous_e__Union
	{
		[FieldOffset(0), Selector(Type, D3D12_RESOURCE_BARRIER_TYPE_TRANSITION)]
		public D3D12_RESOURCE_TRANSITION_BARRIER Transition;

		[FieldOffset(0), Selector(Type, D3D12_RESOURCE_BARRIER_TYPE_ALIASING)]
		public D3D12_RESOURCE_ALIASING_BARRIER Aliasing;

		[FieldOffset(0), Selector(Type, D3D12_RESOURCE_BARRIER_TYPE_UAV_BARRIER)]
		public D3D12_RESOURCE_UAV_BARRIER UAV;
	}

	public D3D12_RESOURCE_BARRIER_TYPE Type;

	public D3D12_RESOURCE_BARRIER_FLAGS Flags;

	public _Anonymous_e__Union Anonymous;
}

Wow, I didn't expect such a quick answer!
The ABI parts (_abi structs, abi() and set_abi()) are definitely confusing.
I guess the preferred way is to use the non-ABI struct and then call .abi()?

A future possibility:
With some sort of "Selector" metadata, it might even be possible to generate the Rust type as an enum instead of a union - it would depend on whether the layouts match one of the 2 layouts listed here:
https://github.com/rust-lang/rfcs/blob/master/text/2195-really-tagged-unions.md#guide-level-explanation
(It would also depend on a currently nightly-only feature to set the discriminant: https://github.com/rust-lang/rust/issues/60553)
Something like this:
#![feature(arbitrary_enum_discriminant)]

#[repr(i32)]
enum D3D12_RESOURCE_BARRIER {
    Transition {
        Flags: D3D12_RESOURCE_BARRIER_FLAGS,
        Transition: D3D12_RESOURCE_TRANSITION_BARRIER,
    } = 0i32,
    Aliasing {
        Flags: D3D12_RESOURCE_BARRIER_FLAGS,
        Aliasing: D3D12_RESOURCE_ALIASING_BARRIER,
    } = 1i32,
    UAV {
        Flags: D3D12_RESOURCE_BARRIER_FLAGS,
        UAV: D3D12_RESOURCE_UAV_BARRIER,
    } = 2i32,
}

fn main() {
    let barrier = D3D12_RESOURCE_BARRIER::Transition {
        Flags: D3D12_RESOURCE_BARRIER_FLAGS::D3D12_RESOURCE_BARRIER_FLAG_NONE,
        Transition: D3D12_RESOURCE_TRANSITION_BARRIER {
            pResource: None,
            StateBefore: D3D12_RESOURCE_STATES::D3D12_RESOURCE_STATE_PRESENT,
            StateAfter: D3D12_RESOURCE_STATES::D3D12_RESOURCE_STATE_RENDER_TARGET,
            Subresource: D3D12_RESOURCE_BARRIER_ALL_SUBRESOURCES,
        },
    };
}

Playground: https://play.rust-lang.org/?version=nightly&mode=debug&edition=2018&gist=7a95fc3acbd0de16c26cacd74a0aebd9

@samlh - it would be excellent to get to that point.  Unfortunately, it looks like the D3D12_RESOURCE_BARRIER struct layout won't work here, since there's a "Flags" field between the Type and and the union:
typedef struct D3D12_RESOURCE_BARRIER {
  D3D12_RESOURCE_BARRIER_TYPE  Type;
  D3D12_RESOURCE_BARRIER_FLAGS Flags;
  union {
    D3D12_RESOURCE_TRANSITION_BARRIER Transition;
    D3D12_RESOURCE_ALIASING_BARRIER   Aliasing;
    D3D12_RESOURCE_UAV_BARRIER        UAV;
  };
} D3D12_RESOURCE_BARRIER;

I'm not sure the arbitrary_enum_discriminant feature can support this as it is?

@damyanp - That's correct, Rust doesn't natively support that layout.
In practice, the enum I wrote in my comment above matches the C struct's layout (same size and field offsets), but I agree that asking a code generator to figure that out is infeasible, and would likely just cause confusion for users in the long run.
I do think that a third-party project manually generating such bindings might be valuable - if I ever get some free time, I'll try experimenting with that.
However, I think I've sidetracked things a bit here - sorry about that!

I guess the preferred way is to use the non-ABI struct and then call .abi()?

My guess is that is the best approach for now - I'm not sure I really understand the purpose of the _abi structs, myself, so I can't be sure, though😄.
If things change to the point where the _abi structs are no longer exposed, then the code delta would be pretty small to remove the .abi() call.

I'm not sure I really understand the purpose of the _abi structs

The ABI struct ensures the proper memory layout and calling semantics, stdcall, caller packs the stack, callee unpacks the stack, and so on. It must match the calling patterns used by a C-struct that is trivially destructible. The projected and ABI structs have the same memory layout and size but not necessarily the same calling semantics and lifetime. For example, projected types may implement Drop whereas the ABI struct won't. Rust then imposes further restrictions around unions that compound this further.


[Event Request] table 780 "Certificate of Supply" - OnBeforeInitRecord

Please add a new event.
[IntegrationEvent(false, false)]
procedure OnBeforeInitRecord(var CertificateOfSupply: Record "Certificate of Supply"; DocumentType: Option; DocumentNo: Code[20]; var IsHandled: Boolean)
begin
end;

procedure InitRecord(DocumentType: Option; DocumentNo: Code[20])
var
    SalesShipmentHeader: Record "Sales Shipment Header";
    ServiceShipmentHeader: Record "Service Shipment Header";
    ReturnShipmentHeader: Record "Return Shipment Header";
    IsHandled: Boolean;
begin
    IsHandled := false;
    OnBeforeInitRecord(Rec, DocumentType, DocumentNo, IsHandled);
    if IsHandled then
        exit;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 47990.


StreamingMaxPool_Batch and Pool_Batch Estimation

StreamingMaxPool_Batch and Pool_Batch are missing the estimation function implementations from HLSCustomOp. Is there an easy way to calculate the usage for those blocks? Thanks!

Pooling layers don't typically contribute much to the overall resource footprint for e.g. convnets, this is why they've been omitted so far. Of course it'd be great to have estimators for them as well.
Our normal approach to develop layer resource estimations functions is to run HLS synthesis across a number of different configurations for that layer (which config/s make sense depends a bit on layer specifics; e.g. input size, kernel size and PE come to mind), put everything into a spreadsheet, then run regression guided by some intuition about what variables matter the most to create an analytical model.

I am closing this issue due to inactivity. Please feel free to reopen or create a new issue if you have more questions!


[Bug?]: Cookie unsign fails if cookie includes special character

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Current behavior 😯
If I manually set a cookie in the client to include a special character (%, & etc.), unsigning it on the server fails and results in a error.
Expected behavior 🤔
Unsigning the cookie shouldn't throw an error.
Steps to reproduce 🕹
I created an example here: https://github.com/GiyoMoon/solid-start-cookie-unsign
Steps to reproduce:
git clone https://github.com/GiyoMoon/solid-start-cookie-unsign
cd solid-start-cookie-unsign
pnpm install
pnpm dev

Navigate to http://localhost:3000
Manually set the cookie on the client side (in your browser inspect for example). Set the name to cookie and the value to a special character like % or &
Click the "Get cookie" button and watch solid start explode
If the cookie doesn't include a special character, it works just fine and you should see undefined printed in the server console because the cookie isn't signed properly (expected behaviour)

Context 🔦
Of course this isn't a bug which happens in normal use as users usually don't go and set their cookies manually. I wouldn't have noticed it if I didn't have the cookie set on localhost:3000 by another application which used to include %.
Your environment 🌎
System: Apple M1 Pro v13.4.1
Nodejs: v18.16.1

package.json

The server tries to usign & but is expecting something in this format <value>.<hash>. Splits at the dot but there is no hash part so it passes the & to atob('&') and atob will throw if it encounters non valid base64 characters.
Using the secret in your example the value should be: &.AqyMrDRyEIsDNXJ66ke+cnVmQqVZe5c/I+Wr9k0Jhbw
https://github.com/solidjs/solid-start/blob/5dd795f74b46ca38938e17b9bdb632a922117bad/packages/start/session/cookieSigning.ts#L27C1-L38C3

Yes I know. But this shouldn't cause an error and the get cookie function should return undefined because the cookie isn't signed properly right?

Agree and would expect the same.
Side note: I overlooked the context part. Sorry about that.

Hi. Can I take this issue ?

In setting up for SolidStarts next Beta Phase built on Nitro and Vinxi we are closing all PRs/Issues that will not be merged due to the system changing. If you feel your issue was closed by mistake. Feel free to re-open it after updating/testing against 0.4.x release. Thank you for your patience.

See https://github.com/solidjs/solid-start/pull/1139 for more details.


Please delete branch rekt

I accidently pushed to the wrong repo, could someone else please delete the branch" rekt"
Thanks

nm, I did it


somePermissionPermanentlyDenied() returning always true

somePermissionPermanentlyDenied in onPermissionsDenied is retuning always true. I have check this issue on 2 devices lg v20 (8.0) and lg g5 (6.0.1). Same results on both devices. If user simple deny the permission  not "don't ask again" then somePermissionPermanentlyDenied is retuning true.

That was my mistake. In my app there was one activity and many fragments. I was requesting permission in fragments but it is android behavior that if a fragment request permission then onRequestPermissionsResult of activity is also called. Hope it will help someone in the future.


Add Windows platform to CI definition file

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (36dc314) 100.00% compared to head (8317b9b) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main        #3   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            1         1
  Lines           51        69   +18
=========================================
+ Hits            51        69   +18

Files
Coverage Δ

scanner.go
100.00% <100.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Pink hydra breaks in nightly

after bisecting, this change is the reason for breakage: neovim/neovim@3a881132460430d23f2fdc87822c87d47f721cfc
stacktrace:
vim/shared.lua:0: s: expected string, got number (1)

# stacktrace:
  - vim/shared.lua:0 _in_ **validate**
  - vim/shared.lua:0 _in_ **startswith**
  - vim/_init_packages.lua:0 _in_ **__index**
  - vim/shared.lua:0 _in_ **islist**
  - vim/shared.lua:0 _in_ ****
  - vim/shared.lua:0 _in_ **tbl_deep_extend**
  - /hydra.nvim/lua/hydra/layer/init.lua:116 _in_ **initialize**
  - /hydra.nvim/lua/hydra/lib/class.lua:14 _in_ **Layer**
  - /hydra.nvim/lua/hydra/init.lua:440 _in_ **_setup_pink_hydra**
  - /hydra.nvim/lua/hydra/init.lua:282 _in_ **initialize**
  - /hydra.nvim/lua/hydra/lib/class.lua:14
  - ~/.config/nvim/lua/cathy/plugin/debug.lua:130 _in_ **config**

for completeness this is the referenced line in config: https://github.com/Cathyprime/nvim-dots/blob/63603e94b5ed99265ce728dc4bc7168308b9406e/lua/cathy/plugin/debug.lua#L130-L151
and this also breaks: https://github.com/Cathyprime/nvim-dots/blob/63603e94b5ed99265ce728dc4bc7168308b9406e/lua/cathy/plugin/debug.lua#L165-L207
the code works in neovim/neovim@08153ddd1c149c867948f4681846531d53ba7759
edit: most likely the HACK has failed

Nightly is doing some... interesting things right now. I'm not going to support nightly right now b/c they seem to want to make massive breaking changes.
If this is still an issue closer to 0.11.0, please reopen

sure thing :)
for people looking for temporary nightly support use my fork (change back when 0.11 releases as I have 0 plans to maintain that)


dark theme scrollbars

can we add the option that if you are using the dark theme in windows that the scrollbars  in the prompt

match the dark scrollbars in  e.g. explorer

Try:
SetWindowTheme(GetConsoleWindow(), L"DarkMode_Explorer", nullptr);

In your console application.

Made a change today to try this out for Insiders builds.

@miniksa awesome, which build number? I'm on the slow ring fyi.

@musm It'll be out in a few weeks. It usually takes just about 3 weeks for checkins we make to get up to master, and usually a week after that for the Insider's build to get spun with the change.
So, soontm

Hmm, I tried what @ysc3839 said in powershell (on 1809, of course) and it had no effect on the scrollbars:
PS> add-type -Name NativeMethods -Namespace Temp -MemberDefinition @"
[DllImport("uxtheme.dll", SetLastError=true, ExactSpelling=true, CharSet=CharSet.Unicode)]
public static extern int SetWindowTheme(IntPtr hWnd, string pszSubAppName, string pszSubIdList);

public static extern bool IsAppThemed

[DllImport("kernel32.dll", SetLastError=true)]
public static extern IntPtr GetConsoleWindow();
"@
PS> [Temp.NativeMethods]::SetWindowTheme([Temp.NativeMethods]::GetConsoleWindow(), "DarkMode_Explorer", $null)
0
PS> # scrollbars still light theme

Suggestions on how to correct this, @zadjii-msft ?

I'm really not sure why it doesn't work from the outside. Could be that it doesn't like being done after ShowWindow has been called and the WM_SETTINGCHANGED handler isn't ready for it. Could be that SetWindowTheme generates a window message that UIPI is blocking from your Powershell binary. Could be something completely different. I'm sorry. I tried it inside the console code and it works, so I'm not intending to spend anytime debugging why it doesn't work from the outside.

(unrelated) @ysc3839 can you provide me with some simple minimal example with that ? Trying to dive in so I can create PRs for some apps I use, but win32 API and world is a little dizzying for first timers.

@musm
It works on my GUI application. Currently I have not tested on console Windows.
Maybe SetWindowTheme for external process is not allowed.
https://github.com/ysc3839/VCMPBrowser/blob/darkmode/DarkMode.h
This code uses internal APIs and may not work on a newer Windows version.

Does the dark mode cover settings dialog?

@miniksa I reverse engineered and found you use GetProcAddress with a magic number. Why not static link to that function?
I'm afraid that the console will broken when the ordinal of that function changed.

@ysc3839 Do not post reverse engineering-ed screenshot. Your concept is wrong. Email me.

@ysc3839 Do not post reverse engineering-ed screenshot. Your argument is wrong. Email me. It is internal matter.

@ysc3839 Do not post reverse engineering-ed screenshot. Your argument is wrong.

@ysc3839 There's a couple reasons for that:

The function may not be exported by name.
We can't statically link it, as the library that provides it is a dynamic library.
We all use the console internally every day, and are very likely to be the first to know if this ordinal changes, probably through a change in its observable behavior. Since we're developing on builds of windows that are very close to mainline, we'll almost certainly figure out changes like this before any breakage makes it out to Insiders.

(additionally, any given ordinal is not at risk of changing during the lifetime of a single version of Windows)

@DHowett-MSFT
Sorry, the "static link" means link to that DLL using import address table.
Some other DLL (explorerframe.dll) link to that function using IAT. It's better than using GetProcAddress.


Discord Link is broken

Discord Server: invite invalid, may be expired or no permissions to join.

@pyramid3d Try this invite. Not sure how long it will be valid...

ok


Renames occurrences of queue to callbackQueue

Continues #762
Hopefully I didn't miss any queue 😄

👏👍

Codecov Report

Merging #1117 into optional-response-thread-param will not change coverage.
The diff coverage is 72.22%.

@@                       Coverage Diff                       @@
##           optional-response-thread-param    #1117   +/-   ##
===============================================================
  Coverage                           76.51%   76.51%
===============================================================
  Files                                  22       22
  Lines                                 728      728
===============================================================
  Hits                                  557      557
  Misses                                171      171

Impacted Files
Coverage Δ

Sources/RxMoya/RxMoyaProvider.swift
94.44% <100%> (ø)
:arrow_up:

Sources/Moya/MoyaProvider.swift
91.22% <100%> (ø)
:arrow_up:

Sources/Moya/Moya+Alamofire.swift
82.6% <100%> (ø)
:arrow_up:

Sources/Moya/MoyaProvider+Internal.swift
62.27% <52.94%> (ø)
:arrow_up:

...urces/ReactiveMoya/ReactiveSwiftMoyaProvider.swift
51.72% <60%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b11060b...0c034df. Read the comment docs.


invalid check type when editing check name

To repro, try editing the name of a check from the main M&A page.
PUT {"id":"046df46a09bd2000","name":"Stock Price Changing Else"}

I think this one has to be patch. We only want put in the edit page

@kelwang the issue is that PATCH doesn't allow us to update all fields. I'd prefer to use just a single method PUT/PATCH for all API updates

@kelwang the issue is that PATCH doesn't allow us to update all fields. I'd prefer to use just a single method PUT/PATCH for all API updates

We should use PUT for the editing page save. and use PATCH for the browsing page edit.


exec: Lua support was not enabled.

os: open suse 12.
1）When I compile ModSecurity，prompt lua was not enabled.
ModSecurity - v3.0.4 for Linux

Mandatory dependencies

libInjection                                  ....v3.9.2-30-gbf234eb
SecLang tests                                 ....c8cf2c5

Optional dependencies

GeoIP/MaxMind                                 ....found

(GeoIP) v1.5.0
-lGeoIP , -I/usr/include/

LibCURL                                       ....not found
YAJL                                          ....found v2.0.4
-lyajl , -DWITH_YAJL
LMDB                                          ....not found
LibXML2                                       ....not found
SSDEEP                                        ....not found
LUA                                           ....not found

2） While  the os have lua .

linux-3z0f:/home/suse/modsecurity-v3.0.4 # whereis lua
lua: /usr/bin/lua /usr/bin/lua5.2 /usr/lib64/lua /usr/share/lua /usr/share/man/man1/lua.1.gz
thanks

@HL123  is required liblua. Check if there is a liblua installed. The installation lua not accompany the liblua, but obviously lua is requeriment to liblua.
If necessary compile liblua from source view https://www.linuxfromscratch.org/blfs/view/8.3/general/lua.html

Thanks , When I install liblua, it has work。 While when I run it, it doesn't work。
I use nginx  + modsecurity + lua . The  modsecurity.conf  have this
SecRuleScript ARGS:p “/appl/gap-nginx/nginx/lua/exec.lua” “block”
When I execute ./nginx -t ，it  prompt   the following information
“modsecurity_rules_file" directive Rules error. File: /appl/gap-nginx/nginx/conf/modsecurity.conf. Line: 34. Column: 20. exec: Lua support was not enabled.  in /appl/gap-nginx/nginx/conf/nginx.conf:41”

You compiled ModSecurity with "--with-lua" option?
See in output from compilation if liblua was included
MAYBE do you needs input full path dir or "lib" from lua:
   --with-lua=/path/lua/lib

Since there is no feedback from the user, I am assuming that the issue was fixed.


Sample - update migration guide for iOS

Sample - Migration guide needs iOS code snippets.

Updates are now live for the migration guide!


Add support for tag searching for the /search query in GraphQL V1

Related to https://github.com/opencollective/opencollective/issues/2970
Front-end PR: https://github.com/opencollective/opencollective-frontend/pull/7579

What do you mean by "/search endpoint" ? I don't know anything like this.

What do you mean by "/search endpoint" ? I don't know anything like this.

Maybe wrong terminology, but what I meant is the logic on the API that we have for searching collectives; https://github.com/opencollective/opencollective-api/blob/533521783a17371eb37d07bcf7a596ba866c617a/server/graphql/v1/queries.js#L901-L904

It's then the search query in GraphQL API v1.

@SudharakaP I don't understand this change, tags are already part of the TS vector:
https://github.com/opencollective/opencollective-api/blob/5eb8644ce6cd5d0150be2e9d95a4d95d75030640/server/lib/search.js#L79
. Was it not working?

@Betree : Thanks for the review.
It was working, but I also wanted to support tags such as jhipster-tag where there is punctuation; which is an obvious use case I thought. With the previous version it seems that if the user types jhipster-tag no results appear as array_to-tsvector seems to do some normalization. If they search for jhipstertag results appear but that isn't intuitive for the user.

The problem with the approach taken here is that the slug is not included in the ts_rank, so results may not be sorted accurately.

I don't understand this part, we didn't do any changes to the slug in this change; slug is already included here so isn't it not part of ts_rank?
https://github.com/opencollective/opencollective-api/blob/5eb8644ce6cd5d0150be2e9d95a4d95d75030640/server/lib/search.js#L77

I don't understand this part, we didn't do any changes to the slug in this change; slug is already included here so isn't it not part of ts_rank?

The TS_RANK is done like this:
ts_rank(${TS_VECTOR}, plainto_tsquery('english', :vectorizedTerm))

If it doesn't match in the WHERE, it won't match in the TS_RANK either because it's the exact same query. Concretly, we're doing the same thing as the query below. If you try and run it, you'll see that it indeed returns a line, but with a TS_RANK = 0:
SELECT ts_rank(array_to_tsvector(ARRAY['jhipster-tag']), plainto_tsquery('simple', 'jhipster-tag'))
WHERE 'jhipster-tag' = ANY(ARRAY['jhipster-tag'])

It was working, but I also wanted to support tags such as jhipster-tag where there is punctuation; which is an obvious use case I thought. With the previous version it seems that if the user types jhipster-tag no results appear as array_to-tsvector seems to do some normalization. If they search for jhipstertag results appear but that isn't intuitive for the user.

It would have been great to document the issue beforehand or explain that in the PR description.
The following line indeed returns false:
array_to_tsvector(ARRAY['jhipster-tag']) @@ plainto_tsquery('simple', 'jhipster-tag')

I can recommend a different way of building the TS_VECTOR which will work with this example:
to_tsvector(array_to_string(ARRAY['jhipster-tag'], ' ')) @@ plainto_tsquery('simple', 'jhipster-tag'),

@Betree : Thanks a lot for the explanation. Makes senses, I've opened a new PR; https://github.com/opencollective/opencollective-api/pull/7310 with the proposed fix. Seems to work perfectly.


Update sample code to T2 MGMT SDK

Part of issue:  https://github.com/Azure/autorest.csharp/issues/1883

Wait issue https://github.com/Azure/azure-sdk-for-net/pull/38876 fix


Navigated and Navigating events

When you call SetNavigationState, will the Frame fire the Navigating and Navigated events, in addition to calling the OnNavigatedTo for the page?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 53e2c721-8072-6bb1-80ab-b28fae5dff06
Version Independent ID: a2dd3d25-f7f8-1ac8-8c79-5fc5e2de108c
Content: Frame.SetNavigationState Method (Windows.UI.Xaml.Controls) - Windows UWP applications
Content Source: https://cpubwin.visualstudio.com/DefaultCollection/windows-uwp/_git/winrt-api-build?path=%2fwinrt-api-build%2fwindows.ui.xaml.controls.frame.yml&version=GBlive&_a=contents
Product: uwp
Git Login: jwmsft
Microsoft Alias: jimwalk

@jwmsft - you made a number of updates to the navigation docs recently. Can you get the requested detail for this topic based on those updates?


Make SemTK cardinality checks accessible by RACK tools

Background:
Users can access cardinality restriction violations (instances with too few/many of a given property) in the SemTK SPARQLgraph UI.  We now want to make this violation information accessible to other tools in the RACK ecosystem.
Acceptance Criteria:

[x] Jenny add SemTK Java client call for future use by RITE.   DONE: OntologyInfoClient.execGetCardinalityViolations()
[x] Jenny add semtk-python3 call for use by RACK CLI.  DONE: semtk3.get_cardinality_violations()
[ ] Eric add RACK CLI call
[x] Paul provide SPARQLgraph URL parameter to open directly to Explore restriction mode
[ ] Jenny add RACK UI button to directly open SPARQLgraph Explore restriction mode
[ ] documentation

I'll jump on it


"Sohatu" is listed in the drop-down menu

Description:
"Sohatu" is listed in the drop-down menu alongside its corresponding county and commune, according to the law
Precondition:
The website is up an running.

Step 1
Type "Sohatu" in the search bar.

Expected results
The location is listed in the drop-down menu as "Sat Radovanu, CĂLĂRAȘI (Radovanu)".


dep ensure changes Gopkg.lock when restoring dependencies

dep ensure changes the Gopkg.lock unexpectedly during restore, causing CI to fail.
This build failed.  When I removed my vendor directory locally and ran make vendor, I got this diff unexpectedly:
diff --git a/Gopkg.lock b/Gopkg.lock
index 7db50dc..c50c6af 100644
--- a/Gopkg.lock
+++ b/Gopkg.lock
@@ -24,9 +24,10 @@
   revision = "0d9f544bb94aac29c185968483459ef74d6deb5d"

 [[projects]]
+  branch = "master"
   name = "github.com/containerd/containerd"
-  packages = [".","api/services/containers/v1","api/services/content/v1","api/services/diff/v1","api/services/events/v1","api/services/images/v1","api/services/namespaces/v1","api/services/snapshot/v1","api/services/tasks/v1","api/services/version/v1","api/types/descriptor","api/types/event","api/types/mount","api/types/task","containers","content","events","images","log","metadata","mount","namespaces","plugin","reference","remotes","remotes/docker","remotes/docker/schema1","rootfs","services/content","services/diff","services/images","services/snapshot","snapshot"]
-  revision = "c4da4ed3932fbe8e35f43d6495731c56e9e1052c"
+  packages = [".","api/services/containers/v1","api/services/content/v1","api/services/diff/v1","api/services/events/v1","api/services/images/v1","api/services/namespaces/v1","api/services/snapshot/v1","api/services/tasks/v1","api/services/version/v1","api/types","api/types/task","containers","content","events","identifiers","images","log","metadata","mount","namespaces","plugin","reference","remotes","remotes/docker","remotes/docker/schema1","rootfs","services/content","services/diff","services/images","services/snapshot","snapshot"]
+  revision = "7ec1497a6bbe76f30f7ddbda403610b40ff8edb3"

 [[projects]]
   branch = "master"
@@ -141,6 +142,6 @@
 [solve-meta]
   analyzer-name = "dep"
   analyzer-version = 1
-  inputs-digest = "2677790afbfe3cc8671e35892291786d4ae4448eecaa9cb4a9f49a3b50bb98c0"
+  inputs-digest = "aac69bc033e8ad1fb360365a370641b0ed503bdec10c2fb05e3c1c3a40b20b1c"
   solver-name = "gps-cdcl"
   solver-version = 1

Fixed for now with https://github.com/samuelkarp/amazon-ecr-containerd-resolver/commit/ef051e068ba1a973323cf5ab00283c36a569b223 (forcing a revision of github.com/opencontainers/runtime-spec instead of github.com/containerd/containerd because I'd like this to keep up with containerd master), but I need to find a better solution.

Looks like this should now be solved with v0.3.1, specifically using dep ensure -vendor-only.

This is resolved with https://github.com/samuelkarp/amazon-ecr-containerd-resolver/commit/26eb67769be8de02fe9218635947f38ddacbb853.


[BUG][DISTRIBUTED] run parts of svd results will cause serialize error

Describe the bug
Some tensor op can generate multiple outputs, svd etc. Assume u, s, v is the result tensors for SVD decomposition, for the distributed setting, if we only run parts of the tensors, for example, u and s, the KeyError will be raised which I guess is all due to the serialization issue.
To Reproduce
I start one scheduler, worker and web on my laptop.
On the client side:
In [3]: from mars.session import new_session

In [4]: session  = new_session('http://<IP_ADDRESS>:61378')

In [5]: a = mt.random.rand(10, 20)

In [6]: dec = np.linalg.svd(a)

In [7]: dec = mt.linalg.svd(a)

In [8]: session.run(dec[:2])

The client will hang.
On the scheduler side, we can get the error:
Traceback (most recent call last):
  File "src/gevent/greenlet.py", line 716, in gevent._greenlet.Greenlet.run
  File "mars/actors/pool/gevent_pool.pyx", line 88, in mars.actors.pool.gevent_pool.ActorExecutionContext.fire_run
    cpdef object fire_run(self):
  File "mars/actors/pool/gevent_pool.pyx", line 91, in mars.actors.pool.gevent_pool.ActorExecutionContext.fire_run
    with self.lock:
  File "mars/actors/pool/gevent_pool.pyx", line 102, in mars.actors.pool.gevent_pool.ActorExecutionContext.fire_run
    raise
  File "mars/actors/pool/gevent_pool.pyx", line 96, in mars.actors.pool.gevent_pool.ActorExecutionContext.fire_run
    res = actor.on_receive(message_ctx.message)
  File "mars/actors/core.pyx", line 108, in mars.actors.core.FunctionActor.on_receive
    cpdef on_receive(self, message):
  File "mars/actors/core.pyx", line 110, in mars.actors.core.FunctionActor.on_receive
    return getattr(self, method)(*args, **kwargs)
  File "/Users/qinxuye/Workspace/mars/mars/scheduler/graph.py", line 153, in execute_graph
    self.prepare_graph()
  File "/Users/qinxuye/Workspace/mars/mars/scheduler/graph.py", line 207, in prepare_graph
    tensor_graph = deserialize_graph(self._serialized_tensor_graph)
  File "/Users/qinxuye/Workspace/mars/mars/utils.py", line 403, in deserialize_graph
    return DirectedGraph.from_json(json_obj)
  File "mars/graph.pyx", line 415, in mars.graph.DirectedGraph.from_json
    return cls.deserialize(SerialiableGraph.from_json(json_obj))
  File "mars/serialize/core.pyx", line 537, in mars.serialize.core.Serializable.from_json
    return cls.deserialize(provider, obj)
  File "mars/serialize/core.pyx", line 510, in mars.serialize.core.Serializable.deserialize
    [cb(key_to_instance) for cb in callbacks]
  File "mars/serialize/jsonserializer.pyx", line 176, in mars.serialize.jsonserializer.JsonSerializeProvider._deserialize_list.cb.inner
    o = subs[v.key, v.id]
KeyError: ('9e2478de2695b727435601490ebaa999', '5219323976')
2018-12-07T11:14:35Z <Greenlet "Greenlet-0" at 0x138f5a448: <built-in method fire_run of mars.actors.pool.gevent_pool.ActorExecutionContext object at 0x139002cc8>> failed with KeyError

The failure can be produced without starting the distributed runtime by the code below.
a = mt.random.rand(9, 6, chunks=(3, 6))
U, s, V = mt.linalg.svd(a)

graph = DirectedGraph()
U.build_graph(tiled=False, graph=graph)
s.build_graph(tiled=False, graph=graph)

new_graph = DirectedGraph.from_json(graph.to_json())

I will add it to the expression tests and try to fix it.

This issue is not solved completely, for example
a = mt.random.rand(9, 6, chunks=(3, 6))
U, s, V = mt.linalg.svd(a)

graph = DirectedGraph()
(U + 1).build_graph(tiled=False, graph=graph)
(s + 1).build_graph(tiled=False, graph=graph)

new_graph = DirectedGraph.from_json(graph.to_json())

We do some calculation on the U and s, the serialize error will throw again, I will try to fix it.


Braces/Parentheses/Brackets Highlighting is broken with v2.3.0dev6 on Windows/Python 3

From pierre.raybaut on 2013-08-30T04:39:32Z
Here is the first report of that bug: https://groups.google.com/forum/#!topic/spyderlib/j7ALUj4nxLc
Original issue: http://code.google.com/p/spyderlib/issues/detail?id=1542

From pierre.raybaut on 2013-08-30T02:46:32Z
This issue was updated by revision 7e1916a2e275 .
Status: Fixed

From ccordoba12 on 2013-09-04T12:08:03Z
issue #1548 has been merged into this issue.


GitHub repository branch button and Git clone (Code) button cannot be detected

Describe the bug
GitHub repository branch button and Git clone (Code) button cannot be detected
To Reproduce
Steps to reproduce the behavior:

Go to a GitHub repository
Wait until the web page is fully loaded
Press f / F
See error

Expected behavior
A yellow box appears on top of these two elements.
Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

macOS version: 11.6
Safari version: 15.0 (166<IP_ADDRESS>.4)
Vimari version: 2.1.1

Any solution no? I have that problem too.


Define new struct combined slice and href string to replace plain slice.

For attributes that are arrays you are currently using slices directly. That is mostly OK, and very idiomatic in Go, but it doesn't allow you to have attributes that are associated to the array itself. This is very important for the 'href' attributes of links. For example, when you get a virtual machine you get something like this:

    ...

    ...

Using slices directly makes it impossible to access the "href" attribute, which is very important if you want to implement something like the "follow_link" method that we have in other SDKs.
I'd suggest to create for each type a corresponding list type. For example VmList, or DiskAttachmentList. This type can be very simple, having a method that returns the slice, and a method that returns the href:
type DiskAttachmentList struct {
href string
slice []DiskAttachment
}
func (l *DiskAttachmentList) Slice() []DiskAttachment {
return l.slice
}
func (l* DiskAttachmentList) Href() string {
return href
}
The attributes that return arrays should then return these lists:
vm := ...
diskAttachments := vm.DiskAttachments()
for _, diskAttachment := range diskAttachments.Slice() {
...
}

The newly definition of combined struct slice with href is as follows:
type DiskAttachmentSlice struct {
	href  *string
	slice []DiskAttachment
}

func (op *DiskAttachmentSlice) Href() (string, bool) {
	if op.href == nil {
		return "", false
	}
	return *op.href, true
}

func (op *DiskAttachmentSlice) SetHref(href string) {
	op.href = &href
}

func (op *DiskAttachmentSlice) Slice() []DiskAttachment {
	return op.slice
}

func (op *DiskAttachmentSlice) SetSlice(slice []DiskAttachment) {
	op.slice = slice
}

The reference for []DiskAttachment defined in types.go are all changed to use *DiskAttachmentSlice. Keep using the pointer of DiskAttachmentSlice is good for backward compatible.
Also changed the examples codes when ranging over slices.


allow to specify the backdrop parent for the modal component

Hi everybody!
I hope you're doing well, I wish you the best for this new year!
A small PR, to allow to specify the root element for the modal backdrop, it can be useful for users who use Bootstrap with Gatsby for example
Edit: The build failed on something I didn't changed, that's strange 🤔

Hello @Johann-S :smiley:
Can you please help me to understand how can it help Gatsby users?
We had another PR trying to introduce a modal option, defining rootParent and inherit it to backdrop.  I believe this option would be more handy, without exposing backdrop rootParent option.
In case I am right and we provide the modal rootParent option, does this PR add any value to functionality?
Ps: would appreciate your help/response on https://github.com/twbs/bootstrap/pull/34989#issuecomment-979846014

Hey :)
Finally after some tests on my project, it's because of purgeCSS remove .modal-backdrop added by our JS.
So feel free to close that PR if it's not useful 👌

So, do we need this after all?

Nope I don't think it's useful at all 😆


Babel error on starting homehost by running yarn homehost

[1] ERROR in ./src/index.js
[1] Module build failed (from ./node_modules/babel-loader/lib/index.js):
[1] Error: [BABEL] /home/arihant/Downloads/homehost-master/client/src/index.js:
[1] As of v7.0.0-beta.55, we've removed Babel's Stage presets.
[1] Please consider reading our blog post on this decision at
[1] https://babeljs.io/blog/2018/07/27/removing-babels-stage-presets
[1] for more details. TL;DR is that it's more beneficial in the
[1]   long run to explicitly add which proposals to use.
[1]
[1] For a more automatic migration, we have updated babel-upgrade,
[1] https://github.com/babel/babel-upgrade to do this for you with
[1] "npx babel-upgrade".
[1]
[1] If you want the same configuration as before:
[1]
[1] {
[1]   "plugins": [
[1]     // Stage 2
[1]     ["@babel/plugin-proposal-decorators", { "legacy": true }],
[1]     "@babel/plugin-proposal-function-sent",
[1]     "@babel/plugin-proposal-export-namespace-from",
[1]     "@babel/plugin-proposal-numeric-separator",
[1]     "@babel/plugin-proposal-throw-expressions",
[1]
[1]     // Stage 3
[1]     "@babel/plugin-syntax-dynamic-import",
[1]     "@babel/plugin-syntax-import-meta",
[1]     ["@babel/plugin-proposal-class-properties", { "loose": false }],
[1]     "@babel/plugin-proposal-json-strings"
[1]   ]
[1] }
[1]
[1] If you're using the same configuration across many separate projects,
[1] keep in mind that you can also create your own custom presets with
[1] whichever plugins and presets you're looking to use.
[1]
[1] module.exports = function() {
[1]   return {
[1]     plugins: [
[1]       require("@babel/plugin-syntax-dynamic-import"),
[1]       [require("@babel/plugin-proposal-decorators"), { "legacy": true }],
[1]       [require("@babel/plugin-proposal-class-properties"), { "loose": false }],
[1]     ],
[1]     presets: [
[1]       // ...
[1]     ],
[1]   };
[1] };
[1]  (While processing<EMAIL_ADDRESS>[1]     at _default (/home/arihant/Downloads/homehost-master/client/node_modules/@babel/preset-stage-2/lib/index.js:9:9)
[1]     at loadDescriptor (/home/arihant/Downloads/homehost-master/client/node_modules/@babel/core/lib/config/full.js:165:14)
[1]     at cachedFunction (/home/arihant/Downloads/homehost-master/client/node_modules/@babel/core/lib/config/caching.js:33:19)
[1]     at loadPresetDescriptor (/home/arihant/Downloads/homehost-master/client/node_modules/@babel/core/lib/config/full.js:235:63)
[1]     at config.presets.reduce (/home/arihant/Downloads/homehost-master/client/node_modules/@babel/core/lib/config/full.js:77:21)
[1]     at Array.reduce (<anonymous>)
[1]     at recurseDescriptors (/home/arihant/Downloads/homehost-master/client/node_modules/@babel/core/lib/config/full.js:74:38)
[1]     at loadFullConfig (/home/arihant/Downloads/homehost-master/client/node_modules/@babel/core/lib/config/full.js:108:6)
[1]     at process.nextTick (/home/arihant/Downloads/homehost-master/client/node_modules/@babel/core/lib/transform.js:28:33)
[1]     at processTicksAndRejections (internal/process/next_tick.js:74:9)
[1]  @ multi (webpack)-dev-server/client?http://localhost:3000 (webpack)/hot/dev-server.js babel-polyfill ./src/index.js app[3]
[1] ℹ ｢wdm｣: Failed to compile.

I assume you are using the latest master.

Did you run npm install on the client/ folder as well as the root folder?
-From your client/package.json, can you list what your devDependencies are

Yes, I am using the latest master and ran npm install on client/ folder as well.
devDependencies from client/package.json:
 "devDependencies": {
    "@babel/core": "^7.3.4",
    "@babel/preset-env": "^7.3.4",
    "@babel/preset-react": "^7.0.0-beta.51",
    "@babel/preset-stage-2": "^7.0.0",
    "babel-loader": "^8.0.0-beta.2",
    "babel-polyfill": "^6.26.0",
    "babel-preset-stage-2": "^6.24.1",
    "css-loader": "^0.28.11",
    "file-loader": "^1.1.11",
    "npm-check-updates": "^3.0.8",
    "style-loader": "^0.21.0",
    "webpack": "^4.29.6",
    "webpack-cli": "^3.0.8",
    "webpack-dev-server": "^3.2.1"
  }
}

@arihantjn53 can you pull master and try again

Thanks @ridhwaans.


Usage for a slot like approach

Hello,
I was wondering if this library would be usable to directly render a component to another place in the render tree, à la https://github.com/javivelasco/react-tunnels#react-tunnels ? So in my case I would like to send the component to the other place without mounting it locally I guess?
My use case is being able to declare "slots" in my Layout that I can fill from children deep in the tree to have like contextual menus depending on the current page without unmouting/remounting the Layout, so I can have animated page transitions as a bonus!

@jgoux Hello, a use case of this kind works, I am also experimenting with the library specifically the implementation of a Navigation Component that uses Framer Motion for animation.
Since initial experiments were easy to implement I am at a point where removing a child and reinserting it elsewhere provides a problem. Specifically, the children are subcomponents that represent a list. If a view or a list included in the view is navigated down in the first parent component by the user and in the next step, the view is passed to another parent component, the list snaps back to the first element of the list; the already executed path in the first parent component is thus lost.
Currently I am looking for a way to solve this, hopefully I can get it round.