[SECURITY] Fix Temporary Directory Hijacking or Information Disclosure Vulnerability

Security Vulnerability Fix
This pull request fixes either 1.) Temporary Directory Hijacking Vulnerability, or 2.) Temporary Directory Information Disclosure Vulnerability, which existed in this project.
Preamble
The system temporary directory is shared between all users on most unix-like systems (not MacOS, or Windows). Thus, code interacting with the system temporary directory must be careful about file interactions in this directory, and must ensure that the correct file permissions are set.
This PR was generated because the following chain of calls was detected in this repository in a way that leaves this project vulnerable.
File.createTempFile(..) -> file.delete() -> either file.mkdir() or file.mkdirs().
Impact
This vulnerability can have one of two impacts depending upon which vulnerability it is.

Temporary Directory Information Disclosure - Information in this directory is visable to other local users, allowing a malicious actor co-resident on the same machine to view potentially sensitive files.
Temporary Directory Hijacking Vulnerability - Same impact as 1. above, but also, ther local users can manipulate/add contents to this directory. If code is being executed out of this temporary directory, it can lead to local priviledge escalation.

Temporary Directory Hijacking
This vulnerability exists because the return value from file.mkdir() or file.mkdirs() is not checked to determine if the call succeeded. Say, for example, because another local user created the directory before this process.
File tmpDir = File.createTempFile("temp", ".dir"); // Attacker knows the full path of the directory that will be later created
// delete the file that was created
tmpDir.delete(); // Attacker sees file is deleted and begins a race to create their own directory before the java code.
// and makes a directory of the same name
// SECURITY VULNERABILITY: Race Condition! - Attacker beats java code and now owns this directory
tmpDir.mkdirs(); // This method returns 'false' because it was unable to create the directory. No exception is thrown.
// Attacker can write any new files to this directory that they wish.
// Attacker can read any files created within this directory.

Other Examples

CVE-2021-20202 - Keycloak/Keycloak
CVE-2020-27216 - eclipse/jetty.project

Temporary Directory Information Disclosure
This vulnerability exists because, although the return values of file.mkdir() or file.mkdirs() are correctly checked, the permissions of the directory that is created follows the default system uname settings. Thus, the directory is created with everyone-readable permissions. As such, any files/directories written into this directory are viewable by all other local users on the system.
File tmpDir = File.createTempFile("temp", ".dir");
tmpDir.delete();
if (!tmpDir.mkdirs()) { // Guard correctly prevents temporary directory hijacking, but directory contents are everyone-readable.
    throw new IOException("Failed to create temporary directory");
}

Other Examples

CVE-2020-15250 - junit-team/junit
CVE-2021-21364 - swagger-api/swagger-codegen
CVE-2022-24823 - netty/netty
CVE-2022-24823 - netty/netty

The Fix
The fix has been to convert the logic above to use the following API that was introduced in Java 1.7.
File tmpDir = Files.createTempDirectory("temp dir").toFile();

The API both created the directory securely, ie with a random, non-conflicting name, with directory permissions that only allow the currently executing user to read or write the contents of this directory.
:arrow_right: Vulnerability Disclosure :arrow_left:
:wave: Vulnerability disclosure is a super important part of the vulnerability handling process and should not be skipped! This may be completely new to you, and that's okay, I'm here to assist!
First question, do we need to perform vulnerability disclosure? It depends!

Is the vulnerable code only in tests or example code? No disclosure required!
Is the vulnerable code in code shipped to your end users? Vulnerability disclosure is probably required!

Vulnerability Disclosure How-To
You have a few options options to perform vulnerability disclosure. However, I'd like to suggest the following 2 options:

Request a CVE number from GitHub by creating a repository-level GitHub Security Advisory. This has the advantage that, if you provide sufficient information, GitHub will automatically generate Dependabot alerts for your downstream consumers, resolving this vulnerability more quickly.
Reach out to the team at Snyk to assist with CVE issuance. They can be reached at the Snyk's Disclosure Email.

Detecting this and Future Vulnerabilities
This vulnerability was automatically detected by GitHub's LGTM.com using this CodeQL Query.
You can automatically detect future vulnerabilities like this by enabling the free (for open-source) GitHub Action.
I'm not an employee of GitHub, I'm simply an open-source security researcher.
Source
This contribution was automatically generated with an OpenRewrite refactoring recipe, which was lovingly hand crafted to bring this security fix to your repository.
The source code that generated this PR can be found here:
UseFilesCreateTempDirectory
Opting-Out
If you'd like to opt-out of future automated security vulnerability fixes like this, please consider adding a file called
.github/GH-ROBOTS.txt to your repository with the line:
User-agent: JLLeitschuh/security-research
Disallow: *

This bot will respect the ROBOTS.txt format for future contributions.
Alternatively, if this project is no longer actively maintained, consider archiving the repository.
CLA Requirements
This section is only relevant if your project requires contributors to sign a Contributor License Agreement (CLA) for external contributions.
It is unlikely that I'll be able to directly sign CLAs. However, all contributed commits are already automatically signed-off.

The meaning of a signoff depends on the project, but it typically certifies that committer has the rights to submit this work under the same license and agrees to a Developer Certificate of Origin
(see https://developercertificate.org/ for more information).
- Git Commit Signoff documentation

If signing your organization's CLA is a strict-requirement for merging this contribution, please feel free to close this PR.
Sponsorship & Support
This contribution is sponsored by HUMAN Security Inc. and the new Dan Kaminsky Fellowship, a fellowship created to celebrate Dan's memory and legacy by funding open-source work that makes the world a better (and more secure) place.
This PR was generated by Moderne, a free-for-open source SaaS offering that uses format-preserving AST transformations to fix bugs, standardize code style, apply best practices, migrate library versions, and fix common security vulnerabilities at scale.
Tracking
All PR's generated as part of this fix are tracked here: https://github.com/JLLeitschuh/security-research/issues/10

@JLLeitschuh I am not sure what vulnerability you are referring to. I am seeing a single change in a single test case.

Regardless, this is most likely a valid security hardening for your tests. These pull requests are generated automatically by me, but I don't make any assumptions on whether or not test code could be vulnerable or not.

This will just cause tests to fail more or less randomly unless I am missing something. That's the opposite of "hardening ".  Can you explain please, as opposed to forcing people to read machine generated text.

This will just cause tests to fail more or less randomly unless I am missing something. That's the opposite of "hardening ". Can you explain please, as opposed to forcing people to read machine generated text.

Why are they supposed to fail?

Also, the text isn't machine generated. It's written by me and has been reviewed by several people before we used it.
I don't understand your concern around causing the tests to fail more often. Could you please elaborate upon what your concerns are?


Explorer: show the address that publishes the package

In the package object we stored the transaction that creates the object, which can be used to derive the address

@666lcz is this on the transaction page?

This is closed by the PR https://github.com/MystenLabs/sui/pull/2704


Access-Control-Allow-Origin is not set according to the docs

Hi
From https://posativ.org/isso/docs/quickstart/ :

You must provide a custom configuration to set [...] host (a list of websites for CORS)

However, the current code only use the first host defined in the configuration:
https://github.com/posativ/isso/blob/master/isso/wsgi.py#L100
(I admit I don't quite understand what role have HTTP_ORIGIN / HTTP_REFERER here,
nor the urlsplit(loc) == split check on line 97)
In order to work around this limitation, and because I don't quite get the logic behind this function,
I submitted a PR: https://github.com/posativ/isso/pull/393
This PR also allow to configure wildcard CORS origins

Closing this as https://github.com/posativ/isso/pull/393 has been merged


Added Symphony version to javascript

I hope this won't be controversial :smile:
Currently there is no way for extensions to get to the variable easily.

@brendo I've scope it to 2.6.0. Feel free to change this or merge.

Yeah, this is fine, and a good addition :)

:+1:


Provide information about presence of Unicode name / comment in ZipArchiveEntry

https://issues.apache.org/jira/browse/COMPRESS-429

Coverage decreased (-0.01%) to 85.869% when pulling 36d504d38cae2edcc4e389bb132ece0888c32c78 on dalbani:COMPRESS-429 into 10ff1c341d37da1cdb2a9ecb280a7e73670c00f5 on apache:master.

Coverage decreased (-0.01%) to 85.869% when pulling 36d504d38cae2edcc4e389bb132ece0888c32c78 on dalbani:COMPRESS-429 into 10ff1c341d37da1cdb2a9ecb280a7e73670c00f5 on apache:master.

Coverage decreased (-0.02%) to 85.889% when pulling db0df3deff3301351e49e5b5e80f1e0926317063 on dalbani:COMPRESS-429 into 78cb9bf36dab81e15887f451fbc964cf57e94739 on apache:master.

Coverage decreased (-0.04%) to 85.865% when pulling db0df3deff3301351e49e5b5e80f1e0926317063 on dalbani:COMPRESS-429 into 78cb9bf36dab81e15887f451fbc964cf57e94739 on apache:master.

Many thanks @dalbani this looks good. I've got two wishes, though:

could you please revert the change in imports to ZipFile? We don't want to use *-imports add all.
the new enums could use some javadoc inclusing a @since marker

Of course, adding tests woudln't hurt , either;-)


Update Sass-lint version

Bump Sass-lint version from 1.2 to 1.3.
Changelog

I would hold off for a moment, I'm going to push 1.4.0 out today hopefully..

Oh nice. Looking forward to class-name-format.

Also the dependencies are set at '^1.2.0so this wont actually be necessary as this will automatically oull down a version ofsass-lint<2.0.0` you'd just need to remove your current copy of this and re download.

Ah good point. I mixed up ~ and ^.

Ha, no worries, I had to double check too :flushed:


Added unit tests and loglevel 'none.'

The changes to config.js and packages.json happened when running the install commands. I think I've tested just about everything there is to test.

What version of jspm are you using? It looks likes some things have changed in terms of how it manages the config.js file.

I'm using 0.10.0 on Windows
On Jan 3, 2015 2:20 PM, "Rob Eisenberg"<EMAIL_ADDRESS>wrote:

What version of jspm are you using? It looks likes some things have
changed in terms of how it manages the config.js file.
—
Reply to this email directly or view it on GitHub
https://github.com/aurelia/logging/pull/1#issuecomment-68606051.

Can you fix your commit message to match the guidelines? See here.

I'm going to close this pull request then redo it with two commits.


Timezone doesn't apply

Versions
"ember-cli": "2.6.2",
"ember-moment": "4.1.0",
My template.hbs has a code below but doesn't show the correct date based on the timeZone defined on addon
    {{moment-format model.createdAt "MMM DD, YYYY · LT" timeZone="Singapore"}}

on my config/environment.js I also included the code below
        moment: {
          includeTimezone: 'all'
        },

Any response is much appreciated, thank you

@mikeelemuel if you manually create a new moment object in the console does it have the tz method defined?

https://github.com/stefanpenner/ember-moment/blob/bef0f56ab7277070dff8a595ecd4fdb509a3ac0b/addon/helpers/-base.js#L42-L44

we found that all did not work. tried ranges, no luck, The only thing we got to work or at least not error was below
'moment': {
      // Options:
      // 'all' - all years, all timezones
      // 'subset' - modern time zones
      // 'none' - no data, just timezone API
      includeTimezone: 'subset'
    },

I thought I would look in the code and see what was really happening but cant find it. Where in the code is this config item even being referenced?
Also the ember-try seems really out of date. I looked because the commits said there was an update of a dependency ember-awesome-macros which states it only supports 3.8 + was trying to figure out what this addon actually supports.


Bug Report: thread panicked while processing panic. aborting.

I simulated a panic in the tauri command. but the with_panic_hook callback handler caused panic again. I setup a dead simple with_panic_hook which just print some plain text.  i found lib.rs #74 hook_client.flush_blocking(); may create panic again.
#[tauri::command]
pub async fn update(
    app_handle: tauri::AppHandle,
) -> Result<(), Errors> {
    panic!("make a panic to test the error handler");
}

Environment:

tauri-plugin-aptabase: 0.4
tauri: 1.5.x
os: MacOS 13.5

i found tauri-plugin-aptabase released 0.5.0, the bug has been fixed.
but no 0.5.0 version in the release page and changelog.md. 😭

good catch @zackshen :)
I completely forgot about those steps. Thank you, I fixed it :)


Facing the issue with pipenv while resolving the dependencies from pipfile

Hello all,
I am facing issue with pipenv, It is successfully creating the pip environment but while resolving the dependencies in the pipfile it is givng the below error:-
CRITICAL:pipenv.patched.notpip._internal.resolution.resolvelib.factory:Could not find a version that satisfies the requirement autopep8 (from versions: none)
[ResolutionFailure]:   File "/usr/local/lib/python3.6/dist-packages/pipenv/resolver.py", line 823, in _main
[ResolutionFailure]:       pre, clear, verbose, system, write, requirements_dir, packages, dev
[ResolutionFailure]:   File "/usr/local/lib/python3.6/dist-packages/pipenv/resolver.py", line 778, in resolve_packages
[ResolutionFailure]:       requirements_dir=requirements_dir,
[ResolutionFailure]:   File "/usr/local/lib/python3.6/dist-packages/pipenv/resolver.py", line 759, in resolve
My Pipfile looks like as shown below:-
[[source]]
name = "pypi"
url = "https://pypi.org/simple"
verify_ssl = true
[dev-packages]
pylint = ""
autopep8 = ""
[packages]
robotframework =""
robotframework-sshlibrary = ""
robotframework-requests = ""
robotframework-seleniumlibrary = ""
Could anyone please help me with this issue?

I think those markers are wrong -- you need like robotframework ="*"

I think those markers are wrong -- you need like robotframework ="*"

Sorry i didn't copy it properly please see the pipfile as shown below:-
There * in inverted commas
[[source]]
name = "pypi"
url = "https://pypi.org/simple"
verify_ssl = true
[dev-packages]
pylint = ""
autopep8 = ""
[packages]
robotframework =""
robotframework-sshlibrary = ""
robotframework-requests = ""
robotframework-seleniumlibrary = ""

I see -- @pari544 Possibly because your python 3.10 is not in quotes it is being interpreted as a float value and so its trying to resolve to python 3.1 for which there is no supported version.

I see -- @pari544 Possibly because your python 3.10 is not in quotes it is being interpreted as a float value and so its trying to resolve to python 3.1 for which there is no supported version.

But here in this pipfile there is not python version at all. could you please locate me exactly which one you are talking about?

I see the actual issue now is your stack trace is referencing python 3.6 which support was dropped from pipenv.  You don't state what version of pipenv you are on, but we no longer support 3.6 at all.

My comment about 3.10 was intended for another thread that I had seen come in via Email. Disregard that.

I am using the pipenv version  as 2022.4.8

I see the actual issue now is your stack trace is referencing python 3.6 which support was dropped from pipenv. You don't state what version of pipenv you are on, but we no longer support 3.6 at all.

Then I understood that i have to upgrade the python to 3.10 version

My comment about 3.10 was intended for another thread that I had seen come in via Email. Disregard that.

okay fine understood

I see the actual issue now is your stack trace is referencing python 3.6 which support was dropped from pipenv. You don't state what version of pipenv you are on, but we no longer support 3.6 at all.

Then I understood that i have to upgrade the python to 3.10 version

Mainly in the error, it is showing that it is not able to locate the autopep and pylint packages to install.
Are these packages are part of pipenv only?

3.6 support was still present in 2022.4.8, I just don't have the means or time to support a 3.6 specific environment resolution issue -- likely one of the packages you are calling out requires something that is no longer 3.6 compatible.  Also you didn't give the exact command you ran to generate the error -- next time please follow the issue template.

@no @pari544 Those packages are in pypi as you can see:
https://pypi.org/project/autopep8/
https://pypi.org/project/pylint/

3.6 support was still present in 2022.4.8, I just don't have the means or time to support a 3.6 specific environment resolution issue -- likely one of the packages you are calling out requires something that is no longer 3.6 compatible. Also you didn't give the exact command you ran to generate the error -- next time please follow the issue template.

okay.,, command we used is "pipenv install --python3 --dev"  which creates the virtual environment and then it tries to access the pipfile inorder to resolve dependecies which are mentioned in pipfile

Hello all,
Please help me out with this issue
It would be greatful if you give some solution for this
Thanks

Sorry @pari544, I am unable to reproduce this issue and you did not follow the issue template which only gives us partial information about your issue.   Are you able to access pypi at all?  The links I provided above are not to be supplied to pipenv, they are for visiting in your browser to check those packages do in fact exist in pypi.  Best regards,

What is the template I have to follow.. please let me know the template format.. I will mention the issue in that format only.
Yes, I checked manually accessing the "https://pypi.org/simple" and able to access this link

@pari544 This is the issue template -- https://github.com/pypa/pipenv/issues/new?assignees=&labels=&template=Bug_report.md
Why don't you just open a new bug report using that template and I'll close this one out and we can start over fresh.  There is a lot of conversation here that is not going to be helpful to keep reparsing.

Yes you can close this issue I am creating a new one


Support pre_release in BuildNumberVersion

When this versioning hook was implemented it missed support for the pre_release? flag.
:mag: /cc @bozo-scripts

Hey @lukesmith,
Thanks for opening this pull-request! There's just a thing or two more that you need to do before we can consider it for bozo-scripts:

should always include a youtrack issue
should be signed off by a non committing developer

As soon as you do that, we'll consider your submission right away!
Thanks!
Note: For a full list of issue filing guidelines, please refer to the bozo-scripts issue filing guidelines.


When will the Chinese model be released？

When will the Chinese model be released？

Try this https://github.com/ymcui/Chinese-ELECTRA


Recursion Crashes Under Windows in Python 3.12 and 3.13

Discussed in https://github.com/pytest-dev/pyfakefs/discussions/1095

Originally posted by MikeTheHammer December  3, 2024
I think this is a bug, but it might be something I'm doing wrong.
I've run the following smoke test under Linux (Ubuntu 24.04) and Windows 10 LTSC, using Pythons 3.9 - 3.13 .
def test__pyfakefs_smoke(fs):
    filename = r"C:\source_file"
    fs.create_file(filename)
    with open(filename) as source_file:
        assert True

Under Linux, this test passes on all Pythons 3.9 - 3.13. Under Windows, it passes on 3.9 - 3.11, but crashes with a RecursionError: maximum recursion depth exceeded on Python 3.12 and 3.13.
On Python 3.12, the stack trace is:
============================= test session starts =============================
platform win32 -- Python 3.12.4, pytest-8.3.4, pluggy-1.5.0
rootdir: C:\Users\Hammer\pyfakefs_smoke
plugins: pyfakefs-5.7.2
collected 1 item

test_pyfakefs_smoke.py F                                                 [100%]

================================== FAILURES ===================================
____________________________ test__pyfakefs_smoke _____________________________

filename = 'C:\\Users\\Hammer\\pyfakefs_smoke\\venv312\\Scripts\\pytest.exe\\__main__.py'
module_globals = None

    def updatecache(filename, module_globals=None):
        """Update a cache entry and return its list of lines.

C:\Users\Hammer\pyfakefs_smoke\venv312\Lib\site-packages\pyfakefs\fake_io.py:124: in open_code
    return self._io_module.open_code(path)
C:\Users\Hammer\pyfakefs_smoke\venv312\Lib\site-packages\pyfakefs\fake_io.py:93: in open
    return fake_open(
C:\Users\Hammer\pyfakefs_smoke\venv312\Lib\site-packages\pyfakefs\fake_open.py:89: in fake_open
    if is_called_from_skipped_module(
C:\Users\Hammer\pyfakefs_smoke\venv312\Lib\site-packages\pyfakefs\helpers.py:494: in is_called_from_skipped_module
    stack = traceback.extract_stack()
C:\Program Files\Python312\Lib\traceback.py:232: in extract_stack
    stack = StackSummary.extract(walk_stack(f), limit=limit)
C:\Program Files\Python312\Lib\traceback.py:395: in extract
    return klass._extract_from_extended_frame_gen(
C:\Program Files\Python312\Lib\traceback.py:438: in _extract_from_extended_frame_gen
    f.line
C:\Program Files\Python312\Lib\traceback.py:323: in line
    self._line = linecache.getline(self.filename, self.lineno)
E   RecursionError: maximum recursion depth exceeded
!!! Recursion detected (same locals & position)
=========================== short test summary info ===========================
FAILED test_pyfakefs_smoke.py::test__pyfakefs_smoke - RecursionError: maximum...
============================== 1 failed in 0.64s ==============================

The stack trace in 3.13 is similar:
============================= test session starts =============================
platform win32 -- Python 3.13.0, pytest-8.3.4, pluggy-1.5.0
rootdir: C:\Users\Hammer\pyfakefs_smoke
plugins: pyfakefs-5.7.2
collected 1 item

test_pyfakefs_smoke.py F                                                 [100%]

================================== FAILURES ===================================
____________________________ test__pyfakefs_smoke _____________________________

filename = 'C:\\Users\\Hammer\\pyfakefs_smoke\\venv313\\Scripts\\pytest.exe\\__main__.py'
module_globals = None

    def updatecache(filename, module_globals=None):
        """Update a cache entry and return its list of lines.
        If something's wrong, print a message, discard the cache entry,
        and return an empty list."""

C:\Users\Hammer\pyfakefs_smoke\venv313\Lib\site-packages\pyfakefs\fake_io.py:124: in open_code
    return self._io_module.open_code(path)
C:\Users\Hammer\pyfakefs_smoke\venv313\Lib\site-packages\pyfakefs\fake_io.py:93: in open
    return fake_open(
C:\Users\Hammer\pyfakefs_smoke\venv313\Lib\site-packages\pyfakefs\fake_open.py:89: in fake_open
    if is_called_from_skipped_module(
C:\Users\Hammer\pyfakefs_smoke\venv313\Lib\site-packages\pyfakefs\helpers.py:494: in is_called_from_skipped_module
    stack = traceback.extract_stack()
C:\Program Files\Python313\Lib\traceback.py:260: in extract_stack
    stack = StackSummary.extract(walk_stack(f), limit=limit)
C:\Program Files\Python313\Lib\traceback.py:445: in extract
    return klass._extract_from_extended_frame_gen(
C:\Program Files\Python313\Lib\traceback.py:492: in _extract_from_extended_frame_gen
    f.line
C:\Program Files\Python313\Lib\traceback.py:369: in line
    self._set_lines()
E   RecursionError: maximum recursion depth exceeded
!!! Recursion detected (same locals & position)
=========================== short test summary info ===========================
FAILED test_pyfakefs_smoke.py::test__pyfakefs_smoke - RecursionError: maximum...
============================== 1 failed in 1.20s ==============================

Versions:

pytest 8.3.4

pyfakefs 5.7.2

Linux Ubuntu 24.04 - Linux 6.8.0-49-generic x86_64:

Python 3.9.19
Python 3.10.14
Python 3.11.9
Python 3.12.4
Python 3.13.0

Windows 10 LTSC 21H2 (OS Build 19044.5131) :

Python 3.9.13
Python 3.10.11
Python 3.11.9
Python 3.12.4
Python 3.13.0

I have seen a somewhat similar behavior with #1086, but labeled it as a limitation due to another context.
But if that happens with such a basic test, it is certainly a bug, at least as far as I can see now.
I did not really understand the cause of the problem (it has to do with the virtual environment and the Python path, but I was not able to find a good solution to prevent this).
An easy workaround to fix this is to use python -m pytest instead of calling pytest directly. This is generally considered good practice, but the direct call should also work. I cannot promise a timely fix, as I already have been struggling with this without success, but I will see what I can do.

Yes, running it as python -m pytest works for me with both 3.12 and 3.13.

@MikeTheHammer - I added a woekaround that should mitigate the issue. Can you please check if the main branch works for you?

@MikeTheHammer - I added a woekaround that should mitigate the issue. Can you please check if the main branch works for you?

I've made a new patch release with the workaround. I'm not happy with the solution and will try to understand the underlying issue better, but I'm closing this issue for now. Please re-open if the issue persists with the current version.


Installation offline

What problem does this feature solve?
Create applications disconnected from the internet, previously it was possible to download the templates (vue init webpack --offline) and then install their disconnected dependencies in the same way (yarn install --offline), like me many people in my country do not have a connection stable (constant) and high level (slow), so we handle a huge cache, but it is an alternative that allows us to continue developing very
What does the proposed API look like?
Could not be as it was before? vue create app --offline

The generic way to implement this is to allow specification of 'package manager args' along with --packageManager.  E.g.
vue create --packageManager yarn --packageManagerArgs '--prefer-offline' app

This would also allow for a .yarnrc file to be specified.

Vue CLI will honour a .yarnrc file that's in the new project's directory.
This introduces are chicken-and-egg situation though if you're using a monorepo.
# setup a repo-wide yarnrc file to set prefer-offline mode
echo '--install.prefer-offline' >> .yarnrc
# pre-create the new Vue CLI project directory
mkdir app
# symlink .yarnrc into the project directory
ln -srt app .yarnrc
# create the project, but merge it with the existing directory
vue create --packageManager yarn --merge app

Thanks for the advice, now after trying I get an error that says Unknown option --packageManagerArgs

Sorry, there's no such argument. That message was a suggestion of how the yarn devs could help fix it.
Use the .yarnrc solution I posted.

Further issues...
@vue/lib/Creator.js, line 133
    const { latestMinor } = await getVersions()

and line 154
        ((/^@vue/.test(dep)) ? `~${latestMinor}` : `latest`)

are non-deterministic. This forces yarn to try and search for a version matching the ~ constraint. This fails with the yarn-offline-mirror.


How do I unfilter the icon for a column

I tried to set the filterable of the column to false but still show the icon， How do I cancel？

Do you want to remove the filterable input field if all columns have a filterable property set to false?

I've tried to delete them all but I still have the ICONS that are displayed and I just want to turn off the filter so can I only use CSS to limit it

You mean the sort icons, because their are no filter icons, only a filter input field?

It's not that I want to get rid of the sort icon in the header of the table which property I'm going to set

remove the order and direction property of the column object.

Thank you. I hope you can update the document

Will add it to my, otherwise feel free to create a merge request.

ok thank you


Adapt intro checklist for video events

Closes #11.

Forgot two things, one more commit incomming.


Fix typo in usage.rst

I think this is a typo?
There are no other quotation marks in the yaml file, and in any case, quotation marks should come in pairs. I think this is probably just a typo.

Can be closed in favour of https://github.com/12rambau/pytest-copie/pull/49


organize cli

Codecov Report

Merging #20 (f273d6f) into main (53a5aab) will increase coverage by 1.36%.
The diff coverage is 83.50%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##             main      #20      +/-   ##
==========================================
+ Coverage   80.68%   82.04%   +1.36%
==========================================
  Files          14       11       -3
  Lines         264      323      +59
==========================================
+ Hits          213      265      +52
- Misses         51       58       +7

Impacted Files
Coverage Δ

omnibridge/wrappers/runners.py
54.05% <56.25%> (+0.72%)
:arrow_up:

...nibridge/model_entities/models_io/base_model_io.py
80.00% <70.00%> (ø)

...wrappers/wrapper_instances/hugging_face_wrapper.py
80.00% <72.72%> (-20.00%)
:arrow_down:

...bridge/wrappers/wrapper_instances/dalle_wrapper.py
63.04% <75.00%> (+8.49%)
:arrow_up:

...nibridge/wrappers/wrapper_instances/gpt_wrapper.py
86.84% <85.71%> (-13.16%)
:arrow_down:

...dge/wrappers/wrapper_instances/rest_api_wrapper.py
90.32% <85.71%> (ø)

...bridge/wrappers/wrapper_interfaces/ModelWrapper.py
85.71% <85.71%> (ø)

omnibridge/saved_data/json_data_manager.py
91.66% <91.66%> (ø)

omnibridge/cli/argument_parser/commands.py
100.00% <100.00%> (ø)

omnibridge/wrappers/api_key.py
100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Add more icons support

see
https://realfavicongenerator.net/favicon_checker?protocol=https&site=threejsfundamentals.org

note: ideally I think this should be part of the build. I don't want to have to manage multiple images. I just want one image and if need be some build rules to generate the others, hopefully without a billion dependencies 😜

FYI: that site helps know what to do but it also has a seriously bad build library that calls out to their server to generate icons in your build. That's about the most horrible thing you could ever do so no, please don't use that site's build scripts.


chainntnfs: re-enable height hint cache

In this PR, we attempt to re-enable the height hint cache for the different ChainNotifier implementations. This will lead to performance improvements upon startup when running a full node backend without txindex or when running as a light client, like Neutrino.
Depends on #1787 and #2004.

Ready for review! There are some additional commits (might seem unrelated) that solve some integration test flakes due to timing issues upon re-enabling the height hint cache.
One thing that's left to address is whether we want to clear the existing state of users' caches. I believe this won't be needed in the case that users have successfully started up after the cache was disabled, as a rescan will occur from the broadcast height and catch everything since then. If this hasn't happened however, it's possible that they begin their rescan after the fact due to previous incorrect behavior of the cache.

There shouldn't be any issues with the integration tests other than:
    --- FAIL: TestLightningNetworkDaemon/revoked_uncooperative_close_retribution_zero_value_remote_output (35.39s)
        lnd_test.go:74: Failed: (revoked uncooperative close retribution zero value remote output): exited with error:
            *errors.errorString unable to find Carol's force close tx in mempool: wanted 1, found 2 txs in mempool: [98075d6b639105d4ed259c77ed171c7e14f3d9daeb22fce5b31a5287668d52f2 b8b042732be88531c640f3f4179cfde1a5baf8a3cd5423c3df0723598c39c0e2]
            /Users/wilmer/go/src/github.com/lightningnetwork/lnd/lnd_test.go:6417 (0x17ade6a)
            	testRevokedCloseRetributionZeroValueRemoteOutput: t.Fatalf("unable to find Carol's force close tx in mempool: %v",
            /Users/wilmer/go/src/github.com/lightningnetwork/lnd/lnd_test.go:99 (0x1788ae6)
            	(*harnessTest).RunTestCase: testCase.test(net, h)
            /Users/wilmer/go/src/github.com/lightningnetwork/lnd/lnd_test.go:12591 (0x17e1c44)
            	TestLightningNetworkDaemon.func3: ht.RunTestCase(testCase, lndHarness)
            /usr/local/Cellar/go/1.11.1/libexec/src/testing/testing.go:827 (0x10f590f)
            	tRunner: fn(t)
            /usr/local/Cellar/go/1.11.1/libexec/src/runtime/asm_amd64.s:1333 (0x105dcb1)
            	goexit: BYTE	$0x90	// NOP

I rarely hit this on Travis though, can only reproduce it reliably locally. This will be resolved by https://github.com/lightningnetwork/lnd/pull/1621/commits/dbc11c7ed3c4608dffe7aa6fd9d1f67512028311.

Also note that I split the integration test fix into https://github.com/lightningnetwork/lnd/pull/2116, so we can get them in before doing the bigger multi-backend change.

I don't think we need to worry about clearing any existing caches, as it was never included in a major release. Additionally, any entries that users had in their caches are now long expired since many weeks have passed since the initial implementation, and the commit that disabled all the caches. The users that had prior height hints also in a way will benefit from them as they won't need to start from the initial broadcast (or confirm or w/e height) and can start a bit earlier in the chain.


Make filters configurable

For some reason, even though I set the default value of the filters parameter to an empty string "", when the -Dfilters flag isn't used the field remains null. To fix this I added a null check (Line 207 of DiffGoal.java) to set the string to "", but I'm not sure why the @Parameter defaultValue isn't working.
I also didn't add a lot of comments explaining the logic because the existing code in DiffGoal.java isn't very commented, but I'd be happy to add more if that would be beneficial.

Also one of the integration test seems to be failing. Perhaps it is an issue with the updated MutationGuidance constructor referenced in MutationGuidanceIT.java? Or is it something else?


Compute validation loss while training?

I would like to separate my dataset into 3 sets: train, val and test, so that I can use the "val" dir for validating during the training phase and "test" dir for the final test.
From the Readme.md I think here "val" is used as a test set instead of a validation set. If I would like to make val and test separated as I said above, what can I do?
Thank you very much!

I tried to this, take a look:
https://github.com/affinelayer/pix2pix-tensorflow/issues/200


[WIP] API App object implementation

Don't merge yet, posted as request to get early peer review underway.
See https://github.com/silverstripe/silverstripe-framework/issues/6681
Other PRs:

[ ] https://github.com/silverstripe/silverstripe-cms/pull/1854
[ ] https://github.com/silverstripe/silverstripe-asset-admin/pull/505
[ ] https://github.com/silverstripe/silverstripe-admin/pull/110
[ ] https://github.com/silverstripe/silverstripe-assets/pull/25
[ ] https://github.com/silverstripe/silverstripe-versioned/pull/16
[ ] https://github.com/silverstripe/silverstripe-testsession/pull/49
[ ] https://github.com/silverstripe/silverstripe-installer/pull/183
[ ] https://github.com/silverstripe/silverstripe-reports/pull/74
[ ] https://github.com/silverstripe/silverstripe-siteconfig/pull/63
[ ] https://github.com/silverstripe/silverstripe-graphql/pull/104
[ ] https://github.com/silverstripe/silverstripe-behat-extension/pull/163

In my most recent push I've consolidated both php-ini modification global methods, as well as direct global access into a new Environment class, and marked it as to be used sparingly.
The logic for constructing HTTPRequest objects has been moved into HTPRequestBuilder, and a CLIRequestBuilder supercedes the original cli.php bootstrap file.

I haven't fully reviewed this, but where is setUpOnce called and how come we're now going back to this pattern?

@dhensby from setupBeforeClass.
public static function setUpBeforeClass()
    {
        // Start tests
        static::start();

        // Call state helpers
        static::$state->setUpOnce(static::class);
        ...

I'll move all http* classes to control @sminnee

Resolved conflicts locally, and merged with git merge --squash through 3873e4ba008cfc2af7e26ca86665affc289cd677. Now merging other requests and keeping an eye on builds. It's going to be a bit of a rocky ride in terms of build failures over the next ~16h. Happy to take a look in the NZ morning, unless @dhensby feels like checking build results as they come in.


Add RAML import

You can now choose between RAML and Swagger to import API definitions into 3scale

Tests @picsoung ??? :-)


MEV-Boost Support for Lighthouse

Hey Guys,
Can anyone confirm if mev-boost support is working for the lighthouse consenus client?
If not which client is it working for?

It's working for all clients. Nimbus requires a source build from unstable, likely until their next release.
Keep in mind Goerli has not merged, so mev-boost will error on that network until after merge.

Yorick,
Thanks for confirming.
You guys have done an excellent job and have covered all the basis! 👍
Found this gem from Remy while reviewing July's call: https://youtu.be/DMynQb6MSfc?t=1157


Preserving State

How can I achieve the same state preservation in this library as I had with a stack of activities? When I open a new activity on top of another, the state of the underlying activity is preserved, including all Views and ViewModels. However, when trying to replicate this behavior with AnimatedHost in Jetpack Compose, the state of the previous screen is lost. This includes the state managed by remember, AndroidView, and ViewModel. What can I do to ensure that the state of the previous screen is retained when navigating between screens using AnimatedHost?

@rpuxa-copilot For saving a state of a composable function you should use 'rememberSaveable' https://developer.android.com/develop/ui/compose/state#restore-ui-state
For saving a state of ViewModel use 'SavedStateHandle' https://developer.android.com/topic/libraries/architecture/viewmodel/viewmodel-savedstate
The library fully supports this functionality and doesn't change the already existing API in any way.

I think you completely misunderstood my question. I don't need to save the state during process death. I need to save state when I go to another screen and back. Here is the simplest example I can provide.
`@Composable
fun Test() {
Column {
val navController = rememberNavController(startDestination = 1)
    Text(text = "Next", modifier = Modifier.clickable {
        navController.navigate(navController.backstack.entries.last().destination + 1)
    })

    Text(text = "Prev", modifier = Modifier.clickable {
        navController.pop()
    })

    NavHost(navController) { destination ->
        AndroidView(factory = {
            WebView(it).apply {
                loadUrl("www.example.com/$destination")
            }
        })
    }
}

}`
If I click Next and the Prev, the first WebView gets completely reloaded. This happens because when I go from screen 1 to screen 2, the first WebView gets discarded. This also happens to remember functions and ViewModels.
If I used Fragments or Activities, I wouldn't get this problem

I am sorry, you where right about rememberSaveable. But, I think, I have to do something about AndroidView by myself (implement some kind of cache logic with rememberSaveable). Thank you for your answer!


Some code correction requirements

Greetings!
First of all thank you very much for this awesome software to be available as Open Source product.
I searched the Internet for something like this to show photos in a gallery-style way.
Now let me write my experience in an issue report:
For this product test I use Windows 10 + Firefox + Apache webserver for win64 - and followed the instruction ("4. Steps to create a gallery") as of 20. Jan. 2024.
#####################################
4.0 Main step: Preparation

Organizing photos in various gallery* subdirectories, keeping in mind the <50 images / dir rules of thumb mentioned later in the instructions - Check.

#-----------------#

create a csv file (building.csv) in the python subdirectory -- Check.

#-----------------#

Install local webserver (apache) - Check.

#-----------------#

Install jupyter notebooks --- and on windows painfully learn how to set it to use the same root dir as the Apache. - Check.

#-----------------#

Download the VGAL repo. - Check,

#-----------------#

(actually the 6. step is marked as 7. in the instructions) Galleries are already there. - Check.

#-----------------#

Run the jupyter notebook and load the notebook VR_gallery.ipynb...
Well: there are some concerns here.

The default values in the VR_gallery.ipynb for:
"building["Technical"]["ambientLight"]=10\n",
"building["Technical"]["pointLight"]=50\n",
Are too much. ambientLight could be 1 while pointlight should be 20.
Also if the image files inside the gallery directories have the extension with capital letters for example .JPG the script simply gets stuck and Jupyter Notebook does not say at which file.
It is good to have the "Handle.exe" tool for windows (something like the "fuser" on Linux ) to find the file where the script stands at, having the PID holding the file - as well as cygwin for bash-like shell commands and iterations for faster file operation thoughout the gallery directories.
Another point here is the aspect ratio of images (height / width): the script seems like tries to guess (?!) the ascect ratio however in some cases they have to be corrected manually in the building.json file - which is a pain in the A job when there are hundreds of images and dozens of galleries.
Of course in case of "dozens of galleries" with <50 images each - the room sizing must be set manually as a trial and error method until the right measure has been found. (the gallery viewer is a good way to test it later on).
Hint for users:
Also the source csv file (building.csv) should be plain, therefore it is not good to edit them - for example - in Excel so there should be no apostrophes present.
The building.json file will be in the root dir of the apache (by default: [Drive]:\Apache24\htdocs directory). It is advised to keep it there and to copy the styles.json there as well. Also copy the new building.json into the vgal subdirectory.
#-----------------#
4.1 Main step:  Hall Builder.

In "/vgal/hall_builder/room_processor.html" I guess the styles.json is missing from the constants.
It calls the "./room_builder_aux.js" java script right at the beginning.

In Firefox the room_builder_aux.js script run on an error stating that "floor_material" is not defined.
It is defined, and the script seems good:
floor_material = materials[data.chosenStyles.chosenFloorStyle];
(Also to mention that the "vgal/blender/scrypt.py" overrides the material attributes.)
When I manually declare the variable to match the information contained in styles.json file as
floor_material = "Wooden";
The next error is that the rb function is not defined in room_processor.html.
As I am not too familiar with the concept (beginner level in python and in Java) so I leave this as it is.
Hall Builder failed for me (this is step 10.) on Windows 10 + Firefox (tried it in Edge and IE compatibility mode as well - No use).
#-----------------#

There is no step 9.

#-----------------#

Yep, Hall Builder failed.

#-----------------#

No downladed room files due to error.

#-----------------#

There is no step 12.

#-----------------#

Probably cannot do without generated files.

#-----------------#
4.2 Main Step: Hall template --- I skipped this during my tests.
#-----------------#
4.3 Main step: On the fly creation (no glb file)
"http://localhost/vgal/gallery_viewer/virtual_gallery.html"
The first problem is with the double quites - they shall be single apostrophes:
const asset_location="/";
const config_file_name="/building.json";
const styles_file_name="/styles.json"
const materials_folder='/vgal/materials';
const hallspics_prefix= '/vgal';
About
const hallspics_prefix= '/vgal';
should this point to /vgal/python    ?
Otherwise it works like charm if the styles.json is also in the root directory of the webserver.
The only issue is that the internal room doors are not working as a link back to the main hall (root) so if I want to get back into the corridor I have to refresh the page.
Plus another big issue after the GalleryViewer works: when I want to export the room(s) to GLB file(s) inside the "GalleryViewer" (babylon.js) the webpage informs me about the Export being in progress... and nothing happens.
There the Firefox web console gives the following information:
BJS - [timestamp]: GLTF2Export is not available. Make sure to load the serializers library
Uncaught TypeError: jl.GLTF2Export is undefined
exportGLTF toolsTabComponent.tsx:286
onClick toolsTabComponent.tsx:501
onClick buttonLineComponent.tsx:20
React 11
unstable_runWithPriority scheduler.production.min.js:18
React 3
The coding reference of Firefox shows the following:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Errors/Unexpected_type?utm_source=mozilla&utm_medium=firefox-console-errors&utm_campaign=default
#-----------------#
So overall the project is very exciting and satisfying as it works like charm in GalleryViewer and needs some manual preparation to make it totally custom.
The textures and sizes etc. are also manually customizable and is a good feature.
Definitely worth to continue developing it, keep up the good work!
Sincerely,
Flow-R-Ian

Hi Flow-R-Ian
Thanks so much for the thorough review !! and thanks so much for the nice and encouraging words ❤
Another user warned me about the light issue. I had been testing lightmaps (that require much higher illumination) and the setting remained. I have already fixed it.
I will go tomorrow through the rest. Some of them are related to the fact that the instructions were quite thorough for v0.1. Since then I have added many features but I have prioritized development for updated documentation. For example the hall builder will be discontinued. The on-the-fly generation does the job in a much more efficient way. A glb file makes sense if it is generated by a 3D tool (blender for ex). As a fallback solution could be generated from the debug menu as you tried. Updating the documentation is in my todo list. I can also create a video.
I have some blender templates and python code to read the json file. The looking is much better but you gotta know blender, which is not trivial.

I went through the list.

To keep the consistency of the folders and the less tweaking I recommended to use devd as a web server. Installing apache would come with its own issues.
Ambient light default setting. FIXED
Image file search in the python script is now case-insensitive. In my case it triggers an error rather than become stuck (both on jupyter notebook and visual studio code). FIXED
With the The HALL Builder is now obsolete and I will remove code and references in the next release. If needed the glb files can be downloaded from the Babylon debug interface. In v0.1 there was no on-the-fly gallery and it made sense, now it does not.
Double quotes or single quotes are technically equivalent, both valid. Corrected anyway. FIXED.
hallpics_prefix should point to the folder in the web server where the images of the building.json files are located. In the default installation that is /vgal. It is correct as it is now.
I have added a line (commented out by default) in the gallery viewer.html with the serializers. If you comment it out, you can save the glb file. FIXED

I need more information for these:

The internal doors currently work well. Sometimes if you resize the window while the gallery is open, the screen position and the door would not be synch anymore. Do you have any error in the browser console?
The aspect ratio is not guessed by the python code is simply taken from the image width and height. Can you send me an image where that does not work well? (could that be images where the camera rotation is encoded in the exif file?)

Hi again,
Thank you for the fast reaction and code corrections. Just cheked it again:
With the door (leading back to the root corridor from a gallery) the window size has not changed. Inside a gallery it just displays a white rectangle at the place of the door with a label: "Entrance". The item seems not active. There is an error in the browser console:
Uncaught (in promise) TypeError: item_names[j] is undefined
rb room_builder_aux.js:392
galleryManager virtual_gallery.html:454
execute directActions.ts:511
_executeCurrent action.ts:173
processTrigger actionManager.ts:353
_processPointerUp scene.inputManager.ts:499
_onPointerUp scene.inputManager.ts:979
_initClickEvent scene.inputManager.ts:669
_onPointerUp scene.inputManager.ts:908
attachControl scene.inputManager.ts:1044
notifyObservers observable.ts:393
_onInputChanged deviceSourceManager.ts:165
o internalDeviceSourceManager.ts:79
_pointerUpEvent webDeviceInputSystem.ts:605
##################
As for the aspect ratio I checked the creation of the building.json file again and caught an example of a portait direction image getting identified as being in "Landscape" direction.

But that is all. Hope they require just a minor correction.
Sincerely,
Flow-R-Ian

Hi !
On the second one what would help me is an image (the actual file) showing the problem, but I guess I understand the issue. It must be related to the fact that sometimes the exif information (the metadata) in the image saves the orientation information. All modern cameras include it. The script could read that metadata. In the meantime you can enforce the rotation of the orientation field with many tools (https://linux.die.net/man/1/exiftran for example, there must be many).
On the second one it is a bit tricky to trouble shoot just with the error. What you might have forgotten (actually I think I forgot to include it in the documentation) is to include the in the csv file one item, normally in the north wall for the door. What this means is that if you have 20 images in a gallery and you distribute 5+5+5+5 in the four wall that will miss the door. In such case the number of items should be 6 +5 +5 +5. If that would not work, send me the building json and I can try to dig further.
I will probably work directly on v1 with major updates in automation and flexibility to use materials.

Version 0.99 is almost ready fixing these issues and adding features. I need to write the documentation

Awesome, thank you.

The just uploaded version brings a lot of improvements, including metadata orientation detection. This closes, the list of issues you reported. Enjoy


819 publish cherrypicks

cp PR #15671
cp PR #15690
cp PR #15482
cp PR #15677
cp PR #15676
cp PR #15672
cp Merge pull request #15510 from kblin/issue-14795
cp Merge pull request #15337 from phemmer/doc-builder-volume
cp Merge pull request #15605 from dharmit/15530-remove-the-terms-folder
cp Merge pull request #15613 from mgrauer/update_docs_installation_mac_docker_machine_name
cp Merge pull request #15430 from charleswhchan/patch-2
cp Merge pull request #15237 from charleswhchan/patch-3
cp Merge pull request #15428 from charleswhchan/patch-1
cp Merge pull request #15542 from MHBauer/rundoclink
cp Merge pull request #15574 from diogomonica/fixing-race-on-key-backup
cp Merge pull request #15560 from docker/patch-bad-formatting
cp Merge pull request #15451 from liubin/liubin/fix-broken-link
cp Merge pull request #15541 from thaJeztah/hashtag-space
cp Merge pull request #15450 from liubin/liubin/change-port-number-through-example

ping @thaJeztah

I'm on my phone now so "lgtm", but let me know if you want me to check if each one should be picked :smile:

@thaJeztah I don't think it is necessary for you to check.  All I've done a check or two and a final just now.

Author LGTM


Bad request (400) error when trying to retrieve Swagger json by URL behind corporate proxy

If I run swagger-typescript-api I get this error:
✨   try to get swagger by url "https://localhost:44368/swagger/v1/swagger.json"
(node:5904) UnhandledPromiseRejectionWarning: Error: Request failed with status code 400
    at createError (C:\Users\C331663\source\repos\commodity-ui\node_modules\axios\lib\core\createError.js:16:15)
    at settle (C:\Users\C331663\source\repos\commodity-ui\node_modules\axios\lib\core\settle.js:17:12)
    at IncomingMessage.handleStreamEnd (C:\Users\C331663\source\repos\commodity-ui\node_modules\axios\lib\adapters\http.js:260:11)
    at IncomingMessage.emit (events.js:327:22)
    at endReadableNT (_stream_readable.js:1201:12)
    at processTicksAndRejections (internal/process/task_queues.js:84:21)
(Use `node --trace-warnings ...` to show where the warning was created)
(node:5904) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting
a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/a
pi/cli.html#cli_unhandled_rejections_mode). (rejection id: 2)
(node:5904) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a
 non-zero exit code.

First problem is that the Axios get for URL doesn't have a catch clause, so we have this awful dump.
Second problem is that I received a HTTP 400. After some investigation I found out was the corporate proxy which I'm behind.
I raised a PR to fix both problems:
https://github.com/acacode/swagger-typescript-api/pull/232
Would be thankful if you'd include it in next release.
Tnx
Fabio

Thank you @kel666 for your contribution!

If someone occurred with this problem reopen this issue please


Upload files with encoded file names in XML

Proposed fix for issue #514. The changed code will try to upload file as usual. If loading the file fails, the filename will be decoded (e.g. "%20" will be converted to a single space) and it will try to read the file with the new filename once more. If the upload fails, a similar workaround will be performed.

Thx Lars, we'll have a look and double check the situation.

Thanks Lars,
It works like a charm! It will be merged. We really appreciate your efforts.


fix: 赋予rds账号权限失败后进行重试

这个 PR 实现什么功能/修复什么问题:
赋予rds账号权限失败后进行重试
是否需要 backport 到之前的 release 分支:

release/2.12

/area region
/cc @swordqiu @yousong

Codecov Report

Merging #3571 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #3571   +/-   ##
======================================
  Coverage    6.96%   6.96%
======================================
  Files         498     498
  Lines       83492   83492
======================================
  Hits         5813    5813
  Misses      77185   77185
  Partials      494     494

Flag
Coverage Δ

#aFlag
6.96% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eceb9a8...25a3915. Read the comment docs.

/lgtm

/approve


Update ODH version, remove bundled monitoring stack and enable oauth for prometheus

I think something went :boom: with the cherry pick


Public IP address

Retrieving Public IP address is currently not working and confirmed by Microsoft.  Do we have an eta for this feature to be fixed?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0fdce995-5347-32c4-119f-6e8484250859
Version Independent ID: 3dcfe7f4-cbb8-6323-5d93-b7e6b7f74db7
Content: Azure Instance Metadata Service
Content Source: articles/virtual-machines/windows/instance-metadata-service.md
Service: virtual-machines-windows
GitHub Login: @harijayms
Microsoft Alias: harijayms

@neilghuman what do you mean by not working? What error are you seeing? What did support say regarding this? Can you share the ticket number?

I will close this out but if you feel you need more information please just let me know.

Hello Micah,
In terms of not working, when the command is ran, it returns an empty string in terms of Public Ip address.  The Azure Product group is aware of this issue and is currently working on a fix.  From PG:
We are actively working on getting this fix, our current timelines from engineering team is 10/15 for Public regions, National Clouds by end of the year.
Important note, this will enable Standard VIPs to be access from IMDS, Basic VIPs are already supported.
Thank you and go ahead and close this thread.

This is still a current issue. Just tested the documented steps and they found just empty string for the public IP address for both of:
curl -H Metadata:true "http://<IP_ADDRESS>/metadata/instance/network?api-version=2017-08-01"
and
curl -H Metadata:true "http://<IP_ADDRESS>/metadata/instance/network/interface/0/ipv4/ipAddress/0/publicIpAddress?api-version=2017-08-01&format=text"
Also tried with the latest supported version (as reported by the API, this is 2019-08-15, which is one behind the documented latest version 2019-11-01 - documented version gives an error):
curl -H Metadata:true "http://<IP_ADDRESS>/metadata/instance/network?api-version=2019-08-15"
This also returned "publicIpAddress":""
May want to update docs while this is broken, as docs go out of their way to say how to find the public IP, but that doesn't work.
Tested on a marketplace VM (though I don't think that should matter). I will use a workaround.


Memory allocation should be an instruction

The (new [TYPE]) computation is currently listed as an exception to the rule of computations not modifying the memory. This is a terrible idea and can easily lead to memory being allocated without the user realizing it.
A new instruction, (allocate [POINTER]) should be introduced instead. The type of memory element should be deduced from the type of [POINTER].

Implemented in https://github.com/nsensfel/tonkadur/commit/6b224c3d53920effdc8cff5846cfc49b4a358a19


fix: specs passing for GDAL 3

added OSRGetAxisMappingStrategy
added OSRSetAxisMappingStrategy
added OSRGetPROJVersion
added #axis_mapping_strategy setter/getter to OGR::SpatialReference
added .proj_version getter to OGR::SpatialReference
made specs passing for GDAL 3

@turboladen
I am planning to add some nicer RSpec helpers to handle different GDAL versions (e.g. skip_gdal_version_less_then("3.0.0"), skip_gdal_version_greater_or_equal_to("3.0.0")) to avoid using if/else version checks (which I didn't like).
But it makes sense for me to merge this PR as it is to make specs pass. And then will we could go to some refactoring.


Is there any sense that zgen loads some default plugins for prezto?

After having a look at the initial script ~.zgen/init.zsh, I found some duplicates in pmodload statement at the end of the file. According to issue #74, the duplicate items added are from default configuration of prezto.
I realized pmodload ensures every plugin is loaded only once. But I don't think the behavior of loading some default plugins in a plugin manager as a good idea, cause priority matters for plugins. Default prezto modules loaded by pmodload breaks the capability for users to control the priority themselves.
Luckily, export ZGEN_PREZTO_LOAD_DEFAULT=0 could avoid the loading of default plugins in prezto.
Some essential priorities for plugins in prezto:

utility > compinit > syntax-highlighing > history-substring-search > autosuggestions
utility > compinit > syntax-highlighing > prompt
utility > compinit > fasd

Is there any reason that zgen stick to this behavior? At least, we'd better tell users about this behavior in README.md.

Closed because of inactivity.


yaw angle in camera coordinate

Does anyone understand the specific meaning of yaw angle in the camera coordinate?
why the yaw in the camera coordinate can translate to yaw in world coordinate using the following function?
(project_3d_world function in show_2d3d_box.py)
def project_3d_world(p2, de_center_in_world, w3d, h3d, l3d, ry3d, camera2world):
center_world = np.array(de_center_in_world) #bottom center in world
theta = np.matrix([math.cos(ry3d), 0, -math.sin(ry3d)]).reshape(3, 1)
theta0 = camera2world[:3, :3] * theta  #first column     # theta and theta0 make sense
world2camera = np.linalg.inv(camera2world)
**yaw_world_res = math.atan2(theta0[1], theta0[0])**        **# totally confusing**
verts3d = get_camera_3d_8points_g2c(w3d, h3d, l3d,
    yaw_world_res, center_world[:3, :], world2camera, p2, isCenter=False)

verts3d = np.array(verts3d)
return verts3d

The same question, and I observed that this yaw angle is inconsistent in eval_tools and show_tools, in eval_tools, yaw is the value in the label. The confusing code ishere


The query haven't been passed when I use

Hi, my problem is the query hasn't been passed from my custom field into the related Resource.
The redirect URL has been updated successfully but the fetch destination still be the response of the configured query in restClient.
const LinkToRelatedCategories = ({ record, translate }) => (
  <FlatButton
    primary
    label='Manage'
    icon={<CategoryIcon />}
    containerElement={<Link to={{ pathname: "/Categories", query: { "where":"MerchantID = "+record.id} } } />}
  />
);
export default translate(LinkToRelatedCategories);`

let url = '';
 const { queryParameters } = fetchUtils;
 const options = {};
 switch (type) {
   case GET_LIST: {
     if (resource == 'Merchants') {
       const { page, perPage } = params.pagination;
     const { field, order } = params.sort;
       const query = {
         where: 'UserID = '+localStorage.getItem('userID'),
         order: field + " " + order,
         offset: JSON.stringify((page - 1) * perPage),
         limit:perPage,
       };
       url = `${API_URL}/${resource}?${queryParameters(query)}`;
       console.log(url)

       break;
     }
     if (resource == 'Categories') {
       console.log(params)
       const { page, perPage } = params.pagination;
       const { field, order } = params.sort;
       const query = {
         where:'OwnerType = 0',
         order: field + " " + order,
         offset: JSON.stringify((page - 1) * perPage),
         limit:perPage,

       };

       url = `${API_URL}/${resource}?${queryParameters(query)}`;
       console.log(url)

       break;
     }
   }

Really need your help, much appreciated for any words, thanks!

See:
https://github.com/marmelab/admin-on-rest-demo/blob/master/src/categories/LinkToRelatedProducts.js
I think you first have to implement filter in Category resource.

Yep, you have to build a query with the filter key, as in the example given by @leesei


Dep upgrade, turn on module noInterop for the production flat bundle

Turns out this actually does nothing with Webpack 2 since it resolves modules itself.


[Bug]: Inconsistent attempt to expose non-public error

Description
Program 1 generates an attempt to expose non-public symbol 'Employee'  error, But program 2 is not. Observed this in SL Update 3.
Program 1:
type Employee record {|
|};

client class RainierClient {
    resource function 'select employees() returns stream<Employee, error?> {
    }
}

Program 2:
type Employee record {|
|};

client class RainierClient {
    resource function 'select employees() returns stream<Employee, error?>? {
        return;
    }
}

Steps to Reproduce
No response
Affected Version(s)
No response
OS, DB, other environment details and versions
No response
Related area
-> Compilation
Related issue(s) (optional)
No response
Suggested label(s) (optional)
No response
Suggested assignee(s) (optional)
No response

We have to handle the union case here https://github.com/ballerina-platform/ballerina-lang/blob/master/compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/semantics/analyzer/CodeAnalyzer.java#L1689.


hyprland: 0.39.1 -> 0.40.0; hyprwayland-scanner: init at 0.3.4

Description of changes

hyprwayland-scanner: init at 0.3.4 - needed for Hyprland
hyprland: 0.39.1 -> 0.40.0 - CHANGELOG

Blocked until https://github.com/NixOS/nixpkgs/pull/306557 lands in master. Tracking https://nixpk.gs/pr-tracker.html?pr=306557.

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Looks like swaylock and hyprlock are broken on 0.40.0, so probably makes sense to include the fix: https://github.com/hyprwm/Hyprland/issues/5913

@fufexan It landed.

Everything's almost working. There's one last thing left to solve.
When building, CMake complains about missing XWayland include paths:
hyprland> CMake Error in CMakeLists.txt:
hyprland>   Imported target "PkgConfig::xdeps" includes non-existent path
hyprland>     "/nix/store/7q83znq247cfc65h3zzq6l82z8dr9d56-xwayland-23.2.6/include"
hyprland>   in its INTERFACE_INCLUDE_DIRECTORIES.  Possible reasons include:
hyprland>   * The path was deleted, renamed, or moved to another location.
hyprland>   * An install or uninstall procedure did not complete successfully.
hyprland>   * The installation package was faulty and references files it does not
hyprland>   provide.

Checking the out dir of xwayland, it seems there isn't any include dir, even though it's referenced by its pkg-config file.
Upstream, we fixed this by using an override.
Ideally, this should be fixed in xwayland upstream. I've tested the latest tag, <IP_ADDRESS>2, but it still references the non-existent path. Pinging @emantor.
Alternatively, we could solve the problem if we could remove the path from INTERFACE_INCLUDE_DIRECTORIES.

I have a fix for the upstream xwayland meson pkgconfig generation, will pull this in once its merged.

So we currently need to wait for this PR to be merged upstream, a new version is released upstream, and nixpkgs updates xwayland before we can continue this PR?

So we currently need to wait for this PR to be merged upstream, a new version is released upstream, and nixpkgs updates xwayland before we can continue this PR?

My plan is to get this merged and than fetchpatch it into nixpkgs. If I read Olivier correctly we can than remove the patch with the 24.x release.

Merging should not be needed, just use https://gitlab.freedesktop.org/xorg/xserver/-/commit/5acdc7b6bdb0722e7afd276f3ae538b6195f0baa.patch and https://gitlab.freedesktop.org/xorg/xserver/-/commit/814dd61c1b46a8a0c4a76587dd786819180f6976.patch?

Merging should not be needed, just use https://gitlab.freedesktop.org/xorg/xserver/-/commit/5acdc7b6bdb0722e7afd276f3ae538b6195f0baa.patch and https://gitlab.freedesktop.org/xorg/xserver/-/commit/814dd61c1b46a8a0c4a76587dd786819180f6976.patch?

The first commit is enough for the backport. My assumption was that this PR is still "Draft" and there is no need to fix this right now, but it appears that this is still a draft PR since Xwayland needs fixing first. #311886

https://github.com/NixOS/nixpkgs/pull/311966 which includes the 24.1.0 bump has been merged.

Please be quick. The current input focus issue almost caused me to send my login password to the NixOS group today 🫠

lets gooo

This crashes my hyprland when using it with nouveau and moving my cursor to the top of the screen.
Additionally this creates a mismatch between a cursor and its hotspots (https://github.com/hyprwm/Hyprland/issues/6117)
here the logs from one of the crashes:
May 21 18:35:14 gravitas kernel: nouveau 0000:01:00.0: .Hyprland-wrapp[13615]: fail ttm_validate
May 21 18:35:14 gravitas kernel: nouveau 0000:01:00.0: .Hyprland-wrapp[13615]: validating bo list
May 21 18:35:14 gravitas kernel: nouveau 0000:01:00.0: .Hyprland-wrapp[13615]: validate: -22
May 21 18:35:14 gravitas kernel: nouveau 0000:01:00.0: .Hyprland-wrapp[13615]: fail ttm_validate
May 21 18:35:14 gravitas kernel: nouveau 0000:01:00.0: .Hyprland-wrapp[13615]: validating bo list
May 21 18:35:14 gravitas kernel: nouveau 0000:01:00.0: .Hyprland-wrapp[13615]: validate: -22
May 21 18:35:14 gravitas kernel: nouveau 0000:01:00.0: fifo: fault 00 [READ] at 000000000f286000 engine 00 [GR] client 01 [GPC0/T1_0] reason 02 [PTE]>
May 21 18:35:14 gravitas kernel: nouveau 0000:01:00.0: fifo:000000:0004:[.Hyprland-wrapp[13615]] rc scheduled
May 21 18:35:14 gravitas kernel: nouveau 0000:01:00.0: fifo:000000: rc scheduled
May 21 18:35:14 gravitas kernel: nouveau 0000:01:00.0: gr: TRAP ch 4 [007fa10000 .Hyprland-wrapp[13615]]
May 21 18:35:14 gravitas kernel: nouveau 0000:01:00.0: gr: GPC0/TPC0/TEX: 80000049
May 21 18:35:14 gravitas kernel: nouveau 0000:01:00.0: gr: GPC0/TPC1/TEX: 80000049
May 21 18:35:14 gravitas kernel: nouveau 0000:01:00.0: gr: GPC1/TPC0/TEX: 80000049
May 21 18:35:14 gravitas kernel: nouveau 0000:01:00.0: fifo:000000:0004:0004:[.Hyprland-wrapp[13615]] errored - disabling channel
May 21 18:35:14 gravitas kernel: nouveau 0000:01:00.0: .Hyprland-wrapp[13615]: channel 4 killed!
May 21 18:35:14 gravitas systemd[1]: Started Process Core Dump (PID 18160/UID 0).

I can update hyprland again when there's a fix. Until then, either use an older nixpkgs, or use the flake package.

Not an ideal situation just a few days before the branch off.

@wuyoli I've downgraded hyprland by a few commits, can you test whether it's all working?
https://github.com/fufexan/nixpkgs/commit/7c60f015be81a848bf1eaa5353327098c53644c2

so that we can get them working right before the branch off

Can anyone shed some light on what this is about? 😄

Also, since I'm here, I just want to thank everyone involved in this! 🙏🏽
I haven't experienced any issues so far with Hyprlock, Hypridle and Pyprland scratchpads 👍🏽

Can anyone shed some light on what this is about? 😄

NixOS 24.05 will be released soon. See more about the process here.

@fufexan I cherry-picked your commit https://github.com/fufexan/nixpkgs/commit/7c60f015be81a848bf1eaa5353327098c53644c2 . this didn't work, but with https://github.com/NixOS/nixpkgs/commit/7185b4755708a7b253f13a8fbe256e14f26be9d0 everything worked again.

Great, I'll make a quick PR then.

Also, @wuyoli do screen lockers work fine? I just remembered about Flakebi's comment.

Sorry, it just crashed again, this time it wasn't obviously in connection to some action i did.
May 22 00:14:44 gravitas kernel: nouveau 0000:01:00.0: fifo: SCHED_ERROR 0a [CTXSW_TIMEOUT]
May 22 00:14:44 gravitas kernel: nouveau 0000:01:00.0: fifo:000000:0003:[.Hyprland-wrapp[6875]] rc scheduled
May 22 00:14:44 gravitas kernel: nouveau 0000:01:00.0: fifo:000000: rc scheduled
May 22 00:14:44 gravitas kernel: nouveau 0000:01:00.0: fifo:000000:0003:0003:[.Hyprland-wrapp[6875]] errored - disabling channel
May 22 00:14:44 gravitas kernel: nouveau 0000:01:00.0: .Hyprland-wrapp[6875]: channel 3 killed!
May 22 00:14:44 gravitas systemd[1]: Started Process Core Dump (PID 8056/UID 0).

The issue with the cursor hotspot is fixed though.

do screen lockers work fine?
no very much not. hyprland crashes instantly (I'm using swaylock)
(sorry I missed this comment previously)

The issue with the cursor hotspot is fixed though.

That's at least something. The crash could also be related to some kernel, nouveau, some driver or maybe also xwayland but that the cursor is so much off for high DPI is good to be fixed for 24.05.


[UNTHEMED]: channel and user list backdrops are not themed

Client Mod
BetterDiscord
Please provide screenshots of the unthemed areas.

Before Submitting

[X] I checked for similar reports of this issue.
[X] I am on the latest stable Discord version.
[X] I am on the latest version of the theme.
[X] I have reinstalled the theme.

Thank you for reporting. Discord recently pushed an update that re-rolled classes. I'll have a fix pushed soon.


404 errors in Edge and IE with dev build

For the dev build, the app returns lots of 404 for map files in IE and Edge. Works on Firefox and Chrome

@robisim74 @FabianGosebrink Any ideas what could be causing this?
Greetings Damien

Hi Damien,
I see that problem only when Task Runner builds the app (#23), because it uses "-d" and it creates inline .map file; instead it seems to work fine also in IE & Edge from the command line with npm run build:

webpack -d bug, cannot fix


Cover missing test scenario in state_directory_management.py

Description
It seems one of the test scenarios where the parent directory doesn't exist was missing from the tests for state_directory_management.py.
Areas changed

npm packages changed:

[ ] responsibleai/causality
[ ] responsibleai/core-ui
[ ] responsibleai/counterfactuals
[ ] responsibleai/dataset-explorer
[ ] responsibleai/fairness
[ ] responsibleai/interpret
[ ] responsibleai/localization
[ ] responsibleai/mlchartlib
[ ] responsibleai/model-assessment

Python packages changed:

[ ] raiwidgets
[x] responsibleai
[ ] erroranalysis
[ ] rai_core_flask

Tests

[ ] No new tests required.
[x] New tests for the added feature are part of this PR.
[ ] I validated the changes manually.

Screenshots (if appropriate):
Documentation:

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

Codecov Report

Merging #1147 (5b1e61c) into main (3906dcc) will increase coverage by 3.14%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1147      +/-   ##
==========================================
+ Coverage   89.49%   92.63%   +3.14%
==========================================
  Files          70       15      -55
  Lines        3198     1005    -2193
==========================================
- Hits         2862      931    -1931
+ Misses        336       74     -262

Flag
Coverage Δ

unittests
92.63% <ø> (+3.14%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

erroranalysis/erroranalysis/report/error_report.py
87.69% <0.00%> (-1.35%)
:arrow_down:

...ranalysis/erroranalysis/analyzer/error_analyzer.py
91.93% <0.00%> (-0.82%)
:arrow_down:

...ranalysis/erroranalysis/_internal/matrix_filter.py
95.51% <0.00%> (-0.04%)
:arrow_down:

responsibleai/responsibleai/__version__.py

responsibleai/responsibleai/_interfaces.py

...onsibleai/responsibleai/serialization_utilities.py

...sibleai/responsibleai/_tools/shared/base_result.py

.../responsibleai/modelanalysis/constants/__init__.py

...tools/counterfactual/dashboard_schemas/__init__.py

...leai/responsibleai/modelanalysis/model_analysis.py

... and 48 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3906dcc...5b1e61c. Read the comment docs.


Support file path with unicode characters

Basisu doesn't work if path contain unicode character:
> basisu "D:\TEMP\漢字\normal.png"

Basis Universal GPU Texture Compressor v1.16.3
Copyright (C) 2019-2022 Binomial LLC, All rights reserved
Using SSE 4.1: 1, Multithreading: 1, Zstandard support: 1, OpenCL: 0
Processing 1 total file(s)
Processing source file "D:\TEMP\??\normal.png"
ERROR: load_png: Failed reading file "D:\TEMP\??\normal.png"!
ERROR: Failed reading source image: D:\TEMP\??\normal.png
ERROR: Compressor failed reading a source image!

Hope this bug will be fixed soon.

Got it. Will fix.

Here are some helper functions that might work:
https://github.com/e-dant/watcher/blob/next/include/watcher/adapter/windows/watch.hpp

@richgel999 Hope this will be fixed soon. Some users of mine having problem because they have non-latin char in Windows user folder name.

Got it- I've got fixes coming. Been working on this.


token0Price and token1price from SDK do not match subgraph

I've posted this on the discord, but haven't received any acknowledement as of yet. Upon investigation, I've discovered the cause the problems described. Here's the original post that I posted on discord, and I'll add more afterward.
Original post:
I'm having trouble trying to understand some properties from the v3 subgraph.
pool.token0Price and pool.token1Price
Let me provide an example, just with necessary info, this is from the BSC graph
"token0": {
"decimals": "18"
},
"token1": {
"decimals": "18"
},
"token0Price": "0.00000000000000000000000000000000000000293895680758558494927616942086432",
"token1Price": "340256786836388081269117234195560700000",
"sqrtPrice": "1461446703485210103287273052203988822378723970341",
"tick": "887271"
}
So this is the info returned from the subgraph. Now using the javascript SDK, I created the necessary objects (two tokens, and a pool).
There are some differences in the data produced in the SDK, and that from the subgraph. Some I understand, but others not.
The SDK produces:
pool.token0Price =<PHONE_NUMBER>36388094070642339899681172762
pool.token1Price = 0.0000000000000000000000000000000000000029389568075855848387034172747685

pool.token0Price and pool.token1Price are swapped. token0Price in the SDK is token1Price from the graph, and vice versa.
The prices from the graph are to 34 significant digits. This is why there are trailing zeros for token1Price on the graph. This is necessary for numbers < 1 to limit the number of decimal places. I understand why this is the case
The prices, even when to the same significant digits, don't match.
pool.token0Price.toSignificant (34) =<PHONE_NUMBER>36388094070642339899681200000
Subgraph counterpart (token1Price) =<PHONE_NUMBER>36388081269117234195560700000

end of original post
So I'll keep this issue to the SDK problem, which is the swapping of prices. Based on the documentation for token0Price, "Returns the current mid price of the pool in terms of token0", I believe the issue is with the SDK and not the graph for this. The prices are the right way around in the subgraph, and the wrong way around in the SDK.
The remaining problems regard the subgraph, so I will open an issue there and reference this one.

I noticed this a while ago and it's indeed confusing. The way the sdk does it is consistent with the documentation though: "Returns the current mid price of the pool in terms of token1, i.e. the ratio of token0 over token1".
The v3 subgraph is not documented as far as I know so it's also not really incorrect. The price is displayed this way on the info page though.
The data from the subgraph is in general not 100% correct,  discrepancies can happen in every single datapoint. I opened an issue on the Ticks but the actual issue is (at least I think so) that the graph doesn't handle reorgs correctly so some transactions are not indexed.
I don't believe the subgraph will ever be updated. I suggest making direct onchain calls for sensitive data.


README example needs update for new embedded graphics api

it is still a 0.6 style example

Fixed with https://github.com/antonok-edm/ssd1309/commit/37439f347c7343996c4d90c4268157a2afc6a037; I just removed it altogether. It's bound to happen again in the future if it's kept there :sweat_smile:


[Editor] Allow MSDF font rendering for custom fonts, add editor setting to control it.

Fixes https://github.com/godotengine/godot/issues/95201

Thanks!


fix: select widget virtualization not rendering first top items

Description
Select widget not rendering first top items because of virtualization
Fixes #12755
Type of change

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Cypress Test

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

Test coverage results :test_tube:
:white_circle: Total coverage has not changed
// Code coverage diff between base branch:release and head branch: fix/select-widget-virtualization

Status
File
% Stmts
% Branch
% Funcs
% Lines

:green_circle:
app/client/src/widgets/SelectWidget/component/index.tsx
15.87 (0.55)
0 (0)
4.55 (0)
16.52 (0.59)

/ok-to-test sha=c7245c4

/ok-to-test sha=ebbe622

@Tooluloope Tested and LGTM.


Whyframe doesn't encapsulate the render of the component or am I crazy

I'm using Vitepress to document a component library, and when I load the scope style sheet in the component that I'm going to document, the rendering is done fine but my styles are also taken by the vitepress theme :(. I would like a isolation level where only the wiframe has those styles and it is not taken HELP PLEASE

I tell you that I tried what you mentioned, however it does not work for me. I don't know what I'm doing wrong or what's wrong hehe
Well, if it works, the styles are no longer applied to everything, but the component does not take the styles

I show you my config, if you realize use the example you have in the doc

<style scoped lang="css">
@import 'my-components/dist/resources/index.css';
</style>

I think this is the problem here. I'm assuming my-components/dist/resources/index.css contains all the styles for the component library. You should design your library to have consumers import that themselves instead, otherwise using <style> or <style scoped>, your consumers will get that CSS file duplicated many times.
So if you remove the style tag in all of your components, import that CSS in /frames/default.md instead, it should work.

I agree with you, that style sheet should not load all the css and I also thank you very much for your support, it works.


Q:Timber cache

Hi I have question about timber cache
I have following config:
define('CACHE_TIME', 86400); define('TIMBER_CACHE', true);
\Timber::$cache = TIMBER_CACHE;
each template is rendered as follow:
\Timber::render( 'pages/single/event.twig', $context, CACHE_TIME);
In DB I can see some records like

_transient_timberloader...

And each minute database grow up in 1MB
And wp_options getting huge 100-200MB then queries on wp_options are too long
What I'm doing wrong? What is the best practise for cache settings?

I have a few sites that have had cache on for a long time and all of them are around 2-3MB, are you sure it's Timber causing this?

Yes when I delete all _transient_timberloader records database reduced from approx. 100MB to 35MB

What version of Timber and wordpress are you using?

wp: 4.5.1
timber: 0.22.6

Any news about this?
I forget to mention that W3 total cache is also installed

It's hard to debug, I would try disabling w3 total cache, I can't imagine Timber does this by itself, there will something else effecting the caching system.

Any updates @ogrosko

I test it locally it works with no problems.
On live server I changed timber cache time to 5 days.

Any updates @ogrosko ? Thanks

No idea where is the problem
After few days database grows to 250MB :( And no idea where is the problem.
What about to disable timber cache?

Is this with disabling W3 cache?

I little worry to disable w3 total cache plugin on live server

Hi,
I have same problem and in my case is because my client use Google Adwords. When use go to page via PPC, then have unique param gclid in url and Timber create new cache for this page. Of course there can be another params eg. utm,...
But I don't have solution how to exclude some params to not create unique cache.
Thanks for help

@ogrosko Is this still something you're actively working on or need addressed? Please respond in two weeks or we'll close this thread


Query doesn't take into account versioned profiles in auto mode

https://github.com/GoogleCloudPlatform/bq-pii-classifier/blob/16c7f9b3fbc59d3687abcdb763d9fdc1c51e93b1/services/library/src/main/java/com/google/cloud/pso/bq_pii_classifier/services/scan/AutoDlpResultsScannerImpl.java#L100C1-L101C1
The bigquery table containing profiles will contain multiple profiles whenever the profile is updated. This fails to pick the most recent one and instead merges old data together with new.
if you query the "table" + _latest_v1 table, which is a view we provide customers we offer the most recent one, then you won't need distinct in the query and won't pull stale profiles.

Thanks @realjordanna for reporting this. The latest_v1 is the one being used (passed via Terraform). I renamed the variable to avoid confusion. This is fixed in v1.0.7.


deprecated reflect mode has been replaced with package mode

re-open of: https://github.com/uber-go/mock/pull/198
resolves https://github.com/uber-go/mock/issues/175
resolves https://github.com/uber-go/mock/issues/197
resolves https://github.com/uber-go/mock/issues/128
It is impossible to create an mock for a generic interface via reflect mode, because it is impossible to compile a generic type without instantiation.
This PR replaces the reflect mod for parsing using go/types.
All exists mocks have been regenerated and the tests have been passed. But since this radically changes the behavior of reflect mode, I would be grateful if there are those who want to add additional test cases that I did not provide.
We can also come up with another name instead of import mode.
benefits:
generation mocks for generic interfaces
generation mocks for aliases to interfaces
correct names for method arguments

@JacobOaks
What do you think about this problem?
https://github.com/uber-go/mock/pull/198#discussion_r1777459359

@tulzke - thanks for re-opening this and apologies again for the git mistakes on the other PR.
I think for now it makes sense to just use the unaliased names until we're able to update go.mod to 1.23. From the perspective of type-checking, types and their aliases are interchangeable so there shouldn't be any missing functionality/bugs introduced by just uniformly using the unaliased names for now. This also keeps the generated code consistent between the two versions. Once 1.24 is out and we can upgrade go.mod to 1.23, we can definitely then switch over to using the alias names.
I think the changes to do this aren't too bad, we would just have a separate case in parseType like so:
case *types.Alias:
    return p.parseType(types.Unalias(t))

What are your thoughts?

we would just have a separate case

I think, that alias for us is the same thing as a *types.Named. We need only his name and package.
types.Unalias(t) returns original type, so in mocks we will see original types. It is not completely correct behavior.

So, if we have agreed on the functionality, can we think about the names? What is the name of the new mode to replace reflect?
Maybe Package mode? Source mode and Package mode. That sounds good.

I don't have a strong opinion on a name. "package mode" or "types mode" is fine.

I don't have a strong opinion on a name. "package mode" or "types mode" is fine.

I choose package mode. Check last commit changes please: https://github.com/uber-go/mock/pull/207/commits/69210e9badcc1aacba501d26e5c40b3ff79de2d9
If everything is OK, i'm waiting for a merge 🙂

I realized that I had made a mistake.
I deleted 3 unused flags, and this may break the existing generation methods. Since now these flags have no effect, I think they can be removed from the readme and help, and when using write a WARNING message to the console.
@JacobOaks What do you think about this?

Hey @tulzke, for --exec_only and --prog_only, I think we can do what you're suggesting.
For build flags, what do you think about maintaining backwards compatibility and passing them to packages.Load via Config which has a BuildFlags field? My understanding is these will get passed to the go list command, which accepts normal go build flags.

Hey @tulzke, for --exec_only and --prog_only, I think we can do what you're suggesting.
For build flags, what do you think about maintaining backwards compatibility and passing them to packages.Load via Config which has a BuildFlags field? My understanding is these will get passed to the go list command, which accepts normal go build flags. This will keep things like build tags specified by --tag to be respected when deciding which Go files to load, for example.

I started developing this feature. I decided to see how it is implemented now. And there was no limit to my surprise. The flag is declared, but not used. 😁
https://github.com/search?q=repo%3Auber-go%2Fmock build_flags&type=code
https://github.com/search?q=repo%3Agolang%2Fmock build_flags&type=code

@JacobOaks
I returned support for build_flags and added additional test case for it

Hi @JacobOaks
I'm glad that PR was merged. So, when is the new release?


Fix argument value validation for ObjectValue and ListValue

Seems like we just weren't checking values of arguments thoroughly - ObjectValue and InputValue were being ignored meaning that variables in these values were also being ignored, resulting in spurious errors (as per #7).
Closes #7
@pfitzseb would you be able to review this if you have a moment? Thanks!

Codecov Report
Base: 86.62% // Head: 87.35% // Increases project coverage by +0.73% :tada:

Coverage data is based on head (83e3b98) compared to base (7ba74ac).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #8      +/-   ##
==========================================
+ Coverage   86.62%   87.35%   +0.73%
==========================================
  Files           6        6
  Lines         957      973      +16
==========================================
+ Hits          829      850      +21
+ Misses        128      123       -5

Impacted Files
Coverage Δ

src/validation.jl
98.03% <100.00%> (+0.22%)
:arrow_up:

src/parser.jl
94.12% <0.00%> (+0.80%)
:arrow_up:

src/types.jl
46.26% <0.00%> (+1.49%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Denom unit for price / denom is showing minting denom instead of the display denom

this.state.mint here is always null as it has not been set in anywhere.
https://github.com/forbole/big-dipper/blob/ddc8c8d982cd6d6c32b615bffefc0c6c9a239e15/imports/ui/accounts/Account.jsx#L246

Fixed in PR #287

That's strange because when I run the master it displays it correctly with the Staking Denom

Could you please confirm that your code  https://github.com/forbole/big-dipper/blob/master/imports/ui/accounts/Account.jsx#L337 is reading the Denom value from the Coin utility as shown below?
({numbro(this.state.price).format("$0,0.00")}/{Coin.StakingCoin.displayName})

I see. This is fixed in the latest PR #287 .


askUser conflic with namedButtons plugin

Let say we have the bellow code, where we use askUser plugin with the namedButtons. when I start the bot and click on the Start Questions which is a Named Button, it asks the What is your name? but also asks the second question as the ROBOT [4] indicates it, which as you know it is not expected.
const bot = new TeleBot({
	token: 'TOKEN',
	usePlugins: ['askUser', 'namedButtons'],
	pluginConfig: {
		namedButtons: {
			buttons: {
				start: {
					label: 'Start Questions',
					command: '/start_quenstions'
				}
			}
		}
	}
});

bot.on('/start', msg => {

	const markup = bot.keyboard([ ['Start Questions'] ], { resize: true })

	return bot.sendMessage(
		msg.from.id,
		"Would you like to start the questions?",
		{ markup }
	)
})

bot.on('/start_quenstions', msg => {

	return bot.sendMessage(msg.from.id, 'What is your name?', { ask: 'name' })
})

bot.on('ask.name', msg => {

	const name = msg.text
	return bot.sendMessage(
		msg.from.id,
		`Your name is ${name}, what about your last name?`,
		{ ask: 'last'}
	)
})

bot.on('ask.last', msg => {

	const name = msg.text
	return bot.sendMessage(
		msg.from.id,
		`Your last name is ${name}`
	)
})

bot.start()

Let's start the bot
Mehran Rasulian [1],
/start
ROBOT [1],
Would you like to start the questions?
Mehran Rasulian [2],
Start Questions
The bellow two robot messages received at the same time!!
ROBOT [3],
What is your name?
ROBOT [4],
Your name is Start Questions, what about your last name?
Mehran Rasulian [3],
Rasuli
ROBOT [5],
Your last name is Rasuli
But when we will not use the namedButton and just use a simple command, the above scenario will not happen and everything is correct.
Already continue using the command event instead of using namedButtons on the production, but please give us a quick fix for this. I tried to find a way to fix this issue but no way yet :disappointed:

Hot fix for askUser plugin:
/*
    Get direct answers from user.
*/

const userList = {};

module.exports = {

    id: 'askUser',

    plugin(bot) {

        // On every text message
        bot.on('text', (msg, props) => {

            const id = msg.chat.id;
            const ask = userList[id];

            // If no question, then it's a regular message
            if (!ask) return;

            // Delete user from list and send custom event
            delete userList[id];
            bot.event('ask.' + ask, msg, props);

        });

        // Before call sendMessage method
        bot.on('sendMessage', (args) => {

            const id = args[0];
            const opt = args[2] || {};

            const ask = opt.ask;

            // If "ask" in options, add user to list
            if (ask) userList[id] = ask;

        });

    }
};

Didn't thought it could be easier than  this to change a paramerter 😃.
But I bet it's been hard to find the bug, Good Job @mullwar 🙌.

this fix does not exist in latest version. can you please publish it.


Couple of fixes to shader compiler

PR Details

Description
This PR addresses two issues we ran into when loading a broken shader:

It was impossible to reload it due to some internal dependency not being tracked and therefor a cache not being invalidated by ResetCache calls. I added a ReferencedShaders property to keep track of them independent of the MinimalContext logic - using that one caused a weired behavior in my previous PR.
The compiler result was not deterministic when invoked a second time - a mixin was marked with error flag but the result log had no error which lead to subsequent code paths crashing as they only checked the result log.

Related Issue
https://github.com/vvvv/VL.Stride/issues/221
Types of changes

[ ] Docs change / refactoring / dependency upgrade
[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[ ] My change requires a change to the documentation.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

Thanks! (now, you probably understand why this part will need a rewrite sooner or later...)

I can imagine yes. Quite a lot of mutation going on.


PR: Add table of contents for /pages

This PR will add tables of contents to the .md files in /pages.

Fixes #725

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: AllUsernamesHaveBeenTaken sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

This is still a WIP.


[mesheryctl] Bug: system reset on stable channel breaks if no version is specified

Description

When mesheryctl system reset is run it will fetch the docker-compose.yaml file from GitHub corresponding to the channel and version specified in the current-context.
If the channel is stable and the version is not specified in the config.yaml file in the ~/.meshery folder, it will fail to pick up a valid file.
version is not specified by default when Meshery is installed.
Example config.yaml where system reset fails-
(base) user@computer:~/.meshery$ cat config.yaml
contexts:
  local:
    endpoint: http://localhost:9081
    token:
      name: Default
      location: auth.json
    platform: kubernetes
    adapters:
    - meshery-istio
    - meshery-linkerd
    - meshery-consul
    - meshery-octarine
    - meshery-nsm
    - meshery-kuma
    - meshery-cpx
    - meshery-osm
    - meshery-nginx-sm
    channel: stable #stable channel but version is not specified
current-context: local
tokens: {}

Here, system reset will try to pick up a file from fileURL = "https://raw.githubusercontent.com/layer5io/meshery/" + currVersion + "/docker-compose.yaml" (line 83 in reset.go).
Since there is no current version specified, the URL will be https://raw.githubusercontent.com/layer5io/meshery/docker-compose.yaml which is invalid.
Expected Behavior

Instead if the channel is stable and the version is not specified in the config.yaml file, it should pick up the docker-compose.yaml file from the latest release(not the edge release but the latest stable release).
May need to use GitHub API for this.

take

There he is! @aneeshnema 💪