Form fields are only considered touched when they were blurred (at least) once

🐛 Bug report
Current behavior
There is a difference in behaviour of validations between fields that have been blurred, and fields that have not. Validations do run on fields that haven't been blurred yet, but the field is only marked touched when the field loses focus, leading errors to only show up for fields that were blurred at least once.
Steps to reproduce the bug
(Not providing codesandbox, as the Reakit documentation shows the behaviour) Take the usage notes for Form, here: https://reakit.io/docs/form/#usage

Focus the name field
Add and remove a name => no error messages
Blur the name field
Focus the name field
Add and remove a name => there are now error messages

Expected behavior
Behaviour should not be different between fields that were and were not blurred once.
Possible solutions
One possibility that is applicable to my use case would be to mark fields touched when they were changed, instead of when they were blurred. That would (I believe) make behaviour of fields consistent between being blurred at least once / not being blurred.
Alternatively, touchedness can be tied to when validations run. If they run on blur, then touched can also be set onBlur, whereas if they run on change, then touched can (also) be set onChange.

FWIW: this is where fields are marked touched, which indeed only runs on blur.
Also; if we reach some consensus on how this should work, I would also like to offer to implement a solution myself. Reakit is of great help to me, so I'd like to contribute where I can!

Hi @lennartbuit! Thanks for opening the issue.
This is working as intended, and the way it works is the same as in other libraries, like Formik.
However, we can think on an option to mark fields as touched when they're updated, for example. Or something else. If you describe your use case, it may help us find a better API.

Hey there, thank you for your (swift!) response. The reason I am asking is because I abstracted the form state away (like suggested in the docs) and have sub components that use a shared context. One of these components is a submit button, I use the form state to determine whether the form can be submitted and thus enabling the submit button. However, as far as I can tell, validations only run when a change was made (this is great! don't want to show errors when people didn't do anything yet), and a form starts out valid. Therefore I am using the touchedness to determine whether it is valid because it wasn't touched yet.
The problem I am now ending up with is that in a single field form, changing a field does run the validations, but does not update the touchedness. This leads me to not be able to determine whether to enable the submit button, no fields are officially touched, and the validations succeeded, so I cannot determine a difference with the initial state.
Since you mentioned Formik, I don't have any experience with it, but I took a look at how it differs. They offer a code sandbox as well, and this example - incidentally - uses dirty to enable the reset button. The difference, however, is that their dirty checking does run on change, and compares initial state with the current.
Once more, thank you (all) for this great library!

So, just to avoid confusion, there are two concepts here: running the validation and actually showing the errors.
By default, validations run on change and on blur, and you can configure it by passing validateOnChange and validateOnBlur to useFormState(). They're true by default:
https://github.com/reakit/reakit/blob/0c51c4f3dc1ec9a83b9d915039ad8167f4e4217b/packages/reakit/src/Form/FormState.ts#L285-L286
The error is shown only after the field has been touched (on blur), so you don't show errors while the user is still typing (imagine that a field has minimum length of 3, and as soon as the user types the first letter you show them an error message 😬):
https://github.com/reakit/reakit/blob/0c51c4f3dc1ec9a83b9d915039ad8167f4e4217b/packages/reakit/src/Form/__utils/shouldShowError.ts#L8
So, validations may run and set form.valid and form.errors even when the errors aren't being displayed to the user. In order to disable the submit button when the form is invalid, you could do this:
const form = useFormState();
<FormSubmitButton {...form} disabled={!form.valid} />

Validations don't run on mount, so the button would be enabled until some form value is changed. We can add a new validateOnMount option similar to the Formik one. But this can also be achieved in the user land:
const form = useFormState();
// Guarantees that we'll only use the first version of form.validate(),
// and our effect will not run on updates
const [initialValidate] = React.useState(() => form.validate);
React.useEffect(() => {
  initialValidate().catch(() => {});
}, [initialValidate]);

Here's a CodeSandbox with dirty and validateOnMount: https://codesandbox.io/s/reakit-form-validateonmount-and-dirty-state-td8ph?file=/index.js
If they're useful, I'm totally open to adding them to the library. :)

Hey, thank you for your suggestion, works perfectly :). Here are some things I noticed while integrating them. I hope that they help in determining what to include in Reakit!

I did not end up needing dirty tracking

The reason being, a 'create' like form is (usually) not valid from the get-go. For 'update' forms, I thought it would be confusing to users that a perfectly valid form could not be submitted.
In other words, I think the value of preventing a superfluous submit is less than the confusion it creates when a perfectly valid form could not be submitted because it was not touched.

validateOnMount runs after first render, which can cause this submit button to flash.

valid is true by default, so prior to the validations running on mount, this submit button is enabled. Basically, in 'create' forms, I expect the form to not be valid initially, whereas in 'update' forms I do. I am currently remedying this by keeping track of whether validations ran, and if they didn't return a prop with the 'default' validness.
Looking at Formik, I see they have deprecated this default validness. So maybe thats something that has a prettier solution.

So, for my usecase, I'd say that validateOnMount would be helpful, but dirty tracking can be omitted!

validateOnMount runs after first render, which can cause this submit button to flash.

I guess you can get rid of that flash if you replace React.useEffect by React.useLayoutEffect.


Can someone tell what is going on in here

Why it doesn't the proper error message like specify the version
v12.22.12

On the windows installation guide I found 8 download options, how I can figure out which one is right to download?
I'm very confused

CLI could have shown some tips in case of typos
The user experience would have been much easier

Where's the uninstallation command?

Because you’re not using this project. You’re using nvm-windows, something entirely different.


alertmanager: support for reusable templates

https://prometheus.io/docs/alerting/latest/notification_examples/#defining-reusable-templates
Please correct me if I'm wrong, but I don't see any support for defining and loading these in just yet. Reusable templates are a useful feature when configuring receivers.
It seems they could be defined in a configmap or secret in gmp-public and then the operator could take care of copying to gmp-system and volume mounting into alertmanager? I'm guessing this could be similar to how this is handled by prometheus-operator https://github.com/prometheus-operator/prometheus-operator/blob/main/Documentation/user-guides/alerting.md#using-a-kubernetes-secret

Hi @nick-jones,
Yes indeed you are correct and thanks for raising this point. I think what you suggested makes sense as a potential path forward to support this.
Marking this as a feature enhancement.

@pintohutch Is this on the roadmap at all, or would you be open to contributions?
We're keen to start adopting Alertmanager as part of GMP, but not being able to handle reusable templates adds friction for us.

Hey @adamstrawson - we are absolutely open to contributions!
In general, we're de-emphasizing the managed alertmanager, preferring to recommend Cloud Alerting's promQL support.
However, we will continue to support this and will happily review any contributions.


Mails Populating db but not the inbox view

Hey,
I am sending mails from gmail to my custom domain, the script is also hosted on my server.
Now I can see the mongo db populating, but the mails do not show up when I open page. Page title count is correct, but the body does not have mails. When I click on JSON / RSS links, I can see the content, but not in html.
<EMAIL_ADDRESS>"domainname.com" is not real domain, just for reference.
Even on gmail I receive failure daemon mails. Why this is the case , when we caught mails and fed them to mongodb.

Partial Fix from pull/#12

I am also seeing this issue, thank you for submitting.
Issue #13 may explain the failure daemon mails.

I think this is something to do with simplesmtp due to its "deprecated" status?


cloudapi: If a compose hasn't succeeded, fail gracefully in the metadata handler

Currently non-success composes return 500 in the /metadata endpoint.  result.OSBuildOutput is nil in that case, and that isn't checked.
So the metadata handler shouldn't just check if a compose has finished, it should also check if it has succeeded.

Got fixed in https://github.com/osbuild/osbuild-composer/pull/1704


first commit to support modules properly in dashboard

Added module support (added only for side menu so far)
Reordered registration of configuration file, because: if (config('laraflock.dashboard.routes')) fails if no configuration file was published for the package.

Hope hear your opinion about the module part.

Going to take a look at this, if you have a demo that would be great, otherwise I'll get it setup locally to test.

I do have a demo, but it's on local vagrant and a very poor connection. You can use hyn-me/management-interface the dev-master should work, be aware it includes multi-tenant too ;p

I updated the code to match your dev-master. Waiting for tests to finish.

Any update on this?


Finish WWTP config structure

Closing this issue as there's no specifics. Will create a draft issue on the project board as a placeholder


yweather broke with new unit_system core configuration

Make sure you are running the latest version of Home Assistant before reporting an issue.
You should only file an issue if you found a bug. Feature and enhancement requests should go in the Feature Requests section of our community forum:
Home Assistant release (hass --version):
0.26.2
Python release (python3 --version):
3.4.2
Component/platform:
sensor:
platform: yweather
Description of problem:
It looks like the new unit system for metric and imperial breaks the yahoo weather component.  yweather does not work when I have unit_system defined but works when I have temperature_unit defined.
Expected:
Problem-relevant configuration.yaml entries and steps to reproduce:
  # C for Celcius, F for Fahrenheit
  temperature_unit: F
  # 'metric' for Metric System, 'imperial' for imperial system
  #unit_system: imperial

# Weather Prediction
sensor:
  platform: yweather
  woeid: 22664092
  monitored_conditions:
#   - weather
   - weather_current
#   - temp_min
#   - temp_max
#   - wind_speed
#   - pressure
#   - visibility
   - humidity
   - temperature

Traceback (if applicable):

Additional info:

Works fine here.
Also, specifying temperature_unit: F results in the same config as unit_system: imperial, so I doubt this has anything to do with it.
What kind of error are you seeing?

Works for me as well
  ...
  unit_system: metric
  ...
sensor:
  - platform: yweather
    woeid: 12891531
    forecast: 0
    monitored_conditions:
     - weather
     - temperature


demo of role variable proliferation

Example implementation of the following policies:

Roles shouldn’t rely on any external variables

Pass everything into the role

Name the variables passed in specifically with the role’s name

This is to keep role variables from conflicting with global variables

We think of calls to roles like function calls

Clearly defined interface

As far as I can see, this will be unmanageable. Roles aren't actually much like functions. Trying to define all their inputs up the stack of dependencies would be truly unwieldy. This PR takes the example of retrofitting the openshift_repos role and examines the first few steps to do so, from which you can extrapolate how the complete refactor would look.
I'd be happy to be wrong but I think this requires more thought as to what we're actually trying to achieve.

I don't think translating every global value into a local role variable is workable.
If we're trying to achieve not stomping on other role's variables, we might just agree to use role-local variables for anything the role defines to use internally, and any inputs that callers might vary at role include time.
If we're trying to achieve specifying the role 'API' in terms of tracking everything it uses in one place, I can't immediately think of anything better than a comments section in the meta/main.yml file. Obviously the implementation could drift from this so it's not great.


[BUG] vmiLatency measurement fails for delete jobs

Bug Description
When running the example kubevirt-density workload, the vmiLatency measurement will throw an error for idle-job or delete-job, but works fine for the create job type.
Output of kube-burner version
Version: 1.10.0
Git Commit: 1b9c7446fff5605724f0d8f72c38d855112e9b2a
Build Date: 2024-06-24T16:11:46Z
Go Version: go1.21.11
OS/Arch: linux amd64
Describe the bug
There is no error when the podLatency measurement is used for the jobType: delete kubevirt-density jobs
These jobs do disable the measurement collection:
VMI latency measurement not compatible with delete jobs, skipping" file="vmi_latency.go:283
However StopWatcher hits issues when the vmiLatency measurement is defined for the "delete" type.
To Reproduce
Run the example kubevirt-density workload, ex:
OBJ_REPLICAS=10  KUBECONFIG=/root/kubeconfig-test1 /root/kubevirt/kube-burner/kube-burner init  -c kubevirt-density.yml
Expected behavior
vmiLatency does not error for delete
Screenshots or output
Error messages:
time="2024-06-28 14:30:23" level=info msg="Job idle-job took 1m0s" file="job.go:196"
time="2024-06-28 14:30:23" level=info msg="Stopping measurement: vmiLatency" file="factory.go:125"
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x18 pc=0x1a948a6]

goroutine 75 [running]:
github.com/kube-burner/kube-burner/pkg/measurements/metrics.(*Watcher).StopWatcher(0x0)
	/home/runner/work/kube-burner/kube-burner/pkg/measurements/metrics/watcher.go:69 +0x86
github.com/kube-burner/kube-burner/pkg/measurements.(*vmiLatency).stop.func1()
	/home/runner/work/kube-burner/kube-burner/pkg/measurements/vmi_latency.go:386 +0x25
github.com/kube-burner/kube-burner/pkg/measurements.(*vmiLatency).stop(0x3627360?)
	/home/runner/work/kube-burner/kube-burner/pkg/measurements/vmi_latency.go:391 +0x82
github.com/kube-burner/kube-burner/pkg/measurements.Stop()
	/home/runner/work/kube-burner/kube-burner/pkg/measurements/factory.go:126 +0x148
github.com/kube-burner/kube-burner/pkg/burner.Run.func1()
	/home/runner/work/kube-burner/kube-burner/pkg/burner/job.go:199 +0x1853
created by github.com/kube-burner/kube-burner/pkg/burner.Run in goroutine 1
	/home/runner/work/kube-burner/kube-burner/pkg/burner/job.go:101 +0x634

[...]

time="2024-06-28 14:27:17" level=info msg="Job delete-job took 1m14s" file="job.go:196"
time="2024-06-28 14:27:17" level=info msg="Stopping measurement: vmiLatency" file="factory.go:125"
panic: close of closed channel

goroutine 10 [running]:
github.com/kube-burner/kube-burner/pkg/measurements/metrics.(*Watcher).StopWatcher(0xc0007a1110)
	/home/runner/work/kube-burner/kube-burner/pkg/measurements/metrics/watcher.go:73 +0xfe
github.com/kube-burner/kube-burner/pkg/measurements.(*vmiLatency).stop.func1()
	/home/runner/work/kube-burner/kube-burner/pkg/measurements/vmi_latency.go:386 +0x25
github.com/kube-burner/kube-burner/pkg/measurements.(*vmiLatency).stop(0x3627360?)
	/home/runner/work/kube-burner/kube-burner/pkg/measurements/vmi_latency.go:391 +0x82
github.com/kube-burner/kube-burner/pkg/measurements.Stop()
	/home/runner/work/kube-burner/kube-burner/pkg/measurements/factory.go:126 +0x148
github.com/kube-burner/kube-burner/pkg/burner.Run.func1()
	/home/runner/work/kube-burner/kube-burner/pkg/burner/job.go:199 +0x1853
created by github.com/kube-burner/kube-burner/pkg/burner.Run in goroutine 1
	/home/runner/work/kube-burner/kube-burner/pkg/burner/job.go:101 +0x634`

Hey @jeniferh , thanks for opening this issue, glad to see there's some interest in the integration of kube-burner with kubevirt, it hasn't been upated in a while, so more issues are possible :(
I think I've found the issue and had pushed the fix in https://github.com/kube-burner/kube-burner/pull/659, I don't have a cluster with virtualization handy, can you help me to test the fix works correctly?
Thanks!

Yeah I am running some VM+PVC workloads, its great to be able to standardize on kube-burner to compare the API load vs other workloads types like cluster-density-v2.
Thanks for such a quick turnaround @rsevilla87! I tested your PR and the vmiLatency measurement now works fine for delete jobs w/ that fix:
time="2024-07-01 17:04:39" level=info msg="Job delete-job took 5m14s" file="job.go:196"
time="2024-07-01 17:04:39" level=info msg="Stopping measurement: vmiLatency" file="factory.go:125"
time="2024-07-01 17:04:39" level=info msg="Indexing collected data from measurement: vmiLatency" file="factory.go:137"

Great, we'll try to merge the PR and cut a new release asap


Multi-GPU training

There is something wrong with multi-gpu training, I'm wondering if it supports multi-gpu training now? if you need the debug info in the pic, let me know.

It seems something wrong with my code, I'll check for it


Add stackoverflow flag on readme

José is going to create a tag for us :)
So just as a reminder: https://stackoverflow.com/questions/tagged/ipycytoscape
We can add this

Hi there, it will take a while still:
https://stackoverflow.com/help/privileges/create-tags
I don't have enough points yet. I thought with 1000 its enough but :-(

I'm also a bit short of the required 1500. Is it possible to watch SO for a specific term anyway? I see y'all have been active asking + answering questions already! Did you just regularly search SO for ipycytoscape or do something fancier?

I just look for "ipycytoscape" particular problem/solution/tutorial ... having a tag in stack overflow helps above all to follow the tag.

Yeah, after shortly using stackover flow as an active user I have to say I really disliked their community and rules, most of my interactions were very unpleasent.
I think it's good to have it as an option, but I'll make it clear on the README that people should feel comfortable to ask questions either here or in the Gitter channel.

Can be closed?

Can be closed?

Yes! Thanks!

Yes! Thanks!


Node2D::set_scale hack to prevent 0 scale should be reviewed

Godot version:
3.2 master (087ffc8b)
Node2D::set_scale() has a hack to prevent setting the scale to 0, which would lead to some errors being raised, likely in various places (to be defined), but at least in Transform2D::affine_invert.
https://github.com/godotengine/godot/blob/087ffc8b5aafafba8fbb17d0689c0ceb88baa27a/scene/2d/node_2d.cpp#L175-L180
https://github.com/godotengine/godot/blob/087ffc8b5aafafba8fbb17d0689c0ceb88baa27a/core/math/transform_2d.cpp#L47-L53
The Node2D hack was added back in 2014 in ed6d9463d26, but without explanations.
With #35073, I applied the same logic for Control::set_scale and Light2D::set_texture_scale to avoid similar errors in affine_invert.
As discussed with @reduz, we should review this code for 4.0 and hopefully do away with the hack, and instead ensure that we can properly support a scale of 0 without errors. If anything, the hack could be moved downstream so that only the transform is affected but not the scale property.
BTW Spatial should in theory suffer from similar issues but seems not to (or no longer to, there used to be bug reports about 3D nodes too), so it might have been fixed differently there.

I had a look at this issue and when removing the hack, the first place, that shows problems, is the CanvasItemEditor.
In order to remove the hack, I used the following patch (the CRASH hepled me to identify problematic areas):
diff --git a/core/math/transform_2d.cpp b/core/math/transform_2d.cpp
index 548a82d254..53e489de65 100644
--- a/core/math/transform_2d.cpp
+++ b/core/math/transform_2d.cpp
@@ -47,6 +47,7 @@ Transform2D Transform2D::inverse() const {

 void Transform2D::affine_invert() {
        real_t det = basis_determinant();
+       CRASH_COND(Math::is_zero_approx(det));
 #ifdef MATH_CHECKS
        ERR_FAIL_COND(det == 0);
 #endif
diff --git a/scene/2d/node_2d.cpp b/scene/2d/node_2d.cpp
index 2518069b78..da67695b0e 100644
--- a/scene/2d/node_2d.cpp
+++ b/scene/2d/node_2d.cpp
@@ -161,12 +161,14 @@ void Node2D::set_scale(const Size2 &p_scale) {
        }
        scale = p_scale;
        // Avoid having 0 scale values, can lead to errors in physics and rendering.
+#if 0
        if (Math::is_zero_approx(scale.x)) {
                scale.x = CMP_EPSILON;
        }
        if (Math::is_zero_approx(scale.y)) {
                scale.y = CMP_EPSILON;
        }
+#endif // 0
        _update_transform();
 }

This change causes several crashes in CanvasItemEditor and most of them can be circumvented by testing, if the matrix can be inverted before applying affine_inverse.
One function, for which no trivial solution exists, is Node2D::_edit_set_rect:
https://github.com/godotengine/godot/blob/3bd74cd67bfc5484b3f5d4b47da66c55457474c7/scene/2d/node_2d.cpp#L107
This line works under the assumption, that Node2D.scale is never 0.
Rewriting the _edit_set_rect-algorithm, so that it doesn't depend on the previous scale-value turned out to be much more complex, than I anticipated at first.
My approach was to change _edit_set_rect, so that it expects its parameter not in local coordinates, but in parent coordinates, but after some experimentation I hit a dead-end, so I leave a note here about one identified problem, which has to be solved in order to fix this issue.
For reference, my work: https://github.com/Sauermann/godot/tree/wip-zerodet-canvasitemeditor.

BTW Spatial should in theory suffer from similar issues but seems not to (or no longer to, there used to be bug reports about 3D nodes too), so it might have been fixed differently there.

I was able to confirm that 3D also suffers from the same problem by scaling 3D-objects to 0, which resulted in error-messages in the output.

Its very difficult to remove this, because you always expect to be able to invert those for different reasons (canvas item editor, remote transform, physics, etc) and having one axis zeroed totally messes that up. I think its fine it stays.


Update parsing of Kamereon vehicle details

Add parsing of vehicle details:

get_registration_number
get_energy_code
get_brand_label
get_model_label

Regarding checking for None => Addressed in PR #68 : https://github.com/hacf-fr/renault-api/pull/68/commits/68b32960dd37f3f8dabcb8139b91595dba78a892


Introduce SecurePinCollector interface

What

Why

Test Plan

✅ | ❌ I've added unit tests for this change.
✅ | ❌ The reviewer should manually test the changes in this PR.

Demo

How

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#256
#255  👈
#254
#253
#252
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @devinmorgan and the rest of your teammates on  Graphite

Merge activity

Jun 17, 11:10 AM EDT: Graphite rebased this pull request after merging its parent, because this pull request is set to merge when ready.


Still maintained ?

The last commit is was more than a year ago, is this project still maintained or have you find a better alternative ?

Hi @QuentinN42, this project is in stasis at the moment, as the SysML v2 spec is currently under pre-release. I'd check back in 6 months or so.

Looks like SysML v2 has been released.

@russkel - I can't seem to find the v2 release. Do you have a link?
I checked:

https://github.com/Systems-Modeling/SysML-v2-Release/releases/tag/2022-08 - just showing as a normal monthly pre-release.
https://www.omgsysml.org/index.htm - I don't see a release announcement.
https://www.omgsysml.org/specifications.htm - still showing v1.5

Sorry @donpellegrino - I followed the link from LinkedIn thinking it was final release. Disregard.

Hi @donpellegrino @russkel @QuentinN42 apologies for the long inactivity on this repo; I think I may circle back to this project once the SysML v2 spec has a means of file-based model interchange, which to my knowledge is still a WIP. As far as the contents of the SysML v2 spec release, I would refer to the intro/training material for the graphical & textual notation:

Intro to the SysML v2 Language-Graphical Notation.pdf
Intro to the SysML v2 Language-Textual Notation.pdf

@capsulecorplab - I thought XMI was the official model interchange and they manifest as XML files. Many SysML modeling tools input/output XML files that use XMI to describe the SysML model data. I perceive there are multiple issues out in the wild with incompatibilities, but that is the conventional approach. A native Python data model for SysML would presumably need a persistence framework that inputs/outputs the XMI encoding.

@donpellegrino I believe the XMI format is for SysML v1, not v2. There's been discussion of a JSON schema for persisting file-based SysML v2 models, but I haven't seen it in a release.

@capsulecorplab - Ah, I see. Thanks. To confirm, the sysml.py persistence target would be whatever the format is used for the "*.sysml" files found at https://github.com/Systems-Modeling/SysML-v2-Release/tree/master/sysml/src/examples ?

@capsulecorplab - Ah, I see. Thanks. To confirm, the sysml.py persistence target would be whatever the format is used for the "*.sysml" files found at https://github.com/Systems-Modeling/SysML-v2-Release/tree/master/sysml/src/examples ?

That was the intent when I first started this project before realizing there was no such interchange format for SysML v2 yet. I considered implementing a kind of yaml-based file interchange format for this project, but later decided to drop that idea on the basis that I'd prefer to leave the standards/spec writing work up to industry professionals / working groups :wink:

@donpellegrino depending on your modeling needs, if you're looking for an open-source modeling tool that supports file-based model interchange and don't mind working natively in text, there's also the OML/OpenCAESAR toolchain that maps to OWL. It's got a bit of overhead to setup though, as you need to build the model as an RDF database that you then run queries against to extract views from the model, but it works https://github.com/modelware/oml-tutorial


hideUserInputOnNoneTextInput with input type="file" failure

Hi,
I have hideUserInputOnNoneTextInput enabled on my form.
But when arriving at the input type="file" the choose file button disappears (because it is not a type="text" of course).
This means you can not select a file and thus not continue...
A solution, I think, might be to only involve any input type that NOT text OR file.
Any other suggestions are welcome of course.
Thanks,
Tim

@TimTdev hopefully better late then never. A fix for this will be released in a few days.

This has been fixed in latest 0.9.90 release.


use <user.code_libraries> in Rust not working

I believe there is an error in the code for rust.talon below
use <user.code_libraries>:
    user.code_insert_library(code_libraries, "")
    key(semicolon enter)

I am on the latest beta version  and the word semicolon  is not a valid input to the key function.  However ';'  is. So key(; enter)   fixes this for me at least.
2022-05-30 14:59:23 ERROR     8: talon/scripting/talon_script.py:589|
    7: talon/scripting/talon_script.py:331|
    6: talon/scripting/talon_script.py:556|
    5:      talon/scripting/actions.py:85 |
    4:        talon/scripting/types.py:411|
    3:           talon/plugins/main.py:59 |
    2:             talon/linux/ctrl.py:225|
    1:             talon/linux/ctrl.py:209|
ValueError: unknown key: 'semicolon'

In addition to the syntax error, there seems to be an error with how user.code_insert_library(code_libraries, "")  is updating the tags.
2022-05-30 14:58:31 ERROR     7:              talon/scripting/talon_script.py:589|
    6:              talon/scripting/talon_script.py:297|
    5:              talon/scripting/talon_script.py:556|
    4:                   talon/scripting/actions.py:85 |
    3:                     talon/scripting/types.py:411|
    2: user/knausj_talon/lang/tags/libraries_gui.py:33 | update_library_list_and_freeze()
    1: user/knausj_talon/lang/tags/libraries_gui.py:75 | ctx.tags.add("user.code_libraries_gui_showing")
AttributeError: 'frozenset' object has no attribute 'add'

I think #911 should fix the first part. The second part is a result of #819.

I think we should prob wait for #911 (and also #819?) before closing this one


More compose

Description

Allow for docker compose to be used in more commands, removing extra hardcoded arguments.
Remove docker-compose container_names, allowing for multiple compose projects to be running at once.
Simplify the browser test docker-compose file to mostly inherit from the base docker-compose file
Allow dev, unit test, and browser tests to run at the same time locally
Rename bin/dump-dev-program-config -> bin/dev-dump-program-config and allow specifying file name for dumping

Checklist

[x] Ran the affected scripts

Issue(s)

Sorry, need to re-get reviews, since I rebased to master!


The Getting Started document could be updated for .NET 8

Doc Update Suggestion
A little while ago I migrated my project to dotnet 8 and I noticed that the Getting Started documentation is a little outdated, for example:

A namespace is being declared in the Program class
The Program class is being declared
The Program class is implementing the Main method
Not using WebApplication.CreateBuilder

Not that these points are serious problems, but I believe that the documentation could be updated.
During the migration I I implemented my Main class a little differently and published this article on medium to demonstrate my approach.
I am willing to make a PR if you fine folks think this kind of changes is welcome.

Hi Matheus!
Welcome to Ocelot world! 🐯
Nice article! Thanks you!
Have you posted this article to LinkedIn network?

Not that these points are serious problems, but I believe that the documentation could be updated.

Not serious! It could be, because we support .NET 6+ only since November'23.
Have you ever thought in terms of backward compatibility?
This old, legacy Program.Main startup approach is supported by .NET 6+ SDKs also...
But Yes, because .NET 6+ app can have implicit entry point aka Top-level statements so it  makes sense to upgrade the docs and samples apps.
I you have intention to contribute, I would ask you update all samples apps too... 🆗 ❔

Hello Raman!
Thank you!

Have you posted this article to LinkedIn network?

No, I have not, only on medium.

Have you ever thought in terms of backward compatibility?

Thinking about backwards compatibility, I don't think it will be a problem because we don't need to apply everything in the article and almost everything in it works in dotnet 6.

If you have intention to contribute, I would ask you update all samples apps too... 🆗 ❔

Ok, I'll update the samples apps and the getting started doc.
Can you create a new branch for me so I can work on it?

@MatheusXavier you should fork the repo, then create your own branch in the forked repo. When you are ready, you can from there create a PR.

@MatheusXavier As @ggnaegi said, you have to fork Ocelot repo and create feature branch in your forked repo.
More about our development process: Release Process

Three months have passed!..
@MatheusXavier, where are you?
You need to update your develop branch to be identical to head repo one! Not it has the diff. The diff must be zero, no changes at all.
Also I see the feature branch: 1912-update-docs-and-apps-samples
But it has no much changes, very initial development.
Why did you stop development on Jan 13?
What's your plan of delivery?

You have the right to reopen this issue in the future if you come with a PR ready.

@MatheusXavier Hello Matheus!
How have you been in 2024? Have you written articles on Medium blogs related to Ocelot? 😉 I have an idea to publish them in Discussions Show and Tell articles, as we currently do not have a dedicated Ocelot blog.

Thinking about backwards compatibility, I don't think it will be a problem because we don't need to apply everything in the article and almost everything in it works in dotnet 6.

Please note that we have discontinued support for .NET 6 and 7 and we are now migrating Ocelot to .NET 9, with .NET 8 as the major LTS version. Consequently, your issue opened on January 9 has become highly relevant. It appears we need to address the ticket and move it into active progress. Are you still with Ocelot and able to assist us?

@MatheusXavier commented on Jan 9, 2024

I am willing to make a PR if you fine folks think this kind of changes is welcome.

An entire year has passed 🤔  What is a PR number? 🙉

Hi @raman-m
Unfortunately I didn't have time to implement that, I also switch between job and now I'm not working with Ocelot anymore, thank you for all support but I'm going to close this issue.

Updating samples is required!


Last page is empty

I have 21 ships in Orbis. 10 on pages 1 & 2, & one ship on page 3, and there is a page 4 shown but it's empty.
Delete one ship and I now have 3 pages listed and the third page is empty.

This is fixed now.


update changelog for 2.15.0 release

Add date to 2.15.0 changelog section to start the release process.

Closing and reopening to retrigger docs build that suddenly failed.


Support units of 1

Pull Request Checklist:

[x] This PR addresses an already opened issue (for bug fixes / features)

This PR fixes #452

[x] Tests for the changes have been added (for bug fixes / features)
[ ] Documentation has been added / updated (for bug fixes / features)
[ ] HISTORY.rst has been updated (with summary of main changes)
[ ] bumpversion (minor / major / patch) has been called on this branch
[ ] Tags have been pushed (git push --tags)

What kind of change does this PR introduce?
Support units of 1.

Does this PR introduce a breaking change?
No

Other information:
Probably needs testing for conversion from pint back to netcdf.

Pull Request Test Coverage Report for Build 1869

2 of 2 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.01%) to 76.398%

Totals

Change from base Build 1865:
0.01%

Covered Lines:
2486

Relevant Lines:
3254

💛  - Coveralls

Seems good.

@huard think you could push a change to the History.rst? This should be noted there.


Question: Null Safety Support?

Please Update your project to null safety.

Version 2 supports null safety.
https://github.com/iamriajul/adhan-dart/tree/v2

Installation: https://pub.dev/packages/adhan/versions/2.0.0-nullsafety.2


fix travis-ci scripts.

delete jdk12,13,14,ea because java 1.6 is not supported on such jdks.

now the travis-ci script is correct.
but this project fails tests on jdk11.
so I guess this is not my fault anyway.
you can choose either delete jdk11 or fix that bug .


Return absolute instead of relative URLs

URLs returned by the notebook service api should be absolute, i.e. include the host name.
...
url: "/jupyterhub/user/cramakri/cramakri-weather-2d-9789210/"

should become
'''
url: "https://renkulab.io/jupyterhub/user/cramakri/cramakri-weather-2d-9789210/"

such that the UI can open that URL directly when opening a notebook server tab for the user.

Leaving this open, but will not work on it until we start to rework the API

I would like to increase the priority for this one. Once this issue is resolved, the UI does not need to be aware anymore of the Jupyterhub URL and depends on the gateway only. This will also make the helm charts less entangled.


Add support for OracleLinux

OracleLinux is similar to RedHat and CentOS, we can just add its name to the list.
I have successfully installed kubernetes on my virtual machines which run OracleLinux.
However, I did notice a minor difference: OracleLinux does not provide epel-release package, so if epel_enabled is set to true, you'll get errors. In my tests, I installed epel on all servers before running kubespray playbook.

https://github.com/kubernetes-incubator/kubespray/pull/2968
@trentzhou   duplicate.

/assign @ant31   Support OracleLinux for kubespray. we need  to support ci test on gce?

/assign @ant31
Support OracleLinux for kubespray. we need to support ci test on gce?

#2968
@trentzhou duplicate.

Good to know that this topic is already being processed. You can close my pull request then.

Closing this pull request because it duplicates with https://github.com/kubernetes-incubator/kubespray/pull/2968


Tabs improvements

Hi! I made a couple little improvements to the tabs so it's a bit closer to other browsers 😄  :

Add middle-click to close tab
Add "Reopen Closed Tab" to tab context menu

Awesome! 👍  Great PR

👌


Persist thumbnail setting

I can switch to small thumbnails and it takes effect when I display photos, but immediately after reloading the page in the browser (F5 in Firefox), they are big again and the setting in the settings panel also is back to "big".

We do not have a field for that in the database, and we also need an API interface for that.

We do not have a field for that in the database, and we also need an API interface for that.

This setting does not exist anymore.


After Sample Edit, Ask For FFQ

Fix #51
New page after editing sample info asks user if they want to take ffq (unless they already took it)
Based on issue info, may need to merge in some tooltip functionality once tooltip goes in.

Great!!


Implementation of Canny and Sobel Edge Detection Technique

Hello! I am a GSSOC'21 participant and I would like to implement the Canny and Sobel Edge Detection Technique from scratch. Please assign me the issue.

Already assigned to someone else. Please look at #5.


Fix problems introduced by #58 & #61

I find there has a problem in #61(/sockets/sockets_windows)
/sockets/sockets_windows no longer need to declare dialer
(sorry my English is poor, Translate to google translate)

thanks but closing in favor pf #61


Windows version refuses to work under Wine

https://github.com/directvt/vtm/releases/latest/download/vtm_windows_x86.zip
$ wine --version
wine-9.0 (Ubuntu 9.0~repack-4build3)

$ wine ./vtm.exe -r term
0088:err:system:NtUserChangeDisplaySettings Changing L"\\\\.\\DISPLAY1" display settings returned -2.
0088:err:explorer:initialize_display_settings Failed to initialize registry display settings for L"\\\\.\\DISPLAY1".

$ cat /etc/lsb-release
DISTRIB_ID=LinuxMint
DISTRIB_RELEASE=22
DISTRIB_CODENAME=wilma
DISTRIB_DESCRIPTION="Linux Mint 22 Wilma"

Thanks for the report. Could you try running vtm with the specified shell?
wine ./vtm.exe -r term cmd.exe

PS: I don't know how much this is allowed in Wine and what environment it has.

ERROR_INVALID_HANDLE

6 (0x6)

The handle is invalid.

Most likely it won't work. Apparently the Console Server is implemented there somehow differently than in the real Windows system. I use an undocumented API there.

Thanks for the report. Could you try running vtm with the specified shell?

Of all the options that are currently available, probably only the following will work in that environment, but only as a demo:
wine ./vtm -r test

Looking at the Wine source, it seems that a number of necessary APIs are not implemented there.

ntdll.spec:@ stub CsrClientCallServer

win32u.spec:@ stub NtUserConsoleControl

Maybe someday I'll come up with a workaround for this.


DirectReportsGroupAutoCreationEnabled

-DirectReportsGroupAutoCreationEnabled
$true: The automatic creation of direct report Office 365 groups is enabled. This is the default value.
I believe the default value was $true at a previous point, but that changed a couple years back when we stopped the update for automatic creation of these groups.  The Default value is $false in my O365 tenant.  Please correct documentation for this parameter.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9e3ab3f0-cc05-e279-8876-6da0b323bcac
Version Independent ID: bfb49814-d60b-564a-25cc-f902dfa42b10
Content: Set-OrganizationConfig (exchange)
Content Source: exchange/exchange-ps/exchange/organization/Set-OrganizationConfig.md
Service: exchange-powershell
GitHub Login: @chrisda
Microsoft Alias: chrisda

@officedocsbot assign @yogkumgit

@ernelso, confirmed and topic updated to $false as the default value.


Implementation of Nextjs Api streaming

The response from ai is being served through nextjs api routes. By taking reference from nextjs docs need to implement the streaming of texts.

Hello  @subhadip001 , if this issue is till open,  can you assign it to me ??

hey @Saurav017 sure you can implement this, also i have open another issue check that once also


Get rid of detector type string

following https://github.com/DiamondLightSource/hyperion/pull/1284 and #1277 we can just use the DetectorSizeConstants and forget about the string field in the params.

This can change based on ROI mode
The validator needs to look at whether we're in the ROI mode or not then use the correct type for it


Added GrafanaLabs.GrafanaOSS version <IP_ADDRESS>

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[x] Does your manifest conform to the 1.0 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

Duplicate of #24321?

2 different versions, 8.1.0 (<IP_ADDRESS> in ARP) and 8.1.1 (<IP_ADDRESS> in ARP)


The result of sendmsg_func are sent_bytes and not returned

https://github.com/real-logic/aeron/blob/dbf92ebcf51361b66b1edc386b22ca056266619d/aeron-driver/src/main/c/media/aeron_receive_channel_endpoint.c#L189-L202
The result sent_bytes of
destination->data_paths->sendmsg_func(destination->data_paths, &destination->transport, msghdr)
are not returned.

That is correct. The send bytes do not increment on the Receiver. Thus we only need to catch errors. We do it this way so that if we decide to change later, we won't need to change the transport bindings.

gocha

For porting to new system, I have to moving os related things down into C file but not in header files.
There is too much confliction when include OS header in C header files. That's why I refactoring struct mmsghdr down into aeron_udp_channel_transport.c, and do not expose everywhere. I've already did the same thing for fileutil and atomic.


Fix security vulnerability in nexus-react

From @mdupont on October 10, 2018 15:31
atob subdependency of svg-react-loader is vulnerable, but svg-react-loader hasn't been updated in a year. Either replace it or find a workaround to update atob.
Copied from original issue: BlueBrain/nexus-webapp-commons#18

Package deprecated.


getTextBlocks() got an unexpected keyword argument 'images'

I have packaged termpdf for my distrib and am playing a bit with it.
When pressing 'c' (crop), termpdf crashes with:
                                                                                File "/nix/store/3nk3v48b1nn1kb0q1ys9xskn7s6jkm7v-termpdf.py-2019-09-30/bin/.termpdf.py-wrapped", line 1479, in view
                                                                                doc.display_page(bar,doc.page)
                                                                                File "/nix/store/3nk3v48b1nn1kb0q1ys9xskn7s6jkm7v-termpdf.py-2019-09-30/bin/.termpdf.py-wrapped", line 600, in display_page
                                                                                crop = self.auto_crop(page)
                                                                                File "/nix/store/3nk3v48b1nn1kb0q1ys9xskn7s6jkm7v-termpdf.py-2019-09-30/bin/.termpdf.py-wrapped", line 580, in auto_crop
                                                                                blocks = page.getTextBlocks(images=True)
                                                                                TypeError: getTextBlocks() got an unexpected keyword argument 'images'

Looks like pymupdf removed support for the images flag in the getTextBlocks() function. I just pushed a quick fix:  9e5ee6d4ebfd16343c231762c2ccd2beb8831847  But this will have the bad consequence that images are ignored when autocropping!

Wait, @teto, are you using Linux? I can't get termpdf.py to work on my Arch Linux system, see https://github.com/dsanson/termpdf.py/issues/2.  If you're running linux, it's probably just a dependency problem on my part.

@rien333 yes I am on linux, you can have a look at my package https://github.com/NixOS/nixpkgs/pull/69637/files to see the dependencies I use. I know at least one person using termpdf.py on arch so that must be sthg in your config. Try reinstalling with the new setup.py (it used to lack dependencies).

(python-)dependencies don't seem to be the issue, but it's a bug that might be specific to kitty, see #2. What version of kitty are you running @teto ?

0.14.3

FWIW, @rien333, I am using fish, though I am on a Mac.


SA1102 reports lines with comments. Code fix removes them.

I think this is not a bug. StyleCop Classic flags this with SA1102 as well.
This could be an enhancement, but it will need discussion.

@vweijsters The bug here is that the code fix removes the comment, not that a violation is reported.

Interesting. Under what conditions should the code fix not be offered? I'm guessing when anything but whitespace trivia and end-of-line trivia is present, but I'm not sure.

After some further thought I think this is not a bug.
The comment is correctly flagged as a violation and therefore it is logical that the code fix would remove it. If the comment should be preserved, the rule should be changed to not flag the comment at all in my opinion.

I was not expecting this behavior when I ran the "fix all occurrences in solution" from another file. I only caught this by being vigilant when staging changes (I do it hunk-by-hunk, typically).
I can see this causing some real grief.

Fair point. I think it would make sense to not produce violations for comments at all.

Another option would be changing // to ////. And that makes complete sense for this example... not sure about other cases though.


frida-tools: use fetchPypi from top-level

Description of changes
According to the release notes fetchPypi should be taken from the top-level now.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Before this commit eval is broken:

      error:
       … while querying the derivation named 'frida-tools-12.1.2'

       … while evaluating the attribute 'out.outPath'

         at /home/tobim/.cache/nixpkgs-review/pr-236795-2/nixpkgs/lib/customisation.nix:215:13:

          214|             drvPath = assert condition; drv.${outputName}.drvPath;
          215|             outPath = assert condition; drv.${outputName}.outPath;
             |             ^
          216|           } //

       … while calling the 'getAttr' builtin

         at //builtin/derivation.nix:19:19: (source not available)

       … while calling the 'derivationStrict' builtin

         at //builtin/derivation.nix:9:12: (source not available)

       … while evaluating derivation 'frida-tools-12.1.2'
         whose name attribute is located at /home/tobim/.cache/nixpkgs-review/pr-236795-2/nixpkgs/pkgs/stdenv/generic/make-derivation.nix:303:7

       … while evaluating attribute 'nativeBuildInputs' of derivation 'frida-tools-12.1.2'

         at /home/tobim/.cache/nixpkgs-review/pr-236795-2/nixpkgs/pkgs/stdenv/generic/make-derivation.nix:347:7:

          346|       depsBuildBuild              = lib.elemAt (lib.elemAt dependencies 0) 0;
          347|       nativeBuildInputs           = lib.elemAt (lib.elemAt dependencies 0) 1;
             |       ^
          348|       depsBuildTarget             = lib.elemAt (lib.elemAt dependencies 0) 2;

       … while calling 'chooseDevOutputs'

         at /home/tobim/.cache/nixpkgs-review/pr-236795-2/nixpkgs/lib/attrsets.nix:959:5:

          958|     # List of packages to pick `dev` outputs from
          959|     drvs:
             |     ^
          960|     builtins.map getDev drvs;

       … from call site

         at /home/tobim/.cache/nixpkgs-review/pr-236795-2/nixpkgs/pkgs/stdenv/generic/make-derivation.nix:244:51:

          243|       (map (drv: drv.__spliced.buildBuild or drv) (checkDependencyList "depsBuildBuild" depsBuildBuild))
          244|       (map (drv: drv.__spliced.buildHost or drv) (checkDependencyList "nativeBuildInputs" nativeBuildInputs'))
             |                                                   ^
          245|       (map (drv: drv.__spliced.buildTarget or drv) (checkDependencyList "depsBuildTarget" depsBuildTarget))

       … while calling 'checkDependencyList''

         at /home/tobim/.cache/nixpkgs-review/pr-236795-2/nixpkgs/pkgs/stdenv/generic/make-derivation.nix:216:43:

          215|   checkDependencyList = checkDependencyList' [];
          216|   checkDependencyList' = positions: name: deps: lib.flip lib.imap1 deps (index: dep:
             |                                           ^
          217|     if lib.isDerivation dep || dep == null || builtins.typeOf dep == "string" || builtins.typeOf dep == "path" then dep

       … from call site

         at /home/tobim/.cache/nixpkgs-review/pr-236795-2/nixpkgs/pkgs/stdenv/generic/make-derivation.nix:216:49:

          215|   checkDependencyList = checkDependencyList' [];
          216|   checkDependencyList' = positions: name: deps: lib.flip lib.imap1 deps (index: dep:
             |                                                 ^
          217|     if lib.isDerivation dep || dep == null || builtins.typeOf dep == "string" || builtins.typeOf dep == "path" then dep

       … while calling 'flip'

         at /home/tobim/.cache/nixpkgs-review/pr-236795-2/nixpkgs/lib/trivial.nix:138:16:

          137|   */
          138|   flip = f: a: b: f b a;
             |                ^
          139|

       … from call site

         at /home/tobim/.cache/nixpkgs-review/pr-236795-2/nixpkgs/lib/trivial.nix:138:19:

          137|   */
          138|   flip = f: a: b: f b a;
             |                   ^
          139|

       … while calling 'imap1'

         at /home/tobim/.cache/nixpkgs-review/pr-236795-2/nixpkgs/lib/lists.nix:117:14:

          116|   */
          117|   imap1 = f: list: genList (n: f (n + 1) (elemAt list n)) (length list);
             |              ^
          118|

       … from call site

         at /home/tobim/.cache/nixpkgs-review/pr-236795-2/nixpkgs/pkgs/development/interpreters/python/mk-python-derivation.nix:181:10:

          180|       pythonRemoveBinBytecodeHook
          181|     ] ++ lib.optionals (lib.hasSuffix "zip" (attrs.src.name or "")) [
             |          ^
          182|       unzip

       … while calling 'optionals'

         at /home/tobim/.cache/nixpkgs-review/pr-236795-2/nixpkgs/lib/lists.nix:301:5:

          300|     # List to return if condition is true
          301|     elems: if cond then elems else [];
             |     ^
          302|

       … from call site

         at /home/tobim/.cache/nixpkgs-review/pr-236795-2/nixpkgs/pkgs/development/interpreters/python/mk-python-derivation.nix:181:25:

          180|       pythonRemoveBinBytecodeHook
          181|     ] ++ lib.optionals (lib.hasSuffix "zip" (attrs.src.name or "")) [
             |                         ^
          182|       unzip

       … while calling 'hasSuffix'

         at /home/tobim/.cache/nixpkgs-review/pr-236795-2/nixpkgs/lib/strings.nix:284:5:

          283|     # Input string
          284|     content:
             |     ^
          285|     let

       … from call site

         at /home/tobim/.cache/nixpkgs-review/pr-236795-2/nixpkgs/lib/strings.nix:291:5:

          290|     # to strings and comparing. This was surprising and confusing.
          291|     warnIf
             |     ^
          292|       (isPath suffix)

       … while calling anonymous lambda

         at /home/tobim/.cache/nixpkgs-review/pr-236795-2/nixpkgs/lib/trivial.nix:357:50:

          356|   */
          357|   warnIf = cond: msg: if cond then warn msg else x: x;
             |                                                  ^
          358|

       error: attribute 'fetchPypi' missing

       at /home/tobim/.cache/nixpkgs-review/pr-236795-2/nixpkgs/pkgs/tools/security/frida-tools/default.nix:7:9:

            6|
            7|   src = python3.pkgs.fetchPypi {
             |         ^
            8|     inherit pname version;


Teamcity

Small configurations for TeamCity compatibility:
Checkout the new status notification on the checks

removing --ram 7 argument on shovill
pipeline output directories automatically generated during install

removing --rm 7 for shovill is I think fine, but this https://app.circleci.com/pipelines/github/APHA-BAC/NextflowSerotypingPipeline/608/workflows/a72666fd-c513-40ff-b8f0-fc5fa821390b/jobs/1509 did not work (same for all four isolates)?

Good Catch - the TeamCity ones all passed though, which is great!

I've cancelled the TeamCity build for this edit, as we are running out of credits and I just changed the circleci config which doesnt affect

Also, just added a build passing badge as well!

Ok cool, now everything passed in CircleCI


ModelViewInheritance fails in certain cases at design-time for the lastLayer

Closing issue for age. Feel free to reopen it at any time.
.Thank you for your contribution.

Closing issue for age. Feel free to reopen it at any time.
.Thank you for your contribution.


Add kubernetes 1.8 compatibility

The --api-servers argument was removed in 1.8 and deprecated long before in favor of kubeconfig

I am trying this as we speak and I'm going straight for 1.9.0 which was just released.

Hah, they released 1.9 minutes after I opened this PR.


Implement renovate

docs: https://docs.renovatebot.com/

I've opened https://github.com/kuberhealthy/kuberhealthy/pull/1234 to introduce the configuration files.
I believe I need some help permissions-wise in the repo.  I need the ability to configure the Renovate Github App in order for this config to be picked up and watched against.  I've included screenshots of what I see in Kuberhealthy vs what I get in my repos where I've set Renovate up:


Issue with Running Python

when attempting to run python code, I am getting this errror
File "<stdin>", line 1     __globals_3542659721031336_1676496996699 = {**globals()}                                                  ^ SyntaxError: invalid syntax name '__globals_3542659721031336_1676496996699' is not defined
Currently I have my python path set as /usr/bin/python3 and I was just attempt to run print("hello world") as a test. Any help with this issue would be appreciated. Thank you.

Hi @williamwu062, please give us more information, like OS, and the exact code block you used

The same bug here:
MacOS 13.0.1, Obsidian 1.4.14, Execute Code 1.8.1
when I am trying this:
print("Vault path:", @vault_path)

the result returned is as below:
name '__globals_6984937966833744_1696515121154' is not defined

I have the same issue.
print("hello there from obsidian")
name '__globals_7530913097808696_1698266731863' is not defined

MacOS: 11.3.1
Obsidian: 1.4.16
Execute Code: (just installed)

so this is a little weird and I can't identify the state where it works or not but when I created a split screen with source view on the left and a reading view on the right...it works. ¯_(ツ)_/¯


The scrutinizer stucks on "Waiting for External Code Coverage"

Maybe the problem is in these lines:
application:
  project_setup:
    before:
      - composer install --prefer-source

Is there still a problem? Builds are running fine.

If everything is ok we can close it.


Refactor gene expression dataset (rebased)

fixes #337
fixes #270
fixes #383
closes #389
closes #391
closes #392
prepares fix for #325
See original PR (#374) for detail

Codecov Report

Merging #404 into master will decrease coverage by 2.29%.
The diff coverage is 89.32%.

@@            Coverage Diff            @@
##           master     #404     +/-   ##
=========================================
- Coverage   89.42%   87.13%   -2.3%
=========================================
  Files          31       30      -1
  Lines        3027     3210    +183
=========================================
+ Hits         2707     2797     +90
- Misses        320      413     +93

Impacted Files
Coverage Δ

scvi/dataset/seqfish.py
100% <100%> (ø)
:arrow_up:

scvi/models/vae.py
88.54% <100%> (ø)
:arrow_up:

scvi/dataset/smfish.py
100% <100%> (+7.69%)
:arrow_up:

scvi/models/log_likelihood.py
100% <100%> (ø)
:arrow_up:

scvi/models/vaec.py
100% <100%> (ø)
:arrow_up:

scvi/dataset/synthetic.py
100% <100%> (ø)
:arrow_up:

scvi/inference/inference.py
100% <100%> (ø)
:arrow_up:

scvi/models/scanvi.py
73.91% <100%> (ø)
:arrow_up:

scvi/inference/autotune.py
68.09% <66.66%> (-1.09%)
:arrow_down:

scvi/inference/fish.py
74.07% <66.66%> (-6.18%)
:arrow_down:

... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 215a22e...428f7c6. Read the comment docs.

@jeff-regier @romain-lopez I did what I could, this is not particularly pretty but the number of commits has been limited, so less breaking commits, and the blame has been preserved. Just to be clear, this should be merged not squash and merged.


Reformatted code in "Detecting Microsoft Edge from your website" (user-agent-guidance.md)

Changed formatting on many sample code lines, Fixed spacing error on first UA code and table.
Rendered article for review:
https://review.docs.microsoft.com/en-us/microsoft-edge/web-platform/user-agent-guidance?branch=pr-en-us-1615

Docs Build status updates of commit 10ee315:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/web-platform/user-agent-guidance.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 79ce7cc:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/web-platform/user-agent-guidance.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit e016aeb:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/web-platform/user-agent-guidance.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 1d51a7f:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/web-platform/user-agent-guidance.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 46ba483:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/web-platform/user-agent-guidance.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit ea0f9f7:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/web-platform/user-agent-guidance.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit f76b38b:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/web-platform/user-agent-guidance.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


[super_clipboard] Impossible to copy to clipboard on iOS using static linkage

Hi,
I saw in a couple of spots that super_native_extensions is made for dynamic linking, but unfortunately constraints on our projects are such that we need to do static linkage.
I followed the steps here: https://github.com/superlistapp/super_native_extensions/issues/136
which enabled me to properly build. This works on web & Android without issues, as well as when building locally to my iPhone device.
But in release or in Testflight, copying fails:
[ERROR:flutter/runtime/dart_vm_initializer.cc(41)] Unhandled Exception: Invalid argument(s): Failed to lookup symbol 'super_native_extensions_init_message_channel_context': dlsym(RTLD_DEFAULT, super_native_extensions_init_message_channel_context): symbol not found
#0      DynamicLibrary.lookup (dart:ffi-patch/ffi_dynamic_library_patch.dart:33)
#1      _getNativeContext (package:super_native_extensions/src/native/context.dart:14)
#2      _nativeContext (package:super_native_extensions/src/native/context.dart:20)
#3      ClipboardReader.instance (package:super_native_extensions/src/clipboard_reader.dart)
#4      SystemClipboard.instance (package:super_clipboard/src/system_clipboard.dart)

Is there any workaround for this or not?
Thank you.

The way our cocoapods integration works (cargokit) can not be done to support static linking unfortunately. So there is no workaround for this. Eventually it will be migrated to Dart/Flutter native assets (once no longer experimental) and this will not be na issue anymore.

Ok, thanks for the explanation. Is there a timeline currently for the porting to native Dart or not?


VSCode changed my colors

My colors are all messed up after updating. Can we revert that change? I don't care about color semantics. Please do not change theme colors!

How can you disable this?

Here is an image that shows how to disable this crap. Hopefully it saves someone 30 minutes of searching through settings.

Duplicate of https://github.com/microsoft/vscode/issues/90379


Question: Passing signal to enabled

Hi, first off nice project! 🚀
Question: Shouldn't enabled take the signal and not signal.value in the readme example?
const query = useQuery$(() => ({
  queryKey: ["user"],
  queryFn: () => fetchUser(),
  enabled: isUserRegistered.value, // <-- this part
}));

useQuery$ takes callback as an argument - so it will subscribe to any signal reads inside of the callback

Right! I get it now.


Update serde to 1.0.0

Would you be willing to merge a PR that uses serde 1.0.0?

Yes. That would be great!

Can you please push this out to crates.io? Perhaps as a 1.0.1 version or something.

Done.

Sorry for commenting so late, but: This should actually be 2.0.0 not 1.0.1 because updating from serde 0.8 to 1.0 is a breaking change and thus requires a new major version.
If you want to strictly follow semver, you could yank the 1.0.1 from crates.io and publish it as 2.0.0 instead.
If no one complains, I'm not sure whether this is worth the effort.


Incorrect Syntax

Incorrect syntax at https://docs.microsoft.com/en-us/azure/azure-monitor/platform/diagnostics-extension-windows-install#powershell-deployment
{
"PublicConfig": {
"WadCfg": {
"DiagnosticMonitorConfiguration": {
"overallQuotaInMB": 10000
},
Should be:
{
"PublicConfig": {
"WadCfg": {
"DiagnosticMonitorConfiguration": {
"overallQuotaInMB": 10000,
P.S. this breaks the validity of the JSON format at the bottom, please review

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 77600ea1-7a57-3969-bbf5-7cdbc4637725
Version Independent ID: 45e95e4a-ef15-423a-ad9d-5b17e964cd1c
Content: Install and configure Windows Azure diagnostics extension (WAD) - Azure Monitor
Content Source: articles/azure-monitor/platform/diagnostics-extension-windows-install.md
Service: azure-monitor
Sub-service: diagnostic-extension
GitHub Login: @bwren
Microsoft Alias: bwren

@PRMerger17 Thanks for your comment! We will review and provide an update as appropriate.

@ThairAbdalla Verified and updated the document as required. Thanks.


Add scriptencoding command to ensure the file encoding.

Hello, thanks for the nice plugin. I love it.
I would like to suggest to add scriptencoding command to the beginning of autoload/julia_latex_symbols.vim. Although a julia source code is preferred to edit under the environment set encoding=utf-8, there are also cases that one is forced to use other encodings. (For example, with other than cp932, it is possible to happen several problems on communication with external programs in Windows os.) With scriptencoding command, it could guarantee to load these multibyte characters appropriately regardless of encoding option.
In fact, it looks the file  autoload/julia_latex_symbols.vim is loaded at the starting of vim, regardless of whether one edits *.jl file or not. Thus it might cause error messages even only to install the plugin and start vim, with a encoding other than utf-8. I think this tiny commit can suppress the error messages at least.

Thanks! I wasn't aware of the scriptencoding command.

Thanks.


Fix Rebuild LevelSet Metadata

This fixes a bug where metadata was not being copied from the input grid when doing tools::levelSetRebuild().
This showed up in Houdini where using the VDB Rebuild SDF SOP was resulting in a VDB primitive that was returning a value of "" for the vdb_value_type intrinsic instead of "float".
I also added a TestLevelSetRebuild unit test because this method was only being tangentially tested through TestFastSweeping. For now it only calls one of these methods and tests that metadata persists but it may be worth expanding this to validate the API properly.

We can't use this solution. There are a number of algorithms across VDB where metadata copying is ignored - this behaviour is probably relied upon somewhere. Additionally, I've called this method internally plenty of times without caring about the state of the grid metadata - I don't want to pay this penalty.
You can either add a new argument which defaults to the old behaviour, or add a new signature which takes a tree and a transform which avoids this problem entirely.
I suggest adding a new argument which defaults to ignoring

We can't use this solution. There are a number of algorithms across VDB where metadata copying is ignored - this behaviour is probably relied upon somewhere. Additionally, I've called this method internally plenty of times without caring about the state of the grid metadata - I don't want to pay this penalty.
You can either add a new argument which defaults to the old behaviour, or add a new signature which takes a tree and a transform which avoids this problem entirely.

I agree with you. Looking at the documentation around the core library API, it is clearly stating that this is a new grid:
/// @brief Return a new grid of type @c GridType that contains a narrow-band level set
/// representation of an isosurface of a given grid.

so it is expected that this new grid would not have the metadata carried across from the older one.
However, I think in this case, the expectations are different in the client code (Houdini), but I'll open a new PR to address the issue there.
Incidentally, just to highlight that you can use the new Grid methods to very cheaply drop metadata:
/// @brief Return a new grid of the same type as this grid whose tree and transform
/// is shared with this grid and whose metadata is provided as an argument.
GridBase::ConstPtr Grid::copyGridReplacingMetadata(const MetaMap& meta) const;

There are a lot of algorithms that do a deepCopy under the hood that will carry the metadata with them, in case you didn't want to pay that penalty there.


[tbm] fix bextri

@alexcrichton so i've splitted the bextri fix here.
We could change the API of functions taking immediate values to:
fn bextri_u32<const imm: u32>(x: u32);

but what I'd like to see is:
fn bextri_u32(x: u32, const imm: u32);

@withoutboats @eddyb thoughts ?

We can special-case some intrinsics to require a constant argument - we've successfully done this for shuffles, which means they get a constant checking error instead of a post-monomorphization one.
As for the feature of an argument being constant... I think I'd prefer imm: const u32 - in the vein of impl Trait, const T used in an input type position would be an anonymous const generic.

As for the feature of an argument being constant... I think I'd prefer imm: const u32 - in the vein of impl Trait, const T used in an input type position would be an anonymous const generic.

That looks great.

I want to add that this PR does not introduce this problem. The macros.rs file edited in this PR already contains some constify macros with match statements up to 255 match arms that we are already using throughout the library to hack our way around this. This is not a new problem; this PR just makes it worse.
From stdsimd's point-of-view, there are two main issues.
The first one is compile-times. bextri's constify macro requires 4096 match arms; for ~4 uses of bextri throughout the library this results in 2-3x larger compile times for cargo test compared against not using bextri at all, making bextri unusable in practice.
The second problem is safety. Some of the intrinsics require const argument. Ideally, users would get a type error when calling an intrinsic that requires a const argument with a non-const one.
I think that for stdsimd an unstable attribute to mark const arguments would already be enough to help with compile-times, diagnostics, and remove the constify! macros.
Whether this deserves a language level solution or not I don't know. stdsimd is not a typical library. This particular problem arises from trying to expose the intrinsics without changing the compiler much by using link_llvm_intrinsics. If we were to do this in the compiler, as you said, we could fix this problems in a nicer way.

@alexcrichton I don't know what I should do about this PR. I don't want it to rotten but I don't want it to slow compile-times by a factor of 3 either. Iff we are going to fix this in trans we should probably fix the other intrinsics requiring immediate arguments as well, but this significantly raises the barrier of entry for people wanting to contribute to the library an intrinsic that requires immediate mode arguments. IIRC tbm::bextri should already be in librustc_platform_intrinsics
(I put it there a while ago), so we could expose that one here directly, and I could special case it in rustc like @eddyb said to make sure that the arguments are const.

Note that the special-casing would still have to be made in the compiler, the difference with using the imm: const u32 syntax is that users could pass the constant argument through several calls.
Such a feature would require and rely on const generics, so just const generics could be used instead when they arrive, with a minor loss of ergonomics but not of generic programming functionality.

@eddyb

Note that the special-casing would still have to be made in the compiler

Currently the constify! macros work without any special casing in the compiler whatsoever. Is that just pure luck? Or why would we still need to have any of these intrinsics in the compiler at all? (beyond shuffles and other generic intrinsics).

@gnzlbg I meant if you wanted to write them as const imm: u32, although I could see it "just work" for intrinsics, by passing them as regular arguments.
FWIW I'd prefer if we didn't expose LLVM intrinsics directly because of the "post-monomorphization error" behavior we get from that, and specify const requirements in the compiler.

Ok thanks for the PR @gnzlbg! I think though that this is a case where I'd personally prefer at least to hold out for a language feature like const x: u32 or something like that. I suspect we're quite aways away from enabling such a language feature, but I think that's ok in terms of this may not be that hotly desired of an intrinsic?

@alexcrichton I agree. The only workaround for the current state of affairs that I can think of is to use associated consts:
// stdsimd:
pub trait bextri_64 {
  const IMM: u64;
  fn bextri_u64(x: u64) -> u64 {
    llvm_bextri(x, Self::IMM)
  }
}

// user
struct V2();
impl bextri_u64 for V {
  const IMM: u64 = 2;
}

but... this is a weird thing to do this.


feat: add package for go compiler given binary detection

Summary
Syft currently has a Golang binary cataloger. This PR adds a unique synthetic package to the SBOM output that represents the go compiler when detected as a part of the go binary cataloger.
When using an SBOM generated by syft - downstream vulnerability scanners now have the opportunity to detect/report on the PURL/CPEs attached to the new package.
One more piece of work should be doing a bit more string parsing on the go version to identify rc and other candidate releases to improve CPE generation. I'll make those changes before we review.

Blocked on https://github.com/anchore/syft/pull/2201
Will merge after review and 2201 is merged into main


Update ru_ru.lang

Thanks for adding all new values into localization files :)

Great work again, cheers! 👍


INVALID_CLIENT

maybe the issue isn't the plugin, and maybe related to the spotify sdk
when trying to connect I got the next error
java.lang.IllegalArgumentException: Unsupported value: com.spotify.android.appremote.api.error.AuthenticationFailedException: {"message":"Client authentication failed:INVALID_CLIENT"}
there are 2 errors nested, the java.lang.IllegalArgumentException I guess is the plugin but the other one AuthenticationFailedException
Any idea to how solve the problems?
I have the Id from the spotify sdk config and, have the aar. on the libs

Hi @oscarshaitan,
Are you trying to run the example or implementing this plugin in your own project?

Im working on my implementation, but practically I copied the example

Did you register the app correctly with Spotify? see: example/README.md

Yes and I have the Client ID, I check that yesterday too.
even on the spotify SDK there is a issue similar

@oscarshaitan Could you maybe reference the issue in the Spotify SDK? Then I will check it out!

sure, https://github.com/spotify/android-sdk/issues/55

@oscarshaitan does the example work correctly for you when you follow the steps from the readme?


[chore] Fix lint issues

Can't merge here neither. LGTM

Strange, we should fix that permission issue :/


Convert any input into OMOP

Methods can assume that input is already in OMOP. By converting other datasets, we convert to a known problem.

Conversion to OMOP would be done at the database level, so this task is better suited for a data cleaning package. Additionally, it seems complex enough to require another dedicated Julia package.
Currently, PreprocessMD.jl doesn't require OMOP format for function inputs, but this might change as the feature set grows and becomes more specialized.
External packages that perform this task should be linked (#166).


Modal (horizontal) recentering off in Firefox (52.0.2 on LinuxMint 17.3 x64)

Viewing the test page on Firefox has all tests pass except the one that checks the left position. The tests will all pass in responsive design mode, but not in normal viewing mode.
Of note:
To reproduce:

Open the test page in Firefox, not in responsive design view
Resizing the entire browser window and refreshing will still reproduce the error

The test seems to be always off by exactly 7px, no matter what size the browser window is in. Here's the output:
modal recentering

AssertionError: left should be nearby: expected 761.5 to be close to 768.5 +/- 1AssertionError@bower_components/chai/chai.js:5553:18
[3]</module.exports/Assertion.prototype.assert@bower_components/chai/chai.js:206:13
closeTo@bower_components/chai/chai.js:1798:5
[10]</module.exports/ctx[name]@bower_components/chai/chai.js:4192:18
[6]</module.exports/assert.closeTo@bower_components/chai/chai.js:3374:5
checkDialogCenter@suite.js:31:5
@suite.js:268:9

This strikes me as a minor glitch. Perhaps I can submit a pull request changing the test to +/-10px?

I feel like the +/- 1px was mostly to deal with Retina-ness and bring
off-by-one. 10px seems extreme. Is there another styling reason why this is
failing?
On Tue., 18 Apr. 2017, 21:22 Ryan Laboucane<EMAIL_ADDRESS>wrote:

This strikes me as a minor glitch. Perhaps I can submit a pull request
changing the test to +/-10px?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/GoogleChrome/dialog-polyfill/issues/140#issuecomment-294791983,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAHRkMiyyVltBog6k88rOFrCUzaGKHQDks5rxJ0CgaJpZM4M_vBQ
.

Somewhat, but I've narrowed it down, this block seems to be causing the error:
test('modal recentering', function() {
    ...
    big.style.height = '200vh';  // 2x view height
    document.body.appendChild(big); // <-- THIS ONE throws centering out of whack
    ...

And, I've found a good analysis why...
tl;dr version:
All major browsers except Safari deviate from the CSS spec on their implementations of fixedpositioning, opting to position relative to the containing element as opposed to the viewport.

I guess there are one of two proposals I would have at this point:

Alter the test to check for centering based on the limitations presented by the browser. Undoubtedly the easier option, as it would involve implementing a feature check to find out how much the scroll bar displaces fixed positioned elements, and testing the centering accounting for that.

Modify the code to center based on the actual viewport. This would be the more CSS compliant solution, but would mean that we would now be styling from the script rather than pure CSS.


Items lose their data properties when rerendered

If you have local data on the items, when they are scrolled away, then back into visibility, the data is lost.

I have the same problem. I don't know how to solve it. Crying

i find a solution

找到解决办法了！离开页面时，存滚动条位置，回来时先把滚动条置顶，然后在手动重置位置，这样就不会导致数据渲染出问题了


Add possibility to modify requests

For some services e.g. tabrisjs.com or github.com authorization is required. This means sending tokens as query or header parameter for every request to those domains. This includes:

requests made from require statements
resource loading e.g. images
XMLHttpRequest requests

It would be nice to have the possibility to set persistent request attributes. E.g. tabris.setRequestParameter( "https://tabrisjs.com/.*", "token", "value" ); or something like this. Of course parameters are not enough, it should also be possible to set headers and so on.

This has been implemented for a while for XHR/fetch. For require statements I don't think this is required. Loading images that require authentication can be done by downloading them via fetch, storing them on disc and loading them from there. Therefore I will close this issue.


Add text area support for connector parameters

Description:
Add text area support for connector parameters in the new properties view to support params like email content, etc.
Suggested Labels:

Suggested Assignees:

Affected Product Version:
OS, DB, other environment details and versions:
Steps to reproduce:
Related Issues:

Fixed with https://github.com/wso2/devstudio-tooling-esb/pull/1216


not openning

python3 bin/evillimiter
Traceback (most recent call last):
File "/home/blo/Desktop/evillimiter/bin/evillimiter", line 14, in
from evillimiter.evillimiter import run # pylint: disable=no-name-in-module
File "/home/blo/Desktop/evillimiter/evillimiter/evillimiter.py", line 9, in
import evillimiter.networking.utils as netutils
File "/home/blo/Desktop/evillimiter/evillimiter/networking/utils.py", line 3, in
from scapy.all import ARP, sr1 # pylint: disable=no-name-in-module
File "/usr/lib/python3/dist-packages/scapy/all.py", line 18, in
from scapy.arch import *
File "/usr/lib/python3/dist-packages/scapy/arch/init.py", line 28, in
from scapy.arch.bpf.core import get_if_raw_addr
File "/usr/lib/python3/dist-packages/scapy/arch/bpf/core.py", line 31, in
LIBC = cdll.LoadLibrary(find_library("libc"))
File "/usr/lib/python3.9/ctypes/util.py", line 341, in find_library
_get_soname(_findLib_gcc(name)) or _get_soname(_findLib_ld(name))
File "/usr/lib/python3.9/ctypes/util.py", line 147, in _findLib_gcc
if not _is_elf(file):
File "/usr/lib/python3.9/ctypes/util.py", line 99, in _is_elf
with open(filename, 'br') as thefile:
FileNotFoundError: [Errno 2] No such file or directory: b'liblibc.a'

cd /usr/lib/x86_64-linux-gnu/
ln -s -f libc.a liblibc.a

@farissalman12 no such directory: 'x86_64-linux-gnu'
Tried creating the directory, and after ln -s -f libc.a liblibc.a, it showed same error.


Automatically able to push all versions of the image with all Multipaper versions

Describe the solution you'd like
Automatically able to push all versions of the image with all Multipaper versions through GitHub Actions.
Describe alternatives you've considered
Manual creation and pushing of Docker files.
Additional context
None.

Discussed internally with @RemcoSpigot, the plan is to create a workflow with support for repository_dispatch and build all future builds from a dispatch upstream.


[5.2] Added wherelike method to query builder

Any chance of getting something like this merged?
I know doing something like where('name', 'like', '%jordan%') isn't bad at all, but I think writing something like whereLike('name', 'jordan') is a bit cleaner, which would result in where name like '%jordan%'.
Also if its something you think is a good addition I can add it to Eloquent's builder as well!

I would not use it this way. The only sense is if it were only shortcut for where('name', 'like', because now tell me, how this method can be used when you want to search for %jordan ? It won't be possible because you assumed everyone will search for %jordan%.

@mnabialek if you look at the PR it will check if the value has a wildcard before attempting to do a full wildcard search. Also the tests have a case for what you just mentioned. Only the wildcard happens after the value in the test.

Sorry, haven't noticed that.

Holding off on this for now.


[MINOR][SQL][DOCS] Fix the comments in the example at window function

functions.scala   window  function    comment   error:
as   the  comment  is,the  schema   is     timestamp:TimestampType, when   apply  the   window  function      using    time     column   that   isn't   exist,this  can   easy    lead  to     misunderstand
can   contributor    help   me   to     merge   the     pull  request

@yzjg do you mind keeping the GitHub PR template: https://github.com/apache/spark/blob/master/.github/PULL_REQUEST_TEMPLATE?

Can one of the admins verify this patch?

@yzjg do you mind keeping the GitHub PR template: https://github.com/apache/spark/blob/master/.github/PULL_REQUEST_TEMPLATE?

Ok,thank  you    HyukjinKwon

Jenkins test this please

Test build #135233 has started for PR 31582 at commit 3a4702d.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39813/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39813/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39813/

Test build #135233 has finished for PR 31582 at commit 3a4702d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135233/

@yzjg, I updated the PR description for you this time but let's make sure we keep the PR description template next time.

Merged to master, branch-3.1, branch-3.0 and branch-2.4.


Non working state on self-hosted workers

Setup-pixi often falls into a non-working state on my self-hosted workers. I happens if it somehow doesn't managed to clean up after itself nicely (post-cleanup: true).
Then on next run the pipeline fails with:

Maybe just force delete it, or check if the version of pixi is OK, and then just continue.
Right now I have a workaround steps in the pipeline to recover from this. Any other good ideas?

You can try setting pixi-bin-path: ${{ runner.temp }}\Scripts\pixi.exe as described in the self-hosted runner section of the readme.
I'm not really a fan of checking the version since this will lead to more logic that needs to be maintained. Maybe just deleting the other file if it exists would be the best way...


add build-nightly.yml

feat: .github/workflows/build-nightly.yml : adding nightly build for couchbase

@MalloD12 : I see that Java CI with Maven / build-test job  is failing since a while ?


Ethical and privacy-respecting captcha

We could implement this one https://github.com/produck/svg-captcha
If anyone knows of a better one, please let us know, meanwhile I think this one looks like a good option

I won't have a chance to code this myself but if someone submits a PR I'm happy to work with them on it.


First feign request in Configuration file locks with Hystrix, Lazy bean + SEMAPHORE helps

Hi,
We have a case where we need to make a rest request in a Spring Configuration. We do this with a Feign client with hystrix enabled.
When performing the request it times out but after it times out the actual call is made.
If we raise the hystrix timeout all it does is wait longer and acts the same after that.
Error:
Failed to instantiate [com.example.error.MyComponent]: Factory method 'myComponent' threw exception; nested exception is com.netflix.hystrix.exception.HystrixRuntimeException: MyClient#getValue(String) timed-out and no fallback available.

As it's part of the setup of the service it fails to start but if we set the bean requiring the call as lazy initialized the initial rest request fail just as earlier but subsequent rest calls work and the bean is properly initialized.
If we use lazy initialization and semaphore (requires both) for the command everything works as intended: hystrix.command.MyClient#getValue(String).execution.isolation.strategy=SEMAPHORE
With this strategy we can get it to work but it's not prefered for a number of reasons.
We use the Spring Cloud Dalston Release but I've been able to reproduce a really simple sample in Finchley as well which I will attach.
In the sample the Feign Client looks like:
@FeignClient(name = "myrespondingservice")
public interface MyClient {

    @RequestMapping(value = "/value/{value}", produces = "text/plain")
    String getValue(@PathVariable("value") String value);
}

And the configuration:
@Configuration
public class MyConfiguration {

    @Bean
    //@Lazy
    public MyComponent myComponent(MyClient myClient) {
        String value = myClient.getValue("thisismyvalue");
        return new MyComponent(value);
    }
}

Is this expected behaviour? I've been up and down the documentation but haven't been able to find anything regarding this.
I found these issues #384, #768 in my search for an answer. They might be related but #384 resulted in a PR not being made and #768 is closed for other reasons.
Thank you
initializationlockdemo.zip

Using a feign client (or any http request) during bean initialization is probably not a good idea. This is all about timeouts here. Not sure there is anything we can do here.

You are probably correct about requests in initialization.
This is a rather special case where we need to connect applications running on a different (legacy) platform. We have existing functionality to find out where the applications are running.
It's possible to solve it through other means but that requires infrastructure change, which I'm afraid isn't possible right now.
Just wanted to see if there's anything we overlooked but will start looking into other ways of doing it.
Thank you for your help


Ractor makes much slower when using in ULID.sample 😄

$ ruby -v
ruby 3.0.1p64 (2021-04-05 revision 0fb782ee38) [x86_64-darwin20]

This is the current code
https://github.com/kachick/ruby-ulid/blob/e6c5d114d028e62986ab4881dc1382121b6a4f81/lib/ulid.rb#L73-L118
AFAIK, Proc can't be passed.
irb(main):012:0> Ractor.new(->{}) {}
<internal:ractor>:267:in `new': allocator undefined for Proc (TypeError)

And using constants makes slower, written in https://techlife.cookpad.com/entry/2020/12/26/131858
So I have just experiment to use Ractor with following code.
      ractors = Array.new(number) do
        Ractor.new(self, MAX_INTEGER, SecureRandom) do |klass, max_int, rng|
          klass.from_integer(rng.random_number(max_int))
        end
      end
      ractors.map(&:take)

The products looks okay, but much slower.
irb(main):004:0> ULID.sample_old(10000); nil
processing time: 0.161876s
irb(main):005:0> ULID.sample(10000); nil #=> Stack!
^C/Users/kachick/.rubies/ruby-3.0.1/lib/ruby/3.0.0/irb.rb:427:in `raise': abort then interrupt! (IRB::Abort)

irb(main):007:0> ULID.sample_old(100); nil
processing time: 0.065385s
irb(main):008:0> ULID.sample(100); nil
processing time: 1.370176s

ref: https://github.com/ruby/ruby/blob/e3e55967826668dcf6f04c550cab5ef8df71fdb7/doc/ractor.md

This issue is just a note.

💭 Generating 10000 ractos sounds 👿


Not having env vars set does not warn or cause error

This is annoying and you can only figure out if reddit is unauthorized by looking at the logs for rqworker.
The issue is that we just assume the environment variables exist and if they don't then nothing crashes

fyi dc run test will complain if the test vars are not there, since the dict access sys.env['foobar'] will throw an exception if a key isn't there. The main issue is that this silently fails in prod.


Issue when using a tableextension-field in a Report Data-Item

Similar to #223
But I don't know if this is same issue:

Create a tableextension
Use the field on the OnAfterGetRecord
Also tried names, but without success

The extension
tableextension 70095673 "Customer(Table 18)" extends Customer
{
  // version NAVW110.0

  fields
  {
    field(70012200;"Invoice Period Code";Code[10])
    {
      CaptionML=ENU='Invoice Period Code';
      TableRelation="WMS Invoice Period";
    }
  }
  keys
  {
  }
}

The report
report 70012277 "WMS Create Sales Invoice"
{
  dataset
  {
      // dataitem(Customer;70095673)
      // dataitem(Customer;18)
      dataitem(Customer;Customer)
      {
        trigger OnAfterGetRecord();
        var
          InvoicePeriod : Record 70012256;
        begin
          InvoicePeriod.GET("Invoice Period Code");
        end;
    }
  }
}

Sure, we can. But I think it's a bug. The compiler should know that it's on the Customer-Data-Item.
And, this is not consistent like other objects.

You are right. I can see that the base fields are in scope. This is a bug.


Use environment to control program arguments

I pushed a commit earlier today that allows the use of environment variables.
I thought you may be interested in cherry-picking if you found it useful?
export NPM_LAZY_PORT=80
export NPM_LAZY_EXTERNAL_URL=http://localhost
node index.js

This looks great! Could you please open a PR?


add support for GitLab Pipelines

Similar to #71 and #72 although I'm not yet sure of what a practical approach is.

GitLab introduced CI/CD components, as a reusable config, that also accepts some inputs.
While it's mostly a next step from the templates approach that was used previously, it feels more inline with GitHub actions.
I think providing a CI component that can be used, would make this really neat.
There are a lot of examples at https://to-be-continuous.gitlab.io/doc/
I'll try to take a closer look at kargo-render after Kubecon, and might integrate it in our GitLab pipeline. If I do I'll come back to you with the resulting component.


Please make support for hexagon delegate

Some devices cannot use gpu delegate. I have tested on some devices like Xiaomi Redmi Note 11 and Samsung A23 (both use Snapdragon 680). Thank you

@raufendro-dev can you use it on a custom model? Do you have sample repo?

Pleas see: https://github.com/am15h/tflite_flutter_plugin/issues/221#issuecomment-1493378921


feat: Auto extract model when upload model in the UI

What this PR does / why we need it:
Add your description
Which issue(s) this PR is related to (optional, link to 3rd issue(s)):
Fixes #
Reference to #

Special notes for your reviewer:
/cc @gaocegege @FogDong

Release note:

NONE

Can you please add an e2e test?

OK

/lgtm


feat(functions): Add HTTP samples, round 1

Hey Ace, a number of comments are resolved but I don't see pushed commits. Holding off on further review for now.

Hey Ace, a number of comments are resolved but I don't see pushed commits. Holding off on further review for now.

Sorry about the confusion - commits should be live now. Thanks!

Tests are failing because the FOO environment variable is missing. (By default, it's set to bar.)


The minimum level setting does not show the data properly.

MinimumLevel isn't working properly (From https://github.com/SeppPenner/Serilog.Sinks.MicrosoftTeams/issues/1#issuecomment-545080734):

It works similar to another repo - it outputs everything to the channel. But the moment I put in the minimum level, it does nothing, even if I put in Information or manually tries to log it using logger.LogInformation("Information Test")..

Great, just to confirm - do I need to have Serilog.Sinks.MicrosoftTeams installed as well? I do have Serilog.Settings.Configuration already installed.
Serilog.Sinks.MicrosoftTeams

do I need to have Serilog.Sinks.MicrosoftTeams installed as well?

The one in the link? No, this isn't required. This is just the old, not maintained version of the sink from @DixonDs. The projects are independent.
Regarding the configuration part with appsettings. I've not yet checked how this works with Serilog. All I can tell is that I didn't explicitely add something to the sink to provide the functionality...

I don't understand this yet... As far as I have tested this, it should work: https://github.com/SeppPenner/Serilog.Sinks.MicrosoftTeams/blob/10f27de25161ec39c121d610a8c8087a4d502c65/Serilog.Sinks.MicrosoftTeams/Serilog.Sinks.MicrosoftTeams/Sinks/MicrosoftTeams/MicrosoftTeamsSink.cs#L63

Sorry, my apology - it was my error. I fixed it and it is working now. Thanks for making this work!


ref: remove PR closed duplication

they are no longer going to be the same due to https://github.com/getsentry/tacos-gha/pull/251