Allow option of using Memory mapped file(s) instead of direct buffers

Hi,
We are using kryonet for some time now in our project. However, we could not afford to have limited byte buffers for read/write in TCP Connections, as we are sending objects that follow the composite pattern, so object sizes are not fixed and predicable in fact. So we tweaked a bit the code and tried to added ability to overcome this, but we just figured out that we did it wrong in a way and that client server communication is a bottleneck for us, especially when there are two or more clients connected.
So I am trying once again to figure out how to improve our own mistakes and one idea came to my mind and that's: Why not allowing users to initialize the client and/or server with mapped byte buffers pointing to the memory mapped files, instead of the direct buffers?
The benefits would be following:

I can select how big are the mapped files and this is really flexible ( I could easily select 4Gb for example). With direct memory this is not an option.
Write and read operations should be performant enough (check this blog from Martin - http://mechanical-sympathy.blogspot.rs/2011/12/java-sequential-io-performance.html)
The implementation does not to change at all, as it's already working with the byte buffer API, so basically we would need only new constructors for switching to mapped byte buffers..

What do you think, did I not consider something here? If you think this is valid option, I have nothing against in providing the pull request, I would just need some agreement on how to implement it.

Sounds like a good change! Are you still interested in implementing it or have done it already?

Hi @crykn,
Unfortunately in our project we decided to go away from kryonet. Thus I can not provide you any support here as simply I don't have for it. If this changes in future I will let you know. Sorry but I posted this almost a year ago :smile:

No problem, it was worth a try ;)


[Blazor Server Side] Setting @layout on _Imports.razor' project root folder freezes the project -- the browser page keeps loading forever

Describe the bug
After setting the @layout on the root folder _Imports.razor file my project builds, no errors/exceptions are thrown, but the project keeps loading forever.
If I remove the @layout declaration the issue stops happening.
To Reproduce
Steps to reproduce the behavior:

Create a new ASP.NET Core Blazor 3.0 Preview 6 Server Side project
Open _Imports.razor on the project root folder
Add a layout declaration. Ej: @layout MainLayout
Run the project

Expected behavior
The browser keeps loading the page forever
Screenshots

Thanks for contacting us, @baartho.
@ajaybhargavb can we check for this and error out instead? How hard will it be? If it's extra-small work item, we may try to do that at some point in the future. If not, we may not even do it given how corner case this is.

Just spent several hours on this issue. It happens all the time when _Imports.razor imports a @layout within the same folder. This will often happen when people refactor their code by moving around *.razor files. Very hard to understand the cause because the app just hangs without any error.

This also happens to me.
As soon as I add a @layout to the _Imports.razor the app hangs.
Very annoying

Bringing this back to triage

We will consider adding some type of error in situations, where an infinite loop cycle exists in layouts.


Add Column to element type registry

This addresses #903.

I do not thing this change can go in. I do not understand what problem it solves, however it does introduce a problem, namely the ability to use a Column outside a ColumnSet which is not desirable.

Added a comment to the issue. We could potentially still prevent users from using Columns outside ColumnSets by having checks inside the actual Column class though.

Closing, per discussion.


14.1 Compatibility

I know its not an "issue" but would like to at least bring attention to the possibility of 14.1 gaining support from the devs or community made support for it. Thanks and hopefully this will get added!

yep. please add ios 14.1 for a14


added functional tests for liveshare in the notebook editor

For #7374

[x] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
[x] Title summarizes what is changing
[] Has a news entry file (remember to thank yourself!)
[ ] Appropriate comments and documentation strings in the code
[ ] Has sufficient logging.
[ ] Has telemetry for enhancements.
[x] Unit tests & system/integration tests are added/updated
[ ] Test plan is updated as appropriate
[ ] package-lock.json has been regenerated by running npm install (if dependencies have changed)
[ ] The wiki is updated with any design decisions/details.

Codecov Report

Merging #8002 into master will decrease coverage by 0.36%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #8002      +/-   ##
==========================================
- Coverage   59.25%   58.88%   -0.37%
==========================================
  Files         499      499
  Lines       22413    22413
  Branches     3597     3592       -5
==========================================
- Hits        13281    13199      -82
- Misses       8301     8377      +76
- Partials      831      837       +6

Impacted Files
Coverage Δ

src/client/datascience/types.ts
100% <ø> (ø)
:arrow_up:

src/client/testing/serviceRegistry.ts
48.64% <0%> (-46.85%)
:arrow_down:

src/client/testing/codeLenses/main.ts
44.44% <0%> (-33.34%)
:arrow_down:

...t/datascience/jupyter/jupyterDataRateLimitError.ts
66.66% <0%> (-33.34%)
:arrow_down:

src/client/formatters/serviceRegistry.ts
75% <0%> (-25%)
:arrow_down:

src/client/common/utils/icons.ts
83.33% <0%> (-16.67%)
:arrow_down:

src/client/api.ts
78.57% <0%> (-14.29%)
:arrow_down:

src/client/datascience/cellFactory.ts
75.86% <0%> (-13.8%)
:arrow_down:

src/client/common/utils/platform.ts
64.7% <0%> (-11.77%)
:arrow_down:

src/client/providers/providerUtilities.ts
83.33% <0%> (-5.56%)
:arrow_down:

... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa75cf0...6e73e56. Read the comment docs.


Request IIW Credential

Also include IIW logo in credential
Credential data model will be a new 'simple' credential

Talked this through with @AlexAndrei98.  the last major need is for the credential to get stored and appear in the Credential List.


http request store context in structure, it may cause some bug?

https://github.com/golang/go/blob/fa04d488bd54b8fdd78cc9bcc6d90de4bf5f8efb/src/net/http/request.go#L319
according to official document, do not store Contexts inside a struct type, but request.go did(https://golang.org/pkg/context/)

Thank you for raising this issue. Unlike many projects, the Go project does not use GitHub Issues for general discussion or asking questions.
The request.ctx field was added in Go 1.7 in this change https://go-review.googlesource.com/c/go/+/21496/ I encourage you to review the history of the change and the associated discussion.
GitHub Issues are used for tracking bugs and proposals only.
For asking questions, see:

Stack Overflow with questions tagged "go"

The Go Forum, a web-based forum

Gophers Slack, use the invite app for access. The #general channel is a good starting point.

Go Community on Hashnode with questions and posts tagged with "go"

The golang-nuts mailing list

IRC channel #go-nuts on Freenode


Updating api/validation/schema_test to test testapi.Version rather than just v1beta1

For https://github.com/GoogleCloudPlatform/kubernetes/issues/6584.
As part of the change, updated api/validation/schema to use the spec from api/swagger-spec.

@bgrant0607

LGTM


[1928] Fix edit link on course details page

Context

This trello ticket

Changes proposed in this pull request

The link that had a placeholder of # was changed to edit_trainee_publish_course_details_path(@trainee) which links back to the edit publish course details page
Page tracker tracks the confirm publish course details page so dynamic back links track it

Guidance to review

Find a trainee on the Provider Led route who is assigned to a publish course
Click on change the publish course
Select a course and follow onto the next page
Theres a link at the bottom of the page called Edit details for this trainee only
Click that link. You will now be redirected to the course selection page

 [S] Fix Edit details for this trainee link

All good


Making web dev proj1 gym template fully responsive

Issue Type:

[x] Bug Report
[ ] Feature Request
[ ] Documentaion

Describe the bug
There is a folder named web dev proj1 gym in the Cool-Front-End-Templates repo. Make that template fully responsive.
Screenshots

Can you assign it to me?

@primetime71 Make the PR as soon as possible.


Optionally read fuzz target class from JAR manifest

By reading the fuzz target class from a JAR manifest entry rather than
a command-line argument, fuzz targets can be fully self-contained.
This commit adds a Java function that looks for a unique
Fuzz-Target-Class attribute in all manifests on the classpath and
returns it to the driver if found. If no such entry is found, it
falls back to the --target_class commandline parameter.

I have addressed the comments and generalized the approach to the list of custom hooks.

I improved the error handling for invalid hook class names as these were the reason for a hard-to-understand CI failure.


Use getters if available instead of accessing the field directly

Other frameworks use the getter if it is available and only fall back to the field-value if no getter is available. This allows to "process" the value in the gettter.
E.g. the following leads to empty column-values instead of "default":
private String value;

public String getValue() {
    if (value == null) {
        return "default";
    }
    return value;
}

Sorry, all good here, there was a bug in the code using the library.


First Synchronization of 'volumes' command

What's The Problem
It's about the first time when docker tries to synchronize the directory within the container and the corresponding one on the host according to the volumes command.
Docker will always sync the host one with the one within the container.
Sometimes, that's not the behaviour we want.
In some situations, we may want docker to synchronize the host one with container one.
The Environment I Found this Problem

docker version: 1.8.2, build 0a8c2e3
docker-compose version: 1.4.2
OS: Ubuntu 14.04
Kernal version: 3.13.0-40-generic

How to Reproduce This Problem
You need 2 files and one empty directory containing nothing named 'dir' within one blank directory.

test.dockerfile

FROM ruby:2.2.3
RUN mkdir /tmp/dir
WORKDIR /tmp/dir
RUN touch /tmp/dir/abc

docker-compose.yml

test:
        build: .
        dockerfile: test.dockerfile
        container_name: tem
        command:  ls
        volumes:
                - ./dir:/tmp/dir

After running docker-compose up.
Withn 'dir', there is nothing.
But there should be a file named abc.
The Potential Solution
Maybe we could add an extra arg to volumes tell docker the direction we want the synchronization to be.

Hi!
Please read this important information about creating issues.
If you are reporting a new issue, make sure that we do not have any duplicates already open. You can ensure this by searching the issue list for this repository. If there is a duplicate, please close your issue and add a comment to the existing issue instead.
If you suspect your issue is a bug, please edit your issue description to include the BUG REPORT INFORMATION shown below. If you fail to provide this information within 7 days, we cannot debug your issue and will close it. We will, however, reopen it if you later provide the information.
This is an automated, informational response.
Thank you.
For more information about reporting issues, see https://github.com/docker/docker/blob/master/CONTRIBUTING.md#reporting-other-issues

BUG REPORT INFORMATION
Use the commands below to provide key information from your environment:
docker version:
docker info:
uname -a:
Provide additional environment details (AWS, VirtualBox, physical, etc.):
List the steps to reproduce the issue:
1.
2.
3.
Describe the results you received:
Describe the results you expected:
Provide additional info you think is important:
----------END REPORT ---------
#ENEEDMOREINFO

When using bind-mounted volumes, docker does not synchronize the files of the container to the volume, but uses the files that are in the bind-mounted directory.
Changing this behavior has been proposed before, but was rejected, see: https://github.com/docker/docker/pull/9092
For that reason, I think this should be closed :'(
As a workaround, you could consider using an entrypoint script that copies files from inside the container to the volume, similar to https://github.com/docker-library/wordpress/blob/3447b0ea9c1eccf1e00feb8e2e70c311690763af/apache/docker-entrypoint.sh#L38-L62

Yep, bind mounts will mount the host dir into the container, nothing more.
It's unfortunate that docker even creates these dirs if missing, but that functionality is deprecated and will be removed in 1.11.


LCFS - Final assessed report, BCeID & IDIR

Description:
The final assessed report feature for both BCeID and IDIR systems will include updates to the report history box and assessment messages. For BCeID users, the report history box is renamed to "Assessment" and displays whether the organization has met renewable and low carbon fuel targets, as well as report history details like signing and submission information. A new button for creating supplemental reports is also introduced. IDIR users will see additional details, including the director's name in the assessment history.
Wireframe:
BCeID Wireframe
IDIR Wireframe
Purpose and benefit to user:
For BCeID users, the updated assessment section provides clear feedback on whether fuel targets are met and offers easy access to create supplemental reports if needed. For IDIR users, the inclusion of the director's name in the assessment provides greater transparency.
Acceptance Criteria:

[ ] The "Report History" box in BCeID is renamed to "Assessment" and displays the correct fuel target messages based on the report status.
[ ] The assessment message dynamically displays “has met” or “has not met” based on the report summary.
[ ] BCeID report history includes timestamps for assessment and submission without displaying government staff names.
[ ] A new card is present in BCeID allowing users to create supplemental reports, with the appropriate 30-day notice message.
[ ] In IDIR, the assessment history includes the director’s name along with the date and timestamp of the assessment.

Development Checklist:

Update the report history box in the BCeID user interface.
Implement dynamic messages for renewable and low carbon fuel target assessments.
Ensure timestamps for report history are displayed correctly, without revealing government staff names in BCeID.
Add a new card with a supplemental report button and notification text.
Modify IDIR report history to include the director’s name in the assessment section.

Notes:
Ensure that the status (met or not met) for fuel targets is determined automatically based on the report summary data. The government staff names should not be visible to BCeID users.

Hi @prv-proton! Blocked from testing this one because of an error when accepting the report on the IDIR side with a director role:

500 is a permissions error, right? I definitely have my role set to "Director"

Unable to test until bug identified in card #1129 has been fixed

there are newer design changes in card 1071, closing this card as a result


Algorand Unity SDK deprecated in Unity Assets??

What??

Yep, Unity changed their asset requirements for any web3 assets recently, and marked all of them deprecated until they can get reapproved :(.
I'm still waiting to hear back on what I need to do to get reapproved.
On Mon, Jul 25, 2022 at 5:17 AM, Enrico Speranza @.***> wrote:

Schermata 2022-07-25 alle 14 06 58
What??
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: @.***>

Hey @Vytek , I'm working with Algorand Foundation to become a VSP with Unity and un-deprecate this asset in the Asset Store.
It's going to be a long process, and may require lots of changes for this project. In the meantime, please install via UPM or the .unitypackage file in the Releases.

keeping this issue open until the sdk can be back in the asset store. However locking it, as there is a workaround above ^^


fix handle on_member_join update_status

Fixed argument error on function call

I think this is exactly the same as #17, which has already been merged.

Can you recheck? It's not the same as #17


Release notes for microbit 0.12.22

@pelikhan oo, this looks super!

I don't understand this change. What is this?

It is probably better idea to squash or rebase before creating the pull request. There are more than 250 commits here

Please use https://github.com/Microsoft/pxt/pull/2181 . This PR was mistakenly based on master.


Add support for MySQL Server Language 5.5.0

Is your feature request related to a problem? Please describe.
Support for MySQL Server Lanaguage 5.5.0
Describe the solution you'd like
Just add support for MySQL Server Language 5.5.0
Describe alternatives you've considered
Nothing
Additional context
Nothing

Hi,
I likely won't be adding support for 5.5.x or below as this has been marked end of life by Oracle in December 2018 so is not recommended to continue using, so would therefore recommend to upgrade MySQL to at least 5.7.x
Thanks
Chris


Syslog entries with no host attribute

Syslog entries with no source host attribute don't parse right. This is the default configuration on FreeBSD, among others. The --no-host option has been added. It will be included in version 1.3.1 or 1.4, whichever comes next.

Implemented in 1.3.1


Notifications not working

Hey as the tittle says i have been unable to receive notifications from this. I have asked a few times on RL discord but no one would respond. I have uninstalled the plugin and reinstalled it but with no success. I received one notification randomly but then never again. I tried deactivating all other plugins to see if any were interfering, nothing. is there anything else that i can do?

Make sure that you have configured the notification setting in the "RuneLite" section to your liking. If you have the defaults, notifications are muted if you have the window in focus.
If you have configured the notifications and this still happens, you'll have to send the logs over and I'll check what I've f'd up this time.

Hey i have always had these notifications settings Pic. Does idle notifications have anything to do with this? Also how do i get the logs?

Other plugins shouldn't be able to interfere, as far as I know. On Windows, you can find the logs in %userprofile%\.runelite\logs, latest is just client.log.
I haven't done this kind of debugging before but those seem like the correct files.

Ok, here is Pasbin of that file


Consistent #include's in public VM APIs

Currently, the #include's in runtime/include/*.h follow two formats:
#include "dart_api.h"
#include "dart_tools_api.h"

and
#include "include/dart_tools_api.h"

This creates problems when we try to define the includes root. Currently, we have to put in both /runtime/ and /runtime/include as part of -I which seems unnecessary. Can we please standardize? I would much rather we always do #1 (w/o the "include" prefix).

@a-siva , this will make it easier to build internally.

Can you elaborate on why you prefer the first option.
In the runtime/vm directory we always use #include "include/dart_api.h" this has been our stated policy and i see that some of the newer files that got added in the 'include' directory do not follow this.

We currently recommend users of this API to write #include "dart_api.h" in their code as opposed to "include/dart_api.h". The latter makes less sense to me since the prefix include/ is not specific to Dart VM.
These users, internally, depend on a single build target which defines the -I flag so they can't modify it. So we either need to tell them to use the include prefix OR have both runtime/ and runtime/include/ as part of -I.


Memory usage improvements and lower minimal git requirement to 1.7.2 (#3013)

Backport to 1.3

LGTM

When I see https://github.com/go-gitea/git/pull/90/files, I think this is unnecessary. There are some risk to send an enhancement PR back port to 1.3.

We only need the change on

GitVersionRequired = "<IP_ADDRESS>"

GitVersionRequired = "1.7.2"

Those additional files are just tests (and CI/drone) related. Where's the risk you see ?

@lunny there is either all or nothing here :)

oh, Yes. LGTM

make L-G-T-M work


Fix: DynamoDB Typeerror with AWS Bedrock

When using AWS Bedrock, _update_item throws a TypeError as AWS Bedrock returns floats in its response. Dynamodb requires floats to be provided as Decimal. The reverse can also occur if you call get_thread from anywhere in code, as Decimal is not JSON serializable.
The issue can be seen here #1116
I have added two new functions within DynamoDBDataLater that converts floats to decimals and decimals to floats, calling each function from _update_item and get_thread respectively. This change resolves the TypeErrors.

Diffs LGTM. Next step is for @willydouhard / @tpatel / team to test and approve.

Anything you need from me to progress this @mayaankvad ?

No, I think the changes look good. Now it needs @willydouhard / teams approval

Seems like mypy is failing @munday-tech

Are you able to make this fix @munday-tech?

Will get it done asap

@willydouhard @mayaankvad should be good now.

Any updates on this one? Looking forward to this being merged

Looks ok to me.

I am waiting for this one to be merged

Also waiting on this to be merged - would someone be able to add the type hints and doc strings so it can be done soon please?

any news about this?

Also needing this to be merged.


Ftest max inputs

Add functional testing to validate maximum number of inputs
15 inputs for a Nano S
128 inputs for a Nano SP and Nano X

Codecov Report
Patch and project coverage have no change.

Comparison is base (1d5d101) 87.98% compared to head (bd8f80a) 87.98%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #13   +/-   ##
=======================================
  Coverage   87.98%   87.98%
=======================================
  Files          25       25
  Lines        1182     1182
=======================================
  Hits         1040     1040
  Misses        142      142

Flag
Coverage Δ

unittests
87.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Add Methods to SocketDigest for Retrieving SO_ORIGINAL_DST Information

#385

@andrewhavck Builds on Rust 1.72 are failing due to the latest boring-sys release (v4.10.*), where bindgen was updated (see: https://github.com/cloudflare/boring/pull/273). Any suggestions on how to resolve this or work around the issue?

@ermakov-oleg fix was merged so builds are passing now.

@andrewhavck maybe there are some other comments or something that might be blocking the merge of these changes?

@ermakov-oleg it's been reviewed internally, should land soon, thanks.

Merged and synced. Thanks!


Fix(pkg): build multi-arch controllers

Purpose of PR?:
KubeArmor custom controllers i.e. kubearmor-policy-manager, kubearmor-annotation-manager and kubearmor-host-policy-manager were built with hardcoded build flags GOOS linux GOARCH amd64 therefore they were failing to execute on arm platform. the PR handles that and also the kube-rbac-proxy deployed along with custom controllers will be removed with this PR.
Fixes #1101 #1084
Does this PR introduce a breaking change?
No
If the changes in this PR are manually verified, list down the scenarios covered::
Additional information for reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Checklist:

[x] Bug fix. Fixes #1101
[x] PR Title follows the convention of  <type>(<scope>): <subject>

imo we can retain kube-rbac-proxy and upgrade it to newer version. at this point we are not leveraging it but  it'll will good to have it for use cases such as granting permissions to export matrix to Prometheus. WDYT @achrefbensaad

@rksharma95 Lets keep it for now.


Upload images to S3 with TrustTrees

We can already pass AWS credentials to TrustTrees
Let's make it so that we can pass a bucket and prefix, then upload the e.g. pngs to an S3 bucket. In case you made e.g. Jira tickets with the alerts, and wanted to link an S3 signed URL or something, to make the graph easily viewable outside of the box TrustTrees is running on.
Make sure to doc in the readme that you need PutObject etc.

(We can close this now)

++, thanks for the pointer, I’m used to GithHub auto-closing.


Provide the code hint for css(include inline css) & javascript in HTML files plz...

VSCode Version: 1.5.1
OS Version: win10

Example：

inline css

Was about to open an issue, but this is about the same thing I am experiencing (?)
css code inside a style tag inside an html file has no intellisense suggestions.... Am I right ?

Sometimes I need to write CSS and JS in HTML, but no intellisense, coding efficiency is very low

duplicate of #8928


build异常

Plugin org.apache.maven.plugins:maven-jar-plugin:2.3.1 or one of its dependencies could not be resolved: Failed to read artifact descriptor for org.apache.maven.plugins:maven-jar-plugin:jar:2.3.1: Could not transfer artifact org.apache.maven.plugins:maven-jar-plugin:pom:2.3.1 from/to central (https://repo.maven.apache.org/maven2): Received fatal alert: protocol_version -> [Help 1]

下载maven，解压后配置环境变量，然后改下仓库信息
安装配置内容可以参考，https://www.cnblogs.com/youxiu326/p/10540752.html
maven下载自己找一下资源


Update README.md

Added details on OpenVINO Go extension and 3 demo repos

The overarching aim is to create an efficient, user-friendly, and scalable system for molecular property prediction and visualization. This system can significantly aid in pharmaceutical research, particularly in the early stages of drug discovery where rapid screening of compounds based on their lipophilicity and structural analysis is vital. By combining the computational power and optimization of OpenVINO with the simplicity and accessibility of a Go client, the system bridges the gap between advanced computational chemistry and practical application in research environments.


Unlock issue #103285

Issue #103285 is locked and therefore people cannot react to indicate if they would like the feature to be implemented. Could it be unlocked so that it has a chance to see how much interest there is?

Unlocked the issue.


Fix: avoid embedding the user input into the error response.

Pull Request
What does this PR do?
Fix #2107.
The problem is meilisearch embeds the user input to the error message.
The reason for this problem is milli throws a serde_json: Error whose Display implementation will do this embedding.
I tried to solve this problem in this PR by manually implementing the Display trait for DocumentFormatError instead of deriving automatically.

PR checklist
Please check if your PR fulfills the following requirements:

[x] Does this PR fix an existing issue?
[x] Have you read the contributing guidelines?
[x] Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

Sorry for the late response. I will submit a patch to  follow the suggestion of @Kerollmops today.

@CNLHC thanks a lot for these changes 🙏
Looks like there is a tiny issue to fix with our clippy CI before Kero reviews it :)


Obtaining or predicting leaf index using ydf

Hello 👋
Thanks for the clear and easy to digest documentation and guides on how to leverage ydf for different ml tasks.
I'll like to know if ydf supports or provide mechanisms for extracting tree index as provided in other libraries such xgboost, catboost and lightgbm. This is good for situations where one needs to use gbm to transform the data.... feature extraction.
I have read the documentation but it's not clear to me if this feature exists. One feature that I came across (although I haven't played with yet) is the get_all_trees method in the advanced section of the documentation. I'm not sure if it provides this functionality.
Thanks in advance.

Hi,
thank you for the kind words :)
I think you might be looking for the model.predict_leaves, which returns the index of the active leaf in every tree for each example - does this fit your needs?

@rstz Thanks a lot for your timely response. It really helps. That's exactly what I'm looking for.


Possibilty to make the page wider

Hi, how is it possible to make the page wider? There are white bars on the left and right from the page.
Cant find the place to change it.
Thanks in advice.

Yes, you can make the page wider.
you can change the container class here index.component.html#L2
Reference:

Bootstrap Containers

Thanks alot, already found that part but wasnt sure.  :)


Change to not initialize collections by default on generated POJOs

Fixes https://github.com/serverlessworkflow/sdk-java/issues/204.
Changes:

Set initializeCollections jsonschema2pojo property to false
Added test
Fixed test that started to fail after setting initializeCollections to false

Can you show what the resulting json (Workflow.toJson(workflow)) looks like with this change?

When initializeCollections = true (current code):
{
  "id" : "functionrefs",
  "name" : "Customer Credit Check Workflow",
  "description" : "Perform Customer Credit Check",
  "version" : "1.0",
  "start" : "TestFunctionRef",
  "specVersion" : "0.8",
  "expressionLang" : "jq",
  "events" : [ ],
  "functions" : [ {
    "name" : "creditCheckFunction",
    "operation" : "http://myapis.org/creditcheckapi.json#doCreditCheck",
    "type" : "rest"
  }, {
    "name" : "sendRejectionEmailFunction",
    "operation" : "http://myapis.org/creditcheckapi.json#rejectionEmail",
    "type" : "rest"
  } ],
  "retries" : [ ],
  "errors" : [ ],
  "secrets" : [ ],
  "states" : [ {
    "actionMode" : "sequential",
    "actions" : [ {
      "functionRef" : "creditCheckFunction"
    }, {
      "functionRef" : {
        "refName" : "sendRejectionEmailFunction",
        "arguments" : {
          "applicant" : "${ .customer }"
        },
        "invoke" : "sync"
      }
    } ],
    "usedForCompensation" : false,
    "name" : "TestFunctionRefs",
    "type" : "operation",
    "end" : true
  } ]
}

When initializeCollections = false (this change):
{
  "id" : "functionrefs",
  "name" : "Customer Credit Check Workflow",
  "description" : "Perform Customer Credit Check",
  "version" : "1.0",
  "start" : "TestFunctionRef",
  "specVersion" : "0.8",
  "events" : [ ],
  "functions" : [ {
    "name" : "creditCheckFunction",
    "operation" : "http://myapis.org/creditcheckapi.json#doCreditCheck",
    "type" : "rest"
  }, {
    "name" : "sendRejectionEmailFunction",
    "operation" : "http://myapis.org/creditcheckapi.json#rejectionEmail",
    "type" : "rest"
  } ],
  "retries" : [ ],
  "errors" : [ ],
  "secrets" : [ ],
  "states" : [ {
    "actionMode" : "sequential",
    "actions" : [ {
      "functionRef" : "creditCheckFunction"
    }, {
      "functionRef" : {
        "refName" : "sendRejectionEmailFunction",
        "arguments" : {
          "applicant" : "${ .customer }"
        },
        "invoke" : "sync"
      }
    } ],
    "usedForCompensation" : false,
    "name" : "TestFunctionRefs",
    "type" : "operation",
    "end" : true
  } ]
}

There's only one difference: "expressionLang" : "jq" didn't appear in the json when initializeCollections = false
This shouldn't happen. If we'll go on with this change, I'll have to investigate it. But this is a different issue.
The most important thing, for what we're discussing, is that annotations doesn't appear in json no matter the value of initializeCollection. This behavior is correct when initializeCollections = false (this change), since Workflow#getAnnotations returns null. But when initializeCollections = true, Workflow#getAnnotations returns an empty list. So an empty array should appear in the resulting json. It looks like the json parser ignores the attribute if it's null or empty.

https://github.com/serverlessworkflow/sdk-java/blob/8a61e3cb23f6ae75d2d711410bff974322717d77/api/src/main/java/io/serverlessworkflow/api/serializers/WorkflowSerializer.java#L66

if its null or empty it should not be spit out as json/yaml

we need tests that round-trip markup it seems ...will add

Reverted to draft to investigate the jq issue.

There's only one difference: "expressionLang" : "jq" didn't appear in the json

jq is the default value if its not in json/yaml so this should be ok imo

There's only one difference: "expressionLang" : "jq" didn't appear in the json

jq is the default value if its not in json/yaml so this should be ok imo
the markup that sdk spits out from object model imo does not 100% have to match the original user markup (for example default prop values and empty arrays can be omitted) , but it has to be semantically the same (and it has to be validatable if original was too)

Yes. Makes sense.

we need tests that round-trip markup it seems ...will add

@tsurdilo Just to clarify, you need to add these tests before we move on with this PR?

we need tests that round-trip markup it seems ...will add

@tsurdilo Just to clarify, you need to add these tests before we move on with this PR?

Yes, I'm updating all tests to make sure the json+yaml outputs are validated. This could help us figure out all possible issues the code might have right now and then we can look how to handle them. Hope thats ok with you.

@tsurdilo did you manage to update the tests you mention above so we can move this PR forward?
If you need any help with that, just let me know.

@manick02 do you mind taking a look at this PR? I'm not sure if @tsurdilo is seeing my messages.
If you have any questions or need any clarification on this, please don't hesitate to ask me.


Use insertLineBreak instead of insertParagraph for PendingKey Enter

To handle https://github.com/codemirror/dev/issues/1145
Based on the suggestion here: https://github.com/codemirror/dev/issues/1145#issuecomment-1617709896
Tested here:

Visit https://cm-view-ada1204-debug.bradyatreplit.repl.co on browserstack.com, using a Google Pixel 7 on Chrome
Click after the t in "Print" in the codemirror editor
Press Backspace
Press t
Press Enter
Notice we move only one newline down instead of 2, as it previously did

We'll need both insertLineBreak and insertParagraph. As in 2670dda


Create de_de.json

Merged, translations keys aren't technically finalized yet but it'll probably be fine


Typo "WHEN @isEmailValidated"→"WHEN @isEmailValidated"

Bold with escape characters
https://docs.microsoft.com/en-us/dynamics365/fraud-protection/fpl-lang-ref

@TinaMcN Could you please explain a bit more about the reason of PR not being built? Thanks.

@YvonneDeQ can you help answering @hyoshioka0128 question?

Thank you - I have fixed the typo and it will be available in the next build release.

Thank you - I have fixed the typo and it will be available in the next build release.
Yvonne
From: Tina McNaboe<EMAIL_ADDRESS>Sent: Wednesday, June 17, 2020 11:46 AM
To: MicrosoftDocs/dynamics-365-fraud-protection<EMAIL_ADDRESS>Cc: Yvonne De Quadros (Aquent<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/dynamics-365-fraud-protection] Typo "WHEN @isEmailValidated"→"WHEN @isEmailValidated" (#6)
@YvonneDeQhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FYvonneDeQ&data=02|01|v-madeq%40microsoft.com|a0a1b58a42de40b12a5208d812eeb18e|72f988bf86f141af91ab2d7cd011db47|1|0|637280163673891498&sdata=AMwuYZiDsPCJEEC%2FDEwMnIIxI764adwBJOK7ZHj1uIA%3D&reserved=0 can you help answering @hyoshioka0128https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fhyoshioka0128&data=02|01|v-madeq%40microsoft.com|a0a1b58a42de40b12a5208d812eeb18e|72f988bf86f141af91ab2d7cd011db47|1|0|637280163673901491&sdata=xDPgBMbfdrnBuzmn%2FNjt2Ka2In7FEen8Ady62zbdECI%3D&reserved=0 question?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fdynamics-365-fraud-protection%2Fpull%2F6%23issuecomment-645554157&data=02|01|v-madeq%40microsoft.com|a0a1b58a42de40b12a5208d812eeb18e|72f988bf86f141af91ab2d7cd011db47|1|0|637280163673901491&sdata=%2F8F%2FeetHtG7wGwYOQeyUWnCOqfNG46UERTaGJvqgECA%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAOZGYWCQ4262CQGZDP3LAMTRXEFO5ANCNFSM4NIKDNBQ&data=02|01|v-madeq%40microsoft.com|a0a1b58a42de40b12a5208d812eeb18e|72f988bf86f141af91ab2d7cd011db47|1|0|637280163673911478&sdata=SrZ82VowJ%2FkA842hQXCK7LHO57n9fkNQY0dEWRGL2K8%3D&reserved=0.


Fs 102/create report agent

Description
https://scottlogic.atlassian.net.mcas.ms/browse/FS-102
Changelog

Add a new report agent to form and execute prompts relating to ESG report generation
Add new user/system prompt templates for ESG report generation

Can we hook this up to the API and report director and test with swagger? http://localhost:8250/docs

Can we hook this up to the API and report director and test with swagger? http://localhost:8250/docs

Ah, we are still waiting for Mike's ticket to go in to get the report director changes


Added University of New Brunswick entry

Whilst ensuring students make good password choices is a welcome thing, this might be a little excessive

Whilst ensuring students make good password choices is a welcome thing, these requirements by the University of New Brunswick might be a little excessive

Thanks for your previous submission!
I've recently migrated the site from a simple README to a full static site (https://github.com/duffn/dumb-password-rules/pull/443).
If you're interested in re-submitting your entry, please create a new PR following the new contributing doc here (https://github.com/duffn/dumb-password-rules/blob/master/CONTRIBUTING.md).


F/A 18C coordinates entering W instead of E

Hello - I have noticed that when entering coordinates for WPTS, the program is not entering E coordinates (even though they are correctly recorded in Scratchpad+). Instead, the script is trying to enter a W coordinate. This is despite all settings being correct (e.g. in Precise mode/no TAC page open, etc.). This might be user error (or a problem with a setting in DCS). However, loading coordinates for other platform (e.g. the F16) works perfectly. So, I am wondering if there might be an error in the script running the key presses? Thanks for looking into this. Regards. S

Hi, can you confirm you use last version ?
also what is your fps in game and in scrachpad config ? (with F18 you need to config a little more in the software. example with 100fps in game, set 110fps on the interface.

i try with last version without problem. W instead E append when fps is set too low in regard of in game fps (so in fact scrachpad+ will press on the keyboard too quickly). be sure you set a value graeter that your true fps.
best,

Thanks so much for that advice. I would never have thought to change FPS. I will make the recommended change and let you know if that solves the problem for me. Best wishes. S
DR SIMON LONGSTAFF AO FCPA FRSN FARPI| EXECUTIVE DIRECTOR | THE ETHICS CENTRE
ADJUNCT PROFESSOR, AGSM, UNSW BUSINESS SCHOOL, UNSW
LVL 2 LEGION HOUSE 161 CASTLEREAGH STREET SYDNEY NSW 2000
E @.*** | T +61 2 8267 5734 | M +61 418 410 187
WWW.ETHICS.ORG.AU
The Unexamined Life is Not Worth Living – Socrates
This communication is intended for the addressee named and may contain information that is strictly confidential. Reproduction, dissemination or distribution of this message is prohibited unless authorised by the sender. There is no warranty that this email is error or virus free. If this is a personal communication it does not necessarily represent the views of The Ethics Centre.

From: DocBrownd @.>
Sent: Thursday, September 26, 2024 6:05:13 AM
To: docbrownd/ScratchpadPlus @.>
Cc: Sting-Array @.>; Author @.>
Subject: Re: [docbrownd/ScratchpadPlus] F/A 18C coordinates entering W instead of E (Issue #3)
i try with last version without problem. W instead E append when fps is set too low in regard of in game fps (so in fact scrachpad+ will press on the keyboard too quickly). be sure you set a value graeter that your true fps.
best,
—
Reply to this email directly, view it on GitHubhttps://github.com/docbrownd/ScratchpadPlus/issues/3#issuecomment-2375148557, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BIWHO5K252MLV346XY3B24TZYMJPTAVCNFSM6AAAAABOUF6KICVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNZVGE2DQNJVG4.
You are receiving this because you authored the thread.Message ID: @.***>

Bonjour Doc - I do not think that I have been making the correct adjustment as nothing I have done has corrected the error. To clarify, I have made a series of adjustments to the 'maximum FPS' settings, in DCS, under the 'system' tab. Those adjustments have ranged from setting the number as high as 300 (maximum) and as low as 100. In no case has the error caused by the rapid button presses been corrected. So, should I set an even lower maximum FPS in that setting? Or am I making changes in the wrong place? That is, is there another setting that I should be changing? Thanks for any further advice you might be able to provide when you have time to do so. Regards. S

when you set in scratchpad+ the fps value, set a value > that your IRL fps. more scratchpad+ fps is greater than IRL FPS, more press speed decrease (and not increase ^^). try with 150 for example. Don't change DCS params, only scratchpad+ config :

D’accord! Thanks again for taking the time to respond. I had not understood that the FOS functionality was in the app. Will try the solution you propose - and will let you know if this solves the problem (which I believe it will)!

Merci beaucoup. Le problème est maintenant résolu. J'apprécie vraiment que vous preniez le temps de m'aider à résoudre ce problème. Meilleurs vœux. S

Merci beaucoup. Le problème est maintenant résolu. J'apprécie vraiment que vous preniez le temps de m'aider à résoudre ce problème. Meilleurs vœux. S

pas de problème.

Merci beaucoup. Le problème est maintenant résolu. J'apprécie vraiment que vous preniez le temps de m'aider à résoudre ce problème. Meilleurs vœux. S

pas de problème.


Click help: max 100 chrs wide

I changed the default maximum width for rich-click to be the full width of the terminal.
This PR customises the package to limit the width to 100 characters (or the width of the terminal if less than that).
Personally I think it looks better for dds as the majority (all?) of the help messages fit within this width.
The end result is the same as when I originally added the package, before I changed the default.

I tried it out and didn't actually notice a difference, so as you say most things should fit within 100 chars. 👍🏻

Ah right, I hadn't pushed the release yet which is why you didn't see any change in behaviour 😅

@ewels 😆 Okey. Have you done that now? Let me know and I'll try it out.

Yup, v0.3.0 went out last night! Still fairly heavy development so it's very likely that I'll need to do another PR soon 👀


Embeddings sweep tests failing

The tests are failing due to API changes. YAML and tt_lib_ops file have to be updated with respect to the last specification.

@npetrovic-tenstorrent is this issue still relevant?
Please close if not.


Add Python 3.9's merge operators | and |= support (#127)

Add Python 3.9's merge operators | and |= support (#127 ) with passing tests.
The implementation simply uses the snippet provided in the PEP https://www.python.org/dev/peps/pep-0584/#reference-implementation
Also fixes the deprecated assertEquals of the unit tests

Coverage decreased (-5.2%) to 94.828% when pulling 39cb368f402069c4a57f0f20387675e2310adab6 on hl037:master into 66d88115001d32083e33f56c1b29d736a6d18560 on mewwts:master.


[Urgenti Fix] JSON output returns incomplete data

This PR fixes the new JSON output introduced in the last PR (#5). In case of multiple errors, the JSON output returned just one error.
I have identified this error because I am working on a GitHub Action.

Nice!


Updated link in documentation

Fixed broken link under "Prepare and configure Kops" section.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


September should be abbreviated as Sep.

,CONTEXT
September used to be abbreviated as Sep, but after #2728 it was changed to Sept.
While I agree that in American English Sept. is more common, Sep is understandable and I think we should use it when formatting dates, to keep consistency with other languages (and JavaScript itself).
Some points in favor of changing it back to Sep:

This is inconsistent with most programming languages: Java, Ruby, Scala and Python (the languages I tested on) all use Sep instead of Sept when formatting dates (snippets below).

Ruby, Java and Python do not accept Sept as an argument when parsing dates.

This could cause issues in the interface, as well: suppose you're displaying the date on an element with a fixed width. September is the only month which requires more space, as it is the only month with 4 characters.

Ruby
  Date.strptime("Sep-01-2015", "%b-%d-%Y") // works
  Date.strptime("Sept-01-2015", "%b-%d-%Y") // error: ArgumentError: invalid date
```

Python
```python
datetime.datetime.strptime( "Sep", "%b" ) // works
datetime.datetime.strptime( "Sept", "%b" ) // error:
// Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/_strptime.py", line 328, in _strptime
    data_string[found.end():])
ValueError: unconverted data remains: t
```

JavaScript

```js
var d = new Date(2016, 8, 1);
d.toString() // Thu Sep 01 2016 00:00:00;
```
JavaScript dateformat (most popular library for formatting date on npm - https://www.npmjs.com/package/dateformat)

```js
var date = new Date(2015, 8, 10);
dateFormat(date, "mmm") // Sep;
```

Java (including its new Time API):
```java
DateTimeFormatter formatter = DateTimeFormatter.ofPattern("MMM-dd-yyyy");
LocalDate date = LocalDate.parse("Sep-10-2016", formatter); // works
LocalDate date = LocalDate.parse("Sept-10-2016", formatter); // error:

Exception in thread "main" java.time.format.DateTimeParseException: Text 'Sept-10-2016' could not be parsed at index 3
```

In fact, I discovered this because I faced an error when trying to consume an API that used the pattern `MMM-DD-YYYY` for dates, but failed to accept `Sept` as an argument.

This could be marked as a duplicate of #2854, I think. I didn't see it when I opened this issue.

Great explanation of this breaking change.

I agree with you. I didn't pay enough attention to this change. I know a lot of people use moment formats to pass strings between languages / platforms etc. I'll revert it in 2.11.1. Sorry for the trouble.
Close in favor of #2881.

Yes, indeed.  Apologies for the breaking change.


Document how to create persistent archive with bst source push

See original issue on GitLab
In GitLab by [Gitlab user @juergbi] on Jul 6, 2020, 08:45
The following discussion from !1977 should be addressed:

[Gitlab user @sstriker] started a discussion:

I think this is excellent functionality.  We should think about documenting how to create a persistent archive from which you can always repeat a build without having to do source mirroring, but purely leveraging a persistent RA and CAS.  This will result in being able to repeat builds even without the host tools needed by the Source plugins.

This will result in being able to repeat builds even without the host tools needed by the Source plugins.

This is most probably untrue simply because Source plugins tend to assert the presence of their host tools early on, and not only directly before attempting to use them (which is a feature of the preflighting stage).


Update for Django 1.8.6 and for Mac OS X El Capitain

the requirements file is way too large: there is no need to replicate all crossbar deps. django requests psutil is enough. just kick the requirments file and leave it as is


feature: add props isSplit to button with dropdown

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/39832
PROPOSAL: https://github.com/Expensify/App/issues/39832#issuecomment-2043170656
Tests

Go to workspace setting
Enable all features: distance rates, categories, tags, taxes
Select rows of data using the checkboxes on the left side of the row
Verify that: A dropdown button with no split is displayed in top right
Click to this button
Verify that: A dropdown is working fine

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

Go to workspace setting
Enable all features: distance rates, categories, tags, taxes
Select rows of data using the checkboxes on the left side of the row
Verify that: A dropdown button with no split is displayed in top right
Click to this button
Verify that: A dropdown is working fine

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/Expensify/App/assets/161821005/5b29a7f8-ba7d-453c-82ad-1473f55fee2d

Android: mWeb Chrome

https://github.com/Expensify/App/assets/161821005/bdc4908a-84e1-4588-bec9-09b03918c518

iOS: Native

https://github.com/Expensify/App/assets/161821005/cb7e6545-029f-4ec7-81fd-3a652ba39f70

iOS: mWeb Safari

https://github.com/Expensify/App/assets/161821005/c65c9e9f-d921-43ef-a110-f7302eadd14d

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/161821005/a647e174-8216-4734-bc4d-ee47c4375c59

MacOS: Desktop

https://github.com/Expensify/App/assets/161821005/52963750-bd14-4bb4-8ba3-1d78e0cb248a

@abdulrahuman5196 Please help to review the PR when you have a chance.

Hi, Got stuck. Will review within one day.

@nkdengineer lint is also failing

https://github.com/Expensify/App/assets/161821005/a7167d68-3dc3-49db-a8e2-8c77c77c7cf2
@luacmartins this is result when i use the new split button in the new SearchFiltersNarrow page
But it doesn't have left icon
What do you think?

Looks good, but we need the left icon too. Does this button not support that?

@luacmartins Currently, the button only supports the right icon and does not have logic support for left icon

Checking now

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

https://github.com/Expensify/App/assets/46707890/b6e750db-c1b2-4ede-8f7d-609ff2f7b53e

Android: mWeb Chrome

https://github.com/Expensify/App/assets/46707890/01341cc0-e92c-4e77-89a7-23024b6c80e3

iOS: Native

https://github.com/Expensify/App/assets/46707890/9be46312-50a1-4ce3-9e41-6c88ed315395

iOS: mWeb Safari

https://github.com/Expensify/App/assets/46707890/d90788a7-ca40-41ac-9e20-6a27b68218b1

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/46707890/c587d773-f2c3-4993-8bb7-3a96c3649169

MacOS: Desktop

https://github.com/Expensify/App/assets/46707890/f2a74ccf-e170-4dce-8553-beadcf880f45

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Cherry-picked to staging by https://github.com/francoisl in version: 1.4.67-7 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.4.68-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Cherry-picked to staging by https://github.com/francoisl in version: 1.4.67-7 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

🚀 Deployed to production by https://github.com/francoisl in version: 1.4.68-3 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Tetsing

Framwork
we could use the built-in unittest to keep with the current no depends, but I really like pytest.
when the tests have been setup they should be used with #8 as well.
I would be more than happy to write the tests

That would be cool. What do you think we should have tests for?
I don't have a strong preference about whether to use such dependencies or not. Either way would work imo.

everything? haha. add_from_class, methods added to CodeAnswers

I mean, sure thing. Unit tests are very nice 😄
We should probably wait for the package logic to move from the main file to init first, though. After that, I'm all for it.

I am fairly biased to pytest, I find it looks much cleaner.

Then I see no reason to use anything else. Let's go with PyTest!

great I can start work on it when #15 and #16 get merged

@vivax3794 we should be ready to start writing tests!
We're considering changing the way that answers are stored, but that shouldn't change the outputs of using the package in any way.
Thanks for helping out.


[CI/Build] Dockerfile.cpu improvements

use requirements-build.txt to install build requirements
use cache bind mounts to speed up builds
use ccache
build wheel and install it instead of using setup.py install

/ready

@bigPYJ1151 @zhouyuan does this look okay by you?


ERROR ON  yarn add<EMAIL_ADDRESS>

I get a similar error both when I build my elm project OR when I call " yarn add<EMAIL_ADDRESS>-- ERROR -----------------------------------------------------------------------
Something went wrong while fetching the following URL:
https://github.com/elm/compiler/releases/download/0.19.1/binary-for-windows-64-bit.gz
It is saying:
Error: connect ECONNREFUSED <IP_ADDRESS>:443

I cannot reproduce this. On macOS 10.15 the command yarn add<EMAIL_ADDRESS>works with no problem.
Is it possible that you have a company firewall? Something that would block requests to github from terminal commands?
Please share information about your OS. If you are running this on a work computer, do you get the same error running on a network outside of work? Etc.

@evancz thanks for the quick response. I eventually figured out that it was my dns that was acting up. I switched to the google dns and now all seems better. Sorry for the false issue. Keep up the good work.


Update @types/cheerio to 0.22.22 and fix tests

Breaking change in<EMAIL_ADDRESS>CheerioElement is now cheerio.Element :-(

Related to: #58


prevent DuckDuckGoSearchAPIWrapper from consuming top result

remove the next call that checks for None on the results generator

good catch @galtay, thanks for fix!


[WIP] Use Map.TryGetValue instead of Map.TryFind

this is based on #4827 by @dsyme and that PR needs to be accepted first.

Thanks for this PR, however it looks to be quite out of date, please reopen, if you want to continue with it.


fixed path of sw and resources & update document

I have pulled this project to my machine, when I finished start server and run. Service worker actually does nothing. So as my investigation, I saw that the path point to sw.js was wrong. I also update document to guild people to set up and run this example

I've tested this, and you are absolutely right! I'll merge this now. Also, sorry for taking so long to respond to this.

@chrisdavidmills Please confirm it.

OK, I know what's going on now. Your suggested changes broke the demo, because the paths were correct assuming the demo was being served from https://mdn.github.io/sw-test/.
If you want to serve the demo from somewhere else (e.g. localhost), you'll need to change the paths in the demo accordingly.
No harm done ;-)

I fixed it, BTW.

It's OK. Thanks.


Removing extra bracket in introduction docs

hmm seems that travis-ci is hanging...been waiting for ages for the check to clear. @mdo ?

@patrickhlauke I think it has just finished :)

Still showing me "continuous-integration/travis-ci — Waiting for status to be reported" ... until then i'm blocked from merging. ho hum, hopefully will shake itself out at some point and then i'll merge :)

@patrickhlauke strange, for me both on GitHub and on Travis page it's passed; but hopefully it'll resolve itself ;)

Travis is seriously broken sometimes. It doesn't even build this PR and we can't merge without it passing.
Only repo owners can, /CC @mdo.


[MB-16426] update prime simulator to include ability request sit address change request

Jira ticket
Summary
This PR adds the ability to create a SIT address change request via prime simulator
Verification Steps for the Author
These are to be checked by the author.

[x] Have the Jira acceptance criteria been met for this change?

Verification Steps for Reviewers
These are to be checked by a reviewer.
Setup to Run the Code

Instructions for starting storybook
Instructions for starting the MilMove application
Instructions for running tests

How to test

Login as a prime user
Access the DSTSIT move
Scroll to the service items section and click the update service items button
You should then be able to complete the form and verify the results in your DB and checking the move as a TOO

Frontend

[ ] There are no aXe warnings for UI.
[ ] This works in Supported Browsers and their phone views (Chrome, Firefox, Edge).
[ ] There are no new console errors in the browser devtools.
[ ] There are no new console errors in the test output.
[ ] If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.

Backend

[ ] Code follows the guidelines for Logging.
[ ] The requirements listed in Querying the Database Safely have been satisfied.

Database
Any new migrations/schema changes:

[ ] Follows our guidelines for Zero-Downtime Deploys.
[ ] Have been communicated to #g-database.
[ ] Secure migrations have been tested following the instructions in our docs.

Screenshots

Messages

:book:
:link: MB-16426

  Generated by :no_entry_sign: dangerJS against fad010f0ae34b2f3051bbf5b46425a1434cfde6f

I haven't fully dug into the why here, but I'm seeing something unexpected when I attempt to follow the instructions in the description above.

I tried both HHGMoveInSITEndsTomorrow and DSTSIT. This issue happened in both examples.
I went and clicked Update Service Items and got to new edit form named Request Destination SIT Address Change.
I went to edit the optional fields like Address 3 and Address 2, and the form immediately errors out with a red line on the left-side.
The Save button is also now disabled, as expected since the form is invalid.
When I go to reload the page, I see the following error in the DevTools console, TypeError: Cannot read properties of undefined (reading 'sitDestinationFinalAddress')  at PrimeUIUpdateServiceItems.jsx:31:28.

I'll see what I can do to further troubleshoot this as part of my review. But if you'd like to pair with me on that @ruizajtruss I'm up for it. Let me know in Slack or here. Thanks!


How to link dependencies through properties with filetree?

I'm trying to remove uses of dependsOn from my codebase, but I'm having trouble getting the task dependencies to link correctly.
Say I have an internal abstract val resDir: DirectoryProperty. The problem is, that directory is far too broad. So I now have to do this:
project.fileTree(resDir.file(PRODUCTS_PATH)).apply {
    include("*.json")
}

That loses the type information unfortunately, so the best solution I've come up with is to use builtBy(resDir).
Here's the end result to get more context:
@get:Internal
internal abstract val resDir: DirectoryProperty

@get:SkipWhenEmpty
@get:PathSensitive(PathSensitivity.RELATIVE)
@get:InputDirectory
protected val productsDir by lazy {
    project.fileTree(resDir.file(PRODUCTS_PATH)).apply {
        builtBy(resDir)
        include("*.json")
    }
}

Is there some way to express a subset of a directory with the property syntax and not lose dependency information?

Both Directory and DirectoryProperty have getAsFileTree() methods, which allow you to convert the directory (property) to a FileTree. So, you should be able to do something like:
resDir.map { it.dir(PRODUCTS_PATH).asFileTree.matching { include("*.json") } }

That works, thanks!


[BUG]Query support on flat_object field with dotted sub field names is unreliable

Describe the bug
I have an index with a field of type “flat_object,” and the JSON object for that field contains dotted sub-field names. I’m attempting to apply a term query using the entire key and value but it doesn't work as expected
To Reproduce
Steps to reproduce the behavior:

Create an index with mapping:

PUT /my-test-os-index
{
  "mappings": {
    "properties": {
      "transcript": {"type": "flat_object"}
    }
  }
}

Index a single document

POST my-test-os-index/_doc
{
  "transcript": {
    "one": "FAILED",
    "two.one": "FAILED",
    "three": "FAILED"
  }
}

Run a term query

POST my-test-os-index/_search
{
  "query": {
    "term": {"transcript.three": "FAILED"}
  }
}

The results are empty

Expected behavior
We expect the one indexed document to be returned cause it matches the criteria
Plugins
I am using OpenSearch 2.9
Host/Environment (please complete the following information):
Using OS serverless
Additional context
POST my-test-os-index/_search
{
  "query": {
    "term": {"transcript.one": "FAILED"}
  }
}

This query retrieves the document making the results order dependent and unreliable

Thanks for filing this issue


Urlencode bookmark URLs

When bookmarking a page with a 'tab' character in the URL, PocketGopher will crash on startup and not start again until app data is cleared. This is because the bookmarks file is tab delimited, and the extra field causes an exception from parseInt. To prevent raw tab characters from ending up in the bookmarks file, this PR calls url encode/decode before reading/writing urls to the bookmarks file. This is also backwards compatible since URLDecode ignores special characters that would normally be url-encoded, so old bookmarks still work.

Great work! I hope your fixes get merged.

Ug. Just had this happen. Is there anyway to save my book marks, or must I start over?

@softgenix As far as I can tell there are 2 conditions where it is possible:

You have root on your device

You are running a debug build of the app (ie, not from F-droid)

If either is true you can retrieve the bookmarks with ADB. If you have root and its enabled for ADB in developer settings, this prints your bookmarks to the command-line:
adb root && adb shell cat /data/data/com.gmail.afonsotrepa.pocketgopher/files/bookmarks
Same thing but for debug builds, this works on my device:
adb shell run-as com.gmail.afonsotrepa.pocketgopher cat /data/data/com.gmail.afonsotrepa.pocketgopher/files/bookmarks


Unable to write a simple blogpost using superagi

I want a customised blogpost which can research on internet & give well formating post, I am not posting anywhere, but still I am failing, please guide me, I am new to all this

Just a heads up, what you are asking is not something that should be asked here. You'll likely find a better response on SAGI's discord/slack/ etc. locations. Github issues are usually for more code related issues or feature requests etc.


Do you want a custom command-line command or a way to plot different mathematical functions ??
Well, that's my fault I haven't documented this repository. I'll try to start working on it soon.

My wording was probably clunky, I'll clarify.
I take it as a base function of a graphing calculator to take in and
graph many different graphs. I did not see any way to do such a thing,
even tho it was illustrated that it could by the sin(x) function.
Some way to plot different mathematical functions is what I want. I was
also unsure about whether there was no such feature or I just didn't
see it. That's why the wording is a mess.
,-'
On Sat, 7 May, 2022 at 10:32 am, Ishan Bawne @.***>
wrote:

I didn't get your question.
Do you want a custom command-line command or a way to plot different
mathematical functions ??
Well, that's my fault I haven't documented this repository. I'll try
to start working on it soon.
—
Reply to this email directly, view it on GitHub
https://github.com/ishanbawne20/Graphing_Terminal/issues/2#issuecomment-1120246826,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AXLTSD7KUBYL7XHFVIFDJM3VI2SL5ANCNFSM5VEG77IQ.
You are receiving this because you authored the thread.Message ID:
@.***>


Fix readme lists display

By adding a new line after images, broken lists are fixed!

Is this project still maintained?

ping @unicodeveloper

No answer, I close it!


Make dir a full accessor, as pagination.rb trys to access it

This allows pagination to occur below the top level of the site.

Page#dir already has an accessor method: https://github.com/mojombo/jekyll/blob/master/lib/jekyll/page.rb#L32-34


Not working on my MacBook Air

Hi John,
Thanks for your work. I've tried to download and installed the screen saver, the installation was successful, however, when I try to switch to it, it seems not working. As you can see in the attachment. Could you help to advise what is wrong with it?
Thanks!
Ming

Try this signed one: https://github.com/fwartner/Aerial/releases/tag/v1.1%40signed

@fwartner it's still can't use in my macbook pro 15.

@fwartner Same for me. Still not working.

@askming Did you get the screensaver working?

No. Not working.

@askming Have you tried the recent betas? https://github.com/JohnCoates/Aerial/releases/tag/v1.2beta5

@askming If they still don't work try the following URLs. If you're unable to view the movie at the following URLs then that most likely means a firewall or proxy is preventing you from accessing the movies on Akamai's servers.
http://a1.phobos.apple.com/us/r1000/000/Features/atv/AutumnResources/videos/b1-1.mov
http://a1.v2.phobos.apple.com.edgesuite.net/us/r1000/000/Features/atv/AutumnResources/videos/b1-1.mov

When I click or copy the link to browser it just starts to download it to my computer.

@askming Cool, that means the videos aren't being blocked. :)
Try 1.2b5 and see if it works for you.

Oh, it's working now! Great！

@askming Cool. Glad to hear it. :)
@devSC Did you get it working?

@alistairmcmillan Thanks for the great work!

@askming Not me. :) The screensaver is all @JohnCoates's work.

I see. Thank you both then :).


Issue loading gif

Hello,
When trying to load images this way:
LazyImage(source: $0) { state in     if let image = state.image {         image // Displays the loaded image     } else if state.error != nil {         Color.red // Indicates an error     } else {         Color.blue // Acts as a placeholder     } }
gif are not animated.
But it works with the simple call:  LazyImage(source: imageUrl, resizingMode: .aspectFill).
Any idea?

Fixed in 0.8.0


Feature/airquality

@dvdgeisler I just got some time to fiddle with my VINDSTYRKAs I got a few months ago (yes, they hid them somewhere in the Lights&Bulbs section). I've dumped some output and added some new models/apis for it already. The official release/sale is announced to begin in April ;-)
I think this won't be much of a heavy thing to investigate, as it seems we can only give it a customName and that's it. Just receiving data.
So essentially, what a VINDSTYRKA/environmentSensor seems to provide:

currentTemperature (in °C)
currentRH (relative humidity, %)
currentPM25 (fine particles, 2.5, seems to be in µg/m³)
maxMeasuredPM25 (seems to be the maximum to-be-reported PM25 value)
minMeasuredPM25 (... minimum to-be-reported)
vocIndex (tVoc which is only displayed using arrows on the device as a trend, unsure about the unit)

Btw. thanks for your library/implementation - works flawlessly and out of the box.
Well-defined and structured nicely. 👍

Might this be a device to also expose over the MQTT interface for integration with HA?

Sure, but I'm neither experienced with MQTT nor HA. This was just a quick shot at adding this type of sensor ;)


bug --queued

Currently, the queue can be created, but when executing the code, it runs immediately and not into the queue

Check if you are using redis or mysql as the queue driver

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

thanks


Add support for ember-source NPM package.

Update usage of ember-cli-version-checker to allow easier checking of Ember versions between ember bower package and ember-source npm package.

👍 thanks @rwjblue. I'm gonna go ahead and merge this and release a patch. Test failures are not related to this PR so I'll look into them when I get a chance.


Fix silently failing terminate() errors

Cell#shutdown failed while checking for a finalizer, because
PoolManager#respond_to?(meth, true) was not fully implemented.

@tarcieri - stubbing and checking Celluloid::Logger.crash seems very helpful (probably would help in other specs to detect other "silent" errors).
One build failed simply because because Travis ran out of available threads, and the PoolManager finalizer crashed.
I'm not sure how to best fix this though.

The test suite is flaky :frown:
It's passed on both Rubies at least once. Calling this good. Thanks!


where is the new update?

hello skin changer is not working rn

Wair for the official update, so that u won't comeback crying about your passwords/accounts.

Just wait

Wair for the official update, so that u won't comeback crying about your passwords/accounts.

Sheelia@960e671
If you download the official repo, and are capable of building it yourself you can just update the offset yourself and use it.

hey,
can you tell me what you mean with update the offset yourself! I dont really know much about it and would like to do it myself

Wair for the official update, so that u won't comeback crying about your passwords/accounts.

Sheelia@960e671
If you download the official repo, and are capable of building it yourself you can just update the offset yourself and use it.

hey, can you tell me what you mean with update the offset yourself! I dont really know much about it and would like to do it myself

there is an tutorial

Wair for the official update, so that u won't comeback crying about your passwords/accounts.

Sheelia@960e671
If you download the official repo, and are capable of building it yourself you can just update the offset yourself and use it.

hey, can you tell me what you mean with update the offset yourself! I dont really know much about it and would like to do it myself

there is an tutorial

can u send me it?


koku-metrics-operator v0.9.2

Signed-off-by: Michael Skarbek<EMAIL_ADDRESS>Thanks submitting your Operator. Please check below list before you create your Pull Request.
Updates to existing Operators

[x] Did you create a ci.yaml file according to the update instructions?
[x] Is your new CSV pointing to the previous version with the replaces property if you chose replaces-mode via the updateGraph property in ci.yaml?
[x] Is your new CSV referenced in the appropriate channel defined in the package.yaml or annotations.yaml ?
[x] Have you tested an update to your Operator when deployed via OLM?
[x] Is your submission signed?

Your submission should not

[x] Modify more than one operator
[x] Modify an Operator you don't own
[x] Rename an operator - please remove and add with a different name instead
[x] Submit operators to both upstream-community-operators and community-operators at once
[x] Modify any files outside the above mentioned folders
[x] Contain more than one commit. Please squash your commits.

Operator Description must contain (in order)

[x] Description about the managed Application and where to find more information
[x] Features and capabilities of your Operator and how to use it
[x] Any manual steps about potential pre-requisites for using your Operator

Operator Metadata should contain

[x] Human readable name and 1-liner description about your Operator
[x] Valid category name1
[x] One of the pre-defined capability levels2
[x] Links to the maintainer, source code and documentation
[x] Example templates for all Custom Resource Definitions intended to be used
[x] A quadratic logo

Remember that you can preview your CSV here.
--
1 If you feel your Operator does not fit any of the pre-defined categories, file an issue against this repo and explain your need
2 For more information see here

LGTM!

LGTM!

/ok-to-test

/ok-to-test

@J0zi while rebasing, the kubernetes-operator label was accidentally added. This label can be removed.

@J0zi while rebasing, the kubernetes-operator label was accidentally added. This label can be removed.

/retest

/retest

/test all


[5.7] Check that a specific error is missing

This will allow to check that a specific field has no error in tests.
My use case is the following.
I have a form with these fields
Label, With uploads, Upload label, Upload deadline
The Upload label and Upload deadline fields are only required when the With uploads checkbox is checked.
I have a test where i check that the required field validation is correct.
I'm checking that when the With uploads is not checked i should have no errors for Upload label, Upload deadline
        $response->assertSessionHasErrors(['label']);
        $response->assertSessionHasNoErrors(['presentation_label', 'presentation_upload_deadline']);

Of course this update does not introduce any breaking changes, if the $keys argument is empty we will just assert that there is no errors at all.
Also, i checked the FoundationTestResponseTest and found no existing tests about session error assertions. If you would like i can make another PR to add tests for all session assertions.

Made this a separate method. Made it match corresponding method.


Include version\tag\build in footer

Describe the solution you'd like
Grafana (for reference) does a pretty nice job of including some info on the build\version\tag that is currently running on the logon screen. Something similar on TaskCafe would be a nice little addon, so that we know what version we are using, especially right now while the project is in active dev.
Additional context

I have marked this task as a good first issue.
The first step would be to add build information during the build step in the magefile.go
A good article can be found here.
Then next step would be to create a GraphQL query that sends this information. This involves updating the gqlgen schema files. After updating the files you can use mage s to regenerate the schema.resolver.go implementation.

internal/graph/schema/_root.gql
internal/graph/schema.resolvers.go

That last step would be to add the info to the Auth component.

frontend/src/Auth/index.tsx

Hi, this would be my first time contribution to open source project .. can I take this ?

@sai-github Sure

@JordanKnott can I include the footer component under frontend/src/shared/components/footer ?

@sai-github I would probably place the component in frontend/src/Auth/Footer.tsx since it is only really should be used in the login module (at least for now).


Ability to create Local Secondary Index for AppSync Model table

Environment information
NA

Describe the feature
Currently we can only crease GSI for the data models in Amplify.

ChartOfAccount: a
    .model({
      orgId: a.id().required(),
      accountName: a.string().required(),
      accountDescription: a.string(),
      categoryName: a.string().required(),
      categoryType: a.string().required(),}) //ex: "INCOME", "EXPENSE", "ASSET",
    .identifier(["orgId", "accountName"])
    .secondaryIndexes((index) => [index("orgId").sortKeys(["categoryName"])])
    .authorization((allow) => [allow.owner()]),
});

There is no option to create Local Secondary Index for the model. Unable to update/add using the backend.ts as the table would be already created by then and the LSI should be created with the table.
Use case
To create and use Local Secondary Index for the data models in amplify.

Very important feature

Hey,👋 thanks for raising this! I'm going to transfer this over to our API repository for better assistance 🙂


Added Classification_titanic_dataset.ipynb

Description
(Write your answer here.)
Checklist

[ ] I am making a proper pull request, not spam.
[ ] I've checked the issue list before deciding what to submit.

Related Issues or Pull Requests
(Write your answer here.)
Add relevant screenshot or video (if any)
(Add here)

@varun290101 please refer to the issues and then add PRs. We already have a starter notebook that uses Titanic Dataset. and add a line Contributes to issue #<issue_number>.  I have not assigned you to any issue. Please follow the rules.


apparmor-utils: fix aa-remove-unknown read check

let aaru = "aa-remove-unknown"; in
aaru tests whether /sys/kernel/security/apparmor/profiles can be opened. Even though the file's permissions usually are 0444, open() still might return EPERM, as this is a virtual filesystem.  Thus, using test -r doesn't suffice for this check.
What aaru does to solve this is (approximately)
  if ! read … < /sys/kernel/security/apparmor/profiles; then
    echo "Meh";
  fi

In principal this works just fine.  When looking closer, it doesn't (which is the root cause of #273164).  Careful readers will notice that the actual access check (for open()) isn't actually related to the read invocation, but the shell's input redirection, which works totally fine:
If the file can't be opened, the shell will return an error and the test fails.  read won't even be invoked.  The culprit is, the read shell builtin might potentially jeopardize the successful test result (open() succeeding): When no profiles are loaded, the file will be empty and read will return 1 for EOF.
As the if's command is only invoked after the actual test succeeded, true is the command of choice here.
I would prefer fixing this upstream, but I refuse to register an account there because GitLab.com wants me to validate an email address (sure), a phone number (why?) and a valid payment method ([redacted]).
This fixes #273164 (»Apparmor service fails to start after nixos-rebuild switch«).
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[x] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Wow. Amazing bug and innovative use of true to workaround :) I will test it out and report back. This is a much better solution than the workaround I proposed at the systemd-level.

This needs to go to staging.

This needs to go to staging.

So I did as described in the contributions guide.  I hope I pinged nobody unrelated, this is a first for me. :see_no_evil:

Is there anything else I can or should do to get this merged?  Sorry for the maybe stupid question, but I'm not very familiar with the staging workflow and a bit puzzled of what the current status is and what to expect (and when) at this stage.

Is there anything else I can or should do to get this merged? Sorry for the maybe stupid question, but I'm not very familiar with the staging workflow and a bit puzzled of what the current status is and what to expect (and when) at this stage.

Now the PR needs a committer to get merged (which I'm not), I guess we can ping one that previously merged apparmor-related PR, like @ajs124, add thumbs up on the first message, add the awaiting_merger label, and raise attention on the discourse.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-already-reviewed/2617/1474

This hasn't hit nixos-unstable yet. See https://nixpk.gs/pr-tracker.html?pr=285915.


Update rectangular_lsap.cpp

What does this implement/fix
"set-complements" (with hyphen), and "coefficients" is one word.

Hi @corey53w53, thank you for the PR.
I am afraid we don't encourage PRs only fixing typos. This generate lot of noise for us maintainers as it requires the same attention as any other PRs. We do accept such changes when they are linked to larger work such as reworking of a paragraph, adding of examples, etc. There are lots of other opportunities for contributing documentation improvements 😃
Again, thank you and I am sorry I have to close this PR.


wireless/wapi: fix wapi wpa_wconfig_s alg data type error

Summary
Correct the alg field type of the wpa_wconfig_s structure, which may cause an unaligned access exception.
Impact
None
Testing
None

@Virus-V please "Remove Gerrit Change-ID's before submitting upstream".

@Virus-V please "Remove Gerrit Change-ID's before submitting upstream".

Done.


MG+MIS Review

Hi Dr. Smith,
This was a tough one. Here's goes for my best attempt 😅

MG.pdf
MIS.pdf

Cheers!

@joedf my feedback is attached.
MG_Fdbck.pdf
MIS_Fdbck.pdf


Remove redundant English section after translation

This commit removes a section in English that has already been translated.

Hello! Thank you for opening your first PR to Astro’s Docs! 🎉
Here’s what will happen next:

Our GitHub bots will run to check your changes.
If they spot any broken links you will see some error messages on this PR.
Don’t hesitate to ask any questions if you’re not sure what these mean!

In a few minutes, you’ll be able to see a preview of your changes on Vercel 🥳

One or more of our maintainers will take a look and may ask you to make changes.
We try to be responsive, but don’t worry if this takes a few days.


Checkboxes are picky about location of labels, toggle stops working, checkbox hidden

Found an old issue for this, but i'm still having the problem.
https://github.com/Semantic-Org/Semantic-UI/issues/2457
I'm also having issues when i leave out the label.
The example should be clear enough to explain the issues i'm having.
http://jsfiddle.net/zebqz16s/
Let me know if any more information is needed.

Same as described here: https://github.com/Semantic-Org/Semantic-UI/issues/3659

There is only a "next sibling" selector in CSS, no "previous sibling". So we cant handle label before input without javascript.
To fix, simply initialize the JS module which will handle this use case.
http://jsfiddle.net/pj77x6m3/


DS-3308 more doclint fixes

https://jira.duraspace.org/browse/DS-3308
Work in progress.

doclint fixes
whitespace fixes
disables doclint to be able to see the issues [temporary]

If you want to review, use this link to ignore whitespace changes:
https://github.com/DSpace/DSpace/pull/1562/files?w=1

Cherry-picked 042a4f9 and 6d8f8ac to master. Closing.


WIP - remove indices in associative arrays if they are all integers

As discussed, this won't work if we have an array of integer values, like entities.