Ammy Compilation Error

I receive this error when attempting to build with Ammy files in a solution.  The issue appears to occur when a 32 bit dll is referenced in a solution that has a configuration of Any CPU.
2>(1,1,1,1): error : Ammy compilation error: System.NullReferenceException: Object reference not set to an instance of an object.
2>(1,1,1,1): error :    at Ammy.Language.Start.GetPublicStaticProperties(TypeSymbol ts)
2>(1,1,1,1): error :    at Ammy.Language.Start.PrepareScopes(NamespaceSymbol rootNamespace, AmmyDependentPropertyEvalContext context)
2>(1,1,1,1): error :    at Ammy.Language.Start.RefreshReferences(Project project)
2>(1,1,1,1): error :    at Ammy.Language.Start.RefreshReferences(CancellationToken _cancellationToken, Project project)
2>(1,1,1,1): error :    at Ammy.Build.AmmyProject.RefreshReferences()
2>(1,1,1,1): error :    at Ammy.Build.AmmyCompiler.Compile(AmmyProject project, Boolean generateMetaFile, Boolean needBamlGeneration, Boolean needUpdate)

Thanks, I will get to it as soon as possible.

Is it possible for you to send me dll in question? I've compiled 32 bit assembly, checked that it indeed requires 32bit, but Ammy still compiles fine after referencing it.
Also, is host project WPF? Seems like some types were not loaded, like System.Windows.Media.Brushes etc.

Would you be able to send me copy of your project? With all sources removed of course, since I only need configuration.

Yes, the dll causing issues is LeadTools.  An evaluation copy can be downloaded from https://www.leadtools.com/downloads?category=mm.
Here is the error with LeadTools included in the project.  I had removed LeadTools from the solution when I sent the earlier error, and I was getting it from another project.
1>  All packages listed in C:\git\aceclient\CapitalGroup.Afsd.Desktop\packages.config are already installed.
1>(1,1,1,1): error : Ammy compilation error: System.IO.FileLoadException: Could not load file or assembly 'Leadtools.Barcode, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=9cf889f53ea9b907' or one of its dependencies. Attempt to load an unverifiable executable with fixups (IAT with more than 2 sections or a TLS section.) (Exception from HRESULT: 0x80131019)
1>(1,1,1,1): error : File name: 'Leadtools.Barcode, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=9cf889f53ea9b907' ---> System.IO.FileLoadException: Attempt to load an unverifiable executable with fixups (IAT with more than 2 sections or a TLS section.) (Exception from HRESULT: 0x80131019)
1>(1,1,1,1): error :    at System.Reflection.RuntimeAssembly.nLoadImage(Byte[] rawAssembly, Byte[] rawSymbolStore, Evidence evidence, StackCrawlMark& stackMark, Boolean fIntrospection, SecurityContextSource securityContextSource)
1>(1,1,1,1): error :    at System.Reflection.Assembly.Load(Byte[] rawAssembly)
1>(1,1,1,1): error :    at Ammy.Backend.ReflectionBackend.LoadExternalSymbols(IEnumerable`1 libs, String libPath, ICompilerMessages compilerMessages, DependentPropertyEvalContext context)
1>(1,1,1,1): error :    at Ammy.Language.Start.RefreshReferences(Project project)
1>(1,1,1,1): error :    at Ammy.Language.Start.RefreshReferences(CancellationToken _cancellationToken, Project project)
1>(1,1,1,1): error :    at Ammy.Build.AmmyProject.RefreshReferences()
1>(1,1,1,1): error :    at Ammy.Build.AmmyCompiler.Compile(AmmyProject project, Boolean generateMetaFile, Boolean needBamlGeneration, Boolean needUpdate)
1>(1,1,1,1): error :
1>(1,1,1,1): error :
1>C:\git\aceclient\packages\Ammy.1.1.8\build\Ammy.targets(15,5): error : Ammy compilation failed

The error I sent previously I received after I removed LeadTools from the solution, and it was stopping on x86 projects and my Windows Installer XML project.

I've added some error checking to backend. Could you try if it works for you now?
Just copy Ammy.Backend.dll to packages\Ammy.1.1.*\build\
Ammy.Backend.zip

Yes, working on it.  I'll get back to you in a few hours.

Seems like an issue with an indirectly referenced assembly. I've modified assembly resolver to accommodate for that. It works in my test cases. Please test it in your configuration.
Ammy.Backend.zip

Better.  I get this error now:
1>(1,1,1,1): error : Ammy compilation error: System.ComponentModel.Win32Exception (0x80004005): The filename or extension is too long
1>(1,1,1,1): error :    at System.Diagnostics.Process.StartWithCreateProcess(ProcessStartInfo startInfo)
1>(1,1,1,1): error :    at System.Diagnostics.Process.Start()
1>(1,1,1,1): error :    at Ammy.Build.BamlCompiler.CompileBamlFiles(CompileResult result, AmmyProject project)
1>(1,1,1,1): error :    at Ammy.Build.AmmyCompiler.Compile(AmmyProject project, Boolean generateMetaFile, Boolean needBamlGeneration, Boolean needUpdate)
1>C:\git\aceclient\packages\Ammy.1.1.8\build\Ammy.targets(15,5): error : Ammy compilation failed

Could you copy build output from Output window?
It needs to be setup for verbose output:
Tools > Options > Projects and Solutions > Build and Run > MSBuild project build output verbosity: Diagnostic
Sorry you encountered so many issues. Your report already helped to resolve two of them, so thank you!

You can send build output to<EMAIL_ADDRESS>if you can't to post it publicly. Thanks!

Yes.  I'll get it to you tomorrow.  I've been in meetings all day.

Any news? Also, please update to latest version from MyGet
Nuget V3: https://www.myget.org/F/ammy/api/v3/index.json
Nuget V2: https://www.myget.org/F/ammy/api/v2
Add it to Options -> Nuget Package Manager -> Package Sources
Don't forget to click Update button there.
After that just switch Package Manager source to this new feed and update-package Ammy. You might need to restart visual studio, since it uses assemblies from a package.

Okay.  Updated to Ammy 1.1.19.
Here is the output when i try to compile the project.  I changed the project name to be different but to have the same length of the actual name.
1>------ Build started: Project: Abcdefghijkl.Abcd.Desktop, Configuration: Debug Any CPU ------
1>  Restoring NuGet packages...
1>  To prevent NuGet from downloading packages during build, open the Visual Studio Options dialog, click on the Package Manager node and uncheck 'Allow NuGet to download missing packages'.
1>  Feeds used:
1>    C:\Users\abcd\AppData\Local\NuGet\Cache
1>    C:\Users\abcd.nuget\packages
1>    https://api.nuget.org/v3/index.json
1>
1>  All packages listed in C:\git\abcclient\Abcdefghijkl.Abcd.Desktop\packages.config are already installed.
1>(1,1,1,1): error : Ammy compilation error: System.ComponentModel.Win32Exception (0x80004005): The filename or extension is too long
1>(1,1,1,1): error :    at System.Diagnostics.Process.StartWithCreateProcess(ProcessStartInfo startInfo)
1>(1,1,1,1): error :    at System.Diagnostics.Process.Start()
1>(1,1,1,1): error :    at Ammy.Build.BamlCompiler.CompileBamlFiles(CompileResult result, AmmyProject project)
1>(1,1,1,1): error :    at Ammy.Build.AmmyCompiler.Compile(AmmyProject project, Boolean generateMetaFile, Boolean needBamlGeneration, Boolean needUpdate)
1>C:\git\abcclient\packages\Ammy.1.1.19\build\Ammy.targets(15,5): error : Ammy compilation failed
========== Build: 0 succeeded, 1 failed, 1 up-to-date, 0 skipped ==========

Can you try compiling using updated Ammy.Build.dll? It will output a warning with full path and arguments to bamlcwpf.exe
Thanks!
Ammy.Build.zip

I emailed you the output.

Sorry for taking so long!
It was an issue with windows not able to handle really long command line arguments. I resolved it by writing arguments into file and using that as a source.
New version is uploaded to NuGet, please check if it finally resolves your issue.
Thanks for your patience :)

Great!  I'll test it this afternoon.

The latest version I see is still 1.1.19.

You will have to use MyGet feed as I have described earlier. I will put it on NuGet as soon as it's confirmed working.
Here are instructions for configuring MyGet feed:
Nuget V3: https://www.myget.org/F/ammy/api/v3/index.json
Nuget V2: https://www.myget.org/F/ammy/api/v2
Add it to Options -> Nuget Package Manager -> Package Sources
Don't forget to click Update button there.
After that just switch Package Manager source to this new feed and update-package Ammy. You might need to restart visual studio, since it uses assemblies from a package.

Better :).  I now see this error.
1>(1,1,1,1): error : Ammy compilation error: Nemerle.Core.AssertionException: assertion failed in file Type\Member\Member.nitra, line 83: Property 'DotNet.Member.PropertySymbol.Type' is not set'
1>(1,1,1,1): error :    at DotNet.Member.PropertySymbol.get_Type()
1>(1,1,1,1): error :    at Ammy.Backend.XamlSymbolLoader.LoadType(SupportsInheritanceTypeSymbol type, TypeSymbol objectType, DependentPropertyEvalContext context, PlatformTypeNames platformTypeNames)
1>(1,1,1,1): error :    at Ammy.Backend.CSharpBackend._N_registerParsedTypes_12541(_N_closureOf_Load_12499 _N_Load_cp_12540, TableScope tableScope)
1>(1,1,1,1): error :    at Ammy.Backend.CSharpBackend._N_registerParsedTypes_12541(_N_closureOf_Load_12499 _N_Load_cp_12540, TableScope tableScope)
1>(1,1,1,1): error :    at Ammy.Backend.CSharpBackend._N_registerParsedTypes_12541(_N_closureOf_Load_12499 _N_Load_cp_12540, TableScope tableScope)
1>(1,1,1,1): error :    at Ammy.Backend.CSharpBackend._N_registerParsedTypes_12541(_N_closureOf_Load_12499 _N_Load_cp_12540, TableScope tableScope)
1>(1,1,1,1): error :    at Ammy.Backend.CSharpBackend._N_registerParsedTypes_12541(_N_closureOf_Load_12499 _N_Load_cp_12540, TableScope tableScope)
1>(1,1,1,1): error :    at Ammy.Backend.CSharpBackend._N_registerParsedTypes_12541(_N_closureOf_Load_12499 _N_Load_cp_12540, TableScope tableScope)
1>(1,1,1,1): error :    at Ammy.Backend.CSharpBackend.Load(ISourceCodeProject project, NamespaceSymbol globalNamespace, TypeSymbol objectType, PlatformTypeNames platformTypeNames, DependentPropertyEvalContext context)
1>(1,1,1,1): error :    at Ammy.Language.Start.RefreshProject(CancellationToken _cancellationToken, ImmutableArray`1 files, Object data)
1>(1,1,1,1): error :    at Ammy.Build.AmmyProject.RefreshProject(String outputPath, String rootNamespace, String assemblyName)
1>(1,1,1,1): error :    at Ammy.Build.AmmyCompiler.Compile(AmmyProject project, Boolean generateMetaFile, Boolean needBamlGeneration, Boolean needUpdate)
1>C:\git\abcclient\packages\Ammy.1.1.25\build\Ammy.targets(15,5): error : Ammy compilation failed

Alright, I've updated it again, try it once more, please :)

It now compiles.  Thank you for being so responsive in resolving these issues!


support SignalR

Expected Behavior / New Feature
SignalR websockets can be successfully rerouted with Ocelot
Actual Behavior / Motivation for New Feature
Fails on the handshake due to inability to map websockets and xhr requests for the same upstream url
Steps to Reproduce the Problem

Clone https://github.com/cristianiorga/OcelotSignalRTest

Start DummySignalR

Start APIGatewayTest

Start DummySignalRClient
Expected: logs dummy test message to console
Actual: cannot enstablish connection

Open DummySignalRWebClient.html in browser
Expected: logs dummy test message to browser console
Actual: cannot establish connection

Browser network log:

Detailed error:

How a successfull handshake looks like:

Specifications

Version: 6.0.0
Platform: Windows
Subsystem: Windows 10 Enterprise 64 bit

Notes:
In order to have a successful handshake with SignalR not only the websocket has to be rerouted.

@TomPallister SignalR will be part of the .NET Core 2.1 release coming mid-2018. You can read more about that at https://blogs.msdn.microsoft.com/webdev/2018/02/02/asp-net-core-2-1-roadmap/ , https://blogs.msdn.microsoft.com/webdev/2018/02/27/asp-net-core-2-1-0-preview1-getting-started-with-signalr/ and https://github.com/aspnet/SignalR/milestones
Currently there is a .NET Core 2.1 Developer preview for SignalR and is that one I used in this issue.
I believe that this would be a great feature for Ocelot and I would be willing to help if you can plan and coordinate the work.

I am building a mobile app using Ionic, when I test it on mobile  signalR and ocelot work perfectly, the only problem i have is when testing on the browser. It brings an error i believe could be as result of cors but i can't solve it. here is the error
Failed to load resource: the server responded with a status of 405 (Method Not Allowed)
?ionicplatform=android&http://localhost:8100/ionic-lab&http://localhost:8100/ionic-lab&http://localhost:8100/ionic-lab#/products:1 Failed to load http://myIp/NotificationHub/negotiate: Response to preflight request doesn't pass access control check: No 'Access-Control-Allow-Origin' header is present on the requested resource. Origin 'http://localhost:8100' is therefore not allowed access. The response had HTTP status code 405.

my configuration is as follows
{
"DownstreamPathTemplate": "/NotificationHub/negotiate",
"UpstreamPathTemplate": "/NotificationHub/negotiate",
"DownstreamScheme": "http",
"DownstreamHostAndPorts": [
{
"Host": "servicename",
"Port": 80
}
],
"UpstreamHttpMethod": ["Options", "Post" ]
},
{
  "DownstreamPathTemplate": "/NotificationHub",
  "UpstreamPathTemplate": "/NotificationHub",
  "DownstreamScheme": "http",
  "DownstreamHostAndPorts": [
    {
      "Host": "servicename",
      "Port": 80
    }
  ],
  "UpstreamHttpMethod": [ "Options", "Get", "Post" ]

},

public void ConfigureServices(IServiceCollection services)
{
services.AddCors(options =>
{
options.AddPolicy("CorsPolicy",
builder => builder
.WithOrigins("http://localhost:8100")
.AllowAnyMethod()
.AllowAnyHeader()
.AllowCredentials()
);
});
services.AddMvc();
}
    // This method gets called by the runtime. Use this method to configure the HTTP request pipeline.
    public void Configure(IApplicationBuilder app, IHostingEnvironment env)
    {
        if (env.IsDevelopment())
        {
            app.UseDeveloperExceptionPage();
        }
        app.UseCors("CorsPolicy");
        app.UseMvc();
    }

@ogomaemmanuel it is probably the same problem as @cristianiorga mentioned to open this ticket. I have not had time to look into the issue yet I'm afraid. I cannot give a time frame either. Maybe I will have time in the next few months. If you want to help out I would suggest forking the Ocelot repository and debugging the code to see whats going on. I'm more than happy to accept PRs and give advice.

@cristianiorga APIGatewayTest project will be changed.
ocelot.json
{   "ReRoutes": [     {       "DownstreamPathTemplate": "/dummy",       "DownstreamScheme": "ws",       "DownstreamHostAndPorts": [         {           "Host": "localhost",           "Port": 50000         }       ],       "UpstreamPathTemplate": "/api/dummy"     },     {       "DownstreamPathTemplate": "/dummy/negotiate",       "DownstreamScheme": "http",       "DownstreamHostAndPorts": [         {           "Host": "localhost",           "Port": 50000         }       ],       "UpstreamPathTemplate": "/api/dummy/negotiate"     }   ],   "GlobalConfiguration": {     "BaseUrl": "http://localhost",     "AdministrationPath": "/administration",     "RequestIdKey": "OcRequestId"   } }
and Program.cs
.Configure(app =>             {                 app.UseWebSockets();                 app.UseOcelot().Wait();             })
you can try. I get the same result as DummySignalR

from #524
Expected Behavior / New Feature
We are using ocelot with the feature websockets. We are using Signalr Core and trying to forward it to the correct server. With that we are using headers on the requests.
The headers disappear once it goes through ocelot. Is this on purpose?
We verified that the headers will be send to the signalr server when it doen't use ocelot.
Config:
"ReRoutes": [{
"DownstreamPathTemplate": "/{catchAll}",
"DownstreamScheme": "ws",
"DownstreamHostAndPorts": [
{
"Host": "localhost",
"Port": 5000
}
],
"UpstreamPathTemplate": "/gateway/{catchAll}",
"UpstreamHttpMethod": [ "GET", "POST", "PUT", "DELETE", "OPTIONS" ]
}]
Actual Behavior / Motivation for New Feature
The headers are being forwarded with the websockets
Steps to Reproduce the Problem
Start a signalr core server
Configure ocelot as described in http://ocelot.readthedocs.io/en/latest/features/websockets.html
Connect a client throuh ocelot and send a header with it.
Check the headers received on the server
Specifications
Version: 8.0.2
Platform: Windows 10
Subsystem: Microsoft.AspNetCore.SignalR.Client 1.0.1

I created a pull request to add headers to the request.
With the following templates it works:
Target framework: 2.1.2
Microsoft.AspNetCore.SignalR.Client 1.0.2
Ocelot develop with my pull-request
 public class Program
    {
        public static void Main(string[] args)
        {
            var webHost = WebHost.CreateDefaultBuilder(args)
                .UseStartup<Startup>()
                .UseIISIntegration()
                .Build();

            webHost.Run();
        }
    }

    public class Startup : IStartup
    {
        public IConfiguration Configuration { get; }

        public Startup(IHostingEnvironment env)
        {
            var builder = new ConfigurationBuilder()
                .SetBasePath(env.ContentRootPath)
                .AddJsonFile("ocelot.json")
                .AddEnvironmentVariables();

            Configuration = builder.Build();
        }

        public IServiceProvider ConfigureServices(IServiceCollection services)
        {
            services.AddOcelot(Configuration);
            return services.BuildServiceProvider();
        }

        public void Configure(IApplicationBuilder app)
        {
            app.UseWebSockets();
            app.UseOcelot().Wait();
        }
    }

ocelot.json
{
  "ReRoutes": [
    {
      "DownstreamPathTemplate": "/{catchAll}",
      "DownstreamScheme": "ws",
      "DownstreamHostAndPorts": [
        {
          "Host": "localhost",
          "Port": 50000
        }
      ],
      "UpstreamPathTemplate": "/gateway/{catchAll}",
      "UpstreamHttpMethod": [ "GET", "POST", "PUT", "DELETE", "OPTIONS" ]
    }
 ]
}

Just released in 8.0.7

Hi, sorry to ask as it may be a stupid question but i don't really get how it fix the original issue "Fails on the handshake due to inability to map websockets and xhr requests for the same upstream url".
For the http(s) negociate part, should be still add an http(s) DownstreamScheme plus a ws DownstreamScheme for the same route ?

hi, there's no typo here?

Hi, It works fine for me, but when I try to balance the SignalR API, the connection doesn't work, it returns 404 error. This is my configuration:
{
"DownstreamPathTemplate": "/Hubs/{everything}",
"DownstreamScheme": "ws",
"ServiceName": "OrderApi",
"UpstreamPathTemplate": "/Hubs/{everything}",
"LoadBalancerOptions": {
"Type": "CookieStickySessions",
"Key": "ASP.NET_SessionId",
"Expiry": 1800000
},
"UpstreamHttpMethod": [ "Get", "Post", "Put", "Delete", "Options" ],
"QoSOptions": {
"TimeoutValue": 120000
}
},
The requests have been resolved by different instances of the API:
info: Ocelot.Authorisation.Middleware.AuthorisationMiddleware[0]
requestId: 0HM8OONQSHKOU:00000007, previousRequestId: no previous request id, message: /Hubs/{everything} route does not require user to be authorised
info: Ocelot.Requester.Middleware.HttpRequesterMiddleware[0]
requestId: 0HM8OONQSHKOU:00000007, previousRequestId: no previous request id, message: 200 (OK) status code, request uri: ws://localhost:5000/Hubs/OrderHub/negotiate?negotiateVersion=1
info: Ocelot.RateLimit.Middleware.ClientRateLimitMiddleware[0]
requestId: 0HM8OONQSHKOU:00000008, previousRequestId: no previous request id, message: EndpointRateLimiting is not enabled for /Hubs/{everything}
info: Ocelot.Authentication.Middleware.AuthenticationMiddleware[0]
requestId: 0HM8OONQSHKOU:00000008, previousRequestId: no previous request id, message: No authentication needed for /Hubs/OrderHub
info: Ocelot.Authorisation.Middleware.AuthorisationMiddleware[0]
requestId: 0HM8OONQSHKOU:00000008, previousRequestId: no previous request id, message: /Hubs/{everything} route does not require user to be authorised
warn: Ocelot.Requester.Middleware.HttpRequesterMiddleware[0]
requestId: 0HM8OONQSHKOU:00000008, previousRequestId: no previous request id, message: 404 (Not Found) status code, request uri: ws://localhost:5080/Hubs/OrderHub?id=6FDYdEFYgnV3lQ_xluR9ZA&_=1621209543544


Use better caching action in github actions

This removes the manual configuration and uses an action that does it automatically.

Great, does this have a testing effect?

It shouldn't, it should just be quicker

lgmt


Issue 1

Closes #1

Need to solve this related issue:
2022-07-15 18:04:17,898 : netban.banmanager[15207] : DEBUG :: Received request to unban ip <IP_ADDRESS>.                                                                                ipset v6.38: Element cannot be deleted from the set: it's not added Task exception was never retrieved future: <Task finished coro=<NetBanLocalFile.processExpiry() done, defined at /home/alex/Developer/netban/netban/local/__init__.py:57> exception=AssertionError('Removing <IP_ADDRESS> from netbanlocal set failed.')> Traceback (most recent call last):   File "/home/alex/Developer/netban/netban/local/__init__.py", line 68, in processExpiry     await self.ban_manager.unban(ip)   File "/home/alex/Developer/netban/netban/__init__.py", line 149, in unban     assert r == 0, "Removing %s from netbanlocal set failed." % ip AssertionError: Removing <IP_ADDRESS> from netbanlocal set failed.


0.65.0 Style/TrailingCommaInArguments wants to add comma after heredoc

I've got a scenario where the test Style/TrailingCommaInArguments wants to add a comma after the start of a heredoc.  This is not the same as #6629
Given the following ruby:
class CommaExample
  def self.prefix(first, second)
    puts "#{first}, #{second}"
  end

  def self.message
    prefix('This is',
           <<~MSG
             a message
           MSG
          )
  end
end

running rubocop returns
rubocop comma_example.rb
Inspecting 1 file
C

Offenses:

comma_example.rb:8:12: C: Style/TrailingCommaInArguments: Put a comma after the last parameter of a multiline method call.
           <<~MSG
           ^^^^^^

1 file inspected, 1 offense detected

Expected behavior
I would not expect this style violation to trigger!
Actual behavior
Rubocop expects a ',' after the message e.g. <<~MSG,
  def self.message
    prefix('This is',
           <<~MSG,
             a message
           MSG
          )
  end

Steps to reproduce the problem
See the example code above
RuboCop version
rubocop --version
0.65.0

Same goes for plain SQL block:
<<-SQL
snip
SQL

Related to https://github.com/rubocop-hq/rubocop/issues/6701 cc @abrom

Not sure why you believe this is an error!? The message is:
Style/TrailingCommaInArguments: Put a comma after the last parameter of a multiline method call.

It's saying your configuration expects to see a comma after the last parameter. The heredoc is the last parameter, thus there should be a comma.
I'm guessing you've overridden the EnforcedStyleForMultiline configuration to either comma or consistent_comma ??
https://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Style/TrailingCommaInArguments

@abrom Should it not put the comma after the heredoc? (i.e. it should correctly recognize where heredoc ends)
Actual
    prefix('This is',
           <<~MSG,
             a message
           MSG
          )

Expected
    prefix('This is',
           <<~MSG
             a message
           MSG,
          )

No, your expected code block is invalid Ruby. The closing heredoc tag must be the only thing on the line. The comma should be after <<~MSG as Rubocop is suggesting (given the supposed configuration and provided code example).

I'm experiencing this issue as well.
<<~SQL
  SELECT *
  FROM web_ingress.locations
  ORDER BY id
  LIMIT 10000
  OFFSET 0;
SQL

is being corrected to the following (which is invalid SQL)
<<~SQL,
  SELECT *
  FROM web_ingress.locations
  ORDER BY id
  LIMIT 10000
  OFFSET 0;
SQL

@nhippenmeyer I cannot reproduce that issue with the latest RuboCop (1.10.0). If the latest RuboCop can reproduce it, can you open a new issue?

the trailing comma won't be included in the HEREDOC SQL string @nhippenmeyer. What of the SQL is invalid?

@koic I'm running RuboCop v1.10.0 so will open a new issue.
@abrom I misspoke. The problem isn't that the generated SQL string is invalid, but rather the trailing comma on the first line of the heredoc produces a ruby syntax error.
Running the following query.rb file results in the error: query.rb:1: syntax error, unexpected end-of-input
query=<<~SQL,
SELECT *
FROM web_ingress.locations
ORDER BY id
LIMIT 10000
OFFSET 0;
SQL

@koic I'm running RuboCop v1.10.0 so will open a new issue for this.
@abrom I misspoke. The problem is not that the generated SQL string is invalid, but rather the trailing comma on the first line of the heredoc produces a ruby syntax error.
Running the following query.rb file
def query(limit)
  <<~SQL,
    SELECT *
    FROM web_ingress.locations
    ORDER BY id
    LIMIT #{limit}
    OFFSET 0;
  SQL
end

puts query(0)

Results in the error:
query.rb:2: syntax error, unexpected ',', expecting `end'
  <<~SQL,
query.rb:11: syntax error, unexpected end-of-input, expecting `end'

I'm confirmed this is no longer an issue in the latest version of RuboCop. Apologies for the false alarm.


Add a Collector that can write to files

At the moment there are plenty of ways to alter the datastream once received (forwards) but none to write the result to a file.
Besides the forwards (AbstractForward as base) there are also collectors (AbstractCollector as base, current once are BufferCollector used for emails, ConfirmCollector to check for reply).
So the goal is to implement a collector that allows:

Custom header
Flush on time, buffered size, schedule (similar to SQLite at the moment)
Name with variable parts (fe.data/time)
allow triggers (fe. x time nothing written etc)

Another option might have been to use TinyLog for this, but this doesn't allow all the goals.

0.9.7 contains a first implementation, functional but currently limited to:

setup only possible in xml, no telnet interface yet
flushing data based on either age or amount of messages received
fixed path

Finished in 0.9.8


append BW-CHILD VOLUME_INFO to call number for boundwith parts folio holding

The boundwith parts folio holding.callNumber field should be the concatenation of the fields BASE_CALL_NUM and VOLUME_INFO from the bwchild tsv.
https://github.com/sul-dlss/libsys-airflow/blob/6a6bb9edc5ef9185d04f6a3f8caaf3f30fb9d259/libsys_airflow/plugins/folio/holdings.py#L491-L504

Hmm, also, the callNumberTypeId will not always be LCC. For instance:

CATKEY
CALL_SEQ
COPY
BARCODE
LIBRARY
HOMELOCATION
CURRENTLOCATION
ITEM_TYPE
ITEM_CAT1
ITEM_CAT2
ITEM_SHADOW
PIECES
CALL_NUMBER_TYPE
BASE_CALL_NUMBER
VOLUME_INFO
CALL_SHADOW
FORMAT
CATALOG_SHADOW

14717798
1
1
36105119552862
GREEN
SEE-OTHER
SEE-OTHER
GOVSTKS
BW-CHILD

0
1SUDOC
S 1.70:83

0
MARC
0

Hmm, also, the callNumberTypeId will not always be LCC. For instance:
CATKEY	CALL_SEQ	COPY	BARCODE	LIBRARY	HOMELOCATION	CURRENTLOCATION	ITEM_TYPE	ITEM_CAT1	ITEM_CAT2	ITEM_SHADOW	PIECES	CALL_NUMBER_TYPE	BASE_CALL_NUMBER	VOLUME_INFO	CALL_SHADOW	FORMAT	CATALOG_SHADOW
14717798	1	1<PHONE_NUMBER>2862	GREEN	SEE-OTHER	SEE-OTHER	GOVSTKS	BW-CHILD		0	1	SUDOC	S 1.70:83		0	MARC	0

Nevermind, I interpreted this incorrectly:
constants.call_number_codes.get(
         row["CALL_NUMBER_TYPE"], "Library of Congress classification"
     )

The correct call number type is being got.


ImportError: cannot import name 'remove_examples' from 'data_utils'

generate_targetcov_openai.py", line 9, in
from data_utils import read_jsonl, write_jsonl, add_lineno, remove_examples
ImportError: cannot import name 'remove_examples' from 'data_utils'
In data_utils.py I couldn't find function named remove_examples. So this should I delete ?  （It doesn't affect the running）

Fixed by removing 'remove_examples'.


Containers list Hostname column not work

Bug description
Containers list Hostname column not work

Expected behavior
The user must be able to show/hide Container hostname column in list.

Portainer Logs
N/A
Steps to reproduce the issue:

Go to Containers list
Click on Columns  (show/hide columns)
Try to show or hide the host column
See error

Technical details:

Portainer version:
Docker version (managed by Portainer): N/A
Kubernetes version (managed by Portainer): N/A
Platform (windows/linux): N/A
Command used to start Portainer (docker run -p 9000:9000 portainer/portainer):
Browser: N/A
Use Case (delete as appropriate): N/A
Have you reviewed our technical documentation and knowledge base? Yes

Additional context
N/A

I have tried to relicate the issue and I cannot as it is working in both Portainer v2.1.1 w/Docker v20.10.5 and Docker v19.03.8
https://files.slack.com/files-pri/T015Z33E1EG-F0200PXBT0R/portainer_column_list_v211-1.png
https://files.slack.com/files-pri/T015Z33E1EG-F01UVCEKUUW/portainer_host_column_removed_v211-2.png
https://files.slack.com/files-pri/T015Z33E1EG-F01UVCFT9SS/portainer_host_added_v211-3.png
v19.03.8
https://files.slack.com/files-pri/T015Z33E1EG-F01V8BHK668/image.png
https://files.slack.com/files-pri/T015Z33E1EG-F01V8BHK668/image.png

@PululuK The Host column is designed to show the Host/Node where the container is running when you are managing a Swarm environment with multiple nodes.
It is here to help you quickly figure out on which node your containers are running.
It brings no value when managing a standalone Docker environment (and is not meant to show the container hostname) so I believe that the fix in #5006 is not necessary.
There is a UX problem here though that led you to that confusion, so I think that the fix here would be to prevent showing the Host filter when managing a non Swarm endpoint.

We'll keep this one tagged as a bug as we should not show the Host column filter when managing a standalone Docker endpoint. Any contributions welcome :-)


Consistent naming convention Layer 2 (L2)

Layer 2 (L2) naming convention
For titles / first time appearing on a page > “Layer 2”
For every other mention > “L2”
Also applies to Ethereum Layer 1 (L1)

Here's a few suggestions that might help


Dependencies update

Cypress updated
petrus, antonio updated
jerome and translatableFactory usage updated
updated build scripts to correspond to the new Gitlab CI configuration
resolved security vulnerabilities from audit

Closes #22

https://travis-ci.com/github/AckeeCZ/create-react-app/jobs/480254613


Object detection

Hey. Is data augmentation supported for object detection tasks?

How do you mean exactly? That the Augmentor library itself performs object detection during the augmentation procedure? If so then currently no, Augmentor does not perform any of its own object detection.


Remove completed TODOs

Huh, how did a test fail?

Huh, how did a test fail?

not sure why matmul was causing nans, but I couldn't reproduce it on my device

Turns out I wasn't lying, it does work now!
https://github.com/geohot/tinygrad/commit/623fb1ef281131ed0b3fd65111bc151a0717b098


UBSan errors found in cmsGetColorSpace: not a valid value for type 'cmsColorSpaceSignature'

Summary
Hi, I found an UBSan error in lcms, that might by cause undefined behaviors in lcms.
it reported:
poc.cc:36:37: runtime error: load of value<PHONE_NUMBER>, which is not a valid value for type 'cmsColorSpaceSignature'

That might due to the _cmsReadHeader, called viacmsOpenProfileFromMem()->cmsOpenProfileFromMemTHR()->_cmsReadHeader(), performed type cast to Icc -> ColorSpace without check this vaule.
The similar issue might also exist in Icc -> DeviceClass , Icc -> PCS  and Icc -> platform .
Poc program
#include <lcms2.h>
#include <stdlib.h>
#include <string.h>
#include <stdint.h>
#include <vector>
#include <fstream>
#include <iostream>

extern "C" int LLVMFuzzerTestOneInput(const uint8_t *data, size_t size) {
	if(size<=0) return 0;

    // Create a profile from the input data
    cmsHPROFILE hProfile = cmsOpenProfileFromMem(data, size);
    if (!hProfile) {
        return 1;
    }

    // Get the color space of the profile
    cmsColorSpaceSignature color_space = cmsGetColorSpace(hProfile);
    std::cout << "Color Space: " << color_space << std::endl;

    cmsCloseProfile(hProfile);
	return 0;
}

Steps to reproduce

Download the poc input: crash-256553a6dfe1fb5be22ce6a3cc1618af1c3b68a6
Built LCMS library with UBSan
Compile the poc program:
clang++ -fsanitize=fuzzer,undefined -g -O0 -I/lcms/include poc.cc -o poc.out liblcms2.a
export UBSAN_OPTIONS=symbolize=1:print_stacktrace=1:halt_on_error=1
Run the Poc program on the input
./poc.out crash-256553a6dfe1fb5be22ce6a3cc1618af1c3b68a6

Thanks for reporting. Indeed, this is not an error but the expected behavior. Remember this is C99 (not C++!) In C99 enums are assumed to fit in an int (32 bits in strict C99).  You are compiling the code with clang++, which is not the required language.
Lcms allows to open profiles with custom color spaces, as an ICC extension, despite the number then is not listed in the enum.  This is perfectly valid in C99.

Thanks for reporting. Indeed, this is not an error but the expected behavior. Remember this is C99 (not C++!) In C99 enums are assumed to fit in an int (32 bits in strict C99). You are compiling the code with clang++, which is not the required language. Lcms allows to open profiles with custom color spaces, as an ICC extension, despite the number then is not listed in the enum. This is perfectly valid in C99.

Yes, i compiled it with clang++. The UBSan reported some errors confused me.
Thanks for your reply.


Maintenance dev

Maintenance update to make the app available for devices with newer Android APIs.  #40

@MatHazak just found this app on the Play Store, but shows there as not compatible with my Pixel 6 on Android 14. Did this commit fix that compatibility?

@johnny5dm

Did this commit fix that compatibility?

Actually, the main purpose of this PR was that issue. We need to submit the updated app to Play Store, but we haven't done so yet. More on #40.


Svelte Flow: add a possibility to modify edge on edge creation

In 0.0.29 we added an onedgecreate prop for the <SvelteFlow /> component.


[stable/minecraft] add extraEnv and forceReDownload options

What this PR does / why we need it:
This PR includes two enhancements to the minecraft chart:

A new values option, forceReDownload, if enabled will instruct the minecraft server container to automatically re-download the server file for each server type so that the files do not need to be manually removed first in order to force a version update.  See #335 for more context and background
An added option to the values for setting any number of extra environment variables as needed. This can future-proof the chart for new env variables that get added to the base image.

Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[ ] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/chart])

/assign @cpanato

/assign @maorfr

/ok-to-test
/lgtm
No chart maintainers :(


Is this running in fp16 or fp32, or is it something different?

With other methods of running LLMs using fp16 or quantization methods down to 4bit/5bit/8bit I'm wondering if the web demo could be faster/smaller in the future with quantization or at least fp16.

Thanks for your advice. We are testing fp16 correctness and speed internally and will make it public soon

Thanks for your advice. We are testing fp16 correctness and speed internally and will make it public soon

I'm wondering about what the web demo uses currently. The model size is similar to a q4_0 ggml model, so is it running 4bit? I couldn't find any specific info on what precision you guys are using.

it is using 4bit quantization and fp32 for compute

it is using 4bit quantization and fp32 for compute

Thank you. Good luck with everything, I'm looking forward to seeing how this progresses.


Fix readonly errors when normalizing touch events on ios

ios10 puts some readonly properties that aren't valid touchevent spec but are in the pointer spec. Trying to overwrite these causes a failure in the normalization code, so there is now a check for each property before changing it.
also slightly tweaked the name of the flag to enable the normalization and made them public; so devs can find and switch the behaviour off if they wish.

Can we just use our own intermediate objects instead of assigning to the event object? I feel like that might be a better way to go about this.

Yeah sorry, started out as wanting to modify the bare minimum, and now its an ugly cludge. Will refactor into something nicer.

I know it's ugly, but I'm struggling to come up with an alternative option :/
It is possible to clone an event via
let newEvent = new originalEvent.constructor(originalEvent.type, originalEvent);
But there are side effects. Stop propagation isn't going to work if you have a different event object. And the .isTrusted flag on the cloned object is false. Suggestions welcome!

I meant something like this:
class OurEventWrapper
{
    constructor(event)
    {
        this.button = event.button || event.touches.length ? 1 : 0;
        // ...
    }
}

// ..........

if (this.normalizeTouchEvents && event.changedTouches)
{
    const evt = new OurEventWrapper(event);
}

I do this in Fae by abstracting events into a Pointer class which can be setup from an event:
https://github.com/Fae/fae/blob/master/plugins/interaction/src/Pointer.js#L406
I plan to do this with the new v5 interaction manager, so I'll just merge this for now and redo it in v5.


Support for .NET 6 and 8

Addresses #2 by replacing  .NET 7 runtime support with .NETs 6 and 8 as .NET 7 has reached end-of-life.

changes tool project to target .NET 6 and .NET 8
changes build project and ci to use .NET 8

Tested using a locally-packed tool after the changes:
# in ./tailwindcss-dotnet
bash>dotnet pack ./src/tailwindcss-dotnet/tailwindcss-dotnet.csproj -o ./artifacts --configuration Release -p:PackageVersion=1.0.1
MSBuild version 17.8.5+b5265ef37 for .NET
  Determining projects to restore...
  Restored /home/user/working/tailwindcss-dotnet/src/tailwindcss-dotnet/tailwindcss-dotnet.csproj (in 1.06 sec).
  tailwindcss-dotnet -> /home/user/tailwindcss-dotnet/src/tailwindcss-dotnet/bin/Release/net6.0/tailwindcss-dotnet.dll
  tailwindcss-dotnet -> /home/user/tailwindcss-dotnet/src/tailwindcss-dotnet/bin/Release/net8.0/tailwindcss-dotnet.dll
  Successfully created package '/home/user/working/tailwindcss-dotnet/artifacts/tailwindcss-dotnet.1.0.1.nupkg'.

# in my project dir
bash>dotnet tool install --add-source ~/tailwindcss-dotnet/artifacts/tailwindcss-dotnet.1.0.1/ tailwindcss-dotnet --version 1.0.1
You can invoke the tool from this directory using the following commands: 'dotnet tool run tailwind' or 'dotnet tailwind'.
Tool 'tailwindcss-dotnet' (version '1.0.1') was successfully installed. Entry is added to the manifest file....

bash>dotnet tool run tailwind install
Downloading tailwind cli v3.4.0 from https://github.com/tailwindlabs/tailwindcss/releases/download/v3.4.0/tailwindcss-linux-x64.
Download completed in 4.14 seconds, average speed: 9.71 MB/s
Project file was not found. Use --project option or change current folder.

bash>

Directory.Build.props should be updated as well because *.csproj framework options are overridden by those values. Also build script `build.cmd' has framework checks.

LGTM, thanks


context.done should accept null as first param

Added contribution notes for TS too.
Expands on work done here (thanks @michael-watson !) https://github.com/Azure/azure-functions-nodejs-worker/pull/194

Thank you @mhoeger!


PPF-345: add downloads and license badge

Codecov Report
Patch and project coverage have no change.

Comparison is base (1b7b666) 100.00% compared to head (3464d77) 100.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff            @@
##            master      #346   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           18        18
  Lines          577       577
=========================================
  Hits           577       577

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


function support char function

Proposed changes
Issue Number: close #xxx
Problem summary
Support function VARCHAR char(INT,..., [USING charset_name]).
Interprets each argument as an integer and returns a string consisting of the characters given by the code values of those integers. NULL values are skipped.
If the result string is illegal for the given character set, the result from CHAR() becomes NULL.
Arguments larger than 255 are converted into multiple result bytes. For example, char(15049882) is equivalent to char(229, 164, 154).
Currently only utf8 is supported for charset_name.
mysql> select char(68, 111, 114, 105, 115);
+--------------------------------------+
| char('utf8', 68, 111, 114, 105, 115) |
+--------------------------------------+
| Doris                                |
+--------------------------------------+

mysql> select char(15049882, 15179199, 14989469);
+--------------------------------------------+
| char('utf8', 15049882, 15179199, 14989469) |
+--------------------------------------------+
| 多睿丝                                     |
+--------------------------------------------+

mysql> select char(255);
+-------------------+
| char('utf8', 255) |
+-------------------+
| NULL              |
+-------------------+

Checklist(Required)

[ ] Does it affect the original behavior
[ ] Has unit tests been added
[ ] Has document been added or modified
[ ] Does it need to update dependencies
[ ] Is this PR support rollback (If NO, please explain WHY)

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall


feat(gtrack): inplace output

useful for reducing copying overhead when merging tracks

@ovesh is on vacation so please review the usage and approve if OK

Just one question out of curiosity: how is the case handled where the dtype of out is incompatible with that of the GenomeTrack?

It should throw since no decoder was registered:
https://github.com/deepgenomics/GenomeKit/blob/1e2b67222fd3504dfd112925893f633bf665f11c/src/genome_track.h#L1073-L1086


POST body is converted to JSON string before sending to server

Attached a sample test request.

@SAPikachu
Oh no.. haha
I'll have a look into this problem!
Thank's for taking your time reporting bugs 🐛
bugs should be eliminated asap!!!
Best Regards,
Jin

@SAPikachu
Thanks for your feedback! I found the bug, I was unncessarily transform Raw Data to string using JSON.stringify before sending to server :/
Wouldn't have found this bug without the community!
I just pushed a new update :)
Thanks again and have a good evening/day ☺


node environment added in eslint and removed unused webpack

Similar of #31

Codecov Report

Merging #34 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master    #34   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files          16     16
  Lines         241    241
=====================================
  Hits          241    241

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2cd6a3c...8a34fe2. Read the comment docs.

@rafaelcamargo Thanks for your guide

@rjoydip Very nice! Thanks for your contribution 😉


Output error, ignore .idea, rm unused variable

now in case of uncaught it shows
  2) jscs should pass for server:
     Uncaught No configuration found. Add a .jscsrc file to your project root or use the -c option.

Thanks for the contribution. I've merged #2 so that execFile is no longer needed.
BTW, what's .idea file for?

Released v1.1.0.

.idea is for all Intelij Idea based IDEs, like WebStorm (super popular IDE for js), PHPStorm, Idea, PyCharm and others

Got it. I copy the template from https://www.gitignore.io/ so it might be a good place to update this, too!


Does not restore notifications after phone reboot and even after starting app

Does not restore notifications after phone reboot and even after starting app. It is needed tap off/on to put them back to notification bar.
(Android 4.0.4)

I tested this with Android 6.0.1 phone and with Android 4.0.3 emulator, and restoring of the notes after reboot worked for me in both. Do you have the latest version (1.5) of the app installed?

Yes, it is 1.5 version.
I can also reproduce it without reboot:

add some notes
go to app manager and force application stop
start it again
notification bar still empty however application shows switched on notes

I have the same "problem". But not after reboot!
I still have a note created and enabled ...

go to app manager and force application stop
start app again
notification bar still empty however application shows switched on notes

I have added in NotesListAdapter.java on Line 100 setNotification(n);
Original
@Override
public void onBindViewHolder(ViewHolder holder, int position)
{
NotificationNote n = this.notes.get(position);
holder.titleView.setText(n.title);
holder.textView.setText(n.text);
holder.switchView.setChecked(n.isVisible);
setNotification(n);
}
After FORCE STOP and starting the APP all the enabled (visible) Notes will show in the notification bar

I can confirm that "setNotification(n);" fixes this issue.

onBindViewHolder is related to displaying the notes list within the app, it's not correct place to call the notification triggering code (setNotification).
When you do the force stop, Android warns you that the app "may misbehave". This is what's happening here, Notification Notes misbehaves as it's force stopped.
I believe the original issue with the rebooting is a different one.

OS/version: Android 6.0.1
NNotes version: 1.5
Missing notifications after reboot.
This kind of behavior seems invariable, rather inconsistent to reproduce with ease. But it still happens (from time to time).


Add new image component

What is this PR trying to achieve?
Recreating the image component to:

Use the JS models available
Work out the sizes automatically
Decouple it from the grid as it can't be used elsewhere if it is.

What does it look like?
WIP
For interface components

[x] Browser testing - Have you checked the component in our supported browsers
[x] No javascript - Have you checked the component with javascript disabled
[x] A11y testing - Have you run pa11y against the component and fixed/verified all errors, warnings and notices?

Have the following been considered/are they needed?

[x] Tests?
[ ] Docs?

This CR is not going to be about integrating this component into the website as I can do that as a next step - I just want to get a consensus that the figure component is doing what it should.


Fix icons

Does this address any existing issue?

@morpheusthewhite Mind reverting this pr, just updated the CSS map instead


Request mypy and cmake as dependencies

Put cmake as dependency since it is small and it makes it build even if it is not already present system-wide.
mypy is needed for stubgen (maybe only in linux)

Hi @albertopasqualetto
Thanks for the PR!
The cmake and mypy dependencies should be added automatically, depending on whether they're available already. The code for this feature is here:
https://github.com/tttapa/py-build-cmake/blob/420f73ca8c4e1b91c1adeddfba3afd697eaeba36/src/py_build_cmake/build.py#L181-L192
What is the reason for adding them as unconditional dependencies? Is the approach above not working correctly for you?

Ok, I understand, for some reason it did not work for me

Now it is working for some reason: I updated pip


docs: Adding a note for how to access frontMatter within pages

Motivation
(Write your motivation here.)
Have you read the Contributing Guidelines on pull requests?
(Write your answer here.)
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

Hi @cdrubin, please sign the CLA so your PR can be a merge candidate. Your PR has almost gone stale, but if you sign the CLA, I can help you complete it.

Superceded by #5900. @cdrubin you will still be credited as co-author


feat: Render cement with new ComplexRope geometry

Render cemnet with ComplexRope and ComplexRopeGeometry

This will improve performance and visuals of cement

Oh, also have a second look at the JSDoc for the complex rope classes, it seems to reference simple rope and have other parameter names for certain functions. 😅

Done with fixes after review. Pleas have a check on JSDoc comments. I might have missed some.


App design: Line chart and Pie chart

Implement the line chart that shows the time series of the crime rate and the pie chart that shows the crime rate percentage by neighborhood

After discussion with TA and Joel, we have decided to remove the Pie chart.


Add type-safety for classnames in vs code

Added type-safety for classnames with typescript-plugin-css-modules in the editor.
Unfortunately, tsc doesn't load plugins yet, so we don't get typechecks for classnames in CI and are stuck with declaring loose definitions in global.d.ts for now.

Note: Make sure your editor is using the workspace version of typescript to use the plugin. See typescript docs

Very cool! 🥳 For the type error, do we need something like: https://www.npmjs.com/package/typescript-plugin-css-modules#user-content-custom-definitions or is what you had before in global.d.ts good to use? 👀

We do :(
I was hoping we wouldn't only to realise tsc doesn't load plugins


Missing runtime.StartSpan

Recall that this is off by default. Did you set inject-spans to true?


Fix the dimension calculation

Fix the dimension calculation when helperClass change the size of the node.
Before

After

I tried to add the helperClass only on the clone element but we can't because the hidden element will still take the same height.
Let me know if you need more detail ✌

After discussion, we will try another approach so I will close this PR.


[SPARK-9398][SQL] Datetime cleanup

JIRA: https://issues.apache.org/jira/browse/SPARK-9398

Merged build triggered.

Merged build started.

Test build #38703 has started for   PR 7725 at commit 2021e75.

Will give another pass once #7718 is merged.

Test build #38703 has finished for   PR 7725 at commit 2021e75.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

cc @davies

Merged build triggered.

Merged build started.

Test build #38785 has started for   PR 7725 at commit b4eade1.

Test build #38785 has finished for   PR 7725 at commit b4eade1.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

LGTM, merging this into master, thanks!


[Fixed]: Sidebar scrollbar disappearing on hover #5750

Fixes: https://github.com/reactjs/react.dev/issues/5727
Resolved issue where scrollbar was getting disappeared when user tries to scroll by dragging scrollbar using cursor.
Solution:
In sidebar component on aside tag before there was 342px size set for lg screen , so what i did is changed it to 320px. Thus the issue is resolved with minimal changes
Issue:

Any updates on this?
See also: #5750

Fixed by https://github.com/reactjs/react.dev/pull/6586 which doesn't change layout.


Changes for Issue #8

This is a set of changes around Issue #8 .
Updates:

References to DOCUMENTDB in a generated variable name have been changed.
Exercise 2 now creates a model using an Azure Machine Learning notebook rather than Azure Synapse Analytics.

@joelhulen could you please review these changes?

Includes a bugfix to add machineid to the TelemetryOutput class in exercise 3, task 3.

This will also close Issue #10 and Issue #11.


fcntl testsuite is not called during make check

tests-fcntl.lua uses lunit which needs to be either called as lunit <testsuite> or the code running lunit.main need to be added to the end of testcase.

Fixed; thanks.


Feature request: support for multi line strings given to Fn::Sub

I'm passing a multi line string to user data like this:
x = """
This is
some
user data
"""

....
UserData(Base64(Sub(x)))

I'm getting output like this:
UserData: !Base64
  Fn::Sub: "\nThis is\nsome\nuser data\n"

I kinda expected this:
UserData:
  Base64:
    Fn::Sub: |
      This is
      some
      user data

I suspect this is partially related to the json/yaml processors and probably not something you can fix, but I thought I'd ask anyway.

It's actually due to how python interprets your code:
>>> x = """
... This is
... some
... user data
... """
>>>
>>>
>>> print x

This is
some
user data

>>> x
'\nThis is\nsome\nuser data\n'
>>>

You're literally putting new lines in the variable, which is how python interprets it.  The python syntax you want to use is something like:
>>> x = ("This is "
... "some "
... "user data"
... )
>>> print x
This is some user data
>>> x
'This is some user data'

Hope that helps!

Umm, I want the new lines.
I thought that was demonstrated in my desired output.

@et304383 oh, sorry, misunderstood

Actually, it looks like we might already support this - have you tried long_form in to_yaml?:
>>> t = Template()
>>> t.add_resource(WaitCondition("MyWaitCondition", Timeout=30, Handle="""My
... special multiline
... Handle
... """))
<troposphere.cloudformation.WaitCondition object at 0x100c0c190>
>>> print t.to_yaml()
Resources:
  MyWaitCondition:
    Properties:
      Handle: "My\nspecial multiline\nHandle\n"
      Timeout: 30
    Type: AWS::CloudFormation::WaitCondition
>>> print t.to_yaml(long_form=True)
Resources:
  MyWaitCondition:
    Properties:
      Handle: |
        My
        special multiline
        Handle
      Timeout: 30
    Type: AWS::CloudFormation::WaitCondition

It appears to work with Sub as well:
>>> t = Template()
>>> t.add_resource(WaitCondition("MyWaitCondition", Timeout=30, Handle=Sub("""My
... special multiline
... Handle
... """)))
<troposphere.cloudformation.WaitCondition object at 0x100c2a610>
>>> print t.to_yaml()
Resources:
  MyWaitCondition:
    Properties:
      Handle: !Sub "My\nspecial multiline\nHandle\n"
      Timeout: 30
    Type: AWS::CloudFormation::WaitCondition

>>> print t.to_yaml(long_form=True)
Resources:
  MyWaitCondition:
    Properties:
      Handle: !Sub |
        My
        special multiline
        Handle
      Timeout: 30
    Type: AWS::CloudFormation::WaitCondition

I'm going to go ahead and close this, as I believe long_form=True does what is being requested.  @et304383 let me know if  it doesn't, thanks!

Yup the long form flag is what I needed.  Thanks a bunch!

Awesome!  Glad to help (eventually! :))

Is this still supported through long_form? i just tested this and having the same result as in the original post.
Following:
x = """ TEST1 TEST2 TEST3 """ f.Code = Code(ZipFile=Sub(x))
with
 with open(local_file_name, 'w') as f:             #yaml.dump(stack.template.to_dict(), f)             f.write(stack.template.to_yaml(long_form=True))
Produces:
 Fn::Sub: "\n            TEST1\n            TEST2\n            TEST3\n  \             \          "

Good question. Been awhile since I looked at it. From the yaml tests it looks like that is enabled with the clean_up flag. Give that a try with your test case.

Yes it worked with the following:
clean_up=True
and
X = """
TEST1
TEST2
TEST3"""
My original test with
x = """
TEST1
TEST2
TEST3
"""
won't work. It seems ending the string with  /n"""  causes some sort of issue.
Anyways, it is good enough for me. Thanks a lot!!

Also, clean_up=True and long_form=True may produce unsupported/invalid template.
The long form clean up removes quote on string and may produce some invalid values and cause CloudFormation to fail with the following:
"Template error: every value of the context object of every Fn::Sub object must be a string or a function that returns a string"

it replaces valid template input
  Value:
    Fn::Join:
      - ","
      - - Fn::If:
            - HasZoneA
            - Ref: PublicSubnetA
            - Ref: "AWS::NoValue"
        - Fn::If:
            - HasZoneB
            - Ref: PublicSubnetB
            - Ref: "AWS::NoValue"
        - Fn::If:
            - HasZoneC
            - Ref: PublicSubnetC
            - Ref: "AWS::NoValue"

by
Value: !Sub

${Param1},${Param2},${Param3}
Param1: !If

HasZoneA
!Ref 'PublicSubnetA'
!Ref 'AWS::NoValue'
Param2: !If
HasZoneB
!Ref 'PublicSubnetB'
!Ref 'AWS::NoValue'
Param3: !If
HasZoneC
!Ref 'PublicSubnetC'
!Ref 'AWS::NoValue'

and then fails

long_form=True doesn't work like described earlier in this threat for troposphere==2.4.5. In fact, after bisecting, I see that it last worked on 2.3.0. It's broken from 2.3.1 on.
I guess I'm finally getting around to version pinning, lol.


feat: added support for BIGNUMERIC data type

@loudinb Now that I've finally been able to release ibis-bigquery 2.0.0, I can start to look at requests like this again.
Would you want to add support for ibis 1.x as well, or should we target the latest? If you want to support ibis 1.x, target the PR at the v1 branch. We can add it there and then apply the same patch to the main branch later.


FIX 5114: Allow null as a valid value for .enu/.enum

When using the useNative and existingType options, the value isn't utilized.
The documentation uses null as an example, this commit allows said example
to pass in typescript
close #5114

I have no idea why the lint stage throws, but also doesn't fail the test:
The 'no-redundant-jsdoc' rule threw an error in '/home/runner/work/knex/knex/types/index.d.ts':
Error: Unexpected tag kind: JSDocDeprecatedTag

Coverage remained the same at 92.277% when pulling 149404f048638924e10a2f1c3a443af67bd550d0 on Naddiseo:master into 939d8a219c432a7d7dcb1ed1a79d1e5a4686eafd on knex:master.


[Question]: Best way to read markdown docs with readers, parsers and splitters

Question Validation

[X] I have searched both the documentation and discord for an answer.

Question
Llama index offers multiple ways to deal with markdown files:

MarkdownElementNodeParser
MarkdownNodeParser
CodeSplitter
SimpleDirectoryReader with MarkdownReader

My question is what is the best way to use these, chaining them together seems like it will be doing similar operations to the data again and again which might "overprocess" it. It could be that FlatReader and a node parser would be best, if so, is there any benefit in using a file type specific text splitter like CodeSplitter.
I am trying to understand this for use in the context of an IngestionPipeline.

Thank you for the reference. I think there is some room for standardization here, at the least markdownreader and Markdownnodeparser should have the same logic. It seams they'll have generally the same output but one will return documents and one will return nodes


Use offline

can to add feature docs offline?
by using Googele Docs in the Chromium-based browser, it's aviable.
thanks

I am working on a new release with offline support, localisation, and other bug fixes

Still waiting on this update.


[BUG] PL/SQL Stored Procedure

Description

I connect to the database succesfuly with a user with enough permissions

I create the following procedure with a cursor in a sql script or in a sql console

CREATE OR REPLACE PROCEDURE BANC."3_MILLORS_CLIENTS"(
id IN NUMBER
) IS
CURSOR C_CLIENTS IS
SELECT c.COD_CLIENTE, c.NOMBRE, c.APELLIDOS, cu.SALDO
FROM BANC.CLIENTE c, BANC.CUENTA cu
WHERE c.COD_CLIENTE = cu.COD_CLIENTE AND
cu.COD_SUCURSAL = id
ORDER BY cu.saldo DESC
FETCH FIRST 3 ROWS ONLY;
BEGIN
DBMS_OUTPUT.ENABLE;
FOR C_C IN C_CLIENTS LOOP
DBMS_OUTPUT.PUT_LINE(C_C.COD_CLIENTE||' '||C_C.NOMBRE||' '||C_C.APELLIDOS||' '||C_C.SALDO);
END LOOP;
END;
BEGIN
BANC."3_MILLORS_CLIENTS"(1);
END;

I run it and I see the following error:
Error occurred during SQL script execution

Razón:
SQL Error [6550] [65000]: ORA-06550: línea 3, columna 13:
PLS-00201: el identificador 'C_CLIENTS' se debe declarar
ORA-06550: línea 3, columna 2:
PL/SQL: Statement ignored

Then on the created procedure I see the following:
CREATE OR REPLACE PROCEDURE BANC."3_MILLORS_CLIENTS"(
id IN NUMBER
) IS
CURSOR C_CLIENTS IS
SELECT c.COD_CLIENTE, c.NOMBRE, c.APELLIDOS, cu.SALDO
FROM BANC.CLIENTE c, BANC.CUENTA cu
WHERE c.COD_CLIENTE = cu.COD_CLIENTE AND
cu.COD_SUCURSAL = id
ORDER BY cu.saldo DESC
FETCH FIRST 3 ROWS ONLY

Resume: Dbeaver executes this script as if it were 2 different parts
DBeaver Version
24.0.0
Operating System
Windows 11 23H2
Database and driver
Database name and version: OracleDB 21.3.0 xe
Driver name and version: Oracle JDBC driver
Steps to reproduce

I connect to the database succesfuly with a user with enough permissions

I create the following procedure with a cursor in a sql script or in a sql console

CREATE OR REPLACE PROCEDURE BANC."3_MILLORS_CLIENTS"(
id IN NUMBER
) IS
CURSOR C_CLIENTS IS
SELECT c.COD_CLIENTE, c.NOMBRE, c.APELLIDOS, cu.SALDO
FROM BANC.CLIENTE c, BANC.CUENTA cu
WHERE c.COD_CLIENTE = cu.COD_CLIENTE AND
cu.COD_SUCURSAL = id
ORDER BY cu.saldo DESC
FETCH FIRST 3 ROWS ONLY;
BEGIN
DBMS_OUTPUT.ENABLE;
FOR C_C IN C_CLIENTS LOOP
DBMS_OUTPUT.PUT_LINE(C_C.COD_CLIENTE||' '||C_C.NOMBRE||' '||C_C.APELLIDOS||' '||C_C.SALDO);
END LOOP;
END;
BEGIN
BANC."3_MILLORS_CLIENTS"(1);
END;

I run it and I see the following error:
Error occurred during SQL script execution

Razón:
SQL Error [6550] [65000]: ORA-06550: línea 3, columna 13:
PLS-00201: el identificador 'C_CLIENTS' se debe declarar
ORA-06550: línea 3, columna 2:
PL/SQL: Statement ignored

Then on the created procedure I see the following:
CREATE OR REPLACE PROCEDURE BANC."3_MILLORS_CLIENTS"(
id IN NUMBER
) IS
CURSOR C_CLIENTS IS
SELECT c.COD_CLIENTE, c.NOMBRE, c.APELLIDOS, cu.SALDO
FROM BANC.CLIENTE c, BANC.CUENTA cu
WHERE c.COD_CLIENTE = cu.COD_CLIENTE AND
cu.COD_SUCURSAL = id
ORDER BY cu.saldo DESC
FETCH FIRST 3 ROWS ONLY

Additional context
No response

Thank you for bug report.

janrodriiguez, try the following steps:

Set DBeaver Preferences: Editors - SQL Editor - SQL Processing - Control command prefix: @
(default is ';')
Change the last lines of the CREATE OR REPLACE PROCEDURE statement
END LOOP;
END;
to
END LOOP;
END@
Execute CREATE OR REPLACE PROCEDURE statement again and check whether the procedure has been created.
Set DBeaver Preferences: Editors - SQL Editor - SQL Processing - Control command prefix: ;
(i.e. set the default value)
Try to execute the procedure call
BEGIN
BANC."3_MILLORS_CLIENTS"(1);
END;
Hope this helps.


opt improve logstash doris output plugin

Proposed changes

support multi thread concurrency for performance
support retry count and infinite retry
add a config to log doris stream load request header and response
add a config to log speed for better observability

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run cloud_p1


Great implementation questions

First, this is a great Implementation. I haven't seen any other implementations of the Hamerly method.
Couple questions:

convergence factor do you have anymore info on it and how adjustments effect it?
sRGB - the library has an implementation of it you're using to support the color profile. Can you add support for this?
can you point me in the direction of how to save out the executable builds for this? Im not familiar with crates but want to be
Thank you

Thanks. I'll try to answer.

convergence factor do you have anymore info on it and how adjustments effect it?

The convergence factor is a distance metric for how much the centroids have changed from one iteration to the next. Below a threshold, the centroids have moved so little between iterations that it's not visible to us, so it's an optimization to not run more iterations than necessary. A higher factor will have lower quality results because the centroids haven't stabilized yet, but if the factor is too low it may never converge due to the instability of centroids juggling points back and forth between one another.
The convergence factor and maximum number of iterations exist to make sure the algorithm is guaranteed to converge or stop. Through experimenting, I found 0.0025 to be a good factor for RGB and 5.0 for Lab but you can try other values that work for your use.
The documentation could be made more clear about this. There's a bit about it in the bottom of this section.
The binary uses 8 as the default k. The iteration limit is set to 20. The convergence factor defaults to 5.0 for Lab and 0.0025 for Srgb
https://docs.rs/kmeans_colors/0.5.0/kmeans_colors/index.html#calculating-k-means

sRGB - the library has an implementation of it you're using to support the color profile. Can you add support for this?

I'm not sure what you mean by this. It's supported in the command line application by passing the --rgb flag. The code examples would look similar but with Lab replaced by Srgb using the palette crate.

can you point me in the direction of how to save out the executable builds for this? Im not familiar with crates but want to be

There are a few ways you can do this, I'm not sure which specifically you mean. You can try downloading from the releases page https://github.com/okaneco/kmeans-colors/releases.
If you cargo install kmeans_colors, the binary will download and compile itself into your .cargo/bin/ folder.
If you're compiling with cargo build --release, the executable will be in the target/release/ folder of your project.

Thank you. I believe you answered my questions. It sounds to me like your stating For the sRGB portion, --rgb represents sRGB and not the rgb profile. In imagemagick and photoshop, RGB and sRGB are two different profiles.
One more: Can you think of how I could adjust the fuzz value or color average when reducing colors? I get 3 colors typically when two colors are next to each other due to anti-aliasing. For example Yellow/Black next to each other often becomes Yellow, Red and Black colors especially if red is used elsewhere?

@okaneco This helps a ton for trying to figure out how to use this as a library.  Is it possible you might be able to integrate some of this into the documentation?


Show diagnostics during training

Hello,
I have a small question with regards to the training config file - in particular, this line: https://github.com/StanfordVL/GibsonEnv/blob/master/examples/configs/husky_navigate_rgb_train.yaml#L12
Is show_diagnostics supposed to be True? If I understand correctly, this would mess up with the rgb input to the agent, which then questions usefulness of the rgb input at all
Thanks, and great work, btw!

Hi @DrSleep, you are right, show_diagnostics should be false in any training and testing configurations. We will push a fix.

@fxia22 thanks!


Bitwise ~

On Bela we have the 16 digital channels encoded as 32bit words (sampled at audio rate). The lower half-word tells you whether a channel is input (1) or output (0), the upper half-word carries the input value read in the last block ( if an input) or the output value that will be written in the next output ( if an output).
Of course, I could transform these into real audio channels in the C wrapper, but its a bit of a waste of memory to use a full 32-bit float (for each of 16 channels) to represent a binary state.
Ideally, having non-casting [&~] and [|~] or non-casting [expr~] would allow us to read the inputs and write the outputs as well as setting the pin direction.
What would you suggest as the best approach to solve this issue?

So in heavy we do have capabilities for integer connections and bitwise operations but the only issue is that because Pd doesn't support it and we don't have our own editor there's not a clear interface to that part of the API.
I'm fairly sure we can support your use case but it might take us a day or so to implement and wouldn't get round to it till at least after next week.

Oh that'd be ok, no hurry.
Then I guess we could use:
To read input channel 0:
[adc~ 11]
|      [1 16]
|      |
|      [<<]
|      |
[&~ 0]

To write output channel 1:
[sig~ 0]
|      [1 17]
|      |
|      [<<]
|      |
[|~ 0]
|
[dac~ 11]

with the caveat that only a single [dac~ 11] object should exist in the patch and signals should be all or'ed together into it.


Add language to the Fetch query endpoint #15

@huslage this test looks like some error on AWS credentials - any ideas?

@khushijindal exciting! Thanks for this PR. End of the work day where I am but we will incorporate this!

@DGaffney I am confused on these tests part though.

@khushijindal the error seems to be on our end with our continuous integration. Not sure but I believe that's what's hold things back right now. I'm offline starting now through the weekend but I will look deeper on monday!

Hello! @khushijindal I went ahead and tested your code locally and it doesn't break any local tests on my machine. I also looked into the unit tests and I'd advise building a test like the 'expects claim_review_search_query hash, empty single time' task in spec/lib/elastic_search_query_test.rb. @huslage do let me know if we can chat about the error @khushijindal is hitting - still seems like something on our end from my perspective.

Hey, @DGaffney I looked into the tests part when I was working on the issue, but couldn't actually understand it, can you help a bit by explaining what needs to be done.

@khushijindal sure thing - I think your test would look something like the following:
    it 'expects claim_review_search_query hash with a language specified' do
      expect(described_class.claim_review_search_query({service: 'google', language: "en"})).to(eq({ size: 20, from: 0, sort: [{created_at:{order: 'desc'}}], query: { bool: { must: [{ match_all: {} }], filter: [{ match_phrase: { 'service' => 'google' } }, { match_phrase: { "language" => "en" } }] , should: [], must_not: [] } } }))
    end

Effectively, as an MVP unit test, we need to confirm that we can create a valid elasticsearch query with the language parameter being passed through.
Additionally, we'll need an integration test that ensures that the query can actually work that would look something like the following inside spec/lib/db_integration_test.rb:
    it "ensures access of #{subclass} via Search-layer" do
      expect(ClaimReview.search(language: "en")[0][:url]).to(eq(@storage_results[subclass][0][:claim_review_url]))
    end

Finally, one thing I didn't see yet, and needs to be in there regardless of this feature getting finished is we need to expose the language that is currently being stored in ElasticSearch in the ClaimReview Schema by adding a line to the lib/claim_review_export.rb file:
      "inLanguage": claim_review['language'],

This needs to be under the inLanguage key in order to be ClaimReview-compliant.
Does this help clarify anything? We've also looked at the failure you're hitting and over here at Meedan we're in agreement that it's an error on our end.

Yes, surely @DGaffney , it helps. I'll work on this too and get back.

@DGaffney , I tried to do as you instructed. Please review and if there is some problem, please tell me.

@huslage how should we handle the breaking tests here?

@khushijindal Unfortunately, due to the error you're running into, we have to open a new PR to test this. I opened up https://github.com/meedan/fetch/pull/65 which incorporates your changes and allows testing of it. If it's alright, I'd like to move over to that ticket instead, and we can finish incorporating the code there (albeit with my name attached to the changes, unfortunately)? Let me know if that's acceptable to you.

Closing PR - your changes have been incorporated on the other branch, @khushijindal!

Hey @DGaffney, I think so you have merged the changes on another PR. As I am participating in Hacktoberfest, as these changes are not merged, my PR would be labelled invalid. So, please at least add hacktoberfest-accepted label. I have started with open-source recently, so these PRs are very important to me. I wanted to raise a new PR incorporating all changes, so it could be merged, but now it has been done, so ok!

@khushijindal I have added the label for you. Thanks so much for the contribution!

@huslage can you please explain to me like where exactly were errors occurring, would be helpful for me in the future. I think so PR from the forked repo fails the AWS credentials .

You're right. The forked repo can't read the AWS credentials. We are
working to fix the problem.
On Fri, Oct 9, 2020 at 9:14 AM Khushi<EMAIL_ADDRESS>wrote:

@huslage https://github.com/huslage can you please explain to me like
where exactly were errors occurring, would be helpful for me in the future.
I think so PR from the forked repo fails the AWS credentials .
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/meedan/fetch/pull/64#issuecomment-706173185, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AADFBK3XQFPDMYMDMFSE2Q3SJ4EBPANCNFSM4SCD3EIA
.

@khushijindal sorry that the fork you opened wasn't the one that directly resulted in the code being accepted - it is a problem on our end and I apologize for that. Thank you so much for your contribution, it's very appreciated.


Support for image generation

Gemini Pro generates images but they appear as

Is image generation not supported?

No it is not supported by default, you could add a tool under the tool section. But no LMM model support generating images by default currently, it's just hallucination.

Ah that's what I thought thanks!
Is there anyway to make sure a tool/custom llm is available to all users?

Unfortunately just a hallucination


Tap fails with chunk exception

I am trying to setup an ETL to import data from mongo (4.0) to BigQuery.
It's important for us to have the schema of our mongo documents in bigquery. Therefore I tried to add the "infer" strategy to the tap. However this is resulting in the following exeception:
Run invocation could not be completed as block failed: Cannot start plugin tap-mongodb: Separator is found, but chunk is longer than limit
I have tried to increase the output buffer via the respective ENV-Var but that does not seem to have any effect.
ENV:

Python 3.9.13
OS: RHEL 8

I have figured out that the root cause is a quite big collection that stores documents.
Is there any option to exclude that collection from the schema generation and sync?


Initialize account when creating, use spec AWS account ID

This PR fixes an issue where the account CR enters the "Creating" status and we never attempt to initialize the account where eventually it would set to "Ready".  No account could ever become "Ready" in this state.
I also remove references to awsAccountID  where not required and only initialize it inside the condition where it is used and not at the pkg scope.

/hold

Tested

BYOC
Account reuse
Account creation

/hold cancel


Upgrade to TypeScript 3.7

TypeScript 3.7 introduces assertion functions which previous versions of tsc cannot compile.

While not technically wrong, it's kind of weird to convert the return type to void. I'd like to look into this to see if it would be an easy fix before merging, should have enough time this weekend.

Turns out that wasn't too difficult after all, thanks for the PR! I've reached out to Anthony about getting a 0.15.1 release with this in it. Just waiting for Travis to pass to merge.
If you need the changes now, I keep @gerrit0/typedoc up to date with master here (whenever bugs are fixed / features added, I don't bother with new releases if nothing user-facing changes), so it will have these changes in an hour or so.


User profile should link to list of edits by that user

still important

I added an "Edits" tab that shows the last 100 edits for the user. I'll have to go back and add pagination so you can see more results if the are any.


[#2999][#2997] improvement(partition): add partition operation dispatcher

What changes were proposed in this pull request?

reuse the class loader of the catalog for partition operation
add partition operation dispatcher

Why are the changes needed?
Fix: #2997 #2999
Does this PR introduce any user-facing change?
no
How was this patch tested?
tests added

@jerryshao All comments are resolved, do you want to take another look?

Yeah, I will.

How do you verify that the partition operation is running in the isolated classloader?

How do you verify that the partition operation is running in the isolated classloader, is it possible to add the test case to cover this?

@jerryshao test for isolated classloader added, please help review again


Migration to PSR-15

Coverage remained the same at 100.0% when pulling 2a05fa1d05b8bbf0913e771df583451797f74ed0 on julienDrobieux:ToPsr15 into 675e003ae3a092b668687ee458eef86065913c20 on thecodingmachine:0.4.

Coverage remained the same at 100.0% when pulling 2a05fa1d05b8bbf0913e771df583451797f74ed0 on julienDrobieux:ToPsr15 into 675e003ae3a092b668687ee458eef86065913c20 on thecodingmachine:0.4.


Update Template projects to .NET 8 and latest NuGet packages

The template projects are still on .NET Core 3.1 and referencing v1.0.0 of the NuGet packages.
These need to be updated to .NET 8 and the latest packages.

This has been fixed as part of v1.1.0


Bumpver doesn't work with uv.lock files

It seems like Bumver doesn't work with uv.lock files. I've also tried other patterns for the uv.lock file and I'm unable to find a pattern that works.
Bumpver version: 2023.1129
I've also tried:
"uv.lock" = [
    "name = \"bumpver-issue\"\nversion = \"{version}\"",
]

And:
"uv.lock" = [
    'name = "bumpver-issue"\nversion = "{version}"',
]

And:
"uv.lock" = [
    'name\s=\s"bumpver-issue"\nversion\s=\s"{version}"',
]

Steps to reproduce:
$ mkdir bumpver-issue

$ cd bumpver-issue

$ uv init
Initialized project `bumpver-issue`

$ uv add django
Using CPython 3.13.0
Creating virtual environment at: .venv
Resolved 5 packages in 149ms
Installed 3 packages in 129ms
 + asgiref==3.8.1
 + django==5.1.2
 + sqlparse==0.5.1

$ uvx bumpver init
WARNING - Couldn't parse pyproject.toml: Missing version_pattern
Updated pyproject.toml

Change the [tool.bumpver] section in pyproject.toml to:
[tool.bumpver]
current_version = "0.1.0"
version_pattern = "MAJOR.MINOR.PATCH"
commit_message = "bump version {old_version} -> {new_version}"
tag_message = "{new_version}"
tag_scope = "default"
pre_commit_hook = ""
post_commit_hook = ""
commit = true
tag = true
push = false

[tool.bumpver.file_patterns]
"pyproject.toml" = [
    'current_version = "{version}"',
]
"uv.lock" = [
    "version = \"{version}\"",
]

Then initialize Git:
git init
git add .
git commit -m "Initial commit"

Then bump the version:
➜ uvx bumpver update -p
INFO    - fetching tags from remote (to turn off use: -n / --no-fetch)
INFO    - Old Version: 0.1.0
INFO    - New Version: 0.1.1
INFO    - git commit --message 'bump version 0.1.0 -> 0.1.1'
INFO    - git tag --annotate 0.1.1 --message '0.1.1'

Then run git diff HEAD^ HEAD | cat to see that bumpver changed all the versions off all the dependencies in the
uv.lock file instead of just the version for bumpver-issue.
diff --git a/pyproject.toml b/pyproject.toml
index 7258584..60f1789 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -9,7 +9,7 @@ dependencies = [
 ]

 [tool.bumpver]
-current_version = "0.1.0"
+current_version = "0.1.1"
 version_pattern = "MAJOR.MINOR.PATCH"
 commit_message = "bump version {old_version} -> {new_version}"
 tag_message = "{new_version}"
diff --git a/uv.lock b/uv.lock
index 78e4d88..91c3ed5 100644
--- a/uv.lock
+++ b/uv.lock
@@ -3,7 +3,7 @@ requires-python = ">=3.13"

 [[package]]
 name = "asgiref"
-version = "3.8.1"
+version = "0.1.1"
 source = { registry = "https://pypi.org/simple" }
 sdist = { url = "https://files.pythonhosted.org/packages/29/38/b3395cc9ad1b56d2ddac9970bc8f4141312dbaec28bc7c218b0dfafd0f42/asgiref-3.8.1.tar.gz", hash = "sha256:c343bd80a0bec947a9860adb4c432ffa7db769836c64238fc34bdc3fec84d590", size = 35186 }
 wheels = [
@@ -12,7 +12,7 @@ wheels = [

 [[package]]
 name = "bumpver-issue"
-version = "0.1.0"
+version = "0.1.1"
 source = { virtual = "." }
 dependencies = [
     { name = "django" },
@@ -23,7 +23,7 @@ requires-dist = [{ name = "django", specifier = ">=5.1.2" }]

 [[package]]
 name = "django"
-version = "5.1.2"
+version = "0.1.1"
 source = { registry = "https://pypi.org/simple" }
 dependencies = [
     { name = "asgiref" },
@@ -37,7 +37,7 @@ wheels = [

 [[package]]
 name = "sqlparse"
-version = "0.5.1"
+version = "0.1.1"
 source = { registry = "https://pypi.org/simple" }
 sdist = { url = "https://files.pythonhosted.org/packages/73/82/dfa23ec2cbed08a801deab02fe7c904bfb00765256b155941d789a338c68/sqlparse-0.5.1.tar.gz", hash = "sha256:bb6b4df465655ef332548e24f08e205afc81b9ab86cb1c45657a7ff173a3a00e", size = 84502 }
 wheels = [

Would there be less to refactor and less risk to breaking existing usages, it you added the ability to specify Regex flags in the pattern.
Maybe something like:
"uv.lock" = [
    "/version = \"{version}\"/gmi",
]

Perhaps. In principle, for this issue, the \n would be enough indication to treat the pattern differently.
"uv.lock" = [
    'name = "bumpver-issue"\nversion = "{version}"',
]

However the multiline detection works, I'm doubtful there's an easy (i.e. hacky) way to make it work. The line by line logic is carried through so many places, I doubt you can make an isolated change.

Regarding capacity ... I was just checking this project out because a friend said he used it. I'm not even using it yet, so I don't really want to spend time on a fix. Right now, using the following in a Justfile is working for me.
@version_bump version:
    sed -i '' 's/version = ".*"/version = "{{ version }}"/' pyproject.toml
    uv sync
    git add pyproject.toml uv.lock
    git commit -m "Version bump to v{{ version }}"
    just _success "Version bumped to v{{ version }}."

@mbarkhau, out of curiosity, why did you close it? UV is becoming more and more common and gaining a lot of traction as the preferred way to manage Python packages.

UV is incidental to the issue. The fundamental issue is this https://github.com/mbarkhau/bumpver/issues/193

A little bit related to https://github.com/astral-sh/uv/issues/6298


Move render-blocking CSS

#76 may help with this. Would be good to pull navigation and landing CSS to the top, and defer the rest.

Everything has been made as small as possible. The site is tiny enough that I'm not going to optimize this any further


Kubernetes discovery failing with "Watch pods unexpectedly closed: EOF"

What did you do?
Using kubernetes discovery to discover services, nodes and pods.
What did you expect to see?
New pods discovered by prometheus
What did you see instead? Under which circumstances?
New pods not picked up by prometheus. Saw repeated messages like the following in the log:
time="2016-06-08T21:42:36Z" level=error msg="Watch pods unexpectedly closed: EOF" source="discovery.go:885"
time="2016-06-08T21:43:59Z" level=error msg="Watch service endpoints unexpectedly closed: EOF" source="discovery.go:553"

Environment

System information:

Linux 4.3.3-coreos x86_64

Prometheus version:
0.19.2

Alertmanager version:
insert output of alertmanager -version here (if relevant to the issue)

Prometheus configuration file:

insert configuration here

Alertmanager configuration file:

insert configuration here (if relevant to the issue)

Logs:

time="2016-06-08T21:42:36Z" level=error msg="Watch pods unexpectedly closed: EOF" source="discovery.go:885"
time="2016-06-08T21:43:59Z" level=error msg="Watch service endpoints unexpectedly closed: EOF" source="discovery.go:553"

How are you connecting to the API server? Is Prometheus running inside the cluster? Please paste the relevant bits of the Prometheus configuration you are using.
Another thing to try – if you scale a few pods around after Prometheus has started, do they start showing up? in that case this would be #1702

I forgot to mention that it did manage to discover one pod, but not others.
The relevant part of the config: (mostly copied from https://github.com/prometheus/prometheus/blob/master/documentation/examples/prometheus-kubernetes.yml)
                  - job_name: 'kubernetes-pods'
                    kubernetes_sd_configs:
                    - api_servers:
                      - https://<IP_ADDRESS>
                      in_cluster: true
                      tls_config:
                        insecure_skip_verify: true

                    relabel_configs:
                    - source_labels: [__meta_kubernetes_role, __meta_kubernetes_pod_annotation_prometheus_io_scrape]
                      action: keep
                      regex: pod;true
                    - source_labels: [__address__, __meta_kubernetes_pod_annotation_prometheus_io_port]
                      action: replace
                      regex: (.+):(?:\\d+);(\\d+)
                      replacement: ${1}:${2}
                      target_label: __address__
                    - action: labelmap
                      regex: __meta_kubernetes_pod_label_(.+)
                    - source_labels: [__meta_kubernetes_pod_namespace]
                      action: replace
                      target_label: kubernetes_namespace
                    - source_labels: [__meta_kubernetes_pod_name]
                      action: replace
                      target_label: kubernetes_pod_name

OK, I figured out the problem. Prometheus requires containers to declare their ports. In the absence of the port relabeling, it will scrape the lowest port.


Unable to conect to http: ....

Hello i put my wallet key and pass and my etherwallet say accepted but then appear unable to conect to... what happen?

Hi Migel,
What are you attempting to do when you get this error?

to watch the money in my wallet
On 15/12/15 11:46, Taylor Van Orden wrote:

Hi Migel,
What are you attempting to do when you get this error?
—
Reply to this email directly or view it on GitHub
https://github.com/kvhnuke/etherwallet/issues/11#issuecomment-164837290.

Hi Migel,
Server rebooted for maintenance, and I had to manually restart the geth service
it is back online now :)
-----Original Message-----
From: Taylor Van Orden<EMAIL_ADDRESS>To: kvhnuke/etherwallet<EMAIL_ADDRESS>Sent: Tue, Dec 15, 2015 9:46 am
Subject: Re: [etherwallet] Unable to conect to http: .... (#11)
Hi Migel,
What are you attempting to do when you get this error?
—
Reply to this email directly or view it on GitHub.

ok, thanks i probe and its ok. 2 question
what is the best way to close the wallet when i finish
what is the fee for sending ether?
On 15/12/15 12:20, kvhnuke wrote:

Hi Migel,
Server rebooted for maintenance, and I had to manually restart the
geth service
it is back online now :)
-----Original Message-----
From: Taylor Van Orden<EMAIL_ADDRESS>To: kvhnuke/etherwallet<EMAIL_ADDRESS>Sent: Tue, Dec 15, 2015 9:46 am
Subject: Re: [etherwallet] Unable to conect to http: .... (#11)
Hi Migel,
What are you attempting to do when you get this error?
—
Reply to this email directly or view it on GitHub.
—
Reply to this email directly or view it on GitHub
https://github.com/kvhnuke/etherwallet/issues/11#issuecomment-164846325.

when i put 50 ether appear below 49435..... usd , the price in incorrect
in that zone.
On 15/12/15 12:20, kvhnuke wrote:

Hi Migel,
Server rebooted for maintenance, and I had to manually restart the
geth service
it is back online now :)
-----Original Message-----
From: Taylor Van Orden<EMAIL_ADDRESS>To: kvhnuke/etherwallet<EMAIL_ADDRESS>Sent: Tue, Dec 15, 2015 9:46 am
Subject: Re: [etherwallet] Unable to conect to http: .... (#11)
Hi Migel,
What are you attempting to do when you get this error?
—
Reply to this email directly or view it on GitHub.
—
Reply to this email directly or view it on GitHub
https://github.com/kvhnuke/etherwallet/issues/11#issuecomment-164846325.

another time, no show me my ethers only say loading.... in 3 lines, what
happen?
El 15/12/15 a las 12:20, kvhnuke escribió:

Hi Migel,
Server rebooted for maintenance, and I had to manually restart the
geth service
it is back online now :)
-----Original Message-----
From: Taylor Van Orden<EMAIL_ADDRESS>To: kvhnuke/etherwallet<EMAIL_ADDRESS>Sent: Tue, Dec 15, 2015 9:46 am
Subject: Re: [etherwallet] Unable to conect to http: .... (#11)
Hi Migel,
What are you attempting to do when you get this error?
—
Reply to this email directly or view it on GitHub.
—
Reply to this email directly or view it on GitHub
https://github.com/kvhnuke/etherwallet/issues/11#issuecomment-164846325.

hello now, the wallet is accepted but no appear how many ethers i have only
loading
loading
loading
El 15/12/15 a las 11:46, Taylor Van Orden escribió:

Hi Migel,
What are you attempting to do when you get this error?
—
Reply to this email directly or view it on GitHub
https://github.com/kvhnuke/etherwallet/issues/11#issuecomment-164837290.

i attempting to send ethers but no appear only
loading
loading
loading

what happen continue saying loading loading and loading , not appear the
quantity of ethers that i have?
what happen?

Same story here,
account balance
loading,...
loading,...
loading,...
and unable to transfer funds

@kvhnuke is on a plane for like 24 hours or some craziness. When he lands and gets internet, he'll restart the server and fix it. Sorry. :(

ok thanksThumbs up
Date: Thu, 17 Dec 2015 01:23:07 -0800
From<EMAIL_ADDRESS>To<EMAIL_ADDRESS>CC<EMAIL_ADDRESS>Subject: Re: [etherwallet] Unable to conect to http: .... (#11)
@kvhnuke is on a plane for like 24 hours or some craziness. When he lands and gets internet, he'll restart the server and fix it. Sorry. :(
—
Reply to this email directly or view it on GitHub.

sorry for the inconvenience, I just had the chance to fix it, let us know if you run into any other issues


Some pages are loading slowly

Traffic has increased so I need to look into performance tuning.

Note: Turning on Cloudflare breaks the server, because HTML/JSON pages get mixed up

Cloudflare is also returning 403 for webfinger queries from my instance and my home connection…
I suspect that it gets very confused by non-browsers sending requests

Thanks for letting me know! I just turned off Cloudflare for webfinger
I was getting a ton of requests, so I might have to figure out an alternate solution

curl -v -H 'Accept: application/ld+json'<EMAIL_ADDRESS>still 403 from here 😕
a header says:
report-to: {"endpoints":[{"url":"https:\/\/a.nel.cloudflare.com\/report\/v3?s=9PgUA%2FoXymOv8f6L4lXi149mAUHRjFHdNns2lAvj%2FtGBrtJnSmHprK7APhjgGOfFWr6Gp0mbkEgdsMoLfoUb8UmmuO3ov8k7cnEE2Xfmyo8omiiTD8jjQHM5VIusJA%3D%3D"}],"group":"cf-nel","max_age":604800}

if it helps any
I appreciate that running a popular fedi node is a pain!

@dakkar That's interesting -- I got the same thing when curling but updated some configuration settings in Cloudflare.
Would you mind to try again?

@dakkar Oh also that will give you an XML version... There is no ld+json version, only application/json and application/jrd+application

ah! I'm not sure what mimetypes my Misskey instance asks for, but it works now!
Thanks you for the very quick response!

Traffic has reduced and this is less of an issue now.
Just noting that Cloudflare isn't really helpful in this case (due to the vary header). May need to look into alternate solutions

This was a different problem today actually! The site should be working again. 😅


Use RX2 other then SF12BW125 ? for DOWNLINK

Can i change RX2 from default SF12BW125 to another SF?
it seems if i change to let say SF8BW125, nodes never get the packet
do BeeLan force 1.0X LoRaWAN Regional Parameters to SF12BW125 ?
problem: CLASS C+OTAA
With SF7->SF12 i can use OTAA and all are OK.
using SF12BW125 for DOWNLINK on RX2 all OK.
change RX2 to another SF for DOWNLINK, and nodes never gets packet.

OK .. it seems its allways listen to SF12 ..
*****************************************************************************************
* Description : Function to switch RFM to continuous receive mode, used for Class C motes
*
* Arguments   : *LoRa_Settings pointer to sSettings struct
*****************************************************************************************
*/
void RFM_Continuous_Receive(sSettings *LoRa_Settings)
{
  //Change DIO 0 back to RxDone and DIO 1 to rx timeout
  RFM_Write(RFM_REG_DIO_MAPPING1,0x00);

  //Invert IQ Back
  RFM_Write(RFM_REG_INVERT_IQ, 0x67);
  RFM_Write(RFM_REG_INVERT_IQ2, 0x19);

	//Change Datarate and channel.
  // This depends on regional parameters
#ifdef EU_868
  RFM_Change_Datarate(SF12BW125);
  RFM_Change_Channel(CHRX2);
#else
	RFM_Change_Datarate(LoRa_Settings->Datarate_Rx);
	RFM_Change_Channel(LoRa_Settings->Channel_Rx);
#endif

	//Switch to continuous receive
	RFM_Switch_Mode(RFM_MODE_RXCONT);
}

so if i change
#ifdef EU_868
  RFM_Change_Datarate(SF12BW125);
  RFM_Change_Channel(CHRX2);
#else

to
#ifdef EU_868
  RFM_Change_Datarate(SF8BW125);
  RFM_Change_Channel(CHRX2);
#else

.. the node can get packet. When RX2 of NS are also SF8BW125.
is the ADR implementation job, to change that? can ADR also change the Listen SF?

i can see in the gateway:
"FCnt": 10,
            "FOpts": [
                {
                    "CID": "RXParamSetupReq",
                    "RX1DRoffset": 0,
                    "RX2DataRate": 2,
                    "RX2Frequency": 869525000
                }
            ]

is this the MAC command "RXParamSetupReq" to change RX? on the node?

Check release 2.0.0


Incorrect define replacement in build

Describe the bug
When building a project that uses import.meta.env.UNKNOWN, it is being replaced as MODE:"production",DEV:!1,PROD:!0}.UNKNOWN instead of ({}).UNKNOWN.
Ref https://github.com/vitejs/vite/pull/8090 (Additional context)
Bug introduced in #5972 in Vite 3. Line 50 is never being used, and skips to line 51 instead.
https://github.com/vitejs/vite/blob/908c9e4cdd2cceb0f01495e38066ffe33c21ddb8/packages/vite/src/node/plugins/define.ts#L42-L53
This not only happens for import.meta.env., but process.env. to for ssr builds. And other similar usage.
Reproduction
Vite 3: https://stackblitz.com/edit/vitejs-vite-b1md2x?file=main.js&terminal=build,preview
Vite 2.9: https://stackblitz.com/edit/vitejs-vite-ouwh65?file=main.js&terminal=build,preview
System Info
Vite 3

Used Package Manager
pnpm
Logs
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to https://github.com/vuejs/core instead.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

@tony19 it does not seem like https://github.com/vitejs/vite/pull/9791 fixes the issue.
The problem lies in the negative lookahead in the regex used for replacements, it will never match "import.meta.env." (or any other .-ending replacement) because it rejects the match when it's followed by a letter or a number.
Sent a PR addressing this issue directly in https://github.com/vitejs/vite/pull/10958 with tests.


jwt_authn: write JWT payload to dynamic metadata

Description: Use dynamicMetadata in the StreamInfo to pass all successfully verified JWT payloads to other HTTP filters.
Risk Level: Low
Testing: Add unit-tests

It was https://github.com/envoyproxy/envoy/pull/4698
It was accidentally closed.

@diemtvu, @yangminzhu and me discussed if we want to use recent introduced FilterState to pass payload and decided to continue to use dynamicMetadata with following reasons:

FilterState may not be ready. It is not clear where to put these data object class definitions.
dynamicMetadata is not going to run away soon. RBAC filter is still using dynamicMetadata,

If RBAC filter decided to not supporting dynamicMetadata,  this fitler will switch to use FilterState.

Using dynamic metadata is totally fine and they exists along with FilterState. You cannot add a FilterState without modifying RBAC filter to support it so in this case it should be dynamic metadata.

Sorry, I was out last week.

@lizan could you help to merge this?

@htuch can we merge this? I think we talked about potential deprecation of metadata but I don't think that should block this?