[SP-3711][PDI-14346] Error handling in Insert/Update from sub transformation

[SP-3711][PDI-14346] Error handling in Insert/Update from sub transformation
-added returning false in error case

Build Completed
:white_check_mark: This pull request has passed all validations.
Build Commands
ant -Dtestreports.dir=bin/reports/unit-test -f engine/build.xml clean-all resolve jacoco && ant -f engine/build.xml checkstyle publish-local

Cleanup Commands
rm -r ~/.ivy2/local || echo no publish local to remove

Changed files
  engine/src/org/pentaho/di/trans/steps/insertupdate/InsertUpdate.java
  engine/test-src/org/pentaho/di/www/RunTransServletTest.java

Unit test coverage change
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.
org.pentaho.di.trans.step.StepMeta

Instruction Change: -.19%:small_red_triangle_down:
Line Change: -.27%:small_red_triangle_down:

org.pentaho.di.trans.steps.insertupdate.InsertUpdate

Branch Change:  + 2.94%
Complexity Change:  + 1.32%
Instruction Change:  + 2.93%
Line Change:  + 5.19%

org.pentaho.di.trans.steps.sortedmerge.SortedMergeMeta

Instruction Change:  + .18%

org.pentaho.di.trans.steps.symmetriccrypto.symmetriccryptotrans.SymmetricCryptoTransMeta

Branch Change:  + 3.33%
Complexity Change:  + 1.85%
Instruction Change:  + .28%

org.pentaho.di.trans.steps.uniquerows.UniqueRowsMeta

Instruction Change: -.18%:small_red_triangle_down:

@mchen-len-son, @mbatchelor Could you please review and merge it?


[xeus] Update to 0.19.1

TODO: Fix usage when built as a static library.

As always, thanks for the PR!


[eCBIS] Adding eCBIS specific questionnaire to the app

Context

Currently, the eCBIS app runs a different set of questionnaires that do not mimic the client's content.
This addresses the addition & configuration of these questionnaires on the app
The forms can be found here.

Task

[x] Push the Add Familly registration to the HAPI FHIR server
[x] Push the Add Familly member registration form to the HAPI FHIR server
[x] Update the form_config to use these new forms.
[ ] Test out the loading of these forms on the app
[ ] Write the related structure maps for the above forms

Acceptance criteria

[ ] The app be able to do the followig

[ ] Load the forms and display them correctly
[ ] Collect & extract data to the respective FHIR resoruces.

Update

The Add Familly registration worked well and the form can be viewed on the app
The Add family member registration breaks and causes a force close on the app
Currently, writing a structure map for the Add Family registration form


Add io_uring to netty-bom

Motivation:
io_uring artifacts are missing from the Netty 4.2.0.Alpha1 BOM
Modification:
add io_uring artifacts to Netty bom/pom.xml
Result:
Netty BOM includes io_uring classes and native artifacts.

CI build failure:

@sullis thanks a lot!


Making FAQs session responsive

Describe the bug
FAQs session is not properly aligned. I can fix it and make the FAQs more responsive and impressive.
Screenshots
FAQs is not aligned in center.

Additional context
Please assign this issue to me.

#806 is doing it


Customized HttpResponse Per Platforms

I am putting HttpResponse into expect/actual class because I knew an interface will be extremely messy for this. It will be very easier to customize it on each platform. I knew the string will be extremely inefficient for large files, so I wanted to give developers better control to handle data how they wanted.
Breaking Change: body in HttpResponse for JVM is ResponseBody.

Looks okay to me! Wondering whether we should still have a common field for something that share across the whole different platforms? e.g. statusCode, possibly more in the future.

Looks okay to me! Wondering whether we should still have a common field for something that share across the whole different platforms? e.g. statusCode, possibly more in the future.

I don't think that is possible for now.

This essentially breaks fuel for use in Kotlin multiplatform. You cannot access statusCode or body in common code


Update .env

Personal setting are not allowed on the source repository. For make personal changes use commits on your repository which you've forked


3d segmentation in point clouds

hi,
i want to use it for 3d segmentation in point clouds,  the model work correctly in ortophotos (Photos in RGB of a point cloud).
I ave seen on your web site somthing about 3d reconstruction, i don`t know if you are developing it or there is already a usefull solution. As my goal is to use it to create 3d segments directly from a 3d picture or just recreating it.

Here are some implementations of SAM in 3D:

Segment Anything 3D

Segment-lidar

References :
1: @misc{yang2023sam3d,
title={SAM3D: Segment Anything in 3D Scenes},
author={Yunhan Yang, Xiaoyang Wu, Tong He, Hengshuang Zhao and Xihui Liu},
year={2023},
eprint={2306.03908},
archivePrefix={arXiv},
primaryClass={cs.CV}
}

2: @misc{yarroudh:2023:samlidar,
author = {Yarroudh, Anass},
title = {LiDAR Automatic Unsurpervised Segmentation using Segment-Anything Model (SAM) from Meta AI},
year = {2023},
howpublished = {GitHub Repository},
url = {https://github.com/Yarroudh/segment-lidar}
}


Sponsor Token Trial

Describe the bug
I had insert the trial sponsor Token, and after it was unvalid evcc wouldnt start anymore.
And i cant change it because i insert it over ui into the database.
Steps to reproduce
I dont know insert a unvalid sponsortoken an restart
Configuration details
Using config file: /config/evcc.yaml
starting evcc: 'EVCC_DATABASE_DSN=/data/evcc.db evcc --config /config/evcc.yaml'
[main  ] INFO 2024/12/13 11:00:04 evcc 0.131.11
[main  ] INFO 2024/12/13 11:00:04 using config file: /config/evcc.yaml
[db    ] INFO 2024/12/13 11:00:04 using sqlite database: /data/evcc.db
[main  ] INFO 2024/12/13 11:00:05 listening at :7070
[main  ] FATAL 2024/12/13 11:00:05 sponsortoken: rpc error: code = Unknown desc = token has invalid claims: token is expired
[main  ] FATAL 2024/12/13 11:00:05 will attempt restart in: 15m0s

Log details
Using config file: /config/evcc.yaml
starting evcc: 'EVCC_DATABASE_DSN=/data/evcc.db evcc --config /config/evcc.yaml'
[main  ] INFO 2024/12/13 11:00:04 evcc 0.131.11
[main  ] INFO 2024/12/13 11:00:04 using config file: /config/evcc.yaml
[db    ] INFO 2024/12/13 11:00:04 using sqlite database: /data/evcc.db
[main  ] INFO 2024/12/13 11:00:05 listening at :7070
[main  ] FATAL 2024/12/13 11:00:05 sponsortoken: rpc error: code = Unknown desc = token has invalid claims: token is expired
[main  ] FATAL 2024/12/13 11:00:05 will attempt restart in: 15m0s

What type of operating system are you running?
HomeAssistant Add-on
Nightly build

[X] I have verified that the issue is reproducible with the latest nightly build

Version
0.131.11

Trial Token ist erneuert.


Switching the is helpers to return boolean

Switched the isEnum/Bitmap/Struct helpers to return booleans. Changed the tests to reflect the same
Updated the asUnderlyingZclTypeWithPackageId and zcl_command_argument_data_type helpers to account for tyhe boolean returns and cleaned up the helpers

Github: ZAP#413

A couple of worries on this.
I have some concerns with backwards compatibility for this incase we were/are using these in our zigbee pro and matter templates before. The isEnum/Bitmap/Struct helpers go through promises so using them with an if can result in an if(unresolved promise) which can return true. I am wondering if I should not export these from the helper-zcl.js for templates and just use these internally.

can result in an if(unresolved promise) which will return true

This is a huge footgun in general.  Is there any way to make that fail?


ci: add testing with Python 3.10 and Ubuntu 22.04

This PR adds testing for Python 3.10 and also adds testing via GH actions since Travis doesn't seem to be working. This confirms that the new Ubuntu LTS release (22.04) which defaults to python 3.10 can't run tests successfully (related to #79).

This highlights the issue with Python 3.10 reported here: https://discord.com/channels/484546513507188745/495696706638184482/973779582333374475

Great idea adding this! Instead of repeating the same workflow twice, is it possible to use a two-dimensional matrix instead, one for the python version and one for the ubuntu version?

Great idea adding this! Instead of repeating the same workflow twice, is it possible to use a two-dimensional matrix instead, one for the python version and one for the ubuntu version?

Yes, that worked great. Thanks for the suggestion :+1:

Closing for now because #80 added tests matching the previous Travis setup and this PR can't pass until Sentinel is updated to support Python 3.10.


Some devices not working properly with mitmproxy

Steps to reproduce the problem:

Start mitmproxy with --htpasswd so users can authenticate
Enter the proxy and authentication details on the phone
Browse around and get HTTP requests logged in the GUI

What is the expected behavior?
Expected behavior is every phone should get the requests logged. And when I say logged, I simply mean showing the status code, showing the URL, showing all that good stuff basically. What mitmproxy GUI is made for.
What went wrong?
Some devices connect fine, but the data is not being logged in certain applications. Browsers seem to work fine, but other applications does not work on all phones (even though they're the exact same version across all devices).
Any other comments?

I have a suspicion, that the proxy settings (when applied to the WiFi network), does not have "permission" to change the proxy settings for the whole device. Maybe some applications are whitelisted (like Safari, Google Chrome, etc.).
This was tested on various iPhones and Android devices running different ROMs and manufacturers.
Check my StackOverflow question for a more in-depth version: http://stackoverflow.com/questions/37154922/mitmproxy-htpasswd-doesnt-work-for-most-people

Mitmproxy Version: 0.18
Operating System: Debian 8.4 or Debian 8.3 (tried both)

http://docs.mitmproxy.org/en/latest/modes.html#regular-proxy

Unfortunately, some applications bypass the system HTTP proxy settings - Android applications are a common example. In these cases, you need to use mitmproxy’s transparent mode.

@mhils Transparent mode does not work with any of the 3 authentication modes. --nonanonymous, --singleuser, or --htpasswd.


Where are those default control styles (win2.x)?

such as NavigationViewItemPresenter

where is MUX_NavigationViewItemPresenterStyleWhenOnTopPane ?

Is winui all code open sourced?

I need it.
ms-appx://Microsoft.UI.Xaml.2.7/Microsoft.UI.Xaml/Themes/19h1_generic.xaml

You should be able to find it inside the packages folder of your project.

no, I searched 19h1_generic.xaml using everything. it is not on my disk.

You should be able to find it inside the packages folder of your project.

I found no packages folder in my project.

You should be able to find it inside the packages folder of your project.

I found no packages folder in my project.

Check under the root folder where the solution is, not the project folder.

no winui related stuff.

@HppZ If you don't find the WinUI 2 package there, you might want to try %USERPROFILE%/.nuget/packages, it might be in there (with bunch of other packages). To answer the original question, all the styles that ship with WinUI 2 are open source and are available on this repository.

@HppZ If you don't find the WinUI 2 package there, you might want to try %USERPROFILE%/.nuget/packages, it might be in there (with bunch of other packages). To answer the original question, all the styles that ship with WinUI 2 are open source and are available on this repository.

found .nuget\packages\microsoft.ui.xaml\2.7.0\lib\uap10.0\Microsoft.UI.Xaml\Themes\Generic.xaml, but some styles does not exist:

and where is Slider's source code?

and where is Slider's source code?

Slider is part of the system and not WinUI 2.x

@HppZ If you don't find the WinUI 2 package there, you might want to try %USERPROFILE%/.nuget/packages, it might be in there (with bunch of other packages). To answer the original question, all the styles that ship with WinUI 2 are open source and are available on this repository.

found .nuget\packages\microsoft.ui.xaml\2.7.0\lib\uap10.0\Microsoft.UI.Xaml\Themes\Generic.xaml, but some styles does not exist:

@Jaiganeshkumaran @chingucoding where are styles start with MUX?

Some styles are not in the generic.xaml file but rather imbedded into themeresources that are part of the appx package iirc. You can search for the style in this GitHub repository though: https://github.com/microsoft/microsoft-ui-xaml/search?q=MUX_NavigationViewItemPresenterStyleWhenOnTopPane

Some styles are not in the generic.xaml file but rather imbedded into themeresources that are part of the appx package iirc. You can search for the style in this GitHub repository though: https://github.com/microsoft/microsoft-ui-xaml/search?q=MUX_NavigationViewItemPresenterStyleWhenOnTopPane

only found MUX styles for RS1. I need the latest.

@HppZ The OS version inside the file name indicate the lowest supported OS for those styles. Unless overridden by a file with a higher OS version, the styles inside the RS1 will be used for all OS versions that are RS1 and newer. Since those styles are only defined in RS1 files, those are the styles you are searching for.


Added Footer

Please, go through these steps before you submit a PR.

[x] My Pod Leader knows I'm working on this Pull Request
[x] I've explained what the Pull Request is adding.
[x] I've explained why this is important.

We have added a footer to the home page of the website. It contains links to blog, about, Socials, project . As of now they are linked to the home page
Having a footer in website is very important as  it serves the purpose  to signal to the user that they are at the bottom of the web page and to provide links or shortcuts to other areas of your web site.
We have implemented this by adding footer elements in  footer.html  and adding it into index.html file. Css for the footer is added in footer.scss file.
This is how It looks

Closes #1

Pending links for footer items before merge


Exclude files from the linter

ngc generates declaration files that are getting linted.
Could you provide a config option that we could use to exclude those files by setting a glob pattern or is there another way to exclude those files?

Good idea, we'll add it to our backlog. Thanks!
Thanks,
Dan

@danbucholtz It seems everything in the node_modules get linted. Is it possible excluding entire node_modules folder from the check?

@DenisVuyka, it shouldn't be, but we'll look into it when we do this.
Thanks,
Dan

I believe this is resolved now. Please let me know if it's not.
Thanks,
Dan


News: Scipy 0.16.1 and Numpy 1.10.1 releases.

0.16.1 tag should be pushed tomorrow morning, when the binaries are built and uploaded.


Remove patch of sys.path and PYTHONPATH which are not needed

This PR removes some patching of the environment in the snapshot qt directive that is not friendly with debian packaging.
closes #2603

LGTM


SQLSTATE[HY000] [2006] MySQL server has gone away while the setup

Attempted Debugging

[X] I have read the debugging page

Searched GitHub Issues

[X] I have searched GitHub for the issue.

Describe the Scenario
I've do exactly all the things what you describe in the page here: https://www.bookstackapp.com/docs/admin/installation/ and from the step "artisan migrate" I got the following error:
In Connection.php line 760:
  SQLSTATE[HY000] [2006] MySQL server has gone away (SQL: select * from information_schema.tables where table_schema = db3 and table_name = migrations and table_type = 'BASE TABLE')

In Connector.php line 70:
  SQLSTATE[HY000] [2006] MySQL server has gone away

Of course the database is available at 3306 and all other instances are working well. Also I've tried with a change of passwords. Without any success.
Exact BookStack Version
v23.08.3
Log Content
n/a
Hosting Environment
KeyHelp Self Hosted Environment, Debian 11 with latest composer and PHP8

Hi @pthoelken,
This is not something I've experienced myself.
Possibly due to the specific way users are created via the control panel used?
Could try following the guidance here:
https://php.watch/articles/PHP-7.4-MySQL-8-server-gone-away-fix

Hi @ssddanbrown,
Thanks for your quick reply. When I do this form your link I got the following errors:
MariaDB [mysql]> ALTER USER 'user_db3'@'localhost' IDENTIFIED WITH caching_sha2_password BY 'XXX';
ERROR 1064 (42000): You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'BY 'XXX'' at line 1

@ssddanbrown  - The problem is not the user account in mysql local. It's a problem by this configuration line which is enabled by default:
MYSQL_ATTR_SSL_CA="/path/to/ca.pem"
When I disable this line, the database will be created successfully. Maybe this line should be disabled by default in the .env.complete? You can close this issue.

@pthoelken Thanks for confirming, yeah, please only copy values from .env.example.complete where required.
It's not meant to be used as a basis for a .env file (Hence the warning that the top of the file.)


Fix find_uv_bin to find uv with system site packages

Summary
This allows uv to find its binary when it was installed as a system package. Current implementation fails if someone creates a venv with --system-packages because the relative uv path would be different.
Fixes: #10194
Test Plan

@charliermarsh please take a look at this and its bug. Let me know if further changes are needed as this is a blocker for addressing https://github.com/tox-dev/tox-uv/issues/109 and in fact can happen easily even without tox. As soon you create a venv and install uv in it, once you try to create a new one, you may discover that you have an unusable uv package.

As soon you create a venv and install uv in it, once you try to create a new one, you may discover that you have an unusable uv package.

To be clear, this should not work by design
❯ uv venv one
Using CPython 3.13.1
Creating virtual environment at: one
Activate with: source one/bin/activate
❯ uv venv two
Using CPython 3.13.1
Creating virtual environment at: two
Activate with: source two/bin/activate
❯ uv pip install -p one uv
Using Python 3.13.1 environment at: one
Resolved 1 package in 181ms
Prepared 1 package in 1.12s
Installed 1 package in 7ms
 + uv==0.5.13
❯ ./one/bin/python -c "import uv; uv.find_uv_bin()"
❯ ./two/bin/python -c "import uv; uv.find_uv_bin()"
Traceback (most recent call last):
  File "<string>", line 1, in <module>
    import uv; uv.find_uv_bin()
    ^^^^^^^^^
ModuleNotFoundError: No module named 'uv'

Do you mean something else?


Methods not inherited by  inherit the EmployeeListNotFoundException

class EmployeeListNotFoundException1 : EmployeeListNotFoundException
{
}
throw new EmployeeListNotFoundException1("test");

the vs for mac ide suggest " the  EmployeeListNotFoundException1 class do not have one parameter constructor function"

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 041f6b4c-2b7e-5332-f24e-12af7a5b07aa
Version Independent ID: e9c2287f-1c4e-ee07-a1ff-77a3f07ce1a4
Content: How to: Create User-Defined Exceptions
Content Source: docs/standard/exceptions/how-to-create-user-defined-exceptions.md
Product: dotnet
Technology: dotnet-standard
GitHub Login: @tdykstra
Microsoft Alias: tdykstra

Add constructor(s) to EmployeeListNotFoundException1 as shown in the example for EmployeeListNotFoundException.

I am new to c#, when I use the Python3, son class can just inherit the init_ class from the parent class. Is there a simple way to bypass define all the constructors again and again

No, you have to define the constructors but you don't have to duplicate the code in them, as constructors in the derived class can call the base class constructor.  See the discussion in this StackOverflow post.

Thank you very much , big help


Make tests stricter for challenge "Decrement a number with javascript"

You can pass the test by assigning 10 to the variable after decrementing it past that value.
It also doesn't seem like the...

myVar = myVar - 1; should be changed.

...test is working.
Incorrect code that is passing:
let myVar = 11;

// Only change code below this line
myVar = myVar - 1;
myVar--;
myVar = 10;

Forum: https://forum.freecodecamp.org/t/decrement-a-number-with-javascript-solution/490852
Challenge: https://www.freecodecamp.org/learn/javascript-algorithms-and-data-structures/basic-javascript/decrement-a-number-with-javascript
Tests: https://github.com/freeCodeCamp/freeCodeCamp/blob/main/curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/decrement-a-number-with-javascript.md

I am happy with this being changed, but, personally, I see no issue here:

The lesson teaches the  -- operator, and that has been used.

If the lesson were to give an h1 element the text Hello, World!, and you did this, I would not expect you to fail the tests:
const h1 = document.querySelector('h1')
h1.textContent = "Hi there!";
h1.textContent = "Hello, World!";

Aside
I might be becoming pessimistic in my teaching pedagogy, but we cannot truly expect to keep changing all these lessons forever, as more and more cases are found - there is a "good enough" point, IMO.

I am happy with this being changed, but, personally, I see no issue here:

The lesson teaches the  -- operator, and that has been used.

If the lesson were to give an h1 element the text Hello, World!, and you did this, I would not expect you to fail the tests:
const h1 = document.querySelector('h1')
h1.textContent = "Hi there!";
h1.textContent = "Hello, World!";

Aside I might be becoming pessimistic in my teaching pedagogy, but we cannot truly expect to keep changing all these lessons forever, as more and more cases are found - there is a "good enough" point, IMO.

Yes, I believe that if a user uses the solution that @lasjorg stated, they know how -- works already, which fulfills the objective of the lesson.

@ShaunSHamilton I don't think your example is equivalent at all. The end value is supposed to be the result of decrementing, not just assigning a final value.

Yes, I believe that if a user uses the solution that @lasjorg stated, they know how -- works already, which fulfills the objective of the lesson.

Clearly, they do not if they can not decrement the starting value to the final value that is asked for. I see no reason why anyone that understands what the challenge is asking for would do that assignment.

I would think a test with a regex that looks for an assignment to be good enough here.

Do not directly assign the value 10 to the myVar variable.

@ShaunSHamilton I don't think your example is equivalent at all. The end value is supposed to be the result of decrementing, not just assigning a final value.

Yes, I believe that if a user uses the solution that @lasjorg stated, they know how -- works already, which fulfills the objective of the lesson.

Clearly, they do not if they can not decrement the starting value to the final value that is asked for. I see no reason why anyone that understands what the challenge is asking for would do that assignment.
We are not just blindly looking for the -- operator to be used. We are looking for the value 11 to be decremented to 10 using the operator.
An example would be a lesson where you ask someone to use a word in a sentence and they use the word incorrectly. They may have used the word but if it is used incorrectly they do not understand the word. Using it in a sentence means correctly using it, not just blindly shoving it into a sentence.
I would think a test with a regex that looks for an assignment to be good enough here.

Do not directly assign the value 10 to the myVar variable.

You're right, my bad. As I understand it, you want to use regex to check if an assignment is present, and if it is, fail the tests?
I think that would work well.

The second test should be updated. Right now you can leave the initial code even though the test says it should be replaced. It should test that myVar = myVar - 1; is not present in the code.

Check that no assignment is used.

The second test should be updated. Right now you can leave the initial code even though the test says it should be replaced. It should test that myVar = myVar - 1; is not present in the code.

Check that no assignment is used.

I see, thank you for the clarification!


Speculative fix for #29262

Description
Per documentation for addStream, we shouldn't be doing things that add to the stream before we've completed.  I suspect the error in #29262 is because we're not awaiting the stderr pipe before we start writing to stderr again.
Related Issues
#29262
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] My PR includes tests for all changed/updated/fixed behaviors (See Test Coverage).
[x] All existing and new tests are passing.
[x] I updated/added relevant documentation (doc comments with ///).
[x] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change (Please read Handling breaking changes).
[x] No, this is not a breaking change.

Hm.  It looks like this also contains some fixes I meant to land in the last PR for this but didn't... but all of these changes should go in.


Types aren't correctly exported for CJS

Description
Typescript with "moduleResolution": "node16" will generate an error when trying to import the module from a cjs file.
Could not find a declaration file for module 'openapi-typescript'. '/node_modules/openapi-typescript/dist/index.cjs' implicitly has an 'any' type.
  Try `npm i --save-dev @types/openapi-typescript` if it exists or add a new declaration (.d.ts) file containing `declare module 'openapi-typescript';`ts(7016)

Name
Version

openapi-typescript
7.4.4

Node.js
22.9.0

Reproduction
Check here : https://arethetypeswrong.github.io/?p=openapi-typescript%407.4.4
Checklist

[x] My OpenAPI schema passes the Redocly validator (npx @redocly/cli@latest lint)
[x] I’m willing to open a PR (see CONTRIBUTING.md)

I think the package.json of each module should be something like :
"exports": {
    "./package.json": "./package.json",
    ".": {
      "import": {
        "types": "./dist/index.d.ts",
        "default": "./dist/index.js"
      },
      "require": {
        "types": "./dist/index.d.ts",
        "default": "./dist/index.cjs"
      }
    }
  },


Emit event on filtered.

Emit event on filtered, so parent can listen when filter changed.
I believe this event is important, since we can't implement network search functionality without this (except with some additional hacks).

LGTM!


statusbar overlap over when using toolbar insteed of default actionbar

statusBar overlap with custom toolbar when using toolbar instead of default actionBar

and when using android:fitsSystemWindows="true"

I have the same exact problem. Any solution for that?

same


Cannot debug extension when building with webpack

This issue has already been discussed in #85713, however I don't understand the explanation at all:
Problem
When debugging, source-mapping/path-mapping doesn't work and breakpoints always stay gray.
Trace says things like: [06:14:51.462 UTC] SourceMap: mapping webpack:///./src/index.js => ${cwd}\src\index.js, via sourceMapPathOverrides entry - "webpack:///./*": "${cwd}/*"
More info

I am developing an extension, and have an extensionHost launch config
The project is located in a multi-root project.
I am building it with webpack, very similar to the webpack sample.

Related Work

In this issue it is said that setting cmd is not necessary because "The debugger should handle this rather than require the user to, and it should actually be handling this correctly in vscode-pwa already" -> I'm not sure what vscode-pwa is and how it relates to this?
@roblourens also mentions that "The new adapter takes a new strategy which should avoid some of the issues with this in the original adapter.". What is said "new adapter" and how can I get it?

Any suggestions as to how I can debug my extensions?

Yeah - Finally working!
Looked closely through the webpack-sample again, and found I forgot to add devtoolModuleFilenameTemplate: "../[resource-path]" to my webpack.config's output.


stackup import enhancement

@ansys-reviewer-bot review

@ring630 I think you need to fix the Unit test and also add more unit tests to increase the coverage. Thanks!


[CSL-143] Improve logging configuration in local scripts (dunno about deployment)

@gromak
CSL-122 is closed now, but I don't like several things about it, namely:

There is kademlia logger name in template, it's strange, because we have logic which maps dht name into actual logger name we use for DHT stuff.
Severity of node logger is {{server}}, lolwhat?
{{main}} (which is MAIN_LOG) is severity of mempty, but it was severity of node.
All node logs are dumped into one single file. I think it's ok to have such file, but I also to want to have other files, e. g. for node.server so that I can see only server logs when I am only interested in them. Also current logic is not the same as it was before, because previously all logs where dumped to file, but now only node logs. If logging to files doesn't impose big overhead, I want to have many files.
I want default severity in scripts (not in application) to be Debug, because people often encounter bugs and w/o Debug severity it's hard (and sometimes impossible) to understand something important from logs.
I don't like that we still use environmental variables like COMM_LOG, MAIN_LOG, etc. I find it much more convenient to modify yaml file instead of using these variables.
I don't like that I need to stash my logging config (which I use locally) when I need to checkout or something.

4. I want at least the following files: with global logs (i. e. mempty), with node logs (i. e. subset of previous), with node.server and node.worker logs. Ideally someone needs to investigate overhead of logging to file. If it's too big, let's have only global logs. It all applies to default template of course, everyone is free to use whatever configuration he wants locally.
5. Set mempty severity to Info/Notice/Warning (not sure), set node severity to Debug.
6. Stop using these environmental variables, remove all placeholders except {{file}} from template.
7. Add environmental variable to set path to logging yaml config and launch system using LOG_CONFIG=my_config.yaml scripts/launch.sh. my_config.yaml won't be in git. We can put it into .gitignore for convenience. We can even add one more script which will run launch.sh with LOG_CONFIG=my_config.yaml.

@gromak
Nobody commented, so I've assigned it to me and will do it soon.

@gromak
1, 2, 3. Fixed.
4. I have added some files, I don't think they will make performance significantly worse. Even if they make it worse, it's only local deployment after all. This part partially depends on CSL-53.
5, 6, 7. Done.

@gromak
I am satisfied and nobody else cares, so I am closing it.


Fix typo

a Azure -> an Azure

@changeworld : Thanks for your contribution! The author, @mattbriggs, has been notified to review your proposed change.

Merging typo fix.


Feature request: Specify the path to the tsconfig

I'm working on template for creating electron applications. In src are several  entry points. Each has its own tsconfig and vite.config. And no tsconfig is at the root of the project.

In vite@2, Rollup plugins are valid Vite plugins, so you could try one of them if you'd like:
https://www.npmjs.com/search?q=rollup typescript paths
Otherwise, PR welcome!

I'm working on upgrading vite-tsconfig-paths to work with vite@2, since none of the Rollup plugins use the tsconfig-paths package like I do. I'm planning on using the root option from vite.config.js as the directory to search for tsconfig.json. Will that work for your use case?

Nope. In my case, there are several entry points, they have their own tsconfig and they are all deeper than the root.

Nope. In my case, there are several entry points, they have their own tsconfig and they are all deeper than the root.

@cawa-93 Ah ok. You said they each have their own vite.config.js, but I suppose the root is still defaulting to process.cwd() for each of them.
If you install vite-tsconfig-paths@next and vite@next, you can do this:
import tsconfigPaths from 'vite-tsconfig-paths'

export default {
  plugins: [
    tsconfigPaths({ root: __dirname }),
  ]
}

@cawa-93 Ah ok. You said they each have their own vite.config.js, but I suppose the root is still defaulting to process.cwd() for each of them.
If you install vite-tsconfig-paths@next and vite@next, you can do this:
import tsconfigPaths from 'vite-tsconfig-paths'

export default {
  plugins: [
    tsconfigPaths({ root: __dirname }),
  ]
}


No playback of recorded "Remote"-Tracks

Hi,
Maybe I am stupid, but I can´t get recorded "Remote"-Tracks to be played back after the recording. (The 2 speaker tracks get played well.)
During playback the "Remote"-channels show no level meter in their respective mixer; the sound of the "Remote"-Tracks is not routed to the master mixer although the "Master" box is checked in the routing for track 2.
Any idea?
Thanks.
Philip

Yes this is something related how the plugin works. You just need to disable the plugin. But be carefull you must disable the cross routing between the tracks. On reaper you can automate this with a routing snapshot. it also saves the state of the plugins. In the next days I will make a video.

Ah, cool. Thanks!

Am 06.01.2016 um 17:58 schrieb Sebastian Reimers<EMAIL_ADDRESS>Yes this is something related how the plugin works. You just need to disable the plugin. But be carefull you must disable the cross routing between the tracks. On reaper you can automate this with a routing snapshot. it also saves the state of the plugins. In the next days I will make a video.
—
Reply to this email directly or view it on GitHub.

But the "Allow feedback in routing" option is not saved by snapshots, is it?

IMHO: its not saved by snapshot, because its a project setting.
But I'm not 100% sure.

Here it is not saved with a snapshot.
But you want to find a way, because deactivating the fx with the "allow feedback in routing“ option actived hurts. Really hurts.

Am 06.01.2016 um 18:34 schrieb Sebastian Reimers<EMAIL_ADDRESS>IMHO: its not saved by snapshot, because its a project setting.
But I'm not 100% sure.
—
Reply to this email directly or view it on GitHub.

Yes sry, thats why you should be carefull and disable the cross routing between the tracks first! Sry if this was not clear enough in my earlier post.

No, you were perfectly clear, I just clicked the wrong button ;)

Am 06.01.2016 um 18:45 schrieb Sebastian Reimers<EMAIL_ADDRESS>Yes sry, thats why you should be carefull and disable the cross routing between the tracks first! Sry if this was not clear enough in my earlier post.
—
Reply to this email directly or view it on GitHub.


Newlines in table get replaced with space, causing rendering issues

Hello!
We're using mdpo for the translation of the AntennaPod website. Now that we're getting in the first translations, we've noticed that newlines in tables are replaced with spaces when the PO(T) are created, and that this messes up the rendering of the table.
The following table:
| Key | Action |
| -- | -- |
|`P` | Play/Pause|
| `J`/`A`/`,` | Rewind media |
| `K`/`D`/`.` | Forward media |
| `+`/`W` | Raise media volume channel |
| `-`/`S` | Lower media volume channel) |
| `M` | Mute/unmute (toggle) media volume channel (only on Android 6 and higher) |

when running
md2po _i18n/en/documentation/*.md --po-filepath _i18n/translation-files/site-documentation.pot --save --quiet

turns into
#: _i18n/en/documentation/playback/shortcuts.md:block 3 (paragraph)
msgid ""
"| Key | Action | | -- | -- | |`P` | Play/Pause| | `J`/`A`/`,` | Rewind media"
" | | `K`/`D`/`.` | Forward media | | `+`/`W` | Raise media volume channel | "
"| `-`/`S` | Lower media volume channel) | | `M` | Mute/unmute (toggle) media"
" volume channel (only on Android 6 and higher) |"
msgstr ""

This, however, creates rendering issues like on this page (en correct, fr not).
I realise that tables are not (yet) part of Commonmark. But given that this actually is just a multiline string, I would expect (based on this article) the PO file to have \n instead of a space.
Would this be possible? Or is there an alternative solution that you can think of (e.g. structuring our MD table slightly differently)?
Many thanks!

Your table is not correctly formatted because separators must have 3 characters or more, so the second line must be | --- | --- | instead of | -- | -- | to be properly parsed. Cheers!


Publish to pypi from CI

See original issue on GitLab
In GitLab by [Gitlab user @jjardon] on Apr 2, 2020, 10:52
AFAIK publishing new releases at https://pypi.org/project/BuildStream/ is a manual process

In GitLab by [Gitlab user @SotK] on Apr 2, 2020, 10:59
There's an example of setting this up in bst-external. Assuming bst is packaged sensibly the exact same code should work here too providing the correct credentials are set in CI variables.

In GitLab by [Gitlab user @SotK] on Apr 2, 2020, 10:59
There's an example of setting this up in bst-external. Assuming bst is packaged sensibly the exact same code should work here too providing the correct credentials are set in CI variables.


JSON-escape strings

Add JSON-escaping for string values (e.g. arguments and filenames) in the output.

At the moment to use basset one needs to run a clean build from zero. But it would be nice to add support for partial builds, when intercepted commands are appended to the existing compile_commands.json instead of overwriting it completely. This will require not just writing, but also reading JSON and will likely require a proper JSON library. Escaping can then also be done using JSON library.
I believe this was my thought process when I decided to completely ignore the need to escape strings in JSON. So maybe instead of implementing our own JSON escaping implementation you can help me pick a good JSON library to use?

I'm trying to implement support for partial builds (with https://github.com/nlohmann/json for JSON handling) and as you recognized it will make this PR obsolete.
BTW, when the new command replaces an existing command(-s?) in the database?  Never?  Meaning, new commands are always appended except for exact duplicates (e.g. same "filename", "directory" and "arguments")?

@d3m3t3r, thank you for your contribution!

This is what I stitched to support incremental update:
https://github.com/d3m3t3r/basset/tree/incremental-update

This is what I come up for the support of incremental update so far: https://github.com/d3m3t3r/basset/tree/incremental-update

@d3m3t3r, don't be shy! Feel free to create a PR. If it is still "work in progress", you can mark it as draft. In any case it will serve as advertisement of your work and upcoming feature in basset.


[Question][Module Name] Devlake ECS Deployment

Hi, I wanted to convert a docker-compose file by defining the individual containers as a registered task onto ECS so I can launch it as a service with the AWS Fargate launch tyoe. How do I define the volumes for ECS and how do I configure the containers with images?

@dosu
What would be the container/volume definitions for this docker-compose file?
version: "3"
services:
grafana:
image: devlake.docker.scarf.sh/apache/devlake-dashboard:v1.0.0
ports:
- 3002:3000
volumes:
- grafana-storage:/var/lib/grafana
environment:
GF_SERVER_ROOT_URL: "http://localhost:4000/grafana"
GF_USERS_DEFAULT_THEME: "light"
MYSQL_URL: "url"
MYSQL_DATABASE: "url"
MYSQL_USER: "user"
MYSQL_PASSWORD: "password"
TZ: UTC
restart: always
#    depends_on:
#      - mysql
devlake:
image: devlake.docker.scarf.sh/apache/devlake:v1.0.0
ports:
- 8080:8080
restart: always
volumes:
- devlake-log:/app/logs
env_file:
- ./.env
environment:
LOGGING_DIR: /app/logs
TZ: UTC
#    depends_on:
#      - mysql
config-ui:
image: devlake.docker.scarf.sh/apache/devlake-config-ui:v1.0.0
ports:
- 4000:4000
env_file:
- ./.env
environment:
DEVLAKE_ENDPOINT: devlake:8080
GRAFANA_ENDPOINT: grafana:3000
TZ: UTC
#ADMIN_USER: devlake
#ADMIN_PASS: merico
depends_on:
- devlake
volumes:
mysql-storage:
grafana-storage:
devlake-log:

When networkMode=awsvpc, the host ports and container ports in port mappings must match.
How can i change the Grafana ports that are 3002 and 3000 to match this

@dosu
is 3000:3000 allowed to be used?

How do I configure docker volumes for MySQL-storage, grafana-storage and devlake-log


Undeclared SwiftSyntaxMacroExpansion dependency on SwiftOperators

Description
When building with --explicit-target-dependency-import-check error, swift-syntax fails to build due to the error: error: Target SwiftSyntaxMacroExpansion imports another target (SwiftOperators) in the package without declaring it a dependency..
Steps to Reproduce
swift build --explicit-target-dependency-import-check error on the 5.9 release.

Tracked in Apple’s issue tracker as rdar://117004722

I believe that Pull Request #2285 from @mbrandonw will resolve this issue.

Fixed by https://github.com/apple/swift-syntax/pull/2285


There's no way to change UNPACK_FLIP_Y_WEBGL in a texture

In the Texture class, these 2 lines (line 51-52) don't give the ability to pass alternate values in the options array:
gl.pixelStorei(gl.UNPACK_FLIP_Y_WEBGL, false);
gl.pixelStorei(gl.UNPACK_PREMULTIPLY_ALPHA_WEBGL, false);

I suggest to permit these values to be changed.
This is for example mandatory to create a video texture with gl.UNPACK_FLIP_Y_WEBGL set to true in your 'sphere-inner-texture' demo if you don't want the video to be reverted.

@gregorybesson
Thank you for the suggestion. We will be working to provide this feature with a simple API.

Hello Farhad, how a re you doing ?
I've made a PR yesterday. You don't like it ?

Hi @gregorybesson , @redwoodfavorite  and I have reviewed the PR and it looks good.

@FarhadG and @redwoodfavorite: this fix will make the sample of Joseph much better as the video on sphere-inner-texture.js won't be reverted anymore !
And the fix for #82 will make a perfect render on iOS retina displays.


feat(conn): move time-consuming ops out of ExecuteCommand for context

The scope (position of destruction) is important for Context, so we should move time-consuming ops like FeedMonitorConns out of ExecuteCommand so that the context can be destructed before these ops. (especially after we move key locking into ExecuteCommands)

cc @PokIsemaine


SQFormDropdown not Orange in Error State

When the SQFormDropdown component falls into an error state, its label and input bottom border line doesn't change to Orange.
See Example Screenshot

:tada: This issue has been resolved in version 3.2.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Add Wikipedia/Wikia web crawler for facts-seeking questions

This relates to #8. After a input is classified as facts-seeking, then we need to make an API call or write a crawler to find the response
Find key words from query to answer

Me and Aditya will be working on this issue.

this could be helpful:
http://textminingonline.com/getting-started-with-keyword-extraction

Me, @arvindsaik , and @aditya5558 will be working on this issue

Done along with question generation. Look into #20 #21


Update systemd to always restart kubelet to support dynamic kubelet configuration

Description of changes:
We were trying to enable dynamic kubelet configuration on our cluster but the new nodes failed to become ready because systemd didn't restart kubelet.service after it cleanly terminated to reload the new configuration.
kubelet reloads dynamic configuration by exiting the process with code 0 and assume that a babysitter process will restart the service. We should configure systemd to restart kubelet on exit code 0 as well (or use Restart=always).
See:

https://kubernetes.io/docs/tasks/administer-cluster/reconfigure-kubelet/#understanding-how-the-kubelet-checkpoints-config
https://github.com/kubernetes/kubernetes/blob/4c00c3c459261e8ff3381c1070ddf798f0131956/pkg/kubelet/kubeletconfig/configsync.go#L191-L207

Workaround
Since we are already using a userdata script to add --dynamic-config-dir as an extra argument, we add the below script to append the exit code to kubelet.service configuration.
cat << EOF > /etc/systemd/system/kubelet.service.d/90-restart-on-exit-code-0.conf
[Service]
RestartForceExitStatus=0
EOF

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

If I remember correctly, Dynamic Kubelet config was stuck in beta for a long time, and SIG-Node has discussed removing it due to a lack of understanding usage and not having an advocate in the SIG. If this is a feature that you depend on, that's something you should be aware of. I would share your use case with them, and I'm happy to help advocate if I understand your use case.

@mmerkes Thanks for the heads up! I didn't know that.
Our team is in a process of migrating from Kops to EKS and we are trying to achieve feature parity with what we have on Kops. We use Dynamic Kubelet Config mainly to configure system resource reservation and eviction thresholds dynamically without the need to rolling update the whole cluster (similar to https://github.com/kubernetes/enhancements/issues/281#issuecomment-695751859). This has been especially useful when we run into out-of-resource issues on the nodes and need to quickly tune the cluster outside of the maintenance window. While it would not break our clusters if the feature ends up getting deprecated, it would slow down our development and operational speed unless an alternative is offered.


Delete empty account at BEACON_ROOTS_ADDRESS

What was wrong?
The current implementation of EIP-4788 did not delete the account at BEACON_ROOTS_ADDRESS if it is empty after being touched by the system message call. For example, in a case where the contract has not been deployed yet. EIP-4788 does not explicitly mention this deletion but it is implied post EIP-161
How was it fixed?
Delete the account at BEACON_ROOTS_ADDRESS if it is empty.

Codecov Report
Attention: 2112 lines in your changes are missing coverage. Please review.

Comparison is base (bf47143) 69.96% compared to head (4938522) 69.83%.
Report is 25 commits behind head on forks/cancun.

Files
Patch %
Lines

src/ethereum/cancun/fork.py
0.00%
236 Missing :warning:

src/ethereum/cancun/vm/instructions/system.py
0.00%
207 Missing :warning:

src/ethereum/cancun/vm/instructions/__init__.py
0.00%
162 Missing :warning:

src/ethereum/cancun/vm/instructions/environment.py
0.00%
153 Missing :warning:

src/ethereum/cancun/state.py
0.00%
149 Missing :warning:

src/ethereum/cancun/vm/interpreter.py
0.00%
112 Missing :warning:

src/ethereum/cancun/vm/instructions/arithmetic.py
0.00%
109 Missing :warning:

src/ethereum/cancun/vm/instructions/stack.py
0.00%
98 Missing :warning:

src/ethereum/cancun/vm/gas.py
0.00%
97 Missing :warning:

src/ethereum/cancun/vm/__init__.py
0.00%
77 Missing :warning:

... and 35 more

Additional details and impacted files
@@               Coverage Diff                @@
##           forks/cancun     #871      +/-   ##
================================================
- Coverage         69.96%   69.83%   -0.13%
================================================
  Files               610      610
  Lines             34295    34773     +478
================================================
+ Hits              23993    24283     +290
- Misses            10302    10490     +188

Flag
Coverage Δ

unittests
69.83% <12.69%> (-0.13%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

The question of whether BEACON_ROOTS_ADDRESS gets cleared is verifiably moot, because the account is not empty and cannot become empty. My recollection is that it was decided to remove the test from execution-spec-tests, rather than force everyone to implement this. If that's the case I don't see why we should be added code to the specs.

The question of whether BEACON_ROOTS_ADDRESS gets cleared is verifiably moot, because the account is not empty and cannot become empty. My recollection is that it was decided to remove the test from execution-spec-tests, rather than force everyone to implement this. If that's the case I don't see why we should be added code to the specs.

The way the ethereum/tests for cancun are currently filled, this account can end up being touched and empty. Will check with the team. @marioevz Any comments on this?

Execution spec tests fix: https://github.com/ethereum/execution-spec-tests/pull/425
Still looking into ethereum/tests.

Opened issue for this to be fixed in the ethereum/tests repo

EIP-7523 fixes this because then the BEACON_ROOTS_ADDRESS cannot be empty in the pre-state.

but can it be non existent?

but then there is this option which is also legal - to just write storages without a silent call. it creates double reading.
because writing storages directly is not a call so it does not fail.
I think it would be better
if there is no contract in the state. deploy contract to the state. make silent call / write storages
if contrac alsready in the state verify  it has nonce = 1, code = CODE


PLEASE add 'de-select all' button/checkbox to the window pane?

This is quite possibly the best productivity tool i've added to my repertoire in a long long time.
But please, Can you add the option to 'de-select' all? If that's too much trouble perhaps just stop them all being checked by default? There are so many occasions when i don't need to inject views, images/ui for example. Each an every time i find myself slowly going through the list de-selecting the ones i don't need ( the majority )

Hi, usually when Views have ids, why not to inject them? Also already injected views are unselected.
But that one extra button wouldn't hurt. We won't develop the feature, but you are welcome to submit a pull request.

"Select/deselect all" checkbox has been added in the latest version - 1.5.0.


[Zone Decommission] Add validation for minimum awareness attribute values set before executing decommission

Is your feature request related to a problem? Please describe.
Before decommission an awareness attribute, we want explicit check for minimum attribute value count to fail fast.
Describe the solution you'd like
Adding a validation before executing the request can help.

This might not be needed as if there are no sufficient attributes, then exclusion itself would fail. Closing the issue


make modifications of matplotlib configuration on a local level

In order to not interfere with other potential components relying on matplotlib and implicitly expecting some or all configurations, namely rcParams, to have their respective default value, I would appreciate if changes to rcParams only influenced july.
Currently, it is reconfigured globally in
https://github.com/e-hulten/july/blob/953ef3ee20549ca791d88d2f08e54862aa4c2f58/src/july/rcmod.py#L55
One possibility to achieve this would be for update_rcparams to use matplotlib.rc_context – returning a new independent context manager, to be used in
https://github.com/e-hulten/july/blob/953ef3ee20549ca791d88d2f08e54862aa4c2f58/src/july/plot.py#L68

Sorry for the late reply. Very good suggestion, I fully agree!
The next version of july will be using the
with plt.rc_context(rcmod):
    ...

context manager to avoid interfering with other plots and packages.


Package routines

I've been working mostly on FinnGen's Google Cloud account. I'm repackaging some code that I've been using often there.

I think I've moved most of the useful functions over. I'll close this once I get the chance to check it again.


Kube-burner v1.7.12

Type of change

[ ] Refactor
[ ] New feature
[x] Bug fix
[x] Optimization
[ ] Documentation Update

Description
Results from this version are quite aligned with the old ones:

Includes:

https://github.com/cloud-bulldozer/kube-burner/pull/491
https://github.com/cloud-bulldozer/kube-burner/pull/497
https://github.com/cloud-bulldozer/kube-burner/pull/503
https://github.com/cloud-bulldozer/kube-burner/pull/506
https://github.com/cloud-bulldozer/kube-burner/pull/508

Related Tickets & Documents

Related Issue #
Closes #

Checklist before requesting a review

[x] I have performed a self-review of my code.
[ ] If it is a core feature, I have added thorough tests.

Testing

Please describe the System Under Test.
Please provide detailed steps to perform tests related to this code change.
How were the fix/results from this change verified? Please provide relevant screenshots or results.

did you list PR #506 twice on accident? was there another PR that was included here?
overall lgtm (assuming 506 was just listed twice)

checked and fixed, was just an errata


Need to capture metrics for timeouts between Mixer client and Mixer server

Describe the feature request
We need to create metrics for timeouts between Mixer client and Mixer server, and capture these metrics. We used to have these metrics per cluster, but later we filter out cluster level metrics at Prometheus.

cc @mandarjog


blackfire: fix typo in PHP version

Issue introduced in #246
I still don't get why doing:
nix build --impure --expr '(import ./.).outputs.packages.${builtins.currentSystem}.php82.withExtensions({ enabled, all }: (enabled ++ all.blackfire))'

result in:

You would need to do enabled ++ [all.blackfire].


Generate image/thumb, in cli mode don't work

I have problem with the batch processing, or cli method. When i save the entry one at the time it generates a thumb, but in batch mode it is always null.
This is the code for it:
$thumb = null;
$picture = $entry->ansattbilde[0] ?? null;
if ($picture) {
    $pictureUrl = $picture->getUrl( ["height" => 136, "width" => 136, "mode" => "crop", "format" => 'jpg'] ) ?? null;
    if ($pictureUrl && strpos( $pictureUrl, 'not-found' ) === false) {
        $thumb = Craft::getAlias( '@baseUrl' ) . str_replace( Craft::getAlias( '@baseUrl' ), "", $pictureUrl );
    }
}

I have added a failsafe of an image for some reason is not found.
I have also added settings for Imager and generateTransform at the top of the transformer, so they generate on request:
Imager::$plugin->setSettings( ['useForNativeTransforms' => false] );
Craft::$app->config->general->generateTransformsBeforePageLoad = true;

and this is the query:
->criteria( function(EntryQuery $query) {
    return $query->site( 'nb_konsern' )->section( ['ansatt', 'ansattManuellOppforing'] )->with( ['ansattbilde'] );
} )

I have also tried it with 'queue' true and false
Any idea of why that shouldn't work on batch?

When you save the entry, the image is probably eager loaded into your entry, when it's batched, it isn't, so you want to do the following:
$picture = $entry->ansattbilde[0] ?? $entry->ansattbilde->one();

That should work

Well it almost worked, i had to add a check to see if php was run in CLI mode, and make two queries, with and without eager loading.
Is it a reason why we cant use eager loading in the batch?

The batch runs a different query to make the indexing faster


fixed #298

Addresses https://github.com/loic-sharma/BaGet/issues/298

Implemented error message for when the package folder cannot be found

This will not solve the problem to its root, but it points any non-MS users into the right direction as the problem can be solved without any programming knowledge.
Coded via GitHub website; not tested yet.

Thanks for opening this! I've slightly tweaked the error message and replace Console.WriteLine with ILogger here: https://github.com/loic-sharma/BaGet/pull/346
Please let me know what you think!

This change has been merged into https://github.com/loic-sharma/BaGet/pull/346. Thanks for taking care of this!


(circular-reference) Update example.js

I didn't get how to test in local though. I installed the dependencies with npm install and tried ASSIGNMENT=circular-buffer npx @babel/node scripts/test. I also tried the sync command

The test also needs to be updated to use new CircularBuffer, or you need to add a "wrapper" factory function. Replace export default class with class and add export default (...params) => new CircularBuffer(...params)
What is the issue with the scripts?

Yeah i see what you mean. The test outputs No tests found. I guess I'm not using the command right...

@SleeplessByte @TomPradat I've had the same problem ! I launched the tests with the npm run test commans directly in my exercise folder

@SleeplessByte @TomPradat I've had the same problem ! I launched the tests with the npm run test commans directly in my exercise folder

This runs the test against the stub file not the example

Are you running ASSIGNMENT=circular-buffer npx @babel/node scripts/test from the root folder of this repo?
What OS are you on and which terminal are you using?

So yeah i've tried to run this from the root folder. I got the same problem on WSL and on macOS

@TomPradat rebase on master, OR prepend your script with PREPARE=1:
PREPARE=1 ASSIGNMENT=circular-buffer npx @babel/node scripts/test


50 document api profiles

Closes #50
The updated documentation can be found here

Codecov Report

Merging #128 (2ca49ea) into main (ecc2f7a) will not change coverage.
The diff coverage is 90.00%.

@@           Coverage Diff           @@
##             main     #128   +/-   ##
=======================================
  Coverage   81.22%   81.22%
=======================================
  Files         100      100
  Lines        5257     5257
=======================================
  Hits         4270     4270
  Misses        987      987

Impacted Files
Coverage Δ

src/profile.F90
100.00% <ø> (ø)

src/profile_warehouse.F90
93.61% <ø> (ø)

src/profiles/earth_sun_distance.F90
100.00% <ø> (ø)

src/profiles/extraterrestrial_flux.F90
93.27% <ø> (ø)

src/profiles/from_config.F90
100.00% <ø> (ø)

src/profiles/from_csv_file.F90
89.85% <ø> (ø)

src/profiles/o2.F90
90.00% <ø> (ø)

src/profiles/o3.F90
91.20% <ø> (ø)

src/profiles/profile_utils.F90
89.24% <ø> (ø)

src/profiles/solar_zenith_angle.F90
100.00% <ø> (ø)

... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Recycler: build from source

Description of changes
This PR brings recyclarr to the latest version and switches from using a pre-built binary to building from source using buildDotnetModule. The package is also moved to by-name.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[x] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/4393

Just force-pushed a new version - using finalAttrs.version and confirmed the update script still works.


Edge Formats

Hello,
I've noticed that the edges generated by the NRI paper are in a symmetric matrix format, whereas the edges expected by dNRI are in a vector format. Likewise, it seems that -- for n particles -- the vector is of length n * (n-1), which makes sense since each particle's relation to itself is a given. That being the case, if I flatten the matrix (excluding the diagonal values) and pass that in as the vector, the edge predictions are always about a 50-50 guess. Any help would be greatly appreciated.
Thanks.

Hi Yishai,
We construct the edges within the encoder in these lines. Specifically, we start with a full ones matrix and subtract out the diagonal, and then essentially "flatten" to get a vector of pairs.
As a quick check, I ran inference using a pre-trained model on the basketball data, and I looked at the predicted logits at this line. The shape of the logits is [batch_size, input_len-1, num_pairs, num_edge_types], where num_pairs = 20 in my case (since there are 5 players in this data). The predictions I got for one time step for one batch entry were:
[ 4.6055, -4.5495],
[ 4.3164, -4.3480],
[ 2.4512, -3.1706],
...,
[ 1.4313, -2.0851],
[-0.1860,  0.8247],
[-3.5411,  2.9512]
so I can confirm that I'm not getting a uniform distribution.
So that I can help further: which data are use using? Is this one of the datasets we used in our paper, or is it some custom dataset? Did you train using our training script, or are you doing something else?

Hello again,
Okay, then I was understanding the edge shape/format correctly, so that's good to hear.
As for my dataset, I'm using a dataset generated with NRI: https://github.com/ethanfetaya/NRI/blob/master/data/generate_dataset.py. To be clear, it has static edges, which I assumed would help me debug my issue with dNRI.
And yes, I'm using your training script. The only modification I've made is adding the eval_edges function from the ..._experiment.py file. I did this to see how the edge predictions were changing over time.
And then, finally, my results are particularly weird. They're almost always predicting one edge type:
    [[[ -4.4010,   4.6667],
      [  0.6088,  -0.3821],
      [ -5.5756,   7.0464],
      ...,
      [  3.7157,  -4.7355],
      [  5.5048,  -7.0182],
      [  3.2469,  -4.1171]],

     [[ -7.4909,   8.2328],
      [ -7.2132,   8.5512],
      [ -8.6809,  10.6069],
      ...,
      [ -7.7252,   8.7680],
      [ -7.4723,   8.3750],
      [ -8.6295,  10.0191]],

     [[ -9.4068,  10.4179],
      [-10.0142,  11.5074],
      [ -9.9098,  11.9369],
      ...,
      [ -9.9795,  11.1857],
      [ -9.7064,  10.7637],
      [-10.1917,  11.6953]],

     ...,

     [[-11.0803,  12.4869],
      [-10.0659,  11.9223],
      [ -8.6793,  10.4833],
      ...,
      [-11.5727,  13.1095],
      [-10.0299,  12.0409],
      [ -9.2140,  11.0667]],

     [[-11.1848,  12.6869],
      [-10.1493,  11.9822],
      [ -8.5420,  10.3441],
      ...,
      [-11.6719,  13.2544],
      [-10.2817,  12.2809],
      [ -9.0036,  10.8821]],

     [[-11.1345,  12.7730],
      [-10.2828,  12.0995],
      [ -8.5565,  10.3753],
      ...,
      [-11.6273,  13.2500],
      [-10.5280,  12.5249],
      [ -8.9474,  10.8262]]],

Val Edge results:
F1:  0.6643718522801465
All predicted edge accuracy:  0.5000667708333328
First Edge Acc:  0.01052189604587582
Second Edge Acc:  0.9894158668266325
Please note that the edges are predicted with a 50-50 chance and then diverge to about a 1-99 chance as training goes on.

Some more information would be useful:

Which simulation setting are you using? How many variables? How many variables are connected?
What training flags are you using?

If I'm understanding the data correctly, the "first edge type" represents no connection and the "second edge type" represents a connection (this is how my code generally interprets edge types, anyways). So these kinds of stats seem to indicate that the model is predicting an edge (i.e. "the second edge type") between all pairs of variables. How well does the static NRI model do on this task?

I used the default parameters to generate the dataset: spring, 5 particles, and a random number of connected particles for each simulation.
My training flags are here:

WORKING_DIR="${BASE_RESULTS_DIR}/dnri/seed_${SEED}/"
ENCODER_ARGS="--encoder_hidden 256 --encoder_mlp_num_layers 3 --encoder_mlp_hidden 128 --encoder_rnn_hidden 64"
DECODER_ARGS="--decoder_hidden 256"
HIDDEN_ARGS="--rnn_hidden 64"
PRIOR_ARGS="--use_learned_prior --prior_num_layers 3 --prior_hidden_size 128"
MODEL_ARGS="--model_type dnri --graph_type dynamic --skip_first --num_edge_types 2 $ENCODER_ARGS $DECODER_ARGS $HIDDEN_ARGS $PRIOR_ARGS --seed ${SEED}"
TRAINING_ARGS='--batch_size 256 --lr 5e-4 --use_adam --num_epochs 100 --normalize_kl --normalize_nll --tune_on_nll --val_teacher_forcing --teacher_forcing_steps -1'
mkdir -p $WORKING_DIR
CUDA_VISIBLE_DEVICES=$GPU python -u dnri/experiments/spring_experiment.py --gpu --mode train --data_path $DATA_PATH --working_dir $WORKING_DIR $MODEL_ARGS $TRAINING_ARGS | tee "${WORKING_DIR}results.txt"
CUDA_VISIBLE_DEVICES=$GPU python -u dnri/experiments/spring_experiment.py --gpu --mode eval --load_best_model --data_path $DATA_PATH --working_dir $WORKING_DIR $MODEL_ARGS $TRAINING_ARGS | tee "${WORKING_DIR}eval_results.txt"

As for NRI, it performed well and mirrored their paper's results:

Epoch: 0177 nll_train: 2.2486116141 kl_train: -0.0030197995 mse_train: 0.0000011712 acc_train: 0.9981461797 nll_val: 0.0790408968 kl_val: -0.0033634473 mse_val: 0.0000000412 acc_val: 0.9976958070 time: 1009.9070s

How do the NLL/MSE for dNRI compare against those for static NRI?
I'll also mention that, if the interaction graph is expected to be static, then I'd expect static NRI to perform better - this model is able to average the interactions across time to come up with its interaction prediction, while dNRI has to make a separate analysis at every point in time.


Adjust few TypeScript's documentation formatting

What
This PR has only documentation formatting adjustments.
I have added some new indentation where needed in the code example and add a missing space in style declaration.

Thanks for submitting these!


Omit not working properly

Bug Report

After using Omit<>, my undefined key errored out.
Example of working (before Omit) and notworking (after Omit) inside:
https://www.typescriptlang.org/play?#code/FASwdgLgpgTgZgQwMZQAQEFUG9ir65JAewFdIAuVAZwhnAHMBuXfBCaAWwAcIrKa6YJsAC+oSLEQpUAIWws8AIxAAbFZRz4tqMAg5R+tBsy0jUAH1RkAJlDjgo1xqgD0L1AHkeIIrpUA6UXFoeGQ0AGF5LWIJCijtPGgADwhDQWFTIIgATy40ABFUAF4MVAAyVEiKmWYcvNQAUWLSivDmKCSuIhgIVDq0ADFmwssG5mAYmmoifQA1BBgAOSIIDw4QdkdKIZLNVk3uXkoAImOAGgVUZTVKGzsHazPXd3Q1VHoiImtUAHcAC1UaDAKysVAYnnWEAAPAA+S4xaBxPYJZKpVCnS4iC5aQikOIYsTAfqoAASzTWGyhAyex1xZAgxxhzEmvSoMyg8xgFM21koZN2lzYnB4fHR50u13UVjAtnsYEcTzcVxgRAA1lAwKg-rA0GQVFAqFRUMQOPoJN9SBB4b5EWjkdpUSdjpjsawkMR6U6WCJxkrifyIZTqei6ZBGYwgA
🔎 Search Terms

Omit
🕗 Version & Regression Information

This is the behavior in every version I tried.

⏯ Playground Link

Playground link with relevant code
💻 Code

// playground.

🙁 Actual behavior

Error!
🙂 Expected behavior

Working without error by TypeScript when 'bill' key is defined to be undefined.

This is working as intended. See #54451 and the linked issues.

Thanks for the hyperlink. Still feels like a bug to me though. When omitting something we expect the rest to stay the same and only the ones mentioned affected. The behaviour doesn’t match up with the meaning of the word at all. Hope they revamp it officially.

If you look up the definition of Omit you will figure out why it's not working as you expect.

Hope they revamp it officially.

As per the issue and it's linked issues: they will not. Now changing the definition of Omit is a too huge breaking change.

I looked up the definition of omit as you suggested:
leave out or exclude (someone or something), either intentionally or forgetfully.
Sounds like it’s not working as per definition. It’s erroring out as per my playground. Please enlighten me (with details if possible) if I am missing something here.

Omit is not a conditional type, so it doesn't distribute over unions. It's using keyof, which for union types only returns the keys common to all types of the union. That's where properties are "lost".


Do we have an option to specify the desired dimensions?

It will be great, if we could specify the desired dimensions to the cropper. Do we have something like that?

Bump, is this going to be updated/implemented?


Dart:io should use lowerCamelCase for publicly visible constants.

The Dart style guide recommends lowerCamelCase for constants. Dart platform libraries used to use SCREAMING_CAPS.
The platform libraries are changing to the recommended style for Dart 2.0, and dart:io should do that too.

dart:io constants outside of dart:_http are updated. Updating dart:_http constants is in-progress here: https://dart-review.googlesource.com/c/sdk/+/58620.

https://dart-review.googlesource.com/c/sdk/+/58620 has landed. Can this be closed?

Yes, I think this is all set.


Declaration in @NgModule duplicating when generating stuff

🐞 Bug report
Command (mark with an x)

- [x] generate

Is this a regression?
Probably, found it on version 8.3.5
Description
The "declaration" key in @NgModule duplicating when generating stuff.
🔬 Minimal Reproduction

Put a quotes or a double-quotes on the "declaration" key at any @NgModule. Or set "object-literal-key-quotes" on tslint to [true, "always"]. Originally, it would look like this:

@NgModule({
  declarations: [Component1, Component2],
  imports: [
    CommonModule,
    OtherModule
  ]
})

Run ng lint --fix (if you did the tslint). It should now look like this:

@NgModule({
  "declarations": [Component1, Component2], // ---> added quotes on the "declaration"
  "imports": [
    CommonModule,
    OtherModule
  ]
})

Generate a component where it would import on the said module. It either generates another "declaration" key with or without quotes (depending on your schematics whether you run lint after generating). It would now look like this:

@NgModule({
  "declarations": [Component1, Component2],
  "imports": [
    CommonModule,
    OtherModule
  ]
  "declarations": [Component3] // ---> It would generate this with or without quotes instead of merging it with the existing one
})
🔥 Exception or Error
Running ng serve now throws the error
error TS2300: Duplicate identifier 'declarations'.
Other Notes
Not big of an issue, but it kills some of the tasks that should be automated when you have a custom tslint settings at the same time.

@MetaMoRpheXx
Hey. Tried to reproduce your issue, but wasn't able to :slightly_frowning_face:


Update README.md for webpack_static

Just add a note that the base path for webpack_static is based on your webpack config's publicPath option

closing will open a new one


add Mockito for Unit tests

Hi, everyone i would like to add tests to the sugar library and i think it would be useful to have Mockito framework. Mockito is an open source project that allows you to easily create mocks and stubs for unit testing.
I think that sugar right now needs more testing, and mockito can help us with this. I leave the link.
http://mockito.org/
Any feedback or opinions are appreciated.

Great, try to improve the coverage if this tests


Update to capacitor 3 or 4

[ ] Direct jump from capacitor 2 to capacitor 4 possible?
[ ] quick test with capacitor 4: What is new? What breaks? What todos emerge?
[ ] If too much work: capacitor 3 update more manageable?

Note: This card will most likely need to be split eventually.

Upgrading to capacitor-4 is now more or less done. We finished all steps and now need to run tests on our devices


Release v. next

/cc: @ejelly or @qvicksilver, maybe one of you can take care of it?

I've made a release, 0.4.3, don't know how fast it will appear in https://wiki.jenkins-ci.org/display/JENKINS/AnsiColor+Plugin.


Loading a fine-tuned model and getting labels.

I fine tuned Mobilenets and attempted to classify images to a live webcam feed using OpenCV but I cant seem to find a way to get predictions. How can I also get the labels from the retrain process when there is no option in keras to save .pbtxt
I tried loading a fine tuned model saved as a .h5 file to this script but it just kept loading in Jupyter Notebook. What is the correct argument to use so I can deploy the model on a real time camera feed?
Heres my code:
`from keras.preprocessing import image
from keras import load_model
import argparse
import cv2
import numpy as np
import os
import random
import sys
import threading
label = ''
frame = None
class MyThread(threading.Thread):
def init(self):
threading.Thread.init(self)
def run(self):
global label
print("[INFO] loading network...")
self.model = load_model(PiVision.h5)

while (~(frame is None)):
    (inID, label) = self.predict(frame)

def predict(self, frame):
image = cv2.cvtColor(frame, cv2.COLOR_BGR2RGB).astype(np.float32)
image = image.transpose((2, 0, 1))
image = image.reshape((1,) + image.shape)
image = preprocess_input(image)
preds = self.model.predict(image)
return decode_predictions(preds)[0]

cap = cv2.VideoCapture(0)
if (cap.isOpened()):
print("Camera OK")
else:
cap.open()
keras_thread = MyThread()
keras_thread.start()
while (True):
ret, original = cap.read()
frame = cv2.resize(original, (224, 224))
Display the predictions
print("ImageNet ID: {}, Label: {}".format(inID, label))
cv2.putText(original, "Label: {}".format(label), (10, 30), cv2.FONT_HERSHEY_SIMPLEX, 0.9, (0, 255, 0), 2)
cv2.imshow("Classification", original)
if (cv2.waitKey(1) & 0xFF == ord('q')):
break;
cap.release()
frame = None
cv2.destroyAllWindows()
sys.exit()`

@ShiroDXD  -  Hi, does this problem exist when tf.keras is used ?

@harshi-gadige I haven't tried it on tf.keras though but can you refer me to any blogs or website that has successfully applied a fine-tuned model. Thanks.

@harshini-gadige I haven't tried it on tf.keras though but can you refer me to any blogs or website that has successfully applied a fine-tuned model. Thanks.

Fine-tuning a Keras model

@ShiroDXD  Any update on this please ?

Closing this as it is in "awaiting response" status for more than a week. Feel free to repost your comments and we will reopen. Thanks !


[KYUUBI #3549] Support query id in Flink engine

Why are the changes needed?

Flink engine now doesn't support query id. This PR fixes the problem.
How was this patch tested?

[x] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[ ] Run test locally before make a pull request

Does the feature has requirements for Flink version?

Does the feature has requirements for Flink version?

Nope, this should be compatible with Flink 1.12 above.

Codecov Report

Merging #3550 (a68bc59) into master (46280fc) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #3550      +/-   ##
============================================
- Coverage     51.73%   51.68%   -0.06%
  Complexity       13       13
============================================
  Files           482      482
  Lines         26950    26950
  Branches       3761     3761
============================================
- Hits          13942    13928      -14
- Misses        11654    11666      +12
- Partials       1354     1356       +2

Impacted Files
Coverage Δ

.../kyuubi/server/mysql/constant/MySQLErrorCode.scala
13.84% <0.00%> (-6.16%)
:arrow_down:

...ache/kyuubi/server/mysql/MySQLCommandHandler.scala
75.00% <0.00%> (-4.55%)
:arrow_down:

...ache/kyuubi/operation/KyuubiOperationManager.scala
79.45% <0.00%> (-2.74%)
:arrow_down:

...ache/kyuubi/server/mysql/MySQLGenericPackets.scala
76.59% <0.00%> (-2.13%)
:arrow_down:

...rg/apache/kyuubi/ctl/cmd/log/LogBatchCommand.scala
78.00% <0.00%> (-2.00%)
:arrow_down:

...n/scala/org/apache/kyuubi/engine/ProcBuilder.scala
80.74% <0.00%> (-0.63%)
:arrow_down:

...a/org/apache/kyuubi/service/TFrontendService.scala
91.17% <0.00%> (-0.30%)
:arrow_down:

...org/apache/kyuubi/operation/ExecuteStatement.scala
79.16% <0.00%> (ø)

...g/apache/kyuubi/operation/BatchJobSubmission.scala
74.64% <0.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Thanks, merging to master


Total Item count in Progress Bar

I'm probably missing the obvious, but is there a way to have a progress bar column for item count? I'm processing over 1000's of files and showing each file as an increment. All works great, and percentages work, but would like item count.
I tried using FileSizeColumn (and TotalFileSizeColumn), but FileSizeColumn seems to insist on putting a suffix "bytes" after the number... but I'm not counting bytes :-)

See (recently updated) docs for details.

Great, thanks!


WIP - don't provide a breaking change

Re: https://github.com/microsoft/TypeScript/pull/39119

There we go, looks like there needed to be a bit more dancing than I expected, but this should provide no breaking changes to existing users 👍🏻


Anyone else having issues with session being lost on dev-master?

I have created a basic test that logs in the user via entering the login credentials, and clicking a login button. The next step where I need to click a menu item fails because of what looks like the session is not set.
Also, why is
$this->getSession

taken out in dev master branch? The programmer is now going to have to use a setter/getter to reuse the session through the lifecycle of the feature. Do we just change these major dependencies without any sort of a question? or documentation?

Can you please share your feature file?

sure
# behat.yml
default:
    extensions:
        Behat\MinkExtension:
            goutte: ~
            selenium2: ~

I was asking for feature file, but you've attached Behat config file. What I need is scenario you're running and custom PHP features that it uses.


feat: add Accordion component

Jira Ticket:
ENG-2808: [Octuple] Accordion

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@2e7a5f0). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #126   +/-   ##
=======================================
  Coverage        ?   80.87%
=======================================
  Files           ?       54
  Lines           ?     1417
  Branches        ?      572
=======================================
  Hits            ?     1146
  Misses          ?      262
  Partials        ?        9

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e7a5f0...c7568fe. Read the comment docs.

explore fliptoolkit for animation

refer to split and toggle button for aria attributes

Wrap multiple accordions in list component for better accessibility


Debug docker images fail to build: inconsistent vendoring in /go/src/github.com/go-delve/delve

E.g. #3187 is failing with this error:
#15 [linux/amd64 build 3/3] RUN if [[ "amd64" == "s390x"  ||  "amd64" == "ppc64le" ]] ; then 	touch /go/bin/dlv;     else         go get github.com/go-delve/delve/cmd/dlv &&         cd /go/src/github.com/go-delve/delve &&         make install;     fi
#15 19.99 go: inconsistent vendoring in /go/src/github.com/go-delve/delve:
#15 19.99<EMAIL_ADDRESS>is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
#15 19.99
#15 19.99 run 'go mod vendor' to sync, or use -mod=mod or -mod=readonly to ignore the vendor directory
#15 19.99 make: *** [Makefile:28: install] Error 1
#15 ERROR: process "/bin/sh -c if [[ \"$TARGETARCH\" == \"s390x\"  ||  \"$TARGETARCH\" == \"ppc64le\" ]] ; then \ttouch /go/bin/dlv;     else         go get github.com/go-delve/delve/cmd/dlv &&         cd /go/src/github.com/go-delve/delve &&         make install;     fi" did not complete successfully: exit code: 2

Likely cause: delve is using go.mod, but our Docker image uses go-1.15-alpine which still defaults to GOPATH mode.


Xrepo how to pass configs to dependent libraries

Consider following code in CMakeLists.txt which uses xrepo-cmake (Note the problem is not specific to xrepo-cmake):
xrepo_package("gflags" CONFIGS mt=true,shared=true)
xrepo_package("glog" CONFIGS shared=true)

glog depends on gflags, xrepo_package(glog ...) would install a -f mt=false,shared=false build of gflags because these are the default configs for gflags. But this version of config is not needed in the cmake project.
Manual install with xrepo install -f shared=true glog would have the same problem if the user actually wants a shared multi-threading enabled bulid of gflags.
We have builtin and non-builtin configs,

For builtin configs like shared=true, maybe it's reasonable to pass it recursively to all dependencies.

But for builtin flags like cflags, it maybe specific for each package thus shouldn't recursively pass to dependencies.

For non-builtin configs (mt=true for gflags).

This is a compilcated problem which I don't have any idea to gracefully handle. vcpkg uses baseline (if I understand correctly) which effectively does not allow user to (easily) change package configs.
For now I can live with creating a private repo and take one of the following options:

change the mt=true as default for gflags.
change the way glog depending on gflags.

Here's the code snippet in gflags's xmake.lua which I changed to take the second option:
for config, dep in pairs(configdeps) do
    if package:config(config) then
        if config == "gflags" then
            package:add("deps", "gflags 2.2.2", {
                configs = {mt = true, shared = package:config("shared")}
            })
        elseif config == "unwind" then
            package:add("deps", "libunwind", {
                configs = {shared = package:config("shared")}
            })
        else
            package:add("deps", dep)
        end
    end
end

It's rather ad-hoc but I doubt if there's any better way to this.
I'm consider adding arrow package in xmake-repo, it depends on lot's of other packages which may require extensive use of passing configs to dependent packages.

we can use add_requireconfs("glog.gflags", {configs = {mt = true, version = "2.2.2", shared = true}}) if we use xmake in xmake.lua.
but xrepo command does not support it yet.
Maybe we can use the xrepo install command to receive a xmake.lua to describe all the installed package information. for example:
xrepo install /xxx/mypkgs.lua

/xxx/mypkgs.lua
add_requires("glog", "libunwind")
add_requireconfs("glog.*", {system = false})
add_requireconfs("glog.gflags", {configs = {mt = true, version = "2.2.2", shared = true}})
-- ...

And pass mypkgs.lua to xrepo-cmake wrapper.

Maybe we can use the xrepo install command to receive a xmake.lua file to describe all package information. for example:
xrepo install /xxx/glog.lua

/xxx/glog.lua
add_requires("glog")
add_requireconfs("glog.*", {system = false})
add_requireconfs("glog.gflags", {configs = {mt = true, version = "2.2.2", shared = true}})
-- ...

And add an api or option to pass glog.lua to xrepo-cmake wrapper.
xrepo_package("glog" CONFIGS /xxx/glog.lua)

This is a nice way for user to override configs in existing repo.
For xrepo package writers, the provided feature already satisfies the need.


Update README.md

typo

fka stands for "formerly known as" whereas "aka" stands for "also known as", which is not the case.  What used to be the Swagger specification is no longer known as that.  It is now known as "OpenAPI Specification.

Oops, my bad !

Though maybe we should write this phrase out?

Maybe, as this is the first time I saw fka (feels wrong for me ^^)


fix(fluentd-output-opensearch): add spec.outputs.opensearch.scheme value

Signed-off-by<EMAIL_ADDRESS>
What this PR does / why we need it:
add spec.outputs.opensearch.scheme value to allow for https connections
Which issue(s) this PR fixes:

Fixes #579
Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc.:

@stexandev You'll need to sign your commit like this:
git commit -s --amend
git push -f

Thanx for the help, fixed that.


OTG Test - RT-1.19: BGP 2-Byte and 4-Byte ASN support

OTG version of this test.
Resolves #1937

Pull Request Functional Test Report for #2339 / 065b9d93426d252aef0c68042b944ef75c908cac
Virtual Devices

Device
Test
Test Documentation
Job
Raw Log

Arista cEOS

RT-1.19: BGP 2-Byte and 4-Byte ASN support

Cisco 8000E

RT-1.19: BGP 2-Byte and 4-Byte ASN support

Cisco XRd

RT-1.19: BGP 2-Byte and 4-Byte ASN support

Juniper cPTX

RT-1.19: BGP 2-Byte and 4-Byte ASN support

Juniper ncPTX

RT-1.19: BGP 2-Byte and 4-Byte ASN support

Nokia SR Linux

RT-1.19: BGP 2-Byte and 4-Byte ASN support

Openconfig Lemming

RT-1.19: BGP 2-Byte and 4-Byte ASN support

Hardware Devices

Device
Test
Test Documentation
Raw Log

Arista 7808

RT-1.19: BGP 2-Byte and 4-Byte ASN support

Cisco 8808

RT-1.19: BGP 2-Byte and 4-Byte ASN support

Juniper PTX10008

RT-1.19: BGP 2-Byte and 4-Byte ASN support

Nokia 7250 IXR-10e

RT-1.19: BGP 2-Byte and 4-Byte ASN support

Help

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 48.7%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1536

Relevant Lines:
3154

💛  - Coveralls

@octpetre : Needs a metadata sync, otherwise it's LGTM.

Done

@octpetre : Metadata formatting is still off.

@jasdeep-hundal I fixed the metadata file


lookup for Headers is not intuitive

It would seem there's an issue with the casing for Headers. The current behavior is:
HTTPure.lookup (HTTPure.headers "Foo" "bar") "Foo" == Nothing

But, it seems like the behavior should be:
HTTPure.lookup (HTTPure.headers "Foo" "bar") "Foo" == Just "bar"

Seems like the issue is the Lookup instance. As discussed in Slack, probably easiest to use Data.String.CaseInsensitiveString (at least internally).

Looks like Headers is a newtype around Object String, so using CaseInsensitiveString is out.
I guess there are some options:

"Fix" the bug with the current implementation.
Looks like we'd want to lowercase both header and headers so values going in would be lowercase. It wouldn't really fix the underlying issue as the constructor is exposed and there's a Newtype instance; people can still construct broken Headers.
Fix the bug, for real.
If we do the above, hide the constructor, and drop the Newtype instance, then using Headers from outside the module is consistent.
Use Map CaseInsensitiveString String instead of Object String.
This would fix the issue altogether. Dunno if the Object String is a requirement of Headers though.

Thoughts on those three options? Maybe there's another thing to do instead?

I lean towards option #3, see #113 as I've wanted to remove the use of Foreign.Object for some time and never got around to it.
I think the only reason Foreign.Object is being used is in some olden times, these objects were passed in through the Node APIs more directly than they are now.  But now, the Headers.write function just traverses the headers data so there isn't a compelling reason to stick to using Foreign.Object.

@cprussin any chance of a new release with this fix soon?

@davezuch so sorry, I meant to release after this merged and then went on vacation and only just returned.
Published v0.8.2

Thanks for the release!
I think the changes made were breaking though (at least, it makes some of my code not type anymore). Any chance we could get a 0.9.0 release? Maybe also delete the 0.8.2 tag? I dunno how you feel about removing tags that already exist.

@joneshf I'm surprised that anything in here is breaking, are you relying on any internals in your code?  Can you be more specific about what's breaking?
Regardless, I'm actually not really worried about the versioning scheme, because semver specifies that any releases below 1.0.0 may be (though I have tried to stick to minor versions for breaking changes and patch versions for non-breaking).
That said, even though we haven't already finished all the items on my 1.0 wishlist, it might be time to start thinking about cutting a 1.0 release.  That will force our hand at being a bit more careful with backwards compatibility.

Sorry, I thought I responded to this. Will do so for posterity, even though multiple versions have been released since 0.8.2.

HTTPure.Headers.Headers was a newtype over Foreign.Object.Object String, then it became  a newtype over Data.Map.Map Data.String.CaseInsensitive.CaseInsensitiveString String. That's the breaking change. Code that was working against the Foreign.Object.Object String doesn't work against the Data.Map.Map Data.String.CaseInsensitive.CaseInsensitiveString String.
I'm not sure what's classified as an internal in purescript-httpure, but it doesn't seem like HTTPure.Headers.Headers is internal. The module naming doesn't indicate it should be internal, there doesn't appear to be documentation about it being internal, and it has a Data.Newtype.Newtype instance which makes its underlying representation visible to everyone no matter if it is supposed to be internal. If it's supposed to be internal, maybe documenting it as such, changing the module name, unexposing the constructor, or removing the Data.Newtype.Newtype instance would be useful to indicate that.
If there were some way to work with the concept of HTTPure.Headers.Headers without resorting to unwrapping the newtype, that could work as well. You can put headers into an HTTPure.Headers.Headers without worrying about what the underlying implementation is: HTTPure.Headers.header and HTTPure.Headers.headers. But near as I can tell, there's no way to get back out all of the headers without unwrapping the newtype. The HTTPure.Lookup module only provides a way to get specific headers, not every header.

Hope that explains what was happening. Lemme know if something is unclear.

Got it, thanks for posting. Yes, the intention is to work with headers without unwrapping, but as you're pointing out there are certainly things you can't currently do without unwrapping. Regardless, it's fair to say that even if those existed, changing an exported type is breaking.
In any case, apologies for the semver abuse and thank you for pointing this out!

No worries. It wasn't that big of an issue, but forgot to follow-up on it.
Would you want to do something about working without unwrapping? We can move to a separate issue if that's better.

@joneshf honestly I hadn't put too much thought into it, I just had this general feeling that you shouldn't have to unwrap HTTPure newtypes in application code.  I'd say if it feels important to anyone, let's go ahead and move to another ticket.