Add basic authentication

Summary
This MR adds some changes we have been using internally, in order to add HTTP Basic authentication out-of-the-box.
We know that project's idea about this is that authentication should be provided by external software, but this can be useful in some scenarios, like running on Google Cloud Run.
This PR fixes/implements the following features

[x] HTTP Basic authentication

The main motivation is, as explained above, allowing the container to run standalone in a serverless environment like the ones provided on AWS or GCP.
Test plan (required)
I have added tests that cover the functionality and this behaviour is configurable by using environment variables.
Closing issues
It does not close, but can help to the people watching this issue
Checklist

[x] Have you followed the guidelines in our CONTRIBUTING guide?
[x] Have you lint your code locally prior to submission (make lint)?
[x] Have you written new tests for your core changes, as applicable?
[x] Have you successfully ran tests with your changes locally (make tests)?
[x] Have you updated the documentation (make doc)?
[x] I have squashed any insignificant commits
[x] This change has comments for package types, values, functions, and non-obvious lines of code

👍 thank you for this PR


kjellqvist/issue9

Fixes #9

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@b46ecd6). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #12   +/-   ##
=======================================
  Coverage        ?   88.67%
=======================================
  Files           ?        4
  Lines           ?      106
  Branches        ?        0
=======================================
  Hits            ?       94
  Misses          ?       12
  Partials        ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b46ecd6...d536901. Read the comment docs.


 I've experience in Python, C, C++, C# and Rust.
Related proposals
While there have been proposals for new keywords to handle error checking, none I've found have been so simple.
Proposal
Many people find the error checking in Go tedious. I propose to add error checking shorthand to the language to reduce amount of code required and to increase readability of the code. It will also reduce copy and paste error checking and potential mistakes introduced by doing so. The change would be backwards compatible with Go by adding an optional operator ??. I've used the ?? operator here but a keyword would work just as well.
r1, _ = someFunc() ??      // This is a quick error return
r2, err = someFunc() ?? {  // This is a quick error check
    // Error handling code
}

Here is a simple example.
func doSomething() (int, error) {
    // snip
}

func retErr() (int, error) {
    // This is a quick error return. It will find the first returned error and check if it's not nill.
    // If so the function will return default values and copy the error into the return value.
    // Whether the error value is discarded or not has no effect on this new feature.
    r1, _ := doSomething() ??

    // This is a quick error check. It will find the first returned error and check if it's not nill.
    // If so it will execute what's inside the braces.
    r2, err := doSomething() ?? {
        log.Print("uh-oh");
        return 0, err;
    }

    return r1 + r2;
}

func retNoErr() int {
    // Quick error return will not compile because the function doesn't return an error
    // r := doSomething() ??

    // So we have to use the Quick error check instead
    r, _ := doSomething() ?? {
        // We could panic here
        return -1;
    }

    return r
}

Costs

This would make code easier to read and write.
It would be an additional thing to learn about the language but by no means difficult.
The compiler and gofmt would be affected and I'm unsure of how many other tools.
The compile time would be increased
The run time would remain the same

Duplicate of #37243


Change configuration files for pdc-client

The configuration for client should be in a dropdir (/etc/pdc.d/)
so that multiple config files can be installed at the same time.

Load a config dict from each file.
If two dicts contain the same key, report an error (the error
message should include the key and all file names defining it)
Merge all these dicts.
Continue as before: load user config file and apply changes from it

JIRA: PDC-1563

Coverage decreased (-0.4%) to 87.103% when pulling e9d86fb0ed1b99ab84afecbcd87a3953758a3853 on PDC-1563_Change_configuration_into_dropdir into 409f042f5aa4fa97722478da730420afb69d1dd0 on master.

Coverage decreased (-0.4%) to 87.103% when pulling 8d5b947edb67bfcd92594e745c11b35f9efef19d on PDC-1563_Change_configuration_into_dropdir into 409f042f5aa4fa97722478da730420afb69d1dd0 on master.

do we want to restrict to these tow files redhat.json and fedora.json, can we add other file like my.json.
and is it ok to expose redhat.json in github? is it ok to search all json files in pdc.d and merge them.
by the way, the coverage decreased, so maybe we need to add some test cases.

There should be no hard coded filenames. The client should load all json files from the directory and merge them.

@lubomir , do you means that get all json files in  /etc/pdc.d/ directory and merge them;  if there are same keys  in them, raise error info?

@bliuredhat yes, exactly that.

Coverage decreased (-0.5%) to 86.98% when pulling 77f4abb96b2388d25c18232498481e3e7787da06 on PDC-1563_Change_configuration_into_dropdir into 409f042f5aa4fa97722478da730420afb69d1dd0 on master.

Coverage decreased (-0.5%) to 87.037% when pulling b4de151cf5226af5f9883672afb277957d2e9a26 on PDC-1563_Change_configuration_into_dropdir into 409f042f5aa4fa97722478da730420afb69d1dd0 on master.

@simozhan; I think this patch don't need to add a test case.

Coverage decreased (-0.5%) to 86.98% when pulling e97b292524ca42da4619421f709fcef68ff80fa4 on PDC-1563_Change_configuration_into_dropdir into 409f042f5aa4fa97722478da730420afb69d1dd0 on master.

:+1:

Coverage decreased (-0.7%) to 86.807% when pulling c02ff41b28371ce146a2b13b803a5f4f63d31706 on PDC-1563_Change_configuration_into_dropdir into 409f042f5aa4fa97722478da730420afb69d1dd0 on master.

As far as functionality goes, this looks good. Since the _read_file function is getting quite long and complicated, maybe adding a comment explaining what it is supposed to do might be helpful in the future. But that is up to you.

Coverage decreased (-0.8%) to 86.702% when pulling f4755a9bcb454ce863cd1642048ac87b60337613 on PDC-1563_Change_configuration_into_dropdir into 409f042f5aa4fa97722478da730420afb69d1dd0 on master.

Coverage decreased (-0.8%) to 86.702% when pulling 2ab1740d5c96a55b3f61711b858141074fc36152 on PDC-1563_Change_configuration_into_dropdir into 409f042f5aa4fa97722478da730420afb69d1dd0 on master.

looks good to me


fix CastOp typo

Hi Xiandi, Liyi and Jiacheng, this is Junda Feng from bytedance.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

misc: fix CastOp typo


Cherry-pick #621

fix(cordon-drain): return correct updated spec
Outdated spec was being returned as part of the cordon/drain operations.

bors merge


Blasts HUD

What does this PR do?
Make Landing page blasts information HUD Desktop and Mobile compatible.
Screenshots?

@nerdlet I think its ready for another review
cc @kilemensi

Looks good for sm and lg screens @karimkawambwa.

Blasts Recorded still needs that underlining per design

md screen looks off

@kilemensi one more review cc @nerdlet

@karimkawambwa
For the small devices, noticed the spacing between the typography and the svg was a bit off

and this as well


sanitize should match strictly on whole words.

We have a Rails app and one of our filter_parameters fields is name. Because of the loose matching on words, fields such as server_name get masked.

This might make sense for filter_parameters, but we definitely don't want to allow anything through that contains "password" or "passwd" etc, so those should retain CONTAINS matches.

@dcramer good point. updated so that it doesn't do strict matching on default list.

@dcramer thoughts on merging this?


Error opening file with mode 'w':

Hi guys, I have the error: Error opening file with mode 'w'
that occurs when an intermediate directory doesn't exist on the class method File.write "./exists/doesnt/file.txt", "content", mode="w+"
if mode is w+ then error should say Error opening file with mode 'w+' not w

FWIW it should be mode: "w+" not mode = "w+".  You're just assigning a local var to "w+", that is probably getting passed into the third argument, not actually changing the mode, hence it uses the default of "w".

Yes, not a bug :)


Provide fallback for devenv for Ubuntu-building?

I'm using a Windows 10 subsystem for Linux. I don't have VS Build Tools 2017 installed on Ubuntu (there's none!), but I've Mono and .NET SDK installed. However, running make vs2017-release64 yields:
devenv .build/projects/vs2017/bgfx.sln /Build "Release|x64"
/bin/sh: 1: devenv: not found
makefile:158: recipe for target 'vs2017-release64' failed
make: *** [vs2017-release64] Error 127

There could be a fallback from devenv to dotnet if devenv isn't there, and run something like dotnet build. .NET SDK supports many things, so I don't see why it couldn't be used.

Pick Linux or Windows. If you're using Windows use VS2017 or MinGW, if you're using Linux use GCC or Clang.

@bkaradzic Firstly, thank you for bgfx, but I don't think it's nice to duplicate packages between WSL (Ubuntu) and Windows, thus the fallback is nice.
For example, I'll have to install Gennie again in Windows, but I don't need since it's already on WSL. But maybe can I PR to the Makefile? Will try to put dotnet build there...


Update openssl

Would fix a security vulnerability present in openssl versions less than 0.10.66: https://github.com/advisories/GHSA-q445-7m23-qrmw

Duplicate of #300, closing.


Respect TMT_WORKDIR_ROOT variable in testcloud

Just a quick fix to prevent testcloud storing the downloaded images in the default location. Would be nice to have something like tmt.utils.get_constant() which would handle the check for possible environment variable override.

Would be nice to have something like tmt.utils.get_constant() which would handle the check for possible environment variable override.

Or finally allow user configuration to be stored and use that to respect user wishes.

Or finally allow user configuration to be stored and use that to respect user wishes.

Even better! :)


Heron update

Pull Request Description
What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)
#1258
What are the significant changes in functionality due to this change request?
Updates HERON to changes for Dec 2021 milestone

For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.

[ ] 1. Review all computer code.
[ ] 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
[ ] 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
[ ] 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
[ ] 5. If significant functionality is added, there must  be tests added to check this. Tests should cover all possible options.  Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in  XML block, the node <internalParallel> to True.
[ ] 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change.  The requirements and the requirements test shall be in sync.
[ ] 7. The merge request must reference an issue.  If the issue is closed, the issue close checklist shall be done.
[ ] 8. If an analytic test is changed/added is the the analytic documentation updated/added?
[ ] 9. If any test used as a basis for documentation examples (currently found in raven/tests/framework/user_guide and raven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.

We should particularly check the plugin tests before merging this.

@PaulTalbot-INL Is this good to merge?

There's too many failing HERON tests; I think forcing the multimarket opt/sweep to run sequentially may solve it, but I'm checking.


RFC/DEP: decorator to deprecate positional/keyword uses of arguments?

Reference issue
NA
What does this implement/fix?
Per The Missing Bits

For new functions or methods with more than a few arguments, all parameters after the first few "obvious" ones should require the use of the keyword when given.

I think we also know that names of required arguments like a/b are typically not very useful (and often just add inconsistency between similar functions). Presumably drawing from years of experience with API design, the array API standard seems to prefer most arguments to be either positional-only or keyword-only, not both.
So I thought I'd experiment with a decorator that will let us standardize existing signatures along these lines.
(Besides helping us make the API more consistent, it is easier/faster to wrap large classes of functions - e.g. for array API dispatching - when it is known whether arguments will be passed by position or keyword.)
This PR also applies the decorator to scipy.stats.ttest_ind, making a and b positional-only and the rest of the arguments keyword only.
Again, this is just an experiment. It could be deemed too noisy for what we gain. An alternative might be to save this sort of thing for a SciPy 2.0 transition? But I thought I'd at least see if we could make it easy to implement.
Additional information
In the documentation, we will get a deprecation admonition in the Extended Summary of ttest_ind:

And here is what the DeprecationWarnings look like:
import numpy as np
from scipy import stats

stats.ttest_ind(np.arange(10), np.arange(10), -1, True)
# DeprecationWarning: Argument(s) {'axis', 'equal_var'} of `ttest_ind` passed by position but will become keyword-only in SciPy 1.17.0.
#  stats.ttest_ind(np.arange(10), np.arange(10), -1, True)
# TtestResult(statistic=0.0, pvalue=1.0, df=18.0)

stats.ttest_ind(a=np.arange(10), b=np.arange(10), axis=-1)
# DeprecationWarning: Argument(s) {'a', 'b'} of `ttest_ind` passed by keyword but will become positional-only in SciPy 1.17.0.
#  stats.ttest_ind(a=np.arange(10), b=np.arange(10), axis=-1)
# TtestResult(statistic=0.0, pvalue=1.0, df=18.0)

I thought I'd get some feedback before putting the time into writing tests.

I believe we actually already have this, see
https://github.com/scipy/scipy/blob/f7e0d1a0d83741ea8efebf33f5ccbda12d1d8503/scipy/_lib/deprecation.py#L179-L235
however the doc improvements look nice!

Oh I didn't know about that. Yeah, maybe the automatic documentation adjustment here will be helpful. Interesting that it lets you change the signature written in the code at the time the decorator is applied, then when you just remove the decorator to get the new behavior. I thought maybe avoiding the use of inspect would reduce overhead, but I measured the overhead of the two and they are comparable. (Both about 4x just emitting a DeprecationWarning.)

I find such a decorator super useful — i’d like to use it right away to clean up some functions in spatial.distance (c.f. gh-21090), which take a pair of inputs named u, v, XA, XB, etc…
A small suggestion: it might be clearer to see the “target” signature if the decorator could be used like this:
@_deprecate_pos_kwd_only_args(version="1.15.0")
@_axis_nan_policy_factory(pack_TtestResult, default_axis=0, n_samples=2,
                          result_to_tuple=unpack_TtestResult, n_outputs=6)
def ttest_ind(a, b, /, *, axis=0, equal_var=True, nan_policy='propagate',
permutations=None, random_state=None, alternative="two-sided",
              trim=0):

That is, instead of listing in the decorator what arguments should not be passed by position and what should not be passed by name, infer the correct usage from the target signature and allow (with a deprecation warning) non-conforming usage.
This is just a cosmetic suggestion and the functionality is equivalent to what you have already written.


Add syntax highlighting and auto-indentation to CSS

Closing this since this project is kind of dead.


Make the nebula wizard embed-able

Describe the solution you'd like
I would want to be able to pragmatically embed a contract. This would generate the usual invoke and similar commands.
Consider such an example:

A Remix button can be included to redirect to the pulsar IDE.
Additional context
We can borrow more context from other similar embed-able wizards.

How would this work?

Create a comprehensive component for the CodeEditor
Allow the component to be usable by both projects.
Allow compiling the component as a stand alone javascript file.

An alternative to the code syntax above:


az aks use-dev-spaces always request az login

Describe the bug
I am following the following article to setup an debug an AKS cluster through VS Code: https://docs.microsoft.com/en-us/azure/dev-spaces/quickstart-nodejs
Follow every step until:
az aks use-dev-spaces -g $rg -n $aks
When I run this command I get:

Run 'az login' to login to Azure and try again.

No matter how many times I try to login, after running the command I get logged out of azure and have to login again to do anything else.
To Reproduce
Just follow the tutorial:
https://docs.microsoft.com/en-us/azure/dev-spaces/quickstart-nodejs
Azure-CLI version: azure-cli (2.0.49)
Dev-Spaces version: dev-spaces-preview (0.1.6)
Expected behavior
Ability to use dev-spaces-preview extension and complete the tutorial.
Environment summary
**Azure Location**
WestEurope

**OS**
Windows 10 Pro (updated)

**PowerShell:**
Major  Minor  Build  Revision
-----  -----  -----  --------
5      1      17134  407

**Azure-CLI:**
azure-cli (2.0.49)

acr (2.1.7)
acs (2.3.9)
advisor (0.6.0)
ams (0.2.4)
appservice (0.2.5)
backup (1.2.1)
batch (3.4.1)
batchai (0.4.4)
billing (0.2.0)
botservice (0.1.1)
cdn (0.2.0)
cloud (2.1.0)
cognitiveservices (0.2.3)
command-modules-nspkg (2.0.2)
configure (2.0.18)
consumption (0.4.0)
container (0.3.7)
core (2.0.49)
cosmosdb (0.2.2)
dla (0.2.3)
dls (0.1.4)
dms (0.1.1)
eventgrid (0.2.0)
eventhubs (0.3.0)
extension (0.2.2)
feedback (2.1.4)
find (0.2.12)
hdinsight (0.1.0)
interactive (0.3.31)
iot (0.3.3)
iotcentral (0.1.3)
keyvault (2.2.5)
lab (0.1.2)
maps (0.3.2)
monitor (0.2.5)
network (2.2.7)
nspkg (3.0.3)
policyinsights (0.1.0)
profile (2.1.1)
rdbms (0.3.2)
redis (0.3.2)
relay (0.1.2)
reservations (0.4.0)
resource (2.1.5)
role (2.1.8)
search (0.1.1)
servicebus (0.3.1)
servicefabric (0.1.6)
signalr (1.0.0)
sql (2.1.5)
storage (2.2.3)
telemetry (1.0.0)
vm (2.2.6)

Extensions:
dev-spaces-preview (0.1.6)

Additional context
Also tried updating Azure-CLI from 2.0.49 to 2.0.52, same behavior. I do have more than one Azure Subscription under my user. But I can create AKS through my default subscription.
with --debug and --verbose flags:
Command arguments: ['aks', 'use-dev-spaces', '--verbose', '--debug', '--output', 'table', '--name', 'AKS-PoC', '--resource-group', 'Azure-AKS-PoC']
Event: Cli.PreExecute []
Event: CommandParser.OnGlobalArgumentsCreate [<function CLILogging.on_global_arguments at 0x03B8F858>, <function OutputProducer.on_global_arguments at 0x03A0A6A8>, <function CLIQuery.on_global_arguments at 0x03B10CD8>]
Event: CommandInvoker.OnPreCommandTableCreate []
Installed command modules ['acr', 'acs', 'advisor', 'ams', 'appservice', 'backup', 'batch', 'batchai', 'billing', 'botservice', 'cdn', 'cloud', 'cognitiveservices', 'configure', 'consumption', 'container', 'cosmosdb', 'dla', 'dls', 'dms', 'eventgrid', 'eventhubs', 'extension', 'feedback', 'find', 'hdinsight', 'interactive', 'iot', 'iotcentral', 'keyvault', 'lab', 'maps', 'monitor', 'network', 'policyinsights', 'profile', 'rdbms', 'redis', 'relay', 'reservations', 'resource', 'role', 'search', 'servicebus', 'servicefabric', 'signalr', 'sql', 'storage', 'vm']
Loaded module 'acr' in 0.005 seconds.
Loaded module 'acs' in 0.004 seconds.
Loaded module 'advisor' in 0.002 seconds.
Event: CommandLoader.OnLoadCommandTable []
Loaded module 'ams' in 0.007 seconds.
Loaded module 'appservice' in 0.008 seconds.
Loaded module 'backup' in 0.004 seconds.
Event: CommandLoader.OnLoadCommandTable []
Loaded module 'batch' in 0.011 seconds.
Loaded module 'batchai' in 0.004 seconds.
Loaded module 'billing' in 0.002 seconds.
Loaded module 'botservice' in 0.004 seconds.
Event: CommandLoader.OnLoadCommandTable []
Loaded module 'cdn' in 0.005 seconds.
Loaded module 'cloud' in 0.002 seconds.
Loaded module 'cognitiveservices' in 0.002 seconds.
Loaded module 'configure' in 0.002 seconds.
Loaded module 'consumption' in 0.004 seconds.
Loaded module 'container' in 0.003 seconds.
Loaded module 'cosmosdb' in 0.005 seconds.
Loaded module 'dla' in 0.005 seconds.
Loaded module 'dls' in 0.004 seconds.
Loaded module 'dms' in 0.002 seconds.
Loaded module 'eventgrid' in 0.003 seconds.
Loaded module 'eventhubs' in 0.004 seconds.
Loaded module 'extension' in 0.001 seconds.
Loaded module 'feedback' in 0.001 seconds.
Loaded module 'find' in 0.001 seconds.
Loaded module 'hdinsight' in 0.003 seconds.
Loaded module 'interactive' in 0.001 seconds.
Loaded module 'iot' in 0.004 seconds.
Loaded module 'iotcentral' in 0.002 seconds.
Loaded module 'keyvault' in 0.006 seconds.
Loaded module 'lab' in 0.005 seconds.
Loaded module 'maps' in 0.002 seconds.
Loaded module 'monitor' in 0.005 seconds.
Loaded module 'network' in 0.025 seconds.
Loaded module 'policyinsights' in 0.002 seconds.
Loaded module 'profile' in 0.002 seconds.
Loaded module 'rdbms' in 0.007 seconds.
Loaded module 'redis' in 0.003 seconds.
Loaded module 'relay' in 0.004 seconds.
Loaded module 'reservations' in 0.003 seconds.
Loaded module 'resource' in 0.010 seconds.
Loaded module 'role' in 0.005 seconds.
Loaded module 'search' in 0.002 seconds.
Loaded module 'servicebus' in 0.005 seconds.
Loaded module 'servicefabric' in 0.003 seconds.
Loaded module 'signalr' in 0.002 seconds.
Loaded module 'sql' in 0.007 seconds.
Event: CommandLoader.OnLoadCommandTable []
Loaded module 'storage' in 0.029 seconds.
Loaded module 'vm' in 0.012 seconds.
Loaded all modules in 0.245 seconds. (note: there's always an overhead with the first module loaded)
Extensions directory: 'c://Repos/\.azure\cliextensions'
Found 1 extensions: ['dev-spaces-preview']
Event: CommandLoader.OnLoadCommandTable []
Loaded extension 'dev-spaces-preview' in 0.003 seconds.
Event: CommandInvoker.OnPreCommandTableTruncate []
Event: CommandInvoker.OnPostCommandTableCreate [<function register_global_subscription_argument.<locals>.add_subscription_parameter at 0x03BDEC00>, <function register_ids_argument.<locals>.add_ids_arguments at 0x03BE7660>]
Event: CommandInvoker.OnCommandTableLoaded []
Event: CommandInvoker.OnPreParseArgs [<function _documentdb_deprecate at 0x048A0618>]
Event: CommandInvoker.OnPostParseArgs [<function OutputProducer.handle_output_argument at 0x03A0A6F0>, <function CLIQuery.handle_query_parameter at 0x03B10C90>, <function register_ids_argument.<locals>.parse_ids_arguments at 0x03BE76A8>, <function handler at 0x0492E978>]
Getting management service client client_type=ContainerServiceClient
msrest.universal_http.requests : Configuring retry: max_retries=4, backoff_factor=0.8, max_backoff=90
msrest.universal_http.requests : Configuring retry: max_retries=4, backoff_factor=0.8, max_backoff=90
Extensions directory: 'c://Repos/\.azure\cliextensions'
Run 'az login' to login to Azure and try again.
Event: CommandInvoker.OnTransformResult [<function _resource_group_transform at 0x03BDEB28>, <function _x509_from_base64_to_hex_transform at 0x03BDEB70>]
Event: CommandInvoker.OnFilterResult []
Event: Cli.PostExecute []
telemetry.save : Save telemetry record of length 2489 in cache
telemetry.check : Negative: The c://Repos/\.azure\telemetry.txt was modified at 2018-12-17 15:57:02.430569, which in less than 600.000000 s

Closing pending repro.


[incubator-kie-issues#968] Support ConditionalExpr in Drools executable model

Fixes https://github.com/apache/incubator-kie-issues/issues/968
Note: this is the when condition used as example
 $p : Person($booleanVariable: (name != null ? true : false))
In both kind of executions (legacy vs executablemodel) the condition that populate the $booleanVariable is ignored for the evaluation of the rule, it is used only for the population of the variable itself

How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.
build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

How to retest this PR or trigger a specific build:

for pull request and downstream checks

Push a new commit to the PR. An empty commit would be enough.

for a full downstream build

for github actions job: add the label run_fdb

for Jenkins PR check only

If you are an ASF committer for KIE podling, login to Jenkins (https://ci-builds.apache.org/job/KIE/job/drools/), go to the specific PR job, and click on Build Now button.

I don't think it can be ignored for the rule evaluation. If it is a boolean condition, it is a constraint in my opinion. What do you think please? Also how does it behave please for non-Boolean typed expressions?

As stated in the comment, that modification on the executable model EXACTLY MIMIC what happen in the legacy one.
Please look at the test, that verify the two different conditions (true/false) for both implementations.
IINW drools currently does not support the nested assignment before "when" evaluation.
My understanding is that (if there is an assignment inside an object):

drools evaluate the condition based on presence of the object itself, and possibly properties already defined for the object
after that, it evaluate the nested property assignment, populating it

IIUC, the request would be to

first, evaluate the inner property assignement
then, evaluate the when condition

I have the impression it would be quite a change, to be done at both compile and execution time, for both model implementations.
This PR ensure the behaviour in the given cases is the same for both implementations, and this is required to allow migration by users.
Changing the logic itself would require more effort, and I think it should be delegated to a specific ticket.
@mariofusco Of course, all my previous assumptions may be wrong, feel free to correct/extend, thanks!

Thanks @mariofusco !
The caveat I found is that in the following expression
$p : Person($booleanVariable: (name != null ? true : false))
the
$booleanVariable: (name != null ? true : false)
part is actually an assignment, so semantically the same as
$p : Person($anotherVariable: ("name"+"somethingelse"))
so, changing the behavior base on the type of the variable, seems unconsistent to me.
In that very example, the rule should be evaluated only when
name != null, and only in that case the $booleanVariable should be populated.
The concept applies beside that simple example, of course, whenever a boolean property is assigned on the fly in the when clause while, actually, this should happen in the then:
if the rule is executed based on the predicate itself, then the variable will be populated (in that context, for me the name != null ? true : false is the predicate, and the $booleanVariable is the result of it)
AFAIK, this should be the correct syntax
global Boolean booleanVariable
rule \"r1\"
when
    $p : Person(name != null);
then
   booleanVariable = true;
   System.out.println(booleanVariable);
   System.out.println($p);
   booleanListGlobal.add(booleanVariable);
end

I have the impression that we are looking for a modification around a wrong usage of the language, putting a consequence semantic inside an evaluating one.
I'm not the responsible of drl language, but this seems strange to me, from a logical point of view.

I don't think it can be ignored for the rule evaluation. If it is a boolean condition, it is a constraint in my opinion. What do you think please? Also how does it behave please for non-Boolean typed expressions?

TBH I do not think so: from logical point of view, it is an "assignment" what we are talking about. "By chance, in this case the variable is a boolean, that of course can be populated only by a condition. BUt dealing with that case in a different way then the other kind of "assignment" would introduce a pretty evident unconsistency


Red line border left

As reported here: roboconf/roboconf#111
There is a red line at border left.
The associated css is in the file app/css/style.css at line 214: border-left: 2px #b23e4b solid;

8 months later...
I would have appreciated a screenshot. :+1  But I found it...


f_736 or f_376

thank you for the repository!!
I would like to mention there may be a mistake line 295 of loadOpenface.py, I believe it's f_736
almost nothing ;)

Thank you! I fixed it.


Restructured Awesomebook using ES6 for PR

Restructured  Awesome books app code and organized by using modules.

Use the npm init -y command to create a package.json file.
Create the entry point for your JavaScript code called index.js
Create an index.css file for your styles.
Create the main index.html file. Link your index.js and index.css files there.
Create a directory called modules.

Re-create your Awesome books app following the rules:

Use ES6 syntax.
Divide your code into modules.
Import modules into the index.js file. (Tip: the more modules the better!)
Refactor your functions to arrow functions.
Use let and const in the correct way.

project completed


strncpy bounds warning with GCC8

GCC8 added or extended  a new class of warnings, -Wstringop-truncation, which cause polybar to fail to build with -Werror as set in the build system. The warnings I encountered are reproduced below:
[  1%] Generating ../../../lib/xpp/include/xpp/proto/xkb.hpp
Scanning dependencies of target i3ipc++
Scanning dependencies of target polybar-msg
[  2%] Generating ../../../lib/xpp/include/xpp/proto/x.hpp
[  3%] Generating ../../../lib/xpp/include/xpp/proto/randr.hpp
[  4%] Building CXX object lib/i3ipcpp/CMakeFiles/i3ipc++.dir/src/ipc.cpp.o
[  5%] Building CXX object bin/CMakeFiles/polybar-msg.dir/ipc.cpp.o
[  7%] Building CXX object lib/i3ipcpp/CMakeFiles/i3ipc++.dir/src/ipc-util.cpp.o
[  7%] Building CXX object bin/CMakeFiles/polybar-msg.dir/utils/env.cpp.o
/tmp/makepkg/polybar-git/src/polybar/lib/i3ipcpp/src/ipc-util.cpp: In constructor ‘i3ipc::buf_t::buf_t(uint32_t)’:
/tmp/makepkg/polybar-git/src/polybar/lib/i3ipcpp/src/ipc-util.cpp:37:9: warning: ‘char* strncpy(char*, const char*, size_t)’ specified bound 6 equals destination size [-Wstringop-truncation]
  strncpy(header->magic, g_i3_ipc_magic.c_str(), sizeof(header->magic));
  ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[  8%] Building CXX object bin/CMakeFiles/polybar-msg.dir/utils/file.cpp.o
[ 10%] Linking CXX static library libi3ipc++.a
[ 11%] Building CXX object bin/CMakeFiles/polybar-msg.dir/utils/string.cpp.o
[ 12%] Linking CXX executable polybar-msg
[ 12%] Built target polybar-msg
list: size, ['red', 'green', 'blue']
list: size, ['red', 'green', 'blue']
[ 12%] Built target i3ipc++
Scanning dependencies of target xpp
[ 13%] Linking CXX static library libxpp.a
[ 13%] Built target xpp
Scanning dependencies of target polybar
[ 14%] Building CXX object bin/CMakeFiles/polybar.dir/adapters/alsa/mixer.cpp.o
[ 15%] Building CXX object bin/CMakeFiles/polybar.dir/adapters/pulseaudio.cpp.o
[ 16%] Building CXX object bin/CMakeFiles/polybar.dir/adapters/net.cpp.o
[ 17%] Building CXX object bin/CMakeFiles/polybar.dir/adapters/alsa/control.cpp.o
[ 19%] Building CXX object bin/CMakeFiles/polybar.dir/cairo/utils.cpp.o
[ 20%] Building CXX object bin/CMakeFiles/polybar.dir/components/bar.cpp.o
[ 21%] Building CXX object bin/CMakeFiles/polybar.dir/components/builder.cpp.o
[ 22%] Building CXX object bin/CMakeFiles/polybar.dir/components/command_line.cpp.o
/tmp/makepkg/polybar-git/src/polybar/src/adapters/net.cpp: In member function ‘void polybar::v3_1_0_118_gf2010ed_git::net::network::check_tuntap()’:
/tmp/makepkg/polybar-git/src/polybar/src/adapters/net.cpp:162:12: warning: ‘char* strncpy(char*, const char*, size_t)’ specified bound 16 equals destination size [-Wstringop-truncation]
     strncpy(request.ifr_name, m_interface.c_str(), IFNAMSIZ - 0);
     ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[ 23%] Building CXX object bin/CMakeFiles/polybar.dir/components/config.cpp.o
[ 24%] Building CXX object bin/CMakeFiles/polybar.dir/components/controller.cpp.o
[ 25%] Building CXX object bin/CMakeFiles/polybar.dir/components/ipc.cpp.o

It appears that the first example (the IPC magic string) might more appropriately use memcpy since it is a fixed size byte sequence and not null-terminated.
The second example in the output is the only time IFNAMSIZ-0 is used within the file; the other uses of strncpy in that file use IFNAMSIZ-1.
I am willing to help track down any other instances of this and submit a pull request fixing them.

Thanks for reporting this! Fix is ready in a PR waiting for approval


Write access modifier not highlighting correctly

Because it ends in semi-colon instead of a colon specifying conditions


[Refactoring] Refactor wording

Describe the solution you'd like
We are porting our system from Disfactory. Refactoring the codebase by re-wording like 工廠 (as-is) to 黑熊 (to-be).

This issue is general and board. The issues like #15 and #14 are the corresponding sub-tasks.

Please note I will keep this issue open as an umbrella issue until alpha is ready.

Next step: try to redefine this issue to see we want to close it or track with the other issues.


rtext: added functions for camel case and snake case (reopened due to formatting errors)

Adds functions for converting text to camel and snake case to match the addition of a pascal case function. Both have been tested against each other's conventions.
This is a duplicate of a PR that was opened earlier. I forgot to turn my auto formatter off so the PR had 6,000 changes. I used git reset, redid the changes, and then forced pushed the commit; as a result, the old PR cannot be merged, so I have to open a new one.
And if I am wrong, then this is what I am seeing on my screen, which is of importance:

Forgot to commsnt btw but the issue is fixed.
The other issues GitHub found are present in TextToPascal and not relevant.

@IoIxD Thanks for the addition! Probably not many users would need that functionality but I personally could need it.

@IoIxD Thanks for the addition! Probably not many users would need that functionality but I personally could need it.

No problem! I was also actually just thibking of a fourth function that could turn any of these cases into properly spaced/capitalized case (snake_case -> Snake Case). Would you be down for that?

Would you be down for that?

@IoIxD I think it's ok for now, the provided functions already cover most of the possible use cases for this kind of functions. Personally I find it useful when generating code from data (like in parsers and similars...).


docs: update docs

Description
This PR includes updates in API and CLI docs.

@crypin

Is there a reason why x/liquidamm/spec part is empty? Will it be added later?

Updated x/liquidamm/spec.

I think we need to update the module name used for this part

Handled in #201, in this file.

This is another issue, but it seems necessary to discuss whether the voting power related to liquidamm balance including btoken should be added to the liquidstaking liquid gov part

Handled in #201.


slider_publisher: 2.2.1-3 in 'foxy/distribution.yaml' [bloom]

Increasing version of package(s) in repository slider_publisher to 2.2.1-3:

upstream repository: https://github.com/oKermorgant/slider_publisher.git
release repository: https://github.com/ros2-gbp/slider_publisher-release.git
distro file: foxy/distribution.yaml
bloom version: 0.11.2
previous version for package: 2.2.0-1

slider_publisher
* remove py extension, fix rate default value
* switch to CMake to avoid deprecation messages
* Contributors: Olivier Kermorgant

Holding for Foxy sync


Deprecated warning is hard to understand without dates

I believe Flutter's deprecation warnings are way too hard to understand. For example, it usually says "deprecated after v1.22.0-12.0.pre". What does that mean? Was it deprecated last week? Last month? Last year? How urgent is this deprecation? I have no idea. It is extremely verbose.

You may wonder, isn't it just a Google search away? The answer is no, you won't find in Google.

My suggestion is to include the date. Instead of This feature was deprecated after v1.22.0-12.0.pre., it could be This feature was deprecated after v1.22.0-12.0.pre on December 20, 2020 or something like that. The same thing affects the Material Fonts change; no one knows what is 'v1.13.8' or how long it's been.

Hi @bernaferrari
You can easily find the release date of each and every Flutter version released here and here.
I see no reason to add hard coded dates in the deprecated warnings
Closing, as this isn't an issue with Flutter itself. If you disagree, please write in the comments and I will reopen it.
Thank you

Hi @bernaferrari
You can easily find the release date of each and every Flutter version released here and here.
I see no reason to add hard coded dates in the deprecated warnings
Closing, as this isn't an issue with Flutter itself. If you disagree, please write in the comments and I will reopen it.
Thank you


GH-86: Fixed crash bug on load error on disposed resources.

Also added cyclic HTTP get tests.

Pull Request Test Coverage Report for Build 97

14 of 16 (87.5%)  changed or added relevant lines in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.09%) to 82.001%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

server/subscription.go
14
16
87.5%

Files with Coverage Reduction
New Missed Lines
%

server/subscription.go
1
82.21%

Totals

Change from base Build 95:
-0.09%

Covered Lines:
2287

Relevant Lines:
2789

💛  - Coveralls


ESCAM PT202	RTSP NOT WORKING

Hi
I'm not getting the rtsp to work on my ESCAM PT202.

Firmware version: 0.2.2

FTP: OK
[ OK] SSH
[ OK] Snapshot
[ OK] ONVIF
[ WIFI] Wifi/ETH

I had the same problem.
I activated the "RTSP alternative server" and it started working.
However I noticed that after a few hours vlcplayer stops displaying the images. If I restart the camera it works again until it blocks again.
I think it's a firmware error.

The standard RTSP server should work.
It comes from a very popular and very stable library (live555).
Alternative server is simpler and rougher, but it's more compatible with some hardware nvr.
So, you should use the first one.
Please, when you try to play with vlc, try 2 or 3 times. Sometimes vlc is hard to get started.
If it doesn't work, try another rtsp client, ffmpeg is good test.
ffmpeg -r 20 -rtsp_transport tcp -i rtsp://<IP_ADDRESS>/ch0_0.h264 /tmp/test.h264


using with django-redis

I'm trying to implement connection pooling by combining django-rq with django-redis, and I'm running into a few issues.
The first thing is probably just a documentation update. The existing example says that we should set
 'CLIENT_CLASS': 'redis_cache.client.DefaultClient',

But the django_redis documentation says that "redis_cache" is deprecated and should be replaced with "django_redis"
But when I do that, I'm getting:
AttributeError: 'DefaultClient' object has no attribute 'client'
Which makes sense because there is no "client" property in django_redis.client.DefaultClient. (I've tried 3.7, 3.8 and 4.0 of django_redis)

I'm using django_redis.client.DefaultClient with on the 3.8 line of django-redis in production and it's working fine so it's probably just some installation issues.
I suggest doing a pip uninstall django-redis and reinstall with pip install django-redis and check if the issue still persists. If it does, open an issue in django-redis' repository.


Create README.md

@laojiuh, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

@laojiuh, we have received your signed contributor license agreement. It will be reviewed by VMware shortly. Another comment will be added to the pull request to notify you when the merge can proceed.

@laojiuh, VMware has rejected your signed contributor license agreement. The merge can not proceed until the agreement has been resigned. Click here to resign the agreement. Reject reason:

111

@laojiuh, we have received your signed contributor license agreement. It will be reviewed by VMware shortly. Another comment will be added to the pull request to notify you when the merge can proceed.

@laojiuh, VMware has approved your signed contributor license agreement.


https://issues.jboss.org/browse/JBTIS-483

Migrate to use new license feature in JBTIS 4.3 / JBDS IS 9

Two general comments/suggestions (applies to other PRs as well):

please squash the commits into single one. They both have identical commits message.
please use just the issue handle (JBTIS-483) in the commit message (instead of the full URL). Full URL has 41 characters which is quite a lot and I don't think the additional info it brings is worth it.

I applied the above suggestions, fixed copy&paste errors in year (2012->2015) and merged the changes into master: https://github.com/droolsjbpm/droolsjbpm-tools/commit/5855f2b74a21534b1079521067d6f466c4b11218


preprocessing of texts and source code

Great work on source code generation.
The details of the preprocessing of texts (naturel languges) and source code are missing from the paper. Would you kindly let me known what kind of preprossing has been conducted, e.g., unifying identifiers?
Thanks.
Hui
<EMAIL_ADDRESS>

Great work on source code generation.
The details of the preprocessing of texts (naturel languges) and source code are missing from the paper. Would you kindly let me known what kind of preprossing has been conducted, e.g., unifying identifiers?
Thanks.
Hui
<EMAIL_ADDRESS>
have you solved the question ?
i am also curious about it

Great work on source code generation.
The details of the preprocessing of texts (naturel languges) and source code are missing from the paper. Would you kindly let me known what kind of preprossing has been conducted, e.g., unifying identifiers?
Thanks.
Hui
<EMAIL_ADDRESS>
have you solved the question ?
i am also curious about it

No. But I built a new dataset (https://github.com/ds4an/CoDas4CG) and conduct a sequence of preprossing as I will :)

Great work on source code generation.
The details of the preprocessing of texts (naturel languges) and source code are missing from the paper. Would you kindly let me known what kind of preprossing has been conducted, e.g., unifying identifiers?
Thanks.
Hui
<EMAIL_ADDRESS>
have you solved the question ?
i am also curious about it

No. But I built a new dataset (https://github.com/ds4an/CoDas4CG) and conduct a sequence of preprossing as I will :)

datasets/conala/dataset.py may do the preprocessing, i thought

@jason-hanling @liuhuigmail
Hi, Professor Liu,
I am also interested about how to pre-process the data.
I note that the pre-processing is done by the dataset.py script (you are right).  I'd like to know what the files are like before pre-processing (conala-train.json). However, I found that the official webpage of CoNala (https://conala-corpus.github.io/) does not support downloading any more.
I wonder do you have something to share. Thanks!

I'm not sure why, but some people have been having trouble downloading the dataset on the chrome browser. Here's a direct link that should work. The dataset is still available:
http://www.phontron.com/download/conala-corpus-v1.1.zip

Oh great @neubig
Thanks a lot.


VEP still needs some fixes

Hi Brad,
I've opened this issue because I've found some things that still bother me when using VEP. I'll try to fix most in an upcoming PR, but I'd like some comments from you/anyone interested. Feel free to strike through anything you're opposed to

[ ] add dbscSNV to the plugins used by default. Since dbscsnvhas been added as datatarget, we can assume the user wants the annotation if it has been downloaded. Same principle as dbnsfp.
[ ] the genesplicer plugin isn't included, even though the executable is installed and the option is included in the list of activated plugins.
[ ] speaking of plugins. I feel we should move the plugin selection away from bcbio_system.yaml and into the analysis config. Does this config support nested options?
[ ] there should also be an option to disable default options
[ ] there should be a function that lists all arguments vep uses and removes the duplicates. it should perhaps also filter out options that are set using different arguments (eg effects_transcripts)
[ ] deprecate the use of the --fields flag, since all this does is format the CSQ tag, without any added benefit.
[ ] ...

I'm hoping to hear your thoughts on this. I'd like to get all the kinks worked out so we can clinically validate everything by May.
Thanks!
M

Another question. Is there a reason arguments that contain a whitespace are added to the arguments list with 2 separate entries? Or is this just code styling? Sticking the 2 together woud greatly simplify the process of cleaning up the arguments list.
Thanks
M

Matthias;
Thanks for continuing to work on the VEP integration. In general, I'd like to push back a bit on introducing a ton of configuration knobs for VEP. We try to avoid this approach in bcbio and focus on having a default approach that works for most cases with minimal tweaking where needed.
Is there any downside to running all of the plugins as long as the data is installed? If not, we should just pile everything on and let folks sort out what they need in downstream analysis. The temporary configuration in bcbio_system.yaml was more to test and develop this but it would be great to settle on more of a standard approach to take here so other people don't need to push all these buttons to get things to work.
If we have a add everything approach this changes a lot of your needs since we don't need to have functions to micromanage argument parsing and should make the code simpler. Do you think this would work? Thanks again for the discussion.

Hi Brad,
I surely don't mind adding all options, especially for VEP itself. We could simplify the code by leaving out the expansive list of annotation arguments and just adding --all, which amounts to just a bit more fields than we currently have. This argument expands to a fixed set and does not vary between versions of VEP. This also doesn't affect runtime very much.
For the plugins however, I might see another scenario. I don't mind having them all running all the time, because that's just what we need, but other users might have little use of the info from maxentscan and genesplicer, and these slow VEP down significanly. So I would keep an option available to disable some plugins, in whichever form you like. If we keep it in the bcbio_system.yaml, users can define their own defaults, based on their use case. That would work for me.
As for the dbNSFP fields, all these do is increase the size of the resulting vcf, so I'd also go with an "add all" approach. I would, however, leave out the population statistics from dbNSFP, since these can be dated in comprarison with the ones from VEP.
I'll work on the changes and create a PR, then we can discuss this further.
M

hi @chapmanb
I've identified the issue with the genesplicer plugin. It seems the genesplicer training dir isn't included in the genome_resources array. I'm not really sure why this is, but this is the thing stopping the plugin from working. Could you point me in the right direction?
Thanks
M

Followed up on this in #1771, so closing this issue to avoid duplicate conversations.