Clipped glyphs when painting text with Canvas

An app that I'm working on is experiencing some minor glyph clipping when painting text with a Canvas.
We're implementing text rendering based on incoming documents, which tell us where and how to paint text.
For the most part, the text that we paint looks fine. But we're seeing minor clipping throughout the text that we paint. Here's an example:

My guess is that this clipping is a side effect of how the documents tell us to paint text. They set the font size to 1.0, and then they tell us to transform the canvas by scaling it up 12x for 12pt fonts, or 24x for 24pt fonts. In theory, this shouldn't effect anything, but that's my best guess for why this clipping problem is happening.
Here's a minimal reproduction based on actual style and size values in one of our documents: https://gist.github.com/matthew-carroll/5ecf8d00ce2840b3ab525d7d5d82fa6c
Flutter version:
Flutter 3.3.3 • channel stable • https://github.com/flutter/flutter.git
Framework • revision 18a827f393 (3 weeks ago) • 2022-09-28 10:03:14 -0700
Engine • revision 5c984c26eb
Tools • Dart 2.18.2 • DevTools 2.15.0

Reproducible using the sample provided above. Pasted below for easy access.
Labeling for further investigation

screenshot

code sample
import 'dart:ui' as ui;

import 'package:flutter/material.dart';

/// This app reproduces a text painting bug in which some characters, and some
/// descenders are cut off.
///
/// This repro captures an actual state of paragraph style, text style, and canvas
/// scaling. We're painting text in our app based on a document's specification of
/// characters and spacing between them. In general, this is working fine. However
/// there are numerous places where we see minor clipping, like we do with this example.
///
/// You'll notice that the font size is set to 1.0 and then the canvas is scaled up 24x,
/// resulting in an effective font size of 24. We do this because it matches the semantics
/// of the document. The document gives us the font size, and the painting transform.
void main() {
  runApp(
    const MaterialApp(
      home: _TextClippingBug(),
    ),
  );
}

class _TextClippingBug extends StatelessWidget {
  const _TextClippingBug({Key? key}) : super(key: key);

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: Center(
        child: CustomPaint(
          painter: _ClippedTextPainter(
            paragraphStyle: ui.ParagraphStyle(
              textAlign: TextAlign.left,
              fontWeight: FontWeight.w400,
              fontStyle: FontStyle.normal,
              fontSize: 1.0,
            ),
            textStyle: ui.TextStyle(
              color: const Color(0xff000000),
              letterSpacing: -0.015,
              wordSpacing: -0.02,
            ),
            textAndSpaces: [
              "mental ",
              0.5,
              "models ",
              0.6,
              "of ",
              0.5,
              "how ",
              0.5,
              "to ",
              0.5,
              "learn ",
              0.5,
              "effectively",
              70,
              ". ",
              0.5,
              "Over",
              17,
              "all",
              " ",
              0.6,
              "the ",
              0.5,
              "r",
              17,
              "esear",
              17,
              "ch ",
              0.5,
              "discussed ",
              0.5,
              "in ",
              0.5,
              "this ",
              0.5,
              "Review ",
              0.5,
              "has",
              -15,
            ],
          ),
        ),
      ),
    );
  }
}

class _ClippedTextPainter extends CustomPainter {
  const _ClippedTextPainter({
    required this.textAndSpaces,
    required this.paragraphStyle,
    required this.textStyle,
  });

  final List<dynamic> textAndSpaces;
  final ui.ParagraphStyle paragraphStyle;
  final ui.TextStyle textStyle;

  @override
  void paint(Canvas canvas, Size size) {
    final builder = ui.ParagraphBuilder(paragraphStyle);

    print("Painting text");
    print(" - text and spaces: $textAndSpaces");
    print("");
    print(" - style:");
    print(textStyle.toString());
    print("");
    print(" - text builder:");
    builder.pushStyle(textStyle);
    final debugStringBuffer = StringBuffer();
    for (final arg in textAndSpaces) {
      if (arg is String) {
        print("    - string: '$arg'");
        builder.addText(arg);
        debugStringBuffer.write(arg);
      } else {
        const fontSize = 1.0;
        const horizontalScalePercent = 1.0;
        final spacer = ((-arg / 1000) * fontSize) * horizontalScalePercent;
        print("    - placeholder: $spacer px wide");
        builder.addPlaceholder(spacer, 1, PlaceholderAlignment.bottom);

        debugStringBuffer.write(" ");
      }
    }
    print("");

    final paragraph = builder.build()..layout(const ui.ParagraphConstraints(width: double.infinity));

    canvas.save();
    canvas.scale(24);
    canvas.translate(-paragraph.maxIntrinsicWidth / 2, 0);
    canvas.drawParagraph(paragraph, Offset(0, -paragraph.alphabeticBaseline));
    canvas.restore();
  }

  @override
  bool shouldRepaint(covariant CustomPainter oldDelegate) {
    return true;
  }
}

flutter doctor -v
[✓] Flutter (Channel stable, 3.3.4, on macOS 12.6 21G115 darwin-arm, locale en-GB)
    • Flutter version 3.3.4 on channel stable at /Users/nexus/dev/sdks/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision eb6d86ee27 (12 days ago), 2022-10-04 22:31:45 -0700
    • Engine revision c08d7d5efc
    • Dart version 2.18.2
    • DevTools version 2.15.0

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0)
    • Android SDK at /Users/nexus/Library/Android/sdk
    • Platform android-33, build-tools 33.0.0
    • Java binary at: /Users/nexus/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/213.7172.25.2113.9123335/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.0)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14A309
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[!] Android Studio
    • Android Studio at /Applications/Android Studio Preview.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    ✗ Unable to find bundled Java version.
    • Try updating or re-installing Android Studio.

[✓] Android Studio (version 2021.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)

[!] Android Studio
    • Android Studio at /Applications/Android Studio Preview 2.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    ✗ Unable to find bundled Java version.
    • Try updating or re-installing Android Studio.

[✓] Android Studio (version 2021.3)
    • Android Studio at /Users/nexus/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/213.7172.25.2113.9123335/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)

[✓] Android Studio (version 2021.3)
    • Android Studio at /Users/nexus/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/213.7172.25.2113.9014738/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)

[✓] VS Code (version 1.72.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.50.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-arm64   • macOS 12.6 21G115 darwin-arm
    • Chrome (web)    • chrome • web-javascript • Google Chrome 106.0.5249.119

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 2 categories.

[✓] Flutter (Channel master, 3.5.0-6.0.pre.49, on macOS 12.6 21G115 darwin-arm64, locale en-GB)
    • Flutter version 3.5.0-6.0.pre.49 on channel master at /Users/nexus/dev/sdks/flutters
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 1e4d56ec7a (7 hours ago), 2022-10-17 01:58:03 -0400
    • Engine revision f6aef9b30f
    • Dart version 2.19.0 (build 2.19.0-312.0.dev)
    • DevTools version 2.18.0

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0)
    • Android SDK at /Users/nexus/Library/Android/sdk
    • Platform android-33, build-tools 33.0.0
    • Java binary at: /Users/nexus/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/213.7172.25.2113.9123335/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.0)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14A309
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[!] Android Studio
    • Android Studio at /Applications/Android Studio Preview.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    ✗ Unable to find bundled Java version.
    • Try updating or re-installing Android Studio.

[✓] Android Studio (version 2021.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)

[!] Android Studio
    • Android Studio at /Applications/Android Studio Preview 2.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    ✗ Unable to find bundled Java version.
    • Try updating or re-installing Android Studio.

[✓] Android Studio (version 2021.3)
    • Android Studio at /Users/nexus/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/213.7172.25.2113.9123335/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)

[✓] Android Studio (version 2021.3)
    • Android Studio at /Users/nexus/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/213.7172.25.2113.9014738/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)

[✓] VS Code (version 1.72.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.50.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-arm64   • macOS 12.6 21G115 darwin-arm64
    • Chrome (web)    • chrome • web-javascript • Google Chrome 106.0.5249.119

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 2 categories.

This is related to the interaction between TextStyle.wordSpacing and placeholders.
A simplified reproduction:
import 'dart:ui' as ui;

import 'package:flutter/material.dart';

void main() {
  runApp(
    Center(child: CustomPaint(
      painter: _ClippedTextPainter(
        paragraphStyle: ui.ParagraphStyle(
          fontSize: 1.0,
        ),
        textStyle: ui.TextStyle(
          color: const Color(0xff000000),
          wordSpacing: -1.50,
        ),
      ),
    )),
  );
}

class _ClippedTextPainter extends CustomPainter {
  const _ClippedTextPainter({
    required this.paragraphStyle,
    required this.textStyle,
  });

  final ui.ParagraphStyle paragraphStyle;
  final ui.TextStyle textStyle;

  @override
  void paint(Canvas canvas, Size size) {
    final builder = ui.ParagraphBuilder(paragraphStyle);

    builder.pushStyle(textStyle);
    builder.addText('aaaaa ');
    builder.addPlaceholder(1, 1, PlaceholderAlignment.bottom);

    final paragraph = builder.build()..layout(const ui.ParagraphConstraints(width: double.infinity));

    canvas.save();
    canvas.scale(24);
    canvas.translate(-paragraph.maxIntrinsicWidth / 2, 0);
    canvas.drawParagraph(paragraph, Offset(0, -paragraph.alphabeticBaseline));
    canvas.restore();
  }

  @override
  bool shouldRepaint(covariant CustomPainter oldDelegate) {
    return true;
  }
}

Reproducing the clipping requires a few factors:

a text span that ends with whitespace
an adjacent placeholder
a text style with negative word spacing

On a debug build this triggers the TextLine::iterateThroughVisualRuns width comparison assert.  If that assert is disabled, then the text renders with a clip rectangle that subtracts the word spacing width.
@Rusino One potential fix would be deferring the application of word spacing until reaching the start of the next word (see https://skia-review.googlesource.com/c/skia/+/597256)


Bump versions

Required for some PRs at DMD and while I was at it I thought I bump everything.

So it looks like we can't upgrade to libdparse 0.10 fully, because ddox only supports 0.8. I added a workaround to the assert_rewrite_magic, let's see what this leads to.

Superseeded by https://github.com/dlang/dlang.org/pull/2758


HBASE-26802 Backport the log4j2 changes to branch-2

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 11s
Docker mode activated.

-0 :warning:
yetus
0m  4s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 18s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 16s
branch-2 passed

+1 :green_heart:
compile
1m 56s
branch-2 passed

+1 :green_heart:
shadedjars
4m 38s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
10m 10s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 42s
the patch passed

+1 :green_heart:
compile
2m  1s
the patch passed

-0 :warning:
javac
2m  1s
root generated 2 new + 37 unchanged - 0 fixed = 39 total (was 37)

+1 :green_heart:
shadedjars
0m 27s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m  6s
hbase-balancer in the patch failed.

_ Other Tests _

-1 :x:
unit
1m 59s
root in the patch failed.

43m 45s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4166/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4166

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 306e91dee7e7 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 0a7e49ca3b

Default Java
AdoptOpenJDK-1.8.0_282-b08

javac
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4166/1/artifact/yetus-jdk8-hadoop2-check/output/diff-compile-javac-root.txt

javadoc
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4166/1/artifact/yetus-jdk8-hadoop2-check/output/patch-javadoc-hbase-balancer.txt

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4166/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-root.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4166/1/testReport/

Max. process+thread count
99 (vs. ulimit of 12500)

modules
C: hbase-logging hbase-common hbase-metrics-api hbase-hadoop-compat hbase-metrics hbase-hadoop2-compat hbase-client hbase-zookeeper hbase-replication hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-rsgroup hbase-shell hbase-endpoint hbase-it hbase-rest hbase-examples hbase-shaded hbase-shaded/hbase-shaded-client hbase-shaded/hbase-shaded-client-byo-hadoop hbase-shaded/hbase-shaded-mapreduce hbase-hbtop hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-lz4 hbase-compression/hbase-compression-snappy hbase-compression/hbase-compression-xz hbase-compression/hbase-compression-zstd hbase-assembly hbase-shaded/hbase-shaded-testing-util hbase-shaded/hbase-shaded-testing-util-tester hbase-shaded/hbase-shaded-check-invariants hbase-shaded/hbase-shaded-with-hadoop-check-invariants hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project . hbase-balancer U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4166/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
6m 31s
Docker mode activated.

-0 :warning:
yetus
0m  5s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 18s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 59s
branch-2 passed

+1 :green_heart:
compile
1m 53s
branch-2 passed

+1 :green_heart:
shadedjars
3m 29s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
9m 46s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 17s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 30s
the patch passed

+1 :green_heart:
compile
1m 59s
the patch passed

-0 :warning:
javac
1m 59s
root generated 2 new + 37 unchanged - 0 fixed = 39 total (was 37)

+1 :green_heart:
shadedjars
0m 20s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m  7s
hbase-balancer in the patch failed.

_ Other Tests _

-1 :x:
unit
1m 45s
root in the patch failed.

46m 46s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4166/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4166

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 2ad8bcd1d101 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 0a7e49ca3b

Default Java
AdoptOpenJDK-11.0.10+9

javac
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4166/1/artifact/yetus-jdk11-hadoop3-check/output/diff-compile-javac-root.txt

javadoc
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4166/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-balancer.txt

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4166/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4166/1/testReport/

Max. process+thread count
213 (vs. ulimit of 12500)

modules
C: hbase-logging hbase-common hbase-metrics-api hbase-hadoop-compat hbase-metrics hbase-hadoop2-compat hbase-client hbase-zookeeper hbase-replication hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-rsgroup hbase-shell hbase-endpoint hbase-it hbase-rest hbase-examples hbase-shaded hbase-shaded/hbase-shaded-client hbase-shaded/hbase-shaded-client-byo-hadoop hbase-shaded/hbase-shaded-mapreduce hbase-hbtop hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-lz4 hbase-compression/hbase-compression-snappy hbase-compression/hbase-compression-xz hbase-compression/hbase-compression-zstd hbase-assembly hbase-shaded/hbase-shaded-testing-util hbase-shaded/hbase-shaded-testing-util-tester hbase-shaded/hbase-shaded-check-invariants hbase-shaded/hbase-shaded-with-hadoop-check-invariants hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project . hbase-balancer U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4166/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 48s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
shelldocs
0m  1s
Shelldocs was not available.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 19s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 41s
branch-2 passed

+1 :green_heart:
compile
6m 21s
branch-2 passed

+1 :green_heart:
checkstyle
1m 12s
branch-2 passed

+1 :green_heart:
spotbugs
16m 10s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m  4s
the patch passed

+1 :green_heart:
compile
6m 18s
the patch passed

+1 :green_heart:
javac
6m 18s
the patch passed

-0 :warning:
checkstyle
1m 10s
root: The patch generated 3 new + 233 unchanged - 4 fixed = 236 total (was 237)

+1 :green_heart:
shellcheck
0m  1s
There were no new shellcheck issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

-1 :x:
xml
0m 27s
The patch has 2 ill-formed XML file(s).

+1 :green_heart:
hadoopcheck
6m 42s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
19m 30s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
4m 27s
The patch does not generate ASF License warnings.

78m 56s

Reason
Tests

XML
Parsing Error(s):

hbase-assembly/src/main/assembly/client.xml

hbase-assembly/src/main/assembly/hadoop-three-compat.xml

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4166/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4166

Optional Tests
dupname asflicense shellcheck shelldocs javac hadoopcheck xml compile spotbugs hbaseanti checkstyle

uname
Linux 762d8897b9d8 5.4.0-1054-aws #57~18.04.1-Ubuntu SMP Thu Jul 15 03:21:36 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 0a7e49ca3b

Default Java
AdoptOpenJDK-1.8.0_282-b08

checkstyle
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4166/1/artifact/yetus-general-check/output/diff-checkstyle-root.txt

xml
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4166/1/artifact/yetus-general-check/output/xml.txt

Max. process+thread count
87 (vs. ulimit of 12500)

modules
C: hbase-logging hbase-common hbase-metrics-api hbase-hadoop-compat hbase-metrics hbase-hadoop2-compat hbase-client hbase-zookeeper hbase-replication hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-rsgroup hbase-shell hbase-endpoint hbase-it hbase-rest hbase-examples hbase-shaded hbase-shaded/hbase-shaded-client hbase-shaded/hbase-shaded-client-byo-hadoop hbase-shaded/hbase-shaded-mapreduce hbase-hbtop hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-lz4 hbase-compression/hbase-compression-snappy hbase-compression/hbase-compression-xz hbase-compression/hbase-compression-zstd hbase-assembly hbase-shaded/hbase-shaded-testing-util hbase-shaded/hbase-shaded-testing-util-tester hbase-shaded/hbase-shaded-check-invariants hbase-shaded/hbase-shaded-with-hadoop-check-invariants hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project . hbase-balancer U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4166/1/console

versions
git=2.17.1 maven=3.6.3 shellcheck=0.4.6 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 28s
Docker mode activated.

-0 :warning:
yetus
0m  4s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 19s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m  4s
branch-2 passed

+1 :green_heart:
compile
1m 52s
branch-2 passed

+1 :green_heart:
shadedjars
3m 30s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
9m 52s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 28s
the patch passed

+1 :green_heart:
compile
1m 55s
the patch passed

-0 :warning:
javac
1m 55s
root generated 2 new + 37 unchanged - 0 fixed = 39 total (was 37)

+1 :green_heart:
shadedjars
0m 21s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
10m  0s
the patch passed

_ Other Tests _

-1 :x:
unit
5m 23s
root in the patch failed.

44m 14s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4166/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4166

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 0dd15606f317 5.4.0-96-generic #109-Ubuntu SMP Wed Jan 12 16:49:16 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 0a7e49ca3b

Default Java
AdoptOpenJDK-11.0.10+9

javac
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4166/2/artifact/yetus-jdk11-hadoop3-check/output/diff-compile-javac-root.txt

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4166/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4166/2/testReport/

Max. process+thread count
371 (vs. ulimit of 12500)

modules
C: hbase-logging hbase-protocol-shaded hbase-common hbase-metrics-api hbase-hadoop-compat hbase-metrics hbase-hadoop2-compat hbase-client hbase-zookeeper hbase-replication hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-rsgroup hbase-shell hbase-endpoint hbase-it hbase-rest hbase-examples hbase-shaded hbase-shaded/hbase-shaded-client hbase-shaded/hbase-shaded-client-byo-hadoop hbase-shaded/hbase-shaded-mapreduce hbase-hbtop hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-lz4 hbase-compression/hbase-compression-snappy hbase-compression/hbase-compression-xz hbase-compression/hbase-compression-zstd hbase-assembly hbase-shaded/hbase-shaded-testing-util hbase-shaded/hbase-shaded-testing-util-tester hbase-shaded/hbase-shaded-check-invariants hbase-shaded/hbase-shaded-with-hadoop-check-invariants hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4166/2/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 28s
Docker mode activated.

-0 :warning:
yetus
0m  6s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 42s
branch-2 passed

+1 :green_heart:
compile
1m 56s
branch-2 passed

+1 :green_heart:
shadedjars
4m 13s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
9m 23s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 47s
the patch passed

+1 :green_heart:
compile
2m  6s
the patch passed

-0 :warning:
javac
2m  6s
root generated 2 new + 37 unchanged - 0 fixed = 39 total (was 37)

+1 :green_heart:
shadedjars
0m 27s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
1m 37s
root generated 6 new + 52 unchanged - 6 fixed = 58 total (was 58)

_ Other Tests _

-1 :x:
unit
5m 27s
root in the patch failed.

44m 16s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4166/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4166

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux a71032613e5c 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 0a7e49ca3b

Default Java
AdoptOpenJDK-1.8.0_282-b08

javac
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4166/2/artifact/yetus-jdk8-hadoop2-check/output/diff-compile-javac-root.txt

javadoc
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4166/2/artifact/yetus-jdk8-hadoop2-check/output/diff-javadoc-javadoc-root.txt

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4166/2/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-root.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4166/2/testReport/

Max. process+thread count
338 (vs. ulimit of 12500)

modules
C: hbase-logging hbase-protocol-shaded hbase-common hbase-metrics-api hbase-hadoop-compat hbase-metrics hbase-hadoop2-compat hbase-client hbase-zookeeper hbase-replication hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-rsgroup hbase-shell hbase-endpoint hbase-it hbase-rest hbase-examples hbase-shaded hbase-shaded/hbase-shaded-client hbase-shaded/hbase-shaded-client-byo-hadoop hbase-shaded/hbase-shaded-mapreduce hbase-hbtop hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-lz4 hbase-compression/hbase-compression-snappy hbase-compression/hbase-compression-xz hbase-compression/hbase-compression-zstd hbase-assembly hbase-shaded/hbase-shaded-testing-util hbase-shaded/hbase-shaded-testing-util-tester hbase-shaded/hbase-shaded-check-invariants hbase-shaded/hbase-shaded-with-hadoop-check-invariants hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4166/2/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 53s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+0 :ok:
shelldocs
0m  1s
Shelldocs was not available.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 15s
branch-2 passed

+1 :green_heart:
compile
6m 17s
branch-2 passed

+1 :green_heart:
checkstyle
1m  8s
branch-2 passed

+1 :green_heart:
spotbugs
17m 33s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m  0s
the patch passed

+1 :green_heart:
compile
6m 23s
the patch passed

+1 :green_heart:
javac
6m 23s
the patch passed

-0 :warning:
checkstyle
1m  9s
root: The patch generated 2 new + 233 unchanged - 4 fixed = 235 total (was 237)

+1 :green_heart:
shellcheck
0m  0s
There were no new shellcheck issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m 28s
The patch has no ill-formed XML file.

+1 :green_heart:
hadoopcheck
6m 39s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
21m  7s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
4m 27s
The patch does not generate ASF License warnings.

81m 18s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4166/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4166

Optional Tests
dupname asflicense shellcheck shelldocs javac hadoopcheck xml compile spotbugs hbaseanti checkstyle

uname
Linux e533b0b3ab49 5.4.0-1054-aws #57~18.04.1-Ubuntu SMP Thu Jul 15 03:21:36 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 0a7e49ca3b

Default Java
AdoptOpenJDK-1.8.0_282-b08

checkstyle
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4166/2/artifact/yetus-general-check/output/diff-checkstyle-root.txt

Max. process+thread count
87 (vs. ulimit of 12500)

modules
C: hbase-logging hbase-protocol-shaded hbase-common hbase-metrics-api hbase-hadoop-compat hbase-metrics hbase-hadoop2-compat hbase-client hbase-zookeeper hbase-replication hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-rsgroup hbase-shell hbase-endpoint hbase-it hbase-rest hbase-examples hbase-shaded hbase-shaded/hbase-shaded-client hbase-shaded/hbase-shaded-client-byo-hadoop hbase-shaded/hbase-shaded-mapreduce hbase-hbtop hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-lz4 hbase-compression/hbase-compression-snappy hbase-compression/hbase-compression-xz hbase-compression/hbase-compression-zstd hbase-assembly hbase-shaded/hbase-shaded-testing-util hbase-shaded/hbase-shaded-testing-util-tester hbase-shaded/hbase-shaded-check-invariants hbase-shaded/hbase-shaded-with-hadoop-check-invariants hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4166/2/console

versions
git=2.17.1 maven=3.6.3 shellcheck=0.4.6 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 23s
Docker mode activated.

-0 :warning:
yetus
0m  5s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 28s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 50s
branch-2 passed

+1 :green_heart:
compile
1m 51s
branch-2 passed

+1 :green_heart:
shadedjars
4m 22s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
9m 24s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 25s
the patch passed

+1 :green_heart:
compile
1m 48s
the patch passed

-0 :warning:
javac
1m 48s
root generated 2 new + 37 unchanged - 0 fixed = 39 total (was 37)

+1 :green_heart:
shadedjars
0m 24s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
9m 56s
the patch passed

_ Other Tests _

-1 :x:
unit
5m 47s
root in the patch failed.

45m 29s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4166/3/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4166

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 65afad2a19fd 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 0a7e49ca3b

Default Java
AdoptOpenJDK-1.8.0_282-b08

javac
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4166/3/artifact/yetus-jdk8-hadoop2-check/output/diff-compile-javac-root.txt

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4166/3/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-root.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4166/3/testReport/

Max. process+thread count
338 (vs. ulimit of 12500)

modules
C: hbase-logging hbase-protocol-shaded hbase-common hbase-metrics-api hbase-hadoop-compat hbase-metrics hbase-hadoop2-compat hbase-client hbase-zookeeper hbase-replication hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-rsgroup hbase-shell hbase-endpoint hbase-it hbase-rest hbase-examples hbase-shaded hbase-shaded/hbase-shaded-client hbase-shaded/hbase-shaded-client-byo-hadoop hbase-shaded/hbase-shaded-mapreduce hbase-hbtop hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-lz4 hbase-compression/hbase-compression-snappy hbase-compression/hbase-compression-xz hbase-compression/hbase-compression-zstd hbase-assembly hbase-shaded/hbase-shaded-testing-util hbase-shaded/hbase-shaded-testing-util-tester hbase-shaded/hbase-shaded-check-invariants hbase-shaded/hbase-shaded-with-hadoop-check-invariants hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4166/3/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 32s
Docker mode activated.

-0 :warning:
yetus
0m  5s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 21s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 43s
branch-2 passed

+1 :green_heart:
compile
2m 19s
branch-2 passed

+1 :green_heart:
shadedjars
4m  8s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
10m 40s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 19s
the patch passed

+1 :green_heart:
compile
2m  8s
the patch passed

-0 :warning:
javac
2m  8s
root generated 2 new + 37 unchanged - 0 fixed = 39 total (was 37)

+1 :green_heart:
shadedjars
0m 21s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
10m 53s
the patch passed

_ Other Tests _

-1 :x:
unit
6m 15s
root in the patch failed.

49m 53s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4166/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4166

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 7822b64b4d0c 5.4.0-96-generic #109-Ubuntu SMP Wed Jan 12 16:49:16 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 0a7e49ca3b

Default Java
AdoptOpenJDK-11.0.10+9

javac
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4166/3/artifact/yetus-jdk11-hadoop3-check/output/diff-compile-javac-root.txt

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4166/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4166/3/testReport/

Max. process+thread count
455 (vs. ulimit of 12500)

modules
C: hbase-logging hbase-protocol-shaded hbase-common hbase-metrics-api hbase-hadoop-compat hbase-metrics hbase-hadoop2-compat hbase-client hbase-zookeeper hbase-replication hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-rsgroup hbase-shell hbase-endpoint hbase-it hbase-rest hbase-examples hbase-shaded hbase-shaded/hbase-shaded-client hbase-shaded/hbase-shaded-client-byo-hadoop hbase-shaded/hbase-shaded-mapreduce hbase-hbtop hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-lz4 hbase-compression/hbase-compression-snappy hbase-compression/hbase-compression-xz hbase-compression/hbase-compression-zstd hbase-assembly hbase-shaded/hbase-shaded-testing-util hbase-shaded/hbase-shaded-testing-util-tester hbase-shaded/hbase-shaded-check-invariants hbase-shaded/hbase-shaded-with-hadoop-check-invariants hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4166/3/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 55s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+0 :ok:
shelldocs
0m  1s
Shelldocs was not available.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 27s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 15s
branch-2 passed

+1 :green_heart:
compile
6m 19s
branch-2 passed

+1 :green_heart:
checkstyle
1m  8s
branch-2 passed

+1 :green_heart:
spotbugs
17m 43s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m  4s
the patch passed

+1 :green_heart:
compile
6m 21s
the patch passed

+1 :green_heart:
javac
6m 21s
the patch passed

-0 :warning:
checkstyle
1m 10s
root: The patch generated 2 new + 233 unchanged - 4 fixed = 235 total (was 237)

+1 :green_heart:
shellcheck
0m  2s
There were no new shellcheck issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m 27s
The patch has no ill-formed XML file.

+1 :green_heart:
hadoopcheck
6m 39s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
21m 12s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
4m 29s
The patch does not generate ASF License warnings.

81m 58s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4166/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4166

Optional Tests
dupname asflicense shellcheck shelldocs javac hadoopcheck xml compile spotbugs hbaseanti checkstyle

uname
Linux 1dc0cb8f059c 5.4.0-1054-aws #57~18.04.1-Ubuntu SMP Thu Jul 15 03:21:36 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 0a7e49ca3b

Default Java
AdoptOpenJDK-1.8.0_282-b08

checkstyle
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4166/3/artifact/yetus-general-check/output/diff-checkstyle-root.txt

Max. process+thread count
87 (vs. ulimit of 12500)

modules
C: hbase-logging hbase-protocol-shaded hbase-common hbase-metrics-api hbase-hadoop-compat hbase-metrics hbase-hadoop2-compat hbase-client hbase-zookeeper hbase-replication hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-rsgroup hbase-shell hbase-endpoint hbase-it hbase-rest hbase-examples hbase-shaded hbase-shaded/hbase-shaded-client hbase-shaded/hbase-shaded-client-byo-hadoop hbase-shaded/hbase-shaded-mapreduce hbase-hbtop hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-lz4 hbase-compression/hbase-compression-snappy hbase-compression/hbase-compression-xz hbase-compression/hbase-compression-zstd hbase-assembly hbase-shaded/hbase-shaded-testing-util hbase-shaded/hbase-shaded-testing-util-tester hbase-shaded/hbase-shaded-check-invariants hbase-shaded/hbase-shaded-with-hadoop-check-invariants hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4166/3/console

versions
git=2.17.1 maven=3.6.3 shellcheck=0.4.6 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 51s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+0 :ok:
shelldocs
0m  1s
Shelldocs was not available.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 13s
branch-2 passed

+1 :green_heart:
compile
6m 16s
branch-2 passed

+1 :green_heart:
checkstyle
1m 11s
branch-2 passed

+1 :green_heart:
spotbugs
17m 29s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m  7s
the patch passed

+1 :green_heart:
compile
6m 20s
the patch passed

+1 :green_heart:
javac
6m 20s
the patch passed

-0 :warning:
checkstyle
1m  9s
root: The patch generated 2 new + 233 unchanged - 4 fixed = 235 total (was 237)

+1 :green_heart:
shellcheck
0m  1s
There were no new shellcheck issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m 27s
The patch has no ill-formed XML file.

+1 :green_heart:
hadoopcheck
6m 37s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
21m 23s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
4m 27s
The patch does not generate ASF License warnings.

81m 26s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4166/4/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4166

Optional Tests
dupname asflicense shellcheck shelldocs javac hadoopcheck xml compile spotbugs hbaseanti checkstyle

uname
Linux 228484ea67bc 5.4.0-1054-aws #57~18.04.1-Ubuntu SMP Thu Jul 15 03:21:36 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 0a7e49ca3b

Default Java
AdoptOpenJDK-1.8.0_282-b08

checkstyle
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4166/4/artifact/yetus-general-check/output/diff-checkstyle-root.txt

Max. process+thread count
87 (vs. ulimit of 12500)

modules
C: hbase-logging hbase-protocol-shaded hbase-common hbase-metrics-api hbase-hadoop-compat hbase-metrics hbase-hadoop2-compat hbase-client hbase-zookeeper hbase-replication hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-rsgroup hbase-shell hbase-endpoint hbase-it hbase-rest hbase-examples hbase-shaded hbase-shaded/hbase-shaded-client hbase-shaded/hbase-shaded-client-byo-hadoop hbase-shaded/hbase-shaded-mapreduce hbase-hbtop hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-lz4 hbase-compression/hbase-compression-snappy hbase-compression/hbase-compression-xz hbase-compression/hbase-compression-zstd hbase-assembly hbase-shaded/hbase-shaded-testing-util hbase-shaded/hbase-shaded-testing-util-tester hbase-shaded/hbase-shaded-check-invariants hbase-shaded/hbase-shaded-with-hadoop-check-invariants hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4166/4/console

versions
git=2.17.1 maven=3.6.3 shellcheck=0.4.6 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 52s
Docker mode activated.

-0 :warning:
yetus
0m  6s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 24s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 53s
branch-2 passed

+1 :green_heart:
compile
2m  4s
branch-2 passed

+1 :green_heart:
shadedjars
3m 40s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
10m 22s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 35s
the patch passed

+1 :green_heart:
compile
2m  7s
the patch passed

-0 :warning:
javac
2m  7s
root generated 2 new + 37 unchanged - 0 fixed = 39 total (was 37)

+1 :green_heart:
shadedjars
0m 20s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
10m 17s
the patch passed

_ Other Tests _

-1 :x:
unit
432m 56s
root in the patch failed.

475m 47s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4166/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4166

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux eec6e215c87f 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 0a7e49ca3b

Default Java
AdoptOpenJDK-11.0.10+9

javac
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4166/4/artifact/yetus-jdk11-hadoop3-check/output/diff-compile-javac-root.txt

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4166/4/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4166/4/testReport/

Max. process+thread count
2447 (vs. ulimit of 12500)

modules
C: hbase-logging hbase-protocol-shaded hbase-common hbase-metrics-api hbase-hadoop-compat hbase-metrics hbase-hadoop2-compat hbase-client hbase-zookeeper hbase-replication hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-rsgroup hbase-shell hbase-endpoint hbase-it hbase-rest hbase-examples hbase-shaded hbase-shaded/hbase-shaded-client hbase-shaded/hbase-shaded-client-byo-hadoop hbase-shaded/hbase-shaded-mapreduce hbase-hbtop hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-lz4 hbase-compression/hbase-compression-snappy hbase-compression/hbase-compression-xz hbase-compression/hbase-compression-zstd hbase-assembly hbase-shaded/hbase-shaded-testing-util hbase-shaded/hbase-shaded-testing-util-tester hbase-shaded/hbase-shaded-check-invariants hbase-shaded/hbase-shaded-with-hadoop-check-invariants hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4166/4/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 54s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+0 :ok:
shelldocs
0m  1s
Shelldocs was not available.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 27s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 15s
branch-2 passed

+1 :green_heart:
compile
6m 13s
branch-2 passed

+1 :green_heart:
checkstyle
1m 10s
branch-2 passed

+1 :green_heart:
spotbugs
17m 40s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m  2s
the patch passed

+1 :green_heart:
compile
6m 20s
the patch passed

+1 :green_heart:
javac
6m 20s
the patch passed

-0 :warning:
checkstyle
1m  8s
root: The patch generated 2 new + 233 unchanged - 4 fixed = 235 total (was 237)

+1 :green_heart:
shellcheck
0m  2s
There were no new shellcheck issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m 27s
The patch has no ill-formed XML file.

+1 :green_heart:
hadoopcheck
6m 37s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
21m  8s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
4m 28s
The patch does not generate ASF License warnings.

81m 32s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4166/5/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4166

Optional Tests
dupname asflicense shellcheck shelldocs javac hadoopcheck xml compile spotbugs hbaseanti checkstyle

uname
Linux b1b3ddd1e3a1 5.4.0-1054-aws #57~18.04.1-Ubuntu SMP Thu Jul 15 03:21:36 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 0a7e49ca3b

Default Java
AdoptOpenJDK-1.8.0_282-b08

checkstyle
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4166/5/artifact/yetus-general-check/output/diff-checkstyle-root.txt

Max. process+thread count
87 (vs. ulimit of 12500)

modules
C: hbase-logging hbase-protocol-shaded hbase-common hbase-metrics-api hbase-hadoop-compat hbase-metrics hbase-hadoop2-compat hbase-client hbase-zookeeper hbase-replication hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-rsgroup hbase-shell hbase-endpoint hbase-it hbase-rest hbase-examples hbase-shaded hbase-shaded/hbase-shaded-client hbase-shaded/hbase-shaded-client-byo-hadoop hbase-shaded/hbase-shaded-mapreduce hbase-hbtop hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-lz4 hbase-compression/hbase-compression-snappy hbase-compression/hbase-compression-xz hbase-compression/hbase-compression-zstd hbase-assembly hbase-shaded/hbase-shaded-testing-util hbase-shaded/hbase-shaded-testing-util-tester hbase-shaded/hbase-shaded-check-invariants hbase-shaded/hbase-shaded-with-hadoop-check-invariants hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4166/5/console

versions
git=2.17.1 maven=3.6.3 shellcheck=0.4.6 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 40s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+0 :ok:
shelldocs
0m  1s
Shelldocs was not available.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 22s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 31s
branch-2 passed

+1 :green_heart:
compile
7m 56s
branch-2 passed

+1 :green_heart:
checkstyle
1m 41s
branch-2 passed

+1 :green_heart:
spotbugs
22m 45s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 54s
the patch passed

+1 :green_heart:
compile
8m 16s
the patch passed

+1 :green_heart:
javac
8m 16s
the patch passed

-0 :warning:
checkstyle
1m 29s
root: The patch generated 2 new + 233 unchanged - 4 fixed = 235 total (was 237)

+1 :green_heart:
shellcheck
0m  2s
There were no new shellcheck issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m 35s
The patch has no ill-formed XML file.

+1 :green_heart:
hadoopcheck
8m  5s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
27m  8s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
5m 18s
The patch does not generate ASF License warnings.

104m 49s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4166/6/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4166

Optional Tests
dupname asflicense shellcheck shelldocs javac hadoopcheck xml compile spotbugs hbaseanti checkstyle

uname
Linux a0bb7a398562 5.4.0-1047-aws #49~18.04.1-Ubuntu SMP Wed Apr 28 23:08:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / f4c91ee65b

Default Java
AdoptOpenJDK-1.8.0_282-b08

checkstyle
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4166/6/artifact/yetus-general-check/output/diff-checkstyle-root.txt

Max. process+thread count
87 (vs. ulimit of 12500)

modules
C: hbase-logging hbase-protocol-shaded hbase-common hbase-metrics-api hbase-hadoop-compat hbase-metrics hbase-hadoop2-compat hbase-client hbase-zookeeper hbase-replication hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-rsgroup hbase-shell hbase-endpoint hbase-it hbase-rest hbase-examples hbase-shaded hbase-shaded/hbase-shaded-client hbase-shaded/hbase-shaded-client-byo-hadoop hbase-shaded/hbase-shaded-mapreduce hbase-hbtop hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-lz4 hbase-compression/hbase-compression-snappy hbase-compression/hbase-compression-xz hbase-compression/hbase-compression-zstd hbase-assembly hbase-shaded/hbase-shaded-testing-util hbase-shaded/hbase-shaded-testing-util-tester hbase-shaded/hbase-shaded-check-invariants hbase-shaded/hbase-shaded-with-hadoop-check-invariants hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4166/6/console

versions
git=2.17.1 maven=3.6.3 shellcheck=0.4.6 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Let me try to execute the UTs locally to see what is the problem.
Seems we always hit the timeout.

The changes lgtm, good to commit once the test issues are analyzed and resolved.

Thanks @apurtell  for the detailed review.
Let me address the problems.

Running locally, we hang forever when running TestThriftServerCmdLine. Not sure why it did not timeout.
Will dig more and report back later.

Oh, it is just a bind error, tried another round it passed...

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 49s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+0 :ok:
shelldocs
0m  1s
Shelldocs was not available.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 43s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 24s
branch-2 passed

+1 :green_heart:
compile
6m 18s
branch-2 passed

+1 :green_heart:
checkstyle
1m  9s
branch-2 passed

-1 :x:
spotbugs
1m  9s
hbase-server in branch-2 has 1 extant spotbugs warnings.

-1 :x:
spotbugs
6m  9s
root in branch-2 has 1 extant spotbugs warnings.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m  4s
the patch passed

+1 :green_heart:
compile
6m 18s
the patch passed

+1 :green_heart:
javac
6m 18s
the patch passed

-0 :warning:
checkstyle
1m 10s
root: The patch generated 2 new + 233 unchanged - 4 fixed = 235 total (was 237)

+1 :green_heart:
shellcheck
0m  1s
There were no new shellcheck issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m 27s
The patch has no ill-formed XML file.

+1 :green_heart:
hadoopcheck
6m 40s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
21m  8s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
4m 27s
The patch does not generate ASF License warnings.

82m  2s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4166/7/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4166

Optional Tests
dupname asflicense shellcheck shelldocs javac hadoopcheck xml compile spotbugs hbaseanti checkstyle

uname
Linux 801a9740ec33 5.4.0-1054-aws #57~18.04.1-Ubuntu SMP Thu Jul 15 03:21:36 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 8a4317838b

Default Java
AdoptOpenJDK-1.8.0_282-b08

spotbugs
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4166/7/artifact/yetus-general-check/output/branch-spotbugs-hbase-server-warnings.html

spotbugs
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4166/7/artifact/yetus-general-check/output/branch-spotbugs-root-warnings.html

checkstyle
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4166/7/artifact/yetus-general-check/output/diff-checkstyle-root.txt

Max. process+thread count
87 (vs. ulimit of 12500)

modules
C: hbase-logging hbase-protocol-shaded hbase-common hbase-metrics-api hbase-hadoop-compat hbase-metrics hbase-hadoop2-compat hbase-client hbase-zookeeper hbase-replication hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-rsgroup hbase-shell hbase-endpoint hbase-it hbase-rest hbase-examples hbase-shaded hbase-shaded/hbase-shaded-client hbase-shaded/hbase-shaded-client-byo-hadoop hbase-shaded/hbase-shaded-mapreduce hbase-hbtop hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-lz4 hbase-compression/hbase-compression-snappy hbase-compression/hbase-compression-xz hbase-compression/hbase-compression-zstd hbase-assembly hbase-shaded/hbase-shaded-testing-util hbase-shaded/hbase-shaded-testing-util-tester hbase-shaded/hbase-shaded-check-invariants hbase-shaded/hbase-shaded-with-hadoop-check-invariants hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4166/7/console

versions
git=2.17.1 maven=3.6.3 shellcheck=0.4.6 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 40s
Docker mode activated.

-0 :warning:
yetus
0m  5s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 38s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
6m 11s
branch-2 passed

+1 :green_heart:
compile
4m 32s
branch-2 passed

+1 :green_heart:
shadedjars
6m 19s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
18m 51s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 23s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 55s
the patch passed

+1 :green_heart:
compile
4m 19s
the patch passed

-0 :warning:
javac
4m 19s
root generated 2 new + 37 unchanged - 0 fixed = 39 total (was 37)

+1 :green_heart:
shadedjars
0m 38s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
20m 37s
the patch passed

_ Other Tests _

-1 :x:
unit
473m 24s
root in the patch failed.

551m 18s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4166/7/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4166

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 65cf47540b10 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 8a4317838b

Default Java
AdoptOpenJDK-11.0.10+9

javac
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4166/7/artifact/yetus-jdk11-hadoop3-check/output/diff-compile-javac-root.txt

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4166/7/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4166/7/testReport/

Max. process+thread count
2067 (vs. ulimit of 12500)

modules
C: hbase-logging hbase-protocol-shaded hbase-common hbase-metrics-api hbase-hadoop-compat hbase-metrics hbase-hadoop2-compat hbase-client hbase-zookeeper hbase-replication hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-rsgroup hbase-shell hbase-endpoint hbase-it hbase-rest hbase-examples hbase-shaded hbase-shaded/hbase-shaded-client hbase-shaded/hbase-shaded-client-byo-hadoop hbase-shaded/hbase-shaded-mapreduce hbase-hbtop hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-lz4 hbase-compression/hbase-compression-snappy hbase-compression/hbase-compression-xz hbase-compression/hbase-compression-zstd hbase-assembly hbase-shaded/hbase-shaded-testing-util hbase-shaded/hbase-shaded-testing-util-tester hbase-shaded/hbase-shaded-check-invariants hbase-shaded/hbase-shaded-with-hadoop-check-invariants hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4166/7/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  3s
Docker mode activated.

-0 :warning:
yetus
0m  5s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 52s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m  5s
branch-2 passed

+1 :green_heart:
compile
1m 46s
branch-2 passed

+1 :green_heart:
shadedjars
4m  1s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
8m 55s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 34s
the patch passed

+1 :green_heart:
compile
1m 56s
the patch passed

-0 :warning:
javac
1m 56s
root generated 2 new + 37 unchanged - 0 fixed = 39 total (was 37)

+1 :green_heart:
shadedjars
0m 24s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
1m 47s
root generated 1 new + 58 unchanged - 1 fixed = 59 total (was 59)

_ Other Tests _

-1 :x:
unit
538m 48s
root in the patch failed.

577m 53s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4166/7/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4166

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 9a43a367d2e1 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 8a4317838b

Default Java
AdoptOpenJDK-1.8.0_282-b08

javac
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4166/7/artifact/yetus-jdk8-hadoop2-check/output/diff-compile-javac-root.txt

javadoc
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4166/7/artifact/yetus-jdk8-hadoop2-check/output/diff-javadoc-javadoc-root.txt

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4166/7/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-root.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4166/7/testReport/

Max. process+thread count
1833 (vs. ulimit of 12500)

modules
C: hbase-logging hbase-protocol-shaded hbase-common hbase-metrics-api hbase-hadoop-compat hbase-metrics hbase-hadoop2-compat hbase-client hbase-zookeeper hbase-replication hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-rsgroup hbase-shell hbase-endpoint hbase-it hbase-rest hbase-examples hbase-shaded hbase-shaded/hbase-shaded-client hbase-shaded/hbase-shaded-client-byo-hadoop hbase-shaded/hbase-shaded-mapreduce hbase-hbtop hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-lz4 hbase-compression/hbase-compression-snappy hbase-compression/hbase-compression-xz hbase-compression/hbase-compression-zstd hbase-assembly hbase-shaded/hbase-shaded-testing-util hbase-shaded/hbase-shaded-testing-util-tester hbase-shaded/hbase-shaded-check-invariants hbase-shaded/hbase-shaded-with-hadoop-check-invariants hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4166/7/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 57s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+0 :ok:
shelldocs
0m  1s
Shelldocs was not available.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 26s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 13s
branch-2 passed

+1 :green_heart:
compile
6m 20s
branch-2 passed

+1 :green_heart:
checkstyle
1m  7s
branch-2 passed

+1 :green_heart:
spotbugs
17m 36s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m  3s
the patch passed

+1 :green_heart:
compile
6m 22s
the patch passed

+1 :green_heart:
javac
6m 22s
the patch passed

-0 :warning:
checkstyle
1m 10s
root: The patch generated 2 new + 233 unchanged - 4 fixed = 235 total (was 237)

+1 :green_heart:
shellcheck
0m  0s
There were no new shellcheck issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m 27s
The patch has no ill-formed XML file.

+1 :green_heart:
hadoopcheck
6m 37s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
21m  9s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
4m 30s
The patch does not generate ASF License warnings.

81m 58s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4166/9/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4166

Optional Tests
dupname asflicense shellcheck shelldocs javac hadoopcheck xml compile spotbugs hbaseanti checkstyle

uname
Linux 2208d8c6fdd3 5.4.0-1054-aws #57~18.04.1-Ubuntu SMP Thu Jul 15 03:21:36 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / e46fbedf56

Default Java
AdoptOpenJDK-1.8.0_282-b08

checkstyle
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4166/9/artifact/yetus-general-check/output/diff-checkstyle-root.txt

Max. process+thread count
87 (vs. ulimit of 12500)

modules
C: hbase-logging hbase-protocol-shaded hbase-common hbase-metrics-api hbase-hadoop-compat hbase-metrics hbase-hadoop2-compat hbase-client hbase-zookeeper hbase-replication hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-rsgroup hbase-shell hbase-endpoint hbase-it hbase-rest hbase-examples hbase-shaded hbase-shaded/hbase-shaded-client hbase-shaded/hbase-shaded-client-byo-hadoop hbase-shaded/hbase-shaded-mapreduce hbase-hbtop hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-lz4 hbase-compression/hbase-compression-snappy hbase-compression/hbase-compression-xz hbase-compression/hbase-compression-zstd hbase-assembly hbase-shaded/hbase-shaded-testing-util hbase-shaded/hbase-shaded-testing-util-tester hbase-shaded/hbase-shaded-check-invariants hbase-shaded/hbase-shaded-with-hadoop-check-invariants hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4166/9/console

versions
git=2.17.1 maven=3.6.3 shellcheck=0.4.6 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 30s
Docker mode activated.

-0 :warning:
yetus
0m  4s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 23s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 39s
branch-2 passed

+1 :green_heart:
compile
3m  7s
branch-2 passed

+1 :green_heart:
shadedjars
4m 36s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
12m 11s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m  3s
the patch passed

+1 :green_heart:
compile
2m 27s
the patch passed

-0 :warning:
javac
2m 27s
root generated 2 new + 37 unchanged - 0 fixed = 39 total (was 37)

+1 :green_heart:
shadedjars
0m 24s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
11m 19s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
431m 29s
root in the patch passed.

482m 14s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4166/9/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4166

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 425389eb2554 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / e46fbedf56

Default Java
AdoptOpenJDK-11.0.10+9

javac
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4166/9/artifact/yetus-jdk11-hadoop3-check/output/diff-compile-javac-root.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4166/9/testReport/

Max. process+thread count
2212 (vs. ulimit of 12500)

modules
C: hbase-logging hbase-protocol-shaded hbase-common hbase-metrics-api hbase-hadoop-compat hbase-metrics hbase-hadoop2-compat hbase-client hbase-zookeeper hbase-replication hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-rsgroup hbase-shell hbase-endpoint hbase-it hbase-rest hbase-examples hbase-shaded hbase-shaded/hbase-shaded-client hbase-shaded/hbase-shaded-client-byo-hadoop hbase-shaded/hbase-shaded-mapreduce hbase-hbtop hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-lz4 hbase-compression/hbase-compression-snappy hbase-compression/hbase-compression-xz hbase-compression/hbase-compression-zstd hbase-assembly hbase-shaded/hbase-shaded-testing-util hbase-shaded/hbase-shaded-testing-util-tester hbase-shaded/hbase-shaded-check-invariants hbase-shaded/hbase-shaded-with-hadoop-check-invariants hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4166/9/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


Disable cookie for static file

Fix: https://github.com/casdoor/casdoor/issues/1654

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.chenjpu seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

@chenjpu this PR has broken all the static paths:
https://github.com/casdoor/casdoor/blob/dd939b5c7e675938d752ec6b6aa9a34e5605d009/main.go#L55-L56
As an example, the Swagger docs doesn't work any more: https://door.casdoor.com/swagger

It should be something like:

This PR will be reverted.


Build successful but no OpenFaceCpp binary created under Linux

I'm trying to compile OpenFaceCpp on Linux virtual machine (No CUDA support). Problem is that after compilation I do not have any OpenFaceCpp binary in build directory but on Windows I have OpenFaceCpp.exe
My configuration:
OS: Ubuntu 18.04.1 LTS
G++: 7.3.0-16ubuntu3
Here are steps I've done to compile, basically everything worked according to README.md but I have to change -std=gnu++11 to -std=gnu++14 and fix one typo (sed commands):
marek@lubuntu18-64:~$ git clone https://github.com/aybassiouny/OpenFaceCpp.git
marek@lubuntu18-64:~$ cd OpenFaceCpp
marek@lubuntu18-64:~/OpenFaceCpp$ git submodule update --init
Submodule 'Lib/dlib-18.18' (https://github.com/davisking/dlib.git) registered for path 'Lib/dlib-18.18'
Submodule 'Lib/tinyxml2' (https://github.com/leethomason/tinyxml2) registered for path 'Lib/tinyxml2'
Cloning into '/home/marek/OpenFaceCpp/Lib/dlib-18.18'...
Cloning into '/home/marek/OpenFaceCpp/Lib/tinyxml2'...
Submodule path 'Lib/dlib-18.18': checked out '021cbbb1c2ddec39d8dd4cb6abfbbafdf1cf4482'
Submodule path 'Lib/tinyxml2': checked out '584af570860b8d7aa0a8105fb79ef9e8492b8aaa'

marek@lubuntu18-64:~/OpenFaceCpp$ git log -1
commit 9f0048906e6c1984c1bef5e0addbb9a0898f3cbd (HEAD -> master, origin/master, origin/HEAD)
Author: Ahmed Bassiouny<EMAIL_ADDRESS>Date:   Mon Aug 6 09:41:19 2018 -0700

    Add torch installation Readme

    Add details how I got torch to work on my machine, should work everywhere. Next steps should be to have a docker.

marek@lubuntu18-64:~/OpenFaceCpp$ mkdir build
marek@lubuntu18-64:~/OpenFaceCpp$ cd build
marek@lubuntu18-64:~/OpenFaceCpp/build$ cmake ..

-- Configuring done
CMake Warning (dev) at Lib/tinyxml2/CMakeLists.txt:106 (add_executable):
  Policy CMP0063 is not set: Honor visibility properties for all target
  types.  Run "cmake --help-policy CMP0063" for policy details.  Use the
  cmake_policy command to set the policy and suppress this warning.

  Target "xmltest" of type "EXECUTABLE" has the following visibility
  properties set for CXX:

    CXX_VISIBILITY_PRESET
    VISIBILITY_INLINES_HIDDEN

  For compatibility CMake is not honoring them for this target.
This warning is for project developers.  Use -Wno-dev to suppress it.

-- Generating done
-- Build files have been written to: /home/marek/OpenFaceCpp/build

marek@lubuntu18-64:~/OpenFaceCpp/build$ cmake --build .
[ 87%] Building CXX object CMakeFiles/OpenFaceCpp.dir/src/TorchWrap.cpp.o
/home/marek/OpenFaceCpp/src/TorchWrap.cpp:47:1: error: ‘tempalte’ does not name a type; did you mean ‘tempnam’?
 tempalte<typename Child>
 ^~~~~~~~

marek@lubuntu18-64:~/OpenFaceCpp/build$ sed -i 's/tempalte/template/' ../src/TorchWrap.cpp
marek@lubuntu18-64:~/OpenFaceCpp/build$ cmake --build .
[ 87%] Building CXX object CMakeFiles/OpenFaceCpp.dir/src/TorchWrap.cpp.o
/home/marek/OpenFaceCpp/src/TorchWrap.cpp: In constructor ‘OpenFaceCpp::TorchWrap::Executer::Executer(const string&, int)’:
/home/marek/OpenFaceCpp/src/TorchWrap.cpp:88:17: error: ‘make_unique’ is not a member of ‘std’
  m_child = std::make_unique<boost::process::child>(

marek@lubuntu18-64:~/OpenFaceCpp/build$ sed -i 's/gnu++11/gnu++14/' dlib_build/CMakeFiles/dlib.dir/flags.make
marek@lubuntu18-64:~/OpenFaceCpp/build$ sed -i 's/gnu++11/gnu++14/' CMakeFiles/OpenFaceCpp.dir/flags.make
marek@lubuntu18-64:~/OpenFaceCpp/build$ cmake --build .

-- [hunter] Calculating Toolchain-SHA1
-- [hunter] Calculating Config-SHA1
-- [hunter] HUNTER_ROOT: /home/marek/.hunter
-- [hunter] [ Hunter-ID: 4c50cfb | Toolchain-ID: 5930f74 | Config-ID: d35ceea ]
-- [hunter] OPENCV_ROOT: /home/marek/.hunter/_Base/4c50cfb/5930f74/d35ceea/Install (ver.: 3.4.1-p1)
-- [hunter] BOOST_ROOT: /home/marek/.hunter/_Base/4c50cfb/5930f74/d35ceea/Install (ver.: 1.67.0-p1)
-- [hunter] BOOST_ROOT: /home/marek/.hunter/_Base/4c50cfb/5930f74/d35ceea/Install (ver.: 1.67.0-p1)
-- [hunter] BOOST_ROOT: /home/marek/.hunter/_Base/4c50cfb/5930f74/d35ceea/Install (ver.: 1.67.0-p1)
-- [hunter] BOOSTPROCESS_ROOT: /home/marek/.hunter/_Base/4c50cfb/5930f74/d35ceea/Install (ver.: 0.5)
-- [hunter] PNG_ROOT: /home/marek/.hunter/_Base/4c50cfb/5930f74/d35ceea/Install (ver.: 1.6.26-p3)
Boost  found.
Found Boost components:
   system;regex
-- Boost version: 1.67.0
-- Found the following Boost libraries:
--   system
--   filesystem
--   iostreams
CMake Warning (dev) at /usr/share/cmake-3.10/Modules/CheckSymbolExists.cmake:57 (if):
  Policy CMP0054 is not set: Only interpret if() arguments as variables or
  keywords when unquoted.  Run "cmake --help-policy CMP0054" for policy
  details.  Use the cmake_policy command to set the policy and suppress this
  warning.

  Quoted variables like "x" will no longer be dereferenced when the policy is
  set to NEW.  Since the policy is not set the OLD behavior will be used.
Call Stack (most recent call first):
  /usr/share/cmake-3.10/Modules/CheckSymbolExists.cmake:48 (__CHECK_SYMBOL_EXISTS_IMPL)
  /usr/share/cmake-3.10/Modules/FindThreads.cmake:134 (CHECK_SYMBOL_EXISTS)
  Lib/dlib-18.18/dlib/CMakeLists.txt:262 (find_package)
This warning is for project developers.  Use -Wno-dev to suppress it.

-- Searching for BLAS and LAPACK
-- Searching for BLAS and LAPACK
-- Checking for module 'cblas'
--   No package 'cblas' found
-- Checking for module 'lapack'
--   No package 'lapack' found
-- Found LAPACK library
-- Found BLAS library
CMake Warning (dev) at /usr/share/cmake-3.10/Modules/CheckFunctionExists.cmake:42 (if):
  Policy CMP0054 is not set: Only interpret if() arguments as variables or
  keywords when unquoted.  Run "cmake --help-policy CMP0054" for policy
  details.  Use the cmake_policy command to set the policy and suppress this
  warning.

  Quoted variables like "x" will no longer be dereferenced when the policy is
  set to NEW.  Since the policy is not set the OLD behavior will be used.
Call Stack (most recent call first):
  Lib/dlib-18.18/dlib/cmake_utils/find_blas.cmake:357 (check_function_exists)
  Lib/dlib-18.18/dlib/CMakeLists.txt:515 (include)
This warning is for project developers.  Use -Wno-dev to suppress it.

-- C++11 activated.
-- Configuring done
CMake Warning (dev) at Lib/tinyxml2/CMakeLists.txt:106 (add_executable):
  Policy CMP0063 is not set: Honor visibility properties for all target
  types.  Run "cmake --help-policy CMP0063" for policy details.  Use the
  cmake_policy command to set the policy and suppress this warning.

  Target "xmltest" of type "EXECUTABLE" has the following visibility
  properties set for CXX:

    CXX_VISIBILITY_PRESET
    VISIBILITY_INLINES_HIDDEN

  For compatibility CMake is not honoring them for this target.
This warning is for project developers.  Use -Wno-dev to suppress it.

-- Generating done
-- Build files have been written to: /home/marek/OpenFaceCpp/build

marek@lubuntu18-64:~/OpenFaceCpp/build$ ls -la
total 88
drwxrwxr-x 6 marek marek  4096 sep 11 01:14 .
drwxrwxr-x 8 marek marek  4096 sep 11 01:01 ..
drwxrwxr-x 3 marek marek  4096 sep 11 01:14 _3rdParty
-rw-rw-r-- 1 marek marek 46758 sep 11 01:14 CMakeCache.txt
drwxrwxr-x 7 marek marek  4096 sep 11 01:42 CMakeFiles
-rw-rw-r-- 1 marek marek  1752 sep 11 01:14 cmake_install.cmake
drwxrwxr-x 3 marek marek  4096 sep 11 01:46 dlib_build
drwxrwxr-x 3 marek marek  4096 sep 11 01:14 Lib
-rw-rw-r-- 1 marek marek 10713 sep 11 01:14 Makefile

I do not know if this matters bit when I try to run make (instead of cmake -build .) inside build dir I get those errors:
marek@lubuntu18-64:~/OpenFaceCpp/build$ make
[  2%] Built target tinyxml2
[ 85%] Built target dlib
[ 87%] Building CXX object CMakeFiles/OpenFaceCpp.dir/src/TorchWrap.cpp.o
/home/marek/OpenFaceCpp/src/TorchWrap.cpp: In constructor ‘OpenFaceCpp::TorchWrap::Executer::Executer(const string&, int)’:
/home/marek/OpenFaceCpp/src/TorchWrap.cpp:91:18: error: ‘on_CreateProcess_setup’ is not a member of ‘boost::process::initializers’
    initializers::on_CreateProcess_setup([this](executor &e)
                  ^~~~~~~~~~~~~~~~~~~~~~
/home/marek/OpenFaceCpp/src/TorchWrap.cpp: In lambda function:
/home/marek/OpenFaceCpp/src/TorchWrap.cpp:94:42: error: ‘class boost::process::posix::initializers::bind_stdout’ has no member named ‘on_CreateProcess_setup’; did you mean ‘on_exec_setup’?
   initializers::bind_stdout(m_childSink).on_CreateProcess_setup(e);
                                          ^~~~~~~~~~~~~~~~~~~~~~
                                          on_exec_setup
/home/marek/OpenFaceCpp/src/TorchWrap.cpp:95:43: error: ‘class boost::process::posix::initializers::bind_stdin’ has no member named ‘on_CreateProcess_setup’; did you mean  on_exec_setup’?
   initializers::bind_stdin(m_childSource).on_CreateProcess_setup(e);
                                           ^~~~~~~~~~~~~~~~~~~~~~
                                           on_exec_setup
/home/marek/OpenFaceCpp/src/TorchWrap.cpp:96:17: error: ‘show_window’ is not a member of ‘boost::process::initializers’
   initializers::show_window(SW_NORMAL).on_CreateProcess_setup(e);
                 ^~~~~~~~~~~
/home/marek/OpenFaceCpp/src/TorchWrap.cpp:96:29: error: ‘SW_NORMAL’ was not declared in this scope
   initializers::show_window(SW_NORMAL).on_CreateProcess_setup(e);
                             ^~~~~~~~~
/home/marek/OpenFaceCpp/src/TorchWrap.cpp:96:29: note: suggested alternative: ‘FP_NORMAL’
   initializers::show_window(SW_NORMAL).on_CreateProcess_setup(e);
                             ^~~~~~~~~
                             FP_NORMAL
/home/marek/OpenFaceCpp/src/TorchWrap.cpp: In constructor ‘OpenFaceCpp::TorchWrap::Executer::Executer(const string&, int)’:
/home/marek/OpenFaceCpp/src/TorchWrap.cpp:98:18: error: ‘on_CreateProcess_error’ is not a member of ‘boost::process::initializers’
    initializers::on_CreateProcess_error([](executor&)
                  ^~~~~~~~~~~~~~~~~~~~~~
/home/marek/OpenFaceCpp/src/TorchWrap.cpp: In lambda function:
/home/marek/OpenFaceCpp/src/TorchWrap.cpp:100:16: error: ‘GetLastError’ was not declared in this scope
   std::cout << GetLastError() << std::endl; })
                ^~~~~~~~~~~~
/home/marek/OpenFaceCpp/src/TorchWrap.cpp:100:16: note: suggested alternative: ‘CV_StsError’
   std::cout << GetLastError() << std::endl; })
                ^~~~~~~~~~~~
                CV_StsError
CMakeFiles/OpenFaceCpp.dir/build.make:110: recipe for target 'CMakeFiles/OpenFaceCpp.dir/src/TorchWrap.cpp.o' failed
make[2]: *** [CMakeFiles/OpenFaceCpp.dir/src/TorchWrap.cpp.o] Error 1
CMakeFiles/Makefile2:68: recipe for target 'CMakeFiles/OpenFaceCpp.dir/all' failed
make[1]: *** [CMakeFiles/OpenFaceCpp.dir/all] Error 2
Makefile:129: recipe for target 'all' failed
make: *** [all] Error 2

Thanks

Hey, I indeed have been lately developing for windows instead of linux. I can't promise how soon I can provide such support. Would be nice if you can try and resolve the compile errors and make a pull request if you have the time.

I got the same errors on RaspberryPi. I guess it may be problem with deprecated GCC compiler ( similar issue ) but I can't figure out how to upgrade gcc on RaspberryPi to one that supports C++14.
Also, at line 47 in TorchWrap.cpp there is a typo: tempalte instead of template, which may cause some compilation errors.

I got similar errors when running "cmake -build ." on Raspbian. After changing on_createProcess_setup to on_exec_setup, GetLastError() to some temporary string "Error" and commenting out initializers::show_window(SW_NORMAL).on_CreateProcess_setup(e), the code somehow compiles, but this is temporary and unprofessional. I don't know what "show_window" does, but I couldn't find any replacement for Linux. Error handling is to be corrected as well.
Thing is, the code compiles, but does it compile correctly? I got no run_tests.cpp but I don't know whether it is somehow connected.
Should I run install.sh at all? When I try to, I got another errors connected with "make_unique", but adding -std=gnu++14 flag to the file won't work.

Any resolution for this issue?


New version: MySQL v0.7.1

Registering package: MySQL
Repository: https://github.com/JuliaDatabases/MySQL.jl
Created by: @quinnj
Version: v0.7.1
Commit: 61fae10ab801554578bb422b775872b7f08bbae8
Reviewed by: @quinnj
Reference: https://github.com/JuliaDatabases/MySQL.jl/commit/61fae10ab801554578bb422b775872b7f08bbae8#commitcomment-35679458

Your new version pull request does not meet all of the guidelines for automatic merging.
Specifically, your pull request does not meet the following guidelines:

The following dependencies do not have a compat entry that has an upper bound: BinaryProvider, DecFP, Tables, julia
A patch release is not allowed to narrow the supported range of Julia versions

If you want to prevent this pull request from being auto-merged, simply leave a comment.
(If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment.)

It is important to note that if your pull request does not meet the guidelines for automatic merging, this does not mean that your pull request will never be merged. It just means that your pull request will require manual review by a human.

These guidelines are intended not as requirements for packages but as very conservative guidelines, which, if your new package or new version of a package meets them, it may be automatically merged.

On a separate note, I see that you are registering a release with a version number of the form v0.X.Y.
Does your package have a stable public API? If so, then it's time for you to register version v1.0.0 of your package. (This is not a requirement. It's just a recommendation.)
If your package does not yet have a stable public API, then of course you are not yet ready to release version v1.0.0.

[noblock]

Please fix the compatibility bounds for the next release such that it will be automatically merged.


Use with tailwind

How can I apply Tailwind classes on the icon? In the previous version (0.3.x), I could do something like this:
<Icon icon={icondata::FaCalendarDaysSolid} class="w-4 h-4 text-gray-600" />

But this doesn't work anymore since class is not exposed.

How can I apply Tailwind classes on the icon? In the previous version (0.3.x), I could do something like this:
<Icon icon={icondata::FaCalendarDaysSolid} class="w-4 h-4 text-gray-600" />

But this doesn't work anymore since class is not exposed.

It's no longer necessary to include a class prop in 0.7. Use spreading instead:
<Icon icon={icondata::FaCalendarDaysSolid} {..} class="w-4 h-4 text-gray-600" />

@ozpv's answer is correct, thus I will close this issue.


AGSGeometry Support

Hi, Would be huge feature if Esri Arcgis IOS SDK supported.
Cannot use geometry in arcgis, as it requires a different format as AGSGeometry.

@ozcan-durak we have just split the Mapbox integration into it's own pod. If you still uses ArcGIS SDK, it should be easy for you to create a pod that supports it, based on the Mapbox one
https://github.com/GEOSwift/GEOSwiftMapboxGL

Closing this due to inactivity.
Sent with GitHawk


How to install? How to use?

Sorry, I haven't touched this in a couple of years. I've mainly left it out there just for history. I'm guessing things have changed a lot with the Idris baseline and this is no longer compatible with it.


add web app to sasjs deploy command console output

Currently when doing a sasjs deploy we get a URL like below:

It would be a great user experience if the user can go straight to the deployed folder to verify.  To make that happen, we need to formulate a URL, depending on the value of serverType, to either (SAS Viya):
$(serverUrl)/SASJobExecution?_path=$(appLoc)&_action=1063
or (SAS 9):
$(serverUrl)/SASStoredProcess?_path=$(appLoc)&_action=1063
In each relevant case, a web app will be launched.  For Viya, the user will need to navigate, whilst for SAS 9 the user will be taken straight to the relevant folder.
We can add this as a final line (after ✔ Service pack has been successfully deployed.) as follows (note change from "Service pack to Build pack):
SAS 9:
✔ Build pack has been successfully deployed.
✔ https://sas.analytium.co.uk:8343/SASStoredProcess?_path=/Public/app/folder-navigator&_action=1063

SAS Viya:
✔ Build pack has been successfully deployed.
✔ https://sas.analytium.co.uk/SASJobExecution?_path=/Public/app/folder-navigator&_action=1063

Closing as we don't deploy service packs for sas 9


What happened to PR from issue #6884 (title_below_image option for Frameit)

Hey guys,
I was looking for a solution to put the title under the screenshot as it is usual for many Screenshot Designs.
I even found that pull request: https://github.com/fastlane/fastlane/pull/6884/
Any idea what happened to that one? Is anybody on a feature like that or implemented it on another way? It would be really nice to use that feature, but I'm a total Ruby noob, so maybe somebody has an idea?

@patreu22 It needed some updates and tests from the original author but never received them (https://github.com/fastlane/fastlane/pull/6884#issuecomment-274878117) I can take a look at to possibly reviving this for you as it seemed like this PR was going to be merged 👌

That's great, @joshdholtz , thank you very much! :) I'm sure a lot of people will benefit from this feature.

Did you already have a chance to take a look on it, @joshdholtz ? :)

@patreu22 Not yet 😔 Too many other things came up! Still on my list, tho


Tuya camera Webrtc wont stay streaming

I have a camera from Tuya (https://expo.tuya.com/product/1106403) that dont have ONVIF nor direct RTSP Port.
I know, I regret buying it.
However by using Home Assistant + WebRTC component, I managed to view it in Lovelace card.
type: custom:webrtc-camera
entity: camera.rooftop_ptz
mode: webrtc
server: http://<IP_ADDRESS>:1984/
background: true

Then it showed at go2rtc web UI.
I pass it to frigate, and create a sub stream from it using "detect-> width" and "detect->height", and succesfully showed at Frigate UI.
Quality is bad, but I have no other choice.
Frigate config is
go2rtc:
  hass:
    config: "/hass/config"
    streams:
        # create substream from encoding main stream
       # main stream got from home assistant with entity=camera.rooftop_ptz
          rooftop_sub:
            - ffmpeg:camera.rooftop_ptz#width=640#hardware#video=h264#audio=aac

cameras:
    rooftop:
      enabled: true
      ui:
        order: 7
      live:
        stream_name: rooftop_sub
      ffmpeg:
        inputs:
            # main stream, got from home assistant
          - path: rtsp://<IP_ADDRESS>:8554/camera.rooftop_ptz
            roles:
              - record
            # sub stream, got from go2rtc
          - path: rtsp://<IP_ADDRESS>:8554/rooftop_sub
            roles:
              - detect

The problem is :
It can stay streaming as long as I open the Home Assistant webUI.
If i close the Home Assistant webUI, it can not stay streaming .
After sometimes, frigate become blank, no frames received.
At go2rtc web (port 1984) showed online = 0.
maybe some guidance ?

https://github.com/felipecrs/hass-expose-camera-stream-source


d1: add backups + importing docs

This PR adds:

A new /learning/importing-data guide to help users understand how to import existing table definitions & data into a D1 database, as well as how to convert an SQLite3 database dump locally.
A new /learning/backups guide that explains how automatic backups work, as well as how to manually create backups and restore them.
A deep-link into https://developers.cloudflare.com/pages/platform/functions/bindings/#d1-databases so that users can find the Pages Functions specific binding docs
Expanding the Tutorials sidebar to list the tutorials, just as we do with Pages docs: https://developers.cloudflare.com/pages/

What the sidebar will look like:

cc/ @nevikashah @geelen

@nevikashah to give this a quick once over before merging @deadlypants1973

lgtm! thanks Matt/Kate