Ipython Markdown Display Widget doesn't render in Jupyter-book

The ipython display widget doesn't render in my jupyter book HTML output. It does in my sphinx material.
To Reproduce
Steps to reproduce the behavior:
Create a markdown table and try to display it with the ipython widget.
from jinja2 import Environment, BaseLoader

rendered_report_header_table="""# Report

## Sample-1

---

|  |  |  |  |
| --- | --- | --- | --- |
| **Patient Name:** | Smith, Todd | **Ordered By:** | Dr. Who |
| **Date of Birth:** | 12/11/1977 | **Sample Collection Date:** | 12/9/2020 |
| **Gender**: | Male | **Sample Accession Date:** | 12/9/2020 |
| **Sample Type:** | blood | **Report Data:** | 12/9/2020 |
| **Sample ID/MRN:** | 1234567 | | |
| **Test Accession:** | BRCA122345 | | |
| **Test Ordered:** | BRCA2 sequencing & Deletion/Duplication analysis | | |
| **Test Code:** | ABCD | | |
| **Test Indictation** | Patient has family history of breast cancer. | | |

---

## Result: Postitive

---

| Gene   | Variant   | Zygosity     | Variant Classification   |
|:-------|:----------|:-------------|:-------------------------|
| BRCA2  | c.10G>T   | Heterozygous | Likely Pathogenic        |
| BRCA2  | c.-172A>G | Heterozygous | Unknown                  |
"""

# This doesn't work in the jupyterhub output
from IPython.display import display, Markdown, Latex, HTML
display(Markdown(rendered_report_header_table))

Expected behavior
I expect the Markdown widget to display. It does display correctly when using sphinx + nbsphinx +the  sphinx-material theme. It also displays correctly in the jupyter notebook itself.

A link to your documentation repository.
Github Repo
Link to Docs in Sphinx
$ jupyter-book build mybook
ERROR ...

Environment

Python Version [e.g. 3.7.1]:
Package versions or output of jupyter-book --version:
Operating System:

OS: Linux
Python 3.7.5
Jupyter Book: 0.8.3
MyST-NB: 0.10.1
Sphinx Book Theme: 0.0.39
MyST-Parser: 0.12.10
Jupyter-Cache: 0.4.1
NbClient: 0.5.1

Additional context
Nothing else really.

Hi @jerowe sorry for the late reply, this is because currently jupyter-book (via myst-nb) only renders Markdown output by codes cells against the CommonMark specification (https://spec.commonmark.org/0.29/) which actually does not contain tables (these are added in a plugin).
Integrating Markdown code outputs back into the flow of the overall document, does present a bit of a challenge to keep consistent compared to other output types.
I am intending to have a second pass at the rendering of outputs in the coming weeks though, and I'll report back 👍
For exact reference: https://github.com/executablebooks/MyST-NB/blob/8d3dfafafd2ededc672baff64946a1ce5950c87b/myst_nb/render_outputs.py#L239

@chrisjsewell  there's no problem. I just really like jupyterbook and this would be a nice feature to have. It's actually only necessary for me for one particular project, and I can use jupyterbook fine on other projects. ;-)

For me this is really important!
It would be good to mention this (and other limitations) clearly in the docs.
My expectation was: if it renders in a live notebook, if it renders in nbviewer, then it will render in Jupyter book.
But that does not seem the case.
I appreciate the difficulties for e.g. pdf output. But for HTML output I would value it very much if Jupyter Book could render as closely as possible as to what Jupyter Notebook/Lab renders.
Currently I'm trying to collate a work of 60+ notebooks in one book. But it turns out to be a bumpy ride.
See also #1113 .

For me this is really important!
It would be good to mention this (and other limitations) clearly in the docs.
My expectation was: if it renders in a live notebook, if it renders in nbviewer, then it will render in Jupyter book.
But that does not seem the case.
I appreciate the difficulties for e.g. pdf output. But for HTML output I would value it very much if Jupyter Book could render as closely as possible as to what Jupyter Notebook/Lab renders.
Currently I'm trying to collate a work of 60+ notebooks in one book. But it turns out to be a bumpy ride.
See also #1113 .

@dirkroorda have you tried using sphinx and nbsphinx? That's what I'm using for my project that requires displaying the markdown widgets. I'm sure jupyter-book will be able to display IPython display widgets.
@chrisjsewell , I'm not sure if this is an option (or just a stupid suggestion ;-) ) but is it possible to use nbsphinx for the ipynb notebooks and the myst-parser for markdown files? Then my markdown widgets would display correctly in the notebooks, and I would get the nice markdown syntax!

@dirkroorda have you tried using sphinx and nbsphinx? That's what I'm using for my project that requires displaying the markdown widgets. I'm sure jupyter-book will be able to display IPython display widgets.
@chrisjsewell , I'm not sure if this is an option (or just a stupid suggestion ;-) ) but is it possible to use nbsphinx for the ipynb notebooks and the myst-parser for markdown files? Then my markdown widgets would display correctly in the notebooks, and I would get the nice markdown syntax!

Oh and I really like the newest release of jupyter-book! I've been using it for new projects and its NIFTY!

Oh and I really like the newest release of jupyter-book! I've been using it for new projects and its NIFTY!

@jerowe
Excellent idea, imho.
Because the rendering of a notebook with its outputcell that can contain arbitrary HTML, Markdown and CSS is quite another thing than rendering a "plain" markdown file.
We have now pretty solid expectations of how an output cell renders whatever we put in it, that it is very disrupting to change that for the sake of wrapping it inside a book.
The look and feel of an output cell is almost sacred!
I have multiple struggles with the Juptyer Book rendering of output cells.

@jerowe
Excellent idea, imho.
Because the rendering of a notebook with its outputcell that can contain arbitrary HTML, Markdown and CSS is quite another thing than rendering a "plain" markdown file.
We have now pretty solid expectations of how an output cell renders whatever we put in it, that it is very disrupting to change that for the sake of wrapping it inside a book.
The look and feel of an output cell is almost sacred!
I have multiple struggles with the Juptyer Book rendering of output cells.

Just a quick note, I'm halfway through a PR that changes how notebook output cells are dealt with (essentially just processing them a bit earlier in the process).
This will fix this issue, so I'd just ask for a little more time (but not too much) 😉

Because the rendering of a notebook with its outputcell that can contain arbitrary HTML, Markdown and CSS is quite another thing than rendering a "plain" markdown file.

That is just not correct; nbsphinx does not work theoretically any differently to myst-nb/jupyter-book, particularly once the above PR is merged.
The only difference is that it goes through an extra (unnecessary) step of converting the file to RestructuredText first, rather than straight to the sphinx syntax tree (this is actually a long term goal of nbsphinx anyway).

I have multiple struggles with the Juptyer Book rendering of output cells.

If you have any issue additional to rendering of Markdown, then I would encourage to open additional issues, to point us to what needs fixing  😄

Just a quick note, I'm halfway through a PR that changes how notebook output cells are dealt with (essentially just processing them a bit earlier in the process).
This will fix this issue, so I'd just ask for a little more time (but not too much) 😉

Because the rendering of a notebook with its outputcell that can contain arbitrary HTML, Markdown and CSS is quite another thing than rendering a "plain" markdown file.

That is just not correct; nbsphinx does not work theoretically any differently to myst-nb/jupyter-book, particularly once the above PR is merged.
The only difference is that it goes through an extra (unnecessary) step of converting the file to RestructuredText first, rather than straight to the sphinx syntax tree (this is actually a long term goal of nbsphinx anyway).

I have multiple struggles with the Juptyer Book rendering of output cells.

If you have any issue additional to rendering of Markdown, then I would encourage to open additional issues, to point us to what needs fixing  😄

In #1113 there is an observation by me that the CSS styling for an output style is too agressive, so that it interferes with whatever blocks are defined by the html that is output into that cell.
A CSS rule like this one
/* Removing all background formatting so we can control at the div level */
.cell_input div.highlight, .cell_input pre, .cell_output .output * {
  border: none;
  background-color: transparent;
  box-shadow: none;
}

is unoverridable because of the * and affects all blocks in the HTML output, stripping them of there borders and backgrounds.
My advice: do not put in *, only explicit classes that are generated by the conversion process.

In #1113 there is an observation by me that the CSS styling for an output style is too agressive, so that it interferes with whatever blocks are defined by the html that is output into that cell.
A CSS rule like this one
/* Removing all background formatting so we can control at the div level */
.cell_input div.highlight, .cell_input pre, .cell_output .output * {
  border: none;
  background-color: transparent;
  box-shadow: none;
}

is unoverridable because of the * and affects all blocks in the HTML output, stripping them of there borders and backgrounds.
My advice: do not put in *, only explicit classes that are generated by the conversion process.

@dirkroorda just to re-iterate what @chrisjsewell suggested, it is much much more helpful to open new issues to bring up new concerns. I've opened up https://github.com/executablebooks/MyST-NB/issues/287 to track the "aggressive CSS styling" point that you bring up

@dirkroorda just to re-iterate what @chrisjsewell suggested, it is much much more helpful to open new issues to bring up new concerns. I've opened up https://github.com/executablebooks/MyST-NB/issues/287 to track the "aggressive CSS styling" point that you bring up

Note that background-color: transparent has already been removed in a previous request

Note that background-color: transparent has already been removed in a previous request

@choldgraf Thanks for that!
I have tried to remedy what I saw (unsuccesfully), but in order to provide a good fix, I would have to study the whole CSS setup that is used, and I think it is a waste of time doing that when people much more capable and familiar to the matter could do it with much less risk of introducing other issues.
So I restrict myself to just signalling the behaviour and pointing to a possible place that causes it.

@choldgraf Thanks for that!
I have tried to remedy what I saw (unsuccesfully), but in order to provide a good fix, I would have to study the whole CSS setup that is used, and I think it is a waste of time doing that when people much more capable and familiar to the matter could do it with much less risk of introducing other issues.
So I restrict myself to just signalling the behaviour and pointing to a possible place that causes it.

I think have a related but more nuanced issue about displaying python code-fences in markdown files....
i'm using Jupyter Book to build docs.
structure like this:
docs/
├─ intro.ipynb
README.md

In my main README.md I have a descriptive summary of the package, which contains python code fences describing how to use it:
e.g.
README.md
# my package

```python
# use like this
my = package(var)
my.plot()
```

some more text

Then in my intro.ipynb i'd like to display the README:
intro.ipynb
from IPython.display import Markdown, display
display(Markdown("../README.md"))

running the nb-spinx command
sphinx-build . _build/html -b html
sphinx does not display the markdown content.
if i remove the python code fences from the README.md then it works fine.
although it feels like quite a specific issue; being able to easily display the content of the README.md in the docs is super useful so i thought it was worth sharing.
cheers

that's a strange one, I'd think it would work. Rather than displaying with display(, could you use an "include" directive like so:
```{include} ../README.md
```

It wouldn't be included in the ipynb version of the page, but would work in the documentation

thanks very much @choldgraf - that worked perfectly :)

Hi @jerowe sorry for the late reply, this is because currently jupyter-book (via myst-nb) only renders Markdown output by codes cells against the CommonMark specification (https://spec.commonmark.org/0.29/) which actually does not contain tables (these are added in a plugin).
Integrating Markdown code outputs back into the flow of the overall document, does present a bit of a challenge to keep consistent compared to other output types. I am intending to have a second pass at the rendering of outputs in the coming weeks though, and I'll report back 👍
For exact reference: https://github.com/executablebooks/MyST-NB/blob/8d3dfafafd2ededc672baff64946a1ce5950c87b/myst_nb/render_outputs.py#L239

@chrisjsewell -- just checking if you have been able to complete your "second pass" on rendering of outputs cells?  Love jupyterbooks BTW!!

Have you had time to look into this? :)


Can I find the 0.2.0 release version in the maven center?

Can I find the 0.2.0 release version in the maven center?

lasted version has been published 6 hours,  plz wait.

@Benzenes The index might not have been updated yet, hence why you are not seeing it in the search.
It has been published -> https://repo1.maven.org/maven2/org/springframework/security/spring-security-oauth2-authorization-server/

thx,I have seen it, and the dependency download is worked for me.


Added toBeArray

What
feature - Added toBeArray matcher

Why
#35

Notes
Housekeeping

[X] Unit tests
[X] Documentation is up to date
[X] No additional lint warnings
[X] Add yourself to contributors list (yarn contributor)

Codecov Report

Merging #50 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #50   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           6      8    +2
  Lines          33     42    +9
  Branches        5      6    +1
=====================================
+ Hits           33     42    +9

Impacted Files
Coverage Δ

src/matchers/toBeArray/index.js
100% <100%> (ø)

src/matchers/toBeArray/predicate.js
100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cba84be...c7e9bfd. Read the comment docs.

Everything should be fixed now

Good job @stofolus thanks a lot


Blue colored (hyperlinked) eTokens are unclickable.

A UX problem.  eToken's name (blue) should be clickable

Removed the link color from the ticker. Will add it back in when we have the dedicated token pages setup


First message in server-streaming stream is not sent if client connects to a just-started server.

What version of gRPC and what language are you using?
Client - gRPC v1.21.0 for Java (Android)
Server - gRPC v1.21.0 for C# (dotnet core 2.1)
What operating system (Linux, Windows,...) and version?
Client - Android 8, Android 9
Server - Windows 10
What runtime / compiler are you using (e.g. python version or version of gcc)
All packages were taken from official builds (Nuget, Gradle)
What did you do?
When a client initiates a server-side streaming RPC call, while the server is not yet up - once the server is loaded (before the client times out), and the connection is established, the first message written to the write-end of the stream (on the server side - IServerStreamWriter) is not sent. When a second WriteAsync call is made, then both messages are sent immediately.
On other cases where the server is already up when the client initiates the RPC call, everything works well
What did you expect to see?
The first call to WriteAsync should send the message immediately.
What did you see instead?
The message wan't sent until a second message was written to the stream.
When the server is already up when the client initiates the RPC call, everything works well.

Could you provide a snippet that reproduces this? Does this only happen with Android Java client against C# server or in other languages as well?

Here are some snippets:
proto
rpc FetchCommands (FetchCommandRequest) returns (stream FetchCommandResponse) { }

client (Android)
...
// Called from `AsyncTask`'s `doInBackground` callback - like in your Android example code
Iterator<FetchCommandResponse> commands = blockingStub.fetchCommands(request);
...
// Called from `AsyncTask`s `onPostExecute` callback (on UI thread)
// - so we use thread executor to read the stream asynchronously without blocking the UI thread
Executor executor = Executors.newSingleThreadExecutor();
executor.execute(new Runnable() {
    @Override
    void run() {
         // >> This line doesn't return (sometimes) after C#'s first call to `WriteAsync`
        while (commands.hasNext()) {
            FetchCommandResponse command = commands.next();
            ....
        }
    }
});
...

server (C# on Windows dotnet core 2.1)
public override async Task FetchCommands(FetchCommandRequest request,
    IServerStreamWriter<FetchCommandResponse> responseStream, ServerCallContext context)
{
    while (!context.CancellationToken.IsCancellationRequested)
    {
        var command = await pending_commands.Dequeue(context.CancellationToken);
        await commands_stream.WriteAsync(command);
    }
}

If it's not helpful, we can try to reproduce it on a smaller scale.

Is this only reproducible when the client is on Android  and the Server is on windows, or have you also seen it in other situations (e.g. linux client to linux server  or windows client to windows server)?
How often is "sometimes" in  This line doesn't return (sometimes)?

Hi @jtattermusch I missed your last comment
I think it happens all the time under the circumstances described (the server is loaded during the connection initialization process from the client side). My code already bypasses this issue (triggers multiple calls to “flush the buffers” on connection) so I cannot know for sure if it still happens on latest versions. I encountered it only on Android client + Windows server, although I didn’t try the same flow on other platforms

@jtattermusch Ping.

This seems similar to https://github.com/grpc/grpc/issues/21484.
Reproducing with the Android client + Windows server setup is difficult, it would be helpful if there was a reproduction on a single system only.

@amitwaisel  it would be good to know at which point the data gets stuck when the first message is not delivered.
Can you try running the server with GRPC_VERBOSITY=debug GRPC_TRACE=tcp to see if the payload of the first message is actually read on the server side (but the server side logic doesn't emit the received message to the user code)?

It does sound similar to #21484. My application's connection flow was significantly changed since, and so are the software versions, it is not trivial to re-test it immediately. I will try to setup a small test to see if it is reproducible.

It does sound similar to #21484. My application's connection flow was significantly changed since, and so are the software versions, it is not trivial to re-test it immediately. I will try to setup a small test to see if it is reproducible.

Great! Ideally you'd provide ready-to-run project (e.g. in a github repo) that reproduces the problem.

I can reopen once there's a reproduction.

Same problem here.
First message is sent as second message is triggered. Subsequent messages are fine
We use c# gRPC NuGet v2.28.1 and have a .Net Standard 2.0 server and .net core 3.1 web service as a client both on Win10.
We encounter the problem on each start of the gRPC stream on first message after AsyncServerStreamingCall.
Please reopen this issue.

@Sequel1  please provide a reproduction (ideally as a project in a github repo) that demonstrates the problem.

Seeing the same issue. Running on Windows 10.
API is client UNI, service Streaming. For a client request there are precisely 2 service responses. The service sends the first response (ie performs WriteAsync). The client does not receive it until the service completes the web request.

Looks like this only occurs if i use HttpClient. If i revert to using SocketsHttpHandler then it behaves as expected?

Looks like this only occurs if i use HttpClient. If i revert to using SocketsHttpHandler then it behaves as expected?

Does that mean that you can reproduce with using Grpc.Net.Client (from https://github.com/grpc/grpc-dotnet) against a Grpc.Core server?
If so, then the issue could be at the server side as the original issue reports the problem with a grpc-java client against a Grpc.Core (C#) server. The problem could be that the messages are actually not sent on the wire by the C# server - which should be visible from the logs (if extra logging & tracing is enabled).
Again having a working reproduction would help a lot (as a github repo?) - without it it's hard to assess who is seeing what behavior exactly and also to debug.

I can reopen this once there's a working reproduction.


add supported features property

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.08%) to 93.179%

Totals

Change from base Build<PHONE_NUMBER>:
0.08%

Covered Lines:
806

Relevant Lines:
865

💛  - Coveralls


Update create-a-phone-system-auto-attendant.md

@MikePlumleyMSFT
PM for this is<EMAIL_ADDRESS>Added information about how to configure the destination number because we have cases on this coming in. Found this in TAP and had requested UI warning to prevent customer errors.
Also revised wording for the Skype for Business Hybrid to make it clearer. Customers and support engineers were not clear on this point. If a tenant is Skype for Business Hybrid and Skype users on premise will call AA, then routing will fail if External Phone number is used for routing to PSTN. In this case customers needs to use a target of a user that is on-premises EV enabled with forwarding to PSTN.

@JohanFreelancer9 Copy editing is needed for this PR. Thanks.

@MikePlumleyMSFT PR has been copyedited and is ready for final review, could you please check and merge? Thanks!

@scanum I see a bunch or unresolved edits. What's the process for resolving those?

@MikePlumleyMSFT Currently working on this!

This info was added via a different PR.


Start Plugin should use event loop to gracefully handle session failures

Start Plugin currently operates completely outside the event loop. When errors happen the event system doesn't get to handle them correctly and the kill event is never called.
This causes bugs for plugins that need to do cleanup after kill is called when the client session errors. The fix is for StartPlugin to immediately start the event loop and then use the event system to do what it needs to

Fixed


Document the static spacing scale and generally improve the spacing guidance

Document the static spacing scale as part of the spacing guidance, as well as:

improving the header structure of the page
moving the section on overrides last, to try and encourage users who are writing their own CSS to use the helpers instead
tweaking the guidance on helpers and overrides

This does not include documenting the new static spacing override classes (#2244) – that will be done in a follow up PR. This means that these changes can go out before v4.3.0 is released.
Fixes #1210.

Built on top of #2274 which should be merged first. Once that PR is merged, the target branch for this PR should automatically update to main.

This looks good from a technical point of view, and makes sense to me 👍


Fix api key

😬

Codecov Report

Merging #54 (89869d9) into master (d20b299) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master     #54   +/-   ##
======================================
  Coverage    0.00%   0.00%
======================================
  Files         370     370
  Lines       11425   11425
  Branches     1145    1145
======================================
  Misses      11425   11425

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d20b299...89869d9. Read the comment docs.


Fix typos in package-osx-bundles.sh

On macOS, plugin files were missing from the .dmg file. It seems like this was caused by some typos in the package-osx-bundles.sh script. This PR appears to fix the issue.

Yep, that is one silly copy&paste lapse.. :sweat_smile:
Thanks for the fix!
btw, some CI builds might fail as GitHub updated their Ubuntu image and broke things once again.


Fix BackupBucket reconciliation error by replacing StrategicMergePatch with MergePatch

How to categorize this PR?
/area backup
/kind bug
What this PR does / why we need it:
This PR fixes an error encountered during the reconciliation when deploying BackupBucket resources in the garden cluster with ProviderConfig.
The error encountered was:
unable to find api field in struct RawExtension for the json field

This happens because StrategicMergePatch requires schema information to process fields, but runtime.RawExtension lacks schema due to its nature of holding arbitrary JSON data.
By switching to MergePatch, which treats runtime.RawExtension fields as opaque, avoid this error and ensure that BackupBucket resources are reconciled correctly when ProviderConfig is used.

Which issue(s) this PR fixes:
Special notes for your reviewer:
Found the bug while testing #10866 for PR https://github.com/gardener/gardener-extension-provider-gcp/pull/906
Release note:
Fixed an error in `BackupBucket` reconciliation by replacing `StrategicMergePatch` with `MergePatch` to properly handle `runtime.RawExtension` fields.

Thanks!
/approve

/retest

/retest


ERROR: Could not find a version that satisfies the requirement pytorch3d (from versions: none)

I am able to run the notebook, but get the following error. How do I fix it?
Looking in links: https://dl.fbaipublicfiles.com/pytorch3d/packaging/wheels/py39_cu111_pyt1100/download.html
ERROR: Could not find a version that satisfies the requirement pytorch3d (from versions: none)
ERROR: No matching distribution found for pytorch3d

Managed to solve the issue with this post https://www.reddit.com/r/DiscoDiffusion/comments/tv44y2/error_no_module_named_py3d_tools/
But then I ran into another issue which I have not fixed yet when running the model:
"EOFError: Ran out of input" will make a separate post for this.
If the solution above fixes the pytorch problem and lets you run everything with no problem update me on that, might have screwed something up on my setup.

Thanks


Make UI more impressive

Hey @vilgad , I am interested in contributing to this issue.
Thanks
Aritra

hi Aritra, Sorry we can't assign issues before 1st feb. All the
contributions will be count form 1st feb onwards
On Sun, Jan 30, 2022 at 6:33 PM Aritra Das @.***> wrote:

Hey @vilgad https://github.com/vilgad , I am interested in contributing
to this issue.
Thanks
Aritra
—
Reply to this email directly, view it on GitHub
https://github.com/Kajal13081/Gallery-Application/issues/17#issuecomment-1025139043,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AUD4U5VWKSLJLXQMPY63HQTUYUZJTANCNFSM5NCT2SWQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

May I work on this?

sure @pree-T but will assign on 1st Feb.

hi Aritra, Sorry we can't assign issues before 1st feb. All the contributions will be count form 1st feb onwards
…
On Sun, Jan 30, 2022 at 6:33 PM Aritra Das @.> wrote: Hey @vilgad https://github.com/vilgad , I am interested in contributing to this issue. Thanks Aritra — Reply to this email directly, view it on GitHub <#17 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUD4U5VWKSLJLXQMPY63HQTUYUZJTANCNFSM5NCT2SWQ . You are receiving this because you were mentioned.Message ID: @.>

Ok @vilgad

hey guys,
i can understand your enthusiasm for open source contribution and thanks
for selecting our project but we will appreciate a lot if you guys can also
chat with us on the JWOC discord channel rather than on comments because
the comment section will be filled with the discussion which is not good
for others who visits the issue for JWOC ,so comment on the issue that you
wanna work on it and want us to assign it to you and if there is any doubt
related to issue or project we can easily clear it on discord. Bonding
with the mentors and other mentees are also important thats why the discord
channel is created
I hope you guys understand it
Here is the discord link JWOC Discord
https://discord.com/invite/ve6ad4jfEP
this is my discord id: Vilgad#0291
Happy Coding ;)
On Sun, Jan 30, 2022 at 11:17 PM Aritra Das @.***>
wrote:

hi Aritra, Sorry we can't assign issues before 1st feb. All the
contributions will be count form 1st feb onwards
… <#m_-3563030440845995458_>
On Sun, Jan 30, 2022 at 6:33 PM Aritra Das @.> wrote: Hey @vilgad
https://github.com/vilgad https://github.com/vilgad
https://github.com/vilgad , I am interested in contributing to this
issue. Thanks Aritra — Reply to this email directly, view it on GitHub <#17
(comment)
https://github.com/Kajal13081/Gallery-Application/issues/17#issuecomment-1025139043>,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AUD4U5VWKSLJLXQMPY63HQTUYUZJTANCNFSM5NCT2SWQ
https://github.com/notifications/unsubscribe-auth/AUD4U5VWKSLJLXQMPY63HQTUYUZJTANCNFSM5NCT2SWQ
. You are receiving this because you were mentioned.Message ID: @.>
Ok @vilgad https://github.com/vilgad
—
Reply to this email directly, view it on GitHub
https://github.com/Kajal13081/Gallery-Application/issues/17#issuecomment-1025193925,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AUD4U5SDIMPQGD3TXUXCRILUYV2SXANCNFSM5NCT2SWQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

I want to work on this issue under JWOC @vilgad

I want to work on this issue under JWOC @vilgad

I have assigned it to you, All the best

I want to work on this issue under JWOC

I want to work on this issue under JWOC

Don't assign me now, I just want to know what UI changes you're expecting in this app, so that I can figure out designs myself.

Don't assign me now, I just want to know what UI changes you're expecting in this app, so that I can figure out designs myself.

You can play with colors which can go with splash screen and icon and can also change the way album fragment looks like you can use scattered grid layout for it

@vilgad I'm sorry, I'm a java developer and I used grid layout in the past but not in kotlin. I might have to use viewpager I guess.
I thought I had to improve the UI only like colors and other Implementation l improvements like you said according to logo and SplashScreen.


Support For Live (tail) logging

Would be great to be able to leave the program open and not have to hit refresh :)

@clarkdatacolgroup although there is auto refresh feature in the bottom left corner of the application's main screen. This refreshes at the regular intervals provided in the input besides the auto refresh checkbox. For now you can use this workaround.


Create factories earlier in the lifecycle

https://github.com/rubyatscale/packs-rails/pull/71 breaks gusto's build. By loading factories earlier in the lifecycle, we see more? full? success.
@matiaseche would you check out if this branch works for your use case?

This is exactly what breaks my use case :cry:
Does this actually work at Gusto? I mean the loading of the factories file paths.
Here is the output to Rails.application.config.factory_bot.definition_file_paths on a test environment:
On this PR's branch:

On main branch:

Hope you don't mind if I join in on this conversation, I can make a new issue if it makes sense, but I wanted to add on to my custom dir not being loaded (on main as well)
I have it under packs/my_pack/spec/factories/my_factory.rb
I am seeing it in application class's definition_file_paths via pack-rails' integration
> MyService::Application.config.factory_bot.definition_file_paths

=> ["factories", "test/factories", "spec/factories", "packs/my_pack/spec/factories", "packs/my_pack/test/factories"]

BUT the key part seems to be FactoryBot.definition_file_paths does not have it:
> FactoryBot.definition_file_paths
=> [#<Pathname:/Users/me/work/my-service/factories>, #<Pathname:/Users/me/work/my-service/test/factories>, #<Pathname:/Users/me/work/my-service/spec/factories>]

I am currently working around this by manually adding the "packs/my_pack/spec/factories" at the end of config in application.rb (or just test.rb):
config.factory_bot.definition_file_paths << "packs/my_pack/spec/factories"

then it appears in FactoryBot.definition_file_paths

Hm... we're in a bit of a pickle here...

Main before the after_initialize change worked for gusto but for neither of you. Am I read your comment right, @yesthesoup?
After the after_initialize change it works for @matiaseche but for neither of us.
With this change it again works for gusto but for neither of you.

Where to go from here?

What versions of factory bot is everyone on?

We could call it twice: on before_configuration and on after_initialize, and then do .uniq to remove duplicates. But I don't like that at all.
Other idea is to add a config parameter to tell when to load FactoryBot.

What versions of factory bot is everyone on?

I am using:

factory_bot 5.1.2
ruby 3.2.2
rails <IP_ADDRESS>

factory bot 6.4.2
ruby 3.2.2
rails 7.0.8

@matiaseche in your spec helper, what comes first: loading of factories vs loading of the app environment?

@matiaseche check the Ruby/Rails modularity slack

Other idea is to add a config parameter to tell when to load FactoryBot.

@matiaseche I agree with this idea. It's more flexible to different folks' implementations and configuration and is a simple fix.
If a future upstream change makes one or the other implementation no longer practical to maintain (e.g. Rails or factorybot api change), we could release a breaking change that favors one or the other.
Although I'd still be curious why our environments are so different! This configuration affects the point in time at which factory bot is assumed to have loaded all factories, I guess? Could be worth filing an issue question over at factory bot!
Cc @shageman

@shageman same versions as yourself:
factory_bot_rails / factory_bot 6.4.2
ruby 3.2.2
rails 7.0.8
maybe the new behaviour differs based on rails/factory bot major versions
let me try that sha thanks, will update.

Downgrading to 81bc3ff does work!
Here's an abbreviated version of my gemfile:
source 'https://rubygems.org'
ruby '3.2.2'

# Core Gems
# ... aws ...

gem 'bootsnap', require: false
gem 'bullet'
gem 'dogstatsd-ruby'
gem 'dotenv-rails'
gem 'graphql'
gem 'lograge'
gem 'logstash-event'
gem 'logstash-logger'
gem "packs-rails", github: "rubyatscale/packs-rails", ref: "81bc3ff" # was just 'pack-rails` latest before
gem 'pg'
gem 'pry-rails'
gem 'puma'
gem 'rack-timeout', require: 'rack/timeout/base'
gem 'rails', '~> 7.0.1'
gem 'rake'
gem 'rbtrace'
gem 'redis-reconnect_with_readonly'
gem 'request_store'
gem 'rollbar'

# sidekiq gems
...

source 'nexus' do
# private gems
...
end

group :development, :test do
  gem 'brakeman'
  gem 'bundler-audit'
  gem 'byebug'
  gem 'factory_bot_rails'
  gem 'fakeredis', require: false
  gem 'fuubar'
  gem 'guard'
  gem 'guard-bundler'
  gem 'guard-rspec'
  gem 'guard-rubocop'
  gem 'listen'
  gem 'pry-byebug'
  gem 'rails-erd'
  gem 'rspec'
  gem 'rspec-rails'
  gem 'simplecov'
  gem 'simplecov_json_formatter'
  gem 'timecop'
  gem 'webmock'
  gem 'ws-style'
  gem 'packwerk'
end

spec/support/factory_bot.rb:
RSpec.configure do |config|
  config.include FactoryBot::Syntax::Methods
end

no other factory bot config in application.rb or test.rb
.rspec
--color
--format Fuubar
--require packs/rails/rspec
--require rails_helper

@matiaseche looking at your original PR #71 just wanted to throw it out there that respond_to?(:factory_bot) was initially always false for me as well because I had gem 'factory_bot_rails', require: false in the dev/test gem group. Just in case you have that as well and didn't already think of it.

Yes! @yesthesoup that was my problem!
My Gemfile has the following:
  gem 'factory_bot', require: false
  gem 'factory_bot_rails', require: false

If I remove the require: false then it works as expected on this branch :rocket:
@shageman I think we are ready to move forward with this change! Thank you both!

Thanks team for getting to the bottom of this!

Yay! to all the progress. And... I am unsure how to proceed :D
For @yesthesoup the downgraded version (i.e., before initializer stuff at all worked).
For @matiaseche what worked? This PR, yes! The downgrade?
If both work for all of us now... which one is better? I am leaning towards removing the initializer code (i.e., "downgrade" rather then this PR) because it is simpler.
Given that we know how to fix in all situations, I won't proceed before your feedback.
Thanks all!

Oh wait... I had pushed another change onto this branch that is effectively the downgrade... Since that's now confirmed to be working for folks, I will merge this.


interaction.response.defer no longer works

Summary
probably due to an update of the discord API, using the "interaction.response.defer" function crashes all the "interaction.send" that follow
Reproduction Steps
I use low-level on_interaction event.
I needed to defer some slow commands, unfortunately, while this worked very well before, now, as soon as I defer a command, I can't send anything after without getting this error message:
Traceback (most recent call last):
  File "/usr/local/lib/python3.9/dist-packages/disnake/client.py", line 612, in _run_event
    await coro(*args, **kwargs)
  File "/root/python/run/OTTO/OTTO_bot.py", line 51, in on_interaction
    await bot_help(interaction)
  File "/root/python/run/OTTO/bot_help.py", line 6, in bot_help
    await interaction.send("test")
  File "/usr/local/lib/python3.9/dist-packages/disnake/interactions/base.py", line 620, in send
    await sender(
  File "/usr/local/lib/python3.9/dist-packages/disnake/webhook/async_.py", line 1625, in send
    data = await adapter.execute_webhook(
  File "/usr/local/lib/python3.9/dist-packages/disnake/webhook/async_.py", line 224, in request
    raise HTTPException(response, data)
disnake.errors.HTTPException: 401 Unauthorized (error code: 50027): Invalid Webhook Token

This message appears only on the commands previously defered
Minimal Reproducible Code
import disnake as discord

intents = discord.Intents.all()
client = discord.Client(intents=intents)

@client.event
async def on_interaction(interaction):
    if interaction.data.name == "help":
        await interaction.response.defer(with_message=True, ephemeral=False)
        await interaction.send("test") # this will crash

client.run("XXXXXXXXX")

Expected Results
/help is supposed to return "bot is thinking..." and then "test".
Actual Results
/help just returns "bot is thinking..." and a console error message
Intents
all
System Information
- Python v3.9.2-final
- disnake v2.5.1-final
    - disnake pkg_resources: v2.5.1
- aiohttp v3.7.4.post0
- system info: Linux 5.10.0-14-cloud-amd64 #1 SMP Debian 5.10.113-1 (2022-04-29)

Checklist

[X] I have searched the open issues for duplicates.
[X] I have shown the entire traceback, if possible.
[X] I have removed my token from display, if visible.

Additional Context
No response

This is an issue with the Discord API. We'll just have to wait for them to fix it.

Please read the Discord status page which states this is an issue with the API that will be fixed.


QCMA FOR MAC NOT WORKING

Qcma download for Mac is not working. "This is not the page your looking for"

@TheOfficialFloW Is it temporary down or are you working on a fix mate?

It‘s not my repo so what do you want me to do?

Who should I contact? Can i download Qcma for Mac elsewhere? Any other solutions?

https://github.com/codestation/qcma/releases

Thank you!


ENH: stats: Add Skewed Cauchy Distribution

https://cran.r-project.org/web/packages/sgt/vignettes/sgt.pdf and https://en.wikipedia.org/wiki/Skewed_generalized_t_distribution#skewed_Cauchy_distribution gives the expression for skewed Cauchy Distribution. Will add tests in due time. Fixes #7437
As this in my first ENH fix, please let me know if I am on the right path.

Yes, this is a very good start!
Several things to do still:

[ ] Add this distribution to the generic test loop: add an entry to https://github.com/scipy/scipy/blob/master/scipy/stats/_distr_params.py

[ ] Testing some values against R would be nice, see how it's done in e.g. test_multivariate.py (grep for "R code")

[ ] An explicit form of cdf, possibly also ppf and/or rvs. These seem to be easy to add, and not having them makes a distributions slow.

http://dx.doi.org/10.1080/03610918.2014.1002617
This gives an algorithm for simulating truncated skewed Cauchy random variables. This is not what we want, is it? I didnt find any references for usual skewed Cauchy random variates. Or am I missing something here.
I can add the pdf and ppf, but the original paper does not give any expression for these. I can integrate the functions myself and derive explicit expressions, though. Shall I proceed?

Yes, doing an integral is straighforward, seems like an easy way to proceed.

Added the ppf and cdf; please crosscheck.

Added tests against cauchy. Will figure out the R Tests soon.

That is right, I shall make the correction over the weekend.

But this also means that, the implementation of skewed normal is incorrect,
because even that does not impose this condition.
And again, following
https://en.wikipedia.org/wiki/Skewed_generalized_t_distribution#skewed_normal_distribution,
it ideally should

ping @adivijaykumar
did you lose interest on this PR?

Hey @zoj613, not really, I had forgotten about this. If you want to go ahead with this, please do!

@ev-br I picked this up, addressing all of your remaining comments, corrected the ppf implementation, and added a tutorial. Hope you don't mind, but I treated the comments as a checklist, resolving them as I went.

@ev-br I picked this up, addressing all of your remaining comments, corrected the ppf implementation, and added a tutorial. Hope you don't mind, but I treated the comments as a checklist, resolving them as I went.

Thanks! I'll address those this morning.

Thanks! I'll address those this morning.

Matt, would be able to squash the commits? 12 commits is a bit too much, and this PR cannot be squash-merged without losing authorship. I'd suggest making it two commits, one by you, the other by the OP. Or if you prefer it more fine-grained, fine by me too.

Matt, would be able to squash the commits? 12 commits is a bit too much, and this PR cannot be squash-merged without losing authorship. I'd suggest making it two commits, one by you, the other by the OP. Or if you prefer it more fine-grained, fine by me too.

I could squash my commits, but I'm not sure about the best way to squash the original ones. I merged master in to avoid force-pushing to the original author's branch, so that puts those commits way back in the list. If I were to do an interactive rebase from here, I'd have to go some ~7000 commits back. I can think of at least one way to do it, but I am wondering what you would do?

I could squash my commits, but I'm not sure about the best way to squash the original ones. I merged master in to avoid force-pushing to the original author's branch, so that puts those commits way back in the list. If I were to do an interactive rebase from here, I'd have to go some ~7000 commits back. I can think of at least one way to do it, but I am wondering what you would do?

If the interactive rebase is challenging, I'd just squash into three commits: all from 2017, merge the master, and all new developments of 2020 and 2021.

If the interactive rebase is challenging, I'd just squash into three commits: all from 2017, merge the master, and all new developments of 2020 and 2021.

And for your cherry-picking approach, I'd squash  into three anyway, so there's only two commits to cherry-pick, instead of 15 :-)

And for your cherry-picking approach, I'd squash  into three anyway, so there's only two commits to cherry-pick, instead of 15 :-)

I'm not aware of being able to squash except via interactive rebase. If I do an interactive rebase, there is no need to keep the merge commit.
The problem is that I don't want to do an interactive rebase involving ~7000 commits that have occurred since the first of the original author:s commits.

I'm not aware of being able to squash except via interactive rebase. If I do an interactive rebase, there is no need to keep the merge commit.
The problem is that I don't want to do an interactive rebase involving ~7000 commits that have occurred since the first of the original author:s commits.

That was unpleasant.
I created gh-13374 to avoid force pushing to @adivijaykumar's repo. Preserving this also makes it possible to confirm that there is no difference between the new PR and the rebased version.

That was unpleasant.
I created gh-13374 to avoid force pushing to @adivijaykumar's repo. Preserving this also makes it possible to confirm that there is no difference between the new PR and the rebased version.


add quarter function

Hi! I'm new to the project. this is my small PR about TiDB function migration.
What problem does this PR solve?
Issue Number: ref https://github.com/tikv/tikv/issues/5751
Problem Summary: migrating quarter from TiDB
What is changed and how it works?
What's Changed:
Implement quarter function.
Related changes
No Related Changes
Check List
Tests
Unit test
Release note

Implement  quarter

/cc @skyzh please review my code

/retest

/test

/merge

/test

/test

/test


Restore string api to virtual shield library

Hi @sidwarkd, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by Microsoft and real humans are currently evaluating your PR.
TTYL, MSBOT;

Sent email with questions. Looks good for the most part, will recheck after email issues have been addressed.

:+1:

Issues addressed. Please recheck @zfields


Prevent users from playing video clips

Hello,
im trying to configure the new frigate card so that users can only see recent snapshots which is working however, when users click on the thumbnail, it starts playing the video clip as well. i want to be able to prevent users from playing video clips from the dashboard/lovelace.

This is not currently supported.
Can you describe the usecase a little more? What do you want to work, and what to you want to be restricted? Why?

Sure. i have a live in nanny that has access to home assistant via an ipad on her wall and her mobile device. on her dashboard, i have picture cards configured so that she can see the last object that was detected for various cameras. im doing this via the built in home assistant picture card. i would love to give her access to see previous images/snapshots that the system detected in the event that she hears something or wants to check if their was movement/activity on a particular camera. right now the way i have it setup, she can only see the LAST object/activity that was detected. the reason why i do not want to give her access to video feeds is for privacy reasons and most importantly, when you play back the video it includes audio as well. if im outside having a private conversation, i dont want her to be able to play back the video. hope this makes sense?

And presumably the user cannot edit the dashboard :-)
I don't think a card wide 'no_video' option makes sense since there will very rarely be wanted, but I do think we should be able to get what you want via other means. By changing the card menu buttons you can hide the live view, clips/clip view, the timeline view and just leave snapshots. At that stage, I think the only "broken" thing is that when you click on a snapshot it takes you to the matching clip.
If an option was added to prevent that click (getting from a snapshot to a video), would that cover the cases you're worried about? Have you seen any other "path" to get to clips?
I hasten to add: This is not any sort of real or even pretend 'security' (in the computer science sense), and there's zero guarantee some existing feature we don't think of, or new feature wouldn't be added to the card in future that adds back in access to clips via some other path. So if you cannot live with that possibility, this approach (and this card) may not be for you.

yes correct the user cannot edit the dashboard, or access frigate directly as i have it hidden from the side bar. Your solution to give an option that would prevent the clip from playing with they click on the snapshot/picture is exactly what im looking for! if that can be disabled somehow from a setting via the card, it would solve my exact issue.


Not able to made changes WebViewYouTubePlayer.kt File.

Bug Report
Description of the Bug

Environment details

Android Version:
API Version:
Tested devices:

Youtube Player Library Version:
Steps to reproduce the bug

name: Bug report
about: Use this template for reporting bugs
labels: bug

Bug Report
Description of the Bug

Environment details

Android Version:
API Version:
Tested devices:

Youtube Player Library Version:
Steps to reproduce the bug

Expected behavior

Actual behavior

Additional information
<!-- Provide here further information that might help understand the issue or reproduce the bug, e.g.
- standalone code snippets of implementation that can copy-pasted and work without any missing classes
- screenshot(s) of visualising the bug
- error logs
- any useful background infromation

i am not able to write any things in these file.

You need to import the project to be able to edit it. Including a library is not enough.


fix: pydantic schema parser now supports nested objects

Updated.
fix: fixes pydantic parser to support nested objects.
This fails before the PR and succeeds afterward:
from pydantic import BaseModel
from typing import List, Optional

from crewai.utilities.pydantic_schema_parser import PydanticSchemaParser

class InnerModel(BaseModel):
    inner_field: int

class TestModel(BaseModel):
    simple_field: str
    list_field: List[int]
    optional_field: Optional[str]
    nested_model: InnerModel

print(PydanticSchemaParser(model=InnerModel).get_schema())   # works
print(PydanticSchemaParser(model=TestModel).get_schema())    # fails

Note. Because the main branch currently doesn't support nested
schemas and the original code against which I made this PR months ago
drifted, I made a judgement call on how to format the nested
structures. I chose the following, inferred from the current code:
>>> print(PydanticSchemaParser(model=InnerModel).get_schema())
{
    inner_field: int
}

>>> print(PydanticSchemaParser(model=TestModel).get_schema())
{
    simple_field: str,
    list_field: List[int],
    optional_field: Optional[str],
    nested_model: InnerModel
    {
        inner_field: int
    }
}
```

Thanks for this. Struggling with this error atm. Hopefully this is merged.

Nice! I see there are some conlicts, I'll try to fix it

Hey @inchoate! Thanks for your pull request!
We've made quite a few changes since July, so could you take a moment to check if everything is still relevant and working as it should?
If it is, just give us a shout— we’d love to help you get it merged!
Thanks

Updated.
Let me know if you want a new PR b/c of the force push.


[FSDE-1206] Add support for portal theme

https://ctl.atlassian.net/browse/FSDE-1206

The CI pipeline did not run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-114/1/. :x:

The CI pipeline did not run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-114/2/. :x:

The CI pipeline run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-114/5/. :white_check_mark:

You can check this PRs instance in https://1e7ff8ccac19ab89e2e8be52271ad4920dee6110-chi-pr.enterprise.ctl.io

The CI pipeline run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-114/6/. :white_check_mark:

You can check this PRs instance in https://d6aa7d80d7429ea21536103898387d083493c062-chi-pr.enterprise.ctl.io

The CI pipeline run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-114/7/. :white_check_mark:

You can check this PRs instance in https://f2fffb3b3655c9aa0c9451d4356d928f819842e2-chi-pr.enterprise.ctl.io

@mattnickles great job!!


Check settings versus docs & schema

Compare https://raw.githubusercontent.com/U-C-S/Hurl/main/Utils/UserSettings.schema.json
What I found:
Background type (enum) missing "none"?
        "BackgroundType": {
          "type": "string",
          "description": "The type of background to use for the browser window. mica or acrylic.",
          "enum": ["mica", "acrylic"]

Rule prefixes: a prefix is expected, "no prefix" is not valid. However, according to docs, a prefix may be omitted to imply "string".
          "Rules": {
            "type": "array",
            "items": {
              "type": "string",
              "description": "The URL pattern prefixed with s$, g$, r$ or d$, followed by the pattern to match. s$ = simple string, g$ = glob, r$ = regex, d$ = domain.",
              "pattern": "^(s\\$|g\\$|r\\$|d\\$).*"
            }

Rule Type
Format
Example

String
s$__your_rule__ or __your_rule__
https://github.com/U-C-S

Window minwidth and minheight
According to the docs, default size is 420×210. MainWindow properties are defined as:
    MinWidth="460"
    MinHeight="230"

Do we know of more inconsistencies?

Yeah, These 2 cases are the only inconsistencies as far as I know. I just left them as it is earlier before having the Settings UI to decide whether it should as it in the schema or as it in the code.

s$your_rule or your_rule

Both should be valid, so the schema's regex should be updated

missing "none"

none currently doesn't work in the UI anyway, but want to support it in the future. we can leave the this as it is

Let's collect the correct data here:

Background type: Adding "none" to the enum is simple. Off-topic:

Maybe "solid" is a better word? None can sound like transparent.
Should mica or acrylic be the default?

Prefix: The best way to specify in RegEx that a prefix may be omitted is (...)

See also #166

Minimum size: I think the code is leading, so 460 x 230

mica is the default (acrylic has issues, i dont know if they still exist in newer versions of wpf-ui)


Output diff to raw logs

Thanks for making this script, I switched from the bash version a few months ago and have been finding it a lot better.
I find that sometimes I need to look at what the diff was for a previous execution so I added this to output the full diff to the raw logs.

Thanks for the PR!
This shouldn't be necessary. The snapper.log will output the condensed and formatted information from snapraid, while snapper_raw.log will contain all the raw output from snapraid, including the diff output.


Samyak1080 issue/238

forked PR from https://github.com/Adobe-Marketing-Cloud/aem-core-wcm-components/pull/252 and activated Junit test for uuid

Codecov Report

Merging #282 into development will increase coverage by 0.03%.
The diff coverage is 100%.

@@                Coverage Diff                @@
##             development     #282      +/-   ##
=================================================
+ Coverage           82.1%   82.14%   +0.03%
- Complexity           849      852       +3
=================================================
  Files                 79       79
  Lines               2727     2733       +6
  Branches             506      507       +1
=================================================
+ Hits                2239     2245       +6
  Misses               201      201
  Partials             287      287

Impacted Files
Coverage Δ
Complexity Δ

...com/adobe/cq/wcm/core/components/models/Image.java
100% <100%> (ø)
13 <1> (+1)
:arrow_up:

.../core/components/internal/models/v2/ImageImpl.java
74.02% <100%> (+1.8%)
22 <1> (+2)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2bb0081...939e912. Read the comment docs.

fixes #238


Let javascript cope with Saleor not at root of site

I want to merge this change because...
I needed to run saleor at a non-root URL, and the hardcoded URLs in cart.js break this. This change uses base.html to set the relevant URLs into two javascript variables which are then used in cart.js.
I appreciate that there may be more optimal ways to achieve this outcome, but I couldn't immediately think of what they might be! Very happy to take suggestions as to better ways to achieve this...
Pull Request Checklist
(Please keep this section. It will make maintainer's life easier.)

[ ] Privileged views and APIs are guarded by proper permission checks.
[ ] All visible strings are translated with proper context.
[ ] All data-formatting is locale-aware (dates, numbers, and so on).
[ ] Database queries are optimized and the number of queries is constant.
[X] The changes are tested.
[X] The code is documented (docstrings, project documentation).
[ ] Python code quality checks pass: pycodestyle, pydocstyle, pylint.
[ ] JavaScript code quality checks pass: eslint.

Codecov Report

Merging #1529 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1529   +/-   ##
=======================================
  Coverage   82.75%   82.75%
=======================================
  Files         131      131
  Lines        5664     5664
  Branches      642      642
=======================================
  Hits         4687     4687
  Misses        812      812
  Partials      165      165

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ec214a...bcbd33e. Read the comment docs.

Thanks for your contribution! Hardcoding URLs in JS is definitely a bad practice and we should get rid of this. However, the most elegant solution (and the one we prefer in Saleor) would be to pass them to JS using data- attributes. I'm not sure to what HTML element we should attach them, maybe the root html would be the most apropriate. So in base.html we could have something like:
<html data-shipping-options-url="{% url "" %}" data-cart-summary-url="{% url "" %}">

And then in JS:
const shippingOptionsURL = $('html').data('shipping-options-url');

etc.
What do you think about this? If you could refactor your code this way, it would be great!

Hi @elwoodxblues - thanks for the suggestion, very useful! I have updated the code as suggested.


[BUG] Preset for github Issues

#Preset for Github Issues

I can make a preset for github issues
Two form can be created.
BUG and Feature form

#Please add hactoberfest and GSSoC24 tag. You can assign me for this issue.

Proceed!

Why reopened this ??


FHI Angular Highcharts: make it possible to set individual colors on series

Description
We would like to be able to set colors, for example on one of the lines in a line diagram. We have a line that is a reference point for the others, so it would have been nice to be able to mark this a little more clearly.

@stalehaugenes Added new issue as discussed, but as mentioned, there will be some discussions internally in the design team regarding this on.

@stalehaugenes, feel free to drop some examples where this is applicable, so we have the best context possible


Opening and closing GUIs in Renoise causes a slight hang

I thought this was just something that happens when you use plugins in Wine but I can't replicate the behaviour in Reaper or qtractor. When I open or close (particularly close) guis of plugins the sound hangs with a nnnnnnnnnnnnnnnnnnnnnnnnnnnnnnn sound, like a beat repeater on a very small size setting. It stays like this for 2 or 3 seconds and then everything goes back to normal. It seems to happen with all vsts I've tried, both instruments and effects.
I have tried with the rt patch for wine and without it, it makes no difference at all.
I tried using alsa instead of JACK and I don't get the nnnnnnnnnnnn sound but instead it just mutes all the sound, all audio stops for the same amount of time and then continues to play again after the 2 - 3 seconds, no not much better or different really.
The same vsts open and close with no audible effect at all in Reaper and in qtractor I don't get the hanging sound and the music continues to play.
I have wine 1.7.29 with the following USE flags enabled (X alsa fontconfig gecko jpeg mono mp3 ncurses nls opengl perl png prelink realtime run-exes ssl threads truetype xml).
I'm really trying to find out whether this is normal and expected or whether it is a problem with renoise, or the bridge, or wine.

Hi abique,
I've used vst-bridge until now and had the exact same issue with the hanging sound but never get around to look for a solution.
A few days ago someone told me about airwave which I didn't know to exist until then. My first impression was very good, and I wanted to compare both projects and found this github issue here by coincidence.
Now my question is about the status of your project. I see you recommended airwave, but I also see quite recent commits to vst-bridge. That puzzles me. Would you be so kind and explain your long term goals concerning this project?
Regards,
Mateusz

Same thing here, same sound freezes "problems", and I was using vst-bridge cause there is more recent commits too :p


Please bring back the resource consumption feature

In 3.3.1, there were fields to customise resource consumed.

It seems to be gone from 4.0. Please bring it back.

It's in the activity.

Thank you.


Tweak works also on DSC-WX220

At present WX220 is not listed at the supported cams. I gave it a try and it worked.

Thanks for reporting. The camera is present in this list, this means that tweaks can be applied in updater mode.


Polish UI on Tic Tac Toe

This is a small PR to polish TicTacToe UI (in line with new designs)

Modifes font values
Modifes color values
Makes window dimension responsive with min width
Makes 'My Games' section scrollable
Updates logo
Other small fixes

#211  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @tarunkhasnavis and the rest of your teammates on  Graphite


fix: Correct Select Widget Mapping for Dynamic Label and Value Keys

Description
Problem
When the Select widget's labelKey or valueKey properties are switched to JS mode, passing a function that returns a string as the key causes the dropdown options to break. Instead of correctly mapping the labels and values, the options are incorrectly returned as an array of the key itself.
Root Cause
The issue lies in the getOptions function in derived.js. The logic that computes the select options based on the labelKey and valueKey was not handling cases where these properties are functions that return arrays. Instead of mapping through the source data and returning the corresponding values for each key, the function was mistakenly returning the entire array.
Solution
The getOptions function in derived.js has been updated to correctly handle cases where labelKey or valueKey are arrays. The function now maps through the sourceData and computes the correct labels and values based on the provided properties, ensuring that the dropdown options are displayed as expected.
Fixes #35269
Automation
/ok-to-test<EMAIL_ADDRESS>@tag.Select, @tag.Widget, @tag.Binding"
:mag: Cypress test results

[!IMPORTANT]
🟣 🟣 🟣 Your tests are running.
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/10523134434
Commit: 0e96dd8df08e55b7c6eb7f79d38e194e25f8e7ae
Workflow: PR Automation test suite
Tags: @tag.Sanity, @tag.Select, @tag.Widget, @tag.Binding
Spec: ``
Fri, 23 Aug 2024 09:12:39 UTC

Communication
Should the DevRel and Marketing teams inform users about this change?

[ ] Yes
[ ] No

Summary by CodeRabbit

New Features

Enhanced test coverage for the Select widget by adding new test cases to validate the correct functioning of JavaScript functions in the label and value keys.
Improved processing of optionLabel and optionValue properties for the Select widget, ensuring accurate mapping to sourceData.

Bug Fixes

Corrected the handling of multiple options in the Select widget to enhance data mapping accuracy and functionality.

/build-deploy-preview skip-tests=true


raft: disabling uncommitted size accounting for emptyEntry

In becomeLeader method(raft.go) we reduce the uncommitted size for empty entry, which is basically a no-op as payload size will always be 0 for empty entries. Added a test case to check that as well.
Signed-off-by: Daman Arora<EMAIL_ADDRESS>this closes #12

@nvanbenschoten I have pushed the required changes

@nvanbenschoten I can see the usage of golang standard testing library for assertions at lot of places, should I create a new issue/PR that uses testify/require for assertions?

@nvanbenschoten I have updated the comment and squashed all the commits.

Hi @tbg
Can I start picking test cases which need to be updated to use testify/require ?

@tbg what do you think? Worth the code movement, or should we just update tests as they're changed going forward? @falser101 had started doing some of this in https://github.com/etcd-io/raft/commit/cdd4cb38ef696c51ef44aefac8acafd302ac34e1 and related commits.

Can I start picking test cases that need to be updated to use testify/require?

Yes, please! Please mention me (@tbg) on these PRs so they pop up on my radar.
I'll merge this once it gets through CI, thank you for your contribution!


Update text to reflect 19 Apr 21 handover session

Context
Update text following handover session on morning of 19 Apr 21 with @jamesrose
Changes proposed in this pull request
Update text after having another read through and make e-mail sending description clearer
Guidance to review

 Ref 003 - Enabling the delivery of remaining device allocations and router orders


Connect additional social account to current user

I didn't find any documentantion or use case anywhere so I had to ask it here.
I am using python-social-auth with django and everytime an user do a login in the app, it creates a new account, which is great.
But I want this use case:
The user logs in with a social backend (i.e. Facebook)
The user goes to his/her edit profile page I had created
In that page he/she finds buttons to assocciate or connect additional accounts to the current django user account (i.e. a Twitter or Google button) so next time he wants to login, could use the Twitter account instead the Facebook (which was the first).

How which is the best way to develop these connect buttons funcionality? I think it will end up by adding a new object to UserSocialAuth model, but how I contact the backend and get the keys using the PSA engine?
Thanks

Is there no way? Anybody?

Yep, i need it to.

Is there no way? Anybody?

Look at django_example app to get a hint.

PSA wil automatically associate new social-account to the current logged in user, if there's no logged-in user, then a new one is created. The URLs are the same for create and associate.


hvplot incompatible with bokeh 3.0.1, 3.0.2

Thanks for all your excellent work with holoviz.
Seems there's an incompatibility between hvplot and bokeh 3.0.  The below shows results for bokeh 3.0.2; bokeh 3.0.1 gives me the same result. bokeh 2.4.3 works fine.
ALL software version info
(this library, plus any other relevant software, e.g. bokeh, python, notebook, OS, browser, etc)
hvplot                    0.8.1
bokeh                     3.0.2
python                    3.10.6
Ubuntu 20.04.5 LTS
conda 4.1.2, condaforge channel (both via miniforge)
Description of expected behavior and the observed behavior
installing hvplot in a minimal conda environment results in an ImportError on import hvplot:

ImportError: cannot import name 'Box' from 'bokeh.models' (/home/timh/mambaforge/envs/venv-test/lib/python3.10/site-packages/bokeh/models/init.py)

Complete, minimal, self-contained example code that reproduces the issue
mamba create -n venv-test python=3.10 bokeh hvplot
conda activate venv-test
python
>>> import hvplot

If I specify bokeh v2.4.3 it works fine:
mamba create -n venv-test python=3.10 bokeh=2.4.3 hvplot
conda activate venv-test
python
>>> import hvplot

Stack traceback and/or browser JavaScript console output

import hvplot
Traceback (most recent call last):
File "", line 1, in
File "/home/timh/mambaforge/envs/venv-test/lib/python3.10/site-packages/hvplot/init.py", line 65, in
import panel as _pn
File "/home/timh/mambaforge/envs/venv-test/lib/python3.10/site-packages/panel/init.py", line 3, in
from . import layout # noqa
File "/home/timh/mambaforge/envs/venv-test/lib/python3.10/site-packages/panel/layout/init.py", line 1, in
from .accordion import Accordion # noqa
File "/home/timh/mambaforge/envs/venv-test/lib/python3.10/site-packages/panel/layout/accordion.py", line 5, in
from .base import NamedListPanel
File "/home/timh/mambaforge/envs/venv-test/lib/python3.10/site-packages/panel/layout/base.py", line 13, in
from ..io.model import hold
File "/home/timh/mambaforge/envs/venv-test/lib/python3.10/site-packages/panel/io/init.py", line 8, in
from ..config import config
File "/home/timh/mambaforge/envs/venv-test/lib/python3.10/site-packages/panel/config.py", line 20, in
from .io.notebook import load_notebook
File "/home/timh/mambaforge/envs/venv-test/lib/python3.10/site-packages/panel/io/notebook.py", line 40, in
from .embed import embed_state
File "/home/timh/mambaforge/envs/venv-test/lib/python3.10/site-packages/panel/io/embed.py", line 20, in
from .model import add_to_doc, diff
File "/home/timh/mambaforge/envs/venv-test/lib/python3.10/site-packages/panel/io/model.py", line 11, in
from bokeh.models import Box, ColumnDataSource, Model
ImportError: cannot import name 'Box' from 'bokeh.models' (/home/timh/mambaforge/envs/venv-test/lib/python3.10/site-packages/bokeh/models/init.py)

Could you please report what HoloViews version was installed?

hvPlot, HoloViews and Panel will not be 3.0 compatible until some time around January. There have been major changes in Bokeh 3.0 that we have to adapt to and as of 3.0.x there is some functionality missing that won't allow us to upgrade.

Could you please report what HoloViews version was installed?

holoviews was 1.14.9
Thanks, @philippjfr, good to know.
Thanks as always to the whole holoviz team for all your work on this!

Oh another question if you don't mind, which version of mamba do you use?

@maximlt, I have mamba 0.22.1, conda 4.12.0


simplify CSP directive generation

Hi! 👋
Firstly, thanks for your work on this project! 🙂
Today I used patch-package to patch<EMAIL_ADDRESS>for the project I'm working on.
My task
I had to implement the CSP headers for an astro web app appropriately to the predefined (and not negotiable) company policy.
Where I ran into obstacles:

I have to add https: to the script-src
I have to remove self from the script-src
Both of them seemed to be impossible with the current implementation of astro-shield:
if I add 'https:', astro-shield adds quotation marks around it, which makes the rule invalid
'self' is added by astro-shield by default, could not prevent it (related: https://github.com/kindspells/astro-shield/issues/54)

My suggestions
Checking the code it seems to me, that it tries to add some defaults to the CSP directives.
IMO the rule of quotation mark usage in CSP directives is chaotic enough, astro-shield should not complicate it further:) (I mean adding and removing quotation marks from the values the developer set in the config file).
My suggestion is to leave the developer-set values as it is to avoid any confusion and expand them only with the hash values of the resources.
Here is the diff that solved my problem:
@@ -16,16 +16,6 @@ export const serialiseHashes = hashes =>
 		.map(h => `'${h}'`)
 		.join(' ')

-/**
- * @param {Set<string>} hashes
- * @returns {string}
- */
-export const safeSerialiseHashes = hashes =>
-	Array.from(hashes)
-		.sort()
-		.map(h => (h.match(/^'[^']+'$/i) ? h : `'${h}'`))
-		.join(' ')
-
 /**
  * @param {CSPDirectives} directives
  * @returns {string}
@@ -45,15 +35,9 @@ export const serialiseCspDirectives = directives =>
 export const setSrcDirective = (directives, srcType, hashes) => {
 	const baseSrcDirective = directives[srcType]
 	if (baseSrcDirective) {
-		const srcDirective = new Set(
-			baseSrcDirective.split(/\s+/).filter(v => v !== "'self'"),
-		)
-		for (const hash of hashes) {
-			srcDirective.add(`'${hash}'`)
-		}
-		directives[srcType] = `'self' ${safeSerialiseHashes(srcDirective)}`
+		directives[srcType] = `${baseSrcDirective} ${serialiseHashes(hashes)}`
 	} else {
-		directives[srcType] = `'self' ${serialiseHashes(hashes)}`
+		directives[srcType] = `${serialiseHashes(hashes)}`
 	}
 }

If it makes sense to you, I would like to contribute by implementing this patch fully (modify the tests and create the PR)
This issue body was partially generated by patch-package.

Hi @danielszuk . It seems you are not the only one having problems with this specific part of the integration.
I agree that it needs some changes, but I should look at it with care. From what I see there, I suspect that your patch would break other systems.

Hey @castarco, thanks for your contribution! We are eagerly waiting for your insights about this, ping me if you need any help.

Morning @danielszuk , you can take a look on this PR https://github.com/kindspells/astro-shield/pull/79 .
It's very similar to what you did, but I kept having 'self' by default (it's possible to remove it by explicitly setting the CSP directive).
I also kept part of that "complex" logic you removed, to ensure that it gets rid of duplicates and always presents the directives in the same form (so equivalent directives should look the same).

Thank you @castarco, works well now in 1.3.6 :)

Thank you @castarco! Works well now in 1.3.6 :)


Add support for deply key APIs

add this apis. https://developer.github.com/v3/repos/keys/

Apart from the two very minor comments, the PR looks good.

For now it was fixed comments.


TAJO-1936: NPE when calling the query result REST api

Currently, Tajo Rest API return NPE when sessionId is null.
because of ConcurrentHashMap's put method throws when value is null.
So. I changed NPE to BadRequestExeception when session id is null.
Thanks.

Hi @charsyam, thanks for your work.
It looks nice to me. I left very trivial comments.
Anyway, as you already know, our REST api lacks methods to test failure cases. So, IMHO, it would be great if more methods to test various failure cases are added like testGetQueryResultWithoutSessionId() you already added in this patch.
What do you think?

@jihoonson
Thanks for your review :)
I will apply your advice.
and I also agree with you. We need more failure testcases :)
I will add more failure testcases for REST-API in my space time :)
Thanks :)

Thanks for understanding.
I will review as soon as possible after you update the patch.

@jihoonson maybe this tonight :) I will upload patch :) Thanks

@jihoonson I applied your review Thanks.
and Junit expected really make it simple :)

Thanks for quick update.
It seems that some unnecessary codes are included mistakenly.
Would you mind cleaning them up?

@jihoonson Thanks for your kind advice :)
I applied your review.

+1 LGTM!

@charsyam, would you please close this pr?
Thanks.


⚠ Bofrost.be has degraded performance

In 3971737, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 905 ms

Resolved: Bofrost.be performance has improved in 6f6dbb7 after 6 minutes.


Fix wrong assertion in typlogger.combined_argtype.

Resolves #46
I also threw in few test cases for combine_argtype just in case.
Feel free to remove it if you deem it unnecessary.

This looks good. Thanks for fixing!


New IPsec Connections UI: VTI is unusable for dynamic local/remote IP

Important notices
Before you add a new report, we ask you kindly to acknowledge the following:

[x] I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
[x] I am convinced that my issue is new after having checked both open and closed issues at https://github.com/opnsense/core/issues?q=is%3Aissue

Describe the bug
With legacy IPsec configuration it is possible to :

input FQDN in ipsec remote outter IP configuration.
use interface name for local outter IP configuration.

VTI interface was then created/modified according to FQDN resolution and/or interface IP change, this was usefull when having a dynamic local IP (assigned to the interface) or a dynamic remote IP.
Main issue : With the new IPsec Connection UI it is impossible to add FQDN or interface name in the Virtual Tunnel Interfaces tab, which breaks dynamic IP VTI configurations.
IPSec configuration itself should work as we can input FQDN in local_addrs/remote_addrs fields, however the help text state that "If FQDNs are assigned, they are resolved every time a configuration lookup is done."
Secondary issue : An option to regularly check if the FQDN changed it's IP (or maybe allow to use alias) and reload ipsec and associated automatic-pass firewall rules might be useful as it will prevent unnecessary use of %any.
For now new IPsec connection UI seems broken for dynamic local/remote IP in routed/VTI setup.
To Reproduce
Steps to reproduce the behavior:

Go to VPN -> IPsec -> Virtual Tunnel Interfaces
Click on 'Add'
Try to enter anything else than an IP address in  'Local address' or 'Remote address'
See error : 'Please specify a valid address.'

Expected behavior
Allow IPsec routed/VTI configurations to works with local and remote dynamic IPs :

VTI tab -> For remote addresses : Add ability to enter FQDN and/or aliases and resolve them regularly and update VTI interface accordingly.
VTI tab -> For local addresses : Add ability to track an interface to update the VTI local IP accordingly. This would also means we need to specify if we want to track ipv4 or ipv6 of the interface.
IPSec Connection tab -> make sure FQDN are regularly resolved or allow to use aliases and reload ipsec when the IP changes.

Describe alternatives you considered
The only workaround would be to manually update the VTI interface configuration every time the local/remote IP changes.
Additional context
Some reports on the forum :
https://forum.opnsense.org/index.php?topic=35140.0
https://forum.opnsense.org/index.php?topic=33117.0
Environment
OPNsense 23.7.2-amd64

can't work reliable, see note in https://docs.opnsense.org/manual/vpnet.html#route-based-vti

No it won't be as reliable as with a static IP. But I have a working VTI configuration with dynamic IP for months now on opnsense, years even on pfsense.
As soon as you have dynamic IP somewhere, it does not work reliably anymore, VTI or not, as you will have to tolerate some downtime.
The tunnel endpoints can be changed live with a single ifconfig command. The main issue is detecting when it needs to be changed.
Unfortunately a lot of us are still stuck to dynamic IP especially on non-professional home ISP

if/when if_ipsec(4) supports the endpoints to be changed without recreating the interface, we might reconsider putting time in this, but until that time, this isn't a priority as it will break somewhere and lead to hard to explain support cases. While developing the new module we tried different options (binding to non existing endpoints, changing on updates), but it's just not reliable due to upstream reasons.

No it won't be as reliable as with a static IP. But I have a working VTI configuration with dynamic IP for months now on opnsense, years even on pfsense.

I double that. I use IPsec VTI since a few years now (I believe starting with 21.1) and did not have any major problems so far.
In my case the IPs do not change frequently, only once each few months, I'd say. Anyway, restarting the IPsec tunnel on the centre firewall is still easier than modifying the configuration (causing potential config errors) after each IP change.

You can keep using the legacy tunnels, maybe eventually we think of something that is sustainable or an upstream change will offer the possibility to change if_ipsec(4) addressing on the fly without breaking traffic at some point.

+1 for this. I'm also using a Site-to-Site Tunnel with dynamic IPs on both sides for over a year now. With some monit rules to check the tunnel health and dead peer detection enabled, the downtime was ~5-10 minutes every few weeks.

@cektom
Hello, I might have rules to check tunnel health and dead peer detection enabled. I need to put the same configuration in place

This https://github.com/opnsense/core/commit/816ecae2c5be3c3e9efa22aa653be19d32afc419 should do the trick, but now I'm looking for people to try it out.

I could successfully set this up with one dynamic IP and one static at least. (Leaving both addresses empty).

@joni1993 thanks for testing. I'll leave this here for a little while, maybe someone else want to try it as well. Merging should be relatively safe as setups with local/remote addresses set are not provisioned using the new hook.

nobody else interested in this? that's surprising....

still in use as a "legacy config" - but ever wondered why this did not work using the new way - how is this testable?

opnsense-patch 816ecae ?

Seems to be working !
I however have to figure a way to force my ISP to change my ipv4 to fully test this

@joni1993 when the old type works, it's unlikely related to this change as both are being setup quite similar, on my end a statically configure vti looks normal after an update.
https://github.com/opnsense/core/blob/bad7f2519b7747213c127826ebdb31929419b3d9/src/etc/inc/plugins.inc.d/ipsec.inc#L1717-L1825
The patch https://github.com/opnsense/core/commit/659ed117f474264f4f3d64039c6fc6dd0ae6ffa9 was released in 24.1.4  if I'm not mistaken.

Are they really set up similar?
I do not know where the generated files are coming from but looking at /usr/local/etc/swanctl/swanctl.conf````, the old method generate local_addrsandremote_addrs``` configuration for the connection, while the new method does not generate such configuration.
On the other hand the new method generates the updown event handler in the children section (which the old one does not) - and manually executing the handler like /usr/local/opnsense/scripts/ipsec/updown_event.py --connection_child 782d9cb1-8af0-4890-a8bf-007eb1934394 --action up --reqid 100 throws:
Traceback (most recent call last):
  File "/usr/local/lib/python3.9/configparser.py", line 789, in get
    value = d[option]
  File "/usr/local/lib/python3.9/collections/__init__.py", line 941, in __getitem__
    return self.__missing__(key)            # support subclasses that define __missing__
  File "/usr/local/lib/python3.9/collections/__init__.py", line 933, in __missing__
    raise KeyError(key)
KeyError: 'connection_child'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/opnsense/scripts/ipsec/updown_event.py", line 64, in <module>
    or cnf.get(section, 'connection_child') == cmd_args.connection_child:
  File "/usr/local/lib/python3.9/configparser.py", line 792, in get
    raise NoOptionError(option, section)
configparser.NoOptionError: No option 'connection_child' in section: 'vti_72691b462a734a82963ade379b5fb4b5'

Changing the updown event script as follows:

diff --git a/src/opnsense/scripts/ipsec/updown_event.py b/src/opnsense/scripts/ipsec/updown_event.py
index dd3030460..6facc4b13 100755
--- a/src/opnsense/scripts/ipsec/updown_event.py
+++ b/src/opnsense/scripts/ipsec/updown_event.py
@@ -59,9 +59,8 @@ if __name__ == '__main__':
             spds = []
             vtis = []
             for section in cnf.sections():
-                if cnf.get(section, 'reqid') == cmd_args.reqid \
-                        or cnf.get(section, 'connection_child') == cmd_args.connection_child:
-                    if section.startswith('spd_'):
+                if cnf.get(section, 'reqid') == cmd_args.reqid:
+                    if cnf.has_option(section,"connection_child") and cnf.get(section, 'connection_child') == cmd_args.connection_child and section.startswith('spd_'):
                         spds.append({
                             'reqid': cmd_args.reqid,
                             'local' : cmd_args.local,

Add the tunnel property to the interface correctly and bringing up the tunnel. Only one manual disconnect/connect was needed after changing the script - disabling and enabling the vti was not enough. (why? - when creating a vti one want's to fire the event to bring up the tunnel?)

@joni1993 what does the reqid_events.conf looks like on your end? it's unlikely there are VTI sections in the configuration when properly configured with static addresses
https://github.com/opnsense/core/blob/b27881c4361a21959a66283789f875c813bbd8d1/src/opnsense/service/templates/OPNsense/IPsec/reqid_events.conf#L21
Without sections starting with vti_ the ifconfig commands are not being executed.

I am not using static addresses.
"Phase 1" (Connections):
Local:
Remote:
"Local Authentication" (Connections):
Round: 0
Authentication: PSK
id:  [A static CNAME pointing to a DynDns domain]
"Remote Authentication" (Connections):
Round: 0
Authentication: PSK
id:
"Children" (Connections):
Mode: Tunnel
Start action: Trap+Start
DPD action: Start
Reqid: 100
Local: <IP_ADDRESS>/0
Remote: <IP_ADDRESS>/0
Pre-Shared-Keys:
Local Identifier:
Remote Identifier:
PSK:
Type: PSK
Virtual Tunnel Interface:
Reqid: 100
Local address:  (because it uses dynamic ips)
Remote address:  (because both need to be empty if one is)
Tunnel local address:  [x.y.z.1]
Tunnel remote address:  [x.y.z.2]
reqid_events:
...
[vti_6066f6a169734e1089435d68c390ff17]
reqid = 100
description = VPN
uuid = 6066f6a1-6973-4e10-8943-5d68c390ff17
...

@joni1993 you mentioned your setup worked before this change, dynamic addresses weren't supported before 21.1.4 for the new connections.

It worked when i was on 21.1.1 + manually applying the patch.
But i suspect it maybe worked because back then i did just disable the old config and enabled the new config at the same time and when applying some "old state"/IKE/Phase2 got reused for the new config - which made it seem working.
But yesterday after updating to 24.1.6, it did not work anymore, so i suspect it initially only worked because of some quirks/coincidence/leftovers-states.

if the log contains the event being processed in : https://github.com/opnsense/core/blob/b27881c4361a21959a66283789f875c813bbd8d1/src/opnsense/scripts/ipsec/updown_event.py#L55
we can add some additional logging to help local debugging, in that case just open a new ticket to request more logging in this event.

Yes it does include the line - but the script probably fails as written in my above comment - because the tunnel property is never applied.

Traceback (most recent call last):
  File "/usr/local/lib/python3.9/configparser.py", line 789, in get
    value = d[option]
  File "/usr/local/lib/python3.9/collections/__init__.py", line 941, in __getitem__
    return self.__missing__(key)            # support subclasses that define __missing__
  File "/usr/local/lib/python3.9/collections/__init__.py", line 933, in __missing__
    raise KeyError(key)
KeyError: 'connection_child'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/opnsense/scripts/ipsec/updown_event.py", line 64, in <module>
    or cnf.get(section, 'connection_child') == cmd_args.connection_child:
  File "/usr/local/lib/python3.9/configparser.py", line 792, in get
    raise NoOptionError(option, section)
configparser.NoOptionError: No option 'connection_child' in section: 'vti_72691b462a734a82963ade379b5fb4b5'

@joni1993 ah, got it, missed that part in your initial comment, I'll take a look

@joni1993 can you try https://github.com/opnsense/core/commit/b0bf317640c17874fa781846a81a39e76517fc05 ?

the event shouldn't try to enforce routing, but if we only change the outer addressing, the inner shouldn't change anyway

I agree. Somehow the Gateway Interface magically changed to some arbitrary interface...
Anyway I'd call this case closed :)


Your NFT bots are spamming Twitter. Ask them to withdraw

Posting this here for developers to boycott your projects, fork them, go elsewhere from the repos.
Your NFT bots are spamming Twitter. This is not acceptable: https://twitter.com/leashless/status/1612841794999574528
Even if you did not do this, make an official statement that you're unrelated to the spam wave. It affects most huge accounts in ETH community.

These bots will simply use any popular NFT PFP.
Just block notifications from non-followers.


irmin-pack: Add forbid_empty_dir_persistence conf

Add this conf value to irmin-pack stores:
  val forbid_empty_dir_persistence : bool
  (** If [true], irmin-pack raises [Failure] if it is asked to save the empty
      inode. This default is [false]. It should be set to [true] if the [Schema]
      of the store allows a hash collision between the empty inode and this
      string of length 1: ["\000"].

      See https://github.com/mirage/irmin/issues/1304 *)

This seems like a good change to me. Just one question: why forbid_empty_dir_persistence? (I expect the answer is: because an empty inode only arises in case the directory itself is empty.)

Good point. I could have named this differently. If you have an idea, shoot

Not suggesting a name change, just wondered about the empty inode <-> empty dir relationship. LGTM


Scrollbar & Scale slow

After completing the switch from absolute to relative positioning, the Scrollbar and Scale widgets got slow when moving the slider.
I haven't investigated yet, may be due to drawable position updates. However if there's anything that can be opimized, I'd love to hear about it. ;-)

I can confirm they are a bit "laggy" now... will take a look

Status? :-D

Profiling data doesn't support this claim (anymore?). Closed.


Migrate image builds to prow

/hold

This is not needed as we don't run Travis build for PR.

/unhold All set! The branch protection bot doesn't run very frequently--maybe every 6 hours or so, so I was waiting to see those rules update in the Settings, but it looks like they updated here also. Here goes nothing! 😄


Fix the ray links in documentation

Codecov Report

Merging #108 (0d4a61e) into master (8a0ad47) will increase coverage by 0.75%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #108      +/-   ##
==========================================
+ Coverage   61.39%   62.14%   +0.75%
==========================================
  Files          32       32
  Lines        2531     2531
  Branches      416      416
==========================================
+ Hits         1554     1573      +19
+ Misses        896      877      -19
  Partials       81       81

Impacted Files
Coverage Δ

adaptdl/adaptdl/goodput.py
99.18% <0.00%> (+1.63%)
:arrow_up:

adaptdl/adaptdl/env.py
83.33% <0.00%> (+3.33%)
:arrow_up:

adaptdl/adaptdl/sched_hints.py
58.33% <0.00%> (+8.33%)
:arrow_up:

adaptdl/adaptdl/torch/_metrics.py
88.54% <0.00%> (+10.68%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a0ad47...0d4a61e. Read the comment docs.


Regarding: Redirecting to null page after running it in IIS 8.0

Hi,
I greatly appreciate for react-adal package. I added package in my react project and started using package to authenticate users with in the organization.  [url]/signin-oidc (url was localhost in dev environment and different for server) worked totally fine in localhost. but when the code was pushed to server that has IIS 8.0. It started giving me error message 'page does not exist'. Then i removed the signin-oidc as redirect URI. It started diverting to null page. and gave errors saying page does not exist. i removed the null at the end and it goes to my home page. I really want this to work in prod environment and don't want to ask users to remove null at the end of url. what should i do to get rid of null page routing. also why signin-oidc not working on IIS 8.0. It totally works fine on my local host.

are you sure you have correctly configurated iis for SPA application?
routing is client side so for every url IIS should return index.html
try search on google for it.
regards

Hi, Yes it is correctly configured, we are using following web.config:

<system.webServer>
    <!-- indicates that the server.js file is a node.js application
    to be handled by the iisnode module -->

    <handlers>
        <add name="iisnode" path="server.js" verb="*" modules="iisnode" />
    </handlers>

    <rewrite>
        <rules>
            <rule name="sendToNode">
                <match url="/*" />
                <action type="Rewrite" url="server.js" />
            </rule>
        </rules>
    </rewrite>

</system.webServer>

not sure, where it is going wrong. localhost:xxxx/signin-oidc works but with hostname/appname/signin-oidc just sends back hostname/appname/signin-oidc/#id_token=xxxxxxxx
Do you have any examples of re-routing. i am not sure how it works on localhost but not working on clientside server.


CMake updated to use /Zc:inline and /Zc:lambda

The /Zc:inline switch enforces C++11 rules on inline visibility which reduces redundant comdats in each OBJ file (i.e. all the DirectXMath inline functions you didn't call in that translation unit). This switch is on by default with MSBuild, but is not on by default for command-line builds. This update adds this switch to CMake builds as well.
This reduces the size of the Release obj/lib files in half.
There's also a /Zc:lambda conformance switch for VS 2019 16.8 or later which I'm enabling for coverage.

Related updates for test suite: https://github.com/walbourn/directxtextest/commit/5f6258d09fc60b765999fdb4e76b34bcbe73a694 https://github.com/walbourn/directxtextest/commit/5f6258d09fc60b765999fdb4e76b34bcbe73a694


Replace custom planner with move_base

Currently, wheele uses the following nodes:
avoid_obstacles/avoid_obs to receive /scan and publish /costmap
avoid_obstacles/astar to receive /costmap and publish /path
avoid_obstacles/nav_states to subscribe to /path, receive cone poses, and publish /cmd_vel
Replace these three nodes with the ros navigation stack (move_base)
The issue we had before with move_base was touching a cone because it is an obstacle in the costmap.

Discussed this during today's build session. Decided to try using the stock move_base/navigation stack on ROS Noetic. Plan is to upgrade Wheele's Pi 3B+ from Kinetic to Noetic. Will use new SD card so we're sure to keep a working copy in case we want to fall back.


[CQLReplicator on Glue] Change number of tiles during replication

During a replication, could we change the number of tiles?
e.g.
cqlreplicator --state init
cqlreplicator --state run --tiles 8
cqlreplicator --state request-stop
cqlreplicator --state run --tiles 16

Tiles are static and defined during the discovery stage.


Fix IP compatability for 1.17

This also does some cleaning that was missed during the initial update, including

using artifacts that don't exist besides haven's mavenLocal
using java 8 for 1.17
missing a gradle wrapper

I didn't use CurseMaven for Immersive Portals because it JIJ's some internal mods, so we have to use the jitpack way.

Thanks - have been using this locally & it works fine. I'd also like to push out changes to prevent the IP Mixin from loading when the mod isn't present to prevent log spam soon.


Bump: Sentry-cocoa to 6.1.4

:scroll: Description
Bump: Sentry-cocoa to 6.1.4
:bulb: Motivation and Context
#271
:green_heart: How did you test it?
running on simulator
:pencil: Checklist

[X] I reviewed submitted code
[ ] I added tests to verify changes
[X] All tests passing
[X] No breaking changes

:crystal_ball: Next steps

Codecov Report

Merging #278 (be0a229) into main (b5d1ae1) will decrease coverage by 5.71%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #278      +/-   ##
==========================================
- Coverage   86.42%   80.71%   -5.72%
==========================================
  Files          52        5      -47
  Lines        1739      223    -1516
==========================================
- Hits         1503      180    -1323
+ Misses        236       43     -193

Impacted Files
Coverage Δ

dart/lib/src/utils.dart

dart/lib/src/diagnostic_logger.dart

dart/lib/src/platform_checker.dart

dart/lib/src/hub_adapter.dart

dart/lib/src/protocol/sentry_stack_frame.dart

dart/lib/src/noop_hub.dart

dart/lib/src/noop_client.dart

dart/lib/src/protocol/request.dart

dart/lib/src/protocol/breadcrumb.dart

dart/lib/src/protocol/app.dart

... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5d1ae1...be0a229. Read the comment docs.

Codecov Report

Merging #278 (be0a229) into main (b5d1ae1) will decrease coverage by 5.71%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #278      +/-   ##
==========================================
- Coverage   86.42%   80.71%   -5.72%
==========================================
  Files          52        5      -47
  Lines        1739      223    -1516
==========================================
- Hits         1503      180    -1323
+ Misses        236       43     -193

Impacted Files
Coverage Δ

dart/lib/src/utils.dart

dart/lib/src/diagnostic_logger.dart

dart/lib/src/platform_checker.dart

dart/lib/src/hub_adapter.dart

dart/lib/src/protocol/sentry_stack_frame.dart

dart/lib/src/noop_hub.dart

dart/lib/src/noop_client.dart

dart/lib/src/protocol/request.dart

dart/lib/src/protocol/breadcrumb.dart

dart/lib/src/protocol/app.dart

... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5d1ae1...be0a229. Read the comment docs.

LGTM, but CI is complaining.

https://github.com/getsentry/sentry-dart/pull/279

LGTM, but CI is complaining.

https://github.com/getsentry/sentry-dart/pull/279