Completion request is sometimes sent on stale document contents

Dear vscode langserver devs,
I'm getting some reports from users that when using triggerCharacters, vscode language client is sending the completion request before a didChanges request when one of the triggerCharacters is used.
This is far from good as our server will return stale completion info then.
Moreover, I can't reproduce locally, but I think such users have a way slower machine so it could be some kind of race.
Do you think that it is a valid behavior to send the completion request before the didChanges request on an edit?

After looking a bit at the code, it seems to me that this could actually be a VS Code issue, if that's the case I'd appreciate if you could transfer the issue.

Which version of the LSP libraries are you using. I fixed two issues for the upcoming 8.1.0 release (which is available as next.5 right now) were didChange requests were sent too late. However this only happened when using full test document sync. Do you use this?

Hi @dbaeumer , thanks a lot for the help!
Indeed we are using 8.0.2 . @Alitzer, can you try with 8.1.0 and see if the problem goes away?
Yes, we use for now full document sync for didChanges, our server client are at https://github.com/ejgallego/coq-lsp

This does appear to resolve our issue. Do you have any idea why this bug is not observed more widely?

Most servers use incremental document sync because it is far more efficient (a lot less data to send) and the problem doesn't show up with incremental sync. Have you ever thought about using incremental sync instead.

I will close the issue since it seems to be addressed in the upcoming 8.1.0 release.

Thanks a lot folks for researching and testing this, I'm glad it seems to be solved.
@dbaeumer , incremental sync is in the roadmap for our server, however it is low priority, in our context there is little diference as the overhead of checking itself is way larger, but indeed we will get to it.


IR->Caffe?

Hi,
In the Caffe directory there is no instruction for IR ->Caffe conversion. Is this  conversion supported?
I want to convert the weights in keras to caffe. How can I do this conversion using MMdnn?
Thank you.

Please follow the steps on the issue #66. Thanks.

Hi @TobeyQin ,
I tried to execute step 2 of the link. It gave the following error: "raise NotImplementedError("Destination [Caffe] is not implemented yet."
Do I have to reinstall MMdnn to get IRtoCaffe?
Thank you.

Hi, I reinstalled MMdnn.  Now I get the following error:
Traceback (most recent call last):   File "/usr/lib/python3.6/runpy.py", line 193, in _run_module_as_main     "__main__", mod_spec)   File "/usr/lib/python3.6/runpy.py", line 85, in _run_code     exec(code, run_globals)   File "/home/anwesha/.local/lib/python3.6/site-packages/mmdnn/conversion/_script/IRToCode.py", line 112, in <module>     _main()   File "/home/anwesha/.local/lib/python3.6/site-packages/mmdnn/conversion/_script/IRToCode.py", line 107, in _main     ret = _convert(args)   File "/home/anwesha/.local/lib/python3.6/site-packages/mmdnn/conversion/_script/IRToCode.py", line 9, in _convert     from mmdnn.conversion.caffe.caffe_emitter import CaffeEmitter   File "/home/anwesha/.local/lib/python3.6/site-packages/mmdnn/conversion/caffe/caffe_emitter.py", line 13, in <module>     import cntk ModuleNotFoundError: No module named 'cntk'

I installed cntk and added the path. I could execute step 2 and 3 and generate the caffemodel. However, testing it with test data gave accuracy=0.08 while the actual accuracy is 79% in keras.

Hi @anwesha94,
what is your keras model data format?  Caffe model takes NCHW data (channel first). If your keras model data format is NHWC (channel last, if you use tensorflow as backend), you should swapaxis your input data for caffe to use.
Or you can provide your model for us to test. Thanks.

Yes, I am using tensorflow as backend. It is using channel last format. I am using the cifar10 dataset for training and testing. I have share the weights here in a zip file:
keras_cifar10_weight_0.zip

Then you should transpose your input data like caffe_input = np.transpose(image, [0, 3, 1, 2]) then feed into caffe, to get right result.

Hi, I changed the axes of input images to (2,0,1). All the predictions are 0. There is something wrong with my conversion. What can be the possible error?

@TobeyQin will help to investigate this problem, thanks.

who can help me solve this problem from IR to caffe. Thank you so much.
Parse file [IR/lenet_finetune.pb] with binary format successfully.
Traceback (most recent call last):
File "/Users/diqiu/anaconda/lib/python2.7/runpy.py", line 174, in _run_module_as_main
"main", fname, loader, pkg_name)
File "/Users/diqiu/anaconda/lib/python2.7/runpy.py", line 72, in _run_code
exec code in run_globals
File "/Users/diqiu/meituan/framework/MMdnn/mmdnn/conversion/_script/IRToCode.py", line 112, in
_main()
File "/Users/diqiu/meituan/framework/MMdnn/mmdnn/conversion/_script/IRToCode.py", line 107, in _main
ret = _convert(args)
File "/Users/diqiu/meituan/framework/MMdnn/mmdnn/conversion/_script/IRToCode.py", line 55, in _convert
emitter.run(args.dstModelPath, args.dstWeightPath, args.phase)
File "mmdnn/conversion/caffe/caffe_emitter.py", line 136, in run
super(CaffeEmitter, self).run(dstNetworkPath, dstWeightPath, phase)
File "mmdnn/conversion/common/DataStructure/emitter.py", line 21, in run
self.save_code(dstNetworkPath, phase)
File "mmdnn/conversion/common/DataStructure/emitter.py", line 53, in save_code
code = self.gen_code(phase)
File "mmdnn/conversion/caffe/caffe_emitter.py", line 124, in gen_code
func(current_node)
File "mmdnn/conversion/caffe/caffe_emitter.py", line 208, in emit_Pool
IR_node.get_attr('pads')[1],
TypeError: 'NoneType' object has no attribute 'getitem'

Hi @qiudi0127 , could you provide related files (models) for us to debug? Thanks.

@qiudi0127
The input layer name should be "data" in the deploy file. Currently the deploy generated in mmdnn names it as <...>_input. Change it to data and check if it works. I had a similar problem for accessing the blobs. This solved for me. However, I didn't get expected testing results.


[Dash] Add theme switcher.

[x] Create theme switcher.
[x] Create toggle button.

Created theme switcher: https://github.com/lofustudio/cookie/commit/76da9c2bb2e13b989ed8bbd1d2ea07e0cd2a4405

Fixed at: https://github.com/lofustudio/cookie/commit/1c0e77825da4f8151e0f0d8422e10e9e9dbfbfd6


Allow dataset documentation repositories to allow different branch names (e.g., main)

I noticed this file, which helps with syncing documentation repository updates, has a reference to master hard-coded. I'm not sure if there's a way to accommodate main/master branches? Or if branch name needs to be specified at the dataset level?

Will leave for another day if we want to organize a mass-renaming of documentation repositories to 'main'. Thanks!


HTML-Code Errors

Please check that HTML-Code is correct:
Check all pages with
https://validator.w3.org

Please analyze

Still Errors found i.e.

[ ] https://swiss.github.io/styleguide/en/tables.html

[ ] https://admin-ch.github.io/styleguide/en/form-elements.html

[ ] https://admin-ch.github.io/styleguide/en/general.html

[ ] https://admin-ch.github.io/styleguide/en/hierarchical-navigation.html

[ ] https://admin-ch.github.io/styleguide/en/header.html

[ ] https://admin-ch.github.io/styleguide/en/content-navigation.html

[ ] https://admin-ch.github.io/styleguide/en/footer.html

[ ] https://admin-ch.github.io/styleguide/en/standard-elements.html

[ ] https://admin-ch.github.io/styleguide/en/widgets.html

[ ] https://admin-ch.github.io/styleguide/en/functions.html

[ ] https://admin-ch.github.io/styleguide/en/teaser.html

[ ] https://admin-ch.github.io/styleguide/en/multimedia.html

[ ] https://admin-ch.github.io/styleguide/en/search.html

[ ] https://admin-ch.github.io/styleguide/en/ordering-checkout.html

[ ] https://admin-ch.github.io/styleguide/en/pages/01.homepage-global-nav.html

[ ] https://admin-ch.github.io/styleguide/en/pages/05.publications.html

[ ] https://admin-ch.github.io/styleguide/en/pages/09.subpage.html

[ ] https://admin-ch.github.io/styleguide/en/pages/02.home-without-nav.html

[ ] https://admin-ch.github.io/styleguide/en/pages/06.detail.html

[ ] https://admin-ch.github.io/styleguide/en/pages/03.preview.html

[ ] https://admin-ch.github.io/styleguide/en/pages/07.forms.html

[ ] https://admin-ch.github.io/styleguide/en/pages/04.preview-without-nav.html

[ ] https://admin-ch.github.io/styleguide/en/pages/08.results.html


Refactored user manage_home to conform to Chef 13 syntax.

Fixes issue described in #144

Thanks for the pointer, we at transportapi have been using our own internal fork with some useful patches for us (e.g. enabling live_stream), will see about moving over to your fork https://github.com/RiotGamesCookbooks/rbenv-cookbook/compare/master...transportapi:master


Flink-operator pod crashes when FlinkCluster object being created

Hi, I tried to deploy latest version:
Got following results,
FlinkCluster Object:
$ kubectl get FlinkCluster -A
NAMESPACE   NAME                         VERSION   STATUS     AGE
default     flinksessioncluster-sample   1.14      Creating   21s

Flink-operator logs:
$ kubectl logs -n flink-operator-system -l app=flink-operator --all-containers
I0304 10:06:26.477230       1 main.go:190] Valid token audiences:
I0304 10:06:26.477540       1 main.go:262] Generating self signed cert as no cert is provided
I0304 10:06:27.043133       1 main.go:311] Starting TCP socket on <IP_ADDRESS>:8443
I0304 10:06:27.043399       1 main.go:318] Listening securely on <IP_ADDRESS>:8443
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile(0xc0003e8a50, {0x1a8efd8, 0xc00017f5f0}, {{{0xc00077cd10, 0x17ac8a0}, {0xc000120f00, 0x413a94}}})
	/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.11.1/pkg/internal/controller/controller.go:114 +0x26f
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler(0xc0003e8a50, {0x1a8ef30, 0xc00058cdc0}, {0x16e1420, 0xc00082ec60})
	/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.11.1/pkg/internal/controller/controller.go:311 +0x33e
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem(0xc0003e8a50, {0x1a8ef30, 0xc00058cdc0})
	/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.11.1/pkg/internal/controller/controller.go:266 +0x205
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2()
	/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.11.1/pkg/internal/controller/controller.go:227 +0x85
created by sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2
	/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.11.1/pkg/internal/controller/controller.go:223 +0x357

K8s version:
$ kubectl version
Client Version: version.Info{Major:"1", Minor:"23", GitVersion:"v1.23.4", GitCommit:"e6c093d87ea4cbb530a7b2ae91e54c0842d8308a", GitTreeState:"clean", BuildDate:"2022-02-16T12:30:48Z", GoVersion:"go1.17.6", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"21", GitVersion:"v1.21.10", GitCommit:"a7a32748b5c60445c4c7ee904caf01b91f2dbb71", GitTreeState:"clean", BuildDate:"2022-02-16T11:18:16Z", GoVersion:"go1.16.14", Compiler:"gc", Platform:"linux/amd64"}
WARNING: version difference between client (1.23) and server (1.21) exceeds the supported minor version skew of +/-1

Operator version: v0.4.0-beta.1

I fix this by apply the certs by myself
https://github.com/haoxins/poc-flink-k8s-native/blob/main/certificates/kustomization.yaml
and I just created a issue for discussing how to add these into the Helm charts
see https://github.com/spotify/flink-on-k8s-operator/issues/268

I fix this by apply the certs by myself
https://github.com/haoxins/poc-flink-k8s-native/blob/main/certificates/kustomization.yaml
and I just created a issue for discussing how to add these into the Helm charts
see #268

It just appears in flink session cluster。

@Sudokamikaze How are you installing the operator?

@Sudokamikaze How are you installing the operator?

@regadas I deployed it via Helm chart
Steps to reproduce:

Clone repo with master branch, go to helm-chart/flink-operator
Open Values.yaml and put: default to watchNamespace
Deploy example from config/samples/flinkoperator_v1beta1_flinksessioncluster.yaml
Check logs of operator

Can't reproduce it anymore on https://github.com/spotify/flink-on-k8s-operator/releases/tag/v0.4.0-beta.4

I fix this by apply the certs by myself
https://github.com/haoxins/poc-flink-k8s-native/blob/main/certificates/kustomization.yaml
and I just created a issue for discussing how to add these into the Helm charts
see #268

Thank you for the solution!


security-types added

The main difference between Security Definition Request (c) and Security Type Request (v) is that the former requests a detailed description of a specific security, while the latter requests a list of all security types available.A Security Definition Request (c) message is used to request detailed information about a specific security. This information can include the security's ticker symbol, CUSIP number, exchange, maturity date, and other relevant details. The Security Definition Request (c) message is typically used by traders who want to know more about a particular security before making a trade.A Security Type Request (v) message is used to request a list of all security types available. This information can be used by traders to find securities that meet their investment criteria. The Security Type Request (v) message is typically used by traders who are new to the market and are not familiar with all of the available securities.Here is a table that summarizes the key differences between Security Definition Request (c) and Security Type Request (v):

Feature
Security Definition Request (c)
Security Type Request (v)

Purpose
Requests detailed information about a specific security
Requests a list of all security types available

Information returned
Ticker symbol, CUSIP number, exchange, maturity date, and other relevant details
List of all security types available

Typical use
By traders who want to know more about a particular security before making a trade
By traders who are new to the market and are not familiar with all of the available securities

what about security list request and security type request?

what about security list request and security type request?

The main difference between Security List Request (x) and Security Type Request (v) is that the former requests a list of securities that match specific criteria, while the latter requests a list of all security types available.A Security List Request (x) message is used to request a list of securities that match specific criteria. This information can be used by traders to find securities that meet their investment criteria. The Security List Request (x) message is typically used by traders who are looking for specific securities, such as those that meet certain financial criteria or that are traded on a particular exchange.A Security Type Request (v) message is used to request a list of all security types available. This information can be used by traders to find securities that meet their investment criteria. The Security Type Request (v) message is typically used by traders who are new to the market and are not familiar with all of the available security types.Here is a table that summarizes the key differences between Security List Request (x) and Security Type Request (v):

Feature
Security List Request (x)
Security Type Request (v)

Purpose
Requests a list of securities that match specific criteria
Requests a list of all security types available

Information returned
List of securities that match specific criteria
List of all security types available

Typical use
By traders who are looking for specific securities
By traders who are new to the market and are not familiar with all of the available security types

Security Type Request (MsgType = v, FIXML = SecTypReq)The Security Type Request (v) message is used to return a list of security types available from a counterparty or market.The request can include a specific TradingSessionID (336) for which Security Types should be returned.TAGFIELD NAMEFIXMLREQ'DCOMMENTS<Standard Message Header>YMsgType = v320SecurityReqID@ReqIDY58Text@TxtNComment, instructions, or other identifying information.354EncodedTextLen@EncTxtLenCMust be set if EncodedText (355) field is specified and must immediately precede it.355EncodedText@EncTxtCEncoded (non-ASCII characters) representation of the Text (58) field in the encoded format specified via the MessageEncoding (347) field.336TradingSessionID@SesIDNOptional Trading Session Identifier to specify a particular trading session for which you want to obtain a list of securities that are tradeable.625TradingSessionSubID@SesSubN460Product@ProdNUsed to qualify which security types are returned167SecurityType@SecTypNUsed to qualify which security type is returned762SecuritySubType@SubTypNUsed to qualify which security types are returned<Standard Message Trailer>YSecurity Type Request (MsgType = v, FIXML = SecTypReq)
The [Security Type Request (v)](https://btobits.com/fixopaedia/fixdic44/message_Security_Type_Request_v.html) message is used to return a list of security types available from a counterparty or market.

Security Types (MsgType = w, FIXML = SecTyps)The Security Types (w) message is used to return a list of security types available from a counterparty or market.TAGFIELD NAMEFIXMLREQ'DCOMMENTS<Standard Message Header>YMsgType = w320SecurityReqID@ReqIDY322SecurityResponseID@RspIDYIdentifier for the security response message323SecurityResponseType@RspTypYThe result of the security request identified by SecurityReqID (320)557TotNoSecurityTypes@TotNoSecTypsNIndicates total number of security types in the event that multiple Security Type messages are used to return results893LastFragment@LastFragmentNIndicates if this message in a fragmented response558NoSecurityTypesSecTN=>167SecurityType@SecTypCRequired if NoSecurityTypes (558) > 0=>762SecuritySubType@SubTypN=>460Product@ProdN=>461CFICode@CFIN58Text@TxtNComment, instructions, or other identifying information.354EncodedTextLen@EncTxtLenCMust be set if EncodedText (355) field is specified and must immediately precede it.355EncodedText@EncTxtCEncoded (non-ASCII characters) representation of the Text (58) field in the encoded format specified via the MessageEncoding (347) field.336TradingSessionID@SesIDNOptional Trading Session Identifier to specify a particular trading session for which you want to obtain a list of securities that are tradeable.625TradingSessionSubID@SesSubN263SubscriptionRequestType@SubReqTypNSubscribe or unsubscribe for security status to security specified in request.<Standard Message Trailer>YSecurity Types (MsgType = w, FIXML = SecTyps)
The [Security Types (w)](https://btobits.com/fixopaedia/fixdic44/message_Security_Types_w.html) message is used to return a list of security types available from a counterparty or market.

 here is a table of the fields in a Security Type Request Reject message:

Field
Name
FIXML
Required
Comments

320
SecurityReqID
@ReqID
Y
Identifier for the security request message that was rejected

350
RejectReason
@RejRsn
Y
Reason for rejecting the security request

58
Text
@Txt
N
Comment, instructions, or other identifying information

354
EncodedTextLen
@EncTxtLen
C
Must be set if EncodedText (355) field is specified and must immediately precede it.

355
EncodedText
@EncTxt
C
Encoded (non-ASCII characters) representation of the Text (58) field in the encoded format specified via the MessageEncoding (347) field.


molecule multiple test roles

  I want to use molecule and integrate it in my Gitlab CI/CD chain to test all my roles that are in a single directory but for the moment I can only test on one role at a time and not the whole directory that contains the roles. I know it needs the molecule.yml file to run the tests but how can I automate this on each role at the same time?

Need help!

Please take a look at the FAQ entry Does Molecule support monorepos?
It's also often done in a CI job where the roles are discovered through a custom script and then molecule is executed against those roles.


Use JSON assert to improve test stability

This PR fixes the non deterministic behaviour of 2 tests in the module xchange-stream-bitmex. This happens as the test assumes the order of keys in a JSON, which is not guaranteed. It has been detected using NonDex tool.
Reproduction of issue

mvn install -pl xchange-stream-bitmex
mvn -pl xchange-stream-bitmex edu.illinois:nondex-maven-plugin:2.1.1:nondex -Dtest=info.bitrich.xchangestream.bitmex.BitmexStreamingTest

[ERROR] Tests run: 2, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 0.735 s <<< FAILURE! -- in info.bitrich.xchangestream.bitmex.BitmexStreamingTest
[ERROR] info.bitrich.xchangestream.bitmex.BitmexStreamingTest.shouldGetCorrectSubscribeMessage -- Time elapsed: 0.717 s <<< FAILURE!
org.junit.ComparisonFailure: expected:<{"[op":"subscribe","args":["name"]]}> but was:<{"[args":["name"],"op":"subscribe"]}>
[ERROR] info.bitrich.xchangestream.bitmex.BitmexStreamingTest.shouldGetCorrectUnsubscribeMessage -- Time elapsed: 0.002 s <<< FAILURE!
org.junit.ComparisonFailure: expected:<{"[op":"unsubscribe","args":["name"]]}> but was:<{"[args":["name"],"op":"unsubscribe"]}>
	at org.junit.Assert.assertEquals(Assert.java:117)
	at org.junit.Assert.assertEquals(Assert.java:146)
	at info.bitrich.xchangestream.bitmex.BitmexStreamingTest.shouldGetCorrectUnsubscribeMessage(BitmexStreamingTest.java:21)

Root cause
The test uses BitmexStreamingService to serialize an BitmexWebSocketSubscriptionMessage object using jackson library's object mapper. This does not guarantee ordering of fields in the resulting JSON string because internally Jackson uses Java's getDeclaredFields() which is unordered Doc.
Stack trace from writeValueAsString to getDeclaredFields:
java.base/java.lang.Class.getDeclaredFields(Class.java:2248)
com.fasterxml.jackson.databind.introspect.AnnotatedFieldCollector._findFields(AnnotatedFieldCollector.java:73)
com.fasterxml.jackson.databind.introspect.AnnotatedFieldCollector.collect(AnnotatedFieldCollector.java:48)
com.fasterxml.jackson.databind.introspect.AnnotatedFieldCollector.collectFields(AnnotatedFieldCollector.java:43)
com.fasterxml.jackson.databind.introspect.AnnotatedClass._fields(AnnotatedClass.java:371)
com.fasterxml.jackson.databind.introspect.AnnotatedClass.fields(AnnotatedClass.java:343)
com.fasterxml.jackson.databind.introspect.POJOPropertiesCollector._addFields(POJOPropertiesCollector.java:494)
com.fasterxml.jackson.databind.introspect.POJOPropertiesCollector.collectAll(POJOPropertiesCollector.java:421)
com.fasterxml.jackson.databind.introspect.POJOPropertiesCollector.getJsonValueAccessor(POJOPropertiesCollector.java:270)
com.fasterxml.jackson.databind.introspect.BasicBeanDescription.findJsonValueAccessor(BasicBeanDescription.java:258)
com.fasterxml.jackson.databind.ser.BasicSerializerFactory.findSerializerByAnnotations(BasicSerializerFactory.java:391)
com.fasterxml.jackson.databind.ser.BeanSerializerFactory._createSerializer2(BeanSerializerFactory.java:225)
com.fasterxml.jackson.databind.ser.BeanSerializerFactory.createSerializer(BeanSerializerFactory.java:174)
com.fasterxml.jackson.databind.SerializerProvider._createUntypedSerializer(SerializerProvider.java:1501)
com.fasterxml.jackson.databind.SerializerProvider._createAndCacheUntypedSerializer(SerializerProvider.java:1449)
com.fasterxml.jackson.databind.SerializerProvider.findValueSerializer(SerializerProvider.java:550)
com.fasterxml.jackson.databind.SerializerProvider.findTypedValueSerializer(SerializerProvider.java:828)
com.fasterxml.jackson.databind.ser.DefaultSerializerProvider.serializeValue(DefaultSerializerProvider.java:308)
com.fasterxml.jackson.databind.ObjectMapper._writeValueAndClose(ObjectMapper.java:4624)
com.fasterxml.jackson.databind.ObjectMapper.writeValueAsString(ObjectMapper.java:3869)

This can cause test flakiness as detected by the tool.
Fix
There are 2 approaches:

Not using additional external library: jackson is already present in the module and this can be used to convert JSON strings to a JSON tree and compare.
Code change: https://github.com/rRajivramachandran/XChange/commit/ca3b36f1614c7308b40cf0abb7b305c98c95616b

Potential future issue:
In case that the JSON value is an array consisting of more elements in future, this approach wont work unless the array elements are ordered in the same way in both strings. Currently we only have a single element "name" in the array. For example:     Assert.assertEquals(         objectMapper.readTree("{\"args\":[\"name1\",\"name2\"]}"), objectMapper.readTree("{\"args\":[\"name2\",\"name1\"]}"));
would fail
To handle this a lot of boilerplate would have to be written and maintained. In this regard I prefer approach 2

Using external library specifically for JSON assertions which handles these cases and many more under the hood: Skyscreamer JSONssert
The library is well known and widely used. It has modes to compare two JSON strings which allows mentioning if array orderings must be strictly verified and also if the difference between the two objects can be any extra fields. Using this will prevent having to maintain any custom logic which is outside the scope of this project just for the sake of tests. This is the apporoach in the PR

As a developer you would have a better idea on the use cases and future extensions of the project. So, I would request your opinion and I am open to updating this PR.
Verification of fix

All tests in the class pass(mvn -pl xchange-stream-bitmex test -Dtest=info.bitrich.xchangestream.bitmex.BitmexStreamingTest)
All tests in class pass when run with nondex(mvn -pl xchange-stream-bitmex edu.illinois:nondex-maven-plugin:2.1.1:nondex -Dtest=info.bitrich.xchangestream.bitmex.BitmexStreamingTest)

Good explanation of both approaches. I think you can open a real PR to discuss with the developers. Eventually, they know the exact use cases.


Replace node socket server

Maybe replace it with https://github.com/Cherry-Pie/websocket or as an alternative for people who can't run node, need to investigate

Had a play around, nah going to stick with node.js/socket.io


Add capabilities to read and interpolate from LES data

This will be used in GCM driven single column cases.

Closed by #2922


[BUG] permissions don't work

Describe the bug
I'm configuring the permissions in luckyperms and I also tried in ftbranks, but I keep saying that it doesn't have permission
Expected behavior
I expected that the player that is in the default rank could use /rtp after I set the permissions
Screenshots
https://prnt.sc/9hn-gbt8zfKO
Desktop (please complete the following information):

RandomTP version: [6.3.0]
Minecraft Version: [1.18.2]
Machine Software [Windows]

This should be fixed in the latest release. If not make sure to re-open the issue or create a new one.


Experimenting with the number of sentences selected

I read in the paper that for extractive summarization, you only take the top 3 sentence scores, There's no explicit mention of this in the code, is there any way i could modify this to get more sentences and experiment a little?

Hi, this is now hardcoded in the codes. If you want, you can change the line 282 in trainer.py by replacing 3 with the number you want.
                               if ((not cal_oracle) and (not self.args.recall_eval) and len(_pred) == 3):

@nlpyang, I had a few more doubts, mind if I ask?

please ask

@nlpyang so, is there any way to load the training set in the test set way.
I was going through your code, and i found that when you are test mode you also load src and tgt text.
The reason i want to do this, is to like display all 3 one after the other. The source text, the output by the model and the gold reference and maybe analyse them.
The first thing i did was load the weights into the model, but when i tried to load the training set in the test format i ran into an error.
I tried doing something like this in jupyter:
test_iter =data_loader.Dataloader(args, load_dataset(args, 'train', shuffle=False),
                                  args.batch_size, device, shuffle=False, is_test=True)

I kept running into this error :
FileNotFoundError: [Errno 2] No such file or directory: '../data/bert_data/cnndm.train.pt'

this probably happens because the execution is going into the :
# Only one inputters.*Dataset, simple!
     98         pt = args.bert_data_path + '.' + corpus_type + '.pt'
---> 99       yield _lazy_dataset_loader(pt, corpus_type)

Any idea how i could go about solving this problem?
Thank you so much for your help.

The error shows you are passing the run argument for -bert_data_path
change it to '../bert_data'

The error shows you are passing the wrong argument for -bert_data_path
change it to '../bert_data'

The error shows you are passing the wrong argument for -bert_data_path
change it to '../bert_data/cnndm'

@nlpyang im sorry to ask but the gold summaries are gold standard or the oracle summaries?

they are gold standard

Excuse me. What do you mean by gold standard here?

The error shows you are passing the wrong argument for -bert_data_path
change it to '../bert_data/cnndm'

Sorry bothering. I came into the same question and I changed the argument command as you said, but it didn't work. Do you have any other solutions?
Thanks!

@Machine-Tom reference summaries, human-written highlights


VMware Fusion can't find IP address on Big Sur

I'm not sure why, but instead of using vmrun, the vmwarefusion driver attempts to find the guest IP through roundabout ways by looking into DHCP lease files.
With the advent of Big Sur, this doesn't work anymore as vmnet1/vmnet8 have disappeared in favour of a native bridge100 interface.
Comparatively, vmrun getGuestIPAddress just works:
~> vmrun list
Total running VMs: 1
/Users/lloeki/.docker/machine/machines/fusion/fusion.vmx
~> vmrun checkToolsState /Users/lloeki/.docker/machine/machines/fusion/fusion.vmx
running
~> vmrun getGuestIPAddress /Users/lloeki/.docker/machine/machines/fusion/fusion.vmx
<IP_ADDRESS>

I suppose it might just be a case of writing a getIPfromVmrun() or something.

Well, this did the trick:
diff --git a/drivers/vmwarefusion/fusion_darwin.go b/drivers/vmwarefusion/fusion_darwin.go
index fb22c96a..b1dcff5e 100644
--- a/drivers/vmwarefusion/fusion_darwin.go
+++ b/drivers/vmwarefusion/fusion_darwin.go
@@ -194,6 +194,11 @@ func (d *Driver) GetIP() (string, error) {
                return "", err
        }

+       // attempt to find the address from vmrun
+       if ip, err := d.getIPfromVmrun(); err == nil {
+               return ip, err
+       }
+
        // attempt to find the address in the vmnet configuration
        if ip, err := d.getIPfromVmnetConfiguration(macaddr); err == nil {
                return ip, err
@@ -535,6 +540,18 @@ func (d *Driver) getIPfromVmnetConfiguration(macaddr string) (string, error) {
        return "", fmt.Errorf("IP not found for MAC %s in vmnet configuration files", macaddr)
 }

+func (d *Driver) getIPfromVmrun() (string, error) {
+       vmx := d.vmxPath()
+
+       ip := regexp.MustCompile(`(\d+\.\d+\.\d+\.\d+)`)
+       stdout, _, _ := vmrun("getGuestIPAddress", vmx)
+       if matches := ip.FindStringSubmatch(stdout); matches != nil {
+               return matches[1], nil
+       }
+
+       return "", fmt.Errorf("could not get IP from vmrun")
+}
+
 func (d *Driver) getIPfromVmnetConfigurationFile(conffile, macaddr string) (string, error) {
        var conffh *os.File
        var confcontent []byte

is there a work for this right now? do you have a compiled binary you could share?

Compiled with go 1.13 from my branch at #4847.
docker-machine.tar.gz

awesome, very much appreciated!!!

your binary doesn't work for me, it just sits looping over the legacy files.

i found another way around this in my setup.
 /var/db/vmware/vmnet-dhcpd-vmnet8.leases contains the lease/ip information being looked for, so i just updated that with the ip and mac address for the vm obtained with a call to arp -a.

I just created a new one with docker-machine create -d vmwarefusion foo.
It seemed to fail to work right away, blocking when waiting for the VM to come up, and ultimately bailing out after 120s of not getting an IP (which docker-machine ls failed to show, although the VM was shown as running).
But a stop+start made it show the proper IP:
$ docker-machine ls
NAME     ACTIVE   DRIVER         STATE     URL                       SWARM   DOCKER      ERRORS
foo      -        vmwarefusion   Running   tcp://<IP_ADDRESS>:2376           Unknown     Unable to query docker version: Get https://<IP_ADDRESS>:2376/v1.15/version: x509: certificate signed by unknown authority
fusion   *        vmwarefusion   Running   tcp://<IP_ADDRESS>:2376           v19.03.12

It still failed though:
$ docker-machine regenerate-certs foo
Regenerate TLS machine certs?  Warning: this is irreversible. (y/n): y
Regenerating TLS certificates
Waiting for SSH to be available...
Too many retries waiting for SSH to be available.  Last error: Maximum number of retries (60) exceeded

it's interesting you can get a machine to create using default driver, i have to use docker-machine-driver-vmware to get mine to create.
in any case, if you edit update the lease file by hand, doing a rm and then a create should work w/o issue b/c the vm should be re-created using the same ip address (assuming the same name)

Just created a machine successfully from A to Z:
Open a first terminal window:
$ bin/docker-machine -D create -d vmwarefusion foo
# wait for ip find loop, do not interrupt it

Then, open a second terminal window:
$ bin/docker-machine ls
NAME     ACTIVE   DRIVER         STATE     URL   SWARM   DOCKER    ERRORS
foo      -        vmwarefusion   Running                 Unknown   IP not found for MAC 00:0c:29:8c:d5:20 in DHCP leases

It looks like VMware tools don't come up properly at this stage, but it does run vmrun getGuestIPAddress each time.  In that
$ bin/docker-machine stop foo
Stopping "foo"...
Machine "foo" was stopped.
$ bin/docker-machine start foo
Starting "foo"...
Machine "foo" was started.
Waiting for SSH to be available...
Detecting the provisioner...
Started machines may have new IP addresses. You may need to re-run the `docker-machine env` command.
$ docker-machine ls
NAME     ACTIVE   DRIVER         STATE     URL                       SWARM   DOCKER    ERRORS
foo      -        vmwarefusion   Running   tcp://<IP_ADDRESS>:2376           Unknown   Unable to query docker version: Get https://<IP_ADDRESS>:2376/v1.15/version: x509: certificate signed by unknown authority

Notice how the IP is correctly detected: rebooting the VM allowed the tools to start correctly this time, but there is a problem with the certificate.
Back in the first terminal, notice that the first command proceeded once it found the IP, only to fail later on, apparently because it could not enableSharedFolders?:
...
(foo) DBG | MAC address in VMX: 00:0c:29:8c:d5:20
(foo) DBG | Trying to find IP address via VMware tools: /Users/lloeki/.docker/machine/machines/foo/foo.vmx
(foo) DBG | executing: /Applications/VMware Fusion.app/Contents/Public/vmrun getGuestIPAddress /Users/lloeki/.docker/machine/machines/foo/foo.vmx
(foo) DBG | Found IP address via VMware tools: <IP_ADDRESS>
(foo) DBG | Got an ip: <IP_ADDRESS>
(foo) DBG | Creating Tar key bundle...
(foo) DBG | executing: /Applications/VMware Fusion.app/Contents/Public/vmrun -gu docker -gp tcuser directoryExistsInGuest /Users/lloeki/.docker/machine/machines/foo/foo.vmx /var/lib/boot2docker
(foo) DBG | executing: /Applications/VMware Fusion.app/Contents/Public/vmrun -gu docker -gp tcuser CopyFileFromHostToGuest /Users/lloeki/.docker/machine/machines/foo/foo.vmx /Users/lloeki/.docker/machine/machines/foo/userdata.tar /home/docker/userdata.tar
(foo) DBG | executing: /Applications/VMware Fusion.app/Contents/Public/vmrun -gu docker -gp tcuser runScriptInGuest /Users/lloeki/.docker/machine/machines/foo/foo.vmx /bin/sh sudo sh -c "tar xvf /home/docker/userdata.tar -C /home/docker > /var/log/userdata.log 2>&1 && chown -R docker:staff /home/docker"
(foo) DBG | executing: /Applications/VMware Fusion.app/Contents/Public/vmrun -gu docker -gp tcuser runScriptInGuest /Users/lloeki/.docker/machine/machines/foo/foo.vmx /bin/sh sudo /bin/mv /home/docker/userdata.tar /var/lib/boot2docker/userdata.tar
(foo) DBG | executing: /Applications/VMware Fusion.app/Contents/Public/vmrun -gu docker -gp tcuser enableSharedFolders /Users/lloeki/.docker/machine/machines/foo/foo.vmx
Error creating machine: Error in driver during machine creation: exit status 255
notifying bugsnag: [Error creating machine: Error in driver during machine creation: exit status 255]

But now that we have an IP address we can proceed from there again and complete the crucial missing step:
$ bin/docker-machine -D regenerate-certs foo
Regenerate TLS machine certs?  Warning: this is irreversible. (y/n): y
Regenerating TLS certificates
Waiting for SSH to be available...
Detecting the provisioner...
Copying certs to the local machine directory...
Copying certs to the remote machine...
Setting Docker configuration on the remote daemon...
$ bin/docker-machine ls
NAME     ACTIVE   DRIVER         STATE     URL                       SWARM   DOCKER      ERRORS
foo      -        vmwarefusion   Running   tcp://<IP_ADDRESS>:2376           v19.03.12
$ bin/docker-machine env foo
export DOCKER_TLS_VERIFY="1"
export DOCKER_HOST="tcp://<IP_ADDRESS>:2376"
export DOCKER_CERT_PATH="/Users/lloeki/.docker/machine/machines/foo"
export DOCKER_MACHINE_NAME="foo"
# Run this command to configure your shell:
# eval $(bin/docker-machine env foo)

To have docker -v volumes work though, one ought to add a shared folder to /Users, which springs some error:
$ vmrun addSharedFolder /Users/lloeki/.docker/machine/machines/foo/foo.vmx /Users /Users
Error: There was an error mounting the Shared Folders file system inside the guest operating system

And while I do get errors such as the above and the ones below, it does appear to work:
$ docker-machine ssh foo
chmod: /mnt/hgfs/Users: Operation not permitted
fuse: mountpoint is not empty
fuse: if you are sure this is safe, use the 'nonempty' mount option
chmod: /mnt/hgfs/Users: Operation not permitted
fuse: mountpoint is not empty
fuse: if you are sure this is safe, use the 'nonempty' mount option
docker@foo:~$ ls /Users/
Shared  lloeki

interesting. i can't get a vm to come up using your steps and the fusion driver. ssh just continues to loop w/ an exit code of 255 and i am unable to regenerate the certs. i also noticed that if i move the old dhcp files out of /var/db/vmware, they don't seem to be recreated.
also just as an unrelated fyi, vpn routing is broken in big sur/fusion 12 as well, just in case you use it and haven't encountered it yet. i can provide a link to a work around if you need it.
hopefully some fix will arise. i am not a fan of docker for mac b/c it doesn't behave the same as docker on a linux box (kafka is a good example of this) and so docker-machine is a great way to spin things up.


Consider alternatives to cookiecutter providing project update

What's needed?
We are investing quite a bit of work trying to add ways to easy the template upgrade for users. Ideally the template tool should help us with this.
Proposed solution
Consider alternatives that have some support for updating projects out of the box. For example:

Copier: https://copier.readthedocs.io/en/stable/updating/
Cruft: https://cruft.github.io/cruft/#updating-a-project

Alternatives and workarounds
We are currently providing a manually-written upgrade script, but it is time consuming and quite flaky.

Cruft doesn't seem to be in a good shape.
Copier, on the other hand seems to be super well maintained, less popular than cookiecutter, but more active.


Archival throws error with S3 driver

Describe the bug
A clear and concise description of what the bug is.

https://community.temporal.io/t/temporal-ui-beta-version-v2-local-setup/4376/3?u=ruslan
To Reproduce
Steps to reproduce the behavior:

Setup archival with s3 backend https://docs.temporal.io/clusters/how-to-set-up-archival/
go to Archival tab in the UI

Expected behavior
A clear and concise description of what you expected to happen.
Archival should list workflows with S3 backend
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

@feedmeapples Hi, are there any updates on this issue?

I also encountered this problem.  My solution is to add a proxy to change the query param.

@xiluoduyu Sure, that kind of work. But most of the web ui features just straight up does not work because of s3 backend limitation and different query parameters. Even the advanced search also doesn't work.

search for archived workflows on S3 doesn't work at all with UI v2

yes.. i too see this issue...
We love the new ui, but not supporting s3 archival is  deal breaker for me.. I would  love if this get fixed asap.
The old ui advanced search does a decent job with s3 archival..

Same issue, following.

this issue seems getting traction.. i'll check with the team if we can get someone on it (a bit occupied with other non UI items)

this issue seems getting traction.. i'll check with the team if we can get someone on it (a bit occupied with other non UI items)

Thanks @feedmeapples , is there any update on this

@feedmeapples , This is presently becoming a blocker for us, and i am not able to upgrade temporal to latest version because of this issue. Any way this can be priortized?

Per docs, https://docs.temporal.io/cluster-deployment-guide#archival Local file system is not production grade.
That leaves with S3 and gcp stores out of box..
S3 is breaking in new ui, This really needs to be given due attention i guess.

Archival backed by S3 seems to have more limitations compared to filestore. Ex. while i'm seeing filestore archival work fine with the UI, with S3 getting

@MichaelSnowden is looking into fixing the above error with S3 backed archival

into fixing the above error with S3 backed archival

Thansk much  @feedmeapples  for followup and getting this priorized! really appricate that!

Few updates on the progress, we want to address this in few stages:

At the end of the first stage we have

UI filters in archival page disabled as the filters will not currently work with S3 backed Archival

As the server team has capacity to get S3 backed Archival on par with the rest of history/visibility filtering options we may enable the UI filters

quick update the this item is still in progress, @MichaelSnowden or I will notify here once finished

@feedmeapples  Is there any plan to revisit this issue now that server fix is made?

this should be working now with the above PR merged and released in v2.14.0

thanks, i just checked this, it works but its far from usable
a) it takes huge time to load the acheives, my archieve runs to few 1000s and it takes a while.
Also it just gets the summar i guess,
clicking on the workflow shows 404,
i think when you click on the archieve search results, it tries to look for the worklow in online/temporal instead of archive this is the url which gets called  "namespaces//workflows///history"
I think the old ui was doing much better job as far as archive search is concerned. Not able to understand what broken in between.

@feedmeapples Does History archival from s3 via UI works with 2.14.0 or in any other versions ?
I'm experiencing the same behaviour as @kkcmadhu in newer versions of UI as well. When opening the workflow id to view history data the UI seems to route to "namespaces/yournamespace/workflows/your-workfllow-name/runid/history" URL, which may not be expected behaviour. Is there a plan to fix this or is there a workaround ?


Trackmap plugin not working with Grafana 7.4.1

When displaying the drives on a map (with the Grafana Trackmap plugin as part of Teslamate), it does not show the blue dot as you move through the data.  This is a known issue with the latest version of the plugin with Grafana 7.4.1. It does not have an issue with Grafana 7.3.7 which was the version used in Teslamate 1.21.3. See here for more details: https://github.com/pR0Ps/grafana-trackmap-panel/issues/50
Expected behavior
When looking at a drive and a map, as you move your cursor through the data on the other tables, you should see a blue dot on the map tracing the position.
How to reproduce it (as minimally and precisely as possible):
Steps to reproduce the behavior:

Go to the Drives dashboard
Click on any drive
Move the cursor through the Drive table
See the issue that there is no blue dot tracing the route on the map

Relevant entries from the logs

Bug seems to be in Grafana and/or the TrackMap plugin

Screenshots

Data

Environment

TeslaMate version: 1.21.4
Type of installation: Docker
OS TeslaMate is installed on: Linux Mint 19.3
User OS & Browser: Linux Mint 19.3 and Brave

Note: the trackmap plugin has supposedly been fixed and closed within the last 12 hours,  but I have not verified whether it is working.

Thanks for the fix!  Trackmap v2.1.1 is now available (https://github.com/pR0Ps/grafana-plugin-repository/tree/update/pr0ps-trackmap-panel-v2.1.1)  but not yet directly from grafana. I have not personally tested it yet, but it is supposed to work with Grafana 7.4+ and have fixes, including the hover issue here.  Perhaps on the next TeslaMate release, if Grafana 7.4+ is needed to update, you can update Trackmap as well.

Yeah, I briefly tested v2.1.1 but the map failed to load with an error. I'll wait until it is officially available and try again.

Yeah, I briefly tested v2.1.1 but the map failed to load with an error. I'll wait until it is officially available and try again.

Thanks for fixing this issue with the downgrade. Appreciate your work on TeslaMate!

Sorry for my ignorance, I am working at macOS Catalina & grafana 7.4.3 I am suffering exactly the same problem regarding no hover over the course. Unfortunately i have been trying during several days to install TrackMap 2.1.1 with no luck. I will really appreciate if you could help me giving me some dumb-for guidelines to isntall TrackMap 2.1.1.
Thanks and best regards,
Antonio Varela.

Hi Adrian,
I just noticed that trackmap has been updated to 2.1.2. I tested it with
Grafana 7.5.4 within Home Assistant and it seems to work.  So hopefully
this allows you to update to the latest version of Grafana with TeslaMate
and keep this feature.
Regards,
Joe
On Sun, Feb 21, 2021 at 11:35 AM Adrian Kumpf @.***>
wrote:

Yeah, I briefly tested v2.1.1 but the map failed to load with an error.
I'll wait until it is officially available and try again.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/adriankumpf/teslamate/issues/1360#issuecomment-782885497,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB6UDWOROBBWMOOL2OYDG63TAEY5HANCNFSM4XYMIWUA
.


Fix tests

How about a green build?
Well, the there_and_back_again_test.rb fails from time to time, so it would be nice if someone could stabilize it.

@osheroff @pschambacher

:+1:

Merge?

We’re ok with dropping support for Rails 2.3 and 3.0?

You might want a final confirmation from Ben but I really don't see why we should bother with Rails versions so old.

Let’s move forward and revert if needed. This PR is 3 weeks old.

:+1: I'm back from vacation.  should really move this repo to the zendesk org.


Change Default Translation

I have some question about how to change default translation without change translatable.php config file
Now, when I change default language in my system, I have to change in translatable.php in fallback_locale
Do you have alternative way to do that?
Thank.

Now I find how to set dynamic configuration
App::make('config')->set('translatable.fallback_locale','en');


Cannot build SwiftMonkey from pods

Cannot call value of non-function type 'XCUIElement'
public func addXCTestTapAlertAction(interval: Int, application: XCUIApplication) {
    addAction(interval: interval) { [weak self] in
        // The test for alerts on screen and dismiss them if there are any.
        for i in 0 ..< application.alerts.count {
            let alert = application.alerts.element(boundBy: i)
            let buttons = alert.descendants(matching: .button)
            XCTAssertNotEqual(buttons.count, 0, "No buttons in alert")
            let index = UInt(self!.r.randomUInt32() % UInt32(buttons.count))
            let button = buttons.element(boundBy: index)
            button.tap()
        }
    }
}

let button = buttons.element(boundBy: index)

Hey @PavelKatunin! Could you please provide more details on the error? Is this something that stopped working after you made an update? Which Swift version are you using? Did you add SwiftMonkey to your UI tests target?

Just got the same error. This is because the Readme example is pointing to 1.0 instead of the newest.

The #62 that fixes the README has been merged. Closing the issue.


Add explicit versioning - also to the latest container image

Please describe what you would like to see in ContainerSSH
It would be beneficial to have a dedicated tag for all released versions.
Please describe the solution you'd like
In addition to the current "lastest" version on hub.docker.com, add a tag for each release.
Please describe your use case
I just upgraded everything to 0.5 and it hopefully somehow works. Because there is no dedicated tag for the 0.5 version container image, with the next update of containerssh my environment might stop working.
I would like to have a tag like "0.5.0" for the release 0.5 to be able to use an image path like containerssh/containerssh:0.5.0

There's already a per-version tag e.g. v0.5.0 and a tag with the build date attached that won't be moved with rebuilds e.g.: v0.5.0-20240107.

Huups.
You are right. Scrolling helps...
Sorry.


Update set-the-caller-id-for-a-user.md

Added support for TPM 2.0

@JohanFreelancer9 Copy editing is needed for this PR. Thanks.


Update README to point to WIKI

The wiki now has Usage and Maven coordinates, so we should reduce the size of the README and just point people to the Wiki links.

This is mostly done - just need to update the wiki link to be this link:
https://github.com/interledger/java-ilp-core/wiki/ILP-Core-Home
or possibly just cleanup the wiki. This might change with the move to HL.


AST: Fix derivation of conformances in Substitution::subst() in the p…

This fixes a second regression from https://github.com/apple/swift/pull/4617. Here, there was an issue in deriving conformances for nested types that were omitted from the minimized signature if a parent type of the nested type was the subject of a same-type constraint.
There's some further cleanup possible here, to generalize the ArchetypeConformanceMap to work with interface types, and use it to replace some similar code in GenericSignature.cpp that suffers from the same problem in theory (we just haven't hit it yet since it's only used in witness thunk emission right now).
I'll work on consolidating the duplicated code and fixing the GenericSignature case after I conform that the original regression is fixed by this patch.

@swift-ci Please smoke test

@swift-ci Please smoke test

@swift-ci Please smoke test


Metadata view of Meltano

Migrated from GitLab: https://gitlab.com/meltano/meltano/-/issues/2611
Originally created by @tayloramurphy on 2021-02-26 15:39:20

One of the things I'm thinking about is how Meltano can be more aware about the data it's generating - the metadata. In a future where much of a data team's data workflow is in Meltano, there are a ton of insights we can gather and surface to be more useful.

View 15 previous comments from the original issue on GitLab

Still relevant but we should move to a discussion and open more focused issues.


 -- Loading tokenizer...
 -- Prompt format: deepseek
 -- System prompt:

You are an AI programming assistant, utilizing the Deepseek Coder model, developed by Deepseek Company, and you only answer questions related to computer science. For politically sensitive questions, security and privacy issues, and other non-computer science questions, you will refuse to answer.

 Response exceeded 100 tokens and was cut short.

User:

The response actually consists of all newline characters, which can be checked by running the same request via tabbyAPI. It just returns '\n' * 100 as completion.
As a comparison Phind-CodeLlama-v2 works as expected:
$ python -u examples/chat.py -m ~/models/firelzrd/Phind-CodeLlama-34B-v2-exl2 -mode codellama -gs 20,20 -l 16384 -maxr 100         -- Model: /home/viktor/models/firelzrd/Phind-CodeLlama-34B-v2-exl2
 -- Options: ['gpu_split: 20,20', 'length: 16384', 'rope_scale 1.0', 'rope_alpha 1.0']
 -- Loading model...
 -- Loading tokenizer...
  Always answer as helpfully as possible.

User: Write a quicksort function in Python 3.

Here is a simple implementation of the quicksort algorithm in Python 3:

   def quicksort(arr):
       if len(arr) <= 1:
           return arr
       pivot = arr[len(arr) // 2]
       left = [x for x in arr if x < pivot]
       middle = [x for x in arr if x == pivot]
    right = [x for x in arr if x >
 !! Response exceeded 100 tokens and was cut short.

User:

I suspect there is some problem with the tokenizer, since this model is using a custom one.
I had to manually install the tokenizers library into the venv to get the DeepSeek Coder loaded.

Deepseek-coder is a little special in that it requires RoPE scaling to work. In the latest dev version the relevant parameters are automatically loaded from the model's config, so once 0.0.12 is ready to release the problem should just go away. In the meantime, for 0.0.11 you can still specify RoPE scaling manually. For Deepseek-coder you'd would to add -rs 4 on the command line.

Thank you. Setting rope scaling to 4 helped.


⚠ Bofrost.fr has degraded performance

In 12031f9, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1006 ms

Resolved: Bofrost.fr performance has improved in bd047ff after 6 minutes.


Expose contract pinning

In current CosmWasm master, wasmvm 0.14-dev, they expose an API to pin/unpin contracts by Checksum. If a contract is pinned, it is guaranteed to be in memory cache and we can reduce the instantiation cost significantly:

Expose keeper API to pin/unpin contracts
Store pinned contracts in KVStore and re-pin on restart (can we just lazily pin everytime we run them, assuming that this is near zero cost if they are already pinned?)
Lower fix gas cost of calling a pinned contract from 40k to 1k (much faster on all machines)
Write some benchmarks that show calling pinned contracts is much faster (ensuring we are using APIs correctly). They can be Keeper level, and we can set the LRU cache size to 0 to ensure no other caching is going on.

Some thoughts:

We need to store a table to lookup contractAddr -> pinned (only set on true)
Add 2 governance messages to pin and unpin contract
Expose the Pin/Unpin functions on the WasmerEngine interface, and make them no-ops in the MockWasmerEngine implementation
On gov:pin, we just write to the kvstore. On gov:unpin, we remove from kvstore and call unpin on wasmer
Everytime we load a contract (where we charge the InstanceCost), we should do more or less the following.

if (contractPinned(ctx, contractAddr)) {
  k.wasmEngine.Pin(codeHash)
} else {
  gasMeter.charge(INSTANCE_COST)
}

Pinned contracts can have 0 instantation cost (the query to see if they are pinned will give 1k gas base fee). Pinning an already pinned contract is a rather cheap no-op on cosmwasm side
This is not the most optimized design, but simple enough and robust against restarts

This approach makes sense and will work.
I was following some design from the capability module and would suggest some improvements (maybe as a new iteration).
My assumption is that we do not change the pinned set very often.

The "lookup" table is also copied into a memory store
On startup we load the "lookup" table from the persistent store and seed the cache and memory store with pinned contracts. A bonus can be code/contract meta data stored in the memory store

That is a good assumption and if you can do something on "startup", then that would be a great improvement. I wasn't sure it that was possible.
Also, if this is memory store, we must be sure not to write during simulated tx


Hello, World! example throws error on "import System;"

I just tried to copy-paste the examples from here: http://www.jspplang.org/tutorial.html
But then I get this:
<EMAIL_ADDRESS>~/W/jspp $ nano main.jspp
<EMAIL_ADDRESS>~/W/jspp $ cat main.jspp
import System;
System.Console.Log("Hello, World!");
<EMAIL_ADDRESS>~/W/jspp $ js++ ./main.jspp -o /dev/null
[  ERROR  ] ./main.jspp: ParseError: Missing ; before statement, line 0 char -1
[  FATAL  ] Compilation failed with a syntax error at parse time.
<EMAIL_ADDRESS>~/W/jspp $ nano main.jspp
<EMAIL_ADDRESS>~/W/jspp $ cat main.jspp
import System
System.Console.Log("Hello, World!");
<EMAIL_ADDRESS>~/W/jspp $ js++ ./main.jspp -o /dev/null
[  ERROR  ] ./main.jspp: ParseError: Missing ; before statement, line 0 char -1
[  FATAL  ] Compilation failed with a syntax error at parse time.
<EMAIL_ADDRESS>~/W/jspp $ nano main.jspp
<EMAIL_ADDRESS>~/W/jspp $ cat main.jspp
// import System
System.Console.Log("Hello, World!");
<EMAIL_ADDRESS>~/W/jspp $ js++ ./main.jspp -o /dev/null
[   OK   ]  /dev/null: Compiled in 13ms

So...what exactly am I doing wrong?

You're doing nothing wrong.
It's not released yet. This download you're using is a very old build. We've re-designed since that time. JS++ is not released yet.

I am using the current git. But I get your point. :) Can't wait!


settings: Show indicator on notification settings.

This PR  fix this issue by showing indicator on notification settings heading.
Fixes: #28728.
Before Changes:

After Changes:

The screen capture looks good to me!

Please complete the self-review checklist, and post a comment to request a review from @sahil839  when ready.

Please  @sahil839  review my PR .

@sahil839   I have implemented all the things discussed above please review it .
To find element  using  .closest(".alert-notification)  was not possible in the existing DOM structure. So I have changed a little bit.
structure before :

structure after:

Yeah, we would need some changes in DOM structure, but I think we can do something better than what it is done currently in the PR.

Can we remove subscription-config div? I don't think it is used. If we can would be good to do so in a separate commit.
The subsection-header div should be inside subsection-parent. This way we would have the structure somewhat similar to display settings, you can have a look at display_settings.hbs file, and then you can get the selector using .closest(".subsection-parent").find(".alert-notification").

I think you can try the above changes and make sure that the design remains similar to what we have in main. Feel free to ask any further questions.

@sahil839   I have updated   the PR  the DOM structure looks good now. Please  review.

Can I work on this??

Can you rebase the PR to fix the failing test which is being discussed here? Looks good to me otherwise.

@sahil839   PR  rebased.

Looks good to me. @timabbott ready for your review.

@vighneshbhat9945 sorry for the slow review; @sahil839 forgot to add the "integration review" label that I track. Merged, thanks for doing this with a nice clean commit history!
I encourage working on next issues in the settings/stream settings UI to use the expertise you've developed in this PR.

Sorry, for missing adding the label.


JNI.createMemberField crashes when having nested class as className on Android 8

I came across the problem in the title. Crashes only happen on my Android 8 phone but not on my older devices and Nox.
Here is a sample project: https://drive.google.com/open?id=1z3TL9WQMM5YyZCOrbo-HVAsRJeu4VvjW
And the APK: https://drive.google.com/open?id=1qdt-CCbJqCENXWXdYusmWjnEiHvDHKkW
It gives this error on crash: JNI DETECTED ERROR IN APPLICATION: illegal class name 'test.Foo$Bar'

Is it expecting "test/Foo$Bar"?
Sources:
https://android.googlesource.com/platform/art/+/15fdb8c/src/check_jni.cc#146
https://stackoverflow.com/questions/9949674/jni-findclass-format-for-subclasses

You are right, changing to that stop the problem. So the real issue is I think the incorrect dotted syntax should throw some kind of error on the Haxe side? That syntax still work on older android versions, that can cause confusion and it's better that nobody else going down this path like me...

I think I may have planned (once or twice) to make the JNI code replace "." with "/" just to fix this, but then it would probably force this problem to occur elsewhere as it is incorrect syntax.
Perhaps documentation on the JNI class would help?

I think if the syntax is incorrect then it should just not work for the reason you mentioned. I only learned JNI while working with Lime so when it works for Lime I assumed it's the correct syntax for JNI in general. There might be others like me, it's better to not cause confusion for them I think.
On a second thought, I started using the dotted syntax from copying someone else's codes so there are probably other people using this syntax. It is also used heavily in projects at my job so... yea I may not want it to stop working yet.
So doing the replacement + adding document  like you said sounds nice. But I think we should only keep it work temporarily along with a traced warning, then sometime in the future we throw it to where it belongs.
Anyway thank you for informing me. I wish I can contribute but don't have the skill yet. :D

Closing this because the fix was merged into 8.1.0-Dev.


DevSecOps Workshop Refactor

switches to amzn linuz base ami
ansible playbook for jenkins configuration
jenkins credentials in ssm parameter store
switches from json to yaml templates
simplifies one-button deployment script
moves config and inspector setup from pipeline to main cloudformation
moves from bash script userdata to cloud-init metadata
virtualenv for owasp zap proxy app
config rules specified via cfn templates

@BrianJakovich @jedugas ready_for_review


fixed font sizes and titles, fixed Issue #64

Description
Decreased Font Size for RQLs, fixed typo in Time Series
Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate)

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes if appropriate.
[ ] All new and existing tests passed.

#64


Added min and mean + Added N input support for max

This PR adds the min and mean layer and also adds support for these layer and the max layer layer to have N inputs instead of just two.
I also moved the convert_max to elementwise_layers as they are elementwise operations.

Thank you for your PR!


change cmake windows target in documentation

According to CMake 3.9.4 generator platform should be Visual Studio 15 2017 Win64

Thank you!


Flannel PublicIP is matching eth0, instead of the given eth1 argument

Related to #216, I've found that in my flannel subnet, I have a subnet w/ publicIP <IP_ADDRESS>.
{"PublicIP":"<IP_ADDRESS>","BackendType":"vxlan","BackendData":{"VtepMAC":"8a:eb:23:bd:1b:4a"}}```

However, looking deeper into the subnet, the public IP above (<IP_ADDRESS>) corresponds to **eth0**.

```[root@kube0 vagrant]# ip a | grep eth1
3: eth1: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc pfifo_fast state UP group default qlen 1000
    inet <IP_ADDRESS>/24 brd <IP_ADDRESS> scope global eth1```

Oddly, though, I have launched flannel with the eth1 argument:

[root@kube0 vagrant]# ps -ax | grep fla
16332 ?        Ssl    0:00 /usr/bin/flanneld -etcd-endpoints=http://<IP_ADDRESS>:2379 -etcd-prefix=/coreos.com/network eth1

I'm assuming that normally, the flannel publicIP should always match the **eth** interface which flannel is launched on, but maybe there are situations where flannel **falls back** to eth0 even if another nic is specified?

Diving deeper, it appears that the IP Addresses in the flannel subnet aren't actually written to etcd anywhere, instead, I only see
[root@kube0 vagrant]# etcdctl ls /coreos.com/network/subnets/
/coreos.com/network/subnets/<IP_ADDRESS>-24

However, I've already allocated a few containers.

Should each container have an entry somewhere in ETCD for its IP address?
Is flannel responsible, on startup, to ensure that IP allocations will indeed be recorded properly in ETCD?

If so, maybe this is a "bug" of some sort, i.e. the fact that its possible for docker to allocate flannel  addresses without registering them in etcd?

NEVERMIND I foud that the eth1 argument being sent requires a --iface= option. Meanwhile, i still have other issues, but now im getting two subnets properly provisioned by flannel to different VM's container spaces.
For anyone curious, you have to be careful to make sure you properly use the iface option when starting flannel with vagrant provisioned VMs on a bridged network (eth0 is the bridge in some cases, which can lead to two separate machines trying to use IPs in the same subnet)

REopening because, flannel should provide an error if you give it an unused/invalid commandline option.     Will change the name shortly...

I think https://github.com/coreos/flannel/pull/223 fixes this. Can it be closed? With latest Go (1.4), bad command line options should result in an error.


Why I get an image of a hand gesture standing on its head

Why I get an image of a hand gesture standing on its head(all the results are the same!):

Maybe there is a hidden mistake in your visualization pipeline, for example, when you map the rgb-d pixel to the 3d world.


fix ov trainer model saving

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


typo dup...

@KevinKelley Thanks for your PR!
Can you please clean it a bit by deleting the .vscode folder and only keep the README?


app.js content hash depends on project path when using router + vuex + config in package.json

Version
3.4.1
Environment info
  System:
    OS: macOS 10.14.3
    CPU: (4) x64 Intel(R) Core(TM) i7-6567U CPU @ 3.30GHz
  Binaries:
    Node: 10.15.0 - /usr/local/bin/node
    Yarn: 1.5.1 - /usr/local/bin/yarn
    npm: 6.4.1 - /usr/local/bin/npm
  Browsers:
    Chrome: 72.0.3626.119
    Firefox: 61.0.1
    Safari: 12.0.3
  npmPackages:
    @vue/babel-helper-vue-jsx-merge-props:  1.0.0-beta.2
    @vue/babel-plugin-transform-vue-jsx:  1.0.0-beta.2
    @vue/babel-preset-app:  3.4.1
    @vue/babel-preset-jsx:  1.0.0-beta.2
    @vue/babel-sugar-functional-vue:  1.0.0-beta.2
    @vue/babel-sugar-inject-h:  1.0.0-beta.2
    @vue/babel-sugar-v-model:  1.0.0-beta.2
    @vue/babel-sugar-v-on:  1.0.0-beta.2
    @vue/cli-overlay:  3.4.1
    @vue/cli-plugin-babel: ^3.4.1 => 3.4.1
    @vue/cli-plugin-eslint: ^3.4.1 => 3.4.1
    @vue/cli-service: ^3.4.1 => 3.4.1
    @vue/cli-shared-utils:  3.4.1
    @vue/component-compiler-utils:  2.6.0
    @vue/eslint-config-standard: ^4.0.0 => 4.0.0
    @vue/preload-webpack-plugin:  1.1.0
    @vue/web-component-wrapper:  1.2.0
    babel-helper-vue-jsx-merge-props:  2.0.3
    eslint-plugin-vue: ^5.0.0 => 5.1.0
    vue: ^2.5.21 => 2.5.22
    vue-content-loader: ^0.2.1 => 0.2.1
    vue-eslint-parser:  2.0.3
    vue-googlemaps: ^0.1.2 => 0.1.2
    vue-hot-reload-api:  2.3.3
    vue-i18n: ^8.7.0 => 8.7.0
    vue-loader:  15.6.4
    vue-observe-visibility:  0.3.1
    vue-resize:  0.4.5
    vue-router: ^3.0.1 => 3.0.2
    vue-style-loader:  4.1.2
    vue-template-compiler: ^2.5.21 => 2.5.22
    vue-template-es2015-compiler:  1.9.1
    vuex: ^3.0.1 => 3.0.1
    vuex-router-sync: ^5.0.0 => 5.0.0
  npmGlobalPackages:
    @vue/cli: 3.4.0

Steps to reproduce

Create a vue-cli project

vue create testapp

Select manually features, add router + vuex, then keep everything as default ; at the last choice, select "In package.json" instead of dedicated config files
Run build and look at the dist/js/app.js content hash

cd testapp
npm run build

Rename the project folder and build again

cd ..
mv testapp testapp2
cd testapp2
npm run build

Compare the dist/js/app.js content hash with the previous one, it should be different

What is expected?
Content hash should be the same
What is actually happening?
Content hash is different

It only happens with the combo "router + vuex + config in package.json" ; it doesn't happen with "router + config in package.json" or "vuex + config in package.json" (which is super weird)
It only affects app.js (and app.js.map), css files are ok

Use case:
I have a vue app deployed with capistrano on 2 different VMs.
At each deploy, on each VM:

A new directory is created with the date in its name (ex: /home/user/releases/20190227110836)
The project code is fetch from git in this directory
npm run build is run

If the directories are not created at the same time, they will have different names, which will generate different content hashes on my app.js on each VM.

Is this related https://github.com/vuejs/vue-cli/commit/d5ed2801cab38de87ae0c453009f620ab32b7915 ?

Nope
The issue looks the same as https://github.com/vuejs/vue-cli/issues/2807
But I already upgraded to vue-cli 3.4.1 and it's still happening.

I mean, you can now apply the absoluteRuntime: false option to the preset now. We didn't document it, though.

Oh ok I thought false was the new default. Don't know where to put this option though.
Also it's still weird that the issue doesn't happen with the config in separate files, but happens with the config in package.json.

// babel.config.js
module.exports = {
  presets: [
    ['@vue/app', {
      absoluteRuntime: false
    }]
  ]
}

Many thanks, I was trying hard stuff like
presets: [
  '@vue/app', {
    absoluteRuntime: false
  }
]

Now it works perfectly.
Still confused about why it happens with this configuration only.
Also I think this should be the default behavior.
Feel free to close this issue if this isn't relevant.

Also it's still weird that the issue doesn't happen with the config in separate files, but happens with the config in package.json.

Just figured it out. It is related to this bug: https://github.com/vuejs/vue-cli/issues/2983 and is expected to be fixed in v3.5.
For now a workaround is to disable thread-loader by adding the following configuration to vue.config.js:
module.exports = {
  parallel: false
}

I'll close this issue as it's now a duplication of #2983.

Also I think this should be the default behavior.

We can't because we can't be sure if the @babel/runtime-corejs2 in the root node_modules is the correct version, due to the non-deterministic nature of npm dependency hoisting. So we have to leave it for the user to decide.

Just tried to reproduce this with the new v3.5, I confirm it's no longer happening 🥇

@sodatea Sadly the issue came back with v3.5.1.
I tryed several combos to find the specific package/version reintroducing the issue and the culprit is<EMAIL_ADDRESS>    "@vue/cli-plugin-babel": "^3.5.3",
    "@vue/cli-plugin-eslint": "^3.5.1",
    "@vue/cli-service": "^3.5.0",

=> ✅
    "@vue/cli-plugin-babel": "^3.5.3",
    "@vue/cli-plugin-eslint": "^3.5.1",
    "@vue/cli-service": "^3.5.1",

=> ❌
(also it seems like the npm package @vue/cli-plugin-eslint got stuck in 3.5.1 when others got to 3.5.3)
I understand this issue is difficult to reproduce but it would be great to have a test to avoid reintroducing it in the future as it can be critical for production environment builds.
Thanks !


Addon Automation Part 1 [buildNum:2<IP_ADDRESS>]

works alongside: https://github.com/iTwin/imodel-native-internal/pull/379

/azp run imodel-native


nlopt: 2.7.0 -> 2.7.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/stevengj/nlopt/releases.
meta.description for nlopt is: "Free open-source library for nonlinear optimization"
meta.homepage for nlopt is: "https://nlopt.readthedocs.io/en/latest/"
meta.changelog for nlopt is: ""
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 2.7.1 with grep in /nix/store/k8svi20dq68z0m73qdvk1d9znxi1cbnf-nlopt-2.7.1

found 2.7.1 in filename of file in /nix/store/k8svi20dq68z0m73qdvk1d9znxi1cbnf-nlopt-2.7.1

Rebuild report (if merged into master) (click to expand)

27 total rebuild path(s)

19 package rebuild(s)

19 x86_64-linux rebuild(s)
8 x86_64-darwin rebuild(s)

First fifty rebuilds by attrpath
cura
docbookrx
haskellPackages.hmatrix-nlopt
haskellPackages.nlopt-haskell
libnest2d
nlopt
pagmo2
prusa-slicer
python38Packages.pygmo
python38Packages.pynest2d
python38Packages.rpy2
python39Packages.pygmo
python39Packages.pynest2d
python39Packages.rpy2
sage
sageWithDoc
shogun
super-slicer
super-slicer-latest

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/k8svi20dq68z0m73qdvk1d9znxi1cbnf-nlopt-2.7.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A nlopt https://github.com/r-ryantm/nixpkgs/archive/43879fc68af80f2ce8a115f612567a4abee620c1.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/k8svi20dq68z0m73qdvk1d9znxi1cbnf-nlopt-2.7.1
ls -la /nix/store/k8svi20dq68z0m73qdvk1d9znxi1cbnf-nlopt-2.7.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
nixpkgs-review took longer than 45m and timed out

Maintainer pings

@ofborg build sage

Looks fine to Sage, but tagging the SuperSlicer maintainers (@cab404 @moredread) just in case.

Gonna try super-slicer in a sec.

Just compiled. Works fine!


fix: pass BTF object by reference in order to allow multiple eBPF programs to share it and save memory (closes #30).

As per title, this PR changtes Bpf::load to use Option<&Btf> instead of Option<Btf> so that a single instance of Btf information can be shared among multiple programs, thus decreasing overall memory usage.

Thank you!


Support scala 3

Not many code changes are needed, it is mostly lib updates and type declarations
Fixes #289

@djspiewak @johnynek Thanks for the comments. I fixed what you suggested


Added updated change upon currentTarget update

Issue
Previously, the updated prop for the annotation.target was always undefined within the TextAnnotator. Although the target changes during the selection.
Changes Made
Following the onChangeSelected from SVGDrawingLayer, I added new Date() for the updated prop on the selection change

Well spotted. Thanks!


Split the boundary and then delete the point.

In "edit with iD", after I create a polygon, if I click a point and split the boundary into two, followed by deleting this point, the polygon would be broken into polylines even when there are enough polylines left to formulate a polygon.

Is this what you mean?

Exactly. Is it a bug or it was designed to be this way?

Looks like a bug to me...

Agree lol

This is a more general issue, iD does break relations when deleting a connecting vertex. For example deleting a highway junction node breaks routes, even where disconnecting or deleting the ways is prohibited.
This is very bad because users might delete the node in order to workaround the other prevented operations, and they will likely assume, that this is save because it is not prevented.

@bhousel How about renaming this issue in "Delete connecting vertex is breaking relations." The split of an area outline in the origial description is only the method to generate a multipolygon with a connecting vertex at the node which is deleted afterwards.
We don't need to prevent the operation, we can add a new untagged way between the neighboring nodes and add as multipolygon member.
In case of a route we can do similar, but should add a tag identifing the added way as a new feature type like "Broken Route Link". This should be redered in iD indicating it as an error and should generate a warning when trying to upload. But in case it is uploaded by accident, it doesn't seem to be a severe issue for applications, and it simplifies fixing the data issue.
The "Broken Route Link" should preferably have a special behavior dragging it to be coincident with a suitable highway/railway for the route. In this case it should be absorbed by the highway/railway transfering the route membership(s).
We can use a similar approch for some other relation breaking operations like disconnect.
@bhousel If this is acceptable, I will try to make a pull request.

@bhousel What's the preferred behavior here? I assume we'd either disable the delete operation or allow deleting the node but keep the two member ways connected at one of the adjacent nodes.

allow deleting the node but keep the two member ways connected at one of the adjacent nodes.

☝ I think this is what we want it to do

@quincylvania

but keep the two member ways connected at one of the adjacent nodes.

This seems to be limited to the special case, where at least one of the member ways is untagged, and isn't a member of any other relation.


Avoid failure on requesting tessellation

Coming from https://github.com/ansys/pyansys-geometry/discussions/1384#discussioncomment-10540787 it also got me thinking... we might have to wrap the tessellation request with a try...except block to avoid failure when requesting plotting. We should also throw out a warning message saying that tessellation request for X failed. Ignoring plotting of this body/component.
@Indrajeetrt since you are the one experiencing this, what's your take on this? Would it make sense as a user to just get a warning saying the previous message or would you prefer it failed like it is doing now?

Closing due to inactivitiy.


Fixes for #1604

ESRGAN is known to have poor handling of RGBA images: https://github.com/xinntao/ESRGAN/issues/18
If we give it an RGBA image, it will output an image where the alpha channel has partial transparency across many pixels.
The simplest solution is to convert the image to RGB before handing to ESRGAN (that is what this PR does).
Preserving alpha (of an input image with some transparency) is tricky. An approximation of the output alpha channel can be created by simply resizing the input image's alpha channel, but this isn't quite correct, because the RGB data is modified during upscaling. Other approaches are discussed in the above ESRGAN issue.
Because there is no good method I could find with my brief search, and because I don't think it is really useful for our case, one effect of this PR is that images with partial transparency, when processed by ESRGAN, will have the alpha channel totally dropped.
Actual changes in this PR:

Converts image to RGB before running ESRGAN
Also adds typing for image input.

This is a draft. Do you want to keep working on it before a review?

@lstein

This is a draft. Do you want to keep working on it before a review?

Yes, may also add changes to inpaint code to handle an edge case
Will mark when ready for review

I added a test to color correction to make sure there are unmasked pixels before trying to color correct.

Thanks Kyle, have tested and confirmed the error condition is avoided with your changes.

@blessedcoolant Here is an image that you can use to recreate the issue, it has partial transparency all over it. Upload to cancel and invoke w/ bbox on it with any settings. It should say outpainting, then on inpaint seams, basically do img2img on the whole image, and not cause an error.


[BUG] Double-Layer capacitor in Alloy Smelter prevents valid (soularium) recipe from being produced

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
Basic capacitor (in ATM9) will convert soul sand into scoria (from create) when not mixed with gold. Soularium production is otherwise fine (when gold placed first).
Double-layer capacitor ignores the existence of gold and will only produce scoria even with output empty and equal amounts of both in the input.
I have not tried the higher alloys/capacitors.
Expected Behavior
I want my soularium! ;)
And a better FE consumption/usage which theoretically comes with the upgraded capacitor.
Perhaps your sag mill can undo this as well as the bug fix?
Steps To Reproduce
No response
Environment
- OS: 8.1
- Java version: 17.05
- Minecraft version: 1.20.1
- Version: 6.0.5alpha

Anything else?
Thank you for coming back. Your work is appreciated,

Im thinking this is a combination of bugs #251 and #292. AFAIK capacitor has no bearing on the processing, just the speed? try clearing the machines inventory, and sticking a block of cobble inside each slot, then removing them, before making solaiium

Unable to repro this, I think that tyler's probably right however.

I'm gonna go and close this as it should be fixed by 6.0.6, please reopen it if you still encounter the issue. Thanks!


padLen() was Computed Twice

padLen() is computed internally by makePad(), so matchlen should be passed as-is.

That is nice gotcha!


Null safety

Hi, any plans to convert this code to null-safe?

Hi. i would love to. But that's a lot of work and unfortunately I don't have time for it.

OK, I'll create a PR.


az rest generates undocumented/unwanted  "resourceGroup" properties

az rest generates undocumented  "resourceGroup" properties
Describe the bug
resourceGroup appears everywhere in the response
{
  "id": "myid",
   "resourceGroup": "myresourcegroup"
  },

To Reproduce
az rest --uri https://management.azure.com/subscriptions/{subscriptionId}/resourceGroups/{resourceGroup}/providers/Microsoft.Network/frontDoors/{frontdoor}?api-version=2019-05-01

Expected behavior
I would expect the same result as using the request directly (with auth).
Using the rest api direcly works as expected.
Environment summary
tested on windows and ubuntu (github actions)
Additional context
this  is a pain because I want to run a

GET,
update response,
PUT

but the PUT fails due to all the extra resourcegroup properties
When running with --verbose --debug I can see the request is working correctly.
however
Event: CommandInvoker.OnTransformResult [<function _resource_group_transform at 0x0401DC48>, <function _x509_from_base64_to_hex_transform at 0x0401DC90>]

is being called
https://github.com/Azure/azure-cli/blob/e015d5bcba0c2d21dc42189daa43dc1eb82d2485/src/azure-cli-core/azure/cli/core/commands/transform.py
could be the issue, can it de disabled?

rest

Thanks for reporting this issue. You analysis is correct.
_add_resource_group is registered at
https://github.com/Azure/azure-cli/blob/06a83a4e7b6cd3da64b84e9408cb13eb5e5d9fec/src/azure-cli-core/azure/cli/core/commands/transform.py#L14
As removing this field will cause a BREAKING CHANGE, we will discuss internally and work on it in the next sprint.

I got trapped by this behavior myself:
$ vnet=$(az rest -m GET -u /subscriptions/0b1f6471-1bf0-4dda-aec3-cb9272f09590/resourceGroups/fanqiu-test/providers/Microsoft.Network/virtualNetworks/vnettest?api-version=2021-02-01)

$ echo "$vnet"
{
  "etag": "W/\"6edecdf3-4fb4-4b9e-a3a0-bcf184d6caf7\"",
  "id": "/subscriptions/0b1f6471-1bf0-4dda-aec3-cb9272f09590/resourceGroups/fanqiu-test/providers/Microsoft.Network/virtualNetworks/vnettest",
  "location": "centralus",
  "name": "vnettest",
  "properties": {
    "addressSpace": {
      "addressPrefixes": [
        "<IP_ADDRESS>/16"
      ]
    },
    "enableDdosProtection": false,
    "provisioningState": "Failed",
    "resourceGuid": "069414bc-bd93-47a1-976e-2e51578a2c72",
    "subnets": [
      {
        "etag": "W/\"6edecdf3-4fb4-4b9e-a3a0-bcf184d6caf7\"",
        "id": "/subscriptions/0b1f6471-1bf0-4dda-aec3-cb9272f09590/resourceGroups/fanqiu-test/providers/Microsoft.Network/virtualNetworks/vnettest/subnets/default",
        "name": "default",
        "properties": {
          "addressPrefix": "<IP_ADDRESS>/24",
          "delegations": [],
          "privateEndpointNetworkPolicies": "Disabled",
          "privateLinkServiceNetworkPolicies": "Disabled",
          "provisioningState": "Failed"
        },
        "resourceGroup": "fanqiu-test",
        "type": "Microsoft.Network/virtualNetworks/subnets"
      }
    ],
    "virtualNetworkPeerings": []
  },
  "resourceGroup": "fanqiu-test",
  "type": "Microsoft.Network/virtualNetworks"
}

$ az rest -m PUT -u /subscriptions/0b1f6471-1bf0-4dda-aec3-cb9272f09590/resourceGroups/fanqiu-test/providers/Microsoft.Network/virtualNetworks/vnettest?api-version=2021-02-01 --body "$vnet"
Bad Request({
  "error": {
    "code": "InvalidRequestFormat",
    "message": "Cannot parse the request.",
    "details": [
      {
        "code": "InvalidJson",
        "message": "Could not find member 'resourceGroup' on object of type 'Subnet'. Path 'properties.subnets[0].resourceGroup', line 27, position 24."
      },
      {
        "code": "InvalidJson",
        "message": "Could not find member 'resourceGroup' on object of type 'VirtualNetwork'. Path 'resourceGroup', line 33, position 18."
      }
    ]
  }
})

The PUT command failed due to the unwanted resourceGroup properties.


Changing volume via keyboard scrolls me to bottom

Windows Terminal version
1.11.2129.0
Windows build number
10.0.22000.348
Other Software
git-bash and tail -f
Steps to reproduce

Tail something
Scroll up
Press volume-up/down on keyboard

Expected Behavior
Stay where you are, Terminal
Actual Behavior
Wait Terminal, come back!

This was harder to find than expected, and I knew it was on the backlog somewhere: /dup #5366
Thanks!


Selected FilterChip/ChoiceChip have no visual indication when focused in M3

Steps to Reproduce

Enable Material 3 in ThemeData
Use multiple FilterChip/ChoiceChip widgets (some in selected state)
Navigate the app using keyboard to focus tappable widgets

Expected results:
The selected FilterChip/ChoiceChip should adhere to theming according to M3 specs, as tracked in #115364.
Actual results:
When using focus to navigate the app, user cannot identify what selected chip actually has focus. Unfocused selected Chip looks the same as focused selected Chip.

Code sample
ThemeData(
	useMaterial3: true,
	colorScheme: ColorScheme.fromSeed(seedColor: Colors.blue),
),

ChoiceChip(
	label: Text("First"),
	selected: true,
	onSelected: (value) {},
),
ChoiceChip(
	label: Text("Second"),
	selected: false,
	onSelected: (value) {},
),

Focus on first widget:

Focus on second widget:

Issue is reproducible on the latest master & stable

recording
https://user-images.githubusercontent.com/88313112/214807457-37abe594-0bf6-45ba-81e5-c87aa9b78bc3.mov

code sample
import 'package:flutter/material.dart';

void main() async {
  runApp(const MyApp());
}

class MyApp extends StatefulWidget {
  const MyApp({super.key});

  @override
  State<MyApp> createState() => _MyAppState();
}

class _MyAppState extends State<MyApp> {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      theme: ThemeData.from(useMaterial3: true, colorScheme: ColorScheme.fromSeed(seedColor: Colors.blue)),
      home: Scaffold(
        body: Center(
          child: Column(
            mainAxisAlignment: MainAxisAlignment.center,
            crossAxisAlignment: CrossAxisAlignment.center,
            children: [
              ChoiceChip(
                label: const Text("First"),
                selected: true,
                onSelected: (value) {},
              ),
              const SizedBox(height: 10.0),
              ChoiceChip(
                label: const Text("Second"),
                selected: false,
                onSelected: (value) {},
              ),
              const SizedBox(height: 10.0),
              FilterChip(
                label: const Text('Filter Selected'),
                onSelected: (val) {},
                selected: true,
              ),
              const SizedBox(height: 10.0),
              FilterChip(
                label: const Text('Filter Not Selected'),
                onSelected: (val) {},
                selected: false,
              ),
            ],
          ),
        ),
      ),
    );
  }
}

flutter doctor -v
[✓] Flutter (Channel stable, 3.7.0, on macOS 13.1 22C65 darwin-arm64, locale en-GB)
    • Flutter version 3.7.0 on channel stable at /Users/nexus/dev/sdks/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision b06b8b2710 (2 days ago), 2023-01-23 16:55:55 -0800
    • Engine revision b24591ed32
    • Dart version 2.19.0
    • DevTools version 2.20.1

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0)
    • Android SDK at /Users/nexus/Library/Android/sdk
    • Platform android-33, build-tools 33.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.15+0-b2043.56-8887301)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.2)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14C18
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[!] Android Studio (version 2022.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    ✗ Unable to find bundled Java version.
    • Try updating or re-installing Android Studio.

[!] Android Studio (version 2022.1)
    • Android Studio at /Users/nexus/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/221.6008.13.2211.9477386/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    ✗ Unable to find bundled Java version.
    • Try updating or re-installing Android Studio.

[✓] IntelliJ IDEA Community Edition (version 2022.2)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.74.3)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.58.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-arm64   • macOS 13.1 22C65 darwin-arm64
    • Chrome (web)    • chrome • web-javascript • Google Chrome 109.0.5414.119

[!] HTTP Host Availability
    ✗ HTTP host "https://cocoapods.org/" is not reachable. Reason: An error occurred while checking the HTTP host: Failed host lookup: 'cocoapods.org'
    ✗ HTTP host "https://maven.google.com/" is not reachable. Reason: An error occurred while checking the HTTP host: Failed host lookup: 'maven.google.com'
    ✗ HTTP host "https://pub.dev/" is not reachable. Reason: An error occurred while checking the HTTP host: Failed host lookup: 'pub.dev'
    ✗ HTTP host "https://cloud.google.com/" is not reachable. Reason: An error occurred while checking the HTTP host: Failed host lookup: 'cloud.google.com'

! Doctor found issues in 3 categories.

[!] Flutter (Channel master, 3.7.0-26.0.pre.14, on macOS 13.1 22C65 darwin-arm64, locale en-GB)
    • Flutter version 3.7.0-26.0.pre.14 on channel master at /Users/nexus/dev/sdks/flutters
    ! Warning: `flutter` on your path resolves to /Users/nexus/dev/sdks/flutter/bin/flutter, which is not inside your current Flutter SDK checkout at /Users/nexus/dev/sdks/flutters. Consider adding /Users/nexus/dev/sdks/flutters/bin to the front of your path.
    ! Warning: `dart` on your path resolves to /Users/nexus/dev/sdks/flutter/bin/dart, which is not inside your current Flutter SDK checkout at /Users/nexus/dev/sdks/flutters. Consider adding /Users/nexus/dev/sdks/flutters/bin to the front of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 351466aea6 (28 hours ago), 2023-01-24 21:46:24 -0800
    • Engine revision bffb983524
    • Dart version 3.0.0 (build 3.0.0-157.0.dev)
    • DevTools version 2.20.1
    • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update checks and upgrades.

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0)
    • Android SDK at /Users/nexus/Library/Android/sdk
    • Platform android-33, build-tools 33.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.15+0-b2043.56-8887301)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.2)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14C18
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[!] Android Studio (version 2022.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    ✗ Unable to find bundled Java version.
    • Try updating or re-installing Android Studio.

[!] Android Studio (version 2022.1)
    • Android Studio at /Users/nexus/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/221.6008.13.2211.9477386/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    ✗ Unable to find bundled Java version.
    • Try updating or re-installing Android Studio.

[✓] IntelliJ IDEA Community Edition (version 2022.2)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.74.3)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.58.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-arm64   • macOS 13.1 22C65 darwin-arm64
    • Chrome (web)    • chrome • web-javascript • Google Chrome 109.0.5414.119

[!] HTTP Host Availability
    ✗ HTTP host "https://cocoapods.org/" is not reachable. Reason: An error occurred while checking the HTTP host: Failed host lookup: 'cocoapods.org'
    ✗ HTTP host "https://maven.google.com/" is not reachable. Reason: An error occurred while checking the HTTP host: Failed host lookup: 'maven.google.com'
    ✗ HTTP host "https://pub.dev/" is not reachable. Reason: An error occurred while checking the HTTP host: Failed host lookup: 'pub.dev'
    ✗ HTTP host "https://cloud.google.com/" is not reachable. Reason: An error occurred while checking the HTTP host: Failed host lookup: 'cloud.google.com'

! Doctor found issues in 4 categories.

I would like to work on this, but I have a question regarding this issue.
The problem appears to be that the widget rendering the color is not a Material, thus InkWell cannot paint the focus effect onto the color. I can resolve that issue by having the color painted by a Material widget instead. However, this causes a couple of tests to fail. The reason for that appears to be Material 3's new surfaceTintColor property. That property applies a tint to the Material's color in order to visually indicate elevation. Apparently, the default surfaceTintColor for Chips is not null, causing all tests that check the background color of Chips to fail. Would it be appropriate to adjust the old tests in this case, possibly overriding the surfaceTintColor?


Doesn't do anything if text is ALL CAPS

Repro:

Enter string in ALL CAPS
Select string
Use smart-title-case to convert text
Nothing happens
Use built-in "transform to lowercase"
Use smart-title-case to convert text
Text transforms properly

Thanks for issue! But it is by design.
I created this extension to manually format the bibliography of an article.
Many abbreviations such as DNA or NPO appear in academic journals. Converting them to, for example, Dna or Npo would result in improper spelling, so this extension does not convert any all-caps words.

It has been a while.
In version 0.5.0, new -strictly commands convert all-caps words strictly as well.
I hope this helps.