"Looks like someone dropped the mic" in the ErrorPage component seems like a misuse of the colloquialism

📜 Description
"Dropping the mic" means doing something so impressive that you can just drop the mic and walk off the stage.
"Dropping the ball" means making a mistake.
"Looks like someone dropped the mic" on an error page appears (at least on its face) to be the result of mixing these two expressions up, maybe in an attempt to connect it to the musical theme that gave Backstage its name?
👍 Expected behavior
I think it should be "looks like someone dropped the ball," or maybe something more music-related that suggests making a mistake.
👎 Actual Behavior with Screenshots

👟 Reproduction steps
Go to https://demo.backstage.io/foo, or any other url on a Backstage instance that would produce a 404.
📃 Provide the context for the Bug.
It is jarring/confusing to read a message that states the opposite of what it intends.
🖥 Your Environment
No response
👀 Have you spent some time to check if this bug has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

Are you willing to submit PR?
Yes I am willing to submit a PR!

Wouldn't really consider this a bug per-se 😅.
I understood it as someone just "dropped the mic and left" like an "Ah screw it" kind of drop.
It's up to interpretations of course but also something like "Is this thing on?" could work 😄

I like "is this thing on?" for a 404!


Mocha programmatic API doesn't report retries

When using Mocha programmatically with the new retries feature, tests that fail the first time but eventually succeed are not marked as "passed" in the suite's tests array.
index.js:
var Mocha = require('mocha');
var mocha = new Mocha({
  retries: 1
});
mocha.addFile('test.js');
mocha.run().on('suite end', function(suite) {
  console.dir(suite);
});

test.js:
var currentRun = 0;

it('should mark tests that succeed on 2nd try as "passed"', function() {
  currentRun++;
  console.log('running test');
  if (currentRun === 1) {
    console.log('failing test');
    throw new Error('hi');
  }
  console.log('passing test');
});

Output:
running test
failing test
running test
passing test
  ✓ should mark tests that succeed on 2nd try as "passed"
Suite {
  title: '',
  ctx:
   Context {
     _runnable:
      Test {
        title: 'should mark tests that succeed on 2nd try as "passed"',
        fn: [Function],
        async: 0,
        sync: true,
        _timeout: 2000,
        _slow: 75,
        _enableTimeouts: true,
        timedOut: false,
        _trace: [Error: done() called multiple times],
        _retries: 1,
        _currentRetry: 1,
        pending: false,
        type: 'test',
        body: 'function () {\n  currentRun++;\n  console.log(\'running test\');\n  if (currentRun === 1) {\n    console.log(\'failing test\');\n    throw new Error(\'hi\');\n  }\n  console.log(\'passing test\');\n}',
        _allowedGlobals: undefined,
        parent: [Circular],
        file: '/Users/claytonwatts/dev/domo/domoweb/DomoWeb/test.js',
        ctx: [Circular],
        _events: [Object],
        _eventsCount: 1,
        callback: [Function: done],
        duration: 0,
        state: 'passed',
        speed: 'fast' },
     test:
      Test {
        title: 'should mark tests that succeed on 2nd try as "passed"',
        fn: [Function],
        async: 0,
        sync: true,
        _timeout: 2000,
        _slow: 75,
        _enableTimeouts: true,
        timedOut: false,
        _trace: [Error: done() called multiple times],
        _retries: 1,
        _currentRetry: 1,
        pending: false,
        type: 'test',
        body: 'function () {\n  currentRun++;\n  console.log(\'running test\');\n  if (currentRun === 1) {\n    console.log(\'failing test\');\n    throw new Error(\'hi\');\n  }\n  console.log(\'passing test\');\n}',
        _allowedGlobals: undefined,
        parent: [Circular],
        file: '/Users/claytonwatts/dev/domo/domoweb/DomoWeb/test.js',
        ctx: [Circular],
        _events: [Object],
        _eventsCount: 1,
        callback: [Function: done],
        duration: 0,
        state: 'passed',
        speed: 'fast' } },
  suites: [],
  tests:
   [ Test {
       title: 'should mark tests that succeed on 2nd try as "passed"',
       async: 0,
       sync: true,
       _timeout: 2000,
       _slow: 75,
       _enableTimeouts: true,
       timedOut: false,
       _trace: [Error: done() called multiple times],
       _retries: 1,
       _currentRetry: 0,
       pending: false,
       type: 'test',
       body: 'function () {\n  currentRun++;\n  console.log(\'running test\');\n  if (currentRun === 1) {\n    console.log(\'failing test\');\n    throw new Error(\'hi\');\n  }\n  console.log(\'passing test\');\n}',
       file: '/Users/claytonwatts/dev/domo/domoweb/DomoWeb/test.js',
       parent: [Circular],
       ctx: [Object],
       _events: [Object],
       _eventsCount: 1,
       callback: [Function: done],
       duration: 0 } ],
  pending: false,
  _beforeEach: [],
  _beforeAll: [],
  _afterEach: [],
  _afterAll: [],
  root: true,
  _timeout: 2000,
  _enableTimeouts: true,
  _slow: 75,
  _bail: undefined,
  _retries: 1,
  delayed: false,
  _events: { 'pre-require': [ [Function], [Function] ] },
  _eventsCount: 1 }

  1 passing (22ms)

Notice that the test objects in Context are correctly marked with state: "passed", but the one in the tests array is from the first run (note _currentRetry: 0) and has no state property.

@longlho

+1 The retry feature is great. We just need it supported in the programmatic API as well.

kk I'll try to take a look asap :)

@cletusw @justspamjustin So every time runner is run, it shallow clone the tests, which I'm not entirely sure whether it should be deep clone instead. The reason is that tests in suite are essentially input, and shallow clone during runnable doesn't prevent runner from modifying input inline, which I think can cause side effects (in this case all test results are persisted in the test object). All public reporters hook into the event lifecycle, which received the cloned test as a param, thus working correctly w/ retries.
In your scenario, since retries clone the tests, the original test that was passed in (or globbed by Mocha, for that matter) isn't considered passed, bc actually it did not, the 2nd cloned one did (which is by design). I think the solution for u guys might be to follow the reporter pattern of listening to certain events since it's more of like a "public" API.
cc @danielstjules @boneskull for discussion.

So does that mean we can't use the data in the "suite end" event?
On Mon, Apr 11, 2016, 6:35 PM Long Ho<EMAIL_ADDRESS>wrote:

@cletusw https://github.com/cletusw @justspamjustin
https://github.com/justspamjustin So every time runner is run, it
shallow clone the tests, which I'm not entirely sure whether it should be
deep clone instead. The reason is that tests in suite are essentially
input, and shallow clone during runnable doesn't prevent runner from
modifying input inline, which I think can cause side effects (in this
case all test results are persisted in the test object). All public
reporters hook into the event lifecycle, which received the cloned test
as a param, thus working correctly w/ retries.
In your scenario, since retries clone the tests, the original test that
was passed in (or globbed by Mocha, for that matter) isn't considered
passed, bc actually it did not, the 2nd cloned one did (which is by
design). I think the solution for u guys might be to follow the reporter
pattern of listening to certain events since it's more of like a "public"
API.
cc @danielstjules https://github.com/danielstjules @boneskull
https://github.com/boneskull for discussion.
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/mochajs/mocha/issues/2188#issuecomment-208641290

that I'm not sure, @danielstjules @boneskull ?

@longlho It seems to me that if we can externally listen to all the pass, fail, and pending events and compile a correct list, then mocha should be able to do the same internally and give correct data on a suite end event.

@longlho Thanks for looking into this, btw. retry for our end-to-end tests is something we've been wanting for a long time, and you've already gotten us most of the way there.

sure np :) I can certainly put in a PR of some sort to address this issue (which I think is either deep cloning the tests and/or store test results separately in the Suite). Kinda waiting for @danielstjules & @boneskull to chime in.

@danielstjules @boneskull Any update on this? This makes the data provided to the suite end event useless when using retries.

@cletusw based on this PR I think listening to pass/fail might yield better results

not stale

any progress ??

Is someone here willing to help? Some testing and feedback would be nice.
lib/runner.js
Please add following lines:
var idx = suite.tests.indexOf(test);                    // new
if (idx > -1) suite.tests[idx] = clonedTest;            // new
self.emit(constants.EVENT_TEST_RETRY, test, err);


Hash to scalar?

Summary
I would like to hash arbitrary byte strings to group scalars.
let msg = "Hello world!".as_bytes();
let h = ark_bn254::Fr::hash(msg);

Problem Definition
This is relevant for some cryptographic schemes in order to expand the message space to arbitrary byte strings (e.g., Catalano-Fiore vector commitments, page 8, footnote 8).
Proposal
Introduce an API for hashing bytes to scalars / prime field elements as described above.
(If this is already implemented, I would be happy to get a pointer into the right direction.)

For Admin Use

[ ] Not duplicate issue
[ ] Appropriate labels applied
[ ] Appropriate contributors tagged
[ ] Contributor assigned/self-assigned

The question is actually about hashing into scalars @burdges, for which you don't need try-and-increment, that's for hashing to EC points.
@matthiasgeihs You can use the DefaultFieldHasher, see https://github.com/arkworks-rs/algebra/blob/4152c41769ae0178fc110bfd15cc699673a2ce4b/ff/src/fields/field_hashers/mod.rs#L41, there's also a doctest which serves as a good usage example.


Fixes Command palette search

Fixes #119
Changes:

Rewrote a bunch of logic to fix the search filtering issue
Now uses Fuzzy search to filter possible commands in the CMD-K menu
This fixes the searching results not shown issue

cc: @seveibar

NOTE: still requires a bit of work with a weird bud and some refactoring, will do when i get some free time

@mrudulpatil18 can we merge to capture these changes?

@mrudulpatil18 can we merge to capture these changes?

Yup, it's working as of now

@seveibar
added absolute position for the cmd-k dialog


Version # of DNN Standard Extensions do not match DNN version

Description of bug
Version # of standard platform core extensions to not match DNN Platform version
Steps to reproduce
List the precise steps to reproduce the bug:

Install DNN97x
Log in as HOST
Goto Extensions
See error

Current behavior
Wrong version shown.
Expected behavior
Version # in line with DNN version.
Wrong #'s are shown for:

Authentication
Registration
Search Results
Users and Roles
View Profile
Default Authentication
Skin objects

Screenshots

Error information

Additional context
Tested on DNN971-RC1, but problem also exists in DNN970
Affected version

[ ] 10.00.00 alpha build
[X] 09.07.01 release candidate
[X] 09.07.00 latest supported release

Affected browser

[X] Chrome
[X] Firefox
[X] Safari
[X] Internet Explorer 11
[X] Microsoft Edge (Classic)
[X] Microsoft Edge Chromium

Was this an upgrade?

I noticed the same in a new install

@mitchelsellers: this was a clean new install

duplicates #3542 There was a PR to update those verisons but I think the way it was implemented only did it once, we need to do something that will do it on all releases...


Support versioned bounding box data

[ ] Add the following columns to the paper, entity, and summary tables:

[ ] job_id: the job that uploaded the data
[ ] active: a flag indicating whether this row should be considered active and hence should be seen in the user interface
[ ] created_at: timestamp that the record was created at

[ ] Update the pipeline upload scripts to

[ ] Before any uploads, generate a unique job ID that has not yet been created yet (can be through a singleton or global function)

[ ] API: support the requesting of data from specific job IDs (all matching data returned); otherwise, return the active data
[ ] UI: pass the job IDs parameter to the API

May also want to add want to make mathmlmatch table versioned as well.


⚠ Bofrost.es has degraded performance

In c8e3fc9, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1736 ms

Resolved: Bofrost.es performance has improved in 29a0746 after 6 minutes.


Label key "alertname" should be less visually dominating

This is a great tool and it really helps to see things clearer. I read about it on the Prometheus-User-Mailinglist. Thank you very much for presenting it there and moving it over here.
Following the spirit of clarifying I think the actual alertname (the value) should be more prominent than the label’s key. So in alertname: HardToRead the string HardToRead should be more prominent than the alertname.
It is good that the keys are so prominent for other labels, but for alertname less would do because one might use this to find an alert by skimming over and every alert has this label, seeing the precise letters of its key in detail is not as important compared to other labels’ keys.
I am not sure how to do this the best way, but here are a few proposals/ideas:

left-align the label (to simplify vertical skimming)
change the font redendering for the alertname key

less bold
less contrast
not render the key alertname at all

What do you think?

I think you're making a good point, I think it makes a lot of sense to put more focus on label values since keys will be repeated but values are going to be more unique.
Now when it comes to the implementation details of how this can be accomplished let's remember that alertname is just one of labels, it's a little special since it's injected by Alertmanager, but other than that it's simply yet another label.
You might have noticed that labels can have unique colors, those are calculated from the key: value pair. I did try to experiment with different styles where both key and value would have it's own color, but that was too noisy, some more experimentation could be possible there, but I doubt we can get more value there without adding noise, which would nullify said value.
We could also try to (as you suggest) tweak the font and the general style of the key, I think it requires a demo to see if that's useful.
Another option I considered in the past, just never implemented, is what you also have as one of the suggestions - don't display the key (alertname in this case) - what I was thinking is that there's a bunch of "standard" keys, like @alertmanager, @receiver and @alertname which are usually quite obvious (as in once you know that's alertname in the title you don't need to see that key again) and I wanted to only render the value until user hovers the cursor over the label, in which case we would expand it into a full label with both key & value.
Finally there's the case of which of those can be applied as a general rule to any label and which are alertname specific - I think the last option seems the best for me right now, dropping keys from well known labels could help reduce visual clutter, but still allowing user to still see the key if they are confused or unsure about it.

Shrinking/expanding label name will be tricky since resizing any label might move it to the next line losing hover state, so a tooltip/popover would be a better solution (but only for "well known" labels).
Names could be rendered smaller than values and with different color, but that will require backend changes and a bit of refactoring

Would this be more readable? I feel like the font might be a little too small now

First of all please excuse me for not answering before, somehow the notifications got filtered away by accident. I am so sorry, I value your wor and it was not on purpose. 😞
I agree, the smallness is a bit too small for my taste. Also if the size varies too much we always have content that is either too large or too small. Not ideal.
I still think that aligning the alertname to the left instead of centering it would help.

No worries and thanks for feedback. This is something that I don't have any strong opinion on so I appricate getting some input.
I feel like not centering alerts in the title (which I think is what you mean by aligning the alertname) would be good, since alertname label would always be in the same place. I'll try pushing layout changes to http://karma-demo.herokuapp.com. Thanks!

Please see https://github.com/prymitive/karma/pull/147#issuecomment-429648014 for the current changes

This looks nice 🤩
I love how the different colour used for some keys makes them really easy to differentiate from the value. E.g.: time, alertname and device. Surely adding instance would be good, maybe even for all labels?
It is tricky though to ensure a decent contrast for all colours and combinations.

Which labels are coloured is configured by the user, the only default is the black background for alertname, since that’s the only guaranteed label (injected by alertmanager).
See Labels section on https://github.com/prymitive/karma/blob/master/docs/CONFIGURATION.md

It is tricky though to ensure a decent contrast for all colours and combinations.

Yes, but I'm hoping I can improve this. Right now it's static, but for all generated colors we calculate brightness to decide if we should use bright or dark font. I want to see if I can use this information to pick better looking font color for the name part.


Alpha value slider fix (#44)

I've fixed the alpha value slider in the color picker, the issue was the color module returned alpha rather than a which react-color was expecting.
This fixes issue #44

I've fixed the alpha value slider in the color picker, the issue was the color module returned alpha rather than a which react-color was expecting.

Ohh this was one of the things I hated most.
Great you found that out - actually spent 0.5hr there and didn't figure it out.


Avoid mutating user passed in options

This fixes #924 and #903
Here's an issue demonstration borrowed from #924
h_int = {abc: :abc}
=> {:abc=>:abc}
h = {k1: h_int, k2: h_int}
=> {:k1=>{:abc=>:abc}, :k2=>{:abc=>:abc}}
Raven.capture_message "Test extra", extra: {h1: h, h2: h_int}

h
=> {:k1=>{:abc=>:abc}, :k2=>"(...)"}

There are 2 factors that cause the issue:

User-provided options will be embedded as part of the Event object.
When we encode the Event object, processors like RemoveCircularReferences use mutation methods like Hash#merge! to save memory allocation.

First Attempt - Drop methods that mutate the data
A quick fix is to change the step 2 to just use methods like Hash#merge. But this can have a significant impact on the memory allocation (about 16~17% more) per Raven#capture_message call.
Here's an example:
Code Change
# lib/raven/processor/removecircularreferences.rb
       case value
       when Hash
         - !value.frozen? ? value.merge!(value) { |_, v| process v, visited } : value.merge(value) { |_, v| process v, visited }
         + value.merge(value) { |_, v| process v, visited }
       when Array
         - !value.frozen? ? value.map! { |v| process v, visited } : value.map { |v| process v, visited }
         + value.map { |v| process v, visited }
       else
         value
       end

Allocation before the change
Calculating -------------------------------------
              master   448.434k memsize (    17.474k retained)
                         3.632k objects (    11.000  retained)
                        50.000  strings (     4.000  retained)

Allocation after the change + comparsion
Calculating -------------------------------------
              branch   519.698k memsize (    17.474k retained)
                         3.838k objects (    11.000  retained)
                        50.000  strings (     4.000  retained)

Allocation Comparison
Comparison:
              master:     448434 allocated
              branch:     519698 allocated - 1.16x more

A More Allocation-Efficient Solution - Duplicate user-passed data (options)
By duplicating user-passed objects, we can avoid the later mutations from changing the data user has. And because user-passed data usually won't be too big, we won't allocate too much memory by doing this. Here's an example:
Code Change
# lib/raven/instance.rb
   def capture_type(obj, options = {})
      # .....
      message_or_exc = obj.is_a?(String) ? "message" : "exception"
      + options = options.deep_dup
      options[:configuration] = configuration
      # .....

Allocation before the change
Calculating -------------------------------------
              master   448.434k memsize (    17.474k retained)
                         3.632k objects (    11.000  retained)
                        50.000  strings (     4.000  retained)

Allocation after the change
Calculating -------------------------------------
              branch   448.666k memsize (    17.474k retained)
                         3.633k objects (    11.000  retained)
                        50.000  strings (     4.000  retained)

Allocation Comparison
Comparison:
              master:     448434 allocated
              branch:     448666 allocated - 1.00x more

As you can see, this approach only allocates about 2xx bytes more of memory. So it's the approach I chose in this PR.
Question - Why making our own deep_dup extension instead of using ActiveSupport's?

It's not worth adding a new dependency just for one of its files. This could greatly impact the size of some non-rails apps.
The implementation of deep_dup is very stable and hasn't changed for 3 years. So it's not a great risk that we'll be out-of-sync on it.

Codecov Report

Merging #994 into master will decrease coverage by 0.42%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #994      +/-   ##
==========================================
- Coverage   97.76%   97.33%   -0.43%
==========================================
  Files          46       46
  Lines        2148     2102      -46
==========================================
- Hits         2100     2046      -54
- Misses         48       56       +8

Impacted Files
Coverage Δ

spec/raven/event_spec.rb
97.80% <100.00%> (+0.25%)
:arrow_up:

...ations/rails/overrides/debug_exceptions_catcher.rb
73.33% <0.00%> (-26.67%)
:arrow_down:

...s/rails/overrides/debug_exceptions_catcher_spec.rb
88.88% <0.00%> (-11.12%)
:arrow_down:

lib/raven/integrations/rails/active_job.rb
96.42% <0.00%> (-3.58%)
:arrow_down:

lib/raven/cli.rb
85.71% <0.00%> (-0.50%)
:arrow_down:

spec/raven/integrations/sidekiq_spec.rb
96.90% <0.00%> (-0.16%)
:arrow_down:

lib/raven/integrations/rack.rb
96.92% <0.00%> (-0.10%)
:arrow_down:

spec/raven/configuration_spec.rb
98.61% <0.00%> (-0.02%)
:arrow_down:

spec/raven/json_spec.rb
100.00% <0.00%> (ø)

spec/raven/processors/cookies_spec.rb
100.00% <0.00%> (ø)

... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 174515e...6f4f113. Read the comment docs.


Release/v1.2.0

Issue #, if available:
Description of changes:

Updating Contributing guide to be more exhaustive.
Fixing various bugs in GIS logic
Updating to use latest osml-imagery-toolkit.
Updating GitHub actions
Adding support for HTTP model endpoints
Adding support for feature segmentation geojson outputs

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

You're missing an update to setup.cfg to bump the version number to 1.2.0.

You're missing an update to setup.cfg to bump the version number to 1.2.0.

Updated version number.


update rook version from v1.1.1 to v1.1.2

some of the CSI bugs are fixed in rook v1.1.2 release and  we have added CSI toleration support in rook  v1.1.2 release
Signed-off-by: Madhu Rajanna<EMAIL_ADDRESS>Fixes: #196

/assign @jarrpa
/assign @davidvossel
let me know anything else  is required  apart from updating the rook version

@Madhu-1 You also need to run make gen-latest-csv to update the CSV with the new image.
/ok-to-test

@kshlm Thanks updated PR.

Thanks.
/lgtm


SAK-46758 Sorting is wrong on Sign-up

https://sakaiproject.atlassian.net/browse/SAK-46758

Related to: https://github.com/sakaiproject/sakai/pull/10137

I'd just use the same code as is in BaseUserDirectoryService.java for the sort name, tbh. StringBuffer is a lot faster than concatenation of strings, for a start. That code is battle hardened.


[Q] Will there be 32bit build?

So, will there be 32bit build?
Regards,
Miika

I think it shouldn't be a problem. I'll close this ticket when it will be ready

32bit build available for 1.4.0


Include votes in DAO.sol for distributing dividends

Now that we have a Voting contract, I would like to add two corporate actions to DAO.sol

Dividends from the invested ventures now get added to the DAO investment pool. A vote can be taken to distribute ether dividends from the investment pool to DAO stakeholders.
A vote should be allowed to allow further funding rounds in the DAO at a given price.

Now, I agree that point 2. is needed and feasible, but point 1. is definitely unfeasible, but without that having anything to do with voting. The mechanism of the DAO is that of the ERC20DividendableEth, where each stakeholder updates his account by his initiative because having the DAO distribute the dividends would be problematic from a gas usage perspective. Do you have another solution in mind, or perhaps you were just mistaken with this?

DAO is an ERC20DividendableEth, and so are the ventures it invests in.
The DAO invests in Ventures, and when the Ventures distribute dividends, the DAO collects them (using venture.updateAccount(this)) and adds them to the investment pool (just by increasing investmentPool by the amount of the claimed dividends).
A Voting can be done so that the DAO distributes dividends to investors. The voting would be to call dao.increasePool() (sending an ether amount to itself, which is a bit weird, we might need to refactor instead), decreasing investmentPool accordingly. After that DAO investors would have to call dao.updateAccount(investor) to claim their dividends.
By the way, what happens with the venture dividends currently? They seem to just accumulate in DAO.sol.
Does this make sense?

Alright, well, first, there is no such thing as an investmentPool in the DAO. It's just a left-over var that I really should have deleted (will do that in the following PR). Second, there is no call to increasePool() simply because it is a payable (external) function, and hence, you cannot call it from the same contract. What there is, instead, is a variation of the content of increasePool() inside profitFromVenture(). And, finally, third, the venture dividends accumulate in the venture.
So, no, it still doesn't make sense to me.

The profits from the ventures seem to go to DAO.sol:
    /**
     * @notice Profit from an investment by claiming dividends for the DAO on the venture.
     * @param venture The address of the VentureEth contract to profit from.
     */
    function profitFromVenture(address venture) public {
        totalDividends = totalDividends.add(
            VentureEth(venture).updateAccount(address(this))
        );
        totalDividendPoints = totalDividends
            .mul(pointMultiplier).div(this.totalSupply());
    }

DAO.sol inherits from ERC20Dividendable.sol, so this function could be implemented:
    function releaseDividends(uint256 amount) {
        totalDividends = totalDividends.add(amount);
        totalDividendPoints = totalDividends
            .mul(pointMultiplier).div(this.totalSupply());
    }

That function is exactly the same as increasePool. Anyway, what does that have to do with the dividend distribution scheme? So, if I get it correctly, you don't want the DAO to be able to disburse the dividends to all its shareholders through a Voting, all that you want is to have the DAO profit from the ventures (that is, to increase the pool) through a Voting, right?

It's exactly the same except it's not external payable. It assumes that the contract already has some ether to distribute as dividends.
The DAO already profits from the ventures (via profitFromVenture). So the DAO has ether that didn't come from the stakeholders. It has profits to either reinvest (funding more ventures through Votings) or distribute.
What I want is exactly the opposite of what you said:
I want for the DAO to be able to disburse the dividends to all its shareholders through a Voting. The DAO calls
        Voting voting = new Voting(address(this), threshold);
        voting.registerProposal(
            address(this),
            abi.encodeWithSignature("releaseDividends(uint256)", amount)
        );

And the DAO stakeholders would call dao.updateAccount(msg.sender).

Alberto, your proposal above is the exact same way the things work now, with except for a Voting when profiting from the ventures (which is what I said you want and you said you want the exact opposite). I guess I really don't get what you want.

Right now, ether profits from the ventures accumulate in DAO.sol (via profitFromVenture).
Right now, DAO stakeholders receive no ether dividends because no one calls dao.increasePool() with an ether amount.

Right?

Right.
Wrong! An investor can just call dao.updateAccount(myself). The increasePool functionality, as stated above, is included in profitFromVenture. Just take a look at profitFromVenture and be made full.

Aaaah, I see:
        totalDividendPoints = totalDividends
            .mul(pointMultiplier).div(this.totalSupply());

So currently, each time that the dao profits from a venture, all collected dividends are marked for distribution to dao stakeholders. That line could use a comment.
Cool, so what I want to do is to remove that line from profitFromVenture, and subject dividend distributions to a Voting instead.
That way, dao stakeholders decide what to do with the venture dividends:
a. Invest them in more ventures.
b. Distribute them as dividends to dao stakeholders.

a. If they invest them in more ventures, there is already a voting mechanism enabled for that.
b. This can't be done! You cannot distribute the dividends, you have to have each investor call updateAccount, which they can as well do as things are now.
I still don't get what you want.
Look, I should move to enable restarting the DAO and letting other investors come in using a Voting, and we can clarify your second requirement later (if there will still be something to clarify), is that fair enough?

I knew you would get it 🤸♂

Bu then, wouldn't there be issues related to how much to disburse as dividends? Because, if you look at profitFromVenture, it also does:
totalDividends = totalDividends.add(
            VentureEth(venture).updateAccount(address(this))
        );

which is what really does the trick.

Hmm, but this would mean I would have to break one feature of ERC20DividendableEth: that it always distributed dividends based on the token balances at the time of the pool increase.

Hmm, but this:
#### Notes
1. Changes in the token supply will affect any dividend distribution events. Any ongoing distribution events for which the contract has received the `ether` before the total supply change are unaffected.

would not hold true anymore, would it?

Can't we just have profitFromVenture subject to Voting? Why do we have to break it down?

I think we need to do some renaming in ERC20DividendableEth at least. It's a bit confusing what each variable is:
totalDividendPoints -> totalDividendsPerToken
lastDividendPoints -> claimedDividends
Would that be right?

No, it wouldn't. The names I think are fine. totalDividendPoints is just that: the points representing the total dividends now. They are not dividends per se, or tokens, they are just points.

They indeed are the ether per token that should be distributed as dividends. And in trying to prove it I found two bugs in the original code 👍
Check this scenario. Round 1:
Supply: 100 tokens
IncreasePool: 10 ether
TotalDividends: 10 (ether)
TotalDividendsPerToken: 10/100 = 0.1 (ether per token)
That's right, if we have 100 tokens and distribute 10 ether, each stakeholder has the right to 0.1 ether. Next round, let's distribute another 10 ether:
Round 2
Supply: 100 tokens
IncreasePool: 10 ether
TotalDividends: 10 + 10 (ether)
TotalDividendsPerToken: 20/100 = 0.2 (ether per token)
Still right, each stakeholder should have got by now 0.2 ether per token. If they claimed after the first round and got 0.1 per token then, when they claim now they will get 0.1 ether per token again, still right.
Let's do another round, but this time we mint and additional 200 tokens, before distributing another 10 ether.
Round 3 (wrong)
Supply: 300 tokens
IncreasePool: 10 ether
TotalDividends: 20  + 10 (ether)
TotalDividendsPerToken: 30/200 = 0.1 (ether per token)
That wouldn't be right. It would mean stakeholders that were in the first funding round can't get dividends until TotalDividendsPerToken crosses the 0.2 mark again.
Fixing the first bug: However, if we modify mint to  modify TotalDividends as in TokenDividends = TokenDividends*(newTotalSupply/oldTotalSupply) things would match:
Round 3(right)
Supply: 300 tokens
IncreasePool: 10 ether
TotalDividends: (20*300/100) + 10 (ether)
TotalDividendsPerToken: 70 / 300 = 0.2333... (ether per token)
That is right, people that already had tokens now get a third of the etherPerToken that they used to get (now 10 ether will give them only 0.03333 ether per token instead of 0.1).
Fixing the second bug: When minting straight into an account with 0 balance, their lastDividendPoints (now claimedDividends) should become totalDividendsPerToken.
When doing a transfer both the sender and the receiver should call updateAccount first.

I'll open an issue to fix ERC20DividendableEth.

Let's fix ERC20DividendableEth first, then we continue with this.

Can't we just have profitFromVenture subject to Voting? Why do we have to break it down?

Because the decision to distribute dividends and how much to distribute should be independent from what the ventures do. In an extreme case, the DAO stakeholders might want to liquidate all the venture portfolio, release all the ether as dividends, and with that liquidate the fund.
In less extreme cases, the DAO stakeholders would just look at the funds at the DAO, and decide how much to pay themselves (as dividends that are first released, and then claimed).

Now that there is an internal releaseDividends(amount) function for ERC20DividendableEth you can continue with the implementation of this. It should be a plain vote on whether to execute releaseDividends(amount).

How can this be, if ERC20DividendableEth cannot be fixed until we migrate to solidity 0.6? I remind you, ERC20DividendableETh, as it is on the fix/erc20-dividends branch, does not pass tests. One of the tests fails for unknown reasons, the other, because of this line:
uint256 differentialDPT = lastDPT[sender]
            .subd(lastDPT[recipient]);

which overflows in most of the cases (this was the .abs() issue).
On the other side, would it be ok to use ERC20DividendableEth as it is? I just wanted to know your informed opinion, after all, the releaseDividends part is working outside of the token transferring context.

You can resolve this issue working from master.
We will fix transfer of dividends after we migrate to solidity 0.6.


python311Packages.google-cloud-asset: 3.24.2 -> 3.24.3

Changelog: https://github.com/googleapis/google-cloud-python/blob/google-cloud-asset-v3.24.3/packages/google-cloud-asset/CHANGELOG.md
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 293851 run on x86_64-linux 1

2 packages marked as broken and skipped:

python312Packages.google-cloud-asset
python312Packages.google-cloud-asset.dist

2 packages built:

python311Packages.google-cloud-asset
python311Packages.google-cloud-asset.dist


setup failed

Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/tmp/pip-build-7VI_fe/pyfasttext/setup.py", line 2, in <module>
    from Cython.Build import cythonize
ImportError: No module named Cython.Build

----------------------------------------

Command "python setup.py egg_info" failed with error code 1 in /tmp/pip-build-7VI_fe/pyfasttext/

resolved after install :
pip install Cython --install-option="--no-cython-compile"
pip install numpy


Change README.md

README.md is still from DXVK so maybe it should change to prevent confusion?

Give me a few hours and I'll have something more useful written up

Isn't the unofficial plan to to have this work merged back into DXVK?

Isn't the unofficial plan to to have this work merged back into DXVK?

Yes.


Lack of documentation for "Partnered CA Providers"

There are two partnered CA providers specified in the doc, however, no configuration setup for the providers is given.
I just surveyed some materials provided by the CA providers officially as follows:

Digicert: https://www.digicert.com/azure-key-vault/connect-to-certcentral-quick-start-guide.htm
Globalsigh: https://www.globalsign.com/en/repository/globalsign-integration-guide-azure-key-vault.pdf

These materials can be included from the msdocs documentation?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2b55e4f7-8890-adc7-f6c5-28c224c96fe2
Version Independent ID: 2d6ddf78-3933-895e-fbd0-9f49aeeed8a2
Content: Certificate creation methods
Content Source: articles/key-vault/create-certificate.md
Service: key-vault
GitHub Login: @msmbaldwin
Microsoft Alias: mbaldwin

@juyamagu Thanks for the feedback. We are currently investigating into the issue and will update you shortly.

@juyamagu I agree. Having this information in this doc will be helpful. I have assigned this to the author to update the doc.

Article updated to add integration guides for partnered CAs with Azure Key Vault.

#close

#please-close


[Python] - mypy has release 0.990 and it seems to expose a series of python typing errors.

You can update mypy to 0.990 and then run tox -e format and you will see a lot of errors.
Some are related to the events.py and others are to mis using optional types.

I'll add this to my backlog

https://github.com/G-Research/armada/issues/1873


Remove requirement on urllib3 and requests

Since urllib3 and requests is very slow to be imported on Raspberry Pi, it would be better to remove it from the source code and implement urllib/urllib2 support. Especially since the code is pretty simple and doesn't need any special functionality from requests.

In the same light, I'd like to get rid of using the six library as well, as it is much faster/better to add the needed pieces straight in your code.


Example of the Readme is not working

Hi,
The mendelian randomization method you're providing seems really cool, and I wanted to try it.
However, the example of the README is not working anymore. Maybe some entry of the function changed without actualizing it.
Thanks for you work,
Best regards
Eliot Dessennes

Hi Eliot,
Thank you for alerting us to this, and I apologize that it does not work according to the README.
We have since changed some parts of the package to make it easier to use. The README has been updated with the new tutorial.
Thanks,
Noah

Hi Noah,
I managed to try your method, diving a little bit into the code.
Thanks for your reply, and your work !
Best regards,
Eliot
De: "Noah Lorincz-Comi" @.>
À: "noahlorinczcomi/MRBEE" @.>
Cc: "Eliot DESSENNES" @.>, "Author" @.>
Envoyé: Samedi 22 Juillet 2023 04:54:29
Objet: Re: [noahlorinczcomi/MRBEE] Example of the Readme is not working (Issue #1)
Hi Eliot,
Thank you for alerting us to this, and I apologize that it does not work according to the README.
We have since changed some parts of the package to make it easier to use. The README has been updated with the new tutorial.
Thanks,
Noah
—
Reply to this email directly, [ https://github.com/noahlorinczcomi/MRBEE/issues/1#issuecomment-1646420362 | view it on GitHub ] , or [ https://github.com/notifications/unsubscribe-auth/A5JSYXMVDAI3TXLU2ZSRYGLXRM6GLANCNFSM6AAAAAAYO2JUCQ | unsubscribe ] .
You are receiving this because you authored the thread. Message ID: <noahlorinczcomi/MRBEE/issues/1/1646420362 @ github . com>

Thanks, Eliot. Best of luck


unify config.ts environment and external configuration on a single configService

Category: enhancement
Severity:High
Config variables are scattered through the codebase, both on the config.ts and environment files. Also if we introduce runtime external configuration #146 is one source for config information.
IMHO environments files should be used for build time variables. For example I find that having URL for back-end services on these files is not the right way to configure the application as you have to rebuild an app for every environment.
I propose to have a configService that you can inject like other services that centralizes all this sources in one single point. This is similar to what Spring offers to the applications.

Maybe the configService should emit an Observable so clients can subscribe to changes
Also config could be saved to localStorage for user preferences, so they can override settings and survive reloads.
Got the idea from this article:
https://www.codemag.com/Article/1801021/Configuration-Settings-for-Angular-Applications


[doc] Add flash_ctrl checklist

Can it be considered D1 complete without someone reviewing and signing off?
On Tue, Nov 5, 2019, 17:49 Eunchan Kim<EMAIL_ADDRESS>wrote:

@eunchan commented on this pull request.
Thanks @tjaychen https://github.com/tjaychen for preparing the
checklist!
If you think the design reached D1, could you please also change
flash_ctrl.prj.hjson file too?
In hw/ip/flash_ctrl/doc/checklist.md
https://github.com/lowRISC/opentitan/pull/886#discussion_r342883558:

+RTL           | [ASSERT_KNOWN_ADDED][]| Done        |
+Code Quality  | [LINT_SETUP][]        | Done        |
+Review        | Reviewer(s)           | Not Started |
+Review        | Signoff date          | Not Started |

+[SPEC_COMPLETE]:      {{<relref "/doc/project/checklist.md#spec-complete" >}}
+[CSR_DEFINED]:        {{<relref "/doc/project/checklist.md#csr-defined" >}}
+[CLKRST_CONNECTED]:   {{<relref "/doc/project/checklist.md#clkrst-connected" >}}
+[IP_TOP]:             {{<relref "/doc/project/checklist.md#ip-top" >}}
+[IP_INSTANCED]:       {{<relref "/doc/project/checklist.md#ip-instanced" >}}
+[MEM_INSTANCED_80]:   {{<relref "/doc/project/checklist.md#mem-instanced-80" >}}
+[FUNC_IMPLEMENTED]:   {{<relref "/doc/project/checklist.md#func-implemented" >}}
+[ASSERT_KNOWN_ADDED]: {{<relref "/doc/project/checklist.md#assert-known-added" >}}
+[LINT_SETUP]:         {{<relref "/doc/project/checklist.md#lint-setup" >}}
+[D1_REVIEWED]:        {{<relref "/doc/project/checklist.md#d1-reviewed" >}}
I thought I removed this in ip_checklist.md.tpl.
In hw/ip/flash_ctrl/doc/checklist.md
https://github.com/lowRISC/opentitan/pull/886#discussion_r342883585:

+[DOC_INTERFACE]:       {{<relref "/doc/project/checklist.md#doc-interface" >}}
+[MISSING_FUNC]:        {{<relref "/doc/project/checklist.md#missing-func" >}}
+[FEATURE_FROZEN]:      {{<relref "/doc/project/checklist.md#feature-frozen" >}}
+[FEATURE_COMPLETE]:    {{<relref "/doc/project/checklist.md#feature-complete" >}}
+[AREA_SANITY_CHECK]:   {{<relref "/doc/project/checklist.md#area-sanity-check" >}}
+[DEBUG_BUS]:           {{<relref "/doc/project/checklist.md#debug-bus" >}}
+[PORT_FROZEN]:         {{<relref "/doc/project/checklist.md#port-frozen" >}}
+[ARCHITECTURE_FROZEN]: {{<relref "/doc/project/checklist.md#architecture-frozen" >}}
+[REVIEW_TODO]:         {{<relref "/doc/project/checklist.md#review-todo" >}}
+[STYLE_X]:             {{<relref "/doc/project/checklist.md#style-x" >}}
+[STYLE_LINT_SETUP]:    {{<relref "/doc/project/checklist.md#style-lint-setup" >}}
+[LINT_PASS]:           {{<relref "/doc/project/checklist.md#lint-pass" >}}
+[CDC_SETUP]:           {{<relref "/doc/project/checklist.md#cdc-setup" >}}
+[CDC_SYNCMACRO]:       {{<relref "/doc/project/checklist.md#cdc-syncmacro" >}}
+[FPGA_TIMING]:         {{<relref "/doc/project/checklist.md#fpga-timing" >}}
+[D2_REVIEWED]:         {{<relref "/doc/project/checklist.md#d2-reviewed" >}}

here again.
In hw/ip/flash_ctrl/doc/checklist.md
https://github.com/lowRISC/opentitan/pull/886#discussion_r342883722:

+Review        | [DESIGN_SPEC_REVIEWED][]              | Not Started |
+Review        | [DV_PLAN_TESTPLAN_REVIEWED][]         | Not Started |
+Review        | [STD_TEST_CATEGORIES_PLANNED][]       | Not Started |
+Review        | [V2_CHECKLIST_SCOPED][]               | Not Started |
+Review        | Reviewer(s)                           | Not Started |
+Review        | Signoff date                          | Not Started |

+[DV_PLAN_DRAFT_COMPLETED]:            {{<relref "/doc/project/checklist.md#dv-plan-draft-completed" >}}
+[TESTPLAN_COMPLETED]:                 {{<relref "/doc/project/checklist.md#testplan-completed" >}}
+[TB_TOP_CREATED]:                     {{<relref "/doc/project/checklist.md#tb-top-created" >}}
+[PRELIMINARY_ASSERTION_CHECKS_ADDED]: {{<relref "/doc/project/checklist.md#preliminary-assertion-checks-added" >}}
+[TB_ENV_CREATED]:                     {{<relref "/doc/project/checklist.md#tb-env-created" >}}
+[RAL_MODEL_GEN_AUTOMATED]:            {{<relref "/doc/project/checklist.md#ral-model-gen-automated" >}}
+[TB_GEN_AUTOMATED]:                   {{<relref "/doc/project/checklist.md#tb-gen-automated"
+>}}
Please move close tag to the above line.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/lowRISC/opentitan/pull/886?email_source=notifications&email_token=AAH2RSRRYJU2YO5ZTFZGZ6LQSIPCBA5CNFSM4JJN3DPKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCKNRG4I#pullrequestreview-312152945,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAH2RSR5GYRPHE3MTUHKT7TQSIPCBANCNFSM4JJN3DPA
.

Can it be considered D1 complete without someone reviewing and signing off?

This should maybe be made more explicit in the hardware stages doc, but the D$(n)->D$(n+1) transitions are handled via normal pull request review, it's just the life-cycle stages (L$(n)) that require more formality.

so if via PR review, does that technically mean i should submit this PR as
is, and another reviewer will go through and confirm my assertions and make
a separate PR?
On Wed, Nov 6, 2019 at 5:43 AM Alex Bradbury<EMAIL_ADDRESS>wrote:

Can it be considered D1 complete without someone reviewing and signing off?
This should maybe be made more explicit in the hardware stages doc
https://docs.opentitan.org/doc/project/hw_stages/, but the
D$(n)->D$(n+1) transitions are handled via normal pull request review, it's
just the life-cycle stages (L$(n)) that require more formality.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/lowRISC/opentitan/pull/886?email_source=notifications&email_token=AAH2RSSE6LHZDMEIPFJBS4LQSLCZRA5CNFSM4JJN3DPKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDGSC4Y#issuecomment-550314355,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAH2RSVJPOQQTYEB77MOMHTQSLCZRANCNFSM4JJN3DPA
.

as far as I understand, this PR here that you submitted serves this purpose, and we as reviewers decide whether it can go in or not. if something has to be amended, this needs to be flagged and discussed in this PR thread (and you would make separate PRs for those amendments). @asb is my understanding correct?

as far as I understand, this PR here that you submitted serves this purpose, and we as reviewers decide whether it can go in or not. if something has to be amended, this needs to be flagged and discussed in this PR thread (and you would make separate PRs for those amendments). @asb is my understanding correct?

Yes

Sounds good! Then review away!
On Wed, Nov 6, 2019, 11:22 Eunchan Kim<EMAIL_ADDRESS>wrote:

as far as I understand, this PR here that you submitted serves this
purpose, and we as reviewers decide whether it can go in or not. if
something has to be amended, this needs to be flagged and discussed in this
PR thread (and you would make separate PRs for those amendments). @asb
https://github.com/asb is my understanding correct?
Yes
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/lowRISC/opentitan/pull/886?email_source=notifications&email_token=AAH2RSSQF55USD56NMGDC4DQSMKN5A5CNFSM4JJN3DPKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDHWA4Y#issuecomment-550461555,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAH2RSX3LKS2K5TNCKEYRWTQSMKN5ANCNFSM4JJN3DPA
.


fix: include JSX related module in package

Fixes #503.

Will fix #502 to just have sel shorthand once you merge this.

Thank you, @nojvek.


Experiment with different file formats on AWS

Compare Zarr vs TileDB vs NetCDF.  Also try compressing with pbzip2 -5 (which reduces .nat files to 0.2x their original size).  Consider:

size on disk
write speed
read speed for queries similar to ones we'd use for the front-end and for ML training.

https://medium.com/informatics-lab/storing-cloud-ready-geoscience-data-with-tiledb-34d454c33055

Note to self:  @DPeterK at the Informatics Lab is also looking at benchmarking various file formats.


Fix size 1 simd butterflies

This fixes a problem where SSE and NEON size 1 butterflies don't work for out-of-place transform. The tests were not catching this because it was using a clone of the expected result as output. Therefore it could not catch that butterflies never wrote anything to the output.

Good catch. I must have cloned the input vec in the tests purely for the convenience of not having to specify the length again.
I'm slightly sad that in the case of an in-place transform, we do an unnecessary read and unnecessary write. I can think of some ways to fix it, but if you're doing a size-1 FFT you are almost certainly never going to notice its performance. So, better to keep it simple.

I'm slightly sad that in the case of an in-place transform, we do an unnecessary read and unnecessary write

Yeah I agree. I thought a little about it but couldn't come up with any simple way to avoid it. It probably doesn't matter though, anyone who cares about performance is not likely to do 1-point FFT at all :D


Merged the AbstractPartitionableKafkaInputOperator, AbstractKafkaInputOp...

...erator, AbstractKafkaSinglePortInputOperator classes

Please submit a new pull request to merge only AbstractPartitionableKafkaInputOperator and AbstractKafkaInputOperator after the idempotency changes are in.


[HOLD for payment 2024-12-16] Search - No sound when paying expense in Search

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.66-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers<EMAIL_ADDRESS>Issue reported by: Applause Internal Team
Action Performed:

Go to staging.new.expensify.com
Go to workspace chat.
Submit an expense to the workspace.
Click dropdown button on the expense preview.
Select Pay elsewhere (do not pay it).
Go to Search.
Click Pay button.

Expected Result:
There will be sound when paying expense in Search.
Actual Result:
There is no sound when paying expense in Search.
Workaround:
Unknown
Platforms:

[x] Android: Standalone
[x] Android: HybridApp
[x] Android: mWeb Chrome
[x] iOS: Standalone
[x] iOS: HybridApp
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
https://github.com/user-attachments/assets/bcab246a-46d3-4a7a-b0a0-147a9b323320

View all open jobs on GitHub
Issue OwnerCurrent Issue Owner: @bfitzexpensify

Yea, I'll look into this thank!

Working on it this week

Payment summary:
@jjcoffee owed $250 via NewDot manual request

$250 approved for @jjcoffee


[CLI] Refactor CodeEditCli

Current Situation
At the moment the CodeEditCli is just a standalone SPM package in our main repo:

https://github.com/CodeEditApp/CodeEdit/tree/main/CodeEditTests

The built binary is then included as a resource in our main workspace:

The Problem
The problem with this approach apart from having a binary in our sources, which technically isn't needed, is that it prevents our app from notarizing.
Proposed Solution
I suggest moving the CodeEditCli package to a new repo (like CodeEditTextView) and then attach the binary to a tagged release as an artifact.
I may also suggest renaming the artifact to codeedit-cli in order to make clear what the binary really is. An alias codeedit can always be created by the user if needed.
This would mean the main app needs to download the latest artifact and move it to the according location in GeneralPreferencesView.swift:215. The location should be /usr/local/bin/codeedit.
Additionally we could also add it to homebrew as a formula codeedit-cli.
Please let me know what you think about that approach and let's discuss what could be improved further in this regard. I then will create the repo in the organization.

I like this idea. As long as we can properly do all that we need to do to communicate with the main app.

Perfect. Then let’s do it!

I just created the repo here.
It builds and deploys the artifact correctly in GH actions.
The only thing missing is notarizing the cli binary:

https://github.com/CodeEditApp/CodeEditCLI/issues/1

Until then the binary cannot be executed once downloaded.

Closing because the new repo has been created. If further discussion is necessary, please open an issue in the new repo.


Handle RTCState.counter internally

It seems like we could have RTCCollection just take care of incrementing the counter itself.

Counter is incremented after any message comes in from another user, so the actual incrementing needs to be handled with new messages.
We can allow a running counter to be set, though.

Fixed in 350f186


AppAsset Frustration

Hi,
This is frustrating. I have this file:
<?php

namespace app\themes\brave;

use yii\web\AssetBundle;

class ThemeAsset extends AssetBundle
{
    //public $basePath = '@app/themes/brave/asset';
    //public $baseUrl = '@web/assets';
    public $sourcePath = '@app/themes/brave/asset';
    public $css = [
        'css/test.css',
    ];
    public $js = [
    ];
}

I register the Asset in my main layout:

	use app\themes\brave\ThemeAsset;
	ThemeAsset::register($this);

The file is published but is not showing on the rendered html.

Anyone can advise?

Are you calling head() function on your main layout ? For example like this:
use app\themes\brave\ThemeAsset;
ThemeAsset::register($this);
$this->head();

Hi,
use app\themes\brave\ThemeAsset;
ThemeAsset::register($this);
$this->head();

I just tried it, what it output is this:
YII-BLOCK-HEAD
no trace of my css file yet.
Thanks

you need to include the entire life cycle of the view http://www.yiiframework.com/doc-2.0/guide-structure-views.html#creating-layouts
YII-BLOCK-HEAD
Is meant to be replaced when you call endBody and endPage on the layout.
http://www.yiiframework.com/doc-2.0/guide-structure-views.html#creating-layouts

That is great. It came out. =)
Thanks a lot


Upgrading azure-eventhubs 0.13.1 to azure-eventhubs 0.15.1

Type of issue

[ ] Bug
[ ] New feature
[X] Enhancement

Description
Shall i fork and update the azure-eventhubs to 0.15.1
reason being azure-eventhubs had servicebus package as part of this .. Now its been moved to different library.. Due to which in a project we cannot use both references.
For example
step1 - IotHubreact to read messages from IOT HUB
step-2 do some business processing
step-3 put to azure service bus queue (using the azure-servicebus 1.1.1)
Please advise.??

Any updates on this issue? In the meantime azure-eventhubs is at 1.1.0 and using the current version is very hard in conjuction with any of the up-to-date azure libraries.
Would forks be accepted?


AKPlayer.load() on a file crashes after upgrading to 4.10 (from 4.9.4)

AudioKit.AKFaderAudioUnit input format must match output format
2020-06-02 12:15:08.494929+0530  [avae]            AVAEInternal.h:109   [AVAudioEngineGraph.mm:4170:UpdateGraphAfterReconfig: (AUGraphParser::InitializeActiveNodesInOutputChain(ThisGraph, kOutputChainFullTraversal, *conn.srcNode, isChainActive)): error -10868
2020-06-02 12:15:08.497253+0530 *** Terminating app due to uncaught exception 'com.apple.coreaudio.avfaudio', reason: 'error -10868'

Another observation - it happens when connected to a bluetooth speaker with a different sample rate than the file - so, my  file is 48K, bluetooth is 44.1K. If I disconnect bluetooth, the crash goes away.

Could the recent AKSettings sampleRate / audioFormat changes be causing the issue?
I have a file, 48 KHz, 32 bits/sample (default recording format on iphone x).
I connect to a audio route that has a 44.1 Khz sample rate.
then, a player.load(url: "path to fie") crashes.
If I disconnect the audio route, the app needs a kill, before the native sample rate is applied. a restarted app on the device's default speaker works fine.

Yet another clue -- I went back to 4.9.4 and this crash is not happen anymore ... however, if I use
player.fadeOutAndStop(time: 1.0), upon stopping player, there's the same crash (this is on the device, native sample rate). Funnily, I was not using fadeOutAndStop in 4.10, and the crash happened with a speaker of different sample rate.
-gd

Just to clarify, you are playing back a stereo 48k file and AudioKit.output is set to 44.1k, correct?

Work around for the moment is to just make a new AKPlayer if you are changing the sample rate:
// for now just make a new player so it's not necessary to rebalance format types
// if the processingFormat changes
if player != nil {
player?.detach()
player = nil
}
player = AKDynamicPlayer(url: url)
// plug it back in

Hi, I've just pushed up an update that will address this. This will be in the v5 develop branch for now, but you could handle on your end as well by monitoring processingFormats.
For performance reasons, sample rate isn't quite as flexible as it used to be. Only if necessary will AKPlayer do real time sample rate conversion and this requires installing an AKMixer into the graph. This means, that if you want to change the processingFormat, you should create a new AKPlayer and detach the old one. This was unclear previously with that load() command, and I've now just pushed up a version that will throw and suggest you make a new player in this scenario.
I've also updated the macOSDevelopment project to show this in practice:
    /// open an audio URL for playing
    func open(url: URL) {
        inputSourceInfo.stringValue = url.lastPathComponent

        do {
            try player?.load(url: url)

        } catch let err as NSError {
            AKLog("🚩", err.description)
            createPlayer(url: url)
        }

        AKLog("Opened", url.path, "duration", player?.duration, "processingFormat", player?.processingFormat)
    }

    private func createPlayer(url: URL) {
        // make a new player so it's not necessary to rebalance format types
        // if the processingFormat changes
        if player != nil {
            player?.detach()
            player = nil
        }
        AKLog("Creating player...", url)
        player = AKDynamicPlayer(url: url)
        player?.completionHandler = handleAudioComplete
        player?.isLooping = loopButton.state == .on
        connectPlayer()
    }

Will likely be merged into v5 today.

Thanks a ton, Ryan!
I've been unclear on this before and avoiding reconnecting notes dynamically like the plague...
Can you advice as to how to reattach notes in an existing (rather complex) graph without restarting the engine?
I'm sure it'll help other devs too, based on my searches on SO and audiokit issues, etc.
Thank you in advance.

Thanks for the detailed reply!! Really appreciate all your help :-)
Is there a way to stave off any format / route changes, for example in the middle of renderToFile? That seems to truncate recordings (at least thats the theory I have)

sorry, i don't really work with iOS much, so I don't have any good advice for those types of changes, if that's what you mean.
It seems to me that the application shouldn't allow format changes during rendering.

Any chance the fix will be in v4? v5 is a few months away (I tried but my code isn't quite working. since there's a few months before it's ready to be tested, there'll be a lot of changes between now and then, so will try later).

i think we can merge that change to v4 yes... @aure  ?

Made the change in v4, though, it is a fairly minor difference, You'll still need to catch the error on your load() and rebuild your player graph if the format changes like the previous example I gave

Many thanks! Yes noted -- I'm going to need to restructure code quite a bit to allow for rebuilding the graph in the middle of the app.

it really shouldn't be too hard to do as a player is generally a node at the end of a chain. a player doesn't accept input, so it just needs to be detached and reattached.

Aloha!
I have a simple music player app that creates a chain on startup (player -> eq -> limiter -> mixer -> output).
I have a list of tracks and when a track is selected, I load the corresponding file to the player. when the user navigates back, i stop playing.
I've been using the latest v4 branch and now the v4 dev branch, and running into issues that could be potentially related to this bug perhaps.
I have a simple app to demo the problem.
4 buttons : play 44.1K file, play 48K file, play a oscillator tone, stop all.
On all sample rates (on simulator @ 44.1K and physical devices with 48K rate), oscillator works fine.
On my iphone 7, (48K native sample rate), I set the a 48K rate and then the  play48() and playTone() works. but play44() crashes with the following:
2020-06-22 18:56:33.265543+0530 rhinoPlayer[37426:1843219] AudioKit.AKFaderAudioUnit input format must match output format
Even if I set the audiokit sample rate to 44.1K before playing, it's the same crash.
Here's the project, I'm building from audiokit v4 developer branch.
https://drive.google.com/drive/folders/1Gg218GAtefB__rAvR3mMTqPzC5MNOjuX?usp=sharing
I'm not sure if i'm doing something wrong / not doing something or if it's a genuine bug.
Also, in this kind of chain, player is not a child node. how can I change the player without having a crash? I'd really appreciate some advice!
Aloha!

it sounds like your processing formats don't match.
if they can't, then put an AKMixer before the player so that sample rate conversion happens. I don't recommend that though.
AKSettings must be set before you establish any connections whatsoever.

Thanks Ryan,
I have one file that's wav at 44.1K, another that's wav at 48K. Users can import files of various formats into the app (in theory).
Why is a mixer before player not recommended?
What's the downside? To clarify, do you mean:
mixer(no inputs) -> player -> etc -> out? How will loading a file to player that's a different format affect the mixer above? Not sure I grok.
I could have files of different formats. How do I handle them at run time then?

since player can't take a input node, not sure how to connect a mixer before. I see you've deleted that part of the comment though.
The thing is that this was working before, on 4.9.4. now it's crashing reliably. I don't see how I can update to further versions -- looks like i may need to pull my app from the app store at some point in the future unless I can figure this out :-(

you just need to look at the format of your incoming file. If it is different, then you should make a new AKPlayer and reconnect it. This is pretty simple to do as a player is the sound source.
AKPlayer will install a mixer on instantiation if formats differ. It won't on a load(). I can consider adding that though. Note, I don't recommend this approach due to performance reasons. Realtime sample rate conversion isn't ideal.
You can of course, just make your own player too. The source code is all there.

An example of that load() with a new player looks like is in the macOSDevelopment project:
https://github.com/AudioKit/AudioKit/blob/v5-develop/Developer/macOS/macOSDevelopment/macOSDevelopment/ViewController.swift
See: open(url:

Aah i see! This code makes it very clear! Thanks a ton, Ryan!
Aloha!

Aloha!
I think this is what i've been hitting! (https://github.com/AudioKit/AudioKit/pull/2131)
Thanks for fixing this :-)
Any change this can be put in v4-dev? I'd love to start using v5 but my code crashes. Looks like v5 isn't ready for primetime yet...?

i think we did merge to v4...

oh you mean the fade out one? could prob merge that i think

It would be more useful to identify what is crashing for you in AK5 though?

oh you mean the fade out one? could prob merge that i think

That'll be great. I'm 99.99% sure that's what I'm hitting in 4.10. That should unblock my app!

It would be more useful to identify what is crashing for you in AK5 though?

I tried to migrate to 5dev - took time (Doubles to AUValue all over, parameter -> parameter.value, AudioKit->AKManager etc).
At the end it crashed when setting up the graph. Assuming the branch isn't ready. I reverted. :-( Should have saved a copy.
If you think I can port my production app without a great deal of disruption to v5 dev, I'd be happy to. Or, when you think its ready - say in a month or so?

I am using v5 in a production setting, so of course am interested to hear exactly which parts are unstable in other areas. It's going ok for me on macOS. But, we're not really going to be supporting v4 builds at some point which is up to @aure
So, it's best to try to migrate to v5 as soon as you can.
Yeah, all the AUValue vs Double is a pain, but hopefully not too much else.

https://github.com/AudioKit/AudioKit/issues/2134#issuecomment-654186903 beat me to it.
I'm seeing the same problem with AKSampler.
Aloha
-Q


[WIP] Add Oracle support

Rebased but having problems. Not done to merge.

Can now run tests with:
GORM_DIALECT=oci8 go test -v -tags oci8

Currently failing with the following output: https://gist.github.com/andreynering/ae4caef4edf7d58f2711f954c82ef102

Hey! I'd love to use this, and contribute to it if you need any help. Are there any specific things that are left to do? If you could share that I'd be happy to pitch in.

@agamdua
I haven't touched this in 4 months.
Some things were working, AutoMigrate, queries, etc.
But there was some problems. Those I can remember are: limit and offset, I don't know how to make auto increment with (need to fetch sequence value first to then insert), Oracle has length limit for constraints and indexes names, lots of failing tests, others I can't remember...
Anyone that want is free to continue my work, just fetch the branch on my fork.

@agamdua Are you working on this? Need help? Not sure how surmountable the issues are, but would love to use gorm with Oracle.

Anybody is developing a dialect oracle?????

@giorgiootto No, nobody. Oracle is harder to support than other databases, so I don't know if that will ever happen.
But if anyone is willing to work on this, feel free to hack with the oracle branch on my fork.
You can take a look at Xorm that seems to support it (I haven't tried myself), or use raw SQL.

I've forked gorm and built a dialect for oracle into it.
I might have broken the dialect for mysql. However, postgres and oracle definitely work. Issues with limit and offset have been resolved. Inserts and updates also seem to be working.
I haven't explicitly checked preload, however, I think it works. This is based on the fork created by @andreynering. We are currently using my fork to work with both oracle and postgres. If anyone is still looking for this, please feel free to contribute/raise issues for the same.

Good news. It´s great.

@misterEggroll any chance to have an ETA of the PR here?

@misterEggroll any chance you can use goracle instead of go-oci8 in your fork?

@cjbj You could try it yourself TBH. There's only one place where I specifically use go-oci8. When I try to resolve the ID of the record by making use of the oracle rowID.
I could help you out if you're looking to do that.


Unable to close stitch menu after opening single page PDF

If you open a multi-page PDF and open the stitch menu, if you then open a single page PDF the icon button for "hide stitch menu" goes away but the menu is left open, unable to be closed unless you refresh or open a multi-page pdf again. menu should be closed automatically if the open/close stitch menu button is hidden.

Whoops! I'm not sure about automatically hiding it though. Then they can't open it again. Might be annoying if you're only trying to look at one page at a time. Maybe we should always show the stitch menu but have it be disabled when there's only one page?

Here's a test if the page count changes: if page count is 1, hide the menu. otherwise, if the page count is more than 1, set it to open by default. I think that's what we're going for, correct?

Sorry, I missed a word in there! I meant always show the stitch menu button not the whole menu.
I think the flow you mentioned works @hluedeke!

Ok, I have it on a new branch I'm working on right now 👍


Feature #7159 Add GPS initialization command auto correct tool

Corrects malformed NMEA sentences by calculating and appending the checksum and adding missing special characters "$" and "*"

Working block (before):
$PUBX,40,GSV,0,0,0,0*59
$PUBX,40,GLL,0,0,0,0*5C
$PUBX,40,ZDA,0,0,0,0*44
$PUBX,40,VTG,0,0,0,0*5E
$PUBX,40,GSV,0,0,0,0*59
$PUBX,40,GSA,0,0,0,0*4E
$PUBX,40,RMC,0,0,0,0*46
$PUBX,40,GGA,0,0,0,0
$PUBX,40,TXT,0,0,0,0
$PUBX,41,1,0007,0003,9600,0
$PUBX,40,ZDA,1,1,1,1
Autocorrected block:
$PUBX,40,GSV,0,0,0,0*59
$PUBX,40,GLL,0,0,0,0*5C
$PUBX,40,ZDA,0,0,0,0*44
$PUBX,40,VTG,0,0,0,0*5E
$PUBX,40,GSV,0,0,0,0*59
$PUBX,40,GSA,0,0,0,0*4E
$PUBX,40,RMC,0,0,0,0*47
$PUBX,40,GGA,0,0,0,0*5A
$PUBX,40,TXT,0,0,0,0*43
$PUBX,41,1,0007,0003,9600,0*10
$PUBX,40,ZDA,1,1,1,1*44

As for the ublox commands, I don't have a ublox to test with yet(one is on the way), but I would suspect it is related to one of the last two commands, though not sure immediately why. Which GPS model are you working with? Could you try? Also what is your baud rate set to(the config option not the PUBX command)?
$PUBX,40,GSV,0,0,0,0*59 $PUBX,40,GLL,0,0,0,0*5C $PUBX,40,ZDA,0,0,0,0*44 $PUBX,40,VTG,0,0,0,0*5E $PUBX,40,GSV,0,0,0,0*59 $PUBX,40,GSA,0,0,0,0*4E $PUBX,40,RMC,0,0,0,0*47 $PUBX,40,GGA,0,0,0,0*5A $PUBX,40,TXT,0,0,0,0*43 $PUBX,41,1,0007,0003,9600,0 $PUBX,40,ZDA,1,1,1,1*44
$PUBX,40,GSV,0,0,0,0*59 $PUBX,40,GLL,0,0,0,0*5C $PUBX,40,ZDA,0,0,0,0*44 $PUBX,40,VTG,0,0,0,0*5E $PUBX,40,GSV,0,0,0,0*59 $PUBX,40,GSA,0,0,0,0*4E $PUBX,40,RMC,0,0,0,0*47 $PUBX,40,GGA,0,0,0,0*5A $PUBX,40,TXT,0,0,0,0*43 $PUBX,41,1,0007,0003,9600,0*10 $PUBX,40,ZDA,1,1,1,1

Not sure what model it is, it's been around for years and has no identifying markings on the case. It shows up as a USB/Serial adapter
ugen0.2: <Prolific Technology Inc.> at usbus0
uplcom0: <Prolific Technology Inc. USB-Serial Controller D, class 0/0, rev 1.10/4.00, addr 2> on usbus0
Even changing the *46 to *47 breaks the GPS, but it seems to not want checksums on any of those later lines. Baud rate is 9600 all-around (in the GUI, in the init strings, and in /etc/remote on the gps0 line). It works fine on reboot with my original init block, but not with any of the altered/"corrected" ones. Maybe it's just this GPS...

I've been wondering why that default init looked so mangled and suspected it was to support a GPS that does not handle proper format. So you say it is the switching of $PUBX,40,RMC,0,0,0,046 to $PUBX,40,RMC,0,0,0,047 that seems to break it?

Not just that but it seems putting a checksum on any of the lines that doesn't have a checksum causes it to fail in some way or another.

So the GPS doesn't like the checksum on the later commands but has no problem with it for the earlier commands? What happens if you enable GGA does it output GGA or just not support it? $PUBX,40,GGA,1,1,1,1 or $PUBX,40,GGA,1,1,1,1*5A


[WIP] Implement Lookahead optimizer

Partially fixes https://github.com/chainer/chainer/issues/8153, implementing the lookahead optimizer (https://arxiv.org/abs/1907.08610).
This PR mostly aims to demonstrate a possible implementation and might not be suitable in Chainer in which case we can close this PR (this optimizer might not be suitable at all considering the fact that PyTorch rejected it).
It introduces a new GradientMethod  that is slightly different from the existing ones in that it accepts an Optimizer instance as an argument and updates using that one in the "inner loop". ~Thus, there are some tricks in order to get around initialization/serialization/deserialization such as overriding setup and _init_states. I might be missing some.~ There are other ways to implement this optimizer e.g. using arguments to existing optimizers or in the Updater layer but I didn't think those would be easier to maintain. I'd be more than happy to hear other ideas.
TODO

[ ] Write tests.
[ ] Compare results with paper.

Overwriting the update rules in setup we cannot do of course. I now feel nesting optimizers isn’t really ideal.

Changed to instead patch the given base optimizer update rule.

Dumping some plots from short runs. All Lookahead hyperparameters are set to default. Just for the record, learning rates of the base optimizer should probably be increased, by roughly a factor of 10 or so when using Lookahead. This requires more runs to be verified though.

ResNet50 (chainercv), CIFAR-100, CorrectedMomentumSGD (default params but lr=0.15)

w/o Lookahead

w/ Lookahead

ResNet50 (chainercv), CIFAR-10, MomentumSGD (default params), ExponentialShift (see train_cifar.py)

w/o Lookahead

w/ Lookahead

Exponential shift reduced the learning rate of the alpha in Lookahead, and thus slowed down training. This was a misconfiguration.


Evacuation ctrl: Wait for all informers' cache sync

What this PR does
Before this PR:
Currently, the evacuation controller has four informers:

vmiInformer
vmiPodInformer
migrationInformer
nodeInformer

but it only waits for two of them.
After this PR:
Add a wait for all informers' cache to be synced.

Fixes #
Why we need it and why it was done in this way
The following tradeoffs were made:
The following alternatives were considered:
Links to places where the discussion took place:
Special notes for your reviewer

Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

[ ] Design: A design document was considered and is present (link) or not required
[X] PR: The PR description is expressive enough and will help future contributors
[ ] Code: Write code that humans can understand and Keep it simple
[ ] Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
[ ] Upgrade: Impact of this change on upgrade flows was considered and addressed if required
[ ] Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
[ ] Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
[ ] Community: Announcement to kubevirt-dev was considered

Release note

NONE

/approve

/cherrypick release-1.2


Create a subsite for the GSSP content

The GSSP pages, like the Guide pages, are styled plainly and should match the rest of the stratigraphy.org.
Also, content for 3 - 4 years of GSSP updates is missing and needs to be added (to be supplied by Stan)

See https://github.com/i-c-stratigraphy/gssps


[Bug] Overlapping LocaleSwitch & ThemeSwitch Button

Is there an existing issue for this?

[X] Yes, I have searched the existing issues and none of them match my problem.

Product Variant
Self-Hosted
Current Behavior
GitHub and Google authentication are overlapping the LocaleSwitch and ThemeSwitch button in the authentication page.
Image 1: Microsoft Edge
Image 2: Brave Browser (Chromium derivative)

Expected Behavior
Should not overlap each other.
Steps To Reproduce

Go to https://rxresu.me/
Click on Get Started button.
Look at the bottom at the left side of the page.

What browsers are you seeing the problem on?
Chrome, Microsoft Edge
What template are you using?
None
Anything else?
Already have a solution. Would love to be assigned to it.

Opened the bug from Company's Peronal ID GitHub account. Opening from my personal id.


No module named 'numpy' on default install

to reproduce install gh/uv:
gh repo clone ibis-project/ibis-ml
cd ibis-ml
uv venv
. .venv/bin/activate
uv pip install -e .

then try importing IbisML:
import ibis_ml as ml

traceback:
[ins] In [1]: import ibis_ml as ml
---------------------------------------------------------------------------
ModuleNotFoundError                       Traceback (most recent call last)
Cell In[1], line 1
----> 1 import ibis_ml as ml

File ~/repos/ibis-ml/ibis_ml/__init__.py:7
      3 __version__ = "0.1.2"
      5 import pprint
----> 7 from ibis_ml.core import Recipe, Step
      8 from ibis_ml.select import (
      9     categorical,
     10     cols,
   (...)
     27     where,
     28 )
     29 from ibis_ml.steps import *

File ~/repos/ibis-ml/ibis_ml/core.py:15
     13 import ibis.expr.operations as ops
     14 import ibis.expr.types as ir
---> 15 import numpy as np
     16 import pandas as pd
     17 import pyarrow as pa

ModuleNotFoundError: No module named 'numpy'

numpy and pandas were removed as required dependencies for the default installation of Ibis: https://github.com/ibis-project/ibis/pull/9564

Thanks for raising. The NumPy and pandas dependencies should only be required when working with these data types (e.g. they shouldn't be needed when working with Polars dataframes), so it's mostly a question of importing in the scope of these functions. @jitingxu1 I see you had already looked at this issue; can you see if can update your PR (or raise a new PR) to do this?


Unused id parameter in Create action

The unused id parameter in the Create action is now used to check if the item exists. This seems more consistent with the Edit action, since it uses its id parameter for a lookup.

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

@ardalis  please review

I think I'd rather just get rid of that unused parameter. Looking at the code I think that should work fine. I don't like having two different IDs that might not match as inputs to the method. @mwvdev agree?

@ardalis I agree, removing it seems more in line with DRY.
Might be a bit confusing for newcomers that the API documentation at Consuming a RESTful Web Service specifies that Create takes an id parameter, maybe that part should be revised since it does seem that the request body contains all required information.
It seems like the postman example screenshot for the create action doesn't provide the ID parameter as is, so that part of the documentation doesn't need updating.

My preference would be to not have an id in the arguments for Create/POST. I'll see if we can update the Xamarin article to match this. If not, my second choice would be to confirm that the id parameter and the id on the model (ToDoItem) match, and if not, throw an exception. At that point, it doesn't matter which is used to check for if the id already exists.

I agree. Should I close this PR?

@mwvdev if you make a new PR that checks that id == item.Id and throws if they don't, I'll accept it.

@ardalis Sounds good, I'll get right on it.

@mwvdev hang on; we might yet be removing id if we can sync the other doc. I'll let you know.

Alright, thanks!

Ok, new plan. Please remove {id} from both Create and Update (Post/Put) and make a new PR. The Xamarin article has already been updated accordingly. https://developer.xamarin.com/guides/xamarin-forms/cloud-services/consuming/rest/

@ardalis Great, I'll get right on it.


superclass mismatch error

I included the gem in my gemfile and ran bundle install, but then got the following error when trying to generate the migration
.rvm/gems/ruby-2.0.0-p247/gems/impressionist-1.5.1/lib/impressionist/models/active_record/impression.rb:5:in `<top (required)>': superclass mismatch for class Impression (TypeError)
I found that file and renamed the class to something random, and it appeared to work fine.
I have no other classes named 'Impression' so I'm not sure what is causing this. I'm on rails 4 by the way.

Am seeing the same issue with rails 4.1, am hesitant to just randomly rename that class.
It seems there is another Impression class defined under app/model/impression.rb, could be a conflict with that?


Update installing-knative-locally.md

Checklist

[ ] commit message follows commit guidelines.
[ ] website builds and runs in production - for information on how to test locally go here.

Description

Related Issues

#issue-number

Is this a duplicate of https://github.com/appsody/website/pull/267?

Is this a duplicate of #267?

This has the additional notes from #267 so after this one is approved/merged then #267 can be closed.


Improved configuration of the tool

No more multiple .env files.
Removed unnecessary env variables, such as Channel name, slack username etc, because it should be configured through the Slack UI during webhook configuration.
Now deployment work without installed AWS CLI. You fill access key and secret at .env file
Cloudwatch notifications don’t require specific SNS topic name to have a proper parsing.
Makefile changed to npm scripts to keep consistent and run everything through npm.

Oh this looks very exciting and very much much needed :D Thanks for the PR
Give me a couple of hours and I'll pull it and test everything out and leave any comments for you. :+1:

@CodyReichert Also we wrote the article with full installation instructions, so next week it will be published and we will submit another PR with the link with a full guide.

This is fantastic work. And I will definitely merge it. I have a few
observations:

I use Makefiles extensively on every project. But mainly to automate
my own commands. I think it's good to remove it as it can confuse many
people used to simple nodejs infrastructure. :+1:

@CodyReichert Also we wrote the article with full installation instructions, so next week it will be published and we will submit another PR with the link with a full guide.

Either way, definitely open a new PR when you do.

Can you fix the simple review comments? If you disagree with any,
that's okay they are not blockers.

Additionally, it would be great if you and your team could help us keep
improving the per-service notifications to be even more accurate.
All-in-all, I'm very happy about this PR. Thank you!

@creichert @CodyReichert

Do we need to have package-lock.json in git? Or I can add it to .gitignore?
I prefer if PR be merged with squash to not store unnecessarily changes like

- ![AWS Cloud Notification for Slack](https://github.com/assertible/lambda-cloudwatch-slack/raw/master/images/cloudwatch.png)
+ ![AWS Cloud Notification for Slack](https://github.com/pixel-point/lambda-cloudwatch-slack/raw/master/images/cloudwatch.png)

in git. Do you agree?

@proAlexandr 	I can rebase them, but in the future you could do an interactive rebase locally:
git rebase -i HEAD~6 # rebase number of commits on that base branch

Then, squash all commits into the last one and git push -f origin branch. No worries, though, just saying that is possible.

@proAlexandr fantastic contribution, I can add you as a collaborator on this repo so you can more quickly make changes and approve pull requests, if you want? We'd still like to have a PR for all changes.

I can add you as a collaborator on this repo so you can more quickly make changes and approve pull requests, if you want?

@creichert Thank you, but for now, I think it is not necessary.


Update parallel_state.py

commenting out all code which check parallel group initialized

Thank you for your contribution! Can you elaborate more on why the changes are needed?

Close this PR since there is no update and we will also refactor this part later.

@zhuohan123
The issue arises when attempting to initialize two Language Model Instances (LLMs) within a single service, triggering this error.

from vllm import LLM
llm = LLM(model='microsoft/phi-2',trust_remote_code=True)
AssertionError: tensor model parallel group is already initialized

from vllm import LLM
llm = LLM(model='microsoft/phi-2',trust_remote_code=True) AssertionError: tensor model parallel group is already initialized i'm run code in gg colab

did you solve this?


Question: Adding Language to Tweet Metadata

I noticed that even though you can filter on language, Twint doesn't return a field with the language code in it with the tweets.
I was looking at adding this, as it isn't hard to pull out of html that Twint scrapes, but I haven't quite figured out how to add that field to the tweet object that Twint creates.  I mean, I have added it to the Twint object, but clearly there is other processing happening somewhere in Twint that isn't picking up my added attribute on the object.   Does someone who is better at untangling OOP know what else I need to change?    Here's what I've done:
Locate the language code in the html and add to tweet object in tweet.py
t.tweet = getText(tw)

 # add language field
 t.lang = tw.find('p', 'tweet-text')['lang']

 t.hashtags = [hashtag.text for hashtag in tw.find_all("a","twitter-hashtag")]

Is there somewhere else in the Twint code that I need to make a change so that the output includes this attribute?  It looks like something like this needs to be added to the format.py code, but I've done this too and still it doesn't show up in the saved text.
        output = output.replace("{lang}", t.lang)
Anybody have any advice or ideas of what I'm missing?

I was just about to post this as a PR. I've been using this for a week or so now on my fork and it seems to be working pretty well, if someone wants to clean it up and submit a proper PR feel free.
         t.lang = tw.findAll("div", "js-tweet-text-container")[0].findAll("p")[0]['lang']

I was just about to post this as a PR. I've been using this for a week or so now on my fork and it seems to be working pretty well, if someone wants to clean it up and submit a proper PR feel free.
 t.lang = tw.findAll("div", "js-tweet-text-container")[0].findAll("p")[0]['lang']

Thanks.   I added this line, but the language field is now showing up in the tweet object in RAM, but somehow it's not being added to the object to be store on disk via Store.json=True.  @pielco11 - is there an additional step I'm missing to add a tweet object attribute to the json output?

I figured out the place to add the language attribute to the saved JSON object.   In write_meta.py, add the line "language" : t.lang, to the TweetData() function.

If it's okay with @pielco11 , I can figure out how to do my first PR :)

Any update here? Would love this!

I have a pull request submitted - #749.

The pull request has now been merged.  This functionality should be available.


Parameters annotated with Spring's @RequestBody and @PathVariable are remote input sources.

@aschackmull I have seen parameters with those annotations in several commercial code bases.
A parameter annotated with @RequestBody will often be a class object with multiple user-controlled member variables. From what I have seen it might make sense to add additional logic to track those as well, which, however, would involve two dataflow steps. I will have a look whether I can add those in a separate PR.

LGTM. Could you add a change note at the end of the change note file along the lines of "Spring framework support is enhanced by taking into account additional annotations that indicate remote user input."

Perhaps also add: "Spring framework support is enhanced by taking into account additional annotations that indicate remote user input. This affects all security queries, which may yield additional results."

Will do.

@yh-semmle Done.


Cargo dep using git = ... without branch = ... fails

After using tokio-uring = { version = "0.3.0", git = "https://github.com/tokio-rs/tokio-uring" } I was getting:
> nix build .#loglogd
warning: Git tree '/home/dpc/lab/loglog' is dirty
error: unknown hash algorithm 'https'
Try 'nix --help' for more information.

I had to:
--- a/server/Cargo.toml
+++ b/server/Cargo.toml
@@ -25,7 +25,7 @@ tokio = { version = "1.19.2", features = ["macros", "rt", "rt-multi-thread", "si
 thiserror = "1.0.31"
 num_enum = "0.5.7"
 nix = { version = "0.24.2", features = [ "zerocopy" ]}
-tokio-uring = { version = "0.3.0", git = "https://github.com/tokio-rs/tokio-uring" }
+tokio-uring = { version = "0.3.0", git = "https://github.com/tokio-rs/tokio-uring", branch = "master" }
 binrw = "0.9.2"
 typed-builder = "0.10.0"
 derive_more = "0.99.17"

to get it to build again.

Thanks for the report @dpc! Do you have a flake which can reproduce the error you hit?
The Cargo.lock file will include a particular commit of the git checkout (even without specifying a branch). The test suite already has a test case for git dependency without a branch/tag/rev. I also tried changing that test to include tokio-uring = { version = "0.3.0", git = "https://github.com/tokio-rs/tokio-uring" } but everything built just fine so I can't reproduce the issue

https://github.com/rustshop/loglog/commit/c08ff81e8a24bd83195df421e13be69099f048b3
this was the commit that was failing both locally and CI: https://github.com/rustshop/loglog/runs/7703607950?check_suite_focus=true
The followup commit fixed it: https://github.com/rustshop/loglog/actions/runs/2808339275

Hmm this looks really weird, it's as if cargo failed(?) to write a git revision in the Cargo.lock file.
Changing the branch appears to have fixed things by forcing cargo to append the revision in the lock file. I was also able to fix things by running cargo update -p tokio-uring which also seemed to make cargo add a revision to the lock file :thinking:
We must have a revision present in the lock file because nix wants to check out a specific commit. If the Cargo.lock file is "invalid" in such a manner then it seems like the best thing we can do is throw a descriptive error to make it easier to resolve

Oh, I see. Now that I think about it - I might have accidentally trigger this state manually, by messing with this Cargo.lock in some weird ways.
A better error message would be great, but I guess it might be just invalid.

Good diagnostics never hurt! I've opened #58 to improve the situation here :smile:


Delete all user data with user delete function

When a user deletes the account, delete all the tables and other data related.

This got done at some point in auth.py.
@classmethod
def remove_by_uid(cls, uid):
	with ndb.Client().context():
		user = cls.query(cls.uid == uid).get()
		if user:
			user.key.delete()
		else:
			return False
		return True


[Feature] : Login & Sign Up form

Describe the feature

In this project Not available on the Login & Sign Up form.

Describe the solution you'd like

So i will implement the Login & Sign Up page ..
It very more important of the user Details and product ordering.
In this Feaute Implementation this issue can be more improve the project.

Describe alternatives you've considered

please assign me ..
i will ready to work on it..

Add ScreenShots

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

consider me for this task.


feature idea: download text widget

I quite often get string output with several kb of genetic data. It would be nice to have a widget just to be able to download it as a text file in the browser instead of seing truncated output.

good I idea I guess.
hmm we already have a DownloadCSV(df: DataFrame) (distributed/spark-based).
so for text, it quite depends on the expected size of outputs. what shall we do if text is larger than meaningful size say 1-10MB? I guess, show truncated output, and just ignore the "download".

what shall we do if text is larger than meaningful size say 1-10MB?

What about just generating file and giving a link to download it?


What is the best way for handle store / reducer?

Hi @robwormald and contributors :)
What is your recommendation for handle the state/store in the reducer (for create a new state)?
Is it the immutablejs the right way? Or just using object assign function? Or another llb?

Don't complicate it.
Your slice of state is an array?
Use array methods which return a new array. Concat, map, etc.
What if the slice is an object?
Object.assign!
You certainly can use immutable.js if you want, and if it's a large team it may be beneficial. But defer complexity until its needed! :)


⚠ GreatPosterWall has degraded performance

In 1051be6, GreatPosterWall ($GPW) experienced degraded performance:

HTTP code: 200
Response time: 12383 ms

Resolved: GreatPosterWall performance has improved in 71d99fb.


Added flag to send shell completions to stdout.

This will allow users that have bespoke systems to pipe and modify the completions as they see fit, increasing the number of systems shell completions can be installed too.

Thanks.
It's rather hard for me to see why this is useful, but I'll just assume it's a nix thing?


testing with DOTA dataset

Hi, thanks for your great work!
I split the testing with the default configuration split_configs/dota1_0/ss_test.json
Then I run the test as below:
EVAL_METRICS=mAP && \ CONFIG_FILE=configs/obb/oriented_rcnn/faster_rcnn_orpn_r50_fpn_1x_dota10.py && \ CHECKPOINT_FILE=ckpt/faster_rcnn_orpn_r50_fpn_1x_dota10_epoch12.pth && \ python tools/test.py ${CONFIG_FILE} ${CHECKPOINT_FILE} --eval ${EVAL_METRICS}
Everything runs fine. However I see that all AP scores are 0 because it does not pick up ground truth.
`root@673e18a920bd:/work/OBBDetection# EVAL_METRICS=mAP && CONFIG_FILE=configs/obb/oriented_rcnn/faster_rcnn_orpn_r50_fpn_1x_dota10.py && CHECKPOINT_FILE=ckpt/faster_rcnn_orpn_r50_fpn_1x_dota10_epoch12.pth && python tools/test.py ${CONFIG_FILE} ${CHECKPOINT_FILE} --eval ${EVAL_METRICS}
load checkpoint from local path: ckpt/faster_rcnn_orpn_r50_fpn_1x_dota10_epoch12.pth
[>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>] 10833/10833, 4.2 task/s, elapsed: 2557s, ETA:     0s
Merging patch bboxes into full image!!!
Multiple processing
[>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>] 937/937, 39.0 task/s, elapsed: 24s, ETA:     0s
Used time: 26.0 s
Start calculate mAP!!!
Result is Only for reference, final result is subject to DOTA_devkit
+--------------------+-----+-------+--------+--------+
| class              | gts | dets  | recall | ap     |
+--------------------+-----+-------+--------+--------+
| large-vehicle      | 0   | 23163 | 0.0000 | 0.0000 |
| swimming-pool      | 0   | 2190  | 0.0000 | 0.0000 |
| helicopter         | 0   | 439   | 0.0000 | 0.0000 |
| bridge             | 0   | 5914  | 0.0000 | 0.0000 |
| plane              | 0   | 4905  | 0.0000 | 0.0000 |
| ship               | 0   | 21624 | 0.0000 | 0.0000 |
| soccer-ball-field  | 0   | 1239  | 0.0000 | 0.0000 |
| basketball-court   | 0   | 784   | 0.0000 | 0.0000 |
| ground-track-field | 0   | 901   | 0.0000 | 0.0000 |
| small-vehicle      | 0   | 37442 | 0.0000 | 0.0000 |
| baseball-diamond   | 0   | 1287  | 0.0000 | 0.0000 |
| tennis-court       | 0   | 2005  | 0.0000 | 0.0000 |
| roundabout         | 0   | 1076  | 0.0000 | 0.0000 |
| storage-tank       | 0   | 5646  | 0.0000 | 0.0000 |
| harbor             | 0   | 6926  | 0.0000 | 0.0000 |
+--------------------+-----+-------+--------+--------+
| mAP                |     |       |        | 0.0000 |
+--------------------+-----+-------+--------+--------+
`
Do I have to reformat the groundtruth of dota dataset before splitting?
The configuration file points to the test partition that has been splitted, so everything is running by default. Am I missing something?
Thanks again

ss_test.json doesn't specify ann_dir, so the dataset doesn't have ground-truth information. You can use ss_val.json to split your test set.

Thanks!

@geobao
Can you solve this problem?
If we use ss_val.json , we need labelTxt folder for test images.

DOTA does not provide label for test dataset
Only the label of train and val dataset can we access


Bump openshift-client to 6.9.0

@Sgitario: Could you plz merge?

Can you fix the conflict please ? @graben

@cmoulliard : Conflict is fixed.


Any chance your package can be upgraded to support symfony/yaml 4?

Hi, I am open for new implementations since if this do not cause a huge break change on the system. What is your idea? Let me know if that is doable.

ping


.sli Integration with PySLM

Hi Tom,
In the future, am looking into integrate the .sl reader with the PySLM project as a reader/writer translator, which can be used for creating build files.
I am still unsure about the legal requirements (in relation to it being opensource), but I intend atleast to make a simple python equivalent based on your work.
If there is anything you can offer that may assist, I would be grateful.
Many Thanks,
Luke

it's MIT Licence so you can do what you want without any warranty..i. f you want you can add me to your "credits" but even this is not required