[BUG] SubscriptionClient.RegisterSessionHandler throws plenty of timeout exceptions when message no message arrives for certain time

I have these settings which i am putting to constructor and then using for initializing SubscriptionClient
        public ServiceBusDefaultConfiguration(Func<ExceptionReceivedEventArgs, Task> exceptionReceivedHandler)         {             this.RetryPolicy = new RetryExponential(TimeSpan.FromSeconds(5), TimeSpan.FromSeconds(30), 10);             this.ReceiveMode = ReceiveMode.PeekLock;             this.PrefetchCount = 0;             this.MessageHandlerOptions = new MessageHandlerOptions(exceptionReceivedHandler)             {                 MaxConcurrentCalls = 1,                 AutoComplete = false,                 MaxAutoRenewDuration = TimeSpan.FromMinutes(5)             };         }
`
subClient = new SubscriptionClient(serviceBusConnection, entityPath, subName, config.ReceiveMode, config.RetryPolicy);
subClient.RegisterSessionHandler(ProcessMessagesInSessionAsync, config.SessionHandlerOptions);
`
If no message will arrive for a certain time, I will get plenty of exceptions that will not bubble up to application. Is this expected ? How to handle such a scenario?
Maybe I dont know how to catch them. ExceptionHandler stored in SessionHandlerOptions is not triggered and other try catch statements anywhere are not triggered either.
Exceptions thrown:
Exception thrown: 'Microsoft.Azure.Amqp.AmqpException' in System.Private.CoreLib.dll
Exception thrown: 'Microsoft.Azure.Amqp.AmqpException' in System.Private.CoreLib.dll
Exception thrown: 'Microsoft.Azure.ServiceBus.ServiceBusTimeoutException' in Microsoft.Azure.ServiceBus.dll
Exception thrown: 'Microsoft.Azure.ServiceBus.ServiceBusTimeoutException' in System.Private.CoreLib.dll
Exception thrown: 'Microsoft.Azure.ServiceBus.ServiceBusTimeoutException' in System.Private.CoreLib.dll
Exception thrown: 'Microsoft.Azure.ServiceBus.ServiceBusTimeoutException' in System.Private.CoreLib.dll
Exception thrown: 'Microsoft.Azure.ServiceBus.ServiceBusTimeoutException' in System.Private.CoreLib.dll
Exception thrown: 'Microsoft.Azure.ServiceBus.ServiceBusTimeoutException' in System.Private.CoreLib.dll
Exception thrown: 'Microsoft.Azure.ServiceBus.ServiceBusTimeoutException' in System.Private.CoreLib.dll
Exception thrown: 'Microsoft.Azure.ServiceBus.ServiceBusTimeoutException' in System.Private.CoreLib.dll
Exception thrown: 'Microsoft.Azure.ServiceBus.ServiceBusTimeoutException' in System.Private.CoreLib.dll
Exception thrown: 'Microsoft.Azure.ServiceBus.ServiceBusTimeoutException' in Microsoft.Azure.ServiceBus.dll
Exception thrown: 'System.Threading.Tasks.TaskCanceledException' in System.Private.CoreLib.dll
Exception thrown: 'Microsoft.Azure.ServiceBus.ServiceBusTimeoutException' in System.Private.CoreLib.dll

@Pucmaster , we will investigate it and let you know.
This behavior is by design as of now, and I can understand that it might be frustrating. There might not be a straightforward solution as it would become a breaking change in terms of behavior.
Quick fix from your end would be to ignore timeoutExceptions coming from RegisterSessionHandler. We will try to wrap our heads and see what could be done here.

Thanks for reporting @Pucmaster
Like @nemakam mentioned there is no solution without a breaking change in behavior.
Furthermore, please note that a newer package Azure.Messaging.ServiceBus is available as of November 2020. While the older package Microsoft.Azure.ServiceBus will continue to receive critical bug fixes, we strongly encourage you to upgrade. Read the migration guide at https://aka.ms/azsdk/net/migrate/sb for more details.
If you continue to see a similar problem after moving to the new package, please do open a new issue and we would be happy to assist

hi, i am getting this error on the new Azure.Messaging.ServiceBus:
System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() in //src/libraries/System.Private.CoreLib/src/System/Runtime/ExceptionServices/ExceptionDispatchInfo.cs:line 56\r\n
at Azure.Messaging.ServiceBus.Amqp.AmqpConnectionScope.d__74.MoveNext() in //sdk/servicebus/Azure.Messaging.ServiceBus/src/Amqp/AmqpConnectionScope.cs:line 714\r\n
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() in //src/libraries/System.Private.CoreLib/src/System/Runtime/ExceptionServices/ExceptionDispatchInfo.cs:line 56\r\n
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task) in //src/libraries/System.Private.CoreLib/src/System/Runtime/CompilerServices/TaskAwaiter.cs:line 173\r\n
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) in //src/libraries/System.Private.CoreLib/src/System/Runtime/CompilerServices/TaskAwaiter.cs:line 150\r\n
at System.Runtime.CompilerServices.ConfiguredTaskAwaitable1.ConfiguredTaskAwaiter.GetResult() in /_/src/libraries/System.Private.CoreLib/src/System/Runtime/CompilerServices/TaskAwaiter.cs:line 551\r\n    at Azure.Messaging.ServiceBus.Amqp.AmqpConnectionScope.<OpenReceiverLinkAsync>d__69.MoveNext() in /_/sdk/servicebus/Azure.Messaging.ServiceBus/src/Amqp/AmqpConnectionScope.cs:line 349\r\n    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() in /_/src/libraries/System.Private.CoreLib/src/System/Runtime/ExceptionServices/ExceptionDispatchInfo.cs:line 56\r\n    at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task) in /_/src/libraries/System.Private.CoreLib/src/System/Runtime/CompilerServices/TaskAwaiter.cs:line 173\r\n    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) in /_/src/libraries/System.Private.CoreLib/src/System/Runtime/CompilerServices/TaskAwaiter.cs:line 150\r\n    at System.Runtime.CompilerServices.ConfiguredTaskAwaitable1.ConfiguredTaskAwaiter.GetResult() in //src/libraries/System.Private.CoreLib/src/System/Runtime/CompilerServices/TaskAwaiter.cs:line 551\r\n
at Azure.Messaging.ServiceBus.Amqp.AmqpReceiver.d__35.MoveNext() in //sdk/servicebus/Azure.Messaging.ServiceBus/src/Amqp/AmqpReceiver.cs:line 200\r\n
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() in //src/libraries/System.Private.CoreLib/src/System/Runtime/ExceptionServices/ExceptionDispatchInfo.cs:line 56\r\n
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task) in //src/libraries/System.Private.CoreLib/src/System/Runtime/CompilerServices/TaskAwaiter.cs:line 173\r\n
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) in //src/libraries/System.Private.CoreLib/src/System/Runtime/CompilerServices/TaskAwaiter.cs:line 150\r\n
at System.Runtime.CompilerServices.ConfiguredTaskAwaitable1.ConfiguredTaskAwaiter.GetResult() in /_/src/libraries/System.Private.CoreLib/src/System/Runtime/CompilerServices/TaskAwaiter.cs:line 551\r\n    at Microsoft.Azure.Amqp.FaultTolerantAmqpObject1.d__6.MoveNext()"	string

@ramya-rao-a My application stops, and this error usually happens when I put a breakpoint somewhere in my app, then continue. It's still unclear to me on what conditions this error pops up, but it's there and happened multiple times already.

@xbaha, Please open a new GitHub issue for the problems you are seeing along with a code snippet showing how you are using the Service Bus package and the version of the package being used


Buildify Envoy upb

This is the last piece of upb build-time code generation effort. This PR

Replaced all envoy proto targets with upb ones.
Updated envoy-api to the latest (particularly to have https://github.com/envoyproxy/envoy/pull/18817)

grpc_build_artifacts_multiplatform: running


When adding a refresh indicator with scroll controller attached to the listview, scroll controller gets disposed and I can't find a way to fix it.

The error is :
════════ Exception caught by widgets library ═══════════════════════════════════
The following assertion was thrown building NotificationListener:
A ScrollController was used after being disposed.
Once you have called dispose() on a ScrollController, it can no longer be used.
The relevant error-causing widget was:
RefreshIndicator RefreshIndicator:file:///Users/ashwinshrestha/development/medhavhi_app/lib/src/class/presentation/paginated_list/view/paginated_list_view.dart:87:53
The code is:
RefreshIndicator.adaptive(
onRefresh: () async =>
_paginationBloc.add(const FetchItems(refresh: true)),
child: ElasticListView(
// controller: _scrollController,
itemCount: state.hasReachedMax
? state.data.length
: state.data.length + 1,
itemBuilder: (context, index) {
return index >= state.data.length
? widget.paginationLoadingWidget ??
SizedBox(
height: 80.v,
width: context.deviceWidth,
child: const Center(
child: CupertinoActivityIndicator(),
),
)
: widget.itemBuilder(context, index, state.data[index]);
},
),
)

Hey!
Thanks for opening this issue. ElasticListView is now a package a package. I tried to reproduce your error but was unable to replicate the issue. Could you please verify with the new package and let me know if the issue still exists? If it does, sharing a code snippet would be very helpful for further debugging.


New "no georeferenced data" dialog

@saleiva @josecruz is there a sketch file for this one? Is it going to work in the same way as the current modal or do you have some other things in mind?

Se could try to open the geocoding modal directly but with a small variation
On Jun 23, 2015 10:18 AM, "Nicklas Gummesson"<EMAIL_ADDRESS>wrote:

@saleiva https://github.com/saleiva @josecruz
https://github.com/josecruz is there a sketch file for this one? Is it
going to work in the same way as the current modal or do you have some
other things in mind?
—
Reply to this email directly or view it on GitHub
https://github.com/CartoDB/cartodb/issues/4131#issuecomment-114402588.

Sure, you have something like this in mind?  where "continue" would take the user to the standard normal start?
(sorry for the 30-sec design that do not fit with current styles ;))

what do you think?

About the alignment: Sketch column layout bug :(
Updated version:

Like it tho. What about...

Changing the style of the button to the grey one.
Making the text more uniform to remove some noise.

Kind of:

Updated with secondary buttons color:

Final version by @saleiva

Two questions:

For how long should this message be displayed? Until modal is closed? Or some interaction?
Should the modal work like the current one, i.e. be opened in this state when opening map?

Whenever the table has non geo data.
Yep!
On Jun 23, 2015 2:21 PM, "Nicklas Gummesson"<EMAIL_ADDRESS>wrote:

Two questions:

For how long should this message be displayed? Until modal is closed?
Or some interaction?
Should the modal work like the current one, i.e. be opened in this
state when opening map?

—
Reply to this email directly or view it on GitHub
https://github.com/CartoDB/cartodb/issues/4131#issuecomment-114472290.


Agent 7.16.0 cannot parse non-semantic nginx version

After upgrading DataDog agent to 7.16.0 nginx integration stopped working.
Agent Log:
Dec 18 15:42:50 nginxproxy agent[29323]: 2019-12-18 15:42:50 EST | CORE | ERROR | (pkg/collector/python/datadog_agent.go:116 in LogMessage) | nginx:17d65b5a97c80644 | (core.py:45) | Unable to transform `version` metadata value `nginx`: Version does not adhere to semantic versioning
nginx -v:
nginx version: nginx/1.13.9 (Ubuntu)
Nothing changed in nginx.d/conf.yaml except status url:
- nginx_status_url: http://localhost:8080/stub_status/
datadog-agent version:
Agent 7.16.0 - Commit: 3e13b77 - Serialization version: 4.15.0 - Go version: go1.12.9
Worked fine with version Agent 6.15.1-1

My bad, metrics are actually sent. There was a delay in them showing in a dashboard which made me think version parsing was a problem.

Thanks for the feedback. I was wondering if it was possible for you to set server_tokens on on the nginx_status location. This should allow the check to retrieve the version, and hopefully not leak it on others.

@therve setting server_tokens on under the nginx_status location indeed solves it. Maybe y'all could make sure it's part of the docs tho? https://docs.datadoghq.com/integrations/nginx/#prepare-nginx could list it, it's pretty harmless if it's within the block which only allows traffic from <IP_ADDRESS>. Or alternatively you could suggest that in the warning being logged by the agent, so one doesn't have to google and find this comment by chance :)

@Seldaek Great idea! Would you mind making a PR? https://github.com/DataDog/integrations-core/blob/master/nginx/README.md


After removing intermediate and saved folders it crashes on Startup of the Project

I configured my project correctly with identity and UsergameplayData modules and it worked fine until I removed the Intermediate and Saved folder to make some space and because I needed a clean state to dev upon it and here is the problem I saw:
On Launch it triggers a breakpoint in AwsGameKitCredentialsLayoutDetails.cpp line 974 because the LastUsedEnv variable is empty.:
FString const lastUsedEnv = editorModule->GetFeatureResourceManager()->GetLastUsedEnvironment();

const auto lastUsedEnvironmentList = environmentOptions.FindByPredicate([this, lastUsedEnv](const FComboBoxItem comboBox) { return (*comboBox.Get() == environmentMapping[lastUsedEnv]); });

I hope that can be fixed soon because it's actually blocking the whole plugin on the editor side.

Hey DevGarou,
I am with the GameKit team and I tried to reproduce your issues with the newest release but unfortunately could not get to the same state that you are in.
It would also help if you can provide the following information

Unreal Editor Version [e.g. 4.27.2]
IDE and Version [e.g. Visual Studio 2019 16.11.7]
OS and Version that you are developing on: [e.g. Windows 10]

Actually I did more than just remove Intermediate and Saved Folder, I
runned this script to clean my project (clean.bat in copy)
I think it removed the Libraries folder too but even when I add it back it
still crashes there:
I think it's strange that the settingsInstanceHandle is null at this point,
it seems like some dependencies are not loaded correctly
https://gyazo.com/d3479680fd50d2447ae68f5b508144bb
Clean.bat code: (to paste in a new file
@ECHO off
REM This command cleans the given project's folder and calls clean.bat for
each plugin, if it exists. If it does not exist, it will default-clean that
folder.
REM Usage: Clean
ECHO Default cleaning..

REM For each existing plugin, we call Clean.bat if it exists, otherwise we
simply remove Binaries, Intermediate and Saved
IF EXIST Plugins (
CD Plugins
FOR /D %%f IN (.*) DO (
ECHO Cleaning %%f
PUSHD %%f
IF EXIST "Clean.bat" (
call Clean.bat
) ELSE (
rd /s /q Binaries
rd /s /q Intermediate
rd /s /q Saved
)
POPD
)
CD ..
)
ECHO Cleaning empty folders in Source..
ROBOCOPY Source Source /S /MOVE
ECHO ----
ECHO Done
ECHO ----
Thank you
On Mon, May 23, 2022 at 10:56 PM Jake Schichko @.***>
wrote:

Reopened #7 https://github.com/aws/aws-gamekit-unreal/issues/7.
—
Reply to this email directly, view it on GitHub
https://github.com/aws/aws-gamekit-unreal/issues/7#event-6664111520, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ALIIAHHYBR7DFCX4EIU3H2LVLPWITANCNFSM5WWMB2OA
.
You are receiving this because you authored the thread.Message ID:
@.***>

I am glad to hear that fixed your issue. I believe the root cause was the following section in the Clean.bat script you sent above:
CD Plugins
FOR /D %%f IN (.\*) DO (
ECHO Cleaning %%f
PUSHD %%f
IF EXIST "Clean.bat" (
call Clean.bat
) ELSE (
rd /s /q Binaries
rd /s /q Intermediate
rd /s /q Saved
)

Since we do not have a Clean.bat script in our plugin directory I believe that the needed binaries were removed which caused the dlls to not be loaded like you mentioned. On our end we can look into creating a Clean.bat script within our plugin directory that can prevent this issue from happening in the future.
If you ever run into an issue like this again you may want to consider re-building and copying over the dlls from out C++ plugin. This is also useful if you ever want to change the functionality of our libraries.
https://github.com/aws/aws-gamekit
Please feel free to re-open this issue if you run into any more issues with this.

Hi again, I did run into this issue again and here what fixed the dll loading issue for me:
I added that line in ..\AwsGameKitCore\Private\Core\AwsGameKitLibraryWrapper.cpp line 32 to actually pass the full path to the dll instead of just the filename:
    libraryPath = FPaths::Combine(FPaths::ProjectDir(), TEXT("Binaries"), TEXT("Win64"), libraryPath);

Although if you want to fix another problem it would be nice to have no
crash a the end of an editor session.
The editor is crashing when we close it because a lambda is called but not
existing anymore somewhere in your code.
Here is a photo:
[image: image.png]
Thanks a lot!
Otherwise really good job it's really handy!
On Tue, May 24, 2022 at 10:38 AM Dev Loper @.***> wrote:

This was the error and I actually had to remove binaries for this plugin,
leave those dependencies in Libraries and rebuild and everything went back
to normal.
On Tue, May 24, 2022 at 10:30 AM Dev Loper @.***> wrote:

Actually the dll are definitely not loaded but they are in the Libraries
folder and in the plugin's Binaries folder too so I don't know what
happened...

Symbols loaded.
[2022.05.24-08.29.30:018][  0]LogAwsGameKit: Display:
FAwsGameKitEditorModule::StartupModule()

On Tue, May 24, 2022 at 10:17 AM Dev Loper @.***> wrote:

Actually I did more than just remove Intermediate and Saved Folder, I
runned this script to clean my project (clean.bat in copy)
I think it removed the Libraries folder too but even when I add it back
it still crashes there:
I think it's strange that the settingsInstanceHandle is null at this
point, it seems like some dependencies are not loaded correctly
https://gyazo.com/d3479680fd50d2447ae68f5b508144bb
Clean.bat code: (to paste in a new file
@ECHO off
REM This command cleans the given project's folder and calls clean.bat
for each plugin, if it exists. If it does not exist, it will default-clean
that folder.
REM Usage: Clean
ECHO Default cleaning..

REM For each existing plugin, we call Clean.bat if it exists, otherwise
we simply remove Binaries, Intermediate and Saved
IF EXIST Plugins (
CD Plugins
FOR /D %%f IN (.*) DO (
ECHO Cleaning %%f
PUSHD %%f
IF EXIST "Clean.bat" (
call Clean.bat
) ELSE (
rd /s /q Binaries
rd /s /q Intermediate
rd /s /q Saved
)
POPD
)
CD ..
)
ECHO Cleaning empty folders in Source..
ROBOCOPY Source Source /S /MOVE
ECHO ----
ECHO Done
ECHO ----
Thank you
On Mon, May 23, 2022 at 10:56 PM Jake Schichko @.***>
wrote:

Reopened #7 https://github.com/aws/aws-gamekit-unreal/issues/7.
—
Reply to this email directly, view it on GitHub
https://github.com/aws/aws-gamekit-unreal/issues/7#event-6664111520,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALIIAHHYBR7DFCX4EIU3H2LVLPWITANCNFSM5WWMB2OA
.
You are receiving this because you authored the thread.Message ID:
@.***>


remove Boscia import and free model before check

mmmh @dhendryc there seems to be a failing assert that is unrelated

It seems that the issue was not that the model has to be reset but rather that a method signature was wrong/missing something.


K12 user migration error

Brief bug description
Migrating Kentico 12 MVC to Xperience getting the error below.
Microsoft.EntityFrameworkCore.Database.Command[20102] Failed executing DbCommand (265ms) [Parameters=[@__PrivilegeLevelsMigratedAsAdminUser_0='?' (Size = 4000)], CommandType='Text', CommandTimeout='30'] SELECT [c].[UserID], [c].[Email], [c].[FirstName], [c].[FullName], [c].[LastLogon], [c].[LastName], [c].[MiddleName], [c].[PreferredCultureCode], [c].[PreferredUICultureCode], [c].[UserCreated], [c].[UserEnabled], [c].[UserGUID], [c].[UserHasAllowedCultures], [c].[UserIsDomain], [c].[UserIsExternal], [c].[UserIsHidden], [c].[UserLastLogonInfo], [c].[UserLastModified], [c].[UserMFRequired], [c].[UserMFSecret], [c].[UserMFTimestep], [c].[UserName], [c].[UserPassword], [c].[UserPasswordFormat], [c].[UserPrivilegeLevel], [c].[UserSecurityStamp], [c].[UserStartingAliasPath], [c].[UserVisibility] FROM [CMS_User] AS [c] WHERE [c].[UserPrivilegeLevel] IN (     SELECT [p].[value]     FROM OPENJSON(@__PrivilegeLevelsMigratedAsAdminUser_0) WITH ([value] int '$') AS [p] )
04:12:22.154
Repro steps
running Migration.Toolkit.CLI.exe migrate --sites --custom-modules --users

Hi! Thanks for sharing your problem and a solution! We'll take a look at it soon and consider adding it to the original integration.

@tkrch Getting the same error on K11 site. Hotfix v11.0.43. Here is the output:

@tkrch Following up on my previous comment, the issue is also present on the KX13 site I attempted to migrate. Logs are available here:

...

@tkrch Thanks for looking into this.

@tkrch
I attempted to migrate the K13 site. While the initial issue has been resolved, I encountered a new problem with Media Libraries and Attachments, which will require further investigation on my end.
As for the K11 site, I'm experiencing a similar issue, but with a different query. Here are logs:

...

@tkrch The issue is gone. Thank you. I came across another issue related to files missing in Media library but I guess that is something wrong on my end 😅.

@tkrch I'm missing these files on my end - I need to get the latest project files and database from the server. However, since I'm currently testing the migration tool to see if it's suitable for future projects, I am giving this a low priority for now.

Hi @tkrch,
I was on leave last week. Glad this has been resolved. BTW we are also experiencing issues with media libraries. Other dev may log new issue as I moved to other project. We are using Azure blob storage.
You can close this one now. Thanks


rfc 1291: Add errno() and set_errno() to libc scope

Without these functions, Rust programs cannot inspect errors returned by
functions defined in libc. From POSIX [0]:

An application that needs to examine the value of errno to determine
the error should set it to 0 before a function call, then inspect it
before a subsequent function call.

From the C standard [1]:

Thus, a program that uses errno for error checking should set it to
zero before a library function call, then inspect it before a
subsequent library function call.

While most libc functions return a sentinel value to indicate an
error, not all do. For example, POSIC strtol has an error condition
that can only be discovered by setting and reading errno [2]:

If the value of base is not supported, 0 shall be returned and errno
shall be set to [EINVAL].

Refs https://github.com/rust-lang/libc/issues/47
[0] http://pubs.opengroup.org/onlinepubs/9699919799/functions/errno.html#tag_16_110_07
[1] §7.5, footnote 202 of ISO/IEC 9899:2011, WG14 draft version N1570
(http://www.open-std.org/jtc1/sc22/wg14/www/docs/n1570.pdf)
[2] http://pubs.opengroup.org/onlinepubs/9699919799/functions/strtol.html#tag_16_590_04

An alternative would be to provide something like errno_ptr() -> *mut ::c_int.

It makes sense errno gets its own ad-hoc solution since it's a global variable ish thing in C, often exposed via a macro.
However, what can we specify for platforms where their libc don't offer any way (like __errno_location) to implement this?
You can make a shim in C to export two functions for this, but I don't think libc should be required to do it.
For that reason I think libc should define errno() / set_errno() only when it can implement them without the help of a C shim.

@bluss

platforms where their libc don't offer any way (like __errno_location) to implement this?

It's fairly hard for platforms to have an errno available to C code but not available via a C API. IIRC, one would have to integrate errno support into the compiler for that to be the case. Otherwise there has to be some way to get at it (even if hidden behind some macros). And if that platform wants to avoid having users recompile all the time, that mechanism will be part of the platform's binary interface spec (like __errno_location).
That said, if we wanted to work with any libc without needing to have custom code for each, shims would be a solution (but one that might not be a great choice, as you've noted).
In summary: I'm not worried about this case at all because it seems very unlikely to be an issue. Do you have an example platform you're thinking of?

Do we know of any platforms where errno is not exposed via such functions, or as an extern int somewhere?

@kamalmarhubi  if it's just a plain extern int, rust shouldn't have any issue interfacing with it without shims (we do have static mut, after all).

@jmesmon yeah though for this RFC amendment, we'd still want a standard interface to it.

@jmesmon Good questions. I tried to have google help me with this, but I can't find a suggestion for a problematic platform. Some older versions of libcs (cygwin) have used an implementation specific struct and had the errno as a field of it (this would possibly be over the borderline of hairiness for rust's libc to handle), but these are probably weeded out and brought into order by now. Modern libcs seem to adhere to the *__errno_location() approach.
My second strategy of looking at how other languages and their environments integrate with libc was not very fruitful, since many of them compile in C and can easily use the shim approach directly.
I'm not exactly worried about it, just if we spec-define this, why not say that errno/set_errno will be provided if it's possible for the platform.

The one place I'm not sure about is embedded platforms' libcs. Has anyone reading here got any experience with one?

@kamalmarhubi regarding the static mut bit, I was just saying it would be trivial to implement the proposed fn errno(), fn set_errno() interface in pure rust even if the libc in question uses a single global variable for errno.

I'm pretty hesitant to add anon-shim-bindings to libc (already kinda uncomfortable about macros-as-functions). Some platforms, like DragonFly, apparently don't have an __errno_location() function but rather require an extern int essentially. Unfortunately #[thread_local] is unstable and would prevent libc from building on stable.
It seems to me that the "most robust" way of doing this is compiling a C shim which return &errno, but one of the big points of libc is that there isn't a C shim that's needed to be compiled. For now I'd prefer if this was a separate crate on crates.io, as accessing errno is stable via io::Error::last_os_error and setting errno from Rust seems like a relatively niche use case.

setting errno from Rust seems like a relatively niche use case.

Some ffi may require setting errno to properly detect errors that are only indicated via errno. Some of the standard strtoul functions are good examples of this. They certainly aren't the majority of functions, but I'm not sure they are quite 'niche'.

Unfortunately #[thread_local] is unstable and would prevent libc from building on stable.

So the obvious solution is to only have errno() and set_errno() available for dragonfly when building for nightly, or to just not provide errno() and set_errno() for dragonfly at all (but still let everyone else work), or have dragonfly provide only errno() as a wrapper around io::Error::last_os_error() and not provide set_errno() (except for on nightly).
I presume the reason for discarding all of these is a desire to expose the same API for all supported systems? If so: don't we already have differences in libc support between different systems (ie: some libcs providing additional functions)? Or has that been avoided so far?

@alexcrichton ah, we had been using __dfly_error() in nix, but apparently that is gone as you point out, with fix for libstd in https://github.com/rust-lang/rust/commit/60c988ec176b9653bc1c3a6d6a738646d15a5ad6

setting errno from Rust seems like a relatively niche use case.

For Rust using libstd, sure, but not for Rust using libc. As mentioned above, clearing errno is required in some cases to properly detect errors.

I presume the reason for discarding all of these is a desire to expose the same API for all supported systems?If so: don't we already have differences in libc support between different systems (ie: some libcs providing additional functions)? Or has that been avoided so far?

Differing function support across platforms already exists, but I think this issue is a bit different because we're adding a function that has no equivalent in the underlying libc.

or have dragonfly provide only errno() as a wrapper around io::Error::last_os_error() and not provide set_errno() (except for on nightly).

We can't rely on io::Error::last_os_error() because libc is used by libstd, so we'd end up with cyclic dependencies between the crates.

I presume the reason for discarding all of these is a desire to expose the same API for all supported systems?

If this was simply about binding various APIs here and there then that would be fine, for example I'd be ok adding functions like __errno_location to libc for relevant platforms. The problem here is that the text in this RFC indicates that libc will provide the errno and set_errno functions in the sense that they're cross platform.

we had been using __dfly_error() in nix, but apparently that is gone as you point out

This was actually never a function defined, it was defined by us and later removed

We can't rely on io::Error::last_os_error() because libc is used by libstd, so we'd end up with cyclic dependencies between the crates.

Right yes not literally as an implementation detail, but from a crate's perspective of just learning errno it suffices.

@alexcrichton can you comment on disagreement on ‘setting errno from Rust seeming like a relatively niche use case’?
Mine: https://github.com/rust-lang/rfcs/pull/1571#issuecomment-208580523
@jmesmon's: https://github.com/rust-lang/rfcs/pull/1571#issuecomment-208481760

By niche I of course don't mean it's useless, I mean that 99% of the time it's never needed (which I basically believe to still be true). The question at hand, though, is essentially whether we should add these to the libc crate or let them grow in another crate.
With today's definition of libc I think we're fine to add functions like __errno_location for the relevant platforms, so we can do that in either case. By adding these functions to libc we're committing to having a non-libc API in the libc crate as we'll be inventing our own function for these cases. I personally worry about aspects like:

How will these functions be discovered? The docs for libc aren't curated at all as it's assumed you can look at your local man pages for documentation.
If we add this "wrapper function" to libc, why wouldn't we define more? Is this the end of Rust-defined APIs to liblibc? Will there be more?
What if the APIs we choose end up not being suitable for some theoretical libc? That means we'd either need to invent more APIs or deprecate everything in favor of a new set of functions.

Yes we can have platform-specific API differences here, and yes we could even not have the API on some platforms. That's missing the point of this issue though as the whole purpose of this is to actually exist and work on all platforms. That sort of portability in my mind should be left to external crates, not libc itself. For example we already have an errno crate on crates.io.

Thanks for the detailed reply! I am convinced now that this does not fit in the libc crate. The errno crate looks like a good place to focus this effort. And we can add the necessary C shims there for platforms that don't provide an __errno_location() equivalent.


Error As(framesv2) The card frame does not exist in the DOM.

hey.
we're facing such an issue in our system with Frames implemented:
<Frames
        config={createCheckoutComFrameConfig({
          publicKey,
          localization: {
            cardNumberPlaceholder: 'E.g. 1234 5678 9123 4567',
            expiryMonthPlaceholder: `${translate('month')} (MM)`,
            expiryYearPlaceholder: `${translate('year')} (YY)`,
            cvvPlaceholder: 'E.g. 123',
          },
        })}
        cardTokenized={onCardTokenizedHandler}
        frameValidationChanged={onFrameValidationChangedHandler}
        ready={onReadyHandler}
        cardSubmitted={onCardSubmittedHandler}
      >

it only happens on mobile devices, it might happen quite randomly and not often.
did somebody face the same issue?

I have the same error

I get this too.
Anyone managed to solve this?

i get this too, what's the workaround to fix this ?
@checkout is anyone maintaining this pkg ?

Same issue here. I'm guessing no one is maintaining this package, so we won't be getting a fix?

Guys, do yoy load the frames script lazily or statically by simply including it into the Head section? We inject the script lazily and have this error, only on iPhones

Guys, do you load the frames script lazily or statically by simply including it into the Head section? We inject the script lazily and have this error, only on iPhones

I've tried both ways. I'm on NextJS, so I've loaded the script before anything else on the page loads, and then I tried again, loading the script lazily. Same error.

Guys, do you load the frames script lazily or statically by simply including it into the Head section? We inject the script lazily and have this error, only on iPhones

using it as an npm package, error appears on different variety of devices:

A few observations that I've encountered while integrating this that might help someone:

You can't reliably mount <FramesReact/> immediately on load
You can't reliably mount <FramesReact/> unless the SDK is loaded
You have to immediately mount <CardNumber/> etc at the same time as you mount <FramesReact />

Something that might help someone:
export function CardFormFramesProvider(props: { children: ReactNode }) {
  // Adds the `<script>` tag to the DOM if not already present
  const scriptState = useCardFormScript();

  /**
   * If we don't wait for the component to be mounted before rendering the iframes, it sometimes fails
   * Possibly related: https://github.com/checkout/frames-react/issues/25
   **/
  const [isMounted, setIsMounted] = useState(false);
  useEffect(() => {
    setIsMounted(true);
  }, []);
  if (!isMounted) {
    return null;
  }
  if (scriptState === 'loading') {
    return null;
  }
  if (scriptState === 'error') {
    return <div>❌ Something went wrong loading our credit card provider</div>;
  }

  return (
    <FramesReact
      config={{
        // [...]
      }}
    >
      {props.children}
    </FramesReact>
  );
}

Closing this issue as this package will soon be deprecated. A new version using Checkout.com Flow is currently in the works.


profile_card

added a snippet of creating is profile cards using css and bootstrap

Looks good! Thank you for your contribution! I look forward to having more ideas and contributions.

Thank you🙂


she said: "what
is this
multiline
crap???"


Game map

Used the low poly environment asset pack to create a open world map
Notes:

weird box collider bug with the big rock not sure why it isn't working
thinking of either sticking to open world and adding different biomes/sections or have multiple levels with different maps

Could you fix the directory structure and remove the dragon and magma object from scene? Also, grass texture could be refreshed as talked about in call. But we can refine in future sprint too.


[jaeger-v2]: Remove SkipBinaryAttrs flag from storage integration

Requirement
As a contributor, I want to remove the SkipBinaryAttrs flag from storage integration test that was temporarily added to bypass the issue sourced from upstream dependency. Marked with this comment https://github.com/jaegertracing/jaeger/pull/5322#discussion_r1556346781.
Problem
The SkipBinaryAttrs flag was added to bypass upstream issue because OTEL pkg/translator/jaeger has a bug that converts Jaeger proto BINARY type tags into OTLP STRING type but remains in STRING type when converted back into Jaeger proto.
Proposal
Remove SkipBinaryAttrs flag from storage integration test once the issue at https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/32208 has been resolved.
Open questions
No response

hey @james-ryans. @yurishkuro I would like to work on it

Hi @prakrit55, actually we have an ongoing PR for this at #5436.


Key missing

Steps to reproduce
set config to:
{
            redisCache {
              defaultDuration: 3600,
              removePathFromCacheKey: true
 };

key is missing if there is no id e.g. /users the key should be users now it is empty.

fixed by c273f759bb43d2c5163988c0703046ce522b0bb7


Download dependencies repo archive instead of git submodule sync

download archive directly instead of git submodule sync to reduce sync time when building fresh.
It also remove complication in build script where it needs to handle stale data.
To check revision cache (potentially having local .lock file in dependency to check if we should download code or not)
curl -L \
  -H "Accept: application/vnd.github+json" \
  -H "X-GitHub-Api-Version: 2022-11-28" \
  https://api.github.com/repos/osmosis-labs/osmosis/commits/v19.2.0

To download tarball
curl -L -o osmosis.tar \
  -H "Accept: application/vnd.github+json" \
  -H "X-GitHub-Api-Version: 2022-11-28" \
  https://api.github.com/repos/osmosis-labs/osmosis/tarball/main

Not doing, since it's actually slow down the process.


BFS Added

Added bfs algorithm for graph traversal.

Added algorithm to count total number of connected components in Graph.


Purge all tokens except settings.access_token

Add support for token purging do passing the option --purge to revoke, it will
purge every token except the current access_token for the cli.

@ekarlso Thanks! Looks good. Would you mind signing our CLA? Ping me when you have signed.

Closing due to inactivity. If you wish to re-open this pull request, please sign the CLA and comment here.


Example of subtasking creation

In this example, I added a simple example of how to handle multiple subtasks

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


add welcome screens and help icon

Help icon will show only once, and will disappear when dismissed.

@islandbitcoin Shouldn't we put welcome screen in the first screen instead of get-started-screen?

I thought about it... and decided no.
I wanted to get the user to the Home Screen as quickly as possible.
Blink used to have the welcome screen in the first screen and then they removed it, based on user feedback.

And also, we should use "react-native-reanimated-carousel" or "react-native-snap-carousel" for better performance and better UI

I cannot get any of them to work on Android with the swipe functionality. Do you know why?

Added a help icon on the getStarted screen, and changed to using react-native-reanimated-carousel.

Should we remove question icon button on the home screen or keep it?

it's a one time press so i want to keep it.


Fix hydra-tui forms to only submit valid values

Also shows focus, invalid values and the maximum amount available.
Fixes issue #224
Before:

After:

For the State updating part that might actually be working. IIRC the EventM or Next brick data types were impossible to unwrap, but we could factor out another, more introspectable DSL than continue :: s -> EventM (Next s). As for the rendering, we needed the full terminal hijack (hacked) test suite, which we have right now.


Website-gamepage+category screen: Duplicate text field needs to be a separate template in keystone, currently pulls same field for two sep. explanation fields.

in the section titled lesson plans on the bottom of each game page, the text field for categories (on each category selection screen) is the same text field. This is an issue since lesson plans and categories are separate things, and the descriptions should be different. Please make a template for lesson plans and have that be assigned to the field on the bottom of the game page. Screenshots attached.

Checked. Ready for integration into prod.


Download test data from an external source during build

Fixes #96.
This is an attempt to reduce the repository size by moving the test data files test/data to an external repository. This can significantly cuts down the size by ~50% (from ~435 MB to ~245 MB).
To make the build process seamless and minimize the effects on the users, the external repository will be downloaded by the build scripts automatically and only when the user desire to build the tests, either by cmake or make. Therefore, this separation should be transparent to regular users.
A similar PR can be considered for the files in benchmarks/data later.
Note: As for now, the test data is being downloaded from my personal repository. They should be moved into a new repository owned by @nlohmann before merging this PR.

Pull request checklist
Read the Contribution Guidelines for detailed information.

[x]  Changes are described in the pull request, or an existing issue is referenced.
[ ]  The test suite compiles and runs without error.
[x]  Code coverage is 100%. Test cases can be added by editing the test suite.
[x]  The source code is amalgamated; that is, after making changes to the sources in the include/nlohmann directory, run make amalgamate to create the single-header file single_include/nlohmann/json.hpp. The whole process is described here.

Please don't

The C++11 support varies between different compilers and versions. Please note the list of supported compilers. Some compilers like GCC 4.7 (and earlier), Clang 3.3 (and earlier), or Microsoft Visual Studio 13.0 and earlier are known not to work due to missing or incomplete C++11 support. Please refrain from proposing changes that work around these compiler's limitations with #ifdefs or other means.
Specifically, I am aware of compilation problems with Microsoft Visual Studio (there even is an issue label for these kind of bugs). I understand that even in 2016, complete C++11 support isn't there yet. But please also understand that I do not want to drop features or uglify the code just to make Microsoft's sub-standard compiler happy. The past has shown that there are ways to express the functionality such that the code compiles with the most recent MSVC - unfortunately, this is not the main objective of the project.
Please refrain from proposing changes that would break JSON conformance. If you propose a conformant extension of JSON to be supported by the library, please motivate this extension.
Please do not open pull requests that address multiple issues.

The LGTM test fails with the following log messages. The build environment might not have access to the outside world to download the repo.
[2019-04-28 22:11:39] [build] Scanning dependencies of target doctest_main
[2019-04-28 22:11:39] [build] [  1%] Building CXX object test/CMakeFiles/doctest_main.dir/src/unit.cpp.o
[2019-04-28 22:11:50] [build] [  1%] Built target doctest_main
[2019-04-28 22:11:50] [build] Scanning dependencies of target ExternalTestData
[2019-04-28 22:11:50] [build] [  2%] Creating directories for 'ExternalTestData'
[2019-04-28 22:11:51] [build] [  3%] Performing download step (git clone) for 'ExternalTestData'
[2019-04-28 22:11:51] [build] Cloning into 'data'...
[2019-04-28 22:11:54] [build] fatal: the remote end hung up unexpectedly
[2019-04-28 22:11:54] [build] Cloning into 'data'...
[2019-04-28 22:11:54] [build] fatal: the remote end hung up unexpectedly
[2019-04-28 22:11:54] [build] Cloning into 'data'...
[2019-04-28 22:11:55] [build] fatal: the remote end hung up unexpectedly
[2019-04-28 22:11:55] [build] -- Had to git clone more than once:
[2019-04-28 22:11:55] [build]           3 times.
[2019-04-28 22:11:55] [build] CMake Error at /opt/src/_lgtm_build_dir/test/ExternalTestData-prefix/tmp/ExternalTestData-gitclone.cmake:66 (message):
[2019-04-28 22:11:55] [build]   Failed to clone repository:
[2019-04-28 22:11:55] [build]   'https://github.com/nickaein/nlohmann-json-testdata.git'
[2019-04-28 22:11:55] [build] make[2]: *** [test/CMakeFiles/ExternalTestData.dir/build.make:91: test/ExternalTestData-prefix/src/ExternalTestData-stamp/ExternalTestData-download] Error 1
[2019-04-28 22:11:55] [build] make[1]: *** [CMakeFiles/Makefile2:1801: test/CMakeFiles/ExternalTestData.dir/all] Error 2
[2019-04-28 22:11:55] [build] make: *** [Makefile:141: all] Error 2

As documented here, LGTM doesn't support git clone for C++ projects.
For a workaround, I modified CMakeLists.txt to check for LGTM_WORKSPACE variable and skip downloading the external test data if LGTM is detected. Since we don't actually run the tests in LGTM, the external data were not needed in the first place.

Don't the git objects still exist in the repo? I understand that this would adjust the size of the working directory (the files currently checked out), but the repo-clone and on-disk storage would not be affected by this patch, right?

@jaredgrubb That's correct. The largest directories are test/data (~197 MBs), benchmarks/data (~60 MBs) and the git history .git (~179 MBs). This PR tackles the first one.
To reduce .git size, we have to rewrite the git history to remove the commits related to the large files. I'm still not clear how much of hassle it would case to the downstream though.

Coverage remained the same at 100.0% when pulling 800ef23016bc2b3f8b3d2c7f58d6689d2be82604 on nickaein:external-tests into ee4028b8e4cf6a85002a296a461534e2380f0d57 on nlohmann:develop.

@nlohmann : Just to confirm that after this PR happens, we will rewrite the repo? I personally don't object, I just want to make sure that is the PoR, or else this patch really doesn't add any benefit.

@jaredgrubb:
That's very good point! I agree that is PR would be less effective if we don't later reduce the size of .git too. However, I believe this can be still useful since:

Having this change in place, the future additions to test/data and benchmarks/data would not further increase the size of this repo. We might be stuck with a ~200 MBs .git in worst case scenarios, but it will not going to significantly increase further by adding more test/benchmarking data.

Assuming their setup supports it, the downstream users who does not need the full repo history can make a shallow clone (e.g. --depth 1 switch). Currently, even a shallow clone contains test data which is not helpful.

But still, I agree that removing test data from git history would be the way to go.
Regarding the git history rewrite, I think initially I was too optimistic and it could be controversial, to say the least. The most significant side-effect of rewriting history for the users is that all commit hashes will be changed. This invalidates all previous references based on commit hashes which could be problematic.
For instance, in Yocto project (a Linux distribution builder), a library version can be pinned down using its commit hash (also by git tag):
http://cgit.openembedded.org/meta-openembedded/tree/meta-oe/recipes-devtools/nlohmann-json/nlohmann-json_git.bb?h=master
They have pinned down
To put it simply, rewriting the history would not only affects the contributors, but also the end-users who rely on the commit IDs.
SRCREV = "aafad2be1f3cd259a1e79d2f6fcf267d1ede9ec7"
There should not be many of such usages, but we should be aware that rewriting the history will break their builds and they will be forced to make changes to fix it.

Is this PR useful on its own?
Very good point! I agree that the PR would be less effective if we are not going to reduce the size of .git later. However, I believe this can be still useful since:

Having this change in place, the future additions to test/data and benchmarks/data will not further increase the size of repository. We might be stuck with a ~200 MBs .git for now, but it will stay around the same size in the future.

The users who does not need the full repo history can make a shallow clone (e.g. --depth 1 switch), assuming their setup supports it. Currently, even a shallow clone contains test data lead to a large repo.

But still, I agree that removing test/benchmark data from git history would be the way to go.
Rewriting history is probably a bad idea
Regarding the git history rewrite, I think I was too optimistic initially. It could be controversial to say the least. Ignoring contributors, the most significant side-effect of rewriting history for the end-users is that all commit hashes will be changed. This invalidates all previous references that based on commit hashes which is be problematic.
For instance, in Yocto project (a Linux distribution builder), a library can be pinned down to a version using its commit hash (they also support git tags):
http://cgit.openembedded.org/meta-openembedded/tree/meta-oe/recipes-devtools/nlohmann-json/nlohmann-json_git.bb?h=master
They have pinned down to version 3.3.0 by setting this hash:
SRCREV=aafad2be1f3cd259a1e79d2f6fcf267d1ede9ec7
A history rewrite would force them to change this commit. Also, a history rewrite will premananetly invalides all links like above.
To put it simply, rewriting the history would not only affects the contributors, but also the users and scripts who rely on current commit hashes.
Possible solution
A safer option would be:

At some point (e.g. at version 4.0.0) we make this repository read-only and mark it as legacy.
A new repository (e.g. https://github.com/nlohmann/modern-json) is created as a clone of legacy repo with its history rewritten to remove all test/benchmark data.
Since we are rewriting the history, we can also do other things like revisiting the directories layout, removing/squashing other commits, etc. if necessary.
The future developments is done inside the new repository.

In this way, all of the previous history with original commit IDs will be kept as before and will be available as long as desired. The legacy repo can warns the users to use to new repo for the latest releases. Any newcomer or a current user who is willing to upgrade can use to the new repo.
I believe this is the viable and least intrusive solution for reducing the size of git history significantly. The question of When this should be done?, and Does it worth it? is up to the @nlohmann and other contributors to discuss and answer.

Just want to say that even if the repo remains as-is, I'd want to have release zips with source code which contain no testing data. This for me would be very useful and a good compromise.

Just want to say that even if the repo remains as-is, I'd want to have release zips with source code which contain no testing data. This for me would be very useful and a good compromise.

yeah, i dont really worry about repo size. as long as release remains small.

The problem that remains for me is that release zip doesn't contain CMakeLists.txt, so it's hard to integrate the library into CMake build process (you have to make the target yourself)


sysutils/nut: multiple fixes

fix rc, upsmon has always to be started
move name to general, makes no sense to have a name for each driver
fix pid file placement
prepare for diagnostics (it's ok, will stay in devel for longer, no showstopper)

My main problem is that restart function doesn't work. The daemon stops and doesn't come back.
In system.log there's:
Apr 14 07:21:14 OPNsense upsd[2467]: mainloop: Interrupted system call
Apr 14 07:21:14 OPNsense upsd[2467]: Signal 15: exiting
Apr 14 07:21:14 OPNsense usbhid-ups[2150]: Signal 15: exiting
Apr 14 07:21:14 OPNsense root: /usr/local/etc/rc.d/nut: WARNING: $nut_upsshut is not set properly - see rc.conf(5).
Apr 14 07:21:14 OPNsense upsmon[4898]: Signal 15: exiting
Apr 14 07:21:14 OPNsense upsmon[4866]: upsmon parent: read

If I execute the commands of restart action via CLI it works, perhaps some permission problem.

Fixed the reconfigure / restart bug, now mergable ..

Yep, pidfiles are there. Dont hate the player ;)
Franco Fichtner<EMAIL_ADDRESS>schrieb am So., 15. Apr. 2018,
10:34:

@fichtner commented on this pull request.
In sysutils/nut/src/etc/inc/plugins.inc.d/nut.inc
https://github.com/opnsense/plugins/pull/648#discussion_r181574702:

@@ -70,7 +70,7 @@ function nut_services()
'start' => array('nut start'),
'stop' => array('nut stop'),
),

       'name' => 'upsmon'

       'name' => '/var/db/nut/upsmon.pid'

sorry what? :D
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/opnsense/plugins/pull/648#pullrequestreview-112230082,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ATfeoY3GAxEP7u5TvHCi-onVcEVE7W3Gks5towX_gaJpZM4TU70h
.

Well, but look, you changed the process name to be the pid file, it makes little sense :)

I'll try to investigate why there's the exit 0 .. thanks :)


Introduce how to setup with pure Create React App

Can you update the documentation to provide setup for the pure ReactJS? Also, some examples how to use it in forms with ReactJS would be nice.

I recommend to using vite following https://github.com/samchon/typescript-json#vite the step, but you want not to use any boilerplate, right?

TypeScript handbook can be a good guide document.
Follow the https://webpack.js.org/guides/typescript/ step and just add special configuration of typescript-json following https://github.com/samchon/typescript-json#webpack

The project is using Create React App, so I would like to integrate and use your library in that setup if possible.

I don't know how to in CRA. Someone else knows how to?

I wanted to use typescript-json in an ejected CRA project, but CRA uses babel-loader and there is no option like getCustomTransformers as in ts-loader.

When builing project, Babel removes all types. Therefore, supporting Babel is not possible.
If no way to adapting ts-loader instead of babel-loader, no way. It would better to use vite instead.

Will support through #509


Add sphinx docs infrastructure

Hey! This looks like a great idea. I haven't used sphinx before - can we add this in its current state/what sort of info would you like me to add to the sphinx documentation vs the notebook tutorials?

Hey! This looks like a great idea. I haven't used sphinx before - can we add this in its current state/what sort of info would you like me to add to the sphinx documentation vs the notebook tutorials?

This adds the infrastructure to create documentation out of notebooks. All docs can be notebooks. It can be merged if it looks good.

Awesome, just updated it so it shows our relevant function documentation as well.


Create Concepts section under Getting Started

I propose that we add a new sub-section under Getting Started,  called Concepts which can house general architectural principals which we want all new users of Kubeflow to understand.
A possible initial structure is as follows:
Getting Started:
  - Installing Kubeflow
  - Concepts:
       - Overview (move from: started/kubeflow-overview)
       - Multi-Tenancy (move from: components/multi-tenancy)
       - ...
 - Examples (if we follow: https://github.com/kubeflow/website/issues/2759)
 - Support (if we follow: https://github.com/kubeflow/website/issues/2760)

NOTE: I have discussed this before in other issues, but in those I was proposing a new top-level section, whereas I now think its better to keep under Getting Started: https://github.com/kubeflow/website/issues/2659, https://github.com/kubeflow/website/issues/2671

@RFMVasconcelos what are your thoughts?

/priority p2


Add location field

Add location field in the account details form in profile page.
Design for reference.⬇

@vinayak-trivedi  can you assign me this issue ?


[FEATURE] OKD/Openshift support

Is it possible to deploy Longhorn on top of OKD (4.5)? Can someone share the correct SecurityContextConstraints & Longhorn settings in order to successfully deploy it in Fedora Coreos  / OKD cluster.
Thank you

I've heard people running Longhorn on top of OKD, but we haven't got time to experiment with it ourselves. It should be the same as a normal Kubernetes cluster? We can give it a try to see how it works.
Are there any specific constrains OKD have?

I've heard people running Longhorn on top of OKD, but we haven't got time to experiment with it ourselves. It should be the same as a normal Kubernetes cluster? We can give it a try to see how it works.
Are there any specific constrains OKD have?

I am struggling to deploy it. Firstly, I ve used ssc from here https://rook.io/docs/rook/v1.4/ceph-openshift.html so longhorn-manager ds could start running. However, they are still failing with error:
‘’’
is forbidden: cannot set blockOwnerDeletion if an ownerReference refers to a resource you can't set finalizers on: ,
‘’’

longhorn-manager-fvllp-longhorn-manager.log
longhorn-manager-8rjbj-longhorn-manager.log
longhorn-manager-fvqcr-longhorn-manager.log
I have addded 3 log files from workers. Is there anyone who can assist with that error?

We can refer to https://github.com/longhorn/longhorn/issues/1757 for some informations.
Also, need to check if we can get rid of bindmount /var/run in the manager. See https://github.com/longhorn/longhorn/issues/1757 for details.

Some notes I made when deploying to OKD 4.5:

Openshift uses SCC instead of PSP, give longhorn some privileges

oc adm policy add-scc-to-user anyuid -z default -n longhorn-system
oc adm policy add-scc-to-user privileged -z longhorn-service-account -n longhorn-system

Add permissions on node+engineimages/finalizers to longhorn-role

 - verbs:
      - '*'
    apiGroups:
      - longhorn.io
    resources:
      - engineimages/finalizers
      - nodes/finalizers
      ...

Enable iscsid.service on nodes
Fix selinux label on /var/lib/kubelet/obsoleted-longhorn-plugins (not sure why I did it like this)

apiVersion: machineconfiguration.openshift.io/v1
kind: MachineConfig
metadata:
  labels:
    machineconfiguration.openshift.io/role: worker
  name: 50-set-selinux-for-longhorn
spec:
  config:
    ignition:
      version: 3.1.0
    systemd:
      units:
        - contents: |
            [Unit]
            Description=Set SELinux for longhorn csi
            Before=kubelet.service

            [Service]
            ExecStart=/usr/bin/chcon -Rt container_file_t /var/lib/kubelet/obsoleted-longhorn-plugins

            [Install]
            WantedBy=multi-user.target
          enabled: true
          name: longhorn-hostpath-provisioner-selinux.service

There are some issues with node draining and rolling upgrades, see #1631

Hi is this fix in version 1.1.0 are 1.1.1 ?

Some notes I made when deploying to OKD 4.5:

@tvanderka many thanks for your notes
I can confirm that longhorn 1.1.0 is running on OKD4.6
additionally:

as a workaround for the usage of  /var/lib/kubelet/obsoleted-longhorn-plugins, I created a machine-config with a oneshot service

apiVersion: machineconfiguration.openshift.io/v1
kind: MachineConfig
metadata:
  name: 51-set-longhorn-worker
  labels:
    {{- include "project.labels" . | nindent 4 }}
    machineconfiguration.openshift.io/role: worker
spec:
  config:
    ignition:
      version: 3.1.0
    systemd:
      units:
        - contents: |
            [Unit]
            Description=Set SELinux chcon for longhorn
            Before=kubelet.service

            [Service]
            Type=oneshot
            RemainAfterExit=true
            ExecStartPre=/usr/bin/mkdir -p  /var/lib/kubelet/obsoleted-longhorn-plugins
            ExecStart=-/usr/bin/chcon -Rt container_file_t /var/lib/kubelet/obsoleted-longhorn-plugins

            [Install]
            WantedBy=multi-user.target
          enabled: true
          name: longhorn-provisioner.service
        - name: iscsid.service
          enabled: true
          state: "started"

removed /var/run from deployment.yaml

added oauth-proxy to the longhorn-ui.yaml

Rolling Updates

There are some issues with node draining and rolling upgrades, see #1631

as a quickfix (hopefully, only until  version 1.1.1/2) I wrote a litle bash-hack to go with rolling updates
#!/bin/bash

set -e
currentActive=""

while : ; do

  currentActive=$(oc get nodes | fgrep "worker " |awk '/SchedulingDisabled/ {print $1 }')
  [[ -z "${currentActive}" ]] && sleep 5 && continue

  echo_info "volume evict ${currentActive}"
  oc patch -n longhorn nodes.longhorn.io ${currentActive} -p '{"spec":{"allowScheduling": false,"evictionRequested": true}}' --type=merge

  while : ; do
   check=$(oc get nodes ${currentActive} | fgrep "worker " | fgrep SchedulingDisabled)
   [[ -n ${check} ]] || break
   echo -n "."
   sleep 5
  done

  echo ""
  echo_info "enable volumes ${currentActive}"
  oc patch -n longhorn nodes.longhorn.io ${currentActive} -p '{"spec":{"allowScheduling": true,"evictionRequested": false}}' --type=merge
done

Some notes I made when deploying to OKD 4.5:

@tvanderka many thanks for your notes
I can confirm that longhorn 1.1.0 is running on OKD4.6
additionally:

as a workaround for the usage of  /var/lib/kubelet/obsoleted-longhorn-plugins, I created a machine-config with a oneshot service

apiVersion: machineconfiguration.openshift.io/v1
kind: MachineConfig
metadata:
  name: 51-set-longhorn-worker
  labels:
    {{- include "project.labels" . | nindent 4 }}
    machineconfiguration.openshift.io/role: worker
spec:
  config:
    ignition:
      version: 3.1.0
    systemd:
      units:
        - contents: |
            [Unit]
            Description=Set SELinux chcon for longhorn
            Before=kubelet.service

            [Service]
            Type=oneshot
            RemainAfterExit=true
            ExecStartPre=/usr/bin/mkdir -p  /var/lib/kubelet/obsoleted-longhorn-plugins
            ExecStart=-/usr/bin/chcon -Rt container_file_t /var/lib/kubelet/obsoleted-longhorn-plugins

            [Install]
            WantedBy=multi-user.target
          enabled: true
          name: longhorn-provisioner.service
        - name: iscsid.service
          enabled: true
          state: "started"

removed /var/run from deployment.yaml

added oauth-proxy to the longhorn-ui.yaml

Rolling Updates

There are some issues with node draining and rolling upgrades, see #1631

as a quickfix (hopefully, only until  version 1.1.1/2) I wrote a litle bash-hack to go with rolling updates
#!/bin/bash

set -e
currentActive=""

while : ; do

  currentActive=$(oc get nodes | fgrep "worker " |awk '/SchedulingDisabled/ {print $1 }')
  [[ -z "${currentActive}" ]] && sleep 5 && continue

  echo_info "volume evict ${currentActive}"
  oc patch -n longhorn nodes.longhorn.io ${currentActive} -p '{"spec":{"allowScheduling": false,"evictionRequested": true}}' --type=merge

  while : ; do
   check=$(oc get nodes ${currentActive} | fgrep "worker " | fgrep SchedulingDisabled)
   [[ -n ${check} ]] || break
   echo -n "."
   sleep 5
  done

  echo ""
  echo_info "enable volumes ${currentActive}"
  oc patch -n longhorn nodes.longhorn.io ${currentActive} -p '{"spec":{"allowScheduling": true,"evictionRequested": false}}' --type=merge
done

@chrisu001 do your have for 2 maybe more information ?

@chrisu001 do your have for 2 maybe more information ?

@chrisu001 do your have for 2 maybe more information ?

simple remove the deprecated mount point from: https://github.com/longhorn/longhorn/blob/0fd0c33e06d7c998dee0f9a43056e4a0030638d9/chart/templates/daemonset-sa.yaml#L48

@chrisu001 do your have for 2 maybe more information ?

simple remove the deprecated mount point from: https://github.com/longhorn/longhorn/blob/0fd0c33e06d7c998dee0f9a43056e4a0030638d9/chart/templates/daemonset-sa.yaml#L48

And 3 you add the oauth-proxy to the longhorn-ui.yaml is that safe ?

And 3 you add the oauth-proxy to the longhorn-ui.yaml is that safe ?

@chrisu001 is your machine set config correct i test on okd 4.6 but getting this error error: error parsing fix-longhorn.yaml: error converting YAML to JSON: yaml: line 6: did not find expected node content

@chrisu001 is your machine set config correct i test on okd 4.6 but getting this error error: error parsing fix-longhorn.yaml: error converting YAML to JSON: yaml: line 6: did not find expected node content

@chrisu001 is your machine set config correct i test on okd 4.6 but getting this error error: error parsing fix-longhorn.yaml: error converting YAML to JSON: yaml: line 6: did not find expected node content
@jwklijnsma  remove the line

 {{- include "project.labels" . | nindent 4 }}

this is an extension of my helm chart toolkit template
Adding an oauth-proxy as a sidecar container is possible and safe, yes. Pls refer to the documentation of OKD. Maybe I'll find the time to write some gists

@chrisu001 is your machine set config correct i test on okd 4.6 but getting this error error: error parsing fix-longhorn.yaml: error converting YAML to JSON: yaml: line 6: did not find expected node content
@jwklijnsma  remove the line

 {{- include "project.labels" . | nindent 4 }}

this is an extension of my helm chart toolkit template
Adding an oauth-proxy as a sidecar container is possible and safe, yes. Pls refer to the documentation of OKD. Maybe I'll find the time to write some gists

How do you guys add disks to the nodes though? via MachineConfig?

How do you guys add disks to the nodes though? via MachineConfig?

is it still planed to support okd/openshift?

it is still open mr for the project https://github.com/longhorn/longhorn/pull/2909

I got an error related to nfs-utils installation on CoreOS. Now, I logged in to my CoreOS node and checked for the already installed packages. It turns out that CoreOS already has a different version of nfs-utils named nfs-utils-coreos.
I don't know what's the problem. Would appreciate any help.

@mujeebishaque maybe you could try rpm-ostree override remove nfs-utils-coreos --install nfs-utils from this https://github.com/coreos/fedora-coreos-tracker/issues/572#issuecomment-658918470

Updated PR: https://github.com/longhorn/longhorn/pull/5004

Openshift uses SCC instead of PSP, give longhorn needed privileges

oc adm policy add-scc-to-user anyuid -z default -n longhorn-system
oc adm policy add-scc-to-user privileged -z longhorn-service-account -n longhorn-system

Add permissions on node+engineimages/finalizers to longhorn-role. Required by OwnerReferencesPermissionEnforcement admission controller (not openshift specific, I hit this on different k8s cluster).

 - verbs:
      - '*'
    apiGroups:
      - longhorn.io
    resources:
      - engineimages/finalizers
      - nodes/finalizers
      ...

For those that are curious, confirm Longhorn 1.42 will deploy to OpenShift 4.12 using Steps 1 and 2 here

Verified on master-head 20230907

longhorn master-head https://github.com/longhorn/longhorn/commit/9948983b15f7d82af44a45917c270313668c3b2c

The test steps
https://github.com/longhorn/longhorn/issues/1831#issuecomment-1352487615
Result Passed

[x] OKD cluster new installed.
[x] Follow the steps in longhorn/chart/ocp-readme.md
[x] Functionalities of Longhorn work well.

Fresh install
Create a statefulset and write data
Scale down/up workload
Trigger replica rebuilding
Create volume backup and restored
Verify volume data
Uninstall

[x] require/doc : Checked documentation in https://github.com/longhorn/website/pull/765


Fixes to allow the model to load

Following the instructions in the readme, there were a couple of hiccups - here's the fixes

Thanks for that Mark! I would like to do a better integration of the dataset encoding part because it's quite tightly associated to the model and right now it's not really satisfactory to have it separated.


dashboard slug is cleared on import

Import a dashboard using superset import-dashboards cmd
Expected results
dashboard is imported as yaml file described
Actual results
dashboard is imported but slug is cleared
Environment
(please complete the following information):

superset version: 0.37
python version: Python 3.8.5
node.js version: v12.4.0
npm version: 6.14.7

Checklist
Make sure these boxes are checked before submitting your issue - thank you!

[ ] I have checked the superset logs for python stacktraces and included it here as text if there are any.
[x] I have reproduced the issue with at least the latest released version of superset.
[x] I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context
The slug is cleared on purpose, which is to avoid conflict, see https://github.com/apache/incubator-superset/blob/master/superset/models/dashboard.py#L316.
But that behavior is not expected in some cases.
If a dashboard is exported to a yaml and imported later, I would expect the same dashboard gets overwritten rather than creating a new dashboard with an empty slug.
This is very useful when I want to create/update dashboard automatically without manual intervene.
If user wants to avoid conflict, user can manually edit dashboard yaml file and set slug to null instead of hard clear in superset code.

@mistercrunch

FYI slug importing was disabled on purpose in #10118 . @stuarthu can you elaborate on your use case so we can assess if the current flow should be changed?

For instance, we might want to introduce an option where the user can choose to 1) ignore the to-be-imported slug 2) overwrite a possibly conflicting pre-existing slug 3) fail the import on conflicting slug. I think this may be a good option going forward that supports most use cases.

@villebro
The slug is cleared on purpose, which is to avoid conflict, see https://github.com/apache/incubator-superset/blob/master/superset/models/dashboard.py#L316.
But that behavior is not expected in some cases.
If a dashboard is exported to a yaml and imported later, I would expect the same dashboard gets overwritten rather than creating a new dashboard with an empty slug.
This is very useful when I want to create dashboard automatically without manual intervene.
If user wants to avoid conflict, user can manually edit dashboard yaml file and set slug to null instead of hard clear in superset code.

I am having the same problem as @stuarthu. I need to automate dashboard imports but it seems impossible to do this in a consistent way due to this slug clearing.
Anyone knows a way to solve this?

the best solution I've foubdn so far (as of version 1.5.1) is to have an import script that roughyl does the following:

finds target dashboard(s) to import, named by slug
deletes any existing dashboards with that slug
import the target dashboards
then send a PUT to set the slug values on each


Tapestry in Action

Enjoying Web Development with Tapestry

http://jumpstart.doublenegative.com.au/jumpstart/examples/ajax/treefromdatabasewithzones


update scenarios and suport validate scope func

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (eb82eb0) 100.00% compared to head (91d4cd5) 100.00%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main        #7   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            1         1
  Lines          159       199   +40
=========================================
+ Hits           159       199   +40

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[Bug]: DNS lookups in 14.2.x break sites using wss/https

Bug description
Steps to reproduce the problem:

Install recent puppeteer versions.
Use puppeteer.connect({ browserWSEndpoint: 'wss://chrome.browserless.io' })
Receive SSL error since we (possibly most sites?) won't have an IP addresses in the HTTPS altnames:

I've traced it to this diff: https://github.com/puppeteer/puppeteer/compare/v14.1.2...v14.2.0#diff-483229840b8c0a75e846133dc211986ef957c8f103789a2f82edb47693242dafR22. I'm not sure if it's a good/standard practice to add an IP to altnames in these certificates or if it's something that bigger tools (like certbot) allow, but found it an oddity myself. It's possible an attacker could obtain that IP address and start handling requests with an IP versus trying to take over the DNS entry -- so I'm skeptical adding IP addresses to the altnames should be the solution here. We use a pretty "vanilla" letsencrypt setup, and I'm sure many others will run into this issue as well.
Here's a snippet of some code:
const puppeteer = require('puppeteer');

(async () => {
  const browser = await puppeteer.connect({
    browserWSEndpoint: 'wss://chrome.browserless.io',
  });

  const page = await browser.newPage();

  await page.goto('https://www.example.com/');
  console.log(await page.title());
  await browser.close();
})().catch((e) => console.error(e));

Which produces (shortened):
[Symbol(kError)]: Error [ERR_TLS_CERT_ALTNAME_INVALID]: Hostname/IP does not match certificate's altnames: IP: <IP_ADDRESS> is not in the cert's list:
      at new NodeError (node:internal/errors:371:5)
      at Object.checkServerIdentity (node:tls:346:12)
      at TLSSocket.onConnectSecure (node:_tls_wrap:1540:27)
      at TLSSocket.emit (node:events:390:28)
      at TLSSocket._finishInit (node:_tls_wrap:944:8)
      at TLSWrap.ssl.onhandshakedone (node:_tls_wrap:725:12) {
    reason: "IP: <IP_ADDRESS> is not in the cert's list: ",
    host: '<IP_ADDRESS>',

Puppeteer version
14.2.1
Node.js version
16.13.2
npm version
8.1.2
What operating system are you seeing the problem on?
macOS
Relevant log output
ErrorEvent {
  [Symbol(kTarget)]: WebSocket {
    _events: [Object: null prototype] { open: [Function], error: [Function] },
    _eventsCount: 2,
    _maxListeners: undefined,
    _binaryType: 'nodebuffer',
    _closeCode: 1006,
    _closeFrameReceived: false,
    _closeFrameSent: false,
    _closeMessage: <Buffer >,
    _closeTimer: null,
    _extensions: {},
    _paused: false,
    _protocol: '',
    _readyState: 3,
    _receiver: null,
    _sender: null,
    _socket: null,
    _bufferedAmount: 0,
    _isServer: false,
    _redirects: 0,
    _url: 'wss://<IP_ADDRESS>/?token=70abbadb-66e8-45cd-9c02-0bfb7457dd99',
    _originalSecure: true,
    _originalHost: '<IP_ADDRESS>',
    _req: null,
    [Symbol(kCapture)]: false
  },
  [Symbol(kType)]: 'error',
  [Symbol(kError)]: Error [ERR_TLS_CERT_ALTNAME_INVALID]: Hostname/IP does not match certificate's altnames: IP: <IP_ADDRESS> is not in the cert's list:
      at new NodeError (node:internal/errors:371:5)
      at Object.checkServerIdentity (node:tls:346:12)
      at TLSSocket.onConnectSecure (node:_tls_wrap:1540:27)
      at TLSSocket.emit (node:events:390:28)
      at TLSSocket._finishInit (node:_tls_wrap:944:8)
      at TLSWrap.ssl.onhandshakedone (node:_tls_wrap:725:12) {
    reason: "IP: <IP_ADDRESS> is not in the cert's list: ",
    host: '<IP_ADDRESS>',
    cert: {
      subject: [Object: null prototype],
      issuer: [Object: null prototype],
      subjectaltname: 'DNS:api.browserless.io, DNS:chrome.browserless.io',
      infoAccess: [Object: null prototype],
      modulus: '9A3B34794B6BF030D3A27176999C920A936AF028BE5ACE27E0A3B3310B337468F7CA346FDD24E839AEBCD52F0BAA155341496D47FEC7CC027060AAEEBD9E63803DB748AA95C4FD20B864D80C31C6FC0E51681D1CD0F62FF744DC6BE2743D76648C23A37DFB0F226DA8E947D574A7ECC80F7B0DB509F476AF70050D44B87F7CE649ABAB6973D7329A75FA2CC704D0F30AF8938D5F0974E0A2E0727D81A9719FE61E169E4933D09047A72F92E2C49BC226708C4FE72CC3885CE1786901C7DC3985C4BA56E78590E3DBC3D6F6F5D439CEFA446EC8B09C82D2C9A4737C4181753DF54862B1155F18409C4652A3CDF9627F6BCAC9C799CAAE5C910432F389AD9B0B07',
      bits: 2048,
      exponent: '0x10001',
      pubkey: <Buffer 30 82 01 22 30 0d 06 09 2a 86 48 86 f7 0d 01 01 01 05 00 03 82 01 0f 00 30 82 01 0a 02 82 01 01 00 9a 3b 34 79 4b 6b f0 30 d3 a2 71 76 99 9c 92 0a 93 ... 244 more bytes>,
      valid_from: 'Jun  2 09:44:48 2022 GMT',
      valid_to: 'Aug 31 09:44:47 2022 GMT',
      fingerprint: '54:3C:76:19:B6:0C:97:FF:C9:72:DF:15:6B:18:F7:8E:44:DD:E6:8A',
      fingerprint256: '69:9B:7B:68:DB:DE:A6:FB:04:8D:3F:36:21:6A:73:9A:CF:A9:5C:6F:1A:75:A2:95:B4:C0:4F:F5:8D:FB:2E:5B',
      ext_key_usage: [Array],
      serialNumber: '0313FAD85AA3EB3BA9DB9BD144A3E1FC6B83',
      raw: <Buffer 30 82 05 44 30 82 04 2c a0 03 02 01 02 02 12 03 13 fa d8 5a a3 eb 3b a9 db 9b d1 44 a3 e1 fc 6b 83 30 0d 06 09 2a 86 48 86 f7 0d 01 01 0b 05 00 30 32 ... 1302 more bytes>,
      issuerCertificate: [Object]
    },
    code: 'ERR_TLS_CERT_ALTNAME_INVALID'
  },
  [Symbol(kMessage)]: "Hostname/IP does not match certificate's altnames: IP: <IP_ADDRESS> is not in the cert's list: "
}

Seeing this as well

Sorry about this! We'll get the fix up and running in 14.2.1. For now, please freeze 14.2.0 and wait till the next release (next week Monday)!

I have the same issue as well, also running 14.2.1


maxFileSize 256mb

I am trying to upload a large zip file, but getting the error "File is too big (256.89MiB). Max filesize: 256MiB."
How do I increase my max file size?

Has anyone found a good solution for this?  I tried including maxFileSize: 2000 in the djsConfig but it didn't override the property.  Trying to think of a solution besides forking Dropzone.js and modifying it, which ofc isn't optimal

For DropZone use maxFilesize with a lower s. 256MB is the default value.

A lot of other properties are not applied - maxFilesize, maxFiles, acceptedFiles etc.

@akash-more
maxFilesize: 5 seem to be equal to 5.02MB, just do a quick math to get 20GB
This is to say the value of maxFilesize is calculated in MB.


Enables overflow checks on all packages

As recommended by audit:

We recommend enabling overflow checks in all packages, including those that do not
currently perform calculations, to prevent unintended consequences if changes are added in
future releases or during refactoring. Note that enabling overflow checks in packages other
than the workspace manifest will lead to compiler warnings.

@ralexstokes sure, that sounds good. 😄


The widget automatically deleted after restart/shut down

Dev Home version
<IP_ADDRESS>
Windows build number
10.0.25370.1
Other software
OS Build Version: 10.0.25370.1.amd64fre.zn_release.230516-0802
.NET Version: .NET 6.0.16
Steps to reproduce the bug
I pin the "widget" like RAM, GPU, etc. But it was deleted automatically after I restart the laptop. So when I open this app again, I must pin again those "widget".
Expected result
The "widget" always saved even the laptop restart, shut down, etc. So I don't need to pin again.
Actual result
The widget is lost/"deleted". So, I need to pin it again.
Included System Information
CPU: AMD Ryzen 5 3500U with Radeon Vega Mobile Gfx
Physical Memory: 9.95GB (5.31GB free)
Processor Architecture: x64
Included Extensions Information
Extensions:
Microsoft.Windows.DevHome_<IP_ADDRESS>_x64__8wekyb3d8bbwe
Microsoft.Windows.DevHomeGitHubExtension_<IP_ADDRESS>_x64__8wekyb3d8bbwe

Duplicate of #742


Updated imports

From pandac.PandaModules to panda3d.core. For new Panda3D 1.9

Hi! Thanks for the PR, sorry for the delay in responding. What problem does this solve? Has the panda3d API changed?


Update the Slack invite link

The Slack invite link on the homepage was out-of-date. See this relevant
issue: https://github.com/kubeflow/website/issues/1456

This change is

Thanks!
/lgtm
/approve


[App Insights] Fix string modeling for enum, package naming

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information

[x] The title of the PR is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
[x] Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
[x] If applicable, the PR references the bug/issue that it fixes.
[x] Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

[x] I have read the contribution guidelines.
[x] My spec meets the review criteria:

[x] The spec conforms to the Swagger 2.0 specification.
[x] The spec follows the guidelines described in the Swagger checklist document.
[x] Validation tools were run on swagger spec(s) and have all been fixed in this PR.

Automation for azure-sdk-for-js

Automation for azure-sdk-for-python

Automation for azure-sdk-for-go

Automation for azure-sdk-for-node

Automation for azure-sdk-for-ruby

Automation for azure-sdk-for-java

Context for renaming packages: Application Insights offers SDKs to both ingest data and to query data. The SDKs for ingestion and sending telemetry are outside of this repository. There's some fairly significant name ambiguity between them currently, e.g.:
Microsoft.ApplicationInsights -> send telemtry
Microsoft.Azure.ApplicationInsights -> query telemetry already in Azure.
The issue applies across languages. I've discussed this offline with a few folks from App Insights and SDK side, and we are working towards renaming these packages with Query for clarity prior to releasing a stable version of the data plane SDKs.

Can one of the admins verify this patch?


chore: also run CI on fix/* and perf/* branches

Description
Just a small thing.
I find myself creating branches named feat/fix-* because I want the CI to be run.
Maybe we can also run the CI on fix/* branches, so that I create branches named fix/* instead of feat/fix-*.
Same for perf/*.
What is the purpose of this pull request?

[ ] Bug fix
[ ] New Feature
[ ] Documentation update
[x] Other

Before submitting the PR, please make sure you do the following

[x] Read the Contributing Guidelines.
[x] Read the Pull Request Guidelines and follow the Commit Convention.
[x] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
[x] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
[x] Ideally, include relevant tests that fail without this PR but pass with it.

Vite's test suite is getting more robust with the latest changes in the 2.9 beta. But we still get some false fails. I don't think that we gain much by duplicating the tests for fix and perf at this point. Maybe we could revisit later.

From Vite team's perspective, this may seem like a duplication of tests, but it isn't for the contributor: I let Vite's CI test my branch on my brillout fork of Vite, so that I know I didn't break anything before opening a PR.
Currently, if I create a branch fix/some-bug on my brillout Vite fork, the CI isn't run.
That's why I create branches named feat/fix-* so that the CI is run.
Anyways, it's just a small thing and I'm fine if we close this PR.


Don't do a remrange for each window on mget

Errr… what. It's a Bowsh!

Tidying up my open Pull Requests :)


chore(deps): upgrade configuration

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-configuration-k8s-28-main" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 3899

Questions ?
Please refer to the Backport tool documentation


NSCalendar tests fail on OSX

https://github.com/Microsoft/WinObjC/issues/743 may be related.
[ RUN      ] NSCalendar.GetDates
unknown file: Failure
Unknown C++ exception thrown in the test body.
[  FAILED  ] NSCalendar.GetDates (61 ms)
[ RUN      ] NSCalendar.CompareDates
Foundation/NSCalendarTests.mm:240: Failure
Value of: NSOrderedAscending
Actual: -1
Expected: [calendar compareDate:date1 toDate:date2 toUnitGranularity:NSCalendarUnitNanosecond]
Which is: 0
[  FAILED  ] NSCalendar.CompareDates (0 ms)
[ RUN      ] NSCalendar.PreserveSmallerUnitsMatching
Foundation/NSCalendarTests.mm:345: Failure
Value of: actualDate
Actual: 2012-02-29 08:00:00 +0000
Expected: expectedDate
Which is: 2012-02-29 11:04:05 +0000
[  FAILED  ] NSCalendar.PreserveSmallerUnitsMatching (5 ms)
[ RUN      ] NSCalendar.weekOfUnitMatching
Foundation/NSCalendarTests.mm:405: Failure
Value of: actualDate
Actual: 2000-01-30 08:00:00 +0000
Expected: expectedDate
Which is: 2000-02-05 08:00:00 +0000
[  FAILED  ] NSCalendar.weekOfUnitMatching (7 ms)
[ RUN      ] NSCalendar.NSRangeValidation
Foundation/NSCalendarTests.mm:486: Failure
Value of: 5
Expected: range.length
Which is: 6
[  FAILED  ] NSCalendar.NSRangeValidation (0 ms)

Was investigating the unknown C++ exception in case we had a more general problem; this seems to be the problematic section:
dateCount = 0;
[calendar enumerateDatesStartingAfterDate:[NSDate dateWithTimeIntervalSinceReferenceDate:0]
                       matchingComponents:leapYearComponents
                                  options:NSCalendarSearchBackwards
                               usingBlock:^(NSDate* date, BOOL exactMatch, BOOL* stop) {
                                   NSString* result = [dateFormatter stringFromDate:date];
                                   ASSERT_OBJCEQ([result substringWithRange:NSMakeRange(0, 6)], @"Feb 29");
                                   if (++dateCount == 50) {
                                       *stop = YES;
                                   }
                               }];


Add scala interface

Related to #3485. Please check @karlnapf

This is not nearly what is needed.
I mean I dont want to discourage you, but maybe consider starting with something simpler.
Ill close this for now as it is a nop.

@karlnapf I would like to learn about Shogun contribution as quickly as possible. Hence I am picking up complicated issues. I would like to have some guidance in this. I apologize if I made a bad contribution.


Changing captive portal use

Hello,
I want to use your initial code to create more inputs on the captive portal. However I am not sure where these initial files installed. When installing the wifi-connect via the curl request where does it install these files on a raspberry pi?

@CBC-LSM  were you able to find a solution for this? I am also trying to change the default UI and add more forms for our database.

I did not. I am very interested in still getting this to work though. I am not very good at this so I am not able to figure it out on my own

Hi @CBC-LSM! Only recently, I saw that there's a UI argument when running wifi connect on the terminal so I'm planning to create a repository with my own designs and then use my own UI folder as argument. I'll be documenting it for future purposes and I'll post this on this thread for your convenience. Thank you!

Hi @CBC-LSM , I was able to get help from balena forums, here's the link to the thread: https://forums.balena.io/t/adding-custom-ui-raspios-buster-lite-armv61/174445/20.


Expand the test matrix to support rails 4.2 and 5.0

All Submissions:

[ ] I've checked to ensure there aren't other open Pull Requests for the same update/change.
[ ] I've submitted a ticket for my issue if one did not already exist.
[ ] My submission passes all tests. (Please run the full test suite locally to cut down on noise from travis failures.)
[ ] I've used Github auto-closing keywords in the commit message or the description.
[ ] I've added/updated tests for this change.

New Feature Submissions:

[ ] I've submitted an issue that describes this feature, and received the go ahead from the maintainers.
[ ] My submission includes new tests.
[ ] My submission maintains compliance with JSON:API.

Bug fixes and Changes to Core Features:

[ ] I've included an explanation of what the changes do and why I'd like you to include them.
[ ] I've provided test(s) that fails without the change.

Test Plan:
Reviewer Checklist:

[ ] Maintains compliance with JSON:API
[ ] Adequate test coverage exists to prevent regressions

Plan is for v0.10.3 to be the last release to support rails 4.2 and 5.0. This could be fixed, but I don't have the time.


[orm/gorm] Allow configuration of singulartable

I'm using DB.SingularTable(true) but I have to use this code within every function of my controllers.
I didn't find a general place to set this value and I'd expect it to be configurable using the app.conf file.
Would it be possible to add a new configuration attribute? e.g. 'db.singulartable', so there is a general and unique place where this can be configured.

A good place to set that would be in the
revel.AppStart(func(){
gorm.DB.SingularTable(true)
})

But configurable is fine as well

A good place to set that would be in the
revel.AppStart(func(){
gorm.DB.SingularTable(true)
})

But configurable is fine as well

Yes @notzippy, it would be a good place but if use that code there, people who don't want/need to use SingularTable will have to use DB.SingularTable(false) within every function in their controllers.


Date range filter not working

Example of my use attached. It just wont filter.
http://jsfiddle.net/grLzcgbn/

Just remove the searching:!1, and it will work see sample and read the following stackoverflow question/answer and the commets (follow the links for more gems)

Perfect. Thanks!


Support for Orion browser

Reported broken at https://chrome.google.com/webstore/detail/crossword-scraper/lmneijnoafbpnfdjabialjehgohpmcpo.
Most likely just going to have to keep this on the backlog along with other unsupported browsers, but if I get a chance I can at least take a look to see what the story is.

I gave this a try for a few minutes and couldn't really get anywhere with either the Firefox or the Chrome version. For one, I can't get the console to load without closing the popup, which is making debugging impossible. I see an error in the console, "Failed to load resource: The operation couldn’t be completed. (Orion.SchemeHandlerError error 2)", which seems to be fairly common from a quick Google search.
Since Orion doesn't advertise working extension support at this point, I think there's not much to be done but wait until they do. If someone feels intrepid, they should feel free to file a bug proactively.


[JBEAP-13424] Error on resetting large message deliver - null: java.l…

…ang.NullPointerException
(cherry picked from commit 53efdbab49eea8755571b2e76ae3f8bf62d364be)
Jira: https://issues.jboss.org/browse/JBEAP-13424
upstream: https://issues.apache.org/jira/browse/ARTEMIS-1455

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Deferred - fixed in 7.1.2