Should be able to have authenticated local non-TLS traffic

I have a PR that very coarsely seeks to do this https://github.com/GoogleCloudPlatform/google-cloud-python/pull/2825, but @dhermes and @jonparrott said that, if this is my goal, there is an easier way to configure how we use the AuthMetadataPlugin to do this.
There are cases where you want to do this... I'm happy restricted it just to traffic to localhost, as that is lower risk.

@jcoatgoogle FWIW, there is "no such thing" as localhost. It's just a convenient alias that's typically in a local hosts file in most OSes. It's typically an alias the very special loopback IP, but doesn't have to be.

Then it doesn't have to have the restriction. I guess that was just more handholding, but if someone sets VENEER_HTTP_AUTH_NO_REALLY or whatever, then it gets it...or whatever configuration, really.

Ok, so, separately, I was finally able to get a pure java HTTP2 reverse proxy... this may allow me to avoid having to do this, which I think would make everyone involved happy.
@jonparrott, you had mentioned that the reverse proxy could do authentication. I actually have that working with application default credentials, but what I'm wondering is if that is always valid? I'm trying to think of cases where the user might have more complicated authentication that this issue would meet (since the auth token would be the same), but just grabbing the default credentials on the proxy wouldn't.

I'm trying to think of cases where the user might have more complicated authentication ...

I would just recommend making your proxy respect the GOOGLE_APPLICATION_CREDENTIALS command, or otherwise have a way to specify authentication, e.g.:
$ your-proxy --use-gce-auth
$ your-proxy --use-service-account /path/to/service_account.json
$ your-proxy --use-bearer-token "bearer_token"
$ env GOOGLE_APPLICATION_CREDENTIALS=/path/to/service_account.json your-proxy


Failed to build communication between rosbridge_websocket and /joint_states nodes

Hi Team
I am trying to sync a UR5 robot arm between Unity and ROS through ROS#. I've created a joint state subscriber in ROSconnector as it shows in the ROS# wiki for turtlebot.
However, in rqt_graph it appears the communication  between rosbridge_websocket and /joint_states nodes are in the wrong way. And of course, I could not sync the UR5 arm in Unity as all, even though the arm in Gazebo and Rviz at ROS side work well.
Can anyone of you kindly tell me how to successfully build up the link? Thanks a lot.
Unity side:

ROS side:(Please take a look at rosbridge_websocket node )

Hi @Bertrand64300,
I believe you are using an old version of ROS#, and following the old Gazebo Simulation tutorial video. In order for us to be able to support you better, please consider updating to the newest version of ROS#. After doing that, following this newer tutorial should help you to sync the UR5 joint states between Gazebo and Unity.
Best, Suzannah

Hi @suzannahsmith1,
Thank you for your response. I tried to download the new version of ROS# but it seems that it is not working on my computer. Indeed, I'm using Unity 2017.4.1f1 for my project (cause some of the packages I need to use require this version of Unity) and I saw on your ROS wiki that "the RosSharp solution is built using .NET Framework 4.6. It requires Unity 2018.x to run".
Is there any way for me to achieve what I want with the old version of ROS#?
Cordially,
Bertrand

Hi @Bertrand64300 , surely you can stick to an older version of ROS# and set up your ROS communication with that. The first video linked by @suzannahsmith1 above also is for the older version.


chore: Delete restriction for names in protobufs

Current dependencies on/for this PR:

main

PR #2642   👈

This comment was auto-generated by Graphite.


[PROPOSAL] 7057 Add a Configurable Event Throttling Policy to Asynchronous Emitters

Motivation
See the issue raised by @leventov (#7057).
Proposed changes
I think that out of the five Emitters listed in #7057, I would change all but StatsDEmitter.  The code that handles enqueuing for the StatsDEmitter is in library class NonBlockingStatsDClient so there wouldn’t really be any way of changing it without rewriting the class.
The two approaches to refactoring:

In an ideal world, I'd create an abstract class QueueBasedEmitter which holds the event queue and implements int offerAndHandleFailure(event), and have the four emitters that write to queue (see list in Motivation) extend it.  This method would try to offer the event to the queue.  If the offering fails, events would be discarded from the queue (based on the configurable policy) until the offer succeeds (this approach assumes that the only reason for a offer() call failing is a full queue).  The number of discarded events would be returned from the function so that the Emitter implementation can use it accordingly; for example, KafkaEmitter has a count of lost events that is periodically logged.   However, I'm not sure if this is feasible since AmbariMetricsEmitter already extends AbstractTimelineMetricsSink and Java doesn't support multiple inheritance.  It would be possible if AmbariMetricsEmitter was ignored in the refactor but that doesn't seem to be a very object-oriented approach.

I think the more feasible approach would be to create a helper class that accepts the event queue as a constructor argument and implements int offerAndHandleFailure(event).  The helper class would be instantiated when the Emitter constructor is called.  The helper would work in AmbariMetricsEmitter, KafkaEmitter, and GraphEmitter with minimal change since they all already use BlockingQueues.  HttpPostEmitter can use the queue approach if its buffersToEmit Deque is converted to a BlockingQueue.  I think this substitution would work since only addLast() and pollFirst() are called on the Deque.

With regard to configuration, I'm thinking of adding the following config parameters:

...emitter.eventThrottlingPolicy [String]: specifies what policy to follow when the queue is full and a new event is offered (i.e. BlockingQueue#offer() times out)

"dropOldest" (default)": discards oldest event from the queue
"dropNewest": discards the event that was just offered

...emitter.eventThrottlingLoggingFrequency [double from 0 to 1]: specifies how often an event being dropped should be logged.  This policy is pretty naive as it assumes the offer failure frequency is constant.  A better (but more challenging) approach might be to tune the logging rate based on the number of failures that have occurred in the past n seconds/minutes.

1: Log every dropped event
0.001: Log 1 in every 1000 dropped events
0: Don't log any dropped events

If anyone thinks that any of the above configs should be removed or modified, or another should be added, leave a comment below.
Rationale
I believe the helper-based approach to refactoring event emission is the best approach because it is the most object-oriented and avoids doing anything hacky with existing code.  The one other option is to have each Emitter implementation implement its own handling of the event throttling policy but that doesn't really help with code reuse.
Operational impact
Likely not?  It would be awesome if someone with more knowledge of users' use cases with metrics could comment on this.
Open questions

What's the best thing to log when an event is dropped?  Count of dropped events, a serialized version of the event, or just the fact that an event has been discarded?
Does this change have an operational impact?

AmbariMetricsEmitter doesn't need to extend AbstractTimelineMetricsSink. This is actually a bad use of inheritance instead of composition. Its internal ConsumerRunnable can extend AbstractTimelineMetricsSink, or a separate private class.
I'm not sure we should introduce configurations before somebody actually needs them. One reason is that it's hard to change HttpPostEmitter to support policies different from "drop oldest batch", that is also not exactly equivalent to queue-based emitters's "drop oldest events". I think we may start with just dropping oldest events in queue-based emitters and reporting, for example, one 1000th drop (but making sure that we report the very first one).

I'm looking at the Kafka metrics emitter and I'm kinda stumped about a design decision.  The way it's currently implemented, it follows the pattern of all the other emitters where events are pushed to some queue then some thread dequeues events and does something with them.  In this case, the thread sends the event to Kafka using the KafkaProducer.  From what I understand, the Kafka producer has its own memory-bounded buffer where records are batched before actually being sent.  From the javadoc:

The producer consists of a pool of buffer space that holds records that haven't yet been transmitted to the server as well as a background I/O thread that is responsible for turning these records into requests and transmitting them to the cluster.

If this is the case, is there any benefit of having the first queue if it's being buffered on the same machine at a later stage?  If not, should it really fit into this Queue-based emitter pattern at all?

@justinborromeo interesting. Does KafkaProducer support custom event dropping policies? It seems to me that we should treat it as we treat NonBlockingStatsDClient.

I don't think it does.  I think it just fails the message that's being added to the full queue.

Could you please open an issue in the Kafka library?

Done: https://issues.apache.org/jira/browse/KAFKA-7953


Breaks on column called "Representative's Address"

Trying this against a CSV exported from https://www.regulations.gov/bulkdownload I got an exception visiting /-/edit-schema/data/tablename - error was:

OperationalError: near "Address": syntax error

One of the columns in the table was called Representative's Address and I think the ' broke it.
The traceback highlighted examples_for_columns:

https://datasette-cloud.sentry.io/issues/4380834663/?project=2050376&query=is%3Aunresolved&referrer=issue-stream&stream_index=0

Function: https://github.com/simonw/datasette-edit-schema/blob/05a155e8c46cfa6f1fc164370b73cf5f047f4010/datasette_edit_schema/utils.py#L92-L125

Here's the bug: https://github.com/simonw/datasette-edit-schema/blob/05a155e8c46cfa6f1fc164370b73cf5f047f4010/datasette_edit_schema/utils.py#L101
Resulted in:
select 'photo's' as label, "photo's" as value from col4),

Another error:
  File "/Users/simon/Dropbox/Development/datasette-edit-schema/datasette_edit_schema/utils.py", line 66, in potential_primary_keys
    cursor.execute(sql)
sqlite3.OperationalError: near "s": syntax error

https://github.com/simonw/datasette-edit-schema/blob/05a155e8c46cfa6f1fc164370b73cf5f047f4010/datasette_edit_schema/utils.py#L54-L89
That generated SQL like this:
select count(*) as _count,
count(distinct "Document ID") as 'distinct.Document ID',
count(distinct "Agency ID") as 'distinct.Agency ID',
count(distinct "Representative's Address") as 'distinct.Representative's Address'
from "lok-imd8-3w1z"


connect ETIMEDOUT <IP_ADDRESS>:443

I use npm i install twitch-chatlog in my windowspower shell but it can't link to some address.
I tried proxy but it still didn't work.
Here is the error.

PS D:\lydia\life\candycrash> twitch-chatlog 79240813
{ FetchError: request to https://api.twitch.tv/kraken/videos/79240813 failed, reason: connect ETIMEDOUT <IP_ADDRESS>:443
at ClientRequest. (C:\Users\TF\AppData\Roaming\npm\node_modules\twitch-chatlog\node_modules\node-fetch\lib\index.js:1455:11)
at emitOne (events.js:116:13)
at ClientRequest.emit (events.js:211:7)
at TLSSocket.socketErrorListener (_http_client.js:387:9)
at emitOne (events.js:116:13)
at TLSSocket.emit (events.js:211:7)
at emitErrorNT (internal/streams/destroy.js:64:8)
at _combinedTickCallback (internal/process/next_tick.js:138:11)
at process._tickCallback (internal/process/next_tick.js:180:9)
message: 'request to https://api.twitch.tv/kraken/videos/79240813 failed, reason: connect ETIMEDOUT <IP_ADDRESS>:443',
type: 'system',
errno: 'ETIMEDOUT',
code: 'ETIMEDOUT' }
(node:11168) UnhandledPromiseRejectionWarning: FetchError: request to https://api.twitch.tv/kraken/videos/79240813 failed, reason: connect ETIMEDOUT <IP_ADDRESS>:443
at ClientRequest. (C:\Users\TF\AppData\Roaming\npm\node_modules\twitch-chatlog\node_modules\node-fetch\lib\index.js:1455:11)
at emitOne (events.js:116:13)
at ClientRequest.emit (events.js:211:7)
at TLSSocket.socketErrorListener (_http_client.js:387:9)
at emitOne (events.js:116:13)
at TLSSocket.emit (events.js:211:7)
at emitErrorNT (internal/streams/destroy.js:64:8)
at _combinedTickCallback (internal/process/next_tick.js:138:11)
at process._tickCallback (internal/process/next_tick.js:180:9)
(node:11168) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:11168) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

I'm sorry, but this looks like a network issue on your side, or possibly an invalid client ID.


multiple-database-support-added

Describe your changes :

I worked on adding multiple database support in Postgres.
fix #3732

Type of change :

[x] Improvement
[x] New feature

Checklist:

[x] I have read the CONTRIBUTING document.
[x] I have commented on my code, particularly in hard-to-understand areas.

Reviewers
@harshach @ayush-shah @pmbrull

shall we wait for the service.db.schema PR for these changes? @harshach

@codingwithabhi can we merge this in?

@codingwithabhi let's add postgres schema fix inside this PR and merge it in today


Matriculation management and changes to user management

Description
Implements matriculation management api + changes to user management api
Implements matriculation user stories (still with mock data, as API is not yet deployed nor tested)
@theovier we would like to merge this branch asap, even if the matriculation management is untested, as the user management API has changed and Lagom is still waiting to deploy 0.6.0. We can test the matriculation when HL deploys.
This branch is already pretty old and will only introduce more merging problems, while it is not even actively worked on anymore.
Type of change (remove all that don't apply)

New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)

user management API changed, might break features. We will test (on this branch) when this PR is accepted and lagom has deployed.

How Has This Been Tested?
We have not tested anything yet.
Checklist: (remove all that don't apply)

[ ] I added corresponding E2E tests (especially for bugfixes)
[X] I added corresponding unit tests (if API code)
[X] I have performed a self-review of my own code
[X] My changes generate no new linting warnings or console warnings
[X] I have updated the CHANGELOG.md to include any changes made in this PR (add WIP to the top, if there is none already)

all tests work (except for matriculation management, which is still untested).
we should implement #403 on this branch before merging, as the phone number is part of the user management target version of this branch.
@tobias-wiese @theovier

Looks good.
Modal
Maybe we should consider removing the "refresh" button from the history modal as it is very unlikely that the matriculation status changes while this menu is opened? If we choose to keep the buttons, we should make one of them a primary action button. Or we could consider removing them all and just keep the X in the top right corner, however, I'm unsure if we should at least keep the cancel button for UX reasons.

Looks good.
Modal
Maybe we should consider removing the "refresh" button from the history modal as it is very unlikely that the matriculation status changes while this menu is opened? If we choose to keep the buttons, we should make one of them a primary action button. Or we could consider removing them all and just keep the X in the top right corner, however, I'm unsure if we should at least keep the cancel button for UX reasons.

The refresh button is needed at this point as the data would else just be refreshed on page reload. But it could be the case, that a student awaits an update of his immatriculation. @bastihav an I discussed these use cases when removing the caching option from the modal.

Looks good.
Modal
Maybe we should consider removing the "refresh" button from the history modal as it is very unlikely that the matriculation status changes while this menu is opened? If we choose to keep the buttons, we should make one of them a primary action button. Or we could consider removing them all and just keep the X in the top right corner, however, I'm unsure if we should at least keep the cancel button for UX reasons.

The refresh button is needed at this point as the data would else just be refreshed on page reload. But it could be the case, that a student awaits an update of his immatriculation. @bastihav an I discussed these use cases when removing the caching option from the modal.

Even if the student awaits updates on his immatriculation status, I doubt that he would let the modal open and refresh it instead of refreshing the whole page.

Looks good.
Modal
Maybe we should consider removing the "refresh" button from the history modal as it is very unlikely that the matriculation status changes while this menu is opened? If we choose to keep the buttons, we should make one of them a primary action button. Or we could consider removing them all and just keep the X in the top right corner, however, I'm unsure if we should at least keep the cancel button for UX reasons.

The refresh button is needed at this point as the data would else just be refreshed on page reload. But it could be the case, that a student awaits an update of his immatriculation. @bastihav an I discussed these use cases when removing the caching option from the modal.

Even if the student awaits updates on his immatriculation status, I doubt that he would let the modal open and refresh it instead of refreshing the whole page.

As a user, I would expect reopening the modal would show new data, however this is not easily feasible as the modal is rendered in the DOM at page loading


MONAI-based fetal brain segmentation pipeline

A new sub-module will be included in the package to perform the automated segmentation of brain in fetal MRI.
This module will be developed using the MONAI framework (https://monai.io/) and will provide:

[ ] A new pretrained model that improves the performance of the currently used one
[ ] The associated python script to run inference with the provided model
[ ] Utilities to (re-)train the segmentation model to ease the introduction and use of model updates within the package.

Part of NiftyMIC v0.8 since f4432f18f02de55f1f61265d83219566dccf655c


TrickSplit

Hi, what is best split settings to get these awesome tricks becouse its not working, when we do split trick the enemy eat the cells on spliting!
https://www.youtube.com/watch?v=E9pcV5DULGs

The current settings are the best settings. The amount of time it takes collision for cells to restore after splitting is the same as it is on vanilla servers.


I'd like to re-run tests for a PR by leaving a comment on that PR's discussion thread

Is your feature request related to a problem? Please describe.
To re-run tests I have to pin and un-pin on Concourse, and it's error prone, and hard.

Describe alternatives you've considered
Pin and unpin and Pin and unpin and Pin and unpin and Pin and unpin and Pin and unpin and Pin and unpin and Pin and unpin and Pin and unpin and Pin and unpin.

See https://probot.github.io/docs/webhooks/

I've heard this idea before. Ping @mook-as

I still believe in not putting in bot-directed and bot-originated comments, since mixing communication methods is painful.  I'd prefer something like a CI: Queued label the PR that the bot would automatically remove once the branch arrives in CI, so that re-triggering is 2-click (once to show the Labels list, and once to select the label).  Or do it with some fancy REST API call / CLI if you prefer.  That's few buttons than typing out all of test please :D Also, that means you can't queue a second run before the first run has landed in CI (but, depending on how we implement it, might be able to queue it before the first run completes)…
(And, yes, issues has a labeled event.)
Labels would not work as well if we have more fine-grained configuration (e.g. if we want to say "only run CATS, not any of the other test suites").

@viovanov closing this issue since we decided to move quickly to the GHA.


The onboarding title does not honor dark mode

What

The onboarding title does not honor dark mode
The Next Button is not contrasted enough

Part of

#684

Screenshot/Mockup/Before-After

If the user prefers to open the app under the forced dark mode, should we consider adding dark mode support here?

This issue is not present, I think we should close this issue.

The problem still occurs to me

But yes @GowthamGoush

This one is fixed.


Autodiscovering tables fails on Oracle

Hello,
I am unable to create a DB connected service on Oracle 11. (Oci8 driver) The error returned when selecting the db adapter is ORA 01745 (invalid host/bind variable name).
A simple oci_connect() test works perfectly with the same instance/schema.

This is due to a bug in zend-db. There is already a PR to fix this (https://github.com/zendframework/zend-db/pull/34) so hopefully this will soon work with oracle also.

Thanks for feedback, I will give your patch a try, hopefully, tomorrow.

I have just tested your fix, and now the UI can list the tables, thanks !
But clicking the 'create service' after having selected a table doesn't do anything. The modal window doesn't close and the service isn't created.
The JS error triggered is Error: e.rest is undefined. Looks more like an JS problem now !

The .js bug is already fixed in master ! I can confirm that your fix works like a charm for the moment !


Survive for as long as possible from the exploding bombs.
How do you play your game?
WASD to move. bomb can be pushed. It explodes in straight lines on x and y axis.
Code
Check off the items that are true.

[ x] The game was made using the Sprig editor.
[ x] The game is placed in the in the /games directory.
[ x] The code is significantly different from all other games in the Sprig gallery (except for games labeled "demo").
[x] The game runs without errors.
[ x] The name of the file/game contains only alphanumeric characters, -s, or _s.
[ x] The game name is not the same as the others from gallery

Image (If an image is used)
N/A

[ ] The image is in the /games/img directory.
[ ] The name of the image matches the name of your file.

Thanks for your PR!

My school's (Bronx Science) hack club


Yang schema evolution should invalidate compiled configurations from old schema revisions

In #1183, the snabb-softwire-v2 schema gained a leaf.  This should have been accompanied with a new revision-date in the schema, but it wasn't.  With a new revision-date, old compiled configurations without this leaf would know that they're stale.  If the stale configuration is used, you end up with a configuration without a given leaf or its default value, which breaks some invariants in the code.
However -- the binary configuration loader currently does not detect that the loaded file is against an old revision.  It should check that the binary was compiled against the latest revision of the schema known to Snabb.

Additionally, can be fixed in the same patch: if yang.load_configuration is given a compiled file directly, but the compiled file fails to load for whatever reason, then we could erroneously return nil from this function.


Firebase-Function not working

After downloading this file , when i use my firebase credentials in .env and start the project . But the firebase is not working . it shows this error.
Error: Missing permissions required for functions deploy. You must have permission iam.serviceAccounts.ActAs on service account
<EMAIL_ADDRESS>To address this error, ask a project Owner to assign your account the "Service Account User" role from this URL:

You also need to go to your firebase console and enable everything required for the project to run like: Authentication, Storage, Realtime Database and so on.

Closing this in favor of Reactive Resume v3 release.
If you continue to face this issue, please raise a new one and I'll have a look at it as soon as I can.
In the meantime, if you are able to, please consider donating to keep supporting the project: https://www.buymeacoffee.com/AmruthPillai :)
Thank you!


Trying to understand if RASA is a good fit for the FAQBot I would like to develop

Hi, the application my team is developing is a so called FAQBot. According to the questions customers will ask we should be able to  recognize 44 different intents which would map to answers to frequently asked questions. As of now there is a total of around 200 sentences mapping to 44 intents. The default scikit-learn pipeline of RASA_NLU is performing very poorly. At the time of launch I guess I will have around 500 sentences mapping to around 30 intents.
In the meantime I am trying to come up with a pipeline which could perform better than the default one of RASA_NLU. There is already a knowledge base of rules based on keyword matching, that I would like to integrate in the Pipeline. I was thinking of creating a pipeline, for instance, like that:
Original Sentence --> Sentence Tokenizer --> Tokenizer --> Spell Checker --> Replace word synonyms --> Remove unrelevant Parts Of Speech --> Lemmatizer --> Keyword Classifier --> Feature Extractor --> Scikit Intent Classifier --> Intent Found
I would like to try different Feature Extractors and Classifier from the ones RASA uses by default and may not be the best fit for the dataset I have. I feel that a simple TFIDF Vectorizer with Latent Semantic Indexing  would work better, and I also would like to try other classifiers apart from SVM. I would like to have the keyword classifier in the pipeline as well so it can profit from the preprocessing.
There are some features in RASA_NLU that are comfortable for the development of a chatbot ( integration with Rasa Core, a clear way to train and evaluate a model, easy integration with AWS). On the other hand, it seems to be a very opinionated framework which does not make it easy at all to create custom pipelines. Actually, the documentation says that currently the creation of custom components is not supported - do I understand it right, isn't there a simple way to plug a TFIDF classifier with Latent Semantic Index, possibly followed by a Random Tree Forest classifier, in RASA_NLU  ?  Considering that the greatest part of my project in the end is text classification, that is, recognition of intents, I find it hard to justify sticking with a framework that does not offer a clear path to tuning pipelines - as of now, I would rather be inclined to build and tune a text classifier using scikit-learn, maybe integrating some gensim and spacy.
Could you guys give me some opinion on how I could approach this problem and whether RASA_NLU is a good fit for the problem I am trying to solve ?
Thank you in advance

please try out the newly merged tensorflow_embedding pipeline (you will have to clone master branch) - it will likely do better at the task you have in mind.
where in the docs did you read that it's not posssible to have custom components?

Thank you amn41, I tried the tensorflow_embedding and in fact it worked much better. Thank you for the tip. I will also go on and see if I manage to implement a custom component.
The documentation I am referring is here : https://github.com/RasaHQ/rasa_nlu/blob/master/docs/pipeline.rst, it says "Currently you need to rely on the components that are shipped with rasa NLU, but we plan to add the possibility to create your own components in your code. " . I guess a task would be to update the documentation.
Let me rephrase, as I think I may have come out too strong. Regrettably, I find myself in the position of having to decide very soon whether to use RASA_NLU for a FAQ Bot that is supposed to go on production in two months. My gut feeling as of now is that RASA_NLU is a cutting-edge project with great potential I would also like to contribute to, but may not be stable and mature enough to be used for a productive project. Just the fact that I have to checkout the master to get the feature that I need, the undocumented features, the changes in the config format, are kind of putting me off  using RASA_NLU for a project at work, and I am rather keen on building a text classification engine relying on somewhat more "stable" libraries like scikit-learn and/or tensorflow, spacy and/or gensim. On the other end I am planning to use RASA_NLU for a hobby project of mine and offer my help to improve the tool.
Any thought ? Thank you in advance.

great to hear that the new pipeline works much better! I will make an issue regarding the docs adding custom components.
I understand your concerns. The feature you want is in the master branch and not yet in a stable release, although we're working hard to push out v0.12 soon.
this feature notwithstanding, Rasa NLU is quite a stable product, and is run in production by a number of large companies. As you can see there is quite comprehensive test coverage, and the web server API has been stable for a long time. You can rely on a specific version to work well, but since we are pre-1.0 release we do not guarantee backwards compatibility when you upgrade. If you want to keep using the latest models and features you will occasionally have to endure breaking changes, such as the new config format. Trust me when I say that none of these features are developed 'just for fun', we have limited resources and can only focus on building features which significantly enhance the product.

Thank you amn41. Taking into account how quick your feedback I am now more inclined to go on and stick with RASA_NLU, but I will have to think it over for a while.
Regards

@diegoami I am going to close this, but please let me know if it needs re-opened. The Rasa team and community are more than happy to help any way we can!

@diegoami Did you end up using Rasa NLU for your FAQBot? Did you end up writing a custom component, e.g. TFIDF Vectorizer? I am curious about your findings and insights since I am facing the same challenge ATM.

Regrettably I found out that the tensorflow_embedding pipeline tended to overfit and as of now we have moved to a rule-based approach, without RASA_NLU. I think that the hard reality is that I don't have enough data to make machine learning work, no matter what model or framework I choose or how much I bend the pipeline.

@diegoami would you be willing to share your dataset? (privately) - I wonder if increasing the regularisation helps here

C:\Users\Sivasai\AppData\Local\Continuum\anaconda3\lib\site-packages\twisted\internet\defer.py:1386 in _inlineCallbacks
1385            else:
1386                result = g.send(result)
1387        except StopIteration as e:

I am getting this Error In HttpWebResponse.Can you please tell me Where I did Mistake

@karthikhadoop unfortunately without more details it's hard to say. What command are you running?  Which python version? (3.x it looks like)
The best would be if you could create a minimal example which lets someone else reproduce this exact issue.

@amn41 Hey I have a similar problem. I am in the process of developing faq bot with around 250 unique QNAs. I am open to providing the dataset privately to get the best possible pipeline. I am also not sure if rasa is a good fit for faq bots but I am a big advocate of rasa framework in general, So I would really want to make this work. Any help will be greatly appreciated. Thanks.

please don't cross post your issue, we'll keep the discussion in the new issue you created


Error when loading incomplete URL

When you enter to this URL http://localhost/roms.html#/snes/ or similar (ending in /) the node crashes.

Aditionally, when the node instance is up for few hours, the node shows an EMFILE error:
I´m using "forever" module for auto-start the node, but in this moment, the node crashes many more times, and i need to restart the system.

fixed node crashes with ending in /

thanks a lot, the node now doesn´t crash. The EMFILE error when the instance is up I think only occurs in Windows platforms.

step to    initializing romstores，please wait 0-5  ，always waiting。。。


REQUIRE

Closes #39

Code that needs to be fixed in master after this is merged:

Script::fix_call_scope_variables checking for ScriptType::Mission.


Bug 2094202: cloudinit username default

📝 Description
Changing message of clouinit default user from cloud-user to template os name and showing the message only if the field is empty.
🎥 Demo

/lgtm

/hold

Things to do:
a - remove the help hint
b - make the username field required
c - in places the UI assume a username and it's missing, we will show some "Not available" or empty as needed
    ( do not guess it's "cloud-user", if missing )

/lgtm

/override ci/prow/kubevirt-e2e-aws
/lgtm


Implement basicauth and oauth2 connectors as filter connectors

@chanakaudaya  This repository is no longer used, so if this PR is required, please send a new PR to relevant repository in https://github.com/wso2-ballerina organization and close this PR


Move sieves from prime.h to sieve.h

Many functions (e.g., is_prime and factor) will have a normal version and a
sieve accelerated version. To avoid mutual dependencies between header
files, we will put the sieve accelerated versions and the sieve classes in
sieve.h.

Interesting. I like the idea but sieves are still related to primes conceptually. What about moving them to a subdirecotry prime or primes?

Interesting. I like the idea but sieves are still related to primes conceptually. What about moving them to a subdirecotry prime or primes?

I don't think we need a prime folder, because the sieve does not only relate to primes, it also relates to many other algorithms, such as the multiplicative functions. https://codeforces.com/blog/entry/54090


mnn加载剪枝模型错误

剪枝后进行mnn转换，报错
Error for compute convolution shape, need channel = 62, input channel = 64
Error for compute convolution shape, need channel = 62, input channel = 64
Error for compute convolution shape, need channel = 62, input channel = 64
Error for compute convolution shape, need channel = 62, input channel = 64

抱歉，不太熟悉mnn转换过程，但是code 本身应该没有问题


Minor rename follow-up

The build for this is here: https://dev.azure.com/azure-sdk/public/_build/results?buildId=2197145&view=results
minor changelog issue.  It looks like the notifications are not being redirected

/azp run

/azp run

You may need to close and reopen to get it to stop requiring old "cadl - Verify PR"

/azp run


new form-related tables

submission_templates
questions
submission_template_questions (join table)
for orgs building their own forms
rename application to submission (application is a reserved word) https://github.com/rubyforgood/pet-rescue/issues/75

Hi @Thrillberg, is this the same as issue 76?


Make alternate api for testing and stuff

What is "stuff"? Could you be more specific please? Could you please describe what this API is needed for etc.? Cheers

Done @mariobehling :smile:

#58 #46


$-ßzÉ is considered valid by Prism but not by parse.y

I wrote a very naive fuzzer to search for code for which parse.y and Prism differ in whether it's valid Ruby code or not (SyntaxError):
puts RUBY_DESCRIPTION
puts RbConfig.ruby

N = Integer(ARGV[0])

require 'prism'

chars = (0...256).map { it.chr(Encoding::UTF_8) }

length = 5

N.times do
  code = length.times.map { chars.sample }.join
  p code

  parse_y_error = false
  begin
    r = RubyVM::AbstractSyntaxTree.parse(code)
    raise unless r
  rescue SyntaxError
    parse_y_error = true
  end

  r = Prism.parse(code)
  raise unless r
  prism_error = !r.success?

  unless prism_error == parse_y_error
    if prism_error
      raise "Prism raised SyntaxError for #{code.inspect} but parse.y didn't"
    else
      raise "parse.y raised SyntaxError for #{code.inspect} but Prism didn't"
    end
  end
end

Running this on ruby-head a couple times I got these failures:
"$-ÅÜß"
fuzz.rb:32:in 'block in <main>': parse.y raised for "$-ÅÜß" but Prism didn't (RuntimeError)
...
"$-Ëc\u0092"
fuzz.rb:32:in 'block in <main>': parse.y raised for "$-Ëc\u0092" but Prism didn't (RuntimeError)
...
"$-ßzÉ"
fuzz.rb:32:in 'block in <main>': parse.y raised for "$-ßzÉ" but Prism didn't (RuntimeError)

which all seem the same case.
And some more which might be related:
fuzz.rb:32:in 'block in <main>': parse.y raised SyntaxError for "y$-öc" but Prism didn't (RuntimeError)
fuzz.rb:32:in 'block in <main>': parse.y raised SyntaxError for "c$-ía" but Prism didn't (RuntimeError)
fuzz.rb:32:in 'block in <main>': parse.y raised SyntaxError for "Õ$-Aö" but Prism didn't (RuntimeError)
fuzz.rb:32:in 'block in <main>': parse.y raised SyntaxError for "±$-å\u008F" but Prism didn't (RuntimeError)

This appeared to be entirely because I thought $-x could have multiple characters instead of just 1. The only other errors I could find using your script had to do with parsing regular expressions.

The only other errors I could find using your script had to do with parsing regular expressions.

Should that be fixed as well or is it an intentional difference?
From the above, removing the $- we are left with:
parse.y raised SyntaxError for "/é[Â/" but Prism didn't
parse.y raised SyntaxError for "-C\t*É" but Prism didn't
parse.y raised SyntaxError for "~ì\v*Å" but Prism didn't
parse.y raised SyntaxError for "~_\f*÷" but Prism didn't
parse.y raised SyntaxError for "\u0081\rR?:" but Prism didn't
parse.y raised SyntaxError for "-\u0088\v*Ñ" but Prism didn't
parse.y raised SyntaxError for "+\u008D\v*f" but Prism didn't
parse.y raised SyntaxError for "/[°Ý/" but Prism didn't
parse.y raised SyntaxError for "¿Ú>?\\" but Prism didn't
parse.y raised SyntaxError for "ÈQ|?\\" but Prism didn't

I think only 2 of them are related to regexps.
Another run with the latest fixes gave:
$ ruby fuzz.rb 10000000
ruby 3.4.0dev (2024-10-03T17:43:11Z master 568511f393) +PRISM [x86_64-linux]
/home/eregon/.rubies/ruby-dev/bin/ruby
parse.y raised SyntaxError for "Z½*?\\" but Prism didn't
parse.y raised SyntaxError for "ò«~?\\" but Prism didn't
parse.y raised SyntaxError for "+r\r*k" but Prism didn't
parse.y raised SyntaxError for "\u0090Å~?\\" but Prism didn't
parse.y raised SyntaxError for "~Ù\r*\u0084" but Prism didn't
parse.y raised SyntaxError for "+Ì *É" but Prism didn't
parse.y raised SyntaxError for "-æ\t*\u0089" but Prism didn't
parse.y raised SyntaxError for "-\u0096\f*H" but Prism didn't
parse.y raised SyntaxError for "/[u¹/" but Prism didn't
parse.y raised SyntaxError for "o\u0094-?\\" but Prism didn't
parse.y raised SyntaxError for "E?F!:" but Prism didn't
parse.y raised SyntaxError for "âÆ=?\\" but Prism didn't
parse.y raised SyntaxError for "/¼\u0018[/" but Prism didn't
parse.y raised SyntaxError for "/[O/x" but Prism didn't
parse.y raised SyntaxError for "+\u009D\r*i" but Prism didn't
parse.y raised SyntaxError for "/\\\u0085)/" but Prism didn't

Should I open new issue(s) for these ones?
I'm not sure how to group except regexp vs not

Hmm, I switched it from RubyVM::AbstractSyntaxTree.parse to RubyVM::InstructionSequence.compile when I did this. I think that got rid of the others.

I wonder if it's to do with the escaping? All of the examples you have that aren't regexp include escaping.
As for the others — yeah there are some things we won't detect as errors because we rely on the various implementations to give us regexp errors. I want to enhance this eventually, but it's going to take some time.


Cow: Watch vernonleeknox.com

Cow requests the watch of the watch_keyword vernonleeknox\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

vernonleeknox\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Jeff Schaller in Charcoal HQ


Add the Zebra Puzzle as a practice exercise.

Tests, stub code, example implementation.

Thanks! @BNAndras is our resident Racket maintainer and they'll review your PR.


Not able to login in PCF Dev.  Server error, status code: 403, error code: 0,

PCF Dev has reserved 3 GB out of 7 GB total system memory.
Bringing machine 'default' up with 'virtualbox' provider...
==> default: Checking if box 'pcfdev/pcfdev' is up to date...
==> default: Clearing any previously set forwarded ports...
==> default: Clearing any previously set network interfaces...
==> default: Preparing network interfaces based on configuration...
default: Adapter 1: nat
default: Adapter 2: hostonly
==> default: Forwarding ports...
default: 22 (guest) => 2222 (host) (adapter 1)
==> default: Running 'pre-boot' VM customizations...
==> default: Booting VM...
==> default: Waiting for machine to boot. This may take a few minutes...
default: SSH address: <IP_ADDRESS>:2222
default: SSH username: vagrant
default: SSH auth method: private key
default: Warning: Remote connection disconnect. Retrying...
default: Warning: Remote connection disconnect. Retrying...
==> default: Machine booted and ready!
==> default: Checking for guest additions in VM...
==> default: Configuring and enabling network interfaces...
==> default: Machine already provisioned. Run vagrant provision or use the --provision
==> default: flag to force provisioning. Provisioners marked to run always will still run.
==> default: Running provisioner: shell...
default: Running: inline script
==> default: stdin: is not a tty
==> default: Waiting for services to start...
==> default: 0 out of 48 running
==> default: 0 out of 48 running
==> default: 0 out of 48 running
==> default: 0 out of 48 running
==> default: 0 out of 48 running
==> default: 38 out of 48 running
==> default: 48 out of 48 running
The SSH command responded with a non-zero exit status. Vagrant
assumes that this means the command failed. The output for this command
should be in the log above. Please read the output to determine what
went wrong.
PS C:\00PCE5COB\PCF\pcfdev-v0.15.0> cf api api.local.pcfdev.io --skip-ssl-validation
Setting api endpoint to api.local.pcfdev.io...
FAILED
Server error, status code: 403, error code: 0, message:

Hi @periz,
Looks like the VM failed to start successfully:
The SSH command responded with a non-zero exit status. Vagrant
assumes that this means the command failed. The output for this command
should be in the log above. Please read the output to determine what
went wrong.

Can you vagrant ssh into the machine and provide us the contents of /var/pcfdev/run.log?
We recommend running PCF Dev with at least 4 GB of free memory. Can you tear down your VM, free up 4 GB of memory, and run the following before starting it again:
>> $env:VM_MEMORY = 4096

Other questions:

Do you require a proxy to access the internet?
Are you attempting to start PCF Dev without an internet connection?
Does api.local.pcfdev.io resolve to <IP_ADDRESS> for you?

I resolved this issue. It is a issue with the DNS. I run PCF Dev ofline.

(Resolved)

hi @sclevine,
If i run behind corporate proxy still i am getting the error. Help me to resolve it.


Develop nuisance components of linear model

Codecov Report

Merging #188 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #188   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files          10     10
  Lines        2189   2202   +13
=====================================
+ Hits         2189   2202   +13

Impacted Files
Coverage Δ

lyman/signals.py
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db1566e...b1292dd. Read the comment docs.


Update index.html

Remove "maximum-scale=1", I noticed it was flagged by google lighthouse.
https://www.a11yproject.com/posts/never-use-maximum-scale/
This should be a good change unless I am overlooking a specific need for that.

I'm wondering if there are any visible changes on mobile when we remove that 🤔


Side menu in Mobile App not retracking after selecting a page to navigate to

Overview
When selecting a page from the side menu in the Mobile App, the page will load in the background but the menu will stay open until you click onto the page behind. Intuitively the menu should retract after selecting a page to navigate to.
References and additional details

Open ShapeShift Mobile App.
Select the menu option at the top left of the screen and notice the menu pop out
Select a page to navigate to, ie. Transaction History
Notice the Transaction History load in the background but the menu is still displayed

Acceptance Criteria
Ideally the menu will retract after selecting a page to navigate to
Need By Date
No response
Screenshots/Mockups
No response
Ownership

[X] If my bounty needs engineering or needs product I have added the respective labels on the right
[X] As the sponsor of this bounty I will review the changes in a preview environment (ops/product) or review the PR (engineering)

Estimated effort
No response
Sponsor / Stakeholder
No response
Bounty Hunters

Join our discord
Include an expected timeline for you to complete work in the work plan when you apply for this bounty!
Please refer to this link for some basic info
Please do not start work on this issue until you are approved in Gitcoin.

@DiggyDiggy2 - just wanted to make sure you saw this one as well

closing as fixed


parseContent() in BlockProcessor does not yield output in sidebar

Hi folks,
maybe I'm doing something wrong or didn't comprehend the API so far. I am about to implement a BlockProcessor (Kotlin code) that is supposed to just append some blocks below a parent sidebar block. What I'm doing is:
@Name("my_block")
@Contexts(Contexts.SIDEBAR)
@ContentModel(ContentModel.COMPOUND)
class MyBlockProcessor : BlockProcessor() {
    override fun process(
        parent: StructuralNode?, reader: Reader, attributes: Map<String?, Any?>?
    ): Any {
        val block = createBlock(
            parent, "sidebar", mapOf(
                Options.ATTRIBUTES to attributes
            )
        )
        parseContent(
            block, listOf(
                "[newcontent]",
                "This is new content2",
                "",
                "[newcontent]",
                "This is also new content2"
            )
        )

        return block
    }
}

However, [newcontent] blocks are not appended in the output document (neither PDF nor HTML). Can anyone tell me what I did wrong?
I printed the children of block before and after parseContent, and it actually creates two children on the heap. If I am doing the same parsing for parent, content is actually added to the parent of block. But I'd like to see it rendered as children to block. Eventually, my plan is to just pass reader.readLines() - of course, that doesn't work either.
Your help is very much appreciated!
-David

Nevermind, I found out I have to provide ContentModel.KEY to ContentModel.COMPOUND in the config of the block. First I tried to use config as the parameter to the constructor of BlockProcessor, but that didn't work out.
So, the running example is:
@Name("my_block")
@Contexts(Contexts.SIDEBAR)
@ContentModel(ContentModel.COMPOUND)
class MyBlockProcessor : BlockProcessor() {
    override fun process(
        parent: StructuralNode?, reader: Reader, attributes: Map<String?, Any?>?
    ): Any {
        val block = createBlock(
            parent, "sidebar", mapOf(
                Options.ATTRIBUTES to attributes,
                ContentModel.KEY to ContentModel.COMPOUND
            )
        )
        parseContent(
            block, listOf(
                "[newcontent]",
                "This is new content2",
                "",
                "[newcontent]",
                "This is also new content2"
            )
        )

        return block
    }
}


Python 3.6 pip failing to install when given a target directory

[XX] are reporting a bug others will be able to reproduce and not asking a question. If you're not sure or want to ask a question do so on our Discourse: https://discourse.brew.sh
[__] ran a brew command and reproduced the problem with multiple formulae? If it's a problem with a single, official formula (not cask) please file this issue at Homebrew/homebrew-core: https://github.com/Homebrew/homebrew-core/issues/new. If it's a brew cask problem please file this issue at https://github.com/caskroom/homebrew-cask/issues/new. If it's a tap (e.g. Homebrew/homebrew-php) problem please file this issue at the tap.
[XX] ran brew update and can still reproduce the problem?
[XX] ran brew doctor, fixed all issues and can still reproduce the problem?
[XX] ran brew config and brew doctor and included their output with your issue?

To help us debug your issue please explain:

What you were trying to do (and why)

From the brew-installed python3 package, I was trying to make use of the pip3 command to install a python package to a targeted directory. Command was:
pip3 install requests -t $(pwd)

What happened (include command output)

Collecting requests
  Using cached requests-2.18.4-py2.py3-none-any.whl
Collecting idna<2.7,>=2.5 (from requests)
  Using cached idna-2.6-py2.py3-none-any.whl
Collecting certifi>=2017.4.17 (from requests)
  Using cached certifi-2018.1.18-py2.py3-none-any.whl
Collecting urllib3<1.23,>=1.21.1 (from requests)
  Using cached urllib3-1.22-py2.py3-none-any.whl
Collecting chardet<3.1.0,>=3.0.2 (from requests)
  Using cached chardet-3.0.4-py2.py3-none-any.whl
Installing collected packages: idna, certifi, urllib3, chardet, requests
Exception:
Traceback (most recent call last):
  File "/usr/local/lib/python3.6/site-packages/pip/basecommand.py", line 215, in main
    status = self.run(options, args)
  File "/usr/local/lib/python3.6/site-packages/pip/commands/install.py", line 342, in run
    prefix=options.prefix_path,
  File "/usr/local/lib/python3.6/site-packages/pip/req/req_set.py", line 784, in install
    **kwargs
  File "/usr/local/lib/python3.6/site-packages/pip/req/req_install.py", line 851, in install
    self.move_wheel_files(self.source_dir, root=root, prefix=prefix)
  File "/usr/local/lib/python3.6/site-packages/pip/req/req_install.py", line 1064, in move_wheel_files
    isolated=self.isolated,
  File "/usr/local/lib/python3.6/site-packages/pip/wheel.py", line 247, in move_wheel_files
    prefix=prefix,
  File "/usr/local/lib/python3.6/site-packages/pip/locations.py", line 153, in distutils_scheme
    i.finalize_options()
  File "/usr/local/Cellar/python/3.6.4_3/Frameworks/Python.framework/Versions/3.6/lib/python3.6/distutils/command/install.py", line 248, in finalize_options
   "must supply either home or prefix/exec-prefix -- not both")
distutils.errors.DistutilsOptionError: must supply either home or prefix/exec-prefix -- not both

Note, this error is fully described in the last line: both home and prefix/exec-prefix were specified in this install. Now, I would identify that the issue is not in the distutils python package, but I believe it is in pip itself.
The version of pip is up to date.
pip 9.0.1 from /usr/local/lib/python3.6/site-packages (python 3.6)

The same version of pip was installed on the Linux box I checked, where the command succeeded (see the next section). Now, this could be an inherent problem with pip or perhaps a problem with how python3 + pip is configured for the brew install. I suspected if I reported this directly on the pip issues site, https://github.com/pypa/pip/issues, they would immediately want further information on the build and install processes used. Since I don't know those details, it would require information from brew support anyway.

What you expected to happen

I expected pip to succeed. For contrast, I tested the same command on Linux and got this:
Collecting requests
  Downloading requests-2.18.4-py2.py3-none-any.whl (88kB)
    100% |████████████████████████████████| 92kB 1.7MB/s
Collecting chardet<3.1.0,>=3.0.2 (from requests)
  Downloading chardet-3.0.4-py2.py3-none-any.whl (133kB)
    100% |████████████████████████████████| 143kB 4.2MB/s
Collecting urllib3<1.23,>=1.21.1 (from requests)
  Downloading urllib3-1.22-py2.py3-none-any.whl (132kB)
    100% |████████████████████████████████| 133kB 4.1MB/s
Collecting idna<2.7,>=2.5 (from requests)
  Downloading idna-2.6-py2.py3-none-any.whl (56kB)
    100% |████████████████████████████████| 61kB 5.4MB/s
Collecting certifi>=2017.4.17 (from requests)
  Downloading certifi-2018.1.18-py2.py3-none-any.whl (151kB)
    100% |████████████████████████████████| 153kB 4.5MB/s
Installing collected packages: chardet, urllib3, idna, certifi, requests
Successfully installed certifi-2018.1.18 chardet-3.0.4 idna-2.6 requests-2.18.4 urllib3-1.22

Step-by-step reproduction instructions (by running brew commands)

pip3 install requests -t $(pwd)

brew config output:

ORIGIN: https://github.com/Homebrew/brew
HEAD: 924c4af3de99f1f7dfef3acdcb03de2bcc9af0ee
Last commit: 29 hours ago
Core tap ORIGIN: https://github.com/Homebrew/homebrew-core
Core tap HEAD: fba87cb5f5c7e926ce68434a40b5ab4ed5259cec
Core tap last commit: 2 hours ago
HOMEBREW_PREFIX: /usr/local
HOMEBREW_RUBY_WARNINGS: -W0
CPU: octa-core 64-bit haswell
Homebrew Ruby: 2.3.3 => /usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.3.3/bin/ruby
Clang: 9.0 build 900
Git: 2.14.3 => /Applications/Xcode.app/Contents/Developer/usr/bin/git
Curl: 7.54.0 => /usr/bin/curl
Perl: /usr/bin/perl
Python: /usr/local/bin/python => /usr/local/Cellar/python/3.6.4_3/Frameworks/Python.framework/Versions/3.6/bin/python3.6
Ruby: /usr/local/bin/ruby => /usr/local/Cellar/ruby/2.5.0/bin/ruby
Java: 1.8.0_162, 1.8.0_151
macOS: 10.12.6-x86_64
Xcode: 9.2
CLT: <IP_ADDRESS>.1.1510905681
X11: N/A
MacPorts/Fink: /opt/local/bin/port

brew doctor output

Please note that these warnings are just used to help the Homebrew maintainers
with debugging if you file an issue. If everything you use Homebrew for is
working fine: please don't worry or file an issue; just ignore this. Thanks!

Warning: Putting non-prefixed coreutils in your path can cause gmp builds to fail.

Warning: You have MacPorts or Fink installed:
  /opt/local/bin/port

This can cause trouble. You don't have to uninstall them, but you may want to
temporarily move them out of the way, e.g.

  sudo mv /opt/local ~/macports

Warning: Homebrew's sbin was not found in your PATH but you have installed
formulae that put executables in /usr/local/sbin.
Consider setting the PATH for example like so
  echo 'export PATH="/usr/local/sbin:$PATH"' >> ~/.bash_profile

This is limitation of Python's distutils.
You need to create venv.

If it's a problem with a single, official formula (not cask) please file this issue at Homebrew/homebrew-core: https://github.com/Homebrew/homebrew-core/issues/new.

So this is filed in the wrong repository.
Also, note this is a duplicate of https://github.com/Homebrew/brew/issues/837, which we're not planning on attempting to fix, but would we'd review a PR if someone comes up with a fix.


Feat: Implemented splash screen

this PR is under the tagline simple things are the best most of times ~ quotes by @lorenzovngl

preview
https://github.com/lorenzovngl/FoodExpirationDates/assets/55085697/d4d37dc8-d459-4635-960f-1b43212f8613

Great work! Thank you!


Migrate main tests from ArmeriaServerCall to server tests.

ArmeriaServerCallTest are very hard to maintain and reason about since they require running many different callbacks in precise order. While the speed of unit tests is nice, these aren't very useful, so we migrate them to normal client/server tests.
Also defines a separate stub interface for fine-grained unit testing. The copy of the upstream one will still be used for interopability tests, but this should be easier to maintain for unit tests. I don't like how in the upstream ones, many different cases are handled by request parameters which are somewhat opaque.
Also follows AbstractThriftOverHttpTest pattern by using the upstream client to test server behavior and interopability in one go. Uses grpc-okhttp instead of grpc-netty to prevent netty version conflicts so this should be reasonably stable unlike the netty interop tests (I'll probably migrate the ignored integration test at some point to okhttp).
Also allows non-qualified content types for proto since many clients (like okhttp, grpc-web) don't specify +proto (hopefully grpc doesn't end up in content-type hell like thrift did...).

Thanks, @anuraaga


Feature request: Add way to identify FFiConversation

Is your feature request related to a problem?
It would be nice to have a way to identify a conversation. I'd say "peer address" though in a world with group chat, that makes less sense. Maybe topic info?
https://github.com/xmtp/libxmtp-swift/blob/main/Sources/LibXMTP/xmtpv3.swift#L399C36-L463
Describe the solution to the problem
No response
Describe the uses cases for the feature
No response
Additional details
No response

Great call out. We have an internal identifier convo_id (not to be confused with V2 conversation IDs) that feels like it would do what you want. It's just the sorted member list right now, but it's treated as an opaque string in libxmtp and might be produced in different ways for things like group conversations.

Exposed convo_id in https://github.com/xmtp/libxmtp/pull/215


[SPARK-40765][SQL] Optimize redundant fs operation in CommandUtils#calculateSingleLocationSize#getPathSize method

What changes were proposed in this pull request?
This pr change the 2nd input parameter from Path to FileStatus to avoid redundant fs.getFileStatus(path) in each recursive call.
Why are the changes needed?
Reduce one dfs operation in each recursive call.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Pass Github Actions

cc @HyukjinKwon @zhengruifeng

Yes, one fs.getFileStatus(path) operation is saved for each recursive call

https://github.com/apache/spark/blob/0dd78341e64a7e146413156834448707f16bba83/sql/core/src/main/scala/org/apache/spark/sql/execution/command/CommandUtils.scala#L116-L132
Line 122 It is a recursive call. The original logic is pass in status.getPath, and then execute val fileStatus = fs.getFileStatus(status.getPath) (Line 117).
After change, the recursive call reuse the incoming status.

But the caller had to add a new call to get the status. It seems to just be moved around. I don't see the same status retrieved twice in the original, so wondering how we can actually avoid a call here

I don't see the same status retrieved twice in the original

Before recursion, there is an exist status instance,  then the recursive call will call getStatus for the exist status.getPath,  Isn't this an unnecessary call?
If there is no recursion, there is no saving.

I see so it saves one call, not one call per recursion?

Every time a recursive call occurs, it will be saved once (the initial call is not counted, and the initial call is not saved)

The saved times are related to the directory level and the number of directories in each level

I may have to think about it more, but still don't see how this saves much as you have added a new call to getFileStatus too. Right? how can it save all the calls but one?

@srowen Is the above example helpful?

From the example:

fs.getFileStatus(Path(/a)) not saved, but no additional calls are added
fs.getFileStatus(Path(/a/b)),fs.getFileStatus(Path(/a/b/c)) and fs.getFileStatus(Path(/a/b/c/d.txt)) saved

OK, I'm still not seeing how they are saved, because in the recursive call, getFileStatus is called. After, you are still calling this on /a/b, /a/b/c, etc. Right? That is line 138

Is it because of code folding? After change, only getFileStatus will be made for /a

Oh yes I think that's it. The other call is not in the same recursive loop. Ok I get it

Oh yes I think that's it. The other call is not in the same recursive loop. Ok I get it

Yes, and I finally know why you had doubts before :)

Merged to master.

Thanks @srowen @HyukjinKwon and @zhengruifeng

I need to know more about the rules for defining error-class, so close first

Ignore the previous


DFS in java

Issue Id you have worked upon -
#142
NOTE -
Please consider this PR as a submission towards Hacktoberfest 2021 and add the hacktoberfest-accepted label to it.

@aadityasinha-dotcom we appreciate your patience, a repo manager will look into your request shortly :)

Hello @aadityasinha-dotcom, we have reviewed your code and noticed that the code has been copied directly from GeeksForGeeks , and submitted with minor tweaks. Plagiarism is highly condemned, and we request you to write code yourself, and submit another pull request.
Looking forward to your non plagiarized contribution :)

Sorry, I will make sure that next time :-(. This is my first time contributing. But can you please remove the invalid label I will make a valid PR.


Separate texteditor theme <-> the editor program

Would it be possible to be able to customize the texteditor (where you type your code) and the editor (vscode) separately? E.g. the default theme for the texteditor, and the darker theme for the rest of vscode. An example from my Jetbrains IDE:

One and two are both different themes, but combined.

There is an open issue on vscode repository but atm is not possible


net.Encrypt() uses the wrong key size for MAC

net.Encrypt() uses the AES key size when generating the MAC key. The decryptV1() function, however, uses the right key size. This is currently not causing any bugs because the key sizes have been set as the same, but would cause decryption to fail if the key sizes ever differed.

See an easy fix in #271


recipes-devtools/dediprog-flasher: add recipe

Adds the DediProgSW/SF100Linux utility for cases where dpcmd can provide reliable flashing method, alternative to flashrom.
Addresses https://github.com/3mdeb/meta-rte/issues/64

The problem im encountering is there seem to be problems with the libusb library. OpenEmbedded has 2 related recipes:

libusb - libusb-0.1 compatibility layer for libusb1
libusb1 - A cross-platform library to access USB devices.

The DediProgSW/SF100Linux includes <libusb-1.0/libusb.h> and requires libusb-1.0 as a dependancy.
Yet adding either of them to DEPENDS puts out an error:
ERROR: dediprog-flasher-1.0+AUTOINC+e691f2d432-r0 do_compile: oe_runmake failed
ERROR: dediprog-flasher-1.0+AUTOINC+e691f2d432-r0 do_compile: Execution of '/build/tmp/work/armv7vet2hf-neon-rte-linux-gnueabi/dediprog-flasher/1.0+AUTOINC+e691f2d432-r0/temp/run.do_compile.
312' failed with exit code 1:
  CC  dpcmd.o
  CC  usbdriver.o
  CC  FlashCommand.o
  CC  SerialFlash.o
In file included from usbdriver.c:1:
usbdriver.h:6:10: fatal error: libusb-1.0/libusb.h: No such file or directory
    6 | #include <libusb-1.0/libusb.h>
      |          ^~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make: *** [Makefile:43: usbdriver.o] Error 1
make: *** Waiting for unfinished jobs....
In file included from dpcmd.c:7:
usbdriver.h:6:10: fatal error: libusb-1.0/libusb.h: No such file or directory
    6 | #include <libusb-1.0/libusb.h>
      |          ^~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make: *** [Makefile:43: dpcmd.o] Error 1
In file included from FlashCommand.c:6:
usbdriver.h:6:10: fatal error: libusb-1.0/libusb.h: No such file or directory
    6 | #include <libusb-1.0/libusb.h>
      |          ^~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make: *** [Makefile:43: FlashCommand.o] Error 1
In file included from SerialFlash.c:5:
usbdriver.h:6:10: fatal error: libusb-1.0/libusb.h: No such file or directory
    6 | #include <libusb-1.0/libusb.h>
      |          ^~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make: *** [Makefile:43: SerialFlash.o] Error 1
WARNING: exit code 1 from a shell command.

ERROR: Logfile of failure stored in: /build/tmp/work/armv7vet2hf-neon-rte-linux-gnueabi/dediprog-flasher/1.0+AUTOINC+e691f2d432-r0/temp/log.do_compile.312
Log data follows:
| DEBUG: Executing shell function do_compile
| NOTE: make -j 16
|   CC  dpcmd.o
|   CC  usbdriver.o
|   CC  FlashCommand.o
|   CC  SerialFlash.o
| In file included from usbdriver.c:1:
| usbdriver.h:6:10: fatal error: libusb-1.0/libusb.h: No such file or directory
|     6 | #include <libusb-1.0/libusb.h>
|       |          ^~~~~~~~~~~~~~~~~~~~~
| compilation terminated.
| make: *** [Makefile:43: usbdriver.o] Error 1
| make: *** Waiting for unfinished jobs....
| In file included from dpcmd.c:7:
| usbdriver.h:6:10: fatal error: libusb-1.0/libusb.h: No such file or directory
|     6 | #include <libusb-1.0/libusb.h>
|       |          ^~~~~~~~~~~~~~~~~~~~~
| compilation terminated.
| make: *** [Makefile:43: dpcmd.o] Error 1
| In file included from FlashCommand.c:6:
| usbdriver.h:6:10: fatal error: libusb-1.0/libusb.h: No such file or directory
|     6 | #include <libusb-1.0/libusb.h>
|       |          ^~~~~~~~~~~~~~~~~~~~~
| compilation terminated.
| make: *** [Makefile:43: FlashCommand.o] Error 1
| In file included from SerialFlash.c:5:
| usbdriver.h:6:10: fatal error: libusb-1.0/libusb.h: No such file or directory
|     6 | #include <libusb-1.0/libusb.h>
|       |          ^~~~~~~~~~~~~~~~~~~~~
| compilation terminated.
| make: *** [Makefile:43: SerialFlash.o] Error 1
| ERROR: oe_runmake failed
| WARNING: exit code 1 from a shell command.
| ERROR: Execution of '/build/tmp/work/armv7vet2hf-neon-rte-linux-gnueabi/dediprog-flasher/1.0+AUTOINC+e691f2d432-r0/temp/run.do_compile.312' failed with exit code 1:
|   CC  dpcmd.o
|   CC  usbdriver.o
|   CC  FlashCommand.o
|   CC  SerialFlash.o
| In file included from usbdriver.c:1:
| usbdriver.h:6:10: fatal error: libusb-1.0/libusb.h: No such file or directory
|     6 | #include <libusb-1.0/libusb.h>
|       |          ^~~~~~~~~~~~~~~~~~~~~
| compilation terminated.
| make: *** [Makefile:43: usbdriver.o] Error 1
| make: *** Waiting for unfinished jobs....
| In file included from dpcmd.c:7:
| usbdriver.h:6:10: fatal error: libusb-1.0/libusb.h: No such file or directory
|     6 | #include <libusb-1.0/libusb.h>
|       |          ^~~~~~~~~~~~~~~~~~~~~
| compilation terminated.
| make: *** [Makefile:43: dpcmd.o] Error 1
| In file included from FlashCommand.c:6:
| usbdriver.h:6:10: fatal error: libusb-1.0/libusb.h: No such file or directory
|     6 | #include <libusb-1.0/libusb.h>
|       |          ^~~~~~~~~~~~~~~~~~~~~
| compilation terminated.
| make: *** [Makefile:43: FlashCommand.o] Error 1
| In file included from SerialFlash.c:5:
| usbdriver.h:6:10: fatal error: libusb-1.0/libusb.h: No such file or directory
|     6 | #include <libusb-1.0/libusb.h>
|       |          ^~~~~~~~~~~~~~~~~~~~~
| compilation terminated.
| make: *** [Makefile:43: SerialFlash.o] Error 1
| WARNING: exit code 1 from a shell command.
|
ERROR: Task (/repo/recipes-devtools/dediprog-flasher/dediprog-flasher.bb:do_compile) failed with exit code '1'

Inside the bitbake dediprog-flasher.bb -c devshell i can see the dpkg --list output and files available at $PKG_CONFIG_PATH
$ dpkg --list | grep usb
$

$ echo $PKG_CONFIG_PATH
/build/tmp/work/armv7vet2hf-neon-rte-linux-gnuethe abi/dediprog-flasher/1.0+AUTOINC+e691f2d432-r0/recipe-sysroot/usr/lib/pkgconfig:
/build/tmp/work/armv7vet2hf-neon-rte-linux-gnueabi/dediprog-flasher/1.0+AUTOINC+e691f2d432-r0/recipe-sysroot/usr/share/pkgconfig
$ ls /build/tmp/work/armv7vet2hf-neon-rte-linux-gnueabi/dediprog-flasher/1.0+AUTOINC+e691f2d432-r0/recipe-sysroot/usr/share/pkgconfig| grep usb
$ ls /build/tmp/work/armv7vet2hf-neon-rte-linux-gnueabi/dediprog-flasher/1.0+AUTOINC+e691f2d432-r0/recipe-sysroot/usr/lib/pkgconfig | grep usb
libusb-1.0.pc
libusb.pc
$ cat libusb.pc
prefix=/usr
exec_prefix=/usr
libdir=/lib
includedir=/usr/include

emulated=1
emulated_by=libusb-1.0

Name: libusb
Description: USB access library (libusb-1.0 compat wrapper)
Version: 0.1.12
Requires.private: libusb-1.0
Libs: -L${libdir} -lusb
Cflags: -I${includedir}
$ cat libusb-1.0.pc
prefix=/usr
exec_prefix=/usr
libdir=/lib
includedir=/usr/include

Name: libusb-1.0
Description: C API for USB device access from Linux, Mac OS X, Windows, OpenBSD/NetBSD and Solaris userspace
Version: 1.0.22
Libs: -L${libdir} -lusb-1.0
Libs.private: -ludev  -pthread
Cflags: -I${includedir}/libusb-1.0

@tym2k1 I suggest to include following patch in the build:
Author: Maciej Pijanowski<EMAIL_ADDRESS>Date:   Fri Jul 5 16:39:13 2024 +0200

    Makefile: allow overriding CC

    Signed-off-by: Maciej Pijanowski<EMAIL_ADDRESS>
diff --git a/Makefile b/Makefile
index 139e5c0c3c3c..226303a6921e 100644
--- a/Makefile
+++ b/Makefile
@@ -12,7 +12,7 @@ endif
 endif

 PROGRAM = dpcmd
-CC      = gcc
+CC     ?= gcc
 PREFIX ?= /usr/local

 PKG_CONFIG ?= pkg-config

I've added the patch and addressed all threads but now the build fails at do_install. There seems to be some problem with the strip command and how it parses the built dpcmd binary.
ERROR: dediprog-flasher-1.0+AUTOINC+e691f2d432-r0 do_install: oe_runmake failed
ERROR: dediprog-flasher-1.0+AUTOINC+e691f2d432-r0 do_install: Execution of '/build/tmp/work/armv7vet2hf-
neon-rte-linux-gnueabi/dediprog-flasher/1.0+AUTOINC+e691f2d432-r0/temp/run.do_install.2499' failed with
exit code 1:
install: creating directory '/build/tmp/work/armv7vet2hf-neon-rte-linux-gnueabi/dediprog-flasher/1.0+AUTOINC+e691f2d432-r0/image/usr'
install: creating directory '/build/tmp/work/armv7vet2hf-neon-rte-linux-gnueabi/dediprog-flasher/1.0+AUTOINC+e691f2d432-r0/image/usr/bin'
install: creating directory '/build/tmp/work/armv7vet2hf-neon-rte-linux-gnueabi/dediprog-flasher/1.0+AUTOINC+e691f2d432-r0/image/usr/share'
install: creating directory '/build/tmp/work/armv7vet2hf-neon-rte-linux-gnueabi/dediprog-flasher/1.0+AUTOINC+e691f2d432-r0/image/usr/share/DediProg'
install: 'dpcmd' -> '/build/tmp/work/armv7vet2hf-neon-rte-linux-gnueabi/dediprog-flasher/1.0+AUTOINC+e691f2d432-r0/image/usr/bin/dpcmd'
strip: Unable to recognise the format of the input file `/build/tmp/work/armv7vet2hf-neon-rte-linux-gnueabi/dediprog-flasher/1.0+AUTOINC+e691f2d432-r0/image/usr/bin/dpcmd'
make: *** [Makefile:61: install] Error 1
WARNING: exit code 1 from a shell command.

Working on it

@tym2k1 Well, the strip is also part of the toolchain.
Check if yocto provides path to strip from toolchain via env variable and modify the Makefile so it can be overriden as well.

As I stated in the patch I think it's best to leave stripping of binaries to built-in bitbake functionalities. As stated in https://github.com/3mdeb/meta-rte/issues/64#issuecomment-2210830251 I'll try to upstream this recipe when we'll tackle https://github.com/3mdeb/meta-rte/issues/67 as current version has reached EOL and we need to ensure it builds for currently supported Yocto versions.

The dpcmd utility also always checks for the ChipInfoDb.dedicfg at relative path ../share/Dediprog/ChipInfoDb.dedicfg. Currently it's placed at /usr/bin/dpcmd and the ChipInfoDb.dedicfg is placed at /usr/share/DediProg/ChipInfoDb.dedicfg so everything works correctly. @macpijan shall we leave it this way or is more work needed to add more robustness to the way the script handles ChipInfoDb.dedicfg ?


Add warning about language preferences.

tags and information is get in user language:
https://store.steampowered.com/account/languagepreferences

This should be only a message informing that everything will be stored in english.


[Feature][Manager] Support create MySQL databases and tables

Description
To support the creation of MySQL databases and tables, you can refer to the class HiveResourceOperator.
Use case
No response
Are you willing to submit PR?

[ ] Yes, I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

can I task this task？

can I task this task？

Of course, you can, thanks.


Add support to build again only failed builds

It may happen that build will fail in COPR for many reasons e.g. network issue, chroot misconfiguration, mirror repo issue.
In this case, it would be better to try to rebuild failed one instead of running all builds again.
This is a great example click here please :crying_cat_face:

Yes, that would make sense.
So to make it clear, we want to have support for \packit rebuild-failed comment that will retrigger the failed builds.
From the code perspective:

[ ] new comment command
[ ] new handler for this job, make sure that:

whitelisting works well
testing-farm is correctly triggered after the build
PR checks are set correctly (the failed updated and the successful not touched)

Can we reuse the SRPM that was already created?
Can we have sem for tests? (\packit retest-failed)

* Can we reuse the SRPM that was already created?

We have to, because then it's not a rebuild any more.

* Can we have same for tests? (`\packit retest-failed`)

+1

Related to #970.

Let's take a look on the Copr's API if we can re-trigger the build without a need to do the SRPM build again or storing it.

Since #1213 is implemented, we can now start working on this.
We'll start with #1204 and can take a look into this later. Here, we can either implement a new command (like /packit rebuild-failed) or support chroots explicitly. In the second case, we can provide a failed alias you could use instead of a chroot.


[Components] Tabs

Both technical and design reviews on their ways 🚀

✅ OK design review

✅ OK design review

In story "intent" add labels to each example
We need lables for the sizes as well.
The label for States could change to Disabled state
Update the prop icon to reflect that now are childrens (like chips)
Add which one is the default in all black.

Everything has been updated. Waiting for final reviews!


Bump k8s.io/* deps to v0.29.0

Proposed Changes

Bump k8s.io/* deps to v0.29.0

Waiting for gardener/gardener to support k8s.io/* v0.29.0.

Closing in favor of https://github.com/ironcore-dev/gardener-extension-provider-ironcore/pull/522


Finalization issue

Based on 7c6474663cdba40422760d21ae0119bfad425e40

All nodes stopped finalization at 14046 / 14071.
New node failed to get finalization at all.
Restarting doesn't help.
Anything we can do to diagnostic the issue and resume the finalization process?

Could you try to collect some logs with -lafg?
CC @andresilva @rphmeier

4 validators( 3 validators in 14046, 1 validators in 14071), may be 3 validators afg not > 2/3 weight.
may be restart 4 validators resume grandpa

@gguoss I'm assuming the authorities are stuck on different rounds, if you collect logs for afg target you should see some messages saying the GRANDPA round the nodes are in. Can you also check if the validator that finalized 14071 is connected to the other validators? I think that validator is on a later GRANDPA round than the other validators.

Logs from validators and some other nodes https://gist.github.com/xlc/82e9c35d95f9e400134de047d6dfea67

logs-from-cennznet-validators-validator-0-in-cennznet-validators-validator-0-0.txt:2019-04-18 01:17:25.549 main DEBUG afg  Voter VALIDATOR_0 noting beginning of round (Round(551), SetId(0)) to network.
logs-from-cennznet-validators-validator-1-in-cennznet-validators-validator-1-0:2019-04-18 01:17:32.213 main DEBUG afg  Voter VALIDATOR_1 noting beginning of round (Round(550), SetId(0)) to network.
logs-from-cennznet-validators-validator-2-in-cennznet-validators-validator-2-0.txt:2019-04-18 01:17:16.724 main DEBUG afg  Voter VALIDATOR_2 noting beginning of round (Round(550), SetId(0)) to network.
logs-from-cennznet-validators-validator-3-in-cennznet-validators-validator-3-0:2019-04-18 01:17:25.558 main DEBUG afg  Voter VALIDATOR_3 noting beginning of round (Round(550), SetId(0)) to network.

So it seems that one of the validators progressed to the next round (maybe because the other authorities didn't see its vote), while the other authorities are stuck in round 550 and probably don't have threshold stake to finalize. What you should do to get finality started again is disable all validators and copy the database from validator 0 into the other validators' nodes, this way when you restart the nodes they'll all be at round 551.
We are working on improvements to fix these situations where it can get stuck with a small amount of validators (https://github.com/paritytech/substrate/commit/9631622fca89709914cec8a3680e5034c51b2519 was recently merged which should help as well).

Thanks. I will upgrade the substrate version and do the fix next week and report the results here.

Tried copy the db of validator 0 to other validators and reset all other nodes and it breaks the connection somehow. Maybe relates to #2335.
I am going to pull latest substrate and reset the testnet and see if this happens again.

Not happening anymore.

It happens again. Please let me know if there are anything you need to diagnostic this issue. The testnet is public now. Our telemetry server is not public but we are going to migrate to use polkadot one soon.
Our web UI: https://cennznet.js.org/cennznet-ui/
Our repo: https://github.com/cennznet/cennznet
Use --chain=rimu to join Rimu testnet. It is also the default network so not specify chain will join to it as well.
Let me know if you need anything, like logs from our validators, or a validator seat.

Most likely fixed in new version.

Tried copy the db of validator 0 to other validators and reset all other nodes and it breaks the connection somehow. Maybe relates to #2335.

I am going to pull latest substrate and reset the testnet and see if this happens again.

Will this workable? I am using rc5 and it happends again.


Parse templateFile for add / modify actions

Allow dynamic templateFile to work for add and modify actions, as discussed in https://github.com/amwmedia/plop/issues/15.

I'm going to go ahead and pull this in. If we decide later that there's a way to make it work to addMany, it can be done separately.

oh, and thanks! 😉


Documentation for FindTheGoal

Hello,
I was looking at issue #32 and the documentation for the environments and realized the FindTheGoal environment is one of the few environments with no documentation.
Since this is the environment that will be used for the first phase, I would like to know if there is an ETA for the documentation on this environment to be made available.
If I may make some suggestions, I would like to know:

If the room is always flat or if the goal may be occluded by walls (making it somewhat like a maze)
What materials are possible for the goal block and for the rest of the room
If there might be obstacles such as lava, holes, steps, etc.

Thank you very much!

#40

@rocanaan : You are right, there was a small issue. While I fixed it, I realised the docstirngs for FindTheGoal are not written. @idvhfd confirmed that he will be adding them soon.
And wrt your questions,

the room will always be flat, and goal will not be occluded by walls
the materials for goal block could be : gold_ore diamond_ore redstone_ore
there will be no obstacles.

@justinglibert : Its defined here. I might be misinterpreting it.
@rdgain : Can you comment on this ?

@spMohanty what I mean is that when I run the environment I never see any block other than the gold one. I looked at the mission file and didn't find a parameter to set that up. If during evaluation our agent can encounter non gold block, how are we supposed to set our local environment to reproduce this diversity?

Apologies for the delay, I was unable to attend this earlier. I added a brief description in the same style as the previous ones (awaiting confirm and pull). Thanks for pointing this out and please do accept my apologies for creating this situation. Let me know if anything else like this is needed.
@justinglibert the seed is being passed as a parameter, that's where the block comes from. Waiting on @spMohanty for exact path to that bit as I can't look for it right now.


Fix docs badge

What does this PR do?
Fix docs badge
Motivation
What inspired you to submit this pull request?
Review checklist

[ ] PR has a meaningful title or PR has the no-changelog label attached
[ ] Feature or bugfix has tests
[ ] Git history is clean
[ ] If PR impacts documentation, docs team has been notified or an issue has been opened on the documentation repo

Additional Notes
Anything else we should know when reviewing?

Closed for #2279


feat: Add observability sample code manifests

Deleted earlier folder. Created a new folder for code samples.

Hello @PrajaktaW-Google, is this meant to supersede this PR?  https://github.com/GoogleCloudPlatform/kubernetes-engine-samples/pull/596
And could you tell me where in the docs these samples appear? Thank you!

Yes, this will supersede this PR. The samples would appear on the following page:
https://cloud.devsite.corp.google.com/kubernetes-engine/docs/how-to/configure-dpv2-observability#hubble-ui-autopilot

2bourgeoisor I added one more sample to this pull request. Hope I have done it the right way.

@PrajaktaW-Google Let me know when you have a CL ready to review that leverages these new samples and I'll look at it at the same time as this PR

Sure, I will share the CL next week. Thanks!

Here is the CL: https://critique.corp.google.com/cl/538084632
Link to the topic where the code is: https://cloud.devsite.corp.google.com/kubernetes-engine/docs/how-to/configure-dpv2-observability

I have implemented the changes that were requested. Please approve the pull request.

The README says these samples are used in https://cloud.google.com/kubernetes-engine/docs/how-to/configure-dpv2-observability but I don't see them being used there. Is that doc changing?

Yes, that's the doc that's changing. Look for the following lines for the sample codes and expand the "+" sign:

+ To scrape metrics with Google Managed Service for Prometheus, create a ClusterPodMonitoring manifest
Deploy Hubble UI: **+**Create a hubble-ui-auto.yaml manifest.
Deploy Hubble UI: **+**Create a hubble-ui-std.yaml manifest.

@PrajaktaW-Google what I mean is that the code is hard-coded line-for-line in the doc. The doc doesn't refer or embed this repo. Is that changing? If so, could you send me the change-list for this?

I will embed this code once you merge it in the main branch. I will need that link and then embed the code. However, let me confirm the process again with my peers.


Visual Studio reports defaultSeverity as warning

Bug Report
I am setting up TSLint support for Visual Studio 2017. I have included this plug-in in my tsconfig.json file and, while it takes a moment to run its analysis, I do get results in the Error Window. However, I set the defaultSeverity to error with the expectation that the TSLint results would show up as Errors in the Error Window. When I run TSLint through the CLI, the results are reported at Errors as I would expect. So I believe this is working.
Is this the right expectation for Visual Studio?
Perhaps I am missing something in the setup for Visual Studio?

tslint-microsoft-contrib version: 0.3.1
TSLint version: 5.11.0
TypeScript version: 2.9.2
Running TSLint via: Visual Studio

tslint.json` configuration:
{
  "defaultSeverity": "error",
  "extends": "tslint:recommended",
  "jsRules": {},
  "rules": {  },
  "rulesDirectory": []
}

Actual behavior
TSLint errors are displayed as Warnings in the Error Window
Expected behavior
TSLint errors are displayed as Errors in the Error Window

@itanex this repo only provides lint rules and should not affect severity or integration with IDE.
As you noted - CLI gives correct results, so this issue should be filled against extension that you use in VS2017.
It may be the case that defaultSeverity is not yes supported by this extension.

Yeah I have been jumping around repos all morning and accidentally posted here.  I closed it since it was a mistake.


Missing the ability to stop the Interval

The interval is currently connected to the component lifecycle, however some intervals should quit earlier.
We can either track a boolean and skip executing the code in the interval, or e.g create a separate component with the useInterval and conditionally render it.
Both seem to be inelegant.

@patroza
Sorry if I misunderstood, but you can stop the interval by setting the delay to null.
const Root: FC = () => {
  const [remaining, setRemaining] = useState(25);
  const [delay, setDelay] = useState<number | null>(1000);

  useInterval(() => {
    setRemaining(remaining - 1);
  }, delay);

  return (
    <>
      <button
        onClick={() => {
          setDelay(null);
        }}
      >
        stop
      </button>
    </>
  );
};

Also explained here: https://overreacted.io/making-setinterval-declarative-with-react-hooks/


Feature Request: Query criteria in PageOptionsDTO

Feature Request
Many a time I will need to submit query criteria to search for instances.  The PageOptionsDTO instance should be enhanced to submit the complex query criteria that mikro-orm support such as $and, $or, $like, $ge etc.  This would allow clients to execute complex queries leveraging the richness of mikro-orm.

That looks doable. Do you have something in mind like an example of how the implementation would look like.

Example 1:   A request such as /posts?{$and:[{name:{$lk: "handbags"}}, {created:{$gt: "2022-05-01"}}]  is basically searching for posts where name contains ($lk = like) "handbags" and has been created after 2022-05-01.
Example 2:  A request such as /posts?{author: {$or: [{name: 'some name'}, {idx: 'xxxx-xxxx'}]}  is a request searching for posts by Authors whose name is either 'some name' or whose idx equals 'xxxx-xxxx'.
Ideally would be something along the lines of what is here -- https://github.com/nestjsx/crud/wiki/Requests#query-params

I think the https://github.com/nestjsx/crud/wiki/Requests#query-params looks more feasible, lets go with that one

Thank you for considering.  If you don't mind any idea on timing.  Sorry but., have some dependencies.., hence the ask..

Will try to start asap . Probably on coming weekend

Will be adding this as first priority : Checked item means they are already implemented

[ ] Select
[ ] cache
[x] search
[x] sort
[x] limit
[x] offset
[x] page

Sorry got way busy with work. Will try to complete them in few days time

I think I figured this one out although not ideal.  Would love to hear your comments ..,

Add the following to PageOptions.dto@Type(() => String)
@IsString()
@IsOptional()
readonly where?: string;

2.   In the Service class add the following ..,

   const criteria = where ? JSON.parse(where) : {};
   return from(this.repo.findAndPaginate( { deleted: false, active: true,  ...criteria }, ...

While this works.., the lack of type checking during the parsing is an issue and only shows up via errors. Ideally this would be something like below with type validation..,
``` const criteria<FilterQuery<TypeName>> = someMagicalMethod(JSON.parse(where)); ```

I will try to make it work. Will have to look into mikroorms typings to get it done

Also @rogrdat  are you having similar issues? https://github.com/rubiin/ultimate-nest/issues/78 while running

nah.., its working fine for me.,  didn't really face an issue.

Cool. I will see to the  list. Working on an interceptor for clearing the relevant cache when the data is mutated, will look into the cache query with it

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.


Move visualiser graph type default to a constant

Description
Refactors the way the visType default is handled so it's controlled by a constant defined at the top of visualiserApp.js
This also cleans up a few places where the default was being set
unnecessarily:

don't set it in html since we set it in javascript instantly anyway
remove code to set buttons to checked since this has no meaning

Motivation and Context
In my fork of Luigi, I use svg as the graph type default. This results in annoying merges when javascript related to handling the defaults changes. In order to make different defaults easier to maintain, this uses a constant in visualiserApp.js to determine which graph type is default rather than hard-coding it everywhere the default value is used.
Have you tested this? If so, how?
I ran it locally with both d3 and svg as defaults and tried loading pages. It seems to work.

While working on #2139 I discovered that the current default graph type is actually svg, despite code that attempts to make it d3. It seems we default the radio buttons to d3 but the graph behavior to svg. To minimize the effects of this change on the end user, I've added a commit that changes the default to svg. These commits now combine to fix a bug where by default you have an svg graph showing under a clicked d3 button, and you can't click the already clicked d3 button to change it.

Note: this failed travis due to a timeout. Nothing to do with this PR as it has no Python code changes.

Finally a red diff! :)

Hopefully I'll be done with the javascript stuff soon and I can get back to red-heavy Python diffs :)


base tag not respected for link urls

After updating from 7.2.2 to 8.0.2, the html base tag seems to be ignored.
Snippet:
<head>
    <base href="http://localhost:5000/">
    <link href="styles/style.css">
</head>

This results in:
Error: ENOENT: no such file or directory, open '..\report-server\styles\style.css'

stacktrace:
Error: Could not load link: "styles/style.css"
    at ...\code\report-server\node_modules\jsdom\lib\jsdom\browser\resource-loader.js:36:21
    at Object.check (..report-server\node_modules\jsdom\lib\jsdom\living\nodes\Document-impl.js:83:11)
    at ReadStream.<anonymous> (..\report-server\node_modules\jsdom\lib\jsdom\living\nodes\Document-impl.js:101:12)
    at ReadStream.wrappedEnqueued (..\report-server\node_modules\jsdom\lib\jsdom\browser\resource-loader.js:200:16)
    at emitOne (events.js:77:13)
    at ReadStream.emit (events.js:169:7)
    at fs.js:1682:12
    at FSReqWrap.oncomplete (fs.js:82:15)

That is not a valid base URL, I am pretty sure. I doubt that code works in a web browser.

Sorry that wasn't a cut and paste, I fixed it. The HTML has not chagned since I updated, it used to work.

It's quite possible that by increasing spec compliance we made things that used to work, stop working.
Can you produce a full code snippet, that I can run with node test.js, showing the problem?

Sure, I'll work it up.

https://github.com/jamietre/jsdom-base-url-issue

Thanks, will investigate!

Thanks. I just updated the repo to correct some confusing things that were result of my haste... but the changes have effect on the outcome.


Fix for FCPL false positive

@mlinksva This is a different approach to solve for the FCPL false positive. Rather than hard-coding limits like the max delta, this PR:

Increases the confidence threshold to 98%, which makes the max delta smaller across all licenses
Better content normalization so the delta is more accurate (whitespace and HRs)

Beyond that this PR also fixes the integration test that modified licenses - previously it added a small number of words to the end of the license which (A) was a small change when converted to a wordset and (B) was stripped entirely from licenses with instructions. Now modified licenses should not match, which I believe is the intended behavior (we were previously testing that they were matching).
Raising the confidence threshold is obviously going to result in more false negatives for modified licenses, but (A) I think that's the intended behavior in many cases (like FCPL) and (B) I'd prefer we return false negatives to false positives.

❤ :

better normalization
higher confidence threshold
removal of 3 random added words expected to pass tests (a mild source of aggravation as an occasional contributor)

The only concern I have is that I guess that false negative rate will be much higher for old short permissive licenses, as their bodies have historically been templated. That was the hunch I was following in trying to put hard limits on the changed words/length for longer licenses, while keeping 5% wiggle room for shorter licenses.
I strongly agree on preferring false negatives to false positives and totally fine with choices made in this PR, just putting this thought out there in case useful.

:metal:

The only concern I have is that I guess that false negative rate will be much higher for old short permissive licenses, as their bodies have historically been templated. That was the hunch I was following in trying to put hard limits on the changed words/length for longer licenses, while keeping 5% wiggle room for shorter licenses.

I thought about suggesting a minimum delta, but anything more than 2% is too much to distinguish FCPL from MPL.


apis: add extension plugin framework for PodMetric

Signed-off-by: Jason Liu<EMAIL_ADDRESS>Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist

[ ] I have written necessary docs and comments
[ ] I have added necessary unit tests and integration tests
[ ] All checks passed in make test

/lgtm

/lgtm

/approve


Added template_oid support to getValue

For uninitialized param values, getValue will now return the value from the template param if available. Does not yet support recursive templates.

better to not merge this now after lengthy discussion on implementation approach


Weird Display in RN V0.68 New Architecture Enabled

Bug
Svg does not show in rn v0.68.0-rc.2 with new architecture enabled instead it shows a strange Text of 'RNSVGRect'

react-native init CleanProject --version 0.68.0-rc.2
cd CleanProject/
yarn add react-native-svg
modify android/gradle.properties -> and change to newArchEnabled=true
run the app -> react-native run-android

Environment info
React native info output:
 System:
    OS: macOS 11.6.2
    CPU: (4) x64 Intel(R) Core(TM) m3-7Y32 CPU @ 1.10GHz
    Memory: 311.86 MB / 8.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 16.13.2 - /usr/local/bin/node
    Yarn: 3.1.1 - /usr/local/bin/yarn
    npm: 8.1.2 - /usr/local/bin/npm
    Watchman: Not Found
  Managers:
    CocoaPods: 1.11.2 - /usr/local/bin/pod
  SDKs:
    iOS SDK:
      Platforms: DriverKit 21.2, iOS 15.2, macOS 12.1, tvOS 15.2, watchOS 8.3
    Android SDK: Not Found
  IDEs:
    Android Studio: 2020.3 AI-203.7717.56.2031.7935034
    Xcode: 13.2.1/13C100 - /usr/bin/xcodebuild
  Languages:
    Java: 11.0.10 - /usr/bin/javac
  npmPackages:
    @react-native-community/cli: Not Found
    react: 17.0.2 => 17.0.2
    react-native: 0.68.0-rc.2 => 0.68.0-rc.2
    react-native-macos: Not Found
  npmGlobalPackages:
    *react-native*: Not Found

Library version: ^12.1.1
Steps To Reproduce

react-native init CleanProject --version 0.68.0-rc.2
cd CleanProject/
yarn add react-native-svg
modify android/gradle.properties -> and change to newArchEnabled=true
yarn android

Describe what you expected to happen:

Display svg correctly

RSSVG Not supported by fabric yet. https://github.com/reactwg/react-native-releases/discussions/13#discussioncomment-2254917

@myckhel any chance you can actually prepare some repro code that shows the problem? your repro steps don't contain any code 😅

@kelset Example repo has been created at https://github.com/myckhel/svg-fabric-unsupported

hi,
I am also facing the issue in android using React Native Fabric architecture.
Any way to fix this?

Same here

Apparently react-native-svg does not fully compatible with new architecture yet. #1731

https://github.com/react-native-svg/react-native-svg/pull/1754

#1754

even after this PR has been merged, some components are still not Fabric compatible

I think we can close this issue now since Fabric support is released. Although, if you want to use it on Android in RN version < 0.70.0-rc.3, you need to link the components manually. There is already an issue for how to do it which I plan to resolve ASAP: https://github.com/react-native-svg/react-native-svg/issues/1839. Feel free to comment here if something is wrong and we can always reopen it then.


feat(wallets): Adds dawn wallet support

Problem solved
Short description of the bug fixed or feature added
Changes made

[ ] Public API changes: list the public API changes made if any
[ ] Internal API changes: explain the internal logic changes

How to test

[ ] Automated tests: link to unit test file
[ ] Manual tests: step by step instructions on how to test

Contributor NFT
Paste in your wallet address below and we will airdrop you a special NFT when your pull request is merged.
Address:

#3381  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @gregfromstl and the rest of your teammates on  Graphite


Play status indicator

Add playback status indication to the tiles.
For example, tiles may have a slightly different color. Or the tile can display a play/pause icon + time and position.


build failure

following the install instructions in the readme I get the following error on step pip install .
  Preparing metadata (setup.py) ... error
  error: subprocess-exited-with-error

  × python setup.py egg_info did not run successfully.
  │ exit code: 1
  ╰─> [8 lines of output]
      Traceback (most recent call last):
        File "<string>", line 2, in <module>
        File "<pip-setuptools-caller>", line 34, in <module>
        File "/home/user/dev/clones/git-remote-nostr/setup.py", line 10, in <module>
          with open(path.join(here, 'README.rst'), encoding='utf-8') as f:
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        File "<frozen codecs>", line 906, in open
      FileNotFoundError: [Errno 2] No such file or directory: '/home/user/dev/clones/git-remote-nostr/README.rst'
      [end of output]

fixed on master