Lemmatization

Turn the lemma_ field in HeadModifierTree into get_lemma function, which takes a list of POS tags of words that should be lemmatized.
Query functions can pass this pos tag list to control what types of words are to be lemmatized.
Fixed #38.
Unittest coming in the future

I think it would be nice to put lemmatization under a flag. Callers can then specify if they want lemmas or original tokens.

Edited as recommended.

lgtm :airplane:

On Jan 13, 2016, at 10:46 AM, moldot<EMAIL_ADDRESS>wrote:

For non-nouns, only lower case.

I'm not sure how you mean this, but in case it's relevant, I note that it is possible to have uppercase letters in verbs and adjectives, such as adjectives of geographic location ("African"), adjectives derived from proper names ("Cartesian"), verbs formed from geographic locations ("Americanize"), etc.

That I meant to lower all words regardless of the POS tags. So, African -> african, Americanize -> americanize. Specifically for nouns, by default, we actually lemmatize them, so Americans will become american. You can, however, require by using lemma_pos flag that other words be lemmatized, too.


Show deprecated blocks if they're being used in a tutorial

fix https://github.com/microsoft/pxt-microbit/issues/3096
I tested this with the random-range deprecated block, and the radio.receiveString() because they seem to be deprecated in different ways?

Yes, that's correct. Those blocks should only show up as shadows

@riknoll what is a shadow block?

Shadow blocks are the blocks you can't remove from inputs. In the toolbox, we use them for default values. You can place other blocks on top of them and they stay if you pull those blocks out again.
We generally try to make it so that you can't have "holes" in the program so that it always converts cleanly to text. Shadow blocks can't be removed so there will always be something. The exception is variable and array blocks, because those can take any type and we can't populate default values.


Allen and drift datasets are the same...

I downloaded all the datasets, using the download_recording.py script. However, it looks like the two allen dataset are the same (same size and same data...), and same for the drift recordings. The code created separate files, but content are identical

You're absolutely right. That's embarrassing.... I had a copy and paste error in the prepare script. I just fixed it, reran the prepare script. So if you git pull this repo you should it should be a non-dup now.
Here are the diffs showing the change:
https://github.com/flatironinstitute/neuropixels-data-sep-2020/commit/da8ff1e26767c08758e4f9e1deede9573289e947#diff-14ff3c3b1ba49e0386d4e250f0af7842
https://github.com/flatironinstitute/neuropixels-data-sep-2020/commit/da8ff1e26767c08758e4f9e1deede9573289e947#diff-068b939774db53f90e085cbd43930134
Tagging: @alexmorley @mhhennig


Validation and Test Results Didn't Change

Hi @ruidan ,
I have run the training and validating scripts with the default setting but the validation result and test result still same in all epoch.

Do you have any ideas about my issue? Thank you.
Noted: I have formatted source code from Python 2. to Python 3. because currently the Tensorflow does not support Python 2. anymore.

Hi， I never test the code with python3. It seems other people also raised the issue that the code will encounter some strange training losses when trained with python3. Therefore, to reproduce the results, it's better to follow the environment setting suggested in README

Hi， I never test the code with python3. It seems other people also raised the issue that the code will encounter some strange training losses when trained with python3. Therefore, to reproduce the results, it's better to follow the environment setting suggested in README

Sorry, I don't find any solution to install TF 1.14 with python 2.7 as in README, even find wheel file on this page https://github.com/fo40225/tensorflow-windows-wheel


docs(jwt) add clarification for consumer parameter in jwt

Related with https://github.com/Kong/kong/issues/2898

Thank you!!

(only in 0.11)

Yes, plugins docs isn't versioned yet anyways, so this property is visible to all versions :/


Feat: Add Contact Us page

Describe the feature
I will add a Contact Us page for the website it will help users to share their views
Add ScreenShots
I will implement it using email js for mailing functionality
Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

@Ayushmaanagarwal1211 go ahead

Ok

@mdazfar2  shall i start working on contact page or faq's page first

@Ayushmaanagarwal1211 sure

Ok working on it

Hii @mdazfar2  when i update my fork to latest as yours  i noticed that someone did work on contributors section and did some changes because of that in my laptop it is not responsive as previous can you please check .
https://github.com/mdazfar2/HelpOps-Hub/assets/118350936/52a09a12-2ced-48be-b7c7-60637c797234


Pin down bundler version in CircleCI config

https://circleci.com/gh/gpii-ops/gpii-infra/390?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

LGTM


Don't strip an ellipsis (...) from a function's body - this has special meaning to type-checkers

Before ruff:
if TYPE_CHECKING:
    def compress(bytes: Sequence[int], target: int) -> list[int]:
        """Docs"
        ...   # <- this tells type-checkers to treat this function like a stub and ignore its body

After ruff:
if TYPE_CHECKING:
    def compress(bytes: Sequence[int], target: int) -> list[int]:  # type: ignore
        """Docs"""
        # Without ... the type-checker assumes the return type is None
        # thus the type-checker marks the return-type annotation as an error.

The ellipses signals to the type-checker (e.g. pyright) that function is acting as a stub and the body should be ignored. In the latter case, the type-checker things that the function returns None and thus marks the return-type as an error.
I.e. without the ellipses, you have to either: provide a fake function body or # type: ignore the function's signature, which would mask actual type-errors in the signature.

Hm we talked about this previously re protocols
https://github.com/astral-sh/ruff/issues/8756
Should we make another exception for if TYPE_CHECKING blocks?

Should we make another exception for if TYPE_CHECKING blocks?

That would be good.
Treating pass and ... as being the same seems weird to me. They are definitely not the same thing.

This should be relatively easy if someone is interested in it.


Log errors for frontend

https://github.com/Open-Pectus/Open-Pectus/issues/311
UOD author could make an error in the UOD.
Erroneous command in method editor.
Maybe create another issue for when we have a hardware layer ready for logging/error handling
Log statements are unique. (1000 repeats of the same error are not useful)

Wrt. to

Log statements are unique. (1000 repeats of the same error are not useful)

I think we need to know the exact situation where this can occur, so we can fix the issue correctly.
If it e.g. is a case of not reporting the same error from hardware each tick, we should probably handle it near the hardware, rather than filter just before sending to frontend.
Filtering on "same text" just before delivering to frontend could hide some repeat errors with significant information, such as clicking a command button twice, where filtering could hide that it failed both times.

A potential solution could be to deduplicate concecutive lines with the same text, keeping the latest timestamp, and counting how many repeats there is, like the chrome debugger does.

Note: The errors sent to aggregator by engine are not just text messages forwarded to the frontend. They are  part of aggregator's model state (contained in RunData which is contained in EngineData). Incoming error log entries are handled in aggregator.from_engine.error_log_changed which currently appends the entries.

Created a spike on aggregation in branch https://github.com/Open-Pectus/Open-Pectus/tree/323-log-errors-for-frontend
Missing persistence changes to save the new entries in db

Review spike, merge it in and create an issue for frontend changes

Hi @jhk-mjolner , this branch is ready for the frontend changes regarding duplicated log entries


Toggle comment in fixed-form grammar

What's the way to indicate how toggle comment should work (Command-/) in fixed-form source files? Currently, Command-/ inserts C-style comments. I tried adding this to my config.cson:
".fixed.fortran.source":
  editor:
    commentStart: "^C "
    commentEnd: ""

but clearly, that's not the way to insert a C in column 1... Any ideas?

Naively, I would expect it to be this
'.source.fortran.fixed':
  'editor':
    'commentStart': 'C '

However this always inserts the comment character before the first non-whitespace character. I don't know how to make it insert the comment character in the first column of a line. I'll look into it and see if I can find anything.

Thanks! A cursory search didn't reveal anything for me. It might need some JavaScript to the rescue, but that's uncharted territory for me.

It appears as though this isn't currently possible in Atom at the moment (see this post), or at least without doing some serious hacking. I've opened an issue at https://github.com/atom/atom. Hopefully they get around to introducing this feature soon.

Thanks. Maybe this calls for a specialized extension in the vein of comment. For example, https://github.com/havber/comment/blob/master/lib/comment.js#L70 seems relevant.

Thanks for the link @dpo, I'm not too familiar with how to write non-syntax highlighting packages for Atom but I'll definitely give that a look to see if it can help.

@dpo I looked into this issue and it looks like I can add some coffee-script or javascript to make this work. I can't give you an ETA as I'm this will require me diving into entirely new territory as far as Atom is concerned but I can say that this is next on my todo list for this package.

@tomedunn I think that would be excellent. I can try to help, but my javascript is just about nil.

So I was able to make some progress on this. It's still not resolved completely but it should be a good first step. This adds a function that can be assigned to a keybinding that will add comments to the start of a line in Fortran - Fixed Form files.
The next step that is needed is to figure out how to create a keybinding that is scope specific. For instance, set things up so cmd+/ calls the regular comment toggling function in Atom when not in Fortran - Fixed Form files and calls the custom function I just added when inside Fortran - Fixed Form files.

Many thanks for this! I just upgraded to 2.0.11. Calling "Language-Fortran ToggleComment" from the command palette doesn't seem to do anything though. What am I missing?

The command will only work in files that are using the Fortran - Fixed Form grammar. I set a keybinding to work with cmd-/. Are you trying this on windows or OS X? If you check out the keybinding file here you can see how to change the keybinding. Let me know if you aren't able to get it to work.

I'm not having any luck. I tried changing the keymap in my keymap.cson with no luck. I experimented with the syntax
"atom-text-editor[data-grammar='source fortran']":
  'cmd-/': 'language-fortran:toggleComment'

(found here). Still no luck.
If anything, calling the function Language Fortran: ToggleComment explicitly from the command palette should always work, shouldn't it?

Did you check the keybinding resolve window with cmd-. to see if the keybinding is being set properly? Also, if you haven't, check the scope with cmd-alt-p to make sure the scope is source.fortran.fixed.

Well I closed the Atom window and opened a fresh one, and now it's working. I guess it needed refreshing. It works nicely now. Many thanks for that!!!

Awesome. If you run into any issues with it let me know! :smile:


Filters not working

Hi ,
Im trying to use filters and isnt work.
I try filter and search methods and only search works. I disable search but filter not work .
At the printscreen below , we can see the result of search method and filter method. With filter, not insert the query to search for my column.
So , what im doing wrong ?
-- Notes:

php 8.1
Laravel 9.52.7
Package version 1.8.3

App\MyModel.php

CLI Test
>
>
> Company::filter(['my_select_filter' => 1])->toSql()
= "select * from `companies`"

> Company::search('test')->toSql()
= "select * from `companies` where (`name` LIKE ?)"

>

My filter
class MySelectFilter extends SelectFilter
{
    public FilterMode $mode = FilterMode::EQUAL;

    protected string $field = 'my_column_id';

    public function title(): string
    {
        return __('Sector');
    }

    public function component(): string
    {
        return 'select';
    }

    public function options(): array
    {
        return OtherModel::query()
            ->orderBy('name')
            ->pluck('name', 'id')
            ->toArray();
    }
}

It should work if you just turn around keys and values of your option array:
public function options(): array
    {
        return OtherModel::query()
            ->orderBy('name')
            ->pluck('id', 'name')
            ->toArray();
    }

The Filtersystem expects the allowed values for filtering in the value-part of the options-array.
The key (if it isn't a sequential array) is only used for filter-visualisation
This is a good hint for extending the documentation

I updated the docs - but it will not be shown on the Documentation page until a new release is released:
you can view it here:
https://github.com/lacodix/laravel-model-filter/tree/master/docs/filter-types

This not work hehe.
public function options(): array
    {
        return OtherModel::query()
            ->orderBy('name')
            ->pluck('id', 'name')
            ->toArray();
    }

The name attribute must be before ID ( pluck('name', 'id')  its the right way.

This not work hehe.
public function options(): array
    {
        return OtherModel::query()
            ->orderBy('name')
            ->pluck('id', 'name')
            ->toArray();
    }

The name attribute must be before ID ( pluck('name', 'id') its the right way.

Sorry , my mistake.
im build my own component and  , using ('íd', 'name')  my select works wrong , but the filter works fine hehe.
I write a custom function to parse the values of the array ( options ) property and work fine.

So , now  , looks working fine .
Thanks for the help.

My suggestion ,
Put to work with  pluck('name'or title, wte , 'id')  ( filter not work )
because the output array will be :
[
1 => 'name'
]
Using this way ( filter work ) pluck('id''name'), the output will be
[
'name' => 1
]
Using translatable package , will be:
[
'{en: name}' => 1
]
In my project  , i use laravel Translatable , so  , using pluck('id''name') laravel parse the right translation to my model and i can render properly the select with the options .
So , i can parse and mount my array , but the translations wasnt parsed.

My suggestion ,
Put to work with pluck('name'or title, wte , 'id') ( filter not work )
because the output array will be :
[ 1 => 'name' ]
Using this way ( filter work ) pluck('id''name'), the output will be
[ 'name' => 1 ]
Using translatable package , will be:
[ '{en: name}' => 1 ]
In my project , i use laravel Translatable , so , using pluck('id''name') laravel parse the right translation to my model and i can render properly the select with the options .
So , i can parse and mount my array , but the translations wasnt parsed.

Update.
This way works fine with Translatable. If has translation ,fetch the right item from translate ,if not, use the value.

To be honest - I'm a bit confused now... :-)
Why do you need this huge availableFilters-Array? Or is it just for some caching-purpose?
About the "filterIsActive" functionality: I already thought about adding such a thing, but finaly I came to the solution that this isn't scope of the package... In an application where I used it, i added a macro "isActive" to the filters (all Filters ar macroable) and just checked if the query-parameter is set for the filter, and returning true) - so I always work with the filter-objects itself...
about your translation problem: what about not using pluck on database? pluck is only a convenient way to fetch only the needed data from database, but you can also do this::
public function options(): array
    {
        return OtherModel::query()
            ->get()
            ->mapWithKeys(fn ($otherModel) => [$otherModel->name => $otherModel->id])
            ->toArray();
    }

I guess accessing name over the model will give you the translated string.
and even sort it:
public function options(): array
    {
        return OtherModel::query()
            ->get()
            ->mapWithKeys(fn ($otherModel) => [$otherModel->name => $otherModel->id])
            ->sortKeys()
            ->toArray();
    }

Hi ,
Im write a FilterBarComponent  , that receive the model and render the filters ,  make filter active or disable it .
About the mapWithKeys method, works fine   , im me select component  , i change the key by values and now looks good.


GameService: Register events in the Bean life-cycle

Ideally, constructors should not have side-effects.
This means there are no surprises when constructing them e.g. in test.

Well kind of makes sense. never thought about it obviously :D


userinteraction enable or disable of cells

can i manually enable and disable the userinteraction of cell

yes, you can do it like this
yourRow.enabled = false


Add assets id as outputs.id to action

Added assets id to the actions outputs. The outputs.id field was mentioned in README.md but strangely not implemented yet.
Related Issue: https://github.com/actions/upload-release-asset/issues/48

The same problem here.


Build appears broken on NetBSD

I'm not sure what the support expectations are here as NetBSD is listed as an untested platform, but here's the output of the tests on NetBSD 8.0.
/home/worker/test-rust-libc.sh
 in dir /home/worker/buildbot/nbsd8-build/build (timeout 1200 secs)
 watching logfiles {}
 argv: [b'/home/worker/test-rust-libc.sh']
 environment:
  EDITOR=vi
  ENV=/home/worker/.shrc
  HOME=/home/worker
  LOGNAME=worker
  MAIL=/var/mail/worker
  OLDPWD=/home/worker
  PATH=/home/worker/.cargo/bin:/home/worker/bin:/bin:/sbin:/usr/bin:/usr/sbin:/usr/X11R7/bin:/usr/pkg/bin:/usr/pkg/sbin:/usr/games:/usr/local/bin:/usr/local/sbin
  PKG_PATH=ftp://ftp.netbsd.org/pub/pkgsrc/packages/NetBSD/amd64/8.0/All/
  PWD=/home/worker/buildbot/nbsd8-build/build
  SHELL=/usr/pkg/bin/bash
  SHLVL=1
  SUDO_COMMAND=/usr/pkg/bin/bash
  SUDO_GID=100
  SUDO_UID=1001
  TERM=xterm-256color
  USER=worker
  USERNAME=worker
  _=/usr/pkg/bin/buildbot-worker3.6
 using PTY: False
NetBSD  8.0 NetBSD 8.0 (GENERIC) #0: Tue Jul 17 14:59:51 UTC 2018  mkrepro@mkrepro.NetBSD.org:/usr/src/sys/arch/amd64/compile/GENERIC amd64
info: syncing channel updates for 'stable-x86_64-unknown-netbsd'
info: checking for self-updates
info: downloading self-update

  stable-x86_64-unknown-netbsd unchanged - rustc 1.31.1 (b6c32da9b 2018-12-18)

rustc 1.31.1 (b6c32da9b 2018-12-18)
    Finished dev [unoptimized + debuginfo] target(s) in 0.45s
     Running /home/worker/buildbot/nbsd8-build/build/target/debug/deps/linux_fcntl-6f4169ac44ebdb2e
RUNNING ALL TESTS
PASSED 0 tests
     Running /home/worker/buildbot/nbsd8-build/build/target/debug/deps/main-9aae4aee8abc9d16
RUNNING ALL TESTS
bad ifaddrs size: rust: 56 (0x38) != c 64 (0x40)
bad NET_MAXID value at byte 0: rust: 35 (0x23) != c 36 (0x24)
bad NET_RT_OOIFLIST value at byte 0: rust: 3 (0x3) != c 4 (0x4)
bad NET_RT_OIFLIST value at byte 0: rust: 4 (0x4) != c 5 (0x5)
bad NET_RT_IFLIST value at byte 0: rust: 5 (0x5) != c 6 (0x6)
bad NET_RT_MAXID value at byte 0: rust: 6 (0x6) != c 7 (0x7)
thread 'main' panicked at 'some tests failed', /home/worker/buildbot/nbsd8-build/build/target/debug/build/libc-test-2a6b9a208facfc9b/out/main.rs:11:21
note: Run with `RUST_BACKTRACE=1` for a backtrace.
error: test failed, to rerun pass '--test main'
program finished with exit code 101
elapsedTime=1.697112

We are only testing that libc builds properly on NetBSD, we are not testing that its ABI is correct.
PRs welcome.

Also ideally, one only needs to contribute a qemu-system build job that runs the tests on a netbsd image. We do this for sparc, s390x, and freebsd, so it shouldn't be hard.

Renamed the issue, since the build actually works on NetBSD. What's failing are the libc-tests. Since NetBSD is not tested on CI, that's to be expected. PRs welcome.


Fix node.js server

The Node.js server isn't using the correct path to serve the front-end files so this PR fixes that.
Wait until #59 is merged before merging this one.

The issue could actually be more easily fixed by updating the .env file to use the correct path. I updated the information in the README to reflect that


should depend on/use graphql-language-service instead of graphql-language-service-interface (deprecated)

graphql-language-service-interface is now deprecated, the way to go is to use graphql-language-service
as all of the subpackages are merged into it.
see deprecation message

One feature that I'm excited about that's in graphql-language-service is getAutocompleteSuggestions includes documentation in the completion items it returns.  Currently ts-graphql-plugin only includes the names of the completions.  You can only access the documentation by hover over a field or whatever after you the completion has been inserted.


dynamicopenvr incompatibility

as it says, using dynamicopenvr with customavatars makes it impossible to draw. I can open the menu and select stuff but actually drawing doesnt work with any button for me. Deleting all of dynamicopenvr and customavatars resolves the issue.
Oculus cv1 on steamvr

Scribble is incompatible with dynamicOpenVR.BeatSaber, since it overrides input handling.
You can still use CustomAvatars without dynamicOpenVR.BeatSaber (just make sure you have the base mod "DynamicOpenVR" installed).


About deployment

Thank you for open sourcing your code!
May I ask what platform your code is deployed on? What frame rate was achieved?

We deployed our policies on various platforms (please see our paper): two different Franka robots, a WidowX robot and the Google robot.
For frame rate, we achieved approximately 6 Hz on a 4090 GPU (again see paper for a detailed plot of achievable control frequencies on different GPUs)


Remove check, --explain, --clean, --generate-shell-completion aliases`

Summary
This PR removes the ruff <path>, ruff --explain, ruff --clean and ruff --generate-shell-completion aliases that were deprecated in https://github.com/astral-sh/ruff/pull/10169 (v0.3.0)
Resolves https://github.com/astral-sh/ruff/issues/10171
Test Plan
I verified that:

The JetBrains extension uses ruff check
The LSP uses ruff check
python-lsp-ruff I think it uses ruff check

I'm looking at the Neovim ecosystem, already completed in conform.nvim:  https://github.com/stevearc/conform.nvim/pull/348

I changed the implementation to error instead of removing the aliases entirely.


thread 'main' panicked at 'range start index 3 out of range for slice of length 2', library/core/src/slice/index.rs:52:

Hi there,
I run rosella with command "rosella recover -i group-MetaGeno_mb2_depth.txt -r MEGAHIT-group-MetaGeno.contigs.fa --output-directory ./rosella_out/ --threads 14"
But after it build the index, I got an error like:
thread 'main' panicked at 'range start index 3 out of range for slice of length 2', library/core/src/slice/index.rs:52:
note: run with RUST_BACKTRACE=1 environment variable to display a backtrace
And it stoped.
Could you help me to check, what's the problem?
Thank you!

Hello,
Would you be able to show me what your group-MetaGeno_mb2_depth.txt file looks like?
Cheers,
Rhys

Hello,
Would you be able to show me what your group-MetaGeno_mb2_depth.txt file looks like?
Cheers, Rhys
Hi Rhys,
The depth file looks like this:
k141_7783846    23.7211
k141_4245736    7.71226
k141_21228664   2.38346
k141_19813420   3.75191
k141_15567689   12

Thank you for your help!

Hi Rhys,
I checked the depth file, it seems like the format of my file is wrong. After I feed the correct depth file to rosella, it can run without errors.
Thank you very much!
Best,

Hi,
Good job figuring out the depth file. Do you have any indication of the quality of the assembly you are trying to provide to rosella is? What is the N50, how many contigs, and what is the overall assembly size in base pairs?
Cheers,
Rhys

Hi Rhys,
I used all the assembly from the MEGAHIT, maybe I need to filter the raw contigs with length (e.g. minimum 1000 bp) first, then feed them to rosella？
contigs (>= 0 bp) 22503179
contigs (>= 1000 bp) 3277097
contigs (>= 5000 bp) 263856
contigs (>= 10000 bp) 86370
contigs (>= 25000 bp) 19635
contigs (>= 50000 bp) 5314
Total length (>= 0 bp)<PHONE_NUMBER>7
Total length (>= 1000 bp)<PHONE_NUMBER>
Total length (>= 5000 bp)<PHONE_NUMBER>
Total length (>= 10000 bp)<PHONE_NUMBER>
Total length (>= 25000 bp) 918924844
Total length (>= 50000 bp) 434733433
contigs 10296633
Largest contig 713443
Total length<PHONE_NUMBER>8
GC (%) 47.28
N50 1527
N75 781
L50 1701970
L75 4882146
N's per 100 kbp 0.00
predicted rRNA genes 1421 + 572 part
Thanks for all your help.
Li Zhao

Hi Li,
I'm unsure what would be causing this issue. I'll have to take a closer look, would you be able to send me through the coverage file and the assembly and I'll see if I can get a more informative error to be produced?
Cheers,
Rhys

Hi Rhys,
The size of the files are big. I have sent the link to your Gmail.
Just in case, I also paste it here:
https://drive.google.com/file/d/1vOnQuDqnRaxasqMGPXInzpXjhrfxfTBo/view?usp=share_link
https://drive.google.com/file/d/1XymHT6NbNJAveejda7RUbl9etC5BFgqR/view?usp=share_link
Thanks for all your help.
Best,
Li

Hi Li,
Sorry have just gotten around to this properly. These files are really big, I'm wondering if your machine is running out memory trying to process them? How much RAM does your machine have?
cheers,
Rhys

Hi Rhys,
The node I used has 3.72T RAM, so it should not be a memory error.
Best,
Li

Hi Li,
Would you be able to check something for me?
Could you run flight by itself? i.e.
flight bin --input MEGAHIT-group-MetaGeno-depth.txt --kmer_frequencies rosella_test/rosella_kmer_table.tsv --assembly MEGAHIT-group-MetaGeno.contigs.fa --cores 8 --output_directory rosella_test/

replacing the kmer table with the one previously produced and the output folder with the previous one as well? And then post what the error says? I think there might be a strange dependency issue occuring with skbio
Cheers,
Rhys

I'm hoping this is fixed in v0.5.0, error should at least be exposed. Please create a new issue with the error from flight if you still experience this


Limit of VMs per backup policy

Hi,
Is the 100 VM/policy still accurate?
Thanks,
Chai

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 88beaa58-adf5-28ef-5510-01ace6923eef
Version Independent ID: 02b2de6f-ba0a-d9dc-fd4f-c0c4d3a46107
Content: FAQ - Backing up Azure VMs - Azure Backup
Content Source: articles/backup/backup-azure-vm-backup-faq.md
Service: backup
GitHub Login: @dcurwin
Microsoft Alias: dacurwin

Thanks for your question. We are actively investigating and will get back to you shortly. Thanks for your patience.

#reassign:sogup

Yes, this limit applies for a backup policy. We recommend creating multiple policies for more than 100VMs for an improved performance.
#please-close


enable_external_interface set to False in defaults-2.0.yml

Can one of the admins verify this patch?

"ok to test" to accept this pull request for testing
"test this please" for a one time test run
"add to whitelist" to add the author to the whitelist

ok to test

retest

I believe you'll need to do something to get the CI runs to work. You may have to add this setting as true in the config that CI builds up. Perhaps somewhere in https://github.com/blueboxgroup/ursula/blob/master/test/setup#L62
In fact, the role default should be False, which it is. So this PR should do two things:

Remove the enable_external_interface entry all together from defaults-2.0.yml
Add a line during CI build up to enable the external interface.

@j2sol @paulczar
We should probably update the all.yml during CI build up to set this variable to true.
In test/setup,
cat >> ${ROOT}/envs/test/group_vars/all.yml <<eof
neutron:
enable_external_interface: True
eof
This would override the default in neutron-common/defaults/main.yml

@ssrikant20 Sounds good, please adjust your PR accordingly, and take out the entry in defaults-2.0.yml


Update virtualbox to 5.1.18-114002

After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} left no offenses.
[x] The commit message includes the cask’s name and version.

Closes #30963


solve Issue 243: add ignore_checks switch

Solves Issue #243 by adding a switch (--ignore_checks) to ignore the pre attack checks for malformed modulus.

Checks always fail, I think it's better to remove it (tu make rsactftool we need to always use --ignore-check with this pr)

I can implement the inverse logic

+1

The commit  is: 8bfd2a42096c1d24e1b840f8c74621768264bfcb


ModuleNotFoundError: No module named 'pyparrot.Model'

Hi,
First of all, thank you so much for sharing your work, it is being really usefull. I have an issue running demoBebopVision.py. I have a bebop2, but its not an issue of the drone so it does not matter i think,. when running demoBebopVision.py from cmd of windows, i have next issue:
Traceback (most recent call last):
File "demoBebopVision.py", line 8, in
from pyparrot.Model import Model
ModuleNotFoundError: No module named 'pyparrot.Model'
Cannot guess what is happening, cause the others demo do work correctly. I have tried to fix the path to the folder pyparrot, but its still not working, and it is the only module is giving problems. Can u imagine what could be happening?
Thanks a lot!

When i say its not a drone issue, is because im not even conecting the Bebop, it gives the problem just running the script

Hi,
First of all, thank you so much for sharing your work, it is being really usefull. I have an issue running demoBebopVision.py. I have a bebop2, but its not an issue of the drone so it does not matter i think,. when running demoBebopVision.py from cmd of windows, i have next issue:
Traceback (most recent call last):
File "demoBebopVision.py", line 8, in
from pyparrot.Model import Model
ModuleNotFoundError: No module named 'pyparrot.Model'
Cannot guess what is happening, cause the others demo do work correctly. I have tried to fix the path to the folder pyparrot, but its still not working, and it is the only module is giving problems. Can u imagine what could be happening?
Thanks a lot!

Ok i have already solved it. the problem was that the folder "C:\Users\jorge\anaconda3\Lib\site-packages\pyparrot" was not saved the module Model.py, so it was not found. i just copied there the file and it runs correctly ;D


Add feature of not registering scroll event

Since scroll events are heavy, that would be grate if you could add the feature of disabling scroll event registration. This way I could have my own scroll event and pass it's pulses to many other components.

Added .offEvent method in v3.2.0 ;)

Thank you very much for this awesome project.


43 bilinear

Proposal for a bilinear interpolator for images (inspired from the one in pyFAI).
the map_coordinates can be parallelized if needed.
related to #43

Please, can the doc be modified to refer to array first and second dimension or to array rows and columns instead of the ambiguous x and y (or better said y and x)?

On Fri, 29 Apr 2016 07:12:45 -0700
V. Armando Solé<EMAIL_ADDRESS>wrote:

Please, can the doc be modified to refer to array first and second dimension or to array rows and columns instead of the ambiguous x and y (or better said y and x)?
is it better now ?

--
Jérôme Kieffer
tel +33 476 882 445


Fix tests in react-form to work with coming react-18 updates

Description
Fixes #2256
With the coming upgrade to react-18 from react-17, we noticed in react-form there were some failing tests when bumping to react-18. In some tests when calling hitSubmit, the function would trigger async calls which some would not yet finish before the jest expect. So we have decided to await on the hitSubmit function before any jest expect.
These test changes are backwards compatible so it would be fine to merge this in main now, which we can then rebase onto our react-18-react-testing branch and have the failing tests fixed.

Type of change

[x]  Patch: Bug (non-breaking change which fixes an issue)
[ ]  Minor: New feature (non-breaking change which adds functionality)
[ ]  Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist
This is not needed since it is a change in tests.
- [ ] I have added a changelog entry, prefixed by the type of change noted above (Documentation fix and Test update does not need a changelog as we do not publish new version)

Hey Ryan, I tried just now to run all the tests files that include the ones the mention above on my update-react-form-package which was rebased off of the react-18-react-testing branch and only have those changes AND I also switched to the react-18-react-testing branch itself and pulled the latest, and applied the changes from this PR and the tests seem to pass.

It seems to be a flaky test issue, and I can reproduce it sporadically by re-running that test suite. I suspect there's a different promise we need to await and are sometimes resolving it and sometimes not.
Here's a strategy for reproducing it:
# Create a throwaway branch with the combination
git checkout react-18-react-testing
git checkout -b throwaway-branch
git cherry-pick fix-tests-in-react-form-react-18

# Re-build just to be safe
yarn build

# Run the test suite in a loop until it fails
while yarn test --no-watch packages/react-form/; do :; done

It seems to be a flaky test issue, and I can reproduce it sporadically by re-running that test suite. I suspect there's a different promise we need to await and are sometimes resolving it and sometimes not.
Here's a strategy for reproducing it:
# Create a throwaway branch with the combination
git checkout react-18-react-testing
git checkout -b throwaway-branch
git cherry-pick fix-tests-in-react-form-react-18

# Re-build just to be safe
yarn build

# Run the test suite in a loop until it fails
while yarn test --no-watch packages/react-form/; do :; done

Thank you so much for looking into it and giving me such easy steps to follow! I was able to recreate it and added changes to fix the flaky tests!


Add more tests for request modifier

Added a few more tests to the untested methods of the RequestModifer.

Changes Unknown when pulling 416ef7629b86b4a670579457071cf0fd96ad39ed on groyoh:add_tests into ** on vinci-proxy:master**.


Remove Unused Imports

Removed unused imports.
Removed unused variables.

Solves issue #72.

Why did my unit testing fail huh?

Why did my unit testing fail huh?

The "check" variable, although a bit rustic was used to make sure that the user when calling the usage of a GPU without CUDA installed wouldnt throw an error, since Github's CI don't have access to one it failed:
 try:
                check = subprocess.check_output(["nvcc", "--version"]).decode()
                self.calculator = GpuCalculator(qubits, big_endian, prep)
except FileNotFoundError:
                print("ERROR: CUDA NOT INSTALLED. SWITCHING TO BASE...")

Oh if that is the case, then we should just be calling subprocess.check_output().decode() without assigning the return to a variable. It should work then?

@brennanfreeze I see what you are doing now, you are calling a command in subprocess to verify if nvcc is installed. If it isn't the command raises an error and you catch that error. There might be a better way to do this (i am not aware of one). I added the function call and just skipped the variable assignment and it works now. Thanks! 👍🏼

@brennanfreeze I see what you are doing now, you are calling a command in subprocess to verify if nvcc is installed. If it isn't the command raises an error and you catch that error. There might be a better way to do this (i am not aware of one). I added the function call and just skipped the variable assignment and it works now. Thanks! 👍🏼

Pretty much! I agree with you there totally is that isnt using a unused variable, but I think for the time being.


Add leading zeros to chapter names

Fixes #9
This change will allow correct sorting of filenames.

Looks good to me. Thank you @celia-v , I think we're only missing the import for the math module. I cannot test for all cases for this change. Shoutout if there are any issues 👍 .
I can accept this after it has been added, and zeroes is added to the list of parameters in the function docstring. (helpful for me later)


Update README.md

made the roor folder to root folder
Related Issue

the issue is that their is a typing error in the readme file i fixed it
Closes: #404
Description of Changes

Checklist:

[ ] My code adheres to the established style guidelines of this project.
[ ] I have conducted a self-review of my code.
[ ] I have included comments in areas that may be difficult to understand.
[ ] I have made corresponding updates to the project documentation.
[ ] My changes have not introduced any new warnings.

Screenshots

Original
Updated

Please provide any necessary screenshots to illustrate the changes made.

please check and merge my pull request .

Already resolved issue.


When extracting just an api via the config.yaml file, the global policy xml file is extracted as well and shouldn't be.

Release version
v6.0.0-alpha.1.0.8
Describe the bug
My config.yaml is set to only extract an api as follows;
`
apiNames:

demo-conference-api

versionSetNames:
backendNames: [ignore]
diagnosticNames: [ignore]
loggerNames: [ignore]
namedValueNames: [ignore]
productNames: [ignore]
subscriptionNames: [ignore]
tagNames: [ignore]
policyFragmentNames: [ignore]
gatewayNames: [ignore]
groupNames: [ignore]
`
Expected behavior
I expect only the API specification, the API apim config, the api policy, and the api operation policies to be extracted.  In this use case, the developer should only be able to work with the api and it's specific policies.
Actual behavior
Unfortunately, the global policy is also extracted along with the api and it's policies.
Reproduction Steps
Setup an config.yaml file to extract just one api, run the extractor, not that the api and it's policies are extracted and the global policy is also extracted.

And what's even worse is that without this policy.xml file the publisher wants to delete the current policy - fortunately in our case this raises a 403 - but that's the least sensible behavior I would expect when I only define a single extracted API.

Will take a look and get back to you.

API filters only affect items related to specific APIs. Service-level policies sit above APIs and aren't impacted by API filters. Just like product-level policies wouldn't be affected by API filters; if you only extract ApiA, the policy for productB would still be extracted.
If you want to specifically exclude service-level policies, your best bet would be to add a .gitignore entry for rootpath/policy.xml.

And what's even worse is that without this policy.xml file the publisher wants to delete the current policy - fortunately in our case this raises a 403 - but that's the least sensible behavior I would expect when I only define a single extracted API.

Please post here a format of the configuration file that you think would make sense if we were to expand support filtering global level artifacts.

And what's even worse is that without this policy.xml file the publisher wants to delete the current policy - fortunately in our case this raises a 403 - but that's the least sensible behavior I would expect when I only define a single extracted API.

Update: My bad, I had a combination of removing the policy.xml from the last commit and using the last_commit setting, so it made sense. I currently have a FileRemove task that cleans up specific files, but I'll provide an idea for a configuration.

API filters only affect items related to specific APIs. Service-level policies sit above APIs and aren't impacted by API filters. Just like product-level policies wouldn't be affected by API filters; if you only extract ApiA, the policy for productB would still be extracted.
If you want to specifically exclude service-level policies, your best bet would be to add a .gitignore entry for rootpath/policy.xml.


[PE-D][Tester B] Hyphenated names are not supported

Some people's names have hyphens, however the app does not allow these people's names to be entered into the system.

Labels: severity.Low type.FeatureFlaw
original: brianchoon/ped#9

I think fair enough. can accept as a legitimate bug


Unable to adjust elevation on token drag with Drag Ruler

Not fixable unless Drag Ruler fixes its libWrapper compatibility issue. https://github.com/manuelVo/foundryvtt-drag-ruler/issues/310

Unlikely to be fixed until this Drag Ruler issue is resolved.
But Elevation Ruler 0.7.4 adds options in settings to display the Foundry ruler when dragging tokens and to use different highlight colors based on token speed.


Optimising Compile time

I've had a lot of issues with compile times on susyone - using this for Drupal Omega 4 theming.
With the help of a cool ruby guru - operating outside of his core competencies - we got compile down from 1m to 20-30s by making various imports much more specific - much better but still unacceptable And yes - my code is an @extend free zone.
from GemFile:
 # Sass, Compass and extensions.
  gem 'sass'      # Sass.
  gem 'sass-globbing'           # Import Sass files based on globbing pattern.
  gem 'compass', '= 1.0.0.alpha.19'                  # Framework built on Sass.
  gem 'compass-validator'       # So you can `compass validate`.
  gem 'compass-normalize'       # Compass version of normalize.css.
  gem 'compass-rgbapng'         # Turns rgba() into .png's for backwards compatibility.
  gem 'susy', ">=2.0"           # Susy grid framework.
  # gem 'singularitygs'         # Alternative to the Susy grid framework.
  gem 'toolkit', '~>2.0'                 # Compass utility from the fabulous Snugug.
  gem 'oily_png'                # Faster Compass sprite generation.
  gem 'css_parser'              # Helps `compass stats` output statistics.

Ideally I'd just be using libSASS for uberfast compiles, via codekit 2.0, but this isn't at all straightforward either, and there's no surety that sourcemaps are supported yet, operating in codekits 'hybrid' libsass/ruby approach.
There is a lot of info out there on optimising for better css, but not actually for the compile time. So if anyone has any general guidelines for optimizing compiling - it would be great to hear 'em.

Any improvements on this issue? We also recognized the compile time issues especially with the span mixin which gets used pretty often. This single mixin eats up all the compile time improvements of the switch to libsass. (more about this can be found here: #465) At the moment our @include span calls make up 90% of the whole sass compile time.

@DenisMir - latest susy is libsass friendly:
http://www.zell-weekeat.com/gulp-libsass-with-susy/

@SachaMPS
Well I got the same problems when skipping grunt and using node-sass directly.

@DenisMir: Sorry, i didnt read your previous message correct.

@SachaMPS Ok fine. :-) I'm just wondering why this is no problem for other users of susy. Each @include span call adds 20ms to the compilation time with libsass. (50ms would be the compilation time in total without the span calls)

I'm experiencing this problem too. What is the current situation here?

Is this issue still relevant?

In my opinion no more since susy works perfectly with libsass

We won't be making major changes to this in Susy 2. We should do what we can to follow best performance practice for v3.

Very surprised that this got closed so quickly. Susy definitely has a performance problem, even when using libsass (it just takes more spans...). Applying several performance optimization (see idlfloods comments) helps - but so far they are not integrated in the master branch. I wonder why...

We are addressing this - just not as a bug fix. The major issues are so engrained in v2 that any suitable fix would require changes to the API (removing nested maps, etc) or massive restructuring. So far none of those optimizations are actually ready for merge, but v3 is coming along nicely in the three branch. There, we can address all the performance issues from the ground up in slimmer, with more modular code.

Thanks for the explanation! Good to know about the three branch...

Just found this thread, super helpful for some local compile times we've been seeing. Love Susy and now we're looking forward to v3 even more. :)

I just ran a rough benchmark test comparing v2 span() function with v3 susy-span() function. Don't worry, that name-spacing will be removable. Here's the test:
// Susy Two
@for $i from 1 through 500 {
  $span: span(3em);
  $span: span(3);
  $span: span(3 at 2);
  $span: span(6 'wide');
  $span: span(2 'static' ('column-width': 5em));
}

// Susy Three
@for $i from 1 through 500 {
  $span: susy-span(3em);
  $span: susy-span(3);
  $span: susy-span(3 at 2);
  $span: susy-span(6 'wide');
  $span: susy-span(2, $math: 'static', $column-width: 5em);
}

That's 2500 function calls each — much larger (I hope) than your average project. I ran the tests three times (to account for variation) in Ruby Sass (for worst case) with the following results:
Susy Two

41.192s
37.719s
41.070s

Susy Three

8.529s
8.293s
7.972s

Unless I'm missing something, I think we're on the right track. We have eliminated several known performance issues:

no more nested maps anywhere
validation is never duplicated (this shaved a second or two off the time in v3)
the parser doesn't use nested loops for comparing keywords
there is less shorthand syntax to parse (only tested in the final function)

It might be fun to compare some other bits (like the parser, settings-access, or Su updates) to see where we're saving most of that time.

\o/

And that's not to say we're done tracking down The Slow Things :)

Oh my  :O

This is awesome! LibSass is also getting a speed boost in 3.3 so this will fly!

@ericam noticed that development on three stopped few weeks ago (no commits pushed), wanted to checkin on the status and see if it's still in the works. Really excited about the performance gains! Thanks

@jasonsemko The core is all done, and then work picked up heavily for me. In my dream world, everyone uses those core functions to build their own mixin system. I'm not sure if that's realistic - so the next step would be building a few simple systems for people to choose from. Any interest in helping make that happen?


Explain the Node.js-specific documentation

The Datadog API Reference doesn't work for Apps out of the box.
We note down that it's not a straight-shot and will take a bit of work.
Hopefully, this will be addressed by the API client becoming usable in the browser.

Thanks for the review!


Chassis and Host state services show incorrect states when targets exit

The chassis and host code monitors for certain targets to reach "JobRemoved" to know when a target has completed.  This works great initially when the target is run.   But later, when the target is stopped, we get this same event.  This doesn't really hurt anything but it's confusing in the journal because you're stopping the target (i.e. powering down) and you see a journal log indicating we powered on.  Later in the power down process, we get the correct journal entries but still confusing initially.

oops, wrong repo.


[dvsim] Remote copy update

This change drops the --archive to avoid rsync running chgrp
to preserve the group associations at the dest, which is not needed.
It also uses checksum match instead of time and size to determine if sources at destination
need to be updated, which shaves off a few seconds.
Signed-off-by: Srikrishna Iyer<EMAIL_ADDRESS>

@tjaychen, @weicaiyang, I am not sure if you can reproduce the error you were seeing earlier. But in theory, with this change, rsync should not attempt to run chgrp or chmod after the copying is done, the assumption being the dest partition is also owned by $USER.

@tjaychen, @weicaiyang, I am not sure if you can reproduce the error you were seeing earlier. But in theory, with this change, rsync should not attempt to run chgrp or chmod after the copying is done, the assumption being the dest partition is also owned by $USER.

I don't have that error now. But I tried this and it works for me.

@tjaychen, @weicaiyang, I am not sure if you can reproduce the error you were seeing earlier. But in theory, with this change, rsync should not attempt to run chgrp or chmod after the copying is done, the assumption being the dest partition is also owned by $USER.

@sriyerg
That error appears again in my side and this PR resolves it.
This is the original rsync command we used and it has errors.
rsync --archive --update --executability --inplace keymgr_sim_cfg.hjson /edascratch/weicai-opentitan/ot/
rsync: [receiver] chgrp "/edascratch/weicai-opentitan/ot/keymgr_sim_cfg.hjson" failed: Invalid argument (22)
rsync error: some files/attrs were not transferred (see previous errors) (code 23) at main.c(1330) [sender=3.2.3]

This new one is executed without any error.
rsync --recursive --links --checksum --update --inplace  keymgr_sim_cfg.hjson /edascratch/weicai-opentitan/ot/

@tjaychen, @weicaiyang, I am not sure if you can reproduce the error you were seeing earlier. But in theory, with this change, rsync should not attempt to run chgrp or chmod after the copying is done, the assumption being the dest partition is also owned by $USER.

@sriyerg
That error appears again in my side and this PR resolves it.
This is the original rsync command we used and it has errors.
rsync --archive --update --executability --inplace keymgr_sim_cfg.hjson /edascratch/weicai-opentitan/ot/
rsync: [receiver] chgrp "/edascratch/weicai-opentitan/ot/keymgr_sim_cfg.hjson" failed: Invalid argument (22)
rsync error: some files/attrs were not transferred (see previous errors) (code 23) at main.c(1330) [sender=3.2.3]

This new one is executed without any error.
rsync --recursive --links --checksum --update --inplace keymgr_sim_cfg.hjson /edascratch/weicai-opentitan/ot/

Thanks for confirming! I assume the sims are passing with this change as well?


Age Calculater

Added Age Calculater

Check this one.

this pull request doesn't contain any files or changes...please make a valid pull request


Add  memory option to CLEAR

Should allow CLEAR  where memory above  is not used. Resets the stack etc. Error if  > free memory, or  in code space + a little RAM space.

Implemented


Vendor kubernetes-1.15.0

Let's not do this for now so that we first can get rid of the gardener-extensions-fixes branch. In order to do this we have to solve https://github.com/gardener/gardener-extensions/issues/163 so that we can update the Kubernetes version in gardener/gardener-extensions to kubernetes-1.14 (basically, the same version that gardener/gardener's master branch is currently referencing). After that we can hopefully can get rid of the mentioned branch, and then update both to kubernetes-1.15.0. In the future, we should try to make gardener/gardener-extensions independent of the Kubernetes version referenced by gardener/gardener.

@adracus , @rfranzke should we wait for kubernetes-sigs/controller-runtime#495 or it is not a hard dependency for this issue?

Most probably we have to wait, otherwise we end-up with the same problems we have seen in the past, I assume.

/assign @ialidzhikov

My plan is first to update to<EMAIL_ADDRESS>then to<EMAIL_ADDRESS>and kubernetes-1.15.

Sounds good, thanks

I will rename the issue to be kubernetes-1.16.

Fixed with #1737


Default form-adapter

The default form-adapter should be the base adapter.
This ensures that all addon users update their default adapter in the config file.

I've decided against doing this. Since this addon was originally built for use with ember-changeset I don't see any reason to change this. As long as the README is well documented this should be fine.


Dependence on Dictionary ordering in Kitura tests

Context and Description
The Kitura tests contain a handful of tests that return an array, and then test that the returned array is equal to some expected value.  The creation of this array has a dependency on the ordering of iteration of elements from a Dictionary, as it is created using dictionary.map { $0.value }:
The dictionary in question is created with the same three elements each time:
https://github.com/IBM-Swift/Kitura/blob/2.5.6/Tests/KituraTests/TestCodableRouter.swift#L62
In Swift 4.2 and earlier, this worked because the hash value of strings is fixed for each execution, and so although the ordering varies across executions, within any one test run it was consistent.
In Swift 5, it appears that each Dictionary instance has its own randomness added to the hashing, so creating the same dictionary over and over yields different ordering.
This is a problem when KituraTestBuilder re-executes the same test again, with the same expectations, but with SSL enabled.  Between the tests, to reset any side-effects (such as modification to this dictionary), it calls setUp() to create it afresh:
https://github.com/IBM-Swift/Kitura/blob/2.5.6/Tests/KituraTests/KituraTest.swift#L85
This has the effect in Swift 5 of randomising the order, whilst the array copy of the previous dictionary (stored within the expectation) still has the old order.  The second (SSL) execution of the test is likely to fail.
I've modified the test above to use a fixed array order in the issue.swift5 branch here:
https://github.com/IBM-Swift/Kitura/commit/8f9e8e146477f7ed1f1ad22a0234823126323608
The same sort of fix needs to be applied to other tests that are failing for the same reason - I believe these are:

TestTypeSafeMiddleware testSingleMiddlewareGetIdentifierCodableArray
TestTypeSafeMiddleware testMultipleMiddlewareGetIdentifierCodableArray

Environment Details
Information about your OS, Swift version and Xcode version if on macOS.
Steps to Reproduce

...
...
etc

Expected vs. Actual Behaviour

[ ] Expected to happen...
[ ] Actually happened...

Fix raised in PR here


Sneak + Rightclick with a block/item in hand on a block with an inventory/UI works wrongly

Minecraft: 1.12.2
Forge: <IP_ADDRESS>11
Valkyrien Warfare: ValkyrianWarfareRevamped-1.12.2-v0.9_alpha-full
Other mods:
Hwyla: 1.8.23-B38_1.12
Just Enough Items (JEI): 1.12.2-<IP_ADDRESS>
(Also tested both with and without: Advanced Rocketry 1.12.2-1.2.6-54)
Normally, in minecraft, when holding a block, such as a hopper, in your main hand, if you sneak while rightclicking with it, it will place the block, even if your crosshairs are pointed at a block with an inventory or UI like a Chest, or Furnace.
With Valkyrien Warfare installed, instead, the block is not placed, and instead the UI for the targetted block is opened instead.
This also interferes with Advanced Rocketry's "Linker" tool, which is a held item that records the coordinates of blocks you shift-right-click-on, for the purposes of helping them interact with that mod's rocket entities. Most of them are blocks with inventories/UI's. The linker fails to record any coordinates.
Thanks for your time and consideration.

I think I saw something about this a while back but was unable to reproduce it. I'll dig around and see what I can find :D

Should be fixed.

Thanks a bazillion! :D


Simple 'if' statements on '0' inconsistent with documentation

Documentation:
In the simplest form you can use it to test if a variable is not empty
via http://twig.sensiolabs.org/doc/tags/if.html

Example:
{% set myvar = 0 %}

{% if myvar %}
    yes
{% else %}
    no
{% endif %}

{% if myvar is not empty %}
    yes
{% else %}
    no
{% endif %}

Expected Output:
yes yes
Actual Output:
no yes

I have tweaked the documentation (087df0513e590c582d1ca8ad321e98540654f9a7). Note that there is already a mention on how to test if a variable is defined or not.


KAFKA-13649: Implement early.start.listeners and fix StandardAuthorizer loading

Since the StandardAuthorizer relies on the metadata log to store its ACLs, we need to be sure that
we have the latest metadata before allowing the authorizer to be used. However, if the authorizer
is not usable for controllers in the cluster, the latest metadata cannot be fetched, because
inter-node communication cannot occur. In the initial commit which introduced StandardAuthorizer,
we punted on the loading issue by allowing the authorizer to be used immediately. This commit fixes
that by implementing early.start.listeners as specified in KIP-801. This will allow in superusers
immediately, but throw the new AuthorizerNotReadyException if non-superusers try to use the
authorizer before StandardAuthorizer#completeInitialLoad is called.
For the broker, we call StandardAuthorizer#completeInitialLoad immediately after metadata catch-up
is complete, right before unfencing. For the controller, we call
StandardAuthorizer#completeInitialLoad when the node has caught up to the high water mark of the
cluster metadata partition.
This PR refactors the SocketServer so that it creates the configured acceptors and processors in
its constructor, rather than requiring a call to SocketServer#startup A new function,
SocketServer#enableRequestProcessing, then starts the threads and begins listening on the
configured ports. enableRequestProcessing uses an async model: we will start the acceptor and
processors associated with an endpoint as soon as that endpoint's authorizer future is completed.
TODO: need to add an additional test case in QuorumControllerTest

I made two changes just now:

Fixed it so TenantPartitionAssignor ignores fenced brokers, and added a unit test for this (as we discussed offline)

Removed ClusterMetadataTest#testNodeReplicaCountsForExistingTenantTopicWithInvalidAssignment and replaced it with  ClusterMetadataTest#testNodeReplicaCountsForUnregisteredBrokers. Basically, the assumptions of the old test were invalid (it is actually possible to have partitions placed on brokers that are no longer in the cluster).

Looking at the code, I see that it already took this into account when computing the nodeMetadata:
    String tenantPrefix = tenant + TenantContext.DELIMITER;
    for (Iterator<String> iterator = cluster.topicNames(); iterator.hasNext();) {
      String topic = iterator.next();
      boolean isTenantTopic = topic.startsWith(tenantPrefix);
      for (List<Integer> replicas : cluster.replicasForTopicName(topic)) {
        for (int i = 0; i < replicas.size(); i++) {
          Integer replica = replicas.get(i);
          NodeMetadata nodeMetadata = nodeMetadatas.computeIfAbsent(replica, node -> new NodeMetadata());
          nodeMetadata.incrementReplicas(i == 0, isTenantTopic);
        }
      }
    }

So the code was already handling this case smoothly, which is what we want. But the very artificial unit test (injecting a null into the replicas array, which wouldn't happen in a real Cluster object) was confusing the issue. Hopefully this clears up the issue.


Clipboard image pasting not working correctly due to plainText check before

Is there an existing issue for this?

[X] I have searched the existing issues

Flutter Quill version
11.0.0-dev.12
Steps to reproduce

Install the example from https://github.com/singerdmx/flutter-quill/blob/master/example/lib/main.dart
Get image into clipboard, for example by taking a screenshot on Android
Paste the image into the editor
Image data is transcribed as plain text and is not inserted as image block

Expected results
Insert an image if "onImagePaste" is defined. (Currently only works with network images / img urls)

On the video is expected result, fixed locally.
https://github.com/user-attachments/assets/c202ba4e-8881-4283-99a8-34fe9d70f838

Actual results
Currently that will be ignored due to check of "plainText", which is not null when we have image data in clipboard.

Here is the video with current result
https://github.com/user-attachments/assets/5f557de6-d858-4cdc-aac2-0ed7bdd04825

Additional Context
No response

This is the same issue as #2323?

After double checking you are right, the issue & source of problem seems to be the same. I probably overlooked it due to phrasing before creating my own issue.

The image URL will be stored in the document JSON, and how it will be loaded depends on your image embed implementation. If you're using flutter_quill_extensions, you can overimage provider builder.

What I meant with that the current implementation only works with network images is that when we grab the image from the web it gets the "image url" property which is pasted as plain text and then rendered within the image embed. If you would pass an image from paint, like in #2385 , the mechanism doesn't work.
And probably my wording was incorrect here:

Insert an image if "onImagePaste" is defined. (Currently only works with network images / img urls)

Since the image pasting still worked via plainText and not onImagePaste in case with network images.


Content jumps in NavigationBar and StatusBar is visible

When I have a  StatusBar and NavigationBar visible the card jumps on user interactions. Also when I return from the TableViewController the vertical offset is not quite correct.
Is it possible to use this component with StatusBar and NavigationBar visible?

I didn't implement it. I hope fix it soon

example with navigation bar in  with-navigation-bar branch


Results are not reproducible

Hi, I ran your code on my own server, the results are:
[No distill]
10000/10000 [==============================] - 8s 783us/sample - loss: 7.5134 - acc: 0.9085accuracy: 90.85% | loss: 7.513414146804809
10000/10000 [==============================] - 8s 785us/sample - loss: 7.5161 - acc: 0.9032
accuracy: 90.32% | loss: 7.516079863357544
[distill with soft target]
Saving trained model to assets/distilled/tree-model.
10000/10000 [==============================] - 7s 711us/sample - loss: 7.7522 - acc: 0.8254
accuracy: 82.54% | loss: 7.7521795679092405
10000/10000 [==============================] - 8s 758us/sample - loss: 7.7434 - acc: 0.8189
accuracy: 81.89% | loss: 7.7433844789505

I also modify the code from https://github.com/kimhc6028/soft-decision-tree
Surprisingly, with depth 4, the results are the same. I.e., before distill 90%, after distill 80%.


[TW#16426] Documentations lacks examples on how to read Hall sensor from ULP co-processor

As I understand, before doing readings from pin 0 and 3, you have to set up Hall configuration registers in a certain way. Current register spec does not explain that in detail.

Good point about adding such an example, we'll add it along with ULP I2C example.
In the meantime, I think TRM does have the information you are looking for:

Pins should be initialized same was as for ADC (see ulp_adc example),
Hall sensor power on and phase should be controlled by ULP (SENS_HALL_PHASE_FORCE=0, SENS_XPD_HALL_FORCE=0),
ADC should be controlled by ULP (adc1_ulp_enable(), same as in ulp_adc example).
After that you should be able to use ADC instruction of the ULP. Per TRM, Sel=0 (for ADC1), Sar_Mux = 9 returns the result for phase 1, Sar_Mux = 10 returns the result for phase 0.

I make an example here: https://github.com/espressif/esp-iot-solution/tree/master/examples/ulp_examples/ulp_hall_sensor , FYI.

Does it is possible to have such type of example (especially the Readme.md) in English and not Japanese/Chinese ... ?

https://github.com/espressif/esp-iot-solution/blob/master/examples/ulp_examples/ulp_hall_sensor/readme_en.md, update english doc.

@FayeY Try to close this issue.


Not fully working with JEI

Vanilla Tweaks Version:  1.5.2
MinecraftForge Version: <IP_ADDRESS>.38
Minecraft Version: 1.12.2
(Optional) Just Enough Items (JEI) Version: <IP_ADDRESS>1
Client or Server?:

[x] Client
[ ] Server

What happens / happened?: Items show up in Just Enough Items (JEI) even if disable them, and items don't show recipes
How can the issue be reproduced?: I'm not sure if you can or if it's JEI that need to fix this
Suggestion 1 Maybe also change it so if you disable a crafting recipe it also disables the item altogether and removes it from set tab it's in and can't generate within the world?
Suggestion 2 Have in the config file a to modify the min or max level for enchanting

It is intended that the items show up in JEI as removing registry things is not recommended by forge thus config only disable the recipe. Min/max level for enchantments for config would cause some enchantments to malfunction thus i am not implementing it.


Upgrade with --reuse-values breaks values set with --set-file when using a binary file

Output of helm version: version.BuildInfo{Version:"v3.2.3", GitCommit:"8f832046e258e2cb800894579b1b3b50c2d83492", GitTreeState:"clean", GoVersion:"go1.13.12"}
Output of kubectl version: Client Version: version.Info{Major:"1", Minor:"18", GitVersion:"v1.18.2", GitCommit:"52c56ce7a8272c798dbc29846288d7cd9fbae032", GitTreeState:"clean", BuildDate:"2020-04-16T11:56:40Z", GoVersion:"go1.13.9", Compiler:"gc", Platform:"windows/amd64"} Server Version: version.Info{Major:"1", Minor:"16+", GitVersion:"v1.16.8-eks-e16311", GitCommit:"e163110a04dcb2f39c3325af96d019b4925419eb", GitTreeState:"clean", BuildDate:"2020-03-27T22:37:12Z", GoVersion:"go1.13.8", Compiler:"gc", Platform:"linux/amd64"}
Cloud Provider/Platform (AKS, GKE, Minikube etc.): EKS
Scenario: I want to use --set-file to pass in a binary file, like a certificate, as a value, which I then use in a secrets.yml template, which base64 encodes the file into a secret. In my deployment I mount that secret as a volume into my container, and my service reads it.
This works great for install, and great if I pass the file in via --set-file again on upgrade, but if I don't pass the file in again and rely on --reuse-values the file is mangled, with ton's of random garbage in the resulting base64, like +/ve and +977 all over the place. If I pass in a file via --set-file that's just ASCII text (even if the text is very large, much larger than the certificate), the value is reused just fine, so it does appear to be an issue with the binary file and how it's reused by --reuse-values.
https://github.com/helm/helm/issues/4131#issuecomment-592018120 mentions this, but that issue is closed so I figured it might not receive any more responses.

Thanks Matt! I don't have a ton of time or any Go/Helm internals knowledge right now, but if I do have some time free up I'll try to take a crack at it.

@srajkovic  I can't repeat the question. Can you give me an example?

Sorry, I haven't had a chance to make a small repro project. I did notice on upgrades I get this error:
USER-SUPPLIED VALUES:
Error: unable to write YAML output: error converting JSON to YAML: yaml: control characters are not allowed
helm.go:84: [debug] error converting JSON to YAML: yaml: control characters are not allowed
unable to write YAML output
helm.sh/helm/v3/pkg/cli/output.EncodeYAML
        /home/circleci/helm.sh/helm/pkg/cli/output/output.go:110
main.statusPrinter.WriteTable
        /home/circleci/helm.sh/helm/cmd/helm/status.go:138
helm.sh/helm/v3/pkg/cli/output.Format.Write
        /home/circleci/helm.sh/helm/pkg/cli/output/output.go:56
main.newUpgradeCmd.func1
        /home/circleci/helm.sh/helm/cmd/helm/upgrade.go:153
github.com/spf13/cobra.(*Command).execute
        /go/pkg/mod/github.com/spf13/cobra@v1.0.0/command.go:842
github.com/spf13/cobra.(*Command).ExecuteC
        /go/pkg/mod/github.com/spf13/cobra@v1.0.0/command.go:950
github.com/spf13/cobra.(*Command).Execute
        /go/pkg/mod/github.com/spf13/cobra@v1.0.0/command.go:887
main.main
        /home/circleci/helm.sh/helm/cmd/helm/helm.go:83
runtime.main
        /usr/local/go/src/runtime/proc.go:203
runtime.goexit
        /usr/local/go/src/runtime/asm_amd64.s:1357

So maybe the issue is in whatever serializes the secret back to YAML, it doesn't escape control characters (which happen to come up in a binary file like a certificate). Maybe the value Helm is storing (for reuse with --reuse-values) in the cluster is actually the stack trace or something?

See #8373 for a failing test case.


Ensure all tests use unique IP ports

What does this PR do
Checklist:

[x] I have read CONTRIBUTING.md
[x] I have written necessary tests and rustdoc comments
[ ] A change log has been added if this PR modifies nix's API

There still seems to be tests that are using the same port 8080 in src/sys/socket/addr.rs:
https://github.com/nix-rust/nix/blob/dbdcfed86e18673c71b54d4c4cd7be289441843c/src/sys/socket/addr.rs#L2560-L2597

BTW, If we want to maintain this state, what about defining some helper type like:
/// Helper type for ensuring all ports used in tests are unique
struct PortAllocator {
    next: AtomicU16,
}

impl PortAllocator {
    pub fn allocate_port(&self) -> u16 {
         self.next.fetch_add(1, Ordering::Relaxed)
    }
}

Though it may be easier to clash (with the ports used on developer's host) comparing to manually-specified ports

In the case of the 8080 ports, you'll notice that none of those tests actually bind to the ports in question.  So there's no real conflict.  Regarding the allocator, I've wondered about that too.  But I wonder if the addition of the allocator would obscure the function of some of the tests.  Do you think so?

In the case of the 8080 ports, you'll notice that none of those tests actually bind to the ports in question. So there's no real conflict.

Yeah, that's right, they are not in actual use. I saw the changes in src/sys/socket/addr.rs, which made me think we should also handle such cases, but since they are not in use, let's ignore them

Regarding the allocator, I've wondered about that too. But I wonder if the addition of the allocator would obscure the function of some of the tests. Do you think so?

Emmm, I am not sure about this:D, would you like show me a brief example demostrating your worries?

Regarding the allocator, I've wondered about that too. But I wonder if the addition of the allocator would obscure the function of some of the tests. Do you think so?

Emmm, I am not sure about this:D, would you like show me a brief example demostrating your worries?

I'm just thinking about readability for somebody not highly familiar with this project.  Code like this:
let addr = SockaddrIn::from_str("<IP_ADDRESS>:1234");

is a lot more obvious than this:
let addr = crate::port_allocator::next();

I'm just thinking about readability for somebody not highly familiar with this project. Code like this:

Yeah, if we do something like this, we should document it well.

I'm just thinking about readability for somebody not highly familiar with this project. Code like this:
let addr = SockaddrIn::from_str("<IP_ADDRESS>:1234");

is a lot more obvious than this:
let addr = crate::port_allocator::next();

Indeed, the old one is clearer, but will we also do this to IP address?   It should be something like this if we only do this to ports:
let port = PORT_ALLOCATOR.next();
let addr = SockAddrV4::from_str(&format!("<IP_ADDRESS>:{port}")).unwrap();

Either way would work.  What do you think is best?

I think we should add a port allocator because manually maintaining the state is too hard, and conflicts are difficult to catch as well since tests are running concurrently.
For the readability issue, it should not be that bad if we only do this to ports:

let addr = SockAddrV4::from_str(&format!("<IP_ADDRESS>:{port}")).unwrap();

BTW, is there any guideline on when a test should be put in src/xxx.rs or test/test_xxx.rs, if not, we should probably make this clear, e.g.,
Tests for public Nix interfaces should all be placed under test, leaving only tests for private stuff within its own module.

BTW, is there any guideline on when a test should be put in src/xxx.rs or test/test_xxx.rs, if not, we should probably make this clear, e.g.,

Not really.  Nix has so many contributors; it seems like each has placed tests according to his preference.  For me personally I have a rule that I like to use, but it doesn't really apply to Nix.

Tests for public Nix interfaces should all be placed under test, leaving only tests for private stuff within its own module.

:+1:

Should we merge this PR? I think it is ok to do that port allocator thing in the future

Should we merge this PR? I think it is ok to do that port allocator thing in the future

Yeah, I think so.  Would you approve it please?


Material errors when building DZO files

Console is spammed with material errors when attempting to build DZO files for blackwater city. Possibly related to instanced collision materials?

I realized this wasn't actually blocking the dzo build either, but just as an FYI.

Fixed in e7867899d2fd44276d46a8304438a1d174e07e00


Gulp

Is it possible for me to use this buildpack for a PHP app, but during the postdeploy phase, get gulp to build assets?

@Soulou any advice?

Hi @jbrooksuk, sorry for the delay
Yes you can run any command you wish after PHP/node installation, just define them in your compose.json in:
{
  ...
  "extra": {
    "paas": {
      "compile": [
        "gulp bundle"
      ]
    }
  }
}

So I just add gulp to my dependencies and this will work?

Yes that's it !

Ok, thanks!

What about bower? Can I install that as a dependency and add it to the compile array?

Yes that's exactly the same

When it's building my app it says bower isn't a command. It's a dependency though.
Sent from my iPhone

On 4 Jan 2015, at 10:04, Soulou<EMAIL_ADDRESS>wrote:
Yes that's exactly the same
—
Reply to this email directly or view it on GitHub.

I'll take time to build an example to show you =)

Cheers!

For now, I've forked the buildpack and manually install it.

Hi again @jbrooksuk

You can find a sample application using PHP Slim framework. It handles assets compilation with bower and gulp as you were asking: https://github.com/Scalingo/sample-php-nodejs
The application is live here: http://sample-php-nodejs.scalingo.io


Circuit construction

Problem: Insertion or appending operations or moments into circuits come with a rich number of options (insert, insert_into_range, etc) as well as different behaviors in the form of insertion strategies.  For advanced users this power can be useful, but for many users, it results in them not being able to transform their thinking into what they expect to happen (in part because the effects are non-local and so hard to reason about as the size of the “action” grows).  This also has a direct impact on optimizers, which are mutating circuits, and where these insertion patterns can interact in strange ways if not done carefully.  The goal of solving this problem is to either modify existing or define new methods to aid in the construction of circuits and lessen the complexity of these notions.  Alternatively there could be other structures which aid in common construction patterns, Circuit builders.  This could be aided by the solution to Subcircuits (#3235).
Rough requirements:

Augment or modify existing creation APIs to simplify the construction, or create helpers that make this easier.
Standardize examples and tutorial code to simplest methods
Be able to construct appropriate groups as defined in Subcircuits

TODO: scope this and figure out whether we want to keep it or merge it with Transformers API items

@tanujkhattar I recommend closing this in favour of more specific issues


Gemma integration

Hi
can you also implement gemma model to compare with llama
best regards

@Isaina open query_vdb.py and replace:
- 36 model, tokenizer = load("mlx-community/NeuralBeagle14-7B-4bit-mlx")
+ 36 model, tokenizer = load("mlx-community/quantized-gemma-2b-it")

Can YOU also support mlx on Intel macos platform

@Isaina no, mlx was create for Apple silicon

            Ok thanks for gemma information On 05.04.2024. at 18:50, Abe Estrada wrote:

                From: "Abe Estrada"<EMAIL_ADDRESS>5 April 2024To: "vegaluisjose/mlx-rag"<EMAIL_ADDRESS>"Mention" ***@***.***>,"Isaina"<EMAIL_ADDRESS>Re: [vegaluisjose/mlx-rag] Gemma integration  (Issue #4)

@Isaina no, mlx was created for Apple silicon
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>


Read EOS token from model runtime information for speculative_decoding_lm

Extension to issue #277, Added the functionality to read EOS token from model runtime information in the speculative_decoding_lm.

@ilya-lavrenov this is the PR corresponding to the change we discussed.

The readme does not contain proper instruction for running speculative_decoding_lm. in the example, it runs the "Llama-2-7b-chat-hf" model as the main model directory;
/build/Release/speculative_decoding_lm ./TinyLlama-1.1B-Chat-v1.0/pytorch/dldt/FP16/ ./Llama-2-7b-chat-hf/pytorch/dldt/FP16/ "Why is the Sun yellow?"
The previous steps do not mention any installation of this model and it also requires extra permission to use this model(model at meta-llama/Llama-2-70b-chat-hf)

The previous steps do not mention any installation of this model and it also requires extra permission to use this model(meta-llama/Llama-2-70b-chat-hf)

Thanks for noticing that. I will update Readme in the next following PRs


Private/Public Keypair generator

Is your feature request related to a problem? Please describe.
It's a bit cumbersome to quickly generate keypairs when making wireguard configurations. Example
Describe the solution you'd like
Would be nice to have a tool that lets me generate a keypair in one click.
Describe alternatives you've considered
For use case of wireguard configs there are various web tools, but it's nicer to have it in a centralized ecosystem of swiss-army devtoys here.
Additional context
Add any other context or screenshots about the feature request here.

Hello,
Thank you very much for your feedback. I'd be honest, I'm not familiar with wireguard, but it sounds interesting. I will keep this issue opened.
Everyone: please upvote this comment to let us know how priority this tool is.

Hi, just one question, because I see it's not mentioned. What keypair are we talking about? There are a lot of different asymmetric encryption algorithms and standards (e.g. keys pem, pkk, id_rsa, openssl). I believe (but may be wrong) that only one of them is considered here, but which one?
I'd be a great fan of all of them, of course, but I know each should have the own issue and PR ;)

I'm afraid, that one huge PR with various algorithms can be too big to implement and review. I'm pretty sure they should be added one-by-one, what is far easier to handle. Especially knowing that some keys can be simply converted to others (e.i. pkk <> pem), and those converters should be included in DevToys too. And again, in separated issue and PR. That's why it'd be good to decide which key pair should be the main/only one in this feature request.
But if I'm wrong, I'm open to discuss other points of view ;)

I guess then a good start would be just this:
https://git.zx2c4.com/wireguard-tools/tree/contrib/keygen-html/wireguard.js


Doc still shows RuleWalker-based rules, which #2552 deprecated

Documentation under https://palantir.github.io/tslint/develop/custom-rules/ should be updated with an example using applyWithFunction instead of the old RuleWalker based example.
TODO

Edit file: https://github.com/palantir/tslint/blob/master/docs/develop/custom-rules/index.md

Ha, yes, indeed.

🤖 Beep boop! 👉  TSLint is deprecated 👈  and you should switch to typescript-eslint! 🤖
🔒 This issue is being locked to prevent further unnecessary discussions. Thank you! 👋


[#2701] Fix OS version checks.

Problem?
OS version checks are broken for Solaris versions older then Solaris 10 and for OS X version 10.10 or newer.
Solution?
Re-factor OS version checks to only compare integers.
Drive-by fix:

avoid confusing Fedora with RHEL or OpenSUSE with SLES.

How to check?
Please review changes (you may ignore style guide fixes).
Run the tests.
Check the logic of bash -x paver.sh detect_os in AIX, Solaris, OS X and supported Linux distros.
reviewer: @adiroiban

needs-review

needs-review

I know that you have worked hard on this  so I am accepting it.
50 lines of codes of which 30% are comments is  a smell of unmaintainable code
For aix we only support aix 5.3 and 7.1... and for solaris only solaris 10... I still think that using a case switch makes the code simpler.
But I also hate Bash (and shell scripting)  so maybe is just me who don't like the shell code :)
Thanks!
approved-at  4a9a209

I also hate code without tests ... and the code from paver.sh has zero tests :(

I know that you have worked hard on this so I am accepting it.

I'm not at all happy with such a reason. Changes should be accepted on technical reasons, not in relation to how long it took and/or how hard it was to write them. And this wasn't much hard work anyway.

50 lines of codes of which 30% are comments is a smell of unmaintainable code

If the new code looks unmaintainable we should make it maintainable.  It would help if you are willing to accept one more global variable in this script. It already has quite a few already… In the same vein, I still think comparing strings is the most straightforward solution here, with a bit of care for special cases like Solaris and OS X. You can see in the changes that, for SunOS, even when comparing integers, I do that already, because we really do not care for the major version. I can do an exception for Darwin too and things would be much simpler. These two changes will get rid of the need for advanced Bash tricks in the new function: IFS and arrays to only compare integers and using eval to return fancy values.

For aix we only support aix 5.3 and 7.1... and for solaris only solaris 10... I still think that using a case switch makes the code simpler.

Our documentation says we support AIX 6.1 and Solaris 11. The fact that we currently only test AIX 5.3/7.1 and Solaris 10 shouldn't be reflected in code that is published for general use. When the logic is that we support AIX 5.3 and newer and Solaris 10 and newer, the code should reflect that. Bash scripting is expressive enough to allow it. And if we wouldn't be so anal about global variables and string comparisons in a shell script we could even do it in a simple way… :)
Anyway, I went full steam and removed the last case $var in in detect_os() for consistency. If you think the whole approach is wrong, let's discuss this and find the optimal solution. Thanks!
needs-review

As long as we don't have a buildslave for an OS we are lying in our documentation and we should fix it.
The documentation should state that is might work on other platforms, but they should contact us.
The download page is more accurate.

Beside technical reason we also have a budget and we should spend the time/money as best as we can.
I don't want to invest to much into paver.sh script so as long as it works I am ok with it.
paver.sh is not used in production so we should be fine if it is not perfect... we can slowly improve it.
Thanks!
approved-at  3038aba


gamepad axes are undefined

xrFrame.session.inputSources[n].gamepad.axes[0] can be undefined even though the gamepad object exists and is not null.
This apparently happens for the Quest Pro emulator, perhaps as a result of using a polyfill.
The Mozilla extension reports a number as required by the gamepad spec.

According to the WebXR Gamepad API spec: https://www.w3.org/TR/webxr-gamepads-module-1/#example-mappings,
gamepad.axes[0] and gamepad.axes[1] are supposed to be the x and y value of touch pad on controllers, quest devices do not have a touch pad, so the value being null or undefined is expected.
If you are looking for the joystick x and y value, they are gamepad.axes[2] and gamepad.axes[3]

Also, according to the spec: https://www.w3.org/TR/webxr-gamepads-module-1/#xr-standard-heading, none of the axes values are required.

@andreasplesch I am closing this issue now, feel free to reopen this if my comments did not fully address your concerns.

Thanks. But I think you missed
https://www.w3.org/TR/webxr-gamepads-module-1/#xr-standard-heading

Devices that lack one of the optional inputs listed in the tables above MUST preserve their place in the buttons or axes array, reporting a placeholder button or placeholder axis, respectively. A placeholder button MUST report 0 for value, false for pressed, and false for touched. A placeholder axis MUST report 0.

So instead of null or undefined the placeholder value must be 0.
This is to make it compatible with
https://w3c.github.io/gamepad/#dom-gamepad-axes
which states:
All axis values MUST be linearly normalized to the range [-1.0 .. 1.0].
as well as https://www.w3.org/TR/gamepad/#dfn-axes
A [sequence](https://webidl.spec.whatwg.org/#idl-sequence) of [double](https://webidl.spec.whatwg.org/#idl-double) values representing the current state of axes exposed by this device

Unfortunately I cannot reopen the issue. Please let me know if I should file a new issue.

Oops! You got me there. I will put up a fix soon!

Glad to help !


Songs getting deleted from auto playlist

For some reason a lot of the songs in the auto playlist are getting deleted from my bot automatically. Then the bot ends up playing only about 3 of the 50 songs I originally put in.

Might be this issue
Refer to #812

whatamike commented a day ago
Same issue for me on ubuntu VM. Just a heads up, it cleared out my autoplaylist file since each song got an error and was removed. Hope you have a backup.

On a related note, the autoplaylist.txt file should probably get backed up if any entries are to be removed.

In the development version of the bot, the autoplaylist is backed up when entries are removed, and the reason for removal is commented in this backed up file. We're aware of the complaints about how the current system works.


feat: Support null safe equals in ExtractEquijoinPredicate

Which issue does this PR close?

Closes #12299.
Rationale for this change
Allow more joins to be executed efficiently.

What changes are included in this PR?
Previously ExtractEquijoinPredicate did not inspect the value of nulls_equals_null for the join before extracting equi join predicates, which was likely a possible source of bugs. The new code will respect null_equals_null if set (and there is a equi join predicate) and if not it will first try to extra Operator::Eq predicates and if none is found it will try to extract Operator::IsNotDistinctFrom equi predicates.
Prev

Are these changes tested?
Yes, using existing and some new test cases.

Are there any user-facing changes?
For queries using IS NOT DISTINCT might have improved query plans.

Converted to draft until I have time to address the feedback and look more into if the requires changes in other rules.


Extreme distortion in multi-lingual voice conversion

The model doesn't seek to work well for foreign languages. Any tips on how can it equally better for foreign-to-foreign U2S voice conversion ?

this answer applies to most vc models.


Add back cell_path support

Found a FIXME comment on line 125 of file crates/nu-command/src/conversions/into/filesize.rs

I think this has been fixed, let's close it.


[Controller/recorder] support pod resource event

This PR is for:

Server

support pod resource event
Checklist

[ ] Added unit test.

Backport to branches

main

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.zhengya seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


gpio: adjust adv function hooks to fix subplatforms

The chardev feature changed the flow for most GPIO functions but did not take into account existing function hooks correctly.
This fixes the checks and restores subplatform GPIO access.
Signed-off-by: Mihai Tudor Panu<EMAIL_ADDRESS>

Sorry, saw this one, but at the end of the day didn't have time to review on the weekend.

No worries, I mainly wanted to point out that subplatforms were broken when we added chardev support. @pylbert is also working on some enhancements to them.


[Feature] Add gtag call utility function for common-react

Describe the solution you'd like
Will be used to track events within google analytics.
https://developers.google.com/analytics/devguides/collection/gtagjs/events

Already has been added


Uninstalling a proxy server

Make a backup of current configs before installing.
Add a command that will uninstall the proxy and rollback to the configs from the backup to get the same server state that was before the proxy was installed.

Make a backup of current configs before installing. Add a command that will uninstall the proxy and rollback to the configs from the backup to get the same server state that was before the proxy was installed.

Done, closed with commit a0c3540cb4be4ca391a32e48f8739c7726409e80.


node-proxy-agent adds a huge amount to load time and installed size

the latest openwhisk npm increased load time tremendously. it also increased the npm install'd size from 1.1MB to 7.5MB
here is the time to load the top-level dependencies in client.js:
messages +1ms
openwhisk_error +1ms
needle +28ms
url +0ms
http +0ms
proxy-agent +119ms

the last bit is the new dependence in the just-released openwhisk
+6.4MB and a huge increase in load time for a dependence that is optional. not to mention that needle supports proxies directly, does it not?
c.f. https://github.com/apache/incubator-openwhisk-client-js/pull/147

it's also worth noting that the tls indirect dependence  (openwhisk -> proxy-agent -> pac-proxy-agent -> get-uri -> ftp -> tls) is seemingly incompatible with webpack builds (note how openwhisk is now loading an ftp library, potentially on each and every function invocation!)

oh damn - thanks for catching this @starpit. Let me look into this and get back to you. This is not ideal!

Looking into this some more... it's clear adding the proxy-agent dependency causes an unacceptable increase in dependency size and load time. I do think supporting HTTP proxies is a valid requirement and we do want to still support this.
https://packagephobia.now.sh/result?p=proxy-agent
Install size has jumped from under 1MB to over 5MB.
<EMAIL_ADDRESS>I have a few ideas about how to resolve this, want to open it up for community involvement to decide the best way forward.

Allow user to pass in exact http.Agent implementation class in constructor, rather than providing the implementation in the library.

Remove proxy-agent dependency and replace with underlying http-proxy-agent and https-proxy-agent deps this project relies on.

Does anyone have any other suggestions?
Given the vast majority of users will not need a HTTP proxy, I'd like to keep the "fast path" as light as possible and this means option 1). seems like the best choice. This does make it a bit more difficult for downstream tools like The Serverless Framework (where the SDK is used implicitly) but that's a trade-off I think we have to make.
I've also opened some other issues to help make sure this kind of issue doesn't happen again and also reduce build size even further.

Since needle has some builtin proxy support and you can pass a custom http agent (documented on the npm page), does that work? Is that what you’re proposing?

@rabbah Yes, that's option 1). User would include proxy they require manually in their app deps and pass that instance to the OW constructor, which we'd pass through to needle.

I agree remove lib dependency and document 2 things with simple example how to initialize ow

how to configure needle proxy
how to configure custom proxy such as http-agent

FYI @karanrk

fwiw, the way i debug load time is by adding a debug call between each require. this is how i got the +xxx ms data above (the numbers were quite stable across runs). there is already an open issue for adding debug calls more generally #120, maybe we can piggyback these interstitial load-time calls on that work item.
then, a fairly straightforward script along with some basic quotas would let us lock down initialization time regressions.


[ALGO] Kahn's Algorithm

Kahn's Algorithm
Kahn's algorithm is used for finding a topological order in a directed graph that has no cycles. The algorithm works by iteratively removing vertices that have an in-degree of zero and removing all outgoing edges from these vertices. The topological order is the sequence in which the nodes are removed.
We already have a function which computes the in-degree of a vertex in graaflib/properties/vertex_properties.h. It would be nice if we could reuse this.
For more details, see the wikipedia entry.
Syntax
The algorithm should have the following syntax:
/**
 * @brief Finds a topological ordering of a directed graph using Kahn's algorithm.
 *
 * Kahn's algorithm works by iteratively removing nodes with an in-degree of zero
 * and all their outgoing edges. The order in which nodes are removed forms the
 * topological order. This implementation returns a vector of vertex IDs representing
 * the topological order.
 *
 * @tparam V The vertex type of the graph.
 * @tparam E The edge type of the graph.
 * @param graph The input directed graph.
 *
 * @return An std::optional containing a std::vector of vertex IDs that make up the
 *         topological order. Returns an empty std::optional if the graph contains a cycle.
 */
template <typename V, typename E>
std::optional<std::vector<vertex_id_t>> kahns_topological_sort(
    const graph<V, E, graph_type::DIRECTED>& graph
);

This should live in the graaf::algorithm namespace under include/graaflib/algorithm/topological_sorting/kahn.h.
Definition of Done
This issue is done when:

[ ] The algorithm is implemented
[ ] The new function has a javadoc-style comment explaining the interface
[ ] Appropriate tests are added under test/graaflib/algorithm/topological_sorting/kahn_test.cpp
[ ] A test coverage of at least 95% is reached
[ ] A documentation entry is added under docs/docs/algorithms under the appropriate category

Just adding a short description and the algorithm syntax here is fine
See the wiki on how to build the documentation locally

[ ] The algorithm is added to the list of algorithms in README.md

@bobluppes
I completed the algorithm as per my knowledge, but when I am compiling the program, it says:
In file included from kahn.cpp:2: ./kahn.h:7:10: fatal error: 'graaflib/graph.h' file not found #include <graaflib/graph.h>          ^~~~~~~~~~~~~~~~~~ 1 error generated.
please help me to fix this
and my code is completed

@bobluppes please assign me to this issue, under hacktober fest
I completed the algorithm as per my knowledge, but when I am compiling the program, it says: In file included from kahn.cpp:2: ./kahn.h:7:10: fatal error: 'graaflib/graph.h' file not found #include <graaflib/graph.h> ^~~~~~~~~~~~~~~~~~ 1 error generated.
please help me to fix this and my code is completed

Hi, of course, welcome to Graaf!
Regarding your issue, maybe you need to reload your cmake config? If the issue persists feel free to reach out in our discord.

hey @bobluppes  have raised a PR regarding this, but 1 check was not completed "Pull-Request-CI / format (pull_request) Failing after 32s"
Can you please help me what I should do here/

hey @bobluppes have raised a PR regarding this, but 1 check was not completed "Pull-Request-CI / format (pull_request) Failing after 32s" Can you please help me what I should do here/

Hi @Dhandeep10, it seems like there are some formatting issues on the PR. You should be able to fix them locally by running clang-format. See this wiki article for more details.
I see there is already some feedback on the PR, let me know if you are still planning on taking this up :)