wait to send low fee transactions until they will be accepted by the electrum server

In https://github.com/sparrowwallet/sparrow/issues/847 I was asking for a way to manually rebroadcast transactions that were accepted by the electrum server you are connected to, but then is later pushed out of the electrum server's mempool. When that happens you don't know if all the other nodes have also forgot about the transaction and the transaction may never get confirmed (even if fee market dynamics change and fee rate of the transaction later becomes high enough).
The issue was closed because it seems as though even if just a few nodes out there have a huge mempool, you might be okay and the transaction may eventually reach a block. I'm not sure if that will always be the case, so https://github.com/sparrowwallet/sparrow/issues/847 may need to be reopened in the future.
Another scenario is you want to broadcast a transaction with a fee rate that is much lower than what will be accepted into the mempool of the electrum server that you are connected to. The most obvious scenario is moving funds in and out of cold storage where you have a low time preference for processing and a high fee preference (wanting a low fee).
Currently, if the transaction you are trying to submit won't fit in the mempool, Sparrow Wallet will give you an obscure error (and you need to look at the log files to see why the electrum server is rejecting the message). Then you need to completely start your transaction over and try to increase the fee and sign a new transaction. Or, you need to wait and manually rebroadcast that raw transaction some other way.
I think Sparrow Wallet should properly check to see if the transaction is going to fit in the mempool of the electrum server, and if it won't, rather than trying and failing, let the user know that it won't be accepted right now. Then, give them two options:

Don't let them broadcast the signed transaction right now, tell them they need to wait for fees to drop before they can try to broadcast.
Schedule the signed transaction for broadcast when fees drop, telling them they need to leave Sparrow Wallet open for this to be possible.

At the very minimum, it would be nice when creating an unsigned transaction to make it more explicit when selecting the fee that the fee they are choosing will be rejected by the server. Right now, if you put it below "try then replace" it says "below minimum". I think the "below minimum" message should be changed to something that is more clear like "your electrum server will not accept this transaction".
There is some related discussion in https://github.com/romanz/electrs/issues/397 about having the electrum server do the scheduling. I think that both a wallet and electrum server based solution are going to be best in order to address all types of users because there will be some people using private and some people using public electrum servers.

Then you need to completely start your transaction over and try to increase the fee and sign a new transaction.

Not true, you can just go back to the Send tab and adjust the fee. Obviously you will need to resign as it is now a different transaction.

Sparrow Wallet will give you an obscure error (and you need to look at the log files to see why the electrum server is rejecting the message)

I specifically do not show the obscure error returned by Bitcoin Core (or indeed any message from the connected server) since that has been proven to be a way to fool and defraud users. You may wish to look into the "Electrum 4" debacle, which was specifically caused by leveraging this attack vector.
That said, I've made a fair bit of progress in decoding the cryptic Bitcoin Core errors and presenting them nicely (in my own language) in recent versions, especially when it comes to insufficient fees.

Right now, if you put it below "try then replace" it says "below minimum".

Unfortunately the current purge rate is not provided by the Electrum server. It is only provided at this time if you configure mempool.space as your fee rate provider. In other words, this data cannot be generally relied upon to be present. In addition, if you are connected via Tor, Sparrow will broadcast using a random external service over Tor (like blockstream or mempool.space) resulting in a successful broadcast since the mempool there is unconstrained.

Don't let them broadcast the signed transaction right now, tell them they need to wait for fees to drop before they can try to broadcast.

This is what Sparrow already does:

Schedule the signed transaction for broadcast when fees drop, telling them they need to leave Sparrow Wallet open for this to be possible.

With the exception of Whirlpool (which is why I wrote Sparrow Terminal), I do not believe it is a good idea to encourage users to leave Sparrow open for long periods. Sparrow is a client, not a server, and leaning too far into "always on" requirements may lead to undesirable outcomes, like transactions unexpectedly not getting broadcast. As you suggest, it is better for the server to handle these kind of requirements from an engineering perspective. Unfortunately, there is no support for this right now in the Electrum protocol, which is where this feature would need to start imo.

Right now, if you put it below "try then replace" it says "below minimum".

Unfortunately the current purge rate is not provided by the Electrum server. It is only provided at this time if you configure mempool.space as your fee rate provider. In other words, this data cannot be generally relied upon to be present. In addition, if you are connected via Tor, Sparrow will broadcast using a random external service over Tor (like blockstream or mempool.space) resulting in a successful broadcast since the mempool there is unconstrained.

How do you determine the "below minimum" fees with the slider then? That never comes up if not using mempool.space for fees?

That never comes up if not using mempool.space for fees?

Correct. Trying setting your Fee rates source to Server in the Preferences.

Interesting, that is a subtle difference between using mempool.space and a private electrum server!
Where do you suggest we request the electrum protocol add support a mempoolminfee? Should an implementation such as electrs be approached and get one implementation supporting it first before trying to get that into the electrum standard?
What happens if you use the Cormorant mode with bitcoin core? https://bitcoincore.org/en/doc/26.0.0/rpc/blockchain/getmempoolinfo/ has a mempoolminfee field that it returns. I don't have a full mempool right now, so I can't test it.

I confirmed that newer versions of Sparrow give a clearer error message now, but what I'm getting doesn't show the "increase the fee to at least 907 sats to try again" part. What scenario is required to get this level of detail?

With the exception of Whirlpool (which is why I wrote Sparrow Terminal), I do not believe it is a good idea to encourage users to leave Sparrow open for long periods. Sparrow is a client, not a server, and leaning too far into "always on" requirements may lead to undesirable outcomes, like transactions unexpectedly not getting broadcast. As you suggest, it is better for the server to handle these kind of requirements from an engineering perspective. Unfortunately, there is no support for this right now in the Electrum protocol, which is where this feature would need to start imo.

Okay, so you are basically suggesting that this issue should be closed then in favor of https://github.com/romanz/electrs/issues/397 ?
For public electrum servers, I'm not sure what a sustainable solution might be. I think in the future maybe there is going to need to be a way to pay an electrum node to hold onto your transaction and re-broadcast it, vaguely "similar" to how watchtowers work in lightning. I guess possibly we are going to need to pay all public electrum nodes in the future for all access since it won't be sustainable to have all volunteer electrum nodes, so maybe the problem is more general. I don't think we can rely on "using a random external service over Tor (like blockstream or mempool.space) resulting in a successful broadcast since the mempool there is unconstrained" forever.

Where do you suggest we request the electrum protocol add support a mempoolminfee? Should an implementation such as electrs be approached and get one implementation supporting it first before trying to get that into the electrum standard?

It's unclear to me, although I will say that https://electrumx-spesmilo.readthedocs.io/en/latest/protocol.html (owned by the Electrum wallet devs, the original inventors of the protocol) is for me the definitive specification. But implementations have added their own extensions to it over the years. I believe that a popular extension (like rebroadcasting) built into one implementation would be copied by the others.

What happens if you use the Cormorant mode with bitcoin core?

Sparrow currently doesn't look for this information from the connected server (as there is no Electrum protocol call for it), but rather the fee rates source, so it doesn't matter.

I confirmed that newer versions of Sparrow give a clearer error message now, but what I'm getting doesn't show the "increase the fee to at least 907 sats to try again" part. What scenario is required to get this level of detail? Is that for Cormorant mode with bitcoin core and not electrum?

Depends on the situation, and since the error message is ultimately coming from Bitcoin Core it doesn't matter whether Cormorant is used or not. As to what error messages Sparrow gets, it's a bit messy, but so are the cryptic responses from Core. If you can create a broadcasting error that Sparrow can handle with a better message, please open a new issue.

Okay, so you are basically suggesting that this issue should be closed then in favor of https://github.com/romanz/electrs/issues/397 ?

Yes, basically. I tried really hard to make this work in Sparrow, and it turned out to have more disadvantages than advantages for the reasons I described there.
Wrt to future solutions, I have a general view that we shouldn't add suboptimal solutions before they are really necessary. Rather, let's see how far we can get by making good engineering decisions with the current infrastructure. I'd like to see delayed (re)broadcasting support in Electrum servers, privately at first, and then publicly later. The resource requirements are not really that onerous in modern hardware terms, and can be capped. That would be my starting point.


Migrate CRDs to kong/kubernetes-configuration repo

Is there an existing issue for this?

[X] I have searched the existing issues

Does this enhancement require public documentation?

[X] I have added an Acceptance Criteria item for adding and/or adjusting public documentation (if applicable)

Problem Statement
Now we have created kong/kubernetes-configuration repository to store CRDs corresponding to Kong configuration. The repo is expected to be shared by KIC and KGO. We need to import source of CRDs from internal packages to packages in kong/kubernetes-configuration.
Proposed Solution

Change import source of CRDs to packages in kong/kubernetes-configuration
Change the scripts to download CRD manifests from kong/kubernetes-configuration
Remove CRD packages and CRD manifests in the repo (Should we do this? Maybe there are dependencies elsewhere)

Additional information
No response
Acceptance Criteria

[ ] KIC imports CRDs from kong/kubernetes-configuration repo
[ ] KIC generate manifests from CRDs downloaded from  kong/kubernetes-configuration repo
[ ] Documents mentioning CRD download URLs changed to URLs in  kong/kubernetes-configuration

It is required for KGO to operate it.

We should also take care of handling the control plane reference in KIC and ignore objects that are not attached to other CPs (have the reference non-empty and refer to non-KIC CP).

Every task has been resolved 🎉


Gateway test race fix.

The gateway unit-tests could fail as it relies on a non-guaranteed ordering
within a computed slice. We fix it by only testing for the presence of the
necessary elements and not their order.

Thanks!


How to edit httpd.conf?

How Do I edit the httpd.conf for Apache  for WebApp?
I would like to edite the ServerTokens Settings.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ba64cf1f-a5a5-7420-9843-fdf34191e2b5
Version Independent ID: 8fa1e477-4419-3af7-b29c-f3a5b927bb78
Content: Open-source technologies FAQs - Azure App Service
Content Source: articles/app-service/faq-open-source-technologies.md
Service: app-service-web
GitHub Login: @genlin
Microsoft Alias: genli

@KeiroKamioka0000, Thanks for your feedback! We will investigate and update as appropriate.

@KeiroKamioka0000, You could try the following approaches and check:

Connect via SSH to the app container virtual machine and then try to modify the file.
Note: You can also connect to the app container directly from your local development machine using SSH, SFTP, or Visual Studio Code (for live debugging Node.js apps).

If it’s a container you could create a container image and use that instead.
You can base off or fork from the built-in images as mentioned in this document : https://docs.microsoft.com/en-us/azure/app-service/containers/app-service-linux-faq#built-in-images

@KeiroKamioka0000, Since we have not heard back from you we will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly reopen the issue and continue the discussion.


misc(header/headertest): Rename param for test suite to be more clear

I'm sorry but this was bothering me.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (debad37) 51.64% compared to head (ddcc7d8) 51.39%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3137      +/-   ##
==========================================
- Coverage   51.64%   51.39%   -0.25%
==========================================
  Files         178      178
  Lines       11226    11226
==========================================
- Hits         5798     5770      -28
- Misses       4933     4955      +22
- Partials      495      501       +6

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

wut

@Wondertan I always assumed the test suite would take num as number of headers to generate when really it was number of validators.

There is a comment that clearly states that this is validators, I don't think this is needed

Now part of #3139


Fix cmake config call for external VTK build

Variable type was missing, breaking config call.

Closing because bug fixed by https://github.com/stnava/ANTs/commit/2f09e62faabf65162e66bd4eed8f94599522f409


chore: remove apisnoop

this repo is being migrated to kubernetes-sigs/apisnoop, as it's being donated to Kubernetes' sig-architecture
related: https://github.com/kubernetes/org/issues/4705
the cncf/apisnoop repo appears to have been recreated since migrating the repo away. It will need to be removed.
I'm hoping this has that affect

@jeefy could you please merge this PR too? There are some more repositories in a similar situation. Thanks!


Intermittent Kotlin buildSrc compilation failures.

Current Behavior
I intermittently observe compile failures of Kotlin code in buildSrc on MacOS.  Once it begins occurring the only thing that (temporarily) resolves the issue is to reboot the machine.  Deleting .gradle/ caches and killing all running Gradle processes does not help.
The compile failure results in errors that indicate that type inference is failing to resolve types, as not all call locations fail.  For example, this piece of code results in three errors:
   // proc has inferred type java.lang.Process
    val errors = proc.errorReader().readText()  // <<<======= errorReader unresolved
        val out = proc.inputReader().readText() // <<<======= inputReader unresolved

        if(proc.waitFor() != 0) {
            println("Signing failed for ${file}")
            println(out)        //  <<== inferred as String normally, error case results in resolution ambiguity
            println(errors)    // <<== inferrred as String normally, error case results in resolution ambiguity
            throw TaskExecutionException(this, Exception(errors))
        }

Adding manifest types to all Process types variables and offending String variables resolves all issues with inferred String types, but not the problems with the errorReader and inputReader extensions.  These seem to be the root cause of the compile failures.
Unfortunately I have not yet demonstrated this in a small sample project and the project this occurs in is a large internal multi-project build.
> Task :buildSrc:checkKotlinGradlePluginConfigurationErrors
> Task :buildSrc:pluginDescriptors
> Task :buildSrc:processResources NO-SOURCE
> Task :buildSrc:compileKotlin FAILED
e: file:///Users/sstadmin/builds/RA1mLz67P/0/apt/apt/buildSrc/src/main/kotlin/edu/stsci/apt/buildsrc/CodeSignTask.kt:57:27 Unresolved reference: errorReader
e: file:///Users/sstadmin/builds/RA1mLz67P/0/apt/apt/buildSrc/src/main/kotlin/edu/stsci/apt/buildsrc/CodeSignTask.kt:58:24 Unresolved reference: inputReader
e: file:///Users/sstadmin/builds/RA1mLz67P/0/apt/apt/buildSrc/src/main/kotlin/edu/stsci/apt/buildsrc/CodeSignTask.kt:62:13 Overload resolution ambiguity:
public inline fun println(message: Any?): Unit defined in kotlin.io
public inline fun println(message: Boolean): Unit defined in kotlin.io
public inline fun println(message: Byte): Unit defined in kotlin.io
public inline fun println(message: Char): Unit defined in kotlin.io
public inline fun println(message: CharArray): Unit defined in kotlin.io
public inline fun println(message: Double): Unit defined in kotlin.io
public inline fun println(message: Float): Unit defined in kotlin.io
public inline fun println(message: Int): Unit defined in kotlin.io
public inline fun println(message: Long): Unit defined in kotlin.io
public inline fun println(message: Short): Unit defined in kotlin.io
e: file:///Users/sstadmin/builds/RA1mLz67P/0/apt/apt/buildSrc/src/main/kotlin/edu/stsci/apt/buildsrc/CodeSignTask.kt:63:13 Overload resolution ambiguity:
public inline fun println(message: Any?): Unit defined in kotlin.io
public inline fun println(message: Boolean): Unit defined in kotlin.io
public inline fun println(message: Byte): Unit defined in kotlin.io
public inline fun println(message: Char): Unit defined in kotlin.io
public inline fun println(message: CharArray): Unit defined in kotlin.io
public inline fun println(message: Double): Unit defined in kotlin.io
public inline fun println(message: Float): Unit defined in kotlin.io
public inline fun println(message: Int): Unit defined in kotlin.io
public inline fun println(message: Long): Unit defined in kotlin.io
public inline fun println(message: Short): Unit defined in kotlin.io
e: file:///Users/sstadmin/builds/RA1mLz67P/0/apt/apt/buildSrc/src/main/kotlin/edu/stsci/apt/buildsrc/CodeSignTask.kt:64:48 Overload resolution ambiguity:
public final fun `<init>`(p0: String!): kotlin.Exception /* = java.lang.Exception */ defined in kotlin.Exception
public final fun `<init>`(p0: Throwable!): kotlin.Exception /* = java.lang.Exception */ defined in kotlin.Exception
e: file:///Users/sstadmin/builds/RA1mLz67P/0/apt/apt/buildSrc/src/main/kotlin/edu/stsci/apt/buildsrc/CodeSignTask.kt:79:28 Unresolved reference: errorReader
e: file:///Users/sstadmin/builds/RA1mLz67P/0/apt/apt/buildSrc/src/main/kotlin/edu/stsci/apt/buildsrc/CodeSignTask.kt:83:34 Unresolved reference: inputReader
e: file:///Users/sstadmin/builds/RA1mLz67P/0/apt/apt/buildSrc/src/main/kotlin/edu/stsci/apt/buildsrc/CodeSignTask.kt:94:73 Unresolved reference: inputReader
e: file:///Users/sstadmin/builds/RA1mLz67P/0/apt/apt/buildSrc/src/main/kotlin/edu/stsci/apt/buildsrc/CodeSignTask.kt:104:54 Unresolved reference: inputReader
e: file:///Users/sstadmin/builds/RA1mLz67P/0/apt/apt/buildSrc/src/main/kotlin/edu/stsci/apt/buildsrc/CodeSignTask.kt:107:46 Unresolved reference: inputReader
e: file:///Users/sstadmin/builds/RA1mLz67P/0/apt/apt/buildSrc/src/main/kotlin/edu/stsci/apt/buildsrc/CodeSignTask.kt:107:94 Unresolved reference: errorReader
e: file:///Users/sstadmin/builds/RA1mLz67P/0/apt/apt/buildSrc/src/main/kotlin/edu/stsci/apt/buildsrc/GitlabApiTasks.kt:154:24 Unresolved reference: inputReader
e: file:///Users/sstadmin/builds/RA1mLz67P/0/apt/apt/buildSrc/src/main/kotlin/edu/stsci/apt/buildsrc/GitlabApiTasks.kt:200:25 Unresolved reference: errorReader
e: file:///Users/sstadmin/builds/RA1mLz67P/0/apt/apt/buildSrc/src/main/kotlin/edu/stsci/apt/buildsrc/GitlabApiTasks.kt:201:25 Unresolved reference: inputReader
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':buildSrc:compileKotlin'.
> A failure occurred while executing org.jetbrains.kotlin.compilerRunner.GradleCompilerRunnerWithWorkers$GradleKotlinCompilerWorkAction
   > Compilation error. See log for more details

Expected Behavior
The success or failure of compilation for buildSrc is consistent.
Context (optional)
Currently the buildSrc Gradle file looks likes this:
plugins {
    `kotlin-dsl`
//    kotlin("jvm") version "2.0.0"
}

repositories {
    mavenCentral()
}

dependencies {
//    implementation(kotlin("stdlib"))
    implementation("org.jetbrains.kotlinx:kotlinx-serialization-json:1.7.1")
    implementation("org.apache.commons:commons-compress:1.26.1")
}

I have variously tried explicit dependencies on the kotlin plugin and Kotlin Standard library but none of these have resolved the issue.
Self-contained Reproducer Project
Unfortunately I have not yet demonstrated this in a small sample project and the project this occurs in is a large internal multi-project build.
Gradle version
8.10.2, but observed in many 8.* versions
Build scan URL (optional)
No response
Your Environment (optional)
No response

I can workaround the issue by manually expanding the inputReader and errorReader extenions like this:
private fun getErrors(proc: Process): String = BufferedReader(InputStreamReader(proc.getErrorStream(), Charset.defaultCharset())).readText()
private fun getOutput(proc: Process): String = BufferedReader(InputStreamReader(proc.getInputStream(), Charset.defaultCharset())).readText()

The extension issue only seems to be related to Process extensions?

This is an issue with the Kotlin Gradle Plugin, which is developed by JetBrains, and cannot be addressed in the Gradle Build Tool project. We cannot just move the issue.
Please open such Kotlin-related issues on the JetBrains YouTrack at https://kotl.in/issue.

We suspect this may be an issue with the Kotlin Compiler daemon, so nothing we can do in Gradle itself.

Thanks, filed https://youtrack.jetbrains.com/issue/KT-72550


fix README translation of zh

zh means Chinese language. Mandarin Chinese is being compared with Cantonese, which emphasizes the dialect side of the language. Simplified Chinese would be better in translation.

Thanks for the precision! That makes sense.


Update version in header.js

It can be very usefull to know the version of the lib by just looking at the header.

Oops. Thanks.


[Update Request]: Oracle.MySQLShell 8.4.0

What type of update are you requesting?
A new version of an existing package
Current Package Identifier
Oracle.MySQLShell
Package Version
8.4.0
Please describe the changes you would like to see
8.4.0 is available from here https://dev.mysql.com/downloads/shell/. PR following.

[!NOTE]
This pull request should be closed as "completed", as it's already solved by #152997.

Thanks for the merge.

closed


zipWith implementation needs investigated

We're currently doing something strange with zipWith (aka the "zip operator"), where we're essentially creating a new observable with the static zip, then creating a new "blank Observable", and setting the source property to the zip, but never setting the operator property.
This seems very unusual, and I feel there are probably bugs around this, and/or it could just be refactored to something simpler.
This apparently also exists in the raceWith operator.

I see why it's doing this. And it is just another smell related to lift. I can't imagine an end user thinking they need to implement an operator from a static method like this. Related to #5431
Closing for now.


Updated the French

Updated the French translation with the new phrases

Please also change the translations in /kibbeh


Add ability to set number of ingredient/recipe factories.

With the current system, one is unable to set an ingredient/input factory number, but we are only allowed to set output. This is especially frustrating when using fluids, as one cannot set a number of buildings for fluids. I suggest that we be allowed to set the number of factories for intermediates and inputs, so that fluid ratios become more easily calculated.

Thanks for the suggestion!
So, I expect the most simple example use case for this is you want to tell the calculator to use one refinery, and just output the maximum possible amount of petroleum gas with all the cracking recipes included. If I'm understanding you correctly, I can see the appeal in that.
The issue is that it's a completely different type of calculation. Today you might say, "I want to output 100 petroleum gas / minute." The calculator understands that as "Generate 100 petroleum gas / minute, minimizing the use of oil, then water, then number of factories." The simplex algorithm then solves the linear program, minimizing the 'cost' which is the input oil, water, and the number of factories.
What you're describing adds a 'maximization' problem on top of that. So it's "Using this number of factories, maximize the output of petroleum gas, but also minimize the use of oil, water, and factories." Simplex can only solve one minimize/maximize problem, not two, so we need to think about it a different way (that I honestly haven't figured out yet). Maybe it's possible to combine the two constraints into one objective.
On top of that, the calculator doesn't even understand some of the basics of this problem. There's no way to say "use this number of factories," if you do that currently it just translates that directly into a number of items but in this case we don't know the number of items yet because we have to calculate it. There's also no way to specify what you're trying to maximize. For example, you might say "using 1 refinery, maximize output" but you have to somewhere specify what you want to maximize, since it could be petroleum gas but it could also be heavy or light oil. For this use case you could just specify "1 factory of petroleum gas", which the UI handles, but then (especially with mods) we don't necessarily know what factory you're referring to. For example, do you want to maximize around 1 chemical plant running light oil cracking, or 1 refinery? You would need to be able to somehow say "Using x of this specific factory (or, more likely, this recipe), maximize the output of this specific product."
All of this to say, I would love to do what you're asking but it is complicated. I'll keep this in the back of my mind and I'll probably explore options at some point, but would likely require a major refactor or a completely different type of calculation.

Here is an example of what I was thinking of.

Here is an example of what I was thinking of.
I don't know why you wouldn't be able to just have the inverse of the graph to maximize it. Is that not feasible?

Maybe for the calculator you could frame the problem by making factories a recipe type with their inputs/outputs being ingredients. (outputs inverse).

That's a really nice way to integrate the concept into the UI, but it doesn't really solve the issue of needing to declare what you want to maximize. So you have to pick petroleum gas in the products list to even get this far, then you come in and change the number of refineries to 1. What do we do with the products you'd defined earlier? At that point you don't really want 1 petroleum gas per second, you just want to maximize petroleum gas subject to a constraint on the number of refineries. I suppose you would wipe out the "1 items/second" and just show the petroleum gas in the products, and assume that's what you're trying to maximize? Once you do that, things could start to get pretty weird.
Maybe I don't understand you, but simply inversing the graph doesn't really work, because the issue is that you're no longer declaring a number of outputs at all. It might be possible to solve with simplex, but it'd definitely take some exploring.

Related: https://github.com/KirkMcDonald/kirkmcdonald.github.io/issues/154

And what's currently this alghoritm trying to maximize/minimize? Sum of all ingredients' amounts?


[TablePagination] Cannot change displayedRows child component from  to

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Current behavior 😯
Tested with version 5.10.0
I'd like to change the displayedRows (label) child component from
 to
.
Things I've tried:
<TablePagination
  DisplayedRowsProps={{ component: "div" }}
/>

<TablePagination
  componentsProps={{
    displayedRows: { component: "div" }
  }}
/>

Expected behavior 🤔
Currently it renders:

It should render:

Steps to reproduce 🕹
import TablePagination from "@mui/material/TablePagination";

<TablePagination
  DisplayedRowsProps={{ component: "div" }}
/>

Context 🔦
I'd like to render a custom React component (with a LinearProgress) in place of count numeric value using labelDisplayedRows prop, so I can display a progress bar while the total number of table rows is not yet available.
Your environment 🌎
Browser: Brave Version 1.42.88 Chromium: 104.0.5112.81 (Official Build) (arm64)

npx @mui/envinfo
System:
    OS: macOS 12.4
  Binaries:
    Node: 16.15.1 - /usr/local/bin/node
    Yarn: 1.22.11 - /opt/homebrew/bin/yarn
    npm: 8.11.0 - /usr/local/bin/npm
  Browsers:
    Chrome: 104.0.5112.79
    Edge: Not Found
    Firefox: 99.0.1
    Safari: 15.5
  npmPackages:
    @emotion/react: ^11.9.3 => 11.9.3
    @emotion/styled: ^11.9.3 => 11.9.3
    @mui/base:  5.0.0-alpha.92
    @mui/icons-material: ^5.8.4 => 5.8.4
    @mui/material: ^5.10.0 => 5.10.0
    @mui/private-theming:  5.9.3
    @mui/styled-engine:  5.10.0
    @mui/system: ^5.10.0 => 5.10.0
    @mui/types:  7.1.5
    @mui/utils:  5.9.3
    @types/react:  18.0.15
    react: ^18.2.0 => 18.2.0
    react-dom: ^18.2.0 => 18.2.0
    typescript: ^4.7.4 => 4.7.4

+1

@elias-pap There is no DisplayedRowsProps or componentsProps.displayedRows in TablePagination. See API docs: https://mui.com/material-ui/react-table/#api.

Please provide a CodeSandbox reproducing the issue. The issue template is a good starting point.

same problem, and just want like below


Config for Quartz Server

Hi,
How to config Quartzmin work with Quartz Server?
Thank you,

I have config and it run now.


Booking 2 Rooms

Thanks Mr Volker. This is great!
However, I'm hoping to book 2 rooms for a family of 5. Is there any way of adding a pre-filled tick 'No' for the disability needs question for room 2 as well?

There has been some work done on this in #2, but it's not merged yet. It would be good to implement it into the app.

Thank you for the update.
Will you be updating again now that the MIQ registration page has changed
this morning?
On Tue, Jul 20, 2021 at 3:41 AM Jeremias Volker @.***>
wrote:

There has been some work done on this in #2
https://github.com/jvolker/miq-nz-booking-tools/pull/2, but it's not
merged yet. It would be good to implement it into the app.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/jvolker/miq-nz-booking-tools/issues/41#issuecomment-882845426,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AU4LZUQLTUZRPWNYYZIV3P3TYSEYZANCNFSM5ASCCANQ
.

fixed in #48


Subfolder support for Synology Diskstation

We are using a synology diskstation as our web server, would it be possible to add subfolder support?
Our smb share currently would look like this smb:///web/CasperShareTest. We need to be able to upload with the following recipe:
JSS_REPOS

share_name
web/CasperShareTest

We have a similar issue of an SMB share and a sub folder that is our web share. It would be a useful ability to move packages to a sub folder of a network share. Perhaps some separation of the SMB connection function and the package move function so that the move is to a directory path, independent of the share mount.

SMB paths are dealt with in python-jss rather than JSSImporter. Specifically, in distribution_point.py. If you are willing to figure out a way of adding subfolder capability to SMB shares in python-jss, I welcome a pull request.


 When running something like the following to get OIDs and descriptions from compiled MIBs, with the CISCO-ENHANCED-IPSEC-FLOW-MIB I get an error.
The code I'm running:
from pysnmp.smi import builder, view, error
mibBuilder = builder.MibBuilder()
mibBuilder.loadTexts = True
mibBuilder.addMibSources(builder.DirMibSource("C:\\Users\\mmiller\\Documents\\tools_etc\\python_projects\\testingMIBS\\temp\\"))
mibBuilder.loadModules(*['CISCO-ENHANCED-IPSEC-FLOW-MIB'])
mibView = view.MibViewController(mibBuilder)
oid, oid_name, _ = mibView.getFirstNodeName()
while True:
    try:
        mib_name, oid_name, suffix = mibView.getNodeLocation(oid)
        oid_info, = mibBuilder.importSymbols(mib_name, oid_name)
        print(oid, oid_name, getattr(oid_info,'description',""))
        oid, oid_name, suffix = mibView.getNextNodeName(oid)
    except error.NoSuchObjectError:
        break

The exception I get:
Traceback (most recent call last):
  File "C:\testing\python_projects\testingMIBS\venv\lib\site-packages\pysnmp\smi\builder.py", line 357, in loadModule
    exec(codeObj, g)
  File ".pysnmp-mibs\CISCO-ENHANCED-IPSEC-FLOW-MIB.py", line 806, in <module>
    if mibBuilder.loadTexts: ciscoEnhIPsecFlowActivityGroup.setReference('rfc2408, rfc2407; rfc2409 section 5.5')
AttributeError: 'ObjectGroup' object has no attribute 'setReference'

I've attached a zip with the original MIB file and the compiled .py mib file.
Thanks
issue.zip

Thanks for the report.
There are a few things you might check,
The Python packages you are using
We are using the latest Python packages from our own, https://github.com/etingof/pysnmp/issues/429 So, you need mibdump from pysmi-lextudio 1.1.13 and then the compiled .py for the MIB document can work with pysnmp-lextudio 5.0.25.
This repo does not support any other distribution of PySNMP bits as part of our support policies.
The MIB document to test
We cannot reproduce the issue with the MIB document from https://raw.githubusercontent.com/lextudio/mibs.pysnmp.com/master/asn1/CISCO-ENHANCED-IPSEC-FLOW-MIB
Due to our support policies, we didn't test the copy you provided, but feel free to let us know if the issue remains after you switch to our supported Python packages.

I am using the lextudio packages. I just tried to uninstall pysnmp and pysmi and get:
(venv) C:\testing\python_projects\testingMIBS>pip3 uninstall pysnmp
WARNING: Skipping pysnmp as it is not installed.

(venv) C:\testing\python_projects\testingMIBS>pip3 uninstall pysmi
WARNING: Skipping pysmi as it is not installed.

But uninstalling the lextudio packages works:
(venv) C:\Users\mmiller\Documents\tools_etc\python_projects\testingMIBS>pip3 uninstall pysnmp-lextudio
Found existing installation: pysnmp-lextudio 5.0.25
Uninstalling pysnmp-lextudio-5.0.25:
  Would remove:
    c:\users\mmiller\documents\tools_etc\python_projects\testingmibs\venv\lib\site-packages\pysnmp\*
    c:\users\mmiller\documents\tools_etc\python_projects\testingmibs\venv\lib\site-packages\pysnmp_lextudio-5.0.25.dist-info\*
Proceed (Y/n)? y
  Successfully uninstalled pysnmp-lextudio-5.0.25

(venv) C:\Users\mmiller\Documents\tools_etc\python_projects\testingMIBS>pip3 uninstall pysmi-lextudio
Found existing installation: pysmi-lextudio 1.1.13
Uninstalling pysmi-lextudio-1.1.13:
  Would remove:
    c:\users\mmiller\documents\tools_etc\python_projects\testingmibs\venv\lib\site-packages\pysmi\*
    c:\users\mmiller\documents\tools_etc\python_projects\testingmibs\venv\lib\site-packages\pysmi_lextudio-1.1.13.dist-info\*
    c:\users\mmiller\documents\tools_etc\python_projects\testingmibs\venv\scripts\mibcopy.exe
    c:\users\mmiller\documents\tools_etc\python_projects\testingmibs\venv\scripts\mibdump.exe
Proceed (Y/n)? y
  Successfully uninstalled pysmi-lextudio-1.1.13

I've now re-installed the packages and the issue still occurs.
If I add the following to the ObjectGroup class in pysnmp > smi > mibs > SNMPv2-CONF.py then I no longer face the issue:
    def getReference(self):
        return self.reference

    def setReference(self, v):
        self.reference = v
        return self

I'm not sure if this is correct but it stops the issue. The same is true for the NotificationGroup class in that file also.

Fixed in pysnmp 7.1.10 and pysmi 1.5.9.
If you cannot upgrade to such versions, either set loadTexts to False, or manually delete the relevant lines from the compiled .py file.


Fix site_range weight and metric

Dependabot dependency update
Update Just env for compose

Any of the failing CI checks that are silently happening are unrelated to this and the checks you added passed, so I'll merge now, thank you for these :pray:


Jest-Jasmine and (older) Jest-Circus deprecation in favour of a newer implementation

Detox 19 is dropping support for the older Jest adapters.
How to tell if you are affected by this issue?
Check your e2e/init.js (or the file you use in setupFilesAfterEnv strings array in your Jest config). If you have calls to adapter.beforeEach or adapter.afterEach, like shown below, then yes, you are affected:
beforeEach(async function() {
  await adapter.beforeEach();
});

afterAll(async () => {
  await adapter.afterAll();
  await detox.cleanup();
});

What shall you do to migrate to the new jest-circus integration?
Follow this Jest setup guide. This section might be amended later.
Why this is happening?
At the moment, Detox has three different ways to integrate with Jest, which is too much to support at once. Only the strongest shall survive, and that is the latest jest-circus integration introduced in 2020 with<EMAIL_ADDRESS>Overall, it is more future-proof since it provides fine-grained control over the tests' lifecycle. To be more specific, it dramatically improves error handling (e.g., immediate screenshots on test failure) and provides more stability (e.g., in cases when detox.init() call fails early and some others).

@noomorph Is this not finished in Detox 18.0?

Unfortunately no - we had to postpone it until 18 "settles in".

So changes in DetoxNext were reverted? @d4vidi

yes AFAIK (just this part, of course)


find compatible USB-c power bank

this would replace the need for the extra usb-A to usb-c cord

as mentioned in #86 , this one works: https://www.canakit.com/raspberry-pi-4-on-off-power-switch.html
I assume other USB-c will work too... i will investigate ones mentioned in various review sites (like wirecutter):
https://www.nytimes.com/wirecutter/reviews/best-usb-battery-packs/
https://www.nytimes.com/wirecutter/reviews/best-usb-battery-packs/


Add arbitrary tag attribute assignment in moustaches

This adds the ability to include attribute values for any element that can be altered by a moustache.
Form:
{attribute=value}

example:

![homebrew mug](https://i.imgur.com/hMna6G0.png) {position:absolute,bottom:20px,left:130px,width:220px,a=b and c,g=h}

becomes:

In order to permit spaces, the pattern matches for moustache code had to remove the space character as a delimiter. I believe I have adequate compensated.
This should solve #1488

Looks good, but for the a="b and c" variation.
In curly-blocks and curly-spans, values with spaces need to be quoted, like this: {{border:"1px red solid" span-text-with-red-border}} It would be better if we didn't have two slightly different/incompatible syntaxes and that this code could also (eventually) be applied to curly-blocks and curly-spans.

In order to permit spaces, the pattern matches for moustache code had to remove the space character as a delimiter.

Unfortunately this breaks a core behavior of the curly syntax. A space is the delimiter to separate the CSS directives from any block contents, in the case of Spans in particular.

Looks good, but for the a="b and c" variation.
In curly-blocks and curly-spans, values with spaces need to be quoted, like this: {{border:"1px red solid" span-text-with-red-border}} It would be better if we didn't have two slightly different/incompatible syntaxes and that this code could also (eventually) be applied to curly-blocks and curly-spans.

Looks good, but for the a="b and c" variation.
In curly-blocks and curly-spans, values with spaces need to be quoted, like this: {{border:"1px red solid" span-text-with-red-border}} It would be better if we didn't have two slightly different/incompatible syntaxes and that this code could also (eventually) be applied to curly-blocks and curly-spans.

I was so focused on my test case I completely forgot about all the other patterns.
I'm gonna have to beat on the regex more...

In order to permit spaces, the pattern matches for moustache code had to remove the space character as a delimiter.

Unfortunately this breaks a core behavior of the curly syntax. A space is the delimiter to separate the CSS directives from any block contents, in the case of Spans in particular.

I looked at the "welcome" brew to see if I could spot any places where my change on the \w to \t\f\n\r breaks anything and I'm not spotting one. Am I missing anything?  All the moustache tests pass as well?

It doesn't break any existing tests, but your new code only touches the single curly "injector" variant. If we were to add that syntax to the double curly "span" variant it would break. We need to ensure any syntax we add would be functional for all variants.

For example:
{{position:absolute,bottom:20px,left:130px,width:220px,a=b and c,g=h My Span Text}}

becomes:

and c,g=h My Span Text<\span>

The regex for attr=value and attr="value with spaces" would be very similar to the regex for csspropery:value and csspropery:"value with spaces" which exists in curly-blocks and curly-spans.

@dbolack-ab If you can get this to work using quotes to contain the spaces instead of removing space as a delimiter, I can give it another look.

Should this wait for #3066 first? to get strings as attributes?
I say that, but i'm the one holding that PR back, will fix that later today if i can.

Should this wait for #3066 first? to get strings as attributes?
I say that, but i'm the one holding that PR back, will fix that later today if i can.

Probably a good idea.

I fixed a small bug and did a little cleanup. I think this is ready to merge unless you have any major concern about my changes. Passes your tests still and seems to function as expected.

@calculuschild  Looks good to me!


Add 20 Christmas songs

Add the following very popular Christmas songs:
NOTE: Set the Author as "Author Unknown" and Album as "Christmas Songs".

Yesu Palanay Munnanaiyeelay
Yesu Rajan Piranthaar
Vanthar Karthar Vanthar
Athi Kalayil Palanai Thedi
Namaskaripom Nam Yesu Rajan
Vaanavar Piranthaar
Maasila Theva Mainthan Yelaiyin Kolam Kondar
Ullam Siriketumay Vinnil Parakatuumay
Kartharallavo Maa Maari Yendru Paalan Allavo
Theadi Vantha Oli, Yennai Atri Thetra Vantha Oli
Chinna Chinna Palagan
Theva Kumaran Yesu
Aarparipom Paalan Piranthe Thinam
Elai Kolam Eduthavareh Yesu Raja
Avaniyiley Avatharithar
Seer Yesu Nathan Yendrum
Naam Rajathi Rajanukke
Piranthar Piranthar
Pirantharey Pirantharey Theva Suthan Pirantharey
Namakkoru palagan piranthar

Since the scope of this issue is too big, closing it.


[feature] Wallet list is not sorted by featuredWalletIds

What problem does this new feature solve?
Wallet list is not sorted by featuredWalletIds
Describe the solution you'd like
Wallet list is not sorted by featuredWalletIds

Available in beta.3


WIP: Upgrade Kubebuilder to v1.0.0

/cc @marun @shashidharatd @onyiny-ang

Holding until alpha is released.  We gain no benefit that I can see from vendoring 0.1.12 - the features it adds are leveraged by running the kubebuilder binary.

@marun for the azure auth code error, it has been fixed in 1.11 https://github.com/kubernetes/client-go/blob/kubernetes-1.11.0/plugin/pkg/client/auth/azure/azure.go#L300 , but the problem is that if we upgrade to kubernetes 1.11.0, there will also be some other changes in client-go part, as some code are now deprecated in client-go, and we may also need to update the code as well. Shall we open an issue to upgrade kubernetes to 1.11.0? I can follow up for this if you agree with this.
I have a diff as follows:
--- a/Gopkg.toml
+++ b/Gopkg.toml
@@ -90,7 +90,7 @@ version="v0.3.4"

 [[override]]
 name="github.com/json-iterator/go"
-version="1.1.3"
+version="1.1.4"

 [[override]]
 name="github.com/mailru/easyjson"
@@ -154,23 +154,23 @@ version="v2.2.1"

 [[override]]
 name="k8s.io/api"
-version="kubernetes-1.10.0"
+version="kubernetes-1.11.0"

 [[override]]
 name="k8s.io/apiextensions-apiserver"
-version="kubernetes-1.10.1"
+version="kubernetes-1.11.0"

 [[override]]
 name="k8s.io/apimachinery"
-version="kubernetes-1.10.0"
+version="kubernetes-1.11.0"

 [[override]]
 name="k8s.io/client-go"
-version="kubernetes-1.10.1"
+version="kubernetes-1.11.0"

 [[override]]
 name="k8s.io/kube-aggregator"
-version="kubernetes-1.10.1"
+version="kubernetes-1.11.0"

 [[override]]
 name="k8s.io/kube-openapi"

The reason that we need to upgrade github.com/json-iterator/go to 1.1.4 is because of issue https://github.com/operator-framework/getting-started/issues/16#issue-334333590
And after dep ensure, the build failed as follows:
root@gyliu-dev1:~/go/src/github.com/kubernetes-sigs/federation-v2# go build -o bin/controller-manager ./cmd/controller-manager
# github.com/kubernetes-sigs/federation-v2/pkg/controller/util
pkg/controller/util/resourceclient.go:35:29: undefined: dynamic.ClientPool
pkg/controller/util/resourceclient.go:47:38: undefined: dynamic.VersionedParameterEncoderWithV1Fallback
pkg/controller/util/resourceclient.go:56:13: undefined: dynamic.NewDynamicClientPool
pkg/controller/util/resourceclient.go:61:26: too many arguments in call to c.client.Resource
	have (*"github.com/kubernetes-sigs/federation-v2/vendor/k8s.io/apimachinery/pkg/apis/meta/v1".APIResource, string)
	want (schema.GroupVersionResource)

@gyliu513, v1.0.0 is released https://github.com/kubernetes-sigs/kubebuilder/releases/tag/v1.0.0
Shall we migrate to v1.0.0 instead of v0.1.12?

@shashidharatd @marun updated to kubebuilder v1.0.0, can you help check? Thanks.

I've changed the title here to preclude ongoing review at this time.  I've been investigating what a switch would imply for the codebase and the changes required are non-trivial and are not suggested at this time.

@gyliu513, shall we close this.

looking forward to it @marun


Adding get rhosak operator script

Adding a script that uses oc adm inspect to get resources from RHOSAK operators.

I dont think any RBAC is needed i was told users automatically have the cluster reader cluster role which has access to everything oc adm inspect needs

Also i dont have access to see why the test failed

01:30:44 [openshift-managed-scripts-gh-pr-check] $ /bin/sh -xe /tmp/jenkins9112491743154026141.sh
01:30:44 + ./hack/app_sre_pr_check.sh
01:30:44 ./hack/schema_validation.sh
01:30:44 convert ./scripts/CEE/check-tech-preview-features/metadata.yaml to json
01:30:44 convert succeed
01:30:44 convert ./scripts/CEE/etcd-health-check/metadata.yaml to json
01:30:44 convert succeed
01:30:44 convert ./scripts/CEE/get-kafka-instance-state/metadata.yaml to json
01:30:44 convert succeed
01:30:44 convert ./scripts/CEE/list-alerts/metadata.yaml to json
01:30:44 convert succeed
01:30:44 convert ./scripts/CEE/registry-s3-bucket-size/metadata.yaml to json
01:30:44 convert succeed
01:30:44 convert ./scripts/CEE/get-rhosak-operators/metadata.yaml to json
01:30:44 Traceback (most recent call last):
01:30:44   File "hack/yamltojson.py", line 4, in <module>
01:30:44     yaml_object = yaml.safe_load(yaml_in)
01:30:44   File "/usr/lib64/python3.6/site-packages/yaml/__init__.py", line 94, in safe_load
01:30:44     return load(stream, SafeLoader)
01:30:44   File "/usr/lib64/python3.6/site-packages/yaml/__init__.py", line 72, in load
01:30:44     return loader.get_single_data()
01:30:44   File "/usr/lib64/python3.6/site-packages/yaml/constructor.py", line 35, in get_single_data
01:30:44     node = self.get_single_node()
01:30:44   File "/usr/lib64/python3.6/site-packages/yaml/composer.py", line 36, in get_single_node
01:30:44     document = self.compose_document()
01:30:44   File "/usr/lib64/python3.6/site-packages/yaml/composer.py", line 55, in compose_document
01:30:44     node = self.compose_node(None, None)
01:30:44   File "/usr/lib64/python3.6/site-packages/yaml/composer.py", line 84, in compose_node
01:30:44     node = self.compose_mapping_node(anchor)
01:30:44   File "/usr/lib64/python3.6/site-packages/yaml/composer.py", line 133, in compose_mapping_node
01:30:44     item_value = self.compose_node(node, item_key)
01:30:44   File "/usr/lib64/python3.6/site-packages/yaml/composer.py", line 82, in compose_node
01:30:44     node = self.compose_sequence_node(anchor)
01:30:44   File "/usr/lib64/python3.6/site-packages/yaml/composer.py", line 111, in compose_sequence_node
01:30:44     node.value.append(self.compose_node(node, index))
01:30:44   File "/usr/lib64/python3.6/site-packages/yaml/composer.py", line 84, in compose_node
01:30:44     node = self.compose_mapping_node(anchor)
01:30:44   File "/usr/lib64/python3.6/site-packages/yaml/composer.py", line 127, in compose_mapping_node
01:30:44     while not self.check_event(MappingEndEvent):
01:30:44   File "/usr/lib64/python3.6/site-packages/yaml/parser.py", line 98, in check_event
01:30:44     self.current_event = self.state()
01:30:44   File "/usr/lib64/python3.6/site-packages/yaml/parser.py", line 439, in parse_block_mapping_key
01:30:44     "expected <block end>, but found %r" % token.id, token.start_mark)
01:30:44 yaml.parser.ParserError: while parsing a block mapping
01:30:44   in "./scripts/CEE/get-rhosak-operators/metadata.yaml", line 16, column 5
01:30:44 expected <block end>, but found '<scalar>'
01:30:44   in "./scripts/CEE/get-rhosak-operators/metadata.yaml", line 17, column 123
01:30:44 convert failed
01:30:44 make: *** [validation] Error 1
01:30:44 Build step 'Execute shell' marked build as failure
01:30:44 Setting status of 5ccbe258d8d15257b6150a9a0cae63f00c9addd2 to FAILURE with url https://ci.ext.devshift.net/job/openshift-managed-scripts-gh-pr-check/239/ and message: ' '

20:15:14 In ./CEE/get-rhosak-operators/get-rhosak-operators.sh line 16:
20:15:14     oc adm inspect ns/redhat-kas-fleetshard-operator $sinceFlag --dest-dir $directory > "$directory"/rhosak.log 2>&1
20:15:14                                                      ^-- SC2128: Expanding an array without an index only gives the first element.
20:15:14                                                      ^-- SC2086: Double quote to prevent globbing and word splitting.
20:15:14                                                                            ^-- SC2086: Double quote to prevent globbing and word splitting.
20:15:14
20:15:14
20:15:14 In ./CEE/get-rhosak-operators/get-rhosak-operators.sh line 19:
20:15:14     oc adm inspect ns/managed-application-services-observability $sinceFlag --dest-dir $directory > "$directory"/rhosak.log 2>&1
20:15:14                                                                  ^-- SC2128: Expanding an array without an index only gives the first element.
20:15:14                                                                  ^-- SC2086: Double quote to prevent globbing and word splitting.
20:15:14                                                                                ^-- SC2086: Double quote to prevent globbing and word splitting.
20:15:14
20:15:14
20:15:14 In ./CEE/get-rhosak-operators/get-rhosak-operators.sh line 22:
20:15:14     oc adm inspect  ns/redhat-managed-kafka-operator --dest-dir $directory > "$directory"/rhosak.log 2>&1
20:15:14                                                                 ^-- SC2086: Double quote to prevent globbing and word splitting.
20:15:14
20:15:14
20:15:14 In ./CEE/get-rhosak-operators/get-rhosak-operators.sh line 31:
20:15:14     tar -zcf  $directory.tar.gz ./"$directory"
20:15:14               ^-- SC2086: Double quote to prevent globbing and word splitting.
20:15:14

Thank you @wanghaoran1988 for the screenshots im in the process of getting access will let you know when i get it

Build is successful
16:43:41 [openshift-managed-scripts-gh-pr-check] $ /bin/sh -xe /tmp/jenkins7298447734980922126.sh
16:43:42 + '[' -z '' ']'
16:43:42 + exit
16:43:42 Setting status of 02ad8afc4a8d7a3fbd227c7f8a3fe7ee2b8f5a27 to SUCCESS with url https://ci.ext.devshift.net/job/openshift-managed-scripts-gh-pr-check/244/ and message: ' '
16:43:42 Using context: ci.ext.devshift.net PR build
16:43:42 Finished: SUCCESS

/lgtm

/approve


fix for 13.19

replace the Riot__g_window sig with this:
48 8B 0D ? ? ? ? FF 15 ? ? ? ? 48 8B 05 ? ? ? ?

work ?

Where do I find that?

how i do that ?

tysm!

how i do that ?

check the pinned problem "Tutorial : How to change offsets by yourself", there are full guide how to do it by yourself

i dont undrestand bro becuse i dont know english

how i do that ?

check the pinned problem "Tutorial : How to change offsets by yourself", there are full guide how to do it by yourself

how i do that ?

check the pinned problem "Tutorial : How to change offsets by yourself", there are full guide how to do it by yourself

https://github.com/R3nzTheCodeGOD/R3nzSkin/blob/6b41f7b1c47ebbc9a7ca04bf6f1895d94df94e97/R3nzSkin/memory.hpp#L90

You are a hero, bro

i do Riot_g  but he says failed to pattern

pls help me

pls help me

Here are the link for already compiled dll file, you need just to change it in the LoL folder https://mega.nz/folder/6nomVJgA#bLEgLwlU3sdg3xh_Q2XIbQ

pls help me

Here are the link for already compiled dll file, you need just to change it in the LoL folder https://mega.nz/folder/6nomVJgA#bLEgLwlU3sdg3xh_Q2XIbQ

and how do u do that ? where should i put this file to

pls help me

Here are the link for already compiled dll file, you need just to change it in the LoL folder https://mega.nz/folder/6nomVJgA#bLEgLwlU3sdg3xh_Q2XIbQ

and how do u do that ? where should i put this file to

you need just to download the file from the link and replace the file in League of Legends folder with the downloaded one.

pls help me

Here are the link for already compiled dll file, you need just to change it in the LoL folder https://mega.nz/folder/6nomVJgA#bLEgLwlU3sdg3xh_Q2XIbQ

and how do u do that ? where should i put this file to

you need just to download the file from the link and replace the file in League of Legends folder with the downloaded one.

thx bud !

When I put the file "RENZSKIN.DLL" inside the lol folder, "replace" doesn't appear, can anyone help me?

pls help me

Here are the link for already compiled dll file, you need just to change it in the LoL folder https://mega.nz/folder/6nomVJgA#bLEgLwlU3sdg3xh_Q2XIbQ

and how do u do that ? where should i put this file to

you need just to download the file from the link and replace the file in League of Legends folder with the downloaded one.

hey bro, i did this but the error of patern stills, you can help me?

@artcevvv the mega link does not seem to be working


Not compatible with Content Security Policy

When I try to use this extension I get the following errors in the developer console:
Content-Security-Policy: The page’s settings blocked the loading of a resource at inline (“style-src”).
Content-Security-Policy: The page’s settings blocked the loading of a resource at inline (“default-src”).

Could you please share a URL to a website where it fails to load. It might be that CSP settings actually block ARIA DevTools scripts. Do other browser extensions that affect page elements run on your page?

Just as a random example: https://xi.github.io/cryptpadtab/
It seems like the issue has to do with unsafe-inline styles.

I've reproduced the problem. It seems to be Firefox specific. I will check if I can do something about this.


IMPROVEMENT: Image next to the radio button option missing

Stock template:

Materialize template: (The images are missing next to the tool)

I am am only documenting my findings.

Solved it. Correction in product.tpl line 234
<img src="<?php echo $option_value['image']; ?>" data-src="<?php echo $option_value['image']; ?>" alt="<?php echo $option_value['name'] . ($option_value['price'] ? ' ' . $option_value['price_prefix'] . $option_value['price'] : ''); ?>" class="responsive-img">
It works now: If there is no image, I put a blank pixel instead of an image (I didn't feel like coding it)

Solved it. Correction in product.tpl line 234

Maybe I misunderstood you)
For the options with and without the image to be displayed with the same indentation, you do not need to encode already. The paradox is that for an option without an image, you need to specify an empty transparent image, for example:

In Photoshop create a transparent image size 1x1 pixel and save it in .png format (save with transparency);
upload the resulting image to the folder OpenCart;
for the corresponding options specify a transparent image.
As I understand it, this is what you did 😉.


Fix includes for ostream

Currently a missing include in MethodDefinition.h keeps zsomeip from building for Android NDK

fixed with #10


wasmtime 15.0.0 - how to build a static library?

Hi,
I'm using libwasmtime, C API of wasmtime, to build a wasm module for NGINX Unit.
Previously it worked well by specifying crates/c-api/Cargo.toml configuration for cargo.
Since 15.0.0 that doesn't work anymore.  Could you guide me how can I build a static library
for the recent version?
Thank you.

https://github.com/bytecodealliance/wasmtime/pull/7341 changed the layout. Looks like you now have to specify crates/c-api/artifact/Cargo.toml instead.

Thanks for the quick reply, @bjorn3!   That works!

Instead of using --manifest-path whatever/Cargo.toml, use -p wasmtime-c-api for your build scripts to be resilient against these sorts of changes.

Instead of using --manifest-path whatever/Cargo.toml, use -p wasmtime-c-api for your build scripts to be resilient against these sorts of changes.

Thanks for the update, @pchickey!  I'm going to update the build procedure according your recommendations.


help

"someone sent a message from a chat that is not the one that I monitor"
please I have tried my channel id, channel name, channe invite link, my telegram user id, my username and still the same....

hey! this seems like a config problem
you could contact me on telegram for assistance, since it could potentially have some sensitive data you wouldn't wanna share in a github issue
My telegram: @Mikhail_Khromov


A Chat Function

Like a little chat box to talk to her

Communication with Monika is currently out of scope. Try Monika After Story for that :)


New CI badges for Readme.

For travis the build is registered with the org (j2objc-contrib).
For appveyor, the build must be registered with the user (madvayApiAccess).
And yes, the Windows build is correctly failing, see #402.  Fixes #400
Badges via http://shields.io/

LGTM


Added index.ts file to helpers directory, and updated all imports, rearranged the docs

I added the index.ts file to the helpers directory.

Updated all of the imports
Moved main README to packages/examples/ReadME
Created a general readme at for the repo
Added more in-depth zkEmailOverview Docs inside of docs folder

I want to merge this ASAP -- if moving the example repo like this causes problems, can you isolate your docs only changes for now and we can shift the other stuff later?

also i cant stack prs if you make changes from metachase24/docs_editor -- can you change your remote so this is a branch in this repo itself?

Yes, i created a new branch and added only docs changes. I need permission to push my branch to the main repo


SPI E2E tests branch fix

Signed-off-by: Josef Kopriva<EMAIL_ADDRESS>

/retest

/lgtm

Merged in #884


Write after free of RetransTableEntry

TestReadInteraction::TestReadChunking() exhibits a use-after-free of a RetransTableEntry.
Original description (not that it is not necessary to use a heap pool for the use-after-free to occur, but it's harder to trace):

Problem
If ReliableMessageMgr::mRetransTable is a heap-allocated pool, TestReadInteraction aborts:
CHIP:SPT: VerifyOrDie failure at ../../src/lib/core/Optional.h:170: HasValue()

This is surprising and may indicate an underlying memory safety problem.
Proposed Solution
Investigate and resolve.

TestReadInteraction::TestReadChunking leads to a use-after-free of a RetransTableEntry, which has been masked by the use of a static BitMapObjectPool for ReliableMessageMgr::mRetransTable.
Complicated details to follow.

Enter TestReadInteraction::TestReadChunking(…)
At 817: InteractionModelEngine::GetInstance()->GetReportingEngine().Run();
Enter Engine::Run()
At 503: CHIP_ERROR err = BuildAndSendSingleReportData(readHandler);
Enter Engine::BuildAndSendSingleReportData(…)
 Enable chunking.
CHIP:DMG:  Sending report (payload has 907 bytes)...
At 426: err = SendReport(apReadHandler, std::move(bufHandle), hasMoreChunks);
Enter Engine::SendReport(…)
At 638: err = apReadHandler->SendReportData(std::move(aPayload), aHasMoreChunks);
Enter ReadHandler::SendReportData(…)
CHIP:DMG: IM RH moving to [AwaitingReportResponse]
At 221: mpExchangeCtx->SendMessage(Protocols::InteractionModel::MsgType::ReportData, std::move(aPayload),
At 222:                            Messaging::SendFlags(noResponseExpected ? Messaging::SendMessageFlags::kNone
At 223:                                                                    : Messaging::SendMessageFlags::kExpectResponse));
Enter SendMessage(…)
At 126: return SendMessage(Protocols::MessageTypeTraits<MessageType>::ProtocolId(), to_underlying(msgType), std::move(msgPayload), …)
Enter ExchangeContext::SendMessage(…)
At 179: CHIP_ERROR err = mDispatch.SendMessage(GetExchangeMgr()->GetSessionManager(), mSession.Get(), mExchangeId, IsInitiator(),
At 180:                                        GetReliableMessageContext(), reliableTransmissionRequested, protocolId, msgType,
At 181:                                        std::move(msgBuf));
Enter ExchangeMessageDispatch::SendMessage(…)
CHIP:EM: Piggybacking Ack for MessageCounter:12451190 on exchange: 22567r
Here the RetransTableEntry for MessageCounter:10983592 is created and retained in entryOwner:
At 80: ReturnErrorOnFailure(reliableMessageMgr->AddToRetransTable(reliableMessageContext, &entry));
At 84: std::unique_ptr<ReliableMessageMgr::RetransTableEntry, decltype(deleter)> entryOwner(entry, deleter);
CHIP:IN: Prepared secure message 0x7ffff7fb4b88 to 0x000000000001E306 (1)  of type 0x5 and protocolId (0, 1) on exchange 22567r with MessageCounter:10983592.
At 87: CHIP_ERROR err = sessionManager->SendPreparedMessage(session, entryOwner->retainedBuf);
Enter SessionManager::SendPreparedMessage(…)
CHIP:IN: Sending encrypted msg 0x7ffff7fb4b88 with MessageCounter:10983592 to 0x000000000001E306 (1) at monotonic time:<PHONE_NUMBER> msec
At 289: return mTransportMgr->SendMessage(*destination, std::move(msgBuf));
Enter Transport::Tuple::SendMessage()
Enter LoopbackTransport::SendMessage()
At 112: HandleMessageReceived(address, std::move(receivedMessage));
Enter Transport::Base::HandleMessageReceived()
Enter TransportMgrBase::HandleMessageReceived(…)
At 71: mSessionManager->OnMessageReceived(peerAddress, std::move(msg));
Enter SessionManager::OnMessageReceived(…)
At 399: SecureUnicastMessageDispatch(packetHeader, peerAddress, std::move(msg));
Enter SessionManager::SecureUnicastMessageDispatch(…)
At 510: if (SecureMessageCodec::Decrypt(secureSession->GetCryptoContext(), payloadHeader, packetHeader, msg) != CHIP_NO_ERROR)
Here packetHeader.GetMessageCounter() = 10983592
At 557: mCB->OnMessageReceived(packetHeader, payloadHeader, session.Value(), peerAddress, isDuplicate, std::move(msg));
Enter ExchangeManager::OnMessageReceived(…)
CHIP:EM: Received message of type 0x5 with protocolId (0, 1) and MessageCounter:10983592 on exchange 22567i
CHIP:EM: Found matching exchange: 22567i, Delegate: 0x7fffffffab00
At 219: ec->HandleMessage(packetHeader.GetMessageCounter(), payloadHeader, source, msgFlags, std::move(msgBuf));
Enter ExchangeContext::HandleMessage(…)
At 455: mDispatch.OnMessageReceived(messageCounter, payloadHeader, peerAddress, msgFlags, GetReliableMessageContext()));
Enter ExchangeMessageDispatch::OnMessageReceived(…)
At 128: reliableMessageContext->HandleRcvdAck(payloadHeader.GetAckMessageCounter().Value());
Enter ReliableMessageContext::HandleRcvdAck(…)
At 86:     if (!GetReliableMessageMgr()->CheckAndRemRetransTable(this, ackMessageCounter))
CHIP:EM: Rxd Ack; Removing MessageCounter:12451190 from Retrans Table on exchange 22567i
CHIP:EM: Removed CHIP MessageCounter:12451190 from RetransTable on exchange 22567i
Return to ExchangeMessageDispatch::OnMessageReceived(…)
Return to ExchangeContext::HandleMessage(…)
At 487: return mDelegate->OnMessageReceived(this, payloadHeader, std::move(msgBuf));
Enter RROR ReadClient::OnMessageReceived(…)
At 308:         err = ProcessReportData(std::move(aPayload));
Enter ReadClient::ProcessReportData(…)
CHIP:DMG: ReportDataMessage =
CHIP:DMG: {
CHIP:DMG:  AttributeReportIBs =
CHIP:DMG:  [
⋮
CHIP:DMG:  ],
CHIP:DMG:
CHIP:DMG:  MoreChunkedMessages = true,
CHIP:DMG:  InteractionModelRevision = 1
CHIP:DMG: }
At 504: err = StatusResponse::Send(err == CHIP_NO_ERROR ? Protocols::InteractionModel::Status::Success
At 505:                                     : Protocols::InteractionModel::Status::InvalidSubscription,
At 506:                mpExchangeCtx, !noResponseExpected);
Enter StatusResponse::Send(…)
At 39: ReturnErrorOnFailure(apExchangeContext->SendMessage(Protocols::InteractionModel::MsgType::StatusResponse, std::move(msgBuf),
At 40:                                                     aExpectResponse ? Messaging::SendMessageFlags::kExpectResponse
At 41:                                                                     : Messaging::SendMessageFlags::kNone));
Enter ExchangeContext::SendMessage(…)
At 179: CHIP_ERROR err = mDispatch.SendMessage(GetExchangeMgr()->GetSessionManager(), mSession.Get(), mExchangeId, IsInitiator(),
At 180:                                        GetReliableMessageContext(), reliableTransmissionRequested, protocolId, msgType,
At 181:                                        std::move(msgBuf));
Enter ExchangeMessageDispatch::SendMessage(…)
CHIP:EM: Piggybacking Ack for MessageCounter:10983592 on exchange: 22567i
CHIP:IN: Prepared secure message 0x7ffff7fb4ae8 to 0x0000000006A11E3D (1)  of type 0x1 and protocolId (0, 1) on exchange 22567i with MessageCounter:12451191.
At 87: CHIP_ERROR err = sessionManager->SendPreparedMessage(session, entryOwner->retainedBuf);
Enter SessionManager::SendPreparedMessage(…)
CHIP:IN: Sending encrypted msg 0x7ffff7fb4ae8 with MessageCounter:12451191 to 0x0000000006A11E3D (1) at monotonic time:<PHONE_NUMBER> msec
At 289: return mTransportMgr->SendMessage(*destination, std::move(msgBuf));
Enter Transport::Tuple::SendMessage()
Enter LoopbackTransport::SendMessage()
At 112: HandleMessageReceived(address, std::move(receivedMessage));
Enter Transport::Base::HandleMessageReceived()
Enter TransportMgrBase::HandleMessageReceived(…)
At 71: mSessionManager->OnMessageReceived(peerAddress, std::move(msg));
Enter SessionManager::OnMessageReceived(…)
At 399: SecureUnicastMessageDispatch(packetHeader, peerAddress, std::move(msg));
Enter SessionManager::SecureUnicastMessageDispatch(…)
At 557: mCB->OnMessageReceived(packetHeader, payloadHeader, session.Value(), peerAddress, isDuplicate, std::move(msg));
Enter ExchangeManager::OnMessageReceived(…)
CHIP:EM: Received message of type 0x1 with protocolId (0, 1) and MessageCounter:12451191 on exchange 22567r
CHIP:EM: Found matching exchange: 22567r, Delegate: 0x7ffff7fa2f00
At 219: ec->HandleMessage(packetHeader.GetMessageCounter(), payloadHeader, source, msgFlags, std::move(msgBuf));
Enter ExchangeContext::HandleMessage(…)
At 455: mDispatch.OnMessageReceived(messageCounter, payloadHeader, peerAddress, msgFlags, GetReliableMessageContext()));
Enter ExchangeMessageDispatch::OnMessageReceived(…)
At 128: reliableMessageContext->HandleRcvdAck(payloadHeader.GetAckMessageCounter().Value());
Enter ReliableMessageContext::HandleRcvdAck(uint32_t ackMessageCounter = __10983592__)
Here the RetransTableEntry for MessageCounter:10983592 is deleted:
At 86: if (!GetReliableMessageMgr()->CheckAndRemRetransTable(this, ackMessageCounter))
CHIP:EM: Rxd Ack; Removing MessageCounter:10983592 from Retrans Table on exchange 22567r
CHIP:EM: Removed CHIP MessageCounter:10983592 from RetransTable on exchange 22567r
Return to ExchangeMessageDispatch::OnMessageReceived(…)
Return to ExchangeContext::HandleMessage(…)

At 102: reliableMessageMgr->StartRetransmision(entryOwner.release());
Enter ReliableMessageMgr::StartRetransmision(…)
Here we have read and write of the deleted RetransTableEntry:
At 207: entry->nextRetransTime = System::SystemClock().GetMonotonicTimestamp() + entry->ec->GetSessionHandle()->GetMRPConfig().mIdleRetransTimeout;

So the fundamental problem, I expect, is that this test uses the sync-message-delivery loopback mode that I thought we had stopped using....  but it looks like a bunch of tests still use it:

TestWriteInteraction
TestCommandInteraction
TestEventLogging
TestReportingEngine
TestReadInteraction
TestInteractionModelEngine.cpp
TestBufferedReadCallback
TestAttributeCache

We should probably fix them all to not do that and see whether that addresses this issue.
@mrjerryjohns

Suspected it might be test-only when I hit LoopbackTransport.
The Interaction tests and TestReportingEngine hit this; the others pass ASAN.

Looks like this is fixed now that all the unit tests use async messaging.  I just tried making the retrans table into an ObjectPool and it passes for me.  See https://github.com/project-chip/connectedhomeip/pull/20058


Cloud rebranding

Coverage remained the same at 54.223% when pulling 7e73a535a8d57e8aab11e66921a0f416e2ef73f9 on cloud into dbe5bf420277f62616896f450d5261c695519cd4 on development.


Three facilities with Chinese addresses have plotted in China, despite having "India" in the country column

Overview
Three facilities contributed to the OAR have addresses in China but, erroneously, have India listed as the country in the data upload. These facilities have plotted on the map in China, but appear in India country searches.
https://openapparel.org/facilities/IN2020217JJAJW1?contributors=139&countries=IN
https://openapparel.org/facilities/IN2020217A108YP
https://openapparel.org/facilities/IN202022057W0HR
Expected Behavior
The combination of country and address details should have produced an error message having been processed and not plotted on the OAR.
Actual Behavior
The facilities were plotted in China.
Demo
Raw data:

Additional context
Note from @jwalgran
The geocoder does return country information, so we can compare this to the country specified by the contributor and put the item into an error state if they do not match.

There's more
https://openapparel.org/facilities/IN2020066H3FY4C?q=IN2020066H3FY4C
@katieashaw @jwalgran @hlennett

I noticed for the first time today that these facilities plotted in China appear when you run a Country search for India:

Your suggested fix works for me @dboyer My broader question is around why / how the facilities got plotted, given the discrepancy of "India" in the country column and Chinese address data in the address field?

The new geocode tool in the dashboard will help us answer this question. We can try replicating the address/county code mismatch and check Google's response.
My guess is that Google is using the county code  as a suggestion or a tiebreaker, not a filter. If that is the case we can consider adding some additional validation to our process that would reject  these mismatched entries.


[B9] Cant make Thaumonomicon

I did the dream stuff, but when i used Salis Mundus on the Bookcase, It played the animation but the the bookcase just poofed out of existence and i get neither the book nor the research.

I just ran into this myself.

I have yet to find a solution to this. This is still happening for me.
https://github.com/Azanor/thaumcraft-beta/issues/1257

I have a similar problem but MC crashes right after the sparkles begin. 1.10.2 forge 2239 then 2511; I also have Thaumic JEI and TC Inv Scanning, and wonder if it's a TC bug or an addon bug?


🐛 BUG: vitest-pool-workers Cannot use require() to import an ES Module

Which Cloudflare product(s) does this pertain to?
Workers Vitest Integration
What version(s) of the tool(s) are you using?
3.78.2 [wrangler], 0.5.2 [vitest-pool-workers]
What version of Node are you using?
20.17.0
What operating system and version are you using?
Mac Sonoma 14.6.1 (23G93)
Describe the Bug
Observed behavior
When using the @clerk/backend package and @cloudflare/vitest-pool-workers tests do not run successfully.
The reported error is TypeError: Cannot use require() to import an ES Module. and it happens because of the snakecase-keys module that clerk uses.
It is worth noting that this error does not stop the actual worker from functioning, esbuild is able to handle this when building and deploying this worker.
I did try to solve this by using deps.inline however this didn't work either.
Expected behavior
I'm no expert in JS bundlers but I feel like this should be a solvable problem? Otherwise we are severly limited in what deps we can use when working with Cloudflare workers.
Please provide a link to a minimal reproduction
https://github.com/AdiRishi/vitest-pool-esm-bug
Please provide any relevant error logs
[vpw:inf] Starting isolated runtimes for vitest.config.mts...
 ❯ test/index.spec.ts (0)

⎯⎯⎯⎯⎯ Failed Suites 1 ⎯⎯⎯⎯⎯

 FAIL  test/index.spec.ts [ test/index.spec.ts ]
TypeError: Cannot use require() to import an ES Module.
 ❯ Users/arishi/playground/vitest-pool-esm-bug/node_modules/.pnpm/snakecase-keys@5.4.4/node_modules/snakecase-keys/index.js?mf_vitest_no_cjs_esm_shim:4:23

 Test Files  1 failed (1)
      Tests  no tests
   Start at  15:41:01
   Duration  771ms (transform 25ms, setup 0ms, collect 0ms, tests 0ms, environment 0ms, prepare 138ms)

[vpw:dbg] Shutting down runtimes...
 ELIFECYCLE  Test failed. See above for more details.

Thank you for creating the issue.
I tested the following versions but encountered the same error:

"vitest": "1.5.0" && "@cloudflare/vitest-pool-workers": "0.4.31"
"vitest": "2.1.1" && "@cloudflare/vitest-pool-workers": "0.5.7"

I hope for a resolution to this issue.

I have the same problem

Hey, I had a look at your repro and it seems like vitest will work if you change your config to:
deps: {
    inline: ['@clerk/backend', 'snakecase-keys', 'snake-case'],
}

Let me know if you're still having issues :)

@emily-shen thank you so much!
I can't believe I didn't think to include the actual @clerk/backend package in deps.inline 🤦
Your fix absolutely works 😄 . I'll close this issue out 💥 .
For anyone worried about the vitest deprecation warning that comes with using deps.inline, you can achieve the same effect with server.deps.inline
server: {
    deps: {
        inline: ['@clerk/backend', 'snakecase-keys', 'snake-case'],
    },
},

I've been following this and will have to see if including more in the inline deps fixes the same issue with hono.


I know the case is a bit crazy, the jinja template are automatically generated.
Anyway thanks for the work in this library and for your help.

Have you considered generating MYID in (.....) instead?

This seems to indicate that there's a better way to write the code you're writing.
Memory sounds like something you'd need to configure in Python, not Jinja. I'm not sure how you would do that. That said, if you happen to want to dig into this and find some way to optimize the memory use of the compiler, I'm open to that, but I'm not going to leave this issue open for that.

Have you considered generating MYID in (.....) instead?

@ThiefMaster The condition is not directly generated by me, but yes I could detect this kind of pattern and handle it to rewrite the condition as a in ....
@davidism well in python there is no issue to handle this kind of condition that's why I thought it was more related to Jinja than juste Python, for my personal knowledge could your explain me or point to me the file which handle this kind of logic in the library ?
Thanks for your answers


move data_probe tools to analysis

move data_probe tools to analysis for importing it easily

Better to add seaborn dependency


logo assets added & favicon update!

Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

@niteshseram As you have worked in mapping the favicons and other PWA-related icons in the manifest, could you please keep this on the radar? Once we merge it, let's have an issue using the logo image that @kvnal is creating as part of this PR.

@niteshseram As you have worked in mapping the favicons and other PWA-related icons in the manifest, could you please keep this on the radar? Once we merge it, let's have an issue using the logo image that @kvnal is creating as part of this PR.

Sure. Once this PR is merged, I will create an issue to use this logo in the PWA

We need one for the dark theme too

I guess it fully depends on the theme of the browser, not the default theme. its better to change the primary color than having different favicons.

We need one for the dark theme too

I guess it fully depends on the theme of the browser, not the default theme. its better to change the primary color than having different favicons.

ok @kvnal , do you want to take care of the @niteshseram's size feedback and propose a primary color? Btw.. I have seen a few example of picking up favicons based on themes. It would be great to confirm what is the right standard followed.
CC: @max-programming

We need one for the dark theme too

I guess it fully depends on the theme of the browser, not the default theme. its better to change the primary color than having different favicons.

ok @kvnal , do you want to take care of the @niteshseram's size feedback and propose a primary color? Btw.. I have seen a few example of picking up favicons based on themes. It would be great to confirm what is the right standard followed.
CC: @max-programming

We could create another favicon and I have a blog post about how to make it work
https://blog.usman-s.me/how-to-change-the-favicon-according-to-system-dark-mode

Hey, @kvnal Do you have any update/need of discussion on this?

Hey, @kvnal Do you have any update/need of discussion on this?

Hi!

is this fine?
PS : I created both favicon for light and dark mode as suggested and resized the .ico

Changes done! pls review and check the deployment!
Thanks!

@kvnal Thanks for the update. I see the favicon is bigger now. But I still see the issue in the darkmode

Also, could yo please resolve the conflict?

@kvnal Thanks for the update. I see the favicon is bigger now. But I still see the issue in the darkmode

Also, could yo please resolve the conflict?

conflict resolved.
maybe because of the custom theme you may have installed in the browser.
have yo tried to refresh the page after changing the system-wide theme? or maybe check the browser's theme settings.

@kvnal Thanks for the update. I see the favicon is bigger now. But I still see the issue in the darkmode

Also, could yo please resolve the conflict?

conflict resolved. maybe because of the custom theme you may have installed in the browser (also it wont work on chrome's Incognito mode) . have yo tried to refresh the page after changing the system-wide theme? or maybe check the browser's theme settings.

I do not have a custom theme actually. Can someone else also test it from preview URL?

I do not have a custom theme actually. Can someone else also test it from preview URL?

@max-programming can you pls test it once?

I do not have a custom theme actually. Can someone else also test it from preview URL?

@max-programming can you pls test it once?

I'll check once I reach home 🙂

I do not have a custom theme actually. Can someone else also test it from preview URL?

@max-programming can you pls test it once?

I'll check once I reach home 🙂

hey! @max-programming Do you have any updates or suggestions on this?

@atapas listener added. pls review
Btw auto changing favicon looks cool tho! but does this have any real use case 🤔?


auto failover to next host in ES_HOSTS not working when health-check is not enabled

When specifying multiple hosts in ES_HOSTS and one is not available an exception is thrown. One would expect automatic failover to another host in the list.
java.util.concurrent.RejectedExecutionException: Rejected execution: Connection refused: no further information: somehost/<IP_ADDRESS>:9400
        at zipkin2.elasticsearch.internal.client.HttpCall.lambda$sendRequest$3(HttpCall.java:173) ~[zipkin-storage-elasticsearch-2.16.2-SNAPSHOT.jar!/:?]
        at java.util.concurrent.CompletableFuture.uniExceptionally(CompletableFuture.java:986) ~[?:?]
        at java.util.concurrent.CompletableFuture$UniExceptionally.tryFire(CompletableFuture.java:970) ~[?:?]
        at java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:506) ~[?:?]
        at java.util.concurrent.CompletableFuture.completeExceptionally(CompletableFuture.java:2088) ~[?:?]
        at com.linecorp.armeria.common.HttpMessageAggregator.fail(HttpMessageAggregator.java:146) ~[armeria-0.90.2.jar!/:?]
        at com.linecorp.armeria.common.HttpMessageAggregator.onError(HttpMessageAggregator.java:60) ~[armeria-0.90.2.jar!/:?]
        at com.linecorp.armeria.common.stream.FilteredStreamMessage$FilteringSubscriber.onError(FilteredStreamMessage.java:277) ~[armeria-0.90.2.jar!/:?]
        at com.linecorp.armeria.common.stream.AbstractStreamMessage$CloseEvent.notifySubscriber(AbstractStreamMessage.java:370) ~[armeria-0.90.2.jar!/:?]
        at com.linecorp.armeria.common.stream.DefaultStreamMessage.notifySubscriberOfCloseEvent(DefaultStreamMessage.java:194) ~[armeria-0.90.2.jar!/:?]
        at com.linecorp.armeria.common.stream.DefaultStreamMessage.handleCloseEvent(DefaultStreamMessage.java:363) ~[armeria-0.90.2.jar!/:?]
        at com.linecorp.armeria.common.stream.DefaultStreamMessage.notifySubscriber0(DefaultStreamMessage.java:306) ~[armeria-0.90.2.jar!/:?]
        at io.netty.util.concurrent.AbstractEventExecutor.safeExecute(AbstractEventExecutor.java:163) ~[netty-common-4.1.39.Final.jar!/:4.1.39.Final]
        at io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:416) ~[netty-common-4.1.39.Final.jar!/:4.1.39.Final]
        at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:515) ~[netty-transport-4.1.39.Final.jar!/:4.1.39.Final]
        at io.netty.util.concurrent.SingleThreadEventExecutor$5.run(SingleThreadEventExecutor.java:918) ~[netty-common-4.1.39.Final.jar!/:4.1.39.Final]
        at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74) ~[netty-common-4.1.39.Final.jar!/:4.1.39.Final]
        at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30) [netty-common-4.1.39.Final.jar!/:4.1.39.Final]
        at java.lang.Thread.run(Thread.java:834) [?:?]
Caused by: io.netty.channel.AbstractChannel$AnnotatedConnectException: Connection refused: no further information:  somehost/<IP_ADDRESS>:9400
Caused by: java.net.ConnectException: Connection refused: no further information
        at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method) ~[?:?]
        at sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:779) ~[?:?]
        at io.netty.channel.socket.nio.NioSocketChannel.doFinishConnect(NioSocketChannel.java:327) ~[netty-transport-4.1.39.Final.jar!/:4.1.39.Final]
        at io.netty.channel.nio.AbstractNioChannel$AbstractNioUnsafe.finishConnect(AbstractNioChannel.java:336) ~[netty-transport-4.1.39.Final.jar!/:4.1.39.Final]
        at io.netty.channel.nio.NioEventLoop.processSelectedKey(NioEventLoop.java:685) ~[netty-transport-4.1.39.Final.jar!/:4.1.39.Final]
        at io.netty.channel.nio.NioEventLoop.processSelectedKeysOptimized(NioEventLoop.java:632) ~[netty-transport-4.1.39.Final.jar!/:4.1.39.Final]
        at io.netty.channel.nio.NioEventLoop.processSelectedKeys(NioEventLoop.java:549) ~[netty-transport-4.1.39.Final.jar!/:4.1.39.Final]
        at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:511) ~[netty-transport-4.1.39.Final.jar!/:4.1.39.Final]
        ... 4 more

#2763 might be related

@anuraaga I assigned you, but if knackered etc, kick it back!

Just to clarify, is this with the health check enabled? It is a much larger issue with Armeria to be able to fallback on connection error which should happen eventually but for now I think we're hoping enabling health check works for these issues. If the client is trying to connect to an invalid host even with health check enabled, then it's a bug in the current implementation.

Yes i had started the server with health-check disabled, as a left-over
when testing the other bug. When i enable health-check there is no issue.
Maybe we should add 'when health-check is not enabled' to the issue title
and decide if this is worth looking into.
On Wed, Aug 21, 2019 at 2:50 PM Anuraag Agrawal<EMAIL_ADDRESS>wrote:

Just to clarify, is this with the health check enabled? It is a much
larger issue with Armeria to be able to fallback on connection error which
should happen eventually but for now I think we're hoping enabling health
check works for these issues. If the client is trying to connect to an
invalid host even with health check enabled, then it's a bug in the current
implementation.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/openzipkin/zipkin/issues/2769?email_source=notifications&email_token=AABPKAHPHKQPDDKPLJGMHQLQFU2Z7A5CNFSM4IOFS2AKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4ZRQWA#issuecomment-523442264,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABPKAEZCGYWBT4QMW5GZR3QFU2Z7ANCNFSM4IOFS2AA
.

This works as intended as long as health-check is enabled, good enough for me !


Custom Match Provisioning Profile Name?

We currently are naming out provisioning profiles "{appIdentifier} Store", but match is not recognizing these and creating "match AppStore {appIdentifier}".
Quick question.
How do I supply a custom provisioning profile name?

Match does not support that functionality.  Please read the code-signing guide in the bot's link above to understand xcode project setup and fastlane.

Match does not support that functionality.  Please read the code-signing guide in the bot's link above to understand xcode project setup and fastlane.


Integrate contractset

This pull request takes the contracts of the contractor and moves them to a stateful object in the proto package. The job of the proto package (which may be renamed) is to manage individual contracts, and perform simple upload/download operations on those contracts.
The biggest advantage here is clean separation of the contracts from all the rest of the state of the contractor. The contracts also now have strict safety properties, which will eliminate the race conditions that we were running into. Finally, the contracts have been moved to a highly scalable 'one file per contract' model, which means we can perform all contract operations with ACID guarantees in a constant number of disk operations, without needing to amortize any expensive operations at all.
Once this is merged and tested, we should be ready to release RC2.

Did you mean to PR contract-wal? These aren't my latest commits. contract-wal extends integrate-contractset.

ah, did not realize.


instance label in ******_gtFine_instanceIds.png

I use the tool json2instanceImg.py to generate instance labels, but in the png image genereted by json2instancImg.py , different car instances(for example) seem to have the same label.
As well, after i colored  the png image, i found that the color of different car instances have the same color.
Also with other classes such as person, different persons have the same instance label.
In json2instancImg.py, different instances are drawed with a unique id combined of class id and instance id, but in result png images, i can't find the defference between labels of instances.
Could you give some advice?
Thx a lot!

Did you make sure to properly read/write the 16 bit png images? The range of values of the instance ID images is 0...65535. Please make sure that you have any values >255, otherwise the image loading is the issue.

Ok, I find out that it was because I loaded the 8 bit png images, loading png images with 16 bit is all right. Thank you very much!

Hi, I would like to ask how to generate Cityscapes datasets that can be used for instance segmentation? After I do the format conversion using the script in the Cityscapes project, it doesn't differentiate the instances with different colors.
For example:

@mcordts @wenhe-jia


Can it write out which file(s) were built?

I don't know if this is related to esbuild or esbuild-rails but, when I'm running my bin/dev script, the result of my javascript compilation isn't being output.  Each time the sass plugin compiles a file it shows up in my Foreman output.
I'd love it if the javascript compilation process did that too.  My config file is the same as in the README, except for the entry points.
Is this something that can be done?
(e)

This would be more of a question for esbuild but you might want to set the logLevel for esbuild. For example, logLevel: 'info'

That did it.  Now the watch process is telling me when a build started, which file, and when the build finished.  Exactly what I wanted.
Thanks much!


Android: Missing letter 'f' in label of VictoryScatter

Bugs
Checklist

[*] This is a victory-native specific issue. (Issues that also appear in victory should be opened here)

[*] I have read through the FAQ and Guides before asking a question

[*] I am using the latest version of victory-native

[*] I have checked to make sure that my versions of react-native and react-native-svg are compatible with this version of victory-native. Read about version requirements

[*] I've searched open issues to make sure I'm not opening a duplicate issue

The Problem

The first image is from my React Native iPhone app. The second is from Android. The code is the same.
I am facing this weird problem. I am using a VictoryScatter in my React Native app. Everything works great on iOS side. This problem only happens on Android. I am trying to show a label on every data point on the scatter graph. Everything works great until I used "Office" as a label. The label shows as "O fice" on Android. The first 'f' becomes a space. I have played some scenario. Here are what I found.
if the label starts with 'ff' -- worked fine.
if the label ends with 'ff' -- works fine.
one 'f' -- works fine.
if 'ff' in middle of a label, the first 'f' becomes a space.
<EMAIL_ADDRESS><EMAIL_ADDRESS>Is this a bug?

<EMAIL_ADDRESS>requires<EMAIL_ADDRESS><EMAIL_ADDRESS>was a breaking change for victory-native, we're working to resolve it, but we're not tracking down bugs that occur with these incompatible versions. Can you try downgrading to<EMAIL_ADDRESS>and see if the bug persists?

I stayed with<EMAIL_ADDRESS>and downgraded react-native-svg to 6.1.4, 6.1.3, 6.1.2 and 6.1.1. I got the same results for all<EMAIL_ADDRESS>release. I couldn't use 6.1.0 because of a compiler error. Please let me know what else I can try. Thanks!

I have create a sample app which can reproduce this problem. Here are the steps.

react-native init victory_issue
cd victory_issue/
npm install --save victory-native
npm install --save<EMAIL_ADDRESS>react-native link react-native-svg
replace your app.js with mine at bottom.
react-native run-android

--------------------------------- App.js ----------------------------------------
/**

Sample React Native App
https://github.com/facebook/react-native
@flow
*/

import React, { Component } from 'react';
import {
Platform,
StyleSheet,
Text,
View,
Dimensions,
} from 'react-native';
import {
Defs,
RadialGradient,
Stop,
Svg,
} from "react-native-svg";
import {
VictoryChart,
VictoryContainer,
VictoryAxis,
VictoryScatter,
VictoryTheme,
VictoryStack,
VictoryArea,
} from 'victory-native';
type Props = {};
export default class App extends Component {
constructor(props) {
super(props);
this.state = {
data: [{
x: 150,
y: 150,
size: 100,
}],
}
}
render() {
return (

<Svg
width={320}
height={320}
viewBox="0 0 320 320"
style={{ width: "100%", height: "auto" }}>
<VictoryChart
standalone={false}
width={320}
height={320}
padding={5}

              <Defs>
                  <RadialGradient id="greenGradient"
                      x1="0%" y1="0%" x2="0%" y2="100%"
                      cx="50%" cy="50%" r="60%"
                      >
                      <Stop offset="0%" stopColor='#0EFF04'/>
                      <Stop offset="100%" stopColor='#4a4a4a'/>
                  </RadialGradient>
              </Defs>
              <VictoryAxis style={{axis: {stroke: '#424242'},}}/>
              <VictoryScatter
                  name="scatter"
                  style={{
                      data: {
                          fill: data => "url(#greenGradient)"
                      },
                      labels: {
                          fontSize: (data) => 50,
                          padding: (data) => -25,
                          fill: '#fff',
                      },
                  }}
                  data={this.state.data}
                  labels={(datum) => {
                      return 'Office';
                  }}
              />
          </VictoryChart>
      </Svg>
  </View>
);

}
}
const styles = StyleSheet.create({
container: {
flex: 1,
justifyContent: 'center',
alignItems: 'center',
backgroundColor: '#424242',
},
});

I have played a little more and narrowed down a little. As long as a label contains "ffi" combination, the first "f" becomes a space regardless of the position of "ffi".


UndocumentedPublicClass in conjunction with typealias

I've got a few cases where I've got const or typealias before my class declaration which does get flagged by UndocumentedPublicClass:
/**
 * @author niklasbaudy / vanniktech
 * @since 04.07.17
 */
typealias Foo = Int

interface Bar {
}

Should this get flagged? In the case of typealias it needs to be outside of the interface declaration.

Yep, because the comment is clearly over typealias in the AST. You need to move the typealias belowe the interface ^^

Yup I can understand this although I'd look weird if it would be this way:
typealias Foo = Int

/**
 * @author niklasbaudy / vanniktech
 * @since 04.07.17
 */
interface Bar {
}

There are also imports and package so not that odd ;) closing this?

Sure :D


Can't download from Hydra[BUG]

Describe the bug
When I go on a game page, I can't seem to download any repack of it, and this happens to all of them, no matter what game.
Steps to Reproduce

Go to catalogue
Choose any game
See the error

Expected behavior
I expected for repack list to show up.
Screenshots

Operating System
Windows 10
Hydra Version
v2.0.3 "Leviticus"
Additional Information
No response

you can find information about this here: https://hydra-launcher.gitbook.io/hydra
you can find sources in the closed issues

Is having to add sources a new thing? Because on my old installation I've never had to do it in order to download stuff.


closes #17

This PR load proverbs from API on index page

Coverage increased (+1.8%) to 88.536% when pulling 901bfbbe539dc9b27da3bd8a977eb279a6b76612 on feature/#17/load-index-from-api into e1ce61fc4e75fda1f9095ccb126635d5d98e1728 on develop.

Coverage increased (+1.8%) to 88.536% when pulling e53521d7a8e0e9b5c233375f15cd49967eda54bc on feature/#17/load-index-from-api into e1ce61fc4e75fda1f9095ccb126635d5d98e1728 on develop.

Coverage increased (+1.8%) to 88.536% when pulling 0415e158e08cab9dce381a024ad34f86cae91a08 on feature/#17/load-index-from-api into e1ce61fc4e75fda1f9095ccb126635d5d98e1728 on develop.

Coverage increased (+1.8%) to 88.536% when pulling b6b88d5f6e77573715ab75f15c3d07a1a5f9b269 on feature/#17/load-index-from-api into e1ce61fc4e75fda1f9095ccb126635d5d98e1728 on develop.

Coverage increased (+1.8%) to 88.536% when pulling 4eabe6d981f8bfeaa94bb750656547f8017eab70 on feature/#17/load-index-from-api into e1ce61fc4e75fda1f9095ccb126635d5d98e1728 on develop.

Coverage increased (+1.8%) to 88.536% when pulling 62fb77d288439de0f0d05809cf9e7eff8b10ca0f on feature/#17/load-index-from-api into e1ce61fc4e75fda1f9095ccb126635d5d98e1728 on develop.

Coverage increased (+1.8%) to 88.536% when pulling a383f4a64cfb21e4cdd7609c4fa9cb0c3fc08b57 on feature/#17/load-index-from-api into e1ce61fc4e75fda1f9095ccb126635d5d98e1728 on develop.

Coverage increased (+1.2%) to 88.007% when pulling 9711ee9537416a4eada37c2453fabad15313cfb3 on feature/#17/load-index-from-api into e1ce61fc4e75fda1f9095ccb126635d5d98e1728 on develop.

Coverage increased (+1.8%) to 88.536% when pulling 47bb8b23bce92deabcab2a3608cc87e3ddf37606 on feature/#17/load-index-from-api into e1ce61fc4e75fda1f9095ccb126635d5d98e1728 on develop.

Coverage increased (+1.8%) to 88.536% when pulling 47bb8b23bce92deabcab2a3608cc87e3ddf37606 on feature/#17/load-index-from-api into e1ce61fc4e75fda1f9095ccb126635d5d98e1728 on develop.


#406 fix group query based on candidate users

Description
Short description or comments
Reference
Issues #406

Polayflow is already released, if build fails, just rebuild it again

LGTM