Node process.domain behavior broken when running code using Jest

🐛 Bug Report
Jest seems to modify the process object in such a way that breaks the ability to run code inside a domain - i.e., process.domain does not change to be the current domain set by calling the enter() method of a domain or running an arbitrary code through the run() method.

I know this feature is deprecated in node, yet we still have some production-code using it heavily - so suggestions to stop using this modules are unfortunately invaluable at the moment.

To Reproduce
Steps to reproduce the behavior:
Run jest with the following spec file (not setup or actual production-code required):
const domain = require('domain')

describe('node domain', () => {
  test('should show that the current domain is used when running a function using domain.run(...)', () => {
    const d = domain.create()

    d.run(() => {
        expect(process.domain).not.toBeNull()
    })
  })
})

Expected behavior
The test above should pass, since process.domain should be set to the actual domain object in which the code is being run. See https://nodejs.org/docs/latest-v8.x/api/domain.html#domain_domain_enter.
Running the test in mocha + chai (with the relevant changes to the test only - requiring expect from chai and changing the matcher to not.to.be.null) results in a passing test.
Link to repl or repo
https://repl.it/@HarelMoshe/testNodeDomains
Output from npx envinfo --preset jest:
 System:
    OS: macOS High Sierra 10.13.2
    CPU: x64 Intel(R) Core(TM) i7-7820HQ CPU @ 2.90GHz
  Binaries:
    Node: 8.12.0 - ~/.nvm/versions/node/v8.12.0/bin/node
    Yarn: 1.6.0 - /usr/local/bin/yarn
    npm: 5.10.0 - ~/.nvm/versions/node/v8.12.0/bin/npm
  npmPackages:
    jest: ^23.6.0 => 23.6.0

I doubt we'll spend time implementing support for domains in Jest seeing as it's deprecated. However, if the diff is minimal, a PR is of course welcome 🙂 The process object is created here: https://github.com/facebook/jest/blob/5eb9d36687d01059570182c4f33fef6e431dbaf5/packages/jest-util/src/create_process_object.js

Thanks for pointing me to that code @SimenB - it actually made me think about a workaround to make the process object have the domain-related code attached to it prior to Jest performing the copy.
All I had to do is create a global-setup file exporting the following:
test/setup/global-setup.js:
module.exports = () => { require('domain') }

and use it as the global-setup file in my jest.config.js file:
module.exports = {
  globalSetup: `test/setup/global-setup.js`
}

Since require-ing the domain module has the side-effect on process in the global-setup phase - i.e., prior to Jest making its copy - that logic is persisted to the copy and everything seems to work fine.

For anyone subscribed: should be fixed in #9136 which will come in Jest 25

Hi, @SimenB . Could you update jest@next on npm? Seems it's still a version published 3 months ago.

ping @SimenB


Custom error messages for file schema validation

Working on adding the ability for pipeline devs to write nicer / more user friendly error message strings to go into the validation.

Ok, I think I'm about there. We can now set custom error messages in the schema and the error message output formatting is much nicer.
After this PR:

And if there is no custom error message set in the schema (worst-case as is a complex validation error):

Verbose nextflow log always gives full validation errors for debugging. From the top screenshot:
May-12 21:34:09.352 [main] DEBUG nextflow.Nextflow - #: 4 schema violations found
May-12 21:34:09.358 [main] DEBUG nextflow.Nextflow - #/1: 2 schema violations found
May-12 21:34:09.358 [main] DEBUG nextflow.Nextflow - #/1/fastq_1: string [h ttps://raw.githubusercontent.com/nf-core/test-datasets/rnaseq/testdata/GSE110004/SRR6357071_1.fastq.gz] does not match pattern ^\S+\.f(ast)?q\.gz$
May-12 21:34:09.359 [main] DEBUG nextflow.Nextflow - #/1/sample: string [WT REP1] does not match pattern ^\S+$
May-12 21:34:09.359 [main] DEBUG nextflow.Nextflow - #/2/fastq_2: #: no subschema matched out of the total 2 subschemas

Test failures seem unrelated..?

Testing with this samplesheet:
sampe,ft_1,_2,strdedness
WT_REP1,https://raw.githubusercontent.com/nf-core/test-datasets/rnaseq/testdata/GSE110004/SRR6357070_1.fastq.gz,https://raw.githubusercontent.com/nf-core/test-datasets/rnaseq/testdata/GSE110004/SRR6357070_2.fastq.gz,reverse
WT_REP2,https://raw.githubusercontent.com/nf-core/test-datasets/rnaseq/testdata/GSE110004/SRR6357072_1.fastq.gz,https://raw.githubusercontent.com/nf-core/test-datasets/rnaseq/testdata/GSE110004/SRR6357072_2.fastq.gz,reverse

I get the following:

Questions:

Doesn't it make sense to only look in the first line for column headers? I realise that this isn't always the case but given that we are already customising some stuff...I found it a bit confusing that the same error message is repeated
Can we change key to header column name or something in the message to make it clearer as to what is missing
I tried to get the verbose log with -v but that didn't work. Maybe I misunderstood but might be nice to point directly to .nextflow.log if that is the intended pointer?

Testing with this samplesheet:
sample,fastq_1,fastq_2,strandedness
WT_REP1,https://raw.githubusercontent.com/nf-core/test-datasets/rnaseq/testdata/GSE110004/SRR6357070_1.fastq.gz,https://raw.githubusercontent.com/nf-core/test-datasets/rnaseq/testdata/GSE110004/SRR6357070_2.fastq.gz,reverse
WT_REP2,https://raw.githubusercontent.com/nf-core/test-datasets/rnaseq/testdata/GSE110004/SRR6357072_1.faq.gz,,reverse

I get the following:

Questions:

The offending line is actually Row 2. You will notice the file extension is faq.gz there? Be good to test this a little to make sure we are reporting the correct rows in the error messages unless this is expected behaviour? In which case it is quite confusing 😅

Testing with this samplesheet:
"sample","fastq_1","fastq_2","strandedness","accession","altitude","assembly_quality","assembly_software","base_count","binning_software","bio_material","broker_name
","cell_line","cell_type","center_name","checklist","collected_by","collection_date","completeness_score","contamination_score","country","cram_index_aspera","cram_i
ndex_ftp","cram_index_galaxy","cultivar","culture_collection","depth","description","dev_stage","ecotype","elevation","environment_biome","environment_feature","envi
ronment_material","environmental_package","environmental_sample","experiment_accession","experiment_alias","experiment_title","experimental_factor","fastq_aspera","f
astq_bytes","fastq_ftp","fastq_galaxy","fastq_md5","first_created","first_public","germline","host","host_body_site","host_genotype","host_gravidity","host_growth_co
nditions","host_phenotype","host_sex","host_status","host_tax_id","identified_by","instrument_model","instrument_platform","investigation_type","isolate","isolation_
source","last_updated","lat","library_layout","library_name","library_selection","library_source","library_strategy","location","lon","mating_type","nominal_length",
"nominal_sdev","parent_study","ph","project_name","protocol_label","read_count","run_accession","run_alias","salinity","sample_accession","sample_alias","sample_capt
ure_status","sample_collection","sample_description","sample_material","sample_title","sampling_campaign","sampling_platform","sampling_site","scientific_name","seco
ndary_sample_accession","secondary_study_accession","sequencing_method","serotype","serovar","sex","specimen_voucher","sra_aspera","sra_bytes","sra_ftp","sra_galaxy"
,"sra_md5","strain","study_accession","study_alias","study_title","sub_species","sub_strain","submission_accession","submitted_aspera","submitted_bytes","submitted_f
ormat","submitted_ftp","submitted_galaxy","submitted_host_sex","submitted_md5","submitted_sex","target_gene","tax_id"
"SRX7777164","./results/public_data/SRX7777164_T1_1.fastq.gz","./results/public_data/SRX7777164_T1_2.fastq.gz","unstranded","SAMN14154203","","","","159508570","",""
,"","","","SUB6993965","","Wisconsin State Lab of Hygiene","2020-02-14","","","USA: Wisconsin, Madison","","","","","","","Illumina MiSeq sequencing; SARS-CoV-2 vero
E6_illumina","","","","","","","","false","SRX7777164","veroE6_illumina","Illumina MiSeq sequencing; SARS-CoV-2 veroE6_illumina","","fasp.sra.ebi.ac.uk:/vol1/fastq/S
RR111/046/SRR11140746/SRR11140746.fastq.gz;fasp.sra.ebi.ac.uk:/vol1/fastq/SRR111/046/SRR11140746/SRR11140746_1.fastq.gz;fasp.sra.ebi.ac.uk:/vol1/fastq/SRR111/046/SRR
11140746/SRR11140746_2.fastq.gz","61294;23319229;25016500","ftp.sra.ebi.ac.uk/vol1/fastq/SRR111/046/SRR11140746/SRR11140746.fastq.gz;ftp.sra.ebi.ac.uk/vol1/fastq/SRR
111/046/SRR11140746/SRR11140746_1.fastq.gz;ftp.sra.ebi.ac.uk/vol1/fastq/SRR111/046/SRR11140746/SRR11140746_2.fastq.gz","ftp.sra.ebi.ac.uk/vol1/fastq/SRR111/046/SRR11
140746/SRR11140746.fastq.gz;ftp.sra.ebi.ac.uk/vol1/fastq/SRR111/046/SRR11140746/SRR11140746_1.fastq.gz;ftp.sra.ebi.ac.uk/vol1/fastq/SRR111/046/SRR11140746/SRR1114074
6_2.fastq.gz","7daeede4030f4da9f424dcea8cbd39f9;a15660f9cecf8344b74cf2c9564866b7;c89d1a727dee49cd33db6e509c975e6f","2020-02-26","2020-02-26","false","Homo sapiens","
","","","","","","","9606","","Illumina MiSeq","ILLUMINA","","2019-nCoV/USA-WI1/2020 Illumina replicate - Vero E6","passage","2020-02-26","43.0731","PAIRED","veroE6_
illumina","RANDOM PCR","METAGENOMIC","WGS","43.0731 N 89.4012 W","-89.4012","","","","PRJEB39908","","","","358971","SRR11140746","veroE6_Illumina.fastq","","SAMN141
54203","veroE6_illumina","","","This sample has been submitted by pda|gkmoreno on 2020-02-22; Severe acute respiratory syndrome coronavirus 2","","This sample has be
en submitted by pda|gkmoreno on 2020-02-22; Severe acute respiratory syndrome coronavirus 2","","","","Severe acute respiratory syndrome coronavirus 2","SRS6189919",
"SRP250294","","","","","","","","","","","2019-nCoV/USA-WI1/2020","PRJNA607948","PRJNA607948","SARS-CoV-2 parallel sequencing by Illumina and Oxford Nanopore Techno
logies","","","SRA1045991","","","","","","","","","","2697049"
"SRX7777166","./results/public_data/SRX7777166_T1_1.fastq.gz","./results/public_data/SRX7777166_T1_2.fastq.gz","unstranded","SAMN14154205","","","","226957916","",""
,"","","","SUB6993965","","Wisconsin State Lab of Hygiene","2020-02-14","","","USA: Wisconsin, Madison","","","","","","","Illumina MiSeq sequencing; SARS-CoV-2 vero
STAT-1KO_illumina","","","","","","","","false","SRX7777166","veroSTAT-1KO_illumina","Illumina MiSeq sequencing; SARS-CoV-2 veroSTAT-1KO_illumina","","fasp.sra.ebi.a
c.uk:/vol1/fastq/SRR111/044/SRR11140744/SRR11140744.fastq.gz;fasp.sra.ebi.ac.uk:/vol1/fastq/SRR111/044/SRR11140744/SRR11140744_1.fastq.gz;fasp.sra.ebi.ac.uk:/vol1/fa
stq/SRR111/044/SRR11140744/SRR11140744_2.fastq.gz","44060;31411553;33762390","ftp.sra.ebi.ac.uk/vol1/fastq/SRR111/044/SRR11140744/SRR11140744.fastq.gz;ftp.sra.ebi.ac
.uk/vol1/fastq/SRR111/044/SRR11140744/SRR11140744_1.fastq.gz;ftp.sra.ebi.ac.uk/vol1/fastq/SRR111/044/SRR11140744/SRR11140744_2.fastq.gz","ftp.sra.ebi.ac.uk/vol1/fast
q/SRR111/044/SRR11140744/SRR11140744.fastq.gz;ftp.sra.ebi.ac.uk/vol1/fastq/SRR111/044/SRR11140744/SRR11140744_1.fastq.gz;ftp.sra.ebi.ac.uk/vol1/fastq/SRR111/044/SRR1
1140744/SRR11140744_2.fastq.gz","547ec7ddd4d59cfbf19246c6db6907be;439cc63471f416970ba002d75b4c0039;ddac5adc21bd8bee3054c886884c454b","2020-02-26","2020-02-26","false
","Homo sapiens","","","","","","","","9606","","Illumina MiSeq","ILLUMINA","","2019-nCoV/USA-WI1/2020 Illumina replicate - Vero STAT-1 KO","passage","2020-02-26","4
3.0731","PAIRED","veroSTAT-1KO_illumina","RANDOM PCR","METAGENOMIC","WGS","43.0731 N 89.4012 W","-89.4012","","","","PRJEB39908","","","","503344","SRR11140744","ver
oSTAT-1KO_Illumina.fastq","","SAMN14154205","veroSTAT-1KO_illumina","","","This sample has been submitted by pda|gkmoreno on 2020-02-22; Severe acute respiratory syn
drome coronavirus 2","","This sample has been submitted by pda|gkmoreno on 2020-02-22; Severe acute respiratory syndrome coronavirus 2","","","","Severe acute respir
atory syndrome coronavirus 2","SRS6189924","SRP250294","","","","","","","","","","","2019-nCoV/USA-WI1/2020","PRJNA607948","PRJNA607948","SARS-CoV-2 parallel sequen
cing by Illumina and Oxford Nanopore Technologies","","","SRA1045991","","","","","","","","","","2697049"

I get the following:

Questions:

Can we make it work? This is the format of the auto-generated samplesheet when running the SRA download workflow in the pipeline. We need to quote everything because the SRA metadata fields can contain commas too 👀

How does the pipeline handle the quotes? Are they stripped off somewhere downstream? We're parsing the file in exactly the same way as the pipeline here so the quotes are being loaded as part of the strings..
Need to think about the level of customisation with the error reports. Should be doable, but now need to specify whether the code is tabular and whether it has a header row. As if a YAML file for example, then it wouldn't make sense to +1 to the entry index and call it rows / columns.

The Python script takes the user provided samplesheet as input and re-formats it before it is loaded in NF. This has allowed the validation and tweaking of the samplesheet e.g. removing quotes like here:
https://github.com/nf-core/rnaseq/blob/596499865e31d79c225d9aee6a7bd8a8a8f63615/bin/check_samplesheet.py#L51

I think this is best handled by stripping the quotes before passing to validation. Shame the Nextflow function doesn't have an option for this..

Closing this as we now have the nf-validation plugin which takes care of all of this and more!


Add versioning to docs

With recent PRs merged the docs have been updated to the canary version, which leads to them not working for the stable release line. In other words: We need a versioned docs system.
Some learnings from doing that on preactjs.com:

The stable docs should always have a lastest tag in the URL, rather then the version. The stable docs are most likely to be shared and thus most likely recommended by google. In Preact we only went with v8.x etc and that lead to search engines over-indexing old sites.
A version selector is not enough, there needs to be a visual indictor and hint that the user is looking at old docs.

I have a branch for this ready, but I'm not sure if it's the right way to go about it. I'm worried about the overhead in maintenance with keeping multiple versions up to date. Changes would need to be either back ported or forward ported and we should avoid that.

Another idea: I quite like the approach ESLint has taken. They only have a current and a HEAD (=canary) version. Whenever a new release is cut the current docs are replaced with HEAD. See https://eslint.org/docs/head/


Refactor and improve certificate handling

Work in progress. Please help testing these with your setups.

[x] Remove on-host creation of self-signed certificates. It was very limited and partly broken anyway (no updates if expired).
[x] Update custom cert files if they change.
[x] Refactor and simplify tasks

Breaking changes:

On-host self-signed certificate creation was removed. Do that on the ansible host and use bbb_own_cert.

Not sure how to fix the "no-changed-when Commands should not change things if nothing needs doing" warnings, or why the linter checks files outside of the working directory (e.g. ../../../.cache/ansible-lint/274f1a/roles/n0emis.bigbluebutton/tasks/certificate-letsencrypt.yml)

Hi @defnull,
thank you for cleaning this up!
However, this breaks at least my setup, where I have externalized the certificate deployment to another role:
https://github.com/crosscodr/ansible-role-certificates
Maybe we can use such a role here too? What do you think? @BrutalBirdie  @Davka
Concerning this PR, I used the fact, that certificates are only deployed when bbb_own_cert is set.
This is not the case in this PR.
Maybe we should make bbb_own_cert optional, i.e. make it a conditional when calling the certificate.yml tasks.

I didn't use this feature, yet and don't know what the difference  between your two proposals would be. However, cleaning up the commit history is a good idea :)


Difficulty connecting to cloud RaspiBolt testnet node

Hello, and thanks for the awesome wallet! It's a superb piece of software for advanced users.
I've been working my way through the RaspiBolt guide on a cloud machine, trying to get a full testnet setup working. Things are going well, except that I'm at the point where I'm trying to get Sparrow to connect to my Electrum server on the node and for some reason I just can't seem to get it working.
See this comment for my current configurations. I can easily connect Sparrow to an Umbrel setup so I know that side of things is working, but I'm wondering if you'd have any ideas as to what I'm doing wrong, maybe on the RaspiBolt side, maybe in combination with some Sparrow config. Because of the number of variables at play I suspect it's just a combination of things (firewall, Tor, NGINX, SSL) I'm not quite aligning properly.
The error I'm getting on the Sparrow side is mostly this one:
Could not connect:

Error getting fee estimates

This is with with the port 60002 configured in Sparrow and the SSL toggle at on, as well as with my other Tor address (see Stadicus example for the Tor without SSL config) directed at port 60001 with the SSL toggle off.
Any ideas where I might be going wrong?

Issue was fixed as per a tip by @Stadicus to turn the bitcoind config blocksonly toggle off. Cheers!

Nice! I'm linking the Sparrow wallet issue for completeness https://github.com/sparrowwallet/sparrow/issues/354


Consider adding min-width and min-height to compendium browser

Duplicate of https://github.com/foundryvtt/dnd5e/issues/3843


document structure improvements

the terminology and definitions section in the protocol overview does not directly support the subsequent sections, and should probably be moved after scheduling, or just merged with the registration section
the preliminaries section and the terminology and definitions subsection in protocol overview are not very consistently formatted with the rest of the document.

I'm not a fan of this dictionary approach. I didn't say this before, because you seem to like it, but since you're having issues with it, maybe we should remove it altogether as you suggested in your first point. IMO this "let's put down definitions and expect people to memorize them and magically they'll know what we're talking about in later sections" is a lazy approach that does not map how humans understand anything. It'd be different if you're listing stuff to guide the implementors, but most of the time it isn't the case and it is not the case here either.

i moved the terminology stuff around a bit, i also have a version of that commit which is independent of the optimization branch, but it was a simpler change there


V1.6 image too large for 2gb SD Card

Stratux version: stratux-v1.6r1-377d22b403.img

Stratux config:
SDR

[ ] single
[ ] dual

GPS

[ ] yes
[ ] no
type:

AHRS

[ ] yes
[ ] no

power source:
usb cable:

EFB app and version: (e.g., WingX Pro7 8.6.2)
EFB platform: (e.g., iOS 9.2)
EFB hardware: (e.g., iPad Mini 2)

Description of your issue:
I'm trying to write the stratux-v1.6r1-377d22b403.img image to a FAT32 formatted 2gb SD card and the v1.6 image is 2.0gb. The image size is about 45mb too large. Can you shrink the size of one of the partitions and reissue the image?

If possible, enable "Replay Logs", reproduce the problem, and provide a copy of the logs in http://<IP_ADDRESS>/logs/stratux/ and http://<IP_ADDRESS>/logs/stratux.log.

May shrink it in the future. I don't think 2GB are produced any more.


No "REGISTER MODEL"

I do not see a REGISTER MODEL link at all in the actions page, does it still exist?

I might've found out why it doesn't show the Device Registration under Advanced Options. I already had set a fulfillment URL for a smart home, then changed my mind and wanted to do embedded (I suppose, just a guess).
However, I used the googlesamples-assistant-devicetool and added it that way, so now the Device Registration appears. Was a bit confusing and not straight forward, a GUI option would've been nicer ;) .. Hope this helps someone else.

So then how would you go about switching? Should be an option on the actions console to switch, instead of digging through docs to find out other options.

Right now the best way would be to create a new project, which I recognize isn't ideal.


git@github.com:kralo/apriltag-generator.git

hello sir
kindly make this with more thread
thank you
bryce

sorry. please delete this


Constraints

Ok now that #46 is merged, this needs to be rebased atop that

Yeet will do

Rebased!

oh lol it doesn't build. fixing...

No_std passes.

I am going to add a feature about nonnative's density-optimization as well as do a final pass of this PR.

I did one pass of Clippy. I allowed type-complexity and too-many-arguments for many places, but this would remain an issue that we need to address in the future---it is way too complicated, and some structures are not obvious how it works.

The upstream Marlin still has unsatisfied constraints in PC check. Some additional changes may be added.

The upstream Marlin check passes.

On the way to resolve conflicts with https://github.com/arkworks-rs/poly-commit/pull/49

Thanks for resolving the conflicts! It was kind of unfortunate that we had these in-flight PRs that clashed.

I think it would probably take some time to merge (auto-merge is not enough!).

Ok. The conflicts are now resolved. Note that additional changes may be pushed due to Marlin.

Marlin passes. I think I will let @Pratyush and @npwardberkeley do a final pass and then we would merge this, probably today or tomorrow.

Question: why is MarlinKZG10 defined in terms of a CycleEngine`? We only need a constraint field and a pairing engine whose base field is the constraint field, no?

(We would pause here and leave the changes in the constraints branch, and we will come back after the paper deadline.)

I would come back to this soon.
This PR has been a little bit too big and is not easy to review. I plan to break it down.
My next move is to push a small PR only on traits, and we start from there!

Question: why is MarlinKZG10 defined in terms of a CycleEngine? We only need a constraint field and a pairing engine whose base field is the constraint field, no?

Re-upping this: At this point there isn't a need for a cycle engine, right? It's only necessary at the PCD stage

Yes. At this point CycleEngine is almost useless---it does not simplify the where clause of the type.
pub struct VerifierKeyVar<
    CycleE: CycleEngine,
    PG: PairingVar<CycleE::E2, <CycleE::E1 as PairingEngine>::Fr>,
> where
    <CycleE::E2 as PairingEngine>::G1Projective: MulAssign<<CycleE::E1 as PairingEngine>::Fq>,
    <CycleE::E2 as PairingEngine>::G2Projective: MulAssign<<CycleE::E1 as PairingEngine>::Fq>,
    <CycleE::E2 as PairingEngine>::G1Affine:
        ToConstraintField<<<CycleE::E1 as PairingEngine>::Fr as Field>::BasePrimeField>,
    <CycleE::E2 as PairingEngine>::G2Affine:
        ToConstraintField<<<CycleE::E1 as PairingEngine>::Fr as Field>::BasePrimeField>,

As we still carry them everywhere.
How likely would Rust be able to handle this? Ideally, we would delegate the where clause entirely to CycleE.
pub trait CycleEngine: Sized + 'static + Copy + Debug + Sync + Send
where
    <Self::E2 as PairingEngine>::G1Projective: MulAssign<<Self::E1 as PairingEngine>::Fq>,
    <Self::E2 as PairingEngine>::G2Projective: MulAssign<<Self::E1 as PairingEngine>::Fq>,
{
    type E1: PairingEngine;
    type E2: PairingEngine<
        Fr = <Self::E1 as PairingEngine>::Fq,
        Fq = <Self::E1 as PairingEngine>::Fr,
    >;
}

I think Rust should be able to handle this now, after this PR was merged: https://github.com/rust-lang/rust/pull/73905.

Let me have a try. If so, then CycleEngine would be a useful abstraction.

To be clear, I think CycleEngine shouldn't appear in poly-commit, only in ark-pcd, no?

I agree, it shouldn't limit itself to cycles of curves.
Then, let me start simplifying the relations.

Thanks, I think that'll make the implementation clearer as well.

I will be back tomorrow to continue working on this. The rest is to apply previous code review comments.
We might need to split the constraints.rs into a file for its data structures---otherwise, it is way too long.
@howardwu This should reconcile with the upstream changes where the CycleEngine is deprecated. Tomorrow I will jump into Marlin to get it working.

Would you like more reviews on this PR? If so, could there be a short description written up for what its doing? Happy to review then


update in stable and add one to latest

update latest for DasWetter, ebus, PVOutputOrg, sbfspot and semp
add amtronwallbox to latest

@rg-engineering now the stable updates are blocked until review of the new one is done ... was no good idea to mix that ... better to separate in different PRs

Link to adapterrepo https://github.com/rg-engineering/ioBroker.amtronwallbox
Result of manual run of adapter-checker:
[E201] Bluefox was not found in the collaborators on NPM!. Please execute in adapter directory: "npm owner add bluefox iobroker.amtronwallbox"
[W156] Adapter should support admin 5 UI (jsonConfig) if you do not use a React based UI
[W400] Cannot find "amtronwallbox" in latest repository

First of all - THANK YOU for the time and effort you spend to maintain this adapter.
I would like to give some (preliminary) feedback based on my personal oppinion. This is NOT an offical review and @Apollon77 might have several additional suggestions or even a different oppinion to one or the other statement. Please feel free to contact him (or wait for a response from him) if you cannot follow my suggestsions or before you spend major effort.

Please consider splitting PR
I would suggest to split this PR into two parts, one for the version updates at stabel and one for the newly added adapter.
Updates to stabel are normally handled very fast (within a few days maximum) while review process for new adapters might last some time.

Readme.md is very short
Please consider adding some information into readme.md describing what fucntionality the adapter provides, how it is configured etc.

github dependabot support seems to be missing
It looks like you did not yet setup dependabot support; at least .github/dependaboit.yml is missing.
Please consider setting up dependabot support (and to ease life the workflow auto-merge.yml). Dependabot will ensure that your adapter uses the most recent versions of external packages and avoids problem due to outdted base libraries. Dependabot provides PRs at you repository to update the dependencies. Depending on you setting, especially on auto-merge.yml configuration no or only minor revisions will be outmatically merged into you main branch. All major revisions msiut (and should) be reviewed by you. (But this suggestion is definitly not a requirement, jsut a hint.)

Thanks for reading and evalutaing this suggestions.
McM1957


Sails Models should support instanceof

Currently there seems to be no way of verifying the class of a given waterline record. Suppose we have a model called User and we want to check that a given record is an instance of User:
User.create().then(function(newUser) {
    console.log(newUser instanceof User.constructor) // false
});

As far as I can tell, the only waterline-y way of doing this (as opposed to a method which uses Sails routes for model identification) is a hack from this StackOverflow question: http://stackoverflow.com/questions/26446206/how-to-get-the-model-name-or-model-class-of-a-waterline-record/26447442#26447442
Models in Sails should at least support calls to instanceof like their Waterline model counterparts do

+1
Any updates on this?

As far as I can tell this is still a defect

In<EMAIL_ADDRESS>it worked like this:
myuser instanceof User._model.__bindData__[0] === true

however, in<EMAIL_ADDRESS>it's still ok when running in the interactive console, but not ok during the execution of bootstrap.js. I tried to use it after the orm hook loaded, but still no luck.
I try to use the sails models with cancan.js - any thoughts/suggestions?
Thanks a lot!

Any solution | workaround | update on this... ? Trying to put some unit tests together and I didn't find anything on this.

So far the only workaround is in that SO answer http://stackoverflow.com/questions/26446206/how-to-get-the-model-name-or-model-class-of-a-waterline-record/26447442#26447442

Yes I saw, but it doesn't work in sails 0.12 =(

@cyrilchapon I used it in sails 0.12 and not only in the console. Watch out, the code you posted isn't the same as the one on the linked SO answer.


Practice App: Feature - Delete & Edit Art Item

What's up?
Some of the endpoints for Art Item will be covered in this sub-issue. Please refer to #104  for list of all endpoints that will be implemented.

API
API Method
API Description

api/v1/artitems/<int:id>
DELETE
Delete an art item with the given ID

To Do

[x] Implement listed functionalities and corresponding APIs:

[x] Edit an art item with the given ID.
[x] Delete an art item with the given ID.

[x] Write unittests for the APIs. Use Faker to generate mock data.
[x] Create Pull request and assign @sinemKocoglu as reviewer as stated in meeting notes #14

Deadline
18.05.2022 @23.59
Additional Information
No response
Reviewers
@sinemKocoglu

Practice App Implementation is over. No action is taken, closing the issue.


camera.CameraMode is incorrect on first start

Camera.instance.cameraMode seems to be always initializing with CameraMode.FirstPerson.
When you run the attached game.ts you will see that the scene runs the "first person" branch when clicking, even though the player loads into third preson view by default.
Then after pressing 'V' twice the cameraMode is returned correctly. (see floating textShapes)
https://app.zenhub.com/files/389651442/93218fb7-fd32-44bb-9c58-fb3b6971db7b/download

Duplicate with #143


e2e: further group tests

Why do we want to reduce the granularity? Can you explain the motivation behind this PR?

Hierarchical tests management.
Test files are really messy -- full of test methods.
I would like each category have only one root test.
I don't really think this reduce the granularity. I'm fine dividing them further into sub-sub-test.

I would like each category have only one root test.

Please do not do this. We should only do this if the tests fall into what https://blog.golang.org/subtests described.
For example, I do not want to make S3 and PV tests subtests of one huge test case.

full of test methods are OK. It is just like other files that full of functions. Grouping them together will not reduce the number of actual tests funcs either.

@xiang90
S3 and PV in both recovery and restore test are actually subtests. They differed in just a field in spec.

Let's just close this


Fix type/exception annotations in cuSPARSE binding

Closes #7677.

/test mini

CI failures are not related.


Update BaseFeatureContext.php

Don't reset $server array

Code is correct, variable naming could be a bit better. Closing :)


"Mardown post processing" page error

https://marcus.se.net/obsidian-plugin-docs/editor/markdown-post-processing says
"If you want to change how a Markdown document is rendered in ##Preview mode##, you can add your own Markdown post processor." but I think it should say "Reading" / "Read mode".
Thanks for the project, very helpful.

Thank you for the heads-up! 🙏


support debugging statically-linked Swift binaries on macOS

This change supports the scenario of linking multiple Swift
module .o files with multiple .swiftmodule files provided to the
linker.
This change expects the "main" Swift module's .swiftmodule to be
specified first in the -add_ast_path directive given to the clang
linker line.
Fixes:
bugs.swift.org/SR-2637

@swift-ci please test

This still needs a test, but I'm running it through the CI to make sure it doesn't somehow break the Linux side.

@swift-ci please test

Hmm, swift-ci might be out to lunch.  Checking in on that...

@swift-ci please test

The failure in the macOS is happening at the Swift standard library level and is unrelated to this change:
/Users/buildnode/jenkins/workspace/swift-lldb-PR-osx/swift/stdlib/public/SDK/Foundation/URLRequest.swift /Users/buildnode/jenkins/workspace/swift-lldb-PR-osx/swift/stdlib/public/SDK/Foundation/UUID.swift /Users/buildnode/jenkins/workspace/swift-lldb-PR-osx/swift/stdlib/public/SDK/Foundation/Hashing.swift
/Users/buildnode/jenkins/workspace/swift-lldb-PR-osx/swift/stdlib/public/SDK/Foundation/Foundation.swift:978:19: error: subscript does not override any subscript from its superclass
  override public subscript(key: Any) -> Any? {
  ~~~~~~~~        ^
/Users/buildnode/jenkins/workspace/swift-lldb-PR-osx/swift/stdlib/public/SDK/Foundation/Foundation.swift:464:22: error: cannot convert value of type '[Any]' to expected argument type 'NSArray'
    self.init(array: elements)
                     ^~~~~~~~
                              as NSArray
/Users/buildnode/jenkins/workspace/swift-lldb-PR-osx/swift/stdlib/public/SDK/Foundation/Foundation.swift:560:25: error: 'map' produces '[T]', not the expected contextual result type 'OpaquePointer!'
      objects: elements.map { $0.1 as AnyObject },
                        ^
/Users/buildnode/jenkins/workspace/swift-lldb-PR-osx/swift/stdlib/public/SDK/Foundation/Foundation.swift:620:5: error: value of type 'NSDictionary' has no member 'enumerateKeysAndObjects'
    d.enumerateKeysAndObjects({
    ^ ~~~~~~~~~~~~~~~~~~~~~~~
/Users/buildnode/jenkins/workspace/swift-lldb-PR-osx/swift/stdlib/public/SDK/Foundation/Foundation.swift:668:6: error: value of type 'NSDictionary' has no member 'enumerateKeysAndObjects'
    d!.enumerateKeysAndObjects({
    ~^ ~~~~~~~~~~~~~~~~~~~~~~~
/Users/buildnode/jenkins/workspace/swift-lldb-PR-osx/swift/stdlib/public/SDK/Foundation/Foundation.swift:875:5: error: value of type 'NSSet' has no member 'enumerateObjects'
    s.enumerateObjects({
    ^ ~~~~~~~~~~~~~~~~
/Users/buildnode/jenkins/workspace/swift-lldb-PR-osx/swift/stdlib/public/SDK/Foundation/Foundation.swift:915:6: error: value of type 'NSSet' has no member 'enumerateObjects'
    s!.enumerateObjects({
    ~^ ~~~~~~~~~~~~~~~~

I'm going to do a local build and see if this has flushed out of stdlib master.  If so, I'm going to rerun the macOS side of the build.

I've got a note into the stdlib/foundation folks to look at that issue.  I'm not seeing it replicated on normal CI.  I'm going to go ahead and merge this.  I'll pull it out if something unforeseen happens.  I was mostly interested in making sure this didn't break the Linux side, since all the dev work for it is for the benefit of the macOS scenario.

Todd, if I patch this change into the swift-3.0-RELEASE tag branch and build a toolchain from it, will it be functionally the same as the one shipping in Xcode 8 (sans shipping to the Store of course)?

That should work, as long as the only thing you pull in is this patch.
Let me know how it goes!
-Todd

On Sep 17, 2016, at 12:22 PM, Dmitry Shevchenko<EMAIL_ADDRESS>wrote:
Todd, if I patch this change into the swift-3.0-RELEASE tag branch and build a toolchain from it, will it be functionally the same as the one shipping in Xcode 8 (sans shipping to the Store of course)?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or mute the thread.


Unable to find variable GMSServices

I've run tns plugin add nativescript-google-maps-sdk. When I try to run the conditional to initialize the API key on iOS, the compiler reports that it cannot find the variable GMSServices. Any ideas how to fix it?

You're most likely missing CocoaPods.  See step 2 https://developers.google.com/maps/documentation/ios-sdk/start

I followed @dapriett 's answer.
I'm able to open .xcworkspace file, use XCode and run the application.
But when I try using Nativescript CLI running
tns run ios --emulator --watch
Same message comes again.
Any idea?

@dapriett
when I run "pod install", there is error message said
"Could not automatically select an Xcode project, Specify one in your Podfile like so:
project 'path/to/Project.xcodeproj'"
problem is my project is based on nativescript, and there is no xcode project file like Project.xcodeproj
are there any way or somehow to create that?


error: Data based matching requries both --link-dir and --data-dirs

I followed the wiki to set this up and ended up with the container exiting after printing:
error: Data based matching requries both --link-dir and --data-dirs
As I don't pass any directories to dataDirs I assume it's using torrent mode by default but unclear. Others seem to have it working so I'm probably missing something but I've tried to find any relation to my issue on here and looked through the wiki without coming up with anything.
Steps:

Run compose, let it generate the config.js then stop it.
Add torznab url's for each tracker in Prowlarr.
Start container.

config.js
"use strict";
Object.defineProperty(exports, "__esModule", { value: true });
module.exports = {
    delay: 10,
    torznab: [
        "https://prowlarr.domain.io/1/api?apikey=[REDACTED]&tracker=[REDACTED]",
        "https://prowlarr.domain.io/2/api?apikey=[REDACTED]&tracker=[REDACTED]"
    ],
    dataDirs: [],
    matchMode: undefined,
    dataCategory: undefined,
    linkDir: undefined,
    linkType: "symlink",
    skipRecheck: false,
    maxDataDepth: 2,
    torrentDir: "/torrents",
    outputDir: "/cross-seeds",
    includeEpisodes: false,
    includeNonVideos: false,
    fuzzySizeThreshold: 0.02,
    excludeOlder: undefined,
    excludeRecentSearch: undefined,
    action: "save",
    rtorrentRpcUrl: undefined,
    qbittorrentUrl: undefined,
    transmissionRpcUrl: undefined,
    duplicateCategories: false,
    notificationWebhookUrl: undefined,
    port: 2468,
    host: undefined,
    rssCadence: undefined,
    searchCadence: undefined,
};
//# sourceMappingURL=config.template.docker.cjs.map

compose.yml
version: "2.1"

networks:
  s3:
    external: true

services:
    cross-seed:
        image: crossseed/cross-seed
        container_name: cross-seed
        user: 1000:1000
        networks:
          - s3
        volumes:
            - /opt/docker/services/cross-seed/config:/config:rw
            - /opt/docker/services/deluge/config/torrents/:/torrents:ro
            - /opt/docker/services/deluge/watch:/cross-seeds:rw
        command: search```

Looks like this is a bug with the default config. Try setting dataDirs to undefined instead of [].

Yup, spot on. Thank you :)


Command examples in INSTALL.md contain annoying $ command prompt

When you click the copy button for the code snippets in the installation guide, you end up copying the command prompts ($) as well. Pasting it directly in the terminal will cause an error:
(base) Chen-deMacBook-Pro:~ chenni$ $ brew update
-bash: $: command not found
(base) Chen-deMacBook-Pro:~ chenni$ $ brew install goenv

It's very annoying for the user. I think we should remove the unnecessary command prompts so that the user can easily copy and execute the commands.
I'd be glad to create a PR for this. What do you think?

Fair. It's more of a style to add them but I don't mind them removed.
Merged :+1:


Fix h1_client feature

Context: https://github.com/http-rs/http-client/pull/67#issuecomment-778734155

When both "native-tls" and "rustls" features are disabled, disable https.
When both "native-tls" and "rustls" features are enabled, prefer "rustls".
This is the same behavior as http-client 6.2.0.
Ideally, it would be nice if this behavior could be controlled by
environment variables or some other way.

This also adds a CI task to check all feature combinations work properly.

When both "native-tls" and "rustls" features are disabled, disable https.

Note that this fixes the issue in http-client 6.3.0, but is not the same behavior as http-client 6.2.0.
If you want the same behavior as http-client 6.2.0, I can fix it, but that will be actually a patch similar to reverting #67.

Thanks! Sorry I didn't catch this on the last release.

Released in 6.3.1


Clarify Docker bind-mount

Change language clarifying how Molecule can start sibling containers. In my experience, Docker-in-Docker generally refers to the build available at https://hub.docker.com/_/docker used for Docker development. This may be a bit of a nit though 😄.
PR Type

Docs Pull Request

recheck


chore(*): enable verbose publish

Description
Last error said to run with verbose: https://github.com/PolymeshAssociation/signing-managers/actions/runs/11279819918/job/31371451179#step:6:70
I am not sure why the error only appears on the runner. Standard runners have 16GB of RAM + 4 CPU, so its not like they are under powered: https://docs.github.com/en/actions/using-github-hosted-runners/using-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories
Breaking Changes

JIRA Link

Checklist

[ ] Updated the Readme.md (if required) ?

/fast-forward


Delete groups deleting all group rules instead of Selected Ones

Problem
When 3 rules are added and top and bottom are selected and the delete button is clicked. All groups are being deleted instead of just the two selected.

This issue only occurs when multiple rules are added at the same time and one is deleted without closing the popup window. It behaves normally if rules are added window is closed and reopened and then multiple rules are selected and deleted.

Was able to resolve this by adding a method to load fresh values to Global tabGroupsArray and removing the local copy of tabGroupsArray from the parameter in deleteButtonLogic() method since not needed. Resolved.


Dark Mode images Modification

Fixed #1078
Work done

Replaced png images with SVG
Looks great in both light and dark mode.

Screenshots

Great Work @kanchi2438 . Keep it up

Thanks, please do add the open-source day tag to this issue, else it might not be counted.


Cap main exit code to 255

Description
According to POSIX, only lower 8-bits of a program exit code are available through wait() and waitpid() calls. Although there is a newer waitid() interface, I think most of the programs still use the old one. As a result, multiples of 256 wrap to 0 for these programs.
This pull request sets cap to 255 for the default main exit code for better compatiblity. Also the documentation for own-main() is updated.
Reproducer
Tested on macOS Sierra with zsh and Fedora 25 with bash.
#define CATCH_CONFIG_MAIN
#include <catch.hpp>

TEST_CASE("256 failures")
{
	for (int i = 0; i < 256; i++) {
		CHECK(false);
	}
}

$ ./before; echo "exit_code: $?"
...
test cases:   1 |   1 failed
assertions: 256 | 256 failed

exit_code: 0

$ ./after; echo "exit_code: $?"
...
test cases:   1 |   1 failed
assertions: 256 | 256 failed

exit_code: 255

Ok, this is interesting and why we can't have nice things.
I am going to make some more documentation changes before accepting though, the clamp on return codes from applyCommandLine is not needed -- it returns either 0 or INT_MAX.

POSIX is one huge trap. :) Thank you, Martin!


Force Update

On a project I'm working on I need the ability to force update the layout on a click event. Is there a method on this.masonry that allows this? I have cards that expand and collapse on click.

Did you fix this?

@JonesDM No, I did not. I ended up using CSS columns instead. Have you found a solution?

this.masonry is a reference to a Masonry instance.
does this.masonry.layout() or this.masonry.reloadItems() work for you?
https://masonry.desandro.com/methods.html#layout-masonry
https://masonry.desandro.com/methods.html#reloaditems

@afram No, neither of these methods worked for me. For my use case I had a card that grew when you clicked read more. After it was done growing I needed to reload the masonry instance due to the fact that card had nestled itself behind the rest of the masonry items.

@afram the this.masonry instance doesn't have those methods at all. I'm facing the same issue as well.

@tallpants that's really strange. this.masonry should be a reference to a Masonry instance. Are you able to reproduce with an example on webpackbin please?

@afram my bad, I was trying to call it before the ref was assigned. this.masonry.layout() works, although it would probably be a good idea to put that in the docs. I don't mind making a PR with an updated README if that's okay with you.

sure that would be great @tallpants :-)

If I dynamically change the size of an item will calling this.masonry.layout() cause the items to reorder accordingly to fit? Because when calling it, the items still stay the same and arent being reordered.

If I dynamically change the size of an item will calling this.masonry.layout() cause the items to reorder accordingly to fit? Because when calling it, the items still stay the same and arent being reordered.

On a project I'm working on I need the ability to force update the layout on a click event. Is there a method on this.masonry that allows this? I have cards that expand and collapse on click.

Realise this is a long time after you were working on this, but found this functionality is already built in.
Looking through the Index.js file of the module there is a prop you can add to the masonry component "enableResizableChildren".
Your Masonry component would looks something like:
<Masonry                     enableResizableChildren={true} otherProps=""                 > // Your masonry content                 </Masonry>

Could someone provide an example of calling reloadItems from within a function component?


PROD : "No data available for current Filter selection" even though data are avalaible

When I try to display a dimension containing many nominal values as color, I get the message "No data available for current Filter selection " even though data exists for the selection chosen. I have to select the filters one by one to display a chart.
To Reproduce

Go to 'https://www.visualize.admin.ch/de/v/uwrjknXAunVd"
Copy and edit this visualisation
Edit "Colors" axis
Select "Sites"
See the message "No data available for current Filter selection "
Edit the filter (Colors-Axis) and unselect all (Select none)
Select one Site, for exemple "Chamoson", and apply Filters.
The chart is displayed.

Expected behavior
All sites should be displayed after step 4.

Environment (please complete the following information):

Visualize environment and version: PROD v3.20.2
Browser : Edge

Additional context
Add any other context about the problem here.

Hi @ortnever, thanks for reporting the bug. I checked and it seems that the behavior is correct on TEST (https://test.visualize.admin.ch/en/create/new?cube=https://environment.ld.admin.ch/foen/ubd0066/12). I am not sure at which point the issue was fixed, but it should be fine once we deploy to PROD.
Let me know if the TEST version works according to expectations 👀 If so, I'll close the issue.

Hi @bprusinowski , Yes it's fine on TEST. Thank you for your input. I didn't remember that we already fixed this issue.

Sure, no problem! I'm glad it works as expected on TEST 👌


Add the limitation to the Embedded Solution

[Enter feedback here]
It looks like we cannot embed the Power BI Paginated Visual Report into the Embedded solution using PBI Embedded Gen2 A SKUs. Could you confirm it and make it clear on this documentation on this limitation?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: cfaaf125-cd9e-4b88-c808-3bd53525d367
Version Independent ID: df09f8c6-0e60-14dc-6095-c2be885019c7
Content: Create and use the paginated report visual - Power BI
Content Source: powerbi-docs/visuals/paginated-report-visual.md
Service: powerbi
Sub-service: pbi-visuals
GitHub Login: @maggiesMSFT
Microsoft Alias: maggies

Hi, @anniexudan -- thanks for asking! I'll check and get back to you.

Hi, @anniexudan -- quick turnaround! The reply I got:
"It should work in the same scenarios as a stand-alone paginated report would work"
And the hypothesis:
"They are probably trying to use it with a Power BI dataset, which isn’t yet supported in this scenario."
If that's not your scenario, you may need to create a support request, https://powerbi.microsoft.com/en-us/support/
Hope that helps!


Not enough information  and some disinformation

Hi all. First of all, thanks for this small but much-needed library!
During my investigation, I found several inaccuracies and some missing information.

I use "react-to-webcomponent": "^2.0.0-alpha.0" (probably I should not but...) it would be nice to know some release notes like what major was changed compared to version "1.7.2"  (looks as if it does not corespond reality in the section "Releases" ). curently  I see it is  *.ts insted of *.js
The "Complete Example" is not complete:
in nutshell, it doesn't work because the "interface GreetingProps" doesn't conform "...ReactComponent: { propTypes?: object },..."

it doesn't work because the "interface GreetingProps" doesn't conform "...ReactComponent: { propTypes?: object },..."
I was wrong . it has other compile issues...

Thank you for pointing this out, I've drafted releases for the last stable release (including a summary since our previous release draft) and the 2.0.0-alpha release. We'll aim to be more consistent with drafting the releases
https://github.com/bitovi/react-to-webcomponent/releases/tag/v1.7.2
https://github.com/bitovi/react-to-webcomponent/releases/tag/v2.0.0-alpha.0
The compile issues hopefully will be resolved with the // @ts-ignore example in the 2 alpha release notes - typings are not complete yet.
Please let us know if this resolves the issues, and thanks again!


feature request: add point from search box result

I really miss something that has very long requested on Odyssey, use the search box and add a point to the search result (of course doing this manually isn't as precise)

duplicated!

closing, then!


Several small additions/fixes

This PR consists of five different fixes / additions.
https://github.com/Steveice10/MCProtocolLib/commit/954b799f885b43121b7be52e3feb1c3bbdc511ad
Adds several missing magic value entries and corresponding enum values and fixes a few incorrect magic values.
https://github.com/Steveice10/MCProtocolLib/commit/584b296f0bfb047cf43098fac7b76f81ec23c6f4
Adds a getter for the score type to the ´ServerScoreboardObjectivePacket´ as it is not yet accessible.
https://github.com/Steveice10/MCProtocolLib/commit/b7f071fb91b184abcc22d767c9b2e59a7dc1b1cb
Changes the first constructor of ´ServerUpdateScorePacket´ to include the objective as it's mandatory for that packet.
https://github.com/Steveice10/MCProtocolLib/commit/c912787d39763adf3c6b801be609bc0c937f3b57
Minecraft sometimes (see here) generates the UUID of an AttributeModifier instead of using one of the predefined magic values. Reading and writing back out such a packet fails as the magic value isn't found.
This commit allows for creation of AttributeModifiers by UUID instead of only magic value and then tries to load the magic value failing silent if it doesn't exist. Sending a packet then uses the UUID instead of the magic value allowing for unknown UUIDs to be read and written without any unexpected behavior.
https://github.com/Steveice10/MCProtocolLib/commit/48c03a93241e6a899886c4c7d121cf2b0e5f3703
Adds equals(Object) and hashCode() methods to every class for which there is a reasonable chance of it ending up in Map (basically every class which acts as a container for data). This does not include packets, simply because I cannot see them being used by anyone in a way that you'd need to have those methods implemented.
There is also the option to drop this commit and use lombok to auto-generate these methods during compile time. However something should be done as currently new Position(0, 0, 0).equals(new Position(0, 0, 0)) returns false which it clearly shouldn't.
Feel free to cherry-pick whichever commit you want, I just didn't like to create five different PR as I dislike all those merge commits generated by github.

Wow, lots of fixes, thanks a ton!
The missing or broken magic values are for the most part from the update process. I usually go by wiki.vg's protocol history page, which usually doesn't list things like added sounds or entities. Other times I might copy/paste a previous entry and forget to change the value of it.


Use pdbgit/gitlink to get source stepping without the need for symbol servers

Visual Studio supports stepping through source pulled from github if you inject the right data into your pdbs. The pdbgit/gitlink project makes this extremely straightforward.
https://github.com/AArnott/PdbGit
We should do the work to enable this experience for functions and webjobs (we might need another version of this issue in the webjobs sdk repo too).

cc @fabiocav

@fabiocav Something like this is now working for v2 right? Can we close this?

This was done for the WebJobs SDK. It's a quick thing, so I'll get this setup here as well.

Resolved by #2149


Single Tab Icon and Text color dynamically

Hi,
first of all, thank you for your great work!
I'm wondering if there is the possibility to color the single tab by code, for example a red color if the corresponding tab-page has a problem, or green color if the data in the relative page are all ok.
Another interesting features would be to block the swipe or access with click for some pages, in order to make a guided entry data by tabs, where the next tab is accessible only if all data are correct in the current.
Regards,
Leonardo Benini

No it's not possible to set the color for a single tab. However, you can achieve that by using custom CSS selectors.

Interesting feature, I'm open to adding it. Most likely I'll make the super-tabs element respect the ionViewCanEnter and ionViewCanLeave methods of child tabs.


Show callstack backstraces for 'Internal Server Error 500

It would save time for debugging.

But maybe only when debug mode?

LGTM but like @lunny I would prefer (not mandatory if other people don't want it) in debug mode only since I don't expect to have stacktrace in normal (info) log.
Have you try to display information return by debug.PrintStack() and if it respect how the rest of the logs are output normally? It would be the biggest point to specifing to debug and not disturb production where anyone would want to catch 500 but analyzing it in testing.

@sapk Yes, I have tried it for debugging the 500 error on my local machine. It doesn't mess up other  other logs (I mean like how kernel log interfere with application log. Broken formatting ..etc.).

Or maybe a config item could disable it.

@lunny The PR's primary purpose is for those scenarios where the bug report is not informative enough when reported from the end-users. For developers who intend to look into the problem by themselves, adding that line doesn't add much effort. So I don't expect it to be as useful as being enabled in production mode.
That said, I can try to add a switch for it if it doesn't introduce too many changes.

I mean keep it open default and end-user could disable it. This is not against your idea.

I think the usefulness of the PR doesn't warrant the extra complexity after just having handled a real 500 error just a moment ago 😆 . So I will back off the PR for now. If I am proved wrong again, it's not too hard to try this again.


When inserting non-image files the spinner stays on page forever

Preflight Checklist

[x] I agree to follow the Code of Conduct that this project adheres to.
[x] I have searched the issue tracker for a feature request that matches the one I want to file, without success.

You must agree to search and the code of conduct. You must fill in this entire template. If you delete part/all or miss parts out your issue will be closed.
If you are technical, you should reporting bugs along the lines of https://marker.io/blog/how-to-write-bug-report. If you are not technical, we will make allowances, please try to make an effort to understand the process.
Describe the bug
A clear and concise description of what the bug is.
When inserting non-image files the spinner stays on page forever
To Reproduce
Steps to reproduce the behavior:

Go to https://app.diagrams.net/
Create a diagram
Click on `Arrange - Insert - Image...' menu item
Click on Open button
Select any non-image file
Verify that the spinner stays on page

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.

draw.io version (In the Help->About menu of the draw.io editor):

draw.io version 23.1.0

Desktop (please complete the following information):

OS: any
Browser any
Browser Version any

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

I tested the problem in incognito/private mode with all browser extensions switched off, write "yes" below:

yes

Additional context
Add any other context about the problem here.

Fix in 23.1.2


Handling function types? 🤔

Is it possible to get this to work with function types as well (in a relatively "clean" way)? I'm picturing a case where a user passes in a slice of functions, as well as slices containing potential args for those functions.
They could then iterate over the product elements, "unpacking" the returned []any slice into fn, arg1,arg2,...,argN, then applying these args to the function like fn(arg1, arg2,...,argN).

One (slightly indirect) way of doing this is to have the caller use the Indices() API, then use the indices returned to index into each of the slices. I'd just like them to be able to do this with Values() directly 🫤


[RC0,1]Inheriting page breaks app, @ViewChild property is undefined

Short description of the problem:
My App contains a tab controller with multiple tabs. 2 of the tabs are highly similar since I wrote a generic component which can cover both pretty well with just a small configuration change.
So I have all the logic in the first Page (TSPage) class and template and made the second page (MyTSPage) extend the first, adjusting some properties in the constructor, like shown below.
TSPage works well, but clicking the tab of the second page breaks the app with an error.
TypeError: Cannot set property 'enabled' of undefined.
I think it happens here, which is part of TSPage (stacktrace seems useless and points to a location without any "enabled"):
this.refresher.enabled = false;
With refresher being (at TSPage):
@ViewChild(Refresher)
public refresher: Refresher;

What behavior are you expecting?
I would expect the page works well when I inherit a second page from the first, but somehow the @ViewChild seems to not resolve properly.
@Component({
    templateUrl: 'ts.html',
    selector: 'my-ts-page'
})
export class MyTSPage extends TSPage {

    constructor(protected navCtrl: NavController,
                public app: App,
                public modalCtrl: ModalController,
                public tsProvider: TSMockProvider) {
        super(navCtrl, app, modalCtrl, tsProvider);
        this.mode = 'own';
        this.segment = 'upcoming';
    }
}

Other information: (e.g. stacktraces, related issues, suggestions how to fix, stackoverflow links, forum links, etc)
Which Ionic Version?
Ionic 2 rc0 and rc1
Run ionic info from terminal/cmd prompt: (paste output below)
Your system information:
You have been opted out of telemetry. To change this, run: cordova telemetry on.
6.3.1
Gulp version:  CLI version 3.9.1
Gulp local:
Ionic Framework Version: 2.0.0-rc.1
Ionic CLI Version: 2.1.1
Ionic App Lib Version: 2.1.1
Ionic App Scripts Version: 0.0.36
OS:
Node Version: v4.4.5

I found a workaround:
Copying over all ViewChild properties also to MyTSPage fixes it. However, I don't think this duplication should be needed?!?
@Component({
    templateUrl: 'ts.html',
    selector: 'my-ts-page'
})
export class MyTSPage extends TSPage {

    @ViewChild(Content)
    public content: Content;
    @ViewChild(InfiniteScroll)
    public infiniteScroll: InfiniteScroll;
    @ViewChild(Refresher)
    public refresher: Refresher;

    constructor(protected navCtrl: NavController,
                public app: App,
                public modalCtrl: ModalController,
                public tsProvider: TSMockProvider) {
        super(navCtrl, app, modalCtrl, tsProvider);
        this.mode = 'own';
        this.segment = 'upcoming';
    }
}

Hello, thanks for opening an issue with us! Would you mind posting a repo or gist that we can use to reproduce this issue?

This is a known angular 2 issue: https://github.com/angular/angular/issues/5415

Thanks, you are right.


lowers logging level for first seen dead compaction

For the case of really quick compactions there is a good chance these finish during the check done by the dead compaction detector.  Currently when this happens a log message is logged about a possible dead compaction that is a false positive.  A large number of quick external compactions can cause a lot of these false positives.
This change adjust the first time a possible dead compaction is logged to trace.

I have not had a chance to test this change yet.  I made the change by reading the Map.merge() javadoc, would be good to get a double check of the use of Map.merge return value.


Option to run in "de-novo" mode

Most of the scripts at https://github.com/sokrypton/ColabFold have a ton of additional flexibility that comes in handy when running AF on de-novo sequences (for which you usually can't generated an MSA) or to do protein-design with.
Can this codebase also be leveraged to:

run predictions without MSA input or template structures, so just the raw sequence input
increase the number of recycle iterations (since this has been shown to recover some of the accuracy lost by not having an MSA)

Yes to both.

Simply run the inference script using the --use_precomputed_alignments flag. Inference will be performed even if the alignments directory is empty.
The number of recycling iterations can be tuned in the model config, located at openfold/config.py under the "data" header.

Done! As of 61df432, you don't need any MSAs (or templates, for that matter) in the alignment_dir of either the inference or training scripts.


Feature: A new modal window for changing languages [fixes #96]

Feature: A new modal window for changing languages [fixes #96]

Good job man
It's perfect 🥰


getting error while loading the model

Hi,
It seems that the library is unable to download the trained NER model from S3 and it's giving an error. Is there a way to fix this issue? Thank you
For reference, I share the error below:
2023-12-10 13:50:13,350 - SkillsExtractor - INFO - Loading the model from a local location (ner_spacy.py:507)
2023-12-10 13:50:13,351 - SkillsExtractor - INFO - Loading the model from /usr/local/lib/python3.10/dist-packages/ojd_daps_skills_data/outputs/models/ner_model/20220825/ (ner_spacy.py:510)
2023-12-10 13:50:13,362 - SkillsExtractor - INFO - Model not found locally - you may need to download it from S3 (set s3_download to True) (ner_spacy.py:516)
---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
<ipython-input-2-07431820480b> in <cell line: 1>()
----> 1 es.load()

1 frames
/usr/local/lib/python3.10/dist-packages/ojd_daps_skills/pipeline/skill_ner/ner_spacy.py in load_model(self, model_folder, s3_download)
    517                 "Model not found locally - you may need to download it from S3 (set s3_download to True)"
    518             )
--> 519         return self.nlp
    520
    521

AttributeError: 'JobNER' object has no attribute 'nlp'

Hi @luqmanjamilch - thanks for using our library!
Are you using the library with pip install ojd_daps_skills? If so, we have just pushed some changes to dev which potentially should fix this issue (or at least give you better warnings), but these havent been included in the latest release yet - so you could try pip install git+https://github.com/nestauk/ojd_daps_skills.git@dev instead.
Let us know how you get on.

also - @luqmanjamilch do you have the AWS cli downloaded?

Hi @lizgzil, Thank you for your help. I used the pip install git+https://github.com/nestauk/ojd_daps_skills.git@dev to install the package and it's working fine. Besides, I am using it on Google Colaboratory and I did not download or set-up AWS cli.

@luqmanjamilch that's great! thanks for letting us know. We will hopefully release the new version soon!

Hey @lizgzil, when are you planning to release the new version?


The project has some magic numbers.

Magic numbers should all be made into more readable constants. For example, the time interval for checking if an event is too soon.

I think the only remaining magic number is the number of blocks to wait() for donation confirmation, but it's only used once.


Algoa Bay Forecast model: Fix path references in the 'make-forcings' step (MatLab CROCOTOOLS execution)

Looking at the output of the Github actions workflow here: https://github.com/SAEON/somisana/runs/6964888710?check_suite_focus=true#step:3:40, it seems likely to me that the rst_filename  will never exist at the path that it is currently expected.
Please can you confirm this @mattcarr03. Should this be looking in the tmp directory?

So during the model run the rst_filename is created in the scratch directory which is the "work directory". It is then moved into the forcing directory during the achieving step, line 66
     mv -f ${SCRATCHDIR}/rst.nc${ENDF} ${FORECASTDIR}/rst_${TIME}.nc${ENDF}
in the script https://github.com/SAEON/somisana/blob/next/models/algoa-bay-forecast/toolkit/run-model/archive_croco.bash.
This was the old setup so it is possible for rst_filename to be moved where fits in best with the new workflow, possibly a folder that is not overwritten as rst_filename needs to be passed from one day to the next. The the path to look for rst_filename needs to be changed accordingly.

In the old setup the same directory was reused. So for our current setup, I think it's better that the current run look for a restart file in yesterdays directory, and move it to todays forcing directory. To this:

There is now a step that moves the rst file generated yesterday to the current working directory: https://github.com/SAEON/somisana/blob/next/.github/workflows/run_algoa-bay-forecast.yml#L263
The MatLab script needs to be updated to look in the tmp directory for the restart file. That's this line of code: https://github.com/SAEON/somisana/blob/next/models/algoa-bay-forecast/toolkit/make-forcings/run.m#L26


Cancel button on HealthpointModal is misleading

Describe the bug
Please see the screenshot. The "Cancel" button (outlined) is misleading, especially when it is translated into other languages e.g. Chinese.
Clicking on this "Cancel" button, we will be redirected to the walk-in locations page. So here "Cancel" means "Go back" which kind of makes sense in English.
However, the i18n key is defined as walkins.cancelBooking. So, translations including Chinese put the equivalent of "Cancel Booking" on this button ("取消预约"). This is not what this button actaully does.
To make it more confusing, notice that on the left hand side, there is a message telling people "Remember to cancel your original booking if you....." So, in this context, people will likely to think that if you click on that button, you will be redirected to a page where you can cancel your previous booking for this location.
To Reproduce

Go to the "walk-in" tab
Choose any one of the locations.
Observe the "Cancel" button.

Screenshots

Device:
Additional context
To reduce potential confusion, I think at least the translations should be updated, from the equivalent of "Cancel Booking" to just "Cancel" or simply "Back". But to keep things consistent, perhaps it is better that we also change the i18n key for this to walkins.cancel or walkins.back so that it does not confuse translaters.

This has been addressed!


Automatically batch messages into a single RPC

Applications may want to setup batching for their message publications, we need to implement:

[x] A mechanism to control the maximum delay for the messages in the batch
[x] A mechanism to control the maximum number of messages (or bytes?) in the batch
[x] A mechanism to force a flush.
[x] Separate batches per ordering key.

There are leftover TODOs here:
https://github.com/googleapis/google-cloud-cpp/blob/4307ca4086f42012e8ee208891162ccecb1694a3/google/cloud/pubsub/publisher.cc#L22


wont compile on Windows

https://paste.debian.net/1272507/
problem with termion 2.0.1
--> .cargo\registry\src\github.com-1ecc6299db9ec823\termion-2.0.1\src\lib.rs:26:9
  |
26 | pub use sys::size::terminal_size;
  |         ^^^ maybe a missing crate `sys`?
  |
  = help: consider adding `extern crate sys` to use the `sys` crate

Looks like the crate I use to manipulate the terminal doesn't support windows. I'll look for another one or I'll have to implement my own.
In the meantime, if you want to run it on windows, it should work with WSL.

Fixed

what windows rust installation you have? gcc/mingw/msys2 ?
I have gcc for windows and some library is missing
ld: cannot find -lntdll

I used the installer straight from their website, works with no issue.
https://www.rust-lang.org/tools/install
This is a rust mingw issue that seems to have been fixed according multiple issues and stack overflow:
https://github.com/rust-lang/cargo/issues/7812
https://github.com/rust-lang/rust/issues/68518
Stack overflow recommends running:
rustup update

https://stackoverflow.com/questions/72381444/rust-cannot-link-with-x86-64-w64-mingw32-gcc


Update redis library

Update the redis library to redigo 1.7.0.
Handles the move of the repository as well.
Depends on #3113

@dmcgowan can you please close this PR in favor of https://github.com/docker/distribution/pull/3239?

Closing in favour of #3239 which updated redigo to later version.


{Resources/resources] Fixed TagCount value property

Generated from RestAPI PR: https://github.com/Azure/azure-rest-api-specs/pull/846

Current coverage is 59.07% (diff: 100%)

No coverage report found for master at 3157b70.

Powered by Codecov. Last update 3157b70...809e95c

Technically a breaking chance, since we get 1 instead of "1".

Included in https://github.com/Azure/azure-sdk-for-python/pull/960


[Jira] Fix epic autocomplete to include all epics of a selected project.

Description
This PR addresses the issue #12646
Current behaviour:
The Jira extension allows the user to create a Jira issue and link it to a parent epic under a specific Jira project. However, not all epics are available under the epic dropdown menu. A user might not be able to find the suitable epic they want to link the issue to.
Root cause:
The Epic autocomplete uses the api /rest/api/3/issue/picker. The API specs, according to the docs, are defined as:
Returns lists of issues matching a query string. Use this resource to provide auto-completion suggestions when the user is looking for an issue using a word or string.

This operation returns two lists:

History Search which includes issues from the user's history of created, edited, or viewed issues that contain the string in the query parameter.
Current Search which includes issues that match the JQL expression in currentJQL and contain the string in the query parameter.

The extension seems to search for Epics within the "History Search" not the "Current Search", so it's only returning Epics that the user interacted with. If a user wants to link an issue to a new epic that a colleague created or one that they haven't interacted with before, they might not find it.
Expected behaviour after the fix:
The fix prioritizes using Current Search over History Search, such that all the relevant epics are retrieved when the user searches for them.
Screencast
Current behaviour (before the fix)
https://github.com/user-attachments/assets/a9e8795c-4d08-4e7a-8e71-2dff6d1c291c
New behaviour (after the fix)
https://github.com/user-attachments/assets/99310287-c17a-4fc1-994f-0a386a5ec880
You'll notice that a new epic (KAN-1) shows up that wasn't retrieved before
Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed outside of the metadata folder

[!IMPORTANT]
/rest/api/3/issue/picker API is not paginated like /rest/api/3/search API - which might lead to heap memory issues crashes for large JIRA customers while creating new issues. We should try to move to a paginated typeahead API if we can in followup PRs. cc: @thomaslombart


Automatically install current collection

If run inside a collection repository dependency step will first
build and install the current collection. This avoids failure to
run test scenarios unless user already installed the collection.
Fixes: #2997

This will address an issue I am currently encountering where trying to get Molecule to pick up an existing collection is difficult but also causes any other collections on my development machine to be overwritten by the ansibile-galaxy command.

I think there first needs to be some consensus (and documentation) on where the molecule folder should end up in a collection repository.

Closing in favour of https://github.com/ansible-community/molecule/pull/3077 which is reusing ansible-lint prerun code.


Get rid of size limit for in() values

At the moment the size is limited to MILL_MAXCHVALSIZE bytes.
Dynamically grow the in buffer to accommodate larger types.

FIxed.


Question: copy login command

See: https://github.com/bcgov/bcbb-gitops-docs/blob/main/docs/01-bcgov-platform.md
“Once you are logged into the OpenShift console you can select "Copy login command" under your profile name.”
Q: What is the significance of the last line? …what is the copied command needed for?

Hey @NicoledeGreef so these docs were some rough notes I had as I was doing the initial prototype.
This is needed when you want to execute either kubectl or the oc cli in order to interact with the cluster.
I can update the notes and add a little context around this and other things.

Resolved this in my updates notes :D


Update vsts agent for build YAML feature

When will the updated vsts agents be available? The current version doesn't support the "YAML - Configure your build as code" feature and if one developer triggers a YAML build all dockerized agents are updated and restarted.
I'm using a hosted VSTS on visualstudio.com and it tries to update the agent to 2.129.1 (dockerized version is 2.122.1). This update fails because it restarts the container and it comes up again with the agent version from the image.

There is a related issue open in https://github.com/Microsoft/vsts-agent-docker/issues/63 in which some workarounds are discussed that might be useful to you
You may need to pull the latest image- this issue has been at least partially mitigated by an update to the images (see issue linked above)
Let me know if that is not enough information to work through your problem

I wasn't aware that the non-tfs-images are fetching the image on start which fixes our problem.
Thanks and closed :)


[HOPS-136] log lost containers.

https://hopshadoop.atlassian.net/browse/HOPS-136

Jenkins test this please.

Jenkins test this please.

Jenkins test this please

test this please

Jenkins test this please

Jenkins test this please

test this please

Jenkins test this please

Jenkins test this please

Jenkins test this please

test this please


Turn on GitHub Pages

Ok, I'm working on it
On Wed, 27 Dec 2023 at 17:25, amuli4 @.***> wrote:

Assigned #9 https://github.com/amuli4/abi-projects-playground/issues/9
to @abimulia https://github.com/abimulia.
—
Reply to this email directly, view it on GitHub
https://github.com/amuli4/abi-projects-playground/issues/9#event-11343996916,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AVRPOS6MSB7ZJQIT727T66DYLPZTHAVCNFSM6AAAAABBEGIRJKVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRGM2DGOJZGY4TCNQ
.
You are receiving this because you were assigned.Message ID:
@.***
com>

--
Regards,
Abi


atom cli crashes

I am getting the following error when trying to use the atom command line tool:
$ atom --safe .
/usr/local/bin/atom: line 115:  8318 Trace/BPT trap: 5       open -a "$ATOM_PATH/$ATOM_APP_NAME" -n --args --executed-from="$(pwd)" --pid=$$ --path-environment="$PATH" "$@"

I installed atom via brew cask install atom yesterday, 1.7.3, and it immediately updated. I can use the atom app, it only occurs when trying to start from the command line.
Versions:
$ atom --version
Atom    : 1.7.4
Electron: 0.36.8
Chrome  : 47.0.2526.110
Node    : 5.1.1
$ apm --version
apm  1.9.2
npm  2.13.3
node 0.10.40
python 2.7.10
git 2.8.2

Running on Mac OSX 10.11.5.
To clarify: I am not sure wheither this is an issue of atom or one of hombrew cask. I have opened issues in either github repository.

I uninstalled atom completely with brew cask zap atom and reinstalled a fresh version 1.7.4, the problem persists. If there is any additional information I can provide, I'll happily do that.

Can you try an official build from atom.io and let us know if that works on your system so we can determine if it's a configuration issue or a brew package issue? Thanks

No response. Closing.


Add flag to skip fetching code in the reproducer

Add a flag to skip fetching code from the zuul var, and instead simply
push whatever is in ~/src in the ansible controller. This allows to rely
on zuul cloning required projects and depends-on and not repeat the same
process.
As a pull request owner and reviewers, I checked that:

[x] Appropriate testing is done and actually running

@pab

@pablintino thanks for the comments, I've made the changes but I'll wait until the current run finishes to upload them to not stop the job run

/approve
/lgtm
This one will have a followup to reuse the previous existing rsync.


Make Kafka K8s GSG CI tests work on multinode setup

This change makes the Kafka K8s GSG CI tests in Ginkgo work on a multinode setup.
The setup looks like this:
Kafka multinode setup:
Ginkgo K8s1:
1. empire-backup
2. empire-hq
3. kafka-broker : ingress policy only
Gingko K8s2:
1. zook
2. empire-outpost-8888
3. empire-outpost-9999
Fixes Issue: #2911
Signed-off-by: Manali Bhutiyani<EMAIL_ADDRESS>Make Kafka K8s GSG CI tests work on multinode setup

test-me-please

test-all-ginkgo

test-me-please

test-me-please

test-me-please

test-me-please


feat: Add basic-tracer package

This is split from https://github.com/open-telemetry/opentelemetry-js/pull/99 to unblock https://github.com/open-telemetry/opentelemetry-js/pull/102 merge.
Also, updated the README file with description, links and license info.

Codecov Report

Merging #131 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #131   +/-   ##
=======================================
  Coverage   98.87%   98.87%
=======================================
  Files          27       27
  Lines        1784     1784
  Branches      201      201
=======================================
  Hits         1764     1764
  Misses         20       20


Performance Issues with Routinator Containers

I am using a 40 AS Mini-Internet here, four regions with 10 ASes each, 2 tier-1, 2 stub (fully configured) and 6 tier-2 ASes (managed by the students). So a "classic" setup I would suppose. Find all config files attached:
40_as_config.zip
Currently the whole intra-domain stuff is done, eBGP session are configured and running, business relationships and IXPs are setup too. The connection matrix shows full connectivity, some paths are still invalid due to route leaks based on mishandled business relationships. RPKI stuff is not done at the moment.
Now I ran into some serious troubles. I observe heavy and rising load on the virtual machine (VM) running the Mini-Internet. The VM has  16 CPU cores, all are up between 95 and 100 % load, load average is between 55 and 70. Memory consumption is at around 44 GB of 64 GB in total. Here's the current output of htop on this VM:

Some deeper analysis shows that a big part of this heavy load seems to originate from the routinator processes in the 40 ASes (look at the TIME column in the ps output):

The ones with the most CPU time are the ones in the fully configured tier-1 and stub ASes. Looking at one of the affected containers (group 12, tier-1, routinator running on the host at router GRZ) shows the following for ps:

Using strace on one of the routinator process on the VM shows that, if I am right, the routinator process is spawning a lot of new processes "doing things". I attach a file with strace output here:
g18_grz_host_routinator_trace.txt
Any ideas what is going wrong here?
Thanks for your help in advance!
Markus

Hey, thanks for investigating this.
Do you know if this traffic between Routinator and Krill always happens, or was that a one-off thing?

Hi Alex,
thx for getting back! It happened midth of May and I solved it by restarting all the routinator containers (as mentioned above). It then again happened around start of June but then disappeared again without doing anything. And it its happening again at the moment. How can I assist in diagnosing the root cause?
Best regards
Markus

I am sorry, but I am not able to shed some more light on this. It all started even before sync sessions with the routinator containers were configured by the students on their BGP routers. So the state of the routinator containers was that they were configured with an IP address and a gateway and therefore were able to communicate and sync with the krill host. With that in mind I would say it all happened during regular routinator operations.

Still, thank you for the report. We'll see if we can find anything.


Returning errors from DataLoaders

Product
Hot Chocolate
Is your feature request related to a problem?
There's a difference between not finding an entity by it's key and being unable to, due to unexpected circumstances.
To handle partial errors inside a DataLoader you currently have two options:

Throw an exception and invalidate all other keys that could be successfully resolved
Add Wrappers to your DataLoader return type and unwrap the result at the call-site (this can be pulled out into a helper method, but you still need to remember to use it at the call site)

Both of these options are not perfect from a DX perspective.
The solution you'd like
It would be great if there were some helpers for dealing with partial DataLoader results. I've seen there already is a Result helper with Reject and Resolve methods in Green Donut, but it doesn't seem to be used anywhere.
Ideally the dataloader.LoadAsync(id) could detect whether the returned item is an error or not and re-throw the exception.

This is supported since day 1 :)

The base DataLoader fetch looks like the following:
    protected override ValueTask FetchAsync(
        IReadOnlyList<TKey> keys,
        Memory<Result<TValue>> results,
        CancellationToken cancellationToken)

Result:
/// <summary>
/// A wrapper for a single value which could contain a valid value or any
/// error.
/// </summary>
/// <typeparam name="TValue">A value type.</typeparam>
public readonly record struct Result<TValue>
{
    /// <summary>
    /// Creates a new value result.
    /// </summary>
    /// <param name="value">The value.</param>
    public Result(TValue value) : this()
    {
        Error = default;
        Value = value;
        Kind = ResultKind.Value;
    }

    /// <summary>
    /// Creates a new error result.
    /// </summary>
    /// <param name="error">
    /// The error.
    /// </param>
    public Result(Exception error)
    {
        Error = error ?? throw new ArgumentNullException(nameof(error));
        Value = default!;
        Kind = ResultKind.Error;
    }

    /// <summary>
    /// Gets a value indicating whether the result is an error, a value or undefined.
    /// </summary>
    public ResultKind Kind { get; }

    /// <summary>
    /// Gets the value. If <see cref="Kind"/> is <see cref="ResultKind.Error"/>, returns
    /// <c>null</c> or <c>default</c> depending on its type.
    /// </summary>
    public TValue Value { get; }

    /// <summary>
    /// Gets an error If <see cref="Kind"/> is <see cref="ResultKind.Error"/>;
    /// otherwise <c>null</c>.
    /// </summary>
    public Exception? Error { get; }

    /// <summary>
    /// Creates a new error result.
    /// </summary>
    /// <param name="error">An arbitrary error.</param>
    /// <returns>An error result.</returns>
    public static Result<TValue> Reject(Exception error) => new(error);

    /// <summary>
    /// Creates a new value result.
    /// </summary>
    /// <param name="value">An arbitrary value.</param>
    /// <returns>A value result.</returns>
    public static Result<TValue> Resolve(TValue value) => new(value);

    /// <summary>
    /// Creates a new error result or a null result.
    /// </summary>
    /// <param name="error">An arbitrary error.</param>
    public static implicit operator Result<TValue>(Exception? error)
        => error is null ? new Result<TValue>(default(TValue)!) : new Result<TValue>(error);

    /// <summary>
    /// Creates a new value result.
    /// </summary>
    /// <param name="value">An arbitrary value.</param>
    public static implicit operator Result<TValue>(TValue value)
        => new(value);

    /// <summary>
    /// Extracts the error from a result.
    /// </summary>
    /// <param name="result">An arbitrary result.</param>
    public static implicit operator Exception?(Result<TValue> result)
        => result.Error;

    /// <summary>
    /// Extracts the value from a result.
    /// </summary>
    /// <param name="result">An arbitrary result.</param>
    public static implicit operator TValue(Result<TValue> result)
        => result.Value;
}

However, we removed result from the higher level abstractions because most use-cases do not need it ... but you can use it when directly inheriting from DataLoader<TK, TV>.


Context not initialized on root path when using setGlobalPrefix

https://github.com/nrwl/nx/issues/19842

Edit by @Papooch: Copied and edited form linked issue:
Current Behavior

I have a project based on nx-v16.x that has been developed for a long time;
Previously, Nestjs-cls was introduced and everything was functioning normally;
When I added the Nest app to the project, the same reusable code, Nestjs-cls, became invalid. Even copying the previous project from the apps was invalid. As of now, the dependency removal and reinstallation, which used to work well, are no longer effective;
In order to ensure that it is my project issue, Nestjs-cls issue, or nx issue, I created two warehouses respectively. One is a pure project generated based on NesCli, and the other is a project based on the current nx-v17-- preset=nest. They only introduced Nestjs-cls, and ultimately found that NestCli's is OK, while nx's is still invalid;

Expected Behavior
I hope Nestjs-cls can be used normally in Nest of nx
Steps to Reproduce

https://github.com/sailengsi/nest-cls_ok ● Project based on nest-cli
https://github.com/sailengsi/nx-nest-cls_bug ● Next project based on nx;

Both of the above two projects were exclusively, and only nestjs-cls were introduced in app.module.ts, and getId using ClsService in app.controller.ts was deleted by Console, since the input of nx projects was always undefined.
Nx Report
No abnormal output

Package Manager Version
pnpm 8.5.1
Operating System

[X] macOS
[ ] Linux
[ ] Windows
[ ] Other (Please specify)

What's quite awkward is that the project has already been launched, and the local hassle I've been dealing with is completely ineffective

Hi, it seems strange to me that NX would break the library. I have been working on a project managed by NX before and we used nestjs-cls without a problem.
I will look at your reproduction in the morning.

Ah ah, oh Maiga
When I woke up in the morning and opened GitHub to see your analysis, I suddenly realized.. After testing, it is indeed the case.
Looking back at the process of discovering this problem again, I feel a bit embarrassed:

When accessing Nestjs-cls for the first time, it was not tested on GlobalPrefix, but directly on its own API, so there was nothing unusual and it was okay. Similarly, the second project remained the same;

In the past two days, I was working on a new project that was empty, so I tested it on GlobalPrefix. I was stunned at the time;

The most important moment came when I returned to my previous project. However, I didn't know how to test it on GlobalPrefix, and it was difficult to do so. At this time, I forgot to test my API and was a bit scared because the first version of this project based on nx had been online for more than ten days. I was thinking that the next press conference wouldn't cause such problems online..

OKOKOK, in fact, I usually don't directly do business logic for GlobalPrefix, just for testing. Unexpectedly, this test almost surprised me.
Thank you, thank you very much for your answer. I can finally let go of my heart that has been hanging in suspense for the past two days.


Create the groundwork for the /events page 📆

This page will include adding a preload function to the Svelte file's script with the module typing. This includes starting on #72 and #74.
Read #20 for more information on fetching Google Calendar data.

Resolved by pull request #91 🤠


Logging metrics across service / process / thread boundaries

Hi,
I currently try to log metrics in an existing system that comprises a lot of different services, processes and threads.  So far I have been using AppMetrics individually in each service / assembly, but now I am at the point where I have a metric which requires counting across the boundaries of services / assemblies.  That is, I need to operate on a metric from different, independently running services.  Only possibility I currently see is with an extra measurement service which provides access to the shared metrics.  Other options?    Any best practices how to do that?

Could you just use the same metric name?

Using the same metric name and context is what I try to achieve.  The issue is that the different services and assemblies start independently from each other.  Hence, I do not know how to obtain a common IMetricsRoot (or similar) across the different services and assemblies.


How can I use ASP.NET Identity in n-tier solution

I’m working on a solution which consists of layered mvc application using entity framework. I want to use AspNet Identity to manage user accounts and logins. Which has its own model and dbcontext classes embedded in it and all of these are inside  MVC project.
I want to be able to manage database interactions through data layer which is entity framework and DB context. And the ApplicationUser is referenced by other tables.
How can I use ASP.NET Identity in the n-tier solution?
Thanks a lot.

Like you would anything else, shove a facade in your service which wraps the methods you want to call.
The only fun part is creating the auth cookies, but that can be done in code once you have the facade return a ClaimsPrincipal;
    await HttpContext.Authentication.SignInAsync("Cookie", userPrincipal,
        new AuthenticationProperties
        {
            ExpiresUtc = DateTime.UtcNow.AddMinutes(20),
            IsPersistent = false,
            AllowRefresh = false
        });

Signout is much the same, except, well, you call SignOut, without needing to pass a principal.


[Extra MetaData Loader] No Menu Entry

Extension
Extra Meta Data Loader
Describe the bug
There is no entry in the menu for setting up this Addon.
To Reproduce
Steps to reproduce the behavior:
Install this Addon (and restart).
Expected behavior
There should be a menu entry anywhere.
Screenshots

Menu items are in the right click game menu

Okay, but where can i find these settings:


DTC's not working

I tried getting the DTC's from OBDII Simulator, but it throws an exception.
The exception occurs at Vehicle.cs:line 163 because the byte array is not long enough. (6 bytes, but it tries to copy 2x 3 bytes starting from index 1 as far as i can see right now.)
Havent read into that part of the protocol yet, so not be able to fix it at this time. Maybe someone can drop an suggestion on why this happens and i'm happy to create a pull request later on.

Which OBD simulator you are using?

The simulator included in this repository. (https://github.com/0x8DEADF00D/obd2NET/tree/master/tools/obdsimwindows)

Made a pull request with a solution that works for me. See Diagnostic Trouble Code Fix #3

The regex in ControllerResponse only takes the last piece of information from the response. This causes the overwritten data bug in above mentioned pull request.

Fixed the above issue of the 3 DTC limit. Not in the regex form, so might be something to improve.

Fixed it, refactored it into an acceptable solution and created a pull request. Everything should work now.


perf: add liveness and readiness probes to deployments

linked here in the codeflare operator

@anishasthana @KPostOffice can one of ye give me a lgtm here so I can merge please?

kind bump to review this PR :)

do we know what is pending for getting this PR merged?

@KPostOffice sorry to poke again, but can you approve this?

Can we please make sure we have manually tested this PR?


add SocketOptionError unknown error

During debugging (probably will open an issue about it soon) DtlsSocket I did hit the  _ => panic!("Unknown error code: {}", errno), in SocketOptionError.
I think it is better to return an Unknown error instead of crashing the whole application.

Hi, thanks for the PR!
I deliberately left it be a panic. The codes all need to be handled correctly or the socket can get into weird undefined states. The only thing the user could do is panic or close the socket and since I can't force users to close the socket (not ergonomically at least), panic is the only option I have.
And if the panic wasn't there, you might have just accepted it being there if it was easily recoverable and I wouldn't become aware of it and the crate would never handle it properly.
So the panic works, because you're here now 😉
So I'm inclined to keep the panic, because it genuinely should never panic and if it does I need to hear about it.

Hmmm I would be probably here too if the DtlsConnect returned an error :D. But I am fine with keeping it as I already found the issue and it clearly my error: https://github.com/diondokter/nrf-modem/issues/25

Hmmm I would be probably here too if the DtlsConnect returned an error :D. But I am fine with keeping it as I already found the issue and it clearly my error: #25

Ha good, but sadly not everyone is such a good Samaritan :P


Adding adventure to list of card layouts for image_uris

Currently Scrython breaks when trying to call the image uris of cards with the new Adventure frame. Took a quick look, and it seems to be an easy fix. Let me know if there's anything else I need to do here.

Thanks for the fix! I tried to update the target branch to develop but there's some funkiness going on with it. In the future, please make sure to branch off of develop and not master.

Gotcha, I should be able to fix that in a bit. Pretty new at this "contributing to open source" thing, and I wasn't sure if develop or master was correct, since master seemed to be ahead of develop.  I think a "Contribution Guidelines" section in the readme or something might be helpful for future contributors.

Just got some time to check out this change, and it works as intended. Not a lot of change but it's good that it works. Thank you for the contribution! I've got some docs for future contributions on the way.