Not able to get detekt custom rule to work.

Issue
Not able to get detekt custom rule to work. Followed all relevant issues (#6194 #3264 #3897  ) and documentation, still not able to figure out the cause.
Used template from detekt.

Expected Behavior

On running ./gradlew detekt it should catch a rule violation for one of the class.
Observed Behavior

Unit tests are working fine as defined here
But when applying the plugin to the root build.gradle file, it seems to not catching violation in this class for Dummy rule
Steps to Reproduce

Live example repository - https://github.com/alpeshvas/detekt-poc

./gradlew detekt on root, it doesn't fail. It should fail

Context

Trying to write a custom rules for our usecase.
Your Environment
Set up:
Custom rules are in the detekt-common-config module
plugins {
    kotlin("jvm") version "2.0.0"
}

apply(plugin = "kotlin")

repositories {
    mavenCentral()
}

dependencies {
    compileOnly("io.gitlab.arturbosch.detekt:detekt-api:1.23.7")
    testImplementation("io.gitlab.arturbosch.detekt:detekt-test:1.20.0")
    testImplementation("org.jetbrains.kotlin:kotlin-test:1.8.0")
    testImplementation(platform("org.junit:junit-bom:5.10.0"))
    testImplementation("org.junit.jupiter:junit-jupiter")
}
tasks.test {
    useJUnitPlatform()
}

Applied in root project with this setup:
Using detektPlugins(project(":detekt-common-config"))
import org.gradle.kotlin.dsl.test
import org.gradle.kotlin.dsl.testImplementation

plugins {
    id("java")
    kotlin("jvm") version "2.0.0"
    id("io.gitlab.arturbosch.detekt") version "1.23.7"
}

group = "com.detekt.poc"
version = "1.0-SNAPSHOT"

repositories {
    mavenCentral()
}

dependencies {
    detektPlugins(project(":detekt-common-config"))
    testImplementation(platform("org.junit:junit-bom:5.10.0"))
    testImplementation("org.junit.jupiter:junit-jupiter")
}

tasks.test {
    useJUnitPlatform()
}

Version of detekt used: 1.23.7
Version of Gradle used (if applicable): Gradle 8.10.2
Gradle scan link (add --scan option when running the gradle task):
Operating System and version: MacOS
Link to your project (if it's a public repository):
https://github.com/alpeshvas/detekt-poc

It started working after I enabled allRules flag to true throught detekt dsl, this is so weird. There is no such thing mentioned in the documentation, adding custom rule in the generated detekt.yml config file should work right?

Yes, it should. I'm not sure what's going on.
What happens when you put the config on your project configuration directly?

Yes, it should. I'm not sure what's going on.

Can you check it out in the public repository I shared? Tried different things, no luck.

I briefly looked into your reproducer @alpeshvas and I'm not able to find the root cause of your problem. At first I thought it was related to you using the root project as sample project, but moving the sample code to a separate sample module hasn't solved.
It seems like the rule is not executed altogether. The rule set is however loaded by detekt.

I briefly looked into your reproducer @alpeshvas and I'm not able to find the root cause of your problem. At first I thought it was related to you using the root project as sample project, but moving the sample code to a separate sample module hasn't solved.
It seems like the rule is not executed altogether. The rule set is however loaded by detekt.

Let me know if you need anything else from my side but reproducer has everything to reproduce the issue.

@cortinico @BraisGabin following up ^

I don't have right now the time to debug the problem. You can checkout https://github.com/BraisGabin/detekt-junit-rules this repo (or create a new one from the template) and use jitpack using the commit version to find if it works. And then keep it changing it until it stop working. This way you can find exactly what's wrong on detekt or on your configuration.
What seems clear is that there is something missing in detekt because it's not easy to debug this issues. So if you find something please keep posting here so we know which is the problem and we find a way to spot those type of issues easier.

I don't have right now the time to debug the problem. You can checkout https://github.com/BraisGabin/detekt-compiler-rules this repo (or create a new one from the template) and use jitpack using the commit version to find if it works. And then keep it changing it until it stop working. This way you can find exactly what's wrong on detekt or on your configuration.
What seems clear is that there is something missing in detekt because it's not easy to debug this issues. So if you find something please keep posting here so we know which is the problem and we find a way to spot those type of issues easier.

Tried, couldn't figure out the issue


accumulate: add bookkeeping

I'm not sure if this would be the first version of the tests, so if anyone knows differently please let me know and I can edit it.

Thanks @raadler , If it doesn't have a BookKeeping module then we tend to consider it the first version anyway.


Automatically create the topic and subscription.

If the first attempt at posting a message fails.
This means one fewer error that the user has to read, figure out, and fix.

LGTM


[Bug]: plex_pilots attribute of Plex Builders not working as expected on Playlists

Version Number
1.16.1
What branch are you on?
master
Describe the Bug
In the plex builder wiki, The attribute plex_pilots says it works with playlist, but when put into a playlist it returns the error Playlist Error: plex_pilots attribute not allowed when using playlists the wiki also says it only works with collection_level: episode and I tried adding that but go the same result
Relevant Collection/Playlist Definition
playlists:
  Watchlist:
    collection_level: episode
    plex_pilots: true
    sync_to_users:
    sync_mode: sync
    libraries: Movies, TV Shows
    trakt_list: https://trakt.tv/users/frazzer951/watchlist?sort=rank,asc
    summary: Watchlist of TV shows and Movies

or
playlists:
  Watchlist:
    plex_pilots: true
    sync_to_users:
    sync_mode: sync
    libraries: Movies, TV Shows
    trakt_list: https://trakt.tv/users/frazzer951/watchlist?sort=rank,asc
    summary: Watchlist of TV shows and Movies

Logs
https://gist.github.com/Frazzer951/e33432efdce5415842eade862feca18a

ok i pushed a fix for this to nightly


Photo Sphere viewer does not open

Apologies, I did not intentionally bypass the issue template. It seems Github skips the template page under certain circumstances. I'll resubmit with the template.


add support for debug_mode

Adds the ability to enable debug mode via a prop on GoogleAnalytics.

Thanks @jacksonhardaker , this is great!

This PR makes all users appear in the DebugVIew and flags every event with debug_mode: 1.

Even undefined, debugMode generates this parameter in the request:
debug_mode=false
Some article on the web states:

Downgrading the package version (to v2.2.0) successfully removed this behaviour.

@santoni0 thanks for reporting this! I pushed a fix, would you mind upgrading to v2.2.2 and verify again?


[Marker.io] Image & hover effects missing from menu

Steps to reproduce:
Open meny on desktop
Actual result:
Expected result:
Menu design in figma here
https://www.figma.com/design/cewZQZSdeFRv1lMy4RfXlP/Prezzee?node-id=8849-17920&t=ho0t3aI2bU2NU7U4-1

Reported by: Holly<EMAIL_ADDRESS>- Contact via Marker.io
Source URL: https://na13-prezzee.webflow.io/en-us
Issue details: Open in Marker.io
Device typedesktopBrowserChrome <IP_ADDRESS>Screen Size2048 x 1152OSOS X 14.7.1Viewport Size1561 x 912Pixel Ratio@2x

🤖 Marker.io bot - This issue was marked as ✅ Resolved in Marker.io


[WIP] Observability Overview page rework

Description
** Pending https://github.com/opensearch-project/dashboards-observability/pull/2209 merge first to update cards.

Move page options to the header
Add UI setting to persist if the cards are disabled
Add ability to dismiss the cards to the page header
Update the empty state for no dashboard selected
Update the fly-out empty state
Small UI adjustment to integration table

Disable cards functionality:
https://github.com/user-attachments/assets/1a283eb6-6c57-4bdf-af68-0c571ad3a42a

Before
After

Update to integrations table

Before
After

Issues Resolved
Check List

[ ] New functionality includes testing.

[ ] All tests pass, including unit test, integration test and doctest

[ ] New functionality has been documented.

[ ] New functionality has javadoc added
[ ] New functionality has user manual doc added

[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

New cards working with dismiss


How can I disable focusing when a marker is clicked?

Clicking a marker seems to update the focus on the globe. I'd like to disable this, perhaps with enableFocusOnClickMarker prop. This is the line in question, it seems:
https://github.com/chrisrzhou/react-globe/blob/9d8e91351b8dbebf0c8aa2444404464a07ea54c0/lib/globe.js#L177
I don't want users to be able to click into the globe. Thanks!

For now I just removed updateFocus using patch-package.


Unable to claim Back End certificate

As part of the recent changes the Full Stack certificate I had previously claimed was removed, but the corresponding waypoint was still marked as done, and this waypoint was reused for the new Back End certificate. I have now completed the additional API challenges, but when I click through the waypoint again I don't get the Back End certificate added to my profile (http://www.freecodecamp.com/george-stepanek).

Hi George,
Yes - I noticed this earlier today. Thank you for opening the issue. @Berkeleytrue is working getting this fixed along with the new Data Visualization certification.

I'm going to close this as duplicate and update this issue: #5553

Closing as duplicate, per Quincy's instructions.


Breaking autocomplete?

Whenever I type things that I'm used to being autocompleted (Sublime will autocomplete based on the words already found in the current document), all I get is all the React suggestions.
For example, I used to be able to type func and hit tab and it would autocomplete to function. Now it autocompletes to React.PropTypes.func.
What the heck? I don't WANT this. Any way to just turn it off? All I want is proper syntax highlighting.

Sorry, realized this is from https://github.com/allanhortle/JSX not this repo.


Using view backgroundImage with css flag on breaks the view

This screen does not render unless you remove cssStyling: true from theme.
https://studio.ensembleui.com/app/j6Kx5d3u1t6GzMHiOWAy/screen/jBJj8YhqCjDn9Vo8WNqo
EDL is:
View:
  styles:
    backgroundImage:
      source: https://images.pexels.com/photos/19749503/pexels-photo-19749503/free-photo-of-moon-among-clouds-on-pink-sky.jpeg?auto=compress&cs=tinysrgb&w=1260&h=750&dpr=2
  body:
    Column:
      children:
        - Text:
            text: test

yeah it's another yamlMap to map issue. That has been the bane of my existence, implementing the feature was the easier part ;-)


Update opera-developer to 44.0.2494.0

After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} left no offenses.
[x] The commit message includes the cask’s name and version.

An extra commit somehow slipped through.

Thanks for pointing that out, Vitor! Fixed.


Fix wireframe overlay

As title, the wireframe is currently not displayed correctly. This will create another mesh for the wireframe to overlay on the actual object

Ok, Seems fine.


Ability to lock scroll if all slides in view

Hello.
Is it possible to lock scroll or check if all slides shown completely?
I know that we could get container width with containerRect.width inside api "scroll" callback and compare it with the sum of all slides widths, but is there more cleanup way?

Hi @Intaria,
I'm not quite sure what you mean by lock scroll. Do you want to disable dragging when all slides have been in view once? Or do you want to be able to determine when the carousel has scrolled to the end of its scrollable length?
Best,
David

Hi @davidjerleke
Totally disable dragging and overstretching slides when all slides in view at once.

Hi! I have the same question:)

@Intaria are you using vanilla JS or React?

@davidjerleke react

Hi @Intaria,
If I understand you correctly, you want to disable dragging as soon as the carousel is headed for the end of its scrollable length. Please let me know if this is not the case. Here's a CodeSandbox demonstrating that. This is how the sandbox works:

As soon as the carousel is headed for the end of its scrollable length, either by dragging or clicking the next button, the carousel is re-initialized with the option draggable: false.
Note that the carousel will continue scrolling until it reaches its end destination.

Is this what you wanted to achieve?
Best,
David

@Intaria have you had any chance to read my response?

I'll chip in here. It would be nice to have an option (similar to draggable - something like noScrollWithAllSlidesInView - probably with more compact wording though) on the initialisation of the carousel. When all slides are in view at once, hence there is no need to use the scroll - then disable it. But this would be an option for the slider, not an extra function with overflow computation etc. That's at least what I would propose.

Hi @stepanjakl,
Thank you for your response. You didn't answer if the solution I provided here was what you wanted to achieve?
I have to weigh feature request carefully because one of the biggest selling points of Embla is that it's very lightweight but still offers a lot of functionality. Its API is very extensible - Both using the public API and the possibility to use and create plugins is what makes it very extensible. This is the first time in a couple of years that someone asks about this feature. So I don't want to prioritize building it into the core and burden other users with an increased bundle size, unless it gets a whole lot of traction/attention. In contrast, an example of a feature request that got very much attention was the new breakpoints option that was released with v7 yesterday.
So for now I would say that the little function I shared in my solution is what I can offer. I hope this makes sense.
Best,
David

I understand. The required outcome can definitely be achieved by using Embla's API. The solution you provided is close to what's needed, except it should disable the scroll on initialization and/or possibly even when slide widths change. For instance, on the desktop you could have 2 slides with 50% width. They fit the container area without overflowing - scroll can be disabled. On the mobile, slide width changes to 100%, therefore one slide would overflow - scroll is enabled. I would say it's not a priority. I could also create a codepen solution for this later.

Hello again @stepanjakl,

For instance, on the desktop you could have 2 slides with 50% width. They fit the container area without overflowing - scroll can be disabled. On the mobile, slide width changes to 100%, therefore one slide would overflow - scroll is enabled.

I think you can do it like this:
const toggleActiveWhenScrollable = () => {
  const isScrollable = embla.internalEngine().scrollSnaps.length > 1
  emba.reInit({ active: isScrollable })
}

const embla = EmblaCarousel(emblaNode, { loop: false })

embla.on('resize', toggleActiveWhenScrollable)
toggleActiveWhenScrollable()

Let me know if it helps.
Best,
David

Thank you David, that is a good solution.

Hello again @stepanjakl,

For instance, on the desktop you could have 2 slides with 50% width. They fit the container area without overflowing - scroll can be disabled. On the mobile, slide width changes to 100%, therefore one slide would overflow - scroll is enabled.

I think you can do it like this:
const toggleActiveWhenScrollable = () => {
  const isScrollable = embla.internalEngine().scrollSnaps.length > 1
  embla.reInit({ active: isScrollable })
}

const embla = EmblaCarousel(emblaNode, { loop: false })

embla.on('resize', toggleActiveWhenScrollable)
toggleActiveWhenScrollable()

Let me know if it helps.
Best, David

Could you provide a example for React please? I'm trying to adapt your example but no success so far.

is there a way to make embla don't block scroll on vertical slides (axis y) ?
on mobile when embla is full width scrolling will just keep sliding embla rather then scrolling the body

Heads up for anyone trying to use the example code posted here. resize event won't fire any longer after active is set to false.
https://github.com/davidjerleke/embla-carousel/blob/7cc1aee2506e7ec4ffeb4eaadb94b7259b286c1c/packages/embla-carousel/src/components/EmblaCarousel.ts#L110-L117
As a workaround I suggest implementing your own ResizeObserver and using that with the event handler.

is there a way to make embla don't block scroll on vertical slides (axis y) ?
on mobile when embla is full width scrolling will just keep sliding embla rather then scrolling the body

You can achive this via breakpoints. If you know when will you show the all slides you can just set the screen size like this:
const [emblaRef] = useEmblaCarousel({
  breakpoints: {
    '(min-width: 1250px)': { active: false }
  }
});

```ts
toggleActiveWhenScrollable()

Yep I second this, I don't think this issue should be closed.

@dbismut what exactly do you want to achieve?

First of all, wonderful job on this package, thanks a lot for it.
I'd like the same thing as the original comment: deactivate the carousel when all slides are fullly visible. Your solution works great to deactivate the slideshow, but as pointed out in this comment by @Ingramz the resize stops working once you've deactivated the carousel.
Which means that going from activated to deactivated works, but not the other way around since the resizeHandler doesn't fire when the carousel is not activated.
Does that make sense?

@dbismut thanks for clarifying. You can control when the carousel should react to drag events with watchDrag like so:
function isScrollable(emblaApi) {
  return emblaApi.internalEngine().scrollSnaps.length > 1;
}

const emblaApi = EmblaCarousel(emblaNode, {
  watchDrag: (emblaApi) => isScrollable(emblaApi),
  loop: false
})

As for navigation buttons like next/prev and dot buttons, they're not built in so you can stop any scrolling when you want like so:
function scrollNext() {
  if (isScrollable(emblaApi)) {
    emblaApi.scrollNext()
  }
}

...etc.

Oh I see, thanks a lot for this!

I'd still like to see this feature be implemented.
I have an instance where all slides are varying widths and there is no way to tell how many scroll slides should be visible at any given breakpoint, to determine if it should be scrollable or not.
An option that simply disables embla entirely if all scroll snaps/slides are in view would be really nice. Not via breakpoints, or any such workarounds. ie; if there is nothing overflowing the carousel viewport, do not allow scrolling. Thats it.

Hi @HarleySalas,
Thank you for your input. With no intention of being rude:
Everyone wants the library to be super convenient with options that solve all their use cases automatically, and they want me to make that happen.
My free time is limited. The hardest part of adding a new feature isn’t the coding—it’s the planning, research and figuring out the best way to implement it without breaking the current code style or quality. That’s the very time consuming part of the process. Coding the feature usually only takes a few hours.
Before I add anything to the core library, there needs to be significant demand for it. If I added every requested feature immediately, the library would become bloated and huge. Many developers like Embla because it’s lightweight and very extensible, so I always have to keep that balance in mind.
While a few developers are interested in this issue, keep in mind that Embla Carousel is used in over 100,000 GitHub repositories—not counting projects using it via CDN or other services like BitBucket etc. Compared to that scale, interest in this feature has been relatively low.
If you support this feature request, the best way to show it is to add a 👍🏻 reaction to the original post. That’s easier for me to track than reading through multiple comments.
Until there’s enough demand for this feature, you’ll need to stick with this solution.
Best regards,
David


fix(scripts/pingcap/community): add sign-off in commit message

Signed-off-by: wuhuizuo<EMAIL_ADDRESS>

/approve

/approve


Encoding bug when getting the results of a windows command

Hi,
I'm trying to execute the follwing command on a french version of Windows 12 :
sudo crackmapexec -uxxxx -pyyyy <IP_ADDRESS> -x 'net user'
Unfortunately, one of the users has some special character in its name, resulting in the following stacktrace:
ERROR:root:'ascii' codec can't decode byte 0x82 in position 55: ordinal not in range(128)
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/gevent/greenlet.py", line 534, in run
    result = self._run(*self.args, **self.kwargs)
  File "/usr/share/crackmapexec/core/greenlets.py", line 242, in main_greenlet
    ntlm_hash)
  File "/usr/share/crackmapexec/core/executor.py", line 30, in __init__
    wmi_exec.run(host, connection)
  File "/usr/share/crackmapexec/core/scripts/wmiexec.py", line 82, in run
    dcom.disconnect()
  File "/usr/lib/python2.7/site-packages/impacket/dcerpc/v5/dcomrt.py", line 1070, in disconnect
    del(INTERFACE.CONNECTIONS[self.__target][currentThread().getName()])
KeyError: 'DummyThread-1'
<Greenlet at 0x7f14a8a01b90: main_greenlet('<IP_ADDRESS>')> failed with KeyError

I think that it happens when the script tries to print the output of the command in the shell.
Keep up the great work, this tool is awesome =) !

can you give me the output of the same command with the --verbose flag? Thanks

Ignore that, referenced the wrong issue number

This should be fixed in https://github.com/byt3bl33d3r/CrackMapExec/commit/d256444cb5fa7e7d27b41f7026649e0819d6816e


Panic after calling take.

While trying to implement cell with expiration, I found that following code
/*
[dependencies]
async-once-cell = "*"
tokio = { version = "*", features = ["macros", "rt-multi-thread"] }
*/

#[tokio::main]
async fn main() {
    let mut cell = async_once_cell::OnceCell::new_with(Some(0u64));
    let value = cell.get();
    let _ = cell.take();
    let _ = cell.get_or_init(async { 1 }).await;
    println!("done");
}

playground
causes
thread 'main' panicked at 'called `Option::unwrap()` on a `None` value', /home/explorer/.cargo/registry/src/github.com-1ecc6299db9ec823/async-once-cell-0.4.2/src/lib.rs:455:51
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

here:
        // Safety: initialized on all paths
        Ok(unsafe { (&*self.value.get()).as_ref().unwrap() })

It seems not all paths ensures value is initialised.

Please check if master fixes this; I just noticed that there's a commit to fix this issue but it wasn't included in 0.4.2.  I'll release 0.4.3 with that later today.


Support for multiple streams in ORT

Need to surface what ever ORT implements.

Please see https://github.com/microsoft/onnxruntime/pull/3723, which is now merged to ORT main.

Added labels and milestone as test only. Feel free to remove anytime.

This was done as part of https://github.com/triton-inference-server/onnxruntime_backend/pull/47


Vendor the test-infra scripts

shared scripts from test-infra live in //vendor/github.com/knative/test-infra/scripts;
created //hack/update-deps.sh to properly update deps, including test-infra;
all bash scripts were updated to use the vendored scripts;

Fixes knative/test-infra#82.
Part of knative/test-infra#30.

/lgtm
/approve


CLDC-1782 Create bulk upload logs

Context

https://digital.dclg.gov.uk/jira/browse/CLDC-1782
This change enables logs from bulk upload to actually be created if they are valid

Changes

Added associations between logs and bulk upload
When logs are created they now reference the bulk upload
The step to check the threshold of whether or not we should create logs has been skipped out for this PR and can be slot in later. At the moment as long as every row in the CSV is considered valid it will create all the logs
For whatever reason a log cannot be saved to log this to sentry for further analysis later
Added class in tests providing tooling to create csv rows from a log i.e. reversing the process to create test data. This class is no way complete but offers convenience and lowers effort needed to create test data
Fixed a bug where renewal was not correctly inferred from correct field if not provided

This has been merged via https://github.com/communitiesuk/submit-social-housing-lettings-and-sales-data/pull/1208


add first moment in history when integration was performed :)

Hi @daviddias 👋
Can you clarify the dates a bit more? Currently the render looks like this:

Hi @daviddias 👋
Can you clarify the dates a bit more? Currently the render looks like this:


not safe use absolute path as id template

after compile twig, in js id contain my absolute path file, it not safe
twig({id:"/var/www/project/frontend/components/block/template.twig" ...

twig-loader index.js issue string
var id = require.resolve(this.resource)

Must research if process.cwd can be used to calculate a relative path...

@webberig We will can in product mode set Id of twig template as hash by path.
add setting to twig-loader "path".
and set it to "[resourcePath]" or "[hash]" in develop or product mode.
example:
{
    test: /\.twig$/,
    loader: function () {
        return process.env.NODE_ENV === 'development' ? 'twig?path=[resourcePath]' : 'twig?path=[hash]';
    }())
},

Started work in PR #17 ... Needs further testing, any feedback is much appreciated!


Store enum columns (as integer)

Enum properties are not stored on the current implementation
[Flags]
public enum EAttributes : ulong
{
	// ...
}

public class MyTestTable
{
	public EAttributes Attributes1 { get; set; } // Column not created

	[Column("_attributes2")]
	public EAttributes Attributes2 { get; set; } // Column not created

	[Column("_attributes3", TypeName="integer")]
	public EAttributes Attributes3 { get; set; } // Column not created
}

This is caused by a limitation in Entity Framework itself. As mentioned here: https://msdn.microsoft.com/en-us/data/hh859576 only the following underlying enumeration types are supported: Byte, Int16,  Int32,  Int64 , or SByte.
If you replace the 'ulong' in your enumeration type declaration by 'long' the corresponding column should be created (I've used it like that before):
public enum EAttributes : long
{
    // ...
}

Very true. I got it working.
Thanks and sorry for raising a wrong issue.

:+1:  You're welcome! :)


ADD: Download from unlisted post by ID

Allows users to download unlisted posts from pixiv
As the page and APIs are similar to the artwork page, I decided to just edit the code a little and allow reused exiting codes to help with the downloading.
Let me know if I need to make any changes!

got sample for the unlisted post? never see that before?

I have added a link in the comments of how the URL looks like.
here it is "https://www.pixiv.net/artworks/unlisted/SbliQHtJS5MMu3elqDFZ", one probably needs to be whitelisted by the artist, I am unsure how it works. Here is a screenshot of how the page looks like.

noted, link is nsfw btw, so I edited it so it doesn't go directly


Add error handler

Is your feature request related to a problem? Please describe.
At the moment, one of the challenges is that callers of the generated Retrofit.dart code have to know about things like a DioError. I feel like this is an implementation detail of the networking layer, and it would be nice to be able to (within the Retrofit file) catch and provide common error handling and/or possible modification to any errors.
Describe the solution you'd like
I was thinking that we could add another parameter to the RestApi annotation which is a function reference. Something like:
@RestApi(onError: handleError)
abstract class MyAPI {
  @POST('/login')
  Future<User> login({String userid, String password});

  Exception handleError(Exception e) {
    // this is where I would do any common error handling
    return MyNewException();
  }
}

And then, in the generated code, if the onError parameter has been set, then it would call this function before rethrowing.
Note that I think that the error handling should also encompass both the network call and also any calls that convert to/from JSON.
Describe alternatives you've considered
I did think about adding the following function in the generated class:
class _MyAPI implements MyAPI {
  ...

  Exception handleError(Exception e) {
    // standard error handling just returns the error untouched
    return e;
  }
}

And then the app's class could override handleError(). The same changes would be required in the generated code, however, I feel like that isn't super discoverable for users of the Retrofit library.
At the moment, the only "workaround" I can find is that every caller has to apply their own common error handling. That behaviour can be extracted into a common function, but I do believe that the domain-specific business logic should not know about things like DioError.
Additional context
None

I think handling errors for each method would be better because sometimes we also throw errors based on the API response that comes from the server. For more information I have filed a issue #357

I think that error handling should be done by the dio interceptor.
Dio interceptor only supports throwing DioError. Therefore, we can make custom exception implement the DioError interface :)
This is a example: https://gist.github.com/ipcjs/c0896bf90effe955a863ed9813d006c5

I think that error handling should be done by the dio interceptor. Dio interceptor only supports throwing DioError. Therefore, we can make custom exception implement the DioError interface :) This is a example: https://gist.github.com/ipcjs/c0896bf90effe955a863ed9813d006c5

The issue I see with this is that I cant throw custom exceptions specific to the API call.

I suppose I could use @Extra(), but then it becomes boilerplate-heavy, which is exactly what I'm trying to avoid.
I'd rather specify an @ErrorHandler(onError) on the method

I think theres no reason not to support this.
In fact, we could have 2 handlers. one common to everything, and one for the individual calls.
Theres quite a few ways we could do this.
All methods:

Have an arbitrary method in the class annotated with @ErrorHandler() which generates a try catch for every method, passing the exception into it. (we could name the method itself whatever we want.) (a potentially overridable method) (better?)
Have an onError in the annotation @RestApi(onError: handleError) (always a static method)
Per method:
Have an @ErrorHandler(onError: (e, s) => do something) (always static)
Perhaps some kind of consistent naming scheme for per-method error handlers?

for a getTasks could be maybe a _catchGetTasks? (feels arbitrary)
for a getTasks define a method that handles errors and call _getTasks()?

alternatively document that users should simply define as follows:

@Get(whatever)
Future<Something> _getTasks();
Future<Something> getTasks() => _getTasks()..onError // or whatever -> arbitrary.

Honestly the only thing that i think actually needs to happen is to define an @ErrorHandler() (annotation name can be changed) method.
it makes the most sense as an in-class method because you could possibly override it, if desired.
that could always be changed by making it private or static or whatever the user desires.

Updated the above with some possibilities

I also find myself wrapping every rest client method call into something like this:
_restClient.apiMethodCall(...).catchError((ex) => errorHandler(ex));
That is a lot of boiler plate code and the same errorHandler is shared between multiple unrelated services.
Currently it is not possible to replace this with a Dio interceptor, because some exceptions, such as data conversions or SocketException are not being routed there.
Also the proposed @ErrorHandler() methods in the rest client is not ideal, because those methods may have to use framework specific code, which shouldn't be in the rest client (eg. Bloc or other state UI or navigation) and also this won't allow to share error handlers.
It would be neat if you could just specify an optional onError parameter in the rest client constructor declaration with the same signature as used by Future.catchError():
factory RestClient(Dio dio, {String baseUrl, Function onError}) = _RestClient;
and then have retrofit_generator would generate and wire in the above .catchError(onError) in the rest client implementation.

It sounds like more ideal and makes a minimum change. @ekuleshov @TekExplorer

That might be generally useful, but doesn't actually help convert responses into custom MyApiExceptions
If a method within the client could be set to wrap all methods generated by retrofit, that would fix it (as then you could have that reference a passed-in method or a static function or anything at all)
Additionally, if a wrapper method is defined, you could do a lot more before and after the actual API call is made

That might be generally useful, but doesn't actually help convert responses into custom MyApiExceptions internally

But it does. That is all I'm doing in my current boiler plate code for all rest API calls:
_restClient.apiMethodCall(...).catchError((ex) => errorHandler(ex));

where errorHandler is implemented something like this (removed all custom logic for simplicity):
T errorHandler<T>(dynamic ex) {
  throw MyException(message: ex.toString();
}

or it can return response with the error state:
T errorHandler<T extends MyResponse>(dynamic ex) {
  return MyResponse(error: ex.toString());
}

Generally it is the same idea and API as used in Future.then(..).onError(..).catchError(..)
Having a wrapper for each rest service method would provide similar features. But there is a problem with input and output types. I don't see how they can be mapped in the generated API, because rest API declares specific type - you can't change it in the generated code.
Also specifying any wrappers or handlers with annotations is too restrictive. Personally I'd prefer them specified as the factory/constructor parameters. That is also inline how freezed generates its code.

That might be generally useful, but doesn't actually help convert responses into custom MyApiExceptions internally

But it does. That is all I'm doing in my current boiler plate code for all rest API calls:
_restClient.apiMethodCall(...).catchError((ex) => errorHandler(ex));

where errorHandler is implemented something like this (removed all custom logic for simplicity):
T errorHandler<T>(dynamic ex) {
  throw MyException(message: ex.toString();
}

or it can return response with the error state:
T errorHandler<T extends MyResponse>(dynamic ex) {
  return MyResponse(error: ex.toString());
}

Generally it is the same idea and API as used in Future.then(..).onError(..).catchError(..)
Having a wrapper for each rest service method would provide similar features. But there is a problem with input and output types. I don't see how they can be mapped in the generated API, because rest API declares specific type - you can't change it in the generated code.
Also specifying any wrappers or handlers with annotations is too restrictive. Personally I'd prefer them specified as the factory/constructor parameters. That is also inline how freezed generates its code.

but thats the thing. with a wrapper function, you can do that.
class MyApi {

MyApi._({this.onError});
// passes along parameters that the private constructor has?
// could alternatively have a builder-style mutable variable
factory MyApi(dio, {baseUrl, onError}) = _MyApi;

final Function? onError;

// maybe include invocation details for more control? probably not.
@wrapper
Future<T> wrapper<T>(Future<void> Function() cb) => cb().onError(onError);
...
}

this not only gives you the ability to handle errors, but opens the door to do just about anything you want, including multi-step handlers. it also ensures that you actually see whats happening and no behavior is hidden.
this specific boilerplate could also be abstracted into a different annotation if you dont need this control.

Have you missed this.onError in the constructor? The @wrapper specification will likely going to be prohibitive due to types mismatch. It doesn't specify parameters or return types and Future<void> is likely invalid type in general. So, it is unclear if you can wire it like that with generated retrofit implementation.
All in all, as @trevorwang said, the onError handler is a smaller change.

Have you missed this.onError in the constructor? The @wrapper specification will likely going to be prohibitive due to types mismatch. It doesn't specify parameters or return types and Future<void> is likely invalid type in general. So, it is unclear if you can wire it like that with generated retrofit implementation.
All in all, as @trevorwang said, the onError handler is a smaller change.

what do you mean type mismatch? what do you mean Future being invalid? none of that seems to actually reference anything

@TekExplorer all I'm saying your examples are incomplete and it is unclear how implementation can be wired together for them. You have declaration for the rest API methods and your wrapper or error handler. But what has to be in between?
Can you write method(s) that will call the rest API methods and then "wraps" that call into your wrapper/handler one to demonstrate how it is supposed to work for various method parameters and return types? The retrofit_generator will essentially have to do just that.
My suggestion is much simpler in that regard. It simply chains to the Future API which retrofit_generator already handling.

@TekExplorer all I'm saying your examples are incomplete and it is unclear (at least to me) how implementation can be wired together for them. You have declaration for the rest API methods and your wrapper or error handler. But what has to be in between? So, perhaps such approach is over-generalized...
Can you write method(s) that will call the rest API methods and then "wraps" that call into your wrapper/handler one to demonstrate how it is supposed to work for various method parameters and return types? The retrofit_generator will essentially have to do just that.
My suggestion is much simpler in that regard. It simply chains to the Future API which retrofit_generator already handling.

my idea is extremely simple.
1 method which wraps the rest
@wrapper
Future<T> wrapper<T>(Future<T> Function() cb) => cb().onError(...);
// or
Future<T> wrapper<T>(Future<T> Function() cb) {
  // do something custom.
  try {
    final data = await cb();
   return data
  } catch (e) {
    print('something went wrong: $e')
  } finally {
    // something custom. releasing a lock?
  }
}

// perhaps you want to do something with the response.
// routes that just want the data can use the data getter
Future<T> wrapper<T>(Future<HttpResponse<T>> Function() cb);

@GET
Future<Todo> getTodo(id);

Future<Todo> getTodo(id) {
  return wrapper<Todo>(() async {
     ...
     return dio.get(id)
  });
}

// or
Future<Todo> _getTodo(id) async {
  return dio.whatever
}
Future<Todo> getTodo(id) => wrapper(() => __getTodo(id));

@TekExplorer you said you want to do "multi step handlers" or perhaps have access to the rest method parameters in your wrapper, but your example does not reflect any of that and doesn't do anything that can't be done in a regular Future.onError() callback.
Future<T> wrapper<T>(Future<T> Function() cb) ...
Also your example also binds your wrapper return type to the rest api method return type, so wrapper won't be able to alter the return type of API response.

I have the same opinion with @ekuleshov .    It seems that It doesn't provide more benefits than a normal error handle from you proposal.   @TekExplorer

I think it makes sense. but honestly, if only there was a way to "pass along" parameters instead of having to specify them manually it would be a non-issue

I implement a simple wrapper generator to handle error. It will be nice if the library can support this feature.

I implement a simple wrapper generator to handle error. It will be nice if the library can support this feature.

This is amazing, work very good @ebwood, you have intention to publish into pub.dev?


OFM Translations - Summer'21

Critical Changes
Changes
Issues Closed
New Metadata
Deleted Metadata
Definition of Done
Refer to Definition of Done to see any additional details for the items below:

[ ] Any net new LWC work has JEST test coverage 50% or above
[ ] Default Sa11y tests pass for all LWC components
[ ] 🔒 Secure both Front-end (LWC) & back-end (Apex) as necessary
[ ] 🔑 Grant users access in Permission Sets (Object, Field, Apex Class) as necessary
[ ] Link the pull request and work item by PR comment and Chatter post respectively, e.g. GUS: W-0000000: Work Name
[ ] Make sure that ACs are updated (if any gaps)
[ ] All acceptance criteria have been met

[ ] Developer
[ ] Code Reviewer

[ ] Pull Request contains draft release notes
[ ] Labels, help text, and customer facing messages are reviewed by Docs
[ ] QE story level testing completed

We already released Outbound Funds Module to unblock Grants Management. This PR missed the boat. If this gets merged we will have to do a second release to be the "real" 232 package.

@sella24 , does this need to be a feature/ branch to merge into master?

@sella24 , does this need to be a feature/ branch to merge into master?

@spelak-salesforce : I don't think so. it doesn't need to be a feature branch.

@sella24 , does this need to be a feature/ branch to merge into master?

@spelak-salesforce : I don't think so. it doesn't need to be a feature branch.

The feature/ prefix is needed to trigger MetaCI builds automatically. You can also trigger builds manually when your branch doesn't include the prefix--I've done so here.

@sella24 Is this PR going to be merged for 232? Release freeze is in approximately 3 hours.
cc @jstvz

Hi @davidmreed , yes it is supposed to be merged for 232.

Closing this PR because it has been cloned into into feature/translation_sfdo-232 with new PR #151


CFP: Support UDPRoute in Cilium Gateway API

Cilium Feature Proposal
The first cut for Gateway API was done in https://github.com/cilium/cilium/pull/21749, however, we have a couple of follow-up tasks to support more features from Gateway API upstream.
This is to track the work to support UDPRoute
Goals
TBD
Proposed Solution
TBD
Tasks
TBD

The work to implement TCPRoute and UDPRoute has so much in common that it's better to track it with one issue. Closing as duplicate, moving to #21929.


error: 'linear_regression_train' undefined near line 35 column 47

Hi
I'm learning linear regression.
In demo.m,I'm running your code to report errors：
            .......
Running linear regression...
error: 'linear_regression_train' undefined near line 35 column 47

I'm sorry. It was my carelessness.
😂


Server examples, updating readers map after closing connection

Hi, I've found a small issue in server examples. When the reader closes connections handler to connection is not removed from the reader's map. It makes unnecessary onFrame for loop iteration or RTP frame repetition on reader site. The way I handle it is fairly simple:
if conn == publisher {
		publisher = nil
		sdp = nil
	} else {
		delete(readers, conn)
	}

I'm quite new to go so I'm not sure if it is the clean and correct way of handling map element removal. Please consider fixing both server and server-udp examples the same or similar way.

Hello, thank you very much for reporting this, it has been fixed.


Add support for AlfredCMS

Add information about this plugin to README.md, please.
Can you give me a link to the website of the AlfredCMS? Can't find it : (


Automated Package Upgrade

:tada: This PR is included in version 7.0.143 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Duration parsing fails for large numbers without showing exception to user

steps to reproduce:

type in a duration with 17 characters
job n/work d/12345678901234567
PeopleSoft doesn't respond. Gradle throws Invotaion Target Exception, Arithmetic Exception: long overflow. from ParserUtil line 206.

note: the limit is 16 characters if all of them are '9'

no longer an issue, likely closed by #204


Analyze Critical/High hl7v2-fhir-converter Fortify Findings

User Story

As a maintainer of the project backend code,
I want to address Fortify scan results,
so that my project does not have vulnerabilities
Description/Use Case

Fortify scan is a static application security testing (SAST) tool that analyzes source code for security vulnerabilities. This tool was recently run against the hl7v2-fhir-converter library and we should address the findings.

Each finding should be analyzed and documented here: https://docs.google.com/spreadsheets/d/1GkTsTtO8aLR09vtxX1ex-bqjlVqshVzH064hA8RqIPw/edit?usp=sharing.
Notes can be kept here, if needed here
New ticket(s) shall be created to address the findings categorized as 'Will Fix'

Risks/Impacts/Considerations

Dev Notes

Acceptance Criteria

[ ] Findings analyzed and spreadsheet updated
[ ] New ticket(s) created to address analyzed findings

Hey team! Please add your planning poker estimate with Zenhub @adegolier @arnejduranovic @jack-h-wang @jalbinson @JFisk42 @wcutshall


First draft for msal-node documentation

Add documentation for msal-node alpha release

Coverage remained the same at 79.458% when pulling 471dc0421945f52e382608fc7ddd7f4228b3c153 on msal-node-documentation into d907a56d3fcb9c22b052f3f4b8187243212f68a6 on dev.

Add a link to this README from the root README.

Closing it as we merged #1902 instead


Flow - RDD to DF

Implements DataFrames for netflow related classes:
Moving word creation to FlowWordCreation.
Implementing FlowSchema.
Flow Feedback refactoring to return DataFrame instead of RDD.
Updated FlowSchema with intermediate columns.
Updated FlowWordCreationTest.

LGTM

looks pretty good, ricardo
my comments are mostly cosmetic, although I am concerned about the commented out unit test....
if the test is now completely invalid, it should be deleted
if it's still valid, it should pass

In commit #1737753 I meant "Out of date". Sorry for the typo.

looking good


Adding credits.md - Solves #88

Hello, thanks, i will open another PR starting from your branch, where i will squash the commit and edit the contributors (some are invisible from this github repo)


Patient page and dashboard page is not working

When I tried to publish to IIS and after publishing logged in as admin on dashboard page all the actions failed under home controller with 404 error

For patient page getting datatable issue

Working fine needed to make changes to path


Allow passing of url to redisOptions object

Adds support for adding a url parameter to the redisOptions object following the reds:// scheme, increases compatibility with platforms like Heroku which provide redis:// urls for connecting

You'd need to make the appropriate changes to the CoffeeScript file which will be compiled into the corresponding JavaScript. However, is there a reason you're not using the redis_connection option support?


Update USERS.md

Adding Rubrik to the glamorous users list

What: Adding Rubrik to the list

Why: To show people that Rubrik is part of the glamorous community

How: via github.com

Checklist:

[n/a ] Documentation
[ n/a] Tests
[X ] Ready to be merged
[Not worthy yet] Added myself to contributors table

Codecov Report

Merging #338 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #338   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files          10     10
  Lines         174    174
  Branches       48     48
=====================================
  Hits          174    174

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3eeffc9...8c933ad. Read the comment docs.

@kentcdodds looks ok for me.


[Bug]: Google Sign Up doesn't work

Summary
Using the signup feature "sign up with google" causes firebase auth handler to freeze, sign in works as intended
Reproduction

Visit lets plan fresh (no previous account)
Click user menu > sign up
Select Google

Expected
Just like with signing in, the auth popup closes and the user is brought back to their account where they are now logged in
Actual
The auth popup shows for an extended period before closing with an error: "Popup closed before sign up could complete".
Note that this doesn't happen for Google accounts that already have an account on Lets Plan, and doesn't happen at all when using "sign in with google" even for account new to Lets Plan

Can't reproduce with my account - the method for sign in and sign up is identical. Attempting to fix by closing modal after opening clicking on the signup button.


reuse queries in pro project db

[ ] I added an entry to CHANGELOG.md if knowledge of this change could be valuable to users.

Here is a brief summary of what I did:

 Die ProPostgresDb sollte, wo möglich, die Queries der PostgresDb wiederverwenden

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

447 of 468 (95.51%)  changed or added relevant lines in 6 files are covered.
4 unchanged lines in 3 files lost coverage.
Overall coverage decreased (-0.002%) to 89.499%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

services/src/layers/postgres_layer_db.rs
211
232
90.95%

Files with Coverage Reduction
New Missed Lines
%

services/src/api/handlers/upload.rs
1
99.52%

services/src/tasks/in_memory.rs
1
92.04%

services/src/pro/contexts/postgres.rs
2
96.34%

Totals

Change from base Build<PHONE_NUMBER>:
-0.002%

Covered Lines:
109192

Relevant Lines:
122004

💛  - Coveralls


code not running

Hi! I've tried to run your code using the 'bash run_bert.sh' command inside a GitHub codespace and the process is being killed and not completing. Is this code no longer able to be run?

Hi there!
I have never used a Github codespace but it seems like a server they provide that can run code? BERT-large takes a large amount of VRAM and RAM, so it's possible that your codespace doesn't have the memory capability to run this. It also depends on what your error message was. If it simply said "killed" it probably is RAM and not VRAM issues - either way though you'll need something with enough to run BERT.
Not sure what your situation is, but I would recommend Google Colab if you have that option available. This code should be able to run on the free tier.
Let me know if you have other questions!

Hi! I have a question, why test.tsv in /data/puns has no labels, while both the train and dev sets have labels

The full data is in the full_dataset folder and includes all labels. Generally I try to keep the labels off of the test data to avoid accidentally validating on them.  Looks I only did that with the pun data in this case (not sure why, but this was in 2019 so I've forgotten most of the details now - it also looks like I didn't upload the code I used for splitting that file). However, that doesn't matter since the labels are in the other file.
Feel free to join the data with that in the full_dataset folder to get the labels and then evaluate on that.


Extension domains configuration for the fhr instance validator

Creating larger questionnaires with extension domains will currently produce lot's of information messages with regard Unkown extensions which might drown the more critical warnings and errors.
The InstanceValidator already has a data structure which is used for registering extension domains, but this data structure is not exposed to client code.
The first of patch for this branch add the necessary functionality for the FhirInstanceValidator in DSTU3 and R4 and the second patch add two tests.
The third and fourth patch are not really about this functionality and can in priniciple remove from this branch and/or moved in their own branches.
The third patch fixes and obvious bug when intialising the FhirInstanceValidator and the forth one tackles a variety of different less important issues.

Coverage increased (+0.02%) to 72.533% when pulling d6416f079a938182f6e7544647c589adb5a93cca on hdconradi:extension_domains_configuration_in_fhr_instance_validator into f766156ca376a39e0ce091d1a155af1e3c5e56f3 on jamesagnew:master.

I have added a bit javadoc and renamed those methods from setExtensionDomains -> setCustomExtensionDomains.
Furthermore I have discovered a (probable) bug for the predefined fhir StructureDefinitions and corrected it in the very first patch.
The tests have been adapted accordingly.

Rebase after 3.4

Rebase after 3.5.0

Rebase after 3.6

Hi @hdconradi - Sorry this took so long to merge, and many thanks for keeping it up to date. I'm merging it now so you don't need to do this any longer. :)


Multiple ssl certs support

closes #13

CLA resubmitted

@adrianlop I updated your branch to support both the old way and new cert list. Can you please review?
This also closes #19.

@danisla thanks for the update, LGTM and also it's great that you included examples 👍


add a sync option among other chrome users

it would be awesome if we can sync simple todo's data to our google account .

Hi, related to that issue, it would be great to sync TODOs with Firefox accounts :)


F1 22 participants field order

games field order doesn't match documentation... kind of "reverse engineered" the acutal order. may have a look.

sorry, my last commit was odd as well :-) but should be okay now

added missing packetFormat-check in lapDataParser

not sure why but the issue i tried to address is gone ;-)


Added another python solution

From the description I assumed that every letter would at most one equal letter following it

Guess that is the same solution that was already merged with #24. If I missed something, feel free to reopen. 😄


Support for Rainbow Wallet in V2

Changes

Added rainbow namespace to InjectedId enum
New Rainbow provider preset in EthereumPresets with isMobile fallback configuration
Support for ethereum.isRainbow provider in getInjectedId

Tests
Injected Wallet
With Rainbow installed:

With MetaMask installed:

Without a detectable provider:

Desktop - View All
Without Rainbow installed:

Injected wallets are now managed through https://cloud.walletconnect.com you can either create a new entry for your project or add your unique injected flag to existing entry.


Investigate compatibility with Dask changes to run tasks outside their event loop

Dask is updating their worker to run submitted async functions outside of their core event loop — this makes a ton of sense but it's breaking Prefect and we are blocking merge of the change. We should determine what changes in behavior are happening and coordinate with them to update their PR or update Prefect to support the changes.
See the change at https://github.com/dask/distributed/pull/7339
See failures at https://github.com/PrefectHQ/prefect-dask/actions/runs/3593749911/jobs/6051108850 in #50

I am encountering this error when I run pytest tests -k "test_failing_flow_run[dask_task_runner_with_thread_pool]"
../../../mambaforge/envs/prefect-dask/lib/python3.9/site-packages/alembic/util/langhelpers.py:68: KeyError
---------------------------------------------------------------------------------------------------------------------------- Captured log call ----------------------------------------------------------------------------------------------------------------------------
INFO     prefect.engine:engine.py:227 Created flow run 'rebel-lyrebird' for flow 'test-flow'
INFO     prefect.task_runner.dask:task_runners.py:290 Creating a new Dask cluster with `distributed.deploy.local.LocalCluster`
INFO     prefect.task_runner.dask:task_runners.py:307 The Dask dashboard is available at http://<IP_ADDRESS>:8787/status
INFO     prefect.flow_runs:engine.py:1080 Created task run 'task_b-8e3be95f-0' for task 'task_b'
INFO     prefect.flow_runs:engine.py:1116 Submitted task run 'task_b-8e3be95f-0' for execution.
INFO     prefect.flow_runs:engine.py:1080 Created task run 'task_a-4179b103-0' for task 'task_a'
INFO     prefect.flow_runs:engine.py:1116 Submitted task run 'task_a-4179b103-0' for execution.
INFO     prefect.flow_runs:engine.py:1080 Created task run 'task_c-167cbbb3-0' for task 'task_c'
INFO     prefect.flow_runs:engine.py:1116 Submitted task run 'task_c-167cbbb3-0' for execution.
INFO     prefect.flow_runs:engine.py:1080 Created task run 'task_c-167cbbb3-1' for task 'task_c'
INFO     prefect.flow_runs:engine.py:1116 Submitted task run 'task_c-167cbbb3-1' for execution.
ERROR    prefect.task_runs:engine.py:1357 Encountered exception during execution:
Traceback (most recent call last):
  File "/Users/andrew/Applications/python/prefect/src/prefect/engine.py", line 1340, in orchestrate_task_run
    result = await run_sync(task.fn, *args, **kwargs)
  File "/Users/andrew/Applications/python/prefect/src/prefect/utilities/asyncutils.py", line 69, in run_sync_in_worker_thread
    return await anyio.to_thread.run_sync(call, cancellable=True)
  File "/Users/andrew/mambaforge/envs/prefect-dask/lib/python3.9/site-packages/anyio/to_thread.py", line 31, in run_sync
    return await get_asynclib().run_sync_in_worker_thread(
  File "/Users/andrew/mambaforge/envs/prefect-dask/lib/python3.9/site-packages/anyio/_backends/_asyncio.py", line 937, in run_sync_in_worker_thread
    return await future
  File "/Users/andrew/mambaforge/envs/prefect-dask/lib/python3.9/site-packages/anyio/_backends/_asyncio.py", line 867, in run
    result = context.run(func, *args)
  File "/Users/andrew/Applications/python/prefect/src/prefect/testing/standard_test_suites/task_runners.py", line 80, in task_b
    raise ValueError("This task fails and passes data downstream!")
ValueError: This task fails and passes data downstream!
ERROR    prefect.task_runs:engine.py:1398 Finished in state Failed('Task run encountered an exception: ValueError: This task fails and passes data downstream!\n')
INFO     prefect.task_runs:engine.py:1426 Crash detected! Execution was interrupted by an unexpected exception: KeyError: 'script'

ERROR    prefect.flow_runs:engine.py:384 Finished in state Failed('2/4 states failed.')
========================================================================================================================= short test summary info =========================================================================================================================
FAILED tests/test_task_runners.py::TestDaskTaskRunner::test_failing_flow_run[dask_task_runner_with_thread_pool] - KeyError: 'script'

alembic has to something to do with database so I remove ~/.prefect/orion.db, but still got the same error; then I realized conftest uses prefect_test_harness, so I commented it out:
# @pytest.fixture(scope="session", autouse=True)
# def prefect_db():
#     """
#     Sets up test harness for temporary DB during test runs.
#     """
#     with prefect_test_harness():
#         yield

And that test passes
========================================================================================================================= test session starts ===========================================================================================================================
platform darwin -- Python 3.9.13, pytest-7.1.3, pluggy-1.0.0 -- /Users/andrew/mambaforge/envs/prefect-dask/bin/python3.9
cachedir: .pytest_cache
rootdir: /Users/andrew/Applications/python/prefect-dask, configfile: setup.cfg
plugins: anyio-3.6.1, flaky-3.7.0, asyncio-0.19.0, timeout-2.1.0, respx-0.20.0
asyncio: mode=auto
collected 117 items / 116 deselected / 1 selected

tests/test_task_runners.py::TestDaskTaskRunner::test_failing_flow_run[dask_task_runner_with_thread_pool] <- ../prefect/src/prefect/testing/standard_test_suites/task_runners.py 12:10:14.804 | INFO    | prefect.engine - Created flow run 'sage-waxbill' for flow 'test-flow'
12:10:14.807 | INFO    | prefect.task_runner.dask - Creating a new Dask cluster with `distributed.deploy.local.LocalCluster`
12:10:15.205 | INFO    | prefect.task_runner.dask - The Dask dashboard is available at http://<IP_ADDRESS>:8787/status
12:10:16.323 | INFO    | Flow run 'sage-waxbill' - Created task run 'task_b-8e3be95f-0' for task 'task_b'
12:10:16.693 | INFO    | Flow run 'sage-waxbill' - Submitted task run 'task_b-8e3be95f-0' for execution.
12:10:16.697 | INFO    | Flow run 'sage-waxbill' - Created task run 'task_a-4179b103-0' for task 'task_a'
12:10:16.699 | INFO    | Flow run 'sage-waxbill' - Submitted task run 'task_a-4179b103-0' for execution.
12:10:16.867 | INFO    | Flow run 'sage-waxbill' - Created task run 'task_c-167cbbb3-0' for task 'task_c'
12:10:16.871 | INFO    | Flow run 'sage-waxbill' - Submitted task run 'task_c-167cbbb3-0' for execution.
12:10:17.002 | INFO    | Flow run 'sage-waxbill' - Created task run 'task_c-167cbbb3-1' for task 'task_c'
12:10:17.007 | INFO    | Flow run 'sage-waxbill' - Submitted task run 'task_c-167cbbb3-1' for execution.
12:10:17.099 | ERROR   | Task run 'task_a-4179b103-0' - Encountered exception during execution:
Traceback (most recent call last):
  File "/Users/andrew/Applications/python/prefect/src/prefect/engine.py", line 1340, in orchestrate_task_run
    result = await run_sync(task.fn, *args, **kwargs)
  File "/Users/andrew/Applications/python/prefect/src/prefect/utilities/asyncutils.py", line 69, in run_sync_in_worker_thread
    return await anyio.to_thread.run_sync(call, cancellable=True)
  File "/Users/andrew/mambaforge/envs/prefect-dask/lib/python3.9/site-packages/anyio/to_thread.py", line 31, in run_sync
    return await get_asynclib().run_sync_in_worker_thread(
  File "/Users/andrew/mambaforge/envs/prefect-dask/lib/python3.9/site-packages/anyio/_backends/_asyncio.py", line 937, in run_sync_in_worker_thread
    return await future
  File "/Users/andrew/mambaforge/envs/prefect-dask/lib/python3.9/site-packages/anyio/_backends/_asyncio.py", line 867, in run
    result = context.run(func, *args)
  File "/Users/andrew/Applications/python/prefect/src/prefect/testing/standard_test_suites/task_runners.py", line 76, in task_a
    raise RuntimeError("This task fails!")
RuntimeError: This task fails!
12:10:17.128 | ERROR   | Task run 'task_b-8e3be95f-0' - Encountered exception during execution:
Traceback (most recent call last):
  File "/Users/andrew/Applications/python/prefect/src/prefect/engine.py", line 1340, in orchestrate_task_run
    result = await run_sync(task.fn, *args, **kwargs)
  File "/Users/andrew/Applications/python/prefect/src/prefect/utilities/asyncutils.py", line 69, in run_sync_in_worker_thread
    return await anyio.to_thread.run_sync(call, cancellable=True)
  File "/Users/andrew/mambaforge/envs/prefect-dask/lib/python3.9/site-packages/anyio/to_thread.py", line 31, in run_sync
    return await get_asynclib().run_sync_in_worker_thread(
  File "/Users/andrew/mambaforge/envs/prefect-dask/lib/python3.9/site-packages/anyio/_backends/_asyncio.py", line 937, in run_sync_in_worker_thread
    return await future
  File "/Users/andrew/mambaforge/envs/prefect-dask/lib/python3.9/site-packages/anyio/_backends/_asyncio.py", line 867, in run
    result = context.run(func, *args)
  File "/Users/andrew/Applications/python/prefect/src/prefect/testing/standard_test_suites/task_runners.py", line 80, in task_b
    raise ValueError("This task fails and passes data downstream!")
ValueError: This task fails and passes data downstream!
12:10:17.232 | ERROR   | Task run 'task_a-4179b103-0' - Finished in state Failed('Task run encountered an exception: RuntimeError: This task fails!\n')
12:10:17.256 | ERROR   | Task run 'task_b-8e3be95f-0' - Finished in state Failed('Task run encountered an exception: ValueError: This task fails and passes data downstream!\n')
12:10:18.768 | ERROR   | Flow run 'sage-waxbill' - Finished in state Failed('2/4 states failed.')
PASSED

==================================================================================================================== 1 passed, 116 deselected in 4.76s ==================================================================================================================

Fixed via https://github.com/PrefectHQ/prefect/pull/7789


How to instruction fine tune it on a custom dataset ?

Is it possible to instruction fine tune it on my custom dataset and how to do it  with my json file ?
data_final10.json

Hi
Thanks for your interest. I think it is possible; you can check the dataset part and the dataload code to find out the dataset structure.


Upgrade dependencies

Fixes #5
With these changes:
~/dev/github.com/drtoful/certinel(master)*
$ govulncheck .
Scanning your code and 195 packages across 16 dependent modules for known vulnerabilities...

No vulnerabilities found.

Share feedback at https://go.dev/s/govulncheck-feedback.

Can this be merged?


typo in readme

just need to be corrected
ImagePickerCompomnentHolder.getInstance()
on the start project page. Thanks for library!

Thanks @djdance 💪👌


strange core dumped problem

Code:
def test2():
    data_in = mx.symbol.Variable('data')
    conv = mx.symbol.Convolution(data=data_in, kernel=(3, 3), num_filter=16)
    datatmp = np.ones((1, 1, 32, 64))
    mxdata = mx.nd.array(datatmp)
    weightmp = np.ones((16, 1, 3, 3))
    mxweight = mx.nd.array(weightmp)
    biastmp = np.zeros(16)
    mxbias = mx.nd.array(biastmp)
    exe_c = conv.bind(ctx=mx.cpu(), args=[mxdata, mxweight, mxbias])
    out = exe_c.forward()

test2()

Error result:
terminate called after throwing an instance of 'std::system_error'
  what():  Operation not permitted
Aborted (core dumped)

I'm not quite sure how the environment is set up. It's possible you are not linked against pthread. Make sure you have -pthreads in the compile options.

It is not possible, I compiled the mxnet without changing anything.Just used default setting.

I ran into the same problem with slightly different code:
import mxnet as mx

x = mx.sym.Variable("x")
y = mx.sym.sqrt(x)

with mx.cpu(0) as ctx:
    executor = y.simple_bind(ctx, x=(1,))
    executor.arg_arrays[0][:] = 4
    executor.forward()
    out_var = executor.outputs[0]
    print out_var
    print out_var.asnumpy()

    mx.ndarray.waitall()
    print "done"

It appears to be a race condition when the python program exits. It only happens half the time and can be fixed with a breakpoint  and then manually continuing just before exit. The result is always printed even on crash.

hmm, can you try to get some stack trace on such error, so we can have a general idea on where things went wrong, thanks!

I tried, was hoping to be a little more useful. Do you know how?
I tried compiling with -rdynamic, DEBUG=1.
When running under GDB everything seems to just work. I will play around some more and see if I can get one.

I was thinking about gdb, don't have brilliant idea on this:( thanks for investigating and please let us know if you have more fundings

So this appears to be a bug with openblas as when compiling with normal blas the error does not occur. Also, the following code is a minimal example to reproduce the bug. Still no stack trace.
import mxnet as mx

The original post mentioned that there is a core dumped. If you actually get a core file dumped, you can load the core file into GDB, and get some stack trace. Although when the libraries are not compiled with -g, the stack trace might be hard to decrypt (e.g. fully of ??? or might be even misleading).

Didn't know you could do that.
I set ulimit -c unlimited to get a core file to show up,
then gdb that file. all ??? on backtrace, no symbols despite mxnet with -g. I checked each of the 4 available frames and none had symbols.
I think its in the ThreadEnginePerDevice dealloc method.
I annotated the code with the following:
    printf("A\n");
    gpu_normal_workers_.Clear();
    printf("B\n");
    gpu_copy_workers_.Clear();
    printf("C\n");
    cpu_normal_workers_.Clear();
    printf("D\n");
    cpu_priority_worker_.reset(nullptr);
    printf("Dealloc threadedEgninginePer\n");

With a result of
$ MXNET_ENGINE_TYPE=ThreadedEnginePerDevice python test.py
[16:02:50] src/engine/engine.cc:36: MXNet start using engine: ThreadedEnginePerDevice
A
B
C
D
terminate called after throwing an instance of 'std::system_error'
  what():  Operation not permitted
Aborted (core dumped)

I am kinda a noob when it comes to debugging this stuff, but I will update if I can get something working. Thanks for the help!

just for the record, I also noticed some crashing from Julia side recently. Basically, if I only load libmxnet but does not do any computation with it. Something like
using MXNet

for i = 1:5
  println(i)
end

then it will crash:
1
2
3
4
5
fish: 'julia foo.jl' terminated by signal SIGSEGV (Address boundary error)

But it will not crash if I actually did some computation (e.g. train a neural network) with MXNet. I have not been able to spend time to debug this yet.

Here is a backtrace with source "import mxnet":
# gdb python core
GNU gdb (Ubuntu 7.7.1-0ubuntu5~14.04.2) 7.7.1
Copyright (C) 2014 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.  Type "show copying"
and "show warranty" for details.
This GDB was configured as "x86_64-linux-gnu".
Type "show configuration" for configuration details.
For bug reporting instructions, please see:
<http://www.gnu.org/software/gdb/bugs/>.
Find the GDB manual and other documentation resources online at:
<http://www.gnu.org/software/gdb/documentation/>.
For help, type "help".
Type "apropos word" to search for commands related to "word"...
Reading symbols from python...(no debugging symbols found)...done.

warning: core file may not match specified executable file.
[New LWP 2344]
[New LWP 2338]
[New LWP 2340]
[New LWP 2339]
[New LWP 2341]
[New LWP 2342]
[New LWP 2337]
[New LWP 2345]
[New LWP 2343]
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
Core was generated by `python perceptron.py'.
Program terminated with signal SIGABRT, Aborted.
#0  0x00007fd976499cc9 in __GI_raise (sig=sig@entry=6) at ../nptl/sysdeps/unix/sysv/linux/raise.c:56
56	../nptl/sysdeps/unix/sysv/linux/raise.c: No such file or directory.
Traceback (most recent call last):
  File "/usr/share/gdb/auto-load/usr/lib/x86_64-linux-gnu/libstdc++.so.6.0.19-gdb.py", line 63, in <module>
    from libstdcxx.v6.printers import register_libstdcxx_printers
ImportError: No module named 'libstdcxx'
(gdb) info threads
  Id   Target Id         Frame
  9    Thread 0x7fd94a629700 (LWP 2343) clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:81
  8    Thread 0x7fd949627700 (LWP 2345) __lll_lock_wait_private ()
    at ../nptl/sysdeps/unix/sysv/linux/x86_64/lowlevellock.S:95
  7    Thread 0x7fd976c3e740 (LWP 2337) 0x00007fd97683166b in pthread_join (threadid=140571240998656,
    thread_return=0x0) at pthread_join.c:92
  6    Thread 0x7fd94ae2a700 (LWP 2342) clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:81
  5    Thread 0x7fd94cdce700 (LWP 2341) 0x00007fd97655012d in poll () at ../sysdeps/unix/syscall-template.S:81
  4    Thread 0x7fd97066c700 (LWP 2339) 0x00007fd97652e3f7 in sched_yield ()
    at ../sysdeps/unix/syscall-template.S:81
  3    Thread 0x7fd96fe6b700 (LWP 2340) 0x00007fd97652e3f7 in sched_yield ()
    at ../sysdeps/unix/syscall-template.S:81
  2    Thread 0x7fd970e6d700 (LWP 2338) 0x00007fd97652e3f7 in sched_yield ()
    at ../sysdeps/unix/syscall-template.S:81
* 1    Thread 0x7fd949e28700 (LWP 2344) 0x00007fd976499cc9 in __GI_raise (sig=sig@entry=6)
    at ../nptl/sysdeps/unix/sysv/linux/raise.c:56
(gdb) bt
#0  0x00007fd976499cc9 in __GI_raise (sig=sig@entry=6) at ../nptl/sysdeps/unix/sysv/linux/raise.c:56
#1  0x00007fd97649d0d8 in __GI_abort () at abort.c:89
#2  0x00007fd95f179535 in __gnu_cxx::__verbose_terminate_handler() () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#3  0x00007fd95f1776d6 in ?? () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#4  0x00007fd95f177703 in std::terminate() () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#5  0x00007fd95f1caad5 in ?? () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#6  0x00007fd976830182 in start_thread (arg=0x7fd949e28700) at pthread_create.c:312
#7  0x00007fd97655d47d in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:111
(gdb)

@korneil It seems to be an import error. Can you confirm that this error occur only when you have a script file containing nothing but
import mxnet

and yet you can run the built-in examples without problem (e.g. mnist/mlp.py)?

closing due to inactive status, feel free to reopen if there is update


DueTimer Library v2.0

Here is the place to discuss the enchancements of the library for the v2.0
Key things that will be created/changed:

[ ] Create Base Interface
[ ] Support for PWM
[ ] Support for Servo
[ ] Support for CounterTimer
[ ] Use of Arduino 1.5.x Library specification
Creation of Github Pages with extended documentation

Hi Ivan
Nice library. But I ran into problem with my Due. I need a timer of about 2000Hz (e.g.yours) and various external button controlled interrupts. If I attach the external interrupts the timer does not work any more but only gives one shot of one of the external interrupts. Is there a way for example to use " attachInterrupt(Button_51, btn51Interrupt, RISING);  " and " Timer.getAvailable().attachInterrupt(myHandler).setFrequency(2000).start(); " together?

hello @Oegtsgeest,
This seems like an interruption priority problem. When you say "only gives one shot", means that the your interruption is not being called again, or, that your cold hangs up?

Thx for yr quick reply. Yes indeed it had to to with priorities. Thanks to your lead i solved the issue.

Hi , can  you help me with a  simple   sketch  for  the library. I  intoduced  it in  my  code and it has display poblem. Thanks

Hi. I have  fixed  the  problem.  Thanks

Hi Ivan. I am using your Timer library for the Due. But when I have a complex code running within the Timer Interrupt Service Routine and I try print data serially I do not get it printed when I use the Serial.print within the ISR. But when I print the data in the loop function I get data but still all the processes are running within the Timer's ISR. Do you understand why I am facing this ?? Please suggest


Killer Joe drop my sword

I'm having poblem with "Killer Joe", it kills some mobs and drop a sword on the ground

EnderIO:EnderIO-1.7.10-<IP_ADDRESS>9_beta
EnderCore:EnderCore-1.7.10-<IP_ADDRESS>_beta
Minecraft:1.7.10
Forge:Forge <IP_ADDRESS>6-1.7.10
Optifine:OptiFine_1.7.10_HD_U_E7

What happend?

Our last 1.7.10 release was 4 years ago...
However, the Killer Joe doesn't (and never has) had code to drop anything to the ground. So some other mod is removing the sword.

Ok, Thanks.


made the contact form responsive  issue #120

Description
i made the contact us page responsive for small screens
Related Issue
Fixes # 120

image2:

Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented on my code, particularly in hard-to-understand areas
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

please merge this PR @subhadipbhowmik  also please dont forget to add level and gssoc-ext label before merge.

Not needed right now

Not needed right now

then why did you assigned me ???


Unusual index error in cryoCARE_extract_training_data.py

Hello,
Thanks for all the great work on cryoCARE. I have been getting the below error recently while preparing the data for denoising (ie. while running cryoCARE_extract_training_data.py).
Does anyone know a cause, or if there's something that maybe I should be doing differently?
Thanks!!
42%|████▏     | 12596/30000 [03:32<03:34, 80.99it/s]
42%|████▏     | 12607/30000 [03:32<03:27, 83.99it/s]
42%|████▏     | 12618/30000 [03:32<03:13, 89.96it/s]
42%|████▏     | 12634/30000 [03:32<02:48, 102.97it/s]
42%|████▏     | 12646/30000 [03:32<02:42, 106.61it/s]
42%|████▏     | 12657/30000 [03:32<02:52, 100.46it/s]
42%|████▏     | 12668/30000 [03:32<02:57, 97.81it/s]
42%|████▏     | 12678/30000 [03:32<03:05, 93.48it/s]
42%|████▏     | 12688/30000 [03:33<03:18, 87.04it/s]
42%|████▏     | 12699/30000 [03:33<03:07, 92.35it/s]
42%|████▏     | 12709/30000 [03:33<03:23, 84.92it/s]
42%|████▏     | 12720/30000 [03:33<03:19, 86.79it/s]
42%|████▏     | 12733/30000 [03:33<02:57, 97.12it/s]
42%|████▏     | 12743/30000 [03:33<03:13, 89.39it/s]
42%|████▎     | 12750/30000 [03:33<04:49, 59.64it/s]
Traceback (most recent call last):
File "/g/easybuild/x86_64/Rocky/8/rome/software/cryoCARE/0.2.1-foss-2021a-CUDA-11.3.1/bin/cryoCARE_extract_train_data.py", line 45, in
main()
File "/g/easybuild/x86_64/Rocky/8/rome/software/cryoCARE/0.2.1-foss-2021a-CUDA-11.3.1/bin/cryoCARE_extract_train_data.py", line 27, in main
dm.setup(config['odd'], config['even'], n_samples_per_tomo=config['num_slices'],
File "/g/easybuild/x86_64/Rocky/8/rome/software/cryoCARE/0.2.1-foss-2021a-CUDA-11.3.1/lib/python3.9/site-packages/cryocare/internals/CryoCAREDataModule.py", line 200, in setup
self.train_dataset = CryoCARE_Dataset(tomo_paths_odd=tomo_paths_odd,
File "/g/easybuild/x86_64/Rocky/8/rome/software/cryoCARE/0.2.1-foss-2021a-CUDA-11.3.1/lib/python3.9/site-packages/cryocare/internals/CryoCAREDataModule.py", line 49, in init
self.compute_mean_std(n_samples=n_normalization_samples)
File "/g/easybuild/x86_64/Rocky/8/rome/software/cryoCARE/0.2.1-foss-2021a-CUDA-11.3.1/lib/python3.9/site-packages/cryocare/internals/CryoCAREDataModule.py", line 97, in compute_mean_std
x, _ = self.getitem(i)
File "/g/easybuild/x86_64/Rocky/8/rome/software/cryoCARE/0.2.1-foss-2021a-CUDA-11.3.1/lib/python3.9/site-packages/cryocare/internals/CryoCAREDataModule.py", line 158, in getitem
z, y, x = self.coords[tomo_index][coord_index]
IndexError: index 5 is out of bounds for axis 0 with size 5

Hi,
I was about to start a thread about this same error.
I think the values for 'num_slices' and 'n_normalization_samples' aren't independent. When the program is trying to pick normalization samples, it looks as though it picks a subset of slices from a previously generated pool of slices, or something like that. So when n_normalization_samples is larger than num_slices, it is trying to grab an element that is not in that pool and you end up with that error.
Setting n_normalization_samples to a value lower than num_slices seems to be a workaround.


demo: large federation setups

https://github.com/fedimint/fedimint/issues/5784
While setting up an 11 member federation we had issues, but a 10 member federation succeeded.
Reproducing different setups in CI.

@bradleystachurski Closing as an old draft that looks like for testing purposes.


error when running performance script

script https://github.com/zero-os/0-orchestrator/tree/master/tests/performance
INFO:[secure]:Creating new container...
 You can follow here: http://<IP_ADDRESS>:8080/nodes/0cc47a740632/containers/bptest_15011391165513997
INFO:[secure]:Cleaning up...
Traceback (most recent call last):
  File "/tmp/performance_test/0-orchestrator/tests/performance/bd-performance.py", line 56, in test_fio_nbd
    mountVdisks(api, deployInfo, nodeIDs)
  File "/tmp/performance_test/0-orchestrator/tests/performance/bd-performance.py", line 109, in mountVdisks
    deployInfo[nodeID]["nbdClientInfo"] = nbdClientConnect(api, nodeID, containername, nbdConfig)
  File "/tmp/performance_test/0-orchestrator/tests/performance/bd-performance.py", line 353, in nbdClientConnect
    waitProcess(api, nbdClientCommand, jobid, nodeID, containername)
  File "/tmp/performance_test/0-orchestrator/tests/performance/bd-performance.py", line 334, in waitProcess
    raise RuntimeError("Command %s failed to execute successfully. %s" % (command, res["stderr"]))
RuntimeError: Command {'name': '/bin/nbd-client', 'pwd': '', 'args': ['-N', 'testvdisk_15011390663503697', '-u', '/fs/0cc47a740636_fscache/fs_15011390503782008/server.socket.nbd_1501139058545642', '/dev/nbd0', '-b', '4096']} failed to execute successfully. Error: Cannot open NBD: No such file or directory
Please ensure the 'nbd' module is loaded.
Exiting.
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
  File "/tmp/performance_test/0-orchestrator/tests/performance/bd-performance.py", line 71, in test_fio_nbd
    raise RuntimeError(e)
RuntimeError: Command {'name': '/bin/nbd-client', 'pwd': '', 'args': ['-N', 'testvdisk_15011390663503697', '-u', '/fs/0cc47a740636_fscache/fs_15011390503782008/server.socket.nbd_1501139058545642', '/dev/nbd0', '-b', '4096']} failed to execute successfully. Error: Cannot open NBD: No such file or directory
Please ensure the 'nbd' module is loaded.
Exiting.
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
  File "/tmp/performance_test/0-orchestrator/tests/performance/bd-performance.py", line 378, in <module>
    test_fio_nbd()
  File "/usr/local/lib/python3.5/dist-packages/click/core.py", line 716, in __call__
    return self.main(*args, **kwargs)
  File "/usr/local/lib/python3.5/dist-packages/click/core.py", line 696, in main
    rv = self.invoke(ctx)
  File "/usr/local/lib/python3.5/dist-packages/click/core.py", line 889, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/usr/local/lib/python3.5/dist-packages/click/core.py", line 534, in invoke
    return callback(*args, **kwargs)
  File "/tmp/performance_test/0-orchestrator/tests/performance/bd-performance.py", line 73, in test_fio_nbd
    cleanUp(api, nodeIDs, deployInfo)
  File "/tmp/performance_test/0-orchestrator/tests/performance/bd-performance.py", line 149, in cleanUp
    filenames = deployInfo[nodeID]["filenames"]
KeyError: 'filenames'

Software Version
4fff9271b5d6edd62023c004717dc595d9f14a20


try eslint-plugin-ie11

eslint-plugin-ie11 should help us cover those few things that ESLint doesn't do out-of-the-box.
If proven useful, it should be used in all code which isn't specifically found in the whitelist of files supporting ES6.

This would be beneficial. We should run tests on it.

Outdated, we transpile our browser bundle to ES5. Has been working perfectly for more than a year now.


Loading jpg files results in corrupted export, but only when the ext is in lowercase

I think my configuration is quite minimal with only ts-loader and file-loader for files.
Example:
const CUTE_AVATAR = require('path/to/image.jpg');

results in corrupted file, but
const CUTE_AVATAR = require('path/to/image.JPG');

does not. Both point to the same image, image's original extension is in lowercase (maybe doesn't matter since OS X).
It also results in different [sha512:hash:base64:7] between the lowercase and the uppercase one.
png files are not affected. Only jpg.
Loaders config below if needed.
loaders: [
            {
                test: /\.tsx?$/,
                loader: 'ts-loader'
            },
            {
                test: /\.(jpg|png)$/i,
                loader: 'file?name=[sha512:hash:base64:7].[ext]'
            }
        ]

Any ideas? Thanks.

I ran in to a similar problem and it turned out it that I was using the babel loader which was already doing image loading, so I didn't need to include a file-loader for my images.

@kairxa Is the problem still there? If yes , can your provide minimum reproducible test repo?

Closing due to inactivity. Please test with latest version and feel free to reopen if still regressions. Thanks!


"[パブリック | 秘密][静的]" needs to be replaced with "[ Public | Private ] [ Static ]"

https://docs.microsoft.com/ja-jp/office/vba/language/concepts/getting-started/writing-a-property-procedure

Working on a fix (Bug 3272654)

Over-localized text fixed


Wondering if these named read macros can be shadowed  by local variables with the same name.

Typically with a classical macro these locals will be figured out at compile-time, and if one happens to be the head of s-expr, it will not get macro-expanded, but called as a function at runtime.
Discussion: https://www.reddit.com/r/lisp/comments/d6evj6/is_there_a_lisp_that_accepts_sexprs_as_reader/

Short answer is no, the read macro will get used instead.
The relevant code is in read-maybe-read-macro, where we hijack the reader for #'( and check if the head symbol has an attached read macro; if it does, we expand, if not, we just leave it as is.


Update slinky-hot, slinky-web to 0.7.2

Updates

me.shadaj:slinky-hot
me.shadaj:slinky-web

from 0.6.8 to 0.7.2.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "me.shadaj" } ]

labels: library-update, early-semver-major, semver-spec-minor, commit-count:1

Superseded by #208.


fixes Random -> ThreadLocalRandom.

fixes Random -> ThreadLocalRandom.

Pull Request Test Coverage Report for Build 800

2 of 3 (66.67%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 68.525%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/rule/ShardingDataSourceNames.java
0
1
0.0%

Totals

Change from base Build 535:
0.0%

Covered Lines:
11493

Relevant Lines:
16772

💛  - Coveralls


Add Skip TLS verification option

For MITM HTTP proxies that re-encrypt requests with a custom CA cert in customer environments, this is helpful.
Related to https://github.com/pivotal-cf/go-pivnet/pull/16

we have removed the develop branch

the change to file "vendor/github.com/pivotal-cf/go-pivnet/pivnet.go" is a vendor file that exists at https://github.com/pivotal-cf/go-pivnet and cannot be changed here.
we do have this requested functionality in in our [pivnet-resource(https://github.com/pivotal-cf/pivnet-resource/blob/3e0df1180e61cdc4b3af5da6500f95c5a85a76ab/concourse/types.go#L21) and therefore it makes sense to support this in our CLI as well.

I will create an internal ticket request to add this functionality.
I will close this issue PR as reject as I cannot merge it in it's current state.


Adding Spring Boot enhancements, Sring Data Repository, Testcontainers

Description
This PR adds support for:

Spring Boot Starters
Spring Data Repository
Spring Boot Testcontainers

Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1088
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:

[x] Code compiles correctly
[x] Created/updated tests
[ ] Extended the documentation

This depends on this: https://github.com/dapr/java-sdk/pull/1085 so please help us to merge that one first

@cicoyle @artursouza this test here: https://github.com/dapr/java-sdk/actions/runs/10578048505/job/29307323653?pr=1089
is failing with this error:
MethodInvokeIT.testInvokeTimeout:95 The message contains DEADLINE_EXCEEDED: DEADLINE_EXCEEDED: context deadline exceeded

But the assertion is done on contains "CallOptions deadline exceeded after" , which in my opinion is causing the flakiness as Daprd (the runtime) is not consistently returning the same error.
@cicoyle maybe you can help me to investigate what is the difference between "context deadline exceeded" and "CallOptions deadline exceeded after"
https://github.com/dapr/java-sdk/blob/master/sdk-tests/src/test/java/io/dapr/it/methodinvoke/grpc/MethodInvokeIT.java#L95

@cicoyle @artursouza this test here: https://github.com/dapr/java-sdk/actions/runs/10578048505/job/29307323653?pr=1089 is failing with this error:
MethodInvokeIT.testInvokeTimeout:95 The message contains DEADLINE_EXCEEDED: DEADLINE_EXCEEDED: context deadline exceeded

But the assertion is done on contains "CallOptions deadline exceeded after" , which in my opinion is causing the flakiness as Daprd (the runtime) is not consistently returning the same error.
@cicoyle maybe you can help me to investigate what is the difference between "context deadline exceeded" and "CallOptions deadline exceeded after"
https://github.com/dapr/java-sdk/blob/master/sdk-tests/src/test/java/io/dapr/it/methodinvoke/grpc/MethodInvokeIT.java#L95
In my experience so far, this test is returning "CallOptions deadline exceeded after" one every 5 attempts.

@salaboy, unless @artursouza and @cicoyle have a different opinion, I think asserting the code of StattusRuntimeException being equal to enum value DEADLINE_EXCEEDED(4) is more than enough.
I have adjusted the test, please take a look and let me know your thoughts.

@artursouza and @cicoyle the build is 🟢. I will need your help with License Compliance, I don't think we use anything "dangerous", but we might need your approval.
Thank you!

@artursouza and @cicoyle the build is 🟢. I will need your help with License Compliance, I don't think we use anything "dangerous", but we might need your approval.
Thank you!

The violation is coming from MySQL Connector/J 8.2.0 Community for using GPL 2.0.
Is there an alternative we can use?

@artursouza and @cicoyle the build is 🟢. I will need your help with License Compliance, I don't think we use anything "dangerous", but we might need your approval.
Thank you!

The violation is coming from MySQL Connector/J 8.2.0 Community for using GPL 2.0.
Is there an alternative we can use?

I have created a CustomMySQLContainer implementation with a log based wait strategy and MySQL Connector J is  no longer required.

@artursouza and @salaboy you can check the SpotBugs failures here: https://github.com/dapr/java-sdk/actions/runs/10601809365/job/29382433463?pr=1089#step:16:3094. This is after I have removed SpotBugs exclude from dapr-spring module.
I don't think having those two exclusion rules for SpotBugs will lead to issues. As I already mentioned most of the classes that we inject via dependency injections are Spring Beans and there is nothing we can do about it.

Pretty close. Have a few comments. Thanks a lot for your contribution.

@artursouza thanks a lot for your review. I have addressed or answered all your comments. I have provided an example regarding SpotBugs failures.
If everything looks good, could you please approve and merge. Thank you.

@artursouza @salaboy @cicoyle the build is 🟢 I have addressed all the comments. Whenever you have a chance could you please take a look.
Thank you 🙇

@artursouza I have addressed  all the review comments. The build is 🟢. I am not sure what's wrong with FOSSA. Could you please take another look and approve it.
Thank you 🙇 !


fix(extensions.json): fix error: johnsoncodehk.volar not found in mar…

fix error: johnsoncodehk.volar not found in marketplace
The error message will pop-up when we open project in vs code. Due to plugin changed its name.


Support for $MISE_ENV in config file

Hi Jeff. I have been using Mise and could not be happier. I have been pondering over an idea. Often, I find myself writing simple programs where the config file does not exceed a few lines.
$ cat .mise.toml
[tools]
go = "prefix:1.22"

$ cat .mise.production.toml
[tools]
go = "prefix:1.17"

Would not it be great if we could consolidate everything into a single file?
# [tools:{MISE_ENV}]

[tools]
go = "prefix:1.22"

[tools:production]
go = "prefix:1.17"

... or:
# [{MISE_ENV}.tools]

[tools]
go = "prefix:1.22"

[production.tools]
go = "prefix:1.17"

Personally, I prefer the first.
I think this aligns perfectly with the Mise philosophy. This tool was crafted to combine all vendor-specific dotfiles into a single entity. Similarly, we can apply this concept to define different environments.

Sorry but I don't see much value here over having separate files. The syntax that you've proposed would complicate the docs, schema, and parsing significantly so there is a real cost to adding something like this. I'll leave it open, but right now I'm not convinced this is a good idea.


⚠ Spryr has degraded performance

In d05534a, Spryr (https://spryr.com) experienced degraded performance:

HTTP code: 200
Response time: 3835 ms

Resolved: Spryr performance has improved in a208e72 after 12 minutes.


Update sprints page

Tiny improvements.
The page also says that registration will open “soon” for people who don't have a conference ticket but the linked page (/tickets) doesn't have information about that yet.

Now that you commented it, I see that “Organise EuroPython 2049” was a joke, but all the other times I read it it was confusing.
Other than that, what other changes am I making that remove jokes/easter eggs?

Other than that, what other changes am I making that remove jokes/easter eggs?

None! All looks good! And easier to understand :)


Alternative username

I know this is not so easy because of SASL/Dovecot, but is it possible to add alternative usernames that can be used instead the primary email for logging in / sending?

Not that I'm aware of right now.
Did you solve your issue?

No, I didn't but I don't need alternative usernames now.

You could achieve it with ldap, you can set a different username to the email address.
When using it without the ldap database it is fixed to the email address.
Agree to close it?

Yes.


lint gosec CI action not working properly, ignoring #nosec

Describe the Bug
It seems that gosec CI action is ignoring the #nosec at a very specific location
To Reproduce
https://github.com/zeta-chain/node/actions/runs/7878254401/job/21496089631?pr=1731
Expected Behavior
If a #nosec is specified, the next line should be ignored for gosec linting check
Screenshots
[/github/workspace/x/emissions/client/tests/suite.go:91] - G404 (CWE-338): Use of weak random number generator (math/rand instead of crypto/rand) (Confidence: MEDIUM, Severity: HIGH)
    90: 			// #nosec G404 randomness used for testing
  > 91: 			BallotStatus:         ballotStatus[rand.Intn(max-min)+min],
    92: 			BallotCreationHeight: 0,

Temporarily removing required status for gosec action, to unblock currently approved PRs.

Fixed the error, let's reopen if it happens again


OAPI : #[salvo(schema(name = XXX))]  expects an identifier instead of a "string" literal

Hello,
Describe the bug :
An error now occurs in new versions of Salvo with OpenAPI :
use salvo::oapi::ToSchema;
use serde::{Deserialize, Serialize};

#[derive(Serialize, Deserialize, Clone, Debug, ToSchema)]
#[salvo(schema(name = "City"))]  //<-- `error: expected identifier`
pub struct CityDTO {
    #[salvo(schema(rename = "id"))]
    pub id: String,
    #[salvo(schema(rename = "name"))]
    pub name: String,
}

gives this error :
error: expected identifier
but by using an identifier instead of a string, it works.
#[salvo(schema(name = City))]

Normally name must take a literal string as parameter instead of an identifier, otherwise it may be confused with variables in the code.
And the weirdest thing is that it works on some names and not others:

it works for LoginDTO but not for CityDTO !!
**Salvo version : **
salvo = { version = "0.68.5", features = ["oapi", "jwt-auth", "compression"] }
salvo-oapi = "0.68.5"

it works for LoginDTO but not for CityDTO !!

I don't think it's a bug, because in the first one you're using #[salvo(symbol(name = "LoginRequest"))] while in the second one using #[salvo(schema(name = "City"))]. There is a diffrence between symbol and schema.
Note
The #[salvo(symbol(name = "LoginRequest"))] will have no effect, because Salvo does not support it.

it works for LoginDTO but not for CityDTO !!

I don't think it's a bug, because in the first one you're using #[salvo(symbol(name = "LoginRequest"))] while in the second one using #[salvo(schema(name = "City"))]. There is a diffrence between symbol and schema.
Note
The #[salvo(symbol(name = "LoginRequest"))] will have no effect, because Salvo does not support it.

Thank you very much for your remarks,
Is it normal that #[salvo(schema(name = "City"))] no longer accepts literal strings?

Is it normal that #[salvo(schema(name = "City"))] no longer accepts literal strings?

It was with #[salvo(schema(symbol = "..."))] but not with name, as you can see here.
Ultimately, Salvo is not stable yet, so you should expect changes like this.

Should we close this issue? It's not a bug
cc: @rxdiscovery @chrislearn

Should we close this issue? It's not a bug
cc: @rxdiscovery @chrislearn

I think it should be kept open, “name” should take a literal string so as not to cause confusion with an already existing type/struct.

I think it should be kept open, “name” should take a literal string so as not to cause confusion with an already existing type/struct.

@chrislearn What do you think? will Salvo support this? if yes we should open this issue.
For me, I think we should not, I think using identifier only is better.

I think this decision can be left to the users, as they may have different usage preferences.


Consider switching to mkdocs

We should consider switching to MkDocs for a more modern setup.
 You can check it out here: https://github.com/fdiblen/mkdocs-pdf

Will this help with #338? I saw that readthedocs supports mkdocs and I know that it supports and previews for pull requests, so maybe we could use that if we cannot get it to work with github pages?


ENH: TabularMSA.repr/str

Contains the commits in #1201 and addresses final review comments. Fixes #1172. Fixes #1171.

:+1: