Plan infrastructure for parameter ID test

Ultimately, we would like to move away from the "atom type" (or "vdw type") focus of the initial test and do a slightly more general test before moving to "real" chemistry -- particularly, we'd like to look at whether we can reproduce the parameter types from the parm@frosst set for AlkEthOH. This would require us to discover patterns which would reproduce vdW types as in the current smarty, but also reproduce bond types, angle types, and torsion types. This would test that our decoration machinery is able to handle the additional complexity that comes with that.
We'll need to think through how we would re-work/re-configure things ultimately to allow that -- probably this would basically be a step towards generating the machinery we would need for parameterizing to actual data. In this test, the existing smarty would be the answer to just one part of the test.

This also means we should try as much as possible to avoid the idea of "atom types" except when scoring the results of smarty, both because it will make this test easier and because it will make it easier for us ultimately to abandon atom types completely. (Maybe this should be a separate issue?)

This also relates to something which came up in the overly-broad issue #3 :

We're slowly trying to move away from smarty being just atomtypes, as the chemical perception will eventually need to handle atoms, bonds, angles, and torsions. That means reference type will be a list of atom types and atoms should be general matches. For now the scoring will likely be the fraction of reference types matches since we're still comparing to current atom types.
I had originally intended to write a completely different piece of code to do that, since this code has no facility for sampling over parameters, and building this in would be difficult since this capability is not modular with the current design.

I think we ought to be separating the issue of "sampling over parameters" from "handling chemical perception generally", as we ought to be able to do more than just "atom types" with smarty.

Do you mean that you want to try to recover bond types in parm@frosst (e.g. HS-SH), or the bond energetics classes?
The recovery of bond, angle, and torsion types may not be meaningful because they are all based on atom types. We're trying to get away from atom types and instead discover different classes of bonds that may be divorced from atom types.
If we want to get away from atom types in a SMIRKS-based bond match, how do we test this on something that is not fundamentally atomtype based if we don't use the energetics to score?

Do you mean that you want to try to recover bond types in parm@frosst (e.g. HS-SH), or the bond energetics classes?

Well, you COULD call it bond, angle, and torsional types, but really we were talking about seeing whether we could reproduce his hand-, expert-generated parameter types from parm@frosst on AlkEthOH. Specifically, from https://github.com/open-forcefield-group/open-forcefield-data/blob/master/Model-Systems/SMIRFF_prototype/smarff_mockup1.Frosst_AlkEthOH we'd look at this type of thing:
[#6X4]-[#6X4]    parBond  (1.526, 310.0) parNum b001 {CT-CT from frcmod.Frosst_AlkEthOH}
[#6X4]-[#1]      parBond  (1.090, 340.0) parNum b002 {CT-H_ from frcmod.Frosst_AlkEthOH}
[#6X4]-[O&X2&H1] parBond  (1.410, 320.0) parNum b003 {CT-OH from frcmod.Frosst_AlkEthOH}
[#6X4]-[O&X2&H0] parBond  (1.370, 320.0) parNum b004 {CT-OS from frcmod.Frosst_AlkEthOH}
[#8X2]-[#1]      parBond  (0.960, 553.0) parNum b005 {OH-HO from frcmod.Frosst_AlkEthOH}

# angles
[a,A]-[#6X4]-[a,A]   parAng (109.50, 50.0) parNum a001 {consensus matches all X-Csp3-X}
[#1]-[#6X4]-[#1]     parAng (109.50, 35.0) parNum a002 {H1-CT-H1 from frcmod.Frosst_AlkEthOH}
[#6X4]-[#6X4]-[#6X4] parAng (109.50, 40.0) parNum a003 {CT-CT-CT from frcmod.Frosst_AlkEthOH}
[#8X2]-[#6X4]-[#8X2] parAng (109.50, 70.0) parNum a004 {O_-CT-O_ from frcmod.Frosst_AlkEthOH}
[#6X4]-[#8X2]-[#1]   parAng (108.50, 55.0) parNum a005 {CT-OH-HO from frcmod.Frosst_AlkEthOH}
[#6X4]-[#8X2]-[#6X4] parAng (109.50, 60.0) parNum a006 {CT-OS-CT from frcmod.Frosst_AlkEthOH}

# torsions
[a,A]-[#6X4]-[#6X4]-[a,A]   parTor ( (9, 1.40, 0.0, 3) ) parNum t0001 {X -CT-CT-X from frcmod.Frosst_AlkEthOH}
...

etc.
The test would be, can we generate SMARTS (SMIRKS) patterns that will color the same parameter numbers, i.e. a001, t001, etc. These wouldn't need to match the same patterns he hand generated, but would they recognize the same bonds, angles, torsions, etc.?
Basically, it's the same test as we're doing in Smarty, but (a) NOT using atom types, and (b) extended to handle bond, angle, and torsional types

The recovery of bond, angle, and torsion types may not be meaningful because they are all based on atom types. We're trying to get away from atom types and instead discover different classes of bonds that may be divorced from atom types.

Ahh, but that's actually one of the great things about this SPECIFIC test - he's already gone through by hand (on AlkEthOH) and divorced the parameters from the normal notion of atom types, i.e. there are fewer torsions in his mockup than there would be if we used normal atom types, etc.

If we want to get away from atom types in a SMIRKS-based bond match, how do we test this on something that is not fundamentally atomtype based if we don't use the energetics to score?

Hopefully the above clarifies.

OK. I was suspecting this was what you meant, but wanted to be sure. It's fundamentally still atomtype-based (since it is just a direct translation of atom types into SMIRKS), but your goal is to just see how easy these hand-coded SMIRKS strings can be recovered with a Monte Carlo scheme.
Any thoughts on how the Monte Carlo sampling should work? I haven't thought through this deeply for the bond, angle, and torsion types.

I think Chris has a pretty good idea how to do it, so I can pick his brain
more tomorrow. Is there anything specific you'd want to know?
Obviously being able to MC sample things more complicated than just vdW
types is going to be key when it comes to parameterizing to experimental
data, so we thought this would be a good thing to make sure we can do as
well.
On Mon, Jun 20, 2016 at 9:07 PM, John Chodera<EMAIL_ADDRESS>wrote:

OK. I was suspecting this was what you meant, but wanted to be sure. It's
fundamentally still atomtype-based (since it is just a direct translation
of atom types into SMIRKS), but your goal is to just see how easy these
hand-coded SMIRKS strings can be recovered with a Monte Carlo scheme.
Any thoughts on how the Monte Carlo sampling should work? I haven't
thought through this deeply for the bond, angle, and torsion types.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/open-forcefield-group/smarty/issues/14#issuecomment-227335564,
or mute the thread
https://github.com/notifications/unsubscribe/AGzUYR7u0XfriZAKsTJfpSKPQfjT-3g-ks5qN2NkgaJpZM4I6QSA
.

--
David Mobley
<EMAIL_ADDRESS>949-385-2436

We specifically need a move set for constructing child proposals for bonds, angles, and torsions.


Random Animation Preset[Question]

Is there the the way to make random slides animations?

Hello, I add shuffle mode in display mode.. When I tried to add it in OnTouch,
https://github.com/daimajia/AndroidImageSlider/blob/master/library/src/main/java/com/daimajia/slider/library/SliderLayout.java#L198
it cannot work smoothly. and I am sorry I cannot handle it for the moment.
You can go on working out more effectively solution.
Please pay attention to https://github.com/daimajia/AndroidImageSlider/blob/master/library/src/main/java/com/daimajia/slider/library/Tricks/ViewPagerEx.java#L1942
Best Regards,
Zhouqiang


Switch from GitHub Actions

They are bad. PRs don't work right, the pipeline is a mess because you need PATs everywhere.
Find a good free for open-source alternative and migrate to it.

@tomphp Any thoughts on services to try for this?

I had a look at

Travis (feels unmaintained)
Circle CI (no free Mac support)
Google Cloud Build (no Mac support)
Azure Pipelines (seems... Ok?)
CodeShip (I couldn't get the project setup on this)

Maybe I should see about cross compiling on Ubuntu for Mac, but then how do I package bottles?

I don't think I am going to fix this soon. I'll put it on ice for now.


Initial Commit for Documentation

Changed README file from using Markdown to Asciidoc syntax.. Divided in into separate files under doc directory and they are now referenced from README file...

@jdigger @sagarsane @jbornemann @jazeren1 : Due to security issues github does allow include directive to render content of the file, so that is rendered as link to the included file...
So I have made changes so table of content directly takes user to the document under docs directory.
Could you please review this..

@viveksachdeva hate to be a stickler, but it's a bit strange to have every paragraph organized into it's own document. Can't say it flows, or makes information easier to find. It's also formatted a bit strange - both the title, and link below the title are links; and arguably importance of information is out of order.
I'm all for making the documentation pretty, but wondering if we can to structure things a bit different. Maybe something like :
Front page :

Project purpose
Directory

Installing Grabbit:

Links to Releases
Version support

Using Grabbit:

General Layout
Running
Monitoring
Cleaning

Contributing:

Prereqs
Releasing

Library Attributions:
License:

Just as an example. This style of doc I think should make it easier to find a category, and snap to a topic.
Documentation on master has been updated since too, so may want to make sure things are updated.
Good work so far!

@jbornemann : Agreed that structure should be better.. I have updated this PR.
Changes made:

Removed autogenerated toc as include directive doesnt work and we ultimately had to specify link to the file under docs
Restructured some docs
Added deleteBeforeWrite documentation from master

@jbornemann , @jdigger : Ready for review

The "project purpose" is exactly the kind of thing that really should lead (in-line) in the README.

Under all the links in "Installing Grabbit", there are NO references to the installation files. We really should make it as clear as possible how to actually install the binaries. (Especially since we've seen repeatedly that otherwise most everyone assumes they have to build from source.)

The README's "Using Grabbit / Setup" implies that it will tell you how to set up using Grabbit. However it points to Prerequisites.adoc, which is about how to install protoc for development. That will be extremely confusing for people since protoc is not required in any way to actually use Grabbit.

The very first item under "Using Grabbit / Running" is "Building from Source", which have nothing to do with running Grabbit.
Anything having to do with building Grabbit (including installing protoc) should probably be moved under it's own top-level header of "Grabbit Development".

Let's rename the "Contributing" section to "Grabbit Development" per the prior comment.

There's a lot of changes I'd like to see to the content of the docs, but this is a great start. 😸

@jdigger : Made some changes to this..

"Using grabbit" is now user centric.
Grabbit development has all information regarding installing binaries and building from source

I am not sure if "building from source" can be clubbed with any other doc as it has only 2-3 lines.

Better.
Think about it from the perspective of someone coming to the project for the first time. What would you want to see?
"Hm, here's that Grabbit project I was told to check out. What exactly is it? Oh, that sounds useful. How do I install it? Is it a stand-alone program, or a package I install in one of my servers, or...? Where do I get the binaries, or do I need to build from source? Okay, I have it installed -- I think. How do I verify it's installed correctly since I had to put it in multiple places? How do I start a copy job? What about if I'm running Windows? It talks about configuration files, but how do I customize it for my environment? There's a lot of fields in that JSON file that doesn't seem like they're necessary; I wonder if they are and I just don't understand them, in which case I have no idea what I should set them to for my environment. ........"

Vivek, did my comment on the approach to take make sense? Obviously it doesn't all have to happen in this PR, but I would like to see things at least move in that direction.

I like the addition of the samples in a7f6d294d6400f9aa6c71055baf4578711029006. I'm good with squashing and merging this as an intermediate step toward more complete docs.  +1

Squashed and pushed to master.

@jdigger : Yes those made perfect sense to me.. I actually asked a person who did not know about grabbit to go through it and see if it is understandable and started making changes from there...


[Feature request] Show all projects in table of infracost comment

My current usage:
infracost breakdown --config-file infracost.yml --format json --out-file infracost.json
infracost comment gitlab --path infracost.json --repo project/repo --merge-request 1234 --gitlab-token TOKEN

Infracost only posts an All projects  project with the combined costs.
It would be better if the individual projects would be visible here as well as a total.
Current situation

:moneybag: Infracost estimate: monthly cost will not change

Project
Previous
New
Diff

All projects
$100
$100
$0

2 projects have no cost estimate changes

Desired situation

:moneybag: Infracost estimate: monthly cost will not change

Project
Previous
New
Diff

Project 1
$25
$25
$0

Project 2
$75
$75
$0

All projects
$100
$100
$0

2 projects have no cost estimate changes

Proposed solution
(Added by @alikhajeh1 from Infracost)
Add --show-options=all-projects to infracost comment and infracost output; the idea being that in the future we could add other things to it (it's not clear what those are yet)

Thanks @syphernl. I think the reason for this is that those 2 projects have no diff, so they are hidden from the table and represented by the 2 projects have no cost estimate changes message. If the projects did have price diffs then they should show in the table.
I'm wondering if there's a better way of presenting this or if we want to make it a flag? There's some existing discussion for this here: https://github.com/infracost/infracost/discussions/1159.
Let me know what you think.

#1159 looks similar, but in the example of the first post I do see a project with no changes but it still shows up in the table. Or is this the case because the other project has changes, and it then shows all individual projects?
I am currently expanding our implementation of Infracost in order to provide our teams with better indication in to the costs of the individual environments as well as the total costs. A flag to show all projects - whether they have changes or not - would be helpful here.

I do see a project with no changes but it still shows up in the table

I think this is because we still show projects that had changes (resources renamed, etc) but resulted in a zero cost diff. Whereas projects that had no changes to resources don't show.

I am currently expanding our implementation of Infracost in order to provide our teams with better indication in to the costs of the individual environments as well as the total costs.

Thanks for the context. This makes sense to me, there's benefit in seeing the cost per project even if there's no diff.
I think to support this we'd probably want to make it a flag, since there are cases where users don't want to see all project and only want to see what has changed. I'll add this to our weekly grooming meeting to see if the team has any ideas.

@syphernl I updated the issue description with the two solutions we can think of, which do you prefer? I'm not sure when we'll get to this yet but it seems like a good option to have (terragrunt users had previously told us to hide the projects with 0 diff from the table and detailed output as otherwise the list gets very long).

which do you prefer?

Option 2 is probably better for future expansion.
One of which could be one to optionally hide "free" projects (e.g. useful for Terragrunt where one of the projects may be a bunch of IAM roles which are free). Not to be confused with 0-diff projects.

Agreed, current comment is not very informative in terms of costs breakdown per project if no changes were made. Given that we process so many details but output very little is unfortunate and should certainly be more configurable. Option 2 sounds reasonable, though we might also make use of the toggle block to display more detailed estimates breakdown. What you think?

@lvkins sorry I missed your comment - I updated the issue description with Option 2 as the proposed solution.

Hi @mohamadrhosseini - thanks for sharing the use-case. That makes sense.
I've added this to the project board and we'll try to get to it in September unless someone from the community wants to work on it, it shouldn't be that difficult but it will require golang experience.

@fatihtokus just wondering if there was any update on this?

@alikhajeh1  created a PR.

Given the comments above (that the current behavior is confusing), I'm wondering if we should add the new --show-options=all-projects flag to all of our CI/CD examples so users are not confused about missing projects but are also aware that they can change that to make the summary table less noisy?

I've updated this so we actually go with the --show-all-projects flag instead of the --show-options flag. After looking through the usage docs of the proposed changes --show-all-projects seems more consistent with our existing flags, since we already have --show-skipped. We can add other options as additional flags in the future if required.
This flag will go out in the v0.10.14 version.

@syphernl, @lvkins, @rottenbytes, @visheyra, @mrhr7, @z0rc, @pacorreia this is now released in v0.10.14. You can use it by adding the --show-all-projects flag to any existing infracost comment commands in your CI pipelines. We'll add some more examples to our individual integration documents soon.
Thank you @fatihtokus for contributing this! 🙏


Add source location to cedar-wasm validate result

Description of changes
Adds the source location to the cedar-wasm output struct. Additionally removes the use of #[serde(untagged)] in the validate result, in favor of a "type" tag field.
The use of untagged made the resulting TypeScript result object difficult to use when working with the generated TypeScript SDK. Type tags are (IMO) fairly standard in the TypeScript ecosystem and are familiar to TS developers, despite the perhaps marginal serialization overhead.
Issue #, if available
Related to #806 (although only implemented for validation)
Checklist for requesting a review
The change in this PR is (choose one, and delete the other options):

[x] A backwards-compatible change requiring a minor version bump to cedar-policy (e.g., addition of a new API).

I confirm that this PR (choose one, and delete the other options):

[x] Does not update the CHANGELOG because my change does not significantly impact released code.

(marked here given that the WASM build is not yet released)
I confirm that cedar-spec (choose one, and delete the other options):

[x] Does not require updates because my change does not impact the Cedar formal model or DRT infrastructure.

I think the CI failure is just a result of needing to merge from main -- #804 changed the definition of SourceLocation out from under this PR.

I've just merged main, although I think #824 may superseed this so feel free to close this PR!

Closing this in favor of #824.


Invoke Multiple tools

Issue you'd like to raise.
In my problem statement I am defining multiple tools which are all based on retrieval chain and I am using OpenAiAgent as the agent  to call this tools.
So when I am running a query it invokes to a single vectorstore. But I need my agent to access different vectorstores if the answer is not fetched from that particular vectorstore.I know the approach to get this working done by other agents.But I need this to be done by openaiAgent.
Suggestion:
No response

yes but here one of the gool is search


Schema inference does not apply filters to Metadata Discovery

Schema inference in petastorm.reader.make_reader utilizes pyarrow.parquet.ParquetDataset to discover metadata (via petastorm.etl.dataset_metadata.get_schema_from_dataset_url), but does not pass filters as an argument (see the instantiation here). This means that there is a bottleneck in both make_reader and make_batch_reader (since it uses the process of schema inference to try to give error messages) for any dataset with a large number of partitions, irrespective of the filters passed in to those functions. Essentially, adding that argument was not meaningful without using it for metadata, in addition to data.

Circling back to test, the filters argument does not appear to be passed to pyarrow.parquet.ParquetManifest, so can't actually speed up the discovery.


feat: send notifications to write company reviews ✍

Description ✏
Closes #537
Describe what this PR does.

On a monthly basis, runs a job that fetches students that have a work experience that ended within the last month. Then, it has the Colorstack bot send a DM to these students encouraging them to leave a review of their experience.

Type of Change 🐞

[x] Feature - A non-breaking change which adds functionality.
[ ] Fix - A non-breaking change which fixes an issue.
[ ] Refactor - A change that neither fixes a bug nor adds a feature.
[ ] Documentation - A change only to in-code or markdown documentation.
[ ] Tests - A change that adds missing unit/integration tests.
[ ] Chore - A change that is likely none of the above.

Checklist ✅

[x] I have done a self-review of my code.
[ ] I have manually tested my code (if applicable).

Thanks @ramiAbdou! And yea I'm definitely down to work on adding a prompt after a member adds a work experience, @tomas-salgado could you make the issue?


Add the mender-gateway docs template

Changelog: None
Signed-off-by: Ole Petter<EMAIL_ADDRESS>

Ref: https://gitlab.com/Northern.tech/Mender/mender-docs-site/-/pipelines

For future reference, is this something to be added to this guide?

For future reference, is this something to be added to this guide?

Probably should, yeh!


Clicking on link in note should open Map View

Currently, on mobile, clicking the link opens up google maps(Earth if Earth is installed, maybe a problem with defaults), but I think if there is an option to open the link into Map View inside the map view itself it would be great.
Problem is real in Linux. It throws an error as I dont exactly have a "Map" app. I can open googlemaps on browser but only after I go to the marker on the map.
So, it would really be a great help if somehow the links in note open in the Map View!! — Just like notes, images or excalidraw or pdfs open in new pane when we click the links, :)
Let me know if I am not clear.

This is a must. Why having a map just in Obsidian, we should go to google or other? I mean, is useful, but the default option should be, imo, to show/center map in for the location clicked.

Until I do that (which I agree that makes a lot of sense), you can right-click the line with the link and choose to open the map view.
(Not as sleek and an extra step compared to clicking the link, I agree...)

Currently facing the same problem on Apple...
Just clicking on the inline geo-link opens the internal map view (cartodb). But when hovering over it the icon appears to open the link and clicking on that, opens Google Earth instead of the internal map.

I didn't notice this is a dup of https://github.com/esm7/obsidian-map-view/issues/144 (actually the other way around but NM).
To make sure I understand, do you mean that the link itself works correctly, but the icon next to it (the little box with the arrow going out, in the default theme) opens an external app?

Ok, I am able to recreate it, and I'm hopeful that the overly complicated method needed to hijack the Obsidian editor links is expandable to the icon too.
However, would you mind to open a new issue for that? I'm hoping to check it out soon, but in case I eventually won't be able to, I rather not get confused by this older issue that is actually resolved.


Simplify equation syntax

Looking at your paper it looks like you have a nice syntax for the equations to be more readable (not split into real/imaginary parts). Any reason why this shouldn't just match the format of 12a (instead of 12b + j*12c)?
I also used the scipy.constants library and the greek letters directly in ascii (which I saw you did for other elements). I also generally think it looks nicer to have spaces around +/- symbols to make it more readable

I don't see any reason to hinder the adoption of simple syntax. The constant library is also a good suggestion. I will approve this PR.


Duplicate attribute declarations behaving unexpectedly

Consider an html tag such as:

Hi

Firefox and chrome both disregard the second class assignment zoop and evaluate to the following:

Hi

I noticed that htmlbars does not do the same, and instead produces the following

Hi

I put a fix in a fork here but I have no idea if the described behavior is intended. If it is not intended, is there a better place for me to contribute my fix/what else do I need to do to get it up to snuff?

@supernullset I'm not sure if this is defined in the html5 spec, but either way we definitely want to match what the major browsers are doing.

@mmun Ok, thats what I was thinking. I actually came across this in the link-to helper (with two class declarations) in an ember project and I was greeted with an obscure parse error. Id love to help out and get this fixed!  So far as I can tell, this is a post parse issue, my original thought was that I would update the parser to just ignore duplicate nodes, but upon reflection I think thats not such a hot idea. Do you think that expanding the structure around processOpcodes would make sense? Im thinking that I could wrap the base function setAttribute in a compiler function for it that would be called here and handle warnings etc.

Actually, I think this should be handled early in on the parsing / AST generation stage.

@mmun How are warnings being thrown in handlebars? I had two thoughts as to why handling this at the parser stage does not feel right:

Duplicate attributes are not necessarily invalid syntax
A better error message could be produced with the extra information that comes from having a proper AST with the duplicate nodes

How warnings are being thrown might give some hints about where this should be done

It's not invalid syntax. Anyways, Esprima parses {x:1,x:2} as two properties so let's stick with your way. We don't have a system for warnings yet.

Cool. Ill get a PR togeather


add exception chain to hld add variable group command

duplicate of https://github.com/microsoft/bedrock/issues/1265


Need double TAB to get focus

Hi, thanks for this really nice component!
I found a little unexpected behavior here when I want to focus to this component from previous input control with Tab key. I need to stroke Tab key twice to focus and start typing on this component.

I have tested it on Chromium 73 and Firefox 66 on Ubuntu 16.04.
Thanks.

Hi, thank you very much for finding a bug, today a new version will be released where this will be fixed. I'll let you know when this happens.
I see your fields may have a green color. If there are no errors, I can do this for you.

:tada: This issue has been resolved in version 2.10.0 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:

I think I fixed the problem with the navigation through the Tab, but I need your confirmation.
I also added a new successful option that adds success styles. I also added 4 new slots (input-before, input-start, input-end, input-after) that allow you to place your content in different parts of the component. Using slot input-end, you can put a tick as you have in the screenshot.
I wrote a sample code that works for me (note: the new slot syntax is used):
<cool-select
  v-model="selected"
  :items="items"
  :error-message="errorMessage"
  :successful="!!(!errorMessage && selected)"
  placeholder="Select name"
>
  <template
    v-if="!errorMessage && selected"
    #input-end
  >
    <span style="color: green; margin-right: 8px;">
      ✔
    </span>
  </template>
</cool-select>

Waiting for your reply.

@andriasmelianus I released a hotfix (2.10.1) where I fixed a small bug, make sure you install this version.
You can also write your suggestions for improving this component, I will consider them.

Hi @iliyaZelenko thank you so much for the extra effort & great features!
But I will try those later, for now, lets focus on this little bug first related to the Tab key.
I have install 2.10.1, but the component refuse to focus and skipping to the next input control instead.
Here is the recorded behavior when I stroke Tab and Shift + Tab

I also have checked this:

Demo on Codesanbox.

It works fine there and I realize, that this problem occurs when we combine the component with native or other input control (e.g. <b-form-input> from BootstrapVue) in the same form.
I hope you have the solution or alternative ways to solve this problem.

This seems to be completely fixed in version 2.10.2. I created for you a demonstration project where you can see this.
Thank you for finding this error and sorry for seeing it in your project.

That's awesome! :handshake: :clap:
The component is working perfectly now.
:top: Lets see this repo crawls to the top soon! :smiley:


[TypeScript] Optional parameter becomes mandatory

using Bridge;

namespace Demo
{
    public class App
    {
        public DoSomething(int i = 5)
        {
        }
    }
}

Generated d.ts:
    export interface App {
        doSomething(i: Number): void;
    }

Expected d.ts:
    export interface App {
        doSomething(i?: Number): void;
    }

At this moment, Bridge generates javascript which doesn't have checks for optional parameters.
The js method looks like
doSomething: function (i) { }
Optional paramaters are inserted by Bridge to invocation declaration during translation. May be we need to generate js code to check that parameter has no value (check during runtime)
I will close this issue and need to create an issue to replace current functionality for optional parameters (generates value inside method body instead adding it invocation during translation)

Yes, TypeScript generates htis kind of check:
function DoSomething (i: number = 5): void  {
}

function DoSomething(i) {
    if (typeof i === "undefined") { i = 5; }
}

Let's keep this issue open because generated d.ts should have that parameter optional and after implementing generating js code to check parameters we would still need to implement TypeScript syntax for this case.

If this is implemented it will fix the issue with the whole CanvasRenderingContext2D which relies on default values.  (issue #411)

A related forum thread.
http://forums.bridge.net/forum/bridge-net-pro/bugs/680-optional-arguments-not-in-js-output

Created an individual issue for pure JavaScript (not TypeScript) - #477.

It is implemented already


Avoid Recreation of API keys & Secret while upgrading confluent terraform provider version (0.5.0 -> 0.7.0)

While upgrading confluent terraform provider version from 0.5.0 to 0.7.0, We're adding confluent_api_key resource to avoid manual creation of keys & secrets.
Current Scenario:
We already have API keys & Secret for existing service accounts.
After Upgrading terraform provider version:
It's adding confluent_api_key resource i.e creating API keys & secret for existing service accounts.
Queries:

Is this expected behaviour while upgrading provider version
Is there any way we can avoid recreation of API keys & secret for already created service accounts,
Also can we limit creation of API key & secret for a service account.

👋 @SukantArora thanks for creating an issue!
In general, we'd very much recommend updating to the latest version of TF Provider (1.7.0) as soon as possible or at least to 1.0.0 (which is the first version that is recommended for using in production).
Speaking about migration to 0.7.0, did you see https://registry.terraform.io/providers/confluentinc/confluent/latest/docs/guides/upgrade-guide-0.7.0 already?

@linouk23, We are planning to update to latest version (1.7.0) eventually, We referred the same doc which you mentioned for upgrading our confluent terraform provider version.
We are upgrading confluent terraform provider version in our existing environment, which have service accounts & topics already, we want to avoid recreation of API keys & secret for it.
It would be great if you can help us with this and also questions asked in my above comment.
Thank You!

Sounds great!
Could you list your TF configuration before & after? It's not super clear to me why TF Provider attempts to create new API Keys.
If you want to import existing API Keys into TF configuration it might be a good idea to import them one by one.

previous.txt
current.txt
I have attached both the files, we only have added `confluent_api_key' resource in the current.
For importing API keys , but there is no resource `confluent_api_key' for previously created service accounts, I couldn't get how can I import that.
Can you please explain.

Sure, so I'm not too familiar how importing works with for_each but if you get rid of it and introduce separate resources for each topic the importing flow would work as following:

Declare new confluent_api_key. app_consumer_kafka_api_key_1 (it's almost done in current.txt -- you only need to remove for_each now).
Follow import doc.
Running terraform plan should show 0 changes.

By the way, here's an example for Importing into Resource configured with for_each that might be helpful.
Let me know if that helps!

Hi @linouk23, Thank You!
I'm able to import confluent_api_key resource, but I have to do it one by one for each key, and we are having around 100 API keys & Secret, and that too in each environment ( STG, PERF, PROD )
Is there any way we can import multiple confluent_api_key resources at once. some kind of a loop, or scripts where we can enter API secrets for all the API keys we can import.

That's great to hear!
Could you create a separate issue for that (something like "How to import lots of resources at once?") and resolve this one?
There're some plans about launching a script that would allow a user to import their existing CC infrastructure to TF but for now you might have to write your own scripting tool or something.

Got It, Thanks for the support!


Privilege escalation: non-admin user can convert private to public simply by renaming project

Steps to reproduce:

Log in as a bog standard user
"New private project" and choose a name
Observe that project is private and that "User management" is not available in Actions tab
"Edit project" and enter a new name
Observe that project is no longer private and that "User management" is now an available action
Profit

(Well, maybe not 6, but...)

Thanks to report this issue, it's fixed now in master.


Missing space in the title

🔍 Is there already an issue for your problem?

[X] I have checked older issues, open and closed

ℹ Environment / Computer Info
Spotify für Windows (64 Bit)
<IP_ADDRESS>0.ga4a70a0e
Spicetify v2.36.11

📝 Description
hey!
On the landing page is a space missing on the top left. I tried a few different versions of the marketplace but none of these fix this.
I tried the automatic installed version, which I assume is the latest (currently 1.0.2), 1.0.1 and 1.0.
I guess Spotify messed something up.
📸 Screenshots

Duplicate of https://github.com/spicetify/marketplace/issues/767


Random errors due to uncaught exception on iOS

Occasionally, when loading the camera view, I get the following error in logs:
2016-05-24 13:33:26.002 myApp[734:897165] *** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '*** -[AVCaptureMetadataOutput setMetadataObjectTypes:] - unsupported type found.  Use -availableMetadataObjectTypes.'
*** First throw call stack:
(0x1829c2e38 0x182027f80 0x189153068 0x1001c54c8 0x1003a1a7c 0x1003a1a3c 0x1003ae554 0x1003a572c 0x1003a1a3c 0x1003b0c9c 0x1003b0364 0x182625470 0x182625020)
libc++abi.dylib: terminating with uncaught exception of type NSException

The highlighted code is the following:
    AVCaptureMetadataOutput *metadataOutput = [[AVCaptureMetadataOutput alloc] init];
    if ([self.session canAddOutput:metadataOutput]) {
      [metadataOutput setMetadataObjectsDelegate:self queue:self.sessionQueue];
      [self.session addOutput:metadataOutput];
  -->    [metadataOutput setMetadataObjectTypes:self.barCodeTypes];
      self.metadataOutput = metadataOutput;
    }

Using the following:
"react": "^0.14.5",
"react-native": "^0.22.0",
"react-native-camera": "git+https://github.com/lwansbrough/react-native-camera.git", (Currently at 0.3.8)
and testing on iOS 9.3.1
I haven't been able to pinpoint the reason for this, as it seems to happen randomly.

Same issue here:
"react": "15.1.0",
"react-native": "^0.27.2",
"react-native-camera": latest master branch
iOS 9.3.4

I have the issue when scanning data matrix codes:
"react": "15.4.1",
"react-native": "0.38.0",
"react-native-camera": latest master branch
iOS 10
Using 'datamatrix' produces the error, 'org.iso.DataMatrix' (that's what onBarCodeRead's e.type returns).
Possibly related: #347.

@Phoenix1708 Your sentence somehow stops.. Where do you remove the barCodeType property from?

Closed due to missing feedback.


Crash, if any variable have reference to delete node

Godot version:
3.0.6 - 3.1a3
OS/device including version:
Windows 10 x64
Issue description:
App is freez and crash, if any variable have reference to delete node.
Steps to reproduce:
var n
func _ready():
	n = Node.new()
	add_child(n)
	n.queue_free()   # crash
#	n = null  # no crash

Run project - and in editor go to remote debug and select Node with this var.

Can't reproduce in Windows 10 Godot 0cff752
Can you open godot via console/terminal and then run a project and see what was written to console?

nope... just freez and crash

No, just empty window without any error message and freeze.

Unless I'm missing something this is intended(?) behaviour, if you're referencing n after freeing it you're going to have to use weakref(n).get_ref() to check that n exists and is not a previously freed node.

no, no referense... no use this var.... just freez
i try another Windows, try 3.0.6 stable 3.1a3.... - crash
https://www.dropbox.com/s/s5lx9nxfmer40wx/test.zip?dl=0
can you drop project without crash?

Find. Run project - and in editor go to remote debug.

@AlexHoratio AFAIK it is meaningless to use weakref on nodes because they are not references. I thought Reduz added a way to check if a var holding an object is valid, recently? Also a crash (i.e no breakpoint) should be fixed, if that happens in an editor build.

Reduz added a way to check if a var holding an object is valid
Yep, I know :).
https://github.com/godotengine/godot/commit/ff1e7cfbf4b7ad9b327588ce7dffb43d31fee3e9
But, crash in an editor build... ((( Any variants to avoid this?

I am using 3.0.3 and for quite some time I had a similar problem running one of my projects from editor. @Zylann can you clarify what do you mean by crash (i.e no breakpoint) - in my case, it did crash but it showed the full stacktrace telling me what exactly happened, so exactly like a breakpoint was set.

temp small hack:
	set_meta("n", Node.new()) 	add_child(get_meta("n")) 	get_meta("n").queue_free()
store in metadata :/ ... no crash :)

@Zireael07 sometimes people say "crash" when it's actually an error catched by debugger. If it really crashes with no info in non-release build, that must be fixed. If you get an error with stack trace in the editor, then it's fine.

O_o you can add metadata as children? super weird
@SuperDIMMaX: Do you see an error with stack trace when the editor build crashes?

I cannot reproduce it on Windows.
@SuperDIMMaX Could you try the following approach?
extends Node

var n
func _ready():
	n = Node.new()
	add_child(n)
	n.call_deferred('queue_free')
	prints('queue_free', n)
	yield(get_tree(), "idle_frame") # Just waiting to check it again in the next frame
	prints('_ready:done', n)
	n = null

Output (no crash):
queue_free [Node:1067]
_ready:done [Deleted Object]

Nope... no error... app freez, then crush. Editor say:
ERROR: _get_socket_error: Socket error: 10054    At: drivers/unix/net_socket_posix.cpp:190

O_o you can add metadata as children? super weird

Nope. I store reference to object in metadata vars.

I guess, editor not validate reference and try get non exist object.

Time mark this as bug?

can confirm this happens on 3.0.6, w10, 64-bit
i get spammed <couldn't map PC to fn name> , no other useful info is printed, unfortunately

Can anyone still reproduce this bug in Godot 3.2.2 or any later release?
If yes, please ensure that an up-to-date Minimal Reproduction Project (MRP) is included in this report (a MRP is a zipped Godot project with the minimal elements necessary to reliably trigger the bug). You can upload ZIP files in an issue comment with a drag and drop.

Closing due to lack of update. Please comment if you can still reproduce this issue in the latest stable version of Godot.


Slave count doesn't get updated in the UI if no more slaves are alive

Hi,
I was running some simple tests with locust (which is so cool btw) and I noticed that if you end up with no slaves connected, the UI does not reflect this change. The slave count in the UI sticks to 1 in this case.
Also, it would be nice to get a warning message in the webUI if you start swarming with no slaves connected. Now, you get this warning only in the command line.
I could provide a quick fix for this if you'd like.
Thanks!

Hello guys,
I has similar issue. Master and web UI doesn't reflect the actual slaves count.
We run locust in Docker containers. My setup include 200 slaves, so 200 docker containers.
Master has registered them all. But, when containers number was downscaled to 10, master and web UI still show 200 slaves assigned.
Our docker is using latest locustio package from pip.
Any advice is appreciated.
Thanks!

@vorozhko:
I ran into the same issue with the following setup:

locust master and slaves running in Docker containers
Docker containers orchestrated with Kubernetes on 4 VMs (private cluster)

The problem is related to how the containers are stopped. For a locust slave to be properly terminated and the number correctly updated, it needs to send the quit message when handling the SIGTERM event by calling the shutdown function.
In my case, the entrypoint for the container is a shell script which starts locust as a child process. It means that the shell script will be assigned PID 1 and the locust script a different PID. When docker stop is called, it send the SIGTERM event to the process with PID 1. But if it is not handled, it waits 10s and then kill the container (and locust can't shutdown gracefully).
The locust start-up I'm using is mostly inspired by https://github.com/peter-evans/locust-docker. With that setup, the easy fix was to prepend exec to replace the shell with the python program, so locust gets PID 1 and can handle the SIGTERM signal:
exec $LOCUST_PATH $LOCUST_FLAGS
Another way to fix this problem would be to handle the case when a slave is disconnected in the locust code itself (socket closed or similar).


Use explicit version numbers in the properties section for plugins.

these versions are provided by spring-data-parent https://github.com/spring-projects/spring-data-build/blob/main/parent/pom.xml


Allow custom endpoints

Azure now lets you host your own ChatGPT instances. It would be cool  to allow this plugin to use those endpoints rather than the OpenAI one.
This would allow the plugin to be used in more sensitive environments

fixed by #26 and slated for next release! Thanks again for the PR, @Nintorac!


Using AAC Codec results a complete muted reproduction

I'm using the chain bluealsa -> bluealsa-aplay to reproduce music from my phone.
If I use a standard SBC coded everything is working, when I try to use AAC (using the iPhone) there's no audio.
In debug mode I see all the packets flow so everything seems fine.
Something is happening in the fdk-aac library. Have you tried this before?
Thank you

I've been testing it with iPhone, however it was quite a long time ago and since then there was a lot of changes in the bluez-alsa project :) Fortunately, right now I've got access to an Android phone with the AAC support. I will check it today in the evening.

I hope, that this "fix" will work for you. It seems that iPhone does not follow A2DP AAC specification...

I Ark thank you for the prompt reply. Now the something exits from the loudspeakers but it is like pieces of waveform separated by silence (likes 3 or 4 per seconds). (Imagine someone at the volume that raise to 100% and low to 0% 3 or 4 times per seconds... this is the effect)

@Arkq I can confirm that the commit fixes the issue on my iPhone. I do not get the fragmented sound as described by @badbat75 .

@joerg-krause I do not know what causes sound chopping, but I was able to reproduce it as well. However, I think, that it is not related to this issue. It will be tracked with the #132. I've got two doogee smartphones, and with one of these phones sound streaming does not work....


chore(ci): add codcov step to unit test flow

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@6e76ede). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #236   +/-   ##
=======================================
  Coverage        ?   93.88%
=======================================
  Files           ?       27
  Lines           ?      278
  Branches        ?        4
=======================================
  Hits            ?      261
  Misses          ?       15
  Partials        ?        2

Flag
Coverage Δ

unittests
93.88% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e76ede...57ae8ce. Read the comment docs.


Lock management "by hand": example with early release of a lock

Hi,
I've a Jenkins job using pipeline and locks.
My Jenkinsfile looks like that:
[...]
lock(resource: 'mylock') {
  parallel foo: stuff_for_foo, bar: stuff_for_bar
}
[...]

Of course, the lock is kept until foo and bar are both terminated.
I would like to know whether it's possible to release the lock as soon as one there is a failure (in either foo or bar).
Note: I'm aware of the "failFast" option of parallel step. However, I do not want to kill all branches in case of failure. Just to release the lock.
Is it possible to lock and release resources directly using API ? Perhaps using LockableResourceManager.lock(..) and LockableResourceManager.freeResources(...) programmatically ?
Any clue on this topic ?
Many thanks

I would propose 2 new steps, boolean tryLock(string resourceName) and void releaseLock(string resourceName).
So that I can:

Try to lock several resources to find one that I can use.
Do the locking within its own stage and easily visualize how much time is spent on waiting.
Release locks when I choose to.

Just reading the original issue, I am trying to understand how the use-case fits with lockable resource concepts? If the resource represented a device, or some other token for dedicated use by some one consumer at a time, doesn't the surviving branch of your parallel job still need it (and need that someone else does not hijack it)? Otherwise, could there be separate resources for those separate branches?

Note for developer.  Document how to unlock resource via LRM.
Add there a notice that is potential risk.
Maybe we shall add it also in groovy shared lib.


Fix OpenTelemetry docs

This fix was already applied in https://github.com/JasperFx/wolverine/pull/735 but got overriden with https://github.com/JasperFx/wolverine/commit/bc6f501a61798cfa2a6b487830e0decea785c5ab . I guess this was done by accident since AddOpenTelemetryTracing is deprecated.
Full credit to @woksin for the initial fix!

@jeremydmiller it looks like it got overridden again by the 3.0 docs.


Update README.md

Add missing "ts" to moduleFileExtensions for TypeScript instructions
Because:
It was missing in the docs, and required for test files written in TypeScript

Thanks @Krossmaskinen!


Path includes a dot (.) character

Describe the bug
When trying to load styles from a file from another library using @vanilla-extract/vite-plugin, an error occurs on the dev server:
vite:spa-fallback Not rewriting GET /@id/ComponentsApp/src/components/Button/styles.css.ts.vanilla.css?hash=0b6a2903c4458e87f00567205ad0a3b6 because the path includes a dot (.) character.
This only occurs if you install the library from the local repository.
At first I thought that the problem might be in the plugin itself, but after debugging I realized that the following path is passed to the @vanilla-extract/vite-plugin for exporting styles:
These two points cause this error
MainApp/../ComponentsApp/src/components/Button/styles.css.ts.vanilla.css?source=LnN0eWxlc19fN3ltc2N6MCB7CiAgY29sb3I6ICNmZjAwMDA7CiAgZm9udC1zaXplOiAyMHB4Owp9
Reproduction
git clone git@github.com:maratnasyrov/ComponentsApp.git
git clone git@github.com:maratnasyrov/MainApp.git
cd MainApp
npm install -S ../ComponentsApp
npm run dev
Open localhost:3000 in browser
Also, this error can be seen in the console
System Info
System:
    OS: Linux 5.4 Ubuntu 20.04.2 LTS (Focal Fossa)
    CPU: (4) x64 Intel(R) Core(TM) i3-4170 CPU @ 3.70GHz
    Memory: 413.61 MB / 15.58 GB
    Container: Yes
    Shell: 5.8 - /usr/bin/zsh
  Binaries:
    Node: 14.17.3 - ~/.nvm/versions/node/v14.17.3/bin/node
    Yarn: 1.17.3 - /usr/bin/yarn
    npm: 6.14.13 - ~/.nvm/versions/node/v14.17.3/bin/npm
    Watchman: 4.9.0 - /usr/local/bin/watchman
  Browsers:
    Chrome: 92.0.4515.107
    Firefox: 90.0.2

Used Package Manager
npm
Logs
vite:load 0ms   [fs] ../ComponentsApp/src/components/Button/styles.css.ts +43ms
  vite:resolve 1ms   MainApp/../ComponentsApp/src/components/Button/styles.css.ts.vanilla.css?source=LnN0eWxlc19fMXVoNTl2MjAgewogIGNvbG9yOiAjZmYwMDAwOwogIGZvbnQtc2l6ZTogMjBweDsKfQ== -> MainApp/../ComponentsApp/src/components/Button/styles.css.ts.vanilla.css?hash=6785b7839a3057ae265165081227272a +62ms
  vite:resolve 1ms   /@id/ComponentsApp/src/components/Button/styles.css.ts.vanilla.css?hash=6785b7839a3057ae265165081227272a -> null +1ms
  vite:transform 43ms  ../ComponentsApp/src/components/Button/styles.css.ts +60ms
  vite:time 45ms  ../ComponentsApp/src/components/Button/styles.css.ts +59ms
  vite:resolve 1ms   ComponentsApp/src/components/Button/styles.css.ts.vanilla.css?hash=6785b7839a3057ae265165081227272a -> null +12ms
  vite:spa-fallback Not rewriting GET /@id/ComponentsApp/src/components/Button/styles.css.ts.vanilla.css?hash=6785b7839a3057ae265165081227272a because the path includes a dot (.) character. +838ms
  vite:time 3ms   /@id/ComponentsApp/src/components/Button/styles.css.ts.vanilla.css?hash=6785b7839a3057ae265165081227272a +13ms

Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to https://github.com/vuejs/vue-next instead.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

+1
In my case, I need to parse a JWT from the URL which is part of the path. For example:
http://localhost:4000/some-path/ag348g9ha3e48rhgalsdkf.f23agw4eg89asdhg.Ddufasfmwi9o0efjnE

Duplicate of #4344

First, I apologize that I mistakenly marked it as a duplicate at the beginning.
I tested this issue and only the npm installed dependencies have this problem, the yarn installed dependencies do not have this problem.
Because vite resolves the locally installed ComponentsApp dependencies to different paths：
https://github.com/vitejs/vite/blob/0aaca236326d89ff54a9710cf0680d76f0a06e23/packages/vite/src/node/plugins/resolve.ts#L491-L505
local dependency for the yarn installation, obtained by resolve, is a link address:
root/MainApp/node_modules/ComponentsApp/src/index.ts
and the local dependencies installed by npm get a real address:
root/ComponentsApp/src/index.ts
this causes the transform hook that triggers @vanilla-extract/vit-plugin to parse @vanilla-extract/css as:
MainApp/../ComponentsApp/src/components/Button/styles.css.ts.vanilla.css?source=LnN0eWxlc19fMXVoNTl2MjAgewogIGNvbG9yOiAjZmYwMDAwOwogIGZvbnQtc2l6ZTogMjBweDsKfQ==
later, when entering the resolveId hook of @vanilla-extract/vit-plugin, the path above is used as the Key to store static CSS code, but Vite normalizes this path before the end of the resolveId hook as follows:
https://github.com/vitejs/vite/blob/0aaca236326d89ff54a9710cf0680d76f0a06e23/packages/vite/src/node/server/pluginContainer.ts#L468-L471
the path becomes:
root/ComponentsApp/src/components/Button/styles.css.ts
this leads to later loading the style with the load hook, using the normalized path as the key to get the static CSS code, which is inconsistent with the code used when storing, so it cannot be found and eventually leads to a 404.
I will submit a pr in the @vanilla-extract/vit-plugin community to fix this issue. This issue I marked as upstream because I think normalization can avoid a lot of security issues, so we should normalize the path.

@ygj6 thanks for your quick response and analysis of this problem. I have not tried using yarn in this case yet, but I think it might be a temporary solution until your changes in vanila-extract are published.

@ygj6 thanks for your quick response and analysis of this problem. I have not tried using yarn in this case yet, but I think it might be a temporary solution until your changes in vanila-extract are published.

PR has been merged and @vanilla-extract/vite-plugin has released 1.1.2 version, I tested it and the issue has been solved, you can try it.
https://github.com/seek-oss/vanilla-extract/releases/tag/%40vanilla-extract%2Fvite-plugin%401.1.2

Checkout vite plugin https://github.com/ivesia/vite-plugin-rewrite-all
This should fix the problem (see also #2190)


the Draft could not use the keyof T type

you can see an code example here:
code sandbox
function ChangeState<T extends Record<string, any>, M extends keyof T>(
  state: T,
  field: M,
  value: T[M]
) {
  return produce(state, (draftState) => {
    draftState[field] = value;
    // Type 'M' cannot be used to index type 'Draft<T>'
  });
}

the keyof T should be used by Draft<T>

See castDraft https://immerjs.github.io/immer/typescript#cast-utilities
On Thu, Mar 17, 2022 at 11:14 AM Rey Wang @.***> wrote:

you can see an code example here:
code sandbox
https://codesandbox.io/s/typescript-playground-export-forked-jf764x?file=/index.ts
function ChangeState<T extends Record<string, any>, M extends keyof T>(
state: T,
field: M,
value: T[M]
) {
return produce(state, (draftState) => {
draftState[field] = value;
// Type 'M' cannot be used to index type 'Draft'
});
}
the keyof T should be used by Draft
—
Reply to this email directly, view it on GitHub
https://github.com/immerjs/immer/issues/918, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAN4NBB7VBTQXTJ3GNWS5BDVAMH3HANCNFSM5Q6UMC2A
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

I'm sorry but how does castDraft help here? draftState is already of the type Draft<T> using the cast would produce Draft<Draft<T>>.
I have a similar problem:
function ChangeStringState<M extends string>(
  state: Record<M, string>,
  field: M,
  value: string,
) {
  return produce(state, (draftState) => {
    draftState[field] = value;
    // Type 'M' cannot be used to index type 'Draft<Record<M, string>>'
  });
}

Yeah same here, is there a way to use a generic keyof M parameter to index the Draft type?

Same issue here. Having a record with generic key type make immer fail. Interestingly enough this is not just a type error, but produce provides no patches at all. I basically ignored the errors for a moment and tries to use produceWithPatches. But the list of returned patches is just empty. In result the produced record is actually changed, but is the same (according to Object.is).

usually these kind of problems take a bit of fiddling around until it "clicks", for typescript like sometimes it helps to type the draft param itself. Or if you use a mutable type definition anyway, there is no Draft wrapper needed anyway (it is only there to make sure that readonly types become assignable in producers), so in that case you can just cast to your real type.
Beyond that hard to give advice on specific cases without a sandbox, to fiddle with.

But the list of returned patches is just empty

Typescript types have no influence on runtime behaviors, so probably two things are being conflated here. Best open a separate issue.
I'm locking the issue as it now discusses three different cases and OP is 1.5 years old.


Error in FastReport community

Hello!

How to connect the parameter in the report in dotnet core 2.1 and FastReport community.
Error while executing the request

Hi!
Thanks for issue request! We have an updated version the Designer Community Edition. Could you try it with your report?
FastReport Community Edition 2018.4.9

It works great! Thank!


Error when copying emoticon to clipboard

Once I finish creating an emoticon, and select to copy it to the clipboard (I did this by going with the default Y), I get the following error:
Something bad happened (︶︹︺)
Error
    at Function.module.exports.sync (/usr/local/lib/node_modules/oji/node_modules/execa/index.js:303:26)
    at Object.copySync (/usr/local/lib/node_modules/oji/node_modules/clipboardy/lib/macos.js:9:26)
    at Object.exports.writeSync.input [as writeSync] (/usr/local/lib/node_modules/oji/node_modules/clipboardy/index.js:38:13)
    at Object.when (/usr/local/lib/node_modules/oji/lib/functions.js:86:18)
    at /usr/local/lib/node_modules/oji/node_modules/run-async/index.js:25:25
    at /usr/local/lib/node_modules/oji/node_modules/run-async/index.js:24:19
    at DeferSubscriber.Rx.Observable.defer [as factory] (/usr/local/lib/node_modules/oji/node_modules/inquirer/lib/ui/prompt.js:109:32)
    at DeferSubscriber._callFactory (/usr/local/lib/node_modules/oji/node_modules/rxjs/observable/DeferObservable.js:92:27)
    at DeferSubscriber.tryDefer (/usr/local/lib/node_modules/oji/node_modules/rxjs/observable/DeferObservable.js:85:18)
    at new DeferSubscriber (/usr/local/lib/node_modules/oji/node_modules/rxjs/observable/DeferObservable.js:81:14)

The complete output is:
? Welcome to OJI! Choose option: Create new emoji
? Choose left arm: ╰
? Choose right arm: ᕤ
? Choose left body: (
? Choose right body: )
? Choose left cheek: ”
? Choose right cheek: ”
? Choose left eye: o
? Choose right eye: o
? Choose nose/mouth: ω
This is your emoji: ╰(”oωo”)ᕤ
? Copy it to clipboard? Yes
Something bad happened (︶︹︺)
Error
    at Function.module.exports.sync (/usr/local/lib/node_modules/oji/node_modules/execa/index.js:303:26)
    at Object.copySync (/usr/local/lib/node_modules/oji/node_modules/clipboardy/lib/macos.js:9:26)
    at Object.exports.writeSync.input [as writeSync] (/usr/local/lib/node_modules/oji/node_modules/clipboardy/index.js:38:13)
    at Object.when (/usr/local/lib/node_modules/oji/lib/functions.js:86:18)
    at /usr/local/lib/node_modules/oji/node_modules/run-async/index.js:25:25
    at /usr/local/lib/node_modules/oji/node_modules/run-async/index.js:24:19
    at DeferSubscriber.Rx.Observable.defer [as factory] (/usr/local/lib/node_modules/oji/node_modules/inquirer/lib/ui/prompt.js:109:32)
    at DeferSubscriber._callFactory (/usr/local/lib/node_modules/oji/node_modules/rxjs/observable/DeferObservable.js:92:27)
    at DeferSubscriber.tryDefer (/usr/local/lib/node_modules/oji/node_modules/rxjs/observable/DeferObservable.js:85:18)
    at new DeferSubscriber (/usr/local/lib/node_modules/oji/node_modules/rxjs/observable/DeferObservable.js:81:14)

OS: macOS Sierra 10.12.6
Terminal: iTerm2
Note: I'm using tmux, and I'm unsure whether that could cause the issue or not.

I think this might be a bug with clipboardy module.

Update oji to version 1.0.7, should work now :smile:

I've updated, and it does seem to work now. Thanks!


Welcome screen quickstart improvements

Welcome screen improvements inspired for pybricks/support#1264

Thanks for working on this.
Some suggestions to improve it even more:

I think it would be better if the actions didn't overlap the logo. So we could make the actions aligned to the bottom or to the left and then have the logo be dynamically sized to fill the remaining space
I don't think "open existing project" is the best choice. If the project tab is already open, the button will do nothing. So it may seem to the user that the button is broken. Instead, I would suggest to provide a list of the 3 most recently used projects, if any, where clicking on one of the projects will open it.

Thanks for working on this.
Some suggestions to improve it even more:

I think it would be better if the actions didn't overlap the logo. So we could make the actions aligned to the bottom or to the left and then have the logo be dynamically sized to fill the remaining space
I don't think "open existing project" is the best choice. If the project tab is already open, the button will do nothing. So it may seem to the user that the button is broken. Instead, I would suggest to provide a list of the 3 most recently used projects, if any, where clicking on one of the projects will open it.

Thanks for the prompt comment.

I played around with the layout, and started from the VS/VSCode welcome setup. Pybricks logo is nevertheless rotated... I am not sure I can follow the above Can you add a small sketch so that I get your layout proposal better?
As for the items I was trying to start from the pybricks/support#1264 suggestion from Laurens, yet I love your idea. At the moment I could not find pybricks FileStorageDb storing or updating any timestamp. Any ideas to get that data?

export type FileMetadata = Readonly<{
    /** A globally unique identifier that serves a a file handle. */
    uuid: UUID;
    /** The path of the file in storage. */
    path: string;
    /** The SHA256 hash of the file contents. */
    sha256: string;
    /** The text editor view state. */
    viewState: monaco.editor.ICodeEditorViewState | null;
}>;

Like this?

Like this?

Pretty much. Although IMHO, vertically aligned and slightly bigger text would be more ascetically pleasing.

(I didn't spend much time on this, so text is probably a bit larger than what I had in mind compared to the scale of the rest of the app that isn't pictured)

2. Any ideas to get that data?

We could add a saga that subscribes to the file open/activate events that writes an array of file names where the currently viewed file always gets bumped to the front of the list. This way, we could avoid file metadata.
Or we could modify the DB to have a last viewed timestamp that gets updated by a similar saga. I don't really have a preference one way or the other at this point.

Thanks for this one! To save yourself some time for future submissions, please do feel free to discuss a sketch or mockup first.

(...) recent files (...)

How about keeping this very simple? The linked issue is about users sometimes not being able to find the file menu when it is closed. Presenting a few recent files on the main screen does not necessarily solve that problem. And potentially amplifies it --- "I see three files, where is the rest?" Or people might think they have to close all their files just to open another.
There may be simpler possibilities:

Option 1: No new UI --- if Pybricks Code is opened, simply have the file menu open by default.
Also, if there are no files yet, show italic placeholder text Create a file to begin... at the location where the first file would be.

Option 2: All of option 1 and show the welcome tour if Pybricks is opened without any files.

Option 3: As discussed in the original issue and your initial PR.
I don't think the button would be doing nothing. It could just say either "Show files" or "Hide files".

After writing this down, I think option 1 makes sense, even independently from this issue. Since opening the file tab is needed in 99% of cases, this really should be the default.
The problem with option 3 is that it essentially duplicates two buttons, which is not ideal in any UI, so that was a bad suggestion on my part in https://github.com/pybricks/support/issues/1264.

I guess we are back on the design board so might make sense to return to the pybricks/support#1264 issue to clarify and agree on a target set.
Shall we continue there?


arm64: Implement Icmp for I16X8 and I32X4

Copyright (c) 2020, Arm Limited.
Probably best to not merge this until https://github.com/bytecodealliance/wasmtime/pull/1802 is, since I don't want to cause more trouble for Anton.

Thanks -- force-pushed a merge conflict fix; will merge when green.


Add name of contributors #7

Thank You @anantprsd5  but looks like someone submitted a PR already. Keep Contributing 😄


Fixed case-sensitive Slides/slides link

Links were pointing to https://beta.ionicframework.com/docs/api/Slides (upper-case 'S') when they should be pointing to "https://beta.ionicframework.com/docs/api/slides" (lower-case 's').
Short description of what this resolves:
broken links in documentation
Changes proposed in this pull request:
Ionic Version: 4.x
Fixes: #

Thank you!


chore: adding links to idsg in docs

Hello, Are these broken now? (DAT & DAPS)
https://github.com/International-Data-Spaces-Association/DataspaceConnector/blame/main/docs/pages/deployment/configuration.md#L31


test(react-router): reproducer starter for #2255

[!IMPORTANT]
These reproductions need to be corrected to match the expected route tree and the content to be displayed on the screen.

Starting for the reproductions for #2255

Currently, we've identified 3 scenarios that need resolution.

/about route with an async loader where this is thrown notFound()

<root.NotFoundComponent />

/about route with a non-async loader where this is thrown notFound()

<root.Component>
  <@tanstack/react-router->DefaultGlobalNotFound />
</root.Component>

/route-that-does-not-exist

<root.Component>
  <root.NotFoundComponent />
</root.Component>

2 definitely shouldn't be happening since it should be traversing up the route-tree to select the notFoundComponent.


Request Study: move "Use map..." card below list of requests

Description
In Request Study, we currently show a "Use map..." prompt above the list of requests.  This task moves that below the list of requests.
Acceptance Criteria

[ ] the "Use map..." card has been moved below the list of requests, and above "Request Priority and Details".

Additional Notes
This is based off usability feedback from users: when they add new locations, they're at the bottom of the list, and some users have reported scrolling all the way to the top to access this card.  (As a side note: all that the "Search Map" button does is focus the search bar on the map; however, this alternate interaction is not easily discoverable.)
See <FcDrawerRequestStudyNew> for card markup.

This is not aligned with current priorities (focus on collision data parity with legacy systems). We may revisit this in the future.