AVRO-2929: Fix larger than requested rented array length

Make sure you have checked all steps below.
Jira

[x] My PR addresses the following Avro Jira issues and references them in the PR title. For example, "AVRO-1234: My Avro PR"

https://issues.apache.org/jira/browse/AVRO-2929

Tests

[x] My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

[x] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters (not including Jira issue reference)
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Documentation

[x] In case of new functionality, my PR adds documentation that describes how to use it.

All the public functions and the classes in the PR contain Javadoc that explain what it does

Hello!  I merged the other PR with a unit test, but thank you for the contribution!

Hello!  I merged the other PR with a unit test, but thank you for the contribution!


Fix bug on restful gateway. Send proper time and catch error in model for complete game

I found a couple of bugs while learning about the architecture, so I fixed them :)

@jesusreal thanks for the catches! I left two small comments, it'll be great if you can address them.

Your comments were very useful to realise that I could provide a much better fix. Thanks! :)


try to get shop-domain from header

because we have this issue https://github.com/ohmybrew/laravel-shopify/issues/295 i try also to get the shopify_domain from the header. in our app we set the header by
window.axios.defaults.headers.common['shop'] = document.head.querySelector('meta[name="shop"]').content

Coverage remained the same at 99.621% when pulling e7e03555382f700815cfe7214bff3e1022de9cf4 on StefanNeuser:master into 01c49909546c2583225147dadaa920277df9083e on ohmybrew:master.

This is very dangerous and would allow an attacker to load any shop by spoofing the header

@darrynten , no it isnt because of the $session->isValid() check in the AuthShop.php middleware

@darrynten your fix is the better one: https://github.com/ohmybrew/laravel-shopify/pull/298


Feature: Introduce the DbSettingMapper class.

This feature has been checked in to the master branch. This will be available on releases > v1.9.11

This is now available at RepoDb releases >= v1.10.0.


Is it possible to see two runs at once?

I cannot seem to spectate my PB ghost, while also having another ghost on the map at the same time
This behaviour is enabled by default without the plugin, but when I have the plugin on, clicking any leaderboard time will cause only that ghost to show
Am I missing something?

Nevermind I had ghosts disabled 🤦🏻♂


can not work with react native

hi, I've setup .babelrc like this:
{
    "presets": ["module:metro-react-native-babel-preset"],
    "plugins": [
        [
            "inline-import",
            {
                "extensions": [".md", ".text", ".txt"]
            }
        ],
        [
            "module-resolver",
            {
                "root": ["./src"],
                "alias": {}
            }
        ]
    ]
}

But cli throw error as below:
error: bundling failed: Error: Unable to resolve module `./button.spec.md` from `/Users/jess/jess/renrendai/source/rrd-react-native/storybook/stories/button.story.js`: The module `./button.spec.md` could not be found from `/Users/jess/jess/renrendai/source/rrd-react-native/storybook/stories/button.story.js`. Indeed, none of these files exist:
  * `/Users/jess/jess/renrendai/source/rrd-react-native/storybook/stories/button.spec.md(.native||.android.js|.native.js|.js|.android.json|.native.json|.json|.android.ts|.native.ts|.ts|.android.tsx|.native.tsx|.tsx)`
  * `/Users/jess/jess/renrendai/source/rrd-react-native/storybook/stories/button.spec.md/index(.native||.android.js|.native.js|.js|.android.json|.native.json|.json|.android.ts|.native.ts|.ts|.android.tsx|.native.tsx|.tsx)`
    at ModuleResolver.resolveDependency (/Users/jess/jess/renrendai/source/rrd-react-native/node_modules/metro/src/node-haste/DependencyGraph/ModuleResolution.js:120:15)
    at ResolutionRequest.resolveDependency (/Users/jess/jess/renrendai/source/rrd-react-native/node_modules/metro/src/node-haste/DependencyGraph/ResolutionRequest.js:49:18)
    at DependencyGraph.resolveDependency (/Users/jess/jess/renrendai/source/rrd-react-native/node_modules/metro/src/node-haste/DependencyGraph.js:218:16)
    at Object.resolve (/Users/jess/jess/renrendai/source/rrd-react-native/node_modules/metro/src/lib/transformHelpers.js:141:30)
    at dependencies.map.result (/Users/jess/jess/renrendai/source/rrd-react-native/node_modules/metro/src/DeltaBundler/traverseDependencies.js:373:31)
    at Array.map (<anonymous>)
    at resolveDependencies (/Users/jess/jess/renrendai/source/rrd-react-native/node_modules/metro/src/DeltaBundler/traverseDependencies.js:369:18)
    at /Users/jess/jess/renrendai/source/rrd-react-native/node_modules/metro/src/DeltaBundler/traverseDependencies.js:188:33
    at Generator.next (<anonymous>)
    at step (/Users/jess/jess/renrendai/source/rrd-react-native/node_modules/metro/src/DeltaBundler/traverseDependencies.js:298:30)
 BUNDLE  [android, dev] ./index.js ░░░░░░░░░░░░░░░░ 0.0% (0/1), failed.

it doens't work for me either, when I import a file, the plugin looks for it in node_modules

No solution for this?

You need to add this to metro.config.js:
const metroDefault = require('metro-config/src/defaults/defaults.js');
...
  resolver: {
    sourceExts: metroDefault.sourceExts.concat(['md', 'sql', 'txt']),
  }
....

Then it's all sweet. I think this should be mentioned in readme.

Also not working with react-native 0.64.2 for me despite configuring the metro config (adding html to sourceExts).
It works when testing an app locally on a physical iOS device, but not with Xcode cloud/test flight.


Bosskmk master

@selvam920
I will consider keypad support in the next version.
Thanks for the code contribution.


Update decapitalize.md

fixed function definition

Description

Resolves #(issue number)
What does your PR belong to?

[ ] Website
[ ] Snippets
[ ] General / Things regarding the repository (like CI Integration)

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (non-breaking improvement of a snippet)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[*] I have checked that the changes are working properly
[ ] I have checked that there isn't any PR doing the same
[ ] I have read the CONTRIBUTING document.

Thank you for your contribution!


Code folding problem with some theme.

I'm using windows 8.1 64bit, and when I download some theme, there is a "bug" with the code folding part.

I mean the cross instead of triangle.

@zolock the default marker is a triangle - but this can be overridden by themes. The theme shown in the image has chosen to render the fold marks as a +.  Since it is not a core brackets issue, you can file an issue with the author of the theme you are using. Please clarify if I have misunderstood the issue.


Add BankTransfer as a payment method [t-rB97kpOf]

Codecov Report

Merging #141 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #141   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files          53     55    +2
  Lines         947    966   +19
=====================================
+ Hits          947    966   +19

Impacted Files
Coverage Δ

src/Services/Gateways/BankTransfer.php
100% <100%> (ø)

src/Facade.php
100% <100%> (ø)
:arrow_up:

...c/Services/Adapters/BankTransferPaymentAdapter.php
100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 823c57a...f0c4268. Read the comment docs.


add support for retrieving the last N versions of a secret

Credstash support versioning of secrets which allows to easily rotate secrets.
With this change node-credstash will keep its current behavior of returning the latest version of a secret by default.
I added a new option limit, to get the latest N versions of a secret:
const Credstash = require('../index.js');

var credstash = new Credstash();
return credstash.get('secret', { limit: 3 }, (e, secrets) => {
  console.log('this is the last version', secrets[0]);
  console.log('this is the second-last', secrets[1]);
  console.log('this is the third-last', secrets[2]);
});

If options.limit: 1 or if you don't pass the options parameters, the callback receives secret (singular). So, this change is backward compatible.

There are two things that I am not entirely convinced:

The name of the parameter limitd - Any idea for a better name?
The callback returning secret or secrets.. Maybe it should return secrets always, even when retrieving just 1.

Hi Jose,
Firstly thanks for the pull request! Just made a couple of comments above. If you could fix the versioning of xtend and remove the .jshintrc file I'm happy to merge and republish.
I'm ok with the name limit, and I think it would be better to keep backwards compatibility for now.

Done! thanks a lot

Thank you for merging this, is this released already?

Yes it is


Show Context Menu on "Select" long press.

There's a specific button for Context which already does this, it shouldn't be duplicated in another button.
Furthermore, the possibility of associating 2 actions with one button is something to be used sparingly and with care (as it hurts discoverability), and it certainly shouldn't be used in one of the "main" buttons (select + d-pad).

I agree with keeping the UI simple.
The patch replicates the long pressing functionality of Kodi (Long press Enter) and various remotes such as Yatse. Also, if you're constantly switching between Kore & a remote control (without a context button) (http://kodi.tv/kodi-16-alpha-3/) it will take some time to get used to it.

I see your point, but nevertheless i don't think that a long press should be added to the select button.
What might be worth considering is changing the select button to use the EventServer. And in the process review the way it is sending button presses to the EventServer. Then Select might send a long press, through EventServer, and that gets processed by Kodi as a normal remote. But i need to think better about this.


GROOVY-10943: Consider additional use of _ as a placeholder

This covers just multi-assignment so far. Also, it leaves the underscore as a dynamic variable for dynamic Groovy. While not recommended, if you do happen to use the underscore (in a multi-assignment for more than one underscore) later, it will be the last set value. The variable is undeclared from a static type checking point of view.

Codecov Report

Merging #1867 (81e5bb3) into master (c27927c) will increase coverage by 0.0106%.
The diff coverage is 93.3333%.

:exclamation: Current head 81e5bb3 differs from pull request most recent head 4db1f34. Consider uploading reports for the commit 4db1f34 to get more accurate results

@@                Coverage Diff                 @@
##               master      #1867        +/-   ##
==================================================
+ Coverage     68.0935%   68.1041%   +0.0105%
- Complexity      28610      28625        +15
==================================================
  Files            1427       1428         +1
  Lines          113115     113143        +28
  Branches        19338      19341         +3
==================================================
+ Hits            77024      77055        +31
  Misses          29600      29600
+ Partials         6491       6488         -3

Impacted Files
Coverage Δ

...va/org/apache/groovy/parser/antlr4/AstBuilder.java
86.8117% <80.0000%> (+0.0176%)
:arrow_up:

...rg/codehaus/groovy/control/PlaceholderVisitor.java
94.7368% <94.7368%> (ø)

...codehaus/groovy/classgen/VariableScopeVisitor.java
94.5122% <100.0000%> (+0.0337%)
:arrow_up:

...a/org/codehaus/groovy/control/CompilationUnit.java
80.6584% <100.0000%> (+0.1605%)
:arrow_up:

...vy/util/concurrent/ConcurrentReferenceHashMap.java
36.0738% <0.0000%> (+0.5034%)
:arrow_up:

...org/codehaus/groovy/vmplugin/v8/IndyInterface.java
86.0656% <0.0000%> (+0.8197%)
:arrow_up:

Support for lambda and closure parameters also added.

The underscore (_) is used in groovy.cli.commons.CommandLineInterface when there is no shortDesc . I don't think this would be an issue
ex.
			cliBuilder.with {
				// HELP OPT
				h(longOpt: 'help', 'Print this help text and exit (usage: -h, --help)')
				_(longOpt:'compress','flag used to signify compression of classes (usage: --compress)')
				_(longOpt:'decompress','flag used to signify decompression of classes (usage: --decompress)')
			}

The underscore (_) is used in groovy.cli.commons.CommandLineInterface when there is no shortDesc . I THINK this is the same usage(???)
ex.
			cliBuilder.with {
				// HELP OPT
				h(longOpt: 'help', 'Print this help text and exit (usage: -h, --help)')
				_(longOpt:'compress','flag used to signify compression of classes (usage: --compress)')
				_(longOpt:'decompress','flag used to signify decompression of classes (usage: --decompress)')
			}

... but this may be worth checking.

No change to that scenario. There are two separate method call expressions with name _ in your example.

@paulk-asert

There are two separate method call expressions with name _ in your example.

AFAIK this is following the example (works great anyway) to set it so that only 'longOpt' is available; basically sets a 'null' for a shortOpt I think(???)


FEATURE: Option for follow_current_file to follow into hidden files

Did you check the docs?

[X] I have read all the docs.

Is your feature request related to a problem? Please describe.
Sometimes I'm working in projects with folders that are hidden becaues they are in gitignore. Folders such as virtual environments with the dependencies of the project. With language servers and the go to definition feature, sometimes I do find myself jumping into those dependency folders without browsing directly to them. If I have follow_current_file enabled and have neo-tree opten, it does'nt follow me anymore into hidden folders. I don't always want to see those folders so it's good they are hidden by default, but it would be great to have an option to allow enable visibility of hidden files only if I am currently editing a hidden file. That way I can then browse around the filesystem at that place.
Describe the solution you'd like.
I think the default behavior can be the expected behavior, but I think having another option similar to leave_dirs_open to further configure it's behavior. Maybe something like follow_into_hidden or something like that.
Describe alternatives you've considered.
I'm not sure of many alternatives. The only thing I can think of is being able to make a custom event_handler but I'm not sure if there is an event for the follow_current_file getting triggered since this isn't triggered directly from browsing within neo-tree, but by navigation outside of neo-tree.
Additional Context
No response

Showing just the path to a hidden file that is currently focused would get pretty complicated, but I can see automatically toggling the "show hidden" state if the current file is in a hidden folder.
Toggling it back off again when the focus leaves might also get complicated. So I would have a a one way action that just turns on show hidden files but does not attempt to figure out if it should be turned off again. Leave that to the user.
The best way to implement this might be in a user defined event. The hardest part would be determining if a given file would be considered hidden or not.
It's not a change that I would work on personally because for me, I can just toggle hidden manually if I cared, but really I just rarely feel the need to see the tree for a file that I got to with "go to definition". I only use the tree to open, add, and delete files. I don't usually leave it open as a reference to where I am.

Yeah I think best would just be just toggling hidden. Definitely not showing just the current path just because it can end up being a bit not useful. Thanks for the ideas! This can be left open just in case someone wants to implement it or if I get some time to take a stab at it!
If I were to try to make an autocommand for this are there API points to get the necessary details? Basically the things that would be needed are:

an event that happens when the file changes and follow_current_file is triggered
an API to check if a node is currently visible or not

With that information it should be easy to just check if the current node is visible, toggle visibility, and then change it in the next event if necessary.
Thanks again!

The follow current file logic is triggered by the VIM_BUFFER_ENTER event (a constant that points to the `"vim_buffer_enter" string.)
Figuring out if a file would be hidden is difficult and there is no api to help you. This is handled along the way as the filesystem is being scanned, and then the hidden files are filtered out just before being sent to the Nui tree, and that intermediate collection of items that might be rendered is just dropped. It might require altering the internal logic to either extract out the hidden logic to a reusable utility or storing the filtered nodes in a separate collection that can be looked up.

Interesting. Thanks for the further information! This will be super useful if anyone decides to pick up trying to implement this.
Thanks for building and maintaining such a great plugin!

I kind of feel that this would be pretty useful, given the amount of dotfiles people are spitting out, and likely managing with something like stow, it makes sense to be able to follow hidden files. Especially in that use case. However, it is kind of moot if you know your dotfiles well enough. Just chiming in because I feel like this would be useful, albeit maybe not critical, feature. Neotree is great, and it's making the move from VSCode a bunch easier :smile:


Recently viewed product widget

Make a recently viewed product widget so that it can be configured to display in many places, for example the homepage

Looks like the existing recently viewed widget works in other places as-is

What exactly are you looking to do here. To add an instance of the recently viewed widget to the home page?

Add a new widget called RecentlyViewedProducts. You can look at the docs here http://docs.simplcommerce.com/en/latest/widgets/. You can see the existing widgets by going to the Admin, in the top menu choose Content --> Widgets --> Create Widgets

Sounds good. I can take this on. Do you have any specifications for the options that should be available for the widget?


W/FileDownloader.MessageSnapshotGate: callback event transfer 3, but is contains false

Hi.
I got two problems with downloading. To keep questions separate I ask first one here,
I got a lot of this debug message :
W/FileDownloader.MessageSnapshotGate: callback event transfer 3, but is contains false
W/FileDownloader.MessageSnapshotGate: callback event transfer 3, but is contains false
W/FileDownloader.MessageSnapshotGate: callback event transfer 3, but is contains false
W/FileDownloader.MessageSnapshotGate: callback event transfer 3, but is contains false
W/FileDownloader.MessageSnapshotGate: callback event transfer -3, but is contains false

What is this?

Sorry for the non-make-sense log wording, I will correct this log.

Cause
Raise this log, because the internal framework callback a event, but in the upper layer there isn't any running task, so this event can't be consumed.
Worry?
Please don't worry about this log, because there are several normal cases will raise this log.
Enhance

I will correct this log.
Alternate this log level to Debug.


Master

I've added the logic and configuration for the ExactPermalinkMatching configuration. Actually pretty simple.
Did I overlook something?

Encountered a bug.


Generating invalid postgres queries

They are pretty good. The reaosn I ask is that I have one more issue, where in my pure js (feathers generated) project, I have the user model like this:
module.exports = function (app) {
  const sequelizeClient = app.get('sequelizeClient');
  const users = sequelizeClient.define('users', {

    email: {
      type: DataTypes.STRING,
      allowNull: false,
      unique: true
    },
    password: {
      type: DataTypes.STRING,
      allowNull: false
    },
  }, {
    hooks: {
      beforeCount(options) {
        options.raw = true;
      }
    }
  });

  return users;
};

and I initialize sequelize like this:
  const sequelize = new Sequelize(connectionString, {
    dialect: 'postgres',
    logging: true,
    define: {
      freezeTableName: true
    }
  });

When I make a call to the feathers authentication API, the SQL generated is this SELECT count(DISTINCT("users"."id")) AS "count" FROM "users" AS "users" WHERE "users"."email" =<EMAIL_ADDRESS>However, in the version where I have converted to using TypeScript with your package, I am creating sequelize like this:
    const sequelize = new Sequelize({
        name: 'feathers-test',
        dialect: 'postgres',
        username: 'postgres',
        password: 'xxx',
        host: 'localhost',
        modelPaths: [__dirname + '/models'],
        define: {
            freezeTableName: true
        },
        logging: false
    });

where this is my model definition:
@Table
export default class User extends Model<User> {

  @IsEmail
  @AllowNull(false)
  @Unique
  @Column
  email: string;

  @AllowNull(false)
  @Column
  password: string;

}

However, the generated SQL for the same action is this: SELECT count(DISTINCT(*)) AS "count" FROM "User" AS "User" WHERE "User"."email" =<EMAIL_ADDRESS>Which throws error:

syntax error at or near "*"

any idea why this might be different form using your package rather than vanilla sequelize?

@RobinBuschmann moved from #131

Did you try to set the beforeCount hook in the sequelize-typescript version as well?

@RobinBuschmann yes, same result...

@RobinBuschmann Any other thoughts?

@georgeedwards I'm getting the same error with pure sequelize - strange. Which sequelize versions are you using?

I encountered the DISTINCT(*) on mysql as well. I reverted to 0.4.0 and do not observe that behavior anymore.

Strange, since I'm getting this error with pure sequelize, I assume, that this isn't a sequelize-typescript issue at all.

@RobinBuschmann I'll look into reporting it to sequelize. Mind sharing the repro you have?

Do we know on which sequelize version this happens? You said, you switched back to<EMAIL_ADDRESS>and it worked again? Are you changed the sequelize versions with that as well?

Oh wait, I revert sequelize-typescript and feathers-sequelze. I kept sequelize at 4.8.4 This is the commit of my package.json:
-    "feathers-sequelize": "2.3.1",
+    "feathers-sequelize": "2.2.1",
-    "sequelize-typescript": "0.5.0",
+    "sequelize-typescript": "0.4.0",

So that's interesting, because 4.8.4 is the latest sequelize, and that's what I've ran all my tests against. It could be feathers-sequelize.... let me run a few more tests on my project.

I just ran my tests with 0.5.0 and all are green.
I'm updating feathers-sequelize to see if I get the bug. In that case it will be feather's problem. Every test run has the latest sequelize 4.8.4 still
Woo! I repro'd the DISTINCT(*) with feathers-sequelize: 2.3.1

But the problem is that I had a cli generated app with the same sequelize (i think - can dbl check...) that did not have this bug. :(

@georgeedwards Try running your code with feathers-sequelize: 2.2.1 - does it work with the latest sequelize and sequelize-typescript with feathers-sequelize pinned to the previous stable release?
That can be a viable work around. The problem now is how does the vanilla js cli generated differ from our typescript apps

feathers-sequelize: 2.3.0 is also good. No distinct * thing. So the observed behavior, as far as I can tell, is not in plain sequelize js apps, but can only be repro'd in feathers-sequelize: 2.3.1 :\
So I looked at the commit from 2.3.0 -> 2.3.1, maybe his has something to do with it?
That commit references and is related to this code But why would our ts apps hit an execution path that the js apps don't?
@RobinBuschmann any direction you can think of? I think I've exhausted all my sleuthing abilities, and I'm not sure if I found an answer or not... I don't understand how this commit changes behavior exactly, and I don't think the include option is messed with by sequelize-typescript... feathers adds it in, but the vanilla js app seems to handle that perfectly fine.
#confused

I haven't used feather-sequelizeyet. So I would say feather-sequelize is not the cause of the error - I think, sequelize is. I will have a look ..and will try with different sequelize version.

@snewell92 Yes, using:
"sequelize-typescript": "0.5.0",
"sequelize": "4.9.0",
"feathers-sequelize": "2.2.1",

works as expected...

The find option distinct: true does not seem to work in general.
https://github.com/sequelize/sequelize/issues/6953
https://github.com/sequelize/sequelize/issues/2713

Issue is closed due to no response

@RobinBuschmann Same problem here


JAV-415 Update Spring dependency from 4.3.4.RELEASE to 4.3.5.RELEASE

Signed-off-by: MabinGo<EMAIL_ADDRESS>

Coverage remained the same at 86.05% when pulling 3ccc7dae7875469da9e483f8fb7f20f983744e14 on MabinGo:updateSpringFrameworkRelease into 8e8bffbc0fbb3289321c5a1cfefba976347bb220 on ServiceComb:master.


docs: add warning about overriding tsconfig types

Description
Added warning that setting compilerOptions.types clobbers its default value.
Additional context
Is there a CI instance where I can see what this Markdown looks like when rendered as HTML?

What is the purpose of this pull request?

[ ] Bug fix
[ ] New Feature
[x] Documentation update
[ ] Other

Before submitting the PR, please make sure you do the following

[x] Read the Contributing Guidelines.
[x] Read the Pull Request Guidelines and follow the PR Title Convention.
[x] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
[x] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
[ ] Ideally, include relevant tests that fail without this PR but pass with it.

n/a

Here's the changed page:
https://deploy-preview-14861--vite-docs-main.netlify.app/guide/features.html


Using with TpolecatModule in Scala 3.1.3 project returns bad option

I have a simple project where I added Tpolecat to my project and got the following error:
[34/34] main.compile
[info] compiling 1 Scala source to /Users/cdepaula/repos/scala-playground/ziotest/out/main/compile.dest/classes ...
[error] bad option '-Xsource:3' was ignored
[error] bad option '-migration' was ignored
[error] two errors found
1 targets failed
main.compile Compilation failed

I solved by using def scalacOptions   = T(super.scalacOptions().filterNot(Set("-Xsource:3", "-migration"))).

Are snapshots published so I can test it out?
Thanks!

I just pushed 0.3.1 it should hit Maven soon

Just tested it and it worked perfectly. Thanks!


Provide default template

It would be nice to have a default template already populated. This would make changing an already built template easier than building one myself. The default one can be similar to the Logseq Zotero one.

that's a good idea! i'll work on adding that to the next release


[Task]: Fix flaky server tests of MSSQL and Redis

SubTasks
MSSQL and Redis Junit test cases are being flaky because they tend to create docker containers in test setup process. This task to identify and solve the issue
For the time being, tests have been disabled in this PR
More info: https://www.notion.so/appsmith/20-09-Promotion-failures-107fe271b0e280099bfbdb9fdde4952d?d=916f2a64421b4f6fa9dd2128437bfc1e#ffffe271b0e281ab82e8f2c211d98be8

Moving it back in order to setup laptop


Images for both light and dark mode appear when in light mode

When viewing the site in light mode, images for both light and dark mode appear. However, only the image specified to be used in light mode should appear.

Note
When in dark mode, only the dark mode image appears, which is expected.

Can't seem to fix this issue. Added to the discussion in https://github.com/squidfunk/mkdocs-material/discussions/5596#discussioncomment-6143105.

After some more troubleshooting, I've resolved this issue as described in PR https://github.com/josh-wong/josh-wong.github.io/pull/15.


vim: :shell throws executionpolicy error

Scoop default setting:
set shell=set shell=C:\WINDOWS\System32\WindowsPowerShell\v1.0\powershell.exe

This throws an error.
This seems to fix it.:
set shell=set shell=C:\WINDOWS\System32\WindowsPowerShell\v1.0\powershell.exe\ -executionpolicy\ bypass

The error occurs when you try to use :shell, btw.

I have noticed this as well. Care to make a PR with the solution?

Sure. I'll give it a try.

Do we need to update the vim.json manifest as well to fix this?

@lukesampson Ah lol that didn't even register :)
@guillermooo Please add this to the vim.json manifest file as well.


which-key not working when localleader is set to ","

What did you expect to happen?
which-key should show the available shortcuts when I press , (my localleader), like it happens when localleader is set to default (SPC m).
What actually happened?
I got the following error in the status bar after waiting for sometime: Error running timer ‘which-key--update’: (wrong-type-argument listp evil-snipe-repeat-reverse).
Additional details:

Include a link to your private config: https://github.com/thiagokokada/dotfiles/tree/master/doom-emacs/.config/doom. But I can reproduce this commenting my whole config.el and just setting a (setq doom-localleader-key ",")

Include any warnings or errors logged to *Messages* (use M-x view-echo-area-messages to see it):

`t' Minor Mode Bindings Starting With ,:
key             binding
---             -------

Error running timer ‘which-key--update’: (wrong-type-argument listp evil-snipe-repeat-reverse)

Steps to reproduce:

Add (setq doom-localleader-key ",") to config.el
Open a file and press ,, wait until the which-key timeout occurs

System information:

SYSTEM  type       gnu/linux
        config     x86_64-pc-linux-gnu
        shell      /run/current-system/sw/bin/zsh
        uname      Linux 5.8.17 #1-NixOS SMP Thu Oct 29 09:08:31 UTC 2020 x86_64
        path       (/nix/store/1zlq72zgll2cfg19x5whfq751s2dvi5d-emacs-packages-deps/bin ~/.local/bin ~/.cargo/bin ~/.npm-packages/bin ~/Projects/RG350-buildroot/output/host/bin ~/Projects/buildroot/output/host/bin ~/.config/emacs/bin /nix/store/ygy19xf7gim44x0kvw2v37yjiabkhssg-kitty-0.18.3/bin /nix/store/96bz457g68lnbdzcr1dzrl6zcd7s0kbb-imagemagick-6.9.11-14/bin /nix/store/8cil6lql1lkq4lxlrk9d0yg0qk62sz82-xsel-unstable-2019-08-21/bin /nix/store/ncgqkpqj9gjaz6abxlwv15jpdn2nc818-ncurses-6.2-dev/bin /run/wrappers/bin ~/.nix-profile/bin /etc/profiles/per-user/$USER/bin /nix/var/nix/profiles/default/bin /run/current-system/sw/bin /nix/store/yf8p9v8kmp3aby4i4qmf0smm369cyi9c-emacs-gcc-20201105.0/libexec/emacs/28.0.50/x86_64-pc-linux-gnu)
EMACS   dir        ~/.config/emacs/
        version    28.0.50
        build      nov 07, 2020
        buildopts  --prefix=/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-emacs-gcc-20201105.0 --disable-build-details --with-modules --with-x-toolkit=gtk3 --with-xft --with-cairo --with-nativecomp CFLAGS=-DMAC_OS_X_VERSION_MAX_ALLOWED=101200
        features   XPM JPEG TIFF GIF PNG RSVG CAIRO SOUND DBUS GSETTINGS GLIB NOTIFY INOTIFY LIBSELINUX GNUTLS LIBXML2 FREETYPE HARFBUZZ M17N_FLT LIBOTF ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 XDBE XIM MODULES NATIVE_COMP THREADS LIBSYSTEMD JSON PDUMPER
        traits     (server-running)
DOOM    dir        ~/.dotfiles/doom-emacs/.config/doom/
        version    2.0.9
        build      HEAD -> develop 7205b727a 2020-11-06 21:16:04 -0500
        elc-files  0
        modules    (:completion company (ivy +fuzzy) :ui doom doom-dashboard hl-todo (modeline +light) ophints (popup +defaults +all) treemacs vc-gutter vi-tilde-fringe workspaces :editor (evil +everywhere) file-templates fold multiple-cursors snippets word-wrap :emacs dired electric undo vc :term vterm :checkers syntax :tools docker (eval +overlay) lookup lsp magit :os tty :lang cc (clojure +lsp) data (dart +flutter +lsp) elixir emacs-lisp (go +lsp) hy json markdown nim nix org (python +lsp +poetry) (ruby +rails) rust scala sh yaml :config (default +bindings +smartparens))
        packages   ((adoc-mode) (evil-escape :disable t) (flycheck-clj-kondo :disable t) (graphql-mode) (lispyville) (lsp-ui :disable t) (sort-words) (uuidgen))
        unpin      (n/a)
        elpa       (vterm)

Disabling evil-snipe works, but this still seems a bug since it used to work before (and I am not in the middle of a "snipe" during my tests).

This is known incompatibility with which-key and Emacs 28, which was fixed upstream some time ago. I've bumped which-key in 92c9127 which should fix your issue. Let me know if that isn't the case and I'll reopen it. Thanks!

@hlissner Still the same issue sadly.
SYSTEM  type       gnu/linux
        config     x86_64-pc-linux-gnu
        shell      /run/current-system/sw/bin/zsh
        uname      Linux 5.8.17 #1-NixOS SMP Thu Oct 29 09:08:31 UTC 2020 x86_64
        path       (/nix/store/1zlq72zgll2cfg19x5whfq751s2dvi5d-emacs-packages-deps/bin ~/.local/bin ~/.cargo/bin ~/.npm-packages/bin ~/Projects/RG350-buildroot/output/host/bin ~/Projects/buildroot/output/host/bin ~/.config/emacs/bin /nix/store/ygy19xf7gim44x0kvw2v37yjiabkhssg-kitty-0.18.3/bin /nix/store/96bz457g68lnbdzcr1dzrl6zcd7s0kbb-imagemagick-6.9.11-14/bin /nix/store/8cil6lql1lkq4lxlrk9d0yg0qk62sz82-xsel-unstable-2019-08-21/bin /nix/store/ncgqkpqj9gjaz6abxlwv15jpdn2nc818-ncurses-6.2-dev/bin /run/wrappers/bin ~/.nix-profile/bin /etc/profiles/per-user/$USER/bin /nix/var/nix/profiles/default/bin /run/current-system/sw/bin /nix/store/yf8p9v8kmp3aby4i4qmf0smm369cyi9c-emacs-gcc-20201105.0/libexec/emacs/28.0.50/x86_64-pc-linux-gnu)
EMACS   dir        ~/.config/emacs/
        version    28.0.50
        build      nov 07, 2020
        buildopts  --prefix=/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-emacs-gcc-20201105.0 --disable-build-details --with-modules --with-x-toolkit=gtk3 --with-xft --with-cairo --with-nativecomp CFLAGS=-DMAC_OS_X_VERSION_MAX_ALLOWED=101200
        features   XPM JPEG TIFF GIF PNG RSVG CAIRO SOUND DBUS GSETTINGS GLIB NOTIFY INOTIFY LIBSELINUX GNUTLS LIBXML2 FREETYPE HARFBUZZ M17N_FLT LIBOTF ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 XDBE XIM MODULES NATIVE_COMP THREADS LIBSYSTEMD JSON PDUMPER
        traits     (server-running)
DOOM    dir        ~/.dotfiles/doom-emacs/.config/doom/
        version    2.0.9
        build      HEAD -> develop 92c9127b8 2020-11-07 00:20:07 -0500
        elc-files  0
        modules    (:completion company (ivy +fuzzy) :ui doom doom-dashboard hl-todo (modeline +light) ophints (popup +defaults +all) treemacs vc-gutter vi-tilde-fringe workspaces :editor (evil +everywhere) file-templates fold multiple-cursors snippets word-wrap :emacs dired electric undo vc :term vterm :checkers syntax :tools docker (eval +overlay) lookup lsp magit :os tty :lang cc (clojure +lsp) data (dart +flutter +lsp) elixir emacs-lisp (go +lsp) hy json markdown nim nix org (python +lsp +poetry) (ruby +rails) rust scala sh yaml :config (default +bindings +smartparens))
        packages   ((adoc-mode) (evil-escape :disable t) (flycheck-clj-kondo :disable t) (graphql-mode) (lispyville) (lsp-ui :disable t) (sort-words) (uuidgen))
        unpin      (n/a)
        elpa       (vterm)

BTW, if Emacs 28 issues are not valid you can keep this close. I don't think this is a big bug anyway.


DB Migration - SQL DB not SQL MI

There is a discrepancy in this article on the type of SQL resource deployed in the solution.
The Proposed Solution calls out Azure SQL DB as the resource
https://docs.microsoft.com/en-us/azure/cloud-adoption-framework/migrate/azure-best-practices/contoso-migration-refactor-web-app-sql#proposed-solution
Later in the Migration Process you note "Contoso provisions an Azure SQL managed instance". Assuming the reference architecture diagram above is correct, you're showing an Azure SQL DB and you should be stating "Contoso provisions an Azure SQL Database"
https://docs.microsoft.com/en-us/azure/cloud-adoption-framework/migrate/azure-best-practices/contoso-migration-refactor-web-app-sql#migration-process

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 793c08e6-c592-7530-92df-6b0a8f1a4b02
Version Independent ID: cb833a2c-e428-732e-cce4-2b09c663c98f
Content: Migrate an application to Azure App Service and SQL Database - Cloud Adoption Framework
Content Source: docs/migrate/azure-best-practices/contoso-migration-refactor-web-app-sql.md
Service: cloud-adoption-framework
Sub-service: migrate
GitHub Login: @BrianBlanchard
Microsoft Alias: brblanch

#please-close


Simplify logic in TakeLastOperator.onNext

It was a quick thought I had when reading the code

Thanks.


Prevent maintaining same Jinja2 templates twice

Issue Type

Template enhancement

As of now templates are duplicated (with minor changes) in https://github.com/aristanetworks/ansible-avd/tree/devel/ansible_collections/arista/avd/roles/eos_cli_config_gen/templates
Would it not be better to have single j2 templates where additional documentation statements are rendered based on specific flag. As of now any change needs to be implemented twice (under eos and documentation).

@mpergament I feel like combining them would make them more cluttered. And in general, these templates are quite different. eos templates generate the eos configuration, and the documentation create table(s) to represent the configuration. The logic is not the same.
Take for example route-bgp template, IMHO combining them would make it larger and harder to maintain.
eos: https://github.com/aristanetworks/ansible-avd/blob/devel/ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/eos/router-bgp.j2
documentation: https://github.com/aristanetworks/ansible-avd/blob/devel/ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/documentation/router-bgp.j2
@aphillipps, any thoughts as you have been a major contributor to the eos_cli_config_gen role?

Hi Carl, i understand they have a different roles but doc template is 100% dependent on config template. I guess what will happen with the time that config template will be updated but doc one will be not. They will deviate with the time causing confusion. So perhaps we can find a smart way to have root jinja2 template only once (and not twice). Just my 2c.

Michael,
I understand what you are saying about keeping the documentation in sync
with the configuration templates. But I think that it is the role of the
AVD maintainers to make sure everything stays consistent and synchronized.
Merging the 2 templates in one will make these templates too long and thus
more difficult to read, troubleshoot and update. Today, when there is an
error in the templates, you know right away if it is in the documentation
or the configuration when you execute the playbook which comes really handy
for troubleshooting. The fewer lines, the faster you spot the issue.
Moreover some customers customize our templates and some could choose to
only customize the documentation part to reflect the company policy and the
structure they want for their documentation.
I think that keeping them seperate brings more benefits and it makes them
more versatile even though that means that we must pay attention to
synchronizing them.
On Tue, Jul 7, 2020 at 2:21 PM Michael Pergament<EMAIL_ADDRESS>wrote:

Hi Carl, i understand they have a different roles but doc template is 100%
dependent on config template. I guess what will happen with the time that
config template will be updated but doc one will be not. They will deviate
with the time causing confusion. So perhaps we can find a smart way to have
root jinja2 template only once (and not twice). Just my 2c.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/aristanetworks/ansible-avd/issues/179#issuecomment-654817701,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AIYHGTXHVNREM2SX52LEVYDR2MHOLANCNFSM4ONPNLDA
.


Does not compile with JDK9-11

Currently, it builds only with JDK8 (and uses Java 1.6 as its source/target compatibility level).
We really need to upgrade/migrate Paxtools project configuration (POM) to make it possible at least to build with JDK9-11, a.s.a.p. And we should also increase the compatibility level to Java 1.8.
PS: I've successfully done this for other projects already, e.g., cpath2 and validator.

Better upgrade to use OpenJDK-15

I am working on generating BioPax for Reactome. We upgraded most of our code to run off of Java 11. I am running into runtime errors with our code for generating BioPax files using Java 11 with the latest validator release (4.0.0). Whereas when we use Java 6, it runs without error. Is this ticket correct that 4.0.0 doesn't work with Java 11? And if so, would it be possible to get Igors changes pulled into a release if they fix the issue?

Can now build with JDK18


issue in CLI competitions leaderboard download for stream contents

When use CLI kaggle competitions leaderboard favorita-grocery-sales-forecasting -d it returns stream data and it raises a key error on size = int(response.headers['Content-Length']) because the server doesn't return Content-Length in headers.
Added a pull request to handle this exception for downloading leaderboard: https://github.com/Kaggle/kaggle-api/pull/354

@pizzaz93 Any suggestion?

I fixed the Kaggle endpoint used for the leaderboard request so that it properly returns a Content-Length.


feat(MeasureTheory/Constructions/BorelSpace/Basic): add Homeomorph.borelSpace_of_measurableEquiv

Add a lemma which lets one recognize a BorelSpace by seeing that some map to another BorelSpace is both a homeomorphism and a measurable equivalence.

Would it be enough to have a topological embedding which is also a measurable embedding?

You are correct, and your comment alerted me to MeasurableEmbedding.borelSpace. Since this is already more general than what I was adding, I will delete


Initial commit of Python starter package rewrite.

I just dropped in everything verbatim from my alt-starter-package.

I'm not sure which of the changes is the most important driver of the speedups.  To demonstrate the speed improvements, I've attached two timing logs of the ImprovedBot.py (aka NorthWestBot.py), one based on the tutorial on website, and the other as translated for the alt-starter.  I then ran:
./halite -q -d "50 50" -s 123456789 "python3 ImprovedBot.py"
The logs show milliseconds used per turn, and suggests 4x speedup on this starter bot logic.  I think users will see even greater speedup multiples with more complicated logic.
OfficialPkg-ImprovedBot.log.txt
AltPkg-ImprovedBot.log.txt

Could you remove all non-random bots (AmbiturnerBot.py, ImprovedBot.py, etc)

@Sydriax will rewrite the improving the random bot sections to use this starter package. I'll look into travis. Then we should be good to merge.

Oh and also we need to edit the README.

@Sydriax, I rewrote the gist's from the "Improving the RandomBot" section, if you'd like to use them:
https://gist.github.com/erdman
I'll revise the README.

@Sydriax, know you guys are busy, so I took a first cut at updating the "How to Improve the RandomBot" php web page for you.  Please revise as you see fit.

Thanks so much for that!

There's an error in Revision4.py. Use use location when you mean square.

Have fixed tests locally so should be good to merge after that.

There's an error in Revision4.py. Use use location when you mean square.

Fixed.


How to update logo ?

I'm submitting a ...
[ ] bug report
[ ] feature request
[ ] question about the decisions made in the repository
[x] question about how to use this project

Summary
I can't figure out how to update the logo, i get the automerge error every time i open a PR. Can someone post a little guide or tutorial on how to make changes in here ?

the thing i do is to simply fork token-list in github desktop, update the logo file in the asset folder of my token and then push to origin but this is not working.

Other information (e.g. detailed explanation, stack traces, related issues, suggestions how to fix, links for us to have context, eg. StackOverflow, personal fork, etc.):

the thing i do is to simply fork token-list in github desktop, update the logo file in the asset folder of my token and then push to origin but this is not working.

here the PR when i added the token to token list: #21163
here the PR of me trying to update the image in the assets folder: #22336

merged


added victoria metrics url auto discovery

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Artifact when rendering large numbers of overlapping paths

I'm seeing artifacts when rendering scenes with large numbers of paths that overlap. It looks like it's related to the renderer's tiles somehow but it isn't strictly a paths per tile issue (see the third image). Here's the roof from the canvas_minimal example drawn on top of itself thousands of times:

Obviously that's a pathological case but the artifacts start to show up with a much smaller number of overlaps (30 in this case):

I'm seeing it in real use as well where complex objects are drawn on top of other paths:

The bottom half of the screen in that example should be solid black but instead has lines of sky color showing through. That also shows the artifact in tiles which don't actually contain a large number of paths, like the ground on the right edge where there should just be two paths overlapping, one for the sky and one for the ground.
The code I used to produce the top two images: https://gist.github.com/alec-deason/2518dfce805c8222ab96c7c336336555
The only issue I could find that looks similar is the lines shown here: https://github.com/servo/pathfinder/issues/284#issuecomment-597564528_
I'm seeing this in both the GL and WebGL renderers on an Intel GPU on Linux and latest commit to pathfinder.

Sorry, I mispoke in the description. The sky in the last picture is not a path, it's just the clear color. So what's showing through the ground is the clear color not another path. That seems like it might be an important distinction.

Yeah, the problem is that when overflow the mask texture the resizing is currently buggy for one frame (that's the first and third images).

Oh, lovely.  I still see the faint vertical lines in the second example but that isn't actually a problem in my use case.
Is there a way to preallocate if I know what I'm going to need? Skimming through the code, I don't see anything obvious.

It's impossible to predict how big the textures are. We just need to fix the bug.

Ok, makes sense. Thanks.

This is the D3D11 mode, right?

I was requesting a GL3.0 context from surfman, which I think puts me in D3D10. I just tried it again requesting a GL4.0 context and see the same artifacts.

https://github.com/servo/pathfinder/pull/418 fixes the biggest problems here. 1-character fix :)
The remaining issue with the 1-pixel-wide vertical lines seems to be caused by accumulation of floating-point error. I had worried that it indicated a fundamental problem with the lookup table approach for area, but I don't think it does, because if it did it wouldn't be a vertical line and would manifest itself only with lines of a certain slope, rather than all lines. So it's probably some subtle bug, not something fundamental.

That's the best kind of fix. And it resolves the main issue for me. Thanks!


Request for supporting compiling on OSX

There are warnings by compilation on OSX using clang:

Apple LLVM version 8.1.0 (clang-802.0.42)
Target: x86_64-apple-darwin16.7.0

Please fix if possible
primitives/transaction.cpp:277:35: warning: '&&' within '||' [-Wlogical-op-parentheses]
    if(outputBlockHeight<TWOYEARS && chainHeight < FORK1HEIGHT || outputBlockHeight < FORK1HEIGHT)
       ~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~~
primitives/transaction.cpp:277:35: note: place parentheses around the '&&' expression to silence this warning
    if(outputBlockHeight<TWOYEARS && chainHeight < FORK1HEIGHT || outputBlockHeight < FORK1HEIGHT)
                                  ^
       (                                                      )
1 warning generated.
primitives/transaction.cpp:277:35: warning: '&&' within '||' [-Wlogical-op-parentheses]
    if(outputBlockHeight<TWOYEARS && chainHeight < FORK1HEIGHT || outputBlockHeight < FORK1HEIGHT)
       ~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~~
primitives/transaction.cpp:277:35: note: place parentheses around the '&&' expression to silence this warning
    if(outputBlockHeight<TWOYEARS && chainHeight < FORK1HEIGHT || outputBlockHeight < FORK1HEIGHT)
                                  ^
       (                                                      )
1 warning generated.
script/sign.cpp:217:13: warning: enumeration value 'TX_CHECKLOCKTIMEVERIFY' not handled in switch [-Wswitch]
    switch (txType)
            ^
1 warning generated.
In file included from helpers/memenv/memenv.cc:9:
In file included from ./port/port.h:14:
In file included from ./port/port_posix.h:47:
./port/atomic_pointer.h:55:3: warning: 'OSMemoryBarrier' is deprecated: first deprecated in macOS 10.12 - Use std::atomic_thread_fence() from <atomic> instead [-Wdeprecated-declarations]
  OSMemoryBarrier();
  ^
/usr/include/libkern/OSAtomicDeprecated.h:749:9: note: 'OSMemoryBarrier' has been explicitly marked deprecated here
void    OSMemoryBarrier( void );
        ^
1 warning generated.
ar: creating archive libmemenv.a
In file included from db/builder.cc:7:
In file included from ./db/filename.h:14:
In file included from ./port/port.h:14:
In file included from ./port/port_posix.h:47:
./port/atomic_pointer.h:55:3: warning: 'OSMemoryBarrier' is deprecated: first deprecated in macOS 10.12 - Use std::atomic_thread_fence() from <atomic> instead [-Wdeprecated-declarations]
  OSMemoryBarrier();
  ^
/usr/include/libkern/OSAtomicDeprecated.h:749:9: note: 'OSMemoryBarrier' has been explicitly marked deprecated here
void    OSMemoryBarrier( void );
        ^
1 warning generated.
In file included from db/db_iter.cc:5:
In file included from ./db/db_iter.h:10:
In file included from ./db/dbformat.h:14:
In file included from ./util/coding.h:17:
In file included from ./port/port.h:14:
In file included from ./port/port_posix.h:47:
./port/atomic_pointer.h:55:3: warning: 'OSMemoryBarrier' is deprecated: first deprecated in macOS 10.12 - Use std::atomic_thread_fence() from <atomic> instead [-Wdeprecated-declarations]
  OSMemoryBarrier();
  ^
/usr/include/libkern/OSAtomicDeprecated.h:749:9: note: 'OSMemoryBarrier' has been explicitly marked deprecated here
void    OSMemoryBarrier( void );
        ^
1 warning generated.
In file included from db/dbformat.cc:6:
In file included from ./db/dbformat.h:14:
In file included from ./util/coding.h:17:
In file included from ./port/port.h:14:
In file included from ./port/port_posix.h:47:
./port/atomic_pointer.h:55:3: warning: 'OSMemoryBarrier' is deprecated: first deprecated in macOS 10.12 - Use std::atomic_thread_fence() from <atomic> instead [-Wdeprecated-declarations]
  OSMemoryBarrier();
  ^
/usr/include/libkern/OSAtomicDeprecated.h:749:9: note: 'OSMemoryBarrier' has been explicitly marked deprecated here
void    OSMemoryBarrier( void );
        ^
1 warning generated.
In file included from db/filename.cc:7:
In file included from ./db/filename.h:14:
In file included from ./port/port.h:14:
In file included from ./port/port_posix.h:47:
./port/atomic_pointer.h:55:3: warning: 'OSMemoryBarrier' is deprecated: first deprecated in macOS 10.12 - Use std::atomic_thread_fence() from <atomic> instead [-Wdeprecated-declarations]
  OSMemoryBarrier();
  ^
/usr/include/libkern/OSAtomicDeprecated.h:749:9: note: 'OSMemoryBarrier' has been explicitly marked deprecated here
void    OSMemoryBarrier( void );
        ^
1 warning generated.
In file included from db/dumpfile.cc:6:
In file included from ./db/dbformat.h:14:
In file included from ./util/coding.h:17:
In file included from ./port/port.h:14:
In file included from ./port/port_posix.h:47:
./port/atomic_pointer.h:55:3: warning: 'OSMemoryBarrier' is deprecated: first deprecated in macOS 10.12 - Use std::atomic_thread_fence() from <atomic> instead [-Wdeprecated-declarations]
  OSMemoryBarrier();
  ^
/usr/include/libkern/OSAtomicDeprecated.h:749:9: note: 'OSMemoryBarrier' has been explicitly marked deprecated here
void    OSMemoryBarrier( void );
        ^
1 warning generated.
In file included from db/log_reader.cc:9:
In file included from ./util/coding.h:17:
In file included from ./port/port.h:14:
In file included from ./port/port_posix.h:47:
./port/atomic_pointer.h:55:3: warning: 'OSMemoryBarrier' is deprecated: first deprecated in macOS 10.12 - Use std::atomic_thread_fence() from <atomic> instead [-Wdeprecated-declarations]
  OSMemoryBarrier();
  ^
/usr/include/libkern/OSAtomicDeprecated.h:749:9: note: 'OSMemoryBarrier' has been explicitly marked deprecated here
void    OSMemoryBarrier( void );
        ^
1 warning generated.
In file included from db/log_writer.cc:9:
In file included from ./util/coding.h:17:
In file included from ./port/port.h:14:
In file included from ./port/port_posix.h:47:
./port/atomic_pointer.h:55:3: warning: 'OSMemoryBarrier' is deprecated: first deprecated in macOS 10.12 - Use std::atomic_thread_fence() from <atomic> instead [-Wdeprecated-declarations]
  OSMemoryBarrier();
  ^
/usr/include/libkern/OSAtomicDeprecated.h:749:9: note: 'OSMemoryBarrier' has been explicitly marked deprecated here
void    OSMemoryBarrier( void );
        ^
1 warning generated.
/opt/local/bin/ranlib: file: libroicoin_util.a(libroicoin_util_a-strnlen.o) has no symbols
/opt/local/bin/ranlib: file: libroicoin_util.a(libroicoin_util_a-strnlen.o) has no symbols
In file included from db/memtable.cc:5:
In file included from ./db/memtable.h:10:
In file included from ./db/dbformat.h:14:
In file included from ./util/coding.h:17:
In file included from ./port/port.h:14:
In file included from ./port/port_posix.h:47:
./port/atomic_pointer.h:55:3: warning: 'OSMemoryBarrier' is deprecated: first deprecated in macOS 10.12 - Use std::atomic_thread_fence() from <atomic> instead [-Wdeprecated-declarations]
  OSMemoryBarrier();
  ^
/usr/include/libkern/OSAtomicDeprecated.h:749:9: note: 'OSMemoryBarrier' has been explicitly marked deprecated here
void    OSMemoryBarrier( void );
        ^
1 warning generated.
In file included from db/table_cache.cc:5:
In file included from ./db/table_cache.h:12:
In file included from ./db/dbformat.h:14:
In file included from ./util/coding.h:17:
In file included from ./port/port.h:14:
In file included from ./port/port_posix.h:47:
./port/atomic_pointer.h:55:3: warning: 'OSMemoryBarrier' is deprecated: first deprecated in macOS 10.12 - Use std::atomic_thread_fence() from <atomic> instead [-Wdeprecated-declarations]
  OSMemoryBarrier();
  ^
/usr/include/libkern/OSAtomicDeprecated.h:749:9: note: 'OSMemoryBarrier' has been explicitly marked deprecated here
void    OSMemoryBarrier( void );
        ^
1 warning generated.
In file included from db/db_impl.cc:5:
In file included from ./db/db_impl.h:10:
In file included from ./db/dbformat.h:14:
In file included from ./util/coding.h:17:
In file included from ./port/port.h:14:
In file included from ./port/port_posix.h:47:
./port/atomic_pointer.h:55:3: warning: 'OSMemoryBarrier' is deprecated: first deprecated in macOS 10.12 - Use std::atomic_thread_fence() from <atomic> instead [-Wdeprecated-declarations]
  OSMemoryBarrier();
  ^
/usr/include/libkern/OSAtomicDeprecated.h:749:9: note: 'OSMemoryBarrier' has been explicitly marked deprecated here
void    OSMemoryBarrier( void );
        ^
1 warning generated.
clang: warning: argument unused during compilation: '-pthread' [-Wunused-command-line-argument]
clang: warning: argument unused during compilation: '-pthread' [-Wunused-command-line-argument]
In file included from db/version_edit.cc:5:
In file included from ./db/version_edit.h:11:
In file included from ./db/dbformat.h:14:
In file included from ./util/coding.h:17:
In file included from ./port/port.h:14:
In file included from ./port/port_posix.h:47:
./port/atomic_pointer.h:55:3: warning: 'OSMemoryBarrier' is deprecated: first deprecated in macOS 10.12 - Use std::atomic_thread_fence() from <atomic> instead [-Wdeprecated-declarations]
  OSMemoryBarrier();
  ^
/usr/include/libkern/OSAtomicDeprecated.h:749:9: note: 'OSMemoryBarrier' has been explicitly marked deprecated here
void    OSMemoryBarrier( void );
        ^
1 warning generated.
In file included from db/repair.cc:28:
In file included from ./db/db_impl.h:10:
In file included from ./db/dbformat.h:14:
In file included from ./util/coding.h:17:
In file included from ./port/port.h:14:
In file included from ./port/port_posix.h:47:
./port/atomic_pointer.h:55:3: warning: 'OSMemoryBarrier' is deprecated: first deprecated in macOS 10.12 - Use std::atomic_thread_fence() from <atomic> instead [-Wdeprecated-declarations]
  OSMemoryBarrier();
  ^
/usr/include/libkern/OSAtomicDeprecated.h:749:9: note: 'OSMemoryBarrier' has been explicitly marked deprecated here
void    OSMemoryBarrier( void );
        ^
1 warning generated.
In file included from db/write_batch.cc:19:
In file included from ./db/dbformat.h:14:
In file included from ./util/coding.h:17:
In file included from ./port/port.h:14:
In file included from ./port/port_posix.h:47:
./port/atomic_pointer.h:55:3: warning: 'OSMemoryBarrier' is deprecated: first deprecated in macOS 10.12 - Use std::atomic_thread_fence() from <atomic> instead [-Wdeprecated-declarations]
  OSMemoryBarrier();
  ^
/usr/include/libkern/OSAtomicDeprecated.h:749:9: note: 'OSMemoryBarrier' has been explicitly marked deprecated here
void    OSMemoryBarrier( void );
        ^
1 warning generated.
In file included from table/block.cc:13:
In file included from ./util/coding.h:17:
In file included from ./port/port.h:14:
In file included from ./port/port_posix.h:47:
./port/atomic_pointer.h:55:3: warning: 'OSMemoryBarrier' is deprecated: first deprecated in macOS 10.12 - Use std::atomic_thread_fence() from <atomic> instead [-Wdeprecated-declarations]
  OSMemoryBarrier();
  ^
/usr/include/libkern/OSAtomicDeprecated.h:749:9: note: 'OSMemoryBarrier' has been explicitly marked deprecated here
void    OSMemoryBarrier( void );
        ^
1 warning generated.
In file included from db/version_set.cc:5:
In file included from ./db/version_set.h:21:
In file included from ./db/dbformat.h:14:
In file included from ./util/coding.h:17:
In file included from ./port/port.h:14:
In file included from ./port/port_posix.h:47:
./port/atomic_pointer.h:55:3: warning: 'OSMemoryBarrier' is deprecated: first deprecated in macOS 10.12 - Use std::atomic_thread_fence() from <atomic> instead [-Wdeprecated-declarations]
  OSMemoryBarrier();
  ^
/usr/include/libkern/OSAtomicDeprecated.h:749:9: note: 'OSMemoryBarrier' has been explicitly marked deprecated here
void    OSMemoryBarrier( void );
        ^
1 warning generated.
In file included from table/block_builder.cc:35:
In file included from ./util/coding.h:17:
In file included from ./port/port.h:14:
In file included from ./port/port_posix.h:47:
./port/atomic_pointer.h:55:3: warning: 'OSMemoryBarrier' is deprecated: first deprecated in macOS 10.12 - Use std::atomic_thread_fence() from <atomic> instead [-Wdeprecated-declarations]
  OSMemoryBarrier();
  ^
/usr/include/libkern/OSAtomicDeprecated.h:749:9: note: 'OSMemoryBarrier' has been explicitly marked deprecated here
void    OSMemoryBarrier( void );
        ^
1 warning generated.
In file included from table/filter_block.cc:8:
In file included from ./util/coding.h:17:
In file included from ./port/port.h:14:
In file included from ./port/port_posix.h:47:
./port/atomic_pointer.h:55:3: warning: 'OSMemoryBarrier' is deprecated: first deprecated in macOS 10.12 - Use std::atomic_thread_fence() from <atomic> instead [-Wdeprecated-declarations]
  OSMemoryBarrier();
  ^
/usr/include/libkern/OSAtomicDeprecated.h:749:9: note: 'OSMemoryBarrier' has been explicitly marked deprecated here
void    OSMemoryBarrier( void );
        ^
1 warning generated.
In file included from table/format.cc:8:
In file included from ./port/port.h:14:
In file included from ./port/port_posix.h:47:
./port/atomic_pointer.h:55:3: warning: 'OSMemoryBarrier' is deprecated: first deprecated in macOS 10.12 - Use std::atomic_thread_fence() from <atomic> instead [-Wdeprecated-declarations]
  OSMemoryBarrier();
  ^
/usr/include/libkern/OSAtomicDeprecated.h:749:9: note: 'OSMemoryBarrier' has been explicitly marked deprecated here
void    OSMemoryBarrier( void );
        ^
1 warning generated.
In file included from table/table.cc:16:
In file included from ./util/coding.h:17:
In file included from ./port/port.h:14:
In file included from ./port/port_posix.h:47:
./port/atomic_pointer.h:55:3: warning: 'OSMemoryBarrier' is deprecated: first deprecated in macOS 10.12 - Use std::atomic_thread_fence() from <atomic> instead [-Wdeprecated-declarations]
  OSMemoryBarrier();
  ^
/usr/include/libkern/OSAtomicDeprecated.h:749:9: note: 'OSMemoryBarrier' has been explicitly marked deprecated here
void    OSMemoryBarrier( void );
        ^
1 warning generated.
In file included from table/table_builder.cc:15:
In file included from ./util/coding.h:17:
In file included from ./port/port.h:14:
In file included from ./port/port_posix.h:47:
./port/atomic_pointer.h:55:3: warning: 'OSMemoryBarrier' is deprecated: first deprecated in macOS 10.12 - Use std::atomic_thread_fence() from <atomic> instead [-Wdeprecated-declarations]
  OSMemoryBarrier();
  ^
/usr/include/libkern/OSAtomicDeprecated.h:749:9: note: 'OSMemoryBarrier' has been explicitly marked deprecated here
void    OSMemoryBarrier( void );
        ^
1 warning generated.
In file included from util/cache.cc:10:
In file included from ./port/port.h:14:
In file included from ./port/port_posix.h:47:
./port/atomic_pointer.h:55:3: warning: 'OSMemoryBarrier' is deprecated: first deprecated in macOS 10.12 - Use std::atomic_thread_fence() from <atomic> instead [-Wdeprecated-declarations]
  OSMemoryBarrier();
  ^
/usr/include/libkern/OSAtomicDeprecated.h:749:9: note: 'OSMemoryBarrier' has been explicitly marked deprecated here
void    OSMemoryBarrier( void );
        ^
1 warning generated.
In file included from util/coding.cc:5:
In file included from ./util/coding.h:17:
In file included from ./port/port.h:14:
In file included from ./port/port_posix.h:47:
./port/atomic_pointer.h:55:3: warning: 'OSMemoryBarrier' is deprecated: first deprecated in macOS 10.12 - Use std::atomic_thread_fence() from <atomic> instead [-Wdeprecated-declarations]
  OSMemoryBarrier();
  ^
/usr/include/libkern/OSAtomicDeprecated.h:749:9: note: 'OSMemoryBarrier' has been explicitly marked deprecated here
void    OSMemoryBarrier( void );
        ^
1 warning generated.
In file included from util/comparator.cc:9:
In file included from ./port/port.h:14:
In file included from ./port/port_posix.h:47:
./port/atomic_pointer.h:55:3: warning: 'OSMemoryBarrier' is deprecated: first deprecated in macOS 10.12 - Use std::atomic_thread_fence() from <atomic> instead [-Wdeprecated-declarations]
  OSMemoryBarrier();
  ^
/usr/include/libkern/OSAtomicDeprecated.h:749:9: note: 'OSMemoryBarrier' has been explicitly marked deprecated here
void    OSMemoryBarrier( void );
        ^
1 warning generated.
In file included from util/crc32c.cc:11:
In file included from ./util/coding.h:17:
In file included from ./port/port.h:14:
In file included from ./port/port_posix.h:47:
./port/atomic_pointer.h:55:3: warning: 'OSMemoryBarrier' is deprecated: first deprecated in macOS 10.12 - Use std::atomic_thread_fence() from <atomic> instead [-Wdeprecated-declarations]
  OSMemoryBarrier();
  ^
/usr/include/libkern/OSAtomicDeprecated.h:749:9: note: 'OSMemoryBarrier' has been explicitly marked deprecated here
void    OSMemoryBarrier( void );
        ^
1 warning generated.
In file included from util/env_posix.cc:23:
In file included from ./port/port.h:14:
In file included from ./port/port_posix.h:47:
./port/atomic_pointer.h:55:3: warning: 'OSMemoryBarrier' is deprecated: first deprecated in macOS 10.12 - Use std::atomic_thread_fence() from <atomic> instead [-Wdeprecated-declarations]
  OSMemoryBarrier();
  ^
/usr/include/libkern/OSAtomicDeprecated.h:749:9: note: 'OSMemoryBarrier' has been explicitly marked deprecated here
void    OSMemoryBarrier( void );
        ^
1 warning generated.
In file included from util/hash.cc:6:
In file included from ./util/coding.h:17:
In file included from ./port/port.h:14:
In file included from ./port/port_posix.h:47:
./port/atomic_pointer.h:55:3: warning: 'OSMemoryBarrier' is deprecated: first deprecated in macOS 10.12 - Use std::atomic_thread_fence() from <atomic> instead [-Wdeprecated-declarations]
  OSMemoryBarrier();
  ^
/usr/include/libkern/OSAtomicDeprecated.h:749:9: note: 'OSMemoryBarrier' has been explicitly marked deprecated here
void    OSMemoryBarrier( void );
        ^
1 warning generated.
In file included from util/histogram.cc:7:
In file included from ./port/port.h:14:
In file included from ./port/port_posix.h:47:
./port/atomic_pointer.h:55:3: warning: 'OSMemoryBarrier' is deprecated: first deprecated in macOS 10.12 - Use std::atomic_thread_fence() from <atomic> instead [-Wdeprecated-declarations]
  OSMemoryBarrier();
  ^
/usr/include/libkern/OSAtomicDeprecated.h:749:9: note: 'OSMemoryBarrier' has been explicitly marked deprecated here
void    OSMemoryBarrier( void );
        ^
1 warning generated.
In file included from util/logging.cc:5:
In file included from ./util/logging.h:14:
In file included from ./port/port.h:14:
In file included from ./port/port_posix.h:47:
./port/atomic_pointer.h:55:3: warning: 'OSMemoryBarrier' is deprecated: first deprecated in macOS 10.12 - Use std::atomic_thread_fence() from <atomic> instead [-Wdeprecated-declarations]
  OSMemoryBarrier();
  ^
/usr/include/libkern/OSAtomicDeprecated.h:749:9: note: 'OSMemoryBarrier' has been explicitly marked deprecated here
void    OSMemoryBarrier( void );
        ^
1 warning generated.
qt/notificator.cpp:66:27: warning: 'LSGetApplicationForInfo' is deprecated: first deprecated in macOS 10.10 - Use LSCopyDefaultApplicationURLForContentType instead. [-Wdeprecated-declarations]
        OSStatus status = LSGetApplicationForInfo(kLSUnknownType, kLSUnknownCreator, CFSTR("growlTicket"), kLSRolesAll, 0, &cfurl);
                          ^
/System/Library/Frameworks/CoreServices.framework/Frameworks/LaunchServices.framework/Headers/LSInfoDeprecated.h:631:1: note: 'LSGetApplicationForInfo' has been explicitly marked deprecated here
LSGetApplicationForInfo(
^
1 warning generated.
In file included from util/status.cc:6:
In file included from ./port/port.h:14:
In file included from ./port/port_posix.h:47:
./port/atomic_pointer.h:55:3: warning: 'OSMemoryBarrier' is deprecated: first deprecated in macOS 10.12 - Use std::atomic_thread_fence() from <atomic> instead [-Wdeprecated-declarations]
  OSMemoryBarrier();
  ^
/usr/include/libkern/OSAtomicDeprecated.h:749:9: note: 'OSMemoryBarrier' has been explicitly marked deprecated here
void    OSMemoryBarrier( void );
        ^
1 warning generated.
In file included from port/port_posix.cc:5:
In file included from ./port/port_posix.h:47:
./port/atomic_pointer.h:55:3: warning: 'OSMemoryBarrier' is deprecated: first deprecated in macOS 10.12 - Use std::atomic_thread_fence() from <atomic> instead [-Wdeprecated-declarations]
  OSMemoryBarrier();
  ^
/usr/include/libkern/OSAtomicDeprecated.h:749:9: note: 'OSMemoryBarrier' has been explicitly marked deprecated here
void    OSMemoryBarrier( void );
        ^
1 warning generated.
ar: creating archive libleveldb.a
/opt/local/bin/ranlib: file: libleveldb.a(env_win.o) has no symbols
qt/guiutil.cpp:737:31: warning: 'LSSharedFileListCopySnapshot' is deprecated: first deprecated in macOS 10.11 - This functionality is no longer supported on OS X. [-Wdeprecated-declarations]
    CFArrayRef listSnapshot = LSSharedFileListCopySnapshot(list, NULL);
                              ^
/System/Library/Frameworks/CoreServices.framework/Frameworks/SharedFileList.framework/Headers/LSSharedFileList.h:617:1: note: 'LSSharedFileListCopySnapshot' has been explicitly marked deprecated here
LSSharedFileListCopySnapshot(
^
qt/guiutil.cpp:744:9: warning: 'LSSharedFileListItemCopyResolvedURL' is deprecated: first deprecated in macOS 10.11 [-Wdeprecated-declarations]
    if(&LSSharedFileListItemCopyResolvedURL)
        ^
/System/Library/Frameworks/CoreServices.framework/Frameworks/SharedFileList.framework/Headers/LSSharedFileList.h:980:1: note: 'LSSharedFileListItemCopyResolvedURL' has been explicitly marked deprecated here
LSSharedFileListItemCopyResolvedURL(
^
qt/guiutil.cpp:745:26: warning: 'LSSharedFileListItemCopyResolvedURL' is deprecated: first deprecated in macOS 10.11 [-Wdeprecated-declarations]
        currentItemURL = LSSharedFileListItemCopyResolvedURL(item, resolutionFlags, NULL);
                         ^
/System/Library/Frameworks/CoreServices.framework/Frameworks/SharedFileList.framework/Headers/LSSharedFileList.h:980:1: note: 'LSSharedFileListItemCopyResolvedURL' has been explicitly marked deprecated here
LSSharedFileListItemCopyResolvedURL(
^
qt/guiutil.cpp:769:67: warning: 'kLSSharedFileListSessionLoginItems' is deprecated: first deprecated in macOS 10.11 - Use a LaunchAgent, XPCService or the ServiceManagement APIs instead. [-Wdeprecated-declarations]
    LSSharedFileListRef loginItems = LSSharedFileListCreate(NULL, kLSSharedFileListSessionLoginItems, NULL);
                                                                  ^
/System/Library/Frameworks/CoreServices.framework/Frameworks/SharedFileList.framework/Headers/LSSharedFileList.h:121:20: note: 'kLSSharedFileListSessionLoginItems' has been explicitly marked deprecated here
extern CFStringRef kLSSharedFileListSessionLoginItems                __OSX_AVAILABLE_BUT_DEPRECATED_MSG(__MAC_10_5, __MAC_10_11, __IPHONE_NA, __IPHONE_NA, "Use a LaunchAgent, XPCService or the ServiceManagement APIs instead.");
                   ^
qt/guiutil.cpp:769:38: warning: 'LSSharedFileListCreate' is deprecated: first deprecated in macOS 10.11 - This functionality is no longer supported on OS X. [-Wdeprecated-declarations]
    LSSharedFileListRef loginItems = LSSharedFileListCreate(NULL, kLSSharedFileListSessionLoginItems, NULL);
                                     ^
/System/Library/Frameworks/CoreServices.framework/Frameworks/SharedFileList.framework/Headers/LSSharedFileList.h:360:1: note: 'LSSharedFileListCreate' has been explicitly marked deprecated here
LSSharedFileListCreate(
^
qt/guiutil.cpp:777:67: warning: 'kLSSharedFileListSessionLoginItems' is deprecated: first deprecated in macOS 10.11 - Use a LaunchAgent, XPCService or the ServiceManagement APIs instead. [-Wdeprecated-declarations]
    LSSharedFileListRef loginItems = LSSharedFileListCreate(NULL, kLSSharedFileListSessionLoginItems, NULL);
                                                                  ^
/System/Library/Frameworks/CoreServices.framework/Frameworks/SharedFileList.framework/Headers/LSSharedFileList.h:121:20: note: 'kLSSharedFileListSessionLoginItems' has been explicitly marked deprecated here
extern CFStringRef kLSSharedFileListSessionLoginItems                __OSX_AVAILABLE_BUT_DEPRECATED_MSG(__MAC_10_5, __MAC_10_11, __IPHONE_NA, __IPHONE_NA, "Use a LaunchAgent, XPCService or the ServiceManagement APIs instead.");
                   ^
qt/guiutil.cpp:777:38: warning: 'LSSharedFileListCreate' is deprecated: first deprecated in macOS 10.11 - This functionality is no longer supported on OS X. [-Wdeprecated-declarations]
    LSSharedFileListRef loginItems = LSSharedFileListCreate(NULL, kLSSharedFileListSessionLoginItems, NULL);
                                     ^
/System/Library/Frameworks/CoreServices.framework/Frameworks/SharedFileList.framework/Headers/LSSharedFileList.h:360:1: note: 'LSSharedFileListCreate' has been explicitly marked deprecated here
LSSharedFileListCreate(
^
qt/guiutil.cpp:782:51: warning: 'kLSSharedFileListItemBeforeFirst' is deprecated: first deprecated in macOS 10.11 - This functionality is no longer supported on OS X. [-Wdeprecated-declarations]
        LSSharedFileListInsertItemURL(loginItems, kLSSharedFileListItemBeforeFirst, NULL, NULL, roicoinAppUrl, NULL, NULL);
                                                  ^
/System/Library/Frameworks/CoreServices.framework/Frameworks/SharedFileList.framework/Headers/LSSharedFileList.h:215:32: note: 'kLSSharedFileListItemBeforeFirst' has been explicitly marked deprecated here
extern LSSharedFileListItemRef kLSSharedFileListItemBeforeFirst      __OSX_AVAILABLE_BUT_DEPRECATED_MSG(__MAC_10_5, __MAC_10_11, __IPHONE_NA, __IPHONE_NA, "This functionality is no longer supported on OS X.");
                               ^
qt/guiutil.cpp:782:9: warning: 'LSSharedFileListInsertItemURL' is deprecated: first deprecated in macOS 10.11 - This functionality is no longer supported on OS X. [-Wdeprecated-declarations]
        LSSharedFileListInsertItemURL(loginItems, kLSSharedFileListItemBeforeFirst, NULL, NULL, roicoinAppUrl, NULL, NULL);
        ^
/System/Library/Frameworks/CoreServices.framework/Frameworks/SharedFileList.framework/Headers/LSSharedFileList.h:674:1: note: 'LSSharedFileListInsertItemURL' has been explicitly marked deprecated here
LSSharedFileListInsertItemURL(
^
qt/guiutil.cpp:786:9: warning: 'LSSharedFileListItemRemove' is deprecated: first deprecated in macOS 10.11 - This functionality is no longer supported on OS X. [-Wdeprecated-declarations]
        LSSharedFileListItemRemove(loginItems, foundItem);
        ^
/System/Library/Frameworks/CoreServices.framework/Frameworks/SharedFileList.framework/Headers/LSSharedFileList.h:812:1: note: 'LSSharedFileListItemRemove' has been explicitly marked deprecated here
LSSharedFileListItemRemove(
^
10 warnings generated.

we are not planning to support native mac building.


Youtube URL returning no video formats found error

Checklist

[   ] I'm reporting a broken site support issue
[ x ] I've verified that I'm running youtube-dl version 2020.05.08
[ x ] I've checked that all provided URLs are alive and playable in a browser
[ x ] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[ x ] I've searched the bugtracker for similar bug reports including closed ones
[ x ] I've read bugs section in FAQ

Verbose log
I'm not using the command line utility, rather the Python module.
ERROR: No video formats found

Description
I'm not sure as to why is stopped working, as it was working fine earlier.
Essentially, it's attempting to stream from a URL into a discord voice channel.
I have checked all the URL's that it attempts to play, and they all function in the browser.
None of them are geo-restricted either.
Link that I actively test the bot with: https://www.youtube.com/watch?v=oHg5SJYRHA0
(it's not actually meant to be a rickroll)

Correction, it's working fine now.
I just added the postprocessors tag to the options.
'postprocessors': [{
     'key': 'FFmpegExtractAudio',
    'preferredcodec': 'mp3',
    'preferredquality': '192',
}]


Refractor the script to work in both python2 and python3

Signed-off-by: Roy Yang<EMAIL_ADDRESS>

This should kubernetes/containerd integration test for COS M85
https://prow.k8s.io/view/gcs/kubernetes-jenkins/logs/ci-containerd-e2e-gci-gce/1304059920986935296

@dims

/assign @dims  @Random-Liu

@bsdnet one nit! looks good to me otherwise.

This is picked from file https://github.com/kubernetes/kubernetes/blob/master/cluster/gce/gci/configure.sh

Looks like it should work, to me, as described in this thread, https://groups.google.com/d/msg/kubernetes-sig-node-test-failures/HuAOqZgXMD4/Fe7NBq-ZAwAJ

Will this be merged automatically like k8s repo or I need to something @dims  @Random-Liu

@mikebrow @dmcgowan can you please look?
LGTM 👍 from me!

Thanks!
On Fri, Sep 11, 2020 at 7:39 PM Phil Estes<EMAIL_ADDRESS>wrote:

Merged #4559 https://github.com/containerd/containerd/pull/4559 into
master.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/containerd/containerd/pull/4559#event-3758692101, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ABBSNJO6IEJLZK7AL7CFVMDSFLNNHANCNFSM4RIH2K6A
.


Release please? Readme documentation does not match version

Hi,
I was trying to use the plugin, but it seems that 0.91 -the version mentioned in the documentation- is old and does not match the information in the Readme file. I cannot seem to find a newer version anywhere or snapshots?
Thanks!

The problem is avro4s is no longer shipped for scala 2.10 and sbt needs a scala 2.10 version.

sbt-avro4s only depends on avro4s-generator, though, which compiles fine under 2.10.6 afaict. Can just that package be published be as 2.10?

Fair point.

The whole generator can probably just move in here.


chore: merge release/1.3.1 to master

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-Blkkw9bQFn8A
Commit ID: 7d00ddc71feefce6a1faa5baadd970ba108c5460
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository


NONE: remove UGC from logs

What's in this PR?
Removing UGC from error, request and response serializers
Why
Because logging UGC is bad, m'kay?
Added feature flags
:cowboy:
Affected issues
NONE
How has this been tested?
locally
Whats Next?


Turn on when mouse keys enabled

Would like to have the highlight turn on when mouse keys in linux is enabled. Is there an easy way to do this? Thanks in advance

What exactly do you mean with mouse keys? How to you enable them? Currently, you can define hotkeys to toogle the highlight, for instance.


fix: fix volume label error, issue#706

Signed-off-by: letty.ll<EMAIL_ADDRESS>
Ⅰ. Describe what this PR did
fix volume create --label error and add a test.
Ⅱ. Does this pull request fix one issue?

fix #706
Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

LGTM
Waiting CI to be green. 😄

Codecov Report

Merging #707 into master will not change coverage.
The diff coverage is 0%.

@@          Coverage Diff           @@
##           master    #707   +/-   ##
======================================
  Coverage    10.7%   10.7%
======================================
  Files          92      92
  Lines        5383    5383
======================================
  Hits          576     576
  Misses       4757    4757
  Partials       50      50

Impacted Files
Coverage Δ

cli/volume.go
0% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d43f7f...f7d502c. Read the comment docs.


Executing AnimatedSprite.new().play(".", true) crashes Godot

Godot version:
Godot 3.2.4 rc 2
Issue description:
Executing
AnimatedSprite.new().play(".", true)

crashes with backtrace
ERROR: set_animation: There is no animation with name '.'.
   At: scene/2d/animated_sprite.cpp:651.
scene/2d/animated_sprite.cpp:614:37: runtime error: member call on null pointer of type 'struct SpriteFrames'
scene/2d/animated_sprite.cpp:614:37: runtime error: member access within null pointer of type 'struct SpriteFrames'
handle_crash: Program crashed with signal 11
Dumping the backtrace.

I just had a little look wondering why all these issues were occurring with new() and wondering if there was a connection. This one does seem to be just missing a valid check, so maybe they are not due to a common cause...
void AnimatedSprite::play(const StringName &p_animation, const bool p_backwards) {

	// lawnjelly inserted these two lines
	if (!frames.is_valid())
		return;

	backwards = p_backwards;

	if (p_animation) {
		set_animation(p_animation);
		if (backwards && get_frame() == 0)
			set_frame(frames->get_frame_count(p_animation) - 1);
	}

	_set_playing(true);
}

By adding that check it fixed the crash. Not sure if it should be fixed in this way.

I just had a little look wondering why all these issues were occurring with new() and wondering if there was a connection.

For now I test only functions on new objects. Later(maybe even today) I will try to test more complex things like executing several random functions on one object, so it should show more errors.

Most of the errors reported happen on methods which expect some data to be initialized in NOTIFICATION_ENTER_TREE, which doesn't happen before add_child(). It's an unlikely use of the API which exposes missing null checks mainly.

Hi, I would like to work on this issue.


Fix #11355 IME - Windows, avoid loss of selected result from IME when continue e…

…ntering composition string
What does the pull request do?
Relate to the issue https://github.com/AvaloniaUI/Avalonia/issues/11355, fix loss of converted string when you do not press enter to confirm IME's conversion and start directly typing next word to convert.
What is the current behavior?
See issue #11355. Also video attached to the issue report.
What is the updated/expected behavior with this PR?
You enter some words, select desired Kanji, continue entering next words without press ENTER key without loss any converted string.
How was the solution implemented (if it's not obvious)?
WM_IME_COMPOSITION handling added to accept the converted string.
Checklist

[ ] Added unit tests (if possible)?
[ ] Added XML documentation to any related classes?
[ ] Consider submitting a PR to https://github.com/AvaloniaUI/Documentation with user documentation

Breaking changes

Obsoletions / Deprecations

Fixed issues
Fixes #11355

You can test this PR using the following package version. 11.0.999-cibuild0034657-beta. (feed url: https://pkgs.dev.azure.com/AvaloniaUI/AvaloniaUI/_packaging/avalonia-all/nuget/v3/index.json) [PRBUILDID]


Uneeded "Format" on Logout Request

Hello,
I'm trying to debug an issue with the logout process.
After a couple hours of debugging I found out that commenting out this line: https://github.com/onelogin/php-saml/blob/master/lib/Saml2/Utils.php#L959 would make things work correctly. I can post the log I get from SAML Tracer (Firefox extension) if needed.
I'm no expert in AD FS nor Saml2, so before going for a Pull Request that might not make any sense, I've a quick question:
Shouldn't the line https://github.com/onelogin/php-saml/blob/master/lib/Saml2/Utils.php#L959, $nameId->setAttribute('Format', $format); be inside the if (isset($spnq)) { three lines above?
From the function's DocBlock it kinda makes sense to me that the SP Format should only be present if the SP Name Qualifier is set.
Am I missing something?
PS. I'm using php-saml with https://github.com/aacotroneo/laravel-saml2 so it might be "laravel-saml2" that is not using php-saml correctly.

After some more debugging I found out that it might be a problem with checking whether $nameIdFormat is empty() or is_null(). I think that $nameIdFormat = false should not be threaded the same way as $nameIdFormat = null since a false value will generate a different XML than null.
That's the two edits I've done to get it working:

https://github.com/onelogin/php-saml/blob/master/lib/Saml2/Auth.php#L450 from
public function logout($returnTo = null, $parameters = array(), $nameId = null, $sessionIndex = null, $stay = false, $nameIdFormat = null) to
public function logout($returnTo = null, $parameters = array(), $nameId = null, $sessionIndex = null, $stay = false, $nameIdFormat = false)

https://github.com/onelogin/php-saml/blob/master/lib/Saml2/LogoutRequest.php#L68 from
if (empty($nameIdFormat)) { to
if (is_null($nameIdFormat)) {.

If you think this is an issue, I can create a pull request.

Here you can see how the NameID elemnt is built. The Format makes reference to the format of the NameID's value.
The constructor will try to set the Format provided in the method, if not it will try to set the format that appears on the settings, by default set to UNSPECIFIED
PHP empty method will return true if the provided format is null, false or "" , so if that is the case, the default settings will be used.
But I don't understand why provide false as nameIdFormat.
lavarel-saml2 is not providing any value for the nameIdFormat so its default setting value should be used, in this case "persistent" and maybe that value is causing you problems.

The problem I'm facing is "The SAML Single Logout request does not correspond to the logged-in session participant." (from the Windows Event Viewer).
I think the error is thrown because the request doesn't contain the NameIdFormat (nor the SPNameQualifier). I've been able to generate a request without the "SPNameQualifier" but not without the "NameIdFormat".
I've trying to modify the login request to include the "NameIdFormat" but I was not able to, probably because of a lack of knowledge of AD FS and Saml2.
I've created this morning a Pull request on the laravel-saml2 repository to allow to pass a value for "nameIdFormat".
I can post the saml2 settings and the Event Viewer logs if needed.

Close since that issue belong laravel-saml2

Hello,
sorry for the late feedback.
I've reviewed your indications this morning for a second time.

But I don't think why a developer should provide false as nameIdFormat value on the @ constructor...

I've found the need to have a SAML2 logout request without the "NameIdFormat" property, it's the only way I got the logout working.
As of my understanding, the XML of the login and logout request has to have the same parameters. Given the error I get when logging out through AD FS, I came to the conclusion that to solve my problem I either have to add the "NameIdFormat" parameter when performing the login request, something I haven't been able to do, or make sure the logout request doesn't have the "NameIdFormat" property.
Even if laravel-saml2 merges this pull request, it would still be necessary to have the change I've proposed in one of my previous comments implemented into the php-saml library. We wouldn't be able to generate the appropriate XML otherwise.
I think the following still applies and I would love to get your opinion on this:

After some more debugging I found out that it might be a problem with checking whether $nameIdFormat is empty() or is_null(). I think that $nameIdFormat = false should not be threaded the same way as $nameIdFormat = null since a false value will generate a different XML than null.


Always include ANCM in build output

Note, this is purely a build only change. I'm currently working on verifying this works with separate branches on aspnetci.
Impact
After we stopped pushing to MyGet, ANCM transfer packages have stopped being uploaded. Builds are now failing with an error saying ANCM could not be found as an artifact dependency as well as the latest version of ANCM being 2.2.2 on myget. This change makes it so ANCM always builds, regardless of if there was a change to ANCM or not.
The reason this is fine is:

ANCM is shipped globally and isn't put in a package.
We are already doing this in 3.0.

Risk
Very low risk. We are rebuilding ANCM every patch version, which will update dll/msi versions. However, the source code being used is the same.

Yes this is a fix that we need in order to build our 2.2 patch.

👍 . Make sure netcoreship is aware of the change, but if it's necessary to build, we gotta take it so go ahead.

Verified here: http://aspnetci/viewLog.html?buildId=655457&buildTypeId=Releases_22xPublic_WindowsInstallers&tab=buildLog&_focus=481#_state=441

Approved for 2.2.6

I'm going to merge this one since we are running into build hangs on 2.2 right now and it's unlikely that the tests will pass. The linux failure is unrelated.


Future-proof our key storage, symmetric key encryption / decryption, symmetric key exchange, and data encryption / decryption

Is your feature request related to a problem? Please describe.

We currently support one single type of public-private encryption keypair (RSA). We need to support ECC and likely others in the future
We currently encrypt  symmetric keys in one way only, by using RSA asymmetric keys. We need to explicitly store some metadata about the asymmetric key that was used to encrypt the symmetric key, along with the encrypted key itself
We currently support one single type of symmetric key - AES-256. We need to support others.
We currently support one single type of encryption - AES-256 using the CTR cipher mode. We need to support others.
We currently support having only one public-private encryption keypair. We need to support having more than one - for migration purposes if nothing else.
We currently support @alice having only one single shared symmetric encryption key for sharing data with @bob, and @bob likewise having only one single shared symmetric encryption key for sharing data with @alice. We need to support each atSign sharing as many symmetric encryption keys as they like with another atSign, and choosing to encrypt data with any of those shared symmetric encryption keys they wish

Describe the solution you'd like

We currently support one single type of public-private encryption keypair (RSA). We need to support ECC and likely others in the future
We currently encrypt  symmetric keys in one way only, by using RSA asymmetric keys. We need to explicitly store some metadata about the asymmetric key that was used to encrypt the symmetric key, along with the encrypted key itself
We currently support one single type of symmetric key - AES-256. We need to support others.
We currently support one single type of encryption - AES-256 using the CTR cipher mode. We need to support others.
We currently support having only one public-private encryption keypair. We need to support having more than one - for migration purposes if nothing else.
We currently support @alice having only one single shared symmetric encryption key for sharing data with @bob, and @bob likewise having only one single shared symmetric encryption key for sharing data with @alice. We need to support each atSign sharing as many symmetric encryption keys as they like with another atSign, and choosing to encrypt data with any of those shared symmetric encryption keys they wish

Describe alternatives you've considered
No response
Additional context
No response

High-level design completed during PR49


Allow setting any log level

It would be useful to set a specific log level by providing a string as other levels apart from info and debug are useful.
Have prioritised the existing debug flag for backwards compatibility but would recommend its removal.

Ah my bad! Was editing straight in the browser and didn't run the tests 🤦
Have fixed now

@stanleyrh nice!  Merging it!


coreth: 0.13.2 -> 0.13.3

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/ava-labs/coreth/releases.
meta.description for coreth is: Code and wrapper to extract Ethereum blockchain functionalities without network/consensus, for building custom blockchain services
meta.homepage for coreth is: https://github.com/ava-labs/coreth
meta.changelog for coreth is: https://github.com/ava-labs/coreth/releases/tag/v0.13.3
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.13.3 with grep in /nix/store/2ibd2m8jh8nqmx199ing3nr7l4s4qznp-coreth-0.13.3
found 0.13.3 in filename of file in /nix/store/2ibd2m8jh8nqmx199ing3nr7l4s4qznp-coreth-0.13.3

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

coreth

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/2ibd2m8jh8nqmx199ing3nr7l4s4qznp-coreth-0.13.3 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A coreth https://github.com/r-ryantm/nixpkgs/archive/9e3310fdf5d6f4032a8644232f0a5aa9de8c6fe1.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/9e3310fdf5d6f4032a8644232f0a5aa9de8c6fe1#coreth

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/2ibd2m8jh8nqmx199ing3nr7l4s4qznp-coreth-0.13.3
ls -la /nix/store/2ibd2m8jh8nqmx199ing3nr7l4s4qznp-coreth-0.13.3/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

1 package built:

coreth

Maintainer pings
cc @urandom2 for testing.

Result of nixpkgs-review pr 308407 run on aarch64-darwin 1

1 package built:

coreth


Added Polish translation

Pull Request Status

[ ] WIP

Description
Short summary of the changes and goals of this pull request.
Todo's

[X] Todo 1
[ ] Todo 2

Codecov Report

Merging #9 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             master      #9   +/-   ##
========================================
  Coverage      92.5%   92.5%
  Complexity       34      34
========================================
  Files             5       5
  Lines            80      80
========================================
  Hits             74      74
  Misses            6       6

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 792de9a...7b15953. Read the comment docs.

#2 Added Polish translation

Looks fine, awesome work.


Automated adoption of Octavia certificates

Depends-On: https://review.rdoproject.org/r/c/rdo-jobs/+/54139
Jira: OSPNET-1069

recheck

recheck

recheck

Since this is now passing CI, just wanted to note that we have to merge this in unison with the depends-on patch https://review.rdoproject.org/r/c/rdo-jobs/+/54139, if we merge only one of them, we'll break the existing jobs

recheck

this seems ready to merge - is it really necessary to have four commits here though ? Personally I'd prefer them squashed into one before merging but I am not going to block the merge on that

this seems ready to merge - is it really necessary to have four commits here though ? Personally I'd prefer them squashed into one before merging but I am not going to block the merge on that

Let's merge it ASAP. I could squash it, but that would further delay the merge and this has been open for too long already IMO.


Refactor RHUA install for RHUI4.2

Prepare for 4.2 launch.

Minimize the patch contents
Use rhui-installer directly

/lgtm