Do you mind if I update the tests to mocha?

Hey Folks,
I was going to spend some time updating the testing system for this repo to mocha but I thought I should ask first ;)
I was looking at the travis output for this PR https://github.com/quartzjer/ursa/pull/107 and I noticed that it didn't show a list of the tests that passed, instead it just says "All tests pass!" in the Travis output. If you have a look at one of my other modules and compare the Travis output https://travis-ci.org/Blooie/express-autoroute/jobs/74972233
Like i said, I would love to update the tests but I didn't want to just land a PR without asking first :wink:

I would definitely love that, I doubt anyone would complain about having better test output :)
:+1:

On Oct 2, 2015, at 6:52 AM, Chris Manson<EMAIL_ADDRESS>wrote:
Hey Folks,
I was going to spend some time updating the testing system for this repo to mocha but I thought I should ask first ;)
I was looking at the travis output for this PR #107 and I noticed that it didn't show a list of the tests that passed, instead it just says "All tests pass!" in the Travis output. If you have a look at one of my other modules and compare the Travis output.
Like i said, I would love to update the tests but I didn't want to just land a PR without asking first
—
Reply to this email directly or view it on GitHub.

:joy: great, i'll take a look this week some time. :+1:


Restore angle bracket used for breadcrumb arrow

In #78 the angle bracket used for the breadcrumb arrow was removed by accident. See the end of line 14 here.
This PR restores said angle bracket and leaves a comment so it's more obvious it was intentional.

Just a note: you need to update the Netlify build image for checks to work here. See #98

Thank you! And fixed the build image


Hide 'Follows You' pill on own Followers page

When looking at your own followers page, every account listed has the "Follows You" pill:

That seems a little redundant; after all, I am looking at my own followers page. Of course they all follow me...
This PR hides that pill when viewing your own page, like:

I will note that I really thought Twitter did this, and then I looked and it didn't. So, maybe this is a silly idea. Happy to close; it was fun to hack on the app locally! :smile:
Also, have never worked with react-native, so wasn't sure how I was supposed to pass additional data down to renderItem, so just added a param instead of making each item be an object or something.

I think for consistency between screens I'd keep the badge. Sure, it's a bit redundant here, but dropping the badge introduces a difference in behavior that imo contributes to mental load a bit.

That's fair; happy to close this if it feels bad.
I'll also say that it'd be nice if pills weren't positioned in a a way that makes the cards even taller, e.g.
bluesky:

twitter:

But that's an entirely different kind of PR 😄


Returning a reviewed item to the user.

This is the description of what happens in this case. There is a related mockup noted below in the Design Doc.
When the review workflow is on and an item is returned to the depositor, several things happen. 1) Under the “Deposits in Progress” header on the depositor’s dashboard it should now say “Returned” to the right of the progress bar for this item. 2) The user is sent an email notification that the item has been returned to them for changes. 3) When they open the item for editing they will see a message at the top of that page. The specs on this are in the design doc here: https://docs.google.com/document/d/1fcr2DYo7OrX-qTdeUOTWKSS1rlq_47sehESmbvgUsrk/edit#heading=h.yiub3zxgcv6m . 4) The item is removed from the Approvals table on the Reviewer’s dashboard.

Text for the email is in https://docs.google.com/document/u/1/d/1TZVILUrORI25kRZyUZ70vMQYo90Ngp_tqCI7BdU_VyQ/edit

I think the status "returned" is being addressed in my PR for #581 and #576 (almost done)

I think the remainder of this is covered by #594


Infinite recursion when running on Windows

Hey
It looks like on VS2019 this bit creates an infinite recursion and the game crashes at launch:
https://github.com/arc80/FlapHero/blob/c42edcc06c545bef7a9219f0727a4a46b883c370/src/flapGame/flapGame/Assets.cpp#L145-L147
because the second version of find is called (and then calls itself), while forSkel is actually already an ArrayView:
template <typename T, typename Callback, std::enable_if_t<IsCallable<Callback, T>, int> = 0>
PLY_INLINE s32 find(ArrayView<const T> arr, const Callback& callback) {
    for (u32 i = 0; i < arr.numItems; i++) {
        if (callback(arr[i]))
            return i;
    }
    return -1;
}

template <typename Arr, typename Arg, typename = details::ArrayViewType<Arr>>
PLY_INLINE s32 find(const Arr& arr, const Arg& arg) {
    return find(arr.view(), arg);
}

It's not clear to me why the overload taking an ArrayView isn't selected here 😞
Edit: it looks like it has to do with T not being const, so ArrayView doesn't match here.

Thanks for reporting this. It's a bug caused by arc80/plywood@91c71de.
The overload taking an ArrayView isn't selected here because the compiler can't deduce any T in ArrayView<const T> that would match ArrayView<Bone>, since Bone is non-const. The compiler doesn't look at user-defined conversions during template argument deduction.
My first thought is to use a cast to ArrayView of const items instead of calling view() here -- that would state more specifically what we want. Might involve changing the ArrayViewType template a little bit. I'll investigate.

Thanks!


wrap pid controller for python with swig

Implemented in 8aff66040672e1cf8b218c23b56578f26a12a51d
Currently for webots i get the following error for the python controller:
WARNING: The current physics step could not be computed correctly. Your world may be too complex. If this problem persists, try simplifying your bounding object(s), reducing the number of joints, or reducing WorldInfo.basicTimeStep
Weird thing is that I am not seeing this at all for the c controller, and I really replicated the code step by step.
I already asked a question to the webots tech service about this on discord.

yeah.... it was because the rotors were not going in the right direction... classic. I first did it without the minuses like this.
    m1_motor.setVelocity(-motorPower.m1)
    m2_motor.setVelocity(motorPower.m2)
    m3_motor.setVelocity(-motorPower.m3)
    m4_motor.setVelocity(motorPower.m4)

probably a bit too much context switching between webotts and gazebo!


hamilton-jacobi / level-set equations

I am interested in a DG solver for hamilton-jacobi equations (of the form $\varphi_t + H(\nabla \varphi) = 0$) as they arise in level-set methods (e.g. $H(\nabla \varphi) = a \| \nabla \varphi \|$ for movement normal to the level-set interface or $H(\nabla \varphi) = \bf{v} \nabla \varphi$ for movement with an external velocity field or any linear combination of these or similar operators).
There are DG methods for this type of equation (e.g. https://www.sciencedirect.com/science/article/abs/pii/S0021999110005255 where auxiliary variables for the spatial derivatives are introduced and numeric fluxes are defined for these). Can this this kind of method be implemented in the Trixi framework? Are you aware of other options?
I'm sorry for not being very well versed in DG methods. Appreciate any help you can provide.

I guess we have many tools required for that but it's not completely straightforward since it's not in the form of a conservation law - which is the type of equations Trixi.jl focuses on.


⚠ Mobitopup has degraded performance

In f84b068, Mobitopup (https://napcard.voz.tech) experienced degraded performance:

HTTP code: 200
Response time: 3695 ms

Resolved: Mobitopup performance has improved in 4b3261c.


The dependency "thecodingmachine/safe" generates deprecated logs in PHP 8.4.

The dependency "thecodingmachine/safe" generates deprecated logs in PHP 8.4.
Please update the dependency "thecodingmachine/safe" to "dev-master".

We will stick with requiring tagged releases. Feel free to post a pull request when v3 is available.


fix: update toolbar when formatted word is deleted

FX-2895
Description
Bug fix
Steps to reproduce:

write “test bold” into the RichTextEditor
bold icon in the toolbar is active
manually remove the “bold” text
write “this should not be bold”

expected:

text is not bold
bold button in toolbar is not active

How to test

apply the reproducing steps in the storybook

Development checks

[x] Add changeset according to guidelines (if needed)
[x] Read CONTRIBUTING.md and Component API principles
[x] Make sure that additions and changes on design follow Toptal's BASE design, and it's been already discussed with designers at #-base-core
[x] Annotate all props in component with documentation
[x] Create examples for component
[x] Ensure that deployed demo has expected results and good examples
[x] Ensure the changed/created components have not caused accessibility issues. How to use accessibility plugin in storybook.
[x] Self reviewed
[x] Covered with tests

Breaking change

[x] codemod is created and showcased in the changeset
[x] test alpha package of Picasso in StaffPortal

All development checks should be done and set checked to pass the
GitHub Bot: TODOLess action

PR commands

List of available commands:

@toptal-bot run package:alpha-release - Release alpha version
@toptal-anvil ping reviewers - Ping FX team for review

PR Review Guidelines

When to approve? ✅
You are OK with merging this PR and

You have no extra requests.
You have optional requests.

Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌
You are not OK with merging this PR because

Something is broken after the changes.
Acceptance criteria is not reached.
Code is dirty.

When to comment (neither ✅ nor ❌)
You want your comments to be addressed before merging this PR in cases like:

There are leftovers like unnecessary logs, comments, etc.
You have an opinionated comment regarding the code that requires a discussion.
You have questions.

How to handle the comments?

An owner of a comment is the only one who can resolve it.
An owner of a comment must resolve it when it's addressed.
A PR owner must reply with ✅ when a comment is addressed.

@toptal-anvil ping reviewers

@mkrl thanks for catching additional edge case, it is fixed now

@toptal-anvil ping reviewers


Error on opening ( or start of signature help

Using latest version of neovim HEAD , lastest version of lsp_signature when it gets the signature help on lua/python code i receive the following error
Error executing vim.schedule lua callback: ...utoload/plugged/lsp_signature.nvim/lua/lsp_signature.lua:71: attempt to concatenate local 'hint' (a nil value)

I had to fill in a config as I was using
on_attach() , the error seems to have gone once I added
on_attach({
hint_enable = true,
hint_scheme = "String",
bind = true,
handler_opts = {
border = "single"
},
doc_lines = 10
})

Same here only in lua though, python seems to work.

In your config can you try:
	lspsig.on_attach({
			hint_enable = false, -- virtual hint enable
    })

and see if that works

doing that does stop the error however i've noticed now when doing
:messages

it says
hover not supported

which from reading the source means hover is not in the resolved capabilities of the client but when i check the client capabilities for python hover is in the list
I'm running pyright 1.1.136
and when using lspsaga hover is available

Yes, I have the same message. Do you use efm alongside pyright? I think it comes from efm.

No efm installed

I did run some simple test with python before push.

Can you guys share with me the python code snips?

I know what is wrong. It happened when there is 0 or 1 argument.
A fix was commited.

Yes, I think it's ok now. Thank you.

fixed by ff28cebe9

@ssmithstone  if you find a solution about the hover not supported in python can you post it as a comment?

I think that is caused by no standard return from pyright. I fixed the issue in latest updates.

Ah thanks! I thought it wasn't relevant to lsp_signature. Works now perfect!


Update UserGuide, DeveloperGuide, PPP, Readme and index.md

Update UserGuide, DeveloperGuide to include invalid file type error message in Planned Enhancements section.
Update PPP headings for every team member.
Update ReadMe's Ui image.
Update index.md's description.
fixes #206 , updates #221

LGTM


User Auth & Action logs for auditing purposes

For the purpose of auditing our users access usage of gogs it would be helpful for the gogs admin interface to provide the ability to do the following:

Within the User Manage Panel each users last login time stamp should be displayed
The addition of a per user access log to see a history of where they have logged in from with timestamps plus a list of actions carried out

Hi,

The addition of a per user access log to see a history of where they have logged in from with timestamps plus a list of actions carried out

Can you give some examples on this?

I'm also interested in such a feature. Specifically the information when a user logs in the first time.


Don't set SMPP remote message ids for failure responses

Currently, we store a mapping between remote message ids and our message ids in redis, and use this when we get a delivery report to publish a delivery report event with our message id.

Ready for review.

:+1:

:+1:


Failed to run test because null with nested test classes.

Environment data
dotnet --info output: 1.0.0-preview2-003133
VS Code version: 1.9.0-insider
C# Extension version: 1.6.2
Steps to reproduce
For us the problem was nested classes. OmniSharp cannot handle this, when we click run test.
    public class SomeClass
    {
        public class SomeMethod
        {
            // Trying to run this test causes
            // "Failed to run test because null"
            [Fact]
            public void SomeTest()
            {

            }
        }
    }

Expected  behavior
The test runs and the output says "Test Passed".
Actual behavior

Failed to run test because null

Thanks. This looks like a dupe of #1100

@gregg-miskelly It is not necessarily a dupe, because there are multiple reasons why Omnisharp might give that error. See also: http://stackoverflow.com/q/40858172/1108891

Okay, I will reopen for now then.

Yeah, this has a different error. However, the "dupe" is from several months ago, so it might just be that behavior has changed since then. I suspect we started hitting null with this change: https://github.com/OmniSharp/omnisharp-roslyn/pull/683
FWIW, this will require a fix in omnisharp-roslyn. Looking at the code in https://github.com/OmniSharp/omnisharp-roslyn/blob/master/src/OmniSharp.DotNetTest/Helpers/TestFeaturesDiscover.cs, I can see how it might fail to locate tests in nested classes. I'll take a look at this shortly.

shortly == tomorrow. :smile:

Note: There's also #743

Looks like the problem is that there's some hacky code in omnisharp-roslyn that searches specifically for the presence of 'project.json'. https://github.com/OmniSharp/omnisharp-roslyn/blob/dev/src/OmniSharp.DotNetTest/Helpers/ProjectPathResolver.cs#L11

OK. I see why the problem is specific to tests in nested classes. The offending line of code is here: https://github.com/OmniSharp/omnisharp-roslyn/blob/dev/src/OmniSharp.DotNetTest/Helpers/TestFeaturesDiscover.cs#L41.
Essentially, the code expects Roslyn's ISymbol.ToDisplayName() to return a name that can be used with 'dotnet test'. However, that method returns strings for display. Between a class and a nested class, it uses a '.' separator. However, 'dotnet test' expects a metadata name when the class and nested class are separated by a '+'. I had to write code that produced a metadata name once before -- for Code Model in VS (https://github.com/dotnet/roslyn/blob/master/src/VisualStudio/Core/Impl/CodeModel/MetadataNameHelpers.cs). Looks like I might have to do that again. :smile:

OK. I've got a fix for this in omnisharp-roslyn.


Change package to org.eclipse

@mickaelistria I have changed package to org.eclipse.
Now we have org.eclipse.language.textmate.core and org.eclipse.language.textmate.eclipse. Is it OK?

We'll see. As the project moves to Eclipse.org, it needs to get a name, and the name should be used in packages. There is no restriction for names except that it mustn't be a registered name. The name has to be decided when submitting the proposal and then Eclipse legal people check whether it's fine.
I didn't find that TextMate is a regstered trademark, however, I'm not sure "Eclipse Textmate" is the right name as it can drive people to imagine that TextMate editor is now part of Eclipe.org...
What about something like EclipseMate ?

I don't know. This project supports TextMate language grammar https://manual.macromates.com/en/language_grammars so I think we should keep TextMate name, no?
But if you are not OK, please give me a suggestion for projects names and  I will update it. Thanks!

I will contact Eclipse legal right now to ask for advices and check whether having textmate in the package name is ok or not.

Thanks @mickaelistria !


Chart not updating when data changes

When I update the data for the chart, the tooltip on the chart displays the correct data however the chart doesn't. I am using a radar chart.

Hi @aarondo,
could you show me your sample code in jsbin? thanks

I cant really do that as Im using vueify.
I have this in my template
''
Then when I update chartData on an event. It updates the data in the tooltip on the chart but doesnt update the radar chart.

How do you update your chartData?

This is how I update the data
this.$set(this.chartData.datasets[0],'data',[1,2,4,5]); which I can see updating in the chart tooltip.
Do I need to do anything once the data has been updated. i can see in the standard chart js docs. That I would normally need to call chart.update(); once the data has been changed?

I managed to get this working. Rather than just updating the datasets data. I had to update the whole chartdata object like this
 this.chartData = {
      labels: ['Plan', 'Reach', 'Act','Convert','Engage'],
      datasets: [{
      borderColor:'#fe5a68',
      pointBackgroundColor: '#fe5a68',
      pointBorderColor: '#fe5a68',
      pointRadius: 4,
      backgroundColor:'rgba(254,90,104,0.5)',
      data: [1, 2, 4,5]
      }]
     }

to trigger the datasets watcher you need to write it like this:
      this.$set(this.chartData.datasets, 0, {
        data: [50, 40, 90],
        label: 'component 1'
      })

To me this worked only:
(vue.js , vue-chart.js)
template part:
<b-select @change="changeData($event)">
<donut-chart ref="firstDonut" :chartdata:"chartdata" :options: "options">
...
script part:
methods: {
changeData(changed) {
this.selectedProductId = changed
this.$refs.firstDonut.renderChart(this.chartdata, this.options)
}
}
Hope I could help


Notes saving with different format in the db

Reproduction Steps

Create a board
Create a note
Save that note in db
Close tab
Rerun the project
Get the board
Previous note appears already in the board
Create another note
Save notes again
Go to db or postman
Notice the first note has changed structure wise

backend issue solved it - https://github.com/roarcoders/scrumblr-sam-api/commit/d57e606b63e9f97680430c194a26a9af06cd87d4


Use static import for @monokle/validation

The @monokle/validation library is now imported dynamically due to some errors with building and static import which I wasn't able to solve in reasonable amount of time:
https://github.com/kubeshop/vscode-monokle/blob/d916d170633535ba96095d011a665b17a94ff4b8/src/utils/validation.ts#L168-L171
But this makes it a bit harder to work with and e.g. cumbersome to import types.

One of the errors was:
Error [ERR_REQUIRE_ESM]: require() of ES Module<EMAIL_ADDRESS>from monokle-vsc/out/extension.js not supported.
Instead change the require of node.js in monokle-vsc/out/extension.js to a dynamic import() which is available in all CommonJS modules.

Just a small update since I encountered this issue with other ESM-only modules. There is an open issue regarding this so not sure if this is (easily) doable - https://github.com/microsoft/vscode/issues/130367.

Did first (unfortunately unsuccessful) attempt with https://github.com/kubeshop/monokle-core/pull/479.


Verify that element model resynthesized correctly when config-specific imports are present

This issue tracks the implementation work for config-specific imports within the summary resynthesizer.  We need to ensure that when config-specific imports are in place the resynthesized element model is correct in two respects:

Elements representing import and export directives point to the LibraryElement corresponding to the selected configuration.
References are correctly resolved according to the selected configuration (e.g. if class A extends B {}, and B is obtained from a config-specific import, then B should be resolved to the correct element).

Note: I believe this task only requires writing tests; assuming that the summary linker has been properly modified to support config-specific imports (see #27045), the existing resynthesizer should resynthesize the element model correctly.

I think the CL for resynthesizing with configured imports already includes required tests.
Well, maybe it should have been one issue - implementation and tests go hand in hand.
https://codereview.chromium.org/2353433002

https://github.com/dart-lang/sdk/commit/f5a616834ea322eecfef4a0b705b9a195d8204dd


Automatic generate

Hey TerrainControl team,
i have Problem. Ist not a issue in this way, but i dont found an better categorie.
At the beginning, my english is not that good, hopefully you unterstand me.
I want to generate a custom Biomes automic, not with an command.
There are three world on my server, and everytime when one was deleted a new world with my custom Biomes should be created(same Name).
Hopefully you understood me and can help me
SevoX

Hmm, I think I understand. Have you tried to NOT set a generation seed for the maps? If no seed is provided you should get a new map. Let me know if this helps :D


Incredibly slow when using lots of ? in the query

Hi, just want to let you know that gorm has a path where it behaves incredibly slow. Imagine a raw query for inserting thousands of rows into the table of this form: INSERT INTO table (a, b, c) VALUES (?, ?, ?), (?, ?, ?), (?, ?, ?), (?, ?, ?), (?, ?, ?), ... and so on, let's say 10000 rows.  Anyways, even if you use gorm.Exec(), it goes through scope.buildWhereCondition: https://github.com/jinzhu/gorm/blob/c3bb6aaa828867eec72dd8571d111e442688f85f/main.go#L431-L433
And in buildWhereCondition, strings.Replace is used for substituting ? symbols with DB specific ones. Sadly you substitute them 1 by 1: https://github.com/jinzhu/gorm/blob/c3bb6aaa828867eec72dd8571d111e442688f85f/scope.go#L563-L578
Calling strings.Replace() with a limit of 1 in a loop on a string with thousands of ? symbols leads to making thousands of copies of that string. It ends up being extremely slow. Using database/sql however directly for such kind of a request works just fine. The kind of slowdown I'm talking about is like 100ms vs 16s.

This has been refactored a little bit.


Adjusted AppShell example

Adjusted the primary labels in the interactive examples to better represent the svelte fragments Added a section depicting the slot usage to make it more clear how to pass through page data
Before submitting the PR:

[ ] Does your PR reference an issue? If not, please chat to the team on Discord or GitHub before submission.
[ ] Did you update and run tests before submission using npm run test?
[ ] Does your branch follow our naming convention? If not, please amend the branch name using branch -m new-branch-name
[ ] Did you update documentation related to your new feature or changes?

What does your PR address?
Please briefly describe your changes here.
Tips

Tap "convert to draft" to indicate this is work in progress.
Link to an issue using the verbiage Fixes #XX
Linked issues will auto-close when the PR is merged.

@LukeHagar seems simple enough so I went ahead and merged this. Thank you sir!


Test cases for Tree/List in Popup/ModalWindow is flaky only in CI runs

It works when running with cypress open. It also worked locally with cypress run (verified using local snapshot instead of percy). It's also not a screenshot-only issue. The assersions on width also fails (See this run)


Modified schema to adjust to user's trip adding flow

 Modified db schema to adjust to user's adding trip flow


UTF-8 Encoding issue

Attempted to use this with SSRS and it works but the report attachments are mangled and renamed. The file contains the correct data but the filename removes the extension.
You can see the log here the MAIL FROM line appends "BODY=8BITMIME SMTPUTF8"

INFO:mail.log:('xxx.xxx.xxx.xxx', 51714) >> b'REDACTED'
INFO:mail.log:('xxx.xxx.xxx.xxx', 51714) >> b'MAIL FROM:<noreply@REDACTED> BODY=8BITMIME SMTPUTF8'
INFO:mail.log:('xxx.xxx.xxx.xxx', 51714) sender: noreply@REDACTED
INFO:mail.log:('xxx.xxx.xxx.xxx', 51714) >> b'RCPT TO:<ME@REDACTED>'
INFO:mail.log:('xxx.xxx.xxx.xxx', 51714) recip: ME@REDACTED

Here is what the attachment looks like in outlook

Ran the name through Base64 decoder and it looks like the name is encoded.

Is there any way you can get this to support this format? Using it on SSRS would be fantastic.

Thank you for looking into this!
Unfortunately no luck after the update. The filename still comes in as "=?utf-8?B?VEVTVC5jc3Y=?=" which should decode to Test.csv

I added a non-inline attachment test and it appears to be working on my end.

I'm going to mark this issue as closed, but let me know if you're still having issues.

Reopening because the committed change is not a comprehensive solution.

@Nussbutter, I've pushed an update that covers RFC2047 and RFC2231. It can also be pretty easily extended for other encodings. I'm not super thrilled with the code, but it should get you rolling.

Awesome, it's working now. Thank you!


GoogLeNet questions

Hi, I am running your examples since long on my Jetson Nano's, working very well (using YOLOv4, full version)
Now I started to play a bit with the other examples, SSD and GoogLeNet. Basically I got it working following your instructions, no problems at all, but I wonder a few things:

Is there another model available for GoogLeNet that is better/able to detect people/pedestrians? The model synset_words.txt has a lot of other stuff but is not really suitable to detect humans (ok baseball player I found)
Does GoogLeNet provide data for bounding boxes?
If so, do you have a sample python code snippet how to extract and use it from the "out" result (out = net.forward(crop[None])) ?

Best regards, Walter

GoogLeNet is a image classification model.  It only produce 1 "class" output (0~999) for the whole image.
For detecting humans, please refer to my yolov4_crowdhuman.  I have included descriptions about Deploying onto Jetson Nano in the README.

Thank you ver y much for the explanation & links! I am actually very happy with YOLOV, it's really good, so this was just a test of the others. I will with high interest look into the links you provided
Best regards, Walter


not working for X-CSRF-TOKEN request header

Hi,
does this package also work for ajax request? its currently not working for me. i know it says it works for any page has _token, is ajax request included?
i did as laravel doc suggests:
<meta name="csrf-token" content="{{ csrf_token() }}">

$.ajaxSetup({
        headers: {
            'X-CSRF-TOKEN': $('meta[name="csrf-token"]').attr('content')
        }
});

update: i checked LaravelCafineDripMiddleware.php, and outputed $content. it turns out that the response content from my server is array instead of string since its not returning a view file. also it seems that the middleware is called twice. the first one returns content as  string, the second one returns array.

Yea, this is only for view forms. There are some scenarios where caffeine will process twice, but I haven't found s way around that yet.

Same issue here.

Can you link me to the relevant code, or post an example in a GIST? Right now this only works with forms that has the token field added. Can you add the token field to the form?

@mikebronner gist here

What if you changed your code like so:
    return `(

Import playlist

        <form><input type="hidden" name="_token" value="' + $('meta[name="csrf-token"]').attr('content') + '"></form>
        <input type="text" ref="url" />
        <button onClick={this.handleSubmit}>Submit</button>

    )`

Sure, it's a work-around, but this package isn't designed for pure AJAX forms, it depends on a form with the CSRF token being on the page, not in JavaScript.

It works, and I made the following changes:
1.Add a form to html
<form><input type="hidden" name="_token" value="{{ csrf_token() }}"></form>

2.Use the token value from hidden input when sending an ajax request
$.ajax
      headers: 'X-CSRF-TOKEN': $('input[name="_token"]').attr('value')

And I add some script to LaravelCaffeineDripMiddleware.php, cause the variable $content always return null value (???):
if (method_exists($response, 'getOriginalContent')) {
    $content = (String) $response->getOriginalContent();
}

Are you running on L5.2? This is likely due to the route not being in the web middleware group. I will have to think about ways to have this work on all middleware groups.

I am running on L5.1.
Thanks :)

done some more thinking on this and I think I have a solution. will post something in the next few days.

Just pushed update that should work on pages with the meta tag, no more fake forms! :)

@mikebronner Thanks for this fix, you are a real life saver!. Any chance this can be updated on the Laravel 5.1 version as well? My understanding is 0.3 is only for L5.2 correct?

You might try installing it in L5.1 and see if it works. Chances are it will, since I now continue as normal if there is no "web" route middleware.

Ah yes, that was what it had complained about before. I will give it a try and let you know.

Appears to work fine! I guess that means you don't have two separate versions to maintain :+1:
Thanks again, this is awesome.

Edit: I retract that statement -- appears to not work exactly.

Hi Mike,
Thanks for the update, the package works with Ajax now. However, using meta tag for Ajax means all pages will be 'awake' as meta tag will be set in a main layout file and all partial views under it will be affected. In my case, I'm using react as my view, so basically the whole site will be awake. Is there a workaround for this?
Thanks

I guess you could use a view composer to conditionally render the meta tag? Or perhaps use a blade include only on the pages that need it by creating a meta placeholder in the layout, and only populating it on the respective pages that need it?

@shangsunset If I were you, in my layout I would do something like:
<meta>

      <title>My Site</title>

      @yield('meta')

</meta>

Then in the view you might have something like:
@extends('layout')

@section('meta')

@endsection

@section('content')

@endsection

That allows you to override as @mikebronner suggested

@cillosis thanks for detailing that, exactly what I meant :)

@mikebronner @cillosis Thanks for your suggestions. They are good solutions for sites have multiple view pages. but for a site uses react as its view, it only needs on blade file, which is the layout file.

For SPA's you would want it to refresh all the time, as its really only a single page. If you don't keep it refreshed for all pages in the SPA (Single Page App), the forms will no longer work when you get to a form if the session timed out. What is your use case that makes you want to not keep the forms awake?

I want to keep forms awake, but users session wont expire even though they didnt check 'remember me'.

That is the intended behavior. User sessions will expire after they logout or close the site and don't access their session for the given timeout period (default is 120 minutes set in config/session.php).

ohh i see. thank you!


docs: add donut chart

📜 Documentation

Codecov Report

Merging #121 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #121   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files          115       115
  Lines         1282      1282
  Branches       366       366
=========================================
  Hits          1282      1282

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f37110c...f85cc75. Read the comment docs.


Add the support of RESP3 double type

This closes #1995

@jihuayu @torwig Thanks for your good reviews. All are done, plz take a look again.


os/user: query systemd’s User/Group Record Lookup API in non-cgo environments before parsing /etc/passwd?

I recently learnt about systemd’s “User/Group Record Lookup API via Varlink”.
It’s a new service introduced by systemd v245 (released March 6th 2020) which can take the role of getpwnam(3) and related calls.
We could consider this as an option for os/user, which currently integrates with Name Service Switch (NSS) only when cgo is available. In non-cgo environments, we could try querying systemd-userdbd.service(8) before falling back to the current behavior of parsing /etc/passwd.
There are two possible ways to query the service:

Parsing userdbctl --output=json. The upside is that userdbctl itself queries NSS if systemd-userdbd is not working. The downside is that we are relying on an external process. I’m not sure how this is regarded in the standard library, and whether overhead of os/user is of concern?

If we wanted to avoid the process overhead, we could integrate with systemd-userdbd directly. I implemented a <100-line proof of concept which prints just the user name. The User/Group Record Lookup API uses a subset of varlink, which boils down to sending and receiving 0-terminated JSON messages over a Unix socket.

Appendix:
userdbctl --output=json Output
{
	"userName" : "root",
	"uid" : 0,
	"gid" : 0,
	"homeDirectory" : "/root",
	"shell" : "/bin/zsh",
	"privileged" : {
		"hashedPassword" : [
			"$6$wKUquM/L7HzvV5eI$dhexy2iU1efxnYe6k0rm4qT8D1TOgAVtYYyjC5wZeClK.ETeCfPCn0xmwZKK/l8MtzJhtSPTsWEopILQXbA.40"
		]
	},
	"passwordChangeNow" : false,
	"lastPasswordChangeUSec" :<PHONE_NUMBER>000000,
	"status" : {
		"12f5c9abd57d4914abe2d5cb4958378b" : {
			"service" : "io.systemd.NameServiceSwitch"
		}
	}
}
{
	"userName" : "nobody",
	"uid" : 65534,
	"gid" : 65534,
	"realName" : "Nobody",
	"homeDirectory" : "/",
	"shell" : "/bin/nologin",
	"passwordChangeNow" : false,
	"lastPasswordChangeUSec" :<PHONE_NUMBER>000000,
	"status" : {
		"12f5c9abd57d4914abe2d5cb4958378b" : {
			"service" : "io.systemd.NameServiceSwitch"
		}
	}
}
{
	"userName" : "systemd-network",
	"uid" : 983,
	"gid" : 983,
	"realName" : "systemd Network Management",
	"homeDirectory" : "/",
	"shell" : "/bin/nologin",
	"passwordChangeNow" : false,
	"lastPasswordChangeUSec" :<PHONE_NUMBER>000000,
	"status" : {
		"12f5c9abd57d4914abe2d5cb4958378b" : {
			"service" : "io.systemd.NameServiceSwitch"
		}
	}
}
{
	"userName" : "systemd-resolve",
	"uid" : 982,
	"gid" : 982,
	"realName" : "systemd Resolver",
	"homeDirectory" : "/",
	"shell" : "/bin/nologin",
	"passwordChangeNow" : false,
	"lastPasswordChangeUSec" :<PHONE_NUMBER>000000,
	"status" : {
		"12f5c9abd57d4914abe2d5cb4958378b" : {
			"service" : "io.systemd.NameServiceSwitch"
		}
	}
}
{
	"userName" : "systemd-timesync",
	"uid" : 981,
	"gid" : 981,
	"realName" : "systemd Time Synchronization",
	"homeDirectory" : "/",
	"shell" : "/bin/nologin",
	"passwordChangeNow" : false,
	"lastPasswordChangeUSec" :<PHONE_NUMBER>000000,
	"status" : {
		"12f5c9abd57d4914abe2d5cb4958378b" : {
			"service" : "io.systemd.NameServiceSwitch"
		}
	}
}
{
	"userName" : "systemd-coredump",
	"uid" : 980,
	"gid" : 980,
	"realName" : "systemd Core Dumper",
	"homeDirectory" : "/",
	"shell" : "/bin/nologin",
	"passwordChangeNow" : false,
	"lastPasswordChangeUSec" :<PHONE_NUMBER>000000,
	"status" : {
		"12f5c9abd57d4914abe2d5cb4958378b" : {
			"service" : "io.systemd.NameServiceSwitch"
		}
	}
}
{
	"userName" : "systemd-network",
	"uid" : 101,
	"gid" : 101,
	"realName" : "network",
	"homeDirectory" : "/run/systemd/netif",
	"shell" : "/bin/false",
	"passwordChangeNow" : false,
	"lastPasswordChangeUSec" :<PHONE_NUMBER>000000,
	"status" : {
		"12f5c9abd57d4914abe2d5cb4958378b" : {
			"service" : "io.systemd.NameServiceSwitch"
		}
	}
}
{
	"userName" : "systemd-resolve",
	"uid" : 105,
	"gid" : 105,
	"realName" : "resolve",
	"homeDirectory" : "/run/systemd/resolve",
	"shell" : "/bin/false",
	"passwordChangeNow" : false,
	"lastPasswordChangeUSec" :<PHONE_NUMBER>000000,
	"status" : {
		"12f5c9abd57d4914abe2d5cb4958378b" : {
			"service" : "io.systemd.NameServiceSwitch"
		}
	}
}
{
	"userName" : "sshd",
	"uid" : 102,
	"gid" : 102,
	"homeDirectory" : "/",
	"shell" : "/bin/false",
	"status" : {
		"12f5c9abd57d4914abe2d5cb4958378b" : {
			"service" : "io.systemd.NameServiceSwitch"
		}
	}
}
{
	"userName" : "messagebus",
	"uid" : 106,
	"gid" : 106,
	"homeDirectory" : "/var/run/dbus",
	"shell" : "/bin/false",
	"status" : {
		"12f5c9abd57d4914abe2d5cb4958378b" : {
			"service" : "io.systemd.NameServiceSwitch"
		}
	}
}
{
	"userName" : "lightdm",
	"uid" : 979,
	"gid" : 979,
	"realName" : "Light Display Manager",
	"homeDirectory" : "/var/lib/lightdm",
	"shell" : "/bin/nologin",
	"passwordChangeNow" : false,
	"lastPasswordChangeUSec" :<PHONE_NUMBER>000000,
	"status" : {
		"12f5c9abd57d4914abe2d5cb4958378b" : {
			"service" : "io.systemd.NameServiceSwitch"
		}
	}
}
{
	"userName" : "polkitd",
	"uid" : 978,
	"gid" : 978,
	"realName" : "PolicyKit Daemon",
	"homeDirectory" : "/etc/polkit-1",
	"shell" : "/bin/nologin",
	"passwordChangeNow" : false,
	"lastPasswordChangeUSec" :<PHONE_NUMBER>000000,
	"status" : {
		"12f5c9abd57d4914abe2d5cb4958378b" : {
			"service" : "io.systemd.NameServiceSwitch"
		}
	}
}

We could also implement LDAP, but we've historically decided not to.  What is the use case we're addressing here?  Why do programs that use os/user want to avoid using cgo?  And should this functionality live in a third party package instead?

We could also implement LDAP, but we've historically decided not to.

While related, that’s a much different call IMO: here, we implement 1 reasonably small API and get access to all NSS plugins.

What is the use case we're addressing here?
Why do programs that use os/user want to avoid using cgo?

I’m not saying they do.
I’m saying that when disabling cgo for whichever reason, there is a feature disparity in os/user, and we could decide to fix it for some environments. Not sure if that scenario is something we should care about. Just wanted to mention this and see what people think.

And should this functionality live in a third party package instead?

It certainly could. The downside of course is that users then first need to discover that package. I think that instead of having each programmer find out about the os/user behavior and having them pull in a third-party package, it would be nicer if os/user just worked in that scenario.

Also /cc @bradfitz @kevinburke per owners.

While related, that’s a much different call IMO: here, we implement 1 reasonably small API and get access to all NSS plugins.

That's a pretty compelling argument, actually.
As for whether we use os/exec: I don't feel strongly either way. Both options involve encoding/json, and the do-it-ourselves way doesn't look super invasive. I'd say do it ourselves if that meant running in more environments or if it was a hot path, but I can't imagine any environment that wouldn't have userdbctl but would have systemd, and I can't imagine this being too hot.

Cool! Does someone want to send a CL, or should I give it a shot when I find a minute?

Looks like nobody wants to race me to it, so I’ll give it a shot over the weekend.

Here’s how far I have come so far: https://github.com/stapelberg/go/commit/87fae81a97dd39ad84b63c0e59deefda9e1afe0b
I’ll try and spend a few more minutes on turning this into a Gerrit CL for proper review next week.

Sent the corresponding CL: https://go-review.googlesource.com/c/go/+/256218

CL was reverted.


Use Write trait in prerendered module.

Hi,
I had quite some difficulty getting this to work on a Raspberry Pi using rppal. I finally figured out it was because FullDuplex is too slow since it sends every byte individually. Since the embedded_hal::blocking::spi::Write trait allows sending a complete byte slice, it works well with the prerendered approach. Should the prerendered module also use the Write trait?

On most mikrocontrollers, the HAL implementations wait for each byte to be received before sending the next one. This is a bit too slow for this code and thus leads to issues, which is why we deliberately introduce the offset using FullDuplex, so we can send the next byte while the previous one is still transmitted.
Does using the Write trait make it work on the Raspberry Pi?

Yes, with Write it works on the Raspberry Pi. I tried first with https://github.com/jgarff/rpi_ws281x, which worked correctly, so I then dug into the source code and found it does a transfer of a complete prerendered buffer. So either embedded_hal::blocking::spi::Transfer or embedded_hal::blocking::spi::Write would work.

Mmh, Write won't work on many MCUs, so we have to add some kind of configuration.
I think it may make more sense to split it into yet another module, since the long low time at the end (and possibly at the start) won't work as a separate call on all linux platforms, but it would take a lot of ram on MCUs to add it in the buffer.
I think a separate backend based on prerendered would be the best option (hosted?).
Perhaps even with std so no need to pass a separate buffer.
@reitermarkus Does that sound reasonable to you?

I had a similar issue on STM32F0 devices: FullDuplex is not implemented, however blocking::spi::Write and others are.
I created a patch https://github.com/smart-leds-rs/ws2812-spi-rs/pull/28 that converts everything to write, however I am not sure if that has sideffects in other implementations. It does work on a STM32F030C8Tx and I would expect it to work on ESP and RPI (Those devices should be fast). Unsure what sideffects it would have on slower devices.
Maybe creating a feature that chooses between fullduplex and write would help.

With v0.5.0 we updated to embedded-hal v1.0 which provides a different set of traits


Derive Default for structs

A large number of structs are passed by-reference to functions which write them, and in this case, it's particularly useful to be able to easily construct a zeroed-out version of the struct instead of writing it by hand. At least in my particular case, I was interested in doing this for the passwd struct, but since I know it's not the only one, I decided to try a blanket-impl approach.
This is only done when you have the extra-traits feature enabled, so, it shouldn't affect build time without this feature enabled.
You could argue that doing MaybeUninit::zeroed().assume_init() is okay even though it's unsafe code, since users of this library are already likely using a lot of unsafe code. I don't like this argument, since Default feels a lot more idiomatic, and reducing the number of unsafe blocks is still good imho.

r? @JohnTitor
(rust-highfive has picked a reviewer for you, use r? to override)

Gonna close this; don't have the time to finish it and it's not super important for now.


Service without selectors, command correction issue #33361

Service without selectors.
Correct command from proxy to port-forward.
issue #33361

/assign

Hi @sftim, can you review?

Hi @sftim, can you review?

I'm happy to let the assigned reviewers check the changes. I did spot that the PR title isn't right (we prefer not to include issue IDs).
/retitle Service without selectors, command correction issue

/unassign

Page preview:
https://deploy-preview-44099--kubernetes-io-main-staging.netlify.app/docs/concepts/services-networking/service/#service-no-selector-access

👋 @ahmedavid .
I'm interested in a technical review for this change.
/sig network

@kubernetes/sig-network-pr-reviews Hi folks – we'd love to get your eyes on this PR for accuracy, thanks!

/remove-lifecycle rotten

Left a message on the Slack channel

/lgtm
Though I think the original comment refers to this proxying https://kubernetes.io/docs/tasks/access-application-cluster/access-cluster-services/#manually-constructing-apiserver-proxy-urls , the existing command is indeed wrong


After focusing a text field, typing always raises the keyboard?

https://user-images.githubusercontent.com/298850/104585150-8b0f9900-565b-11eb-846c-083c25879372.mp4
Please see the above video, after focusing a text field, my app will always raise the keybaord even if the textfield is no longer selected?
The code for this text field is as follows:
TextField(
  autofocus: false,
  controller: _textController,
  minLines: 1,
  maxLines: 1,
  onSubmitted: (_) => _searchTextUpdated(),
  decoration: InputDecoration(
    fillColor: Colors.grey.shade100,
    filled: true,
    border: InputBorder.none,
  ),
)

A different part of my app uses the RawKeyboardListener for keyboard controls and having the keyboard occassionaly appear if the user has previously focused a text field is causing issues.

@jimmyff
Can you provide flutter doctor -v and a complete minimal reproducible code sample that shows the issue ?
Also, does the issue occur on physical device too ?

@jimmyff
Can you provide flutter doctor -v and a complete minimal reproducible code sample that shows the issue ?
Also, does the issue occur on physical device too ?

Without additional information, we are unfortunately not sure how to resolve this issue.
We are therefore reluctantly going to close this bug for now.
Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.
Could everyone who still has this problem please file a new issue with the exact description of what happens, logs, and the output of flutter doctor -v.
All system setups can be slightly different, so it's always better to open new issues and reference related issues.


ERROR:Uncaught exception occured. 'Chat' object has no attribute 'username'

Hello!
I get this strange error and can't figure out what is causing it:
"ERROR:Uncaught exception occured. 'Chat' object has no attribute 'username'"
I successfully got and entered verification code from Telegram.
I'm using multi-word name of the chat.
Python 3.6.5
Linux Mint 18.3 (if it matters)

Any ideas on what is causing it?

Found an issue in code after debugging

The object "Chat" has no such field "username", but it has "title".
After I changed "username" to "title", everything started to work fine.
Will PR on this soon, but additional testing might be useful.

Thank you. I've accepted your PR and fixed the Travis MacOS build.
Cheers!


[AppPlatform] Upgrade API version and polish the API

Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.

API change check
APIView has identified API level changes in this PR and created following API reviews.
Azure.ResourceManager.AppPlatform


Split dpnp_skip_test() because it responsible for 2 functions

check device exists
check dpnp exists

If dpnp_skip_test() is not used then DPNP tests fails too even if they run on existing device like CPU.

The function no longer exists in numba-dpex


Mem protocol

Basic memcache protocol support;

Handle get from a single server.
Handle get success/fail cases

I think this everyone involved moved past this, so closing this request.


test: test to unique id module

Contribution description
Added test to unique id component.

Testing procedure
cd test/uniqueid
make BOARD="your_board" flash term

Issues/PRs references

test command is:
make BOARD="your_board" flash test


Staging 01

The following changes have been made:

Updates to Project page - additional color in Oceanica project style guide
Updates to Project page - additional project added (Lite Life)
Updates to LICENSE.md
Updates to README.md

This PR is ready to be created.

Branch successfully merged. This PR will now be closed.


print html path if savePageSource is true.

#210
# JUnit error message

Element not found {#hello}
Expected: visible
Screenshot: file:/C:/zz.%20My%20Works/10.%20works/UI_TEST/build/reports/tests/com/nhnent/tc/console/ui/BasicCheck/test1/1503627588218.0.png
Html: file:/C:/zz.%20My%20Works/10.%20works/UI_TEST/build/reports/tests/com/nhnent/tc/console/ui/BasicCheck/test1/1503627588218.0.html
Timeout: 10 s.
Caused by: NoSuchElementException: no such element: Unable to locate element: {"method":"css selector","selector":"#hello"}

Hi @hyunil-shin
Please, fix checkstyle issues:
https://travis-ci.org/codeborne/selenide/builds/268212431?utm_source=github_status&utm_medium=notification
....
[ant:checkstyle] Running Checkstyle 6.19 on 147 files
[ant:checkstyle] [ERROR] /home/travis/build/codeborne/selenide/src/main/java/com/codeborne/selenide/ex/ErrorMessages.java:42:7: 'if' is not followed by whitespace. [WhitespaceAround]
[ant:checkstyle] [ERROR] /home/travis/build/codeborne/selenide/src/main/java/com/codeborne/selenide/ex/ErrorMessages.java:43: 'if' have incorrect indentation level 7, expected level should be 6. [Indentation]
[ant:checkstyle] [ERROR] /home/travis/build/codeborne/selenide/src/main/java/com/codeborne/selenide/ex/ErrorMessages.java:43:10: 'if' is not followed by whitespace. [WhitespaceAround]
[ant:checkstyle] [ERROR] /home/travis/build/codeborne/selenide/src/main/java/com/codeborne/selenide/ex/ErrorMessages.java:44: 'if' child have incorrect indentation level 10, expected level should be 8. [Indentation]
[ant:checkstyle] [ERROR] /home/travis/build/codeborne/selenide/src/main/java/com/codeborne/selenide/ex/ErrorMessages.java:45: 'if rcurly' have incorrect indentation level 7, expected level should be 6. [Indentation]
[ant:checkstyle] [ERROR] /home/travis/build/codeborne/selenide/src/main/java/com/codeborne/selenide/ex/ErrorMessages.java:46: 'if' child have incorrect indentation level 7, expected level should be 6. [Indentation]
[ant:checkstyle] [ERROR] /home/travis/build/codeborne/selenide/src/main/java/com/codeborne/selenide/ex/ErrorMessages.java:48:6: 'else' is not preceded with whitespace. [WhitespaceAround]
[ant:checkstyle] [ERROR] /home/travis/build/codeborne/selenide/src/main/java/com/codeborne/selenide/ex/ErrorMessages.java:48:6: '}' is not followed by whitespace. [WhitespaceAround]
[ant:checkstyle] [ERROR] /home/travis/build/codeborne/selenide/src/main/java/com/codeborne/selenide/ex/ErrorMessages.java:49: 'else' child have incorrect indentation level 7, expected level should be 6. [Indentation]

@BorisOsipov  Thank you for your feedback.
I got many "Missing a Javadoc comment" errors in my environments (gradle check). How can I get the same result as Travis CI?
[ant:checkstyle] [ERROR] E:\selenide\src\main\java\com\codeborne\selenide\impl\Html.java:10:3: Missing a Javadoc comment. [JavadocMethod]
[ant:checkstyle] [ERROR] E:\selenide\src\main\java\com\codeborne\selenide\impl\Html.java:14:3: Missing a Javadoc comment. [JavadocMethod]
[ant:checkstyle] [ERROR] E:\selenide\src\main\java\com\codeborne\selenide\impl\Html.java:18:3: Missing a Javadoc comment. [JavadocMethod]
[ant:checkstyle] [ERROR] E:\selenide\src\main\java\com\codeborne\selenide\impl\Html.java:22:3: Missing a Javadoc comment. [JavadocMethod]
[ant:checkstyle] [ERROR] E:\selenide\src\main\java\com\codeborne\selenide\impl\Html.java:26:3: Missing a Javadoc comment. [JavadocMethod]

@hyunil-shin yes it's windows issue :(. On linux gradle check works well.

Coverage increased (+0.2%) to 64.415% when pulling a3e84f3fdaa5179377ccc6f56c901120baaaff1a on hyunil-shin:print_html_path into fadbd5801c18167684fd02e8e9b332cb0a27abd1 on codeborne:master.

Codecov Report

Merging #590 into master will increase coverage by 0.24%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master     #590      +/-   ##
============================================
+ Coverage     60.17%   60.41%   +0.24%
- Complexity      723      728       +5
============================================
  Files           134      134
  Lines          2644     2650       +6
  Branches        267      269       +2
============================================
+ Hits           1591     1601      +10
+ Misses          947      943       -4
  Partials        106      106

Impacted Files
Coverage Δ
Complexity Δ

.../java/com/codeborne/selenide/ex/ErrorMessages.java
86.2% <100%> (+3.59%)
17 <1> (+4)
:arrow_up:

...e/selenide/impl/WebDriverThreadLocalContainer.java
77.93% <0%> (+0.68%)
30% <0%> (ø)
:arrow_down:

...java/com/codeborne/selenide/commands/ScrollTo.java
100% <0%> (+75%)
2% <0%> (+1%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fadbd58...a3e84f3. Read the comment docs.

@hyunil-shin Thank you!


Nested and related data?

Sorry to open this as an issue but I noticed you've previously said you don't get notifications for Discussions.
Has there been any further movement on supporting one->many queries? Or a pattern I should be following?
_Originally posted in https://github.com/tinyplex/tinybase/discussions/18

Do you mean one-to-many (which hopefully can be modeled via the relationships or queries module) or many-to-many?

Ok so I see the challenge here: you are using a cell called 'Id' rather than the native rowId (which is used in join conditions).
It's not possible to create a join based on columns in both tables. Instead you need to create an expression based on columns in one table (the 'root' table) that identifies the rowId to join to.
Is it possible for you to use id also as the rowId?

...Not to say your requirement isn't a valid one - just seeing if that helps you out for now.


Configuration card works on private machines that is owned by another player

After finding a item called configuration card I decided to try it out, after some testing I found that I can "paste" a configuration to a machine that is set to private and is owned by another player, that sounds wrong. If I try to open a machine it tells me I don't have access.
I tried this on a server with Mekanism 9.0.2 and I am op on the server.

Fixed, thanks. Definitely not intentional :)


Loading wrong mc version

VERSION env variable set to 1.17 yet container loads 1.17
[init] Resolved version given 1.17 into 1.17
[15:21:55] [main/INFO]: Loading for game Minecraft 1.17.1
[15:21:55] [main/FATAL]: A critical error occurred
net.fabricmc.loader.discovery.ModResolutionException: Could not find required mod: voicechat requires {minecraft @ [1.17]}

If you got around this, what was the solution?


Fix docsearch dependency version

Questions
Answers

Description?
Fix docsearch dependency version.

Type?
refacto

BC breaks?
no

Deprecations?
no

Fixed ticket?
Na.

How to test?
Search should still work.

Possible impacts?
Search may be broken.

Let's see :)

@kpodemski If I am not wrong we need to trigger a rebuild of the devdocs Hugo website manually for this change to be acknowledged

@matks it's available online, and I didn't do anything apart from merging this PR


Bot can't find certain tickers

For some reason the bot can not find stocks like XOM (Exxon) and CVX (Chevron). I do not know why

Look into this later: https://github.com/ranaroussi/yfinance/issues/268


KMP String Matching Algorithm in C++

Would you like to work on the issue?
Yes, I would like to contribute. Please assign this issue to me.

I would like to contribute to this topic, @piyush6348 @akshat2412 can you assign this issue to me?


Support sirepo.jupyterhub.uri and jupyterhub.sirepo_uri

We need to pass configuration to both servers so just have two parameters with reasonable defaults.
Possibly add a check in component.jupyterhub_proxy and component.sirepo to ask if jupyterhub.sirepo_uri is set or not, appropriately.

@e-carlin do you remember why I created this?

I don't.

I think we don't need this anymore.


unable to open image with large-scale  sizes of 10507x75650x3

The tif aviation image file to be labeled occupies 1.41GB of disk space. The labelImg app （win version) is unable open such image of large-scale sizes of 10507x75650x3 .  So the labeling work can not be carried on.

What specific error messages are you receiving? And are you using the latest release (v.1.7.0)?
Also, could you provide an example image for us to work with?

Thank you. Yes, we used the latest release (v.1.7.0).  The specific error message(s) are :  Error opening file Make sure D:/mosaic1.tif is a valid image file. How can we transfer it to you?

If you don't mind sharing it publicly, I would recommend uploading it to a free Dropbox account and posting the link here.
In the meantime, you could try converting the tif file to a jpeg and letting us know if it continues to blow up.

I have tried to converting the format of tif file to a jpg or jpeg by using the function of imwrite() in Matlab, but it failed with wrong message of "Maximum supported image dimension is 65500 pixels". It can be converted to jp2 or jpx file belonging to the format of JPEG 2000, however the labelimg could not handle this type of file. For the sharing data publicly issue, I have to ask for our leader Dr. Lee's permission.

One thing I forgot to ask, @billrange: Have you tried training with these images before? I'm not sure if your framework (Tensorflow/Darknet/etc.) and graphics card(s) will be able to support such large sizes either...

Closing due to inactivity. Please feel free to reopen.

I have the same issue: I have a large bmp image that is about 420 MB (18k x 24k pixels), and labelImg won't open it: Error opening file: make sure <image_path> is a valid image file. I have smaller files in the same format (10k x 12k pixels, about 130 MB file), and it opens fine.

Note getting to your question about whether tensorflow could even handle these large images, I tested out tensorflow with an image sized 350 MB and it was able to work (faster-rcnn for object detection), but will not open in labelImg.

The reason might be that the LabelImg applicaiton loads the whole image to the memory without considering the unordinarily large sizes of image. I suggest that the software firstly divides the image into the fixed sizes of fractions when dealing with the large-scale image and then loading the fixed sizes of image. When the divided image is moved to the boundary of adjecent divided image, then load the other image to memory to facilitate the labeling. Hope it works, thanks!


Invoke-WebRequest should allow body content on DELETE

Invoke-WebRequest should allow body content on DELETE, and perhaps any verb.
Whenever I run into an API that accepts data on DELETE, I am hamstrung by the client-side enforcement of which verbs can send a body and which cannot. For example, posting data on DELETE is used by many applications such as tumblr/collins to log reasons server-side. This may or may not be a good use of verbs and APIs, but I can't fix the server. I'm required to reimplement Invoke-WebRequest around System.Net.HttpWebRequest::CreateHttp to get the request in the shape that I need. Allowing the user to send a body with any verb is going to allow some needed flexibility in our world of varying APIs. Having a request fail because Invoke-WebRequest can only query perfect APIs will keep people from using it. Curl is a good example of how an API consumer should be less opinionated because it's a part of an imperfect world. With curl, if I construct an HTTP request that follows the core of HTTP but mismatches verbs, content, headers, etc, that's really my prerogative. If the goal for PowerShell 6.0 is to be amazing in the cloud, it has to be amazing in some rainier clouds.
As far as HTTP standards, body content on DELETE has some discussion here:
http://stackoverflow.com/questions/299628/is-an-entity-body-allowed-for-an-http-delete-request
Thank you for your time. I love love PowerShell.

> $PSVersionTable
Name                           Value
----                           -----
PSVersion                      6.0.0-beta
PSEdition                      Core
BuildVersion                   <IP_ADDRESS>
CLRVersion
GitCommitId                    v6.0.0-beta.1
OS                             Darwin 16.5.0 Darwin Kernel Version 16.5.0: Fri Mar  3 16:52:33 PST 2017; root:xnu-3789.51.2~3/RELEASE_X86_64
Platform                       Unix
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

@JasonRitchie Thanks for your report!

@JasonRitchie is there a specific scenario/api that fails because we don't allow body on DELETE?  I'm trying to prioritize this work.  Thanks.

@SteveL-MSFT This appears to be fixed (likely due to upstream changes). I can no longer repro this.
@JasonRitchie  Can you confirm this is no longer an issue?
$Body = "Test"
Invoke-WebRequest -Method DELETE -Body $Body -uri https://httpbin.org/delete
Invoke-RestMethod -Method DELETE -Body $Body -uri https://httpbin.org/delete

Result:
StatusCode        : 200
StatusDescription : OK
Content           : {
                      "args": {},
                      "data": "Test",
                      "files": {},
                      "form": {},
                      "headers": {
                        "Connection": "close",
                        "Content-Length": "4",
                        "Host": "httpbin.org",
                        "User-Agent": "Mozilla/5.0 (Wi...
RawContent        : HTTP/1.1 200 OK
                    Connection: keep-alive
                    Date: Tue, 03 Oct 2017 09:23:03 GMT
                    Via: 1.1 vegur
                    Server: meinheld/0.6.1
                    Access-Control-Allow-Origin: *
                    Access-Control-Allow-Credentials: true
                    X-Powered-...
Forms             :
Headers           : {[Connection, System.String[]], [Date, System.String[]], [Via, System.String[]], [Server,
                    System.String[]]...}
Images            : {}
InputFields       : {}
Links             : {}
ParsedHtml        :
RawContentLength  : 360
RelationLink      : {}

args    :
data    : Test
files   :
form    :
headers : @{Connection=close; Content-Length=4; Host=httpbin.org; User-Agent=Mozilla/5.0 (Windows NT; Microsoft
          Windows 10.0.15063 ; en-US) PowerShell/6.0.0}
json    :
origin  : <IP_ADDRESS>
url     : https://httpbin.org/delete

$PSversionTable:
Name                           Value
----                           -----
PSVersion                      6.0.0-beta.7
PSEdition                      Core
GitCommitId                    v6.0.0-beta.7-83-g417e9889399e2e0e6a90d52ff58ae08ec08b1cf2
OS                             Microsoft Windows 10.0.15063
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

I believe this was a lack of understanding on my part.
I dug back into this and tried to reproduce it, and I was able to, but resolving it was as simple as setting -ContentType correctly. This worked even when I rolled back to beta.1.
I'll give the details here for anyone else who may come across this.
In my initial naive attempt, you can see the body content is sent in query string format as the "data" content. The application I was hitting, tumblr collins, would have none of this. I have to admit I spent far too long stuck on this and I didn't have the understanding back then to identify the real issue.
Invoke-WebRequest -Method DELETE -Body $Body -uri https://httpbin.org/delete -Headers @{'authorization'='basic thing'}
                                                                                StatusCode        : 200                                                                                StatusDescription : OK
Content           : {
                      "args": {},
                      "data": "baz=qux&reason=no+reason&foo=bar",
                      "files": {},
                      "form": {},
                      "headers": {
                        "Accept": "*/*",
                        "Authorization": "basic thing",
                        "Connection": "close",
                       ...
RawContent        : HTTP/1.1 200 OK
                    Connection: keep-alive
                    Server: meinheld/0.6.1
                    Date: Tue, 03 Oct 2017 14:01:03 GMT
                    Access-Control-Allow-Origin: *
                    Access-Control-Allow-Credentials: true
                    X-Powered-By: Flask
                    X-Processed-...
Forms             :
Headers           : {[Connection, System.String[]], [Server, System.String[]], [Date, System.String[]], [Access-Control-Allow-Origin, System.String[]]...}
Images            : {}
InputFields       : {}
Links             : {}
ParsedHtml        :
RawContentLength  : 535

Today as I revisited this I compared the behavior of POST to DELETE. DELETE doesn't set a content type by default. I have no problem with this behavior. In fact, I found this behavior defined in the official documentation.
https://docs.microsoft.com/en-us/powershell/module/microsoft.powershell.utility/invoke-webrequest?view=powershell-6
If this parameter is omitted and the request method is POST, Invoke-WebRequest sets the content type to application/x-www-form-urlencoded. Otherwise, the content type is not specified in the call.
Here is all it took:
Invoke-WebRequest -Method DELETE -Body $Body -uri https://httpbin.org/delete -Headers @{'authorization'='basic thing'} -ContentType 'application/x-www-form-urlencoded'
                                                                                StatusCode        : 200                                                                                StatusDescription : OK
Content           : {
                      "args": {},
                      "data": "",
                      "files": {},
                      "form": {
                        "baz": "qux",
                        "foo": "bar",
                        "reason": "no reason"
                      },
                      "headers": {
                        "Accept": "*/*",
                        "Authorization": "basic thing...
RawContent        : HTTP/1.1 200 OK
                    Connection: keep-alive
                    Server: meinheld/0.6.1
                    Date: Tue, 03 Oct 2017 14:13:48 GMT
                    Access-Control-Allow-Origin: *
                    Access-Control-Allow-Credentials: true
                    X-Powered-By: Flask
                    X-Processed-...
Forms             :
Headers           : {[Connection, System.String[]], [Server, System.String[]], [Date, System.String[]], [Access-Control-Allow-Origin, System.String[]]...}
Images            : {}
InputFields       : {}
Links             : {}
ParsedHtml        :
RawContentLength  : 628
RelationLink      : {}

I'll try to learn from this. I appreciate your time. I personally have no reason for this request to remain open.


Add Nong Song: Kompa Pasion

Song Name
Kompa Pasion
Artist Name
Frozy
Source
Youtube
Youtube Link
https://www.youtube.com/watch?v=-w5K08th9OA
Direct File Link
No response
Song ID
739028
Start Offset [ms]
No response
Extra
No response

accept
On Sat, Oct 26, 2024 at 12:44 PM auto-nong[bot] @.***>
wrote:

Thanks for contributing!
Someone will soon review your request.
Here is the JSON result for the reviewer:
{
"name": "Kompa Pasion",
"artist": "Frozy",
"source": "youtube",
"startOffset": 0,
"yt-id": "-w5K08th9OA",
"songs": [
739028
]
}
To accept the request, a reviewer needs to write "accept".
—
Reply to this email directly, view it on GitHub
https://github.com/FlafyDev/auto-nong-indexes/issues/5430#issuecomment-2439167915,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BKXL7HFVDVOX3SGUBLJR3STZ5LXWDAVCNFSM6AAAAABQUJWTPSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMZZGE3DOOJRGU
.
You are receiving this because you authored the thread.Message ID:
@.***>


Need to fix -- Langroid import error in Colab notebook, with Python 3.10

Langroid requires Python 3.11, however google colab has Python 3.10.
This causes an error when we import langroid.
https://colab.research.google.com/drive/1v6lbtsUCNY0LNZTNqLRPP5GNX6Dh1ZnS?usp=sharing
Error trace
TypeError                                 Traceback (most recent call last)
[<ipython-input-2-916af5008211>](https://localhost:8080/#) in <cell line: 1>()
----> 1 import langroid as lr

7 frames
[/usr/lib/python3.10/typing.py](https://localhost:8080/#) in _type_check(arg, msg, is_argument, module, allow_special_forms)
    174         return arg
    175     if not callable(arg):
--> 176         raise TypeError(f"{msg} Got {arg!r:.100}.")
    177     return arg
    178

TypeError: Tuple[t0, t1, ...]: each t must be a type. Got <module 'PIL.Image' from '/usr/local/lib/python3.10/dist-packages/PIL/Image.py'>.

The core problem is that on google colab, when doing pip install langroid, it installs the max version compatible with Python 3.10, which is langroid==0.1.226 (whereas we are currently at 0.1.238).

Turns out the problem was simply the python version restriction in the pyproject.toml - I had recently changed it to be >=3.11,<3.12. I changed it to >=3.10,<3.12 and it's fine now.


Update OpenSSL RNG Override Unit Test

Issue # (if available): N/A
Description of changes:
Fixed s2n_override_openssl_random_test.c to work with OpenSSL versions that have commit  https://github.com/openssl/openssl/commit/ddd16c2fe988ed9fdd5118c2f2617745438fd675
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

:exclamation: No coverage uploaded for pull request head (ossl_rng_override@f0f2b94). Click here to learn what that means.
The diff coverage is n/a.


Improve rule bot code

The following improvements have been made:

Introduce a base class for the capabilities types

This base class is responsible for calling the method to read the configuration from the configuration file. Each derived class will need to implement that method.

Tests have been added to ensure that the payloads that we generate are in the expected shape.
Simplify the code to generate the payload. Instead of using string templates and doing string replacement for tokens, we are now generating JObject objects that represent the payload

This does mean that we are taking a dependency to Newtonsoft.Json for creating JSON objects but there isn't a good alternative to do the same using System.Text.Json

The code for describing an entry for the PR labeler is moved to a new file, similar to TriageConfig.
Change the ContainsWildcard from a stand-alone property to a calculated one. This means that when a new CodeOwnerEntry object is created you only need to specify the pathExpression

LGTM, although I wonder if we should change the build pipeline to also execute the tests?

LGTM, although I wonder if we should change the build pipeline to also execute the tests?

@mitchdenny yeah -- I would like to have the tests run as well (since now we have some tests 🙂)
Is this the right way to do it? https://github.com/Azure/azure-sdk-tools/blob/master/tools/check-enforcer/ci.yml#L29

@mitchdenny yeah -- I would like to have the tests run as well (since now we have some tests 🙂)
Is this the right way to do it? https://github.com/Azure/azure-sdk-tools/blob/master/tools/check-enforcer/ci.yml#L29

That parameter is designed to work with the functions template. I don't think we've put any test infrastructure into .NET tools, I guess we should do that now.

That parameter is designed to work with the functions template. I don't think we've put any test infrastructure into .NET tools, I guess we should do that now.


Function - Text Cleaning (Function and Testing)

Cleaning function

idea to think about. Customize stop words list.
remove punctuations and special characters

I will be working on this task. Thanks Gretel!


Update terra-functional-testing to 4

Summary

This PR updates terra-functional-testing to 4. As part of that upgrade, webpack was updated to 5 and npm 9 support was added.
Note: graphs only had the default-theme screenshots generated.
Testing

This change was tested using:

[x] WDIO
[ ] Jest
[ ] Visual testing (please attach a screenshot or recording)
[ ] Other (please describe below)
[ ] No tests are needed

In addition to to wdio tests, this was tested by running npm start successfully after the webpack upgrade.
Reviews
In addition to engineering reviews, this PR needs:

[ ] UX review
[ ] Accessibility review
[ ] Functional review

Additional Details

Thank you for contributing to Terra.
@cerner/terra

Note: This PR will not pass the build as webpack 5 is not compatible with the current Karma 6. @adoroshk and I tried looking for an easy solution to address the incompatibility, however we couldn't find a quick & easy fix. At this point, it's better to switch over to Jest for better compatibility with the rest of the Terra ecosystem, then investing in extended time for a  temporary fix. That work will be done in a subsequent PR/Jira.


Automatically choose needed precision

Configbrot should automatically select the appropriate precision for a given zoom.
This should respect autodetection of numeric system.

Ahhh wrong issue.  I will someday remember what page I am on.


[1.21] Simple Compacting Drawer Lang ID Missing

Functional Storage Version: 1.3.6
The Lang file for english is missing the simple compactoing drawer name

Same.

Was on my way to report the same issue.


Homepage: Incorrect redirection of Jetzt Anmelden CTA

Hi @helms-charity,
Please see bug details below:
Steps to Reproduce:

Access https://eds-www.888.de/
Click any of the CTA in the highlighted image below.
Notice that it redirects to www.888.de

Expected Result:
It should redirect to the registration form of relevant site.

@jeric888williamhill issue is fixed...Please review.

Hi @kailasnadh790,
This issue has been fixed verified.
Closing this issue.
Thanks!