No vblank markers on AMD Navi 10

I'm running an AMD RX 5700 (Navi 10) and in the output no vblank markers are shown.
Checkbox Show crtc0 markers (~16.67ms) is selected.
On Intel they are shown.
I assume the AMD kernel driver just does not provide these events? Or is there a different issue?

Those should just be drm_vblank_event events, and it looks like those come from drivers/gpu/drm/drm_vblank.c in the kernel. I'd guess they should work on AMD...
Can you do a "trace-cmd report" on your .dat file and see if those "drm_vblank*" events are in there?

Thanks for the info.
I tried to run trace-cmd report on the .dat file but got some errors. I was using the trace-cmd AUR package.
So I compiled trace-cmd from master and now I can execute the above command and it shows indeed drm_vblank_event in the output. :+1:
But now I'm getting an error when trying to open the file in GPUVis:
Error handle_otpions: unknown option 11
Error read_trace_file: setjmp error called for trace_06-15-2020_20-11-53.dat.
Error load_trace_file(trace_06-15-2020_20-11-53.dat) failed.

Compiling the branch trace-cmd-stable-v2.8 is not possible for me at the moment. Get the error:
/usr/bin/ld: /home/roman/dev/ftrace/trace-cmd/src/tracecmd/trace-mem.o:/home/roman/dev/ftrace/trace-cmd/src/tracecmd/trace-mem.c:33: multiple definition of `common_type_field'; /home/roman/dev/ftrace/trace-cmd/src/tracecmd/trace-hist.o:/home/roman/dev/ftrace/trace-cmd/src/tracecmd/trace-hist.c:30: first defined here

So it would be nice to make GPUVis work with trace-cmd master. Shall I open a new issue for that?

Shall I open a new issue for that?

Yes, please. Looks like they added TRACECMD_OPTION_PROCMAPS, TRACECMD_OPTION_TRACEID, and TRACECMD_OPTION_TIME_SHIFT.
Thanks Roman.

Ok, I opened a new issue. I will close this one. I assume the trace-cmd I had from AUR was the culprit. But the trace-cmd situation with AUR is not nice in general. I don't know if that's something you're involved in or if you know somebody to notice about the problem but since GPUVis depends on trace-cmd and many devs probably use Arch based distros it would be nice if this just works (the problem might be Manjaro-only though).


Roll Packages from e4f2247c3f41 to 66e98d826961 (5 revisions)

https://github.com/flutter/packages/compare/e4f2247c3f41...66e98d826961
2024-08-13<EMAIL_ADDRESS>Fix breakages introduced by SplashFactory (flutter/packages#6952)
2024-08-13<EMAIL_ADDRESS>Manual roll Flutter from 2afc452d3a8e to cc13cd1f1191 (6 revisions) (flutter/packages#7404)
2024-08-13<EMAIL_ADDRESS>[google_maps_flutter_android] Convert Circle and Marker to Pigeon (flutter/packages#7326)
2024-08-13<EMAIL_ADDRESS>[in_app_pur]: Bump androidx.annotation:annotation from 1.8.1 to 1.8.2 in /packages/in_app_purchase/in_app_purchase_android/android (flutter/packages#7379)
2024-08-13<EMAIL_ADDRESS>[file_selector]: Bump androidx.annotation:annotation from 1.8.1 to 1.8.2 in /packages/file_selector/file_selector_android/android (flutter/packages#7381)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


Error in the naming of the h5 model

Hi, I notice that there has been an error in labeling the models. It think should be label as '0.25' instead of 0.35?

I am not sure if it is 0.35 or 0.25


iOS: Not showing Done and Cancel Button on first render, scroll the spin crash the app

React Native version :0.63.3

when first enter the page and trigger the month-year-picker, Not showing Done and Cancel Button. at this time scroll the spin would some times make the app crash.
navigate to other page and navigate back, re-trigger the month-year-picker, it works fine.

as it would crash the app, I guess is there some code issue in this situation?
attached the screen and video. thanks
https://user-images.githubusercontent.com/3691806/128285145-d03f9387-22a6-4db9-9953-541155dea3a0.MP4

this is my code:
render() {
    const { value, minimumDate, maximumDate, locale } = this.state;
    return (
      <MonthPicker
        onChange={this.onValueChange}
        value={value}
        minimumDate={minimumDate}
        maximumDate={maximumDate}
        mode="full"
        autoTheme={false}
        locale={locale}
      />
    );
  }

I found the root cause: when the locale=null, it would reproduce above issue
use below code would fix the problem.
<MonthPicker
        onChange={this.onValueChange}
        value={value}
        minimumDate={minimumDate}
        maximumDate={maximumDate}
        mode="full"
        autoTheme={false}
        locale={locale || 'en'}
      />

closing the issue


Add Cloud Tasks Sample

I just wanted to say we chanced it and added the Cloud Tasks module to our Quarkus project with this library and it seems to work well - we tested task creation with both OIDC and OAuth authorization schemes. I can create a small PR that adds an example and a test perhaps?

That's great. Yeah sure, we would be very happy to accept a contribution!

Fixed by: https://github.com/GoogleCloudPlatform/google-cloud-graalvm-support/pull/78


perf(ast)!: reduce byte size of TSImportType::attributes by Boxing it

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#5678  👈
#5677
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Boshen and the rest of your teammates on  Graphite


LSC Smart Doorbell

Video doorbel not appearing in Home Assistant.
Device normal info

LSC
LSC-Bell 8S(V300)

The standard instruction set wich i've taken out of the debug option on iot :
basic_indicator	Boolean
"{true,false}"
basic_flip	Boolean
"{true,false}"
basic_osd	Boolean
"{true,false}"
motion_sensitivity	Enum
{
"range": [
"0",
"1",
"2"
]
}
basic_nightvision	Enum
{
"range": [
"0",
"1",
"2"
]
}
sd_format	Boolean
"{true,false}"
motion_switch	Boolean
"{true,false}"
record_switch	Boolean
"{true,false}"
record_mode	Enum
{
"range": [
"1",
"2"
]
}
basic_device_volume	Integer
{
"min": 1,
"max": 10,
"scale": 0,
"step": 1
}
The standard status set taken from te same place:

sd_format
Boolean
"{true,false}"

motion_switch
Boolean
"{true,false}"

record_switch
Boolean
"{true,false}"

record_mode
Enum
{   "range": [     "1",     "2"   ] }

basic_device_volume
Integer
{   "min": 1,   "max": 10,   "scale": 0,   "step": 1 }

Can you provide your device's category?

What do you mean exactly?
Its a video doorbel, i think it falls under 'video surveillance'
Outlook voor Androidhttps://aka.ms/AAb9ysg downloaden

From: tsutsuku @.>
Sent: Monday, August 2, 2021 4:34:11 AM
To: tuya/tuya-home-assistant @.>
Cc: monkey2b @.>; Author @.>
Subject: Re: [tuya/tuya-home-assistant] LSC Smart Doorbell (#275)
Can you provide your device's category?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/tuya/tuya-home-assistant/issues/275#issuecomment-890666572, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AVAVWLJ5AQM3T3HSYL7PDDTT2X72HANCNFSM5BKFGZ6Q.

I'm also looking for this integration @tsutsuku , i think a great start would be surveillance and then build up to doorbell features.
Also i'm willing to help with the coding if required.

Looking for a tuya video doorbell driver..


Don't build parse_time till TF r2.1

As discussed, we won't build parse_time till #663 is completely resolved in r2.1

cc: @seanpmorgan @WindQAQ


Add a license

Hey - this looks like a great project, are you able to add a license so we can begin to use it?

Thanks for the issue @AndyRae, added the license in #135  👍


All time best

Show/hide option similar to other stats

What do you mean with all time best though? Doesn't it differ a lot per stat or even.. per perspective?
Is the best boost usage the lowest amount or the highest? Is it best to be in the air more or less? Is hitting the ball a lot of times best or is it best to hit the ball the least amount of times? As you see, it is very situational.
Then I guess it becomes the question whether you want to actually see both (lowest and highest). And then the question is, is it all worth the time developing this in the first place?
I'll think about it, but first I need some more in-depth information about this feature request.
By the way, I noticed you are thinking of a lot of new features (which I love btw!), is this some kind of plugin you've been waiting for? You see, I want to keep the plugin as simple as it is intended to be.  Perhaps it would be better to have such conversations on a more appropriate social platform? Let me know 👍

Sure. We can discuss in Discord AstralM#4416
Lähetetty sovelluksesta Outlook for iOShttps://aka.ms/o0ukef

Lähettäjä: Meine Zeinstra @.>
Lähetetty: Sunday, January 29, 2023 2:52:43 AM
Vastaanottaja: MeineZ/BMDemoTouchRatio @.>
Kopio: maggaou @.>; Author @.>
Aihe: Re: [MeineZ/BMDemoTouchRatio] All time best (Issue #14)
What do you mean with all time best though? Doesn't it differ a lot per stat or even.. per perspective?
Is the best boost usage the lowest amount or the highest? Is it best to be in the air more or less? Is hitting the ball a lot of times best or is it best to hit the ball the least amount of times? As you see, it is very situational.
Then I guess it becomes the question whether you want to actually see both (lowest and highest). And then the question is, is it all worth the time developing this in the first place?
I'll think about it, but first I need some more in-depth information about this feature request.
By the way, I noticed you are thinking of a lot of new features (which I love btw!), is this some kind of plugin you've been waiting for? You see, I want to keep the plugin as simple as it is intended to be.  Perhaps it would be better to have such conversations on a more appropriate social platform? Let me know 👍
—
Reply to this email directly, view it on GitHubhttps://github.com/MeineZ/BMDemoTouchRatio/issues/14#issuecomment-1407525219, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AHZRI64BZ6GT3TXMUBO2XQLWUW5NXANCNFSM6AAAAAAUJ46ZXU.
You are receiving this because you authored the thread.Message ID: @.***>

Allright, will contact you soon! You can remove your discord tag if you want to keep it private. I haved noted down the tag somewhere.

Probably not gonna look at this for a while. Got other features on my mind at the moment :)


Error on start

I already downloaded the latest version, chose the language, agree to storage permission but I still got this message

What phone and android version?

@neobenedict Oppo A53 Android 10

It's fixed and now I can enjoy the story, thank you


Readme should mention delimiter

I assumed a csv tool would default to ',' as the delimiter, but this defaults to ';'. This is mentioned in the terminal help, but not the readme, and the failure mode is an IndexError, which is confusing:
Traceback (most recent call last):
  File "./csv_anonymizer.py", line 152, in <module>
    anonymize(source, target, column_index, int(ARGS.headerLines), ARGS.encoding, delimiter)
  File "./csv_anonymizer.py", line 96, in anonymize
    for row in anonymize_rows(reader, columnIndex):
  File "./csv_anonymizer.py", line 74, in anonymize_rows
    if len(row[columnIndex].strip()) > 0:
IndexError: list index out of range

(Because csv_anonymizer assumes ';', and your csv uses ',', csv_anonymizer is likely to treat a row as a single large field, and thus fail if given a columnIndex > 0.)
In addition to mentioning --delimiter in the readme, perhaps a try/except around that error, with a user-friendly warning if len(row) == 1?

(Once I figured out that I needed to specify --delimiter=,, though, this tool saved me a ton of time, so thank you!)

Just thought about your idea about adding a user friendly message, if the delimiter is wrong and the index given is therefore out of bounds:

Sometimes I only have one column, so this is fine and should not result in an error. Any messages written in this case would be included in my csv file when writing to stdout!
A check of the column index to be less than len(row) (line 74) might solve the problem of variable row length (some rows do have x columns, some not), but might be a problem in the case you describe: wrong delimiter, script only sees 1 column, but you want to replace column 2.

What do you think?

Sometimes I only have one column, so this is fine and should not result in an error. Any messages written in this case would be included in my csv file when writing to stdout!

A check of the column index to be less than len(row) (line 74) might solve the problem of variable row length (some rows do have x columns, some not), but might be a problem in the case you describe: wrong delimiter, script only sees 1 column, but you want to replace column 2.

 print("spam", file=sys.stderr) would avoid that (writing to the file)! But yes, I agree that you don't want to error just on len(row) == 1.  Making this part of the IndexError handling limits it to the case where you've specified a column that is out of bounds.
That said - right now, the behavior if you specify an index that the row doesn't have is a crash (due to unhandled error).  So maybe the right thing is just to do something like
try:
  [code that raises error, this is line 74 in csv_anonymizer.py]
except IndexError:
  msg = "You wanted to anonymize field {}, but row {} has only {} fields. Possibly your data is missing fields, or '{}' is the wrong delimiter?"
  raise Exception(msg.format(columnIndex, rowIndex, len(row), delimiter))

(My python is a bit rusty, I'm not 100% sure of the syntax, but this should be close.)
Note that this would require passing delimiter as a param to anonymize_rows, and you'd want to replace for row in rows: with something like for rowIndex, row in enumerate(rows): (See: https://treyhunner.com/2016/04/how-to-loop-with-indexes-in-python/#What_if_we_need_indexes?)


Enable local feature generation/inference in single script

This PR adds a script that runs feature generation/inference locally based on an input file of ra/dec and/or ZTF light curve IDs.

No worries, thanks!


App crashes on P324

cluster view is a good idea!
I stumbled on an error when I clicked P324:

Probably sources property is missing and if we add empty array it might solve the problem.
"sources": [ ]
@someshkar

Still trying to figure out what this error is, because it's not reproducible. Sources of P324 seem to be present.

Not reproducible


Grub-efi hangs when enter button not hit in grub menu on secure boot

As in the subject when secure boot is turned on and grub menu is showed, there is some time left for choosing the entry to boot and if enter button was not hit the highlighted entry is run automatically but actually it hangs and nothing helps to reboot.
This happens to be scarthgap related, not on kirkstone.

This is odd. I have left my machine for a couple of hours in that state that I have moved an arrow to disable the timer in grub menu and when came back it was hanged as well... Definitely, there must be some kind of a deadlock or something.

Hello, can provide more information?  Which board did you use ?   Which DISTRO_FEATURES are enabled besides efi-secure-boot ? How did you deploy the image ? using wic or rootfs.tar.gz ?

Hello, can provide more information?

Hi @yizhao1 I can.

Which board did you use ?

The board is ours for x86-64 intel architecture with Insyde uefi.

Which DISTRO_FEATURES were enabled besides efi-secure-boot ?

Only the efi-secure-boot from this meta layer is set. Others are like largefile polkit acl xattr pam systemd tpm2 virtualization ipv6 usrmerge.

How did you deploy the image ? using wic or rootfs.tar.gz ?

Actually I'm using both (installer is made from wic and contains inside rootfs.tar.gz which is being extracted to target machine) and it happens on both.
When I disable secure boot in uefi than everything is fine and this does not happen.

I can not reproduce it with wic image on my intel NUC7.  The default grub menu only has one entry. Did you have more than one entry in your grub menu ?

I can not reproduce it with wic image on my intel NUC7. The default grub menu only has one entry. Did you have more than one entry in your grub menu ?

Both one and more entries and still it happens.

Currently I'm reverting only the packages of shim and seloader to see if maybe they are causing the issue.
Additionally I have some suspicions that our UEFI implementation can cause it...

Currently I'm reverting only the packages of shim and seloader to see if maybe they are causing the issue.

Downgrading shim on scarthgap is a nightmare... And downgraded seloader is not working with new shim.

Additionally I have some suspicions that our UEFI implementation can cause it...

Regarding this I can test the image on qemu and see if the error also persist.

OK we have tested the image on QEMU and it is working as suppoused to so the issue is related rather to our UEFI implementation, so I'm closing the issue as solved.

OK after more digging it occurs that the issue is not related to the UEFI but to the USB connection. We have tested the image on one more different platform which has UEFI from AMI and the issue occurs as well and what we discovered that when plugging some usb device like keyboard or mouse that grub hangs.
@yizhao1 can you please verify it on your intel's NUC 7 does it occur as well?

@Dvergatal I tested wic image with usb keyboard and usb mouse on my intel NUC7. It works well. I have no other platforms for testing. Can you test the original secure-core-image scarthgap image on your platform ?

Yes i can test it. I think I will get for myself this intel NUC7 to test as well...

OK a new nuc7 has came and I've tested the same image and to my surprise it has behaved like on our devices in our lab, meaning it did not hang in the grub but hanged when I have disconnected keyboard from USB and plugged it again... So on device which I have at home, it hangs always and on the other devices, even on intel NUC7 it hangs only when usb device is plugged to it when on grub stage not before power on.
@yizhao1 have you made your test in such steps?

OK more digging and it occured that the instant freeze is caused by USB LTE modem connected through m.2 pci slot. When I unplugged this modem my machine stopped to freeze after ~5-8 seconds.
Now it works but still when I will unplug USB keyboard and plug it again than grub hangs...

@yizhao1 more interesting informations. I have finally managed to test it with older version of shim 15.2 from mickledor revision and grub together with seloader are the newest one and everything is working as it is supposed.
The difference which is mostly interesting is that shim contains own repo for gnuefi which is completely different than the one used by seloader and grub...
Need to dig it more...

OK finally i got it working on scarthgap but with shim and gnu-efi from kirkstone... Now i need to somehow do the same with lates shim but with the usage of gnu-efi from opemembedded-core instead of the one provided with shim.

@yizhao1 additional question are you using in your case UEFI_SELOADER  or not?

@yizhao1 OK I have built the image and the issue exists on the reference image as well and it behaves exactly the same as I've described it.

@Dvergatal  I can reproduce this issue now. It only happens with UEFI_SELOADER but not with GRUB_SIGN_VERIFY.

@yizhao1 finally :smiley:  glad to read it :+1: Now we need to solve it. Do you have any ideas?


[FR] Pagination

What would you like to be added?
Good Evening @marcusolsson
I hope you are well
I think it would be useful to include pagination in the plugin.
Why is this needed?
Because of this way, all the data doesn't have to be displayed, and we could choose how many items we want to be displayed in the view.

What's the reason behind paginating? Is it mostly for performance reasons? Also, is this only for the table view?

Good Evening @marcusolsson
I hope you are well
Regarding these excerpts:

What's the reason behind paginating?
Is it mostly for performance reasons?

In my opinion, it is not only about performance, but also about a better visualization of the notes.
Because there are folders that may have many notes and thus have to scroll through all this data can be a tedious task and difficult to view the data, which, I believe, would be attenuated if it was included the pagination that would stipulate a fixed order of notes which would give us a better view, and we could move to the next sequence by clicking a button, for example, instead of using the scroll.
Regarding this excerpt:

Also, is this only for the table view?

No, it would be for the Table View and Calendar View because a day can contain several notes, so instead of using scroll it would be interesting to use pagination.
If you need anything else, just let me know.
Have a wonderful day.

Related to #206.

Tested table view load time, with 100+ notes. Applying sort on Table view will significantly shorten the rendering time of Table components.


State of this repository: trying to update to OpenAPI spec v3

We have made good progress and are now using OpenAPI spec v3 for the GraphHopper Directions API!
We then created our docs from it via https://github.com/Rebilly/ReDoc (actually a fork as we had a few problems and PRs seems to be ignored)
Unfortunately it seems that our latest spec
https://docs.graphhopper.com/openapi.yaml (sources in doc repo)
fails for openapi-generator:
https://github.com/graphhopper/directions-api-doc/issues/14
Using swagger codegen it worked after some problems: #38

Ok, we'll go with our API spec as a single point of truth and let users create their API clients via the swagger editor. More details are described here: https://github.com/graphhopper/directions-api-clients#deprecated-notice


How to a create FlashRegistry of Available Heads for flash.image.ImageClassifier?

Hey folks! This is my first time opening an issue here. Great project!
❓ Questions and Help
After reading the documentation as well as source code, I find that flash.image.ImageClassifier has no flash registry for available heads. There's one for all other flash.image tasks but not the classification task.
Right now, the only way I see to add a heads registry is to create a new class, inherit from flash.image.ImageClassifier, copy and update the __init__() method to fetch heads from a registry.
Is there an easy way to do this? Although it's possible to create a nn.module for the head and pass it to flash.image.ImageClassifier, I would like to keep a registry and simply pass the head id and additional kwargs, just like one would do for loading the model backbone.

Hey @AjinkyaIndulkar Thanks for the question! A registry for classification heads is a great suggestion! I'll recategorize this issue as a feature request to add it. Would you be interested in working on this?

Awesome!!! Let us know if you need help with anything and feel free to open a PR even if you just have something you'd like to get some feedback one :smiley:

alright! I'll go through the contributing guidelines first and reach out if something is unclear.


Add Microsoft bug bounty program

Hello,
As per title, adding an important asset that was missing.

Screenshot showing that my PR submits a valid JSON:

Hi @ngkogkos,
This looks great add, a minor update, our API accepts only domain name as input, so can you update the domain list to only add root domain instead of subdomains.
For example,
live.com

instead of
outlook.live.com

Hi @bauthard thanks for the super quick review.
I've updated my PR as requested and removed an Azure parent domain that would probably lead to thousands of client subdomains with no benefit for the community.
Good job on this project, as a side suggestion, I think it will be good if the API can accept subdomains as well. A lot of programs/vendors enforce restrictions. From a performance perspective, you can avoid having to scan huge spaces if they are out of scope or host client assets.

thanks @ngkogkos, that shouldn't be an issue as we are collecting passing data only.


⚠ Turnos 24x7 has degraded performance

In 9588d3d, Turnos 24x7 (https://reservas-dev.alternativasinteligentes.com/) experienced degraded performance:

HTTP code: 200
Response time: 995 ms

Resolved: Turnos 24x7 performance has improved in 169b69f.


Pipeline for checking configuration health/status

Web-based Unicorn control panel shows configuration related warnings/messages in cases like not serialized, missing root items or enabled transparent sync. This pipeline will allow VS Control panel show the same messages.

Hey Andrii, thanks for the contribution. See https://github.com/kamsar/Unicorn/commit/916221b1def899d0349426925f256fdad0076ceb for a couple changes I made. The only one that might break what you're doing is that I renamed the processor class to match the others' naming convention, so the config registration is different.


service tests need to be migrated to dart2 configuration

When I try running service tests with --strong a lot of them are failing. I have updated the status files.

/cc @a-siva @zanderso

@rmacnak-google landed a number of changes to make the tests strong mode clean, we have only one issue pending which is being tracked in https://github.com/dart-lang/sdk/issues/31696
Closing this issue.


Suggestion: Community development discord channel

It would be good to be able to talk to each other around the development of this project

I'm not very hip to the discord life, I wouldn't mind it, but not sure how active I would be in the community. I do actually want to ask those using this a few questions about the roadmap so maybe I'll set something up.

@Jore I have applied for the Github Beta Discussions, hoping I get approved shortly and we can move some real discussions there.

Fantastic. Thanks so much.


Dragonwell JDK8 Windows builds failing

Thank you for reporting a broken build! Please fill in the following details:

Jenkins link to the failing log: https://ci.adoptopenjdk.net/job/build-scripts/job/jobs/job/jdk8u/job/jdk8u-windows-x64-dragonwell/85/console
Which platforms (OS+arch) are affected: WIndows/x64 (Dragonwell only)
If you look at the historic logs, does the problem appear to be specific to one machine? Np
Link to any upstream project bug report (e.g. OpenJ9/JBS)

Start of error section as follows:
17:02:47  Compiling 9582 files for BUILD_JDK
17:03:14  e:\jenkins\tmp\workspace\build\src\jdk\src\share\classes\com\alibaba\wisp\engine\WispControlGroup.java:32: error: cannot find symbol
17:03:14              Math.min(MAX_PERIOD, WispConfiguration.SYSMON_TICK_US * SCHEDULE_TIMES));
17:03:14                                   ^
17:03:14    symbol:   variable WispConfiguration
17:03:14    location: class WispControlGroup
17:03:14  e:\jenkins\tmp\workspace\build\src\jdk\src\share\classes\com\alibaba\wisp\engine\WispControlGroup.java:46: error: cannot find symbol
17:03:14          int cfsPeriodUs = WispConfiguration.WISP_CONTROL_GROUP_CFS_PERIOD;
17:03:14                            ^
17:03:14    symbol:   variable WispConfiguration
17:03:14    location: class WispControlGroup
17:03:14  e:\jenkins\tmp\workspace\build\src\jdk\src\share\classes\com\alibaba\wisp\engine\WispControlGroup.java:89: error: cannot find symbol
17:03:14          assert task.controlGroup == this;
17:03:14                     ^
17:03:14    symbol:   variable controlGroup
17:03:14    location: variable task of type WispTask

@joeyleeeeeee97 Are you aware of this one?

Maybe we could close this now.


I need help in extracting the face image from the bounding box

I have been creating a code for face detection using mediapipe and I am trying to extract the face image to be saved to a local directory. I guess that extrating part is needed to be added to the code below. Can someone help. I was able to print out the bounding box but still unsucessfully figure out how to extract the face image. Please refer to my codes below :
import cv2
import mediapipe as mp
import uuid   # Unique identifier
import os
mp_face_detection = mp.solutions.face_detection
mp_drawing = mp.solutions.drawing_utils
For webcam input:
cap = cv2.VideoCapture(0)
with mp_face_detection.FaceDetection(
model_selection=0, min_detection_confidence=0.5) as face_detection:
while cap.isOpened():
success, image = cap.read()
if not success:
print("Ignoring empty camera frame.")
# If loading a video, use 'break' instead of 'continue'.
continue
# To improve performance, optionally mark the image as not writeable to
# pass by reference.
image.flags.writeable = False
image = cv2.cvtColor(image, cv2.COLOR_BGR2RGB)
results = face_detection.process(image)

# Draw the face detection annotations on the image.
image.flags.writeable = True
image = cv2.cvtColor(image, cv2.COLOR_RGB2BGR)
if results.detections:
    for detection in results.detections:
        mp_drawing.draw_detection(image, detection)
# Flip the image horizontally for a selfie-view display.
location_data = detection.location_data
if location_data.format == location_data.RELATIVE_BOUNDING_BOX:
    bb = location_data.relative_bounding_box
    bb_box = [bb.xmin, bb.ymin, bb.width, bb.height]
    print(f"RBBox: {bb_box}")
cv2.imshow('MediaPipe Face Detection', cv2.flip(image, 1))
if cv2.waitKey(5) & 0xFF == 27:
    break

cap.release()
cv2.destroyAllWindows()

Hi @khairulsynapse ,
Could you please share me error logs or any reference images/videos w.r.t above issue.

Hi @sureshdagooglecom. No error. It is just that I need some help with the coding in to extract the face image.

Hi. I guess this is not issue related. I will close it at this moment. Sorry for the inconvenience caused.


Backward compatibility

Thanks for a great package!
Been using dabestr for quite some time now and the version change from 0.3.0 to 2023.09.12 crashed our code.
Apparently, "dabestr" was changed to "dabestr_plot", but when I replace one with the other, I get the error message that what I'm trying to plot is not a dabestr object. Is there a changelog somewhere that details what I need to do to make my old code run with the new version?
Many thanks in advance!

Hi @brembs sorry for the late reply!
dabestr v2023.9.12 more or less stuck to the old api (with the sequentially calling of load(), followed by the appropriate effect_size() functions, followed by the dabest_plot() function) but the functions themselves have changed quite drastically.
You may find the changelog here useful. Alternatively, you may also look through the tutorials here for how the new functions are being called.
Hope this helps! Feel free to let me know if you still run into any issues.
Lastly, there are currently some persistent bugs with v2023.9.12. The fixes for the bugs are currently only available in the dev version. You may obtain the dev version via the following:
devtools::install_github(repo = "ACCLAB/dabestr", ref = "dev")

Many thanks for the links! I'll go over them and try and fix our code. This may take some time. I'll get back in case there is something I'm missing. Thanks again for dabestr and for keeping up with the user queries!

Tutorial and changelog helped a lot, many thanks!
Do I understand this correctly that now dabestr works only when the N is identical in both groups?

Yes! For v2023.9.12 of dabestr, that is correct. However, this has been fixed in the dev branch version and you can now do it for unequal Ns across all groups. You can access the dev version by running:
devtools::install_github(repo = "ACCLAB/dabestr", ref = "dev")

You may keep an eye on both the repository and the documentation for upcoming updates. We'll be releasing a new version that incorporates all the fixes in the near future.

Excellent! I'll just wait until the new version comes out! It was very easy to upgrade, thanks again for the support and your great package!

No worries at all! If you ever have more questions or run into any issues, feel free to reach out.
Additionally, thanks for using our dabestr package. Your kind words and support means a lot to us :) Happy coding!


docs: add codepen button

Pull Request
📖 Description

Currently missing:

[x] I'm currently not able to preserve the edited code, as this button is removed by the second code area. It actually WOULD work, but I can't find a way to distinguish if it's the first or the second code view. Maybe someone has an idea?
[x] We should use the actual version number in the esm.sh-links. I'm not sure if we already have it available from Vite side, but that should be easily doable.
[x] assets, theme, utilities and components are included with correct versions
[ ] Little clean up is definitely possible, maybe even having a separate file for that.

🎫 Issues

👩💻 Reviewer Notes

📑 Test Plan

✅ DoD

[ ] I have tested my changes manually.
[ ] I have added automatic tests for my changes (unit- and visual regression tests).
[ ] I have updated the project documentation to reflect my changes (e.g. CHANGELOG, Storybook, ...).
[ ] I have added documentation to the DaVinci migration guide (if need be)
[ ] I have made sure to follow the projects coding and contribution guides.
[ ] I have made sure that the bundle size has changed appropriately.
[ ] I have validated that there are no accessibility errors.
[ ] I have used design tokens instead of fix css values

Everything works now. Maybe some cleanup is needed. I would give this PR now to @kirchsuSICKAG and @schilchSICKAG if that's fine? One addition feature wise: Could be nice, to add the correct font, so that everything looks a bit nicer? :)

Could be nice, to add the correct font, so

Will surely have a look into this later this day, thank you :)

Could be nice, to add the correct font, so that everything looks a bit nicer? :)

I finished all so far, what I had as review comments and also added the font.
From my side it, everything looks good


alternative CBOR encoding

This is an alternative to #35 that doesn't use the jackson CBOR module.  Instead it uses cbor-java and provides a jValueToCbor method to convert from JValue.
Doesn't handle the other direction (cbor to json), since that's a lossy conversion.

oooooooooo i like this! do we trust the lib? if so, go ahead and merge

it has conflicts with the changes in types for the blockchain.

closing to reopen against master


Docker package incorrect for 16.04

By default, the package docker-engine is unable to be found on 16.04 hosts. This should be set to docker.io for said hosts.
I'll try do this one myself :)

THis wa

This was my bad, was accidently running 32bit Ubuntu. Maybe it's worth blowing up if the arch is wrong ?

I'd take a PR for an architecture check.


Fix GCP benchmark workflow error handling [skip ci]

fix #406
To fix the bug

change cluster name to dynamic one by adding Github run number as suffix
make COMPUTE_REGION as a workflow param for user to retry when no sufficient resource in default region
add post-clean up step, always try delete the cluster

Test builds:
Normal successful run: https://github.com/YanxuanLiu/spark-rapids-ml/actions/runs/6085185863/job/16508682985
Create a cluster manually, and trigger the workflow. It failed as expected, and deleted the cluster successfully at the end of workflow.
https://github.com/YanxuanLiu/spark-rapids-ml/actions/runs/6085897714/job/16511031142

Looks like the benchmark is also running from my fork.  Do we need to add code to restrict to main repo somehow?

Looks like the benchmark is also running from my fork. Do we need to add code to restrict to main repo somehow?

Yes, if we want to save resource of GSC

Looks like the benchmark is also running from my fork. Do we need to add code to restrict to main repo somehow?

we should add expression to allow run on prod repo only as defaults
if: github.repository == 'NVIDIA/spark-rapids-ml'

people could update the value if they want enable in their forks

Looks like the benchmark is also running from my fork. Do we need to add code to restrict to main repo somehow?

we should add expression to allow run on prod repo only as defaults
if: github.repository == 'NVIDIA/spark-rapids-ml'

people could update the value if they want enable in their forks

Added and tested https://github.com/YanxuanLiu/spark-rapids-ml/actions/runs/6093671912/job/16533730597

build


Investigate need for BaseModel class

How much does it share with BaseIngress?

#181 summarizes a lot of the required features from the front ends perspective. This issue will contain more specific discussion about how we enable this through the backend. Also related to #81.
My initial thoughts are to split up the major tasks into model initialisation and model run. This could be implemented in a similar way to the BaseIngress class. Potentially, we have a BaseService class that BaseIngress and BaseModel inherits from. It may not even be necessary to have seperate Ingress and Model classes, but I suspect it might be due to different API endpoints with the backend.
The BaseService Class would handle:

passing parameters to the service
running the service
scheduling the service

User would then inherit from BaseService to write the custom methods.
class BaseService():

def __init__(self):

def init_instance(**params):
"""
This method handles the ingestion of the parameters and saves the instance of the model/ingress in the database.
Therefore, in the database, there can be multiple instances of models/ingress but with different parameters.
"""

def run():
"""
This method runs the instance of a model/ingress immediately
"""

def schedule():
"""
This method schedules running the run method. This may have to be the method that requires some Azure interaction.
I really don't know what this looks like to be honest.
"""

This would link up with the frontend, something like:
Choose Model from drop down list : Weather_Ingress
service = WeatherIngress()

Enter parameters : {'start': 'present', 'end': '2 hours'}
service.init_instance( {'start': 'present', 'end': '2 hours'})

Run Now
service.run()

Schedule : EveryDay
service.schedule(EveryDay)

To Do for first PR on this topic:
Compulsory things to do

[ ] Implement BaseService Class and get BaseIngress to Inherit
[ ] Create BaseModel class that inherits from BaseService
[ ] Move Arima over to BaseModel
[ ] Check WeatherIngress still works when inheriting from BaseService Class

Extras

[ ] Ensure user can override parameters, preferably from GUI
[ ] Add a run now functionality via frontend
[ ] Design Scheduler system. This will likely be a PR in its own right as this needs integration with AzureFunctions.

I'm trying to understand how this sits around the backend/frontend and backend/functions divides. Presumably the backend would have endpoints for things like insert-service, insert-service-parameters, schedule-service, and run-service? And the backend would also have the scheduler running. Do I understand correctly that the BaseService class would sit on the frontend or functions side of the divide, and just call these end points? The same way BaseIngress is a bit of code that will run e.g. in an Azure function.

These are the questions I've been asking myself.

Yes backend would have those endpoints
Basically, yes this would work exactly like BaseIngress. Really its a template for a developer to pick up and follow.
I don't really understand our options for scheduling/Azure Functions to be honest, probabaly something we should chat about.

I haven't thought about it in detail, but for the scheduling I'm imagining something where the backend server, the same one that runs the backend API, every time it starts it reads from the database information about what are all the scheduled services, and then sets up cron jobs for all of them. Where by cron jobs I don't mean literal cron jobs, but some sort of background process that does a thing at given regular times.
So I would imagine the flow being something like

The frontend, due to user pressing a button, sends a request to the schedule-service endpoint, with a payload of something like

{
  "service_name": "Weather ingress",
  "parameter_set": {
    "longitude": 0.01
    "latitude": 53.2
   },
  "schedule": "Once a day at 1pm",
}

The schedule would be given in some less silly format of course.
2. The backend writes those parameters into a new row in a table called service_parameters, and writes a row in a table called service_schedules. The latter table would have three columns, one referencing which service this is a schedule for, one referencing a row in service_parameters, and one for the value of the schedule.
4. The backend, once done with the database writes, calls a function called something like update_scheduled_jobs, which goes and discovers in the table service_schedule that there is new scheduled service to run, and sets up a new cron job/timer to make sure that the right service is called with the right parameters at the right time.
The table for services would probably only have two columns, one for the name of the service ("Weather ingress"), and one for the URL of the endpoint to send a request to when calling that service (for weather ingress, the URL for the relevant Azure function, which triggers it to run). Maybe in the future a third column for a JSON schema for the parameters.

closed by #190


Migrate 'pr-autoflow' workflows away from using 'set-output'

This feature has recently been marked for deprecation:
https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
We use it in the auto_release workflow.

Implemented by #60 & #59


[Bug] Oneflow, onediff with pytorch 2.4.1 ImportError: libcudnn_cnn_infer.so.8

Your current environment information
Traceback (most recent call last):
File "/home/shadeform/miniconda3/envs/miner/lib/python3.10/site-packages/onediff/utils/import_utils.py", line 16, in check_module_availability
importlib.import_module(module_name)
File "/home/shadeform/miniconda3/envs/miner/lib/python3.10/importlib/init.py", line 126, in import_module
return _bootstrap._gcd_import(name[level:], package, level)
File "", line 1050, in _gcd_import
File "", line 1027, in _find_and_load
File "", line 1006, in _find_and_load_unlocked
File "", line 688, in _load_unlocked
File "", line 883, in exec_module
File "", line 241, in _call_with_frames_removed
File "/home/shadeform/miniconda3/envs/miner/lib/python3.10/site-packages/oneflow/init.py", line 26, in
import oneflow._oneflow_internal
ImportError: libcudnn_cnn_infer.so.8: cannot open shared object file: No such file or directory
🐛 Describe the bug
onediff==1.2.1.dev24+g9231f556
pytorch==2.4.1
python3 -m pip install -U --pre oneflow -f https://github.com/siliconflow/oneflow_releases/releases/expanded_assets/community_cu118
python3 -m pip install -U --pre oneflow -f https://github.com/siliconflow/oneflow_releases/releases/expanded_assets/community_cu121
python3 -m pip install -U --pre oneflow -f https://github.com/siliconflow/oneflow_releases/releases/expanded_assets/community_cu122
tried above three oneflow installation.
seems like oneflow not supporting pytorch==2.4.1, if i install pytorch==2.3.1 then it works

What is the cudnn version are you using?
You can get it with:
import torch

if torch.backends.cudnn.is_available():
    cudnn_version = torch.backends.cudnn.version()
    print(f"cuDNN version: {cudnn_version}")
else:
    print("cuDNN is not available.")

This worked for me: sudo apt install libcudnn8

python3 -m pip install nvidia-cudnn-cu11==<IP_ADDRESS>

Can fix this.

python3 -m pip install nvidia-cudnn-cu11==<IP_ADDRESS>

can fix this.

after running this python3 -m pip install nvidia-cudnn-cu11==<IP_ADDRESS>
i got below error
ImportError: libcudnn.so.9: cannot open shared object file: No such file or directory

libcudnn.so.9

which package is reporting this error

libcudnn.so.9

which package is reporting this error

ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
torch 2.4.1 requires nvidia-cudnn-cu12==<IP_ADDRESS>; platform_system == "Linux" and platform_machine == "x86_64", but you have nvidia-cudnn-cu12 <IP_ADDRESS> which is incompatible.

This worked for me: sudo apt install libcudnn8

sudo apt install libcudnn8
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
E: Unable to locate package libcudnn8
+-----------------------------------------------------------------------------------------+
| NVIDIA-SMI 550.90.12              Driver Version: 550.90.12      CUDA Version: 12.4     |
|-----------------------------------------+------------------------+----------------------+
| GPU  Name                 Persistence-M | Bus-Id          Disp.A | Volatile Uncorr. ECC |
| Fan  Temp   Perf          Pwr:Usage/Cap |           Memory-Usage | GPU-Util  Compute M. |
|                                         |                        |               MIG M. |
|=========================================+========================+======================|
|   0  NVIDIA H100 80GB HBM3          On  |   00000000:07:00.0 Off |                    0 |
| N/A   24C    P0             69W /  700W |       1MiB /  81559MiB |      0%      Default |
|                                         |                        |             Disabled |
+-----------------------------------------+------------------------+----------------------+
|   1  NVIDIA H100 80GB HBM3          On  |   00000000:08:00.0 Off |                    0 |
| N/A   26C    P0             69W /  700W |       1MiB /  81559MiB |      0%      Default |
|                                         |                        |             Disabled |
+-----------------------------------------+------------------------+----------------------+
+-----------------------------------------------------------------------------------------+
| Processes:                                                                              |
|  GPU   GI   CI        PID   Type   Process name                              GPU Memory |
|        ID   ID                                                               Usage      |
|=========================================================================================|
|  No running processes found                                                             |

@liho00
try
pip install nvidia-cudnn-cu12==<IP_ADDRESS>


chore: add package pre-commit

Signed-off-by: Anthony Rabbito<EMAIL_ADDRESS>

:tada: This PR is included in version 2.10.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


add --verbose flag to pub global activate

try to debug https://github.com/flutter/flutter/issues/82142

test-exempt: is a test

Landing this without the Mac module_custom_host_app_name_test check as this PR should not affect that test (it is flaking on master), and this PR will help us diagnose a separate flake.


index.js → index.ts

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-85.2%) to 0.0%

Totals
Change from base Build<PHONE_NUMBER>:	-85.2%
Covered Lines:	0
Relevant Lines:	0
💛 - Coveralls

What happens？


Change the links to Lucene's homepage in the DOAP file to https://

This PR changes all references to the Lucene homepage from the DOAP file to use the canonic HTTPS link.
P.S.: This cannot change the namespace links as they are identifiers in XML world. Also the official Apache License URL is without https at moment.

I will commit this only to main branch, as the file is only read from there. Or I am missing something (does it need to be backported for another reason?)


Shell completions

It would be nice to have some bash/zsh completions for the commands (start, report etc.) as well as for projects. Is it something you would be interested in?

I'd love to have those! However, I currently have no extra capacity beside my dayjob. Are you interesting in contributing that feature?

Resolved by #79


Update fingerprints.yml

Please add
manufacturer: _TZ3000_oysiif07
model: TS0001
deviceProfileName: single-switch

Please add
zigbeeNodeType: SLEEPY_END_DEVICE
manufacturer: _TZ3000_ji4araar
model: TS0011
Raw Description | 01 0104 0100 01 07 0003 0004 0005 0006 E000 E001 0000 02 0019 000A
MOES 1GANG NO neutrial inner realy switch
Thanks!

Added fingerprints to driver
The previous fingerprints was outdated
Please delete pull requests
Thanks for yours contributions


Fix TOC anchor tags bug

There was a problem with anchor tags and the table of contents generated by markdown-toc for non-alphanumeric characters. I fixed this by changing the slugify option to that used by Marked.

:+1:

(merged manually, but not pushed)


PDF absolute path is not getting

void receiveShare(Share shared) {
// TODO: implement receiveShare
debugPrint("Share received - $shared");

setState(() async {
  _shared = shared.path; //.toString();
  final filePath = await FlutterAbsolutePath.getAbsolutePath(_shared);
  print('FilePath: $filePath');

  showDialog(
    context: context,
    builder: (BuildContext context) => FileUploadDialog(
      url: filePath,
      buttonText: 'Add',
    )
  );
});

}
Result
Share received - {text: null, type: application/pdf, path: content://com.mi.android.globalFileexplorer.myprovider/external_files/CamScanner/New%20Doc%202019-12-04%2012.03.36.pdf}
its return Image file
FilePath: /data/user/0/com.depixed.fileupload/cache/IMG_1581322321796.png

I got the same issue with a pdf file
 final fileToCopy = await FlutterAbsolutePath.getAbsolutePath("content://media/external/file/1233"); print('fileToCopy: $filePath');
fileToCopy: /data/user/0[my app package]/cache/IMG_1602767703689.png
Witch is an image of the first page of the pdf

I got the same issue with a pdf file
final fileToCopy = await FlutterAbsolutePath.getAbsolutePath("content://media/external/file/1233");
print('fileToCopy: $filePath');

Result
fileToCopy: /data/user/0[my app package]/cache/IMG_1602767703689.png
Witch is an image of the first page of the pdf

If you have knowledge about Kotlin Language the go-to flutter/.pub-cache/hosted/pub.dartlang.org/flutter_absolute_path-1.0.6/android/src/main/kotlin/com/kasem/flutter_absolute_path folder in this FileDirectory.kt file you have to set dynamic file extension because in this set static file extension for every file.

I had to fork the package, if someone need it:
  flutter_absolute_path_fork:
    git:
        url: https://github.com/JeanChristopheMobizel/flutter_absolute_path.git
        ref: feature/content-resolver-filename

I had to fork the package, if someone need it:
  flutter_absolute_path_fork:
    git:
        url: https://github.com/JeanChristopheMobizel/flutter_absolute_path.git
        ref: feature/content-resolver-filename


Updated dependencies

@ikbendewilliam I need your regex magic for the logging_test.dart

@ikbendewilliam found the issue 🙈 I was looking at the wrong part of the regex, @luca-vz opened my eyes :D


[BEAM-11375] Downgrade Kafka clients dependency to fix spark postcommit

PR https://github.com/apache/beam/pull/13026 has broken Spark postcommit because of Kafka dependencies mismatch.
Starting with Kafka clients 2.5.0 Scala 2.11 is no longer supported.
This PR reverts Kafka client to 2.4.1

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

Run Java PostCommit

Run Java PostCommit

Run Spark ValidatesRunner

Run Spark ValidatesRunner

Run Java KafkaIO Performance Test

Run Java KafkaIO Performance Test

Run Spark ValidatesRunner

Run Java KafkaIO Performance Test

Run Java PostCommit

Run Spark ValidatesRunner

Run Java PostCommit

Run Java PostCommit

@aromanenko-dev @ibzib It looks like Spark postcommit is working again.
Updating Scala version broke everything so it indeed looks like we have to wait until Spark supports Scala 2.12.
Strangely SpannerIOIT tests keep failing - I'm not sure if it's related to this PR:
io.grpc.StatusRuntimeException: RESOURCE_EXHAUSTED: The instance projects/apache-beam-testing/instances/beam-test has too many database splits to complete the operation.  Please add more nodes and try again.

@piotr-szuberski Thanks! I don't think SpannerIOIT fails are related


Test dirty tile detection for entire planet

Import of entire planet
Import Diff Updates for entire planet

Okay good and bad news.
Using the planet PBF  from  2016-02-29 and doing diff updates until 2016-03-09 covers 10 days of updates. Applying the diff updates with imposm3 takes around 3 hours.
Detecting the dirty tiles of the 10 days only takes  1 hour which I am very happy with - hurray.
Now the bad part: 10 days of changes already affects 42'802'075 tiles. Much more than we expected. This really might require distributed processing of the updates due to the huge amount of tiles.
But we also need to double check whether we do some serious mistakes and the tile count is therefore so high.
So 10 days ~= 43 million tiles. If we want to continuously rerender the world updates on a single machine (to keep it cheap) this means we must be finished with rendering the vector tiles in at least 10 days to be ready for the next update coming in. That could actually still be doable on a single fast server (thinking of reinstating the fat HSR server again).

Good news.
Adding the objects from #210 only adds a 3 million tiles on top for the same time span.
45263435 tiles for 10 days. This hints at the correctness of the hypothesis that a few tiles change very often. Takes ~  1hour 50 minutes for the entire world (including solving #210 #183), which is not bad but not perfect as well. We can still do a lot of optimisation to avoid querying osm_delete tables on the wrong zoom levels if we want to bring that time frame down.


Migrate from setuptools to pyproject

https://packaging.python.org/en/latest/guides/modernize-setup-py-project/

Also use "python -m build" instead of "python setup.py sdist bdist_wheel", as calling setup.py directly is deprecated.
The "build" package needs to be installed first.
https://packaging.python.org/en/latest/discussions/setup-py-deprecated/#setup-py-deprecated

https://github.com/traveltime-dev/traveltime-python-sdk/pull/125


[Question] frame-skipping check in AtariPreprocessing wrapper

Question
Correct me if I am wrong. There is a logical error in this check. The intended behavior is to raise an error if frame-skipping is enabled in the original environment because the AtariPreprocessing wrapper itself applies frame-skipping. But the current check is incorrect because it raises an error only if frame-skipping is disabled in the original environment. The condition should be negated like this:
if (
    env.spec is not None
    and "NoFrameskip" not in env.spec.id
    and getattr(env.unwrapped, "_frameskip", None) == 1
):
    raise ValueError(
        "Disable frame-skipping in the original env. Otherwise, more than one "
        "frame-skip will happen as through this wrapper"
    )

No, as we only want the issue raised if the environment has been internal frameskip of > 1, therefore, we don't want the error when getattr(env.unwrapped, "_frameskip", None) == 1
Looking at the code, I'm uncertain about the first two conditions rather than the third for the v5 environments


De-duplicate announcements in the AuthenticatedGossiper

Issues
Atm, when we receive valid announcements either from the network, or a local subsystem within the AuthenticatedGossiper we immediately add them to the next announcement batch. This can cause excessive spamming as if user triggers a command that triggers a new ChannelUpdate to be sent, then each instance of execution of said command will result in an additional message being added to the channel batch.
To address this issue, the announcementBatch slice within the main networkHandler goroutine should be properly de-duplicated. Additionally, while were at it, we should also make the trickleDelay configurable and exposed as a command line option.
Steps to Completion

[ ] Create a new isolated struct private struct called something along the lines of deDupedAnnouncements. This struct will encapsulate the logic needed to properly de-duplicate any announcements which have been added to this batch. This struct should take the place of the []lnwire.Message used to track the current announcement batch.

[ ] The deDupedAnnouncements struct should have the following methods:

Reset() which resets all storage and indexes used internally
AddMsg(lnwire.Message) which adds a new lnwire.Message to the current batch
Batch() which returns the set of de-duplicated announcements to be sent out during the next announcement epoch.

[ ] We have three main messages types which need to be de-duplicated, each with a unique attribute that can be used to de-duplicate them:

ChannelAnnouncement: uniquely identified by ShortChannelID field.
ChannelUpdate: uniquely identified by the (ShortChannelID, Flags) tuple.
NodeAnnouncement: uniquely identified by the NodeID field.

Based on each of the unique fields for a received announcement, de-duplication should be performed within the AddMsg method, with newer announcements replacing older announcements in the pending batch.

[ ] As a bonus, the  trickleDelay used within the AuthenticatedGossiper should be mode configurable. Currently it's set to 300ms in order to allows us to ensure our tests are speedy. A time.Duration representing the length of an announcement epoch should be added to routing.Config struct.
This value should be exposed in the config for lnd itself, and used to initialize the struct accordingly. NOTE: when creating nodes within the integration tests this value should be set to something on the order of 300ms such that the tests continue to operate as normal.

I'm going to take a stab at this :)

Here's a bit of background to batch announcements: https://github.com/lightningnetwork/lightning-rfc/blob/master/07-routing-gossip.md#rebroadcasting

thanks!

Closed by #322


Pong Game

A two-player game where each player controls a paddle, and they must bounce a ball back and forth without missing.
@iamrahulmahato please assign me this under GSsoc-ext, hacktoberfest, & level-1,2,3

the project is already present


namespace annotation to set default subnet

Feature request
ovn-default is the default subnet used by system pods such as those in the kube-system namespace.
When creating a new namespace and creating a new subnet restricted to that namespace, it would be good to have the possibility to add an annotation on the namespace it selft to select the new custom subnet ad default, so the user doesn't need to annotate each pod/deployment, otherwise it will keep on using the "ovn-default" subnet.
Thank you

It looks like a bug, when create a subnet and set the namespaces field to the new created ns it should automatically bind the namespace to the subnet. Can you give a reproducible steps

It's a design issue, because if i add 2 dedicated Networks i would like to set a default one and specify the other when needed

The annotation will be added to namespace by the order of the 2 subnets bind to it. You can edit the annotation ovn.kubernetes.io/logical_switch: subnet1,subnet2 and put the default one at the first place

Good, so i will give a try and get back to you

trying to remove:
kubectl annotate ns cos ovn.kubernetes.io/logical_switch-
i get:
W0613 19:14:05.081765       6 namespace.go:63] no logical switch annotation for ns cos
even setting the annotation on creation doesn't work.

You need to set the namespace into the namespaces field in two subnets spec, the controller will set the annotation automatically in the namespace and then you can reorder them by namespace annotation.


Run tests

Checklist

[x] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@PrimozGodec, no more segfaults in Windows tests! But macos is crashing. :)


Pass --no-configuration-cache to all managed TeamCity gradle build types

In preparation to eventually enable CC persistently in this repository's gradle.properties.
Reasons for disabling:

Not all use cases of the gradle/gradle build are CC ready
TeamCity injects init scripts that are incompatible with CC, see https://youtrack.jetbrains.com/issue/TW-71916
gradle/gradle build logic for CI (mostly capturing diagnostic data) is not yet ready for CC

CI checks https://builds.gradle.org/buildConfiguration/Hygiene_TestTeamCityBuildConfigurations/46243866 ✅

@bot-gradle test and merge

OK, I've already triggered a build for you.

Pre-tested commit build failed.

@bot-gradle test and merge

OK, I've already triggered a build for you.

Pre-tested commit build cancelled.

@bot-gradle test and merge

OK, I've already triggered a build for you.


📌Grab data products from DPR

Digital Prisons Reporting (DPR) have a number of defined Data Products in a github repository:
Find repository
Simple scenario scrape of data into catalogue
we don't know how many data products
spot checks rather than auto testing

Hi
@Priya Basker
You'll have to speak to HMPPS Auth about that.
If you're after the definitions, they are all in a github-repo : https://github.com/ministryofjustice/digital-prison-reporting-data-product-definitions
This is an internal repo (unsure whether there are security issues, especially around policy definitions) so if you have access to the Moj Github organisation you can simply clone this repo.
There is just 1 in there at the moment - expect another 10-20 by the end of the year.
13:49
This is the only one there : https://github.com/ministryofjustice/digital-prison-reporting-data-product-definitions/blob/main/prisons/orphanage/external-movements-1.0.0.json


SPARK-23325: Use InternalRow when reading with DataSourceV2.

What changes were proposed in this pull request?
This updates the DataSourceV2 API to use InternalRow instead of Row for the default case with no scan mix-ins.
Support for readers that produce Row is added through SupportsDeprecatedScanRow, which matches the previous API. Readers that used Row now implement this class and should be migrated to InternalRow.
Readers that previously implemented SupportsScanUnsafeRow have been migrated to use no SupportsScan mix-ins and produce InternalRow.
How was this patch tested?
This uses existing tests.

Test build #89661 has started for PR 21118 at commit eddd049.

Test build #89661 has finished for PR 21118 at commit eddd049.

This patch fails RAT tests.
This patch does not merge cleanly.
This patch adds no public classes.

Build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89661/
Test FAILed.

Build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2550/
Test PASSed.

Test build #89662 has started for PR 21118 at commit 72f3c1a.

@jose-torres, @cloud-fan, can you take a look at this? It updates the v2 API to use InternalRow by default.

Test build #89663 has started for PR 21118 at commit 2115529.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2551/
Test PASSed.

Test build #89662 has finished for PR 21118 at commit 72f3c1a.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89662/
Test FAILed.

Merged build finished. Test FAILed.

Test build #89663 has finished for PR 21118 at commit 2115529.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89663/
Test FAILed.

Generally looks good.
IIRC, there's some arcane reason why plan nodes need to produce UnsafeRow even though SparkPlan.execute() declares InternalRow. So we may need to add a projection in DataSourceV2ScanExec.

Yeah, we should probably add a projection. It's probably only working because the InternalRows that are produced are all UnsafeRow.

Test build #89665 has started for PR 21118 at commit 6006123.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2552/
Test PASSed.

@rdblue . Could you fix the remaining KafkaMicroBatchSourceSuite.scala, too?
[error] /home/jenkins/workspace/SparkPullRequestBuilder@2/external/kafka-0-10-sql/src/test/scala/
org/apache/spark/sql/kafka010/KafkaMicroBatchSourceSuite.scala:676:
value createUnsafeRowReaderFactories is not a member of org.apache.spark.sql.kafka010.KafkaMicroBatchReader
[error]         val factories = reader.createUnsafeRowReaderFactories().asScala
[error]

Test build #89863 has started for PR 21118 at commit 16f1b6e.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2682/
Test PASSed.

Merged build finished. Test PASSed.

Test build #89863 has finished for PR 21118 at commit 16f1b6e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89863/
Test PASSed.

parquet scan doesn't need unsafe row because it outputs ColumnarBatch. Note that, UnsafeRow is the data format Spark uses to exchange data between operators, but whole-stage-codegen can merge several operators into one. So in your case, a parquet scan followed with some simple operators like filter, project, is still one operator, so you won't see UnsafeRow.
I believe if you add aggregate, you will see UnsafeRow in the final aggregate's generated code, which comes from the ShuffleExchangeExec operator.

@cloud-fan, actually I tried a lot of different queries yesterday, including joins and aggregations. The only thing that didn't work was collect for a select * from t because SparkPlan assumes that the rows will be unsafe.
I'm planning to do more testing, but I don't see anything that requires UnsafeRow in generated code. @marmbrus, what was the original intent in codegen? Should codegen use InternalRow or UnsafeRow?

all the places that use GenerateUnsafeRowJoiner assume the input row is unsafe row.
ShuffleExchangeExec assumes its input is unsafe row, because its serializer is UnsafeRowSerializer.
Note that we don't enforce this at the API level, i.e. SparkPlan.execute still returns RDD[InternalRow]. This is because we have exceptions: the object related operators can return safe row, and object related operators always appear in a group, and the last operator will output unsafe row.
That said, you may not be able to see UnsafeRow in the generated code, but you will get ClassCastException if you don't follow this rule and output safe row.

@cloud-fan, let me clarify what I'm getting at here.
It appears that Spark makes at least one copy of data to unsafe when reading any Parquet row. If the projection includes partition columns, then Spark makes a second copy to unsafe. Two copies of every row read from Parquet is a fairly common occurrence, even if the plan doesn't need the data to be unsafe.
Most of the operators I've been looking at -- including codegen operators -- support InternalRow. If we can get rid of two copies of every row, then we should look into it. It is even more important, if this causes less headache for implementers of the V2 API. If it doesn't matter whether an implementation produces InternalRow or UnsafeRow to Spark internals, then we don't need an extra trait, SupportsScanUnsafeRow, or any code to handle it in Spark. Simpler APIs are a good thing.
What we need to find out is:

Is there a strong expectation (i.e., a design requirement) that data sources produce UnsafeRow? (This is why I'm asking @marmbrus, but I'm not sure who the best person to ask is.)
How many places actually do depend on UnsafeRow and not InternalRow? I've found one and you pointed out another. But we could update the joiner fairly easily and can probably update other places, too.

This is something we should look into now because it has the potential to be a good speed improvement for queries that use nested data (and don't use the vectorized read path). In addition, it will only get harder to remove needless dependence on UnsafeRow later.

I just did a performance test based on our 2.1.1 and a real table. I tested a full scan of an hour of data with a single data filter.
The scan had 13,083 tasks and read 1084.8 GB. I used identical Spark applications with 100 executors, each with 1 core and 6 GB memory.

With project to UnsafeRow: wall time: 12m, total task time: 19h, longest task: 51s.
Without projection, using InternalRow: wall time: 11m, total task time: 17.8h, longest task: 26s.

Clearly, this is not a benchmark. But this shows a 6% performance improvement for not making unnecessary copies. Eliminating copies is a pretty easy way to get better performance, if we can update a few operators to work with both InternalRow and UnsafeRow.

@rdblue , this is a good point. Since not all the operators need unsasfe row, we can save the copy at data source side if we don't need to produce unsade row. Actually we had such a mechanism before: https://github.com/apache/spark/pull/10511
But I'm not sure if it worth to bring it back. We expect data source to produce ColumnarBatch for better performance, and the row interface performance is not that important. Actually the SupportsScanUnsafeRow is only there to avoid perf regression for migrating file sources. If you think that's not a good public API, we can move it to internal package and only use it for file sources.

Actually the SupportsScanUnsafeRow is only there to avoid perf regression for migrating file sources. If you think that's not a good public API, we can move it to internal package and only use it for file sources.

I don't think it is a good idea to introduce additions for file sources. Part of the motivation for the v2 API is to get rid of those. Besides, I don't think we need it if we handle conversion in Spark instead of in the data sources.
I think we should update the physical plan and push both filters and projections into the v2 scan node. Then data sources won't need to produce UnsafeRow but we can guarantee that the scan node produces UnsafeRow, which it would already do in most cases because it includes a projection. I'll open a PR for this, or I can include the change here if you prefer.

We expect data source to produce ColumnarBatch for better performance, and the row interface performance is not that important.

I disagree. The vectorized path isn't used for all Parquet table scans and we should continue to care about its performance.

@cloud-fan: This PR is also related to #21262 because that PR updates the conversion from logical to physical plan and handles projections and filtering. We could modify that strategy to always ensure that there is a ProjectExec wrapping the scan, which will convert to unsafe. If we did that, then only ProjectExec and FilterExec would need to support InternalRow, which they already do.

If we did that, then only ProjectExec and FilterExec would need to support InternalRow, which they already do.

This partially brings #10511 back, and we need to plan project and filter with data source scan together to make sure unsafe row is produced at the end.
If we want to go this way, I think we should fully bring back #10511 to make this contract explicitly, i.e. which operator produce unsafe row and which operator only accepts unsafe row as input. After this, file sources do not need SupportsScanUnsafeRow to avoid perf regression.
On the other hand, do you think it's possible that a data source can directly produce unsafe row? e.g. it copies its data to unsafe row directly, without an intermedia InternalRow. The point is, SupportsScanUnsafeRow is very easy to maintain, compared to SupportsScanColumnarBatch.

If we want to go this way, I think we should fully bring back #10511 to make this contract explicitly, i.e. which operator produce unsafe row and which operator only accepts unsafe row as input.

Whether internal operators should expect UnsafeRow and fail on InternalRow is a design question that we should discuss on the dev list. I'll start a thread.
The solution I'm suggesting would ensure that sources can produce InternalRow and Spark will convert to unsafe if it is required by the plan (there isn't already a projection). For now, since we know there are places that fail, we would make sure there is a projection before any nodes other than filter.
This would be better than having the data sources handle conversion to unsafe because it avoids extra copies when Spark needs to project anyway and moves the conversion after any filters on top of the scan.

Test build #90478 has started for PR 21118 at commit b5d2c9f.

Test build #90478 has finished for PR 21118 at commit b5d2c9f.

This patch fails RAT tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90478/
Test FAILed.

@cloud-fan, @jose-torres, I think this is ready for final review. I've rebased on top of the rename to InputPartition.
I've also added a projection when this produces a physical plan to ensure that the rows are UnsafeRow when they are passed to other operators. When we eventually move filter and projection pushdown to the conversion to a physical plan, we can put filters below the projection to avoid extra copies of rows that will be filtered out. From discussion here and on the list, I think this is a reasonable way to move forward.

Test build #90481 has started for PR 21118 at commit 43d5893.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3115/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3116/
Test PASSed.

Test build #90481 has finished for PR 21118 at commit 43d5893.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90481/
Test FAILed.

LGTM, although as you mentioned I think it'd definitely be valuable to follow up and understand why some operators insist on UnsafeRow even though this isn't what SparkPlan declares as the row type.

Retest this please.

Test build #90494 has started for PR 21118 at commit 43d5893.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3127/
Test PASSed.

Test build #90494 has finished for PR 21118 at commit 43d5893.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Retest this please

Test build #90507 has started for PR 21118 at commit 43d5893.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3137/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90507/
Test PASSed.

Test build #92868 has started for PR 21118 at commit 9c61719.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/854/
Test PASSed.

Test build #92868 has finished for PR 21118 at commit 9c61719.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92868/
Test PASSed.

@cloud-fan, I'd like to get this PR in by 2.4.0. Now that the change to push predicates and projections happens when converting to the physical plan, this can go in. I've rebased this on master and updated it.
This changes the DSv2 API to primarily use InternalRow. It ensures that the rows are UnsafeRow by adding a projection on top of the physical scan node. This projection is actually more efficient than the current read path because filters are run before the projection. This means, for example, that the Parquet reader can avoid those two projections that currently happen in the scan node.

Rebased on master to fix conflicts.

Test build #93365 has started for PR 21118 at commit d1fa32e.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1186/
Test PASSed.

Merged build finished. Test PASSed.

Test build #93365 has finished for PR 21118 at commit d1fa32e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93365/
Test PASSed.

so where are we on this? looks like we have 2 LGTM?

@cloud-fan, any update on merging this?

retest this please

LGTM, let's merge it when the tests pass (the last pass was 4 days ago)

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1275/
Test PASSed.

Test build #93500 has started for PR 21118 at commit d1fa32e.

Test build #93500 has finished for PR 21118 at commit d1fa32e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93500/
Test PASSed.

Thanks! Merged to master.

Thanks for reviewing and merging @cloud-fan, @gatorsmile, @felixcheung!


Changing propType from string to node on components

Following PR #1950  and as proposed in issue #1961 , here is a patch to update PropTypes of some components for which node seems more flexible than string, without breaking current usage
Components / propsTypes modified :

CardTitle title and subtitle
GridTile title
Checkbox label  (example use case: Check to accept our <Link>TOS</Link>)
List subHeader

If you think other components should be change as well (from the "not sure" list in #1961 ), let me know.
Thanks

I think this is going in the right direction. Shouldn't we update the doc too?

Hah, yes, I did not updated for the precedent PR, because Card title and subtitles props types are not documented

@pandaiolo Thanks for updating the doc :+1:. I can't see good reasons for limiting children to only strings. Feel free to change other component if you need it.


Idea: Support loading configuration in file

Right now, when invoked from the command line, Premark requires its configuration to be passed via command line flags. This means that users who repeatedly create a presentation need to rerun a fairly lengthy command, like premark -o slides.html md_slides.
It would be nice if Premark, on startup, checked the current directory for a configuration file (perhaps premark.ini) and pulled its configuration from that. In that situation, command line arguments should take precedence over the settings in the config file. (This seems like a good use case for itertools.chainmap.)
I haven't thought deeply about implementation yet; it's possible there's a roadblock I don't foresee.

Nearly finished in config-file branch.

Merged to master. Available in version 0.1.0.


Make kubectl kudo commands idempotent

What would you like to be added:
Currently kubectl kudo commands aren't idempotent. E.g., running
kubectl kudo install some-operator
kubectl kudo install some-operator

will return an error for the second run, indicating that this operator has already been installed. This is assuming that the first run successfully installed an operator. To ensure idempotency, no error should be returned in this case. Other commands are affected as well. I.e.

kubectl kudo install shouldn't return an error if the same operator is already installed
kubectl repo add shouldn't return an error if the same repository has already been added
kubectl repo remove shouldn't return an error if the repo to remove doesn't exist in the cluster
kubectl kudo uninstall shouldn't return an error if the operator to uninstall doesn't exist in the cluster

Why is this needed:
Idempotency of operations improves the robustness of APIs in distributed systems, as it makes it easier to deal with unreliabilities.

Some thoughts here on install at the very least -
Should it be idempotent? What's the behavior if the version has changed? If parameters have changed? In these cases a silent failure seems more confusing.
For API based usage, should we be more targeting a KUDO API with upsert functionality, and/or making our CRD usage more robust (or consider an aggregated PAI server?)

Yes, that are some very good points. If anything has been changed in the operator then the input is different. Hence, install should fail because update is the right tool for that case.

Did a deeper dive into Kubernetes APIs and the CLI. Operations in Kubernetes are idempotent in that a cluster state doesn't change when executing an operation multiple times. The operation results can be different though. For APIs this is demanded here: https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/api-conventions.md#idempotency
Given this behavior it doesn't make sense to differ from that and provide idempotency for command results. KUDO operations are already idempotent on the cluster state.


SHOWCASE - SSO Auth0

AB#77678

Azure Demo Servers are available:
Universal B2B
Universal B2C
These demo servers are not working, do we have any other place to checkout this?

Azure Demo Servers are available:
Universal B2B Universal B2C
These demo servers are not working, do we have any other place to checkout this?

The Demo servers are available again.

@shauke Hello Stefan, hope you are doing well. I hope you can help with this, I'm trying  to understand the default user role assignment when the user is created using SSO provided token, I'm using the same process flow as in this Demo server to create the user calling the API processtoken and gettting the user/customer created in ICM however the user does not get assigned to any role so its not able to access any further APIs getting 403s. I know this is not from the PWA but something to do in the ICM, can you get me some help on this if there was some customization done to assign the default role to the user created in the demo server or any specific setting needs to be done? Thank you.

@deepakk799 What ICM version are you using and which PWA version?

@deepakk799 What ICM version are you using and which PWA version?

I am using Intershop Commerce Management B2X - <IP_ADDRESS>-LTS, We are not using the PWA by Intershop but custom build Vue JS application which is hosted in Adobe Experience Manager. However we are following the same flow to get the registration and login process as used in the demo site. Calling Processtoken api to create the user and then creating the customer through ISH customer api. It creates both user and customer and from the backoffice I have to manually assign the users roles in order to make the users activity functioning upon log. Thank you.


Update BackupWalletAuto: rename existing target file.

If the target backup file already exists instead of skipping the backup the existing file is renamed with a suffix time.old and the backup is performed.

Try this patch to the automatic test, and tell me why the checksum of the wallet file and the .old copy are different. I haven't figured it out yet, but I'm sure the answer is simple (possibly even something I'm doing wrong with my addition to the test!):
`
diff --git a/qa/rpc-tests/walletbackupauto.py b/qa/rpc-tests/walletbackupauto.py
index 2fa74dc..819a290 100755
--- a/qa/rpc-tests/walletbackupauto.py
+++ b/qa/rpc-tests/walletbackupauto.py
@@ -36,6 +36,8 @@ and that the debug.log contains a conflict message
"""
import os
+import fnmatch
+import hashlib
from test_framework.test_framework import BitcoinTestFramework
from test_framework.util import *
from random import randint
@@ -221,7 +223,10 @@ class WalletBackupTest(BitcoinTestFramework):
if os.path.isfile(node1backupfile): node1backupexists = 1
else: logging.info("Error backup does not exist: %s"%(node1backupfile))

   if os.path.isfile(node2backupfile): node2backupexists = 1

   if os.path.isfile(node2backupfile):

       node2backupexists = 1

       # for comparison to .old file in later test

       node2backupfile_orig_md5 = hashlib.md5(node2backupfile).hexdigest()
   else: logging.info("Error backup does not exist: %s"%(node2backupfile))

   if os.path.isfile(node3backupfile): node3backupexists = 1

@@ -297,5 +302,36 @@ class WalletBackupTest(BitcoinTestFramework):
assert_equal(0,node4backupexists)
assert_greater_than(len(debugmsg_list),0)

   # test that existing wallet backup is preserved

   # rewind node 2's chain to before backupblock

   logging.info("Rewinding node 2 to before auto backup test preservation of existing backup file")

   self.nodes[2].invalidateblock(self.nodes[2].getblockhash(backupblock))

   logging.info("Stopping all nodes")

   self.stop_four()

   #stop_node(self.nodes[2], 2)

   logging.info("Restarting node 2")

   self.nodes[2] = start_node(2, self.options.tmpdir,["-keypool=100", "-autobackupwalletpath=./newreldir/", "-autobackupblock=%s"%(backupblock) ])

   # check that there is no .old yet (node 2 needs to generate a block to hit the height)

   old_files_found=[]

   for file in os.listdir(tmpdir + "/node2/regtest/newreldir"):

       if fnmatch.fnmatch(file, "wallet.dat.auto.%s.bak.*.old" % (backupblock)):

           print "old file found: %s" % file

           old_files_found.append(file)

   assert_equal(0, len(old_files_found))

   # generate a block to hit the backup block height

   # this should cause the existing backup to be saved to a timestamped .old copy

   self.nodes[2].generate(1)

   for file in os.listdir(tmpdir + "/node2/regtest/newreldir"):

       if fnmatch.fnmatch(file, "wallet.dat.auto.%s.bak.*.old" % (backupblock)):

           print "old file found: %s" % file

           old_files_found.append(file)

   assert_equal(1, len(old_files_found))

   # check that the contents of the .old match what we recorded earlier for node 2's backup

   # (the file should just have been renamed)

   assert_equal(node2backupfile_orig_md5,

                hashlib.md5(os.path.join(tmpdir, "/node2/regtest/newreldir", old_files_found[0])).hexdigest())

   stop_node(self.nodes[2], 2)

   self.start_four()

if name == 'main':
WalletBackupTest().main()
`

I've added your patch and also replaced path definitions using os.path.join.
The function which seems to take the longest time is do_one_round() which has 6 calls to one_send().

Thanks for updating the test.


Favicon is still uhuru => Change to Freeflow.

Which favicon exactly? The one in spawner has been handled in this issue and will be fixed next release.
In the app, I have the correct favicon.

Was caching apparantly


Preflight Checklist

[x] I agree to follow the Code of Conduct that this project adheres to.
[ ] I have searched the issue tracker for an issue that matches the one I want to file, without success.
[ ] I am not looking for support or already pursued the available support channels without success.

Version
develop->7e20dc51412cc253f6cf0aa46fd5fb1cf4917f97
Installation Type
Official Docker Compose
Service Name
Deploy(DongTai-deploy)
Describe the details of the bug and the steps to reproduce it

尝试按官方文档使用docker-compose方式安装server端失败, 安装脚本无明显失败报错
Additional Information
No response
Logs
No response

使用 -v 指定安装版本即可正确安装


'Type Query not found' when pushing new environment

Describe the bug
When I try to push new environment I get error:
Type Query not found (Service: AWSAppSync; Status Code: 404; Error Code: NotFoundException)
Amplify CLI Version
4.32.1
To Reproduce
amplify env add prod
amplify push
Expected behavior
The new environment to be created
Screenshots
Resource Name: QuerynearbyTowersResolver (AWS::AppSync::Resolver) Event Type: create Reason: Type Query not found (Service: AWSAppSync; Status Code: 404; Error Code: NotFoundException; Request ID: 165cf41b-0319-42e5-a72e-47cde4b9bae9; Proxy: null)
Desktop (please complete the following information):

OS: Mac
Node Version: 14.11.0

There is a GraphQL API in your project based the error message, we'll need to get more information on the API to investigate further. Can you share the schema of the GraphQL API? you can edited out sensitive information if there is any, just any  schema that would reproduce this issue.

@UnleashedMind thank you for your reply!
Here is the schema:
type Player @model(subscriptions: null) @key(fields: ["owner"])
  @key(name: "byScore", fields: ["type", "score"], queryField: "getPlayersByScore")
  @auth(rules: [
    { allow: private, operations: [read] },
    { allow: private, provider: iam }
  ]) {
  type: String!
  owner: String!
  score: Int!
  towers: [Tower] @connection(keyName: "byPlayer", fields: ["owner"])
}

type Tower @model(subscriptions: null) @searchable
  @key(name: "byPlayer", fields: ["playerOwner"])
  @auth(rules: [
        { allow: private, provider: iam },
        { allow: private, operations: [read] }
      ]) {
  id: ID!
  location: Location!
  playerOwner: String!
  player: Player @connection(fields: ["playerOwner"])
}

type Location {
  lat: Float!
  lon: Float!
}

type Query {
 nearbyTowers(
   location: LocationInput!,
   m: Int,
   limit: Int,
   nextToken: String
 ): ModelTowerConnection @auth(rules: [
      { allow: private, provider: userPools }
      { allow: private, provider: iam }
    ])
}

input LocationInput {
  lat: Float!
  lon: Float!
}

type ModelTowerConnection {
 items: [Tower]
 total: Int
 nextToken: String
}

My best guess is that is somehow related to Elastic Search which I use in the project.

The issue is not about pushing to new environment or the @seachable, but with the type Query you inserted into your schema, I was able to push and change env with type Query removed.

When I tried to remove Query from the scheme and ran amplify push I got the error: No field named nearbyTowers found on type Query . Obviously this is because this field is being used by CustomeResources.json:
"Resources": {
       ...
        "QueryNearbyTowers": {
            "Type": "AWS::AppSync::Resolver",
            "Properties": {
                "ApiId": {
                    "Ref": "AppSyncApiId"
                },
                "DataSourceName": "ElasticSearchDomain",
                "TypeName": "Query",
                "FieldName": "nearbyTowers",
                "RequestMappingTemplateS3Location": {
                    "Fn::Sub": [
                        "s3://${S3DeploymentBucket}/${S3DeploymentRootKey}/resolvers/Query.nearbyTowers.req.vtl",
                        {
                            "S3DeploymentBucket": {
                                "Ref": "S3DeploymentBucket"
                            },
                            "S3DeploymentRootKey": {
                                "Ref": "S3DeploymentRootKey"
                            }
                        }
                    ]
                },
                "ResponseMappingTemplateS3Location": {
                    "Fn::Sub": [
                        "s3://${S3DeploymentBucket}/${S3DeploymentRootKey}/resolvers/Query.nearbyTowers.res.vtl",
                        {
                            "S3DeploymentBucket": {
                                "Ref": "S3DeploymentBucket"
                            },
                            "S3DeploymentRootKey": {
                                "Ref": "S3DeploymentRootKey"
                            }
                        }
                    ]
                }
            }
        }
        ...

I followed this tutorial to implement location based search.
Any advice on how this can be fixed?
Thank you!

@lysachok seems your latest error is related to #5289 which I just ran into today.
@UnleashedMind any chance related issue #5289 can get triaged as it's pretty debilitating for me currently and has been open for a few months without triage.

I managed to get a custom Query backed by a Lambda resolver working by removing the @auth Amplify-supplied annotation I use elsewhere and using AppSync's @aws_iam and @aws_cognito_user_pools annotations instead.
I hadn't used those annotations before as stuck with Amplify's @auth annotation, but I ran into various issues whatever I tried when using that annotation.

@danrivett it helped! Thank you.


Relax version of tesla

This PR relaxes the required version of tesla and bumps the lock file so the tests are run with the latest version.

There seem to be no breaking changes: https://github.com/elixir-tesla/tesla/releases

Hey @dvic , thanks for the contribution!
This change looks good to me, I'd even consider to just set the requirement to ~> 1.4 tbh.
I see coveralls is having some trouble though, I'm trying to figure out what happened


Using Pathname to check for absolute path in ruby script

🦟 Bug fix
Part of https://github.com/gazebosim/gz-tools/issues/7
Summary
As suggested in this comment by @scpeters, porting the fix from https://github.com/gazebosim/gz-plugin/pull/131 for determination of absolute path in ruby script.
Checklist

[ ] Signed all commits for DCO
[ ] Added tests
[ ] Updated documentation (as needed)
[ ] Updated migration guide (as needed)
[ ] Consider updating Python bindings (if the library has them)
[ ] codecheck passed (See contributing)
[ ] All tests passed (See test coverage)
[ ] While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

homebrew build is failing due to https://github.com/osrf/homebrew-simulation/issues/2834

I experimented with enabling windows tests in https://github.com/gazebosim/gz-transport/commit/d37b501e58467bce14dbd5025ea2becd4c711141, but I saw a lot of failed to create subprocess errors, so let's not block on that

https://build.osrfoundation.org/job/gz_transport-14-win/22/

The failing tests are due to https://github.com/osrf/homebrew-simulation/issues/2834 and not related to this change.


special permission should generate onActivityResult

This plugin does not generate onActivityResult when developers select special permission.

I think this is the only issue left before releasing this plugin.


No desktop push notifications are sent for Concierge chats received in NewDot

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Send message to Concierge to prompt a response
Click into another tab
Check back a few minutes later to see if Concierge responded
Now, send a message to someone who isn't Concierge asking for a response
Click into another tab

Expected Result:
You should get a push notification when user or Concierge respond
Actual Result:
No desktop push notifications are sent for Concierge chats received in NewDot
Workaround:
Unknown
Platform:

Where is this issue occurring?

Desktop App

Version Number: 1.1.89-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @sakluger
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1660573368623459
View all open jobs on GitHub

I believe this should have been the engineering tag rather than triage

Unassigning myself after reproducing the issue. I think this is an internal issue.