Error in Finetuning

Hi All
Thank you for this great project. While trying out the fine-tune.py script, I got the error below despite installing all the required modules, including the flash-attn --no-build-isolation. How could this be rectified? Thanks.
ModuleNotFoundError                       Traceback (most recent call last)
 in <cell line: 11>()
9 from torch.utils.data import Dataset
10 from transformers import Trainer, DataCollatorForLanguageModeling
---> 11 from llama_attn_replace import replace_llama_attn
12 from peft import LoraConfig, get_peft_model
13 from torch.distributed import barrier
ModuleNotFoundError: No module named 'llama_attn_replace'

NOTE: If your import is failing due to a missing package, you can
manually install dependencies using either !pip or !apt.
To view examples of installing some common dependencies, click the
"Open Examples" button below.
I also got the error below while running the Supervised Fine-tuning script. Error:
WARNING:torch.distributed.run:

Setting OMP_NUM_THREADS environment variable for each process to be 1 in default, to avoid your system being overloaded, please further tune the variable for optimal performance in your application as needed.

2023-09-29 02:23:07.921163: W tensorflow/compiler/tf2tensorrt/utils/py_utils.cc:38] TF-TRT Warning: Could not find TensorRT
2023-09-29 02:23:07.941552: W tensorflow/compiler/tf2tensorrt/utils/py_utils.cc:38] TF-TRT Warning: Could not find TensorRT
2023-09-29 02:23:08.336867: W tensorflow/compiler/tf2tensorrt/utils/py_utils.cc:38] TF-TRT Warning: Could not find TensorRT
2023-09-29 02:23:08.784676: W tensorflow/compiler/tf2tensorrt/utils/py_utils.cc:38] TF-TRT Warning: Could not find TensorRT
2023-09-29 02:23:09.024703: W tensorflow/compiler/tf2tensorrt/utils/py_utils.cc:38] TF-TRT Warning: Could not find TensorRT
2023-09-29 02:23:09.052531: W tensorflow/compiler/tf2tensorrt/utils/py_utils.cc:38] TF-TRT Warning: Could not find TensorRT
2023-09-29 02:23:09.285467: W tensorflow/compiler/tf2tensorrt/utils/py_utils.cc:38] TF-TRT Warning: Could not find TensorRT
2023-09-29 02:23:09.403561: W tensorflow/compiler/tf2tensorrt/utils/py_utils.cc:38] TF-TRT Warning: Could not find TensorRT
Traceback (most recent call last):
File "/content/supervised-fine-tune.py", line 29, in
from llama_attn_replace import replace_llama_attn
ModuleNotFoundError: No module named 'llama_attn_replace'
Traceback (most recent call last):
File "/content/supervised-fine-tune.py", line 29, in
from llama_attn_replace import replace_llama_attn
ModuleNotFoundError: No module named 'llama_attn_replace'
Traceback (most recent call last):
File "/content/supervised-fine-tune.py", line 29, in
from llama_attn_replace import replace_llama_attn
ModuleNotFoundError: No module named 'llama_attn_replace'
Traceback (most recent call last):
File "/content/supervised-fine-tune.py", line 29, in
from llama_attn_replace import replace_llama_attn
ModuleNotFoundError: No module named 'llama_attn_replace'
Traceback (most recent call last):
File "/content/supervised-fine-tune.py", line 29, in
from llama_attn_replace import replace_llama_attn
ModuleNotFoundError: No module named 'llama_attn_replace'
Traceback (most recent call last):
File "/content/supervised-fine-tune.py", line 29, in
from llama_attn_replace import replace_llama_attn
ModuleNotFoundError: No module named 'llama_attn_replace'
Traceback (most recent call last):
File "/content/supervised-fine-tune.py", line 29, in
from llama_attn_replace import replace_llama_attn
ModuleNotFoundError: No module named 'llama_attn_replace'
Traceback (most recent call last):
File "/content/supervised-fine-tune.py", line 29, in
from llama_attn_replace import replace_llama_attn
ModuleNotFoundError: No module named 'llama_attn_replace'
ERROR:torch.distributed.elastic.multiprocessing.api:failed (exitcode: 1) local_rank: 0 (pid: 7451) of binary: /usr/bin/python3
Traceback (most recent call last):
File "/usr/local/bin/torchrun", line 8, in
sys.exit(main())
File "/usr/local/lib/python3.10/dist-packages/torch/distributed/elastic/multiprocessing/errors/init.py", line 346, in wrapper
return f(*args, **kwargs)
File "/usr/local/lib/python3.10/dist-packages/torch/distributed/run.py", line 794, in main
run(args)
File "/usr/local/lib/python3.10/dist-packages/torch/distributed/run.py", line 785, in run
elastic_launch(
File "/usr/local/lib/python3.10/dist-packages/torch/distributed/launcher/api.py", line 134, in call
return launch_agent(self._config, self._entrypoint, list(args))
File "/usr/local/lib/python3.10/dist-packages/torch/distributed/launcher/api.py", line 250, in launch_agent
raise ChildFailedError(
torch.distributed.elastic.multiprocessing.errors.ChildFailedError:
supervised-fine-tune.py FAILED
Failures:
[1]:
time      : 2023-09-29_02:23:33
host      : ebc31241e54d
rank      : 1 (local_rank: 1)
exitcode  : 1 (pid: 7452)
error_file: <N/A>
traceback : To enable traceback see: https://pytorch.org/docs/stable/elastic/errors.html
[2]:
time      : 2023-09-29_02:23:33
host      : ebc31241e54d
rank      : 2 (local_rank: 2)
exitcode  : 1 (pid: 7453)
error_file: <N/A>
traceback : To enable traceback see: https://pytorch.org/docs/stable/elastic/errors.html
[3]:
time      : 2023-09-29_02:23:33
host      : ebc31241e54d
rank      : 3 (local_rank: 3)
exitcode  : 1 (pid: 7454)
error_file: <N/A>
traceback : To enable traceback see: https://pytorch.org/docs/stable/elastic/errors.html
[4]:
time      : 2023-09-29_02:23:33
host      : ebc31241e54d
rank      : 4 (local_rank: 4)
exitcode  : 1 (pid: 7455)
error_file: <N/A>
traceback : To enable traceback see: https://pytorch.org/docs/stable/elastic/errors.html
[5]:
time      : 2023-09-29_02:23:33
host      : ebc31241e54d
rank      : 5 (local_rank: 5)
exitcode  : 1 (pid: 7456)
error_file: <N/A>
traceback : To enable traceback see: https://pytorch.org/docs/stable/elastic/errors.html
[6]:
time      : 2023-09-29_02:23:33
host      : ebc31241e54d
rank      : 6 (local_rank: 6)
exitcode  : 1 (pid: 7457)
error_file: <N/A>
traceback : To enable traceback see: https://pytorch.org/docs/stable/elastic/errors.html
[7]:
time      : 2023-09-29_02:23:33
host      : ebc31241e54d
rank      : 7 (local_rank: 7)
exitcode  : 1 (pid: 7458)
error_file: <N/A>
traceback : To enable traceback see: https://pytorch.org/docs/stable/elastic/errors.html
Root Cause (first observed failure):
[0]:
time      : 2023-09-29_02:23:33
host      : ebc31241e54d
rank      : 0 (local_rank: 0)
exitcode  : 1 (pid: 7451)
error_file: <N/A>
traceback : To enable traceback see: https://pytorch.org/docs/stable/elastic/errors.html

You need to also include llama_attn_replace.py in the directory of your fine-tuning script.

Hi zpx01
Yes, I included the  llama_attn_replace.p in the directory of your fine-tuning script.

I will close this issue as it has been inactive for several days. Please feel free to re-open it if there are any others to discuss.


Update information-protection-deploy-protect-information.md

Calling out M365 Endpoint data loss prevention(Preview) on this page

@JohanFreelancer9 Please copy review

Issue#https://github.com/MicrosoftDocs/microsoft-365-docs/issues/2659


Regression found for suggestions without tld

@derrickko
One of the recent merges, either #133 or #137 [update: sorry, nothing to do with 137 as that's just a text change] has a regression. If you type a@gm it will suggest a@com and a@gmail comes back with no suggestions where as it use to return<EMAIL_ADDRESS>This is happening on the master branch. If you apply my fix in #138 it will resolve the first issue but the second issue still remains.

yes! the problem is with #133 I mentioned in this PR: https://github.com/ZooTools/email-spell-checker/pull/3

FYI, I rewrote it entirely and update it for 2022 and onward: https://github.com/ZooTools/email-spell-checker

💙 Written in TypeScript and removed jQuery
✅ Fixed a couple of bugs like this or this
🚀 Reduced bundle size to <2KB.
✨ Update TLDs (69+) and added modern startup domains (like .io, .so, .xyz or .dev)
🙏 Implemented suggestions that people made in this repo that were ignored.

Link: https://github.com/ZooTools/email-spell-checker
Come check it out and give it a ⭐ for the effort.


Issue with SerializabledImporters field on standard Unity Inspector

Hi, thank you for the recent update!
I can now install the package.
But I still having trouble to set up the GoogleSpreadsheetImporter
From The Readme

Current Version

The SerializabledImporters field can't be collapsed! Just a text with 'Element 0, Element 1'
Maybe because I don't use Odin Inspector?
I'm using Unity 2020.3.27f1 (LTS)
P.S.
I think the readme need to be updated.

In the newer version, The GoogleSpreadsheetImporter is created on the context menu: Create -> UniGame -> Google -> GoogleSpreadSheetImporter, not from the Menubar.

I don't understand what is SpreadsheetAssetsFolderImporter and how to configure it. A working demo (if possible) will be very helpful.

Thank you!

Hello friend. Try to install https://odininspector.com Unity Package
Work of package without odin will be fixed later

I see, okay then
Thank you for the help Mefodei!


Change manifest link

please dont use personal manifest rather than rom manifest, it costs extra 200G storage on server


Update contributors information and alphabetize

Signed-off-by: Brennan Ashton<EMAIL_ADDRESS>

Hi,
The information n this page is not correct. Currently the roster [1] shows.
Mentors are:
Flavio Paiva Junqueira
Junping Du
Justin Mclean
Mohammad Asif Siddiqui
PPMC members are:
Abdelatif Guettouche
Alan Carvalho de Assis
Alin Jerpelea
Anthony Merlino
David Sidrane
Gregory Nutt
Masayuki Ishikawa
Nathan Hartman
Xiang Xiao
Committers are:
Brennan Ashton
Thanks,
Justin

https://whimsy.apache.org/roster/ppmc/nuttx

Hi,
Note that all Mentors are PPMC members (and IPMC members) and all PPMC members are committers as well.
Thanks,
Justin

That is what I looked at to update this.  Are you asking to break it out to also include PPMC or to enumerate all, so for you it would be (Mentor, PPMC, IPMC, Commiiter)

HI,

That is what I looked at to update this. Are you asking to break it out to also include PPMC or to enumerate all, so for you it would be (Mentor, PPMC, IPMC, Commiiter)

Most people are listed as committers when they are also PPMC members. It might be useful to break it up that way, a lot of projects do so.
Thanks,
Justin

Ok, fully enumerated it is.  Updated the PR.

LGTM


[BUG] with-messaging ports example doesn't work

What happened?
I have the code below, which closely mimics the with-messaging Plasmo example:
// ~/background/messages/message-handler.ts

import { getPort } from "@plasmohq/messaging/background"

import type { PlasmoMessaging } from "@plasmohq/messaging"

const handler: PlasmoMessaging.MessageHandler = async (req, res) => {
  const port = getPort("test")
  port.postMessage("Test message")
  res.send({ success: true })
}

export default handler

// ~/background/ports/test.ts

import type { PlasmoMessaging } from "@plasmohq/messaging"

const handler: PlasmoMessaging.PortHandler = async (req, res) => {
  console.log({ req })
  res.send(req)
}

export default handler

When message-handler.ts is called by an external webpage sending a message to the extension via relayMessage in a content script, instead of the message handler sending a message "Test message" to the port, the service worker logs the following error:
background.cjs:1 Uncaught (in promise) Error: Port test not found
    at x (background.cjs:1:791)
    at handler (message-handler.ts:7:20)
    ...
    await in handler (async)
    anonymous            @ messaging.ts:177

Version
Latest
What OS are you seeing the problem on?
MacOSX
What browsers are you seeing the problem on?
Chrome
Relevant log output
No response
(OPTIONAL) Contribution

[ ] I would like to fix this BUG via a PR

Code of Conduct

[X] I agree to follow this project's Code of Conduct
[X] I checked the current issues for duplicate problems.

Hi there, I'd recommend you do a little more reading into the messaging API in the plasmo docs, or ask the AI bot Pallas on the discord which has also helped me out loads.
From the limited code that I can see though, I can say that the error you are currently running into is from having your port handler under ~/background/messages/ports/test.ts instead of  ~/background/ports/test.ts, as having the port handler under the wrong directory would cause plasmo not to run that code as a port.

Hey @Acorn221, thank you for your message, I will check out the discord - thanks for the tip!
Good spot, I realised that was actually a copy/paste error, my port hander is in fact under ~/background/ports/test.ts. I've updated my comment to reflect that. If you have any other ideas as to why this is erroring, please do let me know.

Ahh I see, I'm also pretty sure that the chrome ports API is not designed for you to communicate from within the background service worker, to the background service worker. You might be better off by registering an event hander under background/index.ts and importing it into the message handler, firing off an event from that message handler, then just adding some code in that monitors that EventTarget instance for the event that you fire off.
So instead of having your test.ts port, you would just have extra code running in background/index.ts that looked like
const target = new EventTarget();

target.addEventListener('test', () => {
  console.log("I am an event that has been triggered");
});
export { target };

Then under your message handler, you'd have something like
import { target } from '~/background';

import type { PlasmoMessaging } from "@plasmohq/messaging"

const handler: PlasmoMessaging.MessageHandler = async (req, res) => {
  const event = new Event('test');
  target.dispatchEvent(event);
  res.send({ success: true })
}

export default handler

I hope this helps! Let me know if you run into any issues with it.

Hey @Acorn221, this is fantastic. Wouldn't have thought of this. Thank you for your help. Will try this in the morning and let you know how it goes.

Hey @Acorn221 this worked fantastically, thank you.
I didn't manage to get my initial code, which follows the with-messaging Plasmo example, to work. However your workaround worked great.


Add birth command

Add the birth command on both CV and resume so that writer can display it.

There is already a similar pull request: #124

I have the feeling that this package is no longer as well maintained as it was at the beginning. Unfortunately, many issues and pull requests remain unanswered.


[Doc] Add partitioning note

What type of PR is this：

[ ] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[x] Doc
[ ] Tool

Which issues of this PR fixes ：

Fixes #
Problem Summary(Required) ：

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] I have added user document for my new feature or new function

run starrocks_admit_test

@mergify backport branch-2.3 branch-2.4


Checkins not parsed as such?

Disclaimer: not too big a fan of checkins. That said, I noticed, e.g., X-Ray (which I use for my home-grown feed reader, too, and relies on mf2-php) doesn't seem to pick up https://xray.p3k.app/parse?url=https%3A%2F%2Fjamesvandyne.com%2F0bb1651e-c6fc-4e41-8c6b-081b7fb79626&pretty=true as a checkin, while, e.g., https://xray.p3k.app/parse?url=https%3A%2F%2Fdavid.shanske.com%2F2021%2F08%2F22%2F5128%2F&pretty=true works fine.
Thinking it's a missing u-checkin on (e.g.) the Swarm/Foursquare link. (Guessing you'd also want to add this to checkins on the homepage.)
Wondering if with it, it'll also pick up the coordinates.

@janboddez Thanks for the bug report! I've added the u-checkin tag, so everything should be working fine. I have the p-location attribute for the post on the detail page (it's down near the map), but I've now also included it in the u-checkin card.
I hear you with the checkins. I didn't see the point really until I could backfeed them into my blog (with photos) as it allows me to create collections as trips.
X-Ray seems to be picking up the fixes.


Patch dependencies whose latest versions are no longer compatible with 1.75

This PR attempts to fix the CI for version 1.75, locking down specific versions of dependencies whose latest versions are no longer compatible.

@koonpeng this PR fixes a CI failure related to a dependency problem, but it seems there's still a test failure related to a panic for the Join operation.
I'd suggest merging this in despite the CI still not passing, and then you can continue working on the implementation of Join.


[Event Request] Report 202 Sales Document - Test - OnBeforeCheckSalesLine

Hello team,
We request that you add an event publisher in the procedure CheckSalesLine() from report 202 Sales Document - Test according to the suggestion in the screenshots below. This to facilitate checks on the Sales Line which do contain the standard Type, but have extra requirements on the line itself. Thank you in advance.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


Rotate image feature

Could you please add "rotate image" feature. I'm not sure if the application takes into account the exif metadata of the image; in my case the image is 480x640 and is always rotated to landscape format 640x480 to the left after loading.

OS: Ubuntu 17.04
PyQt version: 5

I am also facing similar issue, my images are also rotated automatically and hence It gives wrong annotation coordinates.

Weird, I haven't experienced this issue myself. Do you mind posting an example for us to test w/?

Here are some examples of the problem:

I managed to find a solution to put the images right by modifying the exif metadata with this command: exiftran -ai *.jpg
This command will change the exif metadata of all jpg files in the current directory to turn them 90° right.
`

I also realized this issue, which makes my trained model incorrect. Here is my example of this issue ,the two images are the same actually.

@Pitt64 hi，did  you take these pictures with your photo？ I take my photos with my iphone6 and I find that if I upload the photos with data cable，the image in labelImg always takes the left side of my phone as its bottom. But when I upload photos with wechat(a chinese social software), there is no rotation when I use labelImg. I just wonder if your situation is the same as mine

When a picture is taken with some camera, it is recorded as a landscape direction picture and it is specified in the EXIF file of the picture that it was a portrait direction picture.
labelImg isn't handling the rotation needed through that EXIF file.
You have to rotate and save the pictures before using them in labelImg.
You can use
On Linux :
exiftran -ai *.jpeg
exiftran
On Windows:
JPEG Autorotate

Hi,
If the orientation of Exif is 6, the image rotates 90 degrees clockwise, but labelImg seems to rotate counterclockwise 90 degrees.
Have the recent version repaired issue # 198 issue?
Also, since darknet does not consider the orientation of Exif (since darknet recognizes that the image is rotating 90 degrees clockwise), when labelImg rotates the image 90 degrees counterclockwise Does the coordinates of the bounding box that we made are incorrect coordinates for darknet?

I have a similar issue. I decided to go through every image and right click and rotate either left or right depending on what that image needed until all images were orientated the correct way, however this didn't seem to work and labelImg is still showing them in the old rotations. I even restarted my computer just to be sure the orientation wasn't getting updated or something like that but no, when I view the images as "extra large icons" they are rotated in the correct fashion, but when I re-open labelImg it is still showing the wrong orientations. I have almost a thousand images, some of them need a clockwise rotation, others need a counterclockwise rotation so I can't rotate them all in one direction with one command. I have no idea why manually rotating images in the file didn't work

update, I seem to have found something that sorta works just by combining bits and pieces of code I found everywhere(assuming you already manually went through and rotated each image). For some reason it gives errors for some images, but for now the try statement just ignores those, I'll try to figure out why later:
import os
import glob
import PIL
import sys
from PIL import Image, ExifTags
orig_dir = "C:\Users\path_to_origional_images"
conv_dir = "C:\Users\path_to_new_folder_to_store_images\" # make sure to have \ at the end
photos = glob.glob(orig_dir + '/*.jpg')
total_pictures = len(photos)
print("total number of photos is: " + str(total_pictures))
k = 0
for photo in photos:
try:
k = k+1
print(photo)
# still check if the photo is there. it may have moved
if not os.path.isfile(photo):
continue
im = Image.open(photo)
    for orientation in ExifTags.TAGS.keys():
        if ExifTags.TAGS[orientation] == "Orientation":
            break
    exif=dict(im._getexif().items())
    if exif[orientation] == 3:
        im=im.rotate(180, expand=True)
    elif exif[orientation] == 6:
        im=im.rotate(270, expand=True)
    elif exif[orientation] == 8:
        im=im.rotate(90, expand=True)

    im.save(conv_dir +str(k)+ ".png")
    im.close()
except:
    print("caught error")

I opened each image in MS Paint, saved it, and closed it. That seemed to properly orient the image in labelimg

I meet the same problem, the picture changed when i open it in labelImg. beside this issue, i find another closed issue
Rotate 90° when opening？ #342
reason
the key of this problem is because the jpeg image have the metadata exif in wiki, some camera equipment will save the direction sensor's info and some tools will use this meta. obviously labelImg do it
solution
one solution is mentioned above @humandotlearning , use exiftran to change it
another solution is to change the jpeg image to png before you anno it
other
by the way, i tried several tools to open the jpeg image , some use it and some do not use it. for example, labelImg and vscode parse the exif meta; but opencv (cv2.imread) and ubuntu's image tool do not parse

@Pitt64 , I found what was the problem !
When a picture is taken with some camera, it is recorded as a landscape direction picture and it is specified in the EXIF file of the picture that it was a portrait direction picture.
labelImg isn't handling the rotation needed through that EXIF file.
You have to rotate and save the pictures before using them in labelImg.
You can use
On Linux :
exiftran -ai *.jpeg
exiftran
On Windows:
JPEG Autorotate

exiftran -ai *.jpg

how did you use that command ? mine not working from gitbash on that folder

RectLabel is an offline image annotation tool for object detection and segmentation.
Although this is not an open source program, with RectLabel you can remove the EXIF orientation flags from images and convert images to the front orientation. If necessary, you can rotate the image right/left by 90 degrees.
https://rectlabel.com/help#remove_exif_orientation_flags


Math.h does not compile on MSVC

There are multiple mismatches between the header declarations and inline definitions on MSVC. See:
https://github.com/awslabs/aws-c-common/blob/master/include/aws/common/math.h#L74
https://github.com/awslabs/aws-c-common/blob/master/include/aws/common/math.msvc.inl#L70

it has been fixed https://github.com/awslabs/aws-c-common/blob/main/include/aws/common/math.msvc.inl#L113


Release 2024.04.02-SNAPSHOT

Update Diffblue Cover to 2024.04.02-SNAPSHOT

Created as part of testing


Change configuration so that it can be retrieved from different sources

Change configuration so that it can be retrieved from different sources. This way it can be retrieved from the database or config file. This also exposes it to be changed by deployers like Octopus.
Can you advise me as to the default registry location?
64 Bit is HKLM\SOFTWARE\Bittrex
32 Bit is HKLM\SOFTWARE\WOW6432Node\Bittrex

I also noticed that the RISE tests were not passing.
I dont trade RISE so the Balance result was nullable.
Bittrex currently has a wallet outtage for RISE, so the deposit address test was also failing. However I didnt change this because its not a usual situation.


Android Studio data folder is not persisted

Bug Report
android-studio
Current Behaviour
Unlike idea and pycharm that root folders only contain IDE and profile (these folders are persisted), android-studio contains 5 folders and none of them is persisted.
Expected Behaviour
Among the 5 folders, plugins folder should be persisted so any plugin data will not just sit in old version folder of android-studio after update
System details
Windows version: 11
OS architecture: 64bit
PowerShell version: 7.2
Scoop Configuration

{
  "lastupdate": "2022-03-08T13:18:06.8105284+07:00",
  "SCOOP_REPO": "https://github.com/ScoopInstaller/Scoop",
  "SCOOP_BRANCH": "master"
}

Please make a PR for the fix

Sorry I'm not familiar with tweaking this. Could you give me a reference so at least I can know which code does what?

You don't need to modify any code. Look for the term persist in the repo, there are plenty of examples. You just need to modify the json


Project license

An explicit license file is something good to have if it's about to be used for commercial purposes and encourage contributors to add improvements.
Recommended one: Apache License 2.0

I copied this from other projects that I have... in next releases I look this point.
Thank you :)

License changed.


Adding yaml frontmatter for the hub.innersourcecommons.org config

I added YAML frontmatter to create hub.innersourcecommons.org.
Since this is an operational change that does not affect the content itself, we would like to use Lazy Consensus.
I would like to close and merge in a week, Aug 19.
Please confirm

Should we just move all of these files to the hub repo?

Thank you for asking it! No, we can manage all the document here.
I just use this repository there as git's submodule:)

I don’t understand.  YES - move all files here to this repo?  Or NO - leave files in __ and foundation-governance repos?


I can not download sql server windows container

Expected behavior
Actual behavior
Information about the Issue
Steps to reproduce the behavior

...
...

I was downloading from mac os system, i think that it's the reason...


PartitionKey class instead of object

PartitionKey class instead of object
Description
This PR introduces the PartitionKey class as a public contract in the Microsoft.Azure.Cosmos namespaces and modifies all public APIs that receive a partition key to use the new class instead of object.
This avoids runtime issues when passing ItemRequestOptions as partition key passed on compile time but failed running.
Type of change

[X] New feature (non-breaking change which adds functionality)
[X] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Closing issues
This PR closes #287

@ealsur a big thank you for this.

Waiting for Lazy removal part. Lets have issues tracking others and resolve comments.
Good to go.


Closes #207 | ID Frog Story

Please name your PR after the issue it closes. You can use the following line: "Closes #ISSUE-NUMBER" where you replace the ISSUE-NUMBER with the one corresponding to your dataset.
Checkbox

[x] Confirm that this PR is linked to the dataset issue.
[x] Create the dataloader script nusantara/nusa_datasets/my_dataset/my_dataset.py (please use only lowercase and underscore for dataset naming).
[x] Provide values for the _CITATION, _DATASETNAME, _DESCRIPTION, _HOMEPAGE, _LICENSE, _URLs, _SUPPORTED_TASKS, _SOURCE_VERSION, and _NUSANTARA_VERSION variables.
[x] Implement _info(), _split_generators() and _generate_examples() in dataloader script.
[x] Make sure that the BUILDER_CONFIGS class attribute is a list with at least one NusantaraConfig for the source schema and one for a nusantara schema.
[x] Confirm dataloader script works with datasets.load_dataset function.
[x] Confirm that your dataloader script passes the test suite run with python -m tests.test_nusantara --path=nusantara/nusa_datasets/my_dataset/my_dataset.py.
[x] If my dataset is local, I have provided an output of the unit-tests in the PR (please copy paste). This is OPTIONAL for public datasets, as we can test these without access to the data files.

Sorry for the late fix, I have updated the code base on the review

/test dataset=id_frog_story


'Newtonsoft.Json.JsonWriter' threw an exception.

The Assistant fails when running the basic checks. with the following error:
Unhandled Exception: System.TypeInitializationException: The type initializer for 'Newtonsoft.Json.JsonWriter' threw an exception. ---> System.IO.FileLoadException
at Newtonsoft.Json.Utilities.EnumUtils.InitializeValuesAndNames(StructMultiKey2 key)  at System.Collections.Concurrent.ConcurrentDictionary2.GetOrAdd(TKey key, Func`2 valueFactory)
at Newtonsoft.Json.Utilities.EnumUtils.GetEnumValuesAndNames(Type enumType)
at Newtonsoft.Json.JsonWriter.BuildStateArray()
at Newtonsoft.Json.JsonWriter..cctor()
--- End of inner exception stack trace ---
at Newtonsoft.Json.JsonWriter..ctor()
at Newtonsoft.Json.JsonTextWriter..ctor(TextWriter textWriter)
at Newtonsoft.Json.JsonConvert.SerializeObjectInternal(Object value, Type type, JsonSerializer jsonSerializer)
at Newtonsoft.Json.JsonConvert.SerializeObject(Object value, Formatting formatting)
at iisConfigAssistant.Program.Main(String[] args)

All server are Windows Server 2012 R2
This happens on all servers in this cluster.

You refer to the servers as being in a cluster - I am guessing this means they are in a failover cluster? Unfortunately the Migration Assistant does not support clustered IIS servers as a migration source at this time. I have updated the main wiki page with this detail in the FAQs server requirements: https://github.com/Azure/App-Service-Migration-Assistant/wiki.
Thank you for reporting this. We will consider enabling this type of server source in future and/or improving the error message for this case. If I've misunderstood and your are not using clustered servers please let me know and I will provide instructions for getting some additional debugging information.

You are correct my server are in a cluster environment.


OOTB WebPart still using TypeScript 2.2.2 and complaining about the jsZip typings

Category

[x] Question
[ ] Typo
[ ] Bug
[ ] Additional article idea

Expected or Desired Behavior
Compilation of a basic WebPart using<EMAIL_ADDRESS>without problems
Steps to Reproduce

installed the latest generator-sharepoint, yo and gulp
installed typescript 3.3.4 &<EMAIL_ADDRESS>update the tsconfig to extend the rush-stack config
create a basic 2016 and later webpart, no framework
npm i jszip @types/jszip
gulp serve

The serve command fails and reports using typescript 2.2.2

[15:18:31] Starting subtask 'typescript'...
[15:18:31] [typescript] TypeScript version: 2.2.2
[15:18:31] Finished subtask 'copy-static-assets' after 1.72 s
[15:18:33] Error - typescript - node_modules@types\jsZip\index.d.ts(109,57): error TS1005: ',' expected.
[15:18:34] Finished subtask 'tslint' after 3 s
[15:18:34] Error - 'typescript' sub task errored after 3.08 s
"TypeScript error(s) occurred."
[15:18:34] 'serve' errored after 4.79 s

I've tried (none of which work)

creating a new web part project with --skip-install, installing packages, changing the config and then npm i

creating a new web part project, installing packages, changing the config, deleting node_modules and npm i

adding all of this to an existing web part project

I'm stuck.

Ok.
So for anyone out there who has this problem as well, the fix is to tell tslint to use the updated typescript, otherwise it stays at the default of 2.2.2
In the gulpfile.js, just before build.initialize(gulp) add the line:
build.TypeScriptConfiguration.setTypescriptCompiler(require('typescript'));
this appears to update the linter
I'd really like to know why this isn't in the docs anywhere.

Closing this.


context in root is not respected

I've just rolled out something to the wrong cluster, no harm done luckily. But the context: foo setting in the root level was not respected, it took my currently configured context. Only the new helmDefaults: { kubeContext: foo } worked, so we may want to adapt the example in the readme.

Same here. I have this issue a couple of weeks already. My helmfile version: v0.36.0

same, but specifying kubeContext under helmDefaults works as intended

Same issue here.

I suppose, context directive should be deprecated now in favor of helmDefaults.kubeContext?


VLC Player not updating progress time or mark episode as seen

Steps to reproduce

Opening a episode using VLC as external player

Expected behavior
After watching the episode the episode progress is  updated or marked as seen.
Actual behavior
VLC  won't update progress or marked as seen after watching episode and thus trackers can't update along with it.
Crash logs
No response
Aniyomi version
<IP_ADDRESS>
Android version
Android 13
Device
CPH2467
Other details
No response
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] If this is an issue with an official extension, I should be opening an issue in the extensions repository.
[X] If this is an issue with an official manga extension and this issue can be replicated in the Tachiyomi app, that I should be opening an issue in Tachiyomi's extensions repository.
[X] I have gone through the FAQ and troubleshooting guide.
[X] I have updated the app to version <IP_ADDRESS>.
[X] I have updated all installed extensions.
[X] I will fill out all of the requested information in this form.

Same with me like in previous it works perfectly but in latest version it's not

same with me but i use mx player pro as external player
i also have to enable subtitle on each play or when i lock and unlock my phone
when i play the video stright in mx player pro the subtitle is enabled by default


[move-only] Emit an error if we /ever/ partially consume a noncopyable type.

The reason why I am doing this is that this was not part of the original
evolution proposal (it was called an extension) and after some discussion it was
realized that partial consumption would benefit from discussion on the forums.
rdar://111353459

I also needed to add a small optimization to eliminate some iterated copies that are inserted by SILGen since otherwise the diagnostic gets borked. It works by just walking def->uses and is very conservative by: 1. Only pattern matching a very exact sequence. 2. Making sure that all visited iterative copies are in the same block and do not have any side effects in the sequence of instructions.

@swift-ci test

@swift-ci test macOS platform

@swift-ci test macOS platform

@swift-ci test

@swift-ci test macOS platform


[web]: webapp unable to launch without internet access at least one time

Firefox latest on Win 11 latest.
Deploying webapp to nginx server (Ubuntu 22) and connecting directly via Ethernet with static IP addressing on both systems.  Both server and PC are air-gapped from the internet.
Open address of webapp (<IP_ADDRESS>) and the favicon.ico shows on the Firefox tab, but the webapp never loads.
Connect the calling PC to the internet via WiFi and reload the page and the webapp loads properly.
Close the WiFi connection and the webapp continues to function normally.
Reboot the calling PC and the webapp continues to function normally.
Delete cookie/data from dart.dev in Firefox and the webapp FAILS to load.
Repeat WiFi connection and the webapp functions normally again.

Browswer network trace indicates calls to www.gstatic.com for retrieving canvaskit.js and canvaskit.wasm modules as well as to fonts.gstatic.com.  The build/web has both canvaskit.js and canvaskit.wasm modules as part of the deployment.
A documented deployment method is suggested for a deployment that obviates the need for internet sourcing of these (or any such) items.

Hi @guitarpicva

Delete cookie/data from dart.dev in Firefox and the webapp FAILS to load.

This is strange because dart.dev is different from your web app. Is this a prerequisite to reproduce the issue? I'm quite confused about the pattern to reproduce this issue. Please try to observe to see if you can replicate it consistently and see if it has any pattern.
Also, please check if the issue occurs on a newly created Flutter project. And please provide the output of flutter doctor -v as well. Thanks!

You are correct, and I found that rather strange as well. I CANNOT reproduce the dart.dev cache symptom (in fact, that cache never shows back up), but first I tried deleting the flutter.dev cache and it had no effect, so then I deleted dart.dev cache and it then failed to load. The magic downloads get put "somewhere" that is not documented and so it's a bit difficult to trace.
The goal set here is to be able to deploy an air-gapped web application, so we have to have all assets in hand, obviously. I cannot find any documentation to lead one to such an answer, so if we go down this road, then we will have to manually download and deploy any required resources and hope we didn't miss any. Plus this means we will likely have to amend the javascript which I find dangerous. Not knowing where to put everything once gathered is another question.
My feedback was to prompt perhaps some documentation about the PWA efforts that may lead to more in-depth understanding of the deployment structure.
--
Mitch, AB4MW
Sent with Proton Mail secure email.
On Tuesday, April 16th, 2024 at 2:04 AM, huycozy @.***> wrote:

Hi @.***(https://github.com/guitarpicva)

Delete cookie/data from dart.dev in Firefox and the webapp FAILS to load.

This is strange because dart.dev is different from your web app. Is this a prerequisite to reproduce the issue? I'm quite confused about the pattern to reproduce this issue. Please try to observe to see if you can replicate it consistently and see if it has any pattern.
Also, please check if the issue occurs on a newly created Flutter project. And please provide the output of flutter doctor -v as well. Thanks!
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: @.***>

Thanks for the update but it's still not clear how your web is failed to load. It would be helpful if you could share the error/warning log. Please also provide the output of flutter doctor -v.
Based on what you described, please check https://github.com/flutter/flutter/issues/121743 and https://github.com/flutter/flutter/issues/60069 to see if the information there is helpful.

Interesting switch "--pwa-strategy=offline-first". I haven't found documentation for anything to do with pwa, but that gave me a clue to look at the help for flutter build web.
I will give this a go and see how it behaves.
Thank you so much for taking the time to pitch in!
Mitch
--
Mitch, AB4MW
Sent with Proton Mail secure email.
On Wednesday, April 17th, 2024 at 12:56 AM, huycozy @.***> wrote:

Thanks for the update but it's still not clear how your web is failed to load. It would be helpful if you could share the error/warning log. Please also provide the output of flutter doctor -v.
Based on what you described, please check #121743 and #60069 to see if the information there is helpful.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: @.***>


What range DatePicker can be used with the plugin?

Can you provide a suggestion on what DatePicker that supports range select can be used with the plugin?

We didn't meet that use case just yet, though keep us informed if you find something useful.

@wzup did you had a look at http://onefinestay.github.io/react-daterange-picker/ yet?

We're not planning on providing such high level widgets to this lib. You may want to create a custom SchemaField, maybe simply a custom widget, for handling these.


Scrolling recyclerView with multiple view types causing strange overlapping of views

Hi,
The scenario I have is a recycler view containing items with different view types, i.e. i audio, video, image files all in a single adapter, in order to show media files as in other gallery apps.
Now, coming at the issue:
Whenever there are huge number of files present inside the recycler view, and I scroll through the items very fast (top-to-down and vice versa), some of the video thumbnails(of the video files) get overlapped over the audio files placeholder. Again, this happens only when the number of files is large and when scrolled quickly.
Just an FYI:
The getItemViewType() is returning the type of item in order to set appropriate views(for audio, video ,image).
Can anyone confirm if they have experienced a similar issue in the past ?
Or, any idea why this might be happening ?

I'm having the same issue. Did you find any fix?

Hi,
Is there a way to solve this problem without removing All views and without doing setIsRecyclable set to false. Like a solution which doesn't decrease the performance of our recycler view.And Can you explain why this problem generally occurs @techievbv @mangini

@miquelcopet
The solution which you have suggested is just a hack.Not a solution.Is there a proper way which doesn't decrease the performance of recycler view.

I'm having the same issue. Anyone have a solution for this?

I'm having the same issue. Anyone have a solution for this?
Try this..
https://medium.com/@polson55/smooth-recyclerview-scrolling-in-android-57e7a9b71ca7


telegram-desktop: 4.16.7 -> 4.16.8

Diff: https://github.com/telegramdesktop/tdesktop/compare/v4.16.7...v4.16.8
Changelog: https://github.com/telegramdesktop/tdesktop/releases/tag/v4.16.8
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 304657 run on x86_64-linux 1

1 package built:

telegram-desktop


let VSCode format all the AST code so it doesn't barf diffs every change

It appears the auto-format-on-save option in vscode is reformatting the code every time a change is made. Rather than fight the setting, just auto format all the code and check it in as one diff so result in lots of diffs every time a change is made to a file that hasn't been formatted.

Fixed by https://github.com/JeroMiya/xamarin.flutter/pull/28


Histograms in Trees

I am able to see the code changes in the github diff. Check - https://github.com/scikit-hep/uproot/pull/78/files#diff-26c1418a30d1cd262d87e9dfe59ca762R128

I'll accept it when the tests are in and positive.


Pichi/faq page

Proposed Changes

Additional Info.
Any additional info goes here
Screenshots (optional)

Proposed Changes

Add a FAQ's page, link at the bottom of the main page

Additional Info.

There is still no information about FAQ's but the page is there and is ready to have content added

Any additional info goes here
Screenshots (optional)


PageTokens in Youtube Datasource

This is REALLY necessary! I hope this feature will come soon! Do you have it in your plans at least?

Igor, could be more precise? It's about pagination?

Yes! Pagination! So that we could finally load all videos from playlists!

This is how I would like this thing to work... I would like to make an app in App Studio for my favorite tv show by pulling out all the episodes from Youtube and sorting them into playlists by season... In that way I will have five playlists by around 150 videos each, but that I just cannot accomplish via App Studio till this date... There is that number limit in how much videos I can pull from Youtube playlist... You have recently boosted it up to 40, but that is not enough... Thank for that btw, it was my feature request! BUT NOW PLEASE ADD PAGE TOKENS FOR YOUTUBE, SO I CAN FINALLY START WORKING ON MY APP AGAIN! I think you should have been added this feature right at the beggining, but situation is what it is... To explain this more further... In order to show 150 videos today, I would need four separate playlists, but we can accomplish this with just one playlist quite easily if you implement these page tokens! It should look like this in reality: I have a playlist with like 200 videos, but App Studio should manage it in this way - it first loads 40 videos, and then when user scroll to the bottom of that list, app automatically loads the next 40 videos and then again and again! You repeat this CONTINUOUSLY until we load all those videos!  So I hope you can bring this idea into the reality in one of next updates! All App Studio users will be very grateful if you implement this, but I will be the most!
Sorry for long text! All the best to App Studio team! Keep up an amazing work! See you! Regards!

Thanks for your explanation. You have to realize that we have to get the common factor from all the data providers we have...
We are designing a solution that covers all our data providers.
We'll keep you updated.

@javitosanchez  Any progress on the issue? Will this come soon? Cannot wait anymore... ;)

@IgorGiga we have a preliminar version developed in dev branch. You can start playing with it!

Fantastic! Thanks!

Released in the current version

Thank you guys!!!


Revert "Updating the whole document so it is easier to consume"

Reverts Azure/azure-content#5999

@LuisCabrer
Reverting these changes. I'll send a file including the change you made here.


custom_hostname: add support for bundle_method

Adds support for using BundleMethod in custom hostname certificates.

Codecov Report

Merging #1298 (ff49320) into master (a5dc232) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

:exclamation: Current head ff49320 differs from pull request most recent head ca28650. Consider uploading reports for the commit ca28650 to get more accurate results

@@            Coverage Diff             @@
##           master    #1298      +/-   ##
==========================================
- Coverage   49.07%   49.07%   -0.01%
==========================================
  Files         134      134
  Lines       13091    13090       -1
==========================================
- Hits         6425     6424       -1
  Misses       5162     5162
  Partials     1504     1504

Impacted Files
Coverage Δ

custom_hostname.go
47.24% <ø> (ø)

devices_policy.go
49.47% <ø> (ø)

dns.go
45.05% <ø> (ø)

email_routing_destination.go
66.25% <0.00%> (-0.42%)
:arrow_down:

tunnel.go
41.39% <ø> (ø)


Submission of Abstract of Blog post

Can you undo the changes you made to the original template files?

Please let me know when this is ready to be merged!

I created a pull request with update conflict. Sorry for delay in answering.

Hi, on my fork it still shows Process completed with exit code 128 on deploy. Is it the same issue with new pull request as well? If so, can you tell me which files I might have changed.

https://iclr-blogposts.github.io/staging/blog/2023/controllable-music-generation-via-midi-ddsp/ It looks ok on my end - does this look like you intended?

Hi, yes. Thank you!


bugfix linux shell echo field value is too long and causes a line break

增加参数“P”，为了输出结果以长格式显示
What's changed?

Checklist

[ ]  I have read the Contributing Guide
[ ]  I have written the necessary doc or comment.
[ ]  I have added the necessary unit tests and all cases have passed.

todo ubuntu centos ... linux

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑🤝🧑👫🧑🏿🤝🧑🏻👩🏾🤝👨🏿👬🏿

all ubuntucentos ... linux


Fix no poll timeout

This PR fix the behaviour when uxr_read_udp_data_platform get a timeout == 0 and after setting SO_RCVTIMEO, recv() keeps waiting forever.

Build status:

Linux
Windows


build(paperclip): support multiple platforms

test(bdd/thin): fix racy thin prov test

Add retry waiting for condition to be met.

Signed-off-by: Tiago Castro<EMAIL_ADDRESS>

build(paperclip): support multiple platforms

Supports building paperclip from multiple plaforms.
Also updates old openapi update script to update paperclip.

Signed-off-by: Tiago Castro<EMAIL_ADDRESS>

bors merge

bors merge

bors cancel

bors merge


[IDEAs] Better Icons; Better Animations;

Ok so basically i've been using this app for a month now and i absolutely love it.
But one really annoying thing is to set the icon each time i create a new group. Since I'm also using it on my desktop to reduce the number of icons, i 've got an idea: if the user wnats to, the app can create an automatic icon that is the first 3 app's icons put on top of each other, or maybe/android iphone style (icons in a box).
Another thing i'd like to see is a more fluent animation of the group opening and closing.
here is an example i made by hand

Same idea, I'm using it to organize my desktop as well.

It works great. I'm hoping that there could be more emphasis on this type of usage.


Error when specifying specific version

I'm trying to update a CM4 to kernel version 6.1.41 for testing purposes.
I have completed this in the past (maybe 2 months ago) but when I try it now, I get the following error:-
pi@raspberrypi:~ $ sudo rpi-update 5292d2d50791843252458366d686d206271f070f
 *** Raspberry Pi firmware updater by Hexxeh, enhanced by AndrewS and Dom
 *** Performing self-update
 *** Relaunching after update
 *** Raspberry Pi firmware updater by Hexxeh, enhanced by AndrewS and Dom
FW_REV:
WANT_32BIT:1 WANT_64BIT:1 WANT_PI4:1 WANT_PI5:0
 *** Downloading specific artifact revision (this will take a few minutes)
curl  -L https://builds.raspberrypi.com/github/linux/5292d2d50791843252458366d686d206271f070f/bcmrpi | zcat | tar xf - -C //root/.rpi-firmware --strip-components=2
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:--  0:00:03 --:--:--     0

gzip: stdin: unexpected end of file
tar: This does not look like a tar archive
tar: Exiting with failure status due to previous errors
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:--  0:00:03 --:--:--     0
Invalid artifact specified. Response: 404.

Can anyone shed light on what the issue is ?
Cheers

Aha, silly me!!  All working now ...
Thank you :)


openssh: use bin instead of sbin folder

Things done:

[ ] Tested using sandboxing (nix-build --option build-use-chroot true or nix.useChroot on NixOS)
[x] Built on platform(s): Nix on Arch Linux
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

The nox-review command had this output, so I don't know if I used it properly:
No uncommit changes. Did you mean to use the "--against" option?

References #11939.

Works for me


Add a way to customize the session summarization prompt template via settings

User story:
As a ZEP user, I would like to be able to customize the prompt text and input variables used to process the memory of a session
Initial discussion:
I would like to implement this feature into zep. I do not have much knowledge of golang but would like to give this a try. Couple questions:

Is the config/config.go file the place I should place this config setting?
Any suggestions you have in mind about how to approach this?

Contributed in #208 and merged as #211


Temporary Directory

I'm running to a problem where my /tmp folder is running out of space during a pipeline run. I was wondering if there was an option to choose where temporary files are stored for epic?

Thanks for reporting this. I had no idea this could happen. I do not use the tmp folder myself, but I guess unix sort does. Do you have a log of all the output messages when you got the error? This would help me understand where it happened.

I think this is less of a specific EPIC problem, and more of a general case problem where there are too many programs that store temporary files in the /tmp directory (macs2, epic, deeptools, etc) that don't allow for a change in directory for storing temp files. With enough processes running at one time, the /tmp file gets filled over.

The only thing that uses a tmpdir in my software is the unix sort command. If you want to change the tmpdir when running epic you can do TMPDIR="your/temp/folder" && epic -h. Modern versions of sort should respond to the $TMPDIR variable.


manually configure BreadcrumbNode gives exception in the service

Hello,
I dont seem to get the manually node configuration to work. The annotation method works except for the action taking a parameter which is lost on clicking the breadcrumb.
The manual node does not have a DefaultNode as parent. I upgraded to 1.4 but without succes.
I tried:
//[Breadcrumb(“ViewData.Title”, CacheTitle = true, FromAction = “Interaction.Index”)]
public IActionResult Edit(Guid id)
{
var parentNode = new BreadcrumbNode(“InteractionIndex”, “Index”, “Interaction”, id, null);
var editInteractionNode = new BreadcrumbNode(“ViewData.Title”, “Edit”, “Interaction”, id, parentNode);
The id is the routevalue i need to pass.
I get an exception in services saying “Sequence contains no matching element
i have this one in HomeController
[DefaultBreadcrumb(“Home”, CacheTitle = true)]
public IActionResult Index()
{
return View();
}
The Edit action in Interaction controller is in Home > Admin > Interaction > Edit
We use a LocalizedTaghelper derived from the original Taghelper, basically a copy paste of some functions and adding localization on the strings. This worked until i tried configuring a manual node.
I also noted that some of the examples on this didnt match the number and order of prameters in the src. I followed source and could compile, running gives the exception.
Kind regards,
Martien

Hello,
I will try this and get back to you asap.

If i also add the annotation i dont get an exception in the service. Following below code it will show the "HocusPocus" title but when i click one deeper from the Edit view the "hocusPocus" is replaced with literally "ViewData.Title" (no substitution as with pure annotations). Clicking the breadcrumb results as before in an empty id.
As the BreadcrumbManager generates it's hierarchy by the attributes list i assume something here is wrong with the attributes. With annotation the attributes are generated with reflection but i havent seen anything in the code so far that generates the attributes for the manual nodes?
[Breadcrumb("ViewData.Title", CacheTitle = true, FromAction = "Interaction.Index")]
public IActionResult Edit(Guid id)
{
        //var attr = new BreadcrumbAttribute("Interaction.Index");
        var parentNode = new BreadcrumbNode("Interaction", "Index", "Interaction", id, null);
         var editInteractionNode = new BreadcrumbNode("HocusPocus", "Edit", "Interaction", id, parentNode);

        ViewData["BreadcrumbNode"] = editInteractionNode;

When you use manual modes, they completly replace the attributes for that action (except for the default node).
I still didn't find the time to test your code but I think I will later today, sorry!


Fix (Instead of deleting the service, attempt to reconfigure)

I have tested this code, it fixes the issue reffered in #23

thank you ;)


Q: Why Chat API does not include message in the response body?

Why Chat API does not include message in the response body?
Generate API does include the response, is there any reason to omit it here?

Hi @AugustDev are you looking for the message in the final response body? Would you be able to give me an example? This is a new endpoint so I appreciate the feedback.

the structure for the endpoint /api/chat is not the same as /api/generate it's not response but message
/api/chat
{"model":"mistral","created_at":"2023-12-12T20:29:02.010018961Z","message":{"role":"assistant","content":"\n"},"done":false}
/api/generate
{"model":"llama2","created_at":"2023-12-12T20:32:21.667986258Z","response":"The","done":false}
It's not a bug
Best.

Thanks, I understand the feedback now

Hi @AugustDev, the chat api returns a message since it's an object (vs the response text), this is by design. Let me know if you encounter any more issues


feat(editor/#1444): Part 1 - Initial benchmark for word wrap

Splitting out of some of the remaining work in #1969

I caught this update and wondered if this was helpful? https://xi-editor.io/docs/rope_science_05.html

Thanks @Happy-Dude ! Definitely helpful - Raph's blog is awesome 👍


[BEAM-13239] pass through io.EOF when decoding row

Check for io.EOF, and pass through when decoding row.
Fix extra * in error printout for non-pointer structs.
Did a cursory check, and none of the other parts for schema decoding do additional wrapping.

Discovered via running the grades example.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

R: @jrmccluskey @riteshghorse @youngoli


Memory leak in NetworkAvailabliltyCheck (ConnectivityManager stores reference to activity)

I am using leak canary (https://github.com/square/leakcanary) to find leaks in my application.
Activities that use MapView have next leak:

The issue is because
NetworkAvailabliltyCheck used activity context to create ConnectivityManager but it supposed to use application context instead.
as you can see there is next call sequence
protected MapView(final Context context,
					  final ResourceProxy resourceProxy, MapTileProviderBase tileProvider,
					  final Handler tileRequestCompleteHandler, final AttributeSet attrs) {
		super(context, attrs);
		mResourceProxy = resourceProxy;
		this.mController = new MapController(this);
		this.mScroller = new Scroller(context);

		if (tileProvider == null) {
			final ITileSource tileSource = getTileSourceFromAttributes(attrs);
			tileProvider = isInEditMode()
					? new MapTileProviderArray(tileSource, null, new MapTileModuleProviderBase[0])
					: new MapTileProviderBasic(context, tileSource);
		}
    ....
}

public MapTileProviderBasic(final Context pContext, final ITileSource pTileSource) {
		this(new SimpleRegisterReceiver(pContext), new NetworkAvailabliltyCheck(pContext),
				pTileSource, pContext);
}

public NetworkAvailabliltyCheck(final Context aContext) {
		mConnectionManager = (ConnectivityManager) aContext
				.getSystemService(Context.CONNECTIVITY_SERVICE);
          isX86= "Android-x86".equalsIgnoreCase(Build.BRAND);
}

I think we should create MapTileProviderBasic with application context to prevent the leak.
so we should create it in next way:
 new MapTileProviderBasic(context.getApplicationContext(), tileSource);

I can make pull request to fix the issue.

yes please! never heard of that project but i love it already!

Btw, as a workaround in client app I added
getSystemService(Context.CONNECTIVITY_SERVICE); line of code in the application class in onCreate() method.
It creates singleton instance of ConnectivityManager using application context, so when NetworkAvailabliltyCheck is initialized it uses ConnectivityManager instance that was created in application with correct context.

since this was merged, i'm going to close. thanks for the contribution


Update cert-download

Basically the old cert-download uses a deprecated function in fs.exists which fails on newer node versions.
This dep updates that so it's compatible with current node versions

@kokarn the CI checks seems to be failing, any ideas on how to solve?

It's tested on super-old versions. My suggestion would be to bump to more realistic versions and do a major version bump of the package


Scan API with OWASP

Purpose
Trial of using the ZAP OWASP Scanner against the API
Findings

The scanner does not have an action out of the box for github
The scanner when configured seems to take too long to run, and maybe actually trying to execute the API, which could be problematic

Conclusion
Do not run the ZAP OWASP Scanner on the API

Scanner does not work on API,