Standardize CI workflows

This requires tweaking the secrets available in this repo.

I've reverted this back to allow for auto-deploys at every iteration. Now it also uses Github/GCP WIF so we don't even need any secrets. I just tried at this run


CH582M Wont enter bootloader download mode anymore (exam BLE/HID_Keyboard)

Hi, I tried the Exam/BLE/HID_Keyboard program and downloaded to my CH582M. I changed the parameter of DL Config Pin from PB22 to PB11 and now I can no longer enter bootloader download mode using BOOT button + connecting USB-C and WCHISP tool wont find the device.
The program will start and typing "abcdefg...xyzabc..." once connected to bluetooth HID_Keyboard and reset button only reset the program typing back to "abc...".
Is there anyway for me to enter bootloader/download mode again? Button combination or shorting certain pins?

If I am right, you should connect pin PB11 to ground and connect your device to usb

I have tried it, shorting GND to Pin 11 but still it will continue to boot into the example app instead of bootloader. Can I enter bootloader via UART TTL COM connection instead?

Ref: https://github.com/ch32-rs/wchisp/blob/4b4787243ef9bc87cbbb0d95c7482b4f7c9838f1/devices/0x16-CH58x.yaml#L61-L66

Ref: https://github.com/ch32-rs/wchisp/blob/4b4787243ef9bc87cbbb0d95c7482b4f7c9838f1/devices/0x16-CH58x.yaml#L61-L66

The setting seems it can be toggled on/off but I cant get wchisp to even detect the device. The device will boot into the app directly and start typing "abcdefghijk..."

Solved:
Got myself serial usb rx-tx and used No-Key serial port w/ DL key back to PB22 + 115200 baud.
Played around with DL ready  on the tool to reset, connect PA9 PA8 first, then GND finally 3V3.
Once reset, connect via serial on device like before it will say not recognized, but just keep pressing Download until it starts downloading.
Guide here:
https://www.cnblogs.com/gscw/p/16034836.html


Fix false positive in ComparingUnrelatedTypes

Fixes #235

I couldn't see a way to add the additional test conditionally based on 2.13 (it fails to compile without 2.13) and also the typeOf needs the SizeCompareOps class. Let me know if there is a better way to fix this.

Hi @bjchambers

I couldn't see a way to add the additional test conditionally based on 2.13 (it fails to compile without 2.13) and also the typeOf needs the SizeCompareOps class. Let me know if there is a better way to fix this.

I created a PR with a different approach, instead of special casing the inspection for SizeCompareOps only, it checks whether the LHS type has a specialized == or != for the type on RHS.

Ah, that makes sense. It seems like an even better solution! I'll close this PR in favor of that fix.


Run the "runtime-trace-tests" as part of "jake test"

We have a test suite for testing py2ts and ts2py under pxt/tests/runtime-trace-tests. I've been using this heavily when adding or fixing Python.
Unfortunately this test suite doesn't yet run by default by our build agent. This is because it depends on "tsc" and "python3" being present on the host, and are Travis agent isn't yet set up to have these. Hopefully this is a small fix.
Enabling this by default would prevent (some) regressions.

Done.


How I can convert all pages to panels

Question
If I want to show many page survey like one page and I want to show pages like a panels on new one page how I can do it?
Can not find any opportunities on documentation for page (convert to panel) or for survey.
Tested page URL:
https://plnkr.co/edit/n9AFLy?p=preview
Specify your

browser: Chrome
surveyjs version: surveyjs 1.0.52

You can use this setting - https://surveyjs.io/Documentation/Library/?id=surveymodel#isSinglePage

@tsv2013 The question is how I can get all pages, and show them like panel and restyle them?

Here is the updated plunk - https://plnkr.co/edit/HTxlxnzfdzVnpiT1Mp3o?p=preview
Does it fit your needs?

@NafanyaVictorovna it would be great if you could share your decision here for other people

@dmitrykurmanov no problem, will add plunker later.
What about my question?

@NafanyaVictorovna sorry I've missed it. We have expand and collapse methods for programmatically use. https://surveyjs.io/Documentation/Library/?id=panelmodel#expand and https://surveyjs.io/Documentation/Library/?id=panelmodel#collapse.

@dmitrykurmanov Yea, thanks, I know, but how I can prevent to collapse panel, make it state like 'default' - always expanded?

@NafanyaVictorovna also please check this properties:
https://surveyjs.io/Documentation/Library/?id=panelmodel#state
https://surveyjs.io/Documentation/Library/?id=questionpaneldynamicmodel#panelsState


OCaml 4.06.0 support

When trying to opam install fstar I get the following error message:
# Exception: Failure "Unsupported version of OCaml:4.06.0".

Here is the full output:
[ERROR] The compilation of fstar failed at "make PREFIX=/Users/anton/.opam/4.06.0 -C src/ocaml-output".
Processing  1/1: [fstar: rm]
#=== ERROR while installing fstar.<IP_ADDRESS> =====================================#
# opam-version 1.2.2
# os           darwin
# command      make PREFIX=/Users/anton/.opam/4.06.0 -C src/ocaml-output
# path         /Users/anton/.opam/4.06.0/build/fstar.<IP_ADDRESS>
# compiler     4.06.0
# exit-code    2
# env-file     /Users/anton/.opam/4.06.0/build/fstar.<IP_ADDRESS>/fstar-44791-e7966f.env
# stdout-file  /Users/anton/.opam/4.06.0/build/fstar.<IP_ADDRESS>/fstar-44791-e7966f.out
# stderr-file  /Users/anton/.opam/4.06.0/build/fstar.<IP_ADDRESS>/fstar-44791-e7966f.err
### stdout ###
# cp "../extraction/ml/FStar_Extraction_ML_PrintML_.ml" ../extraction/ml/FStar_Extraction_ML_PrintML.ml
### stderr ###
# Exception: Failure "Unsupported version of OCaml:4.06.0".
# cp: cannot stat '../extraction/ml/FStar_Extraction_ML_PrintML_.ml': No such file or directory
# make: *** [../extraction/ml/FStar_Extraction_ML_PrintML.ml] Error 1

It works! I tested it with OCaml 4.06.1. Thanks.


Add note on using image as non-flutter user

Due to recent changes in git, it is no longer possible to access flutter as non-flutter user.
So I think it would be good to add note in README on that.
You're actually able to use flutter, but any command that relies on SDK version is going to be broken

Thanks you, very good point


Tilde compression for default prompt

Resolves #185

I think tilde compression should work for all paths prefixed with $HOME.

@pauldub good point! Fixed

@andrewchambers might this be some weird heisen-bug in job control?


Multinomial batch shape

Batch shape is not set properly in Multinomial. This might affect to others with complex
parameters or with event shep
x = inf.Multinomial(total_count = 2, logits = [0., 0., 0.])

x.event_shape   # 3
x.batch_shape   # 3     (should be 1)
x.sample_shape  # []

Another problem in multivariate normal:

x = inf.MultivariateNormalDiag(loc=[1., -1],
                               scale_diag=[1, 2.],
                               batch_shape=[3,2],
                               sample_shape=100)

x.event_shape   #  2  ok
x.batch_shape   #  3 but should should be 3,2
x.sample_shape  #  100   ok

The problem is related with the input sanitize function. It suposes that every argument, but name and sample_shape, must have the same dimension. Therefore, for distributions like multinomial, some arguments are broadcasted incorrectly.
We have decided to remove the functionallity in the  input sanitize function mostly, and rely on argument cleaning from edward2. We will use such function only to transform Random Variables from edward2 and inferpy to tensors (using tf.convert_to_tensor) when are used as parameters inside of a list structure. In the following this decision is explained:
For some distributions, like Categorical, it is common to use as arguments other distributions for the probs argument, i.e.: [distribution_a, 1 - distribution_a]. Therefore, we still want to have this functionality in Inferpy, but as discussed before the general behaviour of broadcasting every argument is wrong.

Moreover, as a consequence, the possibility of using batch_shape as argument must be removed, as broadcast is not applied for any argument anymore.


NaiveGrounder Refactoring - Modularize bindNextAtomInRule

The motivation of this PR is to be able to re-use some grounder code in PR #207 while generally making reading code in NaiveGrounder a bit more pleasant. Specifically, the basic workflow of NaiveGrounder#bindNextAtomInRule is exactly the same process needed for rule evaluation in PR207's StratifiedEvaluation. In order to enable sharing of this code (and thereby get rid of the very hacky "copy-paste" version currently in use in PR207), a large part of the logic from NaiveGrounder#bindNextAtomInRule has been broken out into RuleInstantiator#instantiateLiteral.
Reworked workflow for NaiveGrounder#bindNextAtomInRule
The refactored version of bindNextAtomInRule delegates the task of finding substitutions for its current literal to RuleInstantiator#instantiateLiteral - instantiateLiteral takes a literal and returns a LiteralInstantiationResult.
Based on the type property of the LiteralInstantiationResult, bindNextAtomInRule decides how to proceed:

LiteralInstantiationResult.Type.CONTINUE: recursively call bindNextAtomInRule to bind the next literal, possibly decreasing the remaining tolerance defined by a permissive grounding heuristic.
LiteralInstantiationResult.Type.PUSH_BACK: push the current literal to the end of the grounding order and proceed with the next literal.
LiteralInstantiationResult.Type.STOP_BINDING: Stops binding for the current literal, returning an empty BindingResult.

Literal Instantiation in RuleInstantiator#instantiateLiteral
instantiateLiteral takes a Literal and a Substitution and returns a LiteralInstantiationResult. The result wraps

an indicator on how to proceed with grounding (type enum, one of CONTINUE, PUSH_BACK, STOP_BINDING)
a list of ImmutablePairs over Substitutions and AssignmentStatuses, where the substitutions are all possible ground substitutions for the given literal, and the AssignmentStatus (one of TRUE, FALSE, UNASSIGNED) attached to each substitution represents the truth value for the last bound atom. In case of FALSE, binding must be stopped, UNASSIGNED will cause bindNextAtomInRule to decrease the remaining tolerance in the presence of a permissive heuristic (or abort binding for strict heuristics).

Substitutions are obtained differently based on the type of literal:

For FixedInterpretationLiterals, substitutions are obtained from FixedInterpretationLiteral#getSatisfyingSubstitutions.
For EnumerationLiterals, the start substitution is extended with an enumeration index by calling EnumerationLiteral#addEnumerationIndexToSubstitution.
Every other type of literal is expected to work like a BasicLiteral and instantiated using an InstantiationStrategy.

Instantiation Strategies
The interface InstantiationStrategydefines two methods:

AssignmentStatus getTruthForGroundLiteral(Literal groundLiteral)
List<ImmutablePair<Substitution, AssignmentStatus>> getAcceptedSubstitutions(Literal lit, Substitution partialSubstitution)

An InstantiationStrategy encapsulates procedures and logic for checking whether a literal should be considered "true" (i.e. if grounding should continue for a given ground literal) and finding valid ground substitutions for partially ground literals.
By having the possibility to switch out instantiation strategies, we are able to modify grounder behavior without touching bindNextAtomInRule. Furthermore, any code that needs to find ground instances of literals - specifically, StratifiedEvaluation in PR #207 - can use a RuleInstantiator in combination with an appropriate InstantiationStrategy.
The DefaultLazyGroundingInstantiationStrategy
DefaultLazyGroundingInstantiationStrategy is the InstantiationStrategy used by NaiveGrounders RuleInstantiator.
It has references to the following  objects used by the grounder:

The grounder WorkingMemory (which is used to find ground instances based on partially ground atoms)
The atomStore of the grounder and the currentAssignment which is passed to bindNextAtomInRule:  The assignment is used to determine whether a ground atom is TRUE (either ThriceTruth.TRUE or ThriceTruth.MBT), FALSE (ThriceTruth.FALSE) or UNASSIGNED (not present in assignment)
The set of atoms removeAfterObtainingNewNoGoods from the grounder. Whenever DefaultLazyGroundingInstantiationStrategy encounters an atom that is FALSE or UNASSIGNED, that atom is added to this set (called staleWorkingMemoryEntries in the instantiation strategy) so that the grounder can afterwards delete the atoms in question from the working memory

DefaultLazyGroundingInstantiationStrategy considers a ground literal lit to be TRUE iff

lit is a negative literal
lit is positive and a fact
lit is positive, and the current assignment is not set (as is the case while NaiveGrounder is in bootstrap)
lit is positive and assigned TRUEor MBT in the current assignment

A ground literal lit is considered FALSE if and only if it is assigned FALSE in the current assignment.
If a literal is not assigned a ThriceTruth in the current assignment, that literal is considered to be UNASSIGNED.

Please, please set your formatter to wrap lines at 120 characters and not 80 and then re-format all your javadoc. Your detailed javadoc comments are excellent, but due to the line breaking they leave me with sometimes just 4 actual lines of code on screen.

Again, I am happy to have this refactoring. There are some improvements and suggestions that should be done before merging, though.

Thanks for the very detailed review! All comments should be addressed now.


[fix][test] testSingleTopicConsumerBatchShortName

Fixes #19089
Modifications
Every manageredLeger has its own thread pool, so there is no ordering guarantee between different topics.
Verifying this change

[x] Make sure that the change passes the CI checks.

This change is a trivial rework / code cleanup without any test coverage.
Documentation

[ ] doc
[ ] doc-required
[x] doc-not-needed
[ ] doc-complete

Matching PR in forked repository
PR in forked repository: https://github.com/labuladong/pulsar/pull/18

/pulsarbot rerun-failure-checks

/pulsarbot rerun-failure-checks


Not able to use jhipster boilerplate.

While using jhipster as boilerplate it is not getting installed.
I have used this command to install that boilerplate
ignite new ignite_with_jhipster -b jhipster
and it seems that the boilerplate is selected

but, when it actually trying to install the same dependancy  it skips and uses ignite-ir-boilerplate-2016
as shown in screen shot, ignite_with_jhipster/node_modules/ignite-jhipster/plugin.js does not exist.  skipping.

@ckalpit Hey I'm the author of the JHipster boilerplate.  When I generate an app I see everything as expected, the home screen's logo/theme is different so I can tell it worked.
My boilerplate adds ignite-ir-boilerplate-2016 to get access to the screen, redux, saga, and other generators so that is what you are seeing in the logs.  The message about plugin.js is just a warning.

But there its written that skipping thats why I have reported this.

Yes, it seems that it is different boilerplate.
By the way, since your boilerplate is extending ignite-ir-boilerplate-2016 your boiler plate also throws same error as I have reported here https://github.com/infinitered/ignite/issues/1001
can you look into it?

The fix will be shipped today.

https://github.com/infinitered/ignite/pull/1005

fix for existing stuff, but this is fixed for all future stuff.


Reconcile RoleBinding and ClusterRoleBinding resources

What this PR does / why we need it:
Reconcile RoleBinding and ClusterRoleBinding on Subjects and RoleRefs attributes.
Also includes unit tests for RBAC's reconciliation.
Release note:

None

/cc @ashleyschuett @kbidarkar

/test all

/retest

/test pull-kubevirt-unit-test

/test pull-kubevirt-e2e-k8s-1.19-sig-storage

/hold
would like confirmation before merge.

seems okay.. can you confirm that you have tested on a running cluster and have made changes to the different types and that there is no hot looping?

Yes, I confirm I've tested it on a running local cluster.
I've changed values of different RoleBindings / ClusterRoleBindings and verified that are being synced back to the original value. I've also verified that the operator logs don't include more than one update for each one that I made.
Thanks @ashleyschuett for all your feedback and review!

/test pull-kubevirt-e2e-k8s-1.20-sig-compute

/unhold
/lgtm

/test pull-kubevirt-e2e-k8s-1.19-sig-storage

/lgtm

Side note: I still don't get it that such a fundamental thing like comparison does not have a standard implementation.... Or am I missing something?

@dhiller The thing is, IIUC, that in golang the only two ways to compare between 2 slices is either by performing reflect.DeepEqual, which is expensive in terms of performance, or implementing it by hand (compare length, each element, etc').
Note: IIUC, you can compare two arrays, meaning slices with a fixed length ([2]string{"a", "b"}), but this is not the case for us. See this for more info: https://yourbasic.org/golang/compare-slices/.
In one of my previous reconciliation PRs I had a comment that maybe it'd be better to have a private function that compares slices then use it everywhere to reduce this overhead. This might be a bit of an overkill. WDYT?

Side note: I still don't get it that such a fundamental thing like comparison does not have a standard implementation.... Or am I missing something?

@dhiller The thing is, IIUC, that in golang the only two ways to compare between 2 slices is either by performing reflect.DeepEqual, which is expensive in terms of performance, or implementing it by hand (compare length, each element, etc').
Note: IIUC, you can compare two arrays, meaning slices with a fixed length (e.g. [2]string{"a", "b"}), but this is not the case for us. See this for more info: https://yourbasic.org/golang/compare-slices/.
In one of my previous reconciliation PRs I had a comment that maybe it'd be better to have a private function that compares slices then use it everywhere to reduce this overhead. This might be a bit of an overkill. WDYT?

@iholder-redhat to be clear, this was not targeted at you, as it clearly is the recommendation to do it like you did. I just find it annoying that everyone has to reinvent the wheel and produce duplicate code. But there must be a reason for this, even though I am missing it.  ;)

Side note: I still don't get it that such a fundamental thing like comparison does not have a standard implementation.... Or am I missing something?

@dhiller The thing is, IIUC, that in golang the only two ways to compare between 2 slices is either by performing reflect.DeepEqual, which is expensive in terms of performance, or implementing it by hand (compare length, each element, etc').
Note: IIUC, you can compare two arrays, meaning slices with a fixed length (e.g. [2]string{"a", "b"}), but this is not the case for us. See this for more info: https://yourbasic.org/golang/compare-slices/.
In one of my previous reconciliation PRs I had a comment that maybe it'd be better to have a private function that compares slices then use it everywhere to reduce this overhead. This might be a bit of an overkill. WDYT?

@iholder-redhat to be clear, this was not targeted at you, as it clearly is the recommendation to do it like you did. I just find it annoying that everyone has to reinvent the wheel and produce duplicate code. But there must be a reason for this, even though I am missing it. </nagging> ;)

Sure, I totally see your point, this is weird that there is no acceptable solution for this.. Maybe it's just because golang is pretty new? (still waiting for templates... ;) ).
In any case, maybe it's better to have a comparison_util.go file somewhere and then we can at least implement it once for all.
And this is not nagging, thanks for raising this discussion :)

/unhold
I think that my comments are nits, and that they should not block this to get merged.


Fix multiple issues from latest update

GitHub Issue (if applicable): #1903 #1902 #1901 #1900 #1897 #1896 #1895
Explanation of Bugfix/Feature/Modification:
YNAB made a few adjustments to the budget page dom causing many features to have weird styling. This should fix all of them.

Is there any information about when the new update (2.23.1) will be available to the public?

@kev88au It's in a "Pending Review" state with the Google Chrome team right now. There were quite a few delays with the last release due to COVID so I expect that'll be the case again.

@kev88au It's in a "Pending Review" state with the Google Chrome team right now. There were quite a few delays with the last release due to COVID, so I expect that'll be the case again.

Thanks, Josh. I understand.
Although it looks like 2.23.1 is available on the Firefox store already, so if you're daily YNABer, and pulling your hair out going back to basic (native) functionality, then it might be worth temporarily using Firefox as a workaround.


SWS-131 change homepage (= base url) to /

This is to enable client-side routing. Else HTML contains links such as "/services/static/js/main.f06a050d.js" instead of "/static/js/main.f06a050d.js" when hitting url "http://sws.../services"

When I deploy this together with https://github.com/swift-sunshine/swscore/pull/64, then the start page does not show at all.

LGTM
Just one question, this has no effect when using npm start ? isn't it ?

@lucasponce I tried with npm start as well and it was working. I hope I'm not missing any use case. Don't know why "." was set in a first place.

Okis, just to confirm :-). Merging.


Feat/introduce cicd

Introduce CICD to CNSI
Implemented 3 GitHub actions workflows:

UNIT_TEST is triggered on pull_request
CodeQL is triggered manually for now
DEPLOY_TO_KIND is to deploy CNSI to a KIND triggered manually

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@4d71cfe). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #13   +/-   ##
=======================================
  Coverage        ?   18.98%
=======================================
  Files           ?        6
  Lines           ?      711
  Branches        ?        0
=======================================
  Hits            ?      135
  Misses          ?      566
  Partials        ?       10

Flag
Coverage Δ

unittests
18.98% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


⚠ T:Riza Roblox Proxy has degraded performance

In 0f9328a, T:Riza Roblox Proxy (https://rprxy.triza.dev) experienced degraded performance:

HTTP code: 200
Response time: 1549 ms

Resolved: T:Riza Roblox Proxy performance has improved in 561ca9c.


mu: 1.8.0 -> 1.8.1

https://github.com/djcb/mu/releases/tag/v1.8.1
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Currently using this in my NixOS config. Still works as expected.

Result of nixpkgs-review pr 179166 run on x86_64-linux 1

2 packages built:

lbdb
mu


Try metab multi-task with just GPP/ER

@amcarter suggested trying the metabolism multi-task with just DO and GPP and ER.

Solving for all:

Solving for DO, GPP, ER (not K, z, or T)

Comparing validation RMSEs


Modules not working

Hi all,
I am using google cloud computer VM with ubuntu 18.04 and Tesla T4 GPU. I successfully build the apollo 5.0 with lgsvl, but the modules seem not working for me.
.
I could successfully use nvidia-smi command in the docker, shown as:

For the cyber_monitor:

For the perception.INFO shows as:

What should I do with error?
Thanks.

how did you install nvidia driver within the docker environment??
Please Help!

@wangyixu14 Hello, how did you combine the LGSVL and Apollo 5.0 together in Ubuntu 18.04? Did you install LGSVL from source or from the binary one, I download the binary LGSVL and cann't execute it in my Ubuntu 18.04.
And I also wonder must I install the nvidia-driver in docker for run Apollo 5.0 in my local machine?

@rongguodong any comments from your side?

What is the error here? Perception module cannot be started? If you click "Perception" in Dreamview and it automatically goes back to grey, you can try to launch it manually using cyber_launch. It should show more error message in the console.

Closed due to inactivity. If the problem persists, pls feel free to reopen it or create a new one and refer to it.


cosine, sine and exp functions

afp versions of these functions evaluated at 0.0 goes into an infinite loop.
numeric::PI needs precision and scale arguments.

Hi Sisirajaya,
Thanks for the issues. Just commited the fixes on github/Edwig/bcd
Best regards,
Edwig Huisman
Van: sisirajaya<EMAIL_ADDRESS>Verzonden: maandag 2 maart 2020 18:48
Aan: edwig/BCD<EMAIL_ADDRESS>CC: Subscribed<EMAIL_ADDRESS>Onderwerp: [edwig/BCD] cosine, sine and exp functions (#1)
These functions evaluated at 0.0 goes into an infinite loop.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/edwig/BCD/issues/1?email_source=notifications&email_token=ABFDS37EN2P3EICCWOASH2TRFPWOVA5CNFSM4K7ZJ6U2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IRYWFCQ , or unsubscribe https://github.com/notifications/unsubscribe-auth/ABFDS36HESKOZ7625EE7OB3RFPWOVANCNFSM4K7ZJ6UQ .  https://github.com/notifications/beacon/ABFDS32NNR5DXMT7R5URXWLRFPWOVA5CNFSM4K7ZJ6U2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IRYWFCQ.gif


Enhance SymbolInformation with optional separator:string

When trying to construct a tree from a list of SymbolInformation objects, we can use the containerName property.
Let's consider the following example :
export namespace bar {
    export namespace bar {
        export function test() {
            return true;
        }
    }
}

In order to tell that test's container is bar.bar the container name should be provided qualified. But to find the container element I would also need to know the qualified name of that element. I could compute it form the name and the containerName if I knew the separator. But I don't.
Either having an optional separator, or the explicit qualified name would solve it.
Many languages use a single separator, so we could configure it in capabilities. But some have different, so we would need the separator on the individual SymbolInformationitem.

As commented in other issue we should not use the textDocument/documentSymbol to reconstruct the hierarchy. I clarified the specification around this a while ago. If we need a hierarchy we should work on a new request that implements this proper. I will close the issue in favour of having a separate request.


Feature request: Autocorrect

Deep Learning Simplified Repository (Proposing new issue)
:red_circle: Project Title : Autocorrect using DL model
:red_circle: Aim : To make a model that uses text as input and fixes any spelling or grammatical errors.
:red_circle: Dataset : http://www.manythings.org/anki/fra-eng.zip
:red_circle: Approach : An LSTM trained on English sentence pairs and tested on different data after adding noise.

📍 Follow the Guidelines to Contribute in the Project :

You need to create a separate folder named as the Project Title.
Inside that folder, there will be four main components.

Images - To store the required images.
Dataset - To store the dataset or, information/source about the dataset.
Model - To store the machine learning model you've created using the dataset.
requirements.txt - This file will contain the required packages/libraries to run the project in other machines.

Inside the Model folder, the README.md file must be filled up properly, with proper visualizations and conclusions.

:red_circle::yellow_circle: Points to Note :

The issues will be assigned on a first come first serve basis, 1 Issue == 1 PR.
"Issue Title" and "PR Title should be the same. Include issue number along with it.
Follow Contributing Guidelines & Code of Conduct before start Contributing.

:white_check_mark: To be Mentioned while taking the issue :

Full name : Vishisht Mishra
GitHub Profile Link : https://github.com/Vishisht16
Email ID<EMAIL_ADDRESS>Participant ID (if applicable):
Approach for this Project : LSTM
What is your participant role? GSSoC Extd - Contributor

Happy Contributing 🚀
All the best. Enjoy your open source journey ahead. 😎

Apart from LSTM is there any other model(s) you can implement here for this same problem statement?
@Vishisht16

That seems to be a good approach. What do you want me to do?
@Vishisht16

That seems to be a good approach. What do you want me to do? @Vishisht16

Here in this repository we used to implement at least 3 models for each problem statement and find out the best fitted one based on the accuracy scores.
Benefits for implementing different models:

Majority of the contributors are new to this open source and deep learning field, implementing multiple models will help contributors to explore more about the topic.
Students can also explore how different models work for a single dataset.
Students can help themselves out, why some model is best fitted with a particular dataset and others are not.
Multiple models will also justify the "Best Fitted" term based on the comparison of the accuracy scores.


Need help with render_bundle after changing directory structure

We have a legacy Django-webpack app using Django webpack loader. The app code moved into a /app directory and the render_bundle stopped working. The error message is
  File "/usr/local/lib/python3.9/site-packages/webpack_loader/templatetags/webpack_loader.py", line 22, in render_bundle
    tags = utils.get_as_tags(
  File "/usr/local/lib/python3.9/site-packages/webpack_loader/utils.py", line 71, in get_as_tags
    bundle = _get_bundle(loader, bundle_name, extension)
  File "/usr/local/lib/python3.9/site-packages/webpack_loader/utils.py", line 47, in _get_bundle
    bundle = loader.get_bundle(bundle_name)
  File "/usr/local/lib/python3.9/site-packages/webpack_loader/loader.py", line 116, in get_bundle
    filtered_chunks = self.filter_chunks(chunks)
  File "/usr/local/lib/python3.9/site-packages/webpack_loader/loader.py", line 58, in filter_chunks
    ignore = any(regex.match(chunk)
  File "/usr/local/lib/python3.9/site-packages/webpack_loader/loader.py", line 58, in <genexpr>
    ignore = any(regex.match(chunk)
TypeError: expected string or bytes-like object

Versions:
django-webpack-loader: 1.6.0
webpack-bundle-tracker: 0.4.3
webpack-stats.json
{"status":"done","publicPath":"http://localhost:8001/","chunks":{"app":[{"name":"app.js","publicPath":"http://localhost:8001/app.js","path":"/app/static/dist/app.js"}]}}
I hard-coded our STATICS_URL to try to match the documentation on django-webpack-loader
STATIC_URL: /app/static/dist/
WEBPACK PATH(output.path): /app/static/dist
Code that triggers the error:
{% render_bundle 'app' %} inside a index.html
WEBPACK_LOADER:
BASE_DIR = "/app"
STATIC_URL = "/app/static/dist/"
STATIC_ROOT = Path(BASE_DIR, "public")
STATICFILES_DIRS = [
    Path(BASE_DIR, "static"),
    Path(BASE_DIR, "static", "dist"),
]
WEBPACK_LOADER = {"DEFAULT": {"CACHE": not DEBUG}}

@gggrunt could you please try upgrading your webpack-bundle-tracker to 1.6.0? Try to always match versions between webpack-bundle-tracker and django-webpack-loader.

I'm also experiencing a similar issue, a TypeError when webpack-stats.json is parsed in django-webpack-loader. My webpack-stats is similarly built. Both webpack-bundle-tracker and django-webpack-loader are installed as version 1.6.0.

@camvrgs sorry you're having issues, please share the whole error stacktrace.

Hi @camvrgs, this looks similar to this issue https://github.com/django-webpack/django-webpack-loader/issues/324. We'll be updating any findings regarding this problem there.

@camvrgs @gggrunt
Please confirm you have the same version in django-webpack-loader and webpack-bundle-tracker like django-webpack-loader==1.6.0 and<EMAIL_ADDRESS>Both libs should always have the same version in projects.
This seems a duplicate of issue #324. Check this comment: https://github.com/django-webpack/django-webpack-loader/issues/324#issuecomment-1270691083
Closing for now.


update to python 3.8

Codecov Report

Merging #95 into master will increase coverage by 20.00%.
The diff coverage is 89.04%.

@@             Coverage Diff             @@
##           master      #95       +/-   ##
===========================================
+ Coverage   50.14%   70.14%   +20.00%
===========================================
  Files          13       13
  Lines         357      402       +45
===========================================
+ Hits          179      282      +103
+ Misses        178      120       -58

Impacted Files
Coverage Δ

historical_system_profiles/deleter.py
0.00% <0.00%> (ø)

historical_system_profiles/listener_logging.py
0.00% <ø> (ø)

historical_system_profiles/archiver.py
70.00% <84.61%> (+70.00%)
:arrow_up:

historical_system_profiles/views/v1.py
98.63% <96.15%> (+31.96%)
:arrow_up:

historical_system_profiles/config.py
100.00% <100.00%> (+6.06%)
:arrow_up:

historical_system_profiles/db_interface.py
79.06% <100.00%> (+12.40%)
:arrow_up:

historical_system_profiles/listener_metrics.py
100.00% <100.00%> (+100.00%)
:arrow_up:

historical_system_profiles/models.py
98.03% <100.00%> (+27.66%)
:arrow_up:

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd45805...d8c5a08. Read the comment docs.


Add Pacific Salmon Explorer

Insert URLs to the project here: https://github.com/salmonwatersheds/tech-report

[x] The projects is active, documented, open source licensed, shows usage from external parties and is directly targeting environmental sustainability. Find more details in the Contribution Guide.

All issues labeled as Good First Issue of the project listed on OpenSustain.tech will be visible on ClimateTriage.com. This is a great way to welcome new community members to your project.
All new projects listed will be posted on our Mastodon channel.

@sjpeacock @hertzPSF @ClareAtkinson @BrunoCartu


Use of angle brackets around file names for include statements

Would you like to replace any double quotes by angle brackets around file names for include statements?

@elfring Doesn't that mean that the library would have to be globally installed for it to build and run properly? Or would the include folder have to be marked as an include path by g++? Either way, what is the advantage over the double quotes?

I suggest to reconsider the consequences of the following wording from the section "16.2 Source file inclusion" in the standard specification for the programming language "C++".
…
The named source file is searched for in an implementation-defined manner. If this search is not supported, or if the search fails, the directive is reprocessed as if it read

#include <h-char-sequence> new-line
…

How do you think about to avoid "a duplicated file search" here?
Would you like to restrict the searched directories for header files of your software?

 Could you please clarify, @elfring?

There are different opinions about the handling of the involved implementation-defined behaviour.

Will header files be also searched outside the specified include directories if double quotes are used for the discussed preprocessor statement?
Is there a speed difference measurable if a file is not found there and the search will be retried with "the angle brackets inclusion method"?

I believe that:

If double quotes are used, only the local and include directories are searched
If brackets are used, the system and include directories are search are search

I doubt that there is a measurable speed difference between the two methods.
I may be wrong though.

Can you imagine use cases where you would like to exclude the search in "local" directories?

I cannot

@elfring Can you think of any use cases?

Yes. - This is the reason for my feature request here.
How much do you care where the include files are safely stored for a software library?

@elfring What is the case?

I find it important to be reasonably sure that the desired computations were really correct because it could be determined by the applied software build parameters that the used functions were actually derived from the expected source files. Can you follow this design concern?

What do you mean by this: "the desired computations were really correct"?

I would generally prefer to exclude the potential for the inclusion of header files from unexpected directories. Can such a security detail become a bit more important occasionally?

Yes, but the brackets mean that a person would have to specify an include directory, which is slightly annoying.

Will the mentioned "annoyance" vanish after safe include specifications would be used?

Yes. This does sound like a good idea. Thank you for the feature request.

Would specifying the include directory in our g++ compilation command in our makefiles and switching the the brackets fix your specified problem?

How would you like to distinguish library versions by your software build system?

Not sure? Any suggestions?

Feel free to submit a pull request that fixes the problem @elfring


providing support python3

In this place it broke in Python 3

Hello @live2son! Thank you for your contribution! Unfortunately this PR do not have any additional information about your changes. There is not clear which problem did you have, what was the root of the problem and what your solution does.  During writing the commit message I recommend you to use conventional commits specification. After adding the additional information you can force push to this branch again. Additional information will help us to make review for your changes. Thank you!

I think this can be closed as it was fixed with #13

I think it was fixed in #13


Graph widget

Description
This PR implements circular progress widgets as mentioned in #329
Usage
(box :class "bar"
       :orientation "v"
       :space-evenly true
    (graph :class "graph"
           :height 200
           :width 200
           :value cpuvar
           :max 20
           :min 0
           :dynamic true
           :thickness 2
           :line-style "miter"
           :time-range "10s")))

Showcase

Checklist
Please make sure you can check all the boxes that apply to this PR.

[x] All widgets I've added are correctly documented.
[x] The documentation in the docs/content/main directory has been adjusted to reflect my changes.
[x] I used cargo fmt to automatically format all code before committing

The PR should be working as of right now, however, there's a couple of things worth adding:

[ ] Dynamic Y range
[ ] Allow specifying if the graph should go downwards or upwards

Very epic!


Update main.py added /arrest

i forgot to remove arrest pls remove it

@nishant0078 i did not get you can you tell what line i messed up

Look at the Image it is attached the indentation is wrong all over the place

this

?
if yess it still works fine

Alright Code is good to go. Hope you have fixed all the grammar error

It looks alright, but there are merge conflicts with main branch that need to be fixed


[security] jackson-databind dependency needs to be upgraded

jackson-databind security vulnerability published: https://bugzilla.redhat.com/show_bug.cgi?id=1462702
jackson-databind issue: https://github.com/FasterXML/jackson-databind/issues/1599
version < 2.8.9  seems problematic.

@himanshug do you know what versions of hadoop such a thing would break?
We use a 2.6 version internally for spark compatibility, but haven't tried a 2.8.

Also, @himanshug would you mind please adding a Security label?

@drcrallen I haven't really analyzed it at all. I came across the issue and security is major concern , so created this issue at least to track that something needs to be done.
I think, in the past, we had issues when trying to upgrade jackson.

sure, creating the new label now.

At first glance it doesn't look like Druid is affected. The vulnerability described in the paper (https://www.github.com/mbechler/marshalsec) is that in some configurations Jackson will deserialize JSON into arbitrary classes based on a field in the JSON with the class name. Then that can be used to trigger code execution during construction of certain classes.
But, from the paper:

Jackson, in its default configuration, does perform strict runtime type checking, including collection generic types, and does not allow the specification of arbitrary types — therefore it is unaffected by these issues by default.

The paper goes on to discuss options you can set in Jackson that will enable this insecure behavior. It mentions a few:

objectMapper.enableDefaultTyping()
a custom TypeResolverBuilder
@JsonTypeInfo on a field

As far as I can tell we are not using any of these. That list might not be exhaustive, but as far as I can tell we are also not using any other thing that would involve allowing the java class name to be read from the json serialized form. We make wide use of @JsonTypeInfo but it is always with use = JsonTypeInfo.Id.NAME, meaning custom strings that are not class names.
It's still good to upgrade, but I don't think it needs to be urgent since it seems likely that there is no actual vulnerability in Druid.

Related slightly due to jackson version change: https://github.com/druid-io/druid/pull/4808

@gianm thanks for looking into it more and finding the scope of exploit, good to know that we are  not impacted. however, let us keep it open to try out newer versions whenever possible.


Either "cuDNN SDPA backward got grad_output.strides() != output.strides()" or OutOfMemory

TL;DR : very hard to tell if training is starting before getting first samples pics ; either it's just not starting or it fails with some error if trying other GPU external settings ; seems to work using 12 GB instead of 16 GB (for a 16 GB GPU)
I'm confused... The part where the training start is a challenge
I have made fluxgym train 2 Loras and they came out well, but most of the time I get this :
[2024-09-17 09:01:52] [INFO] C:\fluxgym\env\Lib\site-packages\torch\autograd\graph.py:826: UserWarning: cuDNN SDPA backward got grad_output.strides() != output.strides(), attempting to materialize a grad_output with matching strides... (Triggered internally at C:\actions-runner_work\pytorch\pytorch\builder\windows\pytorch\aten\src\ATen\native\cudnn\MHA.cpp:676.)
[2024-09-17 09:01:52] [INFO] return Variable._execution_engine.run_backward(  # Calls into the C++ engine to run the backward pass
Then it doesn't do anything. I've noticed sometimes it does work in the background, but you don't see it unless you have set up the parameter to have sample images regularly. So I set up a low threshold like 100 or 200 steps, this way I can monitor the training, because everytime it generates the sample images THEN you see the steps counters.
Unfortunately I just had luck because now I cannot train a third lora using the same parameters as the two previous. Here's what I tried so far :

Updated fluxgym to the latest version using git pull and refreshing dependencies. I ended up doing a fresh new install

Switched the NVIDIA 3D parameters in ControlPanel for CUDA Fallback policy to "Prefer No System Fallback" as someone recommended in https://github.com/cocktailpeanut/fluxgym/issues/48

This replaces the previous error by an OutOfMemory error where it says it's 64 MB short and I should maybe try to set PYTORCH_CUDA_ALLOC_CONF=expandable_segments:True

Set PYTORCH_CUDA_ALLOC_CONF=expandable_segments:True
Now it says in the logs before it starts training that this setting is not allowed on this platform
Then I have a return with code 1

Switch VRAM to 12 Gb (instead of 16 GB)
Now this seems to work but it is a disappointing workaround as it seems much slower (first steps are taking around 7 s / step when I average 2.5 s / step with 16 GB)

Any idea how to fix that and/or how we could make the training start phase more reliable ?
There's this moment between the log line "return Variable._execution_engine.run_backward) and the first samples where I don't know whether or not it's gonna work
EDIT : I've also post the issue on https://github.com/kohya-ss/sd-scripts/ - Will update both ways with solutions

Took me long but it's now solved by using rank 64 instead of 128 which was too VRAM demanding for my 16 GB RTX 4090
If you need to see the initial steps right from the start, to see if your training is working after the "Variable._execution_engine.run_backward("  line, do this :

Abort your training, pressing Control + C
Go in fluxgym\outputs[your lora folder]
Open the train.bat file using Notepd++
Replace every ^ by nothing
Edit > Line Operations > Join Lines (or Control + J) to have the whole commnand on one single line, then copy it
Open a new Powershell terminal, go to the fluxgym directory, do the usual env\Scripts\activate thing
Now instead of doing "py app.py", just paste the line you edited from the train.bat + Enter
Your training will start right away using everything you've done previously in Fluxgym (Settings, Dataset, Captions, etc) but this time you will see a progress bar with the step immediately after the "Variable._execution_engine.run_backward("  line

This way you know if it's working or not, and at which speed, instead of waiting ages without knowing.
That has been essential for me to understand and solve my issue.


audit: uses_from_macos only uses macOS software

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.

[x] Have you successfully run brew tests with your changes locally?

Verify that dependencies specified as being used from macOS are, in fact, provided by macOS.
No tests written because any new test would put test/dev-cmd/audit_spec.rb at over 500 lines, an action which is forbidden by Rubocop.
https://github.com/Homebrew/brew/issues/6150
https://github.com/Homebrew/brew/pull/6162

No tests written because any new test would put test/dev-cmd/audit_spec.rb at over 500 lines, an action which is forbidden by Rubocop.

Please disable the check or split up the file and write some tests anyway, thanks.

I'm okay with merging this PR and see how it performs in practice, with the understanding that it will likely need tweaking and the creation and maintenance of a white list of formulae provided by macOS in addition to those that are keg-only.

I'm okay with merging this PR and see how it performs in practice, with the understanding that it will likely need tweaking and the creation and maintenance of a white list of formulae provided by macOS in addition to those that are keg-only.

In that case we should add code to handle the whitelist now (even if it's an empty array) and make it a --strict audit until we're confident it's reliable enough to be on by default.

In that case we should add code to handle the whitelist now (even if it's an empty array) and make it a --strict audit until we're confident it's reliable enough to be on by default.

Alright, I'll work on this next week.

Thanks for the reviews. I'm working on figuring out how to split up the test into multiple files first in a separate pull request, then I will get back to revising this one.

I'm working on figuring out how to split up the test into multiple files first in a separate pull request, then I will get back to revising this one.

I think it's probably worth adding a RuboCop exception for this file instead unless dev-cmd/audit.rb itself is split into multiple files.

@jonchang any news on this? Thanks!

Haven't figured out how to split up the test file to get it under the 500 line limit. I'll probably try to take another look this weekend.

@jonchang Please don't 😄. Either add a # rubocop:disable to the relevant file or bump the limits in the .rubocop.yml.

Definitely don't have time for this right now. Closing until I go on vacation.


Prepare archer network transactions for eip1559

Note, that this will only work until August 4th. EIP 1559 requires at least the base fee to be paid by tx.origin.
Originally posted by @fleupold in https://github.com/gnosis/gp-v2-services/pull/825#discussion_r670432365

This has been completed with the new Eden integration.


[WIP] Switch the two if branches dealing with SDKROOT

This attempts to fix an issue where running Swift scripts as build scripts within Xcode against targets other than macOS (e.g. iOS) to failed. See SR-9216 or https://github.com/mxcl/swift-sh/issues/113 for more details.
Resolves SR-9216.

Thanks for picking this up, @Jeehut! However, the two branches (if checks) that need to be switched are the ones that say "is SDKROOT set" and "is this the interpreter". An explicit -sdk should still win in both cases.
Once you've got this set up, some of the tests should start failing (hopefully, anyway!), and then you'll need to change those to expect the new behavior. You can see how to run the tests without rebuilding everything in docs/Testing.md.

@belkadan Thanks for the quick response and the correction. But unfortunately I can't find the strings you mentioned anywhere in the project, nor did I find a method in Drive.cpp named similarly, there's just an isSDKTooOld which doesn't sound like the same thing. I couldn't even find the word interpreter in the file. I'm sorry, but I fear you would need to be more explicit.
I will read the docs sometime tomorrow when I have more time, thanks for the pointer.

Oops, I guess it's because the driver calls it "immediate" (script interpreting) and "REPL" (interactive interpreting) modes. It's just the next if-clause down:
https://github.com/apple/swift/blob/78b0295f6faa4d87ca37bcf54b314f03328c88bc/lib/Driver/Driver.cpp#L1707-L1708

@belkadan Thanks for having a look again, I think I understood what you mean now. Could you please have a quick look?

That looks right to me! Did any tests need changing?

I'm not actually sure if I still have pull request testing privileges now that I'm no longer at Apple. Let's see.
@swift-ci Please smoke test

@swift-ci please smoke test

@belkadan Didn't have time to check the tests yet, will try to do this weekend.

Starting to work on this again, just rebased and running utils/build-script --test --ios for the first time ... this can take a while 😅

Finally, after several runs and waiting for multiple hours, I have the test results locally: The tests are failing in these two places:
First:
test/Driver/options-interpreter.swift:18:29: error: CHECK-RESOURCE-DIR-ONLY: expected string not found in input
// CHECK-RESOURCE-DIR-ONLY: # DYLD_LIBRARY_PATH=/RSRC/macosx{{$}}
                            ^
<stdin>:1:1: note: scanning from here
BUILD_DIR/bin/swift -frontend -interpret SOURCE_DIR/test/Driver/options-interpreter.swift -target x86_64-apple-macosx10.9 -enable-objc-interop -sdk /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.15.sdk -module-cache-path BUILD_DIR/swift-test-results/x86_64-apple-macosx10.9/clang-module-cache -resource-dir /RSRC/ -swift-version 4 -ignore-module-source-info -target-sdk-version 10.15.4 -module-name main # DYLD_LIBRARY_PATH=/RSRC/macosx:/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.15.sdk/usr/lib/swift
^
<stdin>:1:451: note: possible intended match here
BUILD_DIR/bin/swift -frontend -interpret SOURCE_DIR/test/Driver/options-interpreter.swift -target x86_64-apple-macosx10.9 -enable-objc-interop -sdk /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.15.sdk -module-cache-path BUILD_DIR/swift-test-results/x86_64-apple-macosx10.9/clang-module-cache -resource-dir /RSRC/ -swift-version 4 -ignore-module-source-info -target-sdk-version 10.15.4 -module-name main # DYLD_LIBRARY_PATH=/RSRC/macosx:/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.15.sdk/usr/lib/swift

Second:
test/Driver/sdk.swift:60:16: error: SDKWARNING: expected string not found in input
// SDKWARNING: warning: no such SDK: '{{.*}}/Inputs/nonexistent-sdk'
               ^
<stdin>:1:1: note: scanning from here
<unknown>:0: warning: unnecessary option '-repl'; this is the default for 'swift' with no input files
^
<stdin>:1:14: note: possible intended match here
<unknown>:0: warning: unnecessary option '-repl'; this is the default for 'swift' with no input files
             ^

Now that I made this first step, next I will try to get an understanding on how these tests work and if I can fix them by reordering something in the tests and switching around things. But since tests are taking so long, I'm not sure how far I will come ... I'm happy about any hints that could direct me a little bit. 😄

You absolutely don't have to rerun the entire test suite — docs/Testing.md#using-litpy

Please update the base branch to main by Oct 5th otherwise the pull request will be closed automatically.

How to change the base branch: (Link)
More detail about the branch update: (Link)

Any updates on this fix? 🙏


feat: faster jsonification

Description
This PR fixes #525

@JackThomson2 , see the commit authors 👀

Nice! What performance uplift did you see?


[BUG]Upgrade gomonkey v2 to support arm64

What is your environment(Kubernetes version, Fluid version, etc.)
Describe the bug
What you expect to happen:
How to reproduce it
Additional Information

Fixed by #1910


Save should be possible rather than always having to "save as/export"

In addition, not having to choose a file name each time would be better.

Auto save with a sqlite file is now available.


Linux Support

I just wanted to ask if there would be support for Linux? In the future or if it supports Linux already.

Technically it could be adapted, and it would be fairly easy. The only parts to be modified are in the class SetNewWallpaper.java and the installer. The problem with linux is that it has many Desktop Manager (KDE, XFCE, GNOME.. etc) and each of them has a different way to apply a wallpaper. For instance if you read the code in SetNewWallpaper.java you would see a method to apply a wallpaper in XFCE (as this was the VM's DE I developed on).
I plan to add such feature in the future

Yep, this is the exact same issue I'm facing with wallpaper-reddit package as I use the Deepin DE, and that isn't supported by that package. Hope the best in adding these features, you can close this issue if you so wish.

@dreaddr you can use styli.sh for linux

Thanks @HarshaVardhanNakkina


c++ library

#include <bits/stdc++.h> this head file doesn’t work in the app, is this issue of IDE?

We have added this header in a recent commit. It is now in the TestFlight build and will be available in the next release.

https://testflight.apple.com/join/EgZ8sE2P

thx,and i have another question, i m new to learning code, can this great IDE download in mac(m1 apple silicon)?

No, Code App is not available for macOS.


Bootstrapping (aka. SwiftCompilerSources) state on Windows

Describe the bug
Bootstrapping the Swift toolchain on Windows still fails at the time. We should look into this problem before more features rely on it and the process becomes mandatory.
Steps To Reproduce
Steps to reproduce the behavior:

Build the Swift toolchain with -DBOOTSTRAPPING_MODE=BOOTSTRAPPING.
...

Expected behavior
Ideally the toolchain should be able to bootstrap. This was formerly blocked by some linker / runtime issue, but now new problems occurred during build steps, before the link step.
Environment (please fill out the following information)

OS: Windows 10 21H2
Visual Studio: 17.3.5

Additional Context
The issue is used to track the state of Swift bootstrapping ability on Windows.

Current blocker
[6031/7041][ 85%][8226.737s] Building swift module Basic
FAILED: bootstrapping1/tools/swift/SwiftCompilerSources/Basic.o T:/1/bootstrapping1/tools/swift/SwiftCompilerSources/Basic.o
cmd.exe /C "cd /D C:\Users\stevapple\Developer\swift\SwiftCompilerSources && T:\1\bootstrapping0\bin\swiftc.exe -c -o T:/1/bootstrapping1/tools/swift/SwiftCompilerSources/Basic.o -I T:/1/bootstrapping0/bin/../lib -target x86_64-unknown-windows-msvc -module-name Basic -emit-module -emit-module-path T:/1/bootstrapping1/tools/swift/SwiftCompilerSources/Basic.swiftmodule -parse-as-library C:/Users/stevapple/Developer/swift/SwiftCompilerSources/Sources/Basic/SourceLoc.swift C:/Users/stevapple/Developer/swift/SwiftCompilerSources/Sources/Basic/Utils.swift -wmo -Xfrontend -validate-tbd-against-ir=none -Xfrontend -enable-experimental-cxx-interop -Xcc -UIBOutlet -Xcc -UIBAction -Xcc -UIBInspectable -Xfrontend -disable-implicit-string-processing-module-import -O -cross-module-optimization -Xcc -I -Xcc C:/Users/stevapple/Developer/llvm-project/llvm/include -Xcc -I -Xcc T:/1/include -Xcc -I -Xcc C:/Users/stevapple/Developer/swift/include -Xcc -I -Xcc T:/1/tools/swift/SwiftCompilerSources/../include -I T:/1/bootstrapping1/tools/swift/SwiftCompilerSources"
<unknown>:0: warning: unable to perform implicit import of "_Concurrency" module: no such module found
C:\Users\stevapple\Developer\swift\include\swift/AST/ASTBridging.h:16:10: note: while building module 'BasicBridging' imported from C:\Users\stevapple\Developer\swift\include\swift/AST/ASTBridging.h:16:
#include "swift/Basic/BasicBridging.h"
         ^
C:/Users/stevapple/Developer/swift/include\swift/Basic/Debug.h:15:10: note: while building module 'LLVM_Utils' imported from C:/Users/stevapple/Developer/swift/include\swift/Basic/Debug.h:15:
#include "llvm/Support/Compiler.h"
         ^
C:/Users/stevapple/Developer/llvm-project/llvm/include\llvm/Support/MathExtras.h:18:10: note: while building module 'std' imported from C:/Users/stevapple/Developer/llvm-project/llvm/include\llvm/Support/MathExtras.h:18:
#include <climits>
         ^
<module-includes>:1:10: note: in file included from <module-includes>:1:
#include "ccomplex"
         ^
C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.33.31629\include/ccomplex:12:10: note: in file included from C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.33.31629\include/ccomplex:12:
#include <complex>
         ^
C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.33.31629\include\complex:13:10: note: in file included from C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.33.31629\include\complex:13:
#include <limits>
         ^
C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.33.31629\include\limits:13:10: note: in file included from C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.33.31629\include\limits:13:
#include <cwchar>
         ^
C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.33.31629\include\cwchar:13:10: note: in file included from C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.33.31629\include\cwchar:13:
#include <wchar.h>
         ^
C:\Program Files (x86)\Windows Kits\10\include\10.0.22621.0\ucrt\wchar.h:236:26: error: missing '#include <vcruntime_string.h>'; 'memcpy' must be declared before it is used
        return (wchar_t*)memcpy(_S1, _S2, _N*sizeof(wchar_t));
                         ^
C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.33.31629\include\vcruntime_string.h:43:15: note: declaration here is not visible
void* __cdecl memcpy(
              ^
C:\Users\stevapple\Developer\swift\include\swift/AST/ASTBridging.h:16:10: note: while building module 'BasicBridging' imported from C:\Users\stevapple\Developer\swift\include\swift/AST/ASTBridging.h:16:
#include "swift/Basic/BasicBridging.h"
         ^
C:/Users/stevapple/Developer/swift/include\swift/Basic/Debug.h:15:10: note: while building module 'LLVM_Utils' imported from C:/Users/stevapple/Developer/swift/include\swift/Basic/Debug.h:15:
#include "llvm/Support/Compiler.h"
         ^
C:/Users/stevapple/Developer/llvm-project/llvm/include\llvm/Support/MathExtras.h:18:10: note: while building module 'std' imported from C:/Users/stevapple/Developer/llvm-project/llvm/include\llvm/Support/MathExtras.h:18:
#include <climits>
         ^
<module-includes>:1:10: note: in file included from <module-includes>:1:
#include "ccomplex"
         ^
C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.33.31629\include/ccomplex:12:10: note: in file included from C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.33.31629\include/ccomplex:12:
#include <complex>
         ^
C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.33.31629\include\complex:13:10: note: in file included from C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.33.31629\include\complex:13:
#include <limits>
         ^
C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.33.31629\include\limits:13:10: note: in file included from C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.33.31629\include\limits:13:
#include <cwchar>
         ^
C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.33.31629\include\cwchar:32:13: error: missing '#include <corecrt_wtime.h>'; 'tm' must be declared before it is used
using _CSTD tm;
            ^
C:\Program Files (x86)\Windows Kits\10\include\10.0.22621.0\ucrt\corecrt_wtime.h:26:8: note: declaration here is not visible
struct tm
       ^
C:\Users\stevapple\Developer\swift\include\swift/AST/ASTBridging.h:16:10: note: while building module 'BasicBridging' imported from C:\Users\stevapple\Developer\swift\include\swift/AST/ASTBridging.h:16:
#include "swift/Basic/BasicBridging.h"
         ^
C:/Users/stevapple/Developer/swift/include\swift/Basic/Debug.h:15:10: note: while building module 'LLVM_Utils' imported from C:/Users/stevapple/Developer/swift/include\swift/Basic/Debug.h:15:
#include "llvm/Support/Compiler.h"
         ^
<module-includes>:1:10: note: in file included from <module-includes>:1:
#include "ADT\APFixedPoint.h"
         ^
C:\Users\stevapple\Developer\llvm-project\llvm\include\llvm/ADT\APFixedPoint.h:19:10: note: in file included from C:\Users\stevapple\Developer\llvm-project\llvm\include\llvm/ADT\APFixedPoint.h:19:
#include "llvm/ADT/APSInt.h"
         ^
C:/Users/stevapple/Developer/llvm-project/llvm/include\llvm/ADT/APSInt.h:18:10: note: in file included from C:/Users/stevapple/Developer/llvm-project/llvm/include\llvm/ADT/APSInt.h:18:
#include "llvm/ADT/APInt.h"
         ^
C:/Users/stevapple/Developer/llvm-project/llvm/include\llvm/ADT/APInt.h:19:10: note: in file included from C:/Users/stevapple/Developer/llvm-project/llvm/include\llvm/ADT/APInt.h:19:
#include "llvm/Support/MathExtras.h"
         ^
C:/Users/stevapple/Developer/llvm-project/llvm/include\llvm/Support/MathExtras.h:18:10: error: could not build module 'std'
#include <climits>
         ^
C:\Users\stevapple\Developer\swift\include\swift/AST/ASTBridging.h:16:10: note: while building module 'BasicBridging' imported from C:\Users\stevapple\Developer\swift\include\swift/AST/ASTBridging.h:16:
#include "swift/Basic/BasicBridging.h"
         ^
C:/Users/stevapple/Developer/swift/include\swift/Basic/Debug.h:15:10: note: while building module 'LLVM_Utils' imported from C:/Users/stevapple/Developer/swift/include\swift/Basic/Debug.h:15:
#include "llvm/Support/Compiler.h"
         ^
C:/Users/stevapple/Developer/llvm-project/llvm/include\llvm/Support/DataTypes.h:19:10: note: while building module 'LLVM_C' imported from C:/Users/stevapple/Developer/llvm-project/llvm/include\llvm/Support/DataTypes.h:19:
#include "llvm-c/DataTypes.h"
         ^
<module-includes>:1:10: note: in file included from <module-includes>:1:
#include ".\Analysis.h"
         ^
C:\Users\stevapple\Developer\llvm-project\llvm\include\llvm-c/.\Analysis.h:23:10: note: in file included from C:\Users\stevapple\Developer\llvm-project\llvm\include\llvm-c/.\Analysis.h:23:
#include "llvm-c/Types.h"
         ^
C:/Users/stevapple/Developer/llvm-project/llvm/include\llvm-c/Types.h:17:10: note: in file included from C:/Users/stevapple/Developer/llvm-project/llvm/include\llvm-c/Types.h:17:
#include "llvm-c/DataTypes.h"
         ^
C:\Users\stevapple\Developer\llvm-project\llvm\include\llvm-c\DataTypes.h:53:10: error: could not build module 'std'
#include <cstddef>
         ^
C:\Users\stevapple\Developer\swift\include\swift/AST/ASTBridging.h:16:10: note: while building module 'BasicBridging' imported from C:\Users\stevapple\Developer\swift\include\swift/AST/ASTBridging.h:16:
#include "swift/Basic/BasicBridging.h"
         ^
<module-includes>:2:10: note: in file included from <module-includes>:2:
#include "Basic/BasicBridging.h"
         ^
C:\Users\stevapple\Developer\swift\include\swift/Basic/BasicBridging.h:17:10: note: in file included from C:\Users\stevapple\Developer\swift\include\swift/Basic/BasicBridging.h:17:
#include "swift/Basic/SourceLoc.h"
         ^
C:/Users/stevapple/Developer/swift/include\swift/Basic/SourceLoc.h:20:10: note: in file included from C:/Users/stevapple/Developer/swift/include\swift/Basic/SourceLoc.h:20:
#include "swift/Basic/Debug.h"
         ^
C:/Users/stevapple/Developer/swift/include\swift/Basic/Debug.h:15:10: error: could not build module 'LLVM_Utils'
#include "llvm/Support/Compiler.h"
         ^
<module-includes>:1:10: note: in file included from <module-includes>:1:
#include "AST/ASTBridging.h"
         ^
C:\Users\stevapple\Developer\swift\include\swift/AST/ASTBridging.h:16:10: error: could not build module 'BasicBridging'
#include "swift/Basic/BasicBridging.h"
         ^
C:/Users/stevapple/Developer/swift/include\swift/Localization/LocalizationFormat.h:25:10: note: while building module 'LLVM_Bitstream' imported from C:/Users/stevapple/Developer/swift/include\swift/Localization/LocalizationFormat.h:25:
#include "llvm/Bitstream/BitstreamReader.h"
         ^
<module-includes>:2:10: note: in file included from <module-includes>:2:
#include "Bitstream\BitCodes.h"
         ^
C:\Users\stevapple\Developer\llvm-project\llvm\include\llvm/Bitstream\BitCodes.h:20:10: error: could not build module 'LLVM_Utils'
#include "llvm/ADT/SmallVector.h"
         ^
C:/Users/stevapple/Developer/swift/SwiftCompilerSources/Sources/Basic/SourceLoc.swift:13:8: error: could not build C module 'ASTBridging'
import ASTBridging
       ^
[6032/7041][ 85%][8285.350s] Building swift module _CompilerRegexParser

This looks like a compiler bug regarding C++-Interop with MSVC, but it could also be related to module maps of used C++ modules.

Note that the mandatory bootstrapping will not use C++ Interop, only C Interop for the first year, so you may have more time to figure this out.


fix(cors): allow custom vary header

Fixes #2932 allow developers to use custom vary header value, it will helps to support many use cases with custom vary headers such as CF Polished.
The author should do the following, if applicable

[x] Add tests
[x] Run tests
[x] bun run format:fix && bun run lint:fix to format the code
[ ] Add TSDoc/JSDoc to document the code

@fzn0x
Thanks! I think we can treat it as afix not  a feat. So we can merge this into the main and will include the next patch release!


[WIP] Setup CI

          1 Warning

:warning:
PR is classed as Work in Progress

  Generated by :no_entry_sign: Danger


Add -working-directory argument to incremental tests' runDriver routine.

Otherwise they deposit various build products into the package root (e.g. main.o, other.o, etc.).

@swift-ci please test


manifest: update hal_nxp for s32k3 lpspi.

Update hal_nxp to remove S32K3X4-0P55A-1P55A-ERRATA by disabling FSL_FEATURE_LPSPI_HAS_ERRATA_050456.
This allows for lpspi to work correctly on mr_canhubk3.

@bperseghetti please rebase

@bperseghetti please rebase

@carlescufi Done!


Some tweaks to logger

Removed koa-logger
Replaced it with similar style in loggingMiddleware
smaller pino-pretty formatting tweaks for readability
local timestamp
console references are now logger

ok I'm abandoning this one ... didn't realize stuff was still in flux, let's land that then I'll figure out what I want


Add auto-reconnect when connection is suddenly lost

Similar to other Socket.io client libraries (i.e. python-socketio), I added auto reconnecting when the connection is lost in not-clean way (i.e. due to service shut down).
I coded it because I need stable connection for my application, and I think it's worth to have such reconnecting in the client code itself (to not need to bother handling edge cases in the application code itself)
I added 2 extra signals: on_connection_lost and on_reconnected to be able to display messages like "We're trying to reconnect you...", etc., and to stop pushing messages, until the connection is retrieved.
This PR also replaces _connected flag (which was unused) with more flexible _connection_state, with RECONNECTING being one of the possible states.
As for now, when the client successfully reconnects, it does NOT connect to any specific Socket.io namespace. Instead, it makes the same on_engine_connected signal being emitted, and one must again manually call socketio_connect to join specific namespaces. I think it would be great idea to automate also that bit, but I didn't want to mess up to much in this very PR.
Minimal script to test/demo these changes:
extends Node

var client: SocketIOClient

func _ready():
	client = SocketIOClient.new("ws://<IP_ADDRESS>:8081/socket.io")

	client.on_engine_connected.connect(on_socket_ready)
	client.on_connect.connect(on_socket_connect)
	client.on_connection_lost.connect(on_connection_lost)
	client.on_reconnected.connect(on_reconnected)

	add_child(client)

func on_socket_ready(_sid: String):
	print("Socket ready. Connecting to namespace...")
	# Connect (or re-connect) to each namespace
	client.socketio_connect()

func on_socket_connect(_payload: Variant, _name_space, _error: bool):
	print("Socket connected!")

func on_connection_lost():
	print("Connection lost. Trying to reconnect. Hold tight!")

func on_reconnected(_payload: Variant, _name_space, _error: bool):
	print("Connection retrieved!")

Hey thanks for the PR and the explanations! They all look good to me. Merged!


Deprecation removal of Gradle UI

Context
See https://github.com/gradle/gradle/issues/995
Gradle Core Team Checklist

[x] Verify test coverage and CI build status
[x] Mention in release notes

Your requested change were done @bmuschko.


Restrict owner to pointers, if possible given the compiler

M-GSL issue 507:
template <class T, class = std::enable_if_t<std::is_pointer<T>::value>>
using owner = T;

Release 0.25.0


[Windows 7] "The system cannot find the path specified."

On Windows 7, Ruby 2.0.0 + DevKit installed, package modules installed via npm install [name] --save-dev, I keep getting the following error:
Running "sass:dist" (sass) task
The system cannot find the path specified.
Warning:  Use --force to continue.

Aborted due to warnings.

My gruntfile looks as follows:
module.exports = function(grunt) {

    grunt.initConfig({
        pkg: grunt.file.readJSON('package.json'),
        sass: {
            dist: {
                options: {
                    style: 'compact',
                    compass: true
                },
                files: {
                    'style.css': 'sass/style.scss'
                }
            }
        },
        watch: {
            files: ['sass/**/*.scss','sass/**/*.sass'],
            tasks: ['default']
        }
    });

    grunt.loadNpmTasks('grunt-contrib-sass');
    grunt.loadNpmTasks('grunt-contrib-watch');

    grunt.registerTask('default', ['sass']);

};

style.css gets compiled to the root. It does work (although it seems to compile twice) but I keep getting the error. Even with clean projects I start I get this message. Am I declaring something wrong?

I know that's an old post, but just i n case this can help someone. It might seem a little silly but... Do you have sass installed?
gem install sass in case you don't

Thanks SoniaGarmar, I had sass installed, thought I reinstalled it but somehow it wasn't. Your post did the trick!

@vwswebmaster  Glad to help!

It is funny @SoniaGarmar how something that obvious can be the culprit. Because I have Sass installed on my main environment I forgot to install it on my new laptop. Unconsciously I assumed was already installed, not realizing that was not... duh! Appreciate your comment on an old thread, it is always good to have new insights in old questions and problems.


Suggestion 4

I think we could make a feature that would allow people to submit reports saying what they want next and how much they like the current version of Repl customs.
FunnyLamma

I'll work on that right now. That feature will come in the next update. For right now, the feedback channel is where users go to submit feedback.


Fixes #1218

Description
Fixes #1218
Add password visibitly toggle to login screen.
Screenshots showing what changed
Before

After

Codecov Report

Merging #1219 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #1219   +/-   ##
======================================
  Coverage    3.81%   3.81%
======================================
  Files         125     125
  Lines        5815    5815
  Branches      568     568
======================================
  Hits          222     222
  Misses       5578    5578
  Partials       15      15

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c51e2e...e0e6991. Read the comment docs.

Thanks for the PR @knight-shade :)


[adc_ctrl] Ensure minimum power-up time is adhered

Add minimal offset from the nominal ADC power-up time to avoid triggering an assertion at exactly 30 us.
Increase the reset value for adc_ctrl to 7 cycles, since the AON clock period may be faster than nominal and cause a quicker channel selection than the 30 us target.
Fixes #18137

CC @meisnere
This was motivated by the new assertion, but it's unclear if it's the correct approach.

The 30us seem to be accurate, according to the ADC spec in the AST docs.

Is the ChannelStableOnAdcEn assertion a design guarantee? Also, the comment in line 119 adc.sv seems wrong: it should say adc_chnsel_i should remain at 0 for 7 cycles after adc_en raises.

I guess the question is why the assertion was set to 7 cycles in the first place, because 30us / 5us = 6 cycles if the clock period is 5us...

Is this relevant to cdc-instrumentation? Once it is enabled, there can be 1 cycle of extra delay
sometimes (not always).

Okay, I see now. adc_ctrl does add a cycle before asserting adc_pd_o, just like its documentation claims. However, the assertion inside the ADC model looks at a cycle-delayed version of that signal vs. the incoming adc_chnsel_i:
https://github.com/lowRISC/opentitan/blob/b3d7261a73b5d9b443e78a65349becfb9f6ac0b6/hw/top_earlgrey/ip/ast/rtl/adc.sv#L33-L39
https://github.com/lowRISC/opentitan/blob/b3d7261a73b5d9b443e78a65349becfb9f6ac0b6/hw/top_earlgrey/ip/ast/rtl/adc.sv#L118-L119
That causes us to align at exactly 30 us again.
And yet... the actual documentation on this suggests the assertion is targeting the wrong value: https://opentitan.org/book/hw/top_earlgrey/ip/ast/index.html#adc-usage-flow
Notice that the start of the time is the port, not the internally-delayed signal. So which should it be? Should the assertion change the LHS of the implication to $rose(adc_pd_i)?
@meisnere Would you happen to be able to help here? Does the assertion or the spec need to change? (if it's spec changes, that'd mean 30 us + 1 clock cycle, to account for the pipeline register)

yeah, I guess the question is why the assertion was set to 7 cycles in the first place, because 30us / 5us = 6 cycles if the clock period is 5us...

It's set to 7 because the 1st check is the 0th cycle (i.e. the same instant when we saw $rose(adc_en)).

This is kind of funky. In isolation, the 7 would be correct to force 6 cycles of observing adc_chnsel_i being 0 after the sampled $rose() event, given the use of the overlapping implication operator, right? The first evaluation of the consequent property expression is at the same time as the end of the antecedent sequence expression (so in the preponed phase of the same clock tick). So that consumes the 1, and then you need to add 6 to get the 6 cycles out.
However, we know that adc_en came from a flop and was valid for most of the cycle before. /shrug

Added a commit that changes the waveform to reflect that adc_pd_i is internally flopped and inverted, becoming adc_en and suggesting that the power-up time is relative to the first clock edge after adc_pd_i goes low.
The new waveform for the power-up portion:

@zi-v @meisnere Let me know if this isn't right. We're confused about the presence of that flop in the path vs. a spec'd time that doesn't involve clocks.

This PR is superseded by #18540.


Added isRunning react method for Android

Hey,
I needed a way to check whether the service is already running, so I built it.
While I was doing that, I added automatically binding the activity to the service (if the service was already running) when the module resumes as well.
Only implemented it for Android for now, but soon will do it for iOS as well. (Focused on the Android version at the moment).
Thanks!
Ansgar

Looking good. Just thinking if static variable would not do the same job.

Another concern. Doesn't using main looper reintroduce that crazy issue with system destroying service when app is terminated by user and option stopOnTerminate is set to true?
I believe it is this one:
https://github.com/mauron85/cordova-plugin-background-geolocation/issues/9#issuecomment-164937039

Please do following test:
use stopOnTerminate: false
Start service. Swipe app from task list. And running logcat watch for:
android.os.DeadObjectException
scheduling restart of crashed service

Wow, thanks for the fast reply!
Yeah, a static field would work aswell. I could change it to that if you prefer that.
Oh, and about the main looper: I think it's not necessary. I didn't know about that bug. I added it because I was running into crashes while trying to bind to the service without a connected activity (I first used the constructor and not the lifecycle callback).
I will test it and report back!

No such crashes. Continues to run in the background.

I vote for static just because code will be little bit smaller. If you can manage iOS implementation (should be easy), I'll merge this.

Implemented in android branch.


Pre Populate TextView

How do you pre populate the textview when the view first loads.  I want to save any text that was in the field and then restore it when they return to the view?

Hello, did you ever find out how to do this?  Thanks for any help!!

I know this is deprecated but I need to update our app until we find a replacement for JSQ.
I saw a post and it said that after version 4 or 5 I should be able to set the textView and then do the following:
NotificationCenter.default.post(name: UITextView.textDidChangeNotification, object: self.inputToolbar.contentView.textView)
to have the textView resize with the new text.  However, that call does not seem to work.  I was hoping you could just tell me how to set the text and re-size the view so it shows correctly.
Any help would be appreciated.
Best,
Tony
On May 29, 2019, at 1:40 PM, Jesse Squires <notifications<EMAIL_ADDRESS>wrote:
Closed #2204https://github.com/jessesquires/JSQMessagesViewController/issues/2204.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/jessesquires/JSQMessagesViewController/issues/2204?email_source=notifications&email_token=AJ5GWY4K22TML2RLYBXQG6DPX25ZRA5CNFSM4FW5U2YKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGORWO3A7Y#event-2375921791, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AJ5GWY6C2BNROJ6OXDE2TULPX25ZRANCNFSM4FW5U2YA.


RFE - Create Dockerfile.common for podmanimage Dockerfiles

In #3287  @vrothberg suggested making a Dockerfile.common for the Dockerfiles found in ./contrib/podmanimage rather than having repetitive lines in all three.  Before fully implementing, we need to make sure the quay.io/user/podman account is happy building the images using a Dockerfile that includes another.  I think it will be OK, but it does need to be verified.  Valentin's comment:
I wonder if we can decompose the common parts of the Dockerfiles into a shared file and control revisions etc. via env variables. The *.in suffix will allow for including another Dockerfile via the #include directive.

The upstream Dockerfile.in could then look like this:

FROM fedora:latest
ENV GOPATH=...
ENV PODMAN_COMMIT=master
ENV CONMON_COMMIT=master

#include ../Dockerfile.common

The Dockerfile.common Dockerfile could then include everything starting from line 14.

If this works here, it would be good to do a similar change in buildah

SGTM

@TomSweeneyRedHat updates?

deep back burner, haven't touched  it yet.

I read through a ton of Dockerfile stuff today and I can't find an easy way to do an INCLUDE directive.  It's something the Dockerfile maintainers are very much against and they added a COPY --context directive that kind of does an include, but you need to split things across directories.  Given that each of our Dockerfiles would only save 3 to 5 lines and they've not changed a bit in the several months since they've been created, I'm going to close this now.  We can reopen if things change later or someone has a brighter idea than I.

I read through a ton of Dockerfile stuff today and I can't find an easy way to do an INCLUDE directive. It's something the Dockerfile maintainers are very much against and they added a COPY --context directive that kind of does an include, but you need to split things across directories.

We won't find much information in the Docker docs because that's not supported. But Buildah and Podman use a workaround via the C pre-processor. It's mentioned in our docs (https://github.com/containers/libpod/blob/master/docs/podman-build.1.md). The Dockerfile must be suffixed with .in to be pre-processesd.

Given that each of our Dockerfiles would only save 3 to 5 lines and they've not changed a bit in the several months since they've been created, I'm going to close this now. We can reopen if things change later or someone has a brighter idea than I.

Sounds good to me. Thanks a lot for looking into it!

We should really make some noice about Dockerfile.in and Buildah.  We should blog on it, and perhaps making it used within the Repo might be a good way to demonstrate it and make sure we don't break it. Even if there is not much to share.

I blogged on Heise.de about it and also will talk about it on Flock. I can
prepare another blog in English after Flock 👍
On Wed 7. Aug 2019 at 13:44, Daniel J Walsh<EMAIL_ADDRESS>wrote:

We should really make some noice about Dockerfile.in and Buildah. We
should blog on it, and perhaps making it used within the Repo might be a
good way to demonstrate it and make sure we don't break it. Even if there
is not much to share.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/containers/libpod/issues/3292?email_source=notifications&email_token=ACZDRA4B6HYV3XSI7TFKE2LQDKYS5A5CNFSM4HWV3BRKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3YD4BQ#issuecomment-519060998,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACZDRA6OIUOSKBFFUBHN67TQDKYS5ANCNFSM4HWV3BRA
.


Where clause can contain ptr type

https://github.com/tree-sitter/tree-sitter-rust/commit/89b43dcfe5efecdc2a8fae18e187997e1e9e65a2

Thanks for these fixes @calixteman, sorry for letting them sit for a while.


chore(main): release iso-did 1.1.0

:robot: I have created a release beep boop
1.1.0 (2023-05-25)
Features

refactor types and add fission rsa old format (1f8eff6)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/hugomrdias/iso-repo/releases/tag/iso-did-v1.1.0 :sunflower:


Molecule v2

Add infrastructure for testing the role with Molecule
Add nginx_keep_default_configs to parameters in defaults/main.yml
Implement tests covering execution of the role with both default variables as well as overriden variables

Proposed tag: 1.0.1

Now available on Galaxy as https://galaxy.ansible.com/openmicroscopy/nginx


New Template for kit 24.05 Release

Description
This PR introduces better guidance for KIT representatives to participate the release process.
TRG 8.03 is not present, so it has been removed from the Template

Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review:

[X] DEPENDENCIES are up-to-date. Dash license tool. Committers can open IP issues for restricted libs.
[X] Copyright and license header are present on all affected files

...as KIT teams are expecting this template to be available cw14 => may I ask you guys for review and final confirmation @danielmiehle & @maximilianong
afterwards @FaGru3n please merge