Monthly Chat Agenda February 2024 (2024-02-05 and 2024-02-19)

This is the Agenda for the two Monthly CRS Chats.
The general chat is going to happen on https://owasp.slack.com in the channel #coreruleset on Monday, 2024-02-05, at 20:30 CET. That's the 1st Monday of the month. A separate issue chat is happening at the same location, same time on Monday, 2024-02-19. That's the 3rd Monday of the month. Please note that we have a CRS calendar (maintained by @fzipi).
Archived previous meetings and their decision are here.
What happend in the meantime since the chat last month
Outside development

The new OWASP ModSecurity project maintains a page with weekly status updates
OWASP ModSecurity has released version 3.0.12, a security fix for CVE-2024-1019. Release Notes. All ModSecurity v3 users are advised to update to 3.0.12.
CRS developer Andrea theMiddle Menin has left the project and published a blog post disclosing a bug affecting CRS users running CRS v4.0.0-RC1 and v4.0.0-RC2. Users running nightly are not affected. Users on the RC releases are advised to update to nightly.

Inside development
Rules

Hard technical bugs with v4 are fixed, what remains is work on FPs (only major rule left is 932236, is being actively discussed) and non-critical bugs.

CRS Sandbox

With Andrea theMiddle Menin pulling out of the project, the Sandbox is a bit in limbo. Development has stalled for several months anyways, but we need to re-organize that.

Security

:wrench: Longstanding problem V3E has been fixed.
Another decoding problem is on the table. Security implications, but CRS users on stable releases are not affected. We hear OWASP ModSecurity is planning for a solution.
It has been brought to our attention that Andrea theMiddle Menin has reported security issues that he has reported to CRS before in bug bounty programs. The situation is a bit delicate but with his pulling out of the CRS project the situation is cleared up.

Plugins

FP fixes for NextCloud

Documentation and Public Relations

:memo: Blog post: A new silver sponsor for CRS: Swiss Post
:memo: Blog post: Welcome the newest addition to the OWASP family: ModSecurity!
:mega: CRS got a shout-out from the CISO of Swiss Post (the Swiss national post service).
:pencil2: The CRS team assisted with the write-up of the ModSecurity CVE, 2024-1019.

Project Administration and Sponsor relationships

F5 / NGINX has stopped CRS sponsoring. This was expected since they focused more and more on the F5 WAF commercially.
Sponsoring of United Security Providers from Switzerland has not been properly announced. But their logo is on the website.
We need to fill 2-3 vacant sponsoring positions to make up for lost sponsoring

Tools

improved generation of go-ftw schemas, now ready to implement logic for running nginx test suite

Testing incl. Seaweed and many future plans

Quantitative testing for false positive on ARGS proves to be very, very helpful, with lots of improvements made by the team.

Containers

big cleanup of variables
improvements to encryption (proper separation of frontend / proxy encryption)
use non-priviledged nginx image
remove the option to set the user at runtime (never worked properly and doesn't make much sense for containers)

CRS Status Page

On hold until CRSv4 is out

Project discussions and decisions

GSoC 2024: Are we taking part again - the question is in fact open
CRS v4 Release Plan

are plugins included in this plan? if yes, which ones?

#3531 -> PR tries to solve natural language FP in 932236 at PL2 (#3511). BUT if we remove the start of string ^, 8 tests are failing. Is the removing of ^ safe enough and do we want to adjust the tests (some of them BB)? @franbuehler could work on this from Saturday on again or someone else can take it if that's too late.

Rules development, key project numbers
PRs that have been merged since the last meeting

#3528
#3522
#3518
#3462
#3520
#3494
#3519
#3515
#3517
#3516
#3514
#3512
#3506
#3505
#3500
#3513
#3488
#3508
#3507
#3499
#3501
#3411
#3477
#3502
#3473
#3487
#3495
#3492
#3491
#3479

We merged 30 PRs since the last monthly project chat.
Open PRs
Open PRs marked DRAFT or work in progress or needs action

#3531

#3521

#3489

#3485

#3450

#3292

#3431

#3347

#2637

As of Monday, we have FIXME open issues.

As of Monday, we have FIXME open pull requests.

Separate 2nd Meeting (Monday, 2024-02-19)

Plan to tag administrative rules with OWASP_CRS. See https://github.com/coreruleset/coreruleset/pull/3571
Performance measuring
PR #3292 (autosync to documentation project) needs a new shepherd to guide it across the line (a GitHub Actions wizard is needed :magic_wand:)

How to get to our slack and join the meeting?
If you are not yet on the OWASP Slack, here is your invite: https://owasp.org/slack/invite .
Everybody is welcome to join our community chat.

Decisions:

We are not going to participate in GSoC this year. Lack of capacity, new release coming in and also mixed experiences in the past.
CRS release still planned for Feb 14. @dune73 will instruct Alessandro to write blog post / release notes, Xanadu will review afterwards.
We will split the work to finish the changelog. @dune73 will perform the lookup automatically. Then invite @theseion and @RedXanadu to help with the rest.
Reducing FPs for 932236 is on good tracks. @theseion and @RedXanadu are on top of this.

Decisions Feb 19

Debian and Ubuntu package name should be crs, not coreruleset

Installation to /etc/crs/4 and /etc/crs/5 is ok

tag administrative rules with OWASP_CRS: will be added to all rules
Linter should check for the existing tag: @airween


Try to publish tags to ghcr as well

#2

It seems to be taking a very long time to pull the container image. It's approx 3GB which is not that huge, but possibly it is decompression which is a big part for the issue.

e2e tests are broken due to large storage usage. I specifically need to fix those, but gonna break the rules to push this and release the code.


Office key delete response if DNE

Change return response if office key does not exist during delete.

Resolved. Created a function to check if exists and an if chain to catch the logic


wrong install instruction

the install instruction for everyone else is :
Clone the repo and run python setup.py install.
but setup.py doesn't exist

Duplicate of #279 and #282


Docs.MS Release Updates for Azure.Messaging.EventGrid

Update docs metadata and targeting for release of Azure.Messaging.EventGrid

Docs Build status updates of commit 65688bb:
:warning: Validation status: warnings

File
Status
Preview URL
Details

api/overview/azure/messaging.eventgrid-readme-pre.md
:warning:Warning
View
Details

api/overview/azure/ai.metricsadvisor-readme-pre.md
:warning:Warning
View
Details

api/overview/azure/messaging.eventgrid-readme-pre.md

Line 2, Column 1: [Warning-ms-prod-and-service] Only one of the following attributes can exist: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.
Line 9, Column 16: [Warning-ms-prod-technology-invalid] Invalid value for 'ms.technology': 'azure' is not valid with 'ms.prod' value 'azure'.
Line 11, Column 13: [Warning-ms-service-subservice-invalid] Invalid value for 'ms.service': 'eventgrid'.
Line 2, Column 1: [Suggestion-description-missing] Missing required attribute: 'description'.

api/overview/azure/ai.metricsadvisor-readme-pre.md

Line 2, Column 1: [Warning-ms-prod-and-service] Only one of the following attributes can exist: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.
Line 9, Column 16: [Warning-ms-prod-technology-invalid] Invalid value for 'ms.technology': 'azure' is not valid with 'ms.prod' value 'azure'.
Line 11, Column 13: [Warning-ms-service-subservice-invalid] Invalid value for 'ms.service': 'metricsadvisor'.
Line 2, Column 1: [Suggestion-description-missing] Missing required attribute: 'description'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


spec says that you only need CORS headers on OPTIONS requests

... in practice, browsers expect the headers on other requests too.

the homeserver should respond to pre-flight requests and supply Cross-Origin Resource Sharing (CORS) headers on all requests

The last part reads to me like it's required on all requests.

hrm fair. Perhaps I should just read it more carefully. I looked at

When a client approaches the server with a pre-flight (OPTIONS) request, the server should respond with the CORS headers for that route

and inferred that I didn't need to add the CORS headers for other methods

Even that section ends with "on all requests". There's probably some room to make it abundantly clear, however.


Revert to global variable to fix undefined errors in bundles, and fix IIFE endings

Back to where we started :P

Thanks! Hopefully this can be revisited when there's more time.


Nodal locations at local coordinate systems

Hello,
I can obtain/view the different defined coordinate systems via the following command :
"result".geometry['coord systems'][<coord_idx>]
I can also view nodal solutions at different coordinate systems by using the following:
"result".nodal_solution(rnum, coord_idx)
However I was wondering if it were possible to somehow input the <coord_idx> and output the nodal locations (x ,y, z) in the local coordinate system. Think about this working as the APDL command: CSYS ; which activates the <coord_idx> coordinate system. This allows us to get (x, y, z) nodal locations transformed according to coord_idx.
I was wondering if some way already exists to achieve this. Please let me know if the problem has been stated clearly enough.
Thanks.

Sorry for taking so long to get back to you about this.
As of now, pyansys only outputs in the global coordinate system, but I envision that other coordinate systems could be added.

Thanks for getting back.
As of now, I do it the hard coded way in python. But I think it might be simple to implement by creating a function that does it because it is possible to do so on the .rst file using the APDL commands. Typically the corresponding APDL functions can be CSYS, LSYS etc.
It would be great if there can be a python function like TransformedNodesArray = NodalCoordTransform(<coord_idx>) or TransformedResultsVectors = ResultCoordTransform(<coord_idx>)
Let me know if you need any sample case for this project.

If you have a code sample you’d like to post here, please do and I’ll be able to implement it quicker. Please post an example file as well.

Closing stale issue.


fix: replace malicious and deleted package

the package "torchtriton" was removed from pypi after it was discovered that it was utilized to initiate dependency confusion attack over PyTorch. PyTorch since replaced it with "pytorch-triton".
you can read more about it here: https://medium.com/checkmarx-security/py-torch-a-leading-ml-framework-was-poisoned-with-malicious-dependency-e30f88242964

thanks guys. I didn't realize we had that requirement.


Patch Electronic Valve with 'bump up' control scheme

Co-authored-by: acbuynak<EMAIL_ADDRESS>

Tested on hardware.
This code will pulse the UP valve for a short time (50 ms) when halt has been first called. We believe this helps move the (potentially) damaged electronic control valve into the correct stopped position.
Some concern on longevity of this fix as valve may not be robust to this.
A future action should be to replace the electronic control unit on the hydraulic assembly.


Must use Home partition

There seems to be no way to custom partition without a home partition or swap partition.

Right, for now archboot requires home and swap.

Ok, thanks for the clarification. This is a pretty big con for me tbh.

It will be implemented i added enhancement label ;)

nice

Implemented in archboot-dev by 0daed98  refered in Partitioning 2.0


org-journal-previous-entry and org-journal-next-entry opens wrong file

Hi!
Problem
For some reason when I call org-journal-previous-entry, org-journal always opens the oldest journal entry of all instead of the previous entry. When I call org-journal-next-entry, it always opens the last journal entry instead of the next one.
Version
(define-package "org-journal" "20200702.519" "a simple org-mode based journaling mode" '((emacs "25.1") (org "9.1")) :commit "b4b3b2d9854ec9ba98c16098979d2b6b40f54180" :authors '(("Bastian Bechtold") ("Christian Schwarzgruber")) :maintainer '("Bastian Bechtold") :url "http://github.com/bastibe/org-journal")

GNU Emacs 26.3 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.20) of 2020-05-19

Configuration
(custom-set-variables
 '(org-journal-carryover-items "TODO=\"TODO\"|TODO=\"WAIT\"")
 '(org-journal-tag-alist '(("dev" . ?d) ("meeting" . ?m) ("short" . ?s) ("learning" . ?l)))
 '(org-journal-date-format "%A, %Y%m%d")
 '(org-journal-dir "/home/vitor/gpm-org/journal/"))

Investigation
I see that org-journal-open-entry is calling org-journal-list-dates, and then we have this line:
(when prev
      (setq dates (reverse dates)))

If I print dates after this line, it's sorted from smaller to biggest:
((6 3 2019) (6 4 2019) (6 5 2019) ... (7 3 2020) (7 6 2020) (7 7 2020))

I have a feeling that this should be the other way around. Actually if I change the line for
(when (not prev)
      (setq dates (reverse dates)))

it all works. So I'm assuming that org-journal-list-dates was supposed to return the dates in a specific order, but for some reason in this journal it seems to be listing the dates in the reverse order.
Let me know if I can help debugging it further!
EDIT
Added missing configuration.
Added emacs version.

This sure sounds like a bug. Did this behavior change recently? It works correctly in the stable version, as far as I can tell.

@bastibe I actually use more than one journal, and this bug only happens for a specific journal and on some machines. I tried both the stable and dev versions and both had the same issue.
I was wondering: it seems that there is an implicit assumption that org-journal-list-dates returns the dates in a specific order, but I don't see any explicit sorting happening in it, and it ends with (hash-table-values org-journal-dates). Could it be that the hashing algorithim used by different platform or emacs versions, or even the strategy for different file names and dates, could be causing this issue? Would it make sense to put an explicit sorting on org-journal-list-dates?

I stumbled upon that issue as well. But I am not sure, honestly. Most of the development of org-journal has been taken over by @cslux. I would say, let's wait for him to comment on this. Org-journal is really his project these days.

Sorry for letting you guys wait so long.  I guess this related to #264. I'll need to reproduce this may self, preferable with a test. Than I'll fix it.

it seems that there is an implicit assumption that org-journal-list-dates returns the dates in a specific order, but I don't see any explicit sorting happening in it, and it ends with (hash-table-values org-journal-dates)

Indeed, we rely on a specific date order.

Could it be that the hashing algorithim used by different platform or emacs versions, or even the strategy for different file names and dates, could be causing this issue?

I don't know, but can very likely be the case.

Would it make sense to put an explicit sorting on org-journal-list-dates?

That sounds good! But still, it would be nice if we find out what was causing it.

If I print dates after this line, it's sorted from smaller to biggest:

That's correct.
Those are my journal entries.
((11 5 2015) (11 9 2015) (5 1 2017) (2 22 2018) (5 17 2018) (5 18 2018) (6 24 2018) (6 26 2018) (7 3 2018) (7 18 2018) (7 27 2018) (1 13 2019) (3 23 2019) (3 27 2019) (4 13 2019) (4 16 2019) (4 17 2019) (4 21 2019) (4 23 2019) (5 5 2019) (5 18 2019) (6 1 2019) (6 16 2019) (6 30 2019) (7 14 2019) (7 28 2019) (8 11 2019) (8 25 2019) (9 1 2019) (9 8 2019) (9 15 2019) (9 22 2019) (9 30 2019) (10 6 2019) (10 10 2019) (10 13 2019) (10 15 2019) (10 20 2019) (10 25 2019) (10 27 2019) (10 31 2019) (11 3 2019) (11 10 2019) (11 18 2019) (11 23 2019) (12 1 2019) (12 8 2019) (12 15 2019) (12 22 2019) (12 29 2019) (1 5 2020) (1 12 2020) (1 19 2020) (1 26 2020) (2 2 2020) (2 9 2020) (2 16 2020) (2 23 2020) (2 27 2020) (3 1 2020) (3 8 2020) (3 15 2020) (3 22 2020) (3 29 2020) (4 5 2020) (4 13 2020) (4 19 2020) (4 26 2020) (5 3 2020) (5 17 2020) (5 25 2020) (5 31 2020) (6 7 2020) (6 8 2020) (6 14 2020) (6 21 2020) (7 5 2020) (7 6 2020) (7 13 2020))

(when (not prev)
(setq dates (reverse dates)))

That's ok, if the return value of org-journal-list-dates is sorted correctly; oldest -> newest
I have generated daily journal files from my yearly journal files, but so far I wasn't able to reproduce it.

@cslux thanks for taking a look into that.
I must say the behavior seems quite erratic, and I can only reproduce it in a single computer (that I use for work, so it's hard to find the time to debug it). But the exact same files on my personal pc (exact same as in it's a shared in a cloud synchronization services without any exception rule) work just fine. I'm running different emacs versions though (the bug happens on 26.3, and my personal pc is in 27.0.91).
I still think the issue is that we can not assume hash-table-values  will return the values of the hash table in any predictable order. I tried to find some information about the hashing algorithim in emacs but I couldn't find anything useful. But the documentation for hash-table-values does not guarantee it will be sorted in any way, and that's usually the case for hashing maps in most languages.
But since you see the same ordering in your journal, I'll try to find some time tomorrow to dig more into this and see if I find anything else. I'll post it here if I do :)

@cslux So, that's the flow on the pc with the bug, when I'm in 2020-07-15 and I'm opening the previous entry:

(org-journal-list-dates) returns dates ordered from bigger->smaller (newest->oldest) at line 10.
(when prev (setq dates (reverse dates)) at lines 22/23 resorts it into smaller->bigger (oldest->newest).
When we reach the while at line 24, the first date on dates is lower (older) than the calendar-date (e.g. in my debugging, (car dates) is (6 3 2019) and calendar-date is (7 15 2020)).
The or condition on line 25 is not met since both (calendar-date-compare (list calendar-date) dates) and (calendar-date-equal (car dates) calendar-date)) return nil
Line 31 is reached, the (car dates) returns (6 3 2019), and that's the file that ends up being opened.

1  >(defun org-journal-open-entry (&optional prev no-select)
2  >  "Open journal entry.
3  >If no next/previous entry was found print MSG."
4  >  (let ((calendar-date (if (org-journal-daily-p)
5  >                           (org-journal-file-name->calendar-date (file-truename (buffer-file-name)))
6  >                         (while (org-up-heading-safe))
7  >                         (org-journal-entry-date->calendar-date)))
8  >        (view-mode-p view-mode)
9  >        (dates (org-journal-list-dates)))
10 >    (unless (member calendar-date dates)
11 >      ;; Insert calendar-date into dates list keeping it in order.
12 >      (setq dates (cl-loop
13 >                     for date in dates
14 >                     while (calendar-date-compare (list date) (list calendar-date))
15 >                     collect date into result and count t into cnt
16 >                     finally return (if result
17 >                                        ;; Front
18 >                                        `(,@result ,calendar-date)
19 >                                      ;; Somewhere enbetween or end of dates
20 >                                      `(,calendar-date ,@result ,@(nthcdr cnt dates))))))
21 >    ;; Reverse list for previous search.
22 >    (when prev
23 >      (setq dates (reverse dates)))
24 >    (while (and dates (car dates)
25 >                (or (if prev
26 >                        (calendar-date-compare (list calendar-date) dates)
27 >                      (calendar-date-compare dates (list calendar-date)))
28 >                    (calendar-date-equal (car dates) calendar-date)))
29 >      (setq dates (cdr dates)))
30 >    (if (and dates (car dates))
31 >        (let* ((date (car dates))
32 >               (time (org-journal-calendar-date->time date))
33 >               (filename (org-journal-get-entry-path time)))
34 >          (if (get-file-buffer filename)
35 >              (progn
36 >                (if no-select
37 >                    (set-buffer (get-file-buffer filename))
38 >                  (switch-to-buffer (get-file-buffer filename)))
39 >                (setq org-journal--kill-buffer nil))
40 >            (push (if no-select
41 >                      (set-buffer (find-file-noselect filename))
42 >                    (find-file filename))
43 >                  org-journal--kill-buffer))
44 >          (org-journal-goto-entry date)
45 >          (view-mode (if view-mode-p 1 -1))
46 >          t)
47 >      nil)))

@vitorqb Thanks for helping. Interesting, org-journal-list-dates returns the dates sorted from oldest -> newest for me, which would be the expected order, not newest -> oldest. Which means (hash-table-values org-journal-dates) returns the dates for you in the order newest -> oldest, instead of oldest -> newest. I'll add something to insure we always get the dates sorted from oldest -> newest.

Should be fixed with commit cf1017b7e6e70d73ab691835e758b15a1ac8b3b0. Thanks for your help @vitorqb.


Wire turrets when parented in x64 singleplayer don't work correctly

Parented turrets don't fire in the direction they're "facing"
Video demonstration; https://youtu.be/QcYkqBQM6WE
Replicated by multi parenting a turret to a prop, then firing the turret

Yes they do, @Anticept just needs to update workshop

ty!


Arbitrary Colorspace and conversion support

🙋 Feature Request

We want some way for users to bring their own color space conversions to React Spectrum's color picking type components.
The first step will be to define some API's to show how we'd like to handle this.
🤔 Expected Behavior

😯 Current Behavior

Users are locked into using RGB/HSL/HSB, if they want another color space supported they have to add it to React Spectrum, they have no say on how many decimal places we carry certain values out to, and they have no say on how we convert between color spaces.
💁 Possible Solution

A Plugin architecture is probably the way to go.
🔦 Context

We don't want to be in the business of performing color conversions. Applications have vastly different needs, be it precision, accuracy, or which color spaces they handle, and we don't want to force a large bundle size to fit everyone's needs.
💻 Examples

🧢 Your Company/Team

🎁 Tracking Ticket (optional)

Stale


Starting the GUI from Command Prompt

Describe the bug
Starting ngrokGUI.exe works fine like normal, but when starting it from cmd it throws an error instead. It's the only time it throws this error and doesn't want to open.
To Reproduce
Steps to reproduce the behavior:

Open Command Prompt (type cmd in Windows search);
Enter start "" "C:\Program Files\ngrok\ngrokGUI.exe" with it pointing to the GUI's location;
See error:

Expected behavior
Having the GUI open like normal when it's run from cmd.
Desktop:

OS: Windows 10 Pro
Version 19043.1288

let me check that :)

Dear @snakehill
Can you try again ?

Perfect! Works as a charm now!
Thank you so much! You have deserved some coffee (incoming shortly).

Thanks sooo much :D <3


Update Github Gist extension

Description
Update Github Gist extension
Screencast

Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed outside of the metadata folder

Hi, @fe9lix Please review this new PR
Regarding the issue of modifying PipeCommand, I have a feeling that there is something wrong with the master branch. I have basically the same commit time as Add Visual-Studio-Code snippet manager extention #1322  that also has a PepeCommand changelog file.He also modified the PepeCommand changelog file.
But I am not modifying other files except pulling from the remote side to updat.
@fe9lix @pomdtr, So can you speculate on the cause? Regarding why there are file changes in the PR for other extensions.
Is it because we are doing Git the wrong way?

@koinzhang Master branch looks fine to me. Git is a bit messy with case changes (changelog.md and CHANGELOG.md – the former was deleted on main), afaik it should typically done with git mv -f .... If you browse the pipe-commands folder here on Github, you can see that there's only a single CHANGELOG.md now, so that is fine.

@koinzhang Main branch looks fine to me. Git is a bit messy with case changes (changelog.md and CHANGELOG.md – the former was deleted on main), afaik it should typically done with git mv -f .... If you browse the pipe-commands folder here on Github, you can see that there's only a single CHANGELOG.md now, so that is fine.

@fe9lix
Thank you for your explanation, I will pay more attention in submitting PR in the future.
👍Re-pulling the branch to submit PR is always the easiest way to solve.


Consider making authorisation mechanism for reading the metadata

@holycrab13  could you post the options to configure the databus? private-mode=true ? or did you document it somewhere?
What about hiding the sparql endpoint?

Needs the environment variable
DATABUS_PRIVATE_MODE=true
SPARQL endpoint is hidden when not logged in.
Added an entry in the advanced configuration chapter in the gitbook

Issue can potentially be closed

Refs #23


Orange Tinted Screen After Running Debloater.

I ran it and now it's orange and I need a fix.

Never mind, I used Display Calibration in Color Management to fix it.

I'm experiencing the same thing, but with three different monitors that have different color capabilities such as HDR.

What video card are you using? I wonder if it is affecting video drivers for AMD and NVIDIA, or both.
Sent from my iPhone

On Jun 12, 2021, at 9:56 PM, Jordan Wages @.***> wrote:

I'm experiencing the same thing, but with three different monitors that have different color capabilities such as HDR.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

I'm using an  NVIDIA GTX 1060, Game Ready Driver version 466.77.

I think this has something to do with the Night Light setting.
Turning it on and off remove the orange tint, but it comes back when I restart.


Support an array of zookeepers hosts entries just like both the mesos…

… and zookeeper modules
Signed-off-by: Salimane Adjao Moustapha<EMAIL_ADDRESS>

*/+
wq3.00127414


Fix typo

/github action/i -> GitHub Actions

@changeworld : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Thanks, @changeworld!
#sign-off


refactor(Data/Sym/Sym2): simplify decidability instances

There shouldn't be any need for a custom boolean algorithm here, typeclass search can find it.
Removes a porting comment from #1805  about boolEq, which isn't needed after all.

bors merge


Current b:match_words does not work very well for vim9script functions

Describe the bug
The current b:match_words for vimscript files does not work very well with vim9script functions. Pressing % (provided by matchit) won't jump to the next enddef when the cursor is on return inside a :def function.
The following patch seems to fix this (thanks to @andymass):
--- /tmp/vim.vim
+++ /usr/share/vim/vim82/ftplugin/vim.vim
@@ -83,7 +83,8 @@
 if exists("loaded_matchit")
   let b:match_ignorecase = 0
   let b:match_words =
-	\ '\<\%(fu\%[nction]\|def\)\>:\<retu\%[rn]\>:\<\%(endf\%[unction]\|enddef\)\>,' .
+	\ '\<fu\%[nction]\>:\<retu\%[rn]\>:\<endf\%[unction]\>,' .
+	\ '\<def\>:\<retu\%[rn]\>:\<enddef\>,' .
  	\ '\<\(wh\%[ile]\|for\)\>:\<brea\%[k]\>:\<con\%[tinue]\>:\<end\(w\%[hile]\|fo\%[r]\)\>,' .
 	\ '\<if\>:\<el\%[seif]\>:\<en\%[dif]\>,' .
 	\ '{:},' .

Affected by this are also other plugins utilizing b:match_words, see https://github.com/andymass/vim-matchup/issues/96.
Environment
Vim version 8.2.983

Thanks.  I thought I tried this and it didn't work.  But your change (in reverse) appears to work.  I'll include it.

closing then.


i18n(fr): Fix typo

What kind of changes does this PR include?

Minor content fixes (broken links, typos, etc.)

Description

Just fixed some French spelling mistakes

Merci, @jdbruxelles! Thank you for your attention to detail, and a great first-time contribution to help us present a more polished page!
If you're interested in contributing more with our translation efforts, please do join our Discord and swing by the #docs / #i18n channels! We are always in need of PR reviewers to support the efforts of translators, too, so feel free to watch this space and review any existing [fr] PRs you see here.  :)

Ok, thank. I'll do it soon.


dep prune breaks installation of vendored package

What version of dep are you using (dep version)?
0.3.2 via Homebrew
What dep command did you run?
Gopkg.toml
required = ["github.com/urfave/cli", "gopkg.in/yaml.v2"]

[[constraint]]
  name = "github.com/Workiva/frugal"
  version = "2.12.0"

main.go
package main

import (
	"fmt"

	frugal "github.com/Workiva/frugal/lib/go"
)

func main() {
	ctx := frugal.NewFContext("")

	fmt.Printf("Hello pruned frugal! %v\n", ctx.CorrelationID())
}

bash command sequence
$ dep ensure
$ dep prune
$ cd vendor/github.com/Workiva/frugal
$ go install .

What did you expect to see?
A happy executable frugal command in my GOPATH/bin.
What did you see instead?
can't load package: package github.com/Workiva/dep_prune_issue/vendor.orig/github.com/Workiva/frugal: cannot find package "github.com/Workiva/dep_prune_issue/vendor.orig/github.com/Workiva/frugal" in any of:
	/usr/local/Cellar/Go/1.9.2/libexec/src/github.com/Workiva/dep_prune_issue/vendor.orig/github.com/Workiva/frugal (from $GOROOT)
	/Users/markcampanelli/dev/go_dep/src/github.com/Workiva/dep_prune_issue/vendor.orig/github.com/Workiva/frugal (from $GOPATH)

This is not a bug.
Since github.com/Workiva/frugal is a main package you need to add it to required yourself as dep won't include it in the dep graph.


Further decouple justification and finalisation

Addresses @djrtwo's comment here. Also gets rid of antepenultimate_.

handled merge conflict. leaving it to you @JustinDrake to merge


#27test coverage reports

You can see the reports produced in the tick next to the commit. I'm assuming that there will be more detail when the .R files are changed as that's what it's set up to cover, but haven't tested that yet. When I come to the unit tests issue I'll look at the output in more detail.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@5634a0d). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #54   +/-   ##
=========================================
  Coverage          ?   50.83%
=========================================
  Files             ?        7
  Lines             ?      120
  Branches          ?        0
=========================================
  Hits              ?       61
  Misses            ?       59
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5634a0d...89eb8f5. Read the comment docs.

Great thanks!
FYI - there was a minor merge conflict in the DESCRIPTION file for some reason


Removes trailing semi colons from javascript in on-page

Working in VS Code on a template page that is using  blocks for javascript.
The formatter removes the semicolons.
Is this fixable, or a bug?

formatted by prettier, can automatic search prettier config file in the dirs, such as .prettierrc, .prettier.json...;
so you can config to keep or remove semi
please read prettier's config referrence


No longer can set className props

It appears that you can no longer write to the child.props.className in the latest version of React. Is there a workaround we can implement into this project, or is this method of autogenerating class names dead?

The way I've seen other modules work around this is by modifying the props and then applying them to a clone of the element, see https://github.com/unicorn-standard/react-pacomo/blob/master/src/pacomo.js

Hey @idmontie,
I've been meaning to update react-bem to work similarly to react-pacomo for a few months, so it's definitely possible. I just haven't gotten around to it yet /=
Pull requests are definitely welcome [=
Cheers,

Alright, I opened up a pull request. I haven't updated any tests for it yet (the tests time out on my machine). Let's do some code review on the PR.

Hey @idmontie,
At first glance, there's a few issues. The version of React in package.json wasn't updated, so it's hard to tell if it would work with the most recent version of React, but I'm pretty sure it won't work with the version of React in the package.json.
Also, this repo is written in es5, so a lot of the es6 features like let, const, of, => and string interpolation won't work.
Finally, the transform method was removed--which is the public interface for the BEMTransformer that ReactBEM calls in it's render method. Because of that, all of the tests fail.
It looks like it's on the right track, though.
To get the tests running, you should only need to run:
npm install
grunt test```

If you can send me the errors your getting if that doesn't work, that would be helpful.

Thanks!

Alright, on my local, I've got the tests running, but what is interesting is that the tests are failing because React changed its interface.
For example, the bem_exists method in react-bem.test.js is throwing an exception because el.type is undefined.
findRenderedDOMComponentWithClass should return a ReactComponent (as specified in its docs), but it is returning the DOM node instead, which means you can't get it's type.
A DOM node however has a "private" member named "_reactInternalComponent" which has a "_type", but that looks like something that can change in the future.


Conditions: Ignore Links

Goal: NOT delete message IF link OR attachment. I currently don't see another way of achieving this without having to build a custom command. Having the ability to "Ignore links" or "Ignore message matching regex" would be much simpler.

We do have a trigger that's called Messages not matches regex

Seems like I didn't read your goal properly. What you're trying to accomplish is a two-step process which cannot be accomplished with amv2 without either new conditions, or a way to make triggers AND (as opposed to the current OR). Here's a basic idea of what the process should be like:
With the addition of new conditions

• System gets triggered on a message without any attachments. (Trigger)
• System checks if this message doesn't have a link either. (Condition)
• System deletes the message. (Effect)
The same thing can be done by triggering on messages without links and setting the condition to messages without attachments. This however seems to be redundant with similar triggers and conditions.

With a way to make triggers AND

• From boolean logic, we can tell that (not X) or (not Y) is the same as not (X AND Y). In your case, this becomes (message doesn't have attachments) AND (message doesn't have links).
• You set two triggers and enable a switch to make triggers AND.
• System gets triggered only when both are satisfied and deletes the message.
This seems to be a much better solution to the problem because it doesn't involve addition of new conditions and allows making all sorts of combinations with triggers.

So adding new triggers won't do any good. For now, custom commands are the best option available, given how they can be customised like this, and in fact to a greater extent. We even have a custom command template available on the server which works in a similar fashion. Implementing such a change in the system (the AND switch option, not the first) seems to be a fairly big (but definitely a good addition).

Thanks for the detailed reply! I will make a custom command. As you mentioned, I do think that having the ability to switch to AND from OR would allow for way more flexibility! Is the dev team planning to implement such feature?


throttler: Split the throttler configuration into more fine-grained fields.

min_duration_between_changes_sec was split into separate "increases" and "decreases" fields.
This is required because an insert test needs to wait longer than a decrease test.
Additionally, there is a new field "spread_backlog_across_sec". Before this change, the value of "min_duration_between_changes_sec" was used for this.

LGTM
(we could make the proto change backwards compatible, but probably not worth it).

(we could make the proto change backwards compatible, but probably not worth it).

Yes, that was my thinking as well :)


Sync olp::utils::LruCache with hf::container::LruCache

Make implementation of olp::utils::LruCache similar
to hf::container::LruCache. Change usage of custom
hf::container::HashFunction to std::hash function.
Relates-To: OLPEDGE-1590
Signed-off-by: Liubov Didkivska<EMAIL_ADDRESS>

This is a huge API break. Can we not just sync internals, instead of everything?

Updated. API is adjusted to current one.

This commit is too huge. Please split up.
Also please consider using std::unordered_map instead of the internal UnorderedMap. I dont think we need the full speed of the internal UnorderedMap which is mostly designed for tuff performance uses case (Routing or rendering) which we will not face for now.

Changing to std::unordered_map will affect implementation of LruCache, as UnorderedMap implemented some advanced futures for example indexing, and have some differences in API compared to std::unordered_map. We can implement using std::unordered_map, but it could look more similar to current LruCache implementation.


Saved image is incorrectly rotated - picture orientation does not match the preview orientation.

Steps to reproduce

Create react native app using sample code provided in README.md
Run app on a Nexus 9 (or any device whose default orientation is landscape not portrait)
Hold device in portrait mode and Take a picture. (Picture is now saved)
Open picture. The picture is rotated incorrectly. It's sideways

Expected behaviour
Saved Picture should retain the same orientation as when taken.
Actual behaviour
Saved Pictured orientation is incorrectly rotated
Environment

Node.js version:  5.2.0
React Native version: 0.21
React Native platform + platform version: iOS 9.0, Android 5.0, etc Android 6

react-native-camera
Version: npm version or "master"

+1

This is happening because on most SAMSUNGs and some other devices the orientation information is saved in EXIF metadata tag. You have to use this information if you want to properly visualize this picture. Take a look here for more info http://stackoverflow.com/questions/28298956/captured-image-getting-rotated-on-nexus-9

Guys I made a PR which is suppose to fix the locked orientation problem. This might fix the Nexus 9 issue too https://github.com/lwansbrough/react-native-camera/pull/232

+1 any further resolution on this? Trying to work with react-native-camera on google pixel 7.1.2. Also utilizing react-native-orientation-lock in landscape mode..

+1

Short term fix: we used the react-native-camera, orientation={Camera.constants.Orientation.landscapeLeft}, in conjunction with react-native-image-resizer: ex. ImageResizer.createResizedImage(data.path, 640, 480, 'JPEG', 100, 0)), the last number, 0, specifying the rotation, as well as react-native-orientation: Orientation.lockToLandscape().

+1

+1

+1

https://github.com/react-native-community/react-native-camera/pull/735


[chip-tool] Get the commissioner to be an optional argument for chip …

…related commands instead of a dedicated command that stores the current commissioner on disk
Problem
In order to switch between commissioners with chip-tool, one needs to run the configure-fabric command. Now that chip-tool supports optional arguments it is much more convenient to use an optional argument.
Change overview

Remove the configure-fabric command
Move the current configure fabric from beeing store on disk to an optional argument

Testing
Update scripts/tests/test_suites.sh to use the "beta" commissioner

Fast tracking given this is adding testing tools.

/rebase


[BUG]: AzureStaticWebApp@0 gets permission denied error when executed on self-hosted agent

New issue checklist

[X] I searched for existing GitHub issues
[X] I read pipeline troubleshooting guide
[X] I checked how to collect logs

Task name
AzureStaticWebApp
Task version
0
Issue Description
When task is executed some files are created in Build.SourcesDirectory.
For me this is the app/public directory for a Hugo app, this is the output from the build process.
When pipeline is executed on hosted agent each build gets clean workspace, so there are no output files from previous build. In this case everything is ok.
But when pipeline is executed on self-hosted agent the next build fails at git checkout task because git clean cannot remove output files which are generated within git workspace directory. Execution fails with many errors like this one:
##[error]System.UnauthorizedAccessException: Access to the path '/home/***/agent-1/_work/8/s/app/public/index.xml' is denied.
The reason is that files generated as output from the task are owned by different user than user under which agent is executed. This different user is an user under which Docker daemon is running, because as I've learned AzureStaticWebApp task is performed by running Docker container.
The public folder which is the output from Hugo is owned by root
Environment type (Please select at least one enviroment where you face this issue)

[ ] Self-Hosted
[ ] Microsoft Hosted
[ ] VMSS Pool
[ ] Container

Azure DevOps Server type
dev.azure.com (formerly visualstudio.com)
Azure DevOps Server Version (if applicable)
No response
Operation system
Ubuntu 20
Relevant log output
git version
git version 2.40.1
git lfs version
git-lfs/3.3.0 (GitHub; linux amd64; go 1.19.3)
git config --get remote.origin.url
##[warning]'git config --get remote.origin.url' failed with exit code: 1, output: ''
##[error]One or several exceptions have been occurred.
##[error]System.UnauthorizedAccessException: Access to the path '/home/***/agent-1/_work/8/s/app/public/index.xml' is denied.
 ---> System.IO.IOException: Permission denied
   --- End of inner exception stack trace ---
   at System.IO.FileSystem.DeleteFile(String fullPath)
   at System.IO.FileInfo.Delete()
   at Microsoft.VisualStudio.Services.Agent.Util.IOUtil.<>c__DisplayClass11_0.<DeleteDirectory>b__0(FileSystemInfo item) in /home/vsts/work/1/s/src/Agent.Sdk/Util/IOUtil.cs:line 152
   at System.Linq.Parallel.ForAllOperator`1.ForAllEnumerator`1.MoveNext(TInput& currentElement, Int32& currentKey)
   at System.Linq.Parallel.ForAllSpoolingTask`2.SpoolingWork()
   at System.Linq.Parallel.SpoolingTaskBase.Work()
   at System.Linq.Parallel.QueryTask.BaseWork(Object unused)
   at System.Linq.Parallel.QueryTask.RunTaskSynchronously(Object o)
   at System.Threading.Tasks.Task.InnerInvoke()
   at System.Threading.Tasks.Task.<>c.<.cctor>b__272_0(Object obj)
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
--- End of stack trace from previous location ---
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
   at System.Threading.Tasks.Task.ExecuteWithThreadLocal(Task& currentTaskSlot, Thread threadPoolThread)

Full task logs with system.debug enabled

 [REPLACE THIS WITH YOUR INFORMATION]

Repro steps
No response

Still an issue


[BUG] Stuck on "2FA" need help.

Before submitting a bug report...

[ ] This bug wasn't already reported.
(I have checked every bug report on GitHub)

Title

[ ] The title is no longer "[BUG] Title" and I edited it with the right error name.

Describe the bug
Dont know how to disable this 2fa, when clicking enter it does nothing. need help
Copy and paste your error
2023-11-30 11:57:07,287 [ERROR] [LOGIN] 2FA required !
2023-11-30 11:57:07,296 [INFO] [LOGIN] Press enter when confirmed...
Screenshots

Value of dashboard variable
dk what this is

I'm having the same issue, After authenticating and pressing enter it still just sits.

execute the command with -v and you can complete the "2FA" on the browser

execute the command with -v and you can complete the "2FA" on the browser

how do i do this?


Better README

I think that readme is a bit incomplete. My  proposal for improve it is this:
In  installation or usage via NPM/Yarn I  suggest to specify different ways to use it via modules:
For example import via js:
import multi from "multi.js/dist/multi-es6.min.js";
import 'multi.js/src/multi.css';
var select = document.getElementById("fruit_select");
multi(select);

Or another option is import js via module and styles via SASS:
@import 'multi.js/src/multi.css';
If you want I can  make a PR including these two steps in README
Thanx!

Please do make a PR, those are always appreciated! :)

This is the PR:https://github.com/fabianlindfors/multi.js/pull/42.
Thanx!


Should be able to update installed neo4j version with rake tasks

Maybe just running rake neo4j:install[version] again would do this.  Should leave data and conf intact, I think.  Right now it puts the folder neo4j-community-2.1.5 inside the db/neo4j/development directory for me.  Spent a little time trying to fix but was having trouble getting pry to get me in there, wanted to create an issue so that I didn't forget.

Moved to https://github.com/neo4jrb/neo4j-rake_tasks/issues/3


build(sync-ts-config): integrating the weaver packages to the monorepo build

Commit to be reviewed

build(sync-ts-config): integrating the weaver packages to the monorepo build
Primary Changes
---------------

1. Relocated tsconfig file to cacti-plugin-weaver-driver-fabric
2. Added comment regarding the other package not having tsconfig and will be ignoring till then

Fixes: #3366
Related to: #3069
Pull Request Requirements

[x] Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
[x] Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
[x] Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

[x] Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
[x] Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

@petermetz I have updated my branch and repush this PR. I can't see the weaver CI job that is failing. I have also tried to look into past latest commit in the main repo and looked for weaver that are failing and didn't see one. I would like to know the specific weaver job that is failing on your end, thank you

The folders added to the ignore list are modules and sample apps that are used in the Weaver test harnesses (see list posted by Michal above).
I'm not sure what the purpose of this PR is. Could you clarify, @ruzell22 ?
Is there a requirement for TypeScript packages to have a tsconfig.json, @petermetz ?
We are undertaking an integration of Weaver packages into the Cacti monorepo, and one of our mentees (Jennifer Bell) is addressing part of that process. The cacti-weaver-driver-fabric package was sort-of integrated into the monorepo as an experiment, whereby a shell package was created in the packages folder with a symlink to the actual source code within the weaver folder. We plan to do something similar for other packages as a stopgap measure before a more comprehensive integration (as per our envisioned architecture, see ROADMAP.md) is done, which will take a while.
But whether or not a package contains a tsconfig.json or not shouldn't matter IMO.
@ruzell22 If you are interested in exposing all other Weaver packages the way I described above for the Fabric Driver, be my guest. @sandeepnRES and I can advise you on that and you can submit a comprehensive PR then.

Is there a requirement for TypeScript packages to have a tsconfig.json, @petermetz ?

@VRamakrishna It's not. Longer term, I'd love it if it was, but because I also don't want to slow down teams working on code who aren't there yet (as in not ready to have Typescript instead of Javascript).
The vision: It would be a nice bump for developer experience if the Typescript compiler was checking all NodeJS/browser source code. It makes entire classes of bugs impossible (not nearly all of them, but small wins are good too).

But whether or not a package contains a tsconfig.json or not shouldn't matter IMO.

The reason why it matters is because the automation is currently broken (it assumes that there is a tsconfig.json for all nodejs packages in the monorepo).
So we definitely need that portion of the PR that makes it so that certain directories are ignored by the script.
The part of the diff that moves around the tsconfig.json file that's in the weaver package can be removed (so that the PR only makes the change to the script under ./tools/ and then we can continue the discussion about the integration tasks in another PR/issue thread.

Please see my comment in the thread above. I'd recommend closing this PR and working with us on a separate PR if you are interested in carrying out integration tasks.

@VRamakrishna Have you seen this thread? https://github.com/hyperledger/cacti/issues/3366#issuecomment-2216674164

@ruzell22 Please remove the part of the diff that moves around the tsconfig.json file so that it only changes ./tools/ and that way we can simplify the review process. Please also make sure to update the ignore patterns as necessary so that the sync ts config script completes successfully.
After making those changes please re-request review from everyone to make sure.

@petermetz I have updated my repo and remove the moving of tsconfig.json. After re-running the yarn run sync-ts-config , the updated ignore patterns are the same as the one in #3367 that has been merged already. I guess this ticket and the PR can be marked as close since it will not make changes in code after the updated ignore patterns

@petermetz Let's close this as @ruzell22 asked for, unless you see a reason to merge it. As @sandeepnRES says above, this doesn't do anything other than change a whitespace.


##[warning]Task 'Robocopy' (1.1.0) is using deprecated task execution handler. The task should use the supported task-lib: https://aka.ms/tasklib

Azure devops always throws this warning when running this task.  It seems they changed the way the ui displays warnings which makes this more prominent.
##[warning]Task 'Robocopy' (1.1.0) is using deprecated task execution handler. The task should use the supported task-lib: https://aka.ms/tasklib

I'm just confirming that I observe the same behavior.

Also here the same.

Still getting it
##[warning]Task 'Robocopy' (1.1.5) is using deprecated task execution handler. The task should use the supported task-lib: https://aka.ms/tasklib

Also receiving the warning on the latest version, 1.1.5.

+1 getting same message

This is still looming.
It's gonna break some day...


AmneziaWG plugin library request

Could there be a possibility to have the AmneziaWG WireGuard obfuscation method available as a C/C++/Rust library? Some of my users are interested in AmneziaWG support for the WireSock VPN Client, and having such a library would simplify integration and allow for future enhancements.

https://github.com/amnezia-vpn/amneziawg-windows-client
https://github.com/amnezia-vpn/amneziawg-go

It would be significantly more convenient to have a reference implementation in the form of a library rather than extracting the relevant functions from the WireGuard source code.

btw why not open source wiresock? :)

Major parts of the WireSock implementation are already open source—such as ndisapi (excluding the driver), boringtun, and shared utility C++ classes, which are also available in ProxiFyre. I don’t believe that fully open-sourcing WireSock would offer any substantial benefits to the project. When ProxiFyre was made open source, it didn’t notably accelerate the project’s development, and some parts were even reused commercially without contributing back. Given that WireSock is a much more complex system, the potential downsides—such as the risk of its components being exploited commercially without reciprocal benefits—raise serious questions about how open-sourcing it would truly aid its progress.

I used wiresock before the protocol was blocked in Russia. It worked just perfectly, Oh, how I wish there was at least some way to use AmneziaWG with normal application tunneling. And ideally with good routing and the ability to add domains

Could you please provide more details on what you mean by “ability to add domains”?

It is possible to add the AllowedIPs parameter in the wireguard config. Wiresock adds the ability to add AllowedApps to the wireguard config. In my fantasies it would be cool to be able to use AllowedDomains to bypass blocking individual sites by their domain respectively.
The thing is that I tried to use known ip lists for youtube or discord. For example from here https://iplist.opencck.org/ with the same AmneziaVPN or v2ray and in the end it opens many unnecessary sites through VPN connection. And I'm talking about thousands of exact Ipv4 addresses not about CIDR.
But as far as I understand the wireguard protocol itself works only with ip and if it is possible, it will be a huge job

Since many domains on CDNs share the same IP, filtering by domain at the IP level becomes impractical. This shared infrastructure means that the decision to route traffic via VPN has to happen as soon as the initial TCP SYN packet is sent, which is before the TLS handshake reveals the SNI (Server Name Indication) and, by extension, the domain. Without SNI data, accurately routing by domain becomes nearly impossible.
Implementing domain-based filtering would require an additional DNS-aware layer, essentially watching DNS traffic and tracking which domains resolve to which IPs. This layer could attempt to “guess” the destination domain when a connection targets an IP that a recent DNS query resolved to. However, this approach has limitations: IPs change frequently, CDNs dynamically assign them, and multiple domains often share the same IP at different times.


Use Helm Upgrade for installs as well

Need to check whether using Upgrade with install option improves performance.

the helm upgrade --install is checked in the cmd/helm/upgrade.go , the test is done by checking if _, err := histClient.Run(args[0]); err == driver.ErrReleaseNotFound {. If the check is true, helms runs the Install action, otherwise Upgrade.
From performance point of view it is exactly what is doing in blue mix_controller.go. In addition, we don't have access to the methods in cmd/helm

So, what is the conclusion regarding Install option in Upgrade params? Is it just for documentation as written in the comments?

No, it does allow to install a new chart during its upgrade.  However,  it is done in the cmd/helm package by a package available functions, WE cannot use it.
You can close the issue.

No, it does allow to install a new chart during its upgrade. However, it is done in the cmd/helm package by a package available functions, WE cannot use it. You can close the issue.

@roytman Why can't we use it?

when helm run as a CLI command, it is going first to the Cobra "commands" in the cmd/helm package. The newUpgradeCmd function  (put attention on its visibility) checks if the install flag is set, and if it is && the release is not deployed, instead of the Upgrade action, it creates and runs the Install action.
Actually we do the same, we check if the release is deployed and if not we Install it, otherwise we upgrade it.
We don't use the commands from the cmd/helm package and use directly the actions.
The only one way to use the feature (and maybe others ) is to run helm operations as an external CLI command.

OK.  Thanks for the explanation.  @roytman


Error Login

Please do not use the version from the releases, do a git clone and use a fresh MySQL database. Please make sure that you have set the settings correctly without spelling mistakes.

How are you running your site?

Actually nvm, this seems to be a configuration error from your side, did you add https/http to your pterodactyl domain in settings.yml?

Please do not use the version from the releases, do a git clone and use a fresh MySQL database. Please make sure that you have set the settings correctly without spelling mistakes.

I will release a new version whenever i have time to fix bugs


how do I use docker.for.mac.localhost within docker-compose.yml file?

File: docker-for-mac/networking.md, CC @gbarr01
the page mentions that I may use the special variable, docker.for.mac.localhost, to access the external IP of the mac host. However, the documentation does not explain how to use this variable within a docker-compose.yml file. Could you add some documentation to show an example of how this variable can be used in the docker-compose.yml file?

Closing this ticket due to its age, and the impending refactor. If you think this is in error, feel free to reopen. Thanks!


Remove references to knative.dev/pkg

Tell us about your request
Right now, we are using various libraries and utilities in knative.dev/pkg. We should knock out references to knative.dev/pkg to not depend on that package directly by removing the following uses for it:

[x] Initializing our logger and configuring a dynamic watch on the zap-config
[ ] Leveraging the knative logger with logging.FromContext rather than using the default controller-runtime logger: #922
[ ] Setting up our webhook server for webhook requests
[ ] Dynamically reconciling webhook certificates in the MutatingWebhookConfigurations
[ ] StatusConditions operations on Custom Resources (Machines) in the project

We'd like to move away from having direct reliance on knative.dev/pkg. This library has bottlenecked our ability to upgrade to the latest client packages of client-go, which may eventually bottleneck Karpenter's ability to support newer versions of K8s as APIs evolve.
Tell us about the problem you're trying to solve. What are you trying to do, and why is it hard?
N/A
Are you currently working around this issue?
N/A
Additional Context
No response
Attachments
No response
Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

Also, https://github.com/kubernetes-sigs/karpenter/blob/48d8ee3103657592dcc1c58ebbbc8fe692c78540/pkg/apis/crds/karpenter.sh_nodeclaims.yaml#L325 mentions KNative - perhaps as a side-effect?

We should migrate the logger that is being initialized through knative-style functions to use the default controller-runtime logger that is injected into the controller Reconcile context by default: #922

/remove-lifecycle stale

/lifecycle frozen


dl: remove older versions of go

Currently there are 96 versions of go, of which 13 release candidate and 13 beta.
What about removing, for Go <= 1.x, all intermediate versions, keeping only the last patched version?
The full list is:

go1.5.4
go1.6.4
go1.7.6
go1.8.7
go1.9.7
go1.10.8
go1.11.9
go1.12.9
go1.13.8

FWIW, I find it quite convenient to be able to also quickly and easily fetch old release candidates, beta versions and "outdated" point releases when tracking down regressions. I'd thus propose to keep these versions.

You can always fetch any versions by cloning the dl repository, run the genv tool followed by go get.
The possible problems with having all versions are:

Long list of packages in https://godoc.org/golang.org/dl
(assuming people actually look at the documentation)
Accidentally downloading an old version

They are not really strong points, so I guess keeping the old version is not a problem.

Thanks for the suggestion.
We generally don't remove old packages. When they're no longer developed, we freeze them, and when they're redundant or unnecessary, we deprecate them.
Old golang.org/dl/... packages are helpful for people who want to try old versions of Go, perhaps to compare something against a newer version. Issue #37156 is just 3 weeks old and was about making even more older Go versions easily accessible.
In the end, as you said, there aren't strong reasons to remove them.

Just for clarification, I was not suggesting to remove, as an example, all go1.8* versions, just go1.8 - go.1.8.6, keeping only go1.8.7.

Sorry, I overlooked that part. I think the same arguments still apply; we don't want to delete packages and there's a chance someone may want to compare patch releases of old Go versions.


Why not generating === instead of == ?

I have noticed that for comparisons transrypt generates == operators, which in JavaScript can try to coerce types wherever necessary and "1" == 1, while in python this is not the case. Why not generating === from python == and !== from python != ? This would make generated code behave closer to python and will help to avoid bugs.

Or at least add the command line switch to enable it


Transfer packages/platform to dart team ownership

@mit-mit mentioned this package would be a better fit for the dart team to own. Current plan:

[x] Make Dart folks admin on https://github.com/google/platform.dart
[x] Transfer https://github.com/google/platform.dart to the dart-lang org
[ ] Sync latest changes from https://github.com/flutter/packages/tree/main/packages/platform to https://github.com/dart-lang/platform.dart
[ ] Update repo and issue links in the package to the new source location
[ ] Update publisher in pub.dev to dart.dev
[ ] Remove source from https://github.com/flutter/packages
[ ] Remove platform from the issue template

cc @stuartmorgan

Yes; @lrhn is a potential owner.

@lrhn What are the next steps for moving this?

Just said to @mit-mit today that we should figure that out.
I have a version of the package API that I'd want to continue with, it might need some tweaking around my Wasm experiments.(Is Wasm a platform?)

Added a tasklist above for how we're planning on doing this, PTAL

Hi - who's driving this / following up on updating the code in dart-lang/platform.dart?

I have a version of the package API that I'd want to continue with, it might need some tweaking around my Wasm experiments.(Is Wasm a platform?)

Are we committing to support the current package or still experimenting? Should this be in dart.dev or labs.dart.dev?

Are we committing to support the current package or still experimenting?

Yes. We concretely plan on a new major version of package:platform with full dart fix support to migrate.

Should this be in dart.dev or labs.dart.dev?
It's core, and should be dart.dev

This is now complete!


feat: implement GET DIRECT DATA for CSV

Fixes #81
Add CSV support to GET DIRECT DATA. This required refactoring the existing XLSX support a bit to abstract away data access when converting the data to a lookup. CSV tests were added to the directdata test model.

I removed the try/catch block around the CSV parse. I tested it with a bad pathname and got the following unhandled exception error message:
Error: ENOENT: no such file or directory, open '/Users/toddfincannon/Projects/SDEverywhere/models/directdata/x_data.csv'
I think this is clear enough that we don't need a special error message.


Proposal: add semantic classes to datepicker directive (and possibly others as well)

I recently wanted to style the datepicker using custom css. Unfortunately I found that styling the datepicker cannot be done cleanly. Since the datepicker only has default bootstrap classes assigned to elements there are 2 options for styling the datepicker:

Copy-paste the default template and change classes in the copy
Override default styles using non-semantic selectors (e.g. [datepicker-popup-wrap] table .btn to target the calendar buttons).

The first option is fragile because it requires manually keeping the copied template up-to-date with upstream, and the second option is fragile since it gives little control and it has a very high coupling with the html structure, which again might be changed upstream.
Common practice is to include semantic class names in the html, such that these can be targeted very precisely using css only (proper separation of concerns). This technique should be applied to this directive as well.
This problem is likely not limited to the datepicker alone, but I simply have not checked the other directives.

+1 for semantic class names. At the very least a few carefully chosen elements could be chosen, and then developers could style the rest using CSS child selectors. There is still some risk of breaking that CSS if the markup structure changes in future versions, but at least those changes could be isolated within these carefully selected elements.

+1

Forgot to add in commit - this is addressed by 97c4333


translateconfig broken by istiod renaming

it's looking for a "pilot" deployment which doesn't exist

fixed


Implementation of Fuzzy

Solid package. It does however seem to lack the fuzzy search option unless utilizing a raw query.
If using a raw query, the results are returned as an ElasticSearch object, which would mean it would need to be converted into a collection afterwards to use. Perhaps add a method to convert it back to the proper collection?
If there is already an easy way to use the fuzzysearch, it should probably be included in the readme. Adding it as a Search Rule also seems to break the system.

Hi @evinkuraga, you can create a search rule, like following:
class MySearchRule extends SearchRule
{
    public function buildQueryPayload()
    {
        return [
            'must' => [
                'fuzzy' => [
                    'my_field' => $this->builder->query
                ]
            ]
        ];
    }
}

Hey @babenkoivan is there a way to set a fuzzy search for all the mapped elements of a model?

@Delindel you can try something like this:
class MySearchRule extends SearchRule
{
    public function buildQueryPayload()
    {
        return [
            'must' => [
                'multi_match' => [
                    'query' => $this->builder->query,
                    'fuzziness' => 'auto'
                ]
            ]
        ];
    }
}

Thanks! Ill give it a try in a bit!
Amazing package man, ES works better than TNTsearch for 30M+ records.

On Mar 25, 2018, at 11:25 AM, Babenko Ivan<EMAIL_ADDRESS>wrote:
@Delindel you can try something like this:
class MySearchRule extends SearchRule
{
public function buildQueryPayload()
{
return [
'must' => [
'multi_match' => [
'query' => $this->builder->query,
'fuzziness' => 'auto'
]
]
];
}
}
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Sorry to bring up an old issue.
Is there a way to set the fuzzy search as the default method in the IndexConfigurator settings array?

Hey man! I ended up doing search rules for every model and define fuzzyness there, honestly fuzzy on everything is madness for the engine.

On Apr 8, 2018, at 6:02 PM, JapSeyz<EMAIL_ADDRESS>wrote:
Sorry to bring up an old issue.
Is there a way to set the fuzzy search as the default method in the IndexConfigurator settings array?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Hey @JapSeyz and @Delindel, you can create one search rule with fuzziness and use it in multiple models. Of course, if you have different logic per model it's better to create one rule per model.

Closed due to inactivity.

I have I'm trying to perform a fuzzy search over a text field but my app returns no results when I set up the search rule:
Product::search("text query")->rule(FuzzyMatchRule::class)->get()
FuzzyMatchRule.php:
    public function buildQueryPayload()
    {
        return [
            'must' => [
                'fuzzy' => [
                    'name' => $this->builder->query
                ]
            ]
        ];
    }

Product.php:
 protected $mapping = [
        "properties" => [
            "name" => [
                "type" => "text"
            ],
            "category" => [
                "type" => "text"
            ],
            "sku" => [
                "type" => "keyword"
            ],
            "specs" => [
                "type" => "object"
            ],
            "brand" => [
                "type" => "text"
            ],
...
    public function toSearchableArray(){

        $searchableArray = $this->toArray();

        unset($searchableArray['created_at']);
        unset($searchableArray['updated_at']);

        $searchableArray['category'] = $this->category->name;

        return $searchableArray;
    }

What I want is simply to be able to search for example the query string: "PROT" so that it returns the products containing that string in the name field, for example in within my data it should return product with name: "02-0690-00_THROAT PROTECTOR"

@poncianodiego have you solved the issue? Your search rule looks correct. Did you try to search the whole word PROTECTOR or use default search rule?


poetry issue

Describe the bug
Note: This error originates from the build backend, and is likely not a problem with poetry but with minimal-snowplow-tracker (0.0.2) not supporting PEP 517 builds. You can verify this by running 'pip wheel --use-pep517 "minimal-snowplow-tracker (==0.0.2)"'.
To Reproduce
Steps to reproduce the behavior or code snippets that produce the issue.
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Environment (please complete the following information):

OS: [e.g. Ubuntu 20.04]
Version [e.g. 3.8]

Additional context
Add any other context about the problem here.

Hi @MuslimBeibytuly, unfortunately minimal-snowplow-tracker is not our package or one that we maintain (it also seems abandoned). This repository only publishes the snowplow-tracker package, which we recommend to be used for tracking Snowplow events from Python.


Remove deprecated options. Closes #3840

Closes #3840 .
In this PR, I've removed the deprecated options which still persisted in the V6 branch.
Below you can find a summary of what I've changed

Command
Deprecated options
Changes

planner plan get
planTitle & planId
Made changes to code and documentation files

planner task get
taskId
Made changes to only the documentation file

spo list webhook list
id & title
Made changes to code and documentation files

spo site add
allowFileSharingForGuestUsers
Made changes to code and documentation files

teams team clone
displayName
Made changes to only the documentation file

teams team set
displayName
Made changes to code and documentation files

I also noticed that the command planner plan get could be optimized by using option sets, but this is already been mentioned by @Jwaegebaert in a different issue #3854

Changed to draft as I've found out that another command (spo listitem list) also contains deprecated options.


Event dispatch, npm repository, has been archived. Is there a maintained alternative?

Hi,
First of all thank you for sharing this node-js project skeleton, and writing a blog post about it :)
I was wondering if you are aware that event dispatch has been archived:
https://github.com/pleerock/event-dispatch#readme
Do you know by any chance if there is a maintained alternative?
Best!

Oh well, that's sad I liked that package :(
I will try to find an alternative, or write a service that does the same

I just found about that package as well, and it looks awesome. Hopefully there are some similar alternatives out there. If you decide to create a similar service, and if you accept PRs, I will be happy to collaborate :)

You might want to check out https://github.com/KeesCBakker/Strongly-Typed-Events-for-TypeScript
I'm in the process of replacing event-dispatch with it for the project I'm currently working on.

I just found this package which I am going to use in my project as an alternative.
https://github.com/j/type-events
I particularly like how events are dispatched as class instances so you can depend on the arguments that are passed to the subscribers.

I ended doing a custom implementation with eventemitter2 because I needed wildcard support.
Here is the pub/sub classes:
import { EventEmitter2 } from "eventemitter2";

export interface IEventPublisherArgs {
  subscribers: EventSubscriber[];
}

export class EventPublisher {
  private emitter: EventEmitter2;

  constructor(args: IEventPublisherArgs) {
    this.emitter = new EventEmitter2({ wildcard: true, delimiter: "." });

    const bus: IEventBus = {
      subscribe: (id, cb) => {
        this.emitter.on(id, cb);
      }
    };

    for (const subscriber of args.subscribers) {
      subscriber.attach(bus);
    }
  }

  publish(event: PublishEvent) {
    this.emitter.emit(event.id, event);
  }
}

export class PublishEvent {
  constructor(public id: string) {}
}

export type SubscribeListenerFunction = (event: PublishEvent) => void;

export type SubscribeFunction = (
  id: string,
  cb: SubscribeListenerFunction
) => void;

export interface IEventBus {
  subscribe: SubscribeFunction;
}

export abstract class EventSubscriber {
  abstract attach(bus: IEventBus): void;
}

Here is a basic example on how it is used (w/ dependency injection):
import { Container } from "typedi";

export class IntegrationConnectedEvent extends PublishEvent {
  constructor(public payload: any) {
    super("integration.connected");
  }
}

export class IntegrationSubscriber extends EventSubscriber {
  attach(bus: IEventBus) {
    bus.subscribe(
      "integration.connected",
      this.onIntegrationConnectedEvent
    );
  }

  async onIntegrationConnectedEvent(event: PublishEvent) {
    if (event instanceof IntegrationConnectedEvent) {
      console.log(event.payload);
    }
  }
}

Container.set("publisher", new EventPublisher({ subscribers: [IntegrationSubscriber] }));

const publisher = Container.get("publisher");

publisher.publish(new IntegrationConnectedEvent("Hello World!"));

// Console output: Hello World!

I thought I'd share in-case it helps somebody.


HAHAHA

I'm laying in bed like just finishing writing that function and I check my git log and it goes back like 30 merges haha. Wow. I've never felt like this bad before. Like right as my body begins to feel weary and my eyes are burning from the excessive screen exposure and lack off sleep...i guess it feels better though because the end result. makes my eyes lay easier

Thing is...I'm not laughing. At all. And I need to brush my teeth so I don't lose more teeth. I haven't showered in more than 7 days.

Thing is...I'm not laughing. At all. And I need to brush my teeth so I don't lose more teeth. I haven't showered in more than 7 days.

Those weird hacker quests you go on to build a bridge made out of eggs and spoons. You know in the end it makes you a lot better but I mean yeah it is faster but the amount of time to pull that off. I've gone on those quests a few too many times.

Those weird hacker quests you go on to build a bridge made out of eggs and spoons. You know in the end it makes you a lot better but I mean yeah it is faster but the amount of time to pull that off. I've gone on those quests a few too many times.

I have this written incorrect. I mean it could be correect if you wanted to do Flow<List> to Flow<List>
but I want ti to do Flow<List> and then it gives you T over and over in onEach
internal suspend fun rescheduleWorkAfterReboot(scope: CoroutineScope, work: Work?){
        dao.getPersistentWork().filterNotNull()
            .flatMapMerge(DEFAULT_CONCURRENCY){
                flow {
                    emit(it.map { Worker.createFromWork(it)} )
                }
            }
            .onEach {
                if(work != null)
                    it.find { it.id == work.id }?.let { scheduler.use { (it as PersistentWorker).scheduleFuture() } }
                else
                    it.filterIsInstance<PersistentWorker>()
                        .forEach { worker -> scheduler.use { worker.scheduleFuture() } }
            }.flowOn(Dispatchers.Default)
            .launchIn(scope)
    }

I have this written incorrect. I mean it could be correect if you wanted to do Flow<List> to Flow<List>
but I want ti to do Flow<List> and then it gives you T over and over in onEach
internal suspend fun rescheduleWorkAfterReboot(scope: CoroutineScope, work: Work?){
        dao.getPersistentWork().filterNotNull()
            .flatMapMerge(DEFAULT_CONCURRENCY){
                flow {
                    emit(it.map { Worker.createFromWork(it)} )
                }
            }
            .onEach {
                if(work != null)
                    it.find { it.id == work.id }?.let { scheduler.use { (it as PersistentWorker).scheduleFuture() } }
                else
                    it.filterIsInstance<PersistentWorker>()
                        .forEach { worker -> scheduler.use { worker.scheduleFuture() } }
            }.flowOn(Dispatchers.Default)
            .launchIn(scope)
    }


FileNotFoundException when specifying Output file for Post Build Action

When i specify an output file name - for post build action - it gives me permission denied on jenkins - saying java.io.FileNotFoundException: change.log (Permission denied)
I even tried first creating that file by executing shell - touch change.log and in the output file I specified $WORKSPACE/change.log - but that did not work either
Any suggestions? Thanks

same here


Make file stats available to indexFilter

Small change to make the file stat information available to the file filter.
There are extensions available to extend the filtering capability, but they are all limited in that it is difficult to have custom filtering for directories or file sizes etc without more information provided to the filter.

IMHO, this raises the question if _indexFilter should be a public api.
Improving it only for the sake of extensions is seems to me a bit risky...

I agree about there should be discussion on if _indexFilter should be public.
I'm not sure I understand the risk statement.  Maybe you could elaborate further to help me understand the concern?

The risk is only from a maintanaince point of view.

@ficristo
I don't think this PR makes _indexFilter public. It's an underscored method which hints private and it's up to developers not to abuse it, this PR doesn't change that. From maintenance point of view, I'm sure @dakaraphi understands, that arguments passed to this function can change with any Brackets release and break his extensions. Voting for merge here.

If the only motivation behind this change is for extensions sake, I'm against it.
IMHO we should spend 0 time on improving private API for that solely reason.
And if we start with one we create a precedent.
We should instead discuss if this kind of API should be made public and eventually add the necessary parameters.
That said, we can hear more opinions of others committers and decide what to do.

I just need a solution to provide this capability.  All extensions which do filtering currently use this function.  In order to get this functionality I must do a very ugly monkey patch in my extension.
Brackets is not usable in my project without this capability as it is a very complex directory structure with many hundred thousands of files.  This certainly can stay private if Brackets wants to include such functionality by default.
For reference, my extension: https://github.com/dakaraphi/brackets-filter-extension

If we are talking about filtering extensions, personally I always felt they were an hack done because of the limitations of Brackets.
The right fix is to provide these features natively in Brackets and not though an extension.
And I think, with the latest changes of @zaggino, we are almost there.

@dakaraphi in the meantime, you can do this:
FileSystem.prototype._indexFilter = function (path, name) {

        var stats = this.getFileForPath(path)._stat;
        if (stats) {
            ...
        }

This would require probably calling projectRefresh event after it's first loaded because first run of this won't have stats.

I think that before we have something in the tree we will have to wait still a lot of time.
I still believe this is not right, but meh. We will survive with it.
@zaggino could you check if this is still valid and land?
@dakaraphi keep in mind that is not a supported behaviour and if this will be in the way we will remove it.

👍


MySQL storage_engine problem

Affected Puppet, Ruby, OS and module versions/distributions

Puppet: 5.3.5
Ruby: 2.0.0p648
Distribution: Puppet Enterprise
Module version: 3.4.0

How to reproduce (e.g Puppet code you use)
  class { 'jira':
    version             => '7.8.1',
    installdir          => '/opt/atlassian-jira',
    homedir             => '/myatlassian/jira',
    db                  => 'mysql',
    dbtype              => 'mysql',
    dbname              => 'jiradb',
    dbuser              => 'jiradbuser',
    dbdriver            => 'com.mysql.jdbc.Driver',
    dbpassword          => 'XXX',
    dbserver            => 'localhost',
    javahome            => '/usr/java/default',
    jvm_xmx             => '3584m',
    jvm_xms             => '3584m',
    mysql_connector_version => '5.1.46',
  }

What are you seeing
The file dbconfig.xml is being modified by Puppet to have this JDBC URL:
jdbc:mysql://localhost:5432/jiradb?useUnicode=true&characterEncoding=UTF8&sessionVariables=storage_engine=InnoDB
However, JIRA is coming up and complaining this: "The connection URL in your dbconfig.xml file contains the storage_engine parameter, which has been deprecated. This needs to be replaced with the default_storage_engine parameter."
What behaviour did you expect instead
How do I change the sessionVariable to match what JIRA 7.8.1 is expecting?

I just merged https://github.com/voxpupuli/puppet-jira/pull/216 which should fix this. I'm going to release a new version now. Please report back if it doesn't fix your issue.

Yep, that fixed the issue! Thanks :-)


unable to resolve path to module "moment-range" (import/no unresolved)

I'm installing moment-range in my application:
const momentRange = require('moment-range');

I got this eslint error:
unable to resolve path to module "moment-range" (import/no unresolved)

However the module was installed and exists in package.json.
.eslintrc.json
{
    "parserOptions": {
        "ecmaVersion": 2017
    },
    "env": {
        "node": true
    },
    "extends": "airbnb-base"
}

I have already open an issue Unable to resolve path to module 'moment-range' import/no-unresolved on eslint project. How can I fix this problem because the only solution that I use now is eslint-disable-line.
eslint-plugin-import: 2.8.0
moment-range: 4.0.0
node: 8.11.3
npm: 5.6.0
OS: Ubuntu 18.04.1LTS (64-bit)

If you open up the repl (node), can you require moment-range successfully?

@ljharb It works on repl.

What's the structure of your project? Do you just have one package.json at the root?

@ljharb  I have only one package.json file

And the eslint error you get is on the command line? Can you share the full command and output?

I can confirm the exact same issue with the moment-range package.

@wcandillon same questions above to you then

Given that<EMAIL_ADDRESS>points to<EMAIL_ADDRESS>but<EMAIL_ADDRESS>has jsnext-main that points to a nonexistent file, this seems to have been a bug in moment-range that they've now fixed.


Bugfix release of Storage.

Release notes will be simple
google-cloud-storage 1.1.1

Bug fix: Only using Blob.updated if it is set in download_to_filename(). (#3352)

/cc @danigosa

Here is the tag build
https://circleci.com/gh/GoogleCloudPlatform/google-cloud-python/1713
which will push to
https://pypi.python.org/pypi/google-cloud-storage/1.1.1


chore(tests): fix use of jest-diff

Jest 27 changed the signature for jest-diff to named exports only.
This bug only arises from failing tests, so it wasn't caught by CI.  But I noticed it when debugging #3214.

Codecov Report

Merging #3215 (bbcc7c6) into master (edc998a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3215   +/-   ##
=======================================
  Coverage   93.95%   93.95%
=======================================
  Files          88       88
  Lines        6365     6365
  Branches     1322     1322
=======================================
  Hits         5980     5980
  Misses        355      355
  Partials       30       30

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edc998a...bbcc7c6. Read the comment docs.

I wonder how it didn't print import warnings. Maybe #3199 would check this?

Good point: #3199 ought to have helped, but I ended up turning off warnings about import foo from 'foo' because we do that a lot in the codebase.  And ESLint doesn't check types.  I would think that Flow would catch it, but I guess it didn't have types for that module (maybe we need to import some?).  Switching to TypeScript may help.  (I'm guessing Jest has TypeScript types.)


About the new "modal component" sample

A simple comment from a newbie...
It might be easy to fix, but it would be nice if the modal component did replace the "default header" with "custom header" as originally intended...
Now I am left with that as an exercise... might be a good exercise! ^_^ but would be nice to show how to do it in the examples! ;)

Do you mean it's broken? It seems to be replacing the default header correctly.

My bad, must have been tired..
yes, it worked, I realized later!
as a side note, 2 unrelated comment:

haven't looked at Vue and/or web development in a while but today, for some reason, doing it at home and finding Vue so much simpler now! Awesome! :)
v-on can only be applied once! What If I want to handle 2 events? (such as click and lost focus on a button)

http://vuejs.org/guide/directives.html#Multiple_Clauses
Please post questions to forum.vuejs.org instead. Also note in 1.0 v-on syntax will be different.


Hello, I would like to know the specific timeline for releasing the code.

I find your paper and methodology very intriguing and would like to use it for my research. Could you please provide a specific timeline for when the source code and pretrained models will be made publicly available?

Me too

Me too


Fail to delete one ADLS Gen2 blob snapshot

Storage Explorer Version: 1.32.0-dev (93)
Build Number: 20230914.4
Branch: main
Platform/OS: Windows 10/Linux Ubuntu 20.04/MacOS Ventura 13.5.2 (Apple M1 Pro)
Architecture: x64/x64/x64
How Found: From running test cases
Regression From: Previous release (1.31.1)
Steps to Reproduce

Expand one ADLS Gen2 storage account -> Blob Containers.
Create a blob container -> Upload one blob.
Create a snapshot for the blob -> Switch to snapshots view.
Delete the snapshot.
Check whether succeeds to delete it.

Expected Experience
Succeed to delete the snapshot.
Actual Experience
Fail to delete the snapshot.

Here is the retry dialog:

Verified this issue on the main build 20230915.2. Fixed. So, we are going to close it.


codeberg-cli: change owner

Description of changes
The repository ownership changed
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Thanks for the fast review and sorry for the trouble because of my undetailed description. I'll make sure to do it better next time!


Optimistic lock support

Simple mapper modification to issue different command set for queue update and queue delete with version check.

Do you mean add something like @Version annotation for schema description?

Hi, technically it will require the development of custom Mapper which can be enabled via schema generator and annotation. But yes, it will be version column driven. Architecture is ready for that.

What about optimistic lock at this moment?

Feature development is currently on hold (till the end of the year). We are working on a new massive component (https://github.com/temporalio/proposals/blob/master/php/php-rr-sdk.md) which consumes all the team attention. You can implement this feature by youself vis custom command in your mapper.

Could this be squeezed in for V2?

Could this be squeezed in for V2?

This is done as macro draft here


Bug: Cannot shift click ender pearls into ender dust in anvil

When using a normal anvil with an aeternium hammer and you attempt to shift click to fully craft the ender pearls it "glitches" the ui and only crafts one.  The expected behavior was that shift click should consume the 16 ender pearls and produce 16 ender dust.
Example of UI aft shift click:

if you click anywhere on the ui again it "resets" to only having crafted one:

Tested in latest version, looks like it was fixed together with other anvil fixes in BClib, now it works fine


[ENH] Type hints for primitives and string arguments

Describe the feature or idea you want to propose
we would like to increase the use of type hints, and a good first issue is to add them for the simplest case when arguments are primitives (int, float, bool) or strings. Pick a package, look through the code and add type hints. Just for primitives for now, more complex types need a bit of thought. Many have npt.ArrayLike types, but we have not decided on standardising on that, so leave these alone. Dont feel you have to do them all, this is a good first issue to get you started.
Describe your proposed solution
for example, the constructor for the anomaly detection algorithm STRAY has these type hints
    def __init__(
        self,
        alpha: float = 0.01,
        k: int = 10,
        knn_algorithm: str = "brute",
        p: float = 0.5,
        size_threshold: int = 50,
        outlier_tail: str = "max",
    ):

but the segmentation algorithm CLASP does not
def _is_trivial_match(candidate, change_points, n_timepoints, exclusion_radius=0.05):
    """Check if a candidate change point is in close proximity to other change points.

Describe alternatives you've considered, if relevant
No response
Additional context
No response

Hello,
I would like to start on this issue. I am taking up "aeon.classification.distance_based._time_series_neighbors.py" script to start with.

@all-contributors please add @nileenagp  for Code

Hello,
I have a doubt here.  If I need to use Type[keras.optimizers.Optimizer] in type hints for a parameter,  Is it allowed to import "keras" as per the project standards,  when it is not required anywhere else in the  script?

No, if the dependency is optional it should not be imported at the top level of a file. This would exclude it from specific type hints like that I imagine.

Thanks for the confirmation, I will leave that type hint for now.

Hello, is this issue still open to work on ?
I would like to work on it , could you please assign it.
Thank you!

Hi @YashviMehta03, this one is a bit too big for a single person really. I would post here selecting a part of the package you want to add type hints too and go from there.

Hello @MatthewMiddlehurst , yes right.
So, these are the modules where I could add type hints since they are missing :

all the .py files under the following directories :
aeon/classification/convolution_based
aeon/classification/feature_based

this particular file
aeon/classification/early_classification/_probability_threshold.py

I would like to work on it , could you assign it?