netbox-dns installation in a docker compose Environment fails

Versions
NetBox Version: 3.6.9
NetBox DNS Version: 0.21.14
Python Version: 3.11.4
Describe the bug
I am running netbox from docker compose environment and part of the that is container build to add the needed Plugins to the container. Last command in the Dockerfile ist a /opt/netbox/venv/bin/python /opt/netbox/netbox/manage.py collectstatic --no-input which fails because the netbox_dns plugin tries to open the Database and fail. Since this in a build phase there is no databate which could be connected at that point in time..
To Reproduce
Steps to reproduce the behavior:

Start of with https://github.com/netbox-community/netbox-docker/releases/tag/2.7.0
Add netbox-plugin-dns to plugin_requirements.txt
Run a docker compose build
See Build Error
failed to solve: process "/bin/sh -c SECRET_KEY=\"Souch8Fis6mongei9yaezeeto4aini5Johleip5ee9ooxieC9v\" /opt/netbox/venv/bin/python /opt/netbox/netbox/manage.py collectstatic --no-input" did not complete successfully: exit code: 1

Expected result
A call to /opt/netbox/netbox/manage.py collectstatic should not open the database so that this step can used in build process as it works without the dns plugin
Actual result
The build process fails and it is not possible to build a docker container including the dns plugin
Screenshots
root@steve-docker-host:/opt/docker-compose/netbox-docker# docker compose build
[+] Building 5.3s (9/9) FINISHED                                                                                docker:default
 => [netbox internal] load build definition from Dockerfile-Plugins                                                                                0.0s
 => => transferring dockerfile: 508B                                                                                0.0s
 => [netbox internal] load .dockerignore                                                                                0.0s
 => => transferring context: 162B                                                                                0.0s
 => [netbox internal] load metadata for docker.io/netboxcommunity/netbox:v3.6-2.7.0                                                                                1.1s
 => [netbox 1/5] FROM docker.io/netboxcommunity/netbox:v3.6-2.7.0@sha256:cf8a16f61d96c5d15cf5c639129662390e4b42685ed9c94ab4e344edeceb9a70                                                                     0.0s
 => [netbox internal] load build context                                                                                0.0s
 => => transferring context: 128B                                                                                0.0s
 => CACHED [netbox 2/5] COPY ./plugin_requirements.txt /                                                                                0.0s
 => CACHED [netbox 3/5] RUN /opt/netbox/venv/bin/pip install  --no-warn-script-location -r /plugin_requirements.txt                                                                                0.0s
 => CACHED [netbox 4/5] COPY configuration/configuration.py /etc/netbox/config/configuration.py                                                                                0.0s
 => ERROR [netbox 5/5] RUN SECRET_KEY="xxx" /opt/netbox/venv/bin/python /opt/netbox/netbox/manage.py collectstatic --no-input                                  4.1s
------
 > [netbox 5/5] RUN SECRET_KEY="xxx" /opt/netbox/venv/bin/python /opt/netbox/netbox/manage.py collectstatic --no-input:
1.384 🧬 loaded config '/etc/netbox/config/configuration.py'
1.385 🧬 loaded config '/etc/netbox/config/extra.py'
1.385 🧬 loaded config '/etc/netbox/config/logging.py'
1.387 🧬 loaded config '/etc/netbox/config/plugins.py'
3.616 Traceback (most recent call last):
3.616   File "/opt/netbox/venv/lib/python3.11/site-packages/django/db/backends/base/base.py", line 289, in ensure_connection
3.618     self.connect()
3.618   File "/opt/netbox/venv/lib/python3.11/site-packages/django/utils/asyncio.py", line 26, in inner
3.618     return func(*args, **kwargs)
3.618            ^^^^^^^^^^^^^^^^^^^^^
3.619   File "/opt/netbox/venv/lib/python3.11/site-packages/django/db/backends/base/base.py", line 270, in connect
3.621     self.connection = self.get_new_connection(conn_params)
3.621                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
3.625   File "/opt/netbox/venv/lib/python3.11/site-packages/django/utils/asyncio.py", line 26, in inner
3.625     return func(*args, **kwargs)
3.626            ^^^^^^^^^^^^^^^^^^^^^
3.632   File "/opt/netbox/venv/lib/python3.11/site-packages/django/db/backends/postgresql/base.py", line 275, in get_new_connection
3.632     connection = self.Database.connect(**conn_params)
3.632                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
3.632   File "/opt/netbox/venv/lib/python3.11/site-packages/psycopg/connection.py", line 729, in connect
3.632     raise ex.with_traceback(None)
3.633 psycopg.OperationalError: connection failed: Connection refused
3.635 	Is the server running on that host and accepting TCP/IP connections?
3.635 connection to server at "localhost" (::1), port 5432 failed: Cannot assign requested address
3.635 	Is the server running on that host and accepting TCP/IP connections?
3.635
3.635 The above exception was the direct cause of the following exception:
3.635
3.635 Traceback (most recent call last):
3.635   File "/opt/netbox/netbox/manage.py", line 10, in <module>
3.635     execute_from_command_line(sys.argv)
3.635   File "/opt/netbox/venv/lib/python3.11/site-packages/django/core/management/__init__.py", line 442, in execute_from_command_line
3.635     utility.execute()
3.635   File "/opt/netbox/venv/lib/python3.11/site-packages/django/core/management/__init__.py", line 416, in execute
3.635     django.setup()
3.635   File "/opt/netbox/venv/lib/python3.11/site-packages/django/__init__.py", line 24, in setup
3.635     apps.populate(settings.INSTALLED_APPS)
3.635   File "/opt/netbox/venv/lib/python3.11/site-packages/django/apps/registry.py", line 124, in populate
3.636     app_config.ready()
3.636   File "/opt/netbox/venv/lib/python3.11/site-packages/netbox_dns/__init__.py", line 53, in ready
3.636     objtype = ContentType.objects.get_for_model(IPAddress)
3.636               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
3.644   File "/opt/netbox/venv/lib/python3.11/site-packages/django/contrib/contenttypes/models.py", line 52, in get_for_model
3.644     ct = self.get(app_label=opts.app_label, model=opts.model_name)
3.644          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
3.644   File "/opt/netbox/venv/lib/python3.11/site-packages/django/db/models/manager.py", line 87, in manager_method
3.644     return getattr(self.get_queryset(), name)(*args, **kwargs)
3.644            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
3.644   File "/opt/netbox/venv/lib/python3.11/site-packages/django/db/models/query.py", line 633, in get
3.644     num = len(clone)
3.644           ^^^^^^^^^^
3.644   File "/opt/netbox/venv/lib/python3.11/site-packages/django/db/models/query.py", line 380, in __len__
3.644     self._fetch_all()
3.644   File "/opt/netbox/venv/lib/python3.11/site-packages/django/db/models/query.py", line 1881, in _fetch_all
3.644     self._result_cache = list(self._iterable_class(self))
3.644                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
3.644   File "/opt/netbox/venv/lib/python3.11/site-packages/django/db/models/query.py", line 91, in __iter__
3.644     results = compiler.execute_sql(
3.644               ^^^^^^^^^^^^^^^^^^^^^
3.644   File "/opt/netbox/venv/lib/python3.11/site-packages/django/db/models/sql/compiler.py", line 1560, in execute_sql
3.644     cursor = self.connection.cursor()
3.644              ^^^^^^^^^^^^^^^^^^^^^^^^
3.644   File "/opt/netbox/venv/lib/python3.11/site-packages/django/utils/asyncio.py", line 26, in inner
3.644     return func(*args, **kwargs)
3.644            ^^^^^^^^^^^^^^^^^^^^^
3.644   File "/opt/netbox/venv/lib/python3.11/site-packages/django/db/backends/base/base.py", line 330, in cursor
3.644     return self._cursor()
3.644            ^^^^^^^^^^^^^^
3.650   File "/opt/netbox/venv/lib/python3.11/site-packages/django/db/backends/base/base.py", line 306, in _cursor
3.650     self.ensure_connection()
3.650   File "/opt/netbox/venv/lib/python3.11/site-packages/django/utils/asyncio.py", line 26, in inner
3.650     return func(*args, **kwargs)
3.650            ^^^^^^^^^^^^^^^^^^^^^
3.650   File "/opt/netbox/venv/lib/python3.11/site-packages/django/db/backends/base/base.py", line 288, in ensure_connection
3.650     with self.wrap_database_errors:
3.650   File "/opt/netbox/venv/lib/python3.11/site-packages/django/db/utils.py", line 91, in __exit__
3.650     raise dj_exc_value.with_traceback(traceback) from exc_value
3.650   File "/opt/netbox/venv/lib/python3.11/site-packages/django/db/backends/base/base.py", line 289, in ensure_connection
3.650     self.connect()
3.650   File "/opt/netbox/venv/lib/python3.11/site-packages/django/utils/asyncio.py", line 26, in inner
3.650     return func(*args, **kwargs)
3.650            ^^^^^^^^^^^^^^^^^^^^^
3.650   File "/opt/netbox/venv/lib/python3.11/site-packages/django/db/backends/base/base.py", line 270, in connect
3.650     self.connection = self.get_new_connection(conn_params)
3.650                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
3.650   File "/opt/netbox/venv/lib/python3.11/site-packages/django/utils/asyncio.py", line 26, in inner
3.650     return func(*args, **kwargs)
3.652            ^^^^^^^^^^^^^^^^^^^^^
3.652   File "/opt/netbox/venv/lib/python3.11/site-packages/django/db/backends/postgresql/base.py", line 275, in get_new_connection
3.652     connection = self.Database.connect(**conn_params)
3.652                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
3.652   File "/opt/netbox/venv/lib/python3.11/site-packages/psycopg/connection.py", line 729, in connect
3.652     raise ex.with_traceback(None)
3.652 django.db.utils.OperationalError: connection failed: Connection refused
3.652 	Is the server running on that host and accepting TCP/IP connections?
3.652 connection to server at "localhost" (::1), port 5432 failed: Cannot assign requested address
3.652 	Is the server running on that host and accepting TCP/IP connections?
------
failed to solve: process "/bin/sh -c SECRET_KEY=\"Souch8Fis6mongei9yaezeeto4aini5Johleip5ee9ooxieC9v\" /opt/netbox/venv/bin/python /opt/netbox/netbox/manage.py collectstatic --no-input" did not complete successfully: exit code: 1
root@steve-docker-host:/opt/docker-compose/netbox-docker# cat Dockerfile-Plugins
FROM netboxcommunity/netbox:v3.6-2.7.0

COPY ./plugin_requirements.txt /
RUN /opt/netbox/venv/bin/pip install  --no-warn-script-location -r /plugin_requirements.txt

# These lines are only required if your plugin has its own static files.
COPY configuration/configuration.py /etc/netbox/config/configuration.py
RUN SECRET_KEY="xxx" /opt/netbox/venv/bin/python /opt/netbox/netbox/manage.py collectstatic --no-input

Hi @lairsdragon, thanks for raising this.
First things first, I don't use Docker at all, so this might be a bit hard for me to reproduce.
NetBox DNS does not bring any static files at all, so I don't really see why the presence of the plugin should affect whether manage.py collectstatic requires a database connection or not. There is also no way in which I could influence this from the plugin code.
It seems to be a Django-specific issue according to this conversation on Stackoverflow. There's also a workaround (untested).

I investigated a bit more deeply, and it seems it is in fact an issue with how manage.py is started.
NetBox DNS runs the following command on initialisation:
objtype = ContentType.objects.get_for_model(IPAddress)

That obviously requires a database connection, and do it fails in your setup when the database is not running.
The code is actually in the ready() method, which determines whether all required dynamic fields for IPAM coupling are present (and contains an unrelated bug, by the way). This check isn't strictly necessary, so one way to get rid of the problem would be to remove it altogether.
However, I can't say at this moment whether there is something else elsewhere that still causes the problem to occur.
So the workaround from the Stackoverflow conversation might be the safer way to solve it (provided that it works).

Thank for looking in that issue,
It only happens if feature_ipam_coupling was set. (Which I have done, after the first sucessful container build)
I suppose you mean the SO Answer with SKIP_PG_EXTRA_VALIDATION? I think that would only work on the specific django plugin...
Maybe a way around would be to see if a specific Envirnoment Variable (eg: "NETBOX_DNS_SKIP_CHECKS") was set and skip the check in that case..

I'll have a look later this evening ... there will be some way to solve it, I'm sure.
Probably I can already reproduce it by stopping the database in a non-Docker installation. If that works, there should be a quick solution for you.

I found a simple and relatively elegant way to work around that issue.
As I said, the test for the custom fields is not strictly necessary, it just logs a warning if some or all custom fields are missing. If the database can't be connected to that check fails.
The workaround I implemented now catches the exception caused by that and logs a different warning instead. I think that will be sufficient as well, and now the ready() method no longer fails and the collectstatic operation can continue.

Release 0.21.15 is out now with a fix for your issue.

Many Thanks Peter, I can confirm that this fixes my issue


Port overriding failing on 0.61.4

With the standard port of 8081 in use, overriding the port to 8088 does not work. When running the iOS app, the app will still look for port 8081.
React Native version:
System:
OS: macOS 10.15.1
CPU: (12) x64 Intel(R) Core(TM) i7-8850H CPU @ 2.60GHz
Memory: 431.70 MB / 16.00 GB
Shell: 3.2.57 - /bin/bash
Binaries:
Node: 11.4.0 - ~/.nvm/versions/node/v11.4.0/bin/node
npm: 6.10.2 - ~/.nvm/versions/node/v11.4.0/bin/npm
Watchman: 4.9.0 - /usr/local/bin/watchman
SDKs:
iOS SDK:
Platforms: iOS 13.2, DriverKit 19.0, macOS 10.15, tvOS 13.2, watchOS 6.1
Android SDK:
API Levels: 24, 27, 28, 29
Build Tools: 27.0.3, 28.0.3, 29.0.0, 29.0.2
System Images: android-28 | Google APIs Intel x86 Atom
IDEs:
Android Studio: 3.5 AI-191.8<IP_ADDRESS>77832
Xcode: 11.2.1/11B53 - /usr/bin/xcodebuild
npmPackages:
react: 16.9.0 => 16.9.0
react-native: 0.61.4 => 0.61.4
Steps To Reproduce

npx react-native init Test
cd Test
npx react-native start --port=8088
open ios/Test.xcworkspace in Xcode
Edit Start Packager build phase of "Test" target to change port from 8081 to 8088
Press Build and Run in Xcode
Simulator will start, app will start, but error:

No bundle URL present.

Make sure you're running a packager server or have included a .jsbundle file in your application bundle.

RCTFatal
__28-[RCTCxxBridge handleError:]_block_invoke
_dispatch_call_block_and_release
_dispatch_client_callout
_dispatch_main_queue_callback_4CF
__CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE__
__CFRunLoopRun
CFRunLoopRunSpecific
GSEventRunModal
UIApplicationMain
main
start

Debug console in Xcode shows that the app is still looking for port 8081:

2019-11-15 13:19:17.348467-0600 Test[39853:298200] Task <DCCAD9E5-5E8F-4253-BB54-F2386A778CD3>.<1> HTTP load failed, 564/0 bytes (error code: -1005 [4:-4])
2019-11-15 13:19:17.354410-0600 Test[39853:298200] Task <DCCAD9E5-5E8F-4253-BB54-F2386A778CD3>.<1> finished with error [-1005] Error Domain=NSURLErrorDomain Code=-1005 "The network connection was lost." UserInfo={NSUnderlyingError=0x60000335fcc0 {Error Domain=kCFErrorDomainCFNetwork Code=-1005 "(null)" UserInfo={NSErrorPeerAddressKey=<CFData 0x6000019cd560 [0x7fff80615350]>{length = 28, capacity = 28, bytes = 0x1c1e1f91000000000000000000000000 ...<PHONE_NUMBER>000000}, _kCFStreamErrorCodeKey=-4, _kCFStreamErrorDomainKey=4}}, NSErrorFailingURLStringKey=http://localhost:8081/status, NSErrorFailingURLKey=http://localhost:8081/status, _kCFStreamErrorDomainKey=4, _kCFStreamErrorCodeKey=-4, NSLocalizedDescription=The network connection was lost.}
2019-11-15 13:19:17.454 [fatal][tid:main] No bundle URL present.

Make sure you're running a packager server or have included a .jsbundle file in your application bundle.
2019-11-15 13:21:29.544057-0600 Test[39853:297947] Returning local object of class NSString

Describe what you expected to happen
I expect to see the starter app running in the simulator

That info was already there right near the top, but I've removed some formatting. Does that help?

It works on an emulator, on a real device I get the same error

Relatedhttps://github.com/facebook/react-native/issues/26331

FWIW, if I use the Configure Bundler option on the in-app/simulator Debug menu to change the port to 8088, it appears to heed the request and works like a charm. Not quite a workaround for me though because 8081 is blocked/in-use on my network and, therefore, cannot access the debug menu.

I'm also experiencing this problem after upgrading to v0.61.4 from v.0.59.5


Errors from packages where no file is open don't appear on problems tab.

In a setup with at least one namespaced package, where I change something in the namespaced package, errors for a consuming package only appear on the problems tab when at least one file of the consuming package is open in VSCode.
I made a repository to demonstrate this behaviour: https://github.com/fhammerschmidt/rescript-vscode-problems-tab

Looks like the build command is "build": "cd app && rescript build -with-deps"
So the project app is built, and during that build one gets an error in the command-line.
I would expect the same behaviour in the editor that when project app is edited, the issues relevant to it are shown.
That project is open when some file from that project is open.
Should there be some way to know that when opening some project ( common ) one should look for issues in other projects ( app )?

The compiler does not show the error if one does this:
cd common
npx rescript

Opening a file from common is the editor's equivalent of asking the question: is there some error when building this project.

The repo is just a limited demonstration of this behaviour, I tried to keep it as simple as possible, maybe it was a bit too simple.
At work we use watchexec which spawns rescript builds in every package, so any error will always be visible in the terminal. But not in the VSCode PROBLEMS tab. And it happens quite often that if you change some common typename which is used in multiple packages, you don't have files open for every one of these.
I even agree that it is completely correct what happens, but maybe there are some possibilities to make the editor experience in monorepos as enjoyable as in non-monorepos.

Sorry, I updated the repo now to run from root, to better reflect what we are doing at work.

Looks like the same concerns apply to normal build. There is no single command that shows all the errors in all the packages.
The analogy is the watcher calling code common/src/App.res common/src/Utils.res after running the build.

What does command mean in this context? Because with rescript build -with-deps in the workspace root, I get errors for all packages.

Looks like -with-deps concatenates the .compiler.log from the various project.
So the thing to try would be to reproduce the same functionality in the editor extension.
Questions include, how does one tell the editor that that's what they want to do.
And how to find out what all the packages are. Whether one needs help from the compiler.

Probably someone interested in monorepos could drive this.


[Bug] Checkbox field type does not show custom options labels

Bug report
What I did
Added a boolean field, with custom labels as specified in the docs:
[
    'name'  => 'name',
    'label' => 'Status',
    'type'  => 'boolean',
    // optionally override the Yes/No texts
    'options' => [0 => 'Active', 1 => 'Inactive']
],

What I expected to happen
Radio buttons or a select box are shown with Active and Inactive
What happened
Only a checkbox is shown with the label 'Status'. Actually, this field is just a straight up include of the checkbox field.
Backpack, Laravel, PHP, DB version
PHP VERSION:
PHP 7.3.18 (cli) (built: May 14 2020 10:54:44) ( NTS )
Copyright (c) 1997-2018 The PHP Group
Zend Engine v3.3.18, Copyright (c) 1998-2018 Zend Technologies
with Zend OPcache v7.3.18, Copyright (c) 1999-2018, by Zend Technologies
LARAVEL VERSION:
v7.20.0@682ea946bc136aa686d5a64940ab3d4a24d5a613
BACKPACK VERSION:
4.1.14@f4a6ad91f2aa3760ffe963c5cd87d2b533803323

@nbolender there must be some misunderstanding here - the boolean field type is just an alias for the checkbox field type. And its definition does NOT include options, it's just a simple checkbox with a label next to it.
You must looking for the select_from_array field type or the radio field type? Those indeed have an options attribute.
Cheers!


Render the window right away, even when async

File scanning can take a particularly long time, so having async_directory_scan = "always" can introduce a huge delay before the window is finally opened.
A better behavior would be to open the window right away, before scanning the directory.

Partially related: #713.

Hopefully something can be done to fix this issue

Hi, I created a possible solution to this issue at #752.
Besides, I am thinking of mainly discussing about this over on #713 so please follow that issue if you are interested.

I have a new fix for this in #1015. Can someone try it out and let me know how it works?
@musjj @charbelnicolas


Fix for #994 (Docker image broken)

This is a fix for the docker image, as the automated build (it is automated right?) creates an image that does not work.
I have not built the docker container myself, but I have re-run the install.sh script on it. It reinstalls without errors now, so it should work when being built as well.
EDIT: Didn't read README before submitting. I can't get the dev branch to install correctly on any of my systems, so I am forced to stick with master. I am aware that this needs to be submitted to the dev branch, sorry about that.

@Strazzom you were right the first time. The base branch should be dev 😄


[TRACKING] Expand Falco metrics w/ rules counters -> deprecate falco-exporter + new Grafana dashboard for Falco metrics

For context on current Falco metrics refactor please see https://github.com/falcosecurity/falco/issues/3131.
libs will already feature a new flag called METRICS_V2_RULE_COUNTERS. Proposing to already prepare for this new metrics category in the upcoming Falco metrics refactor to fully support Prometheus @sgaist. Goal is to deprecate https://github.com/falcosecurity/falco-exporter.
In addition, we need to decide who implements this. I won't have time for Falco 0.38.0 🙃 .
@leogr @alacuku @Issif re Grafana dashboard: How do we want to go about the design? Would you want to collect feedback from various folks in order to distill the most useful metrics? Happy to post a list of the most critical metrics from my perspective.
It would be cool to upstream our new Grafana dashboard to the CNCF Environmental Sustainability Technical Advisory Group (TAG ENV) - Green Reviews Working Group initiatives.

https://github.com/falcosecurity/cncf-green-review-testing/issues/12
https://github.com/falcosecurity/cncf-green-review-testing/discussions/14

/milestone 0.38.0

Dashboards still pending, cc @leogr and @alacuku perhaps track that in a new issue?


Refactor RDF ontologies in blocks-core

Some basic RDF classes are wired-in too deep (into the blocks-core module), conflicting with other higher level implementations. We should move them out to a separate module.

Note:
com.beligum.blocks.rdf.ontology.factories.Person is used throughout the code as a synonym as the logged-in SQL Person, which is a bit troublesome, because they're actually two different things.

Moving these out of blocks-core:
Person
Organization
Country
City
To solve the "Which user made the edit?" question, we introduced a simple userId property (instead of trying to map the existing SQL user to the RDF ontology)

To move classes away in a structured manner, we introduced the blocks-ontologies submodule, introducing its first blocks-ontologies-commons module where all common endpoints will be moved in the first place.

By the way, we renamed the concept of the local vocabulary from settings to local because it makes more sense. So eg. SettingsQueryEndpoint became LocalQueryEndpoint. It used to be named "settings" because the name of the locally hosted vocabulary is configured in the settings xml.

Created the com.beligum.mot.site.config.FixOntologyMessagesTask to fix the message label issues that are introduced by this refactor.


Tier one common examples

Summary
Unify common examples for tier one BSPs to reduce code duplication.
Checklist

[ ] CHANGELOG.md for the BSP or HAL updated
[ ] All new or modified code is well documented, especially public items
[ ] No new warnings or clippy suggestions have been introduced (see CI or check locally)
[ ] Add compilation of these common examples to CI

Fair criticism, I can see that perspective. I didn't think it was too bad but it might be enough to obscure things too much for people wanting to copy-paste get started on their project. Any other opinions?


Fix import issue for Kibana v6.7.0

Additionally delete not needed unit for bottom

Can you re-target this PR to 6.7 branch instead of master

Thanks for point this out and fixing


Race Condition reported in unit tests

I modified the Makefile so it would enable race condition checking when testing.
test:
	@go test ./... --race --count=3

( I also added --count just to work it a bit harder)
There is a race condition being reported.
It's when you renew the visibility of the consumer on line 184 of consumer_test.go
Maybe Consumer.VisibilityTimeout should be private so it can't be modified once the goroutines are running.
This should probably also apply to the other public fields of Consumer.
$ make test
==================
WARNING: DATA RACE
Write at 0x00c0000ee8b0 by goroutine 42:
  github.com/qhenkart/gosqs.TestRun.func5()
      /home/mark/src/gosqs/consumer_test.go:184 +0x54
  testing.tRunner()
      /usr/local/go/src/testing/testing.go:1259 +0x22f
  testing.(*T).Run·dwrap·21()
      /usr/local/go/src/testing/testing.go:1306 +0x47

Previous read at 0x00c0000ee8b0 by goroutine 34:
  github.com/qhenkart/gosqs.(*consumer).extend()
      /home/mark/src/gosqs/consumer.go:270 +0x77
  github.com/qhenkart/gosqs.(*consumer).run·dwrap·2()
      /home/mark/src/gosqs/consumer.go:189 +0x64

Goroutine 42 (running) created at:
  testing.(*T).Run()
      /usr/local/go/src/testing/testing.go:1306 +0x726
  github.com/qhenkart/gosqs.TestRun()
      /home/mark/src/gosqs/consumer_test.go:183 +0x3ca
  testing.tRunner()
      /usr/local/go/src/testing/testing.go:1259 +0x22f
  testing.(*T).Run·dwrap·21()
      /usr/local/go/src/testing/testing.go:1306 +0x47

Goroutine 34 (running) created at:
  github.com/qhenkart/gosqs.(*consumer).run()
      /home/mark/src/gosqs/consumer.go:189 +0x264
  github.com/qhenkart/gosqs.TestRun.func2()
      /home/mark/src/gosqs/consumer_test.go:162 +0xf2
  testing.tRunner()
      /usr/local/go/src/testing/testing.go:1259 +0x22f
  testing.(*T).Run·dwrap·21()
      /usr/local/go/src/testing/testing.go:1306 +0x47
==================
--- FAIL: TestRun (2.45s)
    --- FAIL: TestRun/renew_visibility (2.12s)
        testing.go:1152: race detected during execution of test
    testing.go:1152: race detected during execution of test
FAIL
FAIL	github.com/qhenkart/gosqs	9.703s
?   	github.com/qhenkart/gosqs/examples	[no test files]
ok  	github.com/qhenkart/gosqs/sqstesting	0.040s
FAIL
make: *** [Makefile:5: test] Error 1

@MarkSonghurst Thanks for the issue! I think this stems for from my habit of writing cascading tests that aren't really meant to run concurrently. That being said, you've made a very good point. By allowing clients to modify these fields, I am opening the door for them to create race conditions. As these fields are meant to set up once during configuration, I agree that the fields should be private to enforce only one safe pathway to modify these fields before goroutines are initialized.
Thank you very much for the suggestion. If you would like to make a pull request, I would happily accept it


VM interface

I am splitting this PR into several ones to accommodate for the new VM changes, and ease their review.
Goal
This PR introduces the VM interface. The interface is used for the libp2p protocol integration.

//cc @barath (I can't add you as a reviewer. I guess it is because you don't have the right permissions).


Feature: Add option to disable bucket creation

This PR will add the option createAssetBucket with the default value set to true. It also fixes some issues where it would fail to deploy if the bucketName was resolved to null or undefined.
This fixes #100 and potentially #102 and #86 as well. It's also a workaround for #103 since it allows you to manually set up your bucket with unique resource names.

Thanks for implementing, will get it published now 👍


Allow consuming multiple subs

MVP Solution 🤖 ❗
Simple wrapper command will allow consuming multiple subs. Currently, the package can only consume one sub via queue:work command  (--queue does not change sub), because it's a static variable defined in config. 😞
Ideally, consuming and publishing should be decoupled and customizable, but we have what we have 😄  🚀  Agile and MVP FTW 📈

So if I'm understanding this correctly, your changes would allow multiple subscribers to be utilised through your command that subsequently works multiple queues?
eg:
$:> artisan pubsub:consume product-stock-sub && artisan pubsub:consume product-data-sub
would spin up 2 separate queues at the same time that have different subs set?


Trigger Filtering

Status
READY
JIRA Ticket
SPACON-397
Description
A few sentences describing the overall goals of the pull request's commits.
Todos

[x] Tests
[x] Documentation
[x] License

Steps to Test or Reproduce
Outline the steps to test or reproduce the PR here.
git fetch --all
git checkout <feature_branch>
lein test

@boundlessgeo/spatial-connect

👍


add evaluation data source

The training and evaluation dataset is usually different and in a lot of the cases need to be separated by time not by random sample. e.g. training is data from 2015 and eval is data from 2016.
The current Aerosolve config doesn’t support adding evaluation dataset. This PR is to add this option to the user. As suggested by @deerzq , I refactored the makeTraningrun to make it more generic to make both the training and evaluation dataset(optional)
@jq @saurfang

In this case, if people just want to run makeEvaluation not makeTraining, it will not work. I feel perhaps you can have
makeTraining(sc, query, isMulticlass).coalesce(numShards, shuffle).map(Util.encode).saveAsTextFile(evalOutput, classOf[GzipCodec])
in one function, which takes query and output in as input. Then in makeExampleRun, you can check if the config has path training_hive_query, if so you run the above function for training; then you check if the config has path eval_hive_query, if so you run the above function for eval. Then people can run either training or eval or both.

oh, you may want to update https://github.com/airbnb/aerosolve/blob/master/training/src/main/resources/demo_train.conf#L90
and https://github.com/airbnb/aerosolve/blob/master/training/src/main/resources/demo_multiclass_train.conf#L51

And also update the aerosolve hackpad

@deerzq good suggestions. I updated it to make it backward compatible as well as updating the demo conf. Will update the hackpad once the new jar is published

LGTM

thanks Peng


Example .onmicrosoft.com domain typo

Referring to paragraph "Using the "Microsoft Teams admin center"

In the left navigation, go to Voice > Direct Routing, and then click the SBCs tab.
Click Add.
Enter a FQDN for the SBC.
Make sure the domain name portion of the FQDN matches a domain that's registered in your tenant and keep in mind that the *.onmicrosoft.com domain name isn't supported for the SBC FQDN domain name. For example, if you have two domain names, contoso.com and contoso.on.microsoft.com, use sbc.contoso.com as the SBC name."

Please update the document to proper ".onmicrosoft.com" instead of ".on.microsoft.com" domain.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ad7d5051-1177-c5cf-bf28-8639d7b6fbd1
Version Independent ID: 2a9aa4e1-3767-cd46-50fe-f9dd8b0997be
Content: Connect your Session Border Controller (SBC) to Direct Routing - Microsoft Teams
Content Source: Teams/direct-routing-connect-the-sbc.md
Service: msteams
GitHub Login: @CarolynRowe
Microsoft Alias: crowe

@stefandoh Thank you for submitting feedback and contributing to the docs. We are currently investigating this.

Hi @stefandoh, It was updated/fixed 19 days ago.
Thanks for taking out some time to open the issue. I appreciate and encourage you to do the same in the future also.

@stefandoh Thank you for submitting feedback. We understand that this issue has been resolved.
Please feel free to re-open this issue if there is a specific area of the docs that we can improve or make better. Thank you.


Is OfflineFindingScanner supported on Windows?

Is OfflineFindingScanner meant to work on windows?
If so, it doesn't and also it doesn't give a graceful error message

makes me think it's not, but it would be great if there was a more relevant error message. Also "platform agnostic" is in the readme which is a little confusing?

Thanks for reporting this! It should indeed work on Windows, but I haven't actually been able to test that myself. It looks like the library behaves a little differently on Windows compared to Linux/Mac OS, which is causing the issue.
Unfortunately I don't have a lot of time to look into this right now, but I intend to pick development back up very soon and will fix this asap.

macos returns this tuple

while windows returns a BluetoothLEAdvertisementReceivedEventArgs

This should now be fixed on main and will be included in the next release which is scheduled for this week. Please let me know if the issue persists.


Fix: Minor typo on portuguese operator page

This PR fixes a minor typo on the portuguese translation for Kubernetes operators. I haven't used a development branch as it doesn't exist one for portugueses.

/approve
/lgtm


Automated Package Upgrade

:tada: This PR is included in version 2.2.90 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


refactor(kernel): export actual rule/filter rule/plugin interface

ref #248

https://github.com/textlint/textlint/pull/372/commits/b0eba3bd3013a1425f61fde9fd5272d8d65b4a0b related with #373


Query: Story behind OUYA support

I was confused when I saw the name, and had to look it up. Apparently this console was only sold in 2013-15, and only 200k units. Support was added April of this year, so I'm curious if there is a story that you wouldn't mind sharing?

Hi, not really, and in fact I don't even own an OUYA console/controller.
This was implemented in #48 because the Xelu's controller pack already has icons for this controller, and it's possible that there are users with this type of controller on PC.

Ahh, alrighty. Thanks


Added new formats for parsing time

In this commit, functions have been added to handle other date and time formats.
Added function to parse time given in text format to LocalTime for some scenarios where we can use the LocalTime directly.
Added function to parse date given in format ("%d%m%Y"), in the previous function we have some conditions to check for special character, as this format doesn't have any special characters in between thus we used isolate function to fetch date from the given input.

Add the latest bench marks and also the old ones.

Add the latest bench marks and also the old ones.

Updated the benchmarks.


Bind missing FixedMaterial constants, fixes #2628

Bind FixedMaterial LightShader enum to use on scripting.

:+1: Looks good :smile:


Travis failing against JRuby due to dependency issue

As seen at https://travis-ci.org/neo4jrb/neo4j/builds/90363069.
Our dependency on Coveralls has a dependency on tins. That gem's new version was released yesterday and requires Ruby >= 2.0.0, so JRuby blows up.

New Coveralls release fixes this.


Detect presence of better-wp-security

This wordpress plugin can be ban users scanning sites.
The check performs an additional request only if the site appears to be a wordpress site.

Anything I can do to improve the PR?

hey - sorry didn't get to test it yet!


Ensure no bastion is started when var.vault_create_bastionhost is false.

Done, there were a few "bastion" resources that are now created conditionally. (Push will be later.)


Update MiMA and fix issues it noticed.

We want compatibility with 0.3.0, so I updated the plugin, updated the version
to be checked (was 0.2.4 which meant lots of bogus incompatibilities were
reported) and then fixed the issues.

You can verify with coreJVM/mimaReportBinaryIssues.

Once this lands I want to do a release for Scala 2.13.

Looks good but CI failed.
After we merge this and when we next need to break we should remove that compatibility method since the name is brutal.

Codecov Report

Merging #44 into master will decrease coverage by 2.29%.
The diff coverage is 33.33%.

@@            Coverage Diff            @@
##           master      #44     +/-   ##
=========================================
- Coverage   84.57%   82.27%   -2.3%
=========================================
  Files          13       13
  Lines         376      378      +2
  Branches       20       15      -5
=========================================
- Hits          318      311      -7
- Misses         58       67      +9

Impacted Files
Coverage Δ

core/src/main/scala/com/stripe/dagon/Dag.scala
84.86% <0%> (-0.79%)
:arrow_down:

core/src/main/scala/com/stripe/dagon/Expr.scala
55.17% <100%> (-10.35%)
:arrow_down:

core/src/main/scala/com/stripe/dagon/Literal.scala
50% <0%> (-11.77%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69d0aa4...0b9180f. Read the comment docs.

@johnynek A lot of these updates are to get MiMA and Travis working, but the rest are to get ready for trying to support Scala 2.13.
We're going to have to decide what to do about Stream since we do use it. Honestly I'm tempted to call this 0.4.0 and break bincompat just so we can get out of having Stream in our public API. What do you think?

Sure, I think that’s fine. Let’s do 0.4.0 and minimize hacks.


Command error handling

Fixes: #2004
Some new traits were introducted:

FallibleCommand

this is for command that can potentially fail, and allow people to provide error handlers if an error occurs

CommandErrorHandling

this is for function like types that can handle command errors.

If a command is fallible, then new return type is a Config type.
The Config type allows a user to optionally provide an error handler via on_err_do.
However, I added some builtin handlers (via CommandErrorHandler) like ignore() panic() and log() for some typical use cases of what someone might want to do with an error.
note: the default behavior is log(). None of the commands will panic! but will instead log the error via error!.
EXAMPLES:
fn system(mut commands: Commands) {
    commands.entity(e)
        .insert(32)
        .on_err_do(|error| { /*..*/ });

    command
        .remove_resource::<f32>()
        .on_err(CommandErrorHandler::ignore);

    commands
        .entity(e)
        .despawn()
        .on_err(CommandErrorHandler::panic);

    commands
        .entity(e)
        .insert(32)
        .insert(3.14); // you can also ignore the error handling and just chain regular commands
}

I would prefer to use a System<In = Error, Out = ()> rather than introduce a new lambda with World access

I would prefer to use a System<In = Error, Out = ()> rather than introduce a new kind of closure with World access

this is a fair concern, however is it possible to create a system without allocations?
Specifically, I went this route since I don't have to wrap the error handler in a Box<_>

I was thinking that it might be valuable to have a global error handling for certain classes of error, but on reflection I feel that's an antipattern. I think that the better approach is going to be to provide nice functionality for enforcing error handling in whatever form as part of a Bevy-specific linter (#1602).

this is a fair concern, however is it possible to create a system without allocations?

Not sure, it would probably be hard to capture all the types needed for a FunctionSystem

Specifically, I went this route since I don't have to wrap the error handler in a Box<_>

Why not? I'm not sure of the impact of Boxing a system.

Also, I feel this adds a lot of unnecessary baggage to what is supposed to be a simple error handler.
True exposing &mut World to a random lambda is weird, but unless there's a specific reason to wrap it in a System, should we?

It's more baggage in the implementation, but I feel it's less for the user. but then as there's world access, you end up using the same api in your error handler as in an exclusive system, right?

True exposing &mut World to a random lambda is weird, but unless there's a specific reason to wrap it in a System, should we?

IME reading / writing normal systems is much easier than exclusive systems, in large part due to the implicit documentation of the function parameters.
This also makes any future migration to running these things in automatic parallel much less painful, since they're already scoped.

It's more baggage in the implementation, but I feel it's less for the user. but then as there's world access, you end up using the same api in your error handler as in an exclusive system, right?

Yea that's fair :)
And as @alice-i-cecile said, it would be easier to parallelize these if that ever becomes possible in the future.

Why not? I'm not sure of the impact of Boxing a system

It's just extra memory allocations that I'm trying to avoid if possible.
However, I guess this'll be ok since the memory allocations only happens in the path where you actually specific an error handler.

I also don't expect this pattern to be used much in performance sensitive contexts; it seems much better suited to one-off or occasional system execution in a scripting like way.

IME reading / writing normal systems is much easier than exclusive systems, in large part due to the implicit documentation of the function parameters.

Hmmm the more I try to implement this via systems, the more I dislike it.
With the current standing we have something like:
fn on_failure<H: System<In = ErrorType, Out = ()>>(&mut self, handler: H) { /*..*/ }

However this requires that the user know that type of ErrorType.
And with all of the different possible errors, this is not trivial.
For example despawn() has a DespawnError and insert() has an InsertError`.
Also, type deduction cannot be used.
So this is no longer valid:
commands.entity(e).despawn().on_failure(|infered| {}); // `infered` can no longer be infered

The user is now forced to use In<ErrorType>.
So now the user has to spell out:
commands.entity(e).despawn().on_failure(Box::new(|error: In<DespawnError>| { /*..*/ });

I would like to point out that I do actually like how we can coalesce everything into a system, and how this can provide A LOT of benefits.
However, it is worth pointing out some of the pitfalls.

Personally I'd rather not make it so just adding an error handler requires an heap allocation, as this will discourage adding them. Another point is that while exclusive systems can run regular systems, and there are plans to make direct world access more ergonomic with a more system-like API, the reverse isn't true. I'd recommend having a barebones error handling mechanism directly based on &mut World, especially for this first PR.

Having seen the results of your experiment, I think @TheRawMeatball is probably right above, as much as it pains me to encourage more "operate directly on the entire world" logic.
This needs to be ergonomic, and the heap allocation is a little 😬.

I feel likes there a bit of a asymmetry between ingore and the other error handlers.
Is it worth calling ignore ignore_failure or something of the sort??
Another option is:
commands.entity(e).insert(32).on_failure().handle(/* custom error handler */);

commands.entity(e).despawn().on_failure().ignore();

commands.entity(e).despawn().on_failure().log();

@alice-i-cecile and @TheRawMeatball , I'm curious what your thoughts are here.

This is a question:
do we want to rework the entire Command trait to implement the error handling??
trait Command {
    type Error;

    fn write(self: Box<Self>, &mut World) -> Result<(), Error>;
}

Where if a command is infallible, you can just do
impl Command for MyCommand {
    type Error = std::conver::Infallible;

    fn write(...) { /*..*/ }
}

Pinging here to see if there is any desire to move forward with this API?
Specifically I would love to get some input form @cart but anyone else who has some input/reviews to send my way that'd be awesome :)

This is a very serious improvement, and will make using commands much safer. I would expect us to persist with this style of API in some form even as we reduce our reliance on Commands per se moving forward.

Just gave this a look. I think this is generally the right direction (until we overhaul Commands). I think the multiple on_err / on_err_do functions are a bit confusing. And the types + inference are a bit unwieldy.
I just pushed some (proposed) changes that simplify the implementation, remove the need for on_err_do, and improve ergonomics in some cases. With these changes, only a single on_err function is needed and the error type never needs to be specified (because it is inferred).
I think we should do a quick benchmark to see what this error handling costs us in practice compared to the previous impl. Probably something along the lines of:

Despawning LARGE_NUMBER entities with a error handler identical to the previous inlined "debug log" impl. This tests the "hard coded debug log" -> "command error debug log" case.
Spawning LARGE_NUMBER entities (without explicit error handling). This tests the "previously had no error handling" -> "now has implicit error handling" case.

I think we should do a quick benchmark to see what this error handling costs us in practice compared to the previous impl. Probably something along the lines of:

We can use the commands bench-marking from #2334 once that gets merged.

Here are the perf measurements for calling CommandQueue::apply after call entity(E).despawn()
group                          DESPAWN-ERROR-MAIN                     DESPAWN-ERROR-NEW
-----                          ------------------                     -----------------
despawn_error/0_entities       1.01      9.4±0.28ns        ? ?/sec    1.00      9.3±0.39ns        ? ?/sec
despawn_error/1000_entities    1.00      9.3±0.24ns        ? ?/sec    1.01      9.4±0.38ns        ? ?/sec
despawn_error/1500_entities    1.00      9.3±0.68ns        ? ?/sec    1.01      9.4±0.24ns        ? ?/sec
despawn_error/2000_entities    1.01      9.3±0.31ns        ? ?/sec    1.00      9.3±0.31ns        ? ?/sec
despawn_error/500_entities     1.00      9.2±0.24ns        ? ?/sec    1.00      9.3±0.24ns        ? ?/sec

I ran some perf-tests for this and had the following results:
group                          DESPAWN-ERROR-MAIN                     DESPAWN-ERROR-NEW
-----                          ------------------                     -----------------
despawn_error/0_entities       1.00     10.0±0.46ns        ? ?/sec    1.03     10.2±0.26ns        ? ?/sec
despawn_error/1000_entities    1.00     54.6±2.26µs        ? ?/sec    1.07     58.7±2.70µs        ? ?/sec
despawn_error/1500_entities    1.00     77.1±1.92µs        ? ?/sec    1.12     86.5±2.70µs        ? ?/sec
despawn_error/2000_entities    1.00    103.4±3.29µs        ? ?/sec    1.10    114.2±4.72µs        ? ?/sec
despawn_error/500_entities     1.00     29.6±0.74µs        ? ?/sec    1.07     31.7±1.63µs        ? ?/sec

The error-handling version (unsurprisingly) took a little performance hit since now we store an error-handler, and there is extra logic for when you actually add an error handler.
I'm going to see if I can change anything to help reduce the perf impact, though if anyone has ideas, please shoot them my way :)

pinging here.
Is this PR still a feature people would like implemented?
I've been trying to fix the performance degradation recently and have come up with a possible solution.
(specifically pinging @alice-i-cecile)

Is this PR still a feature people would like implemented?

Yes please! I'd be happy to review this again once it's ready. There may be light changes to how commands work with upcoming scheduler work, but I don't think anything that's likely to conflict.

@NathanSWard I'm looking to revive this; would you prefer I create new PR, make PRs to this or be granted write permissions to your fork>

To anyone who is interested, I picked up this PR and created a new one per the guidelines, you can find it here:
https://github.com/bevyengine/bevy/pull/11184

Closing as adopted :)


Types in a namespace with same name as a function type are not documented

Search terms
namespace, function, const
Expected Behavior
A type declared inside an exported namespace should be documented, even when the namespace shares the name of a function type.
/**
 * Test function
 *
 * @param options Options for the function
 */
declare const test: (options?: test.Options) => void;

declare namespace test {
  /** Test options */
  interface Options {
    a: string;
    b: number;
  }
}

export { test };

Actual Behavior
In the above example, the inner type test.Options is not being documented. I am getting a warning in the terminal:
[warning] test.Options, defined in ./index.ts, is referenced by test.test.options but not included in the documentation.

This seems related to #2476, but still occurs in TypeDoc v0.25.7 when a namespace shares the name of a function type (not a function declaration).
Steps to reproduce the bug
Repro: https://stackblitz.com/edit/stackblitz-starters-qjgazd
For reference, this is the full type declaration file where I originally found this problem: https://github.com/origin-1/c8js/blob/31a262b396c98d95622fcc4b1a31fe04a7d314ea/lib/c8js.d.ts

Environment

Typedoc version: 0.25.7
TypeScript version: 5.3.3
Node.js version: 2.0.10
OS:

Bah, of course I missed that case... function-variables are handled in a different spot. Should be an easy fix at least


Export CSV of rewards

Story
As a user
I want to easily export rewards and fees received by my key
So that I can track my earnings over time
Acceptance Criteria

[ ] I can export rewards and fees reflected on Governance dapp to CSV
[ ] I can understand what is included and what is not included in this export
[ ] I can see rewards across network upgrades i.e. not just since network restart (might need a separate ticket)
[ ] Rewards / fees in the CSV are easily sorteable / formatted i.e. showing relevant timestamp
[ ] Rewards / fees are organised by reward type i.e. staking, infra fees, price taking, price making, liquidity provision, market creation

Sketch / inspiration

Tasks

[ ] UX (if needed)
[ ] Design (if needed)
[ ] Team and stakeholder review
[ ] Specs reviewed and created or adjusted
[ ] Implementation
[ ] Testing (unit and/or e2e)
[ ] Code review
[ ] QA review

Sketch
Additional details / background info

Duplicate / merged with #2319


SUPER KEY not working

Hyprland Version
Hyprland, built from branch main at commit f8008e4b3beb4aae2365973879a46fe0f15c79b4 dirty (Nix CI: use DetSys' install & cache actions). Tag: v0.29.1-75-gf8008e4b
Bug or Regression?
Bug
Description
Hyprland Super key stopped working randomly. I attempted to reboot to resolve the issue, but it still persists. The only way I was able to fix it was by booting into Windows and then back into Linux. Unfortunately, I have since completely removed Windows, and now I am unable to use Hyprland. I also tried Gnome, but the same issue occurs.
How to reproduce
No
Crash reports, logs, images, videos
Super key before the issue

After the issue

Duplicate of #3310 ?

I also tried all these mod
SHIFT CAPS CTRL/CONTROL ALT MOD2 MOD3 SUPER/WIN/LOGO/MOD4 MOD5
$mainMod = MOD4
Still the same issue

Cannot reproduce, what is your full configuration?

Cannot reproduce, what is your full configuration?

https://github.com/shadowelite-sec/hypr/blob/main/hypr/.config/hypr/keybind.conf
https://github.com/shadowelite-sec/hypr/tree/main/hypr/.config/hypr

Maybe this will give you some inspiration?
from https://github.com/hyprwm/Hyprland/issues/3310#issuecomment-1720882586

OK, I found the issue and its neither Hyprland or a kernel issue, turns out my Laptop has a
super key toggle function.
The fix (for me at least) was to press FN+SUPER once and now SUPER is working as expected.
Might be a good thing to add to the FAQ, maybe?

Maybe this will give you some inspiration?
from #3310 (comment)

OK, I found the issue and its neither Hyprland or a kernel issue, turns out my Laptop has a
super key toggle function.
The fix (for me at least) was to press FN+SUPER once and now SUPER is working as expected.
Might be a good thing to add to the FAQ, maybe?

Hmm, this is weird. My issue just fixed itself by connecting an external keyboard. After pressing the Super key on the external keyboard, my laptop's Super key also started working.
I don't know when this problem will occur again.

Maybe this will give you some inspiration?
from #3310 (comment)

OK, I found the issue and its neither Hyprland or a kernel issue, turns out my Laptop has a
super key toggle function.
The fix (for me at least) was to press FN+SUPER once and now SUPER is working as expected.
Might be a good thing to add to the FAQ, maybe?

yes , its working . Thanks :)


Month selector 1st draft changes to estimator for client demo.

Description

Types of changes

Checklist

[ ] I have read the CONTRIBUTING doc
[ ] I have checked that unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)

Further comments

Closing due to sonar failure... fixing and will redo.


[FEATURE] Possibility to provide custom branch for templates

Is your feature request related to a problem? Please describe.
As of this moment seedfarmer will accept template URLs where the templates live in the main/default branch of the repository. With this we are limiting the capacity of having dedicated branches for multiple templates within a single repository.
Describe the solution you'd like
As we already provide the --template-url parameter, adding a --template-branch (which if is not specified the tool will have main as default value). This extra option will be used for the commands seedfarmer init project and seedfarmer init module
Describe alternatives you've considered
Looking at the code, the only alternative we have is adding this parameter, otherwise is already hardcoded to use branches available only in this (seedfarmer) repository.
Additional context
I can proceed to prepare this functionality and submit a Pull Request for your evaluation.

@luisosses I think I understand what you are requesting:  If you have a different git repo (other than seed-farmer repo) that you want to use, you can specify that repo.  AND...you want to add the ability to change and use a branch in that repo for the init.
I want to confirm with you he use case and also assure that we cannot provide any cookiecutter validation for any branches outside of the ones that SF provides for init.

Hello @dgraeber that's correct!
In the same way we are providing the possibility already of using a different repo with the --template-url parameter without any cookiecutter validation, but extending the functionality to be able to provide a branch.
The specific use case would be a single repository dedicated  or providing different templates in different branches (e.g. different IaC tools based templates for modules) - instead of needing a fully exclusive repository for a single template (which somehow we are "forcing" at the moment).
Let me know if I need to add something in the PR #666
Thanks!


Terragrunt Structure for China and Gov Cloud

Hi All,
Just wanted to get some of your recommendations for the terragrunt folder structure if we had prod environments in:
Same Account

us-west-2
us-east-1

Different Accounts

us-china
us-gov

I was thinking we could have us-west-2 and us-china environments in the same folder structure for terragrunt/live/prod, but it looks like that groups stacks together in the same AWS account. So it would need to be terragrunt/live/china and terragrunt/live/gov.
Just wanted to ping here for your recommendations? @ArchiFleKs

Hi @zestrells What do we mean it staked together ? Yes in general I segment AWS account at the environment level. Personnaly I like to do:
terragrunt/live/account1/us-west-2
terragrunt/live/account1/us-east-1
terragrunt/live/account2/us-china
terragrunt/live/account3/us-gov

You can then make use of the terragrunt assume role ARN to switch between account if you have a root accountfor example with iam_role = "arn:aws:iam::${local.merged.aws_account_id}:role/github-action-iac-administrator" in each environment / account terragrunt.hcl here.
Hope that's clear

Hi @ArchiFleKs , sorry to be pinging you so often. Did you have any troubles leveraging terragrunt in China? I am running into the following issue when first running terragrunt to create all components including s3 state backend from a cn-north-1 ec2 instance. We validated that our egress for our Security group is <IP_ADDRESS>/0, so we are confused why this is arising or what the potential fix could be. Thank you for your help as always, we leveraged the suggestions you made above 😄
Initializing the backend...

Successfully configured the backend "s3"! Terraform will automatically
use this backend unless the backend configuration changes.

Initializing provider plugins...
- Finding latest version of hashicorp/aws...
╷
│ Error: Failed to query available provider packages
│
│ Could not retrieve the list of available versions for provider
│ hashicorp/aws: could not connect to registry.terraform.io: Failed to
│ request discovery document: Get
│ "https://registry.terraform.io/.well-known/terraform.json": net/http: TLS
│ handshake timeout

Hi @ArchiFleKs , sorry to be pinging you so often. Did you have any troubles leveraging terragrunt in China? I am running into the following issue when first running terragrunt to create all components including s3 state backend from a cn-north-1 ec2 instance. We validated that our egress for our Security group is <IP_ADDRESS>/0, so we are confused why this is arising or what the potential fix could be. Thank you for your help as always, we leveraged the suggestions you made above 😄

Initializing the backend...

Successfully configured the backend "s3"! Terraform will automatically

use this backend unless the backend configuration changes.

Initializing provider plugins...

- Finding latest version of hashicorp/aws...

╷

│ Error: Failed to query available provider packages

│

│ Could not retrieve the list of available versions for provider

│ hashicorp/aws: could not connect to registry.terraform.io: Failed to

│ request discovery document: Get

│ "https://registry.terraform.io/.well-known/terraform.json": net/http: TLS

│ handshake timeout

Seems more a Terraform / Egress connection issue than related to Teks or this module IMO


Fix unchecked type Scala compiler warnings.

Subtask of #969
Fix warnings related to unchecked type usage in match blocks. These should probably be skimmed for correctness (incorrect cases executed) and annotated with @unchecked.
/Users/james.baiera/Documents/source/elasticsearch-hadoop/spark/core/main/scala/org/elasticsearch/spark/serialization/ScalaValueReader.scala:228: non-variable type argument AnyRef in type pattern Seq[AnyRef] is unchecked since it is eliminated by erasure
        case col: Seq[AnyRef] => {
                  ^
/Users/james.baiera/Documents/source/elasticsearch-hadoop/spark/sql-20/src/main/scala/org/elasticsearch/spark/sql/ScalaEsRowValueReader.scala:103: non-variable type argument String in type pattern Seq[String] is unchecked since it is eliminated by erasure
      case (pastInArray: Boolean, pastRowOrder: Seq[String]) => { inArray = pastInArray; currentArrayRowOrder = pastRowOrder }
                                                ^

These warnings has been fixed in #940.


using Rancher, HostConfig.Link is always empty.

Hi,
First of all, i'm a new Rancher user, and i must say, you guys did an amazing work! :+1:
now, i've migrated my stack to use rancher,
in my stack i have a cronjob that is running periodically, and running docker inspect
on the containers to determinate dependencies.
however, since start using rancher, the HostConfig.Links is always empty (null)
Rancher Version: 1.1.2
Docker Version: 1.12
OS and where are the hosts located? (cloud, bare metal, etc): coreOs @ DO
Setup Details: (single node rancher vs. HA rancher, internal DB vs. external DB)
3 hosts, running total of 11 containers.
Environment Type: (Cattle/Kubernetes/Swarm/Mesos) Cattle
Steps to Reproduce:

Run a stack with links
db:
image: 'mongo:latest'

db-2:
image: 'mongo:latest'
links:
- "db:db"
db-3:
image: 'mongo:latest'
links:
- "db-2:db"
2. Inspect each one of them.
Results:
HostConfig.Link is null for all containers.
Expected:
db: HostConfig.Link should be null.
db-2: HostConfig.Link should have an array with [db] in it.
db-3: HostConfig.Link should have an array with [db-2] in it.

@DxCx we emulate links in rancher, we dont use docker links. I believe those are deprecated, so docker plans on dropping them as well.


Exclude build artifacts from coverage reports

Signed-off-by: Devin Nakamura<EMAIL_ADDRESS>

thanks!


Don't run analyze, coverage, docs on Mac

Submitting on red as build is red due to cancelling travis jobs that this PR is disabling.


Fix license problems

From @justinmclean on the most recent vote thread<EMAIL_ADDRESS>I’ve not done a full check but noticed a couple of minor things:

NOTICE file contains LICENSE information that should be in LICENSE
LICENSE is missing licenses for [1][2]
The files [1][2] and [3] also incorrectly have had ASF headers added, there might be others.

Thanks,
Justin

./zipkin-ui/libs/dagre-d3/js/dagre-d3.js
./zipkin-ui/libs/chosen/chosen.css
./zipkin-ui/libs/dagre-d3/js/dagre-d3.min.js

https://github.com/apache/incubator-zipkin/pull/2568 should fix this. I will add another issue to remind us to remove the statements from the LICENSE file as the corresponding module (zipkin-ui) is scheduled to be deleted soon.


chore: update lockfileVersion of package-lock.json to v2

Node v16+ bundles npm v8, which generates lockfileVersion v2.

Codecov Report

Merging #694 (8a0ba8c) into master (38f1420) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #694   +/-   ##
=======================================
  Coverage   51.39%   51.39%
=======================================
  Files          24       24
  Lines        1043     1043
  Branches      198      198
=======================================
  Hits          536      536
  Misses        459      459
  Partials       48       48


fix(Observable): remove unexpected dev dependency type references

Description:
This PR amends unexpected type references occurs in transpiled type definition, seems it was known issue of TS (https://github.com/Microsoft/TypeScript/issues/11948, https://github.com/Microsoft/TypeScript/issues/11849). Updated TS to latest dev to avoid this issue.
Related issue (if exists):

closes #2112

This change breaks tests, not sure exactly why. Digging bit more.

Most breaking test comes by this issue https://github.com/Microsoft/TypeScript/issues/12058.

@kwonoj parhaps, Did you change the line ending of spec/observables/dom/ajax-spec.ts accidentally?

@saneyuki This PR won't be checked in anyway.


release.yaml is conflicted

release.yaml is conflicted

kubectl apply -f https://storage.googleapis.com/tekton-releases/pipeline/previous/v0.19.0/release.yaml

Thanks for the issue report @gaoyajun01 - those are YAML anchors.  Not artifacts of a merge conflict.

Thanks for the issue report @gaoyajun01 - those are YAML anchors.  Not artifacts of a merge conflict.


support for dynamic request payload

Hi,
I am looking at your code (thanks for making it available - very helpful) with a view to supporting dynamic request payloads.  The use case is stateful APIs.  For instance requesting the last n seconds of results from an API or page n of the results.
My thoughts are that it requires the response handler to be able to alter the request payload data (used by the next request).  There may be a need to indicate whether another request should be made immediately (paging) or whether this polling cycle is done.
Is this something you have designed for or thought of?  Is it a feature your would be interested in adding (if I submitted a PR)?  Do you have any thoughts on implementation?
Thanks,
Anthony.

I think state is typically handled with OffsetStorageReader available in SourceTask. https://kafka.apache.org/0100/javadoc/org/apache/kafka/connect/storage/OffsetStorageReader.html
Take a look at how JDBC source connector uses it.
https://github.com/confluentinc/kafka-connect-jdbc/blob/master/src/main/java/io/confluent/connect/jdbc/source/JdbcSourceTask.java#L139
I think offsets stored in OffsetStorageReader are the "offsets" of the source system and not the offsets of Kafka topics.

I have written code to handle template based payload construction and it is quite a significant chunk of code.  I have written it as a part of the kafka-connect-rest-plugin sub-module, and I will submit a PR for it in a while, but I'm wondering whether it may be something that should be its own sub-module.  Perhaps you can have a look at the PR and advise on how it should be done.

There is an example of a template based transform in kafka-connect-transform-velocity-eval module. Is that similar to what you have in mind?
I’ll take a look at the PR in a bit.


Proposal: Media Player should use standard slider

Proposal: Use standard slider for Media Player
Summary
As part of issue #524, we are making the slider's thumb be round. This was a huge difference between the Media Player and standard version of slider. Now that this differnce is not important, it is proposed that we make them consitent.
Rationale

In an effort to remain consistent and cohesive across controls, we should update this item given the updates of the other slider design.

Scope

Capability
Priority

Developers are able to use WinUI2.2* package and without any work, get the new Windows visual style.
Must

Developers and end users experience control update that feel coherent with the same controls used by Fabric, Edge, and Xbox.
Should

*Timing here is not a commitment, but to follow the release cycle. Just using the next version #.
Design details and visuals
This impacts Media Player Element.
Visual comp
Important Notes
Open Questions

Reviewed with WinUI team and there was no immediate concern with the design's plan here.


Split the package into 'k8s-models' and 'k8s-servant-client'?

The idea is to let the developer have raw access (if needed). If I prefer wreq, I would like to use 'k8s-models' with 'wreq' directly.

Hey, thanks for submitting an issue! :)
Quick question: currently there is nothing tying the models to the client. So, you can depend on this package and use wreq if you'd like. It is the case that the models are packaged with the client and server information (because that is all derived from the API type) but there is nothing forcing their usage. So, can you confirm that what you are suggesting is:

package the k8s-models into it's own package.
package k8s-servant-client, k8s-servant-server into their own, separate packages, both of them depending on the k8s-models.
write bindings for wreq-based client.

I think 1 and 2 are great suggestions. 3 is not a priority (though we would gratefully accept a PR and could help you should you like to go down this road). The main issue is that writing wreq bindings will require a non-trivial amount of code-gen logic (we get the client in this case for free via specifying the API in servant).
Can you confirm I understand your issue correct? Thanks! :)

Yes. All 3 are precisely the points I wanted to make.
Yes, I could use wreq directly with the current haskell-kubernetes. However, stack was taking forever to build haskell-kubernetes. I had to force quit stack build, clone this repo, remove servant dependencies and related code. So, it would be great to keep the models separate.
Regarding 3, it is very hard to use haskell-kubernetes in its current state. None of the functions have documentation; as far as I understand, this is because they are generated by servant. Can this be somehow solved? With the wreq based bindings, I don't see this problem. I'll definitely work on this when I have some time.

@0x777 the only thing that should take unreasonably long to compile is the server, which I am thinking about deprecating because it's only a mock server and takes forever. In any case, I think it's a good idea to separate out the client and server as you suggested (note that the package takes a while to compile in general because there are over 100 data types and each has some template haskell).
Yeah, documentation is missing because of the way servant generates bindings (it generates the type for the API but there's not a clear way to include documentation there (this is a limitation of servant)). If you were to write wreq bindings then you could definitely include the documentation as it comes with the swagger specification for kubernetes.
By the way, to generate the client bindings you'll want to look at the API.hs template here (https://github.com/swagger-api/swagger-codegen/blob/master/modules/swagger-codegen/src/main/resources/haskell-servant/Apis.mustache) and pull that into this project (moving all the codegen out of swagger-codegen and into this project proper). In any case, your client bindings will iterate over the #apiInfo stuff here: https://github.com/swagger-api/swagger-codegen/blob/master/modules/swagger-codegen/src/main/resources/haskell-servant/Apis.mustache#L23
If you want to start thinking about generating the wreq bindings, I can start doing:

working on 1
working on 2
moving the codegen into this project proper.


refactor: unit tests of the self-signed certs in http backend

Description

Related Issue

Motivation and Context

Screenshots (if appropriate)

@gaius-qi fix lint


Update ZoomIT.download.recipe

PR is for this issue:
https://github.com/autopkg/smithjw-recipes/issues/7
Changes line 70 from:
<string>%RECIPE_CACHE_DIR%/unpack/Contents/Info.plist</string>
To:
<string>%RECIPE_CACHE_DIR%/unpack/zoom.us.app/Contents/Info.plist</string>

Opened https://github.com/autopkg/smithjw-recipes/pull/8 to address this problem.


DISABLE_WEBSOCKET_SSL=OFF build error at ss-sdk 2.0.2

IMPORTANT: Before you create an issue, please take a look at our Issue Reporting Guide.
Briefly summarize your issue:

Here is my build option
cmake
-DCMAKE_PREFIX_PATH=../sdk-install
-DWEBSOCKETPP_INCLUDE_DIR=$HOME/sdk_folder/third-party/websocketpp-0.8.1
-DDISABLE_WEBSOCKET_SSL=OFF
-DGSTREAMER_MEDIA_PLAYER=ON
-DCMAKE_BUILD_TYPE=RELEASE
-DPORTAUDIO=ON -DPORTAUDIO_LIB_PATH=/home/pi/sdk_folder/third-party/portaudio/lib/.libs/libportaudio.a
-DPORTAUDIO_INCLUDE_DIR=$HOME/sdk_folder/third-party/portaudio/include/
-DAPL_CORE=ON
-DAPLCORE_INCLUDE_DIR=$HOME/sdk_folder/apl-core-library/aplcore/include
-DAPLCORE_LIB_DIR=$HOME/sdk_folder/apl-core-library/build/aplcore
-DYOGA_INCLUDE_DIR=$HOME/sdk_folder/apl-core-library/build/yoga-prefix/src/yoga
-DYOGA_LIB_DIR=$HOME/sdk_folder/apl-core-library/build/lib
../alexa-smart-screen-sdk
Build error log as below
[ 57%] Building CXX object modules/Alexa/SampleApp/src/CMakeFiles/SampleApp.dir/SampleApplication.cpp.o
/home/pi/avs-1.19/alexa-smart-screen-sdk/modules/Alexa/SampleApp/src/SampleApplication.cpp: In member function ‘bool alexaSmartScreenSDK::sampleApp::SampleApplication::initialize(const std::vector<std::__cxx11::basic_string >&, const string&, const string&, std::shared_ptralexaClientSDK::avsCommon::sdkInterfaces::diagnostics::DiagnosticsInterface)’:
/home/pi/avs-1.19/alexa-smart-screen-sdk/modules/Alexa/SampleApp/src/SampleApplication.cpp:699:5: error: ‘m_webSocketServer’ was not declared in this scope
m_webSocketServer->setCertificateFile(sslCaFile, sslCertificateFile, sslPrivateKeyFile);
^~~~~~~~~~~~~~~~~
/home/pi/avs-1.19/alexa-smart-screen-sdk/modules/Alexa/SampleApp/src/SampleApplication.cpp:699:5: note: suggested alternative: ‘webSocketServer’
m_webSocketServer->setCertificateFile(sslCaFile, sslCertificateFile, sslPrivateKeyFile);
^~~~~~~~~~~~~~~~~
webSocketServer
Here is my solution as below. Please help to check does this change is ok or not
diff --git a/modules/Alexa/SampleApp/src/SampleApplication.cpp b/modules/Alexa/SampleApp/src/SampleApplication.cpp
index 8562c58..f2c20ab 100644
--- a/modules/Alexa/SampleApp/src/SampleApplication.cpp
+++ b/modules/Alexa/SampleApp/src/SampleApplication.cpp
@@ -696,7 +696,7 @@ bool SampleApplication::initialize(
std::string sslPrivateKeyFile;
sampleAppConfig.getString(WEBSOCKET_PRIVATE_KEY, &sslPrivateKeyFile);

m_webSocketServer->setCertificateFile(sslCaFile, sslCertificateFile, sslPrivateKeyFile);

webSocketServer->setCertificateFile(sslCaFile, sslCertificateFile, sslPrivateKeyFile);
#endif
m_guiClient = gui::GUIClient::create(webSocketServer, miscStorage);

What is the expected behavior?

Build ok
What behavior are you observing?

Build error
Provide the steps to reproduce the issue, if applicable:

Build with avs-1.19 with -DDISABLE_WEBSOCKET_SSL=OFF
Tell us about your environment:

What version of the AVS Device SDK are you using?
  <1.19>

Tell us what hardware you're using:

[ ] Desktop / Laptop
[*] Raspberry Pi
[ ] Other - tell us more:

Tell us about your OS (Type & version):

[ ] Linux
[ ] MacOS
[* ] Raspbian Stretch
[ ] Raspbian Jessy
[ ] Other - tell us more:

hello, thank you for reaching out!
It appears to be a typo, and the solution you illustrated should resolve the issue.
Please reach out again if you encounter more issues.

Closing this issue - please reopen if you encounter more errors.


Failing validation doesn't expose value of additional fields to template

If you add additional fields by splitting the 'message' field into an array (as per the readme) and validation fails, the plugin doesn't return the array of values on the 'message' field (so you can pre-fill values)—it just returns the content of the 'body' property of that array.

+1 ... this particularly sucks on large forms.
Is there any known workaround?

It is possible to resolve this by hacking contactform/controllers/ContactFormController.php
For line 133 change:
$message->message = $savedBody;

to:
$message->message = $postedMessage;

This will expose the message fields that have been created as an array. To access in your template just use, eg:
{{ message.message['body'] }}

Be interested to know if there are any security or other implications for this (apart from hacking the core files).

In our current implementation, a proper solution for this would be pretty involved and messy. Contact Form is purposely light-weight.  There are plenty of other more full-featured form builder/contact plugins available.


[Question]: Can I use llama-index , but use my custom nodes

Question Validation

[X] I have searched both the documentation and discord for an answer.

Question
 I already have docs for chunk-text, like BaseNode in llama-index,  can I use the index related the docs I custom? without the

But my docs already have independent structure，can I use it reference by llama-index?
Can I use class IndexNode in llama-index,  from the descrition, I think it can meet my needs.
the description with the class: :"Node with reference to any object.
This can include other indices, query engines, retrievers.

This can also include other nodes"

Can you provide some examples? I am not sure if I am understanding you correctly. Do you inherit BaseNode?


auto update release branch ondemand e2e

init
Execute e2e Tests for Latest Release Branches

Description

How can this be tested?

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 64.86%. Comparing base (1d5f49e) to head (4b88714).
Report is 19 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3775      +/-   ##
==========================================
- Coverage   65.00%   64.86%   -0.15%
==========================================
  Files         386      388       +2
  Lines       21130    21216      +86
==========================================
+ Hits        13735    13761      +26
- Misses       6080     6133      +53
- Partials     1315     1322       +7

Flag
Coverage Δ

unittests
64.86% <ø> (-0.15%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

@chrismuellner PTAL


Add delete topic api

resolve https://github.com/skiptests/astraea/issues/496 Add delete topic api

@chia7712 有空的話 再幫忙review 一下

AdminTest > testDeleteRecord() FAILED
[146](https://github.com/skiptests/astraea/runs/7592311055?check_suite_focus=true#step:5:147)
    org.apache.kafka.common.errors.UnknownTopicOrPartitionException: This server does not host this topic-partition.

this failed test is fixed by #529 already.


Listing [all] biostudies

Hi all,
I'm just wondering if the API supports listing all entries in the bioimage archive, that fulfill a certain criterion, e.g. having an attribute 'license=CC0'... Does the API suppot this? If not, how complicated would it be to change this?
Thanks!
Best,
Robert

Hi @haesleinhuepf ,
We are looking at ways to enable actual public search for BIA data (@sherwoodf), but for the moment the best option for finding something in particular is to search client-side, like (below) in the notebook here.


[Icon request] eye

On Github as used on the Watch counter/button or in general for views.
Material example: https://icon-sets.iconify.design/mdi/eye-outline/

Sorry for delay. I'm hoping to get to this in a few days.

Added few icons: watch and watch-off with -twotone variations and with extra icons that have infinite animation (eye blinking every 6 seconds and off line slightly moving)
But just noticed that I forgot to add watch-loop and watch-twotone-loop variations. I'll add them in next release, probably later today.
Gif preview:

But just noticed that I forgot to add watch-loop and watch-twotone-loop variations. I'll add them in next release, probably later today.

Added.

Thank you so much!


Atari environments not training

I am trying to train Atari models using the Colab notebook linked to in #43. The code is essentially identical to that in the official stable-baselines docs. I haven't touched the code at all.
The agent does not seem to train. I've tried Breakout as well as Pong, I've tried ACER as well as PPO2, I've tried training for a long time. Nothing seems to work. E.g. for Pong, ep_reward (or equivalent) stays consistently at about -20.9 :slightly_frowning_face:
To verify that it really isn't working, I render some frames using
import matplotlib.pyplot as plt
obs = env.reset()
for i in range(1000):
    action, _states = model.predict(obs)
    obs, rewards, dones, info = env.step(action)
    plt.imshow(env.render(mode='rgb_array'))
    plt.grid(None)
    plt.show()

which confirms that the "trained" agent is behaving randomly.
Am I missing something? Have recent changes to the project and/or TF broken the example code? Is the notebook working for others?

Hello,

The agent does not seem to train.

How long did you train it? And what is your setup (please fill the issue template ;))
Anyway, I would recommend you to use the rl baselines zoo which makes it easier to train and test agents.
The code contains tested hyperparameters and the best practices for using stable-baselines ;)
Note: I'm currently running the notebook too to check ;)

Thanks so much Antonin! I'm trying out the zoo notebook right now.

The only known tuple of algorithm-env where we are aware there may be an issue is ACER on Breakout (see #103 ). However, it works for all other tested Atari games.

So, both with the colab notebook and rl zoo, it seems that A2C is training fine on Breakout...
current state of the colab notebook:
---------------------------------
| ep_len_mean        | 323      |
| ep_reward_mean     | 5.94     |
| explained_variance | 0.828    |
| fps                | 421      |
| nupdates           | 32800    |
| policy_entropy     | 1.27     |
| total_timesteps    | 2656800  |
| value_loss         | 0.0304   |
---------------------------------

The ep_reward_mean will be around 50 after 5e6 timesteps, and above 200 after 1e7 steps.

Thanks again. Perhaps I'm really not training long enough then – is 1e6 not enough to get at least some results on Pong? Are there some reference values for minimum timesteps?

is 1e6 not enough to get at least some results on Pong?

Most of the time not.

Are there some reference values for minimum timesteps?

at least 3e6 timesteps I would say.

I see. Sorry to bother you then – thanks for this wonderful framework and for your quick responses!


Shadowing bug in inlining affecting foreach

Describe the bug
Inlining does not handle local variable shadowing properly when within foreach expressions.
To Reproduce
The following zip contains a simple test:
inlinetest.zip
Unzip the file and execute the contract with the following command:
ergorun.js execute model.cto logic.ergo --contract contract.json --request request.json

For the following expression in the test clause:
    return MyResponse{
			output1: let c = 2; c,
			output2: foreach c in [1,2,3] return c
		}

The result is:
{
    "$class": "org.accordproject.inline.MyResponse",
    "output1": 2,
    "output2": [1, 1, 1],
    "transactionId": "07c93b3c-2750-46aa-a8a7-488cf9ade69c",
    "timestamp": "2019-07-26T00:13:41.028Z"
  }

The local variable c shadows the global constant c properly for the let expression, but not for the foreach expression.
Expected behavior
The expected result should be:
{
    "$class": "org.accordproject.inline.MyResponse",
    "output1": 2,
    "output2": [1, 2, 3],
    "transactionId": "07c93b3c-2750-46aa-a8a7-488cf9ade69c",
    "timestamp": "2019-07-26T00:13:41.028Z"
  }

Desktop (please complete the following information):

OS: MacOS
Browser N/A
Version 0.9

The most likely reason for the bug is that the generic mapper for expressions used inside the inlining phase, does not record variables from the foreach expression properly in the context:
The corresponding code is at:
https://github.com/accordproject/ergo/blob/6e755cd9a246f179c056806a1f961534b0e24503/mechanization/Ergo/Lang/ErgoMap.v#L102
Which does not call the ctxt_new_variable_scope.
In contrast, here is the corresponding call for let:
https://github.com/accordproject/ergo/blob/6e755cd9a246f179c056806a1f961534b0e24503/mechanization/Ergo/Lang/ErgoMap.v#L73

Addressed in #640


Add clear_trailing slash on before request

Fixes #7

Code looks alright to me. Not QAed yet, I'll do that tomorrow if @jpmartinspt hasn't by then.


Display delegation info next to rewards

Is your feature request related to a problem? Please describe.
Users would like to see all relevant information in one place regarding rewards. Providing info about just rewards is not enough, it should be put in the context.
Describe the solution you'd like
We propose to add one more table below rewards table with the following information:

Delegation Details

Delegated to
0x12345678910121314

Delegator's Orbs Balance
1234

Voted in previous elections
Yes/No

Voted for next elections
Yes/No

This is an important feature!
I suggest the following format:
Delegation details
|
-- | --
Delegated to | 0x12345678910121314
Delegator's Orbs Balance | 1234
Voted in previous elections | Yes/No
Voted for next elections | Yes/No
Delegation block number | [Ethereum block number]
Delegation method | [Delegate / Transfer]
Delegation timestamp | [Time in human-readable format]

@andr444 , then it will make sense to display similar information in the delegation status popup under on the Guardians page?

Yes, makes sense

If delegation is performed thru Delegateactions => read delegate event from Ethereum and extract the timestamp from there.


Fix custom primary key in browse bread

It was impossible to edit or view a model if we were not using the id primary key for a model. This pull request should use the default primary key set by Laravel inside the Model class.
A model class with a custom primary key should look like:
class MyModel extends Model
{
  protected $primaryKey = 'myCustomPrimaryKey'; // otherwise simply set to id
}

Thank you for this.  I'm okay with it, but can you please verify that there aren't any custom views using this same pattern, and update them if there are?
Thanks!

@fletch3555 done!
What about code climate warnings about HTML lines that are way over 120 characters?

You don't have to worry about codeclimate.

@victorboissiere Awesome. Thanks, this looks really good. Merging it in now :)


[SPARK-50130][SQL][PYTHON] Add DataFrame APIs for scalar and exists subqueries

What changes were proposed in this pull request?
Adds the following DataFrame APIs for subqueries to Spark Classic.

scalar()
exists()

Also, add outer() to Column to specify outer references.
Examples:
For the following tables l and r:
>>> spark.table("l").printSchema()
root
 |-- a: long (nullable = true)
 |-- b: double (nullable = true)

>>> spark.table("r").printSchema()
root
 |-- c: long (nullable = true)
 |-- d: double (nullable = true)

from pyspark.sql import functions as sf

# select * from l where b < (select max(d) from r where a = c)
spark.table("l").where(
    sf.col("b")
    < (
        spark.table("r")
        .where(sf.col("a").outer() == sf.col("c"))
        .select(sf.max("d"))
        .scalar()
    )
)

# select a, (select sum(b) from l l2 where l2.a = l1.a) sum_b from l l1
spark.table("l").select(
    "a",
    (
        spark.table("l")
        .where(sf.col("a") == sf.col("a").outer())
        .select(sf.sum("b"))
        .scalar()
        .alias("sum_b")
    ),
)

# select * from l where exists (select * from r where l.a = r.c)
spark.table("l").where(
    spark.table("r").where(sf.col("a").outer() == sf.col("c")).exists()
)

Why are the changes needed?
Subquery APIs are missing in DataFrame API.
Does this PR introduce any user-facing change?
Yes, new DataFrame APIs for subqueries will be available.
How was this patch tested?
Added the related tests.
Was this patch authored or co-authored using generative AI tooling?
No.

cc @allisonwang-db @cloud-fan @dtenedor

I'll update documents here, and work on Spark Connect in a separate PR.

Run / Build modules: pyspark-mllib, pyspark-ml, pyspark-ml-connect seems to have been canceled for some reason. Rerun the jobs.

The failing tests are not related to this PR.

Merged to master.


jobsub_q/condor_q wrapper needs to be converted to python

Currently, jobsub_q is a shell script.  We should convert this to Python for better future maintainability.

Done in pull request #55.


GAP-2116|add github action stage to check migration script versions

Commit ef84446 shows the build failing if there's a conflict
Commit 9c440bf shows the build passing if there's a new migration script but no conflict
Commit e5e27c3 shows build passing if no migration script added


circleci s3 deployment

this fixes our s3 setup again - I already set the AWS credentials here so we should be ready to go!
My test worked.
PS: It doesn't add the index html for the documentation, do you want to add a index.html to our setup?

Thanks :)


Start karma with no autorun

Hi,
I will love it if karma won't run all the tests at start.

@balauru why?

You can put to karma.conf.js:
        frameworks: ['jasmine'],
        files: [
            '*.test.js'
        ],
        autoWatch: false,
        browsers: ['PhantomJS'],
        singleRun: false

and then manually run tests karma run --port=9876

@maksimr the current project has about 3k tests that take around 5 minutes to run, I don't want to run them on each start given that the CI is green
The answer I was looking for is to simply double the letter of the test ddescribe or iit and then when you call karma start it will only run that test.

@balauru great.
Be careful, since version of 0.3 karma-jasmine change ddescribe on fdescribe and iit on fit.


AttributeError: module 'os' has no attribute 'uname'

from tkinterweb import HtmlFrame #import the HTML browser
try:
  import tkinter as tk #python3
except ImportError:
  import Tkinter as tk #python2

root = tk.Tk() #create the tkinter window
frame = HtmlFrame(root) #create HTML browser

frame.load_website("http://tkhtml.tcl.tk/tkhtml.html") #load a website
frame.pack(fill="both", expand=True) #attach the HtmlFrame widget to the parent window
root.mainloop()

Traceback (most recent call last):
  File "...\web_view.py", line 8, in <module>
    frame = HtmlFrame(root) #create HTML browser
  File "C:\Users\Vicky\anaconda3\Lib\site-packages\tkinterweb\htmlwidgets.py", line 56, in __init__
    self.html = html = TkinterWeb(self, message_func, HtmlFrame)
  File "C:\Users\Vicky\anaconda3\Lib\site-packages\tkinterweb\bindings.py", line 85, in __init__
    folder = get_tkhtml_folder()
  File "C:\Users\Vicky\anaconda3\Lib\site-packages\tkinterweb\utilities.py", line 976, in get_tkhtml_folder
    if "arm" in os.uname()[-1]: # for Raspberry Pi (#24)
AttributeError: module 'os' has no attribute 'uname'

Hi! Thanks for letting me know about this. I just fixed the issue; let me know if it works now!

Hi! Thanks for letting me know about this. I just fixed the issue; let me know if it works now!

Great, it worked now.


Certain items wont get templated?

I am not sure but some of my items don't show up in the forum template when I try to update and then bump. For instance, my "Enlightened" divination card doesn't show up and a few other things even though I have a buyout listed for them. I have tried moving them around in my stash and other things but no fix so far.
Bumping is also an issue at times.I have the 1.9.8-rc1 version
DebugInfo.zip

Any suggestions? Help? Half of my items aren't getting formatted in the "Forum Export" section after I have updated my prices and even without prices they don't get templated.

Hi,
Divination cards not being generated is probably due to them being newer and missing from the data.xml file (https://github.com/Stickymaddness/Procurement/blob/master/POEApi.Model/Data.xml) if you open the file and go to the bottom you'll see a section for divination cards, add the missing cards there are restart Procurement, and the missing cards should now generate properly.

Procurement 1.9.9 has been released, which includes all the missing cards:
https://github.com/Stickymaddness/Procurement/releases/tag/1.9.9


Thorns III and Silk Touch Villager Trade

Is your feature request related to a problem?
These enchantments are rare in the enchanting table especially for Thorns III and there is a empty shop spot among the villagers enchantment shops.
Describe the solution you'd like.
Both Thorns III and Silk Touch to be added to Villager Trades in Orth. The prices for Silk Touch would be 12 Orth coins and Thorns III would be 14 Orth coins.
Describe alternatives you've considered.
By making them more common in the enchanting table list or create new type of enchantment table that does not give only three enchantments.
Agreements

[X] I have searched for and ensured there isn't already an open issue regarding this.
[X] I have ensured the feature I'm requesting isn't already in the latest supported Paper build.

Other
No response

Tweaking ETable is planned. If you want it as a villager, suggest a location, prices, villager name and all that iguess

Then the villager would be named Jag, location would be at 512,126,-172 at Orth. Prices for Thorns III would be 13 Orth coins and Silk Touch would be 12 Orth coins.

Added


Missing --creator-vote-counts when automatically including reviewers

When using the ´az repos policy required-reviewer´ CLI command, we cant set the ´--creator-vote-counts´ property to ´false´.
The default value is ´true´.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e67dccbb-b00c-b3e5-bf48-73d9ed2958f8
Version Independent ID: 7c09b598-7f2e-df53-b9a5-e29ffc4157a5
Content: az repos policy required-reviewer
Content Source: latest/docs-ref-autogen/ext/azure-devops/repos/policy/required-reviewer.yml
GitHub Login: @rloutlaw
Microsoft Alias: routlaw

devops

2 years and found this... I'm having this same issue, is there an update for this?


Dark Mode Contrast on Persona Labels

When viewing the article in dark mode, the labels on the personas are a relatively dark gray and the background is black, making it very difficult to read.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 33fdb2eb-41f6-3f06-fa12-43bab5485c5f
Version Independent ID: 58a1d34e-8abd-f841-9b9a-0651823eb690
Content: Understanding the current business process - Power Apps
Content Source: powerapps-docs/guidance/planning/understanding-current-business-process.md
Service: powerapps
GitHub Login: @TGrounds
Microsoft Alias: thground

Thanks James!  I just forwarded this to be corrected.
Tom.
Tom Grounds
Sr. Customer Success Manager | He/Him/Hishttps://www.mypronouns.org/what-and-why | Dallas
Office: +1<PHONE_NUMBER> | Mobile: +1<PHONE_NUMBER>
tom.grounds<EMAIL_ADDRESS>| LinkedInhttps://www.linkedin.com/in/tomgrounds/
Follow Us @MSFT_Businesshttps://twitter.com/MSFT_Business
[MSSurface_Logo_horizontal_C-Gray_RGB]
From: James Hammonds<EMAIL_ADDRESS>Sent: Tuesday, June 16, 2020 9:18 AM
To: MicrosoftDocs/powerapps-docs<EMAIL_ADDRESS>Cc: Tom Grounds<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: [MicrosoftDocs/powerapps-docs] Dark Mode Contrast on Persona Labels (#1512)
When viewing the article in dark mode, the labels on the personas are a relatively dark gray and the background is black, making it very difficult to read.
[image]https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fuser-images.githubusercontent.com%2F4581067%2F84784084-855fb100-afaf-11ea-80d6-b86dc352c011.png&data=02|01|Tom.Grounds%40microsoft.com|9070d614c2a44f9c76bb08d8120020cb|72f988bf86f141af91ab2d7cd011db47|1|0|637279139041871606&sdata=Qc0LkRYruAnzSwoSSWHMv8ghk0hTCMdx%2FcR6%2BuFxxgU%3D&reserved=0

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 33fdb2eb-41f6-3f06-fa12-43bab5485c5f
Version Independent ID: 58a1d34e-8abd-f841-9b9a-0651823eb690
Content: Understanding the current business process - Power Appshttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdocs.microsoft.com%2Fen-us%2Fpowerapps%2Fguidance%2Fplanning%2Funderstanding-current-business-process&data=02|01|Tom.Grounds%40microsoft.com|9070d614c2a44f9c76bb08d8120020cb|72f988bf86f141af91ab2d7cd011db47|1|0|637279139041871606&sdata=uQrMFjCg3rY9EnGTEW%2Fj4QLEm0HRDjEaKYYL3IufjM8%3D&reserved=0
Content Source: powerapps-docs/guidance/planning/understanding-current-business-process.mdhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fpowerapps-docs%2Fblob%2Flive%2Fpowerapps-docs%2Fguidance%2Fplanning%2Funderstanding-current-business-process.md&data=02|01|Tom.Grounds%40microsoft.com|9070d614c2a44f9c76bb08d8120020cb|72f988bf86f141af91ab2d7cd011db47|1|0|637279139041881572&sdata=9Wt1eR0LpPVH71WXquhnDeSC%2FRS%2B02d4gJPD%2F%2B5q%2Blw%3D&reserved=0
Service: powerapps
GitHub Login: @TGroundshttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FTGrounds&data=02|01|Tom.Grounds%40microsoft.com|9070d614c2a44f9c76bb08d8120020cb|72f988bf86f141af91ab2d7cd011db47|1|0|637279139041881572&sdata=OXShAJAzv53OqrRpMTG6RoeGM1qGokg8%2FA9CPUAeEXg%3D&reserved=0
Microsoft Alias: thground

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fpowerapps-docs%2Fissues%2F1512&data=02|01|Tom.Grounds%40microsoft.com|9070d614c2a44f9c76bb08d8120020cb|72f988bf86f141af91ab2d7cd011db47|1|0|637279139041891518&sdata=0TU7YnA9DaBHXlx%2BF%2Fe%2FJYLYTFk4qmPzDYif1CPhTho%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAJFO5NFIM3LQ5BR2VWNMOADRW55K5ANCNFSM4N7VHVEQ&data=02|01|Tom.Grounds%40microsoft.com|9070d614c2a44f9c76bb08d8120020cb|72f988bf86f141af91ab2d7cd011db47|1|0|637279139041891518&sdata=NASKKZzolwSRnXEWLN0lphviqPJLQONhstitu0TrJY4%3D&reserved=0.

Verified this has been addressed via dark mode on my own computer. If you're still experiencing the issue described here, please reopen or create a new issue.