[CLI]: Can't log from multiple threads

Describe the bug
My code runs on 2 threads, one for training and one for testing. I need to log training and testing stats at the same time, and I try to do that by calling wandb.log() in the training and testing function. However, only the thread that calls first wandb.log() will successfully log stats. The other thread log will be ignored.
If you submit first the training function, you will have always have training stats.
Here is a MWE. If you try it will always log testing stats, because they are started first. Sometimes (out of luck?) it also logs main stats. Sometimes (veeeery rarely) I get all 3 logs, but incomplete.
I have read somewhere that WandB is not thread safe, but in this case it is not even logging anything and it's behavior is completely non-deterministic.
import torch
from concurrent.futures import ThreadPoolExecutor
import wandb
import time

def run():
    wandb.init(
        entity='sparisi',
        project='abcd',
        mode='online',
    )

    done_train = False
    done_test = False

    def test():
        nonlocal done_test
        for i in range(100):
            wandb.log({'test': torch.rand(1).item()}, step=i, commit=True)
        done_test = True

    def train():
        nonlocal done_train
        for i in range(100):
            wandb.log({'train': torch.rand(1).item()}, step=i, commit=True)
        done_train = True

    thread_test = ThreadPoolExecutor(1)
    thread_train = ThreadPoolExecutor(1)
    thread_test.submit(test)
    thread_train.submit(train)

    for i in range(100):
        wandb.log({'main': torch.rand(1).item()}, step=i, commit=True)

    while not done_test and not done_train:
        time.sleep(0.1)

    wandb.finish()

if __name__ == '__main__':
    run()

Additional Files
No response
Environment
WandB version: 0.15.2
OS: Windows
Python version: 3.10
Additional Context
No response

Hi @sparisi, are you looking for each of the threads to log to the same run or would you want each thread to spawn its own run?

Hi @sparisi, are you looking for each of the threads to log to the same run or would you want each thread to spawn its own run?

Same run. I think the problem is that the step argument is not monotonically increasing.

@sparisi I see, yes any log calls made to a step < the current step would not get ingested by the server which would explain the somewhat non-deterministic nature of what you are seeing.
I think for your use case though, it would make sense to use two different wandb.run's and give them a group so they are associated with each other in the UI.

@nate-wandb The problem is that I need to use the same ID because I may need to resume my run later. And I cannot use two wandb.run with the same id, right? I tried and I get the error
FileExistsError: [Errno 17] File exists: '<path>\\wandb\\run-20230519_105638-EnvX-20230519-105631\\run-EnvX-20230519-105631.wandb'

The is here EnvX-<timestamp> but for sweeps it depends on hyperparameters.

@sparisi I see. One workaround could be to use the define metric workflow here and then don't add the step argument to wandb.log but rather track the step as another metric yourself. The UI will plot the actual metric against your custom step metric if you do this.
Do you think this could be a possible solution?

@nate-wandb Yes this works, thanks! It makes a plot for my additional metric ("Steps") which I have to hide every time, though, and sometimes it doesn't set "Steps" as default metric, but it's not a big deal.

Great! We have a feature request currently pending to be able to hide the defined metrics from wandb which should help.
Is it non-deterministic when "Steps" will not be set as the x-axis? Do you have a minimal repro I could test with?

@nate-wandb Do you mean a minimal example with two different time steps?
This is my original example with some time.sleep to make it kinda deterministic. The train thread will log before the test and on the server only train = i ** 2 will be logged. The test plot will be empty.
from concurrent.futures import ThreadPoolExecutor
import wandb
import time

def run():
    wandb.init(
        project='abcd',
        mode='online',
    )

    done_train = False
    done_test = False

    def test():
        nonlocal done_test
        for i in range(100):
            time.sleep(0.2)
            wandb.log({'test': i}, step=i)
        done_test = True

    def train():
        nonlocal done_train
        for i in range(100):
            wandb.log({'train': i ** 2}, step=i)
        done_train = True

    thread_test = ThreadPoolExecutor(1)
    thread_train = ThreadPoolExecutor(1)
    thread_test.submit(test)
    thread_train.submit(train)

    while not done_test and not done_train:
        time.sleep(0.1)

    wandb.finish()

if __name__ == '__main__':
    run()

Hi @sparisi, sorry I was referring to this:

sometimes it doesn't set "Steps" as default metric

Is this something that is happening consistently or does this seem to non-deterministically happen?

HI @sparisi, I just wanted to follow up and see if you think the define metric workflow is an acceptable workaround or if there was anything else I can help with around this?

Hi @nate-wandb, unfortunatley I cannot reproduce it with some code. If I run something locally everything works fine, but all runs submitted as slurm jobs don't show my custom metric "steps" as default x-axis, and I need to manually set it everytime in the plots.

@sparisi Are the slurm jobs using the same version of W&B as when you test locally?

@nate-wandb yes, the latest.

@sparisi, interesting. If this is a blocker, could you possibly create a minimal reproduction of the issue that uses SLURM so that we can try to get a fix on this?

Hi @sparisi, I'll close this for now since the define metric flow solves the original issue but feel free to open another issue if you want us to investigate the default x-axis issue with Slurm. Thank you!


Produce coverage for source files

Codecov Report

Merging #20 into master will decrease coverage by 27.52%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master      #20       +/-   ##
===========================================
- Coverage     100%   72.47%   -27.53%
===========================================
  Files           3        8        +5
  Lines          90      356      +266
===========================================
+ Hits           90      258      +168
- Misses          0       98       +98

Impacted Files
Coverage Δ

include/inotify/FileSystemEvent.h
100% <0%> (ø)

source/FileSystemEvent.cpp
6.81% <0%> (ø)

source/NotifierBuilder.cpp
100% <0%> (ø)

source/Event.cpp
60.41% <0%> (ø)

source/Inotify.cpp
69.59% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db298ad...d09c63c. Read the comment docs.


Fixed column order in query output

The order of column in output was reversed. The order is fixed now.

@microsoft-github-policy-service agree company="Microsoft"

#sign-off

This PR is covered in #1747, so closing this PR so as not to give merge conflicts. Will merge in other PR.
#please-close


FEATURE REQUEST: contour lines

Hello, After spending some time on docs and examples as well as some google searches I could not find what I'm looking for. But I could be wrong.
The feature:
I want to be able to draw contour lines on the globe, starting flat on the surface, and rising up as the lines get closer together creating a contour topo map with elevation above the globe. More specifically, on I can use for a signal data set. For example, if there is a signal with it's strongest point at coordinates (a,b) with the signal weakening around it, the shape would be like a mountain with contour lines, the highest point at coordinates (a,b) with multiple tiers going down the mountain, creating a 3E 'hot spot' effect (but not like the hot spot example in the docs)
If this is already a feature, Awesome! I'd love to know what  i'm missing.
if this has a 3rd party API, great! just point me in the right direction
else: is anyone else interested in something like this?

Good timing, @CHBaker!  We were just talking to @jasonbeverage who has been cooking this up.
@jasonbeverage do you have a screenshot and branch you can share in the meantime before the pull request is open?

Perfect timing :)
I'm working on the ability to modify the shaders of the globe at runtime and one of the examples I'm working on is drawing contour lines based on the elevation.

This screen shot shows two additional shaders ran after the stock globe fragment shader.  One is an elevation contour shader (the red lines) and the other is a color ramp based on the slope of the terrain.
You can play with the demo live here:  https://cesiumglobematerial.netlify.com/apps/sandcastle/?src=Shader Composition.html&label=Showcases
The branch I'm currently working on is here:  https://github.com/jasonbeverage/cesium/tree/globematerial
Don't put too much stock into it yet, I'm just hacking until I get things flushed out and then I will probably start with a clean branch ;)
I'm hoping to put together a PR for this in the next couple of weeks, so any ideas or feedback is appreciated.
Your particular use case is interesting b/c it sounds like you don't really want contours based on elevation, you want contours based on some computed signal strength.  What format is your signal strength data in?  Do you have a tiled raster dataset for the signals?  If so I could picture adding custom shaders to an ImageryLayer to modify how they are rendered in addition to my current post processing mechanism.

@jasonbeverage hey thanks for the detailed response!  That's awesome, and pretty close, and that is correct, I don't want to use terrain, I essentially want to use 'fabricated terrain' if you will, to represent data hot spots.
Right now I'm waiting on a refactored data structure from another company, so I don't know the data structure yet. But if a tiled raster data set is gonna be the best way to go that is good to know. But I'll let you know when I do.

I have a PR open for applying a LUT to a tiled ImageryLayer. There hasn't been much progress on it, but essentially we use the Red band of a PNG to "bake in" the raw data values (with a known minimum & maximum, you can normalize). This then allows us to apply a LUT to meteorological datasets (satellite, radar and numerical models).
See here: https://github.com/AnalyticalGraphicsInc/cesium/pull/4953
I would love input that might move this PR forward, as it's been a high priority since early this year.

Here is a shot of an elevation color ramp generated with this.
I'm hoping to have at least a preliminary PR for this by the end of the week, but we'll see ;)

So right now I'm not focusing on "fabricated" elevation, only on the actual elevation data that is passed through.  The gist of what I am doing is adding Material support to the Globe, so you can basically write your own fragment shaders that control the final coloring of the globe.
I think what you are probably after (and also what @NaderCHASER is after) is more along the lines of having a Material per ImageryLayer that can control how the RGB values are interpreted on a per layer basis.  We have something similar in osgEarth called a ColorFilter, but for now that is outside of the scope of the work I'm currently doing.
If I can get this initial PR included then perhaps I can try to add Material support to the Image Layers after that.

Added in #5919


Rename liboeposix to liboesyscall.

This PR is a follow-up to review comments on the POSIX work. By popular demand, I am renaming the POSIX feature to the SYSCALL feature. Several reviewers (Anand, Akash, Dave) noted that this work contains non-POSIX features and that a more comprehensive name would be better (Dave suggested the SYSCALL name for extensions but I think it's a good overall name). For the public API, this merely changes the name of the liboeposix library to liboesyscall. For the internal API, this PR renames 'posix' to 'syscall' in many places. Additionally, Anand suggested separating the new corelibc headers  into a different directory. The PR does that too, restoring corelibc to its original self.
To summarize: this PR changes two kinds of things:
(1) 'posix' becomes 'syscall' in many places (file names, directory names, function names).
(2) syscall-related headers are moved from the corelibc directory to internal/syscall.
Note that the only consumer of liboesyscall is MUSL (liboelibc).
The changes were mechanical naming changes and there were no functional changes whatsoever. Unfortunately, Github does not always correctly detect that headers have been renamed. Instead it shows them as deleted in one directory and added to another. So I apologize that this inflates the size of the PR.

// Copyright (c) Microsoft Corporation. All rights reserved.

It looks like sys/signal.h was only included as a build shim before, but if the intent is that only liboelibc links against liboesyscall, then can this (and the references from host/linux/posix.c & syscall.c) be removed entirely?

Refers to: include/openenclave/internal/syscall/sys/signal.h:1 in 433c94f. [](commit_id = 433c94fd78b54deb47add1757be0b8109558d635, deletion_comment = False)

add_subdirectory(cpio)

Consider sorting alphabetically for readability.

Refers to: tests/syscall/CMakeLists.txt:5 in 433c94f. [](commit_id = 433c94fd78b54deb47add1757be0b8109558d635, deletion_comment = False)

// Copyright (c) Microsoft Corporation. All rights reserved.
It looks like sys/signal.h was only included as a build shim before, but if the intent is that only liboelibc links against liboesyscall, then can this (and the references from host/linux/posix.c & syscall.c) be removed entirely?
Refers to: include/openenclave/internal/syscall/sys/signal.h:1 in 433c94f. [](commit_id = 433c94f, deletion_comment = False)

I removed all vestiges of signal (as well as epoll).

add_subdirectory(cpio)
Consider sorting alphabetically for readability.
Refers to: tests/syscall/CMakeLists.txt:5 in 433c94f. [](commit_id = 433c94f, deletion_comment = False)

Yeah, fixed (and I added a comment that cpio must come first).

Thank you Simon for your review. I addressed all comments as requested. In addition to removing signal, I removed all epoll references as well.

@mikbras FYI regarding:

Yeah, fixed (and I added a comment that cpio must come first).

Akash had a similar thing about this in a different PR a while back and it turns out that the ordering in the CMakeLists.txt should not matter since the cmake graph will order it correctly. (see the changes to build enclave/core under the enclave/CMakeLists.txt again)

Did you mean load_file_without_crlf? CRLs are often interpreted as certificate revocation lists in this context. (Also, it's stripping CR but not FS here, so load_file_without_cr?)

I checked this fix into the wrong branch. Backed out.

FYI, the "b" doesn't appear to be propagated (see comment in tests/crypto/enclave/host/host.c) in the syscall hook mechanism.

Backed out this fix to crypto.

bors r+

bors r-

bors r+


Support complete endpoint for Stripe notification

The current implementation does not handle the case of a complete stripe endpoint (as provided by Stripe) in its configuration. I could not find anything in the documentation of how the original endpoint needs to be split for the config to work. Also, it stands to reason that a user would assume that the URL provided by Stripe (they even copy it to clipboard!) would work as-is.
The implementation is such that partial endpoints will continue to work.

@squgeim Thanks. I think you supposed to mean slack not stripe :smile:. I got confused, since there's no stripe integration here.
And, could you do  this PR on the master branch, so that this patch could be released shortly. The dev is ahead of master with way too many commits.
Also, would it be possible to add a test for this newly added function? Thanks.


record_transformer - unknown placeholder

I use in_kmsg on fluentbit, forward to fluentd and then I want to replace "mgs" key in record to "message".

fluentd or td-agent version.
gem, 1.0.0 (but even the older 0.14.x)

Environment information, e.g. OS.
ubuntu

Your configuration

      <label @MAINSTREAM >

          ## FIXME: For debuging purposes

          <filter system.log.kernel >

             @type stdout

          </filter>

          <filter system.log.kernel >

              @type record_transformer

              renew_record false

              <record>

                  message ${record['msg']}

                  # message ${msg}    ## same issues

              </record>

          </filter>

          <filter system.log.kernel >

              @type record_transformer

              renew_record false

              remove_keys [ "msg" ]

          </filter>

Problem - unknown placeholder ${record['msg']} found`
The same with ${msg}

2017-12-07 14:54:14.000964150 +0000 system.log.kernel: {"priority":4,"sequence":5761471,"sec":12874928,"usec":964150,"msg":"NFS: state manager: check lease failed on NFSv4 server <IP_ADDRESS> with error 93","hostname":"control-node2.lab.zzz.xxx.ttt"}
2017-12-07 14:54:19.000967199 +0000 system.log.kernel: {"priority":4,"sequence":5761472,"sec":12874933,"usec":967199,"msg":"NFS: state manager: check lease failed on NFSv4 server <IP_ADDRESS> with error 93","hostname":"control-node2.lab.zzz.xxx.ttt"}
2017-12-07 15:39:52 +0000 [warn]: #0 unknown placeholder `${record['msg']}` found
2017-12-07 15:39:52 +0000 [warn]: #0 unknown placeholder `${record['msg']}` found

Corresponding source:
https://github.com/fluent/fluentd/blob/master/lib/fluent/plugin/filter_record_transformer.rb#L235
Am I missing something?

Because you use record['msg'], not record["msg"].
Without enable_ruby, ${} placeholder is not ruby syntax, so record['key'] is not supported for now.
We can support it but it decreases the record_transformer performance.

OK, thanks, please mind the doc, it's missing mention about single apostrophes and the example miss the enable_ruby as well.
<filter foo.bar>
  @type record_transformer
  <record>
    hostname "#{Socket.gethostname}"
    tag ${tag}
  </record>
</filter>

Above example, enable_ruby is not needed because you don't use ruby script inside ${}.

Undrstand, but I got the same issue with:
 <filter system.log.kernel >

              @type record_transformer

              renew_record false

              <record>

                  message ${msg}

              </record>

          </filter>

See FAQ's first: https://docs.fluentd.org/v1.0/articles/filter_record_transformer#faq

And just added second for record['key'].

${tag} and ${msg} are different. See <record> directive document: https://docs.fluentd.org/v1.0/articles/filter_record_transformer#-directive

Finally got the point. Thanks!


quickstart-listing-files (syntax typo fixed)

I noticed some consistent syntax typos wherever a collection of files or folders were being initialized, it was a minor fix,but it certainly will help those developers who want to copy and paste code code straight into the code and it will also avoid some confusion regarding the variable names.

@laurenhughes : PR passed acceptance checklist. Please evaluate further and approve/merge if appropriate. Thanks!


Gulp-sass crashes with invalid color values

For example when I mistyped the color:
a{
    color: $bc-sec;
}

I get the following error on the console:
error.message = gutil.colors.stripColor(message);

Found the problem. Seems like it was a bug in gulp-inject not gulp-sass.


Refactor select all/none js functionality & remove jQuery

Context
Changes proposed in this pull request
This was in desperate need of being a refactor for the following reasons:

jQuery: This relied on jQuery and seemed a bit of overkill to import and include it on every page. It also seemed to be included twice.
jQuery is no longer a dependency for this code to work.

would only work for a single instance of this component. It now supports
multiple components

The js was not scoped to just the component in question. For example,
when the page has loaded, any element that had a class of js-only or non-js-only would be
hidden/shown regardless of what our intentions were for those elements
when the page loaded.

There was a lot of additional markup added just to add the feature.
The markup has now been cleaned up.

No unit tests

Guidance to review
I analyzed the bundles locally before & after the changes:

Before
    After
    % Reduction

gzipped
	130KB
	35KB
	73%

parsed
	408KB
	117KB
	71%

Before:

After:

There will be a follow-up PR, which will include some tidy ups on how webpack is generating our assets.

e0b4af8 (#1012) renames extra-mobile-data-requests.js

:shipit:


Correct Broken Names

Correct names that appear to reference incorrect or missing lang entries.
Also correct names to match pack vision and character.

[x] Embers pump pipe
[x] Bauxite ore to Aluminum ore?
[x] Aluminium products to "Aluminum" (US Localization)
[x] Radiant Crystals (there are two of them, rename one for clarity)

first 2 were done in other releases, localization is already done in oredict (which is nice) but there are 63 items and im not sure that can be done completely, the fluids and materials will stick around in JEI, as we can only rename the finished products themselves, not the fluid names... so the juice may not be worth the squeeze here.
renamed radiant crystals and other related blocks from EB to "dazzling"


Keras saved mode is not .h5 file

Hi I am planning embedding an ML model trained by keras into a climate model which is written by fortran 90. I checked your package and found that it claimed that it is able to translate saved model to fortran script. But I found that my model is not saved by .h5 format, but a folder. I used
def get_model():
    # Create a simple model.
    inputs = keras.Input(shape=(32,))
    outputs = keras.layers.Dense(1)(inputs)
    model = keras.Model(inputs, outputs)
    model.compile(optimizer="adam", loss="mean_squared_error")
    return model

model = get_model()

# Train the model.
test_input = np.random.random((128, 32))
test_target = np.random.random((128, 1))
model.fit(test_input, test_target)

# Calling `save('my_model')` creates a SavedModel folder `my_model`.
model.save("my_model")

# It can be used to reconstruct the model identically.
reconstructed_model = keras.models.load_model("my_model")

so there is a folder named "my_model", and inside there are assets  saved_model.pb  variables. So can I still use your package? thanks!

The saved_model.pb refers to the protocol buffer file which contains the graph definition as well as the weights of the model which you can load with something fancy like tf.io.gfile.GFile('saved_model.pb' , 'rb') and tf.Graph() . Better would be to simply save your model in .h5 with model.save("my_model.h5")  . Then you can use python convert_weights.py --weights_file path/to/my_model.h5 --output_file path/to/model_config.txt, and follow the rest of instructions.

Thanks for your reply! @aakash30jan! And one thing is that, could you please generate small examples for how to propagating the loaded ml model in Fortran? for example, if I have load the my_model.txt in the fortran script by call net % load('model_config.txt'), how can I calculate the forward output using some arbitrary inputs? thanks!


Plugin showing "No supported modules were found. Try refreshing external projects" error

I am using IntelliJ IDEA 2023.3.4 (Ultimate Edition) Build #IU-233.14475.28.
I have installed the latest Package Search plugin (233.11800.6) and opened a multi-module maven project.
When I open Package Search Tool window, it shows "No supported modules were found. Try refreshing external projects" error. Nothing happens even after clicking Refresh.

Hi thank you for the report! Do you have a test project on which we can test on?

This problem is very easy to reproduce on maven package manager，many official source libraries are not working
For example. https://github.com/netty/netty.git or https://github.com/alibaba/canal.git


STORM-704 Apply Travis CI to Apache Storm Project

support build matrix (openjdk6, openjdk7, oraclejdk7, oraclejdk8)
change log level to WARN while running unit tests
print out clojure test reports (only errors)

Sure we should ask Apache Infra to set up Travis CI (with asfgit account), which is not an issue cause many projects on Apache already uses Travis CI.
ex. https://issues.apache.org/jira/browse/INFRA-6161

Applied first on my forked repo: https://travis-ci.org/HeartSaVioR/storm/jobs/56021892
Could any committers help requesting set up Travis CI to Apache Infra?

Failing build (from storm-core) output for example : https://s3.amazonaws.com/archive.travis-ci.org/jobs/56016756/log.txt

@revans2
Could you take a look?
We were talking about adopting Travis CI and I feel you would like this, and there're no hurdle left (except Apache Infra)

@HeartSaVioR Sorry it has taken me so long to take a look.  It appears that for https://travis-ci.org/HeartSaVioR/storm/jobs/56016756 you are missing one of the shell bolt/spout dependencies.  We currently need ruby, python, and nodejs installed.  The errors about
java.lang.RuntimeException: backtype.storm.multilang.NoOutputException: Pipe to subprocess seems to be broken! No output read.```

indicate that one of these is not installed/on the path.

I cloned your changes and have been playing around with them.  For me the test all fail before reaching the clojure test.
https://travis-ci.org/revans2/incubator-storm/jobs/59781670
I think @kishorvpatil is looking into the test failures.  I don't see them on my box, so I think it has something to do with how fast the box is.

@revans2
About multilang, I missed due to not failing tests. We may like to make multilang tests more reliable.
I'll find a reason about what dependencies are missing, and find a way to install such things.
About test failures, we can control STORM_TEST_TIMEOUT_MS to respect slow box, but maybe some tests are still needs fast (maybe not very slow) machine.

Mailed to Travis CI support to how can I get python, ruby, nodejs installed.
If we really need to install these manually, I'll lend a debug VM from Travis CI.

Last build is successful except multilang tests.
https://travis-ci.org/HeartSaVioR/storm/builds/59788403

Yes, so the issue that we have run into before, and may be the same now, is that ruby does not come with JSON support by default on ubuntu.  But that was a much older version or ruby and ubuntu.  So who knows.

https://travis-ci.org/HeartSaVioR/storm/builds/59794019 succeed and https://travis-ci.org/HeartSaVioR/storm/builds/59795636 failed, which means failed tests could be a kind of random failures or relied on machine power.
First one is DisruptorQueueTest, as you already know.
Failed tests:   testMessageDisorder(backtype.storm.utils.DisruptorQueueTest): We expect to receive first published message first, but received null expected:<1> but was:
Second one is Kafka Tests, which I met intermittently from my dev. machine.
testKeyValue(storm.kafka.TridentKafkaTest): Could not send message with key = key-123 to topic = test
generateTuplesWithKeyAndKeyValueScheme(storm.kafka.KafkaUtilsTest): Error fetching data from [Partition{host=localhost:52047, partition=0}] for topic [testTopic]: [OFFSET_OUT_OF_RANGE]

Infra setup seems to be completed. I can see current PR's build status.

@HeartSaVioR great to hear that the setup is complete.  I'm not sure if we want to merge this in as is, knowing that the majority of test cases will fail, or if we want to wait for the tests to pass more regularly.

@revans2
I'm trying to resolve multilang tests, so I'll let you know.
Regarding random failure, IMO we already addressed these to JIRA issue, and it's better to expose instead of hiding so we all know tests issue and will try to resolve.

Can we try and do something like
mvn test -fae
BUILD_RET_VAL=$?

or even better not fail ever, but check the output files for failures. I tend to use the following but you could update your script to do something similar.
mvn test -Pnative -fn
echo "Errors or Failures:"
egrep -il '<fail|<error' ../*/target/test-reports/*.xml | xargs -I '{}' bash -c "echo -n '{}':' '; egrep -ic '<fail|<error' '{}'"
egrep -iq '<fail|<error' ../*/target/test-reports/*.xml
BUILD_RET_VAL=$?

It doesn't print out the full error stack traces, but it does capture any failures

@revans2
Thanks! I'll try it.

mvn with -fae makes sense since retrying tests may require at least collaborator to github repository so even committers are not authorized to retry tests.

Seems like multilang tests cannot verify it runs properly after initialized.
NoOutputException has raised at Travis tests all the time but test-reports doesn't have fail or error.
https://travis-ci.org/HeartSaVioR/storm/jobs/59953593

If we have file "a" containing "abc"...

egrep -il 'abc' a | xargs -I '{}' bash -c "echo -n '{}':' '; egrep -ic 'abc' '{}'"
a: 1
echo $?
0
egrep -il 'fg' a | xargs -I '{}' bash -c "echo -n '{}':' '; egrep -ic 'fg' '{}'"
echo $?
0

It could capture count of string matching patterns in files, but it shouldn't be used to retval.
Note: I've tested it with OSX, with zsh.

Btw, I modified .travis.yml to install recent version of ruby and node, and still have no luck with multilang tests. It doesn't print out any helpful outputs, but I'll keep giving a try.

I'm about to be sure that we're better to introduce Travis CI now though some digging points still exist.
Cause it just catches storm-eventhubs build issue (https://issues.apache.org/jira/browse/STORM-800) automatically.
https://travis-ci.org/apache/storm/builds/59957899

Please note that mvn with -fae still ban external modules to test when storm-core failed.

OK I am +1 for merging this in.  We can adjust things as with error reporting and logging as time goes on.
But I would like others opinions on this too.  @d2r @knusbaum @ptgoetz or any others do you have an opinion on merging this in?

I'm +1 for merging. I'd rather have it in so it can yell at us about fixing the broken tests.


[Refactoring] Implement the main macros in terms of Input::methods on tuples

This PR implements the macros run!, run_output! and run_result! in terms of the methods on Input and in turn implements the methods on Input in terms of the functionality from child_output. And moves some code around to hopefully make more sense. This also means that some internal functions don't have to be public anymore, because they won't show up in code generated by the macros. Therefore, this is technically a breaking change. All the items that were changed to non-public now were #[doc(hidden)] before.

Sweet, looks good to me. I tried improving the tuple_up macro by adding a base case:
macro_rules! tuple_up {
    () => {()};
    …
}

But that didn't work.


Added SPARKLYR_CONFIG_FILE_PATH environment variable as an option to reading sparklyr config

Fix for issue #2152

Notice that there is also R_CONFIG_FILE which is defined in the config package and should have a similar behavior: https://github.com/rstudio/config/blob/master/R/get.R#L27
But it also makes sense to have an environment variable for sparklyr, would suggest we name this SPARKLYR_CONFIG_FILE.

Notice that there is also R_CONFIG_FILE which is defined in the config package and should have a similar behavior: https://github.com/rstudio/config/blob/master/R/get.R#L27
But it also makes sense to have an environment variable for sparklyr, would suggest we name this SPARKLYR_CONFIG_FILE.

Thank you, @AgrawalAmey!


Navbar toggle gets in the way of some elements

When the window width of the browser is small enough the main navigation bar disappears and a navbar toggle appears. This seems to obstruct some headers, such as here, and just feels out of place in other places like here. Should be fixed by adding padding to the right of the navbar toggle button.
Definitely not a major issue, especially since Wagtail is generally used in a full-screen window -- just something I noticed.

Fixed in #3703


Change perf name to something better

change perf name to something more suitable according its funtion.
besides that, set measures relating system calls (waiting time) etc .. (useful when measuring IO)

check dtrace in MAC OS
map results to new perf function


Datasource selection priority

In reviewing korfuri/django-prometheus#318 I noticed a couple of things.

The panel-datasource-rule is very specific about the panel types it checks (graph, singlestat, and table) and therefore excluded timeseries. I've created #13 for this.
The django dashboard actually sets the datasource on each target for the panel, rather than once on the panel itself. Both are "technically" valid. Should the panel-datasource rule accommodate this case, or should we be opinionated that different datasources on targets for the same panel is an anti-pattern? I believe that we should consider it an anti-pattern, and that there should be a target specific rule to check for it.

Thoughts @tomwilkie ?

The panel-datasource-rule is very specific about the panel types it checks (graph, singlestat, and table) and therefore excluded timeseries. I've created Add timeseries to list of panel types when checking datasource #13 for this.

Yeah this is a weakness, do you think we can remove this?

The django dashboard actually sets the datasource on each target for the panel, rather than once on the panel itself. Both are "technically" valid. Should the panel-datasource rule accommodate this case, or should we be opinionated that different datasources on targets for the same panel is an anti-pattern? I believe that we should consider it an anti-pattern, and that there should be a target specific rule to check for it.

Is it still set to a variable?  Yeah I think that should be valid.  But yeah, they should all be the same datasource IMO.

The panel-datasource-rule is very specific about the panel types it checks (graph, singlestat, and table) and therefore excluded timeseries. I've created Add timeseries to list of panel types when checking datasource #13 for this.

Yeah this is a weakness, do you think we can remove this?

Yep, will do. I don't see any reason to filter this based on panel type.

The django dashboard actually sets the datasource on each target for the panel, rather than once on the panel itself. Both are "technically" valid. Should the panel-datasource rule accommodate this case, or should we be opinionated that different datasources on targets for the same panel is an anti-pattern? I believe that we should consider it an anti-pattern, and that there should be a target specific rule to check for it.

Is it still set to a variable? Yeah I think that should be valid. But yeah, they should all be the same datasource IMO.

In this particular case, the datasource was hardcoded to one used by the author, accidentally. But yes, the targets defining their own datasource can (and should) use the variable.
Will create a rule to enforce all datasources to be the same for a panel, if defined on targets. I'll also create another warning/guidance rule that the datasource should preferably be set only on the panel, and not on individual targets.

Yep, will do. I don't see any reason to filter this based on panel type.

I don't recall why I put that in there TBH, but I think there was a reason.  Worth experimenting with removing it and seeing what breaks for sure.

Will create a rule to enforce all datasources to be the same for a panel, if defined on targets. I'll also create another warning/guidance rule that the datasource should preferably be set only on the panel, and not on individual targets.

I think this might be a recent change in Grafana behaviour TBH - it used to be you picked the datasource at the panel level, now it seems to be at the individual "target" (expression).
I think one "principle" for the linter it you should be able to construct a dashboard that passes the linter cleanly using the Grafana UI.  WDYT?
These two things combined means yes, we have to support per-target datasources.  I think we should still be super opinionated and not allow mixing of different datasources - this linter is about consistency and opinionation.  Perhaps we go further and say only one datasource per dashboard?  And that it must be a variable?   I know there as valid use cases for multiple datasources but this linter is optional and people can opt out of individual rules.

Yep, will do. I don't see any reason to filter this based on panel type.

I don't recall why I put that in there TBH, but I think there was a reason. Worth experimenting with removing it and seeing what breaks for sure.

In thinking about this, it is almost certainly the "row" panel, which wouldn't have any target/query/datasource values, by design. I'll experiment with a few existing dashboards. Will probably make this opt out for the "weird" panels which are okay not to have a DS.

Will create a rule to enforce all datasources to be the same for a panel, if defined on targets. I'll also create another warning/guidance rule that the datasource should preferably be set only on the panel, and not on individual targets.

I think this might be a recent change in Grafana behaviour TBH - it used to be you picked the datasource at the panel level, now it seems to be at the individual "target" (expression).
I think one "principle" for the linter it you should be able to construct a dashboard that passes the linter cleanly using the Grafana UI. WDYT?
These two things combined means yes, we have to support per-target datasources. I think we should still be super opinionated and not allow mixing of different datasources - this linter is about consistency and opinionation. Perhaps we go further and say only one datasource per dashboard? And that it must be a variable? I know there as valid use cases for multiple datasources but this linter is optional and people can opt out of individual rules.

Totally agree that the linter should pass on dashboards exported directly from Grafana. This does pose some challenges for backward compatibility, and we may have to start inspecting the schema version 🤔
I do not think we should be opinionated that there should be only one datasource. Perhaps one datasource-per-type. We are starting to build dashboards which have a configurable prometheus and loki datasource to show metrics and logs.
I have time set aside to work on this, so I should be able to make some considerable improvements.

Yep, will do. I don't see any reason to filter this based on panel type.

I don't recall why I put that in there TBH, but I think there was a reason. Worth experimenting with removing it and seeing what breaks for sure.

I think I figured it out, after actually giving it some thought. Some panel types will be ones without a query/target, such as row, or text.
I believe this can safely be tweaked to only check that a panel has a datasource (and that the datasource is correct) when the panel has one or more targets.


Refactor governance

Continuing code refactoring to (hopefully) improve readability and add some logical constraints (consts ;) ). Should not change the actual behaviour.
EDIT: rebased to trigger Travis

Rebased to fix merge conflicts
02f0ec0 -> 2b13f38
<<<<<<< refactorgov
    voteInstanceRef = vote_instance_t(vote.GetOutcome(), nVoteTimeUpdate, vote.GetTimestamp());
    if(!fileVotes.HasVote(vote.GetHash())) {
        fileVotes.AddVote(vote);
    }
=======
    voteInstance = vote_instance_t(vote.GetOutcome(), nVoteTimeUpdate, vote.GetTimestamp());
    fileVotes.AddVote(vote);
>>>>>>> develop

and
80e70ad -> 94d1f9c
<<<<<<< refactorgov
    /*
        TODO

        - There might be an issue with multisig in the coinbase on mainnet, we will add support for it in a future release.
        - Post 12.2+ (test multisig coinbase transaction)
    */

    // 12.1 - todo - compile error
    // if(address.IsPayToScriptHash()) {
    //     strError = "Governance system - multisig is not currently supported";
    //     return false;
    // }
=======
    return true;
>>>>>>> develop

No other changes.


All types is optional

Running the default template like this generates all interfaces as optional which is kind of weird.
npx swagger-typescript-api -p https://blablaurl -o ./models/ -n index.ts --no-client --extract-request-params --extract-request-body

Schema from swagger json file to the response of a normal json endpoint:

Generated model file:
export interface BasketHeader {
  nameId?: string | null;
  basketName?: string;

  /** @format int32 */
  linesCount?: number;
  basketPosInfo?: string | null;
  lines?: FavoriteProduct[];
}

Is it me or is this a bug?

Hello @TommySorensen !
You need to add required property
https://swagger.io/docs/specification/data-models/data-types/
"required": ["basketName"]

Hello @TommySorensen !
You need to add required property
https://swagger.io/docs/specification/data-models/data-types/
"required": ["basketName"]

Thx will try with that.

@TommySorensen if that worked, remember to update or close this issue.  Thanks!


Allow Redash to load table list for Trino data source

User Story
As a data analyst I would like to be able to construct queries against the Trino engine in our Redash BI system.
Description/Context
Our Redash installation is unable to load the schema information for the data lake from Trino. This could be due to the sheer number of tables, a permission issue in the account used in the connection, or some other bug in Redash.
Acceptance Criteria

[ ] I am able to load the table list in Redash when using the Trino Data Lake data source. Example query available for testing here
[ ] The list of tables visible and queryable in Redash is limited to the intermediate and mart schemas.

Testing the connection on redash (QA) works, however it continues to fail loading any schemas and it’s not a permissions thing. Was looking at the trino query code in redash to see what it’s running to load the schemas and trying running that same query in starburst and it just hangs.
https://github.com/getredash/redash/blob/master/redash/query_runner/trino.py#L79-L85

Tried running this in Starburst:
SELECT "table_schema" FROM "ol_data_lake_qa"."information_schema"."columns" LIMIT 10;

which throws the following error:
User: arn:aws:sts::xxx:assumed-role/data-lake-query-engine-role-qa/trino-session is not authorized to perform: glue:GetTables on resource: arn:aws:glue:us-east-1:xxx:database/information_schema because no identity-based policy allows the glue:GetTables action (Service: AWSGlue; Status Code: 400; Error Code: AccessDeniedException; Request ID: 35ae286c-f253-4ee0-bd75-c021d6f18af3; Proxy: null)

Fixed permission on the AWS side, and tried running the query again on the Starburst side without a LIMIT. Ran the following which is a subset of what the Redash Trino connector runs to refresh the schema:
SELECT "table_name" FROM "ol_data_lake_qa"."information_schema"."columns";

That took 23m 39s to complete which kinda explains why testing the Trino data source connection works however it fails to refresh the schema.

The exact SQL statement that Redash Trino runs took 26m 20s to complete when I ran it in Starburst.  Clearly that's not gonna work and we're gonna have to maybe reach out to Starburst folks to see what the issue is and what can be done on their end.

Starburst folks asked me to run:
select count(*)  FROM information_schema.columns
WHERE table_schema NOT IN ('pg_catalog', 'information_schema');

It took 23m 19s and returned 14,603 rows. Based on what I was told, Starburst/Trino has to make calls to AWS Glue for that info which ends up taking quite a while. They had a similar issue with Powerbi and the way they fixed it was by changing the code to only query objects that the user expanded.
There is no real caching layers (10 seconds) since new objects wouldn't show up. Gist of it is that it's bad code on the Redash side and we should open an issue or try and reach out to someone on that team.

It appears that even when schema is specified in the Redash Trino data source, that schema is not used when Redash runs its get_schema function. I ran the following query in Starburst to see how long it'll take if a schema is specified:
select count(*)  FROM information_schema.columns WHERE table_schema IN ('ol_warehouse_qa_intermediate');

That query took 7s to run and returned with 79 rows. So we probably need to patch Redash so that it actually uses the configured schema when running the get_schema function.

I added a patch in our fork of Redash that adds filtering of the schema when it is configured in the data source to help resolve this issue. https://github.com/mitodl/redash/pull/6/files

That fix has been merged and validated on QA and production.


Tweak ApplicantBadge component

This complements https://github.com/x-team/auto/pull/697 by making ApplicantBadge more flexible

Add active state to highlight the whole text content area
Remove the padding from the lefthand side
Give a top and right padding to the text content

For reviewers
Should be merged first, before the https://github.com/x-team/auto/pull/697 PR.

@nicksp looks good, I've just made a couple of cleanups:

un-namespaced the style constants
activeApplicantClassName only needs to be applied once on the container, not twice
used ternary instead of boolean for conditional class application, to avoid the string false being rendered to the DOM

@joshwnj the second isActive class name was required, by removing it you got back to the state where we had a bug on long email addresses:

Fixed that on master branch

@nicksp hmm but .isActive is only changing the background colour. Isn't this an overflow problem?


Run scalar-semantic benchmark variants

Refactors benchmark runner a bit to also run scalar semantic versions of benchmarks.
Built on top of https://github.com/apple/swift-experimental-string-processing/pull/658

Sorry, I missed the PR stack and was just looking at this one first. All three LGTM; I'll come back to the scalar semantics.

@swift-ci please test


Update deploy script

Move rav1e-ch build in another job to speed up deployment
Remove useless linker options for Windows, enabled by default in GithHub Actions

Coverage increased (+0.2%) to 85.019% when pulling 7e3e60687ace6dd51f89afbf9381b7eb4b89dfaf on Luni-4:deploy into a0328612c1cf4dad0dd93dea61d459ff0f548c72 on xiph:master.


Add maxCommits url query to the REST API

Motivation:
A user may not know how many history is in the repository and may have get an error
to get history using relative revision number (e.g, from -1 to -10 when there're
only three history).
If the user uses the maxCommits url query parameter (e.g maxCommits=10  with from -1 to 1),
there's no likely chance to fail and he or she is able to get the history no matter how many history
is is.
Modifications:

Add maxCommits url query to the REST API
Modify Go library to use it

Result:

Better user experience

Codecov Report

Merging #202 into master will decrease coverage by 0.04%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #202      +/-   ##
==========================================
- Coverage   64.15%   64.11%   -0.05%
==========================================
  Files         271      271
  Lines        9648     9650       +2
  Branches     1091     1091
==========================================
- Hits         6190     6187       -3
- Misses       2822     2828       +6
+ Partials      636      635       -1

Impacted Files
Coverage Δ

...raldogma/server/internal/api/ContentServiceV1.java
86.44% <100%> (+0.23%)
:arrow_up:

...ogma/server/internal/storage/StorageException.java
22.22% <0%> (-22.23%)
:arrow_down:

...ernal/storage/repository/git/CommitIdDatabase.java
72.8% <0%> (-1.76%)
:arrow_down:

...internal/storage/repository/git/GitRepository.java
78.98% <0%> (-0.16%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7327a49...6b6f5a7. Read the comment docs.

Thanks, @minwoox !


Added simple node server setup for back-end

Comes with earlier added login form in the client-side react app.


Can't Activate FG in Ready Or Not

Hi there,
Got it working using the winmm.dll method with 3.01 and 3.02. There is a significant amount of screen tearing, even with v-sync forced in nVidia control panel.
Cheers

I am using a 3060ti, with a 60hz monitor. Using "rapid" v-sync in NVCP and a framerate cap at 120 fps (RTSS) reduce the screen tearing significantly, and the input lag is greatly reduced too.

Hi,
I tried but no change. Tried with vsync off and rapid in the NVCP. It's weird, I have not this issue in Alan Wake 2 and Silent Hill 2. They are not FPS tho. Maybe if I had a monitor with some sort of VRR their wouldn't be this screen tearing


Discord worker in cloud - reachable by our devs

Acceptance criteria:

Masa Discord showup on endpoint. Anyone can query discord data from that endpoint.

This is enabled on test4 (masa protocol bootnode): <IP_ADDRESS>


knife client create requires json_class in the user-provided json

Attempting to create a client without the "json_class" key in the user-provided JSON fails:
> cat clients/upload_test_4.json
{
  "name": "upload_test_4"
}
> EDITOR="cat clients/upload_test_4.json >" knife client create upload_test_4
ERROR: knife encountered an unexpected error
This may be a bug in the 'client create' knife command or plugin
Please collect the output of this command with the `-VV` option before filing a bug report.
Exception: NoMethodError: undefined method `save' for {"name"=>"upload_test_4"}:Hash

Adding json_class to the json does the trick:
> cat clients/upload_test_4.json
{
  "name": "upload_test_4",
  "json_class": "Chef::ApiClient"
}
> EDITOR="cat clients/upload_test_4.json >" knife client create upload_test_4
Created client[upload_test_4]
-----BEGIN RSA PRIVATE KEY-----
REDACTED
-----END RSA PRIVATE KEY-----

The ChefFS upload command does not have this problem:
> knife client delete upload_test_4
Do you really want to delete upload_test_4? (Y/N)y
Deleted client[upload_test_4]
> cat clients/upload_test_4.json
{
  "name": "upload_test_4"
}
> knife upload clients/upload_test_4.json
Created clients/upload_test_4.json

Users shouldn't need to know about the json_class hack.

Resolved via #2784


[Translation] Update namespace to Azure.AI.Translator.DocumentTranslation

Still need to update the folder documentranslation to translator. will do it in a future PR

/azp run net - documenttranslation - tests

Currently, there are 4 tests on the live pipeline that are constantly failing. They are tracked by https://github.com/Azure/azure-sdk-for-net/issues/20039

/check-enforcer override


Log error: movie skipped

Hey Diaoul and others
I got a little issue with subliminal (love the program tho dude really thnx for that :p )
but I have alot of older movies (older than 30days) and subliminal wont download subs for those movies... Is there a way to bypass that rule of subliminal?
Or can you add it in the next release that we can chose that for ourselfs cause I want subs for all my movies ofc :)
Kind regards

Please take a look here: #618
I think you have the same issue and it's related to another github repository: https://github.com/SynoCommunity/spksrc/issues/1561

thnx @ratoaq2


Fix wonky search handling

At times, when querying /search/* the search will be triggered but then hang without ever returning any results. Looks like doSearch() doesn't wait long enough for results?

Hopefully fixed with the release of 0.16.4. I gave the search UI more time to display the results, it should at least reduce the risk of the search route hanging.


Destroy/Restore YouTube not working?

Hi,
I'm trying to destroy a YouTube instance and then restore it, but it doesn't seem to work. The docs do not mention that these methods wouldn't work for YouTube as well.
My HTML is

and js
videos = plyr.setup({});

In the docs it says

Destroys the plyr UI and any media event listeners, effectively restoring to the previous state before setup() was called.

When I call videos[0].plyr.destroy()it doesn't restore the original HTML, though I don't know if it should.
But when I call videos[0].plyr.restore() it gives me an error:
Uncaught TypeError: Cannot set property 'buffered' of undefined
I made a fiddle: https://jsfiddle.net/f1hc53cq/2/
Is there something I'm doing wrong?
Thanks for any help,
Daniel

This should be fixed in v1.9.0 - could you give it a go? Bear in mind there were also several breaking changes so check the changelog

It seems to work now, thanks!


Autosticker problem in the group

Hello, I'm having autosticker problems in the group, when I activate it in the group and send the images to be made the stickers, the bot does not do and this error is showing up on the console, you know how to solve?

Hi, thanks for submitting the issue. I will investigate it as fast as possible.

Okay thank you

I've deleted some buggy function that doesn't really matter. Please update the source code to the latest version using:
> git pull origin master

If another error occur, just send it here. I need to get some rest, it's 03:20 AM here lol.

In case the issue has been really solved, considering to close this.

I've deleted some buggy function that doesn't really matter. Please update the source code to the latest version by typing:
> git pull origin master

I came back, I will test again, I will be back in 5min.

In case the issue has been really solved, considering to close this.

This problem has been resolved, thank you very much. Have a nice rest.
Closing the topic.


tests/formulae: skip attestation verification when bottle-reinstalling gh

This should hopefully be the last of these?
https://github.com/Homebrew/homebrew-core/actions/runs/11133201051/job/30951261825?pr=192550#step:3:44
Follow-up to #1247 and #1248.

Last one indeed: https://github.com/Homebrew/homebrew-core/pull/192550 😌


Refactoring

Realised that after adding async there was a lot of repeated code, so I have tidied it up making a RemoveControlBase which both RemoteControl's inherit from. It also converts the yaml into a dataclass ready for #4 implementation.

thanks


Python 3.10 changes

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Added patch to make NWChem build with Python 3.10 as discussed in https://github.com/conda-forge/nwchem-feedstock/pull/15

Using I used conda-smithy to re-render with the command conda smithy rerender -c auto, commit https://github.com/conda-forge/nwchem-feedstock/commit/cb24b13b44b999ec6954a476888a56050cd2974a was generated. Not sure if step is needed.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Closing because of build failures

@conda-forge-admin, please rerender


Preview in the table view of the ratio of how much data we lose by filtering something out on mouse hover in filter view

Do we still count with this one?

Would be nice, but has a low priority for now.

Duplicate of #81. I'm closing this one.


Moder QDK doesn't recognize scientific notation with capital E of floating-point numbers

Describe the bug
I've noticed this for 1E-9, then I couldn't find a way to write it down using capital E.
Expected behavior
I expect scientific notation with capital E to be recognized, same as Classic QDK did. Looking at the Double.qs sample, it looks like now only lower-case e is recognized now.

@swernli I feel like we discussed this when building the parser, but I can't remember the discussion. We explicitly only check for e. We have the same casing limitation with the radix.
    fn exp(&mut self) -> bool {
        if self.next_if_eq('e') {
            self.chars.next_if(|i| i.1 == '+' || i.1 == '-');
            self.eat_while(|c| c.is_ascii_digit());
            true
        } else {
            false
        }
    }

Radix:
    fn leading_zero(&mut self, c: char) -> Option<Number> {
        if c != '0' {
            return None;
        }

        let radix = if self.next_if_eq('b') {
            Radix::Binary
        } else if self.next_if_eq('o') {
            Radix::Octal
        } else if self.next_if_eq('x') {
            Radix::Hexadecimal
        } else {
            Radix::Decimal
        };
//...

Unless there's a good reason not to, we should support either case.

Unless there's a good reason not to, we should support either case.

Should we fix just E or also allow for capital letter radix too? @tcNickolas do you know if the classic QDK accepted both 0x101 and 0X101?

Yes the old QDK accepted capital letters B, O and X for binary, octal and hexadecimal.

In that case it's a little more than a one-line change, but it's close, and might make a good first issue. The functions Ian mentioned above would need to be updated to check both characters like so:
    fn exp(&mut self) -> bool {
        if self.next_if_eq('e') || self.next_if_eq('E') {
            self.chars.next_if(|i| i.1 == '+' || i.1 == '-');
            self.eat_while(|c| c.is_ascii_digit());
            true
        } else {
            false
        }
    }

and
    fn leading_zero(&mut self, c: char) -> Option<Number> {
        if c != '0' {
            return None;
        }

        let radix = if self.next_if_eq('b') || self.next_if_eq('B') {
            Radix::Binary
        } else if self.next_if_eq('o') || self.next_if_eq('O') {
            Radix::Octal
        } else if self.next_if_eq('x') || self.next_if_eq('X') {
            Radix::Hexadecimal
        } else {
            Radix::Decimal
        };
//...

And new test cases should be added accordingly.


There is no support for "SCORER" in search options.

There is no support for "SCORER" in search options.
SCORER {scorer} : If set, we will use a custom scoring function defined by the user
FT.SEARCH <index_name>  SCORER <scorer_name>

This was added to LettuceMod (new home for lettusearch functionality)


Provide support for .json ext

:tada: This issue has been resolved in version 2.13.0 :tada:
The release is available on:

v2.13.0
npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


cross compile scala 2.11

@williamboxhall

Coverage remained the same at 100.0% when pulling 2469b3b915c694efa576a292bbf839d4170ffcc5 on cross-compilation into d3c6ed35743132aa6a9fe9672ebcf05b69ff4d0e on master.

configure the release plugin

Coverage remained the same at 100.0% when pulling 27b2522302c56d48bf3d64c74b1ec8a536e77176 on cross-compilation into d3c6ed35743132aa6a9fe9672ebcf05b69ff4d0e on master.

nice


Can't build from Github generated source archives

Github's generated source zips / tar.gzs strip all the git stuff out, which we currently rely on for generating our version string.

see commit 2bb97a7e0cdf2ee33597a2f7d348262423467924


fix(datepicker): popup background

Resolves #11
DCO 1.1 Signed-off-by: Pooya Parsa<EMAIL_ADDRESS>

Thanks again!

Ah sorry. I've fixed that :)

No worries! All good!

Just waiting for CI to come back then will merge!


Failed to load initial state of resource

Describe the bug
After install ArgoCD using Operator on Openshift, Application and Cluster show errors for many such resources and the namespace added in the cluster
failed to sync cluster https://<IP_ADDRESS>:443: failed to load initial state of resource Service: services is forbidden: User "system:serviceaccount:gm4c-devops-factory:argocd-gm4c-argocd-application-controller" cannot list resource "services" in API group "" in the namespace "dev"
To Reproduce
Steps to reproduce the behavior:

Install the latest version of ArgoCD Operator in a single Namespace on OpenShift
Creat an instance of ArgoCD using the steps given here-
https://argocd-operator.readthedocs.io/en/latest/usage/basics/
Once the instance is Available, set the spec:server: route: enabled: true
Access ArgoCD on the Route created.
Login to the ArgoCD using admin
Add namespace dev to the in-cluster
Add Git repository
Create an application, choose namespace dev
Application shows multiple error messages as in the screenshot
Cluster shows error as in the screenshot

Expected behavior
The application should not show errors.
The Cluster should show a connected status
Screenshots

Additional context
the below log is for many such resources  and namespaces
failed to sync cluster https://<IP_ADDRESS>:443: failed to load initial state of resource DaemonSet.apps: daemonsets.apps is forbidden: User "system:serviceaccount:gm4c-devops-factory:argocd-gm4c-argocd-application-controller" cannot list resource "daemonsets" in API group "apps" in the namespace "dev"
We want to use ArgoCD for deploying only on a few Namespaces of OpenShift

+1

and many errors : watch failed


AST as S-expressions

Internal technical followup to #2037 (includes commits from that PR).
We now serialize ASTs to standard S-expressions; that makes tests more predictable.
Also, tests for floats test AST internals instead of string serialization.

Codecov Report

Merging #2038 (fa3a612) into develop (6426117) will increase coverage by 0.71%.
The diff coverage is n/a.

:exclamation: Current head fa3a612 differs from pull request most recent head 0bfc8b8. Consider uploading reports for the commit 0bfc8b8 to get more accurate results

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@             Coverage Diff             @@
##           develop    #2038      +/-   ##
===========================================
+ Coverage    70.10%   70.81%   +0.71%
===========================================
  Files          101      104       +3
  Lines         5084     5167      +83
  Branches       968      996      +28
===========================================
+ Hits          3564     3659      +95
+ Misses        1476     1471       -5
+ Partials        44       37       -7

see 45 files with indirect coverage changes

Small note: But when you have a second PR that requires a first, I recommend changing the base branch to the first, so the diff is clear.

We can change it later on when that gets merged.


Also CustomLoaderSkin.log, but the log is not recognized

log's url https://mclo.gs/TMcfK3w

Thanks for reporting this, and sorry for taking a while to respond.
This is now being worked on in https://github.com/aternosorg/codex-minecraft/pull/47


Rename columns as per AR output

Closes #233

🤔 I agree that this is at least a minor version bump, possibly major. I don't know how we can get around this in a graceful way though.
Are any of the new columns essential for any functionality? If so, I'd say we don't worry too much about supporting the old data format. If we can still run things off of old data though, we could run some checks on the data, and see which column names they have, and process further based on that. If they're using the old format, throw a warning, and say that we'll be deprecating support for that format in the "near future"™
How much work would it take to check for that? Testing would be a bit of a pain, but not impossible. And we could then have datasets ald_demo and ald_demo_old_format

None of the columns changed here are used in r2dii.match or r2dii.analysis (ie. they are unessential for any functionality.
In my comment on #233 , I split up @vintented's (and AR's) proposed changes into two categories:

I am reopening this as per @vintented's most recent comments on #236
In particular:

lei_company should be lei
id_company should be company_id
ald_emission_factor_unit should be emission_factor_unit
is_ultimate_listed_owner should be removed

Several other comments affect columns used extensively in downstream packages (r2dii.match and r2dii.analysis) and will NOT be changed prior to the upcoming banks release:

name_company should be company_name
production should be activity

The first (those that are implemented in this PR) are completely cosmetic, and the columns are unused in downstream packages.
The second two, namely the changes to name_company and production are used extensively in downstream packages, which is why I elected we hold off on editing these until we are sure we have to.

My understanding (@vintented correct me if I'm wrong) is that the most important name changes were company_id and lei, which are captured above. Anything else that is changed is just bonus points. Really appreciate you working on this, it'll help us align going forward.
@AlexAxthelm based on what @jdhoffa said above, testing is not too important. lei_company, id_company, and is_ultimate_listed_owner were not even in the last release, so they can't break anything downstream since they didn't exist. That leave the rename of ald_emission_factor_unit, which would only effect users who were using it in the outputs.
I say, considering moving the ald_emission_factor_unit to the second category you listed @jdhoffa. Then there is no need for testing or concern, and it can be changed along with then name and production columns in a future release.

@tposey28 thanks, but what you said about ald_emission_factor_unit is untrue, since this is not even actually present in the output

Thanks @jdhoffa for correcting me. It's great to know our code won't break (otherwhise we'd know on CI).
Thanks @tposey28, I think it's nice you inform us but just like any dependency you are free to change things. The question I'm posing is not if we can do it but how. Users may be using demo datasets in scripts, for example, to teach their colleagues how to use our packages. If we release the new ald_ar dataset and leave ald_demo untouched, then such scripts will continue to work for long enough for them to embrace the change and start using ald_ar.

Now that the relevant people are aware, and that @jdhoffa proved to have measured the consequences, I leave it to him to decide. I'll approve this PR so we can merge whenever he's ready.


"access" param handling for model properties

using swagger-core-1.5.1-M2.
I am trying to filter parameters/properties based on the access param.
@ApiParam/@ApiImplicitParam and swagger-models Parameter work just fine. There, both sides support the property and it can be mapped (e.g. in swagger-jaxrs ParameterProcessor).
However, @ApiModelProperty s access flag/param is not mapped to swagger-models Property. AbstractProperty/Property are lacking a corresponding access property, I think?
Not having the access param available in swagger-models Property makes it hard, if not impossible, to filter model properties based on the access param with a SwaggerSpecFilter. At least I did not find a clean way.
Additionally, wouldnt adding an access param to @ApiOperation/Operation make sense, too? That way, all filtering methods of SwaggerSpecFilter could access their corresponding access param for the filtering decision (isOperationAllowed, isParamAllowed, isPropertyAllowed).
thanks, zyro

i understand that this is tagged Feature for the idea of adding an access param to @ApiOperation.
however, i fail to see how the currently available @ApiModelProperty.access is supposed to be used properly if it cannot be evaluated from a SwaggerSpecFilter?
i would be ok with a workaround in the meantime, too. thanks, zyro

Apologies, read the issue too quickly. Regarding @ApiModelProperty, you are correct. Organization-wise though, you need to pick whether this issue deals with this problem or the feature request, and open an additional issue to cover the other part. We can definitely fix the @ApiModelProperty issue.

sure will quickly open a new one for the @ApiModelProperty "bug" as this one is now already tagged feature

I can change the tags, it's no problem, but if you a new one for the bug, make sure to change the title of this one.
I'd create one for the feature request and leave this one for the bug. Up to you.


setting slurm_extra across clusters

Another issue that's come up in this run is that by default, jobs submitted to argo will run only on two of the fourteen GPUs currently available.
To run on the other 12, we usually have to specify:
#SBATCH --partition=main,hoppertest,skinniderlab

This would be an easy fix except that on della, we usually want to run on the PLI partition, and to access that we need to do:
#SBATCH --account=skinniderlab
#SBATCH --partition=pli

Finally, sometimes we also run on the main della partition, in which case we don't want to specify the two additional arguments above.
For now I am just manually editing the slurm_extra values in Snakefile_data to access specific partitions on specific clusters. This is a little clunky but seems to work fine. Is this how the two of you were managing this too, @vineetbansal @anushka255? Or is there a better/different way to do this, e.g., by setting some kind of cluster-specific profile, or by passing in additional arguments when calling snakemake?

You can add an extra argument when calling snakemake:
snakemake --jobs 20 --slurm --default-resources slurm_partition=main,hoppertest,skinniderlab

This will set the same partition for all the rules. And if the individual rules require different partition, you can also override the default per rule by adding the following argument:
--set-resources <rule>:slurm_partition=<other_partition>

Great, just ran this successfully, thanks!

for future reference:
snakemake \
  --configfile /Genomics/skinniderlab/food-clm/clm/database=FooDB-representation=NA-metric=NA-optimizer=NA-rarefaction=1-enum_factor=30/config.yaml \
  --slurm --jobs 10 \
  --default-resources slurm_partition=main,hoppertest,skinniderlab


ETCD v3 + configstore does not seem to work.

Do you want to request a feature or report a bug?
Bug
What did you do?
I followed the documentation to use ETCD v3 as backend.
What did you expect to see?
Working as it should.
What did you see instead?
etcd permission issues.

Output of traefik version: (What version of Traefik are you using?)
traefik:v1.7.0-rc3

What is your environment & configuration (arguments, toml, provider, platform, ...)?
---
kind: ClusterRole
apiVersion: rbac.authorization.k8s.io/v1beta1
metadata:
  name: traefik-ingress-controller
rules:
  - apiGroups:
      - ""
    resources:
      - services
      - endpoints
      - secrets
    verbs:
      - get
      - list
      - watch
  - apiGroups:
      - extensions
    resources:
      - ingresses
    verbs:
      - get
      - list
      - watch
---
kind: ClusterRoleBinding
apiVersion: rbac.authorization.k8s.io/v1beta1
metadata:
  name: traefik-ingress-controller
roleRef:
  apiGroup: rbac.authorization.k8s.io
  kind: ClusterRole
  name: traefik-ingress-controller
subjects:
- kind: ServiceAccount
  name: traefik-ingress-controller
  namespace: kube-system
---
apiVersion: v1
kind: ServiceAccount
metadata:
  name: traefik-ingress-controller
  namespace: kube-system
---
kind: DaemonSet
apiVersion: extensions/v1beta1
metadata:
  name: traefik-ingress-controller
  namespace: kube-system
  labels:
    k8s-app: traefik-ingress-lb
spec:
  updateStrategy:
    type: RollingUpdate
    rollingUpdate:
      maxUnavailable: 1
  template:
    metadata:
      labels:
        k8s-app: traefik-ingress-lb
        name: traefik-ingress-lb
    spec:
      serviceAccountName: traefik-ingress-controller
      terminationGracePeriodSeconds: 60
      initContainers:
      # this will load the config from the configmap into etcd v3 (locking support).
      # Locking prevents that the config is use in a half state (during replica rollout)
      # The configmap is NOT monitored for changes, etcd is.
      # running this storeconfig on it own allows changing the config of running instances ;)
      - name: storeconfig
        image: traefik:v1.7.0-rc3
        imagePullPolicy: IfNotPresent
        args:
        - storeconfig
        - -c
        - /config/config.toml
        volumeMounts:
        - name: config-etcd
          mountPath: /config
          readOnly: true
      containers:
      - name: traefik-ingress-lb
        image: traefik:v1.7.0-rc3
        args:
        # only the etcd config is needed here!
        - --configFile=/config/config.toml
        ports:
        - name: http
          containerPort: 80
          hostPort: 80
        - name: https
          containerPort: 443
          hostPort: 443
        securityContext:
          capabilities:
            drop:
            - ALL
            add:
            - NET_BIND_SERVICE
        volumeMounts:
        - name: config
          mountPath: /config
      dnsPolicy: ClusterFirst
      hostNetwork: true
      nodeSelector:
        # make sure to give this a good name starting with role-ingress-traefik-*.
        role-ingress-traefik-test: "true"
      volumes:
      - name: config
        configMap:
          name: traefik-config
          items:
          - key: config.toml
            path: config.toml
      - name: config-etcd
        configMap:
          name: traefik-config-etcd
          items:
          - key: config.toml
            path: config.toml
---
kind: Service
apiVersion: v1
metadata:
  name: traefik-ingress-service
  namespace: kube-system
spec:
  selector:
    k8s-app: traefik-ingress-lb
  ports:
    - protocol: TCP
      port: 80
      name: web
    - protocol: TCP
      port: 443
      name: web-secure
---
apiVersion: v1
kind: ConfigMap
metadata:
  name: traefik-config-etcd
data:
  config.toml: |
    defaultEntryPoints = ["http","https"]
    debug = false
    logLevel = "DEBUG"

    [entryPoints]
      [entryPoints.http]
        address = ":80"
        compress = true
        # enable redirrect
        [entryPoints.http.redirect]
        entryPoint = "https"
      [entryPoints.https]
        address = ":443"
        compress = true
        [entryPoints.https.tls]
      [entryPoints.http-metrics]
        address = ":5555"
    [metrics]
      # enable metrics endpoint
      [metrics.prometheus]
        entryPoint = "http-metrics"
        buckets=[0.1,0.3,1.2,5.0]
    # enable ping for healthcheck
    [ping]
      entryPoint = "https"

    [etcd]
      endpoint = "[redacted]"
      # look for changes, needed in cluster setup.
      watch = true
      # etcd prefix /k8s/[clustername]/traefik-[purpose]. Look out for trailing slashes.
      prefix = "/k8s/[redacted]/traefik-test"
      # Will soon be the default and is needed for atomic operations
      useAPIV3 = true
      # Username configured in etc k8s_[clustername]_traefik
      username = "k8s_[redacted]_traefik"
      password = "[redacted]"
    [etcd.tls]
      # enable tls but skip securitycheck, can be used if certificates are provided..
      insecureSkipVerify = true

    [acme]
      entryPoint = "https"
      # email on lets encryp issues
      email = "[redacted]"
      # Look out for trailing slashes and match the correct ETCD path.
      storage = "/k8s/[redacted]/traefik-test/acme/account"
      # log this in the pod logs
      acmeLogging = true
      OnHostRule = true
      # override default if needed, for testing for example
      caServer = "https://acme-staging-v02.api.letsencrypt.org/directory"
      [acme.httpChallenge]
        entryPoint="http"

    [kubernetes]
    # Make this ingressClass specific so that you can use kubernetes.io/ingress.class: traefik-test. Start with "traefik-*"
    ingressClass = "traefik-test"
---
apiVersion: v1
kind: ConfigMap
metadata:
  name: traefik-config
data:
  config.toml: |
    debug = true
    logLevel = "DEBUG"
    [etcd]
      endpoint = "[redacted]"
      # look for changes, needed in cluster setup.
      watch = true
      # etcd prefix /k8s/[clustername]/traefik-[purpose]. Look out for trailing slashes.
      prefix = "/k8s/[redacted]/traefik-test"
      # Will soon be the default and is needed for atomic operations
      useAPIV3 = true
      # Username configured in etc k8s_[clustername]_traefik
      username = "k8s_[redacted]_traefik"
      password = "[redacted]"
    [etcd.tls]
      # enable tls but skip securitycheck, can be used if certificates are provided..
      insecureSkipVerify = true

If applicable, please paste the log output in DEBUG level (--logLevel=DEBUG switch)
initcontainer:
2018/09/06 08:04:52 Storing configuration: {"LifeCycle":{"RequestAcceptGraceTimeout":0,"GraceTimeOut":10000000000},"GraceTimeOut":0,"Debug":false,"CheckNewVersion":true,"SendAnonymousUsage":false,"AccessLogsFile":"","AccessLog":null,"TraefikLogsFile":"","TraefikLog":null,"Tracing":null,"LogLevel":"DEBUG","EntryPoints":{"http":{"Address":":80","TLS":null,"Redirect":{"entryPoint":"https"},"Auth":null,"WhitelistSourceRange":null,"WhiteList":null,"Compress":true,"ProxyProtocol":null,"ForwardedHeaders":null},"http-metrics":{"Address":":5555","TLS":null,"Redirect":null,"Auth":null,"WhitelistSourceRange":null,"WhiteList":null,"Compress":false,"ProxyProtocol":null,"ForwardedHeaders":null},"https":{"Address":":443","TLS":{"MinVersion":"","CipherSuites":null,"Certificates":null,"ClientCAFiles":null,"ClientCA":{"Files":null,"Optional":false},"DefaultCertificate":null,"SniStrict":false},"Redirect":null,"Auth":null,"WhitelistSourceRange":null,"WhiteList":null,"Compress":true,"ProxyProtocol":null,"ForwardedHeaders":null}},"Cluster":null,"Constraints":[],"ACME":{"Email":"[redacted]","Domains":null,"Storage":"/k8s/[redacted]/traefik-test/acme/account","StorageFile":"","OnDemand":false,"OnHostRule":true,"CAServer":"https://acme-staging-v02.api.letsencrypt.org/directory","EntryPoint":"https","KeyType":"","DNSChallenge":null,"HTTPChallenge":{"EntryPoint":"http"},"TLSChallenge":null,"DNSProvider":"","DelayDontCheckDNS":0,"ACMELogging":true,"OverrideCertificates":false,"TLSConfig":null},"DefaultEntryPoints":["http","https"],"ProvidersThrottleDuration":2000000000,"MaxIdleConnsPerHost":200,"IdleTimeout":0,"InsecureSkipVerify":false,"RootCAs":null,"Retry":null,"HealthCheck":{"Interval":30000000000},"RespondingTimeouts":null,"ForwardingTimeouts":null,"AllowMinWeightZero":false,"Web":null,"Docker":null,"File":null,"Marathon":null,"Consul":null,"ConsulCatalog":null,"Etcd":{"Watch":true,"Filename":"","Constraints":[],"Trace":false,"TemplateVersion":0,"DebugLogGeneratedTemplate":false,"Endpoint":"[redacted]","Prefix":"/k8s/[redacted]/traefik-test","TLS":{"insecureSkipVerify":true},"Username":"k8s_[redacted]_traefik","Password":"[redacted]","UseAPIV3":true},"Zookeeper":null,"Boltdb":null,"Kubernetes":{"Watch":true,"Filename":"","Constraints":[],"Trace":false,"TemplateVersion":0,"DebugLogGeneratedTemplate":false,"Endpoint":"","Token":"","CertAuthFilePath":"","DisablePassHostHeaders":false,"EnablePassTLSCert":false,"Namespaces":null,"LabelSelector":"","IngressClass":"traefik-test","IngressEndpoint":null},"Mesos":null,"Eureka":null,"ECS":null,"Rancher":null,"DynamoDB":null,"ServiceFabric":null,"Rest":null,"API":null,"Metrics":{"Prometheus":{"Buckets":[0.1,0.3,1.2,5],"EntryPoint":"http-metrics"},"Datadog":null,"StatsD":null,"InfluxDB":null},"Ping":{"EntryPoint":"https"},"HostResolver":null}

logs of traefik itself:
time="2018-09-06T08:04:53Z" level=error msg="Load config error: etcdserver: permission denied, retrying in 502.230034ms"
time="2018-09-06T08:04:54Z" level=error msg="Load config error: etcdserver: permission denied, retrying in 1.008861805s"
time="2018-09-06T08:04:55Z" level=error msg="Load config error: etcdserver: permission denied, retrying in 1.529148714s"
time="2018-09-06T08:04:56Z" level=error msg="Load config error: etcdserver: permission denied, retrying in 2.387034683s"
time="2018-09-06T08:04:59Z" level=error msg="Load config error: etcdserver: permission denied, retrying in 2.109027876s"
time="2018-09-06T08:05:01Z" level=error msg="Load config error: etcdserver: permission denied, retrying in 4.636596763s"
time="2018-09-06T08:05:05Z" level=error msg="Load config error: etcdserver: permission denied, retrying in 6.729177868s"

Thanks for opening this issue!
We need further information to better understand the problem you're facing :thinking:
Could you please join us on our Slack workspace and reach out to us on the (#support channel)?
We're looking forward to talking to you there!

It seems to me that etcd prefix was wrong. I had
role grant k8s_[redacted]_traefik-test --prefix=true readwrite /k8s/[redacted]/traefik-test/

The trailing slash made it that traefik did not had the correct permission when starting even if storeconfig worked correctly.
One more question. What does "OverrideCertificates" of ACME do and why is it not mentioned in the docs ?
Furthermore, is there a problem to store the static config multiple times (the locking in ETCD v3 should prevent problems) ? I currently always do this in the init container.

https://github.com/containous/traefik/issues/2712
I seem to be hitting this issue to, adding the keys and letting the pods restart fixes the problem. Can this be solved soon ?


Enabling GenAI Sandbox for DSEP:Scholarships

Description
Set up and enable the DSEP: Scholarship domain in GenAI Sandbox 2.0. Validate the catalogue generation and JSON responses for on_action calls to ensure seamless functionality and integration for DSEP: Scholarship use cases.
Goals

[x] Enable the DSEP: Scholarship domain in GenAI Sandbox 2.0.
[x] Verify if the catalogue is being generated using GenAI; flag if missing.
[ ] Validate the JSON responses for on_action calls to ensure accuracy and structure.

Expected Outcome
A fully functional GenAI Sandbox for the DSEP: Scholarship domain with verified catalogue generation and accurate JSON responses.
Acceptance Criteria

[x] DSEP: Scholarship domain is enabled and functional in GenAI Sandbox 2.0.
[x] Catalogue is generated using GenAI or flagged if missing.
[x] JSON responses for on_action calls are validated and accurate.
[x] No critical issues remain, and the testing is documented.

Mockups / Wireframes
NA
Product Name
Beckn
Domain
TBD
Tech Skills Needed
GenAI Integration, JSON Validation, QA Testing,
Complexity
Medium
Category
Testing
Sub Category
Sandbox Validation

Current Status: Sandbox 2.0 Catalog is enabled for this domain.
Postman Collection: Link


Can't download samples from Danbooru anymore

Bug description
Pretty much what the title says.
Edit 2023-07-16: Just tested version 7.10.1 and it still works fine there.
Steps to reproduce

Go to Options
Uncheck 'Download original images'
Fetch something from Danbooru
See error

Expected behavior
The expected behavior would be to get the image that is displayed when you open a post, usually a downscale of whatever the original image uploaded was. Their filename also has a '__sample' string right before the md5 hash.
System information

OS: Windows 10
Grabber version: 7.11.1 x64

Indeed, there seem to be an issue where it always loads the full image even when it's supposed to load samples. I'll push a fix soon.


[Bug]: Setpoint completely ignored in new DynESS

Contact Details
No response
VRM portal ID
c0619ab410ae
Country / region
Netherlands (nl)
B max
8.5
TB max
3
FB max
3
TG max
4.1
FG max
4.1
Battery costs
No response
Buy price
(p+0.02118+0.15246)*1.21
Sell price
(p-0.02118+0.15246)*1.21
feed-in possible
yes
feed-in control
yes
Version
0.1.6
What happened?
The new SOC method seems to completely overrule the setpoint settings.
As my solar setup connected to an easysolar ii 5kw is able to produce more Amps than I feel comfortable to send to my batteries for a longer time, I used the grid setpoint to redirect some power to the grid on high input. But at the moment this setpoint seems to be ignored completely with the 'new' SOC based implementation.
Relevant log output
No response
Screenshots
![DESCRIPTION](LINK.png)

How did you implement that redirection? Did you adjust the flow to top the setpoint off or so?
You can still lower the 'tb' setting.

Hi, yes I adjust the setpoint with a separate Node-Red flow. It seems the tb setting doesn't apply to the current going from the built-in MPPT to the battery.
Although I've got no idea how it technically works to lower the amps going into the battery and feeding the excess into the grid, while everything is on the same busbar, but hé that's your trick ;-)

Maybe it is possible to use the setpoint from venus os in ess settings if dyness set the setpoint to 0.
We want to kill most grid consumption so we set the setpoint to -70W.

You would say that, but the whole setpoint  setting seems to be ignored. F.e. at this moment, the setpoint is set to 0, the target SOC is set to 84 % and the system decides to import like 600W from the grid to top-up the 1700W Solar for charging the battery to get to this 84%. This all seems to happen, completely ignoring the Setpoint setting (and maybe other settings, like current limit?) from the Venus OS Console.

That is correct. When running Dynamic ESS the setpoint is ignored, as it is working with the target SOC instead. You cannot have 2 steering mechanisms working at the same time.

Is there expected to be some knobs and/or variables to fine-tune the Dess behaviour in the future? It looks like there is some demand for that?

Seems a won't fix?

@dirkjanfaber

That is correct. When running Dynamic ESS the setpoint is ignored, as it is working with the target SOC instead. You cannot have 2 steering mechanisms working at the same time.

Hey i think for most german users it would be nice to change the system behind dyness from target soc to setpoint.
In my case we have changing selling prices each hour and a constant consumption price.
Apparently it doesn't make sense to work with a target SOC, as the battery will then often be charged from the grid, which incurs high costs. (This is only permitted in Germany for calibration, otherwise it is illegal.)
It would be better if a program determined when the battery is charged and when it is discharged depending on the yield forecast, the consumption forecast, the sales price per hour and the system losses and battery costs. It is important that, if possible, no electricity is drawn from the grid, unless the previous sale from the battery was even better after deducting all losses. This would make DESS much more economical.
I think working with target soc may be easier but now it`s not interessting for me to use DESS beacuse auf much more grid consumption and no economical behavior.


⚠ Fortnite has degraded performance

In b7c292e, Fortnite (https://fortnite.com) experienced degraded performance:

HTTP code: 200
Response time: 1671 ms

Resolved: Fortnite performance has improved in aa67bca.


Adding the dead of the protests section

Hi guys,
We should not forget those who died on the way of this protests.

We will be adding it. If anyone is interested in helping, please add a new page under content folder

I can add that. Can you please specify the details of this feature. What details of the person must be shown, how will we input the person.
Might be some wrong questions because I'm new to open source

I will work on this today, will be grabbing data from https://iranhr.net/en/, NGO based in Norway.

PR is ready, waiting for review/merge.

This looks great. Will merge it now.


Cannot switch list types

https://user-images.githubusercontent.com/26425882/233865099-61574cad-037d-445a-9e2e-892958372bb0.mp4
^ Video of repro.

Fixed in #96


SCP-2858: Chain-index configurable securityParam

Pre-submit checklist:

Branch

[ ] Tests are provided (if possible)
[x] Commit sequence broadly makes sense
[x] Key commits have useful messages
[x] Relevant tickets are mentioned in commit messages
[x] Formatting, materialized Nix files, PNG optimization, etc. are updated

PR

[x] Self-reviewed the diff
[x] Useful pull request description
[x] Reviewer requested

This look great @sjoerdvisscher
I think there's another few spots to use this new parameter, though; they are centered around the use of chainConstant field, defined in src/Plutus/ChainIndex/TxIdState. I think this should just be the securityParam value of your new config (right @j-mueller ?)

I quickly looked at that, but they are used in pure functions, and it looked like a non-trivial task to get the value from config files to the right place.


"Cut Layers" only deletes polygon objects

This issue is present in the vanilla GeoMan version on the demo page.
The "Cut layers" action only deletes polygons, it does not delete point markers or lines:

I believe it should delete all features within the specified polygon.
My guess is that this code needs to be extended to support feature types other than polygon:

The cut mode can be only used for area shapes like Rectangles and Polygons.
I will transform this into a Feature Request and if there are enough likes, we will think about implementing it.


Sort amount correctly

Description

Sort amount by real value

Closes #550

FYI, I don't have an account with all the varieties of tokens in @apbendi's example, but this seems to be working with a single token. If anyone has test tokens they want to send me on Sepolia I can test with more.

If anyone has test tokens they want to send me on Sepolia I can test with more.

The DAI and USDC tokens we use on sepolia can be minted by anyone, so you can mint as much as you want to your wallet: https://github.com/ScopeLift/umbra-api/blob/9631aa785eae26e0a9b5df58bf95ad3b4cbde6ce/src/constants/tokens.ts#L10-L11

Tested with multiple tokens and seems to be working


[Troubleshooting tip] - when ZWESISTC proclib program name is changed document that instance.env needs updating also

The PROCLIB for ZWESISTC contains the name of the cross memory
A customer had changed this, and was unable to log onto the desktop because the zss server was unable to handshake with cross memory
Fix was to update instance.env
This should be documented more clearly

The ZWESISTC PROCLIB member
//ZWESISTC  PROC NAME='ZWESIS_STD',MEM=00,RGN=0M

Solution is to add a comment to the JCL member we deliver and also to update the chapter app-framework/app-troubleshoot.md.


Support terraform 1.0.0 now that it went gold.

Completely trivial, but this PR fixes the module following the release of terraform 1.0.0

Completely trivial, but this PR fixes the module following the release of terraform 1.0.0

Hi @stephgosling ,
Thanks for your PR. Unfortunately, we need to adjust a few more things here - the tests are still running with Terraform v0.15 (see the Makefile for details). We are currently testing our modules for compatibility with Terraform v1.0.0, adjusting the tests, creating release notes, etc. We will ensure compatibility later this month and come back to you once we released the new version.
Again, thanks for your contribution!

Completely trivial, but this PR fixes the module following the release of terraform 1.0.0

Hi @stephgosling ,
We finally found some time to release a new version with Terraform 1.x support in https://github.com/mineiros-io/terraform-aws-cognito-user-pool/releases/tag/v0.7.0.
Again, thanks for your contribution and patience! :)


Fix: https://github.com/tiangolo/fastapi/discussions/10493

@Kludex

Thanks for your help! @sepsh 😄
For future references: This is a fix for https://github.com/tiangolo/fastapi/discussions/10493

Nice catch @sepsh! 🔍
Thanks for the reviews @Kludex, @hasansezertasan, @alejsdev ☕ 🍪 👋

Thanks to your awesome work @Kludex @alejsdev @alejsdev @hasansezertasan. I'm glad I could help. 🤗✌


Option does not take effect

Timings link
No response
Expected behavior
I set

sand:         fix-duping: false
in purpur.yml
Observed/Actual behavior
But sand still cannot be copied, the same save works fine on vanilla
Steps/models to reproduce
Save from https://www.bilibili.com/video/BV1VL4y1h7zE
Purpur version
[14:15:01 INFO]: Checking version, please wait...
[14:15:04 INFO]: This server is running Purpur version git-Purpur-1492 (MC: 1.18.1) (Implementing API version 1.18.1-R0.1-SNAPSHOT) (Git: 29b24bc on HEAD)
[14:15:04 INFO]: You are running the latest version
Agreements

[x] I am running the latest version of Purpur available from https://purpurmc.org/downloads.
[X] I have searched for and ensured there isn't already an open issue regarding this.
[X] My version of Minecraft is supported by Purpur.

Other
No response

You also need to set allow-piston-duplication to true in paper.yml for duping to work

You also need to set allow-piston-duplication to true in paper.yml for duping to work

I re-tested and it still doesn't work.

There is nothing wrong with the settings. You just don't have an understanding of the bug you are trying to exploit. It was fixed in various spots in the server, meaning you need to toggle various settings to undo these fixes.
paper.yml:
settings:
  unsupported-settings:
    allow--piston-duplication: true

purpur.yml
world-settings:
  default:
    blocks:
      end_portal:
        safe-teleporting: false
      sand:
        fix-duping: false

With these settings, your server is effectively broken and exposed to exploits (even more than just duping, so be careful).
I strongly advise against doing this, and recommend you provide sand and other dupable items using other means. Maybe put a spawner cage that spits out sand items. Or give players access to /give or creative mode.


Converting to using Aws Launch Template to support mixed instances po…

…licy.
PR o'clock
Description
Converting from using aws_launc_configuration to aws_launch_template to support mixed_instances_policy in the worker node's autoscaling group.
Addresses https://github.com/terraform-aws-modules/terraform-aws-eks/issues/194
Checklist

[x] terraform fmt and terraform validate both work from the root and examples/eks_test_fixture directories (look in CI for an example)
[ ] Tests for the changes have been added and passing (for bug fixes/features)
[ ] Test results are pasted in this PR (in lieu of CI)
[x] I've added my change to CHANGELOG.md
[ ] Any breaking changes are highlighted above

Hey @skang0601,
Super excited to have Launch Template support!
Do you think we could implement in a way that does not replace the existing  arrangement with aws_launch_configuration? Like could we choose on a per worker group basis whether a group uses a aws_launch_configuration or aws_launch_template?
Reason being this is quite a large change with a lot of extra options and I think it might be nice to have it optional for a while so people can test it out.
What do you think? And others?!?

@max-rocket-internet I think that's a valid ask. I took the naive approach and just created a separate input for worker groups to be created using the launch template.
Either in the future, this can probably be cleaned up further by switching to launch templates entirely or when some of the newer HCL features finally land on a Terraform release.

Made some additional updates.
I moved the mixed_instances_policy param from a global config to per worker group configuration and updated the changelog

is there any eta for release of this feature?

Maybe we just create workers_launch_template.tf to keep everything clear and separate?

Also please rebase 🙂


feat: setup swc [TOL-1167]

To be conform with the build RFC we want to migrate the live preview SDK package from bundling to transpile only.

@chrishelgert this works in<EMAIL_ADDRESS>we still need the react export so i have restored that to what we had before


Label Format "none" shows strange results

I would like to display my data labels in normal units i.e. not in Thousands, Billions and so on. Whenever I select "None" I only get strangely formated labels and cannot even adjust the decimal places:

@stephanbab
When you select "None", the visual uses the format defined in your model. I guess in your case the format has not been defined or it is currently marked as "General". If you change your measures format to show 2 decimal places,  the visual will show 2 decimal places
The reason you can't select decimal places when you select "none" as the option is because "None" allows you to use your own format including the decimal places. I hope this helps
Thanks

Many Thanks for the prompt response which solved my issue!


Scalable test design

I've created a scalable test design. The design consists of a ROM with data (an initialized BRAM), a configurable number of parallel "processing units" and output module which sends the processed data through UART. For now each processing unit is a 16x16 multiplier implemented using LUTs.
Basically the design reads N 32-bit words from an initialized BRAM, processes them in parallel using N processing units and then sends the results through the UART.
The whole design is artificially slowed down to <1MHz (100MHz / 128) to rule out (hopefully) timing issues of VPR. The UART works on 9600 bps.
The test design comes up with a python script which receives the data through UART and compares it with pre-computed expected pattern.
I did some tests for for different values of N (number of parallel workers). Here are the results:
N=1: Working fine
N=2: Working fine
N=3: Working fine
N=4: ASCII characters being sent are messed up
N=5: Working, but there are spurious one-bit errors in the computation results.
N=6: Working, but the computation results are totally wrong.
The tests has been done for:

symbiflow-arch-defs SHA: f4ce9e1
Yosys SHA: 87846729 (built locally)
VPR SHA: f725c5ac0 (built locally)

I did also a test in which I used Yosys + Vivado and the design worked perfectly for N from 1 to 8.
I am sharing the design here because in my opinion it may allow to identify potential problems with VPR by gradually increasing design complexity rather than jumping from a simple counter to a SoC.

Waiting for green travis, then good to merge.

Is there any reason this shouldn't live in the top layer tests?

Is there any reason this shouldn't live in the top layer tests?

No, that's valid.  Would be good to test N=1-6 on ice40 too.  Let's move it to /tests then.

So, shall I move it to <root>/tests ?

So, shall I move it to <root>/tests ?

Yep, and then I think this is LGTM.

Still showing a conflict with xc7/tests/CMakeLists.txt, probably just revert it?

Ok, I'll try

CI is failing, https://travis-ci.org/SymbiFlow/symbiflow-arch-defs/builds/511590955?utm_source=github_status&utm_medium=notification

Yep it is failing, however on my local machine it passes the CMake... I'll investigate that.

@mkurc-ant could it be due to https://github.com/SymbiFlow/symbiflow-arch-defs/pull/462?

@mkurc-ant I think this is because we are skipping inclusion of xc7 for CI (i.e. Travis) so it doens't know about basys3 when you include it. May need to update here

xc7 is not used on CI right now because it exceeds the maximum memory of the CI.

xc7 is not used on CI right now because it exceeds the maximum memory of the CI.

Correct. Currently the scalable test is trying to run on xc7 on Travis and we can't do that. The scalable test will have to be skipped on CI for now, similar to the link to picosoc I included.

Ahhhh... I forgot about that basys3 target is not available in CI. So I disabled the design for CI builds as it is done with the PicoSoC.