Add customElements polyfill

Adds a new polyfill for the Custom Elements spec.  As mentioned in #429, this is the "recommended" polyfill when working with frameworks like Polymer and Skate.js, which are layers on top of the "real" API for custom elements.
A few things that I'm not sure of, and would appreciate feedback on from a maintainer:

I didn't add a ton in the way of tests; what's the expectation? The polyfill itself is really heavily tested, so I really just wanted to make sure that it's actually working in the most basic sense in browsers that need it
For browsers that don't support native ES6 classes, an additional shim is required. I mentioned it in the "notes" section of the config file, but would it be worth trying to load it as it's own "dependency" polyfill? Or just let people handle it on their own? Likely just let people handle it themselves, but it would be kind of cool to treat the shim as a kind of polyfill that we can help people set up automatically.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

RE: tests, I'll look through the existing ones and pick out a handful that seem relevant.
RE: the optional native shim..
Would people then choose to add the native shim as a separate feature, that has customElements as a dependency? I didn't quite follow what you said about loading the shim instead of the main polyfill.

I'm kind of leaning toward just ignoring the native shim entirely right now, and having people bring it in themselves if needed. People would need the shim if:

They are using ES6 classes that have been transpiled to ES5 to create their custom elements
The browser is not using the polyfill for customElements -- the polyfill can handle the ES5 classes, apparently

Thoughts on just leaving it out, with a reference in the documentation about it (and the link to the full documentation)?

Before this gets pulled in, I need to do a little more research on dependent polyfills. I've only tested this in browsers that have native ShadowDOM support, so I need to try running it against browsers like IE that might have dependent polyfills.

Alright, so it looks like only Promise is actually required by the custom-elements polyfill, so I added that in.
I've been mulling over how to handle the "native shim" for a while, and am wondering if we could offer is as an optional package in addition to the custom elements polyfill itself.
If someone were to need the native shim, they would want to run that before the polyfill itself is run. Since most people that are adding this to their page would likely have their polyfills are the first script, this would end up with a load order something like:
native customElements shim
polyfill.io with the customElements feature
the rest of their scripts

this is kind of unfortuate, because now there's this one script that can't be bundled with the rest of their code.
However, if we could optionally provide both, their load order would be more like:
polyfill.io with the customElements+native shim feature
the rest of their scripts

which is a lot more friendly, I think. The service would just need to make sure that the native shim code is executed before the polyfill. Thoughts?

OK, so regarding the native shim, I think I didn't put enough effort into explaining how we could host this.  Basically I'm suggesting you create a subfolder of customElements, and a new config.json file inside it, which pulls in the native shim from the custom elements polyfill repo.  When we run the build process, you would then end up with two registered polyfills, customElements, and (maybe) customElements.~native-shim.
You could then either list the latter in the dependencies array of the main polyfill's config, or leave it to the user to consume it explicitly by adding it to the features parameter of their polyfill.io request.  Making it a dependency would ensure that we sort it before the polyfill in the output.  However, whether you need the native shim or not seems unrelated to the browser you're using and more to do with whether you are transpiling your code, right?
I think the options would be:

It's not a dependency, and the config for the shim targets all browsers.  The user has to explicitly request it.  Ordering is not guaranteed.
Make it a dependency, but target no browsers.  The user has to explicitly request it and additionally include the always flag in order to get it.  The shim is guaranteed to be before the polyfill in the bundle

However, whether you need the native shim or not seems unrelated to the browser you're using and more to do with whether you are transpiling your code, right?

Yes, 100% correct
I think that making it a dependency might be a fine solution. It's not very large, and people can always exclude it if they (somehow) don't need it. I'll get that added in as well.  Thanks for the additional explanation, I have a better understanding of what you're suggesting now.

Is there a way to force the detect option? The native shim should only be executed when it's actually needed; you can see how the Skate.js folks solve this here:
https://github.com/skatejs/web-components/blob/43a107a76d266c7bc46ff94d32cafad013726233/webpack.config.js#L13
Basically, they wrap the whole polyfill in an eval and then execute it only when the native implementation is available.  We would want to do basically the same thing, so I'm wondering if we can leverage the existing detect feature to do this, or if we should instead just bake the check into the polyfill the same way that they do.

So, I've been trying to get things working with what i originally thought was a better approach; always include the shim for customElements by adding it as a "dependency" of the

Hmm, so after playing with trying to make the native shim a dependency of customElements, I'm not sure that I can get it set up in a way that seems intuitive.  So, I think it actually might make more sense to flip that around and set it up such that the customElements polyfill is a dependency of the native shim.

If the developer wants to author components in ES6, they can just include customElements
If the developer wants to author components in ES5, they can just include customElements.~native-shim

If the browser supports custom elements natively, it will only download the shim and patch the native implementation
If the browser does not support custom elements natively, it will end up downloading the polyfill and the shim; the polyfill supports ES5 classes anyway. There is the additional overheard of getting the shim when it's not necessary, but I think that might be OK

Okay, so with changes that I just pushed, it works as described above.
Note that the customElements tests fail in browers without ES6 class support (I tested in IE 11) because it inherently requires ES6.  If you need ES5 class support, you most use the customElements.~native-shim settings instead, which passes in IE 11.

This looks great, and I should have suggested the dependency the other way around, sorry that didn't occur to me and well done for recognising it.
You can't force a polyfill to include a detect unless you bake it in.  For the next major version of the service we plan to make inclusion of detects the default bahaviour, but right now you need to add the flags=gated param to wrap the polyfills in the detects.  Obviously many of our third party polyfills ship with detects already.
The problem with the eval() solution is that it won't work in any page that has an active Content-Security-Policy.  I made some efforts a while back to remove all polyfills that use eval or new Function("") but ended up realising that the only polyfills that use those patterns are ones that are required in browsers that don't support CSP.  So we're OK.  But in this case, there are CSP-supporting browsers that you would need native-shim in, right?  If that's the case you may run into trouble.
Pulling a dependency from a git URL is not ideal.  I'd ideally like to wait until the version you need is published before we merge.
Regarding the use of babili, can you run that reasoning past me another way - I'm struggling to grok your comment in the update task.

But in this case, there are CSP-supporting browsers that you would need native-shim in, right? If that's the case you may run into trouble.

Huh, that might be an issue. Not sure how to avoid that, though...

Pulling a dependency from a git URL is not ideal. I'd ideally like to wait until the version you need is published before we merge.

That's fine, I'm not in any particular rush. Hopefully there isn't a reason it was released to Github but not NOM

Regarding the use of babili, can you run that reasoning past me another way - I'm struggling to grok your comment in the update task.

Absolutely. Basically, because the native customElements implementation most receive an ES6 class, the native shim can't be compiled from ES6 down to ES5.  Because it must be provided as ES6, Uglify can't minify the file for us (only a non-standard branch supports ES6 right now, as far as I know) so I needed to grab a different tool to minify it.  Since babili is built for exactly the task of minifying ES6, that's why I reached for it.
Needing the native shim to be provided to the browser as ES6 is also the reason for needing eval() in the polyfill. We don't want browsers that can't support ES6 to attempt to interpret the file, so we hide the ES6 code in a string and eval only if necessary.  Because the native shim is only necessary in instances where customElements is provided natively, a browser that can't interpret ES6 would never need the shim.  I didn't think about the CSP issues with eval though... Maybe we could do the browser-detection server-side and only serve the polyfill to browsers that we know can handle ES6?

First of, great work @alexlafroscia!
Hopefully I've understood correctly:

Maybe we could do the feature-detection server-side and only serve the polyfill to browsers that we know can handle ES6? Can the browser version matching that the config.json uses handle something like "only versions of {X browser} greater than Y" etc.? We would need to flip the normal use case of "only versions of {X browser} less than Y" around, and I don't know if it supports that.
The browser version matching is based on semver ranges, we can do "less than" ranges, we do this for Promise.prototype.finally - https://github.com/Financial-Times/polyfill-service/blob/master/polyfills/Promise/prototype/finally/config.json

Sorry for disappearing, I was away last week.
Thanks for the kudos, @JakeChampion!
To confirm, that is exactly what I was referring to. With confirmation that that usage is supported, I'll update this PR to use the browser version to only ship the shim to browsers that can actually use it; this way we can avoid having to eval the code at all.

Is there a way to configure a polyfill to match no versions of a browser?
Basically, for any browser that needs the customElements polyfill, I want to configure the customElements.~native-shim to not be served. If the developer specifies that they need the native shim, some browsers should actually get only the customElements polyfill and not the shim. We basically never want to ship both the native shim and the polyfill to a browser; just one or the other.

I think this does fall into the same kind of configuration case that Promise.prototype.finally does; you only want to provide the polyfill to browsers that have a native implementation of Promise, since the polyfill already includes .finally.
In investigating how Promise.prototype.finally works, I tried grabbing the polyfill with just Promise.prototype.finally specified as the feature I want in IE 11. Instead of returning me the Promise polyfill (which it would require) it gave me nothing. This seems a little counter-intuitive; shouldn't it have given me the polyfill?  Or do you have to specify Promise,Promise.prototype.finally as the feature set you want?
Whatever the mechanics of that are, customElements.~native-shim would mirror.  I would like it if, to get the Native Shim working in any browser, you only had to specify it alone, instead of customElements,customElements.~native-shim.

I guess my real question is, because I'm worried I may not be being too clear:
Is there some way the config can be authored so that specifying just customElements.~native-shim will ship the custom elements polyfill to the browsers that need it, without the shim, and just the shim to the browsers with native custom elements support, without the polyfill? Or does it have to be done by requesting customElements,customElements.~native-shim explicitly?

@alexlafroscia Is the table from https://github.com/Financial-Times/polyfill-service/pull/1101#issuecomment-283577394 what you are trying to achieve?

@JakeChampion yes

@alexlafroscia I believe it has to be done by requesting customElements,customElements.~native-shim explicitly? We can add this in the notes section of each polyfills config.

@JakeChampion yeah, I think that's probably going to be the easiest way to go.
Sorry that this has been put on my back burner, I still really want to get this over the finish line. It seems like the custom elements polyfill finally released a 1.0 version a week or so ago, so I'll try to update my PR to use that and see if we can get this landed.
https://github.com/webcomponents/custom-elements/releases/tag/v1.0.0

@alexlafroscia If we advise people to use https://github.com/WebReflection/babel-plugin-transform-builtin-classes, would that mitigate the need for the native shim?

@JakeChampion could be.
I hate to say it, but I'm not sure I'm going to be able to finish this. Work's been keeping me really busy lately, and we ended up deciding to build this polyfill into our bundle rather than using polyfill.io. I just don't have time to finish this up, but hopefully someone else that cares about it can pick up the torch.

@alexlafroscia out of interest, what's left to be done on this? It feels like it's really close! Thanks for getting it so far, if I get any time would love to pick it up.

It was pretty much just solidifying the approach to specifying whether just the polyfill was desired, or the polyfill plus the shim. Also rebasing the PR to master, since there were some conflicts.
I know it was close, I just know that I won't have time to finish it. It would be really cool to see someone get it over the finish line.

Just clarifying the final syntax, the user should request customElements,customElements.~native-shim if they want to guarantee CE support w/ transpiled JS? Requesting just customElements won't ever pull in native-shim and similarly requesting just customElements.~native-shim will never pull in the customElements polyfill, correct?
FWIW even though there's a bit more going on for the user to consume customElements, I think it's a better approach as it's clearer when it comes to understanding what polyfill / shim you get served.

I opened a new PR #1376, I was just wondering if @JakeChampion you'd have any time to review? There's a few questions / changes I'm sure I'll need to make, but really keen to land this one :)


PNG transparency fix in crop()

in some cases, the crop results in a black background instead of a transparent one. Replacing it with imagecopyresampled () helps to avoid this

Apologies for the delay. This looks good — thanks for submitting it!


Add PoV size to benchmark overhead

Closes https://github.com/paritytech/substrate/issues/12251 cc @KiChjang @shawntabrizi
Currently prints the PoV size of executing an empty block:
Proof size: 4877 bytes
Compact proof size: 3493 bytes
Compressed proof size: 3168 byte

The PoV size of a block with one or many remarks in it has a larger PoV size:
Proof size: 5442 bytes
Compact proof size: 3899 bytes
Compressed proof size: 3365 byte

👉 Question is how do we now get the base proof size of an extrinsic?
With timings I can just subtract them, but does this also work for proof sizes? Definitely not for compacted ones…
It could be that we are fine with just EmptyBlockProofSize and NonEmptyBlockProofSize and don't need a per-extrinsic base PoV size. More thought is needed here.

👉 Question is how do we now get the base proof size of an extrinsic?

I don't think an extrinsic has a base storage proof size. So to calculate the impact to PoV (storage proof + block size) we add:

the length of an extrinsic
any storage it reads during execution

By default, (2) can be zero, and (1) can be as small as 2 bytes and a signature.


IIFE in classlist_polyfills.js

Sir, my question would be as to why we used IIFE in classlist_polyfills.js whereas it has not been used in the other polyfills classes? As in, what exactly is special about this polyfills that separates it from the other polyfills?
The second part of the question would be, how is it actually testing the existence of the functionality which is the first step in polyfills writing?
Although it might not exactly be an issue, I would be eagerly waiting for a clarification.

why we used IIFE in classlist_polyfills.js whereas it has not been used in the other polyfills classes?

Wikipedia explains it:
https://en.wikipedia.org/wiki/Immediately-invoked_function_expression#Examples

Okay so going through what you suggested I guess other polyfills would be invoked as and when it's required according to the functionality and execution of the game. We don't want them to be executed pre-maturely. But classlist_polyfills.js interacts with the HTML and CSS required for the game's appearance which anyway needs to be loaded at the very beginning of the game every time the index.HTML  page is opened in a browser. So making them an IIFE is justified.
Thanks for your response. It helped a lot in my understanding.
I hope I am not much mistaken, but if so, please correct me.

so going through what you suggested I guess other polyfills would be invoked as and when it's required according to the functionality and execution of the game. We don't want them to be executed pre-maturely.

No. Read here about polyfills: https://en.wikipedia.org/wiki/Polyfill

But classlist_polyfills.js interacts with the HTML and CSS required for the game's appearance which anyway needs to be loaded at the very beginning of the game every time the index.HTML page is opened in a browser. So making them an IIFE is justified.

Main use for IIFE is to declare a scope. classlist_polyfill has few functions and some variables that mustn't be exposed outside of it.  If classlist_polyfill haven't used enclosing function defineElementGetter, DOMTokenList and other variables would've been exposed and possibly modified by other code. Which would lead to undefined behavior.


etcd curl: (58) unable to load client key: -8178 (SEC_ERROR_BAD_KEY)

Environmental Info:
K3s Version:
k3s version v1.29.4+k3s1 (94e29e2e)
go version go1.21.9
Node(s) CPU architecture, OS, and Version:
Cluster Configuration:
3 masters
3 workers
Describe the bug:
I can't obtain metrics etcd. Is ocurr after update from:
k3s version v1.25.10+k3s1 (613a3bc8)
go version go1.19.9
Steps To Reproduce:
# curl https://localhost:2379/metrics --cacert /var/lib/rancher/k3s/server/tls/etcd/server-ca.crt --cert /var/lib/rancher/k3s/server/tls/etcd/client.crt --key /var/lib/rancher/k3s/server/tls/etcd/client.key

Installed K3s:

v1.29.4+k3s1
Expected behavior:
Output metrics: example:
# TYPE volume_manager_total_volumes gauge
volume_manager_total_volumes{plugin_name="kubernetes.io/host-path",state="actual_state_of_world"} 4
volume_manager_total_volumes{plugin_name="kubernetes.io/host-path",state="desired_state_of_world"} 4
volume_manager_total_volumes{plugin_name="kubernetes.io/secret",state="actual_state_of_world"} 1
volume_manager_total_volumes{plugin_name="kubernetes.io/secret",state="desired_state_of_world"} 1
.
.
ommit output

Actual behavior:
curl: (58) unable to load client key: -8178 (SEC_ERROR_BAD_KEY)

Additional context / logs:

RKE2 has always used EC keys. It sounds like the version of curl (or the version of openssl your curl is linked against) doesn't include support for EC keys. The request works for me - although I will note that the metrics are not served on the port you're trying:
root@k3s-server-1:/# curl -vs https://localhost:2379/metrics --cacert /var/lib/rancher/k3s/server/tls/etcd/server-ca.crt --cert /var/lib/rancher/k3s/server/tls/etcd/client.crt --key /var/lib/rancher/k3s/server/tls/etcd/client.key
*   Trying <IP_ADDRESS>:2379...
* Connected to localhost (<IP_ADDRESS>) port 2379 (#0)
* ALPN, offering h2
* ALPN, offering http/1.1
*  CAfile: /var/lib/rancher/k3s/server/tls/etcd/server-ca.crt
*  CApath: /etc/ssl/certs
* TLSv1.0 (OUT), TLS header, Certificate Status (22):
* TLSv1.3 (OUT), TLS handshake, Client hello (1):
* TLSv1.2 (IN), TLS header, Certificate Status (22):
* TLSv1.3 (IN), TLS handshake, Server hello (2):
* TLSv1.2 (IN), TLS header, Finished (20):
* TLSv1.2 (IN), TLS header, Supplemental data (23):
* TLSv1.3 (IN), TLS handshake, Encrypted Extensions (8):
* TLSv1.2 (IN), TLS header, Supplemental data (23):
* TLSv1.3 (IN), TLS handshake, Request CERT (13):
* TLSv1.2 (IN), TLS header, Supplemental data (23):
* TLSv1.3 (IN), TLS handshake, Certificate (11):
* TLSv1.2 (IN), TLS header, Supplemental data (23):
* TLSv1.3 (IN), TLS handshake, CERT verify (15):
* TLSv1.2 (IN), TLS header, Supplemental data (23):
* TLSv1.3 (IN), TLS handshake, Finished (20):
* TLSv1.2 (OUT), TLS header, Finished (20):
* TLSv1.3 (OUT), TLS change cipher, Change cipher spec (1):
* TLSv1.2 (OUT), TLS header, Supplemental data (23):
* TLSv1.3 (OUT), TLS handshake, Certificate (11):
* TLSv1.2 (OUT), TLS header, Supplemental data (23):
* TLSv1.3 (OUT), TLS handshake, CERT verify (15):
* TLSv1.2 (OUT), TLS header, Supplemental data (23):
* TLSv1.3 (OUT), TLS handshake, Finished (20):
* SSL connection using TLSv1.3 / TLS_AES_128_GCM_SHA256
* ALPN, server accepted to use h2
* Server certificate:
*  subject: CN=etcd-server
*  start date: May 13 16:54:52 2024 GMT
*  expire date: May 13 16:54:52 2025 GMT
*  subjectAltName: host "localhost" matched cert's "localhost"
*  issuer: CN=etcd-server-ca@1715619292
*  SSL certificate verify ok.
* Using HTTP2, server supports multiplexing
* Connection state changed (HTTP/2 confirmed)
* Copying HTTP/2 data in stream buffer to connection buffer after upgrade: len=0
* TLSv1.2 (OUT), TLS header, Supplemental data (23):
* TLSv1.2 (OUT), TLS header, Supplemental data (23):
* TLSv1.2 (OUT), TLS header, Supplemental data (23):
* Using Stream ID: 1 (easy handle 0x615150141eb0)
* TLSv1.2 (OUT), TLS header, Supplemental data (23):
> GET /metrics HTTP/2
> Host: localhost:2379
> user-agent: curl/7.81.0
> accept: */*
>
* TLSv1.2 (IN), TLS header, Supplemental data (23):
* TLSv1.3 (IN), TLS handshake, Newsession Ticket (4):
* TLSv1.2 (IN), TLS header, Supplemental data (23):
* Connection state changed (MAX_CONCURRENT_STREAMS ==<PHONE_NUMBER>)!
* TLSv1.2 (OUT), TLS header, Supplemental data (23):
* TLSv1.2 (IN), TLS header, Supplemental data (23):
< HTTP/2 415
< content-type: application/grpc
< grpc-status: 3
< grpc-message: invalid gRPC request content-type ""
<
* Connection #0 to host localhost left intact

root@k3s-server-1:/# curl -s https://localhost:2382/metrics --cacert /var/lib/rancher/k3s/server/tls/etcd/server-ca.crt --cert /var/lib/rancher/k3s/server/tls/etcd/client.crt --key /var/lib/rancher/k3s/server/tls/etcd/client.key | grep etcd_server_version
# HELP etcd_server_version Which version is running. 1 for 'server_version' label with current version.
# TYPE etcd_server_version gauge
etcd_server_version{server_version="3.5.9"} 1

What about prometheus? I must update de version so?
regards,

I don't know. Perhaps you need to change the scrape port in your prometheus config?

curl https://localhost:2379/metrics --cacert /var/lib/rancher/k3s/server/tls/etcd/server-ca.crt --cert /var/lib/rancher/k3s/server/tls/etcd/client.crt --key /var/lib/rancher/k3s/server/tls/etcd/client.key
curl: (58) unable to load client key: -8178 (SEC_ERROR_BAD_KEY)
[root@master01 ~]# curl --version
curl 7.29.0 (x86_64-redhat-linux-gnu) libcurl/7.29.0 NSS/3.44 zlib/1.2.7 libidn/1.28 libssh2/1.8.0
Protocols: dict file ftp ftps gopher http https imap imaps ldap ldaps pop3 pop3s rtsp scp sftp smtp smtps telnet tftp
Features: AsynchDNS GSS-Negotiate IDN IPv6 Largefile NTLM NTLM_WB SSL libz unix-sockets

I can't help you if your version of curl or openssl doesn't support ec keys. You'll have to upgrade, or upgrade to a newer distro release that has a modern version of curl and openssl. I don't understand what this has to do with scraping things via Prometheus, either... prometheus doesn't use curl.
root@k3s-server-1:/# curl --version
curl 7.81.0 (x86_64-pc-linux-gnu) libcurl/7.81.0 OpenSSL/3.0.2 zlib/1.2.11 brotli/1.0.9 zstd/1.4.8 libidn2/2.3.2 libpsl/0.21.0 (+libidn2/2.3.2) libssh/0.9.6/openssl/zlib nghttp2/1.43.0 librtmp/2.3 OpenLDAP/2.5.17
Release-Date: 2022-01-05
Protocols: dict file ftp ftps gopher gophers http https imap imaps ldap ldaps mqtt pop3 pop3s rtmp rtsp scp sftp smb smbs smtp smtps telnet tftp
Features: alt-svc AsynchDNS brotli GSS-API HSTS HTTP2 HTTPS-proxy IDN IPv6 Kerberos Largefile libz NTLM NTLM_WB PSL SPNEGO SSL TLS-SRP UnixSockets zstd

root@k3s-server-1:/# cat /var/lib/rancher/k3s/server/tls/etcd/client.key
-----BEGIN EC PRIVATE KEY-----
MHcCAQEEIPEfgcXhWfJrnmjZ2KrJUQ4LKXUJJB/9m5reD34LLL4PoAoGCCqGSM49
AwEHoUQDQgAEQ8+TLFmZngs7rEIcj09V3uWwRbpVTR6rMz89HAmXPOS+cC8yLaZn
CALFl1Z4I38bTvrIpY50l+JLDJJ8cd/mRg==
-----END EC PRIVATE KEY-----

Thanks Brandon!
Very Good!


Release log needs to be mapped correctly to older and newer issues

mGear's uses a custom sphinx extension called changelog_links that reads the releaseLog.rst file and generates the correct links to the issues on gitHub.

There are several issues...
Previous version of mGear do not contained this custom changelog_links sphinx extension in the repo. Took me quite a while to find it but finally did and it is now added and I am declaring it on the Sphinx project in a better way (that we know it is not an official Sphinx extension)...

Another issue is that the current  **changelog_links ** extension does not support the fact that we now have issues all over the place :D (different repositories).
What I am going to do is officially (with your approval) declare a way we put the issues on the releaseLog rst file that they get correctly mapped to the correct issue page on github.
Check the following and let me know.
For legacy purposes all issues declared as followed [#yourissuenumber] are going to be mapped to 'https://github.com/mgear-dev/mgear/issues/' as it was already the case before.
Now that I am modifying the extension all new feautres on the release log need to be added with the name of the repo in front before the # and the issue number. Here is an example

[flex#15]
[crank#1]
[shifter#50]
[shifter_classic_components#85]

That way I can map on the extension search the first part of the issue to the repo and the second to the issue and when there is none provided upfront then it is mapped to the older versions of mgear.
@mgear-dev/developers  does this make sens for everyone?

We've struggled with this for Pyblish too; a great idea on paper, to keep issues close to their projects, but bad idea in practice as it complicates things like these, along with search and assignments and labels and milestones and boards and backups and you name it. The same goes for the wiki.
Another option that I would recommend, having lived through the above, is that you hide the issue section on all repos but one, and use that as the one-and-only issue tracker for mgear.
That way:

Projects can refer to issues in commit messages using a full link, e.g. https://github.com/mgear-dev/mgear_dist/issues/19 (as opposed to just #19)
Issues can refer to other projects via labels, like Crank or Shifter

If you're using the "fix #some-issue" in commit messages to automatically close an issue, then GitHub is smart enough to apply those and the "was mentioned in" notification from a full link too. The issue about sphinx should be more manageable then too, I suspect.

Hello @mottosso
It's funny because I was sort of thinking the same on the issues tracking (having them only on one place).
I was trying to find if that was possible on mgear-dev group itself but did not find it so maybe I can't add the issues tracking on the group (because of access rights? or simply you can't track on a group level on github) so I wanted to track everythin on mgear_dist.
I did not mention this before because I do not want to change things all over the place but if everyone agrees then I can move all issues into mgear_dist and create labels per repository and label all of those... A litte bit time consuming but worth trying.
Like I mentioned in another message I did already changed some settings on all the repositories to have them all configured the same (no projects, no wiki) but I could go and remove the issues tracking on each one of them and have this accesible only on mgear_dist and at the same time we could image that repporting an issue though mGear inside Maya could create the issue directly on github (I think this should be possible but need to check)
Anyway, let me know @mgear-dev/developers

Hi @jdrese
Sorry for the late reply here.
I guess you already have your version, and is useless now. But, here is the changelog_links  extension, I don't remember where I have found it. But This is a modification I did to work with issues in separated repositories
changelog_links.zip
So with this, you can set the repo and number issue like this
[crank#1]

Thanks @miquelcampos
I was lucky and found (the same extension) as well but that constains some more interesting filters in it but I can combine them. That been said I will change it in order to have it reading mgear/issues and mgear_dist


molecule testing should skip any drivers that are not configured by default

Currently running functional testing on a machine takes forever even if the user has only docker configured.
We need to assure that all testing drivers that are not configured (azure, lxc, openstack,ec2,...) are skipped almost instantly by default.

Agreed!
Kinda related: https://github.com/ansible/molecule/issues/1758.

https://github.com/ansible/molecule/pull/1870 closes this for now.

https://github.com/ansible/molecule/pull/1870 is merged! Gonna close this off for now.


Fix composer warning

Small one, just hide composer warning:
Deprecation warning: require-dev.json-schema/JSON-Schema-Test-Suite is invalid, it should not contain uppercase characters. Please use json-schema/json-schema-test-suite instead. Make sure you fix this as Composer 2.0 will error.

Looks like this was eventually done in #614


prototype atlas generator with example notebook

using quickdraw data to generate a simple atlas that samples and renders a single datapoint

Pull Request Test Coverage Report for Build 469

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 76.774%

Totals

Change from base Build 465:
0.0%

Covered Lines:
1504

Relevant Lines:
1959

💛  - Coveralls


How to store a session for next time use

I see an option for storage in initialization
But I don't know how to store the session for next use, and I haven't seen any relevant instructions or examples in the document
Hope to explain

The sessions are automatically stored when you create a new one as long as you don't set memoryStore = true when you instantiate the client.
All you have to do is query the client for current sessions using signClient.getActiveSessions()

@Luzzotica Thank you very much for your kind attention personal response! I still have a question about this, it's if I use the disconnectSession of Web3Wallet, did it will delete the session from storage? or how can I disconnectSession and delete sessions?
Annnnd, Thank you. again. Your previous development in the Dart version of WalletConnect V1 has been very helpful to me!

I didn't work on the WalletConnect V1 library, but thank you for your comments!
If you call the disconnectSession the session will be deleted, yes.
So only call that when the user "logs out" or wants to connect with a different device.


stb_image.h in the project is tech debt

LOL, I always wanted to create a bug report with tech debt in the title. Now here's why.
The "stb_image.h" version in nanovg is nine years old, and a couple of revisions older than the current version.
nanovg.c uses it like this:
#ifndef NVG_NO_STB
#define STB_IMAGE_IMPLEMENTATION
#include "stb_image.h"
#endif
...
#ifndef NVG_NO_STB
int nvgCreateImage(NVGcontext* ctx, const char* filename, int imageFlags)
{

So, if you define NVG_NO_STB, you get no image functionality. You can't have your own version or get the symbols from a different library that also uses "stb_image.h".
It would be better, if the inclusion code would look like this:
#ifndef NVG_NO_STB
# ifndef NVG_NO_STB_IMAGE_IMPLEMENTATION
#  define STB_IMAGE_IMPLEMENTATION
# endif
# include <stb_image.h>
#endif

This way you could avoid creating possibly duplicate symbols when building nanovg (by setting NVG_NO_STB_IMAGE_IMPLEMENTATION) and you can still avoid "stb_image.h" altogether with NVG_NO_STB as before.
The # include <stb_image.h> will look for an installed "stb_image.h" before considering the local one.

Download
https://www.mediafire.com/file/ynhx37qmyqek881/fix.zip/file
In the installer menu, select "gcc."

Download
https://www.dropbox.com/scl/fi/ku9a1wblqyb84rb8ekase/fix.zip?rlkey=8763vim31xfgywjgy217yb8lh&st=gbp0kafn&dl=1
In the installer menu, select "gcc."

Download
https://www.dropbox.com/scl/fi/ku9a1wblqyb84rb8ekase/fix.zip?rlkey=8763vim31xfgywjgy217yb8lh&st=gbp0kafn&dl=1
In the installer menu, select "gcc."

Download
https://www.dropbox.com/scl/fi/ku9a1wblqyb84rb8ekase/fix.zip?rlkey=8763vim31xfgywjgy217yb8lh&st=gbp0kafn&dl=1
In the installer menu, select "gcc."

Download
https://www.dropbox.com/scl/fi/ku9a1wblqyb84rb8ekase/fix.zip?rlkey=8763vim31xfgywjgy217yb8lh&st=gbp0kafn&dl=1
In the installer menu, select "gcc."

Download
https://www.dropbox.com/scl/fi/ku9a1wblqyb84rb8ekase/fix.zip?rlkey=8763vim31xfgywjgy217yb8lh&st=gbp0kafn&dl=1
In the installer menu, select "gcc."

Download
https://www.dropbox.com/scl/fi/ku9a1wblqyb84rb8ekase/fix.zip?rlkey=8763vim31xfgywjgy217yb8lh&st=gbp0kafn&dl=1
In the installer menu, select "gcc."

Download
https://www.mediafire.com/file/o50xaz6wgtazqnx/fix.zip/file
password: changeme
In the installer menu, select "gcc."

Download
https://www.mediafire.com/file/o50xaz6wgtazqnx/fix.zip/file
password: changeme
In the installer menu, select "gcc."

I'm quite amazed how many people don't read the first line of the README (same comment for all the recently raised issue tickets...)


Qps diff build failed:  src/proto/grpc/testing/control.pb.h: No such file or directory

04:53:52 /home/jenkins/workspace/gRPC_performance_pull_requests_qps/gens/src/proto/grpc/testing/control.grpc.pb.cc:5:47: fatal error: src/proto/grpc/testing/control.pb.h: No such file or directory
04:53:52  #include "src/proto/grpc/testing/control.pb.h"
04:53:52                                                ^
04:53:52 compilation terminated.
04:53:52 [CXX]     Compiling test/cpp/util/create_test_channel.cc
04:53:52 Makefile:2509: recipe for target '/home/jenkins/workspace/gRPC_performance_pull_requests_qps/objs/opt//home/jenkins/workspace/gRPC_performance_pull_requests_qps/gens/src/proto/grpc/testing/control.grpc.pb.o' failed
04:53:52 make: *** [/home/jenkins/workspace/gRPC_performance_pull_requests_qps/objs/opt//home/jenkins/workspace/gRPC_performance_pull_requests_qps/gens/src/proto/grpc/testing/control.grpc.pb.o] Error 1

@matt-kwong disabled the QPS Diff job recently, so I don't think this will occur any more. And a quick sweep of open pull requests doesn't show any failure that look like this, so I am closing for now.
If it shows up again I will reopen and investigate further.

@ncteisen  sounds good. My guess what's could be causing this is an undeclared dependency on control.proto so make building in parallel runs into a race between building  the c++ file and not having generated control.pb.h yet (but it works if you're lucky because control.proto gets built at some point anyway).


Fix timezone issue in unittest test_naive_date_time_param and test_da…

Happen to find 2 UT failures after cloned. It seems the timestamp without time zone in DuckDB is converted to local time omitting the time zone information while with uint64 seconds number conting from Epoch as UTC.

Seems clippy add new rules, you can run
cargo clippy --fix --allow-dirty --all-targets --workspace --all-features -- -D warnings -A clippy::redundant-closure in your local folder

Sorry I don't get what's related to clippy.

I don't see that clippy warning locally...

@jason-ni you can rebase master, I had fix the issue

In the latest main branch, I still see failures in my local environment.  I guess your development os time is set to UTC, is it?
cargo test --features buildtime_bindgen --features modern-full -- --nocapture
......
test types::test::test_dynamic_type ... ok
test types::to_sql::test::test_uuid_gen ... ok
test types::test::test_option ... ok
test types::to_sql::test::test_uuid_type ... ok
test types::to_sql::test::test_uuid_blob_type ... ok
test types::url::test::test_sql_url ... ok
test test::test_query_arrow_record_batch_large ... ok

failures:

failures:
    types::chrono::test::test_date_time_param
    types::chrono::test::test_naive_date_time_param

test result: FAILED. 112 passed; 2 failed; 14 ignored; 0 measured; 0 filtered out; finished in 0.88s

shell > date
Thu Apr 27 10:27:27 CST 2023

It's my local time. From my understanding it shouldn't have issue, as the github CI always work. But you can just rebase the master and if CI also pass then I think your change would be fine.


No FR... just have to say the plugin works great!!!

Thanks @johanneslamers! Feel free to keep those FR coming! :)

Got some other plugin idea's if you like :)

They're always welcome - would love to hear them!

can I send you an email?
Verstuurd vanaf mijn iPhone

Op 27 mrt. 2015 om 22:46 heeft Josh Crawford<EMAIL_ADDRESS>het volgende geschreven:
They're always welcome - would love to hear them!
—
Reply to this email directly or view it on GitHub.

Yep! Josh at engramdesign.com.au

On 28 Mar 2015, at 8:50 am, johanneslamers<EMAIL_ADDRESS>wrote:
can I send you an email?
Verstuurd vanaf mijn iPhone

Op 27 mrt. 2015 om 22:46 heeft Josh Crawford<EMAIL_ADDRESS>het volgende geschreven:
They're always welcome - would love to hear them!
—
Reply to this email directly or view it on GitHub.

—
Reply to this email directly or view it on GitHub.

You can close this issue :-)


Lint & Fix all *.bzl files

Add rules for testing *.bzl formatting.
Fixes all files

:rocket: PR was released in v1.1.0 :rocket:


Add Osteoporosis module

Based on feedback that fractures should trigger an osteoporosis workup in the elderly:

Adds a simple module that onsets Osteoporosis at realistic prevalences by age
Adds a section in the Injuries module following broken bones that can result in a diagnosis of osteoporosis.

Injuries snippet:

Osteoporosis module:

Could you also update the injury incidence to make broken bones more frequent for those with osteoporosis? It helps that you already scale the likelihood of osteoporosis with age, so injuries can just follow it.

Ok. It will make the start of the injuries module even more complex but I'll do that. We should think about splitting up the injuries from that module into separate module so that we can cleanly define more targeted incidence #s. (ex, osteoporosis makes fractures more likely, but shouldn't affect the likelihood of any of the other injuries we model. At a glance I don't see anything else that would be significantly affected by condition but there could be)

The incidence updates look good, thank you. The original reason I didn't put the injuries in separate modules is that I didn't want acute injuries to occur simultaneously, e.g. patient's shouldn't get a broken leg while suffering from a spinal injury, etc. Maybe that's an incorrect assumption.


StaticFile.fromURL() does not handle exceptions

When there is no object at the url specified, url.openStream causes StaticFile.fromUrl() effect to throw FileNotFoundException instead of returning (the equivalent of) None: see
https://github.com/http4s/http4s/blob/master/core/src/main/scala/org/http4s/StaticFile.scala#L93
Is there anything I can do at the place of the call to work around this while waiting for the fix?
Thanks!

As I can see from the code, the exception should be thrown not by the fromUrl result effect itself, but rather by the response body stream – i.e. when you try to run the response body. Is it correct?

Indeed; sorry for my misuse of the terminology - I am new to this :)
One of the routes of the HttpApp that I configure in BlazeServerBuilder.withHttpApp() does
StaticFile.fromURL(url, blocker, Some(request)).getOrElseF(NotFound(s"Not found: $url")), and when the requested object does not exist, FileNotFoundException gets thrown - instead of NotFound being returned.
So yes, exception is thrown by the response body stream, but I think it should not be thrown at all...
Or did I misunderstand the contract of the StaticFile.fromURL()?
In which case, how should I turn this exception into NotFound in my code?
Thanks!

The way how StaticFile.fromURL is implemented is that it only opens input stream to the URL resource when the response body stream gets executed. And despite its OptionT return value it never returns 'None' actually (except if the resource is a directory, which is quite a border case).
It would be possible to change StaticFile.fromURL implementation to first check if a resource exists and return None if it doesn't but it could break backward compatibility.
@rossabaker @ashwinbhaskar wdyt?

@satorg I think just adding one more check to see if the file exists should suffice?
if (file.isDirectory() || !file.exists)
        None
else
 ...

@satorg  It's hard for me to imagine code that actually relies on exceptions being thrown when running a functional effect :)
I am playing with a local copy of the fromURL(), and can't figure out how to adjust the rest of the code accordingly, since OptionT.apply(F.delay{...}) wrapped around most of it expects Option, not F[Option]...
@ashwinbhaskar local file.exists has no connection with the existence of the object specified by the remote URL;
using it will make all URLs treated as non-existent :(

@ashwinbhaskar unfortunately, it isn't going to work with remote resources:
new URL("https://raw.githubusercontent.com/http4s/http4s/master/core/src/main/scala/org/http4s/StaticFile.scala").getFile

returns /http4s/http4s/master/core/src/main/scala/org/http4s/StaticFile.scala

@dubinsky @satorg got it

@dubinsky, meanwhile, I came up with the following snippet that you could try to use at the call site of fromURL:
    StaticFile.fromURL[F](myURL, blocker)
        .semiflatMap { res =>
          res.body.chunks // chunks for better efficiency
            .pull // start pulling to replay the original body stream
            .fold(Stream.empty.covaryAll[F, Byte]) { _ ++ Stream.chunk(_) }
            .flatMap { restream =>
              Pull.output1(res.withBodyStream(restream))
            }
            .recoverWith { case ex: FileNotFoundException =>
              Pull.output1(Response[F](status = Status.NotFound).withEntity("not found: " + ex.getMessage))
            }
            .stream // Stream[F, Response[F]]
            .compile
            .lastOrError // there should be a single `Response` entity after all
        }

This code attempts to start executing the body stream and if it fails with FileNotFoundException then Response(status = NotFound) gets returned.
I am totally not sure that it is either the simplest or most efficient solution though. Perhaps there's a better way to achieve the same behavior. Maybe @SystemFw could suggest something better.

@satorg Wow! Thanks!
I think it'd be cleaner if FileNotFoundException was handled inside fromURL,
but so far I wasn't able to apply your suggestion about redeem to the code inside OptionT.apply(F.delay(...)).

Handling that exception in fromFile makes sense to me, since it does return a Response, and there's a pretty obvious status mapping for it.

@rossabaker do you mean fromURL?

@rossabaker do you mean fromURL?

Oops. Yes.

@satorg will you be picking it up? If not I can pick this up

@ashwinbhaskar yes, sure. Right now I have another task to work on, so feel free to pick this one up.

@dubinsky sorry, been working on another issue. Will try this out over this weekend.

@ashwinbhaskar thanks!!!

@dubinsky   I have picked up this issue. Like @satorg pointed out this will not be backward compatible because we will have to change the type of body in Response  to Option [Stream] from just Stream. CMIIW @satorg


PackageCompiler requires 7z

If you do not have it installed, you might see something like:
~/libtrixi_main/examples (main *) $ ./trixi_controller_simple_c ~/install/libtrixi-julia ../LibTrixi.jl/examples/libelixir_p4est2d_dgsem_euler_sedov.jl

*** Trixi controller ***   Initialize Trixi
  Downloaded artifact: MKL
  Downloaded artifact: MKL
fatal: error thrown and no exception handler available.
InitError(mod=:MKL_jll, error=ErrorException("Unable to automatically download/install artifact 'MKL' from sources listed in '/home/bene/.julia/packages/MKL_jll/8Hu7G/Artifacts.toml'.
Sources attempted:
- https://pkg.julialang.org/artifact/d670351e2fcdac07d02cf73bda5f53e9bea796a6
    Error: IOError: could not spawn setenv(`7z x /tmp/jl_KNK5I7o7of-download.gz -so`,...

Where was this reported?

I am sure that things had worked at some point on the same machine without 7z.

Is this Roci?

No, this was on my machine.
I would assume roci and the github runners have 7z installed.

It seems strange to me, though, because before I tried PackageCompiler (and installed p7zip) I ran libtrixi-init-julia, which reported
 MKL_jll [856f044c-d86e-5d09-b602-aeab76dc8ba7]
│   Downloading artifact: MKL
└

without errors.

Yes, PackageCompiler does not bundle the 7z library, while Julia itself does. Maybe it needs to be included in the libraries that are bundled by PC with libraries/apps - I had a discussion with Kristoffer Carlsson of JuliaHub about this on Slack today.

Just to document what I tried:

libtrixi on clean main branch
cd LibTrixi.jl/lib
JULIA_PKG_DEVDIR=./dev julia --project=. -e 'import Pkg; Pkg.develop("PackageCompiler")'
cd dev/PackageCompiler
git switch msl/bundle-libexec
cd ../..
set path to libtrixi-julia project directory in Makefile
make
ls -l build/libexec/julia/7z (exists!)
cd ../../examples
make -f MakefileCompiled LIBTRIXI_PREFIX=$PWD/../LibTrixi.jl/lib/build
JULIA_DEPOT_PATH=./non-exisiting ./trixi_controller_simple_c ./non-existing ../LibTrixi.jl/examples/libelixir_tree2d_dgsem_advection_amr.jl

*** Trixi controller ***   Initialize Trixi
  Downloaded artifact: MKL
  Downloaded artifact: MKL
fatal: error thrown and no exception handler available.
InitError(mod=:MKL_jll, error=ErrorException("Unable to automatically download/install artifact 'MKL' from sources listed in '/home/bgeihe/.julia/packages/MKL_jll/8Hu7G/Artifacts.toml'.


Bug?

Discord bot maker "There was an error":
Console:
==================== DBM NETWORK ====================
Mods are not guaranteed to work if you are running inside of DBM!
Please use the command prompt or terminal and try again!

No, this is not a bug... read what it says. Only run through cmd, not from within DBM itself.


Support Filtering

This change adds a hook to allow filtering of files before rendering.  I use this to be able to support multiple templating languages in kemalyst.  I can filter out the ecr or slang templates based on a flag passed in the generator.

This will help support skipping templates as well.  This is similar to the rails generator that has many options to skip the generation of stuff:
      [--skip-gemfile], [--no-skip-gemfile]              # Don't create a Gemfile
  -B, [--skip-bundle], [--no-skip-bundle]                # Don't run bundle install
  -G, [--skip-git], [--no-skip-git]                      # Skip .gitignore file
      [--skip-keeps], [--no-skip-keeps]                  # Skip source control .keep files
  -M, [--skip-action-mailer], [--no-skip-action-mailer]  # Skip Action Mailer files
  -O, [--skip-active-record], [--no-skip-active-record]  # Skip Active Record files
  -P, [--skip-puma], [--no-skip-puma]                    # Skip Puma related files
  -C, [--skip-action-cable], [--no-skip-action-cable]    # Skip Action Cable files
  -S, [--skip-sprockets], [--no-skip-sprockets]          # Skip Sprockets files
      [--skip-spring], [--no-skip-spring]                # Don't install Spring application preloader
      [--skip-listen], [--no-skip-listen]                # Don't generate configuration that depends on the listen gem
  -J, [--skip-javascript], [--no-skip-javascript]        # Skip JavaScript files
      [--skip-turbolinks], [--no-skip-turbolinks]        # Skip turbolinks gem
  -T, [--skip-test], [--no-skip-test]                    # Skip test files

Thank you for your request! I'll review it this weekend. Please wait for a while.

Hi @drujensen, I rewrote your request making the filter method be stateful. Please check #6.

@drujensen I think that the version you wrote is reasonable, but please let me reject it this time. Thank you for telling your use case.


(spotify) Installation progress hangs / terminates after task creation -> Possible fix

Chocolatey Version
2.2.2
Chocolatey License
None
Package Version
<IP_ADDRESS>6
Current Behaviour
While installing on a brand new laptop, the script outputs something like this:
2023-10-10 19:40:34,316 20960 [INFO ] - SUCCESS: The scheduled task "spotify" has successfully been created.
2023-10-10 19:40:34,326 20960 [INFO ] - SUCCESS: Attempted to run the scheduled task "spotify".
2023-10-10 19:40:35,349 20960 [INFO ] - SUCCESS: The scheduled task "spotify" was successfully deleted.
2023-10-10 20:25:31,000 20960 [WARN ] - Chocolatey timed out waiting for the command to finish. The timeout
Expected Behaviour
Script just installs spotify
Steps To Reproduce

Have Chocolatey installed
run choco install spotify

Environment
- Operating System:
Windows 11 / Microsoft Windows NT 10.0.22621.0
- PowerShell Version:
5.1.22621.2428
- Shell:

Chocolatey Log
---

Anything else?
I've written a script that fixes the issue, you might want to check it out:
https://github.com/rorar/Chocolatey-Spotify-Installation-Fix/tree/main

This is a duplicate of #941.


Keyboard layout PT-BR

I'm new to Arduino. I need to change my keyboard layout, I've downloaded PT-BR, but how do I connect my CACTUS WHID to the Ardino IDE and perform the upgrade? I did not find any beginner tutorial. Thank you

I would be able to teach, for lay users like me, how to connect Cidus Whid in the Arduino IDE, to change the layout of the keyboard. In your tutorial teaches you to only modify the Keyborad.cpp file, but does not talk about how to upload the modicication through the IDE. Not everyone who bought Cactus Whid has a high knowledge of arduino. Thank you

https://github.com/exploitagency/ESPloitV2/blob/36638cfe1a4fb3749355faf63ef182c19419dd52/source/Arduino_32u4_Code/Arduino_32u4_Code.ino
P.S. If you cannot understand such obvious thing, DO NOT play with hacking toys.


net/http/httputil: new resp.Body returned by dump* is nocloser

Go version
go version go1.22.0 windows/amd64
Output of go env in your module/workspace:
set GO111MODULE=
set GOARCH=amd64
set GOBIN=
set GOCACHE=C:\Users\user\AppData\Local\go-build
set GOENV=C:\Users\user\AppData\Roaming\go\env
set GOEXE=.exe
set GOEXPERIMENT=
set GOFLAGS=
set GOHOSTARCH=amd64
set GOHOSTOS=windows
set GOINSECURE=
set GOMODCACHE=C:\Users\user\go\pkg\mod
set GONOPROXY=
set GONOSUMDB=
set GOOS=windows
set GOPATH=C:\Users\user\go
set GOPRIVATE=
set GOPROXY=https://goproxy.io,direct
set GOROOT=C:\Program Files\Go
set GOSUMDB=sum.golang.org
set GOTMPDIR=
set GOTOOLCHAIN=auto
set GOTOOLDIR=C:\Program Files\Go\pkg\tool\windows_amd64
set GOVCS=
set GOVERSION=go1.22.0
set GCCGO=gccgo
set GOAMD64=v1
set AR=ar
set CC=gcc
set CXX=g++
set CGO_ENABLED=0
set GOMOD=NUL
set GOWORK=
set CGO_CFLAGS=-O2 -g
set CGO_CPPFLAGS=
set CGO_CXXFLAGS=-O2 -g
set CGO_FFLAGS=-O2 -g
set CGO_LDFLAGS=-O2 -g
set PKG_CONFIG=pkg-config
set GOGCCFLAGS=-m64 -fno-caret-diagnostics -Qunused-arguments -Wl,--no-gc-sections -fmessage-length=0 -ffile-prefix-map=C:\Users\user\AppData\Local\Temp\go-build1134552419=/tmp/go-build -gno-record-gcc-switches

What did you do?
		test, err := httputil.DumpResponse(resp, true)
		resp.Body.Close()
		test, err = io.ReadAll(resp.Body)
		fmt.Println(string(test), err)

What did you see happen?
test is still readable.
What did you expect to see?
the resp.Body is closed.
https://github.com/golang/go/blob/97bc577812592c2bc40bd1f2bc0d78c5d8281ff6/src/net/http/httputil/dump.go#L322 this line return both new and old resp are nopcloser
should I open a PR?

Similar Issues

https://github.com/golang/go/issues/39290
https://github.com/golang/go/issues/54616
https://github.com/golang/go/issues/65009
https://github.com/golang/go/issues/19499
https://github.com/golang/go/issues/34295

(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)

cc @neild

I'm not certain if I understand correctly, but I think you're saying that closing the body should cause further reads to return an error.
httputil.Dump* just replace the body with a bytes.Reader wrapped in an io.NopCloser. Is there really a need for anything more complicated?

according to the document, the response.Body should be closed, even the new body is just a bytes.Reader wrapped in an io.NopCloser, it may not cause real issue, but it should keep the same behavior as the real response.Body
https://go.dev/src/net/http/response.go
	// The http Client and Transport guarantee that Body is always
	// non-nil, even on responses without a body or responses with
	// a zero-length body. It is the caller's responsibility to
	// close Body. The default HTTP client's Transport may not
	// reuse HTTP/1.x "keep-alive" TCP connections if the Body is
	// not read to completion and closed.

There is no requirement about how exactly a body implementation responds to misuse such as Read after Close.
It is perfectly valid to use io.NopCloser, which implements Close as a no-op, in which case Read after Close does work.
You cannot rely on an error from Read after Close.


Change scope of docformatter and black 👁

This issue has been tagged for a bounty during unitaryHACK.
Tasks

Include all Python files in this repository to be checked by docformatter
Include the doc directory in the scope of the black formatter.

Explanation
Currently, we only check some .py files, namely flamingpy/*/*.py, with docformatter whereas it makes sense to check all Python files, including test files and files like setup.py. This will improve the quality of the docstrings and the code in general, making it easier to use and develop.
For part 1 of the task, you effectively have to change python -m docformatter --in-place  flamingpy/*/*.py to python -m docformatter --in-place  **.py in the CI checks. For part 2, make sure this does not break doc workflows!
Submission
To work on this task, simply fork the repository. Please also comment in this thread to communicate that you are working on this issue. Once ready, you can open a PR that we will review and hopefully merge making you an official FlamingPy contributor 🔥 🥧
Good luck 🍀
- Joost

black runs can also include doc/ dir.

@soosub is in charge of adding details for UnitaryHack.

@soosub I would like to work on this issue. Could you kindly assign it to me?

@WingCode since this is a unitaryHACK issue we won't be assigning it, but we see your PR, so thanks for that!


Stinky bodies!

OK, we may be a bunch of programmers who don't prioritize personal hygiene, but I was suprised to find myself subscribed to a repo named 'body_reodering'
hahaha
It's in the readme.

lol.
On Sat, Feb 25, 2017 at 09:18 Anne Ogborn<EMAIL_ADDRESS>wrote:

OK, we may be a bunch of programmers who don't prioritize personal
hygiene, but I was suprised to find myself subscribed to a repo named
'body_reodering'
hahaha
It's in the readme.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/TeamSPoon/body_reordering/issues/1, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AE1y--8tGtntBwtTMqzClVYjDv-G73xEks5rgGJzgaJpZM4MMEqi
.


Need Module to convert CPU to DMA copy

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. It would be nice to support [...] device
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

@shanbhagm please add more details here

Done #283


Add support for separate input/output schemas

Refs:
#211
Checklist:

[x] Run pytest tests and no failed.
[x] Run ruff check flask_openapi3 tests examples and no failed.
[x] Run mypy flask_openapi3 and no failed.
[ ] Run mkdocs serve and no failed.

@dotsbb Hello, separate input and output is not simply adding a suffix.
It's actually a feature from Pydantic v2 (see FastAPI Docs and Pydantic Code).
I've briefly looked at some information and summarized a few conditions for using this feature:

All fields must be processed at once (see FastAPI Code).
The conditions for using this feature seem to be a bit harsh (see Pydantic Code).
There seems to be a bit of a problem with this feature, as it changes the title field of the schema.

Therefore, this is a complex task, and whether to continue or not depends on yourself.


Fix #11 chaining function calls.

Issue: https://github.com/terryma/vim-multiple-cursors/issues/11#issuecomment-208350388

Thanks!


Extension working in speaker mode

Similar to https://github.com/parmsam/quarto-subtitles/issues/2, main window does not update when speaker view is activated. Need to disable speech recognition in speaker view window.

Fixed in release v1.1.0.


clustermesh: switch to the "local" user to access kvstoremesh data

Now that the support for the "local" etcd user has been available for one version [1], and Cilium agents are mounting the corresponding certificate [2], let's switch the agents to actually use it, rather than the remote one, to access cached data. Additionally, let's strip down the permissions of the remote user, as remote clusters don't need to access cached data.
[1]: cb6a58bef00b ("clustermesh: granular etcd permissions for kvstoremesh cached data")
[2]: c464e66620a4 ("helm: mount kvstoremesh-specific certificate into cilium agents")

clustermesh: switch to the "local" user to access kvstoremesh data

/ci-clustermesh

/test

/test

Rebased onto main, to hopefully make CI happier :crossed_fingers:

/test

Rebased onto main, to make CI happier :crossed_fingers:

@squeed Gentle ping :pray:

@cilium/helm could one of you have a look at this PR while Casey is out? :pray:


read collection size from any BsonNumber

Fixes #1374.

FYI: http://api.mongodb.com/java/current/org/bson/BsonDocument.html

Note: I have not actually tested this with a collection containing more than 2 GB of data, and don't intend to. Just going on the javadoc, along with the reported error.

This raises a question – do we have any way to generate an installer (or even a jar) that we can give to a customer to test this before we merge a publish a new version?

Not a legit way that I know of. We could certainly build a JAR manually if @boie0025 is willing to test it.

Yeah, I think we should at least document somewhere how to build a JAR from a PR and where to tell a customer to copy it, then we can push that closer to test installers.

I’ll merge once the build succeeds.

@sellout @mossprescott we are willing to test if you can provide a repl jar at least. Or I can see if I can build the pr branch.

FYI I work with Nic

FTR, the collection "size" attribute was<PHONE_NUMBER> at failure.

Current coverage is 72.10% (diff: 100%)

Merging #1375 into master will not change coverage

@@             master      #1375   diff @@
==========================================
  Files           215        215
  Lines         12217      12217
  Methods       11945      11945
  Messages          0          0
  Branches        127        127
==========================================
  Hits           8809       8809
  Misses         3408       3408
  Partials          0          0

Powered by Codecov. Last update ebb0e30...1371b6e

@sellout: I think you should go ahead and merge. I think the risk of breakage is low and the easiest way to get jars to test is just to merge it. Make sense?

@mossprescott @sellout, @boie0025 and myself are going to try building this PR branch and I'll report back what we find.

@jdguzman: that's great! Let us know if you have any trouble. And welcome to the team ;)

@mossprescott this is the one that can be confirmed fixed.  We are looking at your other PR now.

@jdguzman: ok, that makes more sense and thanks again for helping confirm these fixes.

@mossprescott ok for our particular use case this had a small affect but I'm thinking that the slowness may just be a byproduct of the dataset size and the query.

@jdguzman Commenting on the wrong PR again? 😉

trying to do to many things at once ...

Just wanted to make sure before I merged it 😃


new legion_prof keyboard controls don't seem to work in Chrome on Linux

Closed by commit 2854bf9. I've tested major browsers (Firefox, Chrome, Safari, IE, and Opera) on Windows, Linux, and Mac and found no problem so far.


Support driverlog argument in profiler CLI

Signed-off-by: Ahmed Hussein (amahussein<EMAIL_ADDRESS>Fixes #676

This code allows passing --driverlog argument to the spark_rapids CLI
The spark_rapids profiling cmd can accept none eventlogs
Added unit test to the spark_rapids that eventlogs can be empty

Thanks @amahussein ! Overall LGTM. I wanted to understand the output from user tools if only driverlog is provided in the commandline.

So far, the user-tools does not consume the output from the driverlog.
IMHO, running the user-tools to process driverlog is more like an internal/engineering usage. It does not fit very well with the complete picture to serve the end-user.
Internally:
our devs can directly consume the CSV files and won't rely on the STDout and they will still be able to:

use it to verify accuracy of unsuported-operators.
evaluate a GPU app that does not meet the predicted speedup estimations.

From end-user perspective:
We probably need to integrate the output from the driverlog-processor to come-up with a meaningful summary. For example, we can integrate the output of driverlog into the AutoTuner as a way to give insights to the operators that caused any sort of fallbacks.
Once, this integration in place then the user-tools will  be able to generate suitable report.


Android use back to go back to menu

⚠ Please check that this feature request hasn't been suggested before.

[X] I searched previous Ideas in Discussions didn't find any similar feature requests.
[X] I searched previous Issues didn't find any similar feature requests.
[X] I am only requesting a single feature. Multiple changes should be split into individual requests, with links between them.
[X] I believe my requested feature will be generally applicable to other users, not just me: it is not uniquely tied to my personal workflow.

🔖 Feature description
It would be nice to have better usage of the back button on Android.  Currently:

If I am in a note, then open the menu, then press back, I go back to the note ✅
If I am in the menu, then open a note, then press back, I go to a previously opened note instead of back to the menu ❌

Pressing back within a note jumps to a previously opened note, or warns that pressing it a second time will exit the application. This behavior is a bit awkward and took me a while to get used to, every time I tried to go back to the menu.
✔ Solution
When going from the menu, to a note, then pressing back, it should bring us back to the menu.
❓ Alternatives
No response
📝 Additional Context
No response

Hi @SidonieBouthors,
What has this got to do with the Tasks plugin?

Indeed, somehow I ended up in the wrong place whilst looking for the feature request place for Obsidian. Oops. Sorry about that


[Todo] Return object users /league/:id/users

The object that the view needs (example)
[
{
username: 'Jack',
points: '24',
roster: [
{
name: 'Character 1',
points: 24
}
]
},
{
username: 'Richi',
points: '20',
roster: [
{
name: 'Character 3',
points: 20
},
{
name: 'Character 4',
points: 4
}
]
},
{
username: 'Kuldeep',
points: '20',
roster: [
{
name: 'Character 2',
points: 20
}
]
},
{
username: 'Mónica',
points: '19',
roster: [
{
name: 'Character 7',
points: 19
}
]
},
{
username: 'Antonio',
points: '17',
roster: [
{
name: 'Character 6',
points: 17
}
]
];


Feature request: sharing code

Hi!
I love CoffeeScript. In order to refine my code, i need a tool that does several useful things.
Unfortunately, there's no tool that does everything i need. I have to constantly switch between three different tools:

Feature
CoffeeScript.org
js2coffee.org
jsbin.com

Syntax highlighting
:broken_heart:
:green_heart:
:green_heart:

Error highlighting
:broken_heart:1
:green_heart:2
:yellow_heart:3

Code execution
:green_heart:
:green_heart:4
:green_heart:

JS code display
:green_heart:
:green_heart:
:broken_heart:

Reverse compilation
:broken_heart:
:green_heart:
:broken_heart:

Sharing code
:yellow_heart:5
:broken_heart:
:green_heart:

Score (out of 6)
2.5
5
3.5

Reports error's line number whereas lines aren't visually numbered.
Displays the error next to the erroneous line.
Reports error's line number, have to manually enable line numbers and find the line in question.
Hidden feature: press Ctrl+Enter in the JS tab.
Does not store the code. Rather, embeds the code into the URL.

js2coffee is my favorite tool. Among the three services, i wish js2coffee were the one to have the complete functionality.
Currently it lacks only code sharing.
Code sharing can be easily implemented via gist.github.com. You can store snippets from both anonymous and Github-authorized users.

I never really liked how reverse compile works right now... lets see if we can do some UX improvements on that on the next version.

I've implemented a [what i think is] better UX for reverse compilation to the new editor. no more confusing "Which pane am I editing again?" moments!
http://js2coffee.github.io/js2coffee-redux/
Won't explain how to use it (i'm hoping it'd be obvious) — @lolmaus try it out. Would love to get sharing working some time soon too.

Would be great to style scrollbars.

Reverse compiler won't work the same because we adapt JS to Coffee when necessary plus optimize loops, etc..

Scrollbars are better now :)

Sharing and code execution are also available on the new editor now!


Icon request: JFrog

URL for the brand / site / app
https://www.jfrog.com/
Logo resources for the icon
https://jfrog.com/brand-guidelines/
Proof of the Aegis-compatible 2FA
https://www.jfrog.com/confluence/display/JFROG/Logging+in+using+Multi-factor+Authentication
Anything else?
No response
Confirmation

[X] I have read and followed the issue guidelines & issue form.

Here you go!
https://github.com/aegis-icons/aegis-icons/blob/master/icons/1_Primary/JFrog.svg

:question: How to add icon(s) to Aegis?
:star: Support this project by giving a star! Just adding like to this comment is also appreciated.


Lentner Final Project

This is my Final Project submittal.
I would note that there are a few typographical errors and some room for improvement in the discussion.  I plan to improve this shortly regardless, but alas the due date is here :)

I haven't read it yet, but some few comments:
1- You should add a licence as we have in at the beginning of our notebooks.
2- Make the font size of the plots bigger.
3- Install matplotlib 1.5 and use viridis as colormap (we did it for module 5), it looks better.
4- please don't use:
import numpy as np ----------------------> import numpy
from matplotlib import pyplot as plt ---> from matplotlib import pyplot
You can modify this things in a short time, and when you push all those changes will be included in the pull request automatically.

I've just finished the reading of the whole notebook. Here are some suggestions, and typos.

In your BC's after equation 1, appear h_rad and h_conv would you explain what
are these variables?

In the equations for q'' you have sigma, epsilon, T_sur, T_inf and T_suf . Can
you explain what are these variables.

You can write from matplotlib import pyplot, cm instead of:
from matplotlib import pyplot
from matplotlib import cm

The for loops in the cell 3 that correspond to xMelt[i] and xPlate[i] you can
write them in vector form.

In the axis labels the units can be written in Latex by wriing them beteween
'$ $'.

In your code you are using numpy.r_[] but your square brackets are way to separated, why? Besides, it would be nice if you can introduce this function or put a link to the documentation.

The legend in the plot in In[17], covers half of the plot, you can put it
outside, you can follow this link http://stackoverflow.com/questions/4700614/how-to-put-the-legend-out-of-the-plot

typos:
distrobution ------> distribution (this one appears several times)
cental ------------> central
approxamate -------> apprixamate
we get. note ------> we get. Note
analogious --------> analogous
characterise ------> characterize (American english)
conserned ---------> concerned
Matricies ---------> Matrices
codeing -----------> coding
neef  -------------> need
confection --------> convection
Raphon ------------> Raphson
damponing  --------> dampening
substatially ------> substantially
stregths ----------> strengts
recal -------------> recall
exterier ----------> exterior (appears couple of times)
differece ---------> difference
sufficently -------> sufficiently
adventurious ------> adventurous
approaches a more equilibrium state ----> approaches an/the equilibrium state.


pull request for e2e test at 12/30/2016 23:26:07

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Please add support for Aqara lock s2 model(lock.acn02)

You should only file an issue if you found a bug. Feature and enhancement requests should go in the Feature Requests section of our community forum. Thanks!

Sorry about that.


add an option to deal with couchdb conflicts

In the case where two concurrent commits are made on the same session, a conflict might occurs. I see three ways to deals with it :

throw an exception (actual scenario, but it should be better handled)
ignore it
erase the actual stored session

Any interest in this issue getting addressed? I can see how different users would want to either ignore or throw, based on how important their session data is. Consider a PR?

I gladly accept every well tested PRs. :)

I've added basic supprot for ignoring conflicts at https://github.com/eddiesholl/connect-couchdb/tree/conflicts, I'm getting a few other test breakages that I don't think are caused by my changes. If you have a moment do you mind trying it out?
Do you think support for passing in a conflict handling function is required here as well?


Update ICU to 69.1

This PR updates ICU from 64.2 to to 69.1.
Note this PR will cover CVE-2020-10531 (https://www.cvedetails.com/cve/CVE-2020-10531/) which exists through 66.1.
Signed-off-by: Yong Tang<EMAIL_ADDRESS>

@yongtang  Can you please check @mihaimaruseac's comments and keep us posted ? Thanks!

Thanks @gbaned @mihaimaruseac for the reminder. I think I find out where the issue is. Static files within tensorflow/third_party/icu/data/ directory will need to be updated manually and provided as a part of the PR.
However, there is no documentation on how to update those files so I am still in the process of understanding. I will provide update once I can make some progress.

@yongtang Can you please resolve conflicts? Thanks!

@yongtang Any update on this PR? Please. Thanks!

@yongtang Any update on this PR? Please. Thanks!

Sorry for duplicating the work, @yongtang . I was working to bump to 70.1, but due to some failing tests had to lower to 69.1 and then that closed this PR.
I think PR failed before because we didn't also update the datafiles, I added some instructions so we don't forget in the future.


Logitech G910 has broken keys with OpenRGB

Expected Behaviour

When using the Logitech G910 with OpenRGB, the keys ought to all work properly.
Actual Behaviour

The G6, G7, G8, G9 keys and the "G910" logo aren't mapped and instead fall under "Peripheral logo" if the option is set in the OpenRGB options.
Reproduction steps

Use Logitech G910 keyboard with Aurora and OpenRGB.
Observe the OpenRGB and keyboard do not use the G6-G9 keys or G910 logo properly.

Aurora screenshot, showing correct colors:

OpenRGB screenshot, showing actual colors:

Frequency

100%
Aurora Version:

v63
Previously an Issue?

Don't know

OpenRGB doesn't include additional light mappings. This keyboard will need custom layout for openrgb. I can make it myself after changing some implementation of additional light mappings of keyboards.
Also, this is the wrong repository for the new versions
https://github.com/Aurora-RGB/Aurora


Removes last-applied annotation when creating Envoy load balancer service definition

Q
A

Bug fix?
yes

New feature?
no

API breaks?
no

Deprecations?
no

Related tickets
fixes #539

License
Apache 2.0

What's in this PR?

Prevents the banzaicloud.com/last-applied that exists in the KafkaCluster resource from being included in the created Envoy load balancer resource and thus causing the service resource in Kubernetes to be unnecessarily updated.
Additional context

I didn't observe the constant update behavior on a small test EKS cluster but on a sizable production EKS cluster I could consistently reproduce the issue. I'm wondering if this has something to do with some caching happening on the Kubernetes event reader where the banzaicloud.com/last-applied on the KafkaCluster resource isn't updated in the cached events which then perpetuates the cycle whereas on a smaller cluster with fewer events this caching doesn't happen.
Checklist

[x] Implementation tested
[x] Error handling code meets the guideline
[x] Logging code meets the guideline
[x] User guide and development docs updated (if needed)

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Fixed on a different PR.


Add occlusion callback and window attribute

Adds glfwSetWindowOcclusionCallback(GLFWwindow* window, GLFWwindowocclusionfun cbfun) and GLFW_OCCLUDED window attribute as a first step towards #680.
Only implemented on macOS for now.

Thank you, will review!

This feature is so helpful. Please review & merge. Thanks.

As a side-effect of fixing #1337, OpenGL vsync now uses a display link and is not affected by window occlusion. This idea of window occlusion doesn't seem to exist on platforms other than macOS so it would be a macOS-only window attribute and I would prefer not adding that.

The intention was to help users build custom workarounds for the high cpu usage issue caused by the weird vsync behavior of macOS. Since that is all fixed now, this pull request is not needed any more.


Path rename does not get put in undo-redo history, is not restored upon redo.

Visual issue with the path list (logic observing name changes does not work correctly). Save files confirm that the name is changed internally, reverted on undo, changed again on redo, as expected.


2.150.0 You must provide a value for the attribute 'contentRightsDeclaration' with this request

New Release Candidate Issue Checklist

[x] Updated fastlane to the latest release candidate version (2.150.0)
[ ] I read the Contribution Guidelines
[x] I read docs.fastlane.tools
[x] I searched for existing GitHub issues

Breaking version: [2.150.0]

Last working version: [2.149.1]

State of app: [Prepare for Submission]

First version of app?: [Yes]
Issue Description

The problem occurs at the submit_for_review stage.
This is a new app, and everything was fine until submit for review step. Then the following error occurred:
The request cannot be fulfilled because of the state of another resource. - Submit for review errors found.
The provided entity is missing a required attribute - You must provide a value for the attribute 'contentRightsDeclaration' with this request
Mentioning

cc: @joshdholtz
🚫 fastlane environment 🚫
Stack

Key
Value

OS
10.15.4

Ruby
2.6.5

Bundler?
true

Git
git version 2.24.3 (Apple Git-128)

Installation Source
~/.rbenv/versions/2.6.5/bin/fastlane

Host
Mac OS X 10.15.4 (19E266)

Ruby Lib Dir
~/.rbenv/versions/2.6.5/lib

OpenSSL Version
OpenSSL 1.1.1d  10 Sep 2019

Is contained
false

Is homebrew
false

Is installed via Fabric.app
false

Xcode Path
/Applications/Xcode.app/Contents/Developer/

Xcode Version
11.5

System Locale

Error

No Locale with UTF8 found 🚫

fastlane files:
No Fastfile found
No Appfile found
fastlane gems

Gem
Version
Update-Status

fastlane
2.150.0
✅ Up-To-Date

Loaded fastlane plugins:
No plugins Loaded
Loaded gems

Gem
Version

did_you_mean
1.3.0

bundler
1.17.2

etc
1.0.1

forwardable
1.2.0

CFPropertyList
3.0.2

public_suffix
4.0.5

addressable
2.7.0

atomos
0.1.3

aws-eventstream
1.1.0

aws-partitions
1.337.0

aws-sigv4
1.2.1

jmespath
1.4.0

aws-sdk-core
3.103.0

aws-sdk-kms
1.35.0

aws-sdk-s3
1.72.0

babosa
1.0.3

claide
1.0.3

colored
1.2

colored2
3.1.2

highline
1.7.10

commander-fastlane
4.4.6

declarative
0.0.20

declarative-option
0.1.0

digest-crc
0.6.0

unf_ext
<IP_ADDRESS>

unf
0.1.4

domain_name
0.5.20190701

dotenv
2.7.5

emoji_regex
3.0.0

excon
0.75.0

multipart-post
2.0.0

faraday
1.0.1

http-cookie
1.0.3

faraday-cookie_jar
0.0.6

faraday_middleware
1.0.0

fastimage
2.1.7

gh_inspector
1.1.3

jwt
2.1.0

memoist
0.16.2

multi_json
1.14.1

os
1.1.0

signet
0.14.0

googleauth
0.13.0

httpclient
2.8.3

mini_mime
1.0.2

uber
0.1.0

representable
3.0.4

retriable
3.1.2

google-api-client
0.38.0

google-cloud-env
1.3.2

google-cloud-errors
1.0.1

google-cloud-core
1.5.0

google-cloud-storage
1.26.2

json
2.3.1

mini_magick
4.10.1

multi_xml
0.6.0

plist
3.5.0

rubyzip
2.3.0

security
0.1.3

naturally
2.2.0

simctl
1.6.8

slack-notifier
2.3.2

terminal-notifier
2.0.0

unicode-display_width
1.7.0

terminal-table
1.8.0

tty-screen
0.8.0

tty-cursor
0.7.1

tty-spinner
0.9.3

word_wrap
1.0.0

nanaimo
0.2.6

xcodeproj
1.17.0

rouge
2.0.7

xcpretty
0.3.0

xcpretty-travis-formatter
1.0.0

generated on: 2020-07-02

Stack Trace
You can ⌘ + double-click on links to open them directly in your browser.
bundler: failed to load command: fastlane (/Users/vagrant/.rbenv/versions/2.6.5/bin/fastlane)
Spaceship::UnexpectedResponse: [!] The request cannot be fulfilled because of the state of another resource. - Submit for review errors found.
The provided entity is missing a required attribute - You must provide a value for the attribute 'contentRightsDeclaration' with this request
  /Users/vagrant/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/fastlane-2.150.0/spaceship/lib/spaceship/connect_api/client.rb:164:in `handle_response'
  /Users/vagrant/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/fastlane-2.150.0/spaceship/lib/spaceship/connect_api/client.rb:100:in `post'
  /Users/vagrant/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/fastlane-2.150.0/spaceship/lib/spaceship/connect_api/tunes/tunes.rb:796:in `post_app_store_version_submission'
  /Users/vagrant/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/fastlane-2.150.0/spaceship/lib/spaceship/connect_api/models/app_store_version.rb:154:in `create_app_store_version_submission'
  /Users/vagrant/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/fastlane-2.150.0/deliver/lib/deliver/submit_for_review.rb:28:in `submit!'
  /Users/vagrant/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/fastlane-2.150.0/deliver/lib/deliver/runner.rb:172:in `submit_for_review'
  /Users/vagrant/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/fastlane-2.150.0/deliver/lib/deliver/runner.rb:49:in `run'
  /Users/vagrant/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/fastlane-2.150.0/fastlane/lib/fastlane/actions/upload_to_app_store.rb:17:in `run'
  /Users/vagrant/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/fastlane-2.150.0/fastlane/lib/fastlane/runner.rb:261:in `block (2 levels) in execute_action'
  /Users/vagrant/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/fastlane-2.150.0/fastlane/lib/fastlane/actions/actions_helper.rb:50:in `execute_action'
  /Users/vagrant/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/fastlane-2.150.0/fastlane/lib/fastlane/runner.rb:253:in `block in execute_action'
  /Users/vagrant/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/fastlane-2.150.0/fastlane/lib/fastlane/runner.rb:227:in `chdir'
  /Users/vagrant/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/fastlane-2.150.0/fastlane/lib/fastlane/runner.rb:227:in `execute_action'
  /Users/vagrant/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/fastlane-2.150.0/fastlane/lib/fastlane/runner.rb:157:in `trigger_action_by_name'
  /Users/vagrant/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/fastlane-2.150.0/fastlane/lib/fastlane/fast_file.rb:159:in `method_missing'
  Fastfile:55:in `block (2 levels) in parsing_binding'
  /Users/vagrant/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/fastlane-2.150.0/fastlane/lib/fastlane/lane.rb:33:in `call'
  /Users/vagrant/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/fastlane-2.150.0/fastlane/lib/fastlane/runner.rb:49:in `block in execute'
  /Users/vagrant/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/fastlane-2.150.0/fastlane/lib/fastlane/runner.rb:45:in `chdir'
  /Users/vagrant/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/fastlane-2.150.0/fastlane/lib/fastlane/runner.rb:45:in `execute'
  /Users/vagrant/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/fastlane-2.150.0/fastlane/lib/fastlane/lane_manager.rb:47:in `cruise_lane'
  /Users/vagrant/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/fastlane-2.150.0/fastlane/lib/fastlane/command_line_handler.rb:36:in `handle'
  /Users/vagrant/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/fastlane-2.150.0/fastlane/lib/fastlane/commands_generator.rb:108:in `block (2 levels) in run'
  /Users/vagrant/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/commander-fastlane-4.4.6/lib/commander/command.rb:178:in `call'
  /Users/vagrant/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/commander-fastlane-4.4.6/lib/commander/command.rb:153:in `run'
  /Users/vagrant/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/commander-fastlane-4.4.6/lib/commander/runner.rb:476:in `run_active_command'
  /Users/vagrant/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/fastlane-2.150.0/fastlane_core/lib/fastlane_core/ui/fastlane_runner.rb:76:in `run!'
  /Users/vagrant/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/commander-fastlane-4.4.6/lib/commander/delegates.rb:15:in `run!'
  /Users/vagrant/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/fastlane-2.150.0/fastlane/lib/fastlane/commands_generator.rb:352:in `run'
  /Users/vagrant/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/fastlane-2.150.0/fastlane/lib/fastlane/commands_generator.rb:41:in `start'
  /Users/vagrant/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/fastlane-2.150.0/fastlane/lib/fastlane/cli_tools_distributor.rb:119:in `take_off'
  /Users/vagrant/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/fastlane-2.150.0/bin/fastlane:23:in `<top (required)>'
  /Users/vagrant/.rbenv/versions/2.6.5/bin/fastlane:23:in `load'
  /Users/vagrant/.rbenv/versions/2.6.5/bin/fastlane:23:in `<top (required)>'

#16645

@thinklinux
This looks like a new requirement from the AppStoreConnect API which is already handled in the 2.150.0 release, but it remained undocumented - https://github.com/fastlane/fastlane/blob/master/deliver/lib/deliver/submit_for_review.rb#L174
Try providing content_rights_contains_third_party_content: true/false (depending on your app) in submission_information if using fastlane deliver.
E.g
deliver(
   ...
   submission_information: {
          add_id_info_uses_idfa: false,
          export_compliance_compliance_required: false,
          export_compliance_encryption_updated: false,
          export_compliance_app_type: nil,
          export_compliance_uses_encryption: false,
          export_compliance_is_exempt: false,
          export_compliance_contains_third_party_cryptography: false,
          export_compliance_contains_proprietary_cryptography: false,
          content_rights_contains_third_party_content: false
        })

@petekanev Thanks for answering! I had to go to the dentist so I didn't get a chance to this morning 🤷♂ But...
@thinklinux
I will add a helpful error message that explains how to add this when this occurs so there isn't any confusion 😊  I did this with export compliance and IDFA but not content right I guess 😬 I will get this fixed for 2.150.2 💪

Thank you both for the fast reaction!!! Closing this one ^^


[requires.io] dependency update on master branch

Coverage remained the same at 98.182% when pulling 10a27fb575796a4d7118755a3f712aa36c2d117a on requires-io-master into a400767e46e59c33929d6362ae8b3c9345d53c9f on master.

Coverage remained the same at 98.182% when pulling 6555ae20b7d1169cbb7cfaf0cfcc7f2018adaa34 on requires-io-master into a400767e46e59c33929d6362ae8b3c9345d53c9f on master.


Is there a way to plot the number of new infected?

I would like to track the numbers of newly infected people, because it is easier to see if a curve flatten.

The most recent you can track is by month. So the closes you can get is to do M.YY where M is the current month. Unfortunately, I haven't implemented a shorter time period. A PR will be welcome if you'd want to do it.

I though of one or two new colum with the logic.
Column "New Cases"
newCasesToday = totalToday - totalYesterday
Column ActiveCases
currentInfectedToday = totalToday - deatchsToday
This should be possible with the already loaded datasets.


Misleading guarantee of accuracy

Calculatte offers the option to round answers to a certain amount of decimal places, but does not guarantee precision for that amount of decimal places. Much research will be needed to be able to guarantee error within Calculatte, and much time will be needed to conduct said research.
Temporary Solution
No longer offer the ability to round to a certain amount of decimal places without guaranteed error. This solution will most likely be taken until the final solution can be implemented as to not stop the true focus of Calculatte. Calculatte was a passion project for calculus and programming--and more so for calculus. Due to this vision, I still wish to continue adding my knowledge of calculus into code and will add my knowledge of computer science when it is ready.
Solution
Be able to guarantee error and replace decimal rounding with the ability to change the precision of a calculation. I currently do not know what this solution will look like or what it entails.
/cc @jojongx

Whilst removing rounding in PR #6, I noticed that unit tests will now have to account for long decimal results. Due to floating point inaccuracies, often Calculatte's calculation would be inaccurate, however, once rounded to 3-5 decimal places, the value would be 100% or near 100% accurate.
Perhaps, a default rounding value that cannot be changed should be decided upon. More testing on the accuracy of Calculatte's values when rounded need to be done.
/cc @jojongx


ui: don't strip node hostname

Avoid to strip a hostname that is > 12 chars]

ok to tests

rerun tests

rerun selenium-tests

rerun selenium-tests

rerun selenium-tests


Respect build tag priority in uv.lock

Summary
Akin to https://github.com/astral-sh/uv/pull/3781.
Closes https://github.com/astral-sh/uv/issues/9673.

I tested this using the same procedure as https://github.com/astral-sh/uv/pull/3781. I'll add some build tag tests in a separate PR since it's somewhat involved.


CLI: I want to use only 7 chars from the AccountID as well

Feature description
In the CLI, I want to be able to use only 7 chars for the account.
Currently, I get
dschmid@Polygon-DWYQXJC2JG ~ % miden-client account show -v 0x935ca96
Input number was not a valid Account Id

But this
dschmid@Polygon-DWYQXJC2JG ~ % miden-client account show -v 0x935ca96484fe610b

works.
Why is this feature needed?
I want to use the CLI easier.
Might be related to #233

closing as the PR got merged


Elements must only use allowed ARIA attributes

Several component demos exhibit this same issue. Details related to this accessibility violation can be found here: https://dequeuniversity.com/rules/axe/3.0/aria-allowed-attr
Below are the URLs that illustrate the problem:

/components/OptionsMenu/examples-full/
/components/Pagination/examples-full/
/components/Toolbar/examples-full/

This is a critical a11y issue.
Related to https://github.com/patternfly/patternfly-next/issues/541
To learn more about how to build and test locally, check out: https://github.com/patternfly/patternfly-next#testing-for-accessibility
As part of this issue, please complete the following items. These will help reviewers know what issues were addressed in the PR, and also will help us keep our total a11y violation count down.

Run the a11y audit, copy the issues from the audit that were fixed in the PR, and paste them into the PR description.

Instructions for running the audit are here: https://github.com/patternfly/patternfly-next#testing-for-accessibility
Issues that are returned in the terminal look like this. Find the issues you are addressing and copy the following information provided for them or take a screencap to include in the PR.1 error found in: /upgrade-examples/AlertUpgradeExamples/examples-full/

1) Buttons must have discernible text -- https://dequeuniversity.com/rules/axe/3.1/button-name -- impact: critical

-------html violation instances-------

<button class="btn btn-link dropdown-toggle" type="button" id="dropdownKebabRight" data-toggle="dropdown" aria-haspopup="true" aria-expanded="true">

</button>

Reduce the threshold by number of issues being addressed

This update is made here
The new value should be derived by:

subtracting the number of issues you are addressing in the PR (e.g. the line that looks like this in the info you copied from the audit report in item 1 above):
5 errors found in: /components/Toolbar/examples-full/
from current violations (e.g. this line in the audit report, near the end):
20 violations in total

I'm following up on this issue. Any updates here?

@rachael-phillips looks like the original issue in the Form component was resolved, but it's crept back up in three other components since then. I updated the issue accordingly.

Thanks!


wrong code in /bin/attic script

Python-3.2 and virtualenv on raspbian (debian wheezy, python 3.2.3):
(env)pi@raspberrypi ~/attic/merge $ attic init ../repo
Traceback (most recent call last):
  File "/home/pi/attic/env/bin/attic", line 7, in <module>
    execfile(__file__)
NameError: name 'execfile' is not defined

Such a script on another machine with ubuntu looks like:
...
if sys.version_info < (3, 0):
    execfile(__file__)
else:
    exec(compile(open(__file__).read(), __file__, 'exec'))

So somehow it tries to use the pre-py3 way.

This bug might be related to python 3.2.3, I can't reproduce on another machine with 3.2.6.

I close this, doesn't look like the bug is somewhere in attic or could be worked around by attic.


failure to start (or death) after many etcd updates

when there are many etcd updates, like creating 200 pods, calico-bgp-daemon dies and cannot be restarted manually.
Current Behavior
ipam.sync dies from such a HTTP response.
{"errorCode":401,"message":"The event in requested index is outdated and cleared","cause":"the requested history has been cleared [6920/22]","index":7919}
Possible Solution
Fix as described in
https://coreos.com/etcd/docs/latest/v2/api.html#watch-from-cleared-event-index
Steps to Reproduce (for bugs)

Context

Your Environment
happens with calico-bgp-daemon 0.2.1 and 0.2.2

I'm going to deal with this next week.

Created a pull request:
https://github.com/projectcalico/calico-bgp-daemon/pull/31

Fixed by commit a64a15ad433e22e3476245683fc6ec0947d8a614


Fixes #1247 unable to load solution using vs2015

Fixes #1247 unable to load solution using vs2015
Makes imports optional. The code to automatically install dependencies already exists and works correctly from within VS.

:+1:


Document release note subsections and categorize 1.1 notes

Summary
This commit adds contributor documentation about the release note subsections. Now that we're using subsections on main we should encourage contributors to use the appropriate subsection when adding new release notes to reduce the release time effort needed to correctly categorize the release notes. This also updates the new release note template to list out all the subsections.
This also updates the current notes pending for the 1.1.0 release to use subsections so that from this point forward we're using subsections for all feature, deprecation, and upgrade notes.
Details and comments

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0   changed or added relevant lines in 0 files are covered.
3 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.01%) to 89.312%

Files with Coverage Reduction
New Missed Lines
%

crates/qasm2/src/lex.rs
3
91.94%

Totals

Change from base Build<PHONE_NUMBER>:
0.01%

Covered Lines:
59126

Relevant Lines:
66202

💛  - Coveralls


Problem sending Images with firefox minimized

I'm using the following function to send an image with caption.
If the browser (firefox/ubuntu 18.04) is not minimized or if it is hidden by another window I can send images without problems.
The problem are present when I minimize the browser and try to send images.
All the images are not send to the user or  the caption messaje are put in the footer text box
Apparently the problem are present when I try to use the function find_element_by_xpath in order to find the  CSS elements:
            message = self.driver.driver.find_element_by_xpath("/html/body/div/div/div/div[1]/div[2]/span/div/span/div/div/div[2]/div/span/div/div[2]/div/div[3]/div[1]/div[2]")
            message.send_keys(caption+Keys.ENTER)
        else:
            self.driver.driver.find_element_by_xpath("/html/body/div/div/div/div[1]/div[2]/span/div/span/div/div/div[2]/span[2]/div/div/span").click()

Anybody Know if exist some problem using selenium with a browser minimizied and how to solve?
thanks
def send_media_file(self, chat_id, type, mediaURL, caption = None):
    # Select the chat to send file
    self.select_chat(chat_id)

    # Verifica el tipo de archivo a enviar
    if type is None or not (type == self.TYPE_MEDIA or type == self.TYPE_DOCUMENTS):
        return

    #   Not add caption when send documentes
    if type == self.TYPE_DOCUMENTS:
        caption  = ''
        event_id = 'SEND_DOC_FILE'

    while True:
        try:
            # This part clicks on the attachment button
            self.driver.driver.find_element_by_xpath('//*[@title="Adjuntar"]').click()
            time.sleep(2)

            # Gets the photo/video input, you can alter the last li[1] for other type of input
            element = self.driver.driver.find_element_by_xpath('//*[@id="main"]/header/div[3]/div/div[2]/span/div/div/ul/li[' + str(type) + ']/input')

            # Make the input visible
            self.driver.driver.execute_script("arguments[0].setAttribute('style', 'block')",element)

            # Download media file
            filename = helper.downloadMediaFile(mediaURL)

            element.send_keys(filename)

            if caption is not None and util.isNotBlank(caption):
                time.sleep(2)
                message = self.driver.driver.find_element_by_xpath("/html/body/div/div/div/div[1]/div[2]/span/div/span/div/div/div[2]/div/span/div/div[2]/div/div[3]/div[1]/div[2]")
                message.send_keys(caption+Keys.ENTER)
            else:
                self.driver.driver.find_element_by_xpath("/html/body/div/div/div/div[1]/div[2]/span/div/span/div/div/div[2]/span[2]/div/div/span").click()
            break
        except:
            pass

https://github.com/mukulhase/WebWhatsapp-Wrapper/pull/300

@dafner
How did you implement your function?
  self.select_chat(chat_id)
I'm trying this way, but the input field is never filled and so I always get the first chat ..
   elem = driver.driver.find_element_by_xpath('//*[@title="Procurar ou começar uma nova conversa"]')
   elem.send_keys(phone)
   elem.send_keys(Keys.ENTER)

I Use the following method in my class. Also, I attach the function code for  downloadMediaFile method
Did yo experiment some problems in the function find_element_by_xpath when the browser is minimized?
def select_chat(self, chat):
    chat = chat.split("@")[0]

    if chat.isnumeric():
        # Select chat by id
        self.driver.driver.find_element_by_xpath('//*[@title="Buscar o empezar un chat nuevo"]').send_keys(chat + Keys.ENTER)
    else:
        # Select chat by name
        user = self.driver.driver.find_element_by_xpath('//span[@title="{}"]'.format(chat))
        user.click()

def downloadMediaFile(mediaURL, saveAs = None, path = '/tmp'):
if mediaURL is not None and isNotBlank(mediaURL):
# Test if mediaURL is file or a valid URL
if not os.path.isfile(mediaURL):
filename, ext = os.path.splitext(os.path.basename(urlparse(mediaURL).path))
        img_data = requests.get(mediaURL).content

        if saveAs is not None:
            filename = saveAs

        mediaURL = path + '/' + filename + ext

        with open(mediaURL, 'wb') as handler:
            handler.write(img_data)

return mediaURL

bobaoapae
Do you know if your modification to the file wapi.js could be included in the master branch?