[Bug]: OpenAI API Completions and Chat API inconsistency

Your current environment
Collecting environment information...
PyTorch version: 2.3.1+cu121
Is debug build: False
CUDA used to build PyTorch: 12.1
ROCM used to build PyTorch: N/A
OS: Ubuntu 22.04.4 LTS (x86_64)
GCC version: (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0
Clang version: Could not collect
CMake version: version 3.30.1
Libc version: glibc-2.35
Python version: 3.10.12 (main, Mar 22 2024, 16:50:05) [GCC 11.4.0] (64-bit runtime)
Python platform: Linux-5.15.0-113-generic-x86_64-with-glibc2.35
Is CUDA available: True
CUDA runtime version: 12.4.131
CUDA_MODULE_LOADING set to: LAZY
GPU models and configuration: GPU 0: NVIDIA GeForce RTX 4090
Nvidia driver version: 550.90.07
cuDNN version: Could not collect
HIP runtime version: N/A
MIOpen runtime version: N/A
Is XNNPACK available: True
CPU:
Architecture:                       x86_64
CPU op-mode(s):                     32-bit, 64-bit
Address sizes:                      46 bits physical, 48 bits virtual
Byte Order:                         Little Endian
CPU(s):                             8
On-line CPU(s) list:                0-7
Vendor ID:                          GenuineIntel
Model name:                         Intel(R) Core(TM) i7-14700K
CPU family:                         6
Model:                              183
Thread(s) per core:                 1
Core(s) per socket:                 1
Socket(s):                          8
Stepping:                           1
BogoMIPS:                           6835.55
Flags:                              fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush acpi mmx fxsr sse sse2 ss syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl cpuid tsc_known_freq pni pclmulqdq ssse3 fma cx16 sse4_1 sse4_2 x2apic movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand hypervisor lahf_lm abm 3dnowprefetch cpuid_fault ssbd ibrs ibpb stibp ibrs_enhanced fsgsbase tsc_adjust bmi1 avx2 smep bmi2 erms invpcid rdseed adx smap clflushopt clwb sha_ni xsaveopt xsavec xgetbv1 xsaves umip pku ospke gfni vaes vpclmulqdq rdpid md_clear flush_l1d arch_capabilities
Hypervisor vendor:                  Xen
Virtualization type:                full
L1d cache:                          384 KiB (8 instances)
L1i cache:                          256 KiB (8 instances)
L2 cache:                           16 MiB (8 instances)
L3 cache:                           264 MiB (8 instances)
NUMA node(s):                       1
NUMA node0 CPU(s):                  0-7
Vulnerability Gather data sampling: Not affected
Vulnerability Itlb multihit:        Not affected
Vulnerability L1tf:                 Not affected
Vulnerability Mds:                  Not affected
Vulnerability Meltdown:             Not affected
Vulnerability Mmio stale data:      Not affected
Vulnerability Retbleed:             Not affected
Vulnerability Spec rstack overflow: Not affected
Vulnerability Spec store bypass:    Mitigation; Speculative Store Bypass disabled via prctl and seccomp
Vulnerability Spectre v1:           Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2:           Mitigation; Enhanced IBRS; IBPB conditional; RSB filling; PBRSB-eIBRS SW sequence; BHI BHI_DIS_S
Vulnerability Srbds:                Not affected
Vulnerability Tsx async abort:      Not affected
Versions of relevant libraries:
[pip3] numpy==1.26.4
[pip3] nvidia-nccl-cu12==2.20.5
[pip3] torch==2.3.1
[pip3] torchvision==0.18.1
[pip3] transformers==4.43.1
[pip3] triton==2.3.1
[conda] Could not collect
ROCM Version: Could not collect
Neuron SDK Version: N/A
vLLM Version: 0.5.2
vLLM Build Flags:
CUDA Archs: Not Set; ROCm: Disabled; Neuron: Disabled
GPU Topology:
GPU0    CPU Affinity    NUMA Affinity   GPU NUMA ID
GPU0     X      0-7     0               N/A
Legend:
X    = Self
SYS  = Connection traversing PCIe as well as the SMP interconnect between NUMA nodes (e.g., QPI/UPI)
NODE = Connection traversing PCIe as well as the interconnect between PCIe Host Bridges within a NUMA node
PHB  = Connection traversing PCIe as well as a PCIe Host Bridge (typically the CPU)
PXB  = Connection traversing multiple PCIe bridges (without traversing the PCIe Host Bridge)
PIX  = Connection traversing at most a single PCIe bridge
NV#  = Connection traversing a bonded set of # NVLinks
🐛 Describe the bug
when using python -m vllm.entrypoints.openai.api_server --model OpenAI server
And calling it with openai.completions.create or openai.chat.completions.create
In case of chat BOS token isn't automaticaly added
In case of completions it's automaticaly added
Which is unexpected behaviour difference that changes model responce

@Theodotus1243 this is intentional since the BOS token is generally included in chat templates and so would be incorrectly duplicated if it was also added by the tokenizer.
It's added in the completions case because the input is expected to be raw. Note this is only for particular models/tokenizers that expect it (including Llama, Mixtral).

Just adding add_special_tokens = True solves the problem

@njhill Thanks for quick response
Found the same notice in docs
https://docs.vllm.ai/en/stable/serving/openai_compatible_server.html#extra-parameters-for-chat-api
Hope this issue will be useful info for others


videos in pr comments

support for videos in PR comments
Update CODEOWNERS for Code Repository docs. Remove trailing whitespace.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://65a96d16337ae1074aa0c990--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://65a96dccedeba30826786304--harness-developer.netlify.app

Approved the CODEOWNER changes @aimurphy

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://65aefd234fbcb26e1072a044--harness-developer.netlify.app


updating the defaults

This fixes the issue of the default run not working. Substituted the default season for the second last instead of the very last.

Thanks, I hadn't seen this and just put in my own patch here: https://github.com/toddwschneider/ballr/commit/d48757df543029d44e9b12f61e87e35e5b39f910


@2.15.0 -<EMAIL_ADDRESS>

close #611

coverage: 99.245%. remained the same
when pulling a6b432710c84ba6675081b84c123e4092a1b4aa7 on rc-2.15.0
into 6ee7edc5070956486f362042b4a655f602bde7d2 on master.


CsvLayout should support multi line text in excel

I'm using the following CsvLayout, and the output is written into logile.csv
CsvLayout layout = new CsvLayout();
            layout.Columns.Add(new CsvColumn("Date","${longdate}"));
            layout.Columns.Add(new CsvColumn("Level", "${level}"));
            layout.Columns.Add(new CsvColumn("Message", "${message}"));
            layout.Columns.Add(new CsvColumn("Exception", "${exception:format=tostring}"));
            layout.Columns.Add(new CsvColumn("Stacktrace", "${stacktrace}"));

But when the exception has several lines, and you open the csv file in excel, it will show only the first line.
It seems excel handles csv multiline a bit different.
Is there a way to configure NLog in order to use excel for analysing log files?

It does look like Excel is handling it differently. There are a few solutions that worked for people in this (stackoverflow question)[http://stackoverflow.com/questions/2668678/importing-csv-with-line-breaks-in-excel-2007].
Can you try them out and let us know if any worked for you?

I know how i can create a csv which can handle multiline entries in excel. It's mainly masking column entries with a apostrophe.
The problem is that the multi line entries from the exception are written directly by nlog. It seems i'm unable to alter the exception text before it is written into the file.
Or is there a way to set a hook/handle OnBeforeWrite where i could alter the string?

Do you need to replace new line chars from the exception message?

Or is there a way to set a hook/handle OnBeforeWrite where i could alter the string?
You can create a custom exception layout renderer and add them to the NLog.
Take a look at https://github.com/NLog/NLog/wiki/Extending-NLog#how-to-write-a-custom-layout-renderer. Instead of inheriting from LayoutRenderer you might want to inherit from ExceptionLayoutRenderer

There are test cases in NLog repo for this take a look at https://github.com/NLog/NLog/blob/master/tests/NLog.UnitTests/LayoutRenderers/ExceptionTests.cs#L683

Given is the following exception message:
System.ArgumentNullException: Value cannot be null.
Parameter name: foo
   at ConsoleApplication1xx.Program.Main(String[] args) in C:\temp\ConsoleApplication1xx\ConsoleApplication1xx\Program.cs:line 16

And for excel to display it properly from a csv file, it shoul be masked like this:
"System.ArgumentNullException: Value cannot be null.
Parameter name: foo
   at ConsoleApplication1xx.Program.Main(String[] args) in C:\temp\ConsoleApplication1xx\ConsoleApplication1xx\Program.cs:line 16"

The linebreaks don't even matter. Only the quotation mark.

You can use quoting options. Take a look https://github.com/NLog/NLog/wiki/CsvLayout#csv-options

@UgurAldanmaz this.
Thanks a lot.

You are welcome @suntsu42. I am closing this issue. If you need help again, feel free to create a new issue.
Have a good day.

Can someone add this to the wiki? https://github.com/NLog/NLog/wiki/CsvLayout#csv-options

@304NotModified Yes I can. Just as a remark?

I did.  Thanks @304NotModified.

Thanks @UgurAldanmaz !


Add Oracle and Database Schema Conversion Toolkit extensions.

This change adds two more of our extensions.

Extension for Oracle is a basic "tools" extension that enables ADS to connect to Oracle and explore database objects. It currently contains limited functionality scoped to just what we need for the conversion.
Database Schema Conversion Toolkit (Oracle to MS SQL) is the actual extension that implements the conversion from PL/SQL to T-SQL.

thanks for letting us know, looks like Aasim created a while back by mistake, I have deleted it.


Dark mode support

Hey, quick one.
Unless I am missing something obvious, it looks like there is no dark mode support by default?

You can pass directly to the React-Select component.
Took me a little bit to figure out, but I reversed the theme colours for it.
Original:
{
  "borderRadius": 4,
  "colors": {
    "primary": "#2684FF",
    "primary75": "#4C9AFF",
    "primary50": "#B2D4FF",
    "primary25": "#DEEBFF",
    "danger": "#DE350B",
    "dangerLight": "#FFBDAD",
    "neutral0": "hsl(0, 0%, 100%)",
    "neutral5": "hsl(0, 0%, 95%)",
    "neutral10": "hsl(0, 0%, 90%)",
    "neutral20": "hsl(0, 0%, 80%)",
    "neutral30": "hsl(0, 0%, 70%)",
    "neutral40": "hsl(0, 0%, 60%)",
    "neutral50": "hsl(0, 0%, 50%)",
    "neutral60": "hsl(0, 0%, 40%)",
    "neutral70": "hsl(0, 0%, 30%)",
    "neutral80": "hsl(0, 0%, 20%)",
    "neutral90": "hsl(0, 0%, 10%)"
  },
  "spacing": {
    "baseUnit": 4,
    "controlHeight": 38,
    "menuGutter": 8
  }
}

Added the following to tags field:
reactSelectOptions: {
  theme: (theme: any) => ({
    ...theme,
    colors: {
      ...theme.colors,
      "neutral0": "hsl(0, 0%, 10%)",
      "neutral5": "hsl(0, 0%, 15%)",
      "neutral10": "hsl(0, 0%, 20%)",
      "neutral20": "hsl(0, 0%, 30%)",
      "neutral30": "hsl(0, 0%, 40%)",
      "neutral40": "hsl(0, 0%, 50%)",
      "neutral50": "hsl(0, 0%, 60%)",
      "neutral60": "hsl(0, 0%, 70%)",
      "neutral70": "hsl(0, 0%, 80%)",
      "neutral80": "hsl(0, 0%, 90%)",
      "neutral90": "hsl(0, 0%, 100%)"
    },
  })
},

Entire field:
defineField({
  name: 'tags',
  title: 'Tags',
  type: 'tags',
  options: {
    reactSelectOptions: {
      theme: (theme: any) => ({
        ...theme,
        colors: {
          ...theme.colors,
          "neutral0": "hsl(0, 0%, 10%)",
          "neutral5": "hsl(0, 0%, 15%)",
          "neutral10": "hsl(0, 0%, 20%)",
          "neutral20": "hsl(0, 0%, 30%)",
          "neutral30": "hsl(0, 0%, 40%)",
          "neutral40": "hsl(0, 0%, 50%)",
          "neutral50": "hsl(0, 0%, 60%)",
          "neutral60": "hsl(0, 0%, 70%)",
          "neutral70": "hsl(0, 0%, 80%)",
          "neutral80": "hsl(0, 0%, 90%)",
          "neutral90": "hsl(0, 0%, 100%)"
        },
      })
    },
    includeFromRelated: 'tags'
  }
}),

@liamb13 Amazing, thank you!
Sorry for late reply, guess I missed the notification or the notification missed me :)


Migrate old configs to new CLI format

Description

Migrate old configs to match the new CLI design

TODO

[x] Compare performance after migration (ensure that all the optimizers and callbacks are loaded correctly)
[x] Remove LightningModels (they exist for backward compatibility) with the new design we can use the same one as LightningCLI
[x] Extend to cflow, dfkde, dfm, draem, fastflow, ganomaly, strpm, patchcore, reverse_distillation
[x] Modify tests

Ignore the feature extractor part as those changes will be merged into the feature branch from PR https://github.com/openvinotoolkit/anomalib/pull/748

As a result of forcing the config.yaml to follow the PL CLI format, we can no longer re-use parameters from one section of the config in another section. This leads to duplicate parameter definitions in the config, where in our current design we only have to define these parameters once. For example, data and visualization now both have the task parameter, where previously we only had dataset.task. Another example is the duplication of input_size between data and model. I can think of many ways in which this could lead to bugs and unexpected behaviour.

In this particular case, for example, it can indeed happen that they have different sizes but there is a preprocesing step in the model that does the resizing.
I see your point but it honestly doesn't look so catastrophic IMO.

Every parameter that is in some way needed by a module must be be defined in its init args, so we are much less free in how we structure our config.yaml. For example, let's say we want to separate the pre-processing related parameters from the dataset-related parameters, that's no longer possible, because both are needed by the DataModule.

Not trying to disagree on every point (haha), but this actually sounds like an advantage to me.
By enforcing this structure, it becomes easier to find the correspondance of things between the config file and the code.
In other words, it's easier to figure out (for exampel) with a Ctrl+F  the parts of the code affected by a parameter (more intuitive to debug).

In this particular case, for example, it can indeed happen that they have different sizes but there is a preprocesing step in the model that does the resizing.
I see your point but it honestly doesn't look so catastrophic IMO.

It's not just the handling of the duplicate parameters that I'm concerned about, but also the usability of the config file from the user perspective. Having to change multiple parameters in the config to change a single setting does not feel very user-friendly and could easily lead to confusion. If two different parameters are always forced to have the same value, then from a user perspective it makes no sense to have them as different parameters.

By enforcing this structure, it becomes easier to find the correspondance of things between the config file and the code.
In other words, it's easier to figure out (for exampel) with a Ctrl+F the parts of the code affected by a parameter (more intuitive to debug).

I guess that's true, and I agree that in general it would be desirable to have a config file that matches the class structure, but my point is that we lose the flexibility. With the current design we have the freedom to structure the config in any way we see fit, which means that we can structure the parameters based on the design of our modules, but we can deviate from this if needed. We lose this freedom when we switch to the CLI design.
Another side effect is that we cannot pass complex data types to the constructors of our classes. Any complex object that we need in our lightning modules must be instantiated from within the module, which can lead to huge lists of constructor arguments, as we're already seeing in the datamodule.

It's not just the handling of the duplicate parameters that I'm concerned about, but also the usability of the config file from the user perspective. Having to change multiple parameters in the config to change a single setting does not feel very user-friendly and could easily lead to confusion. If two different parameters are always forced to have the same value, then from a user perspective it makes no sense to have them as different parameters.

A possible but not necessarily simple solution to have the best of both worlds: a new abstraction layer (yay! haha).
There could be a (1) user-oriented config (solving the issues you're saying) that gets "normalized"/"standardized" (better term?) to a (2) machine-oriented config file (the one passed to the cli). How I imagine it: the first field of the config file states if its (1) or (2). If it's (1), the cli will first generate (2) before running.
To be noted that (1) can have many simplifications (e.g. custom dimension reduction instead of the ones used in the papers) if relevant, while the user can still use (2) for detailed configuration.

I guess that's true, and I agree that in general it would be desirable to have a config file that matches the class structure, but my point is that we lose the flexibility. With the current design we have the freedom to structure the config in any way we see fit, which means that we can structure the parameters based on the design of our modules, but we can deviate from this if needed. We lose this freedom when we switch to the CLI design.
Another side effect is that we cannot pass complex data types to the constructors of our classes. Any complex object that we need in our lightning modules must be instantiated from within the module, which can lead to huge lists of constructor arguments, as we're already seeing in the datamodule. (EDIT: I guess it helps that the tiler settings are now moved to their own section, so this might not be that big an issue).

That's true. From my personal experience, I actually think it's nice to put some limitations to developper creativity : ) (more seriously, it makes you think twice before deviating from the general framework).

A possible but not necessarily simple solution to have the best of both worlds: a new abstraction layer (yay! haha).
There could be a (1) user-oriented config (solving the issues you're saying) that gets "normalized"/"standardized" (better term?) to a (2) machine-oriented config file (the one passed to the cli). How I imagine it: the first field of the config file states if its (1) or (2). If it's (1), the cli will first generate (2) before running.
To be noted that (1) can have simplifications, while the user can still use (2) for detailed configuration.

Hmm yes, that could work, although I would be concerned about the maintenance. I believe @ashwinvaidya17 found a way to link parameters between different sections of a PL CLI, which could potentially address my concern about parameter duplication.

Hmm yes, that could work, although I would be concerned about the maintenance

yeah... hehe

@djdameln  could it be managed in the trainer?
The trainer has access to both the datamodule/dataset (therefore it can compute the effective image size, seen by the model) and the model.
Idk exatcly how, but it sounds like something that could be manabed with a hook or a callback.
Btw, it would perhaps be nice to have a more precise vocabulary in the args/variables so we know that we're talking about the nominal_input_size (from the preprocessin resize) and the effective_input_size (seen by the model).

these names are just suggestions

@djdameln could it be managed in the trainer?
The trainer has access to both the datamodule/dataset (therefore it can compute the effective image size, seen by the model) and the model.

This could be an option, though I'm not entirely clear on how this would play out with the CLI parser.
We have recently started looking into custom lightning loops, which we are thinking could help to simplify the overall design of the library. I guess it would be possible to manage the effective input size from a custom training loop.

Btw, it would perhaps be nice to have a more precise vocabulary in the args/variables so we know that we're talking about the nominal_input_size (from the preprocessin resize) and the effective_input_size (seen by the model).

I agree, using this for the internal variable names would make the code more easy to follow. For the user-exposed parameters I'm not so sure. An editable parameter which is named as effective_input_size could be even more confusing from a user perspective.

For the user-exposed parameters I'm not so sure. An editable parameter which is named as effective_input_size could be even more confusing from a user perspective.

In general terms, yes, I agree that the user interface should be kept simple.
But this particular case sounds reasonable to require some knowledge from the user IMO.  One must be aware of the existence of a preprocessing pipeline that modifies the data.

Argument linking is only supported from the lightning cli. I haven't added it to this PR as I cli.py is going to be a separate PR

Ah, sorry, I misunderstood your previous comment then. nvm then, let's address it in the next one.


Clicking Twitter & Notifications icons do not close respective elements

Clicking the Twitter icon will open the twitter feed, but clicking it again won't close it.  Same goes for notifications element.

I think that we could have one single mouseup event handler attached to the document body that closes all elements in an "open" state.  If we do that, we have to take into account Work section ul elements that may have an open class name.


Can the daemon return random values?

Hello,
Right now I'm using snmpsim to simulate static data from a file(.snmprec), which works, but I am curious if it's possible to return random values and get rid of the static data that I'm using now.

in the same spirit, I'd like to simulate a number of devices from a base snmprec, and change some data in, like the device IP, Name, serial nb, ...
Is there something to do this, or should I go for a script + some sed?


control-service: move cron jobs methods to the data jobs class

Why
At the moment the KubernetesService class as much to much responsibilities.
It is extended by DataJobsKubernetesService and controlKubernetesService class.
However it includes the logic that is unique to those individual classes also.
For example only the datajobsKS creates or deploys cron jobs.
So in this PR I move those external facing functions to the dataJobsclass and fix the tests.
I have not move alot of the more private functions to the datajobs class yet because alot of other tests need to be changed to achieve this as they are being tested using reflection and I want to keep the PRs small.
How has this been tested?
Locally.
Signed-off-by: murphp15<EMAIL_ADDRESS>

Just because I dont want to cross-reference 200 loc, the methods are the same, they're just moved to the subclass, correct?

Correct!


⚠ Samsung has degraded performance

In 8fc2a4d, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2341 ms

Resolved: Samsung performance has improved in 9d6fc6e.


Bit depth of the original video

Hi,
I have a question.  As you say，the dataset is extracted from the video of HDR10 standard (10-bit, Rec.2020, PQ) and stored in 16 bit PNG .  However, when I read an HDR image with MATLAB, I found that the image contains more than 60000 pixel intensities instead of 1024. This means that this is a real 16 bit image.   Is the  original video really just 10 bits?

@gzsun1416 Yes, you can use ffmpeg or Mediainfo to check the bit depth of the video. FFmpeg can not extract images in 10-bit format.


Regenerate files

Description
Regenerate files changed in https://github.com/stackrox/stackrox/pull/1771
Testing Performed
CI

Duplicates: https://github.com/stackrox/stackrox/pull/1853


Add ABOUT.md.

Add ABOUT.md for Go as requested in http://exercism.io/languages/go.

Nice, thank you!


Compiling error

Hello!
I am getting the error below when i try to compile:
mkdir build_200_200
/usr/bin/arm-none-eabi-gcc -c -mcpu=cortex-m4 -mthumb -mfloat-abi=soft -DUSBD_VID=0x200 -DUSBD_PID=0x200 -DHW_REV= -IBSP -IApp -ICharger -ISensor -IVCP -IHidReportDef/include -IUSBDevice/Include -IUSBDevice/PDs/STM32_XPD -ISTM32_XPD/CMSIS/Include -ISTM32_XPD/CMSIS/Device/ST/STM32F4xx/Include -ISTM32_XPD/STM32F4_XPD/inc -O3 -Wall -fdata-sections -ffunction-sections -std=gnu11 -MMD -MP -MF"build_200_200/bsp_usart.d" -MT"build_200_200/bsp_usart.d" -Wa,-a,-ad,-alms=build_200_200/bsp_usart.lst BSP/bsp_usart.c -o build_200_200/bsp_usart.o
In file included from BSP/bsp_usart.c:23:0:
BSP/bsp_io.h:34:13: error: operator '>' has no left operand
#if (HW_REV > 0xA)

Forced in the Makefile
VID=200
PID=200
HW_REV=1

# Build path
BUILD_DIR = build_$(VID)_$(PID)

##++----  Target configuration  ----++##

CORE = m4
SERIES = STM32F4

and then getting :
BSP/bsp_usart.c:    NVIC_SetPriorityConfig(DMA1_Channel4_5_IRQn, 0, 0);
BSP/bsp_usart.c:    NVIC_EnableIRQ(DMA1_Channel4_5_IRQn);
BSP/bsp_usart.c:    NVIC_DisableIRQ(DMA1_Channel4_5_IRQn);
BSP/STM32F042F6.ioc:NVIC.DMA1_Channel4_5_IRQn=true\:0\:0\:false\:false\:true\:true

It seems that the code is not completellly prepared to compile use the STM32F4 MCUs right ?
DMA1_Channel4_5_IRQn is defeined in stm32f042x6.h but not  in stm32f407xx.h
Looking forward to test the code !-D

If you get a compile error on a revision that compiled on the Travis CI server, you should first check the differences between your make arguments to the ones in .travis.yml. In your case the problem was not assigning the HW_REV any numeric value.
This project was made for this specific MCU (STM32F042) because this is the cheapest that can do the job. Of course the application is reusable, all you need to do is duplicate my BSP folder and replace the hardware bindings to your platform. Other projects have an STM32F4 BSP, e.g. this one. If you only intend to use the USB-UART relay, you only have to modify the pin, IRQ and DMA assignments, and also fill the Channel field of the DMA init structure.

Thank you !
We are developing using the STM32F4 Discovery board, so We are using the stm32f407vgt6 MCU .
We are working in a huge system and we will need to implement a USB composite device, so searching i've found your code. It seems to be an awesome solution .
Do  you have some documents about the code, so we could minimize the learning curve and help you with the development ?
Anyway it seems to be a very good approach to implement composite devices using the STM32 MCU family.
ps: After the development, resolving the all technical issues, we will get the cheapest MCU too.

Do you mean the USBDevice stack or this DebugDongle project in particular?
It also depends on the use case, so are you developing further device classes, or in any way extending the stack? If not, then the examples and the doxygen documentation should be enough. Generally about the USB operation you can find good resources online (e.g. USB Made Simple / USB in a Nutshell). I mainly relied on the official USB specifications when writing the library, they are available online as well.

I meant the USBDevice !
I am using the STM32F4 because we need to have USB HOST;  it will be used to connect  smartphones.
We are using the same books, but we are still learning how to develop the code using the STM32 MCUs. The stm32 cubex makes this task easier, but we still need to create a USB composite device and what you made seems to be awesome !
It is very difficult to find information specific about how to implement composite devices with  stm32 MCUs !

Well in case you want to consult me on specific USB or STM32 related topics you can contact me via email, it's listed on my profile.

If it will not bother you, soon i would like to ask you some help !
Thank you !


Obsidian shows error "Can't find heading" after triggering the popclip extension

I was happy to see that a popclip extension to directy save my (pop)clippings to my Obsidian vault.
I am experiencing the same issue as reported here, though.
I proceeded according to your description, thus popclip extension is accessible and I also set the options for Obsidian clipper.

WHEN I select text from a website
AND click the O icon from the popclip menu
THEN Obsidian throws an error "can't find heading" as explained above.

Any idea what might be missing in the set up or how I can fix this?
Many thanks in advance! 🙏🏻
Originally posted by @GitVolk in https://github.com/canburaks/obsidian-popclip/issues/1#issuecomment-1748498409

@GitVolk what happens when you change location relative to the root directory of your obsidian vault? Because the extension sends the selection directly to the Obisidan, there is no need to pass full location.
/ refers to the root of the vault.
Let me know if it fixes or not.

Not sure if I got you right but replacing the full path to the vault with just the / does not change anything.
Nothing I put in there seems so make a difference, I am afraid.
The "error message" remains the same.
(What heading is supposed to be found by the way...🤔?)
And where would the appended text be put?
Would a new note be created? Would it be appended to the daily note or to any "fixed" note that needs to be pre-created?
As an "ordinary" non-dev user I cannot figure that out from the code, I am sorry.
Any other idea what could fix the problem.

The heading argument comes from the Popclip extension and must match the extension name. Otherwise, it causes unexpected bugs. I've added an option to disable that check.
You can turn off the Popclip Heading option and test it. Please take a backup before the test.
Please let me know if it works or not. @GitVolk @ethanchengyu

i do not think it works

@ethanchengyu What is the name of the extension in the folder? Also, on which website do you get the error?

@ethanchengyu Could you update re-install the popcip extension and try with it?
# PopClip - Obsidian extension, markdown variant
name: ObsidianClipper
icon: O
capture html: true
options:
- identifier: "vault"
  label: "Vault name"
  type: string
- identifier: "path"
  label: "Location"
  type: string
javascript: |
    const vaultName = encodeURIComponent(popclip.options.vault)
    const fileLocation = encodeURIComponent(popclip.options.path)
    const data = {
      clipping: popclip.input.markdown,
      path: fileLocation || undefined,
    }
    let clipping = popclip.input.markdown
    if (popclip.context.browserUrl.length > 0) { // append markdown source link if available
      data["title"] = popclip.context.browserTitle
      data["source"] = popclip.context.browserUrl
    }
    clipping = encodeURIComponent(JSON.stringify(data))
    popclip.openUrl(`obsidian://advanced-uri?vault=${vaultName}&daily=true&data=%0A${clipping}&mode=append`)
#end

oh
after re-install the popcip extension, it works
by the way, how can i change the location in my daily md, it is below now


Doesnt link after building. No logs as well.

After using this jdk on the Gluon Client Documentation Website and Client maven plugin 0.1.21, this is the output of mvn clean client:build
root@DESKTOP-86UB10V:/mnt/d/Coding/Java Projects/indiachan# mvn clean client:build
WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by com.google.inject.internal.cglib.core.$ReflectUtils$1 (file:/usr/share/maven/lib/guice.jar) to method java.lang.ClassLoa
der.defineClass(java.lang.String,byte[],int,int,java.security.ProtectionDomain)
WARNING: Please consider reporting this to the maintainers of com.google.inject.internal.cglib.core.$ReflectUtils$1
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release
[INFO] Scanning for projects...
[INFO]
[INFO] -------------------< com.github.dubbadhar:indiachan >-------------------
[INFO] Building indiachan 1.0
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ indiachan ---
[INFO] Deleting /mnt/d/Coding/Java Projects/indiachan/target
[INFO]
[INFO] -------------------< com.github.dubbadhar:indiachan >-------------------
[INFO] Building indiachan 1.0
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- client-maven-plugin:0.1.21:build (default-cli) @ indiachan ---
WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by com.google.inject.internal.cglib.core.$ReflectUtils$1 (file:/usr/share/maven/lib/guice.jar) to method java.lang.ClassLoa
der.defineClass(java.lang.String,byte[],int,int,java.security.ProtectionDomain)
WARNING: Please consider reporting this to the maintainers of com.google.inject.internal.cglib.core.$ReflectUtils$1
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release
[INFO] Scanning for projects...
[INFO]
[INFO] -------------------< com.github.dubbadhar:indiachan >-------------------
[INFO] Building indiachan 1.0
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] >>> client-maven-plugin:0.1.21:compile (default-cli) > process-classes @ indiachan >>>
[INFO]
[INFO] --- maven-resources-plugin:2.6:resources (default-resources) @ indiachan ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 1 resource
[INFO]
[INFO] --- maven-compiler-plugin:3.8.1:compile (default-compile) @ indiachan ---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 5 source files to /mnt/d/Coding/Java Projects/indiachan/target/classes
[INFO]
[INFO] <<< client-maven-plugin:0.1.21:compile (default-cli) < process-classes @ indiachan <<<
[INFO]
[INFO]
[INFO] --- client-maven-plugin:0.1.21:compile (default-cli) @ indiachan ---
[Thu Apr 23 17:19:57 IST 2020][INFO] ==================== COMPILE TASK ====================
[Thu Apr 23 17:19:57 IST 2020][INFO] We will now compile your code for aarch64-linux-android. This may take some time.

After running mvn client:link this happens:
root@DESKTOP-86UB10V:/mnt/d/Coding/Java Projects/indiachan# mvn client:link
WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by com.google.inject.internal.cglib.core.$ReflectUtils$1 (file:/usr/share/maven/lib/guice.jar) to method java.lang.ClassLoa
der.defineClass(java.lang.String,byte[],int,int,java.security.ProtectionDomain)
WARNING: Please consider reporting this to the maintainers of com.google.inject.internal.cglib.core.$ReflectUtils$1
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release
[INFO] Scanning for projects...
[INFO]
[INFO] -------------------< com.github.dubbadhar:indiachan >-------------------
[INFO] Building indiachan 1.0
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- client-maven-plugin:0.1.21:link (default-cli) @ indiachan ---
[Thu Apr 23 17:28:40 IST 2020][INFO] ==================== LINK TASK ====================
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  5.994 s
[INFO] Finished at: 2020-04-23T17:28:43+05:30
[INFO] ------------------------------------------------------------------------

There is NO apk in target/client/aarch64-android and any of its subdirectories

You have to run client:package to create the apk, and client:install to install into a plugged android device.

Understood, thanks!


feat(SDK): display Compute Modules even if host OS has no drivers

This is the first step towards full usbboot Windows support. The driver
selector dialog will now display disabled devices to represent Compute
Modules even when Windows drivers are not installed to act on them.
These drives will state "Missing drivers."
Change-Type: minor
Changelog-Entry: Display connected Compute Modules even if Windows doesn't have the necessary drivers to act on them.
Signed-off-by: Juan Cruz Viotti<EMAIL_ADDRESS>

./node_modules/.bin/npx eslint lib tests scripts bin versionist.conf.js
C:\projects\etcher\lib\shared\sdk\usbboot\usb.js
  79:5  error  Prefer _.map over a _.forEach with a push to an array inside  lodash/prefer-map
✖ 1 problem (1 error, 0 warnings)

:-/

I fixed the lint warning.

This is how it looks like atm ^

Appveyor says
rebuild-install info begin Prebuild-install version 2.3.0
prebuild-install info looking for local prebuild @ prebuilds\winusb-driver-generator-v1.1.0-node-v48-win32-x64.tar.gz
prebuild-install info looking for cached prebuild @ C:\Users\appveyor\AppData\Roaming\npm-cache\_prebuilds\https-github.com-resin-io-modules-winusb-driver-generator-releases-download-v1.1.0-winusb-driver-generator-v1.1.0-node-v48-win32-x64.tar.gz
prebuild-install http request GET https://github.com/resin-io-modules/winusb-driver-generator/releases/download/v1.1.0/winusb-driver-generator-v1.1.0-node-v48-win32-x64.tar.gz
prebuild-install http 404 https://github.com/resin-io-modules/winusb-driver-generator/releases/download/v1.1.0/winusb-driver-generator-v1.1.0-node-v48-win32-x64.tar.gz
prebuild-install WARN install No prebuilt binaries found (target=6.1.0 runtime=node arch=x64 platform=win32)
make: *** [dist/Etcher-cli-1.2.0+6ce8fea-win32-x64-app] Error 1

:-/
https://github.com/resin-io-modules/winusb-driver-generator/releases seems to have winusb-driver-generator-v1.1.0-electron-v54-win32-x64.tar.gz but not the winusb-driver-generator-v1.1.0-node-v48-win32-x64.tar.gz that is being looked for here? Ping @jhermsmeier as he seems to be familiar with the 'prebuild' stuff :wink:
TravisCI builds are passing on Linux, but failing on OSX, which is weird :-/
  1) Browser: driveScanner given windows given available drives should emit the non removable drives:
     Error: Module did not self-register.

?

Might be worth updating that screenshot, now #1900 is merged ;-)

Regarding the first prebuild error, that's happening because I'm pre-building for Electron, but not for Node.js, which we use to package the CLI. I'll update the module to provide that package.
Regarding build errors on macOS but not on GNU/Linux, remember that we don't load usbboot on GNU/Linux yet and that's why only macOS exhibits the problem. I can locally reproduce so I'll fix it soon.

Oh yeah, I hadn't even noticed that one of the prebuild filenames contains electron and the other contains node!  I'd only noticed the v54 and v48 difference :confused:

Here's the updated screenshot:

Updated! Everything should be green now.

Apologies for the delay, but I've finally got round to testing this PR on my old Win7 x64 laptop... and it seems to work fine :-)
Here's a screenshot with both a CM1 and CM3 plugged in at the same time (after I managed to get all their drivers uninstalled)

C:\projects\etcher\lib\shared\sdk\usbboot\index.js
  288:9  error  Expected line before comment  lines-around-comment
✖ 1 problem (1 error, 0 warnings)

Fixed!


chmod 755 to sh files

I have been using vim-jetpack to manage my plugins, and I found a bug which was caused by .sh files not executable in plat/unitx directory, so I change sh mod to 755

Took me a couple of hours to see that this was the issue I was having. Please include this PR asap.

@leoatchina , you should create a new branch for this pulling request, if you kept on updating your master branch.

Merged with 865d17a63b70690beee855e72abd38db278c1839, thanks!


Some examples writing text to a file?

I would like to see some simple examples for writing text to a file, especially appending.

Wait a couple more hours, I'll open a new PR and add it


n00b question: How do you get started?

I've tried running the Build.PSake.ps1 file and found that I needed to install PS5. Did that.
Now, I'm getting a new error:
The script 'Build.PSake.ps1' cannot be run because the following modules that are specified by the "#requires" statements of the script are missing: VirtualEngine.Build.
+ CategoryInfo          : ResourceUnavailable: (Build.PSake.ps1:String) [], ParentContainsErrorRecordException
+ FullyQualifiedErrorId : ScriptRequiresMissingModules
I've tried running 'Install-Module -Name VirtualEngine.Build' and I get a "no match was found" result...
What am I missing here?
I'm running a fresh install of Windows Server 2012 R2 and the current master branch.

@heartfrappe You don't need to run the PSake build script! Realistically you have 2 options:

Upgrade to WMF 5
You can then run Install-Module Lability and install from the PowerShell Gallery.
Download the Zip file
Extract it to C:\Program Files\WindowsPowerShell\Modules\ directory (or your module path).

PS C:\Users\Iain>

If you have any more problems, let me know 😃

@heartfrappe Did this help?

Closing. Please reopen if you are still struggling.


Remove unused code

I found a number of unreferenced files and have deleted them here. Please let me know if this is in error.

pouring one out


Single yAxis for linePlusBarChart

Could you please show me how to use only one y axis for linePlusBarChart? The example shown in this link have two yaxis (Y1 Axis and Y2Axis) http://plnkr.co/edit/f0QET0?p=preview
I only want to use one yaxis (Y1 Axis) for both line and bar charts.
Thanks you.

This seems to be a limitation in nvd3.  I think they intend for you to use the MultiChart.
https://nvd3-community.github.io/nvd3/examples/multiChart.html
From there, you can specify your axis in your data.  For example, this puts them on the same y axis:
vm.graph_data = [
                {
                    yAxis: 1,
                    key : "Inventory",
                    type: "line",
                    values : [ { x: 1, y: 60}, { x: 2, y: 54}, { x: 3, y: 46}, { x: 4, y: 37}, { x: 5, y: 33}, { x: 6, y: 27}, { x: 7, y: 19}, { x: 8, y: 16} ]
                } ,

                {
                    yAxis: 1,
                    key : "Movement",
                    yDomain: [0, 100],
                    values : [ { x: 1, y: 6}, { x: 2, y: 8}, { x: 3, y: 9}, { x: 4, y: 4}, { x: 5, y: 6}, { x: 6, y: 8}, { x: 7, y: 3}, { x: 8, y: 4} ]
                }
            ];

+1


Snackbar add  start icon

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Summary 💡
Add a start icon in snackbar as a prop
Examples 🌈
No response
Motivation 🔦
No response

import Snackbar from '@mui/material/Snackbar';
import Alert from '@mui/material/Alert';

const SnackbarWithIcon = ({ icon, message, alertProps, ...props }) => {
return (
   <Snackbar {...props} >
    <Alert icon={icon ?? false} {...alertProps}>
      {message}
    </Alert>
  </Snackbar>`
 )
}

Snackbar is meant to be a container for arbitrary content. See https://mui.com/components/snackbars/#customization for details on how you can modify its appearance. There is no need to add another prop to achieve what you need.


Add KeepActivityPrivate condition to showPrivate

For user public activity page is empty issue

I do not think this change is right and I haven't understood the problem.
For the new code: if KeepActivityPrivate=true, then any user can see the context user's private orgs? I do not think it's right to expose private orgs to any visitor.

This modification should be on the public activity tab, not part of the organization. It happens to use the same variable and has been moved to the public activity
Thanks

I am still not sure whether it is right. For example, context user has private activities in its private org and KeepActivityPrivate=false, should a visitor user see the activities in the private org? Is the private org exposed to the visitor by the activity feeds?

The problem is that personal public activity can only be viewed by yourself and the system administrator. It should be open to others to view, or you can set it as private

Is the private org exposed to the visitor by the activity feeds?
Does the org owner want and allow to do so?

Or where can I judge that only the same organization can browse public activity?

No idea... I don't have the knowledge at the moment. It doesn't seem to be an easy problem IMO.


correct typo validade in log output

Small typo in the output.

Hi @nerrehmit,
Thank you for the patch. Sorry for the delay. Merged!


function_call and tool_choice didn't  have "auto" feature implemented

Prerequisites
Please answer the following questions for yourself before submitting an issue.

[x] I am running the latest code. Development is very rapid so there are no tagged versions as of now.
[x] I carefully followed the README.md.
[x] I searched using keywords relevant to my issue to make sure that I am creating a new issue that is not already open (or closed).
[x] I reviewed the Discussions, and have a new bug or useful enhancement to share.

Expected Behavior
Please provide a detailed written description of what you were trying to do, and what you expected llama-cpp-python to do.
Current Behavior
Please provide a detailed written description of what llama-cpp-python did, instead.
Environment and Context
Please provide detailed information about your computer setup. This is important in case the issue is not reproducible except for under certain specific conditions.

Physical (or virtual) hardware you are using, e.g. for Linux:

$ lscpu

Operating System, e.g. for Linux:

$ uname -a

SDK version, e.g. for Linux:

$ python3 --version
$ make --version
$ g++ --version

Failure Information (for bugs)
Please help provide information about the failure if this is a bug. If it is not a bug, please remove the rest of this template.
Steps to Reproduce
Please provide detailed steps for reproducing the issue. We are not sitting in front of your screen, so the more detail the better.

step 1
step 2
step 3
etc.

Note: Many issues seem to be regarding functional or performance issues / differences with llama.cpp. In these cases we need to confirm that you're comparing against the version of llama.cpp that was built with your python package, and which parameters you're passing to the context.
Try the following:

git clone https://github.com/abetlen/llama-cpp-python
cd llama-cpp-python
rm -rf _skbuild/ # delete any old builds
python -m pip install .
cd ./vendor/llama.cpp
Follow llama.cpp's instructions to cmake llama.cpp
Run llama.cpp's ./main with the same arguments you previously passed to llama-cpp-python and see if you can reproduce the issue. If you can, log an issue with llama.cpp

Failure Logs
Please include any relevant log snippets or files. If it works under one configuration but not under another, please provide logs for both configurations and their corresponding outputs so it is easy to see where behavior changes.
Also, please try to avoid using screenshots if at all possible. Instead, copy/paste the console output and use Github's markdown to cleanly format your logs for easy readability.
Example environment info:
llama-cpp-python$ git log | head -1
commit 47b0aa6e957b93dbe2c29d53af16fbae2dd628f2

llama-cpp-python$ python3 --version
Python 3.10.10

llama-cpp-python$ pip list | egrep "uvicorn|fastapi|sse-starlette|numpy"
fastapi                  0.95.0
numpy                    1.24.3
sse-starlette            1.3.3
uvicorn                  0.21.1

llama-cpp-python/vendor/llama.cpp$ git log | head -3
commit 66874d4fbcc7866377246efbcee938e8cc9c7d76
Author: Kerfuffle<EMAIL_ADDRESS>Date:   Thu May 25 20:18:01 2023 -0600

@MoeBuTa can you elaborate a little more, which chat format, maybe a code sample?
It should be noted that because "auto" requires the LLM to choose the appropriate tool and requires some special parsing, currently it only works for some models like "functionary".

Hi @abetlen ,
It is at the line 561 of https://github.com/abetlen/llama-cpp-python/blob/main/llama_cpp/llama_chat_format.py. I would like to use the  "auto" feature to automatically call the appropriate tool I passed to the tools parameter and expected a convert_completion_to_chat_function response, but it appears that line 561 doesn't take tool_choice="auto" into consideration and do something for it.


Round vs Truncate when converting UTM -> MGRS

TL;DR - I think mgrs is rounding a value that should be truncated.
I was testing some sample data against other LL -> MGRS converters online and noticed they are behaving differently at the 5th digit of precision.
An example of this is 36.2361322, -115.0820944.
The converter at earthpoint.us gives MGRS 11SPA 72349 11844, but your forward function gives 11SPA 72349 11845 (spaces added for clarity). The UTM is listed as "11S 672349.27mE 4011844.97mN".
It appears that your tool is rounding the UTM values before converting to MGRS, whereas I believe it should be truncating/flooring. My understanding of this is definitely that of a layperson, so please correct me if I'm wrong.
The section "Truncate, don't round" of the Wikipedia MGRS article has more information about this.

this is one of those places it would help to get a second opinion as we don't necessarily know if earthpoint.us is doing it correctly

I'm not sure if there's an accepted, authoritative source of test inputs and outputs, or a converter that is "blessed" by some authority for being accurate.
Here are a few examples of other converters which show behavior that differs from your mgrs output in the way I have described:

http://geographiclib.sourceforge.net/cgi-bin/GeoConvert

http://legallandconverter.com/p50.html

http://www.movable-type.co.uk/scripts/latlong-utm-mgrs.html

yeah I know there isn't any canonical authority hence I just try to do a 'vote' of different libraries

Yeah, for sure. Whether you change it or not, thanks for your consideration and speedy response.

According to this:
https://en.wikipedia.org/wiki/Military_Grid_Reference_System
the values should be truncated, not rounded. The rationale behind this is

When changing precision levels, it is important to truncate rather than round the easting and northing values to ensure the more precise polygon will remain within the boundaries of the less precise polygon.

Having worked with MGRS a lot, truncation is the correct answer.  The reference from Wikipedia by @noberasco gives a clear explanation on why to truncate.  Since it's Wikipedia, @calvinmetcalf is right to want a source for the decision.  Since MGRS is a DoD coordinate system and the NGA is the DoD's geospatial authority, the NGA is the authority on MGRS.  A Google search of mgrs truncate site:nga.mil will pull up articles mentioning truncation, but nothing that clearly settles the issue.  However, if we look at the source code for GEOTRANS, we will see how the NGA implements their MGRS manipulations.
GEOTRANS is the NGA's "DoD coordinate conversion and datum transformation software."  In the makeMGRSString() function of GEOTRANS 3.7 (the latest version published), we get the answer on lines 332 and 337.  We can see where a value called precision is used to create a value called divisor.  Divisor is then used to move the decimal point left the needed amount.  Finally, the result is truncated by casting it from a double float to a long integer.
Thank you for all your great work on this library!

Hi, all.  It appears that NGA changed things with their new release of GEOTRANS, version 3.8.  Basically, they are now using the center of the box instead of the bottom left when calculating the lat/long.  Please see this PR, which provides more context https://github.com/proj4js/mgrs/pull/60 and here's a link to NGA: https://earth-info.nga.mil/GandG/update/index.php?action=home.
Also, if you find it useful, here's a link to a docker repo that includes a re-run of the Spreadsheet Tests for GEOTRANS: https://hub.docker.com/repository/docker/geodesy/geotrans.
Happy to discuss further.  Please comment or open a new issue if there's more to discuss on this topic.  Thanks again.


Example t8_step5_element_data.jl fails when writing VTK

I am using Julia v1.9.3 on macOS (ARM architecture). I cloned T8code.jl, activated the examples folder as project with T8code.jl and MPI.jl as dependencies:
(examples) pkg> st
Status `~/.julia/dev/T8code/examples/Project.toml`
  [da04e1cc] MPI v0.20.15
  [d0cc0030] T8code v0.4.1 `..`

The examples step0 to step4 run without problems. However, julia --project=. t8_step4_partition_balance_ghost.jl crashes with the following message
[t8]  [step5]
[t8]  [step5] Hello, this is the step5 example of t8code.
[t8]  [step5] In this example we will store data on our elements and exchange the data of ghost elements.
[t8]  [step5]
[t8]  [step5]
[t8]  [step5] Creating an adapted forest as in step3.
[t8]  [step5]
[t8] Constructed uniform forest with 8192 global elements.
[t8] Into t8_forest_adapt from 8192 total elements
[t8] Done t8_forest_adapt with 3089 total elements
[t8] Enter  forest partition.
[t8] Done forest partition.
[t8] Into t8_forest_balance with 3089 global elements.
[t8]  Computed maximum occurring level:	4
[t8]  Into t8_forest_ghost with 3089 local elements.
[t8]  Done t8_forest_ghost with 3089 local elements and 0 ghost elements.
[t8]  Profiling: 0
[t8]  Into t8_forest_adapt from 3089 total elements
[t8]  Done t8_forest_adapt with 3089 total elements
[t8] Done t8_forest_balance with 3089 global elements.
[t8]  [step5] Wrote forest to vtu files: *
[t8]  [step5] Computed level and volume data for local elements.
[t8]  [step5] Element 0 has level 2 and volume 3.255208e-04.
[t8]  [step5] Exchanged ghost data.
[libsc 0] Caught signal SEGV
[libsc 0] Abort: Obtained 21 stack frames
[libsc 0] Stack 0: 0   libsc.2.dylib                       0x0000000116895d44 sc_abort_handler + 100
[libsc 0] Stack 1: 1   libsc.2.dylib                       0x0000000116895e54 sc_abort + 20
[libsc 0] Stack 2: 2   libsc.2.dylib                       0x0000000116897994 sc_signal_handler + 100
[libsc 0] Stack 3: 3   libsystem_platform.dylib            0x0000000182d56a24 _sigtramp + 56
[libsc 0] Stack 4: 4   libt8.2.dylib                       0x0000000116f53d9c t8_forest_vtk_write_file + 2796
[libsc 0] Stack 5: 5   ???                                 0x000000011696c11c 0x0 +<PHONE_NUMBER>
[libsc 0] Stack 6: 6   ???                                 0x00000001169743d0 0x0 +<PHONE_NUMBER>
[libsc 0] Stack 7: 7   libjulia-internal.1.9.dylib         0x000000010531a4ec do_call + 188
[libsc 0] Stack 8: 8   libjulia-internal.1.9.dylib         0x0000000105318d10 eval_body + 1476
[libsc 0] Stack 9: 9   libjulia-internal.1.9.dylib         0x000000010531935c jl_interpret_toplevel_thunk + 260
[libsc 0] Stack 10: 10  libjulia-internal.1.9.dylib         0x000000010533059c jl_toplevel_eval_flex + 4620
[libsc 0] Stack 11: 11  libjulia-internal.1.9.dylib         0x00000001053304c0 jl_toplevel_eval_flex + 4400
[libsc 0] Stack 12: 12  libjulia-internal.1.9.dylib         0x00000001053312e4 ijl_toplevel_eval_in + 156
[libsc 0] Stack 13: 13  sys.dylib                           0x000000013c40d5f4 japi1_include_string_36282.clone_3 + 520
[libsc 0] Stack 14: 14  libjulia-internal.1.9.dylib         0x00000001053015c4 ijl_apply_generic + 1732
[libsc 0] Stack 15: 15  sys.dylib                           0x000000013b0d0b48 japi1__include_47977 + 824
[libsc 0] Stack 16: 16  sys.dylib                           0x000000013af6c00c julia_exec_options_50544 + 21780
[libsc 0] Stack 17: 17  libjulia-internal.1.9.dylib         0x0000000105358644 true_main + 192
[libsc 0] Stack 18: 18  libjulia-internal.1.9.dylib         0x0000000105358538 jl_repl_entrypoint + 180
[libsc 0] Stack 19: 19  julia                               0x0000000104d57f6c main + 12
[libsc 0] Stack 20: 20  dyld                                0x00000001829cff28 start + 2236
application called MPI_Abort(MPI_COMM_WORLD, 1) - process 0
[unset]: PMIU_write error; fd=-1 buf=:cmd=abort exitcode=1 message=application called MPI_Abort(MPI_COMM_WORLD, 1) - process 0
:
system msg for write_line failure : Bad file descriptor

Noted. Looks like a problem on MacOS platforms?

Could very well be the case. I haven't  checked it on other systems. The previous examples using pre-defined VTK output functions work well, though.


Feature Request: Function Signature Args and Linking in "Motokodoc"

Could someone could point me to the file that handles the "Motokodoc" formatting and logic (particularly for the tooltip popup on hover that shows up when a field as the Motokodoc comment header)?
In particular I'd like to add autogeneration/highlighting for argument and return signature, as well the ability to point the comment to another Motokodoc comment.

Additionally if a header format was specified for candid, those two could be linked to avoid duplication of documentation.

Here is the relevant logic in the language server:
https://github.com/dfinity/vscode-motoko/blob/72eb00b61917751e3dba9ab017409d3146d80d5e/src/server/server.ts#L1064-L1078
The "go-to-definition" logic (for pointing to other doc comments) is implemented here:
https://github.com/dfinity/vscode-motoko/blob/72eb00b61917751e3dba9ab017409d3146d80d5e/src/server/navigation.ts#L320
Because doc comments are currently discovered via AST traversal, the language server might need some refactoring to fully achieve what you're suggesting. Feel free to create a docs.ts file for any required helper functions, and I'll eventually move the rest of the onHover() logic into this file as well.
I would also recommend turning on "Debug Hover" in the extension settings, which shows some additional AST information in the hover tooltips.
Let me know if you run into any roadblocks, and I'll do my best to help out.

Closing as not currently planned (feel free to reopen individual requests with more details if needed).


Add environment variables to control cors configuration in docker images

The image uses the cors package from npm. The package is really configurable, check out
cors on npm. We need to think which configurations make sense and what is the best way to allow people to control them. If #58 is done before this it might affect the solution to this issue.

Is there any reason to add more than "allowed origins"? I'd assume that browser apps should only fetch packages/components. Maybe even the default should be "*", since it's very similar to how browser fetch scripts/components from works from different domains.

Using * as the default definitely makes sense. I guess that allowed origins are the only thing that makes sense to configure. I’d say that most users indeed will go with a catch-all configuration. Bottom line: I think you’re right :)


Overwriting Registration

Fairly certain this is changed behavior from v3. Not sure if this is intended or not.
Here's a gist of the issue. The last two tests fail.
https://gist.github.com/dcomartin/6cc581c36cee7ac0cdd79af6d3d42257
It appears that if you specify T2 in RegisterType, an injection factory isn't used.
If you then try and overwrite that registration, it won't.

Is this related issue that was resolved in this release? https://github.com/unitycontainer/container/releases/tag/<IP_ADDRESS>

Sometimes it pays to look at other issues for the answer :)
Duplicates: unitycontainer/container#35, unitycontainer/unity#159, unitycontainer/unity#163, unitycontainer/container#38
Yes, these related to the fix you mentioned.
As explained here and here registration container.RegisterType<IFoo, Foo>(new InjectionFactory(x => foo1)); does not make sense from Unity standpoint.
I should probably add code to capture this condition and report error.

I did mention the resolved issue, and that does explain container.RegisterType<IFoo, Foo>(new InjectionFactory(x => foo1));.
However my last tests I do not see a related issue nor does it explain to to me.  Maybe I'm not understanding correctly.

Yes, there is an issue. The Mapping from first registration is not cleared properly.
Will fix shortly.

Fixed in v5.3.2

Added exception for registering container.RegisterType<IFoo, Foo>(new InjectionFactory(x => foo1));


Oop school library day one

Pull Request Description
Overview
This pull request introduces three new Ruby classes: Person, Student, and Teacher. These classes are designed to represent individuals with specific attributes and behaviors, and they are organized into separate files for better code organization.
Changes Made

Person Class:

Added the Person class with instance variables @id, @name, and @age.
Implemented a constructor that accepts name, age, and parent_permission as parameters, with default values.
Created getters for @id, @name, and @age.
Added setters for @name and @age.
Implemented a private method of_age? that checks if the person is of age (18 or older).
Added a public method can_use_services? that returns true if the person is of age or has parental permission.

Student Class:

Added the Student class, which inherits from Person.
Extended the constructor to include a classroom parameter.
Implemented a method play_hooky that returns "¯\(ツ)/¯".

Teacher Class:

Added the Teacher class, which also inherits from Person.
Extended the constructor to include a specialization parameter.
Overrode the can_use_services? method to always return true.

Files Affected

person.rb: Contains the Person class definition.
student.rb: Contains the Student class definition.
teacher.rb: Contains the Teacher class definition.

Hi @henask12
Approved 🟢 🟢
Your project is complete! There is nothing else to say other than... it's time to merge it :shipit: Congratulations! 🎉

Highlights

Created different files for Person, Student, and Teacher class ✔✔
All class methods implemented correctly ✔
Added getter and setter methods for instance variables ✔

Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


Add a flag to show anchor offsets [phab:D2164]

Created by zarko at 2018-02-02 22:18:32:

fromberger accepted this revision at 2018-02-02 22:20:36

zarko closed via commit 82964297aefbfc3a9923c2d563aee4c98a779363 at 2018-02-02 22:40:45


README improvements

As discussed in #173 this aims to lead users more directly to setup instructions for a fully fledged setup and also add more description about the scope of Selectrum. The new wiki section has yet to be written. Maybe it shouldn't be a subsection, we could put it at right on the wiki home page so it is the first thing people see when navigating to the wiki.

Great start @clemera. I just added a couple of very minor suggestions, which involve splitting paragraphs to better highlight key things new users might look for.

Thanks, @bdarcus! Related to providing more guidance for setup I also opened a PR for prescient to make it easier to selectively configure only sorting/filtering.

One thing I was wondering: Can we provide a quick start/tryout script? I thought about adding something like this to the consult readme, but it should be started with emacs -Q in a separate isolated emacs directory such that it does not mess with an existing installation. Something like this:
(package-initialize)
(setq package-archives '(("melpa" . "https://melpa.org/packages/")))
(package-refresh-contents)
(package-install "selectrum")
(package-install "orderless")
(package-install "consult")
(selectrum-mode)
(setq completion-styles '(orderless))

This does not work since the package-install calls are wrong and I also don't know how to instruct emacs to use a separate directory. I know that there exists chemacs and other full blown solutions, but I wanted to have something simpler. Do you know how to do this?

emacs -Q --some-start-in-directory-option ~/emacs-try-selectrum
run the script from above
Play with a few commands

@minad I'm using emacs-sandbox for such things, looking at the source it seems all you need to do would be:
emacs -Q --eval "(setq user-emacs-directory \"$dir\")" -l /path/to/script.el

I am not interested in requiring additional scripts.
Th easiest solution for now is to just package-install the required packages within your existing setup, then start emacs -Q and then execute a minimal script as shown in https://github.com/minad/consult#bug-reports. But this way you don't get isolation unfortunately.
I will try the example you just showed. I tried the EMACS_USER_DIRECTORY environment variable, but this didn't work.

Okay, this works:

Create file test-selectrum-consult.el

(setq user-emacs-directory "/tmp/emacs-test/")

(package-initialize)
(setq package-archives '(("melpa" . "https://melpa.org/packages/")))
(package-refresh-contents)

(package-install 'selectrum)
(package-install 'orderless)
(package-install 'consult)

(setq completion-styles '(orderless))

(selectrum-mode)

Run the following on the shell:

$ /usr/bin/emacs -Q -l test-selectrum-consult.el

However on my system I am hitting #435 now :crying_cat_face:

This works instead of -Q, as I already mentioned in #435:
$ /usr/bin/emacs  -q --no-site-file --no-site-lisp --no-splash -l test-selectrum-consult.el

IWe could put those starter scripts into the Selectrum/test folder, it would be nice to automatically have these when cloning Selectrum I guess. On the wiki we could then only link to these scripts.

@clemera This sounds good. From my perspective these are the interesting combinations:

selectrum+prescient+consult+embark+embark-consult+marginalia
selectrum+orderless+consult+embark+embark-consult+marginalia
icomplete-vertical+orderless+consult+embark+embark-consult+marginalia

Regarding icomplete-vertical, it would be understandable if you wouldn't want that script here. But I see it as a reference implementation useful for crosschecking. I am usually using Selectrum as you know and switch to Icomplete for testing.
Do you want me to prepare a PR?

When using orderless, we can sill include prescient for sorting, if your are motivated for this I'm happy to get a PR, but I can do it later, too.

Okay, I will prepare a PR later. I will then also link from the consult readmd to the scripts.

Regarding prescient+orderless I would love to wait until your Prescient PR is merged :)

Yes, no hurry we can wait for that.

I actually used this as part of the justification for my bibtex-completion PR, as I think it's a feature. Perhaps you should mention it explicitly?

You could consider it a feature in some sense. By collaborating closely we can sync the projects and ensure that interfaces are compatible. It even allows us to experiment with completing-read extensions like x-group-function. By ensuring that each project keeps a narrow scope, we keep everything reusable and composable. We have different responsibilities, each project has a different maintainer. This distributes the load and ensures that the boundaries are not violated. If a single maintainer maintains everything, you are much quicker to fix a problem in one package with a hack in another package. This is where the danger lies regarding close collaboration. I applied a series of refactorings to Selectrum recently, so I am also more familiar with the internals here now. During the initial development of Consult, I treated Selectrum mostly as a blackbox, which was good. So we have to be careful that the projects do not grow together too much. There have been many steps in the right direction, in particular that Selectrum does not expose its main API anymore and only relies on completing-read now.

What about:

The above packages work well in combination and we are collaborating
with each other to ensure an optimal experience while not introducing
any hard dependencies. Our common denominator is the standard Emacs
API.

Perfect.

Also added the instructions for the prescient/orderless combinations, waiting for the prescient PR to merge now.


PR requirements & template

We need a a brief Wikipedia for the requirements of PR(pull request), like coding norms, descriptions of commits, etc. So we can better collaborate.

I think descriptions of commits are needed and I will try to set up Pylint later as coding norms. I am not familiar with PR. Maybe you can make some rule there?

Hi I think GPT has given a quite good suggestion on this issue together with a PR template.
I will implement the template if you like it.
But before that, we need to determine a standard for code norm. Pylint is good to me. Maybe you can consult other team mates before make decision.
Answer from GPT4:
Certainly! The concept of a pull request (PR) template is centered around improving code quality, ensuring clarity and understanding among contributors, and easing the process of code review. Instituting a standard PR template can greatly benefit the development process by setting clear expectations and reducing the likelihood of incomplete or suboptimal contributions.
Why Use a PR Template?

Consistency: A standard format for all pull requests makes it easier to understand and review.
Efficiency: Reduces back-and-forth by requesting all necessary information upfront.
Documentation: Provides a consistent history of changes which can be valuable for future reference.
Code Quality: Ensures contributors have checked, tested, and verified their changes.
Education: Reminds new contributors of the necessary steps and checks.

Standard Sections for a PR Template:

Title/Description: A clear, concise summary of what the PR achieves.

Issue/Task Link: Reference to any associated tickets, issues, or tasks that this PR addresses. This provides context for why the change is necessary.

Type of Change: Whether it's a bugfix, feature, documentation update, etc.

Testing: Explanation of what testing was done, how to reproduce any tests, or why testing wasn't needed.

Checklist: A list of tasks that the author confirms they've completed. This can include:

[ ] Code follows the project's style guide.
[ ] Code has been commented, particularly in hard-to-understand areas.
[ ] Changes are added to the documentation.
[ ] Tests have been added to verify the change.
[ ] All new and existing tests passed.

Screenshots: Especially for UI changes, a visual representation can be invaluable.

Additional Context: Any other information that might help reviewers understand the PR.

Sample PR Template:
### Description

[Description of the pull request. Should be a clear and concise description of what the PR achieves.]

Fixes #[issue-number]

### Type of Change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Documentation update

### Testing

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

### Checklist:

- [ ] I have followed the project's style guidelines.
- [ ] I have commented my code, particularly in hard-to-understand areas.
- [ ] I have made corresponding changes to the documentation.
- [ ] My changes generate no new warnings or errors.
- [ ] I have added tests that prove my fix is effective or that my feature works.
- [ ] All new and existing tests passed.

### Screenshots (if appropriate)

### Additional Context

Final Thoughts:
While the above is a general template, it's important to adapt it based on the specific needs of your project. Some projects might need additional sections or have unique guidelines. It's also essential to periodically review and update the template based on the feedback from contributors and changes in the development process.
Remember that a PR template is a tool. It's meant to be helpful, not restrictive. The goal is to facilitate clearer communication and maintain the quality of the codebase.


Add support for arm7 in installer (0.0.4)

Would you mind, if I merge this into the 0.0.4 branch? Then, we can merge the collected branch when releasing 0.0.4.

Sounds good!

Good, I'll close this PR then.

Merged gek/add-arm7-installer into 0.0.4 with 75647b3.


[Quarkus] Update description and fix support dates

Use the Security Policy instead of the Release Planning for releasePolicyLink. The Security Policy provides better information on supported versions.
Remove eol and support dates for the last version. Those dates are not predictable.
Update eol and support dates for all but the last versions. eol and support dates for a version X are releaseDate of the X+1 version.
Update description : provide better information for the community version, and add a paragraph describing the Red Hat build of Quarkus (RHBQ).

If only a single patch release is supported at a single time, maybe we should collapse this into one-row=major-version?
Unless the project treats each minor release as major (like Go/K8S) - this would make the page easier to use.

That sounds reasonable

Ok, will do that.

@captn3m0, done.

@marcwrobel could you rebase your PR after merging #1851

@usta, @adriens : after a discussion with @captn3m0 it was decided to keep only the last 0.x and 1.x (see https://github.com/endoflife-date/endoflife.date/pull/1846#issuecomment-1310567404). This PR already implements that, so what is being done in #1851 is a duplicate of that work.
I suggest merging this PR instead of #1851, because merging #1851 first would introduce a lot of conflicts due to the support dates fix. #1851 is a duplicate and can be closed without merging it.

@captn3m0 @marcwrobel  i am agaist keeping a random version , if we keep it like 0.88 or 1.77 we sould at least do it correct way look like in #1851 , ( it can be done in this PR [and close that one] )

would introduce a lot of conflicts due to the support dates fix. #1851 is a duplicate and can be closed without merging it.

I couldnt get this one , how can it conflicts ?

@usta, those are not random versions, they are the last in 0.x and 1.x branches. But I get your point and I also think putting 0.x and 1.x in the releaseCycle has more meaning.
As for the conflicts I fear that if #1851 is merged on master before this PR it would introduce conflicts when I rebase this PR. We are changing the same lines in the same file. So I think it's better to avoid that and finishing the work in this PR.

@usta,  releaseCycle updated to 0.x and 1.x with :

releaseDate : date of the first version in the release cycle,
latestReleaseDate : date of the last version in the release cycle.

I also adjusted eol and support dates to use the following rule : eol and support dates for a given releaseCycle are the greater date between its latestReleaseDate and the releaseDate of the next releaseCycle. As ans exemple here is what as been done for releaseCycle 2.1:

releaseDate of 2.1 : 2021-07-22
latestReleaseDate of 2.1 : 2021-08-26
releaseDate of 2.2 : 2021-08-25
=> eol and support dates of 2.1 = MAX(latestReleaseDate of 2.1, releaseDate of 2.2) = 2021-08-26

I think it makes more sense that way, what do you think ?

#1851  Closed for this PR

Hi guys, awesome collab' job and thanks a lot for the Quarkus discussion, it looks far much better now :ok_hand:

...


Curve Designer breaks with unity versions below 2020

This is because Sampler's use generic types inside a list, which unity versions prior to 2020 do not serialize correctly.

should be fixed by 25cfa6f890b8551ab38862fb836c02a3b3f37e13


Everything is an illegal request

First, can't get past the setup Screen, "illegal request" error.
Do a refresh and the Dashboard appears, but broken with another "illegal request" error.
Clicked on the profile, then on logout. Another error came out:
{"success":false,"error":{"code":"Illegal request","message":"Illegal request","title":null}}
Feels like the anti-CSRF code going amok

try this URL https://localhost:443 , it's works for me , i hope for you too :)

I just figured it out. My docker file was using localhost:port but my actual URL was 192.168.1.xx:port.
I had to edit the docker file to the exact URL I was using (not localhost) and then it worked.


Add request_host to default stats tags

Add request host header to default stats tags. istio/istio#21820
cc @jshaughn

@mandarjog what will Envoy filter look like if we need to customize metrics for e.g. add destination port at all proxies but request host only at sidecars? Can we document it?

EnvoyFilter could distinguish inbound/outbound/gateway proxies so different customization could be applied accordingly. I will add that to the doc in istio.io


Running Android RN app on Travis

For some reason the BundleReleaseJsAndAssets task isn't called.
I had the same issue on my local machine, but I managed to track the issue and fix it:
https://github.com/facebook/react-native/issues/7258#issuecomment-215176661
Anyone had any experience running an Android RN app on travis and can share his travis.yaml ?
Maybe I'm missing something I have to add.

Turned out to be a problem with react.gradle not supporting flavor dimensions well.


fix(icon-assets): Bug fixes not accounted for when consuming

This project uses semver, please check the scope of this pr:

[ ] #none# - documentation fixes and/or test additions
[x] #patch# - backwards-compatible bug fix
[ ] #minor# - adding functionality in a backwards-compatible manner
[ ] #major# - incompatible API change

CHANGELOG

treeForPublic might not exist, check if it is there before attempting to merge
Fix logic surrounding fetch request resolved, so load icons based on cached asset map

Changes Unknown when pulling 5f66487307ff5bfa5f6cebbd1694c9260b5b1580 on srowhani:feature/async-icon-fingerprinting into ** on ciena-frost:master**.

:+1:


ReplicateTable are not getting created in the new Replica

Whenever we increase replication, from operator logs i see that it's running below query to find which tables to create in new replica
 SELECT DISTINCT
        database AS name,
        concat('CREATE DATABASE IF NOT EXISTS ', name) AS create_db_query

It often results in a message like
Creating replicated objects: []

Even though there are many replicated tables, it doesn't create any. Manually running the generated query in clickhouse gives the correct result.
Can someone point out what may be the issue here?

@phatak-dev , what is your operator version and ClickHouse version? There was a bug in operator 0.7.0 an earlier, but it should be good now.

@alex-zaitsev I am using latest (0.9) operator version and clickhouse version <IP_ADDRESS>

@phatak-dev , that could be an issue with the old ClickHouse version you are using.
We recommend using Altinity stable versions, see releases there: https://www.altinity.com/blog/tag/Releases
We have not tested operator extensively for ClickHouse before 19.11 version. I will test with <IP_ADDRESS> to see if we can reproduce the problem.

@phatak-dev , I could not reproduce it in <IP_ADDRESS> version. Could you give me an example of Replicated table you are using?

Below are the tables. One is replicated and one is distributed
CREATE TABLE events_local on cluster '{cluster}' (
    event_date  Date,
    event_type  Int32,
    article_id  Int32,
    title       String
) engine=ReplicatedMergeTree('/clickhouse/{installation}/{cluster}/tables/{shard}/{database}/{table}', '{replica}')
PARTITION BY toYYYYMM(event_date)
ORDER BY (event_date, intHash32(article_id))
SAMPLE BY intHash32(article_id);

CREATE TABLE events on cluster '{cluster}' AS events_local
ENGINE = Distributed('{cluster}', default, events_local, rand());

It works the first time when I increase from 1 to 2 replicas. But when I reduce to 1 and increase to 2 again the tables will be not created.

@alex-zaitsev Tested with <IP_ADDRESS> also. It has same issue. I am running the operator on a AWS kops cluster.

@alex-zaitsev Is the below bug may be causing the issue?
https://github.com/ClickHouse/ClickHouse/issues/7268

@alex-zaitsev With the new version of clickhouse, I see below error at the creation of the new replica
2020.02.25 09:30:53.616041 [ 25 ] {} <Error> Cluster: Poco::Exception. Code: 1000, e.code() = 0, e.displayText() = Host not found: chi-
repl-05-replicated-0-1 (version <IP_ADDRESS> (official build)
2020.02.25 09:30:53.618419 [ 25 ] {} <Error> Cluster: Poco::Exception. Code: 1000, e.code() = 0, e.displayText() = Host not found: chi-
repl-05-replicated-0-1 (version <IP_ADDRESS> (official build)
2020.02.25 09:30:53.620209 [ 25 ] {} <Error> Cluster: Poco::Exception. Code: 1000, e.code() = 0, e.displayText() = Host not found: chi-
repl-05-replicated-0-1 (version <IP_ADDRESS> (official build)

@alex-zaitsev In the newly created pod, I see below error
2020.02.25 09:53:44.849122 [ 6 ] {} <Debug> DDLWorker: Will not execute task query-0000000000: There is no a local address in host list

@phatak-dev , could you share your ClickHouseInstallation resource, please?

@alex-zaitsev
apiVersion: "clickhouse.altinity.com/v1"
kind: "ClickHouseInstallation"

metadata:
  name: "repl-05"

spec:
  defaults:
    templates:
      dataVolumeClaimTemplate: default
      podTemplate: clickhouse:19.16
 configuration:
    zookeeper:
      nodes:
      - host: zookeeper.zoo1ns
    clusters:
      - name: replicated
        layout:
          shardsCount: 1
          replicasCount: 1
  templates:
    volumeClaimTemplates:
      - name: default
        reclaimPolicy: Delete
        spec:
          accessModes:
            - ReadWriteOnce
          resources:
            requests:
                    storage: 300Mi
    podTemplates:
      - name: clickhouse:19.16
        spec:
          containers:
            - name: clickhouse-pod
              image: yandex/clickhouse-server:<IP_ADDRESS>

@alex-zaitsev Once in a while, I get below error when I create the first pod
0225 11:51:15.299328       1 controller.go:497] ERROR update CHI (default/repl-05): "Operation cannot be fulfilled on clickhouseinstallations.clickhouse.altinity.com \"repl-05\": the object has been modified; please apply your changes to the latest version and try again"
I0225 11:51:15.299366       1 worker.go:169] UNABLE to write normalized CHI (default/repl-05). It can trigger update action again. Error: "Operation cannot be fulfilled on clickhouseinstallations.clickhouse.altinity.com \"repl-05\": the object has been modified; please apply your changes to the latest version and try again"

@phatak-dev , this is some sort of race condition. It does not affect the operator's functionality.

@alex-zaitsev tested the code in minikube. It works perfectly fine.

@alex-zaitsev Whenever there is dropped table, I am getting context cancelled error in clickhouse-operator side.

@alex-zaitsev Commenting out defer cancel()  in  func (c *Conn) Query(sql string) (*sqlmodule.Rows, error)  of connection.go file seems to be fixing the issue. As I am not expert in go, not sure what may be this doing and what am I doing correct or not. My current understanding is context getting closed much earlier than actual rows are read.

@phatak-dev , it is a recommended practice to call defer cancel() once context is acquired:
https://stackoverflow.com/questions/44393995/what-happens-if-i-dont-cancel-a-context
defer ensures it is called after returning from the surrounding function. So the code looks safe to me.

As mentioned on "https://github.com/Altinity/clickhouse-operator/blob/master/docs/schema_migration.md"
After cluster is scaled up and new ClickHouse instances are ready, clickhouse-operator automatically creates schema.
If replica is added:
Other replicas at the same shard are analyzed for replicated tables
Databases for replicated tables are created
Replicated tables are created
Then the same logic as to adding shard applies
I am using latest version of altinity operator and clickhouse server.
I deployed clickhouse on k8s cluster with 1 shard and 1 replica. Then I created the replicated merge tree table and inserted few rows:
CREATE TABLE events_local on cluster '{cluster}' (     event_date  Date,     event_type  Int32,     article_id  Int32,     title       String ) engine=ReplicatedMergeTree('/clickhouse/{installation}/{cluster}/tables/{shard}/{database}/{table}', '{replica}') PARTITION BY toYYYYMM(event_date) ORDER BY (event_type, article_id);
Post that, I scaled the setup to have 1 more replica but I do not see schema automatically created on newly created replica pod.
Is there any specific configuration needed for autmatic schema creation on new replica? Please help as I m stuck on this and tried many things mentioned on docs like schemaPolicy, internalReplication etc.
Here is my ClickHouseInstallation yaml file content:
apiVersion: "clickhouse.altinity.com/v1" kind: ClickHouseInstallation metadata:   name: chi-1   namespace: clickhouse spec:   configuration:     zookeeper:       nodes:         - host: "zookeeper-0.zookeepers.clickhouse.svc.cluster.local"           port: 2181     clusters:       - name: chi-1         schemaPolicy:           replica: All         layout:           shards:             - name: shard0               replicasCount: 2  # it was 1 and changed 2 to add 1 more replica               internalReplication: Enabled               templates:                 podTemplate: clickhouse-stable                 dataVolumeClaimTemplate: clickhouse-data-volume     users:       default/password: password       default/profile: default       default/quota: default       default/networks/ip:         - <IP_ADDRESS>/0         - ::/0   templates:     volumeClaimTemplates:       - name: clickhouse-data-volume         spec:           storageClassName: sp-default           accessModes:             - ReadWriteMany           resources:             requests:               storage: 500Mi     podTemplates:       - name: clickhouse-stable         spec:           containers:             - name: clickhouse               image: clickhouse/clickhouse-server:23.7               resources:                 requests:                   memory: "500Mi"                   cpu: "500m"                 limits:                   memory: "1024Mi"                   cpu: "1000m"

I got the issue resolved as mentioned on this link: https://github.com/Altinity/clickhouse-operator/issues/1602


README-BUILD: Add hint for nuget.exe installation

Thank you. I thought about automatically downloading nuget.exe, like we do with other tools. This would also solve issues where nuget.exe is outdated and does not understand the nuspec. But until then, a hint in the readme is good.

In my fork, I've just added the tool to the repo and modified the PowerShell scripts, but I wasn't sure whether you'd like that.
The annoyance is that even after downloading nuget.exe, it still won't work with the current scripts as long as you don't add it to %PATH%.
Then I had thought it must be available as a dotnet tool. Then it could have been added in a dotnet tools manifest (dotnet-tools.json) and in the PS scripts you would just run dotnet tools restore - but it seems that it's not available as a dotnet tool (at least not under the names I've tried).
That's how I came to the winget command. It's a one-line solution, but the shell needs to be re-opened before it works.

We also temporarily add the other tools to the path inside our build file, and restore the original path afterwards (look for $env:Path). I don't want to force people to manually install tools. Even winget is a tool that needs to be installed. I mean, it's great, I use it a lot. But I don't want it as a dependency here, as long as Microsoft does not ship it with Windows.

Even winget is a tool that needs to be installed.

Oh, I thought it's included, don't remember that I installed it, but maybe it's been late at night..

But I don't want it as a dependency here, as long as Microsoft does not ship it with Windows.

LOL - yea, of course it doesn't make sense to resolve one dependency by requiring another one..


Ugly Scrollbar

Just downloaded and installed, noticed the scroll bar isn't being styled or modified as I would have expected and have seen in previous releases...

On hovering, moving from right to left (NOT left to right), of a very small vertical region on the right side of Hyperterm. Normal without hovering.

I'm able to reproduce following the next steps:

Open new terminal
Hover where the scroll bar is supposed to appear
Press Enter key to add a new line until the scroll bar appears
Scrollbar should look thicker and uglier than the regular one
Hover out and scroll up and the regular scrollbar should appear

Yeah I am seeing the same thing. Something like Visual Code's scrollbar would be nice :)

I can't reproduce this O.o

😿

@rauchg Is there anything I can give you to help find it?

I can reproduce as well. As a stopgap I've added  ::-webkit-scrollbar { display: none; } to the termCSS config.

I can also reproduce this.

This looks like the regular scrollbar to me:
::-webkit-scrollbar {
  background: transparent;
  width: 6px;
}
::-webkit-scrollbar-thumb {
  border-radius: 5px;
  background: grey;
}


[FEATURE] Add strict_allow_templates option for the dynamic mapping parameter

Is your feature request related to a problem?
After this PR is merged, we need to update the specification for the dynamic mapping parameter, we should add strict_allow_templates here: https://github.com/opensearch-project/opensearch-api-specification/blob/046b7d1c0c05ab472d2b30f4d041a650c5918417/spec/schemas/_common.mapping.yaml#L138
But I also found that currently we don't support runtime for that parameter, so we should remove it.
What solution would you like?
Update the specification for the dynamic mapping parameter.

i think we can close this issue by #408


ARTEMIS-2309 Alternative approach to using static map on ServerSession

I do not think it applies.  The leak is on core only.


[DNM/WIP] Add CAPI cluster labels to kubeconfig secrets

Issue:

Problem
If we upgrade to use CAPI 1.5.0 or higher its required that the secrets used for kubeconfigs contain a label cluster.x-k8s.io/cluster-name=${CLUSTER_NAME}. Without this the CAPI cluster/machine reconcilers will fail with a failed to retrieve kubeconfig secret for Cluster error.
See the CAPI migration guide: https://github.com/kubernetes-sigs/cluster-api/blob/main/docs/book/src/developer/providers/migrations/v1.4-to-v1.5.md#other
Solution
This adds the required label when we create the secret that contains the kubeconfig. A migration has also been added thats called at startup (on leader election) that will add the label to any kubeconfig secret for an RKE2 cluster
Testing
Testing is ongoing whilst its DNM/WIP
Engineering Testing
Manual Testing

Automated Testing

Test types added/modified:

Unit
Integration (Go Framework)
Integration (v2prov Framework)
Validation (Go Framework)
Other - Explain: EXPLAIN
None
REMOVE NOT APPLICABLE BULLET POINTS ABOVE

If "None" - Reason: EXPLAIN THE REASON

If "None" - GH Issue/PR: LINK TO GH ISSUE/PR TO ADD TESTS

Summary: TODO
QA Testing Considerations

Regressions Considerations

TODO
Existing / newly added automated tests that provide evidence there are no regressions:

TODO

Doh, from base.


Strange issue with /search/byperson

I was playing around with the API today, and tested the /search/byperson endpoint. It seems like something happen by fixing #97
A simple call to https://api.podcastindex.org/api/1.0/search/byperson?q=adamcurry&pretty gave me following response (I cropped it to one result):
{
    "status": "true",
    "items": {
        "14658795158": {
            "id":<PHONE_NUMBER>8,
            "title": "#409: Talking Value 4 Value with the Podfather Adam Curry",
            "link": "https:\/\/podcasters.spotify.com\/pod\/show\/tales-from-the-crypt\/episodes\/409-Talking-Value-4-Value-with-the-Podfather-Adam-Curry-e21ou69",
            "description": "
Join Marty as he sits down with Adam Curry to discuss Podcasting 2.0, Value 4 Value, Bitcoin, energy, culture, and much more.<\/p>\n

<\/p>\n
Adam Curry on Twitter: https:\/\/twitter.com\/adamcurry<\/p>\n
No Agenda Show: https:\/\/www.noagendashow.net\/<\/p>\n

<\/p>\n
\nPod
8:57 - Opening Riff
14:51 - Information Freedom
18:57 - Bitcoin responsibility and remembering your keys
24:19 - Patriot Act 2.0 and thinking local
28:25 - Mining and energy
38:30 - Trans politics and transhumanism
52:41 - Nostr
55:50 - v4v
1:08:43 - Joe Rogan
1:13:23 - Go make children
1:15:50...",
            "guid": "63760e0f-c8d4-45c2-9059-866d5e900b14",
            "datePublished":<PHONE_NUMBER>,
            "dateCrawled":<PHONE_NUMBER>,
            "enclosureUrl": "https:\/\/anchor.fm\/s\/558f520\/podcast\/play\/67974793\/https%3A%2F%2Fd3ctxlq1ktw2nl.cloudfront.net%2Fstaging%2F2023-3-5%2F322224047-44100-2-6f7eb2722c638.mp3",
            "enclosureType": "audio\/mpeg",
            "enclosureLength": 151584181,
            "duration": 9473,
            "explicit": 0,
            "episode": null,
            "episodeType": "full",
            "season": 0,
            "image": "https:\/\/d3t3ozftmdmh3i.cloudfront.net\/staging\/podcast_uploaded_episode\/797160\/797160-1680652733124-656a4d5b67a39.jpg",
            "feedItunesId":<PHONE_NUMBER>,
            "feedImage": "https:\/\/d3t3ozftmdmh3i.cloudfront.net\/production\/podcast_uploaded_nologo\/797160\/797160-1673918964644-e9c5c2eba3449.jpg",
            "feedId": 226249,
            "feedUrl": "https:\/\/anchor.fm\/s\/558f520\/podcast\/rss",
            "feedAuthor": "Marty Bent",
            "feedTitle": "TFTC: A Bitcoin Podcast",
            "feedLanguage": "en-us",
            "chaptersUrl": null,
            "transcriptUrl": null
        }
    },
    "count": 27,
    "query": "adamcurry",
    "description": "Found matching episodes."
}

The "items" object is now a string of random id's, depending on the result. According to the schema items should hold an array of objects.

I think I now what happened. Will check it asap.

This should be fixed now.  Thanks for reporting it.


Services swig 4.1.1

Linter check found the following problems:
The following problems have been found:
WARNING: clone/recipe/meta.yaml:27: host_section_needs_exact_pinnings: Linked libraries host should have exact version pinnings.
Warnings were found

Linter check found the following problems:
The following problems have been found:
WARNING: clone/recipe/meta.yaml:27: host_section_needs_exact_pinnings: Linked libraries host should have exact version pinnings.
Warnings were found

Linter check found the following problems:
ERROR conda.cli.main_run:execute(124): `conda run conda-lint /tmp/abs_7akim_mgck/clone` failed. (See above for error)
The following problems have been found:
===== WARNINGS =====

clone/recipe/meta.yaml:27: host_section_needs_exact_pinnings: Linked libraries host should have exact version pinnings.
===== Final Report: =====
0 Errors and 1 Warning were found


feat(web-modeler): reference docker hub images

Which problem does the PR fix?

Closes https://github.com/camunda/distribution/issues/256
What's in this PR?

References Web Modeler's public images (>= 8.6.0-alpha2) instead of the private ones
Checklist
Please make sure to follow our Contributing Guide.

Before opening the PR:

[x] In the repo's root dir, run make go.update-golden-only.
[x] There is no other open pull request for the same update/change.
[ ] Tests for charts are added (if needed).
[ ] In-repo documentation are updated (if needed).

After opening the PR:

[ ] Did you sign our CLA (Contributor License Agreement)? It will show once you open the PR.
[ ] Did all checks/tests pass in the PR?

This is unblocked now that there are the camunda-platform-alpha charts, cc @JacobiCamunda


Add a new category - Lists various websites where one can practice coding

Hello,
I would like to request for adding a new list to the awesome list. This new list enumerates various websites where one can practice coding.
I created a repository for the same and then got to know about awesome list. I think it would be great if this list can be a part of it.
Let me know if this is a welcome contribution!
Cheers,
Harshita Kasera

I think already exists. See: https://github.com/karlhorky/learn-to-program Maybe contribute to that on instead?

Thank you! I was not aware of this 👍


Implement stdlib member function

Note that I have filled an issue because the documentation and the code seems out of sync ...
https://tickets.puppetlabs.com/browse/MODULES-1838
So right now, it does not what the documentation is saying (but seems to do what the stdlib module is doing in reality)


When Deposit is pending need to reflect that pending transaction even if X out

If you click X you need to be able to pull this up again. Or have some sort of thing where user can understand the transaction is still pending.

added this note text for now.  @proguerra

there is already a pending deposit transaction
correction to grammer (hint use gpt for english stuff)

there is already a pending deposit transaction
correction to grammar (hint use gpt for english stuff)

fixed.

is there a way you can make the words "there is a pending deposit"  clickable to where it links to the blockexplorer transaction?

is there a way you can make the words "there is a pending deposit" clickable to where it links to the blockexplorer transaction? That way people can see what is pending if they dont click it the first time.

You can create new issue with this proposal and just add label enchancement.