[No QA] Fix: Change offline pattern for unassigning cards

Explanation of Change

I also added removing the card from the cardList as before this change the card was still visible in the members details card section (if you assigned the card to yourself).
https://github.com/Expensify/App/issues/51895 - for this one I also disabled the button when loading (bc user was able to click it million times when loading)
Fixed Issues

$ https://github.com/Expensify/App/issues/51876
$ https://github.com/Expensify/App/issues/51895
PROPOSAL:
Tests

https://github.com/Expensify/App/issues/51876

Go to a workspace with company cards feeds enabled
Assign a card to somebody if no cards assigned
Go offline
Go to card details
Unassign card
Verify that the card is no longer on the card list
Go to workspace members
Go to member details (of the member you assigned card to)
Verify that the card is no longer in cards section

https://github.com/Expensify/App/issues/51895

Go offline
Go to card details
Update Card button should be disabled
Go back online
Go to card details
Update Card button should be enabled
Click the button
Verify that when loading the button is also disabled

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."
no QA

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes

[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)

[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

https://github.com/user-attachments/assets/a056a33f-67af-4349-9adf-deb84caddc8d

MacOS: Desktop

@mountiny  Could I take over this one?

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[ ] I verified that all the inputs inside a form are aligned with each other.
[ ] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

@mountiny I've accidentally pushed the changes for https://github.com/Expensify/App/issues/51895 on this branch 🤦🏻♀ 😅 Can it be done in one PR?

@DylanDylann test steps updated, removed the unnecessary code

@parasharrajat This PR belongs to the Workspace Feed Project and I am taking over this project. Sorry for the confusion

@DylanDylann done

@koko57 In offline pattern B, we need to grey out the deleted card when users remove it offline and only hide it when receiving response from BE

We need to add pendingAction or pendingField in optimisticData

We need to add pendingAction or pendingField in optimisticData

@mountiny should we also do this for the Expensify Card? For now we have the same pattern there

https://github.com/Expensify/App/pull/51841 - this PR removes the card optimistically with no card greyed out state - the cards should be removed instantly. Same in the docs:

@koko57 In this issue, the expected is "Use Pattern B as per document sheet". You mean that we need to use another offline pattern

While implementing this PR, there are no requirements for us to use offline pattern B. So I only fixed the original bug and didn't notice which offline pattern we should use

@DylanDylann so I think it should be discussed then. Nevertheless these changes fix the problem I mentioned in the description:

I also added removing the card from the cardList as before this change the card was still visible in the members details card section (if you assigned the card to yourself).

and there was no error handling and restoring the card if the API call failed.

If we use offline pattern B, we also handle failed cases on API

We need to confirm that should we apply offline pattern B to both deactivating Expensify Card action and unassigning Company Card action?

@DylanDylann I've just posted this question in the issue 😃

We should apply pattern B to all of those, if there will be issues with error handling we can do pattern C and wait for the action to succeed same as creating a card

Could we possibly merge this one to have at least https://github.com/Expensify/App/issues/51895 fixed? And I could do the change for all the cards actions in a separate PR? WDYT @mountiny @DylanDylann?

I am fine. But give me 30 mins to make the checklist

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

I haven't uploaded video for IOS because of some problem on my local

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

https://github.com/Expensify/App/issues/51876
Go to a workspace with company cards feeds enabled
Assign a card to somebody if no cards assigned
Go offline
Go to card details
Unassign card
Verify that the card is no longer on the card list
Go to workspace members
Go to member details (of the member you assigned card to)
Verify that the card is no longer in cards section

Verified this is working as expected. We still seem to be using pattern A for this, as the card is being optimistically removed while offline with no feedback. However I think that is expected and we are addressing in a follow up PR, so checking this off. LMK if not correct.  cc @mountiny @koko57

https://github.com/Expensify/App/issues/51895
Go offline
Go to card details
Update Card button should be disabled
Go back online
Go to card details
Update Card button should be enabled
Click the button
Verify that when loading the button is also disabled

Confirmed both cases are working as expected!

@joekaufmanexpensify yes, I will be working on the follow-up today!

Thanks for testing

Course, and sounds good!


MAINT: Remove unused data portal methods.

The apply adjustments behavior had been moved to the HistoryLoader
class.

Coverage increased (+0.1%) to 86.594% when pulling dfd37fcf7837dfd03d1ab2fddd2107ad01220409 on remove-unused-adjustments-in-data-portal into 768cdb73c3adc8a3cfa267be1bf2dd9fb3b0cfc8 on master.


HBASE-25987 Make SSL keystore type configurable for HBase ThriftServer

Before HBASE-25930, the InfoServer was started first and it set the keystore type in the global keystore manager, which setting propagated to the thrift http server too, based on the InfoServer configuration "ssl.server.keystore.type". In HBASE-25930 the startup order changed, and the thrift http server configuration happens before the InfoServer start, so we lack this accidental configuration change now.
Given that we have independent keystore file path / password parameters already for the thrift http server, the proper solution is to create a new parameter for the keystore type of the thrift http server: hbase.thrift.ssl.keystore.type (defaulting to "jks").

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 10s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+1 :green_heart:
mvninstall
4m 14s
master passed

+1 :green_heart:
compile
0m 31s
master passed

+1 :green_heart:
shadedjars
9m  0s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 36s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m  6s
the patch passed

+1 :green_heart:
compile
0m 31s
the patch passed

+1 :green_heart:
javac
0m 31s
the patch passed

+1 :green_heart:
shadedjars
8m 55s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 34s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
7m 24s
hbase-thrift in the patch passed.

38m 17s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3367/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3367

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 6468c8538e13 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 1654dcfbfb

Default Java
AdoptOpenJDK-1.8.0_282-b08

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3367/1/testReport/

Max. process+thread count
1337 (vs. ulimit of 30000)

modules
C: hbase-thrift U: hbase-thrift

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3367/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 44s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+1 :green_heart:
mvninstall
4m 13s
master passed

+1 :green_heart:
compile
1m  4s
master passed

+1 :green_heart:
checkstyle
0m 47s
master passed

+1 :green_heart:
spotbugs
1m 36s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m  0s
the patch passed

+1 :green_heart:
compile
1m  1s
the patch passed

+1 :green_heart:
javac
1m  1s
the patch passed

+1 :green_heart:
checkstyle
0m 43s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
20m 55s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.

+1 :green_heart:
spotbugs
1m 36s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 16s
The patch does not generate ASF License warnings.

46m 31s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3367/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3367

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile

uname
Linux dd2fcb3994e6 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 1654dcfbfb

Default Java
AdoptOpenJDK-1.8.0_282-b08

Max. process+thread count
96 (vs. ulimit of 30000)

modules
C: hbase-thrift U: hbase-thrift

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3367/1/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

thanks for the quick review, @wchevreuil !

Using this patch, I tested the Thrift Server in http mode (hbase.regionserver.thrift.http=true) both with "jks" and "bcfks" (FIPS compliant) keystores.


Include DRSecondary endpoint for GetPublishingProfileXml

Include DRSecondary endpoint for GetPublishingProfileXml. This is for Azure App Service.
PR information

[x] The title of the PR is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
[x] Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
[ ] If applicable, the PR references the bug/issue that it fixes.
[x] Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

[x] I have read the contribution guidelines.
[x] My spec meets the review criteria:

[x] The spec conforms to the Swagger 2.0 specification.
[x] The spec follows the guidelines described in the Swagger checklist document.
[x] Validation tools were run on swagger spec(s) and have all been fixed in this PR.

Automation for azure-sdk-for-ruby

Can one of the admins verify this patch?

Automation for azure-sdk-for-go

Automation for azure-sdk-for-java

Automation for azure-sdk-for-node

Automation for azure-sdk-for-python


Multiple 1xx responses not handled properly

Hi,
Issue #1337 fixed the cases where OkHttp receives an unexpected 1xx response from the server. However this only works if the server sends a single 1xx unexpected response. Any additional unexpected 1xx responses are not handled properly. According to RFC 7231, clients should be able to cope with this:

A client MUST be able to parse one or more 1xx responses received
prior to a final response, even if the client does not expect one. A
user agent MAY ignore unexpected 1xx responses.

Should be fixed in https://github.com/square/okhttp/pull/7629/files


pcfdev fails to deploy PAS

Fetching info:
Performing request GET 'https://<IP_ADDRESS>:25555/info':
Performing GET request:
Retry: Get https://<IP_ADDRESS>:25555/info: dial tcp <IP_ADDRESS>:25555: connectex: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond.
Exit code 1

Env:
Windows 10
64GB RAM
Xeon CPU
Docker
Hyper-V


Difference in way date columns are returned by pyarrow=True or False

If pyarrow=False, the default, a date column is returned as dtype "datetime64".
If pyarrow=True, a date column is returned as dtype "object" with datetime.date objects as data values.
Not sure what is the way to go, but probably it would be better if the behaviour is the same.

Additional complication: columns of type "datetime64" are written by pyogrio to a column of Date type (tested with shapefile), while "object" columns with datetime.date values seem to be written as a "String" column.

Script to reproduce both aspects:
from pathlib import Path
import tempfile

import pyogrio

tmp_dir = Path(tempfile.gettempdir())
url = "https://github.com/theroggy/pysnippets/raw/main/pysnippets/pyogrio/polygon-parcel_31370.zip"
for use_arrow in [True, False]:
    gdf = pyogrio.read_dataframe(url, use_arrow=use_arrow)
    print(
        f"input_file, use_arrow: {use_arrow}, column dtype: {gdf['DATUM'].dtype}, "
        f"value: {gdf['DATUM'][0]}, value type: {type(gdf['DATUM'][0])}"
    )
    written_path = tmp_dir / f"output_{use_arrow}.shp"
    pyogrio.write_dataframe(gdf, written_path)
    gdf = pyogrio.read_dataframe(written_path, use_arrow=False)
    print(
        f"written_file, use_arrow: {use_arrow}, column dtype: {gdf['DATUM'].dtype}, "
        f"value: {gdf['DATUM'][0]}, value type: {type(gdf['DATUM'][0])}"
    )

(relevant) output:
input_file, use_arrow: True, column dtype: object, value: 2020-05-01, value type: <class 'datetime.date'>
written_file, use_arrow: True, column dtype: object, value: 2020-05-01, value type: <class 'str'>
input_file, use_arrow: False, column dtype: datetime64[s], value: 2020-05-01 00:00:00, value type: <class 'pandas._libs.tslibs.timestamps.Timestamp'>
written_file, use_arrow: False, column dtype: datetime64[s], value: 2020-05-01 00:00:00, value type: <class 'pandas._libs.tslibs.timestamps.Timestamp'>

In geofileops I'm thinking about dealing with it as follows, so convert these columns to datetime64:
    # Cast columns that are of object type, but contain datetime.date or datetime.date
    # to proper datetime64 columns.
    if len(result_gdf) > 0:
        for column in result_gdf.select_dtypes(include=["object"]):
            if isinstance(result_gdf[column][0], (datetime.date, datetime.datetime)):
                result_gdf[column] = pd.to_datetime(result_gdf[column])

My personal view in all of these is that in the long term, it makes sense to adopt use_arrow=True as the standard, and deprecate use_arrow=False. For one, there's lots of data type handling that is currently handled manually in use_arrow=False that gets handled automatically by GDAL when using its RFC 86 bindings. The Arrow bindings should be potentially faster, have much lower maintenance requirements, and have zero-copy interoperability with a larger ecosystem.

But this can actually be controlled by a keyword

Ah right. That reminded me of https://github.com/geopandas/pyogrio/issues/241#issuecomment-1508995869, so in theory you could use types_mapper here for the pyarrow -> pandas conversion to get the date type you want?

You could indeed use types_mapper to preserve the arrow date in an Arrow-backed pandas extension dtype. But you can't use this keyword to choose between object and datetime64, because that are no extension dtypes (and the types_mapper keyword only works with extension dtypes ..)


Explicitly stated some dependency versions.

Coverage remained the same at 55.612% when pulling 441fc4c9ead2423703d284d959a02ad23722c4db on p-backman-ericsson:fix_deps into 7e0b561030f3fdcd5fbd303111de6e30556eea0f on Ericsson:master.


Add ts types

Codecov Report

Merging #4 (f175299) into main (ee2b791) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main        #4   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            3         3
  Lines          205       246   +41
=========================================
+ Hits           205       246   +41

Impacted Files
Coverage Δ

lib/index.js
100.00% <100.00%> (ø)

lib/visitor-keys.js
100.00% <100.00%> (ø)

lib/visitor.js
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee2b791...f175299. Read the comment docs.


The plugin stopped working after one of the updates

Describe the bug
A few days ago, there was update for dashboard-nvim and since then the dashboard is not working. Currently I have the very latest version from ~10 min ago, but still on opening nvim or calling :Dashboard I get either an empty [Scratch] buffer or a standard splash screen. Didn't change config or anything at all, so no idea how to debug or reproduce.
To Reproduce
Steps to reproduce the behaviour:

Open :Dashboard or open a new nvim

Expected behaviour
Expect to see the dashboard I've always had
Screenshots

please see doc

Perhaps if changes are breaking and totally incompatible with the previous versions, it makes sense to make the fact of the change more prominent in README or something. Just a thought 👐


Block temporary/burner email addresses

Handling : https://github.com/opencollective/opencollective/issues/2576

@effin143 Can you rebase from master? Then look at the failing tests?

@Betree I think this needs to be documented, we should have a clear idea of what is allowed or not. Would be also interesting to run a test on already registered emails to check that it's making sense.

Thanks for pointing that out @znarf, from the extracted data I now think that we should have a small whitelist of domains we want to allow.
For example https://hush.com  and https://mailhero.io seem like legitimate services that are used to avoid SPAM. They are private emails providers, thus they don't fall in the initial description of shared public inboxes like http://www.yopmail.com/ (that is often used by robots because they make automatizing emails reception really easy).
Below is the data. My advice would be to whitelist all services from Blocked providers for Users with at least 1 transaction that are not shared public inboxes.

Number of existing users: 1157
Number of existing users with at least one transaction: 464

Blocked providers for Users with at least 1 transaction

Domain
Count

https://hush.com
100

https://opayq.com
94

https://mailhero.io
70

https://mailinator.com
46

https://sudomail.com
34

https://maildrop.cc
32

https://neverbox.com
24

https://thrott.com
18

https://gmial.com
12

https://sharklasers.com
4

https://spamgourmet.com
4

https://guerrillamail.com
2

https://urhen.com
2

https://max-mail.com
2

https://daymail.life
2

https://cndps.com
2

https://nicemail.pro
2

https://its0k.com
2

https://spamex.com
2

https://zebra.email
2

https://byom.de
2

https://yeah.net
2

https://nigge.rs
2

https://xoxy.net
2

All blocked providers having entries in Users
mailprotech.com
simpleemail.info
i.ua
sharklasers.com
spamex.com
opayq.com
theroyalweb.club
wegwerfemail.de
yeah.net
mvrht.net
sudomail.com
crypemail.info
bobmail.info
dispostable.com
dreamcatcher.email
urhen.com
skymailapp.com
gmal.com
nigge.rs
planet-travel.club
guerrillamail.com
nwytg.com
next-mail.info
oranek.com
nezdiro.org
loketa.com
hidebusiness.xyz
gamil.com
max-mail.com
yk20.com
4senditnow.com
patonce.com
mailbox87.de
hotmai.com
dayrep.com
zebra.email
mygeoweb.info
minex-coin.com
geo-crypto.com
zoqqa.com
maileme101.com
69postix.info
mailinator.com
binka.me
mailbox52.ga
thrott.com
hitbts.com
getnada.com
test.com
cowcell.com
gmial.com
alexbox.online
mail4-us.org
trash-mail.com
furusato.tokyo
polyswarms.com
mvrht.com
dnsdeer.com
geroev.net
hush.com
neko2.net
example.com
grr.la
shop4mail.net
neverbox.com
etoic.com
bossmail.de
mohmal.com
daymail.life
vomoto.com
its0k.com
nwytg.net
himail.online
xoxy.net
bcaoo.com
f5.si
smartbusiness.me
nicemail.pro
jmail.ovh
mailnesia.com
reddcoin2.com
crowd-mail.com
eoffice.top
maildrop.cc
byom.de
umail2.com
vpsorg.top
honor-8.com
armyspy.com
emailna.co
mailtothis.com
mt2015.com
safetymail.info
spamgourmet.com
fastair.info
desoz.com
theskymail.com
bccto.me
rockmailapp.com
mail-cart.com
lavabit.com
pay-mon.com
phpbb.uu.gl
ymail4.com
hideweb.xyz
4mail.top
cndps.com
mailhero.io
macr2.com
yopmail.com
ugimail.net
alltempmail.com

Below is the data. My advice would be to whitelist all services from Blocked providers for Users with at least 1 transaction that are not shared public inboxes.

@Betree I don't see that implemented in the PR. Shouldn't that be tackled?

@znarf Yes, specs from #2832 (comment) are a blocker before we can merge this.

How should I implement it

make a text file with all the domains
if domain is present in that list , allow them

@znarf Yes, specs from #2832 (comment) are a blocker before we can merge this.

How should I implement it
* make a text file with all the domains
* if domain is present in that list , allow them

Yes, except it should be a JS file - not a text file. The most appropriate one to add this for me seems to be server/lib/email.js. We can have a isWhitelistedDomain function like this in it:
const isWhitelistedDomain = domain => {
  return [].includes(domain) // TODO add domains here
}

@Betree can you do a final review and approve?


kernel: Let the kernel build system strip modules

Since commit 48f51f118506 we let the kernel build system compress the
modules, which makes the original strip expression not work. Let the
kernel build system strip them as well so they get stripped.
cc @edolstra. Also something should be done wrt. module_init_tools.

Any idea how much space we save by combining strip and compression?

It did have a effect on the hashes, but didn't seem to save any space.

The total du is still ~59 MB for me, although it seems the sizes of the files did change slightly. This PR made a difference 100-150 kB for me.


java.lang.reflect.InaccessibleObjectException: Unable to make field private final java.lang.String java.security.cert.Certificate.type

Getting the below exception while making a get call with authToken
Request request = new Request.Builder()
.url("https://sampleurlexample12345.com/api/apiname?param1=value1&param2=value2")
.addHeader("Accept", "application/xyz.v1+json")
.addHeader(AUTHORIZATION_HEADER_VALUE,
BEARER_TOKEN + accessToken)
.build();
java.lang.reflect.InaccessibleObjectException: Unable to make field private final java.lang.String java.security.cert.Certificate.type accessible: module java.base does not "opens java.security.cert" to unnamed module

Without more information we can't confirm the issue. It's likely an issue with newer JVM and java modules.
Consider posting to a site like stackoverflow with a full stacktrace and JVM version

This is coming in response object of the get call, not getting an exception from our application, below is the full response object.
Response{protocol=h2, code=200, message=, url=https://sampleurlexample12345.com/api/apiname?param1=value1&param2=value2}
java.lang.reflect.InaccessibleObjectException: Unable to make field private final java.lang.String java.security.cert.Certificate.type accessible: module java.base does not "opens java.security.cert" to unnamed module

That looks like the Response ends before that warning.  Please continue on stackoverflow or with colleagues.
We can't provide 1:1 support.


Bug in NFT and FT allowances in the precompile

Description
When approving allowances for FTs and NFTs via the precompiles, the process does not complete as expected because there's a bug where the precompile doesn't seem to understand that a token and an account are already associated.
This same process works OK and as expected when done through the SDKs.
In the FT/NFT example:

5 entities are involved: Operator, Treasury, Alice, Bob, and the token.
The Treasury of the token approves an allowance for Alice of 50 FT units / 1 NFT
Alice should send bob 10 FT / 1 NFT units from the allowance
Again, this same process was successfully completed using the JS SDK for both FT and NFT

The Issue:
The allowance transfer throws the error: SPENDER_DOES_NOT_HAVE_ALLOWANCE. See the error file for console output and additional details. Approval-Allowance bug - error message.txt
The crypto transfer tx in Alice's tx history in HashScan correctly shows that she doesn't have the allowance.
The operator tx history, specifically the failed contract call for approving the allowance FALSELY shows: TOKEN_NOT_ASSOCIATED_TO_ACCOUNT.
The console output (and tx history) shows that both Alice and Bob are associated with the token. As a test, the treasury already sent some tokens to Alice using the SDK before calling the contract.
So even though Alice already owns tokens, the precompile seems to think that Alice is not associated to the token => thus the allowance approval via precompile fails => thus the approved token transfer fails.
Tagging @Nana-EC @tinker-michaelj for visibility. Thank you in advanced team : )
Steps to reproduce

Open the following GitPod: https://gitpod.io/#https://github.com/ed-marquez/quick-contract-examples
Add a .env file with your own credentials
Try running the files: 0_test_precompile_FT.js and 0_test_precompile_NFT.js
Monitor the operator account activity in HashScan for additional details

Additional context
No response
Hedera network
mainnet, testnet
Version
v2.18
Operating system
Windows

This bug is also affecting granting an allowance to an account using ERC20 standard calls. Currently, users cannot grant an allowance to an account and complete a token transfer.
Please see the link below for the repo, an explanation of what is being done in the repo, and steps to reproduce:
This below code example does the following:

1. creates 3 accounts: Treasury, Alice, and Bob.
2. creates an FT of token symbol POP
3. executes a tokenAssocations for Alice and Bob to POP
4. executes a token transfer of 3 POP from Treasury to Alice
5. deploys a smart contract
6. executes a ContractExecuteTransaction for the ERC20 approve function
7. executes an approved token transfer
Steps to reproduce: https://gitpod.io/#snapshot/7f7e3241-10f9-443b-88d0-cae4d43222c8

Open the following GitPod:
Add a .env file with your own credentials
Run node index.js in the gitpod terminal
Monitor account activity in HashScan for additional details

To add to this discussion:
HederaTokenService.sol approveNFT method takes a uint256 input for the serial (per the gitpod example) however it dynamically binds to send to the precompile using the IHederaTokenService which expects an int64. If I create my own method making the low-level call dynamically to precompile via IHederaTokenService passing an int64 then I get it to work. This is not the only case of inconsistency, unfortunately.
		// HederaTokenSerive.sol implments the method as unit256 serialNumber
		// however it is called via the interface (IHederaTokenService) where serialNumber is int64
		(bool success, bytes memory result) = precompileAddress.call(
            abi.encodeWithSelector(IHederaTokenService.approveNFT.selector,
            token, address(this), serialNumber));
        responseCode = success ? abi.decode(result, (int32)) : HederaResponseCodes.UNKNOWN;
	}

HI @Burstall thanks for highlighting this.
We are aware of it and are carefully considering the right approach with minimal impact.
This was captured in https://github.com/hashgraph/hedera-services/issues/3916
@ed-marquez  and @a-ridley thanks for the original issue.
We're aware and are investigating how best to approach this.
See https://github.com/hashgraph/hedera-smart-contracts/issues/69 and  https://github.com/hashgraph/hedera-services/issues/3758

The code from gitpod completes succesfully without any errors and the CRYPTO_APPROVE_ALLOWANCE transaction doesn't fail. @ed-marquez @a-ridley Could you please confirm if the issue is resolved?

The code from gitpod completes succesfully without any errors and the CRYPTO_APPROVE_ALLOWANCE transaction doesn't fail. @ed-marquez @a-ridley Could you please confirm if the issue is resolved?

The issue is resolved. I had to make the following change to the smart contract: use delegatecall instead of call. The CRYPTO_APPROVE_ALLOWANCE transaction completes successfully.

Thanks closing this.
@Burstall where are you seeing an int64 serialNumber in IHederaTokenService?
The current and previous data types were all uint256.
Notably this will change with https://github.com/hashgraph/hedera-smart-contracts/pull/99 so feel free to comment there regarding your issue.

looks good now on the latest set I saw. I see things moving around a little and am trying to keep up to date accordingly. thanks.


Fix multi include reinclude from query

now，I search use include
// it's success
http://spark.kufu.no/fhir/ServiceRequest?_id:exact=ambulation&_include=ServiceRequest:encounter
// it's fail
http://spark.kufu.no/fhir/ServiceRequest?_id:exact=ambulation&_include=ServiceRequest:encounter&_include=ServiceRequest:subject&_include=ServiceRequest:requester

@whyfate This PR #277 was supposedly fixing the problem you are experiencing. But as I understand, according to your PR, it doesn't and the fix you are proposing has been tested and works?

@kennethmyhra I think I might know your question,The problem is HttpRequest.But unit testing does not cover this.

The PR #277 only fix the problem of HttpRequestMessage.

It was my fault. After I found out the problem with Httprequest, I rashly modified the HttpRequestMessage, which caused this misunderstanding.

@whyfate I actually like your fix better. It uses an already existing method from the firely-net-sdk, and the code is now similar for both methods.
One thing though, could you recreate a PR and target stu3/master instead of r4/master? If you do that I can forward merge your fix to R4

OK

Thanks, merged #313


Fix #597 - Rename of rack

Description
fix rename of rack not functional neither idempotent
fix dict_merge to not change content of first argument by working on a copy
Issues Resolved
#597
Check List

[ ] New functionality includes testing.

[ ] All tests pass. ($ ./build.sh).

[ ] New functionality has been documented in the README if applicable.

[ ] New functionality has been thoroughly documented in the examples (please include helpful comments).

Closing this as this is taken care in PR #601


Can't have table fill container with variable sized columns

I'm submitting a ...  (check one with "x")
[ ] bug report => search github for a similar issue or PR before submitting
[x] feature request
[ ] support request => Please do not submit support request here, post on Stackoverflow or Gitter

Current behavior
This is using the bootstrap theme.
The columnMode standard only makes the table 750px wide, except for the footer which seems to fill the container. The individual columns don't expand to fit their content. The table can be manually resized with the mouse to use more width, but it doesn't happen automatically.
In columnMode force the table does fill the container, but all columns are the same width and can't be resized.
In columnMode flex, columns are different widths in every row!
Expected behavior
I'd like to see behaviour akin to  in columnMode standard. The columns should automatically set width to best fit their content and to fill the container.
Reproduction of the problem

What is the motivation / use case for changing the behavior?
Seems pretty obvious, I want my table to fill my container
Please tell us about your environment:
npm, mac os

Table version:
13.1.0

Angular version:
6.1.9

Browser: all

Language: TypeScript 2.92

Facing the same issue.

Same issue

yep same, also facing this issue

When sidebar toggle, dispatch then window's resize();
this.cmn.sidebar.onToggle().subscribe(() => {
setTimeout(() => { window.dispatchEvent(new Event('resize')); }, 100);
});

Bump.


Need more information of a Container starting up

From the WebUI :
Rancher : v0.24.0
Cattle : v0.56.0
User Interface : v0.28.0
On my single Amazon EC2 host, I Added an official MySQL (latest) container , with no other config than an environment variable to set the DB password (MYSQL_ROOT_PASSWORD).
Not only did the Container never start, but the status only showed "Starting" in the "CONTAINERS" tab and "Networking" in the "HOSTS" tab.
(See attached image)
Some more information like boot logs or boot console, time taken since Container was started, etc. would be helpful

Oops Sorry, closed by mistake. Re-opening

There is additional info shown in the container details screen when available.


Adding Ethereum latest block number metric.

Refs https://github.com/keep-network/keep-core/issues/3608
Exposing the latest block number metric can be helpful to diagnose some of the problems with a node connectivity and determine if a node is catching up with the global Ethereum state.

General question: why is the Ethereum chain tip block number a metric and not a diagnostic?
Metrics are useful for time series, measurable, and changing over time. The number of nodes connected is a good metric. The connectivity status (0/1) to some external service like Ethereum or Electrum is a good metric. The number of pre-params in the pool is a good metric. The values can go up and down over time and they are measurable: N peers, N parameters, yes/no status.
I don't think chain time block number is a good metric, I would rather make it a diagnostic. It is always increasing and is not really measurable. We can think that "there are N blocks in the chain" but we are mostly interested in a non-measurable block number of the tip.

General question: why is the Ethereum chain tip block number a metric and not a diagnostic?
Metrics are useful for time series, measurable, and changing over time. The number of nodes connected is a good metric. The connectivity status (0/1) to some external service like Ethereum or Electrum is a good metric. The number of pre-params in the pool is a good metric. The values can go up and down over time and they are measurable: N peers, N parameters, yes/no status.
I don't think chain time block number is a good metric, I would rather make it a diagnostic. It is always increasing and is not really measurable. We can think that "there are N blocks in the chain" but we are mostly interested in a non-measurable block number of the tip.

Agree with what you said. I put it under metrics because codewise it's very close to Ethereum connectivity status and required very minimal change. But I think that Eth connectivity also doesn't exactly fit under metrics then. The status is binary, 0 or 1, connection problems or not and I'd rather see it under client's diagnostics. It won't be changed like pre-params where the range is way bigger. We can certainly leave it alone cause most likely some API calls are already in place and use it. Just giving you my reasoning.
For the latest block number, I will move it to diagnostics.

Tested locally, works as advertised!
❯ curl -D - localhost:8081/diagnostics
HTTP/1.1 200 OK
Date: Tue, 20 Jun 2023 13:07:22 GMT
Content-Length: 323
Content-Type: text/plain; charset=utf-8

{
  "chain_info": {
    "latest_eth_block_number": 741
  },
  "client_info": {
    "chain_address": "0x146748a2b46B99ee1470b587bc9812Ea59b79597",
    "network_id": "16Uiu2HAm2GxAmGNcQ6Aq8GMEYsYCnuZqbWLqCKD5fGWciwvUMtoj",
    "revision": "0493b72b3",
    "version": "v2.0.0-m3-73-g0493b72b3"
  },
  "connected_peers": null
}


Added support for nbconvert via console

Thank you for the great plugin. The lines I've added implement a feature to direct call nbconvert from console and set docx as output format. The gui is not needed in this case. Sorry for the 3 pull requests.

Thanks for your contribution!
Please note that pandoc also support conversion of Jupyter Notebooks directly as of version 2.6: https://github.com/jgm/pandoc/releases/tag/2.6
It is not possible to execute notebooks like in your contribution and my modifications to title and author is missing but basic conversions work great.


Way to easy to lose a long doc help string when using quickhelp tooltips.

Version: 1.61.0-insider (user setup)
Commit: ec40cbe164c59f3d13b6eff5fc7b0231ec0ab7aa
Date: 2021-09-13T05:15:14.689Z
Electron: 13.1.8
Chrome: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Windows_NT x64 10.0.22454
Not totally sure this is a VS Code core bug, but seems likely. In a Python file that's long enough to be scrollable, add this to the top.
import pandas as pd
pd.read_csv
You get function help for read_csv. This is fine, but it's long. So I scroll to the bottom where there are examples I want to see. Once I get to the bottom, if I scroll just a bit more (really easy), the whole tooltip disappears and the doc is scrolled, making me need to do it all again.
I would expect that the tooltip would stop scrolling and not disappear unless I moved the mouse outside of the tip itself and scrolled.

Sound like #112373 which should be resolved in January (and looks like it works as expected).

You get function help for read_csv.

What exactly do you mean under this - is it hover, suggestions(autocompletion) details, signature help (parameter info)?

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


upload a mp3 file get http 400 error on nginx accect.log

This is my conf
http {
sendfile on;
tcp_nodelay on;
keepalive_timeout  1800;
large_client_header_buffers 9999 9999k;
client_max_body_size    100M;
client_body_buffer_size 100M;
proxy_connect_timeout   120s;
proxy_send_timeout 120s;
proxy_read_timeout 120s;
proxy_buffers           9999 9999k;
server {
listen 80;
location / {
proxy_pass XXX
proxy_http_version 1.1;
proxy_set_header   Upgrade $http_upgrade;
proxy_set_header   Connection keep-alive;
proxy_set_header   Host $http_host;
proxy_cache_bypass $http_upgrade;
proxy_set_header   X-Forwarded-For $proxy_add_x_forwarded_for;
proxy_set_header   X-Forwarded-Proto $scheme;
proxy_set_header   X-Real-IP $remote_addr;
}
}
When I upload a mp3 file from device, I get this error on accect.log

And device error log
device get *** select timeout or error *** error

This my debug log

According to the error.log, the client (device) closed the socket before sending the entire file. It's hard to tell why it did so and what kind of timeout is that. Your nginx log is missing timestamps, which is why there's no way to tell whether the upload was indeed so slow that the client gave up.

Thanks for reporting this issue, @dfengpo.
We don't have sufficient information to proceed with further troubleshooting. Closing this issue for now.
Please reopen the issue if you have more details about this problem.


misc: require Dart 2, update dependencies

Ack. Will do that in this PR.
On Thu, Aug 9, 2018 at 4:33 AM Martin Kustermann<EMAIL_ADDRESS>wrote:

@mkustermann approved this pull request.
Though you are probably aware that the pub.dartlang.org site is not
switched to Dart 2 yet (and it uses this package)
In pubspec.yaml
https://github.com/dart-lang/pub_server/pull/19#discussion_r208895726:

@@ -1,24 +1,24 @@
name: pub_server
-version: 0.1.4+1
+version: 0.1.5-dev

If you want to publish it, then remove the -dev.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/dart-lang/pub_server/pull/19#pullrequestreview-144798175,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABCinPWnYrBP9r9Kg60Ysia-0x5xkJdks5uPB3zgaJpZM4V0pii
.


SpringBoot and RedisElastiCache Configuration

@aemruli
Hi I am using Redis ElastiCache with Springboot.. While trying to connect to Elastic cache using @EnableElastiCache I am getting the below error.  Could you please let me know how to provide the configurations for redis elasticache in spring boot?
redis.clients.jedis.exceptions.JedisConnectionException: Unexpected end of stream.
at redis.clients.util.RedisInputStream.ensureFill(RedisInputStream.java:199)
at redis.clients.util.RedisInputStream.readByte(RedisInputStream.java:40)

Hello @bhuvana27
I assume that you have a network problem with your connection. Please be aware that due to security reasons (Redis is missing a real authentication) you are not able to access Redis outside the AWS VPC (or within EC2 for classic deployments) - see https://docs.aws.amazon.com/AmazonElastiCache/latest/red-ug/GettingStarted.AuthorizeAccess.html
You can have a look at https://github.com/spring-cloud/spring-cloud-aws/blob/5fde56ffaf1ff11a80ef99aa122142f2fc758387/spring-cloud-aws-integration-test/src/test/java/org/springframework/cloud/aws/cache/BootElastiCacheAwsTest.java which is  a memcached nad redis based test scenario. We only run those test inside the EC2 environment.
Closing this ticket as this is a question, feel free to re-open in case of any further questions.


Add Gitter badge

Could you please add your name to the AUTHORS file?
https://github.com/marcelotrevisani/grayskull/blob/master/AUTHORS


Connectivity Demo not working on Android 13 device (Samsung Note20)

The Connectivity demo in Kastri on my Android (Samsung Note20 5G Android 13) doesn't seem to be working correctly.
When I run it with Airplane mode active on the phone, the app says I'm connected to the internet.
When I change the internet state (e.g. turn off airplane mode) it doesn't trigger the change handler.
Looking at the Android code, it looks from the Android docs that you may be using deprecated APIs but not sure if that's the problem or not. https://developer.android.com/reference/android/net/NetworkInfo
No errors reported, just incorrect behaviour.

It may be that it needs a delay similar to when onAvailable is called, because there can be a lag between when the method is called, and when the connection really is available. Android has to be one of the most problematic OS's between devices. At least iOS is 99.9% consistent!

Thanks Dave, I added the delays in and it made no difference, but it helped to rule that out.
I did figure out what was happening.
On my device I have an antivirus app installed which added a VPN to my internet connection (to check the traffic as it passes through, I assume).
The call to ConnectivityManager.getAllNetworks was returning the VPN as the first network.
The NET_CAPABILITY_INTERNET of this was true and although the network the VPN was connected to wasn't connected (airplane mode is on), the IsConnected property of the VPN was returning true which was confusing everything.
GetAllNetworks seemed to list the proper wifi/mobile connection separately, so I just ignored the VPN case and it now works properly.
I'm sure there's a better way, but the following change worked when made in GetCOnnectedNetworkInfoFromNetwork:
if (LCapabilities <> nil) and
LCapabilities.hasCapability(TJNetworkCapabilities.JavaClass.NET_CAPABILITY_INTERNET) and
LCapabilities.hasCapability(TJNetworkCapabilities.JavaClass.NET_CAPABILITY_NOT_VPN) then

After a bit of searching, I think you may have found the best way! This SO answer (about if VPN is active) has a potentially additional check:
  caps.hasTransport(NetworkCapabilities.TRANSPORT_VPN))

However I think it may be redundant, since:
  LCapabilities.hasCapability(TJNetworkCapabilities.JavaClass.NET_CAPABILITY_NOT_VPN)

returns True for non-VPN connections as well as inactive ones. I'll test out the changes on my device(s) and report my findings

I had SmartVPN on my device, and was able to replicate the issue. Now pushed a fix, thanks!!


Update CMakeLists.txt

Include missing headers

changes included in https://github.com/perftool-incubator/bench-trafficgen/pull/43


Fix VM snapshot size during storage capacity check

Description
This PR fixes the issue #8054

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[x] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)
[ ] build/CI

Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale

[ ] Major
[ ] Minor

Bug Severity

[ ] BLOCKER
[ ] Critical
[ ] Major
[ ] Minor
[ ] Trivial

How Has This Been Tested?

created a VM with one root (2GB) and data (5GB) disks

create VM snapshot and the primary storage usage looks like below

After this is fixed, usage considered 5GB data disk size as well

@blueorangutan package

@harikrishna-patnala a [SF] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan test

@blueorangutan package

Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7394

@blueorangutan test

@rohityadavcloud a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

tested manually according to description, works as expected

[SF] Trillian test result (tid-7995)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 46173 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8101-t7995-kvm-centos7.zip
Smoke tests completed. 106 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

test_02_upgrade_kubernetes_cluster
Failure
580.25
test_kubernetes_clusters.py

test_04_autoscale_kubernetes_cluster
Failure
48.23
test_kubernetes_clusters.py

test_07_deploy_kubernetes_ha_cluster
Failure
3609.51
test_kubernetes_clusters.py

test_08_upgrade_kubernetes_ha_cluster
Failure
0.05
test_kubernetes_clusters.py

test_09_delete_kubernetes_ha_cluster
Failure
0.04
test_kubernetes_clusters.py

ContextSuite context=TestKubernetesCluster>:teardown
Error
283.85
test_kubernetes_clusters.py

test_03_deploy_vm_wrong_checksum
Error
39.60
test_templates.py

test_09_list_templates_download_details
Failure
0.04
test_templates.py


the server could not find the requested resource (get pods.metrics.k8s.io)

I have the same problem as issue #9121: failed to get cpu utilization: unable to get metrics for resource cpu: unable to fetch metrics from API: the server could not find the requested resource (get pods.metrics.k8s.io)

@gregmalley please continue to work off the orgional issue you opened. I have requested more information from you on that issue.
Duplicate of #9121

I solved this by deploying the kubernetes metrics sever into my cluster. The latest version of kubernetes that is deployed by default in azure did not have it included. See: https://github.com/Azure/AKS/issues/318


Remove explicit pull request event types from workflow

According to github docs, when not specifying pull request event type in the github workflow, the default events are "opened, synchronize, and reopened". However, the way we explicitly defined the event types caused the "synchronize" event (run the jobs when new commit is synchronized with the remote branch) to not trigger. Removing the explicitly defined events and using the default gets us the wanted behavior (e.g. triggering workflows on new commits to a PR branch.)

I tried different syntax for explicitly defining events but it didn't get us the behavior we want. So either a bug in github, or bug in the documentation... The default behavior when no events are defined is good for our project, I think.

@rdmark Thank you for analyzing this.

@uweseimet You're welcome. Let me know if this works correctly for your workflow as well. I tested that subsequent changes to C++ or Python code triggered the jobs that I expected.

@rdmark I'm afraid there is no change. I just committed d1a080b7 and the anaylsis was not started.


hdf5 javascript in a webbrowser

Is it possible to adjust this code to run in a browser?
I want to write a javascript module for my web application that allows handling of hdf5 data.
Thus I can not directly interact with files. Instead the data would come from a webserver in raw binary format interpreted as typed array (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Typed_arrays). I want to allow the user to interact with the data, modify it and send it back (still as raw binary HDF5 data).
I see that this is not the scope of your node module but I still hope you have an idea on how to do that.
Thanks in advance.

Hi,
This code is based on a native hdf5 library, written in C.
Thus, I think it can not run in a browser.

Hi,
thanks for the very quick reply. I feared as much. So I will look for alternatives.
Anyway, thanks again.

I've been sending binary data tp browser with web socket API and with binaryjs [which I'm phasing out].  Putting into a second project under this organization.  As typed arrays and buffers

Also sending hdf5 images as buffers to browser canvas

What has slowed putting the hdf5.ws layer API back up is the new javascript language spec coming along. Been experimenting with Babel transpiling and tryng to stand up code with Chakra core.  Am studying javascript languae spec to learn what future code will be.   The viewer/editor layer is koa based and some of it is now based on babel transpiling.
Also V8 could eventually catch up to the new specs and then nodejs projects will not need transpiling.
The babel documents haven't caught up to its own version 6.0.0 release from 6 months ago. Also I'm in a learning curve for pretranspiling for browser client javascript ES2015.

@rimmartin thanks for the additional information. I will follow your updates closely. In case I make some progress I will let you know. I will experiment with emscripten to try and compile the native C library to javascript.

I was able to compile the hdf5 library with emscripten (with some difficulties). I'm also able to compile and link example hdf5 programs in c to javascript (both for nodejs and browsers). However hdf5 does not play nicely with the fake file system provided by emscripten. It just refuses to read or write any files (even preloaded ones) with error messages like that:
HDF5-DIAG: Error detected in HDF5 (1.8.17) thread 0:
  #000: ../../src/H5T.c line 4508 in H5T_path_find(): unable to initialize conversion function
    major: Datatype
    minor: Unable to initialize object
  #001: ../../src/H5Tconv.c line 7713 in H5T__conv_long_float(): disagreement about datatype size
    major: Datatype
    minor: Unable to initialize object
  #002: ../../src/H5T.c line 2290 in H5T_register(): unable to locate/allocate conversion path
    major: Datatype
    minor: Unable to initialize object
...

Currently I see no way of working around this as the hdf5 library depends heavily on files.

Yea, it heavily tied to the file system.  Also hdf5 1.10 gets even more involved.
I'll be putting up the other projects in this organization in the next evenings

Now making a double dataset from browser HDF5 interface.  Preparing to read it back
https://github.com/HDF-NI/hdf5.ws is where this layer is being repo'ed.
Dependencies are just co, ws and hdf5 nodejs modules

@rimmartin thanks for sharing. I will definitely try it out. Thanks for all the help.

It's not complete at all; I'll get the read working tonight
What data types are you first working with?

I wanted to write a module to handle biom format version 2. For now I will probably stick to version 1 which is based on JSON. But I will keep an eye on your work to move to version 2 as soon as possible.
The biom specification contains the data types:
H5T_IEEE_F64LE, H5T_STD_I32LE, H5T_STD_I64LE, H5T_STRING

Ok, I'll look at and work toward supporting that format

Testing with https://github.com/biocore/biom-format/blob/master/examples/rich_sparse_otu_table_hdf5.biom

Able to look at a dataset.  Now biom uses deflate so for writing back I'm adding ohoosing compression level.
Is rich_sparse_otu_table_hdf5.biom typical of your data?
How large a datasets do you reach? I'll be adding chunking and subregion io.

Wow, that looks really promising! This biom file is typical in structure but not in size. The biom files I'm interested in are a few (~5) MB in size. They contain about 100000 entries in sample > matrix > data
Great work!

I was able to compile the hdf5 library with emscripten (with some difficulties). I'm also able to compile and link example hdf5 programs in c to javascript (both for nodejs and browsers). However hdf5 does not play nicely with the fake file system provided by emscripten. It just refuses to read or write any files (even preloaded ones) with error messages like that:
HDF5-DIAG: Error detected in HDF5 (1.8.17) thread 0:
  #000: ../../src/H5T.c line 4508 in H5T_path_find(): unable to initialize conversion function
    major: Datatype
    minor: Unable to initialize object
  #001: ../../src/H5Tconv.c line 7713 in H5T__conv_long_float(): disagreement about datatype size
    major: Datatype
    minor: Unable to initialize object
  #002: ../../src/H5T.c line 2290 in H5T_register(): unable to locate/allocate conversion path
    major: Datatype
    minor: Unable to initialize object
...

Currently I see no way of working around this as the hdf5 library depends heavily on files.

Working with the compile script provided by https://github.com/aertslab/webhdf5 I was able to load HDF5 files from the Emscripten FileSystem API.  I was able to write files too.  With a little adjustment I even got the zlib filter working.  The error message you are showing is coming from some of the byte-conversions not working for 32-bit Webassembly, I think.  The library seems to work in spite of those ominous warnings.
I was able to use "H5Fopen" without difficulty (make sure to compile with "-s WASM_BIGINT" so you can pass hid_t values back and forth to javascript).


feat: Support Chat for users and mentors

Related Issue

In continuation of #781
Description of Changes

chat ability only when logged in
image upload feature
frontend part

This is not yet responsive, will make it responsive in the coming PR.
Checklist:

[x] My code adheres to the established style guidelines of this project.
[x] I have conducted a self-review of my code.
[x] I have included comments in areas that may be difficult to understand.
[x] I have made corresponding updates to the project documentation.
[x] My changes have not introduced any new warnings.

Screenshots
https://github.com/anmode/grabtern-frontend/assets/47839626/e038d9a4-4bd5-49cb-93cc-63d8c1e045af
@anmode
Please provide any necessary screenshots to illustrate the changes made.

great work Rishu! Please keep this pR as your work. I will create it is a project: ( Feat: adding Support chat to Grabtern )
Previous pR and this pr and backend pR I will create!


[DCGate] [RT-1.y] BGP import/export policy matching on community-set - Test Automation

Hello,
README can be found here:
https://github.com/openconfig/featureprofiles/pull/2174
feature/bgp/policybase/otg_tests/aspath_and_community_test/README.md
feature/bgp/policybase/otg_tests/community_test/README.md


Create Staging & Production on heroku

created remote repo for production: https://git.heroku.com/production-maintenance.git
added megan and becky as collaborators

[ ] created remote repo for [staging] (http://staging-maintenance.herokuapp.com/)
[ ] added collaborators: Becky, Steven


[ng6] ng serve; ng build -prod fails on ng g library dependent project

Versions
Angular CLI: 6.0.7
Node: 8.11.2
OS: darwin x64
Angular: 6.0.3
... animations, common, compiler, compiler-cli, core, forms
... http, language-service, platform-browser
... platform-browser-dynamic, router

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.6.7
@angular-devkit/build-angular     0.6.7
@angular-devkit/build-optimizer   0.6.7
@angular-devkit/core              0.6.7
@angular-devkit/schematics        0.6.7
@angular/cdk                      6.2.0
@angular/cli                      6.0.7
@angular/flex-layout              6.0.0-beta.15
@angular/material                 6.2.0
@ngtools/webpack                  6.0.7
@schematics/angular               0.6.7
@schematics/update                0.6.7
rxjs                              6.2.0
typescript                        2.7.2
webpack                           4.8.3

Repro steps

ng new angular-vertical-tabs && cd $_
ng add @angular/material; npm i --save @angular/flex-layout==6.0.0-beta.15
ng g library material-tabs -p vertical
ng build material-tabs --prod
Add dist to git, then import in other Angular 6 project

https://github.com/SamuelMarks/angular-vertical-material-tabs
Observed behavior
Works fine on ng serve. On ng build --prod I get:
ERROR in ./node_modules/angular-vertical-tabs/dist/material-tabs/material-tabs.ngfactory.js
Module not found: Error: Can't resolve 'material-tabs' in 'my-new-repo/node_modules/angular-vertical-tabs/dist/material-tabs'
ERROR in ./src/app/slash/slash.module.ngfactory.js
Module not found: Error: Can't resolve 'material-tabs' in 'my-new-repo/src/app/slash'
ERROR in ./src/app/slash/slash.component.ngfactory.js
Module not found: Error: Can't resolve 'material-tabs' in 'my-new-repo/src/app/slash'

Desired behavior
ng build --prod should work.
Mention any other details that might be useful (optional)
My previous hack solution was to --aot false.

My error (and versions of everything) is nearly identical:
ERROR in<EMAIL_ADDRESS>Module not found: Error: Can't resolve<EMAIL_ADDRESS>in '/home/rtm/repos/nims/red/app/node_modules/@nims/red-shared/lib/components/display-item-artifacts'

@nims/red-shared is a library with a component called display-item-artifacts which is bringing in components such as editable-markdown from another library called ngutils.
This was compiling fine before the upgrade to 6.0.0 etc., although I probably also changed some other things in the meantime.

Related? https://github.com/dherges/ng-packagr/issues/913

For me, it seems that removing the rootDir property of tsconfig.app.json solved the issue.
See this commit for more info: https://github.com/Chan4077/ngx-ytd-api/commit/5b1970cb090fc097e6bf748981d5c650958155ad

Dear all,
We fixed the issue on our side by making the following changes:

removing   "baseUrl": "./"   from src/tsconfig.app.json file
adding "paths" to  tsconfig.json file

Hi,
I fixed the issue with the package.json name attribute in my lib. I wanted to use the library  like this:
folder-structure:
| - node_modules
    | - @mylib
        | -  components
        | -  etc

Import Statement in e.g. app.module.ts:
import { ExampleModule } from '@mylib/components';

The problem was that by generating ng g library mylib-components the package.json was named "name": "mylib-components" due to the library-structure
| - projects
    | - mylib-components
        | - src

Then it couldn't generate the mylib-component.ngfactory.js because it couldn't resolve the path as shown in the folder-structure @mylib/components. To solve the problem I changed the name in the package.json file to "name": "@mylib/components". And in the generated metadata.json file the "importAs: @mylib/components" is now correct instead of "importAs: mylib-components".
Now the production build works with the library.
Hope it helps.

Indeed it is paramount to set the name inside the package.json to the actual library name that will eventually be imported by the consumers as the name set in the package.json will be used as a flatModuleId for ngc.

Hi,
We fixed the issue on our side by making the following changes:

removing "paths": "./" from src/tsconfig.app.json file
edit "paths" to tsconfig.json file
 "baseUrl": "src/", "agc": [       "../dist/agc"     ], "paths": {     ...     "agc/*": [       "../dist/agc/*"     ] }

Got it working, Previously, I was uploading my repo-name/dist in my org/repo-name repository. Library was called lib0.
In org/repo-name2 angular project, I included in my package.json: {"repo-name": "org/repo-name"}. Compiled fine on ng build; ng build --prod proved the problem.
Pushing the dist directory to its own repository org/lib0; removing the previous from my package.json; then adding: {"lib0": "org/lib0"}; proved to be the solution.
Now ng build --prod works; and the rendered static files give no unexpected errors.

@olilutz that is the solution I ended on! Thanks for the help!

import { Injectable } from '@angular/core';
import { Http, Response} from '@angular/http';
import 'rxjs/Rx';
@Injectable({
providedIn: 'root'
})
export class ProfileService {
constructor( private http:Http) { }
saveprofile(){
let url="https://reqres.in/api/users";
return this.http.post(url, {name:'Saranya', city:'Adoor'})
.map((res:Response)=>res.json());
}
}
I used the above code but it showing the error-Module not found: Error: Can't resolve 'rxjs/Rx/add/operator/map'. How can I solve it.

You need to import rxjs differently.
https://github.com/ReactiveX/rxjs/blob/master/doc/pipeable-operators.md
On Mon, 23 Jul 2018 at 07:55, saranyatpillai<EMAIL_ADDRESS>wrote:

import { Injectable } from '@angular/core';
import { Http, Response} from '@angular/http';
import 'rxjs/Rx';
@Injectable https://github.com/Injectable({
providedIn: 'root'
})
export class ProfileService {
constructor( private http:Http) { }
saveprofile(){
let url="https://reqres.in/api/users";
return this.http.post(url, {name:'Saranya', city:'Adoor'})
.map((res:Response)=>res.json());
}
}
I used the above code but it showing the error-Module not found: Error:
Can't resolve 'rxjs/Rx/add/operator/map'. How can I solve it.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/angular/angular-cli/issues/11097#issuecomment-406947224,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AQv-Wm6b_fD_nx5O8AFGPYqN2_-zw-h1ks5uJWVmgaJpZM4UYHDP
.

Thank you.

Hi,
Still I'm facing this issue in one of my library. @ngu/carousel beta version.
Don't know how to solve this issue
Git repo here

@sheikalthaf Could you tell me how did you solve that issue? I'm facing exactly same issue on my library @angular-ng-autocomplete . Here is my repo: https://github.com/gmerabishvili/angular-ng-autocomplete.


az webapp create  doesnt support using a acr image

Describe the bug
az webapp create  can only create a webapp using a public dockerhub or built in image, it doesnt support passing in registry credentials for a acr image.
I'm trying to create a webapp based on a image in acr,  but I cannot pass in the registry credentials into the create command. So I need to first create the webapp with a random public container, then run the az webapp config container set command that accepts registry credentials
To Reproduce
run az webapp create --deployment-container-image-name no way of passing in registry credentials
Expected behavior
I'd like to see consistency between the command line options for az webapp create --deployment-container-image-name and az webapp config container set --docker-custom-image-name
Environment summary
Bash on Windows

We have it on our backlog and will update the thread once we finish the work, that's said we don't have an ETA to share right now

+1 for this, could be useful for us as well

Also, if you have a container that needs certain environment variables set, there is no obvious way to create the webapp with the app settings. you have to first do az webapp create and then az webapp config appsettings set.
Would be nice to be able to create a new webapp from ACR and with environment variables correctly configured in a single step

@yiliaomsft & @Nking92  can you look at this request

+1 from me as well. This is really needed.

We're looking into it.

CC: //@apwestgarth for windows containers

this is needed as soon as possible for Microsoft engagements with other companies (I'm an employee in CSE)

@panchagnula and @Nking92 I think this item has enough traction that we need to have some sort of design figure out as well as costing and review where it fits in the backlog.

@Nking92 is already looking at this along with the container up work he is doing.

We are on track for s69

This has been fixed.

I tried creating a web app for container I used the -i option yet it didn’t give me acr as a default container reg instead it treated my parameter as a private container repo.where as i supplied my acr url and image name to the command.please any idea.??????

@nkemakolam I had this issue when my ACR url didn't start with https://. Setting with https:// registered it as a container registry instead.

I tried creating a web app for container I used the -i option yet it didn’t give me acr as a default container reg instead it treated my parameter as a private container repo.where as i supplied my acr url and image name to the command.please any idea.??????

I had this issue when my ACR url didn't start with https://. Setting with https:// registered it as a container registry instead.


Grant type error running user login (with username/password)

I'm running a command like that to get the credentials of a existing user:
curl -X POST -d<EMAIL_ADDRESS>http://localhost:8000/api/v1/auth/token/

I verified the client_id/client_secret and they are right, and the grant type also. (In the app the Authorization grant type and Client type are set to Confidential and Resource owner password-based). However I'm always getting this error:
{"error_description":"Invalid credentials given.","error":"invalid_grant"}

The social login is working normally with facebook. But the login/password is not.
Is this problem related to bad configuration?

The only thing I can guess here is that you've forgotten to include         'oauth2_provider.contrib.rest_framework.OAuth2Authentication'
as an authentication class for django rest framework in your settings.
Feel free to reopen and post more info if that's not it.

Sadly is another problem, I have it on my settings. I will paste my settings here. Can you take a look?

INSTALLED_APPS = [
    'django.contrib.admin',
    'django.contrib.auth',
    'django.contrib.contenttypes',
    'django.contrib.sessions',
    'django.contrib.messages',
    'django.contrib.staticfiles',
    'rest_framework',
    'oauth2_provider',
    'social_django',
    'rest_framework_social_oauth2',
    'domain',
    'api'
]

MIDDLEWARE = [
    'django.middleware.security.SecurityMiddleware',
    'django.contrib.sessions.middleware.SessionMiddleware',
    'django.middleware.common.CommonMiddleware',
    'django.middleware.csrf.CsrfViewMiddleware',
    'django.contrib.auth.middleware.AuthenticationMiddleware',
    'django.contrib.messages.middleware.MessageMiddleware',
    'django.middleware.clickjacking.XFrameOptionsMiddleware',
]

ROOT_URLCONF = 'clickfit.urls'

TEMPLATES = [
    {
        'BACKEND': 'django.template.backends.django.DjangoTemplates',
        'DIRS': [],
        'APP_DIRS': True,
        'OPTIONS': {
            'context_processors': [
                'django.template.context_processors.debug',
                'django.template.context_processors.request',
                'django.contrib.auth.context_processors.auth',
                'django.contrib.messages.context_processors.messages',
                'social_django.context_processors.backends',
                'social_django.context_processors.login_redirect',
            ],
        },
    },
]

REST_FRAMEWORK = {
    'DEFAULT_AUTHENTICATION_CLASSES': (
        'oauth2_provider.contrib.rest_framework.OAuth2Authentication',
        'rest_framework_social_oauth2.authentication.SocialAuthentication',
    ),
}

AUTHENTICATION_BACKENDS = (
    'social_core.backends.facebook.FacebookAppOAuth2',
    'social_core.backends.facebook.FacebookOAuth2',
    'rest_framework_social_oauth2.backends.DjangoOAuth2',
    'django.contrib.auth.backends.ModelBackend',
)

# Facebook configuration
SOCIAL_AUTH_FACEBOOK_KEY = 'xxxxx'
SOCIAL_AUTH_FACEBOOK_SECRET = xxxx'

# Define SOCIAL_AUTH_FACEBOOK_SCOPE to get extra permissions from facebook.
# Email is not sent by default,
# to get it, you must request the email permission:
SOCIAL_AUTH_FACEBOOK_SCOPE = ['email']
SOCIAL_AUTH_FACEBOOK_PROFILE_EXTRA_PARAMS = {
    'fields': 'id,name,email'
}

WSGI_APPLICATION = 'clickfit.wsgi.application'

# Password validation
# https://docs.djangoproject.com/en/1.11/ref/settings/#auth-password-validators

AUTH_PASSWORD_VALIDATORS = [
    {
        'NAME': 'django.contrib.auth.password_validation.UserAttributeSimilarityValidator',
    },
    {
        'NAME': 'django.contrib.auth.password_validation.MinimumLengthValidator',
    },
    {
        'NAME': 'django.contrib.auth.password_validation.CommonPasswordValidator',
    },
    {
        'NAME': 'django.contrib.auth.password_validation.NumericPasswordValidator',
    },
]

SOCIAL_AUTH_PIPELINE = (
        'social.pipeline.social_auth.social_details',
        'social.pipeline.social_auth.social_uid',
        'social.pipeline.social_auth.auth_allowed',
        'social.pipeline.social_auth.social_user',
        'social.pipeline.user.get_username',
        'social.pipeline.user.create_user',
        'social.pipeline.social_auth.associate_user',
        'social.pipeline.social_auth.load_extra_data',
        'social.pipeline.user.user_details',
        'api.pipelines.save_profile',
)

Can it be related to precedence of my tuple/list itens?

@PhilipGarnero I can't open the issue again.

Have you tried posting with Json instead of form fields ?

Yes, I even wrote a script to test it:
import requests

# ...
# client_id = "<my_client_id>"
# client_secrete = "<my_client_secret>"
# ...

login = 'http://<IP_ADDRESS>:8000/api/v1/auth/token/'
data = {
    "grant_type": "password",
    "client_id": client_id,
    "client_secret": client_secret,
    "username"<EMAIL_ADDRESS>    "password": "client123"
}
response = requests.post(login, data=data)
print(response.json())

# Prints: {"error_description":"Invalid credentials given.","error":"invalid_grant"}

No, this is still form data.
Try to put  response = requests.post(login, data=json.dumps(data))
instead of response = requests.post(login, data=data)

I tried:
response = requests.post(login, data=json.dumps(data))
print(response.json())

It prints:
{'detail': 'Unsupported media type "text/plain" in request.'}

I also tried:
response = requests.post(login, json=data)
print(response.json())

but it returns the same grant type error as before. This is very weird ):
I'm using python 3.5 and Django 1.11.3.

Well, I have absolutely no clue of what could be wrong
Try opening an issue on the django oauth toolkit package.
Maybe they'll know better

Finally I found out what was happening: I was creating the user in my api using User(**kwargs) however the right way to create an user in your code is using create_user like User.objects.create_user(username="name"<EMAIL_ADDRESS>password="***"). If you create the user using the default model way, it will cause to the backend to not use the right algorithm crypt in your password. :rocket:

I also had the same issue, the reason was that the user account was not 'active', hence it was throwing the grant error.

I also faced the same issue and the reason was that user account was not active and some other custom fields which needed to be verified.


first build

{package} {version} {:snowflake:}
Destination channel: {Snowflake | defaults}
Links

{ticket_number}
Upstream repository
Upstream changelog/diff
Relevant dependency PRs:

...

Explanation of changes:

...

Linter check found the following problems:
ERROR conda.cli.main_run:execute(125): `conda run conda-lint /tmp/abs_f9how27sye/clone` failed. (See above for error)
The following problems have been found:
===== WARNINGS =====

clone/recipe/meta.yaml:38: missing_description: The recipe is missing a description
clone/recipe/meta.yaml:15: avoid_noarch: noarch: python packages should be avoided

===== ERRORS =====

clone/recipe/meta.yaml:38: missing_home: The recipe is missing a homepage URL
clone/recipe/meta.yaml:38: missing_license_family: The recipe is missing the about/license_family key.
clone/recipe/meta.yaml:20: missing_wheel: For pypi packages, wheel should be present in the host section
clone/recipe/meta.yaml:38: missing_dev_url: The recipe is missing a dev_url
clone/recipe/meta.yaml:38: missing_documentation: The recipe is missing a doc_url or doc_source_url
===== Final Report: =====
5 Errors and 2 Warnings were found

Linter check found the following problems:
ERROR conda.cli.main_run:execute(125): `conda run conda-lint /tmp/abs_16b4lq5_oe/clone` failed. (See above for error)
The following problems have been found:
===== WARNINGS =====

clone/recipe/meta.yaml:15: avoid_noarch: noarch: python packages should be avoided
clone/recipe/meta.yaml:42: missing_description: The recipe is missing a description

===== ERRORS =====

clone/recipe/meta.yaml:42: missing_documentation: The recipe is missing a doc_url or doc_source_url
clone/recipe/meta.yaml:42: missing_license_family: The recipe is missing the about/license_family key.
===== Final Report: =====
2 Errors and 2 Warnings were found

Linter check found the following problems:
ERROR conda.cli.main_run:execute(125): `conda run conda-lint /tmp/abs_c18nuoc_qc/clone` failed. (See above for error)
The following problems have been found:
===== WARNINGS =====

clone/recipe/meta.yaml:44: missing_description: The recipe is missing a description
clone/recipe/meta.yaml:17: avoid_noarch: noarch: python packages should be avoided

===== ERRORS =====

clone/recipe/meta.yaml:1: patch_must_be_in_build: patch must be in build when source/patches is set.
clone/recipe/meta.yaml:44: missing_documentation: The recipe is missing a doc_url or doc_source_url
clone/recipe/meta.yaml:44: missing_license_family: The recipe is missing the about/license_family key.
===== Final Report: =====
3 Errors and 2 Warnings were found

Linter check found the following problems:
ERROR conda.cli.main_run:execute(125): `conda run conda-lint /tmp/abs_d4vkxd9z3y/clone` failed. (See above for error)
The following problems have been found:
===== WARNINGS =====

clone/recipe/meta.yaml:44: missing_description: The recipe is missing a description
clone/recipe/meta.yaml:17: avoid_noarch: noarch: python packages should be avoided

===== ERRORS =====

clone/recipe/meta.yaml:1: patch_must_be_in_build: patch must be in build when source/patches is set.
clone/recipe/meta.yaml:44: missing_documentation: The recipe is missing a doc_url or doc_source_url
clone/recipe/meta.yaml:44: missing_license_family: The recipe is missing the about/license_family key.
===== Final Report: =====
3 Errors and 2 Warnings were found

Linter check found the following problems:
ERROR conda.cli.main_run:execute(125): `conda run conda-lint /tmp/abs_3ffpw04ns4/clone` failed. (See above for error)
The following problems have been found:
===== WARNINGS =====

clone/recipe/meta.yaml:44: missing_description: The recipe is missing a description
clone/recipe/meta.yaml:17: avoid_noarch: noarch: python packages should be avoided

===== ERRORS =====

clone/recipe/meta.yaml:1: patch_must_be_in_build: patch must be in build when source/patches is set.
clone/recipe/meta.yaml:44: missing_documentation: The recipe is missing a doc_url or doc_source_url
clone/recipe/meta.yaml:44: missing_license_family: The recipe is missing the about/license_family key.
===== Final Report: =====
3 Errors and 2 Warnings were found

Linter check found the following problems:
ERROR conda.cli.main_run:execute(125): `conda run conda-lint /tmp/abs_b3evcpw30g/clone` failed. (See above for error)
The following problems have been found:
===== WARNINGS =====

clone/recipe/meta.yaml:17: avoid_noarch: noarch: python packages should be avoided
clone/recipe/meta.yaml:45: missing_description: The recipe is missing a description

===== ERRORS =====

clone/recipe/meta.yaml:1: patch_must_be_in_build: patch must be in build when source/patches is set.
===== Final Report: =====
1 Error and 2 Warnings were found

Linter check found the following problems:
ERROR conda.cli.main_run:execute(125): `conda run conda-lint /tmp/abs_78aed0tfdf/clone` failed. (See above for error)
The following problems have been found:
===== WARNINGS =====

clone/recipe/meta.yaml:17: avoid_noarch: noarch: python packages should be avoided

===== ERRORS =====

clone/recipe/meta.yaml:1: patch_must_be_in_build: patch must be in build when source/patches is set.
===== Final Report: =====
1 Error and 1 Warning were found

Linter check found the following problems:
ERROR conda.cli.main_run:execute(125): `conda run conda-lint /tmp/abs_7fuf9jyaan/clone` failed. (See above for error)
The following problems have been found:
===== WARNINGS =====

clone/recipe/meta.yaml:19: avoid_noarch: noarch: python packages should be avoided

===== ERRORS =====

clone/recipe/meta.yaml:1: patch_must_be_in_build: patch must be in build when source/patches is set.
===== Final Report: =====
1 Error and 1 Warning were found


Example on react native

Is there any example on how to set the script on react native? I'm trying to import the library and include a log on the render function, but it prints an empty object.
Ex:
import platform from 'platform';
render() {
console.log(platform);
Prints: {}

Hello, I think I found the problem myself here. The first test I made, I was using the Expo XDE, now I tried with vanilla React Native and got the right info:
{"description":"Chrome 57.0.2987.133 on OS X 10.12.4 64-bit","layout":"Blink","manufacturer":null,"name":"Chrome","prerelease":null,"product":null,"ua":"Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/57.0.2987.133 Safari/537.36","version":"57.0.2987.133","os":{"architecture":64,"family":"OS X","version":"10.12.4"}}
So, the problem is the Expo XDE...
Sorry for the rushed question here.

Sadly it just only worked on the ios simulator. Android emulator and running directly on ios device don't return any values...


missing alert when 'save' if required obs fields not filled out on obs/new

clicking save here;
http://www.inaturalist.org/observations/new?project_id=871&taxon_id=54541
without filling out the required obs fields should trigger an alert - currently its unclear why its not saving, e.g. the button is just broken?

tested it here http://www.inaturalist.org/observations/new?project_id=2969 seems fixed