Add route /job-run

Description
Currently /pipeline is used both for editing a pipeline and viewing a read-only pipeline of a job run. This causes quite a few bugs. For example, the root view while viewing a job run becomes /pipelines, where it should have been /jobs. And read-only state might be reset when user refreshes the page.
This PR creates a new route: /job-run and re-use the same component PipelineEditor. /job-run shows the pipeline always in the read-only mode, and its root view is /jobs.
Edit: because this PR remove the unnecessary re-rendering. PipelineEditor in read-only mode has missing connection lines until first session polling response. Thus, this PR also fixes this issue.
Checklist

[x] The PR branch is set up to merge into dev instead of master.

I think it might be best to postpone this PR. All other views as part of jobs still select Pipelines.
Steps to reproduce

Create a job
Open a pipeline run
See that Jobs is correctly selected
Open the settings of the pipeline
See that Pipelines is incorrectly selected
Repeat this with Logs and when viewing a step (View file or double clicking it)

@yannickperrenet Said cases are covered in the new commit. the proposed solution is following the same pattern.
Pipeline settings of a job run => /job-run/pipeline-settings
Logs => /job-run/logs

The edge case of "View file or double clicking it" is not fixed yet.

Should be fixed in the new commits. Thanks for catching it!

Also, after refreshed the page (when looking at the pipeline in read-only mode of a job), the connections only appear after a few seconds. I thought that this issue should also have been fixed in this PR?

I made a mistake when doing cherry-picking and rebasing. Just restore the commit.


Remove meta dependency on docker role for the kubernetes_common role

This dependency causes unnecessary provisioning of docker related resources. Nothing gets ever changed and running it multiple times causes unwanted delay for the whole deployment process.

Looks like tuning task similar to #809

I believe this one has been already done as a part of this milestone https://github.com/epiphany-platform/epiphany/milestone/13.  :+1:


Switch Middleware to use exception factory

The RequestException::create factory was not being used anywhere.
Using it inside of Middleware::httpErrors simplifies the code and
allows for simpler changes in the future.
Also updates the message formatting of the exception factory to
provide a more complete status, including the body of the response.

I like the factory change a lot.
I'm open to modifying the exception message, but I'm not sure that the response body should be part of the message. There have been several issues over time related to exception messages being too large because the response body is part of the message. It looks like the $label variable is no longer part of the message-- can we make sure to include that? I wonder if the message should be more human readable too-- something like Server error response: sending a GET request to /xyz resulted in a 500 Internal Server Error response
The tests will need to be updated for this change as well.

@mtdowling anything else I need to do to get this accepted? It is causing us some issues debugging.

I made a couple small tweaks and merged. Thanks!


Qusetion about "user"

[Enter feedback here]
There are references to a "user" in the below steps, but I don't see where it explains what that user is.
On the resource group the Azure Synapse workspace is located, the service principal and the user for audience insights needs to be assigned at least Reader permissions. For more information, see Assign Azure roles using the Azure portal.
The user needs Storage Blob Data Contributor permissions on the Azure Data Lake Storage Gen2 account where the data is located and linked to the Azure Synapse workspace. Learn more about using the Azure portal to assign an Azure role for access to blob and queue data and Storage Blob Data Contributor permissions.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 889c047e-f0fb-1919-1e66-072c3167dd0a
Version Independent ID: b3d73eb4-0207-b460-43a9-3a4d9fe335d9
Content: Export Customer Insights data to Azure Synapse Analytics - Dynamics 365 Customer Insights
Content Source: ci-docs/audience-insights/export-azure-synapse-analytics.md
Service: customer-insights
Sub-service: audience-insights
GitHub Login: @stefanie-msft
Microsoft Alias: sthe

Thanks for your comment, @pouelletcoopgit. This issue has been assigned to the doc author for review.

Hello @pouelletcoopgit, thank you for sharing your feedback. Would it be clearer to you if we'd refer to "an Azure AD user who can access both, Azure services and Customer Insights"?
Happy to dig into this more with the SME on the product side and follow up after hearing your feedback.
Thanks,
Michael

Hi!
If the reference to "the user" is meant to explain that in order to set permissions in azure, you need an azure user with the ability to set permissions on those objects then maybe adding it as a preface to the steps would make more sense?
In essence we are setting customer insights service principal access to the synapse workspace resource group, datalake etc. Adding reference to another user in those steps is what may add confusion.
Thanks.
Patrick Ouellet | Solution Designer - Technology
Cloud and Hosting Services | Groupe Co-operators limitée
2875 Boul Laurier D3-501, Québec (Québec)  G1V 2M2
Tél. :<PHONE_NUMBER> | Numéro sans frais : 1-855-850-2667, poste 313000
[Co-operators Logo]
From: Michael Hartmann @.>
Sent: April 8, 2022 8:02 AM
To: MicrosoftDocs/customer-insights @.>
Cc: Patrick Ouellet @.>; Mention @.>
Subject: Re: [MicrosoftDocs/customer-insights] Qusetion about "user" (Issue #23)
Courriel externe : Veuillez ne pas suivre les directives, cliquer sur les liens, ouvrir les pièces jointes, transférer le courriel ou y répondre, sauf si vous reconnaissez l'expéditeur et savez que le contenu est sûr.
External email: Do not follow instructions, click links, open attachments, forward or respond to the email unless you recognize the sender and know the content is safe.
Hello @pouelletcoopgithttps://can01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fpouelletcoopgit&data=04|01|patrick.ouellet%40cooperators.ca|295dcbb214cd4b75b9cf08da19578f17|2e0565a853ce4c589dda5ea21ae6b16d|0|0|637850161097008972|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=HbcbHLtwZBj87Nk8HeVy8TGk9mRPeCiX7DAYhIa%2BhbA%3D&reserved=0, thank you for sharing your feedback. Would it be clearer to you if we'd refer to "an Azure AD user who can access both, Azure services and Customer Insights"?
Happy to dig into this more with the SME on the product side and follow up after hearing your feedback.
Thanks,
Michael

Reply to this email directly, view it on GitHubhttps://can01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fcustomer-insights%2Fissues%2F23%23issuecomment-1092787741&data=04|01|patrick.ouellet%40cooperators.ca|295dcbb214cd4b75b9cf08da19578f17|2e0565a853ce4c589dda5ea21ae6b16d|0|0|637850161097008972|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=%2Bk7wY8761%2FhzIa2JMlqw2RnTNqqd4TQLL%2BGwKPL3lk8%3D&reserved=0, or unsubscribehttps://can01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FASQJKNHJP77EZZRMPONFZADVEAN2XANCNFSM5S2JBHJQ&data=04|01|patrick.ouellet%40cooperators.ca|295dcbb214cd4b75b9cf08da19578f17|2e0565a853ce4c589dda5ea21ae6b16d|0|0|637850161097008972|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=e3UtEIKTsaLsxq92FF4vys0%2FeUKLv%2BNq7pcQt1tWiLc%3D&reserved=0.
You are receiving this because you were mentioned.Message ID<EMAIL_ADDRESS>Avant d'imprimer ce message, pensez à l'environnement.
Ce message, y compris tout document qui y est annexé, peut contenir des renseignements confidentiels et privés destinés exclusivement à son destinataire. Toute utilisation, copie ou divulgation non autorisée est strictement interdite. Si vous avez reçu ce message par erreur, veuillez en aviser immédiatement l'expéditeur par courriel et détruire ou supprimer toutes les copies existantes de ce message. Nous prenons des mesures de protection raisonnables pour protéger toute information recueillie, utilisée, conservée et divulguée dans le cadre de nos affaires; cependant, un courriel est susceptible d'être intercepté par des tiers non autorisés. Nous vous déconseillons de communiquer par courriel des renseignements personnels ou sensibles. Si vous nous avez fourni votre adresse courriel ou que vous nous avez envoyé un courriel, nous tenons pour acquis que vous acceptez de communiquer avec nous par courrier électronique. Si vous ne voulez pas recevoir de courriels de notre part, veuillez nous en aviser dans les plus brefs délais.
Please consider the environment before printing this message.
This message, including any documents attached, may contain privileged and confidential information intended for the recipient only. Any unauthorized use, copying or disclosure is prohibited. If you have received this message in error, please notify the sender by email and delete or destroy all copies of this message. We use reasonable safeguards to protect all information collected, used, retained and disclosed in the course of conducting business; however, email may be vulnerable to interception by unauthorized parties. We discourage you from emailing personal or sensitive information. If you provided your email to us, or if you contacted us by email, we accept this as your consent to communicate with you by email. If you do not wish for us to communicate with you by email, please notify us at your earliest convenience.

Hello Patrick,
thank you for getting back to us. We tweaked the documentation to refer more clearly to the required user permissions for the AD user that is setting up the export as well as the service principal. I hope this clarifies the requirements and reduces confusion.
Btw, I edited your email response above and removed your personal details from the message because it's accessible for everyone.
Please reopen the issue or create a new one if you think the content is still unclear.
Thanks!
Michael


could you provide a demo code for test the video in the wild?

@whwu95 I second this. It would be great to have this demo!


Why UploadFile is not exposed?

If you expose UploadFile we can use it as parameter type of fileUpload event. As we are using typescript provide the type is a good approach.

https://github.com/jkuri/ng2-uploader/commit/f55b48e41967eee83fbcb313b3e65c199ff5cab1


Operators : Squeeze, displaceop. Addition : expm, full

An attempt at implementing expm, full (sparse to dense) as expm is not implemented for sparse matrix. With respect to the implementation of expm with respect to sparse matrix, I have been referring to the https://github.com/JuliaLang/julia/issues/10035 which had hints at scipy implementation. The scipy implementation is based on the following algorithm (http://core.ac.uk/download/pdf/17664.pdf) as cited in the documentation. I will try a hand at implementing this if already not implemented, but that said as exponentiation is only available for dense matrix, I have implemented full function and added the expm on the top of that.
Also the * method using DualMatrix was giving some inconsistent results, an attempt has been made to get it work.
Any comments would be helpful. Thanks

I think for sparse matrices one mostly wants to avoid calculating expm directly, since the latter is typically dense and large. This is the reason why empv et al are so important. For those one rather computes expm*v where v is some vector. That said, I think that expm(full(S)) is fine for small problems. If one is really serious about it, one needs something like expmv for QuArrays and functions that displace/squeeze/etc a vector. If we want to include such functions in QuBase, we can pull in Expokit.jl or ExpmV.jl for instance.

@acroy At some point, we should probably include a definition like the following to dispatch on for sparse QuArrays:
typealias SparseQuArray{B,T,N,S<:AbstractSparseArray} QuArray{B,T,N,S}

If we want to include such functions in QuBase, we can pull in Expokit.jl or ExpmV.jl for instance.

+1, and I think it makes sense to include those functions (in the form of using the packages, of course).

I would suggest to wait with using Expokit.jl et al. We have to look into it for the propagators anyways.
+1 to SparseQuArray.

One build passes and the other build fails. The error says "does not pass tests in QuBase" for the second build. Any insights would be helpful.

I guess the Travis failure is not related to this PR. Might be a consequence of JuliaLang/julia#10380. @jrevels : Any ideas?

@acroy done with the edits.

Looks Ok, but I want to wait for @jrevels to comment on the Travis failure. Could you add a test for displaceop? If one applies the displacement op to the ground state, one gets a coherent state and you can test if the elements in the state vector are correct.

@acroy I get an
ERROR: InexactError()
 in setindex! at sparse/sparsematrix.jl:1253
 in generic_scale! at linalg/generic.jl:18

when I use the combination of complex type for alpha parameter in displaceop. So I have replaced it with scale. I will work on this and see if this can be made to work if possible with scale.

I guess you have to use @test_approx_eq or similar. Why do you "hard code" the expected result instead of calculating exp(-1/2) or whatever for the coefficients?

@acroy we could have done something like
exp(-0.5)*(statevec(1,FiniteBasis(2))+statevec(2,FiniteBasis(2)))
2-element QuVector in FiniteBasis{Orthonormal,1}:
...coefficients: Array{Float64,1}
[0.6065306597126334,0.6065306597126334]

which is not equal to the required output. (Truncated version)
We could define coherent state as
coherent(n::Int,alpha::Number) = displaceop(n,alpha)*statevec(1,FiniteBasis(n))

# then test as

coherent(2,1) == displaceop(2,1)*statevec(1,FiniteBasis(2))

We could also have the expansion of coherent states i.e., |alpha> = exp(-mod(alpha)^2)/2)*(sigma[(alpha)^n/sqrt(n!)|n>)

A function coherentstatevec should probably either be implemented using the displace function (which will use expmv) or directly using the expansion in Fock states. But your version is probably Ok for now.
Anyways, the test probably fails because your basis is too small. Using QuDOS.coherentstatevec I get
julia> cs = QuDOS.coherentstatevec(10,1.)
QuStateVec{Array{Complex{Float64},1}}(Complex{Float64}[0.606531+0.0im,0.606531+0.0im,0.428882+0.0im,0.247615+0.0im,0.123808+0.0im,0.0553686+0.0im,0.022603+0.0im,0.00854887+0.0im,0.00299672+0.0im,0.00110007+0.0im],10,[10])

julia> cs[1]
0.6065306597114603 + 0.0im

julia> exp(-0.5)
0.6065306597126334

julia> Base.Test.@test_approx_eq_eps real(cs[1]) exp(-0.5) 1e-6

You might be able to use a similar test if you increase the basis size.

@acroy I have made an attempt at implementing coherentstatevec using expm as well the expanding the summation. I have added the tests for displaceop using the same. A review would be helpful.

I solved the issue with the Travis failure (see #26). Please rebase and squash after addressing the final comments.

@acroy
I have tried these things out. Locally they pass for me, but the build-bot shows an error
println(coeffs(displaceop(2,1.0)'))
println(coeffs(squeezingop(lowerop(2), QuArray(eye(2)),2.0)))
println(@assert coeffs(squeezingop(lowerop(2), QuArray(eye(2)), 2.0)') == coeffs(displaceop(2,1)))
println(@assert squeezingop(lowerop(2),QuArray(eye(2)), 2.0)' == displaceop(2,1))

[0.5403023058681398 0.8414709848078965
 -0.8414709848078965 0.5403023058681397]
[0.5403023058681398 0.8414709848078965
 -0.8414709848078965 0.5403023058681397]
nothing
nothing

Does it make a difference if you take coeffs(displaceop(2,1.0)) in the last assert (note the 1.0)? Otherwise you have to resort to @test_approx_eq or @test_approx_eq_eps.

But locally for me it is passing, I guess it should pass by the build-bot as well, right ? I am missing something here ??

It's strange but it can happen. In the worst case you have to put in println statements like in your local test.

The == in your @test_approx_eq commit is superfluous ...

Hah, nice! Could you please squash your commits. I will have another look tomorrow, but I think everything looks good now.


charts are not published in chart repo

As a get from helm, latest chart versions available at https://open-telemetry.github.io/opentelemetry-helm-charts are:
>> helm search repo open-telemetry -l
NAME                                  	CHART VERSION	APP VERSION	DESCRIPTION
open-telemetry/opentelemetry-collector	0.43.2       	0.67.0     	OpenTelemetry Collector Helm chart for Kubernetes
...
open-telemetry/opentelemetry-operator 	0.20.3       	0.66.0     	OpenTelemetry Operator Helm chart for Kubernetes

but much newer versions are released in the repo.

@dvelben try doing a helm repo update.

My bad. CACHED layer at Docker. Thnx.


UI manage API keys

User Story

As a msadoc user,
I want to create API keys for my CI scripts
in order to push msadoc.json files via CI without exposing my password / JWT

Acceptance Criteria

UI page allowing to create new API keys (with a name and expiration period), the key can be copied
UI page listing all API keys
API keys can be deleted (after confirmation)

Closed by #112


[5.3] SIL: fix memory behavior of global_addr for globals with non-fixed layout.

Global variables with resilient types might be allocated into a buffer and not statically in the data segment.
In this case, the global_addr depends on alloc_global being executed first.
Letting global_addr have a side effect ensures that this dependency is kept.
It prevents e.g. LICM to move a global_addr out of a loop while keeping the alloc_global inside the loop.
rdar://problem/61602640

@swift-ci test


Made the antlr and scala profiles activate themselves on-demand

Cleaned up the oder of entries in the pom.xmls
Added a prerequisiteCheck.groovy to check all known conditions before starting the build and giving the user feedback on what he has to do.

Code review done, can be merged.

thanks for fixing the build, since "main" fails to build for me.
+1, lgtm


Tutorial request: Managing state and interactivity

Continuing on a trail/thread from Layouts, we'd like to show how to make the layout interactive.

Done.https://sz-flutter.firebaseapp.com/tutorials/interactive/


#3 Use invariantSeparatorsPath when finding exclusions

I didn't know that extension existed, nice. Fixed.


Firefox Compatibility, Firefox Selector

Both issues were fixed by creating a firefox selector for tailwind css that detects when firefox is being used. The code for this was quite literally copied and pasted from goated link.

@BeeverFeever You should create a new branch for new changes, as I had to add back my scroll message, thanks lol.

lmaoooooooooo
but no, that scroll message deserves to disappear. it really isnt needed and it doesnt look good at all


Reorder columns

Just wondering if there's any interest in draggable column headings for column re-ordering. This is the one feature missing that is stopping us dropping this in.
Has it been looked at previously? Would you consider a PR for it?

There is actually! @henryvonfire put something together not too long ago so it would be awesome if you guys could work together or one of you can submit a PR and we can productionize it. The new beta (1.0.0-beta.5) has support for column and cell types so it would be pretty easy to get setup.

Hmm its an interesting one. Obviously its ideal if the column dragging can occur without rerendering cells, but that sounds like needing some fancy relative positioning instead of a simple table. Think I'll wait to hear if @henryvonfire has any thoughts or a head start on it.

Sorry, last week I was busy and couldn't give any time to this. I've created a PR with a new column type for dragging columns. It's not completed (I haven't taken into account column groups yet) but I want you to tell me if this is the right approach or if you were thinking about something else.

Sounds good. I've been working on a POC myself, will be interesting to compare notes. I'll be pushing a branch up soon to take a look at.

You can see my work so far at https://github.com/eddiesholl/ember-light-table/tree/reorder-columns. I'm using this app to drive it, with npm link of the ember-light-table app: https://github.com/eddiesholl/ember-light-table-demo

Is this feature still being considered?

@jamespenick Yeah I should have something put together in the next week or two!

Fantastic, thanks for the update!

@offirgolan is this still in the works?  Not trying to pester just curious if it's still in your immediate roadmap.

@trumb1mj I actually have a fully working branch on this. Just need to clean it up 😄


Update requirements.txt

Rasa Core version: latest
Python version:  3.7.0
Operating system (windows, osx, ...): ubuntu 16.04
Issue:
The requirements.txt specifies tensorflow==0.12.0. However no such version exist and the rules being >= 0.12.0 and < 0.13.0 creates an error. Please update tensorflow version to tensorflow ="1.13.0rc2" .

Thanks for raising this issue, @Ghostvv  will get back to you about it soon.

python 3.7 is not yet supported, we're planning to add it soon


Migrate to log4j 2

Quoting @tfmorris from https://github.com/OpenRefine/simile-butterfly/pull/2#issuecomment-634997530:

Both log4j 1.2.16 and 1.2.17 have a security vulnerability which isn't going to be fixed since log4j 1 is end of life. This should be migrated to log4j 2 instead (which appears to have a compatible API).

This was done.


Portal: Deleting departments currently does not work at all

Even if the staff count is 0, the button to delete a department is greyed out.

Test and confirm please

Deleting Future Visioning (which correctly shows 0 members now) returns a
500 in the console.
On Fri, Oct 18, 2019 at 9:59 PM Aric Stewart<EMAIL_ADDRESS>wrote:

Test and confirm please
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/CON-In-A-Box/CIAB-Signin/issues/304?email_source=notifications&email_token=AAISDXFLNYATW27E4L4BW63QPJZZ5A5CNFSM4JA6TO32YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBW457A#issuecomment-544067324,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAISDXHFRME5R4KK56C6L2TQPJZZ5ANCNFSM4JA6TO3Q
.

Correction made.  Please tryin again.

This now works. However, ADDING a department, adding an e-mail 500s.
On Sat, Oct 19, 2019 at 8:18 PM Aric Stewart<EMAIL_ADDRESS>wrote:

Correction made. Please tryin again.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/CON-In-A-Box/CIAB-Signin/issues/304?email_source=notifications&email_token=AAISDXHH4U4EA6BI6MBIWZDQPOWV3A5CNFSM4JA6TO32YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBYAAEA#issuecomment-544210960,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAISDXGGVDMIQLECSG5KXSDQPOWV3ANCNFSM4JA6TO3Q
.

Correction: if I actually remember to SAVE the new department, then adding
email to it works. Adding email should either work before it's saved, or
not be available before it's saved, just to prevent the mistake.
On Sat, Oct 19, 2019 at 9:40 PM Michael Scott Shappe <
<EMAIL_ADDRESS>wrote:

This now works. However, ADDING a department, adding an e-mail 500s.
On Sat, Oct 19, 2019 at 8:18 PM Aric Stewart<EMAIL_ADDRESS>wrote:

Correction made. Please tryin again.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<
https://github.com/CON-In-A-Box/CIAB-Signin/issues/304?email_source=notifications&email_token=AAISDXHH4U4EA6BI6MBIWZDQPOWV3A5CNFSM4JA6TO32YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBYAAEA#issuecomment-544210960
,
or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/AAISDXGGVDMIQLECSG5KXSDQPOWV3ANCNFSM4JA6TO3Q
.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/CON-In-A-Box/CIAB-Signin/issues/304?email_source=notifications&email_token=AAISDXHYUG4VNZJXQDJNFRDQPPAJFA5CNFSM4JA6TO32YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBYA7EQ#issuecomment-544214930,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAISDXB44J5XGUBLOPGFURLQPPAJFANCNFSM4JA6TO3Q
.

Is this fixed?

Yes


arc_read() ignores n_max = Inf

res <- arc_read("https://services.arcgis.com/P3ePLMYs2RVChkJx/arcgis/rest/services/USA_ZIP_Code_Points_analysis/FeatureServer/0", n_max = Inf)

compare this with setting n_max = 1e10

I think I fixed this by always using the n_feats instead of n_max if n_max is infinite 9c130e8 (#167). After the refactor in that PR, I was actually getting an error with n_max = Inf which is why I touched this part.


Expose the compact api on Win32

The .NET assembly isn't aware if we're running on Windows or other platform, so there's no elegant way to prevent it from calling into those missing methods. Furthermore, the other compact methods are not behind and #ifndef, so for consistency's sake, we shouldn't hide these either.

https://github.com/realm/realm-core/blob/v2.6.0/src/realm/group_shared.hpp#L413-L414

WARNING / FIXME: compact() should NOT be exposed publicly on Windows
because it's not crash safe! It may corrupt your database if something fails

I'm not really sure why compact() isn't crash-safe on Windows. It uses copy() rather than move() which results in the file being corrupted if the process crashes in the middle of the copy, but it's not obvious why, as Windows does have atomic renaming.

Agreed. However, ObjectStore isn't the public API. We're throwing when compacting on Windows - https://github.com/realm/realm-dotnet/pull/1389/files#diff-8c3f214c5d8da72534fc6d685d3305a9R220, but hiding those methods means our structs would have different layout, which would cause all sorts of problems.

If nobody objects, I'm going to go ahead and merge that.

If you merge this, you should at least restate the risks of calling into this on Windows.


Fix run_unit_tests.sh

I don't know if it's a mistake, but the airflow/www/static/coverage does not exist. So, if anyone want to try run_unit_tests.sh, he will have an error from rm and he will not able to use it.
Moreover, in https://github.com/airbnb/airflow/blob/master/CONTRIBUTING.md#testing you don't specify to install nose so you can add it to your requierements.txt or specify it in your CONTRIBUTING.md
To finish, are you interested by the output of the test ?

Yes indeed we are interested in the html results of the test. Notice that there's a symlink pointing to that folder from the web server's static folder here:
https://github.com/airbnb/airflow/blob/master/airflow/www/static/docs
You're right, nose should be in the requirements.txt and the setup.py devel extras_require
The idea with the rm statement is to make room for the new export, the bash script should create the folder if it doesn't exist, then empty it to make place for the output of nose

@globus. I had an old open PR to do this :
if [[ -d "airflow/www/static/coverage" ]]
then
  rm airflow/www/static/coverage/*
else
  mkdir -p "airflow/www/static/coverage"
fi

Feel free to reuse

Your else is not usefull because you use -p for mkdir and just adding -f to remove should the error message and so you can remove the if.

a6f42ab4b805c09694892c30a847ac868d912e0e and 49201eef25f5b74b581f9da5d0cbb8797c95cb76 are equivalent to this, closing. Thanks for pointing these out!


Ble connection issues. bleManager.pairingMode() needs to be explicitly called

Note that main() should not call bleManager.init or bleManager.pairingMode. uBit.init does that, so long as the codal.json has the correct settings to enable BLE.

For more context see the entire chain on #105.
codal.json (note that the url/branch is not an issue)
{
  "target": {
    "name": "codal-microbit-v2",
    "info": "This target specifies the micro:bit V2, based on the nordic NRF52833",
    "url": "https://github.com/lancaster-university/codal-microbit-v2",
    "branch": "master",
//    "url": "https://github.com/martinwork/codal-microbit-v2",
//    "branch": "ble-uart-send",
    "type": "git"
  },
  "config":{
    "DEVICE_DMESG_BUFFER_SIZE": 4096,
    "DMESG_SERIAL_DEBUG": 1,

    "DEVICE_BLE": 1,
    "MICROBIT_BLE_ENABLED" : 1,
    "MICROBIT_BLE_PAIRING_MODE": 1,
    "MICROBIT_BLE_DFU_SERVICE": 1,
    "MICROBIT_BLE_DEVICE_INFORMATION_SERVICE": 1,
    "MICROBIT_BLE_EVENT_SERVICE" : 1,
    "MICROBIT_BLE_PARTIAL_FLASHING" : 1,
    "MICROBIT_BLE_SECURITY_LEVEL": "SECURITY_MODE_ENCRYPTION_NO_MITM"
  }
}

Regarding bleManager.init() etc, it was my understanding too that they should not be explicitly called, but while I could indeed remove bleManager.init() it seems like I still need to explicitly call bleManager.pairingMode() in order to connect to the micro:bit. Neither "MICROBIT_BLE_PAIRING_MODE": 1 nor bleManager.advertise() (for trying to connect with previously paired device) seems to work.
nRF Connect (android app) shows that the micro:bit does not advertise with only "MICROBIT_BLE_PAIRING_MODE" being set.
When using bleManager.advertise() nRF Connect can see that the micro:bit is scanning but connecting does not work despite already being paired.
Explicitly calling bleManager.pairingMode() does allow connecting to the micro:bit, both for already paired devices and also new devices.

With a secure pairing mode like SECURITY_MODE_ENCRYPTION_NO_MITM, the micro:bit only advertises to paired devices, unless it is reset into pairing mode.
Pairing is easiest with the Android or iOS micro:bit app, though on Android you can pair in Settings after putting micro:bit into pairing mode.
The usual way into pairing mode is to press and release the micro:bit RESET button while holding down buttons A and B, then continue to hold A and B until the LEDs fill and then show a Bluetooth symbol. micro:bit will then show its identifying histogram and be advertising to all devices.
Having paired micro:bit with a device, that device will see micro:bit advertising in normal application mode.
It's possible to do without secure pairing by specifying "SECURITY_MODE_ENCRYPTION_OPEN_LINK" in the codal.json.
See https://github.com/martinwork/microbit-v2-samples/blob/master/source/samples/BLETest.cpp#L67

bleManager.pairingMode() is called here  when A+B+RESET is used to enter pairing mode.


DoctrineKeyValueStyleRule: properly handle unions

If any of the arguments (table name or parameter values) to the DoctrineKeyValueStyleRule methods are a union type, each subtype will now be checked independently.
Previously, union types would cause an error, because of the improper use of instanceof *Type checks. This is now fixed by using methods to get the constants, e.g. getConstantStrings(), as recommended in https://github.com/staabm/phpstan-dba/pull/564#discussion_r1133053061.

thank you


Fix windows title update

This tries to fix #6.
We ask the X server to report PropertyChange events for visible windows.
This will trigger an event when the title changes, so we can output the windows list with their up-to-date title.
XSelectInput(d, wlist[i].id, PropertyChangeMask);

We only call XSelectInput on new windows, and avoid calling it multiple times if not needed. This is because XSelectInput locks the display (source).

Thanks! Looks very interesting what you're cooking. Something that has been hard to find info on :smile:

Seems great and cleanly done too.
I tried it with name="title" on, it especially makes using browsers with tabs so much better.
I could think of a test to see if non-active windows update: I set my terminal window title as current working directory.

Focus terminal
sleep 5; cd ..
Focus other window
See if bar updates

Yes it works
Any potential issues? I don't really know what LockDisplay could entail in practice, but with quick testing it seems OK.
Let me know if we are ready to merge this, or if there's anything you wanted to work on here still.

I don't really know what LockDisplay could entail in practice

Me neither, but I wanted to avoid too many calls to it :smile:

The only downside I'm seeing is the amount of events we are now receiving, which causes us to recalculate and output the windows list.
I'll spend some more time figuring out if we can only select the events we are interested in.

Ok, sounds good!
Yeah I was thinking about that (refreshing so many times) also in the case of dragging a window back when I added the position sorting.
Pro-tip it's especially easy to see when rapid bar-updating happens by:

Running ./main in terminal
Dragging a window aroung (for example)

I have been wondering if it's an issue for machines with lower specs. But for me, it's still as good as instant.

it's still as good as instant

Same for me. Maybe it's not really an issue.

Also if too much bar updating is an issue, we could add config checks:

if name="class", no need to call configure_windows_notify
if not sort_by="position" no need to listen to geometry events (was it the SubstructureNotifyMask?)

So, by enabling SubstructureNotifyMask in the root window we get geometry events for all windows, and by enabling PropertyChangeMask we only get updates on the windows list (but not on those windows' properties)?
It's not super clear from the Xlib documentation: this PR adds a PropertyChangeMask to a single window because in fact we couldn't get title updates.
Anyway, let me know if you want these checks to be implemented.

Oh yeah, about that PropertyChangeMask... Is it needed anymore on the root window at all?
I should test that out. One thing about it was if I understand correctly that we get notified of changes in _NET_ACTIVE_WINDOW, but is it different if it's on a (single) child window?
(Forgive me, this stuff is so confusing :smile: )

Ohh yeah yeah, it's coming back to me. So, by listening to root window's properties, the exact properties of the root window that we are interested in are:
_NET_CLIENT_LIST(WINDOW): window id # 0xc00001, 0x2a0000a, 0x1e000ed, 0x2000003, 0x1e015db, 0x1600003
_NET_ACTIVE_WINDOW(WINDOW): window id # 0x1600003

by listening to root window's properties, the exact properties of the root window that we are interested in are:

_NET_CLIENT_LIST(WINDOW): window id # 0xc00001, 0x2a0000a, 0x1e000ed, 0x2000003, 0x1e015db, 0x1600003
_NET_ACTIVE_WINDOW(WINDOW): window id # 0x1600003

Ok it makes sense actually. Just a bit confusing :sweat_smile:

Do you want to merge, or does this raise some further questions?

I'm fine with it if you are fine with it. It looks good to me.

Great if I was able to clarify something.
Ok! I'll merge. Thanks for the PR, it's very valuable.


EO up to 0.28.2

#33

@yegor256 Please, have a look. I'm disabling tests with string.as-hash method, and up EO version

@rultor merge

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 3min)

@rultor release, tag is 0.0.4

@rultor release, tag is 0.0.4

@yegor256 OK, I will release it now. Please check the progress here

@rultor release, tag is 0.0.4

@yegor256 Done! FYI, the full log is here (took me 17min)


create parent dir for hashfile if not exists

Relates to #347
This makes sure that hashing works after cargo clean.

Seems reasonable to me. Thank you!


[ESS] Release Checks

This issue tracks all relevant release checks for KITs.
Release Info
Please provide information on what you want to be included in the Eclipse Tractus-X release.
If you are not owner of this issue, please provide the information as comment to the issue.
If changes to your KIT are not yet live on our website, link the open PR introducing the changes for this release.

First kit release for ESS (Enironment and Social Standards) use case

https://github.com/eclipse-tractusx/eclipse-tractusx.github.io/pull/709

PR 709

General

[ ] CHANGELOG available and maintained

Adoption View

[x] Vision and Mission statement present
[x] Business Value statement present
[x] Semantic Models linked and described
[ ] Logic / Schema available and described
[x] Business Process documentation available
[x] Access and Usage Policies documented
[x] Standards submitted / published via the Catena-X e.V. process and linked with current version (e.g., semantic models)
[ ] Tutorials available
[ ] White Paper available
[x] Notice CC BY 4.0 licence statement available

Development View

[ ] API Specification published on SwaggerHub
[ ] Protocols available (e.g., dataspace protocol)
[x] Sample Data available
[ ] Architecture integration into the overall Catena-X architecture and / or product architecture (e.g., Arc42) available.
[ ] Reference Implementation available

Operation View

[ ] Setup Guide available (e.g., installation guides)
[ ] Deployment Script available (e.g., helm charts)

Helpful Links

Catena-X standard library

@birgitZF can you please set the checkmarks for the artifacts / content that you provided with the KIT

@maximilianong I am not sure with some of the checkmarks, e.g. Logic / Schema, we have pnly got one standard: essINcident - data model
@maximilianong when is the deadline? I still have open questions about the table format to @stephanbcbauer

Final pull request needs to be done til the 04.03.2024
Should we setup one meeting to clarify?
Because I have some concerns if this is already a real KIT or still a preview of a KIT. Maybe we can have this discussion aswell.

PR created 04.03.2024
https://github.com/catenax-eV/product-standardization-prod/pull/125

@birgitZF  & @maximilianong  please check once the ticket details. I am assuming that the ticket is related to 24.03. If thats the case, please update the milestone on the right hand side

As soon as this is done; the status needs to get adjusted as well.
Please note: if this is an issue ticket for Post-Consortia; the milestone should stay empty

@jjeroch, you are right, the kit is for 24.3. I have no authorization to edit the right hand side, there is no settings- button for me
@maximilianong , can you change the label for me, please?

handled separately in PR


Fix a few deadlock in tcp/iob

Summary
Fix a few deadlock in tcp/iob.
see the commit messages for details.
Impact
tcp/iob
Testing
tested with some of the other patches in https://github.com/apache/incubator-nuttx/pull/4184

i will restart jobs as the failure looks unrelated to this PR.
curl: (6) Could not resolve host: github.com


Move .codecov.yml

the file must still be located in the root, dev/, or .github/ directories

https://docs.codecov.io/docs/codecov-yaml#can-i-name-the-file-codecovyml
CC @bo98

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.

[x] Have you successfully run brew tests with your changes locally?

@Bo98 Does this still look like it's not working to you?

Well this PR shouldn't be red, but I have no idea whether it correctly takes codecov.yml files in PRs or not.

https://docs.codecov.io/docs/codecov-yaml

Codecov will use the default branch for your repository as the "master" copy of the repositories Codecov Yaml.

I don't know what "master copy" means but ok

Codecov will always use the current yaml on the branch being tested by default.

I guess it isn't working?

cat .github/codecov.yml | curl --data-binary @- https://codecov.io/validate

Wrong keys 'coverage', 'fixes' in {'fixes': ['::Library/Homebrew/'], 'coverage': {'round': 'nearest', 'status': {'project': {'default': {'threshold': '0.05%'}}}}}

@Bo98 Thanks, good catch, updated.


⚠ Bofrost.be has degraded performance

In 1bea5d5, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 3016 ms

Resolved: Bofrost.be performance has improved in 7651748 after 14 minutes.


[FX-392] Move merchantAccount + bearerToken to Config

What

Move merchantAccount and bearerToken from the submit methods to the ForageSDK.Config
Call ForageSDK.setup() with the new ForageSDK.Config to update the environment, session token, merchant account, and/or bearer token

Why
https://linear.app/joinforage/issue/FX-392/move-merchantaccount-bearertoken-to-foragesdksetup-in-forage-ios-sdk
Opted against using @available and gracefully deprecating the old method signatures (make the change reverse compatible), since only one client will have to make this small + trivial change on their end and we're currently making other breaking changes to the SDK anyway.

Test Plan

✅ | ❌ iOS QA Tests passed locally
✅ Unit Tests passed locally

How

Breaking change
[ ] Communicate this change to the client when we release this version
[ ] Update the readme docs

Current dependencies on/for this PR:

main

PR #60   👈

This comment was auto-generated by Graphite.

Opted against using @available and gracefully deprecating the old method signatures (make the change reverse compatible), since only one client will have to make this small + trivial change on their end and we're currently making other breaking changes to the SDK anyway.

This is the right call 👍

Not sure this is something we want to do. On the one side, this would be great for GoPuff because they won't ever need to change either value. On the other side, there will likely be future Merchants who want to pass in a different merchantAccount value based on which store you shop for.
We can tell them to pass in a new Forage Config, but due to the static nature of things in iOS that wouldn't work either since we set the config once and never run that code again.

Discussed via DM and Forage X office hours; The client can call ForageSDK.setup multiple times; I'll add some tests for this as well.
ForageSDK.setup(Config(merchantID: firstMerchantID))
ForageSDK.setup(Config(merchantID: newMerchantID)) // update merchantID


Integrate test notebook cases for both ubi8/ubi9 on various flavors of the notebooks

Integrate test notebook cases for both ubi8/ubi9 on various flavors of the notebooks.
fix: https://github.com/opendatahub-io/notebooks/issues/176

Description

This implementation follows a simple top-down build logic.
For example, in the context of testing the data science notebook, it is imperative to execute both the minimal and data science test notebooks.
How Has This Been Tested?
To test this locally:

Build for example the datascience ubi8 by: make jupyter-datascience-ubi8-python-3.8
Deploy the notebook on your cluster by: make deploy8-jupyter-datascience-ubi8-python-3.8
Run the test recipe by: make test-jupyter-datascience-ubi8-python-3.8
You need to evaluate on the produced logs that the execution completed like:

....
....
Input Notebook:  test_notebook.ipynb
Output Notebook: minimal_ubi8_output.ipynb
Executing:   0%|          | 0/1 [00:00<?, ?cell/s]Executing notebook with kernel: python3
Executing: 100%|██████████| 1/1 [00:03<00:00,  3.34s/cell]
Will not apply HSTS. The HSTS database must be a regular and non-world-writable file.
ERROR: could not open HSTS store at '/opt/app-root/src/.wget-hsts'. HSTS will be disabled.
--2023-09-29 10:47:27--  https://raw.githubusercontent.com/opendatahub-io/notebooks/main/jupyter/datascience/ubi8-python-3.8/test/test_notebook.ipynb
Resolving raw.githubusercontent.com (raw.githubusercontent.com)... <IP_ADDRESS>, <IP_ADDRESS>, <IP_ADDRESS>, ...
Connecting to raw.githubusercontent.com (raw.githubusercontent.com)|<IP_ADDRESS>|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 10130 (9.9K) [text/plain]
Saving to: ‘test_notebook.ipynb’

     0K .........                                             100% 59.4M=0s

2023-09-29 10:47:28 (59.4 MB/s) - ‘test_notebook.ipynb’ saved [10130/10130]

Input Notebook:  test_notebook.ipynb
Output Notebook: datascience_ubi8_output.ipynb
Notebook JSON is invalid: Additional properties are not allowed ('id' was unexpected)

Failed validating 'additionalProperties' in code_cell:

On instance['cells'][0]:
{'cell_type': 'code',
 'execution_count': None,
 'id': '01399e50-95a4-4378-9f8d-434681d6bbf4',
 'metadata': {},
 'outputs': ['...0 outputs...'],
 'source': 'import unittest\n'
           'from unittest import mock\n'
           'from platform import p...'}
Executing:   0%|          | 0/1 [00:00<?, ?cell/s]Executing notebook with kernel: python3
Executing: 100%|██████████| 1/1 [00:07<00:00,  7.20s/cell]

Once you evaluate the results undeploy the notebook by: make undeploy8-jupyter-datascience-ubi8-python-3.8

Merge criteria:

[x] The commits are squashed in a cohesive manner and have meaningful messages.
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has manually tested the changes and verified that the changes work

/override ci/prow/images
/override ci/prow/notebooks-e2e-tests
thanks :+1:


Provider inconsistent result after apply

Describe the bug
I'm getting the error
Error: Provider produced inconsistent result after apply
When applying changes to buildkite_pipeline.pipeline, provider "provider[\"registry.terraform.io/buildkite/buildkite\"]" produced an unexpected new value: .provider_settings.skip_builds_for_existing_commits: was cty.True, but now null.

This is a bug in the provider, which should be reported in the provider's own issue tracker.

since add the following provider settings to my pipeline resource:
build_pull_requests = true
skip_builds_for_existing_commits = true
skip_pull_request_builds_for_existing_commits = true
publish_commit_status = true

Additional context
I'm running in Terraform Cloud and this is happening every run now. I was using version 1.0.6 when I first got the error but have now upgraded to 1.1.0.
Here's the state for the buildkite_pipeline resource:
{
  "mode": "managed",
  "type": "buildkite_pipeline",
  "name": "pipeline",
  "provider": "provider[\"registry.terraform.io/buildkite/buildkite\"]",
  "instances": [
    {
      "schema_version": 1,
      "attributes": {
        "allow_rebuilds": true,
        "badge_url": "https://badge.buildkite.com/e2278bebc452211e5c18b77b2dec8c155ce3b31dfdf4c910fa.svg",
        "branch_configuration": null,
        "cancel_intermediate_builds": true,
        "cancel_intermediate_builds_branch_filter": "",
        "cluster_id": null,
        "default_branch": "dev",
        "default_timeout_in_minutes": 0,
        "description": "Managed by Terraform.",
        "id": "UGlwZWxpbmUtLS0wMThiZjIzNy0zN2ExLTRmMjUtYmM2YS00YWQwMWIwODg4ZTE=",
        "maximum_timeout_in_minutes": 0,
        "name": "suru-website-build",
        "provider_settings": {
          "build_branches": true,
          "build_pull_request_forks": null,
          "build_pull_request_labels_changed": null,
          "build_pull_request_ready_for_review": null,
          "build_pull_requests": true,
          "build_tags": true,
          "cancel_deleted_branch_builds": null,
          "filter_condition": "",
          "filter_enabled": false,
          "prefix_pull_request_fork_branch_names": null,
          "publish_blocked_as_pending": null,
          "publish_commit_status": true,
          "publish_commit_status_per_step": false,
          "pull_request_branch_filter_configuration": "",
          "pull_request_branch_filter_enabled": false,
          "separate_pull_request_statuses": null,
          "skip_builds_for_existing_commits": null,
          "skip_pull_request_builds_for_existing_commits": true,
          "trigger_mode": null
        },
        "repository": "git@bitbucket.org:surupartners/suru-website.git",
        "skip_intermediate_builds": true,
        "skip_intermediate_builds_branch_filter": "",
        "slug": "suru-website-build",
        "steps": "steps:\n- label: ':pipeline: Pipeline Upload'\n  command: buildkite-agent pipeline upload",
        "tags": [],
        "webhook_url": <snip>
      },
      "sensitive_attributes": []
    }
  ]
}

Hi @cphalpin thanks for raising this. You're seeing this issue because skip_builds_for_existing_commits is not a valid provider setting for Bitbucket repositories. Only skip_pull_request_builds_for_existing_commits is valid.
If you remove the line containing that, your terraform should start working

Thank you. Is that documented anywhere? If not shall I create a PR to address it?

Good thinking @cphalpin 👍 no its not. We initially tried implementing validation but ran into trouble with the complexity of different combinations.
You could add better documnetation to https://github.com/buildkite/terraform-provider-buildkite/blob/main/buildkite/resource_pipeline.go#L531. Running make docs afterwards will update the docs as well


Request: Remove requirement for Superiority Die effect

When using Commanding Presence it adds an effect that adds + 0 to your rolls.
EDIT: Apparently this is due to not having the Superiority Die effect on the character. Is there a way that the scripts could each individually calculate the value rather than require this effect? I ask because I'm running public games with strangers and I'm importing their character from D&D Beyond and using the effects in an override compendium so your version of those effects are being imported instead. This fails to work since you need to manually copy the effect over to the character afterwards.

As for the superiority die, most of these maneuvers are NOT scripts, they use just DAE and midi.  Having a separate Superiority die is the only way I can avoid everything being a script, which is not efficient for the game would really slow down gameplay.
I use DDB Importer from Mr. Primate and am a HUGE fan of his work.  There is a setting for any item to have the importer ignore it on updates, kinda locking it in place.

I put all of my automation in the DDB Override compendium, along with automation(s) from Mr. Posney and Crymic... both of which do awesome work btw.
Thanks for the feedback... John


Remove divine trait from Bless' aura

While you are at it, the new Player Core Errata (https://paizo.com/pathfinder/faq) says: "Both the bane and bless spells should have the aura trait."


"Black flash" when open a modal without fade effect.

If I go here: https://reactstrap.github.io/components/modals/
and I try "Modals without Fade Effect" I can see a "black flash" (maybe of backdrop element) on open and on close.
It is much more evident when it opens.
Is it a feature or a bug?
I can't slow down thing to understand better, but is really bad.

I have the same question/issue. This can be reproduced on the reactstrap component page: https://reactstrap.github.io/components/modals/
under: Modals without Fade Effect
This appears to happen on Chrome and not on Firefox.
My personal opinion is this would be a better UI implementation without the "black flash".


Theme-dependent not found images

Is your feature request related to a problem? If yes, please describe it.

Currently the image-not-found image (https://github.com/intershop/intershop-pwa/blob/develop/src/assets/img/not_available.png) is hard-coded in ish-product-image:
https://github.com/intershop/intershop-pwa/blob/dca53858266cac33ff956aa52562018d66db5be1/src/app/shared/components/product/product-image/product-image.component.html#L15
This makes it hard to set the image depending on the theme with the PWA's multi-theme support.
Describe the desired solution.

Image source should be set in theme SCSS.
It should be possible to supply SVG images and have them automatically scale to their surrounding containers.
BONUS The text "NO IMAGE AVAILABLE" should be managed in a translation key and painted on top of the image when rendering, so it can be displayed in the current language.

Describe alternatives you've considered.

Provide additional context.

Additional images that are statically referenced:

It would also be possible to replace the image using pure CSS styling (a circle with a crossing line) and to add the localized text below it. So you have no image at all and there would be no problem with any theme based image reference.


Support adjusting the pool size of  readpool.unified threads dynamically

Feature Request
Describe the feature you'd like:

A dynamic config modification is performed from TiKV-Control command line (documentation). So expect to adjust the thread pool size in this way:
set config tikv `readpool.unified.core-thread-count`=7;

Technical proposal
First add scale workers support in yatp, then change config to support OnlineConfig

/type feature-request


ClickHouse parameterized view

I'd like to parse ClickHouse SQL which contains parameters for their parameterized views. The SQL looks like
CREATE VIEW view AS SELECT * FROM TABLE WHERE Column1={column1:datatype1}
Note the parameter is in the { } brackets. I get an exception. Is this easy to implement with a custom dialect, or would it need more significant changes to the parser?

It wouldn't be difficult, no.  However what I would suggest is posting it to the https://github.com/sqlparser-rs/sqlparser-rs project because this is a clone of the Rust project and keeping in step with their codebase.  I don't mind deviations, and you could certainly extend the existing ClickHouse dialect, but that would turn out the best, most comprehensive solution.

Closing - this will track with the Rust project's implementation.

FYI https://github.com/sqlparser-rs/sqlparser-rs/pull/1181


Annotation does not exist

I get the below error while trying to build React Native App in Android. Is this related to the AndroidX migration?

Task :react-native-flurry-analytics:compileDebugJavaWithJavac FAILED
/node_modules/react-native-flurry-analytics/android/src/main/java/com/xxsnakerxx/flurryanalytics/FlurryAnalyticsModule.java:3: error: package android.support.annotation does not exist
import android.support.annotation.Nullable;
^

I get this error as well.

The error is due to AndroidX upgrade.
Best way to handle would be to upgrade react-native to 0.60, use the jetifier tool to resolve the migration issues.
https://facebook.github.io/react-native/blog/2019/07/03/version-60
https://github.com/mikehardy/jetifier


Add run_in_docker.sh to allow repetitive builds

This change is

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.35%. Comparing base (a3bda1e) to head (ec040a2).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2008   +/-   ##
=======================================
  Coverage   78.35%   78.35%
=======================================
  Files          63       63
  Lines        8990     8990
  Branches     8990     8990
=======================================
  Hits         7044     7044
  Misses       1498     1498
  Partials      448      448

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Can parameterized schedular be used to trigger multiple cron job in a single pipeline?

Hi,
Thanks for the awesome plugin, it works fine for a single cron job, but i need multiple instances of it for different agent from same pipeline.
It seems like it doesn't work with multiple cron jobs each in a separate line?
Thanks in advance for the help

I thought the main fork had that solved. https://github.com/jenkinsci/parameterized-scheduler-plugin.  Did you install that one?

@jwmach1 with my cron listed below only first job is triggered. any thoughts why the second job is ignored?
Parameterized Scheduler v1.0
#ERP_Test_Service
H 1 * * * %INFOBASE=ERP_Test_Service#srv-testk-erp02#srv-testk-sql02;CHAT=-55555;CR=tcp://repo/ERP_Dev_Service

#ERP_Test
H 1 * * * %INFOBASE=ERP_Test#srv-testk-erp02#srv-testk-sql02;CHAT=-33333;CR=tcp://repo/ERP_Master


Add links in projet descriptions

Not able to add links in project descriptions

#146

Links only work in the context section. Should work in all sections.

#152


ButtonGroup: Adds list variant

Fixes #1371
Also adds list variant for Tooltip component to work well with ButtonGroup.

Additional description

CONTRIBUTOR checklist (do not remove)
Please complete for every pull request

[ ] First-time contributors should sign the Contributor License Agreement.  If you haven't before, wait a few minutes and a bot will comment on this pull request with instructions.
[ ] npm run lint:fix has been run and linting passes.
[ ] Mocha, Jest (Storyshots), and components/component-docs.json CI tests pass (npm test).
[ ] Tests have been added for new props to prevent regressions in the future. See readme.
[ ] Review the appropriate Storybook stories. Open http://localhost:9001/.
[ ] The Accessibility panel of each Storybook story has 0 violations (aXe). Open http://localhost:9001/.
[ ] Review tests are passing in the browser. Open http://localhost:8001/.
[ ] Review markup conforms to SLDS by looking at DOM snapshot strings.

REVIEWER checklist (do not remove)

[ ] TravisCI tests pass. This includes linting, Mocha, Jest, Storyshots, and components/component-docs.json tests.
[ ] Tests have been added for new props to prevent regressions in the future. See readme.
[ ] Review the appropriate Storybook stories. Open http://localhost:9001/.
[ ] The Accessibility panel of each Storybook story has 0 violations (aXe). Open http://localhost:9001/.
[ ] Review tests are passing in the browser. Open http://localhost:8001/.
[ ] Review markup conforms to SLDS by looking at DOM snapshot strings.

Required only if there are markup / UX changes

[ ] Add year-first date and commit SHA to last-slds-markup-review in package.json and push.
[ ] Request a review of the deployed Heroku app by the Salesforce UX Accessibility Team.
[ ] Add year-first review date, and commit SHA, last-accessibility-review, to package.json and push.
[ ] While the contributor's branch is checked out, run npm run local-update within locally cloned site repo to confirm the site will function correctly at the next release.

@davidlygagnon I'm in need of this variant for the page header work I've been doing so if you don't mind I can review tomorrow and merge when it's good to go?

@kevinparkerson Go for it - sounds good to me.

@pulkonet please create an example of the list variant in use. Put it in it's own file called list-variant.jsx beneath __examples__. Add it to both __docs__/site-stories.js and __docs__/storybook-stories.jsx. See the list variant on SLDS for what this example should look like. Be sure to use actual LDSR Button components for the children rather than the manual buttons seen in that example.


Proofing design documentation

Fixed typo, improved grammar and punctuation.

LGTM

Seems like all of the changes proposed here, have been taken care of by #185. So I am closing the PR


On vscode 1.77.3 the git source control not work.

VS Code Version: 1.77.3
OS Version: 10.0.19045 Windows

Steps to Reproduce:

On vscode automatic update to (1.77.3) the tab Source Control (GIT) not show my current change of repository files. In this tab only showed the message: "%view.workbench.scm.scanFolderForRepositories%"

Obs:

I use wsl.
To resolve i rollback vscode version to 1.76.2 and disable vscode automatic update.

additional information: my git repositories are on ubuntu (wsl).

I have a similar problem. The "Source Control" panel only shows the status of the repository selected in the "Source Code Repositories". Prior to 1.77.3, all repositories were present in the "Source Control" panel.

additional information: my git repositories are on ubuntu (wsl).

fedora34/wsl works fine.
ol8/wsl works fine.
alpine3.15/wsl NOT work.

rollback to 1.77.2 NOT resolved.
rollback to 1.77.1 NOT resolved.
rollback to 1.76.2 resolved.
it seems to have worked fine before 1.77.3, but not work on rollback.

@mmanyen, the "Source Control" view will show all the repositories that are selected in the "Source Control Repositories" view. Could you select all the repositories in order to view them in the "Source Control" view.

@ericksousa77, could you please share the contents of the Git output window? Thank you!

As you can see in the print, the git source control information reappeared, I was unable to reproduce the error again.
In this print I am using version 1.77.3 of vscode
@lszomoru

Since updating to VS Code 1.77.3, source control details are displayed as usual in the Source Control panel when I first open the repository, but if I select 'reopen in container' to open the folder in a Docker container the source control details are not displayed and the current branch is not respected when I run the app. Instead the message 'scanning the folder for Git repositories' is displayed in the Source Control panel and does not change.
As per ericksousa77 my Git repository is on ubuntu (wsl).
The option to view the Git output window is not available when the application is opened in a container.
If I revert to VS Code 1.76 this issue does not occur, I can see source control details in the Source Control panel both in the container and in the local filesystem.

VS Code 1.77.3
Windows x64 10.0.22621

@AliceWDCR, would it be possible to point me to a repository that I could use to try to reproduce the problem? Also, if you would share the contents of the git output window that would also be helpful. Thanks!

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!

Executing vscode with code . -n did the trick for me.


[incubator/spring-cloud-data-flow] Update to new SCDF version 1.6.0

What this PR does / why we need it:

update app version to 1.6.0
update chart version to 0.2.4
update skipper to 1.0.8

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Special notes for your reviewer:

/ok-to-test

/lgtm


How to get the transaction info

As the new version released, how can I get the transaction info from the block info,I use the RPC API "/v1/chain/get_block" and found that the maybe the transaction info is packed,then how can I get the transaction info in the block?

Resolved by #2932


find<EMAIL_ADDRESS>No such file or directory

Describe the bug
Could not install imagick extension.
Version

[ ] I have checked releases, and the bug exists in the latest patch version of v1 or v2.
[x] v2
[ ] v1

Runners

[x] GitHub Hosted
[ ] Self Hosted

Operating systems
MacOS
PHP versions
All
To Reproduce
https://github.com/phalcon/cphalcon/runs/7291219945?check_suite_focus=true#step:4:32

Fixed in https://github.com/shivammathur/homebrew-extensions/commit/07daaddd0ab4c60f908b169c58bf9a315e4b1569
Please re-run your workflow


feat(storage): add StartOffset and EndOffset to Query

I've tested it in golang-samples repo, and it works correctly.
I'm not clear with what proposed here. It's comment from issue.

Request changes to internal storage client api to add func (c *BucketsListCall) StartOffset(startOffset string) to modify the url query parameter for startOffset

All of these parameters will be sent to backend in manner:
host.com/bucket/o/?startOffest=value1;endOffest=value2

Looks like the user requests a method to change this property in URL. I suspect, it's all about changing a struct field somewhere.


Translations, Tooltips, Bug Fixes

Various translations from Figma, more styling fixes (incl. light/dark), tooltips, onboarding and thank you modals, result map redirect, additional icons, disabled download, eliminated delete function, favicon and app icons, bug fixes

@DezengKong , if the popup window is outside of the screen area, we should move its position, so that it fits in the screen:


Release please

@IgorMinar could you please cut a release now that #7 has been merged ?
Required for https://github.com/angular/angular/pull/9158 which I would like to land before next RC. Thanks.

done


In regard of COOKIE

i am new to hacking and coding but after i installed socialhack on termux they told me to ENTER COOKIE and i don't know what to do
Help me solve this isuue please

What is Cookie?

Login(Failed)

I Need Help.


text: Add and use proportionalLetterSpacing

This could be helpful for #548, but I'm sending it now so we can see if we like the logic and want to reuse it for that. It does make a small adjustment to some letter spacing, to better follow the user's device-level text size setting, so I'll post some screenshots.

Before
After

Thanks! Done.


Add UI for email-based recovery

Feature needs hookup with email provider before it's ready for master.

@Patrick1904 https://near-wallet-pr-268.onrender.com/recover-account still just shows "Phone Number" field for me.

@vgrichina thought we'd only send the email once as part of account/recovery setup? Basically the user won't be able to enter their email post account creation to receive another email?

@Patrick1904 https://near-wallet-pr-268.onrender.com/recover-account still just shows "Phone Number" field for me.

@vgrichina thought we'd only send the email once as part of account/recovery setup? Basically the user won't be able to enter their email post account creation to receive another email?

Good point, but we'll also change phone to work the same basically. So the form needs to be updated e.g. to provide instructions on how to search your recovery info.


Can't share to Facebook

I'm getting this error when trying to share to facebook
https://www.dropbox.com/s/pte1vd6m2m3050d/Screen Shot 2016-09-02 at 12.24.33.png?dl=0
Any idea?

Nobody knows?

Any suggestion?

@dijimon Maybe you run that app on Android emulator without a Facebook app?

Does Facebook share not work on Android when there is no Facebook App on the phone?
In case no, any way to make it work?

@rohitgoyal If no Facebook app, and you're able to tell, perhaps you can just open a browser intent to the appropriate Facebook URL.

@dijimon the error persists?


When the receiver is already logged in, he/she can interact normally meaning he/she can rate this picture

We decide not to implement this function because of the principle of randomness in our application. We don't want famous people to post the link on Instagram and get many likes for a specific picture.


Use Docker container labels to populate the workloadEndpoint

v1.0.0-rc2 creates a workloadEndpoint resource without labels. To use the full power of policy selectors in policies we'd like to enrich the workloadEndpoints with labels passed via the docker run ... --label foo=bar <image> construct.
I've done some prototyping already.
What does not work:

Inside a CreateEndpoint method call its impossible to get the container's label, because the NetworkInspect response does not include the container's ID yet.
Same goes for the Join method.
The container ID is available in the NetworkInfo method call, but a ContainerInspect on the container ID blocks forever. My assumption: Docker locks on the container object before doing the NetworkInfo call.

What does work (I've got a working prototype):

Start a goroutine once the workloadEndpoint has been created in CreateEndpoint
Inside the goroutine: start polling NetworkInspect until its updated with the container ID
Then attempt a ContainerInspect on the ID to get the labels.
Upon success: filter the labels for the ones starting with "org.projectcalico.<something>." and add those (without prefix) to the workloadEndpoint and do an update.
If NetworkInspect or ContainerInspect fails, try again, until success.

I've created this issue to start a spec discussion, so we all feel comfortable with this solution.
Note: once https://github.com/docker/docker/pull/27638 gets merged and released it may give us a cleaner method of populating a workloadEndpoint, but I can not wait.
/cc @lxpollitt @tomdee

Would be great to have this in.  It's sad that we have to do the polling, but I'm OK with it given Docker doesn't support this properly.
One possible suggestion: should we add a label that indicates that we haven't found the real labels yet?  This might be helpful to people.

Given that this may be a temporary solution, I feel that we should have explicit buy-in either through an environment variable or a network option.  The problem with the latter is that it would require storing and querying additional network data, so I'd personally plump for an environment.
Perhaps introduce two environments to (1) turn off profile creation   (2) turn on container labels,  or a single "mode" environment (profile, container label, netopt label).  Whilst I'd prefer a single "mode", I think that would make migration to a new mode difficult.
WDPT?

What about this:

don't create profiles if env key CALICO_DONT_CREATE_PROFILES is set
don't label the WEP if env key CALICO_DONT_LABEL_WEP is set

If CALICO_DONT_LABEL_WEP is unset, two methods of label discovery are executed in order, where set labels cant be overwritten by later methods. First 'container label' followed by 'netopt'. I suggest this order because 'netopt' is not available yet and it depends on a specific Docker version, where 'container label' works on Docker since uhmm 1.6? And order can be changed in the future.

Thanks @rtoma (and @robbrockbank ) this sounds good to me.

Hi @tomdee I've added the switch support with https://github.com/projectcalico/libnetwork-plugin/pull/103/commits/97bf63ac773267b059b23176eddf9d8d36c663ed

This was fixed in https://github.com/projectcalico/libnetwork-plugin/pull/103


path for homedirectory too long in termux

No issue with micro, just myself. Sorry for making a mess here.

Thanks for the great work. I love micro!


Better communicate Snow needs to be implemented in all pages

CTX https://github.com/LavaMoat/snow/issues/109#issuecomment-1618674481:

What would also help is if we communicate the importance of implementing Snow in all same origin pages, this should help with issues such as https://github.com/LavaMoat/snow/issues/73

CTX 2 https://github.com/LavaMoat/snow/issues/73#issuecomment-1638388215:

https://github.com/LavaMoat/snow/pull/128 fixes some problems from https://github.com/LavaMoat/snow/pull/124, bringing us closer to a solution for this problem.
Next step would be to address https://github.com/LavaMoat/snow/issues/122, so that it's clear for the users what they need to do to protect themselves fully against https://github.com/LavaMoat/snow/issues/73

Bottom line:
Past PRs make it so that exploiting #73 isn't possible if ONE of the following TWO conditions is met:

Snow is correctly implemented in ALL same origin HTML pages served by the server (including 404 and such).

#128 is designed so that calling Snow is only necessary in the top main realm, you just need to include the bundle in all pages (or call Snow in all pages too, either way is fine)

Pages correctly allow frame-src CSP only to same-origin or well trusted origins. allowing untrusted cross origin iframes allows #73 to exist when condition (1) isn't met.

Note: is that true when taking open() into consideration too? Need to research...

This ⬆ needs to be correctly communicated for #73 to be considered addressed.

#135 solves this mainly by communicating section 1 (section 2 however is less relevant actually)


Upgrade .NET version in deep-source.yml workflow

User description

Closes #
📑 Description

✅ Checks

[ ] My pull request adheres to the code style of this project
[ ] My code requires changes to the documentation
[ ] I have updated the documentation as required
[ ] All the tests have passed

☢ Does this introduce a breaking change?

[ ] Yes
[ ] No

ℹ Additional Information

Description

Upgraded the .NET version in the GitHub Actions workflow to ensure compatibility with the latest features and improvements.
This change may enhance build performance and access to new functionalities.

Changes walkthrough 📝
Relevant filesEnhancement

deep-source.ymlUpdate .NET version in deep-source.yml workflow

.github/workflows/deep-source.yml
Updated the .NET version from 7.0.x to 8.0.x.  Adjusted the setup for the .NET environment.

+1/-1

💡 Penify usage:
Comment /help on the PR to get a list of all available Penify tools and their descriptions

Summary by CodeRabbit

Chores

Updated the .NET version in the Deep Source workflow configuration from 7.0.x to 8.0.x for improved environment setup.

:white_check_mark: Build VTEX-SDK-dotnet 2.3.1066 completed (commit https://github.com/guibranco/VTEX-SDK-dotnet/commit/6237733917 by @guibranco)

:white_check_mark: Build VTEX-SDK-dotnet 2.3.1084 completed (commit https://github.com/guibranco/VTEX-SDK-dotnet/commit/4bd39f7298 by @gstraccini[bot])


Rewrite unix fork reopen to be compatible with ruby 2.6

On ruby 2.6 the original code would fail specs:
lib/childprocess/unix/fork_exec_process.rb:32:in `reopen': exclusive
access mode is not supported (ArgumentError)
The documentation for reopen shows that it has two ways to call it:
reopen(other_IO) -> ios
reopen(path, mode [,opt]) -> ios
With ruby 2.4 and 2.5 calling reopen with a path and no mode seems to
work fine, but with ruby 2.6 this triggers the spec failure.
This commit splits the calls based on stdout/stderr availability so
that both types of reopen calls can get the required parameters. This
fixes the 2.6 specs while being backward compatible with ruby 2.4 and
2.5.

Coverage remained the same at 94.688% when pulling 21973e113d4e2f6ad603184609f253af27fd1521 on graaff:ruby26-reopen into fb4d23fcd49dd8c12c39d84c6962c4d493e916f5 on enkessler:master.

Coverage remained the same at 94.688% when pulling 21973e113d4e2f6ad603184609f253af27fd1521 on graaff:ruby26-reopen into fb4d23fcd49dd8c12c39d84c6962c4d493e916f5 on enkessler:master.

Coverage remained the same at 94.688% when pulling 21973e113d4e2f6ad603184609f253af27fd1521 on graaff:ruby26-reopen into fb4d23fcd49dd8c12c39d84c6962c4d493e916f5 on enkessler:master.

Coverage remained the same at 94.688% when pulling 21973e113d4e2f6ad603184609f253af27fd1521 on graaff:ruby26-reopen into fb4d23fcd49dd8c12c39d84c6962c4d493e916f5 on enkessler:master.

Coverage remained the same at 94.688% when pulling 21973e113d4e2f6ad603184609f253af27fd1521 on graaff:ruby26-reopen into fb4d23fcd49dd8c12c39d84c6962c4d493e916f5 on enkessler:master.

Thanks for the fix, @graaff.
Can we add Ruby 2.6 to the Travis and AppVeyor CI matrices so we can confirm your fix results in a passing build?
The one failure on AppVeyor looks spurious—I've seen it before.

I wanted to do that in a separate commit but forgot to include that yet. You can verify already with ruby-head which now passes (checked on travis), but I'll update the pull request.

Amazing, thank you @graaff!

Thanks for the quick response and the merge.


Create a Favicon for Container Immersion

Create a Favicon for the site.
The favicon should be called favicon.ico and live in the project root. If you're not familiar with favicons, you can read way more than you ever wanted to know about them here: https://github.com/audreyr/favicon-cheat-sheet. I don't care too much about larger icons for mobile - just a 16x16/32x32 favicon.ico would be sufficient for now. But feel free to add additional formats if you want.
I think some kind of whale would be appropriate, but you could get creative if you want. Also, since this will be an image, make sure you don't use anything that would violate someone's copyright. Using something from an existing icon set would be fine as long as it's licensed to be used in open source projects.

Hi @mkasberg can I attempt this.  (forewarning this would be my first open source contribution :D )

Hi Sean,
Thanks for the response. How exciting to make your first contribution!
Yeah, give it a shot, and feel free to post here if you have questions along the way - I'll try to help.

Great! I will do what I can.  BTW, this project looks great and I hope to contribute to it in the future!

#24 has been submitted.

Looks great Sean! Nice work.

@Seanland Do you have a higher-res version of that icon, or would you like to create one?
I think it would probably look good on the homepage somewhere near the title :)

@mkasberg Yeah, its ~500 x ~500.  It should be able to make a decently small logo somewhere.  I will play around and see what I can come up with!

Upon closer inspection, I don't think we can use that logo. Although https://www.shareicon.net/media-logo-social-docker-878789 marks it as free for commercial use, I think they just copied it from Docker:

It's a little too similar for me to be comfortable using it since the official Docker image is trademarked.
An alternative possibility is the spouting whale from Twemoji, which is licensed under CC-BY 4.0 and is free to "remix, transform, and build upon the material for any purpose, even commercially." - we need to give attribution if we use it, probably in the form of a link at the bottom of the homepage and/or readme. We could potentially change colors, maybe change the water to a single container block, etc.
https://github.com/twitter/twemoji/blob/gh-pages/72x72/1f433.png
https://github.com/twitter/twemoji/blob/gh-pages/svg/1f433.svg

Hey @mkasberg, If you think it is a good idea to change the image I am totally fine with that.  I would rather not step on any toes even if there is a chance.
Should I modify the favicon based on this decision also?

Yes, please do. I reverted the original favicon commit from a couple of days ago, so you have a clean slate right now to try whatever you'd like.
Sorry we couldn't use your original work; thanks for giving it another shot! :+1:

@mkasberg I will gladly add the licensing requirements (I did not yet, in those two pull requests).
I was wondering if you could supply me with the proper verbiage?

Something like this would be good:
Logo based on whale emoji from Twemoji (licensed under CC-BY 4.0).
Thanks!


Compile on Centos 7.0

Centos compilation complains about using -std=c99 for CFLAGS but adding that creates others errors. So this is the safest route to go

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: dearchap sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Alternatively you could add -std=gnu99 to the compile flag. This worked for me and I had made some changes to the Makefile to detect CentOS and append it to CFLAGS as needed

Thats fine with me. When I enabled that flag it didnt compile for me thats
why I made the code changes. Let me test with your fix.
On Thu, Dec 7, 2017 at 8:43 AM, Charles Kozler<EMAIL_ADDRESS>wrote:

Alternatively you could add -std=gnu99 to the compile flag. This worked
for me and I had made some changes to the Makefile to detect CentOS and
append it to CFLAGS as needed
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/ProcDump-for-Linux/pull/5#issuecomment-349970275,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADDV5kbCtFvKj4UueOFAd-Tnl2FCxUfzks5s9-tvgaJpZM4Q4D_X
.

A couple pending PRs have added the -std=gnu99 flag, so I don't think we need to make these code changes right now.  We can revisit and triage later if that doesn't sort out your issues.


chore: remove unused pkg dependency

Closes https://github.com/prisma/prisma/pull/6729

@timsuchanek @williamluke4 just for info.

Weird, why this even here in the first place?

Note quite sure. Found this from Mar 12, 2020 https://github.com/prisma/prisma/commit/847b4473d87783de8377bc9026de5dbfa461b415
Probably something to do with the Go client who uses pkg
https://github.com/prisma/prisma-client-go


feat: add full aria support to accordions

Cleaning up the accordion block and adding a generic ARIA-based implementation for all accessibility-related interactions. See https://www.w3.org/WAI/ARIA/apg/patterns/accordion/ for spec details.
In a nutshell, this adds support for the keyboard events described in the spec, and also decorates the accordion with the proper aria roles and wraps the according toggle in a heading and button.
Fix #120
Test URLs:

Before: https://main--delta--hlxsites.hlx.page/us/en/skymiles/how-to-earn-miles/airline-partners
After: https://a11y-accordion--delta--hlxsites.hlx.page/us/en/skymiles/how-to-earn-miles/airline-partners

@ramboz Text alignment is fixed but the text is all uppercase which isn't the case in the original delta page.

@askayastha22 Indeed. Had the heading styles leaking into it. Should be fixed now.


Add tf.keras template

Added a tf.keras template to notify the users about tf.keras code moved from tensorflow/tensorflow repository to keras-team/keras repository.
Also, asking users to create new issues in keras-team/keras repository.

Sorry, by mistake i edited performance issue template. Closing this and deleting this branch. Will create new template (without editing other templates). Thanks Scott


W3C Validation Badge has a "Request Timeout"

Are you experiencing an issue with...
shields.io
🐞 Description
URL being validated or code to reproduce error :
https://img.shields.io/w3c-validation/default?targetUrl=https%3A%2F%2Fduckduckgo.com%2F
Request Timeout

console :

Failed to load resource: the server responded with a status of 408 ()

🔗 Link to the badge
https://img.shields.io/w3c-validation/default?targetUrl=https%3A%2F%2Fduckduckgo.com%2F
💡 Possible Solution
No response

This badge relies on https://validator.nu/ which is currently taking a really long time to load so we're timing out here
https://github.com/badges/shields/blob/38c1e2df168aac96c2a77b8960d074694c5a6a8b/core/server/server.js#L521-L530
I don't think there's anything we can do here - the issue is with the upstream service. Hopefully it will recover at some point

It seems that they've been experiencing issues recently: https://github.com/validator/validator/issues/1319


[FEATURE REQUEST] Back To Top Arrow Button

Description
Is your feature request related to a problem? Please describe.
I would like to create a back to top arrow button, which takes the user at the head of the page.
Describe the solution you'd like

By creating a back to top arrow button.

Describe alternatives you've considered
No Alternatives.

I would like to work on this issue please assign it to me.

go for it!

hey, @akshitagupta15june can you please assign this issue to me as I am a GSSoC'23 contributor?


New feature - pause tracking keystrokes when mouse cursor moves to a different screen

New feature - pause tracking keystrokes when the mouse cursor moves to a different screen than the keystroke history window. Added a setting to toggle on/off (Keystroke History > Pause when cursor and keystroke window are on different screens). Reset the keystroke window screen location when moving the window and also when Reset position and Reset all buttons are clicked.
Use case:

RightCtrl + F9 can be used to put the application in standby mode which will stop/pause tracking keystrokes. This option is also useful when only one monitor is used.
This pull request adds a new option which makes this more seamless on a multiple monitor setup. One main screen is normally used for screen share/recording purposes while another can be used to perform other tasks which we do not want the app to track keystrokes for (e.g. replying text messages, googling, etc.). The user can move the mouse cursor to the other screen to perform actions that they do not want the app to track without toggling the standby mode.

@Phaiax @kmpm  I've added this new PR based on my usage of multiple screens. I think some others will find this useful as well.


[Bug] Input enters twice in REPL

I was using the following code from Practical Common Lisp:
(defun make-cd (title artist rating ripped)
  (list :title title :artist artist :rating rating :ripped ripped))

(defun prompt-read (prompt)
  (format *query-io* "~a: " prompt)
  (force-output *query-io*)
  (read-line *query-io*))

(defun prompt-for-cd ()
  (make-cd
    (prompt-read "Title")
    (prompt-read "Artist")
    (or (parse-integer (prompt-read "Rating") :junk-allowed t) 0)
    (y-or-n-p "Ripped [y/n]: ")))

When I run prompt-for-cd and enter a value for title, it skips artist and goes directly to rating. When I enter a value for rating, I also see the validation for y-or-n-p say it got a bad value and ask again. From what I can gather, the REPL gets 2 enters instead of 1.

I'll look into it. Getting that stream to work correctly has been flaky. I thought I had it right, but obviously not. :-/

This should be working now. For a couple of weeks now, actually. I forgot to update this issue.


[skip ci] metadata and service check config documentation corrections

What does this PR do?
Improve (?) the documentation for the new check howto.
Motivation
I attended today's DataDog Seattle Summit, and enjoyed Daniel's Maher's workshop.  I noticed a few very small discrepancies between the docs and what the tools produces, so... here we are.
Additional Notes
No additional notes.
Review checklist (to be filled by reviewers)

[ ] PR title must be written as a CHANGELOG entry (see why)
[ ] Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
[ ] PR must have changelog/ and integration/ labels attached
[ ] Feature or bugfix must have tests
[ ] Git history must be clean
[ ] If PR adds a configuration option, it must be added to the configuration file.

I just made one small change

Thank you!


CRI: Allow configuring stdout/stderr streams

The PR https://github.com/kubernetes/kubernetes/pull/52686 added 2 new options Stdout and Stderr to specify whether to enable stdout and stderr for container streaming.
We should support it.

I looked at the change, actually the change is mainly inside streaming server which we are import and using. There is no api change.
We just need to update Kubernetes version and include the change in streaming server.

This is fixed in #322.


Type inference error when using type parameters as constraints

When compiling the following code: (the function call takes a 0-argument function and returns its result)
type NoArgsFn<T> = () => T;

function call<T, Fn extends NoArgsFn<T>>(fn: Fn): T {
  return fn();
}

let result: number = call(() => 1);

I get the following incorrect error: (on the last line)
 try.ts(7,5): error TS2322: Type '{}' is not assignable to type 'number'.
The following workaround, adding an unused dummy argument of type T to the function, avoids this error:
type NoArgsFn<T> = () => T;

function call<T, Fn extends NoArgsFn<T>>(fn: Fn, dummy: T): T {
  return fn();
}

let result: number = call(() => 1, -1);

duplicate of https://github.com/Microsoft/TypeScript/issues/7234

Hi, I believe the problem seems to be that type argument inference isn't 'smart' enough here to infer R from the function type () => R, which involves a reference to a generic parameter.
(I simplified the example a bit)
function call<R, F extends () => R>(func: F): R {
  return func();
}

let result: number = call(() => 1);

Despite the fact that the constraint doesn't error, It doesn't actually know how to infer R so it defaults to {}.
Another workaround is of course to use the signature () => R or its type alias directly as the type instead of as a constraint:
function call<R>(func: () => R): R {
  return func();
}

let result: number = call(() => 1);

But I'm not sure if that was the intention here.


Connection over HTTPS for connecting to the Chainlit Server

I have a Sample Chainlit Server App Running using chainlit run. I see that the Application is opened on the Browser using the HTTP Protocol. Is there a way where I could run the Application over the HTTPS Protocol and along with the Application, also is there a way where the WebSockets Connection could be streamed over wss instead of unencrypted ws socket channel ?
I see that in the config.toml there is a base_url parameter that allows to set the Endpoint as well as the Protocol if the Application is served behind a Reverse Proxy but I do not want to run my Chainlit Behind any Reverse Proxy for now.

If you run your server locally it will use http and ws. If you deploy it (say on render, fly.io or gcp) it will automatically use https and wss.

@willydouhard
What if i package my code into a Docker Container and deploy it on an EC2 Instance given the Fact that I can access the External IP Of the Instance over https and then access the Chainlit Server on Port 8000 ?
Would the chainlit server still automatically use https and wss ?

I'm trying a reverse proxy with nginx, that way nginx expose the service over https, and chainlit can still run in http and nginx do the magic sauce!

Why don´t you allow to configure the SSL context?
https://medium.com/@mariovanrooij/adding-https-to-fastapi-ad5e0f9e084e

workarround using nginx:
nginx.conf:
events {
    worker_connections 1024;
}

http {
    server {
        listen 443 ssl;
        server_name localhost;

	ssl_certificate /etc/nginx/cert/xxxxxxx.crt;
	ssl_certificate_key /etc/nginx/cert/xxxxxxxx.pem;
	ssl_trusted_certificate /etc/nginx/cert/xxxxxxx.ca-bundle;

	location /ws {
	        proxy_pass http://dolf:8888;
		proxy_http_version 1.1;
	        proxy_set_header Upgrade $http_upgrade;
		proxy_set_header Connection "upgrade";
	        proxy_set_header Host $host;
		proxy_set_header X-Real-IP $remote_addr;
	        proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
		proxy_set_header X-Forwarded-Proto $scheme;
	}

        location / {
		proxy_pass http://dolf:8888;
		proxy_set_header Host $host;
		proxy_set_header X-Real-IP $remote_addr;
		proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
		proxy_set_header X-Forwarded-Proto $scheme;
        }
    }
}

dolf is the name of my container running chainlit on my docker network named dolf-network. the dockers:
the nginx run command
docker run --rm --name nginx-ssl-proxy --network dolf-network -p 443:443 \
-v $(pwd)/nginx.conf:/etc/nginx/nginx.conf:ro -v /home/dario/work/dolf/server/cop_cert:/etc/nginx/cert/:ro -d nginx

the chainlit run command(this is a custom build container)
docker run  --network dolf-network  --name dolf  -p 8888:8888 -d --rm  dolf
Could be better with docker compose, but for now is sufficient for me.

workarround using nginx:
nginx.conf:
events {
    worker_connections 1024;
}

http {
    server {
        listen 443 ssl;
        server_name localhost;

	ssl_certificate /etc/nginx/cert/xxxxxxx.crt;
	ssl_certificate_key /etc/nginx/cert/xxxxxxxx.pem;
	ssl_trusted_certificate /etc/nginx/cert/xxxxxxx.ca-bundle;

	location /ws {
	        proxy_pass http://dolf:8888;
		proxy_http_version 1.1;
	        proxy_set_header Upgrade $http_upgrade;
		proxy_set_header Connection "upgrade";
	        proxy_set_header Host $host;
		proxy_set_header X-Real-IP $remote_addr;
	        proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
		proxy_set_header X-Forwarded-Proto $scheme;
	}

        location / {
		proxy_pass http://dolf:8888;
		proxy_set_header Host $host;
		proxy_set_header X-Real-IP $remote_addr;
		proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
		proxy_set_header X-Forwarded-Proto $scheme;
        }
    }
}

dolf is the name of my container running chainlit on my docker network named dolf-network. the dockers:
the nginx run command
docker run --rm --name nginx-ssl-proxy --network dolf-network -p 443:443 \
-v $(pwd)/nginx.conf:/etc/nginx/nginx.conf:ro -v /home/server/cop_cert:/etc/nginx/cert/:ro -d nginx

the chainlit run command(this is a custom build container)
docker run  --network dolf-network  --name dolf  -p 8888:8888 -d --rm  dolf
Could be better with docker compose, but for now is sufficient for me.


KAFKA-17151: Remove waitForCondition when detecting thread leak

Those tests, which are using ClusterTestExtensions, should make sure the threads created by testing get done indeed.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@FrankYang0529 please update related jiras if you try to fix them in this single PR

Hi @chia7712, thanks for your review. I address all comments and update JIRA description.

@FrankYang0529 could you please rebase code again? thanks!

@FrankYang0529 could you please rebase code again? thanks!

Rebased it. Thanks.

@FrankYang0529 this will impact many tests, so I’d like to check it on GitHub CI too. Could you please create another PR having branch “gh-“ to trigger GitHub CI?

@FrankYang0529 this will impact many tests, so I’d like to check it on GitHub CI too. Could you please create another PR having branch “gh-“ to trigger GitHub CI?

https://github.com/apache/kafka/pull/16944


Update --data-dir argument in the docs

The argument --data-dir seems to now be invalid and has been replaced by --dataset-dir
https://rubbrband.gitbook.io/cli-docs/models/lora
This page in the docs needs to be updated.
Have a nice day ;)

Hey @vdeva, thanks for catching that! We've updated the docs for lora 😄


Not working in Microsoft Edge

Due to a bug in getMatchedCSSRules in Microsoft Edge this polyfill won’t work as expected in Microsoft Edge. As this function is basically the heart of the polyfill, I have no clue how to fix this without refactoring the whole polyfill (which due to other restrictions is unwanted).
I’m very sorry about this. In case anyone has a solution, please let me know or send a Pull Request.

Wontfix for Edge?

Yes, I have no way to fix this currently as Edge does not provide any alternative and therefore the aimed solution is not usable anymore. I’m sorry about this and have been poking people at Microsoft regarding this and the native support but did not get an answer. :(


About sort order

I ran the demo, but I have some questions about the order of Cells.
I marked the order I want in the screenshot. Is there a way to do this now?

It now looks like it is arranged in a snake shape, but not exactly (for example, if it is a snake shape, the position of Item 8 should be Item 7).

This can be implemented by changing the columnIndex function to the following
private func columnIndex(for row: Int) -> Int {
    row % Int(columnCount)
}


Configuring egress IP range for Google Cloud Endpoints (GCE) with istio as add-on on GKE

Bug description
Istio is deployed as add-on on GKE and I want to open up the egress traffic so my pods can reach Google Cloud Endpoints service. However, when istio is deployed as an add-on, it is not possible to follow the guide (https://istio.io/docs/tasks/traffic-management/egress/egress-control/#direct-access-to-external-services) that shows the set the settings via the deploy config option --set global.proxy.includeIPRanges="<IP_ADDRESS>/14\,<IP_ADDRESS>/20".
When trying to update the value traffic.sidecar.istio.io/includeOutboundIPRanges in the configmap istio-sidecar-injector via kubectl edit cm istio-sidecar-injector -n istio-system, the configmap gets overwritten very shortly because of managed mechanisms. One a sandbox project I managed (after a lot of trial and error) to keep this update running for some reason so there must be a workaround in which you can update this config.
Is there any procedural workaround to update the includeOutboundIPRanges when having istio installed as add-on on GKE?
I realize that this is not really a bug but more a request to enrich documentation for the istio-add-on on how you can make that work together with Google Cloud Endpoints because as I can image this will be a frequently occurring setup.
Expected behavior
Documentation that clarifies how you can make the istio add-on on GKE work together with Google Cloud Endpoints (configure egress traffic).
Steps to reproduce the bug
Deploy istio as add-on on GKE and try to edit traffic.sidecar.istio.io/includeOutboundIPRanges via kubectl edit cm istio-sidecar-injector -n istio-system. You should notice that shortly after (within a minute) this config value gets overwritten back to * - which blocks all egress traffic.
Version (include the output of istioctl version --remote and kubectl version and helm version if you used Helm)
istioctl version --remote
client version: 1.4.0
control plane version: 0f52910f512029f0f8860b4c586cf9667545dd35
data plane version:  (1 proxies)
kubectl version
Client Version: version.Info{Major:"1", Minor:"16", GitVersion:"v1.16.3", GitCommit:"b3cbbae08ec52a7fc73d334838e18d17e8512749", GitTreeState:"clean", BuildDate:"2019-11-14T04:24:34Z", GoVersion:"go1.12.13", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"12+", GitVersion:"v1.12.10-gke.17", GitCommit:"27b48e2b4c9535d185ec945c6a513537e4d116cf", GitTreeState:"clean", BuildDate:"2019-10-21T20:10:26Z", GoVersion:"go1.12.11b4", Compiler:"gc", Platform:"linux/amd64"}
How was Istio installed?
As add-on on GKE.
Environment where bug was observed (cloud vendor, OS, etc)
Google Cloud.

After browsing around some other related issues I found out that you can annotate your deployments with the following:
spec:
  template:
    metadata:
      annotations:
        sidecar.istio.io/includeOutboundIPRanges: <IP_RANGE>

This will open up egress traffic for the specific IP range, even if the configmap istio-sidecar-injector contains the '*' value (which is the case for the istio add-on on GKE).
Is there a way I can contribute to further clarify the documentation part about Istio add-on on GKE regarding external traffic (https://cloud.google.com/istio/docs/istio-on-gke/installing#accessing_external_services)?

We do have some (somewhat hidden, granted) docs about this on istio.io here: https://istio.io/docs/reference/config/annotations/. I'll send a PR to make this more explicit.

https://github.com/istio/istio.io/pull/5896 documents this

Awesome, thanks for the swift support and making the istio.io as complete as possible :-).


Port iron-request status code tests

Left these out on the original implementation since we would need to mock out the server to spoof status codes. Also its not particularly interesting on the dart side.

related to https://github.com/dart-lang/polymer_elements/issues/16