Added NULL checks in libpd.c

Codecov Report

Merging #20 into master will decrease coverage by 0.08%.
The diff coverage is 49.05%.

@@            Coverage Diff             @@
##           master      #20      +/-   ##
==========================================
- Coverage   64.82%   64.74%   -0.09%
==========================================
  Files          16       16
  Lines        4876     4890      +14
  Branches      437      442       +5
==========================================
+ Hits         3161     3166       +5
- Misses       1518     1524       +6
- Partials      197      200       +3

Impacted Files
Coverage Δ

source/app/libpd.c
41.02% <42.22%> (-1.84%)
:arrow_down:

tests/test_libpd.c
82.6% <87.5%> (-0.32%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c03b418...82bcaaf. Read the comment docs.


chore: add package.json

Without a package.json file npm 6 can not install it and will abort the install of the dependencies.
See https://github.com/npm/npm/issues/20824#issuecomment-399795559

Thanks for contributing @DanielRuf :)


Add response_mode into Authorization url

https://docs.microsoft.com/en-us/azure/active-directory/develop/v1-protocols-oauth-code

response_mode
recommended
Specifies the method that should be used to send the resulting token back to your app. Can be query, fragment, or form_post. query provides the code as a query string parameter on your redirect URI. If you're requesting an ID token using the implicit flow, you cannot use query as specified in the OpenID spec. If you're requesting just the code, you can use query, fragment, or form_post. form_post executes a POST containing the code to your redirect URI.

I will work on this issue after #207 is merged.


Question: Why nvim-qt commands aren't showing?

Describe the bug

Neovim-qt commands aren't showing
When I'm not using lazy.nvim the nvim-qt commands are showing.
Here's my ginit.vim and lazy.lua.

Which version of Neovim are you using?
0.9.0-dev-525+ga7332ba9b
To Reproduce
Steps to reproduce the behavior:

Open nvim-qt.
Try to run nvim-qt commands.

Expected Behavior

nvim-qt commands should show up and run.

Screenshots.

You are more likely to get (faster) help, if you can provide a minimal example that reproduces the behavior.

What do you mean with nvim-qt commands?

Ah probably the rtp. Set config.performance.rtp.reset = false


Is this project Abandoned?

Hi,
The Last commit on this project is from Oct 2017.
Based on the number of issues and open Pull requests this project looks abandoned to me/
Can a maintainer confirm the case?

I've just emailed Blimp. Will update if they respond.

Any work on the status of the project?

Are there any status change? If not, we should move project. What is latest status?

I don't have a response from them.

could try django-rest-framework-simplejwt.

Yep - still no response to my email after 5 weeks. I think we can call this one dead.

@GetBlimp, @jpadilla or @jlhernandez1388 can you please let us know if the project has any future? I noticed that in the django rest framework website they suggest another library now for jwt, maybe this has to do with lack of maintenance in the last year

This project had a lot of potential!

@kylecribbs It works fine. If it stops working in the future I'm sure someone will just fork it. No one is going to spend a month rewriting their auth system rather than just spending five minutes to fix any issues that crop up with Python 3.8 or whatever.

@Alex3917 it doesn’t support Django 2.0. Django 3 is coming out next year with 1.11 becoming end of life.. So it’s pretty safe to call this dead.

https://github.com/Styria-Digital/django-rest-framework-jwt is a drop-in updated replacement fork

The maintainer is willing to transfer ownership (including new pypi project under same name, etc). Please get in touch with him or check the newest status issue to help.

Thank you all for this conversation. I've just posted an update https://github.com/jpadilla/django-rest-framework-jwt/issues/484


Leftmost part of the graph not visible sometimes

Hello,
For some of the flowcharts, the leftmost part is not visible when embedded into the docs. Can we overcome that?

Could you please give me a reproducible example?

Yes, certainly.
This is the code graph source code:
 flowchart TD
     style Start fill:#66ccff,stroke:#333,stroke-width:4px
     style End fill:#66ccff,stroke:#333,stroke-width:4px

     Start --> Initialize
     Initialize --> CatchUp
     CatchUp --> KeepUp
     KeepUp --> CatchUp
     KeepUp --> Validate
     Validate --> KeepUp
     CatchUp --> ShutdownForUpgrade
     KeepUp --> ShutdownForUpgrade
     Validate --> ShutdownForUpgrade
     CatchUp --> Upgrading
     CatchUp -->|at genesis| Validate
     Upgrading --> CatchUp
     ShutdownForUpgrade --> End

and this is the pic embededd in docs:

@mgr-inz-rafal it doesn't reproduce for me locally with cargo doc --open. Does it break for you locally?
Is that a public crate I could see docs.rs page for?

Yes, it reproduces for me locally in both Chrome and Firefox on Linux Mint.
The repo is public:
https://github.com/casper-network/casper-node
However, the docs are not yet published. The charts are merged into the dev branch.
This file contains the mentioned graph: https://github.com/casper-network/casper-node/blob/dev/node/src/reactor/main_reactor/reactor_state.rs

@mgr-inz-rafal add the following init line in your flowchart declaration:
/// flowchart TD
///     %%{init: { 'flowchart': {'diagramPadding':100} }}%%
///     style Start fill:#66ccff,stroke:#333,stroke-width:4px
///     style End fill:#66ccff,stroke:#333,stroke-width:4px
///

It would ensure you have padding at all borders, including leftmost. That should fix it.
Please let me know if that's not a one-off issue, in this case I think aquamarine should enforce larger padding on all diagram types by default.

Marking wontfix for now, will reopen if there are more occasions of this issue.

@mersinvald Adding the manual padding worked like a charm, thanks! :+1:


Configuration Cascading and Hierarchy documentation correction?

Is it just me or is the following example at http://eslint.org/docs/user-guide/configuring#configuration-cascading-and-hierarchy incorrect?

For example, consider projectA which has "root": true set in the .eslintrc file in the main project directory.  In this case, while linting main.js, the configurations within lib/will be used, but the .eslintrc file in projectA/ will not.
home
└── user
   ├── .eslintrc <- Always skipped if other configs present
   └── projectA
       ├── .eslintrc  <- Not used
       └── lib
           ├── .eslintrc  <- { "root": true }
           └── main.js

I think it should be:
For example, consider projectA which has "root": true set in the .eslintrc file in the lib/ directory.  In this case, while linting main.js, the configurations within lib/will be used, but the .eslintrc file in projectA/ will not
instead of:
For example, consider projectA which has "root": true set in the .eslintrc file in the main project directory.  In this case, while linting main.js, the configurations within lib/will be used, but the .eslintrc file in projectA/ will not

@wingy3181 you're right, good catch! Want to send a PR?
Note that because the site documentation in this repository is autogenerated, this change will need to be made in the eslint/eslint repository: https://github.com/eslint/eslint/blob/afbea78d4b94839ec6d59d2c98321901aeb76313/docs/user-guide/configuring.md#configuration-cascading-and-hierarchy.

@btmills
Raised =)
https://github.com/eslint/eslint/pull/8512
Just a stupid q..so if the docs are autogenerate from the eslint repo, how do they endup in the website repo (eslint.github.io)

@wingy3181 thanks! We'll get that landed as soon as the CLA is back up.  The process is not even remotely obvious unless you already know it happens. One of the steps in our release script is generating the site by processing the files in the docs/ directory and copying them over to the adjacent eslint.github.io checkout, then committing them to this repository. That usually happens on our Jenkins build server, so it's mostly automated as part of each release now.

seems it can be closed.

The PR didn't mention the issue, it seems. Closing since this was fixed, thanks!


How can a node (made by user-defined vue componnet) know whether it's selected?

The math formula part in the picture above is a user-defined math node (as a vue component), but when selected, it cannot change its background color just like the text parts around it.
How can such a node know if it is being selected, so it can change its style?

I noticed the self-defined vue component node accepts a selected prop, but it is always false even the math node is selected:

Is atom: true in schema? I'm not sure if its related, but NodeSelection only works if atom: true and I assume NodeSelection is called when the entire node is selected.


ver <IP_ADDRESS> ：There is something wrong with this version

ver <IP_ADDRESS> ：The quality of this version has been greatly improved, but there are still some problems
original ：

ver 1.1.8 ：

ver <IP_ADDRESS>：

I don't know why the picture is not displayed？-_-
the original url ：
original ：
http://wx3.sinaimg.cn/large/694c9b59gy1g0uig5dr59j20f20bt3zw.jpg
ver 1.1.8 ：
http://wx1.sinaimg.cn/large/694c9b59gy1g0uih13u4dj20ua0nr7wh.jpg
ver <IP_ADDRESS>：
http://wx4.sinaimg.cn/large/694c9b59gy1g0uih4xc9cj20ud0npb29.jpg

I am not one of the programmers here, but did you check the noise filter setting for <IP_ADDRESS>?

I am not one of the programmers here, but did you check the noise filter setting for <IP_ADDRESS>?

I've found the cause of the problem。
The default setting for 1.1.8  version is 2-D illust (RGB Model)
but the default setting for 1.1.8  version is 2-D illust (CUnet Model)


Conflict between Maven local repository and Gradle

Current Behavior
When a dependency is declared for a classified artifact in the build.gradle, let's say com.fasterxml.jackson.core:jackson-databind:2.17.2:sources and the non-classified artifact is present in the Maven local repository, Gradle can't resolve the classified artifact with an error:
> Could not resolve all files for configuration ':download'.
   > Could not find jackson-databind-2.17.2-sources.jar (com.fasterxml.jackson.core:jackson-databind:2.17.2).
     Searched in the following locations:
         file:/C:/Users/Admin/.m2/repository/com/fasterxml/jackson/core/jackson-databind/2.17.2/jackson-databind-2.17.2-sources.jar

This can be reproduced by manually downloading non-classifed artifact using mvn dependency:get -Dartifact=com.fasterxml.jackson.core:jackson-databind:2.17.2 and then running any gradle task which depends on the classified artifact:
configurations { download }

dependencies { download 'com.fasterxml.jackson.core:jackson-databind:2.17.2:sources' }

repositories {
  mavenLocal()
  mavenCentral()
}

task download(type: Copy) {
  from configurations.download
  into 'download'
}

If I delete the artifact from the maven local repository, the build succeeds.
Expected Behavior
Gradle should properly resolve the classified artifact even if it's not present in the Maven local repository.
Context (optional)
Initially I encountered this error when downloading sources for libraries from the IDEA. I had a project with maven build and a project with gradle build both depending on the same libraries. So the local maven repository had the library downloaded and when I tried to download sources for this library from the gradle project I've got an error. When .m2 was cleaned, the download succeeded.
Then the same issue started to appear on the TeamCity agents. Again, several different projects were built on the same agents and .m2 was populated with the non-classified artifact from the maven build but gradle build with dependency on the classified artifact failed.
Self-contained Reproducer Project
download.zip
In addition to the gradle project attached, in order to reproduce the issue one has to pollute the local maven repository.
First make sure there's no classified artifact in the local repo: mvn dependency:purge-local-repository -DmanualInclude=com.fasterxml.jackson.core:jackson-databind:2.17.2
Then get only the non-classified artifact: mvn dependency:get -Dartifact=com.fasterxml.jackson.core:jackson-databind:2.17.2.
After that run the attached project ./gradlew download and observe an error.
After purging the local repository again: mvn dependency:purge-local-repository -DmanualInclude=com.fasterxml.jackson.core:jackson-databind:2.17.2
Subsequent ./gradlew download task completes successfully.
It seems that the Maven dependency plugin works properly only in the sufficiently recent version so make sure you have the latest version of the Maven.
Gradle version
8.10.1
Build scan URL (optional)
No response
Your Environment (optional)
I experienced it first on Windows but similar problems started to appear on our Linux build agents.

Your issue appears to be a question about how to use Gradle. They should be asked in a different channel, so we will close it. Your question might be answered in Gradle documentation or on our community Slack or forums. Find links to these resources on help.gradle.org.
If you think our analysis is wrong, please provide us with more detailed information explaining why.

This is the expected behavior, and it's documented here.
The use of mavenLocal is discouraged because of that; please consider using maven with a dedicated directory or a local HTTP instance instead.


Is this a bug or a feature? Previously, this section was not black

Semi-intentional. All the call and voice related CSS was merged into one file in 85499f7003d7043d4dd0619be6de9b53fdeb52ad because it was causing conflicts.
The border radius connecting the voice and chat areas, and the region selection label do need to be fixed though.


Logs not saved on interruption

Describe the bug
Currently, logs are only saved when agent.run() completes. This applies to both saving logs as a local file using LocalLogger and as a pandas DataFrame using the default logger.
To Reproduce

Using pandas:
•	Run an agent in a notebook for a few steps.
•	Stop it.
•	Try to retrieve logs with agent.logger.return_pandas().
•	The logs will be empty.
Using LocalLogger:
•	Instantiate LocalLogger and pass it to the agent.
•	Run the agent.
•	Stop it using a keyboard interrupt.
•	The logs will be empty.

Expected behavior
To ensure we have usable logs even if the agent crashes, the logging mechanism should be modified to append logs continuously throughout the agent’s run.

I'll take care of this

@JoFrost I think you have it in mind, but just catching Keyboard interrupt should do the trick

Hey @JoFrost, have you made progress on this ? I think it's pretty important to have that so we can provide detailed logs in all of our future issues to help you pinpoint the problems.

@paulpalmieri Yep. I'll merge the PR #366 in a bit.


Add choose correct webserver to start. Change python server port to 80

On the uz/mz/pz the server is expected to start only a python server, however two webservers were launched. An apache webserver with httpd and the python webserver. Serving on ports 80 and 8000 respectively. The problem is the apache webserver on port 80 doesn't handle any webpage interaction with the system. So the set LED does not work. This would be the default webpage to go to as it's on port 80. I don't think we need to include the httpd portion and just move the python server to port 80.

I wasn't aware that httpd was running and thus conflicting with the Python webserver.  I agree it is good idea to disable httpd and move the Python webserver to port 80.


[Docs] Create your first plugin example in documentation is not working

Hello, the part Create your first plugin in the documentation is not working. It looks like there is a PluginGroup trait that need to be implemented.
Can you update the documentation in accordance to avoid troubling new user?
use bevy::prelude::{App, Commands, Component, Plugin, Query, With};
use bevy::MinimalPlugins;

#[derive(Component)]
struct Person;

#[derive(Component)]
struct Name(String);

struct HelloPlugin;

impl Plugin for HelloPlugin {
    fn build(&self, app: &mut App) {
        app.add_startup_system(add_people).add_system(greet_people);
    }
}

fn main() {
    App::new()
        .add_plugins(MinimalPlugins)
        .add_plugins(HelloPlugin)
        .run()
}

fn greet_people(query: Query<&Name, With<Person>>) {
    for name in query.iter() {
        println!("hello {}!", name.0);
    }
}

fn add_people(mut commands: Commands) {
    commands.spawn((Person, Name("Elaina Proctor".to_string())));
    commands.spawn((Person, Name("Renzo Hume".to_string())));
    commands.spawn((Person, Name("Zayna Nieves".to_string())));
}

See the following error:
bevy-basic on  main [!+?] is  v0.1.0 via  v1.69.0-nightly on   (eu-central-1)
(❌ ~ 101) ❯ cargo run --color=always --package bevy-basic --bin bevy-basic
   Compiling bevy-basic v0.1.0 (/home/mishaa/dev/bevy-basic)
error[E0277]: the trait bound `HelloPlugin: PluginGroup` is not satisfied
   --> src/main.rs:21:22
    |
21  |         .add_plugins(HelloPlugin)
    |          ----------- ^^^^^^^^^^^ the trait `PluginGroup` is not implemented for `HelloPlugin`
    |          |
    |          required by a bound introduced by this call
    |
    = help: the following other types implement trait `PluginGroup`:
              DefaultPlugins
              MinimalPlugins
              NoopPluginGroup
              PluginGroupBuilder
note: required by a bound in `App::add_plugins`
   --> /home/mishaa/.cargo/registry/src/github.com-1ecc6299db9ec823/bevy_app-0.9.1/src/app.rs:928:27
    |
928 |     pub fn add_plugins<T: PluginGroup>(&mut self, group: T) -> &mut Self {
    |                           ^^^^^^^^^^^ required by this bound in `App::add_plugins`

For more information about this error, try `rustc --explain E0277`.
error: could not compile `bevy-basic` due to previous error

Thanks! ❤

.add_plugins(HelloPlugin)

Tiny but critical typo there :)

.add_plugins(HelloPlugin)

Tiny but critical typo there :)

Oh, I'm so sorry, my bad ! :(
I'm closing, this is working.

No worries, this is a bit of a footgun.


Setting required on the X32 to enable Companion to connect

Hi,
I have the X32 Producer with V4.03 firmware with a factory reset on the settings connected with a static IP address using a wired connection to a Mac. I can control the desk and watch changes on the desk on the Mac using the X32 edit software on the Mac (via the network cable, no USB cable connected) so I am sure that I have bi-directional control available. Companion is running and I have added the X32 instance however it just stays in the "connecting" state. Do I need to enable anything on the desk to allow control from Companion?
I have a Blackmagic ATEM mixer connected to the same network which I am able to control along with the OBS instance which I am also able to control without any issue.

I am experiencing the same issue - cannot get an instance to connect to my X32 with 4.03 firmware. I didn't try with the previous 4.02 firmware. This is on both Mac and windows 10 installs of Companion.

I'm having this problem as well with the Midas M32, it doesn't seem to be get connected. I'm not sure what other info I can provide (I'll collect the firmware version when I'm next there in the next couple of days, but I think we are on the latest 4.03 or version before that).

Same issues. Same firmware (4.03) Companion just says "connecting." I didn't try it with the previous firmware.

I suspect this is a bug where it wont connect after updating the device config, but it should then work after a restart of companion. If not then I dont have any ideas as to the cause for now

I suspect this is a bug where it wont connect after updating the device config, but it should then work after a restart of companion. If not then I don't have any ideas as to the cause for now

I couldn't resolve the issue with a restart of companion and the x32. BUT, it does work with the beta of Companion (Build: companion-2.1.1-140fd7c-2661) I suspect it will be fine the next release.

Companion 2.1.1 is now released. Please give it a try and let me know how it goes

Companion 2.1.1 is now released. Please give it a try and let me know how it goes

Connected without issue and all functions working so far. X32 on 4.03, Companion 2.11 on Win10


Panic formatting v8 identifier

This will panic in dprint's code:
(function TryCatch() {
  %OptimizeFunctionOnNextCall(f);
})();

I know swc doesn't support v8 identifiers though so it thinks this is a binary expression.

I think I'm not going to fix this or ask for it in swc until TypeScript supports v8 identifiers.


my name

Adding myself

@salman-bhai many files have been changed. Should we close this?

Yes I will send a new one.


ISSUE-613: Cloning projection processors with respective configuration as part of Rule

This closes #613

+1 verified cloning topologies with Projection processor, works as expected.


corrected 'transfromer' to 'transformers'

Ⅰ. Describe what this PR does
The PR is to correct "transfromer" to "transformers" in pkg\ddc\jindo\transform.go:34:47
Ⅱ. Does this pull request fix one issue?

fixes #XXXX
Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

/lgtm


Exporting from SQL - SQL int converts to Excel "Custom" number format

Powershell Script
#requirements
#Install-Module Sqlserver
#Install-Module ImportExcel

# Notes
# NoNumberConversion: https://stackoverflow.com/a/69400119/2457222

$sqlquery = "SELECT * FROM viewItems;"

$sqlserver = "####"
$sqlusername = "####"
$sqlpassword = "####"
$sqlcredential = (New-Object System.Management.Automation.PSCredential($sqlusername,($sqlpassword | ConvertTo-SecureString -asPlainText -force)))
$sqldb = "####"

Invoke-SqlCmd -serverInstance $sqlserver -Database $sqldb -credential $sqlcredential -Query $sqlquery |select * -ExcludeProperty ItemArray, RowError, RowState, HasErrors, Table | export-excel "\Inventory.xlsx" -autosize  -NoNumberConversion BarcodeNum, substylecount

Exported File
Inventory.xlsx
The Problem
The substylecount is a column of data type int in SQL which should be presented as such, but instead you see in the attached file that it displays as a custom number format (m/d/yyy h:mm) for some strange reason.

Please, could you post a repro of the data and export. Capture or manually create a csv file, then I can better review it.

I posted the export from the Powershell export.
If you mean the export of the original data in SQL Server, here it is: inventory.csv

I posted the export from the Powershell export.
If you mean the export of the original data in SQL Server, here it is: inventory.csv

Not clear why xlsx is different.
import-csv .\inventory.csv | export-excel "Inventory.xlsx" -autosize  -NoNumberConversion BarcodeNum, substylecount


Make Chunk directory configurable

#38 added ~/.chunk as the default directory for saving progress files. There's a TODO to make it configurable:
https://github.com/cuducos/chunk/blob/02999cdd7fd49644210e074e0e2ae3473e2af2c1/progress.go#L16-L28
Maybe reading from and environment variable like CHUNK_DIR?

Maybe reading from an environment variable like CHUNK_DIR?

In addition, I suggest keeping it consistent with the other configuration params: Download.ProgressTrackerDir and a command line parameter --progress-tracker-dir. Or something like that.


Text container for column description is broken when filtering columns using schema search

Describe the bug
When using schema search in the Dataset view, column description disappears to the user.
To Reproduce

Add a column description using Markdown that's lengthy (and resembles screenshot below)
Use schema search to filter columns to just this column
Observe description section disappear (hidden scroll box)

Expected behavior
Container for dataset description is maintained / matches the user experience before schema search is applied
Screenshots

Dataset Description before using schema search

Description after using schema search

Desktop (please complete the following information):

OS: Mac OS
Browser All browsers (Brave, Chrome, Safari)
Version 0.10

Additional context
Maggie & Aditya confirmed that this is indeed a bug: https://datahubspace.slack.com/archives/CV2UXSE9L/p1678317382698979

To clarify re: the behavior being different based on scrolling to the variable vs finding it through search:
The issue was that “read more” wasn’t triggering a change in table height – so if there were only a couple variables and the height of the table was relatively small, this bug would show itself even without doing a schema search.


[RFC] Implement "related events" API.

This is a potential solution to #234.
The problem we're trying to address here is twofold. Firstly, users like mitmproxy (represented by @Kriechi and @mhils) have a desire to reproduce frames as accurately as possible when they proxy the connection. This means that it's important to them to tell the difference between the two frame sequence of frames that goes [HEADERS(END_HEADERS), PRIORITY] and the one frame one that goes [HEADERS(PRIORITY, END_HEADERS)].
Secondly, we want to begin to introduce to hyper-h2 this notion of events happening "simultaneously": that is, where multiple state transitions happen in such a way that they all occur at the same time, meaning that the user cannot reliably determine the allowed actions unless they have processed all the events that were emitted at that time. Mostly this is a pretty benign issue, but it would be nice to lazily consume events rather than emit them all at once (see #228 for more on this).
That makes this change both an attempt to address the first point cleanly and a potential precursor to the second. In essence, you can think of this change as something of a "beta" API for one of the proposed changes in #228.
In this specific change, events that can semantically occur simultaneously with each other now carry a related_events property. This property is a frozenset (immutability is good!) of all the events that occurred simultaneously.
This PR is a RFC because I'm not 100% sure I'm happy with the API as it stands. In particular, there are a few warts that I'd like feedback on.

Only some events have related_events fields. This is done primarily for clarity (to suggest that only some events can be affected by simultaneity), but it potentially means that code that works with the events gets pretty ugly, because sometimes accessing event.related_events will raise an AttributeError, based only on type(event). So we may want to add related_events to all events.
related_events contains a frozenset of all the events that occurred at once, meaning that event in event.related_events is always True. That's simple and requires the least work in the lower-level library (which is good, because this is a hot section of code), but it leads to the possibility of surprises if the event is handled incautiously (e.g. if you process event and then process event.related_events you may process event twice). So we may want to create different frozensets for each event.

Anyway, I'd like people's feedback on this. @python-hyper/contributors, can I get your input here?

Thanks for taking a swing at this! Really appreciated! 👍

related_events contains a frozenset of all the events that occurred at once

Why did you choose this behaviour? Sounds strange to me - on first thought...
Not sure why I would want to the the event again while looping through related_events
I have my API-user hat on at the moment:
If I get a RequestReceived event, I have to loop through related_events and call isinstance each time to check if I might have gotten a StreamEnded event. That's kinda annoying - unless you have a clean idea on how this API is intended to be used?
Since you already have a very nice and comprehensive definition of which events can be related with each other (in your test comments) - how about baking this directly into the events?
E.g. A RequestReceived event could have a stream_endend = True/False and priority_weight, ... attribute.
Or maybe I just have a very simplistic view for a general purpose API design? 😄

Since you already have a very nice and comprehensive definition of which events can be related with each other (in your test comments) - how about baking this directly into the events?

Yeah, so this is a thing I've been thinking about. What I'm most worried about is the question of aliasing. Specifically, if we emit DataReceived with stream_ended=True, should we then emit StreamEnded? If not, users are exposed to a subtle bug wherein they may not notice state changes. If we do, then users need to be alert for the possibility that they may receive multiple instances of redundant information.
This isn't so bad with StreamEnded, but it's potentially somewhat more problematic with PriorityUpdated, which could cause incautious users to process the same priority update twice, churning a whole chunk of state for no good reason.
One possibility is to have events have specific flags for their possible related events (e.g. a DataReceived event could have a stream_ended_event property that is optionally filled with the event that will follow DataReceived). This has all the same issues as above, but you can at least keep a temporary set around and check whether you've processed an event already.
Otherwise, I can't see a system based on "aggregating" events that isn't awkward. Frankly, the least awkward mode here might be to hang the triggering frame off any event fired by that frame. That at least gives mitmproxy what it needs to rebuild equivalent frames, though we again need to worry about the wacky internal gymnastics h2 performs with regard to HEADERS frames.

events have specific flags for their possible related events (e.g. a DataReceived event could have a stream_ended_event property that is optionally filled

Sounds good!
I'm not sure how other people are receiving data and passing it to h2, but in mitmproxy we only read one frame at a time, and process it. This makes dealing with events much simpler, because it keeps the dependencies between streams limited.

How are you ensuring you read only one frame?

We are parsing the frame header and then read the exact length of the frame from the socket.
https://github.com/mitmproxy/mitmproxy/blob/c801f81373d5935f60bf950b1f266911a94ecf60/netlib/http/http2/framereader.py#L6

Ok, that makes sense. I think that's a relatively unusual approach: most implementations will just feed bytes directly into the state machine without checking where frame boundaries are. Similarly, however, most implementations don't really care about simultaneity except as it might cause unexpected ProtocolErrors to show up.
So I remain a bit unsure about how best to move this forward, but we can also prototype the interface based on set properties and see how the implementation there looks.

Alright, we decided to go with #240 instead.


[WIP] converted msdn links to site-relative for offline scenarios

This PR fixes up msdn shortid urls that were missed in earlier runs

Thanks so much for working on this @mikeblome. We'll review it as soon as possible!

Related to #2037


Add/modify sequenceA hints

When a rule LHS contains sequence or sequence_, add the corresponding sequenceA or sequenceA_ version
~When a rule RHS contains sequence or sequence_, suggest sequenceA or sequenceA_ instead~
Removed a duplicate hint.

Thanks!


fix MM_PORT variable not used in electron

related to #3302

when I do this

i added a config.log() after resolving path to config file in app.js
it completes with correct name
and loads correct module node helpers, but gives the error screen to browsers... (on the specificed port in MM_PORT)
[25.12.2023 14:51.53.887] [LOG]   Starting MagicMirror: v2.25.0
[25.12.2023 14:51.53.889] [LOG]   Loading config ...
[25.12.2023 14:51.53.890] [LOG]   global config file=/home/sam/MagicMirror/config/config2.js
[25.12.2023 14:51.53.891] [DEBUG] config template file not exists, no envsubst
[25.12.2023 14:51.53.893] [LOG]   Loading module helpers ...
[25.12.2023 14:51.53.896] [LOG]   No helper found for module: alert.
[25.12.2023 14:51.54.108] [LOG]   Initializing new module helper ...
[25.12.2023 14:51.54.109] [LOG]   Module helper loaded: MMM-ImagesPhotos
[25.12.2023 14:51.54.109] [LOG]   No helper found for module: clock.
[25.12.2023 14:51.54.177] [LOG]   Initializing new module helper ...
[25.12.2023 14:51.54.178] [LOG]   Module helper loaded: calendar
[25.12.2023 14:51.54.336] [LOG]   Initializing new module helper ...
[25.12.2023 14:51.54.336] [LOG]   Module helper loaded: MMM-Config
[25.12.2023 14:51.54.336] [LOG]   No helper found for module: compliments.
[25.12.2023 14:51.54.378] [LOG]   Initializing new module helper ...
[25.12.2023 14:51.54.378] [LOG]   Module helper loaded: newsfeed
[25.12.2023 14:51.54.378] [LOG]   All module helpers loaded.
[25.12.2023 14:51.54.382] [LOG]   Starting server on port 8091 ...
[25.12.2023 14:51.54.384] [WARN]  You're using a full whitelist configuration to allow for all IPs
[25.12.2023 14:51.54.390] [LOG]   Server started ...
[25.12.2023 14:51.54.390] [LOG]   Connecting socket for: MMM-ImagesPhotos
[25.12.2023 14:51.54.390] [LOG]   Starting node helper for: MMM-ImagesPhotos
[25.12.2023 14:51.54.390] [LOG]   Connecting socket for: calendar
[25.12.2023 14:51.54.390] [LOG]   Starting node helper for: calendar
[25.12.2023 14:51.54.391] [LOG]   Connecting socket for: MMM-Config
[25.12.2023 14:51.54.391] [LOG]   Starting module helper: MMM-Config
[25.12.2023 14:51.54.391] [LOG]   Connecting socket for: newsfeed
[25.12.2023 14:51.54.391] [LOG]   Starting node helper for: newsfeed
[25.12.2023 14:51.54.391] [LOG]   Sockets connected & modules started ...
[25.12.2023 14:51.54.581] [LOG]   Launching application.

can not reproduce your errors, with this fix the port variable is working with electron and also in browser.
I used the sample config.js and only changed address: "<IP_ADDRESS>", and ipWhitelist: [],

so, can we merge it or not? dont want to decide since I dont have time for testing myself

will update this later with another fix

I added another fix which I think was the main problem because using a full path for MM_CONFIG_FILE did not work.
So @sdetweil @rejas feel free to test again, from my side this can me merged.

would like to see a test&approval by @sdetweil since I dont have much time these days

the doc needs to have a statement that the targeted config file must reference a filename in the MagicMirror folder tree (that filename could be linked to a physical file anywhere in the filesystem, on linux systems see the ln command)

will take a look at the docs after this is merged

Spotted and modified doc re-write to match Sam's note.


modified the search function

Users can directly enter the name/email/ phone number (without any switch case).
close #24

Great work!

!bounty 95

!bounty 70

!bounty 60 (Extra 10 Brownie points for elegant code)


Does OpenFAST allow negative fine pitch angle?

Hi,
I'm trying to run a Ramp simulation with negative fine pitch angle (-0.017453300000      ! PC_FinePit) but, the pitch angle doesn't seem to go below zero. I have set minimum physical pitch (PC_MinPit) allowed to -0.34906000000 rad but it doesnt seem to help. Does OpenFAST allow negative fine pitch angle?

Hi, this is probably more of a ROSCO issue.  You may also need to set PS_Mode to 0.

Seting PS_Mode to 0 works. Thanks


EXPIRE not working?

resp_array!["EXPIRE", my_key, 90]  is failing
Error:
Error("ERR Protocol error: expected '$', got ':'")
UPDATE:  the seconds must be expressed as a String or &str.  :-1:

At present redis-async doesn't enforce the structure of Redis commands.  I have considered doing that, but at the moment it doesn't because otherwise every new Redis release would be incompatible until redis-async catches up and adds new commands/options/etc.  This is why resp_array! exists as a macro, to make it easy to construct a Redis command, but it does mean it's up to the calling application to ensure the command is formatted correctly for the version of Redis used.
In this specific case of EXPIRE, I think it's because Redis is expecting the timeout option to be presented as a String.  So resp_array!["EXPIRE", my_key, "90"] ought to do the job.
I should add this as documentation on PairedConnect::send (and similar functions elsewhere).


Improve speed of E2E-test runs

Fail as early as possible with the 'lightest' tests (linting)
Add some caching-steps to reuse effort of previous test-runs

Checklist before requesting a review

[x] I have performed a self-review of my code
[x] I have added tests wherever relevant
[x] I have made sure that all automated checks pass before requesting a review
[x] I do not need any deviation from our PR guidelines

LGTM? :)


Update Netlify configuration file to set basic auth header for all branches except master

Now that we have a Netlify Open Source plan, we can access their custom HTTP headers and password protection features.
To improve our SEO, I would like all branches except for master to have a basic authentication HTTP header. For example, setting a password using Basic-Auth: login:password.
According to a post published in Netlify's blog, we can set up basic authentication at the build step. However, I am concerned about changing our build process given the open-source nature of the Platform.
Instead, I think we can set basic authentication using context-specific custom headers.
@LucaFumis, can you please try and implement a custom header for the following contexts?
[context.deploy-preview.environment]
[context.branch-deploy]
[context.qa.environment]
For the purposes of testing, the header can read:
Basic-Auth = "opentargets:opentargets"

I tried few options with no luck - will try again once the release is live.

Removing from 20.04 release and from Baby Mann milestone. Instead, this has been assigned to the 20.06 release and will be assigned to a sprint once that release has been planned as noted in #994.

@andrewhercules , I guess you cannot set headers per context.

@robsonsobral, unfortunately I don't know how to do this in Netlify. Prior to the introduction of the next-gen Platform in April 2021, the Open Targets team used Netlify's site password protection feature instead of setting basic auth headers.

@andrewhercules , I didn't even know what OpenTargets is. I was researching to fix a similar bug.
I see that your old build scripts had the command cp netlify_headers app/_headers. It is enough to make it work, but not on the free plan.


ivvi.linspace

A replacement of numpy.linspace for use with the ivvi rack dacs.
The voltage output is not the same as the set voltage using
ivvi.set_dac1(v) due to 16 bit quantitation of the DAC.
If you only record the requested value, and not the value
from ivvi.get_dac1() the values will be slightly wrong.
This can lead to:

accidental oversampling (having the same voltage twice,
thinking you have different voltages)
uneven spacing (changing by 2 bits, then 3, then 2 etc...)

This is solved by correctly rounding and picking the correct
start and end values with a fixed spacing with knowledge of
the quantitation.
ivvi.linsweep gives:

even spacing in voltages
recorded voltages match the set voltages
protection from oversampling

@GeneralSarsby this PR has been stalled for some time. Are you planning to finish it? will you need help with that? (if so, let me know)

I don't know what the requirements for the travis tests to pass.
What is it about  the docstring that causes the build to fail?

@astafan8
I'm only guessing at what is needed for the build to pass, trying to throw stuff against the wall and see what works.  It's something about the docstring.
The  #QCoDeS CI failed  page says passed, but gives a failed status.
The Travis CI build failed because of Sphinx complaining about indents on line 22. But I can't see the error.

@GeneralSarsby i'll have a look at it...


add-e2e-tests

use latest e2e template
/run cluster-test-suites

/run cluster-test-suites

upgrade test failed, but that's expected as there has not been a change in the apps


Use icinga2 user/group for logrotate file

The cookbook creates a 'nagios' user/group on debian platforms, but the
logrotate template had hardcoded an 'icinga' user/group. On debian
platforms, that means the logrotate job fails. The fix here is to use
the attributes that define the user/group created by the cookbook.

Looks good - thanks!


Can't resolve 'react'

Hello, I installed last version (1.2.4) and got this problem:

My fault, sorry :crossed_fingers:


WIP: Refactor to make linting more strict

Hey 👋
Based on the discussion here: https://github.com/themesberg/flowbite-vue/discussions/200
This is my proposal for updating linting rules... (details in comments below).
This is Draft PR as if changes are accepted it'll be required to actually implement new rules... this can be done as part of this commit (but it would make it very big) or as separated piece of work after this one is accepted.
When updating linting dependencies I've also updated existing ones as well.
Pleas let me know if this set of rules is acceptable... If yes I'll prepare next one to implement necessary changes to align with those rules.

@cogor
I've updated this PR with changes to Paragraph and Heading components... it covers components as well as docs for them. Let me know if that is ok... and I'll work on the rest of the components.
Also... this PR will affect most of the files... so if you have some work in progress let's figure out how to best avoid conflicts ;)

That is ok, but need to fix an error in docs  :)

good catch, thanks
cool... I'll continue with other components

Hey... this is still WIP... I have few more components to go through... ;)

I know, I merged it into fwb-rename branch, I'll help you out and we'll make faster

Hey @cogor ... I've finished all and it's on the same branch
I've also created PR here


Change domain to new custom domain

With linking to certificate
Description of change
Custom Domain Names - Caseworker Dev
Note: this is just for dev as I want to test one before I do the others

you have this PR too that you could use?
https://github.com/ministryofjustice/laa-assess-crime-forms/pull/333


#210 - update documentation

Description

This corresponds to the changes made for issue #210
Motivation and Context

Checklist

[x] This change complies with the contributing guidelines.
[ ] I have provided automated tests to verify that these changes are correct.

re creating with the correct branch name


Better error messages for feeds

Right now I've got a lot of failing feeds and I don't know why.

As the error reporting is pretty sparse (Error parsing) it's hard to figure out what went wrong (on my side or a broken feed). Looking through each feed is burdensome.
If the error would be logged correctly it would be much easier (it does not really need to be shown in the web interface, if it can be found in heroku logs I'm fine with it)

Closing due to lack of interest. Interested parties may re-open if you want to continue the discussion of implementation.


Distinguishing CRAWLERA_DOWNLOAD_TIMEOUT and X-Crawlera-Timeout

Currently we have:

CRAWLERA_DOWNLOAD_TIMEOUT to specify the download timeout between a client and Crawlera nodes.
X-Crawlera-Timeout to specify the download timeout between Crawlera nodes and the target websites (not yet supported by this package).

Looks like they are somehow misleading and confusing. As we may not easily change the names, shall we:

Add some kind of notes to explain the difference.
Also support X-Crawlera-Timeout in this package.

but X-Crawlera-Timeout isn't used as a settings parameter, but only a request header, I don't see how could they be mixed up.
Also CRAWLERA_DOWNLOAD_TIMEOUT isn't really a necessary or important setting, as the scrapy-crawlera middleware handles a default download_timeout for crawlera requests, and offers CRAWLERA_DOWNLOAD_TIMEOUT if you want to change that default, which is already being handled by the more generic DOWNLOAD_TIMEOUT settings attribute.

@redapple any comments here?


UWP app can't see crashes and always show "Coming soon"

What App Center service does this affect?
Diagnostics
Describe the bug
UWP original use hockeyapp and then auto-sync into AppCneter. But can't see  any crashes information in Diagnostics function.
To Reproduce
N/A
Expected behavior
Can view all crashes and the same as those in Hockeyapp
Screenshots
N/A
Desktop (please complete the following information):

OS: Windows 10
Browser FireFox
Version 65.0.1

Smartphone (please complete the following information):
N/A
Additional context
N/A

Hi @FatJohn! This sounds like something our support team can help troubleshoot with you over Intercom in our main portal. Mind opening up a request there so someone from our team can converse directly with you about your issue?

@patniko OK~ Does Main Portal mean App Center Main Portal ?

It does. Someone should be able to look into your account specifically to see whats going on. Going to close this for now, but feel free to reopen it if you have any troubles reaching out to our support team.


learn backend base knowledge

Basic Model 3 people Kevin
Create preliminary model / table plus sql  for user, history and fishes
Write basic api for get and post
Fish - fish related  History - this is mostly water only
Docker
Create Dockerfile and .sh script to run docker and set up everything
Post images on github for future front end users

Finished,
Have closen the Heroku server for this project.
Turn to Docker, (but every teamate generates their own data).


DMatrix fails on Pandas' nullable floats

XGBoost 1.6.1
Pandas: 1.4.1
Final training data information:
<class 'pandas.core.frame.DataFrame'>
RangeIndex: 10000 entries, 0 to 9999
Data columns (total 9 columns):
 #   Column                  Non-Null Count  Dtype
---  ------                  --------------  -----
 0   class                   10000 non-null  Int64
 1   trip_seconds            9996 non-null   Int64
 2   trip_miles              10000 non-null  Float64
 3   pickup_community_area   9418 non-null   Int64
 4   dropoff_community_area  9267 non-null   Int64
 5   fare                    10000 non-null  Float64
 6   tolls                   8920 non-null   Int64
 7   extras                  10000 non-null  Float64
 8   company                 10000 non-null  category
dtypes: Float64(3), Int64(5), category(1)
memory usage: 714.4 KB
Traceback (most recent call last):
  File "/tmp/tmp.ap5suk4c6n", line 116, in <module>
    _outputs = xgboost_train(**_parsed_args)
  File "/tmp/tmp.ap5suk4c6n", line 67, in xgboost_train
    training_data = xgboost.DMatrix(
  File "/usr/local/lib/python3.10/site-packages/xgboost/core.py", line 532, in inner_f
    return f(**kwargs)
  File "/usr/local/lib/python3.10/site-packages/xgboost/core.py", line 643, in __init__
    handle, feature_names, feature_types = dispatch_data_backend(
  File "/usr/local/lib/python3.10/site-packages/xgboost/data.py", line 896, in dispatch_data_backend
    return _from_pandas_df(data, enable_categorical, missing, threads,
  File "/usr/local/lib/python3.10/site-packages/xgboost/data.py", line 345, in _from_pandas_df
    data, feature_names, feature_types = _transform_pandas_df(
  File "/usr/local/lib/python3.10/site-packages/xgboost/data.py", line 283, in _transform_pandas_df
    _invalid_dataframe_dtype(data)
  File "/usr/local/lib/python3.10/site-packages/xgboost/data.py", line 247, in _invalid_dataframe_dtype
    raise ValueError(msg)
ValueError: DataFrame.dtypes for data must be int, float, bool or category.  When
categorical type is supplied, DMatrix parameter `enable_categorical` must
be set to `True`. Invalid columns:trip_miles, fare, extras, company

https://github.com/dmlc/xgboost/pull/7760 only added support for nullable integers and booleans, but not floats.
P.S. Also the _invalid_dataframe_dtype incorrectly includes categorical columns despite enable_categorical set to True.

Thank you for raising the issue! Would you like to open a PR for the fix?


xmltv format flexibility

Is your feature request related to a problem? Please describe.
One main source of xmltv for Australia is http://www.xmltv.net/ however the format of these files produce an error in xteve.
xml: encoding "ISO-8859-1" declared but Decoder.CharsetReader is nil () - EC: 0
Describe the solution you'd like
Ideally xteve would be able to support these files.

xTeVe uses UTF-8. Ask the Provider of this Guide info to support UTF-8, not the other way around. They should not limit you to one format TBH.

I have the same issue with http://xmltvfree.free.fr/ which is a free service. Would it be possible to either detect the charset or to include an input or dropdown list for the user to select the format himself?

This probably won't help, but I asked my provider to add UTF-8 and they
were able to. That was a free provider.
On Mon, 15 Feb 2021 at 22:08, Frederic R<EMAIL_ADDRESS>wrote:

I have the same issue with http://xmltvfree.free.fr/ which is a free
service. Would it be possible to either detect the charset or to include an
input or dropdown list for the user to select the format himself?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/xteve-project/xTeVe/issues/115#issuecomment-779075121,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABBHHMWR5BRMG5TC4GY673TS7DQCJANCNFSM4MGIRODQ
.

I asked as well => https://gitlab.com/snouf/tvheadend_tools/-/issues/4
I also found another provider for this xmltv file. It's not as ideal as this one but I could get pass this issue for now and continue the setup of xteve & plex


Segmentation fault on WSL2

I followed the instructions on this page (Enable PyTorch with DirectML on WSL 2) and got a segmentation fault.
$  python
Python 3.10.8 (main, Nov 24 2022, 14:13:03) [GCC 11.2.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import torch
>>> import torch_directml
>>> dml = torch_directml.device()
>>> dml
device(type='privateuseone', index=0)
>>> tensor1 = torch.tensor([1]).to(dml)
Segmentation fault

Device details:
Suface Laptop 4
Windows 11 Enterprise (version: 10.0.22621 Build 226221)
CPU: 11th Gen Intel(R) Core(TM) i7-1185G7 @ 3.00GHz   3.00 GHz
Memory: 32.0 GB (31.8 GB usable)
Graphics: Intel Iris Xe Graphics (driver version <IP_ADDRESS>68)
WSL details:
> wsl --version
WSL version: <IP_ADDRESS>
Kernel version: <IP_ADDRESS>
WSLg version: 1.0.47
MSRDC version: 1.2.3575
Direct3D version: 1.606.4
DXCore version: 10.0.25131.1002-220531-1700.rs-onecore-base2-hyp
Windows version: 10.0.22621.963

Python environment details:
Python 3.10
torch==1.13.1
torch-directml==0.1.13.dev221216
pip list:
Package                  Version
------------------------ ----------------
absl-py                  1.3.0
aiohttp                  3.8.3
aiosignal                1.2.0
async-timeout            4.0.2
attrs                    22.1.0
blinker                  1.4
Bottleneck               1.3.5
brotlipy                 0.7.0
cachetools               4.2.2
certifi                  2022.12.7
cffi                     1.15.1
charset-normalizer       2.0.4
click                    8.0.4
contourpy                1.0.5
cryptography             38.0.1
cycler                   0.11.0
flit_core                3.6.0
fonttools                4.25.0
frozenlist               1.3.3
google-auth              2.6.0
google-auth-oauthlib     0.4.4
grpcio                   1.42.0
idna                     3.4
kiwisolver               1.4.4
Markdown                 3.4.1
MarkupSafe               2.1.1
matplotlib               3.6.2
mkl-fft                  1.3.1
mkl-random               1.2.2
mkl-service              2.4.0
multidict                6.0.2
munkres                  1.1.4
numexpr                  2.8.4
numpy                    1.23.5
nvidia-cublas-cu11       <IP_ADDRESS>
nvidia-cuda-nvrtc-cu11   11.7.99
nvidia-cuda-runtime-cu11 11.7.99
nvidia-cudnn-cu11        <IP_ADDRESS>
oauthlib                 3.2.1
opencv-python            <IP_ADDRESS>
packaging                22.0
pandas                   1.5.2
Pillow                   9.3.0
pip                      22.3.1
ply                      3.11
protobuf                 3.20.1
pyasn1                   0.4.8
pyasn1-modules           0.2.8
pycparser                2.21
PyJWT                    2.4.0
pyOpenSSL                22.0.0
pyparsing                3.0.9
PyQt5-sip                12.11.0
PySocks                  1.7.1
python-dateutil          2.8.2
pytz                     2022.7
PyYAML                   6.0
requests                 2.28.1
requests-oauthlib        1.3.0
rsa                      4.7.2
setuptools               65.5.0
sip                      6.6.2
six                      1.16.0
tensorboard              2.10.0
tensorboard-data-server  0.6.1
tensorboard-plugin-wit   1.8.1
toml                     0.10.2
torch                    1.13.1
torch-directml           0.1.13.dev221216
torchvision              0.14.1
tornado                  6.2
tqdm                     4.64.1
typing_extensions        4.4.0
urllib3                  1.26.13
Werkzeug                 2.2.2
wget                     3.2
wheel                    0.37.1
yarl                     1.8.1

While, I do not have this problem:
Python 3.10.8 (main, Nov 24 2022, 14:13:03) [GCC 11.2.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import torch
>>> import torch_directml
>>> dml = torch_directml.device()
>>> tensor1 = torch.tensor([1]).to(dml)
>>> print(tensor1)
tensor([1], device='privateuseone:0')

My GPU is Nvdia's.
Maybe you can try to upgrade torch-directml to version <IP_ADDRESS>.dev230119 and upgrade your GPU driver.

I noticed you have installed the nvidia-XXX, maybe you can try "pip install torchvision" or "conda install torchvision -c pytorch" after "conda install pytorch cpuonly -c pytorch".

Hi @ryotatomioka, Thanks for reporting this. Can you provide us your driver version?

Hi @ryotatomioka, Thanks for reporting this. Can you provide us your driver version?

What do you mean, "driver version"? Do you intend to the graphic cards' driver version?
My GPU is AMD RX 6700xt
Driver's version is 22.5.1
versions:

The driver's version: <IP_ADDRESS>-220428a-382767C-AMD-Software-Adrenalin-Edition
AMD Windows driver version: 30.0.15021.11005
D3D driver version: <IP_ADDRESS>20

Hi @Looong01, Thanks for clarifying my question, And yes, I was asking about the GPU driver version.
I missed the info(Graphics: Intel Iris Xe Graphics (driver version <IP_ADDRESS>68)) in the original post.
Please try updating the GPU driver version. And it's most likely we don't support this GPU because pytorch-directml leverages [DirectML] which has the requirements for Intel GPUs
You can verify that by running:
import torch
import torch_directml
torch_directml.is_available()
torch_directml.device_count()

torch_directml.is_available() returns False or torch_directml.device_count() returns 0 would mean that either the GPU or GPU driver is not supported.

Finding the same error here with a Radeon RX 6700XT.
$ neofetch
            .-/+oossssoo+/-.               xxxx@xxxxxxxx
        `:+ssssssssssssssssss+:`           ---------------
      -+ssssssssssssssssssyyssss+-         OS: Ubuntu 22.04.1 LTS on Windows 10 x86_64
    .ossssssssssssssssssdMMMNysssso.       Kernel: <IP_ADDRESS>-microsoft-standard-WSL2
   /ssssssssssshdmmNNmmyNMMMMhssssss/      Uptime: 1 hour, 37 mins
  +ssssssssshmydMMMMMMMNddddyssssssss+     Packages: 1250 (dpkg)
 /sssssssshNMMMyhhyyyyhmNMMMNhssssssss/    Shell: bash 5.1.16
.ssssssssdMMMNhsssssssssshNMMMdssssssss.   Theme: Adwaita [GTK3]
+sssshhhyNMMNyssssssssssssyNMMMysssssss+   Icons: Adwaita [GTK3]
ossyNMMMNyMMhsssssssssssssshmmmhssssssso   Terminal: Windows Terminal
ossyNMMMNyMMhsssssssssssssshmmmhssssssso   CPU: 12th Gen Intel i9-12900K (24) @ 3.187GHz
+sssshhhyNMMNyssssssssssssyNMMMysssssss+   GPU: ea92:00:00.0 Microsoft Corporation Device 008e
.ssssssssdMMMNhsssssssssshNMMMdssssssss.   Memory: 2751MiB / 15887MiB
 /sssssssshNMMMyhhyyyyhdNMMMNhssssssss/
  +sssssssssdmydMMMMMMMMddddyssssssss+
   /ssssssssssshdmNNNNmyNMMMMhssssss/
    .ossssssssssssssssssdMMMNysssso.
      -+sssssssssssssssssyyyssss+-
        `:+ssssssssssssssssss+:`
            .-/+oossssoo+/-.

❯ wsl --version
WSL version: <IP_ADDRESS>
Kernel version: <IP_ADDRESS>
WSLg version: 1.0.51
MSRDC version: 1.2.3770
Direct3D version: 1.608.2-61064218
DXCore version: 10.0.25131.1002-220531-1700.rs-onecore-base2-hyp
Windows version: 10.0.22621.1702

$ python
Python 3.10.6 (main, Nov  2 2022, 18:53:38) [GCC 11.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import torch
>>> import torch_directml
>>> torch_directml.is_available()
True
>>> torch_directml.device_count()
2

$ pip freeze
certifi==2022.12.7
charset-normalizer==2.1.1
filelock==3.9.0
idna==3.4
Jinja2==3.1.2
MarkupSafe==2.1.2
mpmath==1.2.1
networkx==3.0
numpy==1.24.1
Pillow==9.3.0
requests==2.28.1
sympy==1.11.1
torch==2.0.0+cpu
torch-directml==0.2.0.dev230426
torchaudio==2.0.0+cpu
torchvision==0.15.1
typing_extensions==4.4.0
urllib3==1.26.13

$ python
Python 3.10.6 (main, Nov  2 2022, 18:53:38) [GCC 11.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import torch
>>> import torch_directml
>>> dml = torch_directml.device()
>>> tensor1 = torch.tensor([1]).to(dml)
Segmentation fault

I also can't get an example to work
# I have already installed the requirements.txt file and ran dataset.py
$ python PyTorch/1.8/resnet50/train.py
/home/xxxx/venv/lib/python3.10/site-packages/torchvision/io/image.py:13: UserWarning: Failed to load image Python extension: 'libc10_cuda.so: cannot open shared object file: No such file or directory'If you don't plan on using image functionality from `torchvision.io`, you can ignore this warning. Otherwise, there might be something wrong with your environment. Did you have `libjpeg` or `libpng` installed before building `torchvision` from source?
  warn(
Traceback (most recent call last):
  File "/home/xxxx/DirectML/PyTorch/1.8/resnet50/train.py", line 35, in <module>
    main()
  File "/home/xxxx/DirectML/PyTorch/1.8/resnet50/train.py", line 30, in main
    train(args.path, args.batch_size, args.epochs, args.learning_rate,
  File "/home/xxxx/DirectML/PyTorch/1.8/classification/train_classification.py", line 111, in main
    model = get_model(model_str, device)
  File "/home/xxxx/DirectML/PyTorch/1.8/classification/test_classification.py", line 76, in get_model
    model = models.resnet50(num_classes=10).to(device)
  File "/home/xxxx/venv/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1126, in to
    device, dtype, non_blocking, convert_to_format = torch._C._nn._parse_to(*args, **kwargs)
RuntimeError: Expected one of cpu, cuda, ipu, xpu, mkldnn, opengl, opencl, ideep, hip, ve, fpga, ort, xla, lazy, vulkan, mps, meta, hpu, mtia, privateuseone device type at start of device string: dml

Is there a stable, recommended version of torch-directml, and where if any is that in a requirments.txt file?


Revert "[CheckpointExecutor] Clear pending queue more aggressively

I can pick this into 0.33.

Thank you!


feat: mac credential storage

PR Checklist
Please check if your PR fulfills the following requirements:

[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-examples/blob/master/.github/CONTRIBUTING.md.
What is the current behavior?

Issue Number:
What is the new behavior?
Does this PR introduce a breaking change?

[ ] Yes
[ ] No

New Imports
Are there any new imports or modules? If so, what are they used for and why?
Specific Instructions
Are there any specific instructions or things that should be known prior to reviewing?
Other information

Codecov Report

Merging #90 (24e6651) into main (f7fd1a7) will decrease coverage by 0.13%.
The diff coverage is 2.80%.

@@           Coverage Diff            @@
##            main     #90      +/-   ##
========================================
- Coverage   5.54%   5.41%   -0.14%
========================================
  Files         15      17       +2
  Lines       1533    1663     +130
========================================
+ Hits          85      90       +5
- Misses      1439    1564     +125
  Partials       9       9

Impacted Files
Coverage Δ

internal/driver/checkstatuses.go
0.00% <0.00%> (ø)

internal/driver/config.go
17.64% <ø> (ø)

internal/driver/credentials.go
0.00% <0.00%> (ø)

internal/driver/driver.go
1.27% <0.00%> (-0.07%)
:arrow_down:

internal/driver/onvifclient.go
0.00% <0.00%> (ø)

internal/driver/onvifdiscovery.go
0.00% <0.00%> (ø)

internal/driver/macmapper.go
10.41% <10.41%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7fd1a7...24e6651. Read the comment docs.


error handling implementation

This PR implements my vision for the error handling of a graphql response (when possible), inspired by apollo client.
Background
Basically an operation can fail for 3 possible reasons:

network: when the server returns a "non OK" http code
graphql: when the request is bad formatted for instance, 200 is returned and the error is described in the response
everything else: http code 200 but server returned data with a bad format, failed to perform the request, and so on

Implementation
Network and graphql errors can be handled in a struct like the following, they both implements the go error interface
import "github.com/vektah/gqlparser/v2/gqlerror"

type HTTPError struct {
	Code    int    `json:"code"`
	Message string `json:"message"`
}

type ErrorResponse struct {
	// populated when http status code is not OK
	NetworkError *HTTPError `json:"networkErrors"`
	// populated when http status code is OK but the server returned at least one graphql error
	GqlErrors *gqlerror.List `json:"graphqlErrors"`
}

Parse flow:

If the response code is non OK, the network error will be populated with the result code and a generic message; the body content won't be parsed. the body will still parsed looking for a valid graphql error
If the result code is ok, the response body is parsed in an helper struct:

type response struct {
	Data   json.RawMessage `json:"data"`
	Errors json.RawMessage `json:"errors"`
}

If response.Errors exists, its content is parsed into a gqlerror.List. If the parse fails, a generic error is returned, if succeds an ErrorResponse error type is returned

If response.Data exists, its content is parsed into the final result struct. If the parse fails, a generic error is returned

How to check the error
The error can be checked with a simple type assertion:
getUser, err := githubClient.GetUser(ctx, 10, 10)
if err != nil {
	if handledError, ok := err.(*client.ErrorResponse); ok {
		fmt.Fprintf(os.Stderr, "handled error: %s\n", handledError.Error())
	} else {
		fmt.Fprintf(os.Stderr, "unhandled error: %s\n", err.Error())
	}
	os.Exit(1)
}

This PR resolves #21
**EDIT: ** since some servers return a formatted and valid graphql error even if the http code is "non OK", the response body is always parsed, looking for graphql errors
What do you think?

I think it good ! Thanks !

I forgot to leave my feedback, but it worked great! Thanks a lot :)


[Icon Request] Support for vue.config.js

[x] I'm sure this issue is not a duplicate.

[x] I'm submitting an icon request:

Type: extension, languageid, filename

Icon Name: vueconfig

Sample original Icon:

Extensions: .config.js

Filenames: vue.config.js

Language ids: vue, vueconfig

Language Extensions: ??

More info: https://vuejs.org/

Just like the existent one with the addition of the config wheel.

I believe this would be the next candidate for the PAD system in order to support vue.config.js but not sure what are the file extensions being related to vue projects.
Any thoughts @vscode-icons/development team?

The correct doc for this is at https://cli.vuejs.org/config/.
@KingDarBoja Nope. This isn't a candidate for PAD. This should be supported like any other similar icon.
i.e.
{
      icon: 'vue',
      extensions: ['vue.config.js'],
      languages: [languages.vue],
      format: FileFormat.svg,
    },

On second thought, scratch the above comment. Since vue has also file extensions this can be implemented as a new icon with the cog, as suggested.
    {
      icon: 'vueconfig',
      extensions: ['.vuerc', 'vue.config.js'],
      filename: true,
      format: FileFormat.svg,
    },

@igorer88

https://github.com/vscode-icons/vscode-icons/wiki/Pad

this can be implemented as a new icon with the cog, as suggested.

It needs an icon too so let @KingDarBoja do it.


Using Sparkfun WiFi IR Blaster WRL-15031

After re-configuring the pin declarations and entering my network address info, the device seems to load everything accurately, but the IR receiver seems to receive superfluous data. Random data seems to be received even when taken to an "IR quiet" area. Additionally, the green LED isn't working either. But I confirmed it to work with the blinky example. Can someone please help with this?

Might be a hardware problem or a cheap receiver, or a receiver pin that has other uses. Might want to try a different pin and see if it persists. Ambient light and sunlight can occasionally trigger receives (sunlight more commonly so)
This would be something to pass on to the IRRemote8266 github though as this script just uses that library it doesn't handle any receiving directly on its own

I also thought it was a hardware problem, so I replaced it... and the Beefy 3 FTDI that I used. I suppose that it's possible that it could be a pin issue since these boards are manufactured, but they are manufactured specifically for this purpose, so swapping pins will be significantly harder. I also thought that it could have been some of the code in the IRRemote8266 library, but then I would suspect that it would have caused problems when I tested the receive demo. But it works fine, so did the transmitter.
I've been trying this for some time now, and I can't figure out what could be causing this. It's been a headache. Trust me, I wouldn't have bothered you with this unless I have exhausted all other possibilities.
I have even considered re-writing all of this myself, but coding is time-consuming and I only wanted to do this if I couldn't get this to work at all.
I thought that it could be that the receiver is receiving what is being transmitted, but this is also not the case since it receives IR data when not transmitting. Another thing to note is that the type of code is not detected, where the receive demo did detect the type of signal (Sony, Samsung, etc.).

I experienced such erratic behavior when connecting to the node32 using an Android based browser on both my phone and a tablet.  Switched over to my Win10 laptop to browse the Node32 website for reliable results.  Hope this helps.

I wish this was the case, but my problem is deeper than that. Thanks anyway, it's good to know.

Post a pic of your build
Random noise tends to not be in any readable format so you get an 'unknown' code so that part isn't surprising. Browser should have absolutely nothing to do with it, the code reading happens on a layer below the browser level functions and can be viewed from the serial output as well but its all independent of the browser and can be verified on the serial output
I will say I've never tried this on the sparkfun board so maybe worthwhile to try one of the more common nodemcu boards to rule out a hardware issue
Additionally the irremoteesp8266 library has some sample code projects that are very bare bones that you could upload to test the receiver that don't have all the other functionality of this project that you could use to try and debug with but honestly from a receiver side of things this blueprint doesn't add on any significant changes.
Post some serial logs of the data you're receiving if you want more help but without any logs or pics of the build I won't be able to help

Hey MDHIGGINS,
I don't know what happened to my problem report from before, but I found a possible solution. This is the one about Sparkfun WiFi IR Blaster WRL-15031
In the IR rec demo, I found that I needed to adjust the timeout of UNKNOWN signals. I set it to basically ignore unknown signals (1000ms) and that seems to have solved the problem with receiving. I don't remember having that problem with this board, the first board I tried I did not.
The LED problem persists. This board used GPIO 5.

A code sample of what you changed is always helpful for others who have the same board/issue


Gh 45 resolves #45

this branches off of updates branch and includes latest revisions that fixed #46 fix abc deprecation warning


Feature request: idempotent decorator for Lambda handler

Use Case
Users who write their Lambda functions as classes should be able to make their function handler idempotent via decorator.
Solution/User Experience
import { LambdaInterface } from '@aws-lambda-powertools/commons';
import {
  idempotentHandler,
  DynamoDBPersistenceLayer,
  IdempotencyConfig,
} from '@aws-lambda-powertools/idempotency';

const config = new IdempotencyConfig({...});
const ddbPersistenceLayer = new DynamoDBPersistenceLayer({...});

class Lambda implements LambdaInterface {
  // Decorate your handler class method
  @idempotentHandler({
    persistenceStore: ddbPersistenceLayer,
    config
  })
  public async handler(_event: unknown, _context: unknown): Promise<void> {
    /* ...Function logic here... */
  }
}

export const handlerClass = new Lambda();
export const handler = handlerClass.handler.bind(handlerClass);

The idempotentHandler decorator should be able to decorate an handler method of a LambdaInterface class, both async and sync. The decorator should accept an object with mandatory persistenceStore and an optional config one. The former should be an instance of any class that extends BasePersistenceLayer, while the latter should be an instance of the class IdempotencyConfig.
Following the Powertools for Python implementation, the decorator should:

return early if the POWERTOOLS_IDEMPOTENCY_DISABLED env variable has a truthy value (using EnvironmentVariableService)
use the provided config object or instantiate a new one if none is passed
register the Lambda context into the config object (used to manage timeouts)
instantiate an IdempotencyHandler
call & return the IdempotencyHandler.handle() method

This last step will ensure that the IdempotencyHandler will perform all the actions needed to make the function idempotent.
Alternative solutions
No response
Acknowledgment

[X] This feature request meets Lambda Powertools Tenets
[ ] Should this be considered in other Lambda Powertools languages? i.e. Python, Java

Given that Powertools for AWS (Python) is deprecating decorator usage we have decided to not implement this feature in this version.
We are open to reconsider this decision in the future if there's enough customer demand, but for now we will remove it from the backlog.


Indicate participants of the minimum quorum for the meeting

Hi @AtJano
Great that you are interested in 4Minitz.
Nevertheless your enhacement idea seems a little bit blurry to me.
Could you work out some details? What do you want to achive?
Maybe you can formulate one or more user stories (in form of the user story template)?

The quorum is the minimum number of members who must be present at a meeting to decide/vote issues/business.  No motions or votes should occur unless there is a quorum.  As a result, if quorum is lost the meeting or the debate of the item stops.

No upvotes, no pull requests, no "me too".
Will close this issue as "won't fix"


Repository Organization

For better organization of the project repository please consider the following:
1- Every src folder must have two sub-folders: original and sentiment. Folder names must follow this format: FolderName. Consider abbreviations if the folder name contains more than three words. For instance, a folder named ExploratoryTextDataAnalysis may be abbreviated as ETDA. Please create/rename the folders accordingly and place your notebooks in the corresponding folder.
2- Every IPython Notebook must adopt the following naming format: Name-Of-The-Notebook.ipynb. Please create/rename your notebooks accordingly.

Repository organization is done. Please take a look at the src folders and make sure that your notebooks have been placed in the correct folders. Any future commit that includes the addition of an IPython Notebook or a sub src folder must follow the guidelines specified in this issue.

I didn’t take into consideration item no. 2 when I closed this issue. Therefore, issue remains open. Please rename your notebooks according to item no. 2.


Okta Function App Error

Describe the bug
I used the ARM template to create an Azure function application to bring Okta logs to Sentinel, but the function is failing to run, saying unable to create a new table in the Azure storage for the azure function app
To Reproduce
Steps to reproduce the behavior:

Go to Azure Portal
Access Sentinel
Access Content Hub
Lookup Okta Single Sign-On
Install the solution
Access Data connectors
Lookup the Okta Single Sign-On data connector
Open connector page
Follow the steps to onboard Okta logs to Sentinel
From the 2 options, expand Option 1 - Azure Resource Manager (ARM) template
Click on Deploy to Azure
Once you put in the information to deploy the arm template, finish the deployment
Access the newly created function app
In the function app, on the bottom right, click on "Invocations and more"
See error

Expected behavior
The function app should be able to run without any errors and bring in Okta logs to Sentinel
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

Hi @tazamyinsight, Thanks for flagging this issue, we will investigate this issue and get back to you with some updates by 31-05-2024.
Thanks!

Thank you, just wanted to let you know that today we came across the same Okta logging issue in another Sentinel workspace

Hey @dwrusse/ @tazamyinsight, Thanks for your response. We will investigate on this issue and get back to you with update.

We had the same issue and solved it by changing Powershell version to 7.4, in the Function App Configuration tab, under General Settings:

Hey @tazamyinsight/ @dwrusse / @beachfires, Could you please follow below steps and let us know if you still have the same error :-

In a function app, Under the Configuration tab check for the Function runtime version. It should be ~4:-

In General Setting, please change the PoweShell Core version to 7.4 :-

Save the changes and Restart the function app :-

Currently, we are working on adding the same into the code, Meanwhile could you please update it manually and let us know if you encounter any other errors. Thanks!

@v-sudkharat because we've deployed the function app using the ARM template provided by Azure, those settings are not configurable.  Instead, the following app setting environment variables needed to be changed:

Modify FUNCTIONS_EXTENSION_VERSION to ~4
Add FUNCTIONS_WORKER_RUNTIME_VERSION with value: 7.4

And then restart the function app.  I confirmed this is working for us, thank you.
Please update the ARM template provided by Azure so we can update our IaC accordingly.

Where do we do this?
Modify FUNCTIONS_EXTENSION_VERSION to ~4
Add FUNCTIONS_WORKER_RUNTIME_VERSION with value: 7.4

@tazamyinsight , Open the deployed function app, and follow the steps which mentioned above

Where do we do this?
Modify FUNCTIONS_EXTENSION_VERSION to ~4 Add FUNCTIONS_WORKER_RUNTIME_VERSION with value: 7.4

Hey @tazamyinsight, Please open your deployed function App, and inside it you get the Configuration tab to make changes and remaining steps will be added over here  :- https://github.com/Azure/Azure-Sentinel/issues/10525#issuecomment-2139441029
Please let us know once your issue gets resolved, Thanks!

Hey @tazamyinsight, Waiting for your response for above comment. please let us know if your issue resolved so we can close it from GitHub. Thanks!

Hi @tazamyinsight, Gentle Reminder: We are waiting for your response on this issue. If you still need to keep this issue active, please respond to it in the next 2 days. If we don't receive a response by 10-06-2024 date, we will be closing this issue.
Thanks!

Hello, the fix mentioned here solved my issue, thank you.

Hi @tazamyinsight, Thank you for confirmation. closing this issue. If you still need support for this issue, feel free to re-open it any time. Thank you for your co-operation.


chains: add more call options

This add the possibility to use all the llm call options in the llm chain. I dont know why the lint fails, the issue should be nolinted.
PR Checklist

[x] Read the Contributing documentation.
[x] Read the Code of conduct documentation.
[x] Name your Pull Request title clearly, concisely, and prefixed with the name of primarily affected package you changed according to Good commit messages (such as memory: add interfaces for X, Y or util: add whizzbang helpers).
[x] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
[x] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
[x] Describes source of new concepts.
[x] References existing implementations as appropriate.
[ ] Contains test coverage for new functions.
[ ] Passes all golangci-lint checks.
[x] (remove and do not use this row unless you are a trusted contributor) I am an existing
contributor.

I'm a bit perplexed by this lint issue. Merging and will deal with on main branch


Ability to run isolated instances of cf cli

Please provide details on the following items. Failure to do so may result in deletion of your feature request.
What's the user value of this feature request?
Ability to have two separate cf cli environments without conflicting global state
Who is the functionality for?
Developers working on multiple projects simultaneously
Automated scripts that run cf (possibly conflicting with other executions or interactive use)
CI environments that build and deploy in parallel
How often will this functionality be used by the user?
As needed; most likely written into scripts that use cf.
Who else is affected by the change?
Default behavior will be unaffected, as the ability to isolate instances will require an explicit flag or environment variable
Is your feature request related to a problem? Please describe.
I'm using a CI server to push my code to multiple spaces, however doing this in parallel often fails depending on the order that the cf commands run, e.g.
 parallel {
                stage('Preview Webapp') {
                    steps {
                        sh('''
                            cf login -s my-app-preview -o my-org
                            cf push -f manifest.preview.xml
                        ''')
                    }
                }

                stage('Staging Webapp') {
                    steps {
                        sh('''
                            cf login -s my-app-staging -o my-org
                            cf push -f manifest.staging.xml
                        ''')
                    }
                }
            }

Depending on the race, the push may end up going to a different space than intended:
[Preview Webapp] + cf login -s my-app-preview -o my-org
[Staging Webapp] + cf login -s my-app-staging -o my-org
[Staging Webapp] + cf push -f manifest.staging.xml
[Preview Webapp] + cf push -f manifest.preview.xml // oops, this got pushed to my-app-staging

Describe the solution you'd like
Some way to specify a different "instance" of cf.  One easy way would be to allow the user to set a custom CF_HOME environment variable which would be used to locate the config.json file.
CF_HOME=./cf-preview cf login -s my-app-preview -o my-org
CF_HOME=./cf-staging cf login -s my-app-staging -o my-org
CF_HOME=./cf-staging cf push -f manifest.staging.xml
CF_HOME=./cf-preview cf push -f manifest.preview.xml

If CF_HOME was not set, the default of $HOME/.cf could be used.
Describe alternatives you've considered
Another solution would be to add an option to specify the config.json path, which is already supported for some commands like cf create-service:
OPTIONS:
   -c      Valid JSON object containing service-specific configuration parameters, provided either in-line or in a file. For a list of supported configuration parameters, see documentation for the particular service offering.

However, the -c option is already taken for some commands (e.g. cf push)
A workaround for a CI case is to use completely isolated build agents, though this adds extra overhead and build time.

Not trying to hijack or anything, but I wonder if this issue https://github.com/cloudfoundry/cli/issues/1503 would address this use-case?

@aegershman that would also work as a solution.  I am also embarrassed to see that a CF_HOME environment variable is already supported 😝

Hi @pimlottc-gov thanks for reaching out to us, good to hear from you. Please let us know if you are happy to close this issue given @aegershman's response. Thanks.

Hi @pimlottc-gov I'm closing this issue due to inactivity, please do not hesitate to reopen if you have any questions/feedback. Thanks.

The CF_HOME solution is working fine for me, thanks!  No problem with the close.


Stateful masters #2

Hey Paulo! @pires
After merging stateful masters branch, you removed services for StatefulSets which I think are still needed for the network to work properly. These services are referenced via spec.serviceName in StatefulSet Controller.
Ref: https://kubernetes.io/docs/concepts/workloads/controllers/statefulset/#limitations
"StatefulSets currently require a Headless Service to be responsible for the network identity of the Pods. You are responsible for creating this Service."
I've added es-data-svc.yaml and es-master-svc.yaml as a part of stateful cluster deployment.
Sorry for forgetting it in the first PR

Resolved.
Github doesn't take es-data-svc.yaml as a change even though I have it in this branch and that file is deleted on your master branch, so I'm not sure if you see in what state es-data-stateful.yaml and es-data-svc.yaml need to be.


Allow to save draft email server side

And allow to save multiple draft at same times. One for each mailboxes


SSR Only?

Is there a way to configure Nuxt to be SSR-only, not isomorphic/universal? When I look at the configuration mode documentation, I only have an option for universal (isomorphic) and spa.
The use-case is CORS related. I am unable to consume an API I need to consume client-side so I need to restrict my application to SSR-only.

This question is available on Nuxt community (#c9076)

reopen it, bot !

SSR-only means losing almost all the benefits of a progressive-web application and also no Vue.js on client-side! We once added this feature as an experiment but results were not good at all!
So as a advice (no offense) you may have to rethink about your project architecture that how API calls are made or not using Nuxt.js but a server-side template engine like ejs/laravel.

And if the only issue is CORS then you could look into setting up a proxy for your API (see nuxt-axios documentation for example).

@rchl - can you offer more insight into this? The reason I'm asking is this question I posted in the django-cors-headers repository, about why my Nuxt application isn't triggering a preflight when I'm setting a custom-header. Perhaps you know?

@SHxKM Check https://axios.nuxtjs.org/options#proxy

@rchl - yes. I’ve seen that by now. Why does turning this option on solve CORS? I’ve opened a question on the Proxy Module repo.

It's a proxy - you are making request to the domain you are on which means there is no CORS kicking in and your backend proxies request to your chosen host. There is no CORS restrictions on the node side.


Compilation failed.

stack build --ghc-options="-DGITREV=824b2303a5dd0058e617a351a1667fa66973d919 -Wwarn +RTS -A256m -n2m -RTS" --test --no-haddock-deps --bench --jobs=4 --flag cardano-sl:with-wallet --no-run-tests --no-run-benchmarks --dependencies-only  cardano-sl-infra

unix-compat-<IP_ADDRESS>: configure
unix-compat-<IP_ADDRESS>: build
Progress: 1/4
--  While building package unix-compat-<IP_ADDRESS> using:
      /mnt/aa/.stack/setup-exe-cache/x86_64-linux-nix-ncurses6/Cabal-simple_mPHDZzAJ_<IP_ADDRESS>_ghc-8.0.2 --builddir=.stack-work/dist/x86_64-linux-nix-ncurses6/Cabal-<IP_ADDRESS> build --ghc-options " -ddump-hi -ddump-to-file"
    Process exited with code: ExitFailure 1
    Logs have been written to: /home/vb/code/cardano-sl/.stack-work/logs/unix-compat-<IP_ADDRESS>.log

    Configuring unix-compat-<IP_ADDRESS>...
    Building unix-compat-<IP_ADDRESS>...
    Preprocessing library unix-compat-<IP_ADDRESS>...
    [1 of 8] Compiling System.PosixCompat.User ( .stack-work/dist/x86_64-linux-nix-ncurses6/Cabal-<IP_ADDRESS>/build/System/PosixCompat/User.hs, .stack-work/dist/x86_64-linux-nix-ncurses6/Cabal-<IP_ADDRESS>/build/System/PosixCompat/User.o )
    [2 of 8] Compiling System.PosixCompat.Unistd ( src/System/PosixCompat/Unistd.hs, .stack-work/dist/x86_64-linux-nix-ncurses6/Cabal-<IP_ADDRESS>/build/System/PosixCompat/Unistd.o )
    [3 of 8] Compiling System.PosixCompat.Types ( src/System/PosixCompat/Types.hs, .stack-work/dist/x86_64-linux-nix-ncurses6/Cabal-<IP_ADDRESS>/build/System/PosixCompat/Types.o )
    [4 of 8] Compiling System.PosixCompat.Time ( src/System/PosixCompat/Time.hs, .stack-work/dist/x86_64-linux-nix-ncurses6/Cabal-<IP_ADDRESS>/build/System/PosixCompat/Time.o )
    [5 of 8] Compiling System.PosixCompat.Temp ( src/System/PosixCompat/Temp.hs, .stack-work/dist/x86_64-linux-nix-ncurses6/Cabal-<IP_ADDRESS>/build/System/PosixCompat/Temp.o )
    [6 of 8] Compiling System.PosixCompat.Files ( .stack-work/dist/x86_64-linux-nix-ncurses6/Cabal-<IP_ADDRESS>/build/System/PosixCompat/Files.hs, .stack-work/dist/x86_64-linux-nix-ncurses6/Cabal-<IP_ADDRESS>/build/System/PosixCompat/Files.o )
    [7 of 8] Compiling System.PosixCompat.Extensions ( .stack-work/dist/x86_64-linux-nix-ncurses6/Cabal-<IP_ADDRESS>/build/System/PosixCompat/Extensions.hs, .stack-work/dist/x86_64-linux-nix-ncurses6/Cabal-<IP_ADDRESS>/build/System/PosixCompat/Extensions.o )
    [8 of 8] Compiling System.PosixCompat ( src/System/PosixCompat.hs, .stack-work/dist/x86_64-linux-nix-ncurses6/Cabal-<IP_ADDRESS>/build/System/PosixCompat.o )
    ghc: fd:15: hGetContents: invalid argument (invalid byte sequence)
    `gcc' failed in phase `C Compiler'. (Exit code: 2)```

Hi!

What branch do you use?
Do you use ./scripts/build/cardano-sl.sh?

Le 11/10/2017 à 11:43, Denis Shevchenko a écrit :

Hi!

What branch do you use?

1.0 or master, same result.

Do you use |./scripts/build/cardano-sl.sh|?

Yes.
--
Vincent

Ok, the problem is here:
ghc: fd:15: hGetContents: invalid argument (invalid byte sequence)

It looks like there's a problem with encoding. Please add these export-lines in scripts/build/cardano-sl.sh:
#!/usr/bin/env bash
set -e
set -o pipefail

export LC_ALL=en_US.UTF-8
export LANG=en_US.UTF-8
export LANGUAGE=en_US.UTF-8

@vbmithr ping?

@vbmithr what's the output of lsb_release -a

@vbmithr please reopen if you have more information. Until we know how to reproduce we can't help.


gulp-flowtype is not working for me. Not finding errors. Long running time.

I am not sure why, when I use gulp-typeflow it takes 12s to run the code and it finds 0 erros, while running "flow" command finds errors missed by gulp-typeflow.
I've replaced gulp meanwhile to work with regular 'flow' cmd command which works with the .flowconfig settings
Previous flow task ( with gulp-flowtype )
gulp.task('flowtypeSrc', () =>
  gulp.src(paths.srcJs)
    .pipe(flow({
      all: true,
      weak: false,
      declarations: './flow-typed/npm',
      killFlow: false,
      beep: true,
      abort: true,
    })) // Add Flow here
);

Output:
...
✔ Flow has found 0 errors
[12:22:05] Finished 'flowtypeSrc' after 11 s
...
Actually fails to find erros... and runs 11 seconds.
My current flow task:
gulp.task('flowtypeSrc', () => {
  try {
    execSync('./node_modules/.bin/flow', { stdio: 'inherit' });
  } catch (e) {
    gulp.stop();
  }
});

Output:
...
Found 1 error
[12:14:17] Finished 'flowtypeSrc' after 308 ms
...
I hope to contribute when I get the time, meanwhile this is a valid solution for others with the same problem.

+1

@saginadir what does your replacement gulp task look like?

@faceyspacey Here it is:
gulp.task('flowtypeSrc', () => {
  try {
    execSync('./node_modules/.bin/flow', { stdio: 'inherit' });
  } catch (e) {
    if (!e.message.match(new RegExp('Command failed','i'))) {
      console.log(e);
    }
    gulp.stop();
  }
});

It's es6
Notice I am running ./node_modules/.bin/flow command
Just make sure flow-bin npm package is installed.

@saginadir thanks brother!

The same is happening to me, I have the setup from  this tutorial

It's my first time using gulp and es6, ut I will try to find the issue, as this weekend my wife is out, so I'll bring the party home 🍺 👊 🍻

I have opened a PR to solve that. Basically the application was ignoring all stderr outputs and understanding no outputs as a no errors check.

@alexxmde Gotcha Alex :) nice find.
This library seems unmaintained for several years, and it has it's reasons

Gulp is not as used anymore - webpack does a lot of the work these days with the -w flag that watches for changes and recompiles
Most tools come with -w flag that reruns on file change and makes gulp further obsolete
npm can have custom scripts which you can run like "npm run install"  or "npm run build" and it further obsoletes gulp
I was just using flow in my JetBrains IDE which gives you the errors in the IDE

But still nice catch :) brings me peace to know it's solved.

Hi all,
@saginadir lists the exact reasons for why I stopped maintaining this project along with being unable to keep up with Flow API changes (I hacked this module together the night that Flow was released 😅, a lot has changed).
I appreciate the contribution @alexxmde, I'll check out your PR.
Cheers,
Charlie

Seems to be a problem in the executable flow file that is located in node_modules/gulp-flowtype/node_modules/flow-bin/vendor/flow. Solved this problem by installing flow-bin yarn add --dev flow-bin and pointing the path to flow process.env.FLOW_BIN = path.resolve(__dirname, 'node_modules/.bin/flow'). Now everything works like a charm.


chore(deps): bump codecov to 3.7.1

:tada: This PR is included in version 1.21.1 :tada:
The release is available on:

v1.21.1
GitHub release

Your semantic-release bot :package::rocket:


[test] Annotate an expected test crash for humans who read crash logs.

@swift-ci please smoke test

@swift-ci please smoke test


V4 API for run(), call(), spawn()

One of the things happening in v4 is that we're aligning call() to be more similar to Function.prototype.call() This would imply that the signature for call() would be:
call(fn, thisObj, ...args)

The question is 1) is this desirable? and 2) what should we do with the other "call-like" functions in Effection: run() and spawn(). We could align them like this;
// v3
spawn(fn);
run(fn);

//v4?
spawn(fn, thisObj, ...args);
run(fn, thisObj, ...args);

On the one hand, this has a nice alignment with vanilla js, but on the other, it's annoying in that we don't really ever use this. Still, this is supposed to feel like native JS building blocks, so I'm not sure what the best way to go is.
On the other hand, I've been toying with the idea of deprecating scope.run() and replacing it by passing scope as a parameter to run() This would re-enforce the idea that this is an entry point from javascript and something you should do with care.
run(fn, { scope })

Which is better?

it's annoying in that we don't really ever use this.

Conversely, when using NestJS and Effection together, I often need to use this, which can be quite inconvenient.
import { globalScope } from '..'

@Controller('receiver')
export class ReceiverController {
  @Inject()
  private readonly passport!: Passport

  @Inject()
  private readonly pushService!: PushService

  @Delete()
  public [`@Delete()`](): Promise<void> {
    return globalScope.run(function*(this: ReceiverController) {
      const receiver = yield * this.pushService.getClaimerReceiver(this.passport.id)

      if (null === receiver) {
        return
      }

      yield * this.pushService.deleteReceiver(receiver)
    }.bind(this))
  }
}

@iplaylf2 Thanks so much for your comment. This is a great data point!

I just came across Effection last week and am loving it! Just my two cents on this: you could use an approach similar to Redux-Saga and allow the first arg to call be function or an array where the first element of the array is the thisArg and the second is the function:
class SomeClass {
  public async doStuff(someArg: string): Promise<void> {
    // Stuff being done...
  }
}

const someThing = new SomeClass();

yield* call([someThing, someThing.doStuff], "Hello");

That would make it easier for users to upgrade to the new API and wouldn't require a lot of extra code on your part to check if the call function has a this context.

Glad to hear you like it @mikerourke! We've got a lot of fun stuff coming down the pike too.
This is a really interesting approach that I hadn't considered, but it seems really nice! Is there any downside in your experience? /cc @neurosnap

@cowboyd I've been using Redux-Saga in several projects for the last 4 years, and I haven't encountered any issues with that API for call. It's probably worth mentioning that Redux-Saga also provides an apply effect that has a similar API to Function.prototype.apply that would look like this in Effection:
yield* apply(someThing, someThing.doStuff, ["Hello"]);

If you end up opting for the "array as a first arg for call" approach when you need a this context, it might be nice to provide apply as a convenience wrapper around the call([thisArg, fn], args) API.

The question is 1) is this desirable?

I think it depends.  redux-saga call function type signature is pretty complicated since it can handle so many use cases -- including properly handling this.  All of this is stemmed from the fact that the end-user doesn't call the function being passed into call, rather, the saga runtime handles calling all functions.  The reason why this was preferred is because of the way saga handled side-effects: the end-user doesn't have to deal with managing side-effects because user functions don't actually call them.
The thing I liked about v3 call() is that we didn't have to deal with these use cases at all since the end-user does call the function itself: call(() => response.json());
So if all we are trying to do is align Function.prototype.call with v3 call() then I would rather argue we just change the name of call to something specific to what it is trying to accomplish in effection.
However, if in v4 we are moving to a world that is more similar to redux-saga where the effection runtime run() evaluates a bunch of yielded json objects and then converts them into function calls / activating side-effects, then we will most likely have to do it the way suggested above.
Lemme know if that doesn't make sense since this sort of relies on understanding how redux-saga works.

Let's just keep it as function only, and we'll keep the rest of the API in our back pockets until we can make a clear determination. We can always add args to call((...args) => thing, ...args) if we start with call(() => thing)
That said, I do like using the array idea from redux saga as a way to pass this. I (think) we can add that in the future without making our call() overly complex.


Fix mock generation of function pointer signature parameters

Before this fix an interface method with a parameter such as func(goa.Endpoint) would be generated as
func(goa.design/goa/v3/pkg.Endpoint) instead of something that is actually valid Go.

Codecov Report

Merging #227 (2da56a3) into main (6c3314f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@           Coverage Diff           @@
##             main     #227   +/-   ##
=======================================
  Coverage   94.31%   94.32%
=======================================
  Files          43       43
  Lines        2183     2186    +3
=======================================
+ Hits         2059     2062    +3
  Misses         91       91
  Partials       33       33

Flag
Coverage Δ

micro
94.32% <100.00%> (+<0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

mock/cmd/cmg/pkg/generate/type.go
100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Fix 3d viewer on Desktop

https://github.com/lbryio/lbry-desktop/blob/master/ui/component/fileRender/view.jsx#L166

Thanks @btzr-io !