Fix disconnected bank account still displayed in workflow page

Details

Fix disconnected bank account still displayed in workflow page
Fixed Issues

$ https://github.com/Expensify/App/issues/39439
PROPOSAL: https://github.com/Expensify/App/issues/39439#issuecomment-2036576092
Tests

Pre-requisite: user must be logged in, have created a collect workspace and have connected a bank account.

Go to Settings > Workspace > Workflows
Click on Bank account
Tap on "Disconnect bank account" and confirm.
Tap on the back arrow.
Verify that the bank account is cleared

[x] Verify that no errors appear in the JS console

Offline tests

None
QA Steps

Go to Settings > Workspace > Workflows
Click on Bank account
Tap on "Disconnect bank account" and confirm.
Tap on the back arrow.
Verify that the bank account is cleared

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
https://github.com/Expensify/App/assets/161821005/31f14923-427a-4191-b951-5ee8e57def41

Android: mWeb Chrome
https://github.com/Expensify/App/assets/161821005/0472bfc5-cf2e-44b9-a9f0-a374973ede15

iOS: Native
https://github.com/Expensify/App/assets/161821005/9954095f-642a-478c-8874-77481b349093

iOS: mWeb Safari
https://github.com/Expensify/App/assets/161821005/c87857c1-ee2a-4032-8a6c-0b2bd0da50a1

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/161821005/1e79a394-3a8c-429b-8e3f-11f9e4612997

MacOS: Desktop
https://github.com/Expensify/App/assets/161821005/ceb6b233-2850-4517-9d4f-7310cfd062ae

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.64-6 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Standardized the class construction and inheritance

Overview

Adds PIXI.utils.extend, for instance PIXI.utils.extend(MyClass, EventEmitter);
Adds the constructor property to the prototype
Extends the prototype from the parent to the child using Object.create(parent.prototype)
Adds a static extend function to the child class for extending further
Gives a return value of the child class (first parameter)
Where applicable, replaced class constructor/inheritance with short-hand (e.g.,
DisplayObject.extend(Container)). This does the same thing as calling PIXI.utils.extend.

Example Usage
function MySprite(texture)
{
	Sprite.call(this, texture);
}
Sprite.extend(MySprite);

Or alternately:
var MySprite = Sprite.extend(function(texture)
{
	Sprite.call(this, texture);
});

As opposed to the more verbose:
function MySprite(texture)
{
	Sprite.call(this, texture);
};
MySprite.prototype = Object.create(Sprite.prototype);
MySprite.prototype.constructor = MySprite;

Nice! Thanks @bigtimebuddy :+1:
This looks pretty awesome to me! @englercj looks cool to you too?

Looks good to me, I'd rather the plugin mixin wasn't in the extend method though. I still feel that should be separate since it is a separate concern.
If you remove the plugin mixin part of extend it looks good to me! Thanks for this! Very cool.

@englercj Good call, I removed the pluginTarget mixin stuff from utils.extend.

Nothing against the great work here @bigtimebuddy, but having been bit many times by standard yet framework specific classical inheritance implementations that tend to bleed all over the place, I'm a :-1: on this. Contributors tend to feel they can't implement a class without utils, or forget, or maybe prefer to forget how JavaScript works. Plugins with classes must decide when and how to hook into the core utils. Overall it usually just ends up encouraging bad, or at least, non-standard practices.
If people are all for less verbosity, I would suggest one of following 2 things.

Just do this:

function MySprite(texture)
{
    Sprite.call(this, texture);
}
MySprite.prototype = Object.create(Sprite.prototype, {constructor: {value: Sprite}});

It's not really all that bad IMO, and is the actual pre-ES6 standard.

Use a transpiler (e.g. Babel), which conforms to next-gen JavaScript syntax:

class MySprite extends Sprite  {
    constructor() {
        super();
    }
}

Talk about less verbosity :wink:  This was discussed at some point this year (pretty sure it was before June). If a PR like this one is actually being considered for merge, I believe it should be up for discussion again. It's not like we'd be targeting an incomplete spec at this point.

I think it would be helpful to have some context. The motivation for adding this and several other new features recently (DisplayObject.setTransform, DisplayObject.skew) is that we're laying groundwork for creating a publishing pipeline for Flash. There are some essential ingredients missing from Pixi to provide compatibility with Flash as well as some design choices we've made, like the need to export JavaScript from Flash that is vanilla Pixi.
There is a strong need to create some native Pixi inheritance model/utility that is concise and readable. With Flash, it's not realistic at this point to be targeting ES6 for the output JS and arguably the single-line (MySprite.prototype = Object.create(Sprite.prototype, {constructor: {value: Sprite}});) is clever but isn't that more useful size-wise than creating two lines (96 vs 85 characters). We'll need to be creating export Flash files that contain 100s of extending library items (e.g., Flash output example). Having an extending convenience utility will really help.
@GoodBoyDigital I defer to you. The alternative solution is that I'm okay adding this functionality to PIXI.flash instead, which could provide this exact inheritance by adding static methods for Sprites, Container, Graphics, DisplayObjects, etc.

So to be clear, I am OK with using this since the majority of people will likely enjoy using it more than Object.create.
That being said @drkibitz is 100% correct. The idiomatic and "correct" way is what he posted. The way this PR implements is custom, non-standard, and requires users to know how to "extend in PIXI" instead of just doing normal JS prototype extension.
I do not subscribe to the notion that this or any change at all is necessary for PIXI Flash, nor do I agree that our current implementation is not readable. It is prototype extension, it is JavaScript; this is just how it works in this language.
I still feel like this PR is OK, if people want it, because people who understand JS less can easily extend one of our objects. But as an experienced JS developer, nothing is worse than opening a lib and seeing some weird custom extension method. It almost makes me want to give up on trying to figure out the lib.
Finally, after all that, I would suggest that we compromise. Do not use a custom extension method, but do use an inherit method. One that has been around for a while, is pretty common and people are familiar with. We are using browserify, so you can require('util') and just use the built-in node.js utils.inherits.
Obviously the best would be to write ES6 and just run it through babel, and I'm not sure what your concerns about the output of PIXI flash being ES6 are but we should talk about that (not in this thread). I definitely see the future of pixi going to ES6.

Specifically about this PR and not the concept of prototype extension methods in general; there is some inconsistencies in this PR that makes it difficult to immediately understand whats going on.
examples:
Some sites use utils.extend() while others use Parent.extend(). I understand why but that is only because I understand the implementation of this function. If you have to understand the implementation of an API to use it, I feel like we can do better.
There are a couple places like this:
module.exports = utils.extend(GraphicsData);

Which doesn't make sense to me. We aren't extending anything so why is it there? I realize we were setting constructor before and maybe this is here to do that, but setting constructor was superfluous and this is confusing. It looks like a typo since we are calling extend but not extending anything.
I think if we standardize on util.inherits() and use that everywhere we are truly consistent and the inherits method will do the right thing. Hopefully that sounds agreeable.

@englercj Okay. Just so I'm clear, you're suggesting simply using Node's built-in util.inherits and removing PIXI.utils.extend and ignore the former sites where only the constructor was being set?

I'm happy to retool this PR, but it doesn't _exactly_ solve the initial problem we had of being able to minimally express inheritance in the Flash output that we're hoping to generate.
Just for reference, this is how CreateJS expresses inheritance in it's Flash output, which is problematic for a number of reasons:
(lib.MyContainer = function() {
	this.initialize();
}).prototype = p = new cjs.Container();

We were hoping to do something a little more cleanly (which doesn't have to live at the Pixi-level). We are planning on creating PIXI.flash as a runtime (a la PIXI.spine) and because this is specific to the Flash output, I can move the static extend methods there.
lib.MyContainer = Container.extend(function() {
    Container.call(this);
});

I welcome your suggestions, thoughts.

@bigtimebuddy I'm sorry, but I disagree with almost everything in that comment. There is no need for anything here except convenience. I have preferred PIXI for more than just one reason but rather a combination, of course for performance, but also clarity and the speed of innovation. But specifically over CreateJS because it always seemed like innovation in EaselJS and family were blocked by their support for Adobe product export, (e.g. their sponsors).   For the 17th time, lets stop trying to do this please. ActionScript3 was great in theory, but it's not JavaScript, and if there is any possible way not to encourage and propagate the abuse of classical inheritance the way ActionScript does, lets go that route. To be honest, the explanation that these changes are brought on because of supporting some sort of flash export, this just makes me believe that PIXI will eventually go the way of EaselJS for me.
@englercj Many good points, and I actually thought about mentioning util.inherits, but even this is unnecessary. So I can't be ok with that and not with this PR. I'm still a solid :-1: on this. I've been on the side of PIXI modularity since I don't know when. Adding a util (or PIXI.utils) dependency on nearly every class in the library is just unnecessary, especially since it's not there now. I prefer vanilla JS, yes in my own development which is not important, but especially in OpenSource. It encourages good development practices, which in turn attracts good contributors to the project. This trumps any other need that I could think of.
But to be fair, my opinion probably doesn't matter that much. I haven't contributed nearly as much as I probably should have with code, but I feel like sharing my opinions here and there is a form of contribution regardless how people take them. To be clear, I've been using JavaScript for over 16 years, and ActionScript over 8 (as2 and 3). I've lived the evolution of Flash, and the reinventions of JS. Hopefully my experience has generated some useful opinions, and not things that have sounded like hollow rants here and there. I'm going to stand strong on this opinion, but don't feel bad if you simply don't agree or don't care.  I'm fine to have an discussion off this PR thread about that topic and our aims to build better tooling for Pixi. But thanks for sharing your thoughts and I get where you're coming from--our backgrounds are very similar.
@englercj Let me know how you'd like me to proceed with this PR.

I'm still with @drkibitz on this one, I haven't seen anything here as to why we need this for PIXI.flash, or what it has to do with it at all?
What we do now is idiomatic JS, why does that need to change? Why does the flash plugin require a different inheritance mechanism?
@drkibitz made a really good point here:

Adding a util (or PIXI.utils) dependency on nearly every class in the library is just unnecessary, especially since it's not there now.

That is a great point, why do we need to introduce a new dependency (and new code, etc) for this?

Okay I agree, I think this is superfluous for what the original intention was. I will close the PR.
The main problem we're solving for is JavaScript bloat. With auto-generate JavaScript (as you can see with CreateJS) deeply nested, complex and enormous display lists (like creating long animations), produce unreasonably large files with many library items that require inheritance (not just instantiation).
We have considered other formats to represent timeline animations (JSON, binary formats, etc), but the consensus from all though working on this project was that the code should 1) be easily readable, 2) be as vanilla Pixi as possible, and 3) be easy for coding and non-coding people to modify. The implication of auto-generating those few lines of prototype-Object.create inheritance, while more pure-JS, will mean huge output file sizes (~10-20% larger).
I don't expect you to agree with this approach, but we will probably still find someway to abstract the prototype chain inheritance for brevity's sake.

@bigtimebuddy @englercj Thanks, I appreciate the civilized debate on this one. @bigtimebuddy If it is specifically to reduce bloat for autogenerated code, I would be a lot less against utility methods like this if they remain specific to their needs, e.g. a PIXI.flash.extends or PIXI.flash.inherits sounds a lot more reasonable to me, as it would not extend beyond those boundaries, but hopefully help in the way the purpose of this originally intended.

Yeah using a method like that only inside of autogenerated code, only for that plugin seems extremely reasonable.
I'd be careful saying it would be 10-20% larger with those lines. They are really more like 1-5% of the filesize of an average pixi file. I feel like this change won't be as big of an impact as you think it will.
For example, measuring the effect this PR has on pixi.js:
// pure JS prototype extension
pixi.js        810,381 bytes
pixi.min.js    286,652 bytes

// using this PR for a util method
pixi.js        805,293 bytes   (0.628% file size reduction)
pixi.min.js    283,780 bytes   (1.000% file size reduction)

The change isn't all that noticable. I would expect you to see similar results in your generated code. Also I would make the argument that using the same extension method (that is pure prototype extension) that pixi.js itself uses makes it consistent with what people who have been using pixi.js are familiar with!


Relative tolerances of finite difference checks

In general, the finite difference checks used in the real mode should use the same tolerances. Right now, specific tests require higher or lower tolerances to pass.

We have addressed some of this in our derivative testing presentation. Has to do with condition number of different analyses. I'm not sure there is anything really to do about this.


Include supporting proof obligations in the json output

this brings a bit of parity to the json and text report. also add a note that we should add the API details to the json output later on for full parity

Thank you!


Version Query

Hey!  Great library!
I am trying to use it in conjunction with http://jillix.github.io/svg.pan-zoom.js/ but the download on your main page is built against an older 1x version, and the one in master gives me the following:
TypeError: svg.polygon(...).select is not a function

when used with the latest release of SVG.js (https://cdnjs.cloudflare.com/ajax/libs/svg.js/2.3.0/svg.min.js)
Please could you point me in the direction of the right library version you used to build against so I can track back through svg.pan-zoom.js until I get a working version!
Cheers!

From the doc of svg.select.js:

Note: Duo to naming conflicts the exported method was renamed from select() to selectize().

Also the package.json / bower.json correctly states svg.js v2.2.5 as dependency

Thanks, much appreciated!


Bug 2086488: Cannot cancel vm migration

📝 Description
Cancel VirtualMachine migration action was enabled only when Migrating status exists in vm.status.printableStatus.
This behavior was changed to enable the Cancel VirtualMachine migration action when VirtualMachineInstanceMigration exists and a delete request to the VMIM resources hasn't made yet (checking vmim.metadata.deleteionTimestamp exists)
if vmim.metadata.deleteionTimestamp exists, a description text to the action will be added until the VMIM resource will be deleted
🎥 Demo
before:
https://user-images.githubusercontent.com/67270715/169856706-ec8ac959-d526-47b6-80c1-8ccd47126c23.mp4
after:
https://user-images.githubusercontent.com/67270715/169856883-1082fa83-9e4c-4742-9085-45cd5d91faa5.mp4
Signed-off-by: Aviv Turgeman<EMAIL_ADDRESS>

/bugzilla refresh

/lgtm


feat(tutorial): complete step 5 - Dublin,Ireland

Closes #
{{short description}}
Changelog
New

{{new thing}}

Changed

{{change thing}}

Removed

{{removed thing}}

Please provide the IBM Cloud deploy URL

Oops sorry for the missing piece, here you go
http://carbon-tutorial-liunate.eu-gb.mybluemix.net/


[MetaData] add mean/std

In comparison to @TimeIt this decorator can be used e.g. for debugging a function.
@Node()
class SleepTest:
    @TimeItMean
    def sleep(self):
        sleep(1)

    def run(self):
        for _ in range(10):
            self.sleep()

SleepTest(load=True).metadata  gives
{'sleep:TimeItMean': {'mean': 1.0071059703826903,
  'std': 0.004479182352446432,
  'runs': 10}}

TODOs

[ ] Documentation
[ ] Tests
[x] fix temp_file ToDo
[ ] make it @TimeIt(mean=True) instead of a different decorator
[ ] fix issues with double decorator / descriptor problems

Node(silent=True)
class SleepNode:

    @TimeIt
    def run(self):
        print("GOT HERE?!")
        self.sleep_1s()
        self.sleep_2s()

    def sleep_1s(self):
        sleep(1)

    def sleep_2s(self):
        sleep(2)

SleepNode(load=True).run() # returns a function

You could overwrite the save method in metadata, if there is a list of values that a mean / std is computed over them.


App won't launch after adding FVP to pubspec

Describe the bug
I have been trying to add FVP to my application, but found that it was not launching correctly after updating the code to include FVP.
When I run the app from vscode it builds but nothing actually launches (and no errors are given) - If I hit the pause button the debugger and then hit resume again the app loads up fine and works ok.
In an attempt to find the problem I created a brand new application and simply added the fvp line to the pubspec (it's using 0.28.0 currently) - as soon as only that line has been added I get the behaviour that is described above.. even without any additional FVP code or anything else added to the default sample app that gets generated when you run 'flutter create '
Expected behavior
Application should launch correctly when FVP is present in the pubspec
Log
No logs as there are no errors generated.. steps to reproduce;
flutter create fvp_test
run app (Windows 11 target) - Works OK
add 'fvp: ^0.28.0' into the dependencies section of pubspec
run app (Windows 11 target) - UI never appears after building complete
click pause, then resume in the debugger toolbar - UI now opens and the app works ok

Thanks - I tried the Windows example from your link and it runs ok on the same PC that I'm developing my app on.
The most simple code I have is here https://drive.google.com/file/d/1R7jWNBQMEtFJBjI6jQmz-JTc_cjrUkHN/view?usp=sharing
For me, that compiles ok but never becomes visible - unless I remove the fvp line from the pubspec and then it launches ok.

It looks like this issue I reported a few months ago: #125 The app is only displayed after an hot reload

Thanks for the link, it certainly seems very similar but for me hot reload doesn't help - tried a few times and it never appears.
Using 'flutter run -d windows' from a command line does work though, so certainly seems like some kind of race condition with fvp and the debugger.

It looks like this issue I reported a few months ago: #125看起来就像我几个月前报告的这个问题： #125 The app is only displayed after an hot reload只有在热重载后才会显示应用程序

me too

what about removing dartPluginClass: lines in fvp's pubspec.yaml?

try master branch

Thanks - confirm this fixes the issue for me!


sdba  - Fix loess memory usage

Pull Request Checklist:

[x] This PR addresses an already opened issue (for bug fixes / features)

This PR fixes #529

[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Documentation has been added / updated (for bug fixes / features)
[ ] HISTORY.rst has been updated (with summary of main changes)
[ ] bumpversion (minor / major / patch) has been called on this branch
[ ] Tags have been pushed (git push --tags)

What kind of change does this PR introduce?
In sdba.loess, the rolling weights of the smoothing were computed before the iteration. This was meant to gain speed as they are reused niter times. However, it seems that this (Nt, Nt) array is sometimes too big and I believe this is what crashed the Readthedocs build. I rewrote so that the (Nt,) weights are (re)computed Nt * niter times instead. As niter is usually small ([1, 4]), the loss isn't enormous. Anyway, the cases where speed is a consideration are the same where huge memory use is a problem.

Does this PR introduce a breaking change?
No.

Pull Request Test Coverage Report for Build 2176

0 of 0   changed or added relevant lines in 0 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.06%) to 91.643%

Files with Coverage Reduction
New Missed Lines
%

xclim/subset.py
2
75.0%

Totals

Change from base Build 2175:
-0.06%

Covered Lines:
2873

Relevant Lines:
3135

💛  - Coveralls

Pull Request Test Coverage Report for Build 2176

0 of 0   changed or added relevant lines in 0 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.06%) to 91.643%

Files with Coverage Reduction
New Missed Lines
%

xclim/subset.py
2
75.0%

Totals

Change from base Build 2175:
-0.06%

Covered Lines:
2873

Relevant Lines:
3135

💛  - Coveralls

I added an hidden build on RTD that succeeded, problem fixed.
https://readthedocs.org/projects/xclim/builds/11697094/


embedded caption on web

It seems movies with embedded captions are not supported on web with media_kit 1.1.10+1 and the caption doesnt show, Is there anything or trick that we need to set to have embedded captions on web?

Ask web browsers... what can I do.


Added Dutch BTW (vat) Number

The Dutch BTW number has the following:

Countrycode NL
9 digit number
3 character suffix (B01 to B99)

see link (dutch) for more details

Thanks!


New Loading Video Node: Paths do not consider remote/cloud directories

The new Load Images node does not consider the need for remote server directories. The old (deprecated) node you used to be able to type in a path if you need. However the new one has fixed directories, which would then need to be mapped. For best flexibility, it would be best if we could manually type the path where needed so the user could load from any directory.
The choose folder button is nice for local, but when used remotely it shows a local directory which will not work for remote servers.
Thank you for the amazing work with AnimateDiff in ComfyUI!
Example:

In a few hours, I will have an update to VHS that adds Path version of Load Images and Load Video nodes, letting you choose any directory/video. The purpose of the new Load Images one was to limit access to input directory, but it's not a major security concern and the flexibility of being able to choose whichever directory is nice, so I'm bringing that back in a separate node. I'll update and close this issue when those nodes are pushed to VHS.

I've pushed Path versions of the relevant nodes to VHS! I will close this issue here now, but if you happen to have problems with them, please open a new issue in https://github.com/Kosinkadink/ComfyUI-VideoHelperSuite !


i18n(fr): Update guides/deploy/deno.mdx from #9949

Description (required)

i18n(fr): Update guides/deploy/deno.mdx from https://github.com/withastro/docs/pull/9949

Related issues & labels (optional)

Suggested label: i18n

Lunaria Status Overview
🌕 This pull request will trigger status changes.

Learn more
By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.
You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File
Note

fr/guides/deploy/deno.mdx
Localization changed, will be marked as complete.

Warnings reference

Icon
Description

🔄
The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.


Docker container not connected to repository

Hi! It looks like cruft docker container is not linked to the repo (or marked as private)
Here is some documentation how it can be fixed

Hi! Any reactions?

Fixed. Sorry for the delay.


Nuclide codefix

[x] All compiled assets are included (atom packages are git tags and hence the built files need to be a part of the source control)

Basic support for atom-ide-ui's code actions, as an alternative to intentions. This would allow to depend on atom-ide-ui exclusively, instead of current zoo of packages (linter, linter-ui-default, hyperclick, intentions)
This is basically a carbon copy of CodefixProvider, adapted slightly to atom-ide-ui's API. There's probably an easier way to handle this mess, but I don't see it right now, and I'm running out of time.
Any input is greatly appreciated.
As a side note, this PR also updates README wrt dependencies.

One thing I forgot to mention, I also bumped hyperclick provider from 0.0.0 to 0.1.0 (and changed the provider name as per docs), might solve some hyperclick-related issues

I agree that his is a worthy goal and we should merge, but I'm bothered by the code duplication between CodefixProvider and CodefixActionProvider. The only differences are in the API. This can be easily abstracted out using your favorite compositional pattern. Here are some options:

Have both providers extend from a base provider that does the work
Extract the common code out into helper functions
Have one provider call the other and translate the responses
Have the same class implement both provider APIs

Reasonable request. Done.
While at it, also changed some code in applyFix, namely switched from waiting for save event to using a promise directly.
A side note, @types/atom is horrifyingly outdated to the point of doing more harm than good. Switching to hand-rolled might be a better option at this point, and I do have a hand-rolled one here -- although it's rather rough around the edges, it's more or less up-to-date. Switching might be a lot of work, but I could probably do that. Let me know if you think it's a good idea.

Thanks 👍
Yeah, @types/atom are pretty bad. If it's causing you issues when working on something, feel free to delete and start from scratch using the ones you have.

Hold off on a merge in any case, I think I found a bug I'd like to fix first.

Okay, so apparently it's better to apply changes in reverse, otherwise multiple changes tend to trample over themselves. For example:

1f1d570 seems to work, but I didn't do any extensive testing.

I've been using this for a while and didn't stumble upon any more issues, so I guess it should be good to merge. Which is exactly what I'm going to do now.

🎉


⚠ Beulah Revival Network has degraded performance

In f917099, Beulah Revival Network (https://beulah.clicki.digital) experienced degraded performance:

HTTP code: 200
Response time: 11913 ms

Resolved: Beulah Revival Network performance has improved in de06d06.


Datatables 1.10.19 and scroller extension 2.0.0

Hi,
We use black-dashboard.css in our webapplication, and the application uses datatables version 1.10.19 and the datatables scroller extension, version 2.0.0 - and the whole site builds upon bootstrap 4.
We've experienced that the Edge browser (Microsoft Edge 44.17763.1.0) has problems with the datatables scroller extension, and only when the black-dashboard sheet is used.
If we bypass the black-dashboard sheet, datatables with the scroller works fine. Chrome and Firefox has no problem rendering the content nicely.
Inspecting the black-dashboard sheet indicates that is was built with datatables-1.10.18 and datatables scroller 1.5.0.
Could we try to have an updated version built on recent versions?
Here's an image of the resulting problem in Edge - there's a sort of loading indicator all over, and the contents are present, but hardly visible. And it renders without vertical scrollbar which is also not an issue in Chrome/Firefox.

Here is how it looks in Chrome...

Thank you for your support on this.. and an otherwise awesome theme.
mlgdk

Hi,
Thank you for working with our products.
We provide Data Table in our Pro Version available on the official Bootstrap Marketplace (https://themes.getbootstrap.com/product/black-dashboard-pro-premium-bootstrap-4-admin/). You can find it in Tables -> Datatables.net and it has all the configurations that you need.
Hope it helps.
All the best,
Rares


Flash: Add additional tests and increase code coverage

Requires https://github.com/bosagora/agora/pull/1815 (ignore first commit)

@omerfirmak I hope there's not too many commits. :)


Clarified expectations for pods.

Motivated by #5335 and #5334.

cc @erictune

Ok, @thockin. Recommended a singleton RC + service. PTAL.

LGTM
On Wed, Mar 11, 2015 at 9:17 PM, Brian Grant<EMAIL_ADDRESS>wrote:

Ok, @thockin https://github.com/thockin. Recommended a singleton RC +
service. PTAL.
—
Reply to this email directly or view it on GitHub
https://github.com/GoogleCloudPlatform/kubernetes/pull/5353#issuecomment-78421456
.

LGTM
@brendanburns @alex-mohr please argue here before we merge if you still don't agree with this.

Great feedback. Thanks, @brendandburns. Comments addressed. PTAL.

I still disagree strongly with this design decision.
Obviously we can require users to jump through hoops like creating a controller of size 1 to work around ephemeral pods, but it's an IMO-unreasonable burden to place on users.    It violates the principle of least surprise for users who create a pod with RestartPolicy: Always and find it's deleted or pending forever due to being borked.  How many user complaints of "I created a pod but now it's gone" do we have to reply with "I totally understand how you might have thought you might be able to do that, but You're Doing It Wrong" before we put the user first?
[And yes, I acknowledge there may be costs from pods that are capable of being restarted, but IMO the user experience benefits of that outweigh those costs.]

@alex-mohr As for POLS, I think it all depends on how we explain the system, hence this doc update.
Kubernetes is an extensible, pluggable, building-block OSS platform and toolkit, which is intended to enable building schedulers, controllers, higher-level PaaS functionality, multi-cluster layers, etc., eventually without necessitating modification of core Kubernetes source. Therefore, its APIs aren't just (or even necessarily mainly) targeted at end users, but at tool and extension developers.
In another context, one might consider many of the Kubernetes APIs to be "internal", but we have no such thing: all APIs are universally visible and available, including the APIs used by the scheduler, the node controller, the replication-controller manager, Kubelet's API, etc. There's no glass to break -- in order to handle more complex use cases, one can just access the lower-level APIs in a fully transparent, composable manner.
I understand that you'd like "forever pods", and that might be reasonable to introduce someday. However, it would need to be built upon a controller and a primitive such as the current pod API, so it wouldn't be a core primitive (we plan to convert replication controller to a plugin, as well). It would also create significant challenges for deployment tools.
Eventually I foresee more configuration generators and/or higher-level API layers of the flavor of run-container, which generate the lower-level API objects, though expressed declaratively and expanded server-side, and with a path towards exploiting more of the features of the underlying primitives.
So, I think there are many things we can and should do to make the existing primitives easier to use directly, but it's not the long-term solution to ease of use for application devs and operators. Conflating the end-user UI with the developer SDK will result in nobody being happy.
It is very important to insulate the container runtime environment from the complexity of the management environment -- the vast majority of applications should be obvious to that, and should be able to stick to simple, familiar models. This is why, for example, we provide IP per pod (users can pick their own ports) and services with IPs, DNS, and load balancing. It's also why we've been fairly cautious about exposing Kubernetes API details to containers.
Finally: http://www.jwz.org/doc/worse-is-better.html
I choose another doc to add the above, or create a new one.

An example @alex-mohr: GCE provides "forever VMs". However, the fact that GCE was built on top of something analogous to "forever pods" was more hindrance than help.

I think this looks good to go now that you've incorporated Brendan's comments. Will leave open for a bit longer in case @alex-mohr has more to say.

LGTM

I'm merging this...  @alex-mohr I think this is precisely why we introduced the "run-container" command in kubectl.  We need to make sure we use that in all of our documentation...
--brendan


Is this repo still in use?

I believe we were migrating everything out of here. Did we finish?

Good question Jon, it has bee a while since a commit was merged here and most of the projects were already migrated to its own repo. Abuot the templates that sill here, I am not sure about webservers, but the others, I think, all of them are on their repo as well.


Add a separate application focus/in notification

As we now support multiple windows, we require separate notifications for application focus in and focus out and window focus in and focus out.

Should we rename WM in the constants to WINDOW?

@Calinou I think WM is ok, its just usual window manage events

Superseded by #39986.


Unable to Add TVDB List - Missing 1 required positional argument: ‘language’

I’m trying to add a collection from TVDB. I added the Arrowverse one and it worked great, but when I try to add the MCU one it gives me an error about a missing argument language. I’m thinking something isn’t being passed through properly, but I’m not sure.
Configs are the same as #90 except that I’ve enabled the cache now.
Collection
                                      ######################################################
                                      #               TV Show Collections                  #
                                      ######################################################
collections:
###########################
#     Misc Collections    #
###########################

  Arrowverse:
    tvdb_list: https://www.thetvdb.com/lists/arrowverse
  Marvel Cinematic Universe:
    tvdb_list: https://www.thetvdb.com/lists/marvel-cinematic-universe

Log

|====================================================================================================|

|                                Marvel Cinematic Universe Collection                                |

|====================================================================================================|

|                                                                                |

| Scanning Marvel Cinematic Universe Collection                                                      |

|                                                                                |

| Method: tvdb_list                                                                                |

| Value: https://www.thetvdb.com/lists/marvel-cinematic-universe                                     |

|                                                                                |

| Sync Mode: sync                                                                                |

|                                                                                |

| Method: tvdb_list                                                                                |

| Values: ['https://www.thetvdb.com/lists/marvel-cinematic-universe']                                |

|                                                                                |

| Value: https://www.thetvdb.com/lists/marvel-cinematic-universe                                     |

| Processing TVDb List: https://www.thetvdb.com/lists/marvel-cinematic-universe                      |

| Traceback (most recent call last):                                                                 |

|   File "/modules/config.py", line 461, in update_libraries                                         |

|     builder.run_methods(collection_obj, collection_name, rating_key_map, movie_map, show_map)      |

|   File "/modules/builder.py", line 653, in run_methods                                             |

|     elif "tvdb" in method:                              items_found += check_map(self.config.TVDb.get_items(method, value, self.library.Plex.language)) |

|   File "/modules/tvdb.py", line 132, in get_items                                                  |

|     tmdb_ids, tvdb_ids = self.get_tvdb_ids_from_url(data, language)                                |

|   File "/modules/tvdb.py", line 99, in get_tvdb_ids_from_url                                       |

|     tmdb_id = self.get_movie(language, tvdb_url=f"{self.site_url}{item_url}").tmdb_id              |

|   File "/modules/tvdb.py", line 82, in get_movie                                                   |

|     return TVDbObj(tvdb_url, language, True, self)                                                 |

|   File "/modules/tvdb.py", line 48, in __init__                                                    |

|     try:                                                tmdb_id, _ = TVDb.config.convert_from_imdb(util.get_id_from_imdb_url(results[0])) |

| TypeError: convert_from_imdb() missing 1 required positional argument: 'language'                  |

|                                                                                |

| Unknown Error: convert_from_imdb() missing 1 required positional argument: 'language'              |

|                                                                                |

|====================================================================================================|

fix should be in devlop

It works! Thanks again! I was having some trouble with another collection type earlier that I gave up on for now, so you’ll probably see one more issue from me at some point tonight. I really appreciate the incredibly fast updates!

yea no problem keep them coming im happy to fix things whenever I can!


No known class method for selector 'sharedManager'

When run PRAR-Example, I get this error in ARView.m  line 87, [PRARManager sharedManager].
What to do..

I am also having the same issue when running PRAR-Example. What is work around for it?

Me too! Some ideas?

I just removed "PRAugmentedReality" from example project then install the pod. Then it can be run. but the issue is "http://prar.prometsource.com" the server is down and can not connect.

Any update on this issue?

Apparently the singleton has been removed with commit  3206bcad53460283762852c827f2fbcab9cdc526. You need to setup your own manager instance and store it in a @property. See the public interface.


Does not run as a desktop application

IDE build number: current git master
Java version: 1.8.0_232
OS name and version: Linux Manjaro 18.1.5

After
mvn install mvn consulo:run -pl:consulo-sandbox-desktop
it prints:
Unable to parse command line options: Unrecognized option: -pl:consulo-sandbox-desktop

Hi. Try. I forgot update it after plugin change (and also update to last mvn spec)
mvn consulo:run-desktop -pl consulo:consulo-sandbox-desktop


[Bugfix] [connector-jdbc] Fix when type is int and null value will always get 0 instead of null

Purpose of this pull request

Check list

[ ] Code changed are covered with tests, or it does not need tests for reason:
[ ] If any new Jar binary package adding in your PR, please add License Notice according
New License Guide
[ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
[ ] If you are contributing the connector code, please check that the following files are updated:

Update change log that in connector document. For more details you can refer to connector-v2
Update plugin-mapping.properties and add new connector information in it
Update the pom file of seatunnel-dist

[ ] Update the release-note.

We need to cover scenarios involving null values in the e2e test, so as to ensure that the code won't encounter this issue again and to confirm that the current modification is effective.

The class that has overridden the toInternal method also needs to be modified, for example, PostgresJdbcRowConverter#toInternal.

The class that has overridden the toInternal method also needs to be modified, for example, PostgresJdbcRowConverter#toInternal.

Okk

This PR was blocked by e2e because mysql e2e was losing data.
https://github.com/apache/seatunnel/issues/4732


Using ParseDict when fails if python tuple is present

What version of gRPC and what language are you using?
grpcio=1.59.3
grpcio-tools=1.56.2
protobuf = 4.25.3
or
grpcio=1.64.0
grpcio-tools=1.64.0
protobuf = 5.27.1
What operating system (Linux, Windows,...) and version?
Mac OS 14.5 arm64 M1 Max 32GB RAM
What runtime / compiler are you using (e.g. python version or version of gcc)
Python version 3.8.14.
What did you do?
I am trying to use ParseDict to parse simple python dictionary
original = {
     "tracker": {
        "latest_message": {
              "coords": [(0,3)]
        }
    }
}

with following .proto definition:
syntax = "proto3";

package my_example;
import "google/protobuf/struct.proto";
import "google/protobuf/empty.proto";

message Tracker {
  google.protobuf.Struct latest_message = 1;
}

message ActionRequest {
  Tracker tracker = 1;
}

service ActionServerWebhook {
  rpc Handle(ActionRequest) returns (google.protobuf.Empty) {}
}

Code to generate data:
poetry run python -m grpc_tools.protoc \
	-Igrpc_test_app/grpc_py=./proto \
	--python_out=. \
	--grpc_python_out=. \
	--pyi_out=. \
	proto/webhook.proto

This simple parsing test fails:
from google.protobuf.json_format import ParseDict

from grpc_test_app.grpc_py import webhook_pb2
import pytest

def test_my_example():
    original = {
        "tracker": {
            "latest_message": {
                "coords": [(0, 3)],
            }
        }
    }
    action_request = webhook_pb2.ActionRequest()
    result = ParseDict(js_dict=original, message=action_request, ignore_unknown_fields=True)

What did you expect to see?
I expect for the parse to pass and for coords to be treated as list of lists [[]].
What did you see instead?
I saw an error:
 google.protobuf.json_format.ParseError: Failed to parse latest_message field: Value (0, 3) has unexpected type <class 'tuple'> at ActionRequest.tracker.latest_message.coords[0].

Instead I used:
import json

from google.protobuf.json_format import Parse

from grpc_test_app.grpc_py import webhook_pb2
import pytest

def test_my_example():
    original = {
        "tracker": {
            "latest_message": {
                "coords": [(0, 3)],
            }
        }
    }
    action_request = webhook_pb2.ActionRequest()
    json_result = json.dumps(original)
    result = Parse(text=json_result, message=action_request, ignore_unknown_fields=True)

Note that when JSON parses original it will convert tuple to list. Resulting json will look like this:
{"tracker": {"latest_message": {"text_tokens": [[0, 3]]}}}

Note:
It works if I convert python dictionary to JSON and then use ParseJson. Converting to JSON actually converts tuple to  list.
See TROUBLESHOOTING.md for how to diagnose problems better.
Anything else we should know about your project / environment?

Hi @radovanZRasa, ParseDict takes the argument js_dict which is already expected to be a "Dict representation of a JSON message", i.e a valid JSON object with JSON supported types only.
It doesn't explicitly handle converting Python dictionaries with other types to valid JSON objects, and hence raises a ParseError in that case.

@sreenithi
This poses a trouble since that is not strongly implied by the API.
I took a few moments to looks at the code and believe that Parser which takes python data and goes recursively through it, could be improved to handle Tuple type. Parser already has code block which is handling Python maps etc. so it looks like it could be improved to add support for Tuple as well.

Hi @radovanZRasa, while gRPC uses protobuf, making changes to the protobuf specific methods is handled by the protobuf team and not the gRPC team. So please file this issue with the protobuf repo instead, and they may be in a better position to advise if this change is feasible or not.


Update continuous-delivery-faqs.md

Jateen -- CDS-77431 FAQ on concatenated expressions.
Harness Developer Pull Request
Thanks for helping us make the Developer Hub better. The PR will be looked at
by the maintainers.
What Type of PR is This?

[x] Issue
[ ] Feature
[ ] Maintenance/Chore

If tied to an Issue, list the Issue(s) here:

Issue(s)

House Keeping
Some items to keep track of. Screen shots of changes are optional but would help the maintainers review quicker.

[ ] Tested Locally
[ ] Optional Screen Shoot.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

@jt1000 the FAQs in the docs will be removed soon. FAQs are now being added to
Please update this PR to move your FAQ to the KB or close this PR and create a new PR to update the KB.


Retry in Jenkins does not work

It seems that the retry builds deterministically fail to checkout the git repo: https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/1541/BuildGraph/

It's just the DDoS on GitHub. It'll come back at some point.


obfs4: add meta fields

Description of changes
This commit adds these meta fields:

license
changelog
downloadPage
longDescription from openwrt https://openwrt.org/packages/pkgdata/obfs4proxy

It also improves the meta.description field to be a bit more descriptive.

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

CC @thoughtpolice


Questions about query feature visualization in the paper

Great work and thank you for publishing the code!
I have a question about figure 4 in the paper. I am curious that how you obtain query feature visualization result. Is that by using a well-known data visualization method or your own method? I want to create a visualization result like this, thank you very much!

Hi @Qrteng, I perform the PCA on the query features and select 3 principal components as R, G, and B channels to form the visualization. The codes are:
from sklearn.decomposition import PCA
from PIL import Image

def visualize_and_save_features_pca(feats_map, t, save_dir, layer_idx):
    """
    feats_map: [B, N, D]
    """
    B = len(feats_map)
    feats_map = feats_map.flatten(0, -2)
    feats_map = feats_map.cpu().numpy()
    pca = PCA(n_components=3)
    pca.fit(feats_map)
    feature_maps_pca = pca.transform(feats_map)  # N X 3
    feature_maps_pca = feature_maps_pca.reshape(B, -1, 3)  # B x (H * W) x 3
    for i, experiment in enumerate(feature_maps_pca):
        pca_img = feature_maps_pca[i]  # (H * W) x 3
        h = w = int(np.sqrt(pca_img.shape[0]))
        pca_img = pca_img.reshape(h, w, 3)
        pca_img_min = pca_img.min(axis=(0, 1))
        pca_img_max = pca_img.max(axis=(0, 1))
        pca_img = (pca_img - pca_img_min) / (pca_img_max - pca_img_min)
        pca_img = Image.fromarray((pca_img * 255).astype(np.uint8))
        pca_img.save(os.path.join(save_dir, f"{i}_time_{t}_layer_{layer_idx}.png"))

Hope this can help you.

Thanks a lot!


Add release notes for 2.0.0

Ah that reminds me to update docs/stability-tiers.md as well with the new platforms.


Volunteeer bio & photo for Katherine

You can attach a photo here, and comment with bio, or open a PR.

@ktrammell95

@ktrammell95 Bump!

Weird I never got notice of this. I can work on it today

Done


Event handler implementation.

Framework for adding per-object event handlers. This will be an SQF/callExtension bridge most likely (at least how I am envisioning it) where Intercept will implement a special C++ side call to addEventhandler that will add a specific SQF side callback as well as listing the object internally in the client adding the event. That call back will then be raised when the specific event is handled, assigning _this to a global variable (or someplace we can find it) and notifying all attached Intercept clients of this event and the object.
This is just what I have in my head right now, if there is a better way I am totally for it because this sounds kind of convoluted.

Add listeners for all events in sqf
listeners will assign _this to a global var in missionnamespace
upon event raised, listeners will call an extension with the eventname.
extension will get the assigned data in the global var, and raise the event within C++

Might be risky - because we are using global variables for transporting the data. This is something we would have to test.
Unless we can hook into the RV event system from within C++, the only other option I see if using serialization to transfer the data, but that brings a whole train lot of other problems and perf issues.
Perhaps an alternative might be using some kind of queue (sqf array), and monitor that internally?

I'd prefer to avoid SQF interaction for event hooking. We can hook into the event system Glowbal, and any ghetto SQF workarounds really need to be avoided.
These should be intercepted instead, as the function calls are the same and we already know how to do function hooking and deceleration.
We should hook and catch the function, handle, then pass on to the continuation of the event chain in regular SQF.

Anything that requires more memory patching is out, as it would not be BE compliant. BE does memory image checking to see if there are hooks and flags if so.
If BE was not an issue then I'd say yes, but ultimately we do need to support BE for multiple reasons.

could use #109 for the callback. That could also directly pass _this in the function call.
target addEventHandler ["killed", "_this intercept_event"];

could also format the command string like [_this, eventUUID] intercept_event which will make it easier to decide who should receive the event

#109 is implemented now.. How about
target addEventHandler ["killed", "<UUID> interceptEvent _this"];

Additionally to the addEventhandler CODE wrapper we could add
addEventhandler that takes std::function<void(EH args)>.
People can pass their lambda or whatevers in there and in the backend intercept assigns a ID to the eventhandler and calls addEH like in my last comment.

Okey easy to implement.
On Pluginside we have
holder addEventhandler(object obj_, std::string_view ehname_, std::function<void(game_value)> func_)
(Notice the naming difference from sqf::add_event_handler. In the end it will also be called add_event_handler but I use the camelCase variant here to make it clear what is meant)
This will allow people to pass in lambdas and other crazy stuff.
The holder acts like the RSQF registered_sqf_function When it's refcount goes to 0 the eventhandler will be removed. Removing the need for Plugins to call removeEventhandler and also makes sure every eventhandler is removed when a Plugin unloads and thus preventing any possible user error in that realm.
Plugin side:
In addEventhandler we will generate a Unique ID for the eventhandler and then do a
sqf::add_event_handler(object, ehname_, "[module,UID] interceptEvent _this;
where UID is said Unique ID and module is the hash of the module name. Just because numbers(hash) are faster to handle.
And we will also store the UID connected with the function in a std::map<uint32_t,std::function<...>>
Core side:
interceptEvent will then associate that hash to a module and call it's static function
void event_trigger(uint32_t uid, game_value arguments)
This function will not be accessible to the client and will just be a hidden function just like our assign_functions function.
Plugin side:
That function will take the uid and map it to the function that we stored previously and then just call the function with the arguments.
This can also be extended to every other eventhandler (Not only events of objects) and thus we might also want to have a return value for some eventhandlers.
I think a good solution would be to make the addEventHandler function be a template. And define traits for each possible eventhandler. In these traits we can define the eventHandler name, whether it can return anything, and even how many arguments and what argument types it has.
We would have a enum of eventhandlers and the client would call
addEventHandler<object_fired>(...)
Depending on the template argument addEventHandler will take different arguments.
In this case it would take (https://community.bistudio.com/wiki/Arma_3:_Event_Handlers#Fired)
(object obj_, std::function<void(object,r_string,r_string,r_string,r_string,object,object)>)
or another example addEventhandler<object_handle_rating>(...)
(https://community.bistudio.com/wiki/Arma_3:_Event_Handlers#HandleRating)
which would take
(object obj_, std::function<int(object,int)>)
Assuming rating will only ever be rounded to .0. Otherwise it would be float instead of int.
This could potentially also return std::optional to really conform with the wiki statement in that it CAN return a Number but doesn't have to.
I'm not sure if we can have addEventhandler be a template function. We probably have to go for a class template with operator()
Which we can then easilly pull from the traits by just using operator() = Traits::operator()
I'm not quite sure how we would go about mapping the std::function to the UID then as we have many different types of std::function. Having one map per eventhandler type (Can be stored as static inline variable in the traits. Though we don't have static inline member variables in MSVC yet.) is a possibility but I don't really like cluddering memory with that.
We can also just store the std::function as a pair of <eventhandler type, std::shared_ptr>
And then just switch on the eventhandler type and convert the std::function pointer to the correct type and then call it. Which will be much nicer.

First part of implementation done.
It looks like this for the client
void myOnDraw() {
    sqf::system_chat("onDraw");
}

void __cdecl intercept::post_init() {
    static auto drawEH = client::addMissionEventHandler<client::eventhandlers_mission::Draw3D>(myOnDraw);
}

Or
void myOnDraw() {
    sqf::system_chat("onDraw");
}

void __cdecl intercept::post_init() {
    static auto drawEH = client::addMissionEventHandler<client::eventhandlers_mission::Draw3D>(
        [](){ sqf::system_chat("onDraw"); }
    );
}

Or even Class Member functions.
you need to store the return Value because once the last reference to that get's destructed the Eventhandler will automatically be removed.
For now I'm using pair<uint32,float> as UID for the handlers. The uin32 is randomly generated. and the float is the handle returned by addMissionEventHandler so we have it handy when we want to remove it again.
All handlers are stored in a unordered_map using the UID as index.
there will be one function map for each eventhandler type (generic(addEventHandler), mission (addMissionEventHandler), display (addDisplayEventHandler), ctrl ...)

Implementation has just moved to develop branch.
Examples:
static auto drawEH = client::addMissionEventHandler<client::eventhandlers_mission::Draw3D>(myOnDraw);
    static auto firedEH = client::addEventHandler<client::eventhandlers_object::Fired>(sqf::player(),[](object unit, r_string weapon, r_string muzzle, r_string mode, r_string ammo, r_string magazine, object projectile, object gunner) {
        sqf::system_chat(sqf::format({ "%1 fired %2 with %3 resulting in %4",unit,weapon,ammo,projectile }));
    });

static because return value needs to stay alive. As it going out of scope deletes the eventhandler.
All Mission/Object eventhandlers implemented.
Some ctrl eventhandlers implemented.
Missing are dialog,object(curator), some ctrl handlers.
Can be implemented later on depending on need.

Implementation is already on master branch. Besides addMPEventhandler which is included in #169
Also added a easy way to bind a lambda function to a SQF call.
generate_custom_callback() uses the same code as the eventhandlers but returns the SQF code that can be used to call the Function.


Readme content of Azure Key Vault Certificates is unclear and inconsistencey

1
Section Link

Comments: first certificate  -> certificates, second certificates  -> certificate, thrid Certificate  -> certificate
2
Section Link

Comments: Correct it as certificate
3
Section Link

Comments: Correct it as certificate
4
Section Link

Comments: Content description method and code method do not match. Correct it as GetCertificate, GetCertificateVersion

Comments: first certificate -> certificates, second certificates -> certificates, thrid Certificate -> certificate
"second" is okay as certificate
Please PR.

Created a new PR #11268 to address this issue.


[google-cloud-cpp] update to latest release (v2.4.0)

Updates google-cloud-cpp to the latest release (v2.4.0).
Add the new features included in this release.

What does your PR fix?

N/A

Which triplets are supported/not supported? Have you updated the CI baseline?

No changes.

Does your PR follow the maintainer guide?

Yes.

Yes

Tested each one of the new features on x64-linux using:

vcpkg install google-cloud-cpp[core,batch]
vcpkg install google-cloud-cpp[core,certificatemanager]
vcpkg install google-cloud-cpp[core,datastream]
vcpkg install google-cloud-cpp[core,deploy]

Also tested with vcpkg install google-cloud-cpp[*].

Thanks as always!


Add PluginGroupBuilder::replace helper method

What problem does this solve or what need does it fill?
Bevy is meant to be modular, which means adding, disabling, and swapping out plugins. However, some ergonomics are missing for swapping when using plugin groups.
What solution would you like?
DefaultPlugins
    .build()
    .replace::<AssetPlugin>(OtherAssetPlugin { ... })
    .finish()

What alternative(s) have you considered?
DefaultPlugins
    .build()
    .disable::<AssetPlugin>()
    .add_after::<AssetPlugin>(OtherAssetPlugin { ... })
    .finish()

Note that this is useful when you want to configure AssetPlugin in a subplugin.

Oh. I just realized that .add_after takes two generics, so you have to write it out as .add_after::<AssetPlugin, _>(OtherAssetPlugin { ... }), but it doesn't have to be this way. If add_after used one generic and one impl Plugin, you could omit the _ generic.
I should probably make this a separate issue.

A caveat I ran into: If you do DefaultPlugins.replace::<FooPlugin>(MyFooPLugin), it will panic if FooPlugin does not exist in DefaultPlugins because you disabled its feature. And if you're replacing a plugin that can be disabled via a feature, odds are you're doing that.
Not necessarily a reason not to implement replace, as it's still useful when you can't compile the plugin out of the group.


[$500] [HOLD #37309][Simplified Collect][Tags] Create TagSettingsPage

Implement this section of the Simplified Collect: Tags design doc
cc @waterim
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01ef8d6d5d785755ce
Upwork Job ID:<PHONE_NUMBER>268445696
Last Price Increase: 2024-02-27

Hello, Im Artem from Callstack and would like to take this one

@luacmartins was the External meant to be removed for this one?

yea, @waterim is working on this

Still on hold for the main page

Still on hold

The main page PR was just merged, this one is next in line. Removing hold

We'll start working on this next

Created draft!

PAYMENT SUMMARY FOR MAR 26
Fix: @waterim - does not require payment
PR Review: @hoangzinh [$500, if no regressions] Offer
Please propose a regression test

We'll add test steps once the feature is fully implemented. No need to do that now.

@slafortune will be handling payment for me while I'm ooo
PAYMENT SUMMARY FOR MAR 26
Fix: @waterim - does not require payment
PR Review: @hoangzinh [$500, if no regressions] Offer

Paid ✅


EP271 - 2022 Erors and Omissions

SPEC-2573 and SPEC-2578 failed. Please put SPEC-identifiers into the summary when committing (not the description) so that they show up in the list of commits pertaining to the pull requests.

SPEC-2578 incorrect, name of code set is PartySubIDTypeCodeSet, not PartySubIDSourceCodeSet.


free speedup by utilizing caches better

Instead of always reading from top-left, read from bottom right to better utilize caches.
Before:
step 20: train loss 4.296932 (took 28.770662 ms)
step 21: train loss 4.238368 (took 28.684013 ms)
step 22: train loss 4.235001 (took 28.662183 ms)
step 23: train loss 4.037789 (took 28.673183 ms)
step 24: train loss 4.309966 (took 28.679693 ms)
step 25: train loss 4.451100 (took 28.686702 ms)
step 26: train loss 4.406357 (took 28.670413 ms)
step 27: train loss 4.334877 (took 29.079828 ms)
step 28: train loss 4.368477 (took 28.677603 ms)
step 29: train loss 4.287300 (took 28.685273 ms)
val loss 4.517179
step 30: train loss 4.155085 (took 28.939040 ms)
step 31: train loss 4.116601 (took 28.671473 ms)
step 32: train loss 4.182609 (took 28.681243 ms)
step 33: train loss 4.389328 (took 28.680083 ms)
step 34: train loss 4.254278 (took 28.668353 ms)
step 35: train loss 4.252576 (took 28.684273 ms)
step 36: train loss 4.323340 (took 28.705613 ms)
step 37: train loss 4.266943 (took 28.685933 ms)
step 38: train loss 4.267965 (took 28.670763 ms)
step 39: train loss 4.062835 (took 28.664953 ms)

After:
step 20: train loss 4.296932 (took 27.949317 ms)
step 21: train loss 4.238368 (took 27.939526 ms)
step 22: train loss 4.235001 (took 27.928437 ms)
step 23: train loss 4.037789 (took 27.939787 ms)
step 24: train loss 4.309966 (took 27.933507 ms)
step 25: train loss 4.451100 (took 27.924917 ms)
step 26: train loss 4.406357 (took 27.935437 ms)
step 27: train loss 4.334877 (took 27.931937 ms)
step 28: train loss 4.368477 (took 27.925177 ms)
step 29: train loss 4.287300 (took 27.919606 ms)
val loss 4.517179
step 30: train loss 4.155085 (took 27.950256 ms)
step 31: train loss 4.116601 (took 27.927917 ms)
step 32: train loss 4.182609 (took 27.930627 ms)
step 33: train loss 4.389328 (took 27.917677 ms)
step 34: train loss 4.254278 (took 27.915977 ms)
step 35: train loss 4.252576 (took 27.898277 ms)
step 36: train loss 4.323340 (took 27.935167 ms)
step 37: train loss 4.266943 (took 27.916987 ms)
step 38: train loss 4.267965 (took 27.943397 ms)
step 39: train loss 4.062835 (took 27.937627 ms)

I observed consistent speedup on three different 4090s.
The principle is simple: when you execute a kernel and the data for its last batch of operations is in the last column, the next kernel, B, starts operating directly from the last column rather than the first column, resulting in a higher cache hit rate.

But which kernel is this re-utilizing from? The previous kernel is a cuBLAS matmul.

Yes, both before and after are cublas matmul kernels, and it's not possible to know the details inside the kernel. This speedup is more of a result obtained through experimentation. Note that after the softmax backward operation completes, the cache retains the part of the matrix close to the upper left corner, which benefits the matmul operation that immediately follows.
I call it a 'free speedup' because there is no reason for it to result in a performance loss.

merged in 315af5f, slightly modified with comments ty. it does help about 1ms/iter on average from me, from 193ms -> 192ms. might be more on other GPUs


enable connection and credential exchange with managed wallets

In the meantime I was able to successfully test the external issuer flow locally, I now also understood that the did-communication service endpoint in the DID document is set by ACA-Py in the "assignDidToPublic" step. It looks like the URL is the same for all tenants/subwallets, is this understanding correct? It would be good to add some hint or link to how the ACA-Py handling of tenant-aware endpoint and messages works.


Remove mapped_specialist_topic_content_id from document collections

⚠ This repo is Continuously Deployed: make sure you follow the guidance ⚠
This application is owned by the publishing platform team. Please let us know in #govuk-publishing-platform when you raise any PRs.
Follow these steps if you are doing a Rails upgrade.
Warning
The following PR in the whitehall repository must be merged first.
What
As part of work to retire specialist topics, we temporarily stored a mapping between the archived specialist topic and its document collection conversion. We should remove this once we’re done.
Why
To keep the system clean and avoid unnecessary data.
Trello card

This one looks good too. Again it would be great to make the commit messages distinct. (I know one is just generated), I usually just use Run rake build_schemas for the second commit so people know they can not pay it too much attention.

They are distinct, because of the second line, which is not visible by default here (you'd need to click on ...), but it is visible in the commit list.

yep yep, I see the rest of the commit message. it would be nice to have it in the title of the commit I think. Just thinking about scrolling down the commits in the github GUI where the extended commit isn't visible by default.

Thanks @unoduetre it's great to see this almost gone!
You can reference that the work reverts https://github.com/alphagov/publishing-api/pull/2385
And whilst it seems like a nitpick, I do agree with Becca's comment about simple pscannable commit titles. You can see the titles for the original implementation as a guide.


KPI on homepage links to 404

Reproduce:

Go to e.g. https://dao-dev.hypha.earth/#/testdao/login
Click "continue as guest"
Klick on "3 new Proposals" on Homepage (KPI)

Experienced Behaviour:
I should go to /proposals and see 3 proposals
Expected behaviour:
I get to an error page 404 https://dao-dev.hypha.earth/#/not-found
https://dao-dev.hypha.earth/#/not-found

@leonieherma1 I can not replicate this issue in  https://dao-dev.hypha.earth/#/testdao/login, can you try again please?

@jmgayosso the "new proposal" ist for the last 7 days right?

@jmgayosso the "new proposal" ist for the last 7 days right?

Its correct


FMod Extension: [iOS] Terrible problems streaming if you select Net Stream

Which Extension are you reporting this issue for?
FMOD
Description
It is notable that building this demo project for IOS does function, but has terrible problems streaming if you select Net Stream
(Windows has no such issue)
Split off from https://github.com/YoYoGames/GameMaker-Bugs/issues/8391
Expected Change
The demo should function the same on all platforms
Steps To Reproduce

Start GameMaker and import/open the FMOD demo project
Run it for iOS
Use the net stream test
See/hear the issue

How reliably can you recreate this issue using your steps above?
Always
Which version of GameMaker are you reporting this issue for?
2024.8.1 (Monthly)
Which platform(s) are you seeing the problem on?
iOS
Sample Package Attached?

[ ] I have attached my bug package

Sample Project Added?

[ ] I have included a small sample project

Issue will be closed and 2 feature requests will be created, please refer to: https://github.com/YoYoGames/GMEXT-FMOD/issues/15


fix:Fix version cleaning for VFSForGit windows (#1281).

VFSForGit has the version '2.43.0.vfs.0.0', which has raised issue #1281.
The proposed fix includes a rewritten regex and an added assert.

@huandzh Thanks for the PR, the change looks good.
So forks are broken right now and we fixed it, but we fixed it in the develop-1.20 branch. Think you could rebase off that and change the base branch in this PR?

You're welcome. I'm glad you like the change. The commit has been rebased as suggested.

Thanks! Will get out in a few days.


Allow non-standard http status codes to be used

Koa throws when a status code not defined in the statuses package is used in response:
https://github.com/koajs/koa/blob/78832ff6c63fdd93ad9a49f31ba2edd8cbe8adee/lib/response.js#L84
However, the HTTP RFC does not prevent custom status codes to be used:
http://greenbytes.de/tech/webdav/draft-ietf-httpbis-p2-semantics-25.html#rfc.section.6.p.2
I can understand why status code validation might be useful for people just starting with http protocols, but for people who actually need to use custom codes, this is very limiting.
Proposal
There are several options that the Koa team could choose to remediate the problem:

Do not throw an error and just emit a warning
Keep throwing but add a configuration flag to disable the check (ie. koa.validateStatus = false)
Allow adding custom http status codes to Koa so that it accepts them (ie. koa.AddStatus(440, 'Invalid Chicken'))

I personally like the second and third approach. Currently the third approach is possible, albeit in a hacky way:
import statuses from 'statuses'

// Add a hypothetical "invalid chicken" response code
statuses[440] = 'Invalid chicken'
statuses.codes.push(440)
statuses['Invalid chicken'] = 440

Last option, which I would prefer, is not to expose an API for handling statuses but rather to expose the validation, which can be overloaded/replaced as needed.

what about passing your own version of statuses? app.statuses = statuses.
this will need some way of subclassing statuses

how about removing the dependency, and people can add it as a middleware if needed ( in good Koa spirit )

@jonathanong if your solution is the approach you'd favour, it would (to my understanding) require:

expose statuses through koa/Application
to avoid semver major, expose populateStatusesMap in jshttp/statuses

For which end result for Koa developer would become something pseudo alike:
const statuses = require('statuses')

statuses.mergeStatusesMap({
  440: 'invalid chicken'
})

app.statuses = statuses

Did I follow you correctly here?

@fl0w @jonathanong Is this still needed?

What about just validating that the status code is a number as per the HTTP spec?

The status-code element is a three-digit integer code giving the
result of the attempt to understand and satisfy the request.

Another use-case for this is Cloudflare using its own set of non-RFC status codes - https://en.wikipedia.org/wiki/List_of_HTTP_status_codes#Cloudflare

Can I tackle this by adding all the logic in Koa side?

No, that's gross :)
honestly, i would just add my custom status codes to statuses. yes, it's monkey patching, so i'd pin the statuses version in my deps

Hi,
As mentionned by @fl0w, here I'm currently developing an app which needs the usage of the non-standard code 449 introduced by Microsoft. Maybe we need to discuss about introducing non-standard codes


Unity Editor Update 2017.2.0f3 MRTP

Fixes #1114

There's also a link lower down in the readme, under Prerequisites, that just links to the beta page. That should probably be updated too.

I might just move some of the new stuff to the docs and make the main readme match master.

It's not hard to change the editor version. But really this is just easy for people to reference.
I'm 95% sure we need to be using the MRTP for HMD support and the actual release for HoloLens.

This is the official editor version for WMR


new_version  0.4.0 not show picker

maya file work with dwpicker 0.2.0  works fine. when i use dwpicker 0.4.0, open maya file,the picker not show.
script Editor show:
#   File "C:/Users/cz/Documents/maya/scripts\dwpicker\picker.py", line 230, in mouseMoveEvent
#     self.viewportmapper.to_units_coords(event.pos()),
#   File "C:/Users/cz/Documents/maya/scripts\dwpicker\geometry.py", line 44, in to_units_coords
#     self.to_units(pixels_point.x() + self.origin.x()),
#   File "C:/Users/cz/Documents/maya/scripts\dwpicker\geometry.py", line 35, in to_units
#     return pixels / self.zoom
# ZeroDivisionError: float division by zero

version 0.2.0 work fine

version 0.4.0 reopen maya file ,picker not show

Indeed, we made a conversion mistake only with python2
Release 0.4.1 got the fix.
Thanks for the report.


The 'get_multilayer' method cannot obtain the value obtained by the 'set_multilayer' method

Godot version
4.1.dev
System information
Window 10
Issue description
If the result is what you expect, why not block it when you set the value, the value is successfully set in the Map, but when you get it, it's not what you expect, and you make mistakes.

Steps to reproduce
N/A
Minimal reproduction project
N/A

Please provide an MRP to indicate what specific steps you are doing, or at minimum an actual description of what you are doing
The titles on the form are not optional, you have to fill them in

Please provide an MRP to indicate what specific steps you are doing, or at minimum an actual description of what you are doing, without that not only are we unable to tell what's wrong, we also can't tell if you're doing something wrong
The titles on the form are not optional, you have to fill them in

I have set up a custom "Multiplayer API" on scenario A, and also set up a custom "Multiplayer API" on its sub scenario B. However, sub scenario B cannot obtain its own "Multiplayer API", and only obtains scenario A's "Multiplayer API".  If I am not allowed to set up a "Multiplayer API" on sub scenario B, why not prevent it.  I hope to obtain my own "Multiplayer API" for sub scenes.

Please attach an MRP with your script and scene

small Godot project which reproduces the issue, with no unnecessary files included. Be sure to not include the .godot folder in the archive (but keep project.godot).
Required, unless the reproduction steps are trivial and don't require any project files to be followed. In this case, write "N/A" in the field.

Please attach an MRP with your script and scene

small Godot project which reproduces the issue, with no unnecessary files included. Be sure to not include the .godot folder in the archive (but keep project.godot).
Required, unless the reproduction steps are trivial and don't require any project files to be followed. In this case, write "N/A" in the field.

https://github.com/mao437303994/test_godot.git

I think I know what might be causing this, will take a look when I have time

Got a fix working, will open a PR soon

Got a fix working, PR is open

If the name of a node changes, the result obtained by "get_multilayer" is also incorrect because the map still stores the previous NodePath

It does? It worked right for me, which result?

My results, the correct and expected result:
NodePath: /root/Main
Before update: <SceneMultiplayer#-9223372010682317685>
Exclusive: <SceneMultiplayer#-9223372009692461929>
After update: <SceneMultiplayer#-9223372009692461929>

NodePath: /root/Main/Test
Before update: <SceneMultiplayer#-9223372009692461929>
Exclusive: <SceneMultiplayer#-9223372007947631418>
After update: <SceneMultiplayer#-9223372007947631418>

If the name of a node changes, the result obtained by "get_multilayer" is also incorrect because the map still stores the previous NodePath

Oh my bad, that's not covered here nor is it supported atm, not in the bounds of this PR, open a separate issue please

g.

"set_name" changes the name of node Test, and getting the result should not be correct

If the name of a node changes, the result obtained by "get_multilayer" is also incorrect because the map still stores the previous NodePath

Oh my bad, that's not covered here nor is it supported atm, not in the bounds of this PR, open a separate issue please

My SDK of Godot is still old and has bugs that make it difficult to demonstrate

Yes, and I understand you expect it to work this way, but it unfortunately does not, please open an issue for that specifically as it is not within the bounds of the report in this, you don't mention it, and this is about a specific thing

Update:
This is not a bug, see #77829 for explanation, but the PR now fixes the incorrect assignments that cause this confusion


One script to check everything

Codecov Report

Merging #66 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #66   +/-   ##
=======================================
  Coverage   53.69%   53.69%
=======================================
  Files           5        5
  Lines         149      149
=======================================
  Hits           80       80
  Misses         69       69

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96c932f...15385fd. Read the comment docs.

@tisnik Your image is available in the registry: docker pull quay.io/openshiftio/rhel-fabric8-analytics-f8a-api-gateway:SNAPSHOT-PR-66


Add a section for AtCoder DP Problems

🚀 Feature
A section for AtCoder DP Problems should be added. There are 26 problems from Educational DP contest. They would help in grasping concepts.
Have you read the Contributing Guidelines on Pull Requests?
Yes
Motivation
Good problems to have a hold on Dynamic Programming.
Pitch
(Please explain why this feature should be implemented and how it would be used.)

I would like to work on it.

I would like to do this for all problems in C.

We are logging the scores for the Contributor's Hack 2020. If you have one or more than one PR merged during the program, make sure to fill this form


ci: treat all non-protected branches as pull requests

Issue being fixed or feature implemented
This branch https://github.com/dashpay/dash/tree/feat/flatpak is 3 commits ahead so CI checks should use d494339b9f0587902fbf6358966c65bcfcb9febf as $CI_COMMIT_BEFORE_SHA. But that's not the case according to CI logs https://gitlab.com/dashpay/dash/-/jobs/8179463810#L38
PULL_REQUEST=false COMMIT_RANGE=4d1b648bad417ef9b1c5a96edfa04b0e382f096f..860f6ee48f61f0b670b21ef142d13ae02d3cc50a HOST_SRC_DIR=/builds/dashpay/dash CACHE_DIR=/builds/dashpay/dash/cache

The commit range is just 1 commit instead of 3 and this results in incomplete CI checks. This happens because only branches with special refs like pr-xxxx/author/dash/branch are considered as pull requests.
What was done?
Reverse the check - protected branches are the only non-PRs now, everything else is treated as PRs
How Has This Been Tested?
Breaking Changes
Checklist:

[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have added or updated relevant unit/integration/functional/e2e tests
[ ] I have made corresponding changes to the documentation
[ ] I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

ping @knst


Create a command line option no-configure-network

For #205
Makes it not configure the dns servers and domain
on the zerotier network in my.zerotier.com
That was easy.
Will try to add a test if I get motivated.

Thanks for working on this @laduke! I'll try to test this in my environment soon.
Could you also add some documentation about this option? Maybe something like this under "Configuration" in the main README:
- no_configure_network: (bool) Prevent zeronsd from changing the DNS Search Domain and Server Addresses in ZeroTier Central. Default is `false`. Typically only necessary in more complex setups with multiple DNS servers. Also, with this enabled, zeronsd can run with a token that has read-only access.

Sure. There should be some docs for it under zeronsd help start now.

I've tested this in our environment and it works. Tested both true and false. (Built using docker, then copied the binary to our production machine and replaced /usr/bin/zeronsd. There's probably a better way, but that worked.)
One little issue: I'm using a YAML config file and for some reason this option seems to be required in it? If I omit it, zeronsd exits with the message missing field `no_configure_network`. Btw, this is also true for wildcard and local_url.

There should be some docs for it under zeronsd help start now.

Any chance you could also add it to the README? This wouldn't be the first project that has the functionality I need, but it takes me a while to find because it's one of the few options not in the README 🙂

If I omit it, zeronsd exits with the message missing field no_configure_network. Btw, this is also true for wildcard and local_url.

That's... fun. Need to think about that.

I'd fixup the other issues in different PRs


Fix cluster naming in v1 code for v1alpha3

So that we can use RDS response in ldsv2

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: zackbutcher
Assign the PR to them by writing /assign @zackbutcher in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rshriram: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
106ee64e1ba34df1c1232137510fc319100ba54f
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
d07a194e45ea4ab1d897ccd0ce681f8d454cdb89
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
5eee54eefa0047dacc98f068b0786ac09ead9fd4
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
99b6090d6f56584992a43de52d1665aaeb9474e2
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
99b6090d6f56584992a43de52d1665aaeb9474e2
link
/test istio-unit-tests

prow/istio-presubmit.sh
99b6090d6f56584992a43de52d1665aaeb9474e2
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
99b6090d6f56584992a43de52d1665aaeb9474e2
link
/test istio-presubmit

prow/istio-unit-tests.sh
4eed3e75d7422a423012c5919dc1ce9437c60c8b
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests.sh
7fc28be254ad043741c0d0732b08f33ad8d056e7
link
/test e2e-bookInfo

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test e2e-bookInfo


Support Playlists

Checklist

[X] I made sure that the issue I am raising doesn't already exist

Use case / Problem
Currently it is only possible to play a single file.
Proposal / Solution
It would be great if we could add a playlist so that when one song ends, the next song automatically plays.
Example Code
No response
Affected platforms
Android, iOS, web, Windows, Linux, macOS, other
Platform details
No response
Audio Files/URLs/Sources
No response
Mockups
No response
Related issues / more information
No response
Working on PR
no way

I want to comment here:
playlist: you can implement playlists as you wish by playing multiple audios or songs in sequence. Doesn't make sense for this package to have any builtin playlist mechanism.
i believe the value is to have gapless playlist. Start loading next item just before reaching it.

I think a lof of people would like this feature.
"Doesn't make sense" is a harsh statement for an audio player package.

Playlists are not scope of this library. You can implement your own though :) https://github.com/bluefireteam/audioplayers/blob/main/feature_parity_table.md#other-out-of-scope-features

I'm trying to play audio files in a list. I'm basically incrementing an index in onPlayerComplete, but it gets triggered multiple times and as result multiple files get skipped.
This is basically what I'm doing
 _playerCompleteSubscription =  _audioPlayer1.onPlayerComplete.listen((event) {
print('Player complete');
index++;
};

I'm seeing 'Player complete' multiple times in the logs. Any idea how to do it correctly?


premailer error

Hi,
I start grunt in the console and I have an error with premailer:
[grunt-email-workflow master] grunt
Running "sass:dist" (sass) task
Running "assemble:pages" (assemble) task
Assembling dist/branded.html OK
Assembling dist/transaction.html OK

2 pages assembled.

Running "premailer:html" (premailer) task
/usr/local/Cellar/ruby/2.2.2/lib/ruby/2.2.0/rubygems/core_ext/kernel_require.rb:54:in require': cannot load such file -- premailer (LoadError) 	from /usr/local/Cellar/ruby/2.2.2/lib/ruby/2.2.0/rubygems/core_ext/kernel_require.rb:54:in require'
from /Users/xavi/sites/email/grunt-email-workflow/node_modules/grunt-premailer/lib/premailer.rb:3:in <main>' /usr/local/Cellar/ruby/2.2.2/lib/ruby/2.2.0/rubygems/core_ext/kernel_require.rb:54:in require': cannot load such file -- premailer (LoadError)
from /usr/local/Cellar/ruby/2.2.2/lib/ruby/2.2.0/rubygems/core_ext/kernel_require.rb:54:in require' 	from /Users/xavi/sites/email/grunt-email-workflow/node_modules/grunt-premailer/lib/premailer.rb:3:in '
Fatal error: /usr/local/Cellar/ruby/2.2.2/lib/ruby/2.2.0/rubygems/core_ext/kernel_require.rb:54:in require': cannot load such file -- premailer (LoadError) 	from /usr/local/Cellar/ruby/2.2.2/lib/ruby/2.2.0/rubygems/core_ext/kernel_require.rb:54:in require'
from /Users/xavi/sites/email/grunt-email-workflow/node_modules/grunt-premailer/lib/premailer.rb:3:in `'
[grunt-email-workflow master]
Thank you

EDIT:
I installed gem install premailer and it works.

In case anyone comes across this, hpricot is apparently not supported and I could not install the gem (see http://stackoverflow.com/questions/11605404/installing-hpricot). I did gem install nokogiri instead and it worked great.


v2.3.0-beta.4 - Unable to close a pop-up by clicking background.

For any feature request you can open a new discussion here:
https://github.com/Clooos/Bubble-Card/discussions/categories/feature-requests
For any question you can open a new discussion here:
https://github.com/Clooos/Bubble-Card/discussions/categories/q-a

click to open a pop-up.
click the top to close a pop-up. (if the current background is another card, it launches what's in the background directly)

Expected behavior

click to open a pop-up.
click background to close a pop-up, regardless if it's empty or not, it should just close the current pop-up

Informations (please complete the following information):

OS: iOS 18.1
Browser/App: App
Bubble Card version: v2.3.0-beta.4
Home Assistant version: 2024.10.4

Perhaps this solution will help you figure out the problem click

Hi! I guess that you haven't re-added the pop-up blurred backdrop, take a look a the latest changelog.
This is expected, for example on my setup I don't have the blurred backdrop because I have a menu at the top of my view, and when I open a pop-up, I like to be able to click on that menu.


Marriage Abroad ticket 15. Fact Check feedback on appointment booking

This addresses feedback from fact check that is related to appointment booking.
Summary:

use punctuation in appointment booking links consistently
use city names in appointment booking links consistently
refer users to concrete institutions for countries that have their own phrases. (For other countries a generic institution name with an interpolated country name is used.)
stylistic changes and typo fixes

Looks good to me.

cc97650


💡 [Feature]: Improve create new project walkthrough step

🎯 Aim of the feature
To the create new project step in the walkthrough let's add more guidance which will explain what type of components are possible to be created and what are their benefits

📷 Images (if possible) with expected result
No response
🤔 Additional remarks or comments
we should update this

@Adam-it, Can you assign it to me please?

@Adam-it, Can you assign it to me please?

All yours 👍

Merged ✅
a new pre-release with this change will come our shortly 👍. After sometime we will merge this to main branch to be part of next minor release 💪
You Rock 🤩

Pre-release will be out shortly 👏
This will be part of next minor release 👍
Thank you once again for your awesome contribution 😍
You Rock 🤩