tracing_tracy segfaults when main thread exits with other threads still running

When the main thread exits, if there are other threads that are still running, closing a span in one of those threads appears to cause a segfault.  (The threads are stopped when the process exits, but it seems that they keep running while the main thread is exiting).
This example always causes a segfault on my machine (with tracy-client 0.12.6)
fn main() {
    std::thread::spawn(move || {
        loop {
            let span = tracy_client::span!("Temp");
            drop(span);
        }
    });
    std::thread::sleep(std::time::Duration::from_millis(50));
}

Here's a backtrace from the core dump:
#0  memcpy (__len=1, __src=<synthetic pointer>, __dest=0x7f880042adc0) at /usr/include/x86_64-linux-gnu/bits/string_fortified.h:29
#1  tracy::MemWrite<tracy::QueueType> (val=tracy::QueueType::Callstack, ptr=0x7f880042adc0) at tracy/client/../common/TracyAlign.hpp:22
#2  tracy::Profiler::SendCallstack (this=<optimized out>, depth=depth@entry=60, skipBefore=skipBefore@entry=0x55c8703a0cf3 "__kernel_rt_sigreturn")
    at tracy/client/TracyProfiler.cpp:3058
#3  0x000055c870365499 in tracy::CrashHandler (signal=11, info=0x7f8802edb170) at tracy/client/TracyProfiler.cpp:900
#4  <signal handler called>
#5  0x000055c870366701 in memcpy (__len=<optimized out>, __src=<optimized out>, __dest=<optimized out>) at /usr/include/x86_64-linux-gnu/bits/string_fortified.h:29
#6  tracy::MemWrite<unsigned long> (val=<optimized out>, ptr=<optimized out>) at tracy/client/../common/TracyAlign.hpp:22
#7  tracy::Profiler::SendCallstack (depth=<optimized out>) at tracy/client/TracyProfiler.hpp:539
#8  ___tracy_emit_zone_begin_alloc_callstack (srcloc=140222099853920, depth=<optimized out>, active=1) at tracy/client/TracyProfiler.cpp:3483
#9  0x000055c8703456fb in tracy_client::Span::new (name=..., function=..., file=..., line=5, callstack_depth=62)
    at cargo/registry/src/github.com-1ecc6299db9ec823/tracy-client-0.12.6/src/lib.rs:92
#10 0x000055c870344f80 in repro::main::{closure#0} () at client/src/bin/repro.rs:5
#11 0x000055c870344f06 in std::sys_common::backtrace::__rust_begin_short_backtrace<repro::main::{closure#0}, ()> (f=...)
    at /rustc/59eed8a2aac0230a8b53e89d4e99d55912ba6b35/library/std/src/sys_common/backtrace.rs:125
#12 0x000055c8703452bb in std::thread::{impl#0}::spawn_unchecked::{closure#0}::{closure#0}<repro::main::{closure#0}, ()> ()
    at /rustc/59eed8a2aac0230a8b53e89d4e99d55912ba6b35/library/std/src/thread/mod.rs:481
#13 core::panic::unwind_safe::{impl#23}::call_once<(), std::thread::{impl#0}::spawn_unchecked::{closure#0}::{closure#0}> (self=..., _args=<optimized out>)
    at /rustc/59eed8a2aac0230a8b53e89d4e99d55912ba6b35/library/core/src/panic/unwind_safe.rs:271
#14 std::panicking::try::do_call<core::panic::unwind_safe::AssertUnwindSafe<std::thread::{impl#0}::spawn_unchecked::{closure#0}::{closure#0}>, ()> (data=<optimized out>)
    at /rustc/59eed8a2aac0230a8b53e89d4e99d55912ba6b35/library/std/src/panicking.rs:403
#15 std::panicking::try<(), core::panic::unwind_safe::AssertUnwindSafe<std::thread::{impl#0}::spawn_unchecked::{closure#0}::{closure#0}>> (f=...)
    at /rustc/59eed8a2aac0230a8b53e89d4e99d55912ba6b35/library/std/src/panicking.rs:367
#16 std::panic::catch_unwind<core::panic::unwind_safe::AssertUnwindSafe<std::thread::{impl#0}::spawn_unchecked::{closure#0}::{closure#0}>, ()> (f=...)
    at /rustc/59eed8a2aac0230a8b53e89d4e99d55912ba6b35/library/std/src/panic.rs:129
#17 std::thread::{impl#0}::spawn_unchecked::{closure#0}<repro::main::{closure#0}, ()> () at /rustc/59eed8a2aac0230a8b53e89d4e99d55912ba6b35/library/std/src/thread/mod.rs:480
#18 core::ops::function::FnOnce::call_once<std::thread::{impl#0}::spawn_unchecked::{closure#0}, ()> ()
    at /rustc/59eed8a2aac0230a8b53e89d4e99d55912ba6b35/library/core/src/ops/function.rs:227
#19 0x000055c8703835b3 in alloc::boxed::{impl#44}::call_once<(), dyn core::ops::function::FnOnce<(), Output=()>, alloc::alloc::Global> ()
    at /rustc/59eed8a2aac0230a8b53e89d4e99d55912ba6b35/library/alloc/src/boxed.rs:1636
#20 alloc::boxed::{impl#44}::call_once<(), alloc::boxed::Box<dyn core::ops::function::FnOnce<(), Output=()>, alloc::alloc::Global>, alloc::alloc::Global> ()
    at /rustc/59eed8a2aac0230a8b53e89d4e99d55912ba6b35/library/alloc/src/boxed.rs:1636
#21 std::sys::unix::thread::{impl#2}::new::thread_start () at library/std/src/sys/unix/thread.rs:106
#22 0x00007f880968b450 in start_thread (arg=0x7f8802edc640) at pthread_create.c:473
#23 0x00007f880945dd53 in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:95

Thanks for the report. This may explain the weird SIGSEGVs I've been seeing in CI as well! I think the upstream project at wolfpld/tracy may be interested in knowing about this issue (though you may need to provide a non-Rust reproducer to them). Would you be up to reporting one to them or should I?

I don't have any experience using tracy from within C++, so you should probably report it.  I'll try reproducing it with just tracy-client to simplify it a bit, though.

FWIW https://github.com/wolfpld/tracy/issues/355 is the issue report upstream with an explanation of what happens. Seems like it may be unavoidable, but also probably not super high impact.
I'm not sure if there's a good way to resolve this on the Rust bindings' side, since detached worker threads are pretty commonplace in Rust and instrumenting these worker threads via e.g. tracing is also a norm.


Confusion matrix in LFAnalysis.lf_summary supposes you have at least one ABSTAIN label

Issue description
I think that the correct and incorrect columns from the LFAnalysis().lf_summary(Y) are wrong when you don't have an ABSTAIN, label (i.e. -1) in the input data.
The confusion matrix does not have the same size if the unique labels are [0, 1, 2] or [-1, 0, 1, 2]. I understand that the [1:, 1:]slicing avoids the label -1 (which the first row/colomn) here
https://github.com/snorkel-team/snorkel/blob/ad5731af21a0e628a1c186c3c0b9f9963bae4b0c/snorkel/labeling/analysis.py#L357
Code example/repro steps
from typing import NamedTuple

import numpy as np

from sklearn.metrics import confusion_matrix

from snorkel.labeling import LFAnalysis

class MockLF(NamedTuple):
    name: str

Y = np.array([0, 1, 0, 2, 1, 0, 1, 2])

lfs = [MockLF("one"), MockLF("two"), MockLF("three")]

# suppose you have three labeling functions
L = np.array([[0, 1, 0],
              [0, 0, 1],
              [1, 0, 2],
              [2, 2, 2],
              [0, 1, 1],
              [0, 0, 1],
              [0, 1, 0],
              [0, 2, 1]])

L_w_abstain = np.array([[-1, 1, 0],
                        [0, 0, 1],
                        [1, -1, 2],
                        [2, 2, 2],
                        [0, 1, -1],
                        [0, 0, 1],
                        [0, -1, 0],
                        [0, 2, 1]])

analysis = LFAnalysis(L, lfs=lfs)
print(analysis.lf_summary(Y))

# well_a = LFAnalysis(L_w_abstain, lfs=lfs)
# print(well_a.lf_summary(Y))

Expected behavior
The first labeling function named "one" should have 3 corrects and 5 incorrects instead of
       j   Polarity  Coverage  Overlaps  Conflicts  Correct  Incorrect  Emp. Acc.
one    0  [0, 1, 2]       1.0       1.0      0.875        1          0      0.375
two    1  [0, 1, 2]       1.0       1.0      0.875        4          0      0.750
three  2  [0, 1, 2]       1.0       1.0      0.875        3          1      0.500

System info

How you installed Snorkel (conda, pip, source): pip
OS: GNU/Linux Debian unstable
Python version: 3.7
Snorkel version: 0.9
Versions of any other relevant libraries:

Thanks!
Damien G.

@garaud this is a great find and thanks for submitting the PR! Submitted some comments there.


🔖(chore) bump version to 2.0.0-beta.13

Added

Add a language picker menu to Richie's header & footer, powered by a new
React component.

@mbenadda I updated the translations from crowdin but couldn't get them to work locally :man_shrugging:


Added CSV data for pizza toppings

Signed-off-by: victorbak<EMAIL_ADDRESS>

There is no gpg signing, so I am going to close this for now, let's try and resolve this tomorrow and re submit a PR.


[BUG] Notification Hub is not triggering events with latest version 10* of firebase_messaging in Flutter - works by using FCM direct though

Describe the bug
Using the latest FCM Messaging libraries in flutter, all events are not triggered when using the iOS platform (real device used). When using the FCM API direct with PostMan, all events are triggered as expected.
Exception or Stack Trace
There is no exception/stack trace as this is performed via the Test Send via Azure Portal.
To Reproduce
Create a flutter application using the latest sample provided by firebase_messaging
https://github.com/FirebaseExtended/flutterfire/tree/master/packages/firebase_messaging/firebase_messaging/example
Get the FCM token
Put a breakpoint on the FirebaseMessaging.onMessage.listen event
Register the FCM token with Notification Hub
Send Test Message using the following payload - Note this is a data only event for background processing
{'aps':{'alert': null, 'badge': null, 'content-available':1}, 'data':{'type': 1, 'payload': 'test'}}
No Breakpoint hit

Using Postman to the following URL (same Apple certificate etc) and payload, breakpoints are being hit.
https://fcm.googleapis.com/fcm/send
{
"to":"****",
"notification" : {
"content_available" : true,
"priority" : "high"
},
"data" : {
"sound" : "default",
"body" :  "test body",
"title" : "test title",
"content_available" : true,
"priority" : "high"
}
}
Code Snippet
Add the code snippet that causes the issue.
Expected behavior
I believe (but probably completely wrong!) that it is caused by a missing element message_id - its expecting this to be provided by the Notification Hub payload
https://github.com/FirebaseExtended/flutterfire/blob/master/packages/firebase_messaging/firebase_messaging/ios/Classes/FLTFirebaseMessagingPlugin.m#L286
Screenshots
If applicable, add screenshots to help explain your problem.
Setup (please complete the following information):

OS: iOS 14
IDE : Visual Studio Code
Version of the Library used - Using Test Send via Azure Portal only - no code

Additional context
We cannot process any messages using the flutter framework since upgrading to the latest version and the Notification Hub, we can though use the FCM REST API's to successfully send and receive messages and payloads though.
Information Checklist
Kindly make sure that you have added all the following information above and checkoff the required fields otherwise we will treat the issuer as an incomplete report

[x] Bug Description Added
[x] Repro Steps Added
[x] Setup information Added

For anyone else who encounters this - you need to include "gcm.message_id", "content-available" as part of every payload (both silent and non-silent notifications) you send through.


chore: Update Validator Readme

This PR

allows the install command to be copied to clipboard
fixes typo

Signed-off-by: Michael Beemer<EMAIL_ADDRESS>

The same is likely true of all of the hooks and providers, so I'll go through and make the same change for all packages' READMEs


license = MIT?

Hi,
Is the code released under MIT license?
See
https://help.github.com/articles/adding-a-license-to-a-repository/
for how to add a license file in the repository.

Hi Lars, yes it is MIT licensed. I will add the license immediately.
Thanks for pointing that out!

MIT Licenses are added to this repository and related service repository:
https://github.com/fatihpense/zmimesync_service
Thanks!


Creating an InfoWindow for polygons

I am trying to create an infoWindow with polygons and it is not supported I can add an onClick to polygon though and create an info window using google maps api new google.maps.InfoWindow
for which I need the map context which is under the key '__SECRET_MAP_DO_NOT_USE_OR_YOU_WILL_BE_FIRED'. Any suggestions?

Never mind tried this and it works https://github.com/tomchentw/react-google-maps/issues/311


feat: add thaumcraft integration to search for essentia

Closes https://github.com/GTNewHorizons/GT-New-Horizons-Modpack/issues/17591
https://github.com/user-attachments/assets/6b4239ef-f8d4-40b9-a1a7-612c9322b5c1
Searching for an Aspect Item from Thaumcraft NEI Integration will find Items (Phials, Jars) and Blocks (Nodes, Jars, ...) that contain essentia of that aspect.
This currently only happens when doing the Find Item on the Aspect Item specifically. It could easily be added that this also happens when pressing it on a filled Phial or Jar directly, if that's desirable (would mirror the behavior for fluid ex. water bucket).

The way that the Filter system since #22 is structured is a bit inverted for this (and in general?).
A filter is created for the TileEntity / ItemStack that is currently being inspected, not the one that we're searching for.
This means that (if necessary) extracting information from the ItemStack we're searching for has to be done again for every TileEntity/ItemStack that is getting checked. Here, that extra work is 'just' getting the Aspect of the Aspect Item, but in the future if there is a case that needs more work done on the item being searched, this design may be very inefficient.
This way, each filter is only being used once (Can't search for multiple Items at once + Filter isn't cached (not that it should)),
thus it seems like an odd choice to me.

The way that the Filter system since #22 is structured is a bit inverted for this (and in general?). A filter is created for the TileEntity / ItemStack that is currently being inspected to check if it's a matching one, not the one that we're searching for.
This way, each filter is only being used once (Can't search for multiple Items at once + Filter isn't cached (not that it should)). This means that (if necessary) extracting information from the ItemStack we're searching for has to be done again for every TileEntity/ItemStack that is getting checked. Here, that extra work is 'just' getting the Aspect of the Aspect Item, but in the future if there is a case that needs more work done on the item being searched, this design may be very inefficient, so it seems like an odd choice.

Correct. this is necessary because each block can have its own algorithm for reading its inventory.
It is impossible to build a filter from the side of the ItemStack you are looking for, since the filter is unique for each TileEntity/ItemStack  in which you need to search (If you have an idea how to fix this, give an example)

This currently only happens when doing the Find Item on the Aspect Item specifically. It could easily be added that this also happens when pressing it on a filled Phial or Jar directly, if that's desirable (would mirror the behavior for fluid ex. water bucket).

I don't have an answer to that. I don't play with magic and I don't know how it would be convenient.

This currently only happens when doing the Find Item on the Aspect Item specifically. It could easily be added that this also happens when pressing it on a filled Phial or Jar directly, if that's desirable (would mirror the behavior for fluid ex. water bucket).

I don't have an answer to that. I don't play with magic and I don't know how it would be convenient.

Well aspects aren't actual items, so you would have to go out of your way to search them in NEI before you could ever make use of this feature.
Expanding this feature to include phials and jars sounds like a sensible way to allow people to discover it. Most likely you would want to interpret the search as an "item search" if the phial/jar is empty and as an "aspect search" otherwise.

It is impossible to build a filter from the side of the ItemStack you are looking for, since the filter is unique for each TileEntity/ItemStack in which you need to search (If you have an idea how to fix this, give an example)

It's possible - just do the logic of extracting the needed data from the TE in the match method of the filter instead of the constructor. The Filter would then be specific to the item we're searching for instead of the TE/Stack in which we're searching, and the logic to process the inspected TE/Stack would be moved from the constructor of the filter to the match method.
In pseudocode, currently it's
class SomeFilter {
constructor(inspectedThing) {
  // Extract needed data from inspected thing, ex. for backpack/chest, get the contents of it
}
boolean match(searchedItem/searchRequest) {
  // Extract needed data from the Item we're searching for, ex. for water bucket, get the water fluid
  // Check if the extracted data of the inspectedThing matches the extractedData of the searchedItem
}
}

if we just invert it, then it's
class SomeFilter {
constructor(searchedItem/searchRequest) {
  // Extract needed data from the Item we're searching for, ex. for water bucket, get the water fluid
}
boolean match(inspectedThing) {
  // Extract needed data from inspected thing, ex. for backpack/chest, get the contents of it
  // Check if the extracted data of the inspectedThing matches the extractedData of the searchedItem
}
}

(Whether the extracting from inspectedThing is actually done in the constructor or in the getFilter which calls the constructor is irrelevant here, it's the same)
Since now the filter is created for the searched item instead of the inspected TE/Item, it can be re-used so we don't have to call the constructor so amny times and we don't have to repeat extracting the data from the searchedItem every time.
This would mean the sigature of IStackFilter would change from
public interface IStackFilter {
    boolean matches(FindItemRequest request);
}

to
public interface IStackFilter {
    boolean matches(ItemStack stack);
    boolean matches(TileEntity tileEntity);
}

and similarly, getFilter of providers would get passed the FindItemRequest or the searched ItemStack instead of the inspected ItemStack/TileEntity.
Now, for example for a Backpack Provider, the IStackFilter would be constructed with the item we're searching for, and the matches(ItemStack stack) method would check if stack is a backpack, extract the inventory from the backpack, and check if the inventory contains the stack that it was constructed with.
This does mean that most Providers won't return null for getFilter in most cases, but it would still drastically reduce the amount of Filters constructed, since we're now scaling with the amount of Providers instead of the amount of inspected Stacks/TEs

https://github.com/user-attachments/assets/0ae9ad7a-eff6-4ba2-99a7-bd4cac7d11ef
Now with searching by essentia container


Use python code as plugin

I would like to know if it is possible to use python code as plugin instead of TypeScript code.
As an example, I would like to perform a pearson correlation. I already have this code on my hand but I would like to use it with superset interface. Is it possible to do that ? If yes do you have a documentation about that ?
Thanks
Guillaume

@GuillaumeTh I have actually created a viz that's able to run Python code and render just like regular charts, but it's not quite ready for public consumption yet. In the meantime, would you be able to share how what your preferred workflow would look like? I assume you would like to be able to write regular python code, much like in a notebook, and then render a matplotlib or similar chart in the chart window?

@GuillaumeTh I have actually created a viz that's able to run Python code and render just like regular charts, but it's not quite ready for public consumption yet. In the meantime, would you be able to share how what your preferred workflow would look like? I assume you would like to be able to write regular python code, much like in a notebook, and then render a matplotlib or similar chart in the chart window?

@ktmud Thanks I will check that. In our case Pearson is a small example. We have more complex stats already in python. @villebro currently I have my own Flask server and I get infos from html dropdown. After that a python code run pearson correlation on selected data and display table and graphs in the HTML Flask page. Is it fit in your current workflow ?

@ktmud Thanks I will check that. In our case Pearson is a small example. We have more complex stats already in python. @villebro currently I have my own Flask server and I get infos from html dropdown. After that a python code run pearson correlation on selected data and display table and graphs in the HTML Flask page. Is it fit in your current workflow ?

Going down the same route, I found these SQL based functions useful for 2d series, but I'm looking forward to @villebro's python-bridge because nothing beats pandas.corr() s simplicity in this case.

Hi @villebro I am interesting to test your python support and give you feed back if you want. This python support is important for us and could be a game changer.


Issues while configuring Visual Studio Code for WSL

Windows Build Number : Microsoft Windows [Version 10.0.18362.175]
I'm trying to configure Visual Studio Code to use WSL, as per the steps detailed by Microsoft here at https://code.visualstudio.com/docs/remote/wsl , however every time, I input code ., the following issue occurs,

tanayjha@LAPTOP-4NQ98UA8:~$ cd /mnt/d/Development/CProgramming/
tanayjha@LAPTOP-4NQ98UA8:/mnt/d/Development/CProgramming$ ls
'Hello, World'
tanayjha@LAPTOP-4NQ98UA8:/mnt/d/Development/CProgramming$ cd Hello\,\ World/
tanayjha@LAPTOP-4NQ98UA8:/mnt/d/Development/CProgramming/Hello, World$ code .
Updating VS Code Server to version c7d83e57cd18f18026a8162d042843bda1bcf21f
Removing previous installation...
Downloading:     Failed
Redirecting output to ‘wget-log’.
ERROR: Failed to download https://update.code.visualstudio.com/commit:c7d83e57cd18f18026a8162d042843bda1bcf21f/server-linux-x64/stable to /home/tanayjha/.vscode-server/bin/c7d83e57cd18f18026a8162d042843bda1bcf21f-1560983444.tar.gz
tanayjha@LAPTOP-4NQ98UA8:/mnt/d/Development/CProgramming/Hello, World$

Every time the setup gets stuck here, no matter if I use Visual Studio Code or Visual Studio Code Insiders with the  Remote Development Extension. I've tried using both wired and wireless internet connections, and yet it fails. Other commands such as sudo apt-get update work just fine.
Here's a screenshot just in case,

Here's the log from wget-log file,
 cat wget-log
--2019-06-20 04:00:45--  https://update.code.visualstudio.com/commit:c7d83e57cd18f18026a8162d042843bda1bcf21f/server-linux-x64/stable
Resolving update.code.visualstudio.com (update.code.visualstudio.com)... <IP_ADDRESS>
Connecting to update.code.visualstudio.com (update.code.visualstudio.com)|<IP_ADDRESS>|:443... connected.
Unable to establish SSL connection.

What is the significance of the cd Hello\,\ World/ in your repro (it can't have been for giggles). Does VS Code Remote WSL operate correctly from /home/foo?

What is the significance of the "cd Hello\,\ World/" in your repro (it can't have been for giggles). Does VS Code Remote WSL operate correctly from /home/foo?

@therealkenc
I was just trying to navigate inside the folder, and then open VS Code. Basically was trying to build a Hello, World app using VSCode, and the terminal powers of WSL.
No, WSL doesn't operate correctly even from home/foo . Ends up returning the same error

Okay, appreciate the follow-up. Since wget is apparently working for you in general, and the VS Code spawned wget is not, you might get better guesses over there. That said, it isn't going to be a VS Code Remote thing proper either, since they'll tell you they aren't doing anything "special" with wget. With luck we'll get some me2s and learn some more about what is causing the diverge on your rig.

Wait... I am thinking the resolver, somehow. Your Internet connection is fine, but your DNS is not. Try sticking go-to <IP_ADDRESS> in /etc/resolve.conf on a lark. Noting that we're grasping here. Like:
# This file was automatically generated by WSL. To stop automatic generation of this file, add the following entry to /etc/wsl.conf:
# [network]
# generateResolvConf = false
nameserver <IP_ADDRESS>

Wait... I am thinking the resolver, somehow. Your Internet connection is fine, but your DNS is not. Try sticking go-to <IP_ADDRESS> in /etc/resolve.conf on a lark. Noting that we're grasping here. Like:
# This file was automatically generated by WSL. To stop automatic generation of this file, add the following entry to /etc/wsl.conf:
# [network]
# generateResolvConf = false
nameserver <IP_ADDRESS>

I edited the resolve.conf file using vim, and set the nameserver value to <IP_ADDRESS>, however the problem continues. The download fails by stating failed to establish a SSL connection

however the problem continues

Well it was worth a try..... Thanks.

@therealkenc it seems the problem was due to my antivirus, Kaspersky's network settings, which have a fix as stated here https://superuser.com/questions/1401889/complete-ssl-ubuntu-failure-on-windows-subsystem


gui not loading

vncviewer shows a black screen with a square cursor.

Please show the output of the terminal when you ran the vncstart command

Please show the output of the terminal when you ran the vncstart command

You chose dynamic resolution
Cleaning stale pidfile '/root/.vnc/localhost:5901.pid'!
Cleaning stale X11 lock '/tmp/.X1-lock'!
Cleaning stale X11 lock '/tmp/.X11-unix/X1'!
New Xtigervnc server 'remote-desktop' on port 5901 for display :1.
Use xtigervncviewer -SecurityTypes VncAuth,TLSVnc -passwd /root/.vnc/passwd localhost:1 to connect to the VNC server.
VNC server started. The default password is the account password for root
root@localhost:~#

run vncstart in user not as root


Question about RCD

Thank you for your work! I'm interested in the RCD loss you designed. When I look at the code of the network, I see that the loss of use is ChamferDistanceL1. May I ask where the lost code of RCD is?

Thank you for your interest. I did not encapsulate the RCD as a python class, but instead it is implemented using the code in Partial2Complete/models/P2C.py line 168-171.
rebuild_points = nbr_groups[1] + center_groups[1].unsqueeze(-2)
idx = pointops.knn(center_groups[1], pred,  int(self.nbr_ratio * self.group_size))[0]
nbrs_pred = pointops.index_points(pred, idx).reshape(B, -1, 3)
shape_matching_loss = self.shape_matching_weight * self.shape_criterion(rebuild_points.reshape(B, -1, 3), nbrs_pred).mean()

The RCD first sample center point in the partial shape, this is finished in the group points stage (line 152).
nbrs , center = self.group_divider(pts)  # neighborhood, center

Then, it extracts local patches around center points in both partial and predicted shape. For partial shapes, this is also finished in line 152. For predicted points, we first extract KNN index, then extract local patches as shown in the first code block.
idx = pointops.knn(center_groups[1], pred,  int(self.nbr_ratio * self.group_size))[0]
nbrs_pred = pointops.index_points(pred, idx).reshape(B, -1, 3)

We then do a union operation
rebuild_points = nbr_groups[1] + center_groups[1].unsqueeze(-2)  # for partial point cloud
nbrs_pred = pointops.index_points(pred, idx).reshape(B, -1, 3)  # for predicted point cloud, .reshape(B, -1, 3) do the union operation

Then, the RCD compute the Chamfer distance between the union of patches,
self.shape_criterion(rebuild_points.reshape(B, -1, 3), nbrs_pred).mean()

I am sorry the code I wrote might be too confusing. Please let me know if you have further concerns

Thank you very much for answering my question in detail. Your answer is of great help to me.

Thank you for your interest. I did not encapsulate the RCD as a python class, but instead it is implemented using the code in Partial2Complete/models/P2C.py line 168-171.
rebuild_points = nbr_groups[1] + center_groups[1].unsqueeze(-2)
idx = pointops.knn(center_groups[1], pred,  int(self.nbr_ratio * self.group_size))[0]
nbrs_pred = pointops.index_points(pred, idx).reshape(B, -1, 3)
shape_matching_loss = self.shape_matching_weight * self.shape_criterion(rebuild_points.reshape(B, -1, 3), nbrs_pred).mean()

The RCD first sample center point in the partial shape, this is finished in the group points stage (line 152).
nbrs , center = self.group_divider(pts)  # neighborhood, center

Then, it extracts local patches around center points in both partial and predicted shape. For partial shapes, this is also finished in line 152. For predicted points, we first extract KNN index, then extract local patches as shown in the first code block.
idx = pointops.knn(center_groups[1], pred,  int(self.nbr_ratio * self.group_size))[0]
nbrs_pred = pointops.index_points(pred, idx).reshape(B, -1, 3)

We then do a union operation
rebuild_points = nbr_groups[1] + center_groups[1].unsqueeze(-2)  # for partial point cloud
nbrs_pred = pointops.index_points(pred, idx).reshape(B, -1, 3)  # for predicted point cloud, .reshape(B, -1, 3) do the union operation

Then, the RCD compute the Chamfer distance between the union of patches,
self.shape_criterion(rebuild_points.reshape(B, -1, 3), nbrs_pred).mean()

I am sorry the code I wrote might be too confusing. Please let me know if you have further concerns

Thank you very much for answering my question in detail！ Your answer is of great help to me.

Thank you for your interest. I did not encapsulate the RCD as a python class, but instead it is implemented using the code in Partial2Complete/models/P2C.py line 168-171.
rebuild_points = nbr_groups[1] + center_groups[1].unsqueeze(-2)
idx = pointops.knn(center_groups[1], pred,  int(self.nbr_ratio * self.group_size))[0]
nbrs_pred = pointops.index_points(pred, idx).reshape(B, -1, 3)
shape_matching_loss = self.shape_matching_weight * self.shape_criterion(rebuild_points.reshape(B, -1, 3), nbrs_pred).mean()

The RCD first sample center point in the partial shape, this is finished in the group points stage (line 152).
nbrs , center = self.group_divider(pts)  # neighborhood, center

Then, it extracts local patches around center points in both partial and predicted shape. For partial shapes, this is also finished in line 152. For predicted points, we first extract KNN index, then extract local patches as shown in the first code block.
idx = pointops.knn(center_groups[1], pred,  int(self.nbr_ratio * self.group_size))[0]
nbrs_pred = pointops.index_points(pred, idx).reshape(B, -1, 3)

We then do a union operation
rebuild_points = nbr_groups[1] + center_groups[1].unsqueeze(-2)  # for partial point cloud
nbrs_pred = pointops.index_points(pred, idx).reshape(B, -1, 3)  # for predicted point cloud, .reshape(B, -1, 3) do the union operation

Then, the RCD compute the Chamfer distance between the union of patches,
self.shape_criterion(rebuild_points.reshape(B, -1, 3), nbrs_pred).mean()

I am sorry the code I wrote might be too confusing. Please let me know if you have further concerns

May I ask if I can apply RCD to the field of scene flow matching?

I am sorry that I am not familiar with scene flow matching.
The motivation of RCD is that the ground truth is a subset of the prediction, we want to have a stronger supervision to the known parts to be matched.

I am sorry that I am not familiar with scene flow matching. The motivation of RCD is that the ground truth is a subset of the prediction, we want to have a stronger supervision to the known parts to be matched.

Thanks for your reply！


Push unregister fails in browser

Calling unregister in a browser throws an error, whereas register just fails silently. A silent fail (maybe with a console.log saying the plugin is unavailable) is preferable, to support testing in a browser.
The iOS emulator fails with the same error, as it does not support push.
Cannot read property 'token' of null at Push.unregister (push.js:168)

Thanks @Manduro. I've fixed the problem. unregister returns a promise, so it should never have failed in that manner.


Fix sqlite timestamps

Fixes #3693
Fixes #3320
This is a big change in the way we store and parse timestamp in sqlite.

(Major) We don't ignore timezones anymore if they are present, I am unsure why this what put in place but it feels very very very wrong to me. The data written by diesel is always switched to UTC, but we can't assume the data in the database was written by us. We still fallback to a "naive" implementation if the timezone is missing. I had to remove "bad" tests since 1970-01-01 00:00+01:00 is not the same time as 1970-01-01 00:00Z in my book. We still ignore the timezone if the user uses a "naive" datetime to read the data (I think that is fair, though we could verify with other ORM if they correct to UTC instead).
Uniformity between time and chrono, the code looks more similar and the formats are the same so a user can switch library without any issue now (that was something I found in #3693)
Fixed some documentation

@weiznich This is ready for another round of review, I changed a bit the encoding.
I realized we didn't need the differentiation for subsecond in chrono since the dot is handled by the formatter.
I changed time to now print all digits instead of just 3 or 6 like it currently done, this aligns it with chrono (and what sqlx is doing whatever that's worth).
I am still unsure how many digits we should really print, PG and Mysql cut at the microseconds but sqlite by default stops at the millisecond with %f. And if we should differentiate between a datetime with timezone and a "naive" datetime/time. Any external opinion would be appreciated, but it seems all over the place.
The case for printing they all is quite simple, it's still respecting the RFC3339 and the user can decide to not pass us the microseconds/nanoseconds if they don't want them in the database but the inverse (stopping at X digits) means we decide what loss of information is acceptable.

@weiznich Ready!


TaskDialog Default Button

TaskDialog provides a lot of useful extra features compared to ContentDialog, but there's one notable feature missing:
DefaultButton and CancelButton
Any chance to add that feature?

DefaultButton is implemented. You can't use it if using TaskDialogButton.OKButton or any of the other built-in buttons as those are kept simplistic by design. Instead define a TaskDialogButton and set the IsDefault property to true (see below).
CancelButton is handled implicitly by the TaskDialog listening for the Escape key and closing the dialog with TaskDialogStandardResult.None
var td = new TaskDialog
{
    XamlRoot = this,
    Content = "Default Button Test",
    Buttons =
    {
        new TaskDialogButton
        {
            Text = "OK",
            IsDefault = true,
            DialogResult = TaskDialogStandardResult.OK
        },
        new TaskDialogButton
        {
            Text = "Cancel"
        }
    }
};


Improve error handling in DDLS deserialize

https://github.com/larshp/abapGit/blob/604c68200ed6a038229756f179fb86b9ccc9cc39/src/objects/zcl_abapgit_object_ddls.clas.abap#L168
The TRY CATCH block contains SAVE and WRITE_TADIR calls. If WRITE_TADIR fails, the DDL source will stay in the system in inactive state. In this case, it will not be possible to edit the object via ADT, because TADIR entry is missing. And it will not be possible to create the DDL source manually via ADT, because the DDIC metadata for it already exist. The issue can be solved if you do separate TRY CATCH blocks for each operation (for better traceability). If WRITE_TADIR fails, you need to cleanup the DDIC metadata by calling IF_DD_DDL_HANDLER~DELETE method in CATCH block. If something goes wrong while SAVE, it is also a good idea to call the DELETE method, because part of the DDIC metadata can already be stored in the repository and cause inconsistencies for the next import.

Pull requests welcome 😄

@ezavozina can you help testing the fix in https://github.com/larshp/abapGit/pull/2718 by @juancarlosrodriguezf


🔧 Repository: Renovate changesets on devDependencies

📜 Description
The renovate-changeset action is adding changesets for changes that are only devDependencies. When we merge these changes it then kicks off the version packages which we don't need in this case as the package hans't actually changed
This is properly not something that we fix in this repo but here: https://github.com/backstage/actions/tree/main/renovate-changesets, logging it here for visibility and so I don't forget about it.
👍 Expected behavior
There should be not changesets if the changes are just related to devDependencies
👎 Current Behavior
Changesets are added when there change is just for devDependencies
👟 Reproduction steps
Example PR here: https://github.com/backstage/community-plugins/pull/877
📃 Provide the context for the Bug.
I merged this PR - https://github.com/backstage/community-plugins/pull/877 - which then triggers a bunch of Version Packages PRs.
👀 Have you spent some time to check if this bug has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

Are you willing to submit PR?
No, but I'm happy to collaborate on a PR with someone else

I'd like to take a look at this, can I be assigned to the issue?

Opened a PR for this issue here: https://github.com/backstage/actions/pull/159

I'm not sure about this as in some cases a changeset might be required even for devDependencies bumps.
It can also help debugging unexpected compatibility issues with releases to identify potential causes more quickly.

I think for cases where a changeset for devDependencies are needed, they could be manually added to the Renovate PR. WDYT @vinzscam ?

I also noticed that in this repo we seem to be using this script: https://github.com/backstage/community-plugins/blob/main/scripts/ci/generate-bump-changesets.js rather than the action mentioned in the issue for genrating renovate changesets. So I'd assume we need to make changes to the script instead?


Adding a png image with no background[transparent] always shows border and even after overriding it with CSS it shows very faint border

The html along with bootstrap I used is

The output I am getting is

After overriding bootstrap with internal css the border is still prominent..This image worked fine till bootstrap 5.0 beta 3

Visible border even after border removal

If however I upload the image with style attribute inside div tag it works fine..

Here is the output

Seems like a bug to me

Bootstrap doesn't add a border to the img-fluid class. You should inspect the image in your browser dev tools to see what's happening. It would be either custom CSS or perhaps your image has a slight border.
Here's a codepen with Bootstrap 5.0.2 with a transparent background PNG (no border).
https://codepen.io/coliff/pen/RwpXBoy


Bug: Not logging errors

All my logfiles (last 3 days) exist, but are empty. Changing the logdirectory had no effect. The error was only displayed once, the rest of the time nothing happens.

which os are you using?

Windows. There is a folder name in the path (before the .obsidian) in case that might be relevant.


Fetch spec requires non-omit credentials mode to set cookies too.

HTTP Network or cache fetch step 13 gates on the credentials flag.

Sorry for the merge commit :/

Yeah, this sounds right.

If credentials flag is set and response's header list contains one or more headers named Set-Cookie, run these substeps:

Could @annevk confirm?
There would be a bug in Chrome Canary in this case cause it does pass here when it shouldn't. @nikhilm could you write an extra test that asserts that Set-Cookie is ignored in the credentials omit case.

Thanks @nikhilm!

Confirmed, cookies should only be set if the request allowed credentials. Otherwise e.g. a CORS preflight could result in cookies being set.

Thanks @annevk!


FPORT: Make JCenter opt in

Forward-port of #2335.
Depends upon a release with sbt/librarymanagement#17.

Can one of the admins verify this patch?

@dwijnand I think that the latest release of sbt/librarymanagement (0.1.0-M6) includes sbt/librarymanagement#17.

Well this is the change that required 0.13.11, so I'll wait for that change to be pushed sbt/librarymanagement before updating this. This forward-porting-with-split-repo business is so time consuming.

Superseded by #2481


Block requests to private IPs

Pull request checklist:

[x] CHANGELOG.md was updated, if applicable

Description
Closes #480

This will still resolve hosts pointed to by DNS records. For example if we'd have an A record saying localhost.example.com -> <IP_ADDRESS>, this won't ignore <IP_ADDRESS>.

That should be handled via the ignored hosts imo. It might be worthwhile to add a config option for ignored hosts, since as of now they can only be added by patching the source.

Go's HTTP client has a way to customize parts of the transport layer, see https://pkg.go.dev/net/http#Client and https://pkg.go.dev/net/http#RoundTripper - with this we should be able to intercept the request after the domain resolving has happened & stop it mid-transit instead
Happy to discuss if this feels like a bad idea

I was not able to find a way to intercept requests after the domain resolving. If this is not feasible, we could instead make the ignored hosts configurable and maybe add common hosts (e.g. localhost) as a default entry.


workflow doesn't go ahead next item in case of concurrency: 1

Discussed in https://github.com/StackStorm/st2/discussions/6232

Originally posted by freeyssu September  3, 2024
I usually use with - items statement for parallel process.
I found out that a failed job with concurrency: 1 config causes that task is termiated immediately even though uncompleted items in loop still remains.
This is my sampe code.
When svr1 is failed with concurrency: 1, the workflow doesn 't run the action for the remained 2 items svr2 and svr3. My expectation is that the task completes all 3 items in loop and then mark FAIL result as the first item is failed.
In case of concurrency: 2 or having bigger value, the workflow executes all 3 items and  then marks task FAIL result. This is what I expected.
vars
  - servers: ["svr1", "svr2", "svr3"]

task:
    with:
      items: target_server in <% ctx(servers) %>
      concurrency: 1
    action: pack.action
    next:
      ....
```</div>

This is a known 'fail fast' feature.  You can use a sub workflow that ignores failures to bypass this for now.


Pattern synonyms

 Issue by Lysxia
Friday Aug 28, 2020 at 23:49 GMT
Originally opened as https://github.com/antalsz/hs-to-coq/issues/164

Is there an edit to skip pattern declarations? hs-to-coq just chokes on them:
non-function top level bindings: pattern Em = () unsupported [in module A]

Context: there are some of those in containers, Data.Sequence.Internal.

 Comment by lastland
Saturday Aug 29, 2020 at 02:57 GMT

Unless I'm missing something, I don't think there is such an edit and I'm not sure how difficult it would be to add such an edit.


SAK-31196 - Convert autosave to use webjar

I'm converting this to a submodule of reference and updating to a tag

This branch changed to the webjar is packaged as part of the build (from the new webjars top level) and deployed and used with the version that's there.

When it's not an actual org.webjar artifact should we putting it in the org.sakaiproject namespace? Is it worth contributing this back to the main webjar repository? http://www.webjars.org/contributing

Well I think it's worth contributing it back but I think I think we'd need some a little more work (and maybe at least notify) the original author. This is more of a proof of concept I guess, and could be used for plugins we maintain and ones we just want to pull in really easily? Just seemed better than dropping a new version in here.
I know there's a lot of other ones I could clean up after this was merged.
We could temporarily change the groupId to something else, but I do think that it eventually will get into org.webjars and since it's not released or anything it shouldn't matter that much right now. (Unless he actually does release it, but no way it will match this version)

I'm merging this for now. I should have time once we do a few more of these to look at bundling them up for a proper webjars release but right now there's no plugins there at all.

I forgot that it should be in the org.sakaiproject namespace rather than in this org.webjar namespace. I feel like this might help for temporarily releasing it and is a better idea. That was on PR #3307

By not fixing this we get this warning too during the build. This certainly would move it up on my "release as a webjar" TODO list. I think I'll get the word count packaged and try to get them both.
[WARNING] Some problems were encountered while building the effective model for org.sakaiproject.webjars:ckeditor-autosave:jar:8541f541d9985cfd0859c7d8eb6be404afe95a2d
[WARNING] 'version' contains an expression but should be a constant. @ org.sakaiproject.webjars:ckeditor-autosave:${ckeditor.autosave.version}, /home/matt/gitsource/jonespm/sakai/reference/webjars/ckeditor-autosave/pom.xml, line 15, column 14
[WARNING] 'build.plugins.plugin.version' for org.sonatype.plugins:nexus-staging-maven-plugin is missing. @ org.sakaiproject.webjars:ckeditor-autosave:${ckeditor.autosave.version}, /home/matt/gitsource/jonespm/sakai/reference/webjars/ckeditor-autosave/pom.xml, line 68, column 21
[WARNING]
[WARNING] It is highly recommended to fix these problems because they threaten the stability of your build.
[WARNING]
[WARNING] For this reason, future Maven versions might no longer support building such malformed projects.


Code review Integration discussion

Objective
Discuss potential code-review implementations, document possible solutions/features - and decide on what is required for a Demo and separately for an MVP and Roadmap for later discussion and prioritisation.
Abstract
Some corporates wish for an internal code review before a push is allowed. There are a number of ways this could be supported.
Many organizations implement a shadow internal GIT Repo, usually BitBucket. Developers will internally push to the internal repo against a feature and run some PR request to the internal-git master before then push to the public repo.
We also should support a lighter weight process where we support.
Potential Solutions

The above shadow process, where we check to a successful PR against an internal repo before allowing the push (this would be a straight forward synchronous check)

Email authorization - send email with delta changes to a user-list configured against the repo and await an "APPROVE" email response before continuing with the push (this would be an asynchronous flow, where the push is delayed)

Inbuilt code-review UI with SAML based authentication, this would be an asynchronous flow

Support Synchronous Webhooks

Support Asynchronous Webhooks

Code review conversation complete - we will support synch + asnych webhooks alongside parsing the PACK file content


Connecting database models via ids

Currently, connections between database models are inferred via names (username, job_name, run_name, ...). To make querying more efficient names could be replaced by id (foreign keys).
Things to consider:

the ids should not be used anywhere outside of the database connectors
it might prohibit hybrid database use, e.g. managing users via OIDC and the rest via sqlalchemy

Related to #98.


Intellisense not working properly

Type: Bug
Intellisense stopped working when this update came. i thought it would work after the update but it seems nothing changed
VS Code version: Code 1.84.2 (1a5daa3a0231a0fbba4f14db7ec463cf99d7768e, 2023-11-09T10:51:52.184Z)
OS version: Windows_NT x64 10.0.19045
Modes:

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-8565U CPU @ 1.80GHz (8 x 1992)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: enabled_ondirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: enabled

Load (avg)
undefined

Memory (System)
15.77GB (1.69GB free)

Process Argv
--crash-reporter-id e4fbb242-7fb7-4fa5-900f-d6ef4a476490

Screen Reader
no

VM
50%

Extensions (5)

Extension
Author (truncated)
Version

al-code-outline
and
3.0.53

al-codeactions
dav
1.0.33

al
ms-
12.1.887908

vscode-icons
vsc
12.6.0

crs-al-language-extension
wal
1.5.29

A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
vserr242:30382549
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vshan820:30294714
vstes263cf:30335440
vscod805:30301674
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593:30376534
pythonvs932:30410667
py29gd2263:30880072
vsclangdf:30486550
c4g48928:30535728
dsvsc012:30540252
pynewext54:30695312
azure-dev_surveyone:30548225
282f8724:30602487
f6dab269:30613381
2i9eh265:30646982
showlangstatbar:30737416
pythonfmttext:30731395
fixshowwlkth:30771522
showindicator:30805244
pythongtdpath:30769146
i26e3531:30792625
welcomedialogc:30887144
pythonnosmt12:30797651
pythonidxpt:30866567
pythonnoceb:30805159
asynctok:30869155
dsvsc013:30795093
dsvsc014:30804076
dsvsc015:30845448
pythontestfixt:30871694
pythonregdiag2:30871582
pyreplss2:30886141
pythonmypyd1:30879173
pythoncet0:30885854
pythontbext0:30879054
accentitlementsc:30887149
dsvsc016:30886110
dsvsc017cf:30886113
dsvsc018cf:30886115
aa_t_chat:30882232

Assuming the extensions listed in your report relate to the language you are coding in, please report the issue to the authors of whichever of those extensions is supposed to be providing Intellisense for the language.

This issue is caused by an extension, please file it with the repository (or contact) the extension has linked in its overview in VS Code or the marketplace for VS Code. See also our issue reporting guidelines. If you don't know which extension is causing the problem, you can run Help: Start extension bisect from the command palette (F1) to help identify the problem extension.
Happy Coding!


Menu > Profile UI Missing

Summary:
The Profile UI is missing. This should load a new page with the following elements
Firstname / Lastname
Level and XP
Current goals
Past goals (this is a link to past goals obtained, and the XP earned for each)
Badges (these will be small icons like gaming type trophies, we could maybe use font awesome icons?)
Date joined
Signup for E-Mail newsletter - there should be a chechbox beside this, and if they hit it a field appears below with an OK button beside it which submits their email to the database.

need profile design reviewed, can see it at http://appdemo.oinweb.ca/profile.html


not working in cosole log

customConsole.log.apply( context, arguments );
stream.write( ${generatePrefix( method, config, customConsoleStream.last_msg )}  );
in index.js,I think in line 32  is wrong because  the arguments should inclue generatePrefix(xxx)....
just like this:
let prefix = ${generatePrefix( method, config, customConsoleStream.last_msg )}
arguments.unshift(prefix)
customConsole.log.apply( context, arguments );
i just fix it with these code .

I'm not following you here. Can you please give an example of the problem and how to reproduce it?


Fix/3463 re enable test

There was an alert that prevented the test to proceed (see screenshot). This PR should handle it.
Fixes EXPOSUREAPP-3463

Working Tests 🎉


Working example of Dialog Directive with SkillBuilder schema

I've been pouring over the documentation and digging into the source for why my dialog is not replying and I think it's because I'm using the SkillBuilder.
alexaApp.intent('GetCountryIntent', {
  "dialog": {
    type: "delegate"
  },
  'slots': {},
  'utterances': []
}, (req, res) => {
  if (req.getDialog().isStarted() || req.getDialog().isInProgress()) {
    req.getDialog().handleDialogDelegation();
  }
});

The above returns "dialogState": "STARTED", but then immediately returns "dialogState": "COMPLETED"
I have my IntentSchema.json from the SkillBuilder so is there a way to inject that schema into my alexaApp.intent() or the alexaApp.express({})? I see this idea referenced here #268
The documentation mentions using ask-cli, but I'm a little lost as to how to integrate it and tie it all together. I'm not using the ask deploy command.

I've never used dialog directives, so I'm afraid I don't particularly have any advice/useful info.
For your second point: currently, this library is built around the idea that you'll use your JS code to generate your Alexa schema, not the other way around. e.g. alexaApp.schemas.skillBuilder() will generate an IntentSchema.json file you can drop into the skill builder, but there isn't a concept of importing a skill builder-generated JSON file into your JS app.

Dialog Directives seem to be working for me using very similar code.
alexaApp.intent(
  "SetState",
  {
    dialog: { type: "delegate" },
    utterances: ["{set|change} {state|location}"]
  },
  function(req, res) {
    if (req.getDialog().isStarted() || req.getDialog().isInProgress()) {
      req.getDialog().handleDialogDelegation();
    } else if (req.getDialog().isCompleted()) {
      //do amazing skilful things with the various req.slot("SLOTNAME")
    }
  }
)

Alexa handles ensuring the slot(s) are filled as specified in the Skill Builder, and then when everything is in order, my code processes the results.

Hi @funkydan2 I am using exactly your code, but I receive an "req.getDialog is not a function." error.


Error by editing Published Chart

I got a completed Visualization from someone. I wanted to Edit the Visualization again to see what filters and settings they put in.
When i clicked on the Horizontal axis which is Geburtsjahr in this Visualization i get a black screen with the message: "Application error: a client-side exception has occurred (see the browser console for more information)."
I first thougt i probably am the only one who gets this Issue because it says client side but i made someone else do the same thing as i did with the same Published Visualization and she got the same error message as me when she clicked on the horizontal axis.
When i open the same Data set by myself and click on the horizontal axis i havent gotten this error message.
To Reproduce
Steps to reproduce the behavior:

Open up the Link to the published chart: https://int.visualize.admin.ch/de/v/xnf88WuNFK_L?dataSource=Int
click on "open and edit this visualization"
Click on the horizontal axis

Expected behavior
It should open up the horizontal axis settings
Screenshots or video

Environment (please complete the following information):

Visualize environment and version: v3.24.0 (35dd61f)
Microsoft Edge Version 119.0.2151.44 (Offizielles Build) (64-Bit)

thanks for reporting this @LiamBAFU we will investigate.

@bprusinowski i tested this and could reproduce the error. However when I recreate the exact chart (see: https://int.visualize.admin.ch/v/FTFqAgg2vKCP?dataSource=Int) i cannot reproduce the error. I am wondering if the data changed, causing the error Liam reported.

@sosiology fyi: cannot reproduce here on firefox. related to browser?

Thank you for the hint @Rdataflow. I will test on different browsers and report the results.

@LiamBAFU I retested the reported bug (using this link: https://int.visualize.admin.ch/de/v/xnf88WuNFK_L?dataSource=Int)  this morning on various browsers including: Firefox, Safari, Chrome and Edge and couldn't reproduce the error anymore (thanks for the hint @Rdataflow). Could you retry and let me know if the error persists on your side? Thank you.

I don't get the error message anymore. Thanks for looking at the problem :)


Some files don't have "SamplesPerPixel" header which results in a crash during file parsing

I found a test file which is publicly available here: https://github.com/dragonlet/dicom4android/blob/master/etc/dbf/CT-MONO2-12-lomb-an2
This file does not have a "SamplesPerPixel" header which causes the parser to return an ElementNotFound error when parsing the pixel data. Wondering if it would be a good idea to use a default value of 1 when this header is not present?

Thanks for flagging! I saw this too in testing for issue #59. I will look into it a little more, but when working with clinical datasets, I always like to not assume defaults (unless specified in the spec). If something important to reconstructing the image is missing in the raw data, better to flag to the user.
That being said, we can add an override flag the user can supply where we assume defaults like this. However by deafult, I think returning an error to indicate something is not as expected might be safest (unless the spec says to assume a default in this case--I need to double check that).

That makes sense. I agree that it may be safer not to assume any defaults unless they are explicitly documented in the standard. It's probably a good idea to just flag the user that the DICOM they are parsing does not conform to the standard

Sounds good, closing this out as WAI then!


healthcheck json is not pretty printed

I'd like to have my healthcheck response to be pretty printed.
The following code doesn't seem to affect it
        environment.getObjectMapper().enable(SerializationFeature.INDENT_OUTPUT)
How can I enable pretty printing of the healthcheck (i. e. the response of http://localhost:9081/healthcheck)

Hi @mrkam,
HealthCheckServlet uses own ObjectMapper, and you can't change it. But you can get your response pretty printed by passing the pretty query parameter to the the health check URI: http://localhost:9081/healthcheck?pretty=true.


Weird visual glitch with leaves?

Apparently looking at the leaves from certain distance give this:
Is this the problem with the mod or the outdated texture pack, or something else?

With near view distance:

I have a similar issue. You can see when the leaves becomes nicer when the resource pack is activated as it only works wehn you're pretty close.

Yep, Motschen was right, disabling "Use Block Face Culling" fixed the problem
Should have look around the settings first


current install conflicts with Visual Studio2022 17.10

Just like as it is written on the title. I had problem installing this 3Dpack.
First problem occurred when installing with miniconda. It had conflicting xformers and torch versions. I resolved it by manually installing them in the miniconda env.
Next problem occurred when I received the message corecrt.h was missing.
I went on and installed C++ build environment with windows10 CRT SDK. the problem persisted. Infact, I wasn't able to progress anyfurther, and was stuck for about a week.
I tried again by completely removing Visual Studio and did a clean install. Now, the installation says my version of Visual Studio 2022 17.10 is not supported.
I can't seemed to rollback to 17.08 and I am stuck.
Does anyone have similar issue?

  Only the versions between 2017 and 2022 (inclusive) are supported! The nvcc flag '-allow-unsupported-compiler' can be used to override this version check; however, using an unsupported host compiler may cause compilation failure or incorrect run time execution. Use at your own risk.
getting lists and lists of these reports

an update. I managed to download previous visual studio version from

Still saying no corecrt.h....

here are the settings for Visual Studio install.
Any ideas?

i made some progress, i no longer get corecrt.h error. i had to full unisntall windows and start from scratch.
now i am getting complier error.
warnings.warn(f'Error checking compiler version for {compiler}: {error}')
i tried  using python 3.11.5 and 3.11.9

I'm using 17.9 without any problem. Can you try installing a few more packages from VS

Hello! thanks for the comment. Something required me so I was away for a bit. I am back. I have installed 1.17.9 like you have asked. will return after some tinkering!

resolved after updating the new 3dpack! Thanks!


Corrected Selecting Azure Resource Manager Subscription

Corrected syntax to use Select-AzureRMSubscription otherwise the subscription does not get picked up in the context of Resource Manager and will default to whatever subscription is selected when using Select-AzureSubscription.  Problematic when you have multiple subscriptions.

Hi @RezaMahmood, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no contribution license agreement is required at this point. Real humans will now evaluate your PR.

TTYL, AZPRBOT;

@cynthn - Could you please review this public repo update from @RezaMahmood?

@tysonn I don't think this change applies anymore. The topic was recently updated and the change has already been made in the text. I think this is why there is also a merge conflict for this change?

OK. That is likely why there are merge conflicts. @RezaMahmood - thanks for the update, I apologize for the delay in review. It sounds like this was fixed already, so I'm closing the PR.


Use O(1)-time search

This commit significantly speeds up setup time. I have 84 custom
mappings, and after this commit vim's startup takes 100ms less
(~170ms -> 70ms).
Previous implementation used linear search to find identifier collisions
and defined mappings. This led to quadratic complexity and every new
mapping extended start up even more. The new implementation uses
identifiers as keys, which makes the search constant in time.
This commit also cleans up some idioms, e.g., changes
for i, _ in table do f(table[i]) end to just
for _, v in table do f(v) (the latter being slightly faster as we
avoid the table lookup).

Nice improvement, thanks !


Transparent textures

Transparents textures are currently not supported and their transparent parts are rendered as black.

done !


When enabling custom logo, url shows in wrong place in settings view

Bug description
When you select to use a custom logo, the Url input renders under the analytics setting rather than under the logo setting
Expected behavior
Show the logo url input under the logo setting
Steps to reproduce the issue:

Go to settings
Click on use custom logo
See the the URL input for the logo renders underneath the telemetry setting rather than under the logo setting

Technical details:

Portainer version: 2.0
Docker version (managed by Portainer): 19.03.12
Platform (windows/linux): Linux
Command used to start Portainer (docker run -p 9000:9000 portainer/portainer): docker run
Browser: FireFox

Hey
I was able to reproduce the error.
I am working on it.


Multiplayer Explained Issue on Alpha 12

Hi Mitch, I'm attempting to run through the networking tutorial that you created and having trouble with running the .bat files in windows. I modified it accordingly but I'm getting these errors when running it.
"C:\Program Files\Godot\Godot_v4.0-alpha12_win64.exe" --path .\Multiplayer\ --server --headless

Godot Engine v4.0.alpha12.official.2c11e6d9e - https://godotengine.org

WARNING: res://Characters/Aliens/Player.tscn:3 - ext_resource, invalid UUID: uid://yro4ypo6sek5 - using text path instead: res://Characters/Aliens/Blue/BlueSpriteFrames.tres
     at: load (scene/resources/resource_format_text.cpp:440)
WARNING: res://Characters/Aliens/Blue/BlueSpriteFrames.tres:3 - ext_resource, invalid UUID: uid://xjnyqosqdmw1 - using text path instead: res://Characters/Aliens/Blue/alienBlue_walk1.png
     at: load (scene/resources/resource_format_text.cpp:440)
ERROR: Unable to open file: res://.godot/imported/alienBlue_walk1.png-977551bdfe3f92f98b7269f8ed7e31ba.ctex.
   at: (scene/resources/texture.cpp:822)
ERROR: Failed loading resource: res://.godot/imported/alienBlue_walk1.png-977551bdfe3f92f98b7269f8ed7e31ba.ctex. Make sure resources have been imported by opening the project in the editor at least once.
   at: (core/io/resource_loader.cpp:205)
ERROR: Failed loading resource: res://Characters/Aliens/Blue/alienBlue_walk1.png. Make sure resources have been imported by opening the project in the editor at least once.
   at: (core/io/resource_loader.cpp:205)
ERROR: res://Characters/Aliens/Blue/BlueSpriteFrames.tres:3 - Parse Error: [ext_resource] referenced nonexistent resource at: res://Characters/Aliens/Blue/alienBlue_walk1.png
   at: load (scene/resources/resource_format_text.cpp:478)
ERROR: Failed loading resource: res://Characters/Aliens/Blue/BlueSpriteFrames.tres. Make sure resources have been imported by opening the project in the editor at least once.
   at: (core/io/resource_loader.cpp:205)
ERROR: res://Characters/Aliens/Player.tscn:3 - Parse Error: [ext_resource] referenced nonexistent resource at: res://Characters/Aliens/Blue/BlueSpriteFrames.tres
   at: load (scene/resources/resource_format_text.cpp:478)
ERROR: Failed loading resource: res://Characters/Aliens/Player.tscn. Make sure resources have been imported by opening the project in the editor at least once.
   at: (core/io/resource_loader.cpp:205)
ERROR: Parser bug (please report): tried to assign unset node without an identifier.
   at: resolve_class_interface (modules/gdscript/gdscript_analyzer.cpp:656)
SCRIPT ERROR: Parse Error: Could not preload resource file "res://Characters/Aliens/Player.tscn".
          at: GDScript::reload (res://System/main.gd:4)
SCRIPT ERROR: Parse Error: Cannot use simple "@export" annotation because the type of the initialized value can't be inferred.
          at: GDScript::reload (res://System/main.gd:3)
ERROR: Method/function failed.  Make sure resources have been imported by opening the project in the editor at least once.
   at: (core/io/resource_loader.cpp:205)
ERROR: Failed loading resource: res://Maps/tiles_spritesheet.png. Make sure resources have been imported by opening the project in the editor at least once.
   at: (core/io/resource_loader.cpp:205)
ERROR: res://Maps/Tileset.tres:3 - Parse Error: [ext_resource] referenced nonexistent resource at: res://Maps/tiles_spritesheet.png
   at: load (scene/resources/resource_format_text.cpp:478)
ERROR: Failed loading resource: res://Maps/Tileset.tres. Make sure resources have been imported by opening the project in the editor at least once.
   at: (core/io/resource_loader.cpp:205)
ERROR: res://Maps/TestMap.tscn:3 - Parse Error: [ext_resource] referenced nonexistent resource at: res://Maps/Tileset.tres
   at: load (scene/resources/resource_format_text.cpp:478)
ERROR: Failed loading resource: res://Maps/TestMap.tscn. Make sure resources have been imported by opening the project in the editor at least once.
   at: (core/io/resource_loader.cpp:205)
ERROR: res://System/main.tscn:4 - Parse Error: [ext_resource] referenced nonexistent resource at: res://Maps/TestMap.tscn
   at: load (scene/resources/resource_format_text.cpp:478)
ERROR: Failed loading resource: res://System/main.tscn. Make sure resources have been imported by opening the project in the editor at least once.
   at: (core/io/resource_loader.cpp:205)
ERROR: Failed loading scene: res://System/main.tscn
   at: (main/main.cpp:2669)
ERROR: Condition "_first != nullptr" is true.
   at: ~List (./core/templates/self_list.h:106)
ERROR: Condition "_first != nullptr" is true.
   at: ~List (./core/templates/self_list.h:106)
ERROR: 1 RID allocations of type 'P11GodotBody3D' were leaked at exit.
ERROR: 1 RID allocations of type 'P11GodotArea3D' were leaked at exit.
ERROR: 1 RID allocations of type 'P12GodotSpace3D' were leaked at exit.
ERROR: 1 RID allocations of type 'P11GodotArea2D' were leaked at exit.
ERROR: 1 RID allocations of type 'P12GodotSpace2D' were leaked at exit.
ERROR: 2 RID allocations of type '6NavMap' were leaked at exit.
ERROR: 1 RID allocations of type 'N18RendererCanvasCull6CanvasE' were leaked at exit.
ERROR: 1 RID allocations of type 'N16RendererViewport8ViewportE' were leaked at exit.
ERROR: 1 RID allocations of type 'PN13RendererDummy14TextureStorage12DummyTextureE' were leaked at exit.
ERROR: 1 RID allocations of type 'N17RendererSceneCull8ScenarioE' were leaked at exit.
WARNING: ObjectDB instances leaked at exit (run with --verbose for details).
     at: cleanup (core/object/object.cpp:1918)
ERROR: Resources still in use at exit (run with --verbose for details).
   at: clear (core/io/resource.cpp:474)

I assume it is something that I'm doing incorrectly, but wanted to make sure?

I've just tried checking out and running it on another computer and it seems to be working fine for me.
Are you sure you've opened the project with the editor at least once before trying to run it with the batch file? - I'm not sure if it's necessary to run the project from the editor once first, but that's something I did.
Failing that, you might need to delete all the *.import files, then open the editor again to force it to reimport everything.

Thank you Mitch. I tried your solution which lead me to my issue. I had copied "Multiplayer" folder out of my downloads folder, but not the .bat files :(. So I was running the .bat files from the downloads folder which where refencing the "Multiplayer" games files in the downloads folder as you and the error indicated.. I apologize for my mistake. Thank you for helping me resolve it and for your tutorial. I could not get multiplayer working without you honestly. So I greatly appreciate your tutorials and help.


fixes type for MithrilControllerFunction

MithrilControllerFunction, as used in MithrilComponent, is not a
controller itself, but a function returning a controller. The current
documentation also allows the controller function to be
called with an attributes object and additional arguments. This was not
reflected in the corresponding TypeScript type.

@opax Ping...

Closing, as I'm working on a better, more up-to-date solution in #992.


Turn on quiz rendering in config_automation.yml

Purpose/implementation Section
@carriewright11 mentioned her quizzes weren't being converted. That is because we haven't turn on quizzes in this repo. This PR will do that:

just for context, I thought the coursera rendering did that


docs: change quote to blockquote

What I did

Changed "quote" and "block quote" to "blockquote" on its component page, the All components page, and the Typography page

Testing Instructions

Notes to Reviewers

@marionnegp I gave you feedback to make these changes in another PR, please disregard.


Add parameter for db schema

WHAT
Add a parameter to specify the database schema to be used by the postgresql migration extension.
WHY
As mentioned here: https://github.com/eclipse-tractusx/tractusx-edc/issues/311
Some users might not use the default schema.
FURTHER NOTES
Could not find documentation of existing parameters, thus did not add this parameter. e2e-tests successful.
Closes #311
Brendan Cronin<EMAIL_ADDRESS>Mercedes-Benz Tech Innovation GmbH, legal info/Impressum

I'd like a bit of guidance on this. Getting the schema migration to correctly run is no problem. But the tests also use the upstream EDC postgres extension, which afaik doesn't support configuration of a different schema. Any ideas? @DominikPinsel @wolf4ood

Should probably be documented somewhere here:
https://github.com/eclipse-edc/Connector/blob/8e05ee0fb40b59685832ea7032512dbfde6a06ec/extensions/control-plane/store/sql/asset-index-sql/README.md?plain=1#L41
Not sure where else to look.

@bcronin90  you should be able to provide the schema with connections parameter in the JDBC url (didn't try it)
https://jdbc.postgresql.org/documentation/use/#connection-parameters

I'll try that, thanks. ---- On Mi, 07 Jun 2023 12:02:39 +0200  @.***  wrote ----
@bcronin90  you should be able to provide the schema with connections parameter in the JDBC url (didn't try it)
https://jdbc.postgresql.org/documentation/use/#connection-parameters
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

@wolf4ood Feel free to merge. I don't have the rights.


Telnet-Robot Framework

In GNS3, i configured 2 routers & 1 host & i am able to ping from each other. So how can i excute this setup in Robot framework using python script [using Telnet library]. Please suggest me iam new to this Robot Framework .
In Advance,
Thank you

This issue tracker is for enhancements and bug reporting of Robot Framework. Your question is better suited for the Robot Framework user group

Ok Tattoo, Thank you


update second year in copyright notice

Description

Related issue and scope

[ ] I opened an issue to propose and discuss this change (#????)

My changes affect the following components

[ ] API
[ ] Controller
[ ] Message Bus (e.g., Kafka)
[ ] Loadbalancer
[ ] Invoker
[ ] Intrinsic actions (e.g., sequences, conductors)
[ ] Data stores (e.g., CouchDB)
[ ] Tests
[ ] Deployment
[ ] CLI
[ ] General tooling
[ ] Documentation

Types of changes

[ ] Bug fix (generally a non-breaking change which closes an issue).
[ ] Enhancement or new feature (adds new functionality).
[ ] Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

[ ] I signed an Apache CLA.
[ ] I reviewed the style guides and followed the recommendations (Travis CI will check :).
[ ] I added tests to cover my changes.
[ ] My changes require further changes to the documentation.
[ ] I updated the documentation where necessary.

Codecov Report

Merging #4292 into master will decrease coverage by 4.67%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4292      +/-   ##
==========================================
- Coverage   85.75%   81.07%   -4.68%
==========================================
  Files         163      163
  Lines        7594     7594
  Branches      502      502
==========================================
- Hits         6512     6157     -355
- Misses       1082     1437     +355

Impacted Files
Coverage Δ

...core/database/cosmosdb/RxObservableImplicits.scala
0% <0%> (-100%)
:arrow_down:

...core/database/cosmosdb/CosmosDBArtifactStore.scala
0% <0%> (-95.18%)
:arrow_down:

...sk/core/database/cosmosdb/CosmosDBViewMapper.scala
0% <0%> (-92.6%)
:arrow_down:

...whisk/core/database/cosmosdb/CosmosDBSupport.scala
0% <0%> (-84.62%)
:arrow_down:

...abase/cosmosdb/CosmosDBArtifactStoreProvider.scala
4% <0%> (-52%)
:arrow_down:

...in/scala/org/apache/openwhisk/common/Counter.scala
40% <0%> (-20%)
:arrow_down:

...nwhisk/core/database/cosmosdb/CosmosDBConfig.scala
93.75% <0%> (-6.25%)
:arrow_down:

...whisk/connector/kafka/KafkaProducerConnector.scala
87.5% <0%> (+15%)
:arrow_up:

.../scala/org/apache/openwhisk/utils/Exceptions.scala
40% <0%> (+20%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cc6ab4...2faebd6. Read the comment docs.


log add log for test file read write

Proposed changes
Issue Number: close #xxx
Problem summary
When meeting this error:
store read/write test file occur IO Error. path=/mnt/doris.SSD

We don't know the error reason.
Add a log for it.
Checklist(Required)

[ ] Does it affect the original behavior
[ ] Has unit tests been added
[ ] Has document been added or modified
[ ] Does it need to update dependencies
[ ] Is this PR support rollback (If NO, please explain WHY)

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


Enable additional HELM Features on AKS add-on or enable deployment through HELM when using custom routing tables

Is your feature request related to a problem? Please describe.
By being restricted to deploy AGIC using AKS add-on only, we also could not use full features available on helm configuration. To mention one example:

Deploy only one Application Gateway, as mentioned in the AKS Add-on: “Customers can only deploy one AGIC add-on per AKS cluster, and each AGIC add-on currently can only target one Application Gateway.”

For more information see, Difference between Helm deployment and AKS Add-On
Describe the solution you'd like
Ask: Enable additional Helm features on AKS add-on (like have more application gateways for one AKS) or enable deployment through Helm for Application Gateway in case custom routing tables are used.

Currently, this is by design. We will consider this as a feature request and prioritize based on our backlog.


Addinvoice lacks hope hint if last public channel is pendingclose

I tried closing my last public channel while I still had one private. I created a new invoice and no hint was included. That makes it impossible to receive payments while the channel is closing since the sender won't be able to find a path to my node.
Once the closing channel got confirmed on-chain, addinvoice started including hop_hints again.
lnd version 0.8.0-beta commit=v0.8.1-beta

Are you sure the channel had enough inbound bandwidth for the payment?

Add invoice without any parameter doesn’t assume a min payment size, right?
I simply called lncli addinvoice in both cases.

You can see why the channel is being skipped if you run lncli debuglevel --level=IRPC=debug and try creating the invoices again.
Was the private channel peer offline when you tried the first invoice?

Seems like I can't reproduce...
No I don't think it was offline

No I don't think it was offline

You can cross-check your logs to see timestamps of when the corresponding peer connected/disconnected and when the invoice was created.


Missing pool id after pool import leads to recreating the pool

After importing an existing pool, the resource is missing the poolId paramaeter.
On the first pulumi up, tries to recreate the imported pool because it detects the difference between the empty pool id and the real one on the Proxmox server.
Aftter the pool import, the following warning can be seen:

this provider is based on the terraform provider (https://github.com/bpg/terraform-provider-proxmox), and actually only wraps its functions for pulumi. did you verify if this issue also exists when directly using the terraform provider?

Hi, thanks for the feedback.
I just checked it and the problem is present in the TF provider too.
I created an issue there:
https://github.com/bpg/terraform-provider-proxmox/issues/963

upstream fixed released with Pulumi provider version v5.23.0.


Link colors flicker when updating cells in high frequency

Hi,
I set the colors of my text chat bubbles in this function:
override func collectionView(collectionView: UICollectionView, cellForItemAtIndexPath indexPath: NSIndexPath) -> UICollectionViewCell like this:
if let textView = cell.textView {
            textView.textColor = UIColor.whiteColor()
            textView.linkTextAttributes = [NSForegroundColorAttributeName:myColor, NSUnderlineStyleAttributeName: NSUnderlineStyle.StyleThick.rawValue,
                NSUnderlineColorAttributeName: mycolor];
        }

However, in situations where I load multiple images for image cells and refresh the collectionview each time an image has finished downloading, I can observe a flickering of the links in the text view. It flickers between having the default text color and the color I specify for links.
I am not entirely sure if this has something to do with JSQMessagesViewController, but I didn't find anything using google, so I thought I'd ask here.
Thanks for your time,
Philipp

Has anyone found a fix yet?

I have the same issues, anyone solved this?

Hello everyone!
I'm sorry to inform the community that I'm officially deprecating this project. 😢 Please read my blog post for details:
http://www.jessesquires.com/blog/officially-deprecating-jsqmessagesviewcontroller/
Thus, I'm closing all issues and pull requests and making the necessary updates to formally deprecate the library. I'm sorry if this is unexpected or disappointing. Please know that this was an extremely difficult decision to make. I'd like to thank everyone here for contributing and making this project so great. It was a fun 4 years. 😊
Thanks for understanding,
— jsq


[html] CSS and JS autocomplete not working inside style and script tags respectively in html file

VSCode Version: 1.3.0
OS Version: Windows 10 x64

Steps to Reproduce:

Create a .html file and create style tag.
CSS autocompletion only works on .css file but not working inside style tag of a .html file.
Within a .html file only HTML related auto completion will work.

Same situation.

Same here!

Same situation.

Version: 1.3.1
Same situation.

Hi,
I have a new extension which works for style tags and attributes. Also completes class attributes:
https://github.com/ecmel/vscode-html-css
I used https://github.com/Microsoft/vscode-css-languageservice for language intelligence.
From the experience gathered while writing the extension, in my opinion, vscode html support should be refactored and give html intelligence from the vscode.extension api to allow further extensions leverage the underlying html document.

Thank you!!! Your extension really helps me a lot. It works great! And I have a few questions to ask：

I find that the CSS color decorators attached to color values inside style tags in html files seem not working in vscode 1.3. May your extension help fix this problem in future updates?
If there is any possibility to fix the JS autocomplete problem inside script tags in html?
Thanks again.

在 2016年7月17日，23:19，ecmel<EMAIL_ADDRESS>写道：
Hi,
I have a new extension which works for style tags and attributes. Also completes class attributes:
https://github.com/ecmel/vscode-html-css
I used https://github.com/Microsoft/vscode-css-languageservice for language intelligence.
From the experience gathered while writing the extension, in my opinion, vscode html support should be refactored and give html intelligence from the vscode.extension api to allow further extensions leverage the underlying html document.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

Any progress in fixing this?

Sorry for the delay but there is some major rework behind this:

the CSS completion support was lost when we extract the CSS support into a language server. The plan is to also extract the HTML support into a language server as well that then leverages the CSS language server. This will likely take more than one iteration.
we will work with the typescript team on support Intellisense inside JS script tags. We will start on this during August.

@egamma Thanks for the update.

Not see the prompt in Html file write the javascript

I want to vscode add the javascript prompt in the html file

Version: 1.5.1
Same situation, waiting...

JS doesnt work in HTML document~~

No reason for me to switch from the old version(0.10.6) until this is fixed...

Also, keyboard shortcuts don't seem to work.
For example, if I use the shortcut to add a line comment, <!-- --> is stamped on the page instead of //.

@doplumi The new release 1.6.0 just broke the vscode commenting. Try revert back to 1.5.3 and turn off the auto update.

@motss Still an issue on 1.6.1. What's the easiest way to downgrade, keeping all of the settings & snippets?

What OS you using?
On Sat, Oct 15, 2016, 1:12 AM doplumi<EMAIL_ADDRESS>wrote:

@motss https://github.com/motss Still an issue on 1.6.1. What's the
easiest way to downgrade, keeping all of the settings & snippets?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/vscode/issues/8928#issuecomment-253863056,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AKHcjyiNuGJ9rEXMIMTJR1u-RZuDdB1hks5qz7fbgaJpZM4JH62k
.

CSS (styles) in HTML is now implemented, JS still needs to be done.
We will use https://github.com/Microsoft/vscode/issues/3465 for that.
Note that smart editing functionalty (comments, smart indent) is https://github.com/Microsoft/vscode/issues/11081

ecmel's terrific plugin works for HTML css support, but not in PHP files,
anyone know of a way to add CSS intellisense to PHP?