browserify form-data is not possible anymore

It is not possible to browserify form-data anymore. The version rc1 worked.

Thanks for the report. Is it erroring out? Care to provide the error?

./node_modules/.bin/browserify --ignore mime --ignore compress -t cssify -t jadeify -t brfs test/views/stats.js -o public/scripts/views/test/stats.js
.../node_modules/request/node_modules/form-data/lib/browser.js:1
(exports, require, module, __filename, __dirname) { module.exports = FormData;
^
ReferenceError: FormData is not defined
at Object. (/.../node_modules/request/node_modules/form-data/lib/browser.js:1:80)
at Module._compile (module.js:456:26)
at Object.Module._extensions..js (module.js:474:10)
at Module.load (module.js:356:32)
at Function.Module._load (module.js:312:12)
at Module.require (module.js:364:17)
at require (module.js:380:17)
at nr (/.../node_modules/browserify/node_modules/module-deps/index.js:282:21)
at /.../node_modules/browserify/node_modules/module-deps/index.js:273:21
at onfile (/.../node_modules/browserify/node_modules/resolve/lib/async.js:51:21)

@DylanPiercey you have more experience with browserify and looks like it's related to your fix.

The current browser shim just exposes native formdata.@Ockejanssen Whats the purpose of using the browserified version of the node module?
To prevent this error we return a noop if the browser does not support formdata. (In the future we can provide a polyfill).

I just browserify the request module which uses form-data.

@Ockejanssen I don't know that using request with browserify is a practical use case. The file it generates is upward of 400kb (Just for ajax seems a bit absurd).
Currently we are working on turning this library into an isomorphic polyfill of sorts for the native form-data and as such the "browserified" version of this module simply returns the native module. I think that rather than encouraging browserifying modules not meant for the browser it would be best if request was modified to support the native form data module when run in the browser. I have no idea what opinions the owners of request have on isomorphic javascript but I could perhaps create a couple pr's to make this a reality.
If this is a real concern with a practical use case I would love to hear it and could be swayed to create a work-around.
If you are actually looking for an isomorphic solution I would check out "isomorphic-fetch" which works great with this module.

@DylanPiercey our browserify tests are passing, although they are pretty basic. As for whether it's practical or not - if it was working up until now, and currently it's not, without a major release, then that's a bug that should be dealt with.
If you think that a small fix in request will do, I'm fine with it. I'm only concerned with adding ever more dependencies there. Request is also going to be refactored into more modular code base at some point, so once that happens handling such edge cases won't be a problem, because not everyone will install/load the multipart related logic in the first place.

@alexindigo I think we can remove this in favor of https://github.com/form-data/isomorphic-form-data.

@DylanPiercey I'd prefer to keep for those who doesn't want/can't do different packages in the browser/server and/or have third+ level dependency.
Although I'm yet fully understand logic behind Browserify's bundler. So if you and @simov think we'd be better of without it, I'm down.

Spring cleaning here. Seems like it's no longer an issue, or doesn't produce a lot of interest. I'll close it for now. Let me know if it's still a concern. Thanks.


Add feature "subtract fee from amount" when completing a transactions

We need to add a useful feature of "subtract fee from amount" when completing a transaction.

 Add feature "subtract fee from amount" when completing a transactions


Added the possibility for the module to ignore some tokens

My players prefer to use health bars for themselves and the tint was adding visual clutter on their tokens.
I also thought it would be a nice option, since some modules may use tokens to represent other things that are not creatures and use HP value to control for some values.

Nice idea, I will merge this in once I get the chance to do some testing on it. I also might look into how hard it would be to bundle the macros into the module so that they show up as a compendium.
Unfortunately I am a very busy at the moment, so I won't get the chance to do this for a few days, but when I do I will merge this and then make a new release in Foundry.


dial tcp <IP_ADDRESS>:80: connect: connection refused error while upgrade the module from 17.x to 18.x

Description
We are upgrading the EKS module from 17.x to 18.x and we have self managed nodes. We have cleaned up the statefile by removing  the module.eks_cluster.local_file.kubeconfig and module.eks_cluster.kubernetes_config_map.aws_auth references since18.x version doesn't manage the kubeconfig and aws_auth.
As we are creating the kubernetes resources like secrets, configmaps in the same state as we are creating the cluster, we have configured the kubernetes provider block. But kuberenetes provider is not able to talk to the cluster and the terraform plan is failing with the error Error: Get "http://localhost/api/v1/namespaces/kube-system/secrets/git-credentials": dial tcp <IP_ADDRESS>:80: connect: connection refused
We did not face such issue when we used the 17.x version of eks module
Versions

Terraform: 1.0.0

Provider(s):

   kubernetes = {
      source  = "hashicorp/kubernetes"
      version = ">=2.1.0"
    }

Module:

module "eks_cluster" {
  source  = "terraform-aws-modules/eks/aws"
  version = "18.2.4"
  ...
}

Code Snippet to Reproduce
provider "kubernetes" {
  host                   = data.aws_eks_cluster.cluster.endpoint
  cluster_ca_certificate = base64decode(data.aws_eks_cluster.cluster.certificate_authority.0.data)
  token                  = data.aws_eks_cluster_auth.cluster.token
}

data "aws_eks_cluster" "cluster" {
  name = module.eks_cluster.cluster_id
}

data "aws_eks_cluster_auth" "cluster" {
  name = module.eks_cluster.cluster_id
}

resource "kubernetes_secret" "git_credentials" {
  metadata {
    name      = "git-credentials"
    namespace = local.k8s_kube_system_namespace
  }
  data = {
    username = "git"
    password = data.aws_ssm_parameter.flux_token.value
  }
  type = "kubernetes.io/basic-auth"
}

Expected behavior
Terraform plan should be able to successfully list the resources to the added/modified/destroyed
Actual behavior
Tearraform plan is failing with the error
Error: Get "http://localhost/api/v1/namespaces/kube-system/secrets/git-credentials": dial tcp <IP_ADDRESS>:80: connect: connection refused
Terminal Output Screenshot(s)

Additional context
When we are setting the TF_LOG to DEBUG, we are able to see the detailed logs from the aws provider, where as the kubernetes provider is not showing any detailed logs.

unfortunately this is outside the scope of the module. due to the number of issues and wide ranging configurations, the management of aws-auth/kubeconfig was removed from the module


Be able to use env file

It would be useful to be able to load an env file (similar to https://github.com/microsoft/vscode-go/issues/829). For example my package managment system (Conan) generates and en file. It would be easier for me to just point to this file than manually duplicate the content and update it whenever my dependencies change.
Note: it would probably be better if this can be a list of files. For example Conan can generate two environment files, both of which might be required to be activated at runtime.

I could use a PR for this one.   Probably can be done similarly to the go extension.    Though I think that "env" entries should override the ones in envfile.   I am also not sure whether they've implemented file parsing correctly (or even what the format of that file is).   Finally, please don't forget about Windows, where environment is case-insensitive.  This class is designed to handle all that.

Implemented in v1.9.1


dwarven pickaxe is unequippable & provides no boost

🐛 Bug Report
In BSO, the dwarven pickaxe cannot be equipped and provides no boost to mining (or is overridden by 3rd age pickaxe maybe? unsure). I expect this also occurs with other dwarven equipment however I cannot confirm as I do not have them. I do not know if it providing no boost is the same bug or even if that's unintentional.

Same root as #653
#664 Fixes both these issues

Both issues have now been fixed. I still can't test other equipment since I don't have em but if they were broken I expect they're also fixed now.


Middleware registered in plugins is never executed

Environment
nitropack v0.5.4, no extra config
Reproduction
Given the following plugin:
// plugins/test.ts
export default defineNitroPlugin(nitroApp => {
    nitroApp.h3App.use('/', () => console.log('Middleware ran'))
    console.log('Plugin registered')
})

The plugin appears to register correctly ('Plugin registered' is printed), but the middleware added with h3App.use is never executed ('Middleware ran' is never printed when navigating to any route).
Describe the bug
Any middleware added inside a nitro plugin with nitroApp.h3App.use or other related methods is never executed.
This might be an intentional / known limitation of how plugins work, but it feels unexpected, given that the method throws no error and is readily accessible.
Additional context
No response
Logs
No response

See https://github.com/unjs/nitro/pull/302 and https://github.com/nuxt/framework/issues/5527#issuecomment-1160789814.

Those issues appear to be about adding new routes, not middleware. Unless there is some way to add middleware directly to the router that I'm unaware of, I don't really get why this issue was closed.

I spent all day to figure out how to add middleware via module and didn't find a solution. The problem is actual.

Hello,
Does anyone have a way to add a middleware to nitro yet?
Have a great day.

This worked for me
export default defineNitroPlugin(nitroApp => {
  nitroApp.h3App.stack.unshift({
    route: "/",
    handler: () => {
      console.log('middlware ran');
    },
  });
})

./server/plugins/code.ts
export default defineNitroPlugin(async nitroApp => {
    const handler = await createWebhook();

    nitroApp.h3App.stack.unshift({
        route: '/',
        handler: fromNodeMiddleware(handler),
    });
});

This worked for me
export default defineNitroPlugin(nitroApp => {
  nitroApp.h3App.stack.unshift({
    route: "/",
    handler: () => {
      console.log('middlware ran');
    },
  });
})

I suppose that works, but it reverses the intuitive order - middlewares that are registered first are now run after middlewares registered later.

Thank you for providing a way to solve this. I had been searching for a solution all day.

I need to catch a route like /@:username/ and bypass all not starting with @.
Does nitro provide something like event.next()? to continue the route matching?

I need to catch a route like /@:username/ and bypass all not starting with @.

Supporting paterns in same segment of routes will be coming with next major version of h3/radix3/nitro to allow this 🤞🏼

Generally please avoid modifying nitroApp.h3App.stack, it is unsafe and error-prune and usually the routing patterns could be designed better to avoid requiring workarounds like this. if you have any questions feel free to use Discussions 🙏🏼

@FeldrinH No and you should not register middleware inside a runtime plugin (it is unstable and unpredictable). Middleware should be registered via  server/middleware directory or [{ middleware: true, handler: 'path to handler' }] from configuration to register middleware.
There is a new way of using hooks (request, beforeResponse and afterResponse) which request runs before any other middleware.
export default defineNitroPlugin(nitroApp => {
  nitroApp.hooks.hook('request', (event) => {})
  nitroApp.hooks.hook('afterResponse', (event) => {})
})

Please use Discussions if you have a case that would not be solved with hooks either.

Fair enough


Updated the tables.py to make the column names uniform.

Updated the columns in tables.py to correct the case so that text was uniform from one column to another.

I firmly suspect this test will fail, because the requirements.txt has not been updated yet.  Please re-run test after the requirements.txt PR is merged.

Merged manually. Thanks for the prs!


Update requirements-linting.txt to add flake8-pytest-style

Description
Add flake8-pytest-style to catch any pytest style issues.
Areas changed

npm packages changed:

[ ] responsibleai/causality
[ ] responsibleai/core-ui
[ ] responsibleai/counterfactuals
[ ] responsibleai/dataset-explorer
[ ] responsibleai/fairness
[ ] responsibleai/interpret
[ ] responsibleai/localization
[ ] responsibleai/mlchartlib
[ ] responsibleai/model-assessment

Python packages changed:

[ ] erroranalysis
[ ] raiutils
[ ] raiwidgets
[ ] rai_core_flask
[ ] responsibleai

Tests

[x] No new tests required.
[ ] New tests for the added feature are part of this PR.
[ ] I validated the changes manually.

Screenshots (if appropriate):
Documentation:

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

Codecov Report

Merging #1296 (8849cf0) into main (88791b3) will increase coverage by 3.95%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1296      +/-   ##
==========================================
+ Coverage   86.36%   90.32%   +3.95%
==========================================
  Files          99       34      -65
  Lines        4569     1395    -3174
==========================================
- Hits         3946     1260    -2686
+ Misses        623      135     -488

Flag
Coverage Δ

unittests
90.32% <ø> (+3.95%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

responsibleai/responsibleai/_internal/__init__.py

...i/responsibleai/managers/counterfactual_manager.py

...bleai/responsibleai/_tools/causal/causal_result.py

...ponsibleai/responsibleai/_tools/causal/__init__.py

raiwidgets/raiwidgets/__init__.py

...onsibleai/responsibleai/managers/causal_manager.py

...bleai/responsibleai/_tools/causal/causal_config.py

raiwidgets/raiwidgets/cohort.py

responsibleai/responsibleai/_tools/__init__.py

responsibleai/responsibleai/_input_processing.py

... and 55 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88791b3...8849cf0. Read the comment docs.


\electrum_nmc-3.2.2-py3.5.egg - Not Connected

Traceback
Traceback (most recent call last):
File "site-packages\electrum_nmc-3.2.2-py3.5.egg\electrum_nmc\util.py", line 835, in run_with_except_hook
File "threading.py", line 862, in run
File "C:\Program Files (x86)\Electrum-NMC\electrum_nmc_plugins\trustedcoin\trustedcoin.py", line 381, in f
return func(self, *args, **kwargs)
File "C:\Program Files (x86)\Electrum-NMC\electrum_nmc_plugins\trustedcoin\trustedcoin.py", line 399, in request_billing_info
.format(billing_address, billing_info['billing_address']))
Exception: unexpected trustedcoin billing address: expected N1S1QpNZWhUuytVeXZx14716CbWCozJAZ3, received 15reDAsabKPMTMF9FkdRqarBUN79uT1eLk
Additional information
Electrum version: 3.2.2
Operating system: Windows-7-6.1.7601-SP1
Wallet type: 2fa
Locale: en_US

Closing in favor of https://github.com/namecoin/electrum-nmc/issues/111


Add styles

Added UIKit, updated some templates.  themed the site a bit.  commit comment has full details.

This PR does far more than the description suggests.
So far I've seen it updates the User model, adds a Settings model, rewrites the migrations, adds a flag to control if registration requires email verification, and vendors a copy of Codemirror...


Check comments come through from external gradebook items

Ensure the comments are coming through for the gradebook items that come from external sources, eg Assignments

Hi @steveswinsburg,
To confirm:
Assignments
When originating from the Assignments tool, comments (entered as instructor notes) are passed back to the GB. They are not editable within the GB.
When not originating from the Assignments tool (associated with existing GB item), comments are NOT passed back to the GB. They are editable within the GB, but do not get reflected within the Assignments tool.
Forums
Must be created in GB and then associated with Forum/Topic. Comments are passed back to the GB and are editable in both locations.
Tests & Quizzes
Must originate from T&Q. Comments are not passed back to the GB and are not editable within the GB.


Actionmode helper is not functioning properly

ActionModeHelper doesn't work as expected, it's really frustrating especially after I moved some of my activities to use FastAdapter and now I'm wasting a long time for simple functionality.

Could you provide some code and describe the behavior you don´t like.

The procedure of prelongclick listener and preclicklistener are not handling properly the chain of events or the idea of handling is not explained well at all.

@FabianTerhorst I'd be glad if you could help me with implementing the basic functionality of actionmode with fastadapter, thanks!

@EladKeyshawn you do not have to use the ActionModeHelper if it does not work as you expect. It's just a small helper to simplify things, but it is in no way necessary to implement a contextual actionbar


Issues with detrend='linear' in dft() killing kernel

I have two comments, the first of which is the main issue, while the second is a small, related note. I am currently running the most up-to-date xrft version from GitHub (version 0.2.2+1.g8b7e84e) on Pangeo Cloud.
(1)  I've been trying to use the 'linear' detrend option in dft() without success. (I created a sample notebook here on a subset of CESM data to illustrate this problem, which should be executable on Pangeo Cloud.) Whenever I use the 'linear' option, when using .load() to calculate the dft function, the cell runs for awhile (~15 minutes in my notebook example) and eventually kills the kernel without any warning or error messages. This does not seem to be an issue with running the computation with dask gateway, as I have had this problem running both with and without dask (and when trying to use dask gateway, the dashboard showed no activity the whole time). When running with detrend='constant' or detrend=None I don't have any errors and the function runs in under 10 seconds. I've looked at the xrft code a bit and it may have to do with the dask chunking, but I'm not sure at this point. I believe @navidcy has had similar problems.
(2) I just noticed today that I've been running the dft() function with detrend=True. This ran just fine, but also didn't raise any errors saying that 'True' is, in fact, not one of the options. I wonder if it makes sense to add a warning that any arguments that are not either 'constant' or 'linear' will be treated as 'None'? (I realize that this was entirely my mistake in not reading the xrft docs better, but since the 'window' flag does use 'True' it may be confusing for others as well.)
I would be happy to make a pull request for these issues if we see the need, but since I'm new to this community I might need a few tips from the more experienced developers out there!

Thanks for raising the issue. Upon looking at your example, it seems that you don't chunk your data in the lat/lon direction when taking the FFT. Could you try the linear option with smaller chunks and see if that works? I might be a memory issue.
As for your second point, I agree and raising a warning is probably a good idea.

Worth noting here that, since we implemented detrending, xarray has added support for polyfit, which is totally compatible with dask regardless of chunking. Therefore we should probably replace the internal implementation of detrending with the "official" xarray version.

Thanks @roxyboy for your response. I have tried using the linear flag with smaller chunks in the lat/lon direction with the same results. I'll note that without chunking in lat/lon the data array is only 16MB, so my understanding is that chunking more shouldn't be necessary with such a small data subset.
Looking a bit more at the code, it looks like the xrft.py function creates chunks of size 1 for all dimensions that are not being detrended. I don't understand why this is necessary, and I'm wondering if this might be causing some of the trouble? This chunking takes place on line 381 of xrft.py:

The result of the above lines can be seen in the screenshot below where the output from my dft() function results in a DataArray of size (400,500,11) with chunks of size (1,1,11).
Original DataArray before dft() function is applied:

DataArray after dft() function is applied:

I may well be off-the-mark here, but I did a quick test of applying the spicy.signal.detrend() function directly to the time dimension of my DataArray . With no chunks (as in the original DataArray shown above), the function runs in under 5 seconds. With lat/lon chunks of size 1, it ran successfully but took 17 minutes. (All of this was run without dask gateway.)
Or maybe using xarray's polyfit(), as @rabernat suggested, would solve this problem? Thanks for your help with this!

+1 here: I tried chunking spatial dimensions but problem persisted...

Ok, well in that case, instead of putting in the effort to try to make the detrend function work, I suggest we move on with implementing polyfit.

@roxyboy, I guess the idea is to use xarray.polyfit to find the linear tread and then subtract it from the data, right?
@paigem should we try to have a go at it and make a PR?

We would be very happy to walk you through the PR process.

Yes, let's make a PR, @navidcy!


SPA: use koa-connect-history-api-fallback

Current SPA mode doesn't work as desired with static assets.
When the requested file (containing dot chatacter, e. g. index.js) does not exist, it redirects to index.html instead of 404.
I suggest using koa-connect-history-api-fallback instead, which seems to be appropriate for such cases.
As it is described here, we need to place the historyApiFallback before the static handler.

very useful, thanks! released in version 1.2.2.
please add<EMAIL_ADDRESS>to your email list.. this email address is not yet registered with github so you do not show as a contributor.. after you add it, you will show on the contributor list.
if you have any more issues, let me know!


Typo

Typo
changed this timer to the timer

@Eldrick99 Thanks a bunch for contributing to our docs. We are overjoyed by the help we've been receiving from the community. 💟 This change cannot be accepted for the docs as it not a typo or a grammar error 💛
If you are looking for issues to get started with knowing how to contribute to the docs, checkout new issues and select the good first issue label. Check out this section of the contribution.md to know how to search for issues. You can open a discussion if you have any questions :sparkles:
Once again, thank you for your time in contributing to the GitHub docs 💜

Are you sure Can you please check again?

I tried saying the sentence twice with both words And I think mine sounded correct ..
But it's fine. I'll try another time


Segfault when reading from Python thread

The rapidgzip library crashes with a segfault if the first read/seek happens from a Python thread that isn't the same thread that called rapidgzip.open. If a read or seek is first done from the thread that opened it, no crash happens when subsequently calling read/seek from another thread.
from gzip import GzipFile
import os
from random import randbytes
from tempfile import NamedTemporaryFile
from threading import Thread

import rapidgzip

def create_temp_gzip_file(size_mb=2):
    with NamedTemporaryFile('wb', suffix='.gz', delete=False) as tf:
        with GzipFile(mode='wb', fileobj=tf, compresslevel=2) as gz:
            for _ in range(size_mb):
                gz.write(randbytes(1024*1024))
    return tf.name

def readfile(fd):
    data = fd.read(8)
    print(data)

if __name__ == '__main__':
    filename = create_temp_gzip_file(2)
    with open(filename, 'rb') as fd:
        with rapidgzip.open(fd) as gzip_fd:
            #readfile(gzip_fd) # no segfault if we read from main thread first
            t = Thread(target=readfile, args=[gzip_fd])
            t.start()
            t.join()
    print('done')
    os.unlink(filename)

Backtrace:
Thread 2 "python3" received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x7ffff63ff6c0 (LWP 1379959)]
_rpmalloc_heap_extract_new_span (heap=0x0, span_count=1, class_idx=<optimized out>, heap_size_class=<optimized out>) at external/rpmalloc/rpmalloc/rpmalloc.c:1834
1834	external/rpmalloc/rpmalloc/rpmalloc.c: No such file or directory.
#0  _rpmalloc_heap_extract_new_span (heap=0x0, span_count=1, class_idx=<optimized out>, heap_size_class=<optimized out>) at external/rpmalloc/rpmalloc/rpmalloc.c:1834
#1  0x00007ffff69fbd48 in _rpmalloc_heap_extract_new_span (class_idx=126, span_count=1, heap_size_class=0x0, heap=0x0) at external/rpmalloc/rpmalloc/rpmalloc.c:1820
#2  _rpmalloc_allocate_large (size=32896, heap=0x0) at external/rpmalloc/rpmalloc/rpmalloc.c:2213
#3  _rpmalloc_allocate (size=32768, heap=0x0) at external/rpmalloc/rpmalloc/rpmalloc.c:2268
#4  _rpmalloc_allocate (size=32768, heap=0x0) at external/rpmalloc/rpmalloc/rpmalloc.c:2261
#5  rpmalloc (size=32768) at external/rpmalloc/rpmalloc/rpmalloc.c:3052
#6  0x00007ffff6927f7b in RpmallocAllocator<unsigned char>::allocate (nElementsToAllocate=32768, this=0x7ffff63fe000) at core/FasterVector.hpp:50
#7  std::allocator_traits<RpmallocAllocator<unsigned char> >::allocate (__n=32768, __a=...) at /usr/include/c++/13/bits/alloc_traits.h:333
#8  std::_Vector_base<unsigned char, RpmallocAllocator<unsigned char> >::_M_allocate (__n=32768, this=0x7ffff63fe000) at /usr/include/c++/13/bits/stl_vector.h:378
#9  std::_Vector_base<unsigned char, RpmallocAllocator<unsigned char> >::_M_create_storage (__n=32768, this=0x7ffff63fe000) at /usr/include/c++/13/bits/stl_vector.h:395
#10 std::_Vector_base<unsigned char, RpmallocAllocator<unsigned char> >::_Vector_base (__a=..., __n=32768, this=0x7ffff63fe000) at /usr/include/c++/13/bits/stl_vector.h:332
#11 std::vector<unsigned char, RpmallocAllocator<unsigned char> >::vector (__n=32768, __a=..., this=0x7ffff63fe000) at /usr/include/c++/13/bits/stl_vector.h:554
#12 rapidgzip::deflate::DecodedData::getWindowAt (this=this@entry=0x7ffff0002c20, previousWindow=..., skipBytes=skipBytes@entry=2097152) at rapidgzip/DecodedData.hpp:413
#13 0x00007ffff69b91e1 in rapidgzip::GzipChunkFetcher<FetchingStrategy::FetchMultiStream, rapidgzip::ChunkData, false>::get (this=0x7ffff00010e0, offset=0) at /usr/include/c++/13/optional:306
#14 0x00007ffff69d3e41 in rapidgzip::ParallelGzipReader<rapidgzip::ChunkData, false>::read(std::function<void (std::shared_ptr<rapidgzip::ChunkData> const&, unsigned long, unsigned long)> const&, unsigned long) (this=this@entry=0xba1340, writeFunctor=..., nBytesToRead=nBytesToRead@entry=8) at rapidgzip/ParallelGzipReader.hpp:438
#15 0x00007ffff69d5044 in rapidgzip::ParallelGzipReader<rapidgzip::ChunkData, false>::read (this=0xba1340, outputFileDescriptor=-1, outputBuffer=<optimized out>, nBytesToRead=8)
    at rapidgzip/ParallelGzipReader.hpp:407
#16 0x00007ffff6904f12 in __pyx_pf_9rapidgzip_14_RapidgzipFile_14readinto (__pyx_v_bytes_like=<optimized out>, __pyx_v_self=0x7ffff747f110) at rapidgzip.cpp:14710
#17 __pyx_pw_9rapidgzip_14_RapidgzipFile_15readinto (__pyx_v_self=0x7ffff747f110, __pyx_args=<optimized out>, __pyx_nargs=1, __pyx_kwds=<optimized out>) at rapidgzip.cpp:14588
#18 0x000000000054e768 in ?? ()
#19 0x000000000054db12 in ?? ()
#20 0x0000000000511030 in ?? ()
#21 0x000000000054ce3f in PyObject_CallMethodObjArgs ()
#22 0x00000000006745ec in ?? ()
#23 0x000000000053308f in ?? ()
#24 0x0000000000505850 in PyObject_Vectorcall ()
#25 0x00000000004f627a in _PyEval_EvalFrameDefault ()
#26 0x0000000000525ed5 in _PyFunction_Vectorcall ()
#27 0x00000000004fa184 in _PyEval_EvalFrameDefault ()
#28 0x000000000054e402 in ?? ()
#29 0x000000000054db48 in ?? ()
#30 0x000000000063f714 in ?? ()
--Type <RET> for more, q to quit, c to continue without paging--
#31 0x000000000060d628 in ?? ()
#32 0x00007ffff7c97ada in start_thread (arg=<optimized out>) at ./nptl/pthread_create.c:444
#33 0x00007ffff7d2847c in clone3 () at ../sysdeps/unix/sysv/linux/x86_64/clone3.S:78

Please try reinstalling without rpmalloc support, like this:
export RAPIDGZIP_BUILD_RPMALLOC=disable; python3 -m pip install --force-reinstall 'git+https://github.com/mxmlnkn/indexed_bzip2.git@zlib-support#egginfo=rapidgzip&subdirectory=python/rapidgzip'

It works for me.

Confirmed - no crash for me when built without rpmalloc.

Should be fixed in 0.11.2.


Image loading race condition when image failed to load

Subject of the issue
sf::Image::loadFromFile can't be safely used from multiple threads on different image instances (each thread having its own sf::Image) if there was an error loading images (such as file not found).
Your environment

Arch Linux
git master
GCC 10.2.0

Expected behavior
It should be thread-safe to use different sf::Image instances in different threads.
Actual behavior
The program can crash when using sf::Image::loadFromFile from multiple threads on different image instances (each thread having its own sf::Image) if there was an error loading images (such as file not found) because stb which sf::Image uses has a global variable for the failure reason string (see: extlibs/headers/stb_image/stb_image.h:832) and sfml tries to print the global variable in src/SFML/Graphics/ImageLoader.cpp:127. Between the call to stbi_load and stbi_failure_reason another thread could be in the middle of writing to the failure reason global variable that stb uses, causing a crash in the error printing.
A crash from this happens occasionally in my program and since its a thread race condition I cant provide a reliable code example to reproduce the issue, but here is what valgrind --tool=helgrind complains about:
 542 ==860571== Possible data race during write of size 8 at 0x4916540 by thread #7
 543 ==860571== Locks held: none
 559 ==860571==    at 0x48AD188: stbi__err(char const*) (stb_image.h:841)
 560 ==860571==    by 0x48ADD97: stbi_load (stb_image.h:1135)
 561 ==860571==    by 0x48CB8D7: sf::priv::ImageLoader::loadImageFromFile(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::vector<unsigned char, std::allocator<unsigned char> >&, sf::Vector2<unsigned int>&) (ImageLoader     .cpp:104)
 562 ==860571==    by 0x48ABD2F: sf::Image::loadFromFile(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) (Image.cpp:125)

stb_image.h probably needs to be modified to use thread-safe error string to fix this issue

Good catch and thanks for the detailed description!
STB claims that their function stbi_failure_reason() is thread-safe, which I would interpret that also the writing part should be. In the sense that there should be no race condition on the failure string itself. Even then, it's still possible that this sequence happens:

thread A: stbi_load()
thread B: stbi_load()
thread A: stbi_failure_reason() -> returns error of image B

So I wonder why it crashes. Maybe we use an older STB version, it's not actually thread-safe, or there's another problem.
Conservatively,

It looks like that code you linked to is thread safe but not the version that sfml uses (see: https://github.com/SFML/SFML/blob/master/extlibs/headers/stb_image/stb_image.h#L410). I guess sfml just needs to update stb_image.h to fix it

I updated STB to the latest versions, could you check if the branch in pull request https://github.com/SFML/SFML/pull/1712 does not crash anymore?
Even then, we will probably need some more testing, as it's quite a big version bump.

Sure. The crash doesn't happen all the time so i'll keep the code running for 1 day or so and see if it crashes

Maybe we can also try to design a small application which makes it much more likely to happen.
E.g. two threads, each of which loads an image in a loop, and loading deliberately fails each time.

I created a small program to do that now:
sfml-crash.tar.gz
and compiled with g++ main.cpp -o test-sfml-crash -pthread /usr/local/lib/libsfml-graphics-d.so.2.5
and it crashes in another place in stb_image:
#0  0x00007ffff7a18615 in raise () from /lib/libc.so.6
#1  0x00007ffff7a01862 in abort () from /lib/libc.so.6
#2  0x00007ffff7a5a5e8 in __libc_message () from /lib/libc.so.6
#3  0x00007ffff7a6227a in malloc_printerr () from /lib/libc.so.6
#4  0x00007ffff7a626ac in munmap_chunk () from /lib/libc.so.6
#5  0x00007ffff7f6f024 in stbi__parse_png_file (z=0x7ffff72129d0, scan=0, req_comp=4) at /home/dec05eba/git/SFML/extlibs/headers/stb_image/stb_image.h:5062
#6  0x00007ffff7f6f399 in stbi__do_png (p=0x7ffff72129d0, x=0x7ffff7212c94, y=0x7ffff7212c98, n=0x7ffff7212c9c, req_comp=4, ri=0x7ffff7212abc) at /home/dec05eba/git/SFML/extlibs/headers/stb_image/stb_image.h:5120
#7  0x00007ffff7f6f5a1 in stbi__png_load (s=0x7ffff7212b20, x=0x7ffff7212c94, y=0x7ffff7212c98, comp=0x7ffff7212c9c, req_comp=4, ri=0x7ffff7212abc) at /home/dec05eba/git/SFML/extlibs/headers/stb_image/stb_image.h:5152
#8  0x00007ffff7f5c44a in stbi__load_main (s=0x7ffff7212b20, x=0x7ffff7212c94, y=0x7ffff7212c98, comp=0x7ffff7212c9c, req_comp=4, ri=0x7ffff7212abc, bpc=8) at /home/dec05eba/git/SFML/extlibs/headers/stb_image/stb_image.h:1094
#9  0x00007ffff7f5ca18 in stbi__load_and_postprocess_8bit (s=0x7ffff7212b20, x=0x7ffff7212c94, y=0x7ffff7212c98, comp=0x7ffff7212c9c, req_comp=4) at /home/dec05eba/git/SFML/extlibs/headers/stb_image/stb_image.h:1203
#10 0x00007ffff7f5ce35 in stbi_load_from_file (f=0x7ffff0000b60, x=0x7ffff7212c94, y=0x7ffff7212c98, comp=0x7ffff7212c9c, req_comp=4) at /home/dec05eba/git/SFML/extlibs/headers/stb_image/stb_image.h:1321
#11 0x00007ffff7f5cd9c in stbi_load (filename=0x555555573a00 "working-image.png", x=0x7ffff7212c94, y=0x7ffff7212c98, comp=0x7ffff7212c9c, req_comp=4) at /home/dec05eba/git/SFML/extlibs/headers/stb_image/stb_image.h:1311
#12 0x00007ffff7f7c3c2 in sf::priv::ImageLoader::loadImageFromFile (this=0x7ffff7fc72d0 <sf::priv::ImageLoader::getInstance()::Instance>, filename="working-image.png", pixels=std::vector of length 0, capacity 0, size=...) at /home/dec05eba/git/SFML/src/SFML/Graphics/ImageLoader.cpp:104

Also the same place with printing error still crashes, but this time its another issue that seems to be related to sf::Err?
[1] from 0x00007ffff7e629a1 in std::char_traits<char>::copy(char*, char const*, unsigned long)+25 at /build/gcc/src/gcc-build/x86_64-pc-linux-gnu/libstdc++-v3/include/bits/char_traits.h:395
[2] from 0x00007ffff7e629a1 in std::basic_streambuf<char, std::char_traits<char> >::xsputn(char const*, long)+81 at /build/gcc/src/gcc-build/x86_64-pc-linux-gnu/libstdc++-v3/include/bits/streambuf.tcc:90
[3] from 0x00007ffff7e53da4 in std::basic_streambuf<char, std::char_traits<char> >::sputn(char const*, long)+13 at /build/gcc/src/gcc-build/x86_64-pc-linux-gnu/libstdc++-v3/include/streambuf:457
[4] from 0x00007ffff7e53da4 in std::__ostream_write<char, std::char_traits<char> >(std::basic_ostream<char, std::char_traits<char> >&, char const*, long)+20 at /build/gcc/src/gcc-build/x86_64-pc-linux-gnu/libstdc++-v3/include/bits/ostream_insert.h:50
[5] from 0x00007ffff7e53da4 in std::__ostream_insert<char, std::char_traits<char> >(std::basic_ostream<char, std::char_traits<char> >&, char const*, long)+340 at /build/gcc/src/gcc-build/x86_64-pc-linux-gnu/libstdc++-v3/include/bits/ostream_insert.h:101
[6] from 0x00007ffff7e5415e in std::operator<< <std::char_traits<char> >(std::basic_ostream<char, std::char_traits<char> >&, char const*)+46 at /build/gcc/src/gcc-build/x86_64-pc-linux-gnu/libstdc++-v3/include/bits/char_traits.h:357
[7] from 0x00007ffff7f7c470 in sf::priv::ImageLoader::loadImageFromFile(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::vector<unsigned char, std::allocator<unsigned char> >&, sf::Vector2<unsigned int>&)+288 at /home/dec05eba/git/SFML/src/SFML/Graphics/ImageLoader.cpp:127
[8] from 0x00007ffff7f5ab4a in sf::Image::loadFromFile(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)+54 at /home/dec05eba/git/SFML/src/SFML/Graphics/Image.cpp:125

valgrind complains about:
 157 ==923743== Possible data race during read of size 8 at 0x4ED5E90 by thread #3
 158 ==923743== Locks held: none
 159 ==923743==    at 0x4A40D90: rdbuf (basic_ios.h:322)
 160 ==923743==    by 0x4A40D90: __ostream_write<char, std::char_traits<char> > (ostream_insert.h:50)
 161 ==923743==    by 0x4A40D90: std::basic_ostream<char, std::char_traits<char> >& std::__ostream_insert<char, std::char_traits<char> >(std::basic_ostream<char, std::char_traits<char> >&, char const*, long) (ostream_insert.h:101)
 162 ==923743==    by 0x4A4115D: std::basic_ostream<char, std::char_traits<char> >& std::operator<< <std::char_traits<char> >(std::basic_ostream<char, std::char_traits<char> >&, char const*) (ostream:611)
 163 ==923743==    by 0x48C746F: sf::priv::ImageLoader::loadImageFromFile(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::vector<unsigned char, std::allocator<unsigned char> >&, sf::Vector2<unsigned int>&) (ImageLoader.cpp:127)
 164 ==923743==    by 0x48A5B49: sf::Image::loadFromFile(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) (Image.cpp:125)
 165 ==923743==    by 0x109293: main::{lambda()#1}::operator()() const (in /home/dec05eba/sfml-crash/test-sfml-crash)
 166 ==923743==    by 0x1098FB: void std::__invoke_impl<void, main::{lambda()#1}>(std::__invoke_other, main::{lambda()#1}&&) (in /home/dec05eba/sfml-crash/test-sfml-crash)
 167 ==923743==    by 0x1098B0: std::__invoke_result<main::{lambda()#1}>::type std::__invoke<main::{lambda()#1}>(std::__invoke_result&&, (main::{lambda()#1}&&)...) (in /home/dec05eba/sfml-crash/test-sfml-crash)
 168 ==923743==    by 0x10985D: void std::thread::_Invoker<std::tuple<main::{lambda()#1}> >::_M_invoke<0ul>(std::_Index_tuple<0ul>) (in /home/dec05eba/sfml-crash/test-sfml-crash)
 169 ==923743==    by 0x109831: std::thread::_Invoker<std::tuple<main::{lambda()#1}> >::operator()() (in /home/dec05eba/sfml-crash/test-sfml-crash)
 170 ==923743==    by 0x109815: std::thread::_State_impl<std::thread::_Invoker<std::tuple<main::{lambda()#1}> > >::_M_run() (in /home/dec05eba/sfml-crash/test-sfml-crash)
 171 ==923743==    by 0x49E2C23: execute_native_thread_routine (thread.cc:80)
 172 ==923743==    by 0x4841886: mythread_wrapper (hg_intercepts.c:387)
 173 ==923743==
 174 ==923743== This conflicts with a previous write of size 8 by thread #2
 175 ==923743== Locks held: none
 176 ==923743==    at 0x4A3FC1C: basic_ios (basic_ios.h:462)
 177 ==923743==    by 0x4A3FC1C: std::basic_ostream<char, std::char_traits<char> >::basic_ostream(std::basic_streambuf<char, std::char_traits<char> >*) (ostream:85)
 178 ==923743==    by 0x4EC5E9D: sf::err() (Err.cpp:104)
 179 ==923743==    by 0x48C7460: sf::priv::ImageLoader::loadImageFromFile(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::vector<unsigned char, std::allocator<unsigned char> >&, sf::Vector2<unsigned int>&) (ImageLoader.cpp:127)
 180 ==923743==    by 0x48A5B49: sf::Image::loadFromFile(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) (Image.cpp:125)
 181 ==923743==    by 0x109293: main::{lambda()#1}::operator()() const (in /home/dec05eba/sfml-crash/test-sfml-crash)
 182 ==923743==    by 0x1098FB: void std::__invoke_impl<void, main::{lambda()#1}>(std::__invoke_other, main::{lambda()#1}&&) (in /home/dec05eba/sfml-crash/test-sfml-crash)
 183 ==923743==    by 0x1098B0: std::__invoke_result<main::{lambda()#1}>::type std::__invoke<main::{lambda()#1}>(std::__invoke_result&&, (main::{lambda()#1}&&)...) (in /home/dec05eba/sfml-crash/test-sfml-crash)
 184 ==923743==    by 0x10985D: void std::thread::_Invoker<std::tuple<main::{lambda()#1}> >::_M_invoke<0ul>(std::_Index_tuple<0ul>) (in /home/dec05eba/sfml-crash/test-sfml-crash)
 185 ==923743==  Address 0x4ed5e90 is 240 bytes inside data symbol "_ZZN2sf3errEvE6stream

But looking at the code, it might be a false positive?

I tested changing sf::Err to use thread_local variables instead of static and it doesn't crash anymore (with your branch)

Nice debugging!
I assume you replaced static with thread_local for these two statements?
https://github.com/SFML/SFML/blob/master/src/SFML/System/Err.cpp#L103-L104

that is right

This shouldn't be closed yet, #1712 doesn't fully fix this. thread_local needs to be added in sf::err as described above.

So basically, sf::Err is not thread-safe. thread_local (or SFML's C++98 sf::ThreadLocalPtr equivalent) will make sure there's no race on the DefaultErrStreamBuf itself, but not on the underlying stderr object.
If I'm not mistaken, C++11 guarantees thread safety for stdout, stderr, etc. in the sense that no corruption will occur due to multi-threaded access. However, it's still possible that unbuffered characters are interleaved from two places. In C++98, there was no threading model, so I guess no guarantees (might still work in practice).
I referenced a PR which is still incomplete, let's continue the discussion there. Unfortunately, pre-C++11 we cannot use thread_local.

If I'm not mistaken, C++11 guarantees thread safety for stdout, stderr, etc. in the sense that no corruption will occur due to multi-threaded access. However, it's still possible that unbuffered characters are interleaved from two places
Thats right, stderr is thread-safe and at least on gnu/linux, also unbuffered. Not sure if stderr being unbuffered is part of the standard though.

As the title is confusing and primary reported issue has been fixed, I've created a separate issue to track the sf:err() issue: #3003
As such, I'm closing this one here again


Continue refactoring for codeclimate

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (d73db64) 61.75% compared to head (5e15f98) 61.75%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main       #6   +/-   ##
=======================================
  Coverage   61.75%   61.75%
=======================================
  Files          17       17
  Lines         821      821
=======================================
  Hits          507      507
  Misses        314      314

Flag
Coverage Δ

unittests
61.75% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Yeah, this is about as much refactoring as I can do right now 😅 merging!


Add release to https://bosh.io/releases

Hi,
Please can you add the built release to https://bosh.io/releases?  The 'cf-rabbitmq-release' is already there, so it seems like this should also be made available.
thanks
Rob

Hi @rerooted, we've opened a PR [1] to make sure that this release will be available on bosh.io. It should be available soon.
[1] https://github.com/bosh-io/releases/pull/18


Give me back to my account deduct its very big deduct.

Hi,
I got this message but when i did calculation it doesnt seem to be right
You are one of the users whose balance was affected by the bug in the system and therefore got 0.1142230 BTC Confirmed BTC.
To correct your balance we deducted: 0.1142230 BTC and 8994.8527500 MYX (equivalently to missing BTC amount based on MYX price = 0.00004 BTC).
I have got referral in ICO around 285 Monyx bonus and after exchange opened I deposited 0.11 BTC for trading and buying more. Kindly recheck the deposits/withdrawal again or kindly deduct my Monyx which I got in trading and credit back my BTC deposit which I made recently.
-freemonyx

@combofiend you deposited 0.1043181700 BTC in total and used it to buy 4451.40460650 MYX, I checked your balance, it seems correct.

why you deduct my account  myx 8994.8527500 and 0.078344 btc

i earn myx in exchange buy and sell.

@combofiend is your username "freemonyx"?

yeah. or my balances bugging

missing my balance what happen

why you deduct my account myx 8994.8527500 and 0.078344 btc

@combofiend I don't understand where did you see those values. I just tried to log in your account and see this: https://monosnap.com/file/wKDHGf9gSlfEX2qRdfv2klJ3E1SA2q
Are you sure your username is "freemonyx"?

this is a another deduct to my account.

my second account - manojaum check it and i want to change my email. to<EMAIL_ADDRESS>i put wrong email.

  What u r trying to prove here


Be able to launch without window

Either no window, or to tray, or minimized.
Useful so you don’t have to minimize the window everytime, especially when it starts with SteamVR.

Implemented by https://github.com/Louka3000/OpenVR-Dynamic-Resolution/commit/b9cea02900b514f91f17cefd36904b5b9372bf1e


Add react-tinacms-strapi

@ncphillips How can we test this package locally, I went through the Strapi Guide and tried to use the webpack-helpers package and amened the project' config file as described in https://github.com/tinacms/tinacms/tree/master/packages/%40tinacms/webpack-helpers#nextjs but when running yarn in the Strapi blog project, I  get:
error Received malformed response from registry for "react-tinacms-strapi". The registry may be down.
``ù

It's a bit funky to test because it's not published at all. We were testing locally by copyin the folder to an external node_modules. All is good, I'm going to merge and do a pre-release so we can test it out.


Configuring TLS connections in python3.7

Hi @wallyqs  , a change to python in version 3.7 breaks the recommended method of setting up TLS connections.
>>> import ssl
>>> ssl_ctx = ssl.create_default_context(purpose=ssl.Purpose.SERVER_AUTH)
>>> ssl_ctx.protocol = ssl.PROTOCOL_TLSv1_2
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
AttributeError: can't set attribute

Is there another way to set up an SSL context without setting the protocol property?

Thanks for sharing, had not tried on Python 3.7 yet but getting many errors in the tests so not sure if there might be regressions yet.
In this case, not sure what was the change yet but looks like removing the setting that line would enable TLS to work again:
DEBUG_NATS_TEST=true python3.7 tests/client_test.py ClientTLSTest

=== RUN ClientTLSTest.test_connect
[DEBUG] Server listening on port 4224 started.
[80965] 2018/07/19 16:04:58.689571 [INF] Starting nats-server version 1.2.0
[80965] 2018/07/19 16:04:58.689772 [DBG] Go build version go1.10.2
[80965] 2018/07/19 16:04:58.689790 [INF] Git commit [not set]
[80965] 2018/07/19 16:04:58.691325 [INF] Starting http monitor on <IP_ADDRESS>:8222
[80965] 2018/07/19 16:04:58.691386 [INF] Listening for client connections on <IP_ADDRESS>:4224
[80965] 2018/07/19 16:04:58.691393 [INF] TLS required for client connections
[80965] 2018/07/19 16:04:58.691399 [DBG] Server id is twgywjfm2Qb6MbJf7f0U9D
[80965] 2018/07/19 16:04:58.691402 [INF] Server is ready
[80965] 2018/07/19 16:04:58.777157 [DBG] <IP_ADDRESS>:62736 - cid:1 - Client connection created
[80965] 2018/07/19 16:04:58.777741 [DBG] <IP_ADDRESS>:62736 - cid:1 - Starting TLS client connection handshake
[80965] 2018/07/19 16:04:58.813276 [DBG] <IP_ADDRESS>:62736 - cid:1 - TLS handshake complete
[80965] 2018/07/19 16:04:58.813311 [DBG] <IP_ADDRESS>:62736 - cid:1 - TLS version 1.2, cipher suite TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256
[80965] 2018/07/19 16:04:58.815483 [TRC] <IP_ADDRESS>:62736 - cid:1 - ->> [CONNECT {"lang": "python3", "pedantic": false, "protocol": 1, "verbose": false, "version": "0.7.2"}]
[80965] 2018/07/19 16:04:58.815655 [TRC] <IP_ADDRESS>:62736 - cid:1 - ->> [PING]
[80965] 2018/07/19 16:04:58.815666 [TRC] <IP_ADDRESS>:62736 - cid:1 - <<- [PONG]
[80965] 2018/07/19 16:04:58.817000 [DBG] <IP_ADDRESS>:62736 - cid:1 - Client connection closed
[80965] 2018/07/19 16:04:58.817209 [TRC] <IP_ADDRESS>:62736 - cid:1 - <<- [PING]
[DEBUG] Server listening on 4224 will stop.
[DEBUG] Server listening on 4224 was stopped.

For now made this issue to check the status of the client against Python 3.7 https://github.com/nats-io/asyncio-nats/issues/71

Confirmed support for the client Python 3.7 is ok (#73), thanks again for the report


[New Feature]:ADD a sound effect in the background.

🎮 feature Request
Any game is incomplete without its music. I would add a sound effect in the background.
Point down the features
I will search for a sound effect that matches with the game.
Select program in which you are contributing
GSSoC24
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINE of this project.

@SIM-RAITANI Please raise any other issue, because someone is already working on it...
If you have any doubt you can directly send message on our discord (https://discord.gg/rZb46cCMmK), we have created seprate chennals for all projects...
Thank you :)


[Feat]: Profile Addition : Shariq2003

What feature?
Add my profile under GSSOC EXT
#251 PR Merged, please add labels
Add screenshots
Add screenshots
Code of Conduct

[X] I agree to follow this project's Code of Conduct

@codeaashu please add labels to my PR #251


Valid prefix search (with ^) goes into dead state

What version of regex are you using?
regex-automata = "0.4.5"
Describe the bug at a high level.
I'm trying to do a prefix search by adding a ^ at the beginning of my pattern. I'm searching right-to-left, but the dfa is failing to find a match and entering the "dead" state.
What are the steps to reproduce the behavior?
use regex_automata::{hybrid::dfa::DFA, nfa::thompson, Input};
use std::error::Error;

fn main() -> Result<(), Box<dyn Error>> {
    let pattern = r"^Qu";
    let dfa = DFA::builder()
        .thompson(thompson::Config::new().reverse(true))
        .build_many(&[pattern])?;

    let mut cache = dfa.create_cache();
    let hay = "Quartz";

    let mut state = dfa.start_state_reverse(&mut cache, &Input::new(hay))?;
    for &b in hay.as_bytes().iter().rev() {
        state = dfa.next_state(&mut cache, state, b)?;
        if state.is_dead() {
            panic!("DEAD");
        }
        if state.is_match() {
            println!("BREAK");
            break;
        }
    }

    state = dfa.next_eoi_state(&mut cache, state)?;
    assert!(state.is_match());
    Ok(())
}

What is the actual behavior?
❯ cargo run
    Finished dev [unoptimized + debuginfo] target(s) in 0.00s
     Running `target/debug/reg`
thread 'main' panicked at src/main.rs:17:13:
DEAD
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

What is the expected behavior?
I expect the program to run through to the end, finding a match and passing the assertion, as the pattern ^Qu should match the string "Quartz".
If I remove the ^ from the pattern, this program behaves as expected.

Thanks for the quick fix!


[SPARK-35002][INFRA][FOLLOW-UP] Use localhost instead of <IP_ADDRESS> at SPARK_LOCAL_IP in GA builds

What changes were proposed in this pull request?
This PR replaces <IP_ADDRESS> to localhost.
Why are the changes needed?

https://github.com/apache/spark/pull/32096#discussion_r610349269
https://github.com/apache/spark/pull/32096#issuecomment-816442481

Does this PR introduce any user-facing change?
No, dev-only.
How was this patch tested?
I didn't test it because it's CI specific issue. I will test it in Github Actions build in this PR.

Test build #137118 has started for PR 32102 at commit 676397c.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41697/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41697/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41697/

Merged to master.

Test build #137118 has finished for PR 32102 at commit 676397c.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137118/

Thanks!

I merged to branch-3.1 and branch-3.0 too. Seems like it has the same issue.

Just in case it is useful, I created an alternative fix which fixes the root cause of the problem. Reverse name lookups for the current hostname is broken in GitHub Actions Runner VMs (reported as https://github.com/actions/virtual-environments/issues/3185) and this is the workaround: #32173 .


cannot use existing chroma collection create by another sas user

#Permission for read and write from existing collection (created by another SAS user).

check folder permission / ChromaDB options

get_or_create_collection / similar function.


relational info actions on information shema

Hi all, im trying acces relational database information, but provided information using framework functions are pour, i cant get information about relation types in action reference update or delete, these information is provided on information shema tables i can acces it ussing free querys but i think that these must be provided by the framework on each especific shema engine, but i need to know if these enanced is usefull to be implemented before of work on these.
these can be a good enanched for gii proyect generating models with rules in base of relation about actions delete or update.
Sorry for my english is really low,
please let me know if these isnt the correct section to report these,
Regards.

Of curse these is really DBMS depend these is reasson of that relational information must be provided by the framework for each especific shema the shemas.php using diferents working modes for each db engine.
the previous example is incorrect way to check because the framework dont provide relational info needed.
mi sugestion is provide them implementing function on depend:
yii\db\cubrid\Schema
yii\db\mssql\Schema
yii\db\mysql\Schema
yii\db\oci\Schema
yii\db\pgsql\Schema
yii\db\sqlite\Schema
but these feature will not be able in all engines example mysql/mysam, mysqlite ... not relational but can return false if these is the case. pgsql have innodb as same mode that mysql, mmsql>= 2005 ....
Regards,
Let me know for any concerns.

Example (not tested)
public function getRelationalInfo($tableName){
$result==new Array();
$query = (new Query())
->select('ID, TYPE')
->from('INFORMATION_SCHEMA.INNODB_SYS_FOREIGN')
->where([
'REF_NAME' => end(explode('=',Yii::$app->db->dsn)).'/'.$tableName,
]);
$rows = $query->all();
foreach ($rows as $row){
$query = (new Query())
->select('*')
->from('INFORMATION_SCHEMA.KEY_COLUMN_USAGE')
->where([
'CONSTRAINT_NAME' => end(explode('/',$row['ID'])),
]);
$constrainDat = $query->all();
array_push($result, $constrainDat[0]);
}
}
return (!empty($result)) ? $result : false;
}
these maybe work on mssql pgsql and mysql (need to add validation check for innodb) cubrid maybe can be adapted and another engines not relational database can return false.


openai4s v0.1.0-alpha10

openai4s v0.1.0-alpha10
0.1.0-alpha10 - 2024-08-05
Internal Housekeeping

Remove unused refined4s-doobie from libraryDependencies (#164)

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.74%. Comparing base (ae03947) to head (792e9bd).

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #165   +/-   ##
=======================================
  Coverage   83.74%   83.74%
=======================================
  Files          18       18
  Lines         363      363
  Branches        5        5
=======================================
  Hits          304      304
  Misses         59       59


Add moniker winfsp to WinFsp.WinFsp

Checklist for Pull Requests

[x] Have you signed the Contributor License Agreement?
[ ] Is there a linked Issue?

Manifests

[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[x] Have you validated your manifest locally with winget validate --manifest <path>?

[ ] Does your manifest conform to the 1.6 schema?

Note: <path> is the directory's name containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

Made a new PR with Komac to update the manifest version as well as add the moniker. If this one https://github.com/microsoft/winget-pkgs/pull/184774 passes tests and gets merged we can close the current one.

Close with reason: Duplicate of #184774;


New DiemDB::open() requires RocksDB options

v5 ol/cli/src/node/node.rs db_bootstrapped() requires change:
https://github.com/simsekgokhan/libra/blob/0747e37670a64b324409c6bb14fa516cd3a1745e/ol/cli/src/node/node.rs#L184
@lpgeiger
I did not see a quick solution here, seems like a breaking change. Skipped it for now. FYI.

@dboreham This has your name on it :)


code probelm

Hello，
I still have some questions about the code, first, you set the st_type = 'hcf' in config.py, it does not use node embeddings on each evolving network, because in your work when st_type = 'emb' , the code would read the embedding.
Second, when you generate the embedding of evolving network, you don’t save them in pickle file, but when you read the embedding, you use the pickle to read, it causes  error.
Looking forward to you!
Best wishes to you!

Hello, you use the fix_play() to test baseline methods? or you write other methods?

Hi,
Yeah, I use fix_paly to check the baselines methods.
Best Regards,
On Sun, Sep 10, 2023 at 3:48 AM hanzhne @.***> wrote:

Hello, you use the fix_play() to test baseline methods? or you write other
methods?
—
Reply to this email directly, view it on GitHub
https://github.com/khurshedmemon/DQN-ESN/issues/4#issuecomment-1712682907,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA4BXV7QUO66DSB74FEQUSLXZUL6DANCNFSM6AAAAAAZAAEX4E
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

--
Best Regards,
-----------------------
Khurshed Ali, PhD
Email: @.** @.**>


[CI][Packaging] Wheels for macOS Catalina are failing to build pyarrow with Could NOT find Python3

Describe the bug, including details regarding any error messages, version, and platform.
The following jobs:
wheel-macos-catalina-cp310-amd64
wheel-macos-catalina-cp311-amd64
wheel-macos-catalina-cp312-amd64
wheel-macos-catalina-cp38-amd64
wheel-macos-catalina-cp39-amd64
Are failing to build due to the following error when finding Python building pyarrow:
-- Running cmake for PyArrow
cmake -DCMAKE_OSX_ARCHITECTURES=x86_64 -DARROW_SIMD_LEVEL=SSE4_2 -DCMAKE_INSTALL_PREFIX=/Users/runner/work/crossbow/crossbow/arrow/python/build/lib.macosx-10.15-x86_64-cpython-38/pyarrow -DPYTHON_EXECUTABLE=/Users/runner/work/crossbow/crossbow/build-env/bin/python -DPython3_EXECUTABLE=/Users/runner/work/crossbow/crossbow/build-env/bin/python -DPYARROW_CXXFLAGS= -G Ninja -DPYARROW_BUILD_CUDA=off -DPYARROW_BUILD_SUBSTRAIT=on -DPYARROW_BUILD_FLIGHT=on -DPYARROW_BUILD_GANDIVA=off -DPYARROW_BUILD_ACERO=on -DPYARROW_BUILD_DATASET=on -DPYARROW_BUILD_ORC=on -DPYARROW_BUILD_PARQUET=on -DPYARROW_BUILD_PARQUET_ENCRYPTION=on -DPYARROW_BUILD_AZURE=on -DPYARROW_BUILD_GCS=on -DPYARROW_BUILD_S3=on -DPYARROW_BUILD_HDFS=on -DPYARROW_BUNDLE_ARROW_CPP=on -DPYARROW_BUNDLE_CYTHON_CPP=off -DPYARROW_GENERATE_COVERAGE=off -DCMAKE_BUILD_TYPE=release -DCMAKE_VERBOSE_MAKEFILE=ON /Users/runner/work/crossbow/crossbow/arrow/python
-- The C compiler identification is AppleClang <IP_ADDRESS>00040
-- The CXX compiler identification is AppleClang <IP_ADDRESS>00040
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /Applications/Xcode_15.0.1.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /Applications/Xcode_15.0.1.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- System processor: arm64
-- Performing Test CXX_SUPPORTS_SVE
-- Performing Test CXX_SUPPORTS_SVE - Failed
-- Arrow build warning level: PRODUCTION
CMake Warning at cmake_modules/SetupCxxFlags.cmake:543 (message):
  ARROW_SIMD_LEVEL=SSE4_2 not supported by Arm.
Call Stack (most recent call first):
  CMakeLists.txt:163 (include)

-- Build Type: RELEASE
-- CMAKE_C_FLAGS:  -Wall -Wno-unknown-warning-option -Wno-pass-failed  -Qunused-arguments -fcolor-diagnostics  -fno-omit-frame-pointer -Wno-unused-variable -Wno-maybe-uninitialized -Wno-parentheses-equality -Wno-constant-logical-operand -Wno-missing-declarations -Wno-sometimes-uninitialized -Wno-return-type-c-linkage
-- CMAKE_CXX_FLAGS:  -fno-aligned-new  -Wall -Wno-unknown-warning-option -Wno-pass-failed  -Qunused-arguments -fcolor-diagnostics  -fno-omit-frame-pointer -Wno-unused-variable -Wno-maybe-uninitialized -Wno-parentheses-equality -Wno-constant-logical-operand -Wno-missing-declarations -Wno-sometimes-uninitialized -Wno-return-type-c-linkage
-- Generator: Ninja
-- Build output directory: /Users/runner/work/crossbow/crossbow/arrow/python/build/temp.macosx-10.15-x86_64-cpython-38/release
CMake Error at /Users/runner/work/crossbow/crossbow/local/CMake.app/Contents/share/cmake-3.29/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
  Could NOT find Python3 (missing: Python3_NumPy_INCLUDE_DIRS NumPy) (found
  version "3.8.10")
Call Stack (most recent call first):
  /Users/runner/work/crossbow/crossbow/local/CMake.app/Contents/share/cmake-3.29/Modules/FindPackageHandleStandardArgs.cmake:600 (_FPHSA_FAILURE_MESSAGE)
  /Users/runner/work/crossbow/crossbow/local/CMake.app/Contents/share/cmake-3.29/Modules/FindPython/Support.cmake:3867 (find_package_handle_standard_args)
  /Users/runner/work/crossbow/crossbow/local/CMake.app/Contents/share/cmake-3.29/Modules/FindPython3.cmake:545 (include)
  cmake_modules/FindPython3Alt.cmake:51 (find_package)
  CMakeLists.txt:262 (find_package)

This is happening on the 16.1.0 branch too.
Component(s)
Continuous Integration, Packaging

Issue resolved by pull request 41567
https://github.com/apache/arrow/pull/41567


Summary
Ability to set channel sound from embedded resource
API Changes
Unknown at this time
Intended Use Case
Follows mindset of XF team

it would be great

it would be great


fake almaden enhancement

add defaults and config for pulse configuration

good catch that file did not need changing at all


Update default.nix

Change it to lowercase to according to the convention presented here: http://nixos.org/nixpkgs/manual/#chap-conventions
Thanks to goibhniu from #nixos for pointing me this.

Thanks!

This patch makes imagemagick url invalid. Currently I can't build imagemagick unless if I revert it.

Ah, I'm sorry, thanks! I didn't read enough context, thinking this could break nothing. Fixed in b35e0a0.


When installed, nothing works, winget.exe file is actually empty.

Brief description of your issue
Hi, I tried to install winget through the Microsoft Store, but what I get is a CLI that doesn't work and when I search for the file winget.exe in %LOCALAPPDATA%\Microsoft\WindowsApps\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\winget.exe, the file is 0ko.

Steps to reproduce
Install winget, try launching any command.

Expected behavior
Getting winget to work.

Actual behavior
Getting nothing when executing any winget command.

Environment
Windows: 20h1 10.0.19041.964
Package: 1.0.11451

Seems to be having the same issue here. Tried all the ways still unable to get to run it.

Hopefully this answers the issue.

Hi, I faced the same issue , could not launch app from Microsoft store and winget is not recognized. I followed the steps below:
1.Turned on Developer mode . Still did not work.
2.Downloaded from  the link mentioned in ThioJoe winget video description.Here is the link :  ms-appinstaller:?source=https://aka.ms/getwinget . Copy paste it in browser.
3.It prompted to launch AppInstaller as it is already installed from Store. Updated the AppInstaller.
4.Now launched it from Mircosoft store.
5.winget is working in CMD.

Oh okay, installing winget from GitHub fixed this, thanks !


Show correct time for durations > 60 hours

The % 60 in the for loop causes durations longer than 60 hours to be miscalculated.
Came across this after running a badblocks command which took 90 hours,
but my shell prompt that uses humanize_duration showed 30 hours.

@ammgws What if we showed days instead? 😄

Either way as long as it's a correct representation :)

By the way can't we rewrite this in fish using math? I haven't benchmarked it but I don't see why awk is needed here.

@ammgws We could. Why don't we do it and see which one is faster? I'm going to bet on awk, but I could be wrong. I'm going to pull this locally and rework the code to produce the same output, but see if I can write it using less code. Feels like it could be written with less code.
Thank you!

fish 3.1's new time builtin will come in handy for the benchmark


Using traefik doesn't work

Hi,
I am using Traefik in front of it (it is supposed to handle websockets without any special configuration), do I need to do anything special? I get:
10:00:40.874 [http-nio-8080-exec-3] INFO  o.a.g.tunnel.TunnelRequestService - User "guacadmin" connected to connection "1".
10:00:40.986 [http-nio-8080-exec-1] INFO  o.a.g.tunnel.TunnelRequestService - User "guacadmin" disconnected from connection "1". Duration: 112 milliseconds
Exception in thread "Thread-44" java.lang.IllegalStateException: Message will not be sent because the WebSocket session has been closed
	at org.apache.tomcat.websocket.WsRemoteEndpointImplBase.writeMessagePart(WsRemoteEndpointImplBase.java:424)
	at org.apache.tomcat.websocket.WsRemoteEndpointImplBase.sendMessageBlock(WsRemoteEndpointImplBase.java:309)
	at org.apache.tomcat.websocket.WsRemoteEndpointImplBase.sendMessageBlock(WsRemoteEndpointImplBase.java:250)
	at org.apache.tomcat.websocket.WsRemoteEndpointImplBase.sendString(WsRemoteEndpointImplBase.java:191)
	at org.apache.tomcat.websocket.WsRemoteEndpointBasic.sendText(WsRemoteEndpointBasic.java:37)
	at org.apache.guacamole.websocket.GuacamoleWebSocketTunnelEndpoint.sendInstruction(GuacamoleWebSocketTunnelEndpoint.java:152)
	at org.apache.guacamole.websocket.GuacamoleWebSocketTunnelEndpoint.access$200(GuacamoleWebSocketTunnelEndpoint.java:53)
	at org.apache.guacamole.websocket.GuacamoleWebSocketTunnelEndpoint$2.run(GuacamoleWebSocketTunnelEndpoint.java:253)
^C

switch to traefik or use nginx with websocket support

I am already using Traefik

Sorry i forgot to include the version, use traefik v2, it has websocket support V1 doesnt

I am running the latet v2. However, I don't need Guacamole at the moment.
Thanks.
On Fri, Jun 5, 2020, 18:26 Siyuan Gao<EMAIL_ADDRESS>wrote:

Sorry i forgot to include the version, use traefik v2, it has websocket
support V1 doesnt
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/prabhatsharma/apache-guacamole-helm-chart/issues/6#issuecomment-639610776,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB6QAYDTKIDK3VASKBYTNF3RVEMEJANCNFSM4L33ETGA
.


Strange Window Borders

Hi again, I posted this previously but decided to post it again. For some reason in SimCopter the window borders have strange colors and border styles. Sometimes the colors change:

Not a huge issue because ddrawcompat fixes a bunch of other issues, so once again thank you for working on this over the years.

Fixed in the latest experimental release. Also fixed an issue where the main window didn't update properly after closing a file dialog.

Fixed in the latest experimental release. Also fixed an issue where the main window didn't update properly after closing a file dialog.


Removes Istio bootstrap

The maintenance and side-effects of Istio bootstrap integration have
proven to be the bulk of effort in maintaining this project, and the
bulk of its size. This removes the feature to free us to focus on Envoy,
which better aligns with the primary charter of the project.
Before:
$ du -k build/bin/*/amd64/getenvoy
78876	build/bin/darwin/amd64/getenvoy
67496	build/bin/linux/amd64/getenvoy

Now:
$ du -k build/bin/*/amd64/getenvoy
22784	build/bin/darwin/amd64/getenvoy
20212	build/bin/linux/amd64/getenvoy

Signed-off-by: Adrian Cole<EMAIL_ADDRESS>

Others: the rational is not only the maintenance burden, but also the fact that we have only supported 1.2 (https://github.com/tetratelabs/getenvoy/pull/168) in the released getenvoy version.. which itself I think proves that this feature is no longer in use by the end user.

unit test went from 10m to 3m, but I think most of this is that the linters consume less resources due to the simpler dependency tree.

yeah it is mostly the check phase and likely less bulk to download which is why PRs can check so much faster now.

rebased over #179 to bring down another 2MiB
du -k build/bin/*/amd64/getenvoy
20760	build/bin/darwin/amd64/getenvoy
18420	build/bin/linux/amd64/getenvoy

updated the description with the size difference based on this vs latest master (after rebasing)

@liamawhite I don't think you've been pinged directly on this, but I think you have been the only user of this feature. I searched github google etc and haven't seen any reference to this not made by an employee. We also know that the last release of getenvoy doesn't support any recent release of istio and no-one complained. Finally, it was marked experimental from the beginning. I hope you agree that for the health of the project it is time to delete this. If not please comment why and help pitch in on the maintenance impact which I could enumerate further on, but choosing to save keystrokes.

Going to merge this so that we can conserve time. If there are any post-merge discussions about it, we can have them any time between now and our next release, which I don't know the schedule of.


#34 - check security config

Set default security config to authenticated, allowing no endpoints to be used without bein authenticated. One exception is the /actuator/health endpoint which is open without authentication.

This is rendered obsolete by #56


CA_CERTIFICATES URLs contain unescaped '(' and ')' characters.

==> toolchain: Uploading root certificates to guest instance...
==> toolchain: -- /var/folders/d1/00c_bhx55jx16p42s5rzb3ph0000gn/T/vagrant-ca-certificates20181219-62221-1m9jjxf => /etc/pki/ca-trust/source/anchors/MITRE%20BA%20NPE%20CA-3(1).crt
The following SSH command responded with a non-zero exit status.
Vagrant assumes that this means the command failed!

mv vagrant20181219-62221-1hew1dg /etc/pki/ca-trust/source/anchors/MITRE%20BA%20NPE%20CA-3(1).crt && chown root: /etc/pki/ca-trust/source/anchors/MITRE%20BA%20NPE%20CA-3(1).crt && chmod 0644 /etc/pki/ca-trust/source/anchors/MITRE%20BA%20NPE%20CA-3(1).crt

Stdout from the command:

Stderr from the command:

bash: line 4: syntax error near unexpected token `('
bash: line 4: `mv vagrant20181219-62221-1hew1dg /etc/pki/ca-trust/source/anchors/MITRE%20BA%20NPE%20CA-3(1).crt && chown root: /etc/pki/ca-trust/source/anchors/MITRE%20BA%20NPE%20CA-3(1).crt && chmod 0644 /etc/pki/ca-trust/source/anchors/MITRE%20BA%20NPE%20CA-3(1).crt'

The simple fix is to change the filename from MITRE BA NPE CA-3(1).crt to MITRE BA NPE CA-3.crt and update the docs.  I can send you a PR if'n you want, but it's not really worth it.

Thanks... It is odd this isn't impacting me on my Mac.   I can see how the
parentheses can be problematic, but i think think the class cover this
concern...
Let me scan through the class and cut and paste the text here.
Yes. In section 9.1's note section:
NOTE

The cetificate URLs need to be encoded for parenthese to work.

Son if youk look closely at the URLs for certs the parentheses are encoded
thereby addressing the problem.
http://employeeshare.mitre.org/m/mjwalsh/transfer/MITRE BA ROOT.crt,http://employeeshare.mitre.org/m/mjwalsh/transfer/MITRE BA NPE CA-3(1).crt
As are they in the set_env.sh script in the root of thr project.
All this because the original certs files have these parantheses and chose
to keep them.
-Michael
On Wed, Dec 19, 2018, 10:07 AM T. Miller<EMAIL_ADDRESS>wrote:

The simple fix is to change the filename from MITRE BA NPE CA-3(1).crt to MITRE
BA NPE CA-3.crt and update the docs. I can send you a PR if'n you want,
but it's not really worth it.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/nemonik/hands-on-DevOps/issues/2#issuecomment-448627787,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAKwGA-iBRv-5zKJXQWjhPXcdpXBB1inks5u6lZMgaJpZM4ZabKc
.

I have spelling mistake in the note I need to correct...  :)


🐛 [flutterfire-cli] Creating a project with less than 4 letters results in an error 400

Bug report
Describe the bug
Create a firebase project through the flutterfire-cli with less than 4 letters (example: nld)
It results in a firebase error (HTTP error code 400)
Steps to reproduce
Steps to reproduce the behavior:

Execute flutterfire config
Choose "create a new project"
Type a project with less than 4 letters (exemple: nld)

Expected behavior
Typing the name should result in a validation error, because firebase needs at least 4 characters.

@fodil-a
Since you are using the CLI tool and its command flutterfire configure to create a new project, according to CLI documentation, any issues related to CLI tool need to be reported in dedicated repo: https://github.com/invertase/flutterfire_cli/issues. https://firebase.flutter.dev/docs/cli/#reporting-an-issue
So please open this issue in above repo.
Closing from here.


Error: {}You need to pass auth instance to use gRPC-fallback client in browser. Use OAuth2Client from google-auth-library.

Hello, I'm working with Google Cloud for the first time, and I'm building a React application. I've created a Datastore entity on GCP and now I'm trying to use the Datastore API in React to request the data to use in the application.
In one file called action.js I have:
const {Datastore} = require('@google-cloud/datastore');

const datastore = new Datastore({
  projectId: '[project-id]',
  keyFilename: '[file-name]'
});

export const getAllStocks = async () => {
  try {
    var query = datastore.createQuery(['Stock']);
    datastore.runQuery(query, (err, stocks) => {
      console.log('Here is the stocks', stocks);
    });
  } catch (err) {
    console.error('getAllStocks ERROR:', err);
  }
}

And I've also tried providing the service account credentials through the environment variable as described here  instead of providing the keyFilename in the above code
I try to import getAllStocks into another file:
import React from 'react';
import { getAllStocks } from '../actions';
class StockList extends React.Component {

  render() {
    return [code here]
  }
}

However, I get the error Error: {}You need to pass auth instance to use gRPC-fallback client in browser. Use OAuth2Client from google-auth-library. when I run the app npm start.
And the error disappears once I comment out the line that imports getAllStocks
Am I providing the credentials incorrectly? Or is there something else I need to do to resolve the issue?
Environment details

OS: macOS Mojave 10.14.1
Node.js version: v14.1.0
npm version: 6.14.4
@google-cloud/datastore version: 5.1.0

@zyuzon24  This module was built specifically for Node.js. Here explain how to use google-auth-library with any front-end environment such as a browser, Electron app, React,


Tried to clarify the readme

Chop up my changes as you see fit. I tried to add a little more info about how rollout works for users who were unfamiliar.

Congrats!  You've a contributor!
https://github.com/jrallison/rollout_ui/contributors
On Tue, Oct 18, 2011 at 10:12 AM, Colin Nederkoorn <
<EMAIL_ADDRESS>
Chop up my changes as you see fit. I tried to add a little more info about
how rollout works for users who were unfamiliar.
You can merge this Pull Request by running:
git pull https://github.com/sud0n1m/rollout_ui master
Or you can view, comment on it, or merge it online at:
https://github.com/jrallison/rollout_ui/pull/1
-- Commit Summary --

Tried to clarify instructions in the readme.
Updated readme
Update readme

-- File Changes --
M README.markdown (15)
-- Patch Links --
https://github.com/jrallison/rollout_ui/pull/1.patch
https://github.com/jrallison/rollout_ui/pull/1.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/jrallison/rollout_ui/pull/1

Yay!
On Tue, Oct 18, 2011 at 11:12 AM, John Allison <
<EMAIL_ADDRESS>
Congrats!  You've a contributor!
https://github.com/jrallison/rollout_ui/contributors
On Tue, Oct 18, 2011 at 10:12 AM, Colin Nederkoorn <
<EMAIL_ADDRESS>
Chop up my changes as you see fit. I tried to add a little more info
about
how rollout works for users who were unfamiliar.
You can merge this Pull Request by running:
git pull https://github.com/sud0n1m/rollout_ui master
Or you can view, comment on it, or merge it online at:
https://github.com/jrallison/rollout_ui/pull/1
-- Commit Summary --

Tried to clarify instructions in the readme.
Updated readme
Update readme

-- File Changes --
M README.markdown (15)
-- Patch Links --
https://github.com/jrallison/rollout_ui/pull/1.patch
https://github.com/jrallison/rollout_ui/pull/1.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/jrallison/rollout_ui/pull/1

--
Reply to this email directly or view it on GitHub:
https://github.com/jrallison/rollout_ui/pull/1#issuecomment-2442933


tappedout scraper is failing

Error running task ['run.py', 'scraper', 'all']

Reported on CLI by CLI

FetchException Expecting value: line 1 column 1 (char 0)
Stack Trace:

Python traceback

  File "run.py", line 128, in <module>
    run()
  File "run.py", line 70, in task
    run_all_tasks(module)
  File "run.py", line 115, in run_all_tasks
    s.scrape() # type: ignore
  File "/home/discord/decksite/decksite/scrapers/tappedout.py", line 19, in scrape
    raw_decks = fetch_decks()
  File "/home/discord/decksite/decksite/scrapers/tappedout.py", line 34, in fetch_decks
    return fetch_tools.fetch_json('https://tappedout.net/api/deck/latest/penny-dreadful/')
  File "/home/discord/decksite/shared/fetch_tools.py", line 62, in fetch_json
    raise FetchException(e)

Exception_hash: 074e3c678888dde74db3e67df051fb5112daa781

Labels: CLI; FetchException

Runs to completion on local for me.

We are getting a 403 Forbidden on prod.
Fetching https://api.scryfall.com/bulk-data (cache ok)
[2019-11-11 19:20:32,947] WARNING in logger: Logged in to TappedOut: False
Fetching https://tappedout.net/api/deck/latest/penny-dreadful/ (cache ok)
Failed to load JSON:

<title>403 Forbidden</title>

403 Forbidden

nginx/1.10.3 (Ubuntu)

Error running task ['run.py', 'scraper', 'tappedout']
Reported on CLI by CLI

FetchException
Expecting value: line 1 column 1 (char 0)

Stack Trace:

Python traceback
File "run.py", line 128, in
run()
File "run.py", line 82, in task
exitcode = s.scrape() # type: ignore
File "/home/discord/decksite/decksite/scrapers/tappedout.py", line 19, in scrape
raw_decks = fetch_decks()
File "/home/discord/decksite/decksite/scrapers/tappedout.py", line 34, in fetch_decks
return fetch_tools.fetch_json('https://tappedout.net/api/deck/latest/penny-dreadful/')
File "/home/discord/decksite/shared/fetch_tools.py", line 62, in fetch_json
raise FetchException(e)

Exception_hash: 2e23e5e3e0ad4476bdcce7858c09d84a04b34654

Traceback (most recent call last):
  File "/home/discord/decksite/shared/fetch_tools.py", line 58, in fetch_json
    return json.loads(blob)
  File "/usr/lib64/python3.6/json/__init__.py", line 354, in loads
    return _default_decoder.decode(s)
  File "/usr/lib64/python3.6/json/decoder.py", line 339, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
  File "/usr/lib64/python3.6/json/decoder.py", line 357, in raw_decode
    raise JSONDecodeError("Expecting value", s, err.value) from None
json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "run.py", line 128, in <module>
    run()
  File "run.py", line 35, in run
    task(sys.argv)
  File "run.py", line 82, in task
    exitcode = s.scrape() # type: ignore
  File "/home/discord/decksite/decksite/scrapers/tappedout.py", line 19, in scrape
    raw_decks = fetch_decks()
  File "/home/discord/decksite/decksite/scrapers/tappedout.py", line 34, in fetch_decks
    return fetch_tools.fetch_json('https://tappedout.net/api/deck/latest/penny-dreadful/')
  File "/home/discord/decksite/shared/fetch_tools.py", line 62, in fetch_json
    raise FetchException(e)
shared.fetch_tools.FetchException: Expecting value: line 1 column 1 (char 0)

That page loads in a browser for me so I guess we are rate limited??

I turned the tappedout scraper off in 10dd2716. Let's give it a rest and see if we get unblocked.

Tried just now still 403.

Still Forbidden.

https://tappedout.net/api/deck/latest/penny-dreadful/
Works in my browser. 403 via wget from terminal, same as on prod.
So possibly we need to supply a User-Agent?

I think we're done with Tapped Out. They haven't had our proper legality for a long time.


Don't unnecessarily quote fields with spaces.

Addresses #118
I have changed QuoteMinimal to not quote on spaces.
I have added a QuoteConservative which behaves like the old QuoteMinimal.
The default encoding options now specifies QuoteConservative in an attempt to minimize any potential breakage.

I would love to have this. It surprised me that the default encoding mode puts quotes around strings with spaces in them. I'm annoyed by the lack of a way to work around this problem.
This is especially weird considering the first thing in the README is a CSV that has a string with spaces in it that isn't wrapped in quotes.

Here's the two second crash course in using the library. Given a CSV file with this content:
John Doe,50000
Jane Doe,60000

This would also fix #86, which is a duplicate of #118.

@luke-clifton Is there any actual demand for QuoteConservative ? If we introduce a new constructor (and I'm considering adding the non-numerical one mentioned in the comment in #86), we've got to signal a major version bump anyway, which is basically a very loud "heads up" signal to maintainers to review the API for semantic breaking changes. At which point I'd rather change the default to the less arbitrary rfc4180-minimal mode.

IIRC I had the default match the RFC (although I know that lots of software doesn't follow it closely).

I''m fine with dropping it.

resolved by 2fd71dd


Please Keep Update Package

Please Keep Update Package

Do you have any feature request or bug report?

node_modules/mongodb-snapshot/dist/connectors/mongodb/MongoDBDuplexConnector.d.ts:2:10 - error TS2305: Module '"mongodb"' has no exported member 'FilterQuery'.

2 import { FilterQuery } from "mongodb";
           ~~~~~~~~~~~
node_modules/mongodb-snapshot/dist/connectors/mongodb/MongoDBDuplexConnector.d.ts:79:114 - error TS2694: Namespace '"/Users/danielehrhardt/projects/mefra/accounting-api/node_modules/mongodb/mongodb"' has no exported member 'BulkWriteOpResultObject'.

79     writeCollectionDocuments(collectionName: string, documents: [CollectionDocument]): Promise<import("mongodb").BulkWriteOpResultObject>;
                                                                                ~~~~~~~~~~~~~~~~~~~~~~~

Found 2 error(s).

@danielehrhardt are you trying to compile this library or just using it?

@danielehrhardt are you trying to compile this library or just using it?

Just using it

@danielehrhardt are you running the program as ts-node or node?

It's a matter of the mongodb changing it API, thus mongodb-snapshot is not compatible with version 4 and above. This line, for example, imports FilterQuery that no longer exists.

@garrappachc basically it just types and im not exporting it, so i wonder if by using "any" i can resolve this issue.
Maybe we should upgrade only "@types/mongodb" on package.json?
The library is meant to support both mongodb v3 and v4.


Admin New Player Notification Sound

Adds a quick ping sound that plays to every active (not de-adminned) admin whenever a new player joins.

Добавлю вручную, потому что потому.


No 'build/releases' folder

I feel like I've done everything right, but I'm bad so I'm not sure. I'm running ubuntu and all the commands  to build seem to run smoothly, but at the end there is no 'build/releases' folder and I don't see any way to launch. Maybe I'm missing something obvious, idk.

all the commands to build seem to run smoothly

Did the nodewebkit grunt task succeed? This is the last part of the build process and it compiles the node-webkit application. If it did not, there must be something wrong with either your system/configuration or the node-webkit-builder package. This is how the output of the grunt release command should look like:
Running "release" task

Running "jshint:app" (jshint) task
>> 125 files lint free.

Running "jshint:test" (jshint) task
>> 4 files lint free.

Running "connect:test" (connect) task
Started connect web server on http://<IP_ADDRESS>:8000

Running "qunit:all" (qunit) task
Testing http://localhost:8000/test/tests.html .......OK
>> 27 assertions passed (31ms)

Running "clean:tmp" (clean) task
>> 54 paths cleaned.

Running "copy:build" (copy) task
Created 1 directories copied 41 files

Running "metadata:all" (metadata) task

Running "less:release" (less) task
File build/tmp/styles/app.css created

Running "requirejs:release" (requirejs) task

Running "uglify:release" (uglify) task
>> 1 file created.

Running "uglify:requirejs" (uglify) task
>> 1 file created.

Running "compile:linux64" (compile) task

Running "clean:release_linux64" (clean) task
>> 16 paths cleaned.

Running "nodewebkit:linux64" (nodewebkit) task
Using v0.11.6
Create cache folder in /home/basti/repos/livestreamer-twitch-gui/build/cache/0.11.6
Downloading: http://dl.nwjs.io/v0.11.6/node-webkit-v0.11.6-linux-x64.tar.gz

Create release folder in /home/basti/repos/livestreamer-twitch-gui/build/releases/livestreamer-twitch-gui/linux64
Zipping app/main.js
Zipping img/Twitch_Logo_Purple.png
Zipping img/icon-16.png
Zipping img/icon-256.png
Zipping img/icon-32.png
Zipping img/icon-48.png
Zipping index.html
Zipping oauth.html
Zipping oauth.json
Zipping package.json
Zipping styles/app.css
Zipping vendor/flag-icon-css/flags/4x3/br.svg
Zipping vendor/flag-icon-css/flags/4x3/cn.svg
Zipping vendor/flag-icon-css/flags/4x3/cz.svg
Zipping vendor/flag-icon-css/flags/4x3/de.svg
Zipping vendor/flag-icon-css/flags/4x3/dk.svg
Zipping vendor/flag-icon-css/flags/4x3/es.svg
Zipping vendor/flag-icon-css/flags/4x3/fi.svg
Zipping vendor/flag-icon-css/flags/4x3/fr.svg
Zipping vendor/flag-icon-css/flags/4x3/gb.svg
Zipping vendor/flag-icon-css/flags/4x3/gr.svg
Zipping vendor/flag-icon-css/flags/4x3/hu.svg
Zipping vendor/flag-icon-css/flags/4x3/it.svg
Zipping vendor/flag-icon-css/flags/4x3/jp.svg
Zipping vendor/flag-icon-css/flags/4x3/kr.svg
Zipping vendor/flag-icon-css/flags/4x3/mx.svg
Zipping vendor/flag-icon-css/flags/4x3/nl.svg
Zipping vendor/flag-icon-css/flags/4x3/no.svg
Zipping vendor/flag-icon-css/flags/4x3/pl.svg
Zipping vendor/flag-icon-css/flags/4x3/pt.svg
Zipping vendor/flag-icon-css/flags/4x3/ru.svg
Zipping vendor/flag-icon-css/flags/4x3/se.svg
Zipping vendor/flag-icon-css/flags/4x3/sk.svg
Zipping vendor/flag-icon-css/flags/4x3/tr.svg
Zipping vendor/flag-icon-css/flags/4x3/tw.svg
Zipping vendor/flag-icon-css/flags/4x3/us.svg
Zipping vendor/font-awesome/fonts/fontawesome-webfont.woff
Zipping vendor/requirejs/require.js
Zipping vendor/roboto-fontface/fonts/Roboto-Bold.woff2
Zipping vendor/roboto-fontface/fonts/Roboto-Light.woff2
Zipping vendor/roboto-fontface/fonts/Roboto-Medium.woff2
Zipping vendor/roboto-fontface/fonts/Roboto-Regular.woff2
Zipping vendor/roboto-fontface/fonts/Roboto-RegularItalic.woff2
>> nodewebkit app created.

Running "copy:linux64scripts" (copy) task
Copied 3 files

Running "copy:linux64icons" (copy) task
Copied 6 files

Done without errors.

Mine stops short. Not sure why it would do this.
Running "release" task
Running "jshint:app" (jshint) task

125 files lint free.

Running "jshint:test" (jshint) task

4 files lint free.

Running "connect:test" (connect) task
Started connect web server on http://<IP_ADDRESS>:8000
Running "qunit:all" (qunit) task
Testing http://localhost:8000/test/tests.html .......OK

27 assertions passed (61ms)

Running "clean:tmp" (clean) task

0 paths cleaned.

Running "copy:build" (copy) task
Created 1 directories, copied 41 files
Running "metadata:all" (metadata) task
Running "less:release" (less) task
File build/tmp/styles/app.css created
Running "requirejs:release" (requirejs) task
Running "uglify:release" (uglify) task

1 file created.

Running "uglify:requirejs" (uglify) task

1 file created.

Done, without errors.

Hm, what you've posted is the result of the buildrelease task, which is called by the compile task here... Are you sure you're running the right command (grunt compile)? You can also manually compile the built project by running grunt compile after grunt buildrelease. See grunt --help for a full list of available tasks...


Keep data in local repos and don't upload to GitHub

It is best practice to not upload datasets to GitHub (datasets may not have open source license, datasets may be too big and exceed GitHub's storage limits, keep datasets and software separate) other than maybe an example dataset for users to test out your code.
I would recommend sharing datasets with team members privately instead of uploading them to GitHub. Not a hard rec, but something to consider.

Thanks! The data here is Jaime's experimental data. The reason we kept the data here is to make it easier for everyone who is developing the code to have the whole sets of different plots to try on. We will remove the dataset once all the functions are written.


Fix babel only regexp on windows

cli / packager was broken on Windows after 28f1c67ced5f082d92ba674e7e8bd233f4ff29ca.
Babel only regexp option requires paths to use forward slashes only but __dirname will use backslashes on windows. This simply adds a replace to normalize to forward slashes.
cc @jeanlauliac @cpojer

Thanks @janicduplessis!


Enabling support for the new FP16 implementation in HIP.

This commit also updates support for the existing HIP FP16 implementation
The existing implementation was changed so that we do not need any changes
on the TF side anymore (whether it be the existing HIP FP16 implementation
or the new HIP FP16 implementation).
The TF side of the code mostly uses Eigen::half API routines so it does not
need to worry about the underlying implementation. The one exception to that
was the access to the Eigen::half.x member which used to be unsigned short
on the host side and __fp16 on the device side.  That was changed to be
unsigned short on the device side so that we no longer need to special case
the TF code.
The other (conceptually) major change is that we now have an implicit conversion
operator (operator __half) defined to convert Eigen::half to the native __fp16
for the existing HIP FP16 implementation. This allows us to not change code
that calls the __h* HIP API routines that take __fp16 arguments but are called
with Eigen::half actuals in the Eigen code.
In the new HIP FP16 implmentation, the __h* HIP API routines take __half
arguments, and there exists a constructor to convert __half_raw to __half
(and Eigen::half is derived from __half_raw)
These changes in this commit mirror those made in the TF1.3 stream.

@parallelo how should we interpret bot message "Can one of the admins verify this patch?"

This is interesting -- looks like some settings are still quirky.  It should be set up to whitelist folks who belong to ROCmSoftwarePlatform.  I believe that means that a whitelisted contributor's Jenkins job should proceed without external approval, while a non-whitelisted contributor needs an admin to approve it.
Let me try to figure out why Jenkins thinks @deven-amd is not on the whitelisted group.
Note:  for non-whitelisted PRs, there are a set of commands that admins can use:

When a new pull request is opened in the project and the author of the pull request isn't white-listed,
builder will ask "Can one of the admins verify this patch?".
"ok to test" to accept this pull request for testing
"test this please" for a one time test run
"add to whitelist" to add the author to the whitelist
If the build fails for other various reasons you can rebuild.
"retest this please" to start a new build

https://wiki.jenkins.io/display/JENKINS/GitHub+pull+request+builder+plugin

add to whitelist

@parallelo amazed by the advent of AI.... humans have to please the bots now ;-)

have to be polite to the bots, or else...  ;-)

Jenkins:  retest this please

@deven-amd congratulation for getting the 1st check mark from almighty CI!

@whchung, now that CI is enabled, I keep hearing the "terminator 2 : judgement day" theme in my head, while waiting for CI to finish after I submit a PR :)


balances combing XLM balances view for multiple accounts

I'm not sure if this was intentional or not, I don't think it was:
+---------+----------+---------------+
| openach | USD      |     0.0000000 |
+         +----------+---------------+
|         | XLM      |  9999.9998600 |
+---------+          +---------------+
| issuer  |          | 10019.9999200 |
+---------+----------+---------------+

"openach" and "issuer" are two separate accounts; issuer only has an XLM balance, but the XLM column isn't showing the separation and repeating the asset_code to show crossing an account level boundary.

This intended however this can be confusing.
I have changed it to look like this:
+----------------------+----------+---------------+
|        WALLET        | CURRENCY |    BALANCE    |
+----------------------+----------+---------------+
| main (GA5OM...TQGGY) | CNY      |    20.0000001 |
+----------------------+----------+---------------+
|                      | XLM      |  9983.3333033 |
+----------------------+----------+---------------+
| sec (GB4LZ...RB2A7)  | XLM      | 10010.0000000 |
+----------------------+----------+---------------+

I like the fact that account boundaries but this new format made a new confusion the other direction:
+-------------------------+----------+---------------+
| escrow (GB25P...IUJSF)  | USD      |     0.0000000 |
+-------------------------+----------+---------------+
|                         | USD      |  9080.0000000 |
+-------------------------+----------+---------------+
|                         | USD      |<PHONE_NUMBER> |
+-------------------------+----------+---------------+
|                         | XLM      | 10009.9974300 |
+-------------------------+----------+---------------+

I do like the grouping and "open spaces" view to show that these things were the same; only crossing the account boundary was the confusing part.
Within the same account, the currencies should group like they did, just not across the account boundaries.  Also, as you can see, this account holds three different USD currencies from three different issuers.   I don't know how/if I want to fix it because I appreciate the conciseness of the display; but I do find it unclear which USD came from which issuer which is something I'd like to see clearly because it matters.  (For the moment I can tell because I know roughly what balances belong to each issuer, but without that "secret knowledge" there'd be no way to distinguish them; perhaps ordering them alphabetically by the asset_issuer account or by nickname if they exist in the database?
If you'd like to test this account, it's:
GB25PA4Z5NF34WSL737ZE7VKBMBPNDJGJAAMHKYCDGYZ6QFPQLDIUJSF
on testnet I call it the "escrow" account.

For now I can add the issuer (something like (GB25P...IUJSF)) in the asset column.


Add Sublime Security to Who's using YARA

hi @plusvic, any guidance you can share on this failing CI check? cheers

Hi, @jkamdjou don't worry about the failing check, it's totally unrelated.


cmsisdap: Check for DAP_Transfer response with more transfers than requested

In #922 it looks like transfer_count which is read from the response data could be larger than self.transfers.len(), so we try and access self.transfers out of bounds. This isn't expected from a probe (it shouldn't be able to execute more transfers than we asked...) but at least makes sense to emit a useful error log and return an Error instead of panicking.
Still a draft because there might be more we can do to fix #922.

As far as I can see no reason to wait on this one. Looks like the related error is probably a dap42 bug?


Get user's preferred name on registration

See https://firebase.google.com/docs/auth/web/manage-users#update_a_users_profile

I have to make another input field for taking name of the user?

Yes, another fields to get the user's preferred name should be sufficient. This data should be then set on the user's firebase profile

Implemented in #67