Animation when programmatically expanding / collapsing nodes

I've noticed a discrepancy in transitional animations when clicking on a node's expand / collapse button vs. when we're expanding / collapsing when utilizing one of the following:
chart.setExpansionFlagToChildren(node, false)
chart.expandLevel(0).setExpanded(node.id, true)
When clicking a node's button, the animation seems to originate from the node we're interacting with. On the flip side when we're doing it programmatically, all of the animation seems to originate from the root node. You can see this behavior on the given example https://stackblitz.com/edit/web-platform-o5t1ha by interacting with the 'expand' and 'collapse' buttons on the right.
Wondering if there is a method exposed to modify this, or if this is set stone.

Basically, if you are invoking this.render ,  animation will originate from root
https://github.com/bumbeishvili/org-chart/blob/c8ebb0490ecfcf1424c16a8528a4a835d3efde53/src/d3-org-chart.js#L471
If you want animation to originate from different place, I think you can invoke update method and pass the specific node
https://github.com/bumbeishvili/org-chart/blob/c8ebb0490ecfcf1424c16a8528a4a835d3efde53/src/d3-org-chart.js#L1127
Haven't tested, not sure if it will work

Hi, yes, it sounds like an expected behavior. I don't think that you can run two parallel transition concerning the same tree (update function processes whole tree not just one node)


HHH-13997  Add methods to SessionImpl and StatefulPersistenceContext; make Loader method protected

Follows: https://github.com/hibernate/hibernate-orm/pull/3385
Backported to 5.4

@DavideD I preferred the previous version of this patch.
Again it works by passing a not-fully-initialized instance of this this to an arbitrary function from within the superclass constructor.
And the thing is, we're already extending this class, so why not just override two more of its methods, instead of doing the same thing (overriding) by passing around function refs. To me that seems a much more straightforward design in the case that we're already have to extend the class for other reasons.

I'm going to revert the last commit so that we can release. And then later we can improve it. Does that work for you @gavinking ?

Yup, perfect.

Merged with the additional commit to revert what we discussed


Sync eng/common directory with azure-sdk-tools for PR 1178

Sync eng/common directory with azure-sdk-tools for PR https://github.com/Azure/azure-sdk-tools/pull/1178  See eng/common workflow

/check-enforcer override

/check-enforcer override


No response for search

t = TPB('https://pirateproxy.tube/')

for torrent in t.search('interstellar'):
    print(torrent.info)

this is my code and the search object doesn't return anything i guess because it is not printing anything. am i going wrong somewhere or is the fault on your side?
piratebay is actually blocked in my country but the url above does work when i open it on my web browser.

I have the same problem

any one solve this yet?


Ory Tunnel requests are 2x slower than hitting Ory Network directly

Preflight checklist

[X] I could not find a solution in the existing issues, docs, nor discussions.
[X] I agree to follow this project's Code of Conduct.
[X] I have read and am following this repository's Contribution Guidelines.
[X] This issue affects my Ory Network project.
[X] I have joined the Ory Community Slack.
[ ] I am signed up to the Ory Security Patch Newsletter.

Describe the bug
I noticed that making a request through an Ory Tunnel is roughly 2x slower than making a request directly to Ory.
I think the culprit is here: https://github.com/ory/cli/blob/5e5efa77c077225c16416d85984d0a311f02e82e/cmd/cloudx/proxy/proxy.go#L180C1-L181C1
My Go is not great, but if I understand correctly, this will call Ory for every request the tunnel/proxy is receiving, even if that request is /sessions/whoami? This means that the identity of the user is verified first and then the actual request is handled, which makes sense for the Ory Proxy when it proxies requests to a separate backend service, but perhaps doesn't make sense if the proxy or tunnel are actually proxying a request to Ory?
Reproducing the bug

Get a session token or cookie from an Ory session
Call Ory directly and time the request duration
Call Ory through an Ory Tunnel and time the request duration

I can provide a more detailed steps to reproduce, but I think the difficulty here is that it requires the specific Ory session token and Ory domain to try with
Relevant log output
No response
Relevant configuration
No response
Version
v0.1.36
On which operating system are you observing this issue?
Ory Network
In which environment are you deploying?
Ory Network
Additional Context
No response

Thank you for raising this issue! It's indeed possible that the root cause is that we're wiring everything through the whoami call, which can slow down all requests.
There's probably a bit of work required to make this better/easier such as "this path needs auth, this doesn't". However, the tunnel is really mostly used for local development and while slow requests are poor experience, we also need to balance how complex the tunnel becomes in terms of codebase and configuration.
What would be your ideal solution?

Thanks for getting back to me. I appreciate your approach to balance complexity, I think it makes sense to try to keep a development tool simple.
Perhaps I'm wrong, but my understanding is that the Ory Tunnel doesn't need to check whoami for anything? It's intended to forward the requests to Ory, so if I'm calling <tunnel-url>/sessions/whoami, the tunnel should just forward that to Ory? Or if I make a <tunnel-url>/self-service/login, this also doesn't need the additional whoami call? I'm not sure I see why the tunnel would need to validate the user? So, could it be as simple as just not adding the checkOry middleware if conf.isTunnel (here)?


will you take a paid project?

can i hire you?

what kind of project? @phillypro

i want to add the ability to get a streamkey streamurl from the instagram project....subzeroid doesnt maitain it at all
so id rather pay to fasttrack that capability
instagram now has it to were we can get those keys from the desktop login browser....but i need a python method so i can automate it instead of fiddling through the browser
and i dont want to use selenium right now

another capability im interested in is posting a post to the stories.....weve always been able to post stories
but not post a post to the stories


Replace strategy setting BsonId

Hi,
on version 1.3.1, is it possible to use key provided in value with writemodel replace but inserting key as Bson, not a string?
{
…
"mongodb.writemodel.strategy": "at.grahsl.kafka.connect.mongodb.writemodel.strategy.ReplaceOneDefaultStrategy", —> replace content if “_id” exists in mongo
"mongodb.document.id.strategy": "at.grahsl.kafka.connect.mongodb.processor.id.strategy.ProvidedInValueStrategy" —> pickup “_id” message
…
}

actual behaviour:
event 0:
kafka message 0:
{"_id": "5e56539be1863fe90d324877", “otherkey”: “value”}

mongodb document is:
{
    "_id" : "5e56539be1863fe90d324877”, —> STRING
    “otherkey”: “value”
}

event 1:
kafka message 1:
{"_id": "5e56539be1863fe90d324877", “otherkey”: “newValue”}

mongodb document:
{
    "_id" : "5e56539be1863fe90d324877”, —>  STRING
    “otherkey”: “newValue”
}

desired behaviour:
event 0:
kafka message 0:
{"_id": "5e56539be1863fe90d324877", “otherkey”: “value”}

mongodb document:
{
    "_id" : ObjectId(“5e56539be1863fe90d324877”),  —> OBJECT
    “otherkey”: “value”
}

event 1:
kafka message 1:
{"_id": "5e56539be1863fe90d324877", “otherkey”: “newValue”}

mongodb document:
{
    "_id" : ObjectId(“5e56539be1863fe90d324877”), —> OBJECT
    “otherkey”: “newValue”
}

thanks in advance
best, Luis

Hi @lazaromedina
thx for reaching out and clearly explaining your use case with sample messages & documents. the question for me is the following though: if the _id field in the kafka message contains always an objectid compliant 24 hex string, why is it not in extended json serialization using $oid see https://docs.mongodb.com/manual/reference/mongodb-extended-json/#example ? then it would work as is.
since it's only the raw hex-string, there is currently no way to support this out-of-the-box. you have two options though to make it work without much effort, yet it involves writing some code.
a) write a custom SMT (single message transform) and add this SMT configuration to your connector config
b) write a custom post-processor for the mongodb sink connector which is probably even easier than a) for your use case
I'm happy to receive a PR of course to integrate this "new" post-processor then into the project 😉  If you need any further information just let me know.

Hi @hpgrahsl,
Thanks so much for the good work and your commitment to this project.
As of now, this issue has been solved managing it as a string. However, as you have already indicated for a more future definitive solution I would have to follow the option b. By then, It will be my pleasure to make a PR.
Again, really appreciated the support.
BR
Luis

Great to hear you got it working for your needs! If you don't mind I'd be happy if you could close this issue then ... at least for now. Feel free to re-open anytime when you start with a definitive solutions for this.


Links are not working in Popover

Upgraded to BS 4.3.1, and found that links in Popover are no working, they appear as simple text.
Bug reports must include:

Operating system and version - (macOS)
Browser and version (Chrome, Firefox, Safari)

Same issue, buttons no longer show in popovers.
Bug reports must include:

Operating system and version - (Windows 10)
Browser and version (Chrome, Firefox, IE11)

worth noting that, ideally, popovers should not be used to contain interactive elements (as it won't work properly for keyboard users) ...

You need to pass data-html="true". Keep in mind that as of 4.3.1, we now pass HTML through a sanitizer before echoing in back to the page (to fix CVE-2019-8331). See the documentation on how to configure this.

Thanks, tried that already, still an issue.
Following is the popover init on page load:
$('[data-toggle="popover"]').popover();
Following is the test button:
<a href="javascript:void(0);" class="btn btn-secondary" id="testbtn"
tabindex="0" data-html="true" data-toggle="popover" data-trigger="focus" data-container="body" data-placement="bottom"
data-content=" Upload"
role="button" data-original-title="" title=""> Actions
Following is the screenshot of output with above code:

javascript: URLs are denied by the sanitizer. onlick will also be stripped by default. See sanitizer.js#L60 and sanitizer.js#L24. See this StackOverflow question for some reasons you shouldn't use javascript:void(0);. More generally, popovers are not a good engine for an action menu because they are not appropriately accessible by keyboard and screenreader users (it's an absolutely positioned div that's aria-describedby, the ARIA attribute for tooltipy things, not navigation).


Mention that Role assignment for the user should be at “Subscription” scope

We should be more specific and mention that role assignment for the user should be at “Subscription” scope.
We are seeing issues where the user is Owner of the Resource Group but still "Run Command" list is not populated for such users. They get below errors :-
"The list of commands is not available due to missing permissions or location-specific limitations."
The user needs Role Assignment at Subscription level to pull the "Run Command" list for the VM
Limiting access to Run Command
Listing the run commands or showing the details of a command requires the Microsoft.Compute/locations/runCommands/read permission. The built-in Reader role and higher levels have this permission.
Recommended change :-
Listing the run commands or showing the details of a command requires the Microsoft.Compute/locations/runCommands/read permission at Subscription scope. The built-in Reader role and higher levels have this permission.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b3ff94e6-3c1f-b9e1-1a46-b75fe2ffca1b
Version Independent ID: 8f3ca735-ddd4-f4a9-4ee0-189604018784
Content: Run PowerShell scripts in a Windows VM in Azure - Azure Windows Virtual Machines
Content Source: articles/virtual-machines/windows/run-command.md
Service: virtual-machines
GitHub Login: @bobbytreed
Microsoft Alias: robreed

Thanks for the feedback! I have assigned the issue to the content author to investigate further and update the document as appropriate.

Thanks for the feedback related to this document.
The goal of that sentence in the doc is to limit permissions. Giving permissions to the subscription scope provides more access than the minimum. At this point in time we are opting to leave the doc as it.
#please-close

This issue is old but if it can be revisited it would be great. It took me a couple of hours to figure out why my permissions were not working, I'm glad I found this issue, it would be great to mention that permissions need to be at the subscription level.  thanks,


DIfferent icon for Draft PRs?

Maybe we can use a different icon for draft PRs

We can set the color to gray actually.
Happy to open a PR?

Yeah. Sadly Phosphor Icons doesn't have an icon for draft PRs.


FR: Open in popup?

Possible feature request?
New to Statamic here and I really like this add-on. What would be really neat, is if it were possible to open the palette in a popup to select a color, then hide the palette but showing the activate color being used.
When using Bard or similar to build pay layours, the picker takes up a lot of real estate, especially if used multiple times in a layout.
Just an idea!

@minemindmedia I like this idea. I'm not sure if I'll have bandwidth for it soon, but I'll try to explore the option.

That's awesome!

@minemindmedia Hows this look? https://d.pr/v/4VvrPx

@minemindmedia Would it be better without the extra button? just show an icon to choose the color?
https://d.pr/v/addpRf

Sorry for the multiple posts... @minemindmedia what about this?
https://d.pr/v/vdnhVd

Hi @vmitchell85
Sorry for the late response! Looks great man!
I think any of those would be awesome.


Cross-shell aliases

I would like to be able to specify aliases for built-in scripts in the mise configuration, so as not to specify the full path to them or parameters for launching:
# define
alias myTool='path/to/my_tool.sh --default-option'

# usage
myTool subcommand <path...> --argument Value --some-option

I know it's possible to create a mise task, but calling mise run seems like a longer command, especially when my script can also take many parameter and component arguments:
mise run myTool subcommand <path...> --argument Value --some-option

If I understand correctly, you can use the env._.source directive and specify the path to the script (for example aliases.sh) in which all aliases will be declared.
BUT I want to avoid spreading the project settings across several files, and keep everything in one configuration mise:
# Aliases of bash scripts
[alias.bash]
myTool='path/to/my_tool.sh --default-option'
# Aliases of ruby scripts
[alias.ruby]
myRubyTool='path/to/stuff.rb'

I think there would be value in having cross-shell aliases in mise similar to https://github.com/cpendery/kaldo

Hi! It may make sense to add the env._.alias directive, since this functionality is close to the path/source directives.

yeah it could go there too

(re the OP https://github.com/jdx/mise/issues/2034#issue-2281176873 I think env._.source doesn't quite do this, as it only pulls environment variables, not aliases or other shell-internal things. What you'd probably do is use env._.path to add a local directory to $PATH, and then put little mini scripts in there for each of your commands. this would still involve the more-distributed configuration the OP doesn't like of course)


Mutiple Entities Extract in Rasa

Hi,
How to extract multiple entities belonging to a different entity name in tracker -- actions.py, say I have
Example: I want to play Badminton on Monday.
Here Badminton belongs to Sports Entity and Monday belongs to Days Entity.
I know how to take entity name belonging to the same Entity using "tracker.get_latest_entity_values("entity name") but not sure on the above issue. Kindly help.
Thanks
Hemanth Naidu S

Lets say you defined two entity types sport and date for your NLU model to extract Badminton and Monday (although for a date you should use a pretrained entity, e.g. ducklings date type).
Now you can get these values in your action by using:
sport = next(tracker.get_latest_entity_values("sport"), None)   # and
date = next(tracker.get_latest_entity_values("date"), None)

They will be set to None if there is no value in the utterance for these entities.


See this  stackoverflow

I had to follow https://stackoverflow.com/questions/45282853/the-language-does-not-change-in-the-asp-net-core-web-application in order to get the example working. Give this documentation to a student and they will be stuck. all of them...

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d1833676-ff1b-c587-cc9c-81afffa8ef68
Version Independent ID: ad989395-3f49-4d55-521e-cf6fe56281ee
Content: Globalization and localization in ASP.NET Core
Content Source: aspnetcore/fundamentals/localization.md
Product: aspnet-core
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

@Rick-Anderson this is seems a localization configuration + javascript issue, we already have done this in Localization.StarterWeb


Return Codes as Test result

For CICD Pipelines it would be very helpful if matchstick return different codes depending on the test results.
E.g. Return Code 0 if all tests succesful and Return Code 1 if one or more tests fail

I'm assuming I can close this Issue?


Docs: the "subcurrency" example doesn't emit a "sent" event

The documentation for Subcurrencies (https://fuellabs.github.io/sway/latest/examples/subcurrency.html) defines a "Sent" event, but doesn't emit it

@dmihal yes, we will have more complex logs. Is logging facility something you need right away? If so we can fast track prioritization.

Depends on #823

This is done


Delete .gitlab-ci.yml

@gbiggs Could you double check permissions for @robbel? He seems unable to approve my pull requests.


Bootstrap only essential values

Is your feature request related to a problem?
When I bootstrap otomi values there are many configuration parameters that are optional.
In particular there are hardcoded container image versions for the otomi-api and otomi-console apps (the latest tag)
However, given otomi-core version are released with specific version of otomi-api and otomi-console not latest one.
@bartboshuizen thank you for pointing this out.
Describe the solution you'd like
Bootstrap only those values that are essential for user to fill in.
Do not bootstrap image tag and pullPollicy.
Additional context
See .demo/env/charts/*

The demo files are problematic as they serve 2 functions:

contain as much as possible configuration to cover code paths
demo files for bootstrap phase

Now, given 1 you can deduce that we want those settings in there, and working. So please don't think that we should remove them there (not now at least).
Taking 2 into account, it is also beneficial that the examples show what is possible.
So I am closing this for now, as I don't see any action related to this observation.

Well, the solution is simple.
Have values for bootstrap and for test for coverage and used both of them while running validation tests.
Please do not ignore our reports. I see you are closing a lot of them, without really consulting it with the team.

I just think that when we bootstrap a new user with values, those should be present. We should not adopt a mindset that avoids yaml configuration because "it looks like a lot of stuff". Instead we should focus on installing those values with minimal configuration changes. After flattening that could be as easy as installing a chart. See https://github.com/redkubes/otomi-core/issues/374.
And I am not making those decisions lightly, I just don't always feel like overly explaining higher order principles.
If you want to make a useful extraction from this issue, then please create a story to get better coverage:

it should have values for each cloud
??

But like I said, demo values should show what is useful. I believe the above example about otomi-api and otomi-console NOT being in the demo values is the wrong direction. IMO they SHOULD be in there as it shows that it is easy to test out new versions of those components without getting guarantees that they will. When components can be upgraded without tests breaking, and after observing them for a while, we can decide to backport those versions in core.

If I buy a new car, I just want to press start button and have a pleasant first journey.
With time and need, I will discover all the parameters.
Maybe, I even tune the engine but only if my first impression is positive.

Maybe you are right, but we should provide demo values imo. That is what they are: demo values. We can provide docs that say you can just toss them away and start fresh. We should bootstrap them next to env in envDemo I think. Then we have to maintain 2 sets of values: demo and clean. Clean setup can just contain the files.

good idea!


Source Control stuck on "Initialize Repository"

Type: Bug
I have a git repository but in the Source Control tab it tells me the currently opened folder doesn't have a git repository.
This applies to all the repositories I have.
Also when clicking "Initialize Repository" in folders that don't have a git repo, it creates the .git folder but the Source Control panel stays the way it is.
 If so, were the repositories originally created when running elevated?
Or is the opposite true (repositories created while elevated, VS Code running unelevated)?

VS Code was running unelevated and the same for when I created the repositories.
I gave it a try just now and nothing changed

OK, so it's not a problem related to elevation. Please continue to launch VS Code normally (ie unelevated).
Does the Git channel of the Output panel give any clues about what is happening?

the output gives me fatal: unsafe repository and a git command
I ran the command and now it works again.
Thank you!


Investigate fixing the description in the swagger json in the re-engineering

The title and description is fed into the swagger doc via this bootstrap.js file in the devops repo. The title and description are set via the manifest-vars.yml files in each API repo or if not set there, then it's set in the app.config.ts file. Within the bootstrap.js file, the custom description and custom css for the description is only set if it is not the production environment. Thus, we may be able to set the description in the manifest-vars file for production for each API and have it populate in the swagger doc if we modify the bootstrap.js file to pull in the description from the config service like it does for the tile etc.


Example condition is incorrect

Current example lists --condition "avg Percentage CPU > 90" as a parameter. This is no longer valid, --condition "avg cpu_percent > 90" must be used. This is also incorrect in az monitor metrics alert create --help

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d97968df-72c9-e50c-d5b1-54562c1bdef7
Version Independent ID: 0cde4f15-6464-3106-b787-3ee37c7de0ee
Content: az monitor metrics alert
Content Source: src/azure-cli/azure/cli/command_modules/monitor/_help.py
Service: monitoring-and-diagnostics
GitHub Login: @rloutlaw
Microsoft Alias: routlaw

add to S169

add to S171

@ikantspel9 I have a test and Percentage CPU still works. Could you share more context about this issue?

close this issue since cannot reproduce. Feel free to open new issue if you still meet such issue.


[HUDI-2005][WIP] Removing direct fs call in HoodieLogFileReader

Tips

Thank you very much for contributing to Apache Hudi.
Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.

What is the purpose of the pull request
(For example: This pull request adds quick-start document.)
Brief change log
(for example:)

Modify AnnotationLocation checkstyle rule in checkstyle.xml

Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end.
Added HoodieClientWriteTest to verify the change.
Manually verified the change by running a job locally.

Committer checklist

[ ] Has a corresponding JIRA in PR title & commit

[ ] Commit message is descriptive of the change

[ ] CI is green

[ ] Necessary doc changes done or have another open PR

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@hudi-bot azure run

@hudi-bot azure run

@hudi-bot azure run

@hudi-bot azure run

@nsivabalan  could you explain why mor-incremental support for hive   affect this pr，is it because of the HoodieLogFile from fileSlice has file size set to 0
Maybe we can find a unified solution

@xiarixiaoyao : yeah. when I initially put up this patch, I assumed HoodieLogFile will always have proper size set. But once the mor incremental refactoring PR got landed, this patch is failing and does not work anymore. I tried looking into the more refactoring patch, but could not get much leads. Can you help me here. Is there anyplace you are not setting the size for HoodieLogFile? or letting it set to 0 by default in any of the code paths.

@hudi-bot azure run

@nsivabalan  i will check it today.

@nsivabalan  i think i have found that why the UT failed。
pls add  those code:
writeStat.setFileSizeInBytes(new File(new Path(basePath.toString(), filePath).toString()).length());
in  the third line in   TestHoodieRealtimeRecordReader.createHoodieWriteStat.
we need setFileSizeInBytes for commitFile.
when i add those code,  everythings is ok.

@xiarixiaoyao : awesome. that worked. thanks a ton.


How to stop audio recording when user is silence without using websockets?

Hi,
I am creating a web application just like google's search by voice. I want to stop recording audio when the user stops speaking. I am building my application in React without using WebSockets. (Right now I am using a timer ).
Can anybody suggest how to implement that?

I'm using something like the following to check for muted devices:
    checkForMutedDevice() {
      let audio = this.stream.getAudioTracks()[0];

      audio.onmute = () => (this.inputIsMuted = true);
      audio.onunmute = () => (this.inputIsMuted = false);

      if (audio.muted) this.inputIsMuted = true;
      else this.inputIsMuted = false;
    }

And something like this to check for sound above a certain level (where rms is a function that calculates the root mean square of the byte buffer, and noAudioRMSThreshold is something like 0.2 - this just means it counts as "no sound" if the audio is "quieter" than this).

      this.stream = navigator.mediaDevices.getUserMedia( ... ) // your options here.

      this.audioContext = new AudioContext();
      let script = this.audioContext.createScriptProcessor(512, 1, 1);

      script.onaudioprocess = (event) => {
        const input = event.inputBuffer.getChannelData(0);
        let vol = rms(input);
        if (vol >= this.noAudioRMSThreshold)  {
          this.heardAudio = true;
        }
      };

      this.mic = this.audioContext.createMediaStreamSource(this.stream);
      this.mic.connect(script);
      script.connect(this.audioContext.destination);

You could easily hook up the recordRTC stop/start recording to that (although bear in mind that onaudioprocess is called pretty frequently depending on browser so you might want to debounce/throttle that).


failed to find root dir: i/o timeout

I often use the following command:
gdrive sync upload --chunksize 134218000 --no-progress <local-path> <gdrive-fileID>
Today, running the same command returns the error:
Failed to find root dir: Get https://www.googleapis.com/drive/v3/files/<gdrive-fileID>?alt=json&fields=id%2Cname%2CmimeType%2CappProperties: dial tcp <IP_ADDRESS>:443: i/o timeout
Running info or list on the same gdrive file ID gives the expected output, so the file ID itself is not the problem.
I'm not sure whether this is caused by a temporary problem with the servers hosting google drive content or a change to their API that breaks the sync upload command but not the info or list commands.

yup, i cant confirm this.

I'm having the same problem in a Jenkins Slave in Amazon EC2. When I'll put the artifacts on Google Drive. The problem started last week.


idk if already supported before

bukkit/spigot/paper support?

Bukkit, Spigot, Paper, Sponge, etc. are far too different (server plugins vs mods) from Forge and Fabric, it's not viable to support them without an entirely separate library.


--version on Windows

Livestream said there was a new version available, but I thought I had already updated.
Running livestreamer-v1.12.0-win32-setup.exe on Windows 7, didn't change the reported version.
Uninstalling and reinstalling still reports as version 1.11.1

livestreamer --version
livestreamer-script.py 1.11.1

This means version 1.11.1 is still installed. Make sure to remove 1.11.1 before you install 1.12.


Antialiasing and MultipleRenderTargets

Hello! I was wondering if it was possible to use multiple render targets as a RenderPass and then use an antialiasing technic such as MSAA EffectPass to try to antialias the result? MSAA should not be possible on a texture as far as I know, but I am a beginner in AA paradigms. That is why I am writing this issue as it seems there is a lot of interesting AA, maybe you might have already tried?
The only solution I am seeing otherwise would be to blit and multisample each layout of the MRT.
If an MRT is provided in a ShaderPass, the next pass could technically antialias it? And is the RenderPass required in that case?
Tried to make a basic example using postprocessing but everything renders black:
https://codesandbox.io/s/deferred-bloom-forked-vyd9q?file=/src/App.js

Hi,
I haven't really touched MRT yet, but it looks like it's currently not possible to use WebGLMultipleRenderTargets with WebGLMultisampleRenderTarget due to the way it's implemented in three. This is something that should be addressed since it's supported in WebGL 2.

If an MRT is provided in a ShaderPass, the next pass could technically antialias it? And is the RenderPass required in that case?

Individual textures of a WebGLMultipleRenderTargets instance could be antialiased with a post effect like SMAA, but MSAA would be better overall if it was available. A RenderPass is always required if you want to render meshes, even if it's just a plane with a texture. I'm currently working on the API to support explicit buffer management which would allow you to use a plain texture as input for a pass, if that's what you want to do.

MSAA should not be possible on a texture as far as I know

Right, MSAA works based on geometry and depth; it's not a post effect and it doesn't affect texture details.

Thanks for the explanation @vanruesc! I did try several times to implement MSAA + MRT directly in threejs without success as WebGLTextures has become pretty hard to understand especially with the latest change of the MSAA for VR.
I think explicit buffer management would be perfect for the moment. I will use SMAA as your implementation looks pretty solid.
I just made a minimalist reproduction of threejs MRT + the SMAA of postprocessing. I think it has some encoding issues as I wanted to give RGBFormat but TextureEffect is expecting, either way, sRGB or Linear, I am not sure how I should send the result of my render target to the SMAA Pass. If in the meantime you have any idea how to solve this encoding issue that would be awesome!
Example MRT + Postprocessing SMAA:
https://codesandbox.io/s/wonderful-spence-0tuwv?file=/src/index.js

I will reopen this issue on threejs to do MSAA with MRT 👍


HDFS-16967. RBF: File based state stores should allow concurrent access to the records

File based state store implementations (StateStoreFileImpl and StateStoreFileSystemImpl) should allow updating as well as reading of the state store records concurrently rather than serially. Concurrent access to the record files on the hdfs based store seems to be improving the state store cache loading performance by more than 10x.
For instance, in order to maintain data integrity, when any mount table record(s) is updated, the cache is reloaded. This reload operation seems to be able to gain significant performance improvement by the concurrent access of the mount table records.

@goiri @ZanderXu @tasanuma could you please review this PR?

Based on one of the testing data points, for the same num of mount table records to be loaded in the cache, avg time taken by default is ~1500 ms whereas with concurrent mode, it goes down to ~130 ms.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 57s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  2s

codespell was not available.

+0 :ok:
detsecrets
0m  2s

detect-secrets was not available.

+0 :ok:
xmllint
0m  2s

xmllint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
41m 49s

trunk passed

+1 :green_heart:
compile
0m 44s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
0m 38s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
checkstyle
0m 29s

trunk passed

+1 :green_heart:
mvnsite
0m 42s

trunk passed

+1 :green_heart:
javadoc
0m 48s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 57s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
1m 32s

trunk passed

+1 :green_heart:
shadedclient
23m 57s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 34s

the patch passed

+1 :green_heart:
compile
0m 37s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
0m 37s

the patch passed

+1 :green_heart:
compile
0m 31s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
javac
0m 31s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 17s

the patch passed

+1 :green_heart:
mvnsite
0m 35s

the patch passed

+1 :green_heart:
javadoc
0m 33s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 51s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
1m 22s

the patch passed

+1 :green_heart:
shadedclient
23m 28s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
22m 11s

hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 34s

The patch does not generate ASF License warnings.

125m 56s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5523/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5523

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint

uname
Linux 1a3d234f15b4 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 0c41ead9dc12fca491f65604bea088c9e19b4a5a

Default Java
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5523/1/testReport/

Max. process+thread count
2917 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5523/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Default mode:

Concurrent access mode:

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 59s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
xmllint
0m  0s

xmllint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
41m 44s

trunk passed

+1 :green_heart:
compile
0m 50s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
0m 37s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
checkstyle
0m 31s

trunk passed

+1 :green_heart:
mvnsite
0m 43s

trunk passed

+1 :green_heart:
javadoc
0m 47s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 55s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
1m 32s

trunk passed

+1 :green_heart:
shadedclient
23m 45s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 35s

the patch passed

+1 :green_heart:
compile
0m 37s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
0m 37s

the patch passed

+1 :green_heart:
compile
0m 32s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
javac
0m 32s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 17s

the patch passed

+1 :green_heart:
mvnsite
0m 35s

the patch passed

+1 :green_heart:
javadoc
0m 32s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 53s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
1m 22s

the patch passed

+1 :green_heart:
shadedclient
23m 26s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
21m 49s

hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 34s

The patch does not generate ASF License warnings.

125m 20s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5523/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5523

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint

uname
Linux a7ef1392030a 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 70d39f0260f784f29f75257793fc0091fba018ef

Default Java
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5523/2/testReport/

Max. process+thread count
2539 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5523/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Thanks @simbadzina, addressed your comments

Thanks for your contribution, @virajjasani.
Thanks for reviewing it, @goiri and @simbadzina.


decomp.rssd utility

Hi,
I’m raising this issue to ask for clarification about the decomp.rssd optimization metric.
According to the documentation, the aim of this loss function is to “steer the model towards more realistic decomposition results”.
Question: Isn’t this optimization metric mitigating one of the benefits of MMM, the possibility to spot channels where we are overspending and channels where we are underspending?

Hi, good question. I think of it this way: When you talk about "the possibility to spot channels where we are overspending ...", you're assuming that MMM can produce the truth. This is unfortunately too good to be true... Users are deciding which "truth" they choose, no matter with Robyn or other MMM solutions. Therefore, the premise of MMM's reality is rather "all models are wrong, but some are useful". In this case, decom.rssd helps us getting rid of the "wronger"/ extreme results. In practise, running experiments and then calibrate MMM is the best thing you can do to get as close as possible to truth.

Hi Gufeng,
thanks for the prompt reply - it makes totally sense 👍


Problem with NgReduxModule in an Ionic 2 rc0 project

Hi,
This might not be an issue with ng2-redux as much as me doing something wrong, but here goes:
In app.module.ts, as soon as i import { NgReduxModule, NgRedux } from 'ng2-redux'; and add NgReduxModule to imports, the app fails on startup with the error Uncaught ReferenceError: module is not defined in an node module called symbol-observables.
Does anyone have a clue what I might be doing wrong?
Edit: I'm using the latest ng2-redux beta.

This may be related to #228

The easiest way to get it up and running in ionic is to add the --dev param to the build script. See https://github.com/driftyco/ionic-cli/issues/1504

Just published a new beta.
Slight change with how you import the module, now should do NgReduxModule.forRoot,
change-log details

This should be fixed in 4.0.0-beta.7. Closing issue; feel free to reopen it if you still have issues with the new version of ng2-redux.


The number of points in ScanObjectNNHardest

The paper claims that 1024 points of each instance are used in  ScanObjectNN. However, the default setting in the code is 2048 and it is ignored in the config file. So, I wonder how many points you used for ScanObjectNN.

Hi, there !😊 Thanks for your questions! We use 1024 points for ScanObjectNN. Please Check the Config file of ScanObjectNN and the parameters num_points in  Config
  common:
    NAME: ScanObjectNNHardest
    data_dir: './data/ScanObjectNN/h5_files/main_split'
  train:
    split: train
  val:
    split: val
    num_points: 1024

num_points: 1024  # the number of points passed into model
num_classes: &nclass
  15

I got it! Thank you!


AppSourceCop rule AS0011 does not enforce mandatoryAffixes on new enumextension values

given app.json:
{
  "id": "6613924d-6740-45a3-b07e-94eda29e7fe9",
  "name": "ALProject1",
  "publisher": "Default publisher",
  "version": "<IP_ADDRESS>",
  "platform": "<IP_ADDRESS>",
  "application": "<IP_ADDRESS>",
  "idRanges": [
    {
      "from": 50100,
      "to": 50149
    }
  ],
  "showMyCode": true,
  "runtime": "7.0",
  "features": ["NoImplicitWith"],
  "suppressWarnings": ["AS0013", "AS0015", "AS0051", "AS0052", "AS0084", "AS0092"]
}

settings.json:
{
	"al.codeAnalyzers": ["${AppSourceCop}","${CodeCop}","${PerTenantExtensionCop}","${UICop}"]
}

AppSourceCop.json:
{
	"mandatoryAffixes": ["FOO"]
}

and finally PurchaseDocumentTypeFOO.EnumExt.al:
enumextension 50100 "Purchase Document Type FOO" extends "Purchase Document Type"
{
    value(50100; Bar)
    {
        Caption = 'Bar';
    }
}

There is no error that the new value Bar has a name without a mandatoryAffix - but surely there should be? The point of affixes is to prevent clashes between fields with the same name (but possibly radically different purposes, etc.) between extensions, and surely enum values are one of the main places where that is likely to happen given enough time.

I would expect the name to be diagnosed as needing renamed to "Bar FOO", and if not the same kind of error on the value name as we get for the enumextension name if dropping the suffix there:

AL extension:
Name: AL Language
Id: ms-dynamics-smb.al
Description: AL development tools for Dynamics 365 Business Central
Version: 7.2.475273
Publisher: Microsoft
VS Marketplace Link: https://marketplace.visualstudio.com/items?itemName=ms-dynamics-smb.al

The fix for this issue has been checked in to the master branch. It will be available in the bcinsider.azurecr.io/bcsandbox-master Docker image starting from platform build number 30045 and VS Code Extension Version 9.0.517327.
If you don’t have access to these images you need to become part of the Ready2Go program: aka.ms/readytogo
For more details on code branches and docker images please read:
https://blogs.msdn.microsoft.com/nav/2018/05/03/al-developer-previews-multiple-releases-and-github/
https://freddysblog.com/2020/06/25/working-with-artifacts/


list of indexes with index scans

After making use of unused_indexes, I started wondering about which indexes were being used, and to what extent. There are some other queries for index usage relative to a table, but it might be nice to have a similar query to unused_indexes, but without the limit of 50.

Hi. https://github.com/pawurb/ruby-pg-extras Ruby version of this library has support for query arguments, that would allow  changing the limit. I'm no longer actively developing this version, but if you're interested in submitting a PR with this feature I'll be glad to release it.


HOT-96682: bump RDS instance class

https://instances.vantage.sh/rds/?compare_on=true&selected=db.m5.large,db.r5.xlarge

Can we just fix the DB table instead?  Won't take too long to do and we won't lose data

Hey @mboudreau , I checked the prod database and it doesn't look we have too much huge JSON blobs:

Hence the problem might be something else.... Given the current state of affairs, I think it was agreed that, sadly, it was safer to have 1-2 mins of data loss than to tolerate this problem until we can find the root cause and apply the proper fix.

UPDATE: looks like our queue was stabilised for some reason... Putting on hold for now


Support for kwargs using CeleryTask interface

Added kwargs support using CeleryTask interface.
Performance gain over original implementation using reflection.

Coverage decreased (-5.6%) to 71.961% when pulling 2544d6720d82fd6ac955137722d3c1f2ccf05027 on interface_task into db0b11f922be26784fc25d1fb166f0c63ea7075c on master.


Mark as thumbnail - Remove thumbnail

Currently, the "Mark as thumbnail" option remains visible even if the position has already been marked as a thumbnail. Change the "Mark as thumbnail" option to "Remove thumbnail" if the position has already been marked as a thumbnail.

Fixed in 1.9.1


Prisma thinks named relation  - @ralation (name:..) - is a field with unique constraint

Bug description
Prisma considers field with named relation @relation(name: "MyRelation", fields:[]...)  as field with unique constraint, even though I have not defined themas unique.
Hence when I try to insert a new record that references same FK, it fails with unique constraint violation.

Note: I am using the named relation to disambiguate multiple fields referencing same table.

For example the following model:

model Code {
  ...
  facilityEmissionSourceActivitySource OrgFacilityEmissionSource? @relation("FacilityEmissionSource_activitySource")
}

model OrgFacilityEmissionSource {
  ...
  activitySource    Code?    @relation(name: "FacilityEmissionSource_activitySource", fields: [activitySourceUid], references: [uid])
  activitySourceUid String?  @db.VarChar(40)
}

Generates the following code:
-- CreateIndex
CREATE UNIQUE INDEX "OrgFacilityEmissionSource_activitySourceUid_key" ON "OrgFacilityEmissionSource"("activitySourceUid");

and
// index.d.ts
export type OrgFacilityEmissionSourceWhereUniqueInput = {
    uid?: string
    unitUid?: string
    activitySourceUid?: string
  }

How to reproduce

Create models in schema.prisma with named relations, e.g.

model Code {
  ...
  facilityEmissionSourceActivitySource OrgFacilityEmissionSource? @relation("FacilityEmissionSource_activitySource")
}

model OrgFacilityEmissionSource {
  ...
  activitySource    Code?    @relation(name: "FacilityEmissionSource_activitySource", fields: [activitySourceUid], references: [uid])
  activitySourceUid String?  @db.VarChar(40)
}

run npm prisma generate
check the generated migration file for CREATE UNIQUE INDEX
check the generated index.d.ts for OrgFacilityEmissionSourceWhereUniqueInput that includes activitySourceUid as one of the fields for unique input.

Expected behavior
Unless explicitly declared as @unique, prima generate should not generate code that handles those fields as unique.
Prisma information
datasource db {
  provider = "postgresql"
  url      = env("DATABASE_URL")
}

generator client {
  provider = "prisma-client-js"
  // Below allows embedding logic within transaction.
  // See https://www.prisma.io/docs/concepts/components/prisma-client/transactions
  previewFeatures = ["interactiveTransactions"]
}

Environment & setup

OS: MacOS
Database: PostgreSQL
Node.js version: v16.14.0

Prisma Version
prisma                  : 3.10.0
@prisma/client          : 3.10.0
Current platform        : darwin
Query Engine (Node-API) : libquery-engine 73e60b76d394f8d37d8ebd1f8918c79029f0db86 (at<EMAIL_ADDRESS>Migration Engine        : migration-engine-cli 73e60b76d394f8d37d8ebd1f8918c79029f0db86 (at node_modules/@prisma/engines/migration-engine-darwin)
Introspection Engine    : introspection-core 73e60b76d394f8d37d8ebd1f8918c79029f0db86 (at node_modules/@prisma/engines/introspection-engine-darwin)
Format Binary           : prisma-fmt 73e60b76d394f8d37d8ebd1f8918c79029f0db86 (at node_modules/@prisma/engines/prisma-fmt-darwin)
Default Engines Hash    : 73e60b76d394f8d37d8ebd1f8918c79029f0db86
Studio                  : 0.458.0
Preview Features        : interactiveTransactions

Hi @ysahnpark , this is an instance of https://github.com/prisma/prisma/issues/10503 — Prisma Migrate will create a unique in that place, and we rely on that unique constraint to enforce that the relation is one-to-one, and not one-to-many. We want to change that behaviour so it becomes closer to your intuition. I am personally pushing for this to be included in the next major release of Prisma and hope it will make it. Thanks for reporting the issue! let's track progress on this in https://github.com/prisma/prisma/issues/10503


ericoid, dagged (logical-conflict)

This pull request was generated by the 'mq' tool

/trunk merge


Read files from actual CDRs and output json in an app

I wasn't going to do much more, but I'd certainly help integrate if it has messed things up.

I think it’s perfect and didn’t mess anything up, I hadn’t read things well enough by email. that said i reserve the right to ask for help if i need it :)

ok @kwalcock and @MihaiSurdeanu -- I moved the ConceptSink (and think I accounted for the no sentences thing) to processors.  However, do you think the other two (ConceptSource and the App) belong there?  They seem so use-case specific.  Which makes me wonder if I should actually move all of the concept discovery stuff to a separate repo.  Then they'll need to publishLocal two repos, but still.
FWIW:
I can convince myself that discovering and ranking concepts is general purpose.
I feel like the ConceptSink is generally useful bc it's exporting the ScoredConcepts.
thoughts?

for reference: https://github.com/clulab/processors/pull/486

IM(not exceedingly strong)O all three and the rest of the discovery classes should be in a separate repo in the beginning and then only as they stabilize be moved "up" to processors.  Libraries are meant to change slowly and only leaf nodes of the dependency graph should be published locally.  Eidos was OK for that, but if it's too big, then better a new one than processors.  If the app shouldn't be an app, that's no problem.  It seemed like someone somewhere would need one, though.  It's a tiny amount of code, so please don't worry too much.

i kinda agree with Keith. I also don't have a very strong opinion. The openie subproject in processors is a natural fit for this, so I'd be Ok too if you moved them there directly.

closing bc code in conceptdiscovery repo, can reopen if desired


Structure/Type Cross References

In IDA, structure members can be cross referenced to their use across the entire database. In HexRays, structure members can be cross referenced to their use in a single function, but it includes the access type (read or write).
Binary Ninja should allow structure members to be cross referenced across the entire database as well as including their access type. Read and write accesses would be nice, but also a version of an execute access would be nice. Possibly as a specialization of the read access (a deref+call?).

Along this line, enumerator references would also be helpful.

Along this line, enumerator references would also be helpful.

The initial support for type xref and var xref are pushed to dev 2.2.2648. And I will likely continue to work on improvements for it.


Fix docs for count_above, and clarify the relationship between count_…

…above and count_below

This fixes issue #72

Obsoleted by Theo's other PR.  Closing.


Entities like Thaumcraft's Wisp not rendered

In JER tab i cant see any entity rendered in window of entity:
List of entities without render:
Thaumcraft:

Wisp
Taint Swarm
Eldritch Guardian
Eldritch Warden

Twilight Forest:

Firefly

Ice and Fire:

Pet Shop Owner

The Wisp, Taint Swarm and Firefly are actually invisible entities that render with particle effects, so the visual representation of these creatures is just particles. Because JER renders a static model of the creatures without the particles, they appear invisible.
There is nothing I can do about this issue without rewriting JER's render code or creating a custom entity for the invisible mobs. If the issue bothers you, you can disable the missing creatures in the JEM config.
As for the Pet Shop Owner, there was some issues with Rats villagers, specifically the Plague Doctor, causing render issues with all other villagers. This required me to do some weird stuff to fix the villagers. If you are using Entity Culling you may want to check to make sure that it is not causing the JER entities to be invisible. This was known to occur with mobs in  Chocolate Quest: Repoured.
What version of Rats are you using and are there any other villagers that are not being displayed?

If the issue bothers you

No, its not bother me much, i just reported since wasnt sure issue is known.

other villagers not being displayed?

All other villagers, including Plague Doctor rendered fine.

make sure that it is not causing the JER entities to be invisible

I do use EC. How to "make sure"?

I managed to track down the issue with the Pet Shop Owner.
The Villager Names mod modifies the render code for villagers and causes a NullPointerException when JER attempts to render the Pet Shop Owner. You can see this error spammed in the latest.log while you have the Pet Shop Owner villager trade open in JEI.
[00:14:07] [Client thread/ERROR]: Couldn't render entity
java.lang.NullPointerException: null
	at astrotibs.villagenames.client.renderer.entity.RenderVillagerModern.getEntityTexture(RenderVillagerModern.java:113) ~[RenderVillagerModern.class:?]
	at astrotibs.villagenames.client.renderer.entity.RenderVillagerModern.getEntityTexture(RenderVillagerModern.java:22) ~[RenderVillagerModern.class:?]
	at net.minecraft.client.renderer.entity.Render.bindEntityTexture(Render.java:127) ~[bzg.class:?]
	at net.minecraft.client.renderer.entity.RenderLivingBase.renderModel(RenderLivingBase.java:334) ~[caa.class:?]
	at net.minecraft.client.renderer.entity.RenderLivingBase.doRender(RenderLivingBase.java:240) [caa.class:?]
	at net.minecraft.client.renderer.entity.RenderLiving.doRender(RenderLiving.java:50) [caf.class:?]
	at net.minecraft.client.renderer.entity.RenderLiving.doRender(RenderLiving.java:16) [caf.class:?]
	at net.minecraft.client.renderer.entity.RenderManager.laggoggles_trueRender(RenderManager.java:413) [bzf.class:?]
	at com.github.terminatornl.laggoggles.tickcentral.RenderManagerAdapter.redirectRenderEntity(RenderManagerAdapter.java:18) [RenderManagerAdapter.class:1.12.2-5.9-140]
	at net.minecraft.client.renderer.entity.RenderManager.renderEntity(RenderManager.java) [bzf.class:?]
	at jeresources.util.RenderHelper.renderEntity(RenderHelper.java:96) [RenderHelper.class:?]
	at com.invadermonky.justenoughmagiculture.integrations.jei.categories.jer.villager.CustomVillagerWrapper.drawInfo(CustomVillagerWrapper.java:50) [CustomVillagerWrapper.class:?]
	at mezz.jei.gui.recipes.RecipeLayout.drawRecipe(RecipeLayout.java:158) [RecipeLayout.class:?]
	at mezz.jei.gui.recipes.RecipesGui.drawScreen(RecipesGui.java:222) [RecipesGui.class:?]
	at net.minecraftforge.client.ForgeHooksClient.drawScreen(ForgeHooksClient.java:396) [ForgeHooksClient.class:?]
	at sun.reflect.GeneratedMethodAccessor56.invoke(Unknown Source) ~[?:?]
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_51]
	at java.lang.reflect.Method.invoke(Method.java:497) ~[?:1.8.0_51]
	at net.optifine.reflect.Reflector.callVoid(Reflector.java:669) [Reflector.class:?]
	at net.minecraft.client.renderer.EntityRenderer.updateCameraAndRender(EntityRenderer.java:1462) [buq.class:?]
	at net.minecraft.client.Minecraft.runGameLoop(MinecraftAccessor.java:1119) [bib.class:?]
	at net.minecraft.client.Minecraft.run(MinecraftAccessor.java:8114) [bib.class:?]
	at net.minecraft.client.main.Main.main(SourceFile:123) [Main.class:?]
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_51]
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_51]
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_51]
	at java.lang.reflect.Method.invoke(Method.java:497) ~[?:1.8.0_51]
	at net.minecraft.launchwrapper.Launch.launch(Launch.java:135) [launchwrapper-1.12.jar:?]
	at net.minecraft.launchwrapper.Launch.main(Launch.java:28) [launchwrapper-1.12.jar:?]

Unfortunately, this is one of those situations where there is no good fix.
You can disable the Rats villager fix in the JEM config, which will fix the display bug, but it will cause the Plague Doctor to render incorrectly and may cause issues with other villager textures not loading correctly.
Alternatively, you can keep the fix enabled and the Pet Shop Owner will remain invisible and will throw those errors when JER attempts to render the entity.

As an aside, since you are looking for issues (which I appreciate) you may notice that the Twilight Forest Frost Queen and the Questing Ram do not have JER pages. Both of these entities caused CTD's when JER attempted to render them and I was unable to fix the issues. The Frost Queen ended up being excluded from JER integration, but I put the Questing Ram rewards in the Dungeon category as a workaround.

I will have some play with configurations and report the results.

Questing Ram

Before JEM i used my own JEI tab for mob drops. I used Draconic Evolution Mob Soul as entity representation. Its rendering mobs, including Questing Ram just fine.

JER entity rendering is... not great. That was part of the reason I stopped adding mods to JEM. About 1 out of every 3 mods required me to rewrite JER handlers and either crowbar them into JER's code or create custom handlers specific to that one situation.
I was having to rewrite entire render code for individual entities just so they wouldn't crash the game or break JER.

@Invadermonky You could consider forking JER?

Forking JER is kind of a messy topic. The JER license allows for forking, bug fixing and modifying the code but does not explicitly allow redistribution. I would have to rewrite a large chunk of the codebase to fix some of the issues and if I use any of the original JER code, it can be taken down.
In order to avoid the licensing issues I would have to rewrite the entire mod from scratch which would be a massive undertaking.


does not scrollback to first tab

I have 4 tabs in my activity and here's the scenario:

From the first tab, scroll all the way to the last/4th tab.
Click the first tab indicator.

Expectes results:

Scrolls back to first tab
Actual results:
-Nothing happens. Does not scroll back to first tab
-This only happens to the first tab. Other tabs(2nd & 3rd) work fine.

https://github.com/yanzm/MaterialTabHost/pull/1

I found solution.
tabHost.setOnTabChangedListener(new TabHost.OnTabChangeListener() {

            @Override
            public void onTabChanged(String tabId) {
                             viewPager.setCurrentItem(tabHost.getCurrentTab());
            }
        });


Add language option to nav bar

Describe the solution you'd like
Since phpvms supports multiple languages, it would be useful to add the option for site users to select their language of choice. Particularly, adding an option on the nav bar or in an additional location that's easily accessible would be a huge advantage when running airlines that are international.
Describe alternatives you've considered
Other options may be adding /{your_language}/ to the URL or adding a setting in the Admin panel

Does #1020 solve this issue?

Yes it does


Log4j can't be overrided from the classpath or files section

I am trying to redefine log4j file for the Spark application. I set it up in the src/main/resources folder. So this file is in the jar file. In this log4j file, I defined output in the JSON format.
When I run Spark application with Spark operator the logs are in the standard format. I tried to get Log4j debug output:
log4j: Trying to find [log4j.xml] using context classloader sun.misc.Launcher$AppClassLoader@bebdb06.
log4j: Trying to find [log4j.xml] using sun.misc.Launcher$AppClassLoader@bebdb06 class loader.
log4j: Trying to find [log4j.xml] using ClassLoader.getSystemResource().
log4j: Trying to find [log4j.properties] using context classloader sun.misc.Launcher$AppClassLoader@bebdb06.
log4j: Using URL [jar:file:/opt/spark/jars/kubernetes-model-2.0.0.jar!/log4j.properties] for automatic log4j configuration.
log4j: Reading configuration from URL jar:file:/opt/spark/jars/kubernetes-model-2.0.0.jar!/log4j.properties
log4j: Parsing for [root] with value=[INFO, stdout].

So it looks like my log4j file is not found. I defined it as a file in Spark application custom object definition but the file is still not resolved and the output in the debug is just the same.
Why Log4j is not found in the classpath and why it is not loaded from the files section?
Here is my Spark application configuration:
apiVersion: sparkoperator.k8s.io/v1alpha1
kind: SparkApplication
metadata:
  name: spark-example
  namespace: default
spec:
  type: Scala
  image: gcr.io/spark-operator/spark:v2.4.0-gcs-prometheus
  mainClass: example.SparkAppExample
  mainApplicationFile: local:///tmp/spark_app_example_2.jar
  mode: cluster
  sparkConf:
    "spark.driver.extraJavaOptions": "-Dlog4j.debug"
  files:
    - file:///tmp/log4j.xml
  arguments:
    - "k8s://https://<IP_ADDRESS>:8443"
  volumes:
    - name: jar-pv-storage
      hostPath:
        path: /hosthome/roksolana/Documents/WORK/TBC/tbc/Spark_App_CI_CD/target/scala-2.11
        type: Directory
  driver:
    coreLimit: 1000m
    cores: 0.1
    labels:
      version: 2.4.0
    memory: 1024m
    serviceAccount: default
    volumeMounts:
      - name: jar-pv-storage
        mountPath: /tmp
  executor:
    cores: 1
    instances: 1
    labels:
      version: 2.4.0
    memory: 1024m
    volumeMounts:
      - name: jar-pv-storage
        mountPath: /tmp
  imagePullPolicy: Always
  monitoring:
    exposeDriverMetrics: true
    exposeExecutorMetrics: true
    prometheus:
      jmxExporterJar: "/prometheus/jmx_prometheus_javaagent-0.3.1.jar"
      port: 8090

Are you expecting the file log4j.properties in /opt/spark/jars/kubernetes-model-2.0.0.jar or local:///tmp/spark_app_example_2.jar?

I expect it in mounted jar file as a volume which is 'local:///tmp/spark_app_example_2.jar'

Based on the logs, log4j.properties in /opt/spark/jars/kubernetes-model-2.0.0.jar gets picked up.

Exactly, it looks like it. So how my custom log4j file can be picked up?

You can try to do the following:

Put your custom log4j.properties into your image:

spec:
    driver:
        javaOptions: -Dlog4j.configuration=/path/to/log4j.properties
    executor:
        javaOptions: -Dlog4j.configuration=/path/to/log4j.properties

I use the standard image gcr.io/spark-operator/spark:v2.4.0-gcs-prometheus for the Spark application custom object. So should I add a log4j file by creating my own image based on this image?

Yes, you will need to build a custom image. You can put your log4j.properties under /opt/spark/conf in the image.

But is that possible to get a log4j file as mounted config map instead of building custom image?

Oh, yeah, you can use a ConfigMap.

For some reason, the configmap is mounted but my custom log4j file is still not resolved:
Using Spark's default log4j profile: org/apache/spark/log4j-defaults.properties
Spark application custom object looks like this:
apiVersion: sparkoperator.k8s.io/v1alpha1
kind: SparkApplication
metadata:
  name: spark-example
  namespace: default
spec:
  type: Scala
  image: gcr.io/spark-operator/spark:v2.4.0-gcs-prometheus
  mainClass: example.SparkAppExample
  mainApplicationFile: local:///tmp/spark_app_example_log4j.jar
  mode: cluster
  arguments:
    - "k8s://https://<IP_ADDRESS>:8443"
  volumes:
    - name: jar-pv-storage
      hostPath:
        path: /hosthome/roksolana/Documents/WORK/TBC/tbc/Spark_App_CI_CD/target/scala-2.11
        type: Directory
    - name: log4j-config
      configMap:
        name: log4j
  driver:
    coreLimit: 1000m
    cores: 0.1
    labels:
      version: 2.4.0
    memory: 1024m
    serviceAccount: default
    volumeMounts:
      - name: jar-pv-storage
        mountPath: /tmp
      - name: log4j-config
        mountPath: /tmp/log4j
    javaOptions: "-Dlog4j.configuration=/tmp/log4j/log4j.xml"
  executor:
    cores: 1
    instances: 1
    labels:
      version: 2.4.0
    memory: 1024m
    volumeMounts:
      - name: jar-pv-storage
        mountPath: /tmp
      - name: log4j-config
        mountPath: /tmp/log4j
    javaOptions: "-Dlog4j.configuration=/tmp/log4j/log4j.xml"

Config map mount works just fine. Thanks.

FYI you can set variables by adding this strings to your kubernetes manifest:
spec:
  ...
  driver:
    ...
  executor:
    ...
  sparkConf:
    ...
    "spark.driver.extraJavaOptions": "-Dlog4j.configuration=file:///opt/config/log4j.properties"
    "spark.executor.extraJavaOptions": "-Dlog4j.configuration=file:///opt/config/log4j.properties"

You can try to do the following:

Put your custom log4j.properties into your image:

spec:
    driver:
        javaOptions: -Dlog4j.configuration=/path/to/log4j.properties
    executor:
        javaOptions: -Dlog4j.configuration=/path/to/log4j.properties

What is the format for file path?
Is it local:///path/to/log4j.properties or file:///path/to/log4j.properties?


Allow BA or Util priority in assigning FERC 714 respondent_type

Currently we assume that a FERC 714 respondent is a Balancing Authority if its ID shows up in the list of Balancing Authority IDs, and a Utility if it does not. We could also make the reverse assumption, and would get a different set of geometries. LBL has requested that we make both options possible for comparison.
This will mean a change to the pudl.analysis.demand_mapping.categorize_eia_code() function to allow selecting which type of entity should have priority.

This was accidentally created as a duplicate of #628


Motivation for the new signal streams?

Hello!
After spending a lot of time reading closed issues, merged pull requests, and code, I am still uncertain I understand the motivation for the new concept of signal streams, which will be released with the upcoming version 0.10.0.
Prior to the introduction of signal streams, raw IOs had the capability to specify a group_id for each signal channel. With signal_group_mode = "group-by-same-units" (default since 0.9.0), signals with common characteristics (i.e., sampling rate, data type, and group id) were combined into one multi-channel AnalogSignal, and a Group was created for them (caveat: if the group contained signals with different units, these were split into subgroups).
Signal streams seem to be a replacement for the old concept of signal groups. One difference I have noticed is that, whereas the old signal groups could only have an id, the new signal streams can be named, which can certainly be useful. Otherwise, I don't understand how they differ. Were stream names the primary motivation? Or perhaps there was a performance gain obtained by refactoring?
If streams are essentially just nameable signal groups, why not continue to call them signal groups, in accordance with the Group class that they are analogous to? Why introduce this new term "stream"? The change seems to indicate there are important differences, and consequently I have spent a lot of time searching for them (in vain, haha 😅).
Are there important aspects that I have overlooked?

Salut Jeffrey,
yes indeed, this signal_tream is totally the replacement of this "group_id"  (same signal caracteristics).
But now there is explicitly a structure in header for that.
Main motivations for this:

handle annonations for this "streams" (aka group)
handle array_annotation. Needed for long time)
better API for other project that are "mono stream" (spikeinterface)

About the movitation for naming, I don't know it could be "group_id" also like before.
But now, this stream_index is part signature of: get_signal_size()/get_signal_t_start()/get_analogsignal_chunk().
In was not the case before.
I wanted to be sure that developer would focus on this small change!!
A change in naming "group > stream" ensure that accustomed devs focus on it.
And it works :)
In short, concept have not change. API have change just a little. Name have change.
This rawio is rather internal, so the impact is low for users.
Except for spikeinterface devs and ephyviwer of course.
@PeterNSteinmetz was in the same feeling than you. If you want to a petition to come back on "group_id" I am open héhé.

My view is that group_id is a somewhat better name and since the argument name is different than the names in the prior signature, that should work. If it is going to be changed, certainly should be done prior to the 0.10 release.
However, even more important than that name change, I think, is incorporating PR #970 which considerably clarifies this entire idea of grouping and makes it more explicit.

*smacks forehead many times*
I can't believe I overlooked @PeterNSteinmetz's issue (#969) and pull request (#970) on exactly this topic! I will check them out when I have more time. At a glance, it looks like this issue is redundant, so I will close it.


python-package: fix eval_at

eval_at has been broken after e465f92aa389b42da3cd596a2df4a59ae5032de7.
This commit will fix eval_at.

@henry0312 @wxchan
I think we have this alias: https://github.com/Microsoft/LightGBM/blob/master/include/LightGBM/config.h#L388

This is not problem.
The problem is that we can't pass eval_at (ndcg_eval_at) to Booster now.


Add namespace to support multiple nodes

Overview
If we have two CAN buses, we'd like to launch socket_can_bridge multiple times.
However, the current code doesn't support such a use case.
Ideally, it's better if we can use <push-ros-namespace> for launch.py, but it seems not supported, right?
So I've added namespace arg to support this use case.
Note: matches_node_name was replaced by matches_action for easiler code.
How to test
Prepare
sudo modprobe vcan

# CAN Bus 1
sudo ip link add dev vcan0 type vcan
sudo ip link set vcan0 up

# CAN Bus 2
sudo ip link add dev vcan1 type vcan
sudo ip link set vcan1 up

Test
$ ros2 launch ros2_socketcan socket_can_bridge.launch.xml namespace:=bus1 interface:=vcan0
$ ros2 launch ros2_socketcan socket_can_bridge.launch.xml namespace:=bus2 interface:=vcan1

$ ros2 node list
/bus1/socket_can_receiver
/bus1/socket_can_sender
/bus2/socket_can_receiver
/bus2/socket_can_sender
/launch_ros_2251954
/launch_ros_2253074

$ ros2 topic list
/bus1/can_rx
/bus1/can_tx
/bus1/socket_can_receiver/transition_event
/bus1/socket_can_sender/transition_event
/bus2/can_rx
/bus2/can_tx
/bus2/socket_can_receiver/transition_event
/bus2/socket_can_sender/transition_event
/parameter_events
/rosout

$ ros2 lifecycle get /bus1/socket_can_sender
active [3]

$ ros2 lifecycle get /bus2/socket_can_sender
active [3]

# Run `cansend vcan0 123#45` background
$ ros2 topic echo /bus1/can_tx
header:
  stamp:
    sec:<PHONE_NUMBER>
    nanosec: 346618145
  frame_id: can
id: 291
is_rtr: false
is_extended: false
is_error: false
dlc: 1
data:
- 69
- 0
- 0
- 0
- 0
- 0
- 0
- 0
---

@JWhitleyWork Could you review this, please? :smile:

Or, is it better to write a bridge node in C++ instead of launch.py like this?
https://github.com/astuff/kvaser_interface/blob/56b65758814a6d56ad04a6008334514d84123a8c/src/kvaser_can_bridge.cpp#L52-L73

I guess <push-ros-namespace> is also enable for launch.py
<launch>
  <group>
    <push-ros-namespace namespace="test"/>
    <include file="$(find-pkg-share ros2_socketcan)/launch/socket_can_bridge.launch.xml" >
      <arg name="interface" value="vcan0" />
    </include>
  </group>
</launch>

❯ ros2 topic list
/parameter_events
/rosout
/test/can_rx
/test/can_tx
/test/socket_can_receiver/transition_event
/test/socket_can_sender/transition_event

@wep21 Thank you! Probably I made some mistakes... :cry:
I'm sorry, I'll check it again!

@wep21 Confirmed that push-ros-namespace works only AFTER my modification.
I guess push-ros-namespace sets LaunchConfiguration('namespace') implicitly or something like that..:thinking:
I'll investigate a bit more detail.

Fixed lint.
As I used isort with this settings, the new-line between modules are removed. (I couldn't find the setting...)
[settings]
force_sort_within_sections=true
known_third_party=launch

I leave a note about ament_flake8 for others here.
ament_flake8's results on my local and CI were different. It was because of flake8 plugins.
For example, if we install flake8-import-order then ament_flake8 checks I100, but if not installed, it doesn't check it.
So I haven't installed flake8-import-order because I installed ROS using apt.
If we install ROS from source, many flake8 plugins are installed, and ros-tooling's docker image installs them.

Back to the main subject, the reason why push-ros-namespace didn't work was namespace was set to / if it's "" or None.
I found one workaround to avoid this, using TextSubstitution.
This is not beautiful, but I think not so bad for now.

I've created an issue here https://github.com/ros2/launch_ros/issues/220.

Interesting find! Thanks for looking into this. I'm fine with the changes.


fix prewarming post deploy

preheat invocation_type RequestResponse

This is a 🐞 bug fix.

[ ] I've added tests (if it's a bug, feature or enhancement)
[ ] I've adjusted the documentation (if it's a feature or enhancement)
[ ] The test suite passes (run bundle exec rspec to verify this)

Summary
Fixes the prewarming call post jets deploy.  Using invocation_type: RequestResponse so there's a resp.payload from the resp = lambda_client.invoke call.
Future versions of Jets uses a RequestResponse invocation time also because the extra resp.payload data is useful for printing and debugging.
Context
Reported in the community forums https://community.boltops.com/t/cant-deploy-basic-api/1160/5
How to Test
Go through one of the Jets learn guides
Version Changes
Patch

Released in 5.0.13


improve startup time

Following the new recommendation to pass the package name explicitly: steelbrain/package-deps#41

Published in v1.5.0.


fix: fixed CosmosDb parameter name in Readme

createCosmosDB to createCosmosDb
Description
Found a small typo in the project generated readme file, that prevented the Cosmos DB resource to not be created, if used as described. The value is case sensitive, and is written as createCosmosDB instead of createCosmosDb.
I was provisioning the Azure infrastructure for an article I wrote about MBF and found out the Cosmos DB resource was still being created although I used the correct described value set as false.
After looking into the script code, I realized that the value had a typo, and recreated with the correct parameter name. It worked. :)
Task Item
Didn't found an issue related to it. #minor
Screenshots

@cwhitten added new PR change here to avoid merge problems

Thank you for the contribution!


Getting AttributeError when trying to split coins

I'm getting the following error when trying to split my coins. Please advice.

OK, this is the same as #7 ...
For now I recommend you can follow [https://github.com/markblundeberg/coinsplitter_checkdatasig/blob/master/doc/coinsplitter_user_guide.md#splitting-other-wallets-hardware--cold-watching-only--non-electron-cash](these steps) as a backup plan.
Or you can wait for me to fix bug, which I should get around to in next couple of days.

I have the same issue. However, I am able to open the split dialog via right-click on any of the receiving addresses as described in the readme https://github.com/markblundeberg/coinsplitter_checkdatasig/blob/master/doc/coinsplitter_user_guide.md#from-address-list

Fixed in 52a1b53


Load KAKAROT_ADDRESS and PROXY_CLASS_HASH from .env

Time spent on this PR: 0.5
Pull Request type
Please check the type of change your PR introduces:

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] Documentation content changes
[ ] Testing
[ ] Other (please describe):

What is the current behavior?
Kakarot contract address and proxy account class hash are stored in a constants.rs file however they are meant to change often (depending on devnet/testnet/mainnet, on new deployments)
What is the new behavior?
Values loaded from .env file
Does this introduce a breaking change?

[ ] Yes
[x] No

Other information

Tests fail, could it be that in CI, env variables aren't properly injected?


parallelize RMS capture and audio recording

Hello,
I'm working on a project that starts two scripts using cronjob at the same time. One should record the audio while the other take the RMS values. Is it possible parallelize RMS capture using soundmeter and recording audio at the same time with the same input audio device?

You can try. I believe you are able to open multiple stream from the same audio device.


llvm: backport patch for musl 1.2.4

Description of changes
See #228712.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

(perhaps obvious but in case anyone else was wondering about LLVM 16 like I was: https://github.com/llvm/llvm-project/commit/5cd554303ead0f8891eee3cd6d25cb07f5a7bf67 has already been backported: https://github.com/llvm/llvm-project/commit/a468d1914de53d436ffe51c7889e13f08ff25971)

Feel free to merge. :)


Send one min RPC while tracker popups are open, and close tracker popups on userChanged notification

@keybase/react-hackers
Two changes here:

Whenever a tracker window's open, it sends the new track.checkTracking RPC to the service once every minute.  The service rate limits the RPCs itself (one check per 50 seconds).
Listen to the new tracking notifications channel for a NotifyTracking.trackingChanged RPC that comes with a username/uid. When we get it, fire a tracker:userUpdated action on that user. In the reducer, set closed to true, which makes the tracker popup for that user go away.

I would have liked to use Redux to centralize the RPC sending and timers to one place, but actions aren't supposed to have side-effects (like firing RPCs) and reducers can't create actions, so I think Redux is incompatible with this particular flow.  Happy to hack together on it with someone if they can see a good way to do it, though!
CC @oconnor663

I picked a 30 second limit on the theory that there was going to be one caller every minute, so I wanted to avoid weird timing conditions where the next call came just before the limit expired, and we ended up only checking every 2 minutes. But if we're going to have many callers, maybe it makes sense to bump the limit closer to where we actually want it? 55 seconds or something?
Currently we set that rate limit here: https://github.com/keybase/client/blob/41102688866c753791328a1c2efc0c1dc4e4bfd7/go/service/track.go#L73

@oconnor663 Sure, 50 seconds sounds good to me.  I'll add that to this PR.  Thanks!

@oconnor663<PHONE_NUMBER> look okay?

Looks good.

@MarcoPolo @chrisnojima Responded to review comments and refactored to use Redux for keeping track of the timer, following Marco's idea.  PTAL, thanks!

:+1:

You got some flow issues

@MarcoPolo Thanks!  Back down to "Found 0 errors", PTAL?

:ship: :it:


Create announcement feature

As title, description elements, and calendar transition downward, text bubble png transitions in along with the announcement.
Todos:

Title/description/calendar transitions (should padding for each element change with vertical transition?)
Fade in graphics/speech-bubble.png
Ingest announcement from json/announcment.json

Added an announcement bubble and text that fade in after the arc has done one complete round.


DCOS-37432 - [1.11] improve merge data

This is the porting of the 1.10 performance improvement #2960.
Please note that on 1.11 we changed the name of the class, and stop getting the hostname on mergeData. I would test this with more care and see if we still showing the right data.
Checklist

[X] Did you add a JIRA issue in a commit message or as part of the branch name?
[X] Did you add new unit tests?

This repo has @mesosphere-mergebot integration. You can interact with the following commands.
@mesosphere-mergebot integrate
@mesosphere-mergebot ship-it
@mesosphere-mergebot test

alfred run tests

rebased, waiting for tests to pass

@bstavroulakis I think I fixed that now, please take another look :)

Those tests pass locally: I triggere a re-run
====> Successfully finished tests for pages/services/TasksTable-cy.js

Needs port of https://github.com/dcos/dcos-ui/pull/2982

Rebased, should be reviewable now.

This needs a small fix once #2987 lands.

@Fabs #2987 got merged 👍

@juliangieseke fixed.

@DanielMSchmidt, @bstavroulakis or @juliangieseke could you check again?


Strange error message no header

I got the strange error message above.
My solution runs fine locally.
What has happend?

This issue no longer appears.
Thank you guys


Stray hash after closing modal

When a model is closed, a stray hash remains in the URL.

http://example.com/
Open model
http://example.com/#example-modal
Close modal
http://example.com/#

This can be easily worked around by listening for a close event an using replaceState - however I don't thing it's expected behaviour. In fact, I would expect the URL to return to what it was perviously - if the hash is already populated, the last state should return:

http://example.com/#section
Open model
http://example.com/#example-modal
Close modal
http://example.com/#section

The same here. Any suggestion?

+1

+1

+1

Any news on this? Cheers!

No suggestion?

I've found a way to fix this problem.
In remodal.js find
Remodal.prototype.close = function(reason) {
and look for
location.hash = '';
then add the following code underneath it
history.pushState({}, document.title, location.href.replace('#', ''));
This clears the # from the URL upon closing the popup via the wrapper and buttons.
Hope this helps!


Combining items

Is something like this: https://github.com/atlassian/react-beautiful-dnd/blob/master/docs/guides/combining.md possible with this lib?
I need grid and merge support (for merge I mean exactly dragging one item to drop it over another item)
I think this would be simple to implement. I'd just need a "delayAnimationBasedOnDistance" prop (clearly the name isn't too good) in order to not start the animation if the dragged items moves only of (let's say) 200px and do something on over, if left there the "onSortEnd" function will take care of remove that item from the array and do something else with it.
I believe this "delayAnimationBasedOnDistance" could also be implemented without touching the codebase, basically I could register an onMove callback and keep the other items still until the cursor moved of N pixels.
What do you think? Should this work for you? If so I could do a PR.

How does this differ from the distance prop?
With regards to combining items, it should be feasible assuming you manage the selection / combining of the items in your app and leverage the updateBeforeSortStart prop

@clauderic it differs from the distance prop since when you set that prop, if you don't do a certain distance with the cursor while clicking, it will not enable the "animation" of the item being removed from the flow. What I ask is that if you are already dragging around an element and don't do a certain distance, THE OTHER items (so not the one you're already dragging) will not animate.
Honestly I don't get how I could use in this scenario the updateBeforeSortStart... the problem is that if I place an item over another item, the one below will very soon move at its left or right to make room for the item I'm dragging

It this is not enough I can make a gif

If you could provide a gif, that would be helpful, as I'm still not sure I understand your use-case completely.
I just put together an example for grouping items that I'm going to add to the storybook:

See https://github.com/clauderic/react-sortable-hoc/pull/511 for details and the code, I think this is similar to what you're describing and could be a good starting point for you to achieve what you're looking for

Sorry but it's true that I said I could do a gif, but this example that I previously linked I believe is pretty clear, even more now compared to the gif you posted. Look at the differences between these two:

I'd like to achieve the first one that is the classical behaviour you've got in Windows/OSx/Linux when you want to move a file into a folder.
I cannot achieve this right now because the item I want to move is not placeable over another item.
Anyway on this last sentence a gif is arriving to explain it in a better way

The behaviour you're describing is that of a drag and drop library, this library is solely focused on sorting items. Have you tried using animation-delay to prevent the animation from happening for a certain time?

Hey @giacomocerquone have you find out the solution that you described here ? actually i am having same requirement and couldn't find any solution with this library.


ValueError: zero-size array during _strlib_multinary_features

Description of the bug
"ValueError: zero-size array" happens during featurization.
To Reproduce
Steps to reproduce the behavior:

Run the hardware tutorial
TBD

Expected behavior
Featurization runs without an error.
Error Logs/Screenshots
https://github.com/HiromuHota/fonduer-tutorials/runs/880000246
2020-07-17T00:45:17.3377388Z Traceback (most recent call last):
2020-07-17T00:45:17.3377548Z   File "/usr/local/lib/python3.7/multiprocessing/process.py", line 297, in _bootstrap
2020-07-17T00:45:17.3377686Z     self.run()
2020-07-17T00:45:17.3378135Z   File "/home/user/.venv/lib/python3.7/site-packages/fonduer/utils/udf.py", line 219, in run
2020-07-17T00:45:17.3378281Z     y = self.apply(doc, **self.apply_kwargs)
2020-07-17T00:45:17.3378605Z   File "/home/user/.venv/lib/python3.7/site-packages/fonduer/features/featurizer.py", line 346, in apply
2020-07-17T00:45:17.3378744Z     for cands in cands_list
2020-07-17T00:45:17.3379249Z   File "/home/user/.venv/lib/python3.7/site-packages/fonduer/features/featurizer.py", line 346, in <listcomp>
2020-07-17T00:45:17.3379505Z     for cands in cands_list
2020-07-17T00:45:17.3379821Z   File "/home/user/.venv/lib/python3.7/site-packages/fonduer/utils/utils_udf.py", line 243, in get_mapping
2020-07-17T00:45:17.3379946Z     for cid, key, value in generator(cand):
2020-07-17T00:45:17.3380274Z   File "/home/user/.venv/lib/python3.7/site-packages/fonduer/features/feature_extractors.py", line 63, in extract
2020-07-17T00:45:17.3380428Z     for candidate_id, feature, value in feature_extractor(candidates):
2020-07-17T00:45:17.3380802Z   File "/home/user/.venv/lib/python3.7/site-packages/fonduer/features/feature_libs/structural_features.py", line 70, in extract_structural_features
2020-07-17T00:45:17.3380955Z     for feature, value in _strlib_multinary_features(spans):
2020-07-17T00:45:17.3381317Z   File "/home/user/.venv/lib/python3.7/site-packages/fonduer/features/feature_libs/structural_features.py", line 113, in _strlib_multinary_features
2020-07-17T00:45:17.3381622Z     yield f"COMMON_ANCESTOR_[{' '.join(common_ancestor(spans))}]", DEF_VALUE
2020-07-17T00:45:17.3381973Z   File "/home/user/.venv/lib/python3.7/site-packages/fonduer/utils/data_model_utils/structural.py", line 184, in common_ancestor
2020-07-17T00:45:17.3382114Z     val = np.min(arg_min[np.nonzero(arg_min)])
2020-07-17T00:45:17.3382470Z   File "<__array_function__ internals>", line 6, in amin
2020-07-17T00:45:17.3382803Z   File "/home/user/.venv/lib/python3.7/site-packages/numpy/core/fromnumeric.py", line 2793, in amin
2020-07-17T00:45:17.3382927Z     keepdims=keepdims, initial=initial, where=where)
2020-07-17T00:45:17.3383248Z   File "/home/user/.venv/lib/python3.7/site-packages/numpy/core/fromnumeric.py", line 90, in _wrapreduction
2020-07-17T00:45:17.3383392Z     return ufunc.reduce(obj, axis, dtype, out, **passkwargs)
2020-07-17T00:45:17.3383686Z ValueError: zero-size array to reduction operation minimum which has no identity

Environment (please complete the following information)
TBD.
Additional context
This may be a regression caused by #456.

The error happens when processing Document "Infineon-BC857SERIES_BC858SERIES_BC859SERIES_BC860SERIES-DS-v01_01-en".

The root cause is that fonduer.utils.data_model_utils.common_ancestor does not assume all the mentions share exactly the same ancestor.
The error happens when executing common_ancestor(c) with a candidate: PartTemp(Part(ImplicitSpanMention("BC859", sentence=2516, words=[4,6], position=[0])), Temp(ImplicitSpanMention("200", sentence=2514, words=[1,1], position=[0]))).
As illustrated below, the two spans "BC859" and "200" share the same xpath ('/html/body/table[7]/tr[20]/td[1]/p[3]') hence the same ancestor.


CSS naming convention

This repo is currently 32.3% CSS. I'm thinking it would be useful if we adopted a naming convention such as BEM. I don't intend to retroactively migrate all existing CSS, but I am thinking that this would be useful for the player, which is likely to get pretty messy with a lot of CSS required.
Thoughts?

Adopted after internal discussion


Add openapi documentation + setup mirageJS

Replace msw by mirage and add mock for account, authentication, users endpoints
#17 Add api documentation in admin page

@HugoPerard Is there any way to know required and optional fields ?


Numeric Stable for sigmoid & log_logistic

sigmoid(x)
if x >0 , sigmoid(x) = 1/（1+exp(-x)）
if x <=0, sigmoid(x) = exp(x)/（1+exp(x)）

log_logistic
if x >0 , log_logistic(x) = -log *（1+exp(-x)）
if x <=0, log_logistic(x) = x - log *（1+exp(x)）

Merged into develop branch

When x is larger than 710, exp(x) will overflow:

np.exp(710)
inf

Thus, for numeric stability, made a change by the formula above.


quering data labelled in the viewer

Is it possible to query the data that has been labelled from the viewer?

Yes, the annotations you make in the Viewer are stored as GoldLabel objects, in the gold_label table of the database.  You can write a query joining these with the Candidate objects (or the candidate subclass you defined) that they label.  Hope this helps!


HLSJS doesn't support AES-128 decryption

There should be a call out on your HLS support that any browser that uses HLSJS will fail, and repeat the request for the .ts chunk over and over and over.

*any browser that uses HLSJS with AES-128

@itsjamie I'm gonna close since it's now supported


golang 1.15 is deprecated, golang 1.17 should be used instead

I additionally changed the Required Checks from Go 1.15 to Go 1.17.
Please also change the required go version in the go.mod file.


Rework Note in Safari WebGL2

I found this note hard to read. I shortened the sentences, tried to fix the grammar and added a date.

Thanks! However this note should actually be updated as there has been recent WebGL 2 development, see https://developer.apple.com/safari/technology-preview/release-notes/ (look for "WebGL2" and "WebGL 2"

Huh. I had looked at the source code and not found any further changes. I guess I'll update it then.

Have manually updated this to only use the first line, as per my last comment.


can't turn off the verbose or change the logging level.

Hey,
I am trying to run rviz without any verbose or logging but so far any solution I could find results in a failure. For example the following is not working:
ros2 run rviz2 rviz2 -ros-args --log-level FATAL --disable-rosout-logs --disable-stdout-logs --disable-external-lib-logs

as it prints tons of warnings (which I legit, but I don't want to have the console being spammed); as an example :
Possible reasons are listed at http://wiki.ros.org/tf/Errors%20explained
         at line 332 in /tmp/binarydeb/ros-foxy-tf2-0.13.9/src/buffer_core.cpp
Warning: TF_OLD_DATA ignoring data from the past for frame  at time<PHONE_NUMBER>.749882 according to authority Authority undetectable
Possible reasons are listed at http://wiki.ros.org/tf/Errors%20explained
         at line 332 in /tmp/binarydeb/ros-foxy-tf2-0.13.9/src/buffer_core.cpp
Warning: TF_OLD_DATA ignoring data from the past for frame  at time<PHONE_NUMBER>.754049 according to authority Authority undetectable
Possible reasons are listed at http://wiki.ros.org/tf/Errors%20explained
         at line 332 in /tmp/binarydeb/ros-foxy-tf2-0.13.9/src/buffer_core.cpp
CWarning: Invalid frame ID "" passed to canTransform argument target_frame - frame does not exist
         at line 133 in /tmp/binarydeb/ros-foxy-tf2-0.13.9/src/buffer_core.cpp

Any suggestion ?

This seems to work for me on galactic:
root@logi-XMG-CORE-REN-M20:/code# ros2 run rviz2 rviz2 --ros-args --log-level FATAL
QStandardPaths: XDG_RUNTIME_DIR not set, defaulting to '/tmp/runtime-root

Mmm nope, my answer is not very useful, I also still get the warnings you were talking about. I guess these warnings are not printed by a "ros logger", so --log-level has no power. Correct me if I'm wrong.

+1 on this issue.
Spamming the console with TF errors makes finding the actual source of issues difficult. This is particularly true for people maintaining libraries, because library users who hit issues, tend to then post snapshots of the console which contains only TF spam. Meaningful output from the system is drowned out.
From what I can tell there's no way to stop TF warnings coming from RVIZ. Is that correct?

I am having the same problem and came across with this issue. Is there any update on this?

I've been looking for a solution to this as well. I'd really like to be able to disable all  outputs/logs when launching rviz together with other nodes

Apologies for resurrecting an old thread, but this issue is one of the top results for e.g. "suppress rviz2 output.'
This answer worked for me:
output={'both': 'log'}


Unable to plot distances for stranded TFBS

I received this error from a user and was able to reproduce. When running count_within with stranded=True, and subsequent distance analysis, it is not possible to plot the distribution of TF pair distances.
Steps to reproduce:
import tfcomb.objects

C = tfcomb.objects.CombObj()
C.TFBS_from_motifs(regions="../data/GM12878_hg38_chr4_ATAC_peaks.bed",
                   motifs="../data/HOCOMOCOv11_HUMAN_motifs.txt",
                   genome="../data/hg38_chr4.fa.gz",
                   threads=4)
C.count_within(max_overlap=0.0, threads=4, stranded=True)
C.market_basket()

selection = C.select_significant_rules(x_threshold=0.5)

selection.analyze_distances(threads=6)

TF1, TF2 = selection.distObj.peaks.iloc[0,:2]

selection.distObj.plot((TF1, TF2), style="hist")

This occurs due to a discrepancy between selection.count_names and selection.distObj.TF_names
I will create a PR with a fix, but I might ask for some help with review.

fixed with #56