Cannot invoke find with no arguments

I recently updated to Xcode 6.3 and since then I'm getting this error everywhere I'm using find(). Can anyone help me with this ?
variable data is of SugarRecordResults? type

At a glance I'm not sure what your problem is. Have you pulled the latest code? I seem to be able to use find successfully as can be seen and tested here its built in Xcode 6.3. You can also post your example if you'd like more detailed help.

@dchavezlive I tried the demo and modified the model, then the App began to crash because of unexpectedly found nil while unwrapping an Optional value. I'm sure that something wrong with NSNumber to StringLiteralConvertible in Swift 1.2. And also, lib doesn't generate the correct NSPredicate.
I think this issue should be reopened.

Hi @AustinChou I couldn't fix this issue. When I was testing this library, I just assumed it'll just be a version compatibility problem and moved on with core data.

Fixing in SugarRecord 2.0


[AUTO-PR] Automatically generated new release 2021-06-03T13:35:34.349Z

What are you changing?

[x] Releasing a new version of Notify
[ ] Changing kubernetes configuration

Provide some background on the changes
⚠ The production version of the Terraform infrastructure is behind the latest staging version. Consider upgrading to the latest version before merging this pull request.
NOTIFICATION-API
NOTIFICATION-ADMIN

Split formatting guide into multiple pages (#1051) by Antoine Augusti

NOTIFICATION-DOCUMENT-DOWNLOAD-API
NOTIFICATION-DOCUMENT-DOWNLOAD-FRONTEND
NOTIFICATION-DOCUMENTATION
If you are releasing a new version of notify, what components are you updating

[ ] API
[x] Admin
[ ] Document API
[ ] Document UI

Checklist if releasing new version:

[x] I made sure that both API and Admin changes are present in Notify
[x] I have checked if the docker images I am referencing exist - ex: https://gallery.ecr.aws/v6b8u5o6/notify-admin

Checklist if making changes to Kubernetes:

[ ] I know how to get kubectl credentials in case it catches on fire

Bumping Terraform https://github.com/cds-snc/notification-terraform/pull/272 (no changes to production)


[Discussion] Static or Dynamic analysis, .py (with no output) vs ipynb (that includes output) analysis

Should we "read" the models as code, or actually have an env where they run?
My gut feel is for simplicity, feasibility, and security is we do static analysis, or at least start here
The downsides are

Some models are constructed over multiple python modules which makes single file analysis hard, but I think this is a rare case
It makes parsing certain thing likes number of variables hard, especially with dims coords etc
Means we cant use the pymc functionality itself for analysis

The upsides are

PyMC models aren't really isolated from their env, for dynamic analysis we have to get the data, load it correctly etc and thats a headache
No needing to worry about versions or code security
Makes it simple for anyone to run themselves
Computationally faster

Assuming static analysis this library would then behave like a linter. It gets a reference to a .py or .ipynb file and then it outputs a bunch of metrics

As another thread @twiecki added ideas of analyzing divergences and and sampling time. We can't really do that with sampling or dynamic analysis, but if someone submits a notebook they've run we could parse that out of the cell output. Consider this to be "notebook" analysis, a third possibility
https://discourse.pymc.io/t/extended-event-gathering-pymc-usage-information/13064/3?u=ravinkumar

Here are all the things we gathered on discourse. I have tried to split them into the 3 different analysis areas: static code analysis (requires file where model is in as input), env analysis (requires being executed in the same env where the model is executed) and infdata analysis (requires idata as input directly or its filename plus ArviZ installed). There could also potentially be a 4th area for more "demographic info" which would need to be a form filled by the user, skipping that for now.
Static

Which distributions are being used and how often?
Which sampling functions are more common? Which defaults are most often modified?

Also partially possible via idata analysis checking which groups are present

What operations are more common with PyMC’s outputs: plotting with ArviZ, saving to disk, converting to NumPy/Pandas objects…
What are most common packages also imported; How many folks use xarray operations, arviz, scipy et
Do people use the default sampler, specify their own, or change sampler arguments
What are the most common prior parameters
Which backend is being used?
Use of coords/named dims in models (also combined with InfData section)
Use of “basic” PyMC vs specialized sub-modules/associated projects: GP, BART, sun-ode, Bambi, (others?)

Also partially done via env analysis

Env

How many users are using pymc3 vs pymc

Partially doable from static section too, if restricted to pymc3 vs pymc version comparison

Versions of related packages: how common is it to have latest pymc but older arviz, numpy...

InfData

How big are the models? # of variables being sampled by MCMC? # of observations, how close are we from models that don’t fit in RAM of common computers?

Partially possible as static analysis too but quite difficult imo, and again, only partially possible.

Number of divergences?
Total sampling time?
ESS
Size of datasets being analyzed
Use of coords/named dims in models (also combined with static section)

Demographics

Scientific domains/industries where PyMC is being used
Types of data being studied (purely cross-sectional, purely time series, longitudinal, Geo-spatial…)
Causal identification strategies (if any/applicable)
Repos associated with published papers?


Add xSPSearchManagedProperty resource

The xSPSearchManagedProperty resource is used to define managed properties in the search service application. This should be structured as per the below:
xSPSearchManagedProperty MyCustomSearchProperty
{
ServiceAppName = "Enterprise Search Service Application"
Ensure = "Present"
Name = "MyProperty"
PropertyType = "Text"
Searchable = $true
Queryable = $true
Retrievable = $true
AllowMultipleValues = $true
Refinable = "Yes-Latent"
Sortable = "Yes-Active"
SafeForAnonymous = $false
Alias = "PropertyAlias"
TokenNormalisation = $true
CompleteMatching = $false
IncludeAllCrawledProperties = $false
CrawledProperties = "Field1,Field2"
}

@ykuijs Please assign to me. I am working on a Ressource for this.

All yours!

Implemented in PR #876


[FEATURE REQ] Access to Azure Files with Active Directory

Is your feature request related to a problem? Please describe.
I'm using Active Directory to manage authentication and access to my AZ resources. However, it seems that this is not possible with Azure Files. The configuration for this resource requires to use shared keys. I'm not sure if this behavior depends on the SDK or it's a broader constraint.
Describe the solution you'd like
I would like that the following class:
com.microsoft.azure.batch.protocol.models.AzureFileShareConfiguration

does not require to pass the shared key with the withAccountKey()method.
The method should be optional, and if not invoked, the access to Azure Files should be delegated to AD.
Something similar to what is available for Batch accounts - BatchCredentials with three implementations, one for the keys (BatchSharedKeyCredentials), one for the application (BatchApplicationTokenCredentials) and one for the user (BatchUserTokenCredentials) - would be ideal.
Describe alternatives you've considered
I can use both AD and shared keys, but I'd prefer to be able to use only AD.
Additional context
This is the stack trace I get when I do not pass the shared key:
Caused by:
  mountConfiguration.azureFileShareConfiguration.accountKey is required and cannot be null.

java.lang.IllegalArgumentException: mountConfiguration.azureFileShareConfiguration.accountKey is required and cannot be null.
    at com.microsoft.rest.Validator.validateClass(Validator.java:134)
    at com.microsoft.rest.Validator.validate(Validator.java:77)
    at com.microsoft.azure.batch.protocol.implementation.PoolsImpl.addWithServiceResponseAsync(PoolsImpl.java:812)
    at com.microsoft.azure.batch.protocol.implementation.PoolsImpl.add(PoolsImpl.java:758)
    at com.microsoft.azure.batch.PoolOperations.createPool(PoolOperations.java:461)
    at com.microsoft.azure.batch.PoolOperations.createPool(PoolOperations.java:436)

@mario-guerra I believe you're working with the Azure Batch folks, could you please assist in routing?

I'll check with the Batch team for guidance on how to proceed.

Hi @manuelesimi, Azure Files currently only support authentication using storage account keys and does not support Azure Active Directory (AAD) authentication. This is unfortunately a limitation on the service side and is not on the roadmap for future development.

Hi @mario-guerra, thanks for your ready investigation and reply.
I understand the issue (and somehow suspected it was inherited from the services). Hopefully this limitation can be remove in the future. I'll continue to use the hybrid authentication as workaround.
Thanks again!


Are the components accessible?

Do the components work with screen readers for the visually impaired?

@nikoma I agree that it should be something addressed / answered. I have not dealt with this requirement before so I could not tell you what is required to meet them. I recommend reviewing  material design documentation:  https://material.io/design/usability/accessibility.html#understanding-accessibility
as well as tools like this to answer your question:  https://www.sitepoint.com/site-accessibility-tools/
Being an open source project these advanced features may require contributions for features like this.

@nikoma ,
We are always looking for contributors.

Greetings,
I am new to Blazor and this is my first Github comment. I signed up specifically to be able to ask this question:
Is there a way to access all of the Mat components via the keyboard?
Example: using only the keyboard to get to a tab within MatTabGroup or tab into a MatAccordion and open close the panels using the spacebar
Any MatBlazor parts that cannot be reached via the keyboard makes a site inaccessible. If it's not possible to accomplish this, MatBlazor is relegated to never be usable for government, bank, or corporate site. This applies to most countries that have accessibility requirements/laws (eg US/Canada etc).
I have started using MatBlazor but I cannot seem to reach MatTabGroups with just the keyboard. As it stand now, I will have to remove all of the MatBlazor stuff because I cannot accomplish this. Perhaps it's just because I am new that I cannot figure out how to do this.


go_struct_tag is missing for generated result row struct (or how to configure it)

Version
1.15.0
What happened?
When I use given configuration I can see generated tag in models file.
type Account struct {
	ID          uuid.UUID `sometagtype:"some_value"`
	State       sql.NullString
       # ... rest of the fields
}

However generated struct for my query doesn't contain mentioned tag;
type FindAccountByEmailRow struct {
	ID           uuid.UUID
	State        sql.NullString
       # ... rest of the fields
}

When I use option:   emit_json_tags: true I can see json tag in both places
So my question is if this is a problem or if the generator needs to be configured differently.
Relevant log output
No response
Database schema
CREATE TABLE public.accounts (
    id uuid DEFAULT public.uuid_generate_v4() NOT NULL,
    state character varying,
);

SQL queries
-- name: FindAccountByEmail :one
SELECT
    c.id AS credential_id,
    a.*,
    u.first_name,
    u.last_name,
    -- other fields
FROM
    accounts a
    INNER JOIN users_accounts ua ON a.id = ua.account_id
    INNER JOIN users u ON ua.user_id = u.id
    INNER JOIN credentials c ON c.account_id = a.id
WHERE
    c.email = @email;

Configuration
version: "2"
sql:
  - schema: "db/structure.sql"
    queries: "db/queries.sql"
    engine: "postgresql"
    gen:
      go:
        package: "db"
        out: "db"
        overrides:
          - column: accounts.id
            go_struct_tag: sometagtype:"some_value"

Playground URL
No response
What operating system are you using?
macOS
What database engines are you using?
PostgreSQL
What type of code are you generating?
Go

I also encountered this problem recently. I decided to write a script in python :(

If I understand you correctly, you expect the following output
type FindAccountByEmailRow struct {
	ID           uuid.UUID `sometagtype:"some_value"`
	State        sql.NullString
       # ... rest of the fields
}```
You want the field in the result struct to have the same annotation as the corresponding field in the models struct. Since this works with ```emit_json_tags: true``` as you stated, I would assume this is a bug.
The commit above would fix that.


Adds Local Address to span details when no annotations are present

It is valid to have a local span without any annotations. This presents
the local endpoint in the Key/Value section of Span detail, similarly to
"Client Address" and "Server Address".
Here's an example of this working, given a pre-canned span without any annotations.

$ curl -s localhost:9411/api/v1/spans -X POST -H 'Content-Type: application/json' -d '[
  {
    "traceId": "5a4a9e596c08e861",
    "name": "foo",
    "id": "5a4a9e596c08e861",
    "timestamp":<PHONE_NUMBER>596000,
    "duration": 37000,
    "annotations": [ ],
    "binaryAnnotations": [
      {
        "key": "lc",
        "value": "twitter-server",
        "endpoint": {
          "serviceName": "zipkin-web",
          "ipv4": "<IP_ADDRESS>"
        }
      }
    ]
  }
]'

+1


Window sizes not scaling properly on 200% in Windows.

basically the title, whenever i try to edit or create a connection the windows are way to huge.
I'm using the recommended scaling size of 200% for my resolution / dpi.

Oh, that is weird. Let me see what went wrong here.
Have to see how to reproduce this as my Windows 10 scaling only goes to 175% max.

This is fixed with 110a84d and will be released in the next 1.7.9 update soon

So I published at test build for 1.7.9 here: https://github.com/xpipe-io/xpipe-ptb
Once I'm convinced that it doesn't break things, it will be released as a full release. I want to make sure that everything works with the window clamping even on more complex monitor setups first.

The Welcome Dialog still behaves like it but the ones i posted in the issue work better now.

Works for me 😄

Oh, it seems like I forgot some other windows, that should be fixed quickly.


remove noise from tests

Too many download logs shown during tests. Such as
Download http://localhost:36209/<EMAIL_ADDRESS>Download http://localhost:36209/<EMAIL_ADDRESS>Download http://localhost:36209/<EMAIL_ADDRESS>Download http://localhost:36209/<EMAIL_ADDRESS>Download http://localhost:36209/<EMAIL_ADDRESS>Download http://localhost:36209/<EMAIL_ADDRESS>Download http://localhost:36209/<EMAIL_ADDRESS>Download http://localhost:36209/<EMAIL_ADDRESS>
Better to just get rid of these by adding --quiet flag to tests.

Nvm we don't want this because it completely mutes stderr


Whitelist passed process.env variables

It creates a security hole if you pass init variables to your application through environment. If any security tokens are used, raven passes them through, which is an undesired behavior.

@mattrobenolt here you go, process.env variables. Let me know if that's what you meant.

Closed in favor of #181


Dependabot failure if gemspec file contains instance_eval

Package ecosystem
bundler
Package manager version
Bundler version 2.2.26
Language version
ruby 3.0
dependabot.yml content
version: 2
updates:
- package-ecosystem: bundler
  directory: "/"
  schedule:
    interval: daily
  open-pull-requests-limit: 10
  allow:
  - dependency-type: direct
  - dependency-type: indirect

Description
TLDR: This sample repo contains two gemspec file
test-dependabot-instance-eval.gemspec - simples gemspec file I cound create that build correct gem
test-dependabot-instance-eval-with-dependency.gemspec - another gemspec which use original gemspec to create another gem with additional dependency
In this repo dependabot cannot check dependency of my service with error:
 Dependabot can't evaluate your Ruby dependency files
Dependabot failed to update your dependencies because there was an error evaluating your Ruby dependency files.

Dependabot encountered the following error:

Bundler::Dsl::DSLError with message: [!] There was an error parsing `Gemfile`:
[!] There was an error while loading `test-dependabot-instance-eval-with-dependency.gemspec`: (eval):1: unexpected fraction part after numeric literal
0.0.1
   ^~
. Bundler cannot continue.

 #  from /home/dependabot/dependabot-updater/dependabot_tmp_dir/test-dependabot-instance-eval-with-dependency.gemspec:3
 #  -------------------------------------------
 #
 >  gemspec = instance_eval("0.0.1")
 #
 #  -------------------------------------------
. Bundler cannot continue.

 #  from /home/dependabot/dependabot-updater/dependabot_tmp_dir/Gemfile:5
 #  -------------------------------------------
 #
 >  gemspec

Both gemspec files are fine and can build using gem build without any error
A more detailed description
I'm an author of ooxml_parser gem. It require ruby-filemagic gem as dependency. This dependency is hell to isntall on Windows system so I was in need to make this dependency optional in my gem.
I contacted bundler issue tracker here and team member tell that only option to solve this problem - create two different gemspec file and use instance_eval to add optional dependency. I've made this and everything worked fine, except dependabot checks are started to fail
We discussed this problem and decided to report this issue to dependabot team.
I'm not sure that this problem is easy to fix, but at least I've reported it

Thanks for reporting this and the detailed description + project to reproduce, that'll help a lot. I agree this might not be easy to fix, we do some things to prevent accidental code execution on the dependabot side, and this might hit some of that code. We'll need some time to dive into this, but the report will help a lot 👍

I think have ran into something similar.  I am running multiple gemfiles and get loaded and handled fine by bundler.  The Gemfile looks like this:
Dir["gemfiles/*"].each do |gemfile|
  instance_eval File.read(gemfile)
end

Any ideas on how to get this to work with Dependabot?

Possibly related (and more context on the underlying dynamic code processing problem):

https://github.com/dependabot/dependabot-core/issues/2098

@jurre I think have run into something similar. I am running multiple gemfiles that get loaded and handled fine by bundler. The Gemfile looks like this:
Dir["gemfiles/*"].each do |gemfile|
  instance_eval File.read(gemfile)
end

Any ideas on how to get this to work with Dependabot?

We have this exact same problem. We migrated in https://github.com/theforeman/smart-proxy/commit/bce882c4876ded145465a964f8ea0a4c0f04b4b3 to use eval_gemfile since that was supposedly supported, but now see an error:
Dependabot only supports uninterpolated string arguments to eval_gemfile. Got `bundle`


Status of admin interface

I just wondered what the status of the admin GUI is. I really would like to use Grav on client projects but without it, that's unfortunately a no go.
I'm asking because I cannot seem to find a dev version of it. Also, I'd be more than willing to help out with front end work.

This information will be decimated via the blog/twitter/gitter when we have that information.  Thanks!

Thanks for your reply. So, you're not at all interested in developers joining in? I'll be sure to keep that in mind.

Well I am definitely interested in developers helping out with it, if this is something that interests you please jump on our Gitter.im channel (linked in top-right of our getgrav.org site) and we can chat further.
Thanks!


[WIP] Fixes

Updated dependencies
Fixed Phyrexian lang code
Added deprecation alert for Foil/NonFoil fields for cards
Missed fields added for card types

Thank you for fixing the language and updating to go 1.17! The review title says it is a WIP, let me know when its ready to go and I will merge it!

Thank you for helping keep things up to date!

@BlueMonday don't forget to create a new tag or move the existing one.

@BlueMonday don't forget to create a new tag or move the existing one.

Thank you for the reminder, I tagged v0.2.0.


dragonhide not showing equipment stats

I just tried to see what the stat differences between green/blue/red/black dhide legs were and none showed up for any of them when i hovered over.

I was looking around and d'hide chaps (along with trim variations) are indeed missing from
static.runelite.net/item/stats.json


open_virtual_dataset with dmr++

[x] Closes #85
[x] Tests added
[x] Changes are documented in docs/releases.rst
[x] New functions/methods are listed in api.rst
[x] Open dataset via group= param
[x] Use reader options for dmr file opening pattern

Thanks for taking a look and giving my suggested changes to the chunk key parsing a try @ayushnag !
Continuing the discussion on performance I think the remaining bottlenecks (aside from your point about I/O in the cloud maybe) with this now lie primarily outside the scope of this work, and I don't expect changing XML readers to make a significant improvement.

Some questions about writing unit tests:

How to load test dmrpp’s?

These files are available over https but need netrc login (NASA Earthdata authentication)
I will check how earthaccess gets creds and does testing

What should I compare my result to?

My understanding is that the dmr parsed dataset should match the dataset made by vz.open_dataset(“data.nc”)
Should everything match or are there some main portions to check? (dims, attrs, variables)
Related to https://github.com/zarr-developers/VirtualiZarr/issues/161

@TomNicholas this PR should be ready to go now. You can take a look at the code again if you wish and I can add updates. I have also added docs and release notes.

@TomNicholas do you know why the test is failing? I have added dmrpp as a valid file type so it should be recognized in the unit test. It also passes when I run network tests locally

I'm just looking at that. I suspect it's just a bad merge from main. Have you tried pulling the latest changes to this branch and running that locally?

Amazing piece of work here @ayushnag !!


Lazy parsing for eval docs and trap commands

LazyParseableType allows to embed full sub-documents into the tree:
https://github.com/JetBrains/intellij-community/blob/master/platform/core-api/src/com/intellij/psi/tree/ILazyParseableElementType.java
The Bash code passed to eval is currently lexed as string and later on parsed using an injection host. This is slow, has known issues (e.g. escapings passed to inspections) and is just a workaround.
The lexing should return a lazy parseable element instead of a string for parameters parsed to eval and possibly the trap command.

WordImpl and StringImpl must remove the workarounds to send PsiResolvers into the injected PSI.

Done for the next update.


Add chat link in Contributions

Chat links were not found on the main page and doing so could help in smoother communication with new users.
Also enabling new stream in zulip chatbox for android-fhir
ie. https://chat.fhir.org/#android-fhir

Chat links were not found on the main page and doing so could help in smoother communication with new users.
Also enabling new stream in zulip chatbox for android-fhir
ie. https://chat.fhir.org/#android-fhir

I think the zulip link you shared is for communications pertaining to the standard itself and not this project.

thanks both.
there is an existing stream on zulip (albeit quiet): https://chat.fhir.org/#narrow/stream/276344-android. so we should stick to that.
the zulip chat stream is for android in general and is not limited to this project. so i suggest it be listed as an addtional resource but it's not a chat for this repo.

okay, closing issue.

i think it doesn't harm adding the chat link to the wiki pages by the way.

@jingtang10  sure, should I add it under developer's guide or user's guide.

Thanks. I've done it.


Autocomplete as soon as we type

The current autocomplete is triggered when we hit ctrl + space if I am not wrong, it would be awesome to have autocomplete like atom has which doesn't need a keyboard trigger and suggests as soon as we start typing

Closing as a duplicate of issue #1914. We're considering to implement this for 3.0 or 3.1.


Power ratings

Seems like some calulations in the NC are assuming a 3-phase grid for example
https://github.com/upb-lea/dare/blob/a5d744c31a2adbad795cb55d9c2162221ce689aa/src/nodeconstructor.jl#L244
That 3 should be changed to parameter["grid"]["phase"]
Where else we have hard coded assumtions like 3-phase grid? -> double check
Is the total power rating already checked? So that pwr_sources >= pwr_loads?
What happens if that is equal? In the cable ratings #24 we might run into problems in the optimization.
We should add a "power-level" depending offset to consider worst case power losses across the cables

#24 take parameter["grid"]["phase"] into account during caculation/cable ratings

"Random" sampling of the Sources and Loads results in highly inbalanced powerratios. Thus the PFE can't be solved, resulting in an error.

[ ]  Verified?

Solution would be to set the power in the grid fix (i.e. grid_pwr = num_sources * pwr) and make sure the loads are sampled in a way that it fits to the grid_power (i.e. load_pwr = grid_pwr/num_loads)

[ ] Done?

the current and voltage limits of the loads

[ ] done?

The voltage limit is easy. The difficulty comes in for loads with inductors. What needs to be done is the complex power absorbed by just the inductor should be calculated. S = V I* is the equation. The voltage will be the minimum voltage, something like 0.9 p.u., such that the current limit is maximised.
https://github.com/upb-lea/dare/blob/3ad14d4c44f26d53ff4ab53d7b24f7be028d8645/src/nodeconstructor.jl#L756


Add net.ipv4.ip_forward=1 and use ansible sysctl.

This PR:

Set net.ipv4.ip_forward=1, which is required by Kubernetes.
Use ansible sysctl support instead. Current code has an extra \/ in front of the regexp, which will never match, thus ansible will put a sysctl entry each time it runs.
Format the indent a little bit.

Signed-off-by: Lantao Liu<EMAIL_ADDRESS>

LGTM

Apply LGTM based on https://github.com/kubernetes-incubator/cri-containerd/pull/277#issuecomment-331583520.


Issue vscode / xml views / ui5 language assistant - https://github.com/SAP/ui5-language-assistant/issues/436

Hi,
I´m coding in vscode and have issues because the language assistant has a hardcoded old ui5 version it seems:
https://github.com/SAP/ui5-language-assistant/issues/436
Maybe someone has some ideas and capacity to support the feature to use the ui5 version chosen or at least the newest stable release?
Sample, use m.Avatar in XML View results in an error in the vscode Problem view:

Should be the same for everyone in vscode / BAS
Bye Richard

Hello @richard-bruenning,
I see that there is already such an issue created in the repository of the extension, with a list of specific tasks that need to be done. I hope that the team that maintain it will be able to set aside enough capacity to do it sooner rather than later.
Regards,
Nikolay

Because this issue is already tracked in https://github.com/SAP/ui5-language-assistant/issues/436 we close the issue here.


🎖Added translations for Fluidly stream large external response chunks and OLED Dark

Description
🎖Added translations for Fluidly stream large external response chunks and OLED Dark
Additional Information
only added Fluidly stream large external response chunks and OLED Dark by using google

Thanks!


[proposal] interference manager to aggregate interference metrics

What is your proposal:
After collecting metrics for interference detection, we propose a new component interference-manager to parse metrics from prometheus, aggregate these parsed CPI, PSI... metrics into histograms. Based on those histograms some statistics can be calculated easily and can be used for interference analysis.
Why is this needed:
Use histograms to aggregate metrics on workload level, save storage overhead and make it easy to compute statistics about those metrics.
Is there a suggested solution, if so, please add it:
Plan to implement interference manager:

[ ] Basic architecture

[ ] Use kube builder to generate controllers about metrics aggregation

[ ] Basic functionality

[ ] Metrics Parser
[ ] Histograms' implementation
[ ] Metrics aggregation methods
[ ] Interference Spec computation

/assign


[HELP] glib::MainContext::channel removal missing from changelog

Hello! :) I'm trying to port an application from glib 0.14 to 0.20 and noticed glib::MainContext::channel doesn't exist anymore, but it's mot obvious how to rewrite my application to make it work again. Do you have any pointers? :)
fyi I also noticed https://crates.io/crates/libappindicator points to the gtk-rs github org, but I couldn't find it's git repository unfortunately.
The code I'm trying to port is on github:
https://github.com/kpcyrd/arch-audit-gtk/blob/391bd91795ac50d8a0f8bbd3ff3b3797099cd3ad/src/gui.rs#L141

See https://gtk-rs.org/blog/2024/06/01/new-release.html#removal-of-glib-channels


tiled: 1.2.0 -> 1.2.1

https://github.com/bjorn/tiled/releases/tag/v1.2.1
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Fits CONTRIBUTING.md.

No attempt on x86_64-darwin (full log)
The following builds were skipped because they don't evaluate on x86_64-darwin: tiled
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

Success on aarch64-linux (full log)
Attempted: tiled
Partial log (click to expand)
shrinking /nix/store/w68y88fwrnsn60689sg8b8vrkwvvh3vk-tiled-1.2.1/lib/tiled/plugins/libcsv.so
shrinking /nix/store/w68y88fwrnsn60689sg8b8vrkwvvh3vk-tiled-1.2.1/lib/libtiled.so.1.0.0
gzipping man pages under /nix/store/w68y88fwrnsn60689sg8b8vrkwvvh3vk-tiled-1.2.1/share/man/
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/w68y88fwrnsn60689sg8b8vrkwvvh3vk-tiled-1.2.1/lib  /nix/store/w68y88fwrnsn60689sg8b8vrkwvvh3vk-tiled-1.2.1/bin
patching script interpreter paths in /nix/store/w68y88fwrnsn60689sg8b8vrkwvvh3vk-tiled-1.2.1
checking for references to /build in /nix/store/w68y88fwrnsn60689sg8b8vrkwvvh3vk-tiled-1.2.1...
postPatchMkspecs
postPatchMkspecs
/nix/store/w68y88fwrnsn60689sg8b8vrkwvvh3vk-tiled-1.2.1

Success on x86_64-linux (full log)
Attempted: tiled
Partial log (click to expand)
shrinking /nix/store/a9d1rza6z5v0lwmrycvvszqajmagv5ni-tiled-1.2.1/bin/tiled
shrinking /nix/store/a9d1rza6z5v0lwmrycvvszqajmagv5ni-tiled-1.2.1/bin/terraingenerator
gzipping man pages under /nix/store/a9d1rza6z5v0lwmrycvvszqajmagv5ni-tiled-1.2.1/share/man/
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/a9d1rza6z5v0lwmrycvvszqajmagv5ni-tiled-1.2.1/lib  /nix/store/a9d1rza6z5v0lwmrycvvszqajmagv5ni-tiled-1.2.1/bin
patching script interpreter paths in /nix/store/a9d1rza6z5v0lwmrycvvszqajmagv5ni-tiled-1.2.1
checking for references to /build in /nix/store/a9d1rza6z5v0lwmrycvvszqajmagv5ni-tiled-1.2.1...
postPatchMkspecs
postPatchMkspecs
/nix/store/a9d1rza6z5v0lwmrycvvszqajmagv5ni-tiled-1.2.1


Update rust-lua53 on crates.io

Hi,
is it possible to update the last version of rust-lua53 on crates.io please ?
It will allow project to compile with the latest improvement (e.g: https://github.com/Gigoteur/PX8)
Thank you

I think the current master is ready to be the crate.
I use it in production since last accepted PR. There is no bugs 👍
I've created PR #75 to fix this issue. But only @jcmoyer has rights to publish it.

Yep it can be great !

Any update ? :(

Done.

Thank you !


Improve how tests work

><EMAIL_ADDRESS>test /home/costa/projects/hacker school/hanging-punctuation
> static -H '{"Cache-Control": "no-cache, must-revalidate"}'

serving "." at http://<IP_ADDRESS>:8080
18:2:08 [404]: /
18:2:08 [404]: /favicon.ico
18:2:08 [404]: /favicon.ico
18:2:16 [404]: /

Hey, thanks for opening an issue. You can visit http://<IP_ADDRESS>:8080/test/ and see what I have working, it’s more of an example than a proper test suite really:

It’s pretty early still, though. This project is still really important to me, but I haven’t dedicated time to it in a while. Ideally, it will be a full implementation of hanging-punctuation CSS property and a series of tests that run entirely from the CLI in a headless browser.
If you’re interested in collaborating on it together, let me know! I might get me back into it more.

I'm going to implement a small JavaScript solution for my site, so I'll be working on something. I'm sure we'll overlap a bit. Could you share what the goal is? From a typography standpoint that is.
For me, the ideal would be to get the following characters to hang left or right when they end up at the begining or end of a line:

.
'
"
...
,
«
»
;
maybe a few more

Sure! My goal is to implement something with the same results as hanging-punctuation, which is actually a real CSS property, but defined as “optional,” and so far seems unlikely to ever be implemented in the browser.
Rather than specific characters, there’s a range of unicode characters that this property should to, which I am not doing yet. I wanted to follow that documentation as closely as I could (especially since it accounts for considerations in other languages that I didn’t know about, esp. right-to-left text).
I actually have the basic cases done already (maybe I should make better docs…), which is based of the jQuery.exdent plugin I forked this from, but re-wrote to use without jQuery. If you are looking for a simple solution and already using jQuery, that plugin still works well. Building out what’s defined in that document is what I saw as the next, more widely-applicable step beyond that—if you’re interested in that it would definitely be cool to see if there’s parts we could work on together!

Yeah, I'd love to know what approaches are possible for implementing hanging punctuation. It seems like a really tricky thing to try to implement.
Here were my initial ideas on how it could be done:

Grab all text nodes or just grab p, span, h1-h6, blockquote and q.
Look for leading or ending punctuation, slice it out, and put it back with ::before or ::after.
Split paragraphs on line breaks and do step two on the splits.
Split paragraphs on line breaks, crop leading or ending punctuation and put it back in a span, then step offset spans.

That’s fairly close to what the code does now: https://github.com/kennethormandy/hanging-punctuation/blob/master/hanging-punctuation.js#L82-L88
But rather than applying it to all text nodes, it does it to the ones you’ve applied hanging-punctuation to in your CSS. I’ll see if I can improve the examples and docs for this, it sounds like your use case might be covered already.

Well, I'm struggling with something. Also, side note, I like the absolute positioning approach: http://dabblet.com/gist/9623025 Seems to be more precise and less reliant on knowing how wide "s and 's are.
I'm struggling to understand how to detect punctuation that's not at the very first line of a body of text, but in subsequent lines...

Here’s a working example for you: http://codepen.io/kennethormandy/pen/OPpNQp

Awesome! How do you get it to work in the middle of a paragraph?


tf.nn.softmax_cross_entropy_with_logits_v2() not warning incorrect input shapes when placeholders are provided

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): No
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Linux Ubuntu 16.04
TensorFlow installed from (source or binary): Source
TensorFlow version (use command below): 1.10.0
Python version: 3.5.2
GPU model and memory: GTX1070

Describe the problem
Following is a simple snippet to reproduce the problem. If I'm understanding this correctly, the shape of labels is clearly wrong here but tensorflow doesn't warn you and when the same problem is present in my actual code, not even a runtime error will show up. Appreciate it if you guys can help me out on this especially if I mistook this. Otherwise this looks like a devastating issue.
Source code / logs
a = tf.placeholder(tf.int32, (None))
b = tf.constant([[1.0,2,3],[4,5,6]])
c = tf.nn.softmax_cross_entropy_with_logits_v2(labels=a, logits=b)

The shape of a is unknown, see tf.Dimension. Could you clarify where is wrong?

If we are to provide placeholders for both the label and logits arguments, shouldn't they both have the shape (?, # of classes)? If for example in the above snippet a has only one dimension then there is no way this is an input with correct shape so shouldn't tensorflow warn about it?

Okay in my actual code it was sparse_softmax_cross_entropy_with_logits that was run so I think there should be runtime error if the inputs for softmax_cross_entropy_with_logits are not compatible but no warning thing with the above snippet still persists which might be not that ideal a situation.


PMID:37805140

Increased tRNA N2,N2-dimethylation
Normal tRNA N2,N2-dimethylation - use normal tRNA guanosine N2-methylation
increased stop codon readthrough
~normal stop codon readthrough? normal transcription termination?~

I need "normal stop codon readthrough" for the genetic interaction


Update http-proxy

Update http-proxy from version 1.18.0 to 1.18.1.
This should fix two high vulnerabilities:

https://npmjs.com/advisories/1486
https://npmjs.com/advisories/1486

As suggested by npm audit I used the command:
npm update http-proxy --depth 5

Done in #52


[CI] conda_build step is taking a long time

Since last update of conda-build, the time of the building library went up to 18 mins.

It seems it is coming from https://github.com/conda/conda-build/issues/3775#issue-507970515

good catch, indeed it seems conda-dependent

Closed since PR #249 which removed two nested for loops in tests01_geom/tests03_core.Test03_Rays.calc_signal()


geom_pointrange(): 'size' aesthetic shouldn't affect line width

Example:
ggplot() + geom_pointrange(x=0, ymin=0, ymax=2, y=1, size=10)

Output:

Expected output:

Fix via https://github.com/JetBrains/lets-plot/commit/cc4c05bb112b8f155d67c26bcda046e488ed57dd


Results to Text

Is your feature request related to a problem? Please describe.
I know that this feature is present on SSMS, however, will be awesome to see here!
Describe alternatives you've considered
Saving the result as CSV I get the same result

Since SQL 7, at least, SQL Server query windows have allowed the user to choose between results to grid (Ctrl-D) and results to text (Ctrl-T). Many T-SQL scripts have been written on the premise of outputting formatted results to a text results window. If ADS, Azure Data Studio, query windows do not support results to text, it will make it hard to migrate from SSMS (SQL Server Management studio) to ADS. Results to text is NOT the same thing as saving grid results to a text file. Results to text mixes text formatted query results with the output of PRINT statements, etc.

Wanted to add an additional comment to support this being integrated into ADS. Results and Messages together in the file was very useful in SMSS

Closing as a duplicate of https://github.com/microsoft/azuredatastudio/issues/52.  Thanks for opening this suggestion!


Range Command does not Support Parameter Reordering

Synopsis
The Range Command fails if the to/ parameter appears before from/, even though that is allowed in the specification.

reordering is support in latest pr, ordering from to is working, but "edit a/..." need to be stick together

functionality is fixed from #223 verified. slight issues with the range command syntax and messages, but I will file separate ticket for this (quite minor bugs)


Fix tests

Codecov Report

Merging #104 into master will increase coverage by 21.32%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master     #104       +/-   ##
===========================================
+ Coverage    8.59%   29.92%   +21.32%
===========================================
  Files           4        4
  Lines         128      127        -1
  Branches        5        6        +1
===========================================
+ Hits           11       38       +27
+ Misses        114       87       -27
+ Partials        3        2        -1

Impacted Files
Coverage Δ

frontend/src/reducers/flashcardboxes-reducer.js
38.57% <0%> (+38.57%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a60c03d...59eaf67. Read the comment docs.


fix primary_key

It is an old bug that still exist here, in the branch rails4-mongoid5.
We need the branch so we need the fix.

aaaahhhh, it never pass that easy.
Do we really need CI passed here or we can skip it? Actually, previous builds on rails4-mongoid5 also failed.

thank you! 👍

Hey, thank YOU for opening that PR and getting that cleared up!


Diagnostics for Android (v2)

Description
The same implementation as iOS in version 2.4.0 (latest). But to also include in the final screen an option to send an email (with the diagnostic ID in the subject) along with an optional message field for the user to input their actual problem to the email.

Let's remove the Recovery Type from the list page and decrypt, count words and specify if it came from secret. Make sure that if the encryption fails the diagnostic does not crash.

Hey Daniel we changed the requirements a little bit
No more second screen.
First screen will have feedback editText and button [Report Issue]
Once the button is pressed, it will create a diagnostic id and it will prompt the email to the user.

@dabitdev Oh okay great, that is actually more like the original flow!

do not forget to send the optional Summary to the diagnostic and keep the json object in the body of the email.


feat: CLI allows to incrementally add T3 features

Is your feature request related to a problem? Please describe.
I have started a T3 project for a static site, with no tRPC.

Describe the solution you'd like to see
It would be nice if I could use the cli to add additional parts of the stack to a project already created.
E.g.
npm create t3-app@latest -> if we're in the root of a t3 project, it would be detected and the cli would say it detected a t3 project and would go through some steps to add additional parts of the stack
Describe alternate solutions
Alternatively, add to the docs a section "how to add XXX to an already existing project"
Additional information
No response

This is borderline impossible because there is no way for the CLI to know what changes you have made to your project since scaffolding. Likewise, the docs would be a pain to maintain, and the versions in other languages would be guaranteed to be outdated after a short amount of time.
Here's a method for achieving this manually:

in one folder, create a t3 app that has the same packages as your current app
in another folder, create a t3 app that also has trpc
in the parent folder, diff folder1 folder2


Fixed issue with using $releasever for RedHat

If using RedHat 6.5, using $releasever in the yum repository fails with the following message
Error: Execution of '/usr/bin/yum -d 0 -e 0 -y list gitlab-ce' returned 1: Error: Cannot retrieve repository metadata (repomd.xml) for repository: gitlab_official. Please verify its path and try again

Using the $::os[release][major] fact fixes this issue, the stringify_facts option must be set to false for this to work.

Closing as moving to separate branch


Problem with Installation from pypi

Installation from source using something like pip install -e . seems to work. but installation from pypi wouldn't proceed correctly:
$ pip install quine_mccluskey
Collecting quine_mccluskey
  Using cached https://files.pythonhosted.org/packages/28/b1/d41dbf8a109c6d4c61966a27a18118cce9ff5fffd9a2d558c6b0d67a5f55/quine_mccluskey-0.2.tar.gz
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/private/var/folders/wh/9f9nhgcj4g5_18lv3xt7z9j40000gn/T/pip-install-x_v769mk/quine-mccluskey/setup.py", line 18, in <module>
        long_description=open('README.md').read(),
    FileNotFoundError: [Errno 2] No such file or directory: 'README.md'

    ----------------------------------------
Command "python setup.py egg_info" failed with error code 1 in /private/var/folders/wh/9f9nhgcj4g5_18lv3xt7z9j40000gn/T/pip-install-x_v769mk/quine-mccluskey/

Tested on mac using a fresh python 3.7.2 virtualenv.

This should be fixed now in v0.3


Fixes signature_form for SIGHASH_SINGLE and SIGHAS_NONE.

Fixes #149
signature_form for SIGHASH_SINGLE and SIGHASH_NONE for transactions with more than one input/output was not correctly created.
nSequence for inputs different than the signed index should be set to 0 in both cases.
Moreover, the whole format of SIGHASH_SINGLE was incorrect if a transaction with more than 1 input/output was created.

Hi,
why dont you guys merge this fix?
regards

Seems that no one is taking care of pull requests. Just two really basic ones have been merged throughout this year.


Clean up deprecation warnings in CI

The qEOM algorithm used to trigger a lot of warnings when finding the ground-state solution to start from. This commit avoids that by filtering out expected operator names unless the user explicitly overwrote them.

Summary
The CI is currently littered with a lot of (deprecation) warnings. In this PR I would like to see if this situation can be improved upon.
Details and comments

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

4 of 4 (100.0%)  changed or added relevant lines in 1 file are covered.
8 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.04%) to 85.974%

Files with Coverage Reduction
New Missed Lines
%

qiskit_nature/second_q/algorithms/ground_state_solvers/ground_state_eigensolver.py
8
75.0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.04%

Covered Lines:
18561

Relevant Lines:
21589

💛  - Coveralls

There are still some warnings left but the situation has overall improved quite a lot already. I consider this to be good enough for the time being. In the future we should go over the unittests and remove/duplicate the tests which currently depend on QubitConverter and the (Minimum)EigensolverFactory classes with their replacements, respectively.
This was done to some degree during the refactoring but could be improved further.


Add the option to enable/disable label painting

This PR adds the option to enable/disable labels being painted at the top of bounding boxes.
Note: Label painting is disabled by default
Screenshot:

cool!


One Click Trial left panel UI adjustments

Jira Issue: AAP-27646

Description

Update the left panel of VS Code extension that shows the information of the user based on feedback obtained in the Jul 23 meeting.
BEFORE

AFTER

Note: The "AFTER" image also contains a small fix in the VS Code extension to remove the extra vertical spaces occupied by the HTML <p> tag generated by the marked parser.  The VS Code extension PR for that will be created shortly. --> The PR created: https://github.com/ansible/vscode-ansible/pull/1448

Testing

Unit test case is included.  Manual testing was also done.
Steps to test

Pull down the PR
Run uni tests

Scenarios tested

See above
Production deployment

[X] This code change is ready for production on its own
[ ] This code change requires the following considerations before going to production:

looks good!
Nitpick: Please change from "Trial of 90 days" to "90 days trial"


Update readme.md

Updated the features and content of the module

It's nice to work on this module


Expose Internal Methods and Properties

I've hit an issue where I need to programmatically control other Autocomplete instances on the same page, but (at least from my understanding) this is impossible.
Having an initiation function like this, is great:
autocomplete({
  element: document.querySelector( '' ),
  source: [ 'option', 'option-1', 'options-2']
})

But there is no way to reference this input after it initiates. How hard would it be to have this return the input instance? i.e.
const input = autocomplete({
  element: document.querySelector( '' ),
  source: [ 'option', 'option-1', 'options-2']
})

// Later
input.hide();

Hello @cjkoepke,
Could you give more detail on what specific problem you're trying to solve?

Sure! If I dynamically populate an active autocomplete input, it will start an autosuggest. Since the dynamically populated value is already accurate (not needing autosuggest), I need a way to close the popup suggestion field (or prevent it from opening ad hoc).

Another good use-case I have come across for returning the component from the wrapper module:
https://github.com/alphagov/accessible-autocomplete/blob/935f0d43aea1c606e6b38985e3fe7049ddbe98be/src/wrapper.js#L4
We wanted to implement a button to clear and re-focus the input field, this currently has a sub-optimal user-experience because it requires aligning to some timers internal to accessible-autocomplete. If we reset the input and then re-focus the input before the internal timer has fixed, then the input's value reverts to what it was before being reset. Those timers are there to integrate with Dragon NaturallySpeaking -- https://github.com/alphagov/accessible-autocomplete/blob/935f0d43aea1c606e6b38985e3fe7049ddbe98be/src/autocomplete.js#L107-L125
If the component was returned, we would be able to call component.getDirectInputChanges() to update the internal state of the component and then immediately focus on the input, and have it work correctly.
This is the code we have to have right now to reset and re-focus the input:
let timeout = null;
clearButton.addEventListener('click', function clearInput() {
	input.value = '';
	clearButton.remove();
	// We need to wait longer than 100ms before focusing
	// onto the input element because accessible-autocomplete
	// only checks the value of the input every 100ms.
	// If we modify input.value and then focus into the input in less
	// than 100ms, accessible-autocomplete would not have the updated
	// value and would instead write the old value back into the input.
	// https://github.com/alphagov/accessible-autocomplete/blob/935f0d43aea1c606e6b38985e3fe7049ddbe98be/src/autocomplete.js#L107-L125
	if (!timeout) {
		// The user could press the button multiple times
		// whilst the setTimeout handler has yet to execute
		// We only want to call the handler once
		timeout = setTimeout(() => {
			input.focus();
			timeout = null;
		}, 110);
	}
});

If we had access to the component instance, we could refactor the above into:
clearButton.addEventListener('click', function clearInput() {
	input.value = '';
	clearButton.remove();
	// We need to update the internal state of accessible-autocomplete
	// with the new value in the input
	component.getDirectInputChanges();
	input.focus();
});

@JakeChampion this change to the accessibleAutocomplete function returns the component instance.


Implement GUI feature for using parser components to alert users to inconsistencies

This works now, though I can't find the commit that implemented it. If a user assigns a parser to, say, the transcription field and then enters values in the morpheme break and/or morpheme gloss fields that do not match any of the parser's suggested parses, the UI will alert the user to this fact.


sum() for more "interesting" value types

This pull request isn't really ready yet (see below), but I'm offering it looking for feedback before trying to go any further. I've built everything alongside Vavr without actually moving it into Vavr yet--the production code belongs in io.vavr.collection and some of it would move onto Traversable (or even Foldable). If you folks don't want it at all, then I won't spend the energy trying to integrate it.
I try to show Vavr to every Java programmer I meet in my work as a trainer and coach.
I was working on one of my TDD teaching examples and wanted to be able to invoke sum() on a collection of value objects that acted like numbers: MonetaryAmount. I noticed that Traversable.sum() only operates on Number and primitive numeric types. I thought it might be nice to try to contribute a simple implementation to Vavr for other people who want this behavior, so that people don't have to roll their own every time they encounter this situation.
Of course, sum() needs a description of how to sum things, which is a Monoid. I modeled this as an interface that knows the identity element and "add" function for the value object type. The tests include two examples: one numeric and one non-numeric (based on String). If you folks accept this idea, then I could write a short article on how to write Monoids for various typical value object types. It's not hard and the way I've done it in IntegerValue and StringValue shows a simple convention: a value type class, its monoid class, and a function monoid() on the value type class that returns a singleton instance of the monoid.
I chose the word "monoid" because it is accurate, but I know that not every programmer is familiar with the formal definition of a monoid, even if they broadly understand that sum = reduce identity add and that add doesn't really have to be "add", but any associative binary operation. I played around with other, more-intuitive, less-formal-sounding names and nothing really sounded better than "monoid", so I went with "monoid".
I have also provided a kind of contract test template for checking sum() (see SumArbitraryValueObjectsTest). It could pull double duty as a contract test for people to write their own monoid implementations as well as to use a few sample Value Object types and their monoids to test sum() itself.
If you folks don't want this at all, then I probably won't bother finishing it. If you'd like me to hammer it into shape, then I'm happy to accept your demands and hear your suggestions. I probably didn't follow your coding conventions very well, but I tried to do reasonable things.
Thanks.

The first commit involves bumping the version of the Scala plugin for Maven. I'd obviously clean that up in the final pull request.

Codecov Report

Merging #2323 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #2323      +/-   ##
============================================
- Coverage     97.36%   97.35%   -0.01%
+ Complexity     5247     5246       -1
============================================
  Files            93       93
  Lines         12547    12547
  Branches       1578     1578
============================================
- Hits          12216    12215       -1
  Misses          177      177
- Partials        154      155       +1

Impacted Files
Coverage Δ
Complexity Δ

...r/src/main/java/io/vavr/concurrent/FutureImpl.java
78.51% <0%> (-0.83%)
26% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a0fcf3...83409a1. Read the comment docs.

Thank you! I will wait for your signal when the PR is final/ready.
I don't know were the 'generic' reduction methods like sum will go. I promised to make Vavr 1.0 safer in that regard...

I'll hammer it into shape, then, and put it where it seems to make sense to go. Thanks.

I now submit this pull request "for real". I accept your feedback. Thank you.

I now submit this pull request "for real". I accept your feedback. Thank you.

Hi J.B.!
it seems I totally missed the purpose of your PR. When you added the PR, I only looked at the code changes and it seemed to me that you wanted to add only some changes to the src/test/java part.
I'm afraid, we will not add algebraic abstractions like Monoid (or Functor, Monad, Applicative, Kleisli, ...) to Vavr. In fact I did it myself in the early days of Vavr (formerly Javaslang). Where to start, where to stop?
I soon recognized, that Java is not the right language for such algebraic extensions. In order to define Monad.flatMap, higher kinded types (HKTs) are helpful. However, HKT's can't be expressed with Java's type system.
To that time the overall strategy for Vavr emerged - aligning tightly to Scala. Scala itself does not contain algebraic extensions. For example, a concrete class like String or List should not extend the Monoid interface because the Monoid property is not unique. There are many possibilities to define the 'combine' operation. It could be (but not necessarily have the be) concatenation for example.
Having algebraic abstractions means, to express programs on that level. The code will operate (read: be lifted) on Monoids, Functors, Monads etc. Then, it does not matter if we operate on Lists or Strings or whatever. It can be easily formally proved that the code will be correct, if the corresponding types obey the algebraic abstractions mentioned above.
I do not want to push Vavr in that direction. It is too abstract for (literally spoken) 99% of the Java users. The remaining 1% will most probably not chose Java, because it is too restrictive/not able to express algebraic thoughts in an appropriate way.
Given that, the introduction of Monoid et al look more like a playground or proof of concept instead of covering real-world use cases. I fully understand your interest in that topic. I also played around with it. But it is far from being a practical approach in Java.
I'm not the only one who thinks that way. Most original committers of "Functional Java" turned away from their Java repository. Many of them also have roots in the Scalaz project, which is exactly that: algebraic structures for Scala. But as I said, in Java it does not make much sense. Soon we are confronted with shortcomings of Java.
I hope you understand that I have to close the PR.
I want to apologize because I did not recognize the direction of this PR (and that there does not exist a readme, yet, that reflects our overall strategy).
- Daniel

I understand. I didn't intend Monoid to go in that direction, but rather to provide a convenience for expressing sum() as fold() that "better" (purely my opinion) expresses intent. When I looked for a name for the thing that combines an identity element and an "add" function, I realized that it should be "Monoid", even though I really wanted to avoid the arguably misleading formalism. Your reaction confirms my suspicion.
I see it the other way: a method like sum(Monoid) might help would-be functional programmers in Java learn about fold/reduce without being forced to use arcane-sounding words to describe a familiar concept. Perhaps it works better for sum() to be a literal alias for foldLeft().
On the one hand, I would have preferred to know this before I invested energy into doing it. That is why I asked for feedback before going too far. On the other hand, should I have the urge to try to contribute to this code base in the future, I now know how to do it.

Perhaps it works better for sum() to be a literal alias for foldLeft().

I think that users should learn about fold / reduce. These are the most important methods of our collections. Nearly all other operations can be expressed based on them.
The main problem is that sum() (without arguments) is unsafe. It will disappear in Vavr 1.0.
// safe
List(1, 2, 3).fold(0, (a, b) -> a + b);

// unsafe
List("a", "b", "c").sum();

If Java would support tuples as first class citizens it would be straight forward:
// = Tuple2<int, BiOperator<int>>
var IntSum = (0, (a, b) -> a + b);

// fold takes 2 arguments, which is effectively a Tuple2
var sum = List(1, 2, 3).fold(IntSum);

That is why I asked for feedback before going too far.

Yes, that's my bad. I owe you a ☕ (or two)

One more thought: We avoid introducing aliases in favor of keeping the API surface area small. It is a strategic decision because of simplicity (user perspective) and maintainability (maintainer perspective).

Thanks for explaining. I think I understand. No worries.


Remove SecretStore service account namespace policy

SecretStores are namespaced and as a result, the provider service account field does not have a namespace property.
This blocked the SecretStore from being created as the policy was trying to target a non-existent field and really the policy makes no sense.
Removing it.
Checklist

[x] Update changelog in CHANGELOG.md.

@giantswarm/team-shield Honeybadger have asked me to seek your opinion on removing this policy so let me try and explain the impacts
Unfortunately I have no logs from the deployment failure anymore but could if necessary recreate them
Firstly, as mentioned in the description, a SecretStore is namespace scoped and must use a service account in the same namespace
Secondly, the PR states that a SecretStore auth has no serviceAccount.namespace property; this isn't entirely correct but the mistake is because the policy is actually wrong and the correct field is serviceAccountRef.namespace and the documentation is actually out of date  - I did not see this before.
The implication here is that :point_down:
https://github.com/giantswarm/kyverno-policies-dx/blob/7e0804c7904bbdcd0ac794428afc49776bd7b59f/policies/dx/RestrictExternalSecretsServiceAccounts.yaml#L25-L29
:point_up: should be this: :point_down:
  =(auth):
    # This is for v1beta1
    =(serviceAccountRef):
      namespace: "!*giantswarm*"
      # This is for v1alpha1
      =(serviceAccountRef):
        namespace: "!*giantswarm*"

However, the SDK documentation for this field clearly states: (highlighting my own)

Namespace of the resource being referred to. Ignored if referent is not cluster-scoped. cluster-scoped defaults
to the namespace of the referent.
https://pkg.go.dev/github.com/external-secrets/external-secrets/apis/meta/v1#ServiceAccountSelector

This leads me to the opinion that this policy is not required and may, even in instances it was specified correctly, prevent even ourselves from using ESO SecretStore objects in namespaces we control.
I do agree that the policy for ClusterSecretStore objects should remain in place although further testing of that policy may be required but is out of scope of this PR.

Note: the link to the CRD for serviceAccountRef.namespace is in the v1alpha1 specification - the link to the v1beta1 specification is here: https://github.com/external-secrets/external-secrets/blob/a5ddd97c217fb11afb0c7a401c2bd82731e06641/deploy/crds/bundle.yaml#L8092

I think you'll at least have to regenerate / prune the generated helm policies to make the CI happy


Namespace Not Found Issue in Package

I am encountering a "Namespace Not Found" issue when using this package with Flutter. This appears to be related to outdated dependencies or improper handling of namespaces in the package code.

Hi there, this issue seems similar to #162 . Perhaps they could be linked or reviewed together?


Make sure the logic with requestPage is correct

📝 Provide a description of the new feature
(needs to be a number, original logic has it sometimes null)
➕ Additional Information
No response

Hey @kyrie25 , you probably understand this stuff more than I do, since you did the search thing. Does it look good to you?

Hey @kyrie25 , you probably understand this stuff more than I do, since you did the search thing. Does it look good to you?

LGTM. I don't see any references where requestPage is reassigned to null but if that were the case, there are already functions in the script to reassign the variable to a number


Compatibility

Hi and thank you for this mod!
I'd like to know if this mod is compatible with the mods:

Vanilla Trading Expanded
realistic trade
wealthy traders forked

Thanks!

No idea, never used either of those mods or this mod myself.


Batch inference during training

Single-stage detectors also support batch inference now, so is it possible (or better) to evaluate multiple images in a batch in EvalHook during training? More specifically, should we change the samples_per_gpu in train.py to other values bigger than 1?

Currently, the batch size is hardcoded as 1 during evaluation.
https://github.com/open-mmlab/mmdetection/blob/a1e0e28c1f4602389528b5baf15312b646f8eb42/mmdet/apis/train.py#L115-L120
But to enable evaluation with multi images, you can change 1 to 2 and replace
 dict(type='ImageToTensor', keys=['img']) in val pipeline to DefaultFormatBundle.
I will create a Pr to support that once #3686 is merged.


Can't manage to indicate fortls where to find module files

Definitely not a bug, I just don't get how to tell Fortran Intellisense where to look for imported modules
I tried to tell Fortran Intellisense where to look out for modules :

Via settings.json in VS code

"fortran.includePaths": [
        "path_to_include"
    ],

Via .fortls directly

  "include_dirs": [
  	"path_to_include"
	],

But I keep having "not found in project" warning when importing (with USE statements).
Sorry if I missed a part of the documentation

I meet the same problem

I meet the same problem

Same here, seems related to the upper stream fortls implementation. Tried to use a configuration file .fortls, but still no luck.


[Docs]: broken link

Page(s)
https://jestjs.io/blog/2017/02/21/jest-19-immersive-watch-mode-test-platform-improvements#eslint-plugin-jest--our-very-own-eslint-plugin
Description
link to https://github.com/jestjs/jest/tree/main/packages/eslint-plugin-jest leads to empty page

The plugin was move to: https://github.com/jest-community/eslint-plugin-jest
Just open a PR to fix the broken link.

PR #15096 awaiting approval


Robot Font Not Working

Hey @alchapone @lloeki!
I imported the font-roboto component, but everything on the site is still in Times New Roman.
Thanks.

Hi @nahtnam ,
I am currently trying to implement this GEM with one of my projects. I am having different issues than you are, but noticed that I am seeing an alert regarding robotto in Firebug. Perhaps check your Firebug Console to see if you're not experiencing the same. Might give the guys some more information to work with.

@HermannHH I was able to get it working by adding this CSS at the top of my page:
html body {
  font-family: RobotoDraft;
}

What issues are you having? Maybe I can help you out.

Just not getting any of the components to show in Firefox. Works perfectly in Chrome. And only shows the following in Firefox Firebug and not in Chrome:

Unfortunately im not sure what the issue is.
Sorry.
On Sun Jan 11 2015 at 1:44:25 AM HermannHH<EMAIL_ADDRESS>wrote:

Just not getting any of the components to show in Firefox. Works perfectly
in Chrome. And only shows the following in Firefox Firebug and not in
Chrome:
[image: rsz_screenshot_from_2015-01-11_080610]
https://cloud.githubusercontent.com/assets/5584878/5694868/23f401a8-9987-11e4-8e26-83a8ffedbc04.png
—
Reply to this email directly or view it on GitHub
https://github.com/alchapone/polymer-paper-rails/issues/7#issuecomment-69488735
.


Handle case where no optional parameters are specified

I attempted to specify no optional parameters but simply the URI positional parameter via:
archivenow http://some-urir

and was supplied the command-line help functionality. It would be better to handle this usage in a smarter manner, i.e., triggering the "--all" or "--ia" flags when no archive is explicitly specified.

Done.
Now if no argument provided, the page will be pushed into "ia". If "ia" is not there, the first archive in the list will be considered as the default one.
Example:
$ archivenow.py www.foxnews.com
['https://web.archive.org/web/20170215165408/http://www.foxnews.com']

@maturban
$ archivenow www.foxnews.com
['The Internet Archive: Unexpected error']

I am using version: 2<IP_ADDRESS>.17.30 from pip, as reported by pip show archivenow.

@machawk1  Here is how errors/exceptions are handled for now:
            ...
        except Exception as e:
            pass;
        return self.name+ ": Unexpected error"

where self.name is the name of an archive
would it be fine to do:
            ...
        except Exception as e:
            pass;
        return "Error ("+self.name+ ")"+str(e)

or should I catch each exception separately ?

@maturban It would be good to know WHY the push to the archive failed. If an archive is down, for example, you might expect requests.exceptions.ConnectTimeout and perform some action in the except body then report more information about the error instead of simply saying, "An error occurred".

@machawk1
Now, a more meaningful message is shown when an error is occurred

@maturban You can probably close this ticket, as the request has been fulfilled.
I pulled a new version, killed my internet connection and tried
archivenow www.cs.odu.edu/~mln/

The error I got seemed weird:
["Error (The Internet Archive): HTTPSConnectionPool(host='web.archive.org', port=443): Max retries exceeded with url: /save/www.cs.odu.edu/~mln/ (Caused by NewConnectionError('<requests.packages.urllib3.connection.VerifiedHTTPSConnection object at 0x105933950>: Failed to establish a new connection: [Errno 8] nodename nor servname provided, or not known',))"]


feat: persist user preference for the --remote flag

Changes

🎁 This commit modifies the deploy command so that it persists the value of the --remote flag upon deployment.
🗒 Depends on https://github.com/knative-sandbox/kn-plugin-func/pull/1260

/kind enhancement
Release Note
Persists user preference for remote deployment

Closing in favor of https://github.com/knative/func/pull/1402


Jellyfin source library support

just to addon to this, emby support should be easy. as a few projects ive seen can just work with little tweaking from emby. not that i need emby support as ive switched to jellyfin. jellyseerr was able to work with emby just fine but did needa little bug fixed that was related to a slightly different url path.

"Access your channels by adding the spoofed Tunarr HDHomerun tuner to Plex, Jellyfin, or Emby. Or utilize generated M3U files with any 3rd party IPTV player app."
I don't see Jellyfin on the frontend setup page, Is Jellyfin implemented on the backend somewhere?

Jellyfin is not implemented as a source yet, but you can add your channels (backed by Plex) to Jellyfin as a Live TV source: https://jellyfin.org/docs/general/server/live-tv/setup-guide/
We hope to start implementation of Jellyfin as a programming source soon, though!

Awesome thank you!

how long is this complete

This is in progress right now. You can follow https://github.com/chrisbenincasa/tunarr/pull/633 for updates on the implementation. There is no ETA right now. So far the following things are implemented:

Adding jellyfin servers as a source
UI for browsing your JF libraries
Selecting media to add to channels

What's left (might not be a complete list)

Saving JF media to channels
Streaming implementation
Assorted another cleanup

I'd say we're still a bit away, but making solid progress

um its draft could need fixed and says failed

Yes I understand it's a draft. It's unfinished work that I push to continuously.

hold on maybe i could help


Remove the leading slash for aws deployments.

Not sure if this PR deserves this one but:

Yeah that is an A+ meme you just blew on a pretty trivial patch.


docs(update-certificate-store/README.md): update module/script name

Description
Updates the update-certificate-store module/script name in the module README
Documentation
N/A
TODOs
Please ensure all of these TODOs are completed before asking for a review.

[ ] Ensure the branch is named correctly with the issue number. e.g: feature/new-vpc-endpoints-955 or bug/missing-count-param-434.
[ ] Update the docs.
[ ] Keep the changes backward compatible where possible.
[ ] Run the pre-commit checks successfully.
[ ] Run the relevant tests successfully.
[ ] Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.

Related Issues
N/A

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement
Learn more about why HashiCorp requires a CLA and what the CLA includes
Have you signed the CLA already but the status is still pending? Recheck it.


user.mailbox.unread(user).count wrong. not DISTINCT

The unread count query does not use DISTINCT, so the result is inaccurate.
user.mailbox.unread(user).count # returns 3
user.mailbox.unread(user).all.count # returns 1

Sample SQL generated when doing just count
SELECT COUNT(*) FROM "conversations" INNER JOIN "notifications" ON
"notifications"."conversation_id" = "conversations"."id" AND "notifications"."type" IN
('Message') INNER JOIN "receipts" ON "receipts"."notification_id" = "notifications"."id"
WHERE "receipts"."mailbox_type" = 'inbox' AND "receipts"."trashed" = 'f' AND
"notifications"."type" = 'Message' AND "receipts"."receiver_id" = 33 AND
"receipts"."receiver_type" = 'User' AND "receipts"."is_read" = 'f'

Just tried this against latest master and it's now using DISTINCT. So this has been fixed at some point and can be closed.


add an extra example of ResourcesTracker; change a misspelling of ResourcesTracker's comment

add an extra example of ResourcesTracker; change a misspelling of ResourcesTracker's comment

Thank you :+1:

Thank you :+1:


'Microsoft.NET.Sdk.WindowsDesktop' specified could not be found

C:\Share\UnrealEngine\Engine\Source\Programs\AutomationTool\AutomationTool.csproj(61,31): error MSB4236: The SDK 'Microsoft.NET.Sdk.WindowsDesktop' specified could not be found.
i have tried installed almost every SDK on the visual studio installer
6 , 5 , 3.1
visual studio 2019 and 2022 are installed
i found Microsoft.NET.Sdk.WindowsDesktop as nuget but i should not be adding it to the project.
what could be the issue ?
i can build the engine from visual studio

I solved this myself. Steps:

Install Visual Studio (2019 if you are on the release branch or 2022 if you are on the ue5-main branch).
Make sure to tick (when installing):

Game Development with C++
.NET SDK
.NET Runtime 6 (LTS)
NuGet Package Manager

Hit modify, let that complete. Now for the important step. It seems that if you install .NET Core 3.1 via Visual Studio Unreal Engine doesn't pick it up when building. To solve this, install .NET Core 3.1 manually via this link.
Make sure to reboot after you've installed everything.

The key part of this is the manual .NET Core install. If you install via Visual Studio then Unreal Engine doesn't seem to pick it up; doing the manual install solves this.


arch-riscv: adding support for local interrupts

Besides the standard RISC-V interrupts software, timer, and external interrupt, the RISC-V specification also offers the possibility to implement local interrupts. With this patch, we contribute an extension of RiscvInterrupts that enables connecting interrupt sources to the local interrupt controller. We assigned the local interrupts to machine-level and gave them the highest priority. If two local interrupts are pending, there exception code will be the tie-breaker (higher ID > lower ID). 32 Bit systems only recognize the local interrupts 16 to 31, 64 Bit systems 16 to 63.
I was not able to reopen the pull request https://github.com/gem5/gem5/pull/811 after my force push. Therefore, i opened a new pull request again. I hope that it is not problematic 😅 .
Change-Id: Iff8d34e740b925dce351c0c6f54f4bd37a647e0c

@robhau : Do you mind if we "Squash merge" this PR into the develop branch?

@BobbyRBruce I do not mind ☺


Add links to PSI-search and PSI BLAST from sequence section

From: https://github.com/pombase/website/issues/2140#issuecomment-2535268408

maybe PSI-search and PSI blast will compensate a little for the loss of jackhammer.
We have NCBI PSI-blast, but it's a bit sub-optimal because it caps the results number, so you can never get out of fungi. I haven't tried the EBI ones. If you add the links, I can compare them, and we can remove anything that isn't useful.

That's done now.


Add beat and bar functionality to AudioStreamPlayer[2D/3D]

Implements godotengine/godot-proposals#6166.
Video demo
https://github.com/godotengine/godot/assets/93539/161a47aa-1010-4875-a4e0-eb1a6130e628
API
It adds the following functions and signals:

AudioStreamPlayer.get_current_beat() -> int
AudioStreamPlayer.get_current_bar() -> int
AudioStreamPlayer.get_beat_progress() -> float in range [0,1]
AudioStreamPlayer.get_bar_progress() -> float in range [0,1]
Signal AudioStreamPlayback.beat_changed(beat: int)
Signal AudioStreamPlayback.bar_changed(bar: int)

This allows syncing gameplay or visual effects to the BPM (beats per minute) of music.
It is implemented for MP3 and OGG Vorbis streams (since those are the only ones that have BPM information attached, although it could be implemented for WAV if desired and the bpm/ bar_beats fields are added to that).
This works for AudioStreamPlayer, AudioStreamPlayer2D and AudioStreamPlayer3D.
Test project
~BeatToolsTestProject_v2.zip~
Update: New version that uses the signals on AudioStreamPlayer and adds tweens for label colors when the signals are triggered to demonstrate their usage.
BeatToolsTestProject_v3.zip
This project contains two music files in ogg and mp3 formats with different BPM (to test both implementations and show that it syncs correctly to different speeds).
The contained music files are CC0 licensed and can be found here.
If desired, I can polish this project a bit and add it to the godot-demo-projects repository/ Godot Asset Library, so that we can show a working reference implementation for the BPM features.
Outstanding work
Ideally the events from AudioStreamPlayback would be exposed on AudioStreamPlayer as well (I have defined them there too, but haven't found a good way to re-emit a signal emitted by AudioStreamPlayback from AudioStreamPlayer, since AudioStreamPlayback doesn't have a reference to the player and the player can have multiple playback instances. If someone has an idea how this signal could be exposed, please let me know and I'll adjust the implementation. Otherwise I will remove the signal definitions from AudioStreamPlayer[2D/3D].
Another option would be to emit the signals from the AudioStream instead, which the AudioStreamPlayback has a reference to and could call a method on. This is slightly less elegant to work with in GDScript than signals emitted on the AudioStreamPlayer, since the stream might be changed and then the signals need to be reconnected from code. It also means that you can't connect the signal from the editor UI on the node as usual. It's much nicer than having to connect to signals on the AudioStreamPlayback object though, since that changes often (e.g. when seeking it seems) and isn't available until you play the stream (see the test project for this being tricky to work around).
Another issue is that the signals are emitted from the audio thread, so you have to use call_deferred or set_deferred to interact with UI or other nodes from a function connected to one of the signals (as seen in the example code). Is there a way to emit the signal on the main thread instead?
Update: The signals are now emitted from AudioStreamPlayer[2D/3D] directly, so the GDScript interface is much nicer to use now. Thanks for the feedback and help in getting this to work! :sparkles:

Thanks for the reviews! I implemented the feedback. I'm not 100% sure about resetting prev_beat and prev_bar in start() and stop() yet...
This means that if you "pause" an audio player by storing the current time (progress) in a variable and then pass that to play(), it would trigger a new bar and beat immediately when you start playing (even though you might have paused it in the middle of a bar). If we keep the current state for these variables, it would only emit the events when the next beat or bar is reached, which seems more correct.
This is of course an edge case, but pausing music is relatively common when you e.g. go into a pause menu or inventory screen in the middle of the game, so it's worth considering imo.
It can be worked around by storing the current beat or bar in GDScript, so not sure which behaviour is preferable.

And the very same if-clause in AudioStreamPlayer3D and AudioStreamPlayer.

It seems you overlooked that:
https://github.com/godotengine/godot/blob/c0b189f02fe88d5a5f34ec0176d9bab19abefb0e/scene/3d/audio_stream_player_3d.cpp#L306
https://github.com/godotengine/godot/blob/c0b189f02fe88d5a5f34ec0176d9bab19abefb0e/scene/audio/audio_stream_player.cpp#L57

Yes, thanks!
Fixed :sparkles:

Looking quite good : )
Last thing I can think of is that you should move all 3 lines with int current_beat = playback->get_current_beat(); four lines lower into the if (current_bar >= 0)-clause. That eliminates this function call for everybody who does not use the beats and bars logic.

Thanks, applying that.
An issue that I have now is that when playing an MP3/ OGG audio stream without bpm information attached, we get tons of errors like this:
E 0:00:04:0044   get_frames_per_beat: bpm needs to be assigned in import settings.
  <C++ Error>    Condition "mp3_stream->get_bpm() <= 0" is true. Returning: -1
  <C++ Source>   modules/minimp3/audio_stream_mp3.cpp:148 @ get_frames_per_beat()

Is there a way to conditionally disable these error messages? Otherwise I guess I need a method for internal use on AudioStream that checks if there is bpm information and returns a boolean, which can then be used in the AudioStreamPlayer*::_notification logic?

I can reach the class. AudioStream itself defines the get_bpm() method, and the players have a stream member.

Indeed, I completely missed that and only saw Vector<Ref<AudioStreamPlayback>> stream_playbacks;!

@AThousandShips @MJacred do you think this is ready to be merged, or do I need to make further changes? Thanks :sparkles:

Applied the changes and squashed the commits again :+1:
Thanks for that, I tried to do ranges with [ ] but didn't know how to escape them properly :sweat_smile:

Considering that this seems to be a complete pr with no remaining notes, will this be merged for 4.2?

I was told that 4.2 is entering a feature freeze, so this will likely only get merged for 4.3 sadly.

@lemilonkh: This needs to be approved first. Could you please check as well @ellenhp? (The code looked good to me at least).
If she's unavailable, we can ping Juan afterwards, as it's not about audio containers.

I'm a bit out of the loop with beat/bar stuff and dynamic audio. I made some proposals that made sense to me but Juan wasn't as convinced and I think we ended up going a different way. I haven't kept up with progress.
The only things I'll note here are:

You shouldn't emit any signals from the audio thread, and it looks like you're not doing that. So you're good there.
Lock-free thread safety on any shared data between the audio thread and main thread(s). As long as you're just using primitives I think that's fine because IIRC most platforms do 64-bit writes atomically. Could definitely be wrong there though.

Others may be better at reviewing for style, but I think Juan should review this for audio.

@reduz could you maybe give this PR a review?
I've heard from multiple people who would like to use the functionality in official builds to make e.g. rhythm games or music visualizations, so I think it would be nice if it could make it in for 4.3.

Based on the feedback from @reduz on Twitter I removed the signals from this PR, since they were basically also polling (just with a sugar coated interface), which can be done in GDScript if required.
The previous state of the PR is preserved on the beat-helpers-signals branch in case anyone needs it.
I'd say the PR is ready for a review :sparkles:

@reduz any chance to take a look a this PR?

This is scheduled for 4.3 but it is far from requiring a proper assessment and it cannot be in the incoming version. Is there any progress on this PR? It should be moved to 4.4 just to be sure.

From my end it does what it needs to do, but I agree it makes sense to move it to 4.4.
Let me know if there are any required changes, as this already went through the review process back when I originally made it, it was just never picked up by a core reviewer that could approve it...

I see between [code]x[/code] and [code]y[/code] (inclusive) used very often in the class reference, or similar. Sometimes (inclusive) seems to be omitted but there's no rule. I'd say given the range 0.0 and 1.0 it's reasonable to infer, but it's up to opinion.
So, for example:
Should return how far the playback has progressed from the last musical bar (usually 4 beats, depending on the stream's bar beats) to the next, as a value between [code]0.0[/code] [code]1.0[/code].

@reduz can this be reviewed?


Fix handling of signals in scratchpad when client is nil

Fixes #146 for me. I am pretty new to the codebase and could be missing the intention of this area of the code.

Thanks for bringing that to our attention and sorry for taking so long to take a look at it! The scratchpad holds the client that it is associated with as a field. You are right that it doesn't make much sense as it is right now. Your commit surely fixes it because it connects/disconnects the function from every client there is which is totally fine because the function that gets connected/disconnected only exists for one scratchpad anyway (as it is "dynamically generated" if you will).
That being said, to nitpick a little on your solution: I do think that it would be conceptually more clear if the functions gets connected/disconnected explicitly from one client and not from all clients with the "hidden implication" that there is only one client to disconnect from anyway.
-self.client.disconnect_signal("manage", inital_apply)
+self.client:disconnect_signal("manage", inital_apply)

@Kasper24 Can you verify my assessment?

Yeah this file was just recently refactored away from the way I have it here, and I think the intention was what you are saying here @Nooo37. Its just down this path self.client is nil so there needs to be a new way to come up with connecting the signal to a single client

Oh you are right, my proposal doesn't make much sense either here


Genres are not returned for albums

I couldn't tell for sure if this is a web API bug or a bug in this .NET library, since I found discussions for it here https://github.com/spotify/web-api/issues/157.
Requesting several albums by IDs works, but the Genres property on FullAlbum is always an empty List<string>.
In the discusison it was mentioned that the request might work with the --genres parameter supplied.

If it's not delivered by the API, there is not much we can do...
I think the parameter is referring to libspotify, which does not solely use the web API.
Feel free to contact Spotify via their forum and post updates here, but closing for now since it's out of my hands.


Infinite loop in d3.timeHour.range.

The problem is that date.setMinutes is losing an hour rather than rounding down to the start of the current hour:
var date = new Date(1478419200000); // Sun Nov 06 2016 01:00:00 GMT-0700 (PDT)
date.setTime(+date + 1 * 36e5); // Sun Nov 06 2016 01:00:00 GMT-0800 (PST)
date.setMinutes(0, 0, 0); // Sun Nov 06 2016 01:00:00 GMT-0700 (PDT)

This bug appears present in Chrome and Node but not Safari and Firefox.


Any configuration to work with Smudge locally ?

I normally connect to university network and get public IP.
When I'm using Smudge for transmitting data (1000-1200 bytes/data), sometimes broadcast messages are lost or very slow.
So I'm here for an advice. I need Smudge to run and broadcast messages only in my localhost.
Here are some of my code.
func ConfigServer() error {
	port, err := strconv.Atoi(NODE_ID)
	if err != nil {
		return err
	}

	// Set configuration options
	smudge.SetListenIP(net.ParseIP(baseAddress))
	smudge.SetListenPort(port)
	smudge.SetHeartbeatMillis(500)
	smudge.SetMaxBroadcastBytes(2000)
	smudge.SetLogThreshold(smudge.LogOff)
	smudge.SetMulticastEnabled(false)
	smudge.SetClusterName("KU-Coin")

	smudge.AddStatusListener(MyStatusListener{})
	smudge.AddBroadcastListener(MyBroadcastListener{})

	// Add a new remote node. Currently, to join an existing cluster you must
	// add at least one of its healthy member nodes.

	if nodeAddress != knownNodes[0] {
		node, err := smudge.CreateNodeByAddress(knownNodes[0])
		if err == nil {
			smudge.AddNode(node)
		} else {
			return err
		}
	}

	// start the server
	go func() {
		smudge.Begin()
	}()

	// Handle SIGINT and SIGTERM.
	// quit := make(chan os.Signal, 2)
	// signal.Notify(quit, syscall.SIGINT, syscall.SIGTERM)
	// <-quit
	return nil
}

I've set baseAddress to "<IP_ADDRESS>" but still got no luck.
Thanks in advance

I don't think you can broadcast messages that large. Max on IPv4 is 256 bytes as a broadcast message piggy bags on a single IPv4 frame. The other 256 bytes of the frame is used for Smudge signalling.
If you want to send larger messages you should split you message up in smaller bits and re-assemble them at the receiving side. Note that these smaller packages may be received out-of-order or may not be received at all.

You could, in theory, increase the maximum packet size via SetMaxBroadcastBytes(int), but this will also increase the UDP packet size, which isn't support by many infrastructures. They could be simply dropped and disappear into the void.
@eelcocramer is correct that for packets this large you may wish to split the messages into multiple parts that are re-assembled at the destination. This adds some administrative overhead on your part, but it's feasible.
Maybe, just maybe, a feature to support that automatically could be added directly into Smudge, but I can't promise it would be available any time soon.
If your network supports IPv6, you can also use that protocol to get a little more space to work with, if you can compress your messages to less than 512 bytes.

I didn't deal the problem with splitting messages at the first place because I was aware of something that you said "Note that these smaller packages may be received out-of-order or may not be received at all."
The message out-of-order is not a big problem but the packet loss is very important to me.
According to 1000+ bytes of messages, I've used encoding/gob already.
If you guys have any other good encoding. I'll be appreciated to test it.
I've heard about ETH encoding method called RLP. But I'm not sure how to get and plug in the module into my project.
Thanks!

To be honest my remark about packet loss (or message loss) is an assumption which is based on the fact that messages or sent using ‘udp’ and that networks could split and merge during operation.
I noticed that smudge can deal with lost and reconnected links to some level. I think messages are send several times. This may depend on the load of the messages though. Maybe @clockworksoul can shine some light on how broadcasts propagate through the network?

One more problem I found, I had 3 nodes that were in the same cluster and each nodes see others as ALIVE. Then, I disconnected 1 node and wait 4-5 seconds until other nodes found it as DEAD. Then, I rejoin this node into the cluster and wait until the other nodes found it as ALIVE and it knew those 2 nodes were ALIVE too. Then, I start broadcast messages. In this case, OnBroadcast() didn't trigger on those 2 nodes.
I've tried time.Sleep() after smudge.Begin() to make sure everything is ready to go. But the broadcasting still didn't work.

I've done many experiments and come up with a assumption that any node that's online for a long time will rarely receive broadcast message from new joining nodes.
I set this assumption because when I join 2 new nodes at the same time and broadcast. those two can receive each other messages. But the one that's online for such 5 minutes can't receive any message but status.

When I start node 1, then node 2, then node 3 continuously, everything worked fine.
But when I wait for like 3 minutes and disconnected node 3, then restart it. the broadcast messages from node 3 can't reach node 1 and node 2.
If I disconnected node 2 and node 3 after waiting 3 minutes, then restart those 2 nodes. The broadcast messages can reach each others but can't reach node 1.
I can give you my repo and shell script to reproduce it if you would like to.
Thanks!

I've commited scripts file to use and README.md that includes step to reproduce
if you're interested...
https://github.com/fe1t/blockchain_programming_in_golang/blob/p2p_smudge/src/README.md

I've commited scripts file to use and README.md that includes step to reproduce
if you're interested...
https://github.com/fe1t/blockchain_programming_in_golang/tree/p2p_smudge/src

Any suggestion how to modify Smudge to handle TCP packet instead ?
Currently, I'm using Smudge as node discovery
When I want to broadcast a message, I just loop over AllNodes() and DialTCP on my own way.
This way seems pretty fast. but it has a problem when many goroutines trying to connect to same destination.
I'm not good at networking, so I don't know how to deal with this.
Thanks!

Hi clockworksoul,
Don't worry, I've done it with atomic broadcast by using Smudge as node discovery protocol.
Thanks very much


Error on signed content from AWS.

I´m trying to open a signed content from amazon but the fresco tag can´t open it. If you use the Image tag, works fine. An exemple link is https://weduc-storage.s3-eu-west-1.amazonaws.com/e97cb8f8521dfa019d6de5c1e3f568ff181fc84f.jpg?AWSAccessKeyId=NANANANANANANA&Expires=1484620088&Signature=NANANANANANA%3D .
As you can see, there´s a signature after the extension. Is there other way to solve it?

Hi @jbfulgencio ,
The Android native Fresco library is designed to work with direct URLs of images, if there is any authentication required it should not be in the URI itself but rather in a different authentication mechanism which will provide a simple URL address to the image.
The current implementation of nativescript-fresco and its imageUri supports loading images from remote location (http, https), from the resources and local files of your {N} application or more details refer the readme here. Loading images from not authenticated remote location is not supported but it could be possible.


[NFC] Restructed LexicalDestroyFolding.

Separate distinct multi-step tasks into distinct multi member function classes.  Clarify when values are produced and consumed.

To the question of whether all the refactoring is really worthwhile...
I realize you split 3 classes: Candidates, FindCandidates, and FilterCandidates, even though there's only one piece of exposed state, Candidates. I realize that was to avoid passing IntroducerUsage and BorroweeUsage around as arguments. But I think it would be fine to pass those around across a few APIs since they're already nicely encapsulated. We always need to make these kind of tradeoffs. I don't think strictly following one design rule over others leads to the best outcome. What you did here was the extreme end of some design strategies I was advocating in the previous PR. I wouldn't have taken it this far for a relatively simple utility 😄

Yeah, the 3 classes: FindCandidates, FilterCandidates and Rewriter are the ones doing the work, writing to (the first two) and reading from (the last) the one instance of Candidates.
In this case, it seemed a bit cleaner (highly subjective) to me to have the constant reference IntroducerUsage and BorroweeUsage be members of classes rather than passing them around to several functions.  This way the related functions are grouped together into a single namespace and the noise of passing the arguments explicitly isn't there.  And you can easily find out how the members are used within those related functions by finding usages of the symbol.

@swift-ci please smoke test

nice!


Tensor ncon

Adds an ncon function that acts on tn.Tensor

huh?

@mganahl Could you merge master into experimental_ncon? This pr is like 100 lines apart from that.

its merged

Ok, well that was weird, but that seems to have fixed the CLA thing


Is there somewhere I can go to see a list of new functionality as it's added?

As this is a very actively maintained project, is it possible to have a page that lists newly added features of note? I used to frequently browse the commit history, but it's often hard to determine what's been added just from the check-in comments.

Besides commit logs, I don't think there is any easy way to monitor what's being added.
One possible way could be to monitor only changes made to the documentation files.

I've been scanning the merged PRs list to get a sense, but that doesn't get me changes that @fchollet makes because he commits directly to master. @fchollet would you consider also using the PR interface for your contributions? That also gives us a place where we can discuss changes if something has broken.


Api Wizzard World Issue Service Unavailable

Hey, I'm not sure if it's the write place to write this so sorry in advance.
I have some problems to access datas with this API. So I try it with your swagger, but the same issue appears. Maybe an issue with the wiki? I don't know.
I use your API for a university project for learn javascript, so thanks you for your good work.

Actually API is so popular we exceeded free quota or Heroku. It should reset at the start of the month, but I will try to fix it sooner.

Okay. It should work now. Happy codding!