[Suggestion] Deep Storage Cell 64k+

I suggest at this point a storage disk with 64k+ capacity, but only for a single type of item like stone or netherrack.

Good idea, what size were you thinking about?

thats a good question
one question coming up, how much max storage per disk is possible?
is it capped at max int value of 2,147B?

It's capped to the max int value yes but I'd never add a disk in that comes close to that amount :P

What I WOULD consider: 128K Deep Unit.. Maybe more.

after some thinking i would say 16m storage maximum for 1 disk would be more than enough.
you are at 64k and then upwards 256k, 1m, 4m 16m.
all after the 64k is for 1 item only and needs three of the former class cells to craft.

Yes, I might do that...
256k, 1m, 4m, 16m are the logical progression, but I'm worried it'll break balance, even if it only can take 1 type of item.

Well, such things are already available, just as blocks. Just make it relatively difficult to craft, IMO. And maybe even let them be disabled in config if a pack maker wants to limit it.

i didn't see it breaking the balance of the game
back in 1.6.4 and ae1 i have a wall of 64k storage disk in drives to store all my stuff including massiv amounts of cobble and normal stone. so going upwards with the capacity is a normal thing and the costs are fairly balanced for it.
to give it numbers:
256k is 3 64k, 9 16k, 27 4k, 81 1k
1m is 9 64k
4m is 27 64k
16m is 81 64k, 243 16k, 729 4k, 2187 1k(~34 stacks)
and belive me that is not imbalanced in my eyes to go all the way from 1k to 16m

I'm a storage pig. I'll take the biggest you'll give me.

me too, but if it gets developt you can only store 1 item type per disc as mentioned above.
btw when it comes to dyes like diffrent wool colors each colored wool counts as 1 item type
also 1 item is a damaged sword, only a sword with identical damaged value can be stored.

In 1.7.10 with AE2 we would just use a deep storage unit which would hold billions (2^31 aka 2.147Billion) and we would just put a storage bus on it and bam, instantly hold a ton of that one item.  If we had DSU's then I don't think this would be an issue.  Perhaps not as expensive considering how limiting and also that it takes up a precious disk slot.  I would say anything over 1M is more than anyone would ever use of that single item and while a nice to have feature it isn't OP and therefore shouldn't be arduous to craft nor super expensive.
Just some perspective.


Inverted proportion in Masonry mode

Hi, in Masonry mode, a portrait image has a landscape miniature on the gallery, and vice versa.
I tracked down the issue, and it's there:
https://github.com/Ecodev/natural-gallery-js/blob/b7d4cad4ecfab557eda51159f8c2ed8b8385891c/app/js/galleries/Masonry.ts#L155
it should be
item.height = item.width * item.model.enlargedHeight / item.model.enlargedWidth;

Thanks, I'll check this.

Just published 4.1.1 that fix it.


Adding Simple Name Example

Adding Simple Name Example to gb-pages branch per fent suggestion. #35

Awesome thank you!


Search panel focusing incorrectly

The search panel gets focused incorrectly and behaves erratically on mouse hover.

This problem  is solved since commit https://github.com/TheIllusionistMirage/Prattle/commit/c632d9fc0e067ca65fe916a83dfc49403644e8a7


Amino Acid Reduced Alphabet Search

Indexing with the reduced alphabet is pretty straightforward but verifying is not!

Querying:

[ ] Preprocessing the query by replacing letters with one (need mapping of chars)
[ ] Alter graph construction default case to place character nodes in a buffer instead of instantly adding them to NFA
[ ] What's the best way to read the reference files?

The graph simplification isn't strictly necessary... It might be a better idea to have a separate method for graph construction when there is a reduction since it's slightly more complex.
It's also probably smart to replace the current I/O approach with a view


macos: waitForNetwork in dns_darwin.go does not deal with ipv6 addresses

On my macos machine, /etc/resolv.conf seems to be updated first with ipv6 addresses, and then a bit later with ipv4 addresses.
This causes crc wait to stop when it only contains ipv6 addresses, and try to ping them. Unfortunately, on macos, ping does not seem to know how to deal with ipv6 addresses, ping6 must be used for that.
This result in a (non-fatal) ERRO Host is not connected to internet. message during startup.

This code is not triggered anymore with the new network stack. I guess we can close this.

Was minor at the time, and is indeed no longer the default networking mode. Closing now.


Fixed #29864 -- Separate cache methods reference documents.

https://code.djangoproject.com/ticket/29864

My patch wasn't meant to be complete.

The text and code shouldn't be reordered. The order should be link anchor, text, code example.

The text and code shouldn't be reordered. The order should be link anchor, text, code example.

Done, except for incr/decr methods because they have common text.

You can put the link anchors for incr and decr next to each other, followed by the text and code examples. Please revert the punctuation changes that are now in the patch.


change name of repo

It doesn't need to have "nitro" in it.
We could have SCBridge-Wallet (or whatever our hackathon submission title is).

OK I went with SCBridge-Wallet for now (I think it is marginally easier to tell a story with).


add clang 16

macos-latest does not support gcc10, so I specified the previous version

Thanks for your contribution!


criu dump failed

Hi, I setup a new ubuntu20.04 vm, run commands in misc/provision.sh to prepare the environment.
Then I try the example with make and  FITM_ARGS=config/fitm-args.ftp.json make run, but I got criu dump failed error message. The fuzzer stuck at gen1 for about 1min then exit.
Could you please help? Thank you.
cargo build --release
    Finished release [optimized + debuginfo] target(s) in 0.03s
sudo rm -rf ./active-state
sudo rm -rf ./cmin-tmp
sudo -E ./target/release/fitm config/fitm-args.ftp.json
cwd: "/home/qwe/FitM"

    __________________  ___
   / ____/  _/_  __/  |/  /
  / /_   / /  / / / /|_/ /
 / __/ _/ /  / / / /  / /
/_/   /___/ /_/ /_/  /_/

File fitm-state.json not found. Restarting from scratch.
No valid state to resume. Starting fresh :)
==== [*] Time start init_run: 2022-04-15 19:39:09 ====
[*] Init run finished with exit code None
[*] Target was killed by signal. Assuming dump success.
[*] Init run finished with exit code Some(0)
[!] Unexpected exit status '0' from snapshot creation.
thread 'main' panicked at 'Namespace call failed with error Custom { kind: Other, error: "[!] criu dump failed, check active-state dir." }', src/namespacing.rs:135:31
stack backtrace:
   0: rust_begin_unwind
             at /rustc/7737e0b5c4103216d6fd8cf941b7ab9bdbaace7c/library/std/src/panicking.rs:584:5
   1: core::panicking::panic_fmt
             at /rustc/7737e0b5c4103216d6fd8cf941b7ab9bdbaace7c/library/core/src/panicking.rs:143:14
   2: fitm::namespacing::NamespaceContext::execute
             at /home/qwe/FitM/src/namespacing.rs:135:31
   3: fitm::FITMSnapshot::init_run
             at /home/qwe/FitM/src/lib.rs:269:28
   4: fitm::run
             at /home/qwe/FitM/src/lib.rs:1351:13
   5: fitm::main
             at /home/qwe/FitM/src/main.rs:88:21
   6: core::ops::function::FnOnce::call_once
             at /rustc/7737e0b5c4103216d6fd8cf941b7ab9bdbaace7c/library/core/src/ops/function.rs:227:5
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
[*] Init run finished with exit code None
[*] Target was killed by signal. Assuming dump success.
==== [*] Time end init_run: "2022-04-15 19:39:10" ====
---> Round 1: Fuzzing Gen 1
==== [*] Queue before process_stage contains: [[], ["fitm-gen1-state0"], ["fitm-gen2-state0"], []] ====
==== [*] Time start process_stage gen 1: "2022-04-15 19:39:10" ====
     -> Processing stage with 1 inputs.
==== [*] Time start process_stage loop step fitm-gen1-state0: "2022-04-15 19:39:10" ====
==== [*] Wrote cmin contents from /home/qwe/FitM/cmin-tmp to /home/qwe/FitM/saved-states/fitm-gen1-state0/in ====
==== [*] Start fuzzing fitm-gen1-state0 ("ftp") ====
         Fuzzer Stats:
         - cycles_done       : 1
         - execs_done        : 62990
         - execs_per_sec     : 1049.52
         - paths_total       : 103
         - max_depth         : 2
         - stability         : 100.00%
         - unique_crashes    : 0
         - unique_hangs      : 0
==== [*] Finished fuzzing fitm-gen1-state0 ====
==== [*] Wrote cmin contents from /home/qwe/FitM/cmin-tmp to /home/qwe/FitM/saved-states/fitm-gen1-state0/out/main/queue ====
==== [*] Creating outputs for state: fitm-gen1-state0 ====
==== [*] Using input: "/home/qwe/FitM/saved-states/fitm-gen1-state0/out/main/queue/id:000068,time:0,orig:id:000131,src:000055+000118,time:58311,op:splice,rep:2" ====
thread 'main' panicked at '[!] create_outputs_file(): Snapshot run failed: Os { code: 10, kind: Uncategorized, message: "No child processes" }', src/lib.rs:552:55
stack backtrace:
   0: rust_begin_unwind
             at /rustc/7737e0b5c4103216d6fd8cf941b7ab9bdbaace7c/library/std/src/panicking.rs:584:5
   1: core::panicking::panic_fmt
             at /rustc/7737e0b5c4103216d6fd8cf941b7ab9bdbaace7c/library/core/src/panicking.rs:143:14
   2: core::result::unwrap_failed
             at /rustc/7737e0b5c4103216d6fd8cf941b7ab9bdbaace7c/library/core/src/result.rs:1749:5
   3: core::result::Result<T,E>::expect
             at /rustc/7737e0b5c4103216d6fd8cf941b7ab9bdbaace7c/library/core/src/result.rs:1022:23
   4: fitm::FITMSnapshot::create_outputs_file::{{closure}}
             at /home/qwe/FitM/src/lib.rs:552:21
   5: fitm::namespacing::NamespaceContext::execute
             at /home/qwe/FitM/src/namespacing.rs:126:27
   6: fitm::FITMSnapshot::create_outputs_file
             at /home/qwe/FitM/src/lib.rs:525:27
   7: fitm::FITMSnapshot::create_outputs
             at /home/qwe/FitM/src/lib.rs:623:13
   8: fitm::process_stage
             at /home/qwe/FitM/src/lib.rs:981:9
   9: fitm::run
             at /home/qwe/FitM/src/lib.rs:1458:30
  10: fitm::main
             at /home/qwe/FitM/src/main.rs:88:21
  11: core::ops::function::FnOnce::call_once
             at /rustc/7737e0b5c4103216d6fd8cf941b7ab9bdbaace7c/library/core/src/ops/function.rs:227:5
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
[!] Error during create_outputs execution. Please check latest statefolder for output
make: *** [Makefile:40: run] Error 1

In active-state/snapshot/criu.log, it seems that the snapshot works
...
(00.022122) 0x7f7784ffd000-0x7f7784ffe000 (4K) prot 0x1 flags 0x2 fdflags 0 st 0x41 off 0x2c000 reg fp  shmid: 0x2
(00.022124) 0x7f7784ffe000-0x7f7784fff000 (4K) prot 0x3 flags 0x2 fdflags 0 st 0x41 off 0x2d000 reg fp  shmid: 0x2
(00.022126) 0x7f7784fff000-0x7f7785000000 (4K) prot 0x3 flags 0x22 fdflags 0 st 0x201 off 0 reg ap  shmid: 0
(00.022127) 0x7ffd9d46a000-0x7ffd9d48b000 (132K) prot 0x3 flags 0x122 fdflags 0 st 0x201 off 0 reg ap  shmid: 0
(00.022129) 0x7ffd9d4b7000-0x7ffd9d4bb000 (16K) prot 0x1 flags 0x22 fdflags 0 st 0x1201 off 0 reg vvar ap  shmid: 0
(00.022131) 0x7ffd9d4bb000-0x7ffd9d4bd000 (8K) prot 0x5 flags 0x22 fdflags 0 st 0x209 off 0 reg vdso ap  shmid: 0
(00.022133) 0xffffffffff600000-0xffffffffff601000 (4K) prot 0x4 flags 0x22 fdflags 0 st 0x204 off 0 vsys ap  shmid: 0
(00.022135) Obtaining task auvx ...
(00.022245) Dumping path for -3 fd via self 16 [/home/qwe/FitM/active-state]
(00.022271) Dumping path for -3 fd via self 16 [/]
(00.022276) Dumping task cwd id 0x17 root id 0x18
(00.022373) Dumping file-locks
(00.022379)
(00.022381) Dumping pstree (pid: 20513)
(00.022382) ----------------------------------------
(00.022384) Process: 20513(20513)
(00.022410) ----------------------------------------
(00.022432) cg: All tasks in criu's cgroups. Nothing to dump.
(00.022434) unix: Dumping external sockets
(00.022460) Writing image inventory (version 1)
(00.022508) Running post-dump scripts
(00.022511) Unfreezing tasks into 2
(00.022513)     Unseizing 20513 into 2
(00.023064) Writing stats
(00.023094) Dumping finished successfully


command_path comment

It wouldn't hurt to have the comment by the command_path in the config.yml example say something about this pointing to console, or maybe even just call it console_path.  I was new to symfony and queuebundle and it took a little looking to understand this was correct and pointing to the bin folder where 'console' app resides.  I also struggled a little with permissions for the lock_service. I finally just did a chmod 777 * -R and work started to run.  Maybe a note about permissions on that path could be good too.
So far my install is able to run work and I'm pretty happy about that.  Thanks.

I am sorry would you please elaborate little bit as to what you want to see in doc.


CORS for Swagger UI is broken

Hi,
I am struggle on this. Let's see if anybody can help me.
Since I have pulled the last version, my auto-generated swagger/swagger.go looks like:
func MountController(service goa.Service) {
	service.ServeFiles("/swagger.json", "swagger/swagger.json")
}

This makes sense since swagger.json is a static file.
However, before it looked like:
// MountController mounts the swagger spec controller under "/swagger.json".
func MountController(service goa.Service) {
	ctrl := service.NewController("Swagger")
	service.Info("mount", "ctrl", "Swagger", "action", "Show", "route", "GET /swagger.json")
	h := ctrl.NewHTTPRouterHandle("Show", getSwagger)
	service.HTTPHandler().(*httprouter.Router).Handle("GET", "/swagger.json", h)
}

// getSwagger is the httprouter handle that returns the Swagger spec.
// func getSwagger(w http.ResponseWriter, r *http.Request, p httprouter.Params) {
func getSwagger(ctx *goa.Context) error {
	ctx.Header().Set("Content-Type", "application/swagger+json")
	ctx.Header().Set("Cache-Control", "public, max-age=3600")
	return ctx.Respond(200, []byte(spec))
}

// Generated spec
const spec = `{...} `

If I understood, this old version sets a handler for the given path to serve the swagger spec.
Now, once we set up CORS using the new goa-middleware/cors the library parses handlers adding required headers.
However, now the controller does not tie path to handler, therefore, the request serves the file but does not change any header to allow CORS.
Any tip to solve this?
Thanks!

Hmm that's an oversight really. The ServeFiles implementation uses the router directly therefore bypassing setting up middlewares. It didn't seem necessary that middleware be used to serve files directly. The problem above clearly demonstrates that that's not the case. I'll update the implementation so it properly sets up the middleware. I'm also thinking it may make sense for the Controller interface to expose ServeFiles so that specific middleware can be setup, would that help your use case?

Yeah, that was our guess. Very appreciated if you can apply the require change so we can use the entire solution: goa + goa-middleware/cors.
Thanks a lot!

The PR above should fix it, please close the issue if it does, thanks!

This was fast! All good now.
Again, thanks a lot a happy holidays!!!


fix: enable dereference when copying module to tmp dir

When executing the copy command, for symlinked node_modules like in the case of pnpm, the copy will treat nested folders as files which breaks the pack command. De-referencing will make sure any symlinked folders are actually dereferenced.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@RomainMuller - can I please get a review?

@mergifyio update


Confirming current password is using username provided by the user

There's a bug on the setting new password action. It's using the username provided by the user to check if the current password user is valid but if you set a new username at same time as you change the password you get an invalid password error
https://github.com/epicweb-dev/epic-stack/blob/main/app/routes/settings%2B/profile.index.tsx#L73C6-L73C6

Nice catch! We should lookup the user by their ID and verify that username. Would you be interested in contributing a fix?

Ive already fixed in another repo. Gonna take a break from coding this week and will open a pr when come back


gnupg21: Add texinfo as a dependency

This adds texinfo as a dependency, without which the build will fail.

Hope this is okay @wkennington


Ir generation is too slow.

When parsing apl_arpege_parallel.F90 (https://github.com/pmarguinaud/IAL/blob/openacccpglagstack84/arpifs/phys_dmn/apl_arpege_parallel.F90) with Sourcefile.from_file("apl_arpege_parallel.F90)", it takes about 50 seconds, which is far too long for what I'm doing.
Is there any way of running it faster please?

Hi @ecossevin this one looks actually pretty loaded, so let me start with a few general comments:

The file you link is not actually publicly accessible, and in general we prefer neutral examples, not stuff directly ripped out of large code bases and in private repos. I can see why this particular case it might be different though. :wink:
I got a separate version of this file internally, and it is ~7Kloc of auto-generated code! :open_mouth:  So for the record, Loki is not originally built for single-file processing speed (python and all that) and I'm not surprised this is slow. It is generally  recommended to start from unprocessed files of a reasonable size!

Nevertheless, the ratio fparser's AST processing to Loki's IR generation seems off (I get a total of ~68s, with 8s for FP AST and 60s for Loki IR), which does indeed hint at a severe performance problem in our frontend (usually I'd expect roughly a 1-to-1 ratio). I've tracked this down to some very inefficient searches in some utility passes and a sub-optimal feature in our Transformer base class, but an immediate quick-fix had some bad fallout. I'll have another go at this soon (time permitting), but in the meantime please be patient as this one seems to sit deep.
So, many thanks for flagging this and please hold tight - we were aware of some sub-optimalities from the early days, but I wasn't aware how bad this one was. :pray:

Hi, so after some digging I've managed to drop the frontend processing times for this example quite a bit - for a detailed description of the problem please see PR #229 . Taking a slightly different version of the source file linked in the issue description, I get the following timings:
=====  Loki main  ======
In [1]: from loki import Sourcefile, config_override

In [2]: with config_override({'log-level': 'perf'}):
   ...:     Sourcefile.from_file("apl_arpege_parallel.F90")
   ...:
[Loki::Frontend] Executed sanitize_input in 0.12s
[Loki::Sourcefile] Constructed from apl_arpege_parallel.F90 in 68.48s

vs.
====  Loki naml-frontend-optimisations  =====
In [1]: from loki import Sourcefile, config_override

In [2]: with config_override({'log-level': 'perf'}):
   ...:     Sourcefile.from_file("apl_arpege_parallel.F90")
   ...:
[Loki::Frontend] Executed sanitize_input in 0.12s
[Loki::FP] Executed parse_fparser_source in 7.60s
[Loki::Frontend] Executed sanitize_ir in 0.26s
[Loki::Frontend] Executed sanitize_ir in 6.07s
[Loki::Frontend] Executed sanitize_ir in 1.00s
[Loki::FP] Executed parse_fparser_ast in 20.11s
[Loki::Sourcefile] Constructed from apl_arpege_parallel.F90 in 27.85s

There's probably a little more that can be done for the ~6s call to sanitize_ir - it still uses two unoptimised search-and-replace utilities, but it was ~45s before the improvements in #229 . Certain overhead from transforming an AST of that size is also expected, but this should alleviate the problem a little for now.

Ok, following the merges of PRs #241 #242 and #245 we now have the FP-frontend parsing time for this pathological file down to this:
In [3]: with config_override({'log-level': 'perf'}):
   ...:     Sourcefile.from_file("apl_arpege_parallel.F90")
   ...:
[Loki::Frontend] Executed sanitize_input in 0.12s
[Loki::FP] Executed parse_fparser_source in 7.67s
[Loki::Frontend] Executed sanitize_ir in 0.11s
[Loki::Frontend] Executed sanitize_ir in 2.73s
[Loki::Frontend] Executed sanitize_ir in 0.48s
[Loki::FP] Executed parse_fparser_ast in 5.40s
[Loki::Sourcefile] Constructed from apl_arpege_parallel.F90 in 13.23s

This might not fix the "many small, unscoped parses" issue (discussedoffline), but I think this is enough for this one to be closed.


hail: Add NixOS module

Motivation for this change
There is no NixOS module for Hail yet.
Things done

[ ] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] Linux

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

We have been running this module on our server for the last few weeks.
I am not so sure what to do about https://github.com/TaktInc/hail/issues/10 . This issue affects one when one tries to activate a NixOS profile using Hail, as hail will try to restart itself when a new profile is activated which wrecks havoc. There is a simple solution using systemd-run which we could add to the NixOS module. However, I am not sure if this belongs into the module or users of Hail should just implement this themselves. @shlevy What do you think?

IMO we should separate out "this module gets hail running on a NixOS system" from "this hail profile activates a NixOS system, which happens to include hail itself". The latter should be responsible for systemd-run, but it may make sense to have some helper function as part of NixOS to manage that.


Add verify-gofmt.sh

Add a verify-gofmt.sh script.

@duglin @vaikas-google @bmelville @arschles

shouldn't this be hooked into the Makefile?

I am not sure what kubernetes does -- I believe there is a 'make verify'
that invokes the verification script hack/verify-all.sh.  I'll copy that
pattern in a follow-up (or in this PR if you would prefer).
On Tue, Nov 22, 2016 at 10:33 AM, Doug Davis<EMAIL_ADDRESS>wrote:

shouldn't this be hooked into the Makefile?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes-incubator/service-catalog/pull/34#issuecomment-262272805,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAWXmHSUdisggK9J-gYjDPHuNU7OI-m6ks5rAwszgaJpZM4KqwYj
.

Yea, we might as well just hook it in so that "make" runs the verify scripts first, then does a build.

I don't want to make 'make' run the verify stuff first -- since that's not
what Kube does.  Remember, name of the game is 'little kube'.
On Tue, Nov 22, 2016 at 10:43 AM, Doug Davis<EMAIL_ADDRESS>wrote:

Yea, we might as well just hook it in so that "make" runs the verify
scripts first, then does a build.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes-incubator/service-catalog/pull/34#issuecomment-262275790,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAWXmCR_9EyvC6OnTfu0Z9i9TwCpgxerks5rAw2RgaJpZM4KqwYj
.

that's fine I guess.  I just think its better to catch errors by the developer instead of by the CI after the PR has been issued.  But ok.

There's a pre-commit hook you can use to run the verify scripts, which is
what upstream does :)
On Tue, Nov 22, 2016 at 10:48 AM, Doug Davis<EMAIL_ADDRESS>wrote:

that's fine I guess. I just think its better to catch errors by the
developer instead of by the CI after the PR has been issued. But ok.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes-incubator/service-catalog/pull/34#issuecomment-262277350,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAWXmPCBo-wKZC9V80M-wHDZQdC_jbc6ks5rAw7BgaJpZM4KqwYj
.

yea and that assumes the dev did the extra steps necessary to run those commit hook - which isn't necessarily true.  But I still like the idea of not even allowing the dev to compile (run "make") if they messed up - again catch error as early in the pipeline as possible. What I've seen other projects do is only run it on modified files instead of all so that its pretty quick.
This is a rat-hole, I know, but just feels wrong to check-in code that's not used.  Even if we added a "make verify" step in the Makefile (that requires people to manually invoke it) it would be better than no call to it at all.

Let's hold off on further changes for now.  I'll add a make verify when I
come back to this, deal?
On Tue, Nov 22, 2016 at 11:06 AM, Doug Davis<EMAIL_ADDRESS>wrote:

yea and that assumes the dev did the extra steps necessary to run those
commit hook - which isn't necessarily true. But I still like the idea of
not even allowing the dev to compile (run "make") if they messed up - again
catch error as early in the pipeline as possible. What I've seen other
projects do is only run it on modified files instead of all so that its
pretty quick.
This is a rat-hole, I know, but just feels wrong to check-in code that's
not used. Even if we added a "make verify" step in the Makefile (that
requires people to manually invoke it) it would be better than no call to
it at all.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes-incubator/service-catalog/pull/34#issuecomment-262282954,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAWXmGTNt4sqZBrbdqtl9raWxjrEyumeks5rAxL3gaJpZM4KqwYj
.

This LGTM. we could also hook up the script to our CI infrastructure

I am going to re-do this PR after I get the script directory moved.

@kubernetes-incubator/maintainers-service-catalog PTAL -- I want to get this in, then I'll add a make verify directive in a follow-up.

LGTM

LGTM

Added veto... reasoning...
There's a lot of discussion above about if or how this should be integrated into a make target, when that target runs, developers adding the script as a commit hook, etc...
imho, this should be treated as a test. i.e. I am imagining that at some point in the near future:
test: test-format test-unit test-integration test-e2e

This doesn't rely on developers to have installed the commit hook and it short-circuits more resource-intensive tests if formatting or style issues exist.
I recognize that this might not be how k8s does things, but I also think we agreed yesterday that we wouldn't allow "being like k8s" to impinge upon the potential for improvements.

Rescinding veto because I overlooked this comment:

I want to get this in, then I'll add a make verify directive in a follow-up.

But let's have this conversation soon.
LGTM


feat: update default image to ghcr.io one

Description
per Atlantis 0.17.1 release, the default image registry is ghcr.io. Thus updating the code to reflect that.

Thanks @chenrui333 !
v3.1.0 has been just released.

Thanks @antonbabenko!

FYI - I don't think this change does what you think it does. if we wanted to change the image repo, we should have changed the image version to be dev per the directions of upstream Atlantis repo https://github.com/terraform-aws-modules/terraform-aws-atlantis/blob/179b846000b64d8e7e42890c5672455b4db9bf3b/variables.tf#L470

also, they are still publishing to Dockerhub as well so the "old" route still works


BreadcrumbAttribute should only be allowed on methods and classes

(Default)BreadcrumbAttribute have no effect when placed on anything besides methods or classes.
Make this apparent by added AttributeTargets restrictions such as:
[AttributeUsage(AttributeTargets.Method | AttributeTargets.Class, AllowMultiple = false, Inherited = true)]

I already added that on my local version and didn't want to push until a new version is out.
Thank you for the reminder!


fix: iteratively replace "close" to avoid maximum stack error

Closes https://github.com/alexeyraspopov/picocolors/issues/63

Hi, thanks for the awesome library!
This is one implementation idea I had to avoid call stack error explained in the above issue. I'm not sure if you have any particular reason you've chosen recursive one (perf? code side?), but just to have something to discuss, I'm starting this PR here.
Please let me know what you think. Thanks!

Thanks for raising the issue and making a PR for it! Let me briefly go through the code first. It passes the tests so nothing prevents me from merging it. After the merge I'll need to make some tests to see how it affects existing benchmarks and if we need some more of them for this kind of tasks.

@hi-ogawa, I did some benchmarking locally, testing out the suggested changes. Unfortunately, there's very clear regression in the main benchmark, that is a lot larger than an error threshold:
main branch        4,798,017 ops/sec
this branch        2,990,548 ops/sec

I assume this is mainly due to extra conditions that the solution requires.
I do like your approach with cycle, so I tried to play around with it. Here's what I ended up with
let formatter =
	(open, close, replace = open) =>
	input => {
		let string = "" + input
		let index = string.indexOf(close, open.length)
		return ~index
			? open + replaceClose(string, close, replace, index) + close
			: open + string + close
	}

function replaceClose(string, close, replace, index) {
	let result = ""
	let cursor = 0
	do {
		result += string.substring(cursor, index) + replace
		cursor = index + close.length
		index = string.indexOf(close, cursor)
	} while (~index)
	return result + string.substring(cursor)
}

This provides following benchmark results, which is even higher than the baseline. Something that I'd expect from using a cycle instead of non-TCO recursion.
main branch          4,777,274 ops/sec
this solution        4,963,734 ops/sec

The striking difference coming from not having extra conditions for certain cases. We still need an extra function which in isolation may have fewer assumptions and provide more straightforward computations.
Let me know what you think about this approach. If you can update your branch with suggested changes, we can run through tests one more time and merge it. I will publish a patch version update after that.

Very interesting! Right, I was thinking the special casing the first check could have significant impact, but I didn't properly compared with main branch. Thanks for testing with it.
Your code looks good to me and now I updated a branch with your suggestion. Thanks for the review!

@hi-ogawa v1.0.1 is now available in NPM.


mender-uboot: Reduce SPL size for beaglebone-yocto (scarthgap)

It seems the uboot image in Scarthgap has grown such that the default autoconfig setup for at least Beaglebone no longer fits in sram:
cp u-boot-dtb.bin u-boot.bin
|    rm -f spl/drivers/mtd/nand/built-in.o; arm-poky-linux-gnueabi-ar cDPrsT spl/drivers/mtd/nand/built-in.o spl/drivers/mtd/nand/raw/built-in.o
|    rm -f spl/drivers/mtd/built-in.o; arm-poky-linux-gnueabi-ar cDPrsT spl/drivers/mtd/built-in.o spl/drivers/mtd/mtd.o spl/drivers/mtd/nand/built-in.o
|    rm -f spl/drivers/built-in.o; arm-poky-linux-gnueabi-ar cDPrsT spl/drivers/built-in.o spl/drivers/block/built-in.o spl/drivers/core/built-in.o spl/drivers/gpio/built-in.o spl/drivers/i2c/built-in.o spl/drivers/mmc/built-in.o spl/drivers/mtd/built-in.o spl/drivers/net/built-in.o spl/drivers/power/built-in.o spl/drivers/serial/built-in.o spl/drivers/bus/built-in.o spl/drivers/usb/musb-new/built-in.o spl/drivers/usb/gadget/built-in.o spl/drivers/usb/common/built-in.o spl/drivers/usb/gadget/udc/built-in.o spl/drivers/watchdog/built-in.o spl/drivers/soc/built-in.o
|   ( cd spl && arm-poky-linux-gnueabi-ld.bfd -z noexecstack --no-warn-rwx-segments -T u-boot-spl.lds --gc-sections -Bstatic --gc-sections  --no-dynamic-linker --build-id=none -Ttext 0x402F0400 arch/arm/cpu/armv7/start.o --whole-archive arch/arm/mach-omap2/built-in.o arch/arm/cpu/armv7/built-in.o arch/arm/cpu/built-in.o arch/arm/lib/built-in.o board/ti/am335x/built-in.o board/ti/common/built-in.o common/spl/built-in.o common/init/built-in.o boot/built-in.o common/built-in.o cmd/built-in.o env/built-in.o lib/built-in.o disk/built-in.o drivers/built-in.o drivers/usb/dwc3/built-in.o drivers/usb/cdns3/built-in.o dts/built-in.o fs/built-in.o net/built-in.o  --no-whole-archive arch/arm/lib/eabi_compat.o arch/arm/lib/lib.a -Map u-boot-spl.map -o u-boot-spl )
| arm-poky-linux-gnueabi-ld.bfd: u-boot-spl section __u_boot_list' will not fit in region .sram'
| arm-poky-linux-gnueabi-ld.bfd: region `.sram' overflowed by 824 bytes
| make[2]: *** [/work/dmoseley/scratch/mender-beaglebone/build/tmp/work/beaglebone_yocto-poky-linux-gnueabi/u-boot/2024.01/git/scripts/Makefile.spl:527: spl/u-boot-spl] Error 1
| make[1]: *** [/work/dmoseley/scratch/mender-beaglebone/build/tmp/work/beaglebone_yocto-poky-linux-gnueabi/u-boot/2024.01/git/Makefile:2054: spl/u-boot-spl] Error 2
This patch removes a few USB config options from SPL which should not be needed in a Mender config since it is just going to load the main uboot image from SDCard.
Changelog: Title
Ticket: None

@TheYoctoJester I think this contains the requested changes.  Not sure what happened on the other PR.

@drewmoseley perfect, thanks and merged 👍


MWPW-137722 - Adding sitemap index

Adds a sitemap-index.xml

Resolves: MWPW-137722
Test URLs:
N/A

Codecov Report

Merging #19 (9579c1a) into main (cb3346a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #19   +/-   ##
=======================================
  Coverage   86.36%   86.36%
=======================================
  Files           2        2
  Lines         176      176
=======================================
  Hits          152      152
  Misses         24       24

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


No title bar context menu on Linux

Testing #156220
On Ubuntu with Window: Title Bar Style set to custom, I can't bring up the title bar context menu, neither with a mouse, trackpad, or Shift+F10.

Assigning to this milestone to investigate, may get pushed back

After investigation, it looks like Linux suffers from the same issue as Windows did (no mouse events in draggable regions). I implemented the window hook for Windows but this is not an option on Linux (at least the hook is a Windows-only thing). As the custom title bar is not the default for Linux, we can live with this, as you can still right click the menu bar, command center, or layout controls to hide them.

I can bring up the context menu if the cursor is over the menu bar.

Testing #156220
On Ubuntu with Window: Title Bar Style set to custom, I can't bring up the title bar context menu, neither with a mouse, trackpad, or Shift+F10.

Closing as this doesn't seem to be a blocker and is more of a good to have. Can revisit if there is need in the future.


why don't I get the correct coord

My require:  I need get correct coord when I double click the svg 's location by mouse.
MY suggestion:
1 the Author need add  checkLimits,(forbid not viewport's coord)
2 I can get the correct coord although I zoomin or zoomout at one fixed point of svg.But now you can know the coord will be changed with viewbox's data. Because I need input fixed data ,I can't hope the fixed data's coord will be changed randomly.
MY function:
/**

Handle double click event
See handleMouseDown() for alternate detection method

@param {Event} evt
*/
SvgPanZoom.prototype.handleDblClick = function(evt) {
var point = getViewBoxCoordinatesFromEvent(this.svg, evt);
document.getElementById('mouselnginput').value=point.x+","+point.y;

My<EMAIL_ADDRESS>

https://github.com/ariutta/svg-pan-zoom#bugs-and-issues


Add GHSL citation (Fixes #498)

Can you provide a screenshot?

@tetraptych ^

Should we also cite the census in the Population Data section?

But are all the sources under Provider Data actually used for the provider points? I thought some of them were references for the text description...

@tetraptych true-- We have many types of data sources and references:

Provider points from various sources
Population points from GHSL
Kaiser Family Foundation and other sites that might be referenced for facts in the dataset description
Census data

Is there a better way to group this all in one lump maybe? "Data sources and references"?

I think there was another ticket about citing description things inline instead of in "data sources". it's not really a data source then too

I still think it'd be nice to clarify where which thing is coming from =(

@akegan what about the latest version?

@ericboucher please push your changes -- the code does not reflect your screenshot.

still has some lines with multiple citations, some with only 1

What do you mean @akegan ?

Small caps please (JK)


Fies #6468 - Uses space match and adds newline for all sed flavors

Fix for: https://github.com/go-gitea/gitea/issues/6468
This makes it so both GNU sed (Linux) and FreeBSD sed (MacOS) can be used for the sed commands used after the swagger command in make generate-swagger.

FreeBSD sed does not support \s so just a space is used now between basePath: and "/api/v1" as that all there will be.

For the new line at end of file, FreeBSD feels it should always add it, GNU sed does not. Easiest to add the -e '$a\' command which adds a new line at the end of a file if one doesn't already exist.

Before one could use homebrew to install GNU sed and rename gsed to sed, but now one can't. Also aliasing gsed to sed was not possible.

Codecov Report

Merging #6473 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #6473      +/-   ##
==========================================
+ Coverage    39.4%   39.41%   +<.01%
==========================================
  Files         393      393
  Lines       53271    53271
==========================================
+ Hits        20992    20995       +3
+ Misses      29292    29290       -2
+ Partials     2987     2986       -1

Impacted Files
Coverage Δ

modules/sync/unique_queue.go
89.28% <0%> (+10.71%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04d78b6...5e2778d. Read the comment docs.


Add canary tagged releases to list-all

Bein able to install Bun's canary release would be great.

I don't think it's really useful.
asdf was not built with tag-based use cases in mind, and users have to manually remove/install them when needed.
it might be useful when selecting wide ranges in tool-versions, but I can't imagine there being a canary there.

I will add latest-stable that recommended by asdf, but I won't add any custom method then. Please open an issue to the upstream if you still want it


Pool::acquire always sends a ping to the connection it returns

Looking at my logs, it seems that sqlx sends a ping to a connection each time it is acquired from a pool, no matter how old the latest ping is. This results in a lot of unnecessary pings.
Would it be possible to add a configurable minimum delay before which connections can be acquired without ping ? So that when the application is busy, no ping is ever sent (sqlx knows that the connection is healthy because it has a recent successful request), but a ping is sent on the first request after a long period of inactivity.

You can do .test_before_acquire(false) on PoolOptions to turn off the pings on acquire.
That does mean the pool will stop pinging the connections entirely, though. The idle reaper should test connections but it doesn't.

What I would like is not to never test before acquiring, it is for sqlx to record the time of the latest successful ping or request on each connection, and to test the connection only if it is more than a few milliseconds ago.

Looking at the code, it seems that the problem is still there, isn't it ? @abonander
https://github.com/launchbadge/sqlx/blob/main/sqlx-core/src/pool/inner.rs#L363
The connection is going to be pinged again even if it had a successful interaction with the database half a millisecond ago.

It doesn't log a query every ping() call anymore and there's an example in the PoolOptions docs to implement your custom ping routine: https://docs.rs/sqlx/latest/sqlx/pool/struct.PoolOptions.html#example-custom-test_before_acquire-logic

Great, before_acquire is exactly what I needed, thank you !

Hmmm, sounds like I rejoiced too quickly. The example code in before_acquire_logic panics. I'll open a new issue.


CAMEL-16343: Avoid committing offsets on onPartitionsRevoked in case the user committing offsets

This will make camel-kafka commits offsets onPartitionsRevoked only if autoCommitOffsets is true and thus the use will have the full control on manual offset commit. Also, previously the manual commit offsets test was disabled and now is fixed with this PR

Hi,
I think you also need to check what is the value of autoCommitOnStop during shutdown.
As of now, during shutdown - kafka revoke the assigned partition, and then it is forcing commitSync
DEBUG org.apache.camel.component.kafka.KafkaConsumer: - onPartitionsRevoked: **-Thread 0 from topic ** DEBUG org.apache.camel.component.kafka.KafkaConsumer: - Forcing commitSync **-Thread 0 from topic ** with offset: 31621
if condition should be same as that in doRun() method

Hi,
I think you also need to check what is the value of autoCommitOnStop during shutdown.
As of now, during shutdown - kafka revoke the assigned partition, and then it is forcing commitSync
DEBUG org.apache.camel.component.kafka.KafkaConsumer: - onPartitionsRevoked: **-Thread 0 from topic **

DEBUG org.apache.camel.component.kafka.KafkaConsumer: - Forcing commitSync **-Thread 0 from topic ** with offset: 31621

if condition should be same as that in doRun() method

Can you please create a JIRA ticket for it? Would be great if you send us a PR to fix it :)


Change the way in which the backward mode works

At the moment, our estimators have a backward mode which is indented to study the dynamics of the "backward" Markov process. I would change the interpretation of this and unify our treatment of initial, intermediate, and terminal states:

the backward mode should not change the naming of any attribute or method, nor should it make any method available. Any estimator should have the same methods and attributes available, independent of its direction.
the backward characteristic of an estimator should thus only act as a description of the estimator; the user themselves should understand to interpret terminal states in the backward process as initial states of the forward process
initial and terminal states should be treated equally; every estimator should have equivalent methods available for their identification and visualization, e.g. compute_terminal_states and compute_initial_states, plot_terminal_states and plot_initial_states, etc. They should also be written to equivalent attributes in the estimator and in AnnData.
the predict() method should compute both initial and terminal states
we need to discuss the treatment of intermediate states - ideally, the predict() method would perform a full classification of states into either initial, terminal, or intermediate.

Changes:

introduce a method classify_states that controls which states are computed via a which parameter (default: terminal)
plotting: use the plot_macrostates method, introduce a which parameter (None by default)
For manual setting: set_states_from macrostates and set_states with which argument
The predict method is just an alias for classify_states (other way round)

Hi Mike, what's the state here - should I test this again?


Add notification receiver

This PR adds notification receiver.

Coverage remained the same at 100.0% when pulling 4d9c2d0287d26a287fb07091b23832917d0c2edd on fisuda:feature/receiver into 7f8afd340397ede5664fc14a5881736d4dea6369 on lets-fiware:main.


WinUI 3 - Update AppWindow custom buttons for Windows 11

Describe the bug
Windows 11 introduced new caption button icons for windows. While being similar to Windows 10's, 11's caption button icons are more rounded and, in my opinion, a little bit thicker, to reflect the change in window geometry.
When setting AppWindowTitleBar.ExtendsContentIntoTitleBar to true the caption buttons don't reflect the new style on Windows 11.  In the screenshots section you can see a side-by-side view of the Settings app and a WinUI3 Desktop App titlebar. Notice that the maximize button is completely square for WinUI3, but rounded in Settings and many other windows.
Steps to reproduce the bug

Steps to reproduce the behavior:

Create a WinUI3 Desktop app with the 1.0.0 experimental release.
Set AppWindow.TitleBar.ExtendsContentIntoTitleBar to true.
The caption buttons look like Windows 10's and not Windows 11's.

Expected behavior
WinUI3 custom caption buttons should be rounded on W11 and square on W10. WinUI should automatically choose the icons from the Segoe Fluent Icons font.
Screenshots

Version Info
NuGet package version: [WinUI 3 - Windows App SDK 1.0.0: 1.0.0-experimental]
Windows app type:

UWP
Win32

No
Yes

Windows version
Saw the problem?

Insider Build (22000.132)
Yes

October 2020 Update (19042)

May 2020 Update (19041)

November 2019 Update (18363)

May 2019 Update (18362)

October 2018 Update (17763)

April 2018 Update (17134)

Fall Creators Update (16299)

Creators Update (15063)

Device form factor
Saw the problem?

Completely off-topic, but Windows 11 has the best UI since W7. Fluent Design now looks like it's ready to build complex and advanced apps with great UX. Microsoft reinvestment in Windows looks good.

No matter what do you think about the UI Design of Windows 11, the basic non-client area style should be unified. Many details of WinUI3 are supposed to be polished, surely including this issue.

Hey, this was a known bug in the experimental release and a fix has already been made. Expect the fix in the Preview 1 release.


Nice branching infographics

https://twitter.com/jay_gee/status/703360688618536960

I really like this and will try to build it in.


Certain panels in Atom will not render completely

I've noticed various panels in Atom are not being rendered completely. Adjusting the editor size will change the results of the partial rendering. Example of rendering differences when changing width of the entire window:

So far, I've noticed this behavior on the following:

Atom > Preferences > Installed Packages
Markdown preview

Tested on v1.2.4 and v.1.3.0-beta6, community extensions disabled. System info below:

Refs atom/one-dark-ui#109.

This has been fixed by https://github.com/atom/one-dark-ui/pull/112


Issue on Text Display with RTL

We are trying to upgrade our e-commerce site with multi language English and Arabic interface, but the right to left RTL text direction got missed up in web HTML rendering with Flutter 3.7
How to solve this issue? we are super excited to work on the new version of #flutter
for example:

correct expected output: (test) (هذا نص تجريبي (اختبار
wrong  result:

we have tried this code sample, but it was not working
import 'package:flutter/material.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        primarySwatch: Colors.blue,
      ),
      home: const HomePage(),
    );
  }
}

class HomePage extends StatelessWidget {
  const HomePage({Key? key}) : super(key: key);

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: Center(
        child: Directionality(
          textDirection: TextDirection.rtl,
          child: Text(
            '(test) (هذا نص تجريبي (اختبار',
            style: TextStyle(fontSize: 30, fontWeight: FontWeight.bold),
          ),
        ),
      ),
    );
  }
}

Reproducible using latest versions on web.

 stable, master flutter doctor -v
[!] Flutter (Channel stable, 3.7.6, on macOS 12.2.1 21D62 darwin-x64, locale
    en-GB)
    • Flutter version 3.7.6 on channel stable at
      /Users/dhs/documents/fluttersdk/flutter
    ! Warning: `flutter` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/flutter, which is not inside
      your current Flutter SDK checkout at
      /Users/dhs/documents/fluttersdk/flutter. Consider adding
      /Users/dhs/documents/fluttersdk/flutter/bin to the front of your path.
    ! Warning: `dart` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/dart, which is not inside your
      current Flutter SDK checkout at /Users/dhs/documents/fluttersdk/flutter.
      Consider adding /Users/dhs/documents/fluttersdk/flutter/bin to the front
      of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 12cb4eb7a0 (8 days ago), 2023-03-01 10:29:26 -0800
    • Engine revision ada363ee93
    • Dart version 2.19.3
    • DevTools version 2.20.1
    • If those were intentional, you can disregard the above warnings; however
      it is recommended to use "git" directly to perform update checks and
      upgrades.

[!] Xcode - develop for iOS and macOS (Xcode 12.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    ! Flutter recommends a minimum Xcode version of 13.
      Download the latest version or update via the Mac App Store.
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] VS Code (version 1.62.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.21.0

[✓] Connected device (5 available)
    • SM G975F (mobile)       • RZ8M802WY0X • android-arm64   • Android 11 (API 30)
    • Darshan's iphone (mobile)  • 21150b119064aecc249dfcfe05e259197461ce23 •
      ios            • iOS 14.4.1 18D61
    • iPhone 12 Pro Max (mobile) • A5473606-0213-4FD8-BA16-553433949729     •
      ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-3 (simulator)
    • macOS (desktop)            • macos                                    •
      darwin-x64     • Mac OS X 10.15.4 19E2269 darwin-x64
    • Chrome (web)               • chrome                                   •
      web-javascript • Google Chrome 98.0.4758.80

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

[!] Flutter (Channel master, 3.9.0-1.0.pre.164, on macOS 12.2.1 21D62
    darwin-x64, locale en-GB)
    • Flutter version 3.9.0-1.0.pre.164 on channel master at
      /Users/dhs/documents/fluttersdk/flutter
    ! Warning: `flutter` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/flutter, which is not inside
      your current Flutter SDK checkout at
      /Users/dhs/documents/fluttersdk/flutter. Consider adding
      /Users/dhs/documents/fluttersdk/flutter/bin to the front of your path.
    ! Warning: `dart` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/dart, which is not inside your
      current Flutter SDK checkout at /Users/dhs/documents/fluttersdk/flutter.
      Consider adding /Users/dhs/documents/fluttersdk/flutter/bin to the front
      of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 9ba0d08ebc (23 hours ago), 2023-03-12 00:16:19 -0500
    • Engine revision 57f7120ef9
    • Dart version 3.0.0 (build 3.0.0-322.0.dev)
    • DevTools version 2.22.2
    • If those were intentional, you can disregard the above warnings; however
      it is recommended to use "git" directly to perform update checks and
      upgrades.

[!] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Users/dhs/Library/Android/sdk
    ✗ cmdline-tools component is missing
      Run `path/to/sdkmanager --install "cmdline-tools;latest"`
      See https://developer.android.com/studio/command-line for more details.
    ✗ Android license status unknown.
      Run `flutter doctor --android-licenses` to accept the SDK licenses.
      See https://flutter.dev/docs/get-started/install/macos#android-setup for
      more details.

[✓] Xcode - develop for iOS and macOS (Xcode 13.2.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 13C100
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] IntelliJ IDEA Ultimate Edition (version 2021.3.2)
    • IntelliJ at /Applications/IntelliJ IDEA.app
    • Flutter plugin version 65.1.4
    • Dart plugin version 213.7228

[✓] VS Code (version 1.62.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.29.0

[✓] Connected device (3 available)
    • Darshan's iphone (mobile) • 21150b119064aecc249dfcfe05e259197461ce23 • ios
      • iOS 15.3.1 19D52
    • macOS (desktop)           • macos                                    •
      darwin-x64     • macOS 12.2.1 21D62 darwin-x64
    • Chrome (web)              • chrome                                   •
      web-javascript • Google Chrome 109.0.5414.119

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 1 category.

[!] Xcode - develop for iOS and macOS (Xcode 12.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    ! Flutter recommends a minimum Xcode version of 13.
      Download the latest version or update via the Mac App Store.
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] VS Code (version 1.62.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.21.0

[✓] Connected device (5 available)
    • SM G975F (mobile)       • RZ8M802WY0X • android-arm64   • Android 11 (API 30)
    • Darshan's iphone (mobile)  • 21150b119064aecc249dfcfe05e259197461ce23 •
      ios            • iOS 14.4.1 18D61
    • iPhone 12 Pro Max (mobile) • A5473606-0213-4FD8-BA16-553433949729     •
      ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-3 (simulator)
    • macOS (desktop)            • macos                                    •
      darwin-x64     • Mac OS X 10.15.4 19E2269 darwin-x64
    • Chrome (web)               • chrome                                   •
      web-javascript • Google Chrome 98.0.4758.80

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

@darshankawar Can you check how this text renders on non-web platforms? On my side, I see the exact same rendering when launching the app on desktop ('-d linux') and with the Android emulator.
@MOdeh90 Can you verify that, when setting textDirection to TextDirection.ltr instead of TextDirection.rtl, the result is the one you expected?

Can you check how this text renders on non-web platforms? On my side, I see the exact same rendering when launching the app on desktop ('-d linux') and with the Android emulator.

Yes, I see the same on desktop too and think if the directionality being passed in the sample code has anything to do with the current output. If we pass ltr, then the result is as expected, so maybe this is not an issue ?

Can you verify that, when setting textDirection to TextDirection.ltr instead of TextDirection.rtl, the result is the one you expected?

Verified this, and as stated above, the result is as expected:

@MOdeh90 Please confirm if passing ltr instead of rtl works in your case or not.

@darshankawar Can you check how this text renders on non-web platforms? On my side, I see the exact same rendering when launching the app on desktop ('-d linux') and with the Android emulator.
@MOdeh90 Can you verify that, when setting textDirection to TextDirection.ltr instead of TextDirection.rtl, the result is the one you expected?

@bleroux  Yes the result as expected when setting textDirection to TextDirection.ltr instead of TextDirection.rtl

Can you check how this text renders on non-web platforms? On my side, I see the exact same rendering when launching the app on desktop ('-d linux') and with the Android emulator.

Yes, I see the same on desktop too and think if the directionality being passed in the sample code has anything to do with the current output. If we pass ltr, then the result is as expected, so maybe this is not an issue ?

Can you verify that, when setting textDirection to TextDirection.ltr instead of TextDirection.rtl, the result is the one you expected?

Verified this, and as stated above, the result is as expected:

@MOdeh90 Please confirm if passing ltr instead of rtl works in your case or not.

@darshankawar yes, confirmed when passing ltr instead of rtl will working fine
but still we have issue when setting textDirection to TextDirection.rtl because the result as not expected while we working with Arabic Interface

Few things I noticed (too many details below, sorry):

LTR case shows the correct results but as far as I can see it happens almost by accident (one of the closing braces is considered RTL, all the other - LTR???)
run[0:8) left: '(test) ('
run[8:14) right: 'هذا'
run[14:15) right: ' '
run[15:19) right: 'نص'
run[19:20) right: ' '
run[20:32) right: 'تجريبي'
run[32:34) right: ' ('  - it is reverted in the picture
run[34:46) right: 'اختبار'
Both Chrome and Firefox show the same results as Flutter does: correct with LTR setting on the text, incorrect with RTL.
The text breaking in RTL case seems correct (yet the results are not):
run[0:1) right: '('
run[1:5) left: 'test'
run[5:8) right: ') ('
run[8:14) right: 'هذا'
run[14:15) right: ' '
run[15:19) right: 'نص'
run[19:20) right: ' '
run[20:32) right: 'تجريبي'
run[32:34) right: ' (' - it should be reverted in the picture but it's not!
run[34:46) right: 'اختبار'

I agree, we should fix the case with RTL settings on the text since that is the right way to use it. However, given that all browsers do the same wrong thing I am not sure we can fix it in Flutter (although we will try).


Yourls 2.0

Why is the Edit Action not working on Alpha Version 2.0
https://github.com/YOURLS/YOURLS/blob/2.0/includes/admin/admin-ajax.php
The other actions, share, delete and stats are working, only the Edit functions goes to a blank page
Thanks.
p.s. I know this is maybe not the right place the ask this question, is there a dev issue ticket list?

I'm not sure the 2.0 dev branches will be expanded. A lot of things have changed in master... Bootstrap is not the same... Not using enough 3rd party libs and re-inventing the wheel instead... So, not saying it won't, but not saying it will either.
Anyway, regarding your question: I don't know :)
(yes, this is a correct place to submit this issue)

Ok thanks, do you have some tip how we could include Bootstrap classes? I've created a simple plugin to add Bootstrap and Bootswatch https://github.com/scriptgeni/yourls-bootstrap-bootswatch (still working on it). But the thing is the class name are hardcode in functions_html.php and some other place. Is there a way to hook an extra CSS class to tables or other elements without changing the core files?


Markdown output

In a live installation (https://pylode.surroundaustralia.com) there is an option to generate output in Markdown format instead of HTML.
Please suggest how can I get output in Markdown format using the command line tool or programmatically.
I looked into the code but did not realize how is it possible.
Thanks in advance!

I think the Markdown generation was removed in version 3.x. The only options to generate Markdown that I'm aware of are using the code of the branch named 2.x or using this docker image (ghcr.io/ashleycaselli/pylode.md:1.0.4).


Add Apache and CC0 licenses

This is a suggested temporary solution to https://github.com/dada-lang/dada/issues/28, which is concerned with "runtime exceptions".
The CC0 license effectively makes all contents of this repository public domain, relinquishing all copyright claims wherever legally possible.
The intent here is that the CC0 license makes it possible to relicense the codebase in the future, once somebody has made more concrete decisions about how to apply a runtime exception, without getting consent from all prior contributors, and without requiring a contributor license agreement (CLA). At that stage, the CC0 license can be removed if desired (and in the meantime the CC0 is an effective runtime exception), leaving prior code without copyright claims, but future code under the new license.
It does require contributors to completely relinquish any copyright claims to their contributions, but not to another entity as with a CLA.
I feel nervous about this as it is rare to completely give up all rights like this (though some like @burntsushi do it), but I also think the practical impact of downgrading from MIT to CC0 is effectively none, and it's a bold statement.
I am completely open to not doing this - alternate solutions can be discussed on the associated issue.
The Apache-2 license remains necessary for its clauses preventing contributors from using patents maliciously. The MIT license then is kind of superfluous with CC0, but is common and understandable and the MIT/Apache combo is standard in the Rust community.
As far as existing contributors are concerned, I think it is easy to argue that nobody but @nikomatsakis actually has copyrightable material here yet, so this relicense can be done without explicit consent, but existing contributors should still approve of such a bold license choice cc @XFFXFF @lqd @mbrobbel.

In principle, I love this. Let me dig a bit into the legal implications though.

One question I have -- if we have deps that are MIT/Apache2, does this present an issue?

On further reflection, feeling pretty good about this formulation.

One question I have -- if we have deps that are MIT/Apache2, does this present an issue?

It doesn't present an issue to applying CC0 to this repo, but it does when it comes time to think about which parts of code truly need runtime exceptions. Just like in the Rust standard library we have to consider that anything in the library is MIT-equivalent, we would need to be careful that any code that might be compiled into a dada program has a runtime exception.
This would become an issue with Rust crates that are compiled into the dada runtime.
A related and distant concern is that if we establish a runtime exception for dada itself, then, like in the Rust ecosystem, we might hope that most other crates would pick the same license. This would solve a common problem in pretty much every package-based ecosystem where most projects distributing binaries ignore the attribution requirement for binaries, and in practice nobody really cares, but technically they are violating the license.

Having this repo be CC0 would also need we need to be careful not to just copy-paste code from other Rust projects.

One question I have is this - if CC0 says "I give up all copyright claims", but we're also distributing under license that indicate the code is copyrighted, what is the actual legal impact to the MIT and Apache license. It may be that the MIT license is completely invalidated in a way that doesn't really matter, but do the patent-protection clauses of Apache still hold?

@brson Assuming we did not take this route...

It doesn't present an issue to applying CC0 to this repo, but it does when it comes time to think about which parts of code truly need runtime exceptions. Just like in the Rust standard library we have to consider that anything in the library is MIT-equivalent, we would need to be careful that any code that might be compiled into a dada program has a runtime exception.

...it seems like any deviation from the Rust license is going to cause a potential issue here, right? i.e., the structure of our license is going to be "MIT + Apache2 + X" where X is the "runtime exception". But that is already distinct from the license of most every Rust library we use, which is MIT + Apache2.

@brson Assuming we did not take this route...

It doesn't present an issue to applying CC0 to this repo, but it does when it comes time to think about which parts of code truly need runtime exceptions. Just like in the Rust standard library we have to consider that anything in the library is MIT-equivalent, we would need to be careful that any code that might be compiled into a dada program has a runtime exception.

...it seems like any deviation from the Rust license is going to cause a potential issue here, right? i.e., the structure of our license is going to be "MIT + Apache2 + X" where X is the "runtime exception". But that is already distinct from the license of most every Rust library we use, which is MIT + Apache2.
But I guess that the narrower we can make X, the better.

Yes. Since a large amount of the code will be 3rd-party Rust crates, dada will mostly by Rust-licensed. The only hope for a runtime exception making a meaningful difference is if we can create a boundary around the dada runtime through which we can keep Rust-licensed code out, or at least limited, with a pathway to replacing it.
To be clear this concern doesn't apply to the interpreter, for which there's no hope of losing the Rust license, but for code directly compiled into compiled dada distributables.

That also includes things like a dada standard library. So having a runtime exception could be more impactful for a prospective dada ecosystem, even if the ship has sailed for the rust ecosystem.

With the dada runtime likely being written largely in Rust, it will be difficult to completely get rid of the Rust license, though I could schemes to limit how much of Rust core/std is used, with some plan to eliminate it.

Well, this has sat here for a while! I'm not really sure what I'm waiting for. I like the idea of this PR, but I also feel like it may be impractical to really do anything but conform to the general Rust license setup, imperfect as it is.

I'm going to close this for now, but we should revisit the question at some point.


flanneld binary is quite large

The flanneld binary got quite large when we added the kube-subnet-mgr (which imports a lot of code to get a k8s client). It would be nice to get the size back down, some options are:

Start using https://github.com/kubernetes/client-go
Start using https://github.com/ericchiang/k8s

Even with the move to client-go the binary is still ~52MB

I think to make them smaller we'd need to use upx (and maybe some stripping)

A crazier option would be shipping different binaries for k8s vs etcd backed flanneld.


Update all APIs to be mostly-compatible with GAX 4.0.0-alpha02

Most of these changes are hand-written, with the final giant commit being autogenerated.
We can periodically rebase this branch from main, regenerating right as the final commit each time to avoid conflicts.
It should compile and unit tests should pass, but I expect integration tests to fail at the moment for some APIs where we need to expose more via GAX - those changes all have FIXME in the text.

Note: we expect "detect differences" to fail. There needs to be a tooling change there to pick up different TFMs to compare against.


I create a subfolder to categorize some system tiddlers. But when they were modified, the position change to root tiddler folder!

Can Tiddlerserver save the file in its subfolder position?

It should work exactly the same as the TiddlyWiki Node server. If you can do this properly with the Node server but not with TiddlyServer than could you explain in more detail how to do it in the Node server and I will attempt to find why it is not working the same in TiddlyServer.


R: Add Python wrapper for calling R's hierarchical methods

Issue #, if available:
Description of changes:
Adds a python wrapper for calling R's hierarchical forecasting methods. The processing of the input (multivariate) target and the forecasts are slightly different from what we have in the current wrapper for uni-variate methods. So, factored out the common stuff by adding a new base class _predictor.py and keeping the specifics in _univariate_predictor.py and _hierarchical_predictor.py.
Also added implementation of the naive bottom up reconciliation method. This is tested on a synthetic hierarchical dataset using both ETS and ARIMA as base forecasting methods.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Seems like GitHub is complaining about conflicts, but I don't understand it. Maybe try to rebase on top of dev and force-push?

This is due to the recent bug fix on mainline. Resolved the conflict manually and this change now appears in both  _univariate_predictor and _hierarchical_predictor.


Create new release and ship to PyPI

There have been a number of changes since the January release, would it be possible to cut a release , 0.4.2, and ship to PyPI? Right now we're using this dependency in our own stack and it would be great to unpin it from a git hash, happy to do this if it's something I as a contributor have privileges for. Thanks!

Definitely, was thinking we should do this--will release sometime this week!
cc @lintangsutawika

please consider merging these #1571 #1569 before version bump

may this implementation https://github.com/EleutherAI/lm-evaluation-harness/pull/1578 will find its way to the new release (as long awaited one https://github.com/EleutherAI/lm-evaluation-harness/issues/1543)

Hi @artemorloff ! Thank you very much for the PRs, I will review #1571 today or tomorrow. However, I don't think we'll include it in the new version release, in the interest of not introducing large changes that haven't had the time to settle
Likewise, regarding #1578 -- chat templating is still something both requested and desired, but we haven't merged it yet because we've been seeing inconsistent results including decreased scores when applying a chat template. Hope to get it added soon nevertheless, but likewise would prefer to put out v0.4.2 now and follow up with a v0.4.3 relatively soon if some other major changes get landed.

May I suggest using the milestones feature of github as (seems) it was used before. Because these PRs with big changes appeared now, as I think, because of this announcing issue happened just 3 days ago, so people with requested and desired implementations start getting them done quickly to be included in pypi. And with milestones some kind of planning and announcing can be done.

Thank you @LSinev for the feedback, well taken and appreciated! Will work on getting things better-documented for the future for certain, and set up milestones for visibility.
I'm still leaning toward putting out v0.4.2 ASAP since it's been a while and subsequently having much more frequent minor releases to keep PyPI more up-to-date than it has been, which I hope might be a good middle ground here, but if this is significantly disappointing to contributors then would like to know.

Hi, I asked about the chat template issue in issue #1543 and @LSinev kindly guide me to this PR and some other PRs and issues that might solve my problem. He also suggested me to leave some thoughts about some certain PRs.
I read some of the core changes in #1578 that might help solving this chat templating issue and here are my thoughts and reviews
Pros:
This PR supports chat template by revising the tok_batch_encode function. To enable apply_chat_template function, we simply needs to pass --model_args "is_chat_model=True,apply_template=True". It conveniently wrapping up the hf chat template function to use.
Cons:
I am kind of concern on how this revision could apply to many different cases as it kind of pre assume that every input string is a user role. Let's say I want to add some different system message to ensure best performance or some user, assistant few shot dialogue as in context examples. I am not sure how this can be achieved through this small revision.
At last, I feel this feature needs more changes before merging or releasing. Some of the possible solutions that I feel might possible is like allowing the user to pass in system prompt say like --system "You are a helpful assistant" for custom system prompt that applies to every requests. For assistant role that could possibly appear in the context might need to revise the few shot context function.
And again, thank you for your great work!

Thank you for the feedback @kcz358 !
If you'd like to also check out https://github.com/EleutherAI/lm-evaluation-harness/pull/1287 , this PR allows for system prompts to be passed in . The problem of dividing context appropriately amongst user / assistant content is something which we will have to fix for certain before merging in support.

Hi @artemorloff ! Thank you very much for the PRs, I will review #1571 today or tomorrow. However, I don't think we'll include it in the new version release, in the interest of not introducing large changes that haven't had the time to settle

Hi @haileyschoelkopf ! I was just wondering if there was any follow-up to my change request. Would it be possible to provide an estimate of when you might be able to review the changes? I'm eager to incorporate any feedback you may have and move forward with the development process.


docs(moveField): document moveField in readme

👍 Looks good to me!

:tada: This PR is included in version 0.15.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[firebase_admob] should treat app installation as reward

I'm not sure if it should work this way by design, but IMO if user already had an interaction with rewarding ad (clicked on install), plugin should emit rewarded event

@lesnitsky
The issue at https://github.com/flutter/flutter/issues/26828 has been closed and moved here. Future collaboration on this issue will be done here.

The firebase_admob plugin will be deprecated in April 2021 in favor of Google Mobile Ads SDK for Flutter.
Google Mobile Ads SDK for Flutter is a new Flutter plugin that supports more Ads formats than firebase_admob does. Google Mobile Ads SDK for Flutter currently supports loading and displaying banner, interstitial (full-screen), native ads, and rewarded video ads across AdMob and AdManager. It also supports displaying banner and native ads as Widgets as opposed to being overlayed over all app content.
We're now recommending projects currently using firebase_admob migrate to Google Mobile Ads SDK for Flutter following the instructions outlined here.
Issues with migrating or with using the new package should now be raised over on the Google Mobile Ads SDK for Flutter repository.


Checkbox Mui-focusVisible does not work with preact

[x] The issue is present in the latest release.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯
When navigating with the keyboard - tabbing through inputs the checkbox does not show anything to indicate it is focussed
Expected Behavior 🤔
When focussed the checkbox should get a highlight
Steps to Reproduce 🕹
Steps:

Goto https://codesandbox.io/s/optimistic-goldberg-0kri6?file=/src/index.js
Click in the rendered page
Press tab once (at this point checkbox should be focussed)
See there is no indication of focus
If you press space it should toggle the checked state - confirming the checkbox was focussed

With react where it is working:

Goto https://codesandbox.io/s/zen-edison-uuojo?file=/src/App.js
Click in the rendered page
Press tab once, the checkbox is focussed and it gets highlighted to show it has focus.

Context 🔦
We use Preact, we have forms with checkboxes, we want users to be able to navigate with a keyboard and know when they are on the checkbox
Your Environment 🌎

`npx @material-ui/envinfo`
  System:
    OS: Linux 4.4 Ubuntu 18.04.5 LTS (Bionic Beaver)
  Binaries:
    Node: 16.4.1 - ~/.heroku/node/bin/node
    Yarn: 1.22.10 - ~/.heroku/yarn/bin/yarn
    npm: 7.18.1 - ~/.heroku/node/bin/npm
  Browsers:
    Chrome: Not Found
    Firefox: Not Found
  npmPackages:
    @material-ui/core: ^4.6.0 => 4.11.2
    @material-ui/icons: ^4.5.1 => 4.11.2
    @material-ui/lab: ^4.0.0-alpha.39 => 4.0.0-alpha.57
    @material-ui/styles:  4.11.2
    @material-ui/system:  4.11.2
    @material-ui/types:  5.1.0
    @material-ui/utils:  4.11.2
    @types/react: ^16.9.11 => 16.14.2

Preact
    @preact: 10.5.14

Also seeing this locally with
    @material-ui/core 4.11.4
    Firefox 89.0.2
    Chrome 91.0.4472.114
    MacOS 11.4

Thanks for the report.
This probably happens because preact does not bubble focus events like react does. We do rely on this behavior in a couple of other places as well. I suggest you move to react or use :focus-visible pseudo selectors to fix this compatiblity problem.

Ah, thanks for the explanation and suggestions


Update Cargo.toml add repository

to allow crates.io, rust-digger, and others to link to it.

Thank you very much for this pull request, @szabgab !
I will publish it within the next release.

You are welcome. On this page you'll find information about all of your crates. I hope it will be helpful.


DROOLS-1114 - Add ConversationId http header/jms property to allow dy…

…namic routing of requests - changed conversationId format

jenkins retest this


Nuget download issue on PCL project

Hi,
Tried to download and install DLToolkit
https://www.nuget.org/packages/DLToolkit.Forms.Controls.ImageCropView
Could not install package 'System.Runtime.InteropServices.RuntimeInformation 4.0.0'. You are trying to install this package into a project that targets '.NETPortable,Version=v4.5,Profile=Profile111', but the package does not contain any assembly references or content files that are compatible with that framework. For more information, contact the package author.
i already tried the workaround shown here:
https://forums.xamarin.com/discussion/80045/error-using-nuget
but then all my other dependencies not loaded.

Yes, it's because RX dependencies. I'll try to remove that dependency but I'll need to think of how to handle event throttling without it first.

I just removed RX dependencies, just use 1.0.5 nuget :) It should work now on 111 profile.


[ENH] remove _serialize file and functions therein

for some reason there is a file called _serialize in the base class directory that simply wraps pickling functionality. I see no point in it. Can deprecate it or keep it if anyone wants to. I think the example should change if we keep it, it uses a CNNClassifier and I think this is not the best way to save/load keras estimators?

for some reason there is a file called _serialize in the base class directory that simply wraps pickling functionality. I see no point in it. Can deprecate it or keep it if anyone wants to. I think the example should change if we keep it, it uses a CNNClassifier and I think this is not the best way to save/load keras estimators?

Yes i agree, there was even lots of this kind of tests in deep learning module, where someone tried to force this kind of saving on deep learners but never worked, i just deleted them :)


Create deployment code

Create a deployment method for the needed containers, and commit it as code to a deployment repo or as a folder in the projects..
Lets discuss pros and cons of different deployment metods for the containers...
Scalability? Statelessness? Cross-infrastructure deployments?
What toolstack?
Podman? K8s? Docker-swarm? Ansible-pull?
This issue should be handled by a devops team with solid container deployment experience...

Initial work is available in the (now sadly) long running branch #18.
This work should be moved out of the issue-tracker repo and be placed in its own deployment-template repo.


[HUDI-2168] Fix for AccessControlException for anonymous user

What is the purpose of the pull request
To fix access control exception while running the test cases which involves starting the Hive service
Brief change log
Set config
config.setBoolean("dfs.permissions",false);

Verify this pull request
This pull request is a trivial rework / code cleanup without any test coverage.

Verified the tests are running locally after this change

Committer checklist

[X] Has a corresponding JIRA in PR title & commit

[X] Commit message is descriptive of the change

[ ] CI is green

[ ] Necessary doc changes done or have another open PR

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

Codecov Report

Merging #3264 (e8e5e31) into master (b0089b8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             master   #3264   +/-   ##
========================================
  Coverage      2.86%   2.86%
  Complexity       85      85
========================================
  Files           283     283
  Lines         11711   11711
  Branches        961     961
========================================
  Hits            335     335
  Misses        11350   11350
  Partials         26      26

Flag
Coverage Δ

hudiclient
0.00% <ø> (ø)

hudisync
5.37% <ø> (ø)

hudiutilities
9.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0089b8...e8e5e31. Read the comment docs.


[BACKLOG-6777] Fixed getDirectory( String path ) method of

LazyUnifiedRepositoryDirectory when creating a new
LazyUnifiedRepositoryDirectory, now it will have the right parent
directory as argument

@pentaho-nbaker @rmansoor please review. Cherry picked from #2242


[CSL-160] MPC communication: further improvements

@gromak
In CSL-97 we have significantly improved MPC communication by using more reasonable protocol. Hopefully it will be enough. However, if we see that it's not enough and other optmizations (e. g. serialization/networking) don't help, we'll need to do something with it.
Some thoughts from [this comment|https://issues.serokell.io/issue/CSL-97#comment=96-961]:
• --now we send only one item in inventory message (because they are created we 1 item: our own item). Instead of doing it we can collect some data and resend it once per second or something. Some experiments are required to check what is better.--
• Do not send data to node which sent it to us. If it's not very hard to do, let's do it. It won't give us significant benefit, but even 5-10% is good enough.
• Request inventory from neighbors on joining network. Probably useless, but I will leave it here.
• Batch requests of openings? Makes sense only if we collect multiple messages before sending.
• LRU caching of messages?
• Do not ask same data from many neighbors, only from one per 0.5 sec, for example.
See more details in CSL-97. Ideally we won't need anything from here.

@gromak

• now we send only one item in inventory message (because they are created we 1 item: our own item). Instead of doing it we can collect some data and resend it once per second or something. Some experiments are required to check what is better.
Now we have CSL-722 for it, this improvement is not MPC-specific.

@gromak
Actually, almost improvement apply not only to SSC, but also to other components.


NormalizeRenderer loses block quote formatting when used in lists

Hello,
I want to process a list of block quotes using the following code:
            var pipeline = new MarkdownPipelineBuilder().UseAdvancedExtensions().Build();
            var content =File.ReadAllText(sourcePath);

            var markdownDoc = Markdown.Parse(content, pipeline);

            using (var streamWriter = new StreamWriter(targetPath))
            {
                var renderer = new NormalizeRenderer(streamWriter);

                renderer.Render(markdownDoc);
            }

I'm using the following markdown as source:
List of blockquotes
1. > This is a quote in a list 1
2. > This is a quote in a list 2
3. > This is a quote in a list 3

The result is:
List of blockquotes

1. This is a quote in a list 1
2. This is a quote in a list 2
3. This is a quote in a list 3

I've expected the result to be the same but the block quote formatting is lost in the target file.
Is there any way to use Markdig and preserve both list and block quote formatting?
Regards.
Mircea

Yeah, NormalizeRenderer hasn't been developed to be fully supported/completed, it's a work in progress (e.g #155), so likely block quotes are not supported correctly. PR Welcome.


On start up of Solr you get an ALARMING message about shared memory.

Turns out it really doesn't matter, but for people who aren't deep in Solr, it's pretty shocking.
This triggered a documentation fix for Solr ;-)  https://github.com/apache/lucene-solr/pull/2304

I'd like to merge this, can I get a LGTM?


[Error] Error downloading account name

Hi
DebugInfo.log

I've cloned this repository and (temporarily) fixed the issue.
Feel free to download the new version I've created from my own repository, it should be public.
https://github.com/Omga4000/Procurement/releases/tag/1.30.0
Let me know if that works for you.

@chrlsfrmg
Your account name was not found.
Verified manually - it really wasn't found.
When was the last time you've logged into the game?
If it was before 11.08.2020, you will not be able to use it.
You can use this tool to check whether the API can find your account or not: https://poe.watch/Account

?

@chrlsfrmg O nome da sua conta não foi encontrado. Verificado manualmente - realmente não foi encontrado.
Quando foi a última vez que você entrou no jogo? Se foi antes de 11.08.2020, você não poderá usá-lo. Você pode usar esta ferramenta para verificar se a API pode encontrar sua conta ou não: https://poe.watch/Account

I'm playing now!

Why are you giving this? I'm playing right now, I've been playing for days now.

@chrlsfrmg
False positive, I assume.
Did you ever scan 1.29.1 to see if the result is the same?
You can fully see all of my changes and see I made no significant ones, definitely not something that will trigger a virus alter, unless the original Procurement also triggered it - GitHub doesn't hide anything.
Regarding why this is not working for you, I cannot say.
I gave you this website because the changes I've made are based off of poe-watch's API and if they cannot find you, it won't work.
You'll need to resolve it and have that website recognize you before you can use my changes.

How can I get it recognized? It's saying not found, but I've been playing for several days now.

Help me pls

I play on Steam, is this what is causing this error?

@chrlsfrmg
Please stop replying in chains. Edit your previous message if you have additional things to mention.
Regarding your issue - I do not know what is causing it.
I don't believe you playing through Steam is the issue as I have tried it with a Steam account and it works.
Contact their support / Discord channel to get it resolved.

Contact their support / Discord channel to get it resolved.

PoE or Procurement support?

Contact their support / Discord channel to get it resolved.

PoE or Procurement support?

poe-watch, the site I linked. They have a Discord channel listed in their website.

Thank you very much!

I was informed that it is not being shown, as I do not have public stash tabs. The 4 normals that come with the game are not public unless we get 1 paid.

@chrlsfrmg
Please try the latest release. It contains a new fix which should work permanently.
https://github.com/Omga4000/Procurement/releases/

@chrlsfrmg
Please try the latest release. It contains a new fix which should work permanently. https://github.com/Omga4000/Procurement/releases/

EXCELLENT!!!! It worked!!!

Duplicate of #1140.


[Improve][JDBC]jdbcOutputFormat use BufferReduce

Purpose of this pull request

jdbcOutputFormat use BufferReduce
1.Use bufferReduce to precompute on a batch of data, reducing interaction with the database
2.Fix the primary key duplication problem caused by repeatedly modifying the same primary key data in the data restoration job
Which issue you fix
Fixes # (issue).
Checklist:

[ ] I have executed the 'mvn spotless:apply' command to format my code.
[ ] I have a meaningful commit message (including the issue id, the template of commit message is '[label-type-#issue-id][fixed-module] a meaningful commit message.')
[ ] I have performed a self-review of my own code.
[ ] I have commented my code, particularly in hard-to-understand areas.
[ ] I have made corresponding changes to the documentation.
[ ] I have added tests that prove my fix is effective or that my feature works.
[ ] New and existing unit tests pass locally with my changes.
[ ] I have checked my code and corrected any misspellings.
[ ] My commit is only one. (If there are multiple commits, you can use 'git squash' to compress multiple commits into one.)

@chaozwn @FlechazoW @ll076110


Yarn2nix-moretea is GPL-3.0 licensed, should be MIT

Describe the bug
Problem
All expressions in nixpkgs are supposed to be MIT licensed, but yarn2nix-moretea is licensed under GPL-3.0.
yarn2nix-moretea as an externally developed project under different licensing terms that we use for nixpkgs.
It was merged into nixpgks in https://github.com/NixOS/nixpkgs/pull/108138 without the license being changed to MIT or a compatible license.
Impact
Every package using mkYarnPackage is using improperly licensed expressions, which at the time of writing looks to be a bit more than 25 packages.
Solution
I have two proposed solutions, neither of which are particularly appealing:

Re-license yarn2nix-moretea under MIT

This would require assembling relicensing signatures from all existing yarn2nix authors which include both contributors when it was in nix-community & in nixpkgs.
It's gonna take some time and keep us in license non-compliance in the mean time.

Drop yarn2nix, migrate packages to something else

The newly added yarnBuildHook looks like a good contender as pointed out by @SuperSandro2000 in chat.
CC
CCing authors and other relevant parties

@zimbatm
@moretea
@lassulus

Add a :+1: reaction to issues you find important.

Just to repeat what I said on Matrix, if we can’t figure out something better in a few days I will open a relicensing issue and start the work of pinging all the contributors. Reimplementing it sounds nice, but I suspect it would take quite a while given the speed at which Nixpkgs language ecosystems tend to move.

yarn2nix can be easily misused and trigger IFD. I think too that in the long run we should replace it.
Maybe yarnBuildHook/yarnConfigHook from https://github.com/NixOS/nixpkgs/pull/318015 are already enough and the package can easily be migrated?

(Nixpkgs potentially actually being GPLv3 is very much a bug IMO.)
Migration is all well and good, but we probably ought to try to relicense anyway: we can’t change old revisions of Nixpkgs and it’s not good for multiple years of Nixpkgs history to be under unclear licensing conditions.

I guess re-licensing is the better way for now? We can ping all the contributors, from a glance I read most of the names before.

Yes, I think we should probably at least try. I will open a new GitHub issue for it today so that we can discuss here without it getting bogged down in rote responses.

Okay, here we go I guess: https://github.com/NixOS/nixpkgs/issues/334374

Oof, thank you @emilazy for trying to clean up that mess.
I just got the notification from the tracking issue and I'm feel that a big portion of any blame should go towards my direction because of the introduction in #60429, rather than #108138
While I (try to) put a lot more thought into licenses today, it didn't cross my mind back then that vendoring with the included license could have such implications.

No worries @WilliButz – thanks for trying to improve the Node packaging situation in Nixpkgs and for your quick reply to the ping! This is an institutional failure IMO, and I think that it would have been caught before merge these days.

@petabyteboy (GitHub account is gone; will try to follow up via email unless anyone knows other current contact information)

https://discourse.nixos.org/u/petabyteboy seems still active. It might be worth posting the same as https://github.com/NixOS/nixpkgs/issues/334374 on Discourse if you want people's replies to be public.


Remove explicit heights on form elements

Input heights were initially added in https://github.com/twbs/bootstrap/pull/26820 to fix https://github.com/twbs/bootstrap/issues/18842. Select heights were added to fix https://bugzilla.mozilla.org/show_bug.cgi?id=1560824.
But:

The additional height in https://github.com/twbs/bootstrap/pull/26820 was caused by pseudo elements, something I fixed in https://github.com/twbs/bootstrap/pull/30269.
In the meantime the select issue in FF is changed when you explicitly set the line height (https://bugzilla.mozilla.org/show_bug.cgi?id=1560824#c14), making setting the height redundant

However, removing the explicit height would reintroduce https://github.com/twbs/bootstrap/issues/23307. Luckily, date inputs have a ::-webkit-datetime-edit of which we can set the height in em 🎉
This means, we can safely remove those (min-)heights that seem to cause some issues like https://github.com/twbs/bootstrap/pull/26820#issuecomment-565485267 or https://github.com/twbs/bootstrap/pull/31955#issuecomment-716101054 (this needs to be confirmed though)
I've kept a min-height for textareas, to keep support for https://github.com/twbs/bootstrap/pull/29124
I didn't apply this change to .form-file, since this will introduce conflicts with https://github.com/twbs/bootstrap/pull/31955, therefor I'll keep this in draft.

Don't merge this yet, I'm doing some tests withs input field heights to confirm this works (already found a bug in the current implementation which was solved in this PR, lol)

Ok, I made a codepen to check browsers with and it looks like we're ok with this change: https://codepen.io/MartijnCuppens/pen/JjKpbGd?editors=1010
I actually even found out there's a bug with the current implementation: https://codepen.io/MartijnCuppens/pen/PozQbqJ?editors=1010

i think this change now made <input type="color"> revert to its odd/small size - see for instance https://deploy-preview-32020--twbs-bootstrap.netlify.app/docs/5.0/forms/form-control/#color (from my other PR)


Implement new Google Play In-App Review API

Version 0.7 of https://pub.dev/packages/rate_my_app/changelog already includes this possibility.

Updated to version 1.7, and there is no code change required.
Was unable to test, though, as the if and when the pop-up appears is now controlled by Google according to "Quotas" section of this:
https://developer.android.com/guide/playcore/in-app-review


557 stage times

Pull Request Overview

Addition of stage start times to Sighting and AssetGroupSighting Detailed info plus the assetgroupsightingasasightinng one
Change AssetGroupSighting to be a proper constructor and moved the creation loging out of AssetGroup into there
Fixed a few tests that were creating AssetGroupSightings in ways that will never occur in the real system
Found and fixed a coup[le of bugs in the identification and collaboration code

Draft still as I just realised that the un-reviewed time logic is the wrong way around
Also moved AGS setup into an init function and caught a coupe of tests that were testing AGS in ways that  it will never be used. More comments inline about this.
Model Updates
AssetGroupSighting

detection_start_time
curation_start_time

Sighting

unreviewed_start
review_time

REST API Updates]
Only new fields shown
[GET]  /api/v1/asset_groups/sighting/{ags_guid}
[GET]  /api/v1/asset_groups/sighting/as_sighting/{ags_guid}
{
    'curation_start_time': 'iso datetime if detection finished or not started, started, null if detection in progress',
    'detection_start_time':  'iso datetime if detection started, null otherwise'
}

[GET]  /api/v1/sighting/{sighting_guid}
{
    'curation_start_time': 'iso datetime if detection finished or not started, started, null if detection in progress',
    'detection_start_time':  'iso datetime if detection started, null otherwise'
    'identification_start_time':  'iso datetime if identification started, null otherwise'
    'unreviewed_start_time':  'iso datetime if identification finished or not started, started, null if identification in progress',
    'review_time': null right now will be populated when review implemented
}

/rebase

/rebase

/rebase

/rebase


Delegation of Trait Implementations

For our custom types Float and Double, we have to delegate quite a lot of trait implementations to the underlying f32 and f64 types, respectively. I played around with delegate and ambassador a bit but I did not achieve satisfying results here.
This is not a pressing issue at all but it would be nice to have if we can find a nice way to shorten those delegations.
Feel free to experiment here :)

Is this still something that needs solving?

If there should be a new language feature in the future that makes delegations easier, we might reconsider this but before that there is not much that can be done :)


just installed nadeko files and haven't touched them but getting errors

not entirely sure how to fix this

Update your bot, you're on 1.3x

Update your bot, you're on 1.3x