Next.js SSG Build Error with styled-jsx > 3.1.2

Do you want to request a feature or report a bug?
Bug
What is the current behavior?
I have a next.js app with SSG and SSR pages. When I compile via next build, I compiles fine with styled-jsx 3.1.2, but fails with 3.1.3 and 3.3.0.
Creating an optimized production build

Compiled successfully.

Warning: You have opted-out of Automatic Static Optimization due to `getInitialProps` in `pages/_app`. This does not opt-out pages with `getStaticProps`
Read more: https://err.sh/next.js/opt-out-auto-static-optimization

Automatically optimizing pages .

Error occurred prerendering page "/some/ssg/page". Read more: https://err.sh/next.js/prerender-error
TypeError: Cannot read property 'replace' of undefined

[..] (for each SSG page, the same error is shown)

tsc build and linting succeeds correctly with any version.
I use nprogress (0.2.0) and next-nprogress (1.4.0) (it's the only packages that depend on styled-jsx, other than that I use styled-components), could that be related?
If the current behavior is a bug, please provide the steps to reproduce and possibly a minimal demo or testcase in the form of a Next.js app, CodeSandbox URL or similar
I'll try to reproduce, might take me some time though.
What is the expected behavior?
The build should succeed.
Environment (include versions)

OS: Docker node:12.16.3-alpine
Browser: n/a
styled-jsx (version): >= 3.1.3

Did this work in previous versions?
Yes, in 3.1.2

Ok since next-nprogress is deprecated, and even archived on github, and also I rather use styled-components in my client app and not styled-jsx, I inlined the few lines of the next-nprogress code and got rid of the explicit dependency on styled-jsx entirely.
Here's the migrated code if someone cares:
import React, { FunctionComponent, useEffect, useCallback } from 'react'
import NProgressLib, { NProgressOptions } from 'nprogress'
import Router from 'next/router'
import { createGlobalStyle, keyframes } from 'styled-components'

interface NProgressProps {
    color?: string
    showAfterMs?: number
    spinner?: boolean
    options?: Partial<NProgressOptions>
}

let timer: number | undefined

export const NProgress: FunctionComponent<NProgressProps> = ({ color = '#2299DD', showAfterMs = 300, spinner = true, options }) => {
    const routeChangeStart = useCallback(() => {
        clearTimeout(timer)
        timer = setTimeout(NProgressLib.start, showAfterMs)
    }, [showAfterMs])

    const routeChangeEnd = useCallback(() => {
        clearTimeout(timer)
        NProgressLib.done()
    }, [])

    useEffect(() => {
        if (options) {
            NProgressLib.configure(options)
        }

        Router.events.on('routeChangeStart', routeChangeStart)
        Router.events.on('routeChangeComplete', routeChangeEnd)
        Router.events.on('routeChangeError', routeChangeEnd)

        return () => {
            clearTimeout(timer)
            Router.events.off('routeChangeStart', routeChangeStart)
            Router.events.off('routeChangeComplete', routeChangeEnd)
            Router.events.off('routeChangeError', routeChangeEnd)
        }
    }, [options, routeChangeEnd, routeChangeStart])

    return <NProgressStyle color={color} spinner={spinner} />
}

const rotationKeyframes = keyframes`
    0% {
        transform: rotate(0deg);
    }
    100% {
        transform: rotate(360deg);
    }
`

const NProgressStyle = createGlobalStyle<Required<Pick<NProgressProps, 'color' | 'spinner'>>>`
    #nprogress {
        pointer-events: none;
    }
    #nprogress .bar {
        background: ${(p) => p.color};
        position: fixed;
        z-index: 1031;
        top: 0;
        left: 0;
        width: 100%;
        height: 2px;
    }
    #nprogress .peg {
        display: block;
        position: absolute;
        right: 0px;
        width: 100px;
        height: 100%;
        box-shadow: 0 0 10px ${(p) => p.color}, 0 0 5px ${(p) => p.color};
        opacity: 1;
        transform: rotate(3deg) translate(0px, -4px);
    }
    #nprogress .spinner {
        display: ${(p) => (p.spinner ? 'block' : 'none')};
        position: fixed;
        z-index: 1031;
        top: 15px;
        right: 15px;
    }
    #nprogress .spinner-icon {
        width: 18px;
        height: 18px;
        box-sizing: border-box;
        border: solid 2px transparent;
        border-top-color: ${(p) => p.color};
        border-left-color: ${(p) => p.color};
        border-radius: 50%;
        animation: ${rotationKeyframes} 400ms linear infinite;
    }
    .nprogress-custom-parent {
        overflow: hidden;
        position: relative;
    }
    .nprogress-custom-parent #nprogress .spinner,
    .nprogress-custom-parent #nprogress .bar {
        position: absolute;
    }
`

I guess the compile error stemmed from next-nprogress using this syntax:
<style jsx global>{`

https://github.com/sergiodxa/next-nprogress/blob/master/src/component.js#L48
This syntax was deprecated in styled-jsx 3.1.3:
styled-jsx converts style blocks to a custom JSXStyle component which takes css strings via a css prop. This prop conflicts with other libraries like styled-components. Since for us is just an implementation detail we are going to rename it to children and make theJSXStylecomponent work more like a regularstyle` element.

https://github.com/zeit/styled-jsx/releases/tag/v3.1.3
I have to say, it is very weird to make such a breaking change in a bugfix release.


Bump metallb version

Using the latest that ships the new name for IPPool.
Signed-off-by: Federico Paolinelli<EMAIL_ADDRESS>

/lgtm


Feature | Add a floating back to top button

Add a floating back to top button so that the user doesn't have to scroll through the whole page and get on the top of the page just by clicking on the button.

can i work on this issue under JWoC


[Appliance CLI Extension] Add index.json for version 0.1.40 to be available publicly

This checklist is used to make sure that common guidelines for a pull request are followed.

For new extensions:

[ ] My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

Appliance CLI Extension


Refine bash completion of machines in start and stop commands

Bash completion for docker-machine start and docker-machine stop always completed all machines, regardless of their state.
This PR refines this so that docker-machine start only completes stopped machines and docker-machine stop only completes running machines.
A new function _docker_machine_machines was factored out that lists machines and accepts additional parameters that get passed on to docker-machine. It can also be invoked directly, e.g.
_docker_machine_machines --filter state=Running
_docker_machine_machines --filter state=Running --filter driver=vmwarevsphere --format='{{.Name}}\t{{.State}}'

Such functions are widely used in Docker's bash completion.

Cool!
LGTM thanks @albers !


[Compute] 2019-12-01 API version

Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Contribution checklist:

[x] I have reviewed the documentation for the workflow.
[x] Validation tools were run on swagger spec(s) and have all been fixed in this PR.
[x] The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

[x] Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

[x] If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

/azp run automation - sdk

/azp run automation - sdk

Can one of the admins verify this patch?

/azp run automation - sdk

The below is expected since 'SshPublicKeyUpdateResource' is used only in a request body for update.  It is not used in a response body, so it does not need 'name', 'id', and 'type' properties.
Potential new ARM errors
R2020 - RequiredPropertiesMissingInResourceModel
Model definition 'SshPublicKeyUpdateResource' must have the properties 'name', 'id' and 'type' in its hierarchy and these properties must be marked as readonly.
at specification/compute/resource-manager/Microsoft.Compute/stable/2019-12-01/compute.json:6645

/azp run automation - sdk

/azp run automation - sdk

@hyonholee just verifying that none of the new operations are long-running (the examples indicate they are not)
Also

The .Net SDK break is from a previous PR, and is in tests
The indicated breaking change in Python is expected - the request types indicated do not have these properties.


Expose a .calls with normalizeRequest

The example showcases a fetch call made using return fetch('https://google.com');, which then gets tested using
expect(fetch.mock.calls[0][0]).toEqual('https://google.com');

This seems rather brittle to me, since the test would fail when one does return fetch(new Request('https://google.com')) instead.
I propose adding a .calls (or some other name like .normalizedCalls or .requests) property that returns normalized requests instead of [string | Request | undefined, RequestInit | undefined][]

If you're using expect from jest, you can use .toHaveBeenLastCalledWith() (https://jestjs.io/docs/27.x/expect#tohavebeenlastcalledwitharg1-arg2-) along with .toHaveBeenCalledTimes() (https://jestjs.io/docs/27.x/expect#tohavebeencalledtimesnumber).  Maybe there's a similar matcher built into chai/vitest, I'm not sure as I use expect.

I guess I haven't clearly explained my issue.
fetch.mock.calls[0] has the type string | Request | undefined.
If I now want to check if a call was a post request, there is no straightforward way of doing so. I'd have to do the whole normalizing myself.
It'd be lovely if this library provided a utility like that.
e.g.
const postReqs = fetchMock.requests().filter(v => v.method === "POST");

// where requests does this
function requests(fetchMock: FetchMock) {
    return fetchMock.mock.calls.map((call) =>
      normalizeRequest(call[0], call[1])
    );
  }

This isn't something I have time to work on myself, but I'll review a PR if you're willing to put one together.

@IanVS Done :)


Revert accidental BC

Problematic behavior

90caad6, which manually updated dependencies, accidentally bumped the Next.js peer dependency from next@10 to next@11. The culprit was npm-check-updates without the --dep option. This has since been fixed.
The coming update will address this issue along with #295 by extending NTARH compat all the way back to next@9.

Reproduction steps

Expected behavior

Additional context

:tada: This issue has been resolved in version 2.1.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Aaron's PR

Checklist
Required changes:

[x] Center the description (Line 17 in HTML file) using a single change in CSS
[x] Fix JS so that when the search is executed, the search engine is not present in query
[x] Add Google Drive, Google Slides and Google Sheets as a provider

Optional changes:

[x] Add other search providers (GitHub, Spotify, etc)
[ ] Additional CSS styling (as you like)

Hosted Link:
https://aaronrockmenezes.github.io/multisearch/

Added hosted link


dep can't upgrade from client-go release-4.0 to release-5.0

What version of dep are you using (dep version)?
v0.3.1-122-g98f625e
What dep command did you run?
The scenario is this.

check out https://github.com/davecheney/dep-k8s-example
dep ensure && go build
Edit Gopkg.toml and apply this patch to upgrade from the release-4.0 branch to release-5.0. (The revision for apimachinery is taken from https://github.com/kubernetes/client-go/blob/release-5.0/Godeps/Godeps.json)

lucky(~/src/github.com/davecheney/dep-k8s-example) % git diff
diff --git a/Gopkg.toml b/Gopkg.toml
index 58ae22c..1b91f62 100644
--- a/Gopkg.toml
+++ b/Gopkg.toml
@@ -8,11 +8,11 @@

[[constraint]]
 name="k8s.io/client-go"
-  branch="release-4.0"
+  branch="release-5.0"

[[override]]
 name="k8s.io/apimachinery"
-  revision="917740426ad66ff818da4809990480bcc0786a77"
+  revision="9d38e20d609d27e00d4ec18f7b9db67105a2bde0"

[[override]]
 name="github.com/ugorji/go"

Run dep ensure to fetch the new dependencies.

What did you expect to see?
I expected dep ensure to complete successfully.
What did you see instead?
lucky(~/src/github.com/davecheney/dep-k8s-example) % dep ensure
ensure Solve(): No versions of k8s.io/client-go met constraints:
        release-4.0: Could not introduce<EMAIL_ADDRESS>as it is not allowed by constraint release-5.0 from project github.com/davecheney/dep-k8s-example.
        v4.0.0: Could not introduce<EMAIL_ADDRESS>as it is not allowed by constraint release-5.0 from project github.com/davecheney/dep-k8s-example.
        v3.0.0: Could not introduce<EMAIL_ADDRESS>as it is not allowed by constraint release-5.0 from project github.com/davecheney/dep-k8s-example.
        v2.0.0: Could not introduce<EMAIL_ADDRESS>as it is not allowed by constraint release-5.0 from project github.com/davecheney/dep-k8s-example.
        v1.5.1: Could not introduce<EMAIL_ADDRESS>as it is not allowed by constraint release-5.0 from project github.com/davecheney/dep-k8s-example.
        v1.5.0: Could not introduce<EMAIL_ADDRESS>as it is not allowed by constraint release-5.0 from project github.com/davecheney/dep-k8s-example.
        v1.4.0: Could not introduce<EMAIL_ADDRESS>as it is not allowed by constraint release-5.0 from project github.com/davecheney/dep-k8s-example.
        v4.0.0-beta.0: Could not introduce<EMAIL_ADDRESS>as it is not allowed by constraint release-5.0 from project github.com/davecheney/dep-k8s-example.
        v3.0.0-beta.0: Could not introduce<EMAIL_ADDRESS>as it is not allowed by constraint release-5.0 from project github.com/davecheney/dep-k8s-example.
        v2.0.0-alpha.1: Could not introduce<EMAIL_ADDRESS>as it is not allowed by constraint release-5.0 from project github.com/davecheney/dep-k8s-example.
        v2.0.0-alpha.0: Could not introduce<EMAIL_ADDRESS>as it is not allowed by constraint release-5.0 from project github.com/davecheney/dep-k8s-example.
        master: Could not introduce k8s.io/client-go@master, as it is not allowed by constraint release-5.0 from project github.com/davecheney/dep-k8s-example.
        release-1.4: Could not introduce<EMAIL_ADDRESS>as it is not allowed by constraint release-5.0 from project github.com/davecheney/dep-k8s-example.
        release-1.5: Could not introduce<EMAIL_ADDRESS>as it is not allowed by constraint release-5.0 from project github.com/davecheney/dep-k8s-example.
        release-2.0: Could not introduce<EMAIL_ADDRESS>as it is not allowed by constraint release-5.0 from project github.com/davecheney/dep-k8s-example.
        release-3.0: Could not introduce<EMAIL_ADDRESS>as it is not allowed by constraint release-5.0 from project github.com/davecheney/dep-k8s-example.
        release-5.0: Could not introduce<EMAIL_ADDRESS>as its subpackage k8s.io/client-go/pkg/api/v1 is missing. (Package is required by (root).)
        revert-14-1.5: Could not introduce<EMAIL_ADDRESS>as it is not allowed by constraint release-5.0 from project github.com/davecheney/dep-k8s-example.

dep cannot update to the release-5.0 branch because it would fail to compile. Superficially that is helpful, but unless dep upgrades the client-go dependency, I cannot fix the build breakage from the major api bump.
How can I use dep to fetch release-5.0 so I can fix the build breakage?

man, you just keep on bumping into these fundamental questions 😜 gotta love k8s, drawing out all the warts.
the simple answer for what you can do right now would be that you add k8s.io/client-go/pkg/api/v1 to the ignored list in Gopkg.toml. i think that'll let you make it through - it just won't care that that package doesn't exist. you can then remove that ignored directive once you've eliminated all instances of that import. please do let me know if that doesn't work.
this is a tip of a bigger iceberg, though. these sort of additional checks that dep does give it the characteristics of a strongly mean-reverting system - one where wild fluctuations tend to be dampened out, back towards some (working) midpoint. this tends to be good the overwhelming majority of the time, but can put the user in an awkward position when they need to make large transitions, as you do here.
the biggest original problem in this class this was the "how do i add a new dependency?" problem chicken-or-egg problem, now addressed by dep ensure -add. but your issue here is a good example of that same sort of "how do i get from here to there?" gap. and, if we end up adding type analysis, that gap will become much more pronounced.
my plan has been that, if we ever get to doing type analysis, it would absolutely 💯 need to come with some sort of -version-checks-only flag, which can be included in order to tell the solver to disable anything other than the essential version satisfiability checks. i don't think it's strictly necessary now, for cases like this, as recourse exists with ignored. but eventually, such a flag would let users live in these "in between" places, both for this case, and the likely much more common case of creating some temporary type mismatches while making slightly larger changes.

Does this imply that the versions determined by deps depend not just on Gopkg.toml, but on application code as well?

yes.
On October 14, 2017 4:04:16 PM EDT, Justin Santa Barbara<EMAIL_ADDRESS>wrote:

Does this imply that the versions determined by deps depend not just on
Gopkg.toml, but on application code as well?
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/golang/dep/issues/1265#issuecomment-336663291

Can you explain what we're trying to do here?  I guess that for dependencies that don't define their dependencies we have to do this to infer their dependencies somehow.  But for a user application using dep, we should make them declare their direct dependencies.
I'd suggest we should also warn about dependencies that are not good go-citizens, and do not include a Gopkg.toml.
Taking that to extremes (if we're trying to "fill in the gaps" until all libraries include a Gopkg.toml): disable all additional analysis entirely by default (including for transitive dependencies); we expect all libraries to declare a Gopkg.toml file.  Then we have a flag --legacy which must be passed to enable dependency inference, and it suggests filing a github issue against the legacy library.  Eventually --legacy inference would be removed from dep, likely moved to a plugin.

As an aside I had similar issues recently with apimachinery and it turns out that having a copy of it in your GOPATH could also cause issues. Albeit in my case, it might have been a poorly or partially installed version. Once I cleared it out it worked.
I think yours is a separate problem but it just might change things with a clean GOPATH.

@justinsb even if we were to make the changes you're proposing, it would have little practical bearing on this issue - but making such changes is not on the table:

Can you explain what we're trying to do here? I guess that for dependencies that don't define their dependencies we have to do this to infer their dependencies somehow.

they do define their dependencies - that's what import statements in the source code are. asking the user to duplicate that information into Gopkg.toml is tedious and wasteful, so we don't do it. the package management committee discussed this over a year ago now.
consider just how much information we would have to record in e.g. k8s' Gopkg.toml if we wanted to make it possible for a user to import a single package within k8s, and get only the direct external dependencies of that package, and of all the other internal k8s packages transitively imported by that package. (we'd have to duplicate both the package structure and the import statements in their entirety)

But for a user application using dep, we should make them declare their direct dependencies.

we literally can't make anyone do anything. there is no central point of control, of publishing, that could be used to enforce such a rule - and intentionally excluding segments of the ecosystem is a non-starter.

I'd suggest we should also warn about dependencies that are not good go-citizens, and do not include a Gopkg.toml.

we're a long way off from this, if we ever do it. and we're unlikely to, as if your library relies solely on stdlib, there's no reason at all to use dep.
@ianlewis if accurate, this is very concerning - the only time that GOPATH should matter in any way to dep is if you dep init -gopath. outside of that, i can't even conceive of how cleaning out GOPATH/src could change dep's behavior.

@sdboyer Yah, I though so too. Drove me bonkers trying to figure it out. I got errors like this
$ mkdir -p $GOPATH/src/test
$ cd $GOPATH/src/test
$ curl -o main.go https://raw.githubusercontent.com/kubernetes/client-go/release-4.0/examples/out-of-cluster-client-configuration/main.go
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  2535  100  2535    0     0  14419      0 --:--:-- --:--:-- --:--:-- 14485

$ dep init
No versions of k8s.io/apimachinery met constraints:
	master: unable to update checked out version: : command failed: [git checkout 3b05bbfa0a45413bfa184edbf9af617e277962fb]: exit status 1
	release-1.6: unable to update checked out version: : command failed: [git checkout 35be0db31bd6e5635ef6366708dc2b137392f6a2]: exit status 1
	release-1.7: unable to update checked out version: : command failed: [git checkout 8ab5f3d8a330c2e9baaf84e39042db8d49034ae2]: exit status 1
	release-1.8: unable to update checked out version: : command failed: [git checkout 9d38e20d609d27e00d4ec18f7b9db67105a2bde0]: exit status 1

@ianlewis oooh ooh cache corruption cache corruption. could you try compiling dep from #1279 and seeing if that magically fixes it?
could you tar up $GOPATH/pkg/dep/sources/https---github.com-kubernetes-apimachinery and make it available so i can see the state of the repo? or, just running git status in that dir and seeing if anything seems odd/there's a dirty tree or untracked files, etc. do that, then #1279 😄
this is getting off-topic, though - let's please carry that discussion on in slack, or another issue. @davecheney, did the ignored approach work for you, at least for now?

@sdboyer I've been trying the ignored approach too (for https://github.com/heptio/ark). I initially did what you suggested, and reran dep ensure -update k8s.io/client-go k8s.io/apimachinery k8s.io/kubernetes, which then listed another package that it had trouble with, so I kept adding to the ignored list until dep would run without complaining. But now I can't actually get it to pull in dependencies that are new to client-go v5.0.0. If I comment out the ignored list, it continues to complain about packages via transitive dependencies, e.g.:
v5.0.0: "k8s.io/client-go/discovery" transitively (through 1 packages) imports "k8s.io/client-go/pkg/api/v1", which contains malformed code: no package exists at "k8s.io/client-go/pkg/api/v1"

I don't have any references in the Ark repo to k8s.io/client-go/pkg/api* anywhere. Help?

@ncdc yeah, this story still needs improving 😢 it's not a common case, but it's definitely exacerbated by the complexity of k8s.
to be clear, though:

which then listed another package that it had trouble with,

these are packages from release-4.0 that no longer exist in release-5.0, right? those are the only ones i was imagining should go into ignored. if so, this:

But now I can't actually get it to pull in dependencies that are new to client-go v5.0.0.

confuses me...oh, wait! that'd just be because you don't actually import those yet. right.
OK, here's my suggestion for a virtuous loop that probably still won't be pleasant, but should at least get you through this with less hair-pulling:

identify a package that has disappeared in the new version, and add it to the ignored list
if that package has a corresponding package(s) in the new version, add those to the required list, including a comment about the old one it's replacing
repeat 1-2 until solving goes through
work through the list of each ignored package in your code, searching for instances of the import statement pointing at it and refactoring the corresponding file(s) to point to the new package(s), which you can handily reference b/c of the comments you made
remove the entry from ignored, and corresponding required entries
repeat 4-5 until you're totally converted

so, i'm imagining your WIP Gopkg.toml looks something like this:
ignored = [
  "something/we/actually/ignore/all/the/time"
# START REFACTORING LIST, ALL THESE ARE GONE WHEN WE'RE DONE
  "importpath/to/old/pkg1"
  "importpath/to/old/pkg2"
]

required = [
  "importpath/to/new/pkg1" # from "importpath/to/old/pkg1"
  "importpath/to/new/pkg2a" # from "importpath/to/old/pkg2"
  "importpath/to/new/pkg2b" # from "importpath/to/old/pkg2"
]

these are packages from release-4.0 that no longer exist in release-5.0, right? those are the only ones i was imagining should go into ignored

Actually, no. Some of the packages listed are no longer in 5.0, but others are. Weird...
I'll give your suggestion a try and see how it goes. Will report back later. Thanks!

@sdboyer something was messed up with my cache. Once I removed ~/go/pkg/dep/sources/https---github.com-kubernetes-client--go, I was able to get past my issues and have it download the new transitive dependencies. I'm still fixing compilation issues, but I'm optimistic I got past my main problem.

@ncdc uuuugh. i would love to figure out a way to better wrap when these problems occur, rather than waiting for them to blow up. hopefully #1279 will make the incidence of these cache issues much, much less frequent.
i want to merge that soon so that we can have people test it in the wild for a while before release. it's an adaptive failure mechanism, so the most we can really test it for is that it doesn't have unintended consequences on the happy path, or misbehaviors on certain known failure paths.

@sdboyer in my case, I'm pretty sure the cached copy of client-go wasn't dirty. I'm not 100% positive, but I know I didn't cd in there and muck with it. It had the v5.0.0 tag checked out, but it most definitely did not match a manual clone & checkout of that tag. Very odd.

@ncdc any chance that upstream folks had force-pushed that tag at some point?

@sdboyer can't say for sure, but we don't think so.

@sdboyer Sounds good. Will follow up.

i'm gonna close this one out, as we at least have an adequate workaround (even if not ideal)


Fix: fs_lvm live migration

Description
Can't live migrate VM if it have connected storage disks from the shared datastore eg CD-ROMS (not fs_lvm)
To Reproduce

Connect shared cd-rom image to the lvm backed vm
try to live-migrate it.

Actual behavior
...
[Z0][VMM][I]: + for disk in $(ls /var/lib/one//datastores/164/6237/disk.*)
[Z0][VMM][I]: + '[' -L /var/lib/one//datastores/164/6237/disk.3 ']'
[Z0][VMM][I]: ++ readlink /var/lib/one//datastores/164/6237/disk.3
[Z0][VMM][I]: + DEVICE=/var/lib/one/datastores/100/805cba38656802399588f09cd8958010
[Z0][VMM][I]: + sudo lvchange -ay /var/lib/one/datastores/100/805cba38656802399588f09cd8958010
[Z0][VMM][I]: "/var/lib/one/datastores/100/805cba38656802399588f09cd8958010": Invalid path for Logical Volume.

Expected behavior
VM successfully migrated
Details

Affected Component: Storage
Hypervisor: KVM
Version: 5.6.0

Progress Status

[ ] Branch created
[ ] Code committed to development branch
[ ] Testing - QA
[ ] Documentation
[ ] Release notes - resolved issues, compatibility, known issues
[ ] Code committed to upstream release/hotfix branches
[ ] Documentation committed to upstream release/hotfix branches

Can be merged into master / one-5.6


UPSERT [new feature]

UPSERT is a very useful feature for developers please try to add this feature in workers-qb package.
https://www.sqlite.org/lang_UPSERT.html

I will probably do this in the next minor release 😄

Hey @rupamking1 i've just created a new release (v1.1.0) that adds Upsert support, read the docs here


authenticate resolve after transition sucessfull

I'm using the session's authenticate method on my login controller to perform authentication.
That methods returns a promise, and I'm using it to set a isLoading property on my controller.
This way I can conditionally show spinners, disable inputs, etc.
However, the route I'm transitioning to after authentication sucessful (through the routeAfterAuthentication configuration property), has a model hook that takes some time to resolve.
As a result, I'm seeing some UI flickering, because the authenticate promise resolves before the model hook of the routeAfterAuthentication route.
I was trying to avoid the use of needs in the target route and using afterModel to set the isLoading property back to false.
Ideally, the authenticate promise would only resolve when the transition to the target route successfully completed transition.
Is this possible?

No, that'd not possible as the session doesn't actually know anything about the transition that's happening - it only sees the authenticator that returns a promise that will resolve at some point in time at which the session is authenticated and returns resolves the promise it returns as well.

Right. Makes sense. Any ideas to achieve this?
I believe it should be a common scenario.

I ended up using the loading substate for the target route.
When authentication is successful I get a nice loading feedback.


Rewrite package configuration description and add iBuffer as default

@shombando

I should have probably created two PRs - one for iBuffer and other for small rewrite. If you like that way, I can separate them.

@systemhalted thanks for adding additional config to make life easier. Can you please rephrase your ibuffer section to be more informative? We want the description to be about ibuffer itself and why it may be more useful than the default buffer manager but we don't want to bash choices made by the emacs maintainers. This will educate the user and let them choose if that's what they want to do. The goal is provide options not indoctrinate but I do admire your passion!
Also, it may be better to do separate pull requests as you're making these changes. If I could request you be mindful for copying and pasting sections since that messes with the git history (diff should be able to recognize things just moved but if often can't and then git blame breaks over time). Basically if we don't intend to modify a section it shouldn't show up in a diff.
By the way, I'm trying to do things as legit as possible so if you'd rather just contribute config and not mess with idiomatic git usage, that's totally fine too... I'll just cherry pick, but if you want to practice best practices I can continue providing feedback like above. Please let me know what you prefer and thanks for the interest.


Adding translations - input fields

Prerequisites

[x] I've searched for existing issues

Describe the bug
When a user adds content in an input field meant for a translation (ex. french translation for a specific input field), and save, please by default have the accordion open upon page reload. I tried not filling out the English and only filling in the French, and saved - and it looks weird because it saves successfully, but the accordions are closed so it looks like there's no content there.
Expected behavior
Have the accordion open by default if there's content in there OR have a badge that says "content added".

@cherylhjli it actually does have a "content added" badge but maybe the placement isn't as expected?

ahhh I see. Yes if this could be open by default that'd be great!


Create simple data science projects using tools provided for the community

Can Jupyter notebooks with Matplotlib and other packages that run with python be accessed without azure service?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 79668399-b304-e485-f724-04d8ead4b2ed
Version Independent ID: d3b473dc-7804-8e1d-eb41-affd3bbc0123
Content: Data Science and Analytical Applications workload - Visual Studio
Content Source: docs/python/data-science-and-analytical-applications-workload.md
Product: visual-studio-windows
Technology: vs-python
GitHub Login: @JoshuaPartlow
Microsoft Alias: joshuapa

@jparra0419 -- thank you for your question. Here are a few options you might consider:

https://social.msdn.microsoft.com/Forums/vstudio
https://www.stackoverflow.com
https://www.reddit.com/r/VisualStudio/

W A. Rohm,
It is too bad you didn't answer my question.
Here goes again:"  " After a Web Application is completed with VisualStudio is it
possible to publish the application (app.py) in GitHub as a
Website by following the  GitHub’s procedure?
The procedure consists of a few steps that GitHub provides to anybody who registers with this company. This allows a person to publish the WebSite public (free) or private (pay).
Thank you for your help,
Jorge Parra
On Monday, May 11, 2020, 06:26:43 PM EDT, William Anton Rohm<EMAIL_ADDRESS>wrote:

@jparra0419 -- thank you for your question. Here are a few options you might consider:

https://social.msdn.microsoft.com/Forums/vstudio
https://www.stackoverflow.com
https://www.reddit.com/r/VisualStudio/

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

@jparra0419 -- thank you for clarifying.
@JoshuaPartlow -- please look into this potential documentation issue.

Hi @jparra0419 - For your first question around Jupyter Notebooks, there are a number of services for hosting them, with Azure being one option. As far as what can be done with GitHub, I'd have to defer to their support site for guidance.

Closing given time open. If this is still an issue, please feel free to reopen.


PH01 Humidifier unavailable

Dyson: PH01 (Pure Humidify+Cool)
HA: 2024.1
ha-dyson: 1.3.6
I was using shenxn/ha-dyson before, but completely deleted it and started using libdyson-wg/ha-dyson yesterday (thanks for the continues support!). The fan now works brilliant, but I can't get the humidifier to work. Says it's unavailable. Anything I can do in order to fix this?

Same issue after upgrading to ha 2024.1

https://github.com/home-assistant/core/pull/107026
https://github.com/home-assistant/core/milestone/640?closed=1

https://developers.home-assistant.io/blog/2023/12/28/support-feature-magic-numbers-deprecation/

Ahh, I've been working on a more complete update since (until now) the deprecated features were non-breaking for this integration. But I'll get out a mini-release tonight to get humidifiers working again.

This is mitigated by HA 2024.1.1 which was just released.

Nice. That gives me some time to finish the comprehensive cleanup. Thanks for the info @mundschenk-at

I am not sure that this is related, but I just updated to HA 2024.1.1 and im unable to add the integration at all.
Device: TP07
Error:

This integration does not support configuration via the UI. If you followed this link from the Home Assistant website, make sure you run the latest version of Home Assistant.

This issue is also impacting my Purifier Hot+Cool Formaldehyde (climate and fan entities) since 2024.1 it's been showing as no longer being provided by the dyson_local integration.

This should be resolved now on the latest version.

@codyc1515 you're beating me everywhere these days! Everyone having issues, please feel free to follow up if 1.3.7 doesn't resolve your problems.


The TeX input Jax should add an application/x-tex annotation

This change was done in MediaWiki, but it does not seem to have been integrated upstream (I could not find an issue): https://github.com/mathjax/MathJax/blob/develop/unpacked/jax/input/TeX/jax.js#L2090
This is necessary to allow copy & paste by other means than the MathJax context menu (e.g. with https://addons.mozilla.org/en-US/firefox/addon/mathml-copy/ or MathPlayer context).
If this is to be an option, it should not be an author config but a menu option, so that any user can decide whether or not he wants the TeX source to be exposed. In particular, such a menu option could be easily controlled by https://addons.mozilla.org/en-US/firefox/addon/mathjax-native-mathml/, without having to redefine MathJax's code.

==> In Testsuite
UI/issue814.html


CMS element for app does not take full width in sw-cms-block__content

PHP Version
8.1
Shopware Version
<IP_ADDRESS>
Expected behaviour
When you add a CMS element through a Shopware app the element/iFrame must take the entire width of the available space in the Shopping Experience editor.

Actual behaviour
The element/Iframe only takes 50% of the width.

How to reproduce

include a CMS element/block from a Shopware App (these elements are loaded through an iFrame)
validate visualisation in the Shopware admin

PR: https://github.com/shopware/platform/pull/2931

Issue can be close. Meanwhile the PR has been merged.

PR has been merged


SemanticLogger v4.3.0 Conflict with RSpec v3.7.0

Environment

Ruby Version: 2.4.3p205
Semantic Logger Version: 4.3.0
RSpec Version: 3.7.0

Expected Behavior
SemanticLogger should not cause Forwardable warnings when this code is run:
require 'rspec'
require 'semantic_logger'

class Foo
  include SemanticLogger::Loggable

  def initialize
    logger.info("Hi!")
  end

  def query
    logger.info("query!")
  end
end

RSpec.describe Foo do
  let(:foo) { Foo.new }

  context "#query" do
    it "queries things" do
      expect(foo).to receive(:query)
      foo.query
    end
  end
end

RSpec::Core::Runner::run([])

Actual Behavior
Forwardable warnings about the logger function being defined more than once are shown.
$ irb
irb(main):001:0> require 'rspec'
=> true
irb(main):002:0> require 'semantic_logger'
=> true
irb(main):003:0>
irb(main):004:0* class Foo
irb(main):005:1>   include SemanticLogger::Loggable
irb(main):006:1>
irb(main):007:1*   def initialize
irb(main):008:2>     logger.info("Hi!")
irb(main):009:2>   end
irb(main):010:1>
irb(main):011:1*   def query
irb(main):012:2>     logger.info("query!")
irb(main):013:2>   end
irb(main):014:1> end
=> :query
irb(main):015:0>
irb(main):016:0* RSpec.describe Foo do
irb(main):017:1*   let(:foo) { Foo.new }
irb(main):018:1>
irb(main):019:1*   context "#query" do
irb(main):020:2*     it "queries things" do
irb(main):021:3*       expect(foo).to receive(:query)
irb(main):022:3>       foo.query
irb(main):023:3>     end
irb(main):024:2>   end
irb(main):025:1> end
=> RSpec::ExampleGroups::Foo
irb(main):026:0>
irb(main):027:0* RSpec::Core::Runner::run([])

Randomized with seed 15777
/usr/local/stow/ruby-2.4.3/lib/ruby/2.4.0/forwardable.rb:220: warning: method redefined; discarding old logger
.

Top 1 slowest examples (0.0307 seconds, 78.3% of total time):
  Foo#query queries things
    0.0307 seconds (irb):20

Finished in 0.03922 seconds (files took 0.74927 seconds to load)
1 example, 0 failures

Randomized with seed 15777

=> 0

Pull Request
None available at this time, it took me a fair bit of time to replicate the issue and I'm pretty confused by all of the magic that is in forwardable.rb -- not quite sure where the problem lies/how to go about fixing it.

Still a problem with 4.5.0 and RSpec 3.8.

Please re-open once you have a Pull Request available


Can you increase the space distance above the title

The distance between the top of the title and the text paragraph, and the distance between the text paragraph below is the same, can some adjustments be made?

It would be nice if this was the case

obsidian-california-coast-theme

I tried to take the paragraph spacing from this thread and used it, but it didn't work

Are you talking about reading mode or editing mode or both?

It's  reading mide.editing mode can be achieved by separating them with spaces

In that case you can use Contextual Typography plugin:
https://github.com/mgmeyers/obsidian-contextual-typography

① His plug-in is to narrow the distance between titles
②What I wanted to achieve was the spatial distance between paragraphs and headings, and his plugin didn't change that

You should read the documentation for Contextual Typography as it allows you to define any margins you want between element types

I'm very sorry, I can't find anything to adjust, which means I don't know how to do it. I would be very grateful if you could show me how to do it.

I encounter the same problem and I was unable to find the documentation for Contextual Typography. @kepano @zhl111 if you are free can you kindly point out how to I use that plug-in to define the margin please? Thank you!

Fixed in 7.0


tour: More info would be great for channels from tick.*

Context: https://tour.golang.org/concurrency/6
This is a good example of channels, but it would be great to simply add

Note that time.Tick() and time.After() create channels.

Thanks for the report. This was also raised as #1033. See my answer at https://github.com/golang/tour/issues/1033#issuecomment-688348130. I'm closing here too.


Add test framework

The point of this PR is to add a useful set of tests which can be expanded upon as new features arrive. The test framework is Jest.
Current goals:

Enable asserting the result of SteamUser.chatMessage() calls

Features thus far:

Executing in CI
Current tests are in src/classes/__tests__/ which is common Jest convention. It makes imports easy for what is being tested generally because you import ../classname.

Please only create a new branch from the development branch and create a pull request to the development branch.
Thank you.
https://github.com/idinium96/tf2autobot/blob/master/.github/contributing.md

Damn I thought I rebased on development.

@idinium96 I think the PR just defaulted to master. I swapped it.

I think I will not add this.

Hrm I didn't intend this to be ready. To keep track of progress would you prefer I make an issue that the branch will fulfill? At this point the code is supposed to be an example of where the starting point of testing is.

Yes rtfm. https://github.com/idinium96/tf2autobot/blob/master/.github/contributing.md#pull-requests
I'll make an issue called add testing that'll track my progress and then open the pr


⚠ ClamAV has degraded performance

In 9be5e08, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 472 ms

Resolved: ClamAV performance has improved in 0ae3692.


Login Clientbound Set Compression

Enables compression. If compression is enabled, all following packets are encoded in the compressed packet format. Negative or zero values will disable compression, meaning the packet format should remain in the uncompressed packet format. However, this packet is entirely optional, and if not sent, compression will also not be enabled (the notchian server does not send the packet when compression is disabled).

implemented in f3c2093


Docs - Quickstart: part 3 - Create HTTP Service

I am following the steps described:
-> There is no mention of transaction SICF needed to create a service / the screenshot displayed.

br
Jacques

Hi @nomssi,
thank you for the hint, its a good idea to add that!
Used your screenshot now and updated the documentation:
https://abap2ui5.github.io/docs/get_started/quickstart.html#_3-create-http-service
Feel also free to contribute directly to the docs, if you miss certain information. Everything is just WIP :)
Best regards.


Tidy up test dir a bit

Some suggested changes to tidy up tests a bit

moved all tests of things in hetnode2vec.py into the same file, and renamed that file test_hetnode2vec.py
made a dir tests/utils/ for utility fxn used in tests, and moved a fxn that was used a few times into there

Thanks Justin! It looks fine to merge it to develop.
I had fixed a bug in tests/test_hetnode2vec.py. But, there is a bug in get_alias_edge_xn2v in hetnode2vec.py
I try to fix it a soon as possible.


add optional function arg as condition to $if.

Closes #271

[x] implement
[x] unit test
[x] document

Tried to make it throw a type error if a user tried to capture value when they've passed in a boolean, like:
 const query = ctx.db
  .selectFrom('person')
  .$if(true, (qb, val) => qb.where('first_name', '=', val))

Unfortunately I ran into issues trying to  use conditionals with generics, so this PR is the best I could do; val would be an unknown type.

Thank you! 💪

Tried to make it throw a type error if a user tried to capture value when they've passed in a boolean, like:
 const query = ctx.db
  .selectFrom('person')
  .$if(true, (qb, val) => qb.where('first_name', '=', val))

Unfortunately I ran into issues trying to use conditionals with generics, so this PR is the best I could do; val would be an unknown type:

Most of the time, our consumers will pass a value or function that their "truthyness" can only be determined at runtime. Consumers should be discouraged from using $if with true or false known at compile-time, kinda pointless no?

Most of the time, our consumers will pass a value or function that their "truthyness" can only be determined at runtime. Consumers should be discouraged from using $if with true or false known at compile-time, kinda pointless no?

Agreed. Also, always passing the truthy value in all cases as suggested in https://github.com/koskimas/kysely/pull/272#discussion_r1063015157 made this a non-issue as well.

Didn't notice that yesterday, let's also add these changes to other builders where .$if exists.

@igalklebanov Done. Also updated conditional-selects.md recipe.

@igalklebanov @koskimas  Anything else needed for this to get merged?

@koskimas Would you like me to resolve conflicts here, or are we not too sure about this one?

I don't know what to do with the $if method. People are overusing it, causing horrible typescript performance. I'm thinking we should maybe remove it and add a selectIf method. Or add selectIf and make this one just return the output type unconditionally which would solve the typescript performance issues.

I don't know what to do with the $if method. People are overusing it, causing horrible typescript performance. I'm thinking we should maybe remove it and add a selectIf method. Or add selectIf and make this one just return the output type unconditionally which would solve the typescript performance issues.

I like the 2nd idea.
I'm leaning towards the utility prefix with .$ifSelect or .$selectIf, but selectIf is OK.
Maybe we should type-omit .select/.selectAll from .$if's callback's builder.
Alternatively, we could type-pick .select/.selectAll in .$if's builder, and not introduce a new method.

Yep, let's figure out an alternative for $if and close this.


small fix for incomplete-list.sh

https://github.com/pzs-ng/pzs-ng/blob/a8a5fa2396f3015290043d03d2dd12d75253bb52/sitebot/extra/incomplete-list.sh#L68
comp="`ls -1 /$glroot/$result/ | grep "$releaseComplete"`"

Thanks for your suggestion but in combination with the referenced issue, another solution was chosen.


Segfault

The script benchmarks/strong_scaling/CPU+DPU.py crashes on 2048 DPU.
The script 2048_only doesn't.
There's probably a memory leak. Check the C arrays.

Identical problem with the higgs benchmark

Probable cause: because the input array doesn't have padding, we're trying to copy data to DPUs that resides in inaccessible memory regions.
Either rewrite the input buffer with padding (let's avoid that), or change the logic of number of points per DPU to do some aliased transfer.


Softmax activations don't get converted to Softmax TFLite operator if ndim > 2

System information

OS Platform and Distribution (e.g., Linux Ubuntu 16.04): MacOS 10.15.1
TensorFlow installed from (source or binary): binary
TensorFlow version (or github SHA if from source): tf-nightly==2.1.0.dev20191203

Command used to run the converter or code if you’re using the Python API
import pathlib

inpt = tf.keras.layers.Input(shape=[256, 256, 3])
out = tf.keras.layers.Lambda(lambda x: tf.keras.activations.softmax(x))(inpt)
out = tf.keras.layers.Lambda(lambda x: tf.nn.softmax(x))(out)
model = tf.keras.Model(inpt, out)

converter = tf.lite.TFLiteConverter.from_keras_model(model)
tflite_model = converter.convert()
pathlib.Path('out.tflite').write_bytes(tflite_model)

Failure details

This graph shows the difference between the different softmax methods.  When using tf.keras.activations.softmax, there is code with a workaround for multiple dimensions.  It looks like this was written before the tensorflow op had multi-dimension support.

@ghop02 Can you please try experimental_new_converter and let us know whether the issue persists with most recent converter. I had tried the converter for several complex layers and the converter is working well. I have added experimental_new_converter to your code. Please check the gist here.
converter.experimental_new_converter = True
Thanks!

Hi @jvishnuvardhan , thanks for the response!

I still get a similar result.  If you look at the link above, the keras softmax is converting to:
  elif ndim > 2:
    e = math_ops.exp(x - math_ops.reduce_max(x, axis=axis, keepdims=True))
    s = math_ops.reduce_sum(e, axis=axis, keepdims=True)
    return e / s

I think removing that logic, and just always returning the tf.nn.softmax operation would work, since I believe that code was written before tensorflow had support for ndim > 2

Seems reasonable though I don't have the full history behind the Keras implementation. @fchollet any thoughts (or somebody else who can chime in)?

@anilsathyan7 if you're blocked, you should be able to make this change to sneak the softmax operator in:
- out = Activation("softmax")(in)
+ out = tf.keras.layers.Lambda(lambda x: tf.nn.softmax(x))(in)

I will also add that TF2.1 works with conversion but TF2.2 does not, when using this method


[Feature][Issue-2214] Team add number, can direct select.

What changes were proposed in this pull request
Issue Number: close #2214

Brief change log
[Feature][Issue-2214] Team add number, can direct select.
Verifying this change

Manually verified the change by testing locally.

Does this pull request potentially affect one of the following parts

Dependencies (does it add or upgrade a dependency): (yes / no)

Hi, @wangsizhu0504 .
The new interface candidateUsers is healthy.
The data queried from backend can't be rendered in FE, Could you help to check it ? Thank you in advance.
CC @1996fanrui @wangsizhu0504 @wolfboys

Thanks for the help from @1996fanrui @wangsizhu0504 offline.
I fixed the little case in https://github.com/apache/incubator-streampark/pull/2262/commits/c42061c83a38a4738fdcc001c6fef5db50252c7b
Could you @wolfboys help to review it ? thx

Thanks for the help from @1996fanrui @wangsizhu0504 offline. I fixed the little case in c42061c Could you @wolfboys help to review it ? thx

Thanks for your contribution, happy chinese new year👏, i'll review it later

The title Support to select user when binding member. SGTM.


monolog v2 support and drop php < 7.2

@abacaphiliac it's ready. I have to drop support for zf2 because it doesn't work correctly with php 7.3 and 7.4.

@abacaphiliac ping

@abacaphiliac can you take a look?

hi @snapshotpl,
first thing, let me say thank you for the dedication and care you have put into this effort. i sincerely apologize for the delay.
next, as it stands, there are quite a few breaking changes in this request. i think we are forced to target a 3.0 release, which is great because 3.0 has been roughly (very roughly) planned for quite some time now:
https://github.com/enlitepro/enlite-monolog/projects
i think the best course of action is as follows:

i would create a tag for changes that have been merged into master since the last tag
i would create a new protected branch from master for development of 3.0, with composer branch alias
you would redirect this pull request to the 3.0 branch
we would tackle the rest of the breaking changes slated for 3.0
i would release 3.0 (after we have some consumer feedback on a stable candidate, of course)

i was tinkering with the ZF2 integration tests last night as i saw your commit message about it not working with the newest version(s) of PHP. i think i was able to come up with a way for us to maintain ZF2 and ZF3 compatibility, which i've done in a separate branch here:
https://github.com/enlitepro/enlite-monolog/compare/master...abacaphiliac:monolog-2?expand=1
here's the build for that proposal:
https://travis-ci.org/abacaphiliac/enlite-monolog/builds/627060591
that potential submission itself can definitely be broken up into a few smaller chunks, e.g. switch to infection from humbug, add prefer-lowest ZF2/3 integration builds, upgrade of all dev/build dependencies (not just phpunit), stage reconfiguration, and finally merging a compatible upgrade to monolog 2.
are you interested in pairing up on an alternative plan to the one above? if so, i was thinking we might be able to knock out some of these upgrades in the 2.x series together, while also continuing the great efforts that you've done in this request (e.g. implementing new syntax, tightening up the public APIs, enforcing strictness, etc.) and turning it into a complete 3.0 release. what do you think?

Thanks for reply!
Since keep ZF2/3 compatibility make sense we already give possibility to smooth switch in v2. I would like to left it because it increase code complexity. I have more ideas to make this lib simple in v3 before final result.
About other things (humbug->infection, phpunit) - these are internal tools and aren't impact to end user, so imo we can change it once as it.
In summary:

release current master,
branch this changes to v3
make some other work to v3 branch (even add removed zf2 support),
release (we can also add zf2 support after v3 release if will be required),
:beers:

@snapshotpl great, i'm glad we can work together on this. i'll throw a couple of small build PRs your way and i think together we'll be able to get your monolog v2 support into this project's 2.x.


Slack alerts error

Hi, I get an error when the heuristic alerts to slack, which makes pessimism_alerts_generated_total metric doesn't work.

Found that, the response from slack is just a plain text "ok" or some error message like "channel not found", not a struct as below.
https://github.com/base-org/pessimism/blob/14481ced518b71995bac5b617f971ea9aaee367c/internal/client/slack.go#L77-L80
Could you please fix this issue? Pessimism works well for me.😀

Thanks for filing an issue! Hmmm, looks we may be using different Slack APIs then. I can add support for different host types to ensure cross compatibility between workspace API types. I wouldn't be able to get to this until the week after next (vacation) so there'd be a bit of a wait. You're more than welcome to do the implementation yourself if you need this compatibility sooner.
Also I'm happy to hear that Pessimism is working well for you. Please lmk if there any other features/changes that you'd like seen 🙏🏻


Automatically assign an asset

Hi, I apologize for asking a basic question. Do you know how to assign an asset through code instead of manually linking it to the Asset field in the Unity Editor? I'm not very familiar with Unity, so I would greatly appreciate any guidance you can provide. Thank you!

@Vinci881027 in the same way as assigning any reference to any other component in Unity, really (getting familiar with Unity would help in general, I guess). Something like:
var gsrenderer = gameObjectWithGaussianRenderer.GetComponent<GaussianSplatRenderer>();
gsrenderer.m_Asset = yourAsset;

Thank you for your response. It is very helpful.


[containerapp] Fix YAML create with user-assigned identity

Fixes https://github.com/microsoft/azure-container-apps/issues/662
When YAML is converted to JSON, principalId and clientId in each user assigned identity are set to null and the user assigned identity is no longer just an empty object {}. This causes this error from the RP when it's used in a PUT request.
ERROR: (InvalidIdentityValues) Invalid value for the identities '/subscriptions/***/resourceGroups/***/providers/Microsoft.ManagedIdentity/userAssignedIdentities/id-platform'. The 'UserAssignedIdentities' property keys should only be empty json objects, null or the resource exisiting property.

Also fixes an exception that is thrown when an app has no ingress (response from GET container app call has ingress: null).

This checklist is used to make sure that common guidelines for a pull request are followed.

For new extensions:

[ ] My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

containerapp

Could you please add some test cases for this PR change?

@zhoxing-ms Tests added. Thanks!


Can Fga run on virtual machine ? ( Vmos ,F1 vm)

Preparation

[X] I read the Troubleshooting Guide
[X] My question isn't answered in any other issues (even the closed ones)

Your question
I want to use Virtual machine (Vmos , F1 VM ) to change the screen to 16:9
I Think use virtual machine can fix full screen problem of fga

You'll have to test it yourself. But which device do you have where you can't set FGO to full screen?

You'll have to test it yourself. But which device do you have where you can't set FGO to full screen?

nah im just curious if fga buster can run correctly on 16:9 screen or not
sorry for bad grammar

ok
F1 Vm can run FGA buster without problem
auto farm still ok


[Roadmap] Custom URLs (URL shortener)

Use the umami base to support generating and tracking URLs similar to Bitly and Yourls
Track metrics for URLs just like websites

This sounds really useful. I humbly request that included in this is a documented API for creating/resolving these shortened URLs.
Do you already have a design in mind?

@scoates The app currently makes API calls already, so this feature would just be an extension of that. There is no API documentation at the moment though. I will create an admin interface for creating links in the app, but of course you can just call the APIs directly as well.

Explaining my 👎 :
I'm not sure this is a great feature. Self-hosting URL shorteners is never good for ensuring content is preservable. Specifically, Link rot becomes a permanent issue if a user decides to leave umami for another service in the future, or just stop using analytics all together

Curious: was this closed because it's been implemented in an upcoming version, @mikecao?

I think it's better off as a separate app like @codyogden mentioned. Keep umami strictly for analytics and I will create another app for links.


Build failed due to unsufficient disk space: how do I clean up?

While tryind to build the docker image, my VM ran out of memory.
I am therefore left with ~20 GB of "intermediate" files which are not listed be docker image ls, how can I get rid of these?
Also, what is a good estimate of  how much memory the final build will occupy? I think this would be good information to put in the read me :)
Thanks for your work!
Andrea

Cleaning unused containers with docker system prune worked for me.


Validating parameters in UMAP class

Hi,
Sorry for nitpicking, but I think that the descriptions in _validate_parameters in UMAP class don't perfectly match the conditions tested sometimes. I'm not a native English speaker, so I may be wrong, but for instance:
https://github.com/lmcinnes/umap/blob/d286224a86dfe730c76f082c6f523b69b57bd0f8/umap/umap_.py#L1281-L1282
"min_dist must be less than or equal to spread" is more accurate as min_dist  can be equal to spread.
Likewise for min_dist and negative_sample_rate for instance (a "be" is also missing):
https://github.com/lmcinnes/umap/blob/d286224a86dfe730c76f082c6f523b69b57bd0f8/umap/umap_.py#L1283-L1284
https://github.com/lmcinnes/umap/blob/d286224a86dfe730c76f082c6f523b69b57bd0f8/umap/umap_.py#L1296-L1297
Not a big deal though :)

Nitpicks are good because error messages matter. Thanks for this.
On Tue, Aug 7, 2018 at 9:51 AM Johann Faouzi<EMAIL_ADDRESS>wrote:

Hi,
Sorry for nitpicking, but I think that the descriptions in
_validate_parameters in UMAP class don't perfectly match the conditions
tested sometimes. I'm not a native English speaker, so I may be wrong, but
for instance:
https://github.com/lmcinnes/umap/blob/d286224a86dfe730c76f082c6f523b69b57bd0f8/umap/umap_.py#L1281-L1282
"min_dist must be less than or equal to spread" is more accurate as
min_dist can be equal to spread.
Likewise for min_dist and negative_sample_rate for instance (a "be" is
also missing):
https://github.com/lmcinnes/umap/blob/d286224a86dfe730c76f082c6f523b69b57bd0f8/umap/umap_.py#L1283-L1284
https://github.com/lmcinnes/umap/blob/d286224a86dfe730c76f082c6f523b69b57bd0f8/umap/umap_.py#L1296-L1297
Not a big deal though :)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/lmcinnes/umap/issues/112, or mute the thread
https://github.com/notifications/unsubscribe-auth/ALaKBSFhAECc0tAYl5Os1dIE49B0fljeks5uOZtPgaJpZM4VyMye
.


graduate RetroactiveDefaultStorageClass feature to GA in 1.28

Graduate RetroactiveDefaultStorageClass featrue to GA in 1.28.
KEP: https://github.com/kubernetes/enhancements/issues/3333
KEP 1.28: https://github.com/kubernetes/enhancements/pull/4021
k/k: https://github.com/kubernetes/kubernetes/pull/118102

/sig storage

This PR will merge once k8s/k8s #118102 will merge, till that put this PR on hold.
/hold

@RomanBednar please update this doc
https://github.com/kubernetes/website/blob/dev-1.28/content/en/docs/reference/command-line-tools-reference/feature-gates.md#feature-gates-for-graduated-or-deprecated-features

@carlory Done.

please squash your commits into one

/hold cancel
@tengqm It' ready for review.

changes look good to me.
/lgtm

/assign @reylejano

Thanks, @RomanBednar
changes look good to me.
/lgtm

/lgtm

/hold
Needs tech review from SIG Storage (should be trivial to get)
/approve
Fine to unhold this once tech reviewed

/lgtm

/hold cancel
Review is done from sig-storage.


Source files for the web front end

Any idea where can we see the source for the front end (askbayou.com)? I can see that there is a flask server running. Ports 8080,8081 & 8084 are open. But 8084 seems to be accessible for API access only. Any documentation on how to call the same (http://localhost:8084/apisynthesis)?

Thanks a lot...


Have u successfully trained this model by using multiple GPUS?

When I tried to train the model by using nn.DataParallel in pytorch, Runtime error occurred:

RuntimeError: arguments are located on different GPUs

However , I can train BSN by simply parallel model on multiple GPUS.
Do u have any idea about it?

of course. In the code I released，the bm mask matrix is a FloatTensor，it's not a component of a module.if you want to train on multi GPUs you should register the bm mask to the torch.nn.Parameter to register it to the module so when you use the  nn.DataParallel, it will auto have a bm mask in every GPUs.
you should do like this:
self.bm_mask = nn.Parameter(bm_mask.view(self.temporal_dim, -1),requires_grad=False)

and when you give the parameter to the optimizer, you shuold filter the bm mask out.

Thanks very much about that！


Bug: 28 - Spacing needed between Remove button and Color name input in Mobile

Describe the Bug
In mobile, the Remove button and color name (primary or any other) input have no spacing in between
Steps to Reproduce
Steps to reproduce the behavior:

Go to https://color-conjure.netlify.app/ in mobile

Expected Behavior
Some spacing between Remove button and Color name input
Screenshots

Environment

OS: iOS
Browser: Chrome

Additional Context
N/A

Would you like to work on this @IdrisGit ?

Yeah sure, I will look into it

Let me know and I'll assign it to you

I have made the changes will raise the PR.


:book: docs(README): write comprehensive API walkthrough

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
805

Relevant Lines:
805

💛  - Coveralls


Add contrib for enron email dataset

Codecov Report

Merging #217 (37b140b) into dev (70f1350) will decrease coverage by 0.45%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev     #217      +/-   ##
==========================================
- Coverage   85.44%   84.99%   -0.46%
==========================================
  Files          47       47
  Lines        3127     3018     -109
  Branches      612      612
==========================================
- Hits         2672     2565     -107
+ Misses        340      338       -2
  Partials      115      115

Flag
Coverage Δ

unittests
84.99% <ø> (-0.46%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

meerkat/columns/spacy_column.py
49.01% <0.00%> (-2.84%)
:arrow_down:

meerkat/mixins/collate.py
75.00% <0.00%> (-2.78%)
:arrow_down:

meerkat/columns/list_column.py
57.40% <0.00%> (-1.53%)
:arrow_down:

meerkat/cells/abstract.py
76.47% <0.00%> (-1.31%)
:arrow_down:

meerkat/block/ref.py
75.86% <0.00%> (-0.81%)
:arrow_down:

meerkat/pipelines/entitydatapanel.py
70.83% <0.00%> (-0.79%)
:arrow_down:

meerkat/columns/lambda_column.py
79.43% <0.00%> (-0.75%)
:arrow_down:

meerkat/block/abstract.py
95.65% <0.00%> (-0.72%)
:arrow_down:

meerkat/mixins/materialize.py
91.66% <0.00%> (-0.65%)
:arrow_down:

meerkat/columns/cell_column.py
90.47% <0.00%> (-0.64%)
:arrow_down:

... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70f1350...37b140b. Read the comment docs.


Dictionaries don't respect insertion order

Operating system or device - Godot version:
Godot 3.0
Issue description:
Dictionaries don't respect insertion order, but 0a59c3c3a6a8c13a5c82d59d9587fca31f900604 claimed they should.
Steps to reproduce:
var dict = {"C": 1, "B": 2, "A": 3}
print(dict)
(A:3), (B:2), (C:1)
for k in dict:
	print(k)
C
A
B

Have you tried for in in range dict.size() ?

@Zireael07 You mean like:

That doesn't work as well.

I think dicts do respect order (when iterated directly), but not when calling dict.keys() or printing. Correct?

@bojidar-bg How do you iterate directly through a dictionary? I only know of accessing values by keys, or iterating by keys as in example above.

Wait, just tested it myself, doesn't work either... My bad.
var dict = {c = 2, a = 3, b = 1, rainbow = "correct", bowrain = "incorrect", d = 4}
for key in dict:
	print(key)

Produces (in a 3.0 build):
c
d
a
bowrain
rainbow
b

Which is not correct, at all.

i don't think dictionaries are meant to have an order

They have one in 3.0 though, so, this was closed 😃


Avatar group shape rounded not working

Current Behavior
Avatar group has this code in the page:
<script lang="ts">
   import { AvatarGroup } from 'stwui';
</script>

<AvatarGroup shape="rounded">
	<AvatarGroup.Avatar src={avatars[0]} />
	<AvatarGroup.Avatar src={avatars[1]} />
	<AvatarGroup.Avatar src={avatars[2]} />
	<AvatarGroup.Avatar src={avatars[3]} />
</AvatarGroup>

<AvatarGroup shape="square">
	<AvatarGroup.Avatar src={avatars[0]} />
	<AvatarGroup.Avatar src={avatars[1]} />
	<AvatarGroup.Avatar src={avatars[2]} />
	<AvatarGroup.Avatar src={avatars[3]} />
</AvatarGroup>

But both shapes appear squared:

Expected Behavior
The first avatar group should be shaped rounded:

Steps To Reproduce
Can be seen on the website: https://stwui.vercel.app/avatar-group
Link to Reproduction / Stackblitz
https://stwui.vercel.app/avatar-group
More Information
No response

Sorry - my eyes aren't what they used to be. No issue here, the rounded effect is working!


target="_blank" breaks the anchor links

If I add target="_blank"  it just links to the top of the page. It's probably something obvious, but wondering if anyone encountered the same issue.

I don't think React Router's <Link> supports target="_blank" since it's for push state routing (all props are passed through to <Link>. Just use a normal <a> if you want to open something in a new browser window.


deprecate descheduler custom flag of http-enabled

Follow up to https://github.com/kubernetes-sigs/descheduler/pull/1496#issuecomment-2291531874
cc: @jklaw90  and @ingvagabund

/lgtm


Fixup have_enqueued_job matcher on job retries

Previously we were checking only job counts, so if one job was
performed and one job was added - matcher failed. Check by unique
id (#hash) instead.
We cannot use job['job_id'] here, because job retains job_id on retry.
This works only with rails >= 6.1, because retry_on was introduced in 6.0 and apparently test queue adapter is broken for retries in 6.0: it adds executed job back with added exception_executions along with actual retried job. So dunno how to proceed here, please advise /shrug
Test CI run: https://github.com/ojab/rspec-rails/runs/5183906574?check_suite_focus=true
Also:
fixes #2668

hmm.. Actually looking @ CI, 6.0 is green, so probably failure is rails-6.0 <-> ruby-3.1 compat locally. And 5.2 fails with unknown keyword queue. so retry_on is there.
I'll check tomorrow and I guess would get green CI without any workarounds :sweat_smile:

It became more complicated due to rails-6.0 pushing jobs with the same #hash to the queue, but CI is green https://github.com/ojab/rspec-rails/runs/5198727860?check_suite_focus=true
Cleaned up, still two additional commits: first fixing rspec dependencies version in gemspec, second restricting rails-5.2 version for ruby-2.2 compat (filled https://github.com/rails/rails/pull/44435 about it).

We've merged build fixes for Rails and updated the minimum versions so this should be ok to be rebased without your ci changes

:bow: done

:crying_cat_face:

Green. @JonRowe any objections on merging this change?

The previous implementation was:

Save the number of currently enqueued jobs
Run the block passed to expect { ... } that can:

perform previously scheduled jobs and remove them from enqueued
enqueue more jobs

Remove the number of previously enqueued jobs from the list of currently enqueued jobs

Of course, since the matcher is scoped to one specific job class, it's quite an edge case.
This (previous, before the PR's) implementation was not considering jobs that were at the bottom of the list, and moved to the top of the list, e.g.:
- job with args [1]
- job with args [2]
+ job with args [1]
+ job with args [2]

And expect { ... }.to have_enqueued_jobs would fail because it would think that no jobs were (re-)enqueued.
Equally, if the order of jobs would change, or if some jobs succeed, or if more jobs succeed than fail and a re-scheduled, the expectation would fail.
I believe we can leave some of those cases for follow-up improvements, but one I'd love to see is:
# some setup
expect { ... }.to have_enqueued_job(MyJob)

that would fail if we just compare the counts of matching jobs.
It is unfair to do so with counts because yes, one job was performed, and one enqueued.
If you scope it to the :retry queue, the expectation would pass. Because there were no jobs on that queue, and now there's one. But this is unfair, too, as it works fine with the previous count-only implementation, too.
How about an example with a job that was on :retry queue already and got re-enqueued again?

This looks fine to me, but I defer to @pirj as we do want a failing spec this fixes :)

Previously we were checking only job counts, so if one job was performed and one job was added - matcher failed.

This is an incorrect assumption.
The "before" for the matcher is everything prior to what is inside the expect { ... } block.
I am not aware of an option to perform jobs with the test adapter that were enqueued previously.
queue_adapter.perform_enqueued_jobs = true and perform_enqueued_jobs { ... } do not perform previously enqueued jobs.
So if a job is enqueued, performed and schedules itself all inside expect { ... }, all previously enqueued jobs are out of equation with
in_block_jobs = queue_adapter.enqueued_jobs.drop(original_enqueued_jobs_count)

and all the jobs that are left enqueued (e.g. when perform_enqueued_jobs = true but perform_enqueued_at_jobs = false) like in the case with job retries, are still detected. This is what your newly added example shows, as it is passing just fine with the current implementation.
Even though I'd love to merge my shiny refactoring involving Set that considers if the same job gets re-enqueued, I have no good idea how it can affect a real-world spec.
I failed to write an example that would break the existing implementation, and with this I'm more inclined to close this PR.
Please do not hesitate to reopen if you can write a failing spec.

Actually, a spec might be possible to write with a direct non-block usage of perform_enqueued_jobs as here.

@ojab Does this look correct to you?
Please accept my apologies for nitpicking and ignorance of the block-less form of perform_enqueued_jobs that was needed to reproduce the issue.

@pirj oh, right, sorry for bogus spec. I'll update the PR tomorrow to use non-block form and will check that it fails properly in master.

Checked the commit where monkeypatch was introduced into local codebase, it's
retried_job.perform_later

expect  { perform_enqueued_jobs }.to

so yeah, spec is indeed doesn't mirror what was broken :facepalm:
Changed/verified that it breaks with rails-6.1 on main and works with changes in this PR/pushed.

Which monkey patch?
How does this work?
We set the adapter to perform jobs, then schedule a job.
The job should immediately execute, fail and be re-scheduled for later, right?
What does the second perform_enqueued_jobs do, performs it once again, and then it is re-scheduled once again?
        queue_adapter.perform_enqueued_jobs = true
      end

      it "passes with reenqueued job" do
        time = Time.current.change(usec: 0)

        retried_job.perform_later

        travel_to time do
          expect  { perform_enqueued_jobs }.to

I strongly prefer the solution with Set, as it's significantly simpler.
Does it solve the same issue?

Thank you, @ojab !
I went with my implementation approach for the fix. If you feel that yours is superior, please don't hesitate to open a PR with a failing spec.

Released in 6.0.2


how to change "Slect images amount is limit"  error message

Kindly give idea to change the error message


moment.utc Safari BST parse error

Description of the Issue and Steps to Reproduce:
Open Safari 11
Run moment.utc('Wed Jun 20 2018 00:00:00 GMT+0100 (BST)').toISOString()
You'll get null
Environment:
Moment 2.22.2, Safari 11
Other information that may be helpful:
Errors on momentjs.org too.
If you are reporting an issue, please run the following code in the environment you are using and include the output:
>console.log( (new Date()).toString())
< Thu Jun 07 2018 17:12:55 GMT+0100 (BST)
>console.log((new Date()).toLocaleString())
< 07/06/2018, 17:12:55
>console.log( (new Date()).getTimezoneOffset())
< -60
>console.log( navigator.userAgent)
< Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_4) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/11.1 Safari/605.1.15
>console.log(moment.version)
< 2.22.2

If you open developer tools in Safari and ensure console logging it set to All, you'll see the deprecation warning:

Deprecation warning: value provided is not in a recognized RFC2822 or ISO format. moment construction falls back to js Date(), which is not reliable across all browsers and versions. Non RFC2822/ISO date formats are discouraged and will be removed in an upcoming major release. Please refer to http://momentjs.com/guides/#/warnings/js-date/ for more info.

i.e. as you've discovered, the date format you're using works in some browsers and not others.
The suggestion is that you should ensure your dates are formatted in accordance with standards, or if you know the format, pass the format string and use strict parsing.

@jack828 specify the format or make sure its either ISO or RFC2822:
moment('Wed Jun 20 2018 00:00:00 GMT+0100 (BST)', 'ddd MMM DD YYYY HH:mm:ss [GMT]ZZ')
> moment("2018-06-20T02:00:00.000")

Note that this does not parse the (BST) so it will fail if run in strict mode. Moment can't skip arbitrary text in its parser.


[Runtime] Remove warning about "missing" witness table entries.

It introduces spurious results.

@swift-ci please smoke test and merge

@swift-ci please smoke test and merge


Preview a campaign before publishing/saving

Break out from #37
Ability to preview changes when updating a campaign (already published) before saving them. Have the ability to preview an unpublished campaign or a change before they push it live. The preview could be just in a tab (like above here when I am entering a comment on an issue in GitHub) it doesn't have to be 'long lived' aka stored in system.
Add a UI tab to display preview of the campaign
@tonysurma - Can I confirm, is it just the content of the description (and it's formatting) we want to preview of the whole campaign layout (including title and images etc)?

Working on it.

Thanks for picking this up Hamid!


remove nullable goproto option for DeploymentGroups

Pull Request Test Coverage Report for Build 92

3 of 3 (100.0%) changed or added relevant lines in 2 files are covered.
31 unchanged lines in 1 file lost coverage.
Overall coverage remained the same at 65.862%

Files with Coverage Reduction
New Missed Lines
%

app/deployment/app.go
31
47.71%

Totals

Change from base Build 86:
0.0%

Covered Lines:
3054

Relevant Lines:
4637

💛  - Coveralls


Automatically trim whitespace from input box fields

One of the most annoying issues I had with pfSense, and now having with OPNSense since migrating routers over is the lack of trimming text on input fields. For example, putting in any extra whitespace at the beginning or end of a MAC address or IP address field results in an error and having to go back to correct it, instead of just trimming the additional characters and processing like normal.
This is most commonly occurring when copy-pasting the addresses (or really, any field data) from other web based administration consoles that use tables. If the cursor selection for the address on the other administration page was too far to the left/right, it'll include an additional TAB character.

Some fields in MVC have special validation to avoid this, but most of the static pages do not do this at all. Nothing we want to change in old code that is too hard to maintain and eventually removed.

I'm confused. What part of this is being removed? The page in question is the DHCP static IP address UI page. Why would any of that be removed? Also, what is complex about running trim() on GET/POST data, to help provide a better UX for end-users?

The entire page will be removed and replaced by a MVC variant when the time is ready (static page is almost any page containing ".php" in the URL while the new pages contain "/ui" in the URL).

Can we please revisit this? MVC migration or not, this results in super-annoying validation errors, e.g. when pasting aliases.

@doktornotor yes and no, we're not going to cleanse the actual input as a space is a regular character and we would interfere with with the normal storage pattern. The pasting issue however can likely be fixed easily with https://github.com/opnsense/core/commit/547c97a93192a4b6ad8150a0d4c6e91c6da6bc5e , in my humble opinion this isn't a backend issue and should thus be fixed where it originates from.

Kinda confused how it is supposed to be fixed where it originates from. The problem is described pretty exactly in the original report, There are areas where it always makes sense to trim any whitespace from input (or treat it as a delimiter) - such as IPs, subnets etc.
On a more generic note, the inability to edit anything in these types of input fields does not help. I need to find and remove the offending entries and re-add them again.

ok, then I'll patiently wait for a PR which fits the earlier described boundaries.

So with https://github.com/opnsense/core/commit/547c97a93192a4b6ad8150a0d4c6e91c6da6bc5e applied - am I supposed to  somehow edit mvc/app/Views/OPNsense/alias/alias.volt to get the whitespace trimmed on paste, or... ?

on input fields, yes, on tokenizers, no. likely also fixable, but not related to the (generic) question. I can point you in the direction, but already starting to regret spending time on the subject.

Well if that's something that could eventually get merged I'd be happy to spend some time to get this improved. If whitespace trimming is generally undesired, then I'd rather not maintain local patches.

cleansing the "paste" action is fine, to be honest, your specific use-case likely only needs a trim() here :
https://github.com/opnsense/core/blob/5280cb346bc40fe9dc221dcdae6c9eb4543de74e/src/opnsense/www/js/opnsense_ui.js#L366
90% of the other inputs just use an input field, which is what my commit cleanses when being pasted. I'm for good reasons not a fan of sending A to an endpoint and storing B, it's asking for future issues. data is either acceptable or it's not.


Update cancel-azure-subscription.md

Update deletion for AAD Offer - autodelete after 90 days of cancellations

@macyso Thanks for opening this PR to make a doc update. I expect your PR to get merged sometime today and the article to get refreshed live later this afternoon.


libsinsp.pc references build tree instead of install prefix

Describe the bug
Notice the references to /tmp/guix-build-falcosecurity-libs-0.15.1-drv-0 in the pkg-config libsinsp.pc file, as shown by the grep command below:
$ grep -rin guix-build /gnu/store/c363y8pvmynd2c8dg83802891n4v03nr-falcosecurity-libs-0.15.1
grep: /gnu/store/c363y8pvmynd2c8dg83802891n4v03nr-falcosecurity-libs-0.15.1/lib/libscap_engine_savefile.a : fichiers binaires correspondent
/gnu/store/c363y8pvmynd2c8dg83802891n4v03nr-falcosecurity-libs-0.15.1/lib/pkgconfig/libsinsp.pc:11:Cflags: -I${includedir}/falcosecurity/libsinsp -I/tmp/guix-build-falcosecurity-libs-0.15.1.drv-0/source -I/tmp/guix-build-falcosecurity-libs-0.15.1.drv-0/source/userspace -I/tmp/guix-build-falcosecurity-libs-0.15.1.drv-0/source/userspace/libscap -I/tmp/guix-build-falcosecurity-libs-0.15.1.drv-0/build -I/tmp/guix-build-falcosecurity-libs-0.15.1.drv-0/build/driver/src -I/gnu/store/vbb4mazz64v6gy10nzz1dp1ixk690fav-tbb-2021.6.0/include/tbb -I/gnu/store/9jkzwa8j0ag4n0bwmdwn9k313ilwgywf-jsoncpp-1.9.5/include -I/gnu/store/m57i4jra2yg42sz886qyz6x5qz2bxiai-valijson-1.0.2/include -I/gnu/store/4w850l8yy5lj5mvrfq253bcs8axhnizc-re2-2022-12-01/include -I/gnu/store/0kzjzrgsn7k1clc6mxk5ndfmsikwm7wz-c-ares-1.18.1/include -I/gnu/store/54cqjg46c15qsx75b63rfbmvshw8w5nd-curl-8.5.0/include

This then causes issues like:
CMake Error in userspace/sysdig/CMakeLists.txt:
  Imported target "PkgConfig::LIBSINSP" includes non-existent path

    "/tmp/guix-build-falcosecurity-libs-0.15.1.drv-0/source"

  in its INTERFACE_INCLUDE_DIRECTORIES.  Possible reasons include:

  * The path was deleted, renamed, or moved to another location.

  * An install or uninstall procedure did not complete successfully.

  * The installation package was faulty and references files it does not
  provide.

With CMake when one tries to use it with pkg_check_modules.
How to reproduce it
Build it in a different location than its installation prefix.
Expected behaviour
The pkg-config file include directives in CFLAGS should refer to the installed files in their final location (installation prefix), not those from the build tree.
Environment

Falco version: 0.15.1
OS: Guix System
Kernel: Linux hurd 6.8.8-gnu #1 SMP PREEMPT_DYNAMIC 1 x86_64 GNU/Linux
Installation method: From source.

A workaround is to remove the @SINSP_PKG_CONFIG_INCLUDES@ template variable from the userspace/libsinsp/libsinsp.pc.in source file before configuration.

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle stale

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle rotten

/remove-lifecycle rotten

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle stale

/remove-lifecycle stale


user_scope

Hey thanks for this!!
I can't seem to get user_scope to be generated when set via the config or when passing it via a url param. It's always null. I'm probably doing something wrong, but it looks like you have default_users_scope in the module doc and default_user_scope here: https://github.com/jsmestad/ueberauth_slack_v2/blob/master/lib/ueberauth/strategy/slack_v2.ex#L34

@chasers what do you have in your config?
For example here one from a project of mine:
config :ueberauth, Ueberauth,
  providers: [
    slack:
      {Ueberauth.Strategy.SlackV2,
       [
         default_scope: "",
         default_user_scope:
           Enum.join(
             [
               "chat:write",
               "users.profile:write",
               "users:read",
               "users:write"
             ],
             ","
           ),
         callback_url: Environment.get("SLACK_CALLBACK_URL")
       ]}
  ]

No need to support me on this really, it all works if I handroll the auth url ... it looks like it's generating the scopes correctly. Every time I touch oauth stuff I need to relearn it 😭.  TL;DR when I use Ueberauth to generate the auth url it tries to auth the bot in the callback phase.
I'm trying to reimpliment the Slack sign in stuff...
When using Ueberauth to generate the auth urls I'm redirected to:
https://slack.com/oauth/v2/authorize?client_id=689539426144.1542831573764&redirect_uri=http%3A%2F%2Flocalhost%3A4000%2Fauth%2Fslack%2Fcallback&response_type=code&scope=app_mentions%3Aread&user_scopes=identity.basic%2Cidentity.avatar%2Cidentity.email%2Cidentity.team

So that actually seems to generate the correct scopes ... apologies. But it looks like it's trying to authenticate the bot and not the user because I get this from the callback phase.
%Ueberauth.Auth{
  credentials: %Ueberauth.Auth.Credentials{
    expires: false,
    expires_at: nil,
    other: %{
      has_2fa: nil,
      is_admin: false,
      is_owner: false,
      is_primary_owner: false,
      is_restricted: false,
      is_ultra_restricted: false,
      team: "Logflare",
      team_domain: nil,
      team_id: "TL9FVCJ48",
      team_url: "https://logflare.slack.com/",
      user: "logflare_staging",
      user_id: "U01FSS3ADM0"
    },
    refresh_token: nil,
    scopes: ["users:read", "incoming-webhook", "commands", "app_mentions:read"],
    secret: nil,
    token: "xoxb-689539426144-1536887353714-VJqwaM8chs6gLNrXexpTS5Sr",
    token_type: "bot"
  }

But when I roll my own authorize url it all works:
https://slack.com/oauth/v2/authorize?client_id=#{Application.get_env(:ueberauth, Ueberauth.Strategy.SlackV2.OAuth)[:client_id]}&install_redirect=update-to-granular-scopes&scope=&user_scope=identity.basic,identity.avatar,identity.email,identity.team&redirect_uri=#{LogflareWeb.Endpoint.url() <> "/auth/slack/callback"}&state=

My config looks like this:
config :ueberauth, Ueberauth,
  providers: [
    github: {Ueberauth.Strategy.Github, [default_scope: "user:email"]},
    google: {Ueberauth.Strategy.Google, []},
    slack:
      {Ueberauth.Strategy.SlackV2,
       [
         default_scope: "app_mentions:read",
         default_user_scope: "identity.basic,identity.avatar,identity.email,identity.team"
       ]}
  ],
  json_library: Jason

@chasers let me know if you hit any other issues. I have some commits on master to try and iron out how to parse the new Slack v2 data in all cases. I am sure there are a few changes to the OAuth::Client-related code that are unhandled.


Support "direct" LAN mode in addition to NAT

NAT is a pain, so I'd like to implement "direct" LAN mode like in Broadband Hamnet & AREDN. In this mode, each host connected to the LAN gets its own IP address on the mesh, and no port forwarding is required.

I have opened a fork and a pull request and have Direct mode working, including a new reservation screen, similar to BBHN's Linksys routers.  Until its accepted by urlgrey, you can get it at https://github.com/cbegg50/hsmm-pi.git.

I tried your fork cbegg and the script dosent get it installed. Would of loved to check out direct mode

Took a lot of figuring out because I am new to hsmm-pi and even Linux but I got it working. I like your additions.


Pass env down?

Given
- uses: jenseng/dynamic-uses@v1
  with:
    uses: actions/setup-node@${{ steps.branch-name.outputs.current_branch }}
    with: '{ "node-version": 18 }'
  env:
    environment_variable: test

I don't believe env would be passed down into the dynamically created uses, this would be pretty integral to have as a feature

Hmm, not sure why it wouldn't work, and from this test it seems to work just fine, in particular see how both a composite action and JS action output the env_test_ vars (either explicitly set on the step, or inherited from the job)

Closing this out, but happy to reopen if there are situations where it's not working correctly


Write a Python program to find the trace of a matrix

Description
Write a Python program to find the trace of a matrix
The trace of a square matrix is the sum of the elements on the main diagonal (from the upper left to the lower right).
Input  :
1 2 3
4 5 6
7 8 9

Output :
15

How to contribute

Save the solution in program/find-the-trace-of-a-matrix.py file
Add find-the-trace-of-a-matrix.py file in find-the-trace-of-a-matrix folder

!assign


wfm-checkbox doesn't work on pad

wfm-checkbox doesn't work on pad

another duplicate issue of issue https://github.com/Teleopti/styleguide/issues/297


Add sample data and handling of hidden pages and questions

This PR includes changes to hide pages, page sections, and embeddables that are marked as hidden in the activity JSON.  Question numbering, page numbering, and page navigation is updated to reflect hidden content.  An additional sample JSON file is included that contains hidden pages, hidden sections (the interactive box section has content but is hidden) and questions (use ?activity=sample-activity-hidden-content to access).

This all looks good, AFAICT. It would be nice to see a spec test for this, though. I assume sample-activity-hidden-content is a real activity? Then the spec test could be based on what is really hidden in that activity (which is presumably the same, but hard for me to check).

@eireland Any thoughts on testing hidden content?  Would this make more sense as something we build into the Cypress tests?

@sfentress I added tests for activity-utils.ts that uses 2 of the sample activities (which also revealed a bug that I fixed).  Should be a good starting point for testing functions in that module.


Treat liveness and readiness separately

Suppose I have an application that can take itself "out of service" for various reasons (operations, too many requests, etc). The application code will make that determination and change their health check to NOT_SERVING.
If I run this application in a container/pod in kubernetes, then I can set a livenessProbe that will terminate the container/pod if the status changes from SERVING. However, I'd also like to run a readinessProbe that will mark the container as Not Ready if the status returns NOT_SERVING, but change the livenessProbe to not kill the container/Pod.
My initial thought was to add a flag --not-serving (will gladly take input on flag name) that would return exit code 0 if the status is NOT_SERVING. This would allow the container/pod to live but not be ready.
I'm willing to contribute this if it makes sense.
working on my CLA

Liveness probes are usually used for processes that locked up/frozen. If the process is locked up, who's sending the NOT_SERVING response?

If the process locks up or is frozen, then it will not return a response and terminate the pod anyways. However, if something in the code changes the health status to NOT_SERVING, I want the pod to stay alive but move to a Not Ready state. In short, it's less about liveness and more about differentiating between liveness and readiness.

I think you said it yourself :) You need to use readiness probe. So this tool already fails that probe if the service is not serving. I don't see what else you need to distinguish.

My plan it to use the probe for both liveness and readiness, but don't want to fail the liveness if the status comes back as NOT_SERVING. To do that, I'd want a flag.
If I use this probe for liveness and the application is set to NOT_SERVING then it'll fail. Is there another/better way to check for liveness? Is a port scan more efficient here?
I'm certain I'm not explaining it properly, but I do appreciate you working with me on this! :-)

I'll give an advice and excuse my bluntness. Initially it seemed like you didn't know exactly what liveness probes are for, and that's a big problem. Liveness probes can be malicious if you exactly don't know what they're designed for. They're for deadlocked/frozen processes. A readiness probe can already serve as a liveness probe for your use case.
If your readiness probe is the same thing as your liveness probe, you should set your keyboard aside and do more reading.

https://srcco.de/posts/kubernetes-liveness-probes-are-dangerous.html
https://twitter.com/sszuecs/status/1175376216997670913
https://twitter.com/thockin/status/1175577582365884416
https://github.com/kubernetes/website/issues/16607

Liveness probes are most likely what you think they are. Try sticking with readiness probes, and don't feel obliged to use liveness probes. In your case, liveness probe can be as simple as checking a port is open (e.g. test -n $(nc -z localhost 80-80)).

I appreciate that feedback. My thought process was that the flag would differentiate between liveness and readiness, but instead I can use a tcp socket for liveness and use the probe for readiness.
I think there's still an edge use case for the flag (and it's only 4 LoC), but we can keep this closed.


Issue #42: activates tests

.travis.yml:

adds make test

Makefile:

clarifies documentation comments

docker-test/run.sh:

adds output of image name which is tested

Travis build succeeded. This should fix #42


AWS_PROFILE not working, commands failing

What happened?
In pulumi-aws v5+, if the provider profile is specified by the config, it is now required to set the AWS_ACCESS_KEY and AWS_SECRET_KEY for that specific profile. Previously if there were no credentials, Terraform would fall back on the credentials found in the environment.
GH Issue
Terraform Provider Update
Given this, I am attempting to pass AWS_PROFILE as an env parameter to the actions as recommended here. However, this does not work and there is no way to relate the credentials to the was profile so Pulumi does not fail the command.
Steps to reproduce

Have an AWS profile set up in your aws provider.

- name: Pulumi preview
        uses: pulumi/actions@v3
        with:
          command: preview
          stack-name: myStack
        env:
          PULUMI_ACCESS_TOKEN: ${{ secrets.PULUMI_ACCESS_TOKEN }}
          AWS_PROFILE: ${{ env.AWS_PROFILE }}
          AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
          AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
          AWS_REGION: ${{ env.AWS_REGION }}

Expected Behavior
Actions can use the credentials set in the CI/CD process to the profile passed in the actions automatically. Command runs successfully.
Actual Behavior
Commands fail with the following error:
error configuring Terraform AWS Provider: failed to get shared config profile, my-profile
Versions used
@pulumi/aws     5.4.0
@pulumi/awsx    0.40.0
@pulumi/pulumi  3.32.1
@pulumi/random  4.6.0
Additional context
No response
Contributing
Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

Sorry for the confusion here, I believe you want to use a different action in a previous step, like: https://github.com/aws-actions/configure-aws-credentials, rather than passing aws creds via the env of the pulumi action.

@jkisk I think this is unrelated to Github Actions. On my laptop, I'm using export AWS_PROFILE=atriso to point to the correct sections in the following files:
~/.aws/config
[profile atriso]
region=eu-west-1
output=json

~/.aws/credentials
[atriso]
aws_access_key_id=<mykey>
aws_secret_access_key=<mysecret>

Only exporting AWS_PROFILE works when using the AWS CLI. For instance, aws iam list-users returns me the actual list of users I have in my AWS account.
With Pulumi, this worked when using pulumi-aws v3. This morning, I upgraded to pulumi-aws v5 and I get the error:
$ pulumi preview
Previewing update (production)

View Live: https://app.pulumi.com/<redacted>

     Type                 Name             Plan     Info
     pulumi:pulumi:Stack  root-production
     └─ aws:iam:User      github-user               1 error

Diagnostics:
  aws:iam:User (github-user):
    error: unable to validate AWS AccessKeyID and/or SecretAccessKey - see https://pulumi.io/install/aws.html for details on configuration

This is clearly a regression. Probably in the upstream TF provider?

One recent change is that we've started pre-validating credentials up-front rather than waiting for a resource to fail to deploy. One workaround is to set skipCredentialsValidation: true which will skip this step. However, there's also an additional change which should be released in the next hour (v5.7.1) which should address some issues in this credentials validation process.