Define Logging Levels and Use Cases

Currently, the project lacks clearly defined conventions and guidelines for logging. This creates potential inconsistencies in how logging is implemented across the codebase. Establishing standard practices for logging will improve code maintainability, debugging, and user experience.

Define Logging Levels and Their Use Cases:

Provide clear definitions and examples for log levels (e.g., DEBUG, INFO, WARN, ERROR, FATAL).
Specify when to use each level, such as:

DEBUG: Detailed diagnostic information, disabled in production.
INFO: High-level status updates for normal operations.
WARN: Indication of potential issues or recoverable errors.
ERROR: Non-recoverable errors requiring attention.
FATAL: Critical errors leading to application termination.

Standardize Logging Format:

Ensure logs include essential context such as timestamps, module/component names, and unique request/operation identifiers where applicable.

Adopt a Logging Framework:

Choose or recommend a logging framework (e.g., klog, zap, or others) that integrates well with the Kubernetes ecosystem.
Ensure the framework supports structured logging for better integration with observability tools.

Document Logging Guidelines:

Add a section in the developer documentation outlining logging conventions.
Include best practices for implementing logs, avoiding sensitive data in logs, and ensuring performance considerations.

Refactor Existing Logs:

Audit and refactor existing log statements to align with the new conventions.
Remove redundant or unnecessary log statements.

Acceptance Criteria

[ ] Logging levels and their definitions are documented.
[ ] A consistent logging framework is selected and integrated into the project.
[ ] Logging format is standardized across the codebase.
[ ] Documentation is updated with logging guidelines and examples.
[ ] Existing logs are refactored to follow the defined conventions.

See https://github.com/kubernetes-sigs/gateway-api-inference-extension/pull/90#discussion_r1886180939 for additional context.

I included "Adopt a Logging Framework" above for completeness but the project currently uses klog which meets the documented criteria. If others agree, then check off A consistent logging framework is selected and integrated into the project. in the Acceptance Criteria section.


docs: storybook install and demo

Description
Add storybook installation instructions and a gif of what it looks like to help people understand all the different options that come NES.css
Compatibility
README update only. No compatibility issues.
Caveats
None.

Thanks for your contribute 😆
I think this storybook section is better in CONTRIBUTING.md 🤔
and I want the assets directory to contain only things related to NES.css, so I want to move it to .github/assets or .github/images.
I will merge this PR and fix about the above. 🔧
Please wait for a moment. 🙇

:tada: This PR is included in version 2.3.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Login fields shown on splash screen

log in, open dev tools and throttle connection speed, refresh, shouldn't see anything here except a small central loading indicator


Possibly related to #57, crash when naval unit turn starts offscreen

I've mentioned before and tagged in #57 but can't reproduce reliably.
Had it again tonight though in latest 527 build.  Definitely upon starting a turn with an offscreen naval unit (trireme this time, away from land) but does not appear to occur every time.
Not sure if this helps, Error report:
Problem signature:
Problem Event Name:	CLR20r3
Problem Signature 01:	civone.exe
Problem Signature 02:	<IP_ADDRESS>
Problem Signature 03:	57d80d16
Problem Signature 04:	CivOne
Problem Signature 05:	<IP_ADDRESS>
Problem Signature 06:	57d80d16
Problem Signature 07:	757
Problem Signature 08:	0
Problem Signature 09:	System.NullReferenceException
OS Version:	6.1.76<IP_ADDRESS>.256.1
Locale ID:	2057
Additional Information 1:	48f3
Additional Information 2:	48f3caff84f0073211477328e1e01226
Additional Information 3:	431e
Additional Information 4:	431e697fab0030dcb99e8afab0c611fd

Thank you for the info and the log. It should help in finding out what's going wrong.

Can you confirm that this happens when the boat is close to one of the poles?

Confirmed, this has been fixed in a recent commit.


chore: CODEOWNERS audit

Description
Fixes b/275440264
Updates after a cross-repo audit in preparations for the upcoming FixIt.
Checklist

[X] Please merge this PR for me once it is approved

Closing this PR and moving to a clean version #2992 due to issues with conflict resolution.


Support IPv6 from mDNS

This also adds support for IPv6 with zones, making use of the netip package. This breaks the TCPMux and AllConnsGetter interfaces to get more accurate Mux matching.

@edaniels Would it possible to limit this just to mDNS for now?
I would love to see these other things fixed, but as unique efforts/PRs.
The Mux setup in ICE in particular needs evaluated. We have 3 different UDP Mux's I believe, and they all have different issues. Before we break any APIs I would like to understand them all and do one clean break!

@edaniels Would it possible to limit this just to mDNS for now?
I would love to see these other things fixed, but as unique efforts/PRs.
The Mux setup in ICE in particular needs evaluated. We have 3 different UDP Mux's I believe, and they all have different issues. Before we break any APIs I would like to understand them all and do one clean break!

I want to say yes but let's see what breaks when I undo those changes in this PR. They must have happened in combination with a TCP mux plus mDNS tests. If they don't break, I'll keep it undone. If they do, I'll see if I can create a temporary hidden interface that is an experimental API that works for the mixed implemented in the pkg!


_posts folder contents could be easier to manage

-posts folder contains language folders and these are subdivided with category folders.
However, the actual modules are controlled by the header matter and do not need to be in these language and category folders. An example of how the folders could be organized is at
https://github.com/Nick-Tallguy/Nick-Tallguy.github.io/tree/master/_posts
I propose to gradually move the folder contents, renaming as needed, until they are in this format. This will make managing the system easier, and could lead to a small amount of automation of updates

See also #306

Closing now. _posts folder now contains language folders with no folders within them. This is much easier for me to manage with scripts.


What SO tag to use

When I open a new issue here the text says to use SO tag google-cloud-python:
If you are reporting  .... to see if there is already work being done.

http://stackoverflow.com/questions/tagged/google-cloud-python

The SO tag google-cloud-python has no guidance, to icon. However, the SO tag gcloud-python has a guidance and a nice Google Cloud logo. Which one is right? If the google-cloud-python, may you polish it? Thanks.

Thanks for the report @xmedeko!
@lukesneeringer or @omaray, do you have access to the StackOverflow account to update this?

I do not. @omaray?

Hello xmedeko. Thanks for pointing out that gcloud-python has a logo next to it. We'll make sure to remove it.
Regarding what tag to use - we normally recommend using a double tag system: [python][product]. So for bigquery for instance, you could use [python][google-bigquery].

@omaray What if a want to address this library in general? When I open a new issue here the text says to use SO tag google-cloud-python - is that the right tag? What about gcloud-python is it the wrong tag? If I look into the SO questions, many users use both of them, i.e. they are confused like me.

To clarify: the gcloud-python tag should not be sponsored with a logo anymore. I made a request and waiting for a response. Thank you for pointing that out.
Then the fact that the text says to use "google-cloud-python" is actually something that was debated (whether we should use it or not). Meaning,  when people use a client library, it's usually "in a language and for a product". Therefore, they'll want to tag their language and the actual product. So expecting to have 2 tags also make sense.
But that being said, what would be your expectations here? Would you expect to use a single tag, like [google-cloud-python], or use two tags such [python][google-bigquery] if you used the bigquery library?

The [python] tag and the product tag are too broad. So I vote for both [google-cloud-python] and the product tag:

The problem may not be related to any particular product, just to the [google-cloud-python] library itself.
When the problem is related to a particular product, it should be tagged with both [google-cloud-python][google-bigquery].

Note: there is also a tag google-api-python-client for the old Python client library, too.

Yes, I'm indeed aware of these other google-api-* tags.
Thanks for the feedback xmedeko. We'll consider strongly.

Regardless of the final decision, closing this issue.


issue#651

Export-AzPolicyResources.ps1 :

Correct property reference
Casing fix (wrong one was not reading/assigning values as expected)

Scripts/Helpers/Confirm-PolicyResourceExclusions.ps1 :

if and foreach where giving error if value was null - introduced check to skip

@microsoft-github-policy-service agree [company="KPN BV"]

@microsoft-github-policy-service agree company="KPN BV"


/dev/null on Windows can't be found

Pretty simple error, on Windows 10 :
Caused by: java.io.FileNotFoundException: \dev\null (Le chemin dÆaccÞs spÚcifiÚ est introuvable)
at com.cloudbees.diff.Diff.diff(Diff.java:25)
at com.cloudbees.diff.Diff$diff.call(Unknown Source)
at uk.jamierocks.propatcher.task.MakePatchesTask.process(MakePatchesTask.groovy:97)
at uk.jamierocks.propatcher.task.MakePatchesTask$process.callCurrent(Unknown Source)
at uk.jamierocks.propatcher.task.MakePatchesTask.doTask(MakePatchesTask.groovy:51)
at org.gradle.internal.reflect.JavaMethod.invoke(JavaMethod.java:75)
... 75 more

Interesting - I'll give this a look when I get back later ;)

Created a Pull Request to fix this and other Windows bugs :) Think to the Windows compatilbity next time ! I always use Linux but during holidays i use my laptop under Windows so, i was blocked :(
If you could push this to the gradle repository so I can use it asap !

https://github.com/jamierocks/ProPatcher/commit/b02caa374320d3530f75a6291b00a3271988c7f5


Add Color Palette Extension

Description
Your Global Color Palettes
Choose palette from built-in popular color palettes
; Preview the appearance, name and HSL value of each color;
Copy the color value (Hex or RGB or HSL) to your clipboard.
ScreenShot

Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed outside of the metadata folder

It would maybe be nice if this extension could superseed #3162 by @douglas-pires and add the colors from that extension too; what do you both thinks?

Sorry, I didn't notice that there is already a similar extension.
I want to ask whether similar extensions are allowed to exist?

if it's not allowed, I don't mind merging the two extensions, of course it depends on what @douglas-pires thinks.
If allowed, I might prefer ColorPalette to be released as an independent extension, so that we can all continue to optimize according to our own ideas.
ColorPalette wants to support more functions in the future. Such as supporting users to add JSON files to make their own color palettes.

Looking forward to your reply.

if it's not allowed, I don't mind merging the two extensions, of course, it depends on what @douglas-pires thinks.

Hello folks, I don't mind merging them either. @mapengyuan, you did a great job putting together the pre-built palettes.
I also don't mind having two independent extensions, but that will depend on the strategy Raycast wants to take as a product per se.

It's also more about not confusing the users that can see two almost identical extensions.
If @douglas-pires doesn't mind, yours can superseed the current one, then the current users of https://www.raycast.com/douglas-pires/palette-colors will just get an update with this instead
That would only require that you support the palette colors that's currently in that one

If @douglas-pires doesn't mind, yours can superseed the current one
This is my first PR on Github，and I just started learning TS and writing the extension of Raycast. I have a lot to learn.

The next thing I need to do is to organize the colors of the previous plugins into the JSON file as a separate category?
And I want to confirm again, whether @douglas-pires  is willing to accept this, after all, you are the first developer to provide a similar plugin, and I fully accept you to do this.

It's also more about not confusing the users that can see two almost identical extensions.

I agree. Even though they have different approaches (dynamic vs static) they have a similar purpose: to provide colors.

The next thing I need to do is to organize the colors of the previous plugins into the JSON file as a separate category?

Yes, you can use another Grid.Dropdown.Section component to create another section and list the options there. Something like:
        <Grid.Dropdown tooltip="Select Color Scheme Variant" storeValue onChange={(newValue) => setType(newValue)}>
          <Grid.Dropdown.Section title="Color Scheme Variants">
            <Grid.Dropdown.Item title="Mono" value={SchemeTypes.Mono} />
            <Grid.Dropdown.Item title="Contrast" value={SchemeTypes.Contrast} />
            <Grid.Dropdown.Item title="Tetrade" value={SchemeTypes.Tetrade} />
            <Grid.Dropdown.Item title="Analogic" value={SchemeTypes.Analogic} />
          </Grid.Dropdown.Section>
          <Grid.Dropdown.Section title="Design">
            // ... The list of colors here
          </Grid.Dropdown.Section>
        </Grid.Dropdown>

It shouldn't be too problematic to merge your approach with the current plugin. Let me know if you need help. Also, it's important to note that unfortunately, Raycast doesn't provide a localization feature, which means that the plugins and their texts must be translated into English (link to the docs),

If @douglas-pires doesn't mind, yours can superseed the current one, then the current users of https://www.raycast.com/douglas-pires/palette-colors will just get an update with this instead

Hello folks, I think I should have done the job, and change some features.

Combined palette-colors's four kinds palettes into one palette named "Color Scheme Variants", and put the palette into "Dynamic palettes".
Modifies the mechanism of regenerate palette: switching palette no longer triggers regenerate palette, only manually clicking "Regenerate Color" will trigger.Because I think that after the user generates a favorite color palette, they don't want to switch the color palette to trigger the refresh of the palette, so that they will not be able to find the previous color palette.

I also did the following：

Documented the current merge in the README.md and CHANGELOG.md files, with thanks to @douglas-pires.
Replace the previous Chinese content with English content, however, the colors in Traditional Chinese Color Palette use Chinese names that are so difficult to translate into English. In order to maintain the accuracy of the color names, the Chinese names are still used.

Is there anything else I need to do? @pernielsentikaer

Hi @mapengyuan 👋
Wow! That's awesome! I fixed the flicker when entering the extension. Do you mind checking it out so Ididn't break anything?
There are some Chinese in the extension, at the moment, Raycast doesn't support localization and only supports US English. Therefore, please avoid introducing your custom way to localize your extension.
I'm looking forward to testing this extension again 🔥
Request a new review when you are ready. Feel free to contact me here or at Slack if you have any questions.

I'm loving the changes! Thank you for your work improving it, @mapengyuan! I'll test it today in the evening here.

Did you have time to test it out yet @douglas-pires

Hey guys, I made another Commit, fixing some bugs and adding a custom palette.

Fixed the problem of automatic refresh when the dynamically generated swatch is loaded, ensuring that the refresh of the palette can only be triggered manually.
A customizable built-in color palette has been added. Users who need to customize the color palette can easily customize it by modifying the Json file without modifying the code.

You can  test the extension by the latest commit @douglas-pires 😊

Maybe we should move Custom_Palette to supportPath (write it if not exists) and do something like this instead:
{paletteRef.current === "custom" && (
  <Action.Open
    title="Edit Custom Palette"
    target={`${environment.supportPath}/Plaette_Custom.json`}
  />
)}

If we keep it in assetsPath it will be deleted upon updating the extension 😉
Also hence there is a spelling error here: Plaette_Custom

Thank you so much for your suggestion. After thinking about it, users should have a better way to add custom palettes, the current method I provide is not good enough. So I removed the Custom palette. After this busy time has passed, I'll try to come up with a better way to support custom.

So we're ready to move on now @mapengyuan?

So we're ready to move on now @mapengyuan?

I have no problem 😊

I'll test right now. Sorry for the late response everyone!

Yes, replace the current extension folder is the thing to do, then its only an update 😊

Yes, replace the current extension folder is the thing to do, then its only an update 😊

Do you need me to do this? Complete the replacement and submit a new Commit

It needs to "replace" files in the other extension, this way it will just be seen as an update 😊

Done, but I don't know how to add @douglas-pires to the developer of the plugin😂

I'm not sure what I broke, can you guys check it? 😊

Thanks, @mapengyuan! :)

Can we fix it so it's not flickering? It seems to be the elements that go temporary to 4
Log
06:39:05.537 PaletteRef:  spectrum palette.length:  42
06:39:05.552 PaletteRef:  spectrum palette.length:  4
06:39:05.558 PaletteRef:  spectrum palette.length:  4
06:39:05.592 PaletteRef:  spectrum palette.length:  42

Happens on all loads for me, I just added console.log("PaletteRef: ", paletteRef.current, "palette.length: ", palette.length); before the return 😊

I reproduced this bug and I will try to fix it over the weekend

Are you still working on this @mapengyuan

Are you still working on this @mapengyuan

I'm really sorry, there have been some changes in my job recently, and I have had to spend a lot of time on work. I may have to finish fixing this issue in May.😭

All good, I converted it to a draft 😊

Closing this for now. We can always open it again when you're ready 🙂


"cannot unmarshal DNS message" in data "oci_waas_edge_subnets" "waf_cidr_blocks"

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform Version and Provider Version
Terraform v0.13.7

provider registry.terraform.io/hashicorp/local v2.1.0
provider registry.terraform.io/hashicorp/null v3.1.0
provider registry.terraform.io/hashicorp/oci v4.36.0
provider registry.terraform.io/hashicorp/template v2.2.0

I've also tried Terraform v1.0.3; which makes no difference
Affected Resource(s)
data "oci_waas_edge_subnets" "waf_cidr_blocks"
Terraform Configuration Files
The only changes I have made compared to the terraform.tfvars.example are the following:
I've shortened some of the variables with ....etc. to hide some potentially sensitive info
api_fingerprint = "31:f9:f7:35:0e.....etc."
api_private_key_path = "~/.oci/oci_api_key.pem"
region = "eu-amsterdam-1"
tenancy_id = "ocid1.tenancy.oc1..aaaaaaaalmam3mmw.....etc."
user_id = "ocid1.user.oc1..aaaaaaaaxfta2g5bmjv72y7oz.....etc."
compartment_id = "ocid1.compartment.oc1..aaaaaaaa.....etc."
label_prefix = "nxs-dvza-test"
ssh_private_key_path = ".oci/dummy-ssh"
ssh_public_key_path = ".oci/dummy-ssh.pub"
bastion_enabled = false
operator_enabled = false
cluster_name = "cluster"
node_pools = {
  np1 = {
    shape = "VM.Standard.E3.Flex",
    ocpus = 2,
    node_pool_size = 3
  }
}

node_pools_to_drain = [ "np1" ]

Panic Output
https://gist.github.com/willemsendennis/c1cb7f10cd838bd11ed3ee8c80d0b95e
Expected Behavior
No waas/waf errors should be thrown, especially since we didn't enable it.
Actual Behavior
Error: Get "https://waas.eu-amsterdam-1.oci.oraclecloud.com/20181116/edgeSubnets": dial tcp: lookup waas.eu-amsterdam-1.oci.oraclecloud.com on <IP_ADDRESS>:53: cannot unmarshal DNS message
on modules/okenetwork/datasources.tf line 22, in data "oci_waas_edge_subnets" "waf_cidr_blocks":
22: data "oci_waas_edge_subnets" "waf_cidr_blocks" {
Steps to Reproduce

clone the git repo
apply the changes I have mentioned above for the terraform.tfvars
terraform init
terraform plan

Important Factoids
I have tried region eu-amsterdam-1 and eu-frankfurt-1
Last working version I've tried that didn't have this issue is oracle-terraform-modules/oke/oci 3.0.0

Hi @willemsendennis,
In the other issue, as a quick suggestion, I mentioned the following:

Create a group and add the terraform user to the group
Create a policy in root compartment with the following statement: "Allow group to read waas-family in tenancy"
And then try again by uncommenting the datasource? Please replace the groupname in (2) as appropriate.

To which you replied:
Unfortunately adding the policy to the group where the terraform user is part of didn't help.
With the same user I am able to perform the following oci cli waas command, e.g.:
oci waas waas-policy list --compartment-id=...
Can I confirm you added the "Allow group to read waas-family in tenancy" and it still didn't work?

Hi @hyder,
Yes, I added the read waas-family in tenancy to the group the user is part of.
(Also tried manage waas-family and even tried creating a separate group with waas policies, just to be sure)
Without success.

Hi @willemsendennis, I think we have identified a temporary fix but we are still not sure why this is happening. We'll follow up with our engineering team internally.

Great, thank you @hyder for the status update.

@willemsendennis , can you please test?

Hi @hyder,
Yes I can confirm this works as expected.
Enabling WAF is on our todo list, seeing this fix (although also a correct fix) is sort of a workaround for the issue I do wonder if we will hit the issue again.
But, until then, thank you for the quick actions!

Glad this works for now. Yes, we are aware. This is just to get you going while we figure out why this is happening.


Increase memory and cpu limit for DBaaS Operator

Description

Verification Steps

Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist (Definition of Done)

[ ] All acceptance criteria specified in JIRA or in issue number have been completed
[ ] Unit tests added that prove the fix is effective or the feature works
[ ] Documentation added for the feature
[ ] all relevant tests are passing
[x] Code Review completed
[ ] Verified independently by reviewer

lgtm


Set default visibility to hidden

Resolved issues:
N/A
Description of changes:
This change sets the default symbol visibility to hidden. The APIs which are to be exported are marked with S2N_API such that they are attributed with default visibility.
Call-outs:
To facilitate this change all tests are now linked to the static library in order to access the internals of s2n.
s2nc and s2nd are also linked to the static lib as they access private internals.
when running fuzz testing, the previous behavior (default visibility) is used as fuzz testing relies on the LD_PRELOAD trick to subvert some s2n APIs.  When statically linking with s2n this doesn't work as the symbols are resolved at link time.
Testing:
Existing test suites should pass.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #2082 into master will decrease coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2082      +/-   ##
==========================================
- Coverage   80.41%   80.34%   -0.07%
==========================================
  Files         233      233
  Lines       17629    17625       -4
==========================================
- Hits        14176    14161      -15
- Misses       3453     3464      +11

may need some updates to fix benchmarks now..
/tmp/ccmRdnHg.o: In function `ValidPemTestFixture::SetUp(benchmark::State const&)':
s2n_pem_parse_benchmark.cc:(.text._ZN19ValidPemTestFixture5SetUpERKN9benchmark5StateE[_ZN19ValidPemTestFixture5SetUpERKN9benchmark5StateE]+0x7c): undefined reference to `s2n_read_test_pem'
s2n_pem_parse_benchmark.cc:(.text._ZN19ValidPemTestFixture5SetUpERKN9benchmark5StateE[_ZN19ValidPemTestFixture5SetUpERKN9benchmark5StateE]+0xa6): undefined reference to `s2n_read_test_pem'
/tmp/ccmRdnHg.o: In function `InvalidPemTestFixture::SetUp(benchmark::State const&)':
s2n_pem_parse_benchmark.cc:(.text._ZN21InvalidPemTestFixture5SetUpERKN9benchmark5StateE[_ZN21InvalidPemTestFixture5SetUpERKN9benchmark5StateE]+0x7c): undefined reference to `s2n_read_test_pem'
s2n_pem_parse_benchmark.cc:(.text._ZN21InvalidPemTestFixture5SetUpERKN9benchmark5StateE[_ZN21InvalidPemTestFixture5SetUpERKN9benchmark5StateE]+0xa6): undefined reference to `s2n_read_test_pem'

may need some updates to fix benchmarks now..
/tmp/ccmRdnHg.o: In function `ValidPemTestFixture::SetUp(benchmark::State const&)':
s2n_pem_parse_benchmark.cc:(.text._ZN19ValidPemTestFixture5SetUpERKN9benchmark5StateE[_ZN19ValidPemTestFixture5SetUpERKN9benchmark5StateE]+0x7c): undefined reference to `s2n_read_test_pem'
s2n_pem_parse_benchmark.cc:(.text._ZN19ValidPemTestFixture5SetUpERKN9benchmark5StateE[_ZN19ValidPemTestFixture5SetUpERKN9benchmark5StateE]+0xa6): undefined reference to `s2n_read_test_pem'
/tmp/ccmRdnHg.o: In function `InvalidPemTestFixture::SetUp(benchmark::State const&)':
s2n_pem_parse_benchmark.cc:(.text._ZN21InvalidPemTestFixture5SetUpERKN9benchmark5StateE[_ZN21InvalidPemTestFixture5SetUpERKN9benchmark5StateE]+0x7c): undefined reference to `s2n_read_test_pem'
s2n_pem_parse_benchmark.cc:(.text._ZN21InvalidPemTestFixture5SetUpERKN9benchmark5StateE[_ZN21InvalidPemTestFixture5SetUpERKN9benchmark5StateE]+0xa6): undefined reference to `s2n_read_test_pem'

Yes, i'll rebase and fix any issues - i already have a fix for this one, but i pushed them out of order, so this is expected.

Compare this with https://github.com/awslabs/s2n/pull/2101#issuecomment-655732887, seems to be about 2x faster.

Same results on my dev box - thanks for posting, you beat me to it :)
Yes, it is about 2x faster on the pem parsing, no change on the base64 stuff


Cannot read property 'selections' of null

I am bumping in to this error at this line: https://github.com/mattkrick/cashay/blob/8d9174d478b63883f68b64f82c183b60a3aad0c4/src/normalize/denormalizeStore.js#L34
This started happening after I added a custom type to my schema.  When i had "hello" resolving to "world" everything worked fine, but when i tried to create a very basic "user" type, i started seeing this.
I'm not sure what's going on here, could use a point in the right direction.

thanks for the bug report! Can you share your schema & query? If not everything, at least the part where it gets tripped up.

Sure!
This is my schema.js which contains everything.
(Note that this is a function because of how I handle importing and passing around graphql)
// graphql/server/schema.js

export default function(graphql) {
  const {
    GraphQLSchema,
    GraphQLObjectType,
    GraphQLString,
    GraphQLNonNull,
    GraphQLID
  } = graphql;

  const User = new GraphQLObjectType({
    name: 'User',
    description: 'Stuff',
    fields: () => ({
      id: {
        type: GraphQLID,
        description: 'the id'
      },
      name: {
        type: GraphQLString,
        description: 'the name'
      }
    })
  });

  const queryType = new GraphQLObjectType({
    name: 'RootQueryType',
    fields: () => ({
      hello: {
        type: GraphQLString,
        resolve() {
          return 'world';
        }
      },
      user: {
        type: User
      }
    })
  });

  return new GraphQLSchema({
    query: queryType
  });
}

Also, the error gets triggered when I run cashay.query(`{ user }`)
Running cashay.query(`{ hello }`) works fine.

Updated example with a resolve callback.  Still getting the same error.

@mattkrick any idea what might be causing this error?  i am not too knowledgable on how ASTs work or what exactly is being done by the offending line, but i want to help!

AH! Sorry I replied a few days ago but guess it didn't make it to github. Thanks for the ping!
I think the cause is that you're returning a string instead of a document (complete with an id field). I'll fix this

okie doke, so the problem is that your query isn't valid. GraphQL is super declarative, so you'd need to write:
user {
  id
  name
}

Otherwise, it doesn't know what fields to grab for ya.
That said, Cashay should probably throw up a useful warning message. I'll fix that

Thanks for the quick feedback.  I'll give it a try later today.

Adding the fields works.  Thanks!
FYI, if the id field is omitted, I get this error:
Uncaught TypeError: Cannot read property 'find' of undefined

occurring at this line:
https://github.com/mattkrick/cashay/blob/master/src/normalize/normalizeResponse.js#L52
maybe this needs a friendlier error as well?

that sounds good, i'll add that to the PR

Awesome!  Thanks for the quick feedback.  I'll make the adjustment, and close after I verify.
Sent from my iPhone

On Oct 23, 2016, at 8:55 AM, Matt Krick<EMAIL_ADDRESS>wrote:
okie doke, so the problem is that your query isn't valid. GraphQL is super declarative, so you'd need to write:
user {
id
name
}
Otherwise, it doesn't know what fields to grab for ya.
That said, Cashay should probably throw up a useful warning message. I'll fix that
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Ah, you know what, I don't think I planned for any query from the root
query to return a primitive. Usually a query returns a document that
includes an ID field. If you don't have an ID, then it can't really cache
it efficiently. I'll dig in and see if I can reproduce.
On Fri, Oct 21, 2016, 8:43 AM Dustin Farris<EMAIL_ADDRESS>wrote:

Updated example with a resolve callback. Still getting the same error.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/mattkrick/cashay/issues/131#issuecomment-255412383,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFQjv6hwVMrDliRmOJ22jIssM0XrNcA4ks5q2N2ygaJpZM4KdWC0
.


Add a logger system to catch break app

Create a logger system to save app failures and unexpected breaks.

Avoid crash on deserializers when values are null and log this issues and send it to api to be fixed.


[MMCA-4753] Display a list of requested authorities CSV files notification to download on the 'Manage your account authorities' page

[x] Lift all relevant code from customs-financials-frontend
[x] Ensure test coverage for all lifted code
[x] Refactor Standing Authority notification view model
[x] Updated sbt-plugin to latest
[x] Update all license headers

https://jira.tools.tax.service.gov.uk/browse/MMCA-4753

Could you please address the below scalastyle warnings for Tests?
[warn] /Users/vineet.tyagi/hmrc/codebase/customs-manage-authorities-frontend/test/controllers/ManageAuthoritiesControllerSpec.scala:190:0: Whitespace at end of line
[warn] /Users/vineet.tyagi/hmrc/codebase/customs-manage-authorities-frontend/test/controllers/ManageAuthoritiesControllerSpec.scala:238:0: Whitespace at end of line
[warn] /Users/vineet.tyagi/hmrc/codebase/customs-manage-authorities-frontend/test/controllers/ManageAuthoritiesControllerSpec.scala:292:0: Whitespace at end of line

Thanks for reviewing, Vineet! 😊 I've gone through all your comments and made the necessary corrections.
I also added an extra test to verify that the call to the customs-financials-api to delete notifications from ManageAuthoritiesController is invoked, as our conversation reminded me this check was missing.
I think it could be beneficial to implement scalafmt for the project as a tech debt. This could save time for dev and the reviewer by ensuring consistent styling across the codebase, and let us all agree on common style as a team.

Could you please address the below scalastyle warnings for Tests?
[warn] /Users/vineet.tyagi/hmrc/codebase/customs-manage-authorities-frontend/test/controllers/ManageAuthoritiesControllerSpec.scala:190:0: Whitespace at end of line [warn] /Users/vineet.tyagi/hmrc/codebase/customs-manage-authorities-frontend/test/controllers/ManageAuthoritiesControllerSpec.scala:238:0: Whitespace at end of line [warn] /Users/vineet.tyagi/hmrc/codebase/customs-manage-authorities-frontend/test/controllers/ManageAuthoritiesControllerSpec.scala:292:0: Whitespace at end of line

These seem to be false positives, because I can't see any whitespace here :thinking:

Fixed whitespaces now

Thanks for reviewing, Vineet! 😊 I've gone through all your comments and made the necessary corrections.
I also added an extra test to verify that the call to the customs-financials-api to delete notifications from ManageAuthoritiesController is invoked, as our conversation reminded me this check was missing.
I think it could be beneficial to implement scalafmt for the project as a tech debt. This could save time for dev and the reviewer by ensuring consistent styling across the codebase, and let us all agree on common style as a team.

Yes. Tom, we will do that as part of tech debt and thanks for addressing the comments


rpc.idleText doesn't work?

I wanted to have a sarcastic little message for when I'm idle, so I gave it a value, and also set rpc.checkIdle to 10 seconds so I could easily see if the change worked. I unfocused my terminal, switched to Discord, waited 10 seconds... nothing. Waited a bit longer... nothing. Tried to find a coc command that could help me figure out the issue but I didn't find anything. Didn't see anything important in :CocOpenLog either.
Here's my coc-settings.json. Pretty bare, I know.
{
	// 0_coc
	"coc.preferences.extensionUpdateCheck": "daily",

	// 1_java
	"java.clean.workspace": true,
	"java.completion.enabled": true,
	"java.codeGeneration.generateComments": true,

	// 2_discord
	"rpc.workspaceElapsedTime": true,
	"rpc.checkIdle": 10,
	"rpc.idleText": "Zᴢz",

	"": ""
}

I originally tried a much longer string by the way, but after it didn't work I thought maybe there was a character limit so I set it to the Zzz, but obviously it still didn't work.

I've to rewrite the whole "idle" a little bit, to make something more optimal and work properly. If you have any ideas on how I can do this, feel free to contribute. #38

Fixed. Available soonTM - https://github.com/LeonardSSH/coc-discord-rpc/pull/38#issuecomment-854910348


🐛 android alarm manager error with react native >= 0.68

Hello,
Notification scheduled using the alarm manager does not work anymore since react native version 0.68, was working fine on 0.66
Notification works fine when not using the alarm manager.
When triggering a notification with alarm manager I get this error:
[Error: Attempt to invoke virtual method 'java.lang.Class java.lang.Object.getClass()' on a null object reference]

Version tested:
0.68.2
0.69.1
reproduction in a bare new react native project, created with npx react-native init notifications --template react-native-template-typescript:
import notifee, {
  AndroidBadgeIconType,
  TimestampTrigger,
  TriggerType,
} from '@notifee/react-native';
import React from 'react';
import {SafeAreaView, Text, TouchableOpacity} from 'react-native';

export const testNotification = async () => {
  try {
    await notifee.requestPermission();
    const channelId = await notifee.createChannel({
      id: 'notification-channel',
      name: 'Reminder',
    });

    const fireDate = new Date();
    fireDate.setSeconds(fireDate.getSeconds() + 5);

    const trigger: TimestampTrigger = {
      type: TriggerType.TIMESTAMP,
      timestamp: fireDate.getTime(),
      alarmManager: {
        allowWhileIdle: true,
      },
    };

    await notifee.createTriggerNotification(
      {
        title: 'Test Notification',
        body: 'Hello',
        android: {
          channelId,
          badgeIconType: AndroidBadgeIconType.SMALL,
          pressAction: {
            id: 'default',
            launchActivity: 'default',
          },
        },
      },
      trigger,
    );
  } catch (e) {
    console.error(e);
  }
};

const App = () => {
  return (
    <SafeAreaView>
      <TouchableOpacity onPress={testNotification}>
        <Text>RUN</Text>
      </TouchableOpacity>
    </SafeAreaView>
  );
};

export default App;

npx react-native info result:
System:
    OS: macOS 12.4
    CPU: (8) x64 Intel(R) Core(TM) i7-7820HQ CPU @ 2.90GHz
    Memory: 1.07 GB / 16.00 GB
    Shell: 3.2.57 - /bin/bash
  Binaries:
    Node: 16.13.0 - ~/.nvm/versions/node/v16.13.0/bin/node
    Yarn: 1.22.17 - ~/.nvm/versions/node/v16.13.0/bin/yarn
    npm: 8.1.2 - ~/.nvm/versions/node/v16.13.0/bin/npm
    Watchman: 2<IP_ADDRESS> - /usr/local/bin/watchman
  Managers:
    CocoaPods: 1.11.3 - /Users/alexandre/.rbenv/shims/pod
  SDKs:
    iOS SDK:
      Platforms: DriverKit 21.2, iOS 15.2, macOS 12.1, tvOS 15.2, watchOS 8.3
    Android SDK: Not Found
  IDEs:
    Android Studio: 2021.2 AI-212.5712.43.2112.8609683
    Xcode: 13.2.1/13C100 - /usr/bin/xcodebuild
  Languages:
    Java: 11.0.2 - /usr/bin/javac
  npmPackages:
    @react-native-community/cli: Not Found
    react: 18.0.0 => 18.0.0
    react-native: 0.69.1 => 0.69.1
    react-native-macos: Not Found
  npmGlobalPackages:
    *react-native*: Not Found

package.json
{
  "name": "notifications",
  "version": "0.0.1",
  "private": true,
  "scripts": {
    "android": "react-native run-android",
    "ios": "react-native run-ios",
    "start": "react-native start",
    "test": "jest",
    "lint": "eslint . --ext .js,.jsx,.ts,.tsx"
  },
  "dependencies": {
    "@notifee/react-native": "^5.4.0",
    "react": "18.0.0",
    "react-native": "0.69.1"
  },
  "devDependencies": {
    "@babel/core": "^7.12.9",
    "@babel/runtime": "^7.12.5",
    "@react-native-community/eslint-config": "^2.0.0",
    "@tsconfig/react-native": "^2.0.0",
    "@types/jest": "^26.0.23",
    "@types/react-native": "^0.69.1",
    "@types/react-test-renderer": "^18.0.0",
    "@typescript-eslint/eslint-plugin": "^5.29.0",
    "@typescript-eslint/parser": "^5.29.0",
    "babel-jest": "^26.6.3",
    "eslint": "^7.32.0",
    "jest": "^26.6.3",
    "metro-react-native-babel-preset": "^0.70.3",
    "react-test-renderer": "18.0.0",
    "typescript": "^4.4.4"
  },
  "resolutions": {
    "@types/react": "^18"
  },
  "jest": {
    "preset": "react-native",
    "moduleFileExtensions": [
      "ts",
      "tsx",
      "js",
      "jsx",
      "json",
      "node"
    ]
  }
}

The same issue is with<EMAIL_ADDRESS>but the issue is gone with the previous version on notifee (5.3.0).

Do you have the whole stack trace? This is not enough of it to be useful:
[Error: Attempt to invoke virtual method 'java.lang.Class java.lang.Object.getClass()' on a null object reference]

@mikehardy here is the stacktrace:
07-03 null:null:null.401 13507 14416 E ReactNativeJS: [Error: Attempt to invoke virtual method 'java.lang.Class java.lang.Object.getClass()' on a null object reference]
07-03 null:null:null.505 13507 13507 E NOTIFEE : (API): createTriggerNotification
07-03 null:null:null.505 13507 13507 E NOTIFEE : java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.Class java.lang.Object.getClass()' on a null object reference
07-03 null:null:null.505 13507 13507 E NOTIFEE : 	at n.o.t.i.f.e.e.o.a(SourceFile:2)
07-03 null:null:null.505 13507 13507 E NOTIFEE : 	at app.notifee.core.b.a(SourceFile:130)
07-03 null:null:null.505 13507 13507 E NOTIFEE : 	at app.notifee.core.c.a(SourceFile:862)
07-03 null:null:null.505 13507 13507 E NOTIFEE : 	at app.notifee.core.c$$ExternalSyntheticLambda5.call(D8$$SyntheticClass)
07-03 null:null:null.505 13507 13507 E NOTIFEE : 	at com.google.android.gms.tasks.zzz.run(com.google.android.gms:play-services-tasks@@18.0.null:null:null)
07-03 null:null:null.505 13507 13507 E NOTIFEE : 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1113)
07-03 null:null:null.505 13507 13507 E NOTIFEE : 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:588)
07-03 null:null:null.505 13507 13507 E NOTIFEE : 	at java.lang.Thread.run(Thread.java:818)

Well that is just bizarre, thanks for the report (great detail by the way), unfortunately the stack trace is a bit uninformative but that's not a complaint, it's just buried in the core library and that's how they look. @helenaford do you have any time for a local repro attempt? I'm travelling and will be for quite some weeks unfortunately. Failing that @alwex you can pull the repo and try to run the core library from source, it's not super hard though a bit subtle. This kind of bug is usually pretty easy to catch with source available though

I just tried to downgrade to v5.3.0 as @dancixx  mentioned and the error is gone. It seems to have been introduced with v5.4.0, so not related with react native. I will try to run the code from source and see what happens.

Thanks All, I will look now and find the issue 🙌

Published a fix (v5.4.1), thanks for reporting this! Also, sorry you faced the bug, please let us know if you run into anything else. thanks!

I confirm the issue is resolved, thank you


feat: add pest-language-server

Closes williamboman/mason.nvim#1313

This LSP only works on .pest files, but the validation is failing because there's no language named "Pest". How do I fix this?

This LSP only works on .pest files, but the validation is failing because there's no language named "Pest". How do I fix this?

It needs to be included in the enum specification in the schema, I pushed a commit that adds this!


Malicious gen perm

Returns a sort permutation in a malicious context.
This runs sort in a malicious context. The caller is responsible to validate the accumulater contents and downgrade context to Semi-honest before calling this function
The function takes care of upgrading and validating while the sort protocol runs.
It then returns a semi honest context with output in Replicated format. The caller should then upgrade the output and context before moving forward
Steps

[Malicious Special] Upgrade the context from semihonest to malicious and get a validator
[Malicious Special] Upgrade 0th sort bit keys
Compute bit permutation that sorts 0th bit
For 1st to N-1th bit of input share
i. Shuffle the i-1th composition
ii. [Malicious Special] Validate the accumulator contents
iii. [Malicious Special] Malicious reveal
iv. [Malicious Special] Downgrade context to semihonest
i. [Malicious Special] Upgrade ith sort bit keys
ii. Sort ith bit based on i-1th bits by applying i-1th composition on ith bit
Compute bit permutation that sorts ith bit
Compute ith composition by composing i-1th composition on ith permutation
In the end, following is returned
i. n-1th composition: This is the permutation which sorts the inputs
ii. Validator which can be used to validate the leftover items in the accumulator


update(falco-incubating_rules.yaml): add Backdoored library loaded in…

…to SSHD rule

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind feature

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area rules

/area registry

/area build

/area documentation

Proposed rule maturity level

Uncomment one (or more) /area <> lines (only for PRs that add or modify rules):

/area maturity-stable

/area maturity-incubating

/area maturity-sandbox

/area maturity-deprecated

What this PR does / why we need it:
Detect the sshd process loading a vulnerable version of libzlma
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:

LGTM label has been added.  Git tree hash: a5f03a0d5aba54d53f4b64fe5dc802d5796d1157


Add tip for returning large response payload

This tip is useful for use cases with large response such as server side rendering.

Thanks for reviewing @meryllblanchet . Yes good idea, updated ✅


Update _index.md

Update ingress certificate request
What this PR does / why we need it:
It updates the documentation to reflect actual behaviour.
Which issue(s) this PR fixes:
Fixes #
After a little troubleshooting, it seems like the Ingress manifest don't trigger the DNSEntry manifest creation on the shoot without dns.gardener.cloud/class: garden and dns.gardener.cloud/dnsnames: ... annotations.
Special notes for your reviewer:
Documentation update.
Release note:

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@timuthy


pkg/list: list.Flatten fails on non-final value

This cue code:
import "list"
Items :: [... string] | *[]
x: list.FlattenN([Items], -1)

produces:
{
    "x": [
        []
    ]
}

not the expected:
{
    "x": []
}

It seems that the flatten code isn't treating Items as a list.

This issue has been migrated to https://github.com/cue-lang/cue/issues/268.
For more details about CUE's migration to a new home, please see https://github.com/cue-lang/cue/issues/1078.


New updates don't contain the DASH video & DASH audio format

I'm using the latest version of youtube-dl and the updates after the 15th of January (maybe even later, 15th was the latest I tried with) don't contain the (DASH video) or (DASH audio) in their format.
Before the update: 480x360 (DASH video) - webm
After the update: 480x360 - webm
These were really helpful because the DASH files solely contain either audio or video (not both) so it was easier to keep them separated.
I tried to use the newer version, but I kept getting frustrated because I couldn't tell the DASH files apart from the others so after downloading 1 hour videos (I have limited bandwidth and I believe that there are other users with the same issue) and only getting a 720p video without the sound, I reverted back to the update from the 15th which is a shame because now I'm missing out on the great new features.
All I'm asking is that you please add the (DASH video) or (DASH audio) back to the format so we can tell the audio, video and video+audio files apart, thanks guys.

Which URL are you trying?

Please review our bug reporting guidelines and post the missing information. Without that information (firstly, the complete output of youtube-dl when called with -v) we can not help you. For what it's worth, works fine for me:
$ youtube-dl -F test:youtube
[TestURL] Test URL: http://www.youtube.com/watch?v=BaW_jenozKcj&t=1s&end=9
[youtube] BaW_jenozKc: Downloading webpage
[youtube] BaW_jenozKc: Downloading video info webpage
[youtube] BaW_jenozKc: Extracting video information
[youtube] BaW_jenozKc: Downloading DASH manifest
[youtube] BaW_jenozKc: Downloading DASH manifest
[info] Available formats for BaW_jenozKc:
format code  extension  resolution note
249          webm       audio only DASH audio   47k , opus @ 50k, 57.05KiB
250          webm       audio only DASH audio   66k , opus @ 70k, 79.56KiB
171          webm       audio only DASH audio   74k , vorbis@128k (44100Hz), 89.59KiB
140          m4a        audio only DASH audio  127k , m4a_dash container, mp4a.40.2@128k (44100Hz), 154.06KiB
251          webm       audio only DASH audio  155k , opus @160k, 186.27KiB
141          m4a        audio only DASH audio  255k , m4a_dash container, mp4a.40.2@256k (44100Hz), 308.59KiB
278          webm       256x144    DASH video   24k , webm container, vp9, 15fps, video only, 25.51KiB
242          webm       426x240    DASH video   27k , vp9, 30fps, video only, 32.52KiB
243          webm       640x360    DASH video   54k , vp9, 30fps, video only, 65.38KiB
160          mp4        256x144    DASH video  115k , avc1.4d400c, 15fps, video only, 135.08KiB
244          webm       854x480    DASH video  145k , vp9, 30fps, video only, 151.52KiB
133          mp4        426x240    DASH video  246k , avc1.4d4015, 30fps, video only, 294.27KiB
134          mp4        640x360    DASH video  294k , avc1.4d401e, 30fps, video only, 349.59KiB
247          webm       1280x720   DASH video  423k , vp9, 30fps, video only, 451.13KiB
135          mp4        854x480    DASH video  727k , avc1.4d401f, 30fps, video only, 849.41KiB
248          webm       1920x1080  DASH video  731k , vp9, 30fps, video only, 809.99KiB
136          mp4        1280x720   DASH video 1425k , avc1.4d401f, 30fps, video only, 1.60MiB
137          mp4        1920x1080  DASH video 1835k , avc1.640028, 30fps, video only, 2.11MiB
17           3gp        176x144    small , mp4v.20.3,  mp4a.40.2@ 24k
36           3gp        320x240    small , mp4v.20.3,  mp4a.40.2@ 32k
5            flv        400x240    small , h263, mp3  @ 64k
43           webm       640x360    medium , vp8.0,  vorbis@128k
18           mp4        640x360    medium , avc1.42001E,  mp4a.40.2@ 96k
22           mp4        1280x720   hd720 , avc1.64001F,  mp4a.40.2@192k (best)

Thanks for your replies, I'll explain what's missing.
@yan12125 - any YouTube video
@phihag - while replying to your message I went back and took a close look at the arguments and output.  I found the issue and it was due to the command that I was running for a longtime and it seems as though the new update changed how --youtube-skip-dash-manifest works as some of the format titles were hidden.  Either way, the problem was solved simply by removing --youtube-skip-dash-manifest from the good old command that I've been using for a while to get my videos.
Sorry for wasting your time, again, the new update changed the behavior of command that I was using.

Could you post the command you use and the output, as well as the difference between your expectation and the actual output, for both the latest version and the previously "working" version?

@yan12125, I just had --youtube-skip-dash-manifest added and it didn't add the (DASH video) to the format, that's the only change, the rest is all the same.

There were no changes for --youtube-skip-dash-manifest behavior lately. Last change related to --youtube-skip-dash-manifest dates half a year ago.


Missing file in data/

Hi @klevdiamanti,
first of all thank you for providing the code for the Mass-Spec analysis. I was trying to execute it but ran into an error:
tmp.azpid <- unique.gene.id(azpid.index_ = dia$index$AZpID)
Error in file(file, "rt") : cannot open the connection

which ultimately comes from the file gene.id.file <- "../data/gsea_files/all.gene.ids.txt" not being present in the repo
https://github.com/klevdiamanti/multitissue_ms_proteomics/blob/main/R/ms_proteomics_pipeline.Rmd#L60
Could you please upload it?
A unrelated question is that the sample names in proteomics_random.xlsx and covars_random.xlsx are named rand*  which is not the same format supplied in the supp matherials of the paper. Are these the same samples and are the intensity values those used in the papers?
Thank you!
António

Hi ,
Thanks for picking this up. Indeed the file you mentioned was missing, but it has been uploaded now. I have tested the rest of the pipeline and it seems to be working without any issues.
The datasets included in the repo are synthetic data that mimic the datasets included in the supplementary materials of the paper, and the format of the data is different. However, I think that with minimal data wrangling one may shape the data from the manuscript to run in the pipeline without problems.
Best,
Klev

Thank you  @klevdiamanti!
Data wrangling shouldn't be a problem, but to make sure I pick the right data, can you please confirm if:

sample data is that Table s1a
protein intensity files are in Table s1c

it would be very appreciated.
Best regards,
António

Yes, protein levels are in Table S1c and other viariables are in Table S1a.
Best,
Klev


Each row of Contributor Screen should navigate to Github page when clicked

Idea Description
Each row should navigate to github page which sent by API
Reference images and links

I'd like to try this issue!


added default name ad tabs

Pull Request Template
Description
Changed new tab name as tab
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Pending:

Tab Number

Tests:

Yet to write tests

#16

@hericlesme this is done. Please check

@gowthamraj198 Thank You! :tada:


Update StorageOS Operator to version 1.5.0

Update to existing Operators

[x] Is your new CSV pointing to the previous version with the replaces property?
[x] Is your new CSV referenced in the appropriate channel defined in the package.yaml ?
[x] Have you tested an update to your Operator when deployed via OLM?
[x] Is your submission signed?

The failure seems to be related to scorecard test cleanup again. It happened last time as well.
I've setup scorecard test for all the CRDs and it works fine https://travis-ci.org/storageos/cluster-operator/jobs/611315398#L1616 .
Not sure why it fails here.

Testing succeeds, cleanup fails. Operator is ok though.


Bower package for 2.9.4 release is not including dist folder and files

Expected Behavior
Using bower install for 2.9.4 should install distribution package
e.g. include "dist" folder and files
Current Behavior
Package installs the gihub repo code
Steps to Reproduce
Run "bower install" with 2.9.4 release as a dependency
Context
Existing builds fail as the 'dist' folder and expected files are missing

Can this problem be fixed as soon as possible?

bower.json is missing

Hello,
Same problem here.
Our project uses angular-chart.js dependency, and angular-chart.js bower.json is too permissive (version 2.X of Chart.js).
Chart.js version 2.9.3 is OK, but version 2.9.4 fails, so our web application crashs.
Can we help you to solve the problem ?

@f3cp @HereWeR @pblanchardie @fresnault I believe I have fixed this issue by repushing the v2.9.4 tag here on GitHub. I can see the dist folder & bower.json file. Can you confirm that this works for you?

@etimberg It's good for us after clean bower cache. Thank you for fixing this so quickly.


I18n module

I would like to add multi-lang on this app, is anyone working on it yet ?
@elhmn @Sanix-Darker @FanJups

Hello @mouafus , am not sure it's already planed, so yeah, you can go ahead with it !
Can you just add more indications on how you're going to implement it please ? 🙏🏽

Hello @Sanix-Darker
I will add the i18n module to facilitate translation through translation files, and add an element to the user interface for interface change.

Hello @Sanix-Darker I will add the i18n module to facilitate translation through translation files, and add an element to the user interface for interface change.

I don't think anyone is working on it currently, we are building new feature and I think picking up i18n will cause some friction.
But feel free to pick that up, we will find ways sync that with the new feature.

Hello @Sanix-Darker I will add the i18n module to facilitate translation through translation files, and add an element to the user interface for interface change.

I don't think anyone is working on it currently, we are building new feature and I think picking up i18n will cause some friction. But feel free to pick that up, we will find ways sync that with the new feature.

Okay, I've almost finished this module locally, I'd like to be notified when it's possible to merge please !

You need to create a pull request before it can get merged

You need to create a pull request before it can get merged

done !

Could you share a link please ?

You need to create a pull request before it can get merged

done !

Could you share a link please ?

https://github.com/osscameroon/jobsika/pull/414


TypeError when using -cp with the imconv task

Hey @landmanbester ,
this command:
spimple-imconv -image mfs07/output/continuum/polarization/test3_fast_mfs07-Q-image.fits -o test -pp 0.008333333 0.008333333 0 -nthreads 10 -cp
failed with this error:
INFO      14:02:09 - IMCONV             | Input Options:
INFO      14:02:09 - IMCONV             |                          image = mfs07/output/continuum/polarization/test3_fast_mfs07-Q-image.fits
INFO      14:02:09 - IMCONV             |                output_filename = test
INFO      14:02:09 - IMCONV             |                       psf_pars = [0.008333333, 0.008333333, 0.0]
INFO      14:02:09 - IMCONV             |                       nthreads = 10
INFO      14:02:09 - IMCONV             |                       circ_psf = True
INFO      14:02:09 - IMCONV             |                     beam_model = None
INFO      14:02:09 - IMCONV             |                           band = l
INFO      14:02:09 - IMCONV             |                         pb_min = 0.05
INFO      14:02:09 - IMCONV             |                   padding_frac = 0.5
INFO      14:02:09 - IMCONV             |                      out_dtype = f4
Traceback (most recent call last):
  File "/home/floi/.local/bin/spimple-imconv", line 8, in <module>
    sys.exit(image_convolver())
  File "/home/floi/.local/lib/python3.8/site-packages/spimple/apps/image_convolver.py", line 104, in image_convolver
    gaussparf[0] = e
TypeError: 'tuple' object does not support item assignment

It should be fixed in the imconv-fixes branch. I'm also looking into an issue where high frequency ripples sometimes get introduced during the convolution. I'm pretty sure this is new as I've not noticed it before. I'll make a new release when I get to the bottom of it

There were some precision issues that could have resulted in unstable behaviour. Should all be fixed in the imconv-fixes branch. @Mulan-94 can you give it a go with the latest changes? You should not have to set -cp anymore, worked for me anyway. If this works I'll get a new release out tomorrow

@landmanbester Yes, it works very well now for me, those two problematic channels I had with my cube have disappeared as well. Both with and without -cp


EOU: When loading a program with -l or --load, it should be the default, to be run page

When you load a program using xrpn -l the program's global label should be the default label to use with XEQ, without having to do a page 1. This saves a step in debugging and running programs.

I don't want to do this as I want to open up the possibility of loading several programs at once, each file to a different page.

I decided to do this anyway.
Also added the possibility to save and load a state in Debug Mode - and to load a full state when running XRPN with the -s or --state switch.

Excellent, thanks.     On Wednesday, April 13, 2022, 04:02:31 AM EDT, Geir Isene @.***> wrote:
I decided to do this anyway.
Also added the possibility to save and load a state in Debug Mode - and to load a full state when running XRPN with the -s or --state switch.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>


questions regarding "vmq-admin session list"

I had a question about the "vmq-admin session list" command.
My goal is to be able to maintain an online/offline status for each device. I can currently send out an online/offline status message each time a device connects or drops off, but that assumes that my external service is online and active all the time. If it ever goes down, then I have the potential to lose the current online/offline status.
The "vmq-admin session list" provides all of the active and inactive sessions the broker has seen. A few questions on it:

Does it span all nodes or only the local one?
Does the broker flush out old connections?
Can I query for just active connections?
Can I query for single or wildcard connections?
How inefficient is this command?
What happens if I run this query with tens of thousands of connections (or more)?

I know about a year ago you said this function was going to go through a major rewrite; is that still the case? Is it close to getting updated?
Thanks.

Hi @jeremylink
The rewrite has happened, it's however with some caveats (see below). To go through your questions:

It spans all nodes by default
Yes, but there is a bug where sometimes old sessions are shown after a broker restart (clean session true sessions) - this will be fixed soon
If by active you mean 'online', then yes: vmq-admin session show --is_online=true.
Wildcards are not (yet) supported in the command line interface, although it is supported by the underlying query-language.
Good question - worst case is that it will have to iterate over all clients on each node to find what it's looking for, there may, however, be some optimizations - @dergraf can for sure elaborate here.
It has a built in limit option which prevent the entire session state to be propated as a result (which could overwhelm the network and the client) - it defaults to 100 results returned from each node.

Note, with the next release this command has been renamed to vmq-admin session show for consistency. Also, note that it should be possible to combine filters (--client_id=xyz and --is_online=true) but that is currently not working and it's a known bug which will also be fixed shortly.

I have 2 use cases:

Query for all connected devices at application startup.
This doesn't really work though since there is a limit of 100 results.
This will only work if you can add some sorting of paging mechanism on the results.

Query for the status on a single device:
This is not working until a future release that will fix the combo filters (--client_id and --is_online).

Do you have a timeframe for #2?
Thanks.

Hi @jeremylink
We want to be able to do both 1 and 2, but I can't say any concrete to when the work will be done. I believe 2 will happen before 1 as it's more low-hanging.

@jeremylink fyi the work to get 2) done is ongoing, see #346 .

Hi @jeremylink #346 was merged to master a while ago and will be part of 1.0.1 as we considered that a bugfix. I suppose I can close this.


Reverted #558 for Windows - 64 bit debug test cmake fails to detect the python lib correctly

Reverted #558 for Windows since the 64 bit debug test build fails on Windows with this option. At windows for this build type it detects the debug 64 bit python library at wrong location:
21:27:49 -- Found PythonLibs: optimized;C:/Python-2.7.14/PCbuild/amd64/python27_d.lib;debug;C:/Python27/libs/python27_d.lib (found suitable version "2.7.14", minimum required is "2")
21:27:49 -- Using PYTHON_INCLUDE_DIRS: C:/Python27/include
21:27:49 -- Using PYTHON_LIBRARIES: optimized;C:/Python-2.7.14/PCbuild/amd64/python27_d.lib;debug;C:/Python27/libs/python27_d.lib
21:27:49 -- Shall use the SHARED Hazelcast library for the tests.
21:27:49 -- Found PythonInterp: C:/Python27/python.exe (found version "2.7.14")

The working one prints:
14:48:31 -- Found PythonLibs: C:/Python-2.7.14/PCbuild/amd64/python27_d.lib (found version "2.7.14")
14:48:31 -- Using PYTHON_INCLUDE_DIRS: C:/Python27/include
14:48:31 -- Using PYTHON_LIBRARIES: C:/Python-2.7.14/PCbuild/amd64/python27_d.lib
14:48:31 -- Shall use the SHARED Hazelcast library for the tests.
14:48:31 -- Found PythonInterp: C:/Python27/python.exe (found version "2.7.14")

Linux test PASSed.

Windows test PASSed.


Add th cells to Activity Log

The activity log should have visually hidden th cells to help screenreaders navigate the data table.
https://github.com/cfpb/cfgov-refresh/pull/972/files#r39313740

Is this still an Open Issue?

No.


Cannot save the environment if it contains slashes

Hi, thank you for the great software first!
I am really enjoying using the software, however I found some trivial bugs that occur in corner cases.
When I try to save an environment which contains slashes, for example "model_1/dim100", it cannot save the environment and makes some unhappy side effects.
If I save it programmatically, for example vis.save([env_name]), the server makes error logs of FileNotFoundError, since the directory $HOME/.visdom/model_1 does not exist.
And if I try to save it on the webpage, the webpage goes offline and I have to click the "offline" button or refresh the page to revive functionalities.
I think two solutions are possible:

making the directory (using something like mkdir -p or os.makedirs) before making the JSON file of an environment, or
replacing slash characters with other safe characters, like _.

Hi @jihunchoi , thanks for your post! You're right, and it sounds like 2 is a good solution. Since the change is pretty simple, want to submit a pull request?

Yup, I will send a PR within 24 hours.


using the command bin/pinot-admin.sh to excute sql,but prompt connection timed out, how can I deal with it?thx

What do you mean by the prompt connection timed out? Did you get an error?

when I use the command bin/pinot-admin.sh post, then about five mininutes later, I get the prompt that connection timed out, but when I check the log I can't find any errors.

And I want to know which log4j.properties file it use when it is running, I want to check all the running information, so I need the log4j.

Too old, no longer relevant


Finalize the list of files which require modifications.

Scrutinize the tentative files list, set aside the files which we will have to modify and explain in brief the changes we will be making to those files in wiki.

Specified additional details for the methods listed in the wiki. Will require further analysis to specify the changes required in depth.

Scrutinized all the identified files, and it seems that the questions weights re being taken into consideration. A summary of the findings is as below:

When adding a new question to a questionnaire, the update method gets called which redirects the flow to add_new_questions method which sets the weight of scored questions to 1 by default when such a question is created for the first time. We could not find a way to associate a weight with a scored question when creating it for the first time.

After creating such a scored question, we changed the weight and saved the questionnaire, which resulted in the update method being called. This time we observed that params[:question] contained all of the existing questions with updated attributes if any (the updated weight values also get recorded here), which are then used to update the weights and any other attributes of the corresponding questions in the database. This is how the weights get updated, we also verified the same after checking the corresponding weights in the database.

Also, all such weights associated with scored questions in a questionnaire are considered when calculating the grades as is evident from the get_total_score method in answer.rb. This method calculates the score for a questionnaire by considering one response at a time which is then aggregated by the caller of this method, compute_scores in the same file.

To calculate the scores for scored questions, the following query is being used:

questionnaireData = ScoreView.find_by_sql ["SELECT q1_max_question_score ,SUM(question_weight) as sum_of_weights,SUM(question_weight * s_score) as weighted_score FROM score_views WHERE type in('Criterion', 'Scale') AND q1_id = ? AND s_response_id = ?", @questions[0].questionnaire_id, @response.id]
We can see that the above query multiplies the score with weights associated with questions. We were also able to verify this by creating a questionnaire and associating different weights with the questions in it. This led to the score calculation for that questionnaire to change as per the weights, which we were also able to verify manually.


Overrides for strictRead and strictWrite in BinaryProtocol

Adding overrides for the strictRead and strictWrite in the BinaryProtocol constructor. Before these were defaulted to false and immutable.
Tests for beginReadMessage and beginWriteMessage, which utilize the strictRead and strictWrite values.

Fixes #547

@microsoft-github-policy-service agree


click redirects can break with relative links on IE

Currently we construct the redirect href with this code
helpers.getAbsolutePath = function (href) {
    var link = document.createElement('a');
    link.href = href;
    return (link.protocol + '//' + link.host + link.pathname + link.search + link.hash);
};

However on some (all?) IE versions this still returns a relative link. This SO question seems to indicate the behavior goes at least as far back as IE 6.
Proposed solution is to use cloneNode() as shamelessly copied from the SO linked above.
helpers.getAbsolutePath = function (href) {
    var link = document.createElement('a');
    link.href = href;
    return link.cloneNode(false).href;
};

released in 1.5.2


Invalid classname error when module installs

I installed the module and I get "invalid classname" when I go to the modules tab. Tested with 1.2.2. and 1.2.3 of the plugin on tb 1.0.1 - this is in live site, it was fine on my test site a few weeks ago

@gingerling did you get solved this ?

@firstred Do you have any suggestions on this issue? I have an PS1.6 that was already moved to TB 1.0 version and is running for more than 6 months, but can't upgrade to latest one due to this.
Thanks,

Is the site already running thirty bees? If so delete the migration module and try.

@Dh42 yes its already removed after migrating to TB, now we would like to upgrade to 1.0.3 but can't due to this error.

finally i did manual upgrade and was successfully upgraded to 1.0.3

Updating thirty bees is now done with module Core Updater, which (hopefully) has no such issues. This module is going to get removed and is no longer subject for bug fixes.


Plan for better developer tooling

The fix proposed in #197 uses features of ES2015. To maintain support of this app in legacy browsers (looking at you IE11) main.js needs to be transpiled with babel during the build process. I thought this might be an opportune time to review and modify the overall developer tooling in this project since it has been brought up in many other issues (e.g. #113, #176, #178).
I'll throw some of the initial ideas down as their own comments so they can be voted on.

Run babel on main.js

Replace Grunt with vanilla npm scripts

Webpack

Replace jQuery with vanilla js

Build JSAPI with Bower

Incorporate Prettier. Ideally, this should be triggered before Pull Requests.


yolov3 bounding box

hi
your network is very good and I want to thank you for this network
i want to implement angle to bounding box and change yolo formats to (x,y,w,h,a)
can we change bounding box yolov3 bounding box styles?

Following ... :)


[WIP] [2.0] Unified API

This is a non-exhaustive list containing todo's to refactor the current 2.0 branch to conform the unified SDK API see: https://docs.sentry.io/clientdev/unified-api/
In general, all points are up for discussion. This should be a rough guideline to hold on to while we progress through it.

[ ] Up minimum PHP version to 7.1 and use features (like: Return type declarations, nullable types, Throwable, …)
[ ] General wording changes to functions (e.g.: leaveBreadcrumb -> addBreadcrumb, Config -> Options)
[ ] Change Sentry protocol version to 7
[ ] Update SDK identifier + User Agent (sentry.php)
[x] Context → Scope
[x] Create Hub which takes some responsibility of the Client / ClientBuilder
[ ] Breakup Client

[x] Move getLastEventID to Hub
[ ] Move breadcrumbs, context information into Scope
[ ] Refactor Middleware's to Integrations
[ ] Remove some public setter/getter

[ ] DSN → We no longer need path (projectRoot)
[ ] shouldCapture → beforeSend
[ ] Do not setTags in Configuration
[ ] Stacktrace should be stacktrace.values[].frames
[ ] Breadcrumbs should be breadcrumbs.values[].crumb
[ ] Remove base64 encoding
[ ] Remove sanitization
[ ] Remove docs from repo, they new live in https://github.com/getsentry/sentry-docs
[ ] Write + Update Docs https://github.com/getsentry/sentry-php/issues/650

Closing to use issue again #670


Exiting Doom Emacs fails if projectile project has been opened

What did you expect to happen?
Should be able to exit emacs.
What actually happened?
Failed to exit emacs, backtrace below.
Debugger entered--Lisp error: (args-out-of-range "" 0 -1)
  substring("" 0 -1)
  (member (substring proot 0 -1) blacklist)
  (or (not (stringp proot)) (>= (length (gethash proot projectile-projects-cache)) doom-projectile-cache-limit) (member (substring proot 0 -1) blacklist) (and doom-projectile-cache-purge-non-projects (not (doom-project-p proot))) (projectile-ignored-project-p proot))
  (if (or (not (stringp proot)) (>= (length (gethash proot projectile-projects-cache)) doom-projectile-cache-limit) (member (substring proot 0 -1) blacklist) (and doom-projectile-cache-purge-non-projects (not (doom-project-p proot))) (projectile-ignored-project-p proot)) (progn (if doom-debug-p (progn (let ((inhibit-message (active-minibuffer-window))) (message #("DOOM Removed %S from projectile cache" 0 5 (face font-lock-comment-face)) proot)))) (remhash proot projectile-projects-cache) (remhash proot projectile-projects-cache-time) (remhash proot projectile-project-type-cache)))

Describe your attempts to resolve the issue
Haven't tried it, because I don't know any elisp, but I think the fix is to skip any proots that are empty strings.
see line 127 in core-projects.el
for proot in (hash-table-keys projectile-projects-cache)
Steps to reproduce

Open emacs
Open a project in projectile (SPC p p, select any project)
attempt to quit emacs (:q, select y)

System Information
https://gist.github.com/GnawNom/05b0c0d3694e66d61098de42d71d4343

Sounds like doom is a bit too much like Vim haha. Try using SPC q q to quit instead.

Tried SPC q q, still get the same error and backtrace. Same thing when I try cmd+q (quit via mac) or killing via activity manager or SPC q K.

As of 1352f8a this issue should be resolved. Let me know if that isn't the case and I'll reopen it. Thanks for bringing it to my attention!

Let me try this out, thanks for the quick fix!

Yep. That worked 👍


Add in variant of capturef that uses va_list

I'd ideally like to wrap g3log with my custom logger class. I'm currently doing this, but I'm forced to cobble it together in a couple of ways. First, I'm using macros to invoke my logger. Additionally, I've copied the implementation of LogCapture::capturef in my class.
In many ways, this mirrors what g3log is already doing, but this way, it hides g3log as the underlying implementation for logging.
The reason for this request is that if I wrap LogCapture::capturef in another function that is variadic, capturef  will not behave properly.
An example I made of wrapping is here:
static void wrapper_log(const char *file, const int32_t line, const char *function, Logger::Level level, const char *message, ...) {
    va_list args;
    va_start(args, message);
    va_list argsCopy;
    va_copy(argsCopy, args);
    Logger::log(file, line, function, level, message, argsCopy);
    va_end(argsCopy);
    va_end(args);
}

wrapper_log(__FILE__, __LINE__, __PRETTY_FUNCTION__, Logger::Level::Debug, "message with %d and %s", 10, "another string");

The output of this becomes:

DEBUG [JKSLobby.mm->-[JKSLobby initWithViewController:gameSpace:delegate:]:111]	message with 236138912 and (null)

Where Logger::log is this class function which is more or less same code as capturef (the difference is that the first line is constructing LogCapture like this: LogCapture capture(file, line, function, toG3Level(level));
The signature for log is this.
    static void log(const char *file, const int32_t line, const char *function, Level level, const char *message, ...) __attribute__((format(printf, 5, 6)));

If I also implement another function, but this one uses va_list, the results are as expected.
    static void log(const char *file, const int32_t line, const char *function, Level level, const char *message, va_list args);

DEBUG [JKSLobby.mm->-[JKSLobby initWithViewController:gameSpace:delegate:]:108]	message with 10 and another string

I realize also that using templates would be better overall, but I want g3log hidden, and by using templates, AFAIK, I have to include implementation in the header files.

I won't add his but am open for pull requests


another tiflash_write node oom after inject one tiflash_write node failure for 50m and recover

Bug Report
Please answer these questions before submitting your issue. Thanks!
1. Minimal reproduce step (Required)
1、run ch
go-tpc ch run -D tpcc --host tc-tidb.endless-ha-test-tps-1815226-1-478 -P4000 --warehouses 2000 -T 32 --acThreads 1 --queries q16 --ignore-error '2013,1213,1105,1205,8022,8028,9004,9007,1062' --time 36000m --user root --password '' --interval '10s'
2、inject one of  tiflash_write node failure for 50m
3、after 48m，one tiflash_write node oom and workload always report error as below：
err execute query q16 failed Error 1105: other error for mpp stream: Poco::Exception. Code: 1000, e.code() = 15, e.displayText() = Exception: no alive tiflash, cannot dispatch BatchCopTask, e.what() = Exception
2. What did you expect to see? (Required)
no error report after 2m when fault injection
no oom
3. What did you see instead (Required)

workload report “err execute query q16 failed Error 1105: other error for mpp stream: Poco::Exception. Code: 1000, e.code() = 15, e.displayText() = Exception: no alive tiflash, cannot dispatch BatchCopTask, e.what() = Exception” after inject one tiflash_write node failure for 50m
4. What is your TiFlash version? (Required)
git hash：f08e4d66ec09b2fb6ea727a23bc7956c15caae40

/severity major

Seems this bug is caused by
TiKV leader will NOT send CompactLog when one TiFlash write node is down. It leads to the number of RaftLog in the other TiFlash write node grows rapidly. It finally cause the TiFlash write node OOM cause by too many pages in UniPS.


How to contribute

Hi! How can I contribute? For example, if I notice a typo in a book title, should I open a pull request?

You can make a pull request or, if it's small, just create an issue and I'll fix it.


Icon only styles?

Sometimes text icons are very small indeed, see below:

Is there anty way I can target icons only with CSS? Often it's simply a matter of increasing their font size, but if I can't target only icons then text becomes massive in comparison.

You can do it with pango markup atm, e.g.
"format": "{icon} {capacity}%"

It works with pango, but it screws up text's vertical alignment too like in this screenshot, where "archimago" is a text going with the icon in the following way, for instance:
"format": " ~ {}",
"exec" : "cat /etc/hostname",

this is a better source imo https://docs.gtk.org/Pango/pango_markup.html, had to change line_height cause the bar becomes too big

I was having a similar issue. The pango markup works, but would be tedious to enter this for every icon in my config. Instead, I installed Nerd Fonts, then used fc-list to find the font name that I wanted and added that to style.css. Now the icons match the font size.

Use the nerdfont variant Propo, i.e.:  "JetBrainsMono Nerd Font Propo", which isn't strictly monospaced, and works well in this scenario


date not working

date default in current date.
However when i set any other date value, it still shows current date only when datepicker comes up. Any solution for this?

I'm facing the same issue on Ionic 2.

Me too having the same issue. it is said to be in Type: String, any idea which format?


Update Tesseract for Flutter 2.0

Really need an update of this amazing package for Flutter 2.0. Could you, zuzu.dev tell me please, when will it happen? I really need it:)

I am not planning on releasing a web version any time soon.  I have full time job and don't have time. If anyone is willing to do the work, and open a PR I will launch it.


simplify tun IP configuration

use the base of the dns IP range as the tun IP address
add 1 (instead of bitwise OR) to the tun IP to get the DNS server listen IP. bitwise OR leads to unexpected values when host portion of base IP is not 0.
populate IpInfo->IP with the tun IP instead of the DNS IP.

before this change, the value provided with the -d option was expected to be a network address (i.e. a CIDR with no host bits set):

the tun IP was always ".1"
the dns IP was always ".2"

this PR changes the meaning of the -d value:

the tun IP is the base IP of the provided CIDR.
the dns IP is the tun IP + ".1".

note that -d now works more like the ip address add command when adding a CIDR. for example:
$ sudo ip addr add <IP_ADDRESS>/24 dev lo
$ ip addr show dev lo
1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN group default qlen 1000
    link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
    inet <IP_ADDRESS>/8 scope host lo
       valid_lft forever preferred_lft forever
    inet <IP_ADDRESS>/24 scope global lo
       valid_lft forever preferred_lft forever
    inet6 ::1/128 scope host
       valid_lft forever preferred_lft forever

before this change, the value provided with the -d option was expected to be a network address (i.e. a CIDR with no host bits set):

For reference: -d is the abbreviated form of --dns-ip-range.

this PR changes the meaning of the -d value:

the tun IP is the base IP of the provided CIDR.
the dns IP is the tun IP + ".1".

note that -d now works more like the ip address add command when adding a CIDR. for example:

There's an apparent contradiction here if I'm reading you correctly.
If the tun IP (the interface address) is the "base IP of the ... CIDR", then I expect tun IP <IP_ADDRESS> for DNS IP range <IP_ADDRESS>/24. However, if the tun IP is assigned in a similar way as ip address add, then I expect tun IP <IP_ADDRESS> for DNS IP range <IP_ADDRESS>/24 (the difference is the host address as network address [base address] of the subnet vs specified host address in IP range).

@scareything OK, I'll try again to express my understanding in the form of an accurate example.
The default DNS IP range is <IP_ADDRESS>/10 and this will produce a TUN IP of <IP_ADDRESS> and nameserver IP of <IP_ADDRESS> because the fourth octet of the specified range is always used as the TUN IP, and the nameserver IP is +1.
If I specify a DNS IP range of <IP_ADDRESS>/26 (64 is the network address) then the TUN IP shall be <IP_ADDRESS> (network +1) and the nameserver IP <IP_ADDRESS> (TUN +1).
Just like ip addr add, if I specify a DNS IP range where the fourth octet is a usable host address inside the range instead of the network address then the host address becomes the TUN IP instead of computing network address +1. For example, for <IP_ADDRESS>/26 then TUN IP is <IP_ADDRESS> and nameserver IP is <IP_ADDRESS>.
Is that completely accurate?

most of the substantive changes from this PR were added in #470


Search: Improvements to clear button behavior

Issue: https://github.com/Microsoft/vscode/issues/62952
Made a few improvements to the behavior of the search clear button based off the suggestions in the above issue.
The clear button now:

Enables after any input to any input box in the search form
Disables after input is cleared from all input boxes in the search form
Clears all input from the search form now including the include and exclude filters

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: aechan sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

great

Is there a way to restore the original behavior? I keep around a list of exclusions that I sometimes swap between include/exclude (e.g. tests).

@WinnieP Are you saying that you'd prefer the include/exclude boxes to not clear when the clear button is pressed?

@aechan Yes, I personally preferred it when those 2 boxes were not cleared when clearing results.

@WinnieP I would recommend opening an issue for that then.


Add namespace name to antrea network policy logs

It would be really nice if we could get the namespace name on the antrea network policy logs. I do not even know if this would be possible, but if so it would be a lot more friendly to debug if you see any drops because you can clearly see if those namespaces should be communicating or not.
of course if the traffic comes from/goes to some external entity that should issue a "null" namespace as source or destination.

It's easy enough to add the Namespace / Name for the local Pod (the Pod on which the network policy is applied) to the logs. The Antrea Agent has this information already. However, getting that information for the other endpoint - if it is a Pod - is not really straightforward. The Pod will typically be on a different Node, and the Agent generating the log entry has no knowledge about that Pod, it only has the IP address and doesn't know how to map it to a Pod Namespace & Name. And we want to keep it this way: an Antrea Agent doesn't need to know about Pods running on other Nodes. If all Agents need to know about all Pods, that put some unnecessary load on both the K8s APIs and on the Agents, which have to keep a lot of state up-to-date.
I think we are trying to keep audit logs light weight: self-contained and easily generated locally by just the Antrea Agent. For more advanced use cases, we are investing in the Flow Aggregator (and the surrounding Flow Visibility solution). The Aggregator aggregates flow information from all the different Agents, and can report all blocked connections, with full information for each connection (K8s Namespaces, Names, ...), even for Service traffic. See https://github.com/antrea-io/antrea/blob/main/docs/network-flow-visibility.md. for an overview. Think of the Flow Aggregator as the Antrea Controller equivalent for network flows. We are very receptive to feedback when it comes to the Flow Aggregator and what helpful features we can build with it.
Coming back to your original question: if you are happy with the Namespace & Name of the local endpoint (Pod to which the policy is applied), we can add that to the policy audit logs. However, it will only give you half the information you need to answer your original "question:"

you can clearly see if those namespaces should be communicating or not.

It would be great to have the namespace/pod name for local on the logs, even if it is only half of the information it would be really helpful if it could be implemented.

Thanks for the feedback. I'd like to make the following points though:

we don't intend for the flow visibility tools to miss any connection. We want to have at least one flow record for every connection. We listen to conntrack for events (at the moment we poll, but I'd like us to change that and even when polling, connections stay in conntrack for long enough for us to catch everything)
we are trying to simplify the infrastructure required to run these tools, this is why we moved away from the ELK stack.

That being said, I can understand this request. I am just trying to avoid too much redundancy, and also too much resource consumption by Antrea components.
Ideally, what would be the best consumption model for audit logs for you? If we need to add Pod namespace/name, we are likely to do it in a central location (could be the Flow Aggregator, or something else). Should we then expose an API, write the logs to a file, send them to a configurable webhook (like K8s audit events)?

Yes, it seems hard to add remote Pod information for every logged packet, and probably also hard to stream all logs to a central service to add Pod information there.
Maybe we can have an async service (in antrea-agent or a separate one) to add information for dropped traffic (assuming dropped traffic is less), and try best to add information for other with some rate control?

Thanks for the feedback. I'd like to make the following points though:

we don't intend for the flow visibility tools to miss any connection. We want to have at least one flow record for every connection. We listen to conntrack for events (at the moment we poll, but I'd like us to change that and even when polling, connections stay in conntrack for long enough for us to catch everything)
we are trying to simplify the infrastructure required to run these tools, this is why we moved away from the ELK stack.

That being said, I can understand this request. I am just trying to avoid too much redundancy, and also too much resource consumption by Antrea components.
Ideally, what would be the best consumption model for audit logs for you? If we need to add Pod namespace/name, we are likely to do it in a central location (could be the Flow Aggregator, or something else). Should we then expose an API, write the logs to a file, send them to a configurable webhook (like K8s audit events)?

I like to the appriach of just writing to a file. If it's going to be on a central location, add to a log file in the node running the controller.

/remove-stale

/remove-stale

/remove-stale

Now that we have added support for file logging to the FlowAggregator, I think the only remaining ask would be to include the appliedTo (local) Pod namespace/name to audit logs. As a reminder, we do not believe that including the peer Pod namespace/name is a good idea, for scalability reasons.

Great. Which version should it make available?

Great. Which version should it make available?

File logging is available in the FlowAggregator in Antrea v1.12
I expect that the local Pod names will be added to audit logs starting with Antrea v1.13

@jsalatiel we have closed this issue, as what we discussed above has been implemented
as a reminder, we have the following capabilities:

the FlowAggregator can now export flow records as a log file: this is similar to Audit Logging in the Agent, but 1) it happens in a centralized location, and 2) each log entry includes more information, including namespace / name for both sides of the connection. Of course, this requires deploying the Flow Aggregator. This is available in Antrea v1.12.
the namespace / name of the local Pod has been added to the Audit Logs generated by the Agent. This will be available in Antrea v1.13.


Populate DatabaseAccountCreateUpdateParameters with new properties to support CCX

Populate DatabaseAccountCreateUpdateParameters with 2 new parameters to support Cassandra Connector Exchange(CCX) feature.
Property Names -
enable_cassandra_connector
connector_offer
We are not yet exposing the property in cli_cosmosdb_create and cli_cosmosdb_update as customers are being on-boarded to this feature in an ad-hoc manner. But for customers whose account is CCX enabled, we need to pass on the existing value of these parameters to DatabaseAccountCreateUpdateParameters so that it does not get reset.
The new python sdk release 0.8.0 already honors these 2 properties in  DatabaseAccountCreateUpdateParameters
https://pypi.org/project/azure-mgmt-cosmosdb/0.8.0/
Also bumping the python version for azure-mgmt-cosmosdb to 0.8.0.
This checklist is used to make sure that common guidelines for a pull request are followed.

[x] The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).

[x] I adhere to the Command Guidelines.

If you want to make your changes available in next release, your code should be merged before this Thursday. For me, there are two things waiting for your changes: 1. Besides declare cosmosdb version update, you also need to declare new two arguments in your commands. 2. Resolve conflicts and make CI passed. It looks good in general.


Make search filter in list view sticky

When using the search field to filter records, the filter is reset after editing and saving a record. The search should remain sticky, so that the search results are still displayed after editing a record.


Correct authority on generated XML

Fixes a bug where content assist could not be shown on commands where the XML was generated by another user when default permissions were not good enough
Introduced versioning to the GENCMDXML program, which is now called GENCMDX where X is the version number.
Fixed issue with the generated file containing spaces at the end.

@irfansharif can you please review this?


[5.5] Fix typo in CHANGELOG-5.5.md

Small typo fix.

Is 419 even supported by all browsers yet?

No - but see discussion here: https://github.com/laravel/framework/pull/18728

Fair enough. :P


NO-JIRA: Update Konflux and perform migration

What this PR does / why we need it:
Replaces #4478:

cherry picked the commit in #4478
Removed BASE_IMAGES_DIGEST per the Konflux migration instructions - https://github.com/konflux-ci/build-definitions/blob/main/task/buildah/0.2/MIGRATION.md

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes N/A
Checklist

[ ] Subject and description added to both, commit and PR.
[ ] Relevant issues have been referenced.
[ ] This change includes docs.
[ ] This change includes unit tests.

/area ci-tooling

/lgtm


TypeError: 'method' object is not subscriptable

Run initial array detection
Refine detected arrays
Evaluate candidates
Traceback (most recent call last):
File "CRISPRidentify.py", line 249, in
run_over_one_file(complete_path_file, folder_result, pickle_folder)
File "CRISPRidentify.py", line 210, in run_over_one_file
flag_dev_mode=FLAG_DEVELOPER_MODE)
File "components/pipeline.py", line 30, in init
self._run_evaluation()
File "components/pipeline.py", line 60, in _run_evaluation
flag_dev_mode=self.flag_dev_mode)
File "components/module_evaluation.py", line 27, in init
self._extract_features_and_evaluate()
File "components/module_evaluation.py", line 65, in _extract_features_and_eval       uate
feature_vector = FeatureExtractor(0, crispr_candidate, list_features).extrac       t()[0]
File "components/components_evaluation.py", line 957, in extract
self.list_spacers).output()
File "components/components_evaluation.py", line 782, in init
self._compute_similarity_repeats_spacers()
File "components/components_evaluation.py", line 824, in _compute_similarity_r       epeats_spacers
self.similarity_score_repeats = self._compute_similarity_repeats()
File "components/components_evaluation.py", line 797, in _compute_similarity_r       epeats
x = kernel_matrix(graphs, r=3, d=4)
File "components/components_eden.py", line 158, in kernel_matrix
data_matrix = vectorize(graphs, **opts)
File "components/components_eden.py", line 136, in vectorize
return Vectorizer(**opts).transform(graphs)
File "components/components_eden.py", line 371, in transform
feature_rows.append(self._transform(graph))
File "components/components_eden.py", line 459, in _transform
graph = self._graph_preprocessing(original_graph)
File "components/components_eden.py", line 447, in _graph_preprocessing
graph = _edge_to_vertex_transform(original_graph)
File "components/components_eden.py", line 1005, in _edge_to_vertex_transform
graph.nodes[n]['node'] = True
TypeError: 'method' object is not subscriptable

fixed


Add method to delete entire dataset

There should be a method to remove a dataset from the Saved Sets list if it is no longer wanted. Possibly a little trash-can icon.

OOPS this already exists.


Villagers till branches, stones, and shipment box.

Villagers seem to treat branches, stones, and the shipment box as if its farmable and till it into farmland. I keep losing my shipment box because of it.

What on earth. I'll have to check the villager ai to see what they're doing...

Oh wait. Maybe this is that bug, that I fixed earlier too. Not what you think it is xD. <<< was confused because villagers don't till farmland. Is it wet soil? If so that's fixed.

The shipment crate was no where near water so it shouldn't have been wet.

Let me know if you run in to this issue again, I haven't. I've noticed some crops reappearing as dead though... >.>, unless I just forgot about them xD.


token_vec_300.bin is a w2v or fasttext format?

Thanks for your amazing Library
One simple question about your NER module
vec_path = '/home/lightsmile/NLP/embedding/char/token_vec_300.bin'
The vec bin is a w2v or fasttext file?
I already had my w2v pre-trained bin file because its size is only about 200M.
If fasttext bin file,  it is always about 1G , not too capable for production environment.
Thanks a lot.

the vec bin is w2v format, It's first line contains the num of words and the dimension of vectors.
In this example, the token_vec_300.bin is word vector file for chinese, and it's file size is about 67M.
In  this library, I use torchtext to load the word embedding file and It supports both two formats.
This project is just for practice, so if you want to use lightnlp for your project, maybe you need to fix some bug when using and modify the source code.

thanks a lot.
it works now..
one more question   .how to increase the batch size per epoch in the statement
ner_model.train(train_path, vectors_path=vec_path, dev_path=dev_path, save_path=model_path, log_dir=log_dir,)
Because i would like to run the training on google colab.
The default batch size is 128, i think colab can make it with 218 or above
Thanks a lot

the source code about batch_size in lightNLP/module.py at master · smilelight/lightNLP is:
train_iter = ner_tool.get_iterator(train_dataset, batch_size=DEFAULT_CONFIG['batch_size'])
config = Config(word_vocab, tag_vocab, save_path=save_path, vector_path=vectors_path, **kwargs)
bilstmcrf = BiLstmCrf(config)

there's a  bug there in the line of train_iter = ..., you need to set the batch_size in two place:

set batch_size in the train statement:

ner_model.train(train_path, vectors_path=vec_path, dev_path=dev_path, save_path=model_path, log_dir=log_dir, batch_size=218)

set batch_size in the line of train_iter = ...

train_iter = ner_tool.get_iterator(train_dataset, batch_size=218)

I'll fix the bug soon.