F# Record Serialization

@ctaggart has requested the ability to serialize/deserialize F# Record types, rather than .NET Class Types.

Proposed protobuf serializable Record definition
    type ETest =
        | Nada = 0
        | One = 1
        | Two = 2

    let ETestDefault = ETest.One  // NOTE: Non-zero default is only supported in Proto2

    type InnerSample = {
        id : int32
        name : string
        option : bool
        test : ETest
        packedFixed32 : uint32 list
        repeatedInt32 : int32 list
        }
        with
            static member Default = {
                id=0
                name=""
                option=false
                test=ETest.Nada
                packedFixed32=[]
                repeatedInt32=[]
            }

            member m.Serialize zcb                      = zcb |> serialize m
            member m.Deserialize zcb                    = zcb |> deserialize m
            member m.SerializeLengthDelimited zcb       = zcb |> serializeLengthDelimited m
            member m.DeserializeLengthDelimited zcb     = zcb |> deserializeLengthDelimited m

            member m.SerializeWithUnknowns unks zcb                 = zcb |> serializeWithUnknowns m unks
            member m.DeserializeWithUnknowns zcb                    = zcb |> deserializeWithUnknowns m
            member m.SerializeLengthDelimitedWithUnknowns unks zcb  = zcb |> serializeLengthDelimitedWithUnknowns m unks
            member m.DeserializeLengthDelimitedWithUnknowns zcb     = zcb |> deserializeLengthDelimitedWithUnknowns m

            member m.Serializer zcb =
                (m.id            |> dehydrateVarint 1) >>
                (m.name          |> dehydrateString 2) >>
                (m.option        |> dehydrateBool 3) >>
                (m.test          |> dehydrateDefaultedVarint ETestDefault 4) >>
                (m.packedFixed32 |> dehydratePackedFixed32 5) >>
                (m.repeatedInt32 |> dehydrateRepeated dehydrateVarint 6)
                <| zcb

            member m.DecoderRing =
                [
                    1, fun m rawField -> { m with id = rawField |> hydrateInt32 }
                    2, fun m rawField -> { m with name = rawField |> hydrateString }
                    3, fun m rawField -> { m with option = rawField |> hydrateBool }
                    4, fun m rawField -> { m with test = rawField |> hydrateEnum }
                    5, fun m rawField -> { m with packedFixed32 = rawField |> hydratePackedFixed32 }
                    6, fun m rawField -> { m with repeatedInt32 = (rawField |> hydrateInt32) :: m.repeatedInt32 }
                ]
                |> Map.ofList

            static member DecodeFixup m =
                { m with
                    packedFixed32 = List.rev m.packedFixed32
                    repeatedInt32 = List.rev m.repeatedInt32 }

This makes me really happy to see this!

Fixed in #39


The class "Doctrine\ODM\MongoDB\PersistentCollection" was not found in the chain configured namespaces App\Document"

Q
A

Version
1.2.9

Framework
Symfony 4

PHP
7.2

Support Question
I created a class to update the cart object. When I try to update an object that is already stored in the database, I get an error The class "Doctrine\ODM\MongoDB\PersistentCollection" was not found in the chain configured namespaces App\Document". This error occurs only with the cart object (And only during the object update. Creating a new object runs without problems), although there are similar objects in the project that do not cause such a problem.
In addition to this error, I discovered a few more:

This error occurs only when you try to update a field of type "EmbedMany". An attempt to update all other fields passed without errors. Also, any operations with any other objects go without problems.
When I tried to use QueryBuilder, I got the error Class 'Cart' does not exist

Cart class:
namespace App\Document;

use DateTime;
use Doctrine\ODM\MongoDB\Mapping\Annotations as MongoDB;

/**
 * @MongoDB\EmbeddedDocument()
 */
class CartItem
{
    /**
     * @MongoDB\Field(type="string")
     */
    private $productId;

    /**
     * @MongoDB\Field(type="integer")
     */
    private $quantity;

    // More fields ...

    /**
     * @return string
     */
    public function getProductId(): string
    {
        return $this->productId;
    }

    /**
     * @param string $productId
     * @return CartItem
     */
    public function setProductId($productId): CartItem
    {
        $this->productId = $productId;
        return $this;
    }

    /**
     * @return int
     */
    public function getQuantity(): int
    {
        return $this->quantity;
    }

    /**
     * @param int $quantity
     * @return CartItem
     */
    public function setQuantity(int $quantity): CartItem
    {
        $this->quantity = $quantity;
        return $this;
    }

    // More getters and setters ...
}

/**
 * @MongoDB\Document()
 */
class Cart
{
    /**
     * @MongoDB\Id
     */
    private $id;

    /**
     * @MongoDB\Field(type="string")
     */
    private $hash;

    /**
     * @MongoDB\Field(type="date")
     */
    private $date;

    // More fields ...

    /**
     * 'Bad' field
     * @MongoDB\EmbedMany(targetDocument="CartItem")
     */
    private $products;

    /**
     * @return mixed
     */
    public function getId()
    {
        return $this->id;
    }

    /**
     * @return string
     */
    public function getHash(): ?string
    {
        return $this->hash;
    }

    /**
     * @param string $hash
     * @return Cart
     */
    public function setHash(string $hash): Cart
    {
        $this->hash = $hash;
        return $this;
    }

    /**
     * @return DateTime
     */
    public function getDate(): DateTime
    {
        return $this->date;
    }

    /**
     * @param DateTime $date
     * @return Cart
     */
    public function setDate(DateTime $date): Cart
    {
        $this->date = $date;
        return $this;
    }

    // More getters and setters

    /**
     * @return CartItem[]|null
     */
    public function getProducts(): ?array
    {
        return $this->products;
    }

    /**
     * @param CartItem[] $products
     * @return Cart
     */
    public function setProducts(array $products): Cart
    {
        $this->products = $products;
        return $this;
    }
}

The class for updating an cart object is just a set of business logic (After checking, it turned out that it does not affect the error in any way, so I don’t show the logic) and standard object saving using:
$cart = $this->documentManager->getRepository(Cart::class)->find('some_id');
$cart->setProducts([/* CartItem[] */]);
$this->documentManager->flush();

I also attach the config file (config/packages/doctrine.yaml):
doctrine_mongodb:
    auto_generate_proxy_classes: true
    auto_generate_hydrator_classes: true
    connections:
        default:
            server: '%env(resolve:MONGODB_URL)%'
            options: {}
    default_database: '%env(resolve:MONGODB_DB)%'
    document_managers:
        default:
            auto_mapping: true
            mappings:
                App:
                    is_bundle: false
                    type: annotation
                    dir: '%kernel.project_dir%/src/Document'
                    prefix: 'App\Document'
                    alias: App

What could be the problem?

Are you sure that ->setProducts() gets only instances of CartItems? Offhand your types in entity are wrong, getProducts() should not be typed to array as ODM will use PersistentCollection after the Cart is loaded thus you should type against Doctrine\Common\Collections\Collection

Also just to be sure: you don't have Cart and CartItem in one file as the pasted code suggests?

Also just to be sure: you don't have Cart and CartItem in one file as the pasted code suggests?

No, both of these objects are in the same file.

Are you sure that ->setProducts() gets only instances of CartItems? Offhand your types in entity are wrong, getProducts() should not be typed to array as ODM will use PersistentCollection after the Cart is loaded thus you should type against Doctrine\Common\Collections\Collection

Once again checked the returned types of variables at each stage of logic. When retrieving from the database, $cart->getProducts() somehow belongs to the type [object] (Doctrine\\ODM\\MongoDB\\PersistentCollection: {}), and therefore an error occurs with the class not found when updating the cart object. I also looked at the Doctrine\Common\Collections\Collection interface documentation and found that there is a toArray() method that works fine with the PersistentCollection conversion to [ CartItem[] ]. In general, the problem is solved. Also found in the documentation for Doctrine ODM this topic about custom collections.
P.S. It turns out that the whole thing is in my inattention to details ¯\(ツ)/¯


Adding FrameWorks

I want to add react.js , django , flask , node in framework.
@shriya030  can i work on this issue under LGM-SOC21 .

Can i work on this issue?
I can add

@shriya030 can you please tell me why we have 2 AngularJS  is there any specific reason??
Can I remove one of them .

@shriya030 can you please tell me why we have 2 AngularJS is there any specific reason??
Can I remove one of them.

Pull the upstream and then make the required changes. I have made few changes in the Data folder. There is only one angularJS now. You can add other frameworks after that.

Ok


excel file

are we missing excel file?

what wanna say ?
Say it Clearly

Closing Due to inactivity


Cluster install step failed while running oc login command

After OSD cluster is created successfully, oc login command is failing

Noticed all the latest jobs failing at cluster install while running oc login command.
This is the PR that added the oc login command.
periodic-ci-CSPI-QE-MSI-rhods-addon-interop-v4.13-IIB-smoke-rosa-rhods-addon-baseline-fips
periodic-ci-CSPI-QE-MSI-rhods-addon-interop-v4.13-IIB-smoke-osd-rhods-addon-baseline-fips

As you mentioned in the previous title of this issue there seems to be oc login being called somewhere

It doesn't appear to be part of the cluster step that runs this automation from what I can tell.
We just need to make sure that when we call oc login that we never print the command itself to output as it exposes the cluster password.


Android compile Error

Describe the bug
[CXX1306] D:\workspace\wenet\runtime\android\app\src\main\cpp\CMakeLists.txt debug|arm64-v8a : CMake Error: The following variables are used in this project, but they are set to NOTFOUND.
Please set them or make sure they are set and tested correctly in the CMake files:
FBJNI_LIBRARY
linked by target "decoder" in directory D:/workspace/wenet/runtime/android/app/src/main/cpp/decoder
PYTORCH_LIBRARY
linked by target "decoder" in directory D:/workspace/wenet/runtime/android/app/src/main/cpp/decoder
To Reproduce
Steps to reproduce the behavior:

Environment:
Android Studio Hedgehog | 2023.1.1 Patch 2
Build #AI-231.9392.1.2311.11330709, built on January 19, 2024
Runtime version: 17.0.7+0-b2043.56-10550314 amd64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o.
Windows 10.0
GC: G1 Young Generation, G1 Old Generation
Memory: 2048M
Cores: 20
Registry:
external.system.auto.import.disabled=true
ide.text.editor.with.preview.show.floating.toolbar=false

Android SDK Build-Tools: 30.0.3
NDK: 22.0.7026061
Android SDK Command-line Tools: 4.0.0
CMake: <IP_ADDRESS>88404
Android Emulator
Android SDK Platform-tool
Operation:Win10
Wenet: newest master

@pengzhendong would you please help on the problem?

试着在 buid.gradle 中加 nameapace

试着在build.gradle 中加上 namespace

I'm getting the same issue. It is also reported in #2615
./gradlew --version

------------------------------------------------------------
Gradle 7.5
------------------------------------------------------------

Build time:   2022-07-14 12:48:15 UTC
Revision:     c7db7b958189ad2b0c1472b6fe663e6d654a5103

Kotlin:       1.6.21
Groovy:       3.0.10
Ant:          Apache Ant(TM) version 1.10.11 compiled on July 10 2021
JVM:          11.0.24 (Ubuntu 11.0.24+8-post-Ubuntu-1ubuntu322.04)
OS:           Linux 6.9.3-76060903-generic amd64


TypeScript extensions are not set up to pass type-checking

When you create a TypeScript extension, you do not get a tsconfig.json file that is configured to handle the project’s source code. There is also no type-check or tsc NPM script, which are generally included in projects (so you can run npm run type-check/ yarn type-check).
There were a few type-checking issues I encountered when I added a minimally-working tsconfig.json, and I will open issues for us on the checkout side to resolve those. Here's the TSConfig I used:
{
  "compilerOptions": {
    "strict": true,
    "jsx": "react",
    "esModuleInterop": true,
    "lib": ["esnext", "dom"],
    "rootDir": "src",
    "outDir": "build/typescript",
    "declaration": true,
    "declarationMap": true,
    "emitDeclarationOnly": true
  }
}

As an aside, the declared TypeScript version is also quite old relative to what actually gets installed (^4.1.0 is installed as 4.6.3 for me today).

There were a few type-checking issues I encountered when I added a minimally-working tsconfig.json, and I will open issues for us on the checkout side to resolve those. Here's the TSConfig I used:

Does the same configuration apply to all the extension types?


python3Packages.scrapy: disable flaky test

Motivation for this change
ZHF #122042
This test will fail if /tmp/foobar already exists owned by a different user. Technically only observed to be a problem on darwin but in theory any system not using namespaced /tmp for their builder could run into this.
Issue opened upstream https://github.com/scrapy/scrapy/issues/5157
Edit: ok, so it looks like scrapy has been broken on master since the branch, but the backport of this is needed for 21.05.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[x] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Added a release notes entry if the change is major or breaking
[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 124153 at 486902ac run on x86_64-linux 1

8 packages failed to build:

python38Packages.scrapy
python38Packages.scrapy-deltafetch
python38Packages.scrapy-fake-useragent
python38Packages.scrapy-splash
python39Packages.scrapy
python39Packages.scrapy-deltafetch
python39Packages.scrapy-fake-useragent
python39Packages.scrapy-splash

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement. Does something look off? Please file an issue or reach out on IRC.

seem slike a dependency needs to be fixed first:
builder for '/nix/store/n14g214sddszkp4a5pzdhc5nhsp8wqwi-python3.8-parsel-1.6.0.drv' failed with exit code 1; last 10 log lines:
  FAILED tests/test_selector.py::SelectorTestCase::test_replacement_null_char_from_body

@jonringer sigh, well.. it wasn't broken when I did this

looks like it's related to the libxml2 bump, which is known to have caused several regressions
d01a4e3fe99cdc9f4015e741edfd3c77a5d90a37 is the first bad commit
commit d01a4e3fe99cdc9f4015e741edfd3c77a5d90a37
Author: Jan Tojnar<EMAIL_ADDRESS>Date:   Thu May 13 18:11:20 2021 +0200

    libxml2: 2.9.10 → 2.9.12

    https://mail.gnome.org/archives/xml/2021-May/msg00000.html

    CVE-2021-3541

 pkgs/development/libraries/libxml2/default.nix | 28 +++-----------------------
 1 file changed, 3 insertions(+), 25 deletions(-)
bisect run success


lldb-server needs to be installed in $PATH

What version of Delve are you using (dlv version)?

$ dlv version
Delve Debugger
Version: 1.0.0-rc.1
Build: $Id: b6077a6a35c48a31716aad2ad3fdf77bbdf70abd $

What version of Go are you using? (go version)?

$ go version
go version go1.9.1 darwin/amd64

What operating system and processor architecture are you using?

$ sw_vers
ProductName:	Mac OS X
ProductVersion:	10.12.3
BuildVersion:	16D32

What did you do?

$ go get -u github.com/derekparker/delve/cmd/dlv
$ dlv exec k6 run samples/http_2.js

What did you expect to see?
The Go debugger

What did you see instead?

could not launch process: exec: "lldb-server": executable file not found in $PATH

You either need lldb-server in $PATH or debugserver at /Library/Developer/CommandLineTools/Library/PrivateFrameworks/LLDB.framework/Versions/A/Resources/debugserver, which should be installed with xcode command line tools.

This error can show up for Mac users using delve of version 0.12.2 or above. Not sure why, but doing a xcode-select --install has solved the problem for users who have seen this issue.

in here
this fix my issue.

This isn't really a Delve issue but perhaps the error message could be improved.

On macOS with Xcode, without installing a standalone CLT, I used
sudo mkdir -p /Library/Developer/CommandLineTools/Library/PrivateFrameworks/LLDB.framework/Versions/A/Resources/
sudo ln -s "/Applications/Xcode.app/Contents/SharedFrameworks/LLDB.framework/Versions/A/Resources/debugserver" /Library/Developer/CommandLineTools/Library/PrivateFrameworks/LLDB.framework/Versions/A/Resources/debugserver

Would be a nice enhancement. I am using dlv through JetBrains goland IDE and thought the error was wrong since CLT is updated/managed when Xcode is installed.
@unknownzerx since your comment the line has changed from 370 to 302 in gdbserver.go
https://github.com/go-delve/delve/blob/aa0b4eb180124c68a5dbd5389d6d30734735129d/pkg/proc/gdbserial/gdbserver.go#L302

On macOS with Xcode, without installing a standalone CLT, I used
sudo mkdir -p /Library/Developer/CommandLineTools/Library/PrivateFrameworks/LLDB.framework/Versions/A/Resources/
sudo ln -s "/Applications/Xcode.app/Contents/SharedFrameworks/LLDB.framework/Versions/A/Resources/debugserver" /Library/Developer/CommandLineTools/Library/PrivateFrameworks/LLDB.framework/Versions/A/Resources/debugserver

It is hard-coded in gdbserver.go around L370, I think it should also find the executable come with Xcode.

This worked for me!! Many thanks.

On macOS with Xcode, without installing a standalone CLT, I used
sudo mkdir -p /Library/Developer/CommandLineTools/Library/PrivateFrameworks/LLDB.framework/Versions/A/Resources/
sudo ln -s "/Applications/Xcode.app/Contents/SharedFrameworks/LLDB.framework/Versions/A/Resources/debugserver" /Library/Developer/CommandLineTools/Library/PrivateFrameworks/LLDB.framework/Versions/A/Resources/debugserver

It is hard-coded in gdbserver.go around L370, I think it should also find the executable come with Xcode.

Good stuff, thanks


HBASE-28683 Only allow one TableProcedureInterface for a single table…

… to run at the same time for some special procedure types (#6046)
Signed-off-by: Viraj Jasani<EMAIL_ADDRESS>(cherry picked from commit 50a495f735b88f933311dd9fff7d6ce9364298a6)

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 45s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
hbaseanti
0m  0s

Patch does not have any anti-patterns.

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m  8s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m  2s

branch-2 passed

+1 :green_heart:
compile
3m 13s

branch-2 passed

+1 :green_heart:
checkstyle
0m 50s

branch-2 passed

+1 :green_heart:
spotbugs
1m 57s

branch-2 passed

+1 :green_heart:
spotless
0m 48s

branch has no errors when running spotless:check.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m  2s

the patch passed

+1 :green_heart:
compile
3m  9s

the patch passed

+1 :green_heart:
javac
3m  9s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 11s

The patch passed checkstyle in hbase-procedure

+1 :green_heart:
checkstyle
0m 36s

hbase-server: The patch generated 0 new + 1 unchanged - 2 fixed = 1 total (was 3)

+1 :green_heart:
spotbugs
2m 16s

the patch passed

+1 :green_heart:
hadoopcheck
15m 33s

Patch does not cause any errors with Hadoop 2.10.2 or 3.3.6 3.4.0.

+1 :green_heart:
spotless
0m 45s

patch has no errors when running spotless:check.

_ Other Tests _

+1 :green_heart:
asflicense
0m 23s

The patch does not generate ASF License warnings.

38m 57s

Subsystem
Report/Notes

Docker
ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6084/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6084

Optional Tests
dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless

uname
Linux 528e31eff16f 5.4.0-186-generic #206-Ubuntu SMP Fri Apr 26 12:31:10 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 5141f84b659d72404d99faa12565e455a0782dd4

Default Java
Eclipse Adoptium-11.0.23+9

Max. process+thread count
79 (vs. ulimit of 30000)

modules
C: hbase-procedure hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6084/1/console

versions
git=2.34.1 maven=3.9.8 spotbugs=4.7.3

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 45s

Docker mode activated.

-0 :warning:
yetus
0m  5s

Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 10s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 11s

branch-2 passed

+1 :green_heart:
compile
1m 10s

branch-2 passed

+1 :green_heart:
javadoc
0m 39s

branch-2 passed

+1 :green_heart:
shadedjars
5m 55s

branch has no errors when building our shaded downstream artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m  6s

the patch passed

+1 :green_heart:
compile
1m 11s

the patch passed

+1 :green_heart:
javac
1m 11s

the patch passed

+1 :green_heart:
javadoc
0m 38s

the patch passed

+1 :green_heart:
shadedjars
5m 55s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

+1 :green_heart:
unit
1m 31s

hbase-procedure in the patch passed.

+1 :green_heart:
unit
205m 34s

hbase-server in the patch passed.

234m 12s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6084/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6084

Optional Tests
javac javadoc unit compile shadedjars

uname
Linux 957e76795c1b 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 5141f84b659d72404d99faa12565e455a0782dd4

Default Java
Eclipse Adoptium-17.0.11+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6084/1/testReport/

Max. process+thread count
4391 (vs. ulimit of 30000)

modules
C: hbase-procedure hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6084/1/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 20s

Docker mode activated.

-0 :warning:
yetus
0m  5s

Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m  9s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 38s

branch-2 passed

+1 :green_heart:
compile
1m 34s

branch-2 passed

+1 :green_heart:
javadoc
0m 53s

branch-2 passed

+1 :green_heart:
shadedjars
8m 33s

branch has no errors when building our shaded downstream artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 18s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 58s

the patch passed

+1 :green_heart:
compile
1m 10s

the patch passed

+1 :green_heart:
javac
1m 10s

the patch passed

+1 :green_heart:
javadoc
0m 41s

the patch passed

+1 :green_heart:
shadedjars
5m 31s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

+1 :green_heart:
unit
1m 28s

hbase-procedure in the patch passed.

+1 :green_heart:
unit
221m 47s

hbase-server in the patch passed.

253m 50s

Subsystem
Report/Notes

Docker
ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6084/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6084

Optional Tests
javac javadoc unit compile shadedjars

uname
Linux 7286a15ab513 5.4.0-182-generic #202-Ubuntu SMP Fri Apr 26 12:29:36 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 5141f84b659d72404d99faa12565e455a0782dd4

Default Java
Eclipse Adoptium-11.0.23+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6084/1/testReport/

Max. process+thread count
4545 (vs. ulimit of 30000)

modules
C: hbase-procedure hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6084/1/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 44s

Docker mode activated.

-0 :warning:
yetus
0m  6s

Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 10s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 13s

branch-2 passed

+1 :green_heart:
compile
0m 59s

branch-2 passed

+1 :green_heart:
javadoc
0m 39s

branch-2 passed

+1 :green_heart:
shadedjars
4m 54s

branch has no errors when building our shaded downstream artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 23s

the patch passed

+1 :green_heart:
compile
1m  0s

the patch passed

+1 :green_heart:
javac
1m  0s

the patch passed

+1 :green_heart:
javadoc
0m 38s

the patch passed

+1 :green_heart:
shadedjars
4m 52s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

+1 :green_heart:
unit
1m 21s

hbase-procedure in the patch passed.

+1 :green_heart:
unit
241m 14s

hbase-server in the patch passed.

267m 28s

Subsystem
Report/Notes

Docker
ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6084/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6084

Optional Tests
javac javadoc unit compile shadedjars

uname
Linux 4df76d6528f6 5.4.0-186-generic #206-Ubuntu SMP Fri Apr 26 12:31:10 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 5141f84b659d72404d99faa12565e455a0782dd4

Default Java
Temurin-1.8.0_412-b08

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6084/1/testReport/

Max. process+thread count
4298 (vs. ulimit of 30000)

modules
C: hbase-procedure hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6084/1/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.


Update website-monitoring.md

at  cleaning resources explanation hard coded  resource group name. probably mark
that you should delete exactly group you used for  resources

@bergano65 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Hi @mrbullwinkle - Could you indicate whether this PR can be merged? Thanks!

#sign-off


[v2] Unit testing not compatible with node v18+

When trying to install package for unit testing on node v18 or node v20, there is an error during npm install

Fixed in https://github.com/llaske/sugarizer/pull/1626


Support Adapters that Interact with Services

Resolves #453
An issue with having an Adapter that interacts with third  party services is a third party service may have its own authentication scheme. That scheme might involve passing a token through Tiled from the client as a password, and then when the Adapter interacts with the third party service, the it somehow needs access to that token from within the same user session.
This PR implements two parts of this.

It adds the ability for a username/password Authenticator to return a state object back to Tiled.  Tiled stores that dictionary in the session row of the auth database.

We will provide a mechanism for Adapters to have access to this state.

The initial commits address the first case but not yet the second, so this PR is preliminary.

I like this.
We do need a database revision for this, to support migration.
https://github.com/bluesky/tiled/blob/3127d98cfaae36d62588feca25e3fae017d3f009/tiled/database/alembic_utils.py#L62-L74

I like this.
We do need a database revision for this, to support migration.
https://github.com/bluesky/tiled/blob/3127d98cfaae36d62588feca25e3fae017d3f009/tiled/database/alembic_utils.py#L62-L74

Interesting. I would have thought that SQLAlchemy would gracefully handle a new column with no data changes.

Fixed errors in LDAP test on CI
Manually this against the OIDC example, which we do not run on CI, and resolved some breakage. (It would be nice if we could test OIDC on CI. I'm not sure how that would work, with a web browser involved in the flow, but people must have some way to do this.)
Placed session state in JWT, where get_session_state looks for it.

Finally, I changed:
    entry.with_session_state(state)

to
    entry = entry.with_session_state(state)

The adapter may do:
class Adapter:
    ...

    def with_session_state(self, state):
       self.state = state  # mutate!
       return self

but now it may also do:
class Adapter:
    ...

    def with_session_state(self, state):
        return NewInstanceOfAdapterOrSomething(...)

which seems safer and better to me offhand. Anyway, we have both options now.
The only remaining issue is that typing.Protocol is not available in Python 3.7. This may be a signal to just drop 3.7, as it is end-of-life anyway. (Security support ended two weeks ago.)


implement PartialEq<str> for Bound<'py, PyString>

Idea spurred by #4020 and also what I've just been doing in #4196.
This PR implements comparison between Python str and Rust &str by using:

The new PyUnicode_EqualToUTF8AndSize on Python 3.13,
fallback to converting to a Rust &str and doing equality that way on older versions.

PyUnicode_EqualToUTF8AndSize can never fail, so similarly the fallback implementations just return false on error getting UTF8 data out.

Thanks for the approval @LilyFoote!
I just realised: there's a bit edge case where: what about when the Bound<'py, PyString> contains a subclass of str? That subclass can override inequality, and might not compare equal with strings (although that would be very weird).
What should we do then? One option is to make these implementations return false for subclasses (e.g. do an is_exact_instance_of::<PyString>() check).
In PyUnicode_EqualToUTF8 there is no subclass checking - https://github.com/python/cpython/blob/42351c3b9a357ec67135b30ed41f59e6f306ac52/Objects/unicodeobject.c#L10789
I'm inclined to proceed with this as-is, but I would also be glad to hear folks' opinions as there is a slight possibility this is a footgun which leads to surprises in the subclass edge case.

I think subclassing built-in types like str is fairly well known to have edge-cases and oddities like this. Maybe all we need here is a note in the docs.

I think subclassing built-in types like str is fairly well known to have edge-cases and oddities like this. Maybe all we need here is a note in the docs.

True! I think to that point, it's very likely that users would write bound_str.to_str()? == "rust string" which is just as wrong for subclasses as what we implement here. So documenting gotcha on the trait implementations as you suggest and moving on might be fine.
Any other opinions before we proceed?

Thanks both! I've added documentation and will proceed to merge 👍


added prettier test for Typescripts

issue №132

everything is done

It's sad what we can't make it run in parallel (I tryed too)
Maybe we can speed it up?
We can make it to use the docker image what already have node installed, here is example:

So we will not need to install it every time, we are using node:14-alpine so it should be fine to use it in pipeline
Also we should break .ts code and check what pipeline will fail after it
We are don't really want making python devs to wait extra minute before their code check, let's try to make it as fast as we can

In pipeline we have a message about
npm WARN exec The following package was not found and will be installed<EMAIL_ADDRESS>I think we should install our packages from repo and use it
Please check
typescript-app/package.json

Also would be great after you will done testing change places for ts and python, because the most of contributors are using python and let's no make them to wait them for ts check


Add readBlock to objectForKey & writeBlock to setObject:forKey:

Generally this is a merge of https://github.com/tumblr/TMCache/pull/30/commits to PINCache.
Read & Write blocks are quite useful when object isn't compatible with NSCoding or manual action needs to be performed

Thanks for the contribution!  Would you be willing to split this up into multiple pull requests (e.g. one that adds nonnull, etc. attributes to the current code, one that adds the new read/write blocks, etc.)?  That would make it easier to review the functional changes on their own.

@jparise should I remove nullability attributes and then make a diff branch with them?
What is the best way to do it?

Yes, that would be my preference.  @garrettmoon is the primary maintainer, though, so let's see what he says.

Hi Dima,
Thanks so much for the contribution!
I agree with Jon that splitting this up into multiple pull requests will make it easier to review and merge in. If you're willing to do that, it would be greatly appreciated!
On Mon, Jun 8, 2015 at 9:55 AM, Jon Parise<EMAIL_ADDRESS>wrote:

Yes, that would be my preference.  @garrettmoon is the primary maintainer, though, so let's see what he says.
Reply to this email directly or view it on GitHub:
https://github.com/pinterest/PINCache/pull/6#issuecomment-110072377

I'll do my best tomorrow's morning ;)

Sorry, @garrettmoon, I'm a bit busy atm, so waiting for the weekends

Hey, no worries!

Guys, having a really crazy pre-release week, sorry one more time

@garrettmoon I reverted nullability attributes, check it!

Thanks! I'll give this another look by EOD Friday.

This looks good! Aside from the few nits above, there's one other thing I'd request: many of the changes are whitespace changes that seem unnecessary and conflict with the existing whitespace patterns. Do you mind cleaning this up?

@garrettmoon
Check out my fixes!

@garrettmoon
Aside this PR can you also check other branches, that I have, maybe some of them can be useful for master repo:
feature/extension - saves key extension to disk, when you're passing key like "key.png". This one is useful, when you're using QLPreviewController - it can't identify object content-type without extension.
feature/object_at_path - allows you to set object at path. This is useful, when object is relatively big, so instead of explicit read and write NSFileManager used to simply copy / move file.
feature/trim_by_keys - this one is quite specific. It allows you to trim a defined set of keys to some date (heavily used in my current project cleanup of unused key with specific criteria)

@dimazen Nice! And if you feel that the features would be widely useful to others, feel free to submit pull requests. One more question and I think we're there!

I think I dropped the ball on this. The last question was, can you reformat your patch so it doesn't include all the whitespace changes? I know this is a pain, but it will help keep our git history. Thank you in advance!

Argh, I've totally forgot about it, sure I will with no questions ;)

Just to keep things clean, I'm going to close this. Feel free to reopen if you'd like to continue working on it.

Or rather, let me know if you'd like to reopen :)


Work Estimate / Blockers for References (gradient accumulation and convergence understanding)

Reference owners please update yellow cells with a work estimate (in weeks/days) or a blocking issue that needs to be resolved.
https://docs.google.com/spreadsheets/d/1W8L8SBIrgbJ_f_-2hUt8SqLNkzAvsKNkQ0A6pKWz9_8/edit#gid=0

SWG:
Will request reference owners add status updates next week to the spreadsheet.

We had requested a status update in this spreadsheet:
https://docs.google.com/spreadsheets/d/1W8L8SBIrgbJ_f_-2hUt8SqLNkzAvsKNkQ0A6pKWz9_8/edit#gid=0
We will touch base next week:

Does it need gradient accumulation?
Status on adding gradient accumulation?
Convergence Curve - https://drive.google.com/drive/u/0/folders/1sDmlkLyehFcQWEEW8IhQUbLafaPhTE-9

Convergence Curves:
Run 2x the required runs for submission spread across the historically min submitted batch size and max submitted batch sizes -- running a powers of 2 start at min going to max.

In addition to gradient accumulation and convergence curves, we also need to update logging to the latest v0.7 (or v1.0?) spec.  I've added a column in the status spreadsheet for this.

In addition to gradient accumulation and convergence curves, we also need to update logging to the latest v0.7 (or v1.0?) spec.  I've added a column in the status spreadsheet for this.

From this week's meeting:

Tracking spreadsheet: https://docs.google.com/spreadsheets/d/1W8L8SBIrgbJ_f_-2hUt8SqLNkzAvsKNkQ0A6pKWz9_8/edit?usp=sharing
Reminded group that we plan to freeze on 1/22
Review existing pull requests https://github.com/mlcommons/training/pulls, all are to be resolved in the next 2 weeks
If you lack permissions to contribute, please update
We should make a label to indicate which PRs are going to impact the references
Follow up over email on status of Minigo
In progress work for every reference.
New action item for all reference owners to fix logging, not needed by freeze but we want shortly after. [AI JohnT] Email to be sent to owners. (sent on 1/7/21)
Want convergence curves by freeze deadline. Let others know if you need help with this.

From this week's meeting:

Tracking spreadsheet: https://docs.google.com/spreadsheets/d/1W8L8SBIrgbJ_f_-2hUt8SqLNkzAvsKNkQ0A6pKWz9_8/edit?usp=sharing
Reminded group that we plan to freeze on 1/22
Review existing pull requests https://github.com/mlcommons/training/pulls, all are to be resolved in the next 2 weeks
If you lack permissions to contribute, please update
We should make a label to indicate which PRs are going to impact the references
Follow up over email on status of Minigo
In progress work for every reference.
New action item for all reference owners to fix logging, not needed by freeze but we want shortly after. [AI JohnT] Email to be sent to owners. (sent on 1/7/21)
Want convergence curves by freeze deadline. Let others know if you need help with this.


[ZF2] \Zend\EventManager\SharedEventManager performance issue

Hi,
Can anybody tell me why array_key_exists function is used over and over in the code of SharedEventManager class instead of isset, simply? Naturally I talk about version 2 (I see that this class is implemented otherwise in version 3). Wouldn't it be better to use isset function for better performance and for better logic in the code?

@peterr send a patch: tests are in place to see if it will work anyway :-)

Is the legacy branch from https://github.com/zendframework/zend-eventmanager correct place to do that?

@peterr yep

But I see that the master branch includes yet version 3. Is there a special branch for version 2 in the repository? I talk about version 2 of the EventManager component. Version 3, as I see, is implemented otherwise and don't have this problem any more.

@peterr

master = current version (stable, in this case 3.0.x)
develop = next version (new features/unstable, in this case 3.1.x or 4.x, depending on what will happen)
legacy = previous version (2.x, in this case)

This issue has been moved from the zendframework repository as part of the bug migration program as outlined here - http://framework.zend.com/blog/2016-04-11-issue-closures.html
New issue can be found at: https://github.com/zendframework/zend-eventmanager/issues/29


*: fix go mod tidy and clean up some dependencies

What problem does this PR solve?
The problem of #1329 is caused by our cleanup shell script. After we introduce go module, the original shell script will delete vendor/modules.txt which leads to #1329.

The vendor/modules.txt file, which describes how each entry in go.mod file corresponds to which subdirectory within vendor/

What is changed and how it works?
This PR fixes the problem which we can not use go mod tidy and cleans up some unused dependencies. Closes #1329.
Check List
Tests

No code

PTAL @disksing @nolouch

We will need this in other repos as well (tidb-operator and tidb come to mind).

@gregwebs AFAIK, tidb does not use vendor for managing dependencies anymore. As for tidb-operator, it doesn't have this script.

/run-all-tests


Markdown Previewer

I would like to add under Web Development, Markdown Previewer which takes the markdown code and renders HTML element. Please assign me this under GSSOC'2024

@AmrutaJayanti Explain in details

As you enter the markdown code, it renders the HTML element. Its beginner friendly. It helps beginners to acustomate for writing markdown codes.


Bug fix:  Allow empty multi instance resources

The client fails to register currently if a multi instance resource is created without any instances.  This is allowed by the spec, in fact, it makes sense.  The client may want to create a multi instance resource with no initial instances so that the server can PUT the resource instances later.  (For example, our use case is just a simple place for our web team to store information specific to the IoT node in STRING format)

[x] I confirm this contribution is my own and I agree to license it with Apache 2.0.
[x] I confirm the moderators may change the PR before merging it in.
[x] I understand the release model prohibits detailed Git history and my contribution will be recorded to the list at the bottom of CONTRIBUTING.md.
Summary of changes

Thanks, looks like a valid fix. Can you check the boxes in the template, and we will take a look how to patch this.

Ok, checked the boxes, and completed the fix with another commit.

Hi @Alex-EEE . @teetak01  assinged me to take this fix into our internal repository. After reviewing changes here are how those to methods will look like after this
M2MNsdlInterface::create_nsdl_resource_structure
    if (res) {         // if there are multiple instances supported         if (multiple_instances) {             const M2MResourceInstanceList &res_list = res->resource_instances();             if (!res_list.empty()) {                 M2MResourceInstanceList::const_iterator it;                 it = res_list.begin();                 for ( ; it != res_list.end(); it++ ) {                     success = create_nsdl_resource((*it));                     if (!success) {                         tr_error("M2MNsdlInterface::create_nsdl_resource_structure - instance creation failed");                         return false;                     }                 }             }         }         // Register the main Resource as well along with ResourceInstances         success = create_nsdl_resource(res);     }
M2MTLVDeserializer::deserialize_resource_instances
`        if(!found) {
if(M2MTLVDeserializer::Post == operation) {
error = M2MTLVDeserializer::NotAllowed;
} else if(M2MTLVDeserializer::Put == operation) {
// Create a new Resource Instance
M2MResourceInstance *res_instance = resource.get_parent_object_instance().create_dynamic_resource_instance(
resource.name(),
"",
resource.resource_instance_type(),
true,
til._id);
if(res_instance) {
res_instance->set_operation(M2MBase::PUT_ALLOWED);
}
}
    }`


Create Players from Audio Element from HTML

Hi,
Question:
Tell me if I am wrong, but at this point, all datas are generated from a the jquery file.
Would it be possible to tweak it so that it is able to auto-detect audio element on HTML (or maybe a div or something else with data attributes) and put them this player ?
The ultimate goal would be to be able to auto create player from the html without touching the JS, and if possible, creating some kind of wordpress plugin with wavesurfer.
The fact all infos came from the jquery make it a bit difficult to integrate with wordpress from post content.
Thanks for the infos !

Good idea, we should add automatic HTML initialization.

Oh, I'm very happy that you are interested by this :)
This would be wonderful and so much easier ton integrate in post content.
Idealy, the markup should be abble to determine some customization (such as the plugins to used for a certain file player for exemple - multi waveforms, etc...), and it would fall back to some default settings if nothing provided.
this is a lot of work in perspective but IMHO it really worth it.
thanks for you interest in this, can't wait to hear more about it !

VERY glad to read 'HTML initialization" -- I use video.js for video and am committed to wavesurfer.js ... and, someday figuring out (or benefiting from new HTML initialization:-) HOW I may have an audio player in every article (html/css/js only pages) without putting a script for each player etc. etc.
So far I've been effectively stopped as the few examples I've found in 'issues' posts seem to only hint at some elegant method.
I'm relentlessly optimistic - and yet, IS HTML initialization the key?
For video.js, of course, I simply put HTML calling the .mp4/.ogg/.webm and done.
Is it possible, anytime now *-) something like this will appear, allowing, what must be 1000's of us hopefuls, to use HTML, call the audio file, and have a different waveform in each article.
Again, me, i use just plain html/css/js -- no CMS or similar.
In absolutely any event great thanks for all the brilliances.

closed ? is that integrated or don't you want to implement this anymore ?

WOW - I went to:
@katspaugh 	add html init; resolves #524
as noted above.
Then found a totally new file i believe:
32  src/html-init.js
And LOTS of changes in other places.
Terribly sorry to have to ask.
Can we find out how to use the new feature?
(may be an update at some point in readme i figure)
AMAZING body or work. I'm certain we all appreciate the effort and knowledge and creativity,  and ...ummm, patience it takes!

Here's a codepen with a demo, guys: http://codepen.io/katspaugh/pen/WQXzpB?editors=10
(Didn't post it at once because had to to go right after I commited it.)

Let me say: WHOA WHOA WOOHOO!!!!   Changes Everything from my view. Better stop writing as I could ramble on!  HUGE Gratitude.

@katspaugh
That's very promising, seems simple to integrate !
few questions : are you sure wavesufer markup won't be a flag as invalid HTML 5 properties ? It could be bad for SEO.
Could some styling be applied by CSS ?
Anyway, very nice to see this update, it is definitely a huge thing :)
@tweed
You are welcome ^^

Thanks for the motivation @tweed! :thumbsup:
@X-Raym <wavesurfer> is not a valid tag, yes. You think, it can be important for SEO? We can change it to match any element with a data-wavesurfer attribute.
You can apply CSS, yes.

Thanks for you amazing work with this!
Will this change perhaps make it possible to use wavesurfer with meteorjs? Never managed to get it to work before..

@katspaugh
ok so I did a bit more research on custom tags in HTML5 and it seems possible to use wavesurfer tag without problem, as it is part of W3C recommandations.
http://w3c.github.io/webcomponents/spec/custom/
that said, it seems that it is just 'draft'.
another great article on that:
http://www.html5rocks.com/en/tutorials/webcomponents/customelements/?redirect_from_locale=fr
if after taking a look at this article it seems possible to make  valid, so yes, go for it, it is a nice idea :)
else, maybe just using a standard  is enough.
thanks for your consideration !
ps: could the html markup be able to trigger wavesurfer module such as the split waveforms for multichannel audio ?

ould the html markup be able to trigger wavesurfer module such as the split waveforms for multichannel audio ?

Multichannel audio is not a module, it's just a parameter. As I said, all parameters are supported as data-attributes.

@katspaugh
ok, that is perfect :D good job on this feature, it will be so easier to implement :P

@katspaugh
Hi,
Does the HTML validation still need the wavesufer tag or is their now a more W3C compliant solution ? :)

People interested in this can take a look at this WordPress integration project:
WaveSurfer-WP — A WordPress Integration for WaveSurfer

Does the HTML validation still need the wavesufer tag or is their now a more W3C compliant solution ? :)

@X-Raym yep. I still think it's nicer than having a div with some attribute. Besides, wavesurfer.js creates wave and region tags inside anyway, and I would prefer to keep things as they are.

[QUOTE]
Here's a codepen with a demo, guys: http://codepen.io/katspaugh/pen/WQXzpB?editors=100
[END QUOTE]
Sorry to be stumped at such a beginner's level.
The codepen quoted above works. There's no JS or CSS in the codepen. How is it running?
I am only needing to create the most basic WAV or mp3 player multiple times on single page website.
Each blog entry on the single page is within a DIV.
HUGELY great is the new enhancement: 'Create Players from Audio Element from HTML"
I put THIS in HEAD of single webpage
    <script src="wavesurfer.min.js"></script>
	<script src="html-init.js"></script>

    <link rel="stylesheet" href="style.css" />
    <link rel="stylesheet" href="ribbon.css" />

THEN I thought I could add THIS to each DIV and get multiple players

May I ask:
what's the minimum i need to have on the single page of HTML/CSS to have a different wav/mp3 in each DIV (each div is a separate blog entry)
DO I need to add the "controls" HTML in EACH DIV?
AND/OR do i need to add a script to the bottom of the single webpage?
BASICALLY I'm trying to use the HTML initialize and play enhancement with as little repeated code as possible. A different wavesurfer instance in each DIV - all on one single HTML/CSS page.
Sorry to be at the point I need to ask.
Looked everywhere i could for examples.
Tried the usual dozens of attempts.

@tweed
When building WaveSurfer-WP, I realized that we could create WaveSurfer elements from HTML, but using the regular WebAudio just like regular wavesurfer-js initialization with a bit of jQuery.
To make this work with several players, I recreate all buttons elements and the JS initiliazer.
(oh yes and codepen don't need to include scripts as you did, CSS and JS are automatically loaded from the different panels, and external files like wavesurfer-js are put in the settings as external resources).
So, if you need a HTML markup + initializer demo,
Maybe take a look at this pen
This is what I have done for WaveSurfer-WP so far.
Contrary to standard HTML init, it doesn't recognize all data attributes, but it has smoother cursor refresh rate.
Feel free to mod it to your needs !

WOW  X-Raym !! thank YOU
I'm usually able to stumble upon the answer through searches and attempts - not so with wavesurfer - so far.
Before posting and asking here I had already downloaded and looked at your fab WP plugin and also had looked at your pen.
Having failed with 'html-init.js' before posting the above, upon seeing your codepen's jquery code, and your plugin's PHP code I only did a quick look.  My single page HTML/CSS/JS blog does not use jquery, though I will be doing a WP effort as well and your plugin will be FANTASTIC. I'll be in good company there *-) nice!
Did a few effort to finding out what the external resources are for codepens that don't show them. no luck.
Firstly: I thought that, if I could find out what JS and CSS was behind: http://codepen.io/katspaugh/pen/WQXzpB?editors=100
i'd know if I'm on the right track in hoping to have as minimal/vanilla as possible multi-waversurfer instances on one simple HTML/CSS/JS page.
'html-init.js' would likely be best to start with as i think I'll need some of the attributes.
Secondly, my wishful thinking is:

put wavesurfer.js and html-init.js in HEAD of single HTML/CSS/JS page.

perhaps some CSS needs to be in the HEAD as well - ribbon.css? bottom part of wavesurfer's style.css?

each blog post has 3 DIVs - one for text and video, and audio. Perhaps needed would be a single bit of JS script on the page at the bottom with the other JS scripts.

leave off the button HTML code (at least NOT have to have it in EVERY DIV) - and leave off any bootstrap as I only want a basic non-styled PLAY/PAUSE single button and the waveform.

super minimal -  i thought possibly the HTML initialization enhancement would allow very little code needed in each audio DIV - as, there are many many blog posts on the single HTML page.
wavesurfer
data-wave-color="violet"
data-progress-color="purple"
data-url="media/blogpost1.mp3">
/wavesurfer>
wavesurfer
data-wave-color="violet"
data-progress-color="purple"
data-url="media/blogpost2.mp3">
/wavesurfer
NOTE:  the < and the > get deleted from the above, around 'wavesurfer'

External resources on codepen are under the (Settings)[https://monosnap.com/file/rUsyln3cAKiS3fZXYrX3FEWU2ecdb3.png] panel.
You only need the wavesurfer.min.js file. These are the basic resources.
Then you can have your own CSS and your own initialization javascript. It is easier to build a initialization file with jQuery because of all the event detector and DOM manipulation.
I don't mind using jQuery as it is bundle on all WordPress installation.
Hope these infos help !
(consider using code markup when posting code so that it become more readable :hamster: )

THANK YOU
-- found the external resources
-- have looked, and haven't found how to post code yet -- sorry!
-- jquery's great - just keen to not use it with my simple vanilla js page so i guessi need to find out how to initialize without it.
I've failed entirely to get anything to even show - perhaps it's that I'm running locally only or some other typical silliness - I've learned lots that hard long way *-)
May I ask, can i do this? [below]
have html-init.js and wavesurfer.js in HEAD of web page
have wavesurfer's style.css in HEAD of web page
put wavesurfer tag on webpage ANYWHERE
and have it show up and run?
JUST this tag in HTML page: (as html-init.js saysit needs wavesurfer tag)

IF so then it would be something like me running locally or other silliness why i get nothing showing.
However, I'm guessing I'm missing something fundamental.
Sorry to be at the point where I really need to sort this out.

ADDITIONAL:
I don't get any waveform when i see this codepen:
http://codepen.io/katspaugh/pen/WQXzpB?editors=100
I am very happy to have had help here.
guessing that as this is a closed "issue' i could/should really consider well, and then post a clear/short (with code done properly) and with example pen once I've done a serious effort at refining my thoughts/observations.
That way it could be helpful to the community.
I believe that people are struggling with the html-init - Multiple Players from Audio Element from HTML  method/option.
Thanks!

I'm studying: and I'm now thinking that partly the reason nothing shows is that I need to specify "container' From the WaveSurfer Options
container:
CSS-selector or HTML-element where the waveform should be drawn. This is the only required parameter.
If I specify 'container' it would 'draw' based on just an HTML-element
I will sort this out, though if an example is around based on my post 2 above this that would be great of course -- Yet, in absolutely any event - I'm most happy for the time and effort - THANKs!

In order to help you understand a bit more what is going on, I tell you some infos, hoping it will help you.
In fact, there is two concepts :

HTML init from a wavesurfer tag
HTML init from a regular tag

The first init, that was discusting about in this thread, is a way to automatically replace wavesurfer tags with a colored waveform, based on all data-thing attribute of this tag.
It also put an audio tag, from which the sound came from. Here is a (demo)[http://codepen.io/X-Raym/pen/jbRawz/]. Look the wavesurfer tag, and all check for the audio tag in the js.
The @katspaugh exemple however didn't have buttons controls for that: indeed, these are made a custom initiliazer-js, different from projects to projects to user needs.
In WaveSurfer-WP v1.x, I made button to control the play of the audio tag.
But there was an issue regarding to refresh rate. Indeed, "new position" events trigger of the audio tags are in fact a bit slow.
So @katspaugh leads me to another concept : using the regular WebAudio element used by wavesurfer-js in default mod.
This needs to change the wavesurfer tag by a div tag (in order to avoid the HTML init using audio element), and then same thing : rebuilding audio controller according to your needs.
I keep the data-attributes concept to push parameter inside my initialization-js, as it is HTML 5 and jQUery friendly.
In both cases I used jQuery for ease of programming (ability to trigger/check events, to look for elements in DOM etc).
The results looks exactly the same, but this WebAudio initlization has a lot of advantage (including nice cursor refreshing rate. Results is just like the first codepen I send you. No wavesurfer tag, and buttons control a WebAudio elements.
I think that is how much I can help you. You have all infos in these two codepens according to your need. I will advice use the WebAudio + jQuery version :+1:
Feel free to mod everything to your needs.
Good luck for the next !

FANTASTIC!
biGGest thanks!

Hello @katspaugh,
I used wavesurfer.js package its working great.
I want to know, can we differentiate voice from audio file using wavesurfer.js.
in audio conversion between two person can we separate Two Voice's showing different color?
Please give me replay  as soon as possible.

@sanjeev441
Please open a dedicated issue, it has nothing to do with this one.

do you know any voice differentiate or separate packages.


Rewrite emitter code

Need to investigate the TS2 compiler API and see if it is in a place where we can emit output using typescript itself.
If not a good alternative may be: https://github.com/RyanCavanaugh/dts-dom.

Using dts-dom in v2 now.


5.8 support?

Not planned to work on this package at the moment, so no plans for 5.8 support.

Please

@ashishnimrot currently we have half-year of work planned on our main product - 2019.quickadminpanel.com - and it has API generator inside of it. So package version isn't our priority at the moment, we're running a business and this package doesn't generate us any money. Sorry.


Can't update heating/cooling setpoint of thermostat

i've have set the temperature range to 17° - 30°, yet for some reason if i set the temperature to anything but 17, i get the following error:
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/components/zha/helpers.py", line 1286, in handler
    return await func(self, *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/components/zha/climate.py", line 230, in async_set_temperature
    await self.entity_data.entity.async_set_temperature(
  File "/usr/local/lib/python3.12/site-packages/zha/application/platforms/climate/__init__.py", line 462, in async_set_temperature
    await self._thermostat_cluster_handler.async_set_heating_setpoint(
  File "/usr/local/lib/python3.12/site-packages/zha/zigbee/cluster_handlers/hvac.py", line 286, in async_set_heating_setpoint
    await self.write_attributes_safe({attr: temperature})
  File "/usr/local/lib/python3.12/site-packages/zha/zigbee/cluster_handlers/__init__.py", line 624, in write_attributes_safe
    raise ZHAException(
zha.exceptions.ZHAException: Failed to write attribute occupied_heating_setpoint=2150: <Status.INVALID_VALUE: 135>

The interface displays the range correctly:

Please upload a debug log and diagnostics JSON for your device.

after some debugging the problem seems to be when i initialize the zigbee stack with an already set occupied heat/cool setpoint. So when i start the microcontroller, i read the status of the device and which temperature it is currently set to, and set OCCUPIED_COOLING_SETPOINT_ID and OCCUPIED_HEATING_SETPOINT_ID to the read temperature. If i don't do that, it seems to work fine. However, then HA might be out of sync with the actual setpoint of the AC until it is updated via the interface.
home-assistant_zha_2024-10-24T11-49-46.844Z.log
zha-3da5f89364f2b930116be3c470048f04-enktro ACmidea-2a8cfe24fc1c66e93d0fdd676fbef0cd.json

never mind, home assistant just seems to randomly decide what the limit will be, regardless of whether i pre-configure the setpoints or not. it will randomly send garbage as system mode as well if i switch between modes too quickly, like 0x903 (zigbee has defined 0x00-0x09) and start to lag.

it will randomly send garbage as system mode as well if i switch between modes too quickly, like 0x903

You gotta upload some debug logs if you're building your own device like this.

don't know what logs of the device i would send if homeassistant does not send a temperature update to the device because of the "invalid value" error.
the garbage system mode "home assistant sends" me seems to be an issue with the way the ESP SDK defines the enum. i receive a pointer to the value in the callback, which is 1 byte in size, but when i cast the void* to the enum *, it will read more than 1 byte, since the enum is not defined to be 1 byte, but just the default "int". i assume thats why i sometimes receive values like 0x0904 altough i should read 0x04 when i set the mode to heat.
i will just copy the value instead of casting the pointer

after some debugging the problem seems to be when i initialize the zigbee stack with an already set occupied heat/cool setpoint. So when i start the microcontroller, i read the status of the device and which temperature it is currently set to, and set OCCUPIED_COOLING_SETPOINT_ID and OCCUPIED_HEATING_SETPOINT_ID to the read temperature. If i don't do that, it seems to work fine. However, then HA might be out of sync with the actual setpoint of the AC until it is updated via the interface.
home-assistant_zha_2024-10-24T11-49-46.844Z.log zha-3da5f89364f2b930116be3c470048f04-enktro ACmidea-2a8cfe24fc1c66e93d0fdd676fbef0cd.json

in the diagnostics of the device you can see that the absolute limits are set to 1700 and 3000 for both heating and cooling. yet, in the debug log of home assistant, you can see it fails to set the value to 2750, which is well withing the range of the defined limits. i can't figure out where self.write_attributes comes from though, then i could see which limits are used to validate if the new value is in the supported range.

i get the feeling that thermostat devices just aren't fully supported in zha. I can't even update the temperature setpoint from the device. I've send a write attribute command, which home assistant received:
2024-10-28 13:25:50.761 DEBUG (MainThread) [zigpy.zcl] [0xA14F:1:0x0201] Decoded ZCL frame: Thermostat:Write_Attributes(attributes=[Attribute(attrid=0x0012, value=TypeValue(type=int16s, value=2500))])
2024-10-28 13:25:50.764 DEBUG (MainThread) [zigpy.zcl] [0xA14F:1:0x0201] Received command 0x02 (TSN 8): Write_Attributes(attributes=[Attribute(attrid=0x0012, value=TypeValue(type=int16s, value=2500))])

But it wasn't updated. When i read the attribute via the interface i get back 2100, which was the value before i send the update.

I've send a write attribute command, which home assistant received

This is backwards. Your device has a Thermostat cluster with attributes and ZHA will write those attributes to control the device. ZHA doesn't have a Thermostat cluster, you can't send it a Write_Attributes command and expect it to do anything.
If you change an attribute you need to send an attribute report, not write an attribute.

i get the feeling that thermostat devices just aren't fully supported in zha.

You're building your own custom device. I suggest you revisit the ZCL spec, this isn't a problem with ZHA.


"donejs generate" should create files based on "npm prefix" not the current directory

When going through the guide, cd into the src directory and do:
donejs generate component home.component
This will give you the following error:
Cannot find module 'yeoman-environment'
Therefore any generate commands should start from the npm prefix directory and not the current directory.

Makes sense (we're assuming you're running commands from the root level). I'm wondering if there is a way to find that out. Just go up paths until you find a package.json?

You could definitely do that!
I figured it would be easier to just call npm prefix.  I realize there is a performance implication, but it is a command so it won't be running often enough to warrant concerns about executing an extra process.

Based on:
https://github.com/donejs/donejs/blob/master/bin/donejs#L12
Root is currently cwd() I believe this is where we could make this change... whatever that change is.

I briefly looked into this but couldn't seem to find a way to use it programatically. So the only option I can think of would be to run npm prefix in process.cwd() and get the output folder.


tf.set_random_seed doesn't work after any operations have been constructed

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow):
Yes, just switching the order of this:

tf.set_random_seed(1234)
a = tf.random_uniform([1])
b = tf.random_normal([1])

to this:
a = tf.random_uniform([1])
b = tf.random_normal([1])
tf.set_random_seed(1234)

in this example:
https://www.tensorflow.org/api_docs/python/tf/set_random_seed
No longer sets the seed.

OS Platform and Distribution (e.g., Linux Ubuntu 16.04):
TensorFlow installed from (source or binary):

Binary via pip

TensorFlow version (use command below):

$ python -c "import tensorflow as tf; print(tf.GIT_VERSION, tf.VERSION)"
v1.3.0-rc2-20-g0787eee 1.3.0

Python version:

$ python --version
Python 3.6.1

Bazel version (if compiling from source):
n/a

GCC/Compiler version (if compiling from source):
n/a

CUDA/cuDNN version:
n/a

GPU model and memory:
n/a

Exact command to reproduce:
python tf-test.py

where tf-test is below:
You can collect some of this information using our environment capture script:
https://github.com/tensorflow/tensorflow/tree/master/tools/tf_env_collect.sh
You can obtain the TensorFlow version with
python -c "import tensorflow as tf; print(tf.GIT_VERSION, tf.VERSION)"
Describe the problem
If we would like to deterministically run a tensorflow graph, we want to be able to pass in the seed without rebuilding the graph from scratch (which is slow in our interactive application).
Also, this ordering constraint makes it tricky to debug what's going on and no mention is given to the fact that the seed is read in the op creation not execution in the documentation as far as I can tell.
Source code / logs
Include any logs or source code that would be helpful to diagnose the problem. If including tracebacks, please include the full traceback. Large logs and files should be attached. Try to provide a reproducible test case that is the bare minimum necessary to generate the problem.
As written on example page:
$ python tf-test.py
Session 1
2017-11-21 15:38:24.133822: W tensorflow/core/platform/cpu_feature_guard.cc:45] The TensorFlow library wasn't compiled to use SSE4.2 instructions, but these are available on your machine and could speed up CPU computations.
2017-11-21 15:38:24.133854: W tensorflow/core/platform/cpu_feature_guard.cc:45] The TensorFlow library wasn't compiled to use AVX instructions, but these are available on your machine and could speed up CPU computations.
[ 0.96046877]
[ 0.83621562]
[ 0.4987599]
[ 0.54880583]
Session 2
[ 0.96046877]
[ 0.83621562]
[ 0.4987599]
[ 0.54880583]

With set_random_seed after:
$ python tf-test.py
Session 1
2017-11-21 15:41:57.602615: W tensorflow/core/platform/cpu_feature_guard.cc:45] The TensorFlow library wasn't compiled to use SSE4.2 instructions, but these are available on your machine and could speed up CPU computations.
2017-11-21 15:41:57.602638: W tensorflow/core/platform/cpu_feature_guard.cc:45] The TensorFlow library wasn't compiled to use AVX instructions, but these are available on your machine and could speed up CPU computations.
[ 0.53137994]
[ 0.32236636]
[ 1.07008374]
[ 0.49122357]
Session 2
[ 0.07862437]
[ 0.18420935]
[ 0.76287955]
[ 0.47924194]

Full tf-test.py:
import tensorflow as tf

a = tf.random_uniform([1])
b = tf.random_normal([1])

tf.set_random_seed(1234)

# Repeatedly running this block with the same graph will generate the same
# sequences of 'a' and 'b'.
print("Session 1")
with tf.Session() as sess1:
  print(sess1.run(a))  # generates 'A1'
  print(sess1.run(a))  # generates 'A2'
  print(sess1.run(b))  # generates 'B1'
  print(sess1.run(b))  # generates 'B2'

print("Session 2")
with tf.Session() as sess2:
  print(sess2.run(a))  # generates 'A1'
  print(sess2.run(a))  # generates 'A2'
  print(sess2.run(b))  # generates 'B1'
  print(sess2.run(b))  # generates 'B2'

This is working as intended.  Seeds are used during graph construction, so changing them after you've constructed the graph does, indeed, not do anything.

@ekelsen Hey, thanks for replying. If it's the intent that the seed is remembered in the graph operations and can't be altered after, the documentation could use some clarification.
In our use case, we are able to use the stateless_random_uniform from contrib and manually pass in the seed in the feed_dict, however this diminished the utility of a bunch of built-in operations like random_brightness, etc.

@darknoon Thanks for the detailed post.  Indeed the documentation could try to make this more clear - would you like to take a stab at that?

The above mentioned random APIs have been changed into tf.random.set_seed, tf.random.uniform and tf.random.normal.
In Tensorflow 2, with eager execution by default, the deterministic behavior depends on global level seed and operation level seed. You can find the details for different type of seeds here.


Query parameters null

Describe the Bug
When using umami.track() it sends null value to Query parameters.
I'm using this code as explained in docs:
 umami.track('video play', {
   website: 'website-id-here',
   video: "test video play button",
 });

In the Events tab it gets video play correctly:

In the Query parameters tab shows null:

I'm using nginx:
server{
        server_name example.com;

        gzip on;
        gzip_proxied any;
        gzip_types application/javascript application/x-javascript text/css text/javascript;
        gzip_comp_level 6;
        gzip_buffers 16 8k;
        gzip_min_length 256;

        location /_next/static/ {
                alias /var/www/example.com/.next/static/;
                expires 365d;
                access_log off;
        }

        location / {
                proxy_pass http://<IP_ADDRESS>:4000;
                proxy_http_version 1.1;
                proxy_set_header Upgrade $http_upgrade;
                proxy_set_header Connection 'upgrade';
                proxy_set_header Host $host;
                proxy_cache_bypass $http_upgrade;
                proxy_buffering on;
                # Important to get country in umami.is
                    proxy_set_header X-Forwarded-Proto https;
                    proxy_set_header X-Real-IP $remote_addr;
                    proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
                    proxy_set_header X-Forwarded-Host  $host;
        }

    listen 443 ssl; # managed by Certbot
    ssl_certificate /etc/letsencrypt/live/example.com/fullchain.pem; # managed by Certbot
    ssl_certificate_key /etc/letsencrypt/live/example.com/privkey.pem; # managed by Certbot
    include /etc/letsencrypt/options-ssl-nginx.conf; # managed by Certbot
    ssl_dhparam /etc/letsencrypt/ssl-dhparams.pem; # managed by Certbot

}
server{
    if ($host = example.com) {
        return 301 https://$host$request_uri;
    } # managed by Certbot

        server_name example.com;
    listen 80;
    return 404; # managed by Certbot

}

Database
PostgreSQL
Relevant log output
No response
Which browser are you using? (if relevant)
Firefox
How are you deploying your application? (if relevant)
nginx

Seems like there an issue filtering null values in our self-hosted version, cloud seems to work fine. Thanks for reporting.

@franciscao633 this should be fixed in dev, the corresponding PR is merged now. 😄

fixed in v2.3.0


chore: upgrade charts

updated chart jxgh/jxboot-helmfile-resources from 1.0.75 to 1.0.76

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign rajdavies
You can assign the PR to them by writing /assign @rajdavies in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


new proxy sha for release-1.1

/hold until https://github.com/istio/proxy/pull/2120

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: utka
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: rshriram
If they are not already assigned, you can assign the PR to them by writing /assign @rshriram in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@utka: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
5230cb759bcd3fb228c48153a0a4669c9fd2af80
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@utka: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
5230cb759bcd3fb228c48153a0a4669c9fd2af80
link
/test istio-unit-tests

prow/istio-integ-local-tests.sh
5230cb759bcd3fb228c48153a0a4669c9fd2af80
link
/test istio-integ-local-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@utka: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
5230cb759bcd3fb228c48153a0a4669c9fd2af80
link
/test istio-unit-tests

prow/istio-integ-local-tests.sh
5230cb759bcd3fb228c48153a0a4669c9fd2af80
link
/test istio-integ-local-tests

prow/istio-presubmit.sh
5230cb759bcd3fb228c48153a0a4669c9fd2af80
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@utka: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
5230cb759bcd3fb228c48153a0a4669c9fd2af80
link
/test istio-unit-tests

prow/istio-integ-local-tests.sh
5230cb759bcd3fb228c48153a0a4669c9fd2af80
link
/test istio-integ-local-tests

prow/istio-presubmit.sh
5230cb759bcd3fb228c48153a0a4669c9fd2af80
link
/test istio-presubmit

prow/istio-integ-k8s-tests.sh
5230cb759bcd3fb228c48153a0a4669c9fd2af80
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@utka: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-local-tests.sh
5230cb759bcd3fb228c48153a0a4669c9fd2af80
link
/test istio-integ-local-tests

prow/istio-presubmit.sh
5230cb759bcd3fb228c48153a0a4669c9fd2af80
link
/test istio-presubmit

prow/istio-integ-k8s-tests.sh
5230cb759bcd3fb228c48153a0a4669c9fd2af80
link
/test istio-integ-k8s-tests

prow/istio-unit-tests.sh
5230cb759bcd3fb228c48153a0a4669c9fd2af80
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@utka: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
5230cb759bcd3fb228c48153a0a4669c9fd2af80
link
/test istio-presubmit

prow/istio-integ-k8s-tests.sh
5230cb759bcd3fb228c48153a0a4669c9fd2af80
link
/test istio-integ-k8s-tests

prow/istio-unit-tests.sh
5230cb759bcd3fb228c48153a0a4669c9fd2af80
link
/test istio-unit-tests

prow/istio-integ-local-tests.sh
5230cb759bcd3fb228c48153a0a4669c9fd2af80
link
/test istio-integ-local-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@utka: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
5230cb759bcd3fb228c48153a0a4669c9fd2af80
link
/test istio-integ-k8s-tests

prow/istio-unit-tests.sh
5230cb759bcd3fb228c48153a0a4669c9fd2af80
link
/test istio-unit-tests

prow/istio-integ-local-tests.sh
5230cb759bcd3fb228c48153a0a4669c9fd2af80
link
/test istio-integ-local-tests

prow/istio-presubmit.sh
5230cb759bcd3fb228c48153a0a4669c9fd2af80
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@utka: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
5230cb759bcd3fb228c48153a0a4669c9fd2af80
link
/test istio-unit-tests

prow/istio-integ-local-tests.sh
5230cb759bcd3fb228c48153a0a4669c9fd2af80
link
/test istio-integ-local-tests

prow/istio-presubmit.sh
5230cb759bcd3fb228c48153a0a4669c9fd2af80
link
/test istio-presubmit

prow/istio-integ-k8s-tests.sh
5230cb759bcd3fb228c48153a0a4669c9fd2af80
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@utka: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-local-tests.sh
5230cb759bcd3fb228c48153a0a4669c9fd2af80
link
/test istio-integ-local-tests

prow/istio-presubmit.sh
5230cb759bcd3fb228c48153a0a4669c9fd2af80
link
/test istio-presubmit

prow/istio-integ-k8s-tests.sh
5230cb759bcd3fb228c48153a0a4669c9fd2af80
link
/test istio-integ-k8s-tests

prow/istio-unit-tests.sh
858bdee337e531067b9fe8758d7d3c4de6e21b68
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@utka: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
5230cb759bcd3fb228c48153a0a4669c9fd2af80
link
/test istio-presubmit

prow/istio-integ-k8s-tests.sh
5230cb759bcd3fb228c48153a0a4669c9fd2af80
link
/test istio-integ-k8s-tests

prow/istio-unit-tests.sh
858bdee337e531067b9fe8758d7d3c4de6e21b68
link
/test istio-unit-tests

prow/istio-integ-local-tests.sh
858bdee337e531067b9fe8758d7d3c4de6e21b68
link
/test istio-integ-local-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@utka: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
5230cb759bcd3fb228c48153a0a4669c9fd2af80
link
/test istio-integ-k8s-tests

prow/istio-unit-tests.sh
858bdee337e531067b9fe8758d7d3c4de6e21b68
link
/test istio-unit-tests

prow/istio-integ-local-tests.sh
858bdee337e531067b9fe8758d7d3c4de6e21b68
link
/test istio-integ-local-tests

prow/istio-presubmit.sh
858bdee337e531067b9fe8758d7d3c4de6e21b68
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@utka: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
858bdee337e531067b9fe8758d7d3c4de6e21b68
link
/test istio-unit-tests

prow/istio-integ-local-tests.sh
858bdee337e531067b9fe8758d7d3c4de6e21b68
link
/test istio-integ-local-tests

prow/istio-presubmit.sh
858bdee337e531067b9fe8758d7d3c4de6e21b68
link
/test istio-presubmit

prow/istio-integ-k8s-tests.sh
858bdee337e531067b9fe8758d7d3c4de6e21b68
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@utka: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
858bdee337e531067b9fe8758d7d3c4de6e21b68
link
/test istio-unit-tests

prow/istio-presubmit.sh
858bdee337e531067b9fe8758d7d3c4de6e21b68
link
/test istio-presubmit

prow/istio-integ-k8s-tests.sh
858bdee337e531067b9fe8758d7d3c4de6e21b68
link
/test istio-integ-k8s-tests

prow/istio-integ-local-tests.sh
a42194c5b13df363fff8b5cd188afe9ea3da4cb5
link
/test istio-integ-local-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@utka: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
858bdee337e531067b9fe8758d7d3c4de6e21b68
link
/test istio-presubmit

prow/istio-integ-k8s-tests.sh
858bdee337e531067b9fe8758d7d3c4de6e21b68
link
/test istio-integ-k8s-tests

prow/istio-integ-local-tests.sh
a42194c5b13df363fff8b5cd188afe9ea3da4cb5
link
/test istio-integ-local-tests

prow/istio-unit-tests.sh
a42194c5b13df363fff8b5cd188afe9ea3da4cb5
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@utka: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
858bdee337e531067b9fe8758d7d3c4de6e21b68
link
/test istio-integ-k8s-tests

prow/istio-integ-local-tests.sh
a42194c5b13df363fff8b5cd188afe9ea3da4cb5
link
/test istio-integ-local-tests

prow/istio-unit-tests.sh
a42194c5b13df363fff8b5cd188afe9ea3da4cb5
link
/test istio-unit-tests

prow/istio-presubmit.sh
a42194c5b13df363fff8b5cd188afe9ea3da4cb5
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@utka: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
858bdee337e531067b9fe8758d7d3c4de6e21b68
link
/test istio-integ-k8s-tests

prow/istio-unit-tests.sh
a42194c5b13df363fff8b5cd188afe9ea3da4cb5
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@utka: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
858bdee337e531067b9fe8758d7d3c4de6e21b68
link
/test istio-integ-k8s-tests

prow/istio-unit-tests.sh
a42194c5b13df363fff8b5cd188afe9ea3da4cb5
link
/test istio-unit-tests

prow/e2e-simpleTests-cni.sh
a42194c5b13df363fff8b5cd188afe9ea3da4cb5
link
/test e2e-simpleTests-cni

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@utka: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
a42194c5b13df363fff8b5cd188afe9ea3da4cb5
link
/test istio-unit-tests

prow/e2e-simpleTests-cni.sh
a42194c5b13df363fff8b5cd188afe9ea3da4cb5
link
/test e2e-simpleTests-cni

prow/istio-integ-k8s-tests.sh
a42194c5b13df363fff8b5cd188afe9ea3da4cb5
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@utka: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
a42194c5b13df363fff8b5cd188afe9ea3da4cb5
link
/test istio-unit-tests

prow/e2e-simpleTests-cni.sh
a42194c5b13df363fff8b5cd188afe9ea3da4cb5
link
/test e2e-simpleTests-cni

prow/istio-integ-k8s-tests.sh
a42194c5b13df363fff8b5cd188afe9ea3da4cb5
link
/test istio-integ-k8s-tests

prow/istio-pilot-multicluster-e2e.sh
a42194c5b13df363fff8b5cd188afe9ea3da4cb5
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@utka: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
a42194c5b13df363fff8b5cd188afe9ea3da4cb5
link
/test istio-unit-tests

prow/e2e-simpleTests-cni.sh
a42194c5b13df363fff8b5cd188afe9ea3da4cb5
link
/test e2e-simpleTests-cni

prow/istio-integ-k8s-tests.sh
a42194c5b13df363fff8b5cd188afe9ea3da4cb5
link
/test istio-integ-k8s-tests

prow/istio-pilot-multicluster-e2e.sh
a42194c5b13df363fff8b5cd188afe9ea3da4cb5
link
/test istio-pilot-multicluster-e2e

prow/e2e_pilotv2_auth_sds.sh
a42194c5b13df363fff8b5cd188afe9ea3da4cb5
link
/test istio_auth_sds_e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Merging PR https://github.com/istio/istio/pull/11591 after this merge should fix the test failures

/lgtm

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: duderino, utka
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: rshriram
If they are not already assigned, you can assign the PR to them by writing /assign @rshriram in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: costinm, duderino, utka
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [costinm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


(GH-307) Fix path resolution on mac and *nix

So I tested this on my Ubuntu desktop and it worked.  Although it wasn't broken before.  Did we expect all *nix users to be broken?

I updated the issue with a little more information

Seems Arch is supported by VSCode...https://aur.archlinux.org/packages/visual-studio-code-bin/?comments=all

It's odd.  I can't replicate the bad paths with my Ubuntu Desktop.  Another user I had try with Mac is not experiencing the bad pathing.  And I can't see anything in the Puppet repos/docs to suggest a path change.  This PR looks fine and I'm almost about to press the merge button, but I'm having trouble repro-ing.
no issues from what I can see. VSC 1.25.0, PE 4.10.9. im on OSX 10.12.6, so not high sierra


Displays arrow-up when filter visibility toggles

Added arrow-up, which is shown when the filter section is extended.
Initial :-

Final :-

@akmadian  done :)

@akmadian  check !

@akmadian Sir I have used SVG files, kindly review :)

@akmadian Done !

Review @brenoferreira .

@brenoferreira
please review my last update, and suggest if anything left.


Change time chat

please guide me how can chat fastest

The chat is already running at its fastest speed.

It depends on your server connection, poor connection to server (or poor server) can lead to slowing down. (Or a bad client too)


fix SyncCompanies.rb typo

line 34 was referencing "opportunities.json" instead of "companies.json".

Thanks for the correction!


protoc compile navigation.proto error?

Hello,everyone!
When I use protoc to compile navigation.proto,there are some error,such as:
navigation.proto:34:3: Expected "required", "optional", or "repeated". navigation.proto:34:6: Expected field name.
How should I solve it?

@JackRen88 Did you compile inside docker?
The maps syntax is supported starting from protobuf v3.0.0.
Please check the version of your protobuf.


lang="ts" seems to confuse VS code

When I have a construct like:

and using lang="ts" in a Svelte source file, it seems to say that "counts" is not found.
I can work around this with:
    let counts: SiteStatistic
    $m: counts = SiteStatistics.find().fetch()[0]

However, I'm hoping there is a cleaner way.  Any suggestions?

The TS example in the docs also show this as needed, so while I wish it could be defined in the $m block, I'll close this as I should just read the docs better I suppose.  :)


Example of using custom theme?

I would like to use a custom theme—e.g. those made available at https://github.com/brijeshb42/monaco-themes/tree/master using the json files.
Are there any examples that illustrate how to accomplish this? Both the microsoft docs and the docs.rs/monaco docs are a little sparse on this topic

Did you end up figuring out how to do it? I'm also wanting to add a custom theme.

Did you end up figuring out how to do it? I'm also wanting to add a custom theme.

no i didnt :/


Add seeders and provider back to the torrent info

Closes #52

The problem is atm we've no service that's updating seeders.
So they'll only ever show what they are on the initial ingestion
It's not the responsibility of the consumer. Its sole purpose is ingestion of torrent data from the queue. We need a new separate service that handles updates of seeders periodically
Ideally this would be wrapped in pm2 in the container as it allows execution of a task on a cron schedule ala: pm2 start update-seeders.js --cron "*/15 * * * *"

Do you wish to hold this merge until thats done?

No we can add it if you'd like 😃
It's just they'll all say 100 as the dmm ones are hardcoded lol

So open an issue for seeder updates & link this issue?

#73 this is a good idea. Tagging the issue here for clarity.

Feels like this one should be closed, @purple-emily ?


"continuously replicate from to a different target region" is "from to" grammatically correct?

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 77b55957-eb46-c35a-5f31-66ca20ad4390
Version Independent ID: 10500bf3-d343-0bc9-cc16-642c5116a131
Content: Azure to Azure disaster recovery architecture in Azure Site Recovery - Azure Site Recovery
Content Source: articles/site-recovery/azure-to-azure-architecture.md
Service: site-recovery
GitHub Login: @rayne-wiselman
Microsoft Alias: raynew

@theBlueclouds Thanks a lot for bringing this to our notice and helping us to improve our Azure documentation, I have raised a PR to correct it in the document and it would go live later in the week.
At this point it appears that there's no further edits or updates needed to the documentation other than what is listed above. We will go ahead and close this issue, however if you have any further queries please tag us in your reply and will be happy to reopen the thread and continue the conversation. Thank you


Compose single yargs command

[ ] Define composeCommand function for yargs
[ ] Create tests for yargs composeCommand

Still need sinon tests that check that client command/option handlers are being called.


Update ovs datapath settings for antrea version 0.11.3 and 0.13.3

For version 0.11.3, the depmod volume mount also was removed to avoid dependency error
in the container.
Signed-off-by: Hang Yan<EMAIL_ADDRESS>What this PR does / why we need it

Details for the Release Notes (PLEASE PROVIDE)

Which issue(s) this PR fixes

Fixes: #
Describe testing done for PR

Special notes for your reviewer

ref to: https://github.com/vmware-tanzu/community-edition/pull/3560

All updated


⚠ PrivateHD has degraded performance

In 12d9eb9, PrivateHD ($PHD) experienced degraded performance:

HTTP code: 200
Response time: 1751 ms

Resolved: PrivateHD performance has improved in 276d986.


Fix: Now correctly allows to override ElementFinder and ElementArrayFinder methods

Fix: Now correctly allows to override ElementFinder and ElementArrayFinder methods
Because monkeypatching was done in constructor against 'this', all objects that was trying to extend ElementFinder or ElementArrayFinder and override some of WebElements methods:
let WEB_ELEMENT_FUNCTIONS = [
'click', 'sendKeys', 'getTagName', 'getCssValue', 'getAttribute', 'getText', 'getRect',
'isEnabled', 'isSelected', 'submit', 'clear', 'isDisplayed', 'getId', 'takeScreenshot'
];
class Component extends ElementFinder {
  constructor(elementFinder: ElementFinder) {
    super(elementFinder.browser_, elementFinder.elementArrayFinder_);
  }

 async click() {
     console.log('OWN click!')
     await super.click()
 }
}

new Component($('button')).click()

Before this PR code above would not be working - since monkey-patching is overrides methods declared in child classes:
https://github.com/Xotabu4/protractor-element-extend/issues/20

@cnishina could you take a look at it useful PR? :)


Revert #75031 - caused 2 hydra failures

#75031 caused a few hydra failures -- first some IFD due to some path confusion, then due to nixpkgs.tarball failure. Reverting until we can test it a bit more carefully :)
Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Notify maintainers
cc @

Update: validating this PR through a bisection.

I think I might be mistaken, checking.

hydra eval was fixed by an earlier revert. Tarball would be fixed by this PR according to ofborg.

Sorry, #75031 wasn't related.


Adding some functional tests

Adding some functional tests to some specific parts. I'll start doing some integrations, but as that will need the containers to be running, I am leaving it for later.

Thanks @jabolina