Feature request: Provide ability to organize text mode code into multiple files

Similar requests

[X] I have searched and found no existing similar requests

How are you using Studio?
Legend Studio
What problems are you trying to solve?
Provide ability to organize text mode code into multiple files
Describe the solution you would like to see implemented
ENGINE

[ ] Engine Change the response of grammarToJson api to return an array of grammar elements each corresponding to an entity instead of one single grammar text
[ ] Engine Change the payload to jsonToGrammar api to take an array of grammar elements as an input each corresponding to an entity instead of one single grammar text
[ ] add a new field to SourceInformation which stores the entity name so that we can do proper error handling when engine returns compilation errors
[ ] Throw parsing error when user tries to add multiple elements in one file

STUDIO

[ ] Show each entity in a different file in text mode
[ ] Think about how to differentiate when you are in text mode and form mode as we have have tabs in both the modes
( MAYBE Have a label in explorer tree that says which mode we are in )
[ ] How to handle graph builder failure? MAYBE stay in form mode when we encounter this scenario and wait for the compilation to finish so that we have the sourceInformation of the compilation failure if ny exists so that we know which entity file to open when we re-direct to text mode.
[ ] Support adding new packageable element from text mode. This can be made possible using snippet suggestions we have so that we can create a basic snippet. If no snippet exists we can just create an empty file
[ ] How we are gonna do manual testing?
[ ] We can show warnings specific to a file and specific to project in the warnings tab

Describe alternatives you have considered
No response
Documentation, Design, Adoption, Migration Strategy
No response
Contribution

[x] I would like to work on this feature

Closing this as we have done a PoC of this and realized that we cannot define the requirements properly for the feature, in particular, rename/refactor operation is hard as the user cannot do a simple text-replace anymore, and errors caused by this refactoring can spread across multiple files, making it harder for users to debug. Also, we need to think about what it means for section index, one strategy is for us to either flatten the import statements, or duplicate the import per file, but when re-assembling the individual file, we end up with duplication of sections.


[bug]: Unencrypted TLS key does not work in 0.16.0

Background
When placing an unencrypted key file, and booting lnd without --tlsencrypt, it throws an error saying my private key is encrypted but I don't have tlsencrypt enabled.
However, my private key is not encrypted. (see below)
Your environment

version of lnd 0.16.0-beta
which operating system (uname -a on *Nix) Linux c75866d65bf0 5.15.49-linuxkit #1 SMP Tue Sep 13 07:51:46 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
version of btcd, bitcoind, or other backend bitcoind 24.0.1
any other relevant environment details

Steps to reproduce
Place tls.cert in lnd folder
-----BEGIN CERTIFICATE-----
MIIB5jCCAY2gAwIBAgIQHFx0JBsx3QaYKe6Cj6OhbTAKBggqhkjOPQQDAjA1MR8w
HQYDVQQKDBZsbmQgYXV0b2dlbmVyYXRlZCBjZXJ0MRIwEAYDVQQDDAlsb2NhbGhv
c3QwHhcNMjEwMzI5MDI0ODM3WhcNNDkxMjMxMDI0ODM3WjA1MR8wHQYDVQQKDBZs
bmQgYXV0b2dlbmVyYXRlZCBjZXJ0MRIwEAYDVQQDDAlsb2NhbGhvc3QwWTATBgcq
hkjOPQIBBggqhkjOPQMBBwNCAAS/iH6M/x82oIQVgN+scrVPTwaDWba6ZkNDOlnM
1hOZM/jb80rRFVxmj7YpWUaPOuGt7kZR1quNoCRhwbgltuLFo38wfTAOBgNVHQ8B
Af8EBAMCAqQwEwYDVR0lBAwwCgYIKwYBBQUHAwEwDwYDVR0TAQH/BAUwAwEB/zAd
BgNVHQ4EFgQUVU/1biM6C74jTr0ySchNbrwSfZkwJgYDVR0RBB8wHYIJbG9jYWxo
b3N0ggpsbmRjaGFubmVshwR/AAABMAoGCCqGSM49BAMCA0cAMEQCICUvjjUjXfW5
BYd8KH6GAimyCHaOqYzzTzmgmPBPSiLXAiAOiSF4BwAXe+Hmh9xjwZTqTIUBtkiy
WfzjNBEGNLSdoA==
-----END CERTIFICATE-----

Place tls.key in lnd folder:
-----BEGIN PRIVATE KEY-----
MIGHAgEAMBMGByqGSM49AgEGCCqGSM49AwEHBG0wawIBAQQgubLWz/UCo9+LK+xq
APxDbHOYl6RswJrdqV2KHAGYRj2hRANCAAS/iH6M/x82oIQVgN+scrVPTwaDWba6
ZkNDOlnM1hOZM/jb80rRFVxmj7YpWUaPOuGt7kZR1quNoCRhwbgltuLF
-----END PRIVATE KEY-----

DO NOT use tlsencrypt flag
Expected behaviour
It should start like < 0.16.0 does.
Actual behaviour
I get the error: https://github.com/lightningnetwork/lnd/blob/v0.16.0-beta/tls_manager.go#L298-L301

My tls.key is a valid EC key file... not encrypted..
$ openssl ec -in tls.key -text -noout
read EC key
Private-Key: (256 bit)
priv:
    00:b9:b2:d6:cf:f5:02:a3:df:8b:2b:ec:6a:00:fc:
    43:6c:73:98:97:a4:6c:c0:9a:dd:a9:5d:8a:1c:01:
    98:46:3d
pub:
    04:bf:88:7e:8c:ff:1f:36:a0:84:15:80:df:ac:72:
    b5:4f:4f:06:83:59:b6:ba:66:43:43:3a:59:cc:d6:
    13:99:33:f8:db:f3:4a:d1:15:5c:66:8f:b6:29:59:
    46:8f:3a:e1:ad:ee:46:51:d6:ab:8d:a0:24:61:c1:
    b8:25:b6:e2:c5
ASN1 OID: prime256v1
NIST CURVE: P-256

ok... seems like the issue was the method by which a valid unencrypted private key was detected.
https://github.com/lightningnetwork/lnd/blob/v0.16.0-beta/tls_manager.go#L38
We are generating the TLS cert and key using the following command (we modify the DNS and IP entries for prod)
openssl \
  req \
  -newkey ec:<(openssl ecparam -name prime256v1) \
  -nodes \
  -keyout \
  tls.key \
  -x509 \
  -set_serial 0x$(openssl rand -hex 16) \
  -config <(echo "
      [req]
      x509_extensions = v3_req
      distinguished_name = req_distinguished_name
      prompt = no

      [req_distinguished_name]
      organizationName = lnd autogenerated cert
      commonName = localhost

      [v3_req]
      keyUsage = critical, digitalSignature, keyCertSign, keyEncipherment
      extendedKeyUsage = serverAuth
      basicConstraints = critical, CA:true
      subjectKeyIdentifier = hash
      subjectAltName = DNS:localhost, IP:<IP_ADDRESS>
  ") \
  -out tls.cert \
  -days 420

This creates a valid cert and key that matches the exact params of lnd, but the name of the header leaves out EC
By adding EC into the private key, it works.
perhaps the mechanism for deciding if a key is unencrypted should be refined a bit.


The loss function choice in parameter objective

In short, does binary:logistic and reg:logistic use different loss function, i.e., objective function? I think for binary classification, that the loss function should be the sum of cross entropy across all samples, right? The same question for multi:softmax and multi:softprob. Do they only differ in the output (one outputs classes and the other gives probability)?
Meanwhile, see the answer by the author, what's the point to use the rmse  metric for binary classification learner?

I think the author means that reg:logistic use rmse.

I think the author means that reg:logistic use rmse.

Does that mean the cost or loss functions for binary:logistic and reg:logistic are different? If so, what's the point using rmse in logistic regression?

As far as I can tell from the code they are exactly the same.
I assume the purpose is to have them as a convenient way to report RMSE in the evaluation stage of the learning, but this should not affect the actual learning.
In other words,  I think the end model from running these two objectives should be the same, the only difference would be the reported metrics in the evaluation while learning.

As far as I can tell from the code they are exactly the same.
I assume the purpose is to have them as a convenient way to report RMSE in the evaluation stage of the learning, but this should not affect the actual learning.
In other words, I think the end model from running these two objectives should be the same, the only difference would be the reported metrics in the evaluation while learning.

Sounds quite reasonable. I need to try if forcing xgb.XGBClassifier to use reg:logistic and 'logloss' togeter will cause any difference.


chore: deprecate Array.modifyOp

I don't understand what's broken here, and it's not too important, so just closing this for now.


track block mismatch errors when taking a basebackup

About this change: What it does, why it matters
Sometimes xtrabackup might fail when keeping up with redo logs, this will end up with an error due to block mismatches. Will be nice to track such errors, this way maybe we know when to set redo_log_archiving=true and retry taking the backup again... as just restarting myhoard is not the proper solution.
Seems there is a misconception that xtrabackup is not releasing correctly the backup lock, when the case is that the BackupStream keeps retrying on taking a basebackup, xtrabackup takes the lock and eventually fails due to block mismatch. This might take a long time, so myhoard will keep complaining when purging binlogs.

Codecov Report

Merging #174 (56d7b07) into master (f374442) will decrease coverage by 0.68%.
The diff coverage is 52.00%.

@@            Coverage Diff             @@
##           master     #174      +/-   ##
==========================================
- Coverage   79.31%   78.64%   -0.68%
==========================================
  Files          17       17
  Lines        4385     4401      +16
  Branches      991      944      -47
==========================================
- Hits         3478     3461      -17
- Misses        683      701      +18
- Partials      224      239      +15

Files Changed
Coverage Δ

myhoard/basebackup_operation.py
87.63% <33.33%> (-3.85%)
:arrow_down:

myhoard/backup_stream.py
78.20% <55.55%> (-1.80%)
:arrow_down:

myhoard/errors.py
66.66% <100.00%> (+3.03%)
:arrow_up:

... and 4 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


split vercel api routes function

This creates a seperate serverless function api.func to handle API routes.
An effect of this is fixing https://github.com/solidjs/solid-start/issues/612
Build output
.vercel
├── output
│  ├── config.json
│  ├── functions
│  │  ├── api.func
│  │  │  └── index.js
│  │  └── render.func
│  │     └── index.js

Config
{
  "version": 3,
  "routes": [
    ...
    // Add route for api handler
    {
      "src": "/api/hello",
      "dest": "/api"
    },
    {
      "src": "/.*",
      "dest": "/render"
    }
  ]
}

Not sure if this is the best approach, but would at least make ISR work with API routes. We could limit it to only be done when prerender is enabled, but I think it should be fine even when it is not enabled.
If there is a way to get a server output with only API routes it would make more sense (and without API routes for render.func)

I have an experimental version available that splits each api routes into individual serverless functions https://github.com/ryoid/solid-start/pull/1 not sure if this breaks stuff though.

Yeah this is interesting, because it touches on something I've been thinking about. How to effectively break apart these monoliths for optimal deployment and how to expose it. My temptation is to just split in half like you've done here for now. But this definitely an important area of consideration.

I think having it more granular helps when there are different runtimes, such as edge that might not work/make sense for all functions. Or when everything bundled together is larger than the platform's serverless size limits (unsure how common this is). Could also have it as an opt in similar to what SvelteKit has. Splitting it in half seems like a good first step.
Agree that if it does become named exports there needs to be a standardised pattern.


Minimized versions and .otf

The .otf font can also ignored as browsers don't use them.

forget about the minimized thing, its not in the package ;P


Mushroom structures can join together

The mushroom structures in the mushroom island can join together:

It's also possible for them to spawn really tall, possible the same joining issue but this time vertical?

We actually just use Vanilla mushroom generation. I suppose we could replace them with custom structures if this is an issue

Closing since this is Vanilla behavior,


Cargo fmt keeps adding commas after methods definition at methods! macro

Is it possible to make the methods! (and unsafe_methods!) macro accept both with or without commas?
(This would help a Rust/Rutie newbie like me)
It would be desirable to have this possibility? (Or is there another way to tackle this situation? A cargo fmt configuration, for example?)
Is it easily accomplish-able? If so, I could study Rust macros and try to open a PR myself.
Bellow a git diff after a cargo fmt
diff --git a/src/lib.rs b/src/lib.rs
index c6f733c..83fdde3 100644
--- a/src/lib.rs
+++ b/src/lib.rs
@@ -73,14 +73,12 @@ methods!(
         }

         array
-    }
-
+    },
     fn pub_to_s() -> RString {
         let matrix_str = rtself.get_data(&*MATRIX_WRAPPER_INSTANCE).to_s();

         RString::from(matrix_str)
-    }
-
+    },
     fn pub_dot(other: MatrixRs) -> MatrixRs {
         let other = other.unwrap_or_rb_raise();
         let other_matrix = other.get_data(&*MATRIX_WRAPPER_INSTANCE);

@abinoam I believe @gemmaro has solved this issue and this is now in v0.8.2.


Windows version

Does this work on windows?

Its in readme section as TODO but I really hope development is in progress, I'm in a boat for windows and mac application that needs tts.


the difference between the external FANlayer and the FANlayer in Timeseries_Forecasting

Hello, what is the difference between the external FANlayer and the FANlayer in Timeseries_Forecasting? I want to process my own periodic series, which one should I use?

Thank you for your attention to our work. The FANlayer in Timeseries_Forecasting represents the version directly utilized in our experiments, while the external FANlayer is the revised version that adds comments and hyperparameter adjustments. We recommend that you use the external FANlayer.

Thank you very much for your reply. Your work has given me great inspiration. Thank you again.


How do i use the auto generated sdk with this base?

the one from here https://github.com/neverlosecc/source2sdk/tree/cs2

why?

I want to made a skin changer and i can't find the member method in the src currently (according to this https://www.unknowncheats.me/forum/3711351-post132.html) , i'm new to this so if there is already a way to get the needed weapon service, please show me how
Grab the weapon services instance of your local player pawn: C_BasePlayerPawn::m_pWeaponServices.
Loop CPlayer_WeaponServices::m_hMyWeapons (num weapons is at + 0x0, data is at + 0x8).

see cbaseentity.hpp or another hpp file from that directory maybe youll get an idea

i'm new to c++ so please bear with me.
as i understand, i need to use NETVAR to declared some kind of reference to the actual method signature in the main game process.
but when i then add another normal method, it's error'ed out

the NETVAR define is in netvars.hpp

one more question, how do i set value to the NETVAR mapped property?


Daemon crashes on startup with /tmp mounted on RAM

Bug
Lbry not starting.
To Reproduce
Steps to reproduce the behavior:

mount your temp folder on ram. tmpfs /tmp tmpfs defaults,noexec,nosuid 0 0 (fstab)
start lbry
see error

Daemon: /opt/LBRY/resources/static/daemon/lbrynet: error while loading shared libraries: libz.so.1: failed to map segment from shared object
Expected behavior
daemon not crashing
Screenshots

System Configuration

LBRY Daemon version: 0.76.0
LBRY App version: 0.46.2
LBRY Installation ID:
Operating system: Linux (Linux-5.7.4-zen1-1-zen-x86_64-with-arch)

Sorry to hear about the trouble. Can you try with sudo, like sudo mount /tmp -o remount,exec
Also, you can try something like this:
export TMP=/usr/local/tmpdir

@tzarebczan after sudo mount /tmp -o remount,exec I can start the daemon. But this is only a temporary solution. Why is the ticket closed?

same issue for me.
Making tmp files executable could not be a good solution, just a workaround


Delete cascade not working in AsyncSession

First Check

[X] I added a very descriptive title to this issue.
[X] I used the GitHub search to find a similar issue and didn't find it.
[X] I searched the SQLModel documentation, with the integrated search.
[X] I already searched in Google "How to X in SQLModel" and didn't find any information.
[X] I already read and followed all the tutorial in the docs and didn't find an answer.
[X] I already checked if it is not related to SQLModel but to Pydantic.
[X] I already checked if it is not related to SQLModel but to SQLAlchemy.

Commit to Help

[X] I commit to help with one of those options 👆

Example Code
from typing import List, Optional
import sqlalchemy as sa
from sqlmodel import Field, Relationship, SQLModel

class Address(SQLModel, table=True):
    __tablename__ = 'addresses'

    id: Optional[int] = Field(default=None, primary_key=True, nullable=False)
    user_id: int = Field(foreign_key='users.id', nullable=False)
    user: 'User' = Relationship(back_populates='addresses', sa_relationship_kwargs={'lazy':'noload'})

class User(SQLModel, table=True):
    __tablename__ = 'users'

    id: Optional[int] = Field(default=None, primary_key=True, nullable=False)
    name: str = Field(max_length=100, nullable=False)
    addresses: List['Address'] = Relationship(back_populates='user', sa_relationship_kwargs={'cascade': 'all, delete', 'lazy':'noload'})

# when doing a delete

async def remove_user(db: AsyncSession, *, id: int):
    obj = await db.get(User, id)
    await db.delete(obj)
    await db.commit()

Description
When using lazy='noload' in the relationship arguments it loads the user object with addresses: [] so there are no addresses to apply the cascade to, you always have to selectinload or joinedload so that when deleting the object it works.
Am I misunderstanding or doing it wrong because that looks too much work just to delete an object, specially if it has too many relations.
Operating System
Linux, Windows
Operating System Details
No response
SQLModel Version
0.0.8
Python Version
3.11
Additional Context
No response

For relationship cascades to work your related entities should be loaded first
You might want to confidure on delete on your foreign keys for db-level cascades https://docs.sqlalchemy.org/en/14/core/constraints.html#sqlalchemy.schema.ForeignKey.params.ondelete
async def main():
    async with engine.connect() as connection:
        await connection.run_sync(SQLModel.metadata.drop_all)
        await connection.run_sync(SQLModel.metadata.create_all)
        await connection.commit()

    # Seed the data
    async with async_sessionmaker.begin() as session:
        session.add(
            User(
                name="Doctor",
                addresses=[Address(), Address()],
            )
        )

    async with async_sessionmaker.begin() as session:
        stmt = select(User).options(joinedload(User.addresses))
        user = await session.scalar(stmt)
        await session.delete(user)

@ThirVondukr I am aware that we need to load the relation manually but I am asking if there is another way, since usually you may have many relations it is not practical to load each of them. Also keep in mind that these children will have other children under them that need to be loaded as well to apply the cascades.
I think using the on_delete='CASCADE' seems to be the only practical option but I read that it is not a good practice to keep the logic in the database and it should be on the ORM side.

Your data integrity should be handled on DB side as much as possible 😉

maybe you can try to add passive_deletes=True to delete children by db cascade delete natively, also it's has better performance than sqlalchemy core.

@wangxin688 thanks I didn't know about this flag, but it still won't fix the problem because you would need to add a CASCADE on the database side. I have opted to do this for my project but everywhere I read says its not best practice.

@wangxin688 thanks I didn't know about this flag, but it still won't fix the problem because you would need to add a CASCADE on the database side. I have opted to do this for my project but everywhere I read says its not best practice.

That's true, you need define cascade action in Column level, db natively action is always a better choice for me.


IA-1812: parent disapear when an alias is added in orgunit creation

adding an alias cleared the org unit treeview input
Self proof reading checklist

[x] Did I use eslint and black formatters
[x] Is my code clear enough and well documented
[ ] Are my typescript files well typed
[ ] Did I add translations
[ ] My migrations file are included
[ ] Are there enough tests

Changes

fixed handleChangeAlias function

How to test
Go to Orgunits > Create
Then  select a parent orgunit and try adding an alias
Adding an alias should not empty the parent orgunit treeview
Print screen / video
recording-2023-01-13-16-07-51.webm

Added cypress test on creation.
@cypress


Provide a React template in ES6 syntax

I think it's quite essential to provide a React Redux template in ES6 syntax. In general TypeScript is getting more and more popular among Angular developers. But in the React community ES6 is more popular.

Closing as duplicate of #118


rule-types: add check for more rule types - v1

The goal is to have at least one rule for each rule type the engine has.
DE_only and like_ip_only were missing

Merged in #2139, thanks!


connection pool storage options

Connection pool could be expanded with additional storage or "sharing" options to allow for better control over the numbers of connections an application uses.

Thread: Each connection pool shares its connections with all other pools on the same thread.
Process: Each connection pool shares its connections with all other pools in the same process. This is similar to thread-sharing but requires locks for synchronizing access.
Instance: Each connection pool has its own, private connections.

For an example on sharing pooled connections across all event loops, have a look at https://github.com/vapor/database-kit/blob/master/Sources/DatabaseKit/ConnectionPool/DatabaseConnectionPool.swift.

This was for the most part implemented in #53.
Process:
Sharing connections across a process is not reasonable given Vapor's design. Each connection stores a reference to its event loop, which should always be the Request's event loop. This allows for route handlers to be much more efficient and not need to change threads a lot.
Thread:
There's a new ThreadConnectionPool type that, if shared across threads, will yield the same connection pool per thread.
Instance:
Initializing a new connection pool will not share storage with any other connection pools that have been created in the thread or process.


[safety-rules, consensus, ...] Remove a few panics

There are rumors that people don't like panics, specially in key areas such as the TCB.
Just to map out the feasibility of tooling that would make those panics harder to introduce, this PR aims at starting a conversation by removing a bunch of panics, through folding them in the Error case of their enclosing Result.
Kind reviewer:
If you see one of your favorite panics listed in this PR, now's the time to defend it. But more importantly, if you can say a word on how that panic represents a legitimate use case you'd want in high-assurance code, that would be even more helpful.

Overall this makes sense to me. Going forward, it would be nice if we had a linter to prevent such cases (e.g., where a panic is possible in a function that explicitly returns a Result<..>).

Overall this makes sense to me. Going forward, it would be nice if we had a linter to prevent such cases (e.g., where a panic is possible in a function that explicitly returns a Result<..>).

Yeah, creating it is the idea, but feedback on specifics helps scope out the least intrusive way to make it happen.

Overall this makes sense to me. Going forward, it would be nice if we had a linter to prevent such cases (e.g., where a panic is possible in a function that explicitly returns a Result<..>).

we're working on it :)

Using errors almost certainly eliminates the backtrace

For many Error types (including anyhow which is used in many of these examples):
If you want panics and errors to both have backtraces, set RUST_BACKTRACE=1;
If you want only errors to have backtraces, set RUST_LIB_BACKTRACE=1;
If you want only panics to have backtraces, set RUST_BACKTRACE=1 and RUST_LIB_BACKTRACE=0.
The tracking issue for having this in the std lib is https://github.com/rust-lang/rust/issues/53487

Using errors almost certainly eliminates the backtrace

For many Error types which use std::backtrace (including anyhow which is used in many of these examples and throughout the code base):
If you want panics and errors to both have backtraces, set RUST_BACKTRACE=1;
If you want only errors to have backtraces, set RUST_LIB_BACKTRACE=1;
If you want only panics to have backtraces, set RUST_BACKTRACE=1 and RUST_LIB_BACKTRACE=0.
The tracking issue for having this in the std lib is rust-lang/rust#53487

Errors do not have backtraces unless they are compiled with the nightly compiler :/ https://doc.rust-lang.org/std/error/trait.Error.html#method.backtrace
so the only way to get them is via expect statements or rolling your own Error type that has backtrace -- something I wish we had done much earlier.

:exclamation: Invalid command

Bors help and documentation

Bors is a Github App used to manage merging of PRs in order to ensure that CI is always green. It does so by maintaining a Merge Queue. Once a PR reaches the head of the Merge Queue it is rebased on top of the latest version of the PR's base-branch (generally master) and then triggers CI. If CI comes back green the PR is then merged into the base-branch. Regardless of the outcome, the next PR is the queue is then processed.
General

This project's Merge Queue can be found here.
This project requires PRs to be Reviewed and Approved before they can be queued for merging.
Before PR's can be merged they must be configured with "Allow edits from maintainers" enabled. This is needed for Bors to be able to update PR's in-place so that Github can properly recognize and mark them as "merged" once they've been merged into the upstream branch.

Commands
Bors actions can be triggered by posting a comment which includes a line of the form /<action>.

Command
Action
Description

Land
land, merge
attempt to land or merge a PR

Canary
canary, try
canary a PR by performing all checks without merging

Cancel
cancel, stop
stop an in-progress land

Cherry Pick
cherry-pick <target>
cherry-pick a PR into <target> branch

Priority
priority
set the priority level for a PR (high, normal, low)

Help
help, h
show this help message

Options
Options for Pull Requests are configured through the application of labels.

          Option
Description

Indicates that the PR is high-priority. When queued the PR will be placed at the head of the merge queue.

Indicates that the PR is low-priority. When queued the PR will be placed at the back of the merge queue.

Before merging the PR will be squashed down to a single commit, only retaining the commit message of the first commit in the PR.

/land


doc: improve environment variables doc quickstart example

Description

Improve environment variable quickstart example

@jayair @fwang will the changes make it better to understand?
#2158

Hey @tlcheah2 can you share what was confusing?

Hi @fwang
Sorry for the delay. It's confusing from the beginner's point of view.
new Function(stack, "MyFunction", {
       handler: "lambda.handler",
       config: [USER_UPDATED_TOPIC],
     });

The original doc only show that I need to pass the parameters via config. This part is great.
However, in order to have a complete working example, the function has to be assigned to routes like the example below.
const myFunction = new Function(stack, "MyFunction", {
       handler: "lambda.handler",
       config: [STRIPE_KEY, GITHUB_TOKEN],
     });

     const api = new Api(stack, "api", {
      routes: {
        "GET /notes": myFunction,
      },
   }):

So I find it adding the API part seems better to me. I also realize the environment variables docs had been removed. So probably this PR is not needed anymore?

We are transition this repo to https://github.com/sst/v2 and are closing this issue for now. If it is still relevant please reopen it there - sorry for the trouble


Similarity OF Triangles Calculator

Issue Id you have worked upon -
#279
Briefly explain your program logic -
Program calculates and determines the similarity of two triangles based on their side lengths and angles. It applies the SSS (Side-Side-Side) axiom , SAS (Side-Angle-Side) and AA(Angle-Angle) axiom to check for similarity. The program also performs input validation to ensure positive side lengths and that the sum of angles in each triangle is equal to 180 degrees.
Screenshots(Attach 2 screenshots of your own input and output) -

By raising this PR I affirm that -

[x] My code follows the guidelines of this project.

[x] I have performed a self-review of my own code.

[x] I have commented my code.

[x] My code gives the correct output.

[x] I affirm that I strictly follow contributing guidelines and code of conduct.

Congratulations 🎉 @rishirohilla on your contribution.
Thanks for adding value to this repository. 😊
Let's celebrate this fest 😃 by providing more developers 👨💻👩💻 an opportunity to contribute. Help us make this repository reach far and more by sharing this to your friends and colleagues.
Your efforts can make difference.

Hey 👋, may you also encourage us by clicking the star icon on the repository main page. ⭐


Default colourbar extend='max' when minimum level or value is zero

cf-plot has an 'extend' keyword option to cbar, levs and to specific functions to enable or disable extension markers on each end of the displayed colour bar, which is set by default to be enabled at both ends:
https://github.com/NCAS-CMS/cf-plot/blob/a325942415561e5a22773715ff3946e1416094f7/cfplot/cfplot.py#L8618-L8619
which produces colour bar ends like this (see red annotations):

However, in practice I have seen people show plots in presentations where the values plotted start at zero where the extension marker is still at the lower end. This made me think that we should update our default behaviour.
Namely, given very often when data values begin at 0(.0) that means the data in question doesn't make physical sense as a negative value, e.g. for a ratio or fraction such as albedo, for a vector magnitude such as wind magnitude, or for a scalar quantity such as mass which has no meaning in negative terms.
In these cases by default we still show the extension markers on the lower end, which is misleading data visualisation (and as much as the user should change this on the plot to correct it, often I have seen this hasn't been done - maybe they didn't have the time, or weren't aware that cf-plot allows one to configure this). In these cases, the colour bar should have extend='max' as the default behaviour, so that only the colour bar upper end gets the extension marker end:

(Note this would only be default behaviour, and can still be overridden by the user in case the range of possible values does extend below zero and they just happen to want to show the levels beginning with zero.)

Hi Sadie - I'm not sure about treating zero as a special case (if I understand correctly). Wouldn't it be better to compare the data minimum with the colour bar mininum and (by default) add the extension triangle only if the former is greater than the larger? Similarly for the maximum.

Hi @davidhassell. Yes, you do understand correctly, I believe zero should be a special case, for the reasons I outline, notably (the 'TLDR' key bit):

when data values begin at 0(.0) that means the data in question doesn't make physical sense as a negative value, e.g. for a ratio or fraction such as albedo, for a vector magnitude such as wind magnitude, or for a scalar quantity such as mass which has no meaning in negative terms.

Fair enough that you disagree (or question) this! I like your alternative suggestion, though I want to play around with some real datasets and plots of them to convince myself it will produce sensible extension markers, or lack thereof, in the majority of cases. Thanks, I'll keep you updated here once I have time to investigation.


Fix client connection deadlock [closes #326]

I think I'm starting to get a picture of the problem, here. (Please correct me if I'm wrong.)
share::RecvStream holds a streams::OpaqueStreamRef (via share::ReleaseCapacity). The OpaqueStreamRef is one of the structs that can hold a reference on the Arc. The other struct is streams::StreamRef (which in turn has an inner OpaqueStreamRef).
Here's an ASCII art diagram showing the hierarchy (as I understand it):
Process
└── share::RecvStream
    └── share::ReleaseCapacity
        └── streams::OpaqueStreamRef
            └── streams::Streams

client.handshake
└── client::Builder
    └── client::Handshake
        └── client::Connection
            └── proto::Connection
                └── streams::Streams

Process is a struct in the client example. streams::Streams.has_streams_or_other_references is where Arc::strong_countis called: https://github.com/carllerche/h2/blob/c7d4182ffec23bc1f508a62bb59a9c286fdc888a/src/proto/streams/streams.rs#L750-L761
Commenting these checks does indeed prevent the hang...
The race occurs when the proto::Connection future is polled prior to the OpaqueStreamRef being fully dropped. This happens because there are two futures in the client example; client::Connection and Process that both share a reference to the streams::Streams. Which means that success depends on the order which the two futures are polled.
From this perspective, I looked into how proto::Connection gets woken up, and it simply happens here when the OpaqueStreamRef is dropped: https://github.com/carllerche/h2/blob/c7d4182ffec23bc1f508a62bb59a9c286fdc888a/src/proto/streams/streams.rs#L1111-L1119
So the question I had, seeing this condition, is how can I check if all streams are closed on the connection? Well, this looks relevant: https://github.com/carllerche/h2/blob/cf62b783e0bfe7b183cdef78874c5ca6e417c59e/src/proto/streams/store.rs#L196-L198
And the patch works!
I don't know of a good way to test this, other than the STR in https://github.com/carllerche/h2/issues/326#issuecomment-441820232 ... Perhaps creating the two (or more) futures and polling them in deterministic order (instead of on the default tokio runtime) could surface the case where proto::Connection.go_away.should_close_on_idle returns false. But I can't see an obvious way to set it up without a large test fixture and set of mocks.
Because I can't deterministically test it, I honestly don't know if this is the right way to address the issue...

Thanks for diving into this!
It looks like this change doesn't quite do it, as it's causing a couple tests to fail. I believe they are failing because the Connection is being polled before the SendRequest was able to open a stream, and so the Connection is closing immediately.

Hmmm... I did run cargo test, but not the integration tests (with hfuzz). I'll give it another go.

I can't seem to fix it with manual ref counts. I get recursive locks in StreamRef.clone(), for example.
The best alternative I can come up with is deferring the task.notify(), but that will still exhibit non-deterministic behavior.

Could you elaborate more about how you were doing the manual ref count?
My expectation would be this would work...
There are some other examples we could explore though if a manual ref count does not work.

@carllerche It was pretty much like the stream ref counting; just another usize on the streams::Streams struct. The count was incremented every time StreamRef and OpaqueStreamRef were created/cloned, and decremented in drop_stream_ref() before notifying the task.
It also occurred that maybe the task should be notified at a higher-level of abstraction than when a single stream is dropped. But I haven't tried anything with that.


helper classes are now exposed to exports for umd, cjs and iife build…

…s in rollup.config.mjs.

Helper classes are now exposed to exports for umd, cjs and iife builds in rollup.config.mjs.
This is a useful modification for users who are using the js-sdk through cdn as UMD or CJS modules (for example, for implementing custom AuthStore for local persistance)
dist has also been rebuilt after the modification

There are no plans for this as it will be a breaking change for those who rely on the current CJS bundle.
Additionally the CJS bundle is considered deprecated and will be removed in the future.


Plotting nyquist plot from FrequencyResponseData fails

When trying to create the nyquist plot from an FRD system
freq_response = ct.FRD(response, frequencies)
ct.nyquist_plot(freq_response)

the plotting fails with the following error
AttributeError: 'FrequencyResponseData' object has no attribute 'poles' during the call of _default_frequency_range
version: 0.10.0

Is it possible to make a Nyquist plot given only frequency response data?

You can get a valid Nyquist plot from the frequency response in some instances and with some assumptions.  Basically, if the open loop dynamics are assumed stable, the zero frequency gain is finite, and the high frequency gain is zero, it should work.
The error above comes when it tries to compute the default frequency range for the plot, but in the case of frequency response data you don't actually need to do that.
A quick fix is to change the call to be ct.nyquist_plot(freq_response, freq_response.omega), which bypasses the computation of the default frequency range.

Fixed in #996.


How to run cyclonedx-cli

Is there any document to show the installation steps and how to run this tool?

There is a docker container that can be used with the -rm option:
docker run --rm -it cyclonedx/cyclonedx-cli --help
This should probably be described in the readme.
Or you download the binary from the release page.
This is actually described in the readme.

My bad I couldn't run it in linux.

CYCLONEDXCLI_LATEST_URL=`curl -s https://api.github.com/repos/CycloneDX/cyclonedx-cli/releases/latest | jq -r '.assets[] | select(.name | contains ("-linux-x64")) | .browser_download_url' | grep -v md5`
mkdir -p /opt/cyclonedx-cli
wget -q -O /opt/cyclonedx-cli/cyclonedx-cli ${CYCLONEDXCLI_LATEST_URL}
chmod +x /opt/cyclonedx-cli/cyclonedx-cli
ln -s /opt/cyclonedx-cli/cyclonedx-cli /usr/local/bin/cyclonedx-cli
cyclonedx-cli -h


Improve _events validation

Raise a warning if the last (latest) event has onset before the halfway mark of the duration of the corresponding scan (number of volumes * TR). The design is suspiciously short.
Raise a warning if the last (latest) event has onset after the end of the duration of the corresponding scan. The design is suspiciously long.

@chrisfilo do you have example datasets that are passing / violating these requirements handy?

https://openneuro.org/datasets/ds000114/versions/1.0.0/file-display/task-fingerfootlips_events.tsv

breaking modification 1: remove bottom 70% of rows
breaking modification 2: add an event with onset time of 2000


Danny Colin (anthropology)

Name of the organization
Danny Colin
@dannycolin on github
@dannycolincom on twitter
Contact name and informations
Grad student in anthropology at the University of Montreal

Oh I'm still an undergrad. It's my last year tho ;). Btw, I saw you're from Montreal. Are you still studying at a Uni?


Add a conda/mamba environment file

Enhancement 🚀
Lots of people uses conda or mamba to manage virtual environments and to get faster package resolution/solving and downloads. It would be great if this project had an environment file that had all the dependencies needed to install just deepdoctection from pip.
Motivation  💪
People wouldn't have to deal with installing certain critical dependencies themselves that have massive binaries via pip, like torch (e.g. with CUDA).
Additional context 🧬
Dependencies are currently defined in setup.py and are copied into requirements.txt using pip-compile.
https://github.com/deepdoctection/deepdoctection/blob/7d8fd153d4cf5dfa0c5f038eeaca2f8a603d3a79/setup.py#L42-L101
It would also be great if we created a feedstock so this package could be on conda-forge!

Thank you very much for the suggestion, this would indeed help a lot of users.


dependencies for python app should be loaded with setuptools

@objectiser could you please review? It's just a minor thing.

Wondering whether we should use autobuild for docker images, however it would require to build images  when reviewing (which is good but might be more time consuming).

@pavolloffay LGTM :+1:
Sounds reasonable  (autobuild).


Read DAPR_GRPC_PORT env for grpc api call in test

Description
Read DAPR_GRPC_PORT env for grpc api call in test
Issue reference
n/a
Checklist
Please make sure you've  completed the relevant tasks for this PR, out of the following list:

[ ] Code compiles correctly
[ ] Created/updated tests
[ ] Unit tests passing
[ ] End-to-end tests passing
[ ] Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]
[ ] Specification has been updated / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]
[ ] Provided sample for the feature / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

/ok-to-wintest

/ok-to-wintest

/ok-to-wintest


These IM related callbacks contains small or no generated code, should be put into separate file to reduce the size of template. }}

false

https://github.com/project-chip/connectedhomeip/blob/f0f5de0d79ae1c51d7fddbf70900ebac0acd899a/src/app/zap-templates/templates/app/CHIPClientCallbacks-src.zapt#L118-L123

This issue was generated by todo-issue based on a TODO comment in f0f5de0d79ae1c51d7fddbf70900ebac0acd899a.

Moved to post v1 as this does not seem to be a blocking bug but more maintenance of template logic (overly long templates and repeated code).


Bump Apache SSHD to 2.10.0

@bot-gradle test this

I've triggered the following builds for you. Click here to see all build failures.

PullRequestFeedback build

Closing, as @ljacomet solved the problem.


fixes #73

do not use Enumeration#Value twice with the same id
bump version to 2.0.3-SNAPSHOT
adds ScalaTest test dependency with unit test for #73

Since 2.0.2 is critically broken, also please bump this ASAP to 2.0.3 stable and publish artifacts.

Ping - we should push this ASAP, otherwise there will be projects starting to depend on a broken version.

@SethTisue 2.0.3 staged, please sonatypeRelease


Image always nil on real device

When using pod on simulator, code work like charm but when using on real device fullResolutionImage is always nil.
I've been working on this for 3 hours ... and i'm going nowhere do you have a solution for this ?
PS: I'm using iPhone 7+ with iOS 11.1
func dismissPhotoPicker(withTLPHAssets: [TLPHAsset]) {
        if withTLPHAssets.count != 0 {
            let asset = withTLPHAssets[0]

            if asset.type == .photo || asset.type == .livePhoto {
                self.photoArray[self.selectedRow] = asset.fullResolutionImage
            }

            self.refreshUI()
        }
    }

@rico237
Are you used icloud photos?
I thinks, "fullResolutionImage" method is get image request using wrong options.
https://stackoverflow.com/questions/31037859/phimagemanager-requestimageforasset-returns-nil-sometimes-for-icloud-photos
Try this.
func dismissPhotoPicker(withTLPHAssets: [TLPHAsset]) {
        // use selected order, fullresolution image
        if withTLPHAssets.count != 0 {
            let asset = withTLPHAssets[0]
            self.getImage(phasset: asset.phAsset)
            print("aa\(test)")
        }
    }
func getImage(phasset: PHAsset?) {
        guard let asset = phasset else { return }
        let options = PHImageRequestOptions()
        options.isSynchronous = false
        options.isNetworkAccessAllowed = true
        options.deliveryMode = .opportunistic
        options.version = .current
        options.resizeMode = .exact
        options.progressHandler = { (progress,error,stop,info) in
            //progressBlock(progress)
        }
        let requestId = PHCachingImageManager().requestImageData(for: asset, options: options) { (imageData, dataUTI, orientation, info) in
            if let data = imageData,let _ = info {
                //completionBlock(UIImage(data: data))
                print(data)
            }
        }
    }

OMG !!
I really thank you for your answer and how quickly you provided me with a solution <3
It worked like a charm
Again thank you so much !! 👍


syntax highlighting fails on multi-line arrow functions

Also note that the syntax highlighting doesn't work if the const does not have flow types.

Yes this is an issue that I can't fix. I can't read ahead to find out that this is a function because the arrow appears on a later line. This is a limitation of textmate grammars. Therefore I don't know that the bracket contents are arguments. The Atom team are working on a proper grammar parser based upon incremental AST that should be able to parse this type of construct. You can see their progress at github.com/tree-sitter.

It's a great shame as prettier makes this type of syntax format more likely. I could probably improve it slightly but I always run into edge cases. With tree-sitter promising super fast parsing and a robust AST I think that textmate grammars will be a thing of the past. That is why I'm a bit reluctant to do too much work in this area. I may revisit this given some time to see if any small changes can improve the result.
FYI VSCode also has similar problems.

Actually I forgot I made some changes in the middle of last year that make this possible! I just pushed 2.57.1 that should fix this. One thing I can't do is scope the const var name as a function as I explained earlier.
@mgmcdermott Can you check that the flow types are correctly highlighted and that the body return is now correct? For reference what is the theme you are using?

@mgmcdermott I think you are using oceanic-next. If so then this is the best I can do. In my grammar the function block, including its body, has a meta scope of meta.function.js whereas the multiline arrow func has no such scope. Again this is because the the parameter args have already been parsed by the time the arrow is encountered.
oceanic-next scopes any class=function/variable./readwrite as orange.

Sorry for the delay @gandm but I appreciate the quick response. This is a major improvement for me. Thanks.


Update operators.py --- copy edits (grammar, consistency, clarity)

In addition to fixing typos for the word "specialized" and changed "dedicated for" to "dedicated to" --  I also adjusted something that seemed to render differently than planned --
The auto docs said "additional arguments are field names passed to the function" but it showed up on the web page as "(additional areguments are field names passed to the) - name of function" -- I changed it to "field names passed in" -- I hope this renders better.

Closed this and created another pull request for all of the changes, since this one seems to have a commit not signed off properly?


Create PBS scripts for various experiments

Now that we have a few types of experiments to run, we should create some scripts that can be run on Palmetto. The general form will probably be:

specify PBS parameters
load modules
run scripts/cross-validate.py several times with various parameters

I should have a few basic scripts on the repo soon.

We have a few scripts covering basic experiments now, other experiments should be easy to create from these scripts.


JWS has invalid anti-replay nonce

After the closing of #339 I tried to generate the certificates but I still get the same error:
This are the commands I runned:
(changed some data for privacy)
$ date
Mon Mar 20 21:15:53 CET 2017

$ mkdir -p /root/lego
$ docker pull xenolf/lego
Using default tag: latest
latest: Pulling from xenolf/lego

709515475419: Already exists
08590bbbf3a6: Pull complete
Digest: sha256:81eb513d461b6a2ed03b055fddcc33cb906b21b8c6a4d33b3f3f483952175edc
Status: Downloaded newer image for xenolf/lego:latest

$ docker run --rm --name lego -v /root/lego:/.lego --env GANDI_API_KEY=xxxxxxxxxxxxxxxxxxx xenolf/lego --domains joan.domain.com --email<EMAIL_ADDRESS>--accept-tos --dns gandi --dns-resolvers a.dns.gandi.net --pem run
2017/03/20 20:16:12 [INFO][joan.domain.com] acme: Obtaining bundled SAN certificate
2017/03/20 20:16:12 [INFO][joan.domain.com] AuthURL: https://acme-v01.api.letsencrypt.org/acme/authz/ESZNvYshFPRkWSybn9Huo4QqVfR4lvLIpQxeZ_cTWZQ
2017/03/20 20:16:12 [INFO][joan.domain.com] acme: Trying to solve DNS-01
2017/03/20 20:16:15 [INFO][joan.domain.com] Checking DNS record propagation using [a.dns.gandi.net:53]
2017/03/20 20:34:23 [joan.domain.com] Could not obtain certificates
	acme: Error 400 - urn:acme:error:badNonce - JWS has invalid anti-replay nonce BOyYLPtyguoonH3VnVm1pr0NIBd6d5g6mbztjU2BX28

Does the latest docker image includes the changes?

@jfisbein please try again with current master. I placed the fix on a code path where it was never hit, #367 fixes this.

ir worked!!
thanks!
2017/03/30 08:04:28 [INFO][joan.mydomain.com] acme: Obtaining bundled SAN certificate
2017/03/30 08:04:28 [INFO][joan.mydomain.com] AuthURL: https://acme-v01.api.letsencrypt.org/acme/authz/nIDbvAmqBn7_9se6DAXq5FIa3_wXFNLOejLQx5MGz18
2017/03/30 08:04:28 [INFO][joan.mydomain.com] acme: Could not find solver for: http-01
2017/03/30 08:04:28 [INFO][joan.mydomain.com] acme: Trying to solve DNS-01
2017/03/30 08:04:31 [INFO][joan.mydomain.com] Checking DNS record propagation using [a.dns.gandi.net:53]
2017/03/30 08:31:55 [INFO][joan.mydomain.com] The server validated our request
2017/03/30 08:31:56 [INFO][joan.mydomain.com] acme: Validations succeeded; requesting certificates
2017/03/30 08:31:57 [INFO] acme: Requesting issuer cert from https://acme-v01.api.letsencrypt.org/acme/issuer-cert
2017/03/30 08:31:57 [INFO][joan.mydomain.com] Server responded with a certificate.


Distx 534 use v1 committer for spark

DISTX-534 As per TSB-437, FileOutputCommitter algorithm v2 may result into
bad output data. Hence it has been advised to go back to v1 version.
This commit makes following config changes in 710, 720, 721, 722, 723
DE, DE HA & Spark3 templates so that v1 algorithm is configured ootb
in DH clusters :
fs.s3a.committer.name=directory
mapreduce.fileoutputcommitter.algorithm.version=1
spark.hadoop.mapreduce.fileoutputcommitter.algorithm.version=1
Testing done :
Have created a DE cluster using a modified 7.2.2 template that includes above mentioned config changes. Cluster creation was successful on AWS using m5d.2xl instance types.

@keyki @lnardai Please merge it in CB-2.31.0 as well as master once its reviewed and all the tests pass.

@steveloughran Pls review and approve it.

@amitagarwal06 is it needed into 2.31? Is there any issue with current solution? If not, please change this PR's target to master, since we are about to release 2.31. Merging changes like this can cause major delay in release process, so if this is required, we can still add this later in 2.31 and release it using hotfix process.

@horadla23 As mentioned in the PR comment, there is data correctness issue in FileOutputCommitter algorithm version V2 which effects customers using Spark (on previous version of clusters too). Hence its required to configure a prior version V1 of the algorithm. It is very much needed as per TSB (https://jira.cloudera.com/browse/TSB-437), that is why I have been asked to put this in CB-2.31.0 as well as master branches.
cc @shwethags can also add her thoughts.

And do we know about any customer issue caused by using v2?
I'm ok with this if it impacts customers, but without it, it is little bit risky to merge this into 2.31, since it affects all DE templates and this requires retesting on AWS and Azure all DE templates enabled in 2.31. But after proper test it can go into 2.31 and can be released via hotfix process.

I will coordinate with Prasad for testing. Can we get this in CB 2.31 as its for the TSB issue


Using a SQL Container with a Volume

We need an example about how to configure SQL Server container with a Volume using Aspire. I have tried using the method WithVolumeMount, but with no luck.

https://github.com/dotnet/aspire/issues/974

Agreed this would be a good sample to have. I'm thinking of just having a default Blazor app with Identity (individual accounts auth) configured to use SQL Server, hosted via an AppHost that composes in a SQL Server container as the store.


Permissions to run RLA are incorrect

>The account that you use to run the Replication Link Analyzer must have local administrator rights on each computer that is involved in the replication link. The account does not require a specific role-based administration security role.
That's not enough, since RLA also performs SELECT queries to few DB tables, and machine admin is not necessary even a DB reader for SQL.
So we also require at least SQL DB Reader to run the tool properly, and maybe more permissions to perform fixes.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 669373a9-3d4b-73dd-5d3e-1bca2af0ccf4
Version Independent ID: 81b0c667-debc-7053-6678-26724f52b81b
Content: Monitor replication - Configuration Manager
Content Source: sccm/core/servers/manage/monitor-hierarchy-and-replication-infrastructure.md
Product: configuration-manager
Technology: configmgr-other
GitHub Login: @mestew
Microsoft Alias: mstewart

Hi @Yupiter2005, I'm currently reviewing this article along with others for some new content we're adding. I noticed that the RLA prereq section has two bullets, one for local admin rights, and one for sysadmin rights.  (I can't link straight to that section with how the current article is structured, but go to the RLA section and then scroll down to the bold text: Prerequisites to use the Replication Link Analyzer:)
I think that addresses your concern, so I'm going to close this issue. Please reopen the issue if I'm missing something.


Reset App late in day causes "Limit already reached" error message

Avoid duplicates

[X] Bug is not mentioned in the FAQ
FAQ entry https://www.coronawarn.app/en/faq/#API39508 is related and is in the process of being updated (see https://github.com/corona-warn-app/cwa-website/issues/781)
[X] Bug is specific for Android only, for general issues / questions that apply to iOS and Android please raise them in the documentation repository
[X] Bug is not already reported in another issue
This is a follow on to "Resetting the CWA triggers error 39508" https://github.com/corona-warn-app/cwa-app-android/issues/934 and it is related to "Error 39508 / Limit already reached" https://github.com/corona-warn-app/cwa-app-android/issues/1459

Technical details

Device name: Samsung Galaxy Tab A SM-T510
Android version: 10
App version: 1.11.0
ENS version:<PHONE_NUMBER>0

Describe the bug
If CWA is reset in the late evening after 6 exposure checks have been done, then after onboarding, the "Limit already reached" error message is displayed following by "Check is running".
Exposure checks start working correctly however in the early hours of the next day.
Steps to reproduce the issue

Connect device to charger and ensure WiFi access is available.

Examine exposure log after 20:00 UTC through Settings > Google > COVID-19 Exposure Notifications > three-dot overflow menu > Exposure checks.

If 6 exposure checks after 00:00 UTC (currently 01:00 CET) on the current day have already been carried out, then ...

CWA > three-dot overflow menu > Settings > Reset App.

Go through onboarding and activate exposure logging.

Note error message "Limit already reached"

Expected behaviour
Carrying out Reset App should not lead to an error message. After a reset a user can expect not to be influenced by past history.
Possible Fix

Increase the interval between exposure checks to 5 hours.
or
When resetting the app, check if the quota has been exceeded and delay exposure checks until after the quota has been reset by ENS. Suppress the generic error message and output instead an error message for this specific situation.

Internal Tracking ID: EXPOSUREAPP-4947

@MikeMcC399, Thanks. Internally tracked, see above.

We should not increase the check period for all user because of this edge case.
After a reset don't have the information how many ENF checks where uses for this. We cannot delay the check.

@dsarkar
Could we please add the https://github.com/corona-warn-app/cwa-app-android/labels/wontfix label to this issue? @thomasaugsten commented in https://github.com/corona-warn-app/cwa-app-android/issues/2248#issuecomment-773900831 and then closed the issue.
I have suggested in https://github.com/corona-warn-app/cwa-website/issues/848 that we add this information to https://www.coronawarn.app/en/faq/#API39508 so that users know it is expected that "Limit already reached" can appear if the app is reset after 21:00 in winter or 22:00 in summer if it has been permanently connected to WiFi during the day (and possibly also permanently connected to a charger).


Cellnoise - visible noise from far away

Open "Tube lights and local fog density" scene and put the camera to:

You should see this:

I could locate the source of this noise which is in VolumetricFog.cginc - Fog function
uvw.xy += cellNoise(uvw.xy * _Screen_TexelSize.zw) * _VolumeScatter_TexelSize.xy * 0.8;
This removes the noise but also introducs banding:
uvw.xy += /*cellNoise(uvw.xy * _Screen_TexelSize.zw) */ _VolumeScatter_TexelSize.xy * 0.8;
I rewrote the Fog method to also have a time parameter to enable scrolling the cellnoise. With an applied Temporal Anti-Aliasing the results were not bad but still not good enough. The distribution pattern of the cellnoise doesn't seem to help in this problem.

A lot of the problems where talked about in the Inside rendering talk (https://www.youtube.com/watch?v=RdN06E6Xn9E)
They used a blue noise in the end. Can we also do this?

I intentionally introduced the noise to hide banding artifacts (which get more pronounced when there are volumetric shadow edges in view).
I'm very aware of Mikkel's research on the topic and I'll be working on improving banding removal in the coming months, for our current demo.


Change the default gravity values

By using the default physics values like suggested by @aaronfranke on #53957, I noticed they seem to be wrong.
it's easier in 3D as we can tell we must target the reality scale. I tested on a character (1m50) from my project. I set the value from 9.81 to 61.25 (0.98/0.016 (delta))  (https://github.com/fabriceci/3d-platform-test-for-godot4) with as code, the new default template for CharacterBody3D
Before:

After:

In 2D is a bit touchy, as the scale is relative to the project. But as we need to choice one to define a default, I suggest to choice the one relative to the most used character in Godot Games. I set the value from 980.0 to 2900.0 (just by feeling)

(64x64)
Same very basic, just the icon with the new default template.
Before:

After:

Whoa, why do you need nearly 10 times the real gravity for realistic behavior?

So there doesn't seem to be a problem with the equations themselves, default gravity of 9.8 does work as expected. Maybe the default damping is a bit high though if it leads most users to find that Godot physics are too floaty, though we'd need more data to be sure. Otherwise the points raised by pouleyKetchoupp above are quite valid.

I think setting the default linear damping to 0 might be a good idea. It's not realistic by any means, but most game physics don't seem to feature any kind of air resistance by default.

I think setting the default linear damping to 0 might be a good idea. It's not realistic by any means, but most game physics don't seem to feature any kind of air resistance by default (especially on the Y axis).

It would be worth decreasing the value if it feels too floaty at the moment, although I'm not too sure about setting 0 by default. It's not just useful to simulate air friction, it also helps with stabilization and performance by lowering the velocity until the body sleeps.


adding support for dragonfly

This would add support to test dragonfly using test-containers-python
This include:

new entry in the test containers list.
update the readme file.
update github workflow.
Note that since dragonfly work out of the box with the same clients as Redis, there is no requirement to change the installations or dependencies here.
Signed-off-by: Boaz Sade<EMAIL_ADDRESS>

Closing this PR for now because we can use the redis container with a different image (see #126 for a similar discussion).


Refactor mariadb to match keystone template layout

Convert the template layout to match the new keystone template layout, which is more readable and supports testing of injected scripts as they are not wrapped in nested YAML.

This is part of https://github.com/att-comdev/aic-helm/pull/49


Game_state - KeyError: 'bdraw'

Hi.
In this error im playing with White and I'm getting that "b" that generate this error. (the "b" the 0 position for black, but why can handle this¿) What can be wrong here¿
What can i do¿

File "/usr/lib/python3.10/threading.py", line 1009, in _bootstrap_inner
    self.run()
File "/home/panchines/.local/lib/python3.10/site-packages/lichs/Game.py", line 27, in run
    self.handle_state_change(event)

File "/home/panchines/.local/lib/python3.10/site-packages/lichs/Game.py", line 35, in handle_state_change
    if game_state[self.color[0].lower() + "draw"] == True:
KeyError: 'bdraw'

If i delete this:
if game_state[self.color[0].lower() + "draw"] == True:             self.handle_draw_state(game_state)
The program works..... but if somebody try to offer draw, nothing happend.


Add per-package whitelisting for non-free packages

This is unlike https://github.com/NixOS/nixpkgs/pull/5892 which is about licenses.
I appreciate that Nix blacklists non-free packages by default, but it's really unfortunate to have a single action to remove that blacklist, even on a per-license basis. Anyone who isn't 100% hard-core software freedom person will choose to remove the blacklist and then all packages will seem similar.
The ideal behavior is that the user should have to take some action each and every time they want to install a non-free package. That way, they receive warning about packages being non-free. I may decide that accepting non-free terms is ok for one particular package and would not want to otherwise ignorantly install anything else non-free.
Please support one-by-one whitelisting of non-free packages so that everyone can choose to install particular non-free packages but still be warned / blocked about any other non-free packages in the future.

This is actually supported, but undocumented. There is an option to white-list packages even if they are unfree, called allowUnfreePredicate in the code.
Look here

There is actually an issue (#4389) about this. I want to solve that issue after #5892 or maybe in one step with #5892.

Seems like allowUnfreePredicate is documented now, so nothing left to do here.


Mail Notification Component Demo

Mail Notification Component Demo
Cannot be merged until approved and new components are merged into blur-admin, will conflict w/ the notifications demo, I will fix conflicts when the changes in blur are approved/merged.

Merge conflicts on this one


HLO: Spellbook not fully imported

When importing my wizard, it didn't import all the spells he knows.
I forget exactly which but either it only imported the spells I currently have memorized and/or only my "free" spells section of the spellbook. I had several more in the same spellbook added/bought and those didn't seem to import.
*Still saved me a LOT of time! Woot! Keep up the good work :)

Send me the export token so I can try to reproduce :)

I just updated #14 with token and screenshot. Can test both issues with same character :)

nevermind, hold off on this. I think i see the issue

I think this is fixed now -- if you're not the GM, have the GM update the module and try again

This one still doesn't seem to be correct.  It looks like it's only pulling in spells I currently have "Memorized". Interesting enough, it pulls it only if "Memorized" is > 0, and doesn't matter what slot, i.e. Fireball imports ok because I have it memorized as Bonus Evocation Spells and Longstrider imports ok because I have it memorized in a 2nd level slot.

What is NOT importing are spells from the "Spellbooks and Spells Summary" section in HLO. This is where you denote which spells you learn for free at each level, as well as any you "purchase".  For instance, I have Animate Rope as a 1rst level, but not memorized, so it's not being imported.
FWIW I don't really care if it can't import/set what I have memorized, as long as all the spells are added to my spell book TO memorize :)
I'll hop on the discord if you need more help.

Ah yes, this is a known issue. If you take a look at the json export from Herolab Online, you'll notice that they don't include spells that are not memorized.  I have an open ticket with them about it. There's nothing I can do, unfortunately. I recommend having all spells prepped if you want them to be included in the export. Obviously this will show an error within HLO that you have too many spells prepped, but it's the only work-around for the time being.


Does 'tx.commit()' has timeout feature?

We are using babrahams:transaction library in our project. We have business case where we need to add timeout as part of transaction commit(tx.commit()). If transaction is taking more that x milliseconds to complete all queries to commit, then it should rollback all the changes.
Please let me know whether this can be achieved using babrahams:transaction library? If not, can this be achieved logically in meteor code?
Thanks in advance.

Hi,
I think it times out and automatically rolls back if the transaction is idle (no new writes) for longer than 5 seconds. You can set this default timeout by changing the 5000 to, say, 2000:
tx.idleTimeout = 5000;

But I don't think there's a way to make the transaction just cut out and roll back everything after a certain amount of time has elasped.
Brent


Fix for adding more authentication fields

This pull request is in reference to
#84 and #87
The modification in #87 did not result in JSONObtainWebToken reflecting the added authentication fields. The fix involved referencing jwt_settings.JWT_GET_USER_BY_NATURAL_KEY_HANDLER(username) in decorators.py as well as in backend.py instead of using utils.get_user_by_natural_key.
After including the following code below in settings.py of the Django web. It is possible to make a graphql mutation using the additional fields email, phone by adding the respective strings into the username field or from the customized get_user_model().USERNAME_FIELD to log in. There is a need to ensure that email, phone are unique in the user model used.
from django.contrib.auth import get_user_model
from django.db.models import Q

def custom_get_user_by_natural_key(username):
    User = get_user_model()
    try:
        return User.objects.get(
            Q(username=username) | Q(email=username) | Q(phone=username)
        )
    except User.DoesNotExist:
        return None

GRAPHQL_JWT = {
    'JWT_GET_USER_BY_NATURAL_KEY_HANDLER': custom_get_user_by_natural_key
}

Example graphql query possible now
# using username
mutation {
  JSONObtainWebToken(username: "myUsername" password: "examplepassword") {
    token
    refreshToken

  }
}

# using email
mutation {
  JSONObtainWebToken(username<EMAIL_ADDRESS>password: "examplepassword") {
    token
    refreshToken

  }
}

# using phone number
mutation {
  JSONObtainWebToken(username: "12346789" password: "examplepassword") {
    token
    refreshToken

  }
}

Codecov Report

Merging #108 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #108   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files          17     17
  Lines         280    279    -1
  Branches       31     31
=====================================
- Hits          280    279    -1

Impacted Files
Coverage Δ

graphql_jwt/backends.py
100% <100%> (ø)
:arrow_up:

graphql_jwt/refresh_token/relay.py
100% <0%> (ø)
:arrow_up:

graphql_jwt/refresh_token/mutations.py
100% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc9a54b...c2eed80. Read the comment docs.

Hey @JSeam2 ,
you don't need to modify the package, just create an authentication backend and use your JWT_GET_USER_BY_NATURAL_KEY_HANDLER function to retrieve the user.
See: https://docs.djangoproject.com/en/3.0/topics/auth/customizing/
I close the PR, if you have any questions please let me know.

Good day @mongkok ,
The issue with just using JWT_GET_USER_BY_NATURAL_KEY_HANDLER on my side is that customizing this doesn't allow me to log in with either username or email should I set
def custom_get_user_by_natural_key(username):
    User = get_user_model()

    try:
        return User.objects.get(
            Q(username__iexact=username) | Q(email__iexact=username)
        )
    except User.DoesNotExist:
        return None

GRAPHQL_JWT = {
    ...
    'JWT_GET_USER_BY_NATURAL_KEY_HANDLER': custom_get_user_by_natural_key
}

On my side, I created an account with username = asdf, email =<EMAIL_ADDRESS>and password = asdf.
When I log in with only the username, it is ok.
mutation {
  obtainToken(
    username: "asdf"
    password: "asdf"
  ) {
    token
    refreshToken
  }
}

When I log in with only the email, I get a Please, enter valid credentials error.
mutation {
  obtainToken(
    username<EMAIL_ADDRESS>    password: "asdf"
  ) {
    token
    refreshToken
  }
}

Hence, I decided to invoke jwt_settings.JWT_GET_USER_BY_NATURAL_KEY_HANDLER(username) in decorator.py. Do you have any solutions regarding this?

Hi @JSeam2,
I think the right approach is to create an authentication backend:
from django.contrib.auth import get_user_model

UserModel = get_user_model()

class CustomBackend:

    def authenticate(self, request, username=None, password=None, **kwargs):
        if username is None or password is None:
            return None

        user = custom_get_user_by_natural_key(username)

        if user is not None and user.check_password(password) and user.is_active:
            return user
        return None

    def get_user(self, user_id):
        return None

...and add the backend to your AUTHENTICATION_BACKENDS:
# settings.py
AUTHENTICATION_BACKENDS = [
    'graphql_jwt.backends.JSONWebTokenBackend',
    'path.to.CustomBackend',
    'django.contrib.auth.backends.ModelBackend',
]

@mongkok Noted, thanks for the advice!


gawk: 5.1.1 -> 5.2.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/gawk/versions.
meta.description for gawk is: "GNU implementation of the Awk programming language"
meta.homepage for gawk is: "https://www.gnu.org/software/gawk/"
meta.changelog for gawk is: ""
Updates performed

Version update

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 5.2.0 with grep in /nix/store/s0jz4zl0fni9q1xv5padn8x8jzprmsld-gawk-5.2.0
found 5.2.0 in filename of file in /nix/store/s0jz4zl0fni9q1xv5padn8x8jzprmsld-gawk-5.2.0

Rebuild report (if merged into master) (click to expand)

57140 total rebuild path(s)

57140 package rebuild(s)

First fifty rebuilds by attrpath

AMB-plugins
ArchiSteamFarm
AusweisApp2
CHOWTapeModel
ChowCentaur
ChowKick
ChowPhaser
CoinMP
CuboCore.coreaction
CuboCore.corearchiver
CuboCore.corefm
CuboCore.coregarage
CuboCore.corehunt
CuboCore.coreimage
CuboCore.coreinfo
CuboCore.corekeyboard
CuboCore.corepad
CuboCore.corepaint
CuboCore.corepdf
CuboCore.corepins
CuboCore.corerenamer
CuboCore.coreshot
CuboCore.corestats
CuboCore.corestuff
CuboCore.coreterminal
CuboCore.coretime
CuboCore.coretoppings
CuboCore.coreuniverse
CuboCore.libcprime
CuboCore.libcsys
DisnixWebService
EBTKS
EmptyEpsilon
FIL-plugins
Fabric
HentaiAtHome
LAStools
LASzip
LASzip2
LibreArp
LibreArp-lv2
Literate
MACS2
MIDIVisualizer
MMA
NSPlist
OSCAR
OVMF
OVMFFull

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/s0jz4zl0fni9q1xv5padn8x8jzprmsld-gawk-5.2.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A gawk https://github.com/r-ryantm/nixpkgs/archive/654db5814c2cac2348f60cb2181730e943238b18.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/s0jz4zl0fni9q1xv5padn8x8jzprmsld-gawk-5.2.0
ls -la /nix/store/s0jz4zl0fni9q1xv5padn8x8jzprmsld-gawk-5.2.0/bin

Pre-merge build results
NixPkgs review skipped

Maintainer pings

5.2.1 is out and should be safer to use. Would r-ryantm update PR if we un-draft it? Trying.

Let's close it and allow bot to retry from scratch.


Polygons deform on zoom (android)

I encounter an issue on displaying some squares on map. (using 'com.mapzen.tangram:tangram:0.4.5')
In total there are 12 x 12 squares around the globe.
Everything looks ok upon a certain zoom level:

When zoomed in a little bit more:

I have tried changing the style to "lines" / "points" and the polygon outlines also deform like what you see above. I also note that more squares deform if I remove the gap between each square, don't know if this is related.
Here is the code:
        for(int j = 0; j < 12; ++j) {
            for(int i = 0; i < 12; ++i) {
                List<List<LngLat>> xss = new ArrayList<>(1);
                List<LngLat> xs = new ArrayList<>(4);
                xss.add(xs);
                xs.add(new LngLat(lng[i + 0], lat[j + 0]));
                xs.add(new LngLat(lng2[i + 1], lat[j + 0]));
                xs.add(new LngLat(lng2[i + 1], lat2[j + 1]));
                xs.add(new LngLat(lng[i + 0], lat2[j + 1]));
                data.addPolygon(xss, null);
            }
        }

and here is the style
layers:
    mylayer:
        data: { source: mysource }
        draw:
          mydraw:
            style: polygons
            color: [1.0, .5, .5, .5]
            order: 553     <--lowering this number won't help.

Is it a bug or am I doing something wrong?
Please help. Thanks.

Hello again, I solved the problem by repeating the first vertex (closing the loop).
List<List<LngLat>> xss = new ArrayList<>(1);
                List<LngLat> xs = new ArrayList<>(5);
                xss.add(xs);
                xs.add(new LngLat(lng[i + 0], lat[j + 0]));    //<----
                xs.add(new LngLat(lng2[i + 1], lat[j + 0]));
                xs.add(new LngLat(lng2[i + 1], lat2[j + 1]));
                xs.add(new LngLat(lng[i + 0], lat2[j + 1]));
                xs.add(new LngLat(lng[i + 0], lat[j + 0]));    //<----
                data.addPolygon(xss, null);

Can someone comment on this? Is this the correct way of doing it?

I had a similar problem when I displayed these kinds of rectangles on the map for debug purposes. So I can reproduce this. If this is intended behavior, I think it would be helpful if this is mentioned in the javadoc for that method.

hmm, I am quite sure this is not the correct way because by adding the 5th point the centroid of the polygon shifted.
As you can see here:

I added the stripes and border so now it is easier to see what is going on.
When zoomed in, 1 centroid split into 4!

This time I set centroid: false:

And when zoomed in:

It seems additional vertices are added when zooming in.
I guess it is related to the GeoJSONVT library? not so sure...

Hello @westnordost and @lunarflint! I think you've helped us catch a bug or two here :)
@lunarflint was correct in the earlier comment: the rings of polygons added to a MapData should be closed, i.e. the first point should be repeated as the last point. This is in keeping with the GeoJSON geometry definitions, and @westnordost is correct that we should say this in the javadocs.
As you also demonstrated in a screenshot, closing the outer ring of a polygon produces an inaccurate centroid. This is simply because the function we currently use to calculate polygon centroids is, well, it's just wrong.
I'll create issues for both of these problems and link them to this issue for reference.

Javadoc updated: https://github.com/tangrams/tangram-es/commit/249e28c6571a02015c937f15aace9583112195ed

This should be fixed in tangram core now.


[BUG]: Dialog doesn't unmount

Issue description
I want to clear the inputs inside of the dialog, however as it doesn't unmount React's useEffect cleanup function doesn't have an effect.
Media & Screenshots
No response
Baklava Version
No response
Operating system
No response
Priority this issue should have
Medium (should be fixed soon)
Please review the checkboxes that are applicable.

[X] This issue is directly related to React

I think we can use same approach as we did in Drawer component, by removing the content from DOM when the dialog closed. I'm not sure if doing this in frameworks can have any bad side effects.


Commands sent with swagger documentation does not work when service port is different than 10010.

Swagger has been removed. It will be replaced by api doc.


python310Packages.rns: 0.5.3 -> 0.5.4

Diff: https://github.com/markqvist/Reticulum/compare/refs/tags/0.5.3...0.5.4
Changelog: https://github.com/markqvist/Reticulum/releases/tag/0.5.4
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 235841 run on x86_64-linux 1

12 packages built:

python310Packages.lxmf
python310Packages.lxmf.dist
python310Packages.nomadnet
python310Packages.nomadnet.dist
python310Packages.rns
python310Packages.rns.dist
python311Packages.lxmf
python311Packages.lxmf.dist
python311Packages.nomadnet
python311Packages.nomadnet.dist
python311Packages.rns
python311Packages.rns.dist


targets: add support for PAC55XX

Add support for PAC55XX SoCs. Target file has been generated using target-gen and the latest CMSIS pack from
https://www.qorvo.com/extra/keil_pack/.
Tested with probe-rs download/reset on PAC5527. Note that there seem to be some issues with RTT (not when using VSCode extension, though).

merge conflict fixed


What's the meaning of offset in ProjEnc?

I notice there is a variable offset defined in the ProjEnc class at Line33. And it is used for computing idx_xy_dense at Line65. BTW, what's the meaning of idx_xy_dense and f_dense? I didn't find related clarification in the original paper. Can you explain more?
https://github.com/wangzy22/P2P/blob/b26e9942a1bafd70e999815df5feb7d1a3210b4c/models/layers/encoder.py#L33
https://github.com/wangzy22/P2P/blob/b26e9942a1bafd70e999815df5feb7d1a3210b4c/models/layers/encoder.py#L65
https://github.com/wangzy22/P2P/blob/b26e9942a1bafd70e999815df5feb7d1a3210b4c/models/layers/encoder.py#L81

Hi, thanks for your interest in our paper!
The offset variable is designed to project a point into 3x3 pixels that form a square centered at the original projection pixel. Given that the point cloud is sparse, we believe that this densify operation would produce smoother image.
Therefore, idx_xy_dense is the densified index for projection and f_dense is just a duplication of the original feature to match size.


Unknown table engine Kafka

hi i,ve installed clickhouse 19.3.5 on cent 6 , but when i create table with kafka engine, it reports exception about
Received exception from server (version 19.3.5):
Code: 56. DB::Exception: Received from localhost:9002, ::1. DB::Exception: Unknown table engine Kafka.

Unfortunately, Kafka engine is disabled in CentOS 6 build. If you need Kafka - use CentOS 7


TestWorkflowEnvironment timeouts run defer statements

Expected Behavior
Workflows that timeout from TestWorkflowEnvironment.SetWorkflowRunTimeout run deferred statements
Actual Behavior
Workflows that timeout from the real server do not run defer statements

Hrmm, I don't think this is possible in Go without leaking goroutines/memory. Panic and runtime.Goexit both call defer. You can't exit a function without calling defer in any way that I can think of. I'd be curious to know how we do cache eviction and if we run defer then and just discard commands. Seems likely.


Icon upload broken

Hi!
I've created some new (nested) collections for Lemmy / Kbin instances and now I'm trying to set the official logos as icons by uploading them using the "+" button on the "Change icon" window. But no matter what format I use (ICO, SVG, PNG) after selecting the file the Raindrop window just closes and there's no new icon available. I'm using the latest Firefox on Ubuntu (not the Snap version).
Here's an example icon: https://lemmy.world/pictrs/image/66ca36df-4ada-47b3-9169-01870d8fb0ac.png (you can convert it to ICO using https://convertio.co)
Btw: it would be nice if Raindrop would include "Fediverse" icons (Lemmy, Mastodon, etc.)

Hello!
What OS/browser? I tried to upload this specific PNG on macOS/Chrome and it works

I'm using the latest Firefox on Ubuntu (not the Snap version).

Right now it's Firefox 115.0.2 on Ubuntu 22.04.


Test tcolorbox 6.2.0 with LaTeX 2021-11-15

https://github.com/T-F-S/tcolorbox/issues/267

https://github.com/T-F-S/tcolorbox/releases/tag/v6.2.0
https://github.com/latex3/latex2e/releases/tag/release-2021-11-15
https://github.com/latex3/latex2e/releases/tag/release-2021-11-15-PL1

Luckily, \tl_set:Ne is the only variant that's supported in latest l3kernel hence used in tcolorbox v6.2.0, but not added yet back to the l3kernel 2021-11-12. This latter one is the newest version of l3kernel when LaTeX2e 2021-11-15 was just released.


feat(net-report): add net_report::Options to specify which probes you want to run

Description
Breaking change that allows you to specify which probe protocols you would like to run.
Really written so it is easier to test QUIC address discovery on iroh doctor, but this also allows us to test specific protocols in isolation.
Breaking Changes

iroh-net-report

added

net_report::Client::get_report_with_options
ProbeProtocols is now public

changed

net_report::Client::get_report_channel now takes an opts: net_report::Options

Notes & open questions
I'm open to adjustments on the Options. The whole "we build a UDP socket for you if one isn't provided" bit means that I couldn't rely on, for example, stun_sock_v4 == None to know whether the user wanted to run a stun ipv4 probe, so I needed the protocols: BTreeSet<ProbeProtocol> field. I think this is a decent compromise between annoying and useful, but would love feedback.
Change checklist

[ ] Self-review.
[x] Documentation updates following the style guide, if relevant.
[x] Tests if relevant.
[x] All breaking changes documented.

The whole "we build a UDP socket for you if one isn't provided"

I wonder if we should change this

Yes, I agree this is worth trying out.  I forgot what the reason for this is, but I think it might have just been for ease of testing, which you're changing here anyway by being able to not have stun probes when testing.  And in the MagicSock we'll never need this functionality.

I tried to create an alternative that would look like:
Options::run_stun(probe_ipv4: bool, probe_ipv6: socket: None) and so on for each "type" of protocol to keep the functionality and make it consistent.
But I wonder if we should then just remove it completely. Creating a socket is not that big of a hassle to justify essentially equivalent options to behave so differently/inconsistently among them, and make it consistent across protocols is also (comparatively) a lot more work.

Okay here is what it looks like with removing the UdpSocket and adjusting the Options accordingly.


Fix some let cases

While this seems to fix quiet some cases, it seems to also cause a regression. Will need to investigate.


Stub _dm_db procs

We're going to have an internal SQLite instance for these right? Spinup on first use?

/shrug
Sorting out the implementation is a problem for the future.


Small fix in security section of API guidelines document

Problem description
The security section of the document includes the below line
Basic idea in terms of security is to understand that various types of data will require different levels of security, depending on the confidentiality of the data you are trying to obtain and the level of trust between **Telefónica** and the consumer.
Expected behavior
Telefonica reference needs to be changed to a more generic term.
Alternative solution

Additional context

Hi @shilpa-padgaonkar,
Maybe something like  "Resource or Service Provider" ?


Update readme.md with updated links

I noticed there was several dead links in the readme due to the new doc being released. Updated links to their new locations
Fix http->https where possible and update links doc links.
Fixes issue: https://github.com/wycats/handlebars.js/issues/1616

@nknapp Could you verify that I've updated this with the correct links?

Thanks for these updates. I wonder if I should have been more cautious about preserving URLs in the new site.
Maybe we can move content from the README and CONTRIBUTING to handlebarsjs.com, it might be easier to maintain that way.


[SMALLFIX] Improve some worker metrics names and desc

Updated some variable names and metric key descriptions

Codecov Report

Merging #13635 (e868d3e) into master (8f97988) will decrease coverage by 26.16%.
The diff coverage is 80.00%.

@@              Coverage Diff              @@
##             master   #13635       +/-   ##
=============================================
- Coverage     43.76%   17.60%   -26.17%
+ Complexity     9049     2668     -6381
=============================================
  Files          1378     1378
  Lines         79869    79868        -1
  Branches       9713     9713
=============================================
- Hits          34957    14060    -20897
- Misses        41962    64565    +22603
+ Partials       2950     1243     -1707

Impacted Files
Coverage Δ

...n/java/alluxio/worker/block/AsyncBlockRemover.java
55.17% <66.66%> (-27.88%)
:arrow_down:

...ommon/src/main/java/alluxio/metrics/MetricKey.java
97.14% <100.00%> (-0.44%)
:arrow_down:

...mon/src/main/java/alluxio/shell/CommandReturn.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...mon/src/main/java/alluxio/util/ExceptionUtils.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...n/src/main/java/alluxio/wire/AlluxioProxyInfo.java
0.00% <0.00%> (-100.00%)
:arrow_down:

.../src/main/java/alluxio/wire/AlluxioMasterInfo.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...src/main/java/alluxio/job/meta/JobIdGenerator.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...n/src/main/java/alluxio/stress/BaseParameters.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...src/main/java/alluxio/client/UnderStorageType.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...main/java/alluxio/underfs/options/ListOptions.java
0.00% <0.00%> (-100.00%)
:arrow_down:

... and 659 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f97988...e868d3e. Read the comment docs.

alluxio-bot, merge this please

alluxio-bot, cherry-pick this to branch-2.6 please


Maximum call stack exceeded

Thanks for the excellent tool. I find when I paste more than 2 dozen or so lines, I get a maximum callstack exceeded error. Any thoughts of fixing this?
Thanks again!

Can you provide a sample so I can repro?

Actually, you might be running into a bug I fixed in 64ac394. Please pull down that version and see if it works for you.

Hey Dave. Thanks very much for the update. I'll try out the new version and if I'm still hitting the issue I'll make an example repo when I can.
Thanks again for the great library! It's a great thing to have on hand. Must have saved me days and days of coding.

Are you planning to release a versioned update I could pull via npm/yarn?

Yep, as soon as we can verify this bug is squashed. I was also hoping to address #4 and #5 in the next release, but I can publish sooner if it helps.

I published a new version (or three) to npm. Let me know if you're still having problems.

Thanks a lot @dave-kennedy.
That will let me test it sooner. It will be a few days before I can give it a proper test.

Closed due to inactivity.

Whoops thanks for updating the status of this. Yes the update did fix the issue. Sorry for not posting back. Great dev. I really appreciate the update you wrote to fix this issue.


Toggle camera slowing down ui

Ui gets slowed down a bit noticeably while the camera is toggled
what is the solution to this as uiviews cant be manipulated in the background thread? thanks a lot for an amazing library

Switch the camera asynchronously?  I did something like this:
- (IBAction)changeBroadcasterCamera:(id)sender {

    switch (_session.cameraState) {
        case VCCameraStateFront:
        {
            dispatch_async(dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_BACKGROUND, 0), ^{
                _session.cameraState = VCCameraStateBack;
            });
            break;
        }

        case VCCameraStateBack:
        {
            dispatch_async(dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_BACKGROUND, 0), ^{
                _session.cameraState = VCCameraStateFront;
            });
            break;
        }

        default:
            break;
    }
}

Thanks a lot josh :) trying it
On Mon, Jul 6, 2015 at 11:59 AM, Josh Lieberman<EMAIL_ADDRESS>wrote:

Switch the camera asynchronously?  I did something like this:
- (IBAction)changeBroadcasterCamera:(id)sender {

    switch (_session.cameraState) {
        case VCCameraStateFront:
        {
            dispatch_async(dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_BACKGROUND, 0), ^{
                _session.cameraState = VCCameraStateBack;
            });
            break;
        }

        case VCCameraStateBack:
        {
            dispatch_async(dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_BACKGROUND, 0), ^{
                _session.cameraState = VCCameraStateFront;
            });
            break;
        }

        default:
            break;
    }
}

Reply to this email directly or view it on GitHub:
https://github.com/jgh-/VideoCore/issues/165#issuecomment-118959225

Josh it becomes very responsive but the view flips to horizontal orientation for a second before going back to portrait looks bad
Is there any alternative to fix that thanks
On Mon, Jul 6, 2015 at 12:09 PM, null<EMAIL_ADDRESS>wrote:

Thanks a lot josh :) trying it
On Mon, Jul 6, 2015 at 11:59 AM, Josh Lieberman<EMAIL_ADDRESS>wrote:

Switch the camera asynchronously?  I did something like this:
- (IBAction)changeBroadcasterCamera:(id)sender {

    switch (_session.cameraState) {
        case VCCameraStateFront:
        {
            dispatch_async(dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_BACKGROUND, 0), ^{
                _session.cameraState = VCCameraStateBack;
            });
            break;
        }

        case VCCameraStateBack:
        {
            dispatch_async(dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_BACKGROUND, 0), ^{
                _session.cameraState = VCCameraStateFront;
            });
            break;
        }

        default:
            break;
    }
}

Reply to this email directly or view it on GitHub:
https://github.com/jgh-/VideoCore/issues/165#issuecomment-118959225

I know of that issue, thought there was an open bug for it.  Search around, otherwise feel free to open a new issue.  Are you using the latest version of classes in the repo?


GSD Request

--- GSD JSON ---
{
  "vendor_name": "Linux",
  "product_name": "Kernel",
  "product_version": "versions from v5.11 to before v5.15.7",
  "vulnerability_type": "unspecified",
  "affected_component": "unspecified",
  "attack_vector": "unspecified",
  "impact": "unspecified",
  "credit": "",
  "references": [
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=1da81e5562fac8286567422cc56a7fbd0dc646d4",
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=602824cf9aa9db8830ffe5cfb2cd54365cada4fe"
  ],
  "extended_references": [
    {
      "type": "commit",
      "value": "1da81e5562fac8286567422cc56a7fbd0dc646d4",
      "note": "introduced"
    },
    {
      "type": "commit",
      "value": "602824cf9aa9db8830ffe5cfb2cd54365cada4fe",
      "note": "fixed"
    }
  ],
  "reporter": "joshbressers",
  "reporter_id": 1692786,
  "notes": "",
  "description": "serial: liteuart: fix use-after-free and memleak on unbind\n\nThis is an automated ID intended to aid in discovery of potential security vulnerabilities. The actual impact and attack plausibility have not yet been proven.\nThis ID is fixed in Linux Kernel version v5.15.7 by commit 602824cf9aa9db8830ffe5cfb2cd54365cada4fe, it was introduced in version v5.11 by commit 1da81e5562fac8286567422cc56a7fbd0dc646d4. For more details please see the references link."
}
--- GSD JSON ---

This issue has been assigned GSD-2021-1002581


Synchronization not allowed

Why I am not getting synchronized from Visual Studio 2017? Getting following error. open he REPO from visual studio and Sync..
Here is a print preview at http://prntscr.com/kuwyss
Opening repositories: C:\Users\user\Source\Repos\Windows-universal-samples Remote: Counting objects: 225, done.         Remote: Total 225 (delta 138), reused 138 (delta 138), pack-reused 87         Remote: Permission to Microsoft/Windows-universal-samples.git denied to jecalderon. Error encountered while pushing to the remote repository: Git failed with a fatal error. unable to access 'https://github.com/Microsoft/Windows-universal-samples/': The requested URL returned error: 403 Pushing to https://github.com/Microsoft/Windows-universal-samples

Why are you pushing changes into the repo? If you want to make changes, please use a pull request.

I am confused. I want to update all reent changes into my local repository. I do not want to push changes to the repo. What is the correct procedure?

This is a git question, not a question about the UWP samples repo. You want to Fetch or Pull, not Sync. Sync will push your changes.


[GHSA-pj7m-g53m-7638] Bootstrap Cross-site Scripting vulnerability

Updates

Affected products
Description

Comments
I used the example of https://github.com/twbs/bootstrap/issues/26627#issuecomment-393058335 and modified the bootstrap version to one below the formerly stated patched version 3.4.0 and couldn't verify the issue see https://jsbin.com/jafujoqage/edit?html,output

Hi @jenhae, my colleague @JonathanLEvans and I worked together and found the commit that introduced the vulnerable code in version 4.0.0-alpha6. https://github.com/twbs/bootstrap/commit/c2616fb74e6bdc0cd46a5678a2c5cffcbe422106#diff-1d84c75bd9722a89a7db565ca8061c7b2c7657ed908a9cb2a2feb1124537429b shows where const targets = $.makeArray($(this._selector)), the line that was fixed in https://github.com/twbs/bootstrap/pull/26630/files#diff-1d84c75bd9722a89a7db565ca8061c7b2c7657ed908a9cb2a2feb1124537429b. Even searching for let targets = $.makeArray($(this._selector)) led me to this commit where the line was added in scrollspy.js in the 4.x branch, and I was unable to find let targets = $.makeArray($(this._selector)) in any 3.x versions. Because your findings are consistent with evidence in the source code, we are accepting this contribution.


Clarification about term and subterms

Hi @amallia ,
From what I understood, in order to estimate the importance of a term, you consider the prediction of its first occurrence in the document (contrary to DeepCT which takes the max I think). It was not clear to me however (from the paper and the code) how you obtain the term-level prediction from sub-terms? Do you also consider the first occurrence? i.e. for indexes=['index', '##es'], you compute the score by simply scoring the 'index' embedding?
Thanks in advance,
Thibault

Hi @thibault-formal

From what I understood, in order to estimate the importance of a term, you consider the prediction of its first occurrence in the document (contrary to DeepCT which takes the max I think)
Correct

It was not clear to me however (from the paper and the code) how you obtain the term-level prediction from sub-terms?
Do you also consider the first occurrence?
Yes

I have a newer version of the code/model which performs these steps in a cleaner way. I am going to release the code soon.
Closing now. Feel free to reopen if needed

Perfect, thank you!