Cleaning up reference to TripleO

This PR removes all the remaining references to TripleO.

Thank you @kajinamit for working on this. The rdo team has not removed the tripleo component yet and reusable packages from tripleo component is not yet moved to podified component. that's why I would avoid merging it now.

Thank you @kajinamit for working on this. The rdo team has not removed the tripleo component yet and reusable packages from tripleo component is not yet moved to podified component. that's why I would avoid merging it now.

Thanks for letting me know it. That makes sense.
Let me know if you want to merge some fixes earlier independently. For example we might want to merge fix for roles/repo-setup/tasks/yum-config-compose-no-collections.yml or renaming of some task files in case that affects CI workflow.

Thanks for letting me know it. That makes sense. Let me know if you want to merge some fixes earlier independently. For example we might want to merge fix for roles/repo-setup/tasks/yum-config-compose-no-collections.yml or renaming of some task files in case that affects CI workflow. If needed I can create a separate PR.

Sounds good to create a separate pr, thank you :-)

I'll create a different PR to address the remaining references.


bug: unexpected result when using f in macro when multi_line = false

Did you check docs and existing issues?

[X] I have read all the flash.nvim docs
[X] I have searched the existing issues of flash.nvim
[X] I have searched the existing issues of plugins related to this issue

Neovim version (nvim -v)
v0.9.5
Operating system/version
NixOS unstable @ ae5c332cbb5827f6b1f02572496b141021de335f
Describe the bug
As the title says, macros don't work quite as expected if multi_line is set to false. See repro.lua and the provided steps.
Steps To Reproduce

nvim -u repro.lua repro.lua
76Gzz (goto example section)
qafadwj0q (record macro to delete add, reset position on next line)
QQQQ (observe how it fails from the second repetition)
Set multi_line to true or remove it from the config, observe how it works then.

Expected Behavior
Macros should work the same as stock vim and especially independent from seemingly unrelated config.
Repro
-- DO NOT change the paths and don't remove the colorscheme
local root = vim.fn.fnamemodify("./.repro", ":p")

-- set stdpaths to use .repro
for _, name in ipairs({ "config", "data", "state", "cache" }) do
	vim.env[("XDG_%s_HOME"):format(name:upper())] = root .. "/" .. name
end

-- bootstrap lazy
local lazypath = root .. "/plugins/lazy.nvim"
if not vim.loop.fs_stat(lazypath) then
	vim.fn.system({ "git", "clone", "--filter=blob:none", "https://github.com/folke/lazy.nvim.git", lazypath })
end
vim.opt.runtimepath:prepend(lazypath)

-- install plugins
local plugins = {
	"folke/tokyonight.nvim",
	-- add any other plugins here
	{
		"folke/flash.nvim",
		lazy = true,
		keys = {
			"f",
			"F",
			"t",
			"T",
			";",
			",",
			{
				"S",
				mode = { "n", "x", "o" },
				function()
					require("flash").jump()
				end,
				desc = "Flash jump",
			},
			{
				"<c-s>",
				mode = { "c" },
				function()
					require("flash").toggle()
				end,
				desc = "toggle Flash search",
			},
		},
		opts = {
			modes = {
				search = {
					enabled = false,
					highlight = { backdrop = true },
				},
				char = {
					enabled = true,
					keys = { "f", "F", "t", "T", ",", ";" },
					char_actions = function(motion)
						return {
							[";"] = "right",
							[","] = "left",
							[motion:lower()] = "right",
							[motion:upper()] = "left",
						}
					end,
					multi_line = false,
					highlight = { backdrop = false },
				},
			},
		},
	},
}
require("lazy").setup(plugins, {
	root = root .. "/plugins",
})

vim.cmd.colorscheme("tokyonight")
-- add anything else here (start the repro steps here)
-- add anything else here
-- add anything else here
-- add anything else here
-- add anything else here

I also encountered macro replay issues with char mode on.
-- aaa 1 bbb 2 ccc 3
-- aaa 1 bbb 2 ccc 3
-- aaa 1 bbb 2 ccc 3
-- aaa 1 bbb 2 ccc 3
-- aaa 1 bbb 2 ccc 3

I recorded a macro to modify all number to #.
Press qq for starting, then press 0, then f1r# then f2r# then f3r#, then <esc>.
Use @q for replaying, got totally wrong result belowing.
-- aaa # bbb # ccc #
-- aaa # bbb 2 ccc 3
-- aaa # bbb 2 ccc 3
-- aaa # bbb 2 ccc 3
-- aaa 1 bbb 2 ccc 3

It should be
-- aaa # bbb # ccc #
-- aaa # bbb # ccc #
-- aaa 1 bbb 2 ccc 3
-- aaa 1 bbb 2 ccc 3
-- aaa 1 bbb 2 ccc 3

Disable multiline mode not working.


NO BMI Source in Github

There is no source in github，
samples/bmi
https://github.com/ServiceComb/ServiceComb-Java-Chassis/tree/master/samples/bmi

The BMI sample currently is still in PR. You can get the code with the following commands:

git clone https://github.com/ServiceComb/ServiceComb-Java-Chassis
cd ServiceComb-Java-Chassis
git fetch origin pull/129/head:sample
git checkout sample

@zhuhoudong The url should work now. Thanks for your feedback.


[BUG] Incompatibility with Drag Ruler + Vision 5e

When the moved token is outside from hearing range (default 30ft.) from one another everything is fine.

When the moved token is inside hearing range, drag/elevation ruler will not show and throw some errors

I'm not entirely sure which module is "causing" the problem, but since Drag Ruler plus Vision 5e work fine together and Vision 5e is not in the errors Elevation Ruler is probably the culprit.

Unlikely to be fixed until this Drag Ruler issue is resolved.
But Elevation Ruler 0.7.4 adds options in settings to display the Foundry ruler when dragging tokens and to use different highlight colors based on token speed.
I will keep this open to see if I can address compatibility with Vision 5e.


Appstudio update rhtap-demo-component-qqcs

Pipelines as Code configuration proposal
To start the PipelineRun, add a new comment with content /ok-to-test
For more detailed information about running a PipelineRun, please refer to Pipelines as Code documentation Running the PipelineRun
To customize the proposed PipelineRuns after merge, please refer to Build Pipeline customization

Pipelines as Code CI has failed.There was an error creating the PipelineRun: rhtap-demo-component-qqcs-on-pull-request-
creating pipelinerun rhtap-demo-component-qqcs-on-pull-request- in namespace rhtap-demo-dev-mfcr-tenant has failed.
Tekton Controller has reported this error: the namespace of the provided object does not match the namespace sent on the request


Restructured images for 2D discrete pipelines

There is some issue with the MacOS runner, looking into it.
Requested labels: macOS-11
Job defined at: PolyPhyHub/PolyPhy/.github/workflows/macos_python.yml@refs/pull/114/merge
Waiting for a runner to pick up this job...

Fixed MacOS 11 version, merging it.


Discrimination between "a" and "aa".

Thank you for creating Lark.
I want to use Lark to distinguish between "a" and "aa".
(I'm sorry if it's an already mentioned issue.)
Run the following sample program.
from lark import Lark

text = 'a aa aaa'

parser = Lark('''
    start:  statement*
    statement: a | aa | aaa
    a: "a"
    aa: "aa"
    aaa: "aaa"

    %import common.WS
    %ignore WS
''', start='start')

tree = parser.parse(text)

The result I want is:
start
  statement
    a
  statement
    aa
  statement
    aaa

But every time I actually do it, the result is different.

I would appreciate it if you could tell me the solution.

It's a known issue with the Earley parser, that it isn't always deterministic in choosing a derivation when there's ambiguity.
A straight-forward solution would be do give explicit priority to the longer rules:
    a: "a"
    aa.1: "aa"
    aaa.2: "aaa"

Another way is to force to lexer to expect a whitespace after the string:
    a: /a(?=\s)/
    aa: /aa(?=\s)/
    aaa: /aaa/

(%ignore doesn't force a separation in Earley by design)
Another "fix" would be using lexer="basic", since it removes the ambiguity. You can also do parser="lalr".
Having said all this, I do think ideally your use case should work as-is without any of these fixes. So feel free to leave this open, and maybe we'll get to it some day.

Thank you for the quick response.
By prioritizing as you say, I was able to get the results I expected.
I am grateful for your support.

Having said all this, I do think ideally your use case should work as-is without any of these fixes. So feel free to leave this open, and maybe we'll get to it some day.

Yes. Keep it open until you can resolve the ambiguity without adding anything.


Refactor Errors

Goals

[x] XErrors are constructed where they are used, move to xmlable._errors to clean up code
[x] Add basic tests for some errors
[x] Add more complex examples
[x] General cleanup

LGTM


Swift 3.0 and Xcode 8 GM support

Forked from @pascalfribi's PR https://github.com/matthewpalmer/Locksmith/pull/140.
Added a Test Host target with Keychain Sharing capabilities.
Also, added @aaronpearce's suggestion to change old[String(kSecReturnData)] = true to old[String(kSecReturnData)] = kCFBooleanTrue in asReadableSecureStoragePropertyDictionary.
Tests are passing in my machine, running Xcode 8 GM.

Some Travis test configurations are failing. I will need some help with .travis.yml
Never used Travis before so I'm having issues there. Tests are passing in my machine.

Xcode 8 is out! Time to merge this PR.

Yep, will work on this when I have time on the weekend 👍

On 14 Sep. 2016, at 8:41 am, phatmann<EMAIL_ADDRESS>wrote:
Xcode 8 is out! Time to merge this PR.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@fedetrim could you add -verbos flag to xcodebuild commands in .travis.yml file?
It should look like: xcodebuild -verbose -workspace .... this way we might be able to solve the Travis problem.
Thanks.
P.S.: I'm very thankful for this great library and I know @matthewpalmer  is busy during week, but my projects won't build and that means I have to wait a few days to be able to work on them! I simply cannot wait that long.

Merged—thanks so much @fedetrim!
I'll dig into travis soon 👍

Thanks for merging @matthewpalmer ! I am very thankful for this library!

thanks @fedetrim


Duplicated lines from leapp.linter

In a Fedora 28 machine, using Python 2.7.14, I create the following project:
(env) $ snactor new-project sandbox
New project sandbox has been created in /home/amello/red_hat/vms/leapp-centos/sandbox/sandbox
(env) $ cd sandbox/
(env) [sandbox]$ snactor new-tag Scan
New tag Scan has been created in /home/amello/red_hat/vms/leapp-centos/sandbox/sandbox/tags/scan.py
(env) [sandbox]$ snactor new-actor A
New actor A has been created at /home/amello/red_hat/vms/leapp-centos/sandbox/sandbox/actors/a/actor.py

This is the code of actor A, with field tags not being a tuple:
from leapp.actors import Actor
from leapp.tags import ScanTag

class A(Actor):
    name = 'a'
    description = 'Sample actor A.'
    consumes = ()
    produces = ()
    tags = (ScanTag)

    def process(self):
        self.log.info("Starting actor A")

When I try to run actor A, leapp.linter warns me multiple times about the same problem.
(env) [sandbox]$ snactor run A
2018-05-07 23:11:33.260 INFO     PID: 22995 leapp: Logging has been initialized
2018-05-07 23:11:33.270 INFO     PID: 22995 leapp.repository.sandbox: New repository 'sandbox' initialized at /home/amello/red_hat/vms/leapp-centos/sandbox/sandbox
2018-05-07 23:11:33.302 WARNING  PID: 22997 leapp.linter: Actor <class 'actor.A'> field tags should be a tuple of Tags
2018-05-07 23:11:33.314 WARNING  PID: 22997 leapp.linter: Actor <class 'actor.A'> field tags should be a tuple of Tags
2018-05-07 23:11:33.349 WARNING  PID: 23010 leapp.linter: Actor <class 'actor.A'> field tags should be a tuple of Tags
2018-05-07 23:11:33.360 INFO     PID: 23010 leapp.actors.a: Starting actor A

Attempted fix: https://github.com/leapp-to/leapp/commit/abfe3fb439e6238f588df4eb516fbe60f4c29684

There are still duplicit lines from linter (not three same lines but only two, so there's a progress here):
$ snactor repo new NewRepo
New repository NewRepo has been created in /home/user/NewRepo
$ snactor new-tag NewTag
New tag NewTag has been created in /home/user/NewRepo/tags/newtag.py
$ snactor new-model NewModel
New model NewModel has been created in /home/user/NewRepo/models/newmodel.py

NewModel.topic = NewTopic
NewActor.consumes = (NewModel)
NewActor.tags = (NewTag)

$ snactor run NewActor
2018-11-13 21:58:19.668 INFO     PID: 3212 leapp: Logging has been initialized
2018-11-13 21:58:19.681 INFO     PID: 3212 leapp.repository.NewRepo: A new repository 'NewRepo' is initialized at /home/user/NewRepo
2018-11-13 21:58:19.700 WARNING  PID: 3217 leapp.linter: Actor <class 'actor.NewActor'> field tags should be a tuple of Tags
2018-11-13 21:58:19.710 WARNING  PID: 3217 leapp.linter: Actor <class 'actor.NewActor'> field consumes should be a tuple of Models
2018-11-13 21:58:19.737 WARNING  PID: 3233 leapp.linter: Actor <class 'actor.NewActor'> field tags should be a tuple of Tags
2018-11-13 21:58:19.748 WARNING  PID: 3233 leapp.linter: Actor <class 'actor.NewActor'> field consumes should be a tuple of Models

$ rpm -q snactor python2-leapp python2
snactor-0.3-1.devel.20181112.git.238.noarch
python2-leapp-0.3-1.devel.20181112.git.238.noarch
python2-2.7.13-17.fc27.x86_64


Recover previous version?

Before the map stopped working, I had mapped a large area using v0.1.5 but when 0.1.7 was released my copy of 0.1.5 was deleted before I could copy it over and as such all my pokestop location data is gone. Is there any way to recover those map files?

%appdata%\pokemon-go-map
Pokestops are stored in a database there (as well as the pokemon, gyms etc). Maybe your data is still in there?

Mine auto updated to 0.1.7.  Kindy crappy because this am when I tried to look at the local gyms to go gank I just got the Opps error.

Sadly it looks like the database file was erased with the new version. Opening the file that was appdata\roaming, there was only 2 stops in the file.


Update the source information

Type: Missing
Summary:
Update the source information
Details:
With the rise in supply chain attacks and OSS dependencies being used as a attack vector, Microsoft is working with our ecosystem partners, such as the Linux Foundation's OpenSSF, to enable OSS consumers to track packages back to their public sources.
Resolution:
This PR was created to add this value, ensuring future releases will include this provenance information.
Published NPM packages with repository information:
* uid2
Affected definitions:

uid2 0.0.3

Found another package that pointed to this user account on GitHub. Agreed.


🏃♂ Name v1alpha2 imports

What this PR does / why we need it:
Trying to keep consistency in how the imports are named across the repository.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

/lgtm
/ok-to-test


Add support for show and hide cursor?

Would a pull request to add the ability to hide/show the cursor be welcome, something like this?
impl Term {
	...
	fn cursor_hide(&mut self) -> io::Result<()> {
        let esc = "\u{001B}";
        let hide = format!("{}[?25l", esc);
        self.write(hide.as_bytes())?;
        Ok(())
    }

    fn cursor_show(&mut self) -> io::Result<()> {
        let esc = "\u{001B}";
        let show = format!("{}[0H{}[0J{}[?25h", esc, esc, esc);
        self.write(show.as_bytes())?;
        Ok(())
    }
}

Sorry to conform to how your internal design is it would make more sense for hide and show to be implemented in common_term.rs:
pub fn show_cursor(out: &Term) -> io::Result<()> {
	let esc = "\u{001B}";
    out.write_str(&format!("{}[0H{}[0J{}[?25h", esc, esc, esc))
}
and so on...

then just call the func in the Term method
this does work on both windows and linux. Hope this is helpful, thanks for a great lib!

This is implemented now.


Swig support for MsgBucket and IO tests

Relevant to #375

TODO: Add in swig tests for SubAgentDescription etc?

I will merge this as soon as CI passes (as I think that was agreed in Weds meeting).


HBASE-24739 [Build] branch-1's build seems broken because of pylint

Try to use the latest pylint version that supports python2.7.

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2065/1/console in case of problems.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m  0s
Docker mode activated.

-1 :x:
docker
5m 25s
Docker failed to build yetus/hbase:7cf97016b9.

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hbase/pull/2065

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2065/1/console

versions
git=2.17.1

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2065/2/console in case of problems.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m  0s
Docker mode activated.

-1 :x:
docker
0m 11s
Docker failed to build yetus/hbase:7cf97016b9.

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hbase/pull/2065

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2065/2/console

versions
git=2.17.1

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

seems not right, hmm...

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2065/3/console in case of problems.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
12m 29s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
hadolint
0m  0s
hadolint was not available.

+0 :ok:
shelldocs
0m  0s
Shelldocs was not available.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-1 Compile Tests _

+0 :ok:
mvndep
2m 23s
Maven dependency ordering for branch

_ Patch Compile Tests _

+0 :ok:
mvndep
0m  8s
Maven dependency ordering for patch

+1 :green_heart:
shellcheck
0m  1s
There were no new shellcheck issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

_ Other Tests _

+0 :ok:
asflicense
0m  0s
ASF License check generated no output?

15m 53s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2065/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2065

Optional Tests
dupname asflicense hadolint shellcheck shelldocs

uname
Linux 9f1fd0cb07e2 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-2065/out/precommit/personality/provided.sh

git revision
branch-1 / 0841f12

Max. process+thread count
36 (vs. ulimit of 10000)

modules
C:  U:

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2065/3/console

versions
git=1.9.1 maven=3.0.5

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

ping @busbey
I'm not sure if I did it right, would you mind taking a look?

seems reasonable. delete the whole "install pylint via pip" section? maybe put up a test commit on this PR that touches a python file so we can ensure pylint works?

Let's get it in? It's holding up other changes for branch-1

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2065/4/console in case of problems.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
6m 52s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
hadolint
0m  0s
hadolint was not available.

+0 :ok:
shelldocs
0m  0s
Shelldocs was not available.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-1 Compile Tests _

+0 :ok:
mvndep
2m 26s
Maven dependency ordering for branch

_ Patch Compile Tests _

+0 :ok:
mvndep
0m  9s
Maven dependency ordering for patch

+1 :green_heart:
shellcheck
0m  0s
There were no new shellcheck issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

_ Other Tests _

+0 :ok:
asflicense
0m  0s
ASF License check generated no output?

10m 35s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2065/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2065

Optional Tests
dupname asflicense hadolint shellcheck shelldocs

uname
Linux 7f9abd6e7c0c 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-2065/out/precommit/personality/provided.sh

git revision
branch-1 / f5080eb

Max. process+thread count
41 (vs. ulimit of 10000)

modules
C:  U:

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2065/4/console

versions
git=1.9.1 maven=3.0.5

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.


We need the interiors for security

I am looking for the agency offices but see we need the int files loaded, any way to do it manual

Should be fixed with the latest commit.


Cordova App: Viewport Sqaure, Result in Circle Not Working

I am trying to get circle canvas in cordova app. It is perfectly working on desktop but when I try on mobile cordova app, it is returning me square canvas only. Following is my code when saving canvas. Same code on desktop returning circle image from square viewport. But same not working on cordova app.
$('#save_btn').on('click',function(ev){
	$('#collapseExample').collapse('hide');
	$('#my_image').croppie('result', {
 	type: 'canvas',
     	size: { width: 200, height: 200 },
   	format: 'png',
	circle:true,
            }).then(function (canvas) {
	$('#img_block').append('<img src='+canvas+'>');
	});
});

Its happening in old android devices only.

@dhwalin @thedustinsmith
Hi! I'm having the same problem on the cordova.
Have you been able to identify the problem?
Tks


mvn azure-functions:run is throwing an error

mvn azure-functions:run is throwing an error

https://docs.microsoft.com/en-us/azure/azure-functions/functions-create-first-java-maven

mvn azure-functions:run is throwing an error

Thanks for the feedback! We are currently investigating and will update you shortly.

@Rakshitakv what is the output of the mvn clean package ?
Does it succeed?


Make NativePtrs comparison operators live outside the class, so that they can be constexpr.

Lets try this rodeo one more time :-)
Now NativePtr's comparison operators aren't member functions, freeing up template specializations from forcing the default implementation to be non-constexpr.
Until Visual Studio's implementation of std::set supports UniquePtr (which, btw, the most recent update may have fixed that, and now that VS2015 isn't supported anymore, I'll investigate that again), this should be the final word on the whole dynlib situation.

Looks like the best option, thanks. Merged.


ROUTING_OPT_ITERS no longer works

Describe the bug
set ::env(ROUTING_OPT_ITERS) 100
should set the number of routing iterations to 100. Instead it is stuck at 64.
To Reproduce
On a congested design that takes longer than 64 iterations to route, increase iterations to a larger number:
set ::env(ROUTING_OPT_ITERS) 100
Expected behavior
router should keep going past 64th iteration
Screenshots

Desktop (please complete the following information):

OS: Ubuntu 20.04
Openlane Version 0.12
open_pdks Version:f788cea
skywater-pdk Version: db2e067

In case it's useful here's a screenshot after I set global iterations to 80

but still exited after 64

@mattvenn Can you share your design and config.tcl ? We think tritonroute either ignores the parameter or doesn't honour it if the violations are unsolvable.
On another note, if you are still facing violations after the 64th iteration, you can try to slightly increase the GLB_RT_ADJUSTMENT.

how would you prefer me to share the design? It is user_project_wrapper, so
it's part of caravel_user_project.
On Wed, 28 Apr 2021 at 20:30, Manar @.***> wrote:

@mattvenn https://github.com/mattvenn Can you share your design and
config.tcl ? We think tritonroute either ignores the parameter or doesn't
honour it if the violations are unsolvable.
On another note, if you are still facing violations after the 64th
iteration, you can try to slightly increase the GLB_RT_ADJUSTMENT.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/efabless/openlane/issues/303#issuecomment-828682671,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAE223ADJX3PEGVEFOV3WZLTLBH3DANCNFSM43W652VA
.

--
Matthew Venn
web mattvenn.net twitter @matthewvenn https://twitter.com/matthewvenn

I have the same issue. I tested with lower size and with lower size of 64 works ( for example I tested with 20 and only does 20)

TritonRoute only does 64 iterations.  The control can limit it to less but can't force it higher.

OR team has clarified that this is intentional. We should maybe add a warning.


Incorrectly parses non-XML-compliant template

This template causes typescript error:
<template>
<img src="logo.png">
</template>

Note the image closing tag is missing, but it's still valid vue template. Things like linters inspire that syntax

ERROR in ./src/components/App.vue?vue&type=script&lang=ts& (../node_modules/babel-loader/lib??ref--0-0!./node_modules/vue-loader/lib??vue-loader-options!./src/components/App.vue?vue&type=script&lang=ts&)
Module build failed (from ../node_modules/babel-loader/lib/index.js):
SyntaxError: /home/andrew/WebstormProjects/vue-webpack-typescript/src/components/App.vue: Unexpected token (32:10)
30 | })
31 | export default class App extends Vue {

32 |   private i: number = 0;
|           ^
33 |   private readonly a: number[] = [];
34 |
35 |   private readonly id: string = 'App';

Ok, I think the issue is related to vue-property-decorator

Hi! Thank you for reporting this. Unfortunately, the official docs don't say which syntax must be used for the <template> section. In fact the XML parsing works fine - what you have mentioned as an example is not a valid XML - I guess it's SGML (which is a quite relaxed superset) and that kind of parser has to be used. At first glance I can't see any reasonable high-level parser written in JS (and I don't want to write one + don't want to rely on string replace method as well :D). I'll investigate if there is any suitable solution.
I've stopped using vue recently so I may not be up to date - maybe this package is no longer required and the official vue-loader already covers this case?

@pawelgabryelewicz well, I stuck to that issue for the second time, and it's really hard to track those errors, cause from the first look it seems like the cause should be in babel-loader.

Maybe it's easier to check how vue-loader parses that thing?
Or as a quick workaround, we might catch the exception so at least rethrow a meaningful error, cause other folks may just spend an enormous amount of time as I did for a simple tweak.
If all of that is too much effort to spend, I would recommend at least to add a bold text in the README of this plugin that it requires a VALID XML template layout

I have recently released version 1.1.1 which relies on internal vue-template-compiler - please check if the issue persists. Starting from now all the files that Vue is able to compile, should work here as well. It's not exactly the source that you mentioned, but that was a good point start with. Thanks for your contribution and your time. Sorry for the delay, this is a very side project.


When using tooltip with tailwind html size dont update to fit leaving white space after rotate on phone

Duplicates

[X] I have searched the existing issues

Latest version

[x] I have tested the latest version

Steps to reproduce 🕹
Steps:

using CRA
install tailwindcss postcss autoprefixer
install @mui/material @emotion/styled @emotion/react
add tooltip to anywhere

Current behavior 😯
html size is not update leaving white space at bottom and left side
Expected behavior 🤔
html should resize back and fit screen
Context 🔦
screenshot from google chrome on pc same result when testing on google chrome on phone

Your environment 🌎

npx @mui/envinfo
  Google Chrome

  System:
    OS: Windows 10 10.0.22000
  Binaries:
    Node: 16.17.0 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.22.19 - ~\AppData\Roaming\npm\yarn.CMD
    npm: 8.15.0 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Chrome: Not Found
    Edge: Spartan (44.22000.120.0), Chromium (105.0.1343.53)
  npmPackages:
    @emotion/react: ^11.10.4 => 11.10.4
    @emotion/styled: ^11.10.4 => 11.10.4
    @mui/base:  5.0.0-alpha.99
    @mui/core-downloads-tracker:  5.10.7
    @mui/material: ^5.10.7 => 5.10.7
    @mui/private-theming:  5.10.6
    @mui/styled-engine:  5.10.7
    @mui/system:  5.10.7
    @mui/types:  7.2.0
    @mui/utils:  5.10.6
    @types/react: ^18.0.0 => 18.0.21
    react: ^18.2.0 => 18.2.0
    react-dom: ^18.2.0 => 18.2.0
    typescript: ^4.4.2 => 4.8.4

Did you use the official example we provide for integrating with Tailwind CSS -https://github.com/mui/material-ui/blob/master/examples/tailwind-css/README.md?

Yes and i test it and found out that this happened when tooptip wrap under flex or text-center

oh i forgot to mention tooltip props open = true


Add utilites for digraphs and netlist analyses

This is a set of utilities for directed graph-based analyses of circuits, and a set of analyses for examining the netlist of the circuit. They are all based around an API for MutableDiGraph and immutable DiGraph classes. It is considerably simpler than the variant I had previously attempted using scala-graph.
The netlist analyses are simple (examining instance hierarchy), but I thought the analyses/Netlist.scala file would be a good place to keep related analyses.
I am using these graph utilities and analyses for combinational loop detection and for developing the memory double pumping pass. I believe @shunshou is also using them to generate constraints files.

Haven't generated constraint files yet, but using your utilities to great effect :)

Out of curiosity, What is the "memory double pumping pass"?

Turning a synchronous read memory with 2N read ports and 2M write ports into a double-pumped memory with N read ports and M write ports (with some concessions on read-under-write behavior).

Still working on adding Scaladoc to all the public methods. I added an exception for running linearization on a cyclic graph.


Sails 1.x migration

About time for sails 1 migration

the sails migration guide is detailed enough: https://sailsjs.com/documentation/upgrading/to-v-1-0
addressed in this issue: cf23076


Add Tracer capability

Tracing support for SWAM
Log format

<trace> -> <log> \n <trace> | <EOF>

<log> -> <event_type>,<time>,<args>

<time> -> \d+
<event_type> -> "msize" | "mread" | "mwrite" | "mgrow" | "spush" | "spop"

<args> -> <arg>,<args> | <arg>

<arg> -> \w+

Example
mread,1567590525454,i32,100,10,
This log means, memory read at time<PHONE_NUMBER>454, read as 4 bytes integer(i32), in address 100, result  value 10
Filtering logs
You can set a filter for event logs based on the first element in the line. The filter can be specified as a regular expression in the reference.conf file. For example, to log only memory operations: filter = "mread|mwrite".
Tracers
Swam provides a JULTracer implementation that uses java.util.logging for tracing. You can pass whatever implementation of your choice to the Engine factory to override this.
The engine runs without tracer by default.
Output example
mread,446479078,i32,0,0
mread,451988189,i32,0,2
mwrite,452499619,i32,0,2
mread,452918915,i32,0,2
mwrite,454010692,i32,65536,3
mwrite,447102186,i32,0,2
mread,449056814,i32,0,2
mread,453380464,i32,65536,0
mread,454471107,i32,65536,3

Supersedes #48

Poke @Jacarte

very nice Christmas' gift!

Indeed, thanks @satabin

Merged, don't hesitate to improve/fix things if it's not working as expected.


Adapt automation to run propertly cnao providers.

What this PR does / why we need it:
The multus lane at kubevirt is testing a very old version of cluster-network-addons-operator AKA CNAO, this PR bump kubevirtci and adapt automation to run cnao provider correctly and towards multus and networking tests.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
The pull-kubevirt-e2e-k8s-cnao-1.17 job is still optional and run_always: false, it need to be exercised with pull-kubevirt-e2e-k8s-cnao-1.17, when this PR is merged we will do the replacement of lanes s/multus/cnao/.
Release note:

NONE

/hold
we have to decide how to orchestrate this since it depends on project-infra lane merge.

/hold cancel
cnao is working fine now

/retest

/test pull-kubevirt-e2e-k8s-cnao-1.17

/cc @phoracek @rmohr

/test pull-kubevirt-e2e-k8s-cnao-1.17

/lgtm

/test pull-kubevirt-e2e-k8s-cnao-1.17

/lgtm

/lgtm

/retest

/test  pull-kubevirt-e2e-k8s-1.17-cnao

/test pull-kubevirt-e2e-k8s-cnao-1.17

/lgtm
/approve

/test pull-kubevirt-e2e-k8s-genie-1.11.1

/test pull-kubevirt-e2e-k8s-cnao-1.17

/test pull-kubevirt-e2e-k8s-1.16

/override continuous-integration/travis-ci/pr

/test pull-kubevirt-e2e-k8s-1.15-ceph

/override continuous-integration/travis-ci/pr


Slight issues on tutorial 4.

In tutorial number 4 the gate is defined through the Hamiltonian:
H_{\text{OAT}}(\chi, \Delta, \omega) = \sum_{i=1}^3 \chi_i L_{z, i}^2 + \Delta_i L_{z, i} + \Omega_i L_{x, i}
However, in the gate chi Delta and Omega are also used as the angles, which should be the product no ? So I wonder about the proper definitions here ...

I also attempted to implement the ly gate, however the collective_spin_simulator throws the error that rLy is not implemented. Is this a bug or a feature ?

To your first point, the "angles" in the gate refer specifically to that Hamiltonian, so the gate generated by this Hamiltonian picks up the same definitions. I'm not sure what you mean by taking the product of these parameters?

To your second point, the collective_spin_simulator is a specific example of a spin backend which already has a fixed gateset defined in its configuration, mocking the restrictions of a real hardware backend. These can be looked up through the supported_instructions of the backend configuration and currently include

"supported_instructions": [
    "rLz",
    "rLx",
    "rLz2",
    "OAT",
    "rLzz",
    "measure",
    "barrier",
],

You would need to add your rLy gate there or simply use the general SpinSimulator backend which does not have any restrictions on the gates it can process.
Hope this clears things up.

Concerning the first point:
Well the gate is U = e^{itH} right. So the parameters of the Hamiltonian are fixed, but the angle in front of the operators changes as time moves. Take for example the simple case of the U = e^{it \Delta Lz}. Delta is fixed in the experiment, but the time changed, so the thing that should be given to the unitary is t\times \Delta...

Good to know for the second point.

Back to your first point:
Is see what you mean, but I'm not sure there's a good solution for this.
In the circuit we don't care about experimental parameters and gate times but only the resulting angles which is given by the abstract parameters (in the case of single spin rotations). And, frankly, we need some names for the parameters in the gate.  We chose chi, Delta, Omega to hint at the standard notation of the Hamiltonian, not because these correspond to the actual experimental values.
So if that is confusing from the experimental point of view, what other name for the parameters would be natural?
(You can also think of it as setting t = \hbar = 1 (dimensionless) for the purpose of the gate definition. )

So if that is confusing from the experimental point of view, what other name for the parameters would be natural?

Something like another greek letter would be great. But in the FH model, the variable J and U are really associated with fixed parameters. It would hurt my AMO/condensed-matter etc eye much less to see: \theta_J = Jt than J = Jt...


Memory optimizations

Current way of parsing the received file is inefficient. This Pr provides means to optimize memory usage and improve time costs per job.
Means used to improve efficiency
These are the changes I've made along with the reasoning behind.
Remove tempfile logic e6a3822
Red series in the chart
This is more of a code cleanup. The presumption is that once we receive the file it doesn't make any sense to store it as a temp file, because in containerized environment the /tmp partition is a tmpfs type - the data are stored in memory nevertheless. Therefore, we won't save much memory if we would dump the data in a file and then do our parsing over this tempfile.
Using a temfile would save us the HTTP response data overhead - a bit less memory due to tmpfs optimization on OS level. But it takes more time to process the data - it takes time to store the file and load it again.
Use chunked stream 864e93c
Yellow series
Unfortunately, if we want to parse the *.csv we need to load it fully into memory. But when we do so, we don't need to parse it as a whole. Instead we can parse each line as a separate entry. This way we don't need to keep the whole output file in memory and we can instead stream each entry separately in a chunked manner. Our memory usage then lowers to "just":

whole *.tar.gz in memory
whole *.csv in memory
one entry parsed at a time

This approach greatly lowers memory usage, since it takes much space to store whole file while parsed. Pandas and Numpy are root cause of this issue. We've used them for the parsing instead of the standard csv package, because that one doesn't handle well data conversions... This issue is completely avoided with the last optimization:
Avoid parsing to JSON and stream chunked binary data f0705eb
Green series
The parsing would be done once more on the AI service side nevertheless. Hence it doesn't make much sense to do it twice just so we can have neater, readable output of the data-collector. Since the parsing would consume time and resources in the AI service, the data collector can skip that part and just unpack the file and dump the binary data as a stream. We can chunk the reads of the *.csv - limit to a buffer size. The size limit can be used to balance memory spikes to time it takes to finish the job.
Memory and time savings are huge since the parsing is really costly operation and we're about to avoid that.
Benchmark
To see how each optimization performs, we should do some benchmark. For that I've chose to use the Titanic dataset once more, just layered the data... So I've extended the data set by the same data so I've end up with a file:

Metric
Value

Total size of titanic_extra_big.tar.gz when compressed
66MiB

Inner titanic.csv when unpacked
211MiB

Inner titanic.csv entries total
4436774 lines + 1 header

So as you can see it's really sparse and not much unique. That helps with compression so it shortens the time it takes to pass the file over the network. Also the impact of storing the file locally is lowered as well.
Now, let's see how each of the optimizations performs:

Optimization
Memory peak for the same job

Master for comparison
4433.92MiB

No temp file
5092.35MiB

Chunked parsed stream
1115.14MiB

Raw binary stream
134MiB

It's worth mentioning the data were collected using docker stats which have a refresh rate of approx. a second. So the peak you see in the No temp file series may have (and probably did) occurred in the Master as well, it just wasn't caught.

Optimization
Time to complete a job

Master for comparison
137s

No temp file
135s

Chunked parsed stream
23s

Raw binary stream
18s

Conclusion
As shown, chunked stream performs far better than parsing whole file at once. That is a valid observation no matter if we choose to parse the data or just dump it raw.
All these approaches results in the same, consumable output. Due to change in data format, only the last Raw binary stream optimization would require a small change in the AI service.
The residual memory increase after a job is completed, is something worth looking at. It seems the garbage collector in Python doesn't work well when the Thread objects are nod joined back... This should be addressed in future.

You are right, I should try the test with larger datasets.
I tried the Single Request test about 5 times and 2 out of those 5 times (like I mentioned above) the consumption in master was less than streamed - master was at about 25MiB and streamed was at 30MiB.
Then I had to restart the docker daemon on my machine, and when I resumed my testing, I saw the exact opposite - streamed consumption was less than master. So I repeated the test 3 more times, and this time streamed consumed less in every test.
But if you disregard that first spike for both master and streamed (just to be fair), I think the streamed approach did perform better in terms of time
I do like the streamed implementation a lot, so if it works well with https://github.com/ManageIQ/aiops-insights-clustering/pull/29 (which I will test next), I think this should be good to go!

@AparnaKarve Sounds cool! :wink:
I don't know... the behavior for a single request on your machine is kinda weird. :smile: Let's see what results you're gonna get, when you run some more expensive test. But I'm pretty sure that it's gonna behave similar to my observations..
The insights-clustering PR brings no change to their workflow, it just adopts to these changes, so I don't expect any delays on that side. If we decide we want to go this way and merge this, the only change we have to keep in mind is that the API spec is changed for the AI service... Other than that, we should be fine. :slightly_smiling_face:

@tumido I am currently testing with -
'{"url": "https://github.com/AparnaKarve/datasets/blob/master/big.tar.gz?raw=true"}'
It's a fairly large dataset - size: 15.5 MB and 65,500 rows
the results are better for master I think -- but need a second pair of eyes and another machine to confirm.
Meanwhile,  I also tested ManageIQ/aiops-insights-clustering#29, and that looks good!

Hm, the results are significantly for me, however the data set you're using is flawed. It contains 2 CSV files, and since the latest "raw streamed" commit is set to parse only the first CSV file found, it makes the results incomparable...
Try my dataset, which is still by magnitude larger than the one you've used:
https://drive.google.com/file/d/1aAqMyRBA7_0f6jkUJPsnY_t0q2sk0p1C/view?usp=sharing
Also, more and more multiple tests I run, I feel like I need to address the issue with cleanup after the workers.. :/ That has to be fixed, it seems the memory is not cleaned, when the worker exits... Never. Which is bad.

@AparnaKarve what do you think about this PR, can we merge it (after the demo though...)? So I can base my multi-worker on it? :) Any objections? :cake:

@tumido Looks like you made some updates today, which means I would have to rerun my cAdvisor tests to be sure that the memory readings are OK.
Lets shoot for EOD Monday to get this merged. That sound OK?

@tumido I tested this again today a couple times using your dataset
cAdvisor readings -

Scenario
Master
Streamed

Idle state
73.10
71.87

Single Run
76.04
74.29

Multiple Runs(4)
79.18
80.18

Multiple Runs(6)
82.49
80.07

Multiple Runs(12)
87.21
80.14

Multiple Runs(20)
89.13
80.02

Memory never gets restored back to it's original consumption number for both cases, which I believe even you noted.
From what I can see, the streamed seems to be performing better with more number of runs -- it's staying consistent at ~80MiB
If we average it out over several runs, clearly streamed would do better than master.
Good to go from my side!! :)

@AparnaKarve  I don't get how you can have such low RAM readings on master... I get nowhere near that. :/ Like at all. Are you sure you're building the image the proper way?
$ git checkout master
$ s2i build -c . centos/python-36-centos7 aiops-data-collector:master

I mean.. it's really interesting that you're deployment gets so low in consumption. I can't reproduce it either locally or in OpenShift.

@tumido I checked out both master and streamed_data branches and did this for each branch respectively -
docker build -t <my_docker_id>/aiops-data-collector_master -f Dockerfile .
docker build -t <my_docker_id>/aiops-data-collector_streamed -f Dockerfile .

I was surprised at the low numbers too, but it is what it is.
When I was testing a couple days ago, the numbers were not this low, I remember.
Also I left the docker instances ON overnight, and the memory consumption did come down today quite a bit -
Master - 76.40
Streamed - 74.61

Hm.. weird.. we don't have a Dockerfile in the repo. What are using to build it against then? Please use the s2i so the workflow is the same as for OpenShift.

I mean.. if your dockerfile features a better setup for the master.. Let's use it! :wink: :wine_glass:

We did have a Dockerfile at some point, right?
It was removed in https://github.com/ManageIQ/aiops-data-collector/pull/11 - but that is what I am using.
I will be retesting with s2i today

@AparnaKarve Hm.. that Dockerfile is dated. It also requires requirements.txt which we no longer keep in the repo, so you've probably had the images using wrong and incomplete dependencies... Did you check on the outputs during your tests? Well.. anyways, let's test it against s2i builds which are up-to-date. I think that would give you the same results as it did for me.
Also note, that you have to have the parser set to CSV in order to kick in. Otherwise the pandas won't run at all... That's maybe the issue. The Dockerfile with dated requirements (missing pandas and stuff) and no parsing happening (otherwise you'd get traceback because of missing pandas)... no wonder the results are nearly the same for you.
One mystery solved. :slightly_smiling_face: Let's try with s2i  and we'll see. :slightly_smiling_face:

@tumido So as we discussed requirements.txt was not the issue... but there were other factors in play... not going to list those, since it does not add to the conversation here...
So lets scratch out all the earlier readings, and restart with s2i
With s2i, I'm happy to say that the First Run reading closely matches with yours.

Scenario
Master
Streamed

Idle state
150.36
73.70

First Run
Reached up to 656.707 and crashed (crash log below * Worker was restored back showing 219.20)
137.469 (memory was restored back to 76.79)

Second Run
Started from ~219 and reached up to ~811 and crashed  again, Worker was restored back showing ~282
Started with ~76, reached up to 141.02 (memory was restored back to 79.40)

Third Run
Started from ~282 and reached up to ~812 and crashed  again, Worker was restored back showing ~335
Started with ~79, reached up to 144.039 (memory was restored back to 82.24)

crash log in `master`
[2019-02-22 21:24:14,500] DEBUG in connectionpool: https://raw.githubusercontent.com:443 "GET /AparnaKarve/datasets/master/big_titanic.tar.gz HTTP/1.1"<PHONE_NUMBER>3
[2019-02-22 21:24:43 +0000] [1] [CRITICAL] WORKER TIMEOUT (pid:32)
[2019-02-22 21:24:43 +0000] [32] [INFO] Worker exiting (pid: 32)
[2019-02-22 21:24:43 +0000] [47] [INFO] Booting worker with pid: 47

On my machine, master version is simply unable to handle huge datasets (note the crashes indicated above in the table)
OTOH, streamed is not only finishing the task, but also exiting gracefully
====> This is a BIG win, and for this reason alone we should merge the PR!
Way to go! :)

Issues currently noted with streamed version

Notice how the memory usage keeps going up and up after every run, so something to look into in follow-up PRs
If you change the NEXT_MICROSERVICE_HOST in the .env file to say localhost:80800,  there is a urllib3.exceptions.NewConnectionError exception, but what's interesting is, the memory consumption after the exception is 142.41 and it never comes down to the 70s/80s range

The issues mentioned above could be resolved in follow-up PRs

LMK what you think about the new readings with s2i


Form state should not have effect on the visibility of inner message

Version
0.67.1
By now, messages within a form will only be shown if their state equals with that of the form. I think this layer of logic is useless because in React, we can easily sync the state and visibility of all of them.
With such a constrain, some fine grained controls become odd. For example, If I wanna show some error message and some warning message, as the form can have only one state, I have to set these messages' visible to true to enforce it.
Also, for components like Message, visible prop seems like an anti-pattern. Component should take care of the styles of itself, but problems like should it be rendered and where to place it should be handled by the user or consumer component.

Messages within a Form are shown/hidden via CSS.  Please post CSS issues on the main repo https://github.com/Semantic-Org/Semantic-UI.  This project only concerns itself with React components.


Is the project alive?

Hi @romerojunior !
I've just deployed Cloudian cluster in my org, I wonder if  you are still working on this project, willing to accept PRs etc?
Cheers!

PRs are always welcome! I'm not actively developing this project since it's been stable for my personal needs, but please feel free to test, use or provide new features. 🚀

OK, great, I'm at early stage of it, but keen to take this project as a foundation for any further developments.
Thanks!


Feat/update helm chart

JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/CCD-2269
Change description
Add am-role-assignment-service to preview-aat yml and update hmctspublic version in chart yml
Does this PR introduce a breaking change? (check one with "x")
[x] Yes
[ ] No

feat: update Chart for hmctspublic version

feat: update app information for am-role-assignment-service


Stop running tasks in default Makefile.toml

Describe the bug
I have Makefile.toml in my workspace. This is having following configuration. And I wanted to skip default Makefile.toml. But this is not skipping as expected.
[config]
skip_core_tasks = true

To Reproduce

Add Makefile.toml file in your workspace directory
Add following config in your Makefile.toml

[config]
skip_core_tasks = true

Run command cargo make or cargo make --makefile ./Makefile.toml

Expected: should run tasks only in my Makefile.toml, not include default's ./Makefile.toml
Actual: It is picking Makefile.toml and finishes. But it continues to execute tasks in default ./Makefile.toml file as well.

can you show me your makefile and the output of the run?

Makefile:

Output:
cargo-make-run-defaults-issues-289.log

ok, so this is a workspace (missed that part), so basically  you want each member to either define that as well or automatically extend the workspace makefile by adding
[env]
CARGO_MAKE_EXTEND_WORKSPACE_MAKEFILE = "true"

Thanks @sagiegurari resolves the issue


Timing issue between SLO config + calculated service metric

Describe the bug
We currently have a timing issue between calculated service metrics and SLOs. When an SLO depends on a calc service metric, monaco correctly creates the calc service metric first. However, as soon as the SLO config is applied, the API validation kicks in with the following error:
[2021-06-22T07:48:01.047Z]     Response was: {"error":{"code":400,"message":"Validation failed for 1 Validators.","constraintViolations":[{"path":"builtin:monitoring.slo/0/metricNumerator","message":"Given property 'metricNumerator' with value: 'calc:service.<snip>' violates the following constraint: Metric selector for numerator is invalid..","parameterLocation":"PAYLOAD_BODY","location":null}]}}, responsible config:<snip>.json

It complains that it can't find the calculated service metric. This error just happens when the environment creates both configs for the first time.
How to reproduce
Add a SLO config depending on a calculated service metric:
{
  "enabled": true,
  "name": "{{ .name }}",
  "description": "Measures the ratio of service cally below {{ .milliseconds }} milliseconds. (# of service calls < {{ .milliseconds }} milliseconds / # of total service calls)",
  "status": "WARNING",
  "error": "NONE",
  "useRateMetric": false,
  "metricRate": "",
  "metricNumerator": "{{ .calculatedServiceMetricId }}",
  "metricDenominator": "builtin:service.requestCount.server",
  "target": {{ .target }},
  "warning": {{ .warning }},
  "evaluationType": "AGGREGATE",
  "timeframe": "-1h",
  "filter": "type(\"SERVICE\"), entityId(\"{{ .meId }}\")"
}

config:
  - responseTimeLessThan250ms: "response-time-less-than-X-ms.json"

responseTimeLessThan250ms:
  - name: "Response Time less than 250ms"
  - calculatedServiceMetricId: "/service/calculated-metrics-service/responseTimeLessThan250ms.id"
  - milliseconds: "250"
  - target: "95"
  - warning: "96"
  - meId: "<snip>"

Expected behavior
monaco should wait with applying the SLO until the calc service metris is fully present at the environment. Probably, some kind of retry mechanism is needed here.

The same behaviour exists with Applications and Synthetic Monitors. If in one monaco run you create an application and then reference it in a synthetic test, Monaco will fail stating the Application does not exist. A subsequent run would be successful.

I have a similar issue with SLOs that use MZ Filter "filter": "mzName(\"{{ .mzname }}\"),type(\"SERVICE\")".  monaco log will show Response was: {"error":{"code":400,"message":"SLO validation failed with 1 error(s):\nGiven filter is invalid."}}, responsible config: monaco-files/projects/workshop/slo/monolith-slo.json.    If you want a new issue for this, let me know.

@kristofre We just experienced this issue with the combination of a new Application and new Synthetic Monitors like you describe. Will this issue be fixed in a future version? This sounds like a general retry mechanism which should be added to Monaco which waits untill all dependencies are created.

Another timing issue: synthetic tests + synthetic credential vault. The error is:
11:12:56  2021-11-25 10:12:55 ERROR 	Id '<project>/credential-vault/<referenced-id>' was not available. Please make sure the reference exists.

I'll take a look at this issue next and try to find a generic solution to the problem. As of now we have some rudimentary retry mechanism based on whitelisting in place: https://github.com/dynatrace-oss/dynatrace-monitoring-as-code/blob/main/pkg/rest/config_upload.go#L85-L107
The goal would be to detect automatically if a retry is necessary. One possible implementation: When the upload of a config fails:

We check whether dependencies of this config were just being created (monaco performed a POST).
If no: return the error to the user
If yes: Check if these dependencies already exist by performing a GET request and possibly start a retry handling until the GET returns the wanted config (or times out). When it does: retry the failing config update.


Is there a newer version of this documentation?

I'm hoping to use Microsoft Forms as the front end and have approvers interact with the workflow from within Microsoft Teams.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3f86061a-70b6-f9d0-4450-158876f2cd4d
Version Independent ID: ee2fde39-1f02-6a2b-ca91-5caba0d1694a
Content: Create a modern approval workflow with multiple approvers - Power Automate
Content Source: articles/sequential-modern-approvals.md
Service: flow
GitHub Login: @MSFTMan
Microsoft Alias: deonhe

This doc has been updated.

Updating this topic

Topic updated


When sending user data, only send populated attributes

Implement selective user update logic, so that only attributes with updated values will be sent to the auth server API.

:+1:


Can vim-airline indicate command mode?

Is it possible for the status bar to indicate command mode and search mode? I.e. when I hit : and begin typing an ex command, it'd be great if the airline indicator mode changed. It still says normal when I am in fact in command mode, for instance.
Looking at the code, it looks like the check_mode function is where this is done, and I don't see an option for command mode. Looking at :help mode(), however, suggests a string is returned for command mode, which makes me think it is possible.
Does airline already support this? Am I missing an option somewhere?

doesn't look like this is possible.
let g:inc = 0
function! Inc()
  let g:inc = g:inc + 1
  return g:inc
endfunction
set statusline=%{Inc()}

once you're inside : the statusline stops updating.  normally it will increment with every keystroke.
and without autocmds to tell us when we enter/exit ex mode we're pretty much stuck.


Question Event Resize

Hello,
Is there an effective way to get the event when the browser window is resized or a control is resized ?
With no real lag ? Often I have found solutions with a listener with a frequency for the check.
Maybe with Resize Observer https://drafts.csswg.org/resize-observer-1/ or resize event https://developer.mozilla.org/en-US/docs/Web/API/Window/resize_event ? Could be nice to have this feature in your 'blazor-components' project.
Thanks for any answer. 😄

Hi @boukenka,
Yes definitely ways to get nonfictions about "resize". However it requires JS interop to happen. Which definitely will have impact on performance. Cannot really tell you the exact delay (lag) time. Since Blazor is a client side framework. So the performance can be hugely impacted by the client machine performance.
I already have some "Global" events listener wired up to Blazor via JS interop. You can check e.g. Mouse events in this demo app. Please have a look on it and let me know if you think it has the required performance. If yes then I can add very similar API interfaces for other global events like you requested: resizing.

Thanks @majorimi. I had a look to the demo. It seems pretty fast. It should have the required performance.

Yes it is pretty fast. Even with the UI rendered and log scrolling to the bottom (that is another JS call)...
Ok I will add "Resize" events support for Window and HTML elements. Probably will be in the next release.

Thanks @majorimi  and have a nice week-end!

@boukenka I have merged Resize-Js to the next release branch. Finalizing on small component so in a few days I will publish v1.1.0 Nuget packages.

Hi @boukenka,
I'm closing your request as it was deployed with v1.1.0. You can download latest Nuget package. See usage and try out in Demo app Resize-JS.
Hope you will be satisfied with the lag time as well.

@majorimi Sorry it took some time to answer you. I did some tests this morning. The solution you have implemented is really good. The lag time is very small. Thank you again 😄

Hi @boukenka,
Good to hear that 😄 Please check usage example which is currently missing DisposeAsync() call. Since all JSInterop should be disposed. However I made some mistake in that so currently you will get Exception. I already fixed that which will be published soon in v1.2.
Also note that v1.2 will have a small breaking change. All namespaces renames must be @using Majorsoft.Blazor.* So it is simple to fix....

Ok v1.2.0 was released today with your request in it...

Ok v1.2.0 was released today with your request in it...

Hi  @majorimi
I have updated my project with the latest version v1.2.0 (also based on the demo code).
It works perfectly. Thanks again.

Hi  @majorimi
I have updated my project with the latest version v1.2.0 (also based on the demo code).
It works perfectly. Thanks again.


Is there a way to make this mod affect other attributes

Make sure you are not opening a duplicate.

[x] I have searched the issue tracker and did not find an issue describing my bug.

Description of your suggestion.
besides just ranged damage and melee for example working with Wizards mod, or even just being able to reforge a staff from the mod?

yes, you can add your own datapack with every attributes you want, check out the readme :)


start: Add code as dependency to experiment

See https://github.com/iterative/dvc.org/pull/4393#discussion_r1140640775_
The experiments get started doesn't specify that you should have your code committed to git so that your experiment is reproducible.

Not sure this has come up as an issue yet. Closing.


[FlowAggregator] Upgrade to ClickHouse Go client v2

ClickHouse Go client v1 is in maintenance-only mode. All new features are being introduced in v2.
It seems that v2 of the client also received performance improvements: https://github.com/ClickHouse/clickhouse-go#benchmark
There are some breaking changes between v1 and v2, which have been documented here: https://github.com/ClickHouse/clickhouse-go/blob/main/v1_v2_CHANGES.md
We should upgrade the Antrea Flow Aggregator to use v2 of the client, for future-proofness and to benefit from the improvements introduced in v2.

Hi @antoninbas , I got some dependencies conflicts on go.opentelemetry.io/otel

The latest ClickHouse Go client v2 github.com/ClickHouse/clickhouse-go/v2 v2.9.1 requires go.opentelemetry.io/otel v1.13.0, even v2.0.0 requires go.opentelemetry.io/otel v1.3.0
Antrea depends on k8s.io/apiserver v0.24.0, which depends on go.opentelemetry.io/otel v0.20.0
go.opentelemetry.io/otel introduces incompatible changes between v0.x.y and v1.x.y

There are a lot of related issues in opentelemetry-go repository: e.g. https://github.com/open-telemetry/opentelemetry-go/issues/3292
These are what I got when running go mod tidy after upgrading ClickHouse Go client to v2.9.1. For example, go.opentelemetry.io/otel/metric/registry no longer exist in v1 modules
antrea.io/antrea/cmd/antrea-agent imports
	k8s.io/apiserver/pkg/server/options imports
	go.opentelemetry.io/otel/semconv: module go.opentelemetry.io/otel@latest found (v1.15.0), but does not contain package go.opentelemetry.io/otel/semconv
antrea.io/antrea/cmd/antrea-agent imports
	k8s.io/apiserver/pkg/server/options imports
	go.opentelemetry.io/otel/exporters/otlp/otlpgrpc imports
	go.opentelemetry.io/otel/exporters/otlp/internal/transform imports
	go.opentelemetry.io/otel/metric/number: module go.opentelemetry.io/otel/metric@latest found (v0.38.0), but does not contain package go.opentelemetry.io/otel/metric/number
antrea.io/antrea/cmd/antrea-agent imports
	k8s.io/apiserver/pkg/server/options imports
	go.opentelemetry.io/otel/exporters/otlp/otlpgrpc imports
	go.opentelemetry.io/otel/exporters/otlp imports
	go.opentelemetry.io/otel/sdk/metric/controller/basic imports
	go.opentelemetry.io/otel/metric/registry: module go.opentelemetry.io/otel/metric@latest found (v0.38.0), but does not contain package go.opentelemetry.io/otel/metric/registry
antrea.io/antrea/cmd/antrea-agent imports
	k8s.io/apiserver/pkg/server/options imports
	go.opentelemetry.io/otel/exporters/otlp/otlpgrpc imports
	go.opentelemetry.io/otel/exporters/otlp imports
	go.opentelemetry.io/otel/sdk/metric/controller/basic imports
	go.opentelemetry.io/otel/sdk/metric imports
	go.opentelemetry.io/otel/internal/metric imports
	go.opentelemetry.io/otel/metric/sdkapi: module go.opentelemetry.io/otel/metric@latest found (v0.38.0), but does not contain package go.opentelemetry.io/otel/metric/sdkapi

I see k8s.io/apiserver latest depends on  go.opentelemetry.io/otel v1.10.0 : https://github.com/kubernetes/apiserver/blob/2dff60bb4d1c1e9877bb624908af0d53e51634c0/go.mod#L29 . Do we consider upgrade k8s.io/apiserver first? Do you have other suggestions? Thanks

You can upgrade Antrea to use version v0.27.1 (most recent) of the K8s dependencies. Typically we try to keep these dependencies "current", but the update process can be a bit involved. This seems like a good time to do it. You should do it as a separate PR (i.e., not part of the same PR as the ClickHouse update).
Refer to these 2 PRs for the previous update:

https://github.com/antrea-io/antrea/pull/3742
https://github.com/antrea-io/antrea/pull/3813

(it should have been a single PR, but I forgot something in the first one)

I noticed K8s v0.27.1 uses Go 1.20. Do we want to 1) open another PR to upgrade Go version or 2) only upgrade K8s lib to v0.26.4 which uses Go 1.19?
Given the scope of this upgrade, Elton suggested me to also cc @tnqn and @luolanzone in case they have any objections

v0.26.4 is fine by me


#2554 MIDI note offs for playing notes when sequencer stops

I am forgoing any points for tests this time, since there is currently no precedent to test this correctly in code.
I have done some QA with an app I have for testing starting stopping, loops, no loops, and note trigger / loop boundary edge cases

I'm going to merge so @btfranklin has a chance to test.


Minify JavaScript et CSS files

In GitLab by @vrechdelaval on Sep 7, 2015, 20:58
Using YUI compressor ?


Use original request if the reroute fails

Hi ,
Is there a way to configure angular-apimock to use the original request if the reroute fails. I believe in the current implementation its possible to do the opposite (i.e try the original request, if it fails then it tries to recover with a reroute) by setting apimock=auto.
Thanks & Regards

You're right, it's possible to do the opposite of what you want. I'll consider it, but it might take a while. I'd gladly appreciate a PR if you want to contribute.


id number for United_Kingdom

https://en.wikipedia.org/wiki/National_identification_number#United_Kingdom

finish national insurance number https://www.gov.uk/hmrc-internal-manuals/national-insurance-manual/nim39110


Failing Aspire.Playground.Tests.AppHostTests.TestEndpointsReturnOk for TestShop.AppHost

Build Information
Build: https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=782411
Build error leg or test failing: Aspire.Playground.Tests.AppHostTests.Aspire.Playground.Tests.AppHostTests.TestEndpointsReturnOk
Pull request: https://github.com/dotnet/aspire/pull/5366

Error Message
Fill the error message using step by step known issues guidance.

{
  "ErrorMessage": "Timed out waiting for this text from resource basketservice: Application started",
  "ErrorPattern": "",
  "BuildRetry": false,
  "ExcludeConsoleLog": false
}

Known issue validation
Build: :mag_right: https://dev.azure.com/dnceng-public/public/_build/results?buildId=782411
Error message validated: [Timed out waiting for this text from resource basketservice: Application started]
Result validation: :white_check_mark: Known issue matched with the provided build.
Validation performed at: 8/20/2024 10:07:03 PM UTC

Report

Build
Definition
Test
Pull Request

827989
dotnet/aspire
Aspire.Playground.Tests.AppHostTests.Aspire.Playground.Tests.AppHostTests.TestEndpointsReturnOk
dotnet/aspire#6119

Summary

24-Hour Hit Count
7-Day Hit Count
1-Month Count

0
0
1

note to self: message is likely getting missed because it arrives before we start waiting for text. solution: WaitforResources, and then start waiting. And use eventing to set up waiting for text before starting the app.

Update: This is incorrect as the all the messages get replayed note to self: message is likely getting missed because it arrives before we start waiting for text. solution: WaitforResources, and then start waiting. And use eventing to set up waiting for text before starting the app.


175 refactor styling from stylecss into themejs

name: Issue 175
about: removes style.css and reference to it in project's index file

CONCISE description of PR 175

This PR:
1. Removes redundant styles.css file since project is utilizing MUI

Issues needing discussion/feedback (optional):
1. When I was about to push this originally, I thought I saw some unexpected behavior while testing manually. I'm having issues trying to reproduce this now, so additional testing/review would be appreciated.

Hi masen, thanks for working on this. I don't have time to go over the code just yet but wanted to note that this should be merging into Development, not Master. You should be able to change it using the edit button at the top. Thanks!

Thanks for looking this over @leekahung @andycwilliams!


[Bug]: Progress bar caps out at 24hrs

Library version
1.1.1
PHP version
8.2
Bug description
We have some big tasks :)
Sample code
No response
Code of Conduct

[X] I agree to follow the Code of Conduct

Thank you for your useful insight with using this library for big tasks. The behavior of the progress bar has been changed in version 1.1.2 to avoid capping out at 24 hours.


Pyright logging has changed to log arrays in alpha

(2) ['[LS]', 'Searching for source files']
instrument.ts:125 (2) ['[LS]', 'No source files found.']
instrument.ts:125 (2) ['[LS]', 'Background analysis(Pyright-background-1) root directory: /']
instrument.ts:125 (2) ['[LS]', 'Background analysis(Pyright-background-1) started']

We're not clear why this has changed.

This was a bug introduced in sentry 6.17.7 and fixed in 6.17.8 - see issue https://github.com/getsentry/sentry-javascript/issues/4558.
This is now no longer a problem in the alpha and the console is logging strings again.
In our theme project, we use<EMAIL_ADDRESS>but apparently this is not respected. See the output in this issue where @sentry/minimal is referenced as 6.16.1 - https://github.com/microbit-foundation/python-editor-next-microbit/issues/8. What is going on here?

I think it's just semver combined with the way we install the theme package.
Because we npm install it, we don't benefit from the lock file tracking the versions of its dependencies.
The only dependency is Sentry.
I've pinned it in the theme project and will upgrade to that version.


compatibility with recipe stages

can be added compatibility with recipe stages ? for now if put unlocked recipe start crafting but don't make anythings

Heys Alle, IIRC only dynamic mod recipes should need special game-stages integration. The mod uses only the standard recipes, should this not be covered by the game-stages mod/kube/tweaker? Or did I not understand the question correctly (sorry in that case, simply let me know). Cheers,-

the issue is automated crafting with anthillinside, not the recipe


Pipeline produces empty file download.txt

Hi Stirling-PDF Team,
first of all, thanks for this great app. I discovered it recently and immediately add it to my home services :)
I want to use the pipeline function to make a watchdog for scanned documents.
Scan to folder > OCR + some post processing > take it from the output folder
Unfortunate, when trying my pipeline in the GUI the output is always an empty file "download.txt". Also (of course) the pipeline is not working in the configured folder. Is there anything I done wrong?
Here is the pipeline definition:
OCR-Watchdog.json
{   "name": "OCR-Watchdog",   "pipeline": [     {       "operation": "/api/v1/misc/remove-blanks",       "parameters": {         "threshold": 10,         "whitePercent": 99.9,         "fileInput": "automated"       }     },     {       "operation": "/api/v1/misc/ocr-pdf",       "parameters": {         "languages": [           "deu",           "eng"         ],         "sidecar": false,         "deskew": true,         "clean": true,         "cleanFinal": false,         "ocrType": "skip-text",         "ocrRenderType": "hocr",         "removeImagesAfter": false,         "fileInput": "automated"       }     },     {       "operation": "/api/v1/misc/auto-rename",       "parameters": {         "useFirstTextAsFallback": false,         "fileInput": "automated"       }     }   ],   "_examples": {     "outputDir": "{outputFolder}/{folderName}",     "outputFileName": "{filename}-{pipelineName}-{date}-{time}"   },   "outputDir": "{outputFolder}/Scan-Output",   "outputFileName": "{filename}" }
Tried different language descriptions (e.g. "German","English") but none worked.
Running 0.22.8 on Docker.
Thanks a lot!

https://github.com/Stirling-Tools/Stirling-PDF/discussions/989
seem to have their languages as "languages": "deu, eng",
Not sure if that will fix it, also are there any docker logs you can share about this if you still facing issue?

Thanks for the quick answer! Yes, that fixed it 👍


Clear, minimal configuration file example

As a novice developer
I want the example configurations.INI to contain only programmatically meaningful, well-described items
so that I can learn the configuration options efficiently.
AC

All obsolete fields (e.g. the ones under "[vintage]") are removed from the file.
Each field is preceded with a comment describing what it does and/or some other illustrative example values to try out. (This presumes that the config file format supports comments; if not this may need to be discarded.)

Great suggestion. A hashtag # can be used for comments, so we should be in business: https://docs.python.org/2/library/configparser.html

Assigning to @BenHaleyEvolvedEnergyResearch for checking branch clear_config_1


Add Uint256 strategy

I'd also ask @mkaput since he's the fuzzing specialist 😬

As discussed on the meeting, will be merged in it's current state.

@Radinyn Are docs updated about this? Also if it is a breaking change we should mention it in changelog

@Radinyn Can you create task for this and add it to this milestone?


Automated Azure Deployment

It would be great to have the needed models for the project deployed automatically using either ARM templates or bicep. This would save from long setup documentation and also ensure correctness for the project.

Hi @ghost-pep,
Thanks for raising this issue!
I could not find a reference to the specific Azure resources needed in the repository. Could you help clarify which resources (e.g., Azure Functions, Cognitive Services, or others) you’d like to have automatically deployed?
Based on the project structure, I assume the following might be relevant:

Azure OpenAI Service or Cognitive Services for AI models,
Azure Storage and Azure App Service/Functions for hosting,
and potentially Key Vault for secrets management.

Kind regards

Hey! These are great questions! For the code that is currently in the repo, we deployed an Azure OpenAI (AOAI) instance and then deployed models like GPT3/4 for a backing implementation for our text completion using API keys. The right way to do this would be to have a fully automated deployment that does not use keys and rather deploys our code to Azure App Service and then links to the Azure OpenAI instance using managed identities. This can all be automated using Bicep (my preferred solution over ARM templates directly).
For those looking to work on this issue, I'd start by getting a Bicep file that can deploy Azure OpenAI with models working. I would say that the overachieving way would be to fully automate the app deployment as well but that would be a massive bonus to the MVP of just getting automated AOAI up and running


ad hoc type checking for R.multiply and R.divide

Current behaviour:
R.multiply(1, 'XXX');
// => NaN

R.divide(1, 'XXX');
// => NaN

New behaviour:
R.multiply(1, 'XXX');
// ! TypeError: ‘multiply’ expected a value of type Number as its second argument; received "XXX"

R.divide(1, 'XXX');
// ! TypeError: ‘divide’ expected a value of type Number as its second argument; received "XXX"

I'm not yet convinced.
Why shouldn't 1 * 'XXX' result in NaN?  If you try to multiply a number by a non-number, that seems quite a propos.  And a throwing an exception again has the problems with composability that always bother me.  It strikes me as very much a last resort.
In #1573, we had a different situation, where our implementation was reporting an inappropriate value.  Here this starts to stray into the territory of Sanctuary.  As far as I'm concerned, Ramda isn't in the business of making Javascript into a more type-safe language.  If the user wants to use it in with her more type-safe code, it should work just fine, but trying to impose that much additional discipline on her is the province of a higher-level library, or even better, of a language that has better type tools built in.

If we want R.multiply('foo', 'bar') to evaluate to NaN, shouldn't R.add('foo', 'bar') evaluate to NaN also? It seems to me the behaviour should at least be consistent.

I agree with @CrossEye .
JS allows multiplication between non-numeric types if the object defines the valueOf method. For example, the following code works just fine in Chrome 46.0.2490.80 (64-bit).
var obj = {valueOf: () => 2};
obj * 2 // 4

@niloy, your argument applies equally to addition and subtraction.

@davidchambers Which begs the question, why did you choose multiply and divide. There are better candidates. In multiply and divide, the input can come from user, the user is free to input non-numeric data.
Consider a scenario where a list of numbers is being pulled from server and I need to map over them to generate their doubles. getDataFromServer().then(R.map(R.multiply(2))). Lets say from whatever reason, the list contains some non-numeric data. If multiply throws, mapping if other valid numbers in the list is also halted. I would rather prefer that map produces NaN for the invalid values rather than a complete exit.

This just makes me think we were too hasty in #1573.
I just saw the problems with R.inc and realized that they were traceable to R.add and didn't see any better solution than throwing.  But the point from @niloy makes me realize that there's more going on.

makes me wonder if a function enabling composition with exceptions could be useful.
Consider: tryWith :: (x -> a) -> (e -> a) -> a where the first function is evaluated and returns a unless it throws; in which case the second function is evaluated and returns a.
Not as elegant as it is in OCaml, but maybe better than nothing. Because this is JS, this would rely on the good behavior of developers to ensure that the return types of the two functions line up.

makes me wonder if a function enabling composition with exceptions could be useful.

We have encase and encaseEither. :)

makes me wonder if a function enabling composition with exceptions could be useful.

Recently discussed on Gitter.

We have encase and encaseEither. :)

yes, similar. encase guarantees a 'a Maybe, what i am suggesting would leave the choice of return value up to the user.

Consider a scenario where a list of numbers is being pulled from server and I need to map over them to generate their doubles. getDataFromServer().then(R.map(R.multiply(2))). Lets say from whatever reason, the list contains some non-numeric data. If multiply throws, mapping if other valid numbers in the list is also halted. I would rather prefer that map produces NaN for the invalid values rather than a complete exit.

If you know that your computation requires a list of Numbers and you can't trust your input, why are you not beginning your pipeline with R.filter(R.is(Number))? It's good practice to sanitise your inputs when you have strict constraints like that.

If you know that your computation requires a list of Numbers and you can't trust your input, why are you not beginning your pipeline with R.filter(R.is(Number))? It's good practice to sanitise your inputs when you have strict constraints like that.

For the four years this system has been running, the list has always supplied numbers.  When you wrote the code, it was clear and obvious that the generator could only supply numbers.  But a confluence of changes made by the junior developer who was around two years ago and made some changes that seemed innocuous to the code reviewer, a little optimization made by the summer intern, and a update to an external library that a brand new hire implemented as her first project before leaving for greener pastures means that in that unlikely -- but unfortunately possible -- case that a user deletes her age on the final submission screen, there could be an undefined value in what would usually be a list of numbers.  Again, this was not possible when the code was written four years ago, or you would have guarded against it.  Now however, even though this is an entirely optional field, the application crashes on the user, with an obscure message and a very difficult-to-recreate situation.
Not being able to trust the data is very much a sliding scale, and an ever-changing one.

I understand what you're saying but my response was to the particular scenario presented there, i.e., for some reason allowing a pipeline to spew out NaNs is preferable to a function within it throwing with a descriptive error message. Surely those NaNs will just go on to cause an exception in an even more obscure and hard to track down place unless you filter them out, which brings us back to the original point that it's better not to let the situation arise in the first place.

it's better not to let the situation arise in the first place

That's certain.  But the question to us as a library is how to handle it if they do.  My take is that throwing an exception should be extremely rare, and only if there is no other reasonable option.  Because a function that throws is not composable, and, in my example above, even though the error would not cause any further issues, we've stopped a customer from completing her purchase on our site because of this hard-to-debug scenario.  Who knows how much business we'll lose before some kind-hearted soul bothers to report this to us?

I hope your back end knows how to process NaN-dollar payments. :stuck_out_tongue_winking_eye:

Presumably some system somewhere will have to fail, and there is certainly a problem in separating the cause of the failure from where it's articulated.  But I don't think it's our responsibility as a library to interject ourselves and point out the user's already-existing failures.  Bad data passed to the library is not the library's fault, and interjecting our possibly unwanted corrective action just says that the user needs her hand held.  Doing it by throwing an exception means that she can no longer use functional composition to build this part of the application but must wrap everything in some try...catch logic.
I would rather let her compose functions as she chooses, and decide where to handle such potential failures on her own.  My hope is that she would correct the data at its source so there's no chance of passing something bad into Ramda, but if not, I would rather pass out a NaN and let her decide whether that's a problem on her own.
It's not always possible, of course.  But often we can give a reasonable result even with bad data; when we can, I would prefer that we do, reserving exceptions for when we have no reasonable choice.
To me, encase or tryWith are mostly Band-Aids on this problem.  They don't solve the basic issue, but allow some chance of composing the system out of pieces in places where its clear an exception is a real possibility.  They're good to have, but I wouldn't want to rely on them except in quite unusual circumstances.


HmIP-SRD

Please integrate the HmIP-SRD
I attached the a link to the descriptions I got from my CCU
Please let me know if you need something else.
https://gist.github.com/malkie-hass/1b84c4dfaf393127fb43049e3b07d5d7
Thanks a lot
Malkie

I have added support in version 0.1.71.

I have added support in version 0.1.71.


execute bash scripts via system command

in some parts of the code, a terminal is opened and a bash script is executed later. This function does not work.

now I fix this one, look at https://github.com/NachtsternBuild/fastboot-assistant/blob/main/Anwendung/header/header_open_terminal_by_desktop.c

it's time to remove all bash scripts


Update Composer dependencies (2021-11-24-00-08)

Visual regression test passed!
View the visual regression test report


Remove unused webpack files.

Thanks!

Right, good catch.
Should be correct now.

Coverage remained the same at 99.206% when pulling 9977a72fc8f96f838b59b8dd5cd18e16c7ef93be on rikkert:v3.0.0 into b0f3f3725e3483e76096b04687481aafc8ef1719 on mxstbr:v3.0.0.

This looks good, thanks so much!


Lite server could not start

D:\!Projects\TypeScript\ui-router\quickstart-ng2>npm update
<EMAIL_ADDRESS>D:\!Projects\TypeScript\ui-router\quickstart-ng2
+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>`--<EMAIL_ADDRESS>
npm WARN optional Skipping failed optional dependency /chokidar/fsevents:
npm WARN notsup Not compatible with your operating system or architecture<EMAIL_ADDRESS>npm WARN<EMAIL_ADDRESS>No repository field.

D:\!Projects\TypeScript\ui-router\quickstart-ng2>npm start

><EMAIL_ADDRESS>start D:\!Projects\TypeScript\ui-router\quickstart-ng2
> npm run tsc && npm run watch

><EMAIL_ADDRESS>tsc D:\!Projects\TypeScript\ui-router\quickstart-ng2
> tsc

><EMAIL_ADDRESS>watch D:\!Projects\TypeScript\ui-router\quickstart-ng2
> npm run tsc:w & npm run lite

><EMAIL_ADDRESS>tsc:w D:\!Projects\TypeScript\ui-router\quickstart-ng2
> tsc -w

00:06:46 - Compilation complete. Watching for file changes.

When I change this line:
"watch": "npm run tsc:w & npm run lite",
to
 "watch": "npm run lite & npm run tsc:w",
It's run as expected.
00:06:46 - Compilation complete. Watching for file changes.
Terminate batch job (Y/N)? y

D:\!Projects\TypeScript\ui-router\quickstart-ng2>npm start

><EMAIL_ADDRESS>start D:\!Projects\TypeScript\ui-router\quickstart-ng2
> npm run tsc && npm run watch

><EMAIL_ADDRESS>tsc D:\!Projects\TypeScript\ui-router\quickstart-ng2
> tsc

><EMAIL_ADDRESS>watch D:\!Projects\TypeScript\ui-router\quickstart-ng2
> npm run lite & npm run tsc:w

><EMAIL_ADDRESS>lite D:\!Projects\TypeScript\ui-router\quickstart-ng2
> lite-server

Did not detect a `bs-config.json` or `bs-config.js` override file. Using lite-server defaults...
** browser-sync config **
{ injectChanges: false,
  files: [ './**/*.{html,htm,css,js}' ],
  watchOptions: { ignored: 'node_modules' },
  server: { baseDir: './', middleware: [ [Function], [Function] ] } }
[BS] Access URLs:
 --------------------------------------
       Local: http://localhost:3000
    External: http://<IP_ADDRESS>:3000
 --------------------------------------
          UI: http://localhost:3001
 UI External: http://<IP_ADDRESS>:3001
 --------------------------------------
[BS] Serving files from: ./
[BS] Watching files...
16.09.06 00:10:58 200 GET /index.html
16.09.06 00:10:58 200 GET /node_modules/es6-shim/es6-shim.min.js
16.09.06 00:10:58 200 GET /node_modules/zone.js/dist/zone.js
16.09.06 00:10:58 200 GET /systemjs.config.js
16.09.06 00:10:58 200 GET /styles.css
16.09.06 00:10:58 200 GET /node_modules/reflect-metad

Interesting, the ampersand I was using apparently doesn't work on Windows.
I wanted both those commands to run concurrently.


add basic support for cmake

A lot of projects (for ex. pico-sdk) use cmake as their compilation helper. I needed to include this in my Pico project, so here it is.
It becomes trivial to use (and also add compile flags). Example:
add_subdirectory(littlefs)
target_compile_definitions(littlefs PUBLIC LFS_THREADSAFE)

Hi @MrJake222, thanks for creating a PR.
I appreciate the thought to upstream this, but I'm hesitant to bring this in unless more people weigh in that this is useful.
The problem is that there's always N+1 build systems, and my general experience is cmake configuration ends up very project-specific. Though those projects could have been using cmake "wrong".

We would probably also need to add cmake to the CI to at least test that the configuration continues to build correctly.

This would definately be usefull for us when integrtating littlefs into our CMake based projects. Having to add littlefs with ExternalProject_add() and setting a BUILD_COMMAND with a lot of parameters to get it into a CMake project is just not a good solution and is highly dependent of the format of the littlefs makefile.

Adding CMake support would be really helpful for those using CMake for their projects. On the other hand:

cmake configuration ends up very project-specific

I believe that it would be better just to create a section in the README describing which CMake commands to include in one's CMakeLists.txt in order to link the littlefs source files

Adding CMake support would be really helpful for those using CMake for their projects.

Yes.

On the other hand:

cmake configuration ends up very project-specific

I believe that it would be better just to create a section in the README describing which CMake commands to include in one's CMakeLists.txt in order to link the littlefs source files

👎 What if the app developer wants to include the littlefs repo as a git submodule, and build it as a library with CMake?

I'm a fan of CMake but would vote a no on this one. There is really only one compilation unit in the project. Two if you include the CRC implementation. Easy to add to any build system.
Those that want to add it as a library, could do so. Those that want to add it directly into their own target, could do so as well. Pleasing both use cases and who knows what else invites some maintenance work along the way.
Doing add_subdirectory() to include another project requires some careful thought. Do you really want the other project's install files, tests, benchmarks, development dependencies to be part of the parent project? Granted, that's not the case here since the project is not using cmake but that's generally what root level CMakeLists.txt is for. I'd rather see this in some support/static_library.cmake etc.
ExternalProject_Add() is a bit more isolated but still invokes the same unnecessary complexity in the subproject's own build system while actually you are only interested in a couple of files.

👎 What if the app developer wants to include the littlefs repo as a git submodule, and build it as a library with CMake?

It sounds like a problem with the build system if it doesn't support this use case.

I'm a fan of CMake but would vote a no on this one. There is really only one compilation unit in the project. Two if you include the CRC implementation. Easy to add to any build system.

CMake supports globbing doesn't it? The relevant sources are *.h and *.c is this is unlikely to ever change.

It's interesting to note no other project in the space (dhara, spiffs, ChaN's fatfs) provide a CMakeLists.txt. ChaN's fatfs, the most popular, doesn't even provide a Makefile.
Worst case we could provide a separate repo, maybe littlefs-cmake, for CMake integration. But I think the CMakeLists.txt will never actually converge into something that makes everyone happy. I'm also not sure the maintainer-headache vs user-headache tradeoff makes sense...

I'm not sure I'm entirely persuaded, but based on feedback here, I'm content not to keep advocating for this one.
I'm not the pull requestor, though.


docs(zh-cn): Reviewed 38_saving-and-reloading-a-dataset.srt

docs(zh-cn): Reviewed 38_saving-and-reloading-a-dataset.srt #390

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


API Keys, request for information

When creating the API key for Dribbble and for ProductHunt, what did you use as the callback/redirect URL when registering an application on their site?
Is it OK to use http://www.example.com ?

For dribble the callback is plaid://dribbble-auth-callback


Add linters and rules from firefly repo

To keep consistency across codebases, we should add the linters to the Makefile to this repo from https://github.com/hyperledger-labs/firefly/blob/main/Makefile

I can pick up this one.


Autoplay with different volume

Is is possible to autoplay 2 players at the same time but with different volumes?!
Because I've noticed that it saves a global value for volume, when volume is tweaked.
Once you refresh the page all the players start with the saved volume and not with the one specified in plyr.setup();

just use .setVolume on the different instances.

As above really - use .setVolume()


Allow for custom capitalizations in navigation links

Fixes #487
Introduces a custom capitalize method in the script that generates and adds the navigation links which takes into consideration a map of custom capitalizations, for example: "exunit" => "ExUnit".
I populated the list with everything I noticed as I clicked through each page, but any additional customizations can be added after-the-fact as they arise.
The only code change was in utils/lib/mix/tasks/add_navigation.ex while the rest of the changes were  performed by mix bc.

Looks great!
For some reason, I have it in my head that module attributes should go at the top of the module (for idiomatic reasons, not behavioral ones), but I found Elixir documentation that contradicts me: https://elixir-lang.org/getting-started/module-attributes.html
What do you think? I'm not blocking the PR over something so pedantic, I'm just curious about your thoughts.

Looks great!
For some reason, I have it in my head that module attributes should go at the top of the module (for idiomatic reasons, not behavioral ones), but I found Elixir documentation that contradicts me: https://elixir-lang.org/getting-started/module-attributes.html
What do you think? I'm not blocking the PR over something so pedantic, I'm just curious about your thoughts.

I remember asking myself that question when I was working on it. I think I decided to keep it close to the function that used it so it was easy to see the definition when reading the code for capitalize, but I agree that it does feel more "right" or idiomatic to have it at the top. I guess if the module were larger the feeling that it needs to be close to where its used would be a bigger concern, and maybe a code smell that the module is doing too many things, but in this case where the module is pretty small and relatively single-purpose, I think either location (including the more idiomatic one at the top) would be fine. Let me know if you'd like me to move it up.  :)

I'm happy with it as it is! I appreciate your thoughts!


error MSB4086 on install

Hi, I'm running npm-install and seeing the following error...
C:\Windows\Microsoft.NET\Framework\v4.0.30319\Microsoft.Common.targets(94,27): error MSB4086: A numeric comparison was
attempted on "$(TargetPlatformVersion)" that evaluates to "10.0.10586.0" instead of a number, in condition "'$(UseOSWin
MdReferences)' == '' and ('$(TargetPlatformWinMDLocation)' == '' and '$(TargetPlatformIdentifier)' == 'Windows' and $(
TargetPlatformVersion)' > '7.0')". [C:\Users\Tom\Dev\app\node_modules\.staging\electron-
windows-interactive-notification-906feb04'InteractiveNotifications\InteractiveNotifications.vcxproj]

I was wondering if you could point me in the right direction. I have VSCode 2015 installed and build tools 2015. I've also set my VisualStudioVersion environment variable to 14.0 as was mentioned in #3 just in case this has any impact on what's happening.
Thanks!

I am also facing the problem
>msbuild .\InteractiveNotifications.sln /p:Configuration=Release /p:Platform=x64

Microsoft (R) Build Engine version 4.7.2556.0
[Microsoft .NET Framework, version 4.0.30319.42000]
Copyright (C) Microsoft Corporation. All rights reserved.

Building the projects in this solution one at a time. To enable parallel build, please add the "/m" switch.
Build started 07-12-2017 06:14:13 PM.
Project "C:\Users\Syed\MyFiles\MyWorkspace\FULLClient-Electron\node_modules\electron-windows-interactive-notifications\InteractiveNotifications.sln" on node 1 (default targets).
ValidateSolutionConfiguration:
  Building solution configuration "Release|x64".
ValidateProjects:
  The project "InteractiveManagedTest" is not selected for building in solution configuration "Release|x64".
Project "C:\Users\Syed\MyFiles\MyWorkspace\FULLClient-Electron\node_modules\electron-windows-interactive-notifications\InteractiveNotifications.sln" (1) is building "C:\Users\Syed\MyFiles\MyWorkspace\FULLClient-Electron\node_modules\electron-windows-interactive-notifications\InteractiveNotifications\InteractiveNotifications.vcxproj" (2) on node 1 (default targets).
C:\Windows\Microsoft.NET\Framework\v4.0.30319\Microsoft.Common.targets(94,27): error MSB4086: A numeric comparison was attempted on "$(TargetPlatformVersion)" that evaluates to "10.0.10586.0" instead of a number, in condition "'$(UseOSWinMdReferences)' == '' and ('$(TargetPlatformWinMDLocation)' == '' and '$(TargetPlatformIdentifier)' == 'Windows' and '$(TargetPlatformVersion)'
> '7.0')". [C:\Users\Syed\MyFiles\MyWorkspace\FULLClient-Electron\node_modules\electron-windows-interactive-notifications\InteractiveNotifications\InteractiveNotifications.vcxproj]
Done Building Project "C:\Users\Syed\MyFiles\MyWorkspace\FULLClient-Electron\node_modules\electron-windows-interactive-notifications\InteractiveNotifications\InteractiveNotifications.vcxproj" (default targets) -- FAILED.
Done Building Project "C:\Users\Syed\MyFiles\MyWorkspace\FULLClient-Electron\node_modules\electron-windows-interactive-notifications\InteractiveNotifications.sln" (default targets) -- FAILED.

Build FAILED.

"C:\Users\Syed\MyFiles\MyWorkspace\FULLClient-Electron\node_modules\electron-windows-interactive-notifications\InteractiveNotifications.sln" (default target) (1) ->
"C:\Users\Syed\MyFiles\MyWorkspace\FULLClient-Electron\node_modules\electron-windows-interactive-notifications\InteractiveNotifications\InteractiveNotifications.vcxproj" (default target) (2) ->
  C:\Windows\Microsoft.NET\Framework\v4.0.30319\Microsoft.Common.targets(94,27): error MSB4086: A numeric comparison was attempted on "$(TargetPlatformVersion)" that evaluates to "10.0.10586.0" instead of a number, in condition "'$(UseOSWinMdReferences)' == '' and ('$(TargetPlatformWinMDLocation)' == '' and '$(TargetPlatformIdentifier)' == 'Windows' and '$(TargetPlatformVersion)' > '7.0')". [C:\Users\Syed\MyFiles\MyWorkspace\FULLClient-Electron\node_modules\electron-windows-interactive-notifications\InteractiveNotifications\InteractiveNotifications.vcxproj]

    0 Warning(s)
    1 Error(s)

I solved this problem feeling awesome [gifbot:happy]
Install this it solves the problem.
https://go.microsoft.com/fwlink/p/?LinkID=698771


When using a controller to start an emotes nothing happen

Hello Been testing controller support for Too many emotes and it seem like nothing happen when using the Wheel with a controller I tried with Input utility and same issue. If you first use keyboard and mouse to use the wheel after that all emotes used using controller play the default dance emotes in first person
Rolled back to 1.8.6 and it work so something happen in a recent update
Cheers

Hmm, I'll have to test this when I get home, but thanks for bringing this up!

Sorry for the delay, this has been fixed, and will be pushed soon in 2.0.3

Awesome :) thanks!