Discord updates

Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Since @MP2E is not active anymore (https://github.com/NixOS/nixpkgs/issues/290642), please remove theem.

Since @MP2E is not active anymore (#290642), please remove theem.

https://github.com/NixOS/nixpkgs/pull/307583


Is it possible to pass extra argument flags to all dependencies?

Is it possible to pass extra argument flags to all (or specific) dependencies in the chain?
{
  "scripts": {
    "build": "wireit",
    "bundle": "wireit"
  },
  "wireit": {
    "build": {
      "command": "tsc"
    },
    "bundle": {
      "command": "rollup -c",
      "dependencies": ["build"]
    }
  }
}

Ie. I want this
pnpm build -- --mode=production

↓
to resolve to this
tsc --mode=production

I can see this being workaroundable if https://github.com/google/wireit/issues/93 gets implemented.

I see setting env vars being supported now with the caveat of Setting an environment variable with env does not apply transitively through dependencies. If you need the same environment variable to be set for multiple scripts, you must configure it for each of them.
This is not possible in some case scenarios.
Would a cascade: true be feasible?


about median value calculation in loss function

Please see here for code: https://gist.github.com/ranftlr/1d6194db2e1dffa0a50c9b0a9549cbd2
We've never tried this loss without the ReLU at the end, it is possible that this influences the training dynamic.

Hi, in paper, you said the median value comes from all valid pixels, but in the loss function below, medians were driven from all pixels. In case of the GT depth map is relatively sparse, will this code cause some issue? (eg. use mix dataset, where the valid pixel density of sample may change)
https://gist.github.com/ranftlr/1d6194db2e1dffa0a50c9b0a9549cbd2#file-loss-py-L32
Originally posted by @mzy97 in https://github.com/intel-isl/MiDaS/issues/33#issuecomment-796752326

I opened an issue about this 3 months ago and have not received a response... https://github.com/intel-isl/MiDaS/issues/73

I think it's right to use valid pixels to calculate median and I think the valid pixels should also be sorted when calculating trimmed later. Is that right?


add option to disable group mappings

Hi,
adds the option to disable group mappings (and the ldap search request).
Defaults to have them enabled (for backward compatibility).
EmTeedee

Great work! Thank you! Tehre are two minor issues I'd like to be fixed though :wink:

Good stuff, but there are problems.
IMHO, it might be better to put the group stuff into a function and then
only call that function if the group option is enabled.
On 03/06/2015 11:44 AM, EmTeedee wrote:

Hi,
adds the option to disable group mappings (and the ldap search request).
Defaults to have them enabled (for backward compatibility).
EmTeedee

    You can view, comment on, or merge this pull request online at:

https://github.com/heiglandreas/authLdap/pull/26
    Commit Summary

enable/disable group mapping

change debug message
File Changes

M authLdap.php
https://github.com/heiglandreas/authLdap/pull/26/files#diff-0 (73)

M view/admin.phtml
https://github.com/heiglandreas/authLdap/pull/26/files#diff-1 (52)
Patch Links:

https://github.com/heiglandreas/authLdap/pull/26.patch

https://github.com/heiglandreas/authLdap/pull/26.diff

—
Reply to this email directly or view it on GitHub
https://github.com/heiglandreas/authLdap/pull/26.

This should address all the problems raised.

Thanks! Looking good :+1:


✨ Rename the edge API group

Summary
This PR renames the API group edge.kubestellar.io to control.kubestellar.io, then makes necessary updates (code and doc) related to the renaming.
This PR begins to handle #1544.

Thanks @waltforme
/lgtm
/approve


Minor: Disabled dashed-line deprecation warning.

Thank you for contributing to harp.gl!
Before requesting a pull request, please remember to check the following documents:

contribution guidelines
coding style

If you are adding new functionality we would highly appreciate if you can describe what is the capability you are adding and even better if you can add some examples. Please also remember to add tests for it.
Our bots will check whether your PR can be directly integrated into the mainline. We have some internal integration tests running on the background, our bots will inform you of the next steps and someone from our team will take a look and help if needed!
And please do not forget to sign-off your commit! You can read more about DCO here. But, in short, you just need to use git commit -s or append --signoff when you are committing to the repo.
Happy contributing!

Codecov Report

Merging #1052 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1052      +/-   ##
==========================================
+ Coverage   45.85%   45.86%   +<.01%
==========================================
  Files         237      237
  Lines       22093    22091       -2
  Branches     4962     4961       -1
==========================================
  Hits        10131    10131
+ Misses      11962    11960       -2

Impacted Files
Coverage Δ

@here/harp-mapview/lib/ThemeLoader.ts
82.23% <ø> (+0.82%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3106b9d...8c92cf5. Read the comment docs.


⚠ RbxVeri has degraded performance

In e50f16c, RbxVeri (https://verify.triza.dev) experienced degraded performance:

HTTP code: 200
Response time: 8392 ms

Resolved: RbxVeri performance has improved in a021aa2.


StringJoin issue on CUDA EP: scalar input could only be applied to CPU tensor

Hello,
I used tensorflow-onnx to transform my TF model to ONNX with either --opset 18 --extra_opset ai.onnx.contrib:1 --custom-ops StringJoin:ai.onnx.contrib or --opset 18 --extra_opset ai.onnx.contrib:1 or --opset 18 --extra_opset ai.onnx.contrib:1 --custom-ops StringJoin:ai.onnx.contrib,StringSplit:ai.onnx.contrib
When loading it with onnxruntime and the associated custom ops (aka CPU EP) everything works. With onnxruntime-gpu and the associated custom ops (see snippet below, same problem using io_binding) I have the following error 2023-10-18 10:53:42.171526398 [E:onnxruntime:, sequential_executor.cc:514 ExecuteKernel] Non-zero status code returned while running StringJoin node. Name:'StatefulPartitionedCall/ReduceJoin/ReduceJoin' Status Message: 1: scalar input could only be applied to CPU tensor
import onnxruntime as rt
from onnxruntime_extensions import get_library_path
import numpy as np

sess_options = rt.SessionOptions()
sess_options.register_custom_ops_library(get_library_path())
inference_session = rt.InferenceSession("path", sess_options, providers=["CUDAExecutionProvider"])
inputs = np.random.randint(0, 249, (64, 45), dtype=np.int32)
inference_session.run(None, {"inputs": inputs})

How can I use this operation with CUDA EP like other operations that are placed on CPU EP? I attached a minimal onnx model with the problematic operations
model.zip

It looks like the issue doesn't occur in the StringJoin kernel, while it happens on KernelExecutor in ORT. So I think moving this issue to ORT github may get some help more quickly.

Thanks I move it there

@wenbingl can you tag somebody relevant on the ORT issue?

@wenbingl can you tag somebody relevant on the ORT issue?

I believe there is a system to forward the issue to a corresponding team alias, please stay tuned.


Fix typo in C and Golang API

Fix type recieve -> receive in C and Golang APIs.

I can't "approve", but I approve this :D


Assertion 'label_p->continue_tgt_oc != MAX_OPCODES' failed in jsp_label_rewrite_jumps_and_pop

Jerry version:
Checked revision: 9b24d8f
Build: debug.linux

OS:
Ubuntu 15.04, x86_64

Test case:
label_0:
    if (false)
        do  {
            continue label_0;
        } while (false);

Backtrace:
ICE: Assertion 'label_p->continue_tgt_oc != MAX_OPCODES' failed at jerryscript/jerry-core/parser/js/jsp-label.cpp(jsp_label_rewrite_jumps_and_pop):125.
Error: ERR_FAILED_INTERNAL_ASSERTION

Program received signal SIGABRT, Aborted.
0x0000000000499ae6 in syscall_2_asm () at jerryscript/jerry-libc/target/linux/jerry-asm.S:32
32    SYSCALL_2
(gdb) bt
# 0  0x0000000000499ae6 in syscall_2_asm () at jerryscript/jerry-libc/target/linux/jerry-asm.S:32
# 1  0x00000000004003c2 in syscall_2 (syscall_no=62, arg1=9091, arg2=6) at jerryscript/jerry-libc/target/linux/jerry-libc-target.c:96
# 2  0x0000000000400563 in abort () at jerryscript/jerry-libc/target/linux/jerry-libc-target.c:175
# 3  0x000000000044242f in jerry_fatal (code=ERR_FAILED_INTERNAL_ASSERTION) at jerryscript/jerry-core/jrt/jrt-fatals.cpp:65
# 4  0x000000000044247e in jerry_assert_fail (assertion=0x4a6350 "label_p->continue_tgt_oc != MAX_OPCODES",
    file=0x4a6210 "jerryscript/jerry-core/parser/js/jsp-label.cpp",
    function=0x4a1560 <_ZZ31jsp_label_rewrite_jumps_and_popP11jsp_label_ttE8__func__.lto_priv.303> "jsp_label_rewrite_jumps_and_pop", line=125)
    at jerryscript/jerry-core/jrt/jrt-fatals.cpp:92
# 5  0x000000000041c6cf in jsp_label_rewrite_jumps_and_pop (label_p=0x7fffffffd3d0, break_tgt_oc=7)
    at jerryscript/jerry-core/parser/js/jsp-label.cpp:125
# 6  0x000000000044a7df in parse_statement (outermost_stmt_label_p=0x0) at jerryscript/jerry-core/parser/js/parser.cpp:2795
# 7  0x000000000044a88e in parse_source_element () at jerryscript/jerry-core/parser/js/parser.cpp:2835
# 8  0x000000000044ad2f in parse_source_element_list(bool) [clone .lto_priv.560] (is_global=true)
    at jerryscript/jerry-core/parser/js/parser.cpp:3074
# 9  0x000000000044aec3 in parser_parse_program (
    source_p=0x6cb780 <_ZL13source_buffer.lto_priv.1117> "label_0: \n    if (false)\n        do  {\n", ' ' <repeats 12 times>, "continue label_0;\n        } while (false);", source_size=93, in_function=false, in_eval=false, is_strict=false, out_opcodes_p=0x7fffffffd620)
    at jerryscript/jerry-core/parser/js/parser.cpp:3134
# 10 0x000000000044b042 in parser_parse_script (
    source=0x6cb780 <_ZL13source_buffer.lto_priv.1117> "label_0: \n    if (false)\n        do  {\n", ' ' <repeats 12 times>, "continue label_0;\n        } while (false);", source_size=93, opcodes_p=0x7fffffffd620) at jerryscript/jerry-core/parser/js/parser.cpp:3203
# 11 0x00000000004991f6 in jerry_parse (
    source_p=0x6cb780 <_ZL13source_buffer.lto_priv.1117> "label_0: \n    if (false)\n        do  {\n", ' ' <repeats 12 times>, "continue label_0;\n        } while (false);", source_size=93) at jerryscript/jerry-core/jerry.cpp:1341
# 12 0x0000000000497e03 in main (argc=3, argv=0x7fffffffd8c8) at jerryscript/main-linux.cpp:285

Same on master (f17f785b6ec0c71c2ef37e4e80a98aff1eff0963)

New testcase:
u:L: continue u:

@renatahodovan, what is the expected result?
On current master (91a0514) fails with the following:
PARSE_ERROR: Labelled statement targeted by a continue noty found. (line: 1, column: 15)

This is a fuzzer-generated test. Its only expected result is not to fail with an assert.

Works on current master (91a0514).


Add a joystick_button action.

I took the liberty of adding thumbstick clicking to the default actions and interactions since the configurable actions may take a while. :)
I chose button index 14 by referring to the JoystickList enum:
JOY_VR_PAD = 14 --- Push down on the touchpad or main joystick on a VR controller.
I'm not entirely sure it's the correct index, since the valve knuckles has a pad and main joystick, so which should use that index really?
I would not object if you'd like another button index instead!

Looks good, make sure to update the demo/addons/godot-openxr/CHANGES.md file and add your name to CONTRIBUTORS.md and I'll merge it

@BastiaanOlij Cool! All done :)

Thanks!


make PrivateKey + Signature comparisons use constant time comparisons

Fixes https://github.com/tendermint/go-crypto/issues/43
Avoid susceptibility to timing/side channel attacks by ensuring
that private key and signature comparisons use
subtle.ConstantTimeCompare
instead of
bytes.Equal

Does it matter for signatures? And where do we even use privKey.Equals ?

@ebuchman, yeah for signatures I infer that from the case that those are like authenticated messages, but I perhaps am wrong that it doesn't matter.
In regards to where we use PrivKey.Equals, interestingly I don't seem to see usages in our repos.
If the usage/correctness doesn't matter, then perhaps we should delete those otherwise it is something that will get the ears of any auditor burning. I found this by isolating package by package and reading through to ensure just sort of correctness of the code.

Hm, seems maybe we can eliminate both Equals ? I see no reason to ever be checking privkey equality like that, and same for signatures? Are we using that anywhere?

status?

Replaced by https://github.com/tendermint/go-crypto/pull/53/files

@odeke-em note subtle uses 1 to denote equality.
Also, is there some reason the signatures need to be checked in constant time?

Thank you @ebuchman for the refurbish! Mother of God, why did I use 0 instead? Moreover I was somewhat involved in reviewing the original Go package signature IIRC, how could I not catch that.

oh cool - agl doesn't think verify should be in constant time either: https://github.com/golang/crypto/commit/c412588e259ef2d488e15762500456cd3b171bad#diff-8183aa2c95dc1385c8f58bf1917fcb0b

Gotcha gotcha, thanks for the discussion and you called this about signatures not needing constant time comparisons.


Fix job campaign in CMSMonitoring

Impact of the new feature
We need to propagate the job campaign in the CMS monitoring, preferentially as a new classad.
Is your feature request related to a problem? Please describe.
Job campaign needs to be propagated for CMS monitoring
Describe the solution you'd like
Create a classad with the job campaign name. However, we don't seem to propagate this information in the job pickle, meaning the agent does not have this information as of now. We need to implement this feature at the job packet level before we can create the classad.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
This was meant to be implemented for the agent cycle (July 11-15), but it will have to be postponed, since we don't have this information easily accesible in the agent at this point.

@amaltaro Here is the ticket for this issue, please feel free to correct/expand as needed.

Thanks for creating this issue, @khurtado .
I just wanted to complement that:
a) we need to set the job campaign at the job creation level (pickled job description)
b) consume the job campaign information at the JobSubmitter component (and SimpleCondorPlugin)
c) define the new job classad (perhaps CMS_Campaign).
We will have to discuss with CMS / CMS Monitoring on how to deal with StepChain workflows, because those jobs are for most of the cases multi-campaign, so we will likely create a comma separated list of campaigns and someone will have to define how to consume this information in monitoring.
Kenyi, I would suggest to rename this issue though to something like "Provide campaign name in the job classad". The actual fix will then be on the HTCondor job monitoring.

@amaltaro I knew I was forgetting something important (stepChain comment), thank you, Alan!

Kenyi, I just noticed this is also a duplication of https://github.com/dmwm/WMCore/issues/10914, sorry about that! I am closing this one as not planned as well, and will add 10914 to the Q3/2023 project board.


[Tidy] Tidy with mode --recursive does not work

Environment:

Robot Framework 3.1.2
Mac OS 10.13.6
Python 2.7.10

I'm now using robot.tidy tool to apply the new FOR loop syntax for my project
Tidy still works properly with the normal mode
python -m robot.tidy --inplace keyword_sample.robot
But python -m robot.tidy --recursive <project_folder> does not work at all. Nothing happens after executing this command
Please help to take a look.
Thank you!

Works for me.

Works for me. Can you test again? If it still fails, you'd need to provide some more information.

I think I could reproduce this one.
I tried mode --recursive with robot file containing Test Cases -> it works normally
I tried mode --recursive with robot file only containing Keywords or Variable -> nothing happens

I think that's a known limitation/bug occurring also with earlier versions.

Yeah, this is a known issue. One problem with processing resource files has been that if you were changing format, also imports would have need to be updated like resource.html -> resource.robot. Now that we will only support the plain text format in RF 3.2, that problem isn't anymore relevant. Another problem is that resource imports can lead to files outside the directory given as an argument to Tidy and it's a bit questionable is that fine or not. Separate command line option could be added to control the behavior if needed, though, and it could perhaps be used also when tidying a single file.
Things we can do:

Document that --recursive doesn't process resource files. I changed the title of this issue to cover that.

Actually add the functionality to process resource files. Separate issue should be submitted about it.


[Snyk] Security upgrade python from 3.7.10-slim-buster to 3.9.14-slim-buster

This PR was automatically created by Snyk using the credentials of a real user.Keeping your Docker base image up-to-date means you’ll benefit from security fixes in the latest version of your chosen image.
Changes included in this PR

Dockerfile

We recommend upgrading to python:3.9.14-slim-buster, as this image has only 86 known vulnerabilities. To do this, merge this pull request, then verify your application still works as expected.
Some of the most important vulnerabilities in your base image include:

Severity
Priority Score / 1000
Issue
Exploit Maturity

714
Directory Traversal SNYK-DEBIAN10-DPKG-2847944
No Known Exploit

714
Buffer Overflow SNYK-DEBIAN10-OPENSSL-1569403
No Known Exploit

614
Loop with Unreachable Exit Condition ('Infinite Loop') SNYK-DEBIAN10-OPENSSL-2426310
No Known Exploit

714
OS Command Injection SNYK-DEBIAN10-OPENSSL-2807585
No Known Exploit

714
OS Command Injection SNYK-DEBIAN10-OPENSSL-2933515
No Known Exploit

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
🛠 Adjust project settings

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


feat: improve configuration of concurrent yurtappdaemon workers (#1912)

What type of PR is this?

/kind good-first-issue
/kind feature

What this PR does / why we need it:
improve the configuration of concurrent yurtappdaemon workers in yurt-manager component
Which issue(s) this PR fixes:

Fixes #1912

/rerun

/rerun

/lgtm


AzureSpringCloud service tag does not exist

AzureSpringCloud service tag does not exist

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: d79e04c4-055b-826e-05ec-7edefe441cc5
Version Independent ID: d4043afa-2e04-8700-3ffc-0465340ea8e5
Content: Security controls for Azure Spring Apps Service
Content Source: articles/spring-apps/concept-security-controls.md
Service: spring-apps
GitHub Login: @KarlErickson
Microsoft Alias: karler

@ULSam
Thanks for your feedback! We will investigate and update as appropriate.

Done.

@KarlErickson please help to close this issue.

#please-close


Added missing class

mdl-layout--fixed-header is missing from the mdl-layout container div

Can you please send this patch into mdl-1.1 so the fix will be pushed in the next release?
master is currently V2 work which won't ship for a while and the docs are going to be completely redone before release.
Thank you.


break timer shouldn't hide tabs

Is your feature request related to a problem? Please describe.
I like to tweak configs and check how many tasks are left. It may happen during break time, even though it sounds stupid, the app shouldn't control when I can do these things.

What do you mean by that. Can you elaborate it?

I was not aware of fullscreen break timer.


docs: update theme 1.7

Related issue https://github.com/scylladb/sphinx-scylladb-theme/issues/1035
ScyllaDB Sphinx Theme 1.7 is out 🥳 Now, the docs will automatically publish when backporting changes to previous branches. This release also introduces minor style enhancements to the sidebar and homepage.
You can read more about all notable changes here.
How to test this PR

Clone this PR. For more information, see Cloning pull requests locally.

Enter the docs folder, and run:
make preview

Open http://localhost:5500 with your favorite browser. The doc should render without errors, and the version should be Sphinx Theme version (see the footer) must be 1.7.x:

cc/ @annastuchlik

Having installed poetry using dnf:
sudo dnf install poetry
and run make preview, I got an error:
Writing lock file
poetry update
Updating dependencies
Resolving dependencies... (1.3s)

No dependencies to install or update
cp -TLr source _source
python _utils/prepare_sphinx_source.py _source
Preparing sphinx source in _source
OK Done - prepared sphinx source is in _source
poetry run sphinx-autobuild -b dirhtml -d _build/doctrees  -j auto _source _build/dirhtml --port 5500
[sphinx-autobuild] > sphinx-build -b dirhtml -d _build/doctrees -j auto /home/wojciech/Repos/rust-driver-playground/docs/_source /home/wojciech/Repos/rust-driver-playground/docs/_build/dirhtml
Running Sphinx v7.2.6
/home/wojciech/.cache/pypoetry/virtualenvs/sphinx-docs-B6yYV2vv-py3.12/lib/python3.12/site-packages/sphinx_scylladb_theme/lexers/cql.py:236: SyntaxWarning: invalid escape sequence '\s'
  r"(" + "|".join(s.replace(" ", "\s+") for s in DATATYPES) + r")\b",

Extension error:
Could not import extension sphinx_multiversion (exception: No module named 'distutils')
Command exited with exit code: 2
The server will continue serving the build folder, but the contents being served are no longer in sync with the documentation sources. Please fix the cause of the error above or press Ctrl+C to stop the server.
[I 240514 07:51:51 server:335] Serving on http://<IP_ADDRESS>:5500

Having installed poetry using dnf: sudo dnf install poetry and run make preview, I got an error:
Writing lock file
poetry update
Updating dependencies
Resolving dependencies... (1.3s)

No dependencies to install or update
cp -TLr source _source
python _utils/prepare_sphinx_source.py _source
Preparing sphinx source in _source
OK Done - prepared sphinx source is in _source
poetry run sphinx-autobuild -b dirhtml -d _build/doctrees  -j auto _source _build/dirhtml --port 5500
[sphinx-autobuild] > sphinx-build -b dirhtml -d _build/doctrees -j auto /home/wojciech/Repos/rust-driver-playground/docs/_source /home/wojciech/Repos/rust-driver-playground/docs/_build/dirhtml
Running Sphinx v7.2.6
/home/wojciech/.cache/pypoetry/virtualenvs/sphinx-docs-B6yYV2vv-py3.12/lib/python3.12/site-packages/sphinx_scylladb_theme/lexers/cql.py:236: SyntaxWarning: invalid escape sequence '\s'
  r"(" + "|".join(s.replace(" ", "\s+") for s in DATATYPES) + r")\b",

Extension error:
Could not import extension sphinx_multiversion (exception: No module named 'distutils')
Command exited with exit code: 2
The server will continue serving the build folder, but the contents being served are no longer in sync with the documentation sources. Please fix the cause of the error above or press Ctrl+C to stop the server.
[I 240514 07:51:51 server:335] Serving on http://<IP_ADDRESS>:5500

I think you need to use older python (3.10 should work). Easiest way to do so would be using pyenv.
With that being said, imo the docs should always support python installed in latest stable fedora - otherwise it adds unnecessary friction for developers.

The docs are compatible with Python 3.10. It's in our plans to make them compatible with Python 3.12 , but this is not part of the current release.
cc/ @annastuchlik


Uniform sphere API

I've introduced a new API for loading SphereRDD (similar to Point3DRDD). It is much simpler now, as there is only one single command:
import com.spark3d.spatial3DRDD.SphereRDD
// load CSV/JSON/TXT
val spheres = new SphereRDD(SparkSession, filename, columnames, isSpherical)
// load FITS
val spheres = new SphereRDD(SparkSession, filename, HDU, columnames, isSpherical)

I've also added support for JSON and TXT files.
All the messy stuff is now hidden in the Loader object, and the Sphere3D has just overloaded constructors.
Next steps (another PR):

Do the same for shell, sphere, box.
Add support for HDF5 and ROOT

Codecov Report

Merging #64 into master will decrease coverage by 0.12%.
The diff coverage is 96.42%.

@@            Coverage Diff             @@
##           master      #64      +/-   ##
==========================================
- Coverage   98.63%   98.51%   -0.13%
==========================================
  Files          22       22
  Lines         731      739       +8
  Branches      201      206       +5
==========================================
+ Hits          721      728       +7
- Misses         10       11       +1

Impacted Files
Coverage Δ

...in/scala/com/spark3d/spatial3DRDD/Point3DRDD.scala
83.33% <ø> (ø)
:arrow_up:

...c/main/scala/com/spark3d/spatial3DRDD/Loader.scala
100% <100%> (ø)
:arrow_up:

...ain/scala/com/spark3d/spatial3DRDD/SphereRDD.scala
83.33% <83.33%> (-16.67%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf348e4...9f2932e. Read the comment docs.


dev: add auto commit gen

Current dependencies on/for this PR:

main

PR #744   👈

This stack of pull requests is managed by Graphite.


Do not apply Egress to traffic destined for ServiceCIDRs

When AntreaProxy is asked to skip some Services or is not running at all, Pod-to-Service traffic would be forwarded to Egress Node and be load-balanced remotely, as opposed to locally, which could incur performance issue and unexpected behaviors.
This patch installs flows to prevent traffic destined for ServiceCIDRs from being SNAT'd.
Fixes #5494

/test-all
/test-ipv6-all
/test-ipv6-only-all

However, I wonder if instead, we should install flows for skipServices to the AntreaProxy LB table in OVS, and send the packets directly to the host network (same behavior as when AntreaProxy is disabled). This would avoid adding Service flows to the SNAT table. I am being a bit vague here, since I am not super familiar with the current version of the pipeline. This approach may not make sense or be possible.

Thanks for the comment. I thought it over, and tend to keep the current approach for a few reasons, please let me know whether they make sense to you or not:

skipServices is not the only case that can bypass AntreaProxy, services with service.kubernetes.io/service-proxy-name label can also bypass it, we would need to consider both. Excluding all ServiceCIDRs from Egress may be simpler to cover all cases regardless of how AntreaProxy is configured and whether it runs.
We have used the way of exception for Node IPs and user configured exceptCIDRs, it may be easier to understand to keep them in the same place.
Bypassing most stages for specific traffic flows generally adds complexity, needing careful consideration and could cause some problems. For example, it would be impossible to enforce Egress NetworkPolicy or enable logging for Services skipped via skipServices config, service-proxy-name label.
I'm even thinking if it really makes sense to have the current behavior of disabled AntreaProxy. It has several problems: in noEncap/policyOnly mode, Egress NetworkPolicy is not enforced when the Pod accesses ANY destination via Service; in encap mode, Egress NetworkPolicy is not enforced when the Pod accesses external destination/hostNetwork Pod (e.g. kube-apiserver) via Service. If we change to make it go over the pipeline, at least user could configure the service IP or leverage toService peer to enforce Egress NetworkPolicy, though it would be an extra configuration compared with enabled AntreaProxy. We can document it clearly: when AntreaProxy is not enabled or a Service is skipped by AntreaProxy, the Egress rule should use Service-oriented peer instead of Endpoint-oriented peer for Pod-to-Service traffic.

@tnqn thanks for thinking it over, it makes sense to me. If we ever need to exclude more Service traffic for features in the future, maybe it will make sense at that point to consider a classifier and register mark early in the pipeline

Yes, makes sense.

/test-e2e

/test-e2e


Array definitions and references that do not parse

Definitions in DEFINE DATA:
ARR (IX:IX+1) (with or without whitespace before the operator +)
References
ARR(IX.1) (note period, not colon and also multiple dimensions)
ARR(1.IX)
ARR(IX.IY)
I will add more as the pop up.

Covered by #346


feat(#795): remove Testable and its usages

In this pull I've removed org.eolang.jeo.representation.bytecode.Testable.java and its usages in order to get rid of generated code examples in logs.
closes #795
History:

feat(#795): Testable off
feat(#795): clean for qulice

PR-Codex overview
This PR focuses on removing the testCode method from several classes that implement the Testable interface and simplifying some constructors by removing unnecessary parameters.
Detailed summary

Deleted the testCode method from BytecodeTryCatchBlock, BytecodeMethodProperties, BytecodeFrame, BytecodeLabel, BytecodeMethod, and BytecodeClass.
Simplified constructors in Stack and BytecodeLabel by removing the AllLabels parameter.
Updated the BytecodeMethod and BytecodeClass to remove testCode implementations.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@volodya-lombrozo take a look, please

@rultor merge

@rultor merge

@volodya-lombrozo OK, I'll try to merge now. You can check the progress of the merge here.

@rultor merge

@volodya-lombrozo Done! FYI, the full log is here (took me 9min).


How is graphics handled?

How will graphics be handled?
Because the drivers for graphics cards are written per-OS.

There is a standard called VESA. For that, see http://wiki.osdev.org/VESA_Video_Modes
You can also set a VGA mode in the bootloader or in protected mode, and use that. You could just write drivers for each specific graphics card


add region growing algorithm

This PR adds the region-growing algorithm to DSWx-SAR.
The region-growing algorithm takes the fuzzy-value Geotiff and produces the intermediate binary water map, region_growing_output_binary_VV_VH.tif.

@LiangJYu Thank you for the comments. I revised the PR based on your comments.

@LiangJYu Thank you for your great comments and corrections. I just finished the modification. Would you be able to have another look?

@LiangJYu Thank you for your suggestions. I just removed 'water' from the variable names. likelihood_image seems reasonable to me. If you don't have additional comments on this PR, may I merge it?
https://github.com/opera-adt/DSWX-SAR/pull/13#discussion_r1308168866


[VS Code] Could not join the collaboration session as it has already reached the maximum of 5 participants.

<!--
For Visual Studio problems/feedback, please use the Report

Closing as a duplicate of #1207


Navboxes at bottom of page lack any styling, making them difficult to read

Navboxes (at bottom of page, not the vertical navboxes found on the top of some pages) have no special styling when viewing them in WikiWash, making larger ones very difficult to read.
A great example is the navbox at the bottom of http://en.wikiwash.org/Spider-Man/706363838-706357374#External_links

/cc @irfanpirbhai


AreaDetector Statistics for multiple image per point with N filter

There are two separate issues:

[ ] N filter buffer is not cleared prior to a new scan.  This affects the statistics if the N filter is enabled.

[ ] The filter should be automatically enabled by the software when using the AreaDetector with a motor scan with N filter = num_images.  There should be a discussion on how to handle ct() with num_images > 1.  The user may or may not want this enabled. Most likely, the user will want N filter disabled in the case where num_images is large.

I discussed with @stuwilkins how this should be done. What is the relevant PV?

XF:23ID1-ES{FCCD}Proc1:NumFilter_RBV
is the Filter N Images
XF:23ID1-ES{FCCD}Proc1:EnableFilter
enables / disables the filter
the type of filter is configurable deeper in the area detector screen.  is this something we want to make configurable through bluesky not.

All of the processing plugin options are configurable through ophyd. See: https://github.com/NSLS-II/ophyd/blob/master/ophyd/areadetector/plugins.py#L411 for example

We probably should install a dev version of ophyd if you want to use this (to capture all of the AD configuration + the blocking callback stuff).

@danielballan If we make this change, how will that be affected by the slow detector fix you implemented so we can ^C the fast ccd scans? Does the final fix make it easy to switch between the slow and normal mode?
@cmazzoli @stuwilkins preferences?


feat: Add difference and intersect  BigQuery classes

feat: Should change the default compile SQL from INTERSECT to INTERSECT DISTINCT and same for EXCEPT
Closes #87

I still don't know what would be a easy way to play around with this locally? Do you have a notebook or so you're using when developing ?

@tswast is there a changelog or something I should  update? Also should I add tests for this?

@tswast is there a changelog or something I should update?

Release-Please should see the feat:  in the PR / commit and send a PR to update the changelog as part of the next release.

Also should I add tests for this?

Yes, please. :-) I'd at least like to see unit tests in https://github.com/ibis-project/ibis-bigquery/blob/main/tests/unit/test_compiler.py that check if the expected SQL is generated when used.

Ok I added the test. For some reason I can't run the tests locally, getting a AttributeError: module 'sqlalchemy' has no attribute 'Binary'.
Do we need to lock the sqlalchemy version?
I created the ibis-bigquery-dev env and it seems to have installed:
sqlalchemy                1.4.20           py38h96a0964_0    conda-forge

Ok seems like it's still not working. If you could help me out with running the tests locally, I'll figure out why it's not using the  difference_class etc.

@tswast I downgraded SQLalchemy to 1.3.23 now the previous error disappeared but I still can't run the tests. This time it fails with AttributeError: module 'ibis.sql.compiler' has no attribute 'Intersection' but again in CI it seems to work any idea what's different between the versions?

AttributeError: module 'sqlalchemy' has no attribute 'Binary'

This is a know issue in Ibis (not really their fault, as SQLAlchemy made breaking changes in 1.4). I believe it has been fixed in https://github.com/ibis-project/ibis/pull/2690

AttributeError: module 'ibis.sql.compiler' has no attribute 'Intersection'

Hmmm... I don't see how your change would have caused this. Ibis has been doing a ton of refactoring, so we probably need to adjust some imports and add fallbacks for older versions.

Ok so the error probably happens independently from the version because Ibis isnt exporting the classes in https://github.com/ibis-project/ibis/blob/master/ibis/backends/base/sql/compiler/init.py
I will include that in another PR there but another problem is that I can't find the Intersection class in 1.3.

Thanks for jumping on this! I think it'd be easier to close this and create a new PR once ibis-project/ibis#4006 is done?

Thanks for jumping on this! I think it'd be easier to close this and create a new PR once https://github.com/ibis-project/ibis/pull/4006 is done?

I suspect we might be able to use this PR once #4006 is done. Right now I'm getting some failed unit tests when I use my patch, so it's been helpful in development of that PR.


Hot Module Reloading Config?

Question about Next.js
So I am using next 5.1.X, looking to upgrade to 6 soon. However are there any current or old docs about configuring the HMR? I am trying to find out what is triggering my HMR since it seems to rebuild my bundle at random times and I cannot find any docs on it. Is there an way to check what triggers the bundle rebuild? A debug mode? A default reload timeout? Any ideas would be great!

Should be fixed in Next 6 or next@canary. It was caused by on-demand-entries removing an active page. Also please follow the issue template. The template you chose clearly states questions shouldn't be posted here.
Template:
# Question about Next.js

Questions should be posted on https://spectrum.chat/next-js


[FX-574] Fix height and width attributes

What

Revert #92

Why
https://linear.app/joinforage/issue/FX-574/ios-fix-height-and-width-attributes

Test Plan

[ ] Check if default size did not regress
[ ] Check if custom parent view sizing works

How

Current dependencies on/for this PR:

main

PR #113   👈

This comment was auto-generated by Graphite.


Added checks to make sure app configs are correct

when they are loaded, so that things fail faster if there
is a config error

Looks good now.

fixes #539


issue with storing extra_info in Chroma #811

@jerryjliu please run the build one more time, some lint issues, hope they are fixed now


Missing Spa Locked from controls

Hi,
I have issues with the Spa Locked feature. At the moment it is not available in the controls. I just updated now to the latest version (v1.5.0) of the Bestway integration and the feature just dissapeared.

Could you help me in this issue? Maybe it is my fault that I'm not able to see this option. What should I change or turn on to be able to use this?
Thank you very much.
Have a nice day!
Regards,
Sanyi

Are you able to downgrade to get it working again? If so, what's the last version you can see it working in?
If it's previously been there, it's perhaps just an oversight in some recent restructuring.

Are you able to downgrade to get it working again? If so, what's the last version you can see it working in?
If it's previously been there, it's perhaps just an oversight in some recent restructuring.

Unfortunatelly I do not know how can I downgrade it. If you can help me in it I can try.
Previously it was there and it was a really useful function because of the kid, I was able to unlock it from remotely.

It should be doable via the UI. HACS -> Integrations > Bestway. Then click the ... menu in the top right -> Redownload, and select a version to try.

It should be doable via the UI. HACS -> Integrations > Bestway. Then click the ... menu in the top right -> Redownload, and select a version to try.

The Bestway is not visible for me in HACS -> Integrations > Bestway, but the integration is installed and working at the moment. Because of this issue I'm not able to redownload an older version

I have a similar issue where i lose the thermostat controls. Rolling back to 1.3.1 fixes the issue for me.

In the meanwhile I was able to try severeal older version but for me in all version have the same issue. But I noticed an other issue. When I turn on the bubbles I am able to change the intesity of the bubbles but I can not turn it off.

Having just gone through a few older versions, Airjet_V01 has never had support for the lock button. Plain old "Airjet" devices do, which suggests perhaps the device itself has updated and is providing a different API. If you can provide debug logs while manually controlling the lock switch with a minute gap between each change, that might enable support to be added.
@mjtilford if there are also problems with thermostat settings, please raise another issue to describe exactly what's going on there.

Closing due to inactivity. Unable to assist without debug logs.


Create resume template

Create page template for resume based on previous Jekyll-based resume.

Completed in #156


Create Transition from zprood's cycle count hack.md

RehabMan's ACPIBatteryManager supported a so-called @zprood's _BIF extension technique for providing cycle count. This technique was used to add cycle count into _BIF if it existed in some EC registers, but wasn't visible because the battery device only implemented _BIF method, but not ACPI 4.0 _BIX. Extending the _BIF return package doesn't conform to the ACPI specification and should be avoided. It's not supported by SMCBatteryManager. Instead, a proper _BIX implementation should be provided. Here I'll show an example of such transformation for @kecinzer's HP laptop, based on his SSDT.
The original code with comments (I'll show everything for BAT0 device, it's the same for BAT1):
Name (NBTI, Package(0x02)
{
    Package(0x0F)
    {
        0x01,
        0xFFFFFFFF,
        0xFFFFFFFF,
        0x01,
        0xFFFFFFFF,
        0x00,
        0x00,
        0x64,
        0x64,
        "Primary",
        "100000",
        "LIon",
        "Hewlett-Packard",
        Zero, // extension for cycle count
        Zero, // extension for temperature
    },
    Package (0x0F) { /* the same package for the second battery is not shown */ }
})

Method (BTIF, 1, Serialized) // it's _SB.BTIF
{
    Local0 = ^PCI0.LPCB.EC.BTIF (Arg0)
    If ((Local0 == 0xFF))
    {
        Return (Package (0x0D)
        {
            Zero,
            0xFFFFFFFF,
            0xFFFFFFFF,
            One,
            0xFFFFFFFF,
            Zero,
            Zero,
            Zero,
            Zero,
            "",
            "",
            "",
            Zero
        })
    }
    Else
    {
        Return (DerefOf (NBTI [Arg0]))
    }
}

Device (BAT0)
{
    /* other methods are not shown */
    Method (_BIF, 0, NotSerialized)  // _BIF: Battery Information
    {
        Return (BTIF (Zero))
    }
}

Method (BTIF, 1, Serialized) // it's EC.BTIF
{
    ShiftLeft (One, Arg0, Local7)
    BTDR (One)
    If (LEqual (BSTA (Local7), 0x0F))
    {
        Return (0xFF)
    }

    Acquire (BTMX, 0xFFFF)
    Store (NGBF, Local0)
    Release (BTMX)
    If (LEqual (And (Local0, Local7), Zero))
    {
        Return (Zero)
    }

    Store (NDBS, Index (NBST, Arg0))
    Acquire (BTMX, 0xFFFF)
    Or (NGBT, Local7, NGBT)
    Release (BTMX)
    Acquire (ECMX, 0xFFFF)
    If (ECRG)
    {
        Store (Arg0, BSEL) // Battery index for dual-battery laptops

        // Battery Full Capacity (last full charge capacity)
        // It's either HP's mistake or intentional lie –
        // they are putting last full charge capacity
        // in both Last Full Charge Capacity and
        // Design Capacity field.
        // I'll correct it below.
        Store (B1B2 (BFC0, BFC1), Local0)
        Store (Local0, Index (DerefOf (Index (NBTI, Arg0)), One)) // Design Capacity
        Store (Local0, Index (DerefOf (Index (NBTI, Arg0)), 0x02)) // Last Full Charge Capacity
        Store (B1B2 (BDV0, BDV1), Index (DerefOf (Index (NBTI, Arg0)), 0x04)) // Design Voltage
        Multiply (B1B2 (BFC0, BFC1), NLB1, Local0)
        Divide (Local0, 0x64, /*Local3*/, Local4)
        Store (Local4, Index (DerefOf (Index (NBTI, Arg0)), 0x05)) // Design Capacity of Warning
        Multiply (B1B2 (BFC0, BFC1), NLO2, Local0)
        Divide (Local0, 0x64, /*Local3*/, Local4)
        Store (Local4, Index (DerefOf (Index (NBTI, Arg0)), 0x06)) // Design Capacity of Low
        Store (B1B2 (BSN0, BSN1), Local0)
        Store (B1B2 (BDA0, BDA1), Local1)
        // Battery Cycle Count – this is zprood's extension,
        // look that index is 0x0D, which is not allowed for _BIF
        Store (B1B2 (BCC0, BCC1), Index (DerefOf (Index (NBTI, Arg0)), 0x0D))
        // RehabMan's extension, temperature should not be provided here
        Acquire (\_SB.PCI0.LPCB.EC.ECMX, 0xFFFF)
        Store (5, \_SB.PCI0.LPCB.EC.CRZN)
        Store (\_SB.PCI0.LPCB.EC.TEMP, Local2)
        Release (\_SB.PCI0.LPCB.EC.ECMX)
        Add (Multiply (Local2, 10), 2732, Local2) // Celsius to .1K
        Store (Local2, Index (DerefOf (Index (NBTI, Arg0)), 0x0E))
    }

    Release (ECMX)
    Store (GBSS (Local0, Local1), Local2)
    Store (Local2, Index (DerefOf (Index (NBTI, Arg0)), 0x0A))
    Acquire (BTMX, 0xFFFF)
    And (NGBF, Not (Local7), NGBF)
    Release (BTMX)
    Return (Zero)
}

First let's remove the extra fields from _BIF (and fix HP bug):
Name (NBTI, Package(0x02)
{
    Package(0x0D) // change package length back to 0x0D
    {
        0x01,
        0xFFFFFFFF,
        0xFFFFFFFF,
        0x01,
        0xFFFFFFFF,
        0x00,
        0x00,
        0x64,
        0x64,
        "Primary",
        "100000",
        "LIon",
        "Hewlett-Packard",
        // extra fields are removed
    },
    Package (0x0F) { /* the same package for the second battery is not shown */ }
})

Method (BTIF, 1, Serialized) // it's EC.BTIF
{
    ShiftLeft (One, Arg0, Local7)
    BTDR (One)
    If (LEqual (BSTA (Local7), 0x0F))
    {
        Return (0xFF)
    }

    Acquire (BTMX, 0xFFFF)
    Store (NGBF, Local0)
    Release (BTMX)
    If (LEqual (And (Local0, Local7), Zero))
    {
        Return (Zero)
    }

    Store (NDBS, Index (NBST, Arg0))
    Acquire (BTMX, 0xFFFF)
    Or (NGBT, Local7, NGBT)
    Release (BTMX)
    Acquire (ECMX, 0xFFFF)
    If (ECRG)
    {
        Store (Arg0, BSEL)

        Store (B1B2 (BDC0, BDC1), Local0) // Fix for HP's bug – put Designed Capacity here
        Store (Local0, Index (DerefOf (Index (NBTI, Arg0)), One)) // Design Capacity
        Store (B1B2 (BFC0, BFC1), Local0)
        Store (Local0, Index (DerefOf (Index (NBTI, Arg0)), 0x02)) // Last Full Charge Capacity
        Store (B1B2 (BDV0, BDV1), Index (DerefOf (Index (NBTI, Arg0)), 0x04)) // Design Voltage
        Multiply (B1B2 (BFC0, BFC1), NLB1, Local0)
        Divide (Local0, 0x64, /*Local3*/, Local4)
        Store (Local4, Index (DerefOf (Index (NBTI, Arg0)), 0x05)) // Design Capacity of Warning
        Multiply (B1B2 (BFC0, BFC1), NLO2, Local0)
        Divide (Local0, 0x64, /*Local3*/, Local4)
        Store (Local4, Index (DerefOf (Index (NBTI, Arg0)), 0x06)) // Design Capacity of Low
        Store (B1B2 (BSN0, BSN1), Local0)
        Store (B1B2 (BDA0, BDA1), Local1)
    }

    Release (ECMX)
    Store (GBSS (Local0, Local1), Local2)
    Store (Local2, Index (DerefOf (Index (NBTI, Arg0)), 0x0A))
    Acquire (BTMX, 0xFFFF)
    And (NGBF, Not (Local7), NGBF)
    Release (BTMX)
    Return (Zero)
}

I'm writing it here and then will move into a file.

Then implement _BIX method:
Scope(\_SB.BAT0)
{
    Method (_BIX, 0, NotSerialized)
    {
        Return (BTIX (Zero))
    }
}

Scope (\_SB)
{
    Method (BTIX, 1, Serialized)
    {
        Local0 = ^PCI0.LPCB.EC.BTIX (Arg0)
        If ((Local0 == 0xFF))
        {
            Return (Package (0x15)
            {
                One, // Revision
                Zero,
                0xFFFFFFFF,
                0xFFFFFFFF,
                One,
                0xFFFFFFFF,
                Zero,
                Zero,
                0xFFFFFFFF,
                100000,
                0xFFFFFFFF,
                0xFFFFFFFF,
                0xFFFFFFFF,
                0xFFFFFFFF,
                Zero,
                Zero,
                "",
                "",
                "",
                Zero,
                One
            })
        }
        Else
        {
            Return (DerefOf (NBIX [Arg0]))
        }
    }

    Name (NBIX, Package(0x02)
    {
        Package(0x15)
        {
            0x01,
            0x01,
            0xFFFFFFFF,
            0xFFFFFFFF,
            0x01,
            0xFFFFFFFF,
            0x00,
            0x00,
            0x00,
            100000,
            0xFFFFFFFF,
            0xFFFFFFFF,
            0xFFFFFFFF,
            0xFFFFFFFF,
            0x64,
            0x64,
            "Primary",
            "100000",
            "LIon",
            "Hewlett-Packard",
            One
        },
        /* the package for the second battery is not shown */
    })
}

Looks good to me, thx!


Stream to ZMQ from databroker

Would it be possible to stream data from the databroker though ZMQ? The current callback requires a RE instance.

I think a PR to make the RE optional would be merged.

Closed by #746.


49-coeffects

Fix #49
Works to be done:

re-organize the namespaces.

Codecov Report
Base: 94.93% // Head: 95.85% // Increases project coverage by +0.92% :tada:

Coverage data is based on head (20f462f) compared to base (861ef19).
Patch coverage: 95.06% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #50      +/-   ##
==========================================
+ Coverage   94.93%   95.85%   +0.92%
==========================================
  Files           7        6       -1
  Lines         375      386      +11
  Branches       11        9       -2
==========================================
+ Hits          356      370      +14
+ Misses          8        7       -1
+ Partials       11        9       -2

Impacted Files
Coverage Δ

src/sg/flybot/pullable/core.cljc
95.88% <94.66%> (+0.81%)
:arrow_up:

src/sg/flybot/pullable.cljc
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Languages/Localization

Is there any translation/localization in lnbits project?
Any roadmap?

There has been discussions about this just recently. @arcbtc @fusion44 sis you come to a conclusion which tools would be most appropriate for localizing LNbits?

I'd use Weblate to translate the actual files.  On the python side there is a nice library called python-i18n. Seems to be easy to implement.

Just stumbled across this library:
https://babel.pocoo.org/en/latest/
Looks like a solid option.

Closed as it's being done in #1608


Refactor error framework

Changes
Classes:

Add ErrorFactory
Add ErrorManagerImpl
Add ErrorManagerReq
Add ErrorStateMonitor
Remove ErrorCommBridge
Remove ErrorManager

Move managment of active errors from global manager to each module.
Change the interface of raising, clearing and subscribing errors.
Requires

https://github.com/EVerest/everest-utils/pull/141
Release v0.1.0 in everest-utils

There should be a version bump in the CMakeLists.txt before merging this :)


feat(source): support extract pk for debezium avro source

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?

support extract pk for debezium avro source

Checklist

[x] I have written necessary rustdoc comments
[x] I have added necessary unit tests and integration tests
~- [ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features).~
~- [ ] I have demonstrated that backward compatibility is not broken by breaking changes and created issues to track deprecated features to be removed in the future. (Please refer to the issue)~
[x] All checks passed in ./risedev check (or alias, ./risedev c)

Documentation

Click here for Documentation
Types of user-facing changes
Please keep the types that apply to your changes, and remove the others.

Connector (sources & sinks)

Release note

User can create a table with debezium avro source without specify pk columns wihch would be extract from kafka key schema.
create table t with (
    connector = 'kafka',
    topic = 'dbserver1.inventory.customers',
    properties.bootstrap.server = '<IP_ADDRESS>:9092',
    scan.startup.mode = 'earliest')
row format debezium_avro
row schema location confluent schema registry 'http://<IP_ADDRESS>:8081';

In some use cases, key schema may be absent in scheme registry or the key may not be in avro format even though dbz is used. Therefore, we should provide the flexibility to user to configure the key format/schema. There are two approaches:

Allow user to define the pk fields in CREATE TABLE, just like what we did before this PR. If pk fields is provided, we will skip looking at the kakfa message key.
Allow user to define the KEY FORMAT and allow it to be different from the ROW FORMAT.

I prefer 1 > 2 since it is simpler to implement and easier to understand for user given that we haven't seen a case that the pk field is missing in the kafka message value.

I also prefer 1 > 2.

I prefer 1 > 2 since it is simpler to implement and easier to understand for user given that we haven't seen a case that the pk field is missing in the kafka message value.

I also prefer 1 > 2.


About optimizer

can index be optimized by multithread？

If your question means whether you can simultaneously optimize multiple indexes with different parameters from a single index by multiple threads, yes you can with multiple instances of “Optimizer”. However, the optimization measures actual search times in a part of the processing. Therefore, when you simultaneously optimize multiple indexes, the parameters of the optimized indexes might not be the best.

I didn't make myself clear. There are 100k data. I covert anng to onng , the graph optimizer spend too much time. So i want to know whether optimiezer could be  accelerated by multithread. And i don't know optimizer still spend a long time  if i only append ten elements to a onng.

The most part of optimizer is processed by multithreads. Optimizer consists of adjusting the incoming and outgoing edges, removing shortcut edges, adjusting search parameters and prefetch parameters. Although I am not sure whether the time is loner than I expect, if so, adjusting search parameters might be slow for 100K objects. This adjustment measures actual search times with a single thread. When the number of objects is not enough or other processes are running on the computer at the same time, the search times fluctuate. As the result, it takes more time to adjust search parameters. 100K objects is a little fewer than I expect.
Optimizer always optimize all of a graph, even if you append only ten objects to a graph. Once you have already built ONNG, optimization after 10 insertions is not effective for search performance.

The most part of optimizer is processed by multithreads. Optimizer consists of adjusting the incoming and outgoing edges, removing shortcut edges, adjusting search parameters and prefetch parameters. Although I am not sure whether the time is loner than I expect, if so, adjusting search parameters might be slow for 100K objects. This adjustment measures actual search times with a single thread. When the number of objects is not enough or other processes are running on the computer at the same time, the search times fluctuate. As the result, it takes more time to adjust search parameters. 100K objects is a little fewer than I expect.
Optimizer always optimize all of a graph, even if you append only ten objects to a graph. Once you have already built ONNG, optimization after 10 insertions is not effective for search performance.

Thanks for your clear explaintation, which also answered the question in my mind.


typo revise zh-CN document markdown format in ALTER-SYSTEM-DECOMMISSION-BACKEND

Proposed changes
Issue Number: close #16220
Problem summary
The Example session in zh-CN document ALTER-SYSTEM-DECOMMISSION-BACKEND can be revised.
before:

after:

Checklist(Required)

Does it affect the original behavior:

[ ] Yes
[x] No
[ ] I don't know

Has unit tests been added:

[ ] Yes
[ ] No
[x] No Need

Has document been added or modified:

[x] Yes
[ ] No
[ ] No Need

Does it need to update dependencies:

[ ] Yes
[x] No

Are there any changes that cannot be rolled back:

[ ] Yes (If Yes, please explain WHY)
[x] No

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

@hf200012 Please approve the review, thank you :)

@Gabriel39


Remove buyer's premium note on lot view

screen shot forthcoming
#1506

@ashfurrow could we potentially replace the buyers premium data instead with the current bid:

10/10, I like this idea ^

Really an oversight on my part because if the lot isn't live we don't show the user the value they would potentially setting a max bid towards.

Fixed in 1598edb.


Attempt to reconnect control connection on failed connection

In initialization scenarios during startup and recovery, it is
possible for control connections to be attempted before the
intended receiver is available. This change ensures that a worker
will try to reconnect in this situation.
Closes #2622
Closes #2685

@slfritchie @JONBRWN I've rebased in the recently merged 0.6.0 release code.  Theoretically, this will pass the resilience tests (as it did when rebased against the release branch on a different branch).  If so, it's ready to be merged when approved.


AgentUpdateView not working

Everything in the application from the tutorial so far (about to get into deployment) works perfectly except for UpdateAgentView. I've copy/pasted straight from this GitHub, and it still won't update the information for the agents. The form just goes back to agent-list with no changes on the front end, and no changes in the Agent or User table.
I've seen a few others post about this same issue on the YouTube video.
With that being said, what an amazing tutorial, and I've very appreciative of your work!
My best,
Michael

I was able to fix this by adding the following to the AgentUpdateView:
    def form_valid(self, form):         if form.is_valid():             form.save()         return super(AgentUpdateView, self).form_valid(form)
However, in the video, he says you don't need this... and it's not needed for the Lead Update. I'm not sure why it wasn't updating the agents without this.
The update form is still not pre-populated like the Lead Update Form is. I still have not fixed this part.

I think I figured out what the problem is, but I'm not sure how to fix it.
I think the problem is that the model form is changing User, but it's getting passed the wrong . It's getting passed the pk of the agent instead of the pk of the user. However, I'm not sure how to fix this.
I tried the following with no luck:
    def get_queryset(self):         curr_user = self.request.user         agent = Agent.objects.filter(organization=curr_user.userprofile)[0]         print(agent.user.id)         print(User.objects.filter(id=agent.user.id)[0].id)         return User.objects.filter(id=agent.user.id)
I got a 404 not found.
I also tried passing in the agent.user.pk in the url instead of agent.pk. That didn't work either.

AgentUpdateView is actually not working neither here https://crm.justdjango.com/agents/, nor if you git clone the latest version from the official repo.
The files that cause this issue are:

https://github.com/justdjango/getting-started-with-django/blob/main/agents/views.py
https://github.com/justdjango/getting-started-with-django/blob/main/agents/forms.py

@Bowiemb I also tried to fix this and came up to a similar function-based view first.
But your code has a dangerous bug (I also had it the first time I implemented the solution).
If this line agent = Agent.objects.get(pk=pk) you just check agent's pk and don't check whether it belongs to the same organisation as request.user.
Therefore any user signed up as ogranizer will be able to change any agent by visiting url http://localhost:8000/agents/5/update/, where 5 can be id of any agent.
You can check it yourself.

I ended up with two equal solutions (honestly, I prefer function-based view, because it's easier to debug and more explicit):
1. function-based view
agents/views.py
def agent_update_view(request, pk):
	organization = request.user.userprofile
	agent = Agent.objects.get(id=pk, organization=organization)
	form = AgentModelForm(instance=agent.user)

	if request.method == "POST":
		form = AgentModelForm(request.POST, instance=agent.user)
		if form.is_valid():
			form.save()
			return redirect("/agents")

	context = {
		"form": form,
		"agent": agent
	}
	return render(request, "agents/agent_update.html", context)

agents/urls.py
from .views import agent_update_view

urlpatterns += [
	path('<int:pk>/update/', agent_update_view, name="agent-update"),
]

and don't forget to comment out path('<int:pk>/update/', AgentUpdateView.as_view(), name="agent-update"),

2. class-based view
agents/forms.py
from django import forms
from django.contrib.auth import get_user_model

from leads.models import Agent

User = get_user_model()

class AgentModelForm(forms.ModelForm):
    class Meta:
        model = User
        fields = (
            'email',
            'username',
            'first_name',
            'last_name',
        )

    def __init__(self, *args, **kwargs):
        kwargs['instance'] = kwargs['instance'].user
        super().__init__(*args, **kwargs)

class AgentCreationModelForm(forms.ModelForm):
    class Meta:
        model = User
         fields = (
            'email',
            'username',
            'first_name',
            'last_name',
        )

agents/views.py

AgentUpdateView stays the same as it is in the offical repo.
Change form_class of AgentCreateView:

class AgentCreateView(OrganizerLoginRequiredMixin, generic.CreateView):
    template_name = "agents/agent_create.html"
    form_class = AgentCreationModelForm

.......

P.S. Maybe my code also contains some bug, but I tested it manually and it seems to work fine.
@mattfreire thank you for such an amazing tutorial.
Hope you will be able to find a minute to fix this issue in the official repo.

Was reading Django docs on Forms and came up with a shorter and elegant solution.
It seems that you just need to override get_form_kwargs method inside AgentUpdateView to make it work as a class-based view.
agents/views.py
class AgentUpdateView(OrganizerLoginRequiredMixin, generic.UpdateView):
	template_name = "agents/agent_update.html"
	form_class = AgentModelForm

	def get_queryset(self):
		organisation = self.request.user.userprofile
		return Agent.objects.filter(organisation=organisation)

	def get_form_kwargs(self, **kwargs):
		kwargs = super().get_form_kwargs(**kwargs)
		kwargs['instance'] = kwargs['instance'].user
		return kwargs

	def get_success_url(self) -> str:
		return reverse("agents:agent-list")


KAFKA-18073: Prevent dropped records when conversions fail & errors.tolerance is none

Ticket KAFKA-18073
If the conversion call fails (e.g., connectivity issue to Schema Registry, Avro exception) then even with errors.tolerance set to None (the default) we will still drop the record. This causes silent & unexpected data loss by default for any Kafka Connect source connector. We should prevent this and fail loudly and not drop records if the conversion call fails.
Changes
In order to ensure we preserve the behavior added in https://github.com/apache/kafka/pull/13955 we check if the context has failed or not when skipping records that were filtered out by a transformation. For the transformed/converted (ie producer records) we handle based on the errors.tolerance. Also add a couple helper methods to DRY up the code.
Testing
Ensured tests added in https://github.com/apache/kafka/pull/13955 still pass. Also add several new tests to test the different logical branches depending on errorrs.tolerance & whether convert or transform succeed/fail.
More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.
Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@chia7712 Could you take a look at this when you get the chance? I saw you on the past couple PRs for this file. This bug causes data loss by default for all Kafka Connect source connectors. Thanks for the help!

Good point, will update

@gharris1727 gentle nudge on this, added tests to sink as well, all tests are passing. Please let me know if there's anything else I can do.


update usage using jupyter notebook examples

closes #102
Is that okay that I moved examples into docs?

Codecov Report

Merging #118 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #118   +/-   ##
=======================================
  Coverage   95.87%   95.87%
=======================================
  Files          34       34
  Lines        1456     1456
=======================================
  Hits         1396     1396
  Misses         60       60

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adcb503...3b4badc. Read the comment docs.

Yes, that's fine. But change the readme too then. Then "Quick Start" section points to the examples directory currently.


Insiders 1.25.0 extension does not work if there is only one installed

VSCode Version: 1.25.0-insiders
OS Version: Win10 64bit

Steps to Reproduce:
Create hello world extension using:
npm install -g yo generator-code
yo code

Put this to the .vscode-insiders/extensions/
It does not work.
However, if you install any other extension (so that you have two installed extensions!) it works.
Same is true for all extensions I presume: they don't work if you have only one installed.

@Ciantic
You must place the extension like this:
$HOME/.vscode-insiders/extension/myExtension/package.json
But why are you placing it in that location, when you can launch it from anywhere using F5 ?

@alexandrudima they don't work either if you install only one from a market place.
I was testing my own https://marketplace.visualstudio.com/items?itemName=Ciantic.keymapceditor-vsc by installing to fresh insiders. It does not work.
Neither does hello world, if you have only one installed.

@alexandrudima
\.vscode-insiders\extensions\helloworldvsc\package.json
Just try it, create only one extension to fresh Insiders, it does not work. But if you install any other extension both works.

@Ciantic I cannot reproduce.
I have a single extension installed:

I can run the insiders and the single installed extension is picked up:

@Ciantic Let's try to clarify. Are you having trouble with an extension that you are authoring or with any extension that you install from the marketplace?

@alexandrudima the bug can be reprod with Hello World:
npm install -g yo generator-code
yo code

C:\Source\HTML5\vsc-example\helloworldvsc\package.json
ONLY one installed.
Then try running Hello World command:

It does not work. It does not run the activation at all.

after that, install some other extension, magically the Hello World starts to working.

There appears to be an error in the console if you have only one extension installed also:

But it disappears if I install second extension.

I have also reinstalled VS Code Insiders twice, and blown the %appdata%\VSCode Insiders directory couple of times.
It keeps happening for me.

@alexandrudima your extension does not work either if I have only it installed.
It shows in the context menu but it does not copy anything.

I tested now inside fresh Hyper-V Windows 10 container, same problem.
Only Copy relative path -extension installed and it does not work. It shows up in the context menu but it does not activate. Nor copy anything to the clipboard because it does not activate.

Same error in console (no network connectivity in the container, those errors are not relevant).

@Ciantic Thank you for your patience. I can reproduce the exception.


overly agressive url-encoding if a field contains text including links

When one enters some text which includes a URL into a field (e.g. note or fixme), the whole text gets percent-escaped (e.g. all whitespace transformed to %20). This automatic escaping should (at least) not be active if the field's value doesn't start with what looks like a URL.

iD seems to be URL-encoding every field containing a URL if any field is edited. This is causing source tags to become incomprehensible, because they often contain URLs along with other text:
source=TIGER/Line%C2%AE%202008%20Place%20Shapefiles%20(http://www.census.gov/geo/www/tiger/)

This regression was introduced in 420647f5034083db905b5bf320e7c21b52379a3f for #2323. cleanVal() is called on every tag when any tag is edited. It mostly makes sense to strip spaces after semicolons that aggressively (except in the note and description fields…), but I think it may be too aggressive for other types of canonicalization.
Anyhow, the errant escaping is due to treating the entire tag value as a URL if “http” occurs anywhere inside:
var cleaned = "TIGER/Line® 2008 Place Shapefiles (http://www.census.gov/geo/www/tiger/)";
cleaned = cleaned.replace(/[^\w\+\-\.\/\?\[\]\(\)~!@#$%&*',:;=]/g, encodeURIComponent);
// => TIGER/Line%C2%AE%202008%20Place%20Shapefiles%20(http://www.census.gov/geo/www/tiger/)

/cc @bhousel

Yes, the url escaping ended up too aggressive because I didn't want to whitelist keys to apply it too (think of all the facebook, instagram, google_plus tags people add for their businesses).
Would it be better maybe if I change it to only urlencode if the value begins with http (instead of just containing it anywhere in the value)?

Yes, the url escaping ended up too aggressive because I didn't want to whitelist keys to apply it too (think of all the facebook, instagram, google_plus tags people add for their businesses).

Taginfo says contact:facebook and the like are more common. These sites also don’t tend to have the escaping issues that random websites may.

Would it be better maybe if I change it to only urlencode if the value begins with http (instead of just containing it anywhere in the value)?

I think that’d be OK. It’d also cover any source tag that consists entirely of a URL.

Would it be better maybe if I change it to only urlencode if the value begins with http (instead of just containing it anywhere in the value)?

+1


DefiChain Desktop Wallet not recognizing BTC

Overview:
Using the desktop wallet, I deposited some DFI and BTC. Both show correctly in my balances screen. The DFI seems to work correctly throughout. However, BTC doesn't seem to be recognized anywhere else in the wallet. Either selection is missing or balance shows as 0.00.
Actual behavior:

When going to the DEX screen, BTC balance shows as zero.
Going to liquidity screen to add liquidity to btc-dfi pair, BTC selection doesnt even show.
In transaction screen, only DFI transaction is listed, not BTC.
When checking the wallet address for BTC created by the DFI desktop wallet, it says it can't be found: https://defiscan.live/address/bc1q7c2g0znk7hyy8q59cyj2l97c8c3dd0jxt0sxc6
Even though the transaction is shown on BTC blockchain: https://tradeblock.com/bitcoin/address/bc1q7c2g0znk7hyy8q59cyj2l97c8c3dd0jxt0sxc6
Tried to withdraw BTC from wallet and it shows amount on the screen but when I try to actually send it, says insufficient funds. Probably because it thinks the balance is zero.

Expected behavior:
BTC to be recognized throughout wallet and balance to be shown and used correctly.
How to reproduce it (as minimally and precisely as possible):
Deposit some amount of BTC to DeFiChain wallet. Try to use it on DEX or liquidity screens.
What are your environment parameters?

DeFiCh/app Version: 2.12.0
Operating System (OS): Windows 10
– RAM (GB): 16
– CPU (Intel Core i5/i7/etc.): Ryzen 7
Current free storage capacity: enough

logs.zip

Hi @everlast556 , the reason why you don't see your BTC on DEX or on DeFiScan is because for native BTC being sent to DeFiChain desktop app, it can only be for send (to and fro from your BTC address on BTC Network). The address that you created to receive / send BTC bc1q is a Bitcoin Network address, hence also why you're able to view the transaction on the Bitcoin Explorer instead.
If you would like to use the other features; on DeFiChain Network, you'll have to send DFI instead. To send DFI, you may do so from exchanges which supports DFI via DeFiChain Network — KuCoin, Bittrex, Hotbit just to name a few.
Closing this thread as it's not a bug, if you've further enquires on how to use DeFiChain Desktop app, you may do so on DeFiChain Telegram (EN).

Why are there selections for BTC in the DEX than? Why does no transactions show for BTC when it accepts it? How can you add BTC liquidity to a BTC/DFI pair without BTC? Why can I not withdraw the BTC then? If these aren't bugs, surely you can see there are some serious UI issues here.

I have the same problem as described above. Why I can't use this BTCs ? - I sent my BTCs from Cake to DEFICHAIN and now I can't do anything with it. How can I recover them then ?  Would be great to get any help about this.   I was sending the BTCs to add liquidity in the BTC-DFI pair but the BTCs are not recognized.  And how can I use my BTS now? or what is to do?
It seems to be the same problem as  everlast556   has

However, it would be great, if anyone can solve this problem in the future. The BTCs sent to the wallet, are not useful for anything then sending them back.
If you send DFI and change them into BTC on the DEX, these dBTC you can use for liquidity pools.  (BTC-DFI - for example) But it is very, very confusing as it is made now!   If there is an intention, that people use this DEFICHAIN, it should be much more easy to handle.


Upgrade Raspiblitz v1.9.0 - Blockchain does not connect and update anymore

I have a similar problem to https://github.com/raspiblitz/raspiblitz/issues/3614 while my debug.log looks a bit different.
Steps I did:

[x] Flashed a new SD Card to Version 1.9.0 (GitHub release)
[x] Followed the upgrade progress
[x] Everything worked fine for a week
[x] Now no new peers can be found

After shortly checking the logs I find the following errors:

tail: cannot open '/mnt/hdd/lnd/logs/bitcoin/mainnet/lnd.log' for reading: No such file or directory
2023-07-03T17:57:15Z Error: Failed to load database path '/mnt/hdd/bitcoin/wallet.dat'. Data is not in recognized format.
Jul 03 18:57:11 raspberrypi systemd[1]: Dependency failed for Lightning Network Daemon.
Jul 03 18:57:11 raspberrypi systemd[1]: lnd.service: Job lnd.service/start failed with result 'dependency'.

Full debug.log file: https://l.termbin.com/2dup

This seems to be a duplicate of #3970
Can you please try the solution here:
https://github.com/raspiblitz/raspiblitz/issues/3970#issuecomment-1619671508


modify readme

hi

Your PR has been submitted. Thanks for your contribution!

Your PR has been submitted. Thanks for your contribution!


Add RoPE comparison across flashinfer and vLLM

Motivation
NOTE: flashinfer.apply_rope_pos_ids does not exist in the prebuilt wheel, must build from source. Is this an issue?
We want to verify the correctness of flashinfer's RoPE against vLLM's RoPE, in preparation of replacing vLLM's get_rope with flashinfer's.
cc: @ByronHsu
Modifications
Added standalone python script for comparison.
Checklist

[x] Format your code according to the Contributor Guide.
[x] Add unit tests as outlined in the Contributor Guide.
[x] Update documentation as needed, including docstrings or example tutorials.

It's worth noting that flashinfer uses fp32 internally for sin/cos, we found there will be some non-trivial output difference if we use fp16 sin/cos.

@james-p-xu How is it going?  Has it already run successfully after removing this dependency using flashinfer latest https://github.com/flashinfer-ai/flashinfer-nightly/releases
https://github.com/sgl-project/sglang/blob/60769be14d00fb0d61159312db796c5f47bff6f7/python/sglang/srt/models/llama.py#L25

I will first merge this PR into the sgl-project:rpoe branch today to run the CI with nightly FlashInfer. You can check it out later and submit a new PR. Thanks!

Looks like there is another correctness issue with flashinfer apply_rope_pos_ids function. Will sync with Zihao offline on this.

also related with https://github.com/sgl-project/sglang/issues/2620


Fix template not found error

I get this error consistently

when running npx react-native init MyApp --template react-native-template-typescript

Hi @p13i this is a duplicate of #1777 and many more issues and PRs.
For more information please check out react-native-template-typescript usage note.
There is also a note right below the command on the Typescript page:


feature/issue#451 implement password recovery functionality

dev
ZenHub

Main ZenHub ticket

Summary of issue
Currently the project haven't functionality for password restoration. Implement this one.
Create endpoints for password restoration request (/reset-password/request). Required fields:

email (of user which wants restore the password).

Create password restoration approval endpoint (/reset-password/approval). Requirements:

email (the same email that user fills in the restoration request field)
token (token which was sent in the confirmation latter)
new_password (new password which requires conditions. Use functionality of password validation present in user registration functionality for checking requirements)
new_password_confirmation (should be the exact same value as a "new_password")
Token expiration time: 3 hours after approval message sending
Once password was changed token which was used for it should be disabled.
All bearer tokens should be expired after password changing

Create table password_recovery_tokens for store tokens in DB with next fields:

id (PK)
email (varchar(255))
token (varchar(36))
send_date_time (timestamp)
enabled (boolean)

Implement functionality for sending approval email which contains token. Generated link should have user's email and token as a url's variable named email and token.

Implement cron job which erase both expired and disabled tokens every 24 hours from DB
Token which was expired should not be allowed to change the password.

Other requirements:

If possible reuse or refactor methods for reusing code which used  for user registration for password requirements validation and setting the new password
Write unit/integration tests for new functionality

Corner cases:

Token expired or disabled: HTTP 406 ("Token is invalid)
Passwords don't matches: HTTP 406 ("Passwords not equals")
Password not satisfied rules: HTTP 406 ("Password too weak")
Wrong email: HTTP 404 ("Password restoration request not found")
Other: default error

Summary of change

Created new entity, repository and table for password recovery tokens
Edited OpenAPI specification
Added new endpoints for password restoration request and password restoration approval
Added 2 methods in service layer for password restoration request and change password
Added 2 cron jobs which sends approval letters and marks tokens as expired
Refactored Mail service layer
Added tests
Added mustache template for password recovery letter
Added new Exception, Converters and Exception mapper

Testing approach
Not required
CHECK LIST

[x]  СI passed
[ ]  Сode coverage >=95%
[x]  PR is reviewed manually again (to make sure you have 100% ready code)
[ ]  All reviewers agreed to merge the PR
[x]  I've checked new feature as logged in and logged out user if needed
[ ]  PR meets all conventions

Nice 👍


New function in node.py

I wrote a get_nodes_with_heading function in node.py for my own project so that one can easily zoom-in on nodes with a certain heading in the loaded document.
Example Usage:
from orgparse import loads
root = loads("""
* first
** second
*** third
* fourth
""")
root.get_nodes_with_heading("third")[0].heading
# Output: 'third'

Hope the community would find this useful.

Hey, thanks for the contribution. I am not sure it makes sense to keep in main node class because it's a bit too specific to your usecase -- at the very least this needs a test (otherwise someone else might break it by accident).
I am willing to include it in a separate file like contrib.py if you want though -- that would mean it's not exposed as a public API, but still can be used by you. Feel free to do that and reopen if you want :)


usm: file registry: Fix handling of short-lived processes

What does this PR do?
If a process terminates before we open the shared library that we want to hook, then os.ErrNotExist is returned and the code in file_registry.go::Register does not add the path to the block list.
But if the process terminates after we successfully open the ELF, then the probe registration fails due to the writes to uprobe_events failing because the path (/proc/PID/root/...) no longer exists, and the the probe registration fails with a different error (the eBPF manager does not join the errors but instead combines the error strings) and the path ends up getting blocked.
While the eBPF manager could also be fixed to join the errors, we should make the file manager more robust against failures in activation due to short-lived processes by checking if the file still exists before adding the path to the permanent block list.
Motivation
https://datadoghq.atlassian.net/browse/USMON-1292
Describe how to test/QA your changes
Test cases are included.
Possible Drawbacks / Trade-offs
Additional Notes

/merge


commit translated contents

Docs Build status updates of commit 89a5ac5:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

DocsLegal/TOC.md
:x:Error

Details

DocsLegal/index.md
:warning:Warning

Details

DocsLegal/TOC.md

[Error-InvalidMarkdownToc]

Invalid toc file: W:\hq0i-s\DocsLegal\TOC.md, Details: Unknown syntax at line 5:
<!-->
## [Baskisch](software-license-terms-eu-es.md)
## [Bulgarisch](software-license-terms-bg-bg.md)

[Error-InvalidTocFile]

W:\hq0i-s\DocsLegal\TOC.md is not a valid TOC File: Invalid toc file: W:\hq0i-s\DocsLegal\TOC.md, Details: Unknown syntax at line 5:
<!-->
## [Baskisch](software-license-terms-eu-es.md)
## [Bulgarisch](software-license-terms-bg-bg.md)

[Error-InvalidMarkdownToc]

Invalid toc file: W:\hq0i-s\DocsLegal\TOC.md, Details: Unknown syntax at line 5:
<!-->
## [Baskisch](software-license-terms-eu-es.md)
## [Bulgarisch](software-license-terms-bg-bg.md)

[Error-InvalidTocFile]

W:\hq0i-s\DocsLegal\TOC.md is not a valid TOC File: Invalid toc file: W:\hq0i-s\DocsLegal\TOC.md, Details: Unknown syntax at line 5:
<!-->
## [Baskisch](software-license-terms-eu-es.md)
## [Bulgarisch](software-license-terms-bg-bg.md)

DocsLegal/index.md

Line 16: [Warning-InvalidFileLink] Invalid file link:(~/information-protection/software-license-terms).

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 6621718:
:warning: Validation status: warnings

File
Status
Preview URL
Details

DocsLegal/index.md
:warning:Warning

Details

DocsLegal/GDPR.md
:white_check_mark:Succeeded

DocsLegal/TOC.md
:white_check_mark:Succeeded

DocsLegal/termsofuse.md
:white_check_mark:Succeeded

DocsLegal/index.md

Line 16: [Warning-InvalidFileLink] Invalid file link:(~/information-protection/software-license-terms).

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Change detection issue within AJAX call

Issue type
I'm submitting a ...  (check one with "x")

[x] bug report
[ ] feature request
[ ] question about the decisions made in the repository

Issue description
Current behavior:
Change detection is not working within ngx-admin-starter-kit within AJAX (get or post) subscribe call. When the subscribe is complete, the view is not updated with new model values. If I use ChangeDetectorRef and call .detectChanges(); it will update the view but this seems more like a workaround than the solution and I'd prefer not to do detectChanges everywhere I have subscribes.
Expected behavior:
Within the subscribe call, changing the model value should cause Angular's change detection to update the view. This happens in Angular's heroes sample project using HttpClient (question asked here: https://stackoverflow.com/questions/48512875/issue-when-model-changes-within-ajax-call-in-ngx-admin)
Steps to reproduce:

Download and npm install ngx-admin-starter-kit
In users.service.ts, add an HttpClient GET call to an external server (replace http://localhost:63468/api/clubs/heroes with any reachable server) - code snippet below
In header.component.ts, add a call and subscribe to that new service method - code snippet below
In header.component.html add a button click event and display this.hero from model. - code snippet below
Launch the application and click the add hero button.
The view's {{hero}} should be updated after the button click to say 'h' but it doesn't update until you click onto the view again.

Related code:

// users.service.ts
getHeroes (): Observable<any> {
    //return Observable.of('Mary');
    return this.http.get<any[]>('http://localhost:63468/api/clubs/heroes');
  }

// header.component.ts
getHero() {
    this.userService.getHeroes()
      .subscribe(heroes => {
        debugger;
        this.hero = 'h';
      });
  }

// header.component.html
<button (click)="getHero()">
    add hero
  </button>
  {{hero}}

Other information:
node: v6.9.2
npm: 3.10.9
OS: Windows 10
Browser: Chrome (haven't tested on others)
Angular, Nebular
angular-devkit/build-optimizer - 0.0.36
angular-devkit/core - 0.0.22
angular-devkit/schematics - 0.0.42
angular/animations - 5.1.3
angular/cli - 1.6.3
angular/common - 5.1.3
angular/compiler - 5.1.3
angular/compiler-cli - 5.1.3
angular/core - 5.1.3
angular/forms - 5.1.3
angular/http - 5.1.3
angular/language-service - 5.1.3
angular/platform-browser - 5.1.3
angular/platform-browser-dynamic - 5.1.3
angular/router - 5.1.3
schematics/angular - 0.1.11
nebular/auth - 2.0.0-rc.4
nebular/theme - 2.0.0-rc.4
nebular-icons - 1.0.6

The same thing is happening to me but not only on ajax calls, it also happens to the sidebar, NbLoginComponent only shows the error if you click on the page, same for my forms, and even the toasters only show up if I call a detectChanges() after it.

You can fix quickly it with using of ChangeDetectorRef :
  constructor(private sidebarService: NbSidebarService,
              private menuService: NbMenuService,
              private userService: UserService,
              private analyticsService: AnalyticsService,
              private cdr: ChangeDetectorRef) {
  }

  getHero() {
    this.userService.getHeroes()
      .subscribe(heroes => {
        this.hero = 'h';
        this.cdr.detectChanges();
      });
  }

I will try to fix it soon.

That is what I am doing, but I was checking and I thinking I found the root of the problem, but I didn't have time to test, @acasciani and I both used the starter-kit, and on the app.component the ChangeDetectionStrategy is set to OnPush and shouldn't be set or set to Default, I think that could be it since OnPush only detect change in events like click, but I need test but should work now.
And if this is the problem the starter kit should be updated.

fixed by https://github.com/akveo/ngx-admin/pull/1534


HTTP/2 Make DefaultHttp2HeadersDecoder's Http2Headers object creation extensible

Motivation:
It is generally useful to override DefaultHttp2HeadersDecoder's creation of a new Http2Headers object so more optimized versions can be substituted if the use case allows for it.
Modifications:

DefaultHttp2HeadersDecoder should support an overridable method to generate the new Http2Headers object for each decode operation

Result:
DefaultHttp2HeadersDecoder is more extensible.
Fixes #6591.

@nmittler @carl-mastrangelo @ejona86 - FYI

4.1 (225d10e)


[move-only] Add a new type of mark_must_check initable_but_not_consumable

This is used to teach the checker that the thing being checked is supposed to be uninitialized at the mark_must_check point so that we don't put a destroy_addr there.
The way this is implemented is that we always initially add assignable_but_not_consumable but in DI once we discover that the assign we are guarding is an init, we convert the assignable to its initable variant.
rdar://106525988

@swift-ci smoke test

@swift-ci smoke test

@swift-ci Please test


add urllib3 version restriction to requirements.txt

Details are in https://github.com/ucbrise/clipper/issues/678. Once requests library starts to be compatible with urllib3 >= 1.25, we should remove this line.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/1916/
Test PASSed.

I added urllib3 constraint to Dev35Dockerfile as well. And the previous CI shows that urllib3==1.25.2 does not generate failed to parse error. I think the problem is within urllib3==1.25.1.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/1917/
Test FAILed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/1918/
Test PASSed.

I'm re-running travis. Once it pass we should be fine.


chore: Refresh CRD-docs-for-docs-repo.md

Description

Relates to https://github.com/kubewarden/kubewarden-controller/pull/826
Check in result of doing cd docs/crds; make generate

Test

NA

Additional Information
Tradeoff

Potential improvement

@jhkrug true, fixed the godocs and regenerated the crds and crd docs, please rereview.


unable to add Ids

Hello,
I installes rtetempo via HACS on my docker installation of homeassistant (official stable image), but when I validate the ids, I get an "Unknown error occurred"
the logs arror : "TypeError: HomeAssistant.new() missing 1 required positional argument: 'config_dir'"
Can someone help me finding where it comes from ?
Thank you !
The full logs shows :
home-assistant   | 2023-09-08 12:06:18.909 ERROR (MainThread) [aiohttp.server] Error handling request
home-assistant   | Traceback (most recent call last):
home-assistant   |   File "/usr/local/lib/python3.11/site-packages/aiohttp/web_protocol.py", line 433, in _handle_request
home-assistant   |     resp = await request_handler(request)
home-assistant   |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
home-assistant   |   File "/usr/local/lib/python3.11/site-packages/aiohttp/web_app.py", line 504, in _handle
home-assistant   |     resp = await handler(request)
home-assistant   |            ^^^^^^^^^^^^^^^^^^^^^^
home-assistant   |   File "/usr/local/lib/python3.11/site-packages/aiohttp/web_middlewares.py", line 117, in impl
home-assistant   |     return await handler(request)
home-assistant   |            ^^^^^^^^^^^^^^^^^^^^^^
home-assistant   |   File "/usr/src/homeassistant/homeassistant/components/http/security_filter.py", line 85, in security_filter_middleware
home-assistant   |     return await handler(request)
home-assistant   |            ^^^^^^^^^^^^^^^^^^^^^^
home-assistant   |   File "/usr/src/homeassistant/homeassistant/components/http/forwarded.py", line 100, in forwarded_middleware
home-assistant   |     return await handler(request)
home-assistant   |            ^^^^^^^^^^^^^^^^^^^^^^
home-assistant   |   File "/usr/src/homeassistant/homeassistant/components/http/request_context.py", line 28, in request_context_middleware
home-assistant   |     return await handler(request)
home-assistant   |            ^^^^^^^^^^^^^^^^^^^^^^
home-assistant   |   File "/usr/src/homeassistant/homeassistant/components/http/ban.py", line 80, in ban_middleware
home-assistant   |     return await handler(request)
home-assistant   |            ^^^^^^^^^^^^^^^^^^^^^^
home-assistant   |   File "/usr/src/homeassistant/homeassistant/components/http/auth.py", line 236, in auth_middleware
home-assistant   |     return await handler(request)
home-assistant   |            ^^^^^^^^^^^^^^^^^^^^^^
home-assistant   |   File "/usr/src/homeassistant/homeassistant/components/http/headers.py", line 31, in headers_middleware
home-assistant   |     response = await handler(request)
home-assistant   |                ^^^^^^^^^^^^^^^^^^^^^^
home-assistant   |   File "/usr/src/homeassistant/homeassistant/components/http/view.py", line 148, in handle
home-assistant   |     result = await handler(request, **request.match_info)
home-assistant   |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
home-assistant   |   File "/usr/src/homeassistant/homeassistant/components/http/decorators.py", line 63, in with_admin
home-assistant   |     return await func(self, request, *args, **kwargs)
home-assistant   |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
home-assistant   |   File "/usr/src/homeassistant/homeassistant/components/config/config_entries.py", line 177, in post
home-assistant   |     return await super().post(request, flow_id)
home-assistant   |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
home-assistant   |   File "/usr/src/homeassistant/homeassistant/components/http/data_validator.py", line 72, in wrapper
home-assistant   |     result = await method(view, request, data, *args, **kwargs)
home-assistant   |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
home-assistant   |   File "/usr/src/homeassistant/homeassistant/helpers/data_entry_flow.py", line 110, in post
home-assistant   |     result = await self._flow_mgr.async_configure(flow_id, data)
home-assistant   |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
home-assistant   |   File "/usr/src/homeassistant/homeassistant/data_entry_flow.py", line 298, in async_configure
home-assistant   |     result = await self._async_handle_step(
home-assistant   |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
home-assistant   |   File "/usr/src/homeassistant/homeassistant/data_entry_flow.py", line 394, in _async_handle_step
home-assistant   |     result: FlowResult = await getattr(flow, method)(user_input)
home-assistant   |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
home-assistant   |   File "/config/custom_components/rtetempo/config_flow.py", line 50, in async_step_user
home-assistant   |     hass = HomeAssistant()
home-assistant   |            ^^^^^^^^^^^^^^^
home-assistant   | TypeError: HomeAssistant.__new__() missing 1 required positional argument: 'config_dir'

That's... weird.
I am guessing that the constructor has changed in 2023.9.0 and that all existing installations are fine but new one will fail.
I need to look into that when a bit a free time arise. In the meantime can you try this workaround ?

Downgrade to the last HA 2023.8.X
Install rtetempo
Upgrade HA to 2023.9.0

If this is what I think it is, it should do the trick for now.

Hello.
Indeed, it worked !
Thank you.

It should be fixed with v1.3.2


Latitude Units

Inputting latitude units as decimal degrees raises ValueError:

I am using refet version 0.3.7 and I used a station latitude in decimal degrees in the .ini file.
refet version 0.3.7 is supposed to expect decimal degrees but I am being warned that latitudes must be in radians.

Update 9/24/18:
This issue arises when you are using refet 0.3.1. I misidentified my version at first glance.

My apologies for not responding to this sooner, for some reason I did not get any notification when you opened your issue.
I am in the middle of a complete rewrite of my script to make it more condensed and efficient, I will add handling to indicate if the refet package is the wrong version. I appreciate the feedback and please let me know if you have any other suggestions and issues.