Add extended_errcode_int function.

This is a simplified alternative to #51, only defining the integer-returning function. This avoids making design decision now about the form of the extended error codes. This will suffice for solving paurkedal/ocaml-caqti#72, since I will need to define an independent set of errors to smooth out the difference between the different database client libraries anyway.

Thanks for the contribution!


Temperature coefficient units

solarforecastarbiter.datamodel.PVModelingParameters takes in temperature_coefficient in units of %/C, while the temperature coefficients used in pvlib, typically gamma_pdc, are in units of 1/C. Additionally, the example from the workshop is in units of 1/C:

temperature_coefficient=-0.003,  # 1/C

Is there a reason that the units are different in solarforecastarbiter?

I just remembered that the units for site metadata in the web interface are %/C, and I was probably involved in that decision, or at least had the opportunity to comment on it...

It looks like we neglected to update the workshop notebook with new values after adjusting the units. Thanks for bringing it to our attention. I know that the API documentation for these units was not updated until long after this change was implemented in the core library and dashboard.
The primary motivations for this change were that AC and DC loss factor are specified in units of % and temperature coefficients are typically available on datasheets in units of %/C as discussed here:  https://github.com/SolarArbiter/solarforecastarbiter-core/issues/350
Conversion to units of 1/C for use in pvlib occurs in the calculate_power function: https://github.com/SolarArbiter/solarforecastarbiter-core/blob/25fc4c97114f9750d9e1381cddbc783e7024e662/solarforecastarbiter/pvmodel.py#L270

The reasoning behind using %/C makes sense to me.
Thanks.

I am certain this came out of the DOE workshop in October 2019 in DC, and I recall you had some good suggestions there...
I'll transfer the issue to the workshop repository so we don't forget to update the notebook.


pakage is not a word.

Package is a reserved word, so I changed it to pkg.

Close for the same reason as mentioned in https://github.com/microsoft/vscode/pull/78576#issuecomment-519731948, thanks!


Can't get the MQT to work, any ideas ?

Hi,
I have put this into a nodemcu, it connects to WiFi and it also connects to the MWTT broker (i can see that in the serial terminal) however when i publish the json payload to /home/rgb1/set nothing shows up the serial terminal ? I tried two different MQTT servers, both mosquito and http://www.hivemq.com/try-out/ and none works. It's very strange, in the code i should be able to see "Message received..." but nothing comes in.
Any ideas what i might be doing wrong ?

Never mind, i solved my problem, the problem was that the json i was sending from mqtt box should be in one line, i had just made copy/paste from the page here.


Is vcs module obsolete?

When I investigate existing PyBuilder code for usage into SemVer git tag plugin (takes project.version according Git tag) I found only vcs module. But didn't find any usage of it. Should it be removed?

No, I have many many projects that use the vcs module to set the version. Specifically count_travis for continuous versioning.

PyBuilder - plugin-based system. So if vcs is used into projects - it should be converted to plugin.

Sure, pull-requests welcome! You'd end up breaking quite a lot of peoples build.py.

Thanks, no. I created pull request for pytest plugin year ago and it's still here. :grin:
Question closed.


Typos in documents: LCL Filter state-space model reference frame should be on the dq0 axis.

Hi! The correct model should be:

Hi, is the only difference that we use R and I instead of DQ? This is just a convention that we use to refer to the reference frame of the network as RI instead of the internal reference frames of dq used for devices.

Hi, is the only difference that we use R and I instead of DQ? This is just a convention that we use to refer to the reference frame of the network as RI instead of the internal reference frames of dq used for devices.
Hi, that makes sense to me.
Just one more small typo, for eq(1e) and (1f), the filter current i_r and i_i should be used instead of converter current i_r,cv and i_i,cv.

Hi, is the only difference that we use R and I instead of DQ? This is just a convention that we use to refer to the reference frame of the network as RI instead of the internal reference frames of dq used for devices.

Hi, that makes sense to me. Just one more small typo, for eq(1e) and (1f), the filter current i_r and i_i should be used instead of converter current i_r,cv and i_i,cv.

Thanks for this. I'll fix this typo in the next release!

@rodrigomha can we fix this for the 0.13 release?


[WIP] Binding one component to multiple parameters – Solution #2

fixes #90
Signed-off-by: Ingo Bürk<EMAIL_ADDRESS>

This pull request relates to or closes the following issues:
I have verified that…

[ ] the commits in this pull request follow the conventionalcommits pattern
[ ] tests have been updated or added
[ ] documentation has been updated to reflect the changes made

TODO:

[ ] Resolve open TODOs
[ ] Tests
[ ] Documentation
[ ] Ensure documentation inheritance works


Refresh Flow on SSH No Ports

Notes on concerns:

A user is brought to checkout with the button that claims "Try it for free", but there is no notion of free trial on landing page (instead there are two spots that suggest $99)
Organization could be removed out of redundancy
On the right hand there are about 3 spots that SHH No Ports is repeated
Separate form into section (perhaps reorder sections to have setup come first - requires discussion)
Add to progress bar - email authentication (note that down the line we might want to rethink if we want users to authenticate in the middle of the process)
"Edit" on payment page should immediately open textbooks (might be confusing to bring users back to first page)
Make it obvious that is a free trial, entering credit card information might be intimidating

Figma
Steps:

[ ] Create mockup of payment flows

Update: we went through back and fourths this sprint and finalized a "quick fix" see Figma tab, Ashish is currently working on release (release candidate should be available for OCT 30/31)


AZ-203 Azure Service Fabric left out

I am a Service Fabric fan and I am working on preparing for https://docs.microsoft.com/en-us/learn/certifications/exams/az-203.
I am very surprised to see that ASF is not in the exam syllabus. There is AKS and containers and stuff but not ASF. So, what is the idea behind that? Will Microsoft be dropping support to ASF and moving to Docker, Kubernetes? I am also learning ASF, so please let me know whether ASF will be sunset.

I'm a consumer of Service Fabric, and one thing I've noticed is that Service Fabric has support for Stateful Services, but AKS does not. Until that feature parity is there, I would be surprised if Azure made the complete transition to AKS over Service Fabric. There are a lot of major Azure products running off of Service Fabric that would need to be ported over. Service Fabric has the maturity at this point, even if its not the current 'cool kid' on the block. Just my 2 cents, but it would be great to hear from a Microsoft resource on this one 😄

The roadmap concerning all of the products in this sphere (AKS, ASF, ASF mesh) and the new programming model/platform/... released (dapr) is not really clear.
I was hoping ignite would show a path but it did not...

Yes, we need this info

Valid observations, need a clear information on road map towards ASF.

It's part of AZ-400 though. There we some questions about how Service Fabric fits in CI/CD.

@artisticcheese Thanks for the mention. Glad its part of CI/CD. Me being a developer, am interested to know more on the development front. Would appreciate if anyone from Microsoft can comment.

@alexv-be

dapr

https://cloudblogs.microsoft.com/opensource/2019/10/16/announcing-dapr-open-source-project-build-microservice-applications/
says
Although Dapr borrowed the Actor Framework and Stateful features from Service Fabric, There are a couple of major differences. a) Stateful services: Your code + data wont’ live together on dapr. You would need an additional I/O hop to access cosmos or redis [or your own state provider] to get to the data. In service fabric, once you hit a partition the data lives right there on that node. You will get much lower latency for reliable collection reads with Service Fabric. b) Service fabric runs classic .net and .net core. Dapr is only for .net core projects. This is a big deal for users who have vast assets on classic .net c) With external state provider, partitioning becomes a little murky on dapr. Service fabric gives you range and named partitions with replicas. I am not clear how dapr handles replicas or it delegates that to kubernetes or the underlying orchestrator. d) Service Fabric roadmap: https://github.com/Microsoft/service-fabric#service-fabric-release-schedule. so, to answer your question, Service Fabric is here to stay.

Thanks for positive feedback on Service Fabric. We would like to learn more about your Service Fabric workloads. Please share your contact information.

@athinanthny Hi,
I am learning ASF as well as preparing for Azure Certs. I work in non-ASF .NET based apps in my normal office hours, but have built multi-tenant saas apps as my pet projects, mostly monolithic.
Next on list, I am planning to build a multi-utility mobile app to which microservices are more apt in the back end.
Hence I shortlisted ASF for it. The workload I am planning to use is https://docs.microsoft.com/en-us/archive/blogs/maheshkshirsagar/common-workloads-on-azure-service-fabric "Multi-tenant applications"

@athinanthny here is example and I believe it is not unique.
We are going to migrate our enterprise product from legacy WCF Windows service-hosted monolith to some distributed cloud-friendly model. Classics. Among requirements there are:
•	ability to host app as on the cloud as on-premises;
•	both .Net Framework and .Net Core support (at least for the transition from .Net Framework period);
•	dynamic scalability, good balance between performance and resiliency;
•	state and health monitor;
•	rich programming model;
•	easy local deployment for dev/QA needs;
•	easy staged migration opportunity.
To reduce the complexity, we are not interested neither in cross-platform nor in multi-lang/frameworks support. Just Windows and .Net.
From all those perspectives SF looks like a perfect match we would love to go with. All the POCs we've done so far give very promising results. But... Microsoft's attitude towards its own platform raises a lot of concerns as to SF future also mentioned in this thread. With a quite restrained updates on SF over the past year, it is hard to miss that huge effort Microsoft puts on propagation of Kubernetes and Dapr. The last thing we want is to endeavor to migrate from obsolete technology stack just to end up with another discarded platform.
And there are no reliable statements on that, only contradictory guesses and gossips from various people. Even after requesting proactive hours for SF as a part of our Microsoft Premier Support subscription, Microsoft guys are trying to discourage us from going with SF because they have very little clues what's the hell SF is and what is its road map as a platform.
It would be extremely frustrating if after all we have to switch to Dapr, Kubernetes and all the zoo of their various come-alongs just because of lack of confidence in SF future.

Why are you not considering running just Windows containers inside Kubernetes instead of SF?

We did. It is a nightmare to run Kubernetes and containers in a highly-regulated corporate environment.

I imagine SF running in the same environment shall not be much different

As above, all SF proof of concepts works just fine. With SF reliable services I do not need to deal with all those local Hyper-V restrictions and other jazz.
I just don't want to turn this thread into debates around Kubernetes. My original point was about uncertainty about SF as a platform despite all its benefits.

@Tavriets  We would like to have detailed follow-up to better guide you on next steps. Are you available to do a phone chat for 30mins next week (Tue-Friday). If yes, please share your contact info

@athinanthny, more than happy to have a call. Could you please contact me at my private address tavriets at gmail.com to arrange time?

@Tavriets those are a lot of the same reasons my company is moving to Service Fabric. Sadly we live in a culture of "sort by stars descending on GitHub" and I believe it causes more fear than is necessary. We have a team of 5 people managing around 20-30 micro-services (full CI/CD pipelines). Even the process of standing up a new Service Fabric cluster is automated. I can't imagine this kind of autonomy with such a small team on many of the other technologies.
@athinanthny what would be the best way to send you contact information?

@artisticcheese the SDK that Service Fabric provides for RPC between services and reliable distributed state persistence don't have an equivalent in K8's, at least not out of the box.

@athinanthny
If I need to migrate my Azure Cloud Services, I was hoping that ASF would be the best fit and I have started working on the same. But after seeing @Tavriets comment that "Microsoft guys are trying to discourage us from going with SF because they have very little clues what's the hell SF is and what is its road map as a platform." I am now really afraid.
Microsoft needs to take a strong stand and provide a long term support to ASF.

@JustinKaffenberger  @Tavriets @srivathsanvlb  Please reach us at<EMAIL_ADDRESS>as early as you can and mention this git issue for references. We would like to talk to you all this week. We want to understand your usecase, hear your concerns, learn about your workloads and provide best guidance possible.

@athinanthny<EMAIL_ADDRESS>rejects incoming messages. At least from my address.

@srivathsanvlb to be fair I'd love to see @Tavriets get knowledgeable support for AKS and do a comparison. My suspicion is that with enough complexity any technology stack can become cumbersome for support to deal with, and simply migrating an existing architecture to AKS doesn't make the complexity go away.
As far as I know, Windows Containers on Service Fabric is currently the only production ready way to run Windows Containers on Azure, as it is still in preview for AKS. We don't current run containers on Service Fabric, just processes, but this is an important note if Windows Containers are important for you.

@Tavriets I have the same issue with the email address.

Windows containers are officially supported from vendors are on Docker swarm, Service Fabric and ACI. The problem with Service Fabric support is that despite today is February 18, 2020 they still don't support Windows 2019 as base OS when you deploy as PaaS in Azure. So it's not better then really any other alternatives. Service Fabric had such a nice headstart as you mentioned as far as running supported Windows containers but it's a joke now as far as Windows containers. How on Earth they still don't support Windows 2019 as host OS? Even Kube now have it in preview. For me personally SF is dead as far container orchestrator

@Tavriets  @JustinKaffenberger  we encountered email issue and will resolve it in 24hrs. Please reach us after 24hrs. Sorry for the incovenience.

@artisticcheese it appears that their docs are the issue. It looks like support for Windows Server 2019 was added in April of 2019: 6.4 Refresh Release

Yes but I don't beleive that version made it to Azure itself. Here is a list of supported OS versions if you create it from portal. Windows 2019 is missing and hence will not be able to run Windows 2019 containers as result.

@artisticcheese interesting, I will have to do more research on this new(ish) concept of the semi-annual channel. It seems to be something Microsoft is pushing for micro-service platforms. From this page in particular:

Containerized applications, container hosts, and application scenarios benefiting from faster innovation

but from what I can tell 1909 is the latest.

It is supported in standalone cluster but just not in Azure. ACI (Azure Container Instances) are actually running on top of Service Fabric (to some people surprise since they expected it to be running on Kubernetes) and that one have support for Windows 2019 in preview (https://docs.microsoft.com/en-us/azure/container-instances/container-instances-region-availability#availability---windows-server-2019-ltsc-1809-deployments-preview). So basically Azure Service Fabric is no better and and in reality worse in supporting Windows containers on Azure then Kubernetes.

I sent an email to the email address specified above and I would like share the response I received.
There is not a plan to drop support for ASF. We discuss our roadmap during events like our most recent Community Q&A (yesterday: https://m.youtube.com/watch?v=RcrYDPn9R4A) and are working to do a better job communicating current work items and progress.
In the meantime we have started to incorporate information into our release notes.
https://github.com/Azure/service-fabric/blob/master/release_notes/Service_Fabric_ReleaseNotes_70.md
In regard to the issue, we believe that this was an accident and that SF is present in higher level trainings but are following up on the issue.

There has been a lot of FUD spread around the community around Service Fabric. What most people do not realize, is that Azure actually runs on SF. Massively scalable multi-tenant stuff like CosmosDB, runs on SF.
https://dev.to/aloneguid/is-azure-service-fabric-still-relevant-in-2020-4j87
SF is not going away. Many enterprises run their mission critical workloads on SF. It's just not so very visible compared to the k8s screaming community herds.

I'm a bit concerned that the November 2019 release of the eShopOnContainers sample application, which showcases how to build .NET applications using microservices and containers, has added a deployment option for AKS, while "retiring" Service Fabric as a deployment scenario. See the release notes here. I like the benefits of SF, but I'm hearing mixed messages.

I personally always had a very consistent answer from MS about SF: it's not going anywhere. I've had this response using different channels, including this one. And at this point, I can only trust this is the case, although some of the evidence clearly points in another direction, the released roadmap was a great confirmation.
What I do worry about, is the fact that MS seems to be pushing K8S more than the in-house developed alternative (SF), the technology that actually solves a ton of service oriented architecture problems. This inevitably leads to a "see, even MS pushes kube over SF"-conversation with customers when proposing SF's value. For the Microsoft focused enterprise SF makes a lot of sense. There's something to be said about some good old-fashioned competition to drive innovation.

Now it seems even Microsoft is starting to migrate away from Service Fabric:
https://www.theregister.com/2020/06/17/microsoft_plans_to_move_teams/

Any updates?

We would like to have detailed follow-up to better guide you on next steps. Are you available to do a phone chat for 30mins next week (Tue-Friday). If yes, please share your contact info

Why the preferential treatment - can't you post an update somewhere for all to see?

Has there been any more communication about teams abandoning Service Fabric? An community Q/A session I've missed?
Would be very interested to hear the details of how SF failed teams enough to motivate such an investment, and what the response from sf team is. And of course, any details that could shed some light on the future.

Just dropping this here: https://twitter.com/3tornados/status/1243393599309414400
During the giant upsurge in usage of Team in March (Covid outbreak), it was actually SF that saved the day.
I keep reading quite a lot of rumors regarding future of SF, but until there is an official statement regarding abandoning SF from MS, I shall just regards those rumors as FUD.

We use SF extensively, but stratergically we can now reimplement services using serverless/aks and get as good perperformance without the complexities and overheads of SF (including specialised resources to maintain systems). Our problems are not if SF is capable or not, its the limitations around its scaling and state replication that make our solutons costly to operate.
On every support call with MS on SF, the SF team shrugs there shoudlers "orly? we dont pay, so wouldnt know" and thats that. We are not seeing the focus on the customer, because in this case, we are just a small drop in the pool - Azure gets what it needs and there is little leftover for others.
To me, this is the real story at play when people talk about SF being pulled back from the public and kept internally. Its costing modal wasnt designed to be a competitive SaaS product, its designed to meet the needs of Azure.


Clarify disk formatting for Meteor example.

GKE has a hosted master now. We can leave this as kubernetes-master as this is written for kubernetes and not GKE. Added note to clarify.

LGTM. Doc-only change, green, merging.


Extension contribution

Question or Suggestion
Hello @scottmckendry , I would like to contribute with Neogit extension but I'm not totally sure how to do it as I'm not very good at managing github repos. I followed the instructions on contributing page, but what is the best way to go about it and submit a PR? Should I clone your repo, make the changes and submit a PR? Currently for testing purpose I edit the nvim file directly, which I'm sure it not the correct way to do it.
Thanks for your patience!

Thanks for showing interest in the project @gldtn! I want the contribution process to be as streamlined as possible so it's always good to get feedback from first-time contributors.
If you use lazy.nvim as you neovim plugin you can configure it to look for local copies of plugins in a specific folder, like I have done here:
https://github.com/scottmckendry/Windots/blob/eec6734e91d556b203f765d3bb6b9fc2f9fb5f49/nvim/lua/core/lazy.lua#L21C5-L24C7
From the configuration docs:

dev = {
   ---@type string | fun(plugin: LazyPlugin): string directory where you store your local plugin projects
   path = "~/projects",
  ---@type string[] plugins that match these patterns will use your local versions instead of being fetched from GitHub>
   patterns = {}, -- For example {"folke"}
   fallback = false, -- Fallback to git when local plugin doesn't exist
}

Once this is setup, you can clone your fork of cyberdream.nvim to the local directory you've configured in lazy.nvim.
Then in your plugin config, add dev = true, to get lazy to load your local copy instead of it's own cloned version.
Here's an example from my config:
https://github.com/scottmckendry/Windots/blob/eec6734e91d556b203f765d3bb6b9fc2f9fb5f49/nvim/lua/plugins/colourscheme.lua#L4C9-L4C20
This will let you test your changes locally before committing/merging upstream. Let me know if you have any other questions!

I think I did everything right, and submitted a PR 🎉
Thanks for you help!
Dev would not work until I added the imports inside specs table:
spec = {
        { import = "plugins" },
        { import = "plugins.lsp" },
    },

before I just had:
 { import = "plugins" },
        { import = "plugins.lsp" },

Leaving it registered here just in case someone has the same problem.


PermissionsEx Group Add/Remove Issues.

Hello.
Over the time I have been using PermissionsEx I have found a few issues.
The issue that I want to assess is to do with adding/removing multiple groups.
Issue:
Sometimes when a user ranks up, their groups are not added/removed, instead permissionsEx only executes one of the commands (either adding another group the user, or removing one of their groups) and the user is reverted back to the default group (a).
I think I may have found the cause, (it's not to do with weight).
When multiple PermissionsEx groups are added/removed from multiple users at the same time, I think the plugin is having issues writing to the file.
I have made the issue much less common with a custom cool-down plugin for the /rankup command.
What used to happen before we had this cool-down command is that two users would rankup right after one another, and one users would either have an extra group added to their info, or have their primary group removed, although the other user would be fine.
It seems to be very hard to reproduce this.
One thing I have noticed is that the permissions.yml file is around 6mb perhaps causing write issues.
I know I'm not very good at explaining the situation, but if you could respond back to me whenever so we can discuss the issue and hopefully resolve it, I would be immensely appreciative.
Thank you so much for your time,
with regards,
Dug.

What version of PEX are you using? The most recent version of PEX may be better at handling conflicts like this.

I'm currently using 1.22.8, I have also tried 1.22.9, and many other previous version.
The server is running 1.7.10 protocol patch.

@D-ouglas, I would recommend you to upgrade to 1.8.* as the plugin is updating to latest version (Fixing problems and stuff)

We've updated to the latest version and the issue seems to have been resolved.
Thanks for your time.

No problem @D-ouglas.
@zml2008, you can close this now.


Default importHook

I propose that it is reasonable for the importHook argument of the Module constructor to be optional and for the default import behavior to come from the global environment.
Following the precedent on the Function constructor, a Module constructor should have an execution context [[Context]] internal slot, from which we can find the corresponding module or script record, from which new Module instances would inherit their import behavior.
This implies that the Function and Module constructors would behave consistently for the purposes of reaching for the global import behavior, that both objects represent an authority to evaluate code in the global environment.
For example, if one constructs a module with a particular importHook, that will apply to the static and dynamic imports in the text of the module, but both the Function and Module constructors can be used to bypass that hook.
const module = new Module(
  new ModuleSource(`
    new Function('return import("fs")');
    new Module(new ModuleSource('import fs from 'fs'));
  `),
  {
    importHook() { throw new Error('you shall not import') },
  }
);

The Function constructor establishes a precedent that confinement is not possible without virtualization of Evaluators. The evaluators layer addresses this confinement problem by creating new eval, Function, and Module instances with a different [[Context]] internal slot, such that a host can evaluate guest code, including the above example, where the nested Function and Module constructors would be the confined evaluators.

To formalize this a little more:

the 2nd argument of the Module constructor to be an object (similar to Proxy Handler)
hooks can be extracted from that object during construction (different from Proxy Handler)
the object and the extracted hooks to be store into some internal slots of the Module Instance.
when calling a hook, use the object as the this value of the invocation (similar to Proxy Handler).
if no importHook is provided, implement the default importHook which delegates to the browser to resolve based on a null referral.
the 2nd argument is optional.
the 3rd argument is importMeta, which is also optional. No referral argument is needed anymore since you can rely on the this value inside hooks for the context.

Pros:

extensible (future hooks will work fine)
easy to understand, not need to learn about referral at all.
shorter.

Cons:

In order to pass importMeta you must pass a handler, even if it is empty, e.g.: new Module(source, {}, { url: 'something' }), should we allow this argument to be null?


Mute and Volume Controls Not Working

Consent

[X] I have searched the existing issues and verified that there is no open issue for the same subject.
[X] I understand that the YTMDesktop Elgato Plugin has NO affiliation with Google, YouTube or the YTMDesktop application.

Current Behavior
It appears the mute, volume up, and volume down controls do not work. Volume up and down will move the volume sliders inside the YTMD app, and mute seems to toggle mute yet the audio does not mute or get adjusted at all. I have confirmed it's not my audio setup as if I use the mouse to drag the volume or click the mute button inside YTMD it works fine. I'm not sure if this is a problem with your Stream Deck app or with the YTMD player. All other buttons are working fine for me.
Expected Behavior
Volume adjustments should not only adjust the UI elements of the YTMD app but also adjust the volume appropriately.
Steps To Reproduce

Press any volume adjustment volume on stream deck.
Observe no change in audio volume.
Click with mouse on YTMD volume controls
Observe proper change in audio adjustment.

OS
Windows
OS Version
11
Plugin Version
1.7.0
YTMDesktop Version
1.13.0
How did you download the software?
Elgato Store
Anything else?
Here's a video of the behavior:
https://photos.app.goo.gl/pXNpDJ2ySAeEB1ts5

This seems to be a /duplicate of #28
Please make sure you're on one of the latest pre-/nightly releases, because v1.13.0 isn't supported anymore.
If this issue still persist, feel free to re-open it.

Confirmed working as expected on 1.14.2


[Error] "Could not debug. Unable to set up communication with VSCode react-native extension.

[Error] "Could not debug. Unable to set up communication with VSCode react-native extension. Is this a react-native project, and have you made sure that the react-native npm package is installed at the root?"

VSCode Version:版本 1.14.1 (1.14.1)
OS Version:macOS 10.12.5 (16F73)
我已经安装了npm,并且用命令可以跑起来，Xcode也可以跑起来，就是VScode起不来。
Steps to Reproduce:

1.Open my project.
2.click run.

Reproduces without extensions: Yes/No

This issue was moved to Microsoft/vscode-react-native#475


fix: flakey macOS build caused by CAS operation setting 0 expiration to 1

fixes #59
Pretty sure this is the cause of the flakiness because if you set:
diff --git a/src/server/segcache/tests/common.rs b/src/server/segcache/tests/common.rs
index 9f33681..e551a35 100644
--- a/src/server/segcache/tests/common.rs
+++ b/src/server/segcache/tests/common.rs
@@ -235,7 +235,7 @@ fn test(name: &str, data: &[(&str, Option<&str>)]) {
             }
         }

-        std::thread::sleep(Duration::from_millis(10));
+        std::thread::sleep(Duration::from_millis(1000));
         let mut buf = vec![0; 4096];

         if let Some(response) = response {

so you enforce a long wait in between running commands, then the test will fail every time on my machine (x86_64 Ubuntu WSL2).
I think the reason it doesn't fail all the time is due to machine load/architecture performance differences that cause the GET to occur either before or after the relatively immediate expiration of the key. If Pelikan was slower we'd probably have found this bug already.
The test that specifically fails (or at least the one that seems to be the cause of the nondeterministic failures) is here:
https://github.com/pelikan-io/pelikan/blob/4599e5f964ae59113e0d26e0a7ededcd46e9e4b0/src/server/segcache/tests/common.rs#L56-L66
If I run that sequence of commands on memcached, the get command will always succeed, regardless of how much time has passed.
However, when I run those commands against segcache, the key is expired by the time I try to get it (at least that's the likely behavior I see, based on the GET returning nothing)

To check this in CI can you revert #58 here as well? It won't give 100% certainty but at least if that test fails then we know the issue is still there.

To check this in CI can you revert #58 here as well? It won't give 100% certainty but at least if that test fails then we know the issue is still there.

ok I reverted it as part of this PR

Per discussion on discord... this is actually a little more buggy than it appeared. Will edit the diff


Address a half of the comments on the terms part of the Quviq generators PR

It’s a big part of the huge PR and addressing comments requires a lot of time.
From https://input-output.atlassian.net/browse/PLT-934

PR: https://github.com/IntersectMBO/plutus/pull/4949

There's no such review, hence I'm closing the issue.


/integrations/: Focus search bar on page load.

This focuses the search bar on initial page load.

Merged, thanks @brockwhittaker!


Clean up Overview

Draft PR where we can experiment with the overview page, which is a bit overwhelming in length and content. I began by reorganizing some text and headings, and introducing basic expandable sections for each component. More to do:

I think that the introductory paragraph itself could use a re-visit to provide a compelling/concise explanation of the whole Zowe project
Any other suggestions on how to make this section more "digestable"?
Not sure if the Details html tag will do well or if we'll need another solution for expandables ( and javascript, or something?) @jackjia-ibm
Looking into adding a button look-and-feel to the expandable sections.

Signed-off-by: BrandonJenkins14<EMAIL_ADDRESS>

If no additional comments on this section, we could potentially merge my initial changes in and publish, then open a separate issue for  improving the look and feel of the expandable sections.
I can imagine other scenarios where we might want buttons in the doc (click here to learn about option A, or here to learn about option B), and/or more expandable sections. We can make the site a bit more interactive.

@BrandonJenkins14 This looks good to me. It is much improved and greatly reduces the length of the overview section. Do you want me to merge it?

@nannanli Thank you for the general review/approval. I will go ahead and merge it. Opening a separate issue to investigate improving the look of the buttons.


Update Friuli-Venezia Giulia source

This change updates the dataset and fields used for addresses in Friuli-Venezia Giulia, Italy.

Hey @iandees, the data for this source will need to be re-hosted.

I'm in progress on generating a form you can use to upload yourself.
In the meantime, can you make sure the process for generating the file you're asking to rehost is either in the scripts/ directory of this repo or described in detail here?

Awesome, thanks - I can give the form a try once it becomes available. The process for generating the file is as follows:

Navigate to https://www.dati.friuliveneziagiulia.it/Regioni-e-citt-/Numeri-Civici-Ascot/fcre-uegn
Click on the "Esportazione" button
Select the CSV file download option
Create new X (lon) and Y (lat) fields in the csv. This can be done in QGIS by:

importing the csv as a new layer using the "Add Delimited Text Layer..." option
right-clicking on the layer and selecting the the "Export > Save Features As..."  option
selecting the "AS_XY" option under Geometry

The zip file has been re-hosted and the data url has been updated.

The build error here is from broken MVTs from Mapbox.


TrashSlot not loading

I'm using your TrashSlot mod for my pack. Looking at the log, it seems to be present, but it does not load (see screenshot below).

OS: Linux Mint 19.3
Minecraft: 1.15.2
Forge version: 31.1.88
TrashSlot_1.15.2-11.0.0

https://paste.ee/p/qLgWO

There's a keybind to toggle it, it's probably toggled off right now.

Yup, that was it. Thanks!


Removed Duplication in ObjectiveClass

The code was created for the sole purpose of showing my students, that they should think on their own instead of following thought leaders and popular bloggers, as they, while being popular, still are human and sometimes don't write that great or just plain bad and dirty code. The code prior to the pull request is a perfect example of such code because of the excess amount of duplication.
The secondary aim of refactoring was to show my students, how to use some unobvious ways of handling functions in swift, when using unsafe force-cast related code.
I've created this pull request just to check, how hacktoberfest (I really want that t-shirt, yay) reacts to rejected or ignored pull requests, as original maintainer, from what it looks, ignores pull requests from other users.
P.S. I doubt the maintainer would merge the pull request, so I didn't update to Swift 4. If accept happens for some weird reason, I would refactor it to swift 4 with pleasure.

Update in case you wonder, hacktoberfest accepts pending requests. The next step is the pull-request rejection.

@marmelroy Please, note the build failure because of code signing failure. Won't be able to fix it on my end, as I double checked and I didn't change any certificates and such.

@marmelroy Please, note the build failure because of code signing failure. Won't be able to fix it on my end, as I double checked and I didn't change any certificates and such.


Miscellaneous improvements to the clustermesh upgrade/downgrade test

Slow down agent rollout to better highlight possible issues;
Hard-code IPAM mode and operator replicas to prevent changes due to defaulting;
Fix incorrectly named test to ensure that it is actually executed.

/test

/test

Sorry @viktor-kurchenko, I've pushed a couple of additional minor changes. Could you please take another look?


Qestion: subscription to other devices node's properties

Is it possible for a device 'A' to subscribe to a property of a node of a device 'B'?
thank you
Before submitting your issue, make sure:

[ ] You're using a stable release, not the Git development version which is, by definition, unstable
[ ] You've read the documentation for your release, which is in the docs/ folder of the .zip of the release you're using, especially the Getting started and Troubleshooting pages, which contain respectively the minimum required version of the dependencies, and some answsers to the most common problems
[ ] You're using the examples bundled in your release, which are in the examples/ folder of the .zip of the release you're using. Examples in the latest git revision might not be backward-compatible with your release

Thanks!

I believe the response will be to use something like NodeRed+MQTT

thank you n8twj.
I tried
AsyncMqttClient& mqttClient = Homie.getMqttClient();
...
void onMqttMessage(char* topic, char* payload, AsyncMqttClientMessageProperties properties, size_t len, size_t index, size_t total) {
  Serial.println("** Publish received **");
  Serial.print(" topic: ");
  Serial.println(topic);
  Serial.print("payload: ");
  Serial.println(payload);
}

void onHomieEvent(const HomieEvent& event) {
  switch(event.type) {
   case HomieEventType::MQTT_CONNECTED:
    uint16_t packetIdSub = mqttClient.subscribe("my/topic/here", 0);
    Serial.print("Subscribing at QoS 0, packetId: ");
    Serial.println(packetIdSub);
    break;
  }
}

void setup() {
...
  Homie.onEvent(onHomieEvent);
  mqttClient.onMessage(onMqttMessage);

  Homie.setup();
}

and it works fine.


reafctor: Language toggle and en.json and he.json on cheage Language

Description

screenshots

this is my fust pull
סליחה על הטעיות אשמח לשמוע הערות

i thought about moving it next to the icons on the top of the page and change it to the shape of a flag

@zushar good idea :muscle:


bdjuno start return error: ERROR: failed to start client: Not Found

I setup and run bdjuno following the doc. When I run bdjuno start, I got an error: ERROR: failed to start client: Not Found.
My steps:

run bdjuno init and got config.yaml inside ~/.bdjuno folder
I copied the genesis.json file to ~/.bdjuno folder
I run bdjuno parse genesis-file --genesis-file-path ~/.bdjuno. Nothing happened, no new file created
I run bdjuno start and got the error
I change some config about config.yaml
chain:
bech32_prefix: cosmos
modules: []
node:
type: remote
config:
rpc:
client_name: juno
address: http://<IP_ADDRESS>:26657
max_connections: 20
grpc:
address: http://<IP_ADDRESS>:9090
insecure: true
http://<IP_ADDRESS>:26657 can be accessed
and  grpc address is changed from localhost:9090 to <IP_ADDRESS>:9090 in app.toml
Is that a bug? or I do something wrong.Please help me.

I found the solution


Another great issue to solve

Come get the reward!

@quest-bot stash 200

@quest-bot raid

@quest-bot reward @nickdiaconou

Testing images in comments...

https://upload.wikimedia.org/wikipedia/commons/b/b0/NewTux.svg
Testing svg embed

https://quine.sh/images/quine-logo.svg
Testing sag embed

 You spot someone...

 - Dragons!

 - Embark

 - bugs

 - A plague of locusts has infested https://github.com/nick-corp’s repo
Merge a PR that solves this issue to find a cure and get rid of these bugs. Loot of 100 USD has been stashed in this issue to reward the solver!
🗡 Comment @quest-bot embark to check-in for this Quest and start solving the issue. Other solvers will be notified!
⚔ When you submit a PR, comment @quest-bot loot #31 to link your PR to this Quest.
Questions? Check out the docs.

 - A plague of locusts has infested https://github.com/nick-corp’s repo
Merge a PR that solves this issue to find a cure and get rid of these bugs!
 - Loot of 100 USD has been stashed in this issue to reward the solver!
🗡 Comment @quest-bot embark to check-in for this Quest and start solving the issue. Other solvers will be notified!
⚔ When you submit a PR, comment @quest-bot loot #31 to link your PR to this Quest.
Questions? Check out the docs.

 -  A sorcerer...

Quest Solved!
Congratulations @nickdiaconou!
Your PR has spread the potion all around the village. The locusts have flown out of town ⛅
They have been victorious in Quest #{31} 🗡
💰 To claim your $100 reward follow instructionshere
🧚 Thanks to all bold adventurers for your efforts! Sign-up to Quine.sh to access more exciting Quests like this one ⚔
This Quest is now closed ✨
Questions? Check out the docs.


Testing

Testing

@benlaurete Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

@benlaurete Please use your own fork to experiment with github’s PR features.


Flags for staged package object storage

@larioj I'll take a look tomorrow morning.

@jsancio and I had a conversation about the flags and we decided that the flags should be an S3 uri or a file URI. For example the packageStagingUri should be either s3://bucket/path or file://path. Similarly for the final storage location


rg/ripgrep update 14.1.1

Command
rg
Version
14.1.1
Release
https://github.com/BurntSushi/ripgrep/releases/tag/14.1.1
Changelog
No response
Anything else?
I needed a completer to nushell so I am trying carapace. I usually alias rg to rg --hyperlink-format=kitty and found completion doesn't work because that flag is not defined in rg_completer. So, I added it among other flags and improved things a bit with PR #2617
However, I have some questions:
First, is there a way for carapace to just ignore missing flags?
Second, rootCmd.Flags().BoolP("case-sensitive", "s", false, "Search case sensitively.") is using false as the default value though the default for rg search is case-sensitive, so I changed it to true. How is this going to affect autocomplete practically? Afterall, the default behavior is defined by ripgrep not by the value stated here.
Third, it seems like Bool() and BoolP() would allow --case-sensitive=<TAB> to give two values true and false which is wrong because this is a toggle flag that doesn't accept a value. I kept the patch simple and followed the current procedure but not sure whether this is the correct way to handle it.

Polar

First, is there a way for carapace to just ignore missing flags?

With CARAPACE_LENIENT, but that has some implications.
For unknown flags it can't be determined if they take an argument, so they are just handled as bool.
This is a generic change so an overlay might provide a better alternative.
But both should be seen only as temporary workarounds.

Second, rootCmd.Flags().BoolP("case-sensitive", "s", false, "Search case sensitively.") is using false as the default value though the default for rg search is case-sensitive, so I changed it to true. How is this going to affect autocomplete practically? Afterall, the default behavior is defined by ripgrep not by the value stated here.

Defaults aren't really relevant for the external completer unless they are used in a contextual completion.
In most cases they are currently left out. Doesn't hurt to add them though.

Third, it seems like Bool() and BoolP() would allow --case-sensitive= to give two values true and false which is wrong because this is a toggle flag that doesn't accept a value. I kept the patch simple and followed the current procedure but not sure whether this is the correct way to handle it.

Current behaviour of carapace is to provide completions as cobra can parse them.
There are indefed differences between commands (e.g. for some the attached variant is mandatory).
At the moment there is no way to enforce a specific behaviour, but rather left to the user to know about a commands unique requirements.

Thanks for the clarifications and merging. Closed with fix #2617


fix typo/misspelling in locale_de-DE.ini

this pr fixes a small typo in the german language file locale_de-DE.ini

@SimonWaldherr sorry only changes to https://github.com/go-gitea/gitea/blob/master/options/locale/locale_en-US.ini are valid :/
It would be nice if you can correct this on crowdin :)

@6543 thanks. Done.


Style fix

Good morning!

Morning. How can I be of service?

Right now there is nothing todo but as soon as something pops up I let u know


Installation Failed: Unable to load valid module manifest data from (Github url)

Cannot install this module from within foundry vtt in update 10.284

Yeah, version 9.280 here, same problem, for the 9.280 I think the correct link would be:
"https://raw.githubusercontent.com/misthero/dnd5e-custom-skills/v1.0.8/module.json"
But even using this one it instantly goes 100% but then get stuck on 100% forever, I also tried installing it with the zip version but then it doesn't show up, I think I might have another bug report, but I'll try and test it on 1.0.8 first when I'm able to get it

If you want a work around for it, go to the FoundryVTT page of the module, go over the version 1.1.0 which is the compatible one for v10 and click over "Manifest URL"

Search for this in the page that it opens up

And click over "Raw"

This screen should open up, get the download link, just download it, open up the rar, then the folder inside of it, and then you should go to your Foundry Modules folder, find the module folder, open it and then drag the following files from the zip to the folder:

The path to the module folder should be at AppData\Local\FoundryVTT\Data\modules\dnd5e-custom-skills

sorry guys, I've messed up the v1.0.8 manifest, should be fixed now


Refactor for PSR-2 and packagist indexing

I think you may want to check whether the examples are running correctly with your modifications. Nevertheless, thanks for the great work! I've been waiting to make this thing autoload for a long time. :)

Changes OK, ready to merge.


Script to create missing Feedback PRs

As outlined in the AI24 p2 repo a  current bug with GitHub Classrooms prevents the feedback PRs from being made successfully.
We need a script to check repos to see if they have it, then create it if necessary. This also means we need to create a branch at the original commit of the repo - luckily has a consistent SHA for every fork of a given project.

First pass completed - note this requires the SHA to be hardcoded in BASE_SHA

this is awesome @AndrewPaulChester , so we can run it on P2 beforehand to make sure all Feedback branches and PR are there...

OK, I have added the SHA as argument to the script.
Now, it is not checking that the feedback PR already exists but they close it. I think we need to check for PR #1 and see if it exists, that is the one GH Classroom creates. Similar to the script I have to find closed PRs.. for example this one says it is missing but it is just closed:
https://github.com/RMIT-COSC1127-1125-AI24/p2-multiagent-K-Niva/pulls

It should not just be checking to see if they are closed, but I didn't test extensively. Perhaps it needs an argument to get any pr regardless of status? That repo is interesting because they have actually deleted the feedback branch entirely.

From: Sebastian Sardina @.>
Sent: Friday, August 30, 2024 5:39:04 PM
To: ssardina-teaching/git-hw-submissions @.>
Cc: Andrew Chester @.>; Mention @.>
Subject: Re: [ssardina-teaching/git-hw-submissions] Script to create missing Feedback PRs (Issue #22)
OK, I have added the SHA as argument to the script.
Now, it is not checking that the feedback PR already exists but they close it. I think we need to check for PR #1https://github.com/ssardina-teaching/git-hw-submissions/issues/1 and see if it exists, that is the one GH Classroom creates. Similar to the script I have to find closed PRs.. for example this one says it is missing but it is just closed:
https://github.com/RMIT-COSC1127-1125-AI24/p2-multiagent-K-Niva/pulls
image.png (view on web)https://github.com/user-attachments/assets/9095fab4-c21b-4007-bc3f-6c50473d3356
—
Reply to this email directly, view it on GitHubhttps://github.com/ssardina-teaching/git-hw-submissions/issues/22#issuecomment-2320358290, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ALRW5XL5RUAFRVNGZXNPPALZUAORRAVCNFSM6AAAAABNJWONQ2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRQGM2TQMRZGA.
You are receiving this because you were mentioned.Message ID: @.***>

yes I know how to improve it, I am half way no worries

done, it can also find the merged PRs


Refactor NEAR amounts formatting

near-api-js now has the utils for this: https://github.com/near/near-api-js/blob/master/src/utils/format.ts

@frol is this issue still relevant?


drag events dataTransfer is undefined in RC5 alpha 7-2 with NgModule imports

Bug, feature request, or proposal:
Bug: Since adding in Md*Module(s) and hammerjs, drag events no longer contain the dataTransfer property.
browser_adapter.js:84 TypeError: Cannot set property 'effectAllowed' of undefined
    at DraggableDirective.onDragStart (draggable.directive.ts:9)
    at DebugAppView._View_BusinessObjectFieldsListComponent1._handle_dragstart_0_0 (BusinessObjectFieldsListComponent.ngfactory.js:238)
    at view.js:381
    at dom_renderer.js:255
    at hammer_gestures.js:68
    at ZoneDelegate.invoke (zone.js:323)
    at Object.onInvoke (ng_zone_impl.js:53)
    at ZoneDelegate.invoke (zone.js:322)
    at Zone.runGuarded (zone.js:230)
    at NgZoneImpl.runInnerGuarded (ng_zone_impl.js:86)

This did not happen when directly using the Md* components in our components.  Once we added the Md*Module(s) to NgModule and installed hammerjs this error arose.
What is the expected behavior?
drag events should have the dataTransfer property to be able to pass data in the dropped element
What is the current behavior?
error above
What are the steps to reproduce?
(I'm working on it, but can't figure out how to get ng2 rc5 and md alpha7-2 all in the same plunker...)
Plunker template: http://plnkr.co/edit/o077B6uEiiIgkC0S06dd
Which versions of Angular, Material, OS, browsers are affected?
Angular 2 RC5
Material alpha 7-2
hammerjs 2.0.8
Windows 8.1
Chrome and FF latest
Is there anything else we should know?
It's worth noting that this error occurs in a component with NO MD components in use.  But it only happens if we NgModule import the MD components (needed elsewhere in the application).  It doesn't make sense, but our draggable div isn't an md-* component!  But if I remove them from NgModule imports I can drag it!

+1 hammerjs is overriding the original drag events with no way to access the original event.

Why are "drag", "dragstart" and "dragend" being created as custom events, when they are native events?
https://github.com/angular/material2/blob/master/src/lib/core/gestures/MdGestureConfig.ts
Unless I missed something I don't think "drag", "dragstart" or "dragend" are being used in any component yet.
Thanks in advance :-)

We removed dragstart and dragend, but we should also remove drag from gesture config.
https://github.com/angular/material2/blob/b09465cda7cf8c74a5c903ee49d0366d644643d4/src/lib/core/gestures/MdGestureConfig.ts#L10-L10


Tables support

Hi @thetarnav ,
Great project, I am really eager to use it in my platform to implement streaming animation as in perplexity. However we make heavy use of tables to render data, and can i ask you when is it expected to have first version that support tables even in very basic way, i can help if you wish, if the infrastructure needed are there. Thanks again.

I don't have plans to do it now so I cannot give you a timeline.
You're welcome to take a stab at it if you want.
Not sure what do you mean with infrastructure.
I think the syntax could be supported, but it is a complex one so something might be necessary to change. Like the idea to keep the token enum as an bitset would have to probably be changed as I'm running out of bits, and there is not much benefit to it either.

I don't have plans to do it now so I cannot give you a timeline.
You're welcome to take a stab at it if you want.
Not sure what do you mean with infrastructure.
I think the syntax could be supported, but it is a complex one so something might be necessary to change. Like the idea to keep the token enum as an bitset would have to probably be changed as I'm running out of bits, and there is not much benefit to it either.

By infrastructure i mean, if i can resuse some existing markdown features that already implemented, and just modify a code a bit to make it work at this point i only care about the table itself with some cells, it doesn't need to be comprehensive to support differentiation between th and td for now. And i will take care of styling in css. Any idea how can i do that ? Or weather it is possible at all without major changes in the parser ?


how about file uploads?

can we do file uploads with useMutation?

Sure you can. I am uploading images using a mutation by converting the images to base64 first.


call read ('classpath:   not working

Not able to read the classpath file ... I tried without classpath , by giving directly ...
I m getting post response where Authorization is null/.
response :
Accept: /
1 > Accept-Encoding: [gzip, deflate, br]
1 > Authorization: null
1 > Cache-Control: no-cache, no-store
1 > Connection: keep-alive
Feature: signup post call with access token
Background:
* url 'https://adbjkasbjksab.com'
* configure ssl = true
* def jsonp = read('../datafolder/payloadrequest.json')
* def tokens = call read ('classpath: auth/Authentication.feature')
* def authToken = tokens.accessToken
Scenario: create sign up
  Given path 'api/individuals'
  And request jsonp
  And header Accept = '*/*'
  And header Authorization = authToken
  And header Content-Type = 'application/json'
  And header Accept-Encoding = 'gzip', 'deflate', 'br'
  And header Connection = 'keep-alive'
  And header Cache-Control = 'no-cache, no-store'
  When method POST
  Then status 200
  Then print 'response---',response

below is working fine , getting access token
Feature: Generate Auth token and use this as a reusable feature
Background:
* url 'https://dontwanttoreveal/oauth2/token'
Scenario: Get oath token
* form field grant_type = 'client_credentials'
* form field client_id = 'dontwanttoreveal'
* form field client_secret = 'dontwanttoreveal'
* method post
* status 200

* def accessToken = 'Bearer ' + response.access_token
* print accessToken

follow this process: https://github.com/intuit/karate/wiki/How-to-Submit-an-Issue


Traits for electric consumption report for outlet?

Is there a traits for this? I can't find one . Thanks

Do you mean EnergyStorage?

No. EnergyStorage is based on battery right ? but in the consumption. We
want to see how much electricity is used in the specific outlet . like for
the consumption report . how much kilowatt_hour this specific outlet is
used for a day , for a week or for a month. We are building an outlet with
that, so the users can see how much they need to pay with each outlet .
Thanks
On Tue, Dec 15, 2020 at 2:18 AM Nick<EMAIL_ADDRESS>wrote:

Do you mean EnergyStorage
https://developers.google.com/assistant/smarthome/traits/energystorage?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/actions-on-google/smart-home-nodejs/issues/525#issuecomment-744620816,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHOMQBHHLLYRQAIX3ZSEXYLSUZJJBANCNFSM4U2IQQZA
.

This issue tracker is for filing developer bugs and feature requests with the content of this GitHub repository (Smart Home Node.js sample).
For filing developer bugs and feature requests with the Actions on Google Smart Home platform, please follow https://developers.google.com/assistant/smarthome/support.
Thanks in advance.

This issue tracker is for filing developer bugs and feature requests with the content of this GitHub repository (Smart Home Node.js sample).
For filing developer bugs and feature requests with the Actions on Google Smart Home platform, please follow https://developers.google.com/assistant/smarthome/support.
Thanks in advance.


Compiler: emit simpler debug info for code generated by macros

Fixes what's mentioned in this comment
I chose to expand locations that are inside macro expansions to the location where the macro is expanded, for debug info. That means that for this code:
macro foo
  a = 1
  a += 2
  puts a
end

foo

the debug info for all the contents of the expansion of foo will be at the line where foo is invoked (here, filename "foo.cr", line 7, column 1).
A more correct solution to this, which is removed in this PR, is to generate temporary files for each macro expansion, and use that temporary file name in the debug info. The problems with this approach are:

It's hard to name these filenames so that previous compilation info (.bc, .o) can be reused. Maybe we can use a hash of the macro content, but maybe doing so will be a bit slow.
It fills the cache directory with these temporary files (maybe not that problematic)

I also copy this comment I left in the code:
# We should have expanded locations with VirtualFiles in them to
# the location where they expanded. Debug locations will point
# to the single line where the macro was expanded. This is not
# convenient for debugging macro code, but the other solution
# involves creating temporary files to hold the expanded macro
# code, but that prevents reusing previous compilations. In
# any case, macro code *should* be simple so that it doesn't
# need to be debugged at runtime (because macros work at compile-time.)

We can leave a better solution for this problem, if the need arrives, for later. For now it's better to have faster compile times than to be able to debug code produced by macros.
/cc @ysbaddaden

Oops, I had other commits too. I rebased now.

AFAIK this only applies to backtraces at runtime, right? It doesn't affect debugging of macros at compile time? If so, then this looks like an okay solution.

@ysbaddaden Yes, that's the case :-)


[Feature] scheduled jobs, workflows, and incremental learning

Search before asking

[X] I had searched in the issues and found no similar feature requirement.

Description
does (kube)ray support scheduled jobs (e.g. through cronjobs)?
is it possible to chain different jobs/pipelines together, e.g. when a deployed modelA returns a specific value, then start a training pipeline for another model and so on. as in, is there the concept of workflows in ray?
is there any incremental (online) learning model implementation in ray library and if so, how to distribute it and checkpointing it ?
Use case
No response
Related issues
No response
Are you willing to submit a PR?

[ ] Yes I am willing to submit a PR!

I can't comment on workflows for Ray, but cronjob-like feature for KubeRay with RayJob seems like reasonable feature request


FIX-#4835: Handle pathlib.Path properly in read_parquet

Signed-off-by: Karthik Velayutham<EMAIL_ADDRESS>
What do these changes do?

[x] commit message follows format outlined here
[x] passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
[x] passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
[x] signed commit with git commit -s
[x] Resolves #4835
[x] tests added and passing
[x] module layout described at docs/development/architecture.rst is up-to-date
[x] added (Issue Number: PR title (PR Number)) and github username to release notes for next major release

This PR addresses this specific case, but I think I need to make this more generalizable to anything that is PathLike.


How to constrain which positions allowed in Flex

Hi - I'm referring to Draftkings NFL. I've loaded my metrics into the optimizer and it appears that every flex player is a TE in the output. I'm not sure how I can apply a constraint here to allow only WR, RB, in Flex, or just WR in Flex, etc. Thanks

Hi, you can't exclude specific position from UTIL choices, maybe I will add this feature in next release. For now you can only set one specific position that will be used for UTIL using this method optimizer.set_players_with_same_position({'WR': 1})


Update template.yaml, change upper case to lower case for element ID

ID: XMM-1  ->    Id: XMM-1
ID: XMM-2 ->     Id: XMM-2

Please commit to master branch

Please approve


Fix header installation path

Do not install the headers in /usr/include/dragonbox-1.1.3/dragonbox but install them in /usr/include/dragonbox.

Thanks for the PR and sorry for the delay.
I am currently not sure what is the common best practice, to include the version, or to not include the version. Do you have some other reference projects that I can look at?

Sorry @danyspin97, I concluded that having an extra directory is a good thing, because it prevents people from accidently including the library without being explicit about using it. Adding the right include directory should not be a big issue for any build system you use I guess. So I close this PR.

The problem is not the depth of the directory structure, but that the install location changes depending on the version used.
Having different directories for different major versions (e.g. version 1, version 2) is common practice, but not for minor versions when one uses semantic versioning.

@ecorm Thanks for the input. Do you know of some references that I can have a look at?

@jk-jeon I don't have a reference off the top of my head to give you. Certainly not Ryu, as they messed things up like having really short function names in the global namespace, and also perhaps macros without a prefix to help avoiding clashes with other library/application macros.
I'll see if I can find a reference/example and will get back to you.

@ecorm Thanks a lot. I think this provides the rationale behind the practice I got to follow. Note that the one who opened that issue is the one who wrote the CMake script of this project.

I think https://github.com/Dobiasd/FunctionalPlus/issues/222 provides the rationale behind the practice I got to follow.

I don't agree with their approach, and it goes against the convention in Linux. Let's say I have an open-source library that depends on dragonbox. I don't want to impose which version of the dragonbox my users must have on their system, except for the major version (that is 1.x.x or 2.x.x). Let's say in my hypothetical library, I only impose major version 1 of dragonbox. If you follow the semantic versioning principle, then my users can supply any version 1.x.x of dragonbox, and my library should be able to compile with it, assuming it only uses features from the 1.0.0 release.
For example:
#ifndef MYLIBRARY_HPP
#define MYLIBRARY_HPP

#include <string>
#include <dragonbox/dragonbox.h>

// The following would be annoying to users who don't have the exact same version of dragonbox
// on their system. They would need to patch this source file!
// #include <dragonbox-1.1.3/dragonbox/dragonbox.h>

namespace mylib
{

inline std::string doubleToString(double x)
{
    constexpr int buffer_length = 1 + // for '\0'
        jkj::dragonbox::max_output_string_length<jkj::dragonbox::ieee754_binary64>;
    char buffer[buffer_length];
    return std::string(jkj::dragonbox::to_chars(x, buffer));
}

} // namespace mylib

#endif // MYLIBRARY_HPP

If my library depends on dragonbox 1.1 or later because of new features or bugfixes, that could be checked with version macros:
#ifndef MYLIBRARY_HPP
#define MYLIBRARY_HPP

#include <string>
#include <dragonbox/dragonbox.h>

#if JKJ_DRAGONBOX_VERSION_MAJOR != 1 || JKJ_DRAGONBOX_VERSION_MINOR < 1
    #error MyLibrary requires dragonbox 1.1 or later
#endif

Having dragonbox 1.1 or later installed could also be checked with my library's CMake script if dragonbox exports things correctly in its CMake scripts.
If you follow semantic versioning, and you release a version 2 of dragonbox where you allow yourself to break its API, then you should install it under a dragonbox2 subdirectory bu default so that it can co-exist with dragonbox version 1:
#ifndef MYLIBRARY_HPP
#define MYLIBRARY_HPP

#include <string>

#ifdef MYLIBRARY_USE_LEGACY_DRAGONBOX
#include <dragonbox/dragonbox.h>
#else
#include <dragonbox2/dragonbox.h>
#endif

If a developer needs to maintain multiple versions of dragonbox for different projects, they can use CMAKE_INSTALL_PREFIX to specify where dragonbox in installed:
cmake --install . --prefix /home/me/code/dragonbox-1.1.3

In the developer's CMakeLists.txt for their app, they can add /home/me/code/dragonbox-1.1.3 as an include search directory, and in their code they just need to do this:
#include <dragonbox/dragonbox.h>

Whenever you see

usr/include/somelib-1.1
usr/include/somelib-1.2

It's because the library didn't strictly follow the semantic versioning convention. Some apps/libraries in the system depend on the behavior of somelib v1.1 whereas others depend on the behavior of v1.2. If one is careful not to alter behavior within a major version, then any app should be able to use the latest version of somelib-1.x. Note that it's acceptable to add new features within a major version (this is where you'd increment the minor version), as long as it doesn't break code that was using the older minor versions. I don't normally consider fixing bugs to be "altering behavior". In those rare instances where an app depends on buggy behavior, you could allow the user to define a macro that re-enables the buggy behavior in later versions.
If the behavior of dragonbox can alter between minor versions (say, the decimal string output like removing trailing zeroes), and there's a chance that apps depend on that behavior, then there may be an argument for installing under usr/include/dragonbox-1.1. usr/include/dragonbox-1.2, etc as shown above. Having separate directories for patch versions (e.g. 1.1.2, 1.1.3, etc) is going too far, IMO.
Whenever you see

usr/include/somelib
usr/include/somelib-2

It means the library properly followed the semantic versioning convention where they only broke the API in major versions. Some system apps are relying on the old somelib, and others rely on somelib-2, the latter not having a backwards-compatible API with somelib version 1.

@ecorm I see what you mean.
For the first point about the Linux convention, I don't have much to say. There was a related comment on that in the issue thread I mentioned. At this point I'm not conclusive on this matter. I need to have some more research on this topic.
For the second point about the include directory, I think I'm not agreeing with you on it. I think deciding which version of library to include is basically the job of build system, not of source code. If the user correctly set up the include directory (which I believe should be automatic if the CMake script of this repo is written correctly), then the source code just need to have #include <dragonbox/dragonbox.h> regardless of the version it's willing to use.
Your suggestion about the possibility of coexistence of two different versions behind a macro switch seems tempting, but my gut feeling is that it is a brittle hack basically. Because, (1) we anyway need to have a single version of dragonbox across the whole project because otherwise it's an ODR time bomb waiting to explode, and (2) the way to have a single version across the whole project is to define that macro switch through the build system. In that case, it would be just better to write the build script correctly to find the right include directory, rather than to do some macro hack.
To be fair, we could also have an inline namespace to prevent the ODR issue, but anyway I feel uneasy about having multiple versions of the same library in a single project.

A note before continuing the discussion: dragonbox is now shipped in Linux distributions as it is a Libreoffice dependency.

For the first point about the Linux convention, I don't have much to say. There was a related comment on that in the issue thread I mentioned. At this point I'm not conclusive on this matter. I need to have some more research on this topic.

I think a quick inspection of /usr/include/ in a Linux distribution could be a good starting point. There is no package that is shipped with a bugfix version in the directory; the build system would have to change the version included every time there is a bugfix version update. This is not correct because the bugfix version update does not break the API/ABI, there is no need to depend on the bugfix version. Let's also consider that libreoffice has like 30 or more dependencies, if every library did the same as dragonbox it would not scale.
Having a major version like dragonbox-1/dragonbox.h would also be fine, but that's different than dragonbox-${version}/dragonbox/dragonbox.h. We can discuss more this option if you prefer, and I would also be open to help.

@danyspin97 Thanks for the reply. Would you mind opening an issue about this matter? I think it would be better to discuss further in an issue thread instead of a PR.
Anyway, here is what I think right now:

If it is currently not possible to set the install directory into /usr/include/dragonbox from the user's side (without a terrible hack and/or something very unconventional) , this should be considered a bug. I have to fix it.

If it is possible to do so, still we need to decide which one should be the default. This I think is something I need to have more discussion.


Badges, years using specific programming languages, etc.

First of all, congrats to all the developers of sourcerer. Excellent application. Anyway, the issue is the info I had in my badges is gone, and now I can only see "years using X" , etc., which is not compatible with the timeline charts. I.ex, the time line shows some of my python repos as far back as 2012, but the badges say that I have been using python for only 2 years, etc.

Hi @lmsanch. We slightly updated the formula for badges. Now it works with repositories of small teams too. I hope your profile looks better now.
Still investigating the issue with years.

Updated calculation of the number of years is in production.


Run CI testing inside docker containers

Follow up to the discussion in #294
@facaiy Let me know your thoughts on this setup. After we're in agreement we can request Amit to approve and modify anything on their side.

Just a note.. this would require:

Nvidia-docker to be installed on their GCP image
Requires a pass argument to run with python3


data table sort asc -> descending takes 3 clicks

Detailed description
there is always 3 state for sorting in the data table
how ever sort order doesn't seem to be replaced
Result is it takes 3 clicks to sort.
'application-header bx--table-sort-v2'
'application-header bx--table-sort-v2 bx--table-sort-v2--active'
'bx--table-sort-v2--ascending'
You can see the behaviour when you

select sortable header
sort multiple times on active sort header

Describe in detail the issue you're having.

Is this a feature request (new component, new icon), a bug, or a general issue? general issue

Is this issue related to a specific component? DataTable

What did you expect to happen? What happened instead? What would you like to see changed?
sort get swapped per click

What browser are you working in? chrome

What version of the Carbon Design System are you using? 6.26.0

What offering/product do you work on? Any pressing ship or release dates we should be aware of?
transformation advisor

Steps to reproduce the issue

Step one
Step two
Step three
etc.

Additional information

Screenshots or code
Notes

Hi @lounestor! 👋 Thanks so much for taking the time to make this issue. Going to mark this as a duplicate of #1122, but feel free to comment if you feel like they are different!

@joshblack ya thats perfect sorry i missed that other related defect


[Discussion] Optional arguments for curried functions.

For Libraries optional arguments are widely used and I personaly often create functions that allow me to use a subset of possible arguments.
The flexibility and benefits of currying functions are also undeniable.
I wanted to curry the lodash debounce function, while preserving the possibility of not specifying the optional opions argument.
So I created the following curryShort function, that will shortcircuit and apply the arguments to the function when all conditions are met.
There are edge cases but its good enough as a proof of concept:
function testConditions(combined,conditions){
  return combined.reduce((acc,val,index)=>{
      return acc ||
        (conditions[index] && conditions[index](val))
    },false)
}

function _curryNshort(conditions, received, fn, length) {
  return function() {
    var combined = [];
    var argsIdx = 0;
    var left = length ;
    var combinedIdx = 0;
    while (combinedIdx < received.length || argsIdx < arguments.length) {
      var result;
      if (combinedIdx < received.length &&
          (!_isPlaceholder(received[combinedIdx]) ||
           argsIdx >= arguments.length)) {
        result = received[combinedIdx];
      } else {
        result = arguments[argsIdx];
        argsIdx += 1;
      }
      combined[combinedIdx] = result;
      if (!_isPlaceholder(result)) {
        left -= 1;
      }
      combinedIdx += 1;
    }
    var shortcircuit = testConditions(combined,conditions)
    var applyFunction = left <= 0 || shortcircuit
    return  applyFunction
      ? fn.apply(this, combined)
      : _arity(left, _curryNshort(conditions, combined, fn, length));
  };
}

var curryShort =  _curry2(function curryShort(conditions, fn) {
  var length = conditions.length
  if (length === 1) {
    return _curry1(fn);
  }
  return _arity(length, _curryNshort(conditions, [], fn, length));
});

This works identically like curryN, except it doesn't just look for how many arguments are missing,
but also checks if the shortcircuit conditions with testConditions are met if so, the arguments are applied.
conditions is an array of functions to test the arguments. Each condition function corresponds with the argument with the same index and will be called like so conditions[0](arguments[0]) etc.
The arity of the function to be curried is taken from the length of the conditions array.
Example:
// prints string, or adds two numbers
 var add_or_print = (x,y)=>{
   if(typeof x === 'string'){
     return x
   } else {
     return x+y
   }
}

var isString = x => typeof x == 'string'
var aop_conditions = [isString,null]
var aop = curryShort(aop_conditions,add_or_print)
console.log(aop(3)(2)) //shortcircuit conditions not met, expects second argument >>> 5
console.log(aop('love')) //shortcircuit conditions met, applies function >>>love

Would be glad to hear your thoughts :D
Link to playground: Playground

This is an interesting implementation.
While I can see the appeal, it doesn't feel to me like a good fit for Ramda.
Ramda tries to emphasize simplicity.  A function that does one thing is simpler than one which does different things depending upon how many argument we pass.  (The same can be said about the types of the arguments passed.  Ramda also works this way on types, but that is tempered by Ramda recognizing higher types such as Functor.)  While concerns about reasonable implementation have helped steer us away from trying to work with optional parameters, our worries about simplicity in these situations is even more important.
So if I were to try to curry lodash's debounce, I would probably prefer to create two separate function:
// TODO: better names?
const debounceComplete = (options) => (wait) => (fn) => _.debounce(fn, wait, options)

const debounceSimple = debounceComplete({
    leading: false,
    maxWait: Infinity, // Is this correct?
    trailing: true
})

I applaud you on your interesting approach.  But it would take a lot of convincing for me to be interested in including it in Ramda.

https://github.com/ramda/ramda/issues/2809

Prior to the implementation I think there should be a discussion on where a "curried function with optional parameters" sits in the ramda philosophy.
I personally have mixed feelings,
for instance, I also share the concern around the SRP expressed by @CrossEye...
with regards to your specific use case I'd rather expect something like what @CrossEye did:
const debounce = ({ leading = false, trailing = false, ...etc } = {}, wait = 0) =>
  (fn) => _.debounce(fn, wait, { leading, trailing, ...etc });

From a more generic standpoint,
I'd like to understand their possible uses cases and implications.
as an example, how would it play with such situations (repl)?
const title = R.prop('title');

const fn1 = title()
const fn2 = fn1()
const fn3 = fn2()

fn3({ title: 'Hello World' });

when would we draw the line and assume that a missing argument is optional?

One last point around baking conditions and function application all together,
you could achieve your add_or_print function with a little function composition instead:
const add_or_print = R.cond([
  [R.is(String), R.identity],
  [R.T, R.add]
]);

add_or_print('hello');

add_or_print(3, 5);

When i posted it I was more curious about could and how then the should and why. For instance I am now intrigued by building a curryX.  It would be a higher order function of curryN since, curryN's condition is simply the amount of arguments.
curryX would function as a collector of arguments, and arbitrary conditions could be imposed on when to finally apply the function.
curryN = curryX(N => arguments => arguments.length == N)

In that sense it would be a purer form of currying because it's not bound by one simplistic condition, but could be wielded in various different forms.
from then on you could have
curryString, curryNull, curryFalsey
It could go on for hundreds of calls
buffer('0101010'),buffer('1110101'),....,buffer('1110101')
var message = buffer('parse')

Of course the API for creating arbitrary currying functions out of curryX would make or break it.  (is it still currying?😅)
Well so much for the theory and possibilities.

I'd love to see where you go with that, but I think we're drifting ever further away from Ramda's domain.
Please, if you do develop that, share it.  I'd love to see how it comes out.

As for adding it to Ramda, I'm certainly not pushing it, it's more of a thought experiment.
If possible I would rather publish it as a ramda plugin and let people find useful pattern., I am not sure if it would be possible to use core Ramda functions in a plugin without duplicating code. #Todo
As to a libraries philosophy:

The library should empower users by providing robust code which solves coding problems.
A well thought out API makes the library cohesive, intiuitive and easier to learn.

These are rules imposed on the library itself and it's code and none of them should impose it's rules also on the users code.
Further I would like to illustrate that the mentioned concerns for simplicity are the same as with regular currying. Since curryN is a subset of curryX they share the same uncertainties.
curryN is familiar to a FP, yet for a OOP this would be a wild and confusing idea.
I think the same goes for curryX, curryN's condition for argument.length is in a grander scheme as arbitrary as any other condition.
var printN = curryN(2,printMany)
var printX= curryX(R.is(String), printMany)

var helloN = printN('Hello ') // only called once. this is still a function
var helloX = printX('Hello ') // only called with strings. this is still a function

var textN = helloN(3) // second argument. function returns.
var textX = helloX(3) // non string argument. function returns.

log(textN) >>> "hello hello hello"
log(textX) >>> "hello hello hello"

Im trying to illustrate that:

For both methods the programmer has to keep in mind if the condition for the function to return has been met. - It doesn't really matter what the condition is.
For both methods the programmer has to keep in mind the correct type of argument.
String -> Number -> String

The only difference really is the condition at which ithe functions return.
Which in my opinion cant possibly be more confusing than the placeholder value R.__
Thank you and sorry for reading this wall 😅😂


restoration_video_demo.py does not produce any output

I would like to test the demo script.
command  is below.
python demo/restoration_video_demo.py ./configs/restorers/basicvsr/basicvsr_vimeo90k_bi.py https://download.openmmlab.com/mmediting/restorers/basicvsr/basicvsr_vimeo90k_bi_20210409-d2d8f760.pth [folder for input frames] [output folder]
Input size is 1920x1280 and the image file format is %08d.png
after printing below messages, model does not produce any output. 2G is allocated for Gpu memory.
**The model and loaded state dict do not match exactly
missing keys in source state_dict: step_counter**
Anything I am missing?

Turns out if you have too many frames in the input folder, it might take a while.
testing just 10 frames worked.
Is Multiple gpu testing enabled?

Hello,
You can check if --window-size or --max-seq-len helps.
https://github.com/open-mmlab/mmediting/blob/master/demo/restoration_video_demo.py

Do you have any other idea if setting --max-seq-len to a low value doesn't help with 4K images? I use a 16Gb RAM GPU.

If you don't mind writing some codes, an idea is to dig into the forward function of BasicVSRNet and decompose the flow computing, forward propagation, backward propagation, and upsampling steps.
You can try to break the for loop, cache some intermediate tensors to CPU memory or hard drive, and then proceed to the next steps. So hopefully, the GPU memory contains only features of one single frame, which will be a much little burden.

Another way is to separate the images into patches. It can be achieved by going into the forward of BasicVSRNet and using an additional for loop. But this could results in discontinuities in patch boundaries.

Closing due to inactivity, please reopen if there are any further problems.


google music doesnt show up in apps list on marshmellow

I've installed logged into lastfm and rebooted.
I'm on an axon 7.

It shows up as "Android Music Player" Apps

@HumbleBeeBumbleBee No apps show up besides spotify. This is while I'm playing music on the google music app.

When listening with Google Play Music, "Android Music Player" appears in the list, but is listed as uninstalled. No music is detected, and no scrobbles are cached. (Android 7.1)

@earfolds Have you tried disabling power saving for Simple Last.fm Scrobbler and GPM ?


Update notebook.sh

Fixes #43: Do not generate PEM_FILE when USE_HTTP=1 (i.e., no HTTPS support requested).

Make a rapid PR for this bug for one of the notebook.sh.

Looking good, thanks!


fix(SettingDialog): use value instead of selected props in

avoid the browser console warning in devServer mode

Thanks


Cannot Build the Unet Model -Help

python convert_unet.py --ckpt_path "H:\ComfyUI\models\checkpoints\SDXL\turbovisionxlSuperFastXL_tvxlV431vae.safetensors" --batch_max 4 --height_min 512 --width_min 512 --height_max 1024 --width_max 1024 --token_count_max 300
warnings.warn(warning)
ERROR:root:Exporting to ONNX failed. ONNX export failed on an operator with unrecognized namespace xformers_flash::flash_fwd. If you are trying to export a custom operator, make sure you registered it with the right domain and version.
Building TensorRT engine… This can take a while.
Building TensorRT engine for H:\ComfyUI\custom_nodes\comfy-trt-test\comfy_trt\Unet-onnx\sd_xl_turbo_1.0_fp16.onnx: H:\ComfyUI\custom_nodes\comfy-trt-test\comfy_trt\Unet-trt\sd_xl_turbo_1.0_fp16_1a54828ff58cb83ba8972aa17e71bd66.trt
Could not open file H:\ComfyUI\custom_nodes\comfy-trt-test\comfy_trt\Unet-onnx\sd_xl_turbo_1.0_fp16.onnx
Could not open file H:\ComfyUI\custom_nodes\comfy-trt-test\comfy_trt\Unet-onnx\sd_xl_turbo_1.0_fp16.onnx
[E] ModelImporter.cpp:773: Failed to parse ONNX model from file: H:\ComfyUI\custom_nodes\comfy-trt-test\comfy_trt\Unet-onnx\sd_xl_turbo_1.0_fp16.onnx
[!] Failed to parse ONNX model. Does the model file exist and contain a valid ONNX model?

u r sure about that console message output ? the input model is turbovisionxlSuperFastXL_tvxlV431vae.safetensors but the message is about sd_xl_turbo_1.0_fp16

Same message. Sorry was so tired. Tried different turbo models, with the same result.
Building TensorRT engine for H:\ComfyUI\custom_nodes\comfy-trt-test\comfy_trt\Unet-onnx\sd_xl_turbo_1.0_fp16.onnx: H:\ComfyUI\custom_nodes\comfy-trt-test\comfy_trt\Unet-trt\sd_xl_turbo_1.0_fp16_1a54828ff58cb83ba8972aa17e71bd66.trt
Could not open file H:\ComfyUI\custom_nodes\comfy-trt-test\comfy_trt\Unet-onnx\sd_xl_turbo_1.0_fp16.onnx
Could not open file H:\ComfyUI\custom_nodes\comfy-trt-test\comfy_trt\Unet-onnx\sd_xl_turbo_1.0_fp16.onnx
[E] ModelImporter.cpp:773: Failed to parse ONNX model from file: H:\ComfyUI\custom_nodes\comfy-trt-test\comfy_trt\Unet-onnx\sd_xl_turbo_1.0_fp16.onnx
[!] Failed to parse ONNX model. Does the model file exist and contain a valid ONNX model?
Traceback (most recent call last):
File "H:\ComfyUI\custom_nodes\comfy-trt-test\convert_unet.py", line 141, in
ret = export_trt(trt_path, onnx_path, timing_cache, profile=profile, use_fp16=not args.float32)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ret = engine.build(onnx_path, use_fp16, enable_refit=True, timing_cache=timing_cache, input_profile=[profile])                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "H:\ComfyUI\custom_nodes\comfy-trt-test\comfy_trt\utilities.py", line 151, in build
network = network_from_onnx_path(onnx_path, flags=[trt.OnnxParserFlag.NATIVE_INSTANCENORM])
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "", line 3, in network_from_onnx_path
File "C:\comfyVENV\Lib\site-packages\polygraphy\backend\base\loader.py", line 40, in call
return self.call_impl(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\comfyVENV\Lib\site-packages\polygraphy\util\util.py", line 710, in wrapped
return func(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^
File "C:\comfyVENV\Lib\site-packages\polygraphy\backend\trt\loader.py", line 227, in call_impl
trt_util.check_onnx_parser_errors(parser, success)
File "C:\comfyVENV\Lib\site-packages\polygraphy\backend\trt\util.py", line 86, in check_onnx_parser_errors
G_LOGGER.critical("Failed to parse ONNX model. Does the model file exist and contain a valid ONNX model?")
File "C:\comfyVENV\Lib\site-packages\polygraphy\logger\logger.py", line 605, in critical
raise ExceptionType(message) from None
polygraphy.exception.exception.PolygraphyException: Failed to parse ONNX model. Does the model file exist and contain a valid ONNX model?

seem like problem with turbo, u may want to try other models not turbo, there's already another problem with turbo in #4
i may need to remove turbo from supported list

what onnx version and tensorrt version u have ?

what onnx version and tensorrt version u have ?

No luck with other SDXL Models.
C:\comfyVENV\Lib\site-packages\torch\onnx\utils.py:737: UserWarning: We detected that you are modifying a dictionary that is an input to your model. Note that dictionaries are allowed as inputs in ONNX but they should be handled with care. Usages of dictionaries is not recommended, and should not be used except for configuration use. Also note that the order and values of the keys must remain the same.
warnings.warn(warning)
ERROR:root:Exporting to ONNX failed. ONNX export failed on an operator with unrecognized namespace xformers_flash::flash_fwd. If you are trying to export a custom operator, make sure you registered it with the right domain and version.
ONNX file has been saved to disk.
H:\ComfyUI\custom_nodes\comfy-trt-test....\comfy\ldm\modules\diffusionmodules\openaimodel.py:844: TracerWarning: Converting a tensor to a Python boolean might cause the trace to be incorrect. We can't record the data flow of Python values, so this value will be treated as a constant in the future. This means that the trace might not generalize to other inputs!
assert y.shape[0] == x.shape[0]
ERROR:root:Exporting to ONNX failed. ONNX export failed on an operator with unrecognized namespace xformers_flash::flash_fwd. If you are trying to export a custom operator, make sure you registered it with the right domain and version.
Building TensorRT engine… This can take a while.
Building TensorRT engine for H:\ComfyUI\custom_nodes\comfy-trt-test\comfy_trt\Unet-onnx\albedobaseXL_v20.onnx: H:\ComfyUI\custom_nodes\comfy-trt-test\comfy_trt\Unet-trt\albedobaseXL_v20_1a54828ff58cb83ba8972aa17e71bd66.trt
Could not open file H:\ComfyUI\custom_nodes\comfy-trt-test\comfy_trt\Unet-onnx\albedobaseXL_v20.onnx
Could not open file H:\ComfyUI\custom_nodes\comfy-trt-test\comfy_trt\Unet-onnx\albedobaseXL_v20.onnx
[E] ModelImporter.cpp:773: Failed to parse ONNX model from file: H:\ComfyUI\custom_nodes\comfy-trt-test\comfy_trt\Unet-onnx\albedobaseXL_v20.onnx
[!] Failed to parse ONNX model. Does the model file exist and contain a valid ONNX model?

it's weird ... i cannot reproduce those error
u have enough vram and/or disk space ?

it's weird ... i cannot reproduce those error
u have enough vram and/or disk space ?

RTX 3060 12GB - 200GB open space of 1TB, 32GB Ram

if u dont mind can u delete 2 folders Unet-onnx & Unet-trt then try convert again ?
for any SDXL model it should create 2 files: 1 .onnx file 3 MB + 1 file without extension 5.2 GB

Did that and I now have a new install, but I still have this problem. I so want to experiment with this... :-(
C:\AI_Files\venv\Lib\site-packages\torch\onnx\utils.py:737: UserWarning: We detected that you are modifying a dictionary that is an input to your model. Note that dictionaries are allowed as inputs in ONNX but they should be handled with care. Usages of dictionaries is not recommended, and should not be used except for configuration use. Also note that the order and values of the keys must remain the same.
warnings.warn(warning)
ERROR:root:Exporting to ONNX failed. ONNX export failed on an operator with unrecognized namespace xformers_flash::flash_fwd. If you are trying to export a custom operator, make sure you registered it with the right domain and version.
Building TensorRT engine… This can take a while.
Building TensorRT engine for C:\AI_Files\ComfyUI\custom_nodes\comfy-trt-test\comfy_trt\Unet-onnx\RealVisXLv20_VAE.onnx: C:\AI_Files\ComfyUI\custom_nodes\comfy-trt-test\comfy_trt\Unet-trt\RealVisXLv20_VAE_1a54828ff58cb83ba8972aa17e71bd66.trt
Could not open file C:\AI_Files\ComfyUI\custom_nodes\comfy-trt-test\comfy_trt\Unet-onnx\RealVisXLv20_VAE.onnx
Could not open file C:\AI_Files\ComfyUI\custom_nodes\comfy-trt-test\comfy_trt\Unet-onnx\RealVisXLv20_VAE.onnx
[E] ModelImporter.cpp:844: Failed to parse ONNX model from file: C:\AI_Files\ComfyUI\custom_nodes\comfy-trt-test\comfy_trt\Unet-onnx\RealVisXLv20_VAE.onnx
[!] Failed to parse ONNX model. Does the model file exist and contain a valid ONNX model?
Traceback (most recent call last):
File "C:\AI_Files\ComfyUI\custom_nodes\comfy-trt-test\convert_unet.py", line 141, in
ret = export_trt(trt_path, onnx_path, timing_cache, profile=profile, use_fp16=not args.float32)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\AI_Files\ComfyUI\custom_nodes\comfy-trt-test\comfy_trt\exporter.py", line 157, in export_trt
ret = engine.build(onnx_path, use_fp16, enable_refit=True, timing_cache=timing_cache, input_profile=[profile])
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\AI_Files\ComfyUI\custom_nodes\comfy-trt-test\comfy_trt\utilities.py", line 151, in build
network = network_from_onnx_path(onnx_path, flags=[trt.OnnxParserFlag.NATIVE_INSTANCENORM])
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "", line 3, in network_from_onnx_path
File "C:\AI_Files\venv\Lib\site-packages\polygraphy\backend\base\loader.py", line 40, in call
return self.call_impl(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\AI_Files\venv\Lib\site-packages\polygraphy\util\util.py", line 710, in wrapped
return func(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^
File "C:\AI_Files\venv\Lib\site-packages\polygraphy\backend\trt\loader.py", line 227, in call_impl
trt_util.check_onnx_parser_errors(parser, success)
File "C:\AI_Files\venv\Lib\site-packages\polygraphy\backend\trt\util.py", line 86, in check_onnx_parser_errors
G_LOGGER.critical("Failed to parse ONNX model. Does the model file exist and contain a valid ONNX model?")
File "C:\AI_Files\venv\Lib\site-packages\polygraphy\logger\logger.py", line 605, in critical
raise ExceptionType(message) from None
polygraphy.exception.exception.PolygraphyException: Failed to parse ONNX model. Does the model file exist and contain a valid ONNX model?

do u see any onnx file as i said ?

do u see any onnx file as i said ?

I do follow your instructions. I first deleted those folders... Nothing gets created in ONNX

But in unet-TRT

no onnx file at all 😰
seem like something mess up with xformers ...
if there is nothing rely on xformers can u try remove it ? comfyui doesnt rely on it anymore

I removed xformers now I can create files, but they fail:
Building TensorRT engine… This can take a while.
Building TensorRT engine for C:\AI_Files\ComfyUI\custom_nodes\comfy-trt-test\comfy_trt\Unet-onnx\sd_xl_base_1.0_0.9vae.onnx: C:\AI_Files\ComfyUI\custom_nodes\comfy-trt-test\comfy_trt\Unet-trt\sd_xl_base_1.0_0.9vae_1a54828ff58cb83ba8972aa17e71bd66.trt
[E] 1: [stdArchiveReader.cpp::nvinfer1::rt::StdArchiveReader::stdArchiveReaderInitCommon::47] Error Code 1: Serialization (Serialization assertion stdVersionRead == kSERIALIZATION_VERSION failed.Version tag does not match. Note: Current Version: 228, Serialized Engine Version: 224)
[E] 4: The timing cache will not be used!
[E] 1: [stdArchiveReader.cpp::nvinfer1::rt::StdArchiveReader::stdArchiveReaderInitCommon::47] Error Code 1: Serialization (Serialization assertion stdVersionRead == kSERIALIZATION_VERSION failed.Version tag does not match. Note: Current Version: 228, Serialized Engine Version: 224)
[E] 4: The timing cache will not be used!
TensorRT engines has been saved to disk.

TensorRT engines has been saved to disk.

it worked 😉 now u can check if the engine actually work in comfyui

TensorRT engines has been saved to disk.

it worked 😉 now u can check if the engine actually work in comfyui

But what does that error mean?
[E] 1: [stdArchiveReader.cpp::nvinfer1::rt::StdArchiveReader::stdArchiveReaderInitCommon::47] Error Code 1: Serialization (Serialization assertion stdVersionRead == kSERIALIZATION_VERSION failed.Version tag does not match. Note: Current Version: 228, Serialized Engine Version: 224)
[E] 4: The timing cache will not be used!
[E] 1: [stdArchiveReader.cpp::nvinfer1::rt::StdArchiveReader::stdArchiveReaderInitCommon::47] Error Code 1: Serialization (Serialization assertion stdVersionRead == kSERIALIZATION_VERSION failed.Version tag does not match. Note: Current Version: 228, Serialized Engine Version: 224)
[E] 4: The timing cache will not be used!

doesnt matter if the trt engine works, i already said in README

doesnt matter if the trt engine works, i already said in README

Fails in Comfy Generation:

seem like comfyui update something
wait a sec

i just push an update, can u try ?

Thanks for the help. Think the previous error is gone but now I get this:

Dont you have a preset workflow I can try?

as i said: turbo has problem
u can try other xl models

i created two model one normal and one sdxl turbo both give me this error any idea ,,,

Also I tried all --fpxx-unet options

don't hijack issue if u dont have same error
turbo has a different workflow, what model u using when u get those errors ?
make sure to have a proper setup and well isolated, and give proper bug report, i only see a mess:

different nodes in error message eventhough there's no custom node in your workflow image
weird model name, seem like image output, what is it ? if that's something private, i cannot test it i cannot help
u use a1111 and comfyui in same venv

i think its same error but you couldn't get the point ,,, i tried to make the onyx file using stable diffusion extinsion  with turbo model and its work perfect using your node , so the problem in converting onyx files in your code

u think ? do u bother to compare error message u having vs error message in this issue ? also could u address other points i made above ?

i was have same error okay so i follow the you !

until i face that error ,,

and i think its okay if i have same env for any if they need same library is that right

and i think its okay if i have same env for any if they need same library is that right

no, i have no idea how u setup a1111 and whether it's the same as comfyui
again could u address other points i made above ?

Thank you you are amazing ,,,