Latest update causes problems (same like #27)

The update of this theme states that 'Quark' is not installed. It is.
Also the plugin 'presentation-deckset' is missing, it is not
The installation of it causes an error (reported with Ole Vik)
See attachment

Hi @awrog , thanks for reporting the issue. When updating an inherited theme (like QOP) there will always be a note about the dependent theme being installed (Quark), however you should not be getting that error re: deckset.
Could you please confirm that the site you are updating has both the Presentation Plugin and the Presentation Plugin?
Thanks very much,
Paul

I am trying to replicate the issue, and an update from Quark v1.9.4 to the current release (v2.0.5) works locally - I will try to locate a skeleton with v2.0.3 to test as well.

I could send you a full backup...

Sure thing, my email address is<EMAIL_ADDRESS>Might have any server changes been done recently? Issue #27 seemed to be related to that too.

I figured it out. the offending file was \user\config\plugins\presentation.yaml
Although I've never used the plugin Presentation, the config-file seems incompatible with the latest version of the plugin.
Just deleting the old presentation.yaml and reopening and saving the plugin solves the problem!

Glad you got things going @awrog . I've also been in touch with, Ole and he has also worked out an approach for the Presentation Deckset Plugin to prevent this issue in the future.

Great, love Grav and the support from you guys!
On Fri, 20 Dec 2019, 17:42 Paul Hibbitts<EMAIL_ADDRESS>wrote:

Glad you got things going @awrog https://github.com/awrog . I've also
been in touch with, Ole and he has also worked out an approach for the
Presentation Deckset Plugin to prevent this issue in the future.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/hibbitts-design/grav-theme-quark-open-publishing/issues/28?email_source=notifications&email_token=AC4XGQZED65QRPAOKIZTO4LQZTYWDA5CNFSM4J4KB3GKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHNNHXA#issuecomment-567989212,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AC4XGQZEB2EXYRCLDFFY2WLQZTYWDANCNFSM4J4KB3GA
.


How to use and publish to the registry

Is there a plan to better document the usage and any plans to publish to the terraform registry as a provider?

I have yet to get the current, undocumented way of using this working yet, but here are some notes on what I think is needed.

Download the zip of the binary for your OS platform architecture from https://github.com/denoland/terraform-deploy-provider/releases and unzip it
Touch create a .terraformrc in the specifically designated directory for your OS (see https://developer.hashicorp.com/terraform/cli/config/config-file)
Fill it out so it doesn't look to the Terraform registry for the provider binary, but instead looks at your local filesystem, in particular the path to the binary (see https://developer.hashicorp.com/terraform/cli/config/config-file#provider-installation)

In theory this should be enough to get terraform init to work I think, but I haven't succeeded so far.
I sort of wonder how easy it would be to publish a fork of this to the Terraform registry just to get a feel for what the blockers are.

Somehow I set this up with different steps, I didn't make a .terraformrc to do it.
I put the binary at ~/.terraform.d/plugins/terraform.local/denoland/deploy/0.3.1/linux_amd64/terraform-provider-deploy_v0.3.1 and then added this block to my configuration directory:
terraform {
  required_providers {
    deploy = {
      source  = "terraform.local/denoland/deploy"
      version = "0.3.1"
    }
  }
}

provider "deploy" {
  api_token = "ddp_..........."
}

But seriously this should be on the registry, I'd assume that the existing binary is fine and it's maybe a bit of a code-signing concern to properly publish a build to the registry.


⚠ Spryr has degraded performance

In 85b6625, Spryr (https://spryr.com) experienced degraded performance:

HTTP code: 200
Response time: 3419 ms

Resolved: Spryr performance has improved in 9e55ff4 after 7 minutes.


Question: Howto make a "Select" Invalid

Could you please explain how one should (dynamically) mark a "Select" as invalid (so that a red border is shown underneath) ?
A hint about invalidating other components (like the datepicker) would be highly appreciated :smiley:

We are leaving any complex validation that is not provided by html up to the user. In addition, i'm not sure  how validating a select would even be useful.
In any case, this is out of the scope of our project.

Well, when we call $('select').material_select(); then the following code:
<select>
    <option value="" disabled selected>Choose your option</option>
    <option value="1">Option 1</option>
    <option value="2">Option 2</option>
    <option value="3">Option 3</option>
</select>
Materialize Select

becomes like this:

    <input class="select-dropdown" readonly="true" data-activates="select-options-8a6ba0ba-61d0-ccb1-b245-9fa560768eb7" value="Choose your option" type="text">

Choose your option

Option 1

Option 2

Option 3

    <select class="initialized">
        <option value="" disabled="" selected="">Choose your option</option>
        <option value="1">Option 1</option>
        <option value="2">Option 2</option>
        <option value="3">Option 3</option>
    </select>

Materialize Select

So I thought we could then add "invalid" to <input class="select-dropdown" ...> so it gets a red border underneath in case we need the user to select an option and he forgot to...

@acburst Take a look at the following image, the upper select is missing the red line when invalid, since you also use input fields in your initialized widget, why not be able to make the invalid style look the same?

Hello! My select dont is showed, when i use directives like *ngFor, or *ngIf. Can you help me ?

@Jhonatangiraldo you should use angular-materialize https://krescruz.github.io/angular-materialize/ maybe that will save your life in that case hahaha


Unlink slice viewers

To be done after the viewer v24.0.0 is embedded.
due to the slider in the viewer https://github.com/TomographicImaging/iDVC/blob/0fed0478d8b14e2c8ded4f6fa82642898dfc8b3a/src/idvc/dvc_interface.py#L813
this needs to be set to False to unlink the two viewers

This does not need to be addressed as the viewer is now linking the 2D and 3D viewers with the mouse wheel as well as the slider. See https://github.com/TomographicImaging/CILViewer/pull/413


[Feature 1] Modifying Features/Hidden Layers

Selecting properties, adding layers/neurons, and changing the weights between the layers.

/close by #42


CI caching

Codecov Report

Merging #160 (50d65e9) into develop (87d8106) will decrease coverage by 29.01%.
The diff coverage is 23.72%.

:exclamation: Current head 50d65e9 differs from pull request most recent head becc2b2. Consider uploading reports for the commit becc2b2 to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@             Coverage Diff              @@
##           develop     #160       +/-   ##
============================================
- Coverage    67.53%   38.52%   -29.01%
============================================
  Files           54       86       +32
  Lines         8375    11566     +3191
============================================
- Hits          5656     4456     -1200
- Misses        2719     7110     +4391

Impacted Files
Coverage Δ

src/abci/mod.rs
0.00% <0.00%> (ø)

src/abci/node.rs
0.00% <0.00%> (ø)

src/abci/prost.rs
8.57% <0.00%> (-8.58%)
:arrow_down:

src/abci/tendermint_client.rs
0.00% <0.00%> (ø)

src/call.rs
0.00% <0.00%> (ø)

src/client/chain.rs
0.00% <0.00%> (ø)

src/client/mock.rs
0.00% <0.00%> (ø)

src/client/mod.rs
0.00% <0.00%> (ø)

src/coins/accounts.rs
0.00% <0.00%> (ø)

src/coins/coin.rs
28.57% <0.00%> (+0.98%)
:arrow_up:

... and 115 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Prefix concatenation when using stages-multitenant results in prefix longer than 9 chars

The variable var.prefix in stages/0-bootstrap/terraform.tfvars must be no longer than 9 chars.
The short_name in stages-multitenant/0-bootstrap-tenant/terraform.tfvars should be 3 or 4 letters.
In stages-multitenant/0-bootstrap-tenant/main.tf, the output prefix var is created by concatenating the two above variables, i.e.

prefix = join("-", compact([var.prefix, var.tenant_config.short_name]))

Consequently, the newly created prefix variable in stages-multitenant/0-bootstrap-tenant.auto-tfvars.json is longer than 9 characters.
But the validation in stages-multitenant/1-resman-tenant/variables.tf requires that this prefix be no longer than 9 characters.

Is the validation in stages-multitenant/1-resman-tenant/variables.tf correct?  If so, then the instructions need to be updated to explain the consequences of using a prefix and short_name that, when concatenated, will be over 9 characters.

In the meantime, my workaround for completing stage 1-resman-multitenant was to change the prefix validation in variables.tf to be:
  validation {
    condition     = try(length(var.prefix), 0) < 14
    error_message = "Use a maximum of 13 characters for prefix (which incudes tenant short name)."
  }

This seems to have worked fine, and I've been able to execute this stage.  I haven't yet checked it in with a PR, as I wasn't sure if there are any downstream negative consequences.

Thanks for opening this. I have a vage recollection of checking when I developed the multitenant stages, and 13 or 14 being the magic number like you say. I also remember fixing the validation, but I'm eveidently wrong.
This is a sample of project ids created by different stages minus prefix, with their word count
12 audit-logs-0
10 iac-core-0
16 prod-net-spoke-0
15 prod-sec-core-0
19 prod-gke-clusters-0
19 prod-data-orc-cmp-0

Tenant prefix by default combines org-level prefix and tenant shortname, so 30 (maximum project id length) minus 1 (dash joining org-level and tenant-level), minus 19 (longest project id) leaves 10 characters.
Which is larger than the current condition in tenant stages, but by only 1 char. And it's also suboptimal as an org-level prefix of 9 would only leave 1 character for tenant short names.
The only leeway we have is in stage 3 names: if we set a limit to 16 for those, we get back 3 characters that combined with the 1 above give a maximum of 4 characters for tenant shortnames, which actually matches what we've seen at customers. GKE is easy as we just need to shorten clusters, the data platform is a bit more complex we need to sync with @lcaggio .
The other alternative is to shorten the check for org-level stages so the maximum prefix length is 7, and we get 3 characters minimum for tenants.
This was probably longer than you asked for. :) What are your thoughts on this? And @juliocc please chime in too of course.

Sounds like a plan. We can also leave the org-level to 9, then with the 18 for stage 3 you have 2 chars minimum for tenants, plus any left over from the org 9. WDYT?

I guess it depends if you think 2 chars are sufficient for the top-level tenants?  I guess most enterprises don't have too many at this level, so probably okay.  But 2 chars doesn't allow for a very descriptive short name.
However, I guess you could encourage users to think about this from the start of the process.  So, if we stuck with keeping 9 chars for org prefix, maybe add a note to the 0-bootstrap readme to say something like "If you plan to use multitenant, and you want your top-level tenant short names to be more than 2 characters long, do not use the full 9 characters for your organization prefix."
Would that work?  If so, and if you'd like me to contribute to the 0-bootstrap readme, then I can do that tonight. (But I understand if you'd rather do it yourselves!)

Yes, that is exactly what I meant: users should take into account limitations right from the start. If you want to go ahead with a PR, by all means do so! And thanks again for raising this. :)

Awesome, will do!  Thanks for coming back so quickly, and for giving me the opportunity to contribute!

@ludoo Thanks for approving the PR.  I haven't closed the issue yet, as I haven't touched anything in stage 3.

This seems to be an issue again. We have to double check the length of all DP SAs


Remove unused JEE deps

Two compile dependencies referencing JEE artifacts don't seem to be required for compilation. This PR removes them from the build.

If we don't need these then presumably #2091 is not needed? That seems like it would be a good outcome to me...


Update influxdb.conf.erb

Fixed [[udp]] and [[grafana]] into [udp] and [grafana]

Seems that the double square brackets break influxdb.

Nope, the  double [[ is correct with influxdb 0.9.3.


Enable API 27 on emulator.wtf

We need to investigate and fix test failures that occur on API 27 emulator:

permissions_location_test was caused by #1450. Hotfix was implemented in #1452.


electron-prebuilt -> electron

by the end of 2016, electron will no longer be distributed through the electron-prebuilt package. better to be ready now :smile:
http://electron.atom.io/blog/2016/08/16/npm-install-electron

This was actually already done in the most recent release branch.


[Event Hubs] [Perf] SubscribeTest takes 300 seconds longer than expected to end

Command to run = npm run perf-test:node -- SubscribeTest --event-size 1024 --max-batch-size 100 --events 10000
2023-03-08T23:29:26.741Z rhea-promise:receiver [connection-2] receiver '55c82c77-4f84-4fa1-8366-a7b59bc30d01' got event: 'receiver_error'. Re-emitting the translated context.
2023-03-08T23:29:26.741Z rhea-promise:translate [connection-2] Translating the context for event: 'receiver_error'.
azure:event-hubs:verbose [connection-2] An error occurred on the $management receiver link.. MessagingError: The connection was inactive for more than the allowed 300000 milliseconds and is closed by container 'LinkTracker'. TrackingId:760005faa1cf456dbc52dbb7449cb088_G15S2, SystemTracker:gateway5, Timestamp:2023-03-08T23:29:26
    at Object.translate (/workspaces/azure-sdk-for-js/sdk/core/core-amqp/dist/index.js:1009:23)
    at Receiver.<anonymous> (/workspaces/azure-sdk-for-js/sdk/eventhub/event-hubs/dist/index.js:2309:46)
    at Receiver.emit (node:events:512:28)
    at emit (/workspaces/azure-sdk-for-js/common/temp/node_modules/.pnpm/rhea-promise@2.1.0/node_modules/rhea-promise/dist/lib/util/utils.js:131:24)
    at Object.emitEvent (/workspaces/azure-sdk-for-js/common/temp/node_modules/.pnpm/rhea-promise@2.1.0/node_modules/rhea-promise/dist/lib/util/utils.js:142:9)
    at Receiver.<anonymous> (/workspaces/azure-sdk-for-js/common/temp/node_modules/.pnpm/rhea-promise@2.1.0/node_modules/rhea-promise/dist/lib/link.js:284:25)
    at Receiver.emit (node:events:512:28)
    at link.dispatch (/workspaces/azure-sdk-for-js/common/temp/node_modules/.pnpm/rhea@2.0.8/node_modules/rhea/lib/link.js:59:37)
    at link.on_detach (/workspaces/azure-sdk-for-js/common/temp/node_modules/.pnpm/rhea@2.0.8/node_modules/rhea/lib/link.js:162:32)
    at Session.on_detach (/workspaces/azure-sdk-for-js/common/temp/node_modules/.pnpm/rhea@2.0.8/node_modules/rhea/lib/session.js:740:27) {
  retryable: true,
  info: null,
  code: 'ConnectionForcedError'
}
2023-03-08T23:29:26.741Z rhea:events [connection-2] Link got event: receiver_close
2023-03-08T23:29:26.741Z rhea-promise:receiver [connection-2] receiver '55c82c77-4f84-4fa1-8366-a7b59bc30d01' got event: 'receiver_close'. Re-emitting the translated context.

Figured the bug, fixing in https://github.com/Azure/azure-sdk-for-js/pull/25131


Add leakScope true to components

Previously leakScope was true by default. In 3.0 it is false by default. Since determining whether a Component actually takes advantage of leakScope is hard, setting it to true will allow v2 components to continue working after code migration.

To accomplish this, we need a codemod like this one I just wrote up; probably a little bit smarter (can and Component could be named differently on import/require).


Issue on page /notebooks/09/economicdispatch.html

Something seems to be going wrong with the first model formulation in section "MILO reformulation for the chance-constrained ED problem". I have the following screen

Thank you!  That was a math formatting error. It's been fixed and verified. Feel free to reopen if you if notice any similar issues in this or other notebooks.


Bounty: Fast parallel scan (Mamba, etc).

It would be great to have a general parallel prefix sum (associative scan) operation in tinygrad, something like associative_scan in JAX or scan_associative in TensorFlow Probability. This operation is key for the parallelization of some algorithms in CRFs, filtering/smoothing in state space models, mamba etc.
Additional Reference
https://arxiv.org/abs/2311.06281
Current Bounty: $500
To lock the bounty submit a draft PR with a decent amount of progress made
Make sure to reference this issue in the PR for future tracking
Notice: If the PR goes stale the bounty will be unlocked

can the possible operations just be limited to the stock tinygrad BinaryOps which would make sense here (ADD, MUL, MAX, XOR)? looking at the jax api. Or do you want just ADD prioritized right now?

Hey is this bounty up for grabs?


build fail for tsdoc

Hi,
I followed Contributing.md but build fail
I have no idea to handle this,
is there any suggestion? thx.
$ npm run build

<EMAIL_ADDRESS>build D:\study\tsdoc\tsdoc
node ./build.js

-- TYPESCRIPT --
node_modules/jest-diff/build/diffLines.d.ts:8:13 - error TS1005: '=' expected.
8 import type { DiffOptions } from './types';
~
node_modules/jest-diff/build/diffLines.d.ts:8:34 - error TS1005: ';' expected.
8 import type { DiffOptions } from './types';
~~~~~~~~~
node_modules/jest-diff/build/index.d.ts:10:13 - error TS1005: '=' expected.
10 import type { DiffOptions } from './types';
~
node_modules/jest-diff/build/index.d.ts:10:34 - error TS1005: ';' expected.
10 import type { DiffOptions } from './types';
~~~~~~~~~
node_modules/jest-diff/build/index.d.ts:11:1 - error TS1128: Declaration or statement expected.
11 export type { DiffOptions, DiffOptionsColor } from './types';

node_modules/jest-diff/build/index.d.ts:11:13 - error TS1005: ';' expected.

11 export type { DiffOptions, DiffOptionsColor } from './types';
            ~

node_modules/jest-diff/build/index.d.ts:11:52 - error TS1005: ';' expected.

11 export type { DiffOptions, DiffOptionsColor } from './types';
                                                   ~~~~~~~~~

node_modules/jest-diff/build/printDiffs.d.ts:8:13 - error TS1005: '=' expected.

8 import type { DiffOptions, DiffOptionsNormalized } from './types';
           ~

node_modules/jest-diff/build/printDiffs.d.ts:8:57 - error TS1005: ';' expected.

8 import type { DiffOptions, DiffOptionsNormalized } from './types';
                                                       ~~~~~~~~~

Found 9 errors.

ERROR: Command failed: D:\study\tsdoc\tsdoc\node_modules\.bin\tsc
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>build: `node ./build.js`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>build script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR!      C:\Users\Administrator\AppData\Roaming\npm-cache\_logs\2020-06-15T09_46_28_284Z-debug.log

I see, you are using the "standalone with NPM" instructions from Contributing.md.
For now, try using the Rush instructions instead:
$ cd ./tsdoc
$ rush install
$ rush build


fix: the env.TAG variable will not start with a v

This will fix the change done in issue #606 to work as expected
Closes #607
Signed-off-by: John Long<EMAIL_ADDRESS>

Thanks @leonardoce


Improve legibility of bdd_varprofile

It is not clear, that Adiar has support to obtain all variables in a BDD or ZDD.
Tasks:

BDD:

[ ] Move bdd_varprofile up next to bdd_minvar and bdd_maxvar in the BDD API.
[ ] Rename bdd_varprofile into bdd_support.
[ ] Add a new overload bdd_support(f) that returns a bdd cube (see also: #533).

ZDD:

[ ] Move zdd_varprofile up next to zdd_minvar and zdd_maxvar in the ZDD API.
[ ] Rename zdd_varprofile into zdd_support.
[ ] Add a new overload zdd_support(A) that returns a zdd cube (blocked until #533 is resolved).

Additional context
This was noticed by Anna Blume Jakobsen while browsing through the documentation.

Doing this, we can also add bdd_varprofile in the way it is used in BuDDy, i.e. where you get to read through the levels file.


New utility module: chroot

osbuild/util: new module: chroot
New chroot utility module that sets up a tree with the necessary virtual
filesystems needed for running commands in the root tree in a similar
environment as they would run in the build root.
This is needed for some stages, but may also be used for all chroot
calls to unify the setup and teardown of the root environment.
The Chroot context class was previously part of the org.osbuild.dracut
stage, which was the first stage to need this setup.

stages/update-crypto-policies: use Chroot context
Recently [1], the update-crypto-policies script added a check to verify
that the FIPS policy was automounted by reading the
/proc/self/mountinfo.  The script will fail if the proc filesystem isn't
available.
Use the new Chroot context to set up the environment for the command.
[1] https://gitlab.com/redhat-crypto/fedora-crypto-policies/-/commit/04ceadccfc07e5946b08157d06ca5c0d5a229d92

Notes
We might expand the class to have a call() method or similar, so that we can do:
with Chroot(path) as chroot:
  chroot.call("dracut" ...)

Leaving this for a follow-up though.

I reverted the change to the umount calls to get this PR through with the same behaviour we had before.  So the context now is a straight-up copy of the one that was in the dracut stage.
Let's get this merged to unblock the new distros and we can take our time with improvements and updating tests in a separate PR, instead of rushing it here.


GH-3521 more query benchmarks

GitHub issue resolved:  GH-3521
Briefly describe the changes proposed in this PR:

more query benchmarks
some have been commented out because they are too slow

PR Author Checklist (see the contributor guidelines for more details):

[x] my pull request is self-contained
[ ] I've added tests for the changes I made
[x] I've applied code formatting (you can use mvn process-resources to format from the command line)
[x] I've squashed my commits where necessary
[ ] every commit message starts with the issue number (GH-xxxx) followed by a meaningful description of the change

Benchmark                                                     Mode  Cnt      Score     Error  Units
QueryBenchmark.complexQuery                                   avgt    5     47.596 ±   0.488  ms/op
QueryBenchmark.different_datasets_with_similar_distributions  avgt    5      3.232 ±   0.090  ms/op
QueryBenchmark.groupByQuery                                   avgt    5      1.983 ±   0.072  ms/op
QueryBenchmark.long_chain                                     avgt    5   1055.210 ±  32.642  ms/op
QueryBenchmark.lots_of_optional                               avgt    5    271.959 ±   8.758  ms/op
QueryBenchmark.minus                                          avgt    5  12103.994 ± 100.582  ms/op
QueryBenchmark.nested_optionals                               avgt    5    262.800 ±   5.527  ms/op
QueryBenchmark.pathExpressionQuery1                           avgt    5     23.529 ±   0.894  ms/op
QueryBenchmark.pathExpressionQuery2                           avgt    5      1.596 ±   0.102  ms/op
QueryBenchmark.query_distinct_predicates                      avgt    5    194.093 ±   9.729  ms/op
QueryBenchmark.simple_filter_not                              avgt    5     10.962 ±   0.539  ms/op


Don't require _config/ dir or _config.php file for modules

Currently the ManifestFileFinder only looks for files that are inside a directory with either a _config/ directory or _config.php file, because that's how it detects if something is "a module".
https://docs.silverstripe.org/en/5/getting_started/directory_structure/#module-structure also says

They need to have a _config.php file or a _config/ directory present

We should allow for directories with a composer.json file where the type is set to either silverstripe-vendormodule or silverstripe-theme to also count, since that's the type we say is necessary for modules and themes and some may not have a need for config.
Acceptance criteria

modules and themes don't need to have a _config/ directory or _config.php file to be detected as modules, including full manifest detection
the _config/ directory and _config.php file detection is left in place as a fallback

Any reason why we would wait for CMS 6 to do this change. This seems like something that could happen in CMS 5.3 without any downside.

Any reason why we would wait for CMS 6 to do this change

Who knows if someone has a module that has the silverstripe-vendormodule type but they don't want to be considered a module, so their hacky way to do that was to not have the dir/file needed to pick it up?
Seems unlikely, but I'd take a risk-averse approach. There's very little risk for sure, but I'd argue that in this case the benefit of doing it in CMS 5 is so low that there's no harm in doing it for 6 and just not upsetting the few people that might be upset by it.

That said, I don't feel overly strongly about it.

PRs merged


FPT_TST_EXT.1.1

Application Note: The bootchain of the OS is the sequence of software, to included the OS loader, the kernel, system drivers or modules, and system files, which ultimately result in loading the OS. The first part of the OS, usually referred to as the first-stage bootloader, must be loaded by the platform. Assessing its integrity, while critical, is the platform's responsibility; and therefore outside the scope of this protection profile. All software after the initial program is within scope
I assume the "All software after the initial program" means after the initial bootloader? why the name change in the last sentence?

rephrased to avoid the problem


add resource_kind, resource_name & container_name lables to vulnerability metrics

Description
This PR adds the following lables to metrics to better describe the scanned resource:

resource_kind
resource_name
container_name (where applicable)

I believe this PR also addresses a potential bug that I described here that resulted in the resource labels not being added to the trivy_vulnerability_id metric (test added to validate this scenario)
Related issues

Close #839

Checklist

[x] I've read the guidelines for contributing to this repository.
[x] I've added tests that prove my fix is effective or that my feature works.
[ ] I've updated the documentation with the relevant information (if needed).
[ ] I've added usage information (if the PR introduces new options)
[ ] I've included a "before" and "after" example to the description (if the PR is a user interface change).

@dkulchinsky thank you for the contribution 🚀  , once comment , could you please update the metrics docs with new field example

Thanks for taking a look @chen-keinan, updated the metrics doc.
Also started thinking that perhaps the the same labels would be useful in other metrics as well? but just vulnerabilities, wdyt?

Thanks for taking a look @chen-keinan, updated the metrics doc.
Also started thinking that perhaps the same labels would be useful in other metrics as well? not just vulnerabilities, wdyt?

Good Point , you can do it in this PR or another PR , it up to you to decide

Thanks @chen-keinan, I think I should be able to add this to the current PR to keep things neat.

Hey @chen-keinan, updated the other metrics as well and aligned the docs, so this is ready for another pass.
Thanks!

lgtm 🚀

Thanks for reviewing and merging @chen-keinan!


In RTD sphinx-jsonschema requires manually entering new lines

In the documentation, the configuration_file.rst contains sphinx-jsonschema. When entering a description, the developer needs to manually select where they want their new lines. To do so, it is necessary to generate the documentation. Theses steps are not very convenient. Adding an option to set a maximum depth would be moe convenient.
See comment: https://github.com/ivadomed/ivadomed/pull/612/files#r570333890

New issue: #671


rebar3: update documentation

Motivation for this change
rebar3-open was made the default and the hermetic build of  rebar3 was deleted in https://github.com/NixOS/nixpkgs/pull/54115. This update the documentation to be up to date with the state of rebar3.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ x ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Notify maintainers
cc @ankhers maybe ?

Looks fine to me.

backported in 4c6b739fd7244fa4c8c041ef7624d5fd9dd6c09f


Test-FileCatalog does not work on PSCore.

Steps to reproduce

Create new file catalog for one of the modules in your system (using New-FileCatlog)
Run Test-FileCatlog on the catalog created in step 1.

New-FileCatalog -CatalogFilePath "C:\Program Files\WindowsPowerShell\Modules\Pester\3.4.0\pester.cat"  -Path "C:\Program Files\WindowsPowerShell\Modules\Pester\3.4.0"

Test-FileCatalog "C:\Program Files\WindowsPowerShell\Modules\Pester\3.4.0\pester.cat"

Expected behavior
PS C:\DSC-tests\DSC\Tests\PullServerClient\BVT> Test-FileCatalog "C:\Program Files\WindowsPowerShell\Modules\Pester\3.4.0\pester.cat" -Detailed

Status        : Valid
HashAlgorithm : SHA1
CatalogItems  : {[Functions\Coverage.ps1, F4022ABD45FE0FB2C3527A539F022E2AFDF16851], [Functions\Assertions\BeGreaterThan.ps1,
                EEE62A89040021D1F3B2B86D8B6C4884AF7C8925], [bin\Pester.bat, E20AF79E7EC1B2DBA3DF7600C46E9CA613DF1A3C], [Functions\GlobalMock-A.Tests.ps1,
                DF7F6F009A46AE9386C01A2350741C264FB4163D]...}
PathItems     : {[Build.bat, B4FEDB2F7522EB6EEA68EEA73A095EBA8E441926], [build.psake.ps1, 70DA7E6DF0664C0E791C32C31E14924B779A6938], [CHANGELOG.md,
                86F6D42CC7389E38952ED741BFACE73A2C755119], [chocolateyInstall.ps1, 013A7B468B830C37FA51518E56933ACE54889CCC]...}
Signature     : System.Management.Automation.Signature

Actual behavior
PS C:\InGuestPolicyx64> Test-FileCatalog "C:\Program Files\WindowsPowerShell\Modules\Pester\3.4.0\pester.cat"

<NO OUTPUT>

Environment data

PS C:\InGuestPolicyx64> $PSVersionTable

Name                           Value
----                           -----
PSVersion                      6.0.0-beta
PSEdition                      Core
GitCommitId                    v6.0.0-beta.6-dirty
OS                             Microsoft Windows 10.0.16250
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

@iSazonov  This appears to be caused by #3074. Can you take a look? there appears to be no code path for when -Path is not supplied. In 5.1 supplying just -CatalogFilePath (position 0)  would use the directory of the catalog file. This is performed in PerformAction() which is never reached because ProcessRecord() doesn't have any code paths for null -Path.

@BerheAbrha you can work around this by supplying the -Path and -CatalogFilePath:
Example:
New-FileCatalog -CatalogFilePath C:\temp\temp.cat -Path C:\temp\
Test-FileCatalog -Path C:\temp\ -CatalogFilePath C:\temp\temp.cat -Detailed

Also, judging from your PSVersiontable, you are not on the latest version of PS core. However, i was able to repro this for you on
Name                           Value
----                           -----
PSVersion                      6.0.0-rc
PSEdition                      Core
GitCommitId                    v6.0.0-rc
OS                             Microsoft Windows 10.0.15063
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

The problem appears to be line 117 was moved inside the if statement when it should stay where it was outside of it.  I'll submit a fix.

My bad 😕

@iSazonov no worries, I'm just adding some tests and should have a PR soon

@markekraus, It does work when the path is supplied to the cmdlet.  But it is regression from WMF 5.1 where path is not required.  This is broke signature validation logic in DSC.
PS C:\InGuestPolicyx64> Test-FileCatalog -CatalogFilePath "C:\Program Files\WindowsPowerShell\Modules\Pester\3.4.0\peste
r.cat" -Detailed -Path "C:\Program Files\WindowsPowerShell\Modules\Pester\3.4.0"

Status        : Valid
HashAlgorithm : SHA1
CatalogItems  : {[Functions\Coverage.ps1, F4022ABD45FE0FB2C3527A539F022E2AFDF16851],
                [Functions\Assertions\BeGreaterThan.ps1, EEE62A89040021D1F3B2B86D8B6C4884AF7C8925], [bin\Pester.bat,
                E20AF79E7EC1B2DBA3DF7600C46E9CA613DF1A3C], [Functions\GlobalMock-A.Tests.ps1,
                DF7F6F009A46AE9386C01A2350741C264FB4163D]...}
PathItems     : {[Build.bat, B4FEDB2F7522EB6EEA68EEA73A095EBA8E441926], [build.psake.ps1,
                70DA7E6DF0664C0E791C32C31E14924B779A6938], [CHANGELOG.md, 86F6D42CC7389E38952ED741BFACE73A2C755119],
                [chocolateyInstall.ps1, 013A7B468B830C37FA51518E56933ACE54889CCC]...}
Signature     : System.Management.Automation.Signature

@BerheAbrha Yes it was a regression. i was letting you know the workaround while the issue was being addressed. #5596 has addressed the issue and this should be fixed in 6.0.0-GA 😃 , Thanks for reporting!


Search-api: API_TYPE only allows selection of two options

Need to support any application.
causes an error if set to anything else
Traceback (most recent call last):
File "./wsgi.py", line 1, in
from app import app as application
File "./app.py", line 61, in
"Required configuration parameter API_TYPE not found in application configuration. Must be set to 'HUBMAP' or 'SENNET'.")
ValueError: Required configuration parameter API_TYPE not found in application configuration. Must be set to 'HUBMAP' or 'SENNET'.

maybe this can come from the configuration and use a form of "reflection" to instanciate

Issued a new PR to dev-integrate to address this. New app config setting is "TRANSLATOR_CLASS" that will be the name of the translator class the user wants to use


Add ReTiCo to title for better visibility in pin mode

For better visibility in pin mode add ReTiCo to title

I have to check if I can access tu use_pin value. If not, I prefer not to use too long Panel titles.

I just tried it to see what it looks like, in fact it's a very bad idea, the visibility is much less good.
Moreover, if you think about it, there is no risk of confusing it with other titles. Don't touch anything, it's great like that.


New field view with a text field where you can input a query and see the XML result

Replicate PDS WITSMLstudio functionality where the user can enter an arbitrary query and the API will forward it to the target WITSML server as is, and then show the result as is.
Include:

ReturnElements options
Template for every object type / ReturnElements combination
Get/Add/Update/Delete function options

Optionally / future work:

XML formatting
Syntax highlighting
XML validation

Moved from WE-343

Can probably borrow code from PDS client here (also open source).


Node & Pod Selector section need to be redesigned

The Node & Pod selector section in create workload needs to be redesigned.

[ ] Redo headers
[ ] Change text (confusing?)
[ ] Make differences between Required & Prefer more identifiable.
[ ] Use the new standard for our "block" control

Vincent and I took a look:  Here are his comments.
Pod Selector:
1 button for Pod selector
At start - 1 drop-down with the 4 choices
reorder so that it is Namespace, Rule, then topology.
Add tooltip to Topology
Multi-select
Topology default should be kubernetes.io/hostname (maybe drop-down with standards)
Node Selector:
Specific nodes should only be node name, cause key/Value is on other radio
Doesn't like that there isn't a None option for the radio (should that be a third option)
Change selector section to match the pod selector section

Verified fixed


update README.md to match the current source code

update pdl file links (fixes #9)
update the link to the source code directory (/gen/gotpl and /fixup)
update information about the cache directory (<default root cache directory>/cdproto-gen)
update the command-line options
specify that the -out option is required now
update the example command-line output
it's more reasonable to run cdproto-gen in the repository root (instead of installing with go get -u). The example command tries to match this case.

Closing  as having been merged


Add a way to ignore or filter warnings

I am using clang -fsyntax-only as my c++ syntax checker, but it has this annoying issue: https://llvm.org/bugs/show_bug.cgi?id=16686 that makes syntastic complain whenever I'm syntax-checking a header with #pragma once. Is there a way I could ignore or filter this warning in syntastic? Would that be something useful to add?

Try :help 'syntastic_quiet_messages'.


[DO NOT MERGE] Pull Push

Is this ready to be reviewed?

No still researching how to retrieve the list of conflicts during a merge.
Got an idea?
On Fri, May 4, 2018, 18:30 Matt Diephouse<EMAIL_ADDRESS>wrote:

Is this ready to be reviewed?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/SwiftGit2/SwiftGit2/pull/129#issuecomment-386759760,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACvoW7FyS7UUFv47p7DYBII0Vlgk1of8ks5tvOSOgaJpZM4TurzY
.

Any update here? Really looking for pull & push features on SwiftGit2. Otherwise, is there anything I can do to "emulate" this feature natively or by using ObjectiveGit?

Feel free to open it again, if you figured out  😊


Added Isomorphic String Calculator

Fixes Issue🛠
I have added an isomorphic string calculator
Closes #1665
Description👨💻
Added an isomorphic string calculator that calculates whether two strings are isomorphic or not .
Type of Change📄

[x] New feature (non-breaking change which adds functionality)

Checklist✅

[x] I am an Open Source contributor
[x] I have performed a self-review of my code
[x] My code follows the style guidelines of this project
[x] I have commented on my code, particularly in hard-to-understand area

Screenshots/GIF📷

@meetarora10 Thank You for your contribution.  Please correct URL in main index.html file.

@Nihal4777 done .

@Rakesh9100 please review and merge this today .


os-nginx: Add option for upstream keepalive

Important notices
Before you add a new report, we ask you kindly to acknowledge the following:

[x] I have read the contributing guide lines at https://github.com/opnsense/plugins/blob/master/CONTRIBUTING.md
[x] I have searched the existing issues, open and closed, and I'm convinced that mine is new.
[x] When the request is meant for an existing plugin, I've added its name to the title.

Is your feature request related to a problem? Please describe.
For performance tuning I would like to be able to enable keepalive for upstream connections.
Describe the solution you'd like
Two new options in Upstream:

Keepalive: how many connections to keep alive upstream (0 or empty for disabled)
Keepalive Timeout: how long to wait for closing an idle upstream connection

Describe alternatives you've considered
Not really any alternatives, as the keepalive directive must be set in the upstream context, which will be overwritten when pressing Apply in the WebUI.
Additional context
This will require two new directives in the upstream context and two in the location context when upstream keepalive is enabled:
upstream

keepalive [int];
keepalive_timeout [int];

location

proxy_http_version 1.1;
proxy_set_header Connection "";

I also need proxy_http_version.


haskell-data-hash: disable broken test suite

Test suite is broken on GHC 7.10.
@peti

Can you please report that issue upstream to the package maintainers to give them a chance to fix this? Ideally, the URL to the upstream ticket would be added to the override in a comment so that it's easier for us to track whether the problem has been resolved or not.

The package does not have a github repo / website / issue tracker, but I have sent the maintainer an email.

Cool, thank you!


Enhancement: make the combo asset used

just put it above the combo number or something

example taken from mungyodance 3

it is already used?

where
i dont see it

the add call function for combo is disabled iirc but its easy to restore


API docs are missing the overview for all package docs

The lower part of the sidenav on https://docs.flutter.io/ contains links to API docs for a number of packages exposed by Flutter. For those docs, there seems to be no way to get to the overview page of the package docs. For example, the sidenav contains term_glyph. The overview page of that package is shown here on pub. But when you click term_glyph in the sidenav on docs.flutter.io, I don't see that overview.
Update 9. nov 2022: The API docs page is now https://api.flutter.dev/. This still has the issue. For example, when you click characters in the left-nav you get this page, but I think the landing page should be this page.

This still remains an issue on the latest master 1.21.0-6.0.pre.41

Hello @mit-mit
Revisiting this issue, since the flutter api docs website is now changed to https://docs.flutter.dev/ and I don't seem to exactly replicate the issue you described originally, can you please confirm if this should remain open or can be closed ?

This issue is still there. Added an update at the top.

cc @gspencergoog, wdyt? For an example like characters this page is a much better landing page than the current page.


response in linux server

So as per example I integrated the cleverbot in my code as below:
var Cleverbot = require('cleverbot-node');
cleverbot = new Cleverbot;
cleverbot.configure({botapi: "KEY"});
cleverbot.write(cleverMessage, function (response) {
   console.log(response.message);
});

Running the above from my windows pc, works just fine, but from the linux server, responds as
npm view cleverbot-node version -> 0.3.3

yes me to. Can you help?

I am also having this problem, the full response is as follows:
{ message: '',
  sessionid: '\n<title>401 Authorization Required</title>',
  logurl: '\n',
  vText8: '\n
401 Authorization Required
',
  vText7: '\n
nginx/1.6.2 (Ubuntu)',
  vText6: '\n',
  vText5: '\n',
  vText4: '\n' }

@MightyAlex200 These all appear to be errors with the 0.2.x versions. Since 0.2.x versions deal with the unofficial Cleverbot API, I am not going to support it. You will need to update to the 0.3.x version (0.3.3 being the latest) and get an API key from here, https://www.cleverbot.com/api/.
@llool are you sure you are using 0.3.3? What version is listed in node_modules/cleverbot-node/package.json?

Hey uhm, I'm having issues update cleverbot-node, it still keeps saying its version 0.2.4.

@WhiteKitty00 What does the package.json look like for you app? Is cleverbot-node included in there or is it a dependency of another package?

@fojas it was cleverbot-node version 0.2.4, I also did npm update in the main folder, and npm update -g, which ran through, but didnt update it, I think npm was bugged for me, because when I did "npm list cleverbot-node" it didnt list it, yet it was registered in the folder, so I reinstalled it, now its version 0.3.3. Sorry for the incident! (My linux server keeps bugging alot recently..)


[Improvement][API][num-3 & 4] add processDefinition releaseWorkflowAndSchedule

#6772
At the same time, online and offline workflows and scheduled workflows are not allowed. Empty workflows are not allowed to go online
We can use deleteProcessDefinitionByCode instead of deleteWorkflowAndSchedule ,so delete deleteWorkflowAndSchedule

Codecov Report

Merging #7044 (1bc4265) into dev (c5bde33) will increase coverage by 0.04%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev    #7044      +/-   ##
============================================
+ Coverage     32.62%   32.66%   +0.04%
  Complexity     1605     1605
============================================
  Files           431      431
  Lines         14342    14342
  Branches       1437     1437
============================================
+ Hits           4679     4685       +6
+ Misses         9213     9208       -5
+ Partials        450      449       -1

Impacted Files
Coverage Δ

...org/apache/dolphinscheduler/remote/utils/Host.java
37.77% <0.00%> (-2.23%)
:arrow_down:

...e/dolphinscheduler/remote/NettyRemotingClient.java
52.11% <0.00%> (-1.41%)
:arrow_down:

...er/master/dispatch/host/assign/RandomSelector.java
83.33% <0.00%> (+5.55%)
:arrow_up:

...r/plugin/registry/zookeeper/ZookeeperRegistry.java
54.54% <0.00%> (+7.27%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5bde33...1bc4265. Read the comment docs.


Rework underlying API for encoding/decoding

The current primary interface for using Chiron is based around functions which use statically-resolved type parameters (SRTP). This API should remain in place, but it should instead be based on an API that doesn't rely on SRTP.

[ ] Add symmetric encoder and decoder types:
type Decoder<'a> = Json -> JsonResult<'a>
type Encoder<'a> = 'a -> Json -> Json
[ ] Extract the default encoder/decoder functions from ToJsonDefaults and FromJsonDefaults into functions under Encode and Decode modules, respectively
[ ] Add monadic and applicative functions for Decoder<'a>
[ ] Add functor and chaining functions for Encoder<'a>
[ ] Create a fromJson {} computation expression, adapted from json {}
[ ] Create a toJson {} computation expression.

If we're going to have a fromJson CE (not a bad idea) would it make sense to introduce a toJson CE as well? The json CE would probably remain as a more "general" CE perhaps...

Yeah. I've just been re-looking at the Encoder<'a> type and thinking that it should be a state monad instead of just the function it is now, so as to support "mixin" encoders. If so, then that leads to a toJson {} CE to support that. We could still have the json {} CE supported. Though I'm of two minds on retiring it, I'll default to keeping it supported.

The json {} CE does support more than just mapping to/from. With the Json.Optic.* support, etc. it supports querying and modification of JSON structures. There is an argument as to whether that's needed outside of a mapping context, but it does so at the moment...

Right. I can see that. Maybe I just haven't had a use case for doing reading during a ToJson or writing during a FromJson. The Json.Optic.* support is definitely still going to be useful. This may be something that I need to throw against the wall to really see what it looks like.

Ok, I can see a reason for the json {} CE. It exists as a composition of the "state" and "either" monads. What we really need is to "run" the CE. The CE needs to be extended so that it can bind to Encoders and Decoders. That would allow the more direct serialization/deserialization method to live along side the more general-purpose json {} method.


[AnVIL DX] Export to Terra from dataset detail page

Dupe of https://github.com/DataBiosphere/data-browser/issues/3223.


Do I still need SublimeLinter-jshint if I use this linter?

I install npm install -g eslint
I install SublimeLinter-contrib-eslint
But when I open a jsx file, it still uses jshint not eslint, how do I fix this?

I suppose you just have SublimeLinter-jshint plugin installed. Remove or disable it.

Something changed after I remove SublimeLinter-jshint,
But it still can not work with jsx syntax

Check Tools - SublimeLinter - Debug Mode. I suppose you need to  add jsx option to .eslintrc http://eslint.org/docs/user-guide/configuring#specifying-language-options

where should I put the eslintrc file?
when I type eslint --init from CMD, it generate .eslintrc file in the current directiry.

it should be enough, just check if you have option jsx

Thanks, I get it eventually.

@roadhump
Excuse me, it's me again,
can this linter use a global .eslintrc file so that I don't have to run eslint --init in every project?

@littlee Yes, plugin works with configs as eslint itself http://eslint.org/docs/user-guide/configuring#configuration-cascading-and-hierarchy


Missing Options for Write debugging information

You are missing information on the Write debugging information section as per below.

Option
Documented

(none)
True

Small Memory Dump
True

Kernel Memory Dump
True

Complete Memory Dump
True

Automatic Memory Dump
False

Active Memory Dump
False

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 15dba2f3-d2e9-592e-b724-a2166213fc25
Version Independent ID: 4b63e388-c87b-3173-c623-a12d791b224e
Content: Configure system failure and recovery options in Windows - Windows Client Management
Content Source: windows/client-management/system-failure-recovery-options.md
Product: w10
Technology: windows
GitHub Login: @Deland-Han
Microsoft Alias: delhan

@denisebmsft . I think above table must be added in this article,  table format gives easy understanding..
@TroySAJordan  advice should be consider

Hello, @TroySAJordan ,
good point, I created the PR (https://github.com/MicrosoftDocs/windows-itpro-docs/pull/10608).
Thank you


custom fields for all data types

It would be great if you could extend custom fields to all data types. Currently it is not possible to add custom fields for rack roles, device roles, tenants and so on.
If we could add those, we could add more fields to keep more specific information e.g. for our device roles.

I second this. I have a specific device role (e.g. DB server) and would like to attach a custom field to servers with only this role. It would be confusing if all devices would have this custom field..

Custom fields should be used sparingly, as they introduce a significant performance overhead. This overhead is reasonable when dealing with primary objects, but attempting to extend custom fields to secondary objects would introduce a much higher performance penalty. Further, it doesn't yield much value over assigning the custom field to an object directly.

Currently it is not possible to add custom fields for rack roles, device roles, tenants and so on.

You can add custom fields to tenants.

I understand that you don't want users to experience any performance impact. However, I think they should be able to decide for themselves if they take the risk or not. Not being able to assign custom fields to a certain device type or role is clearly a disadvantage.


Miscellaneous fixes and tests

Codecov Report

Merging #50 into master will decrease coverage by 0.21%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##           master      #50      +/-   ##
==========================================
- Coverage   87.50%   87.28%   -0.22%
==========================================
  Files          12       12
  Lines         456      464       +8
  Branches       17       19       +2
==========================================
+ Hits          399      405       +6
- Misses         50       51       +1
- Partials        7        8       +1

Impacted Files
Coverage Δ

src/Data/Aeson/Schema/TH/Utils.hs
69.79% <72.72%> (+0.12%)
:arrow_up:

src/Data/Aeson/Schema/TH/Unwrap.hs
90.90% <100.00%> (+0.16%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04f4fc6...64c9133. Read the comment docs.


Group hiscores

Joe 7 on discord:

For created groups, would it be possible also add a "group hiscores?"
That way you could see how your lvls compare to other people in your group

Done in #121


Question: render partial pdf file instead of the whole pdf?

Link to PDF file (or attach file here):
test center.pdf
Configuration:

Web browser and its version: Chrome
Operating system and its version: OS X 10.10.5
PDF.js version<EMAIL_ADDRESS>Is an extension: No

Hello pdf.js team,
Thank you for your amazing work! I just start to use pdf.js from last month, it is truly incredible.
I wonder if there is any way to render partial pdf without scanning through the whole pdf.
I want to only render the center box from original pdf file

Will be rendered like this:

The case is I try to render the Commendation PDF files without showing the borders.
I can now achieve this by modifying the PageViewport(constructor) and Canvas Size.
However, some pdfs are rasterized with big sizes. Even I only render very center(1/10 width and height),  the total rendering time is almost the same as I render the whole pdf.
Is there any way to just select a field in the pdf and render it?( or it is actually how pdf.js works =~=).
I browsed the issues and couldn't find enough information. If it is possible, please give me some hint, so I can keep digging!
Thanks for reading my question, I appreciate so much!
This is the code where I calculate the rendering time.
    render: function PDFPageProxy_render(params) {
      var start = window.performance.now();
      .....
      .....
      var end = window.performance.now();
      var time = (end - start);
      console.log('%c rendering time: ' + time.toFixed(4) + 'ms', 'background: #9c0000; color: #fffdc7');
      }
      return renderTask;
    },

Cropping a PDF file is not supported by PDF.js. As you indicated, you could implement this yourself, but it will not speed up the rendering time of the PDF file. Even with range requests, you need a certain amount of data to be loaded to render a part of the PDF file. Unless you know where the parts of the PDF file you are interested in are in the file, you will not be able to render only a part of a page efficiently as far as I know.

Thanks for answering!

Can be connected with tracked item "provide boundary to getOperatorList and discard objects/text from the list that are not in the boundary" at https://github.com/mozilla/pdf.js/issues/6419#issuecomment-191423489

Link to PDF file (or attach file here):
test center.pdf
Configuration:

Web browser and its version: Chrome
Operating system and its version: OS X 10.10.5
PDF.js version<EMAIL_ADDRESS>Is an extension: No

Hello pdf.js team,
Thank you for your amazing work! I just start to use pdf.js from last month, it is truly incredible.
I wonder if there is any way to render partial pdf without scanning through the whole pdf.
I want to only render the center box from original pdf file

Will be rendered like this:

The case is I try to render the Commendation PDF files without showing the borders.
I can now achieve this by modifying the PageViewport(constructor) and Canvas Size.
However, some pdfs are rasterized with big sizes. Even I only render very center(1/10 width and height), the total rendering time is almost the same as I render the whole pdf.
Is there any way to just select a field in the pdf and render it?( or it is actually how pdf.js works =~=).
I browsed the issues and couldn't find enough information. If it is possible, please give me some hint, so I can keep digging!
Thanks for reading my question, I appreciate so much!
This is the code where I calculate the rendering time.
    render: function PDFPageProxy_render(params) {
      var start = window.performance.now();
      .....
      .....
      var end = window.performance.now();
      var time = (end - start);
      console.log('%c rendering time: ' + time.toFixed(4) + 'ms', 'background: #9c0000; color: #fffdc7');
      }
      return renderTask;
    },

Can you provide a code sample how you did it?


pull request for e2e test at 01/02/2017 22:15:11

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Special characters deployed wrong

Describe the bug
I have a few pipelines, were in the column mappings and column definitions are special characters like 'ä', 'ö'
When you deploy your development stage of the data factory to the next stage, all special characters, are deployed wrong
To Reproduce
Your script to reproduce the behaviour:
$RootFolder = "."

# Step 1
Install-Module Az.DataFactory -MinimumVersion "1.7.0" -Force -Scope CurrentUser
Install-Module -Name Az.Accounts -MinimumVersion "2.1.0" -Force -Scope CurrentUser
Install-Module -Name "azure.datafactory.tools" -Force -Scope CurrentUser
Import-Module -Name "azure.datafactory.tools" -Force

# Step 2
# Exclude Integration Runtime
$opt = New-AdfPublishOption
$opt.Excludes.Add("integrationruntime.*", "")
$opt.Excludes.Add("trigger.*", "")
$opt.Excludes.Add("linkedservice.*","")
$opt.StopStartTriggers = $false
$opt.DeleteNotInSource = $true

Publish-AdfV2FromJson -RootFolder "$RootFolder" -ResourceGroupName "$ResourceGroupName" -DataFactoryName "$DataFactoryName" -Stage $stage -Option $opt

Expected behaviour
Correct deployed special characters
Screenshots

Version of PowerShell module of:

azure.datafactory.tools 1.7.0
Az.Accounts 2.1.0

Fixed and will be released in ver.0.18


upgrade to m3

@longnguyen11288 as I said on kato, m3.medium is too small for a microbosh - its ephemeral disk is only 4G. If we're abandoning m1.medium then either m3.large or a different instance type family.

I added 160gb ephermal disk. I tested it and all tmp data goes to that disk
On 27 Apr 2015 19:11, "Dr Nic Williams"<EMAIL_ADDRESS>wrote:

@longnguyen11288 https://github.com/longnguyen11288 as I said on kato,
m3.medium is too small for a microbosh - its ephemeral disk is only 4G.
If we're abandoning m1.medium then either m3.large or a different
instance type family.
—
Reply to this email directly or view it on GitHub
https://github.com/cloudfoundry-community/bosh-bootstrap/pull/309#issuecomment-96846351
.

Ahhh awesome that this works.
On Mon, Apr 27, 2015 at 4:35 PM, Long Nguyen<EMAIL_ADDRESS>wrote:

I added 160gb ephermal disk. I tested it and all tmp data goes to that disk
On 27 Apr 2015 19:11, "Dr Nic Williams"<EMAIL_ADDRESS>wrote:

@longnguyen11288 https://github.com/longnguyen11288 as I said on kato,
m3.medium is too small for a microbosh - its ephemeral disk is only 4G.
If we're abandoning m1.medium then either m3.large or a different
instance type family.
—
Reply to this email directly or view it on GitHub
https://github.com/cloudfoundry-community/bosh-bootstrap/pull/309#issuecomment-96846351
.

Reply to this email directly or view it on GitHub:
https://github.com/cloudfoundry-community/bosh-bootstrap/pull/309#issuecomment-96850848

Merge away
On Mon, Apr 27, 2015 at 4:35 PM, Long Nguyen<EMAIL_ADDRESS>wrote:

I added 160gb ephermal disk. I tested it and all tmp data goes to that disk
On 27 Apr 2015 19:11, "Dr Nic Williams"<EMAIL_ADDRESS>wrote:

@longnguyen11288 https://github.com/longnguyen11288 as I said on kato,
m3.medium is too small for a microbosh - its ephemeral disk is only 4G.
If we're abandoning m1.medium then either m3.large or a different
instance type family.
—
Reply to this email directly or view it on GitHub
https://github.com/cloudfoundry-community/bosh-bootstrap/pull/309#issuecomment-96846351
.

Reply to this email directly or view it on GitHub:
https://github.com/cloudfoundry-community/bosh-bootstrap/pull/309#issuecomment-96850848

Except for the failing tests. What's up?
On Mon, Apr 27, 2015 at 6:32 PM, Dr Nic Williams<EMAIL_ADDRESS>wrote:

Merge away
On Mon, Apr 27, 2015 at 4:35 PM, Long Nguyen<EMAIL_ADDRESS>wrote:

I added 160gb ephermal disk. I tested it and all tmp data goes to that disk
On 27 Apr 2015 19:11, "Dr Nic Williams"<EMAIL_ADDRESS>wrote:

@longnguyen11288 https://github.com/longnguyen11288 as I said on kato,
m3.medium is too small for a microbosh - its ephemeral disk is only 4G.
If we're abandoning m1.medium then either m3.large or a different
instance type family.
—
Reply to this email directly or view it on GitHub
https://github.com/cloudfoundry-community/bosh-bootstrap/pull/309#issuecomment-96846351
.

Reply to this email directly or view it on GitHub:
https://github.com/cloudfoundry-community/bosh-bootstrap/pull/309#issuecomment-96850848

The terrible gem is whats up... locking down


Task Definition IP Address

Hey there,
thanks for putting this together, great work.
We are trying to run Vertx within a ECS environment testing with this Discovery Implementation. The Log files indicate that it works

Task Finds itself. (File Attached)
TaskInformation20190502.txt

Scan and Retrieval of configured services within the cluster as expected. (File Attached)
TaskScanResult20190502.txt

Does the response of 2) need to include the actual public IP address in order to connect ? The response that we are seeing does include the network bindings like this
 "networkBindings": [                         {                             "bindIP": "<IP_ADDRESS>",                             "containerPort": 5701,                             "hostPort": 5701,                             "protocol": "tcp"                         },                         {                             "bindIP": "<IP_ADDRESS>",                             "containerPort": 8080,                             "hostPort": 33054,                             "protocol": "tcp"                         }                     ],
But no further information about the IP address of the task. Any ideas ?
Are you guys planning to take this further ? Would be interested to contribute
Thanks,
Mark

Checking the code it seems like that it expected to have entries in the containers.networkInterfaces object which is empty in our case so I assume this is a configuration problem on our side as we have set task network mode to bridge.

@MarkThielen True, we only tested on Fargate for now which is indeed AWSVPC. Feel free to make a PR.
The devs from Hazelcast have promised to add support Fargate+ECS in but not sure if it is already available.

Thanks @urs-ikentoo-com,
checked where the hazelcast devs are and it seems it will still be some time, that is fine. I liked your guys implementation very much and have added regexps for cluster / service names as it matches our use case very well. I started a pull request let me know what you think.
Our use case comes from a Vertx framework perspective where we have encountered a couple of problems and could not find a clear solution. First of all the Hazelcast Discovery of ECS tasks and its IP addresses was a bit tricky until I found your solution. To make that work in different environments (dev, staging, prod) a way for defining cluster name regular expressions made sense for our setup as well as the service name regexp which lets us choose which services we want to discover in the cluster.
Added some comments and documentation to the readme.md file as well as some integration testing to see if and how the regexps work.
It is very likely that we will extend this until there is something official out there that we can review but the lightweight of this solution makes it very interesting.
Regards and thanks,
Mark

@MarkThielen True, we only tested on Fargate for now which is indeed AWSVPC. Feel free to make a PR.
The devs from Hazelcast have promised to add support Fargate+ECS in but not sure if it is already available.


Unexpected errors are missing colors when run with jest --watch

While test failures with a single test run using jest have the expected colored output from Unexpected, they are not colored at all when the failure happens using the jest --watch runner. Jest itself does have colored output in both cases.

This seems to be fixed after upgrading both unexpected and jest to the latest.


proposal: Change Operator from class to interface.

The motivation of this pull request is here:
A deriving class is unclear to understand "what we should need to implement this derived classs?". Thus, I think we should define interface and implement it for each implementations in these case:

There is no default behavior, or a few default behavior.
No need to create a base class instance.

Operator base class define only call() method, I think it will not be high cost for us to implement call method for each Operator implementations.
How do you think about this?

@saneyuki I don't at all disagree with this PR. If we use an interface, TypeScript will then complain if we don't implement the call method. And I don't think we're using the plain Operator type anywhere. SO this makes total sense.
I'll leave this PR sit for a while for others to chime in, but for now it looks fine to me.

attn @trxcllnt

@saneyuki @blesh the only reason this is a base class is because TypeScript creates an empty file for interfaces. Do we expect anybody to ever import the defaultCallFn from Operator?

the only reason this is a base class is because TypeScript creates an empty file for interfaces.

 Don't think of it as an "empty file"... think of it as "importing all of JavaScript in 0 bytes".

Do we expect anybody to ever import the defaultCallFn from Operator?

I doubt it.
Otherwise LGTM. @trxcllnt ?

@blesh lgtm

Thank you @saneyuki!
Merged with d565115d5c64c740dd5ce93060c816d0ad1daee1

@blesh @trxcllnt thank you for your reviewing!


Please consider fixing issues detected by repository checker

Notification from ioBroker Check and Service Bot
Dear adapter developer,
I'm the ioBroker Check and Service Bot. I'm an automated tool processing routine tasks for the ioBroker infrastructure. I have recently checked the repository for your adapter hiob for common errors and appropiate suggestions to keep this adapter up to date.
This check is based the current head revisions (master / main  branch) of the adapter repository
Please see the result of the check below.
ioBroker.hiob
   -
:thumbsup: No errors found
WARNINGS:

[ ] :eyes: [W156] js-controller 5.0.0 listed as dependency but 5.0.19 is recommended. Please consider updating dependency at io-package.json.

:thumbsup: No suggestions found
Please review issues reported and consider fixing them as soon as appropiate.
Warnings reported by repository checker should be reviewed. While some warnings can be ignored due to good reasons or a dedicated decision of the developer, most warnings should be fixed as soon as appropiate.
You may start a new check or force the creation of a new issue at any time by adding the following comment to this issue:
@iobroker-bot recheck
@iobroker-bot recreate
Please note that I (and the server at GitHub) have always plenty of work to do. So it may last up to 30 minutes until you see a reaction. I will drop a comment here as soon as I start processing.
Feel free to contact me (@iobroker-bot) if you have any questions or feel that an issue is incorrectly flagged.
And THANKS A LOT for maintaining this adapter from me and all users.
Let's work together for the best user experience.
your
ioBroker Check and Service Bot
Note: This issue replaces issue #86
@mcm1957 for evidence
Last update at Wed, 11 Sep 2024 15:43:26 GMT based on commit 88d47a016c0835a3768ab08b25cac458e1a4bf99
ioBroker.repochecker 3.0.2

@iobroker-bot recheck

This issue has been updated by ioBroker Check and Service Bot
RECHECK has been performed as requested.
No changes detected.


Upgrade specs2 to 3.x?

I use specs2 3.4 in my project with pact-jvm-provider-specs2, it will report some compilation error.
Sample code:
import org.specs2.execute.Result
import org.specs2.specification.{Example, Fragment, Fragments}
import au.com.dius.pact.provider.specs2.ProviderSpec

class MyPactRunnerSpec extends ProviderSpec {

  override def is: Fragments = {
    //...
  }

}

Compilation error:
overriding method is in trait SpecificationStructure of type => org.specs2.specification.core.SpecStructure;
[error]  method is has incompatible type
[error]   override def is: Fragments = {
[error]                ^
[error] one error found
[error] (test:compileIncremental) Compilation failed

Are we going to upgrade it?

Is specs2 3 backwardly compatible with specs2 2? Or will it break things? I'm assuming it will force people to upgrade their builds?

In relation to this issue: #20

I've upgraded Specs2 to version 3.6.4, hopefully it will work for you.

Version 3.0.4/2.2.15 has been released with Specs2 graded


error: function lower(enum_users_status) does not exist

From @slavafomin on August 8, 2016 22:36
Hello!
Thank you for this great library!
However, I'm having an error: function lower(enum_users_status) does not exist.
I'm not sure if this issue relates to this module or to waterline.
Here's my other comment (left unnoticed):
https://github.com/balderdashy/sails-postgresql/issues/99#issuecomment-236730862

The enum_users_status is a custom enumeration type used in our PostgreSQL database. The schema for it is:
CREATE TYPE "enum_users_status" AS ENUM (
  'foo',
  'bar',
  'baz'
);

Such database type should be easily mapped to string or text type.
It's defined in my model as:
    status: {
      type: 'string',
      size: 20,
      enum: ['foo', 'bar', 'baz'],
      defaultsTo: 'foo',
      required: true
    }

What is the reason for this error? Such configuration works perfectly fine with Sequelize in our other project.
$ npm ls waterline
app
├─┬<EMAIL_ADDRESS>│ └──<EMAIL_ADDRESS>└─┬<EMAIL_ADDRESS>  └──<EMAIL_ADDRESS>
Please advise, thank you!
Copied from original issue: balderdashy/sails-postgresql#256

From @sailsbot on August 8, 2016 22:36
@slavafomin Thanks for posting, we'll take a look as soon as possible.  In the meantime, if you haven’t already, please carefully read the issue contribution guidelines and double-check for any missing information above.  In particular, please ensure that this issue is about a stability or performance bug with a  documented feature; and make sure you’ve included detailed instructions on how to reproduce the bug from a clean install.   Finally, don’t forget to include the version of Node.js you tested with, as well as your version of Sails or Waterline, and of any relevant standalone adapters/generators/hooks.
Thank you!

From @slavafomin on August 8, 2016 22:41
@particlebanana could you please look at it? We've found this issue only when it's reached our production server, and I don't really want to convert our database columns to plain text types instead of enums. I really hope this issue could be solved promptly.
Thanks!

From @slavafomin on August 15, 2016 8:24
Is there anybody still working at this project?

From @particlebanana on August 15, 2016 15:31
@slavafomin it's because of the case-sensitivity setting. Try turning that off so the lower function doesn't get added on the query.
In your connection config add:
wlNext: {
  caseSensitive: false
}

From @slavafomin on August 16, 2016 14:36
Hello @particlebanana!
I've changed my config to:

module.exports.connections = {
  main: {
    adapter  : 'sails-postgresql',
    // ...
    wlNext: {
      caseSensitive: false
    }
  }
};

But, I'm still getting the same error.

From @slavafomin on August 16, 2016 14:45
I've pinpointed the problem to this module/file: https://github.com/balderdashy/waterline-sequel/blob/master/sequel/lib/criteriaProcessor.js#L382-L384
buildParam(): caseSensitive = undefined  <  "user"."email"
buildParam(): caseSensitive = undefined  <  "order"."user"
buildParam(): caseSensitive = true,      <  LOWER("order"."status")

Are you sure that sensitivity argument is correctly passed to the buildParam() function in all places?

From @slavafomin on August 28, 2016 15:43
UP?

From @slavafomin on August 21, 2016 23:7
Any further suggestions on this please?

From @sailsbot on October 3, 2016 23:0
@slavafomin,@sailsbot,@particlebanana: Hello, I'm a repo bot-- nice to meet you!
It has been 30 days since there have been any updates or new comments on this page.  If this issue has been resolved, feel free to disregard the rest of this message and simply close the issue if possible.  On the other hand, if you are still waiting on a patch, please post a comment to keep the thread alive (with any new information you can provide).
If no further activity occurs on this thread within the next 3 days, the issue will automatically be closed.
Thanks so much for your help!

From @slavafomin on September 2, 2016 0:47
If someone will get into the same situation as me: the dirty workaround would be to create a lower function for each enumeration type. You can do so in PostgreSQL this way:
-- enum_users_gender
CREATE OR REPLACE FUNCTION lower(enum_users_gender) RETURNS text AS $$
  SELECT lower($1::text);
$$ LANGUAGE SQL;

It was a terrible mistake to ever use Sails.js and especially Waterline in our products. Seems like we will have to pay for this dearly...

From @slavafomin on October 5, 2016 5:1
@sailsbot keep you hands from it tin can!

From @sailsbot on November 5, 2016 23:0
@slavafomin,@sailsbot,@particlebanana: Hello, I'm a repo bot-- nice to meet you!
It has been 30 days since there have been any updates or new comments on this page.  If this issue has been resolved, feel free to disregard the rest of this message and simply close the issue if possible.  On the other hand, if you are still waiting on a patch, please post a comment to keep the thread alive (with any new information you can provide).
If no further activity occurs on this thread within the next 3 days, the issue will automatically be closed.
Thanks so much for your help!

From @slavafomin on November 6, 2016 14:2
@sailsbot get lost already...

From @particlebanana on November 7, 2016 18:15
@slavafomin I'm moving the adapters away from the in house built sql generator to just use Knex. The version on Master should work in this use case - it also removes all the lower stuff.
It will be published as<EMAIL_ADDRESS>when the next version of Waterline is published.
I added the "bug" label to this so the bot will leave it alone.

🎉This was incorporated into the official 1.0 release.


Submissions: python alien/send request fails

What I've done:

[*] created a private Git repository
[*] copied the deploy key and added it to the repository
[*] created a branch called submission
[*] downloaded a starter kit
[*] committed and pushed the starter kit
[*] waited for more than 10 minutes

Here's the problem:
I'm using python. The starter-kit works. But when I replace the post command with:
import requests
res = requests.post("https://icfpc2020-api.testkontur.ru/aliens/send?apiKey=<my-api-key>", data="string")

then the testing stages fails with:
Traceback (most recent call last):
  File "/usr/local/lib/python3.8/site-packages/urllib3/connection.py", line 159, in _new_conn
    conn = connection.create_connection(
  File "/usr/local/lib/python3.8/site-packages/urllib3/util/connection.py", line 61, in create_connection
    for res in socket.getaddrinfo(host, port, family, socket.SOCK_STREAM):
  File "/usr/local/lib/python3.8/socket.py", line 918, in getaddrinfo
    for res in _socket.getaddrinfo(host, port, family, type, proto, flags):
socket.gaierror: [Errno -3] Temporary failure in name resolution

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/lib/python3.8/site-packages/urllib3/connectionpool.py", line 670, in urlopen
    httplib_response = self._make_request(
  File "/usr/local/lib/python3.8/site-packages/urllib3/connectionpool.py", line 381, in _make_request
    self._validate_conn(conn)
  File "/usr/local/lib/python3.8/site-packages/urllib3/connectionpool.py", line 976, in _validate_conn
    conn.connect()
  File "/usr/local/lib/python3.8/site-packages/urllib3/connection.py", line 308, in connect
    conn = self._new_conn()
  File "/usr/local/lib/python3.8/site-packages/urllib3/connection.py", line 171, in _new_conn
    raise NewConnectionError(
urllib3.exceptions.NewConnectionError: <urllib3.connection.HTTPSConnection object at 0x7feabcc7e490>: Failed to establish a new connection: [Errno -3] Temporary failure in name resolution

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/lib/python3.8/site-packages/requests/adapters.py", line 439, in send
    resp = conn.urlopen(
  File "/usr/local/lib/python3.8/site-packages/urllib3/connectionpool.py", line 724, in urlopen
    retries = retries.increment(
  File "/usr/local/lib/python3.8/site-packages/urllib3/util/retry.py", line 439, in increment
    raise MaxRetryError(_pool, url, error or ResponseError(cause))
urllib3.exceptions.MaxRetryError: HTTPSConnectionPool(host='icfpc2020-api.testkontur.ru', port=443): Max retries exceeded with url: /aliens/send?apiKey=<my-api-key> (Caused by NewConnectionError('<urllib3.connection.HTTPSConnection object at 0x7feabcc7e490>: Failed to establish a new connection: [Errno -3] Temporary failure in name resolution'))

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "app/main.py", line 14, in <module>
    main()
  File "app/main.py", line 8, in main
    utils.start(server_url=sys.argv[1],
  File "/solution/app/icfp_lib/utils.py", line 10, in start
    res = requests.post(url, data=data)
  File "/usr/local/lib/python3.8/site-packages/requests/api.py", line 119, in post
    return request('post', url, data=data, json=json, **kwargs)
  File "/usr/local/lib/python3.8/site-packages/requests/api.py", line 61, in request
    return session.request(method=method, url=url, **kwargs)
  File "/usr/local/lib/python3.8/site-packages/requests/sessions.py", line 530, in request
    resp = self.send(prep, **send_kwargs)
  File "/usr/local/lib/python3.8/site-packages/requests/sessions.py", line 643, in send
    r = adapter.send(request, **kwargs)
  File "/usr/local/lib/python3.8/site-packages/requests/adapters.py", line 516, in send
    raise ConnectionError(e, request=request)
requests.exceptions.ConnectionError: HTTPSConnectionPool(host='icfpc2020-api.testkontur.ru', port=443): Max retries exceeded with url: /aliens/send?apiKey=<my-api-key>(Caused by NewConnectionError('<urllib3.connection.HTTPSConnection object at 0x7feabcc7e490>: Failed to establish a new connection: [Errno -3] Temporary failure in name resolution'))

Am I doing something wrong?

I used the wrong url and api-key. One has to use the ones provided by argv


Added South Florida PHP User Group (SoFloPHP)

This one conflicts with previous PRs. Can you check and resubmit please?

OK, fixed. (pulled from your repo and then re-added SoFloPHP)


Reorgs causing memory leaks in block puller

LookaheadBlockPuller.PushBlock is called when the block is being delivered in BPB.Node_MessageReceived. Now consider the start of the method:
            uint256 hash = block.Header.GetHash();
            ChainedBlock header = this.Chain.GetBlock(hash);
            while (this.currentSize + length >= this.MaxBufferedSize && header.Height != this.location.Height + 1)

If we reorged to different chain before the block came, can't we get null header here? So do we rely here on the exception to be consumed by OnMessageReceived try/catch block around handler.DynamicInvoke(this, m);? This is probably OK, although not sure if intentional. But what if reorg happened later, but before this new block is consumed. It seems like it will be added to downloadedBlocks and never consumed. Looks like memory leak and if blocks are full, this means 1MB of memory gone forever, and eventually, if the node is run for a long time, it could sum up.

 [BlockPuller] Reorgs causing memory leaks in block puller

I think we only need to clear all 3 dictionaries on reorg that will sort everything, if a block arrives that was asked from a different chain it will be ignored as it will be treated like it was not solicited.

+- yes, but it has to be done very carefully, otherwise we can introduce more problems by fixing this.

Hi @Aprogiena , according to Jeremy you have done a lot of work on Reorg? Do you now if this still an issue?

AFAIK, this code has not been touched. The leak should still be present here.

@fassadlr this applies to both the puller (consensus) and store as well.

looking at this issue again, i think this can't be solved in BlockPuller class because that one has no idea about these reorgs
so he new logic of cleaning has to be implemented at higher level, there are two consumers of BlockPuller - LookaheadBlockPuller and StoreBlockPuller
LookaheadBlockPuller will probably be OK on its own to implement such a logic
but StoreBlockPuller not, so we have to go level up here again. so it is probably BlockStoreLoop and the BS steps classes that have to implement that logic
sounds quite complicated

alternatively, but not very elegantly, we could insert a timer into each downloaded block - DownloadedBlock class. something like - if no one consumes the block within 5 minutes, the block will remove itself
that would be very simple to implement, but it is very inelegant solution. would work though :/

Well that would work but we could instead of a time use the reorg events, when a reorg is detected in the LookaheadPuller we can call a method that cleans all the collections, alternatively this can also be called from the ConsensusLoop where we handle the reorg.
Same as Store the step that handles the reorg can clean up the puller.

i don't think we have anything like reorg event that would be reliable

fixed by the new puller btw so we may close it already

Fixed with activation merge.


[feature] Support the use of cross-database use of UDF

What type of PR is this：

[ ] bug
[x] feature
[ ] enhancement
[ ] refactor
[ ] others

Which issues of this PR fixes ：
Fixes #6446
Problem Summary(Required) ：
eg:
create function in database A
use function in database B

select A.udf() from xxx;

run starrocks_fe_unittest

run starrocks_fe_unittest

@Mergifyio backport branch-2.1

@Mergifyio backport rebase

run starrocks_be_unittest

[FE PR Coverage check]
:heart_eyes: pass : 5 / 6 (83.33%)
file detail

path
covered line
new line
coverage

:large_blue_circle:
com/starrocks/analysis/FunctionName.java
3
4
75.00%

:large_blue_circle:
com/starrocks/sql/parser/AstBuilder.java
2
2
100.00%

[FE PR Coverage check]
:heart_eyes: pass : 5 / 6 (83.33%)
file detail

path
covered line
new line
coverage

:large_blue_circle:
com/starrocks/analysis/FunctionName.java
3
4
75.00%

:large_blue_circle:
com/starrocks/sql/parser/AstBuilder.java
2
2
100.00%

https://github.com/Mergifyio backport branch-2.2

https://github.com/Mergifyio backport branch-2.3


Thumbnail crop should be higher

I believe the cropping used to make thumbnails is centered within the image, but this cuts off a lot of heads. I think the crop should be moved up a bit within the image.

i would suggest closing this issue: yes, SmartResize is hit and miss, but there isn't much that can be done about this in Sigal itself. this is a pilkit problem, and should be reported there.

SmartResize was one possible solution. I think it'd still make sense to adopt @hyperking's approach.

I realize now that an option was added in #263 to specify how thumbnails are cropped (the thumb_fit and thumb_fit_centering settings). This allows to crop from the top of the image, so I think the issue can be closed.

Oh, and just to clarify things, thumbnails are created directly with Pillow, so not using pilkit's processors:
https://github.com/saimn/sigal/blob/master/sigal/image.py#L139-L155

Ah, I had not noticed the thumb_fit_centering, thanks!


Reduce redundancy of SciF docker odm_workflow command regarding named volumes

Task to do
Take a look at the docker command and determine how to simplify. Might also be able to remove a mount command and use the my_input volume
docker run --rm -v /var/run/docker.sock:/var/run/docker.sock -v "${PWD}/inputs:/scif/data"/odm_workflow/images -v my_output:/output -e INPUT_VOLUME=my_input -e OUTPUT_VOLUME=my_output -e "INPUT_IMAGE_FOLDER=/images" -e "OUTPUT_FOLDER=/output" agdrone/canopycover-workflow:latest run odm_workflow plot_shapes.shp my_input my_output
Reason
Even though this is intended for copy-paste, it can be simplified
Result
Easier to understand docker command
Notes:
See:

https://github.com/AgPipeline/drone-makeflow/pull/4#discussion_r470133534
https://github.com/AgPipeline/drone-makeflow/pull/4#discussion_r470137093

On branch: https://github.com/AgPipeline/drone-makeflow/tree/odm_command_redundancies
Waiting on backlog of PRs to be reviewed


Better support for setting WWW-Authenticate header for basic autentification

Issue: The http-response for a failed basic autentification should include a WWW-Authenticate header.
But setting such a header is not supported as part of throwing a ca.uhn.fhir.rest.server.exceptions.AuthenticationException.
My current solution is also to implement handleException for this scenario in the autentification interceptor. The code looking something like this (as we only have basic autentification).
@Override     public boolean handleException(RequestDetails requestDetails, BaseServerResponseException e,HttpServletRequest request, HttpServletResponse response) throws ServletException, IOException {         if(e instanceof AuthenticationException) {             if(!response.containsHeader("WWW-Authenticate")) {                 response.addHeader("WWW-Authenticate", "Basic realm=\"Some realm\"");             }         }         return true;     }
Not super nice...

Definitely agreed this isn't great.
We don't actually use WWW-Authenticate ourselves, so I don't have much insight into how this would be used by HAPI developers. Any insights into what would be useful behaviour/API?

(sorry for the late reply - holiday)
One possible implementation would be to have a specific interceptor class for the basic http autentification (much like I was forced to do). This class should then have an overrideable implementation of String getRealm which the interceptor class would use.
Another way would be to extend the AuthenticationException to support setting any kind of response headers or more specifically a WWW-Authenticate header.
I myself prefer to the latter solution: extend the AuthenticationException with the possiblity to set/add a (WWW-Authenticate) response header(s).

Ah, I like the second idea a lot. I am going to add some code to allow any BaseServerResponseException to have arbitrary headers attached, and then add a method to AuthenticationException that allows you to specify the realm.

Thanks for the suggestion!
I've added a method to AuthenticationException that lets you add a custom realm, and you can now add any other arbitrary headers to the response you want as well.


✨Introduce Helm chart and entry.sh for implementing cluster deployment in separated containers

Summary

Updated entry,sh to support running separated processes
Updated core-helm-chart to:

Removed the mandatory kubestellar namespace. Use --namespace <name> instead or install in a new-project
Persist the PKI and kcp kubeconfig
Run kubestellar as 5 separated containers in a pod: kcp core mailbox-controller where-resolver placement-translator
Enable setting the ESPW name via value ESPW_NAME
Enable ensuring 0, 1, or more inventories using value ENSURE_INV
Enable ensuring 0, 1, or more WMW using value ENSURE_WMW
Access individual containers logs:

kubectl logs $(kubectl get pod --selector=app=kubestellar -o jsonpath='{.items[0].metadata.name}') -c kcp
kubectl logs $(kubectl get pod --selector=app=kubestellar -o jsonpath='{.items[0].metadata.name}') -c core
kubectl logs $(kubectl get pod --selector=app=kubestellar -o jsonpath='{.items[0].metadata.name}') -c mailbox-controller
kubectl logs $(kubectl get pod --selector=app=kubestellar -o jsonpath='{.items[0].metadata.name}') -c where-resolver
kubectl logs $(kubectl get pod --selector=app=kubestellar -o jsonpath='{.items[0].metadata.name}') -c placement-translator

Retrieve the admin.kubeconfig:
kubectl get secrets kubestellar -o 'go-template={{index .data "external.kubeconfig"}}' | base64 --decode > admin.kubeconfig

Related issue(s)
#1063 not fixed yet
#995 not working for kcp v0.11.0
Fixes #
#992
#993
#1048

/hold

@MikeSpreitzer I think the most critical gap is to find a way to restart kcp properly with the pki CA being maintained and have a functional admin.kubeconfig. So far I have not been able to do it. Please help if you have time.

@clubanderson the latest commit should resolve https://github.com/kubestellar/kubestellar/issues/1048

@francostellari : can you please bump the chart's major version number to 1?

/ok-to-merge

/unhold

What's with the file named 0 introduced by this PR?

@francostellari : can you please bump the chart's major version number to 1, so client code gets a strong signal that it creates different structure now? The chart's version number can describe the chart independent of (but I am not saying orthogonal to) the MCCM version that it deploys.

Done

What's with the file named 0 introduced by this PR?

sorry, removed

Perhaps core-helm-chart/README.md should have been deleted earlier. I left it only for internal consumption. What users should be reading is the documentation in the https://docs.kubestellar.io/main/Coding Milestones/PoC2023q1/commands/#deployment-into-a-kubernetes-cluster section. And this PR needs to keep the commands in that section working.

The title of this PR is currently wrong, right?  This PR does not introduce the Helm chart.

/unhold

back to /hold
config error

I am running through example1 using the deploy-as-workload option. It gets stuck at the following point (I start this excerpt with a get pods to show state).
bash-3.2$ kubectl get pods -A
NAMESPACE            NAME                                            READY   STATUS      RESTARTS   AGE
default              kubestellar-84fdf66696-dl9p5                    5/5     Running     0          113s
ingress-nginx        ingress-nginx-admission-create-2k96v            0/1     Completed   0          5m46s
ingress-nginx        ingress-nginx-admission-patch-qglgh             0/1     Completed   0          5m46s
ingress-nginx        ingress-nginx-controller-7456fdc894-slr78       1/1     Running     0          5m46s
kube-system          coredns-5d78c9869d-248xx                        1/1     Running     0          5m57s
kube-system          coredns-5d78c9869d-jxrg8                        1/1     Running     0          5m57s
kube-system          etcd-ks-host-control-plane                      1/1     Running     0          6m11s
kube-system          kindnet-t2jpd                                   1/1     Running     0          5m58s
kube-system          kube-apiserver-ks-host-control-plane            1/1     Running     0          6m11s
kube-system          kube-controller-manager-ks-host-control-plane   1/1     Running     0          6m11s
kube-system          kube-proxy-ghtr7                                1/1     Running     0          5m58s
kube-system          kube-scheduler-ks-host-control-plane            1/1     Running     0          6m11s
local-path-storage   local-path-provisioner-6bc4bddd6b-5flmh         1/1     Running     0          5m57s

bash-3.2$ kubectl kubestellar get-external-kubeconfig -o kcs.kubeconfig -X
+ shift
+ ((  0 > 0  ))
+ '[' -z kcs.kubeconfig ']'
+ set -e
++ kubectl get pods -n kubestellar -l app=kubestellar-server -o 'jsonpath={.items[0].metadata.name}'
+ server_pod=
+ sleep 10
++ kubectl get pods -n kubestellar -l app=kubestellar-server -o 'jsonpath={.items[0].metadata.name}'
+ server_pod=
+ sleep 10
++ kubectl get pods -n kubestellar -l app=kubestellar-server -o 'jsonpath={.items[0].metadata.name}'
+ server_pod=
+ sleep 10
^C

See git history problems here now.  Currently this PR diverges from main after commit 523ce181bd4b2b8268f71ac3b10a512fb03ce318 , which was the merge of #1047 last week. That won't pick up the recent improvements to kubestellar init (#1057, #1089), which merged later.
In this PR now, scripts/kubectl-kubestellar-deploy sets the default core image tag to a build of commit 8259fa7c7 , which is later than 523ce181bd4b2b8268f71ac3b10a512fb03ce318 but does not include the changes in this PR.

Also, the tag main-mc currently refers to a multi-platform manifest that was built from commit c722cbdc , which also does not include all of the changes in this PR.
The good news is that this PR is still consistent with main regarding the default syncer image tag.
I am going to launch a build of the current version of this PR.

BTW, when you rebase, it would probably be good to squash together all those README updates.

Oh! "Merge branch 'kubestellar:main' into helm-chart-separated-containers"! Please do not do that. It violates the discipline we agreed to regarding keeping the git history simple.

I just built a core image for commit cd4136ab4 , and while doing that noticed that the changes since c722cbdc are non-functional.

So I updated kubectl-kubestellar-deploy to ask for core image tag "git-c722cbdc-clean" (same image as "main-mc" at the moment). Deleted the old chart instance and made a new one with the updated deploy plugin. But still the get-external-kubeconfig plugin is looking for the wrong pod.
bash-3.2$ kubectl kubestellar get-external-kubeconfig -o kcs.kubeconfig -X
+ shift
+ ((  0 > 0  ))
+ '[' -z kcs.kubeconfig ']'
+ set -e
++ kubectl get pods -n kubestellar -l app=kubestellar-server -o 'jsonpath={.items[0].metadata.name}'
+ server_pod=
+ sleep 10
++ kubectl get pods -n kubestellar -l app=kubestellar-server -o 'jsonpath={.items[0].metadata.name}'
+ server_pod=
+ sleep 10
...

And this tells why: the namespace is not what's expected.
bash-3.2$ kubectl get pods -A -L app
NAMESPACE            NAME                                            READY   STATUS      RESTARTS       AGE    APP
default              kubestellar-cfb965b4d-gnvhm                     5/5     Running     1 (4m5s ago)   4m9s   kubestellar
...

See git history problems here now. Currently this PR diverges from main after commit 523ce18 , which was the merge of #1047 last week. That won't pick up the recent improvements to kubestellar init (#1057, #1089), which merged later.
In this PR now, scripts/kubectl-kubestellar-deploy sets the default core image tag to a build of commit 8259fa7 , which is later than 523ce18 but does not include the changes in this PR.

I rebased but did not squash the cmmits.
I know for sure that I would screw up something

Oh! "Merge branch 'kubestellar:main' into helm-chart-separated-containers"! Please do not do that. It violates the discipline we agreed to regarding keeping the git history simple.

I'm sorry I don't understand and I don't know how to fix this.

And this tells why: the namespace is not what's expected.
bash-3.2$ kubectl get pods -A -L app
NAMESPACE            NAME                                            READY   STATUS      RESTARTS       AGE    APP
default              kubestellar-cfb965b4d-gnvhm                     5/5     Running     1 (4m5s ago)   4m9s   kubestellar
...

The deployment ns is now a user choice, as requested.

I am going to continue testing what I have, choosing to put the core into the kubestellar namespace.

Ugh, this is why I opened #414.
bash-3.2$ kubectl kubestellar deploy --external-endpoint yep.yep:6443 -n kubestellar --create-namespace
/Users/mspreitz/go/src/github.com/kubestellar/kubestellar/bin/kubectl-kubestellar-deploy: missing value for long flag --create-namespace

After manually creating the kubestellar namespace and doing the deploy, we are closer but still no cigar, different label.
bash-3.2$ kubectl get pods -A -L app
NAMESPACE            NAME                                            READY   STATUS      RESTARTS   AGE    APP
...
kubestellar          kubestellar-cfb965b4d-d5d6c                     5/5     Running     0          52s    kubestellar
...

I rebased

No, you did not.  You merged main into this PR's branch.  Please do not do that.  It violates the discipline that we agreed to for keeping simple git history.

run_kcp insists on FAILURE of the command to delete the Secret.
the ready file is created in the init container, but currently other plugins seek it in the default container.

out-of-the-box spaces a bit incoherent:
bash-3.2$ kubectl get Workspaces
NAME                                                       TYPE           REGION   PHASE   URL                                                  AGE
1lce1d0yfx2ti8lb-mb-53b3a371-5df9-4799-92f4-0462c3d24611   organization            Ready   https://<IP_ADDRESS>:6443/clusters/2a9byjmlatxgls74   23s
1lce1d0yfx2ti8lb-mb-7ccf8af2-deb3-4336-be7c-4a336f871464   organization            Ready   https://<IP_ADDRESS>:6443/clusters/27nbqr8af6tu7rpi   29s
compute                                                    universal               Ready   https://<IP_ADDRESS>:6443/clusters/3yd4rtw13irl9qkz   20m
espw                                                       organization            Ready   https://<IP_ADDRESS>:6443/clusters/2msbc26i71vb9b07   20m
imw1                                                       organization            Ready   https://<IP_ADDRESS>:6443/clusters/1lce1d0yfx2ti8lb   20m
inv1                                                       organization            Ready   https://<IP_ADDRESS>:6443/clusters/2wfiqqxbuhpm1rci   20m
wmw1                                                       organization            Ready   https://<IP_ADDRESS>:6443/clusters/ftdvvmtpu621oqtj   20m

I successfully ran through example1 with deploying the core to a kind cluster.
/lgtm
/approve
Thanks!


{request} Not updated the repository !

In DockerHub you have updates the quality of voice and features but when I build it using github docker file  voice quality is poor
So try to update it

I'll check on that this week. I'm hoping to push a new version of OpenTTS with support for some of the SSML standard.

Please try OpenTTS 2.1 and see if it's better.