Extended JDTLS support

Clarification
This is something I'd like to do and contribute. I'm creating an issue to see if there is interest from the community and it stays within this project's scope before I spend time on something that won't be merged.
Issue
JDTLS is a non-conventional language server, I've been using it for 3 months and it works fine but sometimes errors pop up, code generations always use incorrect indentation and I know there's a lot of missing features.
I know there's an amazing plugin (nvim-jdtls) that takes care of this, but it more than just a language server client including testing, debugging, bytecode inspection and more...
There's also an issue on how it's launched, the command is huge (you gotta spin up jvm with lots of arguments) and there's no convention. Also, the default cmd has no Lombok support which is a must for writing modern java.
Proposal

Add some extended client capabilities
Autodetect if user installed jdtls via AUR or JDTLS-LAUNCHER
Allow Lombok setup with default cmd
Add better documentation

I'm in favor of anything that does not substantially add to the complexity of the jdtls configuraiton in nvim-lspconfig, however, I am not in favor of anything that is too opinionated (does adding lombok support result in strange behavior for those not using lombok?) or anything that is tailored to a specific installation method (I would consider the AUR to be an unreliable source generally).
Re: extending client capabilities which capabilities were you thinking of? If we advertise something core does not support it may result in undefined behavior from the language server.
I really want to push people to use/improve nvim-jdtls, is there an issue with not using the additional features it affords?

but it more than just a language server client including testing, debugging, bytecode inspection and more...

All of that functionality is based on the language server. The debug-adapter is an extension to the language server, and doesn't work without it. The bytecode inspection is using the language server to retrieve the classpath of your project. Besides - having that functionality in it has no overhead at runtime. Most of it also doesn't have an overhead at import time, because it lives in separate modules.

There's also an issue on how it's launched, the command is huge (you gotta spin up jvm with lots of arguments) and there's no convention. Also, the default cmd has no Lombok support which is a must for writing modern java.

One of the reasons I ended up letting users create their own config is so that they can easily extend the java/jvm options - which for example lets them add lombok support or configure the heap size.
Besides that, @mjlbach and me were actually talking about how we could streamline the setup to be closer to what lspconfig is doing.

Add better documentation

Would love to hear what's missing from the nvim-jdtls documentation

extending client capabilities which capabilities were you thinking of?

All the necessary ones to prevent No delegateCommandHandler error and all code actions that can be resolved with no more
than 10 lines of code to reduce complexity

does adding lombok support result in strange behavior for those not using lombok?

No, Lombok is a library that provides annotations to generate implicit methods such as getters, setters, constructors and others. You need to add a javaagent to jdtls execution command for it to detect the existence of these implicit methods.

Both the launcher in AUR and the JDTLS-LAUNCHER ignore that you probably want to set a different workspace folder per project.

Agree, but the location of this directory does not affect the language server at all. I think there has to be a standard and provide an option to change it.

Would love to hear what's missing from the nvim-jdtls documentation

I'm glad that you saw this, I wanted to reach you at some point too.
I've been talking via discord with other neovim users when I had to set up JDTLs. nvim-jdtls had all the features I wanted but it wasn't easy when you know nothing. Everyone pointed me to this video but it still took me like 3 hours to set up. I've seen many people resort to COC for this reason, you can't beat a :CocInstall.
When I had everything set up my vimrc became a mess. Having a separate own code_actions function and the start_or_attach working different to lspconfig's setup() function, I ended up with lots of conditionals and autocmds.
Because I need Java for work and I didn't want to spend all working day setting up everything, I created jdtls and decided to go lspconfig only, and talking with others they found it useful too reducing jdtls setup time to about 5 minutes.
My ultimate goal here is to reduce the time it takes to set up jdtls and try make use of all its features. What I see here is:

JDTLS is lacking an official installer and launcher,
Some of the features that nvim-jdtls provides could be upstreamed into lspconfig so people that don't need anything extra doesn't have to install and configure an aditional plugin
nvim-jdtls does an excellent job but the API and documentation could be improved

I'm willing to help in all 3 cases, I just want to know what's the best way of doing so

Some of the features that nvim-jdtls provides could be upstreamed into lspconfig so people that don't need anything extra doesn't have to install and configure an additional plugin

I think the issue here is, I don't use Java, and I can't really support people asking specific questions about Java. We're getting to a fairly massive number of language servers, and when I want to make tree-side changes that are not reg-exable it takes an unreasonable amount of time. I'd like to move more and more to create a common framework for language specific extensions like the nvim-jdtls model. Lspconfig should be a decent fallback that implements only things on the LSP specification. I've been somewhat lax about this historically, but as language specific plugins emerge I'm in favor of removing anything we've added in lspconfig that is off-spec.

JDTLS is lacking an official installer and launcher

I'm hoping package managers add it to their repos, or that people prefer the prebuilt binaries which should be easy to put somewhere on the path. I think JDTLS-LAUNCHER would need, at minimum, to remove all usage of elevated privileges (don't install things into non-user directories) for me to consider adding it in the installation instructions. If people are really having issues getting it installed, the LspInstall plugin should likely be updated.

All the necessary ones to prevent No delegateCommandHandler error and all code actions that can be resolved with no more than 10 lines of code to reduce complexity

By default the only command that eclipse.jdt.ls sends that isn't part of the core spec is the java.apply.workspaceEdit, that should already be handled here: https://github.com/neovim/nvim-lspconfig/blob/master/lua/lspconfig/jdtls.lua#L107
Any of the other extensions require an opt-in via a setting in the init_options. Supporting them you'd likely end up requiring a dedicated code-action function as well. There is a reason I had to do that in nvim-jdtls, see https://github.com/neovim/neovim/issues/12326 / https://github.com/neovim/neovim/pull/14115 - There is work to make that unnecessary in the future.

When I had everything set up my vimrc became a mess. Having a separate own code_actions function and the start_or_attach working different to lspconfig's setup() function, I ended up with lots of conditionals and autocmds.

Can you elaborate why you needed conditionals and lots of autocmds?  Using both lspconfig setup and the autocmd for jdtls should be possible without any extra conditionals.
The code_action function from jdtls is even a drop-in replacement for vim.lsp.buf.code_action. (And otherwise you could work with 2 different on_attach hooks.)

nvim-jdtls does an excellent job but the API and documentation could be improved

It would help getting more insights into where you got stuck, or with which part you struggled. "could be improved" is too generic and not actionable feedback.

I'm hoping package managers add it to their repos, or that people prefer the prebuilt binaries which should be easy to put somewhere on the path.

Thank you for the feedback, I plan to push this idea to Eclipse for an official launcher or improve mine i.

I don't use Java, and I can't really support people asking specific questions about Java.

My plans did not extend outside the existing jdtls.lua file, simply updating the multiple handlers and providing much better settings. Anyways, I see why you wouldn't want to have things outside spec.

By default the only command that eclipse.jdt.ls sends that isn't part of the core spec is the java.apply.workspaceEdit

Yes but still the current way of handling it causes the error to appear when I organize imports or remove variables. I think it should either be removed or completed.

Any of the other extensions require an opt-in via a setting in the init_options.

Yes, this is pretty much what I'd like to support by default. As far as I've seen it should be possible to implement at least a few and the issue you linked was something I also considered and it's cool to see that there's a discussion about that. I mainly opened this issue to know what the scope for this project is and know where I should push for changes.

"could be improved" is too generic and not actionable feedback

I didn't want to go into details because I don't think it's the right place, do you mind if I open an issue on your repo with full details?

My plans did not extend outside the existing jdtls.lua file, simply updating the multiple handlers and providing much better settings. Anyways, I see why you wouldn't want to have things outside spec.

Sure! If there's a way to improve the handlers that's not implemented in lspconfig go for it :) I expect though that it will require duplicating a lot of functionality in nvim-jdlts (esp around code actions), but I'll defer to @mfussenegger on this one

Any of the other extensions require an opt-in via a setting in the init_options.

Yes, this is pretty much what I'd like to support by default

This reads as "I'd like lspconfig to do what nvim-jdtls already does, because ..."
Duplicating these efforts is not a good use of our time. The idea was and is for lspconfig to contain a set of default configurations for various language servers. Any "not part of core specification" extensions are out of scope. If it wasn't for that - I could've integrated the nvim-jdtls functionality in lspconfig to begin with.
I'd rather spend the time on addressing the because reasons.
Given that many servers provide functionalities that are beyond the core LSP spec, we expect more language specific plugins to pop-up - and there are already several of them.
If you've concrete suggestions on how to make the extensions feel more aligned, so that any nvim-lsp-LANG-X doesn't feel foreign but provides a similar setup experience, let us know.

I didn't want to go into details because I don't think it's the right place, do you mind if I open an issue on your repo with full details?

Please go for it.

Sorry for the late response but I had to think a little before answering!

This reads as "I'd like lspconfig to do what nvim-jdtls already does, because ..."

My original plan was to extract some of nvim-jdtls functionality and include it in lspconfig; I wanted to split the problem of having to set up two plugins at the same time into setting one up first and then the other. After talking with you and thinking about it I came to the same conclusion as yours that it will simply take too much time for the benefits.
To close this issue I'd like to make a contribution including a documentation update. Whenever someone wants to set up a language server the first thing they will look at is CONFIG.md file and it's far from providing enough information to be able to set up at least the basics.
I will also put effort into nvim-jdtls which seems to be the best solution.
Thank you both @mjlbach and @mfussenegger and sorry if I took much time of yours with this discussion, I wanted to reduce jdtls setup time and didn't know where to start!

No worries, please file a PR if there are actionable items from this. For now I'm going to close


docker-outside-of-docker failed to install -> rep ubuntu/20.04/prod focal InRelease is not signed

Trying to use the images:

https://mcr.microsoft.com/en-us/product/devcontainers/dotnet/tags

6.0-focal published June 24, 2024
dev-8.0 published June 24, 2024

The deployment errors out seemingly due to docker-outside-of-docker. Not sure if this is the cause or just a symptom of the failure.

5.546 W: GPG error: https://packages.microsoft.com/ubuntu/20.04/prod focal InRel
ease: The following signatures couldn't be verified because the public key is no
t available: NO_PUBKEY EB3E94ADBE1229CF
5.546 E: The repository 'https://packages.microsoft.com/ubuntu/20.04/prod focal
InRelease' is not signed.
5.547 ERROR: Feature "Docker (docker-outside-of-docker)" (ghcr.io/devcontainers/
features/docker-outside-of-docker) failed to install! Look at the documentation
at https://github.com/devcontainers/features/tree/main/src/docker-outside-of-doc
ker for help troubleshooting this error.

It looks like the docker outside of docker feature install.sh only imports the Microsoft signing keys if Moby is used:
https://github.com/devcontainers/features/blob/414d3450434b9072f01afe80cab226c60088224a/src/docker-outside-of-docker/install.sh#L215-L229
I do notice the Sample project I'm using doesn't provide a Moby property, which per docker outside of docker docs, moby should be true by default. Not sure why the key setup isn't working.
https://github.com/Azure-Samples/azure-sql-library-app-blazor/blob/0a1ba8c97744d887f209d95c7f932ddf0eb8b04c/.devcontainer/devcontainer.json#L59-L61
		"ghcr.io/devcontainers/features/docker-outside-of-docker:1": {
			"version": "latest"
		}

Solution was to add config to my dockerfile to import microsoft signing keys as suggested by Microsoft documentation. not sure why the key import in docker-outside-docker install.sh doesn't fulfill whatever is happening below:
# Import Microsoft Signing Keys
# https://learn.microsoft.com/dotnet/core/install/linux-ubuntu#unable-to-locate--some-packages-could-not-be-installed
RUN sudo apt-get install -y gpg wget \
    && wget https://packages.microsoft.com/keys/microsoft.asc \
    && cat microsoft.asc | gpg --dearmor -o microsoft.asc.gpg \
    && sudo mv microsoft.asc.gpg /etc/apt/trusted.gpg.d/ \
    && sudo chown root:root /etc/apt/trusted.gpg.d/microsoft.asc.gpg

The docker-outside-of-docker feature's install.sh script should ideally handle the import of the necessary GPG keys. However, there could be several reasons why this might not be working as expected:

Conditional Logic: The script might have conditional logic that skips the key import under certain conditions. For example, it might only import the keys if a specific version of Docker (like Moby) is being installed.
Environment Differences: The environment in which the script runs might differ from your Dockerfile environment, leading to discrepancies in the key import process.
Permissions: The script might not have the necessary permissions to import the keys or move them to the correct location.


Playground unable to parse the wasi witx definitions

https://bytecodealliance.github.io/witx-bindgen/
extra tokens remaining after parse
     --> input:8:1
      |
    8 | (typename $size u32)
      | ^

Ah, the old-witx-compat feature of witx-bindgen-gen-core needs to be enabled for it to work.

Yes the exact syntax parsed by this right now is different than the current s-expression syntax slightly. I think some changes were reverted on the WASI repo and I didn't reflect those changes here. The syntax is enabled, though, for example you can see with:
(module $x
    (typename $a u32)
)

in the online preview.

Yeah, it works. I do need to rename the $fd resource though to avoid the above error and then it crashes when trying to generate js:
panicked at 'called `Option::unwrap()` on a `None` value', crates/gen-js/src/lib.rs:1577:74
    error https://bytecodealliance.github.io/witx-bindgen/browser/bindings.js:14
    Config$GT$3new28_$u7b$$u7b$closure$u7d$$u7d$28_$u7b$$u7b$closure$u7d$$u7d$17hc3548f0a0e19d9b8E https://bytecodealliance.github.io/witx-bindgen/demo.wasm:21495
    _ZN3std9panicking20rust_panic_with_hook17h2d9079427a2d996aE https://bytecodealliance.github.io/witx-bindgen/demo.wasm:1238878
    _ZN3std9panicking19begin_panic_handler28_$u7b$$u7b$closure$u7d$$u7d$17h4e49f350d9f4de36E https://bytecodealliance.github.io/witx-bindgen/demo.wasm:1235338
    _ZN3std10sys_common9backtrace26__rust_end_short_backtrace17h91e711607d91be52E https://bytecodealliance.github.io/witx-bindgen/demo.wasm:1235193
    rust_begin_unwind https://bytecodealliance.github.io/witx-bindgen/demo.wasm:1238631
    _ZN4core9panicking9panic_fmt17h1fea623755fffed7E https://bytecodealliance.github.io/witx-bindgen/demo.wasm:1246871
    _ZN4core9panicking5panic17h38cac710b5048ca0E https://bytecodealliance.github.io/witx-bindgen/demo.wasm:1243875
    Bindgen$GT$4emit17hc14e5c5c3ef64090E https://bytecodealliance.github.io/witx-bindgen/demo.wasm:641662
    _ZN5witx23abi18Generator$LT$B$GT$4emit17h29e995f42a9bba15E https://bytecodealliance.github.io/witx-bindgen/demo.wasm:683197
    _ZN5witx23abi18Generator$LT$B$GT$4lift17ha82fa66619137e3cE https://bytecodealliance.github.io/witx-bindgen/demo.wasm:689112
    _ZN5witx23abi18Generator$LT$B$GT$8lift_all17h900e8d3422513b3fE https://bytecodealliance.github.io/witx-bindgen/demo.wasm:703981
    _ZN5witx23abi18Generator$LT$B$GT$4call17h002cf80a6b6f2a58E https://bytecodealliance.github.io/witx-bindgen/demo.wasm:701440
    Interface$GT$4call17h4b1056d7b69908f3E https://bytecodealliance.github.io/witx-bindgen/demo.wasm:665379
    Generator$GT$6import17h7c00bc37a10c78aeE https://bytecodealliance.github.io/witx-bindgen/demo.wasm:598427
    _ZN21witx_bindgen_gen_core9Generator8generate17h8c254e199c99850fE https://bytecodealliance.github.io/witx-bindgen/demo.wasm:35853
    Config$GT$6render17hb8945f660c715d4fE https://bytecodealliance.github.io/witx-bindgen/demo.wasm:17252
    render https://bytecodealliance.github.io/witx-bindgen/demo.wasm:27402

Hoping this is a related query, else please point me to the right forum/issue.
Can witx-bindgen be used to generate Python (wasmtime-py) host bindings for wasi-nn witx?
I'm getting errors like the one posted in this issue, and reading through these details, I want to check if this is supported at all?
Otherwise, if not witx-bindgen, could you please tell what is the best way to provide Python host-side functions in a Python program embedding wasmtime-py, that will satisfy something like the wasi-nn witx required by a Wasm guest module?

@bjorn3 can you open a separate issue specifically for the JS error you're seeing?
@sambitnayak yes it's supported, but the s-expression-based syntax is not precisely the same as the one supported by the witx crate at this time. It diverged at some point and I haven't gotten around to trying to fix it.
For reference all implementations are tested against wasi snapshot as well as a version of wasi purely using interface types so it's not like things aren't supported and/or don't work, it's probably just fiddly syntax.

@bjorn3 can you open a separate issue specifically for the JS error you're seeing?

Done: https://github.com/bytecodealliance/witx-bindgen/issues/69


Fix lint ci

JS Lint CI is failing all the sudden and I'm also getting different results vs running test:lint:js locally.

[ ] Add lint config paths to lint workflow paths to trigger workflow when they're changed


Make default style meet WCAG AA

Accessibility by default is important.
The colors with a too low contrast were adjusted just
so much that they match the required contrast of 4.5.
Part of #1718.

tests/html_linenos_expected_output somehow needs to be updated for the tests to pass ... but I don't know how.

Thanks for preparing this! I'll fix the lineos update. Do you happen to have a before/after screenshot for the default style?

Yeah, I added screenshots for all changed colors.

Thanks a lot. That is much more subtle than I expected.

Indeed, thanks a lot!

You're welcome :) Once this is merged, I'll proceed with the steps I outlined in #1718.

Merged, thanks a lot. Pray continue.


Overwrite lunch session for session time table by ItemDecoration

Kind (Required)

Proposal / Discussion

Overview (Required)

Currently, lunch is only HallA, But we want to spread it. It is hard to realize this with LayoutManager, so overwrite it with ItemDecoration.

Links

https://github.com/DroidKaigi/conference-app-2019/blob/master/feature/session/src/main/java/io/github/droidkaigi/confsched2019/session/ui/TabularFormSessionPageFragment.kt#L61

I'm working on now. I'll create PR today.

I'm looking forward to your PR 😄


Will there be a possibility of porting to a lower version?

Just a suggestion, e.g. for 1.16.5 :)

Thanks for the suggestion, version for 1.16.5 coming soon

@ALONEJINGYAN pls test https://legacy.curseforge.com/minecraft/mc-mods/achievements-optimizer/files/4866775


[Cherry Pick 4.13] Settings scope: support backward compat setting scope, remove ComponentRegistration in DialogStateManager (#5397)

Cherry pick of https://github.com/microsoft/botbuilder-dotnet/pull/5397

Settings scope: support backward compat setting scope, remove ComponentRegistration in DialogStateManager
Legacy settings: add test that failed before and now passes with the fix

SettingsScope was not working in a backward compatible way because of 3 subtle things happening simultaneously:

DialogStateManager was registering the DialogcomponentRegistration by itself
We removed IConfiguration from the turnState, so legacy SettingsMemoryScope did not have access to configuration in turn state (so the registration in dialog state manager was not getting any settings)
SettingsMemoryScope only gets evaluated once

Here we remove the DialogStateManager call to DialogComponentRegistration since this is the last call to ComponentRegistration in non-test code. Legacy code will still work because legacy adapters still add IConfiguration to the turnState. New code will use the new route.
Also, fixing a breaking change where we would break folks using the default constructor of SettingsMemoryScope.
Note that tests still rely on ComponentRegistration and we have an R14 change to remove these, basically by moving the TestAdapter and TestScript to the BotComponent pattern. This work is tracked here: https://github.com/microsoft/botbuilder-dotnet/issues/5396

/azp run BotBuilder-DotNet-CI-PR-yaml

/azp run BotBuilder-DotNet-CI-PR-yaml

/azp run BotBuilder-DotNet-CI-PR-(MacLinux)-yaml


How to introduce and demonstrate substrate playground?

https://github.com/substrate-developer-hub/substrate-developer-hub.github.io/commits/df/tut/playground
@sacha-l / @jimmychu0807 / @jeluard  - this (now stale) tutorial was to replace (or be an alternative to) the "add a pallet" nicks tutorial using the playground. It would need a rework to get it ready to publish, but if we want to highlight playground in general, this could be the go-to referenced as an alternative to building on your local machine as an example of using the playground.
What are your thoughts or getting this reworked and published? Or better alternatives to show off playground on the devhub?

Playground can be better integrated using some kind of JS integration. Would it be doable with the current framework?
Also I understand there is some work being done on devhub as a whole.

@NukeManDan
hmm... I have never tried this branch, and this branch seems really old. Did you run this branch. If that's handy, can you make a screenshot how playground is integrated in this branch?

@jimmychu0807 Its a tutorial that incorporates using Playground to complete it, using screenshots of Playground for relevant steps. I think it was a great initiative but we should leave it out for that sake of not risking wasted efforts once we get integrating Playground in all tutorials (one day!)

I am thinking to have a better integration between Substrate Node template and playground, adding a link on top of the node template readme. Once the integration is stabilised, we can do further integration from knowledge base to playground.

Let''s open a new issue for the new docs if needed https://github.com/substrate-developer-hub/substrate-docs/


.mkv/x-matroska support with subtitle  (Feature request)

Can you please add support to  .mkv/x-matroska files? with custom subtitles Onclick/Onplay
In html5/xhtml you can play matroska files using

<video src="http://example.com/x.mkv" type='video/x-matroska; codecs="theora, vorbis"' ></video>

And using Track tag for subtitles
I also tried to add the codecs in your webtorrent

(webtorrent.min.js (latest version))

but I failed.

Idk if possible, but not maintaining the project atm.
Diego

On 12/07/2020, at 5:43 AM, josh mora<EMAIL_ADDRESS>wrote:

Can you please add support to .mkv/x-matroska files? with custom subtitles Onclick/Onplay
In html5/xhtml you can play matroska files using

And using Track tag for subtitles
I also tried to add the codecs in your webtorrent
(webtorrent.min.js (latest version))
but I failed.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.


Increase Webhook Timeout/Await

Hi, I need to increase the time that the webhook awaits before giving timeout. Can anyone point me in the right direction please?
Is it here: https://github.com/postalhq/postal/blob/2595481b266199d8e29347dea2764f2c10202805/app/models/webhook_request.rb#L57

If you have found the line of code, you can change it yourself as you need but be warned that it may get reset if you update Postal.
5 seconds is already a long time to be waiting, does whatever receives the webhook need to be improved?

@willpower232 agreed 100%. Yet at the near maximum, 14mg per email, 5s very rarely is not enough. Still working to improve the API. We manage to figure it out. we change this line:
https://github.com/postalhq/postal/blob/57cc0239bdf745c63cd18f366c4f3c36855cff2f/lib/postal/http.rb#L58
for this:
timeout = 10 #options[:timeout] || 60


YOLO Person Detection mAP value

I tried to recreate the YOLO person-detection model by following yolo_person_detection.ipynb. According to the model zoo page, it should reach a<EMAIL_ADDRESS>of 51.49 %. However, when I run the accuracy evaluation, this is the output:
 detections_count = 70741, unique_truth_count = 10777
class_id = 0, name = person, ap = 21.04%   	 (TP = 2916, FP = 7206)

 for conf_thresh = 0.25, precision = 0.29, recall = 0.27, F1-score = 0.28
 for conf_thresh = 0.25, TP = 2916, FP = 7206, FN = 7861, average IoU = 19.79 %

 IoU threshold = 50 %, used 101 Recall-points
 mean average precision<EMAIL_ADDRESS>= 0.210397, or 21.04 %
Total Detection Time: 3 Seconds

The resulting<EMAIL_ADDRESS>is 21.04 %. The result is similar whether or not I train from scratch or use the pretrained model. Am I mixing anything up here?

Hi @thgbe ,
Thanks for testing out the yolo training flow!
Initially, the evaluation is done directly in Darknet.
However, since the quantized TFLite model is being used for device implementation, the evaluation should be done at python level instead of Darknet (C++) level.
I have updated the training flow to use the developed python evaluation script.
The numbers in the README has been updated properly with the evaluation accuracy results.
I will be closing this issue. Thanks !


[v2] Point the link for Ruby on Rails to the official rails/webpacker repo

The repo https://github.com/typescript-ruby/typescript-rails doesn't seem to be very active these days, and Rail's official JS integration has evolved in the mean time. I think it's time to switch to Rails official TS guide.

thanks!


JS: introduce PropRef#mayHavePropertyName

The same pattern of name = read.getPropertyName() or read.getPropertyNameExpr().flow().mayHaveStringValue(name) occurred a few times in our codebase.
This PR introduces a new mayHavePropertyName predicate that describes that pattern.
I did a small smoke-test evaluation trying what would happen if I replaced all getPropertyName with mayHavePropertyName, and it didn't really change anything. But such a change feels wrong to me.

occurred a few times in our codebase.

Only three times? I would have expected double digits here.
Perhaps we should just shelve this then until we have decided on a strategy for https://github.com/github/codeql-javascript-team/issues/101 which requires a similar discussion.

I'm no longer trying to resolve https://github.com/github/codeql-javascript-team/issues/101 so we should try to resolve this PR as it stand. Personally I think it's fine to land it.


Add Checkbox

Please look over this and refactor me ta

Coverage increased (+0.004%) to 99.644% when pulling a9acaff02a50dd5f4b9d5cae9116d7900df07789 on checkboxes into e2a5fbf2ff876662cd60c45a82f9ba9ad9730aa0 on master.

Have refactored the checkboxes and added tests for the additional elements - 1 test currently broken so we can over this tmw if you like?

Coverage increased (+0.01%) to 99.677% when pulling 09b0832ee558881bdcb486710fabcb96d96a1b41 on checkboxes into e409cc21301a220f2c51443c039213385e5e3d35 on master.

Coverage increased (+0.01%) to 99.683% when pulling b65eba45ed0111da087361d17dc83283a8bd7abd on checkboxes into e409cc21301a220f2c51443c039213385e5e3d35 on master.

Coverage decreased (-0.3%) to 99.403% when pulling c065999369b56e1e16e37f6d28422ab96a36a530 on checkboxes into 51f49274cfa2194071afcd608d918135cc499596 on master.

Have refactored the tests and have added to demo so please review. Screenshot here:

Coverage increased (+0.01%) to 99.701% when pulling 4fa66a0a1dc9c64a672712ddb445176b974e4237 on checkboxes into 51f49274cfa2194071afcd608d918135cc499596 on master.


Fix test 5.14 to not always pass when multiple ports are published.

Signed-off-by: Zvi "Viz" Effron<EMAIL_ADDRESS>

Looks good. Thank you for the contribution.


Dart Sass

If you use Dart Sass, do you select this library?
I was using postCss, but it does not seem to support Dart Sass.
Thank you for your answer.

Hi @shunki-github ,
You can pass the sass runtime implementation via the runtime option param:
// rollup.config.js
import rollupPluginSass from 'rollup-plugin-sass';
import sass from 'node-sass';

export default {
  input: 'index.js',
  output: {
    file: 'bundle.js',
    format: 'cjs',
  },
  plugins: [
    rollupPluginSass({
      runtime: sass
    })
  ]
});

Thank you!

Not a problem 👍🏽 .


Allow language to be marked as readonly

It would be useful if, rather than removing a language altogether (using the FilterLanguages event), we could mark a language as readonly so that the value can be seen but not updated.

Just adding a comment to this really. This is not as simple as it first appears. The fix in your repo is fine for anything that is an input field, but people put many types of property editors inside vorto including things like the grid which is pretty dificult to make read only. My concern would be we implement this and people could modify something even if it's flagged to be readonly.


fix(backup): treat blank values like nil

See: https://docs.ansible.com/ansible/latest/user_guide/playbooks_filters.html#defaulting-undefined-variables

Good catch! And shouldn't the same also be applied to the defaults of the installation role?


feature: basic tx manager starting point

intention is to resolve nonce issues and gas issues by breaking out tx lifecycle management into its own task
TODO directions:

reload from DB and check that all nonces have txns and receipts
handle pending escalator errors
more todos are todo

closing pending more precise specification


Add AirPlay player state Boolean

Pull request
Description
This PR display an overlay when the player enter in AirPlay mode.
Changes made

A boolean has been added to know whether AirPlay is active or not.
An overlay has been added over the player when AirPlay is active.
The seek bar digits have now a fixed size (#169).

Checklist

[X] Your branch has been rebased onto the main branch.
[X] APIs have been properly documented (if relevant).
[X] The documentation has been updated (if relevant).
~New unit tests have been written (if relevant).~
[X] The demo has been updated (if relevant).
~The playground has been updated (if relevant).~

🌙 Available in TestFlight nightlies
The most recent state can be tested in the following builds:

Platform
Version

iOS
-

tvOS
1.0.0 (186)


Image_to_pencilsketches

check your code for linting

someone already working on this script. This issue is created and in progress.
please go through README for contributions guidelines.

first, you have to create issue and assigned


Gruvbox light mode?

Is there support for light mode?

Hi @roachsinai
There is no light mode, only dark medium in this repo.

Thanks for your reply!


Allow bytestring-0.11

Tested using
packages: .

constraints:
  bytestring >= 0.11

source-repository-package
  type: git
  location: https://github.com/haskell/text
  tag: v<IP_ADDRESS>-rc1

@Bodigrim: Thank you!  I just pushed a matching revision to Hackage

@Bodigrim: Thank you!  I just pushed a matching revision to Hackage


/photos endpoint returns 5000 results

I'm not sure if this is intentional but it took me by surprise. Under Resources on http://jsonplaceholder.typicode.com/ there is a mention of the /photos endpoint containing 200 items, but when I hit said endpoint it returns 5000.
$.ajax('http://jsonplaceholder.typicode.com/photos/', {
  method: 'GET'
}).then(function(data) {
  console.log(data.length);
});
// 5000

My laptop fans kicked into overdrive. :smile:

Not intentional :)
Thanks for letting me know, it should be good now.


Configure renovate

Pull Request Test Coverage Report for Build 147

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 88.101%

Totals

Change from base Build 131:
0.0%

Covered Lines:
348

Relevant Lines:
395

💛  - Coveralls


html5lib version 0.999999999 (latest) does not work with djangocms-text-ckeditor

If I install the latest version of html5lib, I get the following import error when I try to migrate.  I'm using djangocms-text-ckeditor==3.0.1 and djangocms==3.3.1.
When I downgrade to html5lib==0.9999999, it works.
(myproject)$ ./manage.py migrate
Traceback (most recent call last):
  File "./manage.py", line 10, in <module>
    execute_from_command_line(sys.argv)
  File "Sites/myproject/envs/myproject/lib/python2.7/site-packages/django/core/management/__init__.py", line 353, in execute_from_command_line
    utility.execute()
  File "Sites/myproject/envs/myproject/lib/python2.7/site-packages/django/core/management/__init__.py", line 327, in execute
    django.setup()
  File "Sites/myproject/envs/myproject/lib/python2.7/site-packages/django/__init__.py", line 18, in setup
    apps.populate(settings.INSTALLED_APPS)
  File "Sites/myproject/envs/myproject/lib/python2.7/site-packages/django/apps/registry.py", line 108, in populate
    app_config.import_models(all_models)
  File "Sites/myproject/envs/myproject/lib/python2.7/site-packages/django/apps/config.py", line 202, in import_models
    self.models_module = import_module(models_module_name)
  File "/usr/local/Cellar/python/2.7.9/Frameworks/Python.framework/Versions/2.7/lib/python2.7/importlib/__init__.py", line 37, in import_module
    __import__(name)
  File "/Sites/myproject/proj/myproject/myproject/apps/pagefeature/models.py", line 8, in <module>
    from djangocms_text_ckeditor.fields import HTMLField
  File "/Sites/myproject/envs/myproject/lib/python2.7/site-packages/djangocms_text_ckeditor/fields.py", line 9, in <module>
    from .html import clean_html
  File "/Sites/myproject/envs/myproject/lib/python2.7/site-packages/djangocms_text_ckeditor/html.py", line 8, in <module>
    from html5lib import sanitizer, serializer, treebuilders, treewalkers
ImportError: cannot import name sanitizer

I think this might be related to the following:
https://github.com/html5lib/html5lib-python/issues/72
https://github.com/html5lib/html5lib-python/issues/277

Closing as a duplicate of https://github.com/divio/djangocms-text-ckeditor/issues/336
djangocms-text-ckeditor currently pins html5lib to be less than 0.999999999


Cron job error

Hello,
I face an issue when I try to set up the cron job. The errors are regarding the api_token and host_fqdn config options. These options are not empty in each configuration file I have created.
2024-03-04 20:41:26,406 - INFO: Starting NetBox Sync v1.5.1 (2023-09-25)
2024-03-04 20:41:26,406 - ERROR: Config option 'api_token' in 'netbox' can't be empty/undefined
2024-03-04 20:41:26,406 - ERROR: Config option 'host_fqdn' in 'netbox' can't be empty/undefined
2024-03-04 20:41:26,406 - ERROR: Config validation failed. Exit!
Everything work as expected when I manually trigger the configuration files through the virtual environment:
(.venv) [XXXX@netbox netbox-sync]# /opt/netbox-sync/netbox-sync.py -c settings-XXXX-XXXX.ini

Hi,
Do you also use your virtual environment in your ceon job?

Can you try to define the log file as a command option -c? Or set the log level to DEBUG2?

Hello,
Thanks again for your awesome netbox-sync plugin. I manage to overcome the Erros by executing the following bash script in the cronjob.
#!/bin/bash
cd /opt/netbox-sync/
. .venv/bin/activate
/opt/netbox-sync/netbox-sync.py -c settings-XXXX.ini > /tmp/cron-debug-XXXX.log
exit 0

Great that you foond a solution and that it helps you in your infrastructure needs.


Update kernel.js

This looks better in my opinion.

The reason i kept them in variables is , if in case you want to add some middleware conditionally. Like if in production run these and in development run something else.
You can easily push or remove items from array and pass the final one to Middleware method

I suppose, looks cleaner imo that's all.

Sorry have to pull it down for the sake of flexibility


Add backup and restore strategy of failed cluster in doc site

In certain unfortunate circumstances, an EKS Anywhere cluster may find itself in an unrecoverable state due to various factors such as a failed cluster upgrade, underlying infrastructure problems, or network issues, rendering the cluster inaccessible through conventional means. We need documents that outline detailed steps to guide user through the process of restoring a failed cluster from backups in these critical situations.

Hello Joey, we do see this issue created a month back, seems we are also stuck in a similar situation , where we wish to take a backup of a bottlerocket nodes and restore it say in case when the nodes are not reachable nor the cluster.  Is there any update on the documentation for the same !

Hello Joey, we do see this issue created a month back, seems we are also stuck in a similar situation , where we wish to take a backup of a bottlerocket nodes and restore it say in case when the nodes are not reachable nor the cluster. Is there any update on the documentation for the same !

Hello the doc site is updated with instruction. Please take a look and give it a try: https://anywhere.eks.amazonaws.com/docs/clustermgmt/cluster-backup-restore/


Bump to 0.2.41

Hm ok the web-sys test failure is worrisome but shouldn't block the release, so merging!

er other way around


Is there a way to stop MR from running with each click on a + in MSC Updates

When MSC finds new apps to update, it displays them with a + in the Updates window. Clicking the + causes a full MR run. Is there anyway to avoid that? Is this really a munki issue?

MunkiReport does not (or at least should not) run through all of its pre/postflight scripts. It only runs the ones that directly pertain to Munki itself. Having it not run those scripts will cause the inventory and install/remove history to be out of date in MunkiReport.


Create SignupView

Create SignupView according to the blueprint and the CA Lab code.

check this: https://github.com/CSC207-2024F-UofT/NoteApplication


Error in 'Applied Accessibility: Give Links Meaning by Using Descriptive Link Text'

Describe your problem and - if possible - how to reproduce it
 doesn't work. it says

code.match(...) is null

but  works without a problem
Add a Link to the page with the problem
https://learn.freecodecamp.org/responsive-web-design/applied-accessibility/give-links-meaning-by-using-descriptive-link-text
Tell us about your browser and operating system

Browser Name: Firefox
Browser Version: 62
Operating System: Windows 10

I have the same problem, my code:
Click here for information about batteries
doesn't work? help pls?

@bayronguti22hope, sorry that you're having a problem.
The description says to move the  tags form around "Click here" to "information about batteries." So here's the passing code:
Click here for information about batteries


Identify different instances of same device

I am using several USB audio interfaces through a USB hub, but every time I turn on or re-plug it, it seems like the device Ids and their order changes. Is it possible to map the device to its physical location using sounddevice?
For example, I have this:
>>> sd.query_devices()
   0 USB PnP Sound Device: Audio (hw:0,0), ALSA (1 in, 2 out)
   1 USB PnP Sound Device: Audio (hw:1,0), ALSA (1 in, 2 out)
   2 bcm2835 ALSA: IEC958/HDMI (hw:2,1), ALSA (0 in, 8 out)
   3 bcm2835 ALSA: IEC958/HDMI1 (hw:2,2), ALSA (0 in, 8 out)
   4 USB PnP Sound Device: Audio (hw:3,0), ALSA (1 in, 2 out)
   5 USB PnP Sound Device: Audio (hw:4,0), ALSA (1 in, 2 out)
   6 sysdefault, ALSA (128 in, 128 out)
   7 front, ALSA (0 in, 2 out)
   8 surround40, ALSA (0 in, 2 out)
   9 iec958, ALSA (0 in, 2 out)
  10 spdif, ALSA (1 in, 2 out)
* 11 default, ALSA (128 in, 128 out)
  12 dmix, ALSA (0 in, 2 out)

and from the terminal I can find the physical connection for each USB dongle:
$ lsusb -t
/:  Bus 01.Port 1: Dev 1, Class=root_hub, Driver=dwc_otg/1p, 480M
    |__ Port 1: Dev 2, If 0, Class=Hub, Driver=hub/5p, 480M
        |__ Port 1: Dev 3, If 0, Class=Vendor Specific Class, Driver=smsc95xx, 480M
        |__ Port 2: Dev 9, If 0, Class=Hub, Driver=hub/4p, 480M
            |__ Port 3: Dev 12, If 2, Class=Audio, Driver=snd-usb-audio, 12M
            |__ Port 3: Dev 12, If 0, Class=Audio, Driver=snd-usb-audio, 12M
            |__ Port 3: Dev 12, If 3, Class=Human Interface Device, Driver=usbhid, 12M
            |__ Port 3: Dev 12, If 1, Class=Audio, Driver=snd-usb-audio, 12M
            |__ Port 1: Dev 10, If 3, Class=Human Interface Device, Driver=usbhid, 12M
            |__ Port 1: Dev 10, If 1, Class=Audio, Driver=snd-usb-audio, 12M
            |__ Port 1: Dev 10, If 2, Class=Audio, Driver=snd-usb-audio, 12M
            |__ Port 1: Dev 10, If 0, Class=Audio, Driver=snd-usb-audio, 12M
            |__ Port 4: Dev 13, If 1, Class=Audio, Driver=snd-usb-audio, 12M
            |__ Port 4: Dev 13, If 2, Class=Audio, Driver=snd-usb-audio, 12M
            |__ Port 4: Dev 13, If 0, Class=Audio, Driver=snd-usb-audio, 12M
            |__ Port 4: Dev 13, If 3, Class=Human Interface Device, Driver=usbhid, 12M
            |__ Port 2: Dev 11, If 2, Class=Audio, Driver=snd-usb-audio, 12M
            |__ Port 2: Dev 11, If 0, Class=Audio, Driver=snd-usb-audio, 12M
            |__ Port 2: Dev 11, If 3, Class=Human Interface Device, Driver=usbhid, 12M
            |__ Port 2: Dev 11, If 1, Class=Audio, Driver=snd-usb-audio, 12M

There has been quite some discussion on the mailing list ... any new insights @gustavovelascoh?

@mgeier did you ever hear back or solve this?
feels like an essential feature-need to get the full usb descriptor meta incl. unit serial number, that way opening several handles by vid, pid, serial would be much more robust

did you ever hear back or solve this?

No.

feels like an essential feature-need to get the full usb descriptor meta incl. unit serial number, that way opening several handles by vid, pid, serial would be much more robust

Yes, it would be great, but you have to talk to the PortAudio project about this. Here is not the right place.


Change Anna's profile picture

Please provide a 300x300 pixel picture (probably zooming in a bit on your face).


Update tf job examples to tf v2

What this PR does / why we need it:
Update TFjob examples to TF v2
Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Fixes #2015
Checklist:

[ ] Docs included if any changes are user facing

Pull Request Test Coverage Report for Build<PHONE_NUMBER>6
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>0:
0.0%

Covered Lines:
66

Relevant Lines:
66

💛  - Coveralls

Hi @alongzhi, I saw you added ppc64le images before.
In order to support ppc64le I need base image of TF-v2 to replace this image - ibmcom/tensorflow-ppc64le:1.13.1 that used in: examples/tensorflow/dist-mnist/Dockerfile.ppc64le and examples/tensorflow/mnist_with_summaries/Dockerfile.ppc64le.
Can you pls support this image? otherwise just let me know and I'll remove this Dockerfile.ppc64le since the source code support only TF-v2 now..
@JosepSampe @ckadner Do you know who can support this image from IBM?
@andreyvelich - FYI

@alongzhi Are you planning to continue support powerPC images in Training Operator ?
Otherwise, we will remove them.
cc @kubeflow/wg-training-leads

/assign @kuizhiqing

@YosiElias Please can you rebase your PR to fix unit tests ?


Add arrow or something that shows to features collections and ability to scroll

Bubble background on main page

Make arrow


Outdated value for scipy.constants.au

My issue is about an outdated value for scipy.constants.au.
The value returned is<PHONE_NUMBER>91.0.  The correct value
is<PHONE_NUMBER>00.0.  See IAU 2012 Resolution B2 and
https://www.iau.org/public/themes/measuring/ .
Reproducing code example:
from scipy.constants import au
print(au)

Scipy/Numpy/Python version information:
 1.2.0rc2 1.15.4 sys.version_info(major=3, minor=7, micro=1, releaselevel='final', serial=0)

Thanks for the report @japagetw. Value updated in gh-9588

Ralf,
Thanks!
-- Jim Paget
From: Ralf Gommers<EMAIL_ADDRESS>Sent: Wednesday, December 12, 2018 05:52 PM
To: scipy/scipy<EMAIL_ADDRESS>Cc: James A Paget<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [scipy/scipy] Outdated value for scipy.constants.au (#9587)
Thanks for the report @japagetwhttps://github.com/japagetw. Value updated in gh-9588https://github.com/scipy/scipy/pull/9588
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/scipy/scipy/issues/9587#issuecomment-446812837, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AOT3O8iuvlrxvTlTAO3KGRvoI7K9oO2sks5u4bLGgaJpZM4ZQs3i.


v0.11.0-rc.1

What type of PR is this?
Add one of the following kinds:

enhancement/feature

What this PR does / why we need it:
Initial rc pre-release for Fall Meta Release, with alignment to Commonalities 0.4-rc.1, Identity and Consent Management-0.2.rc1, and Edge Cloud.
See #3  and/or CHANGLOG.md for full list of fixed issues.
Which issue(s) this PR fixes:
<!-- Automatically closes linked issue when PR is merged.

Fixes #3

#### Special notes for reviewers:

#### Changelog input

(captured in CHANGELOG.md)

#### Additional documentation

This section can be blank.

```
docs

```

Iinter errors are due to trailing spaces: local lint shows no errors so I'll check what the problem is...

@javierlozallu  I can't upload the whitespace fix because this is a protected branch, meaning I can't commit to it.
The report above shows only trailing whitespace errors for the YAML - so I can fix that when we move from 0.11.0-rc.1 to 0.11.0- rc . We are required too have the rc available by end of Friday, so if you are happy with the rest of this rc1 PR then please approve and I can upload rc with the whitespace fix for approval.

Thanks @javierlozallu , well spotted - I will create a PR for this PR(!) because it is a protected branch so I can not apply new commits.


Generated code is not following go standard for error strings

If you build the latest code, it generates hundreds of go-staticcheck warnings:
error strings should not be capitalized (ST1005)
error strings should not end with punctuation or newlines (ST1005)

Closed by https://github.com/onshape-public/openapi-utilities/pull/21


updated the image in the top of the hero section

resolves #282

Hey @dennyglee !
I compared two images that you provided, and this one

looks better than previous one.
Please check it, and let me know if everything is good!
Thanks!


Allow for injected of bindings

In the spec we have taken the more secured approach and only supported mounting of binding data.
However, there can be cases where the binding data is not necessarily sensitive data - it could simply be an URL of an in-cluster service, or a public external service.
Also - while there's consensus of environment variables not being as secured as persisted volumes, supporting this method will improve the modernization of existing applications.

For
servicebinding/secret/<binding_property>: {.status.<status_property>} (where <binding_property> is any property from the binding schema, and <status_property> refers to the path to the correspoding status property)

we can have something like   servicebinding/secret/as_env/<binding_property>: {.status.<status_property>}
or servicebinding/secret/as_volumemount/<binding_property>: {.status.<status_property>}

hey @Avni-Sharma - I was wondering if perhaps the decision of injecting "as env" versus "as volume" is something that the bindable service shouldn't be concern with, since that only affects the consumer and each consumer could be different?
I am thinking about if this is just an option on the ServiceBinding CR - so from the perspective of the bindable service its job is to make its bindable properties available, and the consumer decides (via the request CR) how to consume that.
What do you think?

Very interesting points.
We did try taking the approach as you had outlined initially but then we realized that backing services may always have a mix of environment variables and "files", and maybe the operator author knows best?
Example, certificates ideally will be "files", usernames could be environment variables.
So, such scenarios where we need both would be hard to express in a Service Binding.
So how about having the spec do the following:

Ask operator authors to specify volume or env ( as we have now )
Support a blanket override field in Service Binding CRD which says "I don't care what the operator author recommends I want everything to be a volumeMount or everything to be an envVar" kinda thing.

that's a good point - basically, if the bindable Operator makes that suggestion (env / volume) then it saves the extra work from every consumer to make the decision.   I like that.  👍
Other related questions:

what is the key called inside ServiceBinding CR that toggles envVar vs volumeMount?
what should the default for that key be?

Following the SBO convention, we could update the spec saying that bindable services MAY add the prefifx env or mount to their x-descriptors or annotations.
@Avni-Sharma @sbose78 - thoughts?

after thinking more about it, we may have some obstacles in allowing the bindable resource pick which items are env versus which are mounted.   In the case where someone creates a ServiceBinding CR but turns off application injecting (so just lets SBO create the Secret), how would they know which items of the Secret were intended to be injected as env var versus mounted?

but turns off application injecting (so just lets SBO create the Secret)

If SBO is being asked to skip injecting, then that information is effectively lost 🤔
However, we can 'copy' over the information into the secret's annotations and leave it for consumers to interpret ?

I think that's a good approach.   @navidsh - that would mean our Runtime Component could check if there are any annotations in the Secret, and process those.

Shall we then look at supporting the same annotation format in the sbr cr as annotations as well? so the resolution would be that the sbr cr annotations > (crd annotations/x descriptor ) or can we have it in customEnVar / dataMapping so we can have something like
dataMapping:
   - Name: CUSTOM_NAME
     Value: go template/json-path
     InjectAs: Env/VolumeMount

wherein the user is telling that I want the variables as env var or a volume mount. So what the backing service's annotations provide us with, is something that should be ideally followed. Anything else (customizable or the user's wish) can then go to customEnvVar / dataMapping

Good idea, the override staircase could then be:

read guidance from operator author
read global SBR configuration
read customEnvVar BindAs/InjectAs ?

Good idea, the override staircase could then be:

read guidance from operator author
read global SBR configuration
read customEnvVar BindAs/InjectAs ?

yup

sounds good to me!


Reduce significant figures in X, Y, Z outputs

The precision isn't real, so we should eliminate it. I think it will also look and feel like it's less noisy as the user won't see the numbers changing as much, even though the apparent precision is lower.
This could be set as a function of distance from the camera that follows the rise in stereo error at increased Z, or it could be set to a fixed value, like 10cm. Here's an example of RMS error increasing with distance from some Intel Real Sense devices.
Suggestion:

<2m use cm precision
2m to 5m use dm precision
>5m use half-meter precision

This is partially addressed in https://github.com/luxonis/depthai/pull/95

It's just fixed decimal for now... but closing the issue.  For other applications where more precision is required, it's simple enough to just change the print statement https://github.com/luxonis/depthai/blob/0611eb701fffbcd743644e4f0d2c7b92e60b7cd9/depthai.py#L198 (I think).


Update textadept to 9.4

After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} left no offenses.
[x] The commit message includes the cask’s name and version.

Thank you for the contribution. It was merged directly as 7ce626599c6a0d12325766ec1f476abaa6021eb1. Your contribution is still credited to you.


'keyError: non-existent config key: TEXTFUSENET_MUTIL_PATH_FUSE_ON'

@ying09 I am using TextFuseNet to detect the scent text in an image. When I had  detectron2 installed (MacPro + M1 chip) and tried to run the demo, it shows the error as
'keyError: non-existent config key: TEXTFUSENET_MUTIL_PATH_FUSE_ON'
I searched this issue around and it seems I am the first one in the TextFuseNet. Any suggestions?
A similar issue was found but I don't have an idea.
Thanks.

In all the scripts inside the demo folder, just insert a line (cfg.set_new_allowed(True)) into the function setup_cfg. It will look something like:
def setup_cfg(args):
    # load config from file and command-line arguments
    cfg = get_cfg()
    cfg.set_new_allowed(True)
    cfg.merge_from_file(args.config_file)
    cfg.merge_from_list(args.opts)
    # Set model
    cfg.MODEL.WEIGHTS = args.weights
    # Set score_threshold for builtin models
    cfg.MODEL.RETINANET.SCORE_THRESH_TEST = args.confidence_threshold
    cfg.MODEL.ROI_HEADS.SCORE_THRESH_TEST = args.confidence_threshold
    cfg.MODEL.PANOPTIC_FPN.COMBINE.INSTANCES_CONFIDENCE_THRESH = args.confidence_threshold
    cfg.freeze()
    return cfg


WARNING:langchain_google_genai.chat_models:Retrying langchain_google_genai.chat_models._chat_with_retry.._chat_with_retry in 32.0 seconds as it raised ResourceExhausted: 429 Resource has been exhausted (e.g. check quota)..

I know this is not really a bug, but rather i have reach quota limit. My question is why there's only me who has this error? I have try to find the problem online using Google but did not find same problem.
I am sorry, i have asked many questions for you.

try to increase the rate limit on the gemini platform


Use OpenAI embeddings for similarity

Use https://beta.openai.com/docs/guides/embeddings/use-cases to calculate similarity.
If an openai_secret_key is provided in config.SECRET.json then it activates embedding-based similarity.
A new cloud function is set up that when a card's title or body is modified it's flagged to have its embedding fetched. (The fetching has to happen serverside to protect the secret key).   Getting an embedding for a live-editing card is harder then.
Fetchign embeddings could take awhile and could fail, and sometimes we'd need to do many in bulk, so we'll need some kind of implciit queing system, and flagging cards that have an embedding fetch happening, or need a new one
The functions to compute two similarities between cards instead uses the embeddings. (Maybe have a different type of fingerprint, an EmbeddingFingerprint?)

See also https://github.com/dglazkov/wanderer

And https://github.com/openai/openai-cookbook/blob/838f000935d9df03e75e181cbcea2e306850794b/examples/Question_answering_using_embeddings.ipynb

https://extensions.dev/extensions/googlecloud/firestore-semantic-search

The content that is sent to the embedder should also include the canonical forms of any concept links, to help create semantic connection across multiple synonyms

A few challenges: the set of embeddings in production will likely be extremely large, and push the renderer closer to an OOM.  There will also be many cases where you don't have the embeddings but still want to do something meaningful.
Have a new set of query filters, meaning, which if embeddings are available, uses a sorting based on cosine similiarty, and if they aren't, falls back to just an alias for similarity.
One design: have the embeddings in a cloud function. Use hnsw to do the index. Store the index in Cloud Storage, and every time you save a new snapshot, remove ones that are above some count (so keep a few just in case). Every time the cloud function loads (will cloud functions v2 help the instance be reused more often?) it loads the snapshot of the most recent version.
hnsw doesn't allow saving metadata so we'll have to do it some other way, including maintaining a mapping from cardID -> hnsw index. That will be stored in a new embeddings firestore collection, which will be keyed off of cardID + embedding_space (allowing adding new ones in the future), like c-123-4567+embedding-ada-002. Each record will have the embedding_index, the last_updated date, and a snapshot of the embedded text.  Every time a card is saved and its content changes, we check if there is an embedding record, and if there is one if the text is equivalent. If any of these aren't true, then we kick off an embedding request and then store the result in the hsnw index, saving a snapshot, and updating the embedding record.
There is also an endpoint, which anyone can hit (because it never sends back card content) that you can pass a key card ID and a k, and it will pass back an array of [CARD_ID, similarity] records of the most similar items. (You can pass -1 to mean 'literally every card'). When you hit the endpoint, the endpoint loads up the hnsw index, looks up the embedding_index of the given card ID, fetches the embedding of that item, fetches the k most similar, and then reverses out the card_id of each one before passing back. You can also pass to the endpoint not a cardID but a card content. In the future we can filter out any cards the given user doesn't have access to (to not leak the existence of other cards, and to ensure the recrods that are passed back aren't, for example, entirely unpublished cards they can't see).
The local filter for meaning will keep track of cached similarity lists of key careds (invalidating the list each time it's fetched). The filter will have a bit of a delay to actually give a result, as it fetches to the endpoint.
The content to be embedded is a function that takes a card and a collection of concept cards and produces a canonical text, which includes the canonical form of every concept card's title appended at the end.

Just use Qdrant? (open source pinecone alternative)

[ ] Enable Object Versioning on new buckets when being created


Audit and make documentation for command LPOP consistent

The documentation of the command [LPOP](https://dicedb.io/commands/lpop/) present in the docs could have become stale. We need your help to ensure that the documentation is complete, correct, and consistent.  Completing this issue will give you much-needed exposure to how the command is implemented and the different parameters it accepts. Hence, this is a great way to build a good understanding of the project and its functionality. While still making a significant contribution. Here's what you need to do:

Go through the documentation of the command and run all the examples, making sure they all work as expected
If the same command is present in Redis, then the expected output of the DiceDB command is the same as the Redis output
If the command is not in Redis, then as per your judgment, raise an issue with this template or fix the documentation and raise a pull request.
The documentation should contain the following sections in the following order

short and concise introduction paragraph about the command covering what it does
Syntax
Parameters: List all the parameters the command accepts, and ignore the section if there are no parameters
Return values: List all possible return values and under what condition
Behaviour: Describe the behavior of the command, what it does, how it does it, some internal specifics if any
Errors: List all possible errors the command can throw and under what condition
Examples: List all possible examples of the command and the expected output. Assume CLI implementation

Note: The title of the sections should be the exact strings mentioned above, like "Examples", "Return values", etc.
Note: The description of the command in Frontmatter of the command.md file is the first paragraph (introduction) of the command.
Go through the DiceDB/dice repository and explore the command implementation

to understand all possible return values
to understand all possible error values and conditions
to understand different parameters the command accepts

Please use the documentation of the SET command as the reference point and structure the
documentation of this command in a very similar way, including the following points

if you see any "Conclusion" section, remove it
the headers (h1, h2, h3) should be appropriately used
the CLI prompt should be <IP_ADDRESS>:7379> and not anything else
Use markdown tables for parameters and return values (ref SET command documentation)
wrap any command or paramter in backticks (`) to highlight them
the section header should be capitalize as used in the SET command documentation

If you find any inconsistencies, please fix the documentation and raise the PR.
The core idea of this exercise is to ensure that the documentation is consistent, correct, and complete.
Make sure you comment on the other issues you created (if any) as a comment on this issue and also any PR (if any) that you created.
Thank you for picking this up and contributing to the DiceDB. It means a ton.

Hi @arpitbbhayani , I would love to work on this issue. If you could please assign me this task I would highly appreciate it.

@Kripu77 assigned, thanks for contributing.

@Kripu77 assigned, thanks for contributing.

Thanks @lucifercr07

Hello @Kripu77,
There has been no activity on this issue for the past 5 days.
It would be awesome if you keep posting updates to this issue so that we know you are actively working on it.
We are really eager to close this issue at the earliest, hence if we continue to see the inactivity, we will have to reassign the issue to someone else. We are doing this to ensure that the project maintains its momentum and others are not blocked on this work.
Just drop a comment with the current status of the work or share any issues you are facing. We can always chip in to help you out.
Thanks again.

Hi @arpitbbhayani
Apologies for the delay, I've some updates which I have made on my end. I'll raise the PR ASAP.
Thanks
Kripu


fix: do not use intersection for search params

I wonder if the same should be applied for path params?


Deploy S3 frontend

Deploy the frontend S3 version to Google App Engine.

Story Points: 21
See the discussion in Frontend S3
Powered by Parabol


Login using google in OpenOCRCorrect

Users should be able to login using google in offline tool and authenticate them whether they have rights to access or not using email id only. => Hence eliminating the need of GitHub username and key for end users.

Completed. Refer c91fab07b823c1fb84e7dbfdb3bb8bedd0e9b638 & 87b05cfdcdd95d84647f46712a92af2f3d3d7676


[WIP] ENH: add ability to spawn MPI jobs from parent job

The goal here is to allow MPIBackend to spawn child jobs from an existing MPI job/communicator. A user could then run any simulation script (e.g., plot_simulate_mpi_backend.py) from a computing cluster with the following command and it will spawn as many sub-processes as are specified by MPIBackend(n_procs=...) to complete the simulation job:
$ mpiexec -np 1 --oversubscribe python -m mpi4py /path/to/script.py

I'm currently interested in this use-case for two reasons:

It will allow a user to implement some more complex yet faster MPI configurations on a computing cluster where one can e.g. parallelize across both simulations and neurons, where currently only either scenario or the other is possible.
It solves (I think) some the security concerns with allowing a process to instantiate its own MPI parent job, which is what MPIBackend currently does.

closes #477

For the time being, I've created a new file called mpi_comm_spawn_child.py that more-or-less mirrors the style of mpi_child.py. Eventually, these files should be combined into one. It also currently runs, so give it a try!

Codecov Report

Merging #506 (c616558) into master (c7460ba) will decrease coverage by 0.87%.
The diff coverage is 34.78%.

@@            Coverage Diff             @@
##           master     #506      +/-   ##
==========================================
- Coverage   87.63%   86.75%   -0.88%
==========================================
  Files          19       20       +1
  Lines        3792     3843      +51
==========================================
+ Hits         3323     3334      +11
- Misses        469      509      +40

Impacted Files
Coverage Δ

hnn_core/mpi_child.py
96.47% <ø> (ø)

hnn_core/mpi_comm_spawn_child.py
0.00% <0.00%> (ø)

hnn_core/parallel_backends.py
79.68% <60.00%> (-1.81%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7460ba...c616558. Read the comment docs.

I'm interested! You need to educate me a little over a video call what was the motivation, what are the pros/cons of spawning jobs through MPI vs Python etc

Let's setup a time to chat more about this!

I'd definitely like to be apart of the meeting as well. I'm wondering if this is also the reason why MPI doesn't work in WSL?

@rythorpe I added the comment that it closes #477

FYI, I think the reason MPIBackend is setup the way it is currently (i.e., prior to this PR) is specifically to provide timeouts + tracebacks when errors occur prior to a blocking MPI call. (See https://github.com/mpi4py/mpi4py/issues/53 for a discussion on this topic.) An MPIBackend subprocess created via subprocess.Popen enforces a timeout when waiting for communications to/from child MPI processes and terminates them when a timeout monitored by the parent process is exceeded, capturing stderr and stdout on the way out.
Correspondingly, unit tests that explicitly test the guts of MPIBackend should use the original codepath (i.e., calling mpiexec internally when mpi_comm_spawn=False) so that tracebacks can be preserved and logged. Tests for the new functionality introduced here will also be written, however they should not replace the previous tests.

seems like this might be a way to go: https://mpi4py.readthedocs.io/en/stable/mpi4py.run.html
using a -m flag? Try to avoid peppering the codebase with try/except blocks ... it's really anti-pattern. But if that's the only way to get MPI to work gracefully, you can put in one function ...

seems like this might be a way to go: https://mpi4py.readthedocs.io/en/stable/mpi4py.run.html
using an -m flag? Try to avoid peppering the codebase with try/except blocks ... it's really anti-pattern. But if that's the only way to get MPI to work gracefully, you can put in one function ...

Yes, this is what I've been doing when calling mpiexec, however, I haven't really explored using try/except statements. In order to get this to be a robust and dependable solution for handling errors, we'd have to put try/except statements prior to every blocking MPI call in the codebase. This might work though since there aren't many MPI calls... I'll need to look into this more.

Minor update, I finally got this branch to run off of a master MPI process on Oscar (Brown's HPC). See here for a demo.


Request package: HandBrake 1.3.2

Package name
HandBrake
Homepage
https://handbrake.fr/
https://github.com/HandBrake/HandBrake
Description
HandBrake is a tool for converting video from nearly any format to a selection of modern, widely supported codecs. OpenSource.

Handbrake is already provided by the Debian's official repo.


Task failed with error 'could not find bucket'

Hi,
All the Tasks in our account failed in between 7:00-7:30 AM IST and with the error 'could not find bucket' for different buckets and its working fine after 7:30. Could you please let us know whats the reason for this and whether it can happen in future.
Steps to reproduce:
Intermittent
Expected behavior:
All the Tasks in our account failed
Actual behavior:
Task Should complete successfully
Environment info: Both Production and Staging

InfluxDB version: Cloud 2.0

Logs:
Task failed with the error: Task encountered unrecoverable error, requires admin action: Error exhausting result iterator; Err: failed to initialize execute state: could not find bucket "_tasks": failed to initialize execute state: could not find bucket "_tasks"

Hey @Bharathebt  did you find solution of this error


General restyling - Removed deprecated statements and updated dependencies

Hello, I hope you'll accept this pull request, since this library is really important for Rust FTP support. Really, there's nothing decent out there for FTP in Rust.
These changes solve deprecation warnings and updates all the crates to the latest version. In addition I replaced openssl with native_tls to make it easier to run on Windows and MacOs machine.
Changes

Replaced OpenSSL with Native-tls
Upgraded dependencies:

lazy_static 1.4.0
regex 1.4.2
chrono 0.4.19

Fixed deprecated statements
Added get_welcome_msg method
Solved these issues:

#91
#84

I tested the commit and everything is fine.
EDIT (2020-12-02)
I also merged what you already did on branch stable-updates, which sounded good to me.
EDIT (2020-12-03)
I reported the patches from async-rust-ftp (which is a library derived from this one).
Eventually I replaced openssl with native_tls, which makes it easy to run on MacOS and Windows.

For those who read this merge request and are looking for a way to apply these changes before the new published version, just add this to  Cargo.toml
# ...
[dependencies]
# ...
ftp = { git = "https://github.com/ChristianVisintin/rust-ftp" , features = ["secure"] }
# ...

@ChristianVisintin Thanks for making these updates. I plan on actively maintaining the project from here on out. Seeing as your an active user of this library any feedback on it would be nice.


[eval] add nightly swe bench evaluation workflow

End-user friendly description of the problem this fixes or functionality that this introduces

[ ] Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below

Give a summary of what the PR does, explaining any non-trivial design decisions

Link of any specific issues this addresses

Switch to https://github.com/All-Hands-AI/OpenHands/pull/4489, since fork cannot access correct github secret.


Add missing code in InternalEngine part of #10513

Description
This PR adds the code missed from the backport of the PR #10513.
Related Issues
Resolves #10585 & #10513

Check List

[ ] ~New functionality includes testing.~

[x] All tests pass

[ ] ~New functionality has been documented.~

[ ] ~New functionality has javadoc added~

[x] Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
[x] Commits are signed per the DCO using --signoff
[ ] ~Commit changes are listed out in CHANGELOG.md file (See: Changelog)~
[ ] ~Public documentation issue/PR created~

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

:grey_exclamation: Gradle check result for d09a435e9b63b21187e42be77f27d19d80089801: UNSTABLE

TEST FAILURES:

      1 org.opensearch.index.shard.RemoteStoreRefreshListenerTests.testRefreshAfterCommit
      1 org.opensearch.index.shard.RemoteStoreRefreshListenerTests.testAfterRefresh
      1 org.opensearch.index.shard.RemoteStoreRefreshListenerTests.testAfterMultipleCommits
      1 org.opensearch.index.shard.RemoteStoreRefreshListenerTests.testAfterCommit
      1 org.opensearch.index.shard.RemoteIndexShardTests.testNoFailuresOnFileReads

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.


Allow specifying custom profiles

Allow for users to specify a specific profile. I have a ci-specific profile, so it would be useful to be able to set a different profile in the action config.

Thanks for the PR!
The --profile option affect the directory from which the built binaries are output, so you have to adjust /release below.
https://github.com/taiki-e/upload-rust-binary-action/blob/609508cff1a3f2297c188c806101d75e7196b17e/main.sh#L244
https://github.com/taiki-e/upload-rust-binary-action/blob/609508cff1a3f2297c188c806101d75e7196b17e/main.sh#L251-L252
https://github.com/taiki-e/upload-rust-binary-action/blob/609508cff1a3f2297c188c806101d75e7196b17e/main.sh#L263
See this code in cargo-llvm-cov for the directory name used.

Good catch, thanks

Published in 1.14.0.


Fix infinite loop from sentinel pool when failover occurred (for 2.7)

Fixes #1093

After failover, any borrowed instances connected to old master could be returned to pool
Thread calling JedisSentinelPool.getResource() will run into infinite loop because old instances borrowed and returned repeatedly
Fix JedisSentinelPool.getResource() to return instance as broken when instance is not connected to current master

I'll cherry-pick this to 2.8 when it is labeled as READY TO MERGE.

@HeartSaVioR amazing. We probably forgot to downmerge :)

Merged to 2.7 and 2.8 respectively.


When trying to login to self-hosted gitlab, it just shows yellow box with [object Object]

Hello,
Few hours ago I started using Netlify CMS on our sites, implicitly connected to our self-hosted gitlab and it worked correctly. Recently I made pull and rebase and now it dont want to let me log in. All configurations are still the same as few hours ago. But now, when I click to 'Login with GitLab' it just show a yellow box with text '[object Object]' and nothing more. I tried to rebuild the sites a few times, also tried to make a new 'Application' on my gitlab account and connect the CMS to it, but still returns the [object Object] error and no login. Any hint please?
After checking networks tab in dev tools, it shows {error: "404 Not Found"} as one of the response so this will be probably the [object Object] what is in the yellow box. But still... Why it worked few hours ago. I also tried to connect the CMS to other repos which we have, but still the same.

Did you update Netlify CMS between when it worked and when it didn't? What version are you using?


SEVERE bug in Dashy - looping reinstall after adding basic auth to conf.yml

Environment
Self-Hosted (Docker)
System
Mint 21.3
Version
3.1.1
Describe the problem
I put the finishing touches on Dashy while I was at work today. Had everything right where I wanted it including customizing the colors on Material Dark theme. A couple hours and I went back to it, expecting to be logged out. At that point, I realized there was no login. So I went to the docs and realized this is not a default feature in Dashy. So I added basic auth as per the instructions in the docs. Logged in and logged out a couple times - great!
I came back to it an hour or so later and I couldn’t get to it. I mean it was just down. So I came home and accessed it locally. I got a screen saying Dashy was ”Initializing”…

And when it finished, I got all my groups - but they were empty; no items. When I logged in, one of my groups (the one I setup a couple days ago) had items in it but none of the groups I’ve created/populated since then.
So I restarted the container, hoping for the best. When it came up, I got the “ Initializing”. When it finished and I logged in, same result - all my groups empty except for the one I setup a couple days ago. Now I was curious, so I restarted the container again. “ Initializing” screen AGAIN.
Everything worked great ‘til I added the basic auth.
Additional info
No response
Please tick the boxes

[X] You have explained the issue clearly, and included all relevant info
[X] You are using a supported version of Dashy
[X] You've checked that this issue hasn't already been raised
[X] You've checked the docs and troubleshooting guide
[X] You agree to the code of conduct

Hmm that kinda sounds like a caching issue, could you try clearing cache and cookies?

Done. Same result.

Could you post your conf.yml, and your log?

I'm unclear on "log". Is that the name of the file? Can you tell me where exactly to find it?
conf.yml:
pageInfo:
title: Mission Control
description: Donnie Ferris's Homelab
navLinks:
- title: Bookmarks
path: https://bookmarks.donferris.me
target: newtab
- title: GitHub
path: https://github.com/donferris
target: newtab
- title: Documentation
path: https://dashy.to/docs
target: newtab
appConfig:
theme: material-dark
layout: horizontal
iconSize: small
startingView: default
defaultOpeningMethod: newtab
statusCheck: true
statusCheckInterval: 60
faviconApi: allesedv
routingMode: history
enableMultiTasking: false
widgetsAlwaysUseProxy: false
webSearch:
disableWebSearch: false
searchEngine: duckduckgo
openingMethod: newtab
searchBangs: {}
enableFontAwesome: true
enableMaterialDesignIcons: false
hideComponents:
hideHeading: false
hideNav: false
hideSearch: false
hideSettings: false
hideFooter: false
auth:
users:
- user: admin
hash: 14656ad68233df29c17dd8e462f063c22fb1318
type: admin
- user: guest
hash: 8be0b5445fca6eb16d14c6f4eaff1cf1d1a3362
enableGuestAccess: true
enableOidc: false
oidc: {}
enableHeaderAuth: false
headerAuth:
userHeader: REMOTE_USER
proxyWhitelist: []
enableKeycloak: false
showSplashScreen: false
preventWriteToDisk: false
preventLocalSave: false
disableConfiguration: false
disableConfigurationForNonAdmin: false
allowConfigEdit: true
enableServiceWorker: false
disableContextMenu: false
disableUpdateChecks: false
disableSmartSort: false
enableErrorReporting: false
sections:

name: Management
displayData:
sortBy: default
rows: 1
cols: 1
collapsed: false
hideForGuests: true
items:

title: Lab Docs
icon: fas fa-file
url: https://labdocs.donferris.me
id: 0_1021_labdocs
title: Yacht
icon: fas fa-ship
url: https://yacht.donferris.me
id: 1_1021_yacht
title: Portainer
icon: fas fa-anchor
url: https://portainer.donferris.me
target: newtab
id: 2_1021_portainer
icon: fas fa-wrench

name: Services
icon: fas fa-bolt
displayData:
sortBy: default
rows: 1
cols: 1
collapsed: false
hideForGuests: false
items: []
name: Websites
icon: fas fa-atom
displayData:
sortBy: default
rows: 1
cols: 1
collapsed: false
hideForGuests: false
items: []
name: Media
icon: fas fa-film fas fa-music
displayData:
sortBy: default
rows: 1
cols: 1
collapsed: false
hideForGuests: false
items: []
name: Dashy
icon: fas fa-rocket
items:

title: Dashy Live
description: Development a project management links for Dashy
icon: https://i.ibb.co/qWWpD0v/astro-dab-128.png
url: https://live.dashy.to/
target: newtab
id: 0_505_dashylive
title: GitHub
description: Source Code, Issues and Pull Requests
url: https://github.com/lissy93/dashy
icon: favicon
id: 1_505_github
title: Docs
description: Configuring & Usage Documentation
provider: Dashy.to
icon: far fa-book
url: https://dashy.to/docs
id: 2_505_docs
title: Showcase
description: See how others are using Dashy
url: https://github.com/Lissy93/dashy/blob/master/docs/showcase.md
icon: far fa-grin-hearts
id: 3_505_showcase
title: Config Guide
description: See full list of configuration options
url: https://github.com/Lissy93/dashy/blob/master/docs/configuring.md
icon: fas fa-wrench
id: 4_505_configguide
title: Support
description: Get help with Dashy, raise a bug, or get in contact
url: https://github.com/Lissy93/dashy/blob/master/.github/SUPPORT.md
icon: far fa-hands-helping
id: 5_505_support
displayData:
sortBy: default
rows: 1
cols: 1
collapsed: true
hideForGuests: false
`
That was a little difficult. I got it through a shell executed from Portainer and I had to copy and paste it 25 lines at a time. So I left out the custom colors section which I assume you don't really need.

If you role back your most recent change, does everything work again?
If clearing browser data didn't help, killing and restarting the container should fix it.
Rest assured, your config data should be fine, and unaffected. Dashy won't write anything to that file without you saving changes, and backups are always made in the user-data dir.


Unlocalized skill checks

Looks like there are still a few skill checks that don't get localized properly:

First one is a skill check rolled directly from an NPC sheet, the second one is rolled from a PC sheet.
Also, for @Check rolls with a set DC, the skill name in the DC line is not localized:

Same issue as 2253?

The other issue is related to skill variants. This issue is about actual skills

Inline skill checks should be fixed by: https://github.com/foundryvtt/pf2e/pull/6727

Should this be closed?

Not quite. While the first issue is solved an @Check command e.g. added to the chat still has the label unlocalized

I think this isn't actually a localization issue though - as far as I understand it the plain check type is used for the label instead of using the skill name - otherwise it would be Thievery in English I guess?


Error loading /config/configuration.yaml: Secret todoist_home_project_id not defined

Hi,
can you help me?
I got this error: Error loading /config/configuration.yaml: Secret todoist_home_project_id not defined
Thanks.

it looks like your secrets are not loading or are not properly referenced.
https://www.home-assistant.io/docs/configuration/secrets#using-secretsyaml

Thanks, I was able to solve the problem, but I still have another one. I'm trying to get the weather integration to work but I'm having trouble. Which is this and where exactly is it configured „weather.koti“?

Thanks, I was able to solve the problem, but I still have another one. I'm trying to get the weather integration to work but I'm having trouble. Which is this and where exactly is it configured „weather.koti“?

sorry for my late response. i think then you are looking for the following location: https://github.com/troinine/hass-config/blob/main/popups/common/weather-forecast.yaml
then line number 33

Hey @stromen1! And thanks to @RubenDijk for providing support here! Few bits to add.
weather.koti is my personal weather entity. Your HA has probably your own with a different name, assuming you have enabled a weather integration. I personally use AccuWeather.
When you have enabled a weather integration you can see a weather sensor. weather.koti is used in few places but a find-and-replace with VSCode for example will do the trick for you 😄.


hipblas cannot build using cmake on windows with rocm5.7.1

-- hip::amdhip64 is SHARED_LIBRARY
-- hip::amdhip64 is SHARED_LIBRARY
-- HIP and hipBLAS found
-- CMAKE_SYSTEM_PROCESSOR: AMD64
-- x86 detected
-- Configuring done (0.2s)
CMake Error at CMakeLists.txt:213 (add_library):
  Cannot find source file:

    W:/git/rwkv.cpp/ggml/src/ggml-cuda.cu

  Tried extensions .c .C .c++ .cc .cpp .cxx .cu .mpp .m .M .mm .ixx .cppm .h
  .hh .h++ .hm .hpp .hxx .in .txx .f .F .for .f77 .f90 .f95 .f03 .hip .ispc

CMake Error at CMakeLists.txt:407 (add_library):
  Cannot find source file:

    W:/git/rwkv.cpp/ggml/src/ggml.c

  Tried extensions .c .C .c++ .cc .cpp .cxx .cu .mpp .m .M .mm .ixx .cppm .h
  .hh .h++ .hm .hpp .hxx .in .txx .f .F .for .f77 .f90 .f95 .f03 .hip .ispc

CMake Error at CMakeLists.txt:213 (add_library):
  No SOURCES given to target: ggml-rocm

CMake Error at CMakeLists.txt:407 (add_library):
  No SOURCES given to target: ggml

CMake Generate step failed.  Build files cannot be regenerated correctly.

cmake .. -G "Ninja" -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++ -DRWKV_HIPBLAS=ON -DCMcmake .. -G "Ninja" -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++ -DRWKV_HIPBLAS=ON -DCMAKE_BUILD_TYPE=Release -DAMDGPU_TARGETS=gfx1100AKE_BUILD_TYPE=Release -DAMDGPU_TARGETS=gfx1100
I think it stop working now.

Cannot find source file

Looks like files of ggml are missing completely. Please make sure you've cloned the repository with --recursive flag present: git clone --recursive https://github.com/saharNooby/rwkv.cpp.git.

good, thanks.


Mobile device view: toggling stories panel with ☰ button

Issue:
What I did

adapted Header component  to have ☰ button when on mobile device
make stories-panel toggled by clicking ☰ button
added helper to detect whether the storybook is open on mobile device (this is done through userAgent of window)
adjusted styles

Now on mobile devices the layout looks something like this when storybook is rendered:

How to test
Open storybook on mobile device
Is this testable with Jest or Chromatic screenshots?
yes (I added some new tests)
Does this need a new example in the kitchen sink apps?
no
Does this need an update to the documentation?
not sure
If your answer is yes to any of these, please make sure to include it in your PR.

It breaks in a weird manner when I try to resize stories panel on mobile: https://deploy-preview-3337--storybooks-official.netlify.com/?selectedKind=ui%2FAddonPanel&selectedStory=default&full=0&addons=1&stories=0&panelRight=0&addonPanel=storybook%2Factions%2Factions-panel

@denzenin Thank you for this amazing first PR, thank you!

@Hypnosphi regarding breaking on resize. yes, it is weird indeed. It seems that resizing of SplitPane works far from smooth on mobile. Tried it on master branch. Even when I had succeeded to resize story-panel I could resize it again (after first resize) only once in a bunch of tries.

@ndelangen thank you for the kind words :)

So should we maybe disable resizing on mobile at all?

Good day to all, could you please advise what changes should I make to my pull request to move it forward? Maybe one step at a time but still I need to know those steps :)

What do you think about this?

should we maybe disable resizing on mobile at all?

You also need to resolve conflicts, feel free to ask for help if you need one

It would be more explicit if we would just disable handlers

Awesome work @denzenin ! 💪

yay! thank you all for your help and support :)

@Aarbel try latest alpha, 4.0.0-alpha.20


Add security contact for several plugins

@csanchez @Vlatombe As maintainers, please approve or contact @richbg.
FYI @maxlaverse @maselvaraj this is seeking to define who would be informed about security vulnerabilities in these plugins. In the past I've chosen a maintainer at random. Docs: https://github.com/jenkins-infra/repository-permissions-updater#managing-security-process

Sure. Thanks @daniel-beck  👍

Premature, lacking approval from artifact-manager-s3 and kubernetes-credentials maintainers.

My apologies, I misunderstood the approvals that were waiting.

Sorry, I overlooked the first GitHub notification.
The kubernetes-credentials plugin is backed by individuals and doesn't have a dedicated security team but I'd like to be informed if there are security vulnerabilities in it.
Who is represented by cloud_platform_v2 @slide ? It's not mentioned in the link you pasted and apparently it's not used for any other plugin than the 3 in this pull-request.

@maxlaverse It's an account backed by a team at CloudBees (I believe one that Carlos and Vincent are on, hence the choice for these plugins). We started doing this quite a bit recently -- e.g. most of the Pipeline and Blue Ocean plugins are covered similarly. The idea here is that doing so makes it much less likely that issues fall between the cracks and are forgotten.

I'd like to be informed if there are security vulnerabilities in it.

From a Jenkins security team perspective, we can only add one assignee to Jira issues, and doing further out of bands communication is simply too much overhead. So I would ask that you align with your co-maintainers here. Maybe it's good enough to leave the security contact as defined here, and they keep you informed out of band -- something we recommend anyway to prevent regular releases from interfering with security update preparation (something that's happened with Mesos Plugin before because only Vincent was aware this was happening).
If you'd prefer to revert this change in the mean time, please file a PR to revert your plugin's part of this change and we'll go back to the default of "choose one of the maintainers as contact for security issues" until a security contact is defined.

Sure, I understand.
I'm perfectly fine with having that team from CloudBees notified first. It's a pretty small plugin with only a few lines of code and the initial implementation was done by another CloudBees employee anyway.
Thanks for the explanation @daniel-beck


Use the same method that we generate private keys in BLS

we could use the same method that we generate private keys in BLS where some 32 bytes entropy bytes are an input, in our case the whole digest. However @asonnino it's very common for rogue key protection to use half scalars, because we care about pre-image attacks; you try to cancel-out another pub key, so combinatorics are already very expensive.
We do use half scalars in many apps (ie in the EdDSA half aggregation) for performance reasons to make that exponentiation half-expensive. In fact though, here we don't care, as this applies once at private key randomization (and with our mode where new-priv_key = old_priv_key \times this_scalar, we don't even have an ECC operation).
@asonnino: You remember the discussion we had at overleaf, shall we update the private key or for each signature we multiply by this scalar? if we do the former half or full scalar doesn't really matter. In the second you have to pay that cost every time you sign.
Originally posted by @kchalkias in https://github.com/MystenLabs/fastcrypto/pull/236#discussion_r1027302408

@kchalkias There's a method called get_128bit_scalar given an RNG in the bls12381 module which is used to randomise signatures in verify_batch_empty_fail_different_msg. If half scalars are enough, we could change this method to take 16 bytes instead. Using the generate method, as you suggest, is also possible but then we would have to either extract the scalar from the private key afterwards, or use the private key type to represent the scalar.


:robot: Add group3r.vm

Automated PR from https://github.com/mandiant/VM-Packages/issues/506 :rocket:

@Menn1s, @day1player, @skollr34p3r please review


problems with percentile_cont and percentile_disc

I have a problem, I'll give a code for example case:
[Enter feedback here]
ELECT
installationFullName, PERCENTILE_CONT(0.95) OVER (ORDER BY Real_tanque) as mediana
FROM [autonomia]
GROUP BY installationFullName,SlidingWindow(hour, 1)
and this is the error in the console:
Failed to compile the query script: Parameter '0' of function 'percentile_cont' is out of range between '0' and '1' : '95'.. Error position: {"StartLine":84,"StartColumn":27,"StartOffset":2091,"EndLine":84,"EndColumn":75,"EndOffset":2139,"Expression":"PERCENTILE_CONT ( 0.95 ) OVER ( ORDER BY Real_tanque )"}.
[2023/08/30 04:10:47 PM] [Error] An error occurred while executing the command: localrun, error details: Parameter '0' of function 'percentile_cont' is out of range between '0' and '1' : '95'..
I don't understand why it doesn't work
Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 50141507-37cc-1180-1e02-2b737a7c7cad
Version Independent ID: 881c9624-2a77-4a7e-801e-8c6f2ef294d3
Content: Percentile_Cont (Azure Stream Analytics) - Stream Analytics Query
Content Source: stream-analytics-docs/percentile-cont-azure-stream-analytics.md
Service: stream-analytics
GitHub Login: @ajetasin
Microsoft Alias: ajetasi

#sign-off

#please-close


ScottPlot5: Cache typefaces to improve Linux performance

Hello,
I'm experiencing some problems with ScottPlot version 5 on linux, the rendering time is too big. If you enable the performance meter with double click, it shows 70-100 ms time and 10-15 fps on an empty plot. To run on linux I use an Avalonia gui, with custom-made control (this is not important, the root of the bug is plot.Render(SKSurface).
You may found a reproduction sample application on this repo.
I've looked at the code and conclude, that Extensions/SkiaSharpExtensions -> ApplyToPaint(this FontStyle fontStyle, SKPaint paint) is the root of the problem, and the exact call is SKTypeface.FromFamilyName(fontStyle.Name, skfs).
For some unknown reason this call takes about 4ms, and that function is called by axes measure and panel rendering 17 times each rendering time!
To test my assumptions, I've replaced the var assignment with
SKTypeface typeface = (_typeface == null) ? SKTypeface.FromFamilyName(fontStyle.Name, skfs) : _typeface;
and declared a static _typeface nearby at class level (private static SKTypeface? _typeface = null;). That is, I just cached the call's result. And, it began to work as expected! The frame rate became the same as I saw on Windows, 200+.
So, it seems some caching layer is needed to negate the slow call on Linux. I don't know the reasons, but I've checked that on two different distributions with the same outcome.
System Details

ScottPlot Version: 5.0.1-beta
Operating System: Ubuntu Linux 22.04.1 LTS, ArchLinux current
Application Type: Avalonia (actually didn't matter)
.NET Version: .NET 6.0, 7.0

HI @nightfog-git,
The requested font may not be available on your system. The search takes a long time and eventually returns the default font.
Check that the requested and returned font match. Try changing the requested font to one that is exactly on your system.

I've checked that, the requested one is Numbus Sans, and SKTypeface.FromFamilyName returns the object with the same FamilyName. The font file is physically present in /usr/share/fonts/gsfonts.

Thanks for reporting this @nightfog-git!
For added context, the SKTypeface.FromFamilyName() call here is what you say is slow on Linux:
https://github.com/ScottPlot/ScottPlot/blob/8bf79deee6501d4bcdd7e1548034444cb9d43bda/src/ScottPlot5/ScottPlot5/Extensions/SkiaSharpExtensions.cs#L91-L102
ScottPlot 5 has a static FontService class:
https://github.com/ScottPlot/ScottPlot/blob/ebde30ccb26dc2bacc2c9cc97e90bbe9bcb3c055/src/ScottPlot5/ScottPlot5/FontService.cs#L1-L68
It sounds like we could extend it by adding a system to call SKTypeface.FromFamilyName() and cache the results, then ensure that all font code only retrieves SKTypeface through that caching service.
It may take me a few days to get to it, but I'll definitely work to improve this! When it's ready to try I'll follow-up here and you can confirm whether or not performance on Linux improved. Thanks again for reporting this issue!

Related, some of these font services fail in some configurations of .NET Framework apps (e.g., in VS designer, #2491)
When this topic is investigated further, .NET Framework 4.6.2 tests should be added to ensure everything works
It may be worth considering whether or not to keep supporting .NET Framework in ScottPlot 5 🔥
We should at least wrap DLL calls like these in exception handlers so they fail with a more descriptive error message indicating how to fix it (e.g., target .NET Core)