Sbt integration

This merges https://github.com/scala-ide/sbt-integration into scala-ide core. Furthermore it also integrates @dragos first attempt of an sbt editor (in #912 and #913) into the new module sbt.core.
TODO:

[ ] Replace hard-coded paths in SbtPresentationCompiler with sbt-server integration.
[ ] Remove DefaultScalaEditorConfiguration. This class simply shouldn't exist. We should remove functionality that can't be used in the sbt editor out of ScalaSourceViewerConfiguration and not add another source viewer configuration that doesn't have any functionality.

It looks like Akka requires Java 8...

On 04/12/2016 02:20 PM, Iulian Dragos wrote:

It looks like Akka requires Java 8...

Yes, we need to update the Java version anyway for Mars. Can we update
the Java version on Jenkins?

I'll look into it.

retest this please

Seems that Java 8 is in place. Only one test failed, on Mars. Probably a flaky test.

Ok, thanks.

Superseded by the scala-ide/sbt-integration branch


docs: changelog for v0.0.1-policy-assistant

The link to the demo will be broken until #269 merges

/ok-to-test

/lgtm


Questions about performing fips validation for specific modes

Hello,
I have some questions about performing a fips validation for a specific algorithm using libacvp:
Say I wanted to perform a fips validation for only AES CBC and ECB modes. Currently when I download aes vectors using the command:

./app/acvp_app --aes --vector_req ./vectors

I receive vector sets for all AES algorithms.
After processing only AES and CBC vector sets and performing a fips validation using commands:

./app/acvp_app --post ./metadata/person.json
./app/acvp_app --aes --vector_upload JSONresponses --fips_validation ./metadata/validation.json --verbose

I get the following error:

***ACVP [ERR][acvp_get_result_test_session:2618]--> Missing submissions for one or more vector sets. Please submit responses for all vector sets.
***ACVP [ERR][acvp_validate_test_session:2801]--> This testSession cannot be certified. Required disposition == 'pass'.

How can I use libacvp to download only the vectorsets that correspond to specific modes such as ECB and CBC? If this is possible, where in the app source code would I make this modification?

Is it possible to manually download vectors for specific algorithms using the POST, GET or PUT requests in the app? If so how would this be done and how would you save the server response to a file?

You just need to go into app_main.c and comment out the flavors of AES you do not want to register for in enable_aes() and re-compile.

I have a question about that :
for example in aes cbc mode , the parameter plaintext is set thanks to this command.
rv = acvp_cap_sym_cipher_set_parm(ctx, ACVP_AES_CBC, ACVP_SYM_CIPH_PTLEN, 1536);
The value 1536 is just an example or it is based on ACVP protocol.
Can we have a bigger value than 1536 or not ?
Best regards,

That value is dependent upon your crypto module. All of the values used in the registration in app_main.c are examples only, mostly based on openssl FOM.

ok thanks


sqlite open as readonly db

Fixes #77
All future modules should use open_sqlite_db_readonly(path) from ilapfuncs instead of sqlite3.connect(path)
I will be making the same edits to ileapp too tomorrow.

This is good stuff. I had no idea there was a function for it. 👏 👏 👏

I finally got around to implementing this, it's been a long time. Can you test this and make sure it works ok, before merging?

Artifact needs to be renamed. Going to test now.

I think it's case sensitive, was working on stuff yesterday and saw this. Rename to be lowercase.

Lowercased it. Going to compare master with the output of the PR.
BRB....

Worked like a charm. Did some random checks. No changes in output so far. That being said this is a great improvement for the obvious forensic implications. Thanks @ydkhatri. Learned something new. Obligatory tweet incoming. LOL!
Merging pull request.

I blame git. I think since I renamed the file on Windows, git did not take notice.


CLN plugin does not gracefully exit

It should subscribe to shutdown event notification to know when lightningd is about to stop. Otherwise, this happens:
Sep  4 13:53:58 vlad-VirtualBox systemd[1]: Stopping Core Lightning daemon...
Sep  4 13:53:59 vlad-VirtualBox systemd[1]: lightningd.service: Deactivated successfully.
Sep  4 13:53:59 vlad-VirtualBox systemd[1]: lightningd.service: Unit process 18447 (peerswap) remains running after unit stopped.
Sep  4 13:53:59 vlad-VirtualBox systemd[1]: lightningd.service: Unit process 18472 (lightning_conne) remains running after unit stopped.
Sep  4 13:53:59 vlad-VirtualBox systemd[1]: lightningd.service: Unit process 18539 (peerswap) remains running after unit stopped.
Sep  4 13:53:59 vlad-VirtualBox systemd[1]: lightningd.service: Unit process 18564 (lightning_conne) remains running after unit stopped.
Sep  4 13:53:59 vlad-VirtualBox systemd[1]: lightningd.service: Unit process 18590 (peerswap) remains running after unit stopped.
Sep  4 13:53:59 vlad-VirtualBox systemd[1]: lightningd.service: Unit process 18614 (lightning_hsmd) remains running after unit stopped.
Sep  4 13:53:59 vlad-VirtualBox systemd[1]: lightningd.service: Unit process 18615 (lightning_conne) remains running after unit stopped.
Sep  4 13:53:59 vlad-VirtualBox systemd[1]: lightningd.service: Unit process 18639 (peerswap) remains running after unit stopped.
Sep  4 13:53:59 vlad-VirtualBox systemd[1]: lightningd.service: Unit process 18662 (lightning_hsmd) remains running after unit stopped.
Sep  4 13:53:59 vlad-VirtualBox systemd[1]: lightningd.service: Unit process 18663 (lightning_conne) remains running after unit stopped.
Sep  4 13:53:59 vlad-VirtualBox systemd[1]: lightningd.service: Unit process 18784 (peerswap) remains running after unit stopped.
Sep  4 13:53:59 vlad-VirtualBox systemd[1]: lightningd.service: Unit process 18851 (lightning_hsmd) remains running after unit stopped.
Sep  4 13:53:59 vlad-VirtualBox systemd[1]: lightningd.service: Unit process 18856 (lightning_conne) remains running after unit stopped.
Sep  4 13:53:59 vlad-VirtualBox systemd[1]: lightningd.service: Unit process 18936 (peerswap) remains running after unit stopped.
Sep  4 13:53:59 vlad-VirtualBox systemd[1]: lightningd.service: Unit process 18959 (lightning_conne) remains running after unit stopped.
Sep  4 13:53:59 vlad-VirtualBox systemd[1]: lightningd.service: Unit process 18982 (peerswap) remains running after unit stopped.
Sep  4 13:53:59 vlad-VirtualBox systemd[1]: lightningd.service: Unit process 19006 (lightning_hsmd) remains running after unit stopped.
Sep  4 13:53:59 vlad-VirtualBox systemd[1]: lightningd.service: Unit process 19007 (lightning_conne) remains running after unit stopped.
Sep  4 13:53:59 vlad-VirtualBox systemd[1]: lightningd.service: Unit process 19064 (peerswap) remains running after unit stopped.
Sep  4 13:53:59 vlad-VirtualBox systemd[1]: lightningd.service: Unit process 19089 (lightning_hsmd) remains running after unit stopped.
Sep  4 13:53:59 vlad-VirtualBox systemd[1]: lightningd.service: Unit process 19090 (lightning_conne) remains running after unit stopped.
Sep  4 13:53:59 vlad-VirtualBox systemd[1]: lightningd.service: Unit process 19181 (peerswap) remains running after unit stopped.
Sep  4 13:53:59 vlad-VirtualBox systemd[1]: lightningd.service: Unit process 19270 (lightning_hsmd) remains running after unit stopped.
Sep  4 13:53:59 vlad-VirtualBox systemd[1]: lightningd.service: Unit process 19274 (lightning_conne) remains running after unit stopped.
Sep  4 13:53:59 vlad-VirtualBox systemd[1]: lightningd.service: Unit process 19343 (peerswap) remains running after unit stopped.
Sep  4 13:53:59 vlad-VirtualBox systemd[1]: lightningd.service: Unit process 19365 (lightning_hsmd) remains running after unit stopped.
Sep  4 13:53:59 vlad-VirtualBox systemd[1]: lightningd.service: Unit process 19366 (lightning_conne) remains running after unit stopped.
Sep  4 13:53:59 vlad-VirtualBox systemd[1]: lightningd.service: Unit process 19417 (peerswap) remains running after unit stopped.
Sep  4 13:53:59 vlad-VirtualBox systemd[1]: lightningd.service: Unit process 19441 (lightning_conne) remains running after unit stopped.
Sep  4 13:53:59 vlad-VirtualBox systemd[1]: lightningd.service: Unit process 19628 (peerswap) remains running after unit stopped.
Sep  4 13:53:59 vlad-VirtualBox systemd[1]: lightningd.service: Unit process 19739 (lightning_conne) remains running after unit stopped.
Sep  4 13:53:59 vlad-VirtualBox systemd[1]: lightningd.service: Unit process 19784 (lightning_hsmd) remains running after unit stopped.
Sep  4 13:53:59 vlad-VirtualBox systemd[1]: lightningd.service: Unit process 29117 (peerswap) remains running after unit stopped.
Sep  4 13:53:59 vlad-VirtualBox systemd[1]: lightningd.service: Unit process 29243 (lightning_conne) remains running after unit stopped.
Sep  4 13:53:59 vlad-VirtualBox systemd[1]: lightningd.service: Unit process 29318 (peerswap) remains running after unit stopped.
Sep  4 13:53:59 vlad-VirtualBox systemd[1]: lightningd.service: Unit process 29377 (lightning_conne) remains running after unit stopped.
Sep  4 13:53:59 vlad-VirtualBox systemd[1]: lightningd.service: Unit process 29402 (peerswap) remains running after unit stopped.
Sep  4 13:53:59 vlad-VirtualBox systemd[1]: lightningd.service: Unit process 29425 (lightning_conne) remains running after unit stopped.
Sep  4 13:53:59 vlad-VirtualBox systemd[1]: lightningd.service: Unit process 29483 (peerswap) remains running after unit stopped.
Sep  4 13:53:59 vlad-VirtualBox systemd[1]: lightningd.service: Unit process 29640 (lightning_hsmd) remains running after unit stopped.
Sep  4 13:53:59 vlad-VirtualBox systemd[1]: lightningd.service: Unit process 29656 (lightning_conne) remains running after unit stopped.
Sep  4 13:53:59 vlad-VirtualBox systemd[1]: lightningd.service: Unit process 29745 (peerswap) remains running after unit stopped.
Sep  4 13:53:59 vlad-VirtualBox systemd[1]: lightningd.service: Unit process 29863 (lightning_conne) remains running after unit stopped.
Sep  4 13:53:59 vlad-VirtualBox systemd[1]: lightningd.service: Unit process 29993 (lightning_hsmd) remains running after unit stopped.
Sep  4 13:53:59 vlad-VirtualBox systemd[1]: lightningd.service: Unit process 30607 (lightning_hsmd) remains running after unit stopped.
Sep  4 13:53:59 vlad-VirtualBox systemd[1]: lightningd.service: Unit process 40975 (peerswap) remains running after unit stopped.
Sep  4 13:53:59 vlad-VirtualBox systemd[1]: lightningd.service: Unit process 41065 (lightning_hsmd) remains running after unit stopped.
Sep  4 13:53:59 vlad-VirtualBox systemd[1]: lightningd.service: Unit process 41069 (lightning_conne) remains running after unit stopped.
Sep  4 13:53:59 vlad-VirtualBox systemd[1]: lightningd.service: Unit process 41130 (peerswap) remains running after unit stopped.
Sep  4 13:53:59 vlad-VirtualBox systemd[1]: lightningd.service: Unit process 41155 (lightning_hsmd) remains running after unit stopped.
Sep  4 13:53:59 vlad-VirtualBox systemd[1]: lightningd.service: Unit process 41157 (lightning_conne) remains running after unit stopped.
Sep  4 13:53:59 vlad-VirtualBox systemd[1]: lightningd.service: Unit process 41239 (peerswap) remains running after unit stopped.
Sep  4 13:53:59 vlad-VirtualBox systemd[1]: lightningd.service: Unit process 41380 (lightning_conne) remains running after unit stopped.
Sep  4 13:53:59 vlad-VirtualBox systemd[1]: lightningd.service: Unit process 41417 (peerswap) remains running after unit stopped.
Sep  4 13:53:59 vlad-VirtualBox systemd[1]: lightningd.service: Unit process 41437 (lightning_hsmd) remains running after unit stopped.
Sep  4 13:53:59 vlad-VirtualBox systemd[1]: lightningd.service: Unit process 41438 (lightning_conne) remains running after unit stopped.
Sep  4 13:53:59 vlad-VirtualBox systemd[1]: lightningd.service: Unit process 41498 (peerswap) remains running after unit stopped.
Sep  4 13:53:59 vlad-VirtualBox systemd[1]: lightningd.service: Unit process 41606 (lightning_hsmd) remains running after unit stopped.
Sep  4 13:53:59 vlad-VirtualBox systemd[1]: lightningd.service: Unit process 41622 (lightning_conne) remains running after unit stopped.
Sep  4 13:53:59 vlad-VirtualBox systemd[1]: lightningd.service: Unit process 41739 (peerswap) remains running after unit stopped.
Sep  4 13:53:59 vlad-VirtualBox systemd[1]: lightningd.service: Unit process 41760 (lightning_hsmd) remains running after unit stopped.
Sep  4 13:53:59 vlad-VirtualBox systemd[1]: lightningd.service: Unit process 41761 (lightning_conne) remains running after unit stopped.
Sep  4 13:53:59 vlad-VirtualBox systemd[1]: lightningd.service: Unit process 41787 (peerswap) remains running after unit stopped.
Sep  4 13:53:59 vlad-VirtualBox systemd[1]: lightningd.service: Unit process 41857 (lightning_conne) remains running after unit stopped.
Sep  4 13:53:59 vlad-VirtualBox systemd[1]: lightningd.service: Unit process 52016 (peerswap) remains running after unit stopped.
Sep  4 13:53:59 vlad-VirtualBox systemd[1]: lightningd.service: Unit process 52038 (lightning_hsmd) remains running after unit stopped.
Sep  4 13:53:59 vlad-VirtualBox systemd[1]: lightningd.service: Unit process 52041 (lightning_conne) remains running after unit stopped.
Sep  4 13:53:59 vlad-VirtualBox systemd[1]: lightningd.service: Unit process 52100 (peerswap) remains running after unit stopped.
Sep  4 13:53:59 vlad-VirtualBox systemd[1]: lightningd.service: Unit process 52300 (lightning_conne) remains running after unit stopped.
Sep  4 13:53:59 vlad-VirtualBox systemd[1]: lightningd.service: Unit process 52383 (lightning_hsmd) remains running after unit stopped.
Sep  4 13:53:59 vlad-VirtualBox systemd[1]: lightningd.service: Unit process 52497 (lightning_gossi) remains running after unit stopped.
Sep  4 13:53:59 vlad-VirtualBox systemd[1]: lightningd.service: Unit process 99981 (lightning_hsmd) remains running after unit stopped.
Sep  4 13:53:59 vlad-VirtualBox systemd[1]: lightningd.service: Unit process 139787 (peerswap) remains running after unit stopped.
Sep  4 13:53:59 vlad-VirtualBox systemd[1]: lightningd.service: Unit process 140812 (peerswap) remains running after unit stopped.
Sep  4 13:53:59 vlad-VirtualBox systemd[1]: lightningd.service: Unit process 140893 (peerswap) remains running after unit stopped.
Sep  4 13:53:59 vlad-VirtualBox systemd[1]: lightningd.service: Unit process 140947 (bcli) remains running after unit stopped.
Sep  4 13:53:59 vlad-VirtualBox systemd[1]: lightningd.service: Unit process 140948 (commando) remains running after unit stopped.
Sep  4 13:53:59 vlad-VirtualBox systemd[1]: lightningd.service: Unit process 140949 (fetchinvoice) remains running after unit stopped.
Sep  4 13:53:59 vlad-VirtualBox systemd[1]: lightningd.service: Unit process 140950 (funder) remains running after unit stopped.
Sep  4 13:53:59 vlad-VirtualBox systemd[1]: lightningd.service: Unit process 140951 (topology) remains running after unit stopped.
Sep  4 13:53:59 vlad-VirtualBox systemd[1]: lightningd.service: Unit process 140952 (keysend) remains running after unit stopped.
Sep  4 13:53:59 vlad-VirtualBox systemd[1]: lightningd.service: Unit process 140953 (offers) remains running after unit stopped.
Sep  4 13:53:59 vlad-VirtualBox systemd[1]: lightningd.service: Unit process 140954 (pay) remains running after unit stopped.
Sep  4 13:53:59 vlad-VirtualBox systemd[1]: lightningd.service: Unit process 140956 (txprepare) remains running after unit stopped.
Sep  4 13:53:59 vlad-VirtualBox systemd[1]: lightningd.service: Unit process 140957 (cln-renepay) remains running after unit stopped.
Sep  4 13:53:59 vlad-VirtualBox systemd[1]: Stopped Core Lightning daemon.
Sep  4 13:53:59 vlad-VirtualBox systemd[1]: lightningd.service: Consumed 37.782s CPU time.

Thank you.
Will have a look at it very soon.

Confirmed.
It is necessary to add a shutdown hook to glightning and add to peerswap.
I will address these.

Could you please check if it functions as expected with the build from this PR when you have a moment?
https://github.com/ElementsProject/peerswap/pull/318

Could you please check if it functions as expected with the build from this PR when you have a moment? #318

Hi, I am sure peerswap shuts down gracefully, but CLN 24.08.1 checks too early. It should give 30 seconds, but gives 0:
sep 24 12:43:56 vlad-VirtualBox systemd[1]: Started Core Lightning daemon.
sep 24 12:44:53 vlad-VirtualBox systemd[1]: Stopping Core Lightning daemon...
sep 24 12:44:53 vlad-VirtualBox lightningd[584546]: Lost connection to the RPC socket.
sep 24 12:44:53 vlad-VirtualBox lightningd[584550]: Lost connection to the RPC socket.
sep 24 12:44:53 vlad-VirtualBox lightningd[584549]: Lost connection to the RPC socket.
sep 24 12:44:53 vlad-VirtualBox lightningd[584548]: Lost connection to the RPC socket.
sep 24 12:44:53 vlad-VirtualBox lightningd[584539]: Lost connection to the RPC socket.
sep 24 12:44:53 vlad-VirtualBox systemd[1]: lightningd.service: Deactivated successfully.
sep 24 12:44:53 vlad-VirtualBox lightningd[584538]: Lost connection to the RPC socket.
sep 24 12:44:53 vlad-VirtualBox systemd[1]: lightningd.service: Unit process 584536 (chanbackup) remains running after unit stopped.
sep 24 12:44:53 vlad-VirtualBox lightningd[584547]: Lost connection to the RPC socket.
sep 24 12:44:53 vlad-VirtualBox systemd[1]: lightningd.service: Unit process 584540 (topology) remains running after unit stopped.
sep 24 12:44:53 vlad-VirtualBox lightningd[584543]: Lost connection to the RPC socket.
sep 24 12:44:53 vlad-VirtualBox systemd[1]: lightningd.service: Unit process 584542 (offers) remains running after unit stopped.
sep 24 12:44:53 vlad-VirtualBox lightningd[584535]: Lost connection to the RPC socket.
sep 24 12:44:53 vlad-VirtualBox systemd[1]: lightningd.service: Unit process 584544 (recklessrpc) remains running after unit stopped.
sep 24 12:44:53 vlad-VirtualBox lightningd[584541]: Lost connection to the RPC socket.
sep 24 12:44:53 vlad-VirtualBox systemd[1]: lightningd.service: Unit process 584545 (recover) remains running after unit stopped.
sep 24 12:44:53 vlad-VirtualBox systemd[1]: lightningd.service: Unit process 584547 (cln-renepay) remains running after unit stopped.
sep 24 12:44:53 vlad-VirtualBox systemd[1]: lightningd.service: Unit process 584552 (bookkeeper) remains running after unit stopped.
sep 24 12:44:53 vlad-VirtualBox systemd[1]: lightningd.service: Unit process 584556 (peerswap) remains running after unit stopped.
sep 24 12:44:53 vlad-VirtualBox systemd[1]: lightningd.service: Unit process 584557 (psweb) remains running after unit stopped.
sep 24 12:44:53 vlad-VirtualBox systemd[1]: lightningd.service: Unit process 584808 (lightning_conne) remains running after unit stopped.
sep 24 12:44:53 vlad-VirtualBox systemd[1]: lightningd.service: Unit process 584928 (lightning_gossi) remains running after unit stopped.
sep 24 12:44:53 vlad-VirtualBox systemd[1]: Stopped Core Lightning daemon.
sep 24 12:44:53 vlad-VirtualBox systemd[1]: lightningd.service: Consumed 29.391s CPU time.
sep 24 12:44:53 vlad-VirtualBox lightningd[584536]: Lost connection to the RPC socket.

https://github.com/ElementsProject/lightning/issues/7697

Why was this closed as completed?

Why was this closed as completed?

Because the bug is on CLN side, so I opened the issue there.

Keep it open until the fix is merged upstream


LDAP Connection

Hi,
I can't connect users when ldap backend is configured, all I've got is the red pop-up (Error, Wrong username or password).
These are the parameters that I added to docker-compose.yml :
PASSWORDCOCKPIT_AUTHENTICATION_TYPE: ldap PASSWORDCOCKPIT_LDAP_HOST: ip.address.of.dc PASSWORDCOCKPIT_LDAP_PORT: 389 PASSWORDCOCKPIT_LDAP_USERNAME: uid-name,CN=user,OU=OU,DC=domain,DC=com PASSWORDCOCKPIT_LDAP_PASSWORD: my_password PASSWORDCOCKPIT_LDAP_BASEDN: OU=OU,DC=domain,DC=com PASSWORDCOCKPIT_LDAP_ACCOUNTFILTERFORMAT: (&(memberOf=CN=group,OU=OU,DC=domain,DC=com)(uid=%s)) PASSWORDCOCKPIT_LDAP_BINDREQUIRESDN: 'false' (I tested both without luck)
Do you have any hint to help me configure ldap connection?
Does the default admin work if ldap is configured? Which user is the admin?
Thank you in advance.
Mathieu

I noticed that PASSWORDCOCKPIT_LDAP_USERNAME is uid-name,CN=user,OU=OU,DC=domain,DC=com, correct should be: uid=name,CN=user,OU=OU,DC=domain,DC=com
If LDAP is enabled it works for all users, you cannot deactivate it for one user only (admin). The admin must exist in the baseDN.
Username (uid) of the admin is admin.
You can add another admin user directly through INSERT in the DB, e.g.: INSERT INTO user VALUES('1', 'youradminuid', '$2y$10$NpW4tA8NVA68HDXO.p.lFutTbfD1G5Lw9GeR0S3sBuAY3TQ9t4FUO', 'Your', 'Admin', 'it', null<EMAIL_ADDRESS>'1' ,'0');

I've change uid-name to uid=name but I haven't seen a change.
Our admin is disabled and has been renamed for security reason, I can't create an other one.
I haven't see logs to check if the connection with ActiveDirectory is OK. Is there any?

Have you tried querying and accessing via an LDAP browser to check your PASSWORDCOCKPIT_LDAP_ACCOUNTFILTERFORMAT and PASSWORDCOCKPIT_LDAP_USERNAME?
The user must belong to the group that returns PASSWORDCOCKPIT_LDAP_ACCOUNTFILTERFORMAT. Is it confirmed in your case?
Unfortunately there are no logs for the connection with ActiveDirectory. The error logs can be visible through: docker logs [container_id]
At the moment it is not even possible to define LDAP attributes, which are as follows:

username: uid
name: givenname
surname: sn
email: email

Perhaps your LDAP server does not identify users with these attributes.
Have you tried passwordcockpit without LDAP? Does it work?

PasswordCockpit work without LDAP, but we tried to always work with LDAP to limit number of account for our users. For a password manager, it's mandatory.
After some querying, I've found that we do not use uid or email field, name or surname are not usable because some our users have same firstname or lastname. Usually, we use samAccountName or mail field to identify users.
If it's not possible, I will continue my research for a new password manager.
Thanks for your time.

Make LDAP attributes configurable

Modify:
https://github.com/passwordcockpit/backend/blob/master/src/Authentication/src/Api/V1/Adapter/LdapAdapter.php
Add variables in docker-compose
Remember to add phone (can be emtpy)


Implement absolute-path as a known format for emitter options

From design #2241
An option marked with absolute-path will expect to receive a fully resolved absolute path after interpolation. If not it will emit an error.
// bad
models
./models

// bood
{project-root}/models
{emitter-output-dir}/models
{cwd}/models

est: 5


Scrolling on one page influences scroll position on other page

Hi,
when I scroll down on page 1 so that the header shrinks, and haven't even touched page 2, then switch to page 2, page 2 is scrolled down a lil bit (probably the height of the header).
How can I avoid this behavior?
Thanks and best regards.

Does anyone find any solution for this problem.
please help...

Same problem, how to avoid this behavior?


Cross reference data/:max page in math/:max and vice versa

I published the wiki, changes are live.


az login with SP

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

I am trying use az login with SP .  I a using on Linux , so export as variable . Problem is az vm list or any az command is not working unless, I authenticate with az login --service-principal -u $AZURE_CLIENT_ID -p $AZURE_CLIENT_SECRET --tenant $AZURE_TENANT_ID
Which is fine but after az login , it is generating .azure/accessTokens.json  on home directory and SP credential information are on clear text , which is a big risk for security.
How it should work : After export , az login should work but without generating any .azure/accessTokens.json in clear text. Same login concept is working for AWS . When aws credentials are export then just aws  s3 ls  or similar command work without generating Key and secret is clear text.
Example:
export AZURE_CLIENT_ID=xxxxxxx
export AZURE_CLIENT_SECRET=xxxxxxx
export AZURE_TENANT_ID=xxxxxxx
export AZURE_SUBSCRIPTION_ID=xxxxxx
az login --service-principal -u $AZURE_CLIENT_ID -p $AZURE_CLIENT_SECRET --tenant $AZURE_TENANT_ID
az vm list

Thanks  @Sas002, right now this is by-design. Also ~/.azure is being ACL'd correctly for protection. For record, AWS also saves secret in plain text, or if that been changed, please let me know.
For secret free solution, I very much suggest you go with the managed service identity
Any questions/suggestion, let us know

Closing as we don't have outstanding bugs

Let's discuss this further in https://github.com/Azure/azure-cli/issues/9282.


Partitioned writes may not need to sort the incoming data

Currently writing partitioned data will introduce a sort if the query plan does not already call for an output ordering that matches the partition keys.  However I don't think the ordering is necessary, and it is relatively expensive to perform.  Instead of doing a sort, we distinct and sort the partition keys as we do today, and do a lowerBound against the unsorted incoming batch which produces the partition mapping per row.  We can then call cudf's partition to partition the batch and make the partitions spillable, moving onto the next batch, tracking all the partitions associated with each key as we move through the batches.  Once we reach the end of the batches, we can then proceed to go through the distinct keys, concatenating and encoding the partition data for that key on the GPU, copy the data back to the host, release the GPU semaphore, and write it to the distributed filesystem.
This ends up looking very similar to the dynamic partition writer we have today except it does not require concurrent writers be held open, which will save on CPU memory pressure from multiple file handles being held open.  We may still desire multiple file handles if we find it helps performance (e.g.: multithreaded writes against a cloud store), but it is not required.
Note that doing this refactor should allow us to combine the logic for the dynamic and non-dynamic writers, as they will be quite similar afterwards.

As a follow on to this we might be able to play some performance games even when there is an order by column.  The performance of sorting a single simple columns is much less than sorting multiple columns.  Here is a quick test from my desktop.
spark.time(spark.range(10000000000L).selectExpr("id", "500000000 - id as other", "id + 1000000 as even_other")
   .orderBy("other").show())
5.2 seconds

spark.time(spark.range(10000000000L).selectExpr("id", "500000000 - id as other", "id + 1000000 as even_other")
   .orderBy("other", "id").show())
11.1 seconds

spark.time(spark.range(10000000000L).selectExpr("id", "500000000 - id as other", "id + 1000000 as even_other")
   .orderBy("other", "id", "even_other").show())
11.1 seconds

When going from 1 to 2 columns in the order by the time more than doubled, but when going from 2 to 3 columns the time stayed the same.
The point is that even if we have an order-by clause in the output and the order by is for a single simple column, then we could sort by the single simple column instead of sorting by all of the columns and still do the "dynamic partition writer" assuming that the order of the output rows is preserved when we do the partition call. Which I think it would have to for the proposed code above to do the right thing anyways.

cudf does not guarantee the order within partitions after partition is called, so we could not rely on that.  Therefore if we're using cudf's partition we could only perform this optimization if the query does not require any order before the write.  However it may be difficult to distinguish in the physical CPU plan whether a required ordering on the write came from normal partitioning logic on the CPU or an explicit orderBy requested by the user as part of the write.
Alternatively we could work with cudf to implement a partition that does preserve order (or write our own).


Dontcompile whit some components alcinoe

When I use Layout or TAmemo, TAEdits... I get these restrictions, I don't know if it's the component or an error on my machine. I reinstalled Alcinoe, according to the guidelines and latest corrections...

Sorry once again, I'm having problems, I thought I had solved it for the last time, but I see that you are not patching the files to be able to use the visual components.

Hello, Can you Investigate in your computer why the command "call .\InitEnvironment.bat" located in CompileAll.bat didn't work ?
My guess is that you call CompileAll.bat from a directory different than the Alcinoe root dir

look to it's corrected, if you can try again and confirm everything work as expected ?

Im try againg, aparentely its work well, thanks.


Finetune UX documentation of button component

What is the problem we are solving and why?

As a user, I want to have accessible and a consistent buttons, so I can perform my aactions quickly

As a developer, I want to have an easy to use button component, so I can quickly implement actions in the user interface of the product

As a designer, I want to have clear UX documentation and an easy to use Figma component of a button, so I can quickly create actions in my prototypes

Description
When the buttons tokens for all different brands are ready we need to start with finetuning of the UX Documentation.
Design
The design of the multi-brand button component can be found in Figma when they are ready.
https://github.com/sanomalearning/design-system/issues/169#tasklist-block-f1757676-0338-49af-882f-f3b922a1fafc

solved in #172


Support /completion

Implement the completion support API

In progress

First experiment being tested

Fixed in https://github.com/dart-lang/dart-services/pull/79


Change resolution when no connected monitor

I try to provide the size argument, but it has no effect.
This is the warning I keep seeing:
x11docker note: Could not detect any connected monitor.
  Running on a server? Will try to set a framebuffer size
  with xrandr --fb 1024x768 that may serve as a virtual display.

Is there any way to change that default value to something else?

To provide more context, I am trying to run it in a script with the options for GPU. I got this from the other issues (for example: https://github.com/mviereck/x11docker/issues/206):
#! /bin/bash
read Xenv < <(x11docker --xorg --gpu --xtest --display=30 --showenv --exe -- SINGULARITY_COMMAND)
env $Xenv xpra start :30 --use-display --start-via-proxy=no --daemon=no

I found two related bugs (check of xrandr output (available monitors) and check of --size argument).
Please update to master version and try again.

@mviereck I pulled the latest master version, with this command curl -fsSL https://raw.githubusercontent.com/mviereck/x11docker/master/x11docker | sudo bash -s -- --update and was able to see this note x11docker note: Installed x11docker version 6.7.0. However, even when supplying a size in the script, it doesn't change the size and I still see the warning about xrandr.
read Xenv < <(x11docker --display=30 --desktop --size 1920x1080 --pulseaudio --gpu --xorg --xtest --showenv x11docker/lxde-wine)
Is that correct?
My current workaround is that once I am able to get into the container and access terminal, I just type xrandr --fb 1920x1080 and it will resize the desktop.

Please use --update-master instead of --update.
You can just run sudo x11docker --update-master.
( The long command with curl just helps for first installation.)

@mviereck ok, that worked. Thanks!
New note, which is from the latest version.
x11docker note: Could not detect any connected monitor.
  Running on a server? Will try to set a framebuffer size
  with xrandr --fb x that may serve as a virtual display.

Works.

@mviereck actually, sorry. What worked was updating to the latest branch. And what works now, that didn't before, is resizing the display from the client end. However, the default size does not go through.
This is what I see in the xpra output on the host:
2021-03-29 13:57:46,831  running with pid 1446949 on Linux Ubuntu 20.04 focal
2021-03-29 13:57:46,836  connected to X11 display :30 with 24 bit colors
2021-03-29 13:57:46,837  initial resolution: 640x480
2021-03-29 13:57:46,843   :30.0 (217x163 mm - DPI: 75x75) workarea: 640x454
2021-03-29 13:57:46,843     monitor 2

Even though I supplied 1920x1080 as an argument to size to x11docker.

Odd. How did you start xpra?

Yet found another bug.
Please update again.
To check: The message should show the size, too:
  with xrandr --fb 1920x1080 that may serve as a virtual display.

Ok, updated,
x11docker note: Installed x11docker version 6.8.0-beta-2

Now the note says:
x11docker note: Could not detect any connected monitor.
  Running on a server? Will try to set a framebuffer size
  with xrandr --fb 1920x1080 that may serve as a virtual display.

And when I started xpra client up, it loads at the right size by default. Thanks! 💯

Great!
Thank you for reporting and testing.


Remove usage of global in covid_model.jl

I haven't run the model on my laptop yet. But I notice the usage of globals in https://github.com/ETACE/ace_covid19/blob/7549e90ff4132ec9ade624470cb444d4836d934f/covid_model.jl#L55-L63. This is known to significantly slow down the code: https://docs.julialang.org/en/v1/manual/performance-tips/#Avoid-global-variables.
I'm not sure what the best remedy is, but I think using a mutable struct instance containing all these vars should alleviate the problem. Hope this will speed up the code.

Note: from personal experience, I had observed a 4x speedup in my code by removing the globals.


Use public key as node uid

#966

Thanks for the pull request, and welcome! The MaidSafe team is excited to review your changes, and you should hear from @canndrew (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
Please see CONTRIBUTOR.md for more information.

Hi! Thanks for this. Were actually in the process though of fixing #966 ourselves and part of this will mean keeping the generic UID parameter. As such I'm going to close this but you should be able to see our fix on the crust dev branch by the end of the week.
Thanks for the effort though :)!

It's still a while away from being production ready I'd say. If you want NAT traversal I'd suggest using the p2p crate
p2p was split off from crust, it's purely for NAT traversal (it's what crust uses internally for NAT traversal) and it's a lot more mature than crust (it works today). Note that you need to use the one on github though as the crates.io version is ancient and pretty much an entirely different library.


Update frameworks.md

Adds Bottr to list of frameworks build on Express.js

Happy to add this, but the wording is not proper English ("...Framework for which...").  Could you please change text to:

Framework that simplifies building chatbot applications.

@crandmck  Updated :)

Thanks!


News page - News Anchor cards carousel

For https://www.sling.com/programming/news develop a card carousel

Similar UI is at https://www.sling.com/programming/entertainment rendering the shows .

Fixed via https://github.com/aemsites/sling/pull/316


Add Dockerfile for Products Project

Dockerfile for Products Project
Some line numbers
Please check for style
Enjoy 🦄
The Docker Image did not work for me,
image: products:latest
so I added a small Troubleshooting section to make a docker image from the Products solution.
Before requesting or performing a merge in upstream:

[ ] Verify that your pull request is following our PR quality criteria (items that apply to All and Learn):
https://review.learn.microsoft.com/help/contribute/contribute-how-to-write-pull-request-quality-criteria?branch=main
[X] Verify your PR has a useful title that reflects what it is for.

@microsoft-github-policy-service agree


style: Use factory.local for the hosts

Description
Standardize on the branding of the solution
Closes #356

An idea to test it, could be use a host, remove it from ci-pool, remove the dnsmasq configurations manually, clone repo, run manually the lab-dns script to test it as a hostand then pass the CI (adding it again to the ci pool)...

An idea to test it, could be use a host, remove it from ci-pool, remove the dnsmasq configurations manually, clone repo, run manually the lab-dns script to test it as a hostand then pass the CI (adding it again to the ci pool)...

:+1:  let's please run a full e2e tests for this PR:

Clean host, no hub
deploy everything.
screenshots
profit

/hold


Adds a from_pydantic method that creates a QueryBuilder from a pydantic Model

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (f7db803) to head (eb89b81).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff            @@
##              main       #22   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            3         4    +1
  Lines          147       153    +6
=========================================
+ Hits           147       153    +6

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (f7db803) to head (ba2b9a2).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff            @@
##              main       #22   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            3         4    +1
  Lines          147       153    +6
=========================================
+ Hits           147       153    +6

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.

Project coverage is 99.38%. Comparing base (ced9c26) to head (abced50).
Report is 1 commits behind head on main.

Files with missing lines
Patch %
Lines

gqlrequests/query_creator.py
90.00%
1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff             @@
##              main      #22      +/-   ##
===========================================
- Coverage   100.00%   99.38%   -0.62%
===========================================
  Files            3        4       +1
  Lines          147      162      +15
===========================================
+ Hits           147      161      +14
- Misses           0        1       +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Map Display jumps due to Qt::QueuedConnection

After the recent upgrade from 1.14.20 to 1.14.23, we observed glitches when rendering dynamic maps such as costmaps.
I tracked the problem down to this commit: https://github.com/ros-visualization/rviz/commit/93ac44b26babb298046694efe78f8f986f7219e9 (PR https://github.com/ros-visualization/rviz/pull/1793)
This "hack" seems to cause a delay in map rendering that leads to a broken map display.
With QueuedConnection
Using an unmodified 1.14.23 from the ROS noetic package distro. The costmap is jumping while moving. Note that the costmap frame_id is in a fixed frame.
https://github.com/ros-visualization/rviz/assets/8985495/6e592999-bd06-4403-afaa-9803da4773c7
Without QueuedConnection
I cloned RViz from source at 1.14.23, removed that Qt::QueuedConnection flag, and built it. Using this patched RViz, the costmap is rendered at the correct spot again without jumping:
https://github.com/ros-visualization/rviz/assets/8985495/b0494338-cfb6-4262-9a3f-1a53f9a75c76
Your environment

OS Version: e.g. Ubuntu 20.04
ROS Distro: Noetic
RViz, Qt, OGRE, OpenGl version as printed by rviz:

[${node} INFO<PHONE_NUMBER>.955965167]: rviz version 1.14.23
[${node} INFO<PHONE_NUMBER>.956069614]: compiled against Qt version 5.12.8
[${node} INFO<PHONE_NUMBER>.956126962]: compiled against OGRE version 1.9.0 (Ghadamon)
[/rviz_1715596402254328779 INFO<PHONE_NUMBER>.270469085]: Forcing OpenGl version 0.
[/rviz_1715596402254328779 INFO<PHONE_NUMBER>.742861634,<PHONE_NUMBER>.783960104]: Stereo is NOT SUPPORTED
[/rviz_1715596402254328779 INFO<PHONE_NUMBER>.743000877,<PHONE_NUMBER>.783960104]: OpenGL device: AMD RENOIR (DRM 3.44.0, 5.16.15-051615-generic, LLVM 12.0.0)
[/rviz_1715596402254328779 INFO<PHONE_NUMBER>.743048266,<PHONE_NUMBER>.783960104]: OpenGl version: 4.6 (GLSL 4.6) limited to GLSL 1.4 on Mesa system.

If source build, which git commit? -
System locale, i.e. the output of echo "$LANG $LC_NUMERIC": en_US.utf8 (LANG=C rviz doesn't change anything here)
Before reporting a rendering issue, try running RViz with LANG=C rviz!

PR with code changes for my workaround: https://github.com/ros-visualization/rviz/pull/1827

This issue has been mentioned on ROS Discourse. There might be relevant details there:
https://discourse.ros.org/t/preparing-for-noetic-sync-2024-05-09/37602/9

Thanks for reporting this issue. Could you please provide a bagfile with your map data to experiment with the issue?

Thanks for providing the bag file. I can reproduce the glitches with that file. However, a simple test example (map_test.py) doesn't exhibit the issue. Thus I don't yet understand, where your particular issue comes from.
What version of the map is shown for the fraction of a second?
Could you please experiment with this test map and try to reproduce your issue with it?

The issue seems to be visible with the following conditions:

grid is moved
content of grid changes

With the queued connection enabled, the previous grid gets first moved to the new position. Then the content gets updated with a short delay. It's not the grid moving to the wrong position, this is easier to see when replaying the videos with slower playback speed.
Here's a modified version of your script that makes it a bit better visible, it uses the RViz logo image from this repository:
https://github.com/magazino/rviz/commit/0bc892642811302511a7a26e7d51dc07ccd0bc28
It looks like in the video below in RViz 1.14.23. Also here I'd recommend to reduce playback speed, but it's also visible in normal speed.
https://github.com/ros-visualization/rviz/assets/8985495/c1d8dfa6-4160-4fbb-9376-88cc81bfe2af
With the modified source without queued connection:
https://github.com/ros-visualization/rviz/assets/8985495/d6938c48-c2e2-4b1b-8767-dc6e9cc9ea2a


Update react.md

Fixed syntax highlighting for JSX code snippets.

I think that should work in gitbook! Thanks @kulakowka


Can’t click on address field drop-down suggestions

Operation System: Linux, Fedora 29
Beaker version: 0.8.6 (flatpak runtime via flathub)

Visit https://example.com so it’s in your history. Close the tab.
Open a new tab and focus the address field
Type example.com
Click on https://example.com/ in the address field drop-down selection list

Expected: should navigate to the pressed item.
Actual: drop-down is dismissed when you click on it and the address field resets to previous value (dismissing what you’ve just typed).
Work-around: use keyboard arrow keys and press enter instead of using the mouse.

Thanks for filing. I'll check into that. It doesn't seem to happen on MacOS.

Same issue on Windows 10.

Okay, I was able to reproduce on Windows and pushed a fix. LMK if that doesn't solve it for you.


Add android studio process logic for JetBrainsToolbox

When searching for android studio plugins path, use the 'idea.paths.selector' as first priority, but when it doesn't exist, use the old version logic.
This will fix: https://github.com/flutter/flutter/issues/27670
https://github.com/flutter/flutter/issues/27136
https://github.com/flutter/flutter/issues/27762
Also see: https://github.com/flutter/flutter/issues/26928

A typical Info.plist(not the real one, just a wrapper) is located in:
~/Applications/JetBrains\ Toolbox/Android\ Studio.app/Contents/Info.plist
with the content below:
<?xml version='1.0' encoding='UTF-8'?>
<!DOCTYPE plist PUBLIC '-//Apple Computer//DTD PLIST 1.0//EN' 'http://www.apple.com/DTDs/PropertyList-1.0.dtd'>
<plist version="1.0">
 <dict>
  <key>CFBundleDevelopmentRegion</key>
  <string>English</string>
  <key>CFBundleExecutable</key>
  <string>jetbrains-toolbox-launcher</string>
  <key>CFBundleGetInfoString</key>
  <string/>
  <key>CFBundleInfoDictionaryVersion</key>
  <string>6.0</string>
  <key>CFBundlePackageType</key>
  <string>APPL</string>
  <key>CFBundleSignature</key>
  <string>????</string>
  <key>NSHumanReadableCopyright</key>
  <string>Copyright (c) JetBrains s.r.o.</string>
  <key>NSHighResolutionCapable</key>
  <true/>
  <key>NSUIElement</key>
  <false/>
  <key>LSUIElement</key>
  <true/>
  <key>CFBundleName</key>
  <string>Android Studio</string>
  <key>CFBundleIdentifier</key>
  <string>com.jetbrains.apps.activator.linkapp.pcom.jetbrains.apps.activator__ndroid_tudio_3_5_anary_3</string>
  <key>CFBundleVersion</key>
  <string>3.5 Canary 3</string>
  <key>CFBundleLongVersionString</key>
  <string>3.5 Canary 3</string>
  <key>CFBundleShortVersionString</key>
  <string>3.5 Canary 3</string>
  <key>CFBundleIconFile</key>
  <string>icon.icns</string>
  <key>JetBrainsToolboxApp</key>
  <string>/Users/kylewong/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/183.5256920/Android Studio 3.5 Preview.app</string>
 </dict>
</plist>

@kangwang1988 Sorry, I'm not qualified to review this.

@cbracken
Could you have a look at this PR please?

@xster
This is an regression where I tried to resolve: https://github.com/flutter/flutter/issues/26928
However, there are some cases like downloading by JetBrainsToolbox which will fail the flutter doctor command. I've seen several reports about this, it seems to be a blocker now.
Please review this pr when available.

Thanks for the quick fix. Can we add some tests here?

Thanks for the quick fix. Can we add some tests here?

I tried to add some tests.
However, as
  group('pluginsPath', () {
    testUsingContext('extracts custom paths from home dir', () {
      final AndroidStudio studio =
          AndroidStudio.fromHomeDot(fs.directory(studioHome));
      expect(studio, isNotNull);
      expect(studio.pluginsPath,
          equals('/home/me/.AndroidStudioWithCheese5.0/config/plugins'));
    }, overrides: <Type, Generator>{
      FileSystem: () => fs,
      // Custom home paths are not supported on macOS nor Windows yet,
      // so we force the platform to fake Linux here.
      Platform: () => linuxPlatform(),
    });
  });

It fails.

Perhaps try something like https://github.com/flutter/flutter/blob/master/packages/flutter_tools/test/ios/cocoapods_test.dart#L49 via MemoryFileSystems.

Perhaps try something like https://github.com/flutter/flutter/blob/master/packages/flutter_tools/test/ios/cocoapods_test.dart#L49 via MemoryFileSystems. (I don't know if it works, I haven't tried it but that test seems like a promising prior art)

It does no help.
This logic is used in android_studio.dart
String get homeDirPath {
  if (_homeDirPath == null) {
    _homeDirPath = platform.isWindows
        ? platform.environment['USERPROFILE']
        : platform.environment['HOME'];
    if (_homeDirPath != null)
      _homeDirPath = fs.path.absolute(_homeDirPath);
  }
  return _homeDirPath;
}

However,
// Custom home paths are not supported on macOS nor Windows yet,
// so we force the platform to fake Linux here.

When I write a test like
expect(pluginPath, fs.path.join(homedir,...))
It will always fail on mac.

@xster
I believe their is a conflicts in common.dart(flutter_tools/lib/src/base)

Which will fail the multiple FakePlatform, I will address a new pr to resolve the test issues.

I'm not sure I understand what's meant in the screenshot? Is it that the caching breaks tests when there are multiple tests?
Feel free to merge this one (when the tree is green) and address the test in a separate PR.

@xster
https://github.com/flutter/flutter/pull/27873 has more information.


Create aims-and-values.md

closes #ISSUE-NO
What does this PR do?
Description of the task to be completed?
How can this be manually tested?
Any background context you want to provide?
Is there any relevant issue to this PR?
Screenshots (if appropriate)
Questions

Maybe add a link to the sidebar docs/_layout/sidebar.md

@schmelto the last line e.g. EOF is in a newline as this has been the standard for a number of languages.


[WIP] pip install and convert to RST

This updates the README to recommend to pip install and converts the README to reStructured text which PyPI can render.

Codecov Report

Merging #73 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master     #73   +/-   ##
======================================
  Coverage    92.6%   92.6%
======================================
  Files          12      12
  Lines         500     500
======================================
  Hits          463     463
  Misses         37      37

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 374f57c...9589104. Read the comment docs.

This is ready, can't spot any more rendering errors in the converted readme.


在provide中使用expect，似乎没有生效

Describe the bug
const wrapper = await mount(HH, {
props: listData,
global: {
provide: {
onShowAllReply: async data => {
console.log(12)
expect(12).toBe(undefined);
},
},
},
});
这是我的代码，12可以正常输入，但是断言成功了？
Reproduction
https://github.com/vitest-dev/vitest
System Info
npx envinfo --system --npmPackages '{vitest,@vitest/*,vite,@vitejs/*}' --binaries --browsers

Used Package Manager
pnpm
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

这里断言失败的异常似乎被vue捕获了，所以vitest没有监听到


Adding the i18n keys for the voucher status

Screenshots
English

French

Needed for the pull request #175 of the frontend project :)

I've removed the extra space, thank you!

Let's make sure to get a review before merging in the future :)

@ann-kilzer My mistake, I'll do that next time.


Reduce the number of states

None is almost always an alias of Error. Also, it is a real mystery to understand why a status is None. Let's remove it.
Also treat unexpected libvirt statuses as errors like pause, pmsuspended, etc.
crc doesn't nothing with state.Saved, Paused, etc. It is better to remove it and show an error.

Yes you are right for paused. I ran a loop asking for the state of crc domain and I got:
$ repeat 1000 virsh --connect qemu:///system domstate crc
error: failed to get domain 'crc'

error: failed to get domain 'crc'

paused

paused

paused

paused

paused

paused

paused

paused

running

running

running


Add support for imports in parent class(es)

Would fix #116

Coverage increased (+0.004%) to 99.459% when pulling f8a630aad88fbb668541a3a184d49582ef1eed8d on Add-support-for-parent-class-imports into d58e4c61d8547c2284ca5fabcf79523b37e1affa on develop.


Enhance catalog.create_database with exist_ok option

Is your idea related to a problem? Please describe.
catalog.create_database currently raises an exception if the database already exists. As a user, my goal is simply to idempotently ensure that the database exists, preferably without having to deal with any exception.
Describe the solution you'd like
I request an exist_ok option motivated by the one in pathlib.Path.mkdir. Just as in mkdir, its default value would be False. It would be used as for example:
wr.catalog.create_database('foo_db', description='This is the foo db', exist_ok=True)

wr.catalog.create_database('bar_db', exist_ok=True)

Additionally, if exist_ok=True but description is different from its preexisting value, its value must preferably still be updated.

If you want, you can give the new exist_ok parameter a try 😉:
pip uninstall awswrangler -y
pip install git+https://github.com/maxispeicher/aws-data-wrangler.git@add_exist_flag_to_catalog_create

Covered in 2.7.0 release


can't download card key backup

After I press the Connect Bolt Card button, the app doesn't download card key backup files to the download folder.
Google Pixel5a Android 13
BoltCardWallet app version 0.3.0

Thanks for the bug report this is a feature to prevent filling up the user's downloads folder.
We will change this to a dialogue:
Card Connected
tick
Do you wish to backup the card keys?
(You can do this later in the card details screen)
Yes / No


Added configuring for HTTP proxy

Brought back the setting of HTTP proxy on Windows, that was removed in ticket #444.
Extended the toggle-proxy.sh script so that it also enables/disabled HTTP proxy on macOS

@microsoft-github-policy-service agree


[Bug Report] Please update documentation   template code for Laravel 5.8

Element UI version
2.12.0
OS/Browsers version
Linux Debian 10 (Buster) / Firefox 60.8.0esr (64 bit)
Vue version
2.6.10
Reproduction Link
https://jsfiddle.net/null
Steps to reproduce

Created new basic Laravel project

Added all necessary node packages:
npm install
npm i element-ui -S

Start the monitor:
npm run watch

Added code to resources/js/app.js:
import Vue from 'vue';
import ElementUI from 'element-ui';
import 'element-ui/lib/theme-chalk/index.css';
Vue.use(ElementUI);

Added sample component in same file:
Vue.component('el-switch', require('./components/el-switch.vue').default);

Added resources/js/components/el-switch.vue with the following same code:

Added script tag to end of body in view: resources/views/welcome.blade.php:

Above there add the following code:

Extra info:
node version: 10.5.2
npm version: 6.0.1
What is Expected?
displaying an element on the page
What is actually happening?
nothing is displayed
Notes:
Your documentation is not clear about the steps.
Your Laravel template at https://github.com/ElementUI/element-in-laravel-starter is for 5.7
I would like to have better instructions in the documentation for Laravel. Note that everything on the internet (youtube / google search) goes up to 5.7 and nothing newer. In a few days Laravel 6 will come out which makes the current template more obsolete.

It seems to be my fault. Sorry to have bothered you since I thought this was indeed an issue with element UI. It seems this was an issue with my code.


Write packager scripts to start storybook

Write scripts to package the app and push it to the simulator/device similar to the react-native run-ios command.

At the moment, users should replace their index.ios.js file with the one we use for the storybook as done here which is unacceptable to say the least. This can be fixed by writing scripts to package the storybook.

Setup guides are available which explains how to do this


Document different unit of measurements for sensor data on iOS and Android

The unit of measurement for the acceleration sensors are different on iOS and Android.
Android (m/s²): https://developer.android.com/guide/topics/sensors/sensors_motion
iOS (g):  https://developer.apple.com/documentation/coremotion/getting_raw_accelerometer_events

In the long run, shouldn't we perform the conversion ourselves so that games can behave the same way on both platforms?

Yes, for 4.0 that is actually better. I would probably convert the iOS values to m/s².
I can make a seperate PR for that against master and change the base branch of this one to 3.x if that's alright?

I can make a seperate PR for that against master and change the base branch of this one to 3.x if that's alright?

Sounds good, or we can also merge this documentation improvement in master and cherry-pick it, and have a follow-up PR to do appropriate conversions.

I can make a seperate PR for that against master and change the base branch of this one to 3.x if that's alright?

Sounds good, or we can also merge this documentation improvement in master and cherry-pick it, and have a follow-up PR to do appropriate conversions (and change the docs back, though keeping a note about what unit is used).

Ok, let's do that. I just pushed a new version with the changes.

Thanks!

Cherry-picked for 3.3.


Ethers v6 + various refactorings

In summary, as there are quite a few changes:

upgrade to Ethers v6
split typechain generated types into an ESM package (contracts) and the underlying contracts + hardhat build stuff into the hardhat package
removed functions, there's no API or workers now
tested with sapphire-paratime master (1.3.x)
added Makefiles
made UI more robust
updated dependencies

Lets wait for the https://github.com/oasisprotocol/sapphire-paratime/pull/261 to be merged, so that the dependency can be updated as well. And afterwards I will look into the PR changes, I missed the previous PR refactoring merge.

Lets wait for the oasisprotocol/sapphire-paratime#261 to be merged, so that the dependency can be updated as well. And afterwards I will look into the PR changes, I missed the previous PR refactoring merge.

I have published the two packages and updated the dependencies.


add custom restangular collection methods to object returned by service()

It could be interesting to add the custom restangular collection methods to the object returned by the Restangular.service() method.
Here is an example:
angular.module('services')
  .factory('WorkerService', [
    'Restangular',
    function(Restangular) {
      return Restangular.withConfig(function(RestangularConfigurer) {
        RestangularConfigurer.addElementTransformer('worker', true, function(worker) {
          worker.addRestangularMethod('doSomething', 'get', 'do-something');
          return worker;
        });
      }).service('worker');
    }
  ]);

By default, the object returned by Restangular.service() only contains the following methods: one, post, getList.
The new proposed behavior would be to return an object with the same methods plus the method doSomething that mapped to the one being configurered using the addRestangularMethod.
// In your controller you inject Users
Worker.one(2).get() // GET to /users/1
Worker.post({data}) // POST to /users

// GET to /users
Worker.getList().then(function(worker) {
  worker.name = "Gonto";
  // PUT to /users/1
  worker.put();
})
// Use the custom method
Worker.doSomething() // GET to /worker/do-something

Apparently this now has been fixed by https://github.com/FabienDehopre/restangular/commit/204dab5fc44617bb92fa1e1829ae4bceb0fe0b2d this PR (please see test suite).
var Accounts = Restangular.withConfig(function(RestangularConfigurer) {
+        RestangularConfigurer.addElementTransformer('accounts', true, function(worker) {
+          worker.addRestangularMethod('doSomething', 'get', 'do-something');
+          return worker;
+        });
+      }).service('accounts');
+      Accounts.doSomething();


Fix CI failures after removing ZTEST_NEW_API

Some PR's were not updated after #63723

Duplicate: #64420


Convey env vars between k8s containers

Description
Pass environment vars through the k8s socket
Context
https://linear.app/buildkite/issue/PS-72/make-buildkite-agent-id-available-within-k8s-stack-containers
Changes

In kubernetes/kubernetes.go: Replace AccessToken string with Env []string
In agent/job_runner.go: Provide processEnv to the Kubernetes socket server
In clicommand/bootstrap.go: Connect the socket as the very first thing it does, to get env vars in time for configuring the executor
Some cleanup

Testing

[x] Tests have run locally (with go test ./...). Buildkite employees may check this if the pipeline has run automatically.
[x] Code is formatted (with go fmt ./...)

I did some testing after merge (it was slightly easier to grab an edge build from Docker Hub last night) and I discovered that despite setting env vars as the first thing inside the bootstrap command, it's still not early enough. urfave/cli uses the EnvVar field on each flag as the flag default, so the env vars would need to be set even earlier in the process (before urfave/cli processes the flag definitions).


Prepare for v2.0 release

EasyVerein has announced a new API version 2.0, which apparently should come with some changes to the authentication. This issue serves as a placeholder to track needed changed for 2.0 compatibility. For now, 2.0 documentation is not available yet, I'll add details once available.

The documentation is now available. Apparently the tokens are valid for only 30 days, and need to be periodically renewed. As this library doesn't deal with storing / retrieving the token, I'm currently thinking to simply add the necessary endpoints to refresh the token. Also, we should probably emit a warning level log message if the token needs to be refreshed.
Another option would be to accept a callback function that the library automatically calls with a new token once a refresh is needed.
Any preferences from the community?

Released as part of the v1.0.0 release.


Admin order creation

Issue Reference
Admin order creation

@jitendra-webkul Sir,

From Admin end when we create a order and the we add a new address and clicking on save address, we are getting console errors and also the dialoge box is not responding properly. Please check the video and screenshot below.

Screenshot

Video
https://github.com/bagisto/bagisto/assets/92721837/64efa5bf-b443-4bcb-bf91-bf9349db13f3

UI issue in applying Cart Rule with small Character Value.

https://scrsht.com/0469e8df -> It should be on left side.
https://scrsht.com/45ce21dd -> For large Coupon code it is working fine.


Command to select from a set of options does not work

I'm replicating the tutorial (https://github.com/microsoft/guidance/blob/main/notebooks/tutorial.ipynb) commands in colab.
When I try the code:
# the {{#select}} command allows you to use the LLM to select from a set of options
program = guidance('''Is the following sentence offensive? Please answer with a single word, either "Yes", "No", or "Maybe".
Sentence: {{example}}
Answer:{{#select "answer" logprobs='logprobs'}} Yes{{or}} No{{or}} Maybe{{/select}}''')
executed_program = program(example='I hate tacos')
I obtain multiple answers instead of only one:
Is the following sentence offensive? Please answer with a single word, either "Yes", "No", or "Maybe".
Sentence: I hate tacos
Answer: Yes No Maybe Maybe
Am I doing something wrong?

Seems to be related to : https://github.com/microsoft/guidance/issues/248#issuecomment-1616158391 .
I think there is a bug. It may be only program.textand the real value of answer might be ok. It was the case for me but apparently not fully right in the issue's comment.
Currently, I am using the other syntax that seems to work better.
Answer:{{select "answer" logprobs='logprobs' valud}} options=["Yes", "No", "Maybe"]}}

Hopefully this is fixed in the new release, where we fixed a lot of select bugs. Sorry it took us so long to get to it!


Handle UNKNOWN_TOPIC_OR_PARTITION as a temporary exception instead of permanent.

Turns out Kafka throws this exception when leadership changes, and this does not necessarily mean
that the topic is not present.
Handle this one as a temporary exception so that we can minimize consumption gaps.

Current coverage is 66.46% (diff: 100%)

Merging #985 into master will decrease coverage by 0.09%

@@             master       #985   diff @@
==========================================
  Files           739        739
  Lines         35034      35034
  Methods           0          0
  Messages          0          0
  Branches       5230       5230
==========================================
- Hits          23320      23286    -34
- Misses        10185      10225    +40
+ Partials       1529       1523     -6

Powered by Codecov. Last update 41ea24b...e55b438


transaction update needed in 0.5.0

in lotus 0.5.0
gasPrice is removed
gasCap,gasPremium is added
please update this project!

yes, this is high priority to us. We are currently working on this.

yes, this is high priority to us. We are currently working on this.

thanks,
when will  new version realeased?? i`m look forward


Update image ghcr.io/zoriya/kyoo_transcoder to 389d5a7

This PR contains the following updates:

Package
Update
Change

ghcr.io/zoriya/kyoo_transcoder
digest
fcb16a5 -> 389d5a7

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

Edited/Blocked Notification
Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.
You can manually request rebase by checking the rebase/retry box above.
⚠ Warning: custom changes will be lost.


Deploy.ps1 : ../Publish/CustomerSite.zip is not a valid local file path or you do not have permissions to access it

Describe the bug
Thanks for the amazing tool !
We are trying to deploy latest infrastructure using provided instructions but received an error :
Deploy.ps1 : ../Publish/CustomerSite.zip is not a valid local file path or you do not have permissions to access it.
To Reproduce
Steps to reproduce the behavior:
Open cloud shell on azure and run
dotnet tool install --global dotnet-ef; `
git clone https://github.com/Azure/Commercial-Marketplace-SaaS-Accelerator.git -b 6.1.2 --depth 1; `
cd ./Commercial-Marketplace-SaaS-Accelerator/deployment; `
Connect-AzureAD -Confirm; `
.\Deploy.ps1 `
-WebAppNamePrefix "my-app-dev" `
-SQLServerName "my-app-dev" `
-SQLAdminLogin "adminlogin" `
-SQLAdminLoginPassword "mypassword" `
-PublisherAdminUsers<EMAIL_ADDRESS>`
-ResourceGroupForDeployment "myresourcegroup" `
-TenantID "myguid" `
-AzureSubscriptionID "myguid" `
-Location "North Central US"
Expected behavior
Successful execution without errors
Screenshots
step : Deploy Code to Customer Portal
returns:

portal looks like:

Environment (please complete the following information):

Are you using the CloudShell?
-> Yes

Hello @berezovskyy-andriy ,
Any update on the issue? how to fix it?
I am facing same issue.

@adityosnrost Please try to install with the latest installation instructions from here https://github.com/Azure/Commercial-Marketplace-SaaS-Accelerator/blob/main/docs/Installation-Instructions.md and please let me know if you still have any issues.

Yes, I am using that docs and still showing this:

Let me try to use update command.


CSV node msg.columns bug

What are the steps to reproduce?
node.template is not getting cleaned if you pass in msg.columns with different values
I am reading files with json object that I want to use CSV node to convert to string - this file can be changed to have different columns values and is then parsed by same CSV node
I have a function node before the csv node that assigns msg.columns from the payload dynamically
pass in say 8 columns for example msg.columns = "col1,col2,col3,col4,col5,col6,col7,col8"
and then pass in another file with 10 columns msg.columns = "col1,col2,col3,col4,col5,col6,col7,col8,col9,col10"
when the node is run the second time (without re-deploying - note deploying resets this) - then it keeps the first node.template value and keeps overriding msg.columns and parses the payload incorrectly.
This is the line that I believe has the bug:
if ((node.template.length === 1) && (node.template[0] === '') && (msg.hasOwnProperty("columns"))) {
This is what I think it should be - to allow that the node.tempalte value gets reset if there is a msg.columns
if ((node.template.length === 1) && (node.template[0] === '') || (msg.hasOwnProperty("columns"))) {
What happens?
when the node is run the second time (without re-deploying - note deploying resets this) - then it keeps the first node.template value and keeps overriding msg.columns and parses the payload incorrectly.
What do you expect to happen?
It should not override the msg.columns and get the payload converted incorrectly
Please tell us about your environment:

[ ] Node-RED version: 1.2.7
[ ] Node.js version: v13.9.0
[ ] npm version: 6.13.7
[ ] Platform/OS: Windows
[ ] Browser: Chrome

or perhaps this is needed
ou = ou.slice(0, -1) + node.ret;
}
else {
if (msg.hasOwnProperty("columns")) {
node.template = clean((msg.columns || "").split(","));
}

If you were writing this to a file and suddenly changed columns half way through this would be bad....

Perhaps my description is not clear - but I am not writing it to a file, easiest or quickest way to replicate it is to read a file, because I can change the file to have different columns which is when this issue happens (without changing inside node-red and deploying again). But the reading or writing files has nothing to do with the issue really - so not sure why you are commenting on that

because that was the use case envisioned when it was created. If you are creating a CSV you would expect the columns to remain constant. I can see your use case is different, so this is a new feature rather than an issue per se.

Okay, I hear you on writing to file and how you planned it initially, but CSV is a parser node that parses object data to string, for which I think you should be able to pass it msg.columns the way you would want. Thanks

I hear you.

OK - need some more clarity... - You are reading a file... within that file surely the fields that you need to map to columns remain the same ? so once defined they are constant for that file ? If so then the issue is that the template isn't being reset at the end of that file ? If so how are you reading in the file ? Is it using a file in node set to read one line at a time ?
Or are you actually wanting to change the columns on a per row basis ?

The input is an array of objects that I need to be parsed as a multi line CSV string. This input can have different object properties and will always have 2 or more objects in the array, and the properties for each (columns for csv string) can or will differ.
Example:

[{"col1":"header1","col2":"header2"},{"col1":"line1"}]
desired output:
header1,header2
line1
(line1, is also fine)
[{"col1":"header1"},{"col1":"line1","col2":"line2"}]
header1
line1,line2
(header1, is also fine)
when example 2 runs without msg.columns it cuts of line2 and gives
header1
line1
To overcome this I pass msg.columns="col1,col2" then example 1 and 2 will work fine

However when after this there is another value passed in as
3)[{"col1":"header1","col2":"header2","col3":"header3"},{"col1":"line1","col2":"line2"}]
it outputs as
header1,header2
line1,line2
even if I pass msg.columns as "col1,col2,col3" - because within the node it changes msg.columns back to "col1,col2"
(note - this 3 examples happen without redeploy of node-red as re-deploying changes this behavior - and resets the msg.columns value that is being changed back)

OK - so I'm working on a fix... can you confirm the expected outputs fro your examples ? This is without  setting any msg.columns of course... (and sending column headers (which can be turned off)
1
col1,col2
header1,header2
line1,

2
col1
header1
line1

3
col1,col2,col3
header1,header2,header3
line1,line2,

example 2 should be
col1,col2
header1,
line1,line2
need it to not cut off any data
the other examples would work fine

I think I'm going to push back on that... again if you don't set the headers up front - how does it know where to add an extra column - if say you had example like
[
    {
        "col1": "header1",
        "col2": "header2",
        "col3": "header3",
        "col4": "header4"
    },
    {
        "col1": "itemA",
        "col2": "itemB"
    },
    {
        "col1": "itemA",
        "col3": "itemC"
    },
    {
        "col1": "itemA",
        "col4": "itemD"
    }
]

you would get correct csv like
col1,col2,col3,col4
header1,header2,header3,header4
itemA,itemB,,
itemA,,itemC,
itemA,,,itemD

If you reset it on every line you would get
col1,col2,col3,col4
header1,header2,header3,header4
itemA,itemB
itemA,itemC
itemA,itemD

which would be plain wrong

I think I'm going to push back on that... again if you don't set the headers up front - how does it know where to add an extra column

I do want to set the headers in msg.column - but this cannot then be changed when node is called again? it keeps this, even if you pass something new it does not change
[
    {
        "col1": "header1",
        "col2": "header2",
        "col3": "header3",
        "col4": "header4"
    },
    {
        "col1": "itemA",
        "col2": "itemB"
    },
    {
        "col1": "itemA",
        "col3": "itemC"
    },
    {
        "col1": "itemA",
        "col4": "itemD"
    }
]

I would not have an example like this really if there is only 2 items it would be col1 and col2 and not for example col4 - then there would need to be 4 properties
This is in the context of sending in an array - of course if sent as single lines then there is no context of what came before so it would break as you want :-)

But this sounds like then I might as well parse everything in a function node

yes the fix resets for every new array or file. and honours msg.columns, so you can now call multiple times in any order.

Great, thanks!


⚠ Bofrost.de has degraded performance

In d38a4ce, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1312 ms

Resolved: Bofrost.de performance has improved in 47f0e58 after 6 minutes.


fix(ENG-1030): IESO Adequacy Forecast Report fixes

Summary
There is some funky behavior going on with the current IESO Adequacy Report. This cleans the report up a bit further and fixes the current column issue, as well as some other improvements.
Details
The report structure map has seen some improvements and generalizations to make it clearer and more standardized. More could be done here, but it continues to be more legible and generalized. As we do more XML report parsing I could see this developing into a repeatable, robust design pattern for parsing these reports.
Dataframe shape debugging code now at the end of the process to accurately reflect df shape. Sorting now includes Last Modified it has been moved to the front of the df with the other timestamp columns.
There is no Estimated section for Total Exports (like there is for Total Imports) so this removed from the structure map. While not technically a breaking issue, it would throw up a warning each time it was run:

Looks good.
I did notice while testing, that although the type annotation says last_modified can be str | datetime.date | datetime.datetime, if you pass a str or a datetime.date, you get an error like: 'datetime.date' object has no attribute 'tz'.

Good find. I added a handle_date


How to customize error handling?

This is our doc write
"
Customizing the Error Handling
Error handling in an Authorization Server uses standard Spring MVC features, namely @ExceptionHandler methods in the endpoints themselves. Users can also provide a WebResponseExceptionTranslator to the endpoints themselves which is the best way to change the content of the responses as opposed to the way they are rendered. The rendering of exceptions delegates to HttpMesssageConverters (which can be added to the MVC configuration) in the case of token endpoint and to the OAuth error view (/oauth/error) in the case of teh authorization endpoint. A whitelabel error endpoint is provided, but users probably need to provide a custom implementation (e.g. just add a @Controller with @RequestMapping("/oauth/error")).
"
I have  try create a WebResponseExceptionTranslator by spring  for TokenEndpoints, but I failed.
The TokenEndPoints is dynamic create, There is no attribute for authorization-server to set this.
So How to custom the  WebResponseExceptionTranslator .

To use a custom WebResponseExceptionTranslator you would have to create the endpoints yourself as @Bean definitions (i.e. not use the @Enable* annotations).

Hi, is there some convenient way to set WebResponseExceptionTranslator for endpoints in xml configuration, and I find it in java configuration.
Did you completely abandon xml configuration support at some point in this project?
Thank you very much for your reply.

what is the way to configure in java configuration? I am also looking in xml .. any way just curious how to set in java config?

Is there some convenient way to set WebResponseExceptionTranslator for endpoints in xml configuration????


metadata: citation file is not being parsed

CITATION.cff is not properly parsed when a release contains the file.
Additionally, the configuration variable is not set by default on invenio-github. We should add it.

Closing, aleady implemented in https://github.com/zenodo/zenodo-rdm/pull/612


Move eslint to peer dependencies.

eslint plugins can define eslint as a peer dependency so that npm can ensure that they are compatible with the installed version of eslint (and warn if they are not). Nesting eslint under gulp-eslint prevents npm checking peer dependency versions - instead another copy of eslint is installed that may be a different version. The end result is that plugins could be run with an incompatible version of eslint and cause errors.
Changing eslint to a peer dependency means that the plugins and gulp-eslint will use the same copy of eslint, so any incompatibilities will be flagged by npm before they can lead to errors.
Fixes #68

https://github.com/adametry/gulp-eslint/issues/68#issuecomment-111742001


Misleading error message when using incorrect types for UDFs

When giving an UDF an unexpected/unsupported input type, the error msg is misleading. For example
import torcharrow as ta
from torcharrow import functional as F_eager

df = ta.dataframe(
    {
        "a": [x for x in range(5)],
        "b": [100 * x for x in range(5)],
        "label": [np.float32(x + 0.5) for x in range(5)],
        "label_str": [str(np.float32(x + 0.5)) for x in range(5)],
    }

)

print(F_eager.torcharrow_round(df["label"]))
print(F_eager.torcharrow_round(df["label_str"]))

The first one prints without any issue,
the second shows a
Request for unknown Velox UDF: torcharrow_round

since it doesn't expect a Column(str)
However, my first impression was to think that this method doesn't exist. Would be great if we could return something along the lines of "torcharrow_round exists, but only accepts int/floats/etc"

To start with, even put the type get called would be useful (e.g. cannot find "torcharrow_round" with input type VARCHAR) would be helpful ~

Actually, looks like we can do something similar to https://github.com/facebookincubator/velox/blob/041f3759d6e4c070c2ecd2e01eae6a7be9d93957/velox/parse/TypeResolver.cpp#L112-L124

resolved via https://github.com/pytorch/torcharrow/pull/400


Do not meddle with the PyQt namespace

i.e. remove this:
https://github.com/harvimt/quamash/blob/master/quamash/__init__.py#L52

Well, the hack is still there. Is it absolutely necessary?

No. It's been fixed in another branch for a while.
Also it's like the least ugly hack in quamash.
On Mon, Dec 14, 2015 at 4:17 PM, Sébastien Bourdeauducq <
<EMAIL_ADDRESS>wrote:

Well, the hack is still there. Is it absolutely necessary?
—
Reply to this email directly or view it on GitHub
https://github.com/harvimt/quamash/issues/57#issuecomment-164601609.

Can you please point to the branch you are referring to?

depinject5realz I think. It's in a PR, and it needs to be rebased off
master.
On Mon, Dec 14, 2015 at 5:54 PM, Sébastien Bourdeauducq <
<EMAIL_ADDRESS>wrote:

Can you please point to the branch you are referring to?
—
Reply to this email directly or view it on GitHub
https://github.com/harvimt/quamash/issues/57#issuecomment-164617817.


New licenses

Codecov Report

Merging #34 into master will increase coverage by 0.4%.
The diff coverage is 94.23%.

@@            Coverage Diff            @@
##           master      #34     +/-   ##
=========================================
+ Coverage   90.48%   90.88%   +0.4%
=========================================
  Files          22       23      +1
  Lines         704      735     +31
=========================================
+ Hits          637      668     +31
  Misses         67       67

Impacted Files
Coverage Δ

...danan/bazel/mvn/merger/DependencyNamePrefixer.java
94.73% <ø> (ø)
:arrow_up:

...n/java/net/evendanan/bazel/mvn/api/Dependency.java
91.17% <ø> (+1.81%)
:arrow_up:

...endanan/bazel/mvn/serialization/Serialization.java
100% <100%> (ø)
:arrow_up:

.../net/evendanan/bazel/mvn/impl/TargetsBuilders.java
98.3% <100%> (ø)
:arrow_up:

...et/evendanan/bazel/mvn/serialization/Adapters.java
90.19% <80%> (ø)
:arrow_up:

...main/java/net/evendanan/bazel/mvn/api/License.java
95.45% <95.45%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb42c80...6e4d633. Read the comment docs.


pipewire: enable strictDeps

glib for gdbus-codegen
tested cross and native
for native used diffoscope to check the outputs
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

I built this on my system and cross-compilation now works again for pipewire. x86 also still works. Didn't check any deps, but will build and run the nixosTests linked in the passthru.tests (that'll take a bit).


[DO NOT MERGE] Updated targetSdkVersion and compileSdkVersion

The Google Play Store's guidelines dictate that, as of August 31st, 2023, new apps should target Android API level 33+, and existing apps should target Android API level 31+. August 31st became the de-facto date where API levels shall be updated for subsequent years as new API levels of Android are released.
I have updated our targetSdkVersion and compileSdkVersion to use the latest API level instead (34, released in October, 2023), as this will be required by the Google Play Store come next August.It also allows our users to test out the latest Android features in their apps by not locking them to an earlier level like 31 or 33.

Will merge after I update our sample app.

LGTM