A few more improvements to the README.md

I've already created a draft before (https://github.com/justafish/ddev-drupal-core-dev/pull/9) but thanks to my "excellent" git and github skills something went wrong when i tried to sync my branch with the latest changes when randys PR went in. I've simply created a new PR now, that was faster incorporating my suggested changes i've done locally so far.
and again at first thank you for creating that excellent add-on! and as a disclaimer i am not a developer just a regular ddev user who was just used to a composer patches based workflow for testing issues on drupal.org. when i first tried the add-on i ran into a few stepping blocks since it is following a slightly different paradigm (i've expecting the folder structure with web as the docroot and i've installed drush wondering why i haven't had a git status without any changes). one or two weeks ago i've also noticed a support request on the drupal slack by someone trying to get the add-on work (who had basically the same issues like me). so based on my own experience as well as the details i've learned during the conversation on slack i've tried to come up with a few improvements to the README.md:

added a TOC and structured the entire document with headlines
untwine the long codeblock at the beginning and move the different parts into the appropriate sections
tried to make it clear nothing should be installed (required) with composer like for example drush (therefore the warning box to make it extra clear)
added the omit the database container flag since the addon is using SQLite (to save a few megabyte but at the same time to help the user to understand how the add is working and what database is used - which is also relevant in case someone wants to drop the database tables in case one is working on a patch in the context of the drupal installer).

plus i've added the suggestions @rfay made over on the old PR into this one

Looks like #17 was merged in, you may want to rebase this so we don't double up on changes. In particular, @rfay's line about running DDEV with preset flags for overrides, php version etc.

thank you, i've rebased my branch against upstream/main now. i was under the impression since the github ui showed that the branch has no conflicts with the base branch it wouldn't be necessary. but definitely the better and cleaner choice.

Given my #16 was getting messy, I'm happy to work on this one instead as we're working towards the same goal.

i think we shouldnt expand the scope and pack more things into this PR. I would keep this PR about simply restructuring the README to improve hopefully readability and clarity. The PR you have started is more about functionality and that the quickstart guide runs through without any stumbling blocks.
And in regards of the continuing problems  #16  and also #20 @simesy tried to fix alongside the changes in the upcoming version 1.23.0 of DDEV https://github.com/ddev/ddev/releases/tag/v1.23.0-alpha1 @rfay suggested in a conversation on slack to do the following:
I think that the 3-4 contributors trying to sort things out in the justafish repo should just sit down and collaborate. Slack channel for that might not be a bad idea. Competing PRs are just going to waste justafish’s time and energy```

that was the reason behind simes posting: https://github.com/justafish/ddev-drupal-core-dev/issues/22

so you are welcome to join the discussion on the newly created channel.

Sounds like a smart approach, I agree with trying to keep functionality vs readability separate but note this can be messy when we are working on the same files via separate PRs.
What's the Slack channel called?

See

https://github.com/justafish/ddev-drupal-core-dev/issues/22

@T-Fletcher


[MultiForce] - Login URL Redirects user to the Lightning Pages setup page vs setup or home

Extension
https://www.raycast.com/brian_j_decoder22/multi-force
Raycast Version
1.80
macOS Version
14.5
Description
Login URL Redirects user to the Lightning Pages setup page vs setup or home
Steps To Reproduce

Click a Login
Salesforce opens into the Lightning App Builder Tab

Current Behaviour
No response
Expected Behaviour
Opens Setup home or Home

@raycastbot assign me

@raycastbot good first issue

@raycastbot keep this issue open

@raycastbot close this issue Closes the issue.
A fix for this issue was accepted into the Raycast store.

@raycastbot close this issue


Feature Button on Existing Exports Not Working

The 'Feature' button at the bottom left corner of the Export job page doesn't seem to be working. The 'Re-Run', 'Clone' and 'Delete' buttons are working, but the 'Feature' button doesn't bring up the YAML syntax used for the job, like it should do.

This seems to have been fixed in 97a3ad1. If it's still problematic, can you share the export URL that's problematic?

It seems to be the case on all of the exports. Just go to the Export page and select any job to test:
https://export.hotosm.org/en/v3/exports/6d3f88aa-1c78-494d-927d-c64ab09fb2b4
https://export.hotosm.org/en/v3/exports/7e6878c0-58e8-4eac-876b-ccf33eaa8a05

I discovered I was using a cached copy; after closing it, I managed to reproduce it and fixed it in 48168cb, which @bdon is deploying soon.


Don't add newlines after code snippets in headers

Fixes the very odd behavior on https://docs.rs/crate/winapi/0.3.8
Closes https://github.com/rust-lang/docs.rs/issues/645
r? @GuillaumeGomez

Couldn't find issues so once I have an answer to my question, all good for me!

Thanks!


Radios have high cpu usage

If you have a bunch of radios (one way) with the max amount of inputs, and wire it to a button (any value, tried with<PHONE_NUMBER>02880) and start spamming it, the server will start to slow down.
A person came onto the server that I was playing on, and we've experience some server crashes. Looking at logs we saw this:
LUA | 0 lua/entities/gmod_wire_radio.lua:122: ShowOutput | 1 lua/wire/server/radiolib.lua:49: Radio_SendData | 2 lua/entities/gmod_wire_radio.lua:81: ? | 3 [C]:-1: xpcall | 4 lua/wire/server/wirelib.lua:58: TriggerInput | 5 lua/wire/server/wirelib.lua:530: Wire_TriggerOutput END:maxdepth STACK:29: <UserData>, '(Channel 0) Transmit 1:9.8596108894622e+30 2:9.8596108894622e+30 3:9.8596108894622e+30 4:9.8596108894622e+30 5:9.8596108894622e+30 6:9.8596108894622e+30 7:9.8596108894622e+30 8:9.8596108894622e+30 9:9.8596108894622e+30 10:9.8596108894622e+30 11:9.8596108894622e+30 12:9.8596108894622e+30 13:9.8596108894622e+30 14:9.8596108894622e+30 15:9.8596108894622e+30 16:9.8596108894622e+30 17:9.8596108894622e+30 18:9.8596108894622e+30 19:9.8596108894622e+30 20:9.8596108894622e+30 21:9.8596108894622e+30 22:9.8596108894622e+30 23:9.8596108894622e+30 24:9.8596108894622e+30 25:9.8596108894622e+30 26:9.8596108894622e+30 27:9.8596108894622e+30 28:9.8596108894622e+30 29:9.8596108894622e+30 30:9.8596108894622e+30 31:9.8596108894622e+30 32:9.8596108894622e+30 Receive 1:9.5708088510014e+30 2:9.5708088510014e+30 3:9.5708088510014e+30 4:9.5708088510014e+30 5:9.5708088510014e+30 6:9.5708088510014e+30 7:9.5708088510014e+30 8:9.5708088510014e+30 9:9.5708088510014e+30 10:9.5708088510014e+30 11:9.5708088510014e+30 12:9.5708088510014e+30 13:9.5708088510014e+30 14:9.5708088510014e+30 15:9.5708088510014e+30 16:9.5708088510014e+30', LN17, LN32, LN1, LN17, '(Channel 0) Transmit 1:9.8596108894622e+30 2:9.8596108894622e+30 3:9.8596108894622e+30 4:9.8596108894622e+30 5:9.8596108894622e+30 6:9.8596108894622e+30 7:9.8596108894622e+30 8:9.8596108894622e+30 9:9.8596108894622e+30 10:9.8596108894622e+30 11:9.8596108894622e+30 12:9.8596108894622e+30 13:9.8596108894622e+30 14:9.8596108894622e+30 15:9.8596108894622e+30 16:9.8596108894622e+30 17:9.8596108894622e+30 18:9.8596108894622e+30 19:9.8596108894622e+30 20:9.8596108894622e+30 21:9.8596108894622e+30 22:9.8596108894622e+30 23:9.8596108894622e+30 24:9.8596108894622e+30 25:9.8596108894622e+30 26:9.8596108894622e+30 27:9.8596108894622e+30 28:9.8596108894622e+30 29:9.8596108894622e+30 30:9.8596108894622e+30 31:9.8596108894622e+30 32:9.8596108894622e+30
9.8596108894622e+30 mustve been the value they selected to use. Maybe clamp it to 2^31-1 or limit amount of radios people can spawn? This is also the contraption they used:

I solved it on my server by just lower sbox_maxradios or whatever it is. Basically it's just TriggerInput spam.

Why would any amount of trigger input spam cause the server to lag, unless it's wired into an infinite loop? I checked the code and while the radio is one of the oldest untouched pieces of code in all of wire, it doesn't seem to be that bad

Inputs can be triggered about 10 times per frame and with 100 inputs connected sequentially (so it builds a big stack) it adds up I guess. That code needs refactoring though, for sure.

I never understood the point of radio. It's not like wires have a range limit. Maybe it could just act as a proxy between two entities instead of the overcomplicated mess it is.

recon. needs refactoring.

Looks like the problem is they can have 32 inputs/ouputs running through an inefficient radio library ~7 times per radio per frame.

I really don't see any point in these entities, but the best solution is to limit them imo.

Here's a new library. Should be lightning fast. Just requires a few changes to the entity. (reminder: ent.Channel needs to be changed to a string)
local Channel = {
	__index = {
		register = function(self, ent)
			table.insert(self.subscribers, ent)
			ent.ChannelData = self
			ent:NotifyReceivedData()
		end,
		unregister = function(self, ent)
			table.removeByValue(self.subscribers, ent)
		end,
		isEmpty = function(self)
			return #subscribers == 0
		end,
		send = function(self, ent, subch, x)
			self.data[subch] = x
			for k, v in ipairs(self.subscribers) do
				v:NotifyReceivedData(subch)
			end
		end
	},
	__call = function(meta)
		return setmetatable({
			data = {0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0},
			subscribers = {}
		}, meta)
	end
}
setmetatable(Channel, Channel)

local Channels = setmetatable({},{__index = function(t,k) local r=Channel() t[k]=r return r end})
local Secure_Channels = setmetatable({},{__index = function(t,k) local r=setmetatable({},{__index = function(t,k) local r=Channel() t[k]=r return r end}) t[k]=r return r end})

function Radio_Register(ent)
	Channels[ent.Channel]:register(ent)
end

function Radio_RegisterSecure(ent)
	Secure_Channels[ent.Steamid][ent.Channel]:register(ent)
end

function Radio_Unregister(ent)
	local chan = Channels[ent.Channel]
	chan:unregister(ent)
	if chan:isEmpty() then
		Channels[ent.Channel] = nil
	end
end

function Radio_UnregisterSecure(ent)
	local chan = Secure_Channels[ent.Steamid][ent.Channel]
	chan:unregister(ent)
	if chan:isEmpty() then
		Secure_Channels[ent.Steamid][ent.Channel] = nil
		if next(Secure_Channels[ent.Steamid])==nil then
			Secure_Channels[ent.Steamid] = nil
		end
	end
end

function Radio_SendData(ent, subch, data)
	Channels[ent.Channel]:send(ent, subch, data)
end

function Radio_SendDataSecure(ent, subch, data)
	Secure_Channels[ent.Steamid][ent.Channel]:send(ent, subch, data)
end

function Radio_ChangeChannel(ent)
	Radio_Unregister(ent)
	Radio_Register(ent)
end

function Radio_ChangeChannelSecure(ent)
	Radio_UnregisterSecure(ent)
	Radio_RegisterSecure(ent)
end

local radio_twowaycounter = 0
function Radio_GetTwoWayID()
	radio_twowaycounter = radio_twowaycounter + 1
	return radio_twowaycounter
end

Just realized the ChangeChannel function won't work, but that can be fixed while integrating.


jest-react-native is out of sync with react-native?

    `ScrollView` has no propType for native prop `RCTScrollView.onScrollBeginDrag` of native type `BOOL`
    If you haven't changed this prop yourself, this usually means that your versions of the native code and JavaScript code are out of sync. Updating both should make this error go away.

      at verifyPropTypes (node_modules/react-native/Libraries/ReactNative/verifyPropTypes.js:58:7)
      at requireNativeComponent (node_modules/react-native/Libraries/ReactNative/requireNativeComponent.js:94:21)
      at Object.<anonymous> (node_modules/react-native/Libraries/Components/ScrollView/ScrollView.js:576:19)
      at Object.<anonymous> (node_modules/react-native/Libraries/Animated/src/Animated.js:19:16)

Happened at updating jest from v15 to v17 and react-native from 0.33 to 0.38

@cpojer may be it's worth looking on this issue. May be it can be just closed :)
For resolving, I've simple changed jest preset from jest-react-native  to react-native


add systemic test

Closes #22
API/Interface Changes:
The changes will likely not impact user code in typical usage, but this PR will bump the major version just in case.

Positional arguments are required, keyword args all now have defaults.

All date-related arguments are now required to be Dates (some were previously allowed to be nothing)
Previously, the to positional argument could be nothing and the study_end kwarg was required to be specified by user.
to is now required and up to the user to determine the last date observed which is independent from the study_end (in the code and in theory).
study_end and study_start now have defaults (typemax(Date) and typemin(Date)) respectively.

All exposure types now return a three-element tuple.

Previously, Anniversary and AnniversaryCalendar would return a third element with the field name of policy_timestep. For consistency, Calendar will as well, but it will be missing

Calendar and Anniversary are now constructors for AnniversaryCalendar where the respective argument is nothing

Other
README/documentation

Outline principles for determining exposures on different basis
Note treatment of leap years

Tests

Comb through tests align expectation with documented principles
Add a simulated set of experience where the goal is to recover a ~100% A/E for simulated claims if the exposures are calculated correctly (since the same assumption will be used for the simulated claims as the expected # of claims)

Accuracy improves further when tested with 10m census records (takes ~1.5 minutes on M3 Mac to simulate and do studies on 3 bases), but limited to 1m due to CI memory/speed limits
 ExperienceAnalysis.AnniversaryCalendar{Year, Nothing}(Year(1), nothing) seems to have a very slight (<0.5%) bias towards low A/E)? It gets better with 10m records vs 1m. Is this an expected bias for what's been tested or is it an issue? TBD

@MatthewCaseres are you able to share your actexps comparison script and/or run it against this PR?
The first post describes the changes, but for more context on the moderate refactor: By combining all the logic into the AnniversaryCalendar version and simply typemax/typemin the omitted value then there's only one overall flow. It did get a bit more complicated to handle the edge cases but let me know if you look at it and anything's not clear.
As for the tests, I went through and did make some changes to tests where I felt like the prior definitions weren't consistent with the principles now defined in the README. I'd start with those principles if you want to review this, and then let me know if you disagree with any of the test target changes.
My plan is to merge and tag a new major version ~Thursday unless you raise an issue or explicitly would like some more time to review.

The comparison script is really just computing the same data set census_dat from benchmarks using both packages, and scrolling through r left join julia and julia left join R. It was a lot more involved when I was diving into specific issues to raise issues, that work isn't applicable here and I recommend doing something simple.
Simpler codebase is nice. Expecting some performance regression due to
        while first(result).to < study_start
            popfirst!(result)
        end

In situations where from << to and we are doing some monthly study being able to avoid the extra work likely reduces computation time by a significant factor.


incremement to get new pypi features working

Pypi now renders the readme correctly 💃

Hello @sauln, Thank you for submitting the Pull Request !

In the file setup.py, following are the PEP8 issues :

Line 12:53: W291 trailing whitespace
Line 20:9: E121 continuation line under-indented for hanging indent
Line 27:9: E121 continuation line under-indented for hanging indent
Line 42:6: E124 closing bracket does not match visual indentation

Do see the Hitchhiker's guide to code style

Codecov Report

Merging #76 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #76   +/-   ##
=======================================
  Coverage   82.15%   82.15%
=======================================
  Files           6        6
  Lines         409      409
  Branches       95       95
=======================================
  Hits          336      336
  Misses         51       51
  Partials       22       22

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3520c2e...a91ff45. Read the comment docs.


Improve website structure and style

This is a WIP pull request. Do not merge.
I hope these changes are not too trivial to consider. I wanted to work on adding some structure to the site, in anticipation to potentially adding more data and links to things (#21, #22, #48, #19, #26, etc.). I would welcome suggestions/issues that you have and would like me to address.
Before:

After:

(screenshots taken in Firefox 61, Ubuntu 17.10)

This looks great! Excited to see what else you're working on :).

Just curious, what are your thoughts on using a framework for this? I'm not opposed either way. So far, I have just been using vanilla CSS to put something together, which has the name benefit of everything being very lightweight (<70KB). However, a framework could be more consistent and easier for others to learn.

@camchenry this is looking really awesome :D. Would you mind rebasing your branch onto master so that the latest CI changes can run? I'd selfishly like to test the screenshotting I added and hopefully I can get the automated deployment working in time for when this is ready to merge.

Yeah I'll update the branch when I get a chance.
On Oct 14, 2018 7:47 PM, "Adam Perry"<EMAIL_ADDRESS>wrote:
@camchenry https://github.com/camchenry this is looking really awesome
:D. Would you mind rebasing your branch onto master so that the latest CI
changes can run? I'd selfishly like to test the screenshotting I added and
hopefully I can get the automated deployment working in time for when this
is ready to merge.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/anp/lolbench/pull/55#issuecomment-429673691, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABcawIVvFu5V2qW1gn8usIWDhNt_OEYuks5uk8zxgaJpZM4XaJzX
.

Been a while since I rebased, hopefully that looks okay. I suppose you can just squash this pull request later.

Thank you so much! I squashed the commits down but kept your messages. Should be live on the site in an hour or two.


Duplicated modules under optimizeDeps

Describe the bug
Hi everyone,
as this is my first issue here i'd like to thank you for this great tool ❤.
I am having an issue with vite's optimization of dependencies during development: under some (admittingly very specific, but in my opinion legitimate) circumstances, vite will instantiate a module from node_modules twice.
This in turn leads to side effects happening multiple times, confused object identities and instanceof checks failing, which can be very hard to debug. When the depsOptimizer is not present (e.g. during vite build), everything works as expected.
I'll do my best describing the issue. I have also attached a repository with as minimal of a reproduction as i could manage.
The problem
At my company, we are using a vite/rollup plugin to add some reflection capabilities to an application.
Essentially, from a single import in the application's code to a virtual module, the apps entire dependency graph may be scanned. All transitive node dependencies are visited and for certain packages code is generated, including imports to modules or objects within those packages.
The reproduction repository uses a simplified system that produces the same problem. A single import "virtual:init-all-packages"; triggers analysis of the dependency graph, visits all referenced packages (just via dependencies), and if their package.json contains a "customAutoInit": "..." declaration, that init module will be imported to trigger the initialization code within that module.
The import "virtual:init-all-packages"; is thus turned into:
import "RESOLVED_LOCATION/dep1/init1.js";
import "RESOLVED_LOCATION/dep2/init2.js";
// ...

Note that this virtual module cannot use bare imports (e.g. import "dep1/init1.js") because transitive dependencies may not be reachable from the virtual modules "location" (nested node_modules etc. should be taken into account). This is why the plugin resolves the module ids passing some importer from where the import is possible. This results in an absolute path like /@fs/.../dep1/init1.js?v=d7007810, which will then be ignored by the depsOptimizer.
The problem here arises when the unoptimized modules mentioned above use node modules that are also used by the application directly (and are thus optimized in node_modules/.vite/...). There will be two copies of any modules used in this way: raw files in node_modules and a copy bundled by esbuild in .vite, with different parts of the application observing one or the other. In the reproduction repository, the module shared/inner is duplicated.
I don't think excluding certain packages from optimization would really help here, since only a static set of packages can be configured and dependencies may add additional imports whenever they feel like it, making any such solution very hard to maintain. Also optimization is a great feature in principle and i would like to make it work correctly in this case.
Additional observations
I have dug around vite's code a bit.
All problems would be avoided if the resolve(...) call in our plugin would receive an optimized module id instead of the raw location.
The implementation of resolve even has this capability, adding a missing import and then re-triggering optimization, but that branch is skipped in these specific circumstances because the (virtual) importer is in node_modules.
However, i cannot use a location outside of node_modules because the module id in question might not be reachable from elsewhere.
I have verified locally that removing the (importer && isInNodeModules(importer)) check from the linked condition would fix the issue in this case. However that line is probably there for a good reason (?). The check was introduced by Evan in this commit, but I couldn't find any additional context.
An additional option for resolve, or an improved skip condition (although i can't think of one) or any other kind of workaround with would be greatly appreciated. However, because the optimizer can alter the observable behaviour of the app in a significant matter, I believe a fix should be internal.
Reproduction
https://github.com/mbeckem/vite-duplicated-modules-repro
Steps to reproduce
Run pnpm install followed by pnpm vite dev and then open the browser, for more details see the linked repository's README.
System Info
System:
    OS: Linux 5.15 Ubuntu 22.04.2 LTS 22.04.2 LTS (Jammy Jellyfish)
    CPU: (16) x64 AMD Ryzen 7 PRO 4750U with Radeon Graphics
    Memory: 17.12 GB / 30.59 GB
    Container: Yes
    Shell: 5.1.16 - /bin/bash
  Binaries:
    Node: 18.13.0 - ~/.nvm/versions/node/v18.13.0/bin/node
    npm: 8.19.3 - ~/.nvm/versions/node/v18.13.0/bin/npm
  Browsers:
    Chrome: 114.0.5735.133
    Firefox: 114.0.1
  npmPackages:
    vite: ^4.3.9 => 4.3.9

Used Package Manager
pnpm
Logs

Click to expand!
$ pnpm vite dev --debug
  vite:config bundled config file loaded in 50.16ms +0ms
  vite:config using resolved config: {
  vite:config   root: '/home/michael/projects/pioneer/repro-depsoptimize-duplicated-modules/src',
  vite:config   plugins: [
  vite:config     'vite:optimized-deps',
  vite:config     'vite:watch-package-data',
  vite:config     'vite:pre-alias',
  vite:config     'alias',
  vite:config     'vite:modulepreload-polyfill',
  vite:config     'vite:resolve',
  vite:config     'vite:html-inline-proxy',
  vite:config     'vite:css',
  vite:config     'vite:esbuild',
  vite:config     'vite:json',
  vite:config     'vite:wasm-helper',
  vite:config     'vite:worker',
  vite:config     'vite:asset',
  vite:config     'auto-init',
  vite:config     'vite:wasm-fallback',
  vite:config     'vite:define',
  vite:config     'vite:css-post',
  vite:config     'vite:worker-import-meta-url',
  vite:config     'vite:asset-import-meta-url',
  vite:config     'vite:dynamic-import-vars',
  vite:config     'vite:import-glob',
  vite:config     'vite:client-inject',
  vite:config     'vite:import-analysis'
  vite:config   ],
  vite:config   optimizeDeps: {
  vite:config     disabled: 'build',
  vite:config     force: undefined,
  vite:config     esbuildOptions: { preserveSymlinks: false }
  vite:config   },
  vite:config   server: {
  vite:config     preTransformRequests: true,
  vite:config     sourcemapIgnoreList: [Function: isInNodeModules],
  vite:config     middlewareMode: false,
  vite:config     fs: { strict: true, allow: [Array], deny: [Array] }
  vite:config   },
  vite:config   configFile: '/home/michael/projects/pioneer/repro-depsoptimize-duplicated-modules/vite.config.ts',
  vite:config   configFileDependencies: [
  vite:config     '/home/michael/projects/pioneer/repro-depsoptimize-duplicated-modules/vite.config.ts'
  vite:config   ],
  vite:config   inlineConfig: {
  vite:config     root: undefined,
  vite:config     base: undefined,
  vite:config     mode: undefined,
  vite:config     configFile: undefined,
  vite:config     logLevel: undefined,
  vite:config     clearScreen: undefined,
  vite:config     optimizeDeps: { force: undefined },
  vite:config     server: {}
  vite:config   },
  vite:config   base: '/',
  vite:config   rawBase: '/',
  vite:config   resolve: {
  vite:config     mainFields: [ 'module', 'jsnext:main', 'jsnext' ],
  vite:config     browserField: true,
  vite:config     conditions: [],
  vite:config     extensions: [
  vite:config       '.mjs',  '.js',
  vite:config       '.mts',  '.ts',
  vite:config       '.jsx',  '.tsx',
  vite:config       '.json'
  vite:config     ],
  vite:config     dedupe: [],
  vite:config     preserveSymlinks: false,
  vite:config     alias: [ [Object], [Object] ]
  vite:config   },
  vite:config   publicDir: '/home/michael/projects/pioneer/repro-depsoptimize-duplicated-modules/src/public',
  vite:config   cacheDir: '/home/michael/projects/pioneer/repro-depsoptimize-duplicated-modules/node_modules/.vite',
  vite:config   command: 'serve',
  vite:config   mode: 'development',
  vite:config   ssr: {
  vite:config     format: 'esm',
  vite:config     target: 'node',
  vite:config     optimizeDeps: { disabled: true, esbuildOptions: [Object] }
  vite:config   },
  vite:config   isWorker: false,
  vite:config   mainConfig: null,
  vite:config   isProduction: false,
  vite:config   esbuild: { jsxDev: true },
  vite:config   build: {
  vite:config     target: [ 'es2020', 'edge88', 'firefox78', 'chrome87', 'safari14' ],
  vite:config     cssTarget: [ 'es2020', 'edge88', 'firefox78', 'chrome87', 'safari14' ],
  vite:config     outDir: 'dist',
  vite:config     assetsDir: 'assets',
  vite:config     assetsInlineLimit: 4096,
  vite:config     cssCodeSplit: true,
  vite:config     sourcemap: false,
  vite:config     rollupOptions: {},
  vite:config     minify: 'esbuild',
  vite:config     terserOptions: {},
  vite:config     write: true,
  vite:config     emptyOutDir: null,
  vite:config     copyPublicDir: true,
  vite:config     manifest: false,
  vite:config     lib: false,
  vite:config     ssr: false,
  vite:config     ssrManifest: false,
  vite:config     ssrEmitAssets: false,
  vite:config     reportCompressedSize: true,
  vite:config     chunkSizeWarningLimit: 500,
  vite:config     watch: null,
  vite:config     commonjsOptions: { include: [Array], extensions: [Array] },
  vite:config     dynamicImportVarsOptions: { warnOnError: true, exclude: [Array] },
  vite:config     modulePreload: { polyfill: true },
  vite:config     cssMinify: true
  vite:config   },
  vite:config   preview: {
  vite:config     port: undefined,
  vite:config     strictPort: undefined,
  vite:config     host: undefined,
  vite:config     https: undefined,
  vite:config     open: undefined,
  vite:config     proxy: undefined,
  vite:config     cors: undefined,
  vite:config     headers: undefined
  vite:config   },
  vite:config   envDir: '/home/michael/projects/pioneer/repro-depsoptimize-duplicated-modules/src',
  vite:config   env: { BASE_URL: '/', MODE: 'development', DEV: true, PROD: false },
  vite:config   assetsInclude: [Function: assetsInclude],
  vite:config   logger: {
  vite:config     hasWarned: false,
  vite:config     info: [Function: info],
  vite:config     warn: [Function: warn],
  vite:config     warnOnce: [Function: warnOnce],
  vite:config     error: [Function: error],
  vite:config     clearScreen: [Function: clearScreen],
  vite:config     hasErrorLogged: [Function: hasErrorLogged]
  vite:config   },
  vite:config   packageCache: Map(2) {
  vite:config     'fnpd_/home/michael/projects/pioneer/repro-depsoptimize-duplicated-modules' => {
  vite:config       dir: '/home/michael/projects/pioneer/repro-depsoptimize-duplicated-modules',
  vite:config       data: [Object],
  vite:config       hasSideEffects: [Function: hasSideEffects],
  vite:config       webResolvedImports: {},
  vite:config       nodeResolvedImports: {},
  vite:config       setResolvedCache: [Function: setResolvedCache],
  vite:config       getResolvedCache: [Function: getResolvedCache]
  vite:config     },
  vite:config     'fnpd_/home/michael/projects/pioneer/repro-depsoptimize-duplicated-modules/src' => {
  vite:config       dir: '/home/michael/projects/pioneer/repro-depsoptimize-duplicated-modules',
  vite:config       data: [Object],
  vite:config       hasSideEffects: [Function: hasSideEffects],
  vite:config       webResolvedImports: {},
  vite:config       nodeResolvedImports: {},
  vite:config       setResolvedCache: [Function: setResolvedCache],
  vite:config       getResolvedCache: [Function: getResolvedCache]
  vite:config     },
  vite:config     set: [Function (anonymous)]
  vite:config   },
  vite:config   createResolver: [Function: createResolver],
  vite:config   worker: {
  vite:config     format: 'iife',
  vite:config     plugins: [
  vite:config       'vite:optimized-deps',
  vite:config       'vite:watch-package-data',
  vite:config       'vite:pre-alias',
  vite:config       'alias',
  vite:config       'vite:modulepreload-polyfill',
  vite:config       'vite:resolve',
  vite:config       'vite:html-inline-proxy',
  vite:config       'vite:css',
  vite:config       'vite:esbuild',
  vite:config       'vite:json',
  vite:config       'vite:wasm-helper',
  vite:config       'vite:worker',
  vite:config       'vite:asset',
  vite:config       'vite:wasm-fallback',
  vite:config       'vite:define',
  vite:config       'vite:css-post',
  vite:config       'vite:worker-import-meta-url',
  vite:config       'vite:asset-import-meta-url',
  vite:config       'vite:dynamic-import-vars',
  vite:config       'vite:import-glob',
  vite:config       'vite:client-inject',
  vite:config       'vite:import-analysis'
  vite:config     ],
  vite:config     rollupOptions: {},
  vite:config     getSortedPlugins: [Function: getSortedPlugins],
  vite:config     getSortedPluginHooks: [Function: getSortedPluginHooks]
  vite:config   },
  vite:config   appType: 'spa',
  vite:config   experimental: { importGlobRestoreExtension: false, hmrPartialAccept: false },
  vite:config   getSortedPlugins: [Function: getSortedPlugins],
  vite:config   getSortedPluginHooks: [Function: getSortedPluginHooks]
  vite:config } +11ms
  vite:esbuild 31.21ms tsconfck init /home/michael/projects/pioneer/repro-depsoptimize-duplicated-modules +0ms
  vite:deps scanning for dependencies... +0ms

  VITE v4.3.9  ready in 221 ms

  ➜  Local:   http://localhost:5173/
  ➜  Network: use --host to expose
  ➜  press h to show help
  vite:deps Crawling dependencies using entries:
  vite:deps   /home/michael/projects/pioneer/repro-depsoptimize-duplicated-modules/src/index.html +0ms
  vite:resolve 0.34ms ./app/index.js -> /home/michael/projects/pioneer/repro-depsoptimize-duplicated-modules/src/app/index.js +0ms
  vite:resolve 0.80ms virtual:init-all-packages -> auto-init?from=/home/michael/projects/pioneer/repro-depsoptimize-duplicated-modules/src/app/package.json&noext +4ms
  vite:resolve 0.75ms shared -> /home/michael/projects/pioneer/repro-depsoptimize-duplicated-modules/external/node_modules/shared/index.js +3ms
  vite:deps Scan completed in 39.70ms:
  vite:deps   shared -> /home/michael/projects/pioneer/repro-depsoptimize-duplicated-modules/external/node_modules/shared/index.js +26ms
  vite:deps Dependencies bundled in 7.41ms +0ms
  vite:html-fallback Rewriting GET / to /index.html +0ms
  vite:time 37.45ms /index.html +0ms
  vite:resolve 0.91ms /@vite/client -> /home/michael/projects/pioneer/repro-depsoptimize-duplicated-modules/node_modules/.pnpm/vite@4.3.9_<EMAIL_ADDRESS>+0ms
  vite:resolve 0.21ms /app/index.js -> /home/michael/projects/pioneer/repro-depsoptimize-duplicated-modules/src/app/index.js +4ms
  vite:load 3.59ms [fs] /@vite/client +0ms
  vite:load 1.73ms [fs] /app/index.js +1ms
  vite:resolve 0.33ms shared -> /home/michael/projects/pioneer/repro-depsoptimize-duplicated-modules/node_modules/.vite/deps/shared.js?v=b189d285 +7ms
  vite:resolve 0.56ms virtual:init-all-packages -> auto-init?from=/home/michael/projects/pioneer/repro-depsoptimize-duplicated-modules/src/app/package.json&noext +0ms
  vite:import-analysis 4.26ms [2 imports rewritten] app/index.js +0ms
  vite:transform 7.34ms /app/index.js +0ms
  vite:time 11.76ms /app/index.js +486ms
  vite:resolve 3.00ms dep1/package.json -> /home/michael/projects/pioneer/repro-depsoptimize-duplicated-modules/external/node_modules/dep1/package.json +6ms
  vite:resolve 0.65ms dep1/init1.js -> /home/michael/projects/pioneer/repro-depsoptimize-duplicated-modules/external/node_modules/dep1/init1.js?v=077357fd +1ms
  vite:resolve 0.47ms dep2/package.json -> /home/michael/projects/pioneer/repro-depsoptimize-duplicated-modules/external/node_modules/dep2/package.json +0ms
  vite:resolve 0.61ms dep2/initExport -> /home/michael/projects/pioneer/repro-depsoptimize-duplicated-modules/external/node_modules/dep2/init2.js?v=077357fd +1ms
  vite:resolve 0.26ms shared/package.json -> /home/michael/projects/pioneer/repro-depsoptimize-duplicated-modules/external/node_modules/shared/package.json +0ms
  vite:load 7.29ms [plugin] auto-init?from=/home/michael/projects/pioneer/repro-depsoptimize-duplicated-modules/src/app/package.json&noext +14ms
  vite:import-analysis 0.96ms [2 imports rewritten] auto-init?from=/home/michael/projects/pioneer/repro-depsoptimize-duplicated-modules/src/app/package.json&noext +7ms
  vite:transform 1.46ms auto-init?from=/home/michael/projects/pioneer/repro-depsoptimize-duplicated-modules/src/app/package.json&noext +8ms
  vite:resolve 0.12ms @vite/env -> /home/michael/projects/pioneer/repro-depsoptimize-duplicated-modules/node_modules/.pnpm/vite@4.3.9_<EMAIL_ADDRESS>+10ms
  vite:import-analysis 3.27ms [1 imports rewritten] /home/michael/projects/pioneer/repro-depsoptimize-duplicated-modules/node_modules/.pnpm/vite@4.3.9_<EMAIL_ADDRESS>+9ms
  vite:transform 4.02ms /@vite/client +8ms
  vite:time 32.49ms /@vite/client +15ms
  vite:cache [memory] auto-init?from=/home/michael/projects/pioneer/repro-depsoptimize-duplicated-modules/src/app/package.json&noext +0ms
  vite:time 0.34ms /@id/__x00__auto-init?from=/home/michael/projects/pioneer/repro-depsoptimize-duplicated-modules/src/app/package.json&noext +2ms
  vite:load 11.68ms [fs] ../external/node_modules/dep2/init2.js?v=077357fd +13ms
  vite:resolve 0.77ms shared/inner -> /home/michael/projects/pioneer/repro-depsoptimize-duplicated-modules/external/node_modules/shared/inner.js?v=077357fd +8ms
  vite:import-analysis 3.53ms [1 imports rewritten] /home/michael/projects/pioneer/repro-depsoptimize-duplicated-modules/external/node_modules/dep2/init2.js?v=077357fd +8ms
  vite:transform 4.27ms ../external/node_modules/dep2/init2.js?v=077357fd +8ms
  vite:load 17.28ms [fs] ../external/node_modules/dep1/init1.js?v=077357fd +5ms
  vite:import-analysis 0.03ms [no imports] /home/michael/projects/pioneer/repro-depsoptimize-duplicated-modules/external/node_modules/dep1/init1.js?v=077357fd +2ms
  vite:transform 0.88ms ../external/node_modules/dep1/init1.js?v=077357fd +2ms
  vite:load 11.27ms [fs] ../node_modules/.pnpm/vite@4.3.9_<EMAIL_ADDRESS>+3ms
  vite:load 3.35ms [fs] ../external/node_modules/shared/inner.js?v=077357fd +0ms
  vite:import-analysis 0.09ms [no imports] /home/michael/projects/pioneer/repro-depsoptimize-duplicated-modules/external/node_modules/shared/inner.js?v=077357fd +2ms
  vite:transform 0.38ms ../external/node_modules/shared/inner.js?v=077357fd +2ms
  vite:cache [memory] ../external/node_modules/dep1/init1.js?v=077357fd +11ms
  vite:time 0.44ms ../external/node_modules/dep1/init1.js?v=077357fd +11ms
  vite:cache [memory] ../external/node_modules/dep2/init2.js?v=077357fd +1ms
  vite:time 0.47ms ../external/node_modules/dep2/init2.js?v=077357fd +1ms
  vite:import-analysis 0.07ms [no imports] /home/michael/projects/pioneer/repro-depsoptimize-duplicated-modules/node_modules/.pnpm/vite@4.3.9_<EMAIL_ADDRESS>+4ms
  vite:transform 0.49ms ../node_modules/.pnpm/vite@4.3.9_<EMAIL_ADDRESS>+4ms
  vite:cache [304] ../node_modules/.pnpm/vite@4.3.9_<EMAIL_ADDRESS>+0ms
  vite:time 0.40ms ../node_modules/.pnpm/vite@4.3.9_<EMAIL_ADDRESS>+7ms
  vite:cache [memory] ../external/node_modules/shared/inner.js?v=077357fd +20ms
  vite:time 0.74ms ../external/node_modules/shared/inner.js?v=077357fd +13ms
  vite:deps ✨ static imports crawl ended +16s
  vite:deps ✨ using post-scan optimizer result, the scanner found every used dependency +0ms
  vite:optimize-deps load /home/michael/projects/pioneer/repro-depsoptimize-duplicated-modules/node_modules/.vite/deps/shared.js +0ms
  vite:deps ✨ dependencies optimized +2ms
  vite:load 86.71ms [plugin] ../node_modules/.vite/deps/shared.js?v=b189d285 +59ms
  vite:import-analysis 0.03ms [no imports] /home/michael/projects/pioneer/repro-depsoptimize-duplicated-modules/node_modules/.vite/deps/shared.js?v=b189d285 +54ms
  vite:transform 0.26ms ../node_modules/.vite/deps/shared.js?v=b189d285 +54ms
  vite:time 60.24ms ../node_modules/.vite/deps/shared.js?v=b189d285 +37ms

Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

possible duplicated of https://github.com/vitejs/vite/issues/9171 ?

I can't say this with absolute certainty, but I think that this is a different problem (with similar error symptoms, though). #9171 describes duplicated modules within the chunks generated by the optimizer (chunk-xyz.js). This issue is related two duplicate modules where one copy is generated by the optimizer and the other one is not.
Essentially, there are two "import paths" that are not merged into the same module copy, hence the module existing twice. Additonally, this problem only occurs during development, whereas #9171 can also happen during build.

I don't know much about Vite, so I'm not sure this is related, but I am getting duplicate modules breaking my app, and using resolve.alias is not helping and only causes module not found errors.
With this config,
import {defineConfig} from 'vite'
import path from 'path'

// https://vitejs.dev/config/
export default defineConfig({
	optimizeDeps: {
		noDiscovery: true,
		include: [],
	},
	assetsInclude: ['**/*.glb'],
	build: {
		target: 'esnext',
		// FIXME ^ why do private fields get compiled to __pricateAdd(), __privateGet(), etc, although we use esnext?
		minify: false,
	},
	esbuild: {
		minify: false,
		jsx: 'automatic',
		jsxImportSource: 'preact',
		target: 'esnext',
		// FIXME ^ why do private fields get compiled to __pricateAdd(), __privateGet(), etc, although we use esnext?
	},
	resolve: {
		alias: {
			'solid-js': path.resolve('./node_modules/solid-js/dist/solid.js'),
			'solid-js/store': path.resolve('./node_modules/solid-js/store/dist/store.js'),
			'solid-js/web': path.resolve('./node_modules/solid-js/web/dist/web.js'),
			'solid-js/html': path.resolve('./node_modules/solid-js/html/dist/html.js'),
		},
	},
})

I get errors like these:
Failed to resolve import "solid-js/web" from "node_modules/lume/dist/index.js". Does the file exist?

I have verified that paths like path.resolve('./node_modules/solid-js/dist/solid.js') do actually exist.
Without the resolve.alias, I do not get the missing module errors, but then the app ends up having duplicate libraries (that makes other problems).
I do have an optimizeDeps config. Is it related?

Maybe my issue is not optimizeDeps-related. Changing my alias config to following no longer has a missing module error, and duplicates are prevented:
		alias: {
			'solid-js': path.resolve('./node_modules/solid-js'),
		},

Dunno if this is related, but I just ran into an issue where running vite build produced two different sized results depending on if the packages were installed with npm ci vs pnpm i --frozen-lockfile.
I narrowed it down to the use of shared-workspace-lockfile = false in my .npmrc file. Removing, or setting this to true removed the duplication of bundled assets and the filesizes are the same/closer.

For context... This happened for me in a monorepo using "npm workspaces". We mainly use npm, but "npm workspaces" are a bit of nightmare for building and isolating/ejecting backend Node applications for production. Because of this, in CI we opted to use pnpm instead to at least pnpm install --frozen-lockfile the packages at the start, and then pnpm deploy at the end to export an isolated package that we can prep for dist.
This preparation looks a little like:
# Generate PNPM Workspace and Settings
cat 'package.json' | yq eval '{"packages": .workspaces}' -P - > 'pnpm-workspace.yaml'
echo 'link-workspace-packages = true' > '.npmrc'
echo 'shared-workspace-lockfile = false' >> '.npmrc'   # <---- this was causing the duplication
echo 'shamefully-hoist = true' >> '.npmrc'

# Generate PNPM Lockfile
pnpm import

# Install Dependencies
pnpm install --frozen-lockfile

The deployment/ejection looks like:
# Create isolated/deployable application
pnpm deploy --filter="$project_name" --prod /usr/src/deploy

In between those stages we would build and test etc... Using either npm or pnpm to do so, i.e... npm run build or pnpm run build, or npm run build --workspace="$project_name" or pnpm run --filter="$project_name" build.
This is where we noticed that the resulting assets for one of our very-small frontend packages was slightly larger than expected.
Running npm ci in the root of the repo to remove the pnpm installed deps and replace with npm installed ones, then re-running the build fixed the issue. So we determined it was something about how pnpm was structuring the node_modules/. After playing with the pnpm settings, we determined it was the shared-workspace-lockfile causing the problem for us.
Annoyingly, that option is kind of important for backend applications (as it seems to ensure deps with binaries are correctly exported when deploying), but for frontend applications/assets having it is causing this bundling bloat. I was hoping I could create an .npmrc in each package to tailor what we need where, but it doesn't look like these get inherited. The good news is that the setting can be added and removed just before/after pnpm deploy at least and its seems to work out.
Anyways.... in my case at least, this issue seems to be related more to pnpm and not vite necessarily.


Add test to check email subject templates do NOT contain newlines

Fixes (partly) https://github.com/pypi/warehouse/issues/13216, related to https://github.com/pypi/warehouse/pull/13215.
This is a pretty blunt approach. We iterate over all email subject templates, use a regex to find the whole subject block, and assert that it does not contain newlines.
It does seem to do the job: it caught an existing subject template with newlines, which is now fixed in the second commit.
If using regexes is too blunt, then we can use this PR to discuss how we can test for this. I opened a PR that would've been affected by this issue, and I never would've realized if not for @woodruffw's comment here.
cc @di @miketheman

(Needs update/rebase, but otherwise LGTM!)


Translatable models and multi-language CRUDs

I'm using some multi-language fields following guide:
https://backpackforlaravel.com/docs/5.x/crud-operation-update#translatable-models-and-multi-language-cruds
I've found this issues:

i'd like to choose what languages to support, now i see always English, French, Italian, Romanian, how can i set them?
Changing language you lost values, you always need to Save, is there a way to save on lang change?

Is it a bug in the latest version of Backpack?
also previous versions
Backpack, Laravel, PHP, DB version
When I run php artisan backpack:version the output is:
PHP VERSION:
PHP 8.1.11 (cli) (built: Sep 29 2022 02:51:04) (NTS)
Copyright (c) The PHP Group
Zend Engine v4.1.11, Copyright (c) Zend Technologies
with Zend OPcache v8.1.11, Copyright (c), by Zend Technologies
LARAVEL VERSION:
v9.43.0@011f2e1d49a11c22519a7899b46ddf3bc5b0f40b
BACKPACK VERSION:
5.4.11@ffbadcdb6478822646600b2cd763490caa927155

Hello @blondie63
For your first question you should check the config/backpack/crud.php file. https://github.com/Laravel-Backpack/CRUD/blob/main/src/config/backpack/crud.php
And for the second question the answer is no 😞 When language changes a new request is initiated and the page refreshed.
Although I think it's a good UX if when you click to change the language it could at least warn the user that the changes would be lost if not saved.
But it would be intrusive when you have no changes, so we'd need to build a input change listener to only trigger that warning if there are un-saved changes in the form.
I will be moving this to Ideas and changing the title to match this suggestion. I think it wouldn't take that much time to develop and add some great UX value.
Thanks for raising the issue @blondie63
Wish you all the best 🎅


Add a 'reactive' fold equivalent to collectStream (foldStream)

Should allow the current values of a Stream to be folded / reduced asynchronously into a new Stream

exists already : reduceAll
In 2.1.0 we should introduce an alias for collectStream called collectAll to align the naming and deprecate collectStream

Released in 2.1.0


Sending EndFrame() in a LLM tool_call will not hangup the phone call

I want to hangup the phone in a LLM tool call, so in the tool context I called llm.push_frame(EndFrame()), but this could not hangup the call.
So is it possible to hangup the phone call in a LLM tool call context? In the twilio document it says the only way to hangup the call is close the websocket. I know the FastAPIWebsocketInputTransport will close websocket when it process EndFrame. But I cannot get the reference from a llm tool context. How should i do this?
Some other information:

use Twilio bidirectional stream to connect call to LLM;
use FastAPIWebsocketTransport

So any suggestions? Thanks!

I found using the newest EndTaskFrame() will work, but remember to send it to upstream direction.
code like this:
async def hangup_call(function_name, toll_call_id, args, llm, context, result_callback):
    print(f"Hanging up call for client ID: {args['client_id']}")
    await llm.push_frame(EndTaskFrame(), FrameDirection.UPSTREAM)

i will close this issue


Feature/tech 475 increase code coverage

Nice improvements!
* [dd01f8d#diff-3821613dc8ca82480d738cb93d2630104d580e147d989150de7aa0c7191354ecR20-R28](https://github.com/Vandebron/mpyl/commit/dd01f8dffb0bcf3b9841be9f107c31edd25656ad#diff-3821613dc8ca82480d738cb93d2630104d580e147d989150de7aa0c7191354ecR20-R28) maybe you could use "named parameters" here.

* [9273d4c#diff-8363fb6fae73cdc9c25ae024d7a27de8f1d2e5ad4d79a4ee5212ca56b0bc6da6R49-R51](https://github.com/Vandebron/mpyl/commit/9273d4ce6036fe7eb5b855143b0f246bf234d2ba#diff-8363fb6fae73cdc9c25ae024d7a27de8f1d2e5ad4d79a4ee5212ca56b0bc6da6R49-R51) I think this test is likely to fail locally if you happen to have a different version of MpyL installed.  Perhaps you could simplify this test by using the standard roundtrip logic, but simply deleting the line that starts with `Version: ` in the expect text?

* [27b7abe#diff-8c2733bc30b50c487f64020f6f51505eb3a540b0e720b420b2aad2e8bd6e366bR114-R120](https://github.com/Vandebron/mpyl/commit/27b7abe6a71678dd653db5d89e3369020fdf5774#diff-8c2733bc30b50c487f64020f6f51505eb3a540b0e720b420b2aad2e8bd6e366bR114-R120) is this guaranteed to have consistent results? What if I run an MPyL build locally?

* [27b7abe#diff-8c2733bc30b50c487f64020f6f51505eb3a540b0e720b420b2aad2e8bd6e366bR96-R112](https://github.com/Vandebron/mpyl/commit/27b7abe6a71678dd653db5d89e3369020fdf5774#diff-8c2733bc30b50c487f64020f6f51505eb3a540b0e720b420b2aad2e8bd6e366bR96-R112) do we need the chdirs? Seems a bit brittle.

Done in 4f693dd4363e7cde63c83e986e137c94e39e5d31
Why would it fail with a different version installed? The test gets the installed version and replaces the placeholder text with that version. Am I missing something?
Yeah this works because it doesn't have the chdir's you mentioned in the next point, it won't find anything to clean
Because these cli cmd's need to be run from root, otherwise it won't find the projects. I couldn't find a better way, and I liked this more than not having any coverage. But I'm open to suggestions?


How can i order an edited columns properly ?

Summary of problem or feature request
I have price and created_at column that i have edited as you see on the code below:
public function getResponse(){
    $products = Product::all();

    return DataTables::of($products)
        ->editColumn('created_at', function(Product $product) {
                return $product->created_at->format('d-m-Y H:i:s');
            })
        ->editColumn('price', function(Product $product) {
            return '$'. number_format($product->price, 2);
        })
        ->toJson();
}

The problem is when i sort the datatable by price or created_at, the rows don't get sorted properly because the value format is edited.
is there an easy way to make the columns get sorted by the original column value?
System details

Operating System: win10
PHP Version: v8.1.12
Laravel Version: v9
Laravel-Datatables Version: v10

If you want it sorted the way it was formatted, you need to do the editing via SQL level:
$products = Product::query()
  ->select('columns,...');
  ->addSelectRaw("concat('$', price) as price");

return DataTables::of($products)->toJson();

sorry, I didn't explain the issue properly.
The problem is: when I edit a column the sorting don't work properly as you see on the image image below.
public function getResponse(){
    $products = Product::all();

    return DataTables::of($products)
        ->editColumn('price', function(Product $product) {
            return '$'. number_format($product->price, 2);
        })
        ->toJson();
}

Ascending price assortment as you see is not correct.

Try using query instead of collection:
$products = Product::query();


Remove row-transformation capability from TopNProjection

Changes the TopNProjection constructor to enforce a simple
"row-passthrough" - it can no longer evaluate functions or shuffle
columns.

Adapts the SimpleTopNProjector to no longer add a
RowTransformingBatchIterator. This should avoid a bit of overhead
during query execution.

The planner already adds an EvalProjection if a scalar
evaluation or column shuffling is required. So it is no longer necessary
for the TopNProjection to provide this functionality as well.

Codecov Report

Merging #6422 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #6422      +/-   ##
============================================
- Coverage     82.75%   82.71%   -0.04%
+ Complexity    12893    12881      -12
============================================
  Files          1481     1481
  Lines         48060    48053       -7
  Branches       5836     5836
============================================
- Hits          39774    39749      -25
- Misses         5540     5560      +20
+ Partials       2746     2744       -2

Impacted Files
Coverage Δ
Complexity Δ

...ation/projectors/ProjectionToProjectorVisitor.java
92.01% <100%> (-0.19%)
32 <0> (ø)

...rate/operation/projectors/SimpleTopNProjector.java
83.33% <100%> (-3.34%)
6 <3> (ø)

...va/io/crate/planner/projection/TopNProjection.java
69.23% <100%> (+1.73%)
12 <1> (-1)
:arrow_down:

...rc/main/java/io/crate/planner/operators/Limit.java
89.18% <100%> (ø)
16 <0> (ø)
:arrow_down:

...main/java/io/crate/data/LimitingBatchIterator.java
100% <100%> (ø)
11 <1> (ø)
:arrow_down:

...ecutor/transport/task/elasticsearch/ESGetTask.java
85.16% <100%> (ø)
13 <0> (ø)
:arrow_down:

.../planner/projection/builder/ProjectionBuilder.java
70.45% <100%> (ø)
12 <0> (ø)
:arrow_down:

...n/java/io/crate/exceptions/JobKilledException.java
0% <0%> (-66.67%)
0% <0%> (-1%)

...in/java/io/crate/lucene/match/CrateRegexQuery.java
43.47% <0%> (-39.14%)
4% <0%> (-5%)

...a/io/crate/executor/transport/ActionListeners.java
33.33% <0%> (-22.23%)
2% <0%> (-1%)

... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0790dc...9d58c52. Read the comment docs.


Add new 1.24 patches

Issue #, if available:
Closes https://github.com/aws/eks-distro/issues/1430
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/retest

/test kubernetes-1-24-presubmit

/retest

/approve


Fix broken INSTALL.md.in path while running make distcheck

The distcheck target ensures that the distribution tarball is
self-contained, i.e. using only the files present in the distribution it
can create another identical distribution. While doing so, we can't
assume that the current directory is the top-level.
This makes make distcheck work for me on OpenBSD. /cc @mike-burns

Thanks, merged as 9034255.


[Security issue] Clarity depends on bootstrap 4.0.0-alpha which has xss issue

Harbor team depends on Clarity 0.12. Now this version is using bootstrap 4.0.0 alpha which is reported xss security risks.
Can clarity make a patch to 0.12 version, modify the dependency to bootstrap 4.1.3? otherwise , harbor team can not release new version.
Waiting for feedback

We are aware of the XSS report, but Clarity does not use the JavaScript from Bootstrap which has the vulnerability. Updating Bootstrap is a breaking change for us, because Bootstrap changed a lot of files and features between 4.0.0-alpha.5 and 4.0.0.

@gnomeontherun , do you have any plan of this? It looks not so reasonable to use a alpha version in a product release.

@zhoumeina view issue https://github.com/vmware/clarity/issues/1531

@gnomeontherun
Could you give an update here on what our plan is? Thanks.

As I noted in https://github.com/goharbor/harbor/pull/5967, most projects don't actually need Bootstrap unless the build custom themes. So your immediate issue can be resolved by removing it from your project if tooling is throwing notices about having a dependency upon Bootstrap 4.0.0-alpha.5.
Our rationale for not updating before is that we don't use the JavaScript (which has the issue), and we don't ship with Bootstrap (its optional for only custom theme implementations). However, automated testing tools don't know the difference or understand the way dependencies are actually used to know that we don't actually consume the offending code, and we realize this may be an issue for some
As I mentioned, updating Bootstrap causes a number of breaking changes and we're not able to do this right now based on the amount of work involved to smooth over all the changes and also manage the release. That is why we targeted it for 2.0, and that will not change.
However, I have a plan that allows us to remove the Bootstrap dependency in 1.0 (by copying over just the Sass files we consume) without a breaking change to almost all users. It could be a breaking change for some users who are doing their own themes and have not followed our guide, so to be certain we will wait until the 1.0 version with this change.

We cannot put this change into 0.12, it will only go into 1.0 and above. If you don't need bootstrap to build a custom theme, this warning can be ignored. NPM doesn't have a way to mark optional peer dependencies.
Since this was merged, we'll close this ticket.


Be able to merge vars instance of overwrite.

Coverage decreased (-1.04%) to 98.96% when pulling da7205958507bb86d6882aa6a69bc81e2ac23da2 on merge into 929d883d82f7468ad80fef57151c5023d979e711 on master.

Coverage remained the same at 100.0% when pulling 652c7a67a5828e3fb2b4f2f5e5088fa3fe58931b on merge into 929d883d82f7468ad80fef57151c5023d979e711 on master.

Except the typos, LGTM.

Coverage remained the same at 100.0% when pulling 0efe1e5cb7b9c10a7c3fab4e68ac77d1f531c8a0 on merge into ee1790f267f2db886060fcbe9a21ea1cbe6f9cb9 on master.


2.9

For #37
I fixed a test and added the new rules.
Do you want me to convert all rules to new string syntax or do you prefer the numbers?
Also do you want me to include tests for the new rules?

Do you want me to convert all rules to new string syntax or do you prefer the numbers?

If you wouldn't mind, that would be great. Whichever route we go, we should be consistent though.

Also do you want me to include tests for the new rules?

Yes, please.

@cjihrig I did see that eslint docs do not prefer string over number just states "'error' or 2" so...

IMO strings are more developer friendly.

@cjihrig  1 test error https://travis-ci.org/continuationlabs/eslint-config-hapi/jobs/127603105#L219 not sure what happened. I can update the travis to also include v6? and maybe remove the old iojs's?

Wow, don't see segmentation faults every day. Yea, we only need to support 4, 5, and 6.

@cjihrig all green now 🎉

Awesome. Thank you!


failed to start harbor-core for lack of secret harborcluster-sample-harbor-harbor-internal-tls-core

MountVolume.SetUp failed for volume "internal-certificates" : secret "harborcluster-sample-harbor-harbor-internal-tls-core" not found

this is not issue, harborcluster-sample-harbor-harbor-internal-tls-core is created later


typo on the landing page

just FYI, "partecipate" in https://clor.io/

Thank you for the report 🙏  and sorry for looking into this issue just now. It was fixed once you reported it.


[1pt] Add unit tests for Book and Label classes

Add unit tests for all implemented methods.

Regarding the commits in #29 and #27, I have already made all the unit tests for these classes.
Is there anything missing?

There isn't anything left on the test cases, I;ve checked on the tests you wrote and they cover both instances.


Multiple words search not working

Hello there,
The issue I am facing is using getting tweets only containing 2 or 3 words
For exemple when I use
go run main.go -Query (flex working)
It gives me every tweets containing the word 'flex' but not the word working :

And then when I click on the link as you can see above here is what I get 👍

If you have an idea on how we could fix that ! Thanks

Perhaps there was an error in the way inputs were parsed, but now it's working as expected. May you check now, please?

Maybe try quoting your query?
$ go run main.go -Query "(flex working)"

There was an issue with the safe-url-encoding of the input. Now it's expected to work as needed.
(btw nice formatting is very welcome, not mandatory but please)


Label the details shown  regarding mission

It would me more informative if we add label to details shown regarding various missions.

I would like to work on this project.
Please assign me when coding period start.

@Aniket979Kanodia I am assigning you the issue, you can make the PR when LGMSoC starts!

Thank you for assigning me this issue.
Is there any slack or discord group available which I can connect for discussion.

Yes please join the slack channel for this project through the LGMSoC workspace in the announcements section!


python 3 syntax for print() example in READER.md

*README.MD

Hey! I am hosting a new master branch for this repo since the old creator has been MIA for 2 years. Hoping to get this repo back on it's feet and in good standing. I've been working on updating tests and adding all new functionality and have merged some of the PR's that I thought were sufficient for merging. If your PR didn't make it, resubmit it please.
Thanks!
https://github.com/Harrison97/spotipy


Outline panel doesn't show project for a plain dotnet project

Outline viewer doesn't show project for a plain dotnet project

Steps to reproduce

Create a fresh F# dotnet core project from the command line, as with
dotnet new console -lang F#.
Open the folder in VSCode, and notice that the outline panel shows the contents of any .fs file, but it doesn't show the project.
If you add a new .fs file, you need to put it in the right order manually in the .fsproj file; the ordering buttons do not appear.

The behaviour is the same with or without the Ionide Mechanic extension.
Machine infos

Operating system: Darwin
Arch: x64
VSCode: 1.25.1
Runtime: .Net
Mono version:

Mono JIT compiler version <IP_ADDRESS> (2017-12/ea8a24b1bbf Tue Apr 24 14:53:01 EDT 2018)
Copyright (C) 2002-2014 Novell, Inc, Xamarin Inc and Contributors. www.mono-project.com
	TLS:           normal
	SIGSEGV:       altstack
	Notification:  kqueue
	Architecture:  amd64
	Disabled:      none
	Misc:          softdebug
	Interpreter:   yes
	LLVM:          yes(3.6.0svn-mono-master/8b1520c8aae)
	GC:            sgen (concurrent by default)

MSBuild version:

Microsoft (R) Build Engine version <IP_ADDRESS> (xplat-master/ca830585 Sun Mar 25 19:24:09 EDT 2018) for Mono
Copyright (C) Microsoft Corporation. All rights reserved.

Outline viewer is showing only content of the current file.
The project explorer is under F# icon in the activity bar:


New UI, new tech stack (node.js)

why the new stack?
how do i get this up and running?

to get it up and running
node -v
(should print latest version 14)
if node 14 then
npm i
to install JS dependencies
then run the app in dev mode
npm run dev
this starts https server at localhost:3000

npm run dev throws error, missing script dev


Add support for poly1305 in EVP_PKEY

Add Poly1305 as a "signed" digest.

Checklist

[X] documentation is added or updated
[X] tests are added or updated
[X] CLA is signed

Description of change

Hmmmm....  this is a bit overdone.  We're trying to move to having EVP used universally, so new algos are made EVP-only (i.e. internal).  Could you please adapt to that plan (which essentially means undoing the public Poly1305 part)?

Was about to say the same thing.

Sure, I was just following the example of the other digests.

I put the flags change into another PR and removed it from here.

This change is now just the updates for the EVP_PKEY changes. The Poly1305_xxxx functions are no longer exported.

+1

This PR has been reduced to just the EVP_PKEY API.
I have rebased on top of master; and have consolidated all the commits into a single one.

A lot of this is basically from HMAC, which is another "keyed" message digest. I'm not sure there are actually two keys, but I will look at it again.

As an aside, there is no EVP_PKEY_assign_HMAC() (or CMAC) from which this code is based. Can't create a EVP_PKEY_set1_POLY1305() because the ASN1_OCTET_STRING type has no refcount.
I'll see what I can do about documenting EVP_PKEY_CTRL_SET_MAC_KEY and EVP_PKEY_CTRL_DIGESTINIT; they were pre-existing.

Regarding two keys, it's a bit weird. A digest mechanism (which is what this does), sometimes has two keys, a MAC key, and a "public key". Here (and apparently in HMAC, but CMAC is different), the MAC key is assigned, then a "public key" can be generated from that MAC key, and then used in the DigestInit, which simply re-assigns the MAC key from the "public key". I agree this seems convoluted. But it does allow, at least for Poly1305 (and HMAC), to set the key via the EVP_PKEY_CTRL_SET_MAC_KEY or via EVP_DigestSignInit() with an EVP_PKEY of type EVP_PKEY_POLY1305 (EVP_PKEY_HMAC).

As an aside, there is no EVP_PKEY_assign_HMAC() (or CMAC) from which this code is based. Can't create a EVP_PKEY_set1_POLY1305() because the ASN1_OCTET_STRING type has no refcount.

IIRC there is some precedent for naming something with "set1" that secretly makes a copy, though given the different semantics with respect to modifying one copy, I'm not sure that we should encourage more of them.

Note: EVP_PKEY_CTRL_DIGESTINIT seems to be internal, used when EVP_DigestSignInit() is called.

Documented the SET_MAC_KEY option. Added some accessor functions.
I have also been able to use Poly1305 via:
``openssl dgst -mac poly1305 -macopt hexkey:XX...
Which works with the test data

Merging this now (I see that @dot-asm approved as well)

Or wait...  I'm rushing things.  @dot-asm, please reconfirm.

Also, looking at the commits, they should all be squashed into one before final merge.  @dot-asm, @tmshort, I can do that...

Yeah. I did some additional cleanup; I can squash if desired.

@tmshort, if you want to do the squashing, please be my guest :-)

In process...

Squashed and rebased. I had to update the EVP_F_EVP_PKEY_GET0_POLY1305 function number as well.

@tmshort please submit an ICLA too.

I sent the ICLA in this morning.

Merged, master only.  52ad5b60e3a1fef12a1a5ea01527a90b8f92a34b


Missing PnP:DataRow Support for List Attachments

As for the Content Extraction and Provisioing it would be good to have the possibility to specify File attached to ListItems.
Based on AttachmentCreationInformation we would need a FileName and TypeId to fully specify a attached File. I would suggest to have a it like:
pnp:DataRows
<pnp:DataRow rowId=1>
</pnp:DataRow>
pnp:DataRowAttachments
<pnp:DataRowAttachment rowId=1 FileName="myFile1.txt" TypeId="">
<pnp:DataRowAttachment rowId=1 FileName="myFile2.txt" TypeId="">
</pnp:DataRowAttachments>
</pnp:DataRows>
In that way we have no need to change DataRow from a Dictionary to a more complex object and can still have attachments assigned to ListItems - would mean:
<pnp:DataRowAttachment rowId="xsy:int" FileName="xsd:string" TypeId="xsd:string" >

Hi @czullu,
Thanks for the input. I've just added the Attachments collection to the DataRow. You will find it in schema 201909.


raft: Check promotable() in MsgTimeoutNow handling

Contributing guidelines
Please read our contribution workflow before submitting a pull request.
If MsgTimeoutNow arrived after a node was removed, the node could start
and win an election, then panic in becomeLeader (see
cockroachdb/cockroach#8535)

LGTM

/cc @siddontang


Add support for static factories

Currently, any method annotated with @Factory will be treated as-if it was non-static.
This means GraphQLite will try to instantiate the class the factory is in, even if the factory is public static.
GraphQLite should not try to instantiate the class if the factory is static.

Done in #27


fixing #520

See #520, this PR aims to make sure that the movisens functions receive a directory path and not a filepath as input.

Checklist before merging:

[x] Existing tests still work (check by running the test suite, e.g. from RStudio).
[x] Added tests (if you added functionality) or fixed existing test (if you fixed a bug).
[x] Updated or expanded the documentation.
[x] Updated release notes in inst/NEWS.Rd with a user-readable summary. Please, include references to relevant issues or PR discussions.
[x] Added your name to the contributors lists in the DESCRIPTION and CITATION.cff files.

Codecov Report

Merging #521 (f3977d4) into master (86b3312) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master     #521   +/-   ##
=======================================
  Coverage   73.23%   73.23%
=======================================
  Files          93       93
  Lines       11218    11218
=======================================
  Hits         8215     8215
  Misses       3003     3003

Impacted Files
Coverage Δ

R/g.getstarttime.R
56.58% <0.00%> (ø)

R/g.readaccfile.R
40.84% <0.00%> (ø)

R/g.readtemp_movisens.R
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86b3312...f3977d4. Read the comment docs.


Simulation setting that switches or skips calculations

Implement methods to optionally skip a calculation and link outputs by passing a flag to the simulation settings without requiring an entirely new calculation
For example, the option to use aoi diffuse modifiers or not could depend on a simulation setting, therefore aoi modifier would be linked to aoi diffuse modifier

Assuming that #63 is complete, then in calculation parameter formula can be a dictionary.
EG: spectral calculation with optional formulas
spectral = CalcParameter(
    dependencies=[solarposition, skymodel],
    formula=['f_sapm', 'f_fs', 'fspectrl2'],
    args={'f_sapm': {
        'data': {'time': 'time'},
        'output': {'AM': 'airmass'}
    }, 'f_fs': {
        'data': {'time': 'time'},
        'output': {'AM': 'airmass', 'pwat': 'watervap'}
    }, 'f_spectrl2': {
        'data': {'time': 'time'},
        'output': {'eqe': 'quantumeff', 'pwat': 'watervap', 'aod': 'aod', 'alpha': 'angstrom_alpha'}
    }},
    returns: ['spectral_shift'],
    skip: [1]  # a skip value for each returns, could be set to a value from any dependent calculation
)

Then in the simulation layer, a SimParameter can have the calculation option attribute.
settings = SimParameter(...
    calc_options={'spectral': None}
)  # None means use the skip value

~ or ~
settings = SimParameter(...
    calc_options={'spectral': 'f_sapm'}
)  # None means use the f_sapm formula and args!

Here's a sketch @anomam and I drew in our simeng2 meeting on 11/3:

For now, we can do this by just using a different calculation class, which is more tedious, but equally effective, EG:
class SAPMSpectralCalc(calculations.Calc):
    dependencies = ['blah']
    static = [{'formula': 'f_sapm', 'args': {'data': {'times': 'times'}, 'outputs': {'am': 'am'}}, 'returns: ['m']}]

class FirstSolarSpectralCalc(calculations.Calc):
    dependencies = ['blah']
    static = [{
        'formula': 'f_fs',
        'args': {'data': {'times': 'times'},
                 'outputs': {'pwat': 'pwat', 'am': 'am'}},
        'returns: ['m']
    }]

etc. then just create more than one model, but swap out the desired calculation. In your application, you can switch between models based on the calc options desired.


Allow tests to be run against different versions of kafka broker

Hi Ozan!
I am working with @k-wall and we would like to discuss with you a topic we have in mind that is very useful for us.
We are very interested in having container images in quay for different versions of kafka-native, because it is important for us to demonstrate that our project works against many versions of the kafka broker.
Our test framework currently relies on your repo to provide an image containing the kafka native binary.
We need a mechanism to produce many different kafka-native images (one per kafka version). Perhaps the naming scheme could be:
 quay.io/projectName/kafka-native-3.3.1:latest
 quay.io/projectName/kafka-native-3.2.0:latest

For that we will appreciate a lot your experience and your work in this repo to help us with our topic. What do you suggest that could be the best approach for that?

I see that this has been discussed here: https://github.com/kroxylicious/kproxy/issues/86. So putting it here for xref.
I expected this to become a requirement, just not this fast :)
It is not as straightforward as creating a kafka broker distribution, because it is compiled. Applied substitutions and some wrapping code can change. I think having a branch per supported kafka version makes sense.
As per the naming scheme, I'd keep the repository name as kafka-native, and change the tag like [project-version|latest]-kafka-[kafka-version], just like https://quay.io/repository/strimzi/kafka?tab=tags or https://quay.io/repository/strimzi-test-container/test-container?tab=tags. So it would be tags like
quay.io/ogunalp/kafka-native:latest-kafka-3.3.1
quay.io/ogunalp/kafka-native:0.1.2-kafka-3.2.0
quay.io/ogunalp/kafka-native:latest-kafka-3.2.1
quay.io/ogunalp/kafka-native:0.1.2-kafka-3.2.1

I recently worked on a github actions pipeline to perform a release. Currently, it releases maven artifacts to central and publishes image tags (version and latest) to quay.io.
We can adapt this to pick several branches, build images for them and push to quay with specific tags.


bvbulkalloc

Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (go version)?
Does this issue reproduce with the latest release?
What operating system and processor architecture are you using (go env)?
What did you do?
If possible, provide a recipe for reproducing the error.
A complete runnable program is good.
A link on play.golang.org is best.
What did you expect to see?
What did you see instead?

Kindly fill the complete issue template with the problem you are experiencing.

I'm going to close this as there is no actionable bug report here.
If this is a bug report, please file a new issue completing the template as requested.
Alternatively, please see https://golang.org/wiki/Questions for good places to ask questions. If there is a bug, they'll redirect you back to here if necessary.

My guess is that you wanted to report something similar to  #26560


Enable / disable panels in target and disease profile pages based on data availability

In the target and disease profile pages it is currently not possible to see which panels contain data and which ones don't before opening each of the panels (see screenshot below).

It would be nice to enable/disable the panels based on data availability, just like is done in the associations page:

@afaulconbridge, @mkarmona: I want to make a PR with a solution for this. My current idea is to extend the public/utils/stats API so that it accepts the target ID or the disease ID as a parameter. The counts would then reflect the number of associations found only for the given target or given disease.
So the get_stats in https://github.com/opentargets/rest_api/blob/master/app/common/elasticsearchclient.py#L1853 would look something like this (adding just target here...to keep the example simpler):
    def get_stats(self, ensembl_id=None):

        stats = DataStats()
        if ensembl_id is None:
            my_filter = {
                "constant_score": {
                    "filter": {
                        "term": {"target.id": ensembl_id}
                    }
                }
            }
        else:
            my_filter = {"match_all": {}}

        stats.add_evidencestring(self._cached_search(index=self._index_data,
                                                     # doc_type=self._docname_data,
                                                     body={"query": my_filter,
                                                           "aggs": {
                                                               "data": {
                                               ....

What do you think? Is this a good approach? Or are there other existing endpoints I should change instead? Or perhaps I should make a new one? Maybe a new endpoint would be better since I am not really interested in the target_count and disease_count parts of the get_stats response (see https://github.com/opentargets/rest_api/blob/master/app/common/elasticsearchclient.py#L1909 and https://github.com/opentargets/rest_api/blob/master/app/common/elasticsearchclient.py#L1923
)

discussion results: will maybe be handled in the new REACT version.

Note for the REACT versions this is part of opentargets/platform#224

closing this, since it is apparently a duplicate according to @afaulconbridge ' s note.
@afaulconbridge would it be possible to give a quick demo of how the new solution works now (I read in #224 that there is a proof of concept)?
@fedde-s @Sjoerd-van-Hagen


fix: Video calls open again on Electron window

Closes #2480

The opposite is happening ... VC oppens  in safari now while it was opening in electron window until the update ...
we tried both positions of the "open video chat using application window" switch

@chrisi51
This was a fix for the Video Conference from version 5.2 above.
But I'm taking a look in what breaked the versions below 5.0

thx for checking ... were on an older version due to UCS:
Version 3.18.2

@chrisi51 your server is public? Could I connect to it to test? You can reach me on open.rocket.chat if positive.

no its private :( and also not very easy to bring it public for testing right now :)

no problem, I'm spinning up some servers to test it

@chrisi51 already fixed it, will make a release today yet. The problem was the way jitsi domain string comes on some servers.

@jeanfbrito yep its working - thx!

@jeanfbrito hmm not working for me either, using 3.8.11 + Jitsi + Rocketchat 5.1.3 -> still opening in (default) browser
also cleared all %appdata% etc -> but no effect

This will work only on versions below 4.8.2 and above 5.2.
The Rocket.Chat 5.2 will be released soon and then it will start working on
it. We needed to change things because of the video conference on version 5
and it will be ready on this week release.
Em ter., 27 de set. de 2022 08:44, amsnek @.***>
escreveu:

@jeanfbrito https://github.com/jeanfbrito hmm not working for me
either, using 3.8.11 + Jitsi + Rocketchat 5.1.3 -> still opening in
(default) browser
also cleared all %appdata% etc -> but no effect
—
Reply to this email directly, view it on GitHub
https://github.com/RocketChat/Rocket.Chat.Electron/pull/2495#issuecomment-1259380048,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAI7PCQGJZAPLAD5G2TDM3DWALMYDANCNFSM6AAAAAAQDM5FCM
.
You are receiving this because you were mentioned.Message ID:
@.***>

This will work only on versions below 4.8.2 and above 5.2.

Ah this makes sense, i wasnt sure if the 5.2 wasnt a typo since there is no 5.2 yet. Thanks, that is good to know.

Yeah I released the desktop before the server version to be ready when the
server updates.
I needed to change code inside the server this time, this is why this time
we need a server release. After that it will be working with any video
conference provider. Before was just jitsi and BBB.
Em ter., 27 de set. de 2022 09:16, amsnek @.***>
escreveu:

This will work only on versions below 4.8.2 and above 5.2.
Ah this makes sense, i wasnt sure if the 5.2 wasnt a typo since there is
no 5.2 yet. Thanks, that is good to know.
—
Reply to this email directly, view it on GitHub
https://github.com/RocketChat/Rocket.Chat.Electron/pull/2495#issuecomment-1259420992,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAI7PCUL4KJEAFVXGOS6XG3WALQSNANCNFSM6AAAAAAQDM5FCM
.
You are receiving this because you were mentioned.Message ID:
@.***>


cleanup(libsinsp): cleanup unaligned access in plugin framework+tests

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind cleanup

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area libsinsp

Does this PR require a change in the driver versions?
No

What this PR does / why we need it:
This is part of this effort: https://github.com/falcosecurity/libs/issues/1470
This current PR deals with plugins, note that it introduces a dependency from the plugin tests to the scap library in order to use the scap_event_encode_params function which allows the test classes to easily create events without misaligned reads or writes.
It looks like the sinsp test suite is are currently at 7 errors with UBSan.
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

NONE

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: LucaGuerra
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [LucaGuerra]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jasondellaluce, LucaGuerra
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [LucaGuerra,jasondellaluce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Implemented warning balloon which shows up when old java version is used

As discussed in #62 this code will add a warning balloon if an old java version is used. Every time the plugin is installed/started or the IDE starts up the message will appear. So far the code will not disable the plugin but I think this will be a good resource for that.

:+1:


implement sigwinch-aware resizing

adds a new auto_lines option
currently just fills the entire terminal
also not actually sigwinch aware, that'll need either a global flag or global ref to tty

Hi @youbitchoc. Could you describe exactly what this options does? In case of acceptance, it needs to be added to the documentation.

passing --lines=auto tells fnf to use the entire terminal, and resizes accordingly with the terminal

Ok. Tested and working as expected. Merging.


error: unable to recognize "certificate-issuer.yaml": no matches for kind "Issuer" in version "cert-manager.io/v1alpha2"

error: unable to recognize "certificate-issuer.yaml": no matches for kind "Issuer" in version "cert-manager.io/v1alpha2"
How to solve above error in Chapter 06 p.151?
Thank you!

Make sure you run these command to check :
kubectl get crd
It must result something like this :
NAME                                    CREATED AT
certificaterequests.cert-manager.io     2021-02-14T10:18:39Z
certificates.cert-manager.io            2021-02-14T10:18:40Z
challenges.acme.cert-manager.io         2021-02-14T10:18:41Z
clusterissuers.cert-manager.io          2021-02-14T10:18:41Z
issuers.cert-manager.io                 2021-02-14T10:18:38Z
orders.acme.cert-manager.io             2021-02-14T10:18:39Z
If it is not there then run following command:
Kubernetes 1.15+
$ kubectl apply --validate=false -f https://github.com/jetstack/cert-manager/releases/download/v0.15.1/cert-manager.crds.yaml
Kubernetes <1.15
$ kubectl apply --validate=false -f https://github.com/jetstack/cert-manager/releases/download/v0.15.1/cert-manager-legacy.crds.yaml


Updated pages for 1.28.11

 You should sign our Contributor License Agreement in order to get your pull request merged.

Test comment just to validate cla - will be removed immediately

outdated


android bluetotth scaning not working,ios working

Android Not scanning, ios working, is there. any option to scan paired devices ?

solved the issue with adding permission from flutter also added android manifest.xml
var statusLocation = Permission.location;
var statusScan = Permission.bluetoothScan;
var statusConnect = Permission.bluetoothConnect;
if (Platform.isAndroid) {
if (await statusLocation.isDenied) {
await [
Permission.location,
].request();
}
    if (await statusLocation.isGranted &&
      await statusScan.isGranted &&
      await statusScan.isGranted) {
    commonPrint('all grnted');
    // do scan bluetooth device function
  }

@iyashiyas @ferns-it can you share your AndroidManifest and a more detailed code snippet?

@iyashiyas @ferns-it I was able to figure out. Thank you. However, it does not work with Android 12. Worked fine with Android 9.

Android 12 doesn't work initially. You'll have to follow this: https://stackoverflow.com/questions/70578601/android-12-ble-scan-does-not-find-any-devices

Thanks ,this works for me
I migrated my project to null safety.
targeting sdk  30 to 31


Generate bashrc to execute SR Automatic Via Drop File bashrc to File Home in file System

Can we discuss this With @xorrior And @424f424f  in Upload file this Generate ! in Empire 2.2  OR 3 !

now this Handler And Listener With @xorrior And @424f424f 😄

@jihadLkmaty218  can you provide a link to the PR in which this was added?

thank you @xorrior ❤
https://github.com/jihadLkmaty218/Empire_2.2/blob/master/bashrc.py
And this : Generate File bashrc And execute Stager Automatic Via Drop File bashrc to File Home in file System
Video
https://streamable.com/s80w1

https://github.com/jihadLkmaty218/Empire_2.2/blob/master/Stager-Via-COM-Hijacking.py
Generate COM-Hijacking And execute File sct Via add Link raw file sct on gists or github
Author i'am And @subTee
Video
Soon Upload now

And I am happy to work with you thank you @xorrior After understanding the topic you can Tweet to  my @homjxi0e ::)

It can be uploaded within the latest version @xorrior

@jihadLkmaty218 these are not PR's that are currently open in the project. I will not accept PR's that just generate launchers.


Support AOT-built static assets

Creates a static folder under config.build.outDir during AOT build. Serves any static files that are found there.

@adamgreg Tried to push into the PR branch, but it looks like I'm not allowed to. Here is a patch that adds tests.
From 9ab99983cd634766a90322e8c90d9e10453756af Mon Sep 17 00:00:00 2001
From: Marvin Hagemeister<EMAIL_ADDRESS>Date: Fri, 3 Nov 2023 14:41:41 +0100
Subject: [PATCH] chore: add tests

---
 src/server/fs_extract.ts                      |  4 +-
 tests/build_test.ts                           | 48 ++++++++++++++++++-
 tests/fixture_build_static/deno.json          | 14 ++++++
 tests/fixture_build_static/dev.ts             |  5 ++
 tests/fixture_build_static/fresh.gen.ts       | 15 ++++++
 tests/fixture_build_static/main.ts            | 10 ++++
 tests/fixture_build_static/routes/index.tsx   |  3 ++
 .../fixture_build_static/static/duplicate.txt |  1 +
 tests/test_utils.ts                           | 13 +++++
 9 files changed, 110 insertions(+), 3 deletions(-)
 create mode 100644 tests/fixture_build_static/deno.json
 create mode 100755 tests/fixture_build_static/dev.ts
 create mode 100644 tests/fixture_build_static/fresh.gen.ts
 create mode 100644 tests/fixture_build_static/main.ts
 create mode 100644 tests/fixture_build_static/routes/index.tsx
 create mode 100644 tests/fixture_build_static/static/duplicate.txt

diff --git a/src/server/fs_extract.ts b/src/server/fs_extract.ts
index 8ae66ce..636f60e 100644
--- a/src/server/fs_extract.ts
+++ b/src/server/fs_extract.ts
@@ -262,8 +262,8 @@ export async function extractRoutes(

   const staticFiles: StaticFile[] = [];
   try {
-    const builtStaticDir = join(config.build.outDir, "static");
-    for (const staticDir of [config.staticDir, builtStaticDir]) {
+    const outDirStatic = join(config.build.outDir, "static");
+    for (const staticDir of [config.staticDir, outDirStatic]) {
       const staticDirUrl = toFileUrl(staticDir);
       const entries = walk(staticDir, {
         includeFiles: true,
diff --git a/tests/build_test.ts b/tests/build_test.ts
index 043e4db..53719df 100644
--- a/tests/build_test.ts
+++ b/tests/build_test.ts
@@ -3,11 +3,13 @@ import { puppeteer } from "./deps.ts";
 import { assert } from "$std/_util/asserts.ts";
 import {
   getStdOutput,
+  recreateFolder,
   startFreshServer,
   waitForText,
+  withFakeServe,
 } from "$fresh/tests/test_utils.ts";
 import { BuildSnapshotJson } from "$fresh/src/build/mod.ts";
-import { assertStringIncludes } from "$std/testing/asserts.ts";
+import { assertEquals, assertStringIncludes } from "$std/testing/asserts.ts";
 import { assertNotMatch } from "$std/testing/asserts.ts";

 function runBuild(fixture: string, subDirPath: string, outDir: string) {
@@ -256,3 +258,47 @@ Deno.test("pass target options", async () => {
     `Asset contained ?? despite target es2015\n\n${stdout}\n${stderr}`,
   );
 });
+
+Deno.test("serve static files from build dir", async () => {
+  const filePath = path.join(
+    path.dirname(path.fromFileUrl(import.meta.url)),
+    "fixture_build_static",
+    "_fresh",
+    "static",
+    "foo.txt",
+  );
+
+  await recreateFolder(path.dirname(filePath));
+  await Deno.writeTextFile(filePath, `it works`);
+
+  await withFakeServe(
+    "./tests/fixture_build_static/main.ts",
+    async (server) => {
+      const res = await server.get("/foo.txt");
+      const text = await res.text();
+      assertEquals(text, "it works");
+    },
+  );
+});
+
+Deno.test("prefer static files from build dir", async () => {
+  const filePath = path.join(
+    path.dirname(path.fromFileUrl(import.meta.url)),
+    "fixture_build_static",
+    "_fresh",
+    "static",
+    "duplicate.txt",
+  );
+
+  await recreateFolder(path.dirname(filePath));
+  await Deno.writeTextFile(filePath, "it works");
+
+  await withFakeServe(
+    "./tests/fixture_build_static/main.ts",
+    async (server) => {
+      const res = await server.get("/duplicate.txt");
+      const text = await res.text();
+      assertEquals(text, "it works");
+    },
+  );
+});
diff --git a/tests/fixture_build_static/deno.json b/tests/fixture_build_static/deno.json
new file mode 100644
index 0000000..fe6caa1
--- /dev/null
+++ b/tests/fixture_build_static/deno.json
@@ -0,0 +1,14 @@
+{
+  "lock": false,
+  "imports": {
+    "$fresh/": "../../",
+    "preact"<EMAIL_ADDRESS>+    "preact/"<EMAIL_ADDRESS>+    "@preact/signals": "https://esm.sh/*<EMAIL_ADDRESS>+    "@preact/signals-core": "https://esm.sh/<EMAIL_ADDRESS>+  },
+  "compilerOptions": {
+    "jsx": "react-jsx",
+    "jsxImportSource": "preact"
+  }
+}
diff --git a/tests/fixture_build_static/dev.ts b/tests/fixture_build_static/dev.ts
new file mode 100755
index 0000000..2d85d6c
--- /dev/null
+++ b/tests/fixture_build_static/dev.ts
@@ -0,0 +1,5 @@
+#!/usr/bin/env -S deno run -A --watch=static/,routes/
+
+import dev from "$fresh/dev.ts";
+
+await dev(import.meta.url, "./main.ts");
diff --git a/tests/fixture_build_static/fresh.gen.ts b/tests/fixture_build_static/fresh.gen.ts
new file mode 100644
index 0000000..b321c0e
--- /dev/null
+++ b/tests/fixture_build_static/fresh.gen.ts
@@ -0,0 +1,15 @@
+// DO NOT EDIT. This file is generated by Fresh.
+// This file SHOULD be checked into source version control.
+// This file is automatically updated during development when running `dev.ts`.
+
+import * as $0 from "./routes/index.tsx";
+
+const manifest = {
+  routes: {
+    "./routes/index.tsx": $0,
+  },
+  islands: {},
+  baseUrl: import.meta.url,
+};
+
+export default manifest;
diff --git a/tests/fixture_build_static/main.ts b/tests/fixture_build_static/main.ts
new file mode 100644
index 0000000..dedce9c
--- /dev/null
+++ b/tests/fixture_build_static/main.ts
@@ -0,0 +1,10 @@
+/// <reference no-default-lib="true" />
+/// <reference lib="dom" />
+/// <reference lib="dom.iterable" />
+/// <reference lib="dom.asynciterable" />
+/// <reference lib="deno.ns" />
+
+import { start } from "$fresh/server.ts";
+import manifest from "./fresh.gen.ts";
+
+await start(manifest);
diff --git a/tests/fixture_build_static/routes/index.tsx b/tests/fixture_build_static/routes/index.tsx
new file mode 100644
index 0000000..de8f384
--- /dev/null
+++ b/tests/fixture_build_static/routes/index.tsx
@@ -0,0 +1,3 @@
+export default function Home() {
+  return
text
;
+}
diff --git a/tests/fixture_build_static/static/duplicate.txt b/tests/fixture_build_static/static/duplicate.txt
new file mode 100644
index 0000000..5496f6f
--- /dev/null
+++ b/tests/fixture_build_static/static/duplicate.txt
@@ -0,0 +1 @@
+it doesn't work
\ No newline at end of file
diff --git a/tests/test_utils.ts b/tests/test_utils.ts
index ba5e64c..a9dd393 100644
--- a/tests/test_utils.ts
+++ b/tests/test_utils.ts
@@ -449,6 +449,19 @@ async function spawnServer(
   return { serverProcess, lines, address, output };
 }

+export async function recreateFolder(folderPath: string) {
+  try {
+    await Deno.remove(folderPath);
+  } catch {
+    // ignore
+  }
+  try {
+    await Deno.mkdir(folderPath, { recursive: true });
+  } catch {
+    // ignore
+  }
+}
+
 export async function runBuild(fixture: string) {
   const outDir = path.join(path.dirname(fixture), "_fresh");
   try {
--
2.42.0


Assert 400 error on duplicate lookup entry creation

This is a bad request, not an internal server error. Now that we properly handle the error, return the right response code.

May consider 409 instead of 400 here for better semantic meaning.
:+1:

(reference: http://www.restapitutorial.com/httpstatuscodes.html)

@heckj reading through that description, it specifies conflicts with the current state of a resource, whereas I take this route/code to mean "create a new resource, no you can't" rather than "update this resource, no there's a conflict" ?

:+1:

:+1:

merge this PR to let Jenkins pass


Fix #encoding error by oracle_enhanced

An error occurs because Oracle cannot omit FROM.
$ bin/rails c
Loading development environment (Rails <IP_ADDRESS>)
ruby 2.3.3 [1] pry(main)> ::ActiveRecord::Base.connection.select_one("SELECT '' AS str;").values.first.encoding
   (2.4ms)  SELECT '' AS str;
ActiveRecord::StatementInvalid: OCIError: ORA-00911: invalid character: SELECT '' AS str;
from stmt.c:243:in oci8lib_230.bundle

In the case of Oracle, I want to execute the following SQL:
$ bin/rails c
Loading development environment (Rails <IP_ADDRESS>)
ruby 2.3.3 [1] pry(main)> ::ActiveRecord::Base.connection.select_one("SELECT dummy FROM DUAL").values.first.encoding
   (0.9ms)  SELECT dummy FROM DUAL
=> #<Encoding:UTF-8>

ref. https://github.com/rsim/oracle-enhanced

Hi @mshibuya, Thanks for maintenance.
I also want this patch. Is there any information you need to merge?

Merged in, thanks!

Thanks for your merging 💚 💛 ❤

Thank you for merged :)


Use single command to run Mocha tests

Related to work in https://github.com/artsy/force/pull/3864 and #3877
This PR updates scripts/test.sh to run mocha tests with a single command, and changes circle parallelism to 2 containers (one for jest, one for Mocha).
This change led to a lot of failing tests, inconsistently failing items have been x'd and a few linting errors and other issues have been fixed.

I'm interested in getting some insights on how this affects CI length and what the general per PR delta will be. Once this CI run is done maybe we can kick it off a few more times to see an average run-time.

Yes, we do see an increase of around 1-2 min for the test step with this change. I have mixed feelings about this because there is a tradeoff, but ultimately I think this pr makes the test process more surefire.
Pros:

Free up one circle container
Full Mocha suite can be run with a single command
We will no longer miss test files in the /src directory
It is easier to spot tests that are not tearing down correctly

Con:

Takes a little longer to run test suite

I'm interested to track the median job time in Circle, which is currently 2:10 min. If we notice this has a significant change we can always go back to 3 containers and split out desktop from mobile tests.


Low Security Fixes for login page, and SSL link to SFDC

Updated link to SFDC and login form autocomplete="off" fix for older browsers

Right on. Thanks!


is no longer allowed in client

Using pivpn -a nopass -n name-here -d 365 the response recieved is Name can only contain alphanumeric characters and these characters (.-@_).
@ and _ work as expected but - gives the above error

Thanks, apparently, there is a missing \ before - here.

This error occurs in interactive mode as well: pivpn add nopass

Thanks, apparently there is a missing \ right before the fourth - here.

I think this works differently than you intend: After patching makeOVPN.sh with the change
you propose it also accepts '' as a valid char (e.g. 'foo\bar' is not refused).
I think a better pattern is this: [^a-zA-Z0-9.@_-]
Have a look here as well (according to this there is no real escaping within character classes in Posix ERE (which IIRC is what bash is using)):
https://stackoverflow.com/questions/399078/what-special-characters-must-be-escaped-in-regular-expressions

Thanks for the insights @mquirin, so since - is a metacharacter used to represent a range, you have to place it just after ^ or as the last character if you want the shell to interpret it as a literal -.

Test branch merged into master.
Closing


store: check if peers need to split after initialization

check if peers need to split after initialization.

/run-all-test


Lseg - Bucuresti appears twice as location

ENVIROMENT: production
URL: https://scrapers.peviitor.ro/src/lseg/index.html
Browser: Chrome
Device: laptop
OS: Windows 10
STEPS TO REPRODUCE:

Open URL in browser
Click on 'Run scraper'
Check location for Senior Analyst - Global Share Plans

EXPECTED RESULTS:
Bucuresti should appear only once as location for Senior Analyst - Global Share Plans
ACTUAL RESULTS:
Bucuresti appears twice as location for Senior Analyst - Global Share Plans

Deprecated!


Postgres Example

Is there interest in including a postgres example?  I created one analogous to the redis example (performs INSERT or SELECT) as an exercise, and it is essentially ready for PR.

Yes please! I tried doing it myself but kept hitting blockers with regards to app configuration as seen at #464

I put up #490. I haven't tested enough yet, but in theory I didn't do anything new from the redis example that I initially cloned.