MemberNameEqualsClassName factory function exemption doesn't work on generics

Expected Behavior
The MemberNameEqualsClassName rule is documented as Factory functions that create an instance of the class are exempt from this rule.  Would expect this exemption to apply even if the class in question has generics.
Observed Behavior
A generic class with a generic factory function is reported as violating the rule.
Steps to Reproduce
This code triggers the rule:
data class FieldInfo<T>(
    val alias: String,
    val extractor: (String) -> T
) {
    companion object {
        // this complains about MemberNameEqualsClassName
        fun <T> fieldInfo(
            alias: String,
            extractor: (String) -> T
        ): FieldInfo<T> {
            return FieldInfo(alias, extractor)
        }
    }
}

Removing the generic does not trigger the rule:
data class FieldInfo(
    val alias: String,
    val extractor: (String) -> String
) {
    companion object {
        // this does not complain about MemberNameEqualsClassName
        fun fieldInfo(
            alias: String,
            extractor: (String) -> String
        ): FieldInfo {
            return FieldInfo(alias, extractor)
        }
    }
}

Context
The above example is a trivial reproduction, in our real world use case we have inline factory functions with reified type parameters that provide default extractor implementations. (eg inline fun <reified T> fieldInfo(alias: String) = FieldInfo(alias, defaultImpl()) where defaultImpl is an inline function that returns different implementations based on T::class)
Your Environment

Version of detekt used:  1.16.0
Version of Gradle used (if applicable): n/a, maven/antrun config here: https://github.com/trib3/leakycauldron/blob/main/parent-pom/pom.xml#L1469-L1505
Gradle scan link (add --scan option when running the gradle task): n/a
Operating System and version: ubuntu 21.04
Link to your project (if it's a public repository): n/a, but public maven parent pom linked above

It appears that typeReference.text == klass.name (https://github.com/detekt/detekt/blob/main/detekt-rules-naming/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/naming/MemberNameEqualsClassName.kt#L104) is false because typeReference.text evaluates to FieldInfo<T> and klass.name evaluates to FieldInfo

Thanks for the research! Do you have the time to provide a PR to fix it?


Missing range field in CompletionItem

Reported: https://github.com/Microsoft/language-server-protocol/issues/148
Fixed: https://github.com/Microsoft/language-server-protocol/commit/c83f10657833dc715cebf9efc39dc11371066739
Broken: https://github.com/Microsoft/language-server-protocol/commit/b082a3bd761f7c50db0b538e954ac467e8aa5ba8
Probably a bad merge

@dbaeumer Could you clarify whether the current protocol.md is correct on this regard or not? We are updating LSP4J to support the version 3.0 and it is confusing.

Sorry for the confusion here. I already updated the release notes to clarify this. The protocol doesn't support a range field. This was introduced to allow VS Code to support snippets. For the protocol we decided to go with a less breaking approach to keep the protocol more compatible in form of its structure. So for the protocol this means:

no range field
an insertTextFormat property denoting with the primary text to insert is plain text or a snippet
the insertTextFormat property applies to both the insertText and the textEdit.

So if you want to insert a snippet via a textEdit set insertTextFormat to Snippet. This allows you to specify a range with a snippet.

The range field on CompletionItem is still referenced in multiple places:
https://github.com/Microsoft/language-server-protocol/blame/d72d515fbf828b06c2a0b79f5d0234e64f12b523/protocol.md#L10
https://github.com/Microsoft/language-server-protocol/blame/d72d515fbf828b06c2a0b79f5d0234e64f12b523/protocol.md#L1788
I don't understand why only snippet format would need a range - how does the editor know what to replace with insertText (or fallback of label) if there is no range? Does it assume everything from the request position up to the next whitespace?

@natebosch thanks for pointing this out.
No, both snippet and plan text can provide a range. If you want to provide a range (we do some defaults based on the cursor position) then you need to provide a text edit. If not range is required you can use insertText or label.


Per App Admin Access

I know this has been brought up before, but I really need per app admin access.
Essentially I have multiple developers from different companies.  I do not want developers from project A to be able to mess w/ project B.     This is sort of doable with deployment only keys, but is becoming a HUGE pane when they are trying to debug things.  If they could simply ssh<EMAIL_ADDRESS>enter appname they could do their debugging much simpler.
I would also like them to be able to do something like ssh<EMAIL_ADDRESS>redis:delete appname and ssh<EMAIL_ADDRESS>redis:create appname (since redis is linked to the appname app).
Any ideas of how to do this?

Allow to enter or exec is relatively easy to add, because everything is there. The problem is with other commands, but is still doable, but how it should work. redis:create operates not on appname, but dbname.

We could add developer keys which would have more privileges.

Yes.  It looks like it would be really easy to expand the access acl... something like this (below) would allow you to add an optional appname:
case "$1" in
  access:add)
    verify_max_args 2 "$@" # I changed max args to 2

    # check if arg 2 is set, if not.. act normal
    if [ -z ${2+x} ];
    then
      add_ssh_key "admin-$2"
      info "$FINGERPRINT added as an admin-$2"
    else
      add_ssh_key "admin"
      info "$FINGERPRINT added as an admin"
    fi
    ;;

Then in verify-command... do something like that:
# not real bash... just spit balling

if `$NAME` has `admin-` in it...
then
  APPNAME = eerything after `admin-`

  # Allow normal git deploy stuff here

  if $APPNAME == $2
  then
    allow the command
  else
     fail 'command not allowed
  fi
fi

It's not that simple, because verify-command works on commands not on APPNAME.
This would allow you to access single app per-key.
I still think that current deployment keys by adding FINGERPRINT to additional file that will mark it as key with elevated permission allowing to access some selected/filtered commands.

Verify-command looks like it checks $NAME though... this name is either admin or deploy... right?
So if we make the $NAME something like admin-appname instead of just plain admin (set in access:add i think) then we can pull appname from $NAME by spitting after admin-..

Yes. It checks, but with admin-appname it forces ssh key to be used only by single app and that I don't like.

Oh I gotcha... I didn't think of that.  I was thinking you could set it multple times for the different apps, but I don't think you can since you can't sent the fingerprint more than once.

Yes. Fingerprint is unique. Name is simply used to distinguish key type.

So something very similar to how you did the ~dokku/appname/DEPLOY_ALLOWED file, but have do something like (below) in verify-command:
#!/bin/bash

source "$(dirname $0)/vars"

cat

[[ -z "$NAME" ]] && [[ $(id -un) != "root" ]] && fail "Access denied. No user supplied."

# http://unix.stackexchange.com/a/67900
if [ "$NAME" != "developer" ] && [ "$NAME" != "deploy" ]; then
    # Allow everything
    exit 0
fi

[[ -z "$FINGERPRINT" ]] && fail "Access denied. No fingerprint supplied."

case "$1" in
    git-hook)
        APP="$2"
        ;;

    git-*)
        APP="$(echo "$2" | perl -pe 's/(?<!\\)'\''//g' | sed 's/\\'\''/'\''/g')"
        ;;

    *)
        if [[ "$NAME" == "developer" ]]; then
          APP="$2"
        else
          fail "Access denied. Please login as an admin."
        fi
        ;;
esac

check_app_name "$APP"

if ! is_fingerprint_allowed "$FINGERPRINT"
then
    fail "Access denied. You don't have permission to access this app."
fi

I tested the above by creating adding a deploy key, then manually changing my authorized_keys name to be developer instead of deploy... works well.
This allows you to just add the developer fingerprints the DEPLOY_ALLOWED file and it would work.  You may want a separate DEVELOPER_ALLOWED file though too.

It's infact done. It's still requires some tests, but should work already :)


Update Posts “a-scheduled-post”

Automatically generated by Netlify CMS

👷 Deploy Preview for strong-beijinho-c4d917 processing.

Name
Link

🔨 Latest commit
b43a5f8af500f40fd065ac0fb1e10724fbeb9cde

🔍 Latest deploy log
https://app.netlify.com/sites/strong-beijinho-c4d917/deploys/65eab2e85399ca00083c4f42


Output issues

Current Behavior

Not all cities have data for all the values that can be processes by measure. For instance Madrid does not a value for buffered lane.
All the values are decimal, which does not bring additional information to the reader.
The headers contain a lot of nan for no reason.

track,nan,retail,nan,people,transit,lane,core_services,recreation,buffered_lane,nan,state,nan,nan,sharrow,city,nan,opportunity,country
45.951,,50.24194171,,54.61762189,71.04434298,99.229,76.33477133,67.96172124,,,MD,,24334.196,361.299,Madrid,,71.11145219,Spain

Expected Behavior

Add default values for the missing fields.
Rounding them to the closer integer would be enough.
Remove the nan fields.

I believe #11 will fix all these issues.
We will just need to create a function to populate the ScoreCard model from a dataframe.


Update help text for sendgscc

removed exec to reflect latest version
fixes issue https://github.com/biblepay/biblepay-evolution/issues/18

Thanks.


Documentation - mjml-breakpoint "try it live" link

The "try it live" link here:
https://mjml.io/documentation/#mjml-breakpoint
links to a head fonts example and not an example for <mj-breakpoint />
https://mjml.io/try-it-live/components/head-font

Hi @rufranop thanks for reporting this, it will be fixed in the next website release 👍


fix creditCarStrictMode (no way to delete the 16th digit of a visa)

tested on window (edge, firefox, opera, chrome)
tested on mobile Android (edge, chrome, vivaldi, opera, opera mini, firefox)
tested on Iphone (safari)

thanks, released in 1.6.0


incompatible encoding regexp match (GBK regexp with UTF-8 string)

I install all those thing step by step.
When I try to build the theme, with  bundle exec jekyll serve
it occurs

Jekyll 3.4.5 erro:  incompatible encoding regexp match (GBK regexp with UTF-8 string)

My local PC base on Chinese language.

just copy them folder to root , like D:
without any Chinese character.
Done.


Executor failure during staging leaves orphaned executor, preventing recovery

Executor log shows process has exited, however mesos state shows it as staging. This prevents framework from recovering as it is unable to retrieve the resources.

This is interesting. So, just to clarify: executor never launched ? (because fetcher failed to fetch JRE which is required for executor launch).

I've seen this happen several times as I'm testing a deployment. Most recent shows node-0 and node-0-template in STAGING. Stdout logs show that the child process exited, but the container still hangs around.  I've also seen the task in FAILED state yet still under active tasks in Mesos. The framework appears to be trying to recover, but is unable to get the port reservation it needs because there appears to be an orphaned reservation occupying the port range from the failed task.  The latter may be an issue with mesos that is just a side effect of the initial error.  In any case the only way I'm able to recover is to assassinate the slave machine.

@dylanwilder Logs would be helpful. I'll find the ticket. Thanks.

Ok, I've figured out the root cause here (should note i'm on version 1.0.17-3.0.8). There's two issues, the first on the deploy, the second on the inability to recover.

I am updating the executor configuration (i.e. to change the jre or cassandra version). This triggers a cluster rolling restart here.  Looks like the issue was fixed here, but this used to read getExecutor().withNewId().getExecutorInfo() which caused the updates to be out of sync.
This error causes the the task to FAIL, however the executor is orphaned.  The scheduler is unaware of it's existence but it is still consuming the executor port resource and the scheduler is unable to relaunch. killing the process loops back to (1)

Seeing as how (1) has been addressed already, is it possible that (2) has been fixed as well?

Looks like this code will always attempt to create a new executor.  Really it should be reusing the existing executor, however since we are not actually tracking the state of executors themselves this could lead to reverse problem.  It seems to me that executors should really be tracked as first class assets rather than as a reference from tasks. Thoughts?

Marking closed as #316 was merged


Allow for residual or solution tolerances

This PR allows for tolerances to be specified on either the solution x, or on the residual f(x). Normally, we'd use keywords but there are some remaining issues related to Cassette not being able to forcefully inline things. So, using @jkozdon's functor suggestion, which seems nice and sufficiently flexible. This PR also adds some type restrictions.

bors r+


Define problem statement for DNS Discovery

User Need
As a (type of user)
I want (some action)
so that (some result)
Value
Defining the problem helps the team understand what we are trying to solve.
Acceptance Criteria:

Agreed and documented problem statement(s)

Notes:

Will create multiple problems statements for discoveries.

Set of problem statements for further breakdown - https://docs.google.com/presentation/d/1nRyOex6tZL4FDOON1iltsHiIwlBcp6EUvLqYjipjI_s/edit?usp=sharing


Function names should say what they do

Fix for issue #23
Fix for Function names should say what they do

Ready to merge


Fix getTransactionReceipt for nonexistent transaction

If a receipt for a transaction that didn't exist was requested,
an error was thrown. Now it returns null like geth. I've modelled
the new code after the implementation of eth_getTransactionByHash,
which is clearly written to avoid the same issue there.
I've included a new test for this too (NB two tests fail, but
that's the case on master, too, so I've left those alone for
now).

Whoops, good call. Thanks @area!


styleUrls doesn't allow to link to external css file

Before this was working
component.ts
  styleUrls: [
    './my_framework/default.css',
    './components/component/component.css'
  ]

now with this code
  moduleId: module.id,
  styleUrls: [
    './my_framework/default.css',
    './component.css'
  ]

I get this error in browser:
"EXCEPTION: Failed to load http://localhost:5555/components/component/my_framework/default.css"

I tried these urls with no success: my_framework/default.css, /my_framework/default.css, ../../my_framework/default.css.

you can use styles: [] instead of styleUrls: [] and require the file as string styles: [ require('./component.css') ]

require adds .js to the end. Actually it was my mistake - I had to add ../../../ instead of ../../. Relative paths are working.


Error NOTFOUND antena shows

Something happened on the recent commits, error will be fixed in the next commit

Ok, thanks for your time and making this script free

many times this happens

reported error cannot be reproduced however it may be fixed by 256b8182ce24dcb08832df7da6c8a966e98adac0, initial error is bogus, closing issue


Reorganization of the selection-classes

I just re-added the simple lasso-selection. I will keep this as draft right now as I need to extract a base-class for different selection-types. For doing that I also have to make actual typescript classes from that without defining all methods as local variables in the closure.

I'd suggest you submit the lasso tool implementation separately from an attempt to rearchitecting the code.

After adding the lasso-tool, i started extracting a base-class for all selection-tools. The simple lasso-selection now is handled here:
https://github.com/playcanvas/supersplat/pull/269

Not planning on this reorg.


fix alt tags of speaker cards

Describe the bug
alt tags of speaker cards are hardcoded
To Reproduce
Steps to reproduce the behaviour:

Go to components
Click on speaker components
check alt tags

Expected behavior
alt tags either be dynamic or if presentational only then do not show the alt tags
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

I would like to contribute on this. Can you assign me this issue?

I would like to contribute on this. Can you assign me this issue?

Thank you. My suggestion please close the existing issue you have picked . Once that is close will assign a new issue.


Modify notification window heigh calculation

Add a notification list management in order to calculate notification window height at runtime.

@lneir , can you please review this one? Thanks!

@lneir , I´ve applied your comments & also tested with Jimmy´s script for burst message.
Could you please review?

lgtm


chore: add release change log generation tool

Details
This adds a script to generate a changelog during release. This copies from the optional script we have for Accessibility Insights for Web releases.
It auto-generates the tester, verified, dev, commit, pr, change description, group, version, and date columns for all the changes between the current release and the previous.
To run it, in the root of the action repo you run the following command, for this example I'm using the previous two release tags:
node ./tools/get-change-log-for-release.js --from v3.1.0 --to v3.1.1
This is the resulting file from that command:
change-log.v3.1.0-v3.1.1.csv
Once the table is generated and filtered, it looks like this (an example of what the previous release's table would have looked like):

Motivation
Additional tooling to simplify the release process
Context
This will work the same for both the GH action and the ADO Extension.

Pull request checklist

[n/a] Addresses an existing issue: Fixes #0000
[n/a] Added relevant unit test for your changes. (yarn test)
[n/a] Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
[n/a] Ran precheckin (yarn precheckin)
[x] Described how this PR impacts both the ADO extension and the GitHub action

Codecov Report

Merging #1381 (424adef) into main (93bb0f1) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head 424adef differs from pull request most recent head d7c6e21. Consider uploading reports for the commit d7c6e21 to get more accurate results

@@           Coverage Diff           @@
##             main    #1381   +/-   ##
=======================================
  Coverage   91.97%   91.97%
=======================================
  Files          62       62
  Lines        1607     1607
  Branches      206      206
=======================================
  Hits         1478     1478
  Misses        129      129

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Update privacy notice for EOL (EXPOSUREAPP-14955)

Ticket.
Please compare the contents of the word documents found in the ticket with the changes made to the privacy files.

It would be good to have a new open PR to make comments on the text contents.


[1.12rc4] Exposed ports for containers when not deployed through a service

docker version:
Client:
 Version:      1.12.0-rc4
 API version:  1.24
 Go version:   go1.6.2
 Git commit:   e4a0dbc
 Built:
 OS/Arch:      linux/amd64

Server:
 Version:      1.12.0-rc4
 API version:  1.24
 Go version:   go1.6.2
 Git commit:   e4a0dbc
 Built:
 OS/Arch:      linux/amd64

docker info:
Containers: 3
 Running: 2
 Paused: 0
 Stopped: 1
Images: 3
Server Version: 1.12.0-rc4
Storage Driver: devicemapper
 Pool Name: docker-253:0-134665692-pool
 Pool Blocksize: 65.54 kB
 Base Device Size: 10.74 GB
 Backing Filesystem: xfs
 Data file: /dev/loop0
 Metadata file: /dev/loop1
 Data Space Used: 607.3 MB
 Data Space Total: 107.4 GB
 Data Space Available: 39.16 GB
 Metadata Space Used: 1.851 MB
 Metadata Space Total: 2.147 GB
 Metadata Space Available: 2.146 GB
 Thin Pool Minimum Free Space: 10.74 GB
 Udev Sync Supported: true
 Deferred Removal Enabled: false
 Deferred Deletion Enabled: false
 Deferred Deleted Device Count: 0
 Data loop file: /var/lib/docker/devicemapper/devicemapper/data
 WARNING: Usage of loopback devices is strongly discouraged for production use. Use `--storage-opt dm.thinpooldev` to specify a custom block storage device.
 Metadata loop file: /var/lib/docker/devicemapper/devicemapper/metadata
 Library Version: 1.02.107-RHEL7 (2015-10-14)
Logging Driver: json-file
Cgroup Driver: cgroupfs
Plugins:
 Volume: local
 Network: null host bridge overlay
Swarm: active
 NodeID: 4bg5sh5kw24bg906jbmqe1wl3
 IsManager: Yes
 Managers: 1
 Nodes: 1
 CACertHash: sha256:d38cc073759e00ac76b865b7aee359f5084c022c57f635221a7cbc7f253095b4
Runtimes: runc
Default Runtime: runc
Security Options: seccomp
Kernel Version: 3.10.0-327.el7.x86_64
Operating System: CentOS Linux 7 (Core)
OSType: linux
Architecture: x86_64
CPUs: 1
Total Memory: 993 MiB
Name: docker-platform-kitchen-1.local
ID: TCOH:Z4RR:N3GT:BAWK:45FX:LACB:Z3UM:YHRL:24XQ:J3M5:QUKN:PLZY
Docker Root Dir: /var/lib/docker
Debug Mode (client): false
Debug Mode (server): false
Registry: https://index.docker.io/v1/
WARNING: bridge-nf-call-ip6tables is disabled
Insecure Registries:
 <IP_ADDRESS>/8

Additional environment details (AWS, VirtualBox, physical, etc.):
Tested on physical and also VirtualBox.
Steps to reproduce the issue:

Init a swarm on host (docker swarm init)
Run an image that expose a port on host e.g:

docker run --name nexus -d -p 80:8081 sonatype/nexus3:latest

Try to to connect to the exposed port on host using some network utilities e.g

telnet localhost 80

Describe the results you received:
[root@docker-platform-kitchen-1 ~]# telnet localhost 80
Trying ::1...
Connected to localhost.
Escape character is '^]'.
Connection closed by foreign host.

However the iptables rules generated by docker seems correct:
[root@docker-platform-kitchen-1 ~]# iptables -t nat -L -n -v
Chain PREROUTING (policy ACCEPT 102 packets, 58752 bytes)
 pkts bytes target     prot opt in     out     source               destination
    1    44 DOCKER     all  --  *      *       <IP_ADDRESS>/0            <IP_ADDRESS>/0            ADDRTYPE match dst-type LOCAL

Chain INPUT (policy ACCEPT 102 packets, 58752 bytes)
 pkts bytes target     prot opt in     out     source               destination

Chain OUTPUT (policy ACCEPT 104 packets, 33844 bytes)
 pkts bytes target     prot opt in     out     source               destination
    0     0 DOCKER     all  --  *      *       <IP_ADDRESS>/0           !<IP_ADDRESS>/8          ADDRTYPE match dst-type LOCAL

Chain POSTROUTING (policy ACCEPT 104 packets, 33844 bytes)
 pkts bytes target     prot opt in     out     source               destination
    0     0 MASQUERADE  all  --  *      !docker_gwbridge  <IP_ADDRESS>/16        <IP_ADDRESS>/0
    0     0 MASQUERADE  all  --  *      !docker0  <IP_ADDRESS>/16        <IP_ADDRESS>/0
    0     0 MASQUERADE  tcp  --  *      *       <IP_ADDRESS>           <IP_ADDRESS>           tcp dpt:7777
    0     0 MASQUERADE  tcp  --  *      *       <IP_ADDRESS>           <IP_ADDRESS>           tcp dpt:8081

Chain DOCKER (2 references)
 pkts bytes target     prot opt in     out     source               destination
    0     0 RETURN     all  --  docker_gwbridge *       <IP_ADDRESS>/0            <IP_ADDRESS>/0
    0     0 RETURN     all  --  docker0 *       <IP_ADDRESS>/0            <IP_ADDRESS>/0
    0     0 DNAT       tcp  --  !docker0 *       <IP_ADDRESS>/0            <IP_ADDRESS>/0            tcp dpt:7777 to:<IP_ADDRESS>:7777
    0     0 DNAT       tcp  --  !docker0 *       <IP_ADDRESS>/0            <IP_ADDRESS>/0            tcp dpt:80 to:<IP_ADDRESS>:8081

Describe the results you expected:
When running the container in an non-swarm initialized environment i got this result:
root@docker-platform-kitchen-1 ~]# telnet localhost 80
Trying ::1...
Connected to localhost.
Escape character is '^]'.
get /
HTTP/1.1 400 HTTP/0.9 not supported
Content-Length: 0
Connection: close
Server: Jetty(9.3.7.v20160115)

Is it possible in a swarm environment to run containers and access exposed ports on host when these containers are not created using the service api?
Thanks for your feedback.

For me (on master), I always get an immediate closure:
Trying <IP_ADDRESS>...
Connected to <IP_ADDRESS>.
Escape character is '^]'.
Connection closed by foreign host.

Also note that localhost is a special case and is handled by a proxy process.

I also did a test on the primary IP interface of the host and i got the same result.


Release DMG build

Created target "Release" in Xcode project to automate building project, copying binary to a staging directory "dist" and creating a DMG image for release.

@AhiyaHiya what is this? ...maybe by mistake?

Hi Mathias, this pull request was simply for automating making the DMG, so it is up to your discretion whether or not you pull the changes into your branch. :)


Type 1 - Add showTabs argument to workbook publish method

Summary
Allow users to control the showTabs argument when initially publishing a workbook. This is possible in the REST API, but currently in TSC we can only modify this after the fact.
Request Type
Type 1: support a REST API:
https://help.tableau.com/current/api/rest_api/en-us/REST/rest_api_ref_publishing.htm#publish_workbook
Description
The default option when publishing a workbook is to not show tabs. This is resulting in a poor UX as Tableau Server seems to not show views to users in the workbook content url despite having access to each of the views, thus making it impossible to navigate to a view through the workbook.

Whoops. Didn't acknowledge that was a feature of the item directly and can initialize there. Sorted!


sensors: convert grove ADC sensors to devicetree

Also add a nexus map so we can reference Arduino analog inputs in overlays.
Fixes #20426.

@MaureenHelm and @galak can you take a look?


Add Support for Commands API

Add support for the Commands API.

Added in v1.2.0.

@jemc thank you Joe!  Closing this issue.

Sorry, I meant to close it! :wink:

@jemc no worries!


OneDrive/SharePoint File Picker not working for DocumentSets

Hi all,
Figured I should cross post here for extra visibility since this would apply to the API.
I am in the process of onboarding a client using SharePoint and everything is working with the exception of DocumentSets. In my local tenant on O365, I am unable to reproduce this issue, but in the client's tenant, DocSets are being treated as "files" and not folders when clicking on them in the FilePicker api.
Below is some triage I did in the client's tenants, and they made a comment about a setting they may have changed.
Hopping for any guidance or assistance on this one
https://github.com/OneDrive/samples/issues/57

After reproing this without the sdk itself (which appears to be a link builder at the end of the day), we opened a ticket with Microsoft. The ticket has still not been triaged and for the time being we wrote our own (less featured) file picker using the graph API.
Hope to use this library again soon but for the time being, we are unable to use this with specific clients due to bugs on the file picker side.

Hey @nicolasiscoding , I'm going to address this one in the other repository you mentioned above.


Skill handler only supports a single adapter

Skill handler has a hard dependency on a single bot adapter, making it not possible to mix multiple adapters with skills. This happens both for composer and for code-first dialogs.
The issue is to make changes to allow multiple adapters on a root bot and skills routing to the right adapter.

Potential approaches include 1) making skill handler take all the registered adapters or 2) create a multiplexer adapter that contains all adapters and make the runtime use that for multiple adapters. If the multiplexer adapter does the multiplexing, the skill handler can continue to receive the single (multiplexer) adapter and rely on the adapter.

Known limitation.


ColumnsNameFinder

I want have a util class such as the demo of TablesNamesFinder.java
Now, I need parser the sql for my project. I want have a class that can find all used columns and it's alias within an statement.
Please teach me how to writer the class.
Thank you very march!

Look here: https://stackoverflow.com/questions/40908062/parsing-table-and-column-names-from-sql-hql-java
Hope that helps.


Please import OSC

Hello STYLY team,
I hope this message finds you well. I am currently developing an application for the Apple Vision Pro that aims to synchronize audio and spatial effects. However, I have encountered a limitation regarding MIDI device connectivity.
As it is not physically possible to connect MIDI devices directly to the Vision Pro via USB, I propose an alternative approach. I intend to use TouchDesigner to receive MIDI signals and convert them into OSC (Open Sound Control) messages, which can then be transmitted to and received by the Vision Pro. This method would allow us to effectively integrate MIDI with the Vision Pro, enabling synchronized audio and spatial effects within the application.
To achieve this, I would like to request the implementation of OSC support in the Apple Vision Pro. This feature would greatly enhance the capabilities of the Vision Pro and open up new possibilities for interactive applications that rely on MIDI data.
Thank you for considering this request. I am looking forward to any assistance you can provide in implementing OSC support. Your efforts in making the Vision Pro more versatile and user-friendly are highly appreciated.
https://openupm.com/packages/jp.keijiro.osc-jack/

Thank you for your request. We're working on including OSC featrure.

Great!! I am looking forward to!!

@scs-yasu
Hi, now STYLY supports receiving OSC message in contents. Please check my simple example to capture how to build content.
https://github.com/ku6ryo/OSC-Sample_STYLY-for-VisionPro

wow amazing!!! I wll try!!


Warnings after react 16.3.0 update

Hey 😄
We updated our project with react 16.3.0 version and activated the StrictMode (https://reactjs.org/docs/strict-mode.html) to see the new warnings issued.
I have some issued which (I think) concerns hoc-react-loader :
componentWillMount: Please update the following components to use componentDidMount instead: Loader([...])

componentWillReceiveProps: Please update the following components to use static getDerivedStateFromProps instead: Loader([...])

Am I wrong ? 😓

Hi @ebriand 😃
You are right !
You can create a PR if you want to fix that on your own.
Or I will look into it when I will have the time to (next week maybe ?)


error in load plugin

Hello I had an error when I wanted to load my plugin it says "o.type is not a constructor" but when I was checked in the codes of the plugin I did not find "o .type "can you help me?

@name here

class 'whatever goes here'
has to be same


Not setting uploaderID with TorrentJSON when Uploader == nil

From the picture, when uploading, we set only the UploaderID to the Torrent struct. Afterward, for ES indexing, we do torrent.ToJSON(), but since the Uploader hasn't been set, the UploaderID is 0. This results in wrong UploaderID in ES index.

Maybe related: Can you also check torrent ID 924740 "../../delete_me.torrent🙂5" on dev, I created it under the username anime_is_bad but it doesn't even show in my profile page, I don't remember if I checked "hidden". Don't know what and how I did it.

Fixed by #930


WIP: Fix destructive Editing

Tries to fix #55 .
Main idea: When searching for the left hand side of in a line, it does not only have to match $left, but also at least one additional whitespace or the $assign_string
As it is deep change in sed commands, it is very important, that we test this commit carefully. Thank you :-)
I still see a problem in zathurarc. The line
 set recolor                     "false"

isn't removed and I have no idea why… Maybe someone else?

I have been in the mood to torture my brain today and this problem might be right challenge, but I don't understand where is the problem? Can you add example of original, wanted result and actual result config file?
Side note: This is probably the best time to start with writing tests for changes so we can slowly add some edge cases and implement new features without fear (or at least with less fear ;) )

I can't reconstruct my problem anymore....
I'm waiting for #46 to be accepted and will then rebuild this PR.

As we finally merged #46 and #48, we are now ready to work further on this PR.
It is ready to be merged, but I would be happy to see your review and feedback.

I tried to get through all changes and it looks OK, at least in theory.
I'm pretty confident that it is ok and would work, but not 100 %. Is this PR urgent or we can try to introduce some tests first which will confirm this is OK?
Btw. I'm not familiar with ERE (I'm using PCRE where I can) so I didn't check that line but I agree with it in spirit :)

Is this PR urgent or we can try to introduce some tests first which will confirm this is OK?

I agree. It's better to apply proper fixes instead of introducing new bugs.
See #57 for discussion about tests.


BuildFilesAreOrderedRule crash

XCLinting/BuildFilesAreOrderedRule.swift:57: Fatal error
Looks like something is sneaking past the regular expression. It's quite complex, so that isn't shocking.
Reported by @nighthawk

Addressed with 8cf9d65658a34e37639f65f0a6e0cd3001bf6350

(well, not addressed, but debugging information added and it will no longer crash. Underlying issue remains)

@mattmassicotte just to say, thanks for this awesome project! ❤

@iby Thank you - I'm so glad you are liking it!


Feature: Completion with HOW method only if ^ supplied by user

Problem:
"toto".<Tab> -> scroll with all HOW method
There are a lot HOW method so it is annoying to find your own method in all that
Solution:
"toto".<Tab> -> scroll on class methods
"toto".^<Tab> -> Scroll on HOW methods

Good idea!


@typeparam does not work in Razor Component with where constraint after VS 2022 17.5

@typeparam with a where constraint does not work in versions of VS 2022 after 17.5.   As per this document: https://learn.microsoft.com/en-us/aspnet/core/blazor/components/generic-type-support?view=aspnetcore-7.0
cc: @guardrex https://github.com/dotnet/AspNetCore.Docs/issues/29883

@davidwengier Is this fixed by https://github.com/dotnet/razor/issues/8905?

Yep, looks the same. Closing as a duplicate, will be fixed in 17.8 P1


Handle KeyError in Capacitor calculate_217f_part_stress()

Expected Behavior
Calculation method continues to calculate remaining values even if there are missing input values used to select from dicts.
Actual Behavior
Method raises KeyError when missing input value prevents selecting dict value.  Selecting a new component/assembly does not 'reset' anything and RTK must be closed and re-opened.
Steps to Reproduce the Problem

Select a capacitor using the part stress method.
Don't fully populate all inputs.
Attempt to calculate part.


Converted JS code to ES6 and added prettier to improve code formatting

Description

Converted js code of all the files inside frontend/src/Components to es6 format.
Converted js code of all the files inside frontend/src/Pages to es6 format.
Added prettier to improve the code formatting.

Looks like, It still has conflicts. Would you like to resolve this? @agentraghav

Closing because of conflicts.
You can resolve the conflicts and re-open.

@Mr-spShuvo  ya for sure


Fork in Golden Set

Gertjanpfsense/pfsense [1787241] is a fork of pfsense/pfsense [3040416] and the forked repository is in our Golden Set. @craigcabrey and @stevekroh: Do you think we should replace 1787241 with 3040416 and re-compute the attribute thresholds from the Golden Set and the score of the 2m projects in reaper_results?

Here are the attribute values for both these projects:
Gertjanpfsense/pfsense

    architecture              0.06388888888888888
    community                 5
    continuous_integration    False
    documentation             0.12812189799670795
    history                   6.863636363636363
    license                   True
    management                0.0
    state                     active
    stars                     0
    unit_test                 0

pfsense/pfsense

    architecture              0.06388888888888888
    community                 6
    continuous_integration    False
    documentation             0.12811310403745566
    history                   50.186440677966104
    license                   True
    management                13.389830508474576
    state                     active
    stars                     783
    unit_test                 0

The attribute values are not significantly different to have an impact on the currently established thresholds. I am going to replace Gertjanpfsense/pfsense with pfsense/pfsense in our Golden Set.

The original intention was for pfsense/pfsense to be in the golden set, so that seems appropriate to me. Not sure how a fork got in there.


FIX: Error generating documentation with Dingo API

Fixed "PHP Fatal error: Method Illuminate\View\View::__toString(……) must not throw an exception" when using with Dingo API.

[Current coverage][cc-pull] is 86.42%

Merging [#59][cc-pull] into [master][cc-base-branch] will not change coverage

@@             master        #59   diff @@
==========================================
  Files             6          6
  Lines           442        442
  Methods          36         36
  Messages          0          0
  Branches          0          0
==========================================
  Hits            382        382
  Misses           60         60
  Partials          0          0

Powered by Codecov. Last updated by [49976fe...e24a1a1][cc-compare]
[cc-base-branch]: https://codecov.io/gh/mpociot/laravel-apidoc-generator/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/mpociot/laravel-apidoc-generator/compare/49976fe1ac79e7ca52234efbf5e7e130a97265f1...e24a1a1f53dae003a2065910007bbfeb652552fa?src=pr
[cc-pull]: https://codecov.io/gh/mpociot/laravel-apidoc-generator/pull/59?src=pr


Correct typo

Correct small typo

Thank you for correcting this typo, @Faulknerd!

No problem, happy to help


Prior Encounters dont show any details

When u select prior Encounter(Girls mapped by you) it shows no details of the mapped girl when you select her from the list.

Line 59, PatientRunnerFragment. Set showCompleteConfirmation to true.

Maping form decorates the patient object. Is not related to the Encounter records. Will need a Fragment/DialogFragment that shows a patient summary.

Possibly link to PatientList
Maybe short click view summary/long click edit


Implementing Video Filters (Blur, VIrtual Background)

What is the feature that you would like to see in the app? Please describe.
Are options for blur / virtual background something you have considered adding into twilio-video-app-react ?
Is your feature request related to a problem? Please describe.
Many of our users are requesting a way to have a blurred or virtual background.
Related Threads:
https://github.com/twilio/video-quickstart-ios/issues/409
https://github.com/twilio/twilio-video.js/issues/953

Use TensorFlow.js or something of the like.  I seriously doubt they're going to implement it in this demo app.

Hey @RusseII!
Thanks for the feature request. Unfortunately this feature is not on the roadmap for this app, but I'll let the team know that there is community interest in this feature.
As for implementing the feature, I've seen other apps use this drawBokehEffect function from this library: https://github.com/tensorflow/tfjs-models/tree/master/body-pix

Closing this - as this feature is not on our roadmap.

Hi Team, I would like to integrate Virtual background for video call in iOS app side. Could you please help me on this

Hi Team, I would like to integrate Virtual background for video call in iOS app side. Could you please help me on this


Add requestIdleCallback API to elemental-dom artifact

The requestIdleCallback API has been around for a reasonable length of time and implemented in Chrome and Firefox for a while (See https://caniuse.com/#search=requestIdleCallback). Closure already has externs for it at externs/browser/w3c_requestidlecallback.js and this has not seen any structural changes since 2015.
Would it be possible to include this API in elemental-dom artifact.

submitted as 2eff837a4da0c2896a489d61c8a4a66db002624f


perf: do not store network edges in state

Description:
Do not store network edges in state. We don't use this data anywhere, and it takes up a lot of memory.
Motivation and Context:
I was doing some debugging and analysing the memory heap. The thing that takes up the bulk of our memory (sometimes over 50%)is the network edge list. It grows considerably over time as the app remains open.
How Has This Been Tested?
Look at memory snapshot (taken from memory tab of devtools)before and after patch.
Types of changes:
Performance improvement
Checklist:

[x] My code follows the code style of this project.
[x] I have reviewed and updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes where needed.
[ ] All new and existing tests passed.
[x] My commits have been squashed into a concise set of changes.

Coverage increased (+0.009%) to 19.446% when pulling 6ee70053e87eac6fdad7d9c5d9cea8fd41e0cf4b on mrfelton:perf/dont-store-edges into 8cea6239785af101e78d78614a0763577685d30f on LN-Zap:master.

Coverage increased (+0.009%) to 19.446% when pulling 6ee70053e87eac6fdad7d9c5d9cea8fd41e0cf4b on mrfelton:perf/dont-store-edges into 8cea6239785af101e78d78614a0763577685d30f on LN-Zap:master.


🐛 Bug Report: TechDocs Live preview breaks down when clicking a page on sidebar

📜 Description
When changing page via sidebarmenu the techdocs page rendering falls apart.
👍 Expected behavior
It should render the page as the last screenshot without needed manually refresh the page.
👎 Actual Behavior with Screenshots
I tried TechDocs Live preview environment but it seems to break down massively just by changing page from sidebar
When starting up the environment, everything is fine:

After clicking World! from the sidebar it breaks down:

After refreshing the page it's fine again:

👟 Reproduction steps
I started the environment by running:
npx @techdocs/cli@latest serve

I'm pretty sure that I'm using the latest released techdocs cli package:
@techdocs/cli: 1.4.1
📃 Provide the context for the Bug.
This behaviour is new but not sure in which version it works correctly.
🖥 Your Environment
Chrome 113.0.5672.92
👀 Have you spent some time to check if this bug has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

Are you willing to submit PR?
No, I don't have time to work on this right now

I'm seeing the same behaviour serving docs locally and clicking any sidebar nav links, with latest 1.4.1 version - https://www.npmjs.com/package/@techdocs/cli

this issue appears to be resolved in version 1.4.2

I can confirm that I was seing this problem with 1.4.1, and that it works fine with 1.4.2.

Sweet, closing!


RepaintAll

Should we call (UnityEditor.SceneView/RepaintAll) and equivalent after each REPL invocation?

No we shouldn't


Added arabic provider EgyAnime

i also added a new extractor, its for the website clipwatching

I think it'd be great if you handled cases like https://www.egyanime.com/watch?w=8085 by throwing a custom logging.error message to let the user know there is a copyright violation

For anime dl -u naruto -p egyanime -c 5 - this gets https://www.egyanime.com/movie?do=10 instead of https://www.egyanime.com/movie?w=10 which then (probably) causes it to fail to extract the final link


Update example files for 1.1

We should probably also provide a version of the included example.parquet in geoarrow encoding, as well as for the nz-building-outlines.parquet.

For geoarrow-encoding, given that this is geometry type specific, it might make sense to include example files in this repo for all types. Or update the geoarrow-data repo to also include Parquet versions of the files (currently I think it hosts only .arrow files?)
Originally posted by @jorisvandenbossche in https://github.com/opengeospatial/geoparquet/issues/189#issuecomment-2020578039

I think it makes sense to include some (very small) data files in this repo, or in a specific geoparquet-data repo

So we've got #204 in - is there more we want to do here? Get #134 in?

I think it would also be good to have the example.parquet file in a different encoding


Fix dropped curly braces in manpages

These are a result of the (now fixed) issue cpuguy83/go-md2man#13; this is a placeholder to remind me to make a pull request updating man/Dockerfile when a new go-md2man version is released with the fix.

Hi!
Please read this important information about creating issues.
If you are reporting a new issue, make sure that we do not have any duplicates already open. You can ensure this by searching the issue list for this repository. If there is a duplicate, please close your issue and add a comment to the existing issue instead.
If you suspect your issue is a bug, please edit your issue description to include the BUG REPORT INFORMATION shown below. If you fail to provide this information within 7 days, we cannot debug your issue and will close it. We will, however, reopen it if you later provide the information.
This is an automated, informational response.
Thank you.
For more information about reporting issues, see https://github.com/docker/docker/blob/master/CONTRIBUTING.md#reporting-other-issues

BUG REPORT INFORMATION
Use the commands below to provide key information from your environment:
docker version:
docker info:
uname -a:
Provide additional environment details (AWS, VirtualBox, physical, etc.):
List the steps to reproduce the issue:
1.
2.
3.
Describe the results you received:
Describe the results you expected:
Provide additional info you think is important:
----------END REPORT ---------
#ENEEDMOREINFO

has this been fixed

Yep, closing.


Could module fragments have their own source-maps?

This might be out of scope of the discussion here but it feels like if a module fragment could include its own sourcemap url comment then bundlers could do a lot less work combining sourcemaps for large bundle files.

This seems OK in principle, but I don't know how much appetite there is to change anything about sourcemaps at all.

The work done to unify a fragment's source map into the file's source map is pretty simple to do.
However, supporting multiple source maps (in special locations) is going to cause a huge amount of turn in the tooling ecosystem. Most tools iterate backwards looking for the source map comment and stop once it's found. But now, they need to implement a JS parser so they can find each source map and figure out the bounds where it applies.
This is sooooo much more work to do. I don't think this is a useful change.


Help Mojy to run PaHM with SCHISM

@SorooshMani-NOAA  @pvelissariou1
How to make sure track file is ok?

@mojy3995 @SorooshMani-NOAA @pvelissariou1
We need to make sure the track files are in NHC bdeck text format (based on what @pvelissariou1  and @SorooshMani-NOAA  mentioned). -Saeed

@saeed-moghimi-noaa @SorooshMani-NOAA @pvelissariou1, There is a possibility of failing pyschism to create the correct ".dat" file. Soroosh can test first with the parawind/hurricane-track.dat file (already was created by using pyschism), and if it didn't work, you can re-create that by using parametric_runs/test_paramwind.py to make sure the pyschism/python code is working correctly. I also added the original text file from Sergey. I don't have any other example to check the NHC bdeck text format, but if you have, you can compare with what we have to see if there is something wrong with the original file.

The problem is with the formatting of hurricane-track.dat. It is the format used for longitude (column 8) in the
data file. PaHM expects 3 digits for longitude that is, 124E instead of 1243E for example. I am using the format
of b-deck files supplied by NHC. In PaHM code, I read the longitude field with the format:  i3, a1; 3 digits for longitude and a character for the West/East part. I'll check again the b-deck file format and see if I can be more general in reading the fields.

@pvelissariou1 can you please test the original track file as well? I just want to make sure it's not the PySCHISM that's reformatting it.

@pvelissariou1, Thank you!! or we can change the .py code to create the readable .dat file by PAHM.

Mojy,
Is this the file Sergey shared that works with ADCIRC as an input file or
still need to go through ASWIP (a prep process by adcirc modeling tools)?
Takis,
The final format input to ADCIRC and SCHISM are identical, right?
Thanks,
-Saeed

Saeed Moghimi, PhD
NOS Storm Surge Modeling
https://nauticalcharts.noaa.gov/learn/storm-surge-modeling.html Team Lead
Coastal Marine Modeling Branch, Coast Survey Development Laboratory, Office
of Coast Survey at NOAA National Ocean Service.
Address: 1315 East West Hwy, Room 6607, Silver Spring, Maryland  20910
Phone: (302) 827-3986
The contents of this message are mine personally and do not necessarily
reflect any position of NOAA.
On Thu, Sep 8, 2022 at 11:49 AM Panagiotis Velissariou <
@.***> wrote:

Hold on, let me check the documentation to see if I have the correct
format.
—
Reply to this email directly, view it on GitHub
https://github.com/noaa-ocs-modeling/PaHM/issues/10#issuecomment-1240901099,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APZULD4EYBHJLFMNJD2G62LV5IDFZANCNFSM6AAAAAAQH2LNBI
.
You are receiving this because you were mentioned.Message ID:
@.***>

Yes, the final format input is identical. Still checking.

I have modified the PaHM source code and fixed the issue. It had to do with the read format in the code. I'll update PaHM and I'll create a PR to SCHISM.

PySCHISM doesn't really do any transformation on the format. It pretty much writes out what it reads for most fields. It just adds empty fields for missing segments of the track. It was written very similar to adcircpy's version of it. In this case that 124E field is read as string and is not reformatted at all.

@SorooshMani-NOAA, thank you Soroosh for the clarification.

I updated PaHM repo and created a PR to SCHISM repo. Joseph is to review and accept the PR. Mojgan, when Joseph merges the PR, please update your SCHISM sources.  Thank you. Please let me know once he accepts the PR and merges that.

Mojgan, please refresh your schism sources and re-run your test case. Joseph has merged my PR to schism. When you are successful with your test case I'll close this issue.

Ok, thanks.

Mojgan, open file schism/src/Core/PaHM/parwind.F90 and delete lines 134 and 135:
! Array of info about the best track data (extension to use multiple storms)
TYPE(BestTrackData_T), ALLOCATABLE    :: bestTrackData(:)
When I copied my changes, I left this extra statement by mistake.
Please re-compile

ok

Ok, thanks. I will close this issue.

Are you going to fix that issue or I should document that?

I created another PR to SCHISM. Issue is fixed. No need to do anything.
Panagiotis Velissariou, Ph.D., P.E.
UCAR Scientist
National Ocean and Atmospheric Administration
National Ocean Service
Office of Coast Survey CSDL/CMMB
Project Lead - Coastal Coupling
cell:<PHONE_NUMBER>
email: @.***
On Thu, Sep 8, 2022 at 2:43 PM Mojy @.***> wrote:

Are you going to fix that issue or I should document that?
—
Reply to this email directly, view it on GitHub
https://github.com/noaa-ocs-modeling/PaHM/issues/10#issuecomment-1241155029,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APC7TPZJBLK7QP2YPPUFMUTV5I6VDANCNFSM6AAAAAAQH2LNBI
.
You are receiving this because you modified the open/close state.Message
ID: @.***>

@pvelissariou1 @SorooshMani-NOAA @saeed-moghimi-noaa
I am just checking the results and I am not sure about the accuracy of that.
This is maximum elevation: 6.551453e-06 & maximum horizontalVelX= 0.0001021061


keep lookup history when refreshing cache

Signed-off-by: vadim.zyarko<EMAIL_ADDRESS>What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area libsinsp
What this PR does / why we need it:
This PR is to refactor dns_manager:

introduce a client API to clear the DNS cache, it might be required when client configuration has changed
but the cache keeps on refreshing with all values.
introduces new logic to retain previously discovered records while refreshing the cache.
Currently, records discovered in previous refreshes are discarded and replaced with newly received ones.
This makes the cache less useful in cases of multiple records for a name.
eg loginmicrofsoft.com can resolve to 40 entries but DNS system reports only 8 records at a time.
Thus keeping more records gives more precision to the cache.

Does this PR introduce a user-facing change?:
yes
update: introduce a client API to clear the DNS cache, it might be required when client configuration has changed
but the cache keeps on refreshing with all values.
new: introduce new logic to retain previously discovered records while refreshing the cache.

@VadimZy: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Hi @VadimZy. Thanks for your PR.
I'm waiting for a falcosecurity member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: VadimZy
To complete the pull request process, please assign fntlnz after the PR has been reviewed.
You can assign the PR to them by writing /assign @fntlnz in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@VadimZy: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@VadimZy as far as I can tell, there's a Prow automation plugin on the release-note block, so please update it to have something meaningful.

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle stale

/remove-lifecycle stale

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle stale

/milestone 0.11.0

/cc @gnosek @mstemm

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle rotten

/remove-lifecycle rotten

@VadimZy can you rebase this one?

/milestone 0.12.0

@VadimZy is this still needed/alive?

@FedeDP Hi Federico, sorry for the delay.
This PR is obsolete. We no longer use reverse DNS lookup in the agent. We moved to the bad IPs list matching.


added transition effect for smooth hover

Stop write to me
Le jeu. 1 oct. 2020 à 19:44, Pankaj Kumar Sahu<EMAIL_ADDRESS>a
écrit :

You can view, comment on, or merge this pull request online at:
https://github.com/WebCifar/one-page-website-html-css-project-for-practice/pull/14
Commit Summary

Update style.css

File Changes

M style.css
https://github.com/WebCifar/one-page-website-html-css-project-for-practice/pull/14/files#diff-da232d78aa810382f2dcdceae308ff8e
(979)

Patch Links:

https://github.com/WebCifar/one-page-website-html-css-project-for-practice/pull/14.patch
https://github.com/WebCifar/one-page-website-html-css-project-for-practice/pull/14.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/WebCifar/one-page-website-html-css-project-for-practice/pull/14,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AMKTCZ2WAFT2K4RJ3ZU2KUDSITEZVANCNFSM4SAZQ5FA
.


[Internship] Binary Input Example

Binary Input Example
The goal of this example project is to test the performance of Engflow's remote execution and caching service based on the number of input binary files in the dependency graph. The project contains a genrule that generates a specified number of Java binaries for the genbinary Java library, which are then listed as dependencies in the main binary. The Main.java file loops through each generated class and calls its greetNum method.
How It Works

Generation of Java Binaries:

The genrule in the BUILD file generates a specified number of Java classes (Hello1.java, Hello2.java, ..., HelloN.java).
Each generated class contains a greetNum method that prints a unique message.

Main Class Execution:

The Main.java file in binaryinput dynamically loads each generated class using reflection.
It then invokes the greetNum method of each class, printing the corresponding message.

@NicolasHuertas we have fixed the issue with CI. Please, sync your branches with main.

Thank you @NicolasHuertas  for the changes. This is looking really good. Let's do a final change before acceptance.
Please, remove the python script leaving only the example. The script can be a second contribution, we will see. Remove references to the script too.


Add as bower package

Didn't find prism when searched http://bower.io/search/
Can you add it?

Hm?

Hmm, weird.

Hmm, it comes up for me too!

That is weird, indeed.
I suggest you submit an issue on Bower.


Missing cgmathx64.dll

It's looking for this dll that doesn't exist. Now, I barely know what a dll is, or how it's used, so feel free to ignore this and I'll go back to webgl land 😅
Is this something I have to build or get from somewhere? Or is this something which is fundamentally not gonna work on linux?
Traceback (most recent call last):
  File "/home/tdhooper/Projects/sqrmelon/SqrMelon/sceneview3d.py", line 164, in paintGL
    execfile(modifier, globals(), locals())
  File "/home/tdhooper/Projects/sqrmelon/SqrMelon/defaultproject/animationprocessor.py", line 2, in <module>
    cgmath.prepare()
  File "/home/tdhooper/Projects/sqrmelon/SqrMelon/cgmath/__init__.py", line 25, in prepare
    _dllHandle = ctypes.CDLL(dllPath)
  File "/usr/lib/python2.7/ctypes/__init__.py", line 362, in __init__
    self._handle = _dlopen(self._name, mode)
OSError: /home/tdhooper/Projects/sqrmelon/SqrMelon/cgmath/cgmathx64.dll: invalid ELF header

Ah, that's not gonna work indeed. A DLL is a compiled bundle of functions and it has to be compiled separately for linux / osx as their internals are different from windows. I can make a pure-python version that does not need the DLL, will keep you posted!

I looked into trying to compile it with gcc, but there's lots of Windows specific stuff in there isn't there?
Don't do that just yet, as I've not managed to get anything to draw yet so might not be worth it. Right now I'm running into a problem with setting up the buffers, I'll create another issue for that.

I've made a try/except that will load a python version if the DLL load fails.
Also looked at your branch and tried to implement your fixes as much as I could. In theory you should be able to pull the master branch and be at the same point, give or take these 2 issues.
Probably you're not out of the woods yet but at least a lot closer!


Remove bigbang "private" key from git history

Overview
A legacy Zarf Big Bang example included a private key for configuring Istio TLS.
Bigbang intentionally checks these keys in publicly for use in local dev and examples.
The key (from ~2022) is certainly expired, but can still flag in history scans when teams look into adopting Zarf.
We should consider scrubbing it from the history to reduce potential confusion and concern.
Details
The commit SHAs (listed below) can be identified with:
git log --all --full-history -- "**/bigbangdev.key*"

b051061a72374894562d21b77d54bbf065b384af
80c4ed1986b3d40f587e8f915a1e9bba5931d7e2

NOTE: There may be other similar commits that are worth tracking down, these are obviously specific to this particular file/example

Closing this because this is not a security concern. The private key was for localhost and is long expired


External network to access services in custom VPCs.

Hello,
We are testing Custom VPC. We have tested isolation between two different VPCs and isolation was tested successfully.
After that, we have tried to expose service in custom VPC. As far as I understand correctly, we need to add static routes on our router for each service ip which is explained in below section.
https://github.com/kubeovn/kube-ovn/blob/master/docs/vpc.md#vpc-loadbalancer
ip route add <SVC_IP> via <VPC_LB_IP> and SVC_IP is internal IP of course. Why do we need to add route? Can LB do nat to SVC_IP and port like NodePort solution?
Or is there any possibilty to expose services via nodeport or loadbalancer in custom VPC solution without adding static routes to local router or host. Because this solution may not be working in public cloud providers
Many thanks for your support.

You can refer to the VPC LB document here. After adding the annotation to the VPC, a Pod will be created automatically in the kube-system namespace.

Hello @zhangzujian, yes exactly after annotation vpc-lb pod automatically created. My quesion is that do we need to add following static routes to our local router for each service "ip route add <SVC_IP> via <VPC_LB_IP>" which is written in VPC LB document.
Instead of this, external network use VPC-LB IP in order to reach service and VPC-LB make nat to SVC_IP and port like NodePort solution?
Thanks

Instead of this, external network use VPC-LB IP in order to reach service and VPC-LB can make nat to SVC_IP and port like NodePort solution?

We have not implemented a NodePort-like solution so it's the only way to access services currently.
Accessing services through node ports is a good idea, but it's not been our focus recently.

Thanks again for quick reply. Yes this would be very helpful. Actually I thought initially OVS DNAT can easily be used for exposing service from external sources. So user can easily use this feature without adding routes to their underlying infrastructure like any other Kubernetes services.


Basic Authentication

I want to be able to protect some of my kube-system service (dashboard, kubedash, ...) yet still exposing them with the nginx-controller without having to change thos service's code base.
But cannot find a way to implement basic authentication as described in the NGING docs
Am I missing something?

@cescoferraro please check this https://github.com/aledbf/contrib/blob/6d61ea81bb0bdbbc115cd6a6e9c59ef653afb213/ingress/controllers/nginx/examples/auth/README.md

is this on 0.61 @aledbf  ?

@cescoferraro no, next release


feature: Autoplay the next video after completion of one #1308

PR Fixes:

1 Autoplay next video after completion of one and also handled the case where "week 1" last video is played then "week 2" first video is played.
2 When last week's last video is played then it doesn't route anywhere instead stays there.
3 Implemented same autoplay next video with the "Next button" and while reaching last week's last video disabled that button and showed the message "Last video of the course".

Resolves #1308
https://github.com/user-attachments/assets/c1ba4304-3a77-4d0f-a8cc-88bd4544686d
Checklist before requesting a review

[x] I have performed a self-review of my code
[x] I assure there is no similar/duplicate pull request regarding same issue

Diff looks huge, Can you please create a new pr with only the relavent changes. Closing this for now!


[Volunteer] Add integrated test for Resilience4j plugin

Volunteer help

[ ] Add integrated test for Resilience4j plugin

We should test as many parameter configurations as possible.

I can have a try.

I can have a try.

good luck!

I cross my fingers :)

I cross my fingers :)

Haha, we think Resilience4j is an excellent fault-tolerant library that can integrate well with Apache ShenYu~

Do the tests are implemented? If not I can have a try.


Expand list of "well-known" parsers.

Currently, spine-web JavaScript client requires custom Protobuf message types and parsers to be passed for client initialization. Some of "well-known" parsers are built-in and defined in web/client-js/main/client/parser/well-known-parsers.js. The issue is to expand the list of those parsers with parser for google.protobuf.Struct type.

@YegorUdovchenko Apparently, this issue was addressed via #132 in version 1.4.2.
Please confirm that you no longer experience the issue.

Works well, thank you.


Inconsistent behavior in the UWP Combobox SelectionChanged event

Describe the bug
I stumbled upon inconsistent behavior in the SelectionChanged event of the UWP Combobox control. If a data model property is bound to the combobox's SelectedIndex property, the data model property inconsistently matches/does not match the combobox's SelectIndex property in the event handler depending on how you interact with the control.
Steps to reproduce the bug

Create an empty UWP app.
Create a data model class with an integer property.
Bind the data model property to the SelectedIndex property of the combobox.
Create a SelectionChanged event handler for the combobox.
In the event handler, display the value of the combobox's SelectedIndex property and the value of the bound data model property.
Make selections in the combobox using the mouse or touch. Note that the displayed values in the event handler match.
Use the keyboard to make selections in the combobox. Note that the displayed values in the event handler do not match.

Expected behavior
The values in the event handler should consistently match, or not match, regardless of how you interact with the control.
Repro
I have made available a demonstration project that reproduces the issue:
https://github.com/EddieLotter/UwpComboboxAnomaly
Version Info

NuGet package
version

Microsoft.NETCore.UniversalWindowsPlatform
6.2.8

Windows 10 version
Saw the problem?

Insider Build (xxxxx)

May 2019 Update (18362)
Yes

October 2018 Update (17763)

April 2018 Update (17134)

Fall Creators Update (16299)

Creators Update (15063)

Device form factor
Saw the problem?

Desktop
Yes

Mobile

Xbox

Surface Hub

IoT

Good bug! ComboBox code is in the framework so we won't be able to fix this until winui 3.0, but we'll put it on the backlog.

@jevansaks you're welcome. Fortunately it's easy to work around, so it's not critical. :)

UP. This issue should not be part of https://github.com/microsoft/microsoft-ui-xaml/discussions/8638.


Fix link color and tab component styles

Fixes #23504 as well as:

Update link style across site to use consistent default color when appropriate (as defined in /assets/scss/_skin.css#L1)
Update tab component font styles to match the rest of the document (the current one is inheriting styles from JQuery UI, which is also the cause of #23504)

/area web-development

Preview:

https://deploy-preview-23534--kubernetes-io-master-staging.netlify.app/docs/setup/production-environment/tools/kubeadm/install-kubeadm/#installing-runtime
https://deploy-preview-23534--kubernetes-io-master-staging.netlify.app/docs/concepts/cluster-administration/cloud-providers/#vsphere

/assign @steveperry-53

/assign @sftim


Study Plan

College Board
I can review College Board and rewatch any videos that I need to. This helps me remember things I may have forgotten.
I can also look back on the quizzes that I did and review those. This also helps me remember things I may have forgotten.
Previous Trimesters
I can review my repositories from the previous trimesters. By doing this I strengthen my knowledge of code.
I can look at my journals from previous trimesters and review them.

##My Scores


Add version_info

I added a version_info module to

follow SemVer
encourage frequent deployment of development versions to pypi via

patch versions
the devN tag

make version easily accessible from within python code

For downstream packages it would be super useful to have more frequent (development) releases on PyPI. For development releases this could happen nightly (or arbitrarily) via bumping the devN tag.

Thanks a lot!


zos: avoid compiler warnings

Some of these compiler flags are not supported. So don't
use them.

CI: https://ci.nodejs.org/view/libuv/job/libuv-test-commit/297/

And its 💚

Landed in https://github.com/libuv/libuv/commit/d5fc593b5f511386bef526cd454b473614de4a1f. Thanks!


Remove popular posts for now

Just get rid of Popular posts for now, since it's causing problems.
@kave
@richaagarwal

let it go! :+1:


Issue with body tag style

I'm not sure if this is related to issue #74.
Upon opening the modal, a top style property is added to the body element.
ie: <body class="tingle-enabled" style="top: -689px;">
Although when closing the modal, this value does not get removed which:

Leaves additional space at the bottom of the page.
Unable to scroll to the top. (content 'cropped');

Hi @RyanGosden,
I just published a new version (0.13.2) which should fix your issue.

@robinparisi - Tested and issue is resolved. I must say, that was the quickest resolution I have seen to this date. Many thanks.


How to enable audio support?

Hello, I am using Hyper-V to install macOS 14.
Now I find that the sound in macOS cannot be played through the Windows speakers.
Is there any way to hear the sound in macOS?
Thank you!

Hyper-V unfortunately does not provide audio virtualization. As mentioned in the README, no audio device is given to the VM by default:
https://github.com/Qonfused/OSX-Hyper-V/blob/b16b38a3533386bbba4c083d84344334839c05fa/docs/README.md?plain=1#L499-L500
One of the options that might be apparent if you have access to a Windows edition with DDA support is to pass in a supported GPU, though there are issues with detecting devices early enough to apply patches w/ AppleALC and WhateverGreen (refer to the README; also explained in #6).
The best option at the moment is to use a virtual audio device that can behave as an audio sink/loopback device. You can the open-source Blackhole driver to capture desktop audio and route it through a network-enabled app between macOS and the Windows host (I've done this with OBS Ninja in the past or through a networked USB-interface with VirtualHere).


Misinterpretation of NAT rules

[Enter feedback here]
The NAT rules shown at the branches in the diagram seem to convey that they are actually configured on the branch gateway. But that's not what is intended. Suggest correcting this either by 1) providing an explanation that this is just a logical view and all rules are actually configured on the VNet gateway, or 2) changing the diagram.
Thx,
jgolani@microsoft
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b4ea585e-6ab4-38b6-0b75-6b53ae438d7d
Version Independent ID: 21dbf063-9b96-9936-8daa-79a3cb831198
Content: About NAT (Network Address Translation) on VPN Gateway - Azure VPN Gateway
Content Source: articles/vpn-gateway/nat-overview.md
Service: vpn-gateway
GitHub Login: @cherylmc
Microsoft Alias: cherylmc

Thank you for your feedback! We have assigned this issue to the author to review further and take the next course of action.

#reassign:@deeharris-23

#reassign:radwiv

#assign:cherylmc

#reassign:@deeharris-23


Documentation "Custom Request and APIRoute class" GZipMiddleware reference

The Tip in Custom Request and APIRoute Class documentation | Create a custom GzipRequest class says that the example shown there is a "toy" one, and for the real GZip support the GZip Middleware could be used.

The custom created GZip Request class handles the decoding of incoming gzipped content we receive to a web-server.
But GZip Middleware is doing the opposite thing: it handles the GZip encoding of the content we send from a web-server.

Is the suggested piece of information in "Tip" really corresponds to the example shown below in the documenation?
Is there a plan to implement a GZip Middleware for decoding incoming gzipped requests (similarly to the existing GZip Middleware that encodes the outgoing responses)?

It would indeed be great.

I came across this today and it's definitely confusing. The "Tip" gives the impression that GZipMiddleware handles both request and response compression.
Looking at similar issues for FastAPI/Starlette, it looks like there are no plans to implement request decompression in GZipMiddleware according to this closed issue. It references a related discussion on general-purpose deserialization which contains an implementation of GZipMiddleware request decompression, but this hasn't been merged back into Starlette.

In my very first experience using FastAPI I ran into this issue. Incoming POST requests that have Content-Encoding: gzip fail request validation. Following the FastAPI doc to add the GZipMiddleware does not help my app to process incoming gzipped requests. From my testing, it appears that all the GZipMiddleware does with a request is to check if the Accept-Encoding header contains gzip and if so it gzips the response.
The Starlette Middleware doc also implies that GZipMiddleware is only for gzipping responses, not for handling gzipped requests.
Since this issue is still open, I thought I'd comment with this "me too" comment and suggest that unless there are plans to add request handling to the GZipMiddleware, then at a minimum the documentation should make clear that middleware will create gzipped responses but does not handle gzipped requests. Ideally that updated documentation would include an example of how to write a custom middleware to handle gzipped requests, if that is indeed the only way it can be done right now. The example could be either in-line in the doc, or linked from the doc.
Thanks!

Yeah... The docs are wrong there... :thinking:
I don't find anything on the literature about Content-Encoding in the request headers... :eyes:


Compute the end-game metrics for final summary

US: Display Game Summary #93
PREREQUISITES:

end-game logic is implemented

GODOT LOGIC:

register the metric that we want to display in the summary
compute and store the final summary based on the recorded metrics

BOUNDARIES:

What this task handles is the recording of the metrics and computing and storing of the final summary
What this task does not handle are the design and the logic of how the final summary is displayed

OUTCOMES:

The end-game summary is computed and stored.

END-GAME SCORING:
formula that gives a sum of:

anonymity (average for whole game?)
negative parameters from all selected answers (-X P)
points (stars) from missed zones
current progress at the end

to be discussed when picked..


[Docs] Git Setup

As title.
Installing Git from binary package and source

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@29151b9). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #10122   +/-   ##
=========================================
  Coverage          ?   43.41%
=========================================
  Files             ?      576
  Lines             ?    79632
  Branches          ?        0
=========================================
  Hits              ?    34570
  Misses            ?    40785
  Partials          ?     4277

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29151b9...4645faf. Read the comment docs.

@bagasme can you add a link to this page on ? https://github.com/go-gitea/gitea/blob/8a828500e689b7958e050ebd2dc46d380c3d6ae6/docs/content/doc/installation/from-binary.en-us.md#L52

Perhaps just adding some links to the binary page or FAQ? In my opinion, building Git from source is out of scope for Gitea documentation.

@jolheiser if git users lookup gitea's docs then we made it :laughing:

@techknowlogick git-scm.com site mention this (build from source) on Pro Git.

I'm not concerned about specifically building from source, but rather there links to specific tar bundles that would need to be updated, as well as reviewing the link you just posted the content covers the same but in greater detail. Maybe instead you could add a small note to the installation page that mentions git is also required and link to the page that you just did so that we don't need to maintain it and the official docs from git will always be most accurate and most maintained.


Error converting ulid lightener_context to bytes: ULID must be a 26 character string: lightener_context

First of all, thanks for the great work!
Home Assistant 2023.4.6
Supervisor 2023.04.1
Operating System 10.1
Hundreds of errors like the following are logged:
2023-05-02 20:21:17.542 ERROR (Recorder) [homeassistant.components.recorder.models.context] Error converting ulid lightener_context to bytes: ULID must be a 26 character string: lightener_context
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/components/recorder/models/context.py", line 19, in ulid_to_bytes_or_none
return ulid_to_bytes(ulid)
File "src/ulid_transform/_ulid_impl.pyx", line 23, in ulid_transform._ulid_impl._ulid_to_bytes
ValueError: ULID must be a 26 character string: lightener_context

Thanks for the report. I could confirm the issue although apparently everything seems to work.

Fixed with c0afc1c3c9fff2c334d12f714379b7b41ef3caba.


Error messages

Not having any issues, but I saw this in the developer console and thought you should know.

(This is happening all the time, even when I'm not working on a page with wordcount enabled.)

Should be fixed in latest version.

I'm afraid there are still some errors.

Apologies, please see the latest version.


[MODCON-164] Update libraries of dependant acq modules to the latest versions

Purpose
[MODCON-164] Update libraries of dependant acq modules to the latest versions

Approach

Update versions
Add module descriptor validator

just need to update from master, it contains permission renames and plugin to validate that should fix build issue


fix(#84): order of properties

Purpose
Right now when using the extended tags functionality, you will see content as the first property rendered. This can make finding tags in the html difficult at a glance.
<meta content="Home Page | My Test Site" name="title">

We should instead start with either the name or property of the tag to improve readability.
Testing

[ ] Confirm that tags are created more like <meta  name="title" content="Home Page | My Test Site">
[ ] Other tag functionality such as OG tags and Twitter tags are unaffected.
[ ] Any other build commands are not affected.

@mikeethedude Landed in 0.8.1. Excuse the long delay between versions and thanks again for your this PR!


Iox #521 best practice for testing

Pre-Review Checklist for the PR Author

[x] Branch follows the naming format (iox-#123-this-is-a-branch)
[x] Commits messages are according to this guideline

[x] Commit messages have the issue ID (iox-#123 commit text)
[x] Commit messages are signed (git commit -s)
[x] Commit author matches Eclipse Contributor Agreement (and ECA is signed)

[x] Update the PR title

Follow the same conventions as for commit messages
Link to the relevant issue

[x] Relevant issues are linked
[x] Add sensible notes for the reviewer
[ ] All checks have passed
[ ] Assign PR to reviewer

Notes for Reviewer

This PR tries to document the our best practices to write tests for iceoryx. Some of them were unwritten, making it hard for new contributor to write test the way we expect it.
I still have to write a small example for typed and parameterized test, but this will be more or less just a template for c&p and all the other stuff is done and can be reviewed.
Oh, and I fixed a typo from my last PR.
Checklist for the PR Reviewer

[ ] Commits are properly organized and messages are according to the guideline
[ ] Code according to our coding style and naming conventions
[ ] Unit tests have been written for new behavior
[ ] Public API changes are documented via doxygen
[ ] Copyright owner are updated in the changed files
[ ] PR title describes the changes

Post-review Checklist for the PR Author

[ ] All open points are addressed and tracked via issues

Post-review Checklist for the Eclipse Committer

[ ] All checkboxes in the PR checklist are checked or crossed out
[ ] Merge

References

Partly closes #521

There should be a link from https://github.com/eclipse-iceoryx/iceoryx/blob/master/CONTRIBUTING.md#testing to this document.


Swift 2.2 support

Do you have an version for Swift 2.2?

Hi @leonereveel, yes it is a file-only setup for Swift 2.2. See the details here and let me know how it goes.
https://github.com/marketplacer/swift-badge/wiki/Legacy-Swift-versions

Closing the issue, feel free to reopen if needed.


Note and pin package changes in environment.yaml

We had a couple changes to environment.yaml starting in PR #95.
In environment.yaml:

[ ] On the pandas line, we need to note that we don't directly depend on pandas and this version pin is a workaround to a regression (#96).

[x] On the pip xclim line, we need to pin the xclim version. Also, try switch the package install to a conda dependency rather than pip.

We should do this after the main features are merged into main, just before the release.

xclim was pinned in PR #99 but pulling the package from conda-forge caused an error in the environment build so we're going to keep it installing from pip for the v0.4.0 release.


software_spec: improve bad manifest error message.

Let's complain immediately after fetching if there's something wrong and improve the error message to make it clearer what's going on.
Inspired by #76336.

Review period skipped due to critical label.


Update Composer dependencies (2022-11-23-00-10)

Visual regression test passed!
View the visual regression test report


Needed example or docs for standard procedure on multiple getters

When using more than one getter the incoming buffer can get a bit messy, and simply decoding it directly and naively doesn't always get the intended message.
This applies specifically to turning on the encoder output (which is a periodic message) as well as requesting values (which is a triggered message).
Potentially, this could be a new feature - or it could be already implemented in a non-obvious way that I'm not seeing!

I see what you're saying. Yeah that sounds like a good idea. Right now I think this could be accomplished by checking the the responses ID.
What I was thinking this would look like would be the following where the user has defined some handler, user_defined_handler, which they call with any parsed messages.
response, consumed = pyvesc.decode(buff)
buff = buff[consumed:]

if response:
    user_defined_handler(id=response.id, msg=response)    # response.id should always be valid so long as resonse is not None

So far the focus of PyVESC has been solely on facilitating the encoding/decoding of messages according to the VESC message protocol. I was kind of hoping to keep it this way because I think it then provides a flexible and reliable base for developing VESC applications. I think that we would lose some generality of the library if we started implementing handlers.
Personally I think that this would be a really good feature but I don't think that PyVESC is the proper place to put it.
What do you think?

Liam: I just installed and ran the examples on PyVesc. Worked flawlessly! I have the hal sensors connected to the Vesc. How can I read the rotation position using pyvesc?

@pythonmobile
Hey glad to hear it worked!
I think that Austin, @ausshir, might be a bit better suited to answer this question. I have primarily been working on the communication protocol rather than the actual VESC's themselves. @ausshir can you chime in?

@ausshir Hope you already have a decoder for encoder somewhere.
@LiamBindle Thanks. Is the following code already checked in and ready to use for users?
``
response, consumed = pyvesc.decode(buff)
buff = buff[consumed:]
if response:
user_defined_handler(id=response.id, msg=response)
''

Hey @pythonmobile
Sorry for the late response. The code snippet I have shown above is just an example of how I would handle multiple getters. There are a lot of different ways this could be done (the example is just a simple one) but I don't want to restrict PyVESC to just one of these methods. I'd really like to keep this library general so I'm leaving it up to the users to implement their own.
Just as a reference this would be how I would do it (quick solution).
# handler for GetValues
def get_values_callback(msg):
    # type(msg) is GetValues
    # handle the message however you'd like here
    print("Received a GetValues message")

# handler for GetRotorPosition
def get_rotor_position_callback(msg):
    # type(msg) is GetRotorPosition
    # handle the message however you'd like here
    print("Received a GetRotorPosition message")

# make a list of callbacks to hold callbacks for id's between 0-35 (I've chosen 36 arbitrarily)
callbacks = [None]*36
callbacks[GetValues.id] = get_values_callback
callbacks[GetRotorPosition.id] = get_rotor_position_callback

Now wherever you parse the messages from your UART I'd put something like this
# buff is the UART read buffer
response, consumed = pyvesc.decode(buff)
buff = buff[consumed:]

# call the appropriate callback
callbacks[response.id](response)

This is a start on how I would do this. I have not tested this code but this would be how I would approach the problem. Essentially the idea is to have a list of callback functions which take the message as a parameter. The appropriate callback is indexed by messages ID.
Let me know if you have any problems!


docs: ✏ Full Walkthrough Issuer Node README

Updated the README to reflect the full walkthrough process of setting it up
BREAKING CHANGE: 🧨 No
Section includes new Getting Started and screenshots to help developers go through the process of setting up, issuer a claim, and verifying a claim.
Example screenshots of markdown

Hi @codingwithmanny thanks for your contrib! May I point your attention to the current develop branch? There we have changed and simplified a lot of the config process and updated the README to be clearer, more concise and more comprehensive.
We are currently working on how best to structure the repo, but the rule of thumb is that main will always be a stable reference for implementers, and develop the base branch for any and all PRs.

@cneuro yep, got the PR for that one. This one I made sure to close out, but still give some devs its reference to get started.


[Bug] Cannot access 'fs' before initialization

Describe the Bug

To Reproduce

Expected Behavior

Screenshots

Discord Version

Additional Context

Sounds like you are using the old mac installer, please use the new one found here: https://github.com/BetterDiscord/Installer/releases/latest

I have an installation problem (file compression)

Safari Cannot Unzip This File Safari is unable to open the "BetterDiscordMacInstaller.zip" file because it is still being downloaded.

That is not the filename of the new installer, not sure what you're downloading.


Added NLP - Text Classification using LSTM and GloVe (TF) Notebook

Added Beginner friendly tutorial notebook on Sentimental Classification on Text using LSTM Network and GloVe Embedding built using Tensorflow.
I have also added a few content on NLP in README.md. I am thinking maybe we can add some resource links and "Open in Colab" links in there. I will fill in the rest in my next PR

Perfect @arunpandian7

Sure I will check and fix that.


Is this suitable for lipsync?

Hi, this project seems to be animating a reference image with driving audio and/or face pose. Is this suitable for lipsync?
Also, this seems to be using video diffusion methods, how do you make it to generate such a long video, without running into resource constraints? Is this using Conv method instead of temporal attention for handling the temporal dimension?

it is renders kind of slow, don't think people can use it for lipsync, 5 second audio on RTX 4090 , takes 30/30 [03:37<00:00,  7.25s/it]

It will be slow because this is based on video diffusion model. Not looking at realtime prediction. But it is suitable for lip sync? Do you have a pipeline for that?
How can we split the audio feature to only generate one frame, rather than complete video to do frame-by-frame processing?

It is a common limitation for SD models for its slow inference. We are trying to accelerate it by step distillation techniques. It is possible that we release a fast version of EchoMimic in this month.


left/right instead of expected/actual in test output

For equality comparisons, rust's test runner uses "left" and "right". I like this better than "expected" and "actual" because it takes me a moment to remember which argument is which. I'm not sure what t.ok() and t.notOk() should report.

Would you think that this would be a breaking change, or that nobody would be depending on the wording in the output?

I didn't find anything right away but I think some of the pretty output parser modules expect to find "expected" and "actual" in the yaml block so this would be a breaking change.

Is that particularly worth it? It seems like a pretty minimal improvement.

ok closing then


Dedicated exception to handle failures of MakeGenericType exclusively

A small improvement for fix for #87 and #92 (done in https://github.com/unitycontainer/container/commit/941cdd6d7e41e976431763c511c466f0b26d309b)

Are you going to resubmit your pr for the error?
I am trying to release 5.8.7 soon

@bartoszkp
It looks like I removed your last PR but did not remove this one. It was hiding behind my packages update commit and I did not see it. Would you resubmit your second PR?

@ENikS I am not sure, but I think I posted only one PR - this one. And my changes were only one commit. The commit - 03ae60c307803f81230e50fbb120784dd3d65baf is present here, in my fork, and in v5.x branch, therefore I think everything is fine. When looking at the code, all my changes are there - the new dedicated exception, the MakeGenericTypeOrThrow method, the place where the new exception is handled and 3 unit tests.


Locale files from carmen are loaded after rails app initializes

Hi,
we have a problem with adding custom translation to some Carmen state. We added translation to our locale file but it didn't change anything. I think the problem lies at how carmen-rails adds locale files from Carmen to rails I18n.load_path. It adds the files to config.i18n.load_path withing its Railtie and that causes the files are added to app I18n.load_path after the app locales so it rewrites any locale keys app defines.
I just wanted to check, isn't this for some intention i just can't think of right now? If not i propose to change it. I actually tried it at my fork masa331/carmen-rails. I changed the Railtie a bit and it's all good.
If it's all right should i make a pull request?

Hi, i tried your branch and added this to my app's config/locales/en.yml:
en:
  world:
    kr:
      official_name: "South Korea"

But I still see, 'translation missing: en.world.kr.official_name'. Do I need to configure something for my locale to be used with your fork?

Try to add also common_name and name to your yaml:
en:
  world:
    kr:
      official_name: 'South Korea'
      common_name: 'South Korea'
      name: 'South Korea'

I don't know which one is the one really needed tho.. Don't have time for more investigation now :)