[FLINK-15855][hive] Use the new type inference for Hive UDAF

What is the purpose of the change
Use new type inference for Hive UDAF
Brief change log

Stop using AggregateFunctionDefinition in HiveFunctionDefinitionFactory
Remove HiveLegacyFunction, HiveAggSqlFunction, HiveFunctionUtils
Add a HiveParserOperatorBinding and create AggregateCall with the HiveParserOperatorBinding to make HiveGenericUFAF can get literal arguments

Verifying this change
existing tests and added test in udaf.q.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
The S3 file system connector:  no

Documentation

Does this pull request introduce a new feature? no
If yes, how is the feature documented? N/A

@flinkbot run azure

@flinkbot run azure

Tests passed: https://dev.azure.com/imjark/Flink/_build/results?buildId=572&view=logs&j=f3dc9b18-b77a-55c1-591e-264c46fe44d1&t=2d3cd81e-1c37-5c31-0ee4-f5d5cdb9324d
Merging...


Setting LEDs... doesn't end

It successfully combines both JoyCons but gets stuck setting the LED for the right JoyCon. After running it a few times, it eventually set both LEDs but I still had to manually stop the execution. Hope to be helpful!

There's just no completion message, did you make sure inputs could be seen in joy.cpl first? I noticed the same thing but it still works.

Sorry for the delayed response. The driver works perfectly. Just had to configure the offsets a bit. The issue I was referring to is that I have to initialize the Joy-Con driver 2 or 3 times for both joy-con LEDs to set and stop blinking.


Upgrade to k2, add Qodana, remove Kotlin/js

Apparently, Qodana build fails now because the QODANA_TOKEN secret is not in the head repository.


Results sent to http socket without client.http_socket config raise an exception

Expected Behavior
By default I should be able to send valid check results to the client http socket input without an error.
Current Behavior
Since Sensu 1.1.0, sending check results to the client http socket raises an exception
Possible Solution
As a workaround, adding { "client": { "http_socket": {} } } to sensu-client configuration avoids the exception.
To fix this regression directly we should verify that @settings[:http_socket] is a hash before attempting to test keys inside such a hash. c.f. https://github.com/sensu/sensu/blob/v1.1.1/lib/sensu/client/http_socket.rb#L125
Steps to Reproduce (for bugs)

Stand up a sensu-client instance with default configuration (no client.http_socket settings)
Post a check result to the client http socket
Observe 500 internal server error response
Observe the following in sensu-client.log:

"undefined method `[]' for nil:NilClass","backtrace":["/opt/sensu/embedded/lib/ruby/gems/2.4.0/gems/sensu-1.1.0/lib/sensu/client/http_socket.rb:125:in `process_request_results'"

e.g.
$ curl -v -H 'Content-Type: application/json' -X POST -d '{"name": "http_socket_test", "status": 2, "output": "this will fail" }' <IP_ADDRESS>:3031/results
Note: Unnecessary use of -X or --request, POST is already inferred.
*   Trying <IP_ADDRESS>...
* TCP_NODELAY set
* Failed to set TCP_KEEPALIVE on fd 3
* Connected to <IP_ADDRESS> (<IP_ADDRESS>) port 3031 (#0)
> POST /results HTTP/1.1
> Host: <IP_ADDRESS>:3031
> User-Agent: curl/7.54.1
> Accept: */*
> Content-Type: application/json
> Content-Length: 70
>
* upload completely sent off: 70 out of 70 bytes
< HTTP/1.1 500 Internal Server Error
< Content-length: 77
< Content-type: application/json
<
* Connection #0 to host <IP_ADDRESS> left intact
{"response":"Internal Server Error: Check your Sensu logs for error details"}

Context
This unexpected exception causes check result submission via client http socket to fail unexpectedly.
Your Environment

Sensu version used: 1.1.1
Active Sensu extensions (e.g. WizardVan 0.1.0): N/A
Operating System and version (e.g. Ubuntu 14.04): Ubuntu 16.04
Transport and runtime versions (e.g. RabbitMQ 3.6.2 on Erlang 18.2): N/A

Thanks to @betorvs for reporting this issue via Sensu Community Slack 👍

I'll whip up a fix 👍


Error while updating property 'nativeBackgroundAndroid'

After upgrading react-native from 0.39.0 to 0.41.0, rendering ActionButton gives this error. I have upgraded to the latest version of react-native-action-button  (2.5.1) and still get the error.
Error while updating property 'nativeBackgroundAndroid' of a view managed by: RCTView
updateViewProp
    ViewManagersPropertyCache.java:89
setProperty
    ViewManagerPropertyUpdater.java:123
updateProps
    ViewManagerPropertyUpdater.java:42
updateProperties
    ViewManager.java:36
createView
    NativeViewHierarchyManager.java:227
execute
    UIViewOperationQueue.java:148
dispatchPendingNonBatchedOperations
    UIViewOperationQueue.java:890
doFrameGuarded
    UIViewOperationQueue.java:863
doFrame
    GuardedChoreographerFrameCallback.java:32
doFrame
    ReactChoreographer.java:131
run
    Choreographer.java:759
doCallbacks
    Choreographer.java:574
doFrame
    Choreographer.java:543
run
    Choreographer.java:747
handleCallback
    Handler.java:733
dispatchMessage
    Handler.java:95
loop
    Looper.java:136
main
    ActivityThread.java:5001
invokeNative
    Method.java:-2
invoke
    Method.java:515
run
    ZygoteInit.java:785
main
    ZygoteInit.java:601
main
    NativeStart.java:-2

Here's a clue. A prior upgrade triggered this error in a the react-native-material-kit module, which was fixed by this change: https://github.com/xinthink/react-native-material-kit/commit/cc9ac25c072834b3f478738b543fa08b2223f887

It look like this is fixed on master.

I'll publish Master to npm later

Done


Adding rules at Runtime

Hi,
If I understood correctly, it is only possible to modify certain rules at runtime (like the example on changing the adult age). But it is not possible to add new rules whithout recompiling, right?
In my case, I need to inject new rules (java files in this case) to clients without them recompiling java code. Any other solution you can think of?
Thanks

Hi @mmorelo

But it is not possible to add new rules whithout recompiling, right?

Indeed, this is not possible

In my case, I need to inject new rules (java files in this case) to clients without them recompiling java code. Any other solution you can think of?

Just to be sure I understand. The idea is to read java code from a file, compile it on the fly, create the Rule object and register it at runtime. Is this your plan?


Change git repo url from SSH to HTTPS

The change is made for researchers to easly clone the project to check out from systems and platforms with SSH not in sync with github. Eg : Google Colab, Remote GPU Servers etc

Thank you!


Filter falsey values from build configs before passing them to rollup

Fixes https://github.com/palmerhq/tsdx/issues/76
I wasn't sure how to write a test for this. Sorry. I'd be happy to write a test if you point me to an example of a similar test that it should look like.
Details copied from commit message:

fix: remove falsey build configs
If the opts.format.includes call above returns false, a false value
is inserted into the array in place of a rollup config object. Each
element of the createBuildConfigs is eventually passed into rollup
as an inputOption. If one of these elements is false, the script will
pass that value as a config to rollup which results in a rollup error
stating: "You must supply an options object to rollup"
This commit fixes that issue by filtering out falsey values.

@allcontributors please add @jakegavin for bugs, code


Moved versioning config info to Kubeflow release guide

Removed info about configuring a new version of the website, and linked to the Kubeflow release guide instead. PR https://github.com/kubeflow/kubeflow/pull/4127 adds the info to the Kubeflow release guide.
Fixes https://github.com/kubeflow/website/issues/1153

This change is

/assign @abhi-g


[staging] [onboarding] expand button on create a new project doesn't aline up

Step
logging into your dashboard and check on the onboarding part
Expected
The expand button icon should aline up with the create a project
Actual

Does look just to be on 'Staging' -- Which browser @chennan47 ? -- and can you check other browsers?

@lbanner I am using chrome. Have tested this problem on Chrome 40, Safari 7, firefox 35 on OSX ver 10 and Chrome 40, firefox, IE 11 on windows 8.1. It appears that this problem only happen to Chrome and Safari.

@caneruguz ?

There are some strange things happening on develop branch, most of which are issues that are not on production and some are things that were fixed earlier. This is something Steve showed me. We looked into it, and could not understand what could possibly cause this.  Before we go on trying to fix this I would like to make sure it's not a regression of recent changes to osf.
@sloria .

Sounds good @caneruguz TY

Yes, will look into this.

@lbanner this should be fixed after Steve's change to the css load, I'm not seeing it in production. We can close this issue.

Got it -- TY


Strange compilation errors

After some combination of npm installs and deleting package-lock.json, both powerAction.ts and powerCapabilities.ts failed to compile.  In both cases, it was attempting to return a value from a function declared as returning Promise<void>.
mps % npm run build

><EMAIL_ADDRESS>build
> tsc

src/routes/amt/powerAction.ts:24:5 - error TS2322: Type 'Response<any, Record<string, any>>' is not assignable to type 'void'.

24     return res.status(200).json(powerAction).end()
       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

src/routes/amt/powerCapabilities.ts:21:5 - error TS2322: Type 'Response<any, Record<string, any>>' is not assignable to type 'void'.

21     return res.status(200).json(bootCaps).end()
       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Found 2 errors in 2 files.

Errors  Files
     1  src/routes/amt/powerAction.ts:24
     1  src/routes/amt/powerCapabilities.ts:21

The fix, should this occur, is either to remove the 'return' keyword or move it to a new line in these two files (falling through would simply return in both cases, but probably better to make it explicit).
After restoring my package-lock.json, this problem is no longer reproducible.
However, one of the fixes should be applied as trying to return something when void is expected doesn't make sense.

This is likely due to the upgrade to a newer version of typescript. We'll address shortly.


[CLI::Open] Support exiting when selecting gem

Closes https://github.com/bundler/bundler/issues/5301

@bundlerbot r+


test-branch/execute-job/wrong-commit-sha-on-pr/9c7bb9b3-81ac-4f2d-ad05-c24b03095e36

PR for testing df0819fdd1d0062fd671b26b320c862c59da9050

/canonical/self-hosted-runners/run-workflows 931ad21dd9ace68aaa0a7d341e94de96ad93fa6b


Add Hanom Information Vietnam College

@hanhdt-edu Regrettably, this request has signs of fraud. I have to close it without merging.
It does not mean that something is wrong with the school. The issue is related to a combination of suspicious factors related to the domain itself.
Please feel free to apply for free educational license with an official document which proves that you are a student. You can do it using "OFFICIAL DOCUMENT" tab at https://www.jetbrains.com/shop/eform/students.
Thank you for your understanding!


dont work

"@nestjs/core": "8.4.1",
"nestjs-telegraf": "^2.6.1",
"telegraf": "^4.9.1",
"typescript": "^4.8.2"
`node_modules/nestjs-telegraf/dist/types/index.d.ts:6:158 - error TS2344: Type 'T[U]' does not satisfy the constraint '(...args: any) => any'.
Type 'T[OnlyFunctionPropertyNames]' is not assignable to type '(...args: any) => any'.
Type 'T[T[keyof T] extends (...args: any) => any ? keyof T : never]' is not assignable to type '(...args: any) => any'.
Type 'T[keyof T]' is not assignable to type '(...args: any) => any'.
Type 'T[string] | T[number] | T[symbol]' is not assignable to type '(...args: any) => any'.
Type 'T[string]' is not assignable to type '(...args: any) => any'.
6 export declare type ComposerMethodArgs<T extends Composer, U extends OnlyFunctionPropertyNames = OnlyFunctionPropertyNames> = Filter<Parameters<T[U]>, Middleware>;`

Try to downgrade Typescript version https://github.com/hypeertech/nestjs-telegraf/issues/362#issuecomment-1076249546.
I have already fixed this bug, but this fix will be in the next version (probably).

@Form1ca please, update to nestjs-telegraf v2.6.2. This problem fixed by @Maks1mS in that version.


enforcedPlatform doesn't accept provider from version catalog

Expected Behavior
When you write this it obviously works
dependencies {
    // All the lines below compile and work
    "implementation"(platform(libs.jackson.platform))
    "implementation"(platform(libs.jackson.platform.get())) // Works fine, but you probably don't want to write get
    // of course enforcedPlatform means a little bit different thing
    "implementation"(enforcedPlatform(libs.jackson.platform))
    "implementation"(enforcedPlatform(libs.jackson.platform.get())) // Same
}

Current Behavior
dependencies {
    // All the lines below compile and work
    "implementation"(platform(libs.jackson.platform))
    "implementation"(platform(libs.jackson.platform.get()))
    // Except this one:
    "implementation"(enforcedPlatform(libs.jackson.platform)) // this one THROWS
    "implementation"(enforcedPlatform(libs.jackson.platform.get()))
}

Error is:
... long stack trace ...
Caused by: org.gradle.internal.typeconversion.UnsupportedNotationException: Cannot convert the provided notation to an object of type Dependency: provider(?).
The following types/formats are supported:
  - Instances of Dependency.
  - String or CharSequence values, for example 'org.gradle:gradle-core:1.0'.
  - Maps, for example [group: 'org.gradle', name: 'gradle-core', version: '1.0'].
  - FileCollections, for example files('some.jar', 'someOther.jar').
  - Projects, for example project(':some:project:path').
  - ClassPathNotation, for example gradleApi().

Context
I was trying to use version catalogs and enforcePlatform in build.gradle.kts.
Steps to Reproduce
While self-descriptive, here you have an example:
gradle-bug-enforcedPlatform-version-catalog.zip
Your Environment
Gradle 7.2, Gradle Kotlin DSL.

Sorry that you're having trouble with Gradle and thank you for reporting the issue!
This was already addressed in https://github.com/gradle/gradle/issues/17849. Fix will be available in 7.3.


Custom entity for budget

Read first: https://cloud.google.com/dialogflow/docs/entities-overview
If we want to recognize category names from speech we'll need to make an entity to do so. The entity type, in this case, would be category-name and the entity entries would be the name of those categories (e.g. groceries, electric, utilities, etc).
Create an entity named "category-name" that includes all the default category names as entries. Ask Brady and Buffy if category name data exists so we can add other often used category names.
Question: Will be be able to get the budget for a category who's name is not included? (ie will dialog flow recognize "how much money do I have in my X budget" if X is not an already an entry.

@mjakebarrington You may have already solved this issue with the {} addition. We'll have to do more testing to know for sure.

As I understand it, @{categories, @sys.void}  in dialogflow combined with your search function on line 25 should cover ANY category, including categories created by the user, so long as dialogflow recognizes the user's speech and can correctly parse speech into the string to search.

Yes, this appears to have been resolved.

As a side note *
When I type, pi is a recognized budget. When I use my voice, DialogFlow assumes I meant 'pie'.

Words that sound the same but have different spellings can cause some confusion, but I doubt this is something we can/should resolve on our end. Perhaps we could add entities for common budgets that may sound comparable to something else if they exist. Admittedly, not too many people have a 'pi' budget but some people may enjoy the baked dish enough to have a 'pie' budget. I simply reversed it as an edge case.

Also I believe some layer is having difficulties with very large numbers. My $9,999,999,999,999.99 food budget caused a 'not responding' error. Again... edge case.


Envoy Load Shedding && Maintenance Mode

Title: How to load shed in envoy to help upstream service recover
Description:

Trying to figure out how to configure load shading to help upstream service recover. Currently we are using envoy for s2s communication. I am not sure is load shedding is meant to achieved via circuit breaking or maintenance mode.
Also I am having hard time find documentation on maintenance mode how to enable, disable and configure it. Plus how does envoy behave in this mode.

Really the appreciate the help.
PS: Envoy is a great tool and its community is equally awesome.

Hi @justConfused -- there are 2 related subsystems at least. One primarily protects upstreams:: https://www.envoyproxy.io/docs/envoy/latest/intro/arch_overview/circuit_breaking
The other primarily protects Envoy:
https://www.envoyproxy.io/docs/envoy/latest/intro/arch_overview/overload_manager
What is maintenance mode? I'm not familiar with that Envoy concept yet.

Hi @jmarantz
I would like start up by mentioning, I am very new to envoy. I have been following a talk by @ccaraman
Reducing Mean-Time-to-Detection of Incidents with an Envoy Service Mesh
https://www.youtube.com/watch?v=q_psmHeXaGI

In the talk she mentions putting envoy in maintenance_mode which allowed them to shed load to a service by percentage. It looks to be disjoint from circuit_breakers.
I would like to learn more about this mode and its usage. Following is the relevant documentation I have found. Looking for something more in-depth possibly with an example.
https://www.envoyproxy.io/docs/envoy/latest/configuration/http_filters/router_filter#config-http-filters-router-runtime-maintenance-mode

The above documentation points to how to use runtime (typically via a file system) to have Envoy automatically respond with a 503 (known as "maintenance mode"). There is also a plan to have this be part of the config that can be served via EDS, where it is known as "drop overload" but the concept is the same: https://github.com/envoyproxy/envoy/issues/1355. Today this is only doable via runtime. (Though technically it could be accomplished via a direct response route injected by RDS).

Thanks @mattklein123 this better helps me under this options.


Casting video in electron app

Have you read the FAQ and checked for duplicate open issues?
yes
What version of Shaka Player are you using?
2.5.0-beta2
Can you reproduce the issue with our latest release version?
yes
Can you reproduce the issue with the latest code from master?
N/A
Are you using the demo app or your own custom app?
both
If custom app, can you reproduce the issue using our demo app?
yes
What browser and OS are you using?
electron 4.1.1, macOS 10.14.5
For embedded devices (smart TVs, etc.), what model and firmware version are you using?
N/A
What are the manifest and license server URIs?

N/A
What did you do?

build electron app with shaka player
play video (works fine)
trying cast to TV

What did you expect to happen?

cast starting on TV

What actually happened?

I'm using shaka player in electron app.
Trying to implement cast feature.
Shaka cast init fails here:
!window.chrome
https://github.com/google/shaka-player/blob/master/lib/cast/cast_sender.js#L186
There are no window.chrome object, and it seems that chrome cast library should be add separately.
I've tried to add cast functionality to electron app using electron-chromecast lib, now I got 6007 error code.
Playing video in electron app using shaka player works perfect, the problem only with casting video to TV.
This feature is not supported or problem is on my end?

We have little to no experience with electron.  This sounds more like a problem with electron itself.  All we do is use the browser's APIs for communicating with the Chromecast.  If those APIs aren't available, we can't do anything about it.  Note that in our demo we load a sender library, which you will probably need to do in your app too.
With the 6007 error, is that coming from the Chromecast?  Does it work with clear content?  Are you using PlayReady or Widevine?  Are you using a custom receiver app?  Does your license server require wrapping the request?  What is the value of error.data[0], it should be another Shaka Error object with the error that caused it.

@TheModMaker thank you for the answer. Yeah, the problem is in electron itself: it doesn't support cast. I've tried electron-chromecast as a polyfill, but it is not enough. I'll not investigate deeper, going with other solution.


Error while trying to insert math formula

Hello, I'm trying to insert math formulas (\frac{1}{2} for example) but I get the following error:

What can I do?
Thank you in advance for the availability

Not sure, I assume @DanielJGeiger might know more.


Implement Stargate V2 REST endpoints for keyspace CRUD operations using new gRPC endpoints

As part of incremental work for prototyping Stargate V2 REST api, we need ability to create and access keyspace information.
Recently added (in SGv2) gRPC operations:

rpc CreateKeyspace(CqlKeyspaceCreate) returns (Response) {}
rpc DescribeKeyspace(DescribeKeyspaceQuery) returns (CqlKeyspaceDescribe) {}

are good foundation (instead of generating cql statements) and should be used.

Actually looks like current implementations of gRPC operations do not match well with what REST API needs, so will not change those.
But will implement DELETE operation that was missing so far.


Increase and decrease quantity button not functioning

The button in Momos section beside Chicken Cheese Fried Momo is not functioning.

Assign me to this. I will be working on it.

Fixed in Pull Request - #55


Update docs to show end to end installation of Ubuntu 18.04 on worker

Related to https://github.com/tinkerbell/tink/issues/91

Working Example - https://github.com/thebsdbox/tinkerbell-ubuntu
One step closer! 🎉


refactoring in HashUtilities.getRandomLetterOrDigit()

No need for a condition here, as the Math.abs() method comes in handy.
Casting to char is reduntant.

Task :FileSystem:compileJava FAILED
/tmp/ghidra/Ghidra/Framework/FileSystem/src/main/java/ghidra/util/HashUtilities.java:49: error: incompatible types: possible lossy conversion from int to char
return c;
^

Thank you for the PR, but I don't see a need to change the current implementation.


Mac Installation

There are currently simulator compiler errors on mac computers. In addition, files are install to /usr/local, and so, users of xcode cannot access files without linking that directory.

@joshuagruenstein @FlyingGraysons I do not have access to a mac, and this is sysadmin-y.

@joshuagruenstein @FlyingGraysons this is a critical bug and needs to be fixed quickly.


Switch from akka to pekko

Sorry for the ping 🙏 , but since you've contributed in https://github.com/findify/s3mock in the past I thought you might be interested to know that there's now a new fork of the repo here: https://github.com/marko-asplund/s3mock
Release https://github.com/marko-asplund/s3mock/releases/tag/0.5.0 supports Pekko and is also published on Maven central.
Contributions are very welcome! 😄
@romangrebennikov @pjfanning @shuttie @tonicebrian @ignacioPL @jrouly @thereisnospoon @knservis @ukeller @chetanmeh @joemeszaros @jimirocks @mirosval @markarasev @vizog @nsanglar @carstenlenz @andyscott @dayyan @hospadar


Clean up on  #772

Just a little clean up on the work I did on #772 as follow up.

This passes. @vorburger please can you check and merge this?

PS FTR I haven't actually pulled and myself locally re-verified (I did the original), but I'm sure you have tested this yourself on minikube while you made these changes, so I'll merge.


Cannot read property 'forEach' of undefined in Google Analytics

Version information

Laravel: v8.46.0
Voyager: v1.4
PHP: 8.0.3
Database: MySQL 5.7.24 (e.g. MySQL 8.0)

Description
When i go on my dashboard there is no charts available
Steps To Reproduce
Steps to reproduce the behavior:

Add your google client ID in settings
Go back to the dashboard

Screenshots

I don't know if this can help you but i have :
On line 1352 : var data1 = results[0].rows.map(function (row)
On line 1512 : response.rows.forEach(function (row, i)
On line 1423 : var data1 = results[0].rows.map(function (row)
On line 1484 : response.rows.forEach(function (row, i)

To be honest, I kinda hate that this feature exists in Voyager.  Seems to cause more trouble than it's worth.
Anyway, we simply make use of the Google analytics API library, so those errors are almost certainly coming from there.  Most likely, either the API key is wrong, or you haven't enabled API access in your account.  Or something else along those lines.  Run through the GA docs to make sure you have everything correctly enabled/configured, and let us know.

To be honest, I kinda hate that this feature exists in Voyager. Seems to cause more trouble than it's worth.
Anyway, we simply make use of the Google analytics API library, so those errors are almost certainly coming from there. Most likely, either the API key is wrong, or you haven't enabled API access in your account. Or something else along those lines. Run through the GA docs to make sure you have everything correctly enabled/configured, and let us know.

Hi !
I'm currently working on a local dev env so maybe this is the problem... I have checked both the API key and my API access, they are ok
Update before my answer : I have now the two top charts available BUT i need to open my dev console make it higher as possible (to hide the two charts) and then i can see them... This is "special"


Add lcms port

Little-CMS is used in WebKit and also image libraries.

I needed to install pkgconfig stuff so that libjxl could find lcms2.
https://github.com/unicodon/WebKitRequirements/commit/18d5586c4180b0ccafd11a24b8cfa6e28c9ff194

My plan was to swipe the FindLCMS2 from WebKit and add it to the jxl build.

I'll try this out with my libjxl branch.

Instead of patching we may want to have build/CMakeLists.txt and copy it, like https://github.com/WebKitForWindows/WebKitRequirements/blob/main/ports/pixman/portfile.cmake#L25.


Linux 32bit Build

Attempting to build Linux 32bit from source and it's downloading the 64bit of Electron.
Using the following:
Node:	v6.9.1
Npm:	v3.10.9
Here's the line from the build output:
Downloading electron-v1.3.13-linux-x64.zip

Make sure you're trying to build Atom 1.13 and up.  Atom 1.11 and 1.12 had a bug in the build scripts where it would force x64 installation.


Update required range for exponential notation

We had defined a certain range where the default number-to-text conversion should go from decimal numbers to exponential notation, while leaving some to be implementation-dependent (until 1e10 should use decimal notation; starting from 1e20 should use exponential). In JavaScript, the exponential notation is used starting from 1e21, so we can relax the requirement and start requiring exponential notation from that as well.

✅ No public API change.

✅ No public API change.


Add ".exe" to the TestPackageBinfile test for windows binaries

Fixes:
--- FAIL: TestPackageBinfile (0.00s)
	package_test.go:56: (b).Binfile(): want C:\gopath\src\github.com\constabulary\gb\testdata\bin\b, got C:\gopath\src\github.com\constabulary\gb\testdata\bin\b.exe

Not sure if this is the right fix, but I'll let you judge me on that. :smile:

Yup, LGTM.

:tada:


Feat: Redux toolkit

Describe the feature
I am willing to add the redux toolkit for state management in the application.
Add ScreenShots
No screenshots needed
Record

[X] I agree to follow this project's Code of Conduct
[X] I have checked the existing issues
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

fine.


Expose Error interface

The documentation for Execute states:

// Internal library errors will match the interface Error and you can use type casting to check this.

But, the Error type is unexported so I am unable to do a type check.

I believe this is the type you want: https://github.com/cep21/circuit/blob/master/v3/errors.go#L17

Yeah I saw that that is the type I want, but I suppose I was anticipating it to be exported in the forward.go file so I don't need to reference the versioned path.  Using the versioned path works, but seems counter to the normal usage pattern where you don't need to peer into the v3 path.
If I've been using this wrong and in fact I should be referencing the v3 path then I can switch my imports across the board-- but in that case I would wonder why types are boosted to the top level in closers and forward.go.

forward.go exists because of backwards compatibility and go modules requiring a /v3 import path for SEMVER v3 libraries.  If you're using go modules, then think of "github.com/cep21/circuit/Circuit" as v1 of the Circuit object.
The error interface is only supported in the v3 version of the library.  I recommend using the /v3/ import path.

I would wonder why types are boosted to the top level in closers and forward.go

It was part of the modules migration to not break existing code.  Because type Error didn't exist during the modules migration, I didn't need to promote it.  I would rather not promote it now since the correct way to use go modules is to put semver in the import path.

Ahhh ok, that makes perfect sense.  I'll switch my code to use the v3 path then and add in a type assertion.  Thanks for the help!


feat: implement feature flag for the Zeno frontend

Description
Adds feature flags to Zeno's frontend. They need to be defined in /src/lib/util/features.ts and are stored in a cookie so that they are persisted for users.

This is a very basic implementation of feature flags but I think we need something before we can add bigger new features that might not be ready for broad adoption yet.

What's the main goal of this? To have specific users use a feature? Or for us as developers to use it? Or for us to manage which features are in prod?
If its one of the last two I think we might want another way of doing this where we can set features in some admin panel?

What we probably ultimately want to be able to do is:

as devs activate/deactivate features on the fly (for this something in the UI would be good, maybe just in dev deploy)
activate/deactivate features for specific user groups

For 2. I think we need bigger changes and a broader discussion on how to do this. This is just a quick implementation to get feature flags. It should not prevent us from moving to something else in the future. I think the most important thing is to have something for now. Changing the implementation will be pretty easy.

SGTM!


Mermaid is wikis: note about limited support is now more prominent

It didn't work for me that the documentation shows the link to the flowchart functionality in Mermaid but the keyword is not supported.
This PR expands and rearranges the note about some functionality not being supported.

(other content here)

@chcomley
Can you review the proposed changes? IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team


[ALL] Refactored Core to use DispatchData via Buffer typealias

This PR will refactor the entire codebase away from Data to typealias Buffer = DispatchData for all byte array storage.
There are several reasons for doing this:

Data leaks memory horribly on macOS in Zewo most likely due to lack of autorelease pool
Data is hard to work with in a zero-copy fashion for reading
DispatchData by default tries its hardest to never copy the underlying buffers
DispatchData allows more control over when and how memory pointers are created/deallocated

We should see some decent performance gains and less memory usage.

Current coverage is 70.66% (diff: 42.59%)

Merging #150 into master will decrease coverage by 0.70%

@@             master       #150   diff @@
==========================================
  Files           131        131
  Lines          6720       6786    +66
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
- Hits           4796       4795     -1
- Misses         1924       1991    +67
  Partials          0          0

Powered by Codecov. Last update 3b3b1f3...462d908


[Quick Tour] pre-requisite - docker should be intalled and started/restarted

Description:
Can we mention like $subject for "Deploying on Docker" steps?
This is because to avoid any unnecessary issue occurring like below

I tried the "Deploying on Docker"
Docker was already up and running in windows
After code changes, ballerina build hello_service.bal was failing

PS C:\Users\wso2\Desktop\QuickGuide\project1> ballerina build hello_service.bal
error [docker plugin]: Unable to build docker image: Get https://registry-1.docker.io/v2/: dial tcp: lookup registry-1.docker.io on <IP_ADDRESS>:53: read udp <IP_ADDRESS>:46285-><IP_ADDRESS>:53: i/o timeout
ballerina: Oh no, something really went wrong. Bad. Sad.
There should be a file named "ballerina-internal.log" in the current directory.
If you are able to share with us the code that broke Ballerina then
we would REALLY appreciate if you would report this to us:
go to https://github.com/ballerina-platform/ballerina-lang/issues and
create a bug report with both this log file and the sample code.
We thank you for helping make us better dancers.

This has resolved once I restarted the docker, so can we improve our steps there?

Fixed with https://github.com/ballerina-platform/ballerina-www/pull/784


cli_parser: Add depends_on, required_for and conflicts for switch options

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[x] Have you written new tests for your changes? Here's an example.

[x] Have you successfully run brew tests with your changes locally?

Declaration of depends_on , required_for and conflicts constraints were added for flags  in https://github.com/Homebrew/brew/pull/3987
This PR extends the same functionality for switch options.

👍. Merge when ready!


Schedule CI every morning

 CI-Update

https://github.com/geo-engine/ci-tests/actions?query=workflow%3ACI
Seems to work here


Bug in v6 of angular/cli for custom collection: 'Data path "" should have required property' even though the property is supplied on the cli

Bug Report or Feature Request (mark with an x)
- [x ] bug report -> please search issues before submitting
- [ ] feature request

Area
- [ ] devkit
- [x ] schematics

Versions
Windows 10
Angular CLI: 6.0.8
Node: 8.11.3
OS: win32 x64
Angular:
...
Package                      Version
@angular-devkit/architect    0.6.8
@angular-devkit/core         0.6.8
@angular-devkit/schematics   0.6.8
@schematics/angular          0.6.8
@schematics/update           0.6.8
rxjs                         6.2.1
typescript                   2.7.2
Repro steps

Install @angular/cli 6.0.8 globally
Create a new schematic in C:\Projects\Schematics and do an npm install
cwd should be C:\Projects\Schematics
In the collection.json, add "extends": ["@schematics/angular"]
In the collection.json, add an application schematic under the "schematics" collection like so:

{
  "$schema"<EMAIL_ADDRESS>  "extends": ["@schematics/angular"],
  "schematics": {
    "application": {
      "description": "A blank schematic.",
      "factory": "./application",
	    "schema": "./application/schema.json"
    }
  }
}

In "./application/schema.json", add a required 'name' and 'directory' property

{
	"$schema": "http://json-schema.org/schema",
	"id": "testschema",
	"title": "test schema",
	"type": "object",
	"properties": {
		"name": {
			"type": "string"
		},
		"directory": {
			"type": "string",
			"format": "path",
			"description": "The directory name to create the app in.",
			"alias": "dir"
		}
	},
	"required": [
		"name",
		"directory"
	]
}

in the schematic's package.json, change the 'name' to test-schematic

npm run build

npm link

cd to C:\Projects

npm link test-schematic

npm install

ng new --collection=test-schematic --name=test --directory=test

Now you will see this error in the terminal:
Schematic input does not validate against the Schema: {"projectRoot":"","name":"test","inlineStyle":false,"inlineTemplate":false,"prefix":"app","routing":false,"style":"css","skipTests":false,"skipPackageJson":false}Errors:
Data path "" should have required property 'directory'.
Even though the --directory option was supplied.
Adding a console.log(options) to the entry function after attempting the same command will show an object with
'directory': undefined

downgrade global @angular/cli to version 1.7.3
ng new test --collection=test-schematic --directory=test  will now work properly

The log given by the failure
Schematic input does not validate against the Schema: {"projectRoot":"","name":"test","inlineStyle":false,"inlineTemplate":false,"prefix":"app","routing":false,"style":"css","skipTests":false,"skipPackageJson":false}Errors:
Data path "" should have required property 'directory'.
Desired functionality

all custom option values passed into the cli for a custom collection should be used and not discarded.
Should NOT have to extend @schematics/angular for ng-new to work with custom collections.
(angular cli v1.7.3 lets you use ng-new on custom collections without having to extend the base angular schematics).

Mention any other details that might be useful
Adding unit tests and running a test run with the schematics-cli allows all unit tests to pass with the directory option passed in successfully, but angular-cli doesnt recognize directory in the custom collection.

This should already be addressed and fixed in the next release with PR #11083.


Changed link of "good first issue" and "help wanted"

This change is

@sarahmaddox @jlewi I have reverted back the changes. Please review the PR.

/assign
/ok-to-test

@sarahmaddox I have updated the links. Please review it.
Thanks!

Preview: https://deploy-preview-1410--competent-brattain-de2d6d.netlify.com/docs/about/contributing/#starter-issues
Thanks!
/lgtm
/approve

/retest


express validation on param converter

Hi,
How I can use validation in a param converter?
I wanted to use Joi.objectId () to validate that this is a mongodb valid id
router.route('/:id')
  /** GET /api/users/:userId - Get user */
  .get(validate(paramValidation.get),userCtrl.get)

  /** PUT /api/users/:userId - Update user */
  .put(validate(paramValidation.updateUser), userCtrl.update)

  /** DELETE /api/users/:userId - Delete user */
  .delete(validate(paramValidation.deleteUser), userCtrl.remove);

/** Load user when API with userId route parameter is hit */
router.param('id', userCtrl.load);

Thanks and regards

Hi @sergio11
You can validate mongo id like this.
You have to this for each api validation having id in the API path as this cannot be done directly with param converter.
  param: {
      id: Joi.objectId()
  }

Thanks for answering.
As you say, I am validating on each endpoint the param id.
updateUser: {
    body: {
      fullname: Joi.string().required(),
      username: Joi.string().required(),
      password: Joi.string().regex(/^[a-zA-Z0-9]{5,30}$/),
      website: Joi.string().optional(),
      biography: Joi.string().optional(),
      email: Joi.string().email(),
      mobileNumber: Joi.string().regex(/^[1-9]{9}$/).required()
    },
    params: {
      userId: Joi.objectId()
    }
  }

The problem is that the param converter runs before and causes the following error when I provide an invalid _id (/api/users/dsadas232):
CastError: Cast to ObjectId failed for value "dsadas232" at path "_id"
I am looking forward to your response. regards

@sergio11 It should be id: Joi.objectId(). Can you try with this change ?

I've already changed it and I still get the same error.

@sergio11 oh sorry. CastError: Cast to ObjectId failed for value "dsadas232" at path "_id" is actually valid errors. Trying using /api/users/57a3079225028ce79705e88b and you won't get the error.
http://stackoverflow.com/questions/13850819/can-i-determine-if-a-string-is-a-mongodb-objectid


error while running the demo in rviz

Got the error in planned robot model in Rviz

It looks to me like your TF tree is mal-formed. This might mean that one of the nodes didn't launch correctly. Can you expand the left side panel so I can see the errors? Also can you post the terminal logs from the ROS node?


V3 sdk samples

Fixes #
Proposed Changes

Testing

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: tapasviparmar sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


more like a cheatsheet

This is ace, bu not really a cheatsheet as its too long form, would it be useful to actually attempt to put the same information (in short hand) on a page or couple of pages for "quick" reference?  This woud probably mostly be a design challenge TBH. And happy to help

Hi @benbyford ! I explained here the motivations behind the name.
If you want to try something to make it fit on an A4 page I'm open to suggestions and propositions, but yeah quite a challenge 😅


Numeric input on mobile web

https://github.com/web-ridge/react-native-paper-dates/blob/master/src/CalendarEdit.tsx#L147
Blocked by: https://github.com/necolas/react-native-web/issues/1705

PR is made to React Native Web: https://github.com/necolas/react-native-web/pull/1709


Encrypt the HTTPBody when make a request and decrypt the HTTPBody when receive a response

Hello, my server is not over SSL so I want to know how to
Encrypt the HTTPBody when make a request.
Decrypt the HTTPBody when receive a response.
Thanks.

Hi @Shuangzuan,
Questions like these should be asked on Stackoverflow. Github is for reporting issues and feature requests.
:beers:


Update README.md

Add information on how to use build flags to reach different log levels.

:+1:

Thanks for the PR, this has been merged in.


Update docs/tutorial/examples for exists

Describe the bug
Docs/tutorials/examples are outdated for db.exists API.
To Reproduce
Steps to reproduce the behavior:

Follow db.exists here
OR
Follow db.exists here
OR
Follow db.exists here

Expected behavior
Docs should follow API of 2.x binding.
Screenshots
Exists in new API is wrapper in where

Versions (please complete the following information):

prisma-binding 2.x

Additional context
https://stackoverflow.com/questions/51013126/graphql-mutation-throwing-error

Can someone please explain this further.. 😊
export Interface Exists{
Link: (Where?: LinkWhereInput) => Promise
User: (Where?: UserWhereInput) => Promise
Vote: (Where?: VoteWhereInput) => Promise
}
This is the error I am getting..
Apparently it's caused by the 'exists' function having the wrong syntax..
However I don't know how to solve it.
Below is the code 👇🏼
async function vote(parent, args, ctx, info) {
const { linkId } = args;
const userId = getUserId(ctx);
const linkExists = await ctx.db.exists.Vote({
user: { id: userId },
link: { id: linkId }
});
if (linkExists) {
throw new Error(Already voted for link: ${linkId});
}
return ctx.db.mutation.createVote(
	{
		data: {
			user: { connect: { id: userId } },
			link: { connect: { id: linkId } }
		}
	},
	info
);

}

I had the same issue. First, make sure your cli and server have both the same versions. Second, delete the "generated" directory and run prisma generate with a complete clean slate.


Mention Github Signature Verification Issue

Description
I'd like to add the information, that Github Signature Verification of Keyless Signatures is currently not supported, to page "Detailed Gitsign Usage".
The paragraph would also link to the respective Github Issue, so that interested users can check for the latest status of this feature. This might even help to raise visibility of the issue, since users can upvote this ticket.

Are you planning on doing a PR for this? I can tackle it, but I also encourage you to do a PR, or to share some proposed text here in the issue. Thank you!


Cabana: support live streaming

support live streaming from a panda or c3.
cabana will only cache settings.cached_segment_limit * 60 seconds data in the memory to prevent memory exhaustion in living mode. you can change this setting in the option dialog : menu->files->settings->Cached segment limit
usage:
receive msgq messages:
cabana --stream
receive zmq messages:
cabana --stream --zmq="<IP_ADDRESS>"
Currently, there are some restrictions in the live streaming mode.

no video
can't disable dynamic mode in historylog (the "dynamic mode" checkbox is disabled)
can't zoom-in/zoom-out charts
can't pause, or seekto a positon

I'll try to remove some of these restrictions in the future.
Kazam_screencast_00048.webm

This will be amazing for new car ports or general debugging, thanks deanlee!!

Conflict with https://github.com/commaai/openpilot/pull/26970. temporarily convert to draft to wait  for  https://github.com/commaai/openpilot/pull/26970 to be merged first.

Looks like fading of the colors broke in this PR. In https://github.com/commaai/openpilot/pull/26970 the red/cyan slowly fade out.

That looks correct!

Probably best to keep these extra color changes separate from the streaming PR. There is no need to abstract it into a class to be able to merge this.

ok,I'll remove these changes

@adeebshihadeh this pr is ready. many later works depends on this. It's getting harder to fix it's conflicts with the master.

@sshane can you test a bit and merge?

I also have code for an AbstractStream implementation that connects to a panda directly. Can submit a PR if you're interested (and this PR is merged).

that's great!!

I also have code for an AbstractStream implementation that connects to a panda directly. Can submit a PR if you're interested (and this PR is merged).

Any reason not to use boardd? I think sendcan/can are already a nice abstraction if people want to use other CAN tools.

I'm trying to get cabana to run on Windows as well, not requiring any messaging makes the setup much simpler 😅. It uses the same Panda class as boardd, so it's only a few lines different from @deanlee's livestream.
No worries if you're not interested in maintaining it!

I'm trying to get cabana to run on Windows as well, not requiring any messaging makes the setup much simpler sweat_smile. It uses the same Panda class as boardd, so it's only a few lines different from @deanlee's livestream.

Should be fine if it's a small change. Maybe <20 lines?

Seems to be working well on my desk with a C3!

Thanks @deanlee! I'll do some more testing in a car with a real use and lyk if I see any issues. Pausing the way PlotJuggler handles it with live streaming would be nice 😄


New package: SoilWater_ToolBox v0.1.0

Registering package: SoilWater_ToolBox
Repository: https://github.com/manaakiwhenua/SoilWater_ToolBox.jl
Created by: @joseph-pollacco
Version: v0.1.0
Commit: 9ff6970d888507cad849f7d59fbd4618593200a7
Git reference: HEAD
Release notes:

New Package

New package

SoilWater-Toolbox

@joseph-pollacco I'm going to close also this pull request, but of course feel free to register again the package when you're ready

Dear Mosè Giordano,
A great thanks for your kind help. I have now resubmit it.
Have a great day,
joseph
Your new package pull request met all of the guidelines for auto-merging and is scheduled to be merged when the mandatory waiting period (3 days) has elapsed.
Since you are registering a new package, please make sure that you have read the package naming guidelines: https://julialang.github.io/Pkg.jl/dev/creating-packages/#Package-naming-guidelines-1https://aus01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fjulialang.github.io%2FPkg.jl%2Fdev%2Fcreating-packages%2F%23Package-naming-guidelines-1&data=04|01|pollaccoj%40landcareresearch.co.nz|7c20300ee60245ae139108d94d61cab7|43050530b3c74cd2a11cb826b2604b5b|0|0|637625904679057918|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=BjuUNwSgS6HoroT43aTPl%2FI6DC7Go2a7toTSWYGIYT0%3D&reserved=0
From: Mosè Giordano @.>
Sent: Friday, 23 July 2021 10:06 AM
To: JuliaRegistries/General @.>
Cc: Joseph Pollacco @.>; Mention @.>
Subject: Re: [JuliaRegistries/General] New package: SoilWater_ToolBox v0.1.0 (#40577)
@joseph-pollaccohttps://aus01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fjoseph-pollacco&data=04|01|pollaccoj%40landcareresearch.co.nz|015e0288faf74a37ba6808d94d5cd655|43050530b3c74cd2a11cb826b2604b5b|0|0|637625883397952940|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=RS78L4DydOFaH9smUqkAkuAFxKZ9I6RroxjrbR1Q4JE%3D&reserved=0 I'm going to close also this pull request, but of course feel free to register again the package when you're ready

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://aus01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FJuliaRegistries%2FGeneral%2Fpull%2F40577%23issuecomment-885265446&data=04|01|pollaccoj%40landcareresearch.co.nz|015e0288faf74a37ba6808d94d5cd655|43050530b3c74cd2a11cb826b2604b5b|0|0|637625883397962938|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=iUFleFa%2BdijdpOJBOReU9XxlwsUDy%2FfwHkk%2BbB0tDG8%3D&reserved=0, or unsubscribehttps://aus01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FACVGEEELAJ4YXJUHKAEMG43TZCI2XANCNFSM5ACPP6ZQ&data=04|01|pollaccoj%40landcareresearch.co.nz|015e0288faf74a37ba6808d94d5cd655|43050530b3c74cd2a11cb826b2604b5b|0|0|637625883397972940|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=AxlXbKB7JVczlqFOLOV%2Bl2CqxlMD5%2FrBNIgoOCIgi0A%3D&reserved=0.

Please consider the environment before printing this email
Warning: This electronic message together with any attachments is confidential. If you receive it in error: (i) you must not read, use, disclose, copy or retain it; (ii) please contact the sender immediately by reply email and then delete the emails.
The views expressed in this email may not be those of Landcare Research New Zealand Limited. http://www.landcareresearch.co.nz


pr2_robot: 1.6.24-0 in 'indigo/distribution.yaml' [bloom]

Increasing version of package(s) in repository pr2_robot to 1.6.24-0:

upstream repository: https://github.com/UNR-RoboticsResearchLab/pr2_robot.git
release repository: https://github.com/pr2-gbp/pr2_robot-release.git
distro file: indigo/distribution.yaml
bloom version: 0.6.2
previous version for package: 1.6.23-1

I'm a little confused as to why this is failing, is there someone I can talk to offline about this problem?

Do you have access to push to: https://github.com/pr2-gbp/pr2_robot-release ? There do not appear to be any recent changes pushed there by you.
 Such as @TheDash

I spoke with @TheDash. Since Clearpath is no longer supporting him to maintain the PR2, he asked me to fork the repos. I don't have push access to pr2-gdp/pr2_robot-release, so I forked the release repo as well.

Are you willing to take over as the ongoing maintainer? If so could you update the package.xml files with your information and we'll figure out access for the necessary repositories.

Yes, I'll do so. Note, I can only submit pull requests right now, so
someone will have to accept them for the office repos to see me as
maintainer.
-Dave
On Wed, Mar 14, 2018 at 1:55 PM, Tully Foote<EMAIL_ADDRESS>wrote:

Are you willing to take over as the ongoing maintainer? If so could you
update the package.xml files with your information and we'll figure out
access for the necessary repositories.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ros/rosdistro/pull/17107#issuecomment-373171343, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AFmFuaHzG1GRlh7KiNK3TQ2Spq0gQRh3ks5teYOkgaJpZM4Sl0jc
.

That's good. Please open a ticket on both the upstream repo and the gbp repo to officially request access so you can maintain them in place.

Issues opened, ready to maintain both repos. Access requested for several others where updates will be coming.

@davefeilseifer I see that #17182 has been opened and merged, can this be closed then ?


Allow for nested chex.chexify

Hello, I have a dilemma with chexify - consider the following code:
# If this is not commented out, the second test will fail
# If this is commented out, the first test will fail
@chex.chexify
@jax.jit
def log_safe(x: jnp.array) -> jnp.array:
    chex.assert_trees_all_equal(x > 0, jnp.ones_like(x, dtype=bool))
    return jnp.log(x)

@chex.chexify
@jax.jit
def combo_safe(x: jnp.array) -> jnp.array:
    chex.assert_trees_all_equal(x != 1, jnp.ones_like(x, dtype=bool))
    return log_safe(x) / (x - 1)

def test_log_safe() -> None:
    x = jnp.array([1.0, 2.0, 3.0, -1.0])
    with pytest.raises(Exception):
        log_safe(x)
        log_safe.wait_checks()

    x = jnp.array([1.0, 2.0, 3.0, 4.0])
    assert jnp.array_equal(log_safe(x), jnp.log(x))
    log_safe.wait_checks()

def test_combo_safe() -> None:
    x = jnp.array([1.0, 2.0, 3.0, 4.0])
    with pytest.raises(Exception):
        combo_safe(x)
        combo_safe.wait_checks()

    x = jnp.array([2.0, 3.0, 4.0, 5.0])
    assert jnp.array_equal(combo_safe(x), jnp.log(x) / (x - 1))
    combo_safe.wait_checks()

If I comment out the first chexify the test_log_safe test will fail with RuntimeError: Value assertions can only be called from functions wrapped with @chex.chexify. See the docs. which makes sense to me. However, once I add the decorator back in, the second test fails with RuntimeError: Nested @chexify wrapping is disallowed. Make sure that you only wrap the function at the outermost level.
A hack in this simple scenario would be to make two versions of the function, a log_safe without the chexify decorator and a log_safe_test = chex.chexify(log_safe) and only call the log_safe_test version during my test. However, that solution is pretty clumsy, especially if I have a lot of these scenarios. In a codebase that is fully end-to-end jax, that would mean all but the outermost function require this hack. Would it be possible to allow for nested chex.chexify where subsequent applications of the macro simply do nothing, or just raise a warning?

I'm also finding the recent-ish change to disallow multiple chexify quite difficult since my graph of functions is not a tree with a single root but I still want chexify in this situation: f() calls g() calls h(), and g() calls h()


The home page following content UI need to change. Currently it is not balanced.

please work on the home page and update the UI design accordingly try to make the home page UI beautiful and balanced.


Items don't get soul fire

Basically since the search is limited to MobEntity, when items just extend Entity.
I see no reason why it shouldn't allow any type of entity.

Fixed in next update


Add .editorconfig File [Assigned to estevanjantsk]

For consistency of formatting in different editors, we should add an .editorconfig file to the project.

Hey! I'll help with this one! Can you assign this issue to me? 👍

 @AlphaT3ch hi man! =DDD! Nice project and wow, what a nice solution for URL shortener. o.o. Well, saw this project in hacktoberfest filter and here I am! Bro fist.

@estevanjantsk Awesome! Totally assigned to you. Ready to go!

Addressed in #7


Fixed losing transparency of PNGs (image_picker)

When the user picks a png that has transparent pixels, these are then lost (made black). This was caused by always saving the image as JPEG when resizing.
At first I always saved the image as PNG, but that did not work very well for Android, where the JPEG format carried important rotation (EXIF) information. So for Android I am deciding the output format based on the file extension. For iOS things are a bit simpler and we can just always save as png.

@roughike would you mind reviewing this? You seem to have had the most impact on this plugin in recent months. :-)


save videos for sessions

Motivation/Description of the PR

Description of this PR, which problem it solves
Resolves #issueId (if applicable).

Applicable helpers:

[ ] WebDriver
[ ] Puppeteer
[ ] Nightmare
[ ] REST
[ ] FileHelper
[ ] Appium
[ ] Protractor
[ ] TestCafe
[х] Playwright

Applicable plugins:

[ ] allure
[ ] autoDelay
[ ] autoLogin
[ ] customLocator
[ ] pauseOnFail
[ ] coverage
[ ] retryFailedStep
[ ] screenshotOnFail
[ ] selenoid
[ ] stepByStepReport
[ ] stepTimeout
[ ] wdio
[ ] subtitles

Type of change

[ ] :fire: Breaking changes
[ ] :rocket: New functionality
[ ] :bug: Bug fix
[ ] :clipboard: Documentation changes/updates
[ ] :hotsprings: Hot fix
[ ] :hammer: Markdown files fix - not related to source code
[ ] :nail_care: Polish code

Checklist:

[ ] Tests have been added
[ ] Documentation has been added (Run npm run docs)
[ ] Lint checking (Run npm run lint)
[ ] Local tests are passed (Run npm test)

Is it not available for playwright ? If not , When can we expect this ?


⚠ Mobitopup has degraded performance

In 29d5b35, Mobitopup (https://napcard.voz.tech) experienced degraded performance:

HTTP code: 200
Response time: 8650 ms

Resolved: Mobitopup performance has improved in 132c1c9.


feat: cleaning long running transactions by recycling sessions

Automatically cleaning long running transactions

Closing this PR , as we are not going ahead with this solution


Adding more tests

Coverage increased (+0.2%) to 81.51% when pulling b4e5905f29af3c0eba4ef623d492a327bc9deddb on features/more_tests into 0d415607a4fcfee711b854e4909b7846e1ee2909 on master_V0.5rc.

Coverage increased (+0.3%) to 81.647% when pulling<PHONE_NUMBER>19b32d8ca023a69c89ccb8ec1d8924 on features/more_tests into 215e07d562ef38029cf63dde0afee757ad8b4494 on master_V0.5rc.


setup script and install script user flag is inverted for no reason and it's annoying

fixed. Both now use --full flag instead.


Change title transformations to keep it consistent

Change a few titles to make it consistent with the other transformations pages.

@gmsantos : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@gmsantos : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@gmsantos : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off


images

Successful Ansible Tower creation and login.

Amazon EC2 Instance Info

Info on SSHing to the EC2 instance:

Error connecting to EC2 Instance over SSH:
The PEM key permissions were too insecure.

I am on a Windows machine using Cygwin. chmod 400 devops.pem does not actually change the permissions.

The solution:

based on this link and some general exploration.
moved devops PEM file to /home/vishy/.ssh/ folder.
changed Group of .ssh to Users using chgrp Users /home/vishy/.ssh/
changed Group of devops.pem to `Users similarly.
*now, changing the permissions to 0400 worked.` :+1:

Starting EC2 instance using Vagrantfile
When starting the EC2 instance using the Vagrantfile, I encounter the error:

gem install nokogiri does not appear to work for Windows.
The issue appears to be related to support of the nokogiri gem for Ruby 2.2+ (my version of Ruby). reference.
I downgraded to Ruby 2.0.0 p648.

AWS Account Blocked
My AWS Account got blocked. This was likely due to my own stupidity - I put my credentials out to the world for everyone to see :-1:

"default" security group does not allow SSH by default!
Reference.
In the above page:

Important
Your default security group does not allow incoming SSH traffic by default.

This was causing me hours of trouble SSHing to my instance.
As a result I had to add a rule allowing SSH.

After this, SSH worked properly. :+1:

first successful ansible ping to deployed hosts

Ansible Installation of Jenkins on EC2

Error restarting iptables for Ansible Tomcat Config

java-1.7.0-openjdk does not contain javac.
To be able to compile the source code for the site being deployed you would need to install
java-1.7.0-openjdk-devel.
http://stackoverflow.com/a/15088523/682912

Error accessing manager console for Tomcat deployment

My server.xml, tomcat-users.xml are properly configured.
I have configured an admin user to access the "manager-gui" role.

However, the UI fails to give me access. It keeps failing with a 401 error.

After taking a look at the tomcat logs at tomcat/logs/ I found the following error:

How to install mkpasswd on EC2 machines:
Use yum whatprovides mkpasswd. This will tell you the package that provides it.
On EC2, it is provided by the expect package.
http://pikedom.com/?p=74

I faced lots of trouble with the file module of Ansible. It just wouldn't change the permissions or ownership of certain files. And so starting up Tomcat would always fail.
Finally what worked for me was running shell: /bin/chmod -R

The deployed application :+1:

Vagrant is unable to execute rsync step
After a Vagrant box is brought up using vagrant up, an rsync step appears to fail.
I have not managed to solve this one yet.


Document handler js error fix, package.json main update

JS errors were occurring due to outright reference to module when module did not exist in the global scope. Changing to reference as property of window to avoid JS errors.
Also updating package.json's main property to point to www/DocumentHandler.js, which should be the entry point rather than index.js which does not exist.
@vkajtazov can you please review?

Yeah of course,
I will review your pull request, but let me know more details about your problem.
Did it happen when installing the plugin ?
Which Cordova version are you using ?

Cordova version 7.1.0. No errors installing, but after loading DocumentViewer.js I'm immediately seeing Uncaught ReferenceError: module is not defined due to my project not using RequireJS. Since DocumentHandler.js has a check for the existence of the module object before attempting to export itself, it seemed reasonable that the conditional should be able to fail gracefully when module did not exist in the global scope.
The package.json change didn't correct any error for me since I'm loading the file manually, but for others it would be beneficial for the main property to reference the primary JS file in the project.

@gdvsbp
Released new NPM version 1.0.14 with your changes.


Allow query params in OIDC authorization endpoint

Do you have an example where this would be necessary?

Twitch requires a custom param to get email claims:
https://id.twitch.tv/oauth2/authorize?claims=%7B%22id_token%22:%7B%22email%22:null%7D%7D

( btw Cloudflare also have a quirk that they send HTTP Basic Auth headers without Base64 padding which is a disobey of RFC


Support Authorization Code Flow with PKCE

The web/pwa implementation retrieves the token by using response_type=token on the authorization request.
Thats differs how its done in Android.
Within this task I will use response_type=code with a code_challenge in the web implementation as well.

https://developer.okta.com/authentication-guide/implementing-authentication/auth-code-pkce

This does not include having to use the app secret, which will not be supported because of security reasons.

Note that OAuthSwift added support for PKCE https://github.com/OAuthSwift/OAuthSwift/issues/501#issuecomment-460289428

For code response type PKCE will be enabled by default because it's the most common use case for code.
A additional option will allow disabling this default behaviour.

Note: OAuthSwift with PKCE is not released yet!

Althougth it might be easier for me as plugin developer to leave everything to the user but as a user I don't want to do PKCE myself. So I most probably introduce 1-2 dependencies to the web part and let the plugin handle everything.
Web:

base64url
SHA256: https://github.com/dchest/fast-sha256-js

OauthSwift 1.3.0 was released today. :)

As mentioned above PKCE is enabled by default if code flow is used.
To disable PKCE set the new option pkceDisabled to true.
Note: I tested PKCE only with Google OAuth provider, which does not require the usage of PKCE and works with and without it.


Failing scenario - pfs5_too_low_capacity - 02.08.2019

Scenario also failed on 31.07.2019 -> see #150
DevOpsBot 09:06
Starting run for scenarios ‘pfs5_too_low_capacity’..
DevOpsBot 09:18
❌ Error while running scenario: assertion errors!
Log can be downloaded from:
http://scenario-player.ci.raiden.network/Scenario_player_Logs-pfs5_too_low_capacity-1-latest-2019-08-01.tar.gz

@palango Please close this issue, if it is related to #150

@christianbrb Do you mena 1.8. in the title, today it didn't run yet.

@palango Ups, have been too fast and copied a report from yesterday. Closing this.


Error message should provide link to ruget + miette bug trackers

In @zkat's tweet https://twitter.com/zkat__/status/1428962008699793412/photo/1, the final message is
This is a bug. It might be in ruget, or it might be in the source
you're using, but it's definitely a bug and should be reported.

The question arises, to whom or what should the bug be reported?
Providing a link to both ruget and miette's Issues pages would be a great start, and if it's not in miette or ruget then whoever is maintaining those projects can guide the submitter to a more appropriate project to file a bug with.

so, there's two bits here: We already support arbitrary (clickable!) URLs for individual diagnostic codes. Second, we have #34, which I'm gonna mark this as a duplicate of, and close this issue.


[GLUTEN-5720][VL] Enable left and right semi join type in smj

What changes were proposed in this pull request?
Support left  and right semi join in SMJ.
How was this patch tested?
Adding new unit test.

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query
log/native_5825_time.csv
log/native_master_06_05_2024_54aeb010d_time.csv
difference
percentage

q1
36.22
34.06
-2.165
94.02%

q2
23.56
23.10
-0.457
98.06%

q3
39.78
36.59
-3.186
91.99%

q4
30.69
34.70
4.004
113.04%

q5
69.83
69.24
-0.591
99.15%

q6
10.01
7.84
-2.172
78.30%

q7
79.29
81.42
2.126
102.68%

q8
85.09
87.21
2.114
102.48%

q9
123.90
119.35
-4.551
96.33%

q10
44.27
45.23
0.960
102.17%

q11
20.39
22.65
2.260
111.08%

q12
27.92
25.04
-2.887
89.66%

q13
36.47
36.70
0.225
100.62%

q14
18.66
17.35
-1.314
92.96%

q15
32.96
29.97
-2.992
90.92%

q16
13.99
15.12
1.129
108.07%

q17
102.32
104.42
2.104
102.06%

q18
147.61
144.82
-2.796
98.11%

q19
15.00
14.62
-0.381
97.46%

q20
29.40
26.48
-2.917
90.08%

q21
258.44
266.79
8.352
103.23%

q22
12.23
12.29
0.058
100.47%

total
1258.04
1254.96
-3.078
99.76%


Compressed pdf larger than original?

$ pdfly compress in.pdf out.pdf
Original Size  : 1,996,123
Compressed Size: 2,014,972 (100.9% of original)

How is this possible?

Please complete with test code, input file and output file
Like this, we can not do  any review

I am having the same issue with multiple pdf files.
$ pdfly compress Lockhart_2002_-_A_Mathematician\'s_Lament.pdf Lockhart_compressed.pdf
Ignoring wrong pointing object 0 0 (offset 0)
Ignoring wrong pointing object 91 0 (offset 0)
Ignoring wrong pointing object 93 0 (offset 0)
Original Size  : 400,277
Compressed Size: 418,320 (104.5% of original)

Lockhart_2002_-_A_Mathematician's_Lament.pdf
Lockhart_compressed.pdf
Another example:
$ pdfly compress Example_form.pdf Output.pdf
Original Size  : 95,569
Compressed Size: 103,325 (108.1% of original)

Strangely, trying to compress the output of this form reduces the size, although it is still larger than the original:
$ pdfly compress Output.pdf Out2.pdf
Original Size  : 103,325
Compressed Size: 98,634 (95.5% of original)

Example_form.pdf
Output.pdf
Out2.pdf

these cases are possible. The compression applies a loss-less compression on streams but some other solution such as building streams of object could reduce size too. However pypdf currently has no capability to build such streams and define a strategy to compress them.
The only easy solution I could currently image would be to write the output into a stream compare size and if greater than the original just return the original file. If this sounds good to you, do not hesitate to propose a PR


add beforeRequire event

There is already a require event which fires after a successful require (I think?), but I'd like to also have a beforeRequire event, which would include the external module name. This could be used for timing the load of the external module.

Seems good to me! You'll want to emit here:
https://github.com/tkellen/js-liftoff/blob/master/index.js#L27
If you include tests and documentation on the first pass we can probably get a release cut right away.

I've sended a pr #92 for this issue.
Now I think it is enough to emit beforeRequire event only for a module specified with opts.require by an app user. (So I'll close https://github.com/js-cli/js-rechoir/pull/36.)


Monarch grammar: Regex starting with ^ should only match start of source line, but it does not.

monaco-editor version: 0.19.3
Browser: Chrome 79
OS: macOS
Playground code that reproduces the issue:
According to the Monarch docs:

If it starts with a ^ character, the expression only matches at the start of a source line.

I have tried both specifying a regex literal /^!/ as well as a string "^!", but neither works.
You can reproduce the issue on the special Monarch playground at https://microsoft.github.io/monaco-editor/monarch.html. In the Language syntax definition, specify:
return {
  // The main tokenizer for our languages
  tokenizer: {
    root: [
      [/^\!/, {token: 'delimiter.curly', next: 'jsonInBang', nextEmbedded: 'json'}],
    ],
    jsonInBang: [
      [/^\!/, {token: 'delimiter.curly', next: '@pop', nextEmbedded: '@pop'}],
    ],
  },
};

And then in the Language editor, specify:
!
  {
    "foo": "bar",
    "baz": 42,
    "quux": [
      {
        "foo": "bar!",
      }
    ],
    "quux2": [
      {
        "foo": "bar",
      }
    ]
  }
!

If you look carefully, the JSON inside the ! starts out being highlighted correctly, but after the ! in the string literal "bar!", it stops working. It appears the /^\!/ has matched it even though it is not the start of a source code line, which is not what the docs claim should happen.

Stepping through the code, I believe the issue is that MonarchTokenizer._myTokenize() has proper checks for ^:
https://github.com/Microsoft/vscode/blob/0aed1023c556dfcd9fc211855f14b5a183b8a3e0/src/vs/editor/standalone/common/monarch/monarchLexer.ts#L614-L625
In particular, it does this check:
if (pos === 0 || !rule.matchOnlyAtLineStart) {

By comparison, when in an embedded grammar, I believe MonarchTokenizer._findLeavingNestedModeOffset() is used to test the rules to determine whether to exit the embedded mode. As best I can tell, it not appear to check if matchOnlyAtLineStart is set on each rule.

Ah, so the issue is a bit more subtle than I realized. In monarchCompile.ts, as part of Rule.setRegex(), the regular expression is rewritten:
https://github.com/Microsoft/vscode/blob/0aed1023c556dfcd9fc211855f14b5a183b8a3e0/src/vs/editor/standalone/common/monarch/monarchCompile.ts#L372
wrapping it in ^(?:<original_regex>), dropping the ^, if necessary (and setting matchOnlyAtLineStart to reflect that change).
As such, this check in _findLeavingNestedModeOffset() is expected to succeed:
https://github.com/Microsoft/vscode/blob/0aed1023c556dfcd9fc211855f14b5a183b8a3e0/src/vs/editor/standalone/common/monarch/monarchLexer.ts#L499
since those characters should have been added by setRegex().
I suspect the fix might be as simple as changing this code:
https://github.com/Microsoft/vscode/blob/0aed1023c556dfcd9fc211855f14b5a183b8a3e0/src/vs/editor/standalone/common/monarch/monarchLexer.ts#L503-L506
To be something like:
if (result === -1 || (result !== 0 && rule.matchOnlyAtLineStart)) {
    continue;
}

Though it would probably be slightly more efficient to rewrite the regex to include a leading ^ before passing it to line.search() so that it can fail faster, if appropriate.
Also, I think the RegExp is re-created each time _findLeavingNestedModeOffset() is run, so it might benefit from caching it on the rule or in a WeakMap or something?

I'm trying to fix this myself and I have been following the instructions on CONTRIBUTING.md, but it is proving difficult. What I really want is a dev version of https://microsoft.github.io/monaco-editor/monarch.html that I can edit/refresh quickly.
I followed the instructions for npm run release and npm run build-website, but it takes 3 minutes to build on my laptop, so that is a slow dev cycle. Even once it is done, it does not seem to be loading my dev version, but what was downloaded into node_modules/, even if I add ?editor=src, so that's no good.
I poked around the various .html files in test/, but none of them seem to offer a similar level of interactivity as the playground.
It would be helpful if the docs provided more detail about how the maintainers get a good dev cycle going.

@bolinfest The trick is to use yarn run watch in the vscode repo. That will be a process that will continue executing until killed. Then, you can edit .ts files and within <1s the generated .js are written to disk and then you can reload the webpage.

@alexdima I had that working for the establish test pages, but it did not seem to be working for the playground (which I cared about because I didn't see a good test page for grammars, so I wanted to use monarch.html). Should the fast edit/refresh cycle be working for the playground, too?

For testing changes like that, I typically use one of the generated files like at http://<IP_ADDRESS>:8080/monaco-editor/test/playground.generated/extending-language-services-custom-languages.html
and just edit the .html to contain the Monarch definition I want and the content I want and then just reload...


[WIP] ES6 support

Going to support ES6

[x] switch internal parser
[x] implement
[x] refactor
[x] use babel-core and babel-plugin-espower for testing

Coverage remained the same at 98.78% when pulling d924fd218301489a41eade5c59b7f8af90398945 on es6 into dbf6c11d772eee0d9636f09b43c8a7aa6cc74fbb on master.

Coverage remained the same at 98.78% when pulling d924fd218301489a41eade5c59b7f8af90398945 on es6 into dbf6c11d772eee0d9636f09b43c8a7aa6cc74fbb on master.

Coverage remained the same at 98.78% when pulling 369683ef811dbe933e192cb24b4ffff105c25008 on es6 into dbf6c11d772eee0d9636f09b43c8a7aa6cc74fbb on master.

Coverage remained the same at 98.78% when pulling 369683ef811dbe933e192cb24b4ffff105c25008 on es6 into dbf6c11d772eee0d9636f09b43c8a7aa6cc74fbb on master.


Include reference to Thymeleaf bug

In the current version of the example (since Migrate to Spring Boot 3.0.0), the following is included in build.gradle:
	//  Temporary explicit version to fix Thymeleaf bug
	implementation 'org.thymeleaf.extras:thymeleaf-extras-springsecurity6:3.1.1.RELEASE'

It would be useful with a reference to what that bug is, so one can know whether it is relevant for a particular use case and to be able to follow it.

@rwinch Can you identify the exact issue in Thymeleaf's issue tracker? It would make sense to let people know which issue it is, and maybe we can remove that comment if it has been fixed. Thanks.

I could not find the reference to the Thymeleaf bug, but I did run the guide locally and can confirm that the additional dependency is still needed. As such, I merged PR #76 and will allow dependabot to continue to manage the version of the temporary dependency for now.


JSON serialization of topology template should render attributes as JSON; not as nested XML

If properties are key/value, the JSON should contain key/value pairs, too
As is:
                "any": "<?xml version=\"1.0\" encoding=\"UTF-16\"?>\n<wfn:BaobabProperties xmlns=\"http://winery.opentosca.org/test/nodetypes/fruits\" xmlns:selfservice=\"http://www.eclipse.org/winery/model/selfservice\" xmlns:tosca=\"http://docs.oasis-open.org/tosca/ns/2011/12\" xmlns:ty=\"http://winery.opentosca.org/test/nodetypes/fruits\" xmlns:wfn=\"http://winery.opentosca.org/test/nodetypes/fruits\" xmlns:winery=\"http://www.opentosca.org/winery/extensions/tosca/2013/02/12\"><ty:Antioxidants/><ty:VitaminC/><ty:Potassium/><ty:Superfood/><ty:HarvestedAt/>\n\t\t\t</wfn:BaobabProperties>"

Should be:
{
  "Antioxidants": "",
  "VitaminC": "",
  "Potassium": "",
  "Superfood": "",
  "HarvestedAt": ""
}

Fixed.


Can this library compress images?

As well as resizing images, is there a way to reduce the quality or change the quality setting that is used when resizing? (i.e. if it is a JPEG)
I am looking for a way to shrink the photos taken with the camera before sending to my API. I've seen several libraries that shrink photos and some that compress them, but so far haven't seen any that do both,
This library looks very full featured, but I couldn't see how to do this. Or maybe I'm missing the point here and compression is not really needed?
Cheers,
Rob

IBitmapImage.Save does this, it will save as either PNG or JPEG and does let you set compression levels on JPEG


Invariant Violation: requireNativeComponent: "RNMaterialLetterIcon" was not found in the UIManager.

react-native init TestDrawer
npm i react-native-navigation-drawer-layout
i copied the content found in  package documentation to my App.js
package.json looks like this
{
...
  "dependencies": {
    "react": "16.6.1",
    "react-native": "0.57.7",
    "react-native-navigation-drawer-layout": "0.0.3"
  },
  "devDependencies": {
    "babel-jest": "23.6.0",
    "jest": "23.6.0",
    "metro-react-native-babel-preset": "0.49.2",
    "react-test-renderer": "16.6.1"
  },
...
}

I ran
npm react-native run-android
I got this error

Invariant Violation: Invariant Violation: requireNativeComponent: "RNMaterialLetterIcon" was not found in the UIManager.

@gaetanozappi This fix, worked like charm. Lots of download (gradle & react-native-material-letter-icon ) happened at the background!
I appreciate all the effort you put into this. Thanks!

how to fix ???

@bestkung1  : What the problem, could you be specific?


Added short description of wesbite and center align word of day

The current website design lacks a short and engaging description for SEO and user engagement. Additionally, the 'Word of the Day' section is not centered, affecting the overall layout and aesthetic of the page.
Pull Request Checklist

[ ] I have added screenshots and videos to show before and after the working of my code.
[ ] I have ensured that the screen size is set to 100% while making the video.
[ ] I have synced the latest fork with my local repository and resolved any conflicts.
[ ] I have mentioned the issue number which I created before making this PR .(format to mention issue number is : fixes #(issue number) )
[ ] I understand that if any the above conditions are not met , my PR will not be MERGED .

Kindly follow pr checklist

remove this

Kindly follow pr checklist

What am i MIssing? can you elaborate

@ANSHIKA-26  made the necessary changes as you described. Pls merge now

issue number

why is the navbar twice ?

and why is word of the day out of its box and why is the word of day box empty ?

what exactly did you do ?


xonsh: fix wrapper, 0.17.0 -> 0.18.2

Description of changes
Avoid double wrapping, and make the top-level xonsh package the wrapper itself again.
Fixes https://github.com/NixOS/nixpkgs/issues/248978
Fixes https://github.com/NixOS/nixpkgs/issues/326339
Note: The fix actually makes the xonsh executables in the unwrapped variants unusable, so python3Packages.xonsh should only be used as a module afterwards. To use another Python version (e.g. avoid the f-string regression https://github.com/xonsh/xonsh/issues/5166), override the python3 used by top-level xonsh, like pkgs.xonsh.override { python3 = pkgs.python311; }.

Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[X] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/4355

I'm going to update xonsh to 0.18.2 in this PR, because it is not merged for too long, and I don't want to open a separate PR for update and rebase this one. Don't merge before it is done.

So I have a question about the new wrapper: how do you make a dev shell that has a custom Python environment that also works when you run xonsh inside the dev shell, and the dev shell lets you import xonsh?

So I have a question about the new wrapper: how do you make a dev shell that has a custom Python environment that also works when you run xonsh inside the dev shell, and the dev shell lets you import xonsh?

Good question. I didn't think of this use case, but adding the unwrapped xonsh to a python env actually works, because creating a python env effectively wraps it.
{ pkgs ? import <nixpkgs> {} }:

let
  pythonEnv = pkgs.python3.withPackages (ps: with ps; [
    requests
    xonsh
  ]);
in

pkgs.mkShell {
  packages = [ pythonEnv ];
}

This is exactly how the wrapper works, except the wrapper is a proper shell package and only exposes xonsh itself.


Smartthings battery levels reporting incorrectly

Samsung devices shares it's battery range with centralite. Since this change, my devices are reporting low levels, with a bunch now reporting 0% battery, and they are still working.
https://github.com/dmulcahey/zha-device-handlers/commit/6cba0ff725db1e5d66b577ddfb283d2f7fd73313
Do the Samsung devices need their own battery logic to have them report correctly?

I’m not surprised. I’m not sold on the new ranges myself... can you monitor them so we can track the min side voltage where they stop working? That’s what I’m doing myself.

I think for devices that we know are using CR2 or CR123 battery we could use a lower voltage threshold.

The max voltage is also incorrect, I replaced batteries in a few devices recently, and now they are reporting 30%.
I just checked and these devices are reporting 24 volts, which would have reported 90% on the old scale which seems correct.
For min voltage, I just replaced most of my devices as they had reached 1%. They were still working at that level (16 volts).
So basically I have seen devices working in the 16 - 26 volts range which seems to align well with the original range.

What kind of batteries? 100 is usually 3.0v for Lithium batteries at a minimum. Most start between 3.4 and 3.2ish. 2.4v seems really low for a new battery.

They are CR2032 so yes they are 3V. Maybe the reported voltage is not actual. I'll pull one down and measure it when I get a chance.

I have plenty of those in use and they generally start at 3.2 when new... I have 8 of the sylvania dimmers that use these

Referring to the smartthings community repo for this device, it uses the old scale:
https://github.com/SmartThingsCommunity/SmartThingsPublic/blob/master/devicetypes/smartthings/smartsense-multi-sensor.src/smartsense-multi-sensor.groovy

Multi, motion & moisture all use the old logic.

I just noticed my smartthings tag v4 are not showing any battery, when pulling the values, they are in fact < 21. IF the new values added in 6cba0ff725db1e5d66b577ddfb283d2f7fd73313 are in fact correct for some devices, maybe we need to split out the values to retain the old logic where applicable.

@ryanwinter check out #208, it should resolve your issues.


Binary committed to the repo?

Hi @simar7 any reason why the trivy-db binary is part of the repo - https://github.com/aquasecurity/trivy-db/blob/master/cmd/trivy-db/trivy-db? I have a PR to remove it, please feel free to close it, if it's irrelevant. Thanks!

Hi @simar7 any reason why the trivy-db binary is part of the repo - https://github.com/aquasecurity/trivy-db/blob/master/cmd/trivy-db/trivy-db? I have a PR to remove it, please feel free to close it, if it's irrelevant. Thanks!

thanks for the PR! - good catch.


fix(deps): migrate to @gitbeaker/rest

Closes #131
Summary

Remove the usage of @gitbeaker/node and use @gitbeaker/rest instead.

https://github.com/un-ts/changesets-gitlab/blob/a30d2babda63e0bd49ef3123671cc7c062ab663d/.codesandbox/ci.json#L2
https://github.com/un-ts/changesets-gitlab/blob/a30d2babda63e0bd49ef3123671cc7c062ab663d/.github/workflows/ci.yml#L13-L15
@alan910127 Please help to change these node versions at the same time.
For codesandbox, we can use 18, for GitHub Actions, we should use 18 and 20

https://github.com/un-ts/changesets-gitlab/blob/a30d2babda63e0bd49ef3123671cc7c062ab663d/.codesandbox/ci.json#L2
https://github.com/un-ts/changesets-gitlab/blob/a30d2babda63e0bd49ef3123671cc7c062ab663d/.github/workflows/ci.yml#L13-L15
@alan910127 Please help to change these node versions at the same time.
For codesandbox, we can use 18, for GitHub Actions, we should use 18 and 20

How about the release action in .github/workflows/release.yml? Should I also bump it to node 18?

How about the release action in .github/workflows/release.yml? Should I also bump it to node 18?

We can change to use lts/*


Any plan for Windows UWP support in the future?

I'm sorry if it's not the place for asking, I couldn't find anything about it anywhere.

Currently our project is focused on Android and iOS deployment targets.
https://flutter.io/faq/#what-devices-and-os-versions-does-flutter-run-on
It's certainly possible to port Flutter's runtime to UWP: https://github.com/flutter/engine/wiki/Porting-Flutter's-Engine
however we've not had very many requests for that.  Someone could certainly fork flutter/engine and do so themselves if they desired.

React Native provides this option. Best to stick with that platform until a definitive development path and platform is available.

I'd immigrate using Flutter when it supports UWP/Windows, and WASM.

#30726

There is a new update about flutter UWP: https://github.com/flutter/flutter/wiki/Desktop-shells

@eseidelGoogle Can you re-open this issue?

I believe https://github.com/flutter/flutter/issues/14967 is currently tracking.

Yes they should...its almost 2 years now :(


added parameters for input and output files encoding charset

Looks good, merged

Released v2,0,8 , should appear in maven central in a few hours


No FastPath for new Array(constant)

Today we don't generate fast path for below case.
var x = new Array(5); // argument should be constant between 0 and 8 inclusive.

That is because in lowerer , we fetch the wrong source of instruction. I tried fixing it by extracting the right argument and based on that emit fast path. For below test case I saw 10% win.
var start = new Date().getTime();
function test() {
  var arr = [];
  for (var j = 0; j < 100; j++) {
    arr.push(new Array(5));
  }
  return arr;
}

for (var i = 0; i < 1000000; i++) {
  test();
}
var end = new Date().getTime();
var time = end - start;
print(time);

However, I later realized that Array ctor can take multiple parameters that are array elements and we need to emit code to initialize those elements in fast path. With other work items on my plate, I will let JIT team fix it.
I was also curious why we decided to emit fast path only for array length up to 8 and not beyond.

FYI - @LouisLaf , @curtisman

On the second thought, I was wondering if we can also emit array creation fast path for below scenario
new Array(variable); // 0 <= variable <= 8;

We can have bound checks on argument passed to Array ctor and call helper if argument is beyond specific range. In acme-air benchmark, below are the js functions that call Array ctor specifying size through variable instead of constant.

I traced the variable value passed to the Array ctor and found out all of them were less than 8. Optimizing this case should give us approx. 8% win.

index.js!proto.handle = 3
_stream_writable.js!onwrite = 8
_stream_writable.js!clearBuffer = 2
net.js!Socket.prototype._writeGeneric = 8
_stream_readable.js!Readable.prototype.read - less than 5 (through inlining nextTick)
_stream_readable.js!readableAddChunk - less than 5 (through inlining nextTick)
internal/process/next_tick.js!nextTick less than 5

@kunalspathak , nice find that we are fetching the wrong argument! Getting src2 of the new array instruction and using it as length should work fine as long as you detect that it is the only argument passed to the constructor and call the helper if its not. Or, we can also walk the argument chain and count the number of arguments and emit the fastpath if the number is <= 8 (I don't know the reasoning behind '8').


gRPC finally tagless

I know your knowledge of macros is very limited and I don't expect you to review the implementation - that should be covered with tests. However you can review he functionality from high level - API etc, e.g. the note about required Scheduler is quite valid (even though I doubt it can be solved).

@petr-k @jakubjanecek ping guys :-)

Sorry, I don't know gRPC and I don't know macros too much so there's not much I can review. I guess it's ok :)


How to set conditional marker colors in line charts?

I'm learning the Power BI sample report - Regional Sales Sample. In the Win/Loss Ratio Overview page, there is a line chart "Closing Percentage by Month". In this line chart, the markers have different colors based on the Close%. When clicking somewhere else to narrow the dataset, the marker's color also changes accordingly.
Can you give me some guidance on how to set conditional marker colors? Thank you!

It's poor implementation from Microsoft, but the trick here is to first change that visual to a 'Clustered column chart'. Then, you can set the 'Color' of the 'Columns' (in the Visual settings) via the 'fx' icon. In there, you can specify a gradient, color by rules, or color by a field value. Once you have your colors set as desired, change the visual back to a 'Line chart'.
Here's an old (~5 years ago) YouTube video that shows off the idea: https://www.youtube.com/watch?v=A4iG8S4EpHs
Why it requires that clunky work-around (and why that work-around should even work in the first place) and is not a thing that is possible directly through the 'Line chart' settings is one of many Microsoft/Power BI decisions that is beyond me.


Enabling Customizable Rollups the first time does not fully enable the feature

Critical Changes
Changes
Issues Closed
Fixes #4346
New Metadata
Deleted Metadata

**lurch: attach W-034034

Tracking W-034034

**lurch: attach W-033047

Tracking W-033047

@rponti-sforg , I've just updated PR to track W-033047 and set issue #4231  as fixed in addition to the Customizable Rollup enable issue. Can you please test Rollup create and update as well based on the #4231 ?

**lurch: dettach W-033047

**lurch: detach W-033047

Detached W-034034

QE testing is complete.  Tests have passed.
For further testing details, see: https://foundation.lightning.force.com/lightning/r/agf__ADM_Work__c/a2x1E000001C6maQAC/view
Merging PR and deleting branch.


Do not accept this pull request

I'm issuing this pull request so that I can see what needs to be done in order to get StickyE integrated with HARK.

Closing this PR, per phone conversation with ESC.  Taking a different tack by merging StickyE from his fork into a new branch on the econ-ark fork, then fiddling with things.


Update port_palermo_test.rb

Why make this a barrier to entry for ALL changes? This is a totally obvious change, which should be accepted w/o issue. I'm not going to open a discussion for a small change like this.

And I am not going to make you open a discussion for this.  I would not call this a "small change" though, pretty big mistake, really.
Thank you for finding it and making the change!


[117] Allow JWK parameters of type [String]

Resolves #117.
Implemented this today throughout the day. Submitting the pull request now, so I can continue implementing feedback tomorrow at work.

Allows encoding and decoding of [String] JWK parameters in addition to String parameters.

Tell me what you think!

⚠ This contains two API changes in JWS.swift (major release needed):
subscript(parameter: String) -> String?
// becomes
subscript(parameter: String) -> Any?

let parameters: [String: String]
// becomes
let parameters: [String: JWKParameterType]

Oh! also might want to add a changelog entry, since we have one now.

🆒 Thanks for the review @nathan-mohemian! I'll definitely address the feedback, you're 100% right!

A week later I finally managed to address your feedback @nathan-mohemian! 😅

@daniel-mohemian what's the status of this PR?

@daniel-mohemian what's the status of this PR?

I need to find time to revisit it and check into which major release we put it. I'll close the PR for now as it obviously is stale. Thanks for reminding me about it!


Splitting the BaseMappable protocol to two "from JSON" and "to JSON" protocols

Similar to Codable that uses Encodable and Decodable, it would be really useful to have the protocol split so that you can now create models that are to be used ONLY for data coming FROM JSON (ie that have the init(map: Map) throws initializer) and models that are used for serializing TO JSON (i.e. that have the mapping(map: Map) method).
This way there is compiler support for models that are supposed to be used for either requests or models that are used only for responses but never both.
In my code I end up with models that throw runtime exceptions when I know I need to only support one way mapping but this is dangerous.
In addition, Transforms, Mappable and ImmutableMappable should be split up in this manner.
Personally, I care very little for Mappable. I feel every model should use ImmutableMappable.
If this is not possible, I'll probably end up making my own mapping logic or go back to using Codable

This type of change would require a significant rewrite of parts of the project. I do agree that it is a nice way to approach your data modelling.
If this is something you need I would recommend using Codable.


Enhanced printing of elements with opinions

Allow configuration to print AST elements with opinions or without them.

[ ] Unit test all changes
[ ] Update README.md if applicable
[ ] Add [WIP] to the pull request title if it's work in progress
[ ] Squash commits that aren't meaningful changes
[ ] Run sbt scalariformFormat test:scalariformFormat to make sure that the source files are formatted

@getquill/maintainers

That's a good one! Do you think it is worth a note in CONTRIBUTING.md?

Yeah probably. I need to put together a couple of things for CONTRIBUTING.md. Also, I was thinking of doing a video chat with any Quill maintainers and anyone else who's interested about how to work with Quill ASTs to fix bugs and implement new features. WDYT?


Fix visudo check

In some cases when /usr/sbin/visudo isn't on the users PATH validation checks will fail when installing sudoers templates. Passing the full path to visudo for template validation is more reliable. This also more closely replicates the examples given in the official ansible docs: https://docs.ansible.com/ansible/latest/collections/ansible/builtin/template_module.html.

Thank you for the pull request. I will merge it and create a new version, and I will also add the changes to the "arillso.system" collection, which is updated more frequently.
Here is the link to the corresponding GitHub directory:
https://github.com/arillso/ansible.system/tree/main/roles/sudoers


BSOD When Running Compiled Program in Bash

I'm attempting to compile and run NFD (https://github.com/named-data/NFD) on Bash on Windows. The compilation is successful, as is running some of compiled executables. However, when running a particular executable (build/unit-tests-daemon from the source root directory), my computer BSODs with a SYSTEM_THREAD_EXCEPTION_NOT_HANDLED error.
Windows Version: 10.0.14393
Steps to Reproduce
Start with a fresh install of Windows Subsystem for Linux.
$ sudo apt-get update
$ sudo apt-get upgade
$ sudo apt-get install git build-essential libcrypto++-dev libsqlite3-dev libboost-all-dev libssl-dev libpcap-dev pkg-config
/// ndn-cxx is a dependency for NFD that we need to compile
$ git clone https://github.com/named-data/ndn-cxx
$ cd ndn-cxx
$ ./waf configure --with-tests
$ ./waf
$ sudo ./waf install
$ sudo ldconfig
$ cd ..
$ git clone https://github.com/named-data/NFD
$ cd NFD
$ git submodule init && git submodule update
$ ./waf configure --with-tests
$ ./waf
$ sudo ./waf install
/// run the program that causes the BSOD
$ build/unit-tests-daemon
Expected Behavior
No BSODs
strace
Strangely, running the command through strace does not cause a BSOD.
strace -ff -o ../strace-out/unit-tests-daemon build/unit-tests-daemon

Thank you very much for reporting this!  I'll take a look this morning and see where the bugcheck is coming from.

@eric135 - I was able to reproduce the BSOD locally. Thanks again for reporting this and for the detailed repro steps (very helpful)!

Thanks for tracking this down @sunilmut, you beat me to it.

Thanks @benhillis. The fix has been checked in our dev branch and should make it to the release branch soon.

Tested with 14915 and did not experience a BOSD.  I did not confirm all the tests ran successfully.