Strikeout CompletionItems (and Symbols?) that are deprecated

Ctrl+Space is nice and all but when you are new to a library you just see a list of functions and you won't realize that some of them are deprecated. Would it be possible to add a strikeout line via the line-through text-decoration or some kind of icon overlay to indicate that something is deprecated?

@jrieken I'm interested in this too, for deprecated html/css properties.

it'd also be great to strikeout deprecated props/methods in the editor itself like webstorm does it. ie

Raised a couple times previously:

https://github.com/Microsoft/vscode/issues/31159
https://github.com/Microsoft/vscode/issues/10316 - recommends using extension with textDecoration API https://github.com/Microsoft/vscode/issues/10316#issuecomment-238474701

@jcrben Those are issues for language support. This issue is more general, and I think this is an issue to support the deprecated property on the completion and symbol items in the LSP spec with a visual change.
When this is done, I would expect more language support would follow. It's possible that some language servers already do set that property but you don't know since VS Code ignores it.
Specifically on those issues, I don't agree with the notion that it should be done in a separate extension or that it should use the decorations API. Deprecation is a standard practice for languages, and JavaScript/TypeScript have JSDoc to determine this, which is already being parsed and used for other tags.

I'd like something similar to this. I'd like to be able to prevent deprecated things from showing up in the list of suggestions at all.

@kamranayub work on this is sitting here: https://github.com/microsoft/vscode/tree/joh/completionsDeprecated.

I'm currently seeing lots of deprecated items in JavaScript suggestion lists.  A string variable for example offers the following methods.  The first four on the list are deprecated.  Would be nice to get them out of the way.

adding @octref since his CSS language brain has deprecation-information

CSS now looks like this. I don't know if this is possible, but a strikeout overlay on top of the completion item's icon would be much easier to see for me.

Slightly improved version which

shows the line through
doesn't show match highlights (no bold)
renders the item slightly opaque

The analog thing for symbols in outline and breadcrumb pickers, not in breadcrumb itself tho. I believe that would be too noisy, esp since the editor (e.g the thing under cursor) will already be annotated as deprecated.

Testing on vscode-java with initial deprecated support in jdt.ls, in Insiders build ada79d72be36ecbfed6f88bb16edcc5cc3f5c2a8 :

I'll keep testing with newer builds next week.
cc @akaroml

What a time to be alive...

Closing. We have the UX for outline, workspace symbols, and completions. The API is proposed and will be finalised in https://github.com/microsoft/vscode/issues/23927

@jrieken I tested today's insiders build (185308c0dd317d73fe4c19dea347582dee9650de 2019-08-26T09:43:06.818Z)  and I no longer see the completion/symboles striked through O_o. Is there something I need to enable in my extension now?

What version of the proposed API did you code this against?

latest LSP release. Which adds the deprecated property to completion items, workspace and document symbols.  completion items worked last week, as per my screenshot.
I tried to add vscode.proposed.d.ts by calling npx vscode-dts dev. But I'm not sure where the file is supposed to go. In my project root? my project source folder? Either way I don't get the strikethroughs.

enableProposedApi is set to true too. Wasn't necessary last week.

latest LSP release.

I don't think that's weird up (@dbaeumer) yet. It might have worked by accident because the first proposal used the same names. The proposed API (CompletionItem.tags, SymbolInformation#tags) is described here: https://github.com/microsoft/vscode/issues/23927

do you plan to get VS Code support the deprecated properties of the current LSP version?
On the Java side, those new tags are not yet supported by the LSP4J bindings, so it'll take us more time to have that deprecated support that way.

LSP and vscode.d.ts are two separate things. The LSP-vscode-client fulfils the vscode.d.ts-contract, e.g it will map the deprecated-field that LSP defines onto the completion item tag that vscode.d.ts defines. The sequence is that we finalise the API next milestone, that LSP adopts the new API, and that things then come together.
Since you are on the LSP side and since to my knowledge deprecation is already supported there (but not yet wired up), there is nothing you have to do

ok, can you please let me know when this is wired up in vscode then?

Hi Fred,
can you please remove me from your “subscribed”-list?
Thanks.
Best,
Daniel
Daniel Hofinger
Founder & Managing Director, Hofinger Ventures UG
A Mörfelder Landstraße 6-8, 60598 Frankfurt am Main
M +49<PHONE_NUMBER>
E<EMAIL_ADDRESS>W www.hofinger.xyz
Hofinger Ventures UG (haftungsbeschränkt), Luisenstraße 34, 60316 Frankfurt am Main; Geschäftsführer: Daniel Hofinger; Amtsgericht Frankfurt am Main; HRB 108730; USt.-IdNr.: DE312772958; Diese E-Mail enthält vertrauliche und/oder rechtlich geschützte Informationen. Wenn Sie nicht der richtige Adressat sind oder diese E-Mail irrtümlich erhalten haben, informieren Sie bitte sofort den Absender und vernichten Sie diese Mail.  The information contained in this message is confidential or protected by law. If you are not the intended recipient (or have received this e-mail in error), please notify the sender and delete this message. Any unauthorized publishing or copying of this message or unauthorized distribution of the information contained in this e-mail is strictly prohibited.
On 26. Aug 2019, 17:41 +0200, Fred Bricon<EMAIL_ADDRESS>wrote:

ok, can you please let me know when this is wired up in vscode then?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

I didn't add you. But you can unsubscribe from notifications from this issue by clicking on the "Unsubscribe" button here.

I didn't add you. But you can unsubscribe from notifications from this issue by clicking on the "Unsubscribe" button here.

Hey Fred, I think the enableProposedApi is no longer needed because the changes are already in the latest release of the vscode-languageclient v5.3.0-next.9. Could you try to upgrade the client to see whether it works? Thanks.

@jrieken is correct. It is not wired up yet. I only wire up new API if it is at least released in a stable build. I don't make a dependency on Insider in LSP libs (I once did and it confused a lot of users).
However you can implement this yourself using a custom middleware if you really need to do so.

Hi Dirk,
please remove me from CC, thanks.
Best,
Daniel
Daniel Hofinger
Founder & Managing Director, Hofinger Ventures UG
A Mörfelder Landstraße 6-8, 60598 Frankfurt am Main
M +49<PHONE_NUMBER>
E<EMAIL_ADDRESS>W www.hofinger.xyz
Hofinger Ventures UG (haftungsbeschränkt), Luisenstraße 34, 60316 Frankfurt am Main; Geschäftsführer: Daniel Hofinger; Amtsgericht Frankfurt am Main; HRB 108730; USt.-IdNr.: DE312772958; Diese E-Mail enthält vertrauliche und/oder rechtlich geschützte Informationen. Wenn Sie nicht der richtige Adressat sind oder diese E-Mail irrtümlich erhalten haben, informieren Sie bitte sofort den Absender und vernichten Sie diese Mail.  The information contained in this message is confidential or protected by law. If you are not the intended recipient (or have received this e-mail in error), please notify the sender and delete this message. Any unauthorized publishing or copying of this message or unauthorized distribution of the information contained in this e-mail is strictly prohibited.
On 27. Aug 2019, 09:09 +0200, Dirk Bäumer<EMAIL_ADDRESS>wrote:

@jrieken is correct. It is not wired up yet. I only wire up new API if it is at least released in a stable build. I don't make a dependency on Insider in LSP libs (I once did and it confused a lot of users).
However you can implement this yourself using a custom middleware if you really need to do so.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

@danielhofinger you need to unsubscribe yourself from the issue using the GitHub UI.

Alright, thanks! @dbaeumer

@jrieken is correct. It is not wired up yet. I only wire up new API if it is at least released in a stable build. I don't make a dependency on Insider in LSP libs (I once did and it confused a lot of users).
However you can implement this yourself using a custom middleware if you really need to do so.

I don't think I'm gonna start messing with custom middleware code (don't even know what to do). So I'll just wait for you to wire things up in the insiders build at least

https://github.com/microsoft/vscode/issues/77239 was marked as a duplicate of this issue and closed.
@jrieken said:

I'd say this is a dupe of #50972 and it would be us adding some API flag and then allows users to configure how the suggest UX is handling that flag

Does the closure of this issue address #77239? Should https://github.com/microsoft/vscode/issues/77239 be reopened?


Simplify CNI plugin/bridge usage for unprivileged users

user-mode networking is now supported within a user namespace. To allow containers to communicate with each other currently nested containers need to be created though. This provides a bad usability in most use-cases.
Instead users should also be able to setup all containers from within the host namespace and bridge them in a shared namespace with a single ctnr command.
Option 1: Move container execution into another, implicit, shared container
a) An implicit shared container with an own file system (from a stage image containing plugin binaries as in rkt) is maintained to run nested containers.
Problem1: If the shared container does not inherit the host's file system external files cannot be resolved.
It is also not possible to mount them into the outer container since this would require a container update which would break other containers that have already been started there.
Problem2: the container is not visible on the host anymore - only the outer container. But at least this way terminating the outer container also terminates the children (although they may leak kernel resources when not properly terminated/unmounted).
b) Alternatively the outer container could inherit the host's file system only having minimal isolation (userns, netns, mountns) to avoid breaking external file references and keep containers visible on the host.
Problem1: plugin binaries cannot be provided.
=> In the outer container the stage image's file contents could be mounted over the rootfs providing all required plugin binaries.
Problem2: Child containers on the host cannot be associated with the parent. On container termination on the host the bridge plugin would not be able to cleanup the veth when it is not run within the outer container's netns anymore which cannot be enforced using plain runc.
=> The child containers could be mapped to the outer container by writing their state into a separate directory and a naming convention. Thus the user should be made aware of the container hierarchy and deal with it explicitly which is probably not a bad idea and can be simplified in high-level tooling/compose. In order to make containers communicate with each other she may create a parent container/pod first and add containers or nested pods to it.
c) Another alternative that would provide both the necessary bridge namespace and the OCI/CNI plugin binaries would be to mount the host's namespace into a sub directory of the container and rewrite file references accordingly. Unfortunately the sub directory prefix may still be shown to the user in error messages.
EDIT:
In general this option also supports to run multiple containers as pod. The outer/pod container would define the network and the child/app containers would remain in the outer container's network namespace.
This needs to be done for pods anyway. Once this is done communication between pods can be achieved using another outer container - same problem a layer higher then. Container hierarchies should become part of the ctnr design as 1b shows.
Option 2: Move OCI CNI network hook execution into other namespace
The OCI network hook would require the namespaces it should enter before CNI execution configured.
Thus it could ensure that network deletion/termination is initiated from within the same namespace.
The container would be visible and can easily be controlled on the host.
The functionality could also be used with plain runc/other OCI runtimes.
Also other CNI plugins could benefit from this approach: for instance the existing portmap plugin could be used as well.
On the other hand it may limit CNI plugin capabilities since it can only be applied to ALL plugins:
For instance a plugin is planned to forward/proxy ports from the host to the container's netns using socat or similar.
This plugin would require explicit configuration of the namespace to forward ports to in addition to the container's namespace.
This would be acceptable since the plugin could be used to connect any namespace this way.
Where/how to create/lookup the userns/netns from within the OCI hook?
Create/join namespace by name dynamically? When to remove?
=> Make OCI hook join existing namespace only (tooling on top of runc must create/provide and remove the namespace when not needed anymore)
=> Make ctnr create/gc a container representing the namespace dynamically
=> The stage container is still required to get the hook/plugin binaries. Back to option 1?
=> These two features should be separated because one is about file system dependencies and the other about network namespaces which users may want to combine independent from each other?!
Option 3: Extend bridge plugin to bridge custom userns/netns with container
The bridge plugin would get an additional parameter specifying the namespaces to bridge to instead of the current namespace.
Thus it could ensure that network deletion/termination is triggered from within the same namespace.
The container would be visible and can easily be controlled on the host.
A plugin to map ports using socat would not need additional configuration of the namespace to map ports to (except when it should work with a completely different namespace).
=> Problem: the netns configuration is dynamic. if it should be part of any static plugin configuration a dependency to the container engine (no!) or another mapping would need to be created
=> provide userns/netns or rather process PID in runtime config as in portmap plugin
=> Problem: it is unclear for ctnr when to create the custom netns since it doesn't interpret CNI network configurations - it would always need to create it to be sure or
=> require an additional parameter
Option 4: Create new CNI plugin that enters custom netns and executes nested plugins there
=> provides most flexibility
=> Problems: as in option 3
=> The plugin should also manage the slirped shared network namespace itself: The namespace should be a simple host-independent name so that it can be configured statically within a CNI JSON file. The plugin should map the provided name to a namespace persistently. The plugin should also keep track of the namespace's users and terminate the slirp4netns process and destroy the shared namespace as soon as no container is using it anymore. This would also allow usage in other contexts as for instance with plain runc without ctnr and decouples the network logic from the rest.
Problem: The plugin requires a lot of the container engine's functionality!
Result so far
Actually three features were mixed here (especially in option 1):

Support bridging multiple containers to a shared namespace.
Provide additional binaries to create a container using a stage image as in rkt.
Support pods

EDIT:
This issue is about bridging containers but the pod feature could also solve it. Currently I'd go with option 1b.
@AkihiroSuda please have a quick look over this. I may be missing sth in my considerations.

I realized option 1 would also allow usage of containers/storage


CloudFormation CREATE_FAILED herdServerWaitCondition

I have tried to launch the demo stack several times using different versions.
14:35:30 UTC-0400 | CREATE_FAILED | AWS::CloudFormation::Stack | herd-test001 | The   following resource(s) failed to create: [herdServerWaitCondition]. -- | -- | -- | -- | --
Looking at the EC2 Logs it seems to fail attempting to retrieve https://raw.githubusercontent.com/FINRAOS/herd/v0.48.0/herd-build/herd-scripts/herd-scripts-sql/src/main/resources/herd.postgres.0.1.0.create.sql where it encounters a 404 error.
Is this similar to issue #303?
Thanks for your help.

Here is a work-around
1. Download and unzip https://github.com/FINRAOS/herd/archive/master.zip
2. Upload ./herd-master/herd-build/herd-scripts/herd-scripts-sql/src/main/resources to a web-accessible S3 bucket
3. Modify 'herd.localdb.template'
Search raw.githubusercontent.com/FINRAOS/herd/v0.48.0/herd-build/herd-scripts/herd-scripts-sql/src/main/resources
Replace with your bucket name and prefix
4. Run cloud formation with modified template

I applied the work-around suggested in the above post. But still landing into the same issue. I am using version 0.49.0. Any solutions please?


Feed and speed not work

I can't use this feature. When i select DOC and WOC always stay in certain percentage... Nothing happend after long time.
[code]
OS: Windows 11 build 22631
Word size of FreeCAD: 64-bit
Version: <IP_ADDRESS>771 (Git)
Build type: Release
Branch: releases/FreeCAD-0-21
Hash: b9bfa5c5507506e4515816414cd27f4851d00489
Python 3.8.10, Qt 5.15.2, Coin 4.0.1, Vtk 8.2.0, OCC 7.6.3
Locale: French/Canada (fr_CA)
Installed mods:

btl 0.9.9
[/code]

I'm afraid your report does not include enough information to find out what may be going on. Could you post a screenshot of the tool parameters, and another of the machine settings, and one of the calculator?

Hi,
Sorry for not giving enough information. In fact, it is only in adatative mode that the calculator does not work. Here are the screenshots of the settings.

thank

Wow, looks like you had to dig pretty deep for this one, thank you! It's merged, so should work if you update.

@knipknap Thanks man! Yeah a lot of back and forth but then I realized it was the method :)


Trigonometric Functions

[ ] sin, arcsin
[ ] cos, arccos
[ ] tan, arctan
[ ] sec, arcsec
[ ] csc, arccsc
[ ] cot, arccot

working on sin and arcsin

working on cos

@Aditya-Dhodapkar @VaibhavPatel6 See #86. Once merged, use UnaryExpression as the base for your Sine, Cosine, and ArcSine nodes


Issue post Notifications chapter

After I complete the Notifcations chapter the Meteor webserver throws the
following error and and the app doesn't show any notifications in the dropdown.
(webapp_server.js:419) Error serving static file Error: Forbidden
It does allow to add comments without any issues.
Have tried the following without any success:

Tripple checked the code changes (against the book and github)
Restarted the server and reset the app

Any hints - seems to be a more generic issue and not (just) related to the code?
Thx
-Tom

Sorry, I haven't been able to reproduce this error. Closing it for now.


creating an ID for each unique item in a plot

This is more of a feature request. On smaller objects in say a scatter plot, there is no id to try and link to using jquery.
Example:
<g opacity="1" transform="translate(407.1688232421875,388.3738708496094),scale(1,1)" class="d3plus_rect" style="cursor: pointer;">
<rect class="d3plus_data" x="-24" y="-24" width="48" height="48" fill="#a5c697" opacity="0.9" vector-effect="non-scaling-stroke" style="stroke: rgb(133, 159, 121); stroke-width: 1;" shape-rendering="auto" transform="" ry="25" rx="25"></rect>
</g>

as you can see in the above there is no unique id to link to this item. I'm trying to make a table that displays the same information as the graph. So if you click on an element in the table it makes the item on the graph 'grow' or become more visible. However; if the item is a small one as in the above, there is no way to select that item and change the shape or traits of the DOM.
However, in bigger items that have a label attached to them, there is an id.
Example:
<g opacity="1" transform="translate(1285.162353515625,580.87841796875),scale(1,1)" class="d3plus_rect" style="cursor: pointer;">
<rect class="d3plus_data" x="-49" y="-49" width="98" height="98" fill="#B35C1E" opacity="0.9" vector-effect="non-scaling-stroke" style="stroke: rgb(144, 74, 24); stroke-width: 1;" shape-rendering="auto" transform="" ry="50" rx="50"></rect>
<text id="d3plus_label_Some_Generic_Quiz_rect" class="d3plus_label" opacity="1" font-weight="200" font-family="Helvetica" stroke="none" pointer-events="none" fill="#e9d7cb" text-anchor="middle" font-size="11px" x="-45.5" y="-45.5" style="font-size: 11px;" transform="rotate(0,0,0)scale(1)translate(0,0)rotate(0, 0, 0)translate(0,30.979999999999997)"><tspan x="0px" dy="12.100000000000001px" dominant-baseline="alphabetic" style="baseline-shift: 0%;">Execute Risk</tspan><tspan x="0px" dy="12.100000000000001px" dominant-baseline="alphabetic" style="baseline-shift: 0%;">Generic Quiz</tspan>
</text>
</g>
````
Is there any plans on making a unique id for the rect class? IE "d3plus_rect_Some_generic_quiz_rect". This will help me out greatly when I'm trying to locate the item using jquery from the datatable script I already have made.

Example:
````javascript
$(document).ready(function() {
    var table = $("#table").DataTable( {
                data: radarValues,
                columns: [
                    { data: "quiz", title: "Quiz Name" },
                    { data: "avg", title: "Average Score" },
                    { data: "taken", title: "How Many Times Taken" }
                ]
            } );
    //onclick function to find and make circles bigger.
     $("#table tbody").on("click", "tr", function() {
        //code to find element on form and enlarge it.
        var data = table.row( this ).data();

        if ($(this).css("background-color") != "rgb(255, 255, 0)") {
            $(this).css("background-color", "yellow");

            var str = data.quiz;
            //get ride of the & signs
            str = str.replace("&", "and")
            var eleToEnlarge = "#d3plus_label_" + str.replace(/\s/g, "_")  + "_rect";

            //var element = $(eleToEnlarge).
            var rect = $(eleToEnlarge).closest(".d3plus_data");
            console.log("eleToEnlarge", eleToEnlarge);
            console.log("rect", rect);
            //set the height
            var height = rect.attr("height");
            var width = rect.attr("width");
            rect.attr("height",height + 10);
            rect.attr("width",width + 10);
        }
        else {
            $(this).css("background-color", "white");
            var str = data.quiz;
            //get ride of the & signs
            str = str.replace("&", "and")
            var eleToEnlarge = "#d3plus_label_" + str.replace(/\s/g, "_")  + "_rect";
            var rect = $(eleToEnlarge).closest("rect");
            //var rect = element.closest(".d3plus_data");
            //set the height
            var height = rect.attr("height");
            var width = rect.attr("width");
            rect.attr("height", height - 10);
            rect.attr("width", width - 10);
        }
    } );//end of onclick function
} );//end of document ready
````

sorry for the formatting of the jQuery I copied it over from Eclipse and the tabs stayed.  I know, not really an excuse, but it's Friday.

Also here is the code for the call to d3plus. This is being generated by php, after the data is pulled from mongo and formatted to json.

````javascript
var radarValues = ['.$stringForJsonRadar.']
var visualization = d3plus.viz()
.container("'.$docID.'")
.data(radarValues)
.type("scatter")
.id("quiz")
.x("taken")
.y("avg")
.size("taken")
.descs({
    "taken":"How many times a test was taken",
    "avg": "The avg grade per attempt"
    })
.tooltip(["taken", "avg"])
.draw()
````

Instead of jumping around trying to assign a standard ID to all shape types, I just applied an unique ID to each data <g>. This fix will be part of the next release. :beers:

That was something I was thinking of after making the request, because it makes more sense. Thanks! Will help me out a load, with these graphs I'm making.


write collect classes type

PBXProjWriter was still writing in array.
Related: https://github.com/xcodeswift/xcproj/pull/94
Also renamed spec file for consistency.

Also renamed spec file for consistency.

By the way this Xcode Plugin is useful.
You can switch between Spec/Tests files and implementation file using Keyboard shortcut. e.g. Hoge.swift <=> HogeSpec.swift
https://github.com/takasek/XCJumpToTests

Cool! how do you install that Xcode plugin @toshi0383 ?

@pepibumur Like this!

I don't know why CI fails?

Thanks @toshi0383, I'll give it a try to the plugin. Regarding Travis, it seems that it comes now with swiftlint preinstalled. If you try to install a Homebrew formula, when it's already installed it fails. You have to update the .travis.yml script to use upgrade instead:
brew upgrade swiftlint

Oh I was looking at XcodeGen's .travis.yml.😅


Feature/savejoint an dreplay actions

This will close #16 #6

Render in actionReplay not working but it is able to save numpy array of video


DiffOpMove does not work in debug mode (only works in release mode)

While I was exploring the possibility of minimising the binary size of (my version of) the js-framework-benchmark for leptos framework, I ran into a problem where the "swap rows" button didn't work in debug mode. It turns out it only works in release mode. 😬
I have now found the issue which seems to be related to the function EachItem.get_opening_node which work differently in release and debug mode. In debug mode, the opening node is always a Comment type node. In release mode it's a normal Element type node. In debug mode, later when mount_child(MountKind::Before(&opening), &each_item); is called to insert the nodes at the right positions, it does not work because opening is a comment node. Changing the behavior of get_opening_node to work the same as release in mode fixes this problem.
Because I don't know the intent of having different implementations of get_opening_node, I decided not to open a pull request of my "fix". However, I still think this issue needs to be resolved, since a broken DiffOpMove implementation in debug builds are unacceptable.
This is the change I did to "fix" the issue:
leptos_dom/src/components.rs
impl Mountable for ComponentRepr {

    // ...

    fn get_opening_node(&self) -> web_sys::Node {
        // #[cfg(debug_assertions)]
        // return self._opening.node.clone();

        // #[cfg(not(debug_assertions))]
        return if let Some(child) = self.children.get(0) {
            child.get_opening_node()
        } else {
            self.closing.node.clone()
        };
    }

    // ...

}

leptos_dom/src/components/each.rs
impl Mountable for EachItem {

    // ...

    #[inline(always)]
    fn get_opening_node(&self) -> web_sys::Node {
        // #[cfg(debug_assertions)]
        // return self.opening.node.clone();

        // #[cfg(not(debug_assertions))]
        return self.child.get_opening_node();
    }

    // ...

}

Thanks. The <For/> component is toward the tail end of a significant rewrite by @jquesada2016 (see #533, #897), which will likely resolve this issue in any case.
In the meantime, if you have a solution please do open a PR so we can test it.


add a chmod command

add a chmod command to solved issue https://github.com/Dataman-Cloud/crane/issues/471

👍


Add base64 encoding support to file provider

Fixes #163.

@skokhanovskiy  add some unit-tests will be better.

@yxxhero I've added some tests for both GetString() and GetStringMap().


hackit.server doesn't exist.

It seems the game allows me to connect to any server no matter if it exists or not. hackit.server seems to be unimplemented. 🤒

That's a feature, not a bug! There only files in certain servers, though :)
And the game basically stops rn at hackit.server... I'll continue making servers/missions/storyline in the next few updates

Ah.


upgrade myst-parser dep to 1.0

This updates the myst-parser dependency to ~1.0
The changes are simple:
Update imports
Deprecate DOCUTILS_EXCLUDED_ARGS and implemented the omit: [docutils]
Black also did some formatting
I know very little about how this uses myst-parser all i know is that my jupyter-book compiles and uses latest features of myst parser using this. the doc generator seems broken on master , so i cant really tell if this is me or just broken on base rev, please advice !

I've tried this. It forced to downgrade sphinx from 6.1.0 to 5.3.0. why ?
and I got this error
# Sphinx version: 5.3.0
# Python version: 3.10.6 (CPython)
# Docutils version: 0.19
# Jinja2 version: 3.0.3
# Last messages:

# Loaded extensions:
Traceback (most recent call last):
  File "/home/tin/.virtualenvs/shiphero/lib/python3.10/site-packages/sphinx/cmd/build.py", line 276, in build_main
    app = Sphinx(args.sourcedir, args.confdir, args.outputdir,
  File "/home/tin/.virtualenvs/shiphero/lib/python3.10/site-packages/sphinx/application.py", line 223, in __init__
    self.setup_extension(extension)
  File "/home/tin/.virtualenvs/shiphero/lib/python3.10/site-packages/sphinx/application.py", line 398, in setup_extension
    self.registry.load_extension(self, extname)
  File "/home/tin/.virtualenvs/shiphero/lib/python3.10/site-packages/sphinx/registry.py", line 472, in load_extension
    metadata = setup(app)
  File "/home/tin/.virtualenvs/shiphero/lib/python3.10/site-packages/myst_nb/__init__.py", line 8, in setup
    from .sphinx_ext import sphinx_setup
  File "/home/tin/.virtualenvs/shiphero/lib/python3.10/site-packages/myst_nb/sphinx_ext.py", line 23, in <module>
    from myst_nb.sphinx_ import (
  File "/home/tin/.virtualenvs/shiphero/lib/python3.10/site-packages/myst_nb/sphinx_.py", line 16, in <module>
    from myst_parser.mdit_to_docutils.sphinx_ import SphinxRenderer, create_warning
ImportError: cannot import name 'create_warning' from 'myst_parser.mdit_to_docutils.sphinx_' (/home/tin/.virtualenvs/shiphero/lib/python3.10/site-packages/myst_parser/mdit_to_docutils/sphinx_.py)

hi, what did you did to get this error (how do i reproduce)?

I've tried this. It forced to downgrade sphinx from 6.1.0 to 5.3.0. why ?

Don't know, nothing in the PR sets the version of sphinx, so i guess is within the allowed versions , if you give me the command you used i'm happy to check

I took a look at the CI jobs and noticed a few errors:
mypy errors in our pre-commit job
Apparently MyST-parser introduced a new way to construct create_warnings and it is checking for a particular warning type. The myst-parser warnings object is here:
https://github.com/executablebooks/MyST-Parser/blob/a784880c7fbd893566087b83deec081376740e2c/myst_parser/warnings_.py#L10-L26
Here's the error:
myst_nb/core/render.py:99: error: Argument "subtype" to "create_warning" of "DocutilsRenderer" has incompatible type "str"; expected "MystWarnings"  [arg-type]
myst_nb/core/render.py:225: error: Unexpected keyword argument "wtype" for "create_warning" of "DocutilsRenderer"  [call-arg]
/home/runner/.cache/pre-commit/repofub48hzv/py_env-python3.9/lib/python3.9/site-packages/myst_parser/mdit_to_docutils/base.py:162: note: "create_warning" of "DocutilsRenderer" defined here
myst_nb/core/render.py:225: error: Unexpected keyword argument "wtype" for "create_warning" of "DocutilsRenderer"  [call-arg]
myst_nb/core/render.py:228: error: Argument "subtype" to "create_warning" of "DocutilsRenderer" has incompatible type "str"; expected "MystWarnings"  [arg-type]
/home/runner/.cache/pre-commit/repofub48hzv/py_env-python3.9/lib/python3.9/site-packages/myst_parser/mdit_to_docutils/base.py:162: note: "create_warning" of "DocutilsRenderer" defined here
myst_nb/core/render.py:228: error: Argument "subtype" to "create_warning" of "DocutilsRenderer" has incompatible type "str"; expected "MystWarnings"  [arg-type]
myst_nb/core/render.py:979: error: Unexpected keyword argument "wtype" for "create_warning" of "DocutilsRenderer"  [call-arg]
/home/runner/.cache/pre-commit/repofub48hzv/py_env-python3.9/lib/python3.9/site-packages/myst_parser/mdit_to_docutils/base.py:162: note: "create_warning" of "DocutilsRenderer" defined here
myst_nb/core/render.py:979: error: Unexpected keyword argument "wtype" for "create_warning" of "DocutilsRenderer"  [call-arg]
myst_nb/core/render.py:983: error: Argument "subtype" to "create_warning" of "DocutilsRenderer" has incompatible type "str"; expected "MystWarnings"  [arg-type]
/home/runner/.cache/pre-commit/repofub48hzv/py_env-python3.9/lib/python3.9/site-packages/myst_parser/mdit_to_docutils/base.py:162: note: "create_warning" of "DocutilsRenderer" defined here
myst_nb/core/render.py:983: error: Argument "subtype" to "create_warning" of "DocutilsRenderer" has incompatible type "str"; expected "MystWarnings"  [arg-type]
myst_nb/sphinx_.py:305: error: Unexpected keyword argument "wtype" for "create_warning" of "DocutilsRenderer"  [call-arg]
/home/runner/.cache/pre-commit/repofub48hzv/py_env-python3.9/lib/python3.9/site-packages/myst_parser/mdit_to_docutils/base.py:162: note: "create_warning" of "DocutilsRenderer" defined here
myst_nb/sphinx_.py:310: error: Argument "subtype" to "create_warning" of "DocutilsRenderer" has incompatible type "str"; expected "MystWarnings"  [arg-type]
myst_nb/docutils_.py:306: error: Unexpected keyword argument "wtype" for "create_warning" of "DocutilsRenderer"  [call-arg]
/home/runner/.cache/pre-commit/repofub48hzv/py_env-python3.9/lib/python3.9/site-packages/myst_parser/mdit_to_docutils/base.py:162: note: "create_warning" of "DocutilsRenderer" defined here
myst_nb/docutils_.py:312: error: Argument "subtype" to "create_warning" of "DocutilsRenderer" has incompatible type "str"; expected "MystWarnings"  [arg-type]
myst_nb/docutils_.py:337: error: Unexpected keyword argument "wtype" for "create_warning" of "DocutilsRenderer"  [call-arg]
/home/runner/.cache/pre-commit/repofub48hzv/py_env-python3.9/lib/python3.9/site-packages/myst_parser/mdit_to_docutils/base.py:162: note: "create_warning" of "DocutilsRenderer" defined here
myst_nb/docutils_.py:342: error: Argument "subtype" to "create_warning" of "DocutilsRenderer" has incompatible type "str"; expected "MystWarnings"  [arg-type]

Regression test breakages
This one is probably simple to fix, there are some regression test changes detected:
For example:
-        <footnote_reference auto="1" ids="footnote-reference-1" refid="a">
+        <footnote_reference auto="1" ids="id1" refid="a">
             1

-        <footnote_reference auto="1" ids="footnote-reference-2" refid="b">
+        <footnote_reference auto="1" ids="id2" refid="b">
             2

To fix these you generally just need to delete the corresponding regression test file, and then re-run the tests.

I've been trying to use that PR on top of 0.17.2 but looks like PR needs to be rediffed
+ /usr/bin/gzip -dc /home/tkloczko/rpmbuild/SOURCES/python-myst-nb-0.17.2.tar.gz
+ /usr/bin/tar -xof -
+ STATUS=0
+ '[' 0 -ne 0 ']'
+ cd MyST-NB-0.17.2
+ /usr/bin/chmod -Rf a+rX,u+w,g-w,o-w .
+ /usr/bin/cat /home/tkloczko/rpmbuild/SOURCES/python-myst-nb-UPGRADE-myst-parser-1.0.patch
+ /usr/bin/patch -p1 -s --fuzz=0 --no-backup-if-mismatch -f
1 out of 2 hunks FAILED -- saving rejects to file myst_nb/core/read.py.rej
1 out of 6 hunks FAILED -- saving rejects to file myst_nb/core/render.py.rej
1 out of 4 hunks FAILED -- saving rejects to file myst_nb/docutils_.py.rej
2 out of 3 hunks FAILED -- saving rejects to file myst_nb/sphinx_.py.rej
2 out of 2 hunks FAILED -- saving rejects to file pyproject.toml.rej

I need to take a closer look at how MystWarnings is working in create_warnings. I will need to loop back around to this PR in a couple days.

@chrisjsewell I have tried to mirror the new warnings_.py structure that has been put in place in myst-parser but I am getting mypy issues due to the mix of MystWarnings and MystNBWarnings. The render objects from myst-parser is returning MystWarnings when I need a union of both.
myst_nb/core/render.py:100: error: Argument "subtype" to "create_warning" of "DocutilsRenderer" has incompatible type "MystNBWarnings"; expected "MystWarnings"  [arg-type]

Would be interested in thoughts on how to resolve this if you've got time. Thanks.

In short term, would it be acceptable to just suppress these warnings with type: ignore?

I'm personally fine with that - it feels like the pain people are feeling with a version capped and outdated MyST parser is stronger than the pain they might feel if some problem occurs because of this type mismatch.
I'd suggest we just try to get these changes in quickly and cut a release. Then keep an eye for new issues that might be related to this and provide guidance (inc telling people to version cap) if so.

I've fixed the type errors in a PR to this branch: https://github.com/aleivag/MyST-NB/pull/1
I did find a couple of changes to behavior from this process.
Just haven't heard back from @aleivag yet.

Thanks for making that effort @Yoshanuikabundi - in that case I'd recommend the following course of action:

Give @aleivag a few days to review and merge @Yoshanuikabundi's PR.
If he doesn't respond in that time, I'll apply @Yoshanuikabundi's commit here (w/ attribution) and will push to @aleivag's branch.
We can then see if the test suite is happy.

@Yoshanuikabundi what were the behavior changes that you noticed?

(FYI I'm not currently maintaining this repo: https://github.com/executablebooks/meta/issues/961)

OK I've cherry-picked and pushed the two commits from @Yoshanuikabundi's PR to this branch. Let's see how that impacts tests and such.

@choldgraf I was initially confused about this error because I don't see how anything I did could cause it (and also I don't understand it at all), so I checked out the commit on this branch before I did any work (a150582232cc07d33d519152e3697388667ead34) and I get a very similar error locally there:
_____________________________ ERROR collecting tests/test_docutils.py ______________________________
tests/test_docutils.py:11: in <module>
    from myst_nb.docutils_ import Parser
myst_nb/docutils_.py:73: in <module>
    class Parser(MystParser):
myst_nb/docutils_.py:82: in Parser
    create_myst_settings_spec(NbParserConfig, "nb_"),
.soap/test/lib/python3.8/site-packages/myst_parser/parsers/docutils_.py:211: in create_myst_settings_spec
    return tuple(
.soap/test/lib/python3.8/site-packages/myst_parser/parsers/docutils_.py:212: in <genexpr>
    attr_to_optparse_option(at, getattr(defaults, at.name), prefix)
.soap/test/lib/python3.8/site-packages/myst_parser/parsers/docutils_.py:200: in attr_to_optparse_option
    at_options, default_str = _attr_to_optparse_option(attribute, default)
.soap/test/lib/python3.8/site-packages/myst_parser/parsers/docutils_.py:185: in _attr_to_optparse_option
    raise AssertionError(
E   AssertionError: Configuration option execution_mode not set up for use in docutils.conf.

So I think this is might be from a change in a dependency? I'm looking into it but I'm in unfamiliar territory.

I suggest we roll back or pin as many non-myst-parser versions as we can until we get the tests passing, and then merge and iterate selectively from there.
This seems to be where the field that generates this error is coming from:
https://github.com/executablebooks/MyST-NB/blob/5d972446636b631dd5777f286420cce3e906cfce/myst_nb/core/config.py#L138-L146
cc also @agoose77 in case any of this is familiar? I think he's looked through the myst-nb codebase before.

Wait a minute, are these failures all about mypy? These should be in pre-commit not in the actual pytest so things are not getting confused. But hey, tests are starting to pass :)

It is related to typing, but not mypy; myst-parser uses the type signatures of the config objects to perform some translation. In myst-nb we used from __future__ import annotations, which has the effect of storing type signatures as strings. This is not something that myst-parser anticipates, and therefore fails. We can fix this on the myst-parser side, but that would require a new release of myst-parser. For now, then, we can just update myst-nb to use non-string annotations for this module.

Can the typing verification be excluded from pytest or handled in a different tool? That way at least we can separate the functional tests that would use dynamic typing. The typing tests can be a bit finicky with different python versions, package versions, etc.

I think our strategy here is that we should optimize for getting these versions bumped in a way that will not confuse users. If tests are failing only because we are not meeting some strict requirement of the test that may not actually translate to an impaired user UX, I am okay loosening the test restriction or using a hacky workaround.

To be clear, the tests are failing because we broke something by moving to stringized annotations. I've reverted that part of the PR, which should make the tests pass :crossed_fingers:

For sure that sounds like a functionality issue that needs to be addressed. I was thinking about having the tests be a bit more separated so it is easier to read. At some point the tests did not start to run because it detected bad typing errors, which does not tell us if the tests would actually fail for the user or not. Having those checks are great to have and address, but have them a bit separate so its easier to judge which one to prioritize and which ones can/should be resolved by dropping older version support

Amazing! Thanks for this iteration folks. It looks like the only "failing" thing is the documentation having a few broken cross-reference links because the myst docs have changed. I would be fine merging this as-is in order to get it in. But if anyone wants to quickly fix those I'm happy to review and merge.

I've pushed fixes for the Intersphinx links that are breaking RTD to my branch: https://github.com/Yoshanuikabundi/MyST-NB/commits/upgrade-to-1
The docs build locally for me without warnings and I've spot checked that most of the links still go to the same places. Was just a matter of updating to the new syntax for specifying Intersphinx links and fixing some ambiguities.
Thanks for taking a look @agoose77, I don't know that I ever would have figured that out!


share: downgrading and changing permissions should be bundled in one command

If a file already has 'writer' permission, 'drive share -role read' does not change the permissions to reader.
For example, if you run this:

drive share -role writer -emails<EMAIL_ADDRESS>-id ABC123
drive share -role reader -emails<EMAIL_ADDRESS>-id ABC123

then the file with id ABC123 retains the writer permission, despite the script reporting back:

successful share for test with email<EMAIL_ADDRESS>role "reader" accountType "user"

which gives the impression that the file now has "reader" permission.
However,

drive share -role reader -emails<EMAIL_ADDRESS>-id ABC123
drive share -role writer -emails<EMAIL_ADDRESS>-id ABC123

works, i.e. the permission can be upgraded to writer, but not downgraded to reader.
(Of course, you could unshare first, and then reshare, but it changing permissions should be possible in one command...)

I should add that

drive share -role writer -with-link -id ABC123
drive share -role reader -with-link -id ABC123

does work as expected.
(Despite the message

successful share for test with email "", role "reader" accountType "anyone"
share err test: googleapi: Error 400: Permission value field required, required

)

Hi @odeke-em - any updates on this? It's tricky because unshare/reshare is not equivalent to 'downgrading' permissions.
E.g. "unshare fully, then reshare as reader" may change how others have put the file into folders. Also, for folders, "unshare fully, then reshare as reader", has the side-effect that users are then added to sub-folders (when previously they weren't).
Maybe it's not possible with the current API version - any thoughts?


Krylov and preconditioners?

At a glance, it looks like you're showing stationary iterations, which is fine to demonstrate how to execute code, but not a good example of how to actually solve equations. I know y'all are aware aware of better solvers, but hope the pedagogy here can support best practices.
Depending on your perception of the audience, it'd be useful to have an exercise that compares accuracy vs cost to help navigate the thicket of confounding factors in scaling studies.

Thanks @jedbrown  for your insights and suggestions. We added an explicit "Disclaimer" notice warning the folks that many different solution approaches exists. Here, we focus on a modified stationary iteration scheme where "damping" is added to bring the convergence order closer to O(N) rather than O(N^2) - known and/or referred to as damped pseudo-transient approach (second order Richardson iterations in e.g. Frankel (1950)).
Due to short course  time limitations and expected broad and diverse background from the audience, we did not plan to dive further technical details.
I close this issue, but do not hesitate to follow up offline if you have specific suggestions or references.


bpf lru map type fix in probe.

This pull request is now managed with CodeReviewHub. Refresh.


[Feature] Print KubeRay logs in Buildkite runner when tests fail

Search before asking

[X] I had searched in the issues and found no similar feature requirement.

Description
https://buildkite.com/ray-project/ray-ecosystem-ci-kuberay-ci/builds/5662#0193c112-1087-45ff-bdf6-bda38ca89bd4
If go test -timeout 30m -v ./test/e2e fails, the kubectl logs command will not be executed. Modify the behavior to print the logs only when there are failed tests.
https://github.com/ray-project/kuberay/blob/8ec59e518354f281cd7ac7cad68cc5546a06131e/.buildkite/test-e2e.yml#L15-L17
Use case
No response
Related issues
No response
Are you willing to submit a PR?

[ ] Yes I am willing to submit a PR!

Hi, @kevin85421 Can I take on this?


fixed type name exception on unsupported method signature types

i had a 'bool' in my signature, so the gen tool had thrown an exception Method 'DrvQueryDriverInfo' has non-exportable type 'typeCode'. With this fix, it now prints Method 'DrvQueryDriverInfo' has non-exportable type 'Boolean'

Thanks @mwetzko. Appreciate the contribution.


Unit test fails when Razor page returns a partial

A small update to the sample code is needed when unit testing a Razor page action that returns a partial. Here's the last line of the action that I'm testing.
return Partial("_PartialViewName", modelObject);
The page works perfectly when running in the browser. When called from a unit test, the return statement throws an ArgumentNullException, "Value cannot be null. (Parameter 'metadataProvider')".
at Microsoft.AspNetCore.Mvc.ViewFeatures.ViewDataDictionary..ctor(IModelMetadataProvider metadataProvider, ModelStateDictionary modelState, Type declaredModelType)
at Microsoft.AspNetCore.Mvc.ViewFeatures.ViewDataDictionary..ctor(IModelMetadataProvider metadataProvider, ModelStateDictionary modelState)
at Microsoft.AspNetCore.Mvc.RazorPages.PageModel.Partial(String viewName, Object model)
at MyNamespace.Web.Pages.UploadModel.OnPost() in C:***.Web\Pages\Upload.cshtml.cs:line 67
at **.Tests.Pages.UploadPageTests.OnPost_SavesUploadWithClaimsUserName() in ***.Tests\Pages\UploadPageTests.cs:line 119
The unit test sets up a PageContext exactly as shown in the sample code. I am instantiating a new EmptyModelMetadataProvider and using it to instantiate the ViewData as indicated.
    var httpContext = new DefaultHttpContext();
    var modelState = new ModelStateDictionary();
    var actionContext = new ActionContext(httpContext, new RouteData(), new PageActionDescriptor(), modelState);
    var modelMetadataProvider = new EmptyModelMetadataProvider();
    var viewData = new ViewDataDictionary(modelMetadataProvider, modelState);
    var tempData = new TempDataDictionary(httpContext, Mock.Of<ITempDataProvider>());
    var pageContext = new PageContext(actionContext)
    {
        ViewData = viewData
    };
    var pageModel = new MyPageModel()
    {
        PageContext = pageContext,
        TempData = tempData,
        Url = new UrlHelper(actionContext)
    };

However, the Razor engine expects the Page itself to have a ModelMetadataProvider and this is null.
The solution is to set the PageModel.MetaDataProvider like so:
    var pageModel = new MyPageModel()
    {
        PageContext = pageContext,
        TempData = tempData,
        Url = new UrlHelper(actionContext),
        MetadataProvider = modelMetadataProvider
    };

Again, this only seems to be necessary when the page action returns a Partial. This is in .NET Core 3.1.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 28ae5984-32b1-13b6-7430-6a28460b42ce
Version Independent ID: 20dc0e1d-d582-c091-8243-cefbb1825397
Content: Razor Pages unit tests in ASP.NET Core
Content Source: aspnetcore/test/razor-pages-tests.md
Product: aspnet-core
Technology: aspnetcore-test
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

@lauraemilyjacobsen thanks for the detailed report.

oops, I missed it. I will take a look at it 🙂


WIP: Rebuild with parallel OpenBLAS

Bump build number and rebuild with the parallel OpenBLAS.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Looks like this relies on hmat-oss being rebuilt for it to pass. Please see PR ( https://github.com/conda-forge/hmat-oss-feedstock/pull/1 ) for that rebuild.

Looks like this relies on hmat-oss being rebuilt for it to pass. Please see PR ( https://github.com/conda-forge/hmat-oss-feedstock/pull/1 ) for that rebuild.

@jakirkham could you resubmit the travis build after the hmat-oss bump ?

Restarted the CIs now that hmat-oss is deployed.

This is now passing. Please take it in when you are ready.

Sorry, I had forgotten to take the WIP off earlier.


Issue with Scope Roles and powershell

When assigning a scoped role via Powershell, all roles appear to work, except "User Administrator".
This returns an error
Message: Must specify property roleObjectId of entity ScopedRoleMembership.
Changing the Role to "Groups Administrator" works fine.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7ee59fc3-8f8f-cecc-47c3-3e1c12248942
Version Independent ID: 45f956e0-d4ea-42cd-6e1c-0fd8dab34834
Content: Assign and list roles with administrative unit scope (preview) - Azure Active Directory
Content Source: articles/active-directory/users-groups-roles/roles-admin-units-assign-roles.md
Service: active-directory
Sub-service: users-groups-roles
GitHub Login: @curtand
Microsoft Alias: curtand

@darrenjoycenz Thank you for your feedback . We will investigate and update the thread.

@darrenjoycenz Apologies for the delay on this, this got stuck somewhere in internal issues.  Can you help us understand if you are still facing the issue as I was able to do this via powershell without any issue.
Please make sure that you are using the correct Object ID for the role. For user administrator its :
159033a3-46c6-47fb-b214-4de29d3d5b2a
You can get the objectIDs for all role by using this command :  Get-AzureADDirectoryRole

If you have any queries, please feel free to tag me in your comments


Convert to typescript

I've started to dive into Typescript. Looks promising to me so far.
@carlobeltrame Can you have a look at it if you feel this goes into the right direction? If so, I'd continue piece-by-piece with the rest of the code.

Ah wow, nice, thanks! Maybe have a look at https://github.com/ecamp/hal-json-vuex/tree/refactor-to-classes where I started to refactor the storeValueProxy file into classes. I think that should be completed before moving to Typescript, what do you think?

I think that should be completed before moving to Typescript, what do you think?
Ah nice, didn't see that branch before. Yes, makes sense to complete & merge that one before. Otherwise we'll have tons of conflicts.

@carlobeltrame I believe this is in a state where you could have another look at it. Would say 95% complete as a first shot. Appreciate a careful review.
Some open actions (potentially as separate issues, to be discussed):

[ ] Discuss and resolve the various inline comments marked as "TODO"
[ ] Avoid usage of "any" and inline rule exclusions
[ ] Real world test in ecamp3 (only tested independetly so far)
[ ] Consider splitting up index (Install/Export, API actions, helper functions)
[ ] Consider implementation of CanHaveItems as mixin/composable instead of as a base class
[ ] Naming and file organization: Names of classes/interfaces/etc. have now grown historically. I think it makes sense to take a step back and review what the best and most consistent naming would be.
[ ] LoadingStoreCollection is a class with a static function only which is a Javascript antipattern. Consider implementing as simple function or integrate back to LoadingStoreValue.
[ ] Unit tests for separate components?

There is still some work to do before we can merge this I think, but if you feel that some things should be done in later iterations let me know.

Yes agree. Let me see how far I get with the open points. Some of the questions I raised in the earlier comment might be too big to also squeeze into this pull request.
By the way: I also just uploaded a rebased version of the code status as of today (separating renaming of files and actual code change). Might be a bit easier to verify the code changes by looking at the last commit only:
https://github.com/usu/hal-json-vuex/commit/17d57ff7977a3a2916d3d7332d5095e7568a8ca4

I have also continued this a little, and I have come to the conclusion that for HasItems, normal inheritance should be enough, we don't need the more generic variant of mixins you described (a mixin is valuable if you want to apply it to multiple different base classes, but we only ever apply it to StoreValue).
But I am not quite finished with resolving all type-related refactorings I was doing. Maybe we can have a look at it some time.

Mein aktuellster Stand ist jetzt auf diesem Branch: https://github.com/ecamp/hal-json-vuex/tree/feature/typescript

@carlobeltrame
The 2 open points discussed last week are now implemented

$loadItems resolves to the collection object instead of the array of items
get cannot be used anymore with embedded collections (limited to reloading)

We'll probably still see more changes on the embedded collections. I don't think it's coded super cleanly.
But would appreciate if we can merge the current status and then divide future work into smaller chunks.
Alternatively, we could also open a v2-alpha branch (+v2 alpha releases) and start PR/merging into the alpha branch until we feel  the interface is robust and stable enough.

@carlobeltrame I've changed the target branch to next instead of master. So we merge and then tag/publish as 2.0.0-alpha.0? Or 1.3.0-alpha.0?

Yes, +1 for 2.0.0-alpha.0, since technically we already made some small breaking changes (to undocumented features), and this allows us to clean up some more if we deem it necessary.

v2.0.0-alpha.0 is published: https://www.npmjs.com/package/hal-json-vuex?activeTab=versions


How can I log real-ip using the middleware and goji.serve ?

Hi,
I'm currently using goji, and it's running behind an nginx reverse proxy. I set the headers passed to the application and used the middleware defined in goji/web/middleware
Now goji.Serve() prints the connections to stdout which are written to a file using supervisor. In the stdout, despite using the RealIP middleware, it still prints that the connections are made from my localhost (which actually is the case, but not the intended behaviour).
Is there a way I could use the standard output but with the RealIP ?

Not that this is a big issue, but what's the reason for not having middleware.RealIP in the default muxer? It's a pretty low-cost middleware, and it's needed in most production environments anyway (the place where performance actually matters), since they're [very?] likely to be behind a reverse proxy.

If you have it on by default in a non-proxied environment there's the (very
real) risk that the IP you expect to be "real" may be forged. This is a
sharp edge for users who don't know better.
nginx/HAProxy/Apache overwrite this header in full when you're proxying
upstream, which helps avoid this (or at least you may be more aware).
Since it's set-and-forget it's probably the better trade-off to explicitly
require the middleware to be added.
On Fri, 11 Sep 2015 at 6:12 pm Olegs Jeremejevs<EMAIL_ADDRESS>wrote:

Not that this is a big issue, but what's the reason for not having
middleware.RealIP in the default muxer? It's a pretty low-cost
middleware, and it's needed in most production environments anyway (the
place where performance actually matters), since they're [very?] likely to
be behind a reverse proxy.
—
Reply to this email directly or view it on GitHub
https://github.com/zenazn/goji/issues/89#issuecomment-139507041.

Alright, makes sense, thanks.


pull request for e2e test at 01/21/2017 23:45:12

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Statistics cannot select 3D variables

Open jsmall
Create a 2DData renderer
Open the statistics interface

Unless I am missing something, I can only select 2D variables. With a 3D only dataset, cannot add any variables.

Please specify where this data is, and how to open it (VDC, WRF, etc.) @StasJ


CLEAN: For Loop -> Dict Comprehension

Hello!
I changed For Loop to Dict Comprehension.
Improved readability and improved performance.
Thank You!

괜찮습니다. https://google.github.io/styleguide/pyguide.html#274-decision을 참조 하십시오.

Thank you for your review!


API schema generation

Is your feature request related to a problem? Please describe.
It would be nice to have an API schema generation feature as a prerequisite to automatic API documentation generation.
Describe the solution you'd like
Bocadillo is not targeting REST API apps specifically, so there needs to be some kind of "opt-in" to choose which endpoints should be treated as API endpoints.
User interface:

Advice users to adopt an architecture in which the REST API is a separate application which is .mount()ed on the main application, so they don't have to fiddle with schemas too much.
Provide a generate_schema option to API to turn on registration of endpoints by default
Provide a few utilities to turn on/off schema registration manually.

from bocadillo import API

api = API(generate_schema=True)

@api.route("/say/{message}")
async def say(req, res, message: str):
    res.media = {"message": message}

@api.route("/say/text/{message}", schema_ignore=True)
async def bar(req, res):
    res.text = "hello"

This should automatically register a route at "/schema.json" which returns the OpenAPI v3.0 schema for the application. It should be built by inspecting the HTTP routes only.
Ideally, Bocadillo should infer as much information as possible from the view and route. We don't want to force users to write the spec in the docstring.
Describe alternatives you've considered
/
Additional context
Derived from #8.
Take a look at how Starlette generates schemas:

https://www.starlette.io/schemas/
https://github.com/encode/starlette/blob/master/starlette/schemas.py

Starlette has extracted their SchemaGenerator out of the application class since v0.11: https://www.starlette.io/schemas/

Okay so, I think we’ve got far enough without tackling this important and highly asked for feature. This (built-in OpenAPI support) seems to be a game changer for lots of people. Let’s investigate it! Will need to update the issue description.


Dynamic classes for multi selection

I want to be able to style the selected options differently, base on the selection.
I tried this:
<ui-select-match ng-class="{'pending-selection': $item.pending}">{{$item.name}}</ui-select-match>

And even tried this:
<ui-select-match pending-selection="{{$item.pending}}">{{$item.name}}</ui-select-match>

However, it appears that '$item' is not in scope for the span.ui-select-match tag (where the ng-class/pending-selection get inserted into the template), as the ng-repeat is created inside that tag.
I am converting from using the original jQuery Select2 implementation, and I am able to do the dynamic classes because I can attach a class to each 'option', but I haven't been able to figure out how to do the same thing with to angular-ui-select.

Have you tried placing it inside ui-select-match?
eg.
<ui-select-match>
    {{$item.name}}
</ui-select-match>

Assuming answered, closing.

Sorry.  No, it was not answered.  Doing a span inside like that only changes the style of the writing on the 'button', not of the button itself.

You probably need to customise the match-multiple.tpl.html template then.

Assuming answered, closing.


reactfire 1.0.0 does not support firebase 4.0.0 with npm installation

Version info

React: 15.5.4
Firebase: 4.0.0
ReactFire: 1.0.0
Other (e.g. Node, browser, operating system) (if applicable):
Test case

Steps to reproduce

Expected behavior

Actual behavior

no support for all firebase 4.x.x

+1

We have officially deprecated reactfire, as we no longer believe it is the best solution for Firebase developers looking to integrate with React.
Please see the README for information on how to migrate to a better solution. We are working on some new efforts to better serve the React community in the future.


Github Homepage Clone linked on site

🛠 Fixes Issue #89
👨💻 Changes proposed
Github Home Page Clone added to main website

✔ Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[x] This PR does not contain plagiarized content.
[x] The title of my pull request is a short description of the requested changes.

📷 Screenshots

This branch is 2 commits ahead, 2 commits behind Rayman-Sodhi:main.


Scoping logins to subdomain or arbitrary field

Hey guys,
Im just wondering if this is still planned as a feature and/or if there is a currently a workaround? Working on a app with team based subdomain login.

Hi @Wurren,
I don't think anyone's working on it now. We considered implementing this feature, but it'd be quite complicated. There is a solution here: https://github.com/NoamB/sorcery/pull/534#issuecomment-42394156 but it requires overriding authentication method.
Another way would be to add callback to after_login list and do it like this:
def validate_user_scope
  @current_user = nil unless current_user.scope == expected_scope
end

This is far from being perfect, though, as first it logs user in, and then it logs out.

Damn.  Scoping could open up a few possibilities.
I may use the solution of overriding the authentication method. Messy, but probably best for what I want to do.
Thanks!


changes to included files not triggering reconfigure

Brief Issue Summary
whenever I make a change to a CMakeLists.txt file, it triggers a reconfigure. But if I have e.g. include(file.cmake) in the CMakeLists.txt file and I change file.cmake, it doesn't trigger an automatic reconfigure. Is it possible to do this?
CMake Tools Diagnostics
No response
Debug Log
No response
Additional Information
No response

This feature is not currently available, but we can add it in the future. We may not reach to implement this feature soon, but we appreciate any help from the community.

This was fixed with PR #2548 and is available starting in version 1.12.8 (pre-release).


Change radio flags to be simpler, store previous tracks

Radio command can't be started with voice command due to flags, so it has been simplified
Store previous tracks for potential use

LGTM! 🚢🚢🚢


[yugabyte/yugabyte-db#15603] Rename tablet_list to hash_range_list

This PR is simply a renaming PR for TABLET_LIST to HASH_RANGES_LIST supporting the PR #291 so that the changes in #291 can be reviewed easily.

Abandoning this in lieu of #297


Select defaults not recognized if it's an empty string

Hi,
if there is a list of options and of them has value as '' (empty string) and the model is set as empty string as well, it will not get synced being the default option empty. Easier to see than to say... check jsfiddle here.
I know about the new default option feature in 0.12.10 but the options are dynamic in this situation and there could be or not an empty string option.

There's a big problem with selecting options, http://jsfiddle.net/504L15f5/4/ for example

@amine014 the fiddle works properly with latest dev branch, so wait for the next release please.

Thanks Evan :)


Old dialog version being reused?

Hi
I have a bot that I have developed and tested locally. I have enabled the Skype channel and have been testing it to test my code. I have been testing the conversation and have made some code updates to dialog that is invoked down the conversation chain. However, those changes to the dialog do not seem to take effect through the Skype client. I've tried rebuilding and republishing the app. I've tried /deleteprofile and each time I enter the dialog, I hit the issue that an old version of my code is executing.
I tried debugging the app through the emulator with ngrok. And I run into the same issues. This really surprises me as I keep on starting a new conversation each time in the emulator, so I would assume it wouldn't be caching any version of my assembly that is no longer valid.
Any advice?
thanks!

In the C# version of the SDK, we don't serialize any code - we just serialize the class member state of the dialogs on the stack.  So if you're hitting older code, it must be an issue with the code available at that endpoint.  For example, perhaps the deployment does not contain the code you think it does?

@srozga, there might be old assemblies in the server. If you are using Web deploy, select remove additional files at destination on your publish profile.

Thanks, I did have a mess on the server. Not a bot framework issue.


How to modify "Storage Retention" in runtime ?. Is any REST API available

I'm using prometheus and want to modify "Storage Retention" using REST API ?. Could you share details on how to modify prometheus config at run time ?.

It makes more sense to ask questions like this on the prometheus-users mailing list rather than in a GitHub issue. On the mailing list, more people are available to potentially respond to your question, and the whole community can benefit from the answers provided.


Remove version: Microsoft.VCRedist.2022.arm64 version 14.31.31103.0

Package identifier migration
Multiple package identifiers sharing the exactly the same UpgradeCode, hence should be merged into one.

Resolves #180373

Microsoft Reviewers: Open in CodeFlow

Duplicate of #180387


How do you use this with sound over hdmi?

I'm using an rpi4, with 64-bit raspi-os on it.
I would like to try to play audio over my hdmi cord, as it goes to my receiver which is also my home theater setup.

Trying a short tone ...
Playing WAVE '/assets/audio/short-low-tone.wav' : Signed 16 bit Little Endian, Rate 44100 Hz, Stereo
aplay: set_params:1299: Sample format non available
Available formats:

IEC958_SUBFRAME_LE
tone_played=[0]
Device locked/invalid, won't start the application ...

Any idea how to fix this? Or do you have to use a standalone DAC/unused source
Also, my end goal is to get this to work in kodi, and maybe make my own addon to support this. Any idea on how to start, or if that is even possible?

Hello, for some reasons, it seems that the hdmi output cannot play the wav file I use to check if the device is available.
Given the error I assume that the device is not locked, so you can try setting ENABLE_GENERATED_TONE to no.
So you can add this
ENABLE_GENERATED_TONE=no
to your .env file.
If you are using configure.sh, add a -g no to obtain the same result.
I suppose that the issue probably depends on the fact that the device connected to hdmi cannot play 44.1, but might be able to play 48kHz. If that is the case, resampling will probably happen when you play music.
Let me know if this helps.

About the kodi plugin, uhm I don't really know. But there are some plugins which can control docker containers, so maybe I would start from one of those!

Thanks for the heads up and respone! I reset my env to use the enable generated tone command, and now I got this error when I try to play music:
Cannot connect to server socket err = No such file or directory
Cannot connect to server request channel
jack server is not running or cannot be started
JackShmReadWritePtr::~JackShmReadWritePtr - Init not done for -1, skipping unlock
JackShmReadWritePtr::~JackShmReadWritePtr - Init not done for -1, skipping unlock
STARTED TidalConnect services.
[2024-06-14 00:08:00.332] [tisoc] [warning] [PlaybackControllerImpl.cpp:472] Illegal state:1
[2024-06-14 00:08:03.600] [tisoc] [warning] [logger.cpp:22] [audio_worker.cpp:321] Attempting to initialize a decoder without initial data!
Expression 'hostSampleFormat = PaUtil_SelectClosestAvailableFormat( GetAvailableFormats( self->pcm ), userSampleFormat )' failed in 'src/hostapi/alsa/pa_linux_alsa.c', line: 1910
Expression 'PaAlsaStreamComponent_Initialize( &self->playback, alsaApi, outParams, StreamDirection_Out, NULL != callback )' failed in 'src/hostapi/alsa/pa_linux_alsa.c', line: 2175
Expression 'PaAlsaStream_Initialize( stream, alsaHostApi, inputParameters, outputParameters, sampleRate, framesPerBuffer, callback, streamFlags, userData )' failed in 'src/hostapi/alsa/pa_linux_alsa.c', line: 2840
Could not start stream-9988: Invalid stream pointer
Expression 'hostSampleFormat = PaUtil_SelectClosestAvailableFormat( GetAvailableFormats( self->pcm ), userSampleFormat )' failed in 'src/hostapi/alsa/pa_linux_alsa.c', line: 1910
Expression 'PaAlsaStreamComponent_Initialize( &self->playback, alsaApi, outParams, StreamDirection_Out, NULL != callback )' failed in 'src/hostapi/alsa/pa_linux_alsa.c', line: 2175
Expression 'PaAlsaStream_Initialize( stream, alsaHostApi, inputParameters, outputParameters, sampleRate, framesPerBuffer, callback, streamFlags, userData )' failed in 'src/hostapi/alsa/pa_linux_alsa.c', line: 2840
Could not start stream-9988: Invalid stream pointer
[2024-06-14 00:10:30] [info] asio async_shutdown error: asio.misc:2 (End of file)

Hello!
Which sampling rate were you playing?
In any case, I suppose that a custom configuration, which would set the format to 48khz might work.
Can you post the full container logs? I could be able to prepare a custom asound.conf.
Also post the output of
cat /proc/asound/cards
so I have the name of the hdmi device.
However I have found this issue and the outcome does not look promising. I might test on my pi3 over hdmi. I have a pi3 with moode next to my tv, so I can run a hdmi cable and try it, then I will let you know.

Is the os using a desktop? Or, is pulseaudio running?
We can verify if the device is locked using:
watch cat /proc/asound/vc4hdmi*/pcm0p/sub0/hw_params

Hello, I have tried, but I get the same error. Will try again and search for a solution... I'll let you know if I find something interesting.

I just wanted to mention that I can easily play to the TV via chromecast directly from the Tidal App on Android (I'm sure Airplay will work on iOS devices to the TV). Is this option viable for you as a workaround?

Thanks for looking into this so much! I sadly cannot use a chromecast from tidal app on my TV, since the ARC feature on my tv doesn't work (the whole hdmi slot just doesn't work). I think I'll try to get a DAC for my pi for now, but I was hoping for a solution that would allow me to use my receiver's built in DAC in order to play some dolby-atmos enabled tracks through tidal-connect.
Instead of making a kodi addon, I think I'll just try to add some music visualizer and lyrics to the raspi-os, which is what I'm running right now. Pulse audio is running, as pactl list does not return an error.
When I run watch cat /proc/asound/vc4hdmi*/pcm0p/sub0/hw_params, I get closed for both connections.
When I run cat /proc/asound/cards, my card names are vc4hdmi0, vc4hdmi1, and Headphones.
Thank you so much for helping me and looking into this!

Hello, thank you. It kind of bugs me that we could not make it work on that hdmi output. However this is quite an edge case anyway... generally people want to connect this app to an audio DAC.
If you find something, of course please update this ticket or open another.
Please star the repo if you like the work.
Cheers

Hello, today I tried again and had some success, albeit with a small limitation, I can only play up to standard quality (16bit/44.1kHz FLAC).
I have created three new presets in userconfig/, named hdmi-rpi.asound.conf, hdmi-rpi-44.asound.conf and hdmi-rpi-48.asound.conf.
So we can use three new values for ASOUND_FILE_PREFIX: hdmi-rpi, hdmi-rpi-44 and hdmi-rpi-48.
The first two worked for me on my Sony TV, the last (hdmi-rpi-48) does not work on my tv. But I have left it there just in case the result also depend on the connected TV.
So if you want to try, you need to update the repository first, using the following:
cd $HOME/tidal-connect
git config pull.rebase false
git pull

then you should add something like:
ASOUND_FILE_PREFIX=hdmi-rpi-44
to your .env file. Remove any CARD_INDEX or CARD_NAME.
Restart the container using:
docker-compose up -d --force-recreate
Let me know if this helps!

I've had some trouble enabling this, I keep on getting the error "No such device. "
I think the issue is that the hdmi card name used in your config is vc4hdmi, and it might need to be vc4hdmi0 or vc4hdmi1, depending on which slot the hdmi cord is plugged into. I have my hdmi cord plugged into slot 0, and I could not get it to work with the three new values given.
Here is my .env:
FRIENDLY_NAME=Desktoppie
MODEL_NAME=Raspberry Pi
ASOUND_FILE_PREFIX=hdmi-rpi
Here are my logs for hdmi-rpi:
Tidal Connect - https://github.com/GioF71/tidal-connect.git - entrypoint.sh version 0.1.7
Tidal Connect - https://github.com/GioF71/tidal-connect.git - common.sh version 0.1.5
FRIENDLY_NAME=Desktoppie
MODEL_NAME=Raspberry Pi
MQA_CODEC=false
MQA_PASSTHROUGH=false
CARD_NAME=
CARD_INDEX=
CARD_DEVICE=
CARD_FORMAT=
CREATED_ASOUND_CARD_NAME=
ENABLE_SOFTVOLUME=yes
ENABLE_GENERATED_TONE=yes
ASOUND_FILE_PREFIX=hdmi-rpi
FORCE_PLAYBACK_DEVICE=
SLEEP_TIME_SEC=3
RESTART_ON_FAIL=1
RESTART_WAIT_SEC=10
CLIENT_ID=
LOG_LEVEL=3
File [/userconfig/hdmi-rpi.asound.conf] has been provided, copying to [/etc/asound.conf] ...
FORCE_PLAYBACK_DEVICE empty, setting to [custom]
Current /etc/asound.conf:
works for me if audio quality is limited to 16/44
use this by adding the following to your .env file

ASOUND_FILE_PREFIX=hdmi-rpi
pcm.custom {
type plug
slave.pcm "hdmihw"
type "iec958"
slave.format "IEC958_SUBFRAME_LE"
}
pcm.hdmihw {
type hw
card "vc4hdmi"
}
Entering write_asound_if_needed ...
File [/etc/asound.conf] cannot be modified.
Completed write_asound_if_needed.
works for me if audio quality is limited to 16/44
use this by adding the following to your .env file

ASOUND_FILE_PREFIX=hdmi-rpi
pcm.custom {
type plug
slave.pcm "hdmihw"
type "iec958"
slave.format "IEC958_SUBFRAME_LE"
}
pcm.hdmihw {
type hw
card "vc4hdmi"
}
Setting playback device to [custom] ...
PLAYBACK_DEVICE=[custom]
Starting Speaker Application in Background (TMUX)
Sleeping for a while (3 seconds)...
ENABLE_GENERATED_TONE=[yes]
Generated tone is enabled
certificate_path=[/app/ifi-tidal-release/id_certificate/IfiAudio_ZenStream.dat]
COMMAND_LINE=/app/ifi-tidal-release/bin/tidal_connect_application          --tc-certificate-path /app/ifi-tidal-release/id_certificate/IfiAudio_ZenStream.dat          --playback-device custom          -f "Desktoppie"          --model-name "Raspberry Pi"          --codec-mpegh true          --codec-mqa false          --disable-app-security false          --disable-web-security false          --enable-mqa-passthrough false          --log-level 3          --enable-websocket-log "0"
Trying a short tone ...
ALSA lib pcm_hw.c:1713:(_snd_pcm_hw_open) Invalid value for card
aplay: main:788: audio open error: No such device
tone_played=[0]
Device locked/invalid, won't start the application ...
Sleeping 10 seconds before restarting ...
Repeating logs for hdmi-44:
ALSA lib pcm_hw.c:1713:(_snd_pcm_hw_open) Invalid value for card
aplay: main:788: audio open error: No such device
tone_played=[0]
Device locked/invalid, won't start the application ...
Sleeping 10 seconds before restarting ...
Repeating logs for hdmi-48
Trying a short tone ...
ALSA lib pcm_hw.c:1713:(_snd_pcm_hw_open) Invalid value for card
aplay: main:788: audio open error: No such device
tone_played=[0]
Device locked/invalid, won't start the application ...
Sleeping 10 seconds before restarting ...

Hello, this might happen because my device is a pi 3 and yours is a pi4, so 2 hdmi ports instead of 1.
Can you try editing your userconfig/hdmi-rpi.asound.conf and change
card "vc4hdmi"
to
card "vc4hdmi0"
and then restarting/recreating the container?
It this works I will add another set of files with a '0' suffix for the pi4.

That worked! Thank you !

Awesome! I will prepare the additional file tomorrow possibly. You will have to update the repo again and specify a different prefix, should you want to stay "upstream"

Just done that. For you to update:
cd $HOME/tidal-connect
git config pull.rebase false
git reset --hard
git pull

I have written that by memory and not directly tested, hopefully this will reset your status and update to the latest commit in the main branch.
Then edit your .env file and change ASOUND_FILE_PREFIX from hdmi-rpi to hdmi0-rpi.
Let me know if this works!
Cheers

Sorry for the late response, but that worked! Thank you so much for the fix!

Hi, I have a question opposite to this thread. MOODE audio 9.2 RPi4. How can I disable HDMI so that it is inactive during standard system operation?

Hello!
Actually, this is a common problem with usb audio, I assume that when the amp is off, the pi does not "see" the audio device and automatically switch to a valid output.
I don't think that turning hdmi output off would solve the issue. The picture below should clarify about how to disable hdmi.
Is there any chance that you can add a DAC hat to the pi4 like some Hifiberry DAC, or, even better especially if your amp has some available digital input, a Hifiberry Digi+ Pro?
This solution will virtually make your device immune to the problem, because the amp does not need to be on for the audio device to be recognized (as it is self-contained).

You're right. It switches automatically. I don't use HDMI. I don't use 3.5 jack either. I don't use RCA. I ONLY use the USB output for audio. My DAC has a USB input and that's all I use for audio.

Hello, then I'm afraid the best thing to do is to make sure that the dac is on before you turn on the pi...


Fix linting?

Broke something

Codecov Report
Base: 99.69% // Head: 99.61% // Decreases project coverage by -0.09% :warning:

Coverage data is based on head (b449060) compared to base (593f260).
Patch coverage: 80.47% of modified lines in pull request are covered.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##           master       #6      +/-   ##
==========================================
- Coverage   99.69%   99.61%   -0.09%
==========================================
  Files          32       34       +2
  Lines       64833    65084     +251
  Branches      468      485      +17
==========================================
+ Hits        64634    64832     +198
- Misses        113      165      +52
- Partials       86       87       +1

Impacted Files
Coverage Δ

ebcc/codegen/GCCSDxTx.py
100.00% <ø> (ø)

ebcc/codegen/RCCSDxTx.py
100.00% <ø> (ø)

ebcc/codegen/UCCSDxTx.py
100.00% <ø> (ø)

ebcc/ansatz.py
62.50% <62.50%> (ø)

ebcc/ueom.py
92.68% <69.23%> (+0.03%)
:arrow_up:

ebcc/util.py
89.32% <78.57%> (-1.34%)
:arrow_down:

ebcc/gebcc.py
90.35% <81.81%> (+0.96%)
:arrow_up:

ebcc/rebcc.py
85.59% <82.48%> (+0.44%)
:arrow_up:

ebcc/space.py
82.55% <82.55%> (ø)

ebcc/uebcc.py
94.32% <90.17%> (+0.16%)
:arrow_up:

... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


add support to test framework for parsing IPv6 addresses, which CircleCI assigns

We don't have tests for this, so submitting PR to verify it works on CircleCI.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: nmittler
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pkg/OWNERS [nmittler]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


default riff build tag should match sample yaml image tag

Ran into this during a demo today - i like to cd to the sample and then riff build using the defaults.

I discussed this with @markfisher and the thinking was that the default should apply to new functions that would start from 0.0.1 while existing samples should have instructions where the version is specified, currently at 0.0.2. So I would prefer to keep the default as is.


Make the operator work for PySpark in spark master

The operator currently does not support PySpark, which is available now in the master branch of Spark. The following changes are needed to make the operator support PySpark in the master branch:

[ ] Make the operator use the new Spark configuration properties introduced in https://github.com/apache/spark/pull/21092.
[ ] Create a version of the operator image based on a Spark image of the master branch.

@liyinan926 if this is not high priority for you, you can assign me for this, I will be playing soon with spark master anyways. (1st task only)
CC @prasanthkothuri

@mrow4a Are you still interested in taking this?

@liyinan926 Yes, on it now - I see cluster mode is broken for us in the master branch https://github.com/apache/spark/blob/master/resource-managers/kubernetes/docker/src/main/dockerfiles/spark/entrypoint.sh#L87

It appears, that that flag is not taken into account, if specified otherwise by properties file - seems to lunch in cluster mode, but just a printout of driver log is a bit confusing..

@liyinan926 as I understand by https://github.com/GoogleCloudPlatform/spark-on-k8s-operator/issues/129, the goes is to reuse existing API, right (to freeze it for beta release)

@mrow4a Can you clarify what you mean by the goal is to reuse existing API, right (to freeze it for beta release)?

Oops, I think I accidentally marked #129 as all done and closed it. The PySpark one is not done yet. Reopened #129.

@liyinan926 Python works out of the box without --py-files dependencies. Now the question is about the api:
spec:
  type: Python
  mainApplicationFile: "local:///opt/spark/examples/src/main/python/pi.py"
  deps:
    pyfiles:
      - {{ some-path-to-dependency }}

or reusing existing deps->files and type should resolve it to --py-files
spec:
  type: Python
  mainApplicationFile: "local:///opt/spark/examples/src/main/python/pi.py"
  deps:
    files:
      - {{ some-path-to-dependency }}

What do you think?

@mrow4a I think we should keep pyFiles as files may contain non-Python files so blindly resolving files to --py-files is not always appropriate.

@liyinan926 you are totally right, I just remembered that some cases pass both --files and --py-files

Very strange is this with --pyfiles:
+ readarray -t SPARK_EXECUTOR_JAVA_OPTS
+ '[' -n '' ']'
+ '[' -n s3a://spark-on-k8s-cluster/spark-app-dependencies/default/pyspark-pi/wordcount_python_job.zip ']'
+ PYTHONPATH='/opt/spark/python/lib/pyspark.zip:/opt/spark/python/lib/py4j-*.zip:s3a://spark-on-k8s-cluster/spark-app-dependencies/default/pyspark-pi/wordcount_python_job.zip'
+ PYSPARK_ARGS=
+ '[' -n '' ']'
+ '[' 2 == 2 ']'
++ python -V
+ pyv='Python 2.7.5'
+ export PYTHON_VERSION=2.7.5

And of course does not work. It adds the remote dependency to Python Path as s3a - needs investigation.

Strange, to make .zip files work, I needed to add
    wordcount_job_path = SparkFiles.get("wordcount_python_job.zip")
    spark.sparkContext.addPyFile(wordcount_job_path)

otherwise with just addPyFile it gives me
py4j.protocol.Py4JJavaError: An error occurred while calling o65.addFile.
: java.io.FileNotFoundException: File file:/opt/spark/work-dir/wordcount_python_job.zip does not exist


Feature: support duplicated column name from excel files

Given that row 1 in a excel file defines columns' name, it is valid to have multiple columns with the same name in excel.
Could sqlitebiter file xxxxx.xls with such a file could handle the case instead of raising the sqlite3.OperationalError: duplicate column name: COUNTRY error? Maybe by using a suffix _2 for the second column with a given name?

@thomasleveil
Thank you for your feedback.
I had released sqlitebiter 0.18.0, this version automatically renames duplicate column names (adding suffix as you mentioned).
e.g. duplicated columns like A, A, A, A_1, A_1 will rename to A, A_2, A_3, A_1, A_1_1.
Please try this version.

I'll close the issue.
Feel free to reopen if you still have any problems about the issue.

Thank you for this quick update. I had the occasion to use sqlitebiter with such a excel file this morning and everything went fine. Great work!

Thank you for your confirmation!


Add hubot-adapter topic

The list of hubot adapters in the hubot documentation is being replaced with a link to a GitHub topic search. Add the hubot-adapter topic to your repository on GitHub to include it in this list.
/cc https://github.com/github/hubot/pull/1320

Thank you.
I'll add it our product 😄 .

I added the topic.


The filter by  status functionality should display, applicantions based on the application status selected for filter

Describe the task
Currently the functionality for  filtering the applications based on different status of the  applications not working.
Please refer screenshot
Click on filter icon available with Enter a keyword field

Procedure to create new application

Go to recruitment under HR
Click on Add new application
Similarly click on Internship applications
Click on Add new application

Expected behavior
On clicking apply button in filter by status,  should display the  applications based on the status selected in the filter.   On clicking Close button the filter should be reset.
The required changes are required in Job applications and Internship applications
References
Specify any reference material / links

Action items:

[ ] Enable Apply button to send formData to the backend
[ ] Send the form data to the index function of ApplicationController
[ ] Check if the data is received in the controller
[ ] Write a Laravel query to filter out the applications based on the status keyword
[ ] Confirm if we are getting the filtered applications or not in the front end.


Update to .ci-gradle to enrich dependabot

This patch is adding the action to create a dependency graph in dependabot and get PRs from the public Maven repository (openrewrite) without disrupting the current project status.

Please, do not remove the branch. This is used here: https://github.com/moderneinc/moderne-cli/pull/99
If we decided to merge it, I will update the repo to use the main branch again


option: add page-name option to select by name

Usage:
.. drawio-figure:: pages.drawio
:format: png
:page-name: Page-1
Signed-off-by: Schspa Shi<EMAIL_ADDRESS>

Mostly fine.
I'd like to see some tests to make sure this behaviour doesn't break in the future, since we are doing manual parsing.

I have update this PR, the test case was added.


Main character restart on gestalt loaded save

Whenever you load a file with a gestalted main character, it forces you to go through character creation again, giving infinite extra levels.
In order to reproduce the bug, just loading a save with a Gestalt character should do the trick.
Hopefully, a good fix should keep the stats from the saved file when you load it instead of restarting the entire character creation process.

ToyBox Version: [1.3.6]
OS: [Windows 10]

Additional context
Going to "Party", then resetting character level seems to fix the unintended behaviour. However, this seems to cause hit point loss.
Manual_57_gestaltsav.zip

Can you also add your settings for this? This sounds like what happens when you incorrectly set up gestalt.

This is because of incorrectly having both classes flagged as gestalt. I'm adding a fix in #416 to prevent that from happening, and I've added a button to recover from this.


docker: Add centos7 to dockerstatic dockerfiles

[x] commit message has one of the standard prefixes
[ ] faq.md updated if appropriate
[ ] other documentation is changed or added (if applicable)
[ ] playbook changes run through VPC or QPC (if you have access)
[x] VPC/QPC not applicable for this PR
[ ] for inventory.yml changes, bastillion/nagios/jenkins updated accordingly

Security support for centos7 ends in June of this year, so its worth having a few containers on our machines until then
https://endoflife.date/centos

Created https://ci.adoptium.net/computer/test-docker-centos7-x64-1/

Dont merge yet. I am adding steps to install git 2.15.0 form source since the latest git that can be installed on centos7 is 1.8 which is too old to run tests


[Feature]: Add speaker, participants, organizers, team and waiting list to event detail page

Speaker, participants, organizers: From this event and all subevents
Waiting list: From this event (only for team members)
Team: From this event

@phollome
Sorry, for the long living branch. I started to write a raw sql query to get the full depth relations (speaker, participants, organizer) from the event tree. Current status:

I have a raw query, that iterates through the event tree

I have a raw query, that joins the relation tables to get participants, etc...

I wasn't able to combine those two querys and moved on with other tasks after trying it for a while. Maybe you have a better understanding of how to combine those two statements.

see event/$slug/utils.server.ts Line 205-272


Broken autofill since A111 gradio update

It still works technically but my autofill now looks like this:

Tried disabling cache with F12 to force any potential new css but it's still the same.

this is a problem in a111v2.2, v2.1 wont launch at all……

That looks like the issue in #146.
The culprit the was a broken outdated version of the openpose editor extension, are you perhaps using that too?

Yep, just found that out. Sorry, I had no idea that was causing the issue.


maybe use that

https://github.com/samverschueren/listr

oh boy, what a beautiful tool for creating a pipeline. But I guess it shouldn't give that much to the compiler. How do you intend to use it?

Eventually, this listr module doesn't do what I thought it did. Nevermind, current state is great already.


GHA workflow fails, it’s unclear if deployment works

https://github.com/ietf-ribose/bibxml-service/runs/5735494979?check_suite_focus=true
Not sure if a problem with GHA or our logic…

@kwkwan can you please help check why deployment failed? Thanks!

I think it is due to the deletion of the db-migration job when I test the setup of new environment variables before.  I have re-created the job and the workflow action can be re-run successfully.
https://github.com/ietf-ribose/bibxml-service/actions/runs/2057961430

GHA succeeded, thanks!


move calibration out of DBlock definition, see #1371

This separates out the calibration data from the dynamics in the DBlock

[x] Tests for new functionality/models or Tests to reproduce the bug-fix in code.
[x] Updated documentation of features that add new functionality.
[x] Update CHANGELOG.md with major/minor changes.

Requesting review from @mnwhite

Matt gives OK


deploy to bintray

Deployment to ossrh works, but is very slow.
Deployment to github doesn't work for me.
Therefore next candidate is bintray.

done


[Feature] Add default favorite

功能描述 / Feature description
Add a feature where you can select a favorites category to be default, so that when the heart is clicked, it is saved to that favorite by default without asking. When the favorites button is held, then the context menu to select a favorite should pop up. This would streamline the process of adding favorites for a more premium and less clunky feel.
备注 / Additional details
This feature does not have to be mandatory and it can selected in settings.
自查步骤 / Self-review steps

[ ] 如果您有足够的时间和能力，并愿意为此功能请求提交 PR ，请勾上此复选框 / Pull request is welcome. Check this if you want to start a pull request
[X] 您已搜索过 Issue Tracker，没有找到类似的请求 / I have searched on Issue Tracker, No duplicate or related open issue has been found
[X] 您确保这个 Issue 只发起一个功能请求。如果您有多个功能请求，烦请发起多个 Issue / Ensure there is only one feature request in this issue. Please make mutiply issue for mutiply feature request

This is one of the early implemented functions. Currently, this setting is
under the EH option. However, the description of the current option might
be a bit problematic. After enabling this option, it will be collected to
the last selected favorite by default. Long press to show the selection.
sanctifyy @.***>于2024年10月26日 周六01:56写道：

功能描述 / Feature description
Add a feature where you can select a favorites category to be default, so
that when the heart is clicked, it is saved to that favorite by default
without asking. When the favorites button is held, then the context menu to
select a favorite should pop up. This would streamline the process of
adding favorites for a more premium and less clunky feel.
备注 / Additional details
This feature does not have to be mandatory and it can selected in settings.
自查步骤 / Self-review steps

如果您有足够的时间和能力，并愿意为此功能请求提交 PR ，请勾上此复选框 / Pull request is welcome.
Check this if you want to start a pull request
您已搜索过 Issue Tracker https://github.com/3003h/Eros-FE/issues，没有找到类似的请求
/ I have searched on Issue Tracker
https://github.com/3003h/FEhViewer/issues, No duplicate or related
open issue has been found
您确保这个 Issue 只发起一个功能请求。如果您有多个功能请求，烦请发起多个 Issue / Ensure there is only
one feature request in this issue. Please make mutiply issue for mutiply
feature request

—
Reply to this email directly, view it on GitHub
https://github.com/3003h/Eros-FE/issues/373, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADRS3OYKGAWJR7JQIAYEIGLZ5KA33AVCNFSM6AAAAABQTYIWV2VHI2DSMVQWIX3LMV43ASLTON2WKOZSGYYTINZXGM2TQOI
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

After some looking I was able to find it, I was a bit confused by the description. Thanks.