GitLens stopped working

GitLens Version: 11.0.6
Git Version: 2.23.0

VSCode Version: 1.52.0
OS Version:

Steps to Reproduce:
Scenario 1

Go to Gitlens extension
Opening a module and checking the file history
Its empty - no histroy for the file (though I used it many times and the file has history)

Scenario 2

Opening a module
Pressing `Open Changes with Previous Revision
Nothing happend

When did this stop working? Was it working before in GitLens 11.0.6?
Can you try to see if the issue is still reproducible in the insiders edition?. You can install the insiders edition from here. But be sure to disable/uninstall the stable version of GitLens first.

I think the version of vscode is the point.
I found that using vscode 1.52 or 1.51  leads to this bug.

I just started seeing this today, Currently on VS Code 1.52.0. It started with the previous version. I reloaded and updated VSCode hoping to fix it, gitlens worked for a minute or two, but then stopped working after I saved a few files. Currently I am on v11.0.06 of gitlense, but not sure when that updated.
I am using VSCode on WSL.

Can you try to see if the issue is still reproducible in the insiders edition?
You can install the insiders edition from here. Be sure to disable/uninstall the stable version of GitLens first.

@eamodio

When did this stop working? Was it working before in GitLens 11.0.6?
Can you try to see if the issue is still reproducible in the insiders edition?. You can install the insiders edition from here. But be sure to disable/uninstall the stable version of GitLens first.

This also happens with the insiders edition

Can you please enable output channel logging by setting "gitlens.outputLevel": "debug" in your settings.
This will enable logging to the GitLens channel in the Output pane. Once enabled, please reproduce the issue, and attach the log from the GitLens channel.

@eamodio
Thanks. The bug I met fixed in the insiders edition.

@eamodio
[2020-12-18 02:22:18:053] [/Users/ue/Documents/dev/webapp/src/components/pages/games/CreationWizard/BundleStep] git rev-parse --show-toplevel • 7 ms
[2020-12-18 02:22:18:061] [/Users/ue/Documents/dev/webapp] git status --porcelain=v2 --find-renames -- ../../../webapp/src/components/pages/games/CreationWizard/BundleStep/CustomSettings.js • 6 ms
[2020-12-18 02:22:18:068] [/Users/ue/Documents/dev/webapp] git log --format=%x3cr%x3e%x20%H -n3 --follow --name-status -- ../../../webapp/src/components/pages/games/CreationWizard/BundleStep/CustomSettings.js • 6 ms

@udielenberg That's not enough for me to have any clue what is going on. Can you attach logs from when GitLens starts up and discovers the repositories, and then when the problem happens (as there are no errors in what you posted)?
Also is File history / blame the only thing not working? Do any of the other views work, Commits, Branches, etc? Is this a multi-root workspace or are you only opening a single folder? Are there any symlinks involved?

@eamodio
I've cloned a new repo and I've been asked to approve Gitlens Insiders.
After approving everything worked as expected.
So it seems the problem is with a specific project.
Is there a way to retrigger this modal to approve Gitlens connecting to github?
Here are my logs
On VSCode Load
[2020-12-18 20:14:25:882] GitLens (v2020.12.1804): syncedVersion=2020.12.1804, previousVersion=2020.12.1804, gitlens:views:welcome:visible=true, gitlens:views:updates:visible=false
[2020-12-18 20:14:25:882] [1] GitService.initialize
[2020-12-18 20:14:25:882] [2] GitService.getBuiltInGitApi
[2020-12-18 20:14:25:940] [2] GitService.getBuiltInGitApi completed • 58 ms
[2020-12-18 20:14:25:953] Git found: 2.23.0 @ /usr/local/bin/git • 12 ms
[2020-12-18 20:14:25:953] [1] GitService.initialize completed • 70 ms
[2020-12-18 20:14:25:967] Starting repository search in 1 folders
[2020-12-18 20:14:25:967] [3] GitService.repositorySearch(/Users/ue/Documents/dev/webapp) searching (depth=1)...
[2020-12-18 20:14:25:967] [4] GitService.getRepoPathCore — e=/Users/ue/Documents/dev/webapp, t=true
[2020-12-18 20:14:25:971] [5] LineAnnotationController.resume
[2020-12-18 20:14:25:972] [6] GitLineTracker.start
[2020-12-18 20:14:25:972] [6] GitLineTracker.start completed • 0 ms
[2020-12-18 20:14:25:972] [5] LineAnnotationController.resume completed • 0 ms
[2020-12-18 20:14:25:972] [7] LineAnnotationController.refresh
[2020-12-18 20:14:25:972] [8] GitLineTracker.start
[2020-12-18 20:14:25:972] [8] GitLineTracker.start completed • 0 ms
[2020-12-18 20:14:25:972] [9] GitLineTracker.start
[2020-12-18 20:14:25:972] [9] GitLineTracker.start completed • 0 ms
[2020-12-18 20:14:25:979] GitLens (v2020.12.1804) activated • 98 ms
[2020-12-18 20:14:25:980] [7] LineAnnotationController.refresh completed • 7 ms
[2020-12-18 20:14:25:982] [/Users/ue/Documents/dev/webapp] git rev-parse --show-toplevel • 14 ms
[2020-12-18 20:14:25:984] [4] GitService.getRepoPathCore No symlink detected; repoPath=/Users/ue/Documents/dev/webapp
[2020-12-18 20:14:25:984] [4] GitService.getRepoPathCore completed • 16 ms
[2020-12-18 20:14:25:984] [3] GitService.repositorySearch(/Users/ue/Documents/dev/webapp) found root repository in '/Users/ue/Documents/dev/webapp'
[2020-12-18 20:14:25:985] [a] GitService.repositorySearchCore — e=/Users/ue/Documents/dev/webapp, t=1
[2020-12-18 20:14:25:985] [b] GitService.repositorySearchCore — e=/Users/ue/Documents/dev/webapp/.vscode, t=0
[2020-12-18 20:14:25:985] [b] GitService.repositorySearchCore completed • 0 ms
[2020-12-18 20:14:25:985] [c] GitService.repositorySearchCore — e=/Users/ue/Documents/dev/webapp/build, t=0
[2020-12-18 20:14:25:986] [c] GitService.repositorySearchCore completed • 0 ms
[2020-12-18 20:14:25:986] [d] GitService.repositorySearchCore — e=/Users/ue/Documents/dev/webapp/config, t=0
[2020-12-18 20:14:25:986] [d] GitService.repositorySearchCore completed • 0 ms
[2020-12-18 20:14:25:986] [e] GitService.repositorySearchCore — e=/Users/ue/Documents/dev/webapp/cypress, t=0
[2020-12-18 20:14:25:986] [e] GitService.repositorySearchCore completed • 0 ms
[2020-12-18 20:14:25:986] [f] GitService.repositorySearchCore — e=/Users/ue/Documents/dev/webapp/public, t=0
[2020-12-18 20:14:25:986] [f] GitService.repositorySearchCore completed • 0 ms
[2020-12-18 20:14:25:986] [10] GitService.repositorySearchCore — e=/Users/ue/Documents/dev/webapp/scripts, t=0
[2020-12-18 20:14:25:986] [10] GitService.repositorySearchCore completed • 0 ms
[2020-12-18 20:14:25:987] [11] GitService.repositorySearchCore — e=/Users/ue/Documents/dev/webapp/src, t=0
[2020-12-18 20:14:25:987] [11] GitService.repositorySearchCore completed • 0 ms
[2020-12-18 20:14:25:987] [12] GitService.repositorySearchCore — e=/Users/ue/Documents/dev/webapp/x_cypressTests, t=0
[2020-12-18 20:14:25:987] [12] GitService.repositorySearchCore completed • 0 ms
[2020-12-18 20:14:25:987] [a] GitService.repositorySearchCore completed • 2 ms
[2020-12-18 20:14:25:987] [3] GitService.repositorySearch(/Users/ue/Documents/dev/webapp) searching in '/Users/ue/Documents/dev/webapp'...
[2020-12-18 20:14:25:987] [13] GitService.getRepoPathCore — e=/Users/ue/Documents/dev/webapp, t=true
[2020-12-18 20:14:25:994] [/Users/ue/Documents/dev/webapp] git rev-parse --show-toplevel • 6 ms
[2020-12-18 20:14:25:994] [13] GitService.getRepoPathCore No symlink detected; repoPath=/Users/ue/Documents/dev/webapp
[2020-12-18 20:14:25:995] [13] GitService.getRepoPathCore completed • 7 ms
[2020-12-18 20:14:25:995] [3] GitService.repositorySearch(/Users/ue/Documents/dev/webapp) found repository in '/Users/ue/Documents/dev/webapp'
[2020-12-18 20:14:25:995] [3] GitService.repositorySearch(/Users/ue/Documents/dev/webapp) returned 2 repositories (/Users/ue/Documents/dev/webapp, /Users/ue/Documents/dev/webapp) • 27 ms
[2020-12-18 20:14:26:687] [/Users/ue/Documents/dev/webapp] git remote -v • 9 ms
[2020-12-18 20:14:26:688] [14] GitRemoteParser.parse completed • 0 ms
[2020-12-18 20:14:26:688] [15] GitService.getRichRemoteProvider
[2020-12-18 20:14:26:688] [15] GitService.getRichRemoteProvider completed • 0 ms
[2020-12-18 20:14:26:688] [16] GitService.getRichRemoteProvider — {"includeDisconnected":true}
[2020-12-18 20:14:26:688] [16] GitService.getRichRemoteProvider completed • 0 ms

After opening the file
[2020-12-18 20:16:33:608] [f8] LineAnnotationController.onActiveLinesChanged — e=editor=undefined, selections=undefined, pending=false, reason=editor
[2020-12-18 20:16:33:608] [f9] LineAnnotationController.clear completed • 0 ms
[2020-12-18 20:16:33:608] [f8] LineAnnotationController.onActiveLinesChanged completed • 0 ms
[2020-12-18 20:16:33:608] [fa] LineHoverController.onActiveLinesChanged — e=editor=undefined, selections=undefined, pending=false, reason=editor
[2020-12-18 20:16:33:608] [fa] LineHoverController.onActiveLinesChanged completed • 0 ms
[2020-12-18 20:16:33:608] [fb] StatusBarController.onActiveLinesChanged — e=editor=undefined, selections=undefined, pending=false, reason=editor
[2020-12-18 20:16:33:608] [fb] StatusBarController.onActiveLinesChanged completed • 0 ms
[2020-12-18 20:16:33:651] [fc] GitUri.fromUri — e=Uri(file:///Users/ue/Documents/dev/webapp/src/components/pages/CreationWizard/BundleStep/Settings.js)
[2020-12-18 20:16:33:651] [fd] GitService.getRepoPath — e=Uri(file:///Users/ue/Documents/dev/webapp/src/components/pages/CreationWizard/BundleStep/Settings.js)
[2020-12-18 20:16:33:651] [fe] GitService.getRepository — e=Uri(file:///Users/ue/Documents/dev/webapp/src/components/pages/CreationWizard/BundleStep/Settings.js), t={"skipCacheUpdate":true}
[2020-12-18 20:16:33:659] [fe] GitService.getRepository returned undefined • 7 ms
[2020-12-18 20:16:33:659] [ff] GitService.getRepoPathCore — e=/Users/ue/Documents/dev/webapp/src/components/pages/CreationWizard/BundleStep/Settings.js, t=false
[2020-12-18 20:16:33:669] [100] LineAnnotationController.onActiveLinesChanged — e=editor=file:///Users/ue/Documents/dev/webapp/src/components/pages/CreationWizard/BundleStep/Settings.js, selections=undefined, pending=true, reason=editor
[2020-12-18 20:16:33:669] [101] LineAnnotationController.clear completed • 0 ms
[2020-12-18 20:16:33:669] [100] LineAnnotationController.onActiveLinesChanged completed • 0 ms
[2020-12-18 20:16:33:669] [102] LineHoverController.onActiveLinesChanged — e=editor=file:///Users/ue/Documents/dev/webapp/src/components/pages/CreationWizard/BundleStep/Settings.js, selections=undefined, pending=true, reason=editor
[2020-12-18 20:16:33:669] [102] LineHoverController.onActiveLinesChanged completed • 0 ms
[2020-12-18 20:16:33:669] [103] StatusBarController.onActiveLinesChanged — e=editor=file:///Users/ue/Documents/dev/webapp/src/components/pages/CreationWizard/BundleStep/Settings.js, selections=undefined, pending=true, reason=editor
[2020-12-18 20:16:33:669] [103] StatusBarController.onActiveLinesChanged completed • 0 ms
[2020-12-18 20:16:33:678] [/Users/ue/Documents/dev/webapp/src/components/pages/CreationWizard/BundleStep] git rev-parse --show-toplevel • 19 ms
[2020-12-18 20:16:33:686] [ff] GitService.getRepoPathCore No symlink detected; repoPath=/Users/ue/Documents/dev/webapp
[2020-12-18 20:16:33:686] [ff] GitService.getRepoPathCore completed • 27 ms
[2020-12-18 20:16:33:686] [fd] GitService.getRepoPath returned /Users/ue/Documents/dev/webapp • 34 ms
[2020-12-18 20:16:33:686] [fc] GitUri.fromUri returned GitUri(file:///Users/ue/Documents/dev/webapp/src/components/pages/CreationWizard/BundleStep/Settings.js repoPath=/Users/ue/Documents/dev/webapp) • 34 ms
[2020-12-18 20:16:33:686] [104] GitService.getRepository — e=GitUri(file:///Users/ue/Documents/dev/webapp/src/components/pages/CreationWizard/BundleStep/Settings.js repoPath=/Users/ue/Documents/dev/webapp)
[2020-12-18 20:16:33:686] [104] GitService.getRepository returned /Users/ue/Documents/dev/webapp • 0 ms
[2020-12-18 20:16:33:687] [105] GitService.isTracked returned true • 0 ms — e=GitUri(file:///Users/ue/Documents/dev/webapp/src/components/pages/CreationWizard/BundleStep/Settings.js repoPath=/Users/ue/Documents/dev/webapp)
[2020-12-18 20:16:33:867] [106] GitService.getBlameForFile — e=GitUri(file:///Users/ue/Documents/dev/webapp/src/components/pages/CreationWizard/BundleStep/Settings.js repoPath=/Users/ue/Documents/dev/webapp)
[2020-12-18 20:16:33:867] [106] GitService.getBlameForFile Cache miss: 'blame'
[2020-12-18 20:16:33:867] [106] GitService.getBlameForFile Cache add: 'blame'
[2020-12-18 20:16:33:867] [107] GitService.isTracked returned true • 0 ms — e=GitUri(file:///Users/ue/Documents/dev/webapp/src/components/pages/CreationWizard/BundleStep/Settings.js repoPath=/Users/ue/Documents/dev/webapp)
[2020-12-18 20:16:33:880] [108] GitService.getBlameForFile — e=GitUri(file:///Users/ue/Documents/dev/webapp/src/components/pages/CreationWizard/BundleStep/Settings.js repoPath=/Users/ue/Documents/dev/webapp)
[2020-12-18 20:16:33:880] [108] GitService.getBlameForFile Cache hit: 'blame'
[2020-12-18 20:16:33:920] [10a] GitService.getBlameForLine — e=GitUri(file:///Users/ue/Documents/dev/webapp/src/components/pages/CreationWizard/BundleStep/Settings.js repoPath=/Users/ue/Documents/dev/webapp), t=0
[2020-12-18 20:16:33:920] [10b] GitService.getBlameForFile — e=GitUri(file:///Users/ue/Documents/dev/webapp/src/components/pages/CreationWizard/BundleStep/Settings.js repoPath=/Users/ue/Documents/dev/webapp)
[2020-12-18 20:16:33:920] [10b] GitService.getBlameForFile Cache hit: 'blame'
[2020-12-18 20:16:33:931] [/Users/ue/Documents/dev/webapp] git blame --root --incremental -- src/components/pages/CreationWizard/BundleStep/Settings.js • 63 ms
[2020-12-18 20:16:33:931] [10c] GitService.getCurrentUser — /Users/ue/Documents/dev/webapp
[2020-12-18 20:16:33:931] [10c] GitService.getCurrentUser completed • 0 ms
[2020-12-18 20:16:33:932] [10d] GitBlameParser.parse completed • 0 ms
[2020-12-18 20:16:33:932] [106] GitService.getBlameForFile completed • 64 ms
[2020-12-18 20:16:33:932] [108] GitService.getBlameForFile completed • 51 ms
[2020-12-18 20:16:33:932] [10b] GitService.getBlameForFile completed • 11 ms
[2020-12-18 20:16:33:932] GitCodeLensProvider.provideCodeLenses: — 6 symbol(s) found
[2020-12-18 20:16:33:932] GitCodeLensProvider.provideCodeLenses: — 6 symbol(s) found
[2020-12-18 20:16:33:932] [10a] GitService.getBlameForLine completed • 12 ms
[2020-12-18 20:16:33:933] [109] GitLineTracker.updateState returned true • 12 ms — e=0, t=file:///Users/ue/Documents/dev/webapp/src/components/pages/CreationWizard/BundleStep/Settings.js
[2020-12-18 20:16:33:933] [10e] LineAnnotationController.onActiveLinesChanged — e=editor=file:///Users/ue/Documents/dev/webapp/src/components/pages/CreationWizard/BundleStep/Settings.js, selections=[0-0], pending=false, reason=editor
[2020-12-18 20:16:33:933] [10f] LineAnnotationController.refresh
[2020-12-18 20:16:33:933] [110] LineAnnotationController.clear completed • 0 ms
[2020-12-18 20:16:33:933] [10e] LineAnnotationController.onActiveLinesChanged completed • 0 ms
[2020-12-18 20:16:33:934] [111] LineHoverController.onActiveLinesChanged — e=editor=file:///Users/ue/Documents/dev/webapp/src/components/pages/CreationWizard/BundleStep/Settings.js, selections=[0-0], pending=false, reason=editor
[2020-12-18 20:16:33:934] [111] LineHoverController.onActiveLinesChanged completed • 0 ms
[2020-12-18 20:16:33:934] [112] StatusBarController.onActiveLinesChanged — e=editor=file:///Users/ue/Documents/dev/webapp/src/components/pages/CreationWizard/BundleStep/Settings.js, selections=[0-0], pending=false, reason=editor
[2020-12-18 20:16:33:934] [113] StatusBarController.updateBlame
[2020-12-18 20:16:33:934] [114] GitService.getRichRemoteProvider
[2020-12-18 20:16:33:934] [112] StatusBarController.onActiveLinesChanged completed • 0 ms
[2020-12-18 20:16:33:934] [114] GitService.getRichRemoteProvider completed • 0 ms
[2020-12-18 20:16:33:934] [115] GitService.getRichRemoteProvider
[2020-12-18 20:16:33:934] [115] GitService.getRichRemoteProvider completed • 0 ms
[2020-12-18 20:16:33:935] [113] StatusBarController.updateBlame completed • 1 ms
[2020-12-18 20:16:33:936] [10f] LineAnnotationController.refresh completed • selection(s)=[0-0] • 2 ms
[2020-12-18 20:16:33:948] [116] GitService.getBlameForRangeSync — e=<blame>, t=GitUri(file:///Users/ue/Documents/dev/webapp/src/components/pages/CreationWizard/BundleStep/Settings.js repoPath=/Users/ue/Documents/dev/webapp), i=[{"line":0,"character":0},{"line":248,"character":0}]
[2020-12-18 20:16:33:948] [116] GitService.getBlameForRangeSync completed • 0 ms

On click open changes with previous revision
[2020-12-18 20:18:06:840] [1f0] LineAnnotationController.onActiveLinesChanged — e=editor=file:///Users/ue/Documents/dev/webapp/src/components/pages/CreationWizard/BundleStep/Settings.js, selections=undefined, pending=true, reason=selection
[2020-12-18 20:18:06:840] [1f1] LineAnnotationController.clear completed • 0 ms
[2020-12-18 20:18:06:840] [1f0] LineAnnotationController.onActiveLinesChanged completed • 0 ms
[2020-12-18 20:18:06:840] [1f2] LineHoverController.onActiveLinesChanged — e=editor=file:///Users/ue/Documents/dev/webapp/src/components/pages/CreationWizard/BundleStep/Settings.js, selections=undefined, pending=true, reason=selection
[2020-12-18 20:18:06:840] [1f2] LineHoverController.onActiveLinesChanged completed • 0 ms
[2020-12-18 20:18:06:840] [1f3] StatusBarController.onActiveLinesChanged — e=editor=file:///Users/ue/Documents/dev/webapp/src/components/pages/CreationWizard/BundleStep/Settings.js, selections=undefined, pending=true, reason=selection
[2020-12-18 20:18:06:840] [1f3] StatusBarController.onActiveLinesChanged completed • 0 ms
[2020-12-18 20:18:07:067] [1f4] GitService.getBlameForFile — e=GitUri(file:///Users/ue/Documents/dev/webapp/src/components/pages/CreationWizard/BundleStep/Settings.js repoPath=/Users/ue/Documents/dev/webapp)
[2020-12-18 20:18:07:067] [1f4] GitService.getBlameForFile Cache hit: 'blame'
[2020-12-18 20:18:07:067] [1f4] GitService.getBlameForFile completed • 0 ms
[2020-12-18 20:18:07:069] [1f5] GitService.getBlameForFile — e=GitUri(file:///Users/ue/Documents/dev/webapp/src/components/pages/CreationWizard/BundleStep/Settings.js repoPath=/Users/ue/Documents/dev/webapp)
[2020-12-18 20:18:07:069] [1f5] GitService.getBlameForFile Cache hit: 'blame'
[2020-12-18 20:18:07:069] [1f5] GitService.getBlameForFile completed • 0 ms
[2020-12-18 20:18:07:072] GitCodeLensProvider.provideCodeLenses: — 6 symbol(s) found
[2020-12-18 20:18:07:075] GitCodeLensProvider.provideCodeLenses: — 6 symbol(s) found
[2020-12-18 20:18:07:077] [1f6] GitService.getBlameForRangeSync — e=<blame>, t=GitUri(file:///Users/ue/Documents/dev/webapp/src/components/pages/CreationWizard/BundleStep/Settings.js repoPath=/Users/ue/Documents/dev/webapp), i=[{"line":0,"character":0},{"line":248,"character":0}]
[2020-12-18 20:18:07:078] [1f6] GitService.getBlameForRangeSync completed • 0 ms
[2020-12-18 20:18:07:091] [1f8] GitService.getBlameForLine — e=GitUri(file:///Users/ue/Documents/dev/webapp/src/components/pages/CreationWizard/BundleStep/Settings.js repoPath=/Users/ue/Documents/dev/webapp), t=2
[2020-12-18 20:18:07:091] [1f9] GitService.getBlameForFile — e=GitUri(file:///Users/ue/Documents/dev/webapp/src/components/pages/CreationWizard/BundleStep/Settings.js repoPath=/Users/ue/Documents/dev/webapp)
[2020-12-18 20:18:07:091] [1f9] GitService.getBlameForFile Cache hit: 'blame'
[2020-12-18 20:18:07:091] [1f9] GitService.getBlameForFile completed • 0 ms
[2020-12-18 20:18:07:091] [1f8] GitService.getBlameForLine completed • 0 ms
[2020-12-18 20:18:07:091] [1f7] GitLineTracker.updateState returned true • 0 ms — e=2, t=file:///Users/ue/Documents/dev/webapp/src/components/pages/CreationWizard/BundleStep/Settings.js
[2020-12-18 20:18:07:091] [1fa] LineAnnotationController.onActiveLinesChanged — e=editor=file:///Users/ue/Documents/dev/webapp/src/components/pages/CreationWizard/BundleStep/Settings.js, selections=[2-2], pending=false, reason=selection
[2020-12-18 20:18:07:091] [1fb] LineAnnotationController.refresh
[2020-12-18 20:18:07:091] [1fa] LineAnnotationController.onActiveLinesChanged completed • 0 ms
[2020-12-18 20:18:07:091] [1fc] LineHoverController.onActiveLinesChanged — e=editor=file:///Users/ue/Documents/dev/webapp/src/components/pages/CreationWizard/BundleStep/Settings.js, selections=[2-2], pending=false, reason=selection
[2020-12-18 20:18:07:091] [1fc] LineHoverController.onActiveLinesChanged completed • 0 ms
[2020-12-18 20:18:07:092] [1fd] StatusBarController.onActiveLinesChanged — e=editor=file:///Users/ue/Documents/dev/webapp/src/components/pages/CreationWizard/BundleStep/Settings.js, selections=[2-2], pending=false, reason=selection
[2020-12-18 20:18:07:092] [1fe] StatusBarController.updateBlame
[2020-12-18 20:18:07:092] [1ff] GitService.getRichRemoteProvider
[2020-12-18 20:18:07:092] [1fd] StatusBarController.onActiveLinesChanged completed • 0 ms
[2020-12-18 20:18:07:092] [1ff] GitService.getRichRemoteProvider completed • 0 ms
[2020-12-18 20:18:07:092] [200] GitService.getRichRemoteProvider
[2020-12-18 20:18:07:092] [200] GitService.getRichRemoteProvider completed • 0 ms
[2020-12-18 20:18:07:092] [1fe] StatusBarController.updateBlame completed • 0 ms
[2020-12-18 20:18:07:093] [1fb] LineAnnotationController.refresh completed • selection(s)=[2-2] • 1 ms
[2020-12-18 20:18:11:975] [201] LineHoverController.provideDetailsHover — e=file:///Users/ue/Documents/dev/webapp/src/components/pages/CreationWizard/BundleStep/Settings.js, t=5:37
[2020-12-18 20:18:11:975] [202] LineHoverController.provideChangesHover — e=file:///Users/ue/Documents/dev/webapp/src/components/pages/CreationWizard/BundleStep/Settings.js, t=5:37
[2020-12-18 20:18:11:976] [201] LineHoverController.provideDetailsHover completed • 0 ms
[2020-12-18 20:18:11:976] [202] LineHoverController.provideChangesHover completed • 0 ms
[2020-12-18 20:18:13:591] [203] LineHoverController.provideDetailsHover — e=file:///Users/ue/Documents/dev/webapp/src/components/pages/CreationWizard/BundleStep/Settings.js, t=6:31
[2020-12-18 20:18:13:591] [204] LineHoverController.provideChangesHover — e=file:///Users/ue/Documents/dev/webapp/src/components/pages/CreationWizard/BundleStep/Settings.js, t=6:31
[2020-12-18 20:18:13:592] [203] LineHoverController.provideDetailsHover completed • 0 ms
[2020-12-18 20:18:13:592] [204] LineHoverController.provideChangesHover completed • 0 ms
[2020-12-18 20:18:14:406] [205] LineHoverController.provideDetailsHover — e=file:///Users/ue/Documents/dev/webapp/src/components/pages/CreationWizard/BundleStep/Settings.js, t=4:32
[2020-12-18 20:18:14:406] [206] LineHoverController.provideChangesHover — e=file:///Users/ue/Documents/dev/webapp/src/components/pages/CreationWizard/BundleStep/Settings.js, t=4:32
[2020-12-18 20:18:14:406] [205] LineHoverController.provideDetailsHover completed • 0 ms
[2020-12-18 20:18:14:406] [206] LineHoverController.provideChangesHover completed • 0 ms
[2020-12-18 20:18:18:954] [207] GitUri.fromUri — e=Uri(file:///Users/ue/Documents/dev/webapp/src/components/pages/CreationWizard/BundleStep/Settings.js)
[2020-12-18 20:18:18:954] [208] GitService.getRepoPath — e=Uri(file:///Users/ue/Documents/dev/webapp/src/components/pages/CreationWizard/BundleStep/Settings.js)
[2020-12-18 20:18:18:954] [209] GitService.getRepository — e=Uri(file:///Users/ue/Documents/dev/webapp/src/components/pages/CreationWizard/BundleStep/Settings.js), t={"skipCacheUpdate":true}
[2020-12-18 20:18:18:954] [209] GitService.getRepository returned undefined • 0 ms
[2020-12-18 20:18:18:954] [20a] GitService.getRepoPathCore — e=/Users/ue/Documents/dev/webapp/src/components/pages/CreationWizard/BundleStep/Settings.js, t=false
[2020-12-18 20:18:18:973] [/Users/ue/Documents/dev/webapp/src/components/pages/CreationWizard/BundleStep] git rev-parse --show-toplevel • 18 ms
[2020-12-18 20:18:18:974] [20a] GitService.getRepoPathCore No symlink detected; repoPath=/Users/ue/Documents/dev/webapp
[2020-12-18 20:18:18:974] [20a] GitService.getRepoPathCore completed • 19 ms
[2020-12-18 20:18:18:974] [208] GitService.getRepoPath returned /Users/ue/Documents/dev/webapp • 20 ms
[2020-12-18 20:18:18:974] [207] GitUri.fromUri returned GitUri(file:///Users/ue/Documents/dev/webapp/src/components/pages/CreationWizard/BundleStep/Settings.js repoPath=/Users/ue/Documents/dev/webapp) • 20 ms
[2020-12-18 20:18:18:974] [20b] GitService.getPreviousDiffUris — e=/Users/ue/Documents/dev/webapp, t=GitUri(file:///Users/ue/Documents/dev/webapp/src/components/pages/CreationWizard/BundleStep/Settings.js repoPath=/Users/ue/Documents/dev/webapp), i=undefined, n=0
[2020-12-18 20:18:18:975] [20c] GitService.getStatusForFile — e=/Users/ue/Documents/dev/webapp, t=../../../webapp/src/components/pages/CreationWizard/BundleStep/Settings.js
[2020-12-18 20:18:18:985] [/Users/ue/Documents/dev/webapp] Git Command failed: /usr/local/bin/git -c core.quotepath=false -c color.ui=false -c color.status=false status --porcelain=v2 --find-renames -- ../../../webapp/src/components/pages/CreationWizard/BundleStep/Settings.js • ../../../webapp/src/components/pages/CreationWizard/BundleStep/Settings.js: '../../../webapp/src/components/pages/CreationWizard/BundleStep/Settings.js' is outside repository • 10 ms
[2020-12-18 20:18:18:986] [/Users/ue/Documents/dev/webapp] git status --porcelain=v2 --find-renames -- ../../../webapp/src/components/pages/CreationWizard/BundleStep/Settings.js • 10 ms
[2020-12-18 20:18:18:986] [20d] GitStatusParser.parse completed • 0 ms
[2020-12-18 20:18:18:986] [20c] GitService.getStatusForFile completed • 11 ms
[2020-12-18 20:18:18:986] [20e] GitService.getPreviousUri — e=/Users/ue/Documents/dev/webapp, t=GitUri(file:///Users/ue/Documents/dev/webapp/src/components/pages/CreationWizard/BundleStep/Settings.js repoPath=/Users/ue/Documents/dev/webapp), i=undefined, n=0, o=undefined, r=false
[2020-12-18 20:18:18:994] [/Users/ue/Documents/dev/webapp] Git Command failed: /usr/local/bin/git -c core.quotepath=false -c color.ui=false -c log.showSignature=false log --format=%x3cr%x3e%x20%H -n3 --follow --name-status -- ../../../webapp/src/components/pages/CreationWizard/BundleStep/Settings.js • ../../../webapp/src/components/pages/CreationWizard/BundleStep/Settings.js: '../../../webapp/src/components/pages/CreationWizard/BundleStep/Settings.js' is outside repository • 8 ms
[2020-12-18 20:18:18:994] [/Users/ue/Documents/dev/webapp] git log --format=%x3cr%x3e%x20%H -n3 --follow --name-status -- ../../../webapp/src/components/pages/CreationWizard/BundleStep/Settings.js • 8 ms
[2020-12-18 20:18:18:995] [20e] GitService.getPreviousUri completed • 8 ms
[2020-12-18 20:18:18:995] [20b] GitService.getPreviousDiffUris completed • 20 ms
[2020-12-18 20:18:18:995] ShowMessage(info, 'There is no previous commit.', suppressCommitHasNoPreviousCommitWarning, {"title":"Don't Show Again"})
[2020-12-18 20:18:18:995] ShowMessage(info, 'There is no previous commit.', suppressCommitHasNoPreviousCommitWarning, {"title":"Don't Show Again"}) skipped

@udielenberg Thanks for the logs -- unfortunately I don't see anything in there that stands out
if you run git blame --root --incremental -- src/components/pages/CreationWizard/BundleStep/Settings.js in a terminal do you get a valid blame back?
I'm wondering if you might hitting a git issue with ignoreRevsFiles: see https://github.com/eamodio/vscode-gitlens/issues/1143#issuecomment-731843506

i got the same issue, pls help to fix that

Can you try to see if the issue is still reproducible in the insiders edition?
You can install the insiders edition from here. Be sure to disable/uninstall the stable version of GitLens first.

actually after install this preview vesion, it working again for me. thank you

@eamodio
sorry for the delayed answer
I re cloned the repo
I guess I had an issue with my git

@udielenberg So the issue went away? I think the issue was related to path casing -- where you opened a folder with a different casing in vscode than the actual casing on disk.

@eamodio It didnt went away.
but after you suggested its something with git i decided to take the short path and just re clone the repo


missing single quote on sentinel-hub-configuration readthedocs page

Missing single quote inside of tutorial code block on line 62.
Noticed this while running through the configuration directions and it triggered my OCD, lol.

Thanks for fixing this. :+1:
I'm merging into develop branch and it will be merged to master and updated in docs during the next version release.


🐛 BUG: does Miniflare.dispatchFetch handle redirect Response from worker script?

Which Cloudflare product(s) does this pertain to?
Miniflare
What version(s) of the tool(s) are you using?
<EMAIL_ADDRESS>What version of Node are you using?
20.11.1
What operating system and version are you using?
Linux 6.7 Arch Linux
Describe the Bug
Observed behavior
It appears that redirect response (e.g. 302 status) causes Error: redirect count exceeded regardless of location header.
Expected behavior
Preferably it returns response from worker script as is with 30x status and location header, instead of internally undici resolving redirection. I think this is preferred if framework author wants to run their server code on Miniflare by proxying request via dispatchFetch.
Steps to reproduce
I added a reproduction in this repository https://github.com/hi-ogawa/reproductions/tree/main/miniflare-redirect Please let me know if it is concise enough.
(additional context)
I'm currently testing running ViteRuntime to run Vite framework server side code inside Workerd/Miniflare. Here a few relevant links:

https://github.com/vitejs/vite/discussions/15774
https://github.com/hi-ogawa/vite-plugins/tree/main/packages/vite-node-miniflare
https://github.com/hi-ogawa/vite-runtime-workerd-examples/tree/main/examples/react-router-ssr-data-router

It's mostly working, but I just noticed that react-router/remix's server side redirection isn't working and it appears that it's hitting this bug/limitation of Miniflare.dispatchFetch.
Please provide a link to a minimal reproduction
https://github.com/hi-ogawa/reproductions/tree/main/miniflare-redirect
Please provide any relevant error logs
I also wrote this in readme of the reproduction repo, but I'll copy-paste it here:
Reveal log
$ node main.js https://example.local/redirect
[workerd] request.url = https://example.local/redirect
[workerd] request.url = https://example.local/redirect
[workerd] request.url = https://example.local/redirect
[workerd] request.url = https://example.local/redirect
[workerd] request.url = https://example.local/redirect
[workerd] request.url = https://example.local/redirect
[workerd] request.url = https://example.local/redirect
[workerd] request.url = https://example.local/redirect
[workerd] request.url = https://example.local/redirect
[workerd] request.url = https://example.local/redirect
[workerd] request.url = https://example.local/redirect
[workerd] request.url = https://example.local/redirect
[workerd] request.url = https://example.local/redirect
[workerd] request.url = https://example.local/redirect
[workerd] request.url = https://example.local/redirect
[workerd] request.url = https://example.local/redirect
[workerd] request.url = https://example.local/redirect
[workerd] request.url = https://example.local/redirect
[workerd] request.url = https://example.local/redirect
[workerd] request.url = https://example.local/redirect
[workerd] request.url = https://example.local/redirect
/home/hiroshi/code/personal/reproductions/miniflare-redirect/node_modules/.pnpm/undici@5.28.3/node_modules/undici/index.js:112
        Error.captureStackTrace(err, this)
              ^

TypeError: fetch failed
    at fetch (/home/hiroshi/code/personal/reproductions/miniflare-redirect/node_modules/.pnpm/undici@5.28.3/node_modules/undici/index.js:112:15)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async fetch2 (/home/hiroshi/code/personal/reproductions/miniflare-redirect/node_modules/.pnpm/miniflare@3.20240129.2/node_modules/miniflare/dist/src/index.js:4128:20)
    at async Miniflare.dispatchFetch (/home/hiroshi/code/personal/reproductions/miniflare-redirect/node_modules/.pnpm/miniflare@3.20240129.2/node_modules/miniflare/dist/src/index.js:8617:22)
    at async file:///home/hiroshi/code/personal/reproductions/miniflare-redirect/main.js:22:18 {
  cause: Error: redirect count exceeded
      at makeNetworkError (/home/hiroshi/code/personal/reproductions/miniflare-redirect/node_modules/.pnpm/undici@5.28.3/node_modules/undici/lib/fetch/response.js:352:9)
      at httpRedirectFetch (/home/hiroshi/code/personal/reproductions/miniflare-redirect/node_modules/.pnpm/undici@5.28.3/node_modules/undici/lib/fetch/index.js:1141:28)
      at httpFetch (/home/hiroshi/code/personal/reproductions/miniflare-redirect/node_modules/.pnpm/undici@5.28.3/node_modules/undici/lib/fetch/index.js:1090:24)
      at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
      at async /home/hiroshi/code/personal/reproductions/miniflare-redirect/node_modules/.pnpm/undici@5.28.3/node_modules/undici/lib/fetch/index.js:600:16
      at async mainFetch (/home/hiroshi/code/personal/reproductions/miniflare-redirect/node_modules/.pnpm/undici@5.28.3/node_modules/undici/lib/fetch/index.js:584:16)
      at async httpFetch (/home/hiroshi/code/personal/reproductions/miniflare-redirect/node_modules/.pnpm/undici@5.28.3/node_modules/undici/lib/fetch/index.js:1090:18)
      at async /home/hiroshi/code/personal/reproductions/miniflare-redirect/node_modules/.pnpm/undici@5.28.3/node_modules/undici/lib/fetch/index.js:600:16
      at async mainFetch (/home/hiroshi/code/personal/reproductions/miniflare-redirect/node_modules/.pnpm/undici@5.28.3/node_modules/undici/lib/fetch/index.js:584:16)
      at async httpFetch (/home/hiroshi/code/personal/reproductions/miniflare-redirect/node_modules/.pnpm/undici@5.28.3/node_modules/undici/lib/fetch/index.js:1090:18)
}

With the help of @frandiox, I found that using dispatchFetch(url, { redirect: "manual" }) is an appropriate for my use case https://github.com/hi-ogawa/reproductions/commit/8d2f9eef33c5eaaf1141c744fcf2bbce2625a2a9.
I'm happy to close this issue, but maybe this should be still considered a bug for the default { redirect: "follow" } behavior. I'll keep this opened for now, but feel free to triage the issue as you like. Thanks!


[analyzer] fix typo in class name

AbtractCmdLineBenchmark is misspelled.

https://dart-review.googlesource.com/c/sdk/+/279385


When using mocks during development a non-federated zone setting can sometimes respond with zone tags

What happened?
Just to be clear this is a DX thing only.
Also see https://github.com/kumahq/kuma-gui/pull/2016

If you set up your development environment to show you a GUI in "non-federated zone" mode, our mocks will still respond with kuma.io/zone tags. Not only is this technically incorrect (the backend doesn't not respond with kuma.io/zone tags in "non-federated zone" mode), but it can also cause errors to happen due to how TagList works. TagList will try to create links to the zone detail page when it detects a kuma.io/zone tag, but in "non-federated zone" mode that route does not exist.
All in all this is confusing during development and makes it look like there is a problem. Again this does not effect the actual production build.

Closing this seeing as it turns out this is an actual bug not a DX thing, see https://github.com/kumahq/kuma-gui/pull/2016


[graphiql-react] issue with setting tabs title

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
On initial render, all tabs have title <untitled>, then current tab correctly extracts operation name and changes the tab's title.
https://user-images.githubusercontent.com/9862028/205900907-df2e4667-6564-4e40-8131-71cd188fa1d1.mov
From the code, I noticed that fuzzyExtractOperationName does not handle comments before operation.
E.g.
# Some comment...
query one {
  __typename
}

returns null
Expected Behavior
On initial render, all tabs have to have named titles
E.g.
# Some comment...
query one {
  __typename
}

returns one
Steps To Reproduce
You need to enable tabs to notice the issue (repro uses defaultTabs prop)

https://codesandbox.io/s/elegant-mcnulty-jhmyn5?file=/src/index.js

Module pattern

[ ] graphiql-umd
[ ] graphiql-esm
[ ] graphiql-commonjs

Environment
- GraphiQL Version: 2.2.0
- OS:
- Browser:
- Bundler:
- `react` Version:
- `graphql` Version:

Anything else?
Not sure, but I guess you could

add multi line to regex: const regex = /^(?!.*#).*(query|subscription|mutation)\s+([a-zA-Z0-9_]+)/m (this should work for cases when there are multiple operations as well)
run graphql print() on query before fuzzyExtractOperationName

Thank you for the sandbox! Addressed in #2968.


Change the title dynamically depending of current Page

This is from the template,  how can i make the 'title' show the name of the current Page or the $state of the view (i'm using ui.router instead of ngRoute). But the idea is show in the 'title' the name of the 'state'. How i can do that?. I have to pass that value from child to the parent i think.

I saw in the demo, the views have something like this:

  Scroll

And well the 'ui-yield-to="title"' show the span with 'Scroll', what directive do this?

@estvmachine ui-content-for and ui-yield-to


Modified text “背景 到紫色” to ”背景为紫色“.

[x] I have read freeCodeCamp's contribution guidelines.
[ ] My pull request has a descriptive title (not a vague title like Update index.md)
[ ] My pull request targets the master branch of freeCodeCamp.
[ ] None of my changes are plagiarized from another source without proper attribution.
[ ] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

@viggo111 thank you for your contribution

You're welcome it was no trouble at all.
<EMAIL_ADDRESS>发件人： Jingyi Ding
发送时间： 2018-12-25 15:01
收件人： freeCodeCamp/freeCodeCamp
抄送： viggo111; Mention
主题： Re: [freeCodeCamp/freeCodeCamp] Modified text “背景 到紫色” to ”背景为紫色“. (#21305)
@viggo111 thank you for your contribution
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.


CLI Version required?

The current text reads "You can create an incremental snapshot with the Azure CLI, you will need the latest version of Azure CLI. "
Can the text be updated to specify the minimum version of the CLI required?  Using a term like "the latest version" is non-specific; it's related to a particular point-in-time, and it provides no guidance to an end-user as to if they need to upgrade cli versions or not.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7d8793d6-bb58-2beb-f959-4654d7bdad69
Version Independent ID: a42a02a9-36b0-70dc-0737-816904f0e1f1
Content: Incremental snapshots (preview) for managed disks
Content Source: articles/virtual-machines/windows/disks-incremental-snapshots.md
Service: virtual-machines-windows
Sub-service: disks
GitHub Login: @roygara
Microsoft Alias: rogarana

also, I just looked at the release notes  https://docs.microsoft.com/en-us/cli/azure/release-notes-azure-cli?view=azure-cli-latest#september-24-2019; it appears that the minimum version required is 2.0.74

@larryclaman thanks for the feedback. I will work today to get that added to the doc.

@larryclaman I worked offline on this and we want to leave the doc as is for now. The reason is that this feature is still in preview so as we add or update features, we will include it in the latest version of CLI. So adding a minimum requirement will likely result in more pain for our users. That is also why we include that section to automatically update you to the latest version.
Once this feature moves to GA, we will be sure to add the minimum version as we do with our other docs.

thanks Micah.  I am going to submit a second issue regarding the "update your cli" section (which is powershell while the rest of the examples are bash; I think these should be consistent.  )

We can address that here as well. You mean to say a section updating the PS module like we have for the CLI module?

I see you opened it and that's valid feedback. I will triage that one to the author now :)

Thanks for being so responsive!  👍


chore(main): release 1.2.1

:robot: I have created a release beep boop
1.2.1 (2023-01-13)
Bug Fixes

deps: update dependency commander to v9.5.0 (2c6678f)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/EvolutionX-10/Ariaa/releases/tag/v1.2.1 :sunflower:


[Question] How to get/show direct download link with chosen format

Checklist

[x] I'm asking a question
[x] I've looked through the README and FAQ for similar questions
[x] I've searched the bugtracker for similar questions including closed ones

Question

How can I get/show direct download link with chosen format?
For example, if I use -F flag for showing all available formats
$ youtube-dlc -F https://www.facebook.com/honganhaoethaibinh/videos/360047792009932/
[facebook]<PHONE_NUMBER>09932: Downloading webpage
[facebook]<PHONE_NUMBER>09932: Downloading webpage
[facebook]<PHONE_NUMBER>09932: Downloading webpage
[info] Available formats for<PHONE_NUMBER>09932:
format code        extension  resolution note
2027693547365426a  m4a        audio only DASH audio   65k , m4a_dash container, mp4a.40.5 (48000Hz)
382022583207050v   mp4        256x144    DASH video   95k , mp4_dash container, avc1.64000C, video only
2778615029127443v  mp4        426x240    DASH video  231k , mp4_dash container, avc1.640015, video only
348238873165100v   mp4        640x360    DASH video  452k , mp4_dash container, avc1.64001E, video only
891567584710964v   mp4        854x480    DASH video  824k , mp4_dash container, avc1.64001F, video only
841507080009330v   mp4        1280x720   DASH video 1574k , mp4_dash container, avc1.640020, video only
1060163121084435v  mp4        1920x1080  DASH video 2659k , mp4_dash container, avc1.640032, video only
dash_sd_src        mp4        unknown    (best)

then I want to download and show direct link for<PHONE_NUMBER>084435v video and<PHONE_NUMBER>365426a audio. How can I get this direct link?
Thank you.

Sorry. I have figured out. There is option -g to show direct link.
Close this issue.

Facebook videos work? I thought some people mentioned it is broken 😕

@blackjack4494 it works well. I haven't tested full yet, but the public fan page video link is fine.


fix: add github token to publish workflow

Description of changes

Added gh_token as an environment variable per - https://docs.github.com/en/actions/security-guides/automatic-token-authentication

Issue #, if available

Description of how you validated changes
Checklist

[ ] PR description included
[ ] yarn test passes
[ ] Tests are [changed or added]
[ ] Relevant documentation is changed or added (and PR referenced)

Codecov Report

Merging #129 (a45cfe7) into main (64230a9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #129   +/-   ##
=======================================
  Coverage   63.38%   63.38%
=======================================
  Files          11       11
  Lines         396      396
  Branches      117      117
=======================================
  Hits          251      251
  Misses        145      145

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64230a9...a45cfe7. Read the comment docs.


Fix browser warmup value in results

Need to change warmup value from true to off to be consistent with the other tests.


produces application/octet-stream  Io error help

Describe the bug
Please provide details of the problem, including the version of Spring Cloud that you
are using.
 @GetMapping(value = ApiConst.UpcController.downloadTemplate.PATH,
            consumes = MediaType.APPLICATION_FORM_URLENCODED_VALUE,
            produces = MediaType.APPLICATION_OCTET_STREAM_VALUE)
    ResponseEntity<StreamingResponseBody> downloadTemplate()

error here
	@SuppressWarnings("ConstantConditions")
	public boolean hasEmptyMessageBody() throws IOException {
		InputStream body = this.response.getBody();
		// Per contract body shouldn't be null, but check anyway..
		if (body == null) {
			return true;
		}
		if (body.markSupported()) {
			body.mark(1);
			if (body.read() == -1) {
				return true;
			}
			else {
				body.reset();
				return false;
			}
		}
		else {
			this.pushbackInputStream = new PushbackInputStream(body);
			int b = this.pushbackInputStream.read();
			if (b == -1) {
				return true;
			}
			else {
				this.pushbackInputStream.unread(b);
				return false;
			}
		}
	}

this.pushbackInputStream.read()  Method threw 'java.io.IOException' exception.
stream is closed
why ?
feign is not spport produces application/octet-stream  ?

Hello @lnsane, please provide a minimal, complete, verifiable example that reproduces the issue.

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.

Closing due to lack of requested feedback. If you would like us to look at this issue, please provide the requested information and we will re-open the issue.


Compilation problem with Eigen

Hi! First of all, I'd like to thank for the great library! I'm playing around with the library and got following issue. My sample code is:
#include <iostream>
#include "stats.hpp"
#include <Eigen/Dense>

#define STATS_USE_EIGEN

int main() {

    Eigen::MatrixXd gamma_rvs = stats::rgamma<Eigen::MatrixXd>(100,50,3.0,2.0);
    std::cout << gamma_rvs << std::endl;

    return 0;
}

And compilation gave me:

/usr/local/bin/cmake --build /Users/alex/Development/stats_tests/cmake-build-debug --target stats_tests -- -j 4
Scanning dependencies of target stats_tests
[ 50%] Building CXX object CMakeFiles/stats_tests.dir/main.cpp.o
In file included from /Users/alex/Development/stats_tests/include/rand/rand.hpp:27:0,
from /Users/alex/Development/stats_tests/include/stats.hpp:37,
from /Users/alex/Development/stats_tests/main.cpp:2:
/Users/alex/Development/stats_tests/include/rand/rgamma.hpp:42:4: warning: inline function 'mT stats::rgamma(stats::uint_t, stats::uint_t, eT, eT) [with mT = Eigen::Matrix<double, -1, -1>; eT = double; stats::uint_t = unsigned int]' used but never defined
mT rgamma(const uint_t n, const uint_t k, const eT shape_par, const eT scale_par);
^~~~~~
[100%] Linking CXX executable stats_tests
Undefined symbols for architecture x86_64:
"Eigen::Matrix<double, -1, -1, 0, -1, -1> stats::rgamma<Eigen::Matrix<double, -1, -1, 0, -1, -1>, double>(unsigned int, unsigned int, double, double)", referenced from:
_main in main.cpp.o
ld: symbol(s) not found for architecture x86_64
collect2: error: ld returned 1 exit status
make[3]: *** [stats_tests] Error 1
make[2]: *** [CMakeFiles/stats_tests.dir/all] Error 2
make[1]: *** [CMakeFiles/stats_tests.dir/rule] Error 2
make: *** [stats_tests] Error 2

Could you please help me to figure out what's going on.
Thanks!
Alex

Dear @kthohr, thanks! It works.

Glad to hear it works now.


Fix broken link and typos in sequence classification data and modeling notebooks

@ohmeow - Minor doc changes for you review.

Thanks!!!


azurestack-Network 2015-06-15 swagger getting split in to multiple files matching the latest

2015-06-15 swagger getting split in to multiple files matching the latest and also adding descriptions, creating a new composite network swagger
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information

[x] The title of the PR is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
[ ] Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
[ ] If applicable, the PR references the bug/issue that it fixes.
[ ] Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

[x] I have read the contribution guidelines.
[x] My spec meets the review criteria:

[x] The spec conforms to the Swagger 2.0 specification.
[ ] The spec follows the guidelines described in the Swagger checklist document.
[ ] Validation tools were run on swagger spec(s) and have all been fixed in this PR.

This change is

@bganapa,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@jhendrixMSFT could you please help look at this error? I cant seem to find out the reason..

@sergey-shandar could you please help look at this error? I cant seem to find out the reason..

@sergey-shandar Thanks, Could you please let me know how I could run this locally so that I can catch before I push?

@bganapa here's a link how to use the tool https://github.com/Azure/oav#how-to-run-the-tool
Come back to potential breaking changes. Because the changes are big, it's hard to prove that the changes does [not] contain breaking changes for SDKs. I would suggest to ship these kind of changes with new api-version.

@bganapa should we close the PR?

@sergey-shandar , I am going to work on this PR tomorrow. I will sync up with you offline on why it is needed to keep the same api-version.

@bganapa would you still like to sync with me on this PR offline?

@sergey-shandar  synced with sergey offline.  The changes are being to be consumed only by AzureStack. All the azure tools are pointing to the latest api-version swagger.  AzureStack supports only the old api-version 2015-06-15 . We have already generated Python SDK consuming these changes from my fork.
https://github.com/Azure/azure-sdk-for-python/tree/master/azure-mgmt-network/azure/mgmt/network/v2015_06_15 ( Python SDK is multi versioned for the support of azure stack, rest like C# SDK is still single versioned and points only to the latest)
This Python SDK  is already being consumed in the CLI (master branch)

@amarzavery Do you think the Nodejs SDK will be ok with these changes?

cc:@amarzavery for the Q from sergey Do you think the Nodejs SDK will be ok with these changes?

@balajikris could you have a look the PR to make sure it will not cause problems for Nodejs SDK?

@sergey-shandar -  I don't understand why we're editing a 2015 version when there are multiple newer versions, nor do I understand why we're keeping the version number as is. I feel I'm missing a lot of context on this change to make a call.
FWIW, please note that any impact on the node sdk also impacts azure/azure-xplat-cli [tagging @EvgenyAgafonchikov for that].
In all, I think @amarzavery still the right person to make this call.

No modification for Ruby

 https://github.com/Azure/azure-sdk-for-python/pull/1180

No modification for NodeJS

@sergey-shandar Thanks for the taking care of this


Add tests for NotificationClientFactory

Motivation and Context
We want to make changes to NotificationClientFactory but it doesn't have any tests. This PR adds them so we can make the required changes
What has changed
Just added the tests
How to test?
Run the tests
Links
Done against https://trello.com/c/lZYrIXw7/118-create-an-auto-verifying-notify-endpoint-service

 Create an auto-verifying notify endpoint service


Wake tasks on demand

Closes #27

cargo bench -- --baseline master
     Running target/release/deps/concurrency-3e0a087b991e8291
concurrency/10000       time:   [147.90 us 148.32 us 148.81 us]
                        thrpt:  [67.198 Melem/s 67.422 Melem/s 67.611 Melem/s]
                 change:
                        time:   [-1.1204% +0.5084% +3.1406%] (p = 0.70 > 0.05)
                        thrpt:  [-3.0449% -0.5059% +1.1331%]
                        No change in performance detected.
Found 8 outliers among 100 measurements (8.00%)
  1 (1.00%) low mild
  2 (2.00%) high mild
  5 (5.00%) high severe

     Running target/release/deps/futures-fc22523273cb8b7a
futures/mpmc/8x8x1000/1 time:   [411.87 us 414.77 us 417.68 us]
                        thrpt:  [2.3942 Melem/s 2.4110 Melem/s 2.4279 Melem/s]
                 change:
                        time:   [+380.19% +397.37% +414.08%] (p = 0.00 < 0.05)
                        thrpt:  [-80.548% -79.894% -79.175%]
                        Performance has regressed.
Found 6 outliers among 100 measurements (6.00%)
  1 (1.00%) low severe
  2 (2.00%) low mild
  1 (1.00%) high mild
  2 (2.00%) high severe
futures/mpmc/8x8x1000/16
                        time:   [193.22 us 198.70 us 205.47 us]
                        thrpt:  [4.8668 Melem/s 5.0327 Melem/s 5.1754 Melem/s]
                 change:
                        time:   [-5.7392% +1.3975% +7.9555%] (p = 0.72 > 0.05)
                        thrpt:  [-7.3693% -1.3783% +6.0887%]
                        No change in performance detected.
Found 16 outliers among 100 measurements (16.00%)
  1 (1.00%) high mild
  15 (15.00%) high severe
futures/mpmc/8x8x1000/1000
                        time:   [170.77 us 173.72 us 177.18 us]
                        thrpt:  [5.6441 Melem/s 5.7563 Melem/s 5.8557 Melem/s]
                 change:
                        time:   [-3.6986% +1.6819% +7.0616%] (p = 0.57 > 0.05)
                        thrpt:  [-6.5958% -1.6541% +3.8407%]
                        No change in performance detected.
Found 16 outliers among 100 measurements (16.00%)
  4 (4.00%) high mild
  12 (12.00%) high severe

futures/mpsc/15x1x1000/1
                        time:   [45.596 us 45.806 us 46.058 us]
                        thrpt:  [21.712 Melem/s 21.831 Melem/s 21.932 Melem/s]
                 change:
                        time:   [+6.3181% +9.0611% +14.017%] (p = 0.00 < 0.05)
                        thrpt:  [-12.294% -8.3083% -5.9426%]
                        Performance has regressed.
Found 2 outliers among 100 measurements (2.00%)
  1 (1.00%) high mild
  1 (1.00%) high severe
futures/mpsc/15x1x1000/16
                        time:   [204.17 us 204.56 us 204.93 us]
                        thrpt:  [4.8797 Melem/s 4.8886 Melem/s 4.8979 Melem/s]
                 change:
                        time:   [-15.751% -13.938% -12.741%] (p = 0.00 < 0.05)
                        thrpt:  [+14.602% +16.196% +18.696%]
                        Performance has improved.
Found 17 outliers among 100 measurements (17.00%)
  7 (7.00%) low severe
  5 (5.00%) low mild
  2 (2.00%) high mild
  3 (3.00%) high severe
futures/mpsc/15x1x1000/1000
                        time:   [181.98 us 182.37 us 182.91 us]
                        thrpt:  [5.4671 Melem/s 5.4832 Melem/s 5.4952 Melem/s]
                 change:
                        time:   [-3.3568% -2.5098% -1.7357%] (p = 0.00 < 0.05)
                        thrpt:  [+1.7664% +2.5744% +3.4734%]
                        Performance has improved.
Found 20 outliers among 100 measurements (20.00%)
  5 (5.00%) low severe
  6 (6.00%) low mild
  3 (3.00%) high mild
  6 (6.00%) high severe

futures/spmc/1x15x50/1  time:   [514.88 us 518.83 us 523.31 us]
                        thrpt:  [95.546 Kelem/s 96.371 Kelem/s 97.111 Kelem/s]
                 change:
                        time:   [+1236.6% +1292.3% +1332.9%] (p = 0.00 < 0.05)
                        thrpt:  [-93.021% -92.817% -92.519%]
                        Performance has regressed.
Found 5 outliers among 100 measurements (5.00%)
  2 (2.00%) low mild
  2 (2.00%) high mild
  1 (1.00%) high severe
futures/spmc/1x15x50/16 time:   [528.35 us 532.26 us 537.09 us]
                        thrpt:  [93.094 Kelem/s 93.940 Kelem/s 94.635 Kelem/s]
                 change:
                        time:   [+1804.3% +2018.1% +2193.4%] (p = 0.00 < 0.05)
                        thrpt:  [-95.640% -95.279% -94.749%]
                        Performance has regressed.
Found 6 outliers among 100 measurements (6.00%)
  1 (1.00%) low mild
  1 (1.00%) high mild
  4 (4.00%) high severe
futures/spmc/1x15x50/50 time:   [527.64 us 530.48 us 533.69 us]
                        thrpt:  [93.688 Kelem/s 94.255 Kelem/s 94.761 Kelem/s]
                 change:
                        time:   [+2190.5% +2318.0% +2529.8%] (p = 0.00 < 0.05)
                        thrpt:  [-96.197% -95.864% -95.634%]
                        Performance has regressed.
Found 12 outliers among 100 measurements (12.00%)
  1 (1.00%) low severe
  2 (2.00%) low mild
  4 (4.00%) high mild
  5 (5.00%) high severe

futures/spsc/1x1x1000/1 time:   [76.365 us 76.617 us 76.875 us]
                        thrpt:  [13.008 Melem/s 13.052 Melem/s 13.095 Melem/s]
                 change:
                        time:   [+232.62% +241.25% +255.24%] (p = 0.00 < 0.05)
                        thrpt:  [-71.850% -70.696% -69.936%]
                        Performance has regressed.
Found 7 outliers among 100 measurements (7.00%)
  1 (1.00%) low mild
  3 (3.00%) high mild
  3 (3.00%) high severe
futures/spsc/1x1x1000/2 time:   [174.59 us 175.57 us 176.55 us]
                        thrpt:  [5.6641 Melem/s 5.6957 Melem/s 5.7278 Melem/s]
                 change:
                        time:   [+27.678% +29.156% +30.866%] (p = 0.00 < 0.05)
                        thrpt:  [-23.586% -22.574% -21.678%]
                        Performance has regressed.
Found 6 outliers among 100 measurements (6.00%)
  1 (1.00%) low severe
  1 (1.00%) low mild
  2 (2.00%) high mild
  2 (2.00%) high severe
futures/spsc/1x1x1000/1000
                        time:   [137.66 us 138.25 us 138.83 us]
                        thrpt:  [7.2032 Melem/s 7.2335 Melem/s 7.2644 Melem/s]
                 change:
                        time:   [-5.3496% -4.4355% -3.5505%] (p = 0.00 < 0.05)
                        thrpt:  [+3.6812% +4.6414% +5.6520%]
                        Performance has improved.
Found 2 outliers among 100 measurements (2.00%)
  1 (1.00%) low mild
  1 (1.00%) high mild

     Running target/release/deps/throughput-33f84b7172f32e52
mpmc/8x8x1000/1         time:   [79.242 us 79.746 us 80.480 us]
                        thrpt:  [12.426 Melem/s 12.540 Melem/s 12.620 Melem/s]
                 change:
                        time:   [+13.920% +16.142% +17.996%] (p = 0.00 < 0.05)
                        thrpt:  [-15.251% -13.898% -12.219%]
                        Performance has regressed.
Found 11 outliers among 100 measurements (11.00%)
  11 (11.00%) high severe
mpmc/8x8x1000/16        time:   [194.18 us 194.93 us 195.85 us]
                        thrpt:  [5.1059 Melem/s 5.1300 Melem/s 5.1500 Melem/s]
                 change:
                        time:   [-2.0131% +0.5727% +4.3042%] (p = 0.78 > 0.05)
                        thrpt:  [-4.1266% -0.5694% +2.0545%]
                        No change in performance detected.
Found 17 outliers among 100 measurements (17.00%)
  3 (3.00%) low severe
  5 (5.00%) low mild
  3 (3.00%) high mild
  6 (6.00%) high severe
mpmc/8x8x1000/1000      time:   [173.82 us 174.36 us 175.01 us]
                        thrpt:  [5.7140 Melem/s 5.7353 Melem/s 5.7531 Melem/s]
                 change:
                        time:   [+1.0419% +2.6270% +3.8896%] (p = 0.00 < 0.05)
                        thrpt:  [-3.7439% -2.5598% -1.0311%]
                        Performance has regressed.
Found 5 outliers among 100 measurements (5.00%)
  4 (4.00%) high mild
  1 (1.00%) high severe

mpsc/15x1x1000/1        time:   [46.250 us 46.443 us 46.673 us]
                        thrpt:  [21.426 Melem/s 21.532 Melem/s 21.622 Melem/s]
                 change:
                        time:   [+12.005% +14.499% +16.377%] (p = 0.00 < 0.05)
                        thrpt:  [-14.072% -12.663% -10.718%]
                        Performance has regressed.
Found 11 outliers among 100 measurements (11.00%)
  11 (11.00%) high severe
mpsc/15x1x1000/16       time:   [209.59 us 210.11 us 210.61 us]
                        thrpt:  [4.7482 Melem/s 4.7595 Melem/s 4.7713 Melem/s]
                 change:
                        time:   [-4.0778% -0.6940% +2.0212%] (p = 0.74 > 0.05)
                        thrpt:  [-1.9812% +0.6988% +4.2511%]
                        No change in performance detected.
Found 20 outliers among 100 measurements (20.00%)
  8 (8.00%) low severe
  2 (2.00%) low mild
  5 (5.00%) high mild
  5 (5.00%) high severe
mpsc/15x1x1000/1000     time:   [194.93 us 195.33 us 195.77 us]
                        thrpt:  [5.1079 Melem/s 5.1195 Melem/s 5.1301 Melem/s]
                 change:
                        time:   [-0.5982% +0.0781% +0.8626%] (p = 0.84 > 0.05)
                        thrpt:  [-0.8552% -0.0780% +0.6018%]
                        No change in performance detected.
Found 12 outliers among 100 measurements (12.00%)
  5 (5.00%) low severe
  2 (2.00%) low mild
  1 (1.00%) high mild
  4 (4.00%) high severe

spmc/1x15x1000/1        time:   [398.24 us 399.24 us 400.13 us]
                        thrpt:  [2.4992 Melem/s 2.5048 Melem/s 2.5110 Melem/s]
                 change:
                        time:   [+31.918% +33.648% +35.276%] (p = 0.00 < 0.05)
                        thrpt:  [-26.077% -25.177% -24.195%]
                        Performance has regressed.
Found 23 outliers among 100 measurements (23.00%)
  14 (14.00%) low severe
  3 (3.00%) low mild
  3 (3.00%) high mild
  3 (3.00%) high severe
spmc/1x15x1000/16       time:   [229.32 us 229.65 us 230.00 us]
                        thrpt:  [4.3479 Melem/s 4.3545 Melem/s 4.3607 Melem/s]
                 change:
                        time:   [-3.0112% -1.2951% +0.9313%] (p = 0.23 > 0.05)
                        thrpt:  [-0.9227% +1.3121% +3.1046%]
                        No change in performance detected.
Found 8 outliers among 100 measurements (8.00%)
  2 (2.00%) low mild
  2 (2.00%) high mild
  4 (4.00%) high severe
spmc/1x15x1000/1000     time:   [206.83 us 207.44 us 208.05 us]
                        thrpt:  [4.8065 Melem/s 4.8208 Melem/s 4.8349 Melem/s]
                 change:
                        time:   [-2.3128% +2.0579% +6.3338%] (p = 0.42 > 0.05)
                        thrpt:  [-5.9566% -2.0164% +2.3675%]
                        No change in performance detected.
Found 27 outliers among 100 measurements (27.00%)
  8 (8.00%) low severe
  6 (6.00%) low mild
  6 (6.00%) high mild
  7 (7.00%) high severe

spsc/1x1x1000/1         time:   [54.599 us 54.720 us 54.837 us]
                        thrpt:  [18.236 Melem/s 18.275 Melem/s 18.315 Melem/s]
                 change:
                        time:   [+189.89% +196.61% +201.35%] (p = 0.00 < 0.05)
                        thrpt:  [-66.816% -66.285% -65.504%]
                        Performance has regressed.
Found 7 outliers among 100 measurements (7.00%)
  2 (2.00%) low severe
  3 (3.00%) low mild
  2 (2.00%) high severe
spsc/1x1x1000/2         time:   [178.65 us 179.75 us 180.80 us]
                        thrpt:  [5.5309 Melem/s 5.5634 Melem/s 5.5974 Melem/s]
                 change:
                        time:   [+11.909% +14.226% +16.464%] (p = 0.00 < 0.05)
                        thrpt:  [-14.137% -12.454% -10.641%]
                        Performance has regressed.
Found 7 outliers among 100 measurements (7.00%)
  2 (2.00%) low mild
  4 (4.00%) high mild
  1 (1.00%) high severe
spsc/1x1x1000/1000      time:   [91.312 us 91.702 us 92.092 us]
                        thrpt:  [10.859 Melem/s 10.905 Melem/s 10.951 Melem/s]
                 change:
                        time:   [+138.32% +140.59% +142.62%] (p = 0.00 < 0.05)
                        thrpt:  [-58.783% -58.435% -58.040%]
                        Performance has regressed.
Found 4 outliers among 100 measurements (4.00%)
  2 (2.00%) low severe
  2 (2.00%) low mild

As expected this change has a huge impact to the throughput of the spmc case through the Stream interface, as well as a smaller but significant impact to all scenarios where the internal buffer has size 1, which can be explained by the extra atomic swap in Waitlist::wake.


Biome Serialization

Description
Latest.log is completely filled with NPEs about biome features that can't be serialized.
Sometimes the world loads fine, sometimes it doesn't - It never crashes though.
It seems that depending on the seed, biome features from vanilla will also fail to be serialized, also causing tons of NPEs.
How to reproduce (get your mind out of the gutter! -_-)

Using Twitch, with the modpack Enigmatica 5 development branch
Related mods: ultra_amplified_dimension-1.15.2-7.2.3

Make an instance with TerraForged and Ultra Amplified Terrain. (I think some seeds will have issues without UAT)
Launch, and create a new TerraForged world.
Look at the latest.log

Additional information
https://gist.github.com/NillerMedDild/0874052ed233231120ee0e1f8c99b749

These exceptions are caused by third-party mod Features that are not fully/correctly implemented.
TerraForged catches and handles these errors so they are not causing any problems for the normal operation of the game, it just means that certain advanced configuration options in TF cannot be used with these Features.
I know it looks a bit spammy in the console but it's potentially useful information to record for identifying compatibility issues in the future. I could probably change the log level of these messages to debug at least

A lower log level would be nice :)
I'll let the Ultra Amplified dev know about this issue, thanks!


Support dynamic watching for various workload types.

Signed-off-by: mingzhou.swx<EMAIL_ADDRESS>
Ⅰ. Describe what this PR does
Support dynamic watching for various workload types.

Codecov Report

Merging #47 (4fb0a0b) into master (cf29580) will increase coverage by 0.44%.
The diff coverage is 44.18%.

@@            Coverage Diff             @@
##           master      #47      +/-   ##
==========================================
+ Coverage   19.83%   20.28%   +0.44%
==========================================
  Files          21       21
  Lines        2425     2465      +40
==========================================
+ Hits          481      500      +19
- Misses       1872     1891      +19
- Partials       72       74       +2

Flag
Coverage Δ

unittests
20.28% <44.18%> (+0.44%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...bhook/workload/mutating/workload_update_handler.go
30.12% <0.00%> (-0.37%)
:arrow_down:

pkg/controller/rollout/rollout_controller.go
16.66% <40.90%> (+16.66%)
:arrow_up:

...controller/batchrelease/batchrelease_controller.go
47.05% <52.63%> (+1.82%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf29580...4fb0a0b. Read the comment docs.

/lgtm

/approve


Add nofollow to sign in links

Robots should not follow the sign in links.

Codecov Report

Merging #8509 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #8509      +/-   ##
==========================================
+ Coverage   41.71%   41.71%   +<.01%
==========================================
  Files         512      512
  Lines       66941    66941
==========================================
+ Hits        27926    27927       +1
+ Misses      35430    35427       -3
- Partials     3585     3587       +2

Impacted Files
Coverage Δ

models/repo_list.go
73.17% <0%> (-0.98%)
:arrow_down:

models/gpg_key.go
55.83% <0%> (-0.84%)
:arrow_down:

routers/repo/view.go
40.95% <0%> (+0.95%)
:arrow_up:

models/unit.go
67.56% <0%> (+5.4%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db65719...eef77ae. Read the comment docs.


Ports are not being sent when I edit/upgrade

Rancher versions: master 2.0 7/31
Steps to Reproduce:

Upgrade container and add a port

Results: The port is missing from the payload

@tfiduccia similar to the previous issue we had about this, the ports schema indicates this can not be updated. I will do an audit of the container edit/upgrade page and verify everything on the page is updatable. I'll remove ports for now but we should maybe open a bug in cattle if ports should be editable.


[fastlane] Fix slack action when it adds last_git_commit when passing adds last_git_commit_hash

Checklist

[x] I've run bundle exec rspec from the root directory to see all new and existing tests pass
[x] I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
[x] I've read the Contribution Guidelines
[x] I've updated the documentation if necessary.

Motivation and Context

The slack action prints out 3 payloads git_branch, last_git_commit_hash and last_git_commit whenever we pass only two of them - git_branch, last_git_commit_hash.

closes https://github.com/fastlane/fastlane/issues/14234
Description

The changes are about a way we were looking for a particular payload name in a default_payloads array. Before this change, we've been joining all of the items into a single string and check whether this string includes the payload name, i.e.
should_add_payload = ->(payload_name) { options[:default_payloads].nil? || options[:default_payloads].join(" ").include?(payload_name.to_s) }

options[:default_payloads] = [:git_branch, :last_git_commit_hash]
...
=> "git_branch last_git_commit_hash"

# we were iterating through each available option, so even though `last_git_commit` hasn't been provided with `default_payloads`, we were still finding this phrase as part of connected string

🙊 "git_branch last_git_commit_hash last_git_commit" includes `last_git_commit`

This change introduced a new way of checking whether provided default_payload list contains payload name by leveraging Ruby symbols.

The new unit test has been added to cover this case 💪
🙇 🙇

:+1:Nice work @mollyIV
One small addition: It would be nice to make more clear in the example that last_git_commit can be used used and not last_git_commit_message as pointed out in this line:
https://github.com/fastlane/fastlane/blob/dbd327d1baafd6761876738ac863f88889c573d8/fastlane/lib/fastlane/actions/slack.rb#L159
Or make it work only with last_git_commit_message

@MartyCatawiki sure, let's keep the docs up to date, will do 💪

@joshdholtz I updated the docs 👍 🙇


registration

@JuliaRegistrator register()

Registration pull request created: JuliaRegistries/General/108434
Tip: Release Notes
Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.
@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.
Tagging
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v1.0.0 -m "<description of version>" 43411943df25a57651a6edf184469229658f11f0
git push origin v1.0.0

@JuliaRegistrator register()

Registration pull request created: JuliaRegistries/General/108797
Tip: Release Notes
Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.
@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.
Tagging
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v1.0.1 -m "<description of version>" f8cf24b7d06be8d906c6421e9d5ea0017ecefd98
git push origin v1.0.1

@JuliaRegistrator register()

Registration pull request created: JuliaRegistries/General/108846
Tip: Release Notes
Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.
@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.
Tagging
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v1.0.2 -m "<description of version>" 8380b1775c86156b3642d1b01b16a997b979dbba
git push origin v1.0.2

@JuliaRegistrator register()

Registration pull request created: JuliaRegistries/General/110751
Tip: Release Notes
Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.
@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.
Tagging
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v1.0.3 -m "<description of version>" 259263fd155149f160034ed0eb381f0ed0184097
git push origin v1.0.3


styles: first try of removing global eui styles

With great help from @Pooya-Oladazimi  we found a possible solution for global style injection and overwriting consuming app syles. Solves https://github.com/ts4nfdi/terminology-service-suite/issues/144
We disabled the global style option in the Elastic UI Provider (EuiProvider) and created a wrapper with the missing styles from EuiProvider.
Applied to Autocomplete and DataContent widgets as a test.
What do you think of this implementation @Pooya-Oladazimi ?

@jusa3
Thanks for the quick implementation. It is nice. We just need to introduce a wrapper CSS class like ".sem-widget" and use that to narrow down the CSS file selectors. like instead of:
a{}
we use
.sem-widget a {}
so that we only change the anchor style inside the widgets and not globally.

@jusa3
one potential approach is to use another UI lib Material UI. especially because of this:
https://mui.com/material-ui/getting-started/usage/#globals


Request additional scopes with signIn

Hello,
Since the 6.0.0 it looks like isn't anymore possible to SignIn with scopes. The only way I'v found is :

firstly call signInWithConfiguration:presentingViewController:callback:
then call addScopes:presentingViewController:callback:

In my case, I need to connect my user to their Youtube account. It results in two" sign in" in a row, which can be weird for some users.
Is there a way to make one sign in with scope or this is a volunteer behavior?
Btw, thanks for the SPM and M1 compatibility!
Thanks
Florian

I'm facing the exact same problem.
Previously my login flow (login + grant scopes) was contained in a single web view step. Now we need to show one web view for the sign in and another for granting permissions which feels less convenient.
And thanks a lot for SPM and Apple Silicon support! It's awesome 😃

You are correct, with the 6.0.0 release we're requesting only the basic profile scopes (email, profile, openid) in the user's initial sign-in flow.  If you require an additional scope, this will need to happen via addScopes:presentingViewController:callback: sometime after the sign-in flow has been completed.  In keeping with the incremental authorization pattern, we recommend that any additional scope requests happen right before the scope is to be used and with context provided to the user as to why they might want to grant access.

Thanks @petea for the explanation.

Reopening for discussion.

Hi @petea. Very often we need to get all the scopes in time of sign in(or just after), and in this case it's very inconvenient to user to see Are you sure you want to sign in question, make a login and after that see this message again. Some of users could just cancel second one or decide that it's an issue. And in cases when user already gave this permissions( like when he used to use application, removed it and now installed again), after second question it just showing WebView and hide it immediately. It's working, but not very nice looking.
Other approach is just add possibility to hide 2nd popup with sign in question for cases when adding scopes going just after sign in.

Hi @petea. In our App, we have a use case that suffers from this decision. Our users are able to link their calendars (multiple options available) and he only needs sign-in to when we need his calendar consent. This now leads us to having to move the user through two sign-ins (from the eyes of the user) which is bad UX.
We understand the decision of only asking for consent if needed, but we also only want him to login when he wants to link his calendar.
It would be great if it would be possible to combine those two requests into one sign-in-flow again.

Hello @petea 👋  I have the same flow as @mamilov.
As soon as users sign in or register, the first screen we show is filled with information from Google Calendar.
By not being possible to sign in and add the calendar scope at the same time, we are forced to show two sign-in sheets just for the user to be able to get to our first authenticated screen 😔
Previously this was done in one step which was much more user friendly for our purposes.

This is not a good call. I understand your desire to sign in and then prompt for scope at a later time as more functionality is required. However in our app, this just creates a very poor user experience.  That's because we have Google Drive integration and that's all we need. So basically the user signs in and then immediately has to click a prompt again to open a dialog that appears to close immediately to provide the additional scope. Why? What was wrong with the previous method? This appears to be a poor decision on Google's behalf to force developers to use their product in a way that does not make sense. We require the ability to sign in with an initial scope. Period.

Hi @petea 👋
Any update on this matter? It seems like this change is heavily affecting the UX of a fair amount of apps...

I get this same issue, I think the repeated web view will confuse the user. Because user don't know or don't care it is an addScope of whatever. But they do see two web view for grant permission appearing in a row, which is really weird!
I agree that we could add scope when sign in like before.

At the risk of just repeating everything everyone else has said:
I understand only elevating scope when required... But for Firebase (a Google service), let's say I want to get the user's name/photo/profile when they login.
There's no explicit delay in that workflow, so it just requires us to programmatically pop-up 2 distinct WebViews right after one another.
As some Google apps are built with Flutter, this change in UI/UX seems problematic even for Google: https://github.com/flutter/flutter/issues/86436

@cpboyd note that basic profile scopes (email, profile, openid) are granted with the signIn flow, an additional addScopes flow is not required unless you need scopes beyond basic profile such as Contacts, Drive, Calendar, etc.

@petea Thanks for clarifying! I'm not currently using any other scopes, but my app depends on the Flutter plugin.
Would it be possible to build the extra scope flow into the existing WebView pop-up? i.e. somehow give users the ability to opt-out of specific scopes?
It seems like that might be nice even if not requesting at log-in, since as a user I might want to grant permission to Drive but not Contacts.

As everyone said, now the web page for grant scope access(step 2) show up and immediately dismissed, it doesn't show the grant process page to the user.
For add scope:

User click allow.
A new webpage is opened and dismissed immediately.
User has no chance to see what scope it request because this page closed immediately.
Granted access OK and related page in your app is showed, for me it is Google drive.

I raised an issue #44  because I got inconsistent warning email from Google for OAuth Verification Request. I need to pass this verification then I could publish my app to App Store.

FWIW since this library is now open source you can pretty trivially expose the interfaces from GoogleSignIn_Private.h and GIDSignInInternalOptions.h to achieve the single step authentication with scopes flow.
The implementation is already there (and is actually the same one used by the public signIn method) but just not exposed publicly.
let viewController = UIViewController()
let configuration = GIDConfiguration(clientID: "clientID", serverClientID: "serverID")
let options = GIDSignInInternalOptions.defaultOptions(
    with: configuration,
    presenting: viewController,
    loginHint: nil
) { user, error in

}
options.scopes = ["A", "B", "C"]
GIDSignIn.sharedInstance.signIn(with: options)

FWIW since this library is now open source you can pretty trivially expose the interfaces from GoogleSignIn_Private.h and GIDSignInInternalOptions.h to achieve the single step authentication with scopes flow.
The implementation is already there (and is actually the same one used by the public signIn method) but just not exposed publicly.
let viewController = UIViewController()
let configuration = GIDConfiguration(clientID: "clientID", serverClientID: "serverID")
let options = GIDSignInInternalOptions.defaultOptions(
    with: configuration,
    presenting: viewController,
    loginHint: nil
) { user, error in

}
options.scopes = ["A", "B", "C"]
GIDSignIn.sharedInstance.signIn(with: options)

For the changes needed, see this commit

I see the recent version 6.0.2 has different code structure than your commit!

I agree too, that in my app this makes for a UX that looks odd. What are users to understand from this "second sign in" requirement? Here's the way it looks in my app:
https://user-images.githubusercontent.com/5758762/135769337-f95bcaf8-ddf6-40a3-b2db-0fd5944947a5.mov
As remarked, it's not that hard to change the repo in your own fork to work around this. That will put additional overhead on devs using this repo though, when one wants to integrates changes from the main repo though.

Hello @petea

Reopening for discussion.

The discussion is now opened for 3 months, what's the result?
We will see any change in the official repo? Or do we need to fork?
Thanks

I need way to workaround, it's a very dumb decision to have two step authentication like this.

You can use the fork/PR here to workaround. I have a fork too with  similar workaround..

To me the most confusing thing about this process is that, underneath the hood, google implements oauth.  So:

Why would you mess with the extremely well-known oauth specs/expectations by limiting the scopes an application can initially request?  IMO, this definitely violates the principle of least astonishment.
Why would you change the process only for the consumers of this particular library?  Anyone can work around it by implementing the oauth client protocol themselves, or simply forking the library (as others have already done).

This is definitely a head scratcher for me.  I understand that applications can eff with users by requesting all kinds of extra permissions along with the basic permissions needed to sign in. But this doesn't change anything -- bad actors can trivially work around it -- and I'm curious how this was sold as a feature.

@dsharma To help you I'd need more details. I haven't used the sample. Why do you still need to grant additional scopes?

You are correct, with the 6.0.0 release we're requesting only the basic profile scopes (email, profile, openid) in the user's initial sign-in flow. If you require an additional scope, this will need to happen via addScopes:presentingViewController:callback: sometime after the sign-in flow has been completed. In keeping with the incremental authorization pattern, we recommend that any additional scope requests happen right before the scope is to be used and with context provided to the user as to why they might want to grant access.

I believe the need for this changes was to provide incremental authorisation ie

It is considered a best user-experience practice to request authorization for resources at the time you need them.

So if my app needs sign in with scope, and for us we know that the right point to ask for scope is at google sign in, then showing this unusual flow to my customers, just to provide 'a best user-experience' does not make sense.
Developers should be allowed to choose what's best point to get scopes. And if we feel the best point is at sign-in then we should be allowed to have sign in + scopes in one go.
This should be a recommendation but not enforcement. It seems like it is assumed that devs will never need sign in and scopes at same time.

Even Flutter, Google's own cross-platform app development platform is still avoiding v6 due to this specific issue:
https://github.com/flutter/flutter/issues/86436
It seems like having the vast majority of developers avoid upgrading their SDK isn't the intention of this change.
If this were really focused around user privacy, wouldn't the proper course of action be to give advance notice of the change with proper deprecation and a cut-off deadline?
Is the v5 SDK going to stop working at some point? If not, then developers can continue to easily avoid the incremental authorization by continuing to use v5.

I'm the maintainer of https://github.com/klippa-app/nativescript-login and I'm holding off the upgrade due to this issue.
It made sense to add this addScopes method to add extra scopes later on, if you need extra data from the user in a later process in the app, so that's perfectly fine.
However, it doesn't make a lot of sense to remove the scope parameter in the initial flow, as a lot of apps need extra scopes for their app to work at all, and the login flow is perfectly able to show the information about these scopes. On this principle my plugin is built and the only way now is to show 2 logins modals, which degrades the plugin UI, so I'm holding it off for now.

Can this PR be merged? https://github.com/google/GoogleSignIn-iOS/pull/67
The necessity for user experience  is absolutely given for apps who only login to get a specific API working!

We're also hitting this problem, would appreciate the PR getting merged and a new release!

Is there a chance this change can be merged any time soon? This is the only reason we are still using the old library version :-/

Jeez... here we are in 2022. 😓

Hey everyone. I got sick of Google's eternally beta software. It seems that this stupid two step process also caused my users to not actually being signed in correctly and caused non-authenticated daily usage limits. So I wrote this addition for Objective-C that adds the single sign-in method with scopes. Enjoy.
GIDSignIn+Scopes.zip

@jkichline Would you kindly fork this project so we can use SPM? 🙏🏻 thanks

Thanks to everyone for sharing your concerns and specific examples.
The incremental authorization pattern continues to be the recommended way to handle authorization after authentication when requesting additional scopes for specific features of your integration.
However, we understand that for certain use cases this incremental authorization approach has led to a degraded user experience with the flow requesting authorization of an additional scope being seen immediately after the user has just completed the authentication flow.
In our 6.2 release we will return the ability to request additional scopes as part of the sign-in moment for apps that require this for their core functionality.  This release will be made available in the coming weeks.

@petea Thank you so much! Around when do you think this release will be coming out?

@rldaulton the 6.2.0 release, which will address this issue, should be ready within a week.


Attempted a fix for multiple message issue

The 'receive_message' hook was being re-registered every time the messages updated. The socket buffer probably still had the previous message when being re-registered, which was triggering the multiple message bug.
I also had to fix the code a bit to get it to work. The messages were not being rendered due to some typos.


Change locking activity on inactive issues

I request that old inactive (locked for comments) issues on tidymodels ( / tidyverse) packages still accumulate links when they are referenced in new issues or PRs. That way, users perusing old closed issues will be more easily linked to the most up-to-date issue(s) on a topic. (Particularly with locks happening after just 14 days after close.)
For example tidymodels/tune#215 was closed and locked. I opened and closed tidymodels/tune#381 with the intention that a link would be added at the bottom of #215 (as I'd referenced it) for anyone trying to do something similar. Yet because #215 was locked, no link to #381 was added. (This is an imperfect example as maybe I shouldn't have created #381 as it's essentially just a comment on a closed issue -- rather than a genuine bug or feature request -- which you are trying to limit. However in most cases continuing to accumulate links on old issues to newer topics may be valuable for people searching a pakcages github issues for some problem they are facing. I wonder if there is some middle ground here that allows for linking after comments are locked and doesn't leave issues overrun and tidymodels / tidyverse team slammed with notifications.)

Ah, we can link to the locked issues and have the link show up because we are "collaborators" on each repo but other contributors or users cannot.
I don't believe there is a way to lock the issues and still allow external folks to link to it with a visible reference (I guess that is kind of the point) so maybe we should update our wording on the locked issues? I do think it may still be useful direction for folks to put in a link to something they want further addressed, even if a reference isn't autogenerated. 🤔

Posted idea for being able to lock issues and still accrue references: https://github.com/github/feedback/discussions/4850 (no response). Perhaps I just prefer being able to occasionally pollute your closed issues at my leisure 😅.
Wording is fine. Maybe could change:
"and link to this issue" to "and include a link to this issue"
(which might be more clear to user are not "linking" the issue via github's automatic cross-linking, but simply including a URL on the new issue, but probably doesn't matter either way... I could do a PR, otherwise could close.)

I think why I like the idea of allowing references on closed issues is related to the practices I try to follow regarding cross-posting:

:link: Always link to your other posts, and update everywhere with any solutions

-Rstudio Community FAQ: Is it OK to Cross-Post
(Though of course the practices for help sites may be different from those for github.)

I am very similar and like to cross-link a lot so I can easily find things later. For now, we do want to keep the lock files functioning as they are (not any great alternatives at this moment) and I think there is still value in encouraging people to add a link to something they want to see further addressed, even if there is no autogenerated, visible link created on both sides.
I do think your suggested wording is a bit better and more clear; let's at least update that here and then we can eventually get it updated on all the repos.


IPTVnator support h265 / HEVC

make it  support  h265 / HEVC

I think a solution would be to use VLC / MPV as external player - they'll play anything, and then the built-in players aren't in use.

yep, please use external players.


isInCurrentMonth inverted

I think there is a bug with item.isInCurrentMonth, days in month is returning false and not in month returning true =(

Hi, You are correct, I figured out the problem and it should be fixed in latest release.


Support for Python Poetry Projects

Python projects which use Poetry instead of pip for package management etc... are currently not supported by LicenseFinder.
Poetry projects have two files which specify dependencies:

pyproject.toml - which describes the projects metadata (name, desc, etc...) and a top level list of dependencies. This list is roughly equivalent to pip's requirements.txt file - it just lists the direct dependencies. Here's an example from a personal project.
poetry.lock - this is roughly equivalent to a yarn.lock or an npm.lock file in a JS project - it's a complete dependency graph with the whole dependency tree for the project. Here's an example from a personal project

LicenseFinder support for Poetry projects would be very good to have - Poetry is becoming more and more popular for Python projects.

I used
poetry export --without-hashes --format=requirements.txt > requirements.txt
and then
pip install -r requirements.txt
followed by
license_finder --python-version=3
to get my list. Maybe this helps someone..

Do you have any updates on this? It would be a very beneficial enhancement given the movement toward using pyproject.toml as the standard :)

It would be very useful to implement support for Poetry, many projects are moving to it.


When a snapshot test is marked with skip or skipif syrupy exits with a failure exit code

Describe the bug
If a snapshot test is skipped because it was marked with pytest.mark.skip or with pytest.mark.skipif, syrupy will:

correctly report that the related snapshots were unused; but
incorrectly report a failed test run.

To reproduce
Mark a test with pytest.mark.skip.
Expected behavior
The test run shouldn't terminate with an error.
(It's ok that the snapshots that weren't used because the tests were skipped are reported as unused, but that currently happens with a red [error] message.
It would potentially make sense to count skipped tests separately from truly unused ones...)
Screenshots

Environment (please complete the following information):

OS: MacOS Sonoma 14.0 (23A344)
Syrupy Version: tested with 3.0.9 & 4.6.0
Python Version: 3.12

Additional context
We have some snapshot tests that can only run on Python versions below 3.12, so we'd like to skip some snapshot tests if the Python version is 3.12.

You can use the --snapshot-warn-unused option to warn instead of error, resulting in an exit code of 0 (assuming all tests pass). You can make this option an automatic default when running pytest by specifying it in a pytest.ini file:
[pytest]
addopts = --snapshot-warn-unused

I do have some gripes with how snapshots interact with skipped tests. I have a test relying on an external api request whose results I snapshot. I mark this test to be skipped because I only wish to run this test occasionally to test my integration with said external api. There's a couple problems:

The problem outlined in the original issue (okay whatever, we can workaround it with --snapshot-warn-unused)
When I perform a snapshot update with --snapshot-update, because I have a snapshot corresponding to a skipped test, syrupy  deletes the snapshot, since it has been identified as "unused". Any suggested workarounds for this issue would be appreciated.

I mark this test to be skipped because I only wish to run this test occasionally to test my integration with said external API.

Maybe you can use pytest-recording to cache the response?

:tada: This issue has been resolved in version 4.6.3 :tada:
The release is available on:

v4.6.3
GitHub release

Your semantic-release bot :package::rocket: