TileMap.map_to_world() bad return value

Godot version:
v3.2.3.stable.official
OS/device including version:
Windows 10
gtx 970
GLES3
Issue description:
When TileMap is set to 'Half Offset: Offset Y', method map_to_world() seems to return bad values at negative y cells divisible by 2 (-2; -4; -6, etc.).
Here's how my debug looks like:
	if Input.is_action_just_pressed("ui_up"):
		print("Move UP")
		print("current cell: ", map_position)
		print("current cell position: ", position)
		print("target cell: ", get_neighbor_cells()["down"])
		print("target cell position: ", map.map_to_world(get_neighbor_cells()["down"]))
		position = map.map_to_world(get_neighbor_cells()["up"])

	if Input.is_action_just_pressed("ui_down"):
		print("Move DOWN")
		print("current cell: ", map_position)
		print("current cell position: ", position)
		print("target cell: ", get_neighbor_cells()["down"])
		print("target cell position: ", map.map_to_world(get_neighbor_cells()["down"]))
		position = map.map_to_world(get_neighbor_cells()["down"])`

creates output:
Move DOWN
current cell: (-2, -4)
current cell position: (-50, -87)
target cell: (-2, -3)
target cell position: (-50, -87)
Move UP
current cell: (-2, -4)
current cell position: (-50, -87)
target cell: (-2, -3)
target cell position: (-50, -87)

Steps to reproduce:
Run project attached, and do with sprite to cell -2, -4; try going up, or down (key bindings WSADQE).
Minimal reproduction project:
Strategy.zip

There are some obvious user errors in the MRP but there was indeed an issue: world_to_map(map_to_world(p)) could have returned a value different that p. For example for such code in the MRP:
var n := 4
for x in range(-n, n + 1):
	for y in range(-n, n + 1):
		var original := Vector2(x, y)
		var transformed = map.world_to_map(map.map_to_world(original))
		if transformed != original:
			print("%s -> %s" % [original, transformed])

Output in 3.2.3.stable is:

(-4, -4) -> (-4, -5)
(-4, -3) -> (-4, -4)
(-4, -2) -> (-4, -3)
(-4, -1) -> (-4, -2)
(-4, 0) -> (-4, -1)
(-4, 1) -> (-4, 0)
(-4, 2) -> (-4, 1)
(-4, 3) -> (-4, 2)
(-4, 4) -> (-4, 3)
(-2, -4) -> (-2, -5)
(-2, -3) -> (-2, -4)
(-2, -2) -> (-2, -3)
(-2, -1) -> (-2, -2)
(-2, 0) -> (-2, -1)
(-2, 1) -> (-2, 0)
(-2, 2) -> (-2, 1)
(-2, 3) -> (-2, 2)
(-2, 4) -> (-2, 3)

Output in 3.4.4.stable is empty, as expected. It was fixed in #48394.


Slider doesn't respect size when inside a ListView

The following code always fails:

class MyWidget extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return Column(
      mainAxisSize: MainAxisSize.min,
      children: [
        Container(
          width: 200,
          color: Colors.red,
          child: Slider(
            value: 0,
            onChanged: (value) {},
          ),
        ),
        ListView(
          shrinkWrap: true,
          children: [
            Container(
              width: 200,
              color: Colors.red,
              child: Slider(
                value: 0,
                onChanged: (value) {},
              ),
            ),
          ],
        ),
      ],
    );
  }
}

Tested on both DartPad (1.23.0-18.1.pre) and locally (1.24.0-7.0.pre.40).
This can be fixed by using Center(child: Container(child: Slider(...)))), similar to how CircularProgressIndicator works. However, there is no mention anywhere. I feel this is unintuitive and would love to see Slider following the logic.

It seems this affects every view inside a ListView. So weird.


fix(connect): fix createDataFrame for string types

#3601  👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.


Web - LHN - The fab button becomes highlighted in blue

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Go to URL https://staging.new.expensify.com/
Login with any account
Click on the green plus button in the LHN and select New Room
Зress the Esc key on the keyboard

Expected Result:
The fab button should not be highlighted in blue
Actual Result:
The fab button becomes highlighted in blue
Workaround:
Unknown
Platform:

Where is this issue occurring?

Web

Version Number: <IP_ADDRESS>
Reproducible in staging?: Yes
Reproducible in production?: Yes
Email or phone of affected tester (no customers): any
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://user-images.githubusercontent.com/93399543/187993534-d72d46fb-bb01-4de0-9850-5e4ab96520cf.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub

asked about this in our internal slack here https://expensify.slack.com/archives/C02HWMSMZEC/p1662109135616809 will update once we get some more confirmation.

still working on resolving this convo in the thread

dropping this down to weekly since it doesn't seem that pressing and we haven't really come to a conclusion in the thread.

I think we can close this out


Uri: Complete missing hashCode documentation.

The documentation comment for the Uri hashCode property is incomplete.
Complete the description of the hashCode property.

Thank you for all things dart-lang. Please let me know if you would prefer this PR on a different branch besides dev, or if I should use the formal patch workflow.
(Doing this as a PR demo for students, getting started in open source contributions by fixing documentation.)

I think this sounds okay...

Thanks for your contribution!
Please do rebase your change on the master branch. We are unable to merge this until it is based on master. Our PR automation looks for the merge base on the master branch, where it can't find it. We also do not land changes directly on the dev branch, but merge from master to dev every 4 hours.

Hmm, I noticed you also created #44363. Both of these PRs use the wrong base branch (dev instead of master). On this PR, I tried changing that but that confuses GitHub. Perhaps, the easiest would be to change the base branch on #44363, which I can't do myself (perhaps because the PR is closed).

I changed the base for the PR. That does cause a lot of noise, but the actual change looks OK.

I tried just hanging the base for the PR directly in github. Didn;'t work for me.

Yes, I did the same and it also didn't work for me. But it may work on #44363.

Yikes, rebasing onto master created a mess on my end - I likely made a mistake. Please see #44371 which is a PR of a feature branch off of master, and this PR is for a merge into master.
/cc @kevmoo @athomas @lrhn @kwalrath


animated-tabbar is not working with Drawer Navigator

Find below my Navigator
working Fine on IOS  but in android Tab is not working ,
but when i change createDrawerNavigator to createStackNavigator it will work like a charm
Thanks in Advance
// Root Navigatorts
const RootNavigator = createDrawerNavigator(
{
Home: {
screen: TabNavigator,
},
Profile: {
screen: Profile,
},
},
{
contentComponent: drawerContentComponents,
drawerBackgroundColor:'#FAFAFA',
// drawerWidth:Dimensions.get('window').width,
}
);
const TabNavigator = createBottomTabNavigator(
{
Explore: Explore,
Gallery: Gallery,
Membership: Explore,
Shop: Gallery,
},
{
tabBarComponent: props => <AnimatedTabBar tabs={tabs}  {...props} />,
},
);

Hi @graphtobinary would you please update the issue and follow the reporting bug template so i could help you ? thanks


bunny vs python version of rabix

Hi,
Just confused by bunny project. My understranding rabix is implemented in python for CWL specification. Why there is a bunny of java version under rabix? What's the value of bunny while there is already a more matured python version. It looks to me that python version should be continued and now almost dead. Will python version be deprecated and replaced by bunny?

Hi,

Will python version be deprecated and replaced by bunny?

Yes. The CWL specification is still going through iterations, and we wanted to have the ability to run all versions of CWL and combine different versions in a single workflow (which is what bunny can do).
We chose Java partly because the reference implementation is in Python and it would benefit the CWL community to have implementations in multiple languages.


Agree button should match web functionality

The agree button in the ActivityItem component should have the same functionality as on the web. Right now, it appears on multiple activity items with the same taxon id, as well as maverick observations.
The screenshot below should show the agree button in the same activity items as the same observation on the web. In this case, the agree button should only show for the Green Iguana suggested by @chia.

@angielt are you still working on this? FWIW, I can still replicate this in v0.17.1+64


Getting error on sphelper.min.js:1

Uncaught ReferenceError: exports is not defined,     at spHelper.min.js:1
Uncaught TypeError: SP.ClientContext is not a constructor  at e.value (spHelper-stand-alone.min.js:1)
//here is my sample code
function  FnInit(){
// Initialize spHelper
var  dataConnection  =  new  spHelper({
crossDomain  :  false,
targetSite  :  'https://mytanent.sharepoint.com/sites/SiteColname'
});
// Create the callback function that will be executed after the request is completed successfully.
	var  onSuccess  =  function (results){
	console.log('New customer added!');
	}

	// Create the callback function that will be executed if the request fails.
	var  onFailure  =  function (errorMessage){
	console.log('An error has occured!  '  +  errorMessage);
	}

	var  itemDetails  = {listName  :  'SSRequests', columnData  :{Title  :{Type  :  'Text',Value  :  'Hello.'}}};

	// Perform the spHelper request and send your callback functions.
	dataConnection.addListItem(itemDetails, onSuccess, onFailure);

}
SP.SOD.executeFunc("clienttemplates.js", "clienttemplates", FnInit);

Need a bit more information:

What version of SharePoint?
How are you implementing spHelper? .. Add-in? Master Page? Script Editor? Context Editor?
Did you load the SharePoint includes before spHelper?

Paste your full code with the above answers and I'll do my best to help.

Hi James
Thank for you your reply.
What version of SharePoint?  i used Sharepoint online team site.
How are you implementing spHelper? .. Add-in? Master Page? Script Editor? Context Editor?
Add in, i add javascript references in a site page. (i used webpart page)
here is the references i added in the site page.
<asp:Content ContentPlaceHolderId="PlaceHolderMain" runat="server">

</asp:Content>
Did you load the SharePoint includes before spHelper?
Not sure - as you mentioned in your sample code.  see the answer to the 2nd question.
Paste your full code with the above answers and I'll do my best to help.
i have two pages.
1)a aspx page created in sitepages library .
2) a javascript file called  "dashboard-sphelper.js" which is uploaded to sitesassets/JS location.
in the javascript file,  i have the following script to add a list item to the splist  called "SSrequests".
my understanding is to call this FnInit() function in the page_load.
Please help me here.. thanks in advance.
function  FnInit(){
// Initialize spHelper
var  dataConnection  =  new  spHelper({
crossDomain  :  false,
targetSite  :  'https://smeeztech.sharepoint.com/sites/sysService'
});
// Create the callback function that will be executed after the request is completed successfully.
	var  onSuccess  =  function (results){
	alert('New customer added!');
	}

	// Create the callback function that will be executed if the request fails.
	var  onFailure  =  function (errorMessage){
	alert('An error has occured!  '  +  errorMessage);
	}

	var  itemDetails  = {listName  :  'SSRequests', columnData  :{Title  :{Type  :  'Text',Value  :  'Hello.'}}};

	// Perform the spHelper request and send your callback functions.
	dataConnection.addListItem(itemDetails, onSuccess, onFailure);

}
SP.SOD.executeFunc("clienttemplates.js", "clienttemplates", FnInit);

Thank you for the followup information. The order of your loaded scripts is very important. You must load the SharePoint required scripts before spHelper. You are also loading spHelper twice. The order of your loads should look more like this:
<asp:Content ContentPlaceHolderId="PlaceHolderMain" runat="server">
  <script  type="text/javascript" src="https://mytanent.sharepoint.com/sites/sysService/_layouts/15/MicrosoftAjax.js"></script>
  <script  type="text/javascript" src="https://mytanent.sharepoint.com/sites/sysService/_layouts/15/SP.Runtime.js"></script>
  <script  type="text/javascript" src="https://mytanent.sharepoint.com/sites/sysService/_layouts/15/SP.UserProfiles.js"></script>
  <script type="text/javascript" src="https://mytanent.sharepoint.com/sites/sysService/SiteAssets/JS/spHelper-stand-alone-min.js"></script>
  <script type="text/javascript" src="https://mytanent.sharepoint.com/sites/sysService/SiteAssets/JS/dashboard-sphelper.js" ></script>
</asp:Content>

The Microsoft files (MicrosoftAjax/Runntime/UserProfile) are actually loaded by default via the master page. However this forces them to be loaded before spHelper. If they are loaded after, you will receive errors.
Your dashboard-sphelper.js should look something like this:
function FnInit()
{
	// Initialize spHelper
	var dataConnection = new spHelper({
		crossDomain : false,
		targetSite : 'https://mytenant.sharepoint.com/sites/sysService'
	)};

	var  onSuccess  =  function (results){
	alert('New customer added!');
	}

	// Create the callback function that will be executed if the request fails.
	var  onFailure  =  function (errorMessage){
	alert('An error has occured!  '  +  errorMessage);
	}

	var  itemDetails  = {listName  :  'SSRequests', columnData  :{Title  :{Type  :  'Text',Value  :  'Hello.'}}};

	// Perform the spHelper request and send your callback functions.
	dataConnection.addListItem(itemDetails, onSuccess, onFailure);
});

SP.SOD.executeFunc("clienttemplates.js", "SPClientTemplates", FnInit);

Your FnInit function should contain ALL your application / request logic.


create-an-azure-ad-test-user <- update required

The section that describes the creation of the testuser "B.Siomon" (https://learn.microsoft.com/en-us/azure/active-directory/saas-apps/aws-single-sign-on-tutorial#create-an-azure-ad-test-user) does not match the fields I see in the properties section, when creating the new user within Azure AD.
Here is a list of the fields displayed:
Identity
First name
Last name
User type
Job Information
Job title
Company name
Department
Employee ID
Employee type
Employee hire date
Office location
Manager
Contact Information
Street address
City
State or province
ZIP or postal code
Country or region
Business phone
Mobile phone
Email
Other emails
Fax number
Parental controls
Age group
Consent provided for minor
Settings
Usage location

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: f8e131bf-99d7-a850-a597-ac02b9f6c3a9
Version Independent ID: a27625d3-cf35-ffaf-5734-d1a2bbcdd60c
Content: Tutorial: Azure AD SSO integration with AWS IAM Identity Center (successor to AWS Single Sign-On) - Microsoft Entra
Content Source: articles/active-directory/saas-apps/aws-single-sign-on-tutorial.md
Service: active-directory
Sub-service: saas-app-tutorial
GitHub Login: @jeevansd
Microsoft Alias: jeedes

@v-pugoe and @v-hagamp Can you please make these changes?

@andrelohmann
Thanks for bringing this to our attention.
I'm going to assign this to the document author so they can take a look at it accordingly.

@andrelohmann, we're updating the document with latest UI of Azure.
#please-close


unexpected EOF

I quite often use the functionality associated with importing and exporting a dataset, I used this functionality sometimes once a month, and sometimes more often, but yesterday I encountered the following problem: when I try to import a dataset, I get a strange “unexpected EOF” error. This error is reproduced for me on different versions of node, different operating systems, as well as on different versions of this package, the process always breaks at 4%, once when I asked a colleague to reproduce, his process stopped at 5%. I would really appreciate it if you could provide any recommendations on how to fix this.

I also tried to run import on a completely empty dataset, but I got the same error.


Added init.py

Importing nexar_token.py from another script outside this directory currently causes a relative import failure on from local_service import handlerFactory. This addition of __init__.py adds the directory to the system path, allowing the relative import to work as expected. Tested with print_token.py from this directory, and with from nexar_token_py.nexar_token import get_token in a script from a parent directory.

Error message when trying to import without this change:
Traceback (most recent call last):
  File "/Users/andrew/Workspace/testing/folder_permissions.py", line 5, in <module>
    from nexar_token_py.nexar_token import get_token
  File "/Users/andrew/Workspace/testing/nexar_token_py/nexar_token.py", line 11, in <module>
    from local_service import handlerFactory
ModuleNotFoundError: No module named 'local_service'

Discussed with Andrew, and this seems to be the cleanest solution for now.
We tried changing from local_service import handlerFactory to from .local_service import handlerFactory in nexar_token.py and that fixed the issue, but it also broke the print_token.py script. Python doesn't seem to like scripts and modules living in the same directory.
Another thing we tried was installing nexar_token_py as editable, but that needed a setup.py or pyproject.toml file which is a bit more work than I'd hoped for. I tried making a skeleton pyproject.toml file but encountered issues, again to do with nexar_token_py having scripts and modules in the same directory. I've made projects using poetry before which streamlines the process, and that always seems to make a subfolder for all the library files.
On balance, let's go with Andrew's solution of explicitly modifying sys.path in time for the demo tomorrow, and we can revisit our approach later.


What should we show as transactions ?

Description:

On governance we're not displaying Voting transactions because they don't involve a transfer of funds besides of the use of Gas. Same happens with redelegations, as delegation amounts are moved from one validator to another (ie. unbonding-delegation from source validator + delegation to dst validator) but the user doesn't input any amount.
Should we include all transactions that involve gas on the Tx history page ?

yes 👍

Decided


question

Pre-requisites:

[ *] Yes, I looked through both open and closed issues looking for what I needed
[ *] No, I did not find what I was looking for

Nice work guys - question how did you pull off the green bottom aligned toast in the animated gif example exactly? Would love to see an example.

You can have a look at the CustomizedToastWithoutToastViewExample in AdvancedExamples.swift in ToastUISample for more detail. Here's how that view is laid out.
struct ContentView: View {
  var text: String

  var body: some View {
    VStack {
      Spacer()
      Text(text)
        .bold()
        .foregroundColor(.white)
        .padding()
        .background(Color.green)
        .cornerRadius(8.0)
        .shadow(radius: 4)
        .padding()
    }
  }
}

VStack is already vertically centered and padded by default. You need to add a Spacer to push the view downward.

You can have a look at the CustomizedToastWithoutToastViewExample in AdvancedExamples.swift in ToastUISample for more detail. Here's the snippet of that example describing the view.
struct ContentView: View {
  var text: String

  var body: some View {
    VStack {
      Spacer()
      Text(text)
        .bold()
        .foregroundColor(.white)
        .padding()
        .background(Color.green)
        .cornerRadius(8.0)
        .shadow(radius: 4)
        .padding()
    }
  }
}

VStack is already vertically centered and padded by default, then a Spacer is used to push the view downward.

Ack missed the AdvnacedExamples - apologies, and thanks for the response. Nice work again.


Remove compatibility with old ethabi parsing

Solc v0.6 introduced receive function type. With ethabi 14.0, this type is finally supported, so we can implement receive method and drop compatibility layer from our parser.

Note: there's a report that the issue is not fixed, but I wasn't able to confirm it.

Solc changelog says:

The unnamed function commonly referred to as “fallback function” was split up into a new fallback function that is defined using the fallback keyword and a receive ether function defined using the receive keyword.

If present, the receive ether function is called whenever the call data is empty (whether or not ether is received). This function is implicitly payable.
The new fallback function is called when no other function matches (if the receive ether function does not exist then this includes calls with empty call data). You can make this function payable or not. If it is not payable then transactions not matching any other function which send value will revert. You should only need to implement the new fallback function if you are following an upgrade or proxy pattern.

From what I understand, on our side we're just sending a call with empty call data, the node will figure out which method should be called. Is this correct? If so, do we maybe want to rename this method in our API? Or replace it with receive method that doesn't accept any arguments? Or create a separate receive method whilst leaving fallback method as it is?

Is this correct?

fallback and receive functions both accept calldata. The SC bytecode looks at the first 4 bytes of the calldata and uses it to determine which function to jump to when its executing. If the 4 bytes are either not there or don't match any known function, then the SC will jump to the fallback function if the value (the amount of Ether being transferred) is 0 and to the receive function otherwise.

If so, do we maybe want to rename this method in our API?

Hmm, the issue is that to actually call the receive function you need to specify a non-0 value, otherwise it will call the fallback function. Since we don't differentiate between payable and non-payable functions, I think its fine to conflate receive and fallback together. If we really want to support receive, then we would need a separate receive function that takes a non-0 value input, otherwise it would just never get called.

Super happy to get rid of that hacky code!

If the 4 bytes are either not there or don't match any known function, then the SC will jump to the fallback function if the value (the amount of Ether being transferred) is 0 and to the receive function otherwise.

Hmm, solc doc specifically mentions this: If present, the receive ether function is called whenever the call data is empty (whether or not ether is received).

I wonder if we really need fallback function. It feels like receive will cover all use cases.

Ah I see, receive is called on empty calldata, while fallback accepts arbitrary calldata when the selector (first 4 bytes) doesn't match one of the expected functions.

So, do we want to rename anything, or do I merge this PR?

I think its fine for now to conflate fallback with receive for now.


Distant Horizons Bug

When Distant Horizons renders leaves for dynamic trees they do not render, it seems that only the root leaves (right above the tree trunk).
Picture using render distance of 2:

this has been fixed


⚠ Bofrost.be has degraded performance

In 8ed0160, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1144 ms

Resolved: Bofrost.be performance has improved in 2d7483b.


Revert "Switch back guaranteed producer"

This reverts commit 41527f81c837d80c80204fe9d4f278e335849da2 / PR #153

cc @wikimedia/services

Coverage decreased (-4.3%) to 86.076% when pulling ba5fb7cde564caddce43bfcdeb7f5cdcca34c0ce on d00rman:revert-guaranteed into acb84e377965fa4386fdfe2522d3f0f6b355dd6e on wikimedia:master.

Coverage decreased (-4.3%) to 86.076% when pulling ba5fb7cde564caddce43bfcdeb7f5cdcca34c0ce on d00rman:revert-guaranteed into acb84e377965fa4386fdfe2522d3f0f6b355dd6e on wikimedia:master.

Coverage decreased (-4.3%) to 86.076% when pulling ba5fb7cde564caddce43bfcdeb7f5cdcca34c0ce on d00rman:revert-guaranteed into acb84e377965fa4386fdfe2522d3f0f6b355dd6e on wikimedia:master.


Does not pull down tabbed adventures

I need to import "Turn of fortunes wheel"  https://www.dndbeyond.com/sources/paitm/tofw
However when importing planescape it only imports the intro. https://www.dndbeyond.com/sources/paitm

They import for me.
Try clearing your downloaded info in Adventure Muncher and try again.


Unsafe reflection in java (CWE-470)

This PR contains query for unsafe reflection in java.
Developer sometimes refactor code by using reflection. By doing so application could open up to this vulnerability. And reflection can only be used only from trusted sources such as white-listing or hard-coded string.
This query detects the following function
Class.forName(user_input)

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thank you for your submission. We have discussed this query with our team of security researchers, and based on their feedback we are unfortunately unable to accept this query. The concern is that this query is likely to result in a high false positive rate, and therefore does not meet our requirements for inclusion in our default query set.

Ah, I didn't realize that this used 'LocalUserInput`:
https://github.com/Semmle/ql/blob/8140b68f15d1ba3e105972edc30125bf40a6c1ea/java/ql/src/semmle/code/java/dataflow/FlowSources.qll#L156
Is there already a check for this from remote flow data?
I do agree with @yo-h's opinion here. Way too many server applications use locally configured class names to define how their applications startup and behave. To flag this as a security vulnerability would significantly increase the false-positive rate.


Switch folder structure from x.x.x to x.x

I noticed most (not sure if all) of the official docker images are using a simplified folder structure. They only take the major.minor version and map that to a folder name. When the major.minor.patch is updated that gets reflected in the dockerfile but if the major.minor didn't change the folder name wouldn't.
Is this something we wanted to take a look at? Here are some examples showing all the tags still existing but folder structure a bit simplified in the repo:
Solr
https://github.com/docker-solr/docker-solr
https://hub.docker.com/r/library/solr/tags/
Postgres
https://github.com/docker-library/postgres
https://hub.docker.com/r/library/postgres/tags/
Node
https://github.com/nodejs/docker-node
https://hub.docker.com/r/library/postgres/tags/
I for sure might be missing something but thought would start discussion :)

@sylus you at the drupalcon by any chance?

Suggesting dropping the PATCH support? Just doing the latest patch from any MAJOR.MINOR pair?

@pirog sorry I wasn't able to make it to DrupalCon this year! Feel free to reach out to me however through email / slack and what not ^_^
@RobLoach yeah that is what I am thinking, I'll try to get a P.R. going within a couple of days. ^_^

Nevermind already done, thanks you so much! I'll add a small pr to update the update.sh script since now using x.x not x.x.x


Allow setting random state for generators

Todo: pass RandomState to all functions using randomness
Use sklearn.utils.check_random_state for this.

This is done.


ChoiceBoxElement using generic types: There was an attempt

I converted ChoiceBoxElement to support generic types... maybe. I have near no idea what I am doing, so I need you, Eric, to fix my stuff. Thanks in advance.
In ChoiceBoxElement there are various warnings about unchecked calls, and in GuiUtils the methods for creating a choicebox may need some work as well. To get around an issue I thought I had I made a new interface similar to ClickHandler or Callback to execute some usage-defined code like book.getTitle() to return a list of Strings from the Key set of IBooks inside the map. It's a bit of a mess. The goal of it is to take a Map of any object and display an observablelist of Strings to select from.

The class actually seems to function normally, will need to wait and see if eric's implementation will break it.


Add apache_vhosts_ssl to hosts file as well when using vagrant-hostsupdater

Issue Type

Feature Idea

Your Environment
Vagrant 1.8.7
VirtualBox 5.1.30r118389
ansible <IP_ADDRESS>
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/home/my-username/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/lib/python2.7/dist-packages/ansible
  executable location = /usr/bin/ansible
  python version = 2.7.12 (default, Nov 19 2016, 06:48:10) [GCC 5.4.0 20160609]

Your OS

Linux (Ubuntu 16.04)

Summary
I'm starting to work more and more with local SSL-enabled sites in DrupalVM. However when I do a vagrant up, and my sites are being added to my hosts file by means of vagrant-hostsupdater, the SSL-enabled sites are unfortunately left out. I.e I have to manually add them to my hosts file.
I did a little digging in lib/drupalvm/vagrant.rb, and adding something like
aliases += get_apache_vhosts(vconfig.fetch('apache_vhosts_ssl', vconfig['apache_vhosts_ssl']))

into the get_vhost_aliases function seems to fix it for now. However, I'm a complete Ruby noob :), so I have no clue if this is a 'Ruby correct way' of doing this and whether this covers all edge-cases. Also, perhaps more importantly, if you're willing to consider to add this feature.

@sidneygijzen I'd recommend putting the domain in both apache_vhosts and apache_vhosts_ssl this way the domain will still respond on port 80 (http) then you can set an htaccess redirect to 443 (https) for SSL.

@thom8 That is a great suggestion. Thanks! That indeed solves it.

@sidneygijzen - Yeah, I think I'll close this as a won't fix, and recommend the same fix for anyone else who needs 443 domains to show up in the hosts file.
Also, for Nginx, since it's one vhosts list (instead of separate)... it would make it more weird/difficult to support for convenience.


Added CSS: Animations deck

Adding QA questions for "CSS: Animations" deck based on the following source: https://css-tricks.com/almanac/properties/a/animation/
It addresses this issue:
https://github.com/papistan/FrontEndTrivia/issues/55

@alfredlucero thank you! Great set of questions

No problem glad to help :)


When will Azure event hub schema registry be ready for production?

Query/Question
Hi.
We are considering using Azure event hub in a new system we are currently building, but we are a little concerned about schema registry still being in preview.
Could you provide guidance on when schema registry is expected to be ready for production?
Best regards,
Casper
Why is this not a Bug or a feature Request?
It is a timeline question.
Information Checklist
Kindly make sure that you have added all the following information above and checkoff the required fields otherwise we will treat the issuer as an incomplete report

[x] Query Added
[x] Setup information Added

@alzimmermsft Any update on this?
Apart from information on the roadmap towards production quality, we are also interested in when relevant tooling will become available. It is very inconvenient that schema registry is only accessible from the portal, since it makes it hard to include in an automated pipeline. Any plans for supporting schema registry resource management from ARM templates or using the AZ cli?

@alzimmermsft Any update on this?
Apart from information on the roadmap towards production quality, we are also interested in when relevant tooling will become available. It is very inconvenient that schema registry is only accessible from the portal, since it makes it hard to include in an automated pipeline. Any plans for supporting schema registry resource management from ARM templates or using the AZ cli?

@arerlend could you update this with the latest information?

@sjkwak

@alzimmermsft @arerlend @sjkwak
Any update on this?
Cheers,
Casper

@casper-79
The Schema Registry service and the client library to access it azure-data-schemaregistry are both out of preview.
We are still working on the azure-data-schemaregistry-avro package that provides the avro serializer that uses Schema Registry. We plan to move this package out of this preview by the end of this semester.


Nav active state is lost when opening another nav section

When on a page and opening another section the active state should stay active for the page you are on.
https://user-images.githubusercontent.com/2753488/192604864-a3034d22-4276-4d80-b8a5-d14a3b27c731.mov

Hey team! Please add your planning poker estimate with Zenhub @andreancardona @francinelucca @jdharvey-ibm


 It seems like something has changed in the EC and/or js-sdk for that matter. Previously Unpublish was immediately followed by Publish, that's why it worked about a week ago or so, but apparently something changed.
Anyway, I decided to "fix" it by treating Unpublish as Publish (as they are identical in this regard?). This seems to fix the issue.


Plugin cannot handle filename case changes

When a file is renamed in a way that changes case (e.g. components/foo.jsx to components/Foo.jsx), the plugin never stops caching the previous file's pathname. Even after reloading the window or restarting VSCode, it still reports false-negatives on the file (e.g.Filename 'foo' must match the exported and transformed name 'Foo'. for the filenames/match-exported rule). The ESLint CLI doesn't report any issues.

@vdh can you please provide me with a GitHub repository I can clone that demos what you are experiencing. This ensure I test it with the same setup. This might be a problem with VS Code itself. I don't know if VS Code changes the URI on case insensitive file systems in that case.

Here's a minimal reproduction I was able to make: https://github.com/vdh/rename-issue-test
If the problem doesn't appear in VSCode after a clone and npm install, you might have to check out the previous commit (8842e4008dde82ad1b1ad566e27c5ea5cbf27122), open the file in VSCode, then check out the rename commit (95ad5f537a468cebf4ec878c047fd528048a4abd).
For context I'm currently on macOS Catalina 10.15.7 and VSCode 1.51.1, since it may be related to VSCode or the file system.

@vdh thanks for the repository. How do you do the rename.   Can you please add some steps.

I think this might be an issue with VSCode and case-insensitive file systems (WSL emulates Linux which is case-sensitive, so you probably didn't encounter it).
This issue looks like it might be what I'm experiencing, based on the similar misbehaving tabs, and something bad being cached somewhere inside the workspaceStorage folder: https://github.com/microsoft/vscode/issues/102627 It's unfortunate that they seem to have closed it though.
Since this looks more like a VSCode bug than an issue with this extension, I'll close this issue.

Let me test this on Windows then.

Reopening...


restore 10000 for jruby max-requests-per-instance

Given https://tickets.puppetlabs.com/browse/SERVER-1154 is now resolved, we can restore the 10,000 value for jruby max-requests-per-instance. This is the default that is installed in 2016.2, too.

@jessereynolds 10K is the default so I'd say we should just remove the setting from hiera altogether.

https://github.com/puppetlabs/control-repo/commit/5497d199b3c851a317638905e77f44f2fafc64d4


Common navbar links for all themed sites

We need to devise a way of specifying a common set of navbar links for all Pythia sites that use the Sphinx Pythia Theme.  The idea would be that the URLs for links in the top navbar of the Sphinx sites would all be the same, across all sites (i.e., GitHub Pages sites).
Without this feature, going to another Pythia site, even though it might use the same Sphinx Pythia Theme, the top navbar would change and there would no-longer be a common element that links all of the sites together.  And, unless I am mistaken, I think the element that should link all of the sites together is the top navbar.

There is a basic was of doing this in the new theme, by setting the conf.py options:
html_theme_options = {
    'nav_bar': {
        'Link A':  'URL',
        'Link B':  'URL',
        'Link C':  'URL',
    },
}

However, there is no guarantee that each conf.py has the same html_theme_options.

Our current solution works well and isn't too complicated.


Microsoft 365 'Business Premium' (previosly M365 Business)

This page could really use some info for the M365-SMB focussed products. Slightly touched on via O365 Business Premium (although this naming is now out of date).
Please provide updated licensing info that includes an overview of MFA availability on the SMB product lines (M365 Business Premium, Standard).
Side note: The documentation in general really needs better differentiation/info for SMB vs Enterprise. The bulk of the docs focus solely on Enterprise and either ignore SMB or barely touch on it. It really makes it harder than needed to find/implement security features on the SMB side of your product lines.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: feb03e63-f543-d85b-9daf-16b4d1e13a60
Version Independent ID: da9dcdd2-70d4-e08e-18f2-6e6a1489937a
Content: Azure Multi-Factor Authentication versions and consumption plans
Content Source: articles/active-directory/authentication/concept-mfa-licensing.md
Service: active-directory
Sub-service: authentication
GitHub Login: @iainfoulds
Microsoft Alias: iainfou

@netresults-scott Thanks for the feedback !  I have assigned this issue to content author to investigate and update the document as appropriate.

Thanks for the feedback, @netresults-scott
For the most part, the Azure AD docs are trying to just focus on the available Azure AD features such as Multi-Factor Authentication, not get into specific licensing comparisons or differences across M365, EMS, Office 365, etc. The focus isn't so much on Enterprise vs SMB, rather the core underlying features of Azure AD.
The separate M365 docs provide some different breakdowns in content - https://docs.microsoft.com/microsoft-365/?view=o365-worldwide. There's still not a specific section for SMB though, I know.
I'll relay the feedback to colleagues in M365 and licensing / pricing pages such as https://www.microsoft.com/microsoft-365/business to try and help provide some more clarity and better SMB picture.
For now, there's no immediate doc here #please-close


Super cool :)

I'm really excited that you found my little project useful :)

My pleasure, thanks for css-layout!


HADOOP-18797.  Support Concurrent Writes With S3A Magic Committer

Jobs which commit their work to S3 through
magic committer now use a unique magic
containing the job ID:
__magic_job-${jobid}
This allows for multiple jobs to write
to the same destination simultaneously.
Contributed by Syed Shameerur Rahman

Description of PR
How was this patch tested?
For code changes:

[ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

FYI: @steveloughran

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
7m  9s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 11 new or modified test files.

_ branch-3.3 Compile Tests _

-1 :x:
mvninstall
46m 43s
/branch-mvninstall-root.txt
root in branch-3.3 failed.

+1 :green_heart:
compile
0m 42s

branch-3.3 passed

+1 :green_heart:
checkstyle
0m 36s

branch-3.3 passed

+1 :green_heart:
mvnsite
0m 51s

branch-3.3 passed

+1 :green_heart:
javadoc
0m 41s

branch-3.3 passed

+1 :green_heart:
spotbugs
1m 17s

branch-3.3 passed

-1 :x:
shadedclient
37m 13s

branch has errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 41s

the patch passed

+1 :green_heart:
compile
0m 33s

the patch passed

+1 :green_heart:
javac
0m 33s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 22s
/results-checkstyle-hadoop-tools_hadoop-aws.txt
hadoop-tools/hadoop-aws: The patch generated 1 new + 10 unchanged - 0 fixed = 11 total (was 10)

+1 :green_heart:
mvnsite
0m 37s

the patch passed

+1 :green_heart:
javadoc
0m 27s

the patch passed

+1 :green_heart:
spotbugs
1m 11s

the patch passed

-1 :x:
shadedclient
37m  6s

patch has errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 46s

hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 40s

The patch does not generate ASF License warnings.

143m 18s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6122/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6122

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets markdownlint

uname
Linux d6b81cc3fc00 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
branch-3.3 / 8f131180ff67d2a89ccbc3d012ebb400d386c5fe

Default Java
Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~18.04-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6122/1/testReport/

Max. process+thread count
556 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6122/1/console

versions
git=2.17.1 maven=3.6.0 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
11m 47s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 11 new or modified test files.

_ branch-3.3 Compile Tests _

+1 :green_heart:
mvninstall
49m 48s

branch-3.3 passed

+1 :green_heart:
compile
0m 39s

branch-3.3 passed

+1 :green_heart:
checkstyle
0m 32s

branch-3.3 passed

+1 :green_heart:
mvnsite
0m 51s

branch-3.3 passed

+1 :green_heart:
javadoc
0m 38s

branch-3.3 passed

+1 :green_heart:
spotbugs
1m 14s

branch-3.3 passed

+1 :green_heart:
shadedclient
37m 37s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 40s

the patch passed

+1 :green_heart:
compile
0m 32s

the patch passed

+1 :green_heart:
javac
0m 32s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 22s
/results-checkstyle-hadoop-tools_hadoop-aws.txt
hadoop-tools/hadoop-aws: The patch generated 1 new + 10 unchanged - 0 fixed = 11 total (was 10)

+1 :green_heart:
mvnsite
0m 38s

the patch passed

+1 :green_heart:
javadoc
0m 27s

the patch passed

+1 :green_heart:
spotbugs
1m  9s

the patch passed

+1 :green_heart:
shadedclient
36m 31s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 43s

hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 39s

The patch does not generate ASF License warnings.

150m 55s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6122/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6122

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets markdownlint

uname
Linux 32b24fe9347a 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
branch-3.3 / 8f131180ff67d2a89ccbc3d012ebb400d386c5fe

Default Java
Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~18.04-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6122/1/testReport/

Max. process+thread count
726 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6122/1/console

versions
git=2.17.1 maven=3.6.0 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

looks good and I'm not going to review backports except for backporting issues.
which s3 region did you test against, and with what parameters?

looks good and I'm not going to review backports except for backporting issues.
which s3 region did you test against, and with what parameters?

How was this patch tested?
1. Ran S3A Unit Tests

2. Ran S3A Integration test in us-west-1 region

[INFO] Running org.apache.hadoop.fs.s3a.commit.staging.TestDirectoryCommitterScale [INFO] Running org.apache.hadoop.fs.s3a.commit.staging.TestPaths [INFO] Running org.apache.hadoop.fs.s3a.commit.TestMagicCommitPaths [INFO] Running org.apache.hadoop.fs.s3a.commit.staging.TestStagingCommitter [INFO] Running org.apache.hadoop.fs.s3a.commit.staging.TestStagingPartitionedFileListing [INFO] Running org.apache.hadoop.fs.s3a.commit.staging.TestStagingDirectoryOutputCommitter [INFO] Running org.apache.hadoop.fs.s3a.commit.staging.TestStagingPartitionedJobCommit [INFO] Running org.apache.hadoop.fs.s3a.commit.staging.TestStagingPartitionedTaskCommit [INFO] Tests run: 28, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.473 s - in org.apache.hadoop.fs.s3a.commit.TestMagicCommitPaths [INFO] Tests run: 14, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.611 s - in org.apache.hadoop.fs.s3a.commit.staging.TestPaths [INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 20.965 s - in org.apache.hadoop.fs.s3a.commit.staging.TestStagingDirectoryOutputCommitter [INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 23.474 s - in org.apache.hadoop.fs.s3a.commit.staging.TestStagingPartitionedFileListing [INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 27.627 s - in org.apache.hadoop.fs.s3a.commit.staging.TestStagingPartitionedJobCommit [INFO] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 29.249 s - in org.apache.hadoop.fs.s3a.commit.staging.TestStagingPartitionedTaskCommit [INFO] Tests run: 63, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 61.11 s - in org.apache.hadoop.fs.s3a.commit.staging.TestStagingCommitter [INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 84.193 s - in org.apache.hadoop.fs.s3a.commit.staging.TestDirectoryCommitterScale [INFO] Running org.apache.hadoop.fs.s3a.commit.staging.integration.ITestStagingCommitProtocol [INFO] Running org.apache.hadoop.fs.s3a.commit.staging.integration.ITestDirectoryCommitProtocol [INFO] Running org.apache.hadoop.fs.s3a.commit.staging.integration.ITestPartitionedCommitProtocol [INFO] Running org.apache.hadoop.fs.s3a.commit.staging.integration.ITestStagingCommitProtocolFailure [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 5.901 s - in  .hadoop.fs.s3a.commit.staging.integration.ITestStagingCommitProtocolFailure [INFO] Running org.apache.hadoop.fs.s3a.commit.magic.ITestMagicCommitProtocol [INFO] Running org.apache.hadoop.fs.s3a.commit.magic.ITestMagicCommitProtocolFailure [INFO] Running org.apache.hadoop.fs.s3a.commit.integration.ITestS3ACommitterMRJob [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 6.225 s - in org.apache.hadoop.fs.s3a.commit.magic.ITestMagicCommitProtocolFailure [INFO] Running org.apache.hadoop.fs.s3a.commit.ITestS3ACommitterFactory [INFO] Running org.apache.hadoop.fs.s3a.commit.ITestCommitOperations [INFO] Running org.apache.hadoop.fs.s3a.commit.ITestCommitOperationCost [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 7.05 s - in org.apache.hadoop.fs.s3a.commit.ITestS3ACommitterFactory [INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 43.398 s - in org.apache.hadoop.fs.s3a.commit.ITestCommitOperationCost [INFO] Tests run: 18, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 143.308 s - in org.apache.hadoop.fs.s3a.commit.ITestCommitOperations [INFO] Running org.apache.hadoop.fs.s3a.auth.ITestAssumedRoleCommitOperations [INFO] Tests run: 12, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 218.466 s - in org.apache.hadoop.fs.s3a.commit.integration.ITestS3ACommitterMRJob [WARNING] Tests run: 18, Failures: 0, Errors: 0, Skipped: 18, Time elapsed: 62.036 s - in org.apache.hadoop.fs.s3a.auth.ITestAssumedRoleCommitOperations [WARNING] Tests run: 24, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 429.367 s - in  .hadoop.fs.s3a.commit.staging.integration.ITestPartitionedCommitProtocol [INFO] Tests run: 24, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 472.06 s - in  .hadoop.fs.s3a.commit.staging.integration.ITestStagingCommitProtocol [INFO] Tests run: 25, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 498.078 s - in  .hadoop.fs.s3a.commit.staging.integration.ITestDirectoryCommitProtocol [INFO] Tests run: 23, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 861.607 s - in org.apache.hadoop.fs.s3a.commit.magic.ITestMagicCommitProtocol [INFO] Running org.apache.hadoop.fs.s3a.commit.magic.ITestS3AHugeMagicCommits [WARNING] Tests run: 10, Failures: 0, Errors: 0, Skipped: 10, Time elapsed: 29.141 s - in org.apache.hadoop.fs.s3a.commit.magic.ITestS3AHugeMagicCommits [INFO] Running org.apache.hadoop.fs.s3a.commit.terasort.ITestTerasortOnS3A [WARNING] Tests run: 14, Failures: 0, Errors: 0, Skipped: 14, Time elapsed: 47.485 s - in org.apache.hadoop.fs.s3a.commit.terasort.ITestTerasortOnS3A

thanks. we don't need the whole trace, just region, maven args (-Dscale -Dprefetch ...) and whether any tests failed. if a test fails, look in jira to see if it's known

@shameersss1 @steveloughran Was this patch released as part of any 3.3.x hadoop-aws releases. I see that the JIRA references 3.3.9 but that's not yet released if I'm correct. Can you confirm?


Pydantic 1.10.3 breaks MLEM

pip install pydantic==1.10.3 and try import mlem - it fails

works ok with pip install pydantic==1.10.2

can't repro
the version was yanked, so maybe now this is resolved

WARNING: The candidate selected for download or install is a yanked version: 'pydantic' candidate (version 1.10.3 at https://files.pythonhosted.org/packages/b5/b5/4960fbf0d6774372d5d78e1991b498fbfb84383c4f65910063b8736b82a6/pydantic-1.10.3-cp39-cp39-macosx_10_9_x86_64.whl (from https://pypi.org/simple/pydantic/) (requires-python:>=3.7))
Reason for being yanked: See https://github.com/pydantic/pydantic/issues/4885


Explore our shop navigating to code repo

Description
On the home page,
when we click on explore our shop, it is navigating us to github code repo.
Screenshots
No response
Browser 🥦
Google Chrome
Checklist ✅

[X] I checked and didn't find similar issue
[X] I have read the Contributing Guidelines
[X] I am willing to work on this issue (blank for no)

Hi @SoundaryaKoutharapu , well at that time we were in a beta phase of the shops - now that we released it, we will redirect it in our next release. The code is already in my local system - kudos for noticing it though !


Fix jax and jaxlib version string for 24.04

So that they appear as jax-0.4.26 and jaxlib-0.4.26 instead of jax-0.4.26.dev20240404+165361ee8 and jaxlib-0.4.26.dev20240418.

Manual verification: https://github.com/NVIDIA/JAX-Toolbox/actions/runs/8744507879/job/23997723048#step:12:627


Convenient getting error when returned zero value (as 0 BOOL)

Something like this, but for all nullable types:
use Windows::Win32::Foundation::HINSTANCE;

windows::include_bindings!();

trait NullableToResult {
    #[inline]
    fn is_null(&self) -> bool;
    #[inline]
    fn ok(self) -> ::windows::Result<Self> where Self: Sized {
        if !self.is_null() {
            Ok(self)
        } else {
            Err(::windows::HRESULT::from_thread().into())
        }
    }
}

// HINSTANCE as example:
impl NullableToResult for HINSTANCE {
    #[inline]
    fn is_null(&self) -> bool {
        self.is_null()
    }
}

Probably similar https://github.com/microsoft/windows-rs/issues/1105

Thanks for the suggestion. That's similar to how BOOL works today. I like it...

https://github.com/microsoft/windows-rs/issues/1138 This would help to avoid duplicate implementation is_null in example for nullable types


Make the car stop at a distance of our choosing after spotting the obstacle

Requirement to be covered with this issue:

When the car detects something it will collide with, it should be able to prevent it from happening by braking(See the “Basic Movement” milestone).

Requirement to be covered with this issue:

When the car detects something it will collide with, it should be able to prevent it from happening by braking(See the “Basic Movement” milestone).

This issue was resolved in PR #15


distro: Add WithIDGenerator option

This adds the WithIDGenerator option mentioned in this issue: https://github.com/signalfx/splunk-otel-go/issues/1377

I have read the CLA Document and I hereby sign the CLA

Thank you for your comments @pellared . I already added your suggestions and the changelog

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (7ef9bcf) 78.43% compared to head (2c03943) 78.74%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2634      +/-   ##
==========================================
+ Coverage   78.43%   78.74%   +0.30%
==========================================
  Files          83       73      -10
  Lines        3223     2686     -537
==========================================
- Hits         2528     2115     -413
+ Misses        617      503     -114
+ Partials       78       68      -10

Flag
Coverage Δ

Windows
78.74% <100.00%> (+0.03%)
:arrow_up:

macOS
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

do I have to create a signed commit?

Yes. This may help you: https://superuser.com/questions/397149/can-you-gpg-sign-old-commits

Hi @pellared I think it is ok right now. Let me know if anything else is needed. Thanks!

@sergiopastan All good. Thanks for your contribution 🎉  I will merge once the CI passes.


Document database types

In the section below we describe that database types can differ from schema types. For example :text in a migration file would be :string in the Schema.
https://hexdocs.pm/ecto_sql/Ecto.Migration.html#module-field-types
As this section only mentions examples, where do we find the list of database types (with their corresponding Schema types)?
It would be nice to have a link with the documentation. If it's per adapter, then at least have a link to the types that Postgres supports, as Postgres seems to be the most commonly used.

Move to ecto_sql


chore: add codeql config file [APE-751]

What I did
trying to get codeql online again.
it seems to need a config file now for some reason, so adding one of those.
How I did it

How to verify it

Checklist

[ ] All changes are completed
[ ] New test cases have been added
[ ] Documentation has been updated

i think it may have worked now!


All genomes not being saved to genome group

I was in the Pathway EC page and created a group that should have had 171 members (see screenshot)

But when I saved them, only 100 of the 171 showed up (see screenshot).

Most discouraging.  I keep running into these small issues that make my life miserable.

I can reproduce the same problem. Below is the URL for the pathway page from where I created genome group.
https://www.patricbrc.org/portal/portal/patric/CompPathwayTable?cType=taxon&cId=1716&algorithm=PATRIC&ec_number=#aP0=1&aP1=1&aP2=1&aT=0&alg=PATRIC&cwEC=true&cwP=false&pId=&pClass=&ecN=<IP_ADDRESS> https://www.patricbrc.org/portal/portal/patric/CompPathwayTable?cType=taxon&cId=1716&algorithm=PATRIC&ec_number=#aP0=1&aP1=1&aP2=1&aT=0&alg=PATRIC&cwEC=true&cwP=false&pId=&pClass=&ecN=<IP_ADDRESS>

On Jun 8, 2016, at 8:42 AM, ARWattam<EMAIL_ADDRESS>wrote:
I was in the Pathway EC page and created a group that should have had 171 members (see screenshot)
https://cloud.githubusercontent.com/assets/11475316/15896165/11f6239e-2d5d-11e6-845c-c8f86102b30d.png
But when I saved them, only 100 of the 171 showed up (see screenshot).
https://cloud.githubusercontent.com/assets/11475316/15896177/239506ba-2d5d-11e6-96ef-c6d85265d6b5.png
Most discouraging. I keep running into these small issues that make my life miserable.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/PATRIC3/patric3_website/issues/667, or mute the thread https://github.com/notifications/unsubscribe/ABLd7y5IXfhyuoYixAljBFYavF7Ty537ks5qJsatgaJpZM4Iw-Hy.

Some more details to help debug the problem.
I tried to create the same genome group by selecting all the genes from the pathway genes tab and then
saving them as genome group, I got 100 genomes instead of 172.
Then, I tried to do the same from the feature table, by searching for the same EC number, selecting features,
and saving as genome group. Again, got 100 instead of 172.
https://www.patricbrc.org/portal/portal/patric/FeatureTable?cType=taxon&cId=1716&featuretype=&annotation=PATRIC&filtertype=#aP0=1&fT=CDS&alg=PATRIC&filter=&kW="<IP_ADDRESS>"&key=1465394407393 https://www.patricbrc.org/portal/portal/patric/FeatureTable?cType=taxon&cId=1716&featuretype=&annotation=PATRIC&filtertype=#aP0=1&fT=CDS&alg=PATRIC&filter=&kW="<IP_ADDRESS>"&key=1465394407393
So, I think the problem is with the "saving features as genome groups” functionality in general and not
specific to the pathway tab.

On Jun 8, 2016, at 8:52 AM, Maulik Shukla<EMAIL_ADDRESS>wrote:
I can reproduce the same problem. Below is the URL for the pathway page from where I created genome group.
https://www.patricbrc.org/portal/portal/patric/CompPathwayTable?cType=taxon&cId=1716&algorithm=PATRIC&ec_number=#aP0=1&aP1=1&aP2=1&aT=0&alg=PATRIC&cwEC=true&cwP=false&pId=&pClass=&ecN=<IP_ADDRESS> https://www.patricbrc.org/portal/portal/patric/CompPathwayTable?cType=taxon&cId=1716&algorithm=PATRIC&ec_number=#aP0=1&aP1=1&aP2=1&aT=0&alg=PATRIC&cwEC=true&cwP=false&pId=&pClass=&ecN=<IP_ADDRESS>

On Jun 8, 2016, at 8:42 AM, ARWattam<EMAIL_ADDRESS><EMAIL_ADDRESS>wrote:
I was in the Pathway EC page and created a group that should have had 171 members (see screenshot)
https://cloud.githubusercontent.com/assets/11475316/15896165/11f6239e-2d5d-11e6-845c-c8f86102b30d.png
But when I saved them, only 100 of the 171 showed up (see screenshot).
https://cloud.githubusercontent.com/assets/11475316/15896177/239506ba-2d5d-11e6-96ef-c6d85265d6b5.png
Most discouraging. I keep running into these small issues that make my life miserable.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/PATRIC3/patric3_website/issues/667, or mute the thread https://github.com/notifications/unsubscribe/ABLd7y5IXfhyuoYixAljBFYavF7Ty537ks5qJsatgaJpZM4Iw-Hy.

do you have a group with more than 100 genomes? then, can you see them correctly?
I am wondering whether it is a display problem (has all the genomes but just showing first 100) or saving problem (it claims 172 genomes, but actually having 100 genomes, which is more scary case).

Yes, I do have some genome groups in my workspace with more than 100 genomes and they are displayed correctly.
Though, they most likely were generated directly from genome list page.
When saving features as genome group, somehow it gets only 100 genomes, must be limit of number
of records / facet values returned from solr/API.
-Maulik

On Jun 8, 2016, at 9:13 AM, Harry Yoo<EMAIL_ADDRESS>wrote:
do you have a group with more than 100 genomes? then, can you see them correctly?
I am wondering whether it is a display problem (has all the genomes but just showing first 100) or saving problem (it claims 172 genomes, but actually having 100 genomes, which is more scary case).
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/PATRIC3/patric3_website/issues/667#issuecomment-224601917, or mute the thread https://github.com/notifications/unsubscribe/ABLd7yLo7I83Jd-5D451Gw2FBJLs7Igeks5qJs36gaJpZM4Iw-Hy.

Harry is busy preparing for the Demo Tomorrow. He will look into the problem later in the week,
after the demo.
-Maulik

On Jun 8, 2016, at 9:16 AM, Maulik Shukla<EMAIL_ADDRESS>wrote:
Yes, I do have some genome groups in my workspace with more than 100 genomes and they are displayed correctly.
Though, they most likely were generated directly from genome list page.
When saving features as genome group, somehow it gets only 100 genomes, must be limit of number
of records / facet values returned from solr/API.
-Maulik

On Jun 8, 2016, at 9:13 AM, Harry Yoo<EMAIL_ADDRESS><EMAIL_ADDRESS>wrote:
do you have a group with more than 100 genomes? then, can you see them correctly?
I am wondering whether it is a display problem (has all the genomes but just showing first 100) or saving problem (it claims 172 genomes, but actually having 100 genomes, which is more scary case).
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/PATRIC3/patric3_website/issues/667#issuecomment-224601917, or mute the thread https://github.com/notifications/unsubscribe/ABLd7yLo7I83Jd-5D451Gw2FBJLs7Igeks5qJs36gaJpZM4Iw-Hy.

this is fixed and available on beta and production.

fixed on production/.


Steuerung

Add control

The general idea was integrated into the project but the code itself wasn’t able to be merged directly without making huge changes to the existing code and leading to much more work in the future.


NVTabular - Update DFEncoder data ingestion and ETL to use NVTabular

[ ] Update dfencoder.AutoEncoder.init_features()

init_features takes a sample dataframe and determines the schema from the DataFrame's column types
Columns are put into 1 of 3 buckets: categorical, numerical and binary
This should be replaced to use NVTabular's schema and improve on the number of column types available
The ability should be added to dfencoder.AutoEncoder to allow manual overriding of the DataFrame schema (i.e. Supply specific operations or an entire schema which would bypass init_features all together)

[ ] Update dfencoder.AutoEncoder.build_model()

build_model takes the determined schema from a sample DataFrame and builds the auto encoder model from this schema
This requires mapping the schema to specific PyTorch functions before concatting everthing together for the core auto encoder layers.
We would need to update the current code to map from NVTabular schema instead of the current system

We should look at other models in Merlin for examples on how to do this

[ ] Update dfencoder.AutoEncoder.prepare_df()

prepare_df takes an input DataFrame and runs it through the preprocesser to get the final input before passing it to PyTorch
This will need to be replaced with a nvt.Workflow that takes the schema determined from the init_features function
We should look at speeding this up with parallelization or sharding across GPUs if needed.

Putting this on hold while we re-prioritize the updates to DFP


init_params bug

using SimpleChains
using Statistics

sc= SimpleChain(
static(2),
TurboDense(4, tanh),
TurboDense(4, tanh),
TurboDense(3, identity)
)

init_params(sc, Float64) |> std
init_params(sc, Float32) |> std

Running this a few times, I get that the Float64 method has a std around 0.5 while the Float32 one has an std of around 1.
This is with main as of two days ago (before merging #110)

julia> f32 = [std(SimpleChains.init_params(sc, Float32)) for _ in 1:10_000];

julia> f64 = [std(SimpleChains.init_params(sc, Float64)) for _ in 1:10_000];

julia> mean(f32)
0.29680106f0

julia> mean(f64)
0.4596680785000013

huh, that is not what I got. But it still looks strange that the two would be different.

Yes, still definitely wrong. This was on latest main.

We might want to be careful here though. I've found some misuses of glorot_normal! both in the tests of this package as well as in other packages where the fan-in fan-out got lost as the input was flattened before passed. It'd be good to test that init_param correctly uses glorot normal (0 biases) by at least manually comparing the statistics from a bunch of runs with some other implementation.

Locally, I've now added support for passing an rng object
julia> f32tl = [std(SimpleChains.init_params(sc, Float32, Random.default_rng())) for _ in 1:10_000];

julia> f64tl = [std(SimpleChains.init_params(sc, Float64, Random.default_rng())) for _ in 1:10_000];

julia> mean(f64tl)
0.4600335208066101

julia> mean(f32tl)
0.46095517f0

We might want to be careful here though. I've found some misuses of glorot_normal! both in the tests of this package as well as in other packages where the fan-in fan-out got lost as the input was flattened before passed. It'd be good to test that init_param correctly uses glorot normal (0 biases) by at least manually comparing the statistics from a bunch of runs with some other implementation.

While I suspect that nothing like this is the cause for the issues reported here (given my above comment), I do agree that this would be useful.

Still, replacing
  randn!(rng, A, static(0), static(0), σ)

with
  randn!(rng, A)
  A .*= σ
  return A

also yields the expected 0.46.

Using a vector length of 15 instead of 2048 with the same VectorizedRNG example above can reproduce the problem.

Fixed by


Allow displaying two months at a time

Is your feature request related to a problem? Please describe.
Currently, on the desktop, there isn't a good way to allow users to select a date range that has dates from two months (start in January and end in February)
Describe the solution you'd like
I'd like to be able to display two months when selecting a date range, similar to Google Flights:

Describe alternatives you've considered
For now, displaying single month is an option, but from UX perspective two months view would be better

Implemented in #1602.

Hi @oliviertassinari, that's really nice - is it only working for React or for Angular too? I am looking into https://material.angular.io/components/datepicker/overview but it does not have something like yours that has implemented to display 2 months!
Thank you!

@Shwan119 Material UI only focus on React. We can't help you on this one.


Can I link the ramps1.4 PCB based on Marlin which is used in 3d printer usually with SlicerVASST?

Can I link the ramps1.4 PCB based on Marlin which is used in 3d printer usually with SlicerVASST?

This fork of marlin is customized for a IdeaBuilder 20 with MKS Base 1.5 retrofit. I recommend you check out the Marlin community for guides to customizing for your printer.


Replication

Real fix for test issue earlier, with tests.
(note the schema case is not proving much, as we'll deprecate that code when we re-do the pivot).

@enisoc @michael-berlin

LGTM


Digital/Electronic Signatures

This is an excellent library!  Just used it and it works great..
I would like to have this library handle filling in the digital/electronic signatures fields as well.
I ended up using a workaround by converting to html adding signature then converting back to PDF
anyway thanks again!!  also this isnt really an issue but just a request.. couldnt find a spot to do that.

You could use https://www.npmjs.com/package/nopodofo. This lib already returns a buffer after write, and that can be passed directly into nopodofo to sign it. An example for that can be seen here: https://corymickelson.github.io/NoPoDoFo/documentation/cookbook/signer.html


Add same information that appears on Azure portal

On Azure Portal, the mount command for MaCOS is different.
Could we add it here too for easier share with customers?
cmd:
mount_smbfs -d 777 -f 777<EMAIL_ADDRESS>
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: eb2cee16-c6e9-1758-5078-aa224ee12085
Version Independent ID: c1028f61-f7d9-a568-d01c-57d50afbc33e
Content: Mount Azure file share over SMB with macOS
Content Source: articles/storage/files/storage-how-to-use-files-mac.md
Service: storage
Sub-service: files
GitHub Login: @roygara
Microsoft Alias: rogarana

Thanks for the feedback! I have assigned the issue to the content author to investigate further and update the document as appropriate.

@pumpkinclarinet Thanks for reaching out, we considered it but decided to leave this article as-is. Not using the mount command, but the open command, instead.
#please-close


extension method has  private modifier "private static OperationBuilder CreateUser("

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c13eb107-79c2-7824-12c1-e637d2a92add
Version Independent ID: aafc9673-c635-3cf2-6235-8577ff15d19c
Content: Custom Migrations Operations - EF Core
Content Source: entity-framework/core/managing-schemas/migrations/operations.md
Product: entity-framework
Technology: entity-framework-core
GitHub Login: @bricelam
Microsoft Alias: avickers

@IgorGolovko Why are you calling this out?

I agree, they should be internal or public in the sample.


The filter(Class) method

Please add one method that filters by specified class and returns a stream of this class.
In other words, the method that does
  .filter(MyClass.class::isInstance).map(MyClass.class::cast)
but in one operation and safely.

I've found the method named "select" that seems does this thing.
So, this request can be closed.


Electron: 1.6.2 update (<1.5) Completely breaks Dragon menu/submenu voice control (updated)

Development Environment:
OS: Windows 7 Professional SP1
Visual Studio 15 Community \ C++ Tools \ SDK
VS Code: 1.11.1 March release
VS Code: 1.12.0 Insiders March 12
VS Code: 1.12.0 March 7 master branch OSS build
Dragon Naturally Speaking DPI 14 (Voice/Dictation/Control)
Node: 6.10.1
NPM:  3.10.8
Description Of Bug:
Menu handling on Windows 7 started to behave differently
somewhere between March 7 and the Insiders March 12 update.
The problem is somewhat subtle since it may pertain
to voice control using Dragon. I believe for generic
software control in terms of menus, Dragon must utilize
the win32 API and messaging to detect the menus
and control them with voice commands.
Prior to the insiders March 12 (or close to that)
the stable VSC and insiders and OSS build March 7
both the top menu bar items as well as submenu items
were detected controllable by Dragon.
Now Dragon can detect and utilize the top level menus
but the submenus are now unable to be activated.
From of the feedback I can get from Dragon it appears
it detects the list of submenus but cannot control them.
I think this may also affect screen readers, but I do not
know for sure as I do not use one.
I am also thinking it probably has to do with the electron
framework/WindowsNativeInterface which I think has been updated or parts of it recently.
This is pretty big problem for accessibility and unfortunately
a big step back from prior operation.
I'm already working to contribute to the VSC so I can
probably help debugging this.  I can do successive builds
to try and figure out where the submenu started to fail after March 7
but having done this before it takes a long time especially by Voice
and maybe there's already an obvious place to start ?
Thanks

@bpasero
I think I've pretty much proven this is an electron upstream issue (unfortunately)
I did a series of tests with the electron starter app just changing electron versions.
Starting with electron 1.5 they updated Chrome and in npm could also be
they are using the new Windows UIA framework.
Either way it breaks Dragon and forces menus to be controlled
only with arrows.
I looked at the electron repository but found nothing to specifically address this.
I did happen to see someone from Nuance (makers of Dragon) posting a question
about electron and one of their extensions. I have to follow up on that. nothing was conclusive
This will affect any voice users and Dragon is basically the only game in town. So hopefully there is
a solution. It may be solved by exposing the menu templates so Dragon can see them.
I will try and find out what Dragon can work with or what changed with electron.
Unless I missed something I don't think VSC is it fault or can do anything yet.

I am sorry to hear that and would suggest to report this to Electron if possible for you (https://github.com/atom/electron).
I just verified that using NVDA I am still getting the menu items announced when they have focus. Note that we only officially support NVDA as screen reader on Windows at the moment.
/cc @chrisdias

@bpasero
@chrisdias
I did go ahead and post an issue on the electron project
Unfortunately over the weekend I seem to be seeing significant performance issues with Dragon
and the latest insiders not seen in the last stable version
it does not seem consistent so I cannot describe it very well but when it happens a single keypress
action can take several seconds to be performed
This would effectively make VSC completely unusable for Dragon users and really bum me out
to not be able to work on the project.
this issue sounds more like an interference with the Windows messaging or COM interfaces
utilized by Dragon. I also have a call into nuance but I'm not optimistic I will get to anybody
there could really address this.
Putting aside the menu issue (which we can get around mostly with shortcuts) I have seen several
issue posts on significant performance issues. do you see any relationship with the new electron code?

@cleidigh do you see these issues also with normal Chrome browser?

@bpasero
sorry didn't disappear. some system and other issues the past few days..
chrome does have some menu issues that's why suspected the electron
update. it's issues are slightly different it seems to have a menu index problem
you voice select one item it actually selects the above item
I don't think we'll get any help from Nuance unfortunately
I still have to do more tests but I might avoid problems by not using voice click on the main menus
this might solve the voice recognition stalling I would use shortcuts instead
it's a shame but apparently Nuance is bad at support I have not been able to get a hold of anyone on the development team. no answer from the electron team either.
I was able to finish my second PR for review so that's good..
time to look for some more things to help on

We will change to custom menus on Windows. For now you can set "window.titleBarStyle": "custom".


Incorrect info on page

[Enter feedback here]
    <ProjectReference Include="..\PathTo\SourceGenerator.csproj"
                      OutputItemType="Analyzer"
                      ReferenceOutputAssembly="false" />

^^this (on the page) doesn't work
    <ProjectReference Include="..\PathTo\SourceGenerator.csproj" >
      <OutputItemType>Analyzer</OutputItemType>
      <ReferenceOutputAssembly>False</ReferenceOutputAssembly>
    </ProjectReference>

^^ This works. capitol F in false is required.
Be sure to restart visual studio before every test case because the behavior is inconsistent/irratic

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 99a4410c-4c8d-0107-845b-9a951bb76682
Version Independent ID: f1ed9873-3e29-b4bd-2dbb-44dd9a05d790
Content: Source Generators
Content Source: docs/csharp/roslyn-sdk/source-generators-overview.md
Product: dotnet-csharp
Technology: csharp-roslyn
GitHub Login: @BillWagner
Microsoft Alias: wiwagn

Adding @KathleenDollard


Fix a minor test typo.

Merge activity

Dec 20, 1:08 PM: @@jklein24 merged this pull request with Graphite.


[Docs] Laravel Quickstart: Add command to automatically replace APP_URL with $DDEV_PRIMARY_URL

The Problem/Issue/Bug:
APP_URL should be set correctly in Laravels .env, this was missing in the quickstart.
How this PR Solves The Problem:
I added and tested the following on OSX 11.6.5 and ddev version v1.19.1.
ddev exec 'sed -i "/APP_URL=/c APP_URL=$DDEV_PRIMARY_URL" .env'

A more readable version (as described here) would be the following.
sed -i "s/APP_URL=.*/APP_URL=${DDEV_PRIMARY_URL}/g" .env

But I couldn't get it to work with quote escaping. 🤔
Manual Testing Instructions:
Automated Testing Overview:
No tests needed, just docs improvement
Related Issue Link(s):

https://github.com/drud/ddev/issues/3636

Release/Deployment notes:

But I couldn't get it to work with quote escaping.

It has nothing to do with quotes, just use a different delimiter instead of /, e.g. #.
It is because  ${DDEV_PRIMARY_URL} has a / inside.
ddev exec 'sed -i "s#APP_URL=.*#APP_URL=${DDEV_PRIMARY_URL}#g" .env'

Ah, thanks very much @stasadev for the enlightenment! :-o :-o
(For interested readers: https://stackoverflow.com/questions/16790793/how-to-insert-strings-containing-slashes-with-sed)
Not quite sure though if a custom delimiter would be confusing for new users who never worked with sed before? 🤔
ddev exec 'sed -i "s#APP_URL=.*#APP_URL=${DDEV_PRIMARY_URL}#g" .env'
ddev exec 'sed -i "s@APP_URL=.*@APP_URL=${DDEV_PRIMARY_URL}@g" .env'
ddev exec 'sed -i "s:APP_URL=.*:APP_URL=${DDEV_PRIMARY_URL}:g" .env'
ddev exec 'sed -i "s~APP_URL=.*~APP_URL=${DDEV_PRIMARY_URL}~g" .env'

(btw: The cleanest solution would be a CLI tool for dotenv, but did not found a big and major one 🤔)


Create Statistical Outliers Functions

Create static library functions for dealing with outliers.
Define an Outlier Policy that contains the options for outlier removal.
Enable the policy to be extensible so that different techniques for identifying outliers can be utilized.

There are at least three key Outlier methods:

Find and remove at most n outliers from a Mutable List
Identify (by index) the outliers in an unsorted Array
Determine whether the highest element in a sorted Array/List is an outlier

These methods require a definition and technique for determining what an outlier is. This may be specified by the number of Standard Deviations, or a confidence interval.
There may be an option for including/excluding the outlier in the calculations.

It may be possible to use generics to combine all of the List types into one method signature. This would be ideal from a user perspective, however performance impact should be considered at some later date.

Failed Tests:

Off by one error in the medium sized list test, an error in the calculation of the limit for the list data.
A NPE in the max value test - the function returns null when no elements are found.

A DeviationPolicy would generally be applied to a specific set of distributions, for which there are a set of expected values.
This set may represent a series of measurements, for which there is a physical (or digital) lower bound, a small expected range of values, and rare large values. The ideal outlier policy is to look for ouliers only much greater than the range of expected values, and ignore lower values, even if they are over 6 Standard Deviations (SD) below the mean.

Should DeviationPolicy maintain an instance of DistributionCharacteristics?

This branch has to be merged today.
There are important project structure modifications to be made.
Anything too time-consuming to resolve, will become a new issue.

The last thing to do before merging:

A complete implementation of the identifyOutliers functions on double and long type arrays


sanger config

Add sanger.config
Also review the 6 wiki pages  - https://github.com/sanger-tol/nf-core-pipeline/wiki
This will close JIRA ticket https://jira.sanger.ac.uk/browse/TOLIT-559
The Home will be completed after some pages are transferred from Confluence.

nextflow.config
There is more stuff than listed under "What not to change?" and "What to change?", like the check_max function, etc. I would suggest to change the paragraph to:

Only change: "Input options" and "Max resource options" in params, and manifest

and then mention the nextflow version, etc

conf/sanger.config
Having a copy of this file in every pipeline seems to go against the nf-core preferred setup. Can we upload our config to nf-core/configs instead ?

conf/base.config
process_single is a better name than process_nompi (not all multi-threaded software use MPI), and process_single is what's now used in nf-core.
These two labels need a one-line description

We do not change max resource options in nextflow.config

right. even simpler :)

We had some conversation about conf/sanger.config on the nextflow email list but then it dropped again. I can submit a PR and post the link to sanger-openstack#workflow-systems. If approved, we can load with -profile sanger.

Updated the config wiki page

https://github.com/nf-core/configs/pull/399

I am closing this ticket since we don't want to merge this anymore. Its been uploaded to nf-core/configs and the Wiki has been updated accordingly.


russian localization

russian localization added and checked with Rails5

@volmer hey! take a look please 👍

Thanks for the pull request, but we are not supporting additional locales in the main repo for now.
See #233 #214 #64


Helm Apps > App Detail > View Events & Logs is broken

Describe the bug
View events and View container logs are not redirecting to the events and logs tab.
To Reproduce

Go to Applications > Select Helm apps tab
Select any app > it'll redirect to the App Details page > Pods
Select the three-dot menu on the right of the individual pod
Click on view event or view container log
Observe

Expected behavior
It should have redirected the user to the event/log tab
Screenshots

Fixed broken urls


Use Source object to track if a layer is duplicated

Description
As suggested by https://github.com/napari/napari/issues/5023 after https://github.com/napari/napari/pull/5010 the Source object could keep track of a potential parent.
Here I propose a draft how this could look like :)
Type of change

[X] New feature (non-breaking change which adds functionality)

Implementation looks good to me! I would wait a bit to hear other opinions in case we missed something, this is public API and we should be wary with expanding it.

@napari/core-devs any objections to this?

I think I made the implementation a bit cleaner now by utilizing the layer_source context manager in the _duplicate_layer function. Additionally, the weakref creation is now part of the pydantic Source object parent validator.
Furthermore, I added some tests :)
I had to move the import of _source in the Layer object into the __init__ function due to circular imports:
https://github.com/mstabrin/napari/blob/4df932ad0b8edd803d4eef1835f8c690ee2ed998/napari/layers/base/base.py#L236

I added a couple of commits which only import when types are being checked at runtime, could you check whether the circular import is still a problem?

This unfortunately won't work and that is why I needed to resolve the issue in a different way :)
We are dealing with a pydantic object, therefore the type hint is not merely a type hint, but is actually used during runtime to verify the type and Layer really needs to be imported and be available.

ooft, I thought this made it so that the actual import still happened when runtime type checking was performed... no matter -> LGTM here!

@Czaki @brisvag if you're happy with this and see it when CI has passed could you merge?


Just want to say thank you

Thank you for all the hard work. This app is far better than the official one. I have been using it, very nice!

No worries. I learnt a lot writing this app.


Question about lightgbm retrain

Hi !
Environment info
Operating System:ubuntu17.10
CPU/GPU model:CPU
C++/Python/R version:Python
LightGBM version or commit hash:latest
Reproducible examples 1
import lightgbm as lgb
import pandas as pd
import numpy as np

Data = np.random.randint(0,10,(1000,100))
Data1 = np.random.randint(0,10,(1000,100))
Data1[Data >=0]=0
Data1[Data >=3]=1
Data1[Data >=6]=2
Data1 = pd.DataFrame(Data1)

Data2 = np.random.randint(10,100,(1000,50))
Data2 = pd.DataFrame(Data2)
Data3 = pd.concat([Data2,Data1],axis=1)
Data3.columns = np.arange(0,150)
print 'Load is OK'

X_train_A = Data3.iloc[:,50:]
X_train_AB = Data3.iloc[:,20:]
X_train_ABC = Data3.iloc[:,1:]
Y_train = Data3.iloc[:,0]

feature_A_name = X_train_A.columns.values.tolist()
feature_AB_name = X_train_AB.columns.values.tolist()
feature_ABC_name = X_train_ABC.columns.values.tolist()

lgb_train_A = lgb.Dataset(X_train_A,label=Y_train)
lgb_train_AB = lgb.Dataset(X_train_AB,label=Y_train)
lgb_train_ABC = lgb.Dataset(X_train_ABC,label=Y_train)
print 'Data is OK'

# train parameters
params = {'learning_rate':0.05,
          'num_leaves':10,
          'min_data_in_leaf':1,
          'objective':'regression_l2',
          'device':'cpu',
          'max_depth':-1,
          'num_threads':12,
          'feature_fraction':1,
          'verbosity':1}
num_boost_round=50

# train
gbm_A = lgb.train(params, lgb_train_A, num_boost_round)
gbm_AB = lgb.train(params, lgb_train_AB, num_boost_round, init_model=gbm_A)
gbm_ABC = lgb.train(params, lgb_train_ABC, num_boost_round, init_model=gbm_AB)
print 'Train is OK'

# extract feature importance
feature_A_importance = gbm_A.feature_importance()
feature_A = {}
for index, value in enumerate(feature_A_importance):
    if value != 0:      # only output feature which have been uesd in tree
        feature_name = feature_A_name[index]
        feature_A[feature_name] = value
A_nosort = zip(feature_A.values(),feature_A.keys())
A_sort = sorted(A_nosort,reverse=True)
A_sort = pd.DataFrame(A_sort)
A_sort.to_csv('./A_feature_test2.csv')

feature_AB_importance = gbm_AB.feature_importance()
feature_AB = {}
for index, value in enumerate(feature_AB_importance):
    if value != 0:
        feature_name = feature_AB_name[index]
        feature_AB[feature_name] = value
AB_nosort = zip(feature_AB.values(),feature_AB.keys())
AB_sort = sorted(AB_nosort,reverse=True)
AB_sort = pd.DataFrame(AB_sort)
AB_sort.to_csv('./AB_feature_test2.csv')

feature_ABC_importance = gbm_ABC.feature_importance()
feature_ABC = {}
for index, value in enumerate(feature_ABC_importance):
    if value != 0:
        feature_name = feature_ABC_name[index]
        feature_ABC[feature_name] = value
ABC_nosort = zip(feature_ABC.values(),feature_ABC.keys())
ABC_sort = sorted(ABC_nosort,reverse=True)
ABC_sort = pd.DataFrame(ABC_sort)
ABC_sort.to_csv('./ABC_feature_test2.csv')

I find something make me puzzled when I watch the *_feature_test2.csv. For example, the number of the feature '52' in AB_feature_test2.csv is 10, and in ABC_feature_test2.csv is 3. But I think the quantitative relationship between them should be A < AB < ABC, not AB > ABC, because ABC is based on AB.
Reproducible examples 2
X_train_A = Data3.iloc[:,50:]
X_train_AB = Data3.iloc[:,20:]
X_train_ABC = Data3.iloc[:,1:]
Y_train = Data3.iloc[:,0]

just change the content(above) in the examples 1 to the content(below)
X_train_A = Data3.iloc[:,1:100]
X_train_AB = Data3.iloc[:,1:130]
X_train_ABC = Data3.iloc[:,1:]
Y_train = Data3.iloc[:,0]

I find the feature importance is ok. The quantitative relationship between them is A < AB < ABC
Please tell me why, thank you very much!
Yuetong Xu

Firstly, you use the retrain in the wrong way.
In LightGBM side, the j-th feature is X_train_A[:j], X_train_AB[:j], X_train_ABC[:j], but they are different indices in your data,  with the first data setting
Secondly, the feature importance only counts the features in the current dataset. For example, when using X_train_AB as training data, the number of features is only 20, and the feature indices larger than 20 aren't counted.


actioning an Alfred Result does nothing

Diagnostic
Workflow version
2023.10
Alfred version
5.1.2
macOS version
13.5.2
Architecture
arm64
Preferences
Dict {
logins_only = true
}
1Password version
8.10.13
op version
2.21.0
Launchd job
Loaded: -	0	com.alfredapp.vitor.1password
Installed
Debugger output
[01:23:22.499] 1Password[Script Filter] Queuing argument '(null)'
[01:23:22.578] 1Password[Script Filter] Script with argv '(null)' finished
[01:23:22.582] 1Password[Script Filter] {"items":[{"uid":"ivfwtrqwfulhcyavzan2mllghm",
.........
.........
........CUT BECAUSE THIS IS TOO HUGE FOR GITHUB AND ALSO CONTAINS PRIVATE INFO??
........
........
"url":"https://www.elance.com/php/reg/main/createAccount.php?job=1"}},"shift" [truncated]
[01:23:37.272] 1Password[Script Filter] Processing complete
[01:23:37.272] 1Password[Script Filter] Passing output '' to Junction
[01:23:37.272] 1Password[Junction] Processing complete
[01:23:37.272] 1Password[Junction] Passing output '' to Automation Task
[01:23:37.274] 1Password[Automation Task] Running task 'Is App Running?' with arguments (
    "com.1password.1password"
)
[01:23:37.309] 1Password[Automation Task] Processing complete
[01:23:37.310] 1Password[Automation Task] Passing output 'true
' to Conditional
[01:23:37.310] 1Password[Conditional] Processing complete
[01:23:37.310] 1Password[Conditional] Passing output 'true
' to Conditional

More details
i've updated the Workflow to the latest version, then it stopped working. i've reseted the Workflow, updating the items again, but same thing. i feel lost and sad.
i've cut the middle of the debug output because it was too long to paste (65536 characters max in field). AND ALSO WAS CONTAINING SENSITIVE INFO>

Was 1Pasword running at the time?
Which modifier did you use?
What was the action that you wanted?

Was 1Pasword running at the time?

yes.

Which modifier did you use?

command. but also none.

What was the action that you wanted?

Safari opens with the URL of the Alfred Result selected, and fills the logins. kinda like usual. but maybe i'm missing something?

Can you try this version? You’ll need to Force Update Items again.

Can you try this version? You’ll need to Force Update Items again.

we have a winner 🧁

Thank you for the fast feedback. Released 2023.11, will be in the Gallery in a moment.

2023.11 works great. thanks!

@vitorgalvao ok, back here. it does work on my Mac mini M2, but it doesn't work anymore on my MBP Intel... then i've reset the Workflow on that MBP, signed in again (got the popup), and then nothing happens. 1p now keep showing Sign in and update items. i've rebooted blah blah blah.
what do you want me to do now? open a new issue? paste the diagnostic of the MBP here?

fyi, when i reset the Workflow on the MBP:
[13:52:43.709] ERROR: 1Password[Automation Task] Task Argument Error: Expecting single or multiple inputs. Warnings: (     "Passed in file '/Users/guill/Library/Application Support/Alfred/Workflow Data/com.alfredapp.vitor.1password' does not exist, discarding",     "Passed in file '/Users/guill/Library/Caches/com.runningwithcrayons.Alfred/Workflow Data/com.alfredapp.vitor.1password' does not exist, discarding" )
i sync my Settings through Dropbox.

paste the diagnostic of the MBP here?

Yes, please. Plus the debugger when trying to sign in.

Diagnostic
Workflow version
2023.11
Alfred version
5.1.2
macOS version
14.0
Architecture
i386
Preferences
Default
1Password version
8.10.16-43.BETA
op version
2.21.0
Launchd job
NOT loaded
NOT installed
Debugger
[02:22:22.726] 1Password[Script Filter] Queuing argument '(null)'
[02:22:22.809] 1Password[Script Filter] Script with argv '(null)' finished
[02:22:22.814] 1Password[Script Filter] {
"rerun": 0.1,
"items": [{
"variables": { "action": "update_items" },
"title": "Sign in and update items",
"arg": "update_items",
"icon": { "path": "composite_icon.png" }
}]
}
[02:22:22.914] 1Password[Script Filter] Queuing argument '(null)'
[02:22:23.006] 1Password[Script Filter] Script with argv '(null)' finished
[02:22:23.009] 1Password[Script Filter] {
"rerun": 0.1,
"items": [{
"variables": { "action": "update_items" },
"title": "Sign in and update items",
"arg": "update_items",
"icon": { "path": "composite_icon.png" }
}]
}
[02:22:23.103] 1Password[Script Filter] Queuing argument '(null)'
[02:22:23.184] 1Password[Script Filter] Script with argv '(null)' finished
[02:22:23.193] 1Password[Script Filter] {
"rerun": 0.1,
"items": [{
"variables": { "action": "update_items" },
"title": "Sign in and update items",
"arg": "update_items",
"icon": { "path": "composite_icon.png" }
}]
}
[02:22:23.291] 1Password[Script Filter] Queuing argument '(null)'
[02:22:23.316] 1Password[Script Filter] Script with argv '(null)' finished
[02:22:23.322] 1Password[Script Filter] {
"rerun": 0.1,
"items": [{
"variables": { "action": "update_items" },
"title": "Sign in and update items",
"arg": "update_items",
"icon": { "path": "composite_icon.png" }
}]
}
[02:22:23.421] 1Password[Script Filter] Queuing argument '(null)'
[02:22:23.467] 1Password[Script Filter] Processing complete
[02:22:23.474] 1Password[Script Filter] Passing output 'update_items' to Junction
[02:22:23.476] 1Password[Junction] Processing complete
[02:22:23.478] 1Password[Junction] Passing output 'update_items' to Automation Task
[02:22:23.480] 1Password[Automation Task] Running task 'Is App Running?' with arguments (
"com.1password.1password"
)
[02:22:23.563] 1Password[Automation Task] Processing complete
[02:22:23.569] 1Password[Automation Task] Passing output 'true
' to Conditional
[02:22:23.570] 1Password[Conditional] Processing complete
[02:22:23.573] 1Password[Conditional] Passing output 'true
' to Conditional
[02:22:23.574] 1Password[Conditional] Processing complete
[02:22:23.575] 1Password[Conditional] Passing output 'true
' to Run Script
[02:22:23.727] 1Password[Run Script] Processing complete
[02:22:23.736] 1Password[Run Script] Passing output '' to Conditional
[02:22:23.739] 1Password[Conditional] Processing complete
[02:22:23.741] 1Password[Conditional] Passing output '' to Run Script
[02:22:23.826] 1Password[Run Script] Processing complete
[02:22:23.827] 1Password[Run Script] Passing output '' to Conditional
[02:22:23.829] 1Password[Conditional] Processing complete
[02:22:23.834] 1Password[Conditional] Passing output '' to Run Script
`

Does op item list work in a terminal? Where is op on that Mac? Have you installed it with Homebrew too?

Does op item list work in a terminal?

not working. interesting. just seems to be hanging.
Where is op on that Mac? Have you installed it with Homebrew too?
/usr/local/bin/op. installed through Homebrew yes. version 2.21.0.
will remove and reinstall and see.

not working. interesting. just seems to be hanging.
will remove and reinstall and see.

after removing and reinstalling, it works in the Terminal. still not through Alfred tho. will explore the debug info and diagnostic and will come back to you.

debug looks clean:
[15:13:22.296] 1Password[Script Filter] Queuing argument '(null)'
[15:13:22.362] 1Password[Script Filter] Processing complete
[15:13:22.367] 1Password[Script Filter] Passing output 'update_items' to Junction
[15:13:22.369] 1Password[Junction] Processing complete
[15:13:22.370] 1Password[Junction] Passing output 'update_items' to Automation Task
[15:13:22.371] 1Password[Automation Task] Running task 'Is App Running?' with arguments (
"com.1password.1password"
)
[15:13:22.414] 1Password[Automation Task] Processing complete
[15:13:22.418] 1Password[Automation Task] Passing output 'true
' to Conditional
[15:13:22.420] 1Password[Conditional] Processing complete
[15:13:22.421] 1Password[Conditional] Passing output 'true
' to Conditional
[15:13:22.422] 1Password[Conditional] Processing complete
[15:13:22.424] 1Password[Conditional] Passing output 'true
' to Run Script
[15:13:22.509] 1Password[Run Script] Processing complete
[15:13:22.510] 1Password[Run Script] Passing output '' to Conditional
[15:13:22.511] 1Password[Conditional] Processing complete
[15:13:22.517] 1Password[Conditional] Passing output '' to Run Script
[15:13:22.596] 1Password[Run Script] Processing complete
[15:13:22.597] 1Password[Run Script] Passing output '' to Conditional
[15:13:22.603] 1Password[Conditional] Processing complete
[15:13:22.604] 1Password[Conditional] Passing output '' to Run Script
i'm on the latest macOS 14 public beta tho. so maybe it's something related to that. i think the dialog to give access to op for Alfred is kinda new. maybe we don't bother with the issue until macOS 14 is properly released. at that time if it's a common issue you should get more reports. till now i guess it's fine, i'll just dig into it myself.