Artifacts should include the full device log

Right now, artifacts include a portion of the device log during the time of each test. This can lead to missing portions from between the tests.
There should be a full device log at the root folder of the artifacts for reference.

device log during the time of each test

@LeoNatan, it's not a bug, it's a feature. 😃  Think of it as a video recording of the test, which apparently can also miss some things.
Even if we do this, I think it should be configurable, or well-thought in some another way. I see your point that some portions might miss, but browsing one huge log looks not nice either.

With a video it makes sense because Detox waits for idle, which also means UI idleness.
When reading device log, it doesn’t make sense to have it split. What is happening right now is that important parts of the log are missing, which defeats the point of having logs in the first place.
Device log should be kept fully in addition to being split.

Okay, but I think I'll need at least 2-3 SP for that, let's talk in DM.

:)

Closing in favor of #1445.


automatic execution of files in "source"

Hi,
thank you for your great scripts and configurations, and the proposed concept of managing them. I am currently using a small subset of the folders (init, copy and link) in order to setup Raspbian systems. It works great.
Just one question I have: Although the files within the subfolders COPY, LINK and INIT are handled as expected, the files in the SOURCE subfolder seem not to be. For example, I would like to see the prompt change according to the file source/50_prompt.sh . As the file bin/dotfiles does not execute / handle the SOURCE files as done for COPY, LINK and INIT, where (in which of the repository files) do I find the line of code which executes them?
Thank you very much.

https://github.com/cowboy/dotfiles/blob/master/link/.bashrc


Not sure how /api/client/servers/UUID/startup/* works

Not really sure what this is meant for but if anyone cares to explain and or add in these methods feel free to do so, until then consider this endpoint one of the last ones to be added

Hi
I think that /startup doesn't really matter anymore.
The API uses /power, but with a parameter "signal".
I saw that you already did this well in the code.

Inactive, closing


Has one directive

Description of changes

Adding new functionality to support the V2 transformer directives @hasOne, @hasMany, @belongsTo
This also fixes some of the code with @primaryKey and @index being supported next to @connection since that will never happen in a real world scenario
Removes use of the FeatureFlags class in amplify-cli-core and uses feature flags the way that codegen does
Fixes some of the tests that were using FeatureFlags
Issue #, if available

Description of how you validated changes
Ran unit tests, writing some new unit tests, manual testing
Checklist

[x] PR description included
[x] yarn test passes
[x] Tests are changed or added
[x] Breaking changes to existing customers are released behind a feature flag or major version update
[ ] Changes are tested using sample applications for all relevant platforms (iOS/android/flutter/Javascript) that use the feature added/modified

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Getting the PR ready for view, still in the process of adding some more unit tests and manual testing to verify

Codecov Report

Merging #229 (051739a) into vnext-directive-enhancements (4d743b9) will decrease coverage by 0.95%.
The diff coverage is 56.94%.

@@                       Coverage Diff                        @@
##           vnext-directive-enhancements     #229      +/-   ##
================================================================
- Coverage                         85.47%   84.51%   -0.96%
================================================================
  Files                               140      144       +4
  Lines                              6332     6531     +199
  Branches                           1407     1472      +65
================================================================
+ Hits                               5412     5520     +108
- Misses                              840      930      +90
- Partials                             80       81       +1

Impacted Files
Coverage Δ

...odelgen-plugin/src/scalars/supported-directives.ts
100.00% <ø> (ø)

...s/graphql-types-generator/src/utilities/graphql.ts
67.64% <0.00%> (-8.18%)
:arrow_down:

...psync-modelgen-plugin/src/utils/process-has-one.ts
21.42% <21.42%> (ø)

...elgen-plugin/src/visitors/appsync-swift-visitor.ts
89.27% <25.92%> (-7.40%)
:arrow_down:

...odelgen-plugin/src/utils/process-connections-v2.ts
54.71% <54.71%> (ø)

...nc-modelgen-plugin/src/utils/process-belongs-to.ts
56.52% <56.52%> (ø)

...sync-modelgen-plugin/src/utils/process-has-many.ts
66.66% <66.66%> (ø)

...nc-modelgen-plugin/src/visitors/appsync-visitor.ts
92.94% <70.83%> (-2.51%)
:arrow_down:

...delgen-plugin/src/visitors/appsync-java-visitor.ts
93.12% <94.11%> (-0.01%)
:arrow_down:

packages/amplify-codegen/src/commands/models.js
82.07% <100.00%> (+0.17%)
:arrow_up:

... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d743b9...051739a. Read the comment docs.

Ready for review

There are many "TODO's" - is this production ready code?

It should be, I only put these TODOs in because it's stuff we can't do yet but can do soon, I wanted to make sure there were markers to go back and find what to clean up once the new transformer gets released


SelectList: Refactor placeholder for better React support

React warns against using "selected" prop directly on an "option". We currently only use "selected" for the placeholder feature.
This change removes "selected" and instead uses "value" prop when a placeholder is used.

@christianvuerings do I need to bump Gestalt version as well? Does every PR need to update the changelog and bump the version?

@rootvar No need to bump the Gestalt version. Every PR should update the changelog.md file

@christianvuerings got it! thank you


[release-1.10] feat: annotations on gateway serviceaccount

Manual cherrypick required.
#33914 failed to apply on top of branch "release-1.10":
Applying: feat: annotations on gateway serviceaccount
Applying: task: add release notes
Applying: task: fix release notes
Applying: task: update release notes
Applying: task: add ServiceAccount to Gateway Configs
Using index info to reconstruct a base tree...
M	operator/pkg/apis/istio/v1alpha1/values_types.pb.go
M	operator/pkg/apis/istio/v1alpha1/values_types.proto
Falling back to patching base and 3-way merge...
Auto-merging operator/pkg/apis/istio/v1alpha1/values_types.proto
Auto-merging operator/pkg/apis/istio/v1alpha1/values_types.pb.go
CONFLICT (content): Merge conflict in operator/pkg/apis/istio/v1alpha1/values_types.pb.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0005 task: add ServiceAccount to Gateway Configs
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

@craigbox @brian-avery
I created a new branch from release-1.10 and cherry-picked the changes.. Here's a PR to get those into release-1.110 branch:
https://github.com/istio/istio/pull/34964

Fixed in #34969.


fix: adding tests, and fixing some bugs, updating api a bit

Description of changes
Addressing a few bugs and asks in the proposed interface from testing.

Fix predictionsConfig wiring, and add a test to verify it synthesizes.
Fix functionSlot setIn function, which had a bad condition in it, added tests for that.
Add comments to remaining types.
Rename ResolverConfig to conflictResolution, and take types internal so customers don't need to import from transformer packages.
Bump unit test coverage numbers for added tests.
Update API Extract to reflect these changes.

CDK / CloudFormation Parameters Changed
N/A
Issue #, if available
N/A
Description of how you validated changes
Unit tests pass.
Checklist

[x] PR description included
[x] yarn test passes
[x] Tests are changed or added

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #1593 (448ed9e) into main (0dd31fc) will increase coverage by 0.14%.
The diff coverage is 93.33%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@            Coverage Diff             @@
##             main    #1593      +/-   ##
==========================================
+ Coverage   63.28%   63.42%   +0.14%
==========================================
  Files         370      371       +1
  Lines       21689    21701      +12
  Branches     5169     5177       +8
==========================================
+ Hits        13725    13763      +38
+ Misses       7235     7211      -24
+ Partials      729      727       -2

Impacted Files
Coverage Δ

...-api-construct/src/internal/conflict-resolution.ts
88.88% <88.88%> (ø)

...y-graphql-api-construct/src/amplify-graphql-api.ts
96.00% <100.00%> (+0.16%)
:arrow_up:

...mplify-graphql-api-construct/src/internal/index.ts
100.00% <100.00%> (ø)

...l-api-construct/src/internal/user-defined-slots.ts
93.93% <100.00%> (+84.56%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Take trackNumber from lookup?

Hey,
I have one question.
Why you don't pull the trackNumber from the Lookup?
Best regards,
Felix

Okay, I only have m4a-files.
mp3 don't uses trackNumber?

I don't know, I generally use m4a instead of mp3.

Me too.
So i added the trackNumber to source.


Various cleanup

Add cargo llvm-cov report subcommand. This is almost the same as cargo llvm-cov --no-run, but it has a more obvious name and better diagnostics.
Add cargo llvm-cov test subcommand. This is equivalent to cargo llvm-cov without subcommand, except that test name filtering is supported.
Deprecate --no-run in favor of cargo llvm-cov report subcommand.
Support --keep-going (unstable), --ignore-rust-version.
Support --exclude-from-report and --ignore-run-fail for cargo llvm-cov run.
Fix help messages for subcommands.
Fix handling of nextest's --profile option.

Closes #92
Fixes  #216

bors r+


two's-complement logic operations on BigInt

This commit adds the following impls, giving results equivalent to what would be expected with two's complement.

impl Not for BigInt
impl BitAnd<&BigInt> for BigInt, impl BitAndAssign<&BigInt> for BigInt
impl BitOr<&BigInt> for BigInt, impl BitOrAssign<&BigInt> for BigInt
impl BitXor<&BigInt> for BigInt, impl BitXorAssign<&BigInt> for BigInt

I also added some tests. There is most probably some room for optimization, but the bitwise operations all operate in place using a single pass.
I did not add other implementations such as impl BitAnd<BigInt> for BigInt, those can be done later.

I addressed your points in the first commit.
In the second commit I added tests on i64 values within ±3 of interesting values (i64::MIN, -u32::MAX, etc.). All logic operations are tested on all combinations with both i64 and BigInt, and the answers compared. That found a couple of bugs I fixed.

I've added a third commit which makes the inline docs more helpful. I also made the use of the debug_assertions more consistent. I think this makes the code easier to understand.

Commit 1 is now the implementation and commit 2 is the tests.
Commit 3 introduces a crate-visible IntDigits trait so that macros that used to use data.len() or data.capacity() can work for both BigUint and BigInt, and I also used it for BigInt to access BigUint::normalize. I made <BigUint as IntDigits>::normalize simply call the inherent method BigUint::normalize, maybe the implementation could move into the trait method and the inherent method can simply be removed?
Commit 4 implements ref/val forwarding for the bitwise ops of BigInt (depends on commit 3).

I took the small liberty of adding reference Not, but otherwise this quite comprehensive.  Thanks a lot!
bors r+


Initial commit of job and pbs classes

Whoohoo!!! Slow down askask :). We are not halfway through the extraction process! However, a lot of your points are valid, but I think we will have to discuss the library together (and create comments in that process). Let's find a date where we all can squeeze into a tiny room and see how the library will work.

@dankwart-de What is the status of this branch? What is its relation to the BEintegration branch?

For now, I'll close this pull request. It is outdated and work was done in PR#2


[FEATURE] Ability to access absolute x, y coordinate and dimension of a widget

Description of the requested feature
Some widgets may create a dropdown or pull up external applications when being clicked or hovered, and crucial part of the interaction is to open them close to where the original widget was, GTK seems to provide such properties, but the yuck does not have anything to interface this...
Proposed configuration syntax
(defvar widget_name_info '')

(defwidget widget_name
  (box :info widget_name_info    ; updates the passed variable when created or when revealer opens/close etc
       :onsometriggerevent "cmd params ${info.x} ${info.y} ${info.w} ${info.h} --anchor bottom-left more_params"
    ...))

Additional context
-

Should it be different var altogether? Like since defvar can be mutated from outside it might not suit this, would it? Any thoughts?

I really don't like the idea of having a variable be mutated magically by some widget like this (specifically, passing a variable "mutably" to a widget - it'd also not really work in the current state implementation)
Referencing the coordinates of a widget somehow is something I'd want to support somehow, however.
My thought would be that it should suffice to allow accessing the global geometry of a defwidget, but not of any of it's contents. This would allow me to add a "magical" CURRENT_WIDGET variable that contains this geometry data. If you needed to use it nested somewhere, you'd have to extract that part out into a separate widget,... which should still suffice for most usecases.
Additionally, many of these usecases should also be filled by supporting the popover widget as mentioned in #234


replaceImportAddresses doesn't replace all instances (multiple imports / inline instances)

Problem
👋🏻 Hey!
We have a cadence file where we have:

multiple imports: import FirstContract, SecondContract from 0xContract
inline instances:  pre {
      self.account.address == AddressThatNeedsToBeReplaced: "Invalid"
  }

Steps to Reproduce
Multiple imports example:
const addressMap = {
  Messages: '0xf8d6e0586b0a20c7',
  OtherMessages: '0xf8d6e0586b0a20c7',
};

const code = `
  import Messages, OtherMessages from 0x1

  pub fun main(){}
`;

const replaced = replaceImportAddresses(code, addressMap);
console.log({ replaced });

Inline instances example
const addressMap = {
  Messages: '0xf8d6e0586b0a20c7',
  OtherMessages: '0xf8d6e0586b0a20c7',
};

const code2 = `
import Messages from 0x1

transaction() {
    pre {
        self.address == Messages: "Failed" // inlined here
    }
}
`;

const replaced2 = replaceImportAddresses(code2, addressMap);
console.log({ replaced2 });

Acceptance Criteria
Would be nice if the replaceImportAddresses method would replace multiple imports and inline instances.
Is supporting this in on your roadmap ?

Hey, @march213 👋

Multiple imports should be easy to fix. Thank you for flagging this 👍
Inline instances is a bit more tricky, unless it's something easy to tag and replace for example if it comes with # prefix - i.e #MESSAGES 🤔

Multiple imports should be easy to fix. Thank you for flagging this 👍

That's awesome!

Inline instances is a bit more tricky, unless it's something easy to tag and replace for example if it comes with # prefix - i.e #MESSAGES

That potentially could work.

This has been triaged into two separate issues: #117 #118


Example - Project Management System

Background
Hi there, i've created a project for example list using FSD with react, typescript, mobx, material ui, react-hook-form.
Demo: https://ivanzemsky.github.io/ProjectManagement/
Code: https://github.com/IvanZemsky/ProjectManagement
I launched it locally, it seems to be working fine.
Changelog

src/pages/examples/_config.ts
src/pages/examples/img (added project-management-system.png)

Project will be migrated to version 2.1


Updates for the C# debugger

Fixed windows support and added a sample project.

added support for the pipeTransport option in the configurations. This will allow users to debug Godot C# (and probably also Unity) projects and remote applications with the debugger. This also supports a debuggerArgs option that can be used to pass custom arguments to the debugger.


providerconfig: make sure v1 auth path checks for assumeRole field as…

Description of your changes
Fixes https://github.com/crossplane-contrib/provider-aws/issues/1334
Fixes https://github.com/crossplane-contrib/provider-aws/issues/1289
Fixes https://github.com/crossplane-contrib/provider-aws/issues/1278
I have:

[x] Read and followed Crossplane's contribution process.
[x] Run make reviewable test to ensure this PR is ready for review.

How has this code been tested
make reviewable. I don't have the setup for IRSA at the moment. @haarchri Would you mind testing this with a v1 resource?

i can test this later today in our environment and give feedback - thanks

fix is working in our Environment tested kms key, eks addon and vpc endpoint
@stevendborrelli can you also check in your environment if its working ?

@haarchri thank you!


Adds Gateway API controller - nginx-gateway-fabric

In order to move from ingress to gateway api
we need to first need to add the gateway api controller and associated crds.
This commit adds the nginx-gateway-fabric controller.
JIRA: OSPC-298

@sulochan LGTM but this pr will need a rebase.

Done. Rebased.


Not work "pauseResume"

I want to stop the animation using this method, but the animation does not stop

Any issues concerning the pauseResume  method should be resolved in the latest release;
https://github.com/camoconnell/lazy-line-painter/releases/tag/1.6.3


Generated snippets for methods with resource names fail due to multiple matching overloads

Now that we generate GetFoo(FooName) and GetFoo(string), the generated snippets need to specify which parameter list they're using. Currently documentation generation is failing.

I now suspect this is only in manual code (error reporting) and not in the generated snippets at all. Will only close when that's confirmed though.

Pretty sure this is only manual code. Oops.


Update subscriptions.md - Updated FF Developer definition

Updated FF Developer definition
Thanks for contributing to the Harness Developer Hub! Our code owners will review your submission.
Description

Please describe your changes: __________________________________
Jira/GitHub Issue numbers (if any): ______________________________
Preview links/images (Internal contributors only): __________________

PR lifecycle
We aim to merge PRs within one week or less, but delays happen sometimes.
If your PR is open longer than two weeks without any human activity, please tag a code owner in a comment.
PRs must meet these requirements to be merged:

[ ] Successful preview build.
[ ] Code owner review.
[ ] No merge conflicts.
[ ] Release notes/new features docs: Feature/version released to at least one prod environment.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://66395cbaee9376535c5918e0--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://66396ce3e4a6425d35d2a5cc--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://66396d402788c45fad1f40b6--harness-developer.netlify.app


Update _tabs.mdx

Addressed this updated link and copy in this commit and moved the caveats inside a "notes" component.


Make Command+Click work in Monaco

For example, clicking a url in the editor should launch Safari.


[FLINK-11856][table-runtime-blink] Introduce BinaryHashTable to batch table runtime

What is the purpose of the change
(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)
This PR introduce a binary hash table to batch table runtime, preparing for the hash join operator.
Brief change log
(for example:)

Introduced binary hash table and some related stuff

Verifying this change
This change added some tests
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (yes)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)

cc @JingsongLi , i will do some code cleanup when introducing LongHashTable

+1 LGTM


Clarify errors on registrations

The validator registration endpoint currently takes a single registration with the understanding that relay muxers will send the registration to each relay they are aware of.
The spec for this endpoint returns a binary success/error response which precludes the case where a some relays succeed where others fail when processing a registration.
I think we want to erase this level of detail from the API in which case we don't need to change anything. For example, a caller of this endpoint who receives an error should assume the registration has completely failed and they need to try again (e.g. beacon node queues a retry for later). If they get a success, they should assume the responsibility on promulgating their registration is now with the muxer software (and the implication is that internally, the muxer may retry against transient relay failures, etc.)
If this is not the intended semantics, then we should extend the response so many errors can be returned.

I think if we assume the boost software will periodically submit the registrations upstream then the error model for the registerValidator endpoint is simply: 200 OK if this directly hop in the pipeline successfully got a copy of the data, and error otherwise.
If we use this error discipline then each hop (validator to mux to relay to builder and back) can return an error according to their local context and there doesn't seem to be any situation where it implies a "global" error that the validator needs to be aware of
Otherwise, we put the responsibility of managing resubmissions on the validator which we already said was the responsibility of the "sidecar" software (and I want to keep as much logic out of the validator as possible)

@realbigsean mentioned they implemented resending once per epoch into the Lighthouse validator client.
I'm not sure if it's best to move this functionality to mev-boost or have it in the validator and mev-boost simply to proxy it 🤔


Highlight sidebar links for URLs without explicitly-appended .html

[description]:

re: #3431
handle active sidebar highlighting for URLs without .html explicitly appended

This change is

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/59963417ffb0d6470415cb8ce9ebce5b5b7e16f7/

LGTM.


[Bug] ModuleNotFoundError: No module named 'kivymd.elevationbehavior'

ModuleNotFoundError: No module named 'kivymd.elevationbehavior'
When trying to import 'MDCheckbox' from kivymd.selectioncontrols, the above-mentioned error is raised. Upon further inspection, I realized that in line 15 of kivymd.selectioncontrols, the following import statement from kivymd.elevationbehavior import CircularElevationBehavior throws this error, as the module kivymd.elevationbehavior does not exist in the kivymd library.
Potential Fix/Workaround
Replace kivymd.elevationbehavior with kivymd.uix.behaviors
Other Errors and their fixes
Error:
ModuleNotFoundError: No module named 'kivymd.ripplebehavior'
Fix:
Replace kivymd.ripplebehavior with kivymd.uix.behaviors
Error:
Mispelled key 'Grey' - eg. colors['Gray'] results in KeyError: 'Grey'
Fix:
Replace all 'Grey' words with 'Gray'.
Code and Logs
File "xxx.py", line 19, in <module>
     from kivymd.selectioncontrols import MDCheckbox
   File "%APPDATA%\Python\Python38\site-packages\kivymd\selectioncontrols.py", line 15, in <module>
     from kivymd.elevationbehavior import CircularElevationBehavior
 ModuleNotFoundError: No module named 'kivymd.elevationbehavior'

Versions

OS: Windows 10
Python: 3.8
Kivy: 0.20
KivyMD: 0.104.1

@lemousehunter from kivymd,uix.selectioncontrols import MDCheckbox

@HeaTTheatR still doesnt work, throws ModuleNotFoundError: No module named 'kivymd.elevationbehavior'. It references the same file, "%APPDATA/Python/Python38/site-packages/kivymd/selectioncontrols.py" that kivymd.uix.selectioncontrols does.

@lemousehunter
Show the full log from start application to error.
Show the minimal code that leads to the error.

@HeaTTheatR python3 -m pip install --force-reinstall git+https://github.com/HeaTTheatR/KivyMD.git


BIDSify the single-subject dataset and upload to OpenNeuro/datalad

This one can be closed because data is already on openneuro.


Rewrite extension section of spec to reflect current behaviour

And reword/use notation consistent with rest of spec.

at least partially addressed by #791

Out of date


Fix bug when changing class in create controller

When creating a new object, the user might change between different subclasses.
The current behaviour of FObjectView is to copyFrom the old object to the
new one when the class changes, but this causes an often unwanted side
effect where default values of the first class chosen are copied to the
new class chosen instead of using the new class' default values.
This commit gets rid of that behaviour and simply creates a new instance
of the new subclass when chosen.

I’m on phone so I can’t see too much but this change will lose whatever
data was which is probably fine for create controller but for an update it
could clobber/clear the data. Is that desirable?
On Tue, Nov 26, 2019 at 2:30 PM Joel Hughes<EMAIL_ADDRESS>wrote:

Merged #2838 https://github.com/foam-framework/foam2/pull/2838 into
master.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/foam-framework/foam2/pull/2838?email_source=notifications&email_token=AB53ESAWMGIEAQODSKURLJDQVV2NDA5CNFSM4JR4XYAKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOVDPQSGI#event-2833189145,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB53ESEHEFFND6X7WWCRVV3QVV2NDANCNFSM4JR4XYAA
.

I’m on phone so I can’t see too much but this change will lose whatever data was which is probably fine for create controller but for an update it could clobber/clear the data. Is that desirable?

@mcarcaso You would be right, but we're not using FObjectView in DAOUpdateControllerView, just in DAOCreateControllerView. So you can't change the subclass after creation anyway (at least via the GUI (using those views)). So we don't come across that situation anyway.
That being said, I guess your question still applies to when FObjectView is used as the view of a property. In that case, I still think its desirable to drop changes instead of copying them over. It's kind of a toss-up whether the properties that are common between the different classes are ones you want to copy over or not. In the case of something like 'name', you would want to copy because that's not going to change. Anything with a default value (like CAD bank account has certain defaults that are different than the defaults of a USD bank account) is less likely to make sense to copy.
So the question is whether it's worse to have to re-input some data or lose the "correct" defaults. I think losing the correct defaults is worse because it's not clear to the user which properties have meaningful default values, and therefore they have no way of knowing what they need to change.
When I'm creating an account and I choose CAD bank account, a bunch of properties default to CAD-related values. When I switch the class to USD bank account, the CAD-related properties are copied over to the USD bank account object instead of using the USD bank account defaults. That seems worse to me than getting the right defaults and having to fill in a few fields again.

Nice description of the issues :)
I'm mostly indifferent on the behaviour. There are pros/cons to each
approach that you laid out real nice and the desired behaviour is pretty
context dependent. A flag on the view to let the developer choose the
behaviour could be useful? Another option would be to prompt the user and
have them decide if they want changes to be copied over when the class
changes?
Anyway, I'm ok with the changes you made and will leave it up to you if you
want to pursue something that can handle both scenarios but if there's no
need for it now, no sense doing it right away.
On Tue, Nov 26, 2019 at 3:45 PM Troy Wolters<EMAIL_ADDRESS>wrote:

I’m on phone so I can’t see too much but this change will lose whatever
data was which is probably fine for create controller but for an update it
could clobber/clear the data. Is that desirable?
@mcarcaso https://github.com/mcarcaso You would be right, but we're not
using FObjectView in DAOUpdateControllerView, just in
DAOCreateControllerView. So you can't change the subclass after creation
anyway (at least via the GUI (using those views)). So we don't come across
that situation anyway.
That being said, I guess your question still applies to when FObjectView
is used as the view of a property. In that case, I still think its
desirable to drop changes instead of copying them over. It's kind of a
toss-up whether the properties that are common between the different
classes are ones you want to copy over or not. In the case of something
like 'name', you would want to copy because that's not going to change.
Anything with a default value (like CAD bank account has certain defaults
that are different than the defaults of a USD bank account) is less likely
to make sense to copy.
So the question is whether it's worse to have to re-input some data or
lose the "correct" defaults. I think losing the correct defaults is worse
because it's not clear to the user which properties have meaningful default
values, and therefore they have no way of knowing what they need to change.
When I'm creating an account and I choose CAD bank account, a bunch of
properties default to CAD-related values. When I switch the class to USD
bank account, the CAD-related properties are copied over to the USD bank
account object instead of using the USD bank account defaults. That seems
worse to me than getting the right defaults and having to fill in a few
fields again.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/foam-framework/foam2/pull/2838?email_source=notifications&email_token=AB53ESEUHJ3XHAS2RH2UP6DQVWDEZA5CNFSM4JR4XYAKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFHMESQ#issuecomment-558809674,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB53ESFCKE4MMOWXJOFM33DQVWDEZANCNFSM4JR4XYAA
.


Add keyboard shortcut

It would be nice to have a keyboard shortcut to reload the extension.

@arikw Is Alt+r a shortcut? I use Alt+r on some of my ReactJS webpages to re-render the whole site. This stopped working recently. Now when I press Alt+r, I see the little green "OK" on Reload Extensions' toolbar button.

The answer is yes, Alt+r is a keyboard shortcut. If I remove the extension, then my ability to intercept Alt+r works in my app.

I created pull request #14 to add the info to the README.
It is probably worth noting that it defaults to Command-R on Mac, which means it both reloads the page and reloads extensions. It may be worth adding a different default for the Mac (like Opt-R).

Note, I corrected my previous comment. The default is Opt-r on mac.

Good idea!

Docs updated with the help of @studgeek. Thank you!


CERFA 12156*05 (pdf with forms) asks to be opened with Adobe reader

Attach (recommended) or Link to PDF file here:
cerfa_12156-05.pdf
Configuration:

Web browser and its version: Firefox Nightly 89.0a1 (2021-04-03) (64 bits)
Operating system and its version: Linux 4.19.0-1-amd64 #1 SMP Debian 4.19.12-1 (2018-12-22)
PDF.js version: firefox built-in, but reproducible on the online demo
Is a browser extension:

Steps to reproduce the problem:

Open cerfa_12156-05.pdf with pdf.js

What is the expected behavior? (add screenshot)

What went wrong? (add screenshot)

The form is a XFA and we're working to support them.
Anyway it's dup of #2373.


Application must be lauched first

i have already lauched.why have this tips?

seem need to wait a minute


When running  node build --all It fails (Error: Command failed: npm ci.)

I can't run node build --all it always failed Error: Command failed: npm ci.
I am using macbook pro M1. any idea whyl npm ci fails.
node version: v19.6.1
npm version: 9.5.0

Can you help to find out. I'm dealing with a few dozens issues daily, it's really hard for me.

It is weird i think this is an issue with silicon M1 chips, cause i can see that the script doesn't get passed npm ci (cp.execSync("npm ci", {cwd: './site', stdio: 'ignore'});) it stops here. i will keep looking to see if i can manage to fix this on my environment.
Thanks

@rabiibrahimi  I have a similar issue. What is the fix here?
node v20.0.0
npm v9.6.4

2023-04-19T19_45_58_125Z-debug-0.log

I made some progress here.
from
cp.execSync("npm ci", {cwd: './site', stdio: 'ignore'});
to
cp.execSync("npm ci", {pwd: './site', stdio: 'ignore'});
This gets me past the npm stage but now i'm getting an error on the next line
cp.execSync("grunt", {cwd: './site', stdio: 'ignore'});
I tried
cp.execSync("grunt", {pwd: './site', stdio: 'ignore'});
but that doesn't work. I see that Gruntfile.js in /site has a bunch of cwd references as well. Is this some issue on intel mac understanding cwd ?

i have solved it by downgrade node and npm so currently i use these versions:
node v16.19.1
npm 8.19.3
and it works now. guess it is issue with version compatibility.

Well, I’m glad the solution is on the internet somewhere now to save someone else hours of wasted time. Maybe Yuri can update the Readme to advise only node v16.*  npm 8.* is compatible for building or update this to use a more recent version of node.  Homebrew actually installs node and npm together when installing node package. On Apr 20, 2023, at 8:32 AM, Rabii Brahimi @.***> wrote:
i have solved it by downgrade node and npm so currently i use these versions:
node v16.19.1
npm 8.19.3
and it works now. guess it is issue with version compatibility.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: @.***>

You must have not installed it recently or without needing to install the chromium binary. npm will not resolve the chromium dependency.

I am using brew package manager. If you have any specific instructions on how to upgrade node and npm using brew so this works please advise.
From: Anthony Andriano @.>
Date: Thursday, May 25, 2023 at 1:16 PM
To: espocrm/ext-template @.>
Cc: czcpf @.>, Comment @.>
Subject: Re: [espocrm/ext-template] When running node build --all It fails (Error: Command failed: npm ci.) (Issue #14)
You must have not installed it recently or without needing to install the chromium binary. npm will not resolve the chromium dependency.
—
Reply to this email directly, view it on GitHubhttps://github.com/espocrm/ext-template/issues/14#issuecomment-1563317217, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AVBA57M7T3R6C34ILZ25QC3XH6OWBANCNFSM6AAAAAAVOTGVHA.
You are receiving this because you commented.Message ID: @.***>

I am usingnode v16.19.1npm 8.19.3And it works. It stops working when you go above that as far as I can tell. On May 25, 2023, at 2:06 PM, @.*** wrote:
@font-face { font-family: "Cambria Math"; }
@font-face { font-family: Calibri; }
p.MsoNormal, li.MsoNormal, div.MsoNormal { margin: 0in; font-size: 11pt; font-family: Calibri, sans-serif; }
a:link, span.MsoHyperlink { color: blue; text-decoration: underline; }
span.EmailStyle19 { font-family: Calibri, sans-serif; color: windowtext; }
.MsoChpDefault { font-size: 10pt; }
@page WordSection1 { size: 8.5in 11in; margin: 1in; }
div.WordSection1 { page: WordSection1; }
I am using brew package manager. If you have any specific instructions on how to upgrade node and npm using brew so this works please advise.
From:
Anthony Andriano @.>
Date: Thursday, May 25, 2023 at 1:16 PM
To: espocrm/ext-template @.>
Cc: czcpf @.>, Comment @.>
Subject: Re: [espocrm/ext-template] When running node build --all It fails (Error: Command failed: npm ci.) (Issue #14)
You must have not installed it recently or without needing to install the chromium binary. npm will not resolve the chromium dependency.
—
Reply to this email directly,
view it on GitHub, or
unsubscribe.
You are receiving this because you commented.Message
ID: @.***>

You must have not installed it recently or without needing to install the chromium binary. npm will not resolve the chromium dependency.

You are right, this was solved couple months for my Mac M1.

Once that was resolved, the process fails again:
I have had same and it was just database, before running node build --all MAKE SURE YOU HAVE CREATED A DATABASE IN MYSQL.

On an M1 mac, you have to do this:
export PUPPETEER_SKIP_CHROMIUM_DOWNLOAD=true

Once that has been done, it seems to work. Note: it is important to watch the log files in site/data/logs/. Node's output is useless once Espo has started running. For example, if a database isn't accessible, node fails without saying why, but Espo's log will at least mention sql errors.
Here is my setup:
M1 Max
Ventura 13.3.1(a)

node --version
v16.19.1

npm --version
8.19.3

composer --version
Composer version 2.5.6 2023-05-24 09:14:18

php --version
PHP 8.2.6 (cli) (built: May 10 2023 06:14:09) (NTS)


[Backport] Go update and fix of cve 44437 for rhods 1.33 patch

Go update and fix of cve 44437 for rhods 1.33 patch
fix: Upgrade the golang version and indirect dep net, grpc
https://github.com/opendatahub-io/kubeflow/commit/ddbc7053177efd5f9d549b671c763cbb6e6e6972
Related-to: https://github.com/opendatahub-io/kubeflow/issues/217

Merging this to be inline.


Some radiant chest can't having name

I can't put name or item on some radiant chest, but others chets work fine
ErrorLog: https://gist.github.com/GuerreroCraft61/845ad812a9ab8efe67e3c5aa028c8be8

Does this happen without Sponge?

So, this appears to be a tile entity that doesn't properly exist or cannot be resolved on the server. I'd recommend breaking the tile and re-placing it. I've added a more informative message in the next release.


'Submit feature request'

Problem
Would like to see a database option for Oracle since it’s very commonly used in Enterprise.
Suggested solution
Potentially adding a database option for Oracle.
Alternatives
N/A
Additional context
N/A

Feature request is tracked here: https://github.com/prisma/prisma/issues/2853


Subscription, item assignment, + fix for _cstd.py

would you mind adding something to the docs for what you added?

would you mind adding something to the docs for what you added?

for sure, let me know if there's anything i forgot to add in the docs

flake8 is getting mad once again, so ill fix that up before updating the package


prevent multiple calls to disconnect for serial and tcp

as discussed in one of the node-mbus issues here is my change to prevent multiple "disconnect" calls to make problems by checking it.

Does this prevent the segmentation faults?

We tracked the topic down to a topic in my own code where it happened that the mbus_disconnect method was called twice and then the segfault happened at thesecond call of "close(handle->fd);" So yes this change makes sure that "close" is only called once for a filedescriptor at all.
It simply make sure "bad user code" do not break anything


how can i realize multi level help

like this:
git --help
git commit --help
I can't find an example.
thx!

Sure, picocli makes that very easy. For example:
@Command(name = "git", mixinStandardHelpOptions = true,
        subcommands = GitCommit.class,
        description = "Commit stuff...")
class Git implements Runnable {
    public void run() { // business logic here
    }

    public static void main(String[] args) {
        new CommandLine(new Git()).execute(args);
    }
}

@Command(name = "git", mixinStandardHelpOptions = true,
        description = "Commit stuff...")
class GitCommit implements Runnable {
    public void run() { // business logic here
    }
}

See also the user manual section on Subcommands: https://picocli.info/#_subcommands
And examples in the project: https://github.com/remkop/picocli/tree/master/picocli-examples/src/main/java/picocli/examples/subcommands

@CanYouGiveMeAName I updated my answer. Did this answer your question?

Thanks a lot. I wil try.

@CanYouGiveMeAName I updated my answer. Did this answer your question?

Yes

@CanYouGiveMeAName Glad to hear that you were able to make progress!
Please star picocli on GitHub if you like the project! 😉


Reference-style links not working in notes

Reference-style links don't work in notes sections. (I.e. after a ??? on a slide). I tried all 3 styles:
1. [Remark][1]
2. [Remark]
3. [Remark][rem]

[1]: https://github.com/gnab/remark
[Remark]: https://github.com/gnab/remark
[rem]: https://github.com/gnab/remark

I previously had similar problems everywhere within slides (#161) but if I move the links outside of the notes section, they work. If I move them into the notes section, the just show as text, like [Remark][rem].

I assume this is another case where CommonMark will fix the problem. Although I'm a bit surprised that it's now working within the slides for me.

This is working now, as of the current version.


Issue with Scenecuts and Variance

Thank you for this great project @JasperLS, it looks truly amazing! Unfortunately, running the Colaboratory following the instructions result in errors for extracting Scenecuts and variance. The issues arise while using own files as well as the example file provided.
Exact errors is:
[PySceneDetect] Scene list CSV file name format:  Test_file-2_FrameLevel_scenes.csv
[PySceneDetect] Image output format set: JPEG
[PySceneDetect] Image output directory set:  /content/scene_imgs/Test_file-2/frames
[PySceneDetect] Detecting scenes...
0% 1/500 [00:00<00:21, 23.35frames/s]
Traceback (most recent call last):
File "/usr/local/lib/python3.8/dist-packages/click/core.py", line 792, in main
ctx.exit()
File "/usr/local/lib/python3.8/dist-packages/click/core.py", line 558, in exit
raise Exit(code)
click.exceptions.Exit: 0
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/local/bin/scenedetect", line 33, in
sys.exit(load_entry_point('scenedetect==0.5.2', 'console_scripts', 'scenedetect')())
File "/usr/local/lib/python3.8/dist-packages/scenedetect-0.5.2-py3.8.egg/scenedetect/main.py", line 58, in main
File "/usr/local/lib/python3.8/dist-packages/click/core.py", line 792, in main
ctx.exit()
File "/usr/local/lib/python3.8/dist-packages/click/core.py", line 404, in exit
self.close()
File "/usr/local/lib/python3.8/dist-packages/click/core.py", line 494, in close
cb()
File "/usr/local/lib/python3.8/dist-packages/scenedetect-0.5.2-py3.8.egg/scenedetect/cli/context.py", line 321, in process_input
File "/usr/local/lib/python3.8/dist-packages/scenedetect-0.5.2-py3.8.egg/scenedetect/scene_manager.py", line 603, in detect_scenes
File "/usr/local/lib/python3.8/dist-packages/scenedetect-0.5.2-py3.8.egg/scenedetect/scene_manager.py", line 498, in _process_frame
File "/usr/local/lib/python3.8/dist-packages/scenedetect-0.5.2-py3.8.egg/scenedetect/detectors/content_detector.py", line 110, in process_frame
TypeError: 'tuple' object does not support item assignment

Had the same issue but updating the scenedetect package to a version >0.6.0 fixed it for me!


Improve user menu

See commits. I think it looks better now.

The login button now looks very different from the new "you are logged in"-thingy.

Do you think that's bad? I think it's totally fine, maybe even good so that you immediately see whether you're logged in or not.

Clicking on the thingy twice briefly closes it, then opens it again. I would expect it to close it. thinking

That's a bug for a long time already. So... ye I guess I will still fix it this week in a follow up PR? :D

Do you think that's bad? I think it's totally fine, maybe even good so that you immediately see whether you're logged in or not.

Hmm, yeah, maybe you're right. :thinking:

That's a bug for a long time already. So... ye I guess I will still fix it this week in a follow up PR? :D

Fair enough.


How to change language ?

Really your project helps to me.how to chane logo bro.
Thanks

Well I stopped working on this project, maybe I will do it Later. Thanks


Support CopyJobs in BigQuery via a macro

Describe the feature
Support a copy_table macro in BigQuery, which takes advantage of BigQuery's CopyJob which is better optimized than, for instance select * {{source('my_source')}}.
The write disposition on the resulting table can be either append or truncate corresponding to materializations of incremental or table here, depending on how you want to modify the resulting table.
This should look like the following in a model:
{{ config(materialized='table') }}

{{ copy_table(ref('my_table')) }}

Describe alternatives you've considered
Just use select * here.
Additional context
Only interested in BigQuery for this issue, but if there are analogous features in other databases, they can be implemented as well, and possible this can become a global macro.
Who will this benefit?
Any BigQuery users who have step(s) in their SQL pipeline which simply copy data (ex. a release step, or curation that may leave some tables unchanged)
Are you interested in contributing this feature?
I have already written this and maintained it as a patch on a fork of dbt, but would love to upstream & share with anyone who can take advantage.

Thanks for the issue @kconvey, I'm supportive of adding this as an adapter method for BigQuery. I completely agree that it should take a relation as its argument. I imagine there should also be a check to confirm that the relation exists as a table (as opposed to a view or ephemeral model).
I'd be curious to hear a little more about the ways in which this is better optimized than select * from table, if you know them. I couldn't find anything after briefly checking the docs.
I think the closest comparable feature in another database is zero-copy cloning on Snowflake. The two feel different enough that we shouldn't try to implement them as adapter-specific versions of the same macro. (Also, Snowflake has a DDL interface for cloning, so it doesn't need to be an adapter macro.)

+1 to checking that the relation is table or incremental.
I don't know of any specific BigQuery implementation details that make copy_table taster than select * from table, but several months back I found it was a bit better when trying to speed up a pipeline which had an initial model that was a massive copy step, from which all other models derived. The pipeline also was originally written in python (before conversion to dbt), and included both BQ sql jobs and copy jobs at various points, so it was useful to have this feature parity in our fork of dbt when convincing the pipeline owners to switch to dbt.
Going to create a PR for this. Thanks for the triage!


Make Emote Wheel useful again

About the PR
Now emote wheel will be filled with emotes your species can soundplay.
Why / Balance
It was hell to find emote in this wheel.
Technical details
Added 3 new tags for species to determine emotions they can use.
Media

[X] I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

:cl:

fix: Emotes wheel will contain only your species emotions.

Summary by CodeRabbit

New Features

Enhanced capabilities for Harpy, Vulpkanin, and Felinid entities with new tags for improved interactions, including CanPilot, FootstepSound, DoorBumpOpener, and specific emotes.
Introduced whitelists and blacklists for vocal emotes to refine usage and restrict certain entities.
Added new tags in the system to improve organization and clarity.

Bug Fixes

Standardized naming conventions for vocal emotes to enhance consistency.

Chores

Renamed and reorganized various tags to improve clarity and functionality within the application.

I think it's unrelated check fail

it's always an unrelated check fail

it's always an unrelated check fail

I think it's because some problems with plasma cutter. I saw of bunch of errors related with it.


[Question] 我无法检测到星穹铁道的预下载

Checklist

[X] I have already read docs/Tips.md, but my question is not solved.
[X] My question was not mentioned by others, and it is not a duplicate question.

Description
我无法检测到星穹铁道的预下载

Starward Version
0.11.6
Windows Version
22631.3737
Log
No response
Additional Context
No response

米哈游更换了预下载的API，PR里面有一个更新，但是作者还没有合并进去。等作者打包之后更新吧。

#824已经提到过这个问题了。作者还没更，稍微等一下吧www
反正等到明天就不需要预下载了www

https://github.com/Eric-Joker/Starward/actions/runs/9568870284


Product Listing ignores mainVariantId

PHP Version
7.4
Shopware Version
<IP_ADDRESS>
Expected behaviour
On product listings, with filters applied, the previews should show the main variant that is configured on mainVariantId of product. This works well without filters but when there are option filters, then the resolve previews is ignored.
The problem is in this code on ProductListingLoader.php:
if (!$this->hasOptionFilter($criteria)) {
    list($variantIds, $mapping) = $this->resolvePreviews($ids->getIds(), $context);
}

The hasOptionFilter function checks for the optionIds filter on criteria and it is there when filters are applied on product listing.
Previews should always be resolved. If this covers another use case, then I suggest adding a configuration variable on the admin panel so we can control this behavior.
Actual behaviour
When filters are applied, variant previews are not resolved and so the product listing shows random variants instead of the main variant id.
How to reproduce
Perform filters and if configuration options are shown, the main variant id is not selected consistently. It has a random behavior and I suspect it depends on the order it is inserted in the database.

Hello luismarquesfreire,
thank you for your inquiry.
The behavior you describe is currently the desired behavior.
Example: A product exists in red and green variants, with the main variant green. If you now filter for red in the storefront, the main variant is ignored and only the variant that still matches is displayed.
If you want to change the behavior via a configuration, you are welcome to submit a feature request via our official issue-tacker issues.shopware.com/.
The responsible product owner will then look at the behavior and process it further.

I also think this is kind of an inconsistency: the user configures to see main Variants instead of products, this is a active step he is taking, but once filters are applied this configuration is completely ignored.
But the even bigger problem in my opinion is that once the user sets a filter, the result which is returned is even the wrong child:
In my query I request a specific ID:

But the resulting element has a different ID:

In my opinion this is a bug

Where is this mainVariantId stored in the db? I cannot find it

It is stored in the parentId column in the product table

1.5 years later and this topic is still ignored, what is going on, Shopware?  The current behavior is not as described by @taltholtmann .  If the main variant of a product has the option that is selected via filter, the filtered listing should STILL feature the main variant if that has been configured, yet it picks the displayed variant seemingly at random!  In other words, unfiltered I see the main variant (as configured), but if I then select a filter option that ALL variants of the product definitely have, then -sometimes- a completely different variant is featured in listing.  Why??  I assume it goes by order in the database, which might as well be random.  This makes no sense!  Guys, please reopen this ticket and fix this as soon as possible!  Thank you!

@taltholtmann

Hello luismarquesfreire, thank you for your inquiry. The behavior you describe is currently the desired behavior. Example: A product exists in red and green variants, with the main variant green. If you now filter for red in the storefront, the main variant is ignored and only the variant that still matches is displayed.
If you want to change the behavior via a configuration, you are welcome to submit a feature request via our official issue-tacker issues.shopware.com/.
The responsible product owner will then look at the behavior and process it further.

This is obviously not the case for most products.

Create a category with 1 product.
Give the main product size = M (variants will inherit)
Generate 4 variants by color (green, red, blue orange)
Go to storefront presentation and select green as main variant

Filtering in the category on the storefront where size = M, will show some random other colour.
How is this "intended behaviour"? We're not filtering by a property of a variant, we're filtering by a shared property.


Adding Support For RTL direction (flexDirection : 'row-reverse')

Hello ,
I've made app and it must support English and Arabic language. In Arabic language every thing should be from Right To Left directions. I was able to do many tricks to make this request except not able to find solution for Flex Box
I think it must to add support for flexDirection : 'row-reverse' to fix issue .

Looks like this was added in 0.29
https://github.com/facebook/react-native/commit/d43e0db81e86d4d03638cd17034086717fe715a3

I just upgraded the react and it's working great .. thank you

When I use flexDirection : 'row-reverse' in main view.  any sub view with style alignItems:'flex-end' .. should go to the left of main view
currently will go to the right of main view

Hi there! This issue is being closed because it has been inactive for a while.
But don't worry, it will live on with ProductPains! Check out its new home: https://productpains.com/post/react-native/adding-support-for-rtl-direction-flexdirection-row-reverse
Product Pains has been very useful in highlighting the top bugs and feature requests:
https://productpains.com/product/react-native?tab=top
Also, if this issue is a bug, please consider sending a pull request with a fix.

any solutions for horizontal flatlist in rtl?


Custom HTTP_USER_AGENT/HTTP_REFERER per monitor

Is it a duplicate question?
No.
Is your feature request related to a problem? Please describe.
No.
Describe the solution you'd like
Allow to set a custom user-agent and referrer for each monitor.
In my use case I have an image CDN that filters image loading by referer. If you access it without a referer or not the correct one, you get redirected to the homepage.
Describe alternatives you've considered
Currently I can only use Uptime Kuma to test for a 302 (the redirection that happens when you fail the referer check), but I can't check any other condition.
Additional context
N/A

I believe it is covered by #11.

You're completely right. I searched for those specific headers, so I didn't fine that issue. Sorry.


[WEB] plugin is blocked if use some ad blockers

Describe what happened
there is white screen after running app. Data dog logger wrap the whole app so when initialisation is failed running is also failing, in my case I just see white screen, no errors only this in console
App works correctly with some ad blokers(e.x. AdblockPlus)

Note! I guess it happens due to tracking part in the url
Steps to reproduce the issue:
run app on the WEB -> turn on ad blocker (I use uBlock Origin) -> refresh page
Describe what you expected:
Should work if someone turn on any ad blockers
Additional context

Dart/Flutter version: 3.7.9
Datadog SDK version: 1.2.1

Hi @AlehSabadashGmail ,
This isn't technically a bug in the SDK, but I'll see if I can look into it.  It doesn't appear uBlock Origin blocks 'tracking' by default though...
The good part is that tracking_http_client isn't necessary for web, since the Browser SDK does all the work.  If you enclose the call to enableHttpTracking in if (kIsWeb), tree shaking should remove the package import for you in release builds:
final configuration = DdSdkConfiguration(
  // your config
);
if (!kIsWeb) {
  configuration.enableHttpTracking();
}

Then I would just set an exception for localhost on your ad blocker.
Additionally, it's possible this is not an issue with packaged builds at all, as I believe the modules are compiled into one file instead of multiple.
Let me know if any of that works for you.

Hey @fuzzybinary
yeah, it works, thank you very much for your quick response, appreciate it


Update overflowBoundaryElement usage to use React's createPortal

Now that React 16 features can be used. Components should update to createPortal.
https://reactjs.org/docs/portals.html
This will simplify the Dialog code and remove the need for context explicit passing to Portal children.
This will also allow Enzyme testing out of the box.

This will also resolve issues with multiple nested overflowBoundaryElement components using the new PortalSettings component ( https://github.com/salesforce/design-system-react/pull/2867 )


Updates to support container resources

N.B. intention is to rebase and merge

N.B. The distributed-idol, idol-library-example-test and idol-stack Charts continue to reference dependencies via the local file system "repository"; don't know whether this is deliberate/correct in any/some/all of these cases, or in the scope of this change to address.

idol-library-example-test deliberately references via local file.
The others really ought not to, but not in scope for this PR (idol-stack really needs to be updated)


Portmaster - Sonic Mania shows black screen

Bug:
screen resolution of Sonic Mania does not fit to the screen. Editing fsWidth and fsHight for full screen doesn‘t change anything.
Ports description:
Following informations need to be added on the Wiki page:
Steam recommended (open your Library, Right-Click on Sonic Mania, click Properties, click Local Files, then click Browse...)
Select "Data.rsdk", copy it, and paste it into the folder „sonicmania“ of your ports.
Device:
RG351V
ArkOS 2.0 09052022
Portmaster 6.58

Settings.ini —> pixWidth above 400 (default: 320) shows full screen (black bars on the top and bottom)

If you go to video and turn full screen on, it fixes the issue but then sets the game into widescreen mode.  My understanding is that during gameplay, the default settings work fine for full screen on the 351v, just the menus are too big.  Not much we can do to fix that since the port is designed to work on widescreen devices, not 4:3.


Hang after loading first level 4 table on uefi

I tried my os on real hardware for the first time and found that the bootloader is hanging. I tracked the issue down to this line. I'm still a beginner in os development so any help is appreciated.
I am running it on my laptop which is a lenvo legion 7 which has a AMD Ryzen 7 5800H.

Hmm, there's not much to go on. How did you track this hang down to this line? Can you share the log output?

I cloned the repo locally, linked my kernel to the local version and added debug statements. I put 1 statement after the line I linked to and 1 after. Only the first 1 ran. The best photo I can add would be from my phone.

As you can see in the photo it no longer hang. Instead of only copying over the first entry of the old page table, I started copying over all entries and now it works. The panic you can see in the photo seems to be from the fact my system uses huge page table while the bootloader expects 4KiB tables. If you know, could you explain to me why copying over all the old entries would fix it.

The frame buffer (0xfc_1000_0000) is address is in the second pml4 entry, interesting, so the assumption in the comment was incorrect. Your fix seems reasonable. Freel free to open at PR.


added button like google facbook and X in sign up page

fix #123

https://github.com/user-attachments/assets/6adfeb70-ef5c-45cb-9915-72936fb4e379

@sagnik3788 merged this #123

@sagnik3788 please check the Pull Requested


I have bclib, obv, just for better nether and better end and they are great mods I don't want to exclude from my mod list, yes they require this Lib mod, and I get errors when I try to launch mc with it. I had a error where it told me my BCLib was 1.18.1 ver instead of 1.17.1, easy fix, get the latest 1.17.1 ver and delete the old one. Then when I launch my game crashes and gives me a exit code of 0 with no crash report. So I tried deleting it, then launching, this time fabric sees a problem and tells me better nether and end both require BCLib 0.5.5 or later for 1.17.1. Then I try to get 0.5.5 ( i used 0.5.6 on the last crash) for 1.17.1 and use that. that doesnt work.
So I will include the message I get, and my mods as screenshots below to hopefully help.

nvm, now it lets me


Is adding secondary certificate via portal on the backlog

I've been having trouble with adding a secondary certificate via ARM template for some reason.  I know it's not possible now, but are you looking at adding secondary certs via the portal?

Hi @msftjayongg,
Thanks for the question. The best place to check for this is in User Voice, where you can search for similar feature requests or make your own feature request that the product team can reply to directly. If you make a request and post the URL here I will upvote and help spread the word. https://feedback.azure.com/forums/34192--general-feedback

Hope this helps! We will now proceed to close this thread but if you have further questions feel free to post in Q&A or User Voice.


Assistance and RDP file parser fix

Fixed .rdp and .msrcIncident checks.
The command line detection fails, if only one of the aforementioned
files is used as an argument. Detect those first and ignore command
line detection if found.

this changes the behavior of the client. a command line with a .rdp file and additional arguments is not allowed any more.
DMWORD flags = 0;
still 0 when you get to:
CommandLineClearArgumentsA(args);
status = CommandLineParseArgumentsA(argc, (const char**) argv, args, flags,
settings,
freerdp_client_command_line_pre_filter,
freerdp_client_command_line_post_filter);
should be something like this from freerdp_client_detect_command_line:
/* Default is POSIX syntax */
*flags = COMMAND_LINE_SEPARATOR_SPACE;
*flags |= COMMAND_LINE_SIGIL_DASH | COMMAND_LINE_SIGIL_DOUBLE_DASH;
*flags |= COMMAND_LINE_SIGIL_ENABLE_DISABLE;

@jaccobraat See #4477


Feature request: expose IID COM constant and more in windows-sys

Motivation
I'm working to update the sysinfo to windows-sys instead of winapi and I'm missing some things:
Missing elements

IID (specifically for the windows::Win32::System::Wmi::IWbemLocator) is not in  windows-sys but is in windows
ULARGE_INTEGER

Drawbacks
No response
Rationale and alternatives
No response
Additional context
I remember something about the COM APIs not being in windows-sys voluntarily ?

I'm going to update the top comment with missing elements as I find them

https://kennykerr.ca/rust-getting-started/windows-or-windows-sys.html

So necessarily using windows, I don't think that'll go well for compile times sadly (I understand you can't do much about this)
@GuillaumeGomez, before I go any further, would you accept an MR going from winapi to windows ?

If it provides the same functionalities with no downgrade in performance or compilation time, all good for me.

Do give it a try. I am regularly findings ways to improve windows crate build time. Most recently #2360.

Thanks to you both, will do!


Allow setting instance tags for cloud providers

One thing I've noticed after looking through the docs here: https://registry.terraform.io/providers/iterative/iterative/latest/docs/resources/task#argument-reference
is that there is no way to assign a tag to an ec2 instance. This is often necessary for billing purposes, so it would be great if there were a way do this.
Thanks for the great work!

https://github.com/iterative/terraform-provider-iterative/pull/599

@mathematiguy, released with v0.10.14, should be available once the release workflow finishes running; you can upgrade by running terraform init --upgrade


Update the API specification to reflect the minimum number of inputs returned by selectCoins.

Issue
Related to #2244.
Overview
This PR updates the API specification for the selectCoins operation, changing the minimum number of inputs from 0 to 1 in the returned coin selection.
This matches the existing ApiCoinSelection type, which specifies a NonEmpty list of ApiCoinSelectionInput values:
data ApiCoinSelection (n :: NetworkDiscriminant) = ApiCoinSelection
    { inputs :: !(NonEmpty (ApiCoinSelectionInput n))
    , outputs :: ![ApiCoinSelectionOutput n]
    , change :: ![ApiCoinSelectionChange n]
    , certificates :: Maybe (NonEmpty ApiCertificate)
    } deriving (Eq, Generic, Show)

bors merge

bors retry


unable to connect kitematic to docker hub

Expected behavior
Actual behavior
Information about the Issue
Steps to reproduce the behavior

...
...

dear sir/madam
i want your help to give me suitable directions since i am trying to deploy
nginx and mysql database using docker
your sincerely
On Sun, Mar 1, 2020 at 4:01 AM docker-desktop-robot <
<EMAIL_ADDRESS>wrote:

Closed #5581 https://github.com/docker/kitematic/issues/5581.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/docker/kitematic/issues/5581?email_source=notifications&email_token=AOG47YMEG5GVE7264WJJBYDRFHFW3A5CNFSM4K6WLCHKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOW7SLIDY#event-3085218831,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AOG47YJHZRX5IN7HRMIRMSTRFHFW3ANCNFSM4K6WLCHA
.


Show pkg version before compilation

@igorklopov This is easy one. I would like to work on it. Version should be visible only in --debug or always?

Always please :)


Inconsistence in JSON returning from M2X call

Hi,
It appears that succesfull api calls returns status:20X field. While failed calls are returning statusCode:40X.
It would be great if the return field will have the same name, That way you don't need to do extra code on each call to parse for success,
I also found another exception:
The postValues  -https://m2x.att.com/developer/documentation/v2/device#Post-Data-Stream-Values
has a different way to return positive answer:
{ payload: { status: 'accepted' } }
instead 20X it return accepted.

@chenfli it appears that you are referring to an inconsistence in a client library and not the M2X service itself. Can you share which client are you using so we can track the inconsistence?

sure, I am for my implementation of m2x I use
https://www.npmjs.com/package/m2x
it is developed by @grilix / @seriousmoth , If this not the case on the rest API, than it needs to be fixed on that client.

@chenfli thanks for reporting this issue. I'll take a look into this.

@chenfli it looks like status is always available, here is a small example of some calls (being ./config the config from the client example)..:
var config = require("./config");
var M2X = require("m2x");
var m2xClient = new M2X(config.api_key);
var time = new Date().toISOString();

var callback = function(msg) {
  return function(res) { console.log(msg + ":", res.status); }; // display the response status, using 'status' for every response.
};

m2xClient.devices.view(config.device, callback("view device"));
m2xClient.devices.postValues(config.device, "load_1m", [{timestamp: time, value: 1}], callback("postValues"));
m2xClient.client.post("wrong-url", {}, callback("post wrong-url"));
m2xClient.client.post("/wrong-id", {}, callback("post wrong-id"));
m2xClient.client.get("wrong-url", callback("get wrong-url"));
m2xClient.client.get("/wrong-id", callback("get /wrong-id"));
m2xClient.client.get("/devices/" + config.device, callback("get /devices/" + config.device));

The output for this is:
post wrong-url: 404
get wrong-url: 404
post wrong-id: 403
view device: 200
get /wrong-id: 403
get /devices/1a27836313fb0741df2781f6aa2475b5: 200
postValues: 202

Can you please post some example code of what you are trying to do, so we can have a better picture of the problem?

@grilix I think I undersrand the problem, I think I looked to high in the JSON tree (looking only at a subset, msg.payload). I'll validate and close the issue.

validated


Maintainership

I like this package quite a bit, so I'd be happy to continue working on it. @snoyberg, if you think there is some conflict of interest I'll be OK with forking it, but I'd obviously prefer not to.

No problem at all, I've invited you as a maintainer.

Awesome. Thank you!


AMPI failing occasionally during migration in PUP of MPI_Info objects

Original issue: https://charm.cs.illinois.edu/redmine/issues/1792

On multicore-darwin-x86_64, in tests/ampi/megampi/:
$ lldb -- ./pgm +vp2 +p2
(lldb) target create "./pgm"
Current executable set to './pgm' (x86_64).
(lldb) settings set -- target.run-args  "+vp2" "+p2"
(lldb) r
Process 68449 launched: './pgm' (x86_64)
Charm++: standalone mode (not using charmrun)
Charm++> Running in Multicore mode:  2 threads
Converse/Charm++ Commit ID: v6.8.0-435-gfccd8e804
CharmLB> Load balancer assumes all CPUs are same.
Charm++> Running on 1 unique compute nodes (8-way SMP).
Charm++> cpu topology info is gathered in 0.002 seconds.
[0] RandCentLB created
[0] Testing: Testing...
[1] migrated from 1 to 0
[0] Testing: Testing...
[0] migrated from 0 to 1
[1] migrated from 0 to 1
[0] Testing: Testing...
pgm(68449,0x700000081000) malloc: *** error for object 0x5: pointer being freed was not allocated
*** set a breakpoint in malloc_error_break to debug
Process 68449 stopped
* thread #2: tid = 0x5b605, 0x00007fff91882f06 libsystem_kernel.dylib`__pthread_kill + 10, stop reason = signal SIGABRT
    frame #0: 0x00007fff91882f06 libsystem_kernel.dylib`__pthread_kill + 10
libsystem_kernel.dylib`__pthread_kill:
->  0x7fff91882f06 <+10>: jae    0x7fff91882f10            ; <+20>
    0x7fff91882f08 <+12>: movq   %rax, %rdi
    0x7fff91882f0b <+15>: jmp    0x7fff9187d7cd            ; cerror_nocancel
    0x7fff91882f10 <+20>: retq
(lldb) bt
warning: could not load any Objective-C class information. This will significantly reduce the quality of type information available.
* thread #2: tid = 0x5b605, 0x00007fff91882f06 libsystem_kernel.dylib`__pthread_kill + 10, stop reason = signal SIGABRT
  * frame #0: 0x00007fff91882f06 libsystem_kernel.dylib`__pthread_kill + 10
    frame #1: 0x00007fff8466b4ec libsystem_pthread.dylib`pthread_kill + 90
    frame #2: 0x00007fff92a6b6df libsystem_c.dylib`abort + 129
    frame #3: 0x00007fff89c8d041 libsystem_malloc.dylib`free + 425
    frame #4: 0x00000001000182c5 pgm`CkPupPtrVec<InfoStruct, CkPupAllocatePtr<InfoStruct> >::~CkPupPtrVec() [inlined] CkZeroPtr<KeyvalPair, CkPupAllocatePtr<KeyvalPair> >::destroy() + 18 at cklists.h:475 [opt]
    frame #5: 0x00000001000182b3 pgm`CkPupPtrVec<InfoStruct, CkPupAllocatePtr<InfoStruct> >::~CkPupPtrVec() + 4 at cklists.h:498 [opt]
    frame #6: 0x00000001000182af pgm`CkPupPtrVec<InfoStruct, CkPupAllocatePtr<InfoStruct> >::~CkPupPtrVec() [inlined] CkPupPtrVec<KeyvalPair, CkPupAllocatePtr<KeyvalPair> >::~CkPupPtrVec() + 15 at cklists.h:496 [opt]
    frame #7: 0x00000001000182a0 pgm`CkPupPtrVec<InfoStruct, CkPupAllocatePtr<InfoStruct> >::~CkPupPtrVec() [inlined] InfoStruct::~InfoStruct(this=<unavailable>) at ampiimpl.h:323 [opt]
    frame #8: 0x00000001000182a0 pgm`CkPupPtrVec<InfoStruct, CkPupAllocatePtr<InfoStruct> >::~CkPupPtrVec() [inlined] InfoStruct::~InfoStruct(this=<unavailable>) at ampiimpl.h:323 [opt]
    frame #9: 0x00000001000182a0 pgm`CkPupPtrVec<InfoStruct, CkPupAllocatePtr<InfoStruct> >::~CkPupPtrVec() [inlined] CkZeroPtr<InfoStruct, CkPupAllocatePtr<InfoStruct> >::destroy() + 13 at cklists.h:475 [opt]
    frame #10: 0x0000000100018293 pgm`CkPupPtrVec<InfoStruct, CkPupAllocatePtr<InfoStruct> >::~CkPupPtrVec() + 31 at cklists.h:498 [opt]
    frame #11: 0x0000000100018274 pgm`CkPupPtrVec<InfoStruct, CkPupAllocatePtr<InfoStruct> >::~CkPupPtrVec(this=<unavailable>) + 20 at cklists.h:496 [opt]
    frame #12: 0x000000010001a79f pgm`ampiParent::~ampiParent(this=<unavailable>, vtt=<unavailable>) + 287 at ampi.C:1395 [opt]
    frame #13: 0x000000010001ab55 pgm`ampiParent::~ampiParent() [inlined] ampiParent::~ampiParent(this=0x000000010201dc00) + 21 at ampi.C:1392 [opt]
    frame #14: 0x000000010001ab49 pgm`ampiParent::~ampiParent(this=0x000000010201dc00) + 9 at ampi.C:1392 [opt]
    frame #15: 0x000000010009c161 pgm`CkArray::deleteElt(this=<unavailable>, id=<unavailable>) + 225 at ckarray.h:525 [opt]
    frame #16: 0x0000000100094ffc pgm`CkLocMgr::emigrate(this=<unavailable>, rec=<unavailable>, toPe=<unavailable>) + 700 at cklocation.C:3143 [opt]
    frame #17: 0x00000001000956b4 pgm`CkLocRec::staticMigrate(LDObjHandle, int) [inlined] CkLocRec::migrateMe(this=<unavailable>, toPe=0) + 13 at cklocation.C:1927 [opt]
    frame #18: 0x00000001000956a7 pgm`CkLocRec::staticMigrate(LDObjHandle, int) [inlined] CkLocRec::recvMigrate(this=<unavailable>) + 6 at cklocation.C:2063 [opt]
    frame #19: 0x00000001000956a1 pgm`CkLocRec::staticMigrate(h=LDObjHandle ` 0x0000700000080c30, dest=0) + 17 at cklocation.C:2056 [opt]
    frame #20: 0x000000010012cb77 pgm`LBDB::Migrate(LDObjHandle, int) [inlined] LBOM::Migrate(this=<unavailable>, dest=0) + 49 at LBOM.h:37 [opt]
    frame #21: 0x000000010012cb46 pgm`LBDB::Migrate(this=0x0000000100605e00, h=LDObjHandle ` 0x0000700000080c90, dest=0) + 118 at LBDBManager.C:324 [opt]
    frame #22: 0x000000010010e9e1 pgm`::LDMigrate(_h=LDObjHandle ` 0x0000700000080cd0, dest=<unavailable>) + 65 at lbdb.C:399 [opt]
    frame #23: 0x000000010013d800 pgm`CentralLB::ProcessReceiveMigration() [inlined] LBDatabase::Migrate(dest=<unavailable>) + 624 at LBDatabase.h:345 [opt]
    frame #24: 0x000000010013d7a2 pgm`CentralLB::ProcessReceiveMigration(this=<unavailable>) + 530 at CentralLB.C:1170 [opt]
    frame #25: 0x0000000100140b11 pgm`CkIndex_CentralLB::_call_redn_wrapper_ProcessReceiveMigration_void(impl_msg=0x0000000100544410, impl_obj_void=<unavailable>) + 17 at CentralLB.def.h:920 [opt]
    frame #26: 0x0000000100083404 pgm`_processHandler(void*, CkCoreState*) [inlined] CkDeliverMessageFree(msg=0x0000000100544410, obj=0x0000000100605f60) + 23 at ck.C:597 [opt]
    frame #27: 0x00000001000833ed pgm`_processHandler(void*, CkCoreState*) [inlined] _invokeEntryNoTrace(obj=0x0000000100605f60) + 4 at ck.C:641 [opt]
    frame #28: 0x00000001000833e9 pgm`_processHandler(void*, CkCoreState*) [inlined] _invokeEntry(obj=0x0000000100605f60) at ck.C:659 [opt]
    frame #29: 0x00000001000833e9 pgm`_processHandler(void*, CkCoreState*) [inlined] _deliverForBocMsg(CkCoreState*, int, envelope*, IrrGroup*) at ck.C:1083 [opt]
    frame #30: 0x00000001000833e9 pgm`_processHandler(void*, CkCoreState*) [inlined] _processForBocMsg(CkCoreState*, envelope*) at ck.C:1101 [opt]
    frame #31: 0x00000001000833e9 pgm`_processHandler(converseMsg=<unavailable>, ck=0x0000000100741d90) + 2809 at ck.C:1267 [opt]
    frame #32: 0x0000000100160735 pgm`CsdScheduleForever [inlined] CmiHandleMessage(msg=0x00000001005443c0) + 34 at convcore.c:1646 [opt]
    frame #33: 0x0000000100160713 pgm`CsdScheduleForever + 211 at convcore.c:1888 [opt]
    frame #34: 0x0000000100160455 pgm`CsdScheduler(maxmsgs=<unavailable>) + 21 at convcore.c:1824 [opt]
    frame #35: 0x000000010015ae32 pgm`ConverseRunPE(everReturn=0) + 738 at machine-common-core.c:1442 [opt]
    frame #36: 0x000000010015e346 pgm`call_startfn(vindex=0x0000000000000001) + 102 at machine-smp.c:414 [opt]
    frame #37: 0x00007fff8466899d libsystem_pthread.dylib`_pthread_body + 131
    frame #38: 0x00007fff8466891a libsystem_pthread.dylib`_pthread_start + 168
    frame #39: 0x00007fff84666351 libsystem_pthread.dylib`thread_start + 13

Original date: 2018-02-06 17:18:06

This is showing up in some of the Jenkins builds for gerrit, but it only fails ~33% of the time on my machine.

Original date: 2018-02-06 17:28:08

Fix here: ~~https://charm.cs.illinois.edu/gerrit/#/c/3637/~~ https://github.com/UIUC-PPL/charm/commit/b322ece3df79d155b9c33a39f355329584cb6526
Our internal handling of MPI_Info's is pretty ugly, based on the use of CkPupPtrVec rather than std::vector. Cleaning that up is a slightly bigger task though.


Version property on output of Find-Module is a string

Whether this is intentional or the byproduct of an intentional change, the cersion property on output of Find-Module is now a string, and not a version.  This is painful : )
Expected Behavior
Version property from Find-Module is a System.Version
Current Behavior
Version property from Find-Module is a System.String
Possible Solution
No idea.  Might be intentional.
Steps to Reproduce (for bugs)
Use the latest PowerShellGet, look at output from Find-Module
Context
BuildHelpers is a module for helping builds.  Some folks use Get-NextPSGalleryVersion to determine the next version for their module, if they want to auto-increment.  Previously, this used a little logic to bump whatever the lowest increment would be (1.0.0 to 1.0.1, 1.0 to 1.1, etc.).  Now?  It returns 1.0.  Always.    So PSDeploy went from 0.2.6 to 1.0, for example.
I suspect some folks might be using appveyor images that don't include the new powershellget module (i.e. they might be saved from this), but... once they fix that, if I don't patch BuildHelpers, they're going to be publishing a lot of version 1.0 modules : )
I'll be patching BuildHelpers, and many folks don't pin versions so might avoid some pain.
Yeah, folks should probably manually bump things, but we tend to avoid manual work : )
Your Environment
AppVeyor image: Visual Studio 2017 at least.  Likely other systems using the latest PowerShellGet

@RamblingCookieMonster Yes, version property type got changed to string to enable prerelease versioning. For more details, please take a look at https://github.com/PowerShell/PowerShellGet/pull/185 .

Makes sense - thanks!


Adding custom color selector

Limits colors to 12 standard colors (and none) to make later sorting/graphing by flower color possible.
This closes #9

This includes testing for the custom color selector buttons to ensure visibility and make sure the color name gets passed correctly to the plant card when a plant is submitted.


Make sure all fields in a matrix questions are selected

Hi Andrew,
I have a question regarding the matrix question component.
Is it possible to use a validator to require at least one selected value per row?
I tried the following with no success:
https://gist.github.com/piscis/dd6293811300a0fd46abea3cda41d179
Thanks,
Alex

@piscis Unfortunately, there is no way to do it right now for the current version.
I will add isAllRowRequired property (default is false) into upcoming version. We will release it on this week.
Thank you,
Andrew

Hi Andrew,
thank you for the quick reply. I'm really looking forward to it!
All the Best,
Alex

It is included into v0.10.0

I tested this with the following question matrix:
https://gist.github.com/piscis/8833d4ba774953532db5d94d36c034c6
but somehow its not picking up the isAllRowRequired attribute.
I tried to rebuild the latest master but no luck

Using React: It looks like that setting isAllRowRequired on a ReactSurveyModel will not be propagated to the QuestionMatrixModel but I couldn't figure whats wrong.

Yes, sorry about that. I forgot to include the property into json serialization. It is done now. I have updated the example. I have added a checkbox to turn on/off this property.
Thank you,
Andrew


Action is unable to find tests

When using the action using ./, it's able to find the tests in the test.ts or spec.ts files.
However, when using the action with roerohan/vitest-github-action, it's not able to find the tests in the above mentioned files.
It's possibly some issue that's happening post the build.

For more details, check out this issue
https://github.com/vitest-dev/vitest/issues/3393


[expat] Fix build failure.

This fixes a build failure in the expat port due to VERSION no longer being set in the portfile. This was broken by #27547. I elected to hardwire the version numbers instead of reading vcpkg.json because vcpkg.json can have versions that are not expat versions, eg version-date.

What does your PR fix?
Fixes

CMake Error at D:/Plasma/CyanWorlds.comEngine/build/vc++2022-x64/vcpkg_installed/x64-windows-plasma/share/vcpkg-cmake-config/vcpkg_cmake_config_fixup.cmake:36 (message):

  'D:/Plasma/CyanWorlds.comEngine/vcpkg/packages/expat_x64-windows-plasma/debug/lib/cmake/expat-'
  does not exist.
Call Stack (most recent call first):
  ports/expat/portfile.cmake:26 (vcpkg_cmake_config_fixup)
  scripts/ports.cmake:147 (include)

error: building expat:x64-windows-plasma failed with: BUILD_FAILED

Which triplets are supported/not supported? Have you updated the CI baseline?
No change

Does your PR follow the maintainer guide?

Yes

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

No. Add this add at the top (until it arrives in a central place):
vcpkg_minimum_required(VERSION 2022-10-12) # for ${VERSION}

It will tell you if your vcpkg tool is too old.

Thanks for the tip. I've updated the PR to use the new functionality.

Thank you!


Parsing camera position

We're interested in doing some research on something called perception action cycles (defined as a shift in a player's point of view that exceeds a certain threshold in distance), as well as action latency (the time it takes them to perform an action after a shift in PoV). An earlier Starcraft II study found that these were good predictors of player skill and expertise. If you're interested in reading it the study can be found here:
http://journals.plos.org/plosone/article?id=10.1371/journal.pone.0075129
We've looked through your examples, read through a fair amount of previous clarity issues, and built the clarity-analyzer to try and better understand the protobuf jungle. We're now easily able to get player positions.
But from your clarity-analyzer we don't understand where exactly you're pulling the camera positions from (and it does seem like you are able to parse and visualize them). We'd appreciate it if you could help and save us some hours of trial and error by pointing us in the right direction :)

Hey, don't have much time, so just a quick headsup:
Code is here:
https://github.com/spheenik/clarity-analyzer/blob/master/src/main/java/skadistats/clarity/analyzer/main/MapControl.java#L88-L89
There are `CDOTAPlayer'-entities, one for each player, that have coordinates of the player screen. These coordinates are somehow projected in the real game, and I don't know how exactly, and in clarity-analyzer I basically show a rectangle using this point as the center.
HTH, do not hesitate to ask if you have more questions ;-)

Thanks for your help! We were able to get the camera positions.
My second question is whether you have any insight on which player actions go into a players "action per minute" calculation? Are they all contained in one place like dotaunitorder_t. Or do you think pings and addunitselections from ?EDotaUserMessages are also included in this?
The actions per minute calculation itself is not of that great importannce. We'd simply like to be able to extract the tick for each player action in order to get a sense for a players average "action latency" (the time it takes them to perform an action after switching PoV).
We're thinking these relevant actions are the dotaunitorders and the addunitselections. But we'd like to double check with you whether there are any other player actions hidden somewhere in clarity that we don't know about.

On the road and not much time. You have the mouse movement on CDOTAPlayer as well as CDOTAUserMsg_SpectatorPlayerClick and CDOTAUserMsg_SpectatorPlayerUnitOrders messages. Other than that, there's nothing iirc.

Thanks for taking the time @spheenik , we really appreciate it! We made a huge 200mb dump of everything in a replay (about the time you posted) to figure things out and noticed the SpectatorPlayer orders were prominent. And the sequence number for them divided with timestamp in minutes seemed to match up with actions per minute.
It's a bit difficult for us navigating around all this data without being familiar with it, but we're getting there. And I'm not the java dev among us so excuse me if the questions are not phrased as well as they could be :)


Unable to run cilium 1.10.2 via helm on ppc64le

Bug report
Trying to "Validate the Installation" I get the following errors:
NAME                              READY   STATUS                  RESTARTS   AGE
cilium-xyz                       0/1     Init:ImagePullBackOff   0          63m
cilium-operator-xyza       0/1     ImagePullBackOff        0          63m
cilium-operator-xyzb       0/1     Pending                 0          63m
coredns-a                        0/1     Pending                 0          3m52s
coredns-b           	       0/1     Pending                 0          3m52s
etcd-host4                      1/1     Running                 1          80m
kube-apiserver-host4      1/1     Running                 1          80m
kube-controller-manager-host4    1/1     Running                 1          80m
kube-proxy-abc                   1/1     Running                 1          80m
kube-scheduler-host4             1/1     Running                 1          80m
cilium-xyz                       0/1     Init:ErrImagePull       0          66m
cilium-operator-xyza   0/1     ErrImagePull            0          66m
cilium-xyz                       0/1     Init:ImagePullBackOff   0          66m
cilium-operator-xyza   0/1     ImagePullBackOff        0          66m
cilium-xyz                       0/1     Init:ErrImagePull       0          71m
cilium-operator-xyza   0/1     ErrImagePull            0          71m
cilium-xyz                       0/1     Init:ImagePullBackOff   0          71m
cilium-operator-xyza   0/1     ImagePullBackOff        0          71m
cilium-operator-xyza   0/1     ErrImagePull            0          76m
cilium-xyz                       0/1     Init:ErrImagePull       0          76m
cilium-operator-xyza   0/1     ImagePullBackOff        0          76m
cilium-xyz                       0/1     Init:ImagePullBackOff   0          76m
Looking at https://github.com/cilium/cilium/tree/master/images "multi-platform" Dockerfile is amd64 and arm64 (aarch64). Is ppc64le architecture unsupported?
General Information
cilium-cli: v0.8.4 compiled with go1.16.2 on linux/ppc64le
Linux host4 5.11.0-22-generic #23-Ubuntu SMP Thu Jun 17 00:25:44 UTC 2021 ppc64le ppc64le ppc64le GNU/Linux

Orchestration system version in use (e.g. kubectl version, ...)
Client Version: version.Info{Major:"1", Minor:"21", GitVersion:"v1.21.2", GitCommit:"092fbfbf53427de67cac1e9fa54aaa09a28371d7", GitTreeState:"clean", BuildDate:"2021-06-16T12:59:11Z", GoVersion:"go1.16.5", Compiler:"gc", Platform:"linux/ppc64le"}
Server Version: version.Info{Major:"1", Minor:"21", GitVersion:"v1.21.2", GitCommit:"092fbfbf53427de67cac1e9fa54aaa09a28371d7", GitTreeState:"clean", BuildDate:"2021-06-16T12:53:14Z", GoVersion:"go1.16.5", Compiler:"gc", Platform:"linux/ppc64le"}

Link to relevant artifacts (policies, deployments scripts, ...)
https://docs.cilium.io/en/stable/gettingstarted/k8s-install-helm/
https://helm.sh/docs/intro/install/
https://github.com/cilium/cilium-cli

How to reproduce the issue

helm install cilium cilium/cilium --version 1.10.2 --namespace kube-system
kubectl -n kube-system get pods --watch

Is ppc64le architecture unsupported?

At the moment, yes, it is not supported.

I think it would be reasonable to support ppc64le, but I'm not currently aware of anyone working on it. This is expected behaviour for now since it's not supported.


Use only annotated tags for version string

This is because latest is also used as tag for release purposes and
--tags option makes latest appears in version string.

Closed without prejudice.


Fixing typos in macro definitions for CO_NO_LSS_*

Simple edit to correct some macro definitions that had typos. Specifically CO_NO_LSS_MASTER and CO_NO_LSS_SLAVE should be CO_NO_LSS_CLIENT and CO_NO_LSS_SERVER.
Also removed a spurious parenthesis that I think was an accident for CO_NO_TRACE while I was at it.

How did this get in? Was originally "CO_NO_LSS_SERVER" / "CO_NO_LSS_SERVER"?

Looks like commit ae48e57 accidentally added the wrong names.

It is my typo.
I renamed some files and I wanted to make things consistent with standard. Standard uses client/server for SDO and master/slave for LSS and NMT.
But I didn't want to change CO_NO_LSS_SERVER/CLIENT yet, because it depends on libedssharp (I think). So I meant to leave this as it was for now, but made a typo with includes. I wanted to discuss this a little when new OD will be actual.

For what it's worth, the CO_OD.* code is already starting to not be compatible. The #include directives no longer find the header files. I think if you want to change the naming scheme you could just go for it on this branch and it can drive the changes on libedssharp when it gets updated for includes maybe.

Actually CO_OD.* code is still perfectly compatible. Except my typo.

I'll have to check which commit my libedssharp is at. I swear I thought I pulled the latest and it didn't generate #include "301/CO_SDOclient.h". I'll try again

Yeah, as of this commit it still seems to show it's using the old headers. I think you updated your examples but I was saying libedssharp already needs updating so there's probably no reason to let that hold you back from mass updating the macros.

I try not mix to much two steps: split-driver and new-OD.

Agreed, that's a good idea.

I fixed my typos with last commit, where I also added some more documentation, especially ChangeLog. Confusion with server/slave will be solved with newOD.
For now headers in CO_OD.c will have to be edited manually. It is mentioned in readme. Othervise I think, libedssharp stays comaptibile.
Thank you for your corrections, you are very up-to-date.


Improve accesibility making leyboard navigation to work following the CSS order

This pull request implements a focus trap functionality to make a custom keyboard navigation using the arrow keys or through tabs to follow the CSS order instead of the DOM order.
Previously, trying to navigate through the sidebar items using the keyboard led to an unordered navigation due to the fact that it followed the DOM order not the CSS order of the elements.

Before
After

coverage: 100.0%. remained the same
when pulling 8e8036769ae65d4ed06a4738d74312e19abdfb27 on focus_trap
into 56d9668b691be714805ece8d86807731e66ec01a on master.


Changing profile at runtime with MixedRealityToolkit.Instance.ActiveProfile = profileToUse; throws NullReferenceException

Describe the bug
When attempting to set a profile at runtime by following these instructions, a null reference error is thrown.
To reproduce
Steps to reproduce the behavior:

Configure and save an MRTK profile
Give the script a public MixedRealityToolkitConfigurationProfile named profileToUse
Include MixedRealityToolkit.Instance.ActiveProfile = profileToUse
Set profileToUse to the previously saved MRTK profile in Unity Inspector
Run in play mode to get the error

Expected behavior
The MRTK profile should switch easily.
Screenshots

Your setup (please complete the following information)

Unity Version 2020.3.36f1
MRTK Version v<IP_ADDRESS>

Target platform (please complete the following information)

Oculus Quest 2

@nutmeg15
Hello. You can use MixedRealityToolkit.SetProfileBeforeInitialization if you want switch profile before initialization
using Microsoft.MixedReality.Toolkit;
using UnityEngine;

public class PreInitProfileSwapper : MonoBehaviour
{
    [SerializeField]
    private MixedRealityToolkitConfigurationProfile newProfile;

    void Awake()
    {
        MixedRealityToolkit.SetProfileBeforeInitialization(newProfile);
    }
}

Please use MixedRealityToolkit.Instance.ActiveProfile = profileToUse at runtime if you have active profile.
Also you have [DefaultExecutionOrder] attribute to set Awake/Start call before/after other scripts. Like this:
[DefaultExecutionOrder(-1)]
public class PreInitProfileSwapper : MonoBehaviour
{

Have a nice day 😊

Also I checked it again and got error stack when I have active MixedRealityToolkit Inspector. I sent micro changes for this issue


⚠ Bofrost.be has degraded performance

In 96c1673, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1320 ms

Resolved: Bofrost.be performance has improved in d30f4ec.


Stripe SCA updates

Updates the Stripe payment providers to accommodate for the SCA changes coming into effect in September.
There has been quite a fundamental change with how these work now in that orders are not finalized inline, instead these are finalized in response to a webhook request so there are going to be some changes in implementation required. An addition, the front end view has had some pretty major JS updates as there isn't really consistent approach for one off vs subscription payments.
Docs are still currently required also.

I am struggling to complete a payment with the new stripe payment provider.
So far I have:

Pulled the latest master branch of the Payment Providers
Upgraded Tea Commerce to 3.3.1
Updated the Stripe.Net Nuget package to version 26.0 in my main web project
Followed the instructions at https://docs.teacommerce.net/3.3.1/payment-providers/stripe/#configure-stripe to set up stripe webhooks
Sent a test notification from the stripe dashboard to confirm that the request arrives on my server correctly.

I am running Stripe in test mode (Configured in Umbraco backoffice)
When I run through a payment in Stripe I can trace the following web requests

api.stripe.com/v1/tokens
This returns json containing the token id for the test card and looks ok
POST /base/TC/PaymentContinue/1/Stripe%20-%20inline/[Order-Id]
The form data contains the card details and token from the previous request.
The user is then redirected to the ContinueUrl

No charge requests are sent to the stripe api. If I remember correctly I would expect a charge to be sent between 2 and 3 above.
I'm not sure how to continue to investigate this issue and why charges are not being created. Any help would be greatly appreciated.

Hi @twaddell, happy to help but as this is a support request could you raise this as a question on the support forums please https://our.umbraco.com/packages/website-utilities/tea-commerce/tea-commerce-support/
Many thanks
Matt

@mattbrailsford Sorry for posting in the wrong place. Having review some other posts in the support area, I have fixed my issue. I had not copied the StripePaymentForm.cshtml correctly into my main project.

@twaddell ahh, great. Glad you were able to find the solution 👍


i2c_mcux_flexcomm: add transaction timeout option

With the device_sync_sem semaphore, there is the possibility of the code not returning to give it back (mcux_flexcomm_master_transfer_callback is never called), causing it to get stuck in k_sem_take(&data->device_sync_sem, K_FOREVER) in subsequent calls.
The i2c driver recovers by other means (enabling FSL_FEATURE_I2C_TIMEOUT_RECOVERY) but the callback might not return.
Adding a timeout option allows for this occurrence to be avoided.

Hi @guicnDell ,
Thank you for contributing.  Can you please fix the compliance issues?


Upgrade to latest parent, apply import ordering from this

Relies on https://github.com/HotelsDotCom/hotels-oss-parent/pull/34/files and demonstrates how this will sort out the import ordering as a bunch of files have made it in in the past without us spotting the import order differences.

Coverage remained the same at 75.157% when pulling e73d2c5b6e34b1b7ea4b6c3dd30f0c424aae367e on parent-4-2-1 into 9e1da5e3ac3f51afb50f6f6e29291299b1c732df on master.