How to observe AsyncShellTask for user input required

What is the best way to observing an AsyncShellTask to understand if it's waiting for user input?
Example
An external script is launched via SwiftShell by using runAsync such that the execution can return immediately. Although, the script could require some user input during its execution. How can we receive a callback for this event such that the application can properly ask to the user the required input?

Hi, good question. I will take a look when I get back in 2 days. Just a couple of questions:

are you using SwiftShell from a command-line application/script or a GUI application?
which version of macOS or Linux?
is the external script launched using bash?

are you using SwiftShell from a command-line application/script or a GUI application?

I'm using it as part of we WebSocket API I'm building. The user triggers the action and the result, or pending input, are sent back on the socket.

which version of macOS or Linux?

I'm planning to run my application on macOS 10.11.6

is the external script launched using bash?

It can be multiple tasks. In scope there is git command and some ruby executable application. Does this answer your question?
If you have any input I could investigate to help you with this, let me know :)

This is something like what I had in mind. The problem is the closure you assign to onInput will be called many many times, even if the script/command you are running is not asking for input (that is not pulling its standard input). Se the aptly named testFoundationWriteabilityHandlerBeingCalledWhenNoInputIsAskedFor unit test.

You will in any case also have to check the stdout of the command to see what input the script is asking for. Also I think many commands will wisely not ask for input if its stdin is not a terminal session. So we will have to trick them into thinking our filehandle actually belongs to a terminal.

I don't know how to be notified only when and if a command asks for input. I'm leaving this open in case someone else does.

Are there any updates on this? I also need this for Mint https://github.com/yonaskolb/Mint/issues/37

I implemented stdin in cmdshelf.
You might be interested to the implementation, so FYI.👋
https://github.com/toshi0383/cmdshelf/blob/master/Sources/cmdshelf/Functions.swift#L10
The function name is "shellOut", but not using JohnSundell/ShellOut.

I don’t know any more about this than I did 1 year ago I’m afraid. FileHandle’s writeabilityHandler seems like the right tool for the job but I couldn’t get it to work properly. You can see my attempt here: https://github.com/kareman/SwiftShell/compare/writeablestream-oninput


ho to rebuild ctags under windows 10

H:
I hope to rebuild ctags under windows 10 to make the ctags can support
javascript better, but I don't know how to do that exactly,
is any one know to to make that, any suggestion is highly appreciated, thanks
a lot.

This plugin just executes ctags and works with content it gets.
Any question with regards to language support should be asked in a ctags related forum or at ctag's repo.


Is this still being actively developed

Is PGRestAPI still being actively developed? And are there plans to incorporate some of the more recent Mapnik developments, e.g. Node Mapnik v3.5?

I am no longer actively developing PGRestAPI.
From:  shongololo
Reply-To:  spatialdev/PGRestAPI
Date:  Thursday, July 7, 2016 at 6:45 AM
To:  spatialdev/PGRestAPI
Subject:  [spatialdev/PGRestAPI] Is this still being actively developed (#142)
Is PGRestAPI still being actively developed? And are there plans to incorporate some of the more recent Mapnik developments, e.g. Node Mapnik v3.5?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Are there any offshoots or alternatives that you would recommend for the long run?

On 7 Jul 2016, at 17:28, Ryan Whitley<EMAIL_ADDRESS>wrote:
I am no longer actively developing PGRestAPI.
From: shongololo
Reply-To: spatialdev/PGRestAPI
Date: Thursday, July 7, 2016 at 6:45 AM
To: spatialdev/PGRestAPI
Subject: [spatialdev/PGRestAPI] Is this still being actively developed (#142)
Is PGRestAPI still being actively developed? And are there plans to incorporate some of the more recent Mapnik developments, e.g. Node Mapnik v3.5?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.


Jupyter Lab Component Refactor

Support for Kernels

[x] Python
[x] R
[x] Julia

cc: @manskx can I have a review from you?


Add configurable line of who to contact to main screen

Once people deploy the app in their orgs, if they need help they should be able to contact whoever deployed it.

put a placeholder in the main screen


Incorrect value in one instance of postcode in MCS installations

Value of 1111111

when this is sorted the function extract_token_set() in process_mcs_utils.py doesn't need the first if anymore.


Update package.js to avoid conflict with accounts-facebook

I believe<EMAIL_ADDRESS>is now using<EMAIL_ADDRESS>while currently meteor-apollo-accounts is using facebook package.
This has caused the oauth service to register twice which then fails the application with the following error:
https://github.com/orionsoft/meteor-apollo-accounts/issues/46

Can someone test this? Does this work with older versions?

Hi @nicolaslopezj, I only tested with Meteor 1.4.4, which is the latest.

Tested on <IP_ADDRESS> and works

Thanks for the PR, but now the package does not depends on facebook at all

@nicolaslopezj thats great!


WIP: Make libvirtError public and add Code and Domain consts

Closes #121 #56
Resurrection of PR #57
---- Original Commit Message ----
In order to allow fine-grained error handling:

change libvirtError to LibvirtError and implement the error interface.
extract Code and DomainID constants from libvirt sources

Signed-off-by: Roman Mohr<EMAIL_ADDRESS>---- End ----

Given the number of commits and the addition of an error handling case IsNotFound and related consts I think it's easier to start fresh rather than from the original PR. Closing.

Given the number of commits and the addition of an error handling case IsNotFound and related consts I think it's easier to start fresh rather than from the original PR. Closing.

nice @kskewes  that you started working on this that is great.

nice @kskewes  that you started working on this that is great.

I was about to initiate also a PR but since you took the ownership on the old pr I will let you continue working on this. :flower_playing_cards:

I was about to initiate also a PR but since you took the ownership on the old pr I will let you continue working on this. :flower_playing_cards:

Thank you but by all means please go ahead.
I had a look but I think it's better to start fresh given the activity over past two years since the previous PR.

Thank you but by all means please go ahead.
I had a look but I think it's better to start fresh given the activity over past two years since the previous PR.


[SPARK-30447][SQL] Constant propagation nullability issue

What changes were proposed in this pull request?
This PR fixes ConstantPropagation rule as the current implementation produce incorrect results in some cases. E.g.
SELECT * FROM t WHERE NOT(c = 1 AND c + 1 = 1)

returns those rows where c is null due to 1 + 1 = 1 propagation but it shouldn't.
Why are the changes needed?
To fix a bug.
Does this PR introduce any user-facing change?
Yes, fixes a bug.
How was this patch tested?
New UTs.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/21040/
Test PASSed.

Test build #116247 has started for PR 27119 at commit 426fa7b.

I extracted this bug fixing part from https://github.com/apache/spark/pull/24553, its easier to review.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/21041/
Test PASSed.

Test build #116247 has finished for PR 27119 at commit 426fa7b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/116247/
Test PASSed.

@cloud-fan, @maropu, @dongjoon-hyun could you please help me and review this PR?

good catch! Can we add an end-to-end test in SQLQuerySuite to show the wrong result?

Test build #116403 has started for PR 27119 at commit c8f28d7.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/21194/
Test PASSed.

good catch! Can we add an end-to-end test in SQLQuerySuite to show the wrong result?

Sute, I've added it.

Test build #116405 has started for PR 27119 at commit 713b35c.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/21196/
Test PASSed.

Test build #116403 has finished for PR 27119 at commit c8f28d7.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/116403/
Test PASSed.

Test build #116405 has finished for PR 27119 at commit 713b35c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/116405/
Test PASSed.

LGTM. Pending, Jenkins.

Test build #116462 has started for PR 27119 at commit c8a21cc.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/21249/
Test PASSed.

Test build #116462 has finished for PR 27119 at commit c8a21cc.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/116462/
Test FAILed.

@cloud-fan @maropu @dongjoon-hyun , do you think it makes sense to continue working on ConstantPropagation? You know, I extracted this PR from a bigger one: https://github.com/apache/spark/pull/24553 that would add 2 improvements. That PR is still WIP and requires a lots of new UTs. Actually, I'm happy to work on it if someone is interested in giving some feedback now or when it is ready.

retest this please

Test build #116466 has started for PR 27119 at commit c8a21cc.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/21253/
Test PASSed.

Test build #116466 has finished for PR 27119 at commit c8a21cc.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/116466/
Test PASSed.

Merged to master.

@peter-toth Can you make a pr for branch-2.4? That's because I could not merge this cleanly into branch-2.4.

@peter-toth Can you make a pr for branch-2.4? That's because I could not merge this cleanly into branch-2.4.

Here it is: https://github.com/apache/spark/pull/27167

+1, late LGTM. Sorry for being late, @peter-toth .


JDBCBackend.del raises ignored exception when JVM has shut down

I installed message-ix and then I verified the installation by the following command:
$message-ix show-versions

but after using the following command,the system showed me the following error:
$message-ix --platform=default list

Dear @khaeru
Thank you for your comment.
Should I use JDBCBackend to solve the problem?how?
Regards

Should I use JDBCBackend to solve the problem?how?

To repeat what I said, in different words: there is no problem. The software is working fine. The "error" message doesn't affect anything.
However, I agree the message is a little annoying or confusing. I am opened the linked pull request, #378, which will hide the message. But, again, since this does not affect the operation of the software, you can continue to use it. Just ignore the message.
Please let me know if that is not sufficiently clear.


TSX files are identified as TypeScript rather than JSX+TS

Preliminary Steps
I confirm I have...

[x] reviewed How Linguist Works,
[x] reviewed the Troubleshooting docs,
[ ] considered implementing an override, not applicable
[x] verified an issue has not already been logged for your issue (linguist issues).

Problem Description

Files with the extension .tsx (and code blocks with language identifier tsx) on GitHub are shown as TypeScript instead of TypeScript+JSX.
URL of the affected repository:
https://github.com/rainboxx/tsx-jsx-repro/tree/master
Last modified on:

2018-12-21
Expected language:

JSX, although I'm not sure whether there needs a new language that combines TS+JSX
Detected language:

TypeScript

This issue is still relevant. The issue can still be seen here: https://github.com/rainboxx/tsx-jsx-repro/tree/master

Hi @lildude, .tsx is the "official" extension when using JSX with TypeScript, see https://www.typescriptlang.org/docs/handbook/jsx.html. I'm not aware of other usages, a quick look revealed that CoffeScript is using .cjsx or sticks to .coffee, see: https://coffeescript.org/#jsx.
There seems to be a "Team Sports Scheduling System XML Project File" with the suffix tsx which is likely less prominent that tsx as TS+JSX.
I think it's the same way "not a language" as JSX itself is not a language. From my (limited) perspective I'd treat this topic as that if there's support for JSX itself it should also be supported within all the other languages. What do you think?

.tsx is the "official" extension when using JSX with TypeScript, see https://www.typescriptlang.org/docs/handbook/jsx.html.

Hmmm, now I'm confused. What problem are you pointing our or what are you requesting in this issue?
From your OP I took it that you were asking for Typescript files with JSX within them be identified as "Typescript + JSX" instead of just "Typescript", and thus would warrant an equivalent for "Javascript + JSX" (perfectly valid AFAIK) and any other Javascript-like language which can or do use JSX.
As it currently stands, .tsx files are already classified as Typescript as can be seen in your example and is inline with the sentence above.
.jsx files are currently identified as JSX but this language is currently grouped under Javascript, hence the second file in your example is identified as "Javascript".

I think it's the same way "not a language" as JSX itself is not a language. From my (limited) perspective I'd treat this topic as that if there's support for JSX itself it should also be supported within all the other languages. What do you think?

I'm pretty sure this already happens in some form or another as it stands.

.tsx is the "official" extension when using JSX with TypeScript, see https://www.typescriptlang.org/docs/handbook/jsx.html.

Hmmm, now I'm confused. What problem are you pointing our or what are you requesting in this issue?

Sorry for being confusing 😉. I wanted to point out that the suffix is official because I interpreted your reply as "we shouldn't give tsx too much attention because it's arbitrary".
Your resumé is straight to the point, except that I would clarify that "Typescript files" have the suffix ts while "Typescript files with JSX within" have tsx.

I'm pretty sure this already happens in some form or another as it stands.

Maybe I'm getting you wrong (not a native english speaker), but the current rules are:

js is identified as JavaScript
jsx is identified as JSX (grouped under JavaScript because it's a syntax extension to ES/JS)
ts is identified as TypeScript
tsx is still identified as TypeScript

The TypeScript syntax is highlighted in tsx files works. JSX inside it doesn't break the highlighting but it's also not highlighted correctly. I find it confusing that the relationship between js and jsx is different than between ts and tsx and expected jsx and tsx to work respectively.
I assume I'm just repeating what you already know 😉.
Are you saying you don't want to implement a special sub-language TS+JSX because you'd also have to implement CoffeeScript+JSX? About false-positives: I could think of false-positives in combination with any language that embeds JSX without a special suffix (eg. CoffeeScript with .coffee) but can't imagine a false-positive with TS+JSX when the .tsx suffix is used.

The TypeScript syntax is highlighted in tsx files works. JSX inside it doesn't break the highlighting but it's also not highlighted correctly.

This is going to be a problem with the syntax highlighting grammar and not Linguist, and is very similar to a long running issue we already have for JSX syntax highlighting - https://github.com/github/linguist/issues/3044

I find it confusing that the relationship between js and jsx is different than between ts and tsx and expected jsx and tsx to work respectively.

That is indeed confusing and it's not likely to stand for much longer. We're likely to roll .jsx into Javascript at some point as we do for .tsx right now as...

Facebook (more specifically, Dan Abramov) decrees that the .jsx extension is no longer relevant since the pre-Babel days. His reasoning is pretty solid.
facebook/create-react-app#87 (comment)

... from https://github.com/github/linguist/pull/3677#issuecomment-440303127 and then further acknowledged by @Alhadis at https://github.com/github/linguist/pull/3677#issuecomment-440536127:

I'm not sure why we're even bothering to differentiate between JS and JSX anymore, actually. Since it falls under the usage statistics of the former, we may as well roll it into the JavaScript entry and spare ourselves the hassle over semantics.
Since JSX is a superset of JavaScript, it should be possible for one grammar to accommodate both JS and sugary extensions like embedded XML and type annotations. Moreover, Linguist has no way of knowing if something like this is a JS or JSX file...

The same arguments are likely arise if we split .tsx out from Typescript. We're also rethinking the language groups idea too.

Are you saying you don't want to implement a special sub-language TS+JSX because you'd also have to implement CoffeeScript+JSX?

Yes, but also because it shouldn't be needed if we stop treating JSX as its own language and start treating it as a sub-set of Javascript that it apparently is.

I'm totally in favor of bringing .jsx into JavaScript 👍.
However, could there still be some plans to still support JSX highlighting inside of TypeScript? JSX, according to https://facebook.github.io/jsx/, is an "XML-like syntax extension to ECMAScript" and therefore not exactly a sub-set of JavaScript. Because of this the "syntax extension" can also be used with TypeScript.
This is a very valid use-case when using React in combination with TypeScript and I would really love to see this syntax change happen.

However, could there still be some plans to still support JSX highlighting inside of TypeScript?

I don't see why not, however this would be up to the grammar maintainer to implement, not Linguist (we only do the language determination), or for another grammar to be sourced that has JSX support.

Ok, so the whole ticket here is basically not relevant to linguist? And I should ask the grammar maintainer for TypeScript... Right?

Ok, so the whole ticket here is basically not relevant to linguist? And I should ask the grammar maintainer for TypeScript... Right?

Yup, essentially, but you'll please to know I'm in the process of making a new release for Linguist and it includes an update to the TypeScript grammar which from my quick local testing takes your sample foo.tsx from:

... to ...

Whilst not as pretty as the sample jsx grammar, it appears to be an improvement. If you want further improvements, then the grammar itself is the place to take your requests.

Thanks for letting me know about the change!
I quickly checked the grammar repo and saw that this grammar is also in use within VS Code. That application detects JSX inside of .tsx files pretty well:

(I fixed the sample code on GitHub as well but it still shows as before.) VS Code just highlights through TypeScript that react and component Foo is missing.
Any idea how to investigate this further?

@rainboxx you've really piqued my interest in getting to the bottom of this 😄
I've been experimenting with the TypeScript grammar in Lightshow and I think the issue here is the TypeScript repo actually provides four grammars with the two we're interested in being TypeScript and TypeScriptReact. These grammars do not source/include each other and as such are treated as different languages.
GitHub is using the Typescript grammar to highlight your foo.tsx as Linguist is identifying the language as TypeScript whilst VSCode is using TypeScriptReact as it is identifying the language as "TypeScript React". You can see this in the bottom right of your VS Code window:

If I force the language to TypeScript I see the same highlighting as coming in the next release of Linguist:

You can see this in action in Lightshow too:

As GitHub renders it now using the TypeScript grammar
As GitHub would render it if it used the TypeScriptReact grammar

Linguist, and thus GitHub, doesn't know about the "TypeScript React" language and thus doesn't use this grammar.
I think there are only two solutions to this:

Modify the TypeScript grammar to source/include the TypeScriptReact rules (I doubt this would be accepted upstream), or
Add a new "TypeScript React" or similarly named language to Linguist and associate .tsx with that language so we can use the TypeScriptReact grammar. This could be grouped with TypeScript as we currently do for JSX.

I'm reluctant to do the latter for my previously stated reservations but it might be the only option.
@Alhadis @pchaigno I'd appreciate your thoughts on this.

Modify the TypeScript grammar to source/include the TypeScriptReact rules (I doubt this would be accepted upstream)

I might be missing some context here, but why would option 1 not be acceptable?

Add a new "TypeScript React" or similarly named language to Linguist and associate .tsx with that language so we can use the TypeScriptReact grammar. This could be grouped with TypeScript as we currently do for JSX.

As far as I remember (and understand), the issue with JSX is not so much with .jsx files but with .js files which may contain JSX code as well. If, here, .tsx files always contain TypeScript+JSX code, then we should be fine.

Modify the TypeScript grammar to source/include the TypeScriptReact rules (I doubt this would be accepted upstream)

I might be missing some context here, but why would option 1 not be acceptable?

🤷♂ just putting it out there. The two a currently separate, probably for maintainability, so the upstream team may not be too keen on merging the two.

Would there be any drawback from using the TypeScriptReact grammar to highlight all TypeScript code?

Any update on this?

@lildude @pchaigno It seems this has been forgotten. Could we pick this up again?

I've not worked with TypeScript before (unless editing an index.d.ts file counts :p), but I hope to remedy that by starting a TSX project once my current project's is finished.
Then, when my slack arse gets back to rewriting the JS grammar, I can consider integrating TypeScript syntax along with everything else, making it a single-grammar which we can use for JSX, TSX, plain TypeScript, plain JavaScript, and so forth.

Since @stale marked this as Stale is there anything I can do?

@rainboxx I second @pchaigno's earlier question:

Would there be any drawback from using the TypeScriptReact grammar to highlight all TypeScript code?

If there's no harm in using a JSX-enabled TypeScript grammar to highlighting ordinary .ts files, then doing so will easily fix this.

@Alhadis sorry, I skipped this question, which I thought was directed to someone else but I could've answered this as well...
Actually there could be an issue with the angle-bracket type assertion syntax, which is not allowed when using JSX. It looks like being an opening JSX tag and would most likely break syntax highlighting. I'm sure many people are switching to the as-style but there's still old code and people not using JSX that favor the angle-bracket style.

Damn. I see what you mean... 😕
I suppose in the short-term, we can add TSX as a language, but it'll be grouped under TypeScript (and be classified as such in statistics bars). As long as Microsoft don't start phasing out the .tsx extension in favour of just .ts (like Facebook did with the .jsx extension), there shouldn't be any problems with classification.
I describe this as a short-term solution because the long-term desideratum is to have a single grammar which can intelligently highlight both JSX and ordinary JavaScript. Doing so will involve some creative hacks, but I know from experience it's certainly possible. I just need to set aside some time first...

@Alhadis sounds like a plan! If there's anything I can help, let me know. Thank you!

Send me money.
Nah, I kid. 😀 Fix submitted in #4511.
Note that it's currently blocked on #4470, as the PR's body will explain.


Extension causes high cpu load

Issue Type: Performance
Extension Name: azds
Extension Version: 1.0.120190904
OS Version: Windows_NT x64 10.0.17134
VSCode version: 1.38.1

:warning: Make sure to attach this file from your home-directory:
:warning:C:\Users\mbenyakoub\azuredevspaces.azds-unresponsive.cpuprofile.txt
Find more details here: https://github.com/Microsoft/vscode/wiki/Explain:-extension-causes-high-cpu-load

Thank you for reporting this issue.
In order for us to investigate, could you please attach the "azuredevspaces.azds-unresponsive.cpuprofile.txt" file generated by VS Code?
Also, do you remember doing anything specific with the extension when this happened?
Did this issue happen once, or every time you do a specific action?

azuredevspaces.azds-unresponsive.cpuprofile.txt

Thanks @benmed00. We're progressively converting synchronous file system operations to asynchronous ones, and it seems that the remaining ones contributed to the hang you experienced.
I'm fixing this, and I'll update this issues once the fix is ready.

Thak you daniv-msft, you're awesome
On Thu, Sep 26, 2019 at 9:46 PM daniv-msft<EMAIL_ADDRESS>wrote:

Thanks @benmed00 https://github.com/benmed00. We're progressively
converting synchronous file system operations to asynchronous ones, and it
seems that the remaining ones contributed to the hang you experienced.
I'm fixing this, and I'll update this issues once the fix is ready.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Azure/dev-spaces/issues/160?email_source=notifications&email_token=AEHWULDY2EDHLTIUFD4OPS3QLUNS7A5CNFSM4IYNRLJ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7W5EOQ#issuecomment-535679546,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEHWULE62XE3MGLSNCFWOILQLUNS7ANCNFSM4IYNRLJQ
.

The fix to remove all synchronous file system operations has been checked-in, and will be part of the next release of the VS Code extension in 2-3 weeks.
@benmed00 > Please feel free to reopen this issue if you see any other hang after this fix is available.

Reopening the issue, in case other users encounter the same problem. I'll close the issue once the version including this fix is released.

This has been fixed in the latest release.


Investigate alternate implementations of stub functions

Currently, stubs (e.g. GET_VALIDATOR_SET_FOR_SLOT) are implemented as constant operators.
We should discuss with our collaborators if/when we want to look into non-constant versions of these operators.

I don't think we are going to look into that


[Bug]: Obmysql editing stored procedure error

ODC version
odc433
OB version

What happened?

What did you expect to happen?
Edited successfully
How can we reproduce it (as minimally and precisely as possible)?

Create stored procedure
Edit stored procedure

Anything else we need to know?
No response

remove duplicate precudre names.It is not a bug


chore(deps): update hashes of GitHub downloads

GitHub is very nice, and has decided to recreate all of the .tar.gz files with slightly worse compression, so that we can have the fun of updating all of our hashes! Isn't that nice :)
(I've confirmed that running gunzip .tar.gz outputs the same .tar file, so it seems like it's just slightly worse compression).
According to GitHub staff, all of the /archive/refs/tags/$tag URLS should be stable, but I guess they were stable until today :shrug:.
See https://twitter.com/thesayynn/status/1620129657977987073

@AshleySetter, any chance you want to do a review? I'm guessing this might be relevant to other projects too, (e.g. npm install from a git URL like https://github.com/nqminds/many-secured/blob/d9d4161230d530665e125be557e694091e040f11/package-lock.json#L5555)?

Hi @mereacre, looks like GitHub changed course and undid their changes, see https://github.blog/changelog/2023-01-30-git-archive-checksums-may-change/
(side-note, it looks like this was due to a recent change in git's compression algorithm, see https://github.com/git/git/commit/4f4be00d302bc52d0d9d5a3d4738bb525066c710)
They said "GitHub doesn’t guarantee the stability of checksums for automatically generated archives.", but Hyrum's Law means if you expose an API, it becomes part of the API.

Obligatory XKCD: https://xkcd.com/1172/


Integrate proper error handling for unsupported characters in the file path

after download, the file path generated may contain characters that may not be supported; add proper fallback for such characters
tweak insert logic to ensure that the filepath inside audio_store is exactly the same as the one in sqlite.

Ex.

Sqlite:

File:

Closed in #98


Unmaintained Package - Recommended Alternative

The current package is no longer maintained.
Please consider using the Time2fa alternative for your projects.
Any contributions are welcome :)
Thank you and good continuation.

Thanks for this.
I just was looking for an alternative.
I don't understand how this package has more than 200k downloads
Unmaintained and actually also not working for next js 14.


Have Babel transpile in the lib folder

By default code in node_modules is already in ES2015 so users of the lib don't need to transpile it. Through npm we only expose the lib folder and set the entry point to it.
The prepublish script is here if we want one day to publish this lib to publish the compile version

This change is

👍


Don't dumbly assume svg-sprite is in $PATH

I could be wrong, but I don't think you need to list node_modules/.bin/svg-sprite as a source here? If you have it listed, make will expect there to be a rule to build the source, and that's not really necessary because the rule is just the npm install that $(MAKI_SOURCES) requires

It will only fail if it doesn't exist, and if it doesn't exist it'll fail anyways. The rule is depending on node_modules/.bin/svg-sprite
I suppose a more correct way would be to have a rule for node_modules/.bin/svg-sprite which calls npm install

You can use the node_modules/.install prerequisite to ensure that npm install has been run.


[🐞] All bundles get prefetched with full priority in PrefetchServiceWorker resulting in error ERR_INSUFFICIENT_RESOURCES

Which component is affected?
Qwik Runtime
Describe the bug
When using the PrefetchServiceWorker, the service worker prefetches all bundles with full priority. This results in all requests running in parallel without being throttled by $maxPrefetchRequests$.
In an app with more than ~600 bundles, many of the prefetch requests will throw an error Failed to fetch with (failed)net::ERR_INSUFFICIENT_RESOURCES
Reproduction
https://github.com/DustinJSilk/qwik-prefetch-priority
Steps to reproduce
Clone the reproduction url and run these commands:
$ ./generate.sh
$ pnpm i
$ pnpm build
Preview the app:
$ pnpm preview
Then in chrome

Clear the application site data
Refresh the page (witness no prefetching, might be another issue?)
Refresh the page again (witness network errors (failed)net::ERR_INSUFFICIENT_RESOURCES and console errors)

If you don't see network errors, try increasing the number of pages generated in ./generate.sh

System Info
System:
    OS: macOS 14.4.1
    CPU: (12) x64 Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
    Memory: 474.85 MB / 16.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 20.12.2 - ~/.nvm/versions/node/v20.12.2/bin/node
    npm: 10.5.0 - ~/.nvm/versions/node/v20.12.2/bin/npm
    pnpm: 9.0.5 - ~/Library/pnpm/pnpm
  Browsers:
    Chrome: 125.0.6422.77
    Safari: 17.4.1
  npmPackages:
    @builder.io/qwik: github:QwikDev/qwik-build#55dc8da599c585a880561fe8db9dd488c043eb1c => 1.5.5-dev20240523064535
    @builder.io/qwik-city: github:QwikDev/qwik-city-build#9306818ac6318b73b2d7b597a9e9512c2f024bc8 => 1.5.5-dev20240523065036
    typescript: 5.4.5 => 5.4.5
    undici: * => 6.18.1
    vite: ^5.2.10 => 5.2.11

Additional Information
No response

Hi, I tested your repo with #6582 and it's working fine with no errors.

Thanks for your report.

I'm going to close this unless we can reproduce it

@gioboa did you test it on localhost or a server?

Localhost


Guard against duplicated byte buffer pool releases

Task/Issue URL: https://app.asana.com/0/1199371158290272/1201949747150726/f
Description
Releasing the byte buffers that back the packets is a tedious process, and it can happen that we try to release the same buffer twice.
As the buffers a direct ByteBuffers, when released, they end up in a pool of available buffers, which is implemented by a linked queue. It can happen that the same buffer is released twice, resulting in a duplicated entry in the queue, eventually ending up in possible buffer corruption as it can be allocated twice.
This PR ensures that it won't be possible to release the same buffer twice.
Steps to test this PR
Smoke tests in AppTP.
The newly added tests pass.

Current dependencies on/for this PR:

develop

PR #1806   (this PR)

This comment was auto-generated by Graphite.


Feature request: Option to only rename untitled files

I like the AI file renaming but I don't want files i already named to be renamed

hey @Kainkun that makes sense
will ship this week

@Kainkun we shipped this today

@ashgansh awesome, thanks!


Cannot read property 'equals' of null

info: Executing <!purge 1> from Josh (ZR2)
/home/divbot/node_modules/discord.js/lib/Structures/ServerChannel.js:53
                        if (this.server.owner.equals(user)) {
                                             ^
TypeError: Cannot read property 'equals' of null
    at TextChannel.permissionsOf (/home/divbot/node_modules/discord.js/lib/Structures/ServerChannel.js:53:25)
    at Object.Commands.purge.fn (/home/divbot/runtime/commands.js:381:22)
    at /home/divbot/DougBot.js:193:33
    at Object.exports.GetLevel (/home/divbot/runtime/permissions.js:9:12)
    at Client.<anonymous> (/home/divbot/DougBot.js:174:21)
    at Client.emit (events.js:107:17)
    at WebSocket.websocket.onmessage (/home/divbot/node_modules/discord.js/lib/Client/InternalClient.js:1365:16)
    at WebSocket.onMessage (/home/divbot/node_modules/discord.js/node_modules/ws/lib/WebSocket.js:418:14)
    at WebSocket.emit (events.js:110:17)
    at Receiver.ontext (/home/divbot/node_modules/discord.js/node_modules/ws/lib/WebSocket.js:816:10)

Server owner is offline and large threshold is trolling so hard...
BetterWorserDiscord pls
Try latest indev.

Yeah it works thanks for that


FR: Customizable keys / use vim bindings

great plugin, will be using this regularly.
Could the keys be customizable, for example to use hjkl instead of the arrow keys for us vim users? 🙏

Thank you for your awesome idea!
I've added a feature that allows simple customization of key bindings.
After updating the plugin to ^0.1.5, you can use this feature.
One day I'll try to make this plugin support key sequences, e.g. gg / G / 3j.
(But not right now.)
Again, thanks for the idea. :)


Added a Drink Water Application

🛠 Fixes Issue #550
👨💻 Changes proposed
Added a Drink Water Application
✅ Check List (Check all the applicable boxes)

[X] My code doesn't break any part of the project (Zero Octave-Javascript-Projects).
[X] This PR does not contain plagiarized content.
[X] My Addition/Changes works properly and matches the overall repo pattern.
[X] The title of my pull request is a short description of the requested changes.

📷 Screenshots

@Astrodevil pls review the application

Everything is fine. Is 2 liters goal can't be changed? Add your project in cards.json

I have followed the WHO guideline for 2 liters goal.
Made all the changes @Astrodevil pls check.


Implement FedProx to improve robustness to heterogeneity

Following @rabbanitw's comment, extending our federated averaging methods to support FedProx would greatly improve Disco's robustness to client heterogeneity (data and system).
In short, FedProx adds a regularizing term (called "proximal term") to the local objective function.
From the paper:

The proximal term is beneficial in two aspects:
(1) It addresses the issue of statistical heterogeneity by restricting the local updates to be closer to the initial (global) model without any need to manually set the number of local epochs.
(2) It allows for safely incorporating variable amounts of local work resulting from systems heterogeneity

The algorithm is summarized here.

Disco currently doesn't select a subset of users and relies either on all users or on the first ones that reply with local updates.

ok sounds fine. though sth even better and slightly easier to do even is to use momentum (obtained as a difference vector between rounds), which then is added to every local step.
this works in federated and decentralized.
called the mime-light algorithm in
Mime: Mimicking Centralized Stochastic Algorithms in Federated Learning
https://arxiv.org/abs/2008.03606
one could start with whichever is easier to implement in disco, and then do some experiments to compare with/without it

Thanks @JulienVig. Echoing @martinjaggi, I'm fine with whatever is the easier implementation. As long as we have any type of implementation to mitigate client drift so I can discuss it at GDHF, I think it'll be fine!

Thanks for the reference! Looking at both FedProx and MimeLite it seems that they should both be relatively easy to implement, though FedProx seems slightly easier (if I'm not mistaken it's just adding a regularizer to our objective function) while MimeLite requires additional communication (clients send the gradients to the server and the server sends the momentum to the clients)
We should investigate both, especially seeing how FedProx seems to underperform in the Mime experiments.


serializeTx and deserializeTx misses prevScriptPubKey from inputs

Been trying to use this lib to for our transaction flow
Things work if we do

createRawTx
signTx

It breaks if we do

createRawTx
serializeTx
deserializeTx
signTx

I think it's because serializeTx is leaving out the prevScriptPubKey

Thanks for reporting the issue, we're looking into it and are working on a solution.

Functionality to include prevScriptPubKey in serialization added in https://github.com/ZencashOfficial/zencashjs/tree/v1.2.2.


deno binary builds in releases

I have been using Quint with Deno for a while.
$ deno install -A -n quint npm:@informalsystems/quint
✅ Successfully installed quint
/home/user/.deno/bin/quint
$ quint --version
0.21.0
$ # or just
$ deno run -A npm:@informalsystems/quint --version
0.21.0

But I wished if Quint releases could include binaries directly via deno compile.
But I couldn't suggest as quint verify was breaking because of a http2 bug. Today, I resolved it on denoland/deno#24576 which makes Quint Deno-compatible. You can now try it on quint examples.
$ cd quint/examples/cosmos/ics20
$ deno run -A npm:@informalsystems/quint verify --max-steps=1 --main=bankTests --invariant=BalanceNonNegative,NonExistantAccountsOrCoinsAreZero bank.qnt

With this, would you consider including Deno compiled Quint binaries in future releases?
$ deno compile -A -o quint npm:@informalsystems/quint
$ ./quint --version
0.21.0

Pros:

No dependency to node or anything else.
Standalone executables. Easily distributable.

Cons:

Includes Deno runtime. Bigger package: 22MB (without counting the node or npm installation) vs 101MB.
Deno is still ironing out bugs and APIs. But, Deno 2 is coming.

Refs:

deno compile, standalone executables.
pkgx (previously tea) uses deno compile for release binaries.

Thank you for fixing that issue! I agree, we should do it: Pros > Cons :smile:


Create the basic structure with Java and Spring

Create backend service as Monolith using Java and Spring Framework.
The structure should include:

Controllers package contains public REST APIs
Repositories package the components to connect the database
Services package contains the components to handle logic stuffs
Configuration

This issue was moved to mgm-interns/teamradio2-frontend#14

This issue was moved to mgm-interns/teamradio2-frontend#15


Allow init to accept an already configured cache client

First off, I've really enjoyed using Stormpath so far. Great work!
I'm looking to enable caching for my app. I see that the product guide describes how you can tell stormpath what the host, port, and auth options are for the cache and then it makes its own connection to the cache.
Why not just accept an already configured cache client as well? I ask because in my app I have several other components that depend on a redis client, so instead of creating a client for every component I create one client and inject it into every component that needs it. The connection details change depending on the stage of the app so by using injection I isolate the stage/connection details to the one part of my app that is responsible for creating the client.
I explained my use case, and I think in general this would provide value for other users as well. What are your thoughts? I'd be willing to submit a PR if you like this idea.
Thanks again!

I agree!  The underlying Node SDK does support this, see the docs here and note the client option:
http://docs.stormpath.com/nodejs/api/client#redis
For a PR, I think we need to pass that option here:
https://github.com/stormpath/stormpath-express/blob/daaf31023043e5077b167566faf5740a0cb8345a/lib/stormpath.js#L39

Thanks! Change seems straightforward enough, any suggestions for testing?

Actually, it looks like there is already a request in progress for this same feature:
https://github.com/stormpath/stormpath-express/pull/56
Diff shows a change almost identical to what I made.

Thanks everyone for commenting on this -- and sorry for my slow turnaround time.
I'm going to be merging the PR #56 into the library, and this is most definitely a needed / useful option.
I really appreciate ya'll bringing this to my attention <333
I'll leave another comment here once the PR has been merged, and a new release has been cut.

Bam, new release has been cut! If you fetch 1.0.2 you'll be able to specify the cacheClient option when setting up the middleware =)


Seeing continuous failures in grpc Multilang and Mac OS Basic tests

Continuous failures in MacOS (Opt, Debug) tests and Multilang tests.
Failures observed since 10 Oct
Error log :
+ node merge_kokoro_logs.js
TypeError: Cannot read property 'testsuites' of null
    at merged.testsuites.testsuite.Array.concat.apply.objects.map (/Volumes/BuildData/tmpfs/src/github/grpc/grpc-node/merge_kokoro_logs.js:44:126)
    at Array.map (<anonymous>)
    at readDir.then.then (/Volumes/BuildData/tmpfs/src/github/grpc/grpc-node/merge_kokoro_logs.js:44:109)
    at <anonymous>

Error logs where the issue first occured -
https://source.cloud.google.com/results/invocations/44e43e3a-1000-499d-8a55-05aacb8c20b7/targets/grpc%2Fcore%2Fmaster%2Fmacos%2Fgrpc_basictests_opt/log
https://source.cloud.google.com/results/invocations/467171c1-96b4-4a0d-86b4-6afa81e03ff8/targets/grpc%2Fcore%2Fmaster%2Fmacos%2Fgrpc_basictests_dbg/log
https://source.cloud.google.com/results/invocations/0d7bae9a-b0db-4c09-bfaa-5c34d6323b97/targets/grpc%2Fcore%2Fmaster%2Flinux%2Fgrpc_basictests_multilang/log
Commit at which the error started appearing -
https://github.com/grpc/grpc/commit/73c99f890a42479bc82e2c0ab132a97cbcf8434a

Dupe of https://github.com/grpc/grpc/issues/16846


Update whisper-standalone-win description in README.md

@nguyendc-systran Can you merge it? Thx in advance.


[FEATURE]: Dynamic Schema

Describe what you want
It doesn't seem possible to use pgSchema or related with dynamic runtime values. (https://orm.drizzle.team/docs/schemas)
in #423, proposed solutions use a table factory to achieve this, and while this works with the query builder (with code duplication and bad DX), this is not viable for use with relational queries or drizzle-kit.
It is very common to use schemas for separating tables of different tenants in multitenant applications. The easiest way to support this would probably be with an addition to the drizzle() function, which could take an optional schema argument. The schema would apply to all the tables defined on the drizzle db instance.
Similarly, optional config with drizzle kit to specify a schema would solve the problem.

I have already tried defining a drizzle schema factory instead of using a static drizzle schema, that takes a pgSchema as an input and returns the correct drizzle schema.
The problem here is with defining relations, and circular reference issues:

export const getAccreditationDocumentsTable = (schema: string) => {
  const { userDocuments } = getUserDocumentsTable(schema);
  const { accreditations } = getAccreditationsTable(schema);

  const accreditationDocuments = pgSchema(schema).table(
    'accreditation_documents',
    {
      accreditationId: varchar('accreditation_id', { length: 128 })
        .notNull()
        .references(() => accreditations.id),
      userDocumentId: varchar('user_document_id', { length: 128 })
        .notNull()
        .references((): AnyPgColumn => userDocuments.id),
    },
    (table) => {
      return {
        pk: primaryKey({
          columns: [table.accreditationId, table.userDocumentId],
        }),
      };
    },
  );

  const accreditationDocumentsRelations = relations(
    accreditationDocuments,
    ({ one }) => ({
      accreditation: one(accreditations, {
        fields: [accreditationDocuments.accreditationId],
        references: [accreditations.id],
      }),

      userDocument: one(userDocuments, {
        fields: [accreditationDocuments.userDocumentId],
        references: [userDocuments.id],
      }),
    }),
  );

  return { accreditationDocuments, accreditationDocumentsRelations };
};

export const getAccreditationsTable = (schema: string) => {
  const { users } = getUsersTable(schema);
  const { accreditationDocuments } = getAccreditationDocumentsTable(schema);

  const accreditations = pgSchema(schema).table('accreditations', {
    id: varchar('id', { length: 128 })
      .primaryKey()
      .$defaultFn(() => createId()),

    userId: varchar('user_id', { length: 128 })
      .notNull()
      .references(() => users.id),
  });

  const accreditationsRelations = relations(
    accreditations,
    ({ one, many }) => ({
      user: one(users, {
        fields: [accreditations.userId],
        references: [users.id],
      }),
      accreditationDocuments: many(accreditationDocuments),
    }),
  );

  return { accreditations, accreditationsRelations };
};

This causes TS Error: implicitly has return type 'any' because it does not have a return type annotation and is referenced directly or indirectly in one of its return expressions

I've run into that TS error a few times with circular references, and it was resolved (in my PostgreSQL case) by adjusting this line:
.references(() => accreditations.id),
->
.references((): AnyPgColumn => accreditations.id),
The Any[]Column object might be different if you aren't Postgres.

I'm developing a multitenant system, and this aspect is critical for dynamically switching to the tenant schema.
Unfortunately, this feature is not available in drizzle, so I'm considering moving to Kysely.
https://kysely.dev/docs/recipes/schemas
They provide this feature using the following syntax:
db.withSchema(tenant).selectFrom('user').selectAll()

As a workaround this works for us for now
export const customerTable = {
  name: 'customers',
  columns: {
    id: serial('id').primaryKey(),
    name: varchar('name').notNull(),
    createdAt: timestamp('created_at', { withTimezone: true }).notNull(),
    updatedAt: timestamp('updated_at', { withTimezone: true })
      .defaultNow()
      .notNull(),
    active: boolean('active').default(true).notNull(),
  },
  extraConfig: (table: any) => ({
    customerNameIdx: index('customer_name_idx').on(table.name),
  }),
}

export class DBModel {
  dbSchema: string

  constructor(dbSchema: string, withLogs = true) {
    this.dbSchema = dbSchema
    if (withLogs) {
      console.log(`Initialized DB schema ${this.dbSchema}`)
    }
  }

  get customers() {
    return createTableWithSchema(
      this.dbSchema,
      customerTable.name,
      customerTable.columns,
      customerTable.extraConfig,
    )
  }
}

export function createTableWithSchema<
  TSchemaName extends string,
  TTableName extends string,
  TColumnsMap extends Record<string, PgColumnBuilderBase>,
>(
  schemaName: TSchemaName,
  tableName: TTableName,
  tableColumns: TColumnsMap,
  extraConfig: ((self: BuildColumns<TTableName, TColumnsMap, 'pg'>) => PgTableExtraConfig) | undefined
) {
  return pgSchema(schemaName).table(
    tableName,
    tableColumns,
    extraConfig
  )
}

Also created this PR half a year ago to make the schema dynamically changeable at runtime within the library. I guess the subject lacks interest :-)
https://github.com/drizzle-team/drizzle-orm/pull/1266

Currently the lack of this feature prevents me form using Drizzle in my projects.

Has this been neglected so far? I'm having trouble with Prisma handling this and I had Drizzle as my main alternative (actually to become primary). It seems that this important feature is not getting enough attention. Let's stick with Postgres.js for now.

I believe this is basic requirement for many projects. I wish this feature is available from the beginning.


Official MPS support for MAGNeT?

Hi thank you for this amazing work. I had to update some code on my end to get it to work on Mac machines (without using xformers). See the update here: https://github.com/peanutcocktail/audiocraft/commit/370e15c0ef3e0c1e786dd02b3c25957714e95a25
I'm not sending a PR because my "fix" is super ad-hoc (basically using environment variables to avoid the xformers related code, was just focused on getting it to work.
Anyway, I was OK with AudioCraft MusicGen/AudioGen being slow, but this time I think MAGNeT is totally missing out by NOT supporting MPS directly. Looks like it's using the CPU mode currently.
Because the main value of MAGNeT is the speed, I would even go as far to say, this could be the StableDiffusion moment of audio, if we get this to work on ALL platforms (starting with MPS). I wrote about this here: https://x.com/cocktailpeanut/status/1747290801527226394?s=20 It would be a game changer if this works on M1/M2/M3 properly with MPS support.
Any plans to add MPS specific logic to the MAGNeT code?

Yes! Please consider adding MPS – a lot of people at Meta with Macs would benefit from this.

MPS please.

PLEASE

Commenting to keep updated on this, i want to run this on my M1 without waiting until next week

Another vote for this, I want to have faster generation on Mac.

@cocktailpeanut - I don't mind working on this, however I'm not aware of the limitations/nuances of MPS backend.
From your changes, it seems like just an "override" of xformers to enable torch MPS. Am I correct in this?

@theadamsabra I've taken a deeper dive into MPS compatibility with MAGNeT, based off of @cocktailpeanut's changes. A lot of what I've done is just extended if self.device.type == 'cpu' to if self.device.type == 'cpu' or self.device.type == 'mps', but there is also a workaround required to get audio decode to work.
Basically, in https://github.com/facebookresearch/audiocraft/compare/main...damian0815:audiocraft:mps_fixes, the following changes have been made to make MAGNeT work with MPS:

xformers doesn't work with MPS, the IGNORE_MEMORY_EFFICIENT env var is @cocktailpeanut 's fix for that.
Autocast isn't supported on MPS, which the existing code checks by if self.device.type == 'cpu' but this needs to be extended to MPS as well.
https://github.com/pytorch/pytorch/issues/124834 - ELU is broken on MPS which means the tokens to audio decode produces garbled output. this can be overridden by forcing the ELU operation to run on the CPU.

I think the correct way to deal with these is to

abstract out the memory efficient parts of the logic to not be dependant upon xformers (which I believe been largely superseded by torch's internal memory attention logic anyway), and
either invert the logic for disabling autocast on CPU so that it only enables autocast on CUDA, or add some global autocast disabling flag so that the logic can be if not self.disable_autocast: instead of if self.device.type == 'cpu':


Grammar and spelling fixes across the doc

I could generally understand what was being written here, but the grammar was causing me to digest this a lot slower. Therefore, I made a PR to fix the spelling/grammar in various places.
If something doesn't make sense, I'll gladly clarify what I meant with the edit. Hope this helps any other future readers of the doc!

adjusted it all accordingly, just waiting on the CLA check to clear @necolas
thanks for the feedback!


Always show details

Hi,
I was wondering if it is possible to always show the details and remove the button?
Greetings,
Jos

I was just looking into this! I see in the HTML it is a toolbar with chevron icon. I can modify the html to show it but I don't know js at all and don't know how to change the actual card.

Hello, sorry for my late reply. I will try to take the time to add this option.

Update available v5.9.3


CLN: Modularize code, fix count to download correct number of filings

[x] closes #32, #37, #42, #44
[x] tests added / passed
[x] passes git diff upstream/master -u -- "*.py" | flake8 --diff
[x] added entry to CHANGELOG

@coyo8 Looking back on this, it might make sense to make a single Filings class instead of a class for each filing type.
Sent with GitHawk

@coyo8 I updated the code with the changes I mentioned earlier in this pull request.

@coyo8 This should be merged before #52. I think I will need to make some changes to #52 before we can merge that cleanly.

@jackmoody11 nice work!


Avoid netcoreapp package dependency

Removes the machinery required to fix the version of our Microsoft.NETCore.App dependency and returns to the implicit reference.
Works around dotnet/sdk#2204 by updating the implicit reference with PrivateAssets="All".

Rebased on #3264. Ready for review.

Caused: java.io.IOException: Backing channel 'JNLP4-connect connection from <IP_ADDRESS>/<IP_ADDRESS>:39936' is disconnected.
	at hudson.remoting.RemoteInvocationHandler.channelOrFail(RemoteInvocationHandler.java:212)
	at hudson.remoting.RemoteInvocationHandler.invoke(RemoteInvocationHandler.java:281)
	at com.sun.proxy.$Proxy174.isAlive(Unknown Source)

booooo
@dotnet-bot test Windows_NT Build for Full please
@dotnet-bot test Windows_NT Build for CoreCLR please


Multiple Requests sent for SVG sprite in Firefox

Summary
SVG sprite rendering blinking on multiple reloads of the page in Firefox
Steps to reproduce

A App Requesting for the same SVG sprite 10 times (each with different #ids)
Now try to access that app in Firefox

Expected results

Only one request for the SVG Sprite should be sent

Actual results

Request for SVG Sprite is sent 10 times

Additional context

CodePen Link: https://codepen.io/uchihamalolan/full/JjWwVYE
In chrome, there'll be only one request sent
In Firefox, 10 requests are sent

Possible Solution
It seems to be a Bug in Firefox itself, links here:

https://bugzilla.mozilla.org/show_bug.cgi?id=1027106
https://bugzilla.mozilla.org/show_bug.cgi?id=1678956

They suggested a workaround, until the issue is fixed on their side. Please go through the bug report for the workaround

Please note that the workarounds don't really work as using <svg><use xlink:href="sprite.svg#foo"/></svg> does not allow cross origin requests (which is always the case when using cdn). 😥


Logging

Have the output of the ffmpeg conversion and any test go to separate log files that can be brought up from the web pages.
There are also some refinements to make the log output a little clearer.

There seems to be a merge conflict. You might need to pull in the latest changes from main.


Implement Admin namespace RPC handler

Describe the feature
ref #549
Start scaffolding admin namespace RPC handler impl.
API trait first added here: #569
This will look similar to the NetApi:
https://github.com/paradigmxyz/reth/blob/20847845e2d7518515ba514815b1987de8f95e27/crates/net/rpc/src/net/mod.rs#L7-L12
TODO

[ ] add AdminApi type which should also take NetworkHandle
[ ] implement AdminApiServer trait on it
[ ] implement admin functions via NetworkHandle

Additional context
No response

I would like to take this on

awesome!

@mattsse Not sure to understand why AdminApiServer add_peer() and remove_peer() need to be async?
We just need to call NetworkHandle add_peer() and disconnect_peer_with_reason(), no?

they don't, so feel free to change that in the trait

@mattsse I'm not sure add_trusted_peer and remove_trusted_peer should do, as trusted nodes are stored on PeersConfig and seems to be used only when Reth starts. Am I missing something?
Also, it seems connect_trusted_nodes_only is never used.

the connect_trusted_nodes_only setting is enforced here
https://github.com/paradigmxyz/reth/blob/13441ff299b4766959b5439235dfed2071059c54/crates/net/network/src/peers/manager.rs#L469

and seems to be used only when Reth starts. Am I missing something?

right, will create a separate issue for adding commands, similar to add_peer


TypeError: string indices must be integers when calling add_dashboard_panel

Hi there,
I'm attempting to add a dashboard panel to a newly-created dashboard when running this script, but I get the following error:
  File "/Users/<REDACTED>/.pyenv/versions/3.8.5/lib/python3.8/site-packages/sdcclient/monitor/_dashboards_v3.py", line 169, in add_dashboard_panel
    new_panel_id = dboard["panels"][-1]["id"] + 1
TypeError: string indices must be integers

It occurs on this line.  I can confirm that my local configuration (API key, endpoint URL, instance ID) is correct since I haven't had any issues executing other functions from this SDK.

I noticed I get the same type of error when running the dashboard_save_load.py script on line 46.
  File "/Users/vmiltche/.pyenv/versions/3.8.5/lib/python3.8/site-packages/sdcclient/monitor/_dashboards_v3.py", line 381, in create_dashboard_from_file
    return self.create_dashboard_from_template(dashboard_name, dashboard, filter, shared, public)
  File "/Users/vmiltche/.pyenv/versions/3.8.5/lib/python3.8/site-packages/sdcclient/monitor/_dashboards_v3.py", line 271, in create_dashboard_from_template
    template['id'] = None
TypeError: list indices must be integers or slices, not str

For context, I'm running Python 3.8.5 on a macOS Big Sur Version 11.3.1.


refactor(tabs): separate panels from tabs and improve a11y LUM-11309

General summary

[BREAKING] Removed Tabs component replaced by the TabProvider and TabList components.
[BREAKING] Tab component doesn't wrap the tab content anymore (use TabPanel for that). Implements the WAI-ARIA tab role.
Added TabProvider component wrapping the new TabList and TabPanel and handling state (controlled or uncontrolled).
Added TabPanel component that wraps the content of a tab (previously wrapped in the Tab component). Implements the WAI-ARIA tabpanel role.
Added TabList component that wraps Tab components. Implements the WAI-ARIA tablist role.

@pidupuis I have just commited a few changes and improvements :grimacing:

removed "onChange" and "onFocus" on disabled tabs https://github.com/lumapps/design-system/pull/540/files#diff-464ecc0cbb2849ad0e5e25b80e2e17cb2a6c4bdcddeaddc55cea3d5a1d888b6cR90-R91
Added some tests for disabled tabs https://github.com/lumapps/design-system/pull/540/files#diff-bfad564c7d8992dab361a4c6c17c4e353dd58e736941ca3bc8a3a6813eb0ed09R114-R124
Changed my mind on the role and aria-label of the TabList :grimacing: My bad, I tried it out with a screen reader and it works better like this https://github.com/lumapps/design-system/pull/540/files#diff-464ecc0cbb2849ad0e5e25b80e2e17cb2a6c4bdcddeaddc55cea3d5a1d888b6cR103-R105
Updated the snaps for this last change :point_up:

@matmkian Could you review the SCSS and test the new tab component?


[Platform]: Genetics integration

[Platform]: Genetics integration
Description
This pull request introduces several new features and improvements to the platform, including updates to the API URL, new pages for studies and credible sets, and enhancements to the search functionality. The most important changes include the addition of new routes and components for the credible set page, modifications to the search query to include variants, and updates to the Apollo client configuration.
New Features:

Credible Set Page:

Added CredibleSetPage, including components Header, Profile, and ProfileHeader, with corresponding GraphQL queries and fragments. (apps/platform/src/pages/CredibleSetPage/CredibleSetPage.tsx, apps/platform/src/pages/CredibleSetPage/Header.tsx, apps/platform/src/pages/CredibleSetPage/Profile.tsx, apps/platform/src/pages/CredibleSetPage/ProfileHeader.tsx, apps/platform/src/pages/CredibleSetPage/CredibleSetPage.gql, apps/platform/src/pages/CredibleSetPage/ProfileHeader.gql) [1] [2] [3] [4] [5] [6]
Added routes for StudyPage and CredibleSetPage in App.tsx. (apps/platform/src/App.tsx) [1] [2]

Enhancements:

Search Functionality:

Updated SearchQuery to include variants and added a new search query for variants. (apps/platform/src/components/Search/SearchQuery.gql) [1] [2]

Apollo Client Configuration:

Added AlleleFrequency and InSilicoPredictor key fields to Apollo client cache configuration. (apps/platform/src/client.js)

Miscellaneous:

API URL Update:

Changed VITE_API_URL in .env to point to the new genetics API. (apps/platform/.env)

Commented Out Unused Component:

Commented out ShouldAccessPPP component in App.tsx. (apps/platform/src/App.tsx)

These changes collectively enhance the platform's functionality, particularly around credible set data and search capabilities, while also updating configurations to align with new API endpoints.
Issue: (link)
Deploy preview: (link)
Type of change

[x] New feature (non-breaking change which adds functionality)

Closed Test PR


Fix code to avoid trap when description is long

Force an error by corrupting scope.
$ gam user testuser1 check serviceaccount
Computer clock status:
 Your computer clock differs from Google by 0 seconds                       PASS
Service Account Private Key Authentication:
Traceback (most recent call last):
  File "/Users/admin/Documents/GoogleApps/GAMO/gam.py", line 14898, in <module>
    sys.exit(ProcessGAMCommand(sys.argv))
  File "/Users/admin/Documents/GoogleApps/GAMO/gam.py", line 14834, in ProcessGAMCommand
    doCheckServiceAccount(users)
  File "/Users/admin/Documents/GoogleApps/GAMO/gam.py", line 1552, in doCheckServiceAccount
    printPassFail('Authenticating...%s' % auth_error, sa_token_result)
  File "/Users/admin/Documents/GoogleApps/GAMO/gam.py", line 1522, in printPassFail
    print(' {} {:>{padding}}'.format(description, result, padding=str(padding)))
ValueError: Sign not allowed in string format specifier

$ gam user testuser1 check serviceaccount
Computer clock status:
 Your computer clock differs from Google by 1 seconds                       PASS
Service Account Private Key Authentication:
 Authenticating...invalid_scope: https://www.googleapis.com/auth/userinfo.emailx is not a valid audience string. FAIL
Domain-Wide Delegation authentication as<EMAIL_ADDRESS> https://mail.google.com/                                                   PASS
 https://www.googleapis.com/auth/activity                                   PASS
 https://www.googleapis.com/auth/apps.alerts                                PASS
 https://www.googleapis.com/auth/calendar                                   PASS
 https://www.googleapis.com/auth/drive                                      PASS
 https://www.googleapis.com/auth/gmail.settings.basic                       PASS
 https://www.googleapis.com/auth/gmail.settings.sharing                     PASS
 https://www.googleapis.com/auth/spreadsheets                               PASS

All scopes passed!
Service account<PHONE_NUMBER>55721632353 is fully authorized.

Jay
Is there some issue I need to address here?
Ross


Improve Vue

Describe the feature
Currently, <script setup lang="ts"> is being completely bypassed, as of #15. However, bypassing should only be needed when using type-only macros, e.g. defineProps<{ foo: number }>()(not defineProps({ foo: Number })).
So, to improve this:

Quick and acceptable solution: do not exclude files that don't have any type-only macros
Best solution: avoid bypassing completely by converting type-only macros to their runtime definition counterparts, e.g. convert defineProps<{ foo: number }>() to defineProps({ foo: number }). This may be complex to implement, and may even require help from the Vue team. The reverse of https://github.com/sapphi-red/vue-convert-to-script-setup-from-composition-api may work.

I will implement the "quick and acceptable solution" soon.
Additional information

[X] Would you be willing to help implement this feature?

I have some idea and I made the another vue mkdist loader around it.
Take a look: https://github.com/Teages/mkdist-vue-loader
It looks great but I don't know should I merge it back to mkdist because it would break the original code structure (although just a little, it will transfer <script setup> to <script>) and a bit slow (in my test case, it takes 15% longer)


RFE: PromQL primitives for sampling

Proposal
When collecting data from large populations, it is often useful to sample from the population rather than aggregating into a single metric. This operation is more resource-friendly, as well as often more descriptive of the actual population distribution (as the data can be full-fidelity without much performance impact).
Popular TSDBs provide a similar function:
InfluxDB: https://docs.influxdata.com/influxdb/v1.5/query_language/functions/#sample
CrateDB: https://crate.io/docs/crate/reference/en/latest/general/builtins/scalar.html#random
If the maintainers are amenable to this query function, I'm happy to take a stab at implementing it.

I don't see how this would work sanely semantically, nor how it would be a real performance improvement as we'd still need to pull in all the data.

I think there are two things to consider here:

is the sampling utility useful and novel?
To me this issue is unequivocally yes, since sampling full fidelity data is in many cases more useful than looking at either aggregated metrics, or topk()/bottomk() in understanding the population distribution. If there's already something in place, even better! The point here is that even without a performance improvement, this function would be useful unto itself.

is there a performance improvement to querying data in this manner, as compared to the aggregation?
Let's say for example I'm querying something like sample(N, up[1h]). I defer to you in terms of the implementation as I haven't spent a lot of time looking through the source, but I would think algorithmically you could do something like:

generate N random times within the range
for each time generated, perform an instant query at that instant for a single metric
look up and return matching timeseries over the window at full-fidelity

InfluxDB's implementation uses reservoir sampling to achieve O(n) performance for their sample function. Maybe I'm misunderstanding something fundamental about how the query engine performs a lookup, such that sampling random metrics is prohibitively computationally expensive?


Can not import Source Storage with kube2iam

I set up kube2iam service in my k8s cluster. After binding the correct role to the label studio instance, I created source storage left Access Key ID/Secret Access Key/Session Token blank, but failed with the logs:

[2021-06-05 00:20:29,308] [core.utils.common::custom_exception_handler::79] [ERROR] f9a4709c-15af-4ea9-8352-b6ae051534ce {'non_field_errors': [ErrorDetail(string='Cannot connect to S3 bucket-name with specified AWS credentials', code='invalid')]}
Traceback (most recent call last):
File "/usr/local/lib/python3.8/dist-packages/rest_framework/views.py", line 506, in dispatch
response = handler(request, *args, **kwargs)
File "/usr/local/lib/python3.8/dist-packages/django/utils/decorators.py", line 43, in _wrapper
return bound_method(*args, **kwargs)
File "/usr/local/lib/python3.8/dist-packages/rest_framework/generics.py", line 190, in post
return self.create(request, *args, **kwargs)
File "/label-studio/label_studio/io_storages/api.py", line 102, in create
serializer.is_valid(raise_exception=True)
File "/usr/local/lib/python3.8/dist-packages/rest_framework/serializers.py", line 228, in is_valid
raise ValidationError(self.errors)
rest_framework.exceptions.ValidationError: {'non_field_errors': [ErrorDetail(string='Cannot connect to S3 bucket-name with specified AWS credentials', code='invalid')]}
[05/Jun/2021 00:20:29] "POST /api/storages/s3/validate HTTP/1.1" 400 234

Hi! You should explicitly specify AWS credentials, IAM role-based access is not supported.

I created a new key for access s3 storage. But errors if I left Session Token blank. Is "Session Token " must be set?

It works after setting "Bucket Prefix". And it's found that label studio supports kube2iam also after testing.


How to keep the comments at the same line when reformatting the code with Rust code formatter?

I use rust-analyzer in VSCode.
with all default settings.
Check out the gif: when press reformat-hot-key:
my comments move away from the same line of code,
which is really not good-looking.
if the comments is at the same line of code ,
reading the codes will be much more fluent.
Making the comments become optional read.
The code  I wish when reformat.
fn main() {
    let guess: u32 = match guess.trim().parse() {// :u32 : type casting, work with .parse()
        Ok(num) => num,
        Err(_) => { //_  means any error
            println!("Please input numbers!");
            continue;
        }
    };
}

The code I don`t like when reformat:
fn main() {
    let guess: u32 = match guess.trim().parse() {
        // :u32 : type casting, work with .parse()
        Ok(num) => num,
        Err(_) => {
            //_  means any error
            println!("Please input numbers!");
            continue;
        }
    };
}

I want to get some help with it,
and I assume maybe some people also need this formatting behaviour.

Thanks but closing as a duplicate of #3255


[Bug]: Some of "File Menu" can't be displayed.

Describe the bug
The following error occurs when I right-click a file, but it works again when I click "more options".
Relevant errors (if available)
No response
Steps to reproduce

Download the plugins named "AidenLx's Folder Note" and "Folder Note Core";
Add the "Folder Note Core: Delete linked folder" and "Folder Note Core: Make current document folder note" to the "File Menu";
Right-click a file;
Click "more options".

Expected Behavior
The "File Menu" can't work, when you right-click a file.
But it displays one of these two commands when I click "more options".
Additional context
No response
Operating system
Windows

Some Commands are so called "checked" commands. This means, the Plugin that initially added the Command to obsidian determines if the command can run in the current situation (for example because it depends on an active editor), and if it can't it won't be displayed. I think this is an issue with the plugin itself deciding that these commands cannot be run, and thus commander won't display them


fix: Usage documentation for Adapt Essentials: Asset Fields app

Purpose
People had trouble  finding the app after installation. This PR improves documentation and adds documentation on app configuration page.
Approach
README.md is updated to include the instructions. And it's reused in app configuration window.
Testing steps

[ ] Go to app configuration window
[ ] Confirm that you can see Instructions
[ ] Go to App README.md
[ ] Confirm that you see instructions

Breaking Changes
There are no breaking changes
Dependencies and/or References
https://github.com/adaptdk/adapt-essentials-asset-fields/issues/9

cc @whitelisab

@zzzarius Thanks for making the changes! One more small typo and we should be good to go!


Add healthcheck instructions to example Dockerfile in the documentation

First Check

[X] I added a very descriptive title to this issue.
[X] I used the GitHub search to find a similar issue and didn't find it.
[X] I searched the FastAPI documentation, with the integrated search.
[X] I already searched in Google "How to X in FastAPI" and didn't find any information.
[X] I already read and followed all the tutorial in the docs and didn't find an answer.
[X] I already checked if it is not related to FastAPI but to Pydantic.
[X] I already checked if it is not related to FastAPI but to Swagger UI.
[X] I already checked if it is not related to FastAPI but to ReDoc.

Commit to Help

[X] I commit to help with one of those options 👆

Example Code
FROM python:3.9

WORKDIR /code

COPY ./requirements.txt /code/requirements.txt

RUN pip install --no-cache-dir --upgrade -r /code/requirements.txt

COPY ./app /code/app

CMD ["uvicorn", "app.main:app", "--host", "<IP_ADDRESS>", "--port", "80"]

Description
I recently read a recommendation to add the HEALTHCHECK command to a Dockerfile. I was wondering whether it would make sense to include a HEALTHCHECK in the FastAPI documentation. In a previous discussion I tried to verify if this issue makes sense. I've provided example code of how I would add a basic HEALTHCHECK.
Looking forward for some feedback!
Wanted Solution
Add the HEALTHCHECK command to the Dockerfile in the FastAPI docs.
Wanted Code
FROM python:3.9

WORKDIR /code

COPY ./requirements.txt /code/requirements.txt

RUN pip install --no-cache-dir --upgrade -r /code/requirements.txt

COPY ./app /code/app

CMD ["uvicorn", "app.main:app", "--host", "<IP_ADDRESS>", "--port", "80"]

HEALTHCHECK CMD http://localhost/

Alternatives
No response
Operating System
Linux
Operating System Details
No response
FastAPI Version
0.75.2
Python Version
3.9.2
Additional Context
No response

It's a good practice to have health check for containers. A simple short example should suffice. May be we can link to a detailed doc about Docker health check in that for people to read further.


Enable customizable queries / BI integration

Is your feature request related to a problem? Please describe.
A customer might have varying needs for the KPIs, e.g., only show the temperature when machine was not running.
Describe the solution you'd like
The user can specify queries when communicating with factoryinsight.
Describe alternatives you've considered
A good alternative would be replicating the REST API into a relational database for consumption of a BI tool.
Maybe even include GraphQL?
Additional context
Based on expert discussions

Is this still relevant @JeremyTheocharis  ?


When can we add "... Azure Web Apps, virtual machines, databases..." to environments?

[Enter feedback here]
The first line of the article states that environments "...Kubernetes clusters, Azure Web Apps, virtual machines, databases..." however the article then goes on the state that only Kubernetes is currently supported.  Do we have a date for when the other resource types are going to be available or can you change the first line to reflect the current functionality?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 77d95db6-9983-7346-d0eb-4b7443e4e252
Version Independent ID: 0a22cccc-318d-592f-d1ab-09ec01d88087
Content: Environment - Azure Pipelines
Content Source: docs/pipelines/process/environments.md
Product: devops
Technology: devops-cicd
GitHub Login: @RoopeshNair
Microsoft Alias: ronai

@ChrisGibson1982 -- Chris, thanks for your question. It looks like you're working through an issue with your scenario or implementation, rather than an issue with the documentation. Here are a couple of options where you might consider asking your question:

Azure DevOps on Stack Overflow

Azure DevOps Support Bot

I am closing this issue now.  You are welcome to @ mention me for any followup.
We hope to hear from you again.

I think the question is quite valid. the documentation is unclear. it says we can setup a group of resources within an "environment" but then that only AKS can be added.
Same issue in the product, you can create an empty ENV OR a AKS env, but once the empty ENV created, you can only add AKS

We are currently working on adding support for Virtual Machines, it will be available in ~2-3 months. We will follow up with most of the Azure resources including WebApps, soon after that.

+1 for azure webapps in the environments. This would be awesome! :)


Review Repairs: further clarify how new tags are handled - client discussion

Degree of administrator monitoring of new tags vs lag in post going live

Admin are willing to review tags before addition
Profession tags - keep high level, but admin can review
Provider - write custom keywords/tags for searches, not visible in dropdown or to seeker, just keywords for searches


Would be possible to provide an xdg module as well?

So people that want to migrate from directories can pave a no-friction upgrade path for their users.

Can you elaborate? The XDG directories are determined just by checking an environment variable and thats about it - I guess I can make that its own module, but it also doesn't seem that would be compatible with the behavior of directories?

I noticed now, yes it wouldn't be much useful until the xdg defaults are provided


The model box should be in the center of the page if the user is clicking on Quick view for any produt.

Bagisto Version: Master
Steps To reproduce--
1. Log in as a customer.
2. Mouse over on any bundle product.
3. Click on the quick view button
Expected result:  The model box should be in the center of the page if the user is clicking on Quick view for any product.
Actual result:  The model box is not in the center of the page if the user is clicking on Quick view for any product. Please find the screenshot Here

@jitendra-webkul
Now, this issue is fixed. Please find a screenshot Here, for future reference.


Can not implement prop onPageChange

Hi, I'm using react-table, I want to save pageIndex.
So, I use prop onPageChange={(pageIndex) => { console.log('ABC'); }}, but it doesn't works.
Please help me
<ReactTable           loading={false}           data={ this.state.data }           columns={columns}           showPageJump={false}           showPageSizeOptions={false}           pageSize={30}           onPageChange={() => { console.log('ABC'); }} />

onPageChange should work just fine in the latest version: https://github.com/tannerlinsley/react-table/blob/master/src/componentMethods.js#L297-L300
However, if you're looking to only monitor the page changing instead of managing the page changes, you may just want to subscribe using the onChange prop:
onChange={(state, instance) => { console.log(state.page) }}

Does this work for you @trangtv04110 ?

@tannerlinsley You are right.
Using onChange prop, it works good.
Thank you so much.


Move 'emberAfPluginIdentify[Start/Stop]FeedbackCallback' callbacks into src/app/clusters/identify

Problem
#3464 does not have any informations about plugins and will not generate definitions or stubs for the identify methods.
Summary of Changes

Move identify server plugin callbacks into src/app/clusters/identify
Remove the related definitions/stubs from gen/callback.h and gen/callback-stubs.c

I'm converting this PR as a draft since there is something I want to figured out first and I want to make sure it is not merged before.

Changing the status back to "Ready for review"


Connect mesher to elements

Hi @int-ptr-ptr. I’ve made some changes, but they aren’t exactly as you requested. I thought it would make sense to store elements and nodes in a dictionary, with the keys storing tags and the values storing coordinates for nodes or node tags for elements.
If this structure makes it difficult to interact with, please let me know, and I can change it.
Also, if you need any help with the integration, I would be happy to help. Perhaps I can write the code to translate my mesh to fit your interface.

It is certainly workable, but I worry about the inefficiencies of using a map to index nodes. I would expect that mesh.nodes would always be dense (contain all of the indices from 1 to num_nodes). If we re-index all nodes so that they are zero-indexed, then one can store all of the nodes in one large ndarray, allowing for vectorized access, say top_bdry_node_coords = mesh.nodes[np.array(mesh["top_boundary"].mesh[0].nodes.keys()),:]. The main thing that I am looking for is vectorization, but I think the memory overhead of having a separate coordinate array for each node is also notable.
If I were to integrate the mesher into elements, the first thing I would do would be to copy all of the data into full numpy arrays, so it would make sense to just have that in the base mesher already. If I was going to generate the position field from a mesh, I would do it with something like:
pos_field_coefs = base_mesh.nodes[surface_mesh.elements.T, :2]

It also looks like the position data is copied twice. If I modify the node coordinates from the submesh, it does not affect the main mesh node dictionary, which tells me there are two copies of the data.
tmp = mesh["top_boundary"].mesh[0].nodes[3][0] # store the old position temporarily
mesh["top_boundary"].mesh[0].nodes[3][0] = -1 # modify the submesh node coord
print(f"submesh node 3: {mesh['top_boundary'].mesh[0].nodes[3]}")
print(f"mesh node 3: {mesh.nodes[3]}")
mesh["top_boundary"].mesh[0].nodes[3][0] = tmp # restore the old position
# ========= OUTPUT ===========
submesh node 3: [-1.  1.  0.]
mesh node 3: [1. 1. 0.]

I initially thought keeping the structure as a dictionary might be preferable; it seems to be a more organic way to work with PyVista, since it requires both the coordinates of nodes and strips as its main arguments. But, I will try out the array appraoch you laid out here.

I think you could do both. If the dictionary works best for PyVista, you could override a __get_item__ dunder in some class somewhere, or you could just make the dictionary with slice subviews.

If we re-index all nodes so that they are zero-indexed, then one can store all of the nodes in one large ndarray, allowing for vectorized access...

@sinaatalay are we doing this or keeping the dictionary? I can review #13 if we're keeping it as-is.

I will do it. For now, can you manually put all the dictionary values into an array? It should be a line of code.
I think PR is good to review; it will be just a couple of lines of change. I will do it in my first opportunity.

This issue should be resolved by #33.


Best way to parse response after fetch()

I've been playing around with yamlscript after some time using denoflow, and I'm not sure how one can go about parsing the response of a fetch() call in the best way e.g. doing await response.json() after
- use: fetch
  args: https://actionsflow.github.io/test-page/reddit-sample.json

Some alternatives that come to mind are using
- use: eval
  args: "result = await result.json"

But it is not working since eval does not have an implicit return. Using a third party http client which auto-parses the response could work, but I'd like to keep it simple with fetch().
In denoflow there was a run field which came handy for running stuff after each step. Is this something that would also fit to the scope of this project. Or am I missing something and running arbitraty code e.g. for parsing response is alreafy possible?
Thanks in advanced!

Well, yamlscript is designed to write it simply, so in this case it will be:
- id: response
  use: fetch
  args: https://actionsflow.github.io/test-page/reddit-sample.json
- id: json
  use: response.json
- use: console.log
  args: $json

Considering this a really basic use case, I have added this to the readme.
https://github.com/yamlscript/yamlscript#use
Thanks for your issue! you may be the first person to try out this project! have fun, and any advice is welcome

It sounds great, do you have a public repo for that?

Not a public repo yet, but it might make it into netzo. The idea is to have shareable workflows distributed in the open-source marketplace. The declarative syntax of yaml makes workflows very portable and composable. Let me know if you are interested in learning more, I'll definitively stick around 😃

yeah. I'd love to test it, but now it seems more like deno deploy? or  https://pipedream.com ?
yaml is a very beautiful workflow syntax, but I found that for yamlscript, it still needs a lot of buildin functions to make it more enjoyable to use, currently using it can only do some simple work, complex work needs to write too many steps. More buildin is needed, but it seems that not many people are interested in this project, so there is no more progress for now.

Thanks for your comments! But yeah, the dashboard is not really using the yaml/json workflows. This could come in an additional "Workflows" module (currently WIP). But as I mentioned above, "Workers" already allow most workflow use cases with the full-flexibility of code, so we are working on bringing low-code features to the workers module as well.
Anyways, we are still exploring, I will most definitively keep you posted 👍🏼 ⚡


Impish Wrath (from Forest Imp)

Impish Wrath charges don't decrease when the reaction is used, allowing for infinite uses.

please share a save.

Fixed in dev.


Long duration Inertial Navigation capability

Since the course-keeping controller is now tested against non-linear dynamics of NPS AUV II, next task is to incorporate long duration autonomy to course-keeping deep sea mission.
Example mission to be pursued is Vizag to Andaman - stretch of ~2000 kilometers. This would induce serious errors in the controller due to:

Oceanic currents
Earth's curvature

Depth has to maintained constant at 300 meters (so, error in Z has to be monitored too). Sway distance should be kept as minimum as possible.
We start working on this from 1/1/2017. Essential theory required to develop the stack will be circulated soon.
attn : @AlphaMale1996 @shubhamjena

Assigned: Indirect Kalman Filter - Amanpreet.
Assigned: Earth Curvature code and gravity variation - Kshitij Goel

IKF - @aniket11bh
Earth curvature gravity correction - Kshitij
Latitute + Longitude inclusion into the system - Kshitij + @aniket11bh