history can't be used for a second action

If I move an email to a folder and after that I want to go there or move a second email to the same folder, I always have to type again the folders name to be able to select it. Even it is listed in the hostory above the input, I can't select any entry of the history. Neither with mouse nor with cursor keys.
TB 68.9.0
Nostalgy 1.0.21 (xpi from 2020-01-03)

I think this is related to issue #54 or #55

@Olifair Maybe, but this is not 100% clear. And the issue with me is only with the Nostalgy fork for TB68.
With Nostalgy 0.3 in TB 52.9 the history navigation and entry selection is working fine. So, it could be a bug or a missing implementation in version 1.x.

I think the history works if you do left arrow, then you can scroll in the history.

I think the history works if you do left arrow, then you can scroll in the history.

Left is no workaround on my System ... I tried a lot. Every "s" requieres a complete new search ...
For the same folder I use SHIFT+[s, g].
Windows 10 1909 x64 (aktuell), Thunderbird 68.9.0, Nostalgy 0.3.

yes, TB has changed the way how S is used (S sets star on emails, and pressing S is handled differently by TB now as compared to pre TB 59.). Also, TB autocomplete has changed as how to create/fill the initial box with the history.
It might help to set another character, one which is not in use by TB (just press a few letters by trial and error and choose one that does nothing). I am updating for 78, and history will/will not work there, depending how the TB core is changed.
Klaus

On 6/30/2020 1:41 AM, rmmbr wrote:

I think the history works if you do left arrow, then you can scroll in the history.

Left is no workaround on my System ... I tried a lot. Every "s" requieres a complete new search ...
For the same folder I use SHIFT+[s, g].
Windows 10 1909 x64 (aktuell), Thunderbird 68.9.0, Nostalgy 0.3.

Interesting.  For me, left, then up, pops up the menu within which one can scroll ...
EM

Ah great, don't know why I hadn't tried this, probably because when hitting "s", the menu pops up and when hitting "<-" it disappears again, but when then hitting "up" it comes back !!! Great !!!! This will facilitate my archiving of emails so much.

@Olifair: with your description I get the history back too

yes, but finally I had to realise that you get the history back, not the statistical prediction pop-up list (which in my case is switched on and is the first pop-up list) ... and this is a pity.


Is there a way to limit an output to only being connect to one input?

I'm building a custom process flow where you specify the order of execution based on connecting an output to an input. I'm using this for being able to build a behavior tree. Is there a way to limit an output to only having one connection?

Yes, it's the allowMultiple parameter in the Output attribute is made for that: https://github.com/alelievr/NodeGraphProcessor/blob/master/Assets/com.alelievr.NodeGraphProcessor/Runtime/Graph/Attributes.cs#L36

Thanks! Can't believe I missed that haha


Blaze support

Hello,
it will be nice if variables explorer could support Blaze blaze.interactive.InteractiveSymbol
import blaze as bz
table_uri = 'dialect+driver://user:password@host:port/databasename::tablename'
dat = bz.Data(table_uri)

http://blaze.pydata.org
http://blaze.pydata.org/en/latest/rosetta-pandas.html
http://blaze.pydata.org/en/latest/uri.html
with such a feature it will become possible to display inside variables explorer content of :

CSV files
database tables supported by SQLAlchemy (even very long tables !!!)

such feature is now available in gtabview https://github.com/wavexx/gtabview
see https://github.com/wavexx/gtabview/blob/master/gtabview/models.py ExtBlazeModel
Kind regards
PS: contrary to Pandas
import pandas as pd
from sqlalchemy import create_engine
db_uri = 'dialect+driver://user:password@host:port/databasename'
engine = create_engine(db_uri)
df = pd.read_sql("tablename", engine)

Blaze doesn't need to fetch the whole table into memory... and so that's very quick.

Cool :-), @ccordoba12 I already have some work in the QTableQuick widget to handle the numpy and pandas cases (of not loading the whole array), and it seems to work fine :-),  (beta 4 most likely)

Cool! But beta 4? Remember that we're going to have three betas for new features, and that release candidate is meant for bug fixes only.

Oops, beta 3 I meant then....

I'm going to mark this one as duplicate of issue #2553, to consolidate everything in one place.

@scls19fr, please don't open more issues about things supported by gtabview that we don't support.
Instead of that, we should try to see how to use gtabview as a library.

Glad to know. Thank you in advance for your help!


Unable to use I18n backend

Hi @berk ,
I am unable to use I18n backend ymls, like when I am trying to use I18n.backend = I18n::Backend::Tml.new and use this method
=number_to_currency(1000,:locale=>:fr)
It's fallback to :en and I am getting only $ is my currency unit.
Please help me ASAP
Many Thanks

@viveks1422, to change the currency unit, you actually have to specify the unit yourself:
<%= number_to_currency(1000, unit: '€') %>
or use the i18n files to overload it for the locale. We currently fallback on to the default i18n system for numbers, distances, etc...
https://github.com/translationexchange/tml-rails/blob/master/lib/i18n/backend/tml.rb#L63

Hello @berk,
We're having similar issue with tml_rails and I18n.
We have a ton of locales with the same language, e.g. es_MX and es_ES; or en_* for the locales/languages we don't have translations yet; etc.
What I'm trying to say, locale != language. We want to use good old I18n for locales and tml_rails for translations. This is why we need them to work together without interference.
This is why I think this commit https://github.com/translationexchange/tml-rails/commit/aba17d9e47917f8a4cba44f648acffb964fd2b18 has a bug.
The I18n.backend.class.name == 'I18n::Backend::Tml' check was removed and now tml is trying to reset I18n locale, even if we don't use I18n::Backend::Tml backend.
I want tml to be a nice guy and touch I18n.locale only when I allow it by using I18n::Backend::Tml backend.
I monkey patched it, do you think my monkey patch can cause some problems? Do you plan to put if I18n.backend.class.name == 'I18n::Backend::Tml' back in place?
Regards,
Anatoliy


feat: allow to configure api client when initializing light client

Motivation
Since https://github.com/ChainSafe/lodestar/pull/6749 it is possible to configure the wire format. The light client uses SSZ by default, but for debugging purposes or just user preference we should allow to configure the LC to use JSON instead. Being able to control other api client options like timeout might be useful as well.
Description

allow to configure api client when initializing light client
fix README examples

:tada: This PR is included in v1.23.0 :tada:


Create dataset loader for ViSpamReviews

Dataloader name: vispamreviews/vispamreviews.py
DataCatalogue: http://seacrowd.github.io/seacrowd-catalogue/card.html?vispamreviews

Dataset
vispamreviews

Description
The dataset was collected from leading online shopping platforms in Vietnam. Some of the most recent selling products for each product category were selected and up to 15 reviews per product were collected. Each review was then labeled as either NO-SPAM, SPAM-1 (fake review), SPAM-2 (review on brand only), or SPAM-3 (irrelevant content).

Subsets
-

Languages
vie

Tasks
Text Classification

License
Creative Commons Attribution Non Commercial 4.0 (cc-by-nc-4.0)

Homepage
https://github.com/sonlam1102/vispamdetection/

HF URL
-

Paper URL
https://link.springer.com/chapter/10.1007/978-3-031-21743-2_48

#self-assign

I am in China and on vocation, don’t have a good network to access the github, will update the repo when back after 2.18.
From: github-actions[bot] @.>
Date: Thursday, 25 January 2024 at 10:09
To: SEACrowd/seacrowd-datahub @.>
Cc: Yuze GAO @.>, Assign @.>
Subject: Re: [SEACrowd/seacrowd-datahub] Create dataset loader for ViSpamReviews (Issue #310)
Hi, may I know if you are still working on this issue? Please let @holyloveniahttps://github.com/holylovenia @SamuelCahyawijayahttps://github.com/SamuelCahyawijaya @sabilmakbarhttps://github.com/sabilmakbar know if you need any help.
—
Reply to this email directly, view it on GitHubhttps://github.com/SEACrowd/seacrowd-datahub/issues/310#issuecomment-1909227759, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AFOFKPLSYVFMKWN2JSLPH33YQG5ELAVCNFSM6AAAAABBUGZOE6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBZGIZDONZVHE.
You are receiving this because you were assigned.Message ID: @.***>

Hi @, may I know if you are still working on this issue? Please let @holylovenia @SamuelCahyawijaya @sabilmakbar know if you need any help.

Hi, am back from China, will create the dataloader shortly.


Rearrange page information: left is facts, right is why

Left column focuses on facts of the workshop, with most important
stuff at the top.
Right is the whys and hows.
Most important information goes to the tops always.  Also try to
de-duplicate.
There are also some other checks.
For review: please sanity check that this makes sense and it's a
good arrangement.  What else can be simplified.  Especially, how can
we make the concept of teams and how they are registered more clear?

It's really better. Once the workshop page "stabilizes" we should also get the changes back into the template.


Clicking logout button fix

fixes #120
@gbowne1 I have fixed redirecting issue as well as added toast messages
please review and merge it!

@ratishjain12
Can you please provide some screenshots of your changes in your PR description?

Hii @ratishjain12
Thanks for your Contribution🙌
It gives us the enhanced user experiance with toast

@LOGESH-B your welcome, looking forward to improve this project by making great contributions 😁


fix(client): fix voprf proof always verifying

        if ( // VVVVV ooops
            !evaluation.proof.verify_batch(
                [this.gg.generator(), pkS],
                zip(finData.evalReq.blinded, evaluation.evaluated)
            )
        ) {
            throw new Error('proof failed')
        }

A promise will always evaluate as truthy so the check would always verify regardless of whether proof was valid
Upon fixing that discovered a bug in the example:

TODO:

[x] Add an actual test for when a proof is invalid (e.g. signed with a different key)

@armfazh
Welcome :)


Native linux support

Overview
I know this sounds disappointing and actually I'm but I really don't have the time and it will take from me 6-12 months before I can touch the project so I decided that I at least should enable running the Linux example
So we can run and test it
I didn't do anything else
Just connected the Linux plugin to pubspec.yaml
This doesn't affect the other platforms and the only change that we can run the example on Linux
that's all
but the method channels will throw an Exception just like when using the library in a project that supports Linux
You can reject the PR as it doesn't change much, Linux is still unsupported, this is why I suggested to stick to the dart impl as I already implemented it before a few months ago

discord

@natsuk4ze. you can find me in pub channel on flutter

I added the plugin interface for gal without new package or doing a breaking change

OK.
I haven't done a thorough investigation of dart-only-platform-implementations yet, but wouldn't this allow us to remove the gal_linux folder and put all your Linux implementations in a linux folder?

Two folders for linux is weird, so let's make it one.

Actually, it's one
But if you mean two folders
The other one for the example and this can't be deleted. Otherwise, we can't run the example on Linux
It is just for the example
It won't affect the end developer who will use the library for linux

All plugins have two folders for all platforms
One for the example
The other for the plugin itself

Then the linux_gal folder should be under linux.

One idea is to publish the linux support as your extension package and introduce it in the gal readme. This way you are free to write your code.

natsuk4ze. is my username

natsuk4ze. is my username

Sent you a message there


confirm and news adjustment#170

confirm alignment
update selected information's  background-color;
adjust the proptip's position in the namespace and mosaics

linter breaking
https://travis-ci.org/github/nemfoundation/symbol-desktop-wallet/jobs/668626812
Please before pushing always run npm run lint:all:fix


T23292 sort data manager context menu extensions master

Context menu entries from DataManager's extension point "org.mitk.gui.qt.datamanager.contextMenuActions" are added in their (random) order of service listing. This can be confusing when there is more than one entry and the order changes with every application start.
(Though I know that the current mechanism is debated and could use a rewrite) I added a simple alphabetical sorting to the code. This improves the current situation for users.

Has been included


THRIFT-3743 Java JSON protocol left in incorrect state when an exception is thrown during read or write operations

This is the same issue as THRIFT-1473 (Delphi) and THRIFT-3735 (Go) but for the Java library.
The JSON context stack may be left in an incorrect state when an exception is thrown during read or write operations. This leads to further errors while writing/reading the NEXT message, because incorrect characters may be written or expected.
@stevenosborne-wf
@markerickson-wf

The Travis build failure appears to be an unrelated npm error...

+1
We do something similar in Dart, for what it's worth - https://github.com/apache/thrift/blob/master/lib/dart/lib/src/protocol/t_json_protocol.dart#L187

+1

@jfarrell this was merged, and the PR can be closed.


webhook

Signed-off-by: veophi<EMAIL_ADDRESS>
add validate webhook for rollouts
add mutate webhook for workloads
base codes are copy from Openkruise/Kruise.

/lgtm

/approve


No possibility to define WhisperModel compute_type when using GenericLoader with blob_parser=FasterWhisperParser

Checked other resources

[X] I added a very descriptive title to this issue.
[X] I searched the LangChain documentation with the integrated search.
[X] I used the GitHub search to find a similar question and didn't find it.
[X] I am sure that this is a bug in LangChain rather than my code.
[X] The bug is not resolved by updating to the latest stable version of LangChain (or the specific integration package).

Example Code
import torch
from langchain_community.document_loaders import YoutubeAudioLoader
from langchain_community.document_loaders.generic import GenericLoader
from langchain_community.document_loaders.parsers.audio import (
    FasterWhisperParser
)

device = 'cuda' if torch.cuda.is_available() else 'cpu'
# float32
compute_type = "float16" if device == 'cuda' else 'int8'

yt_video_url = 'https://www.youtube.com/watch?v=1bUy-1hGZpI&ab_channel=IBMTechnology'
yt_loader_faster_whisper = GenericLoader(
    blob_loader=YoutubeAudioLoader([ yt_video_url], '.'),
    blob_parser=FasterWhisperParser(device=device)
    # no possibility to define compute_type
    # Error: ValueError: Requested float16 compute type, but the target device or backend do not support efficient float16 computation.
    # blob_parser=FasterWhisperParser(device=device, compute_type=compute_type)
)
yt_data = yt_loader_faster_whisper.load()

Error Message and Stack Trace (if applicable)
Traceback (most recent call last):
  File "python/helpers/pydev/pydevd.py", line 1551, in _exec
    pydev_imports.execfile(file, globals, locals)  # execute the script
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "python/helpers/pydev/_pydev_imps/_pydev_execfile.py", line 18, in execfile
    exec(compile(contents+"\n", file, 'exec'), glob, loc)
  File "AI-POC/frameworks/langchain/01_chat_with_data/main.py", line 133, in <module>
    docs_load()
  File "AI-POC/frameworks/langchain/01_chat_with_data/main.py", line 123, in docs_load
    get_youtube(use_paid_services=False, faster_whisper=True, wisper_local=False)
  File "AI-POC/frameworks/langchain/01_chat_with_data/main.py", line 108, in get_youtube
    yt_data = yt_loader_faster_whisper.load()
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "AI-POC/.venv/lib/python3.11/site-packages/langchain_core/document_loaders/base.py", line 29, in load
    return list(self.lazy_load())
           ^^^^^^^^^^^^^^^^^^^^^^
  File "AI-POC/.venv/lib/python3.11/site-packages/langchain_community/document_loaders/generic.py", line 116, in lazy_load
    yield from self.blob_parser.lazy_parse(blob)
  File "AI-POC/.venv/lib/python3.11/site-packages/langchain_community/document_loaders/parsers/audio.py", line 467, in lazy_parse
    model = WhisperModel(
            ^^^^^^^^^^^^^
  File "AI-POC/.venv/lib/python3.11/site-packages/faster_whisper/transcribe.py", line 145, in __init__
    self.model = ctranslate2.models.Whisper(
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^
ValueError: Requested float16 compute type, but the target device or backend do not support efficient float16 computation.

Description
I'm trying to use the FasterWhisperParser class from the langchain_community package to parse audio data. I want to be able to use a GPU if one is available, and fall back to a CPU otherwise.
I'm trying to set the compute_type to 'float16' when using a GPU and 'int8' when using a CPU. However, I'm encountering an issue because the FasterWhisperParser class doesn't accept a compute_type argument. When I try to use a CPU, I get a ValueError because 'float16' computation isn't efficiently supported on CPUs.
System Info
$ python -m langchain_core.sys_info

System Information
------------------
> OS:  Linux
> OS Version:  #1 SMP PREEMPT_DYNAMIC Thu May 11 15:56:33 UTC 2023
> Python Version:  3.11.6 (main, Oct  3 2023, 00:00:00) [GCC 12.3.1 20230508 (Red Hat 12.3.1-1)]

Package Information
-------------------
> langchain_core: 0.2.11
> langchain: 0.2.6
> langchain_community: 0.2.6
> langsmith: 0.1.83
> langchain_text_splitters: 0.2.2

Packages not installed (Not Necessarily a Problem)
--------------------------------------------------
The following packages were not found:

> langgraph
> langserve

Root cause:
https://github.com/langchain-ai/langchain/blob/ee579c77c1691bdf6b39aef649e1570516917e28/libs/community/langchain_community/document_loaders/parsers/audio.py#L468


Subscriptions auto renewal

Hi
I am trying to setup the subscriptions functionality in Woocommerce
https://woocommerce.com/products/woocommerce-subscriptions/
The Swedbank Pay Checkout indicates that it shall support auto renewals. See attached screenshot.

During the checkout process everything seems fine. Only one payment option is available (credit card). I assume that is because of the auto renewal functionality. That is OK.
The problem occurs during the first renewal. A new renewal order is created by the system but the payment status is pending. The customer need to manually do a new payment from the account page. During that payment process all payments options are available.
Expected behaviour is that the customer shall not manually do a new payment. This should be automatic.
Thanks

Hello. is the product a virtual product?

No, it is of type "simple subscription. See attached screenshot.

@aait Can you attach screenshot of order view screen in the admin backend please?

@aait btw, If we are talking about "Checkout" plugin then please open issue there https://github.com/SwedbankPay/swedbank-pay-woocommerce-checkout

Any special info from the order page?

HI again, any progress or findings on this topic? I have customers asking for this feature and need to find a way forward. Thanks.

@christianz123 Hello! I need to clarify some information. Could you contact me please<EMAIL_ADDRESS>

Sorry this issue is related to the checkout plugin. The naming is very similar :)
I created a new issue in the other repository. This one can be closed.

https://github.com/SwedbankPay/swedbank-pay-woocommerce-checkout/issues/82


unixPB: Update playbook for SLES12SP5

Updated repo to SLE_12_SP5, and moved systemtap-sdt-devel from Build_Tool_Packages package list to Additional_Build_Tools_SLES15 .
This fixes issue #1820
Signed-off-by: Sej<EMAIL_ADDRESS>
Checklist

[x] commit message has one of the standard prefixes
[ ] FAQ.md updated if appropriate
[ ] other documentation is changed or added (if applicable)
[ ] playbook changes run through VPC or QPC (if you have access)
[ ] inventory changes, ensure bastillion is updated accordingly

Note: VPC is currently broken at the minute, but even if it wasn't, there's little point in running it, as we don't test for SLES :-)

Note: VPC is currently broken at the minute, but even if it wasn't, there's little point in running it, as we don't test for SLES :-)


[vm/ffi] Static @NativeCallbacks API

@mkustermann suggested we should have static binding for native callbacks as well, as the dual for the @Native external functions.
We would move the information from Pointer.fromFunction to the declaration site (static functions):
@NativeCallback<void Function()>(
  exportAs: 'setupPrint',
  exceptionalReturn: <...>,
  callbackSemantics: <...>,
)
void setupPrint() {}

void main(){
  final callbackPointer = Pointer.addressOf<void Function()>(setupPrint);
}

Having this more static information would make it in the future possible to compile a Dart aot snapshot in such a way to statically link unresolved symbols from C static libraries to the Dart functions (or rather the FFI callback trampolines for these). The dual to:

https://github.com/dart-lang/sdk/issues/49418

The NativeCallback definition would look something like:
/// Annotation specifying how to bind a Dart function to native code.
///
/// The annotation applies only to static function declarations.
///
/// Example:
///
/// [...]
///
/// NOTE: This is an experimental feature and may change in the future.
@Since('3.1')
class NativeCallback<T> {
  /// If an exception is thrown while calling the function this annotation is on,
  /// the native function will return [exceptionalReturn],
  /// which must be assignable to return type of [T].
  final Object? exceptionalReturn;

  /// The threading semantics when this function is called from native.
  ///
  /// See the documentation on [CallbackSemantics].
  final CallbackSemantics semantics;

  /// The name to be made available to the native linker.
  ///
  /// Defaults to the function name when omitted.
  ///
  /// Example:
  ///
  /// [...]
  ///
  /// Prefer omitting the [symbol] when possible.
  // Note: this does nothing as long as we don't implement static linking.
  final String? exportAs;

  const Native({
    this.exceptionalReturn,
    this.semantics = CallbackSemantics.alreadyEnteredCorrectIsolate,
    this.exportAs,
  });
}

@Since('3.1')
class CallbackSemantics {
  CallbackSemantics._();

  /// [...]
  static const CallbackSemantics alreadyEnteredCorrectIsolate = ...;

  /// [...]
  static const CallbackSemantics asyncVoid = ...;
}

This would prevent using the same Dart function as callback with two different settings, but that could be worked around by creating two top level functions with differing @NativeCallback annotations.
The new API would not support closures (which is also prohibited in the current API). But, for closures we likely need some API that would enable us to weakly hold on to an isolate and tell an isolate that a closure can be released.
Related issues:

https://github.com/dart-lang/sdk/issues/51350

If we change to a new API, we would deprecate the old API and not have to introduce a named-arguments-variant.
We could implement the CallbackSemantics as another optional positional argument for the time being.

https://github.com/dart-lang/sdk/issues/50552

The addressOf dual for native functions instead of Dart functions.

cc @liamappelbe, @mkustermann, @mraleph

Duplicate of https://github.com/dart-lang/sdk/issues/51383.


behaviorVars should be passed in ProviderConfig

Signed-off-by: Fahed DORGAA<EMAIL_ADDRESS>
Description of your changes

Fixes #  as mentioned in design behavior vars should be passed in ProviderConfig
I have:

[x] Read and followed Crossplane's contribution process.
[x] Run make reviewable to ensure this PR is ready for review.
[ ] Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

@morningspace check-diff fixed I will merge this PR


many duplicate documents returned when using es-hadoop to query compared to curl

What kind an issue is this?

Bug report.

Issue description
Description: es-hadoop return many duplicated documents when i use range filter on timestamp.
Steps to reproduce
Code:

when i use following shell to get the curl result, i can get only 2 hits.

curl -u username:password -H 'content-Type:application/json' -XGET my_ip:port/filer-*/_search?pretty -d'
{
  "query": {
    "bool": {
      "must": [
        {
          "term": {
            "event.dataset": "auditd.log"
          }
        },
        {
          "term": {
            "auditd.log.from": "smb"
          }
        },
        {
            "range" : {
                "auditd.log.timestamp" : {
                    "gte" : "1591090993",
                    "lt" :  "1591092573"
                }
            }
        },
        {
          "bool": {
            "minimum_should_match": "1",
            "should": [
              {
                "term": {
                  "auditd.log.action": "create"
                }
              }
            ]
          }
        }
      ]
    }
  },
  "sort": [
    {
      "auditd.log.timestamp": {
        "order": "desc"
      }
    }
  ]
}'

but when i use the same query in es-hadoop to do the same thing, it returned 68 hits, with many documents duplicated. Then i run dropDuplicates() can remove all the duplicated documents to get 2 remaining documents which is same as the curl result.

import org.apache.spark.sql.types._

var q = """
{
  "query": {
    "bool": {
      "must": [
        {
          "term": {
            "event.dataset": "auditd.log"
          }
        },
        {
          "term": {
            "auditd.log.from": "smb"
          }
        },
        {
            "range" : {
                "auditd.log.timestamp" : {
                    "gte" : "1591090993",
                    "lt" :  "1591092573"
                }
            }
        },
        {
          "bool": {
            "minimum_should_match": "1",
            "should": [
              {
                "term": {
                  "auditd.log.action": "create"
                }
              }
            ]
          }
        }
      ]
    }
  },
  "sort": [
    {
      "auditd.log.timestamp": {
        "order": "desc"
      }
    }
  ]
}"""

var my_index = "filer-*"

val options = Map("es.nodes" -> "my_ip",
                  "es.port" -> "port",
                  "pushdown" -> "true",
                  "es.nodes.wan.only" -> "true",
                  "es.nodes.discovery" -> "false",
                  "es.net.http.auth.user" -> "username",
                  "es.net.http.auth.pass" -> "password",
                  "es.query" -> q,
                  "es.read.field.include" -> "@timestamp, auditd.*",
                  "es.scroll.size" -> "1000",
                  "double.filtering" -> "true"
                  )

// Spark 1.4 style
val spark14DF = sqlContext.read.format("es")
                        .options(options)
                        .load(my_index)

spark14DF.count()   // this gives 68

Strack trace: no error logs shown, seems everything goes well.
Version Info
OS:         :  Ubuntu 16.04.6 LTS
JVM         :  openjdk version "1.8.0_242"
Hadoop/Spark:  spark 2.4.6-snapshot
ES-Hadoop   :  7.6.0
ES          :  6.5.4

If a reduce task fails, and then try again, is this part of the data written repeatedly?I feel like this will also lead to duplication.

@schahaha thanks for reply. I think even there is duplicate data, curl command should return those because they have diffent id in ES. so issue here is curl and ES-hadoop give diffrent result with the same query.

A couple of questions here:

When you say duplicates, do you mean documents that should not have matched the query were returned, or do you mean multiple copies of the same document were returned?

is this reproducible in a consistent manner? Was there anything happening on the cluster when this occurred? Were there any task level failures when this happened?

Can you describe how your index is configured, and how the data is indexed within it?

Closing since no further feedback was received.


Use render function for components

I want to enable the following use case:
const MyComponent = () => {
    const [state, useState] = useState("");
    ...some state logic

    const renderToolbar = (props) => {
        ...some logic that consumes the state above
        return <MToolbar {...props} />
    }

    return (
        <MaterialTable
            ...
            components={{
                Toolbar: renderToolbar
            }}
        />
    )
}

Currently overridden components will always be remounted when the state changes because of reference inequality.
Below is a simple demonstration of the current behaviour. Notice the behaviour when clicking on the checkbox.
https://codesandbox.io/s/material-table-starter-template-forked-nwshky?file=/src/index.js
A possible workaround is to pass the state using Context, but I think it would be kind of overkilling.

This is actually a react problem because react needs a stable object reference to keep the state.
Nothing we can do about this on the lib level.
One workaround could be:
const MyToolbar = React.useCallback((props) => (
    <Box>
      <SomeComponent
        search={search}
        onSearchChange={(event, checked) => setSearch(checked)}
      />
      <MTableToolbar {...props} />
    </Box>
  ),[]);

The search state comes from the parent component (i.e App) directly, so we need to add it in the dependency array. The sandbox should also warn you about this.
const MyToolbar = React.useCallback((props) => (
    <Box>
      <SomeComponent
        search={search}
        onSearchChange={(event, checked) => setSearch(checked)}
      />
      <MTableToolbar {...props} />
    </Box>
  ),[search]);

It seems working because I used wrong prop (value) for the  component. I have updated the sandbox and you may try again.

Haven't tried but I think following snippet can help support the use case.
const renderComponent = (component, props) => {
    if (typeof component === "function") {
        // just capitalize it to feel better
        const Component = component;
        return <Component {...props} />
    } else if (typeof component === "object") {
        if (typeof component.render === "function") {
            return component.render(props);
        }
    }

    throw new Error("Failed to render component!");
}

I can submit a PR if you want.

I don't think that this would actually help keeping the state I think, because a new function is created anyway. Did you check this or have a sandbox to verify this?

demo: https://codesandbox.io/s/young-fog-ks52n4?file=/src/App.js
Try updating both  state and update the parent to force a render. You can see that using the function method won't reset the inner state.

Yes but you are fixing a problem that comes only from mismanaging the react tree and those associated states. Can you just use it as a normal external function?

By further evaluation I agree that the components should be provided as stable components instead of functions that returns component. Additional information should be passed by either context or props, but it is another issue.


nixos/rspamd: worker configuration, socket activation and tests

Motivation for this change
These two commits add first tests for existing rspamd module and then updated the module so that you have more control over workers configuration and add support for socket activation.
Care has been taken for the updated module to stay compatible with existing configurations with tests to verify that this is the case.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[X] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[X] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[X] Fits CONTRIBUTING.md.

Failure on x86_64-linux (full log)
Partial log (click to expand)
error: attribute ‘x86_64-linux’ in selection path ‘tests.rspamd.x86_64-linux’ not found

Success on aarch64-linux (full log)
Partial log (click to expand)

The test errors seem to be because rspamd has subtests so the selection path should be tests.rspamd.bindports.x86_64-linux

@GrahamcOfBorg test rspamd.bindports rspamd.deprecated rspamd.ipv4only rspamd.ipv4only-socketActivated rspamd.simple rspamd.simple-socketActivated rspamd.socketActivated

Failure on x86_64-linux (full log)
Partial log (click to expand)
trace: warning: The option `services.rspamd.bindUISocket' defined in `<unknown-file>' has been renamed to `services.rspamd.workers.controller.bindSockets'.
trace: warning: The option `services.rspamd.bindSocket' defined in `<unknown-file>' has been renamed to `services.rspamd.workers.normal.bindSockets'.
error: attribute ‘socketActivated’ in selection path ‘tests.rspamd.socketActivated.x86_64-linux’ not found

Failure on aarch64-linux (full log)
Partial log (click to expand)
trace: warning: The option `services.rspamd.bindUISocket' defined in `<unknown-file>' has been renamed to `services.rspamd.workers.controller.bindSockets'.
trace: warning: The option `services.rspamd.bindSocket' defined in `<unknown-file>' has been renamed to `services.rspamd.workers.normal.bindSockets'.
error: attribute 'socketActivated' in selection path 'tests.rspamd.socketActivated' not found

@andir Ups I had inconsistently named the tests. Could I trouble you with redoing the @GrahamcOfBorg test command since the tests are now named consistently.

@GrahamcOfBorg test rspamd.bindports rspamd.deprecated rspamd.ipv4only rspamd.ipv4only-socketActivated rspamd.simple rspamd.simple-socketActivated rspamd.socketActivated

Success on x86_64-linux (full log)
Partial log (click to expand)
machine# [   26.373297] rspamd[765]: <4pr1kh>; map; read_map_file: /nix/store/dddvgkwkx31ic2q3wdfx18xsfnqpvy0b-rspamd-1.6.5/etc/rspamd/2tld.inc: read map dat, 8213 bytes
/nix/store/dccvpliw89gfhr5v5qypafz7039p46b5-vm-test-run-rspamd-socketActivated
machine# [   26.375293] rspamd[765]: <4pr1kh>; map; rspamd_map_file_read_callback: rereading map file /var/lib/rspamd/2tld.inc.local
machine: exit status 0
machine# [   26.379489] rspamd[765]: <4pr1kh>; map; read_map_file: /var/lib/rspamd/2tld.inc.local: map file is unavailable for reading
test script finished in 28.00s
cleaning up
killing machine (pid 593)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/tmp/nix-build-vm-test-run-rspamd-ipv4only-socketActivated.drv-0/vde1.ctl': Directory not empty

Success on aarch64-linux (full log)
Partial log (click to expand)
killing machine (pid 627)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/fz5chxdw0bwpbqlzp7liwhh3zx1vkxm7-vm-test-run-rspamd-bindports
/nix/store/6n40vxv5jxg8ppmwi6mgspxyl7w0ljii-vm-test-run-rspamd-deprecated
/nix/store/hfxlhva4hrh2vh75f71hsf8ygqk0dk4b-vm-test-run-rspamd-ipv4only
/nix/store/7zks4mmam1f6p65m9n5jz39wbabnw5pf-vm-test-run-rspamd-ipv4only-socketActivated
/nix/store/n5cpyx9zy07x8rx7plr7s18m7dlmj5b1-vm-test-run-rspamd-simple
/nix/store/abxjhj5zszrk3amfsgmxz738y879c00n-vm-test-run-rspamd-simple-socketActivated
/nix/store/2q6ckm8c512np2051fqz6fmpgs5gd156-vm-test-run-rspamd-socketActivated


Enter the text console Mode when shutting down and add a white screen to cover it

This will appear during startup or shutdown. It is not very good-looking. It should be a solid color block and put the cursor at the front.

This would need to be addressed in FreeBSD; I can do nothing about it.

I want to make an unrelated guess, maybe it is wrong and outrageous. The previous version was that the Boot splash was originally a white image on a black background, but after the color was flipped in the later version, it was found that the image became black instead of the desired gray. , so I’m adding a white transparent one. I want to ask if this is the case.

Well, on my system both the boot and the shutdown are gray, so I don't know why it is not working on some machines. In general, setting the colors of the text console should last for the entire session (boot and shutdown), we are not setting the colors more than once.

Otherwise, it might be left over from the white faded animation. This is just a guess.

The better news is that with your new file manager "boot -v" it doesn't show that thing.
However, there is still this problem.

https://forums.freebsd.org/threads/colorize-your-bsd-shell.85458/
Maybe this can help.

Yes, it might work to set the foreground color to "black" like the background. ("Black" is light grey in our case.)

https://forums.freebsd.org/threads/how-to-change-background-color-of-freebsd-terminal.69893/
This is another possible solution found.

Yes. It would be helpful if you could them and let me know if you have found a working one. Thanks!

Only this time did I realize that it was the text and background of the text console Mode. We didn’t need to adjust it at all. Instead, it should have a white overlay.

And we need to avoid changing the font color of the text console Mode, because this will make the text console Mode use user methods.

I don't quite understand. When booted in verbose mode, the messages during boot and shutdown should look similar to this:


Standardize paginated index methods

The idea of this PR is to standardize the methods used to build index queries in different controllers, so that we can build a set of alternate methods that use AR instead of Query. Then, we can switch over one controller at a time.
Things to note:

The index method is again defined in each controller, instead of implicitly in the ApplicationController::Index

It simply delegates to build_index_from_query (the old index method defined in ApplicationController)
When we figure out a build_index_with_active_record, the idea is to have each index instead delegate to that, when it's ready

index_subaction_param_keys and index_subaction_dispatch_table are changed from ivars to methods
Many repetitive declarations are DRY'd up to the ApplicationController::Index

I'm not expecting a code review, these changes are vast. What would be good is a spot check of any indexes you care about, just to be sure they're behaving.
Note that param names have been standardized. I believe the only URL that's changed that would be linked from the outside is herbaria_path(flavor: :all), which is now just herbaria_path. Fortunately the index action will simply ignore the flavor param if anyone sends it, so old links will still work. herbaria_path(flavor: :nonpersonal) has changed to herbaria_path(nonpersonal: true), so if there are external links to that, maybe we should add a redirect in routes.

coverage: 93.491% (-0.03%) from 93.522%
when pulling 5668fd58b02732c1373afc3caee2cbb755cddf5b on standardize-controller-indexes
into 7d3a282443a00de0d7f6d70c60d90277d4561f43 on main.

Thanks for the feedback. I would have tried it myself; then I would have
gotten the same offense and would have found the correction.
On Sat, Dec 14, 2024 at 1:14 PM andrew nimmo @.***>
wrote:

@.**** commented on this pull request.
In app/controllers/application_controller/indexes.rb
https://github.com/MushroomObserver/mushroom-observer/pull/2573#discussion_r1885391252
:

bail = false

index_active_params.each do |subaction|

 next if params[subaction].blank?

 query, display_opts = send(index_param_method_or_default(subaction))

 # Some actions may redirect instead of returning a query.

 # If we have the param but get a blank query we should bail.

 if query.blank?

   bail = true

   break

 end

 # If we have a query, display it.

 return filtered_index(query, display_opts)

end
return if bail

Ah - thanks for the suggestion. That's what I had originally, but Rubocop
Lint/NonLocalExitFromIterator didn't like it. It said "Non-local exit
from iterator, without return value. next, break, Array#find, Array#any?,
etc. is preferred."
I tried switching it to break, but then the tests fail with
"AbstractController::DoubleRenderError". That's when i tried the bail
thing. But I'm just now tweaking your version to explicitly return nil
and that's working, and not offending Rubocop.
Committing that now. Thank you! The bail was bugging me.
—
Reply to this email directly, view it on GitHub
https://github.com/MushroomObserver/mushroom-observer/pull/2573#discussion_r1885391252,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAALDFAFSQU6BZBJIYJFW5T2FSNT5AVCNFSM6AAAAABTL3ZB6WVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKMBUGI2TKMZQGQ
.
You are receiving this because your review was requested.Message ID:
@.***
com>


Update README.md

Change the addBastiInstance function to allowBastiInstanceConnection we decided to change the function name, but I did not update the docs. This PR fixes that.

Thank you @bobveringa!


Implement /accounts/{id} endpoint using experimental ingestion

The /accounts/{id} endpoint is special because it contains balances of all assets. Here's the initial plan for this endpoint migration:

Create processors adding/updating/removing accounts and account data to Horizon DB.
Update existing action code to check if the data matches the data in core DB (it should display only the data from stellar-core in Horizon 0.22.0). (#1726)
We should start displaying data ingested by the new system when history endpoints are implemented.

Closed in #1868.


Add a license

Hi Adam!
Very much enjoying the YouTube videos, they're so well done. I was wondering if I could integrate some of your CSS in an Open-Source project of mine, but I didn't find a license for the code, which AFAIK means you have the full copyright to the code and no one else can use it. If that's the case you want this code to be, that's fine by me, but I was curious anyway.

apache license added 👍🏻
please, go use my code in your open source project 🙂


move to v108 of plugin; remove some config.xml redundancy

@bparees - ptal
fyi - specifying values in the config.xml that were the same as the defaults for the plugin was redundant; plus, in my recent testing, I saw some odd behavior which could have been explained as the config.xml overriding fields I had saved.

@bparees - sample job updated

lgtm. will wait for test success.

[test]


Ignore line endings option?

I use the hashes to determine whether to cachebust JSON files in a CDN, but the hashes are different depending on if I build on my dev machine (windows) vs the CI/CD server (linux). It would be great if I could get a consistent hashcode in both for troubleshooting.

I think a better solution would be to apply the same newline character sequence to the files with another tool, and then use this code to check for equality. That should be a lot faster.
E.g. sed or dos2unix are proposed in this stackoverflow question.
If I were to add this option, I think I would need to switch from efficiently reading the text files as a stream and dumping the chunks into the hash function to reading the files line-by-line, which I presume to be a lot slower.
I'm open to be proven wrong, though.

@marc136 I would expect 99% of the overhead of this library is spent in file IO and the remaining on the 'crypto' libs hashing function; if implemented properly wouldn't the overhead be negligible?
Prior to
        f.pipe(hash, { end: false });

you pipe to a different function that does the call to hash after it strips out line endings / whitespace (if the user specifies the option)


Exporting detailed results does not work properly

Hello Team,
This is regarding issues trying to export the detailed results from a "Sent" message.
When we click the "export detailed results" we the permissions for OneDrive access is never asked/pop up and the message is not received

Is there something we are missing to get te exported details?
REgards

Hi @Axael85 ,
Thanks for raising the query.

Is it a fresh deployment or migration?
Are you able to send the message through 4th sending option?
Could you please perform SYNC for all 3 function apps- Prep, Data, Send and try exporting it again

HEllo  @gsv022 ,
1.- This is not a new deployment
2.- I cannot send message through 4th sending step( it is not showing the groups when trying to deploy)
3.- Have performed the sync for the function apps still failing.
REgards  :(

Hello @gsv022 ,
I have checked the Graph App authentication  part. Everything seems configured properly

As well, checked directly on the storage account for datablobs , and the exportdatablobs is empty. Seems is not triggering anything:

@Axael85 ,
For fourth sending option, please type the name of the team name without any spacings, it will give the details(if not tried already)
Secondly, We suspect that secrets are incorrectly configured.  Here is the procedure for comparison.

Go to app registration-->open author app registration-->click certificate and secrets-->Grab secret value(not id)

Go to azure portal-->Go to resource group(Where the deployment has been done)-->Select keyvault  from list of resources

Go to Access Policy--> Click on Create

Select Key, secret and certificate management

Give the Id through which one can view the secrets

3rd step is optional

Go for Review+Create

Then go to Secrets. You will be able to view the secrets. Compare each app secret from keyvault with app registration secret.

Hello team,
Thanks for the feedback, I have checked for the secrets from keyvault and all of them are correctly configured. Not sure what else is failing.
As well have been any change on the applicaiton, currently I cannot create any other mesage :

Hi @Axael85
Please share your mail id so that we can discuss the issue internally

Hello SaiVenkat
My email address is @.***
From: Sai Venkat @.>
Sent: Thursday, March 21, 2024 7:41 AM
To: OfficeDev/microsoft-teams-apps-company-communicator @.>
Cc: Luna, Christian Ivan @.>; Mention @.>
Subject: Re: [OfficeDev/microsoft-teams-apps-company-communicator] Exporting detailed results does not work properly (Issue #1364)
Hi @Axael85https://github.com/Axael85
Please share your mail id so that we can discuss the issue internally

Reply to this email directly, view it on GitHubhttps://github.com/OfficeDev/microsoft-teams-apps-company-communicator/issues/1364#issuecomment-2012338118, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BD54EJPBZIWJ74HAQGCAM2TYZLPOVAVCNFSM6AAAAABEHK44PWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJSGMZTQMJRHA.
You are receiving this because you were mentioned.Message ID<EMAIL_ADDRESS>

Hello @gsv022
I was able to sort the issue about company communicator, now I'm able to connect this one and send messages. For the downloading issue now I'm able to receive the alert to "Allow or Decline" but show now the next error:

Could this be related to the Client secret?
REgards

Hi @Axael85 ,
Are you able to send the message using 4th sending option?

Hi @gsv022 ,
YEs the 4th sending option is working now. the only pending item is the capability to download the report.
https://private-user-images.githubusercontent.com/150716965/315896215-189ec662-8fbf-4dc6-ab42-0f6a2ac44267.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTE0MDczMzAsIm5iZiI6MTcxMTQwNzAzMCwicGF0aCI6Ii8xNTA3MTY5NjUvMzE1ODk2MjE1LTE4OWVjNjYyLThmYmYtNGRjNi1hYjQyLTBmNmEyYWM0NDI2Ny5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwMzI1JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDMyNVQyMjUwMzBaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1kNTc0NzhiN2U5N2Y1ODJkOGJiOTBiZTllYzA0ZTJhYjJkOWVlNTg1MmRjYzFjZGVjNTI0ZmM4MDUwMjIyOGZlJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.7yqvy14cvgWGQVo6CjotJ73TiAk4rQpkirbdrBZZGcs

@Axael85 ,Could you share the screenshot of the graph API permissions. Here is the reference.

Hi @Axael85 ,
Please remove the extra permissions which are not mentioned in the deployment guide.

Permissions removed

But we can still see the issue here :

Please check the same for author app and user app registrations.

Quick question, which permissions does the Author and user app registration required? Couldnt find them on the wiki.

As per deployment guide there are no permissions need to be added for author/user. By default once app registration is created, user.read will be the permission created and apart from that permission no permission should be there. There are chances that permissions of graph app might got added for author/user. Please check it.

No permissions were presented :

REgards

upon creation of app registration, user.read permission(delegated type) will be created and by any chance that permission is deleted?

Hello @gsv022 ,
Yes the user.read permission was removed from both app registration ( Author and user)

@Axael85 , Please add that permission. It should be there.

Hello @gsv022 ,
Both app registration now have the user.read ( delegated type) permission.

However it is same problem :

Regards

Hi @Axael85 ,
Please share the email id directly here so that we can discuss the issue internally

Hello Sai,
This is my email address<EMAIL_ADDRESS>I'm working on CST Mexico time.
Regards
From: Sai Venkat @.>
Sent: Monday, April 15, 2024 1:16 AM
To: OfficeDev/microsoft-teams-apps-company-communicator @.>
Cc: Luna, Christian Ivan @.>; Mention @.>
Subject: Re: [OfficeDev/microsoft-teams-apps-company-communicator] Exporting detailed results does not work properly (Issue #1364)
Hi @Axael85https://github.com/Axael85 ,
Please share the email id directly here so that we can discuss the issue internally

Reply to this email directly, view it on GitHubhttps://github.com/OfficeDev/microsoft-teams-apps-company-communicator/issues/1364#issuecomment-2055787654, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BD54EJPQPQ4BWPIN5VMV7E3Y5N5EPAVCNFSM6AAAAABEHK44PWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANJVG44DONRVGQ.
You are receiving this because you were mentioned.Message ID<EMAIL_ADDRESS>

Please share the mail id directly on this GitHub platform

hello @gsv022 ,
this is my email address<EMAIL_ADDRESS>

We have initiated the conversation internally. Please check and respond

Hello @gsv022 ,
I'm not able to open the conversation on Teams. Having below error:

Hi @Axael85 ,
We will send out the mail. Please check and respond

Hello @gsv022 ,
NEvere received a meeting invite to collaborate or fix the problem. The issue still exists!

Please log an new issue.


Add icons from the game in the textbox

Stuff like the spellbooks, weapons, etc. There's a file that contains all the icons from the game but all the icons need to be extracted individually.
Then the image can probably be inputted using an  tag or something

Might be possible with a rich text editor library of some sort. Need to find a way to pass it into a react state


Visual Studio error when changing proto properties in gRPC template

Create a new gRPC service

View the greet.proto properties in Visual Studio

Change gRPC Stub Classes from Server only to Client only.

Visual Studio errors

Details in the error popup:

An error has occurred while saving the edited properties listed below:
gRPC Stub Classes
One or more values are invalid. MSBuild returned the following error: The element  beneath element  is invalid because a child element with that name already exists  C:\Users\James\source\repos\GrpcService11\GrpcService11\GrpcService11.csproj

Visual Studio 16.3.3 & 16.4 Preview 1

As a work around you can edit the .csproj file manually.  <Protobuf Include="Protos\greet.proto" GrpcServices="Client" />

@jjmew Do you know what metadata needs to be present to support changing this in the property grid?

Some more detail:
It doesn't happen if VS was opened (or the project is unloaded and reloaded) with no value in XML. If there is no value in XML then the value can be modified successfully until VS is reopened.
Also, the same error happens with other properties on the <Protobuf> element: Access, ProtoCompile

This is either an error in the project system or in Grpc.Tools. Moving to https://github.com/dotnet/project-system/issues/5573

See my comment on https://github.com/dotnet/project-system/issues/5573#issuecomment-540857524, you probably want to change Grpc.Tools to fix this.


x/tools/gopls: report if accepting a completion item will result in auto-import

gopls version
0.17.1
go env
..

What did you do?
"os" is not yet imported:

however, strings are already imported:

What did you see happen?
They looks the same.
What did you expect to see?
Show a hint whether a package is going to be auto-imported, because some package names look similar, I want to use an already imported one, but find myself often accept a wrong name, therefor need to undo auto import.
In clangd, there is a little circle indicating this:

after accpeting printf, the circle disappears, because stdio.h is auto imported

Editor and settings
No response
Logs
No response

Thanks. Coincidentally, I am working on unimported completion, so I will look into this.
Off the top of my head, I do not know what causes the cdot for the clang analyzer, but I can investigate. This is VS Code, right?

Yes, the circle is part of the returned completion item, so every editor has the same looking
https://clangd.llvm.org/features#namespace-and-include-insertion


docs dapp-kit code example fix wrong import

From { type SuiClientOptions} to { getFullnodeUrl }
Description
Documentation change
Test Plan
How did you test the new or updated feature?

If your changes are not user-facing and do not break anything, you can skip the following section. Otherwise, please briefly describe what has changed under the Release Notes section.
Type of Change (Check all that apply)

[ ] protocol change
[x] user-visible impact
[ ] breaking change for a client SDKs
[ ] breaking change for FNs (FN binary must upgrade)
[ ] breaking change for validators or node operators (must upgrade binaries)
[ ] breaking change for on-chain data layout
[ ] necessitate either a data wipe or data migration

Release notes
Fix dapp-kit docs code-example

thanks for fixing this!! while you're at it, mind fixing other instances of this issue?
I see several offenders at https://sdk.mystenlabs.com/dapp-kit/sui-client-provider#usage

@williamrobertson13 thank you for noticing: New PR


Only auth

Please do not develop and / or testing in a PR, but submit once ready to review or discuss.


tests: drivers: build_all: Add a build_all test for wifi

The test targets the following devices at this time.

atmel,winc1500
inventek,eswifi
inventek,eswifi-uart

@loicpoulain @nandojve
Could you take a look if you have time?


add renderHistogram helper and sample family data

changes

add renderHistogram function (see usage in the relationships section (main.ts:renderRelationships)
add relationship section regarding familial meetings
ignore temporary generated bundle files and other build files

other

sometimes, this error Error: <rect> attribute width: A negative value is not valid. ("-1") appears when generating the histogram. It's due to the last element of the generated bins object having a width of 0. Some binCount values trigger this error, others don't. It does not affect the behaviour of the website. added a quickfix that disregards bins where x1 = x0

LGTM, can't merge yet because of merge conflict :{


Node 16

Node 16 became LTS in Oct 2021.
In other work, an eslint error occurs with Node 14, and moving to current LTS seems wiser than tracking down lint issues on older Node.

(missed .tool-versions the first time, forgot about the asdf users among us!)


negative ETA when training

need to edit regex in CLI
https://github.com/cloud-annotations/training/blob/d9f21f732b45597a7cf6f742c46f0b2a2542c917/src/commands/progress.js#L63

fixed


Pigpio doesn't run under Arch Linux after compilation

When I tried to run pigpiod under Arch Linux, I got error regarding missing library (libpigpio.so).
[root@alarmpi tmp]# ldd /usr/local/bin/pigpiod
	linux-vdso.so.1 (0x7efbb000)
	libpigpio.so => not found
	librt.so.1 => /usr/lib/librt.so.1 (0x76f5e000)
	libpthread.so.0 => /usr/lib/libpthread.so.0 (0x76f35000)
	libc.so.6 => /usr/lib/libc.so.6 (0x76df9000)
	libgcc_s.so.1 => /usr/lib/libgcc_s.so.1 (0x76dcd000)
	/lib/ld-linux-armhf.so.3 (0x76f75000)

I didn't capture the exact error message, but I fixed it by adding '/usr/local/lib' to /etc/ld.so.conf. Is it possible to update the build command to automatically cater to such cases?

See #38 PIGPIO under Arch

I'm not sure which location should be used but the Linux File Hierarchy Standard on /usr/local may be helpful...


Add Linux C-Implementation

Hi,
due to request and me needing something todo this evening I re-implemented the Perl-Script in C for Linux. The code is almost the same and roughly follows the same structure (though not always. eg IOPORTS is not the fd to write to but a macro that gets expanded to `"/dev/port").
It works for me really well. I thought about coming back to my project of building a simple GUI that works on Linux/Windows (and doesn't depend on Perl) but I've currently simply no Windows to test on etc. We'll see.

I just read that there are specific methods for accessing io-ports in <asm/io.h>, so I'll try changing the code to use these in the next few days when I'm back home.

Experimenting with the <sys/io.h>-implementation in my branch here (https://github.com/LeonardKoenig/acer_5750G_fan_maximiser/tree/prq_asm_io). It seems to be far more reliable than using open(), write() etc. (I didn't get any timeouts).


Support unions in idlharness

Now with far less craziness.

This change is

(This fixes w3c/web-platform-tests#5034 and supersedes #257.)

@zcorpan Are you interested in reviewing?  It's a lot easier than the last one.  :)

With this change, 3 tests in html/dom/interfaces.html went from fail to pass:
< Fail	TrackEvent interface: new TrackEvent("addtrack", {track:document.createElement("track").track}) must inherit property "track" with the proper type (0)	Unrecognized type [object Object],[object Object],[object Object]
< Fail	CanvasRenderingContext2D interface: document.createElement("canvas").getContext("2d") must inherit property "strokeStyle" with the proper type (15)	Unrecognized type [object Object],[object Object],[object Object]
< Fail	CanvasRenderingContext2D interface: document.createElement("canvas").getContext("2d") must inherit property "fillStyle" with the proper type (16)	Unrecognized type [object Object],[object Object],[object Object]

If I change html/dom/resources/interfaces.idl as follows
@@ -1111,7 +1111,7 @@ interface CanvasImageSmoothing {
 [NoInterfaceObject]
 interface CanvasFillStrokeStyles {
   // colours and styles (see also the CanvasPathDrawingStyles and CanvasTextDrawingStyles interfaces)
-  attribute (DOMString or CanvasGradient or CanvasPattern) strokeStyle; // (default black)
+  attribute (boolean or long) strokeStyle; // (default black)
   attribute (DOMString or CanvasGradient or CanvasPattern) fillStyle; // (default black)
   CanvasGradient createLinearGradient(double x0, double y0, double x1, double y1);
   CanvasGradient createRadialGradient(double x0, double y0, double r0, double x1, double y1, double r1);

I get this failure:

assert_true: Attribute has value "#000000" which doesn't match any of the types in the union expected true got false

and so this seems to work as intended!
The error message seems OK.

Thank you!


卡在命令行了

生成完毕后，命令行里没有结束提醒

一直卡在这儿

Hi, thanks for your interest.
It seems that the problem may exist in the ffmpeg tool.
maybe you can try conda install ffmpeg.
Or you can use the print command to debug and find where the program is stuck.

Thank you very much


Cast int to long to support use of std::max

This caused errors upstream in Chromium. This may have been because of stricter compiler warnings.

overwriting failed checks as the windows kokoro is currently broken; manually tested on linux + win
thanks for the pr! :)


QMetry +Perfecto

Hi,
I am having an issue with Qmetry when running in perfecto cloud for Mobile Web Browser.
I am not able to initialize the driver.
This is happening specifically when i try to initialize driver application.properties file
When try to trigger the driver from a common method i am able to success.
Can someone please help on this

This is not right place for Q & A. It is recommended to post questions with details in users group or in stack-overflow with qaf tag.


Folder with dot in name causes an error

If you have a folder name with dot causes an error trying to read as a file

it happens on


Restlet, Representation model schema

Hey guys,
I'm trying to make Swagger-Core introspection (version 2.0.X, to generate an OpenApi 3.0 spec) working in a restlet framework-based API.
I've suceeded in generating a spec through the  tutorials on the wiki, so thanks !
The only thing that is still a sore is that the spec includes some types/models/schemas that are, I guess, coming because the API endpoint methods are returning an org.restlet.representation.Representation
I couldnt find where to filter out the org.restlet package from the schemas. There is a skippedPackage attribute somewhere but didn't seem to work out. I've also tried to implement some kind of custom ModelConverter to filter classes in org.restlet.*, but again no dice.

Very clear and complete explanation, thanks, that fixed it :+1:


Add If Clause to GitHub Actions

Add if clause to make codecov step trigger only for a pull_request

@gayaldassanayake could you please resolve the review comments.


CI test

I've made several PRs around the doctest https://github.com/Farama-Foundation/Gymnasium/pull/1144 and https://github.com/Farama-Foundation/Gymnasium/pull/1153 reverting it back.
I'm confused, which style does it want us to use

@Kallinteris-Andreas you pushes to the wrong or


Add Contributors Table in README.md

Like this

I would like to work on this.

I would like to work on this.

This would do but, It would be a pain to update the readme every time, I can assign you this issue if you could create a GitHub action that checks the PR and sees if a new person has made the pr then automatically updates the readme.

This would do but, It would be a pain to update the readme every time, I can assign you this issue if you could create a GitHub action that checks the PR and sees if a new person has made the pr then automatically updates the readme.

It will be automated.

It will be automated.

Please add any one label "level-1" or "level-2" or "level-3" or "level-4" or "level-5" in this issue.

Please add any one label "level-1" or "level-2" or "level-3" or "level-4" or "level-5" in this issue.


Only serialize properties that have been assigned

Currently, ZeroQL will serialize a model to JSON text with all the properties, regardless of whether or not they've been assigned, except properties that have a value of null.
This is a problem for any nullable properties that should, during a mutation, be assigned to a value of null.
I propose that models should track which properties have been assigned, and only properties that have been assigned should be in the resulting payload to the server.
Below is an example of a possible implementation of what the generated model code would be...
class Foo
{
    private readonly Dictionary<string, object> assignedProperties = new(); // all models would have this field

    private string? text;
    public string? Text { get => text; set => assignedProperties["Text"] = text = value; }

    private int count;
    public int Count { get => text; set => assignedProperties["Count"] = text = value; }
}

And then whenever serialization happens, it would serialize foo.assignedProperties instead of foo itself.

Hmm, that implementation idea wouldn't really help for the opposite: querying partial entities.
This might need something like Optional<T> for each property.

I saw that the StrawberryShake graphql client from HotChocolate is doing something similar like your first suggestion.
I have been thinking about adding it but never got a good use-case while using the ZeroQL.

What about making a base class/interface for generated DTOs, and making it partial.
That way folks could add custom logic/validation with things like https://github.com/Fody/PropertyChanged. What I proposed could be implemented with that, I'm pretty sure...


[BUG] Console button overlap

Describe the bug

The console button in the VM details page overlaps other elements in the right column.
To Reproduce
Steps to reproduce the behavior:

Create a VM and assign a name with more than 20 characters to it.
Go to VM details page

Expected behavior

The console button shouldn't overlap other page's content.
We should fix the layout by avoiding the columns overlap or move the console button in another section.
Environment

Harvester UI version: v1.3.0

Additional context
Add any other context about the problem here.

Thanks for the fix @a110605 this looks good on Harvester Version: master-9c0a3a1-head
I'll go ahead and close this out :+1: :smile:


Added !targetEnvironment(macCatalyst) condition

Added !targetEnvironment(macCatalyst) condition when building iOS app for MacOS with Catalyst framework Xcode 11 & Catalina

Checklist

[x] I checked the Contributing Guidelines before creating this request.
[ ] New extensions are written in Swift 5.0.
[ ] New extensions support iOS 8.0+ / tvOS 9.0+ / macOS 10.10+ / watchOS 2.0+, or use @available if not.
[ ] I have added tests for new extensions, and they passed.
[ ] All extensions have a clear comments explaining their functionality, all parameters and return type in English.
[ ] All extensions are declared as public.
[ ] I have added a changelog entry describing my changes.

          1 Warning

:warning:
The source files have been modified. Please consider adding a CHANGELOG entry if necessary.

          3 Messages

:book:
Thank you for submitting a pull request to SwifterSwift. The team will review your submission as soon as possible.

:book:
iOS: Executed 605 tests, with 0 failures (0 unexpected) in 11.957 (14.508) seconds

:book:
macOS: Executed 433 tests, with 0 failures (0 unexpected) in 0.970 (1.385) seconds

  Generated by :no_entry_sign: Danger

This PR may be obsoleted by https://github.com/SwifterSwift/SwifterSwift/pull/752 where I added all the necessary #ifs to run the tests and everything else for Xcode 11.1.

Closing this one in favor of #752, but anyways thank you @nasircsms for the work here 💯


receiving Invalid environment name: undefined when running amplify init -y in an initialized project

How did you install the Amplify CLI?
pnpm
If applicable, what version of Node.js are you using?
18
Amplify CLI Version
10.5.1
What operating system are you using?
mac
Did you make any manual changes to the cloud resources managed by Amplify? Please describe the changes made.
n/a
Describe the bug
When running amplify init -y in an initialized project we receive Invalid environment name: undefined
Expected behavior
We should receive a more helpful message such as
Amplify project ${appId} is already initialized for environment ${envName}. To create a new environment run `amplify add env`

Reproduction steps

amplify init -y
amplify init -y

Project Identifier
No response
Log output

# Put your logs below this line

Additional information
No response
Before submitting, please confirm:

[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.
[X] I have removed any sensitive information from my code snippets and submission.

Hello Sir ,I can solve this issue please assign me


Identify solo-maintainer projects

We need to a column is_solo_maintainer_project as boolean (default false) in the table projects as we need to identify projects that solo maintainer (by definition).
Certain checks require this filter: #76, #79, #107, #125 and #127
Note that just listing GitHub organization owners won't solve this as most of this projects have granted admin access level to the foundation or others in case that an emergency access is needed.

I have been thinking about this problem to achieve automation, considering that access has been granted to the foundation. The possible options would be:

Ignoring the foundation's accounts (I don't think this is the best option) with a blacklist.
Verifying who among those with write permissions has recently made a commit to the main repository (possibly the best option).
Doing this step manually.

Or maybe there are better options.

Doing this step manually.

I think this is the way to go, when we add a project we can specify if the project is a solo-maintainer one. By default we consider the project to have a team based governance model.
Using the activity seems complex and requires pulling a lot of data when doing the project registration. Currently we don't use providers when adding a project.

Hi @UlisesGascon
I'd like to work on this issue.
Thanks! :-)

I assigned the issue to you. Thanks for the help @KoolTheba!

As we are using now checklist, this differentiation won't be necessary.


Certain forms reference tests, containing text fields, are failing in Firefox on both bots

As can be seen in https://github.com/mozilla/pdf.js/pull/3891#issuecomment-297307522 and https://github.com/mozilla/pdf.js/pull/3891#issuecomment-297311016, certain forms test-cases that contain text fields have started failing in Firefox on both of the bots. Note: this is with tests run against the current master.
This is really strange, since first of all the number of test failures on the Linux/Windows bots are not identical. Second of all, when testing locally using the latest Nightly (i.e. Firefox 55), or the latest Aurora (i.e. Firefox 54), on Windows I cannot reproduce this.
Edit: Also, opening those test-cases with the default viewer in Firefox 54/55 with renderInteractiveForms = true set, I'm not able to reproduce any issues either.

It could be that this is an issue in the rasterization code for the tests. I suspect #8005 is the same issue as this one actually.

The Linux bot renders f1040-forms correctly again.

Firefox 55 on the Linux bot regressed the rendering of f1040-forms again (see http://<IP_ADDRESS>:8877/28a03e33e0c3cf3/reftest-analyzer.html).

The Linux bot is completely fixed after the Firefox 57 update. This issue now only tracks the Windows bot.

The form tests also intermittently work for me locally on MacOS in both FF and Chrome.

The Windows bot is now also fixed after the Firefox 57 update. Closing since this issue is fixed. If intermittent issues remain after updating to Firefox 57, a new ticket should be opened to track that.


Add ability to use algebraic notation

Currently, the engine only supports a variant of long algebraic notation used by the XBoard/WinBoard protocol/Universal Chess Interface. This isn't bad per se; however, this notation is different than the usual algebraic notation used in common chess parlance. A translator should be added so that if you're playing the engine in console mode, you can type your move in valid algebraic notation and the engine will reply its move in algebraic notation as well (to enhance readability).

The engine now replies in algebraic notation as of version 1.3.0, but still doesn't parse algebraic notation for inputted moves.


enabled specialzers

Enables specialzers in the nephio controller package

https://github.com/nephio-project/nephio/issues/229

Awesome. Can you add ENABLE_APPROVAL too? I forgot to do that in my PR.

Actually don't bother, I still need to add all the permissions and stuff, so I can do it then.


filewatcher loops infinitely when executing a script that invokes ssh

Hi there. I'm using this command to watch changes on a directory with CSS files:
filewatcher -E 'css/*.css' 'touch-css.sh $FILENAME'

It executes a bash file called touch-css.sh that uses the name of the modified file to inform a different server about the updated file:
#!/bin/bash
set -e

LOCAL=Users/proteo/Sites
REMOTE=var/www/sites

# Modifies the path to match the location on the server
FILE=$(echo $1 | sed "s,$LOCAL,$REMOTE,g")

# Update the file in the remote server.
ssh<EMAIL_ADDRESS>"touch $FILE"

echo "Updated $FILE"

The process is (mostly) working, except that the ssh line makes filewatcher to enter in a loop, executing the script over and over infinitely, as if the modified file would be changing every second. As soon as I remove that line, everything works as expected.
It's kind of weird but if I comment the ssh line when filewatcher is looping, as soon as I save the change the loop is terminated, so it's evident that somehow filewatcher is affected by the command.
Thanks in advance for your help.

@proteo thank you for your report!
Did you try the -t flag?
https://unix.stackexchange.com/questions/119894/single-command-to-login-to-ssh-and-run-program
I guess it can help even with Filewatcher, as with anything else.
Just to stop SSH session after a command.

Hi @AlexWayfer , thanks a bunch for your response.
Yes, I tried with the -t flag, but the only difference that makes is to add a "Connection to <IP_ADDRESS> closed." message to each iteration in the loop.
I've also tried with something like this, but still won't work:
ssh<EMAIL_ADDRESS>"touch $FILE &> /dev/null &" &
Please feel free to close this if you think it's not a Filewatcher issue, or let me know if I you want me to do further testing.

OK, let's find the problem out.
I've reproduced environment which you've described.
And I see correct work of filewatcher (master version):
> ../bin/filewatcher -E 'css/*.css' './touch-css.sh $FILENAME'
/home/debian/css/test.css
Updated /home/debian/css/test.css
/home/debian/css/test.css
Updated /home/debian/css/test.css
/home/debian/css/test.css
Updated /home/debian/css/test.css
/home/debian/css/test.css
Updated /home/debian/css/test.css
/home/debian/css/test.css
Updated /home/debian/css/test.css

(All local scripts placed in filewatcher/test/, remote is /hone/debian/)
I don't see any issues.

The process is (mostly) working, except that the ssh line makes filewatcher to enter in a loop, executing the script over and over infinitely, as if the modified file would be changing every second. As soon as I remove that line, everything works as expected.

Which loop? How it looks?
I don't see any infinity loop. Multiple outputs was when I tried to spam Ctrl-S on CSS file (trying to reproduce "if the modified file would be changing every second", I don't know how to make it in another way).

OK, I've recorded a couple of screencasts to show you the issue. First, the result of running the command without the ssh command. You can see the output of the command in the upper window, printing the Updated ...css message only when I do a change and save the file (lower window):

Now, this is the result of enabling the ssh command in touch-css.sh. As you can see, the command keeps printing the same message until I manually cancel it (CTRL+C) even when I've changed the file just once:

Edit:
I'm running macOS 10.14.6, and the remote computer is running Ubuntu server 18.04. filewatcher -v reports: filewatcher, version 1.1.1 by Thomas Flemming 2016

Can you please to switch to master version of filewatcher?
I can record a screen with the similar usage and without loop… server is Debian 9, local is Arch Linux. But I think you trust me.
I want to discover this.
Steps as I see:

Clone the repo and try the same with version in master branch.
Add logs (like puts or something else) to different steps, to know what happens in the loop.

I'll try to do my best to reproduce this. It can be Filewatcher issue so I'm not going to close this.

I can't reproduce it with stable version (from RubyGems) by the way, so you can skip the first step testing, just clone to add debugs please, if it's not hard to you.

And please re-check the content of shell script. Your previously sent version looks like just "update mtime of file (touch it) on server when it changes locally", without some rewriting (for example, via scp). I don't understand the purpose of this.

@proteo friendly reminder, I still wait additional information.

I'm closing this issue due to inactivity. Feel free to write additional information, we can re-check it and investigate more detailed.


Add ability to provide default attributes for assoc

This is a convenience for specializing associated models. It allows doing something similar to the example below, which would otherwise require the definition of an author factory:
factory.define('post', Post, {
  user_id: factory.assoc('user', 'id', { role: 'author' })
  ...
});

Great, would you mind just adding that to the docs as well. Thanks.

Added documentation.

Great, thanks!

Pushed v1.4.0

Thanks!


Stange circles in dxf line work

hi,
Unfortunately i cannot share the file but we have some linework showing strange circles instead of buldges (left: ours, right three-dxf)

and qgis for comparison

Can you copy a small portion of that file containing one of those buldges into a new file and share that?

i will try, has three-dxf an easy way to split out curves?

I did a quick test with Splines and there are some strange things, I'm not sure if it's related to your problems.
Sample file: spline test.zip
This is how it should look like:

This is how it looks:

The odd curves are not drawn correctly and where the spline has an odd number or points it joins the last one with 0,0,0.

I dont have a real dxf editor, can i jsut dm you the file?

@Serthys yeah, I didn't really know what I was doing when I implemented splines and I didn't have a good program to test things with at the time. It looks like you created a nice test for those. Would love a PR, even if it's just to add a failing test.
The issues here definitely look like issues with bulges. Also all the bulges seem to be originating from the end of a line so perhaps we aren't handling some edge condition for bulges? We'll definitely need at least a portion of the file to diagnose. Are you able to open the file and remove most of it but leave part of what is broken? Then you would just be posting a very tiny piece? Otherwise I suppose a DM will do.

@Serthys I just pushed a partial fix for splines. It will now draw simple ones, but can't handle more that 4 control points. Three.js doesn't have an algorithm for more than that. I understand the fundamentals of splines much better now, but not well enough to write code that can handle any number of control points. From what I understand, it becomes a recursive computation as you add more points.
I plan to take a look at the bulge problem soon. Sorry, been getting reoriented with everything. It's been a while!


Remove references to env files that do not exist

Merging the PR as it's removing references that do not exist vs adding any changes. Thanks.


CME install issue from apt (crackmapexec 4.0.1+git20200118-0kali1) on Kali 2020.1

Steps to reproduce

Run apt-get update && apt-get install crackmapexec

OS
Kali 2020.1
Detailed issue explanation
When installing crackmapexec from apt, the following error occurs when setting up...
Setting up python3-terminaltables (3.1.0-3) ...
Setting up python3-xmltodict (0.12.0-1) ...
Setting up python3-pylnk (0.2.1+git20200104-0kali1) ...
Setting up python3-requests-ntlm (1.1.0-1) ...
Setting up python3-winrm (0.4.1-0kali1) ...
Setting up crackmapexec (4.0.1+git20200118-0kali1) ...
/usr/lib/python3/dist-packages/cme/protocols/mssql.py:71: SyntaxWarning: "is" with a literal. Did you mean "=="?
if self.args.auth_type is 'windows':
/usr/lib/python3/dist-packages/cme/protocols/mssql.py:143: SyntaxWarning: "is" with a literal. Did you mean "=="?
if self.args.auth_type is 'windows':
/usr/lib/python3/dist-packages/cme/protocols/mssql.py:159: SyntaxWarning: "is" with a literal. Did you mean "=="?
res = self.conn.login(None, username, password, domain, None, True if self.args.auth_type is 'windows' else False)
/usr/lib/python3/dist-packages/cme/protocols/mssql.py:173: SyntaxWarning: "is" with a literal. Did you mean "=="?
out = u'{}{}:{} {}'.format('{}\'.format(domain) if self.args.auth_type is 'windows' else '',
/usr/lib/python3/dist-packages/cme/protocols/smb.py:910: SyntaxWarning: "is" with a literal. Did you mean "=="?
if self.args.ntds is 'vss':
Processing triggers for kali-menu (2020.1.7) ...
When attempting to run crackmapexec after, the following error appears:
# crackmapexec
Traceback (most recent call last):
File "/usr/bin/crackmapexec", line 11, in
load_entry_point('crackmapexec==5.0.0.dev0', 'console_scripts', 'crackmapexec')()
File "/usr/lib/python3/dist-packages/cme/crackmapexec.py", line 36, in main
args = gen_cli_args()
File "/usr/lib/python3/dist-packages/cme/cli.py", line 67, in gen_cli_args
protocol_object = p_loader.load_protocol(protocols[protocol]['path'])
File "/usr/lib/python3/dist-packages/cme/loaders/protocol_loader.py", line 12, in load_protocol
protocol = imp.load_source('protocol', protocol_path)
File "/usr/lib/python3.7/imp.py", line 169, in load_source
module = _exec(spec, sys.modules[name])
File "", line 630, in _exec
File "", line 728, in exec_module
File "", line 219, in _call_with_frames_removed
File "/usr/lib/python3/dist-packages/cme/protocols/smb.py", line 7, in
from impacket.smbconnection import SMBConnection, SessionError
File "", line 983, in _find_and_load
File "", line 963, in _find_and_load_unlocked
File "", line 906, in _find_spec
File "", line 1280, in find_spec
File "", line 1254, in _get_spec
File "", line 1235, in _legacy_get_spec
File "", line 441, in spec_from_loader
File "", line 594, in spec_from_file_location
File "/usr/local/lib/python3.7/dist-packages/impacket-0.9.19.dev0-py3.7.egg/impacket/smbconnection.py", line 266
except (smb.SessionError, smb3.SessionError), e:
^
SyntaxError: invalid syntax

Update impacket ;)

^^


run swift3 migrator

When you are ready to migrate the code to swift 3, I updated the code using the migrator.
Tests are passing!
Quick question is TableViewDiffCalculator intended to be subclassed? the migrator set the privacy to open but you might want to set it to public to restrict people from subclassing it

oups sorry this is a duplicate of https://github.com/jflinter/Dwifft/pull/22


PD-8267 adding support for S3 cross region replication.

See PD-8267
Resource properties to support S3 replication configuration (configuration for replicating objects in an S3 bucket).

@abegley-r7 nice to see us adding support for more new resources. Glad you stuck with the change you need vs. adding several other resources as well. I remember https://github.com/rapid7/convection/pull/137 being hectic.


Innacurate get_pixel (GDScript) vs texture (shader) reading

Godot version
4.1.stable.official
System information
Windows 10
Issue description
Doing a simple terrain displacement with a simple PNG file, the resulting displacement on shader is one, the heightmap done for it using get_pixel on the same PNG gives another result so the collisions don't match with the terrain displacement at all.
Oddly enough, changing the loaded file from a PNG to a generated noise works normally.

Steps to reproduce
I uploaded the project folder, but basically:
Shader:
void vertex() {
	float world_height = texture(heightmap, UV).r * height_level;

	VERTEX.y = world_height;
}

GDScript:
var material = mesh_instance_3d.get_surface_override_material(0)
var texture = material.get("shader_parameter/heightmap")
var height_level = material.get("shader_parameter/height_level")
var heightmap_image = texture.get_image()
var image_size = Vector2(heightmap_image.get_size())

...

for y in verts:
	for x in verts:
		...
		var height = heightmap_image.get_pixelv(pos * image_size).r * height_level
		points.append(height)
collision_shape_3d.shape.map_data = points

Minimal reproduction project
get_pixel_inaccurate.zip

You need to remove source_color from this shader line:
uniform sampler2D heightmap: source_color, filter_linear_mipmap, repeat_enable;
If you have source_color enabled, the color read from the texture can go through SRGB to linear conversion which will affect the values.
Correct look after removing source_color: