Markers not visible, when style used...

If a matplotlib style is used, it's possible, that the markers are not shown, e.g. with
plt.style.use('seaborn')

Should be fixed with 3cd064bb9044099635764940ed429e0cdcf8d41e


Fix AttributeError: 'DataFrame' object has no attribute 'append' in DataFrameRowsOnly.to_df() #9950

Description
In the latest version of pandas (2.1.2), the append() method has been removed from the DataFrame object. This caused an AttributeError when trying to append a new DataFrame to an existing one using existing_df.append(new_df, ignore_index=True).
I have updated the to_df() method in the DataFrameRowsOnly class to use the pd.concat() function instead of the append() method. This change ensures compatibility with the latest version of pandas and prevents the AttributeError from occurring.
Fixes # 9950
Type of Change

[ ] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

[ ] I stared at the code and made sure it makes sense

Suggested Checklist:

[ ] I have performed a self-review of my own code
[ ] My changes generate no new warnings

Thanks! for the approval @hatianzhang , this is my first contribution, looking forward to contribute more.


Enabled AppVeyor artifact generation

Experimental source doesn't have AppVeyor artifacts enabled, so this will enable it and make all builds available to download (this is useful to compare old builds without have to compile everything again)
https://ci.appveyor.com/project/cbnolok/source2/branch/master/artifacts

Thanks!


php: buildComposer does not output vendorHash

Describe the bug
When building this derivation, no vendorHash is logged. Meaning the build never gets past the check stage.
package.nix:
{ lib, php83, fetchFromGitHub }:

php83.buildComposerProject (finalAttrs: {
  pname = "ppelican-panel";
  version = "v1.0.0-beta7";

  src = fetchFromGitHub {
    owner = "pelican-dev";
    repo = "panel";
    rev = finalAttrs.version;
    hash = "sha256-h0+6rDy7U24XEdqAnfd8Q77VE8Ji2llSxy/vQawPQw4=";
  };

  php83 = php83.buildEnv {
    extensions = ({ enabled, all }: enabled ++ (with all; [
      gd
      mysqli
      mbstring
      bcmath
      xml
      curl
      zip
      intl
      sqlite3
    ]));
  };

  # The composer vendor hash
  vendorHash = lib.fakeHash;
})

Steps To Reproduce
Steps to reproduce the behavior:

run nix-build in folder containing package.nix
Composer starts installing a bunch of packages
See error without vendor hash.

Expected behavior
I expect an output containing the actual vendor hash.
Screenshots

Additional context
I am trying to package https://pelican.dev/
Notify maintainers

@drupol
Metadata
 - system: `"x86_64-linux"`
 - host os: `Linux 6.6.44, NixOS, 24.05 (Uakari), 24.05.20240805.883180e`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.18.5`
 - nixpkgs: `/nix/store/79j6vc975md1w3f2fgli3xw657zyxxyc-source`

[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
output here

Add a :+1: reaction to issues you find important.

Hello,
The red message explains clearly the reasons. This issue has to be fixed upstream.
To verify by yourself, just clone the project and do composer validate.
If you don't want to let upstream know about the issue, you can disable the validation by adding the attribute composerStrictValidation = true; but I don't recommend that.

Hi, thank you for the fast response!
The lock file seems outdated indeed, it just didn't seem to affect my install attempt on a Ubuntu system.
For now composerStrictValidation = false; resolved my issue, will be posting an issue upstream.
Thanks a lot!


pkg/fileutil: helper function to get major, minor numbers of a device file

Ci complains about:
fileutil_test.go:260: arg i for printf verb %s of wrong type: int

@jonboulle care to re-review?

Seems OK but I'll defer to @lucab for approval


Optimise file move

This fixes #467, now when moving files within the same partition, os.Rename is used to update inode pointers instead of copying data. This significantly improves performance for large files and maintains atomic operations where possible.

Thanks a lot for your contribution!

Happy to help 😄

Oh wow. Thank you. This was the only thing missing that stopped me from fully switching to this as my file manager.


Regent: install.py should automatically rebuild terra with CUDA support

If terra wasn't build with CUDA support and a user passes --cuda to install.py then it should automatically rebuild terra with CUDA support or tell the user why it can't and not silently let the user think that CUDA support was successfully installed.

This is fair, but we should do some auto-detect style check like #495 to actually make sure Terra needs a rebuild, not just blindly do it.
Note to self: need to check if make clean && make is enough, or whether we need make purge && make.

I'm seriously considering moving install.py and setup_env.py to build Terra with CMake by default, which I think would also fix.

Both scripts now use CMake by default to build Terra, which I think resolves this issue. Please reopen if you have any further issues.


30k+ API calls to forecast.io per day

Home Assistant release (hass --version): 0.20.2
https://hub.docker.com/r/homeassistant/rpi2-home-assistant/
Description of problem:
10s of thousands of API calls to forecast.io
Expected:
< 1000 API calls
Problem-relevant configuration.yaml entries and steps to reproduce:
sensor:
 - platform: forecast
   api_key: [redacted]
   monitored_conditions:
     - summary
     - icon
     - temperature
     - humidity

see also here: https://community.home-assistant.io/t/forecast-io/1507/6

Same exact issue here. Issue appeared to start on 2016-05-09. >$80 in API calls last month....

Duplicate of #2142

Hey I see the same. For me it started from 2016-05-11 but I guess that is just when we updated.

Ouch. That's not good.
Closing because duplicate.


Wallabag password stored in clear

Actual behaviour
When I configure my miniflux.net account to work with wallabag.it instance to save articles, the password:

is clearly displayed in the configuration tab
is stored in clear in the miniflux application

Expected behaviour
make it encrypted please ;)
Configuration

Miniflux version: Official miniflux.net

Fine, how do you crypt and decrypt the data? with a private key? where do store the private key?

FYI, see https://github.com/wallabag/wallabag/issues/2800


[SPARK-24898][DOC] Adding spark.checkpoint.compress to the docs

What changes were proposed in this pull request?
Adding spark.checkpoint.compress configuration parameter to the documentation
How was this patch tested?
Checked locally for jeykyll html docs. Also validated the html for any issues.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Thank you for your first contribution, @sandeepvja . I left a minor comment.

ok to test

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/11804/
Test PASSed.

Test build #106564 has started for PR 24883 at commit 4961d2a.

Test build #106564 has finished for PR 24883 at commit 4961d2a.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/106564/
Test PASSed.

Test build #106572 has started for PR 24883 at commit a130625.

Thank you for your first contribution, @sandeepvja .

I left a minor comment.
Please attach the generated screenshot to the PR description.

@dongjoon-hyun Thanks for reviewing my first PR. Attached the screenshot to the issue.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/11813/
Test PASSed.

Test build #106572 has finished for PR 24883 at commit a130625.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/106572/
Test PASSed.

@sandeepvja . What is your JIRA ID? You will be an Apache Spark contributor as the Assignee of https://issues.apache.org/jira/browse/SPARK-24898 .

my JIRA Id: m.sandeep , Can you please add me as a contributor to the JIRA issue ?

Sure. @sandeepvja . You are added to the Apache Spark contributor group and the issue is assigned to you. Thank you, @sandeepvja !


Add 'Table.upload_from_file'.

Handles both single-request (multipart) and resumable uploads.
Closes #1261

@tseaver LGTM to merge so we can get changes into 0.9.0, provided a follow up issue is filed and we get the issues resolved.

Follow up issue: #1431

@tseaver FYI gcloud.bigquery.test_table.TestTable.test_upload_from_file_w_bound_client_multipart fails on Windows.


Condense the Travis build matrix expression

I believe this will produce the same set of 12 builds.  See the documentation here.

Doesn't appear to have worked on this first attempt - only two builds in the travis matrix here - one linux, one OSX

Yeah, I'm sad.

OK, so if I understand matrix-include correctly it just wants specific items.  Outside of the matrix-include statement, duplicates should work as I expected.   But since we don't care, e.g., about CC1=gcc-6 on osx, and listing the matrix-excludes would take just as much space, the status quo holds.

😿


centos-6 image does not exist in multi-backend-multi-mig-bucket-https-lb example

I was doing Qwiklabs excercie 'HTTPS Content-Based Load Balancer with Terraform' where example multi-backend-multi-mig-bucket-https-lb is used.
However, after running terraform plan or terraform apply command I get an error Error: error retrieving image information: googleapi: Error 404: The resource 'projects/centos-cloud/global/images/family/centos-6' was not found, notFound.
Indeed in GCP images I see that oldest CentOS image is CentOS7 and there's no CentOS6 image. I've tried to manually workaround this problem changing terraform files, but it seems that information about image is gathered from some external bucket.
I'd like to finish lab as it's one of labs required to gather badge of completion of learning path so I'd be grateful for help with workaround for this problem or a fix. :)

@Dysproz thanks for the report. This seems to stem from https://github.com/terraform-google-modules/terraform-google-vm/issues/125, so closing this to track it there.


Document the onRender prop

Very nice library, just what I was looking for.
The onRender prop of the Frame component is very handy, but currently undocumented.
This is a tiny README update to address that.

@nkzawa curious if you'd be up for this small change? Else no worries I can close this…

@anandaroop Good catch, thank you! And sorry for the delay.


How to delete google compute images that are called stemcell-guid and do not have environment name?

Open an issue on the bosh-google-cpi-release?
When the bosh-google-cpi-release creates the stemcell, they can use the labels field to add the environment/deployment name.

Tentative solution: when users want to clean up orphaned stemcells from bosh in their GCP accounts, they can use the --filter flag and pass stemcell.


Decision: Enable Prometheus Endpoint by default for EnvoyProxy

Description:

Describe the issue.

[optional Relevant Links:]

Any extra documentation required to understand the issue.

ptal @envoyproxy/gateway-maintainers
this will make metrics consistent with control plane

im a +1 on this, and prefer if we add a disable knob in case someone wants to disable it when enabling otel

I forget why it's like this, but that's what I thought, big +1.


WebRTC always muted by default on iphone?

Just noticed that the audio is always muted on my iPhone using the following. Is this a known issue?
type: custom:webrtc-camera
url: doorbell
mode: webrtc

This article not about Safari. But every browser has crazy policy for autoplay video with audio.
https://developer.chrome.com/blog/autoplay?hl=en
Safari also has crazy policy for autoplay webrtc video.
https://developer.apple.com/documentation/webkit/delivering_video_content_for_safari/


Design: file handling

As was started to explore here, we need a way to upload and download files over the HTTP API and the queue-based API.
Some of this is partially implemented (Cog can fetch from data: and http: and respond with data: over the HTTP API) but this is an extended version of that design that hopefully covers everything we need to do.
Requirements

Input files need to be sent to a prediction in the API request directly, from a separate HTTP location, or from cloud storage.
Output files need to be sent back to the caller of the API in the response directly, by uploading to another HTTP endpoint, or by uploading to cloud storage.
Multiple output files need to be stored for each prediction.
This should work for both HTTP and queue-based APIs in the same way.
Authentication should be able to be provided for cloud storage.
The HTTP endpoint for uploading output files needs per-prediction authentication.

Proposed design
Both input and output files are represented as URLs in the input and output objects.
Supported URL schemas:

data: A data URL for passing files directly in the request/response. This is inefficient, but our only option for transferring binary blobs via JSON.
http: An HTTP URL
gs: Google Cloud Storage
s3: Amazon S3

By default, data URLs are used. For example, a basic model that takes image as input and returns an altered image:
Request:
POST /predictions
{
  "input": {
    "image": "data:image/jpeg;base64,..."
  }
}

Response:
{
  "output": "data:image/jpeg;base64,..."
}

Output file paths
For http:, gs:, and s3:, we need some way of hinting to the model of where to put output files.
Prediction requests have an output_file_prefix which defines the URL prefix to upload files to. The model can choose whatever arbitrary paths it wants to upload files within that prefix.
For example, an S3 version of the request above:
Request:
POST /predictions
{
  "input": {
    "image": "s3://bucket/prediction-input/25b743baec7cc6/input.jpg"
  },
  "output_file_prefix": "s3://bucket/prediction-output/25b743baec7cc6/"
}

Response:
{
  "output": "s3://bucket/predictions/25b743baec7cc6/output.jpg"
}

An alternate design could be to specify a base URL at runtime, then files are uploaded to some prediction ID or subpath for each prediction. For example, the model could be booted with `
HTTP
HTTP is a little more nuanced than the cloud storage, because we need to design an API for the endpoint for uploading files.
We could make it behave like the cloud storage prefix, then files are PUT at subpaths of that prefix. For example, a request could look like this:
{
  "input": {
    "image": "https://..."
  },
  "output_file_prefix": "https://replicate.com/predictions/25b743baec7cc6/files/"
}

Then, a file is uploaded by doing:
PUT https://replicate.com/predictions/25b743baec7cc6/files/output.jpg
<file data>

Then, the response would look like:
{
  "output": "https://replicate.com/predictions/25b743baec7cc6/files/output.jpg",
}

An alternate design could be to have a fixed URL that returns a random URL, like is current in serving, but this would be inconsistent with cloud storage, it isn't a "prefix", and is perhaps a less neat HTTP API.
Authentication
Authentication for cloud services is provided at runtime in environment variables using whatever method the client library does by default. AWS_ACCESS_KEY, GOOGLE_SERVICE_ACCOUNT, etc.
For HTTP, Replicate models need to do authentication for each prediction, so we need to pass authentication credentials to the prediction somehow. Some ideas:

Perhaps we could pass a long temporary token as a GET parameter in output_file_prefix, but this would make using a prefix awkward (we would need to inject the path before ?).
Perhaps we could have a separate output_file_http_authentication request key that sets a value for the Authentication HTTP header.

I think this is a good design. Cloud storage can pretty much be treated in this way. S3 has a REST API that you can PUT files to. GS has one too, though it requires POST instead. Both use an Authorization header.

Interesting. I was envisaging us under the hood translating s3://bucket/key into S3 Python library calls under the hood. I think the thing I was getting at was more the semantics of how the URL prefixes work from the user's point of view, rather than the implementation under the hood. E.g. say the model output a file called someoutput.png, then a prefix of s3://bucket/somekey/ would mean it was uploaded with the S3 library to s3://bucket/somekey/someoutput.png, and a prefix of https://replicate.com/files/ would mean the file was HTTP PUT to https://replicate.com/files/someoutput.png.
But you could also imagine a world where we just support HTTP, and just use the cloud storage's HTTP endpoints. That's a bit more complex from the user's point of view maybe (they have to understand how that API works for each cloud storage provider, and how to do auth etc), but reduces a lot of complexity.
I expect we'll just start with data: and http:, because that's all we need for Replicate, so perhaps we can come back to this design when we add S3 and GCS.

When we document this, we should also add documentation to the HTTP as noted in #475.


更新为0725版后一直报错

Server上的配置(仅直接使用KCP，未与Shadowsocks配合使用)：
./server_linux_amd64 -l ":9233" -t "<IP_ADDRESS>:0" -key "password" -mtu 1350 -sndwnd 2048 -rcvwnd 2048 -mode "fast2" > kcptun.log 2>&1 &
客户端配置：
client_windows_amd64.exe -l ":443" -r "serverIP:9233" -key "password" -mtu 1350 -sndwnd 256 -rcvwnd 1024 -mode "fast2"
打开后，server上报错如下：
2016/07/28 22:56:02 version: 20160725
2016/07/28 22:56:02 listen udp :9233: bind: address already in use
2016/07/28 22:56:29 remote address: <IP_ADDRESS>:19987
2016/07/28 22:56:29 dial tcp <IP_ADDRESS>:0: getsockopt: connection refused
2016/07/28 22:56:29 [ERR] yamux: Failed to read header: broken pipe
2016/07/28 22:56:29 remote address: <IP_ADDRESS>:19987
2016/07/28 22:56:30 dial tcp <IP_ADDRESS>:0: getsockopt: connection refused
2016/07/28 22:56:30 [ERR] yamux: Failed to read header: broken pipe
2016/07/28 22:56:30 remote address: <IP_ADDRESS>:19987
2016/07/28 22:56:30 dial tcp <IP_ADDRESS>:0: getsockopt: connection refused
2016/07/28 22:56:30 [ERR] yamux: Failed to read header: broken pipe
2016/07/28 22:56:30 remote address: <IP_ADDRESS>:19987
2016/07/28 22:57:20 remote address: <IP_ADDRESS>:3392
2016/07/28 22:57:20 dial tcp <IP_ADDRESS>:0: getsockopt: connection refused
2016/07/28 22:57:20 [ERR] yamux: Failed to read header: broken pipe
2016/07/28 22:57:20 remote address: <IP_ADDRESS>:3392
2016/07/28 22:57:20 dial tcp <IP_ADDRESS>:0: getsockopt: connection refused
2016/07/28 22:57:20 [ERR] yamux: Failed to read header: broken pipe
2016/07/28 22:57:21 remote address: <IP_ADDRESS>:3392
2016/07/28 22:57:21 dial tcp <IP_ADDRESS>:0: getsockopt: connection refused
2016/07/28 22:57:21 [ERR] yamux: Failed to read header: broken pipe
2016/07/28 22:57:21 remote address: <IP_ADDRESS>:3392
2016/07/28 22:57:21 dial tcp <IP_ADDRESS>:0: getsockopt: connection refused
2016/07/28 22:57:21 [ERR] yamux: Failed to read header: broken pipe
2016/07/28 22:57:22 remote address: <IP_ADDRESS>:3392
2016/07/28 22:57:22 dial tcp <IP_ADDRESS>:0: getsockopt: connection refused
2016/07/28 22:57:22 [ERR] yamux: Failed to read header: broken pipe
2016/07/28 22:57:22 remote address: <IP_ADDRESS>:3392
2016/07/28 22:57:22 dial tcp <IP_ADDRESS>:0: getsockopt: connection refused
2016/07/28 22:57:22 [ERR] yamux: Failed to read header: broken pipe
2016/07/28 22:57:23 remote address: <IP_ADDRESS>:3392
2016/07/28 22:57:23 dial tcp <IP_ADDRESS>:0: getsockopt: connection refused
2016/07/28 22:57:23 [ERR] yamux: Failed to read header: broken pipe
2016/07/28 22:57:24 remote address: <IP_ADDRESS>:3392
2016/07/28 22:57:24 dial tcp <IP_ADDRESS>:0: getsockopt: connection refused
2016/07/28 22:57:24 [ERR] yamux: Failed to read header: broken pipe
2016/07/28 22:57:25 remote address: <IP_ADDRESS>:3392
2016/07/28 22:57:25 dial tcp <IP_ADDRESS>:0: getsockopt: connection refused
2016/07/28 22:57:25 [ERR] yamux: Failed to read header: broken pipe
2016/07/28 22:57:26 remote address: <IP_ADDRESS>:3392
2016/07/28 22:57:26 dial tcp <IP_ADDRESS>:0: getsockopt: connection refused
2016/07/28 22:57:26 [ERR] yamux: Failed to read header: broken pipe
2016/07/28 22:57:27 remote address: <IP_ADDRESS>:3392
2016/07/28 22:57:27 dial tcp <IP_ADDRESS>:0: getsockopt: connection refused
2016/07/28 22:57:27 [ERR] yamux: Failed to read header: broken pipe
2016/07/28 22:57:28 remote address: <IP_ADDRESS>:3392
2016/07/28 22:57:28 dial tcp <IP_ADDRESS>:0: getsockopt: connection refused
2016/07/28 22:57:28 [ERR] yamux: Failed to read header: broken pipe
2016/07/28 22:57:29 remote address: <IP_ADDRESS>:3392
2016/07/28 22:57:29 dial tcp <IP_ADDRESS>:0: getsockopt: connection refused
2016/07/28 22:57:29 [ERR] yamux: Failed to read header: broken pipe
2016/07/28 22:57:30 [ERR] yamux: keepalive failed: i/o deadline reached
2016/07/28 22:57:30 [ERR] yamux: Failed to read header: broken pipe
2016/07/28 22:57:30 keepalive timeout
客户端报错如下：
2016/07/29 10:56:20 version: 20160725
2016/07/29 10:56:20 listening on: [::]:443
2016/07/29 10:56:20 encryption: aes
2016/07/29 10:56:20 nodelay parameters: 1 20 2 1
2016/07/29 10:56:20 remote address: ServerIP:9233
2016/07/29 10:56:20 sndwnd: 256 rcvwnd: 1024
2016/07/29 10:56:20 compression: true
2016/07/29 10:56:20 mtu: 1350
2016/07/29 10:56:20 datashard: 10 parityshard: 3
2016/07/29 10:56:20 acknodelay: false
2016/07/29 10:56:20 dscp: 0
2016/07/29 10:56:20 conn: 1
2016/07/29 10:56:29 stream opened
2016/07/29 10:56:34 stream opened
2016/07/29 10:56:44 stream opened
2016/07/29 10:56:44 stream opened
2016/07/29 10:56:44 stream opened
2016/07/29 10:56:44 stream opened
2016/07/29 10:56:45 stream opened
2016/07/29 10:56:53 stream opened
2016/07/29 10:56:59 stream closed
2016/07/29 10:57:04 stream closed
2016/07/29 10:57:04 stream opened
2016/07/29 10:57:14 stream closed
2016/07/29 10:57:14 stream opened
2016/07/29 10:57:14 stream closed
2016/07/29 10:57:14 stream closed
2016/07/29 10:57:14 stream closed
2016/07/29 10:57:15 stream closed
2016/07/29 10:57:15 stream opened
2016/07/29 10:57:20 [ERR] yamux: keepalive failed: i/o deadline reached
2016/07/29 10:57:20 [ERR] yamux: Failed to read header: broken pipe

kcptun只是一个通路，必须接后端


[PORT] Add support for Facebook Message Read event

Port this change from botbuilder-dotnet/master branch:
https://github.com/microsoft/botbuilder-dotnet/pull/4225

See https://developers.facebook.com/docs/messenger-platform/reference/webhook-events/message-reads
Description
Add support for Facebook Read Message.
It may not be used by the Bot yet but it helps to better support the Facebook events and allow better reusability of the library outside of the "Bot" context in another project for example.
Specific Changes

added FacebookRead.cs class for deserialisation of Facebook Event message_reads
added new property Reads on FacebookMessage

Changed projects

Adapters

@benbrown does this capability exist in bot kit?

According to https://github.com/howdyai/botkit/blob/main/packages/docs/reference/facebook.md#facebookeventtypemiddleware the message read event is supported.


Fix missing space in Falcosidekick-UI ttl argument

Signed-off-by: Jesús Carpintero<EMAIL_ADDRESS>
What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

If this PR will release a new chart version please make sure to also uncomment the following line:

/kind chart-release

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area falco-chart

/area falco-exporter-chart

/area falcosidekick-chart

/area event-generator-chart

What this PR does / why we need it:
helm template falcosidekick falcosecurity/falcosidekick --set webui.enabled=true --set webui.ttl=3303
Error: YAML parse error on falcosidekick/templates/deployment-ui.yaml: error converting YAML to JSON: yaml: line 36: could not find expected ':'

Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Checklist

[x] Chart Version bumped
[ ] Variables are documented in the README.md
[x] CHANGELOG.md updated

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: jesusfcr
Once this PR has been reviewed and has the lgtm label, please assign cpanato for approval by writing /assign @cpanato in a comment. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Issif, jesusfcr
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Issif]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: 860707914efbe8c8c6bd0998ccde3644461a41e2

Thank you for you PR. CircleCI is broken for now, I don't know, this is why even after my approval, it's not merged. FYI, you also have to update the dependency in the Falco chart, see last PR.

@jesusfcr are you planning to create the PR for falco chart or do you want me to do it?


Support for data format NHWC in convolutional layers

Hello,
First of all, thank you for your great work!
I noticed that Equinoxs' convolutional layers use NCHW data format, which, according to Nvidia Tensor Layout, is not optimal for Tensor cores on modern day GPUs.
Changing the (default) data format from NCHW to NHWC hence may benefit performance of convolutional operations.

I think this kind of optimisation should happen automatically at the XLA level. Outside of the jit'd region, store your input in NHWC. Then pass into the jit'd region, transpose to NCHW, and call Equinox.
Under-the-hood, XLA will remove the transpose + NCHW kernel and just replace it with a call to a NHWC implementation.
(I believe.)

Hi @patrick-kidger,
thanks for the quick response.
You may be right here, I have no idea what happens under the hood. I just noticed that the convolution operation in Haiku and FLAX support this option and figured, there may be a difference :-)

I think this kind of optimisation should happen automatically at the XLA level. Outside of the jit'd region, store your input in NHWC. Then pass into the jit'd region, transpose to NCHW, and call Equinox.
Under-the-hood, XLA will remove the transpose + NCHW kernel and just replace it with a call to a NHWC implementation.
(I believe.)

Do you mind explaining this a bit further? I've implemented the VDVAE in both Flax and Equinox, and fp32 training is a bit faster in Flax while float16 training is 40-50% faster. As far as I can tell, the only implementation difference is Equinox with NCHW and Flax with NHWC. I enjoy Equinox much more so I'd like to regain as much of that gap as I can.

Interesting! The overhead from Equinox flattening usually isn't very much -- is your model quite small?
Anyway, I'm glad that you were able to resolve this.


Feature proper readme

I've reworked the old README.MD a bit. We now have a lot more information in the README.

One this is approved, we can close #204.

Maybe make the feature list a list with checkboxes instead so people know which tasks are done or not. i think github markdown has support for that.

Also I can host the media on my website tomorrow so we don't have to download those images as well when we clone.


Make the CommandFactory fully static class.

Coverage decreased (-0.005%) to 72.888% when pulling 48f7a7c834066d17988e04fa2aedf2e4cd3b2260 on fully-static-factory-aleksi into 9b4769f947c88e00199c4cbfe19d2d0ab87f377d on master.

It's in #335


Add django.contrib.sites to INSTALLED_APPS

As requested in https://github.com/Tivix/django-rest-auth/issues/218 hereby the PR to include django.contrib.sites in the installation instructions.

Coverage remained the same at 87.959% when pulling 9cc1a2c3480941d5ac871776fb3c097661e0cf2f on hkraal:docs-installation-include-django-sites into 3189a5c7a0be6540f8b57642cce71176879205e2 on Tivix:master.

When include django.contrib.sites in installed apps, also you must setup SITE_ID =

Coverage remained the same at 87.959% when pulling 580e7bdc965c33ce017121c7bfb39027d5e1f31a on hkraal:docs-installation-include-django-sites into 3189a5c7a0be6540f8b57642cce71176879205e2 on Tivix:master.

@Akay7 Right, fixed that with a new commit. Let me know if all is in order according to you and I'll rebase  and squash before you merge

@hkraal really you can set any number to SITE_ID. But that's okay, anyway who must set different numbers to SITE_ID they will know what they do.

@hkraal Looks good. Please do a squash and then I'll merge it into master. Thanks!

@mariodev I've squashed my commits and rebased master onto my branch so it should be a clean FF merge!

Coverage remained the same at 91.355% when pulling 8812ba11af884424abc7f0106f44f069d1680216 on hkraal:docs-installation-include-django-sites into c4e7bdc77f03b2e1dc4a5f98a78f8133c53719c4 on Tivix:master.

Coverage remained the same at 91.355% when pulling 8812ba11af884424abc7f0106f44f069d1680216 on hkraal:docs-installation-include-django-sites into c4e7bdc77f03b2e1dc4a5f98a78f8133c53719c4 on Tivix:master.

Coverage remained the same at 91.355% when pulling 8812ba11af884424abc7f0106f44f069d1680216 on hkraal:docs-installation-include-django-sites into c4e7bdc77f03b2e1dc4a5f98a78f8133c53719c4 on Tivix:master.


New chat

Are we still doing a new chat?
I have no job and im bored as fuck.

yeah we can start it. all i've done so far is think of fun features

Are you moving away from chatango yet?

yeah i think we should just make our own chat with some nodejs websocket thing
i was thinking we could connect the chat to the list of streams youre watching and do funny stuff with it


Added command for manage.py testserver also

This should resolve #9
It's just a management command file for the testserver command in the same style as the test.py command file. It uses the same -n or --nomigrations flag to enable it.
The command still needs a fixture to run though so
manage.py testserver -n my_fixture.json
should do the trick

Just released 0.6 with this improvement. Tks!


Multiapi auto

Codecov Report

Merging #1633 into master will increase coverage by <.01%.
The diff coverage is 42.47%.

@@            Coverage Diff             @@
##           master    #1633      +/-   ##
==========================================
+ Coverage   56.08%   56.08%   +<.01%
==========================================
  Files        3902     3904       +2
  Lines       94287    94291       +4
==========================================
+ Hits        52881    52885       +4
  Misses      41406    41406

Impacted Files
Coverage Δ

...zure/mgmt/resource/locks/management_lock_client.py
87.8% <ø> (ø)
:arrow_up:

...t/resource/resources/resource_management_client.py
75% <ø> (ø)
:arrow_up:

...rce/azure/mgmt/resource/features/feature_client.py
92.3% <ø> (ø)
:arrow_up:

...mgmt/resource/subscriptions/subscription_client.py
92.1% <ø> (ø)
:arrow_up:

...te/azure/mgmt/compute/compute_management_client.py
60.77% <ø> (ø)
:arrow_up:

...erregistry/container_registry_management_client.py
83.05% <ø> (ø)
:arrow_up:

...source/azure/mgmt/resource/policy/policy_client.py
67.64% <ø> (ø)
:arrow_up:

...zure/mgmt/resource/links/management_link_client.py
94.44% <ø> (ø)
:arrow_up:

azure-mgmt-network/azure/mgmt/network/__init__.py
100% <100%> (+61.15%)
:arrow_up:

azure-mgmt-storage/azure/mgmt/storage/__init__.py
100% <100%> (+31.5%)
:arrow_up:

... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbac87c...5bbae63. Read the comment docs.


added TimeSpanValidationContract

added TimeSpanValidationContract unit tests

Thank you very much!

Hi Andre,
I'm very appreciate to you for your review. I'm glad to help open source, I
feel happy to make development for community benefit.
And also it is another way of improving coding skills for a developer.
Thank you very much
Best Regards
Andre Baltieri<EMAIL_ADDRESS>30 Ağu 2018 Per, 01:48 tarihinde
şunu yazdı:

Thank you very much!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/andrebaltieri/flunt/pull/20#issuecomment-417132010,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AMLB6hh1L03UHVzfTCPDCuwc88KrNy0Sks5uVxpVgaJpZM4WQawC
.

Nice to know!
We did a "Live" Coding review/merge yesterday on my YouTube channel, but we spoke in Portuguese:
https://www.youtube.com/watch?v=-gYnE9K10QI
I also thanked all PRs including yours on this video (37:44)!


Fix Community Calendar

On first load of the Community Page, the calendar isn't showing any events.

If I nav to February, it shows events and if I nav back to January

Looking into this now


587 tutorial "Using Covalent with PennyLane for hybrid computation"

Tutorial on a simple demonstration of integrating Covalent with PennyLane.
Link to issue: https://github.com/AgnostiqHQ/covalent/issues/587

[x] I have added the tests to cover my changes.
[x] I have updated the documentation and CHANGELOG accordingly.
[x] I have read the CONTRIBUTING document.

Hello. You may have forgotten to update the changelog!
Please edit CHANGELOG.md with a one-to-two sentence description of the change in the UNRELEASED section. You may include a small working example for new features.

Hey @ruihao-li. I just took a look through this. It looks like a really good job to me, so well done!
I have one or two minor comments to make though:
(1) The hybrid computation that is being made is three-fold. (i) Quantum (photonic chip) (ii) Quantum (standard gate-model) and (iii) Classical compute. I then think that the classical compute should be it's own electron (i.e, the difference squared function).
(2) Could you please mention somewhere in a markdown cell that Covalent is able to intelligently schedule the tasks from all three paradigms? Right now we show how you would do it but do not motivate the use of covalent!

Thanks @jackbaker1001! I made some modifications based on your comments. Please see the latest commit and description.

@ruihao-li This all looks great now and has my approval.
Once the failed check issue is dealt with (@kessler-frost what is that?) we should be good to merge.

Hey @jackbaker1001, I think @ruihao-li might've missed updating the CHANGELOG.md which will make the version check fail.

Hey @kessler-frost, will do that soon. @jackbaker1001, where do we want to place this tutorial, Beginner or Advanced?

@ruihao-li Beginer for this one


Prune orders instruction

For full context on these changes, read the summary here https://github.com/project-serum/serum-dex/pull/150.

Fuzz tests for this are here https://github.com/project-serum/serum-dex/pull/158.


I got a source compile error

Describe your problem here.
before i got that teacall error now i got this error

Are you modding a build from source or with Lua?
Source
What is your build target?
Windows x64
Did you edit anything in this build? If so, mention or summarize your changes.
Yes i edited HScript.hx

Please help

You forgot a }

I dont understand

you forgot to close a function/expression at line 490

ok im going to try it

Now i got this

That's good
It means it's working


Is there any step that I haven't completed?

I checked the crash_summaries.txt, it shows 09/16 07:14AM outputs/my_videos/377de2ca/logs/opengl_0_0_0001_0.err reason='Could not summarize cause, check outputs/my_videos/377de2ca/logs/opengl_0_0_0001_0.err' node=None fatal=True
Then I checked opengl_0_0_0001_0.err, it shows
/xxx/infinigen/outputs/my_videos/377de2ca/tmp/opengl_d150d739c7254720bbd00b9c48fcbd2d.sh: line 8: /xxx/infinigen/infinigen/datagen/customgt/build/customgt: No such file or directory
Is there any step that I haven't completed?

It appears you havent installed our opengl ground truth module. this could have happened if you chose the MINIMAL_INSTALL version of Installation.md. You will need to either remove opengl_gt from your command, or you can run bash scripts/install/compile_opengl.sh to compile it.


Here we go again

I'm getting this after updating to v<IP_ADDRESS>.
You're using a version of Snapchat or operating system that's no longer supported. Please upgrade your device's operating system and update to the newest app version to use Snapchat. Thanks!
Changing user agent does not work :-(

I'm seeing this aswell @mgp25

Waiting for a fix aswell.

i would appreciate it if you learned how to code tyvm f47effd4751f1352bda86b81e9dce449ed3882fd


Use a lookup table for structured HTTP fields

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

138 of 145 (95.17%)  changed or added relevant lines in 14 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.04%) to 93.271%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/NSign.Abstractions/Signatures/UnknownStructuredFieldComponentException.cs
8
11
72.73%

src/NSign.Abstractions/Signatures/StructuredFieldParsingException.cs
8
12
66.67%

Totals

Change from base Build<PHONE_NUMBER>:
0.04%

Covered Lines:
2574

Relevant Lines:
2794

💛  - Coveralls


(PUP-6839) Bump version to 4.8.0

This updates Puppet's version to 4.8.0 in preparation for the
puppet-agent 1.8.0 release.

CLA signed by all contributors.

👍


Link failed transaction error messages to tec codes doc page

Currently when you clicked into a failed transaction in the explorer you get an error message with no context like this screenshot, but would be great if they can actually link you to the tec codes doc page https://xrpl.org/tec-codes.html#tec-codes (open in new tab) you can see your error message and the corresponding explanation, instead of Googling it.

Proposed (link to tec codes doc page)

Icon SVG (in gray, hex #939A9F)

Thank you for addressing it! A new ticket has been initiated for this feature.

It would also be great if the tec codes page could have a # link (not sure what they're actually called, but like a sub-link) that links to each of the actual codes on the page.


feat/add-light-mode

Fix #9
I have added light mode.
Couldn't get what's you were saying about shadow.

Hi @henrylin03, you can assign yourself.

thank you - closing PR


Decrease number of second-level packages.

We have too many secondary-level packages which makes our top-level Sphinx documentation spammy.
The suggestion is to move threads/ and colors/ to util/, and remote/  to animation/.  With omitting main/ that would give us six subdirectories, which is quite sparse for a typical Python project...

+1
On Mon, Nov 13, 2017 at 11:30 AM, Tom Swirly<EMAIL_ADDRESS>wrote:

We have too many secondary-level packages which makes our top-level Sphinx
documentation spammy.
The suggestion is to move threads/ and colors/ to util/, and remote/ to
animation/. With omitting main/ that would give us six subdirectories,
which is quite sparse for a typical Python project...
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/ManiacalLabs/BiblioPixel/issues/476, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AA6a6nFya0bsXk7z8VLESiiTokTxvabaks5s2G6wgaJpZM4QcClp
.


jackett: 0.20.709 -> 0.20.740

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for jackett is: "API Support for your favorite torrent trackers"
meta.homepage for jackett is: "https://github.com/Jackett/Jackett/"
meta.changelog for jackett is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
Warning: no invocation of /nix/store/l9aq0f4krdl2qvi1iaxk3354vzxnhfd5-jackett-0.20.740/bin/jackett had a zero exit code or showed the expected version
Warning: no invocation of /nix/store/l9aq0f4krdl2qvi1iaxk3354vzxnhfd5-jackett-0.20.740/bin/Jackett had a zero exit code or showed the expected version
0 of 2 passed binary check by having a zero exit code.
0 of 2 passed binary check by having the new version present in output.
found 0.20.740 with grep in /nix/store/l9aq0f4krdl2qvi1iaxk3354vzxnhfd5-jackett-0.20.740
found 0.20.740 in filename of file in /nix/store/l9aq0f4krdl2qvi1iaxk3354vzxnhfd5-jackett-0.20.740

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 x86_64-darwin rebuild(s)

First fifty rebuilds by attrpath
jackett

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/l9aq0f4krdl2qvi1iaxk3354vzxnhfd5-jackett-0.20.740 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A jackett https://github.com/r-ryantm/nixpkgs/archive/cbceae795550e12875119a73f689cec54f5446eb.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/l9aq0f4krdl2qvi1iaxk3354vzxnhfd5-jackett-0.20.740
ls -la /nix/store/l9aq0f4krdl2qvi1iaxk3354vzxnhfd5-jackett-0.20.740/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

jackett

Maintainer pings
cc @edwtjo @nyanloutre @purcell for testing.

v0.20.915 is already out


[GSoC] Optimizing the VOC Compiler

This proposal intends to improve the performance of VOC-generated bytecode by adding piecemeal optimizations.
Table of Contents

Motivation
Goals
Overview of Changes
Considerations
Proposed Timeline
Risk Analysis

Motivation
The current implementation of Python AST to Java bytecode transpilation in many cases takes a naive approach, resulting in redundant bytecode instructions being produced and class files being longer than necessary. Not only does this make the code run slower than it should, this causes problems in some cases because the JVM enforces a size limit on class files, in particular on method sizes: each method must be less than 64KB.
This proposal explores optimizations that cut down the number of generated bytecode instructions.
Goals
This is a list of criteria to use as an evaluation of the success of this project.

All changes outlined in this proposal are implemented;
All changes are tested with a high level of code coverage;
Any problematic areas or potential future optimizations are documented;
Weekly progress updates are given orally/in writing so mentors, community and other GSoC students know what I'm working on.

Overview of Changes
Reducing Instances of Variable Creation
VOC-generated bytecode contains a lot of Object creation and initialization because everything in Python is an Object. Being frugal when creating string and integer objects, in particular, will result in huge savings.
Primitive Types
The Python Object abstraction is preserved in BeeWare's java implementation of the built-in types. However, this means that every time one of these objects is used instructions for Object creation must be generated. Working directly with the java primitives rather than wrapping them in Object would give a significant performance boost. The standard python types int, float, complex, Str, bool and None are considered here as the first candidates for refactoring.
Integers
CPython keeps an array of integer objects for all integers between -5 and 256. When an integer is created in that range a reference to the existing object is returned. It should be possible for VOC to do the same, that is, instead of generating bytecode that creates a new Integer object, any integer in [-5, 256] will refer to the preallocated integer.
Improving Variable Lookup
When a variable is read, instructions for loading global or local variables are generated. However, if the variable is looked up again, VOC has to generate the same loading instructions again. This results in a lot of duplicated bytecode.
VOC should cache values after the first lookup of global variables, modules, and functions whenever possible.
Considerations

Converting to SSA form. Static Single Assignment form is a property of bytecode that requires each variable to be assigned exactly once and can have huge benefits in simplifying some types of optimizations, such as redundancy elimination (common sub-expression elimination, constant propagation). However, converting bytecode to SSA form is nontrivial and it's unclear whether VOC actually needs these types of optimizations. If in the future this becomes more valuable to implement the work here should still be relevant.

Proposed Timeline
Preparation

Until April 23 (Student Proposal Acceptance)

Get to know codebase as suggested changes require a deep understanding of VOC
Take on small coding tasks to learn the development process and about working with BeeWare contributors
Respond to any further questions or comments from BeeWare about my proposal, if any

April 23 - May 14 (Community Bonding Period)

Same as above
Get more comfortable reading and writing bytecode.

Integer Pre-allocation

Week 1: May 14 (Official Coding Start) - May 20

Familiarize myself with performance benchmarking tools so I can evaluate the effectiveness of the optimizations in the coming weeks.
Implement preallocation of a small integer array small_ints.
Add logic for generating a lookup in the small_ints array instead of creating integer objects.

Variable Lookup Optimization

Week 2: May 21 - May 27

Write a method that makes a pass over the generated bytecode. This method allows identification of variables that are loaded multiple times, and a mechanism to mark those locations, so that on the next pass the instructions can be changed in the right places.

Week 3: May 28 - June 3

Write a method that inserts instructions to cache values of global variables after the first load, and remove subsequent reloads with a local load

Week 4: June 4 - June 10

Write a method that updates the jump addresses that change as a result of the above.

Week 5: June 11 (Phase 1 Evaluation due 15th) - June 17

Write a method that inserts instructions to cache values of modules that are loaded multiple times, and remove subsequent reloads with a local load
Write a method that handles updating the jump addresses

Week 6: June 18 - June 24

Write a method that inserts instructions to cache the value of functions after the first load, and remove subsequent reloads with a local load (this one might be a bit trickier, we'd have to make sure that other methods don't modify what was loaded)
Write a method that handles updating the jump addresses

Week 7: June 25 - July 1

Integration testing. I'm a little unsure about how these optimizations will combine and would like to write larger scale tests.

Primitive Types Optimization

Week 8: July 2 - July 8

Discuss with mentor regarding where to put the static methods and how their use changes, as well as how to make these changes incrementally since the standard types are ubiquitous in Python code and in the codebase.

Week 9: July 9 (Phase 2 Evaluation due 13th) - July 15

Refactor Str.java and provide all utility methods statically.
Replace uses of Str methods in the codebase with calls to the static methods.

Week 10: July 16 - July 22

Refactor Int.java and provide all utility methods statically
Replace uses of Int methods in the codebase with calls to the static methods.

Week 11: July 23 - July 29

Refactor Float.java and Complex.java and provide all utility methods statically
Replace uses of Float and Complex methods with calls to the static methods.

Week 12: July 30 - August 5

Refactor Bool.java and NoneType.java and provide all utility methods statically
Replace uses of Bool and NoneType methods with calls to the static methods.

Note: The official coding period is May 14 - August 14, which is a 13 week period. I've accounted for 12 weeks of work here.
Risk Analysis
There are many gaps in my technical knowledge:

Reading bytecode
Debugging bytecode (there's a tool in ASM, but how useful is it?)
JVM specifics
VOC transpilation specifics
VOC's testing system
... and others I'm not aware of right now

I will try to mitigate this by keeping my mentor updated of my progress, updating this timeline as needed, and asking for help early.

@patiences This is a really solid first draft - great work!
A couple of suggestions:

It's great that you've included benchmarking in week 7; however, benchmarking is most useful when it's an ongoing measurement process. I'd suggest getting the benchmark situation sorted out first, so you can run the benchmark each week (or after each change) as a measure of ongoing progress.

Interning strings is a good idea, but I'm not sure if the approach you've proposed will work (at least, not as I've understood what you've described). The constant table in a class file needs to be Java primitives and references; Python strings are instances of a Python string class. So, it won't be possible to intern the Python string instances in the constant table; you'll need a different approach.

Of course, another approach would be to modify VOC to use Java strings in place of a separate string class - which require much less messing around with type conversion, but would mess up the internals a lot. However... I suspect it would also be a huge performance bump. Given that you've found conflicting opinions about whether StackMapFrames are worth the effort, our time might be better served looking to see if modifying VOC internals to use Java primitives rather than classes for Python primitives might be worthwhile. Even a speculative experiment that doesn't end up with production code might be a better use of GSoC time than implementing a bytecode structure that doesn't actually benefit performance.

The constant table in a class file needs to be Java primitives and references; Python strings are instances of a Python string class. So, it won't be possible to intern the Python string instances in the constant table; you'll need a different approach.

Ah, right!

another approach would be to modify VOC to use Java strings in place of a separate string class

Do you mean that python methods that operate on strings (Dict#getitem, for example?) should take java.lang.String strings instead?

Given that you've found conflicting opinions about whether StackMapFrames are worth the effort
Yeah, unfortunately I've seen multiple times that the performance gain was more of a theoretical advantage and has not been realized. :-( But wouldn't implementing StackMapFrames be a good idea since they are no longer optional in Java 8 -- is that a good enough reason?

Regarding strings: I was thinking that the potential optimisation is to completely remove any concept of an org.python.types.String, and replace them with java.lang.String (and similar with Integer, Boolean, and so on). Essentially, we'd be making a special case of Python primitive types, making them fall back to Java primitives.
The catch is that we'd need to provide all the utility methods that Python provides on it's primitive types (e.g., str.format) as a static method somewhere, and if you ever try to invoke a method on a primitive, it would be redirected to the static method.
It wouldn't be a trivial change, though - at the moment, we can assume every object is an org.python.Object; if we start using Java primitives, that distinction would be lost.
As for whether SMF's are worth adding... that's a good question. It's possibly a good move to still add them; at the moment, we can only generate Java 6 bytecode, and while Java VMs are completely backwards compatible, and J6 bytecode will continue to run, it means that if Java ever adds anything interesting (and they already have in J7 and J8), we're might start to hit problems if our Java source code (for the Python standard library) starts to use those features.

Does this mean that users that write Java extensions for their Python code also have to use Java 6 (I don't know how often this happens)? That seems a bit outdated, I personally can't imagine writing java code without J8 lambdas. If this is the case StackMapFrames would probably be a very good idea.
On the other hand, I think the special-casing Python primitive types would be more interesting work for me. :-)

Combining Java6 and Java8 classes in a single executable shouldn't be a problem... but those are always famous last words :-) And, we don't know what is going to be added in Java9 that might cause compatibility problems with Java6. Pinning ourselves to a known-deprecated format isn't a good idea in general.
Honestly, either StackMapFrames or trying to make better use of primitives would be a viable project; StackMapFrames is better defined, but more detailed; primitive use is a lot more exploratory.

@freakboy3742 Thanks for all the insights! :-)
I've updated my proposal to address your comment about getting the benchmarking down in the first week. I've also replaced the work on implementing StackMapFrames with the primitives types optimizations we've chatted about in the comments here, as it is more interesting work for me and will likely have a huge performance impact. I've also added an extra week to the variable lookup work period -- I've been thinking about how to update the jump addresses and I'm still not sure so I've factored in some more time for that.
Let me know what you think!

This is looking pretty good - certainly good enough to submit as a final proposal.

This project was selected for the 2018 GSoC.

Week 2 finished! I've been working on:

Small integer and boolean pre-allocation. Code here and here. I am currently investigating the effect on in-place operations, once that is fixed, should be ready for PR.

Performance benchmarking test suite, code here. Should be ready for PR soon as well.

No blockers, and plenty of work to do coming into week 3! :-)

End of week 3 update:

Made progress on small integer and boolean preallocation by further restricting Integer and Boolean construction in the codebase on the Java side rather than just the transpilation side. This should greatly improve performance of Integers and Booleans that are created as a result of executing the code (range, for example), and speaking of which:

I've been working a lot on how to demonstrate the performance gain of small integer and boolean preallocation. I realised that I wasn't properly measuring the execution time which was causing a lot of instability in the tests but I now have a system. :-) Will have results to share early next week.

Hoping to wrap up these 3 PRs this coming week, and starting work optimizing global loads!

End of week 4 update:

Boolean optimization is merged and small integer optimization and the benchmarking test are close. Hooray! These optimizations actually have created considerable performance improvement as can be seen by the performance tests results which is super exciting.

At the end of the week I started working on optimizing global loads (https://github.com/pybee/voc/pull/833), and will be continuing to work on that this week.

Thanks @freakboy3742 for spending extra time with me this week, even finding time to pair program! :-)

End of week 5 update (sorry late!):

Small integer optimization and the benchmarking test are merged! Yay! The integer optimization definitely gave us a performance boost (though not as drastic as the boolean optimization), and the test suite provides a way to detect changes that affect performance.

This week has been all about working on optimizing global loads. I opened a number of pull requests experimenting with different types of caching, and after meeting with Russ, decided to focus on trying to cache individual modules. Unfortunately I didn't manage to get pystone working (trying to run it through voc results in a org.objectweb.asm.tree.analysis.AnalyzerException: Error at instruction 3882: Incompatible stack heights), I may look at that in a future week. This week my goal is to get one optimization working.

End of week 6!

I've spent the past week on https://github.com/pybee/voc/pull/839, an optimization for global loads that caches Module objects since those get looked up a lot. There are some pretty neat performance improvements (in the PR) already. The last piece is getting it working for generator functions, and I'm hoping to close this next week.
I've also started working on https://github.com/pybee/voc/pull/845, which is an optimization for function calls that take no arguments. The code is all there, but I'm having trouble writing a performance test for this one, so I'll be working on this early next week as well.

Next week I'll look at getting pystone working as well, as it would be super beneficial, and perhaps doing some profiling. On another note, I've written a blog post about my first month working on VOC, check it out if interested :-)

End of week 7 update:

This week I spent a lot of time on https://github.com/pybee/voc/pull/839, trying to optimize GeneratorFunctions and I think I've found out why it's not working/why it's not a good idea. I'm going to spend just a little more time this week wrapping this up, and then it'll be ready for review.

I've been working on writing a performance test for https://github.com/pybee/voc/pull/845 to show the performance improvement, but I haven't been able to write such a test. I think this is because while there are savings any time we can create fewer objects, the extensive null checks I added to support passing null as an argument on the java side perhaps cancels out any improvement. So it might be the case that there is no actual performance improvement. I'll check with Russ next week to see what we want to do with this PR.

This week I was also able to get pystone running which revealed a bug (fix here). These PRs should be merged soon, and I'll be taking a closer look at the pystone tests to see if we can identify some more candidates for performance optimization there.

End of week 8 update (late because I was away Jul 5-13):

Hooked up pystone [PR)(https://github.com/pybee/voc/pull/851)! The difference on my machine between the beginning of May (before I started working on my GSoC project) and on master now is about 2.8x faster (from ~500 pystones/sec to ~1400 pystones/sec) which is crazy!

Merged https://github.com/pybee/voc/pull/852 -- a bug fix (mentioned above).

Merged https://github.com/pybee/voc/pull/869 -- an optimization that comes from not creating __code__ attributes on functions. An issue to track __code__ inspection in the future is here.

Almost there with https://github.com/pybee/voc/pull/864 -- this one has been dragging because I've had so much trouble showing performance improvement by benchmarking. It turns out that this is because setting up for a function invocation (the site of this optimization) is nothing compared to how much time the function invocation actually takes. I've verified that the generated bytecode is smaller, so there is a little more cleaning up to do and then it will be ready for review.

I've written another blog post about the module optimization from this past month (https://github.com/pybee/voc/pull/839), if anyone wants to know more about that. :-)

End of week 9:

Merged https://github.com/pybee/voc/pull/875. This is an optimization that targets comparison operations (like >, ==, etc) due to org.python.types.Methods (unneccessarily) being created for each operation. I'm happy to say that it's resulted in an huge performance improvement on pystone!

There's a bit more work to do on https://github.com/pybee/voc/pull/877, a few small bugs that came out of working on #875 above. I'll wrap this up early next week.

Next week, I'll continue working through some potential optimizations based on results I've gotten from JProfile, so there's plenty more work to do!

End of week 10 update:

Merged https://github.com/pybee/voc/pull/881. This is an optimization targeting nested loops, by reusing the same instance of StopIterations. This does however introduce some behavioral differences between VOC and CPython, documented here: https://voc.readthedocs.io/en/latest/reference/differences.html

This past week I've been profiling small pieces of code that have exposed a few small bugs, including https://github.com/pybee/voc/issues/882, https://github.com/pybee/voc/issues/885, https://github.com/pybee/voc/issues/886, https://github.com/pybee/voc/issues/888, https://github.com/pybee/voc/issues/890.

Open PRs include 1) https://github.com/pybee/voc/pull/877, which is some bug fixes and refactoring around __contains__/__not_contains__.  2) An optimization targeting __dict__ creation which needs a few kinks worked out, and 3) the beginning of some work on reducing the number of org/python/types/Str objects created.

End of week 11 update:

Merged https://github.com/pybee/voc/pull/893. This was supposed to be just a cleanup of org/python/types/Str, but it turned out to be a decent optimization especially for the print function. (See the PR for benchmarking results)

Merged https://github.com/pybee/voc/pull/899. This is an optimization for org/python/types/Dict operations, which are ubiquitous in Python and also in the Pystone benchmark (we saw an amazing performance improvement on Pystone with this one, details in the PR).

Decided not to continue pursuing https://github.com/pybee/voc/pull/880, because it wasn't showing performance improvement and I was a bit mistaken about the way that Java initializes HashMaps.

Logged a few more bugs (https://github.com/pybee/voc/pull/889, https://github.com/pybee/voc/pull/904) and a quick refactoring (https://github.com/pybee/voc/pull/894).

This coming Tuesday is the official cutoff for GSoC, but I will continue working for about a week after. I'm currently working on a blog post for the website, and wrapping up a few more PRs this coming week.

End of week 12 update:

Merged https://github.com/pybee/voc/pull/910. This is the same optimization as https://github.com/pybee/voc/pull/899, for Dict.__setitem__().

Still working on https://github.com/pybee/voc/pull/902, which still needs some cleaning up. The optimization is about creating standard org/python/Object functions at demand, not at module initialization time, which speeds up our initialization time.

Started working on https://github.com/pybee/voc/pull/909 , which is about method caching. Method calls are currently very expensive in VOC because each time we call a method, we create it anew. This optimization yields a significant performance boost, but we are still figuring out how to handle __dict__ inspection if method objects are cached there.

Started working on https://github.com/pybee/voc/pull/905 which is about adding a python base object test suite. I'm having a lot of trouble with getting the tests passing, it looks like there are a lot of bugs around this (some of which, if not too hairy, I'm also addressing in the PR). Still more work to be done for this.

https://github.com/pybee/voc/pull/911 is ready for review -- it's a clean up of (what seems to be) legacy code that creates unnecessary objects.

Started working on https://github.com/pybee/voc/pull/913, which is part of a bug fix for https://github.com/pybee/voc/issues/907 and https://github.com/pybee/voc/issues/912.

I'm also currently working on hooking up a few more benchmarks from http://speed.pypy.org/comparison/ (which is where I'm finding all these new bugs!). I will try to wrap these up early this week if I can as I am planning on working as part of GSoC until Wednesday (but will be around to finish up anything that needs a little more time of course).


Avoid O(n^2) copy operations when draining the Q

Using table.remove(q, 1) will shift the remaining elements down causing #q - 1 copy operations.
This should be avoided.
Special care has to be taken since we are executing callbacks within the loop that potentially (?!) push further elements to the queue.

Thanks very much for the PR! Merged with one minor change.


Speed up deduplication. Fixes #391

Removes combining of source locators since the benefit is dubious.
Adds MultiInfo for faster appending of source locators in future.
I ended up removing the combining of source locators even though I had fixed the performance pathology because it's not clear to me if it's even beneficial. I looked at the results of deduplicating 64 identical Queues and all of the concatinations made the results... not pretty. Anyway we can always add it back in a sensible way in the future if we want to.

Checking if this solves my use case.

Yup this works. There is an unrelated issue I had to fix to get my use case working that I will submit an issue/PR for.
Thanks for fixing this.

Done. Also rebased on master


Document that Uri.encodeQueryComponent uses RFC 3986

We mention RFC 1738, I think we could mention RFC 3986 which updates it.
Some users expect to see 3986 when they search for APIs. For example the docs for the PHP method rawurlencode mention it. https://www.php.net/manual/en/function.rawurlencode.php
cc @lrhn
Context: https://gitter.im/dart-lang/sdk?at=5ea6edc5f6a6e539797d7737

Pretty much all of the Uri class is based on RFC 3986.

Would it be fair to replace mentions of 1738 with 3986? My main hope is that a search of the docs makes this easy to find.


Trigger Deployment Error - Multi-Company FFA

Hi
Am I trying to deploy DLRS in a multi-company FFA environement to roll up from FFA Sales Invoice to Account object.
I get an error deploying the trigger about the current Company not being set (see screenshot). I do have one of the company's set.
Thoughts, tips pointers?
Cheers
Martin

Sure, take a look at this, http://help.financialforce.com/accounting-api/16X/WritingApexTests.htm and this https://github.com/afawcett/declarative-lookup-rollup-summaries/wiki/Challenges-with-Code-Coverage


"Stop My Server" red button does not trigger anything

Hi,
I was wondering what would be the best way to trigger the stop coroutine of a spawner via the jupyterhub web interface. Unfortunately I did not mange to make the red button "Stop My Server" working. After having a closer look to the code, I stumbled in the home template here
https://github.com/jupyter/jupyterhub/blob/0fbd69be9bfc584e6c7d7613f517886ae7993b51/share/jupyter/hub/templates/home.html
it seems that there is no url linked to the button: was this done on purpose?
Cheers,
Danilo

I think the button is powered by JS, do you have home.js?

Yeah, the action is added by js. What version are you running, and do you see anything in the js console?

Closing this issue as it's been inactive for several months. Please feel free to open a new issue at the jupyter/help repo or add a comment to reopen this issue. Thanks! :sunflower:


two espaltherma same homeassistant

Could you tell me how I can have two espaltherma in the same home assistant? I want to control two Daikin Althermas in the same HomeAssistant installation. Can I? What should I change in the code so that the mqtt messages are not confused?
Thanks

Hi @ralf2025, welcome and thanks for your support.
Have a look at this same question opened 2 weeks ago #140
You'll find the things you need to change.

Thanks for the speed and I apologize for not having found it earlier. :-)


[go_router] ShellRoute sub routes not shown in debugLogDiagnostics log

The log printed when debugLogDiagnostics flag is set to true ignores every sub route declared inside a ShellRoute.
Steps to Reproduce
Run the Code Sample with flutter run

Code sample
import 'package:flutter/material.dart';
import 'package:go_router/go_router.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp.router(
      routerConfig: router,
    );
  }
}

final router = GoRouter(
  debugLogDiagnostics: true,
  routes: [
    GoRoute(
      path: '/',
      builder: (context, state) => Center(
        child: Text('home'),
      ),
      routes: [
        GoRoute(
          path: 'inner-path-1',
          builder: (context, state) => Text('Hello'),
        ),
        ShellRoute(
          builder: (context, state, child) => Center(
            child: child,
          ),
          routes: [
            GoRoute(
              path: 'shell-route-path-1',
              builder: (context, state) => Text('Hello'),
            ),
            GoRoute(
              path: 'shell-route-path-2',
              builder: (context, state) => Text('World'),
            ),
          ],
        )
      ],
    ),
  ],
);

Logs
Actual log
[GoRouter] Full paths for routes:
             => /
             =>   /inner-path-1
[GoRouter] setting initial location null
[GoRouter] Using MaterialApp configuration

Expected log
[GoRouter] Full paths for routes:
             => /
             =>   /inner-path-1
             =>   /shell-route-path-1
             =>   /shell-route-path-2
[GoRouter] setting initial location null
[GoRouter] Using MaterialApp configuration

Expected results: ShellRoute sub paths should be explored as well to print that log.
I found the problem is in the _debugFullPathsFor function in lib/src/configuration.dart which ignores ShellRoutes not exploring them recursively.

Thanks for the report. Seeing same behavior running on latest versions.

 stable, master flutter doctor -v

[✓] Flutter (Channel stable, 3.3.5, on macOS 12.2.1 21D62 darwin-x64, locale
    en-GB)
    • Flutter version 3.3.5 on channel stable at
      /Users/dhs/documents/fluttersdk/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision d9111f6402 (10 hours ago), 2022-10-19 12:27:13 -0700
    • Engine revision 3ad69d7be3
    • Dart version 2.18.2
    • DevTools version 2.15.0

[!] Xcode - develop for iOS and macOS (Xcode 12.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    ! Flutter recommends a minimum Xcode version of 13.
      Download the latest version or update via the Mac App Store.
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] VS Code (version 1.62.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.21.0

[✓] Connected device (5 available)
    • SM G975F (mobile)       • RZ8M802WY0X • android-arm64   • Android 11 (API 30)
    • Darshan's iphone (mobile)  • 21150b119064aecc249dfcfe05e259197461ce23 •
      ios            • iOS 14.4.1 18D61
    • iPhone 12 Pro Max (mobile) • A5473606-0213-4FD8-BA16-553433949729     •
      ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-3 (simulator)
    • macOS (desktop)            • macos                                    •
      darwin-x64     • Mac OS X 10.15.4 19E2269 darwin-x64
    • Chrome (web)               • chrome                                   •
      web-javascript • Google Chrome 98.0.4758.80

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

[!] Flutter (Channel master, 3.5.0-10.0.pre.17, on macOS 12.2.1 21D62
    darwin-x64, locale en-GB)
    • Flutter version 3.5.0-10.0.pre.17 on channel master at
      /Users/dhs/documents/fluttersdk/flutter
    ! Warning: `flutter` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/flutter, which is not inside
      your current Flutter SDK checkout at
      /Users/dhs/documents/fluttersdk/flutter. Consider adding
      /Users/dhs/documents/fluttersdk/flutter/bin to the front of your path.
    ! Warning: `dart` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/dart, which is not inside your
      current Flutter SDK checkout at /Users/dhs/documents/fluttersdk/flutter.
      Consider adding /Users/dhs/documents/fluttersdk/flutter/bin to the front
      of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 59d26c481a (5 hours ago), 2022-10-20 20:05:08 -0400
    • Engine revision f24ea1a04d
    • Dart version 2.19.0 (build 2.19.0-324.0.dev)
    • DevTools version 2.18.0
    • If those were intentional, you can disregard the above warnings; however
      it is recommended to use "git" directly to perform update checks and
      upgrades.

[!] Xcode - develop for iOS and macOS (Xcode 12.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    ! Flutter recommends a minimum Xcode version of 13.
      Download the latest version or update via the Mac App Store.
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] VS Code (version 1.62.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.21.0

[✓] Connected device (5 available)
    • SM G975F (mobile)       • RZ8M802WY0X • android-arm64   • Android 11 (API 30)
    • Darshan's iphone (mobile)  • 21150b119064aecc249dfcfe05e259197461ce23 •
      ios            • iOS 14.4.1 18D61
    • iPhone 12 Pro Max (mobile) • A5473606-0213-4FD8-BA16-553433949729     •
      ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-3 (simulator)
    • macOS (desktop)            • macos                                    •
      darwin-x64     • Mac OS X 10.15.4 19E2269 darwin-x64
    • Chrome (web)               • chrome                                   •
      web-javascript • Google Chrome 98.0.4758.80

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

For a more detailed description of an example, see https://github.com/flutter/flutter/issues/116439#issue-1473512737


How to display file in grid as a downloadable format?

How to display file in grid as a downloadable format?

You can use EPPlus (http://epplus.codeplex.com/) library to export grid data to excel file.

Thanks but I want file download functionality by click on grid column button name "Download". Admin upload some files and it will available for users to download it like pdf, word or others files.

You need to put link to /upload/yourfolder/0000/...., you need a formatter that will put /upload/ in front of file name.

Next version will contain a FileDownloadEditor

Thanks. I also want to display multiple document files in left pane and open selected file in document viewer editor.


An Error Message Occured during OTU Clustering Initialization

Hello!
I got an error message (Unexpected error: <class 'IndexError'>) at the begining of "OTU Clustering" step (following steps were completed: "paired-end merging, primer trimming, quality filtering, starting dereplication & pooling"), and the vSearch module was installed.  Do you have any recommendations for this situation?
Thank you for developing the program and for your time again.
Onur.

Can you please show the error that is printed in the console when clicking "Exit"?

Hi again, here they are.
The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/runpy.py", line 197, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/site-packages/apscale_gui/__main__.py", line 880, in <module>
    main()
  File "/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/site-packages/apscale_gui/__main__.py", line 475, in main
    pe_merging_main(str(path_to_outdirs))
  File "/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/site-packages/apscale/b_pe_merging.py", line 167, in main
    Parallel(n_jobs=cores)(
  File "/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/site-packages/joblib/parallel.py", line 1098, in __call__
    self.retrieve()
  File "/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/site-packages/joblib/parallel.py", line 975, in retrieve
    self._output.extend(job.get(timeout=self.timeout))
  File "/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/site-packages/joblib/_parallel_backends.py", line 567, in wrap_future_result
    return future.result(timeout=timeout)
  File "/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/concurrent/futures/_base.py", line 439, in result
    return self.__get_result()
  File "/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/concurrent/futures/_base.py", line 391, in __get_result
    raise self._exception
IndexError: list index out of range
onurdogan@Onurs-iMac ~ %

By the way, I tried using a few files with the "...fastq.gz" extension and successfully completed all the steps. However, when I attempted to use all the files I've owned, I encountered an error during the "OTU clustering" step. I have attached the log files related to this process.
You can find log file here :

 apscale_gui_worked_then_error
apscale_gui_worked

If you have time, I can demonstrate it using AnyDesk/Teamviewer at a mutually convenient time.
Best,

Just realised that I did a mistake in naming the samples as "...R1.fastq.gz" and "...R2.fastq.gz". This incorrect naming resulted in errors in my analysis. After the file was correctly named, the analysis was successfully performed by the "All-in-One analysis" module. Now, I'll be attempt the "NCBI Blast" module. Previously, "...xlsx" outputs of all of my these files in BOLDigger I've obtained. I hope that I can be adapt these outputs for analysis using "Taxon Table Tools (TTT)" too.
Thank you for the development of the programs.
Onur.

Good to hear that you were able to fix the error!
Yes, the output of APSCALE and BOLDIgger is compatible with TTT! The next update will make the conversion even easier, but I don't have the time to either update APSCALE or TTT at the moment. So you will need to perform some minor manual adjustments of the tables for now.


Decrement Score

Split score TDs so left half decreases score and right half increments score

Closed as part of #5


Problem showing negative short integer as decimal

I'm disassembling a Mac OS driver (32-bit PowerPC code). Mac OS error codes are negative. Depending on the context the code may be a 16- or 32-bit signed number.
Part of one decompiled function is sVar3 = -0x1ebb;. I want to show that number in decimal. Right-click on it in the decompiler window, choose Decimal: -7867 from the menu. After 5 or 6 seconds (on my old laptop), a Convert Failed window appears saying "Equate named -7867 already exists with value of<PHONE_NUMBER>".
[Note:<PHONE_NUMBER> = 0xFFFFE145 which is -7867 as a 32-bit signed integer.]
A couple of seconds after dismissing that window, I right-clicked the number and chose Decimal again. This time a dialog box "Decompiler Action Blocked" appeared, saying "You cannot perform Decompiler actions while the Decompiler is busy".
Converting the value to binary or octal did work however. This problem may be specific to short integers, since I was able to change a long integer value elsewhere to decimal?
[In this project, I may have previously created an enum for Mac error codes. Ghidra doesn't support negative enum values so I might have entered 0xFFFFE145 as one of the enum values. But I deleted that enum a while ago. I also previously worked on the project with Ghidra 10.1-BETA. Could this problem be due to the project file getting corrupted?]
To reproduce this download the attached project (same file as for issue# 3733).

Load the project. Open SCUSBeeShim.data
In the Functions window, click SCUSBee_SIMAction.
In the decompiler window, see sVar3 = -0x1ebb; near the start of the function.
Right click etc. as explained above

Attachments
Ghidra_SCUSBee_20211209.zip
Environment (please complete the following information):

Windows 10, Java 11.0.12, Ghidra 10.1

This seems like the same bug I've encountered which can be recreated by finding two instances of a value that displays as negative hex, right-clicking, selecting Convert > Decimal, and repeating this for the other instance. Seems like the first time creates an equate and the second time fails to recognize that the equate already exists. Manually setting the equate also has this issue.


Want to optimize setting hostname when creating a virtual machine

What happened:
Now if we don't set hostname when we create a vm and the virt-laucher will use vmi.spec.name as the vm's hostname and you can find the code from here. In my opinion we should generate the hostname by virt-controller rather than virt-launcher. If we use virt-controller to generate it and we can update the vm's configuration. Such as we can use kubectl get vm -o yaml to get the hostname.
WDYT?
Environment:

KubeVirt version (use virtctl version): N/A
Kubernetes version (use kubectl version): N/A
VM or VMI specifications: N/A
Cloud provider or hardware configuration: N/A
OS (e.g. from /etc/os-release): N/A
Kernel (e.g. uname -a): N/A
Install tools: N/A
Others: N/A

I think it't better to set hostname rather than virt-launcher. WDYT?

/cc @stu-gott

I think it should be possible to set the hostname using cloud-init, for scenarios where the hostname would not otherwise be set.
https://kubevirt.io/user-guide/virtual_machines/startup_scripts/

I fail to understand what is the bug is here.

If we use virt-controller to generate it and we can update the vm's configuration

I am not clear what you expect the virt-controller to do. If you mean it should mutate the VM or VMI spec, I think it is wrong. Through the spec we express what "we" desire, therefore if one did not desire anything, it should not contain anything. What actually is set and examine later can be expressed through the Status section, either through the guest-agent or possibly directly if available (I am not sure it is ok to guess what the guest actually has be set with, no one really can assure cloud-init is available in the guest).

I fail to understand what is the bug is here.

If we use virt-controller to generate it and we can update the vm's configuration

I am not clear what you expect the virt-controller to do. If you mean it should mutate the VM or VMI spec, I think it is wrong. Through the spec we express what "we" desire, therefore if one did not desire anything, it should not contain anything. What actually is set and examine later can be expressed through the Status section, either through the guest-agent or possibly directly if available (I am not sure it is ok to guess what the guest actually has be set with, no one really can assure cloud-init is available in the guest).

I will upload a detailed report to explain it.


CEF Severity supports both Strings and Integers

We have several ArcSight smart connectors processing/outputting messages in CEF format that are failing when using the parse_cef() function. The ArcSight Smart connector is already converting the CEF Severity to the "Low", "High"...etc. equivalent instead of the integer. Example:
CEF:0|Check Point|Security Gateway/Management|1.0|ctl|ctl|Low| ....
java.lang.NumberFormatException: For input string: "Low"
As of May 16th, 2016, Common Event Format v23 allows Severity to be a string value Low, Medium, High, or Very-High, or the integer value of 0-10. Would it be possible to get support for these string values?

@BenjaminLSmith Before devs fix this in the official branch, please check my forked repo:
https://github.com/SonofLiberty90/graylog-plugin-cef
I fixed some things there including string severity field parsing.


Rev Travis GoFmt version

Travis currently runs GoFmt only on Go v1.3 builds not 1.4. This is because GoFmt rules for 1.3 and 1.4 can conflict: for example, Go v1.4 no longer requires assignment in for-range loops, so the GoFmt optimizations differ for both versions (i.e. v1.3 expects _ = range blah 1.4 expects just range blah).
This causes issues for those of us running 1.4 locally, because running GoFmt locally produces code that fails Travis 1.3 builds. And if we use v1.3 syntax, local commits are blocked because v1.4 GoFmt won't be happy (which can be overridden but is still annoying).
Recommendation: modify Travis to Run GoFmt on Go v1.4 builds instead of v1.3 builds.

By definition, every time gofmt is changed, which happens on every single Go version, it breaks us. Maybe we should reconsider our hard requirement of running gofmt.
Another possibility is to run every version of gofmt and accept any match as passing.

I'm very much against removing the gofmt requirement--it replaces a style guide and eliminates nearly all of that sort of argument.
I think we should switch to gofmt from 1.4 when we switch to using 1.4 in our builds. There's nothing blocking either item except for people to do it :)

I agree with @lavalamp: GoFmt is great for avoiding code style debates, and we should run GoFmt only on the newest version of Go that we support (i.e. 1.4 today).

With #4663 gofmt is being run on 1.4. It seems like this issue is resolved?


UseCors must come before UseHttpsRedirection

Issue description
when using Cors middleware, it comes before UseHttpsRedirection.
if not, Cors middleware doesn't work
Software versions

[v] .NET Core 3.1 WebApi

on Startup.cs
public void Configure(IApplicationBuilder app, IWebHostEnvironment env)
        {
            if (env.IsDevelopment())
            {
                app.UseDeveloperExceptionPage();
            }

            app.UseRouting();

            app.UseCors();

            app.UseHttpsRedirection(); // after UseCors();

            app.UseAuthorization();

            app.UseEndpoints(endpoints =>
            {
                endpoints.MapControllers();
            });
        }

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 59bca5db-1196-2a8b-a0d8-4e89b2382288
Version Independent ID: d3f332c4-4c60-039e-0e1e-bc6b11831f87
Content: Enable Cross-Origin Requests (CORS) in ASP.NET Core
Content Source: aspnetcore/security/cors.md
Product: aspnet-core
Technology: aspnetcore-security
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

I don't think that's correct. See https://docs.microsoft.com/en-us/aspnet/core/security/cors?view=aspnetcore-3.1#test-cors

See also https://docs.microsoft.com/en-us/aspnet/core/fundamentals/middleware/?view=aspnetcore-3.1#middleware-order


#67 Fix Dark Modern inactive selection color

https://github.com/dinbtechit/vscode-theme/issues/67 - fix Dark Modern's inactive selection color

Thank you so much for the PR! can you also bump up the version number in gradle.properties to 1.8.1?

No problem :) Done


feat: fix plain string compiler

Fix RM-3436

🧰 Changes
Fixes the astToPlainText compiler.
I'm not sure how this working at all before, sometimes it returns a string, and sometimes it returns the passed in node?! Prior to this, it was calling .runSync(ast) which only runs the run step and only calls transformers on the passed in ast. Theoretically, the correct call should be .stringify(ast), which calls the compile step.
This PR reworks astToPlainText() to make the 'correct' call to .stringify(ast). It also copies in the hast-util-to-string library so that it will use a space ( ) to join all the strings together.
🧬 QA & Testing

Broken on production.
Working in this PR app.

This PR was released!
🚀 Changes included in v6.45.0


Update AndroidManifest.xml

Added needed permissions for document collection

@mrestuccia @borisonr  I reverted my changes to the manifest. I tested and confirmed locally it's not needed, it was just a misunderstanding of permissions.
I updated build.gradle to use 1.0.15 of the SDK instead of the 1.0.9. So isNext wont be a required parameter.
I couldn't see anywhere that Android Studio supported a @latest for dependencies.


Links for discussion items in a listing block are broken

Describe the bug
Links for discussion items in a listing block are broken
To Reproduce
Steps to reproduce the behavior:

Create a new listing block
Filter by type: "Discussion Item"
Save
On the view page, click on any listing item
404 error

Expected behavior
Go to the content page, and link to the correct discussion item

can i work on this


chore: jenkinsx-test-golang to 0.0.1

chore: Promote jenkinsx-test-golang to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Extract only strings and comments from code blocks

As a further step after #75, we should offer an option to only extract literal strings and comments from the code.
For this example:
fn pick_one<T>(a: T, b: T) -> T {
    if std::process::id() % 2 == 0 { a } else { b }
}

fn main() {
    println!("coin toss: {}", pick_one("heads", "tails"));
    println!("cash prize: {}", pick_one(500, 1000));
}

we would end up with just four small strings

"coin toss: {}"
"heads"
"tails"
"cash prize: {}"

in the POT file.
This would require us to process Tag::CodeBlock in a more fine-grained way, but I think it could be worth it.
The fun part would be to find a cross-language solution. I suspect our best bet would be to use a syntax highlighting library: they normally detect strings and comments and so such a library should have the necessary machinery.

Yeah, exactly! I'm hoping that we can use that library to get the byte position of string literals and comments. I don't have any experience with syntect, but I hope you can look at it.

I have tries to use syntect at #109. It seems to work fine.

I have tried to use syntect at #109. It seems to work fine.

That's awesome! It will probably reduce the line count in messages.po by a good margin.


Set dev version

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Expect an option to disable auto creation of subscriptions

The current pulsar admin rest endpoints have already supported to create/list/delete subscriptions of topics. It will be meaningful to allow administrators to disable auto creation of subscriptions. Some scenarios can benefit from it:

subscriptions should not be expanded arbitrarily (although subscriptions can be expired)
public cloud scenario
better to limit the count of subscriptions

@sijie @jiazhai I am trying to work on this, any suggestions? So far I can think of the following:

provide a flag allowAutoSubscriptionCreation, defaults to true
when allowAutoSubscriptionCreation is disabled and the specified subscription on the topic does not exist when trying to subscribe via a consumer, the server should reject the request directly by handleSubscribe in ServerCnx
create the specified subscription on the topic from pulsar admin rest endpoint before create a consumer

cc @codelipenghui

@murong00 the proposal looks good to me +1

@sijie @codelipenghui The above proposal may not work for Reader due to ReaderBuilderImpl (i.e. PulsarClientImpl.doCreateReaderAsync which calls ReaderImpl) does not support to pass subscription, its implementation is hard-coded currently. https://github.com/apache/pulsar/blob/760bd1abfa5374bde85e4d938937a0410dfb2674/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ReaderImpl.java#L37-L43
In addition, the current pulsar admin rest endpoints only support to create a Durable subscription which can not apply to Reader(or Consumer with a NonDurable subscription) whose subscription is NonDurable. https://github.com/apache/pulsar/blob/75a321dfbe23cbd979fa225ef4a3d2fc4201994b/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java#L741-L744
Should we skip the Durable subscriptions when checking to see if a subscription exists? Or maybe we can create it when it is NonDurable?

Any advice will be appreciated, thanks.

We can skip non-durable subscriptions

@sijie Thanks for the advice. I have submitted a fix, please help to review when you are available.


Please consider using pkg-config for cpprcypto

https://github.com/QuantStack/xeus/blob/master/CMakeLists.txt#L58
cppcrypto dropped cmake support. There is crypto-cmake project that breaks: https://github.com/noloader/cryptopp-cmake/issues/45
If the project doesn't officially support cmake, you probably shouldn't insist on expecting it.
In the FreeBSD port, I have this patch:
+FIND_PACKAGE(PkgConfig)
 find_package(nlohmann_json 3.2.0 REQUIRED)
 find_package(xtl 0.5 REQUIRED)
 find_package(cppzmq 4.3.0 REQUIRED)
-find_package(cryptopp REQUIRED)
+pkg_check_modules(cryptopp libcryptopp REQUIRED)

that works fine with cryptocpp project as it is distributed.

Yeah, we dropped cmake for zeromq because is was not the standard way of building zeromq.
What I think we should do is support both in the same way cppzmq supports both cmake and pkg-config for zeromq.

So can find what we did for zeromq here:
https://github.com/QuantStack/xeus/blob/master/CMakeLists.txt#L60-L67

My apologies for jumping in on other's bugs... If you guys need immediate help them ping me at noloader, gmail account. Projects and distros get special privileges.
You are still welcomed to file bug reports if you like. I use them for change control and documentation so if you don't them I may file one on your behalf.


added Cancel button in CREATE pages, and Confirm alert message when d…

…eleting donor from Blood Drive and some forms clean up

@alagiboy


Cydia and APT issues

Long story short, APT doesn't work (using SSH from Terminal) and Cydia crashes despite any amount of reboots. I'll just sit back and let Luca do his godly work and fix some stuff before I try to update my tweaks...

I think this is a long-known cydia bug.
Try with:
rm /private/var/mobile/Library/Cydia/metadata.cb0

What were you testing on @bobbysn0w

when will the ipa come out? People with windows cant jailbreak

@akelly5 DONT SPAM. STOP ASKING FOR ETA.

do you know where I can ask these questions??

@kpwn I suggest https://help.github.com/articles/blocking-a-user-from-your-personal-account/

About to test on my Verizon 5S. I can't remember what the device id is.

Thanks it works.

@akelly5 Ask someone to compile it for you and to send the IPA, but not on here though. This is for productive discussions relating to programming and etc only; not tech support.

@acelogic Lol Luca just tweeted to not ask for the IPA.


Border merge crash with none

Hello.
.test {
  border: 1px none red;
  border-bottom-style: solid;
}

Crashes with unknown property toLowerCase of undefined.

What version? I can't really replicate it with the latest release of cssnano:
https://cssnano.co/playground/

Good catch, thanks.

Fix has been merged into master.


Structural elements: implementation of truss element

This is already started in #176. Aim is to implement a simple truss element for linear elasticity. Take a look also to the JuliaFEM.org/examples. Let's put the focus on static analysis first. This can later on be extended to dynamics also.

[ ] Finalize implementation. We should have working truss model for linear elasticity, for 2d and 3d. It should take at least Young's modulus and cross-section area in order to work. Make it work for both linear elements (Seg2) and quadratic elements (Seg3).
[ ] Create a test. Testing of model should be done with some known result. Testing must be done for 2d and 3d models separately. We can calculate some simple truss structure using e.g. ABAQUS or Code Aster and compare results to that.
[ ] Create Jupyter notebook. It can contain some simple introduction part with review to the theory. Then we show how to solve simple truss problem using JuliaFEM. This goes to http://www.juliafem.org/examples
[ ] Optionally, instead of introducting theory in Notebook, a separate .md file can be created for Truss elements and included to docs/src/theory/truss.md

This is on progress on FEMTruss.jl


upgrade to k8s 1.25.0

added helper script
from https://github.com/kubernetes/kubernetes/issues/79384#issuecomment-521493597
to scripts/upgrade-k8s.sh

as requested

upgraded to Kubernetes 1.25.0:
$ ./scripts/upgrade-k8s.sh 1.25.0
go: downloading k8s.io/kubernetes v1.25.0
go: upgraded k8s.io/api v0.25.0-rc.0 => v0.25.0
go: upgraded k8s.io/apimachinery v0.25.0-rc.0 => v0.25.0
go: upgraded k8s.io/apiserver v0.25.0-rc.0 => v0.25.0
go: upgraded k8s.io/component-base v0.25.0-rc.0 => v0.25.0
go: upgraded k8s.io/component-helpers v0.25.0-rc.0 => v0.25.0
go: upgraded k8s.io/kubernetes v1.25.0-rc.0 => v1.25.0

Signed-off-by: Ed Bartosh<EMAIL_ADDRESS>

Codecov Report

Merging #1131 (f61430f) into main (210252d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1131   +/-   ##
=======================================
  Coverage   52.96%   52.96%
=======================================
  Files          40       40
  Lines        4358     4358
=======================================
  Hits         2308     2308
  Misses       1923     1923
  Partials      127      127

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more