[BUG] Unable to create index pattern using all_access role

Describe the bug
I’m trying to create an index pattern on newly set up opensearch in k8s. Once I create it and get back to ‘Discover’ tab, there are no index patterns and opensearch suggest creating new one.
To Reproduce
Steps to reproduce the behavior:

Install opensearch and dashboards in k8s using helm charts;
Install fluent-bit to deliver logs to opensearch;
Login under ‘admin’ user with ‘all_access’ role;
Go to ‘Discover’ on WI and create a new pattern;
Pattern is created (screenshot attached);
Go back to ‘Discover’ and there are no index patterns;

Expected behavior
The index pattern is created and I can browse logs from 'Discover' tab.
Screenshots

Host/Environment (please complete the following information):
Environment: k8s v1.27.2
Opensearch/dashboards version: 2.11.0
Opensearch chart version: 2.16.1
Dashboards chart version: 2.14.0
Additional context

I created clusters previously and deleted them along with the disk volumes, so it should be a clean install, but may be this is somehow connected, because I can’t see other reason for such behavior.
Also if I go to ‘Saved Objects’ on 'Index patterns' page, I get the following error in the browser console:
   "message": "all shards failed: search_phase_execution_exception: [illegal_argument_exception] Reason: Text fields are not optimised for operations that require per-document field data like aggregations and sorting, so these operations are disabled by default. Please use a keyword field instead. Alternatively, set fielddata=true on [type] in order to load field data by uninverting the inverted index. Note that this can use significant memory."

Looks like a bug. Catch All Triage - 1 2 3 4 5


Black format

Isolating black changes for PR review. This PR changes only code style.

@CodyCBakerPhD this is going to cause a million merge conflicts with your other PRs. Maybe we should merge them first before doing this

@bendichter This was the very first change committed from master, and this branch already serves as the base for the others in this order: black_format -> update_setup -> update_imports -> add_petersen


fix: Fix issue https://github.com/kwado-tech/l10n_mapper/issues/25

Description

Please check the following boxes

[ ] Pull Request title is consistent with the implemented feature, fix etc.
[ ] I have followed proper descriptive code style and conventions
[ ] The code is self-documenting and has no unnecessary comments. I named the functions and variables to clearly describe their purpose.
[ ] I have added Unit Tests and coverage is 70%+
[ ] I have tested and verified this implementation and it works as expected

@kwado-tech hi . can you take a look on this pr ?
Im try to fix issue #25 in this commit

Hey @CaoGiaHieu-dev this pr does not clearly address the issue as there could be multiple cases of malformed translation keys and placeholders with case-format not compatible with darts file-generator.
Will push a fix to address the translation keys and placeholder as well

Ticket resolved in https://github.com/kwado-tech/l10n_mapper/pull/29


Organize Resource Deployment with Tiers

ClusterProfile/Profile instances let deploy add-ons and applications (Helm charts or Kubernetes resources) across a set of managed clusters.
Sometimes there might be a need to tweak deployments for specific clusters (a subset of the original group) within that group.
Previously, creating a new ClusterProfile/Profile targeting a subset of clusters with resources already managed by another profile resulted in conflicts. Sveltos wouldn't allow deployment for those resources.
The concept of tier is introduced to manage deployment priority for resources targeted by multiple configurations.
How it works:

Each ClusterProfile/Profile has a new property called tier.
This tier value controls the deployment order for resources targeting the same cluster element (e.g., a Kubernetes object or Helm chart).
By default, the first configuration to reach the cluster "wins" and deploys the resource.
Tiers override this behavior. When conflicts occur, the configuration with the lowest tier value takes precedence and deploys the resource. Higher tier values represent lower priority.
The default tier value is 100.

Benefits:

Finer control over resource deployment: Tiers allow you to fine-tune deployments within your cluster, especially when multiple configurations manage the same resources.
Conflict resolution: Tiers ensure predictable outcomes when multiple configurations target the same resource. The configuration with the most critical deployment (lowest tier) takes priority.

Fixes #305

Here is an example. All managed clusters have labels env:fv
Then a subset has label region:west and another subset region_east.
Initially deploy this ClusterProfile
apiVersion: config.projectsveltos.io/v1alpha1
kind: ClusterProfile
metadata:
  name: validation-and-monitoring
spec:
  clusterSelector: env=fv
  continueOnConflict: true
  helmCharts:
  - repositoryURL:    https://kyverno.github.io/kyverno/
    repositoryName:   kyverno
    chartName:        kyverno/kyverno
    chartVersion:     v3.1.1
    releaseName:      kyverno-latest
    releaseNamespace: kyverno
    helmChartAction:  Install
  - repositoryURL:    https://prometheus-community.github.io/helm-charts
    repositoryName:   prometheus-community
    chartName:        prometheus-community/prometheus
    chartVersion:     23.4.0
    releaseName:      prometheus
    releaseNamespace: prometheus
    helmChartAction:  Install
  - repositoryURL:    https://grafana.github.io/helm-charts
    repositoryName:   grafana
    chartName:        grafana/grafana
    chartVersion:     6.58.9
    releaseName:      grafana
    releaseNamespace: grafana
    helmChartAction:  Install

Prometheus, Grafana and Kyverno are deployed in all clusters.
If now we post this ClusterProfile selecting a subset of managed clusters (the one with region:west):
apiVersion: config.projectsveltos.io/v1alpha1
kind: ClusterProfile
metadata:
 name: kyverno
spec:
 clusterSelector: region=west
 helmCharts:
 - repositoryURL:    https://kyverno.github.io/kyverno/
   repositoryName:   kyverno
   chartName:        kyverno/kyverno
   chartVersion:     v3.1.4
   releaseName:      kyverno-latest
   releaseNamespace: kyverno
   helmChartAction:  Install

and error will be reported on this
status:
  dependencies: no dependencies
  featureSummaries:
  - failureMessage: cannot manage chart kyverno/kyverno-latest. ClusterSummary validation-and-monitoring-capi-clusterapi-workload
      managing it
    featureID: Helm

With this PR though now we can simply set Tier behaviour. Setting Tier to 50 (so lower than Tier default value of 100) will allow kyverno ClusterProfile to win the conflict and so Kyverno gets upgraded to 3.1.4 only in the region:west clusters
apiVersion: config.projectsveltos.io/v1alpha1
kind: ClusterProfile
metadata:
  name: kyverno
spec:
  tier: 50
  clusterSelector: region=west
  helmCharts:
  - repositoryURL:    https://kyverno.github.io/kyverno/
    repositoryName:   kyverno
    chartName:        kyverno/kyverno
    chartVersion:     v3.1.4
    releaseName:      kyverno-latest
    releaseNamespace: kyverno
    helmChartAction:  Install

+-----------------------------+---------------+------------+----------------+---------+--------------------------------+------------------------------------------+
|           CLUSTER           | RESOURCE TYPE | NAMESPACE  |      NAME      | VERSION |              TIME              |                 PROFILES                 |
+-----------------------------+---------------+------------+----------------+---------+--------------------------------+------------------------------------------+
| default/clusterapi-workload | helm chart    | prometheus | prometheus     | 23.4.0  | 2024-05-14 12:48:20 +0200 CEST | ClusterProfile/validation-and-monitoring |
| default/clusterapi-workload | helm chart    | grafana    | grafana        | 6.58.9  | 2024-05-14 12:48:31 +0200 CEST | ClusterProfile/validation-and-monitoring |
| default/clusterapi-workload | helm chart    | kyverno    | kyverno-latest | 3.1.4   | 2024-05-14 13:01:55 +0200 CEST | ClusterProfile/kyverno                   |
+-----------------------------+---------------+------------+----------------+---------+--------------------------------+------------------------------------------+

Very helpful feature for operations. Thanks @gianlucam76!


Video flickering

Hello everyone,
When video starts, there is a constant flickering no matter in which state the video window is.
I have tried a few hacks such as : http://stackoverflow.com/a/27307286/1374065 but without success.
Here (http://stackoverflow.com/questions/25322660/youtube-android-fragment-flickering) is a problem with flickering , but it lasts less than a half of a second (not my case).
Does anybody have this problem or I am the only one?
Thank you.

I think it is because of you are using SurfaceView. Use TextureView instead of it. Problem should go away and never return back :).

Yeap @Shuhrat-java is right.


add README.md to Cargo.toml in order for crates.io to have a nice README preview

Currently the crates.io page only shows the description from Cargo.toml, see: https://crates.io/crates/spidev
If you add readme = "README.md" it will show the README including the code example. This will attract more users to use this crate.

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nastevens (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
Please see the contribution instructions for more information.

bors r+


Cluster permissions missing critical details

https://docs.microsoft.com/en-us/azure/azure-monitor/logs/logs-dedicated-clusters#management
In section "Management" where it says:
All operations on the cluster level require the Microsoft.OperationalInsights/clusters/write action permission on the cluster.
This is not accurate since, for example, when linking the workspace to the cluster, you also need LinkedServices permissions.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 336076fa-b185-2d98-7b5c-75b6540c99e7
Version Independent ID: b1728f53-57c5-273b-8d75-29cd781f1a56
Content: Azure Monitor Logs Dedicated Clusters - Azure Monitor
Content Source: articles/azure-monitor/logs/logs-dedicated-clusters.md
Service: azure-monitor
Sub-service: logs
GitHub Login: @yossi-y
Microsoft Alias: yossiy

Thanks for the feedback! We are currently investigating and will update you shortly.

Thanks for your feedback.
Although the needed permissions are mentioned under Link workspaces, you are correct that it's not reflected properly in Management  paragraph and clarification was submitted and will be published shortly.
Thanks,

@yossi-y - Thanks for providing your insights and raising the PR.
@damarce135 - Thanks again for bringing this to our attention. We have updated the Doc and it will be live once its merged.  We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


Add X-source

added X-source to query calls.

@ofermend Can you please update the PR description to provide some background?


ADBDEV-6260: Fix GUC sync leaving broken temp tables

Fix GUC sync leaving broken temp tables
Before this patch, if an error happened during GUC sync (for example a segment
was disconnected) the gang was destroyed but the session wasn't reset, so
temporary tables weren't cleaned up. This left a temporary table left on
coordinator, but not on segments, resulting in segment errors. This patch
fixes this by enabling session reset for errors during GUC syncs.

Allure report https://allure.adsw.io/launch/80068

Failed job Regression tests with Postgres on x86_64: https://gitlab.adsw.io/arenadata/github_mirroring/gpdb/-/jobs/1901729

Failed job Regression tests with ORCA on x86_64: https://gitlab.adsw.io/arenadata/github_mirroring/gpdb/-/jobs/1901730

Failed job Regression tests with Postgres on x86_64: https://gitlab.adsw.io/arenadata/github_mirroring/gpdb/-/jobs/1902873

Allure report https://allure.adsw.io/launch/80088

Allure report https://allure.adsw.io/launch/81094

Failed job Behave tests on x86_64: https://gitlab.adsw.io/arenadata/github_mirroring/gpdb/-/jobs/2000589


fix(website): update links and package names for plugins we migrated from janus-idp to community-plugins

Hey, I just made a Pull Request!
This updates a bunch of plugin entries on https://backstage.io/plugins/ from Janus-IDP to Backstage community plugins after we (Red Hat) migrated these plugins and deprecated the old links.
I'll keep that as a draft until I've checked whether we want to link the READMEs on GitHub or any other publicly available documentation.
I confirmed with our team/pm that the READMEs in Backstage community plugins are fine for now.
:heavy_check_mark: Checklist

[ ] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

@Rugvip thanks for review. I confirmed with our team/pm that the READMEs in Backstage community plugins are fine for now.

@Rugvip, thanks for approving it, but what's next or missing? Do you want merge it or will someone else take a look?

Sorry @Rugvip @freben, I know you are all busy, but can you merge this?

Sorry for the delay! :tada:


window.prompt or prompt doesn't work in nativefier

i build a website to desktop app this is the link of the example website :
https://www.javatpoint.com/oprweb/test.jsp?filename=javascript-prompt-dialog-box2
The website with the browser shows the prompt box but in nativier no
Here is the picture in browser :

and here is the picture in nativier

the alert and confirm works good only prompt/window.prompt method

i build a website to desktop app this is the link of the example website :
https://www.javatpoint.com/oprweb/test.jsp?filename=javascript-prompt-dialog-box2
The website with the browser shows the prompt box but in nativefier no
Here is the picture in browser :

and here is the picture in nativefier

You can test JavaScript prompt method and you will see the problem , the prompt box don't show up
the alert and confirm works good only prompt/window.prompt method

i build a website to desktop app this is the link of the example website :
https://www.javatpoint.com/oprweb/test.jsp?filename=javascript-prompt-dialog-box2
The website with the browser shows the prompt box but in nativefier no
Here is the picture in browser :

and here is the picture in nativefier

You can test JavaScript prompt method and you will see the problem , the prompt box don't show up
the alert and confirm works good only prompt/window.prompt method

Because Nativefier is based on Electron, we are limited by the functionality the expose and allow.
In this case Electron has made the decision that window.prompt is more harm than good and have stated that it will never be supported. Sorry.
https://github.com/electron/electron/issues/472
Closing this as there's nothing we can do about it, but I'm not happy to be doing it.
Best I can say is if you have control over the site being passed to Nativefier, then avoid using window.prompt and instead use some sort of javascript pseudo-prompt such as http://bootboxjs.com/examples.html#bb-prompt


chore: if the bool field is null set the inlined boolean as null

for hollow inline, we want to keep the concept of null like we do for the other ones. it's not 100% backwards compatible, but since this is only used within RH we can see how safe it is based on usage. ideally, we patch this before broader usage appears

i addressed the existing usage that this change would have broken. i will land this next week.


Cannot be able to get Metric List

I cannot be able to get a List of Metrics to be fetch via Python SDK.
This is the reference code i am following.
https://github.com/Azure-Samples/azure-samples-python-management/blob/main/samples/monitor/manage_metric_list.py
When running this code i am getting an error
File "/getRMetricsInfo.py", line 50, in
main()
File "/getRMetricsInfo.py", line 33, in main
result = monitor_client.metrics.list(
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/lib/python3.11/site-packages/azure/core/tracing/decorator.py", line 105, in wrapper_use_tracer
return func(*args, **kwargs)
/lib/python3.11/site-packages/azure/mgmt/monitor/v2018_01_01/operations/_metrics_operations.py", line 218, in list
raise HttpResponseError(response=response, model=error, error_format=ARMErrorFormat)
azure.core.exceptions.HttpResponseError: Operation returned an invalid status 'Not Implemented'

Hi @mashirali, it must be the error message in the response content, could you share it as well?
For now, I can only guess you're trying to get the UsedCapacity of a storage account, and by the reference , this metric does not support any dimension, so you should not pass the parameter filter with any value to send a vaild request.


The Unofficial Hollow Knight RPG (Beta Update #1, bugfixes and new features)

Submission Checklist
Required

[x] The pull request title clearly contains the name of the sheet I am editing.
[x] The pull request title clearly states the type of change I am submitting (New Sheet/New Feature/Bugfix/etc.).
[x] The pull request makes changes to files in only one sub-folder.
[x] The pull request does not contain changes to any json files in the translations folder (translation.json is permitted)

New Sheet Details

The name of this game is: < The Unofficial Hollow Knight RPG >  (i.e. Dungeons & Dragons 5th Edition, The Dresden Files RPG)

The publisher of this game is: < The HKRPG Team > (i.e. Wizards of the Coast, Evil Hat)

The name of this game system/family is: < The Unofficial Hollow Knight RPG > (i.e. Dungeons & Dragons, FATE)

[x] I have followed the Character Sheets Standards when building this sheet.

[x] This sheet has been made on behalf of, or by, the game's publisher.
[x] This game is not a traditionally published game, but a copy of the game rules can be purchased/downloaded/found at: < https://hkrpg-team.itch.io/hollow-knight-rpg >
[x] This sheet is for an unofficial fan game, modification to an existing game, or a homebrew system.

Changes / Description
<This is beta test update #1 for the Unofficial HK RPG I've been working on over the last 2 months. Page 1 has been fully developed, with most bugs and features I missed accounted for. Note to the Roll20 team, the name of the sheet has changed a little; please use the name listed in this Pull Request Template, not the name it currently has on Roll20.>

Character Sheet Info Roll20 Internal Use only.

Here's the changes and fixes:
Additions:

Durability being set to 0 for Shell Absorption or worn Armor will remove protection effects given by that armor (including additional soak rolls/rerolls) (this means you’ll need to set durability of your shell to a non-zero number for absorption to work, even if it doesn’t use durability).
Added “+Belt” and “+Footwork” to Modifiers Page
Added “+Parry Dice (Weapon Specific)”  and “+Parry Dice (Shield Specific)”
Added Shield Bashes, including a working “Balanced” option on the modifiers page.
Reroll modifiers for Soak, Cute, Spook, Might Shell Insight or Grace based rolls, and like just a whole bunch of stuff.
Custom success threshold for Soak rolls.
Added an “End Turn” button
Added Status Effect counters, which automatically decrease when clicking “End Turn”.

Fixes:

Fixed glitch where soaking with soft body would initiate a reroll if shell had a “.5”, which shouldn’t happen when soft body is active.
Fixed “Calculated Damage” math so rollover damage cap increases if dedicated stamina of your last attack is higher than your equipped weapon’s damage.
Removed arrows from number inputs where unnecessary, due to some computers causing overlapping of text
Minor spacing and formatting changes
“Attack Roll Toggle” now switched to ‘Melee’ and ‘Ranged’. Modifiers page allows you to choose what attribute is used for your Melee and Ranged attacks.
Stamina Tax resets when clicking “End Turn”
Paralysis SE ticks down when clicking “End Turn”


Fixes reported on #15

Fixed the issues mentioned on #15:

Moved bassets to storage by default
Fixed file location and public paths
Allowed to set the output as the file path
Merged main branch.

Thanks @promatik ! I'm still getting the assets localized in bad places though... Look how the assets paths are being created here, see where I added the dump()s and dd():

In the end, for me, the first asset gets stored in<EMAIL_ADDRESS>which is unexpected... what I expected was:
<EMAIL_ADDRESS><EMAIL_ADDRESS>
This seems to be a relative vs absolute path problem. The weird thing is... why are YOU not getting the same problem? Is it a difference between Unix and Windows? Are you able to fix this or should I figure it out?
Thanks!

Fixed @tabacitu 👌
The issue was indeed with win/unix filesystem, from now on I'm testing stuff with WSL — Windows Subsystem for Linux 😅

We've decided to do this:
@basset('https://domain.com/operations/reorder.js') // if HTTPS, then internalize
@basset(base_path('resources/operations/reorder.js')) // if absolute path, then internalize
@basset(resource_path('operations/reorder.js')) // if absolute path, then internalize
@basset(public_path('operations/reorder.js')) // if public_path, then do not internalize
@basset('operations/reorder.js') // if simple string, assume it's a public path

Let's also do:
@bassetBlock('unique_name_for_code_block.js')
    <!-- Your JS here -->
@bassetBlock

@bassetBlock('unique_name_for_code_block.css')
    <!-- Your CSS here -->
@endBassetBlock


[Feature] using useSWR (react hook) to fetch data

Description
Use of useSWR:
We can consider using useSWR for fetching the data in this case. useSWR is a React hook for data fetching that simplifies the process and handles caching, revalidation, and error handling out of the box. It can improve the performance by caching the data on the client-side and automatically updating it when needed.
Reference: https://swr.vercel.app/

To use in contributors.tsx

Screenshots
No response
Checklist

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[X] I am willing to work on this issue (optional)
[X] I am a GSSoC'23 contributor

@Anmol-Baranwal why we would use it exactly?

@Anmol-Baranwal why we would use it exactly?

The primary goal of useSWR is to provide a better user experience by optimizing the way data is fetched, cached, and updated in the application through sophisticated built-in techniques. I have also provided a reference.

@k-deepak04 what do you think about it?

Closing this. Present one works fine, and we will use this when there is a proper backend.


FCM click_action support or any other way to send data to closed app

Expected Behaviour
Open application and receive data sent with the notification with push.on('notification'...).
See also: https://firebase.google.com/docs/notifications/android/console-device#receive_and_handle_messages
Actual Behaviour
Without click_action in the message, the application is opened, but function registered with push.on('notification', function(data) {...}) is not called.
With "click_action":"FCM_PLUGIN_ACTIVITY" the application is not opened.
Reproduce Scenario (including but not limited to)
Steps to Reproduce

Send notification like below (with required Authorization and Content-Type headers).
Click on notification.

Platform and Version (eg. Android 5.0 or iOS 9.2.1)
Android 6.0.1
(Android) What device vendor (e.g. Samsung, HTC, Sony...)
Sony Xperia Z5 Compact
Cordova CLI version and cordova platform version
PGB: <preference name="phonegap-version" value="cli-6.0.0" />
Plugin version
    <preference name="android-build-tool" value="gradle" />
    <plugin name="phonegap-plugin-push" source="git"
        spec="https://github.com/phonegap/phonegap-plugin-push#07fa81b7a3a62400915ac70b9a24a802465a6f95">
        <param name="SENDER_ID" value="..." />
    </plugin>

Sample Push Data Payload
{
    "notification":{
        "title":"Notification title",
        "body":"Notification body",
        "click_action":"FCM_PLUGIN_ACTIVITY",
    },
    "data":{
        "param1":"value1",
        "param2":"value2"
    },
    "priority":"high",
}

Sample Code that illustrates the problem
Code used in application (I run this from Chrome's remote console when the app is loaded): push.zip
Micro-server implementation in Node.js: fcm-server.zip

@Eccenux what you describe makes sense as expected behaviour. If you specify  "click_action":"FCM_PLUGIN_ACTIVITY" then the OS will try to start the activity FCM_PLUGIN_ACTIVITY which probably doesn't exist in this case.
Instead try sending this payload:
{
    "data":{
        "title":"Notification title",
        "body":"Notification body",
        "param1":"value1",
        "param2":"value2"
    },
    "priority":"high",
}

and let me know if that fixes the issue.

Strange. When anything is set in notification it doesn't work in background, but when I remove all information then notification data is received in background.
i.e. this doesn't work:
{
	"notification":{
		"sound":"default"
	},
	"data":{
		"title":"Notification title",
		"body":"Notification body",
		"param1":"value1",
		"param2":"value2"
	},
	"priority":"high",
	"content_available": true
}

This works:
{
	"notification":{
	},
	"data":{
		"title":"Notification title",
		"body":"Notification body",
		"param1":"value1",
		"param2":"value2"
	},
	"priority":"high",
	"content_available": true
}

So seems like every notification should be sent twice currently... Not that good.
click_action description for Android in FCM docs:

Indicates the action associated with a user click on the notification. When this is set, an activity with a matching intent filter is launched when user clicks the notification.

@Eccenux why do you think the notification needs to be sent twice? But yes, when sending to an Android device your payload must be in data that is well discussed elsewhere in this repo.

I have to use notification to supply additional options (sound, icon...), so I need to send two notifications -- one with options for foreground apps and one for background apps. Or can those be defined differently?

Where exactly do the data-only notification payload fail for you? It is(or maybe was) known to us up until this point that the data-only variant is what works for everything as much as possible. If it's failing in some case, we should fix that case then.

From the FCM docs I though I was supposed to use notification for icons and such... I see examples for this plugin differ... So I guess I need to do more testing.

I need a notification with click_action, but in cordova, where is name of activity?
I want to do the following:
......
notification":{
"title":"Notification title",
"body":"Notification body",
"click_action":"hello.html",
},

....
Is it possible??
Thank you

@Eccenux Yeah !!! Thanks. Since few days I am looking for what my notifications doesn't work good, in my case :

White icon
No redirection when tapped

Your message was very helpful, I just deleted the content in notification, and put everything in "data", now it works, and I don't need to specify any logo. Thanks a lot :)
Like that :
{     "to":"ID-TO-PUSH",     "notification":{     },     "data":{         "title":"Notification title",         "body":"Notification body",         "click_action":"FCM_PLUGIN_ACTIVITY"     },     "priority":"high",     "content_available": true }

@AdrienV Can you tell us how the documentation at https://github.com/phonegap/phonegap-plugin-push/blob/master/docs/PAYLOAD.md#notification-vs-data-payloads wasn't enough for you? If you had to find an old issue and use it as a solution, it's an indication that the docs are not as clear as it should.


feat: paginiation footer utils

Adds some more util functions shared by the pagination footer component and sn-table

:tada: This PR is included in version 2.2.0 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:


Model Monitoring Plot: Inconsistency between Paper and GitHub

Hello,
in your paper 'Explainable AI for Trees: From Local Explanations to Global Understanding' you presented in section 2.7.4 and Method 17 the SHAP monitoring plot as a tool to decompose the loss among the features. In figure 5 you plot 'SHAP loss values' on the y axis where a positive value means the feature increased the loss and the a negative value means the feature helped to improve the model, if I got you right. But the current monitoring plot on GitHub only plots the regular SHAP values on the y axis, as far as I understood it. So with this plot you can see whether the effect of the feature on the output changes over time, which indicates a change on it's impact on the loss, too, but you cannot directly see it's effect on the loss as described in the paper.
How do you compute 'SHAP loss values'  or how can I use the monitoring plot as proposed in this paper? Or is there a misunderstanding from my part? (I'm aware that the current version of this plot is preliminary)

Hey! The monitoring plot will plot any explanations you like over time. In the paper we plot explanations of the loss of the model's output and not just the output. To do that:
explainer = shap.TreeExplainer(model, background, feature_dependence="independent", model_output="logloss")
shap_values = explainer.shap_values(X)
shap.monitoring_plot(feature_index_you_want_to_plot, shap_values, X)

Okay, cool. Thanks a lot!


How to plot masks of maskrcnn?

Hello,
Does someone know how to plot masks of maskrcnn? In the output of maskrcnn_inference in roi_heads.py mask_logits pass through sigmoid to become mask_probs and its output_size is generally very small to correctly see anything (28*28 by default, which is defined in the roi_align parameters). I tried to binarize this mask_probs using cv2.threshold (with threshold value equals to np.median of mask_probs) then convert to polygon with cv2.findcontours and finally resize it in the image shape but the results are not good.
Thanks

could you solve this issue? I'm facing similar issues with masks

Hi,
We added a new function draw_segmentation_masks in https://github.com/pytorch/vision/blob/c2ab0c59f42babf9ad01aa616cd8a901daac86dd/torchvision/utils.py#L228-L252 which can be used to plot the segmentation masks of segmentation models (including Mask R-CNN).
I believe I've answered your question, and as such I'm closing this issue, but let us know if you have further questions


Allow installation of FOSCKEditorBundle ^2.0

Q
A

Bug fix?
no

New feature?
not really

BC breaks?
dont think so looking at release notes of bundle

Deprecations?
no

License
MIT

Hi @bitbager . Did the update to CkEditor 2.0 is on  the roadmap ?
Thanks

we'll add in the next release


Include attribution and license in results

Since addok is datasource-agnostic, it may be a good idea in my opinion to include attribution and possibly the license into the result JSON. I'm thinking that if you find an addok instance in the wild, or even parallel instances of addok with different data for various needs (FANTOIR...), it ensures you know the origin and how to handle it. Maybe it could even be included in the GeocodeJSON spec.
Maybe something as trivial as two optional keys in the config file is enough; then we'd add them at the root of the JSON result.

Good point :)
I'm just wondering if we'll not find the case where attribution and licence are different per result, for example mixing Open Licence and ODBL data in the same instance :s

Yeah, that will probably happen one day :)
We could add it at the single result level; and when importing BANO, Nominatim, or other sources, it could a single value hardcoded in the specific importer, and later a command-line option if we have a generic importer; the license and attribution would be added to each imported address.
I'm a bit worried about the impact on the size of the index though?
As a first step we also could just add the two keys in the configuration, and add them to each result on the fly; the day we need to be smarter, at least the result format won't change. It probably makes sense.

Yep, let do something like this:

keep the attribution on the root of the results GeoJSON
(optionally) add the source of the data of each documents
and make that the attribution can be a dict like source1: attribution, source2: attribution (so we only add the source key to the document in the index)


rendering took too long?

Hello, first of all thanks for the great code! In my storyboard, I get the error error: IB Designables: Failed to render instance of DLRadioButton: Rendering the view took longer than 200 ms. Your drawing code may suffer from slow performance. The app runs but the red error is always there. Is anything affecting performance, and any way to get rid of this error? Thanks again!

Thx for reporting, will take a look in this weekend.

I met this problem too. The interesting thing is that I do noting and it gone. If you find the problem, please tell me too. Thanks for you work.

I had this issue intermittently a while ago, it seems to resolve itself after building the project. I couldn't reproduce it on my Mac. Can anyone of you consistently reproduce it?

The problem went away for now, definitely seems to come and go. Well, I'll post if any more info on my end, but looks ok for now. Thanks again!!


Symmetric multi-processing (SMP) support

Multi CPU support using platform appropriate primitives for parallel computing, such as web workers in the browser, or worker-threads in Node.

That would require a powerful setup

That would require a powerful setup

On the contrary, it should be feasible to emulate a multi-core CPU with SharedArrayBuffer, web workers/threads, and isolating state like the instruction pointer. Not sure how that looks yet with the jitter, whether multiple emulated CPUs could share a single instance, or if each CPU needs its own.

I'm not opposed to having SMP (especially in the form of a user-contributed PR), and it has been shown to be feasible by jor1k and others.
That said, I'd like to improve single-core performance first, since v86 is still fairly slow in that regard (compared to e.g. qemu-tcg).

@copy I'm quite interested in improving performance, do you have any insight as to where to start?

@copy I'm quite interested in improving performance, do you have any insight as to where to start?

Generally, find some OS and/or program you'd like to make run faster, profile it (https://profiler.firefox.com/docs/ for a sampling profiler, make debug-with-profiler has produces stats at the bottom of debug.html (but runs much slower)).
You can also inspect the wasm (and the x86 asm) that v86 generates in dev tools or by changing this flag: https://github.com/copy/v86/blob/35f1f83/src/cpu.js#L1254
Some concrete ideas:

Picking up https://github.com/copy/v86/pull/466. Generally, extending instruction analysis to record which instructions read or write registers and flags, which enables several optimisations like omitting flag generation (as in the aforementioned PR) and optimising cmp+jmp more often. Needs better fuzzing, which I'm working on.
Detecting function boundaries would enable improving control flow. At the moment all function entries and labels (switch targets/goto) are in a single big br_table, which wasm jits aren't too happy about. This would also allow optimising call/ret into wasm calls (with some checks at runtime that the eip on the stack matches the expected return value; and a callstack limit).
Optimising vga memory writes using the existing memory fast path (e.g., allow using the fast path if the page is already marked dirty). See https://github.com/copy/v86/issues/301#issuecomment-1703971315
Running cpu emulation in a worker (#534, #219)
Port pic+apic to Rust. Allows running more of the main loop in Rust (fewer switches between Rust/JS), and possibly some optimisations around mmio
Optimise access to stack memory. If the size of stack access (ESP) can be determined statically, then ESP only needs to be translated to physical once. Needs a fallback to slow path if the access crosses a page.


[web]TextFormField, SelectableText Highlight Won't Work for RTL, Flutter Channel Master Flutter 1.26.0-8.0.pre

I'm using flutter web with FVM flutter channel Master Flutter 1.26.0-8.0.pre.
I'm facing an issue with highlighting TextFormField and SelectableText from Right To Left.
TextFormField:  It will display the highlight but when it will not replace  the highlighted word, instead it positions the cursor the the left of the highlight and start inserting my keyboard input.
SelectableText :  It will display the highlight but copy is not working when the highlight is done from Right to Left .
Everything works fine for Left to Right Highlight

@yizenlim
What is FVM ? Your flutter version seem to be old. Can you upgrade to latest and try again to see if issue persists or not ?
If yes, provide updated flutter doctor -v and a minimal complete reproducible code sample that shows the issue.
Thanks.

Without additional information, we are unfortunately not sure how to resolve this issue.
We are therefore reluctantly going to close this bug for now.
Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.
Could everyone who still has this problem please file a new issue with the exact description of what happens, logs, and the output of flutter doctor -v.
All system setups can be slightly different, so it's always better to open new issues and reference related issues.


Replace internal usages of 'master' term in 'server/src/internalClusterTest' directory

Description

Replace the non-inclusive terminology "master" with "cluster manager" in code comments, internal variable/method/class names, in server/src/internalClusterTest  directory.
Backwards compatibility is not impacted.
The PR is split from https://github.com/opensearch-project/OpenSearch/pull/2150

Replacement rules:

master -> cluster_manager or clusterManager (variable name) or cluster-manager (code comment)
Master -> ClusterManager

Issues Resolved
A part of #1548
Check List

[ ] New functionality includes testing.

[x] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Looks like some changes are in order here. Going to leave this open and we may just need to backport to 2x after the branching.

Hi @nknize, thanks for taking care of this PR. No problem, I will create backport PR to 2.x, and I will keep the impact of this PR within this repository.

start gradle check

start gradle check

In log 5343:
REPRODUCE WITH: ./gradlew ':qa:remote-clusters:integTest' --tests "org.opensearch.cluster.remote.test.RemoteClustersIT.testHAProxyModeConnectionWorks" -Dtests.seed=D7E3D9B3F65AE94F -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=es-PY -Dtests.timezone=Africa/Gaborone -Druntime.java=17

WARNING: Please consider reporting this to the maintainers of org.gradle.api.internal.tasks.testing.worker.TestWorker
WARNING: System::setSecurityManager will be removed in a future release

org.opensearch.cluster.remote.test.RemoteClustersIT > testHAProxyModeConnectionWorks FAILED
    java.lang.AssertionError
        at __randomizedtesting.SeedInfo.seed([D7E3D9B3F65AE94F:D0950C78CDDC9F12]:0)
        at org.junit.Assert.fail(Assert.java:87)
        at org.junit.Assert.assertTrue(Assert.java:42)
        at org.junit.Assert.assertTrue(Assert.java:53)
        at org.opensearch.cluster.remote.test.RemoteClustersIT.testHAProxyModeConnectionWorks(RemoteClustersIT.java:125)

It's reported in #1703 re-run: start gradle check.

In log 5390:
> Task :qa:remote-clusters:integTest

REPRODUCE WITH: ./gradlew ':qa:remote-clusters:integTest' --tests "org.opensearch.cluster.remote.test.RemoteClustersIT.testHAProxyModeConnectionWorks" -Dtests.seed=C884FF6591BB100B -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=ar-KW -Dtests.timezone=America/Metlakatla -Druntime.java=17

org.opensearch.cluster.remote.test.RemoteClustersIT > testHAProxyModeConnectionWorks FAILED
    java.lang.AssertionError
        at __randomizedtesting.SeedInfo.seed([C884FF6591BB100B:CFF22AAEAA3D6656]:0)
        at org.junit.Assert.fail(Assert.java:87)
        at org.junit.Assert.assertTrue(Assert.java:42)
        at org.junit.Assert.assertTrue(Assert.java:53)
        at org.opensearch.cluster.remote.test.RemoteClustersIT.testHAProxyModeConnectionWorks(RemoteClustersIT.java:125)

It's reported in issue #1703 .
re-run: start gradle check


As a user, I want to have multiple groups of keywords that are styled independently

Options page: WIP


remove tiflash download url

Since we have tiflash download on tiup, it seems no longer need to separate url to download tiflash
Signed-off-by: Qiang Zhou<EMAIL_ADDRESS>

conflict and the changed file was deleted, close it.


Fix tvplace search ordering

If tv_featured was absent the ordering was unstable. To fix it, sort by relevancy or by reviewed date depending on the query, and make sure to handle missing tv_featured value.

r+


Can compile plugin, but it fails to load

Cloned OSVR-Core repository.

Installed CMake 3.9.0-rc3.

Downloaded OSVR-Core-Snapshot-v0.6-2080-g8a0429a4-build282-vs12-64bit and run add_sdk_to_registry.cmd

Installed OSVR-Runtime-v0.6-2080-g8a0429a4-build377-win-64bit

Downloaded  boost_1_64_0-msvc-14.1-64 and installed

Went to OSVR-Core/examples/plugin/selfcontained

D:\develop\OSVR-Core\examples\plugin\selfcontained>mkdir build
D:\develop\OSVR-Core\examples\plugin\selfcontained>cd build
D:\develop\OSVR-Core\examples\plugin\selfcontained\build>cmake -G "Visual Studio 14 2015 Win64" ..
-- The C compiler identification is MSVC 19.0.24215.1
-- The CXX compiler identification is MSVC 19.0.24215.1
-- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio 14.0/VC/bin/x86_amd64/cl.exe
-- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio 14.0/VC/bin/x86_amd64/cl.exe -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio 14.0/VC/bin/x86_amd64/cl.exe
-- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio 14.0/VC/bin/x86_amd64/cl.exe -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info
- done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Configuring done
-- Generating done
-- Build files have been written to: D:/develop/OSVR-Core/examples/plugin/selfcontained/build`

Opened .sln in build with Visual Studio 2015 and builded it.

1>------ Build started: Project: ZERO_CHECK, Configuration: Release x64 ------
1>  Checking Build System
1>  CMake does not need to re-run because D:/develop/OSVR-Core/examples/plugin/selfcontained/build/CMakeFiles/generate.stamp is up-to-date.
2>------ Build started: Project: com_osvr_example_selfcontained, Configuration: Release x64 ------
2>  Building Custom Rule D:/develop/OSVR-Core/examples/plugin/selfcontained/CMakeLists.txt
2>  CMake does not need to re-run because D:/develop/OSVR-Core/examples/plugin/selfcontained/build/CMakeFiles/generate.stamp is up-to-date.
2>  [osvr_convert_json] Generating string literal header from com_osvr_example_selfcontained.json
2>  com_osvr_example_selfcontained.cpp
2>     Creating library D:/develop/OSVR-Core/examples/plugin/selfcontained/build/Release/com_osvr_example_selfcontained.lib and object D:/develop/OSVR-Core/examples/plugin/selfcontained/build/Release/com_osvr_example_selfcontained.exp
2>  com_osvr_example_selfcontained.vcxproj -> D:\develop\OSVR-Core\examples\plugin\selfcontained\build\bin\osvr-plugins-0\Release\com_osvr_example_selfcontained.dll
3>------ Build started: Project: ALL_BUILD, Configuration: Release x64 ------
3>  Building Custom Rule D:/develop/OSVR-Core/examples/plugin/selfcontained/CMakeLists.txt
3>  CMake does not need to re-run because D:/develop/OSVR-Core/examples/plugin/selfcontained/build/CMakeFiles/generate.stamp is up-to-date.
========== Build: 3 succeeded, 0 failed, 0 up-to-date, 0 skipped ==========

Copied com_osvr_example_selfcontained.dll from build\bin\osvr-plugins-0\Release and pasted it in OSVR\Runtime\bin
Started osvr_server.exe and it failed to load plugin:

June 23 08:44:29.382 info [OSVR]: Logging for C:\Program Files\OSVR\Runtime\bin\osvr_server.exe
June 23 08:44:29.382 info [OSVR Server]: Using default config file - pass a filename on the command line to use a different one.
June 23 08:44:29.382 info [OSVR Server]: Attempting to load config file 'osvr_server_config.json'.
June 23 08:44:29.382 info [OSVR Server]: Constructing server as configured...
June 23 08:44:29.397 info [OSVR Server]: Loading auto-loadable plugins...
June 23 08:44:29.413 warning [PluginHost]: Failed to load plugin com_osvr_example_selfcontained: Failed to load the module C:/Program Files/OSVR/Runtime/bin/osvr-plugins-0/com_osvr_example_selfcontained
June 23 08:44:29.429 info [OSVR Server]: Loading plugins...
June 23 08:44:29.429 info [OSVR Server]: Instantiating configured drivers...

Hi @ArslanGapizov ,
It looks like the plugin is not loading because you're building the plugin with VS 2015 against OSVR-Core that was built with VS 2013. I would either build it VS 2013 against the same SDK, or build entire OSVR-Core with VS 2015 and then you can use it to build all new plugins.
Let me know if you have have any more questions.
-Georgiy

Thanks for reply, it works. Also I had to change "Release" build to "RelWithDebInfo".

It's actually just the config (release vs relwithdebinfo) not the version of VS that's the issue here, FWIW. Thanks for finding this - I just re-found it yesterday, sorry I hadn't seen your issue earlier.


Problem with get forms function

Hi,
I am trying to get some data from Typeform into Python using the API Wrapper.
import typeform
client = Client('mykeyhere')
myforms = client.get_forms()

But then it gives an error in the parse object:
File "/Users/nick/anaconda3/lib/python3.6/site-packages/typeform/client.py", line 54, in _parse
raise exception.Forbidden(message)
UnboundLocalError: local variable 'message' referenced before assignment
Any suggestions?

This is indeed an error with our code. We applied a quick fix with this commit 8dc9aea.
With this you should be able to see the complete error response.
Anyways, your problem seems to be an access issue. Please double check your credentials.
Hope this helps.

Hi,
This function also gives an error for me (using Authorized Access):
from typeform.client import Client client = Client('TOKEN') client.get_forms()
Output:
Traceback (most recent call last):
File "", line 1, in
File "/home/ajfaure/.virtualenvs/django2/lib/python3.6/site-packages/typeform/client.py", line 147, in get_forms
return self._get(endpoint='forms').json()
File "/home/ajfaure/.virtualenvs/django2/lib/python3.6/site-packages/typeform/client.py", line 26, in _get
return self._request('GET', endpoint, data=data, params=params)
File "/home/ajfaure/.virtualenvs/django2/lib/python3.6/site-packages/typeform/client.py", line 39, in _request
return self._parse(response)
File "/home/ajfaure/.virtualenvs/django2/lib/python3.6/site-packages/typeform/client.py", line 61, in _parse
raise exception.Forbidden(message)
typeform.exception.Forbidden: {'message': 'please provide a valid key', 'status': 403}
Any idea how to fix this?
Thanks,
Andre

Hello,
I've updated this library to version 0.2.0, that means your issue is now fixed.
Please read the changes at https://github.com/GearPlug/typeform-python/releases/tag/v0.2.0
Remember to read the updated README.md
If you have any other issue/question, don't hesitate to open a new issue.


Docker-Compose - Can't find interfaces

Error: fatal msg="Could not get interface: route ip+net: no such network interface\n"
interface = "zt7nnjn3xu" list in .ztdns.toml in the root directory of the git repo
I can start the service using the pre-compiled executable with the same config file and have no problems.
Running this on CentOS 7 as root.

Same thing here...

It seems that the error is raised because by default the containerized daemon doesn't have access to any of the zerotier interfaces of the host machine.
It's possible to solve the issue by commenting out the interface section in zerotier config, so the daemon is bound to all interfaces inside the container, and configure some port forwarding in compose file instead:
version: '3'
services:
  ztdns:
    build: .
    ports:
     - "<IP_ADDRESS>:5356:53/udp"
    volumes:
     - .ztdns.toml:/app/.ztdns.toml

Changing the interface from zt0 to eth0 worked for me. eth0 is the default interface name in alpine.


v0.96.7 - Hotfix - Object inits improvements

Q
A

Bug fix?
yes

New feature?
yes

Needs wipe?
no

Fixed issues
-

Description:
Improvements for object inits. Added support for resource crates and units. To make handling of units initialization easier creation of units managed by liberation Kill-Tracker was moved into separate dedicated function
Content:

[x] Object inits support for resource crates
[x] F_createManagedUnit function
[x] createUnit usage replaced with F_createManagedUnit where applicable
[x] Support for inheritance in KP_objectInits, 3rd argument, optional for BWC

Successfully tested on:

[x] Local MP
[ ] Dedicated MP

Compatibility checked with:

None

Reviewed so far.
Want to do a small test for the inheritance construct, if there is a nicer way via apply or similar.
And I'll give it a playtest on our weekly session today.

I could add adding caching of the inits in some namespace. That would make it a lot faster.

Worked fine in dedicated environment. Players playing with CSAT preset while enemy preset was the AAF preset. All units had the correct sides now. 👍


Architecture overview/ documentation in README

The flow of data from PuppetDB through backend and frontend isn't that clear to me. Shouldn't we have a section in the README about Puppetboard's architecture so it's easier for people to contribute?
Maybe a simple diagram is enough.

  A clean way of separating the front end UI to the database layer.

OK, if this is enough for most people maybe a diagram isn't needed.


Feature Request: Add support for rotating the salt

It would be nice to be able to rotate the salt from time to time for increased security (longer salts). I've just added a PR #1  for this based on how django-fernet-fields.
My idea is to make the SALT_KEY a list where you can add new keys to the front of the list. It if's not a list then it's convert into one within the EncryptedFieldMixin for backward compatibility.  Then the class properties that are currently there are moved to cached_property methods so that multiple keys could be built and then the Fernet call is replaced by MultiFernet if more than one key is to be checked.
This allows older encrypted records to be read whilst new entries will be saved using the new key. This is useful as it allows people to load an object then save it in order to re-hash and encrypt the plain-text value.
This could be extended in the future to add new settings.py entry to allow the kdf to be changed from PBKDF3HMAC to something else if required or, for now, just by extending the class and overloading the new keys method.
This is all based on https://github.com/orcasgit/django-fernet-fields which is a popular encryption field package but it no longer maintained

Closed as the PR was merged in, though I will make another PR shortly with the updated README


Data processing issue (test_entrance_before_exit) and reproducibility (confusion matrices)

I read your paper in detail and want to reproduce your results. However, the requirements file is incomplete, and the readme file also lacks a clear description of which files and how to run them. Can you clarify and help me with the issue below?
Considering that I use the original dataset (that has "entrance date/time"  before exit), those assertions need to be passed, but they fail.

I put MIMIV-IV-ED v2.2. under /data/MIMIC and also copied  patients.csv and transfers.csv files from the MIMIC-IV v2.2 under another folder named /data/MIMIC/core

I run the following script to create a processed version of the dataset according to your scheme.

python src/data_processing/MIMIC/run_processing.py

However, this script gives the following error:
Current Directory:  /home/omersumer/Desktop/ts-ehr/external/camelot-icml
100%|████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 205504/205504 [03:25<00:00, 999.12it/s]
100%|███████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 205504/205504 [03:23<00:00, 1010.21it/s]
100%|███████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 1/1 [00:00<00:00, 58.23it/s]
100%|████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 299712/299712 [05:40<00:00, 879.33it/s]
100%|███████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 4/4 [00:00<00:00, 86.70it/s]
100%|███████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 2/2 [00:00<00:00, 47.20it/s]
100%|███████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 112745/112745 [01:27<00:00, 1290.79it/s]
100%|██████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 2/2 [00:00<00:00, 251.50it/s]
/home/omersumer/Desktop/ts-ehr/external/camelot-icml/src/data_processing/MIMIC/admissions_processing.py:127: SettingWithCopyWarning:
A value is trying to be set on a copy of a slice from a DataFrame.
Try using .loc[row_indexer,col_indexer] = value instead

See the caveats in the documentation: https://pandas.pydata.org/pandas-docs/stable/user_guide/indexing.html#returning-a-view-versus-a-copy
  admissions_ed_S3.loc[:, PATIENT_INFO] = patients_core.set_index("subject_id").loc[patients_S3, PATIENT_INFO].values
/home/omersumer/Desktop/ts-ehr/external/camelot-icml/src/data_processing/MIMIC/admissions_processing.py:130: SettingWithCopyWarning:
A value is trying to be set on a copy of a slice from a DataFrame.
Try using .loc[row_indexer,col_indexer] = value instead

See the caveats in the documentation: https://pandas.pydata.org/pandas-docs/stable/user_guide/indexing.html#returning-a-view-versus-a-copy
  admissions_ed_S3.loc[:, "next_" + col] = transfers_to_relevant_wards.set_index("subject_id").loc[
/home/omersumer/Desktop/ts-ehr/external/camelot-icml/src/data_processing/MIMIC/admissions_processing.py:130: SettingWithCopyWarning:
A value is trying to be set on a copy of a slice from a DataFrame.
Try using .loc[row_indexer,col_indexer] = value instead

See the caveats in the documentation: https://pandas.pydata.org/pandas-docs/stable/user_guide/indexing.html#returning-a-view-versus-a-copy
  admissions_ed_S3.loc[:, "next_" + col] = transfers_to_relevant_wards.set_index("subject_id").loc[
/home/omersumer/Desktop/ts-ehr/external/camelot-icml/src/data_processing/MIMIC/admissions_processing.py:130: SettingWithCopyWarning:
A value is trying to be set on a copy of a slice from a DataFrame.
Try using .loc[row_indexer,col_indexer] = value instead

See the caveats in the documentation: https://pandas.pydata.org/pandas-docs/stable/user_guide/indexing.html#returning-a-view-versus-a-copy
  admissions_ed_S3.loc[:, "next_" + col] = transfers_to_relevant_wards.set_index("subject_id").loc[
/home/omersumer/Desktop/ts-ehr/external/camelot-icml/src/data_processing/MIMIC/admissions_processing.py:130: SettingWithCopyWarning:
A value is trying to be set on a copy of a slice from a DataFrame.
Try using .loc[row_indexer,col_indexer] = value instead

See the caveats in the documentation: https://pandas.pydata.org/pandas-docs/stable/user_guide/indexing.html#returning-a-view-versus-a-copy
  admissions_ed_S3.loc[:, "next_" + col] = transfers_to_relevant_wards.set_index("subject_id").loc[
/home/omersumer/Desktop/ts-ehr/external/camelot-icml/src/data_processing/MIMIC/admissions_processing.py:130: SettingWithCopyWarning:
A value is trying to be set on a copy of a slice from a DataFrame.
Try using .loc[row_indexer,col_indexer] = value instead

See the caveats in the documentation: https://pandas.pydata.org/pandas-docs/stable/user_guide/indexing.html#returning-a-view-versus-a-copy
  admissions_ed_S3.loc[:, "next_" + col] = transfers_to_relevant_wards.set_index("subject_id").loc[
/home/omersumer/Desktop/ts-ehr/external/camelot-icml/src/data_processing/MIMIC/admissions_processing.py:134: SettingWithCopyWarning:
A value is trying to be set on a copy of a slice from a DataFrame.
Try using .loc[row_indexer,col_indexer] = value instead

See the caveats in the documentation: https://pandas.pydata.org/pandas-docs/stable/user_guide/indexing.html#returning-a-view-versus-a-copy
  admissions_ed_S3["age"] = admissions_ed_S3.intime.dt.year - admissions_ed_S3["anchor_year"] + admissions_ed_S3[
Traceback (most recent call last):
  File "src/data_processing/MIMIC/run_processing.py", line 37, in <module>
    main()
  File "src/data_processing/MIMIC/run_processing.py", line 26, in main
    vitals_processing.main()
  File "/home/omersumer/Desktop/ts-ehr/external/camelot-icml/src/data_processing/MIMIC/vitals_processing.py", line 79, in main
    test.admissions_processed_correctly(admissions)
  File "/home/omersumer/Desktop/ts-ehr/external/camelot-icml/src/data_processing/MIMIC/test.py", line 75, in admissions_processed_correctly
    assert test_entrance_before_exit(df["intime"], df["outtime"])
AssertionError

Here is a quick update regarding the issue:

Later, I checked the paper and noticed the cited reference of MIMIC-IV-ED is for version 1.0. I was using the recent version of the data. I set it back to v1.0, and preprocessing worked (lots of pandas warnings, but without issue, it created all files under interim and processed needed for training).

Then, I kept the same configurations, and without changing anything, I trained the CAMELOT model by running python src/training/run_model.py. It produces a bunch of training and validation logs (definitely learning and optimizing the loss terms and AU-ROC is around the reported values, 0.711 and 0.718 in two different runs).

The problem is confusion matrix printed at the end of training is very bad. The model can predict only Ward but not other classes. Below, I share the output at the end of two runs. It is not possible to have good AU-ROC scores but all false predictions. Confusion matrices below are all false in the Death, ICU, and Discharge classes. I think there is an issue with one of these metrics.

Scoring information for this experiment

ROC-AUC value: [0.69488729 0.75383878 0.72695957 0.67002434]
F1 value: [0.         0.02402402 0.86579287 0.        ]
Recall value: [0.         0.01226994 0.99787234 0.        ]
Precision value: [0.         0.57142857 0.76459081 0.        ]
ARI value: 0.011248643132512373
NMI value: 0.006368103818763199
Silhouette value: 0.2257734007305569
DBI value: 1.686989537706597
VRI value: 24.53473699159825
Purity value: 0.08489307223484438

Confusion Matrix for predicting results
Predicted Class  De  I     W  Di
True Class
De                0  1    19   0
I                 0  8   644   0
W                 0  5  2345   0
Di                0  0    59   0
---

Scoring information for this experiment

ROC-AUC value: [0.73703038 0.68693313 0.65729866 0.5604774 ]
F1 value: [0.         0.01213961 0.86541298 0.        ]
Recall value: [0.         0.00613497 0.9987234  0.        ]
Precision value: [0.         0.57142857 0.76350033 0.        ]
ARI value: 0.0043416573852426464
NMI value: 0.0022140455605365052

Confusion Matrix for predicting results
Predicted Class  De  I     W  Di
True Class
De                0  0    20   0
I                 0  4   648   0
W                 0  3  2347   0
Di                0  0    59   0
---

Scoring information for this experiment

ROC-AUC value: [0.74459327 0.73911226 0.70786972 0.5903235 ]
F1 value: [0.         0.06451613 0.86761711 0.        ]
Recall value: [0.         0.03374233 0.99702128 0.        ]
Precision value: [0.         0.73333333 0.76794494 0.        ]
ARI value: 0.030210147661374066
NMI value: 0.01947228477908028
Silhouette value: 0.20218332008355194
DBI value: 5.401939838385961
VRI value: 41.10279826766778
Purity value: 0.08528976883407263

Confusion Matrix for predicting results
Predicted Class  De   I     W  Di
True Class
De                0   1    19   0
I                 0  22   630   0
W                 0   7  2343   0
Di                0   0    59   0

P.S.: I changed seed numbers in both data_config and training_config; it all gave similar outcomes that I shared above.

Hi @sumeromer, thanks for raising this. This was also raised internally, and I will come back to fix the errors within the next few weeks once I have some time. In the meantime, some comments:

The data processing used for the paper is not the one in the latest commits: we were experimenting with other options for further work, and that ended up being left half-way here and moved to a different project.
The written model hyper-parameters are placeholders, not the optimal choice. As we mentioned in our paper review, the model can be quite tricky to train, and is sensitive to hyper-parameter tuning. I will endeavour to find the hyper-parameters used for our results table when I do the general refactoring.

Hi @hrna-ox, thank you very much for your swift reply.
Please do not spend time on the preprocessing issue because everything works in preprocessing in version 1.0, as you used in the paper. I can help to debug your preprocessing script and make it run for the latest MIMIC.
Can you have a look at the performance metrics and the results? Because it never predicts accurately in death and discharge, nearly all predictions are ward. Thus, it is more urgent to understand whether there is a flaw in the evaluation of your approach or not.


Add the test structure

What does this PR do?

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] PR title must be written as a CHANGELOG entry (see why)
[ ] Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
[ ] PR must have changelog/ and integration/ labels attached
[ ] If the PR doesn't need to be tested during QA, please add a qa/skip-qa label.

Current dependencies on/for this PR:

master

PR #13807

PR #13808

PR #13809

PR #13810

PR #13811

PR #13812

PR #13833   👈

This comment was auto-generated by Graphite.


Add bool type as an alias to Boolean

This helps solving the following introspection problem:
/usr/local/lib/python3.5/dist-packages/cockroachdb/sqlalchemy/dialect.py:115: SAWarning: Did not recognize type 'BOOL' of column 'is_something_happened'
  (type_name, name))

And the subsequent error:
  File "/usr/local/lib/python3.5/dist-packages/alembic/autogenerate/compare.py", line 48, in _produce_net_changes                      [48/1946]
    autogen_context, upgrade_ops, schemas
  File "/usr/local/lib/python3.5/dist-packages/alembic/util/langhelpers.py", line 313, in go
    fn(*arg, **kw)
  File "/usr/local/lib/python3.5/dist-packages/alembic/autogenerate/compare.py", line 75, in _autogen_for_tables
    inspector, upgrade_ops, autogen_context)
  File "/usr/local/lib/python3.5/dist-packages/alembic/autogenerate/compare.py", line 137, in _compare_tables
    inspector.reflecttable(t, None)
  File "/usr/local/lib/python3.5/dist-packages/sqlalchemy/engine/reflection.py", line 598, in reflecttable
    table_name, schema, **table.dialect_kwargs):
  File "/usr/local/lib/python3.5/dist-packages/sqlalchemy/engine/reflection.py", line 369, in get_columns
    **kw)
  File "/usr/local/lib/python3.5/dist-packages/cockroachdb/sqlalchemy/dialect.py", line 120, in get_columns
    typ = type_class()
TypeError: 'NullType' object is not callable

This uses alembic, but I think the core problem is introspection not alembic per se.
Versions:

python bindings 0.1.1
cocroachb itself 1.1.2

Amended a commit with a test.

Thanks!


As a CIF developer, I want the Funding Agreement form to be refactored with a custom commit handler, so I have more flexibility in the form layout.

Description:
Similarly to the milestone refaactor (#1007)
Acceptance Criteria:
Given I am a CIF developer
When I commit a funding agreement form
Then a custom form commit handler is called
And both funding_agreement and additional_funding_sources tables are populated
Given I am a CIF developer
When I add, remove or reorder fields on the funding agreement page
Then there is only a single form to change
Development Checklist:

[ ] write new, single json schema, using an array type for the additional funding sources
[ ] don't forget to update the tasklist and mutation fragments to fetch the new data
[ ] existing form_change records need to be migrated with:

[ ] a migration function that goes through every existing revision, grabs the milestone reporting requirements and creates a new form_change for each of these - and delete (archive) the form_changes for reporting_requirement, payment and milestone tables.
[ ] tests for that migration function

[ ] add the funding_agreement form to the list of database form in the server side validation plugins
[ ]
[ ] fix dev data, potentially
[ ] tests for  react form and summary components need to use the same json schema as is deployed to the database.
[ ] commit_form_change_internal should use a custom handler for the funding agreement form
[ ]  tests for handle_funding_Agreement_form_change_commit
[ ] create_project_revision might need refactoring
[ ] Meets the DOD

Definition of Ready (Note: If any of these points are not applicable, mark N/A)

[ ] User story is included
[ ] User role and type are identified
[ ] Acceptance criteria are included
[ ] Wireframes are included (if required)
[ ] Design / Solution is accepted by Product Owner
[ ] Dependencies are identified (technical, business, regulatory/policy)
[ ] Story has been estimated (under 13 pts)

·Definition of Done (Note: If any of these points are not applicable, mark N/A)

[ ] Acceptance criteria are tested by the CI pipeline
[ ] UI meets accessibility requirements
[ ] Configuration changes are documented, documentation and designs are updated
[ ] Passes code peer-review
[ ] Passes QA of Acceptance Criteria with verification in Dev and Test
[ ] Ticket is ready to be merged to main branch
[ ] Can be demoed in Sprint Review
[ ] Bugs or future work cards are identified and created
[ ] Reviewed and approved by Product Owner

Notes:

@pbastia - is this the same as #1171?

@LindsayMacfarlane yes! Thanks for catching that. Zenhub showed me an error "could not create the issue", and I clicked the create button again. I guess it worked anyways ;)
Closing this extra one.


Update the opensource data

We need to update the source where we get the data; we should start using opensource-data
We should change the source here: https://github.com/VueDominicana/open-source/blob/master/src/util/api.js#L3
Considerations with this source:

The data is not sorted, we need to sort it by ourself
It doesn't have the position key
It doesn't have the forked key

For the forked key and also for the count of repositories of a developer, may us after fetch the data call a action that change the developers state with a calculated value ?


Remove use of Deprecated Constructor

https://github.com/MockBukkit/MockBukkit/blob/2e865fa5c78782af64763d2dc3763b2b65f49dbb/src/main/java/be/seeseemelk/mockbukkit/entity/PlayerMock.java#L362
The used Constructor for BlockDamageEventis annotated as Deprecated for Removal and and DoNotUse. Therefore we should replace this Constructor

Hi, I would like to work on this issue. Could you assign it to me?

Sure, done

@thelooter I can't seem to find a depreciation marker or a discussion about possible deprecation of this constructor anywhere. Could you point me in the direction of some info on it?
This file only has one constructor
https://github.com/Bukkit/Bukkit/blob/master/src/main/java/org/bukkit/event/block/BlockDamageEvent.java

We're building on Paper, not Bukkit (which has been unmaintained since 2014), and they have deprecated this constructor as you can see here. Therefore we wanna remove this usage


I have a question

Hello there! I am a developer (trying to figure out chrome themes) and I can't figure out how to make the searchbar text change color (e.g. VS code) can you help me?

"omnibox_text": [r, g, b]
Example: "omnibox_text": [255, 0, 0]


Improve the BackAndroid example to be more clear

The example of BackAndroid caused a bit of confusion for beginners (see #8822), so I thought we should clarify the functionality a bit. I added a comment indicating that a user would have to implement this.onMainScreen and this.goBack on their own, this was the original problem.

By analyzing the blame information on this pull request, we identified @astreet and @jutaz to be potential reviewers.

Thanks for this! Can you actually make the comment explicit and say that you'd need to have your own implementation of this.onMainScreen()/this.goBack()? It'd be even more helpful if there was an example implementation... maybe this should be part of the Navigator docs?

Adding label based on Andy's comment.

Will improve this in a couple of hours, sorry for the delay

@DanielMSchmidt updated the pull request.

@DanielMSchmidt updated the pull request.

@DanielMSchmidt updated the pull request.

@DanielMSchmidt updated the pull request.

@mkonicek Did you mean this way?

@DanielMSchmidt updated the pull request.

Thank you
@facebook-github-bot shipit

Thanks for importing.


Add permissible values to FileTypeEnum and DataCategoryEnum to accomodate workflow configuration DataObjects

Resolves issue: https://github.com/microbiomedata/nmdc-schema/issues/1912
This PR (related to this initial PR that is closed: https://github.com/microbiomedata/berkeley-schema-fy24/pull/136 - we decided to go a different direction after Configuration discussions) allows DataObjects to include workflow configuration files, so they can be connected to their respective workflows via has_input
adds aDataCategoryEnum permissible_value of workflow_parameter_data to allow workflow parameter files as has_input for WorfklowExecutions. It also adds a permissible_value for the FileTypeEnum of Configuration toml.  Both new permissible values include EDAM mappings.

Unsure about how braod or specific the new permissible file for the FileTypeEnum needs to be. Wanted input from @SamuelPurvine

Also please update the PR title to indicate what action was finally taken, adding a new permissible value

@brynnz22  - after talking with @SamuelPurvine, we think workflow_parameter_data is better than workflow_parameter (the latter sounds like we're capturing a single parameter), and fits better with the other permissible values on that Enum.
The proteomics workflows will need a different set of permissible values for the FileTypeEnum (they are not tomls and there are more than one), so I think being more specific for that value for this specific use case is also valuable (CoreMS Configuration toml), but I am open to being overruled on that case.
Generally speaking though, this approach is valuable and applicable for all the mass-spec 'omics, yay!

@turbomam I included you suggestions - updating the description for the Configuration Toml permissible value and including an example data set.
I also changed the new DataCateogryEnum permissible value from workflow_parameter to workflow_parameter_data and @SamuelPurvine's request to be flexible to proteomics use cases.


[SPARK-33540][SQL] Subexpression elimination for interpreted predicate

What changes were proposed in this pull request?

This patch proposes to support subexpression elimination for interpreted predicate.
Why are the changes needed?

Similar to interpreted projection, there are use cases when codegen predicate is not able to work, e.g. too complex schema, non-codegen expression, etc. When there are frequently occurring expressions (subexpressions) among predicate expression, the performance is quite bad as we need to re-compute same expressions. We should be able to support subexpression elimination for interpreted predicate like interpreted projection.
Does this PR introduce any user-facing change?

No, this doesn't change user behavior.
How was this patch tested?

Unit test and benchmark.

Test build #131763 has started for PR 30497 at commit 56c09ca.

Test build #131763 has finished for PR 30497 at commit 56c09ca.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Build finished.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/131763/

retest this please

Test build #131776 has started for PR 30497 at commit 56c09ca.

Build finished.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/36361/

Test build #131776 has finished for PR 30497 at commit 56c09ca.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Build finished.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/131776/

Thanks @dongjoon-hyun @HyukjinKwon @maropu

Build finished.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/36374/


Feature Request - expand scope for subnets should have a nsg

Subnets should have a Network Security Group should be considered to be moved to intermediate too group instead identity MG and Landing Zone MG.
Reason is that it follows best practices and therefore should be on intermediate root group rather than lower scopes:
https://learn.microsoft.com/en-us/azure/security/fundamentals/network-best-practices#logically-segment-subnets
https://learn.microsoft.com/en-us/security/benchmark/azure/baselines/virtual-network-security-baseline#microsoft-defender-for-cloud-monitoring

Hey @vegazbabz, good ask. Would probably need to just be duplicated to platform instead as we dont want this to stop sandbox users finding their way and decommissioned?
May a valid use for notScopes?
cc: @Springstone

Hey @vegazbabz, good ask. Would probably need to just be duplicated to platform instead as we dont want this to stop sandbox users finding their way and decommissioned?
May a valid use for notScopes?
cc: @Springstone

Not a big fan of duplicate assignments. I rather want to use the built-in features provided to me by the cloud. So yes, use excluded scope / notScopes instead of multiple assignments.

@vegazbabz No issue with expanding coverage and using notScopes however, this will be a long-term objective as we're busy with a very large amount of change in ALZ at the moment.


"Could not fetch Infinity Model" masks other errors

At a couple places in the route mixin (here and here), there is a promise failure handler that catches all errors and throws a generic "Could not fetch Infinity Model" error. This makes it quite difficult to determine what the actual error was – in my case the server response was successful, and I had to do some "pause on all exceptions" debugging to find out that it was ember-data telling me an association wasn't set up correctly. Is there an advantage to doing things this way? Why not allow the real error to surface?

thanks @grantovich - yeah that's a good point.  I think we should probably remove all error handling from server promises, and leave them only for validation type errors.
@mkorfmann @mike-north @kellyselden - thoughts / tips here?

just chatted with @mkorfmann - we'd like to ensure we return the error from the promise callback, but instead of throwing, we'll log an Ember.warn.  That way nothing will be swallowed - and the error will be clearly ember-infinity related
We're waiting for #88 to get into the codebase before doing new work on it - so we'll get to this hopefully soon - thankyou @grantovich !

Thanks for the prompt response :smiley_cat: I look forward to those changes.

@grantovich FYI #88 has merged

@grantovich - feel like writing a PR for this? :heart:

This was something I encountered on a free-time project that I work on very infrequently, so I'm not sure if I'll be able to get to it in the near future :crying_cat_face: I'll update here if I find some time to work on it.

kk - thanks anywhoo @grantovich !

Fixed with https://github.com/hhff/ember-infinity/pull/125


Store parameters in output

Mark (mrehorst) suggested I save the parameters that created the pattern in the gcode file. This is a great idea, and I would like to do that.

Thanks for adding the ability to name the output file!  If you could also save that name at the start and/or end of the file that would also be very useful.

I have this in master, and I'll be deploying shortly.


Refactor DevFS for kernel code

Refactor DevFS so that it's easier to add new types of content such as kernel code

add tests for DevFS package scanning
add tests for DevFS over VMService protocol
which covers _DevFSHttpWriter and ServiceProtocolDevFSOperations
replace AssetBundleEntry and DevFSEntry with DevFSContent
refactor to cleanup common code and replace some fields with locals
rework .package file generation refactor away DevFSOperations.writeSource
only update .package file if it has changed
only write/delete/evict assets that have been changed/removed

@johnmccutchan

@johnmccutchan Comments addressed... PTAL

LGTM


How do I input an open-vocabulary text description?

Hello, thank you for developing a good work, i am really interested in it. But I want to know how do I input an open-vocabulary text description like the example you gave?

Thanks for your interest!
We input the text description in line 166~185 of models/sole.py. You may change corresponding part to input your own text query.
Furthermore, if you want to segment masks that is only related to your text query (without segmenting the entire objects in the scene), you con control CURR_TOPK parameter in validation bash file. For example, if you set CURR_TOPK=1, the model will output one single mask that is most related to your input text query.

Thanks for your immediate reply, I will try it later.


Ease Plugin Management in Optimus

Optimus Plugins can be installed by specifying the plugins in the  Config Yaml such that optimus binary takes care of installation of the plugins
All the plugin developers have to build the plugins images whenever there is change in optimus cli or entrypoint.sh, i believe this can be avoided by keeping things centralized.

Duplicated already covered


Figure not showing in plotly.io.show()

I am trying to use the simple_forecast notebook from the quickstart but when running plotly.io.show(fig) no image is coming here. There is no error being thrown.

import plotly.offline as pyo
pyo.init_notebook_mode()

Thanks for chiming in @jorgelaranjo ! Yes, we put some instructions for interactive plotting here: https://linkedin.github.io/greykite/installation.html
To render plots in the notebook, use notebook mode and replace plotly.io.show with iplot:
from plotly.offline import init_notebook_mode, iplot
init_notebook_mode(connected=True)  # for plots to render in jupyter notebook
# ... notebook code ...
# plotly.io.show(fig)  # replace these with `iplot`
iplot(fig)

import plotly.offline as pyo
pyo.init_notebook_mode()

Thank you


website: chore: fix typo

In my opinion, I think it reads better by putting "first" before "try", given the way the sentence has been constructed.

The original wording sounds better to me.

I agree with @callumlocke


Upcoming Gadgets

Just a space to list the gadgets that are planned for the future.

[ ] Battery Meter
[ ] Clock
[ ] Calendar
[ ] Clipboard Meter
[ ] Weather Meter
[ ] App Launcher

Hi, thanks for your gadgets, any plans for a master audio volume gadget?
Volume % with maybe a spectrum indicator?
Regards,

It wasn’t planned, no. Especially with a visualizer, the gadgets updating once a second really messes with visualizes. So that wouldn’t work.

This issue is replaced by #112


FIX Collaborator Image

@0ME9A here

Ready for merge ?

So you did it forcefully not with the help of API. THIK HE JAISI TUMHARI SHARDHA

Why and how both are different?🤔

image

So you did it forcefully not with the help of API. THIK HE JAISI TUMHARI SHARDHA

the Testimonial POST API is not ready yet

No problem, Do it when you are free/want😊

O No It's 1 O'clock
Good night bro I have to sleep.


Camel 4.7 - Running Camel Quarkus in dev mode should pre-configure Camel in dev mode as well

Describe the feature here
camel-core / camel-main has a profile concept that makes it convenient to turn on a bunch of stuff in dev mode that assist during development, and for camel-jbang CLI as well.
So can we make mvn quarkus:dev able to call camel-main to set it in dev mode, via
org.apache.camel.main.ProfileConfigurer#configureCommon

There's a small issue that blocks this:
https://issues.apache.org/jira/browse/CAMEL-21003


func: get vertical position of view in arrange area

removed 2 actions from Misc/TrackParams.cpp, which i did previously, because the same result can be achieved with functions provided by juliansader in pull request #1028. I don't see a point to add the same functionality.
PR #1028 also contains function, which can replace my DO_GetArrangeVertPos, but i still would like to add DO_GetArrangeVertPos to SWS as an alternative, because it's smaller, returns only 2 parameters, which can be more efficient for some specific defered scripts, like mine for example https://github.com/doppgit/spells/blob/master/dopp_fxList_public.lua.
Thanks! Hope to see update soon.

all i did here is not needed anymore, my script used this functions, but looks like script is useless to other people, and this functions can be replaced by functions from other pull request1028, so to avoid redundancy i remove pull request.


add tests to catch data-plane-api compat regressions

Related to https://github.com/envoyproxy/envoy/issues/2466.
This issue will track figuring out some basic sanity tests, much like envoy-filter-example, to help us catch these types of regressions. Some ideas so far:

Have an xDS regression test which works with a server (either Go or C++) which floats behind the SHA used for data-plane-api in main Envoy.
Have a test in Envoy which loads certain proto descriptors by name (services, top level objects, etc.) with a very explicit warning that if any of them change compat is broken and to stop.
Some set of golden JSON/YAML files which need to load with stern warnings about compat. (To some extent I think our example configs are this. They all need to be converted to v2 which is tracked in https://github.com/envoyproxy/envoy/issues/2139).

I would recommend we do (2) immediately as its simple and think about (1) and (3).
cc @envoyproxy/maintainers

@mattklein123 do you still want to add tests for this given that we have added the validation at startup?

No I think we are good. I will close this. Thanks @ramaraochavali!


Failed to build arm image

I'm using oci-build-task to create images, but not only linux/amd64, when I try to use any of these:

IMAGE_PLATFORM: linux/arm/v6
IMAGE_PLATFORM: linux/arm/v7
IMAGE_PLATFORM: linux/arm64

I get the following error
#8 18.15 Traceback (most recent call last):
#8 18.15   File "/usr/local/bin/pip", line 8, in <module>
#8 18.16     sys.exit(main())
#8 18.16   File "/usr/local/lib/python3.9/site-packages/pip/_internal/cli/main.py", line 70, in main
#8 18.16     return command.main(cmd_args)
#8 18.16   File "/usr/local/lib/python3.9/site-packages/pip/_internal/cli/base_command.py", line 98, in main
#8 18.16     return self._main(args)
#8 18.16   File "/usr/local/lib/python3.9/site-packages/pip/_internal/cli/base_command.py", line 214, in _main
#8 18.16     self.handle_pip_version_check(options)
#8 18.16   File "/usr/local/lib/python3.9/site-packages/pip/_internal/cli/req_command.py", line 143, in handle_pip_version_check
#8 18.16     session = self._build_session(
#8 18.16   File "/usr/local/lib/python3.9/site-packages/pip/_internal/cli/req_command.py", line 88, in _build_session
#8 18.16     session = PipSession(
#8 18.16   File "/usr/local/lib/python3.9/site-packages/pip/_internal/network/session.py", line 289, in __init__
#8 18.17     self.headers["User-Agent"] = user_agent()
#8 18.17   File "/usr/local/lib/python3.9/site-packages/pip/_internal/network/session.py", line 132, in user_agent
#8 18.17     linux_distribution = distro.linux_distribution()  # type: ignore
#8 18.17   File "/usr/local/lib/python3.9/site-packages/pip/_vendor/distro.py", line 125, in linux_distribution
#8 18.17     return _distro.linux_distribution(full_distribution_name)
#8 18.17   File "/usr/local/lib/python3.9/site-packages/pip/_vendor/distro.py", line 681, in linux_distribution
#8 18.17     self.version(),
#8 18.17   File "/usr/local/lib/python3.9/site-packages/pip/_vendor/distro.py", line 741, in version
#8 18.17     self.lsb_release_attr('release'),
#8 18.17   File "/usr/local/lib/python3.9/site-packages/pip/_vendor/distro.py", line 903, in lsb_release_attr
#8 18.17     return self._lsb_release_info.get(attribute, '')
#8 18.17   File "/usr/local/lib/python3.9/site-packages/pip/_vendor/distro.py", line 556, in __get__
#8 18.18     ret = obj.__dict__[self._fname] = self._f(obj)
#8 18.18   File "/usr/local/lib/python3.9/site-packages/pip/_vendor/distro.py", line 1014, in _lsb_release_info
#8 18.18     stdout = subprocess.check_output(cmd, stderr=devnull)
#8 18.18   File "/usr/local/lib/python3.9/subprocess.py", line 424, in check_output
#8 18.18     return run(*popenargs, stdout=PIPE, timeout=timeout, check=True,
#8 18.18   File "/usr/local/lib/python3.9/subprocess.py", line 528, in run
#8 18.18     raise CalledProcessError(retcode, process.args,
#8 18.18 subprocess.CalledProcessError: Command '('lsb_release', '-a')' returned non-zero exit status 1.
#8 ERROR: executor failed running [/dev/.buildkit_qemu_emulator /bin/sh -c pip install --no-cache-dir -r requirements.txt]: exit code: 1
------
 > [4/4] RUN pip install --no-cache-dir -r requirements.txt:
------
Dockerfile:7
--------------------
   5 |     COPY . .
   6 |
   7 | >>> RUN pip install --no-cache-dir -r requirements.txt
   8 |
   9 |     ENTRYPOINT python ./helloWorld.py
--------------------
error: failed to solve: rpc error: code = Unknown desc = executor failed running [/dev/.buildkit_qemu_emulator /bin/sh -c pip install --no-cache-dir -r requirements.txt]: exit code: 1
FATA[0055] failed to build: build: exit status 1
FATA[0055] failed to run task: exit status 1

In this repo you will be able to find an example repository (Dockerfile, helloWorld.py and requirement.txt) that I'm using and the pipeline to create.
https://github.com/woolter/test-oci-build-task
The code related with the push is commented as in this moment I'm not able to build the image

Similar but different: setting IMAGE_PLATFORM to linux/arm64 built the linux/amd64 (x86_64) variant.
#5 [2/6] RUN dnf install -y iproute bind-utils neovim
#5 sha256:91d895079f3865ddb70de5a790cbf5518f1554e0c4964b2f43bf52a8593d9671
#5 5.204 Fedora 35 - x86_64                               12 MB/s |  61 MB     00:04


build: added deps target to ensure first build "just works"

Simple addition to the Makefile which retrieves dependencies when you run make, ensures that the first time someone runs a build it should just work.
Cheers

@wolfeidau Thank you for the contribution!
The only issue I can see here is that this may not do the right thing when building with a godep path. For example, if one builds per the instructions:
$ GOPATH=`godep path`:$GOPATH make deps

go get will try to download the files into Godeps, which is not the behavior we want. Perhaps, the deps target could check that the path does not end with "Godeps/_workspace" before running.
Check out https://github.com/docker/distribution/blob/master/docs/building.md for details on this. There is a relevant TODO.

@stevvooe Firstly thanks a lot for taking the time to review this change so thoroughly, it is much appreciated.
I cloned the project to try it out, I checked the README and didn't see anything on building, sorry I missed the docs directory!
I normally assume, rightly or wrongly that if there is a make file the default target will "just work" to build the software, hence my pull request.
I have updated the pull request to correctly use godeps, this will ensure the code retrieved by this tool is built against.
Out of the box users will still need to install some tools to "run" a build but I think that is OK.
Look forward to hearing your views on this.

I normally assume, rightly or wrongly that if there is a make file the default target will "just work" to build the software, hence my pull request.

I 100% agree with this. Unfortunately, there are some subtleties with Go development that make this fairly annoying. Having godep all over the Makefile prevents the user from controlling a builds GOPATH, which is critical for development. The workflow generally works like this:

Use go get to fetch a new dependency needed for a change.
Work on the change, using make test, make binaries, configured with an external GOPATH (not necessarily the Godeps/_workspace.
Once the change is ready, bring the dependency in with godep save ./.... Commit and PR.

So, while it is convenient to have godep in the Makefile for the initial build, putting it there conflicts with the above workflow. Effectively, the current setup allows one to hack with a separate GOPATH, using git checkouts, while the release build uses Godeps.
Enough rambling ;). Let's get something done on this PR:

Let's keep godep out of the Makefile for this PR. I'm going submit a PR that takes care of this problem a little differently.
Keep the deps target you've proposed but have it be a no-op if the first GOPATH element ends with "Godeps/_workspace" and in the same file as the Makefile. I got this to work with the following:

deps:
       @if [[ "$${GOPATH%:*}" != "*/Godeps/_workspace" ]]; then \
               echo "+ $@"; \
               go get -d ./...; \
       fi

I've file #390 to make the build instructions more prominent.

Small correction on the deps guard:
deps:
	@if [[ "$${GOPATH%:*}" != */Godeps/_workspace ]]; then \
		echo "+ $@"; \
		go get -d -t ./...; \
	fi

Sorry to be a little fickle here but this approach has made the Makefile a little fragile.
Checkout the attempt here: https://github.com/docker/distribution/compare/master...stevvooe:makefile-use-godeps
That branch sets godep for the default build. Unfortunately, it breaks some conveniences. I really think the GOPATH must be managed external to the Makefile. Otherwise, the provided targets become fragile and inflexible.
The tricks to getting this to work are the following:

The project must be checked out into a Go workspace. Preferably, use go get github.com/docker/distribution since it downloads all the dependencies, as well.

To get a godep build, simply use godep to set the GOPATH:
$ GOPATH=$(godep path):$GOPATH make

We should probably add a build script that just calls the above and then make the default target explain that runs the build script (and in turn the makefile itself).

Please let me know what you think and thanks for bearing with me on this. A good build pipeline is very important.

Yeah I prefer your solution as it isolates godeps and does an even better job of "just works".
Just a couple of fixes in the diff below as a) vet has moved and that errors out. b) stray target in all.
diff --git a/Makefile b/Makefile
index 03692cc..b991ce1 100644
--- a/Makefile
+++ b/Makefile
@@ -17,7 +17,7 @@ setup-godeps: setup godeps
 godeps: export GOPATH:=$(shell godep path):${GOPATH}
 godeps: all

-all: gopath AUTHORS clean fmt vet fmt lint deps build test binaries
+all: gopath AUTHORS clean fmt vet fmt lint build test binaries

 AUTHORS: .mailmap .git/HEAD
        git log --format='%aN <%aE>' | sort -fu > $@
@@ -45,7 +45,7 @@ setup:
        @if [[ "$${GOPATH%:*}" != */Godeps/_workspace ]]; then \
                echo "+ $@"; \
                go get -d -t ./...; \
-               go get code.google.com/p/go.tools/cmd/vet \
+               go get golang.org/x/tools/cmd/vet \
                            github.com/tools/godep \
                            github.com/golang/lint/golint; \
        fi

Pretty much :+1: from me for closing this and using your code.

@wolfeidau I have apologize that this effort has stalled a bit. Should we re-open this as an issue or are we okay having the discussion here?

@wolfeidau We are going in a different direction here. We may pickup my branch or your PR at a later date to get this right.

@stevvooe No problem, look forward to seeing how you solve this :)


data:image/svg+xml in HEAD tries to load the embebed SVG

Hello,
I have that in my <HEAD> in index.html:
<link
      rel="icon"
      href="data:image/svg+xml,<svg xmlns='http://www.w3.org/2000/svg' viewBox='0 0 100 100'><text y='.95em' font-size='80'>🏴☠</text></svg>"
/>

It allows to have an emoji as favicon.
I never notice it before, but on beta 8 I had this message:
'data:image/svg+xml,<svg xmlns='http://www.w3.org/2000/svg' viewBox='0 0 100 100'><text y='.95em' font-size='80'>🏴☠</text></svg>' is imported by index.html, but could not be resolved – treating it as an external dependency

Now on beta 11 it crashes saying the resource doesn't exist.
[Error: ENOENT: no such file or directory, open '/Users/cedeber/Code/eukolia-app/app/ata:image/svg+xml,<svg xmlns='http:/www.w3.org/2000/svg' viewBox='0 0 100 100'><text y='.95em' font-size='80'>🏴☠</text></svg>']

Thanks.

Nice, thanks.


Can't install node modules

Hi, I deployed a code-server on railway. I successfully opened the port for a vanilla javascript.
But, when I start working on a react project, I always seems to failed on the npm install part.
Every time I tried to install node module, it will run a little bit, then killed the process.

Hi - can you share the project or does this happen with any node project?

Pretty much every node project, happened the same while fresh creating create-react-app on the code-server. (on both iPad and my PC web browser.)
Each time the killed message shows differently.

I googled it and it's due to the 1GB ram inefficiency, the way is to create a swap file.
(I fresh rebuild the code-sever with 14.x this time.)
However, when I do that, I failed the process and received this message:
swapon: /var/swap.1: insecure permissions 0644, 0600 suggested.
swapon: /var/swap.1: swapon failed: Operation not permitted


/install returning not found

Our project codebase is modified to run on the root by renaming server.php to index.php to avoid the command php artisan serve.
but the /install returning not found error.
path to the project : /var/www/html/PROJECT/
route tried to access: http://localhost/PROJECT/install
*note http://localhost/PROJECT is accessible.
also have asked as a question in here
Thanks in Advance.

Hello, I don't know what setup.php file you are referring to. however, to regain access to the installer URL you can try deleting the file found in the following path: storage\installed

Once deleted, try again to access the /install


add 20min ogre download timeout

Without timeout if cmake hangs during the download the jobs will never finish: e.g. https://github.com/ros2/build_cop/issues/77#issuecomment-400836869
This 20min timeout requires a download speed of ~100kb/s.
I can make it higher if we think it's too hard of a requirement

Linux
Linux-aarch64
macOS
Windows


LSC Outdoor Spot lights

Data dump attached.
Please tell me if you need more info, I had to "dissect" these lights a little....
They are basically three RGB spotlights, with one "master" (containing the CB2L module) and two "slaves" which are connected with a cable.
Led_spots_extract_dir.zip

The iHome IH-BW948-999 profile should work for this device.

The dump attached to this issue is extracted only and does not include the storage, so no schema can be generated/verified.  You can try the iHome IH-BW948-999, or supply a full 2M bin and we can re-process this.

Dear Cossid, thanks for the hard work by the way.
I extracted what I could from the raw 2M dump I made, but that process might have gone wrong. Here's the raw dump, maybe that'll clear things up?
Otherwise I can try again, but these lights are lets sat not openable without destroying them....
lsc_outdoor_spots_raw.zip

Yes, that is exactly what we needed.  A profile for this device has been added.