Exceptions that escape SpringMVC DispatcherServlet should be logged with trace & span IDs

Hi,
We are re-raising the issue reported in #579 and #542 because we've tried the suggested solution of handling and logging all the errors ourselves, but we have yet to land on a workable solution.
We tried adding a method like this to our global ControllerAdvice bean:
    @ExceptionHandler(Exception.class)
    ResponseEntity<ErrorPayload> otherwiseUnhandledException(Exception e) {
        log.error("Unexpected exception occurred. Will return HTTP 500.", e);
        return new ResponseEntity<>(new ErrorPayload(e.getMessage(), ""), INTERNAL_SERVER_ERROR);
    }

The error is logged with the correct trace and span IDs (great!) but the killer side effect is that all the internal Spring MVC exceptions that do nice things like return 400 on missing mandatory by our ExceptionHandler method and thus return HTTP 500 to our clients.
We also experimented with registering our own BasicErrorController bean based on the callout box in the docs linked from #579 (https://docs.spring.io/spring-boot/docs/current-SNAPSHOT/reference/htmlsingle/#boot-features-error-handling). We see that it is getting instantiated, but its onError method is not getting called for our failing JSON API requests:
@Slf4j
@Controller
public class MyErrorController extends BasicErrorController {

    public MyErrorController(ErrorAttributes errorAttributes) {
        super(errorAttributes, new ErrorProperties());
        log.info("Created error controller with errorAttributes {}", errorAttributes);
    }

    @RequestMapping(produces = "application/json")
    public ErrorPayload onError() {
        log.error("KABOOM!");
        return new ErrorPayload("Something broke (TODO: resolve actual exception)", "????");
    }
}

We'd really appreciate any advice you can offer on how to preserve Spring MVC's default response codes while also including the Sleuth trace and span IDs in the MDC.
Thanks!

Like presented in the commit message:

without this change any exception that is not caught by a filter, get caught and logged by server's internals (e.g. Tomcat's Valve). To make the Valve log the exception together with the tracing information we would have to allow the tracing context remain in the thread after TraceFilter gets executed. That is problematic cause we're polluting the ThreadLocal and would have to assume that some component will eventually clear the context.
with this change we're trying to solve the issue from a different angle. Whenever an uncaught exception is thrown, we are already catching it in the catch(...) {} clause. It's enough to just log it at the error level and that way, regardless of the underlying server implementation (Tomcat, Undertow) we will log the uncaught exception and rethrow it.

we would have to allow the tracing context remain in the thread after TraceFilter gets executed. That is problematic cause we're polluting the ThreadLocal and would have to assume that some component will eventually clear the context.

Why not using a javax.servlet.ServletRequestListener to listen for the completion of the request and clear the ThreadLocal? Request completed event occurs at the very end - including after it is forwarded to the /error page in case of exception...
In a Tomcat environment, the current approach causes the exception to be logged twice: once by the TraceFilter then by the Tomcat valve.

But the Tomcat Valve is not traced isn't it? If that's not the case, can you show an example of using the javax.servlet.ServletRequestListener ?

But the Tomcat Valve is not traced isn't it?

Not sure I understand your question... If that's what you mean, I confirm the exception stack trace logged by Tomcat is NOT traced (reason why you decided to log it first inside the TraceFilter).

can you show an example of using the javax.servlet.ServletRequestListener ?

I had a look at the TraceFilter code and honestly it looks quite complex and I still don't understand why and when a Span must be started/closed/detached/suspended/etc.
It's your comment saying you would have to leave stuff on the ThreadLocal until the end of the request but don't know how to clean it after that made me think about the ServletRequestListener. I posted to share ideas...
I don't have enough Sleuth knowledge for this task I'm afraid - but I would be glad to help if you give me some more explanation about the TraceFilter internals!

Not sure I understand your question... If that's what you mean, I confirm the exception stack trace logged by Tomcat is NOT traced

Yes, you answered my question.

(reason why you decided to log it first inside the TraceFilter).

Yes, that's why this problem is solved and I see no reason to do anything inside Tomcat Valve. With the current approach we instrument any uncaught exceptions regardless whether they are Tomcat or not.

I had a look at the TraceFilter code and honestly it looks quite complex and I still don't understand why and when a Span must be started/closed/detached/suspended/etc - and basically how it works.

Due to the fact that the filter is used in different dispatches, with & without Error controller / Method Handler / Zuul filter it's complex - I agree.

It's your comment saying you would have to leave stuff on the ThreadLocal until the end of the request but don't know how to clean it after that made me think about the ServletRequestListener. I posted to share ideas...

I don't understand the problem. Do we even have one? :P

I don't understand the problem. Do we even have one?

The "problem" is the exception is now logged twice instead of only once.

I see no reason to do anything inside Tomcat Valve

There is nothing todo in the Tomcat Valve... The proposition was to rely on a ServletRequestListener to delay the ThreadLocal cleanup (or Span close if that is the same) until the request is fully processed. The benefit is this listener encompass the entire processing of the request, including all forwards that may happen (like /error) whereas the ServletFilter is possibly invoked multiple times (adding to its "complexity").
Do you want me to create a separate issue for this "double exception logging" stuff?

Another potential issue I'm thinking of is the case of the ClientAbortException thrown by Tomcat when the connection is closed by the client. This exception can happen from within Tomcat itself during the flush of its response buffer at the end of request processing but also from within the application when the response is too large to fit in the buffer. It is not meant to be handled by the application and is therefore a candidate for an "uncatched exception" and is likely to be logged by the TraceFilter too.
Tomcat on the other hand does NOT log this exception because it is considered a "normal" case.

Do you want me to create a separate issue for this "double exception logging" stuff?

I don't agree that this is a problem. We're catching the exception and logging it at a higher level of abstraction.

Tomcat on the other hand does NOT log this exception because it considers it a "normal" case. I have to double check, but if I remember correctly, it won't even forward the request to the error endpoint (does it break assumptions made by the TraceFilter?)...

Please feel free to file another issue and create a sample of what you suggest to be done, maybe that way it will be easier to understand the whole problem.


Starting a timer that ends in the past does not display an error

With the current iteration of the code, the timer now displays "Timer stopped" straight away.


[language][prover] Fixed the parameter of IsValidReferenceParameter

Replaced __frame with __local_counter as the parameter of IsValidReferenceParameter in boogie_type_check in boogie_helpers.rs
Updated the code generation part to emit the result of boogie_type_check before increasing __local_counter
This commit fixes the issue in proving test_borrow2() in verify-vector.mvir

Motivation
To fix the bug that introduces inconsistency by assume IsValidReferenceParameter.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
cargo test
Related PRs

@bors-libra r=DavidLDill

:pushpin: Commit 141d845 has been approved by DavidLDill

:hourglass: Testing commit 141d84512bbb00f22d75637cac88d9b3627f2e7a with merge 47b3b5ecf91a87409001889787bb868bc2d0459c...

:sunny: Test successful - checks-circle_commit_workflow
Approved by: DavidLDill
Pushing 47b3b5ecf91a87409001889787bb868bc2d0459c to master...


Execute the selected query

Pretty handful feature. Thanks for the PR @rodrigowirth 👏 👏 👏
There is only one problem. Your implementation does not work on executing the query through the short key. But no worries, I can fix that 😄


Migrate away from winapi 0.2

Thanks to the new Cargo nightly -Z timings I saw that our 3.5 min Windows release build was spending 65 seconds building just the old winapi 0.2 crate.
The wall time itself, while very high, is not a major problem as this was a larger from scratch build and lots of cores available, but what the timings clearly showed was that it pushed out a lot of build steps because there were tons of small and big crates that had dependencies on winapi 0.2 directly or indirectly and as such couldn't even start until that had been built.
So want to fully get rid of winapi 0.2 crate in our builds and migrate the crates that we are using to the faster and better winapi 0.3 or, in some cases, remove them.
Current crates that use (directly or indirectly) that uses winapi 0.2:

[x] iovec:: This is the most important as huge ecosystem depend on this small crate. PR fix filed
[x] app_dirs: Abandoned crate, switched to app_dirs2 instead and PR fix was merged & published in 7 minutes (!)
[x] mio: In-progress v0.7 is using latest winapi, v0.6 will stay on winapi 0.2. May just have to wait for v0.7?
[ ] notify: Unmaintained crate, leaf dependency so less important but should find alternative or get it updated. Related PR: https://github.com/notify-rs/notify/pull/217
[x] wasmer-runtime-core: From page_size. Is there a more modern/maintained equivalent that they can switch to?
[x] tokio Update to mio 0.7 https://github.com/tokio-rs/tokio/issues/1190
[x] Ecosystem upgrade to new tokio 0.3

Once we have those resolved:, we want to allow be able to disallow winapi 0.2 in our projects:

[x] cargo-deny: https://github.com/EmbarkStudios/cargo-deny/issues/28

Noticed similar results trying out -Ztimings on rust-analyzer while on windows http://gistpreview.github.io/?4a6eafbb1f4786c534143c959876f38f cc @matklad
For notify, it directly uses winapi 0.3; however, its dep kernel32-sys pulls in winapi 0.2. I mentioned this to @rep-nop, and they saw that the calls to kernel32-sys could be easily replaced. I believe they are working on a PR now.
p.s. notify is currently looking for new maintainers https://github.com/notify-rs/notify/issues/209

@memoryruins Awesome thanks! notify is a good library, hope it finds a new good home

notify PR has been merged :)

Maybe it's possible to do the semver tricks and make 0.2 crates reexports of 0.3 one

@repi looks like the iovec fix was merged

Fixing wasmer: https://github.com/wasmerio/wasmer/pull/948

The page_size maintainer finally woke up and merged my pull request, so as soon as wasmer upgrades to a new page_size, we'll be down to a single remaining dependency on winapi 0.2! (mio)

Nice, and mio 0.7-alpha.1 that was released a few days ago has upgraded to winapi 0.3 also. Though likely will take a while for the rest of the stack to use it.
https://tokio.rs/blog/2019-12-mio-v0.7-alpha.1/

mio 0.7 has now been released! Just waiting for tokio to update and use it now and then this can finally be closed and we won't need winapi 0.2 anymore!

Still waiting for tokio to actually upgrade to mio 0.7.
Also noticed that the old winapi 0.2 doesn't support building for aarch64-pc-windows-msvc (Windows on Arm), so this is a blocker for that.

Not that I don't mind getting rid of 0.2, but is Windows Arm actually a relevant target?

@Jake-Shadle in general no 😀 but something I'm personally just curious about experimenting with

Windows Arm might become important in the coming years. Or not. Time will tell.
It's unclear what's holding Tokio up from upgrading though...

New tokio 0.3 released today that finally does upgrade mio to 0.7 🎉 https://github.com/tokio-rs/tokio/blob/master/tokio/CHANGELOG.md#030-october-15-2020
now just need hyper, h2, reqwest, tonic, tower to be upgraded to use and we are good to go :)

Now finally with the major tokio upgrades to 1.0 and mio they no longer bring in winapi 0.2. Unfortunately found 2 more ecosystem dependencies that still bring in old winapi 0.2: winit (event latest 0.24) and notify 0.4 (unmaintained). Soo close, but not solved yet.

Now finally with the major tokio upgrades to 1.0 and mio they no longer bring in winapi 0.2. Unfortunately found 2 more ecosystem dependencies that still bring in old winapi 0.2: winit (event latest 0.24) and notify 0.4 (unmaintained). Soo close, but not solved yet.

notify and winit now use both mio 0.7+, and while we're not using the latest winit in our project yet, the dependency on winapi 0.2 has been removed away from all these crates, so I think we can finally close this! 🥳


Peer to peer review

In this review, we will give suggestions, Appreciate what was done right and ask for changes

Clean codes

no linter errors
professional GitHub workflow
professional documentation
responsive and mobile-first designing


chore: only run validate check on min terraform version

Description

only run validate check on min terraform version

Motivation and Context

we will use max version supported to run all pre-commit checks, but only perform validation on min supported version

Breaking Changes

no

How Has This Been Tested?

static checks

LGTM, but failing. Don't know why. Good night! :)

I think there is no need to struggle and keep this module compatible with 0.12 which is already out of date anyway.

v1.39.0 has been just released.

@antonbabenko Was this not considered a breaking change?  Setting the required terraform version to 0.13 would be a breaking change in my opinion since we cannot update now because of our terraform version.
My other question is why was the required minimum version of terraform incremented anyways?  It does not appear to have any new feature that this module is making use of and is unrelated to the PR unless I am missing something.

@mike-carey You are right, we bumped the version for no obvious reason (no new features being added) but this was necessary for the failing example where 0.13 syntax was used (see failed run).
Yesterday we discussed with @bryantbiggs that we should be able to run examples with a different version of Terraform during pre-commit checks on GH Actions. Once this is supported, we should be able to revert the minimum version requirements on this module to 0.12.26 as it was. Am I right?
@mike-carey Meanwhile, please use v1.38.0 which is for Terraform 0.12.

Understandable @antonbabenko, thanks for clarifying!  The failed build is the part I was missing.  We look forward to a potential revert to the minimum version and have pinned the version in the meantime.

@bryantbiggs Could you make an update to GH Actions to run each examples with a specific version?

@antonbabenko yes, I have it on my todo list - will take a look this weekend

I've opened a PR to revert the module upgrade to 0.13.x while also fixing the CI/CD checks to validate against various min versions of Terraform required depending on the root directory https://github.com/terraform-aws-modules/terraform-aws-lambda/pull/117

v1.40.0 has been just released.
Minumum Terraform version is now back to 0.12.x.
Thanks, @bryantbiggs !


shelf_temperature_status doesn't match between rest/zapi

Verified in 23.02
Compared the shelf_temperature_status metric published by these two pollers - they are identical
bin/poller --poller sar --promPort 12991 --collectors Rest,RestPerf --objects Shelf,Disk
HARVEST_NO_COLLECTOR_UPGRADE=1 bin/poller --poller sar --promPort 12990 --objects Shelf,Disk


Fix server tests

hah you was faster :-P

Thanks for the PR @danielhusar. Yeah maybe by a minute! ;)
Good work though! :+1:


Missing site_id in iis_site

Missing site_id in version (proposed) 3.0.0 iis_site.  Not sure if it's just missing from the readme, or from the module's functionality.

This doesn't seem to be in the module at the moment

Hi. I'm going to close this Issue. We deprecated the module and the new version is available here: https://forge.puppet.com/puppetlabs/iis


Don't require private key with --authorized-key

Is it possible to run upterm host without using private key if I specify --authorized-key?
I want to be able to run something like upterm host --authorized-key <(curl https://github.com/rothgar.keys) without needing local keys.
It would be great if this can be an option or even better if something like --github-user could be an option for authorized keys.

From what I understand, --authorized-key is meant to restrict the users that can connect to your session, not identify the host of the session.

That is my assumption too. I would like to use the published public keys from a github user so if I wanted you to be able to connect to my session I could run
upterm host --github-user MichaelBitard

and it would automatically pull your public key from https://github.com/MichaelBitard.keys

That would be a good idea indeed. The title of your issue is misleading though ;)
The private key is needed to authentify and sign message yourself, the public key is used for the person willing to connect to your host. They are not related. I think you want to open 2 issues, one is a feature request to add --github-user to simplify --authorized-keys mechanism when allowing a github user to connect. The second issue is that you'd like to make the private-key optional, and I don't know if that's possible.

I think I was confused with what a private key was used for but it makes sense since the system running upterm host is creating an ssh session to the upterm server and allowing other clients through that.
I'll rename this ticket for the --github-user flag and another issue to see if there's a way to generate a temporary public/private key if --private-key isn't provided.

Yes, I definitely like the idea of integrating with GitHub and GitLab public keys!

Please, handle private Gitlab instance, too.
Something like --gitlab-user<EMAIL_ADDRESS>and sponge-bob is implicitly<EMAIL_ADDRESS>


feat(volume): hostPath volume type (#781)

Backport
This will backport the following commits from k8s-24/main to k8s-23/main:

feat(volume): hostPath volume type (#781)

Questions ?
Please refer to the Backport tool documentation

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 795

Questions ?
Please refer to the Backport tool documentation


mod_tile appending bug

mod_tile appending relies on the sequenceNumber key saved by the osm2pgsql container instead of the lastAppended key. this can lead to inconsistency.
p.s. new key names will be more than welcome.

The changes made in #19 changed it so osm2pgsql saves its current state into sequence number, so now it should be fixed, but still need to be tested from mod_tile perspective.


reverse communication for rpc client

Motivation:
Explain the context, and why you're making that change.
To make others understand what is the problem you're trying to solve.
Modification:
Describe the idea and modifications you've done.
Result:
Fixes #.
If there is no issue then describe the changes introduced by this PR.

in order to find the method to invoke, we use the same servers for providers and consumers.


fix(nginx): Use relative redirects

This configures nginx to use relative redirects instead of absolute ones, which sidesteps problems about knowing the correct protocol and port to redirect to (which nginx won't necessarily know).
I didn't go for port_in_redirect off; as:

it would break redirects locally
it wouldn't fix nginx redirecting to http:// instead of https:// in D2S

Nice so let me see if I got an understanding of the issue.
At the moment when the user goes to
https://example.com/components/accordion/preview/default
the server response is
location: http://example.com:8080/components/accordion/preview/default/
this PR port_in_redirect off;
should enable us to get this flow
https://example.com/components/accordion/preview/default
the server response should be
location:  /components/accordion/preview/default/

@adamledwards Yep that's right (except the setting is absolute_redirect off; rather than port_in_redirect off;).


Update openai_info.py with gpt-4-0125-preview model

Update openai_info.py with gpt-4-0125-preview model

believe it's already been updated, thank you anyways @ricoms!


Low Draw Distance For Characters

I have already made a request about this (#17 ) and it seems it might not be possible to fix it.

Dupe of #17.


Separate Migration into subdirectories

Currently you can create a migration through the CLI and it will produce a MigrationTS.ts file in a specified migrations directory where it'll run all the sql inside that file.
Is there an example or way to easily configure mikroORM to discover migrations in a structure similar to the one below
Where the migrations.ts file will addSql by reading from the sql files instead.
migrations/
  | Migration20210731000000/
    - tables.sql
    - insert.sql
    - functions.sql
    - Migration20210731000000.ts
  | Migration2021080100000/
    - tables.sql
    - insert.sql
    - functions.sql
    - Migration2021080100000.ts

Nope, not supported, not planned.


Filterable Select

please add search in select dropdown and add new item in dropdown if item not available

Add new button must haved click event

search is working now in select-dropdown-component using filterable prop as it's value is false by default and if user write filterable prop in it, then user can search given data from the options array.
use addNewItem prop, as it's value is false by default and if user write addNewItem prop in it, then user can use add new item option in dropdown if that item is not available there.


Font Missing Issue

Hey man, how are you?
Just got an issue that the system font is missing.

Hi, somratpro.
Hope you are well.
This sometimes happens with snap apps. Can you please try the following procedure to regenerate the font cache?
rm -rf ~/.cache/fontconfig  sudo fc-cache -r -v
If this isn't enough, please try this...
rm -rf ~/.cache/fontconfig  sudo fc-cache -r -v

Can you please try this and the restart the app?
sudo rm /var/cache/fontconfig/* rm ~/.cache/fontconfig/* fc-cache -r

The output doesn't looks good
zsh: no matches found: /var/cache/fontconfig/*

Just did, But the issue doesn't resolve. I don't know what's wrong with it, very frustrating 😑

You can also do this...
find ~/snap/wazzapp/ -name 'fontconfig'
and delete every fontconfig folder it finds.
then
sudo fc-cache -r
If this doesn't work I'll take a better look into it when I get home.
Can you please tell me your OS version?

If you need a quick solution you may try installing the app image from https://lx-dynamics.com/wazzapp-0.3.9.AppImage

I have published a new version that should solve the issue with Manjaro (this distro seems to be having problems with snapcraft and fonts).
If you want to keep using the snap version please run
snap remove --purge wazzapp
and then
snap install wazzapp
and please let me know if it worked. I had to manually patch electron-builder to make it use core20 as base, it's not yet supported by default.

I am sorry to say that, it doesn't work. It's updated to 0.4.1 version. but the issue is the same. maybe it's my pc problem.  I appreciate you bro ❤

Thank you very much bro.
I will install a virtual machine with your distro to see if it works on my side and get back to you as soon as I can.

Hi,
I've installed a VM with Manjaro-Gnome and I was able to reproduce part of the problem. When clicking the about box all I could see was squares.
This is caused by a bug with fontconfig that's been affecting a lot of snaps in fedora and arch base distros like Manjaro.
I used this workaround to get the fonts to display correctly.
rm -r /snap/wazzapp/common/.cache/fontconfig touch ~/snap/wazzapp/common/.chage/fontconfig
This will have the drawback of making the dialog box take a few seconds to display the first time you click it.
I seriously recommend using the AppImage with arch based distros until this issue with fontconfig gets solved, but if you do try the above workaround please let me know if it worked.

Sorry bro, It's not worked. But I still want to use it, because I can't permanently install AppImage, It runs, and when I close it. It needs to sign in again, which is inconvenient.

I made a package specifically for your system, this should sort things out.
You can download it from https://lx-dynamics.com/wazzapp-0.3.9-1-x86_64.pkg.tar.zst
and install it with
sudo pacman -U wazzapp-0.3.9-1-x86_64.pkg.tar.zst

I think it's working.


Can simple elastix register for bmp images?

Hi, everyone. I'm brand new to simpleelastix, I see many images shown in the examples are in 'nii' format. However, what I want to do is to register two 2d x-ray images in the format of 'bmp'. I need to draw the bounding box in the moving image, can someone give me some tips? Really appreciate.
The following is what I have tried, I referenced "Error after run elastix.Execute() #10" on how to register 2d images,  but seems not work:
import SimpleITK as sitk
fixed_image = sitk.ReadImage("001.bmp", sitk.sitkFloat32)
fixedImage2d = sitk.Extract(fixed_image, (fixed_image.GetWidth(), fixed_image.GetHeight(), 0), (0, 0, 0))
moving_image = sitk.ReadImage("002.bmp", sitk.sitkFloat32)
moving_image2d = sitk.Extract(moving_image, (moving_image.GetWidth(), moving_image.GetHeight(), 0), (0, 0, 0))
elastixImageFilter = sitk.ElastixImageFilter()
elastixImageFilter.SetFixedImage(fixedImage2d)
elastixImageFilter.SetMovingImage(moving_image2d)
elastixImageFilter.SetParameterMap(sitk.GetDefaultParameterMap("rigid"))
elastixImageFilter.Execute()
result_image = elastixImageFilter.GetResultImage()
transformParameterMap = elastixImageFilter.GetTransformParameterMap()
result_image = sitk.Cast(result_image, sitk.sitkUInt8)
sitk.WriteImage(result_image, 'result.bmp')
elastixImageFilter.PrintParameterMap()

Yes, you can register bmp. Once your image is read with ReadImage, SimpleElastix does not care in what format the image is stored on disk. To register 2d images, try to set "FixedImagePyramid" and "MovingImagePyramid" to  "RecursiveImagePyramid".

When you are building the code it guesses at what python version you're using.  This means that if you use a different version than what the system uses natively you might run into this error.  The way I did this was to create a virtual environment in my favourite editor (Pycharm).  I then activated the environment in terminal and did the build/make/install steps from there so that SimpleElastix would guess to use the python virtual environment I'm actively using.  The issue is really in the instructions here: https://simpleelastix.readthedocs.io/GettingStarted.html#compiling-on-linux.  If you want to install on a virtual environment you need to do all the steps from there rather than just the last one (as suggested).


visit website provided by http-server

I setup a http-server on Macbook, then perform  "iproxy 8080 8080", finally I need to visit the website on an iPhone, can I directly enter <IP_ADDRESS>:8080 safari it? or write an APP, which wrapped peertalk.
best wish for you ,i am not good at english.:-D

Maybe Safari can't use a connection from other applications.
I tried to make a SSH channel and access the server in a private network, but it doesn't work.


Update In-devops-everything-is-code.md

Hi DevOps is quite a strong concept and should be used (instead of "Development and Operations")
Same for SecDevops


Update Contract npm dependencies

From yarn outdated:

We should update contracts npm deps & retest before next audit to make sure the contracts, tooling, and tests are using the latest and greatest. Of special note is<EMAIL_ADDRESS>

Warning: Updating from<EMAIL_ADDRESS>to 5.6.0 breaks most of the contracts tests, an unknown error is thrown from VerificationGateway.walletProxyAdmin getter.


Render minitoolbox properly in embedded/readonly blockspaces

Small fix to hidden flyout render properly in readOnly blockspaces (ie. not render)
Also disallows dragging blocks out of the mini toolbox if it's readOnly
Before:

After:

Codecov Report

Merging #233 into master will decrease coverage by 0.00%.
The diff coverage is 20.00%.

@@            Coverage Diff             @@
##           master     #233      +/-   ##
==========================================
- Coverage   59.28%   59.28%   -0.01%
==========================================
  Files          95       95
  Lines       11709    11711       +2
==========================================
+ Hits         6942     6943       +1
- Misses       4767     4768       +1

Impacted Files
Coverage Δ

core/ui/block_space/flyout.js
61.71% <0.00%> (-0.17%)
:arrow_down:

core/ui/css.js
94.73% <ø> (ø)

core/ui/block_space/block_space_editor.js
72.30% <100.00%> (+0.07%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61a5b8b...5365c48. Read the comment docs.


Add pub_cache environment variable response code.

Changes
Add pub_cache environment variable response code on Windows platform.
But not include issue.
Please mention issues fixed by this PR here, using format "Fixes #(Issue number)".
Before Committing
Of course, I checked.
Please make sure that you've formatted the files.
dart format .
cargo clippy --fix

Thank you for the PR! I will merge it as soon as it passes the CI tests :)

@rabbitson87 This change is now available in 4.1.4 !


StackOverflowError with object having an array of itself

I have the schema snippet like this
"Something": {
  "type": "object",
  "properties": {
    "someGroup": {
      "type": "array",
      "items": {
        "allOf": [
          {
            "$ref": "#/components/schemas/Something"
          }
        ]
      }
    }
  }
}

It went into infinite loop.
When I change to this
"Something": {
  "type": "object",
  "properties": {
    "someGroup": {
      "type": "array",
      "items": {
        "allOf": [
          {
            "type": "string"
          }
        ]
      }
    }
  }
}

The generation succeeded.

@a819694114 do you mind telling us in which extension you're seeing this error? (server or client)?

Hi, I am using the server extension.


feat: use no internal packages

What this PR does / why we need it: This PR removes all internal packages from gobox to get around a bug with replace in go.mod files.
JIRA ID: DT-0

Notes for your reviewer:

:tada: This PR is included in version 1.7.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Signing in twice invalidates the previous session

Log into Game Play Color on one device
Log into Game Play Color on a second device

The first device will have been logged out.

This issue has been fixed as part of 2.1.3 (a52c5c42ab23fc38f9b425e06a0feea08ee506a6). The issue does not seem to have been directly related to multiple sign ins. Instead it appears we weren't always getting a refresh token from the server.


tv values

Hello,
In the video on Metta around 1', Alexey talk about "tv" values but without explaining what they are (or what "tv" means).
Sorry for the "loose" question, but couldn find the answer.
Regards

ok, truth values of course :=)


[do not review]Update the verify-readme script/template to take a single or multiple paths

The current verify-readme only takes a single path and there's a need, in Java, to be able to scan multiple paths with a single template call. The changes are as follows:

Add the additional parameter for ScanPaths. The reason ScanPath isn't being updated is because I don't want to break/change the existing template uses in the various language repositories. The script will take one or the other but not both ScanPath and ScanPaths.
I overhauled the script adding verification of the inputs, verification that the pip install commands were successful.
For existing pipeline usages, nothing should change.

The following pipelines have been queued for testing:java - templatejava - template - testsjs - templatenet - templatenet - template - testspython - templatepython - template - tests You can sign off on the approval gate to test the release stage of each pipeline. See eng/common workflow

The following pipelines have been queued for testing:java - templatejava - template - testsjs - templatenet - templatenet - template - testspython - templatepython - template - tests You can sign off on the approval gate to test the release stage of each pipeline. See eng/common workflow

The following pipelines have been queued for testing:java - templatejava - template - testsjs - templatenet - templatenet - template - testspython - templatepython - template - tests You can sign off on the approval gate to test the release stage of each pipeline. See eng/common workflow

The following pipelines have been queued for testing:java - templatejava - template - testsjs - templatenet - templatenet - template - testspython - templatepython - template - tests You can sign off on the approval gate to test the release stage of each pipeline. See eng/common workflow


Continuous Crashing of JS/TS Language Feature Initialization

Type: Bug
Description:
In Visual Studio Code, I am experiencing a recurring issue where the label "Initializing JS/TS language feature" continuously flickers. This behavior seems to interfere with the correct recognition of JSDoc types in the code. Although temporarily resolved by reloading the VSCode window, the problem resurfaces after some time.
Steps to Reproduce:

Open VSCode.
Begin working with JavaScript or TypeScript files.
Observe the "Initializing JS/TS language feature" label flickering.

Expected Behavior:
The label should stabilize once the JS/TS language features are fully initialized, and the JSDoc types should be correctly recognized without any interference.
Actual Behavior:
The label does not stabilize and keeps flickering. This issue appears to affect the correct recognition of JSDoc types in the code.
Temporary Workaround:
Reloading the VSCode window temporarily resolves the issue, but it reoccurs after some time.
VS Code version: Code 1.85.1 (0ee08df0cf4527e40edc9aa28f4b5bd38bbff2b2, 2023-12-13T09:49:37.021Z)
OS version: Windows_NT x64 10.0.22621
Modes:

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-10700T CPU @ 2.00GHz (16 x 1992)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: enabled_ondirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: enabled

Load (avg)
undefined

Memory (System)
15.78GB (6.02GB free)

Process Argv
--crash-reporter-id ad47fbb3-d2fa-4f03-896c-9fc5e954e853

Screen Reader
no

VM
0%

Extensions (13)

Extension
Author (truncated)
Version

jsonl
Alp
0.0.1

gitlens
eam
14.6.1

vscode-postman
eri
2.1.0

code-runner
for
0.12.1

copilot
Git
1.143.0

copilot-chat
Git
0.11.1

vscode-github-actions
git
0.26.2

rest-client
hum
0.25.1

vscode-edit-csv
jan
0.8.3

rainbow-csv
mec
3.9.0

mongodb-vscode
mon
1.3.1

vscode-language-pack-it
MS-
1.85.2023121309

vscode-thunder-client
ran
2.16.3

A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
vserr242:30382549
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vsdfh931cf:30280410
vshan820:30294714
vstes263:30335439
vscoreces:30445986
vscod805:30301674
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593:30376534
pythonvs932:30410667
py29gd2263:30899288
vsclangdf:30486550
c4g48928:30535728
dsvsc012cf:30540253
azure-dev_surveyone:30548225
89544117:30613380
2i9eh265:30646982
showlangstatbar:30737416
962ge761:30917236
fixshowwlkth:30771522
showindicator:30805244
pythongtdpath:30769146
i26e3531:30792625
welcomedialog:30910333
pythonidxpt:30866567
pythonnoceb:30805159
asynctok:30898717
dsvsc013:30795093
dsvsc014:30804076
dsvsc015:30845448
pythontestfixt:30902429
pyreplss1:30897532
pythonmypyd1:30879173
pythoncet0:30885854
pythontbext0:30879054
dsvsc016:30899300
dsvsc017:30899301
dsvsc018:30899302
aa_t_chat:30882232
cp7184t:30925682

i also receive this message "The JS/TS language service crashed 5 times in the last 5 Minutes."

Same issue on VS Code insiders build. Here the crash report.

CPUs | 12th Gen Intel(R) Core(TM) i9-12900 (24 x 2419)
-- | --
GPU Status | 2d_canvas: enabled canvas_oop_rasterization: enabled_on direct_rendering_display_compositor: disabled_off_ok gpu_compositing: enabled multiple_raster_threads: enabled_on opengl: enabled_on rasterization: enabled raw_draw: disabled_off_ok skia_graphite: disabled_off video_decode: enabled video_encode: enabled vulkan: disabled_off webgl: enabled webgl2: enabled webgpu: enabled
Load (avg) |
Memory (System) | 31.71GB (11.07GB free)
Process Argv |
Screen Reader | no
VM | 0%

Extensions: none
vsliv368:30146709
vspor879:30202332
vspor708:30202333
vspor363:30204092
vsc_aa:30263845
vscod805:30301674
vsaa593:30376534
py29gd2263:30784851
c4g48928:30535728
vscrp:30624060
962ge761:30841072
pythongtdpath:30726887
welcomedialog:30812478
pythonidxpt:30768918
pythonnoceb:30776497
asynctok:30898717
dsvsc013:30777762
dsvsc014:30777825
dsvsc015:30821418
pythontestfixt:30866404
pythonregdiag2:30926734
pyreplss1:30879911
pythonmypyd1:30859725
pythoncet0:30859736
pythontbext0:30879054
accentitlementst:30870582
dsvsc016:30879898
dsvsc017:30880771
dsvsc018:30880772
pydisww1:30959800
edj9j583:30943796
fegfb526:30952798
7j2b6412:30951517
e3gdj431:30946825
ccp1r6:30958151

Hey @mjbvz, this issue might need further attention.
@alessandroBoschiero, you can help us out by closing this issue if the problem no longer exists, or adding more information.

The problem persists and occurs as soon as a file with the “.jsw” extension is opened.

Please share repo steps with that file type

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


337 additional - correct selected fields font style

Adjust placeholder text color for selected fields

Change text color back to #aaa from #517B98 for selected fields
declare separate styles for placeholder only

 Placeholder Text: Find outside Coastline and Adjust color


Add 10 file system-based persistence techniques

Add 10 file system-based persistence techniques.
All rules have a reference to an online resource describing the technique.
This PR requires https://github.com/mandiant/capa-rules/pull/952 to be merged.

LGTM!
Leaving this open for 1-2 more days to give Mike and Willi a chance to chime in if they want.

🎉


[e2e]: gradle workflow_dispatch main default slsa3

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/6471246641
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.gradle.workflow_dispatch.main.default.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.gradle.workflow_dispatch.main.default.slsa3.yml
Trigger: workflow_dispatch
Branch: main
Date: Tue Oct 10 15:16:18 UTC 2023

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/6484457747
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.gradle.workflow_dispatch.main.default.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.gradle.workflow_dispatch.main.default.slsa3.yml
Trigger: workflow_dispatch
Branch: main
Date: Wed Oct 11 15:15:15 UTC 2023

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/6497511668
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.gradle.workflow_dispatch.main.default.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.gradle.workflow_dispatch.main.default.slsa3.yml
Trigger: workflow_dispatch
Branch: main
Date: Thu Oct 12 15:15:09 UTC 2023

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/6518404259
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.gradle.workflow_dispatch.main.default.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.gradle.workflow_dispatch.main.default.slsa3.yml
Trigger: workflow_dispatch
Branch: main
Date: Sat Oct 14 15:13:33 UTC 2023

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/6524840432
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.gradle.workflow_dispatch.main.default.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.gradle.workflow_dispatch.main.default.slsa3.yml
Trigger: workflow_dispatch
Branch: main
Date: Sun Oct 15 15:13:56 UTC 2023

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/6535571752
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.gradle.workflow_dispatch.main.default.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.gradle.workflow_dispatch.main.default.slsa3.yml
Trigger: workflow_dispatch
Branch: main
Date: Mon Oct 16 15:16:22 UTC 2023

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/6549189337
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.gradle.workflow_dispatch.main.default.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.gradle.workflow_dispatch.main.default.slsa3.yml
Trigger: workflow_dispatch
Branch: main
Date: Tue Oct 17 15:15:59 UTC 2023
Tests are passing now. Closing this issue.


Error with webdriver

I folowed al the steps, but I get this when executing:
(ERROR) [init->_run_job]: Task failed: Traceback (most recent call last):
File "/opt/needl/needl/schedule/init.py", line 84, in _run_job
ret = job.run()
File "/opt/needl/needl/schedule/init.py", line 336, in run
ret = self.job_func()
File "/opt/needl/needl/tasks/google.py", line 17, in search
browser = utils.get_browser()
File "/opt/needl/needl/utils.py", line 60, in get_browser
return webdriver.Chrome(executable_path=chromedriver, chrome_options=chrome_options)
File "/home/hernan/.local/lib/python3.5/site-packages/selenium/webdriver/chrome/webdriver.py", line 62, in init
self.service.start()
File "/home/hernan/.local/lib/python3.5/site-packages/selenium/webdriver/common/service.py", line 96, in start
self.assert_process_still_running()
File "/home/hernan/.local/lib/python3.5/site-packages/selenium/webdriver/common/service.py", line 109, in assert_process_still_running
% (self.path, return_code)
selenium.common.exceptions.WebDriverException: Message: Service /opt/needl/data/chromedriver unexpectedly exited. Status code was: 127
Is there anything else that I should do to the driver?
Thanks!

@HFsi what system are you on? If you execute chromedriver from your terminal do you get something like:
Starting ChromeDriver 2.33.506106 (8a06c39c4582fbfbab6966dbb1c38a9173bfb1a2) on port 9515
Only local connections are allowed.

I´m running Ubuntu Server 17.10.
I tried start, ./, chromedriver...but can´t getting to work....Which is the command to execute it?
Sorry, I´ve very basic understanding o Linux commands...
Thanks

It sounds like you have the wrong version of chromedriver. Download for your system and architecture and try again.


Bug in "dim_zero_cat" reduction "Metric._reduce_states(...)"

🐛 Bug
The function Metric._reduce_states(...) is supposed to concat states when told to use "cat", but instead tries to add.
To Reproduce
Try to update metric states initialized with dist_reduce_fx='cat'
First define the metric states in the Metric class init function
# base class for metrics requiring an optimal threshold (like EER, BPCER@APCER1%)
class OptimalThresholdMetrics(Metric):
    # .............

    def __init__(self, iter_max=100, tolerance=0.01) -> None:
        super().__init__()

        # ................

        self.add_state("preds", default=torch.tensor([]), dist_reduce_fx='cat')
        self.add_state("targets", default=torch.tensor([]), dist_reduce_fx='cat')

And then, when trying to update the metric with
metric_output = self.train_metrics[0](preds, targets)

I get some sort of dimensionality error (I don't remember the exact message) because Metric._reduce_states(...) tries to add the states instead of concatenating.

Expected behavior
When passing dist_reduce_fx='cat' metric states are supposed to be concatenated when updated, not added.
Environment
I encountered the bug in torchmetrics v1.2.0 installed via pip, but it can also be found in the current master branch
Additional context

How to fix
In src/torchmetrics/metric.py method Meric._reduce_states(...), it currently says
elif reduce_fn == dim_zero_cat:
    reduced = global_state + local_state

instead it should say something like
elif reduce_fn == dim_zero_cat:
    reduced = torch.cat([global_state, local_state])

I created a pull request with my fix. I don't know if I followed the guidelines correctly though (i requested a pull into the master branch if that's okay).


Support FunctionInvoker to allow override convertEvent and convertOutput

I am using generic org.springframework.cloud.function.adapter.aws.FunctionInvoker of spring-cloud-function-adaptor-aws-3.0.8.RELEASE.jar as request handler to invoke my function. But this class ties APIs and models to be AWS specific events rather than simple POJO based input/output for functions.
For example am trying to use SQS Event to trigger the lambda and using this class expects my function to be having input as com.amazonaws.services.lambda.runtime.events.SQSEvent instead of my simple POJO class. There is nothing wrong with this approach other than it creates a hard dependencies on my functions which could have been simpler, my tests (junit and integration tests) could be much simpler to have domain POJO based implementation. If this class can expose the methods as protected for input/ouput conversion (currently it's put under private method) then we can subclass and override it with as per need and use it effectively.
Having said that it's also worth to note that I can very well do this by extending org.springframework.cloud.function.adapter.aws.SpringBootRequestHandler with my own input/output conversion. With my extended class/handler am converting SQSEvent to my POJO by overriding convertEvent method. It also allows me to define a generic output object which wraps my function output with adding some more context information (like correlation-id etc).
I will be happy to share further code details if it would help to understand the issue. Please let me know.

The .aws.FunctionInvoker is by design specific to AWS. We have the same in Google etc.
What you're looking for is conversion of inputs and outputs from raw representation to POJO which is also supported already in Spring Cloud Function and is one of the extension points.
That said, i'll keep this issue open with the idea to provide clear documentation on how to do it as well as add tests that would aside from validation would serve as an example.

thank you !!! @olegz for the details, sounds like a plan.

You can see details from commit message, but basically I've added documentation on type conversion and how to extend it (user defined converters)
There is also a test and few fixes went into the actual FunctionInvoker


Add onDataChange hook and expose useful API endpoints

Hi,
Let's suppose you have a UI with a list of items and an edition form. A click on an item in the list triggers its edition in the form. And there is a "new item" button.
For me this is a fairly common usecase, and this package would be really great if it allowed to do that easily.
I tried but this is really painful for now :

I had to enable passThroughData on all the elements I use, to support changing the document reactively, but this feature was not designed for that.
There is no way to reset the form when the "new item" button is clicked, and no way to reset form state when changing the item being edited because the reset callback is only available in the action function.
When you switch to an item where some fields are absent, form elements are not cleared, they keep the data of the previous item.

I tried to think about a good and unobtrusive way to implement this feature...
There should be a way to tell the form component that the document has changed, and when this happens it must :

reset form state
populate the new current data, whether or not passThroughData is enabled, and reset missing fields

The simplest solution would be to make it an "alternate mode" of handling any change of the reactive data. But you could not have this and the current in-document reactive changes handling at the same time...
A better way would be to be able to specify one variable in data that identifies the document : when it changes, it means the document has changed, when it does not exist, it means we're starting a new document → full reset.
There would be an API like that :
ReactiveForms.createFormBlock
    template: 'myItemForm'
    dataID: '_id' # When data._id changes, the form will be "reset" with the new initial data

So, 1 one line for the user, but clearly some work to do on the package...
What do you think of it ?

This is a good idea. Let me think about this for a bit. I don't think it will be too hard to add.

I think what you're really looking for here is a hook that's called when underlying data changes and gives you access to some useful methods. Like this:
ReactiveForms.createFormBlock
  onDataChange: (oldData, newData) ->
    if oldData._id isnt newData._id then @reset(true)

Or even a function you pass in via template helpers, like:
{{#myFormBlock
  data=data
  action=action
  schema=schema
  onDataChange=onDataChange}}
  ...
{{/myFormBlock}}

What do you think?

That seems great. I agree the helper function is better.
After the reset, we need a way to say explicitly that we want to use the new data, even if passthroughData is not enabled. Either a @setData(newData) method or simply returning true in the hook...

This is coming along. Should have an update out in the next day or two.

Any news on that ?

This should be working in the latest release. Please see the changelog and test it out. Thanks!

It works great !
One issue though : How do you clear elements changed state ? this.reset(true) does not seem to do it.

I'll add this today, not a problem.


Adding edge animations

I created an edge animation plugin and edited canvas renderer's edge definitions to support animated edges.

I'll convert this to a plugin and re-request


cmd/internal/obj/arm: add TST, TEQ instruction

5l seems to explode on the TST instruction

        TST $3, R0

5a is quite happy to assemble this, but 5l then produces

main.tst: illegal combination TST C_RCON C_REG C_NONE, 8 1
(3) TST $3,R0,
main.tst: illegal combination TST C_RCON C_REG C_NONE, 8 1
(3) TST $3,R0,

I conjecture this might be easy to fix since the very similar TEQ instruction works fine.

-------------------

What steps will reproduce the problem?

Save the attached files into a temporary directory

Run

GOARCH="arm" GOOS="linux" go build

What is the expected output?

Nothing (it compiles)

What do you see instead?

# _/tmp/tst
main.tst: illegal combination TST C_RCON C_REG C_NONE, 8 1
(3) TST $3,R0,
main.tst: illegal combination TST C_RCON C_REG C_NONE, 8 1
(3) TST $3,R0,

Which compiler are you using (5g, 6g, 8g, gccgo)?

5a & 5l

Which operating system are you using?

Cross compiling for arm linux on amd64 linux

$ go-linux-arm env
GOARCH="arm"
GOBIN=""
GOCHAR="5"
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/ncw/Code/Go"
GORACE=""
GOROOT="/home/ncw/Code/go"
GOTOOLDIR="/home/ncw/Code/go/pkg/tool/linux_amd64"
CC="gcc"
GOGCCFLAGS="-g -O2 -fPIC -marm"
CGO_ENABLED="0"

Which version are you using?  (run 'go version')

go version devel +77be25034f84 Fri Jul 19 01:22:26 2013 +0400 linux/amd64
Attachments:

tst.s (74 bytes)
tst.go (49 bytes)

Note that there is a TST that means something else.

I believe this can be closed now since this is a duplicate of #21583 which was just closed via:
https://go-review.googlesource.com/c/go/+/67490

Fixed by https://golang.org/cl/67490


After getting PTB to work with BDA the CustomCSS is broken

So lets just say you have a Custom CSS in Discord Canary and/or Discord and you get PTB working.
All of your CSS work would become just these 2 chars in that box.
ée.
@Jiiks pl0x fix this.

atob issue with empty data https://developer.mozilla.org/en-US/docs/Web/API/WindowBase64/atob


What's the reason for the prompt "TAS not find adapter"?

The servantObj in your code may be different from the configuration. Check carefully that the characters in the addServant corresponding to your Server.cpp should be consistent with the web platform configuration.

可能你代码中的servantObj与配置的不一样，仔细检查下你Server.cpp对应addServant 中填的字符要跟web平台配置的一致。


Parse override(list) syntax on variable definition

The parser does not parse an override list specified on a variable definition
The override list may be specified via an import path.

Found in #787

Diagnostics.push is by far the function we call the most in Solang. Adding a vector traversal there will degrade performance. You should either create a new function that does not allow duplicate insertion of warnings or change the way you check for duplicates.
I believe that most warnings do not require checking for duplicates.

So now I've change it, so that:

All the diagnostics are sorted by file location, level and then message
deduplicates are moved

This is done once.


If we use markdownIt plugin, export doesn't work

Observed the same behavior on my obsidian client, as well.


recursivelyGarbageCollect error

trying to upgrade from v0.4.14 to v1 or v2, I got the error below.
The code raising the error just adds a new listener after removing some others by calling the removeAllListeners method multiple times.
There is no error if I comment the removeAllListeners part in my code.
/[***]/node_modules/eventemitter2/lib/eventemitter2.js:623
        if (Object.keys(obj).length > 0) {
                   ^
TypeError: Cannot convert undefined or null to object
    at recursivelyGarbageCollect (/[***]/node_modules/eventemitter2/lib/eventemitter2.js:623:20)
    at recursivelyGarbageCollect (/[***]/node_modules/eventemitter2/lib/eventemitter2.js:624:11)
    at recursivelyGarbageCollect (/[***]/node_modules/eventemitter2/lib/eventemitter2.js:624:11)
    at recursivelyGarbageCollect (/[***]/node_modules/eventemitter2/lib/eventemitter2.js:624:11)
    at EventEmitter.off (/[***]/node_modules/eventemitter2/lib/eventemitter2.js:631:5)
    at EventEmitter.listener (/[***]/node_modules/eventemitter2/lib/eventemitter2.js:252:14)
    at EventEmitter.emit (/[***]/node_modules/eventemitter2/lib/eventemitter2.js:348:22)
    at EventEmitter.end (/[***]/modules/hook.js:253:27)
    at EventEmitter.emit (/[***]/node_modules/eventemitter2/lib/eventemitter2.js:348:22)
    at end (/[***]/modules/deploy.js:396:31)

Oh weird. I'm a bit busy this week, but a PR with a unit test would be appreciated. All that needs to be added is a check to make sure that obj isn't falsy on this line in addition to the other checks.
The unit test should just have the minimal code used to reproduce this issue. (I'm guessing a call to removeAllListeners in the same way you did it would be enough)

sorry but I won't be able to write the unit test
My first description was incomplete, you need to emit an event which will be receive by a once listener, just after removing another listener. Also the wildcard option must be set
here is a sample code to reproduce the issue :
var EventEmitter2 = require('eventemitter2').EventEmitter2;
var eventemitter = new EventEmitter2({ wildcard: true });

eventemitter.on('test1', function(data) { console.log(data); });
eventemitter.once('test2', function(data) { console.log(data); });

eventemitter.emit('test1','test1');
eventemitter.removeAllListeners('test1');
eventemitter.emit('test2','test2');

Hopefully I'll have time sooner than later to fix it up, then. :D Thanks for reporting it!


WYSIWYG HTML editor on popup form

I would like to use a popup form as grid editor. There are some text input and a textarea on the form. It is working
I would like to convert textarea to HTML editor but is not working.
I tried several HTML WYSIWYG editor (jqte, Froala etc.).  My problem is how can I use it with w2ui?
It is not rendering on w2ui form.

Can you please provide a Fiddle/Bin/Pen to demonstrate the issue?

Closing issue: no response


mvn fabric8:run vs mvn package fabric8:resource fabric8:build fabric8:push fabric8:deploy

I was previously using the fabric8:run maven goal but I'm not sure if its correct as the https://maven.fabric8.io/ docs don't reference it?
It is mentioned in the quickstart readme though https://github.com/fabric8-quickstarts/spring-boot-camel#running-the-example-in-kubernetes
FWIW I find
mvn fabric8:run fabric8:push -Ddocker.push.registry=my.registry

simpler to get going than the below
mvn package fabric8:resource fabric8:build fabric8:push fabric8:deploy -Ddocker.push.registry=my.registry

If the full maven goals are required maybe we should have a TL;DR at the top of https://maven.fabric8.io/ to deploy an app?

Hi Rawlings. I also noticed that fabric8:run is undocumented, which is unfortunate as it is the only way I've managed to get the Fabric8 Maven Workflow to work with my OpenShift Origin server.
The OpenShift docs recommend using pre-configured maven profiles.
mvn -Pf8-build
Comprises of clean, install, docker:build, and fabric8:json. This will build dockerfile and JSON template for a project.
mvn -Pf8-local-deploy
Comprises of clean, install, docker:build, fabric8:json, and fabric8:apply. This will create docker and JSON templates and then apply them to OpenShift.
mvn -Pf8-deploy
Comprises of clean, docker:build, fabric8:json, docker:push, and fabric8:apply. This will create docker and JSON templates, push them to docker registry and apply to OpenShift.
Would these be applicable for your situation? I don't think you are using OpenShift but the concepts may be similar.

Those are for the 2.x maven plugin, they don't apply to 3.x
JamesR the main difference between fabric8:run and fabric8:deploy is that the former forks the install goal (which in turn calls the favric8:resource goal to generate the kubernete & openshift manifests and fabric8:build to create the docker image - a regular mvn install will invoke those two)
So mvn fabric8:run == mvn install fabric8:deploy

Thanks for the idea @LewisWatson but yeah it's the f-m-p 3.x that I'm looking at which doesn't work for those profiles.
@jstrachan ok cool that makes sense, so fabric8:run is totally valid and just missing from the https://maven.fabric8.io/ docs.  Just wanted to confirm as I'm updating some examples and wasn't sure.

mvn fabric8:resource generates the manifests
mvn fabric8:build builds the docker image
mvn install generates the resources and builds the docker image
mvn fabric8:deploy applies the manifest
mvn fabric8:run generates the resources and builds the docker image and applies the manifest

Closing as it makes sense now.  Also discussed in more detail in https://github.com/fabric8io/fabric8-maven-plugin/issues/289#issuecomment-242679954


Include more default hdfs libs

by default, include 2.8, 2.9, 3.2 for emr and dataproc

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-PR-Builder/11138/
Test PASSed.

@LuQQiu PTAL

alluxio-bot, merge this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-PR-Builder/11139/
Test PASSed.


ProgressHud appearing under RaisedButton

Whenever I try to show progressHud (i.e: MBProgressHUD) it shows under the raised button, I know it's not an issue with your library but do you have any idea of how can that be fixed?
See screenshot below

Fixed that with the following:
            let hud = MBProgressHUD.showHUDAddedTo(self.view, animated: true)
            hud.layer.zPosition = 2;
            raisedButton.layer.zPosition = 1;

For the raisedButton, you don't need to use the .layer.zPosition property. You can do raisedButotn.zPosition :) Great that you fixed it.


insert original price and offer price from product_items table rather than passing json in create order

also check product_item_status is published or not


Add migrate command to docs

As title, I've seen this question several times lately.
Feel free to suggest amendments, there's not much to explain about the sub-command. It has no extra options.

I also added the gitea convert command to the docs. Same as migrate, there's not much to explain about it other than re-iterating the help-text.

Codecov Report

Merging #8842 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #8842      +/-   ##
==========================================
- Coverage   41.23%   41.23%   -0.01%
==========================================
  Files         543      543
  Lines       69785    69785
==========================================
- Hits        28779    28773       -6
- Misses      37320    37324       +4
- Partials     3686     3688       +2

Impacted Files
Coverage Δ

modules/avatar/avatar.go
48% <0%> (-6%)
:arrow_down:

modules/process/manager.go
78.37% <0%> (-4.06%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45f2192...0d9bf25. Read the comment docs.


Cleanup tutorials

I went through the tutorials and tried to clean them up a bit.  Originally, I just wanted to add some repetition to reinforce the commands but then I got carried away and kept tweaking things.  I don't think my changes will offend anyone, but who knows.
The changes I made:

I re-arranged the tutorials so all the "motions" come before editing a file (Insert Mode).  I also re-arranged the motions to follow (what I consider) a more logical flow.  It goes from h/j/k/l to w/e/b to 0/$/_, then to gg/G and search.  In my mind, this goes from smaller-jumps to larger-jumps and simple movements to more complex movements.
The w/e/b tutorial was using 0/$ when those already have a dedicated tutorial for them.  And after my re-arranging, w/e/b came before that tutorial.  I removed all references of 0/$ in w/e/b to remove confusion.
Changed "Motion and Insert" to be "Insert and Undo".  Since all the motion tutorials are non-destructive, I wanted them to be before any edits to the file.  I also wanted to make sure we taught undo as soon as we taught destructive changes so the user can undo any mistakes when trying to complete later tutorials.  Sometimes you can modify the wrong text and without u there's no way to successfully complete the tutorial.
Added some repetition to the ChangeOperator tutorial.  I had just thrown together the tutorial with a single example so I could reference change in my VisualMode tutorial.  Now it has a couple more uses of cw for reinforcement.
Added some repetition of xp to the CopyPaste tutorial.  Again, I originally only had one example of this and it was the last item in the tutorial so the "you win" animation played before you could even see what xp had changed.
Fixed some issues in the MoveAndInsert/InsertAndUndo tutorial where the marker was claiming success before you entered a space after the added word.  This was throwing me off because it claimed I had completed the step but then wasn't matching the text in the next step so I couldn't complete the tutorial.
Cleaned up the wording in Search tutorial to be more descriptive in case this is the user's first introduction to search mode.

Just played through these w/ the updates, nice! 👍 Thanks for taking a holistic look across the tutorials.

I re-arranged the tutorials so all the "motions" come before editing a file (Insert Mode). I also re-arranged the motions to follow (what I consider) a more logical flow. It goes from h/j/k/l to w/e/b to 0/$/_, then to gg/G and search. In my mind, this goes from smaller-jumps to larger-jumps and simple movements to more complex movements.

I like the progression, seems reasonable to me!

Changed "Motion and Insert" to be "Insert and Undo". Since all the motion tutorials are non-destructive, I wanted them to be before any edits to the file. I also wanted to make sure we taught undo as soon as we taught destructive changes so the user can undo any mistakes when trying to complete later tutorials. Sometimes you can modify the wrong text and without u there's no way to successfully complete the tutorial.

Yes, good catch - makes sense to bring up undo here.
Really appreciate you looking at the overall flow. I do like the added repetition for the commands - I think that is important for building up that 'muscle memory'! Nice work @keforbes !


mim install mmdet

I install mmdet with suggested command mim install mmdet, but there are still compatibility issues as
AssertionError: MMCV==1.4.3 is used but incompatible. Please install mmcv>=1.2.4, <=1.4.0.
mmdet version in my computer is mmdet-2.20.0

Can you post your mmdet/__init__.py?


Would you be interested in a feature to shuffle queues?

We'd like to add a test case to our code to simulate that amazon sqs returns messages in a different order than pushed, since the documentation says that although it's not common, they don't guarantee order.
Before adding that code to my application or making a "private" fork of moto, I wanted to ask you if you'd be interested in a PR with a feature that does that (shuffle the queues)
Regards

Because we keep the API strictly limited to only the actual AWS API I don't think we'd want a special API call (either internal or external) to shuffle the queues.
However, since out-of-order messages is indeed part of the SQS contract I think it would be great if, whenever at least a certain number of messages are in a queue (say, 10) that queue is shuffled. This would let you test the behavior you want and also not violate any assumptions other developers have. If anything it may harden many apps against the realities of AWS.
What do you think?

Considering the lack of response here, and lack of upvotes/+1's, I'm going to assume this is not (or no longer) useful for people, so I'll close this.


implement suspend/resume for KubernetesContainer

We can implement suspend and resume for KubernetesContainerPool by delegating the operations to an invoker-agent that runs as a DaemonSet on every invoker node.  The invoker-agent interacts with the local docker/containerd engine to pause/unpause containers as directed by the invoker.
This PR contains the OpenWhisk core changes to implement this design.  It assumes an invoker-agent as implemented in https://github.com/apache/incubator-openwhisk-deploy-kube/pull/155.  The main changes in this PR are:

Add configuration for the invoker-agent to application.conf (default to disabled).
Implement suspend/resume by delegating to the invoker-agent
Change the implementation of container creation to use the kubeRestClient to create the containers instead of using the kubectl command line.  As part of creation we now extract and save the workerNode IP information in the KubernetesContainer to cache the information needed to communicate with the invoker-agent.
Update test cases for changes in the KubernetesClient API.

If you look into the invoker-agent code in openwhisk-deploy-kube code, you will see that it also support log consolidation.   I plan to submit a separate PR for the openwhisk core side of the logging changes (because it also includes a modest refactor to the logging implementation that should be reviewed separately from the Kubernetes-centric changes in this PR).

@jcrossley3 @bbrowning @bwmcadams  Please review proposed k8s changes.  Thanks.

PG3 / 1913 🔵

rebased to latest master and consolidated small commits made while addressing review comments.


Tooltip floats to top of page in docs when "copy is clicked"

https://github.com/twbs/bootstrap/blob/e153e5f5b2b82ad09a9874b8ff1dfca986790f76/site/assets/js/application.js#L144
https://github.com/twbs/bootstrap/blob/e153e5f5b2b82ad09a9874b8ff1dfca986790f76/site/assets/js/application.js#L156
replace lines above with
tooltipBtn.update() //call to positional update
tooltipBtn.show() //then call to show
Real small.. lol but was just in the docs today and noticed. Hope this is helpful.

Duplicate of the other toolip issues.


Support "not" in a way that conveys useful information for humans

While doca is not a validator, "not" can be used to express conditions that should appear in documentation.  This was requested for doca's predecessor project at cloudflare/json-schema-docs-generator#13.
We definitely do not want to just document the schema under "not" the same way we do schemas that express positive constraints.  There needs to be some thought on what is actually useful for human-oriented documentation here, as opposed to programmatic validation.
@swamikevala if you are still interested in this with doca, can you go into your use case a little bit more?  The example given seemed like it was trying to do something like:
{
    "allOf": [
        {"required": ["foo"]},
        {"not": {"required": ["foo"]}}
    ]
}

where the first entry was shown as a "$ref".  If this is what the "$ref" resolved to, it is an impossible schema- any object that has a "foo" property will pass the first and fail the second, and it's the other way around if there is no "foo" property.  So perhaps I am misunderstanding your use case?

This set of packages is being deprecated in favor of the JSON Schema Tools monorepo.  Contributions are still welcome here but most work will be done on the new packages.
The new UI is still being designed, but hopefully this should be handled in it (although as no one has really asked for it, it may not be in the initial batch of work).  Feel free to file at cloudflare/json-schema-tools if you want to track this specifically.


Unable to Build

Hi, I had one issue in the code. And I changed it, but whenever I am trying to build the code by running sudo make install after make it never runs. I have go installed but still it give me some errors.
/bin/bash: line 1: go: command not found
/bin/bash: line 1: go: command not found
install -m 0755 cog /usr/local/bin/cog```

when I run `go version` I get:
```go version go1.18.3 linux/amd64```

Hi @arnavmehta7. I'm sorry to hear that you're having trouble building from source. Please run the following commands on your machine and share the output:
$ which go                      # reports location of Go executable in PATH
$ which python                  # reports location of Python executable in PATH
$ make make VERBOSE=1 clean cog # make cog from clean state
$ ./cog --version               # run cog executable created from previous step

Thanks. I have fixed this. I had to add go path in visudo.


Download script do not work - missing RS_* files

The reddit.py script does not work anymore, because the submission files (with filenames starting with RS) are no longer available on pushshift.io. Therefore it is not possible to download and generate the data.

Hi, I am facing a similar issue. It would be great if the dataset is made available.
Thanks,
Rajdeep

This repository is no longer supported.
You can see what this HuggingFace dataset has to offer
Or you can modify to code yourself to read .ZST files.


Compiled app doesn't start

Bug report
I've been trying to understand this all day. If I specify runtimeChunk, and (maybe?) it gets minified my app doesn't start. If I comment out runtimeChunk my app starts. The sources all look okay and are loading, but the entry point doesn't exec.
What is the current behavior?
Blank screen after build.
If the current behavior is a bug, please provide the steps to reproduce.
I've been trying to isolate this but haven't yet. I'm sorry. I just wanted to get this out there hoping someone else has ideas.
What is the expected behavior?
the entry point should execute.
Other relevant information:
webpack version:  5.26.3
Node.js version: 15.12.0
Operating System: linux
Additional tools:

Sorry, information is not enough to help you, maybe you forget to add something to your HTML file

I has same problem on rebuild on watch mode or build when not have previous build
Problem started after upgrade to 5.26.0, in version 5.25.1 all working fine

@vadimka123 Maybe you can create example?

hey Guys,
I'm using MacOS and also have similar issue. My teammates don't have it on linux.
So we upgraded our webpack to the version "webpack": "5.26.3" and the initial build is ok but the rebuild is broken.
Here is command
webpack --progress --watch --mode development

when I apply some changes to the file, my webpack does rebuild automatically and I'm getting blank screen without any errors in console.
How I fixed this issue temporary. I reverted my webpack to the version "webpack": "5.25.1" and on this version everything works well. Perhaps 5.26.0 works also fine, I just didn't check that.
webpack config looks like
module.exports = {
	mode: NODE_ENV,
	entry: ['./app/App.jsx'],
	output: {
		path: buildDir,
		filename: DEBUG_ON ? '[name].[fullhash].js' : '[name].[contenthash].js',
		publicPath: cdn_url + '/build/',
	},
	watchOptions: {
		ignored: /node_modules/,
		aggregateTimeout: 300,
	},
	plugins: plugins,
	devtool: DEBUG_ON ? 'eval-source-map' : 'source-map',
	resolve: {
		alias: {
			ringlead_utils: path.resolve(__dirname, 'app/utils'),
		},
		extensions: ['.js', '.jsx'],
		fallback: { url: false },
	},
	optimization: {
		runtimeChunk: 'single',
		splitChunks: {
			automaticNameDelimiter: '.',
			chunks: 'all',
			maxAsyncRequests: 10,
			maxInitialRequests: 10,
			cacheGroups: {
				defaultVendors: {
					reuseExistingChunk: true,
					enforce: true,
				},
				main: {
					reuseExistingChunk: true,
					test: /[\\/]app[\\/]/,
				},
				default: {
					minChunks: 1,
				},
			},
		},
	},
	module: {
		rules: [
			{
				test: /\.jsx?$/,
				exclude: /(node_modules|bower_components)/,
				use: {
					loader: 'babel-loader',
					options: {
						presets: [
							['@babel/env', { targets: '> 0.25%, not dead' }],
							[
								'@babel/preset-react',
								{
									runtime: 'automatic',
								},
							],
						],
						plugins: [
							['@babel/plugin-proposal-decorators', { legacy: true }],
							'@babel/plugin-proposal-class-properties',
							'@babel/plugin-syntax-dynamic-import',
							[
								'@babel/plugin-transform-classes',
								{
									loose: true,
								},
							],
							'@babel/plugin-transform-computed-properties',
							'@babel/plugin-transform-shorthand-properties',
						],
					},
				},
			},
			{
				test: /\.css$/i,
				exclude: [path.resolve(__dirname, 'node_modules/react-phone-input-2/lib/style.css')],
				use: [DEBUG_ON ? 'style-loader' : MiniCssExtractPlugin.loader, 'css-loader'],
			},
			{
				test: /\.css$/i,
				include: [path.resolve(__dirname, 'node_modules/react-phone-input-2/lib/style.css')],
				use: ['style-loader', 'css-loader'],
			},
		],
	},
};

package.json config (removed couple private things):

{
	"name": "",
	"description": "",
	"version": "2.0.0",
	"scripts": {
		"build": "NODE_ENV=production webpack --progress --mode production",
		"watch": "webpack --progress --watch --mode development",
		"watch-analyze": "webpack --progress --watch --display-modules",
		"analyze": "webpack --progress --json --display-modules | webpack-bundle-size-analyzer",
		"build-win": "NODE_ENV=production webpack --progress --mode production",
		"watch-win": "webpack --progress --watch",
		"test": "webpack",
		"eslint": "node_modules/.bin/eslint --ext .jsx,.js,.json --fix --ignore-pattern='!.eslintrc.js' --max-warnings=0 ./app"
	},
	"license": "ISC",
	"dependencies": {
		"@clientio/rappid": "file:vendor/rappid.tgz",
		"@date-io/dayjs": "1.3.13",
		"@material-ui/core": "4.11.3",
		"@material-ui/icons": "4.11.2",
		"@material-ui/pickers": "3.3.10",
		"axios": "0.21.1",
		"backbone": "1.4.0",
		"clsx": "1.1.1",
		"connected-react-router": "6.8.0",
		"dayjs": "1.10.4",
		"highcharts": "9.0.1",
		"history": "4.10.1",
		"jquery": "3.6.0",
		"js-cookie": "2.2.1",
		"lodash": "4.17.21",
		"notistack": "1.0.5",
		"nprogress": "0.2.0",
		"object-hash": "2.1.1",
		"prop-types": "15.7.2",
		"react": "17.0.1",
		"react-dnd": "14.0.1",
		"react-dnd-html5-backend": "14.0.0",
		"react-dom": "17.0.1",
		"react-dropzone": "11.3.1",
		"react-phone-input-2": "2.13.9",
		"react-redux": "7.2.2",
		"react-router": "5.2.0",
		"react-router-dom": "5.2.0",
		"react-select": "[custom private repo was here]",
		"react-window": "1.8.6",
		"redux": "4.0.5",
		"redux-logger": "3.0.6",
		"redux-thunk": "2.3.0",
		"reselect": "4.0.0",
		"socket.io-client": "4.0.0"
	},
	"devDependencies": {
		"@babel/core": "7.13.10",
		"@babel/eslint-parser": "7.13.10",
		"@babel/parser": "7.13.11",
		"@babel/plugin-proposal-class-properties": "7.13.0",
		"@babel/plugin-proposal-decorators": "7.13.5",
		"@babel/plugin-syntax-dynamic-import": "7.8.3",
		"@babel/plugin-transform-classes": "7.13.0",
		"@babel/plugin-transform-computed-properties": "7.13.0",
		"@babel/plugin-transform-runtime": "7.13.10",
		"@babel/plugin-transform-shorthand-properties": "7.12.13",
		"@babel/preset-env": "7.13.10",
		"@babel/preset-react": "7.12.13",
		"@babel/runtime": "7.13.10",
		"babel-loader": "8.2.2",
		"css-loader": "5.1.3",
		"eslint": "7.22.0",
		"eslint-config-prettier": "8.1.0",
		"eslint-config-react-app": "6.0.0",
		"eslint-plugin-flowtype": "5.4.0",
		"eslint-plugin-import": "2.22.1",
		"eslint-plugin-json": "2.1.2",
		"eslint-plugin-jsx-a11y": "6.4.1",
		"eslint-plugin-prettier": "3.3.1",
		"eslint-plugin-react": "7.22.0",
		"eslint-plugin-react-hooks": "4.2.0",
		"eslint-plugin-simple-import-sort": "7.0.0",
		"eslint-plugin-sonarjs": "0.6.0",
		"html-webpack-plugin": "5.3.1",
		"husky": "4.3.8",
		"lint-staged": "10.5.4",
		"mini-css-extract-plugin": "1.3.9",
		"prettier": "2.2.1",
		"style-loader": "2.0.0",
		"webpack": "5.25.1",
		"webpack-bundle-tracker": "0.4.3",
		"webpack-cli": "4.5.0"
	},
	"lint-staged": {
		"*.{js,jsx,json}": [
			"node_modules/.bin/eslint --fix --ignore-pattern '!.eslintrc.js' --max-warnings=0",
			"prettier --write"
		]
	},
	"husky": {
		"hooks": {
			"pre-commit": "lint-staged"
		}
	}
}

Please avoid posting configurations in posts, it is unreadable and very rare helps, thanks

hey @alexander-akait could you please let me the desired way? I'll update my previous post to keep it looks good for the community

@vadimkuragkovskiy

hey @alexander-akait could you please let me the desired way?

Yep, just create small reproducible test repo in own account, it is easy to debug and search a problem(s)

Sorry, information is not enough to help you, maybe you forget to add something to your HTML file

Yeah, i know. This is a project that's been fine for years. I'm still trying to figure out the minimum reproduction.
I think it has something to do with mixing mode: development and runtimeChunk... but i'm not 100% there.
I'll keep trying to find a min repro.

Working fine in version 5.27.1
Can be closed

@jsg2021 Could you try 5.27.1?

I will give it a try today


Define and implement reasonable all target

Current default all target as of c66597570807a07734e59a98fe0456b2b2a39ff0 is to build every bitstream.  This is almost certainly not the right thing to do as the default all target.  This issue about defining and implementing a reasonable all target.

I agree that all bitstreams is probably not correct. Maybe "small" tests would be a good goal with the aim to cover of all the blocks and modes. But that leaves any stress test, but not sure if travis is a good match for that.

I think it problably time to get the kokoro instances going to symbiflow, because they are beefier machines, and will be able to run @ -j16 and get results in a reasonable amount of time.


Uncaught TypeError: Path must be a string. Received undefined

[Enter steps to reproduce below:]

...
...

Atom Version: 1.5.3
System: Mac OS X 10.11.4
Thrown From: Remote-FTP package, v0.7.20
Stack Trace
Uncaught TypeError: Path must be a string. Received undefined
At path.js:8

TypeError: Path must be a string. Received undefined
    at assertPath (path.js:8:11)
    at Object.posix.join (path.js:477:5)
    at /Users/thomasfox/.atom/packages/Remote-FTP/lib/connectors/sftp.js:179:22
    at state.requests.(anonymous function).cb (/Users/thomasfox/.atom/packages/SFTP-deployment/node_modules/ssh2/node_modules/ssh2-streams/lib/sftp.js:1780:16)
    at SFTPStream._transform (/Users/thomasfox/.atom/packages/SFTP-deployment/node_modules/ssh2/node_modules/ssh2-streams/lib/sftp.js:384:17)
    at SFTPStream.Transform._read (_stream_transform.js:167:10)
    at SFTPStream._read (/Users/thomasfox/.atom/packages/SFTP-deployment/node_modules/ssh2/node_modules/ssh2-streams/lib/sftp.js:173:15)
    at SFTPStream.Transform._write (_stream_transform.js:155:12)
    at doWrite (_stream_writable.js:292:12)
    at writeOrBuffer (_stream_writable.js:278:5)
    at SFTPStream.Writable.write (_stream_writable.js:207:11)
    at Channel.ondata (_stream_readable.js:525:20)
    at emitOne (events.js:77:13)
    at Channel.emit (events.js:169:7)
    at readableAddChunk (_stream_readable.js:146:16)
    at Channel.Readable.push (_stream_readable.js:110:10)
    at SSH2Stream.<anonymous> (/Users/thomasfox/.atom/packages/SFTP-deployment/node_modules/ssh2/lib/Channel.js:140:15)
    at emitOne (events.js:77:13)
    at SSH2Stream.emit (events.js:169:7)
    at parsePacket (/Users/thomasfox/.atom/packages/SFTP-deployment/node_modules/ssh2/node_modules/ssh2-streams/lib/ssh.js:3168:10)
    at SSH2Stream._transform (/Users/thomasfox/.atom/packages/SFTP-deployment/node_modules/ssh2/node_modules/ssh2-streams/lib/ssh.js:555:13)
    at SSH2Stream.Transform._read (_stream_transform.js:167:10)
    at SSH2Stream._read (/Users/thomasfox/.atom/packages/SFTP-deployment/node_modules/ssh2/node_modules/ssh2-streams/lib/ssh.js:213:15)
    at SSH2Stream.Transform._write (_stream_transform.js:155:12)
    at doWrite (_stream_writable.js:292:12)
    at writeOrBuffer (_stream_writable.js:278:5)
    at SSH2Stream.Writable.write (_stream_writable.js:207:11)
    at Socket.ondata (_stream_readable.js:525:20)
    at emitOne (events.js:77:13)
    at Socket.emit (events.js:169:7)
    at readableAddChunk (_stream_readable.js:146:16)
    at Socket.Readable.push (_stream_readable.js:110:10)
    at TCP.onread (net.js:523:20)

Commands
     -7:17.3.0 core:paste (atom-text-editor.editor.is-focused)
  8x -7:15.3.0 core:backspace (atom-text-editor.editor.is-focused)
     -7:07.4.0 core:save (atom-text-editor.editor.is-focused)
     -6:47.7.0 tree-view:add-file (span.name.icon.icon-file-directory)
  2x -6:43.7.0 core:backspace (atom-text-editor.editor.mini.is-focused)
     -6:40.5.0 core:confirm (atom-text-editor.editor.mini.is-focused)
     -3:18.2.0 sftp-deployment:uploadSelection (span.name.icon.icon-repo)
     -3:04.1.0 remote-ftp:sync-with-local (div.header.list-item)
     -2:29.1.0 settings-view:check-for-package-updates (atom-workspace.workspace.scrollbars-visible-when-scrolling.theme-atom-material-syntax.theme-atom-material-ui)
     -1:58.9.0 core:confirm (atom-text-editor.editor.mini.is-focused)
  2x -1:54 remote-ftp:toggle (atom-text-editor.editor.mini.is-focused)
  2x -1:47.8.0 tree-view:toggle (atom-workspace.workspace.scrollbars-visible-when-scrolling.theme-atom-material-syntax.theme-atom-material-ui)
  5x -0:44.7.0 core:backspace (atom-text-editor.editor.mini.is-focused)
     -0:30 remote-ftp:toggle (atom-text-editor.editor.is-focused)
     -0:22.8.0 remote-ftp:connect (atom-text-editor.editor.is-focused)
     -0:02.7.0 remote-ftp:sync-with-local (div.header.list-item)

Config
{
  "core": {
    "themes": [
      "atom-material-ui",
      "atom-material-syntax"
    ]
  }
}

Installed Packages
# User
Remote-FTP, v0.7.20
atom-material-syntax, v0.2.4
atom-material-ui, v0.6.2
linter, v1.8.1
linter-eslint, v3.1.1

# Dev
No dev packages

Should be fixed in the latest release

If it was fixed, its back becuase im getting this long pice of text, very simmelar to the one above.
TypeError: Path must be a string. Received undefined
at assertPath (path.js:8:11)
at Object.win32.join (path.js:221:5)
at Client.module.exports.Client.toRemote (C:\Users\pete373e.atom\packages\Remote-FTP\lib\client.js:337:15)
at ConnectorFTP.module.exports.ConnectorFTP.put (C:\Users\pete373e.atom\packages\Remote-FTP\lib\connectors\ftp.js:307:25)
at Client. (C:\Users\pete373e.atom\packages\Remote-FTP\lib\client.js:444:20)
at Client.module.exports.Client._next (C:\Users\pete373e.atom\packages\Remote-FTP\lib\client.js:359:21)
at Client.module.exports.Client._enqueue (C:\Users\pete373e.atom\packages\Remote-FTP\lib\client.js:370:9)
at Client. (C:\Users\pete373e.atom\packages\Remote-FTP\lib\client.js:443:9)
at Client.module.exports.Client.onceConnected (C:\Users\pete373e.atom\packages\Remote-FTP\lib\client.js:167:14)
at Client.module.exports.Client.upload (C:\Users\pete373e.atom\packages\Remote-FTP\lib\client.js:442:8)
at C:\Users\pete373e.atom\packages\Remote-FTP\lib\remote-ftp.js:308:29
at Array.forEach (native)
at atom-workspace.atom.commands.add.remote-ftp:upload-selected (C:\Users\pete373e.atom\packages\Remote-FTP\lib\remote-ftp.js:305:12)
at CommandRegistry.module.exports.CommandRegistry.handleCommandEvent (C:\Users\pete373e\AppData\Local\atom\app-1.8.0\resources\app.asar\src\command-registry.js:260:29)
at CommandRegistry.handleCommandEvent (C:\Users\pete373e\AppData\Local\atom\app-1.8.0\resources\app.asar\src\command-registry.js:3:61)
at CommandRegistry.module.exports.CommandRegistry.dispatch (C:\Users\pete373e\AppData\Local\atom\app-1.8.0\resources\app.asar\src\command-registry.js:160:19)
at AtomEnvironment.module.exports.AtomEnvironment.dispatchContextMenuCommand (C:\Users\pete373e\AppData\Local\atom\app-1.8.0\resources\app.asar\src\atom-environment.js:1106:28)
at EventEmitter.outerCallback (C:\Users\pete373e\AppData\Local\atom\app-1.8.0\resources\app.asar\src\application-delegate.js:340:25)
at emitThree (events.js:97:13)
at EventEmitter.emit (events.js:175:7)
Only package that I installed so far is Remote-FTP.
Any help is very much appiciated.
Thanks in advance


Execution time does not change even if some QC tools are skipped

Description of the bug
I have been testing the execution of the pipeline on an HPC. Despite performing the execution with 32 threads, the time (for 1 fastq pair-end sample) was going up to 3h 15min approximately. To minimize this time (since we have to process a total of 350 samples) I skipped the execution of some quality control tools (preseq, biotype_qc, dupradar, stringtie and deseq2_qc) and the pseudo-alignment with salmon. Even so, the execution time hardly changed. This raises several questions for me:

Any idea what this might be due to?
Is it not possible to go below the 3h execution time for this pipeline?
What are the most demanding processes/tools?

Thanks in advance!
Command used and terminal output
#### COMMAND USED ####

nextflow run nf-core/rnaseq -r 3.8.1  --input ${SAMPLESHEET} -profile singularity --max_cpus 32 --genome GRCh38 --fasta ${REFERENCE_DIR}/GCA_000001405.15_GRCh38_no_alt_analysis_set.fna --gtf ${REFERENCE_DIR}/gencode.v41.annotation.gtf.gz --gencode --star_index ${STAR_INDEX} --aligner star_salmon --skip_preseq --skip_biotype_qc --skip_dupradar --skip_stringtie --skip_deseq2_qc --outdir $OUTDIR

#### OUTPUT ####
nf-core/rnaseq v3.8.1
------------------------------------------------------
Core Nextflow options
  revision       : 3.8.1
  runName        : pedantic_brown
  containerEngine: singularity
  launchDir      : /mnt/netapp2/translational_oncology/1_tools/3_nf_core_rnaseq/1_src
  workDir        : /mnt/netapp2/translational_oncology/1_tools/3_nf_core_rnaseq/1_src/work
  projectDir     : /home/usc/mg/mfp/.nextflow/assets/nf-core/rnaseq
  userName       : uscmgmfp
  profile        : singularity
  configFiles    : /home/usc/mg/mfp/.nextflow/assets/nf-core/rnaseq/nextflow.config

Input/output options
  input          : /mnt/netapp2/translational_oncology/1_tools/3_nf_core_rnaseq/1_src/samplesheet_rna.csv
  outdir         : /mnt/netapp2/translational_oncology/1_tools/3_nf_core_rnaseq/3_results/1_URONCOLOGY-RNA-PE
  email<EMAIL_ADDRESS>
Reference genome options
  genome         : GRCh38
  fasta          : /mnt/netapp2/translational_oncology/0_reference/GCA_000001405.15_GRCh38_no_alt_analysis_set.fna
  gtf            : /mnt/netapp2/translational_oncology/0_reference/gencode.v41.annotation.gtf.gz
  gene_bed       : s3://ngi-igenomes/igenomes/Homo_sapiens/NCBI/GRCh38/Annotation/Genes/genes.bed
  star_index     : /mnt/netapp2/translational_oncology/1_tools/3_nf_core_rnaseq/2_data/1_star_reference
  gencode        : true

Process skipping options
  skip_stringtie : true
  skip_preseq    : true
  skip_dupradar  : true
  skip_biotype_qc: true
  skip_deseq2_qc : true

Max job request options
  max_cpus       : 32
------------------------------------------------------
Completed at: 22-Sep-2022 11:59:44
Duration    : 3h 26m 39s
CPU hours   : 34.4
Succeeded   : 41

Relevant files
No response
System information

Nextflow Version 22.04.5
Executed in Finisterrae III HPC with slurm and Linux
Singularity container
Version of nf-core/rnaseq 3.8.1

Hi @mimifp ! Are you able to send the .nextflow.log files for the runs before and after you used all of the skip steps?
There should also be some files in results/pipeline_info/execution_* that will give you an idea as to how long each process took and an overall summary.
Be interested to know what these look like when compared before and after.


colour.py not fit Python version?

It's a useful method. Hi, I tried to use the tool. However while running the BG_Corr.py script, I encountered an error report.
ModuleNotFoundError: No module named 'colour.algebra'; 'colour' is not a package
I try to run the line with colour package.
from colour import linear_conversion
But I got the following errors.
ImportError: cannot import name 'linear_conversion' from 'colour' (/Users/yixiangshan/opt/anaconda3/lib/python3.9/site-packages/colour.py)
By searching online, this is probably not supported by the python version. My PY version is python 3.9 on a macbook. I would like to ask if you know the reason for it?

Have you ensured that colour is installed on your Python?
Try
conda install -c conda-forge colour-science
for a conda install  or
pip install --user colour-science
for a pip install

Hi, Harry, thank you for your reply. Yes, I installed colour-science in conda. The previous error gets solved.
However, I get new error in colour-checker-detection.
from colour_checker_detection import (colour_checkers_coordinates_segmentation)
cannot import name 'colour_checkers_coordinates_segmentation' from 'colour_checker_detection' (/Users/yixiangshan/opt/anaconda3/lib/python3.9/site-packages/colour_checker_detection/__init__.py).
My colour-checker-detection is version 0.2.0.
colour-checker-detection  0.2.0                    pypi_0    pypi
Are any packages wrong in my python environment?


Remove  elasticsearch-index-sink which is based on not supported component

Remove  elasticsearch-index-sink which is based on camel-elasticsearh, which is not supported in CEQ

I don't have write permission, @cunningt perhaps you have?


[5.8][CSGen] Handle recursive use of variable declarations

Cherry-pick of https://github.com/apple/swift/pull/63505

It's possible for out-of-scope type variable to be the type
of declaration if such declaration is recursively referenced
in the body of a closure located in its initializer expression.
In such cases type of the variable declaration cannot be
connected to the closure because its not known in advance
(determined by the initializer itself).
Resolves: https://github.com/apple/swift/issues/63455 (cherry picked from commit 83dd93ad2e902972eee58a3344f69a554e98e661)

@swift-ci please test

I am closing this one because it causes source compatibility regressions.


Tom Schoenrock-Rossiter code review

#20
@S-Kur
Really nice job on the code, I think I picked up a few tiny things but it was really clean and concise.
Review Checklist
CI Checks
The notebook runs from start to finish on all operating systems:
[x] Mac
[x] Windows
[x] Linux
Reproducibility
[x] Are the data downloaded in the code
[x] Are paths created to ensure they work on all operating systems (using os.path.join)
[x] Are comments used to clarify the contents of the code that can’t be clarified using expressive variable and function names alone? (not too many comments - just enough)
[x] Does the notebook run from start to finish?
PEP 8 standards & Code Readability
Functions
[x] Do functions follow PEP 8 format conventions?
[x] Are function docstrings clear (all inputs and outputs clearly described and defined)
[x] Are function names expressive (the name describes what the function does)?
[x] Are functions easy to understand and read?
[x] How many tasks does each function do? (ideally a function does one thing well).
Package imports
[x] Are standard modules (those included with the base python install) vs. third party (related but externally developed tools) import groups correct with appropriate spacing in between each group?
[x] Are variable names throughout the code, expressive?
**Your code was very easy to read and follow because of your well-named variables!
[x] Is the code overall easy to understand and read? Are there things that would make it more clear / cleaner?
DRY Code
[x] Are segments of code repeated in the file or is the code DRY?
[x] Are loops used to optimize DRY code?
[x] Are functions used to optimize DRY code?
[x] Are there any areas that could be potentially improved (you can suggest improvements OR you can just highlight parts of the code where you suspect it could be cleaner / more efficient.
Novel Approaches to Problem solving
[x] Highlight any novel approaches to completing the assignment.
**I hadn't seen the code you used for plotting before, it works really well

@Tsrockross Thank you for the review!


np.int -> int

np.int is int and it was deprecated in numpy 1.20: https://numpy.org/doc/1.20/release/1.20.0-notes.html#deprecations

Would highly appreciate this change

We would love this fix too!


Suggestion for schema management

Hi, I know, this project is a frontend, but as it is based on many-components-for-creating-one-form,
and because Vue.js is a good innovation pole, I would like to raise the feature of schema management, or cooperation to one. I am however not technical in JS enough for coding this project.
As I am also interested in Meteor, I already sent the same message to aldeed (the Simple Schema package maintainer)
I think it could be a good lever in an object oriented frontends, that would improve everything fast.
A Word file is enclosed, let me know if you prefer another format.
Updated version in next post.
Thanks
Marc

Here is an updated version.
Suggestions for Simple Schema.docx

Hi @MarcTe , thanks for the proposal, however I don't think an issue is the best place for this discussion because:

The proposal doesn't include any concrete implementation suggestions for Vue yet;
It involves the server-side and the data layer which are out of scope for this repo (e.g. Meteor, Apollo)

Feel free to submit this to the forum and invite members from the Meteor/Apollo community to join the discussion.


Could someone please help me manually merge my PR request to change token logo. Thank you! PR #13019

Edited my token image url I modified the Json file and changed my existing image url link the automerge gave me an error. I have understood this is because it needs to be manually merged. How long until my edit is merged?

My PR #13019

did you find answer to this

merged


Respect transaction_ignore_urls and transaction_ignore_user_agents when creating transactions in the spring webflux instrumentation

What does this PR do?
Fixes #2514
Checklist

[x] This is a bugfix

[x] I have updated CHANGELOG.asciidoc
[x] I have added tests that would fail without this fix

:grey_exclamation: Build Aborted

The PR is not allowed to run in the CI yet

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2022-03-15T15:47:04.472+0000

Duration: 3 min 9 sec

Pipeline error

  This error is likely related to the pipeline itself. Please go to the traditional console output here"
  You will see the error (either a wrong syntax or configuration)

:robot: GitHub comments
To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.

run benchmark tests : Run the benchmark tests.

run jdk compatibility tests : Run the JDK Compatibility tests.

run integration tests : Run the Agent Integration tests.

run end-to-end tests : Run the APM-ITs.

run windows tests : Build & tests on windows.

run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@elasticmachine run elasticsearch-ci/docs

Thank You!


Migration to cowboy 2.0

make required changes to support cowboy 2.0

#95 closed in favor of this issue.

Works with
Erlang/OTP 20 [erts-9.2] [64-bit] [smp:4:4] [ds:4:4:10] [async-threads:10]

Eshell V9.2  (abort with ^G)


Regexp match amazon repo urls rather than changing them every month

Description
Describe what this change achieves
Issues Resolved
List any existing issues this PR resolves
Check List

[ ] A summary of changes made is included in the CHANGELOG under ## Unreleased
[ ] New functionality includes testing.
[ ] New functionality has been documented in the README if applicable.

Released as: 4.0.6