Comments support?

How about retrieving comments for all tables + columns, and adding them as TypeScript comments? ;)
See:

Retrieving Comments from a PostgreSQL DB
How to retrieve the comment of a PostgreSQL database?

It would be great to have! 👍

I've been meaning to checkout TypeScript has anyone picked this up?

You can grab this one 👍

FWIW, to retrieve comments with information schema statements :
SELECT
    obj_description(format('%s.%s',isc.table_schema,isc.table_name)::regclass::oid, 'pg_class') as table_description,
    pg_catalog.col_description(format('%s.%s',isc.table_schema,isc.table_name)::regclass::oid,isc.ordinal_position) as column_description
FROM
    information_schema.columns isc

@abenhamdine the same code was shown from the first link that I provided, the answer given by user T.Z. there :wink:

@vitaly-t Ah yes, you're right : actually, I was reading a SO question about this, and I paste immediatly the code without having read your first link... which turned out to be the same link 😉
Otherwise, I still wonder if it exists a 'pure' information schema way to retrieve comments, without any specific pg function, as this module until now is still sql-generic.

I was thinking : it would be a good thing to add in the comments the true datatype of the database column, as the ts types are far more limited, and it can be useful to know the full SQL type.
Example : for a json column :
export namespace osm {

    export namespace usersFields {
        export type last_post = string;
...
 export interface users {
        /** last post of the user (SQL type : jsonb) */
        last_post: usersFields.last_post;
...

I was thinking : it would be a good thing to add in the comments the true datatype of the database column, as the ts types are far more limited, and it can be useful to know the full SQL type.

That's a nice idea, can be very useful.

In the same way, :

it could be useful to have in the comments the default SQL value of the column, if it's different from null.
if there's a check constraint, it could be interesting too to add it, as it provides information about the values allowed for the column.

Not necessary all that in the same PR.

For the foreseeable future, support to PostgreSQL exclusively will be fine.

MySQL is less feature rich, and its lack of feature is often complemented by ORMs.
NodeJS rarely seen used with MSSQL or Oracle, mainly because using them with C#/.Net and Java respectively offer a far better experience.

Actually, I'm a big supporter of postgres, so it's perfect for me 😄

@jmealo do you intend to send PR for this ? If not, I can perhaps give it a try next week. Let me know if you have begun to tackle this.

@xiamx When people are going around hunting for tools like schemats to help them work with an unfamiliar database schema, it is likely they don't have control over the choice of database.

You have a point @masaeedu . With https://github.com/SweetIQ/schemats/pull/52, we adopted a structure that allows us to support other types of databases (they just need to implement a common interface).
Pull requests to support other databases (MSSQL, Sqlite (this one is difficult), etc) are very welcomed.

I think this was implemented by https://github.com/vaultdairy/schemats/commit/ed446b43c6708f7f27dac7b2c819df93f6b88951 and https://github.com/vaultdairy/schemats/commit/f50bd4a7be5218aa8bf08a0ca0e44c8828f6ca07.

@HoldYourWaffle -- Unfortunately, no. The fork now generates io-ts types instead of regular Typescript interfaces. While the output types can be used just as regular types, this change probably isn't something that most consumers of schemats would want.


Enter in parentheses will automatically select the contents in parentheses

Press enter in the brackets of the intelligent prompt, and the content in the brackets will be selected by default, so that the intelligent prompt cannot be used normally in the brackets

Same situation here.

fixed in 2.5.2


Adding std::hash::sha2_256 test to rbpf

Similar to drand test #54 , but here we use more standardized std::hash::sha2_256.
Test code is shorter and simple.
Good news is that two different tests compute the same value.

Closing this since it is superseded by #59


Use @bsphack @esphack instead of \ignorespaces

At least for \addfontfeatures...

On second thoughts, this would change the typesetting of documents that had something like
Foo.\addfontfeatures{A=B} bar

So I think it's too late to make any changes regarding spaces here.


Type for safeParseAsync not coming correctly

The return type for safeParseAsync is not coming correctly, I can retrieve only the success item but not the error itself. I checked the typescript declarations and it contains some union (unnecessary because error or data could be added as optional fields - I mean, nullable ones). Is that the correct behavior? I'm kind of confused but I'm sure it is not.

They could just be like that:

https://youtube.com/shorts/xlTrDIHhnhs?feature=share

https://youtube.com/shorts/xlTrDIHhnhs?feature=share

Meaningless coment, if it bothers you feel free to ignore the issue.

Perhaps this could help you:
https://github.com/JacobWeisenburger/zod_utilz#spr

Perhaps this could help you:
https://github.com/JacobWeisenburger/zod_utilz#spr

Interesting. Also I did not have time to post a written reproduction of the problem yet but I'll be following up soon


wsl2: usage of %LOCALAPPDATA%\Temp\wsl-crashes

Host OS: Windows 11 23H2 22631.4169
Guest distribution: ubuntu, kernel <IP_ADDRESS>-microsoft-swandard-WSL2
Something in my WSL environment is causing failed nodejs commands to write crash dumps to %LOCALAPPDATA%\Temp\wsl-crashes in the host fs. This is annoying because I have a lot of RAM and the crash dumps are big, and Windows gives me notifications that my disk space is running low.
I've searched for information about this, but the documentation about crash dumps refers to WSL2 subsystem crashes, and these are crash dumps from command line programs running in the guest OS.
I would like to be able to disable this behavior or relocate the directory where the crash dumps live. Is this possible? Could it be possible? Is there documentation that I am missing?

https://github.com/microsoft/WSL/issues/12032 is definitely the cause of the files that I'm seeing, but the thing I would like is the ability to change where they are written or disable them being written to the host FS.

@sfoster1: You can disable crash dump collection by setting:
[wsl2]
MaxCrashDumpCount=-1

In %USERPROFILE%/.wslconfig. After WSL restarts, this will completely disable crash dump collection.


Renamed $profile to $TmProfile

You should not use $profile as it is an automatic variable --> https://docs.microsoft.com/en-us/powershell/module/microsoft.powershell.core/about/about_automatic_variables?view=powershell-6

@BaileyLawson : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off


Location element in MPD not honored

I'm evaluating latest master that already supports live streams and it seems that it is not taking into account Location element present in the manifest. We're using Wowza and requesting the default manifest again to refresh chunk list also creates additional sessions, which then invalidates stream statistics.
Please see here for further info http://www.wowza.com/forums/content.php?508-How-to-do-MPEG-DASH-streaming#redirects
Thanks,
Tomas

We don't support that at the moment, but we will add it to the roadmap.  Thanks for the suggestion!


Add guest package for fetching attestation report via syscall

Add ioctl wrapper and structs required to fetch attestation report.
Add a command line tool to fetch real and fake attestation
reports.
Fake attestation report can be used when testing integrations.
Signed-off-by: Maksim An<EMAIL_ADDRESS>

@SeanTAllen @KenGordon @svolos FYI.

This is the replacement for https://github.com/microsoft/hcsshim/pull/1329?

This is the replacement for #1329?

yeah. #1329 was opened as a reference C implementation.

Github doesn't want me to reply to the question about formats, but a json version isn't totally useful as the binary data is signed. Change the format and checking the signature becomes difficult. As a client I cannot rely on, for example, the hostdata or boot measurement fields unless I can validate that the whole report is real and produced by a real device.

Imagine you need to boot a naked UVM image to see that it works and that the measurement is as expected. There is no gcs running to mount a device and having one adds complication to understanding that the kernel/rootfs are as expected.
The C version of this code results in a 17k binary.
From: Kevin Parsons @.>
Sent: 01 April 2022 18:37
To: microsoft/hcsshim @.>
Cc: Ken Gordon @.>; Mention @.>
Subject: Re: [microsoft/hcsshim] Add guest package for fetching attestation report via syscall (PR #1341)
@kevpar commented on this pull request.

In Makefilehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fhcsshim%2Fpull%2F1341%23discussion_r840791702&data=04|01|ken.gordon%40microsoft.com|2d87b1f782284c9d9eed08da14063163|72f988bf86f141af91ab2d7cd011db47|1|0|637844314098266222|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=o07VyLX6rtpZb5bUsi7CPUQDsVp8dMjq2OpRWurO%2FbQ%3D&reserved=0:

@@ -49,6 +49,7 @@ out/delta.tar.gz: bin/init bin/vsockexec bin/cmd/gcs bin/cmd/gcstools bin/cmd/ho

    cp bin/cmd/gcs rootfs/bin/

    cp bin/cmd/gcstools rootfs/bin/

    cp bin/cmd/hooks/wait-paths rootfs/bin/

  cp bin/internal/tools/snp-report rootfs/bin/

Is this just a debug tool? Could we leave it out of the rootfs and just mount it in when needed?

Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fhcsshim%2Fpull%2F1341%23pullrequestreview-929237907&data=04|01|ken.gordon%40microsoft.com|2d87b1f782284c9d9eed08da14063163|72f988bf86f141af91ab2d7cd011db47|1|0|637844314098266222|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=rLHDmi%2FF1osVbD3RuPY7gWJ7hxupxwrWVjoN29cGTJ0%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABI7RIHELYH4PD45MFUFTJTVC4X23ANCNFSM5SEMNH2A&data=04|01|ken.gordon%40microsoft.com|2d87b1f782284c9d9eed08da14063163|72f988bf86f141af91ab2d7cd011db47|1|0|637844314098266222|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=XW4F4knEUTHCJI4cwX0jN7ODJnkHK1qHJHeiKKwLg3c%3D&reserved=0.
You are receiving this because you were mentioned.Message ID<EMAIL_ADDRESS>

It looks like you're checking in the binary internal/tools/snp-report/snp-report. Probably not intended?

It looks like you're checking in the binary internal/tools/snp-report/snp-report. Probably not intended?

thanks for catching this! definitely not!

The blob in the json is base64 bit that is converted to bytes in the hardware register. The base64 is purely an api artefact.
From: Kevin Parsons @.>
Sent: 08 April 2022 18:53
To: microsoft/hcsshim @.>
Cc: Ken Gordon @.>; Mention @.>
Subject: Re: [microsoft/hcsshim] Add guest package for fetching attestation report via syscall (PR #1341)
@kevpar commented on this pull request.

In internal/guest/runtime/hcsv2/uvm.gohttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fhcsshim%2Fpull%2F1341%23discussion_r846357986&data=05|01|ken.gordon%40microsoft.com|f6e4243a86024bd2691208da19888d80|72f988bf86f141af91ab2d7cd011db47|1|0|637850371560390769|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=V6EKkLTf4Lh%2BQovcL3vHJPU6EJ01BJW6cAyonkRCeg4%3D&reserved=0:

@@ -95,6 +95,15 @@ func (h *Host) SetSecurityPolicy(base64Policy string) error {

           return err

    }

  hostData, err := securitypolicy.NewSecurityPolicyDigest(base64Policy)

  if err != nil {

         return err

  }

  if err := validateHostData(fmt.Sprintf("%x", hostData[:])); err != nil {

Maybe I'm missing something, but shouldn't we be doing base64 encoding here instead of just %x formatting? It looks like the data we get from SEV is base64 encoded since that's what we pass in create_lcow.go.

Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fhcsshim%2Fpull%2F1341%23pullrequestreview-936790507&data=05|01|ken.gordon%40microsoft.com|f6e4243a86024bd2691208da19888d80|72f988bf86f141af91ab2d7cd011db47|1|0|637850371560390769|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=CpgWv%2FpRfXOgp7UD02i2Y3u%2BerS8%2Fw2bVdgb4KuQ3ZU%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABI7RIF2GEGIEN26PO322RTVEBW55ANCNFSM5SEMNH2A&data=05|01|ken.gordon%40microsoft.com|f6e4243a86024bd2691208da19888d80|72f988bf86f141af91ab2d7cd011db47|1|0|637850371560390769|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=4xugLUkMWEFdOA9198iILyZltznHo9Ap%2BcYDl1Qmin4%3D&reserved=0.
You are receiving this because you were mentioned.Message ID<EMAIL_ADDRESS>

No, hcs takes a base64, makes a binary blob and puts that nto a hardware register. Maksim then get it out of the hardware register in process via an ioctl and converts it in wild ways. Previously the standalone C program converted it to hex so that it could be consumed by go code that would do whatever from just a series of bytes that were hex encoded to make debugging easier and avoid all the pain of passing binary via stdout.
Really, once it is in process, everything ought to be an appropriate sized blob, with a type etc to make sue it is impossible to compare the wrongs things in the wrong format.
From: Kevin Parsons @.>
Sent: 08 April 2022 19:11
To: microsoft/hcsshim @.>
Cc: Ken Gordon @.>; Mention @.>
Subject: Re: [microsoft/hcsshim] Add guest package for fetching attestation report via syscall (PR #1341)
@kevpar commented on this pull request.

In internal/guest/runtime/hcsv2/uvm.gohttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fhcsshim%2Fpull%2F1341%23discussion_r846370419&data=05|01|ken.gordon%40microsoft.com|be63e82903394263010e08da198b2ed4|72f988bf86f141af91ab2d7cd011db47|1|0|637850382849253649|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=tbwGgbCZXASEEGjwfJv5jVylYPOmq4OQLfcjfegLYKo%3D&reserved=0:

@@ -95,6 +95,15 @@ func (h *Host) SetSecurityPolicy(base64Policy string) error {

           return err

    }

  hostData, err := securitypolicy.NewSecurityPolicyDigest(base64Policy)

  if err != nil {

         return err

  }

  if err := validateHostData(fmt.Sprintf("%x", hostData[:])); err != nil {

That's terrible lol. So HCS is decoding the base64 and formatting it as a hex string? If that's the case let's make a comment both here and in create_lcow.go since that is super confusing.

Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fhcsshim%2Fpull%2F1341%23discussion_r846370419&data=05|01|ken.gordon%40microsoft.com|be63e82903394263010e08da198b2ed4|72f988bf86f141af91ab2d7cd011db47|1|0|637850382849253649|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=tbwGgbCZXASEEGjwfJv5jVylYPOmq4OQLfcjfegLYKo%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABI7RICWODH4MCVI6CKIGPTVEBZERANCNFSM5SEMNH2A&data=05|01|ken.gordon%40microsoft.com|be63e82903394263010e08da198b2ed4|72f988bf86f141af91ab2d7cd011db47|1|0|637850382849253649|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=tfNlWQdOSAYqwIYLZV1xWL7nq8iDcj%2FFdAX52QDVtHY%3D&reserved=0.
You are receiving this because you were mentioned.Message ID<EMAIL_ADDRESS>

Yes.
From: Scott Brender @.>
Sent: 09 April 2022 19:35
To: microsoft/hcsshim @.>
Cc: Ken Gordon @.>; Mention @.>
Subject: Re: [microsoft/hcsshim] Add guest package for fetching attestation report via syscall (PR #1341)
@msscotb commented on this pull request.

In internal/guest/amdsev/report.gohttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fhcsshim%2Fpull%2F1341%23discussion_r846667533&data=05|01|ken.gordon%40microsoft.com|6add7c87778a4a0a6a6008da1a579b8b|72f988bf86f141af91ab2d7cd011db47|1|0|637851260842148511|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=O4wgn%2BaEUROnC2Fv0cnWA2AWmcUnPepDEmj%2FkQBbSmw%3D&reserved=0:

+// MSG_REPORT_RSP Table 23.

+// NOTE: reportResponse.Report is a byte slice, to have the original
+//     response in bytes. The conversion to internal struct happens inside
+//     convertRawReport.
+// NOTE: the additional 64 bytes are reserved, without them, the ioctl fails.
+type reportResponse struct {

  Status     uint32

  ReportSize uint32

  reserved1  [24]byte

  Report     [1184]byte

  reserved2  [64]byte // padding to the size of SEV_SNP_REPORT_RSP_BUF_SZ (i.e., 1280 bytes)

+}

+// FetchRawSNPReport returns attestation report bytes.
+func FetchRawSNPReport(reportData string) ([]byte, error) {

  f, err := os.OpenFile("/dev/sev", os.O_RDWR, 0)

Is write access needed to fetch the SNP report?

Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fhcsshim%2Fpull%2F1341%23pullrequestreview-937167960&data=05|01|ken.gordon%40microsoft.com|6add7c87778a4a0a6a6008da1a579b8b|72f988bf86f141af91ab2d7cd011db47|1|0|637851260842148511|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=dLgeKIrdfIljm6RWlw%2F27XwYjIiJ34vg9hVSlxamvPg%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABI7RIG546GXYNR6OTSMVE3VEHET7ANCNFSM5SEMNH2A&data=05|01|ken.gordon%40microsoft.com|6add7c87778a4a0a6a6008da1a579b8b|72f988bf86f141af91ab2d7cd011db47|1|0|637851260842148511|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=0wzavrSjd71cRoQkWW%2Bk24c1hUcJWCBnUR1D74GCxU4%3D&reserved=0.
You are receiving this because you were mentioned.Message ID<EMAIL_ADDRESS>

Make sure you either rebase your commits into a curated set, or use "Squash and merge".

lgtm


Small recent tag when connecting wallet

would it be possible to put a small "recent" tag there?
design in handoff - light mode invert colors.

https://www.figma.com/file/JXNtryaNYhY0XJNArzvPQx/Handoff?type=design&node-id=1287%3A18959&mode=design&t=dxVk780B0E5Al9nw-1

👋

@exezbcz a couple of questions
when should the recent tag be added

last connected wallet on that device
any connected wallet on that device
with time limit? , last 30 days for example

last connected wallet on that device

yes

with time limit? , last 30 days for example

last used, could be 30 days yes

closed in #7606


English videos

I've noticed that the author has made some videos about hegel and it sounds like its in Russian or Ukranian.
Are there any video recordings available with english subtitles ?

For now, only automatically generated (like in this one.
But I'm going to show Hegel at different English-language conferences after quarantine will be ended.
Thank you for the question :)


Use spec's mountLabel when mounting the rootfs

In NewContainer if a SnapshotKey is used and the spec has a mountLabel specified, that mountLabel should be used to mount the rootfs.
This functionality is need to support full SELinux MCS support in containerd-cri. container-cri delegates mounting the rootfs to containerd by using the NewContainer method with a SnapshotKey. In this scenario the rootfs is not getting the proper selinux context="..." mount option applied.

Codecov Report

Merging #4051 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4051   +/-   ##
=======================================
  Coverage   42.67%   42.67%
=======================================
  Files         130      130
  Lines       14778    14778
=======================================
  Hits         6307     6307
  Misses       7552     7552
  Partials      919      919

Flag
Coverage Δ

#linux
46.07% <ø> (ø)
:arrow_up:

#windows
38.26% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c5279e...c134a9b. Read the comment docs.


Added two new APIs to get topic info and topic messages

Description
This pull request changes the following:

Added two new APIs to get topic info and topic messages

Related Issues

Closes #490

Codecov Report
Attention: Patch coverage is 0% with 48 lines in your changes missing coverage. Please review.

Project coverage is 50.72%. Comparing base (a0c6430) to head (1f20fb7).

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #496      +/-   ##
==========================================
- Coverage   52.59%   50.72%   -1.87%
==========================================
  Files          10       10
  Lines        1194     1238      +44
  Branches      414      426      +12
==========================================
  Hits          628      628
- Misses        566      610      +44

Files
Coverage Δ

...wallet-snap/packages/snap/src/utils/HederaUtils.ts
57.90% <0.00%> (-2.86%)
:arrow_down:


3 new components for the home app

We have 3 frequently used components in the app that would be useful to make available for prototypes. The easiest route would be to add these to palmetto-components. It might make sense to keep them in a separate app-only sub-package if possible.

OptionButton as used on Account, Onboarding, and Summary pages
OptionTile as used on Services, PalmettoProtect, and Checkout pages
RadioGroup as used on Connect, PreferredLanguage, TreeRemoval, and HomeownersAssociation pages

It makes more sense to make these components available from a separate repository. See https://trello.com/c/RNBAh95D/917-export-app-components-for-use-in-prototype. Closing this issue.

Hey @RyanMacBern we actually are in the process if integrating these into the component library (starting with the radio/option tiles).
It will likely be released in the next day or 2. I'll chat with @nathanyoung to get his thoughts on the remaining ones, but figured it might be slightly more awkward to have the app serve up a components package.

@juanfabrega Oh great! I hadn't seen any action on this, so I thought I'd remove the burden from UX. We should chat about how we want to handle things like this going forward.

 Radio Group (tile/card)  palmetto-app

@juanfabrega reminder to tag @RyanMacBern on the PR

 Option Button (palmetto app)

 Option Tile (palmetto app) (card?)


Use the latest tfjs-core 0.12.1

Depends on https://github.com/tensorflow/tfjs-core/pull/1139 and new version (0.12.1) of tfjs-core published.

This change is

You're welcome. I changed how tests work in core (more tests are now running against node) and that required slight api change in jasmine_util


Add authClass configuration option to jolokia-osgi

jolokia-jvm has the option to specify an authClass.  When specified, authMode
is ignored and authentication responsibility is delegated to authClass.  This
change enables the use of any authClass which extends
org.jolokia.osgi.security.Authenticator.
Signed-off-by: Ryan Goulding<EMAIL_ADDRESS>

@rhuss Please let me know your thoughts on this change.  Glad to make any modifications you suggest.  I am trying to integrate this with OpenDaylight (osgi/karaf based);  we have an existing AAA subsystem and I am trying to delegate jolokia authN responsibility to that.  I am the Project Technical Leader of AAA in ODL, so let me know if you think there is a better way to do this and I can adapt internally.

Thanks a lot for the PR. In fact an extension point for an restrictor makes much sense. Jolokia 2.0 already has this, but it's still in early development stage.
Since I'm currently on vacations I will take care about this PR after this (2 weeks). Hope this is OK.

Thanks @rhuss and enjoy your vacation!

Sorry for the long delay. However, I'm just about to pick this up now and cut a release before the end of this week,
Would an OSGi Authenticator service help you, too ? I ask because in an OSGi environment this is the canonical way to wire stuff together and we do this already for restrictors which are exposed as OSGi service. That way you could also nicely stack multiple authenticator services (much like for the restrictor).
My suggestion is to use a new authMode with value service in which case in an OSGi context the authentication service is looked at the time of a request. If no such service is available, then the access is restricted. If more than one service is available then all services must pass. An extension could be, to add an extra authRequire option with possible values all or any and allow also multiple, comma separated authMode values.
I think that would fit better in the current implementation (i.e. avoiding Class.forName() lookups in an OSGi environment).
What do you think ?

Seel also http://njbartlett.name/2010/08/30/osgi-readiness-loading-classes.html why using Class.forName() is not the way to go in OSGi ...

Good points, rhuss.  I will look into adding a service interface instead of using Class.forName(...).


ability to query individual health checks

New feature: ability to query individual health checks
We have few health checks in our application. and one of them is basic dead-lock threads.
When this happens we have no choice than to restart the app.
We would like to automate it but we don't like to query all health checks and then parse the response, because it is useless to call all of them and bring some logic to the monitoring tool. Instead we would like to query individual check and act immediately if its failing.

Could you add a test to https://github.com/dropwizard/metrics/blob/master/metrics-servlets/src/test/java/io/dropwizard/metrics/servlets/HealthCheckServletTest.java?

@ryantenney I was trying to hack and manage some tests, but the way how the code is organised it is impossible... havy refactoring for health-check servlet is required.

Our company also would benefit from such feature..
Any help needed to make it possible?

@ingwarsw maybe if you can come up with any kind of unit test?
we miserably failed to find any way to unit-test this feature.

Will try..
Do i read correctly that url for test should be in format heatlh/nameOfHealthCheck ?

@ryantenney Will it be possible to add it after adding tests and other required stuff or its not desired feature at all?

@ingwarsw, right
there are 2 ways to query it
/healthcheck to query all registered health checks or
/healthcheck/name_of_healthcheck to query one of them, example: /healthcheck/deadlocks

Tests was actually easy :)
I refactored it a bit.. but I dont want to create other PR.
Here it is..
https://github.com/dropwizard/metrics/compare/master...ingwarsw:individual-healthchecks?expand=1

the PR is recreated on top of 3.2-development branch
see https://github.com/dropwizard/metrics/pull/940


Data Failing to Update

3/4 of Demographics data sources have not been updating since 02/19/2021.  This is likely due to a for loop not set up properly to iterate through dictionary correctly.

Same issue with GeoFred data in Labor.

Incorrect indentation in geofred.py file was found and corrected.  Data updates now.


Bus headways issue

https://dashboard.transitmatters.org/bus?config=73,73-1-2064,73-1-12614,2022-03-31,
needs investigation

updated link because buses no longer go to cambridge common: https://dashboard.transitmatters.org/bus?config=73,73-1-2064,73-1-20761,2022-03-31,


Cannot get recorder_mock fixture running

Hi sorry to bug you with an issue but I cannot find any references online about this problem:
I'm finally trying to add some unit tests to my custom_component and basically need to make something like this for it: https://github.com/home-assistant/core/blob/dev/tests/components/tibber/test_statistics.py
Unfortunately whenever I use the recorder_mock fixture I get this error:
recorder_db_url = 'sqlite://', hass_fixture_setup = [True], enable_nightly_purge = False, enable_statistics = False, enable_statistics_table_validation = False

    @pytest.fixture
    async def async_setup_recorder_instance(
        recorder_db_url,
        hass_fixture_setup,
        enable_nightly_purge,
        enable_statistics,
        enable_statistics_table_validation,
    ) -> AsyncGenerator[SetupRecorderInstanceT, None]:
        """Yield callable to setup recorder instance."""
>       assert not hass_fixture_setup
E       assert not [True]

venv/lib/python3.10/site-packages/pytest_homeassistant_custom_component/plugins.py:1020: AssertionError

FAILED tests/test_sensor.py::test_sensor_service - assert not [True]

I cannot find any setting I might need to set online. You can reproduce this error with a simple test like this:
async def test_sensor_service(recorder_mock, hass):
    """Test sensor service."""

    assert True

The only "config" I set was asyncio_mode in the pyproject.toml to get rid of the async errors:
[tool.pytest.ini_options]
asyncio_mode = "auto"

conftest.py is basically unaltered from the template: https://github.com/custom-components/integration_blueprint/blob/master/tests/conftest.py (if this should make any difference)
Do you know anything I might miss by chance as it seems that nobody who uses recorder functions inside a custom_component seem to use unit tests.
Additional infos:
pytest-homeassistant-custom-component==0.12.29
custom_componet uses the custom-components/integration_blueprint template
Full log:
(venv) root ➜ /workspaces/ha_linznetz (add-tests ✗) $ pytest tests/test_sensor.py
Test session starts (platform: linux, Python 3.10.2, pytest 7.2.0, pytest-sugar 0.9.5)
rootdir: /workspaces/ha_linznetz, configfile: pyproject.toml
plugins: anyio-3.6.2, aiohttp-1.0.4, asyncio-0.20.2, cov-3.0.0, forked-1.4.0, freezegun-0.4.2, homeassistant-custom-component-0.12.29, socket-0.5.1, sugar-0.9.5, test-groups-1.0.3, timeout-2.1.0, xdist-2.5.0, requests-mock-1.10.0, respx-0.20.1
asyncio: mode=auto
collecting ...

――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――― ERROR at setup of test_sensor_service ――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――

event_loop = <_UnixSelectorEventLoop running=False closed=False debug=False>, request = <SubRequest 'async_setup_recorder_instance' for <Function test_sensor_service>>
kwargs = {'enable_nightly_purge': False, 'enable_statistics': False, 'enable_statistics_table_validation': False, 'hass_fixture_setup': [True], ...}
func = <function async_setup_recorder_instance at 0x7fdfd430d5a0>
setup = <function _wrap_asyncgen_fixture.<locals>._asyncgen_fixture_wrapper.<locals>.setup at 0x7fdfd3fe2cb0>
finalizer = <function _wrap_asyncgen_fixture.<locals>._asyncgen_fixture_wrapper.<locals>.finalizer at 0x7fdfd3fe2d40>

    @functools.wraps(fixture)
    def _asyncgen_fixture_wrapper(
        event_loop: asyncio.AbstractEventLoop, request: SubRequest, **kwargs: Any
    ):
        func = _perhaps_rebind_fixture_func(
            fixture, request.instance, fixturedef.unittest
        )
        gen_obj = func(**_add_kwargs(func, kwargs, event_loop, request))

        async def setup():
            res = await gen_obj.__anext__()
            return res

        def finalizer() -> None:
            """Yield again, to finalize."""

            async def async_finalizer() -> None:
                try:
                    await gen_obj.__anext__()
                except StopAsyncIteration:
                    pass
                else:
                    msg = "Async generator fixture didn't stop."
                    msg += "Yield only once."
                      It initializes the hass fixture earlier.

Nice catch! Yes I can confirm that the code above works when disabling the enable_custom_integration fixture but sadly it's not a valid solution since I need this fixture to test my custom_integration I guess?
I just tried some other (combinations of) fixtures like hass_recorder or enable_statistics but without success (either the same error or "KeyError: 'recorder_instance'"). Could it be that some kind of fixture combination is need since the recorder_mock does not work?
I use the following homeassistant.components.recorder.statistics functions if this is any helpful:
get_last_statistics
statistics_during_period
async_import_statistics

Oh the order of the fixtures seems to be the solution! (Sorry it's my first time writing unit tests in python.)
Just tried it with the autouse=False and with this function definiton and it seems to work!
async def test_sensor_service(recorder_mock, enable_custom_integrations, hass):

Thank you for helping to understand this behaviour!

No problem, your detailed information was really helpful.  I debated for a long time whether to make enable_custom_integrations automatically use autouse=True from this package.  This issue clarifies that this would have been a bad choice as sometimes we need this fixture in a specific order.

If I may ask another question: Is there any way to disable the auto_enable_custom_integrations fixture for specific tests only (with some annotation or something like this)? Google is not very helpful in this case.
Or do I have to add the enable_custom_integrations in every test manually?

If all your tests need recorder_mock, you could create your own fixture in contest.py with the correct ordering of fixtures.
@pytest.fixture(autouse=True)
def my_fixture(recorder_mock, enable_custom_integrations):
    pass

If you don't need recorder_mock for all tests.  You could create two test modules and scope specific fixtures for each module.  I recommend looking at the pytest documentation here as there are several possibilities here.

I've come across the very same issue and I've resolved this way.
# Test initialization must ensure custom_components are enabled
# but we can't autouse a simple fixture for that since the recorder
# need to be initialized first
@pytest.fixture(autouse=True)
def auto_enable(request: pytest.FixtureRequest):
    if "recorder_mock" in request.fixturenames:
        request.getfixturevalue("recorder_mock")
    hass = request.getfixturevalue("hass")
    hass.data.pop("custom_components")
    yield

I've copied over the code from 'enable_custom_integrations' since I didn't find a solution for how to invoke the 'fixture' in the wild (probably you can't) but this auto_use is basically doing the same, except it checks if you need the 'recorder_mock' and instantiates it in the correct order. This could also work for other fixtures you might need to use and which need to be invoked before 'hass'


fix(controller): add check when deleting a user

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@xtlsoft can you explain the PR?

Previously no proper permission check was done when deleting a user. I could delete an admin user with a normal user.

@xtlsoft usually normal users cannot delete users.  I'm so sorry for bothering you.


Can I read option as argument?

Thanks for the useful library.
Can I read option as argument?
I would be happy if the specification reads as agument after the -- option, as shown below
$ ls -- -l
ls: cannot access '-l': No such file or directory

I understand this issue same as #536


Figma plugin is not loading icons

Package

[ ] lucide
[ ] lucide-angular
[ ] lucide-flutter
[ ] lucide-preact
[ ] lucide-react
[ ] lucide-react-native
[ ] lucide-solid
[ ] lucide-svelte
[ ] lucide-vue
[ ] lucide-vue-next
[X] Figma plugin
[ ] source/main
[ ] other/not relevant

Version
8
Browser

[ ] Chrome/Chromium
[ ] Firefox
[ ] Safari
[ ] Edge
[ ] iOS Safari
[ ] Opera
[X] Other/not relevant

Operating system

[ ] Windows
[ ] Linux
[X] macOS
[ ] Other/not relevant

Description
The plugin is not loading the icons and stays in loading state. It shows only the loading skeleton. I'm using the Figma App on MacoS 14.1.1 (23B81).

Steps to reproduce

Open Figma
Run Lucide Figma Plugin
Icons not loading

Checklist

[X] I have searched if someone has submitted a similar issue before and there weren't any. (Please make sure to also search closed issues, as this issue might already have been resolved.)

Works on my machine 🤷

I got the feedback from my colleague first and then I tested it and got the same result. That was the first time I open the plugin but today it works. Maybe the initial load has an issue. I'm not able to find any way to remove the plugin to test it again.


Rename Ceph vars to avoid conflicts

This patch renames most of Ceph variables from gen-ceph-kustomize script which can conflict with vars from other scripts (e.g TIMEOUT from operator-wait.sh)
Depends-On: https://github.com/openshift/release/pull/41876

/hold


Ale should be able to jump when buffer is modified.

Information
function! ale#util#Open(filename, line, column, options) abort
    if get(a:options, 'open_in_tab', 0)
        call ale#util#Execute('tabedit ' . fnameescape(a:filename))
    else
        call ale#util#Execute('edit ' . fnameescape(a:filename))
    endif

    call cursor(a:line, a:column)
endfunction

Does not consider the buffer of associate filename get changed.
What went wrong
Although I have set hidden, vim could still complain when  the filename is file path.
How to fix
Use the buffer command to open the file when the filename  have associate buffer.

I'm having trouble understanding your issue. Could you share some steps for repeating a bug? Are you saying that jumping to a file doesn't work if you change a filename for a buffer in-between making a request to jump to a file and the response coming back?

Reproduce step：

Add set hidden to .vimrc
Open a file
Change some text
Run command :call ale#util#Open(expand('%:p'), 0,0,{} ) without save

It's annoying when jump to modified buffer.

Ah, I see what you mean. I'll think about that. Refusing to open a new file until you've saved the current on is in-line with how Vim ought to behave.

This only happens when I have set hidden and the open file is current buffer, so I think ale should check if the file is current buffer, if it is current buffer, just jump instead of use edit.

Ah, I see what you mean. That makes more sense. I'll add this to the current project and sort it out later.

I have fixed this now, and I added a test for it.


give up alignment of \ in Makefiles

Is your feature request related to a problem? Please describe.
\ at end of Makefiles are now aligned. However, every time a longer line is added, lines around have to be modified. I don't see big benefits of this alignment style, shall we drop it?
Describe the solution you'd like
Just use a single space between \ and line content.
Describe alternatives you've considered
None.
Additional context
We usually use $(NULL) to at end of a definition. I think this is for avoiding touch the last item when appending a new item.

@jwhui @abtink Thoughts?

Ping~

I don't have any strong preference here but would favor/suggest keeping it as is. I would say this is same as adding a new longer variable name in the code which with our clang-format rule could potentially cause the other definitions/lines to be re-aligned.

Thank you for sharing your inputs. Affecting other lines for alignment is not git blame friendly and also increases unnecessary reviewing efforts. As more and more code are added in, I really hope we could do something to improve reviewers experience a little bit.

I do not have a strong opinion on the \ in Makefiles. However, one could also make a similar argument that the same applies to:

End-of-line comments.
Multi-line macros.
Variable declarations.
Assignment operators.
param and retval documentation.
Method declarations.
...

Where do we draw the line?

Do these styles really improves code readability? Especially

Multi-line macros.
Variable declarations.
Assignment operators.
Method declarations.

I am fine with requiring alignment for documentation, because we usually read them directly instead of the generation of doxygen. Thoughts?

I agree and understand that style is subjective but personally I like the code style we currently use in OpenThread. I find the alignments of variable names, assignments, method declarations, multi-line macros,  etc. to make the code look nicer and help with its readability.
I agree that enforcing such a  code style can cause diffs in PRs/commits to look larger than what the change is and may make it harder for reviewers looking at the diff. But still I would favor enforcing a consistent code style:

I think the source code as a whole is read more often than any individual PR/commit, so keeping the overall style clean is worth making it slightly harder to look at the diff.
With git we can always use --ignore-space-change to see the code change only.
GitHub also provides same feature to ignore white-spaces.

agree.


SegCs is not initialized

the SegCs is not initialized in allocated Contexts by initContexts.
at line 153: *contexts[i] = *contexts[11]; have no any sense - all records anyway not initialized at this point and all zero.
only after line 265: Status = pApi->ntdll.NtGetContextThread( WaitThd, Contexts[11] ); record 11 is init ( in particular SegCs).
after this, but not before, exist sense in *Contexts[i] = *Contexts[11] in loop.
in current code in other (i  !=11) records, SegCs == 0 , despite it must be set to correct value if we set CONTEXT_CONTROL ( part of CONTEXT_FULL ). which effect this have ? on windows 10, begin from some version, this work ok, but before - first 10 versions, win 8.1 etc, after NtContinue code is crashing - the SegCs value is 0x23 instead 0x33, and Rip/Rsp is trancated to 32bit values
also instead N time allocate sizeof(CONTEXT) (and then free it N time) why not allocate 1 time N*sizeof(CONTEXT) and free it also only once

the SegCs is not initialized in allocated Contexts by initContexts. at line 153: *contexts[i] = *contexts[11]; have no any sense - all records anyway not initialized at this point and all zero. only after line 265: Status = pApi->ntdll.NtGetContextThread( WaitThd, Contexts[11] ); record 11 is init ( in particular SegCs). after this, but not before, exist sense in *Contexts[i] = *Contexts[11] in loop. in current code in other (i !=11) records, SegCs == 0 , despite it must be set to correct value if we set CONTEXT_CONTROL ( part of CONTEXT_FULL ). which effect this have ? on windows 10, begin from some version, this work ok, but before - first 10 versions, win 8.1 etc, after NtContinue code is crashing - the SegCs value is 0x23 instead 0x33, and Rip/Rsp is trancated to 32bit values
also instead N time allocate sizeof(CONTEXT) (and then free it N time) why not allocate 1 time N*sizeof(CONTEXT) and free it also only once

Hi! I'm facing the exact same problem. In such a long time, did you manage to solve it?


Why choose us buttons need improvement, our accomplishments cards can be more designed, reach out can be rearranged in a better way The event page should be reorganised , its UI can be improved and box shadows can be made more consistent with the colour scheme of the website

Following Issues Can be seen:
[ ] Why choose us ? : buttons need improvement in UI and functionality
[ ] Our accomplishments : the cards can be designed more to look beautiful and consistent with the theme of the website
[ ] Reach out us through : this as a whole needs improvements
[ ] The event page : UI can be improved, box shadows can be more experimented with to look fitting with the other elements of the page.
Kindly assign me this issue so I can work for the betterment of this amazing project :)

There are many existing issues ( #54 #65)  addressing this problem. Let's continue the discussion there. Closing this.
If you have any other questions, feel free to open this up :)


Add new installer options

[x] Add NVMeFix (resolves #22)
[x] Add Intel Bluetooth (resolves #233)
[x] Update DW1820A solution (resolves #243, fixes #125)

Okay I will wait for that.


Compiler eats all avaialbe memory and crashes with a recursive macro

$ cat runner.cr
macro runner
  {{ run("./source.cr") }}
end
runner

$ cat source.cr
require "./runner"

$ crystal build runner.cr

Compiler starts eating cpu and memory:

Finally, it crashes when free memory not available anymore:
Error executing system command '/bin/sh': Cannot allocate memory
_init +170337 [80]
_init +2399237 [80]
_init +2421599 [80]
_init +2420152 [80]
....
_init +193658 [80]
_init +189991 [80]
__libc_start_main +240 [80]
_init +164313 [80]
 +164313 [80]

Error: you've found a bug in the Crystal compiler. Please open an issue: https://github.com/manastech/crystal/issues

Does it possible to detect such situation and warn ? It could be hard to understand what's going on in a large project.

Or a bit simpler:
# runner.cr
macro runner
  {{ run("./runner.cr") }}
end
runner

I'm afraid that would (probably) be impossible.
Did this happen to you accidentally, or you tried to crash the compiler on purpose?

Accidentally. Bad side of this is editor/ide freezing(if this editor/ide is doing recompilation of a source automatically) and a chance of losing a source code updates. That happen to me with vim syntastic plugin. But that's because I didn't understand how macro works.
In general, compile time recursion could be a powerful feature. Just now noticed few examples in C++.
Seems, this issue does not makes sense now. You may close it if do not plan updates.
Thanks!

Isn't syntastic just a syntax checker?

Yes it is. And it uses a following command to check a syntax:
$ crystal run --no-build --no-color {source.cr}

Yes I just saw, you're correct. Still, this is because vim doesn't allow async ops. I'm presuming an IDE will not have this problem. Vim does not have async by design, so you can't really blame it either.

IDE will not freeze, but compiler will consume all memory.

I have to agree that this is most likely impossible to handle. If somebody can prove me wrong please comment or open a new issue! But I see no benefit in keeping this open :)


How to debug whitescreen of death?

One of my templates stopped working from one second to the other and instead I get a blank site, sometimes a 500 error. There is nothing that would give me a hint about what goes wrong - debug bar and it's Timber extension don't work either because nothing gets loaded.
How can I debug such a situation?

Have you got WP_DEBUG turned on? And have you checked apache/error logs (for the 500 error)?

Thanks for the advice. It was more of a general question. Because luckily I have an up-to-date multi dev env and could just pull in the staging database to get back to work. I have no clue what caused the error, but I will note that 500 should be in WP_DEBUG log.


Swapped navigation to Jetpack Compose Destinations

I've downgraded the compose version to 1.2 in order to use the Jetpack Compose Destinations library. I've tried to make it as much scalable as possible. Let me know if I had violated the project structure or any other clean code. I'll correct and will create another pull request.

Hi, Thank you for your contribution. Looks like you dedicated your time entirely for this. I will for sure acknowledge your contribution at my social profiles.
Also I will review this PR soon. Until then please run spotless apply command to clean ups wildcard imports.

Thank you. I've some pending work to do. I'll look into the spotless evening.

I ran optimize imports before committing the repo. So there occurred multiple wild card imports. Is there any shortcut to get class imports?

Btw I guess UI Tests needs to be rewritten na?

Btw I guess UI Tests needs to be rewritten na?

I think, Yes, but now it's easy to write them. I mean we have abstraction there.

Btw I guess UI Tests needs to be rewritten na?

I think, Yes, but now it's easy to write them. I mean we have abstraction there.

Yup. Got it. I would do that so I can also get familiar with the Compose Destination library. I would merge this PR soon!

@rvenky125 Found an issue.
https://user-images.githubusercontent.com/83884225/181865101-5d20f53a-ae1d-4f0f-847f-3b1d05fc7901.mp4
I'm debugging this issue too. Let me know when you find any fix.

@rvenky125 Found an issue.
screen-20220730-065545.2.mp4
I'm debugging this issue too. Let me know when you find any fix.

Oh, I'll check that now

@rvenky125 Found an issue.
screen-20220730-065545.2.mp4
I'm debugging this issue too. Let me know when you find any fix.

Oh, I'll check that now

I found what's the issue. Please refer to the pending review at top :) .

@rvenky125 Found an issue.
screen-20220730-065545.2.mp4
I'm debugging this issue too. Let me know when you find any fix.

Oh, I'll check that now

I found the issue. Please refer to the pending review at top :) .

@rvenky125 Found an issue.
screen-20220730-065545.2.mp4
I'm debugging this issue too. Let me know when you find any fix.

Oh, I'll check that now

I found the issue. Please refer to the pending review at top :) .

Yeah, I fixed that and committed.

No issues. You did a lot of refactoring in past few days. Great and Thank You again for this hard work.

Also there are lot of code violation when you run gradle spotlessCheck. Please run gradle spotlessApply to fix all those.

Also there are lot of code violation when you run gradle spotlessCheck. Please run gradle spotlessApply to fix all those.

Is it? I've already run that. I just run again. Can you pls check again with the latest commit?

I just realized that I've changed the way of using the backhander. Do you really need it as a dependency? If yes, I'll commit by implementing it.

I just realized that I've changed the way of using the backhander. Do you really need it as a dependency? If yes, I'll commit by implementing it.

I've implemented that backhander as a dep. Let me if you wanted to be in the code.

No issues. You did a lot of refactoring in past few days. Great and Thank You again for this hard work.

I'm thankful to you also. I've learnt how to implement compose destinations in Multi Module arch.

Also there are lot of code violation when you run gradle spotlessCheck. Please run gradle spotlessApply to fix all those.

Is it? I've already run that. I just run again. I'm getting BUILD SUCCESSFUL. Can you pls check again with the latest commit?

if You got Build Success, then check if there is any uncommitted files.

I just realized that I've changed the way of using the backhander. Do you really need it as a dependency? If yes, I'll commit by implementing it.

I've implemented that backhander as a dep. Let me if you wanted to be in the code.

Can you please share the file or line number?

Also replace the content of the file inside of .github/workflows/android_action.yml to this and push the changes so the code review process will start in Github Actions.

I just realized that I've changed the way of using the backhander. Do you really need it as a dependency? If yes, I'll commit by implementing it.

I've implemented that backhander as a dep. Let me if you wanted to be in the code.

Can you please share the file or line number?

It's the HomeScreen composable. Where in previous you have backhander as function to it. But I've replaced it with direct import of BackHandler. Once check the changes in HomeScreen composable, You'll get an idea

Thank you @rvenky125 for your valuable contribution to this repository.

Thank you @rvenky125 for your valuable contribution to this repository.

It's my pleasure. It's my first contribution and you liked it. It's encouraging me to do more contributions.

Definitely. Also, Open source contributions can be added on your portfolio/resume as well and believe me, it helps a lot.

Definitely. Also, Open source contributions can be added to your portfolio/resume as well and believe me, it helps a lot.

Yes, I learnt Android/React native development on my own. I just had my BSC and got a job as a junior SE in a startup company. Mostly it has React Native projects. I'm not that much joy with React native as Android. I wanna become experienced Android Developer. I feel very happy to take any career suggestions from you.
I'll try to contribute as much as possible besides doing my work ☺


WIP: Update documentation

Update documentation for molecule.

Can we drop the use of docker here and maybe just have the getting started run against localhost?
This might necessitate the need for a follw on docs about "standing up infrastructure for a molecule scnearion" guide but it might be easier to demonstate the capabilities of molecule agains localhost


entrystream: use disksort to reduce memory requirements [phab:D718]

Created by schroederc at 2016-02-16 18:03:10:

shahms accepted this revision at 2016-02-16 18:06:33

schroederc closed via commit 630abcf7544146c5ce4c4749a5421625155a84e9 at 2016-02-16 18:21:42


Simplify get simulator command + reduce launch time

Bonus track: Kill all processes by moving everything to CommandsCore

PR is ready to be reviewed ;) @BasThomas @q231950

Uh-oh: it seems to be crashing locally:
2017-10-23 09:10:06.982187+0200 Calabash Launcher[1282:254051] *** Assertion failure in -[NSMenu itemAtIndex:], /Library/Caches/com.apple.xbs/Sources/AppKit/AppKit-1504.83.101/Menus.subproj/NSMenu.m:940
2017-10-23 09:10:06.982400+0200 Calabash Launcher[1282:254051] Failed to set (contentViewController) user defined inspected property on (NSWindow): Invalid parameter not satisfying: index >= 0
rm: /tmp/calabash_pipe: No such file or directory


Open Question: Handling enterprise search tags

When sharing a historic conversation (pressing the send button), the search tags for enterprise search get updated. The tags and search results might change. Due to the fact, that the new information has a different character (they were not extracted in the "real" ongoing conversation) the search results might be biased.
How do we handle that?

The best approach IMHO would be to exclude (or at least handle differently) the messages that are added by the widget (the backend already gets this informations). In addition there is a need of token "aging". @westei what do you think.


[Bug] The hidden column list is not bounded and overflows in height

Steps

Drag a table
Add many columns to the table data
Click on the column visibility option in the table
A very large list of columns is displayed

Expected
The list of columns should have a bounded height and scroll

Happy to do this one if you would like to assign :-)

@A-Scratchy Good to hear you got the setup running on your system. This issue is yours for the taking! 🎉


SubIFD GPS Decode Error: Unexpected format for GPSAltitudeRef

also with some files:
Could not decode SubIFD GPS:
 Illegal format for known tag! Tag: GPSAltitudeRef("") Expected: STRING Got: INT8U

Originally posted by @mschnell1 in https://github.com/TechnikTobi/little_exif/issues/32#issuecomment-2438852691
Required:

Example file that causes the above error

www.bitvibe.de/Upload/2017_stuttgart_07_.jpeg

Fix will be available in the next beta


Reschedule release because of daylight saving time

Summertime

Coverage remained the same at 84.797% when pulling 5a26dd5563d26a29453a2ed5bd8ac6d7952d8645 on reschedule-release-to-daylight-saving-time into 43529f261229e67a35d95857b172205bc9f3eab4 on develop.


Support for darklua

Within my darklua configuration, I have the following:
"bundle": {
    "modules_identifier": "__DARKLUA_BUNDLE_MODULES",
    "excludes": [],
    "require_mode": {
        "name": "path",
        "module_folder_name": "index",
        "sources": {
            "core": "./src/core",
            "modules": "./src/modules"
        }
    }
},

This lets me do require("core/utilities") in any file which is really useful. I'm aware there is a way to do this within the settings already, but an automated version would be great (via darklua)

This isn't really something for luau-lsp to do. Like you say, there are ways to update the settings to get this done. Developing a fully automated system is a bit overkill, and also requires luau-lsp to unnecessarily understand the config of an unrelated tool.


Fix bug wrong metadata on translated docs

Motivation
There is a bug where metadata files are generated incorrectly when using multilingual features.
When processMetadata function is called in translated_docs, the logic to determine the multilingual language has bug.
We already knew the language so We did not have to do it twice.
[Incorrect - core/metadata.js]
The language is reversed (en - ko).

Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
using multilingual features.
[Correct - core/metadata.js]

Related PRs
https://github.com/facebook/Docusaurus/commit/e273dfc13b4031d4d20180d0de30b1c5280d2bf8#diff-a6ea8ce8e7c294d50b747139bc956138

I know a lot more bugs related to this project's multilingual, and I was fixed it. However, there are many cases where we need to change the structure a lot, so I want to send PR in gradually.

I know a lot more bugs related to this project's multilingual

😮
What are some of these bugs?

Https://reasonml.github.io use multi language support.
I actually found out about this bug too when working on subdirectories, athough it will be fixed on #705.
We use processMetadataFile for docs & translated docs and they have a structure like
docs/:language/:filename.md and translated_docs/:language/:filename.md
The logic to determine multilingual has bug just like what this PR address.So i refactored the logic on that PR. Anyway, My test website has almost 100% language translation for docs in crowdin. I think the language is support is fixed.
Can see a test page at
https://endiliey.com/docs/ko/docusaurus/introduction.html

We are running our docs in 3 languages and hope to support 2 more. So I don't believe its true that no one is running multilingual. http://loomx.io/developers

This largely fixes our issues in the sidebar with Japanese and Chinese language seeping into the English docs

Oh I saw that @mattkanwisher. Chinese meta in your english docs

Sorry that I had to use your doc site to test my PR. Glad that it also fix metadata.
// website/package.json
"devDependencies": {
    "docusaurus": "endiliey/Docusaurus#subdir",

This PR should fix it as well

Closed in favor of #705


Can't resolve 4.4.2 version via Swift Package Manager

Hi,
Xcode can not resolve latest 4.4.2 version via Swift Package Manager, if I specify 4.4.2 as version.
This is the error I get from Xcode:
Dependencies could not be resolved because no versions of 'mobile-sdk-ios-swift-package' match the requirement 4.4.2..<4.5.0 and root depends on 'mobile-sdk-ios-swift-package' 4.4.2..<4.5.0.
Although if I use 4.4.2-rc.1 version (which is undocumented) then everything seems to work fine
Is this expected?

Thanks for reporting this, I had forgotten to push the tag for 4.4.2 to the GitHub repository. Should be fixed now.


Set transport type?

Hello,
can you set transport type i.e. car or walking?

Hey, sorry for the late reply. Yes, you can specify the mode 👍 The basic API calls let you pass the necessary option.

Thanks, found it


docs: fix documentation sdk url

Proposed changes
/api/sdk was changed to /sdk, this PR fixes the URL.
Types of changes

[x] Docs (documentation only changes)

Checklist

[x] I have read the CONTRIBUTING documentation
[x] I have read the WRITING DOCUMENTATION guidelines

Codecov Report

Merging #22 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #22   +/-   ##
=======================================
  Coverage   90.71%   90.71%
=======================================
  Files          40       40
  Lines         883      883
=======================================
  Hits          801      801
  Misses         82       82

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 051f90a...97cf553. Read the comment docs.


Add tooltips for pext track

Show a tooltip and highlight the region.

Blocked by broadinstitute/gnomad-browser-toolkit#44.

On second thought, the performance issues with tooltips aren't a blocker. There's a similar issue with the expanded ClinVar variants track.


Android 10 video select path error still not fixed (even if it should?)

Bug Report
Problem
Wen trying to select a video from the gallery an error occurs saying  the path is not found.
What is expected to happen?
The video gets loaded into the app
What does actually happen?
Error: Error copying file File: [cordova]/localhost/sdcard/DCIM/Camera/20220314_175211.mp4 to 'temp1'. The file or directory was not found (Cordova: NOT_FOUND_ERR).
Information

The problem is probably the same as in https://github.com/apache/cordova-plugin-camera/issues/573 because if I use that fork instead it works perfectly. The ticket is closed so I expected it to work.
Command or Code

Environment, Platform, Device

Samsung Galaxy S9
Version information

cordova-plugin-camera: 6.0.0
Android: 10
Checklist

[x ] I searched for existing GitHub issues
[x ] I updated all Cordova tooling to most recent version
[x ] I included all the necessary information above

In v8 external storage paths are now passed as content:// uris and utilises the media store APIs for temporary access grants.
file:// paths that was previously used does not work on API 29, but did work on API 30+ with proper permissions.
Should be fixed by:

https://github.com/apache/cordova-plugin-camera/pull/889
https://github.com/apache/cordova-plugin-camera/pull/902


command to list current settings?

Hi,
When I press the button on the top of my Aerox 3, a color pulses on the bottom. I assume I'm cycling through profiles with different sensitivities.
How would I list those profiles, and/or just list the current dpi settings etc?
I see options for setting all of these values, but not getting them.
Thanks!

Hello
There is no way to read the current config from the device.
Currently, Rivlacfg stores the last known settings in a file (in prevision for a future GUI), but it does not provide a CLI option to display it. You can find you settings in ~/.config/rivalcfg/*.json files :)


created a sign in page

This is a sign in page created to practice html and css

What Happened Ram ?

I have issues with merging, I'll open another pr once it is fixed

Okay !


Clarify Method imports for client DSL in docs

Clarifies the documentation to specify that org.http4s.Methods._ is imported into scope with the default routing DSL, and that the client DSL needs an extra import in order for some of the examples to compile.
Changes could/should also be made for the current 0.20.x documentation, if it all looks good I'll write this up for that as well.

Thanks, @sloshy.  I think the build is failing because it's Method, not Methods.  The clarification is helpful!

@rossabaker You're right - my mistake. Should be fixed up now.


bootstrap-sortable need update

As https://github.com/Sjeiti/TinySort have more updates and fixes,  for example.  https://github.com/Sjeiti/TinySort/issues/102
But bootstrap-sortable not updated for long time.
So it is better  for bootstrap to add new support for the tinysort versions

thanks, I will update

Needs TinySort update and also, needs to solve all the issues existing from March...
We all understand you did this "for the love of art" and for that, we can't demand you anything. But your plugin got quite popular and so you've a responsability about it.
If this is not the case anymore, simply just close the project and announce you're finished with it.
This way, we'll be able to refactor our code to something more mature like, DataTables, i.e.


Omit params import conditionally

Building after codegen was failing because there was no parameters/index.ts; omitting the import altogether if there are no parameters available.

User error! Meant to PR this against the @nmbrco fork


Not all Module functions are exposed

Couldn't find Assert-StringEqual or Asserts-ObjectEqual

Fixed, now all assertion that are at least a bit ready to be published are published.


Update Natural Language docs links (404s + quickstart)

@kimcam Why does the CLA bot not trust you? I assume you still on Cloud team in SEA / KIR?

I signed it!

@dhermes yeah apparently my personal account isn't tied to corp, going to fix that soon :)


error while npm install

i can't run the command nom install successfully  the error message is :
make: Leaving directory '/home/pi/homebridge/lib/HAP-NodeJS/node_modules/ed25519/build'
npm ERR! Linux 3.18.0-20-rpi2
npm ERR! argv "/usr/bin/node" "/usr/bin/npm" "install"
npm ERR! node v0.12.4
npm ERR! npm  v2.10.1
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>install: node-gyp rebuild
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script 'node-gyp rebuild'.
npm ERR! This is most likely a problem with the mdns package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node-gyp rebuild
npm ERR! You can get their info via:
npm ERR!     npm owner ls mdns
npm ERR! There is likely additional logging output above.
npm ERR! Please include the following file with any support request:
npm ERR!     /home/pi/homebridge/lib/HAP-NodeJS/npm-debug.log
gyp ERR! build error
gyp ERR! stack Error: make failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/usr/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:269:23)
gyp ERR! stack     at ChildProcess.emit (events.js:110:17)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (child_process.js:1074:12)
gyp ERR! System Linux 3.18.0-20-rpi2
gyp ERR! command "node" "/usr/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /home/pi/HAP-NodeJS/node_modules/mdns
gyp ERR! node -v v0.12.4
gyp ERR! node-gyp -v v1.0.3
gyp ERR! not ok
npm ERR! Linux 3.18.0-20-rpi2
npm ERR! argv "/usr/bin/node" "/usr/bin/npm" "install"
npm ERR! node v0.12.4
npm ERR! npm  v2.10.1
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>install: node-gyp rebuild
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script 'node-gyp rebuild'.
npm ERR! This is most likely a problem with the mdns package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node-gyp rebuild
npm ERR! You can get their info via:
npm ERR!     npm owner ls mdns
npm ERR! There is likely additional logging output above.
npm ERR! Please include the following file with any support request:
npm ERR!     /home/pi/HAP-NodeJS/npm-debug.log
its on Ubuntu 12 on RPI 2

try using debian, that is the proven one for RPi...

Hi,
I've just received my RPI 2, with Raspbian installed, and I got the same kind of issue when I run "npm install". It seems to be linked to MDNS ...

@FlyingTom I suggest you install node-gyp without the -g option. I solved it that way on my RPi.
sudo npm install node-gyp

Make sure you run this command inside the HAP-NodeJS directory.

@legotheboss Thanks but unfortunately it dos not solve the issue...
Here the error I got when I run "npm install" :

<EMAIL_ADDRESS>install /home/pi/HAP-NodeJS/node_modules/mdns
node-gyp rebuild

make: Entering directory '/home/pi/HAP-NodeJS/node_modules/mdns/build'
CXX(target) Release/obj.target/dns_sd_bindings/src/dns_sd.o
In file included from ../src/dns_sd.cpp:1:0:
../src/mdns.hpp:32:20: fatal error: dns_sd.h: No such file or directory
compilation terminated.
dns_sd_bindings.target.mk:133: recipe for target 'Release/obj.target/dns_sd_bindings/src/dns_sd.o' failed
make: *** [Release/obj.target/dns_sd_bindings/src/dns_sd.o] Error 1
make: Leaving directory '/home/pi/HAP-NodeJS/node_modules/mdns/build'
gyp ERR! build error
gyp ERR! stack Error: make failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/usr/local/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:269:23)
gyp ERR! stack     at ChildProcess.emit (events.js:110:17)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (child_process.js:1074:12)
gyp ERR! System Linux 3.18.7-v7+
gyp ERR! command "node" "/usr/local/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /home/pi/HAP-NodeJS/node_modules/mdns
gyp ERR! node -v v0.12.4
gyp ERR! node-gyp -v v1.0.3
gyp ERR! not ok

<EMAIL_ADDRESS>install /home/pi/HAP-NodeJS/node_modules/srp/node_modules/bignum
node-gyp configure build

make: Entering directory '/home/pi/HAP-NodeJS/node_modules/srp/node_modules/bignum/build'
CXX(target) Release/obj.target/bignum/bignum.o
SOLINK_MODULE(target) Release/obj.target/bignum.node
SOLINK_MODULE(target) Release/obj.target/bignum.node: Finished
COPY Release/bignum.node
make: Leaving directory '/home/pi/HAP-NodeJS/node_modules/srp/node_modules/bignum/build'
npm ERR! Linux 3.18.7-v7+
npm ERR! argv "/usr/local/bin/node" "/usr/local/bin/npm" "install"
npm ERR! node v0.12.4
npm ERR! npm  v2.10.1
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>install: node-gyp rebuild
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script 'node-gyp rebuild'.
npm ERR! This is most likely a problem with the mdns package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node-gyp rebuild
npm ERR! You can get their info via:
npm ERR!     npm owner ls mdns
npm ERR! There is likely additional logging output above.
npm ERR! Please include the following file with any support request:
npm ERR!     /home/pi/HAP-NodeJS/npm-debug.log

I've fixed the issue by installing a missing package:
sudo apt-get install libavahi-compat-libdnssd-dev
Now I'm able to build the project, but when I start it, I've have the following warnings:
~/HAP-NodeJS $ node BridgedCore.js
*** WARNING *** The program 'node' uses the Apple Bonjour compatibility layer of Avahi.
*** WARNING *** Please fix your application to use the native API of Avahi!
*** WARNING *** For more information see http://0pointer.de/avahi-compat?s=libdns_sd&e=node
*** WARNING *** The program 'node' called 'DNSServiceRegister()' which is not supported (or only supported partially) in the Apple Bonjour compatibility layer of Avahi.
*** WARNING *** Please fix your application to use the native API of Avahi!
*** WARNING *** For more information see http://0pointer.de/avahi-compat?s=libdns_sd&e=node&f=DNSServiceRegister
HAP-NodeJS starting...
TCP server accepting connection on port: 51826
HAP Server is listening

These particular warnings are "normal" and can be safely ignored. It looks like it's working otherwise?

Yes it's working :)

@FlyingTom .Already installed libavahi-compat-libdnssd-dev but still have the same issue.any suggestion?
make: Entering directory '/home/pi/HAP-NodeJS/node_modules/mdns/build'
CXX(target) Release/obj.target/dns_sd_bindings/src/dns_sd.o
In file included from ../src/dns_sd.cpp:1:0:
../src/mdns.hpp:32:20: fatal error: dns_sd.h: No such file or directory
compilation terminated.

i tried:
sudo apt-get install libavahi-compat-libdnssd-dev
followed by an explicit:
sudo npm i -g mdns
.. and that worked.  mdns is at 2.4.0 as of writing.

@dariusz as of this spring, the mdns dependancy was removed from hap-nodejs.  So on a recent install this would have no impact.


Vite & Turborepo & Emotion Bug

Describe the bug
If i use @emotion/styled to style ChildComponents (https://emotion.sh/docs/styled#targeting-another-emotion-component) in an package i get an error on running dev, and on running a build, there is no error, but it doesn't work.
Component selectors can only be used in conjunction with @emotion/babel-plugin, the swc Emotion plugin, or another Emotion-aware compiler transform.

If loading from within the vite repo it works fine.
It seams like this may be an issue related with vite. If you think any of the other librarys is the problem i will open an issue there.
Reproduction
https://github.com/wuifdesign/turborepo-vite-emotion-bug
Steps to reproduce
run npm install
run npm run dev
You will see 2 components:

the first will throw an error (loaded from UI).
The second will render fine (loaded from vite project)

System Info
System:
    OS: Windows 10 10.0.22621
    CPU: (20) x64 12th Gen Intel(R) Core(TM) i7-12700K
    Memory: 20.67 GB / 31.80 GB
  Binaries:
    Node: 18.9.1 - C:\Program Files\nodejs\node.EXE
    npm: 8.19.1 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Edge: Spartan (44.22621.674.0), Chromium (106.0.1370.47)
    Internet Explorer: 11.0.22621.1

Used Package Manager
npm
Logs
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

By changing this line to const plugins = true ? [...babelOptions.plugins] : [] , it worked.
https://github.com/vitejs/vite-plugin-react/blob/45fbe2235fc73c498a952aa3cb2bcacb0a57461a/packages/plugin-react/src/index.ts#L233
Closing as a duplicate of https://github.com/vitejs/vite-plugin-react/issues/16.


Users/ianleg/fx utc

Add UTCNow, UTCToday, IsUTCToday function implementations and resources
Add updated error strings for formula columns scenarios
Update unit test infra to be able to tag engine-independent compilation errors with "Compile Error"

Nit: update the PR title to something more meaningful


Include suggested technologies in results

It would be useful to see suggested technologies and their popularity in addition to the technologies that are already being tracked by the service. The information about suggested technologies is available from http://caniuse.com/issue-list

Perhaps the command line tool could also promote the possibility to vote about the technologies that should be added next. The voting is done by adding a comment "+1" to the issue in GitHub.

For example the "URL Standard" feature is currently at position 138 with 7 votes. Perhaps this could be presented as follows.
URL Standard (suggested) 🏆 138 👍 7
  +1 at https://github.com/Fyrd/caniuse/issues/1312

Now I am thinking. Perhaps this feature would also be useful for the caniuse site. I imagine implementing it there first would make it easier to support the feature in the command line tool since it could then be included in the response to a single search request.


When delete a branch, it should not show creating a new pull request hint on console.

➜  git git:(master) git push origin :appleboy-patch-1
remote:
remote: Create a new pull request for 'appleboy-patch-1':
remote:   http://localhost:3000/lunny/git/compare/master...appleboy-patch-1
remote:
To localhost:lunny/git.git
 - [deleted]         appleboy-patch-1

@JulienTant


Implement AccessControl

Fixes #249

Have you though about doing a 2-step admin transfer, similar to #275?

Have you though about doing a 2-step admin transfer, similar to #275?

Unlike Ownable (ERC173) which is one step, AccessControl is by design two steps.

Step one: grant role to the new admin
Step two: either the old admin renounce its role, of the new admin revokes the old admin.

Closed in favor of #373


[Feature] Option to disable toggle animation

If you just set the animation speed to 0, it will be off.

Thanks @MarleDK . That's the correct answer - just go to Settings (Ctrl + ,) in Atom, "Packages", "Termination", and then select our settings. From there you can set animation speed to 0 (it's 1 by default).

there should be info about 0 -> disables animation on the tooltip

@nicman23 Done, thanks!


Add support for layout transitions

Currently it appears there is only support for page level transitions. There is a workaround suggested here but as you can see this gives concurrent transitions (ie. mode is not respected so enter/leave transitions are triggered at the same time).
I think this suggestion makes sense. Though it might be best to specify a global setting in nuxt.config.js and then allow this setting to be overridden somehow (ie. in the layout component).

Just a thought - I guess I could alternatively use nested page components to achieve the desired result, but then why do we need layout components? hmmm

@Atinux I'd really appreciate a little guidance here. I've been trying various ways of going about adding layout transitions, aiming to make use of Vue's built in transition module. I'm currently trying to use the parent/root state and determine whether to re-render the nuxt-child component. This kinda works if the layout is changing because I'm able to store and compare the layout components _uid property, the problem is when the layout isn't changing.
I think ideally what I need is a way to obtain the layoutName from the nuxt-child component based on the data.key property passed to the render() function. Can you think of a "simple" way to do this?

closed via #1620


github_gemini directory not installed

Following the installation instructions at https://gemini.readthedocs.org/en/latest/content/installation.html#automated-installation I do this:
wget https://github.com/arq5x/gemini/raw/master/gemini/scripts/gemini_install.py
tools=/usr/local/gemini data=/Users/xxx/data/gemini # username obscured here
python gemini_install.py $tools $data

The script runs without error and at the end I get:
 Run tests with:
  cd /Users/xxx/data/gemini/github_gemini && bash master-test.sh

gemini runs OK:
~: export PATH=/usr/local/gemini/bin:$PATH
~: which gemini
/usr/local/gemini/bin/gemini
~: gemini -v
gemini 0.18.3

but the directory containing the testing script has not been created:
~: ls /Users/xxx/data/gemini/github_gemini
/opt/pkg/bin/gls: cannot access /Users/xxx/data/gemini/github_gemini: No such file or directory

I am using:
OS X El Capitan version 10.11.4
and:
Python 2.7.10 (default, Oct 23 2015, 19:19:21)
[GCC 4.2.1 Compatible Apple LLVM 7.0.0 (clang-7<IP_ADDRESS>)] on darwin

This is a change to how gemini is installed. you'll have to clone the github
repo if you want to run the tests. I'll leave this open as a reminder to update the docs.


Make game log more efficient

The player-facing game log stores the 200 most recent lines in the game state. While this is convenient to access, this is memory inefficient, since each line of the log will be redundantly copied in several game states. We need a new implementation for the game log that stores each line of the log only once.
One possibility would be to store only the new lines of the log to the game state. When it comes time to render the game log, the client would go through the previous game states and pull those log lines.

Turns out the log does not grown quadratically since the undo stack is reset every turn end.
Chris Swithinbank
@delucis
[00:48](https://gitter.im/boardgame-io/General?at=625e696ac435002500485e38)
@kevinddchen G is copied to the undo stack although that is reset every time a turn ends, so it won’t grow constantly over the life of a game (unless you have just one player I guess). Before you implement this, have you seen boardgame.io’s built-in log? You’ll receive a log property on the client with an entry for each game action. (This is what is visualized in the Log tab of the Debug panel.) You can even attach extra information to the log using the ctx.log.setMetadata method from a move: https://boardgame.io/documentation/#/debugging?id=custom-metadata-in-game-logs

Do note: if too much information is passed between the client and the server (e.g. game log is gigantic) this will create latency issues


records-ui: urlize links in citation text

If there are DOI links serialized in the citation text, they should be clickable links (cc @tmorrell).
Before:

After:

Two fixes:

HTML-escaping the original citation using _.escape) to prevent XSS attacks
Updated the regex to avoid matching some punctuation points (dots, commas, semicolons) so that we don't end up with links like https://doi.org/10.1234/foobar.


Chef Supermarket

Hi,
I used tomcat cookbbook (from Chef) from chef supermarket and got the below issue. Please guide me the next steps

default-ubuntu-1604.log
================================================================================
Error Resolving Cookbooks for Run List:
================================================================================
   Missing Cookbooks:
   ------------------
   No such cookbook: testkitchen

   Expanded Run List:
   ------------------
   * testkitchen::default

   System Info:
   ------------
   chef_version=14.3.37
   platform=ubuntu
   platform_version=16.04
   ruby=ruby 2.5.1p57 (2018-03-29 revision 63029) [x86_64-linux]
   program_name=/opt/chef/bin/chef-client
   executable=/opt/chef/bin/chef-client

   Running handlers:
   [2018-08-29T04:29:49+00:00] ERROR: Running exception handlers
   [2018-08-29T04:29:49+00:00] ERROR: Running exception handlers
   Running handlers complete
   [2018-08-29T04:29:49+00:00] ERROR: Exception handlers complete
   [2018-08-29T04:29:49+00:00] ERROR: Exception handlers complete
   Chef Client failed. 0 resources updated in 00 seconds
   [2018-08-29T04:29:49+00:00] FATAL: Stacktrace dumped to /tmp/kitchen/cache/chef-stacktrace.out
   [2018-08-29T04:29:49+00:00] FATAL: Stacktrace dumped to /tmp/kitchen/cache/chef-stacktrace.out
   [2018-08-29T04:29:49+00:00] FATAL: Please provide the contents of the stacktrace.out file if you file a bug report
   [2018-08-29T04:29:49+00:00] FATAL: Please provide the contents of the stacktrace.out file if you file a bug report
   [2018-08-29T04:29:49+00:00] FATAL: Net::HTTPServerException: 412 "Precondition Failed"
   [2018-08-29T04:29:49+00:00] FATAL: Net::HTTPServerException: 412 "Precondition Failed"

D      Cleaning up local sandbox in C:/Users/SRAVAN~1/AppData/Local/Temp/default-ubuntu-1604-sandbox-20180829-700-tvjchp

------Exception-------
Class: Kitchen::ActionFailed
Message: 1 actions failed.
Converge failed on instance .  Please see .kitchen/logs/default-ubuntu-1604.log for more details
Please see .kitchen/logs/kitchen.log for more details
Also try running kitchen diagnose --all for configuration

@Sravan-jk
Attach your cookbook here.

Hi arun,
PFA
testkitchen.zip

@Sravan-jk
I've tested your cookbook, kitchen converge is successful but I could not check any output using IP.
In kitchen.yml file for ssh_key: ./Kitsetup.pem (as .pem file is in same folder).
This path C:/Users/Sravan J/Desktop/Chef/chef-repo/cookbooks/testkitchen/Kitsetup.pem has space in it, I think this is not valid.
so try ./Kitsetup.pem

Is this resolved?

Thanks, forgot to close this


Over current not handled properly

When an over current situation occurs in the M1k, things go crazy - they don't need to.
In the schematic - the ADM1177-1ARMZ (U2) handles over current of the device, and turns off power to the analog section.
The ADM1177-1 is connected to the ATSAM3 via I2C. I2C can periodically (~2 Hz) read the Status Byte to see if an overcurrent event has happened - and checking HS_ALERT (The hot swap operation has failed since the last time this was reset). If this has been set - the data transfer should stop, (you are sending garbage up the stack), and notify the stack that an over current has happened on the device.
This will effect libsmu as well - as it will need to handle this async event.
-Robin

This is something that should be investigated: reading the ADM1177-1's status periodically might not be possible if the sampling rate is set to 100kSPS (too many things in very short time).
Dragos

In discontinuous mode - (repeated buffers) - we should be able to check at the end of the buffer. (maybe?)
-Robin

While not a show-stopper, it would be good to get this resolved relatively quickly for the sake of the students that will be participating in the summer camp labs.

This is mainly working in recent fw versions and libsmu, it's just waiting on #11 now for some fixes.

Closing this in favor of #11 since overcurrent support now exists and works, it just requires a fix for full support.


Create calculation/route/data workflow that provides historical calculations for passive rewards

Problem:

Passive rewards calculations happen within the contract and are not available historically
Passive rewards should be tracked historically so APY/rewards can be visualized to the user
veOCEAN contract is able to provide balance at a specific height, and at specific checkpoints, enabling us to derive rewards distributed

DoD:

[ ] Passive rewards logic has been rewritten so historical rewards can be calculated
[ ] Historical passive rewards are calculated and are generating the required data to serve this via a route
[ ] DB route has been setup and is serving historical passive rewards

Please add your planning poker estimate with Zenhub @KatunaNorbert

Please add your planning poker estimate with Zenhub @trizin


Add commit hook to check the coding style

I suggest adding a commit hook that would disable committing if the changed files do not follow the coding style. The downside is that this requires us to have pycodestyle installed on the machine that we commit.
@eth-cscs/reframe-devteam What do you think?

We can make the travis CI do that without having to install something. Just a pip is needed.

I have played a little bit with travis regarding this issue. In travis you cannot have independent tabs showing for the pull request. Thus the pycodestyle check would have to be added in the script step. Maybe the situation changes with the Build Stages feature which is currently in beta.

@teojgo Thanks for investigating. IMHO, even build stages are not what we want ideally, cos we do not want to the whole CI to fail just because of the coding style. Anyway, we freeze this issue for the moment.

After a more thorough search, it seems that the following github app does what we want: https://github.com/OrkoHunter/pep8speaks. It offers configuration options regarding the pep8 rules to ignore via a .yml file resting in the repo.

Looks exactly what we want. I think we can schedule this in the upcoming sprint.

@teojgo Could we set up another travis CI test that would run pycodestyle?

I am searching for a way to incorporate the code style checking in the CI.


LetWM pager in cnx-contrib

It's me again!
I'm currently coding a pager for LeftWM, which takes a monitor name, stream the result of letwm-state and allow to have a more correct pager for multi monitor than EWMH: mainly on which monitor has the focus.
As the other issue, would you be interested in merging it in cnx-contrib ?

Sure, I see no issues.


Fixes DataTable fixed layout width prop issue

Fixes #1525
Additional description
Currently, when a simple DataTable with the fixedLayout prop won't correctly set the width's of the rendered <th/> html elements due to a bug in this code:
style={{ width: width ? { width } : null }}

Which is being addressed by replacing it with:
style={width ? { width } : null}

CONTRIBUTOR checklist (do not remove)
Please complete for every pull request

[x] First-time contributors should sign the Contributor License Agreement.  If you haven't before, wait a few minutes and a bot will comment on this pull request with instructions.
[x] npm run lint:fix has been run and linting passes.
[x] Mocha, Jest (Storyshots), and components/component-docs.json CI tests pass (npm test).
[x] Tests have been added for new props to prevent regressions in the future. See readme.
[x] Review the appropriate Storybook stories. Open http://localhost:9001/.
[x] The Accessibility panel of each Storybook story has 0 violations (aXe). Open http://localhost:9001/.
[x] Review tests are passing in the browser. Open http://localhost:8001/.
[x] Review markup conforms to SLDS by looking at DOM snapshot strings.

REVIEWER checklist (do not remove)

[ ] TravisCI tests pass. This includes linting, Mocha, Jest, Storyshots, and components/component-docs.json tests.
[ ] Tests have been added for new props to prevent regressions in the future. See readme.
[ ] Review the appropriate Storybook stories. Open http://localhost:9001/.
[ ] The Accessibility panel of each Storybook story has 0 violations (aXe). Open http://localhost:9001/.
[ ] Review tests are passing in the browser. Open http://localhost:8001/.
[ ] Review markup conforms to SLDS by looking at DOM snapshot strings.
[ ] Add year-first date and commit SHA to last-slds-markup-review in package.json and push.
[ ] Request a review of the deployed Heroku app by the Salesforce UX Accessibility Team.
[ ] Add year-first review date, and commit SHA, last-accessibility-review, to package.json and push.
[ ] While the contributor's branch is checked out, run npm run local-update within locally cloned site repo to confirm the site will function correctly at the next release.

😊


docs(falcosidekick): fix link to Falco in the README

Signed-off-by: Leonardo Di Donato<EMAIL_ADDRESS>What type of PR is this?
/kind cleanup
/kind documentation
Any specific area of the project related to this PR?
/area falcosidekick-chart
What this PR does / why we need it:
Fixes a wrong link in the README
Which issue(s) this PR fixes:
NONE
Special notes for your reviewer:
Checklist
NONE

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please ask for approval from leodido after the PR has been reviewed.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: 27e32603e89287dee2f75a0eb21935fb99affbf9

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Issif
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Issif]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@leodido I approved it, but even for that, you need to bump version and update changelog

New changes are detected. LGTM label has been removed.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please ask for approval from issif after the PR has been reviewed.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please ask for approval from issif after the PR has been reviewed.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: f1b14178a5d1dbcedb6abdc73bce652c080df549

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: leogr
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Issif, leogr
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Issif,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Auto-recommended extension cannot be found

Issue Type: Bug
A popup tells me

The 'Remote - WSL' extension is recommended as you have Windows Linux Subsystem (WSL) installed on your system.

I click Install but get

(x) Error while loading extension. Error

The search field says

@id:ms-vscode-remote.remote-wsl

Funny thing: I already have the Remote WSL extension installed.
VS Code version: Code 1.46.1 (cd9ea6488829f560dc949a8b2fb789f3cdc05f5d, 2020-06-17T21:13:20.174Z)
OS version: Windows_NT x64 10.0.18363
Fetching remote diagnostics for 'Dev Container: Existing Dockerfile' failed.

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-7Y75 CPU @ 1.30GHz (4 x 1608)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: disabled_offprotected_video_decode: enabledrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledviz_display_compositor: enabled_onviz_hit_test_surface_layer: disabled_off_okwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
15.92GB (8.49GB free)

Process Argv
--remote=wsl+Ubuntu

Screen Reader
no

VM
0%

Fetching remote diagnostics for 'Dev Container: Existing Dockerfile' failed.
Extensions: none

Can you please provide error logs when you install the extension?
Please follow these steps

please share the logs from the following locations

Help -> Toggle Developer Tools -> Console
View -> Command Pallette... -> Toggle Shared Process -> Console
View -> Open View… -> Log (Shared)
View -> Open View… -> Log (Window)


[DUOS-1519][risk=no] add parent reference id to dar

Link to Jira ticket
Summary of changes:

Add parent_id column (defaults to null) to the data_access_request table
Create a foreign key constraint on id so that a non-null parent_id must refer to an existing DAR id
Update queries from data_access_request table to include parent_id
Add parentId field to the DataAccessRequest model

Have you read CONTRIBUTING.md lately? If not, do that first.

Label PR with a Jira ticket number and include a link to the ticket
Label PR with a security risk modifier [no, low, medium, high]
PR describes scope of changes
Get a minimum of one thumbs worth of review, preferably two if enough team members are available
Get PO sign-off for all non-trivial UI or workflow changes
Verify all tests go green
Test this change deployed correctly and works on dev environment after deployment

I think there's a bit more to do here. Have a look at the following classes for where we would need to query for this value and map it to the object:

DarCollectionDAO
DataAccessRequestMapper

I don't think we need to modify any tests yet since we can't populate this value - TBD in future stories.


Alchemist Greevil doesn't follow you if sent toi target that died during it's flight to it.

Setting a new command to it makes it go where u want tho.

Fixed.


Ignore file fails with no debug output

I want to use gitsavvy to ignore a file, so trying with both the 'i' and 'I' command on the status screen, I attempted to ignore a main.pdf file. I get the following error:
`D:\Programs and Stuff\Git\cmd\git.EXE config --global core.autocrlf` failed with following output:
However, no error message is printed. The full call stack can be seen in the developer console:

Traceback (most recent call last):
File "core.commands.ignore in C:\Users\Raphael A. Meyer\AppData\Roaming\Sublime Text 3\Installed Packages\GitSavvy.sublime-package", line 41, in on_done
File "core.git_mixins.ignore in C:\Users\Raphael A. Meyer\AppData\Roaming\Sublime Text 3\Installed Packages\GitSavvy.sublime-package", line 19, in add_ignore
File "core.git_command in C:\Users\Raphael A. Meyer\AppData\Roaming\Sublime Text 3\Installed Packages\GitSavvy.sublime-package", line 162, in git
GitSavvy.core.exceptions.GitSavvyError: `D:\Programs and Stuff\Git\cmd\git.EXE config --global core.autocrlf` failed with following output:

Does it work to execute this command from the shell?
git config --global core.autocrlf

What git version are you at?
Windows version

I get an empty new line response by running the above in git bash.
I have git version 2.14.1.windows.1
My windows 10 build is 10.0.15063

git 2.15.0.windows.1
Windows 10 x64 build 16299.19
sublime 3154
git ignore pattern
Traceback (most recent call last):
  File "core.commands.ignore in C:\Users\User\AppData\Roaming\Sublime Text 3\Installed Packages\GitSavvy.sublime-package", line 41, in on_done
  File "core.git_mixins.ignore in C:\Users\User\AppData\Roaming\Sublime Text 3\Installed Packages\GitSavvy.sublime-package", line 19, in add_ignore
  File "core.git_command in C:\Users\User\AppData\Roaming\Sublime Text 3\Installed Packages\GitSavvy.sublime-package", line 166, in git
GitSavvy.core.exceptions.GitSavvyError: `C:\Program Files\Git\cmd\git.EXE config --global core.autocrlf` failed.

git ignore current file
Traceback (most recent call last):
  File "C:\Program Files\Sublime Text 3\sublime_plugin.py", line 918, in run_
    return self.run()
TypeError: run() missing 1 required positional argument: 'file_path_or_pattern'

It should be closed by 36c63c8.
Let's know if it doesn't.