javaagent explaination

Hi,
we are trying to make use of this library and have an issue with using the "-javaagent" parameter.
Our issue is, that we have to open up the jar, remove the aspectjweaver.jar from the resulting jar and than add it as a javaagent in our Dockerfile. I spare you the details. But we don't like what we did there.
Firstly we would like to understand, why we actually need it?
Secondly is there any way around using the -javaagent parameter?
Could you add those details to the readme?
Best Regards

No - this lib entirely relies on the aspectjweaver jar being loaded as javaagent.

If you are unfamiliar with Aspect Oriented Programming, maybe you can read https://www.baeldung.com/aspectj

An alternative that doesn't use AOP is https://github.com/erikvanoosten/metrics-scala - but with that lib, you will need to adjust your code to get the metrics to be recorded.


[WIP] Add GCS support for the image registry

https://jira.coreos.com/browse/DEVEXP-197

fyi @coreydaley I will be creating master-4.2 so our code can land there.


rdkit: Do we still need it in omnia?

Since our omnia version of rdkit is out of date (2015.09.01) compared to the official rdkit conda version, should we drop it? Or update our own version?

It looks like they eventually plan to make conda-forge their official conda package, so presumably it makes sense to deprecate ours.  See discussion https://github.com/rdkit/conda-rdkit/issues/13

FWIW, you should check out this blog post:
https://www.continuum.io/blog/developer-blog/anaconda-build-migration-conda-forge
I think that, between the lines, Continuum is semi-officially suggesting that conda-forge is very nearly a  "standard" secondary repository for reasonably stable conda packages.  For this reason, the Bioconda folks are making efforts to better integrate with conda-forge.

Sounds exciting! There is also an rdkit user group meeting next month we
will send some folks to.
Has anyone heard anything about support for projects that depends on CUDA
or OpenCL?
Alternatively, I imagine we could migrate a number of omnia projects to
conda forge if we had a way to pull in some openmm packages built with our
current build framework as a dependency.

I'm still wrapping my head around their CUDA support.

They build on an CENTOS6 image, which AFAIK may recent enough to get CUDA working
They do build theano, but it's not clear to me if the build has CUDA working: https://github.com/conda-forge/theano-feedstock
They may be waiting on some legal questions about CUDA re-distribution etc: https://github.com/conda-forge/docker-images/pull/21

Short answer: they are still working on it.

Thanks!
Given the momentum behind it, it's still worth looking at whether it makes
sense to migrate the non CUDA packages, or if that is even possible given
the dependency structure and lack of ability to specify multiple channels
for dependencies.
Someone noted that it is possible to declare pip dependencies in conda
recipes. If this were true, some pure python packages might be pip-able
instead.

Conda will definitely install pip dependencies for environments ( env.yaml) but I don't think it works for conda-build recipes.
See the example yaml at the bottom of this page:
https://github.com/conda/conda-env

I just submitted mdtraj to conda-forge at https://github.com/conda-forge/staged-recipes/pull/1477, which is my first experience so far. If things go smoothly, it might make sense for other people to slowly migrate over packages that don't depend on cuda/openmm.

SGTM, I just signed up to watch that thread.

Thanks, @rmcgibbo! Watching too. Please share your experiences.

FWIW, mdtraj packages seem OK: https://anaconda.org/conda-forge/mdtraj/files.  The feedstock repo has been created: https://github.com/conda-forge/mdtraj-feedstock

My impression so far is that the system for adding a new feedstock was very slick. The documentation was nice and clear, the example repo had very good defaults and instructions, and there was lots of cool cloud automation (like the linter automatically commenting on the Github PR, etc).
Sent from my iPhone

On Sep 4, 2016, at 7:04 PM, Kyle Beauchamp<EMAIL_ADDRESS>wrote:
FWIW, mdtraj packages seem OK: https://anaconda.org/conda-forge/mdtraj/files. The feedstock repo has been created: https://github.com/conda-forge/mdtraj-feedstock
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Awesome! Thanks for the report!
Any insight into how this might work for a package that depended on openmm? Is there some way to include the current omnia channel for pulling in dependencies? Would we just be migrating packages over to conda-forge instead of omnia if we started to move them there?
Looking forward to giving this a try...

I strongly doubt that depending on a package in the omnia channel is possible. I think moving openmm and any of its dependents to conda-forge will require figuring out cuda/opencl on their platform.
I'm not sure about this, but I suspect we may be among the people with the most experience packaging cuda stuff with conda using centos6/docker/travis-ci. So perhaps there's something we can contribute there.
Sent from my iPhone

On Sep 4, 2016, at 8:15 PM, John Chodera<EMAIL_ADDRESS>wrote:
Awesome! Thanks for the report!
Any insight into how this might work for a package that depended on openmm? Is there some way to include the current omnia channel for pulling in dependencies? Would we just be migrating packages over to conda-forge instead of omnia if we started to move them there?
Looking forward to giving this a try...
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@jchodera Could you hold off on removing the rdkit on Omnia for a bit? I want to see if I can upgrade deepchem to use the official conda rdkit version without bugs first. (I just posted PR #582 after verifying that the old keras and theano on Omnia could be safely removed).

Sure---let us know what you find!


Update TimeZone SDK member variable names

Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.

API change check
APIView has identified API level changes in this PR and created following API reviews.
Azure.Maps.TimeZones


remove webpack public path for index.html #79

thanks goldhand for the review, I realized that this PR not work.. but I've found other way to solve my case, I'll share on the issue page


Fix slug validation and generation for Attribute create

I want to merge this change because it fixes a problem where creating Attribute with two similar values returned ValidationError when it shouldn't.
Example valid input that was raising error:
  "input": {
    "availableInGrid": true,
    "entityType": null,
    "filterableInDashboard": true,
    "filterableInStorefront": true,
    "inputType": "DROPDOWN",
    "name": "test",
    "slug": "test",
    "storefrontSearchPosition": null,
    "type": "PRODUCT_TYPE",
    "valueRequired": true,
    "visibleInStorefront": true,
    "values": [
      {
        "name": "1.5"
      },
      {
        "name": "15"
      }
    ]
  }
}

Acceptance criteria:

Mutation with given input works properly and creates Attribute with given values.
Adding values with similar names (the ones that would have the same result when they are slugified) would result in generating a unique slug for all the values.
Names that are different only by upper/lower case or spaces are not allowed.

Impact

[ ] New migrations
[ ] New/Updated API fields or mutations
[ ] Deprecated API fields or mutations
[ ] Removed API types, fields, or mutations
[ ] Documentation needs to be updated

Pull Request Checklist

[ ] Privileged queries and mutations are guarded by proper permission checks
[ ] Database queries are optimized and the number of queries is constant
[ ] Database migration files are up to date
[ ] The changes are tested
[ ] GraphQL schema and type definitions are up to date
[ ] Changes are mentioned in the changelog

Reported in: https://saleorcommerce.slack.com/archives/C038XPD8HLK/p1678892312013259


Adds test case for JSON anomaly logging

This changeset adds tests for JSON anomaly logging (part of issue 2282

Continued in #45


Remove password from poller.config check

Required for https://github.com/RackHD/on-core/pull/127

👍

*** BUILD #455 ***
Test Name: create_pollers
Error Details: {'command': 'sdr', 'user': 'admin'} != {u'password': u'admin', u'command': u'sdr', u'user': u'admin'}
Stack Trace: Traceback (most recent call last):
  File "/usr/lib/python2.7/unittest/case.py", line 331, in run
    testMethod()
  File "/usr/lib/python2.7/unittest/case.py", line 1043, in runTest
    self._testFunc()
  File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/case.py", line 296, in testng_method_mistake_capture_func
    compatability.capture_type_error(s_func)
  File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/compatability/exceptions_2_6.py", line 27, in capture_type_error
    func()
  File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/case.py", line 350, in func
    func(test_case.state.get_state())
  File "/home/jenkins/workspace/RackHD/build/test/tests/api/v2_0/pollers_tests.py", line 120, in create_pollers
    assert_equal(poller[key], data[key])
  File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/asserts.py", line 55, in assert_equal
    raise ASSERTION_ERROR(message)
AssertionError: {'command': 'sdr', 'user': 'admin'} != {u'password': u'admin', u'command': u'sdr', u'user': u'admin'}

Needs to be merged with RackHD/on-core#127 to pass

+1


variable referenced but not created anywhere

Hello,
In the "Managing large numbers of users" section, there is the following line:
Invoke-Command -Session $s [...]
But the $s variable is not mentioned anywhere else on the page, so we don't know what is inside and how to create it.
I think you should add the following line at the top of the code block:
$s = Get-PSSession | Where-Object { ($.ComputerName -like '*.online.lync.com' -or $.Computername -eq 'api.interfaces.records.teams.microsoft.com') -and $.State -eq 'Opened' -and $.Availability -eq 'Available' }
$users = Get-CsOnlineUser -Filter { ClientPolicy -eq $null } -ResultSize 500

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b40e7e54-3354-4cb2-e5c0-7ba5411dbdf1
Version Independent ID: 572d0957-750d-6986-f62c-4167fdb8cb4a
Content: Assign per-user Skype for Business Online policies with PowerShell for Microsoft 365 - Microsoft 365 Enterprise
Content Source: microsoft-365/enterprise/assign-per-user-skype-for-business-online-policies-with-microsoft-365-powershell.md
Service: o365-administration
GitHub Login: @kelleyvice-msft
Microsoft Alias: kvice

@orandev Thank you for your feedback. We have made changes to the document via PR#https://github.com/MicrosoftDocs/microsoft-365-docs/pull/6109
Thanks
Sri

@msbemba Thank you very much for the contribution and updating the documentation with PR. @orandev Hope this update is helpful for you. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


The form attribute shouldn't be assigned to the input when its value is undefined

I'm closing #67 in favor of this more easily reproducible issue:
https://codesandbox.io/s/q360k5oj14
You can see that Dio.js behaves differently from React by toggling the imports.

I suspect React won't touch this attribute if its value is undefined and maybe Dio.js should do the same, what do you think?

Does this also apply to null?

Yes, I just replaced undefined with "null" and "false" in the link above and the result was the same. Actually even if I pass a number, true or a string it doesn't change the output. I'm not sure what React really does here.

It's more likely there's something deeply wrong with Dio.js here because it won't render anything, not just the radios, and it won't display any errors either, we just get a blank screen.

Based what i found out form looks like a readonly property that accepts string attributes set via setAttribute. DIO trying to set it as a property input.form = value would probably throw an error. It probably doesn't change the output for React because of how the form property works(if there are not forms that match the string id noop)

it won't display any errors either, we just get a blank screen.

Does this apply only to codesandbox? I get an error outside of codesandbox as well.

I didn't get any errors locally

Maybe you're trying against your recent changes to fix some errors when unmounting?

By the way, I tried to add that line locally and it didn't seem to fix the error handling here...

Yes, that must be it. I have a fix for this, just trying to find a reasonable test for it.

By the way, I tried to add that line locally and it didn't seem to fix the error handling here...

Do you manage to reach the same point that i mentioned? Are we still talking about this issue or #69 ?

TypeError: Cannot read property 'action' of undefined

Yes, I tried following this:
"For example https://github.com/thysultan/dio.js/blob/master/src/Core/Commit.js#L151 putting a if (!element.active) return fixes the issue. "

But I didn't try in that particular project but in my own.

Can you update that issue with the error you got, assuming it's not the same error?

Ok, let me try against the original project first and if it works there I'll try to change that project to reproduce the errors I'm getting in the other project.

Yes, I can confirm that change fixed for that particular project, I'll now try to replicate the other errors I'm getting in that project.

You can also try to point to the version in the repo it has the latest as far as the patch i worked on on.

Patched in 9.1.1


Binary releases and chromium 47

Does this support chromium 47? Also can you add .deb files and .rpm for other distros to your releases? Github allows you to create binary releases http://github.com/gcarq/inox-patchset/releases

Yes the latest tested version is chromium 47.0.2526.80, but I will update it to 47.0.2526.106 the coming days. The binary releases are currently hosted at bintray. I think for the next version I will switch over to Github releases.
I don't know if I'm going to release deb or rpm packages due to time limits, but until then check out ungoogled-chromium, he offers debian build-scripts and binaries for chromium with various patchsets.

No longer relevant since version 48 is out. I added a pre-built binary (pacman pkg)


Fname register signature fix

Why is this change needed?
There was a bug due to which fname registration was failing on example package hello-world. The PR fixes this.

PR-Codex overview
This PR introduces a new function for creating user name proof claims and updates the way user name proof signatures are generated and processed in the registerFname function. It also adds a utility function for converting bytes to hex.
Detailed summary

Added makeUserNameProofClaim function import.
Introduced bytesToHex function import.
Updated registerFname to use await signer.signUserNameProofClaim with makeUserNameProofClaim.
Changed signature processing to use bytesToHex for userNameProofSignature.value.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

How did you discover this error? Any chance you could provide the fid you were using for testing? We saw errors in our logs that seemingly line up with this issue you're reporting-- I want to further validate.

How did you discover this error? Any chance you could provide the fid you were using for testing? We saw errors in our logs that seemingly line up with this issue you're reporting-- I want to further validate.

I was registering a new fid using the same script along with fname - https://github.com/farcasterxyz/hub-monorepo/pull/2384/files#diff-718bf604324aedd7401075eee0a6e08762dc76bde40a11735b1fe0a1e4aebe9bR117

@aditiharini is there a python equivalent for these packages? I know this is unrelated. However couldn't find a better channel to ask this.

There are no Python packages that we maintain, and I'm not aware of any others at this time (but they might be out there!)


resolved the issue https://github.com/shamil-t/ehr-blockchain/issues/17

resoled the issue https://github.com/shamil-t/ehr-blockchain/issues/17


GitHub Actions not running properly on this repository

GitHub Actions not running properly on this repository. Disk running out of space.

Known issue with codeql, we are too big on disk when compiling.

Okay


Add some basic commands such as how are you

Add commands such as how are you, how you are doing, what's up, etc

i would love to be assigned this task

i would love to be assigned this task

@Niiola Assigned

Can I get more explanation of this  to be sure I understood the task

Ok I already did that and submitted
On Mon, Oct 17, 2022 at 12:42 PM Ujjawal Saini @.***>
wrote:

Can I get more explanation of this to be sure I understood the task
@Niiola https://github.com/Niiola simple greetings, text strings with
conditions.
For example:
https://github.com/spignelon/virtual-assistant/blob/main/main.py#L59
Like if how are you in data speak I'm good.
—
Reply to this email directly, view it on GitHub
https://github.com/spignelon/virtual-assistant/issues/14#issuecomment-1280726791,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AVQLHJJNN2IYIUYRX2IU63TWDU3SXANCNFSM6AAAAAARD4RMGY
.
You are receiving this because you were mentioned.Message ID:
@.***>


Transaction Error in Validator

Hello guys.
Having this UTxO error when running minting. It doesn't happen at first time but happens after.
Is this a know issue or as anyone encounter it?
Let me know what you guys think.
I'm running it in a NodeJS server and lucid-cardano version: 0.10.6
Error: "transaction submit error ShelleyTxValidationError ShelleyBasedEraBabbage (ApplyTxError [UtxowFailure (UtxoFailure (FromAlonzoUtxoFail (ValueNotConservedUTxO (Value 0 (fromList [])) (Value<PHONE_NUMBER>0 (fromList []))))),UtxowFailure (UtxoFailure (FromAlonzoUtxoFail (BadInputsUTxO (fromList [TxIn (TxId {_unTxId = SafeHash \"708cf8686b8f22f025cc09cb615869c8486539d8e9f42b200b8121a97f548017\"}) (TxIx 1)]))))])"

BadInputsUTxO means that the input it is trying to consume doesn't belong to current UTxO set, probably because another tx already consumed this input.

@TiagoX9 I am also facing the same error, did you fix that issue?

BadInputsUTxO means that the input it is trying to consume doesn't belong to current UTxO set, probably because another tx already consumed this input.

how can I solve this issue? please help me


#711 create repository service layer

Resolves #711

Added an abstraction over motor lib
Added CRUDRepository interface and impl
Added a model and service layers

@asynchroza @Isak-Bego I made a lot of changes, pls review them again. Also if everything is ok @Isak-Bego pls fix the tests :D

I will probably have some time to review it tomorrow but an ask for the future is to have your work broken down into smaller pieces as a PR with 54 files changed is a pretty substantial amount of changes to read through.

They are around 15 but I changed the name of the folder from py_api to py-api as you suggested, that's why it says 54.


Revert to Defaults menu item breaks shaders

The revert resets the name/type plugs which has breaks the shaders. In the past the looked functional until you actually render, but 964317a now makes the reload button make the problem more apparent. We should fix the menu item.

I'm in the process of adding a "readOnly" metadata entry for another purpose, but once that is done I think we can use it here. If we mark the name/type plugs as read only as far as the UI is concerned, then the "Revert to Defaults" thing will just skip over them.


Support index creation in all supported topologies and configurations.

Namely chef-backend, internal elasticsearch and external elasticsearch.
We also support version 2,5 6 for elasticsearch.
The indexes are being created at compile time (which might be another discussion). At this time none of the services are available. Trying to get the version of es from running elasticsearch will fail if this is not the fist_internal_install of elasticsearch.
To fix this, trying to get the version of es statically, or from the user.
Henceforth, in chef-server.rb the user can specify
elasticsearch['install_major_version'] = 6 #options are 2, 5, or 6

This also fixes the chef-backend scenario.
Adhoc build:
https://buildkite.com/chef/chef-chef-server-master-omnibus-adhoc/builds/1081
Integration test pipeline:
https://buildkite.com/chef/chef-chef-server-master-integration-test/builds/66
Signed-off-by: Prajakta Purohit<EMAIL_ADDRESS>
[ ] New functionality includes tests
[ ] All buildkite tests pass
[ ] Full omnibus build and tests in buildkite pass
[ ] All commits have been signed-off for the Developer Certificate of Origin. See https://github.com/chef/chef/blob/master/CONTRIBUTING.md#developer-certification-of-origin-dco
[ ] PR title is a worthy inclusion in the CHANGELOG

Closing this in favor of #1961


ci: Automate weekly release of bundle

Is this a new chart
What this PR does / why we need it:
Which issue this PR fixes
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

fixes #

Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[ ] Chart Version bumped
[ ] Variables are documented in the README.md
[ ] Title of the PR starts with chart name (e.g. [mychartname])

Looks good to me overall. Just one question:
Shouldn't we create a release workflow just for our k8s-agent team so it doesn't interfere with other teams' release process. And that way we only get release failures for our specific release failures?

Looks good to me overall. Just one question:
Shouldn't we create a release workflow just for our k8s-agent team so it doesn't interfere with other teams' release process. And that way we only get release failures for our specific release failures?

That is a very good point. I looked at creating a second file, but helm/chart-releaser-action does not have a clean way to specify that nri-bundle should be excluded. What is feasible to do is to run our steps only when we have the schedule event:
if: github.event_name == 'schedule'

To avoid affecting other teams I also restored the push event, so other teams can create a chart as soon as they merge changes to master.
These two changes accomplish the following:

Other teams keep releasing their charts on a push to master, so they do not get affected by our changes
The only chart that will be released on schedule will be nri-bundle since it is the only one on a schedule
We only get notified of nri-bundle failures


⚠ Bofrost.hr has degraded performance

In b866248, Bofrost.hr (https://www.bofrost.hr) experienced degraded performance:

HTTP code: 200
Response time: 1523 ms

Resolved: Bofrost.hr performance has improved in 32e0eab after 6 minutes.


Bug in smooth_quant.py

Hi, I think there's a bug affecting both get_module and set_module methods in neural_compressor/adaptor/torch_utils/smooth_quant.py.
The original methods are:
def get_module(model, key):
    """Get module from model by key name.

    Args:
        model (torch.nn.Module): original model
        key (str): module name to be replaced
    """
    attrs = key.split(".")
    module = model
    for attr in attrs:
        try:
            attr = int(attr)
            module = module[attr]
        except:
            module = getattr(module, attr)
    return module

def set_module(model, key, new_module):
    """Set new module into model by key name.

    Args:
        model (torch.nn.Module): original model
        key (str): module name to be replaced
        new_module (torch.nn.Module): new module to be inserted
    """
    attrs = key.split(".")
    module = model
    for attr in attrs[:-1]:
        try:
            attr = int(attr)
            module = module[attr]
        except:
            module = getattr(module, attr)
    setattr(module, attrs[-1], new_module)

When the execution goes into the except blocks, getattr() raises this error: "TypeError: getattr(): attribute name must be string". I think this is due to the fact that attr got cast to int in the try blocks. So, I propose the following modifications:
def get_module(model, key):
    """Get module from model by key name.

    Args:
        model (torch.nn.Module): original model
        key (str): module name to be replaced
    """
    attrs = key.split(".")
    module = model
    for attr in attrs:
        try:
            module = module[int(attr)]
        except:
            module = getattr(module, attr)
    return module

def set_module(model, key, new_module):
    """Set new module into model by key name.

    Args:
        model (torch.nn.Module): original model
        key (str): module name to be replaced
        new_module (torch.nn.Module): new module to be inserted
    """
    attrs = key.split(".")
    module = model
    for attr in attrs[:-1]:
        try:
            module = module[int(attr)]
        except:
            module = getattr(module, attr)
    setattr(module, attrs[-1], new_module)

In this way I'm able to run my code without errors. Let me know what you think. Thanks.

Hi @MatteoPagliani Thank you for raising it. Actually we don't need to use int. I will copy code from https://github.com/intel/neural-compressor/blob/059a7549aebb3318a19b398d006b59cffb465a83/neural_compressor/adaptor/torch_utils/util.py#L598 to replace it.


add code splitting support

It will add support for code splitting and will resolve #42 issue

Hey @fachrihawari
Thanks a lot for the pull request! :)
I did a nuxt build analyze test for nuxt-fire-demo and got the following results:

Bundle size stays almost the same:
295.44 KB (without PR)
299.67 KB (with PR)

However, Firebase modules get taken out of vendor.app.js and splitted into separate files:

Without PR:
![Uploading withoutPR.png…](Without PR)
With PR:
![Uploading withPR.png…](With PR)
So that seems to be a good thing, vendor.app.js get's much smaller.
I'm not a pro when it comes to optimizing js bundles however, so just 3 shy questions before we'll merge that :)

Do you know the reason behind why dynamic imports splits the modules into separate files, whereas the standard lodash conditional imports at the top don't?

Does the split in separate files greatly improve page load speeds with benefits for the end users?

Since we are currently NOT compiling the module and we are using dynamic imports here, which were introduced in ES6, is it guaranteed that this will work with all setups & older browsers?

Do you maybe have any (e.g. StackOverflow) links where this method is suggested to improve Firebase's performance (for regular, not nuxt-fire, setups)?
Looks really promising, would be great if that would improve the performance of nuxt-fire! :)
PS: Oh and line 59 needs fixing, just a small copy paste mistake I assume.

Hi @lupas
Happy to see your response. The reason why I made this PR is for make the service loaded dynamically not on the first time load.

dynamic import introduce for js module like in this link. Why the dynamic split our code to separated file because is handled by babel and web pack for splitting code which use dynamic import

Of course yes, because splitted file will not blocking the rendering of page. You can see this video from firebase summit 2019

From the video above, its can handle with polyfill but I'm not yet test.

@fachrihawari
Thank you for the detailed information! This is great!
Everything looks fine. If support for older browsers is needed and it would break because of this, there is always the option to add the import() polyfill.
Thank you for your input!

Implemented with v2.2.0.

@lupas waw, its great :hooray:


The "options.agent" property must be one of type Agent-like Object, undefined, or false.

When I try to install minecraft jar with @xmcl/installer, I get the following error but not all the times:
GotError: The "options.agent" property must be one of type Agent-like Object, undefined, or false. Received type object

I only get this error in a linux environment (which is sandboxed in a docker environment) or when I test my launcher with spectron which is also sandboxed.
My guess is that it has something to do with these lines:
https://github.com/Voxelum/minecraft-launcher-core-node/blob/a034fba5c1f6c04afe06f36f29f1dc132c1f5a95/packages/installer/util.ts#L92-L102
However, when I do the following, I don't get any error:
const got = require("got")
const HttpAgent = require("agentkeepalive")
const { HttpsAgent } = HttpAgent;

await got("https://www.google.com", {
    agent: {
        http: new HttpAgent(),
        https: new HttpsAgent()
    }
).text();

But if I replace https: new HttpsAgent() with https: new Object(), I get the same error. There must be some conditional agent in the code that I am not aware of that is causing this issue.

That must be a problem of compatibility of got with sandbox... I'll investigate more these day... (if I have time)

It's weird because there doesn't seem to be an issue while running your tests.

Aha! I might have found something useful. Sometimes when I try to install multiple instances simultaneously, I receive this error. On my computer, I need to have 3 parallel downloads. However, on the cloud IDE, I get the error with only 1 download. Maybe it has something to do with the number of sockets available because of agentkeepalive

I am trying to reimplement my install logic using @xmcl/task and it seems like it gets stuck at the install version json sub task.

I am trying to reimplement my install logic using @xmcl/task and it seems like it gets stuck at the install version json sub task.

So what's the current status? Which part are you trying to reimplement?

I am trying to reimplement my install logic using @xmcl/task and it seems like it gets stuck at the install version json sub task.

So what's the current status? Which part are you trying to reimplement?

I am the install task progress. I have a progress bar it stays at 0 percent. I added a console message for each update event and I only get the version json task.

This is my console output:
Install task started

TaskProgress.ts:36 Install task update (0/100). Message: undefined. State:
name: "install"
arguments: {version: "1.15.2"}
path: "install"
__proto__: Object

TaskProgress.ts:36 Install task update (0/100). Message: undefined. State:
name: "installVersion"
arguments: {version: "1.15.2"}
path: "install.installVersion
"__proto__: Object

TaskProgress.ts:36 Install task update (0/100). Message: undefined. State:
name: "install"
arguments: {version: "1.15.2"}
path: "install"__proto__: Object

The first line is outputted on execute event and the following are update events.

Wow, I just marked @xmcl/installer and got as external in my webpack config so that it wouldn't get bundled up and this solved the problem. Maybe this is a problem with bundling using webpack? I'll leave this issue open so I can conduct some further debugging.

Sorry for so many comments but in fact, it turns out that the task installVersion hangs if the version folder exists and the version json file exists but is empty.

Sorry for so many comments but in fact, it turns out that the task install.installVersion hangs if the version folder exists and the version json file exists but is empty.

In fact, this issue was caused by another one: https://github.com/electron/electron/issues/22119. I am still going to leave this issue open because they seem like two different problems.

This issue is really strange and I can't install any version because of it. Even though I set app.allowRendererProcessReuse to false and removed every version from .minecraft/versions/ folder - the issue is still present. What can I do?

This issue is really strange and I can't install any version because of it. Even though I set app.allowRendererProcessReuse to false and removed every version from .minecraft/versions/ folder - the issue is still present. What should I do?

If you are using webpack to bundle your files, this might be useful: I think I fixed the error temporarily by setting @xmcl/installer and got as externals in my webpack config. Of course, this is not optimal because I want to have tree shaking and minification.

Currently... maybe moving the usage of these functions to electron main is the most suitable solution

I am having this problem on electron despite moving got to my webpack externals :/.

I also moved @xmcl/installer to externals but I don't know if that fixes it.

Hmm, there seems to be a similar problem in another repo, https://github.com/axios/axios/issues/1627, even though it is completely unrelated.

I'll close this issue once #143 is closed because it removes got from@xmcl/installer.

I'll close this issue once #143 is closed because it removes got from@xmcl/installer.

You can try the new version and see if this issue happened again.

Fixed!


Improve the GAF file download situation

We have too many GAF files for download and the documentation doesn't cover them all:

https://www.pombase.org/data/annotations/Gene_ontology/gene_association.pombase.gz
https://www.pombase.org/data/annotations/Gene_ontology/gene_association_2-1.pombase.gz
https://www.pombase.org/data/annotations/Gene_ontology/gene_association_2-2.pombase.gz
https://curation.pombase.org/dumps/latest_build/pombase-latest.gaf.gz
https://curation.pombase.org/dumps/latest_build/misc/pombase_style_gaf.tsv
https://curation.pombase.org/dumps/latest_build/misc/go_style_gaf.tsv

Doc page: https://www.pombase.org/downloads/go-annotations
See also: https://github.com/pombase/curation/issues/3269

There isn't as much duplication as I thought and the documentation was correct.
The files in the dumps directory are straight out of the nightly load.  We don't mention them in the documentation.
The files on the main pombase.org site are copied from the dumps directory by the nightly load once everything finishes successfully.  These are the files linked to from the docs and these are the ones we should be telling users about (which I think we usually do).
gene_association.pombase.gz  and gene_association_2-1.pombase.gz are the only files mentioned in the documentation.
The documentation page (https://www.pombase.org/downloads/go-annotations) was correct but I've tweaked it a bit to make the links to the files stand out more.


Having many attachments downloaded in a chat causes crashes when opening the chat

When many attachments are sent in one chat, once the chat is opened the app slows down, then crashes

This is known, currently it's just an issue with flutter (which is the sdk the app is coded with).
Best solution would be to delete these from your Mac for the time being, and reset your Android app for the deleted messages to take effect

This is known, currently it's just an issue with flutter (which is the sdk the app is coded with). Best solution would be to delete these from your Mac for the time being, and reset your Android app for the deleted messages to take effect

Is it because of an unsupported image type? Or how we load them client side?

It's just when the app gets out of memory.

It's just when the app gets out of memory.

Wouldn't that take like 100 images to cause a crash? Is the issue that we load them all at the same time? Cuz I'm sure we can fix that by loading them in batches. Which we should do anyways to reduce lag as much as possible

So that's just flutter being flutter. iirc flutter has a quirk where it loads jpegs multiple times because it converts it into a different format before rendering it on screen. Plus we have our keepalives so even when images are off screen, they're still taking up memory being rendered. So loading in batches won't help if all of them will eventually be rendered in the background

So that's just flutter being flutter. iirc flutter has a quirk where it loads jpegs multiple times because it converts it into a different format before rendering it on screen. Plus we have our keepalives so even when images are off screen, they're still taking up memory being rendered. So loading in batches won't help if all of them will eventually be rendered in the background

Do you think we can remove the keepalives with flutter 3? Something we'd have to test. I assume not, but just a thought

Moving this to v1.10 so this can be investigated later. Right now we believe it's a flutter "bug", so we'll see if there is anything we can do to mitigate it

Best solution would be to delete these from your Mac for the time being

FWIW, I don't think this is a great solution. I don't want to delete messages from any of my chats.

FWIW, I don't think this is a great solution. I don't want to delete messages from any of my chats.

I understand that. I said for the time being :)
This is being actively worked on and hopefully we can come up with a proper solution, though we are limited in some ways by how performant the Flutter framework itself is.

Completed in full rewrite

When will the new, fully-rewritten version be released? I still see 1.10.1 on the Google Play Store


Handle missing verdicts in Faithfulness eval

Description:
The count_verified_statements method currently fails with an undefined method 'captures' for nil error when the expected string "Final verdict for each statement in order:" is absent from the LLMs response. This typically occurs if the provided context is either blank or not relevant to the question/answer.
Proposed Change:
This pull request introduces a guard clause in the count_verified_statements method to handle cases where the LLMs output does not contain the expected verdict format. I think returning a score of 0.0 makes sense given that this would be the correct score in most of these failure cases.
Code Changes:

A conditional check is added to return 0.0 immediately if no match is found in the verifications string.

@andreaslillebo Thank you for the PR!


Custom object types

IN DTAF (escapists map), close to the rocket zone, there are three signs that say ie. "NO USING FAKE FINGERPRINTS"
so my question is:
Is it possible to implement the signs like these to the runtime, and make them saying things you want in the map editor?
I want to add them to my custom prison, making them prompt the tips about eg. Where is the best place to start digging with.
In TE2, there are such.
Of course, if so, sow to do it? I don't mind Java and Kotlin.

Hello, how did you build the app? I just get an error, maybe I don't have gradle installed.


[EXPO SDK 50] [expo-head] Error: generic class 'Field' requires that 'Date' conform to 'AnyArgument'

Is there an existing issue for this?

[X] I have searched the existing issues

Do you want this issue prioritized?

[ ] Yes, I have sponsored
[X] Not urgent

Current Behavior
I'm using solito starter with tailwind. After upgrading to EXPO SDK 50.0.0-preview.4 and running 'yarn ios' I get an error:
❌  (../../node_modules/expo-head/ios/ExpoHeadModule.swift:28:6)

  26 |     @Field
  27 |     var keywords: [String]?
> 28 |     @Field
     |      ^ generic class 'Field' requires that 'Date' conform to 'AnyArgument'
  29 |     var dateModified: Date?
  30 |     @Field
  31 |     var userInfo: [String: AnyHashable]?

'yarn web' and 'yarn android' works fine, problem is only with ios in expo-head. Can you please help to fix it?
Expected Behavior
It should n't be an error.
Steps To Reproduce
Described at https://github.com/expo/expo/issues/25983
Versions
- Solito: 4.0.1
- Next.js: 13.4.19
- Expo: 50.0.0-preview.4
- React Native: 0.73.0

 expo-env-info 1.0.5 environment info:
    System:
      OS: macOS 14.2
      Shell: 5.9 - /bin/zsh
    Binaries:
      Node: 18.19.0 - /usr/local/opt/node@18/bin/node
      Yarn: 3.4.1 - /usr/local/bin/yarn
      npm: 10.2.3 - /usr/local/opt/node@18/bin/npm
      Watchman: 2<IP_ADDRESS> - /usr/local/bin/watchman
    Managers:
      CocoaPods: 1.12.1 - /Users/a123/.rbenv/shims/pod
    SDKs:
      iOS SDK:
        Platforms: DriverKit 23.2, iOS 17.2, macOS 14.2, tvOS 17.2, watchOS 10.2
    IDEs:
      Android Studio: 2021.3 AI-213.7172.25.2113.9123335
      Xcode: 15.1/15C65 - /usr/bin/xcodebuild
    npmGlobalPackages:
      eas-cli: 5.9.1
      expo-cli: 6.3.10
    Expo Workflow: managed

Screenshots
No response
Reproduction
https://github.com/SVronskiy/solito-expo-sdk50

Please open this issue with expo-router or expo-head

According to source code problem in expo-router 2, there is no expo-head in expo-router 3. But still not able to make it work. The reason why I have to upgrade to expo sdk 50 beta - different errors in reanimated.

It’s an expo issue, not a solution one


java: Create cheapest flights within K stops

File(s) Modified: [787-Cheapest-Flights-Within-K_Stops.java]
Language(s) Used: [java]
Submission URL: [https://leetcode.com/submissions/detail/755914004/]

Thanks, @Rixant!


chore: cache templates on project loading/validation

What this PR does / Why we need it:
During project loading, we verify the presence of template files before loading them from disk. Many projects reuse parameterized templates a lot, leading to repeated creation of the same template again and again, including validation to ensure that the file exists on disk which results in a massive amount of unnecessary syscalls for no reason. This PR introduces a cache to store already verified templates.
Special notes for your reviewer:
A next step would be to actually only load the template's content once when template::Content() is invoked. However, this is happening later and would probably change memory consumption significantly. This needs to be investeigated further.
Does this PR introduce a user-facing change?

Afaik, we introduced reading templates when needed to reduce the memory footprint. We used to store the content of the JSON file directly in the config, and this had a huge memory impact.
How would this PR change the memory usage when downloading and deploying an environment with tens of thousands of configurations? Bc even when we use a cache, when downloading and reuploading an environment, there won't be any duplicates of the JSON-files.

Realised that the changes in the PR raises unnecessary questions, given that it gives just a little performance gains in some situtations. So we've decided to close this.


Fix VirtualizedLists nesting issue

Summary of Changes
The VirtualizedLists does not like being nested in a SafeAreaScrollView. When done RN throws an error that is visually jarring. I fixed it by removing the SafeAreaScrollView and just using a plane old View because the two views this issue appears on don't need to scroll (AFAIK). On iOS usrs may be inclided to pull-to-refresh in this situation even though it has no effect.
Related Issues
Fixes #98
Pull Request Checklist
This is just a reminder about the most common mistakes. Please make sure that you tick all appropriate boxes. But please read our contribution guide at least once; it will save you a few review cycles!
If an item doesn't apply to your pull request, check it anyway to make it apparent that there's nothing to do.

[x] All commits contain a DCO Signed-off-by line (we use the DCO GitHub app to enforce this).
[ ] Updated LICENSE-3RD-PARTY.md for any added dependencies or vendored components.
[x] Run prettier: npm run style-format
[ ] Updated documentation for changed code and new or modified features.

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!
PR template adapted from the Python attrs project.

Thanks for fixing this--I hadn't had time to hunt down this issue. Thanks!


Round instructor rating to 2 decimal points in course popup

The instructor rating on the course popup on the search page can get really long. ICS 46 for example:

I can pick this one up!

Could I take this problem?

Could I take this problem?

Yes, go ahead!

Yes, go ahead!
Thank you. I tested this on my local setup and noticed that "Current Instructors" didn't appear in the course popup, so I'm not entirely sure if this solution is 100% effective. However, based on the rest of the code, I believe this should resolve the issue.
{score.score == -1 ? '?' : score.score.toFixed(2)}

What are your thoughts on this? Any additional insights would be appreciated.

Yes, that seems right. You can go ahead and put up a pull request.

Closed via #485


update to go1.21

Update to Go 1.21 and replace existing slices from exp with standard library versions

merged #40


Add set_index test

Simplified version of https://github.com/coiled/coiled-runtime/pull/694 that only adds a set_index

Actually, one question: set_index is a shuffling operation, not a join, isn't it? I'd move it to test_dataframe.py.

Actually, one question: set_index is a shuffling operation, not a join, isn't it? I'd move it to test_dataframe.py.

Yes, it's a shuffle. Just added it to this file since there is the memory multiplier. In the original attempt adding this I was also paramterizing over the dtypes together with the other tests.
FWIW I think we should rather put all shuffle tests in one test_shuffle instead of having join and dataframe.


Replace cargo check --all in docs

There are some lingering instances of cargo check --all, even after the closure of #384. This replaces those occurrences with the correct cargo check. (Fixes #384.)

Thanks!


Eclipse SDK doesn't contain JUnit anymore

This is how I install Eclipse on my system:
eclipse =
  let plugins =
    callPackage <nixpkgs/pkgs/applications/editors/eclipse/plugins.nix> {};
  in
    (eclipses.eclipseWithPlugins {
             eclipse = eclipses.eclipse_sdk_45;
             plugins = [plugins.eclemma];
     });

Everything was fine until Eclipse started to not have JUnit anymore embedded:

when adding a library to a project, JUnit does not appear anymore
the JUnit view does not exist anymore

/cc @rycee @bjornfor any idea?

I tried adding jdt but without success:
eclipse =
  let plugins =
    callPackage <nixpkgs/pkgs/applications/editors/eclipse/plugins.nix> {};
  in
    (eclipses.eclipseWithPlugins {
             eclipse = eclipses.eclipse_sdk_45;
             plugins = [plugins.eclemma plugins.jdt];
     });

No ideas here, sorry. (I don't use eclipse that often, and when I do it's for C and/or embedded programming.)

When I go to Help, About, Installation Details, Plugins, I see 4 lines related to Junit:

JDT JUnit Runtime Support
JDT Junit 4 Runtime Support
JUnit Testing Framework
PDE JUnit Runtime Support

No error in Eclipse log (Help, About, Installation Details, Configuration)

@rycee recommended to remove ~/.eclipse and it worked. Thank you


Added Standardized Abbreviations for Colleges, Majors, and Minors

Summary

Added abbreviations for all colleges, majors, minors, and grad requirements
added said abbreviations into the progress tracker toolcard

Remaining TODOs:
None
Test Plan
Test that the abbreviations are working correctly for both the export toolcard and the progress tracker toolcard.
Notes
There's a bug with the Applied Econ Minor because it's not in index.ts yet, we should add that soon.

The only diff right now is moving the applied econ minor after the aerospace engineering minor instead of before, which might be because i switched the order in another file. should i move it back or leave it as is?

The only diff right now is moving the applied econ minor after the aerospace engineering minor instead of before, which might be because i switched the order in another file. should i move it back or leave it as is?

Oh I see, nevermind. It's alphabetized now which is better.

Just added the codes to the export PDF! @zachary0kent


Python script to generate docs for program options (WIP)

@dothebart I committed a change to the .sh and the .js scripts to make it work in Cygwin.
Furthermore enabled pretty printing for --dump-options, to play nice together with version control.
Integration of the processing script is pending, but it is already capable of printing an HTML table for arangobench to stdout. Need to discuss the format with Santo.

in general I would prefer to print markdown, since thats then better debuggeable.
I also would prefer a bullet point list over a table - you also need to test how this renders to epub & pdf

This is impossible to render to Markdown because of its limitations in regards to tables. HTML is valid Markdown however. Need to check if we need some CSS classes in addition to use the Gitbook theme.
It looks cleaner as a table IMO and follows the example of MySQL and Neo4j. If you want a list instead, please convince Santo first.

generateMdFiles.py can now generate the docublocks in-memory. The checks for a full build fail however, because it tries to find the files for the program options blocks, which do not exist.
@dothebart Can you adjust the build script to ignore them? (not the whole Markdown file the docublocks are used in however)
Not all blocks were found on both sides:
Documentation      |     Programcode:
program_options_arangosh
Documentation:
./Manual/Administration/Arangosh/Configuration.md:@startDocuBlock program_options_arangosh

Usage of docublock for testing:
diff --git a/Documentation/Books/Manual/Administration/Arangosh/Configuration.md b/Documentation/Books/Manual/Administration/Arangosh/Configuration.md
index b2acb47..0fd6392 100644
--- a/Documentation/Books/Manual/Administration/Arangosh/Configuration.md
+++ b/Documentation/Books/Manual/Administration/Arangosh/Configuration.md
@@ -1,6 +1,8 @@
 ArangoDB Shell Configuration
 ============================

+@startDocuBlock program_options_arangosh
+
 _arangosh_ will look for a user-defined startup script named *.arangosh.rc* in the
 user's home directory on startup. The home directory will likely be `/home/<username>/`
 on Unix/Linux, and is determined on Windows by peeking into the environment variables

The actual integration of @startDocuBlock for the program options should happen in the administration refactor PR, not here.
Rendered result with some tweaks to the CSS:

Merged into https://github.com/arangodb/arangodb/pull/4907


Add support for rolling updates

As discussed in https://bit.ly/k8s-LWS

/assign

About maxSurge, we know that deployment is stateless, so we can burst out extra replicas for service availability, and no need to delete them in the final as long as meet the replicas. But for statefulset, it doesn't has this capability because the replicas of statefulsets is indexed, then maxSurge seems not fit for lws as well. e.g. we have a lws with 3 replicas, and the maxSurge is 2, rolling update looks like:

replica-0 (old)
replica-1 (old)
replica-2 (rolling update)
replica-3 (new)
replica-4 (new)

Then when rolling update finished, we'll remove the replica-3 and replica-4? This seems like a waste especially for LLM. @ahg-g @liurupeng any other opinions?

@kerthcet we could add maxSurge support later.  But we may need the maxSurge feature. Right now for GPU/TPU customers, one of most critical issues is hardware stockout which means the accelerators in the zone has all been used up. If the customer use maxUnavailable, with cluster-autoscaler/nodepool-auto-provisioning enabled. It's often during the rollingUpdate the hardware of the updating podgroup will be released. But to provision a new accelerator node, it will be pretty hard(due to stockout), and this may cause issues if the total number of nodes is not large. With maxSurge, this could be mitigated since we always ensure there is at least lws.spec.replicas number of pod groups.

Thanks for the explanation, got the idea about Reserve. Several concerns come into my mind:

This would require additional costs for rolling update, like we have to cleanup the extra replicas, or even trigger the unnecessary autoscaling
From a system/cluster level, will this intensify the resource competition because hardware is scarce and we required extra resources
If maxSurge is set and resource only fit for spec.Replicas, will this block the rolling update. But we can scale down the maxSurge to 0  to solve this.
Maybe we should support reserve pod in kubernetes or at least at kube-scheduler.
Would this fit the Stetefulset? Do we have similar scenarios?

Sorry, I need to think more deep about this feature before I start the work.

I'm inclined to rename rolloutStrategy to updateStrategy to align with Statefulset and rollout may confused with https://github.com/kubernetes-sigs/lws/issues/89 in the future.

@kerthcet , I think these are all valid points. The major reason we want to support it is because of some asks for the feature. Although it seems to be an anti-pattern for StatefulSet. But running AI/ML workload makes the MaxSurge more important, like customers without reservation which improves the hardware obtainability etc.

I could pick up this item if that's ok

Thanks @liurupeng for the feedback and kindness, I'm already working on this this afternoon, I'm free until this weekend so I think I can finish this on time.

sounds good @kerthcet

I suggest that we release 0.2.0 with what we have and leave MaxSerge to the next release. I feel we have enough for a release, and that will help us de-risk 0.2.0 a little

Would we actually be able to support maxSurge given that replicas have stable identities that are baked into the pod names?
btw, we should remove maxSurge parameter before releasing.

Would we actually be able to support maxSurge given that replicas have stable identities that are baked into the pod names?

Comparing to deployment's maxSurge, no ...

btw, we should remove maxSurge

Make sense.

See https://github.com/kubernetes-sigs/lws/pull/107


checkErrors is preventing dep ensure from working within dep

What dep command did you run?
I tried to dep ensure -v in github.com/golang/dep and got the following output:
$ dep ensure -v
Found 5 errors:

/Users/ibrahim/Code/go/src/github.com/golang/dep/cmd/dep/testdata/harness_tests/ensure/pkg-errors/case2/initial/bar/bar.go:3:51: expected 'package', found 'EOF'
/Users/ibrahim/Code/go/src/github.com/golang/dep/internal/gps/_testdata/src/bad/bad.go:6:43: expected 'package', found 'EOF'
import path github.com/golang/dep/internal/gps/_testdata/src/relimport/dotslash had a local import: "./simple"
import path github.com/golang/dep/internal/gps/_testdata/src/relimport/dotdotslash had a local import: "../github.com/golang/dep/internal/gps"
import path github.com/golang/dep/internal/gps/_testdata/src/relimport/dotdot had a local import: ".."

What did you expect to see?
A normal ensure output.
What did you see instead?
#844 introduced some additional rules to check when projects contain Go files with errors. Applying these rules on dep resulted in this case. :grin:
Since dep has some test cases (and test data) with invalid Go files, dep ensure cannot be used in github.com/golang/dep.
cc: @grepory

I think it would be great if we add more output before printing Found # errors:. Since it's not really clear what went wrong.
Something like Calculating imported package tree... and Finished calculating imported package tree. if no error occurred?

baaaaaarrrgghhhh lol

i thought i pieced through those cases, but evidently not. let's get a fast fix in on this one, if we can?

I created a PR. That function does the following now:

If all directories lack Go files, return an error.
If all directories have build errors, return an error.
If all directories either lack Go files or has a build error, return an error.
If some directories are compilable but the tree contains build errors, return a warning with the errors.


950 Initialize callbacks using params emitted in Bluesky documents

Fixes #950
Fixes #372
Callback classes now all get their params from the "hyperion_internal_params" emitted in the outer start document of each plan.
Adds an IspybIds to clean up some type checking issues
80% of line count is just tests being put into classes so I could mock stuff better
To test:

Run tests

why can't we use a normal constructor instead of the setup method?

The constructor of a dataclass requires values for the fields as arguments, but the zocalo callback needs to be instantiated with the ispyb handler as an argument; you can't set the fields of self anywhere (even in init) for a frozen dataclass; we need frozen=True, order=True to guarantee that casting it to a list gives the list in the right order
We will also shortly remove these callback collections completely


clusterInfo: calculate leaderCount/regionCount from cache.

cc @nolouch
This PR aims to optimize balance speed by always using region cache to calculate a store's leaderCount and regionCount, which will be more up to date compared to reading it from StoreHeartbeat.
The main modify is whenever we get a storeInfo from clusterInfo, we setup its leaderCount and regionCount by calculating them from region cache.
However, some tests rely on manually setting leaderCount/regionCount, so setFakeLeaderCount and setFakeRegionCont are introduced to keep them working properly.

LGTM
PTAL @siddontang

@disksing
How about update store info when add region?
For balance speed test, we don't need to get store info from clusterInfo, we can just create a store info we need.

Now store status are updated after handling region heartbeat, thanks for advice from @coocood .
Also I've reorganized handleRegionHeartbeat to avoid redundant updates (skip when nothing is changed).
PTAL @nolouch @siddontang @coocood

LGTM

PTAL @siddontang @nolouch


Teams theme: Popup pointing styles still broken with focus trap

Bug Report
After fix in #1433 Popup pointing with focus trap is still broken:

Version
0.34.1
Testcase
https://codesandbox.io/s/popup-pointing-with-focustrap-broken-styles-8kenr

It seems that is was fixed by #1565:

Fixed in 0.35.0.


[HOLD for payment 2022-12-08] Profile - If user uses saved information, background turns white & is very hard to read

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:
Pre-Condition: User has saved information on their device

Access staging.new.expensify.com
Enter a valid account
Tap on Profile icon > Profile > Add phone number
Selected the saved information option

Expected Result:
User expects the background to match the dark theme
Actual Result:
The background turns to a bright white and afterwards makes it very hard to read the text in the field
Workaround:
unknown
Platform:

Where is this issue occurring?

Web

Version Number: 1.2.33-1
Reproducible in staging?: Y
Reproducible in production?: New UI
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
EXTRA: This seems to happen with any input field as long as you have saves information
https://user-images.githubusercontent.com/43996225/204415527-9c4f235c-788c-413f-b1e8-e74f78a818f7.mp4

Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:
View all open jobs on GitHub

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

Not able to reproduce given these test steps. The input looks fine on my end:

What does "if the user users saved information" mean exactly? Are there missing test steps?

Oh, I think you mean "auto complete"... lemme try that.

Ok, so the user agent stylesheet will need to be overwritten in our app.
Guessing we did not notice this before because our theme was similar to the defaults that Chrome (and others) add in. I also came across this -> https://developer.mozilla.org/en-US/docs/Web/CSS/:autofill which seems to suggest that the autocomplete UA styles can't be easily overwritten in CSS and require some hacks.
Will look around for some solution... but in the meantime... cc @shawnborton @grgia to see if you all know any workarounds.

I had reported this bug earlier here in slack. Raising here for compensation request as a bug reporter.

Found a kind of ridiculous hack to fix this here that does work kind of perfectly.
Honestly, it's not looking good for going through the proper channels:

🥲

I am not really sure how the staging regression could have been avoided in this case. The fix worked in one place but not for all cases. Staging did what it was supposed to in this case and the issue was caught at the right layer.

This was fixed by https://github.com/Expensify/App/pull/13164. Closing!

@luacmartins, c+ review compensation is pending as well.

@luacmartins, c+ review compensation is pending as well.

bump @luacmartins

@sobitneupane @thesahindia sorry we missed those. I'll reopen this issue for compensation.

@sophiepintoraetz can you help with the reporting bonus to @sobitneupane and @thesahindia for C+ PR review?

Thanks @luacmartins

To clarify, @thesahindia you're owed $250 C+ plus the bonus of $125, making it a total of $375 owed, correct?
(@sobitneupane - you're $250)

@sobitneupane, the bonus only applies to external PRs and for internal PRs the compensation is $1000 (slack post here)

Got it - thanks for confirming, @thesahindia! Hired you both for theProfile - If user uses saved information, background turns white & is very hard to read - #13116

paid!


Yarn support

The oc client can currently be installed using yarn, as any other npm package. The problem comes when we try to publish a package to a registry; for some reason it complains about dependency issues:
$ yarn global add oc
$ oc add registry https://your.registry.com
$ NODE_ENV=production oc publish my-widgets
Packaging -> ~/src/my-widgets/_package
An error happened when creating the package: oc/template.html compilation failed - Error requiring oc-template: "oc-template-handlebars" not found

I never had an issue before installing a package with yarn, so I'm not really sure why is this happening. For that same reason, I'm not really sure if I should mark this as a bug or as an enhancement.
Anyone has an idea why this is different using yarn?

@elboletaire thanks for pointing that out. I'll have a look at it and let you know.

@elboletaire I've been able to yarn globally install oc and publish a couple of my packages; one that uses handlebars and another one that uses jade. Some more info:
node: v6.10.2
oc: v0.37.4
// cc @nickbalestra @matteofigus

I can see a difference. In one case you publish one level down your component, in the other it's  /src/component.
This could be a bug for the require wrapper in the cli looking to require the peer template module relative to the component instead of the position of where the command is ran.

Interesting, have you been able to publish if you do what I do? Later I
will try what you are suggesting and see what happens. Thanks.
On Tue, May 23, 2017 at 14:55 Matteo Figus<EMAIL_ADDRESS>wrote:

I can see a difference. In one case you publish one level down your
component, in the other it's /src/component.
This could be a bug for the require wrapper in the cli looking to require
the peer template module relative to the component instead of the position
of where the command is ran.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/opentable/oc/issues/487#issuecomment-303543940, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AGIC3bdsJFVtpbMf4vl093c4fTIJRBGiks5r81XkgaJpZM4NkGYE
.

--
In theory there is no difference between theory and practice. In practice
there is.
Jan L. A. van de Snepscheut

Let me catchup with @nickbalestra about this. I think we established a couple of days ago that there was a bug relative to the cli looking for the template in the wrong path, so it could be related.

@elboletaire can you try yarn global remove oc and then a yarn global add oc and retry to run the publish command? I think there is something wrong with your install and perhaps a remove+add can fix.  Perhaps, it would be useful to ensure yarn is installed with the latest version as well.

@matteofigus if you want I try it, but I guess it's gonna fail, because everywhere where I installed oc client (latest friday was the last time I tried) with yarn failed with the same issue (and that includes docker images from latest node version).
BTW, I'll try it when I arrive at the office

Ok... I managed to reproduce. I think #488 is actually a good way to solve it. I'll add my findings there

Nice, I was coming here to confirm the issue's still there; glad to see you were able to reproduce it 😃


Is it possible to group column with AngularFirestoreCollection?

I am new to Angularfire5, Is it possible to group by column with   AngularFirestoreCollection?
I get data :  this.afs.collection('moneyCost', ref => ref.orderBy('costDate'));
---data example----------------------------
costDate         product          money
2017-11-01     item1             100
2017-11-01     item2              30
2017-11-01     item3              60
2017-11-02     item2              40
2017-11-02     item3              50
I don't know how to group by column and summary column in AngularFirestoreCollection.group data
costDate        money
2017-11-01       190
2017-11-02        90
Is it possible ?

This is a SQL function. Please read this question firebase-count-group-by. IMHO, you have 2 ways:

Create a field (an array) in the parent document called Sum, for example, and every time you add, update or remove an item in moneyCost collection, you update this field accordingly, e.g.: [ { "date" : "2017-11-01",  "amount": 190}, ...]. And you should use a firestore transaction. Also, you can rely on Cloud Functions to do this job.

Another option is to get all items in memory and group the items in JS:

this.itemsCollection = afs.collection<Item>('items');
this.items = this.itemsCollection.valueChanges();

(Group by in JS).

thank you


Calling Auth.SignInWithWebUI results in nothing happening

Describe the bug
I have created a minimal swift app to test federated log in with Amplify. I have created a button that calls the Amplify.Auth.signInWithWebUI method. When I click the button, the method is successfully called, but no Web UI appears on the screen and no error is thrown - there appears to be no side affect to calling the method at all
Steps To Reproduce
Steps to reproduce the behavior:
1. Configure Amplify
2. Click login button
3. Observe... nothing

Minimal example:
Main app:
import Amplify
import SwiftUI
import AWSCognitoAuthPlugin

@main
struct SwiftOauthMinimalApp: App {
    init() {
        do {
            try Amplify.add(plugin: AWSCognitoAuthPlugin())
            try Amplify.configure()
            print("Successfully configured Amplify")
        } catch {
            print("Unable to configure Amplify")
            print("Error: \(error)")
        }
    }

    var body: some Scene {
        WindowGroup {
            ContentView()

        }
    }
}

ContentView:
import Amplify
import Combine
import SwiftUI

struct ContentView: View {

    var body: some View {
        Button("Log in") {
            if let windowScene = UIApplication.shared.connectedScenes.first
                as? UIWindowScene,
                let window = windowScene.windows.first
            {
                print("\(window)")
                Task { await signInWithWebUI(window: window) }
            } else {
                print("Failed to access main window.")
            }
        }
    }

}

func signInWithWebUI(window: UIWindow) async {
    do {
        let signInResult = try await Amplify.Auth.signInWithWebUI(for: .custom("Auth0"),
            presentationAnchor: window)
        if signInResult.isSignedIn {
            print("Sign in succeeded")
        }
    } catch let error as AuthError {
        print("Sign in failed \(error)")
    } catch {
        print("Unexpected error: \(error)")
    }
}

amplifyconfiguration.json:
{
    "auth": {
        "plugins": {
            "awsCognitoAuthPlugin": {
                "IdentityManager": {
                    "Default": {}
                },
                "CognitoUserPool": {
                    "Default": {
                        "PoolId": "XXXX",
                        "AppClientId": "XXXX",
                        "Region": "eu-west-2"
                    }
                },
                "Auth": {
                    "Default": {
                        "authenticationFlowType": "USER_SRP_AUTH",
                        "OAuth": {
                            "WebDomain": "XXXX",
                            "AppClientId": "XXXX",
                            "SignInRedirectURI": "XXXX://",
                            "SignOutRedirectURI": "XXXX://",
                            "Scopes": [
                                "email",
                                "openid",
                                "profile",
                            ],
                            "responseType": "code",
                        }
                    }
                }
            }
        }
    }
}

Expected behavior
WebUI to appear on screen
Amplify Framework Version
2.42.1
Amplify Categories
Auth
Dependency manager
Swift PM
Swift version
6.0
CLI version
None
Xcode version
16.0
Relevant log output
<details>
<summary>Log Messages</summary>

Successfully configured Amplify
<UIWindow: 0x103508220; frame = (0 0; 393 852); gestureRecognizers = <NSArray: 0x600000c7cc90>; layer = <UIWindowLayer: 0x600000c7c060>>

```
Is this a regression?
No
Regression additional context
No response
Platforms
iOS
OS Version
iOS 18.0
Device
iPhone 14 Pro Max
Specific to simulators
No response
Additional context
No response

Hi @januaryblues, thanks for opening this issue. We will attempt to reproduce it and post any updates in here.
In the meantime, could you please share the verbose logs when you call signInWithWebUI? They might help us diagnose your issue.
You can enable verbose logging by doing this before Amplify.configure():
Amplify.Logging.logLevel = .verbose

Thanks @ruisebas for the speedy response. Here is the verbose logs:
Configuring
Configuration: nil
Could not find Cognito Identity Pool configuration
Credential Store state change:

{
    "CredentialStoreState.notConfigured" =     {
    };
}
Auth state change:

{
    "AuthState.notConfigured" =     {
    };
}
Successfully configured Amplify
Auth state change:

{
    "AuthState.configuringAuth" =     {
    };
}
AWSCognitoAuthPlugin/InitializeAuthConfiguration.swift Starting execution
Credential Store state change:

{
    "CredentialStoreState.migratingLegacyStore" =     {
    };
}
AWSCognitoAuthPlugin/MigrateLegacyCredentialStore.swift Starting execution
[KeychainStore] Initialized keychain with service=com.amplify.awsCognitoAuthPlugin, attributes=KeychainStoreAttributes(itemClass: "genp", service: "com.amplify.awsCognitoAuthPlugin", accessGroup: nil), accessGroup=
[KeychainStore] Started retrieving `Data` from the store with key=authConfiguration
[KeychainStore] Successfully retrieved `Data` from the store with key=authConfiguration
[KeychainStore] Started setting `Data` for key=authConfiguration
[KeychainStore] Initialized fetching to decide whether update or add
[KeychainStore] Found existing item, updating
[KeychainStore] Successfully updated `Data` in keychain for key=authConfiguration
[KeychainStore] Initialized keychain with service=com.example.SwiftOauthMinimal.AWSCognitoIdentityUserPool, attributes=KeychainStoreAttributes(itemClass: "genp", service: "com.example.SwiftOauthMinimal.AWSCognitoIdentityUserPool", accessGroup: nil), accessGroup=
[KeychainStore] Started retrieving `String` from the store with key=2hq63pmn2836qoas360c21cid6.currentUser
[KeychainStore] Started retrieving `Data` from the store with key=2hq63pmn2836qoas360c21cid6.currentUser
[KeychainStore] No Keychain item found for key=2hq63pmn2836qoas360c21cid6.currentUser
[KeychainStore] Initialized keychain with service=com.example.SwiftOauthMinimal.AWSCognitoIdentityUserPool, attributes=KeychainStoreAttributes(itemClass: "genp", service: "com.example.SwiftOauthMinimal.AWSCognitoIdentityUserPool", accessGroup: nil), accessGroup=
[KeychainStore] Started retrieving `String` from the store with key=2hq63pmn2836qoas360c21cid6.currentUser
[KeychainStore] Started retrieving `Data` from the store with key=2hq63pmn2836qoas360c21cid6.currentUser
[KeychainStore] No Keychain item found for key=2hq63pmn2836qoas360c21cid6.currentUser
[KeychainStore] Starting to remove all items from keychain
[KeychainStore] Successfully removed all items from keychain
[KeychainStore] Initialized keychain with service=Optional("com.example.SwiftOauthMinimal").AWSMobileClient, attributes=KeychainStoreAttributes(itemClass: "genp", service: "Optional(\"com.example.SwiftOauthMinimal\").AWSMobileClient", accessGroup: nil), accessGroup=
[KeychainStore] Started retrieving `Data` from the store with key=loginsMap
[KeychainStore] No Keychain item found for key=loginsMap
[KeychainStore] Initialized keychain with service=Optional("com.example.SwiftOauthMinimal").AWSMobileClient, attributes=KeychainStoreAttributes(itemClass: "genp", service: "Optional(\"com.example.SwiftOauthMinimal\").AWSMobileClient", accessGroup: nil), accessGroup=
[KeychainStore] Started retrieving `String` from the store with key=federationProvider
[KeychainStore] Started retrieving `Data` from the store with key=federationProvider
[KeychainStore] No Keychain item found for key=federationProvider
[KeychainStore] Starting to remove all items from keychain
[KeychainStore] Successfully removed all items from keychain
AWSCognitoAuthPlugin/MigrateLegacyCredentialStore.swift Sending event CredentialStoreEvent.loadCredentialStore
AWSCognitoAuthPlugin/LoadCredentialStore.swift Starting execution
Credential Store state change:

{
    "CredentialStoreState.loadingStoredCredentials" =     {
    };
}
AWSCognitoAuthPlugin/LoadCredentialStore.swift Retreiving credential amplifyCredentials
[KeychainStore] Initialized keychain with service=com.amplify.awsCognitoAuthPlugin, attributes=KeychainStoreAttributes(itemClass: "genp", service: "com.amplify.awsCognitoAuthPlugin", accessGroup: nil), accessGroup=
[KeychainStore] Started retrieving `Data` from the store with key=authConfiguration
[KeychainStore] Successfully retrieved `Data` from the store with key=authConfiguration
[KeychainStore] Started setting `Data` for key=authConfiguration
[KeychainStore] Initialized fetching to decide whether update or add
[KeychainStore] Found existing item, updating
[KeychainStore] Successfully updated `Data` in keychain for key=authConfiguration
[KeychainStore] Started retrieving `Data` from the store with key=amplify.eu-west-2_mQiFbuxB0.session
[KeychainStore] No Keychain item found for key=amplify.eu-west-2_mQiFbuxB0.session
AWSCognitoAuthPlugin/LoadCredentialStore.swift Sending event CredentialStoreEvent.throwError
AWSCognitoAuthPlugin/IdleCredentialStore.swift Starting execution
AWSCognitoAuthPlugin/IdleCredentialStore.swift Sending event CredentialStoreEvent.moveToIdleState
No existing session found.
AWSCognitoAuthPlugin/InitializeAuthConfiguration.swift Sending event AuthEvent.validateCredentialAndConfiguration
AWSCognitoAuthPlugin/ValidateCredentialsAndConfiguration.swift Starting execution
Auth state change:

{
    "AuthState.validatingCredentialsAndConfiguration" =     {
    };
}
AWSCognitoAuthPlugin/ValidateCredentialsAndConfiguration.swift Sending event AuthEvent.configureAuthentication
Auth state change:

{
    "AuthState.configuringAuthentication" =     {
        "AuthenticationState.notConfigured" =         {
        };
    };
}
AWSCognitoAuthPlugin/InitializeAuthenticationConfiguration.swift Starting execution
AWSCognitoAuthPlugin/InitializeAuthenticationConfiguration.swift Sending event AuthenticationEvent.configure
AWSCognitoAuthPlugin/ConfigureAuthentication.swift Start execution
Auth state change:

{
    "AuthState.configuringAuthentication" =     {
        "AuthenticationState.configured" =         {
        };
    };
}
AWSCognitoAuthPlugin/ConfigureAuthentication.swift Sending event AuthenticationEvent.initializedSignedOut
Credential Store state change:

{
    "CredentialStoreState.error" =     {
        errorType = "KeychainStoreError: Unable to find the keychain item";
    };
}
Credential Store state change:

{
    "CredentialStoreState.idle" =     {
    };
}
AWSCognitoAuthPlugin/ConfigureAuthentication.swift Sending event AuthEvent.authenticationConfigured
Auth state change:

{
    "AuthState.configuringAuthentication" =     {
        "AuthenticationState.signedOut" =         {
            lastKnownUserName = "(nil)";
        };
    };
}
AWSCognitoAuthPlugin/InitializeAuthorizationConfiguration.swift Starting execution
AWSCognitoAuthPlugin/InitializeAuthorizationConfiguration.swift Sending event AuthorizationEvent.configure
Auth state change:

{
    "AuthState.configuringAuthorization" =     {
        "AuthenticationState.signedOut" =         {
            lastKnownUserName = "(nil)";
        };
        "AuthorizationState.notConfigured" =         {
        };
    };
}
AWSCognitoAuthPlugin/ConfigureAuthorization.swift Starting execution
AWSCognitoAuthPlugin/ConfigureAuthorization.swift Sending event AuthEvent.authorizationConfigured
Auth state change:

{
    "AuthState.configuringAuthorization" =     {
        "AuthenticationState.signedOut" =         {
            lastKnownUserName = "(nil)";
        };
        "AuthorizationState.configured" =         {
        };
    };
}
Auth state change:

{
    "AuthState.configured" =     {
        "AuthenticationState.signedOut" =         {
            lastKnownUserName = "(nil)";
        };
        "AuthorizationState.configured" =         {
        };
    };
}
Failed to send CA Event for app launch measurements for ca_event_type: 0 event_name: com.apple.app_launch_measurement.FirstFramePresentationMetric
Failed to send CA Event for app launch measurements for ca_event_type: 1 event_name: com.apple.app_launch_measurement.ExtendedLaunchMetrics
<UIWindow: 0x101b08ea0; frame = (0 0; 393 852); gestureRecognizers = <NSArray: 0x600000c72b50>; layer = <UIWindowLayer: 0x600000c71c20>>
Starting execution for Auth.socialWebUISignInAPI
Check if authstate configured
Auth state configured
Wait for a valid state
Start signIn flow
Wait for signIn to complete
AWSCognitoAuthPlugin/IntializeSignInFlow.swift Starting execution
Auth state change:

{
    "AuthState.configured" =     {
        "AuthenticationState.signingIn" =         {
            "SignInState.notStarted" =             {
            };
        };
        "AuthorizationState.configured" =         {
        };
    };
}
AWSCognitoAuthPlugin/IntializeSignInFlow.swift Sending event SignInEvent.initiateHostedUISignIn
Checking next step for: notStarted
AWSCognitoAuthPlugin/InitializeHostedUISignIn.swift Starting execution
Auth state change:

{
    "AuthState.configured" =     {
        "AuthenticationState.signingIn" =         {
            "SignInState.signingInWithHostedUI" =             {
                "HostedUISignInState.notStarted" =                 {
                };
            };
        };
        "AuthorizationState.configured" =         {
        };
    };
}
AWSCognitoAuthPlugin/LoadCredentialStore.swift Starting execution
Credential Store state change:

{
    "CredentialStoreState.loadingStoredCredentials" =     {
    };
}
Checking next step for: signingInWithHostedUI(AWSCognitoAuthPlugin.HostedUISignInState.notStarted)
AWSCognitoAuthPlugin/LoadCredentialStore.swift Retreiving credential deviceMetadata(username: "unknown")
[KeychainStore] Initialized keychain with service=com.amplify.awsCognitoAuthPlugin, attributes=KeychainStoreAttributes(itemClass: "genp", service: "com.amplify.awsCognitoAuthPlugin", accessGroup: nil), accessGroup=
[KeychainStore] Started retrieving `Data` from the store with key=authConfiguration
[KeychainStore] Successfully retrieved `Data` from the store with key=authConfiguration
[KeychainStore] Started setting `Data` for key=authConfiguration
[KeychainStore] Initialized fetching to decide whether update or add
[KeychainStore] Found existing item, updating
[KeychainStore] Successfully updated `Data` in keychain for key=authConfiguration
[KeychainStore] Started retrieving `Data` from the store with key=amplify.eu-west-2_mQiFbuxB0.unknown.deviceMetadata
[KeychainStore] No Keychain item found for key=amplify.eu-west-2_mQiFbuxB0.unknown.deviceMetadata
AWSCognitoAuthPlugin/LoadCredentialStore.swift Sending event CredentialStoreEvent.throwError
AWSCognitoAuthPlugin/IdleCredentialStore.swift Starting execution
AWSCognitoAuthPlugin/IdleCredentialStore.swift Sending event CredentialStoreEvent.moveToIdleState
AWSCognitoAuthPlugin/LoadCredentialStore.swift Starting execution
AWSCognitoAuthPlugin/LoadCredentialStore.swift Retreiving credential asfDeviceId(username: "unknown")
[KeychainStore] Initialized keychain with service=com.amplify.awsCognitoAuthPlugin, attributes=KeychainStoreAttributes(itemClass: "genp", service: "com.amplify.awsCognitoAuthPlugin", accessGroup: nil), accessGroup=
Credential Store state change:

{
    "CredentialStoreState.error" =     {
        errorType = "KeychainStoreError: Unable to find the keychain item";
    };
}
[KeychainStore] Started retrieving `Data` from the store with key=authConfiguration
Credential Store state change:

{
    "CredentialStoreState.idle" =     {
    };
}
Credential Store state change:

{
    "CredentialStoreState.loadingStoredCredentials" =     {
    };
}
[KeychainStore] Successfully retrieved `Data` from the store with key=authConfiguration
[KeychainStore] Started setting `Data` for key=authConfiguration
[KeychainStore] Initialized fetching to decide whether update or add
[KeychainStore] Found existing item, updating
[KeychainStore] Successfully updated `Data` in keychain for key=authConfiguration
[KeychainStore] Started retrieving `Data` from the store with key=amplify.eu-west-2_mQiFbuxB0.unknown.deviceASF
[KeychainStore] Successfully retrieved `Data` from the store with key=amplify.eu-west-2_mQiFbuxB0.unknown.deviceASF
AWSCognitoAuthPlugin/LoadCredentialStore.swift Sending event CredentialStoreEvent.completedOperation
AWSCognitoAuthPlugin/IdleCredentialStore.swift Starting execution
AWSCognitoAuthPlugin/IdleCredentialStore.swift Sending event CredentialStoreEvent.moveToIdleState
Credential Store state change:

{
    "CredentialStoreState.success" =     {
        savedData = "AWSCognitoAuthPlugin.CredentialStoreData.asfDeviceId(\"2635C31B-6F90-4CD6-B3E6-F777DB746DB5\", \"unknown\")";
    };
}
Credential Store state change:

{
    "CredentialStoreState.idle" =     {
    };
}
AWSCognitoAuthPlugin/InitializeHostedUISignIn.swift Sending event HostedUIEvent(id: "EEEE934C-EA29-42AC-897F-6CE6909CA8AE", eventType: AWSCognitoAuthPlugin.HostedUIEvent.EventType.throwError(AWSCognitoAuthPlugin.SignInError.hostedUI(AWSCognitoAuthPlugin.HostedUIError.signInURI)), time: nil)

Ok, I have this working now. It looks like it was my fault, I had the WebDomain property slightly wrong. So the problem was mine.
I guess some more helpful feedback from Amplify would be useful, rather than just not have the WebUI appear. But other than that I think my problem is solved. Thanks for the help! :)

Hi @januaryblues! I was just about to comment that based on the last log:
AWSCognitoAuthPlugin/ShowHostedUISignIn.swift Sending event SignInEvent(data: nil, id: "D9D78D98-8C60-4975-B6E1-EB6285BCEC61", eventType: AWSCognitoAuthPlugin.SignInEvent.EventType.throwAuthError(AWSCognitoAuthPlugin.SignInError.hostedUI(AWSCognitoAuthPlugin.HostedUIError.signInURI)), time: nil)

there was probably something wrong in your redirect URL. I'm happy to hear that was indeed the issue and that now everything works for you, and I apologize for not coming back to you sooner.
You're right that the lack of an error being thrown is something we need to address in our side, so we'll keep this issue open to track that work and to post further updates.
Thanks!


Option types for nullable scalar inputs in makeVariables?

My GraphQL schema has a nullable String field that gets mapped as option(string) when mapping the response to a record. However, I don't see a parallel for mutations to set that value. In this case, I've specified the argument as $note: String, which I would expect to be treated as option(string) in makeVariables, but it's being treated as string. Am I just overlooking something? If not, how do I set a field to null?

See https://github.com/reasonml-community/graphql_ppx/issues/26.
For now, it's not possible to pass null to a mutation, because reason doesn't have the concept of undefined vs null. We will add this support in 1.0 probably through a query flag where you can pass Some(None) to be explicitly able to pass null into a mutation.

Thanks. I had come across that issue and thought it was about something else. But, reading through, I can see they address the same core problem. I'll close this one out in favor of that.


Add Space between Home and App on Home Page

Maybe add some space between "Home" and "App" on the front page? I kept clicking what I thought was "HomeApp" wondering why the app wasn't opening.

Added #17 to make a slight change for this.

Maybe add some space between "Home" and "App" on the front page? I kept clicking what I thought was "HomeApp" wondering why the app wasn't opening.

weird cus it's fine for me, what's your browser and OS?

Mac OS 11.2.3 Big Sur Safari

I see, I'll deploy your PR as preview, please let me know if it fixed your issue cus it's a user-specific issue


Prettier precommit

Added a prettier pre-commit hook using husky and pretty-quick. It formats files when you commit them... Also comes with a nice terminal UI. https://github.com/CovidEngine/vaxxnz/issues/77

Epic @Francismb!

Fyi, prettier as a presubmit job is also being proposed in PR #87.

Excuse the number of test commits. Changed it to use lint-staged and applying eslint and prettier to staged files.

This looks awesome, thanks @Francismb. Is there anything else to add or are we good to merge?

This looks awesome, thanks @Francismb. Is there anything else to add or are we good to merge?

Depends if you want anything else! IMO It is good to go.

Looks good to me! :shipit:


Icon options are not keyboard accessible

Testing #194038
This may be because hover is used in the background, but I can open the picker using the keyboard but then I cannot select an icon using the keyboard.

It is working for me.
https://github.com/microsoft/vscode/assets/10746682/6383826f-42b2-4e32-a747-5001d340faff
Can you please let me know if you are trying to do differently?

Ah I was using tab. I guess things are more accessible than I thought. Some issues I still see

Do search such as e now you can only use the up and down arrows to cycle because left and right are tied to the input box
Hit tab, you've now exited the hover and there is no way to get back in.

Do search such as e now you can only use the up and down arrows to cycle because left and right are tied to the input box

https://github.com/microsoft/vscode/issues/194217

Hit tab, you've now exited the hover and there is no way to get back in.

Will be fixed by this - https://github.com/microsoft/vscode/issues/194094


Flow cannot define type of variable used inside of a callback

Flow ignores explicit value of a variable used inside of a callback.
/* @flow */

var x: ?string[];

x = [];

x.includes(1); // OK

[].map(() => x.includes(1)); // Error: call of method `includes`. Method cannot be called on possibly undefined value

Example:
https://flow.org/try/#0PQKgBAAgZgNg9gdzCYAoVA3AhgJzADwC4wB+AZwBccBLAOwHMBtAXQG518wBeMF91fADo6AYxgBXACYBTMgAoAjAEpWYYMDAB5ANLoWggLZYADnLlLuAPgLDaYqbMVKVajQFEcOODmIisMGDA4KDADaQoACzhJMAADUQkZMljBMABZcKiYv1paOAowACNpMD8A6Ri4WjBjODIyakKYAE8wcVoZKDoKsGwJaVQgA

@frux I'm pretty sure this isn't a bug because the callback might be executed asynchronously.
The reason is that you've told flow that the variable could be undefined by doing ?string[]. Because you've explicitly told flow that, flow is expected to trust you and go off what you say.
The following also produces the error, as you stated. This would be a more arguable case for you to present, but I still think the fact you've given a type annotation to flow means flow should trust you.
var x: ?string[] = [];
[].map(() => x.includes(1));

However, the following example is probably a bug with flow:
var x;
[].map(() => x.includes(1));
x = [];

Here, flow should not allow this code to compile. The reason flow allows it is because flow incorrectly infers the type of x as an array. However, this code would throw an error at runtime because x is undefined when the map is called, but flow doesn't know that because it thinks it's an array.
This example would fail to compile in typescript with the strict options enabled because typescript would tell you that you haven't declared the type of x so it has type "any" in some locations.

I see. It would be a real magic if flow could understand that callback will be called syncronously. Is there the only resolution to check x every time callback is called?
[].map(() => x && x.includes(1));

There's a way you can work around this:
// type guard, then...
var definedX = x; // This creates a variable which flow knows will not be undefined
// ... then reference definedX inside your callback

Ok, thanks for the explanation.


fix NPE in MultiRegistryAuthSupplier

it never checks if authForBuild returns null

Codecov Report

Merging #783 into master will decrease coverage by 0.02%.
The diff coverage is 50%.

@@             Coverage Diff              @@
##             master     #783      +/-   ##
============================================
- Coverage      65.9%   65.88%   -0.03%
- Complexity      697      698       +1
============================================
  Files           158      158
  Lines          3021     3022       +1
  Branches        346      347       +1
============================================
  Hits           1991     1991
  Misses          876      876
- Partials        154      155       +1


Upgrade to Symfony 6

enhance: Update readme

enhance: Upgrade to symfony 6

enhance: Update symfony/framework-bundle recipe

enhance: Update symfony/routing recipe

enhance: Add context property type

[ ] Update dependency; wait for https://github.com/yceruto/ddd-maker-bundle/pull/4

Thank you @chapterjason!


Update dependencies

Coverage increased (+4.6%) to 96.25% when pulling 0ff1253a6736bda58b40f76142a269aa944cdd8c on update-dependencies into 7eef73adf7156d8b6c71a9506894c0545364e701 on master.


Optimise NEON assembly for get_sad for width 16

Reduces execution time for this function by between 18% and 40%.
The most commonly used block size, 16x16, is improved by 29%.

get_sad/(BLOCK_16X8, 8) time:   [10.095 ns 10.104 ns 10.111 ns]
                        change: [-25.513% -25.484% -25.457%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 25 outliers among 100 measurements (25.00%)
  7 (7.00%) low severe
  1 (1.00%) low mild
  5 (5.00%) high mild
  12 (12.00%) high severe
get_sad/(BLOCK_16X16, 8)
                        time:   [15.758 ns 15.769 ns 15.780 ns]
                        change: [-30.763% -30.703% -30.644%] (p = 0.00 < 0.05)
                        Performance has improved.
get_sad/(BLOCK_16X32, 8)
                        time:   [26.581 ns 26.586 ns 26.592 ns]
                        change: [-35.741% -35.705% -35.668%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 14 outliers among 100 measurements (14.00%)
  1 (1.00%) low mild
  1 (1.00%) high mild
  12 (12.00%) high severe
get_sad/(BLOCK_16X4, 8) time:   [6.9992 ns 7.0004 ns 7.0019 ns]
                        change: [-19.098% -18.976% -18.842%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 9 outliers among 100 measurements (9.00%)
  1 (1.00%) low mild
  5 (5.00%) high mild
  3 (3.00%) high severe
get_sad/(BLOCK_16X64, 8)
                        time:   [47.702 ns 47.710 ns 47.720 ns]
                        change: [-38.632% -38.550% -38.465%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 17 outliers among 100 measurements (17.00%)
  5 (5.00%) high mild
  12 (12.00%) high severe

Coverage decreased (-3.1%) to 65.596% when pulling 81e9252881e77f681189f3e260de83721f08e15e on barrbrain:aarch64-sad into 84f82c70e3b2c47d72dbbd6af6f181fc5ec0ed46 on xiph:master.