Connection failed loop if hostname doesn't match certificate

Describe the bug
If the server is configured to use TLS but upon connecting the hostname does not match the certificate (or perhaps if the certificate has expired as well, haven't tested), an error will be printed indicating as such every 3-5 seconds as Syncplay attempts to reconnect.
To Reproduce
Set up working TLS support, then change from using the valid hostname in the client settings to either another or to the direct IP address of the server.
Expected behavior
As Syncplay is supposed to support Opportunistic TLS I would expect that upon failing to establish a working TLS connection, even if TLS is supposed to be supported by the server, a non TLS fallback connection would be established instead, exactly as if TLS support was not included in the client.
Version and platform:

OS: Both Windows and Linux
Syncplay version and build type: Syncplay 1.7.1
Media player and version:  mpv

I think what you describe is not a bug. It's in fact necessary feature for TLS to work in its confidentiality aspect.
What you described as expected behavior would be to allow a zero-effort man-in-the-middle attack to be executed against the connection by forcing a fallback.
If the server you are connecting to is using a certificate for different hostname than it actually has, that's a problem for the server administrator to resolve.

As long as an appropriate message is printed denoting that the connection is NOT using TLS I don't really see the issue, given that if a user simply lacks a TLS dependency like python-service-identity they can connect to the server using any address or hostname without error and begin leaking an entire chatroom over plain text anyway.
If TLS was meant to be enforced and not opportunistic I would agree with you, or if the user was somehow fooled into thinking they did have a TLS connection when in fact they did not.
However, I do understand your point and would understand if this were closed as not a bug. The scenario is pretty niche, and I agree that the better option is to get users and administrators to configure their configs correctly.

I agree that the present behaviour isn't really a bug, as it doesn't go against documented behaviour. Just changing it to connect with plaintext seems like a step backwards, and making user option just for this edge case seems unnecessary. If there was going to be a change, it would want to be a change more generally to how Syncplay more generally handled plaintext connections.
If the present behaviour were changed I'm not sure if it would be better for it to be:

require SSL (with exception list) by default; or
allow plaintext but error on invalid SSL by default, but allow SSL to be required and allow hosts where plaintext is always allowed.

The advance of option 1 is that it would encourage security, but the advantage of option 2 is that it would not scare people disproportionately for non-SSL servers.
There's also the issue that if a user makes a big deal of requiring SSL then that still doesn't guarantee that all users on the connection have SSL. If we raise expectations about SSL, then there would need a way for warning people about if there is someone connected to the server who doesn't have SSL to avoid a false sense of privacy.
All of this is a lot of complexity, and would result in a lot of text that would need to be converted into multiple languages.
I'm not really sure it is worth it when the vast majority of Syncplay users use the public servers (that support SSL) and use Windows (that supports SSL). There's a lot of design decisions that would need to be consulted upon and made, and a lot of testing that would need to be done on the changes.
Even if there is consensus for how to change the current behaviour someone would have to volunteer to implement it. I only connect to one server and that server has SSL enabled so it's not really a feature I would use, and as such it is not a good one for me to developer or maintain. Also, I don't really have much time for non-critical features at the moment in any case.

There's also the issue that if a user makes a big deal of requiring SSL then that still doesn't guarantee that all users on the connection have SSL. If we raise expectations about SSL, then there would need a way for warning people about if there is someone connected to the server who doesn't have SSL to avoid a false sense of privacy.

Having an "enforce TLS" toggle for the server, which if disabled resulted in users having a green tick or red cross by their name showing their connection status would be a nice way of handling this (could add tooltips saying "using TLS/not using TLS").
Personally I would always prefer enforcing TLS. But it wasn't enforced, and has resulted in a peculiar situation that I should probably have handled at an administration level rather than as a bug report (though I still consider the looping connection failure strange when you can bypass TLS entirely anyway).
I agree that this is a non critical topic, so feel free to shelve or close it.

If someone wanted to code an enforce SSL server I wouldn't have a problem with that so long as they had a backwards compatible way of telling users why their connection attempt failed.


Adjusted ServerRole when using SingleServerFarm

Wrong serveRole specified, it should be 'SingleServer' not 'SingleServerFarm'.

Hmm I haven't tested this yet, but according to this documentation it should still be "SingleServerFarm": https://docs.microsoft.com/en-us/sharepoint/administration/role-conversion-using-minrole-in-sharepoint-server-2016#how-to-change-a-server-role

Hmm I haven't tested this yet, but according to this documentation it should still be "SingleServerFarm": https://docs.microsoft.com/en-us/sharepoint/administration/role-conversion-using-minrole-in-sharepoint-server-2016#how-to-change-a-server-role

Thanks for reply :)
I was unable to launch psconfig when the value SingleServerFarm was set for the registry key "Computer\HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Shared Tools\Web Server Extensions\16.0\WSS\ServerRole" but when I set this to "SingleServer" the wizard starts and I can proceed with the configuration.
Se image below:

What version of SharePoint is this happening on? Are you trying to run PSConfig manually, or in the context of AutoSPInstaller?

What version of SharePoint is this happening on? Are you trying to run PSConfig manually, or in the context of AutoSPInstaller?

Hi, we are running SPSE and this fails both if I run it in the AutoSP Context (null reference value) och manually when starting psconfigUI.

OK I'll try to repro now, stay tuned.

If you do a Set-SPServer -Role and then tab through the options you should see BOTH SingleServer and SingleServerFarm. I'm assuming they're both valid and equivalent.
I just built a farm using SingleServerFarm and it worked fine.

And when I checked the registry, my server role actually was listed as APPLICATION even though central admin and PowerShell both report Single-Server Farm.
I'm running Subscription Edition with the January PU.

If you do a Set-SPServer -Role and then tab through the options you should see BOTH SingleServer and SingleServerFarm. I'm assuming they're both valid and equivalent.
I just built a farm using SingleServerFarm and it worked fine.
And when I checked the registry, my server role actually was listed as APPLICATION even though central admin and PowerShell both report Single-Server Farm.
I'm running Subscription Edition with the January PU.

Thanks for looking into this. The Registry made me confused about this (Application) and I thought the value would be the same as the actual min role.
Not sure why we got the error in the first place but we can close this by now.


Add ruff (a fast Python linter) to pre-commit.

Shamelessly stolen from the TileDB SOMA repository [1], this change adds ruff to the pre-commit workflow.
Also does some minor changes to placate ruff so we start off with a completely clean slate.
[1] https://github.com/single-cell-data/TileDB-SOMA/pull/751
(cc @gsakkis)

Btw @ihnorton pointed out that ruff can subsume isort, you may remove the latter if you want.


Enable use of qiskit ParameterExpressions for circuit conversion: qiskit to braket

Summary

Users that work with a qiskit circuit that was parameterized using a qiskit ParameterExpression can now convert their qiskit circuit to a braket circuit using the convert_qiskit_to_braket_circuit function.

Details

A qiskit ParameterExpression could be for example a qiskit Parameter object with a constant (i.e., float) offset. This could be relevant if one uses a constant baseline for a rotation value on which a variable Parameter then gets added.

This could look something like this for a parametrized CNOT gate in qiskit:
from qiskit.circuit import QuantumCircuit, QuantumRegister
from qiskit_braket_provider.providers import adapter

q_reg = QuantumRegister(2)
my_qc = QuantumCircuit(q_reg, name="custom_cx")

baseline = np.pi * np.array([0.1, 0.3, 0.7, 0.3, -0.4, 0.4, -0.3])
params = ParameterVector(name='a', length=7)

my_qc.u(
    baseline[0] + params[0], # This 'sum' constitutes a qiskit ParameterExpression
    baseline[1] + params[1],
    baseline[2] + params[2],
    q_reg[0],
)
my_qc.u(
    baseline[3] + params[3],
    baseline[4] + params[4],
    baseline[5] + params[5],
    q_reg[1],
)
my_qc.rzx(baseline[6] + params[6], q_reg[0], q_reg[1])

braket_circuit = adapter.convert_qiskit_to_braket_circuit(my_qc)

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hi @lukasvoss, thank you for the contribution! This is a great feature. Please add some tests that cover the lines you've added and show that your changes work correctly.

Dear Lauren, dear Jean-Christophe,
I have implement some changes that are solving the errors arising from the qiskit naming convention of ParameterVector elements by removing the squared-parenthesis from the parameter name.

@jcjaskula-aws Thanks for your contribution, looks good to me!

@all: Thanks for all your contributions!


#863 VA Profile integration: Revise the format of the POST response returned during QA testing

During QA/integration testing, the POST response is supposed to contain the PUT request body.  This is for convenience when making POST requests from a command line client, such as curl, so the user doesn't have to check the CloudWatch logs to see the PUT body.
The PUT body wasn't showing up, and the reason is that AWS Lambda requires the lambda handler return value to include an HTTP response body in a "body" attribute with a stringified value.  This is not well documented.
Using curl in the EC2 bastion host terminal:
< HTTP/2 200
< server: awselb/2.0
< date: Mon, 24 Oct 2022 21:21:48 GMT
< content-type: application/json
< content-length: 78
<
* Connection #0 to host dev.api.notifications.va.gov left intact
{"put_body": {"dateTime": "2022-10-15T02:00:12Z", "status": "COMPLETED_NOOP"}}

Closes #863.

Deployed: https://github.com/department-of-veterans-affairs/notification-api/actions/runs/3316229178

Titles of PRs should start with #issue_number. There's also a template that should have populated for you to fill in but this PR does not fit the format. Did the template not populate?

I added the issue number to the title.  The template populates.


Visual C++ Build Tools link is no longer working

The link to Visual C++ Build Tools for Windows build no longer works, shows only "Expired account".

I would guess it's the Build Tools option over at https://www.visualstudio.com/downloads/ now but I'm not sure.


Running Caddy as a reverse proxy is causing JetBrains teamware to crash, issue with content-type headers?

We are trying to run JetBrains Teamware, a set of Java apps that have their own webservers (Jetty, it seems), through a Caddy reverse proxy. We're having an issue, however, with the apps crashing under Caddy when they talk to JetBrains' authentication service, which we think has something to do with the content-type header.
1. What version of Caddy are you running (caddy -version)?
Caddy 0.8.2
2. What are you trying to do?
Basically, each of the apps (a CD service, a code review service, etc) talks to a JetBrains "Hub," or authentication service, that operates with oAuth and a few other things. Each of the apps has an internal "Hub" but in order to tie them together you need to be running an external instance of a hub. That's fine, but when they boot up and try and connect to the Hub under Caddy, we encounter the issue specified here: https://youtrack.jetbrains.com/oauth?state=%2Fissue%2FJPS-3181 - with exactly the same error output.
We think the problem may be outlined in this comment:

Do you use some proxy for Hub? Looks like Content-type in response was changed to "text/plain".
My colleague told me that Hub may response only with "application/json""

But through our poking around doesn't actually appear that the content-type on that request is getting changed/added via Caddy -- and nothing in the Caddy code looks to us like the content-types would be getting replaced.
 Our initial thought was to overwrite the headers anyway, but we can't manually specify mimetypes due to #666 -- they'd simply get appended, rather than replaced.
Curiously, according to the docs:

Normally, Content-Type is detected automatically, but this is not always possible. If you encounter responses with the wrong Content-Type, you can use this middleware to correct it.

but again, we don't see where in Caddy the Content-Type would be getting inferred/set in the first place. Where in the Caddy code would that automatic detection be taking place?
The Hub docs suggest this as the setup for an Nginx/Apache proxy, and we think we emulated that with Caddy, except for the part about 'DefaultType,'  directive which Caddy does not have. (And if I knew how the content-type headers were getting coerced, I'd just build one.)
3. What is your entire Caddyfile?

hub.tw.mydomain.com {
  proxy / localhost:8081 {
    proxy_header Host {host}
    proxy_header X-Real-IP {remote}
    proxy_header X-Forwarded-Proto {scheme}
    proxy_header X-Forwarded-Host {host}
    websocket
  }

  log /hub/api/rest /var/log/access.log "{remote} - [{when}] {method} {path} {>Accept} {status} {size}"
}

upsource.tw.mydomain.com {
  proxy / localhost:8082 {
    proxy_header Host {host}
    proxy_header X-Real-IP {remote}
    proxy_header X-Forwarded-Proto {scheme}
    proxy_header X-Forwarded-Host {host}
    websocket
  }
}

youtrack.tw.mydomain.com {
  proxy / localhost:8083 {
    proxy_header Host {host}
    proxy_header X-Real-IP {remote}
    proxy_header X-Forwarded-Proto {scheme}
    proxy_header X-Forwarded-Host {host}
    websocket
  }
}

teamcity.tw.mydomain.com {
  proxy / localhost:8084 {
    proxy_header Host {host}
    proxy_header X-Real-IP {remote}
    proxy_header X-Forwarded-Proto {scheme}
    proxy_header X-Forwarded-Host {host}
    websocket
  }
}

4.
We're running it via a systemd service, in Centos 6, under a non-root centos user.
5. What did you expect to see?
We expect the JetBrains teamware not to crash. ;-)
6. What did you see instead (give full error messages and/or log)?
The error linked above. Specifically, on our machine (sorry for the fugly Java stacktrace):
youtrack/bin/youtrack.sh run
Starting YouTrack...
* Configuring JetBrains YouTrack 6.5
* Loading logging configuration from /opt/youtrack/lib/ext/log4j.xml
* Redirecting JetBrains YouTrack 6.5 logging to /opt/youtrack/logs/internal/services/bundleProcess
* Configuring Service-Container[bundleProcess]
* Configuring Starting Page Service
* Configuring YouTrack Configurator
* Configuring Bundle Hub Configurator
* Configuring YouTrack
* Starting Service-Container[bundleProcess]
* Starting Starting Page Service
* JetBrains YouTrack 6.5 will be available on [https://youtrack.tw.mydomain.com/bundle/starting] after start
* Starting YouTrack Configurator
* Starting Bundle Hub Configurator
[YouTrack Error] [2016-04-04 16:38:10,038]  ERROR - dle.util.hub.HubServiceUpdater - Cannot update services information in Hub
[YouTrack Error] org.glassfish.jersey.message.internal.MessageBodyProviderNotFoundException: MessageBodyReader not found for media type=text/plain;charset=utf-8, type=class jetbrains.jetpass.rest.dto.ServiceJSON, genericType=class jetbrains.jetpass.rest.dto.ServiceJSON.
[YouTrack Error]    at org.glassfish.jersey.message.internal.ReaderInterceptorExecutor$TerminalReaderInterceptor.aroundReadFrom(ReaderInterceptorExecutor.java:232)
[YouTrack Error]    at org.glassfish.jersey.message.internal.ReaderInterceptorExecutor.proceed(ReaderInterceptorExecutor.java:156)
[YouTrack Error]    at org.glassfish.jersey.message.internal.MessageBodyFactory.readFrom(MessageBodyFactory.java:1085)
[YouTrack Error]    at org.glassfish.jersey.message.internal.InboundMessageContext.readEntity(InboundMessageContext.java:853)
[YouTrack Error]    at org.glassfish.jersey.message.internal.InboundMessageContext.readEntity(InboundMessageContext.java:785)
[YouTrack Error]    at org.glassfish.jersey.client.ClientResponse.readEntity(ClientResponse.java:326)
[YouTrack Error]    at org.glassfish.jersey.client.JerseyInvocation.translate(JerseyInvocation.java:790)
[YouTrack Error]    at org.glassfish.jersey.client.JerseyInvocation.access$500(JerseyInvocation.java:91)
[YouTrack Error]    at org.glassfish.jersey.client.JerseyInvocation$2.call(JerseyInvocation.java:687)
[YouTrack Error]    at org.glassfish.jersey.internal.Errors.process(Errors.java:315)
[YouTrack Error]    at org.glassfish.jersey.internal.Errors.process(Errors.java:297)
[YouTrack Error]    at org.glassfish.jersey.internal.Errors.process(Errors.java:228)
[YouTrack Error]    at org.glassfish.jersey.process.internal.RequestScope.runInScope(RequestScope.java:444)
[YouTrack Error]    at org.glassfish.jersey.client.JerseyInvocation.invoke(JerseyInvocation.java:683)
[YouTrack Error]    at org.glassfish.jersey.client.JerseyInvocation$Builder.method(JerseyInvocation.java:439)
[YouTrack Error]    at org.glassfish.jersey.client.JerseyInvocation$Builder.post(JerseyInvocation.java:340)
[YouTrack Error]    at jetbrains.jetpass.client.accounts.ServiceClient.updateService(ServiceClient.java:89)
[YouTrack Error]    at com.jetbrains.bundle.util.hub.HubServiceUpdater.compareAndUpdateParameters(HubServiceUpdater.java:244)
[YouTrack Error]    at com.jetbrains.bundle.util.hub.HubServiceUpdater.updateServicesInfoInHub(HubServiceUpdater.java:267)
[YouTrack Error]    at com.jetbrains.bundle.util.hub.HubServiceUpdater.update(HubServiceUpdater.java:55)
[YouTrack Error]    at com.jetbrains.bundle.services.impl.HubConfiguratorService.doStart(HubConfiguratorService.java:65)
[YouTrack Error]    at com.jetbrains.bundle.services.impl.ServiceBase.start(ServiceBase.java:62)
[YouTrack Error]    at com.jetbrains.bundle.Services.startService(Services.java:518)
[YouTrack Error]    at com.jetbrains.bundle.Services.startAllServices(Services.java:490)
[YouTrack Error]    at com.jetbrains.bundle.Services.start(Services.java:468)
[YouTrack Error]    at com.jetbrains.bundle.BundleMain.start(BundleMain.java:248)
[YouTrack Error]    at com.jetbrains.bundle.BundleMain.start(BundleMain.java:208)
[YouTrack Error]    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
[YouTrack Error]    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
[YouTrack Error]    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
[YouTrack Error]    at java.lang.reflect.Method.invoke(Method.java:497)
[YouTrack Error]    at com.jetbrains.bundle.bootstrap.Bundle$EntryPointProvider$1.invoke(Bundle.java:108)
[YouTrack Error]    at com.sun.proxy.$Proxy2.start(Unknown Source)
[YouTrack Error]    at com.jetbrains.bundle.bootstrap.Bundle.start(Bundle.java:54)
[YouTrack Error]    at com.jetbrains.launcher.AppProxy$4.call(AppProxy.java:83)
[YouTrack Error]    at com.jetbrains.launcher.AppProxy$4.call(AppProxy.java:81)
[YouTrack Error]    at java.util.concurrent.FutureTask.run(FutureTask.java:266)
[YouTrack Error]    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
[YouTrack Error]    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
[YouTrack Error]    at java.lang.Thread.run(Thread.java:745)
[YouTrack Error] [2016-04-04 16:38:10,042]  ERROR - es.impl.HubConfiguratorService - Cannot update Hub properties: MessageBodyReader not found for media type=text/plain;charset=utf-8, type=class jetbrains.jetpass.rest.dto.ServiceJSON, genericType=class jetbrains.jetpass.rest.dto.ServiceJSON.
[YouTrack Error] org.glassfish.jersey.message.internal.MessageBodyProviderNotFoundException: MessageBodyReader not found for media type=text/plain;charset=utf-8, type=class jetbrains.jetpass.rest.dto.ServiceJSON, genericType=class jetbrains.jetpass.rest.dto.ServiceJSON.
[YouTrack Error]    at org.glassfish.jersey.message.internal.ReaderInterceptorExecutor$TerminalReaderInterceptor.aroundReadFrom(ReaderInterceptorExecutor.java:232)
* Error while starting JetBrains YouTrack 6.5: MessageBodyReader not found for media type=text/plain;charset=utf-8, type=class jetbrains.jetpass.rest.dto.ServiceJSON, genericType=class jetbrains.jetpass.rest.dto.ServiceJSON.
* Stopping YouTrack
* Stopping Bundle Hub Configurator
* Stopping YouTrack Configurator
[YouTrack Error]    at org.glassfish.jersey.message.internal.ReaderInterceptorExecutor.proceed(ReaderInterceptorExecutor.java:156)
[YouTrack Error]    at org.glassfish.jersey.message.internal.MessageBodyFactory.readFrom(MessageBodyFactory.java:1085)
[YouTrack Error]    at org.glassfish.jersey.message.internal.InboundMessageContext.readEntity(InboundMessageContext.java:853)
[YouTrack Error]    at org.glassfish.jersey.message.internal.InboundMessageContext.readEntity(InboundMessageContext.java:785)
[YouTrack Error]    at org.glassfish.jersey.client.ClientResponse.readEntity(ClientResponse.java:326)
[YouTrack Error]    at org.glassfish.jersey.client.JerseyInvocation.translate(JerseyInvocation.java:790)
[YouTrack Error]    at org.glassfish.jersey.client.JerseyInvocation.access$500(JerseyInvocation.java:91)
[YouTrack Error]    at org.glassfish.jersey.client.JerseyInvocation$2.call(JerseyInvocation.java:687)
[YouTrack Error]    at org.glassfish.jersey.internal.Errors.process(Errors.java:315)
[YouTrack Error]    at org.glassfish.jersey.internal.Errors.process(Errors.java:297)
[YouTrack Error]    at org.glassfish.jersey.internal.Errors.process(Errors.java:228)
[YouTrack Error]    at org.glassfish.jersey.process.internal.RequestScope.runInScope(RequestScope.java:444)
[YouTrack Error]    at org.glassfish.jersey.client.JerseyInvocation.invoke(JerseyInvocation.java:683)
[YouTrack Error]    at org.glassfish.jersey.client.JerseyInvocation$Builder.method(JerseyInvocation.java:439)
[YouTrack Error]    at org.glassfish.jersey.client.JerseyInvocation$Builder.post(JerseyInvocation.java:340)
[YouTrack Error]    at jetbrains.jetpass.client.accounts.ServiceClient.updateService(ServiceClient.java:89)
[YouTrack Error]    at com.jetbrains.bundle.util.hub.HubServiceUpdater.compareAndUpdateParameters(HubServiceUpdater.java:244)
[YouTrack Error]    at com.jetbrains.bundle.util.hub.HubServiceUpdater.updateServicesInfoInHub(HubServiceUpdater.java:267)
[YouTrack Error]    at com.jetbrains.bundle.util.hub.HubServiceUpdater.update(HubServiceUpdater.java:55)
[YouTrack Error]    at com.jetbrains.bundle.services.impl.HubConfiguratorService.doStart(HubConfiguratorService.java:65)
[YouTrack Error]    at com.jetbrains.bundle.services.impl.ServiceBase.start(ServiceBase.java:62)
[YouTrack Error]    at com.jetbrains.bundle.Services.startService(Services.java:518)
[YouTrack Error]    at com.jetbrains.bundle.Services.startAllServices(Services.java:490)
[YouTrack Error]    at com.jetbrains.bundle.Services.start(Services.java:468)
[YouTrack Error]    at com.jetbrains.bundle.BundleMain.start(BundleMain.java:248)
[YouTrack Error]    at com.jetbrains.bundle.BundleMain.start(BundleMain.java:208)
[YouTrack Error]    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
[YouTrack Error]    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
[YouTrack Error]    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
[YouTrack Error]    at java.lang.reflect.Method.invoke(Method.java:497)
[YouTrack Error]    at com.jetbrains.bundle.bootstrap.Bundle$EntryPointProvider$1.invoke(Bundle.java:108)
[YouTrack Error]    at com.sun.proxy.$Proxy2.start(Unknown Source)
[YouTrack Error]    at com.jetbrains.bundle.bootstrap.Bundle.start(Bundle.java:54)
[YouTrack Error]    at com.jetbrains.launcher.AppProxy$4.call(AppProxy.java:83)
[YouTrack Error]    at com.jetbrains.launcher.AppProxy$4.call(AppProxy.java:81)
[YouTrack Error]    at java.util.concurrent.FutureTask.run(FutureTask.java:266)
[YouTrack Error]    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
[YouTrack Error]    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
[YouTrack Error]    at java.lang.Thread.run(Thread.java:745)
[YouTrack Error] [2016-04-04 16:38:10,044]  ERROR -                 bundle.startup - Error while starting JetBrains YouTrack 6.5: MessageBodyReader not found for media type=text/plain;charset=utf-8, type=class jetbrains.jetpass.rest.dto.ServiceJSON, genericType=class jetbrains.jetpass.rest.dto.ServiceJSON.
* Stopping Starting Page Service
* Stopping Service-Container[bundleProcess]
[YouTrack Error] [2016-04-04 16:38:10,080]   WARN - y.util.thread.QueuedThreadPool - qtp2042924422{STOPPING,8<=8<=200,i=6,q=6} Couldn't stop Thread[qtp2042924422-31,5,main]
[YouTrack Error] [2016-04-04 16:38:10,080]   WARN - y.util.thread.QueuedThreadPool - qtp2042924422{STOPPING,8<=8<=200,i=6,q=6} Couldn't stop Thread[qtp2042924422-32,5,main]
[YouTrack Error] [2016-04-04 16:38:10,080]   WARN - y.util.thread.QueuedThreadPool - qtp2042924422{STOPPING,8<=8<=200,i=6,q=6} Couldn't stop Thread[qtp2042924422-34,5,main]
[YouTrack Error] [2016-04-04 16:38:10,080]   WARN - y.util.thread.QueuedThreadPool - qtp2042924422{STOPPING,8<=8<=200,i=6,q=6} Couldn't stop Thread[qtp2042924422-36,5,main]
[YouTrack Error] [2016-04-04 16:38:10,081]   WARN - y.util.thread.QueuedThreadPool - qtp2042924422{STOPPING,8<=8<=200,i=6,q=6} Couldn't stop Thread[qtp2042924422-37,5,main]
[YouTrack Error] [2016-04-04 16:38:10,081]   WARN - y.util.thread.QueuedThreadPool - qtp2042924422{STOPPING,8<=8<=200,i=4,q=5} Couldn't stop Thread[qtp2042924422-60,5,main]
YouTrack process finished
Launcher is exiting

The full debug output is here.
Any suggestions? We're also going to submit this issue to JetBrains, but we're pretty sure it has something to do with Caddy because simply accessing the Hub on its port works just fine.
(Tagging my colleague, @mnaughto, who's helping me with this.)

Thanks for the report.
Indeed I do hope to have that headers issue resolved by the next release (it's not a difficult change, just waiting to hear back on how things are going), which may help with this issue.
What happens if you add another proxy_header line:
proxy_header Content-Type application/json

Does that help?

No, I don't have the logs right now but when we did that we got a null pointer exception.
We're also running into some issues that seem to be related to headers with regards to websockets. Any update on when the header issue will be fixed?

We're also running into some issues that seem to be related to headers with regards to websockets.

What kinds of issues?

What kinds of issues?

@molt maybe this issue is related to #713?

Yeah, that's very likely it. We thought it might be related to the
websocket directive only applying headers before the request, or something,
but it's a Jetty-powered app so #713 seems plausible. (I actually don't
have access to that box or the logs right now, sorry if I'm being vague.)
Brett Neese
563-210-3459
On Mon, Apr 11, 2016 at 3:48 PM, elcore<EMAIL_ADDRESS>wrote:

What kinds of issues?
@molt https://github.com/molt maybe this issue is related to #713
https://github.com/mholt/caddy/pull/713?
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/mholt/caddy/issues/719#issuecomment-208555491

Okay, so that is probably fixed. I want to be sure we understand the content-type problem fully. So the proxy setup looks like this:
[==========request==========]  [======response======]
client ---> caddy ---> jetty   ---> caddy ---> client
        A          B            C          D

So you're suggesting, that at A the Content-Type is application/json but was changed to text/plain at B? Or is it something else.

Actually, based on what I was seeing, it seemed like the request pipeline was just fine, but the content type got changed to something unexpected ("text/plain") between C and D.

So the client in this case is JetBrains teamware, and the backend is some jetty instance.
Okay, this is helpful. Someone (if not me) will look into this soon. If you want to get a head start, I'd recommend looking in here and maybe adding some print statements to verify that the Content-Type header is being copied to downstream properly.

Right. Well, more specifically, the client is one JetBrains application (e.g. YouTrack), and the backend is the API of another JetBrains application (Hub, in this case).

Wonder if the changed header value can be reproduced without needing JetBrains.

If you want, the teamware is available for free download, though it's kind
of a pain to install:  https://www.jetbrains.com/youtrack/,
https://www.jetbrains.com/hub/. We're running on a Centos 7 box.
We ended up using a Elastic Load Balancer to do the proxying in Hub for
now, though that's a hacky solution and definitely overkill.
At this point, however, we kind of just wanted to wait to see what happens
when #666 gets first before trying anything else.
Brett Neese
563-210-3459
On Sat, Apr 16, 2016 at 12:44 PM, Matt Holt<EMAIL_ADDRESS>wrote:

Wonder if the changed header value can be reproduced without needing
JetBrains.
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/mholt/caddy/issues/719#issuecomment-210862549

@brettneese Thanks. #666 has been implemented now, ready to give it another try?

The same error in version 0.9.

@mholt We ended up throwing everything on Dokku, for this and other reasons. If I don't get too bogged down I can try things anything sometime this week but it's looking to be v busy.

Running head on into this issue now. Getting the
MessageBodyReader not found for media type=text/plain;charset=utf-8, type=class jetbrains.jetpass.rest.dto.ServiceJSON, genericType=class jetbrains.jetpass.rest.dto.ServiceJSON.

Error with just about any configuration I can come up with. Using an application/json upstream or downstream ends up sending the actual users json but the YouTrack application still throws a fit about not getting JSON back.
More than happy to give access to some test environments, as YouTrack and Hub are both Composed and are free for 10 user accounts or less.

Is this still an issue with the latest version, 0.9.5?

I've had to abandon the JetBrains software for the time being, too many other higher priorities. I'd be happy to open a new ticket with full debug information, instead of just a "Me too!" when I get back to trying the teamware software if you'd like to close out this ticket.

@dschaper Sure, if you find that the problem still exists, feel free to post it here.

I confirm the issue is still there, I was trying to setup Jetbrains softwares behind Caddy and I'm getting the same error.

Fortunately, I reproduce this issue on my local and did some investigation.
Yes, this is indeed a bug, the unexpected header Content-Type=text/plain;charset=utf-8 caused YouTrack crashed. This header isn't set by Caddy nor Hub backend, but go std lib.
I have just captured the culprit packet with the help of wireshark.
Here is the original packet sending from  Hub to Caddy:
Hypertext Transfer Protocol
    HTTP/1.1 200 OK\r\n
    Date: Wed, 21 Jun 2017 00:23:46 GMT\r\n
    Cache-Control: no-cache, no-store, no-transform, must-revalidate\r\n
    Content-Length: 0\r\n
    Server: Jetty(9.2.10.v20150310)\r\n
    \r\n

And this is packet which Caddy proxy to client (YouTrack in my case):
Hypertext Transfer Protocol
    HTTP/1.1 200 OK\r\n
    Cache-Control: no-cache, no-store, no-transform, must-revalidate\r\n
    Content-Length: 0\r\n
    Date: Wed, 21 Jun 2017 00:23:46 GMT\r\n
    Server: Jetty(9.2.10.v20150310)\r\n
    Content-Type: text/plain; charset=utf-8\r\n
    \r\n

Obviously, A Content-Type has been added even there is no body (Conent-Length is 0).
In most scenarios, it isn't harmful, but Jetbrains software seems concern about it particularly.
After I have forbidden the behavior which go std lib does, the issue gone.
However, I don't think we should some tricks in Caddy to workaroud this special issue, it's better to fix in Jetbrains software instead. It should skip the Content-Type if there is no body actually.

Tw, you're amazing. Thanks so much for investigating this!!
It does seem strange that we add (or Go adds) a Content-Type header when there is no body. I agree with Tw that this is a bug in Jetbrains and that they should fix their software, but I'd be interested to know your patch, Tw, for getting rid of the Content-Type header. I think it's worth seeing what it would take to fix this in Caddy so we don't add headers that aren't needed.

@mholt
This is my scary test patch:
diff --git a/caddyhttp/proxy/reverseproxy.go b/caddyhttp/proxy/reverseproxy.go
index 5fc4aed..465e4a2 100644
--- a/caddyhttp/proxy/reverseproxy.go
+++ b/caddyhttp/proxy/reverseproxy.go
@@ -420,6 +420,14 @@ func copyHeader(dst, src http.Header) {
                        dst.Add(k, v)
                }
        }
+
+       _, hasSetCT := dst["Content-Type"]
+       _, hasCT := src["Content-Type"]
+       cl := dst.Get("Content-Length")
+       if !hasSetCT && !hasCT && cl == "0" {
+               // dst.Set("Content-Type", "") // blank Content-Type also trigger the crash
+               dst.Set("Content-Type", "application/json") // add it anyway for test
+       }
 }

This will prevent Go from adding the Content-Type because we set it explicitly.
I have also try to prevent Go from detecting the Content-Type, it also works as expected.
Here is the patch:
diff --git a/src/net/http/server.go b/src/net/http/server.go
index add05c2..a48b88b 100644
--- a/src/net/http/server.go
+++ b/src/net/http/server.go
@@ -1304,7 +1304,7 @@ func (cw *chunkWriter) writeHeader(p []byte) {
        if bodyAllowedForStatus(code) {
                // If no content type, apply sniffing algorithm to body.
                _, haveType := header["Content-Type"]
-               if !haveType && !hasTE {
+               if !haveType && !hasTE && len(p) > 0 {
                        setHeader.contentType = DetectContentType(p)
                }
        } else {

Interesting, thanks for sharing that. Don't you think it is a bug in Go if Go is adding a Content-Type when the Content-Length is 0?

Hmm, I think so before, but it seems to be expected after I have seen this test case.

@mholt I have just opened a ticket on Go anyway

@tw4452852 Awesome! That's great, it looks like your fix will go in Go 1.10, which should resolve this issue. As far as I can tell, nothing will need to change within Caddy, is that right?

Yes.

Gonna clear up our TODO list by closing this issue, since it seems the best and right place to fix this is in Go itself. :) Thanks again so much for looking into this, @tw4452852 !
Tagging as deferred since it's out of this repo's control (we revisit deferred issues even though they're closed so we can check up on their progress, see if someone implemented a patch, etc).


Enable handling of multiple concurrent alerts

Description
Enable handling of multiple concurrent alerts
Motivation and Context
PoC was hard-coded to only read first event, this causes scaling of wrong services.
How Has This Been Tested?
Replaying json against sample stack
{
  "receiver": "scale-up",
  "status": "firing",
  "alerts": [
    {
      "status": "resolved",
      "labels": {
        "alertname": "APIHighInvocationRate",
        "code": "200",
        "function_name": "func_echoit",
        "instance": "gateway:8080",
        "job": "gateway",
        "monitor": "faas-monitor",
        "service": "gateway",
        "severity": "major",
        "value": "5.2"
      },
      "annotations": {
        "description": "High invocation total on gateway:8080",
        "summary": "High invocation total on gateway:8080"
      },
      "startsAt": "2017-04-13T14:56:27.805Z",
      "endsAt": "2017-04-13T15:00:52.805Z",
      "generatorURL": "http://84e1980973da:9090/graph?g0.expr=rate%28gateway_function_invocation_total%5B10s%5D%29+%3E+5&g0.tab=0"
    },
    {
      "status": "resolved",
      "labels": {
        "alertname": "APIHighInvocationRate",
        "code": "200",
        "function_name": "func_webhookstash",
        "instance": "gateway:8080",
        "job": "gateway",
        "monitor": "faas-monitor",
        "service": "gateway",
        "severity": "major",
        "value": "8.4"
      },
      "annotations": {
        "description": "High invocation total on gateway:8080",
        "summary": "High invocation total on gateway:8080"
      },
      "startsAt": "2017-04-13T15:01:12.805Z",
      "endsAt": "2017-04-13T15:03:52.805Z",
      "generatorURL": "http://84e1980973da:9090/graph?g0.expr=rate%28gateway_function_invocation_total%5B10s%5D%29+%3E+5&g0.tab=0"
    },
    {
      "status": "resolved",
      "labels": {
        "alertname": "APIHighInvocationRate",
        "code": "200",
        "function_name": "func_base64",
        "instance": "gateway:8080",
        "job": "gateway",
        "monitor": "faas-monitor",
        "service": "gateway",
        "severity": "major",
        "value": "5.2"
      },
      "annotations": {
        "description": "High invocation total on gateway:8080",
        "summary": "High invocation total on gateway:8080"
      },
      "startsAt": "2017-04-13T15:04:27.805Z",
      "endsAt": "0001-01-01T00:00:00Z",
      "generatorURL": "http://84e1980973da:9090/graph?g0.expr=rate%28gateway_function_invocation_total%5B10s%5D%29+%3E+5&g0.tab=0"
    }
  ],
  "groupLabels": {
    "alertname": "APIHighInvocationRate",
    "service": "gateway"
  },
  "commonLabels": {
    "alertname": "APIHighInvocationRate",
    "code": "200",
    "instance": "gateway:8080",
    "job": "gateway",
    "monitor": "faas-monitor",
    "service": "gateway",
    "severity": "major"
  },
  "commonAnnotations": {
    "description": "High invocation total on gateway:8080",
    "summary": "High invocation total on gateway:8080"
  },
  "externalURL": "http://40c2e95d3aba:9093",
  "version": "3",
  "groupKey":<PHONE_NUMBER>4214865000
}

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

Fixes #37 cc/ @aafrey


Fix typo in datadog tutorial

Hello dear Ambassador admins & contributors!
This typo prevents the apply of the CRD to work, this PR proposes a simple fix.
Cheers,

We resolved this in the mentioned issue! Sorry for the delay, and thanks for the PR!


Improve Buffer to avoid small allocations:

High Level Overview of Change
Many of the uses of the Buffer class involve allocations where the size is relatively small and maybe even known at compile time.
This commit introduces code that allows for allocations of up to 112 bytes (sufficient for almost all existing cases) to be serviced without requiring the heap at runtime.
Since instances of Buffer are typically allocated on the stack and are short-lived, this change should not have any measurable impact on memory usage.
Type of Change

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Refactor (non-breaking change that only restructures code)
[ ] Tests (You added tests for code that already exists, or your new feature included in this PR)
[ ] Documentation Updates
[ ] Release

Given this has no measurable impact on memory usage, what's the motivation for the change? Why do it?

Given this has no measurable impact on memory usage, what's the motivation for the change? Why do it?

I think it improves and simplifies the codebase, while reducing runtime overhead and minimizing memory fragmentation.
But really, the bottom line is that it's just something I just felt like doing and that's the motivation behind it. :man_shrugging:


Broken link

[Enter feedback here]
In reading the doc on this page: https://docs.microsoft.com/en-us/composer/how-to-create-packages...
The link "extending your bot with code" in the "Components in packages" section is broken (404).  That broken link is pointing to https://docs.microsoft.com/en-us/docs/extending-with-code.md

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5b5c8eb1-7cdd-d698-7b7f-52d1d1d8007d
Version Independent ID: ba8ce385-ff98-0bf9-7bc5-d9a53b22c5cb
Content: Create and share packages - Bot Composer
Content Source: composer-docs/how-to-create-packages.md
Service: bot-composer
GitHub Login: @clearab
Microsoft Alias: anclear

@JonathanFingold correct link should be: https://docs.microsoft.com/composer/concept-extend-with-code

The link has been fixed in the current documentation.


Entity Framework Migration and Persisted Volumes

Unclear How to Set up and Migrate pSQL DB w/ EntityFramework DB Contexts

Hey team, I'm trying to follow along with the docs but instead of a redis cache and 2 apps (UI and API) I'm just doing API & Postgres using Npgsql.
~How does the connection string work here? I'd think it was all handled and I wouldn't have to configure a connection string for local dev (the redis setup makes no mention of a connection string). Do I need to add that to the AppHost or API's appsettings.json?~
It looks like the port changes for the database container every time I restart the Aspire project. Any way to make that port static so I don't have to remember to change it each time?
~Finally, it would be neat to get more details about how to manage migrations for entity framework. I assume I'd just run dotnet ef database update from the API project once I stood up the project but theres that pesky connection string issue.~
I spin up the project with dotnet run --project AspireSample.AppHost and in the API project I add the connection string to appsettings.json like so "db": "Host=localhost;Port=51586;Database=postgres;User ID=postgres;Password=postgres" then in another terminal from the API project I run dotnet ef database update to kick off the migration.
Otherwise, really neat project and good docs 🙂
.NET Core 8

[x] .NET Core
[ ] .NET Framework
[ ] .NET Standard

.NET SDK:
 Version:           8.0.100
 Commit:            57efcf1350
 Workload version:  8.0.100-manifests.71b9f198
Runtime Environment:
OS Name:     Mac OS X
OS Version:  14.1
OS Platform: Darwin
RID:         osx-arm64
Base Path:   /usr/local/share/dotnet/sdk/8.0.100/
.NET workloads installed:
Workload version: 8.0.100-manifests.71b9f198
[aspire]
Installation Source: SDK 8.0.100
Manifest Version:    8.0.0-preview.1.23557.2/8.0.100
Manifest Path:       /usr/local/share/dotnet/sdk-manifests/8.0.100/microsoft.net.sdk.aspire/8.0.0-preview.1.23557.2/WorkloadManifest.json
Install Type:        FileBased
Host:
Version:      8.0.0
Architecture: arm64
Commit:       5535e31a71
.NET SDKs installed:
8.0.100 [/usr/local/share/dotnet/sdk]
.NET runtimes installed:
Microsoft.NETCore.App 8.0.0 [/usr/local/share/dotnet/shared/Microsoft.NETCore.App]
Other architectures found:
x64   [/usr/local/share/dotnet/x64]
registered at [/etc/dotnet/install_location_x64]

<replace>

Update: So I spin up the project with dotnet run --project AspireSample.AppHost and in the api project where I define my DbContext and models I add the connection string to appsettings.json like so "db": "Host=localhost;Port=51586;Database=postgres;User ID=postgres;Password=postgres"
I had to fish the port out of the aspire dashboard to paste on my connection string in order to get the migration to work. I ran the migration from my api project with dotnet ef database update
So I don't know if I'm making a rookie .NET mistake here so feel free to flame and/or correct me here, but one thing I can see getting really annoying is having to remember to update the port in the connection string every time I restart the aspire project since it seems the exposed port in the docker container can change. I can see an argument for not pinning it to 5432 but I'd like to make it static to something so future me doesn't have to hunt it down every time.

I am having the exact same issues but with SQL Server.
Really trying to understand the recommended strategy here.

Closed by #327


glorytun: init at 0.3.4

Motivation for this change
There are many scenarios where you want a VPN that can utilize multiple links. In this space, options are very limited, with glorytun and mlvpn has the players I could find. Neither of which are currently any package repositories including nixpkgs.
Configuring these VPNs requires a fair amount of complex routing configuration, which nixos also makes easy.
I've been using this nixos module and package for several months with good success at stabilizing the internet at my hackerspace, with the following configuration: https://github.com/nycresistor/golden-nix/blob/21da8c91d58e7542e58dab97bed9ee694217fff9/containers/gloryrouter/default.nix#L43
Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[X] Fits CONTRIBUTING.md.

Thanks for the review request, but I am a bit short on time these days and won't be able to look at this.  Sorry!


Improve grammar/language for clarity

@louiscryan, FYI. Minor spec change improvement.

I cancelled the the Travis and Jenkins tests, since only docs were chnaged.


Fix display for machineKey tag

The <machineKey> tag wasn't escaped and therefore considered as a tag by Markdown and not displayed.

Hi @Tyf0x, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, DNFBOT;

@Tyf0x  nice catch!  In non-headings, we format as code so you don't need to escape. But for headings, escaping like you've done is best.


Add reply sections to command pages

They are built from resp2_replies.json/resp3_replies.json from valkey-doc. If the RESP2/RESP3 replies are equal, only a single section is added.
By submitting this pull request, I confirm that my contribution is made under the terms of the BSD-3-Clause License.

Note: https://github.com/valkey-io/valkey-doc/pull/202 is necessary to make this work

@gmbnomis Thanks for the work on this! If this is dependent on a PR in another repo, could you please make this a draft PR so it doesn't get accidentally merged.

I put this PR into draft state (and wait until https://github.com/valkey-io/valkey-doc/pull/202 gets merged)


Looking into marking tablet as chopped in compaction mutation

While working on #1605 I noticed that chop compactions write out two mutations to the metadata table.   One mutation changes the tablets set of files.  The second mutation marks the tablet as chopped.  May be better to do this in a single mutation.  This behavior exist before and after #1605.

A single mutation, if possible, is a good idea. Also, for reference only, there's an open ticket to remove chop compactions entirely: #1327

Closing this issue since #1327 is completed.


Same bugged image

Does an issue already cover this?

[X] I have searched for any existing issues, and didn't find any.

Issue description.
Hi, the issue with image dimension (https://github.com/AnOpenSauceDev/FastRandom/issues/37) is still present after the update...
Dimension of the image and the error in the log are the same, and in mod menu the image is not showing up.

I built it with the new image? I'll reupload anyways.

Okay, just re-released 3.0.3. This 100% has the fix.


BUG: scan wants first link to be evaluated dyadically

This is a duplicate of https://github.com/codereport/jello/issues/7


R4R: add version control #56

Waiting for #63

Add command nsd version nscli version
Rename dep.md to go-mod.md
Repair link in tutorial/cn/README.md

wow sorry for the delay. want to try rebasing onto master and updating this PR to fix the conflicts?

closing this in favor of #141


Testing Github PullRequest onWebhook with Github APPS integration on pac-e2e-ns-z94ff

Add a new PR for testing

Pipelines as Code CI/pipelinerun-nddm has successfully validated your commit.

StatusDurationName

✅ Succeeded
5 seconds
The Task name is Task


[Bug] Header colors don't change in dark mode

Live preview works great. Thank you for this beautiful theme. After the theme is loaded and without any change on style settings, dark theme does not show the header font colors correctly. It works for light theme.

I might opened this issue too quickly. Header colors and background customization work. I think the default settings for the header text color is wrong though. It is set to dark. When I changed to light, everything works as expected. I am leaving this issue open if anything related to this comes up.

Thank you for spotting it! Should now be addressed in Version 1.2.1


pull request for e2e test at 01/04/2017 07:26:10

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Added type check to Get(string id).

Ensures the item returned is of the same type as requested.

Ensures the item returned is of the same type as requested.

Hi @RichMercer - another thought that I had was for this pull request to also include an update to the XML comments on the GetAsync overload that has <remarks> calling attention to the fact that null is returned when the .Type is specified but doesn't match.

@all-contributors please add @RichMercer for code

@all-contributors please add @RichMercer for code

@all-contributors please add @RichMercer for code


[Arbitrum] WETH connector

Added WETH connector

Deployed connector:
ConnectorName: "WETH-A"
ConnectorAddress: 0x6C7256cf7C003dD85683339F75DdE9971f98f2FD

Connector whitelisted: 0xec368500230a8bfa99af193dd535e2ca5536dde33981184fdb0c50530fc61c46


Move ParameterVector and ResultVector to the ngraph namespace

while there are a lot of changes they all fit into one of these categories

move src/ngraph/op/*_vector.hpp to the src/ngraph directory
move ngraph::op::ParameterVector to ngraph::ParameterVector. ResultVector was already in the correct namespace
change #include statements

Seems like this could break doc builds...Is this why the other CI tests fail?


Error in the readme

"Distributed sites have gained much attention lately with systems such as ZeroNet and IPFS, which seem to improve on older systems like Freenet."
ZeroNet and IPFS do not improve on Freenet. Unlike the other two freenet is censorship resistant and anonymous.

Hi @M-i-k-o-t-o, how are you?
I made the corrections here: fixed words in README.md


Compile Error Help...

Describe your bug here.

help i can't compile on release(but working on "-debug" i think debug is not using crash handler.)
Command Prompt/Terminal logs (if existing)
- src/options/GameplaySettingsSubState.cpp
 - src/lime/app/_Event_lime_ui_Gamepad_Void.cpp  [haxe,release]
 - src/hscript/Tools.cpp
 - src/openfl/display/_internal/DOMShape.cpp
 - src/__ASSET__flixel_fonts_monsterrat_ttf.cpp
 - src/flxanimate/data/_AnimationData/SymbolInstance_Impl_.cpp
 - src/FuckingTriangleEffect.cpp
Error: Main.cpp
include\openfl/events/ErrorEvent.h(50): error C2059: 구문 오류: '상수'
include\openfl/events/ErrorEvent.h(50): error C2238: ';' 앞에 예기치 않은 토큰이 있습니다.

PS D:\Files\Source Code\FNF-NightEngine>

Are you modding a build from source or with Lua?
Source
What is your build target?
Windows
Did you edit anything in this build? If so, mention or summarize your changes.
// Code was entirely made by sqirra-rng for their fnf engine named "Izzy Engine", big props to them!!!
// very cool person for real they don't get enough credit for their work
#if CRASH_HANDLER
function onCrash(e:UncaughtErrorEvent):Void
{
var errMsg:String = "";
var path:String;
var callStack:Array = CallStack.exceptionStack(true);
var dateNow:String = Date.now().toString();
dateNow = dateNow.replace(" ", "");
dateNow = dateNow.replace(":", "'");
path = "./crash/" + "NightEngine" + dateNow + ".txt";
for (stackItem in callStack)
{
switch (stackItem)
{
case FilePos(s, file, line, column):
errMsg += file + " (line " + line + ")\n";
default:
Sys.println(stackItem);
}
}
errMsg += "\nUncaught Error: " + e.error + "\nPlease report this error to the GitHub page: https://https://github.com/2JENO/NightEngine\n\n> Crash Handler written by: sqirra-rng";  		if (!FileSystem.exists("./crash/"))
FileSystem.createDirectory("./crash/");
File.saveContent(path, errMsg + "\n");
Sys.println(errMsg);
Sys.println("Crash dump saved in " + Path.normalize(path));  		Application.current.window.alert(errMsg, "Error!");
DiscordClient.shutdown();
Sys.exit(1);
}
#end

please help

found the cause: WindowsData.hx
idk why this is problem so i need fix this


Cmdlet doesnt exist

Get-AzureRMAuthorizationChangeLog doesnt exist, in the link to this cmdlet people are also commenting that it doesnt exist, their voice has gone unanswered

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 64d6e1e4-920b-bd7c-6c26-3ae9d311f447
Version Independent ID: 67798f25-4fb7-cc10-d0c7-229dedd75a3a
Content: Access reporting - Azure RBAC
Content Source: articles/role-based-access-control/change-history-report.md
Service: active-directory
GitHub Login: @rolyon
Microsoft Alias: rolyon

@whytoe We will now proceed to close this thread. If there are further questions regarding this matter, please open a new issue and we will gladly continue the discussion.

This workaround is by no means a solution, the cmdlet is broken, please raise this issue with the Powershell Team.


Icons volume 14

Snowflake
Fish
Fuel - example https://cdn2.iconfinder.com/data/icons/maki/100/fuel-512.png
Basic circuit elements (resistor, capacitor, inductor) - see Oct 22 comment for reference
Squid - see Oct 22 comment for reference
Volume (as in capacity-not sound level) https://icons8.com/icon/1415/volume
(Already done) "Skip to first/last page" for pagination icon set (completed. published to Clarity icon library)
Bell curve (Normal distribution chart) see Oct 25 comment...
Crosshairs, see #2987 for example and details
form kinds (like text input、number input、select、horizontal slider fields)、
table kinds (like general table、tree grid、pivot table) icons
Target (for timeline component)

A fuel icon would be great: https://cdn2.iconfinder.com/data/icons/maki/100/fuel-512.png

Basic circuit elements (resistor, capacitor, inductor)
A squid (might not be practical)

A vulume (capacity, amount) icon would be useful: https://icons8.com/icon/1415/volume

HI @lil-kim could we add an icon for "skip to first/last page" in the new pagination design? Not sure what would be the appropriate name for this. Screenshot for reference:

@lil-kim - The capacitor, resistor and inductor circuit elements here are pretty typical: https://en.wikipedia.org/wiki/Electronic_symbol#/media/File:Circuit_elements.svg
There's also a circuit element symbol for a SQUID, which in retrospect would make way more sense than using an icon of a squid (the animal) in my use case.  It looks the screenshot below (from this image) without the red text (and maybe rotated 90 degrees to be consistent) with the others.

@amellnik
Added your SQUID request to the comprehensive list in the first comment.

Could you consider the Bell curve (Normal distribution chart)、form kinds (like text input、number input、select、horizontal slider fields)、table kinds (like general table、tree grid、pivot table) icons?
Sincerely

Hi, @colinreedmiller
We are going to establish dashboard design tool. Many kinds of widgets to be dragged for designer, such as form, table, and chart aspects. Namely, designer is easy to know what kind of widget through icons.
Thanks.

Updated and compiled list of icons for vol 14 - see first comment.

@Stela-Stamenkova ,
the filenames of the Capacitor, Inductor and Resistor are currently mixed up.
Line_Capacitor -> Line_Inductor
Line_Inductor-> Line_Resistor
Line_Resistor -> Line_Capcitor
Regards.

@Ergnos is correct.  I also think that the resistor and inductor symbols might need an additional zigzag/loop to be recognizable.  (See this for example).

@Ergnos Thanks for your feedback. I have addressed the issue in the PR.
@amellnik thanks for your feedback. I agree with your concern so I will talk to @Stela-Stamenkova and @lil-kim
I am working on the PR right now. You can track it here: https://github.com/vmware/clarity/pull/3099

@Shijir, I modified the inductor and resistor icons based on feedback from @Ergnos
and @amellnik :
inductor-resistor.zip

@lil-kim Looks good!


How to reuse initialized tool?

I am trying to run kalign multiple times to feed it different inputs. But if I do:
let CLI = await new Aioli("kalign/3.3.1");
await CLI.fs.writeFile("input.fa", fasta);
let output = await CLI.exec(`kalign input.fa -f fasta -o result.fasta`);
let out = await CLI.cat("result.fasta");

it executes once without any failures. The subsequent runs of this piece of code lead to the exception:
RangeError: Maximum call stack size exceeded
    at kalign.wasm:0x277e
    at kalign.wasm:0xbc82
    at kalign.wasm:0xd417
    at kalign.wasm:0xd9e1
    at kalign.wasm:0xdd6e
    at kalign.wasm:0xdd7f
    at kalign.wasm:0xdd7f
    at kalign.wasm:0xdd7f
    at kalign.wasm:0xdd7f
    at kalign.wasm:0xdd7f

OK I think. The instance of CLI should not probably be created each time the tool is run. Then I should call it once and reuse for subsequent runs. This time for the second and so on runs we end with:
Kalign (3.3.1)

Copyright (C) 2006,2019,2020,2021 Timo Lassmann

This program comes with ABSOLUTELY NO WARRANTY; for details type:
`kalign -showw'.
This is free software, and you are welcome to redistribute it
under certain conditions; consult the COPYING file for details.

Please cite:
  Lassmann, Timo.
  "Kalign 3: multiple sequence alignment of large data sets."
  Bioinformatics (2019)
  https://doi.org/10.1093/bioinformatics/btz795

WARNING: AVX2 instruction set not found!
         Kalign will not run optimally.

Usage: kalign  -i <seq file> -o <out aln>

Options:

   --format           : Output format. [Fasta]
   --reformat         : Reformat existing alignment. [NA]
   --gpo              : Gap open penalty. [5.5]
   --gpe              : Gap extension penalty. [2.0]
   --tgpe             : Terminal gap extension penalty. [1.0]
   --version (-V/-v)  : Prints version. [NA]

Examples:

Passing sequences via stdin:

   cat input.fa | kalign -f fasta > out.afa

Combining multiple input files:

   kalign seqsA.fa seqsB.fa seqsC.fa -f fasta > combined.afa

[2022-02-03 16:27:08] :     LOG : No input files

But the input file is there. I checked that with await CLI.fs.readdir('.'):
['.', '..', 'result.fasta', 'input.fa']
So the question is how can we run a tool more than once?

Thanks for catching that @nikolay-alemasov!
I've seen this issue with other tools before, and it's most likely because command-line arguments are not being reset by main()—they usually don't need to be since with binaries, you only call main() once.
The fix will involve adding a patch to kalign to reset variables like optind; here's an example with samtools.
I will take a look at this in the next few days, but in the meantime you can use the reinit setting in Aioli:
let CLI = await new Aioli({
  tool: "kalign",
  version: "3.3.1",
  reinit: true
});

This will automatically reinitialize the wasm module so you can run it multiple times in a row. It's inefficient but should unblock you until I implement a better fix.

Running kalign multiple times in a row should now work!
<script src="https://cdn.biowasm.com/v2/aioli/latest/aioli.js"></script>
<script type="module">
let CLI = await new Aioli("kalign/3.3.1");
await CLI.fs.writeFile("input.fa", `>1aab_
GKGDPKKPRGKMSSYAFFVQTSREEHKKKHPDASVNFSEFSKKCSERWKT
MSAKEKGKFEDMAKADKARYEREMKTYIPPKGE
>1j46_A
MQDRVKRPMNAFIVWSRDQRRKMALENPRMRNSEISKQLGYQWKMLTEAE
KWPFFQEAQKLQAMHREKYPNYKYRPRRKAKMLPK
>1k99_A
MKKLKKHPDFPKKPLTPYFRFFMEKRAKYAKLHPEMSNLDLTKILSKKYK
ELPEKKKMKYIQDFQREKQEFERNLARFREDHPDLIQNAKK
>2lef_A
MHIKKPLNAFMLYMKEMRANVVAESTLKESAAINQILGRRWHALSREEQA
KYYELARKERQLHMQLYPGWSARDNYGKKKKRKREK`);

let output;

// Run kalign
output = await CLI.exec(`kalign input.fa -f fasta -o result.fasta`);
console.warn(output);

// Run kalign again -- this previously did not work and showed the help screen
output = await CLI.exec(`kalign input.fa -f fasta -o result.fasta`);
console.warn(output);
</script>

Fantastic, @robertaboukhalil ! Thank you very much!


require keras.js in tampermonkey/userscript/greasymonkey

I am trying to use keras.js in my tampermonkey userscript
// ==/UserScript==
// @require https://github.com/transcranial/keras-js/blob/master/dist/keras.js
// ==/UserScript==

but here comes the error:
Syntax error @ "Slither.io Bot Championship Edition"!
##########################
JSHINT output:
require: (E030) Expected an identifier and instead saw '<' on line: 8 at character: 1
require: (E033) Expected an operator and instead saw '!' on line: 8 at character: 2
require: (W030) Expected an assignment or function call and instead saw an expression on line: 8 at character: 2
require: (E058) Missing semicolon on line: 8 at character: 3
require: (W030) Expected an assignment or function call and instead saw an expression on line: 8 at character: 3
require: (E058) Missing semicolon on line: 8 at character: 10
require: (E030) Expected an identifier and instead saw '<' on line: 9 at character: 1
require: (E041) Unrecoverable syntax error. (0% scanned) on line: 9 at character: 1
##########################

SyntaxError: Unexpected token <
    at eval (<anonymous>)
    at <anonymous>:2:398
    at Object.b [as F_c] (<anonymous>:2:243)
    at Object.E_u (<anonymous>:3:66)
    at u (eval at exec_fn (:1:108), <anonymous>:60:208)
    at E (eval at exec_fn (:1:108), <anonymous>:58:458)
    at Object.create (eval at exec_fn (:1:108), <anonymous>:67:51)
    at e (eval at exec_fn (:1:108), <anonymous>:15:238)

Notice that it worked well when I used
// @require http://code.jquery.com/jquery-latest.js
So what is the proper way to do that?

problem with userscript


Zoo Navigator image no longer available

Current helm chart references Zoo Navigator images at v0.6.0, but these are no longer available on docker hub.
Current is here:

https://hub.docker.com/r/elkozmon/zoonavigator

And does not have separate web and api tiers.

@robparrott - thank you for opening this issue. We should have an updated helm chart with a fix next week.


Migrate repositories to Kotlin

Towards #532

@gino-m  PTAL?

/gcbrun

Codecov Report

Merging #1160 (313b481) into master (fb675b4) will decrease coverage by 0.06%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1160      +/-   ##
============================================
- Coverage     27.36%   27.29%   -0.07%
  Complexity      780      780
============================================
  Files           300      300
  Lines          8068     8077       +9
  Branches        341      341
============================================
- Hits           2208     2205       -3
- Misses         5753     5765      +12
  Partials        107      107

Impacted Files
Coverage Δ

...le/android/gnd/repository/UserMediaRepository.java

.../google/android/gnd/repository/UserRepository.java

...e/android/gnd/repository/SubmissionRepository.java

...om/google/android/gnd/repository/UserRepository.kt
100.00% <0.00%> (ø)

...ogle/android/gnd/repository/UserMediaRepository.kt
0.00% <0.00%> (ø)

...gle/android/gnd/repository/SubmissionRepository.kt
8.53% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb675b4...313b481. Read the comment docs.


Patron Rune

The rune patron lacks other trait "witch-patron".

Duplicate of https://github.com/foundryvtt/pf2e/issues/10760


Adding notice that 3.6 is also supported

Checklist

[X ] I have read the [contribution guidelines] (https://github.com/Azure/azure-iot-sdk-python/blob/master/.github/CONTRIBUTING.md).
[ ] I added or modified the existing tests to cover the change (we do not allow our test coverage to go down).
If this is a modification that impacts the behavior of a public API

[ ] I edited the corresponding document in the devdoc folder and added or modified requirements.

I submitted this PR against the correct branch:

[X] This pull-request is submitted against the master branch.
[X] I have merged the latest master branch prior to submission and re-merged as needed after I took any feedback.
[X] I have squashed my changes into one with a clear description of the change.

Reference/Link to the issue solved with this PR (if any)
Description of the problem
Original text stated that it only supported up to 3.5, but if statement was covering to 3.6.
Description of the solution
Just adding that 3.6 is supported.

Thanks @dustinsummers much appreciated!!


Datadog tracer logs are not json formatted

Welcome!

[X] Yes, I've searched similar issues on GitHub and didn't find any.
[X] Yes, I've searched similar issues on the Traefik community forum and didn't find any.

What did you do?
Hello, I've been investigating an issue we initially spotted in our Fluentd log collector and traced it down to usage of the datadog tracer in Traefik.
We have Traefik configured in our kubernetes as the ingress controller, and in this cluster we are also running datadog.
In order to get traces from Traefik to Datadog, we enabled the traces in Traefik by adding the following to the traefik container args:
      - --tracing.datadog=true
      - --tracing.datadog.localAgentHostPort=$(DD_AGENT_HOST):8126
      - --tracing.datadog.prioritySampling=true

And we set the DD_AGENT_HOST environment variable:
      env:
      - name: DD_ENTITY_ID
        valueFrom:
          fieldRef:
            apiVersion: v1
            fieldPath: metadata.uid
      - name: DD_AGENT_HOST
        value: datadog.datadog.svc.cluster.local

In Traefik, we use json logging format:
      - --log.format=json

However, we're noticing some log parsing errors in Fluentd due to logs coming from Traefik which aren't json-formatted.
On investigation, we found that traefik is outputting messages which are initially created by the datadog tracer. So I opened an issue with their team to ask for a fix and from what I understood in the response, Traefik simply needs to provide its json logger to the tracer in order to make the logs json formatted.
Could this be implemented wherever is appropriate in order to ensure that logs output from external tooling are json formatted?
What did you see instead?
Log messages which are not json formatted
What version of Traefik are you using?
2.10.4
What is your environment & configuration?
# (paste your configuration here)

Add more configuration information here.
If applicable, please paste the log output in DEBUG level
No response

Hey @tspearconquest,
Thanks for the bug report.
If any community member can help us find verified steps to reproduce and fix the issue if possible, we would love the help.

@nmengin I tried to reproduce this issue, it is occuring for branch v2.10 but not for master .


Fix delete as admin

Resolved / Related Issues
Items resolved / related issues by this PR.

Closes #5754

Details of Changes
Add details of changes here.

Fixed not getting asked to perform delete operation as admin

Validation
How did you test these changes?

[x] Built and ran the app

Thank you!


Infer short vs longname from actual node and use longname in example

Updated.

:green_heart: :blue_heart: :purple_heart: :yellow_heart: :heart:


require esm error

Follow the steps

npx create-trigger@latest blank-starter
yarn
yarn build
yarn start

And I got
Error [ERR_REQUIRE_ESM]: require() of ES Module node_modules/terminal-link/index.js from<EMAIL_ADDRESS>not supported.

Thanks for the report @gutenye! Going to work on getting a fix released for this ASAP, sorry about this!

This has been fixed in https://github.com/triggerdotdev/trigger.dev/commit/0b67b51ae4603a3a6b38dd1de4bc605554dcfb4c but don't think this will be released and fixed until tomorrow. Will keep this issue updated when it is fixed.

Thanks for the quick fix.


Using the venv module gets you a different pip/setuptools version

If you use Python 3's built-in venv module, you get a different version of the pip and setuptools packages than the latest installed in the images.
See here:
❯ docker run --rm -it python:3.7-slim bash
root@3dcf68819a98:/# pip list
Package    Version
---------- -------
pip        19.1.1
setuptools 41.0.1
wheel      0.33.1
root@3dcf68819a98:/# python -m venv venv
root@3dcf68819a98:/# venv/bin/pip list
Package    Version
---------- -------
pip        19.0.3
setuptools 40.8.0
You are using pip version 19.0.3, however version 19.1.1 is available.
You should consider upgrading via the 'pip install --upgrade pip' command.
root@3dcf68819a98:/# python -c 'import sys; print(sys.path)'
['', '/usr/local/lib/python37.zip', '/usr/local/lib/python3.7', '/usr/local/lib/python3.7/lib-dynload', '/usr/local/lib/python3.7/site-packages']
root@3dcf68819a98:/# venv/bin/python -c 'import sys; print(sys.path)'
['', '/usr/local/lib/python37.zip', '/usr/local/lib/python3.7', '/usr/local/lib/python3.7/lib-dynload', '/venv/lib/python3.7/site-packages']
root@3dcf68819a98:/# ls /usr/local/lib/python3.7/site-packages
README.txt  __pycache__  easy_install.py  pip  pip-19.1.1.dist-info  pkg_resources  setuptools	setuptools-41.0.1.dist-info  wheel  wheel-0.33.1.dist-info
root@3dcf68819a98:/# ls /venv/lib/python3.7/site-packages
__pycache__  easy_install.py  pip  pip-19.0.3.dist-info  pkg_resources	setuptools  setuptools-40.8.0.dist-info

Similar older issue that was closed: #118
Relevant discussion: https://github.com/docker-library/python/issues/365#issuecomment-456191568

Odd, it seems that the version of venv that comes built-in isn't the most recent, I can't find information in pip or Python release notes about the version they come with. But this is the venv source https://github.com/python/cpython/tree/3.7/Lib/venv/
from https://docs.python.org/3/library/venv.html
The __init__.py is a few months old
And the usage of the built-in venv is limited and doens't have any way to get the version or upgrade
root@5739dbcd587f:/# python -m venv
usage: venv [-h] [--system-site-packages] [--symlinks | --copies] [--clear]
            [--upgrade] [--without-pip] [--prompt PROMPT]
            ENV_DIR [ENV_DIR ...]

I'd come across this issue https://bugs.python.org/issue34556#msg324433
A Python dev notes that it's common to invoke an upgrade when using the built-in venv
You could also use the virtualenv module to get an explicitly latest version
root@59616c014e15:/# pip install virtualenv
Collecting virtualenv
  Downloading https://files.pythonhosted.org/packages/4f/ba/6f9315180501d5ac3e707f19fcb1764c26cc6a9a31af05778f7c2383eadb/virtualenv-16.5.0-py2.py3-none-any.whl (2.0MB)
     |████████████████████████████████| 2.0MB 2.4MB/s
Installing collected packages: virtualenv
Successfully installed virtualenv-16.5.0

root@59616c014e15:/# virtualenv venv
Using base prefix '/usr/local'
New python executable in /venv/bin/python
Installing setuptools, pip, wheel...
done.

root@59616c014e15:/# /venv/bin/pip list
Package    Version
---------- -------
pip        19.1.1
setuptools 41.0.1
wheel      0.33.4

Version 16.5 is the one with the latest release versions
https://virtualenv.pypa.io/en/latest/changes/#id4

upgrade pip from 19.0.3 to 19.1.1 https://github.com/pypa/virtualenv/issues/1346
upgrade setuptools from 40.8.0 to 41.0.1 https://github.com/pypa/virtualenv/issues/1346

Came across this as well. Can also be reproduced with:
FROM python:3.7-slim-stretch

# 19.1.1
RUN pip --version

ENV VIRTUAL_ENV=/venv PATH="/venv/bin:$PATH"
RUN python -m venv /venv

# 19.0.3
RUN pip --version

This is really an upstream issue that is installing the version of pip bundled with Python. I had looked through the issues on https://bugs.python.org and didn't see anything relevant, so I'd recommend maybe making an issue about this upstream.


mise tasks: machine-readable (json) output

I know tasks are experimental and this is probably coming anyway but just to be sure:
I'd love mise tasks to be able to generate machine-readable output, like the json output of mise env (so other tools can pick up the listing and invoke tasks through mise)

there are probably several commands that would benefit from this, mise plugins is another one that came up today. This is really easy to implement if someone wants to learn a bit of rust, see https://github.com/jdx/mise/blob/main/src/cli/outdated.rs for a good example on --json output.


New entry for LaserDist mod I just released

I just released LaserDist on spacedock and github (soon to be Curse also once I finish submitting this PR for NETKAN).  This is the new netkan entry for it.

Could you make the homepage link go to your forum thread, instead? The github $kref will add a link to your repository automatically.
Also, I note you have an AVC .version file. You could use a $vref to automatically keep the KSP version information updated.
"$vref": "#/ckan/ksp-avc",

I've edited the PR with the requested changes. (but I really don't see the forum post as being the mod's home page.  To me the github page is more "homepage like" than the forum post.

When the NetKAN bot goes to your GitHub repo to get more metadata, it'll add a link to the repository (it goes in resources->repository). So users will see both a link to the forum page and the GitHub repo in CKAN.

It is worth noting that this way, users will see both links in the CKAN application.

Thanks for the update. This looks great. Merging now!


Release v1.13.4 and v1.12.5

説明 / Description
Release v1.13.4 and v1.12.5
チェックリスト / Checklist

MUST

[ ] npm test passed
[ ] npm run lint was applied without warnings
[ ] changes of /docs/webapp not included (except release branch)
[ ] console.log not included (except script file)

MUST (for Outside Contributor)

[ ] understand プロジェクトへの関わり方について

RECOMMENDED (it depends on what you change)

[ ] unit test added/updated
[ ] i18n

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 76.24%. Comparing base (ef475e6) to head (0c8b180).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #794   +/-   ##
=======================================
  Coverage   76.24%   76.24%
=======================================
  Files          88       88
  Lines       12290    12290
  Branches     1765     1765
=======================================
  Hits         9370     9370
  Misses       2898     2898
  Partials       22       22

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Shader error in Stylized Surface on fresh install

Just installed Flatkit URP and got a shader error, see attached photo.

Unity details:

Flat Kit version: 2.2.0
Unity version: 2020.2.2f1
Graphics Pipeline: URP
URP version (if applicable): ?
Development OS: Windows

Hi, could you please try doing the following:

Update to a more recent version of Unity. This will fix the bug with the Package Manager.
Check the version of Flat Kit. You told me it was 2.2.0 but the bug I mentioned above lies in the Package Manager not being able to download the latest versions of the assets, though it can display the latest version number. The only way to tell the version is to go Project tab -> Assets -> Flat Kit -> Readme, select it and you should see the version of Flat Kit, Unity, Universal RP. Making a screenshot would help. If you don't see the Readme file it means you've got too old version of Flat Kit. In this case you'll need to update it in the newer version of Unity first.
Install as described in the video / text below the video - here.


Help/advice with testing JTE library using openshift-client plugin

I'm trying to test a JTE library that is using the openshift-client plugin. (I have the dependency in my build.gradle already.)
My (cut down, minimal) template looks like this :
package aa;
void call(app_env) {
  stage("A and A") {
		def build_name_selector = openshift.selector( "bc", "foo" )
		if (build_name_selector.count() > 0)
		{
			echo "foo exists!"
			build_name_selector.delete()
			echo "foo deleted"
		}
	}
}

And one of my tests like this :
package aa;
class aaTest extends JTEPipelineSpecification {
    def aa = null
    def setup() {
        aa = loadPipelineScriptForTest("aa/aa.groovy")
    }
    def "testit" () {
        setup:
            def app_env = [:]
            def mockSelector = Mock(com.openshift.jenkins.plugins.OpenShiftDSL)
            getPipelineMock("openshift.selector")( _ )  >> mockSelector
            explicitlyMockPipelineStep('count')
            getPipelineMock("count")() >> 1
            explicitlyMockPipelineStep('delete')
        when:
            aa(app_env)
        then:
            2 * getPipelineMock("echo")(_)
            1 * getPipelineMock("delete")()
    }
 }

I have another test that sets count to 0 and expects 0 echoes and deletes. They both work as expected.
It has taken a lot of trial and error to get to that. But it feels wrong that I have mocked the entire count() function's result to 1. There must be a "better" way! The script under test could create a different selector later and expect a different result and I have no way of setting it.
NB It is not using the builtin groovy count() & delete()  functions, but versions from the openshift-client library.
IF my test is totally wrong, then please throw out whichever bits are wrong and suggest improvements!

Hi,
I think it is ok to stub the OpenShiftDSL because it is external dependency and usually we don't like to test other class.
As I experienced the Mock is a little buggy, you can use only one instance in one test.
I don't know the JTEPipelineSpecification so I created an example with original JenkinsSpock.
I used GroovyMock now, but I usually use GroovySpy too.
`package aa
import com.homeaway.devtools.jenkins.testing.JenkinsPipelineSpecification
import com.openshift.jenkins.plugins.OpenShiftDSL
class aaTest extends JenkinsPipelineSpecification {
def aa = null
def setup() {
aa = loadPipelineScriptForTest("vars/a.groovy")
}
def "testit"() {
setup:
def app_env = [:]
OpenShiftDSL mockSelector = GroovyMock(OpenShiftDSL) {
// Assertion comes here
1 * count() >> selectorCountResult
expectedDeleteCalls * delete()
}
getPipelineMock("openshift.selector")(_) >> mockSelector
when:
aa(app_env)

then:
expectedEchoCalls * getPipelineMock("echo")(_)

where:
selectorCountResult || expectedDeleteCalls | expectedEchoCalls
1                   || 1                   | 2
0                   || 0                   | 0

}
}`


Login form does not focus on username field

When you come to the login form, we should have javascript to focus on the username input.  I thought this was part of the default CAS.js.  With the custom work we did for the CSS in #10 , we may have disabled the default CAS.js.

In the latest deployment, this feature was lost


Proposal Change - Track history of proposer, limit first timers

Spec

The first time a user creates a proposal, they cannot ask for more than 50,000
If their project requires more funding, we will ask them to make a second proposal after their first one has passed and is in review.

Implementation

keep track of people's ask and success history
For people with non-positive track record, max is 50,000

Still missing:

[ ] Unit test
[ ] Change value to 250k?
[ ] Implementation: A failed proposal "resets" a user's score. We add up successes and failures - maybe not needed.
[ ] Add ability to blacklist?

Implemented here https://github.com/JoinSEEDS/seeds-smart-contracts/pull/133


Enable word wrap for display of long phenotype values

Added CSS for "word-break: break-all" on ".search-value"

This code was merged with branch ALS-500


NEXT-00000 - Fix for thumbnail generation

1. Why is this change necessary?
This Commit is an addition to this PR #3253. In the current state there are Edge Cases in which one side of the generated thumbnail can be larger than configured. To address this Issue the new Implementation checks for that and recalculates the factor.
2. What does this change do, exactly?

 The new factor Calculation addresses this and recalculates the factor.
Let's take a look at the second to last row as an example. The old calculation would generate a Thumbnail sized 667x800px. The Thumbnail configuration only allows a thumbnail to be 600x800px. The factor is calculated again and the final dimension of the thumbnail is 600x720px.
3. Describe each step to reproduce the issue or behaviour.
Upload an Image with unequal dimensions and an active Thumbnail configuration like 1000x1000px.
4. Checklist

[x] I have rebased my changes to remove merge conflicts
[x] I have written tests and verified that they fail without my change
[x] I have created a changelog file with all necessary information about my changes
[ ] I have written or adjusted the documentation according to my changes
[x] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

Hi @keulinho,
I've refactored the calculation into a new class and added the unit tests.
Kind regards
Kevin

The codestyle is failing, after you made your changes you should run composer ecs-fix so that the codestyle will be fixed automatically

The codestyle is failing, after you made your changes you should run composer ecs-fix so that the codestyle will be fixed automatically

Should be all done now.

Thank you for your contribution 🚀 💙


Compiler crash by looping through unicode

Description
So, as one does, I wanted to test out the limits of this https://github.com/typst/typst/commit/b805c5f10080912cbfb1fd2fd2733c48a92ce4f9
Turns out it's very easy to make the compiler crash
For instance
#{
    for i in range(1518){
        str.from-unicode(i)
        sym.zws
    }
}

will crash (1517 does not) with the error
thread 'main' panicked at 'byte index<PHONE_NUMBER>3709551613 is out of bounds of `ְֱֲֳִֵֶַָֹֺֻּֽ֖֛֢֣֤֥֦֧֪֚֭֮֗֘֙֜֝֞֟֠֡֨֩֫֬֯־ֿ׀ׁׂ׃ׅׄ׆ׇ׈`[...]', library\src\text\shaping.rs:285:23

Note that it's not simply \u{5ed} (5ed_16=1517_10) that is problematic, as
#{
    for i in range(1518){
        box(str.from-unicode(i))
    }
}

works just fine.
Another fun error is from
#{
    for i in range(6981){
        box(str.from-unicode(i))
    }
}

which results in
thread 'main' panicked at 'index out of bounds: the len is 1 but the index is 2', C:\Users\redacted\.cargo\registry\src\github.com-1ecc6299db9ec823\rustybuzz-0.7.0\src\complex\universal_machine.rs:370:47

(6980 will not)
This last error even occurs if I call \u{1b44} (which is a valid unicode character https://www.compart.com/en/unicode/U+1B44 )
Now, I realize that some of these errors likely stem from invalid symbols or invalid combinations of symbols (the "breakpoint" in the first example above can change depending on where the range starts), but I'd hope to see a slightly more graceful error message.
Reproduction URL
No response
Operating system
No response
Typst version

[X] I am using the latest version of Typst

This bug seems to be caused by one of the glyphs in a ShapedText having a range value whose start goes below the shaped text’s base value. In this case, this is the ZWS at byte index 7074, right before the instance of U+05A1. This, in turn, probably arises because ShapedText::find_safe_to_break (used by ShapedText::reshape) assumes that the .range.start value of the glyphs are monotonic, while certain shaped texts do not fulfill this condition. Here’s a smaller working example:
#"\u{590}\u{200b}\u{591}\u{200b}\u{592}\u{200b}\u{593}\u{200b}\u{594}\u{200b}\u{595}\u{200b}\u{596}\u{200b}"

@bluebear94 can this be closed?

I think so.


im/monitor_ds.sh skip broken symlinks

Most probably my test setup is too weird but if you have
/var/lib/one/datastores shared on all hosts and want to have
SYSTEM datastore with TM_MAD on one of the hosts, I am doing the following:
mkdir -p /var/lib/one-local/102
ln -s /var/lib/one-local/102 /var/lib/one/datastores/102

This way I have "local" datastore nested in "shared" filesystem.
In the above scenario on all other hosts the symlink is dead.
The proposed patch test the is the $dir directory and continue only if it is indeed directory.

Thanks!


How can I notify .gov domain owners of problems with their SPF/DMARC records?

I spent the last month or so writing my own parsers for SPF and DMARC, and I just learned this project exists! D'oh! My code is not as clean as yours, but it is more strict about how it validates SPF and DMARC records. I'll contribute some code for issue #33 soon 😄
https://domainaware.github.io/checkdmarc/
Anyway, I tested my script against a list of high-profile (risk of fraud or political activism) departments/agencies, I ran those separately, and I found that a few of the domains have errors in their SPF and/or DMARC records (if they have them at all):

cbo.gov

MX record error: mxb-001ec201.gslb.pphosted.com does not have any A or AAAA records
Parsing the SPF record requires more than the 10 maximum DNS queries https://tools.ietf.org/html/rfc7208#section-4.6.4

cia.gov:

Unnecessary SPF mechanisms mx:cia.gov mx:ucia.gov

dhs.gov

hq.dhs.gov does not indicate that it accepts DMARC reports about dhs.gov - https://tools.ietf.org/html/rfc7489#section-7.1

epa.gov

MX record error: grid1f6.gseg.att.com does not have any A or AAAA records;grid126.gseg.att.com does not have any A or AAAA records

gsa.gov

Parsing the SPF record requires more than the 10 maximum DNS queries https://tools.ietf.org/html/rfc7208#section-4.6.4

fema.gov

fema.dhs.gov does not indicate that it accepts DMARC reports about fema.gov - https://tools.ietf.org/html/rfc7489#section-7.1

hhs.gov

SPF warning: The ptr mechanism should not be used - https://tools.ietf.org/html/rfc7208#section-5.5

interior.gov

interior-gov.mail.protection.outlook.com does not have any A or AAAA records

The Department of the Interior uses doi,gov for email, which has Google MX records. They should change interior.gov to match (so email aliases work), or remove this MX record

irs.gov

SPF include qai.irs.gov does not resolve (SERVFAIL)
ofdp.irs.gov does not indicate that it accepts DMARC reports about irs.gov - https://tools.ietf.org/html/rfc7489#section-7.1

opm.gov

Parsing the SPF record requires more than the 10 maximum DNS queries https://tools.ietf.org
-Note: Their SPF record is literally monstrous - not good for OPSEC or the SPF standard
/html/rfc7208#section-4.6.4

nasa.gov

mail.nasa.gov does not indicate that it accepts DMARC reports about nasa.gov - https://tools.ietf.org/html/rfc7489#section-7.1

ofdp.irs.gov

DMARC error: Tag fo must have one of the following values: 0,1,d,s - not 0:1:d:s

sec.gov

<EMAIL_ADDRESS>is not a valid DMARC report URI

uscg.mil

Has a SPF record where a DMARC record should be

@seanthegeek 👋 hi there! Nice work on your tool, and excellent documentation! We would welcome your contributions, especially regarding #33.
Similar to the process described in this blog post, where we deliver HTTPS results to agencies, we also deliver a Trustworthy Email Report regularly to (federal civilian executive branch [so no CIA]) agencies that contains this very information-- minus #33 info, which is a real need. To wit: just this AM I reached out manually to the DHS team notifying them that they won't receive reports from non-hq.dhs.gov domains!
I'm going to close this issue, since it's already happening (by and large). Hope to see you in some pull requests. 👍


⚠ Bofrost.be has degraded performance

In 7b45f47, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 914 ms

Resolved: Bofrost.be performance has improved in 3a013b6 after 6 minutes.


Add size field to the histogram json representation

Having the size field included in the json is interesting for some use cases. Not sure if it would be interesting for Timers. Thanks for your comments.

Size isn't reported by other reporters, and I haven't seen any other requests for this functionality, so I'm afraid I'm unable to merge it.


TechDocs Fail when using url with no error message

Expected Behavior
TechDocs would be displayed.
Current Behavior
Backstage fails to render the latest version of the docks but there are no error messages to be found in the logs:

Build logs shows only:
1info: Step 1 of 3: Preparing docs for entity component:default/surge {"timestamp":"2022-01-04T17:06:03.843Z"}
Steps to Reproduce
The only thing I can think of that is different here is I'm using a url reference to the docs, which it found once successfully and built the docs. I since have updated the latest versions of packages using yarn backstage-cli versions:bump and that's when it seemed to quit working. I have URL set to a specific folder within a large mono-repo like:
annotations:
  backstage.io/techdocs-ref: url:https://mygitlabinstance/mygroup/myproject/-/tree/cat-poc/Subfolder/MyApp/

and inside of there I have the following structure:

mkdocs.yml
docs/

index.md

My mkdocs looks like:
site_name: 'myapp-docs'

nav:
  - Home: index.md

plugins:
  - techdocs-core

my techdocs app-config:
techdocs:
  builder: 'local' # Alternatives - 'external'
  generator:
    runIn: 'docker' # Alternatives - 'local'
  publisher:
    type: 'local' # Alternatives - 'googleGcs' or 'awsS3'. Read documentation for using alternatives.

Context
Can't get the tech-docs to display for the particular component successfully.
 When I go to the the docs and click the "edit this page" icon that opens gitlab I'm not taken to the directory that I have configured that contains the mkdocs.yml but instead one folder up.
For example I have configured:
https://mygitlabinstance/mygroup/myproject/-/tree/cat-poc/Subfolder/MyApp/
where "Subfolder/MyApp" contains the catalog-info.yaml and mkdoc.yml files along with the docs folder. But when I click the "edit this page" link I'm taken to the root of the repo (https://mygitlabinstance/mygroup/myproject/-/tree/cat-poc/) and given an error message that "Subfolder/docs/index.md" did not exist on "cat-poc". Notice that the error indicates it's looking in the wrong folder for the docs folder. It exists within the MyApp folder which is where the catalog-info.yaml and mkdoc.yml reside.
Not sure if this is helpful but something I noticed.

Oddly this started working again today without any changes. It seemed like something was being cached somewhere. I am not using persistent storage and have restarted the application several times. After a restart an older version of the docs were showing up immediately after re-adding the entity, then the build would fail. Today it started working though with no changes to the application.


How to make paging in last child list

I have 3 level of views Parent, Child, Child's of child, How to implement paging in last child list ?!

Pardon? What do you mean ?

@TellH  I want to implement pagination in my child list to show new items when scroll to end of items exist in RecyclerView.
I mean Endless Scrolling with AdapterViews and RecyclerView.


Order on the advance search filters

Select Creator
Select Part Type (i.e., SBOL Type)
Select Part Role (i.e., Role Type)
Select Object Type
Collections

closed by commit fadaab2906b9d7905216af85983eec6ee248eeec


Screen sharing support.

Discord works ok on rpi 4b 8GB but I am unable to share screen.
Could somebody help me with this issue? Since I just started using discord, it is probably something on the app settings I have to change...

Seems that Electron API does not have any GUI for the screen recording... I need to make a new one, which is quite complex for me right now...
Maybe there's any NPM library for doing that? If so, just answer me there because it will speed up my work a lot...
Right now I'll flag this as new feature.

Also see this issue.

I was able to run this in proot in my aarch64 Android

As the screenshot, it's working very smoothly. But still same issue of screen sharing, maybe aarch64 problem.

I was able to run this in proot in my aarch64 Android

As the screenshot, it's working very smoothly. But still same issue of screen sharing, maybe aarch64 problem.

Implemented in 4409e55.


Cannot run Google Map in iOS

Hi, I cannot make it working on iOS.
I did cd platforms/ios && pod install
I see grey map with Google logo on it. Keys are OK.
In log I see the following messages:
2019-03-11 18:22:10.028331+0100 Elis[1273:466060] ERROR: Plugin 'map_0_74670188322' not found, or is not a CDVPlugin. Check your plugin mapping in config.xml.
2019-03-11 18:22:10.028458+0100 Elis[1273:466060] -[CDVCommandQueue executePending] [Line 142] FAILED pluginJSON = ["INVALID","map_0_74670188322","detachFromWebView",[]]
2019-03-11 18:22:10.204654+0100 Elis[1273:466060] ERROR: Plugin 'map_0_74670188322' not found, or is not a CDVPlugin. Check your plugin mapping in config.xml.
2019-03-11 18:22:10.204789+0100 Elis[1273:466060] -[CDVCommandQueue executePending] [Line 142] FAILED pluginJSON = ["INVALID","map_0_74670188322","attachToWebView",[]]
CoreData: annotation:  Failed to load optimized model at path '/var/containers/Bundle/Application/77AFC220-9D79-42EF-89ED-5D2F50A456F6/Elis.app/GoogleMaps.bundle/GMSCacheStorage.momd/StorageWithTileProto.omo'
CoreData: annotation:  Failed to load optimized model at path '/var/containers/Bundle/Application/77AFC220-9D79-42EF-89ED-5D2F50A456F6/Elis.app/GoogleMaps.bundle/GMSCacheStorage.momd/StorageWithTileProto.omo'
CoreData: annotation:  Failed to load optimized model at path '/var/containers/Bundle/Application/77AFC220-9D79-42EF-89ED-5D2F50A456F6/Elis.app/GoogleMaps.bundle/GMSCacheStorage.momd/StorageWithTileProto.omo'

Any idea?

Please share your project files on github repository.

@wf9a5m75 Would you like to see just Xcode files?

No. You need to share your project files everything on to github repository, src (if ionic), www, res, config.xml, package.json.
Otherwise, please debug by yourself.

@wf9a5m75 So, I figured out that cordova-plugin-googlemaps doesn't work well with React. More about this problem here #2487.
It the problem exists, please consider to include such information to README. It could save somebody's time in the future.

If you share your project files on GitHub repository, I answered this plugin does not work with React.js so far.

If you share your project files on GitHub repository, I answered this plugin does not work with React.js so far.

@wf9a5m75 It works fine with React for me so far. If there are known issues with React, please let me know so I will check it for you.

@wf9a5m75 So, now it works with React for me. It was my lack of experience with pod software and API keys proper configurations.
Please tell me what is the problem with react, so I can test it for you.

Congrats. I don't know the reason of the problem with React.js. Because I don't have experienced React.js well, and nobody share the project with me.
Please check https://github.com/mapsplugin/cordova-plugin-googlemaps/issues/2487 for the details of previous inspection.


InteractionChecks.cs uses EditorApplication API which is unsupported on Unity 5.6

Unity changed the capitalisation in playmodeStateChanged to playModeStateChanged after 5.6
The script also uses the PlayModeStateChange enum which wasn't there in 5.6
Only writing this, since on the LM site for the Unity assets it says 5.6 is still supported.
P.S.: Nice work on the new version by the way :)

Fixed in develop now! Future release packages will support 5.6 as advertised. We may hotfix a release to support 5.6 depending on how many 5.6ers we find.
The fixes are in these two commits:
https://github.com/leapmotion/UnityModules/commit/ab1210e3f4e708fdf066b5edac88c0c6407c6d6a
^fixes 5.6 support
https://github.com/leapmotion/UnityModules/commit/9248dc014c662cd28fb28403e6b2410e34c07c81