Problem about esp-lcd flags.swap_color_bytes causing extra line (IDFGH-7904)

My Env:

idf version : v4.4-263-g000d3823bb-dirty, it should be a clone of release/v4.4 branch
module : esp32s3-wroom-1u
screen : RM68120, 8bit parallel mode, 10M speed.

Problem:
As a 8 bit parallel screen, I should swap the color bit. However, when I use .flags.swap_color_bytes = 1 to swap it, it may cause some extra lines on the screen. Using Swap the 2 bytes of RGB565 color in menuconfig > Component config > LVGL configuration > Color settings don't cause these lines .
Init codes:
    ESP_LOGI(TAG, "Initialize LCD Intel 8080 bus");
    esp_lcd_i80_bus_handle_t i80_bus = NULL;
    esp_lcd_i80_bus_config_t bus_config = {
            .dc_gpio_num = LCD_RS_Pin,
            .wr_gpio_num = LCD_WR_Pin,
            .data_gpio_nums = {
                    LCD_D0_Pin,
                    LCD_D1_Pin,
                    LCD_D2_Pin,
                    LCD_D3_Pin,
                    LCD_D4_Pin,
                    LCD_D5_Pin,
                    LCD_D6_Pin,
                    LCD_D7_Pin,
            },
            .bus_width = 8,
            .max_transfer_bytes = LCD_WIDTH * 40 * sizeof(uint16_t)    //最大32640 *2, 受DMA限制
    };
    ESP_ERROR_CHECK(esp_lcd_new_i80_bus(&bus_config, &i80_bus));

    esp_lcd_panel_io_handle_t io_handle = NULL;
    esp_lcd_panel_io_i80_config_t io_config = {
            .cs_gpio_num = LCD_CS_Pin,
            .pclk_hz = 10 * 1000 * 1000, // 测试14MHz以上花屏 10MHZ=26.18fps   13MHZ=34.04fps
            .trans_queue_depth = 10,
            .dc_levels = {
                    .dc_idle_level = 1,
                    .dc_cmd_level = 0,
                    .dc_dummy_level = 1,
                    .dc_data_level = 1,
            },
            // .on_color_trans_done = example_notify_lvgl_flush_ready,  //Callback invoked when color data transfer has finished
            // .user_ctx = &disp_drv,                                   //User private data, passed directly to on_color_trans_done’s user_ctx
            .lcd_cmd_bits = 16,
            .lcd_param_bits = 16,
//            .flags.swap_color_bytes = 1,
    };
    ESP_ERROR_CHECK(esp_lcd_new_panel_io_i80(i80_bus, &io_config, &io_handle));

driver codes can be found in W00ng's repo， I just modify the bud width ,io ,and port on lvgl.
using init to swap

using LVGL to swap

I don't have an RM68120 LCD around, but I do have an NT35510, I suppose they two share the same basic register layout. I tried the example here, with or without enabling the LV_COLOR_16_SWAP, and I got the same result, didn't see the strange afterimage,
Could you reproduce the issue with the same example? (you can try the master branch for now, to make sure this is not an issue leftover in the release/v4.4 branch only).

It seems not to happen with esp-idf v5.0....

Actually, this commit already solved my problem... release version also have a commit solved this. My idf version is a little bit outdated.
Thanks.

Newest release/v4.4 branch also don't have this problem...Sorry for my outdated idf causing this.
Thanks


fix: bump markdown version to fix crash on reload

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/42160
PROPOSAL:
Tests

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native
https://github.com/Expensify/App/assets/32481228/5a1e8f61-b81f-46ea-952c-b8a1edfd28e3

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

Since https://github.com/Expensify/App/pull/42377 is not yet merged, I would merge it as patch for now if we want it merged ASAP. If no, I can change this PR to bumping to 0.1.74 which has my commit: https://github.com/Expensify/react-native-live-markdown/pull/349. Wdyt @mountiny ?

@WoLewicki I believe there was a new release created. Can you please update the pr?

Ok so we want this PR to bump the markdown to the newest version? But then the reviewer would have to test if none of the recently released versions of markdown bring any new issues.

Yes, that sounds good
@mananjadhav could you list the changes in the markdown between the current version the one we are going to use here? Thanks!

I was away Thu-Friday, I'll take a look at this tomorrow.

@WoLewicki Did you say your changes are in 0.1.74? @mountiny I can see we're already using 0.1.76 in the latest main (merged in this PR).

@mananjadhav can you test if this is fixed on main then?

@mountiny Sorry should've mentioned tested in one of the PR branches I worked. Anyway uploaded the video for main.
https://github.com/Expensify/App/assets/3069065/7f32a7e4-147b-4b04-9552-df5e3cc019d2


Repeatable Events

Hello Werner,
Thanks for your awesome work with this package!
If possible, could you please implement a functionality to repeat an event?
I'm currently implementing a calendar view into an app for my university (University of Applied Sciences Munich).
Since the lectures repeat every week, it would be great to display them in the calendar without the need to split the event into multiple.
Thanks in advance,
Moritz

Hi, that is unfortunately not something that I will be implementing anytime soon, so for now you would need to create multiple CalendarEvent entries if you want repeating events. You should be able to leverage the Custom Object passed into CalendarEvent to reschedule the repeating events.

Fine. I think I'll have to split the events then 🙂.
Thanks for the awesome work on the package!


Disregard targets that are too far into the future

This PR stops raising a ValidationError on too-far-into-the-future targets, and disregards them instead.
The two options for me here are, either:

we allow too-far-into-the-future targets, but disregard them. We follow up (new ticket) by using the 'Warning' HTTP header, and add documentation that API users should monitor these (if they aren't already), or
we grandfather too-far-into-the-future targets for now, and will raise in the future. We follow up (new ticket) by using deprecation and sunset headers, and disallow such targets in the future.

With either option, this PR would be the first step imo.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

1 of 5 (20.0%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.02%) to 65.631%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

flexmeasures/data/schemas/scheduling/storage.py
1
2
50.0%

flexmeasures/data/services/scheduling.py
0
1
0.0%

flexmeasures/data/models/planning/storage.py
0
2
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.02%

Covered Lines:
6867

Relevant Lines:
9835

💛  - Coveralls

Amends #568.


Make remember_scroll_position_test.dart pass

We've decided not to store the scroll position in PageStorage because
routes now maintainState by default.

Fixes #8051

@Hixie @HansMuller

Fixes #8051

Wait, why?

Wait, why?

Scrollable1 does this.  There's a test that fails when converted to the new world if we don't match the old world's behavior.

If you're on route A, scroll to some offset, then go to route B, then go back, you'll return to the same scroll offset you had before.

If you're on route A, scroll to some offset, then go to route B, then go back, you'll return to the same scroll offset you had before.

This already works, because ModalPageRoute sets maintainState to true by default, so the state is never lost. Try it on trunk in the gallery, say. It won't lose scroll position when switching pages.

So, this test fails without this patch.  Would you like me to delete this test or change Scrollable2 to match Scrollable1 and make the test pass?

Does it only fail in the case where you pass false to the maintainState boolean? If so, I would just remove that line at the bottom, and leave the rest as-is, to verify that we do maintain this particular state. I don't think we need to support maintaining state when maintainState is false, at least not until we have requests for that feature.

Does it only fail in the case where you pass false to the maintainState boolean?

Yes.

If so, I would just remove that line at the bottom, and leave the rest as-is, to verify that we do maintain this particular state. I don't think we need to support maintaining state when maintainState is false, at least not until we have requests for that feature.

SGTM

(I suspect we will revisit this when we deal with "how do I maintain state across app restarts", which will probably be in the M4 timeframe.

Done.  PTAL.

how do I maintain state across app restarts

Yes, but we'll need to re-think a bunch of assumptions to make sure we can persistent the information to disk.

Yes, but we'll need to re-think a bunch of assumptions to make sure we can persistent the information to disk.

Yeah.

Github had a strange approach to doing the diff on that test.


Buttons in nested containers

it might be me, but it looks like Tink doesn't adjust for buttons in nested containers with different scales/positions/pivots.
I have a play button within a scaled container that is itself a child of the stage. The hit detection looks like it's using the scale and position of the stage instead of the nested container.

I had a same issue with scalled button it looks like the sprite.gx and sprite.gy are not working with scaling
in the line 337 in the hitTestSprite function so i changed it to x and y and my button hitbox was fixed
hope it will help


Clean up debug and standard-page-controller

@gauntface
Since we most likely won't have this on DevSite, either remove, or document in the ReadMe so folks know what it is and what they can use it for.

This was a nice to have / useful for testing - easier to remove.


ci: fix docker build error

Which issue(s) this PR fixes:
Original CI error: https://github.com/longhorn/longhorn-tests/actions/runs/9315512758/job/25641815189
This PR CI result: https://github.com/longhorn/longhorn-tests/actions/runs/9396482830/job/25877751459?pr=1932
What this PR does / why we need it:
Special notes for your reviewer:
Additional documentation or context

After upgrading Docker from 24.07 to 26.1.4, I was able to build the private image without this PR. I'm not sure if we need to submit that.

Thanks @roger-ryao for validation. We need this PR to fix CI error. If you are okay with it, may you approve it? Thanks.


make icon adjust to current theme

https://hacks.mozilla.org/2017/12/using-the-new-theming-api-in-firefox/
related to #5 but more specific

yeah please!


Time column too narrow on some devices

Could not be reproduced.

Reappeared on Galaxy S5

8760102279e5cfee6868b35ac74dafd3d9d23b51 and #26 fix this.


Update serverproperty-transact-sql.md

Synapse on-demand pool returns 11, not 6 like Synapse provisioned pool returns.

@pwehland : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Thanks @pwehland!
@julieMSFT - Hey Julie, can you please take a look? Thanks!

#sign-off

#sign-off

@julieMSFT: I'm sorry - only the author of this article, @VanMSFT, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.

@julieMSFT: I'm sorry - only the author of this article, @VanMSFT, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.

#sign-off

#sign-off


add MyGet feed details to readme

I am not sure about the wording but this seems like a useful information to have on readme.

thanks. This is a great small addition.


Do not merge: replacing deprecated Limits calls

Replacing calls to Limits.getFutureCalls() and Limits.getLimitFutureCalls() with Limits.getAsyncCalls() and Limits.getLimitAsyncCalls() respectively.

@dospromptman this is passing build, should be good to merge now.


v2.1.0 displays error message "error: invalid key: pr-release.ssl_no_verify"

❯ git-pr-release -n
error: invalid key: pr-release.ssl_no_verify
WARNING: `Faraday::Connection#authorization` is deprecated; it will be removed in version 2.0.
While initializing your connection, use `#request(:authorization, ...)` instead.
See https://lostisland.github.io/faraday/middleware/authentication for more usage info.
(ry

#77 might have bug. I'll fix.

git config does not allow camelcase in variable names:

The variable names are case-insensitive, allow only alphanumeric characters and -, and must start with an alphabetic character.
https://git-scm.com/docs/git-config#_configuration_file


Add topmost pick to picksource

Simplify getting topmost pick by moving this to the pick source. This is more ECS-idiomatic, and will remove the need for "global" state in the plugin's top level. This might require restructuring how groups work.
The most sensible way to do this would store this information in a group, as this can only have one intersection. A pick source, however, can belong to multiple groups and have multiple intersections associated with it. Right now, though, groups don't exist as entities and have no way to store data.
Alternatively, maybe a new constraint could be added, where a Pick Source can only be used in a single group? What use cases does this prevent? Using the mouse as a single source and finding the top pick for multiple groups?

Completed in bevy_mod_raycast
Can access with RayCastSource::intersect_top()

Completed in bevy_mod_raycast
Can access with RayCastSource::intersect_top()


53 feather file conversion support

Fixes #53
Adds support for the feather file support, although conversion to compressed feather does not work because this is not supported by pyarrow.dataset. In addition, there is no API to find the compression used in an existing file (like for parquet), so we rely on the user to set this property in the metadata.
This PR also adds a parametrized test for converting between the 3 supported formats, with randomly generated data of a schema that includes all types that are supported by all 3 formats.

Created JIRA about the absence of compression support in pyarrow.dataset.ipc: https://issues.apache.org/jira/browse/ARROW-17991

At first, I figured we'd just use the normal ipc writer for now, but now you mention the nightlies, I think that might be a better idea. Because there could be more stuff we need that we add to Arrow ourselves.

Would you mind setting up the dependency setup to pull a nightly for arrow in this PR + take out the stops that prevent compression from being used?

Done. also merged #109 into this, so will close it.

Now, pyarrow nightlies are installed for the test-wheel step. But for pipx, I had to add the flags (most notably --pre) needed to install pyarrow nightlies to the pipx command to install datalogistik, because otherwise a separate environment would be created. But I guess that means that for the other dependencies it might also install non-stable packages.


Slow inference speed on RTX 3090.

What is the issue?
I am getting only about 60t/s compared to 85t/s in llama.cpp when running llama3-8B-q8_0. When I run ollama on RTX 4080 super, I get the same performance as in llama.cpp. I tried running both natively and in docker, results were the same.
That leads me to believe that something is not right, or is that expected behaviour? Thanks
OS
Linux
GPU
Nvidia
CPU
Intel
Ollama version
0.1.48

What cuda version do you have installed?
What flags did you use to compile llama.cpp, and do they differ from our settings?

https://github.com/ollama/ollama/blob/main/llm/generate/gen_common.sh#L43
https://github.com/ollama/ollama/blob/main/llm/generate/gen_linux.sh#L160-L185

In general we're trying to balance broad hardware support for older and newer GPUs.  We're looking at adding 2 distinct cuda runners (adding a v12 runner in addition to our existing v11 runner) which will allow us to tune the v12 runner to optimize for newer GPUs without dropping support for older GPUs with the v11 runner.

I am using cuda 12.5. I did default cuda llama.cpp compile, I did not set any extra flags.
I tried the v12 runner branch, but the performance did not improve.
After some further testing, it seems that the issue is maybe not related to the gpu. When some model is running, one cpu thread is running constantly at 100% (both in ollama and llama.cpp). With 3090, I am using xeon e5 2699 v3, which does not have great single core performance.  With 4080 (where I did not see performance degradation), I was using ryzen 5 5600x. So maybe there is larger cpu overhead in ollama?
I ended up running full fp16 version, where I found that the performance is closer to llama.cpp - I get around 42.5t/s in ollama and 49.5t/s in llama.cpp.

@Saniel0 from your last comment, it sounds like the original comparison wasn't "apples to apples" on otherwise identical hardware.  Yes, the CPU is involved in coordinating and processing results as they're generated by the GPU.
It sounds like we can close this issue.  If there's still a performance concern, please elaborate and I'll reopen.


Error Loading Package @io_bazel_rules_docker when building Tensorflow

Please make sure that this is a build/installation issue. As per our GitHub Policy, we only address code/doc bugs, performance issues, feature requests and build/installation issues on GitHub. tag:build_template
System information

OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Windows 10
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device: N/A
TensorFlow installed from (source or binary): Source
TensorFlow version: 1.12.2 / master branch
Python version: Python 3.6.8 :: Anaconda, Inc.
Installed using virtualenv? pip? conda?: Conda
Bazel version (if compiling from source): 0.25.2
GCC/Compiler version (if compiling from source): gcc version 8.2.0 (Rev3, Built by MSYS2 project)
CUDA/cuDNN version: Cuda v10.1 - cudnn-9.2-windows10-x64-v<IP_ADDRESS>
GPU model and memory: NVidia 1060

Describe the problem
Build failing when running bazel build --config=opt //tools/pip_package:build_pip_package
with error:
ERROR: error loading package '': Encountered error while reading extension file 'repositories/repositories.bzl': no such package '@io_bazel_rules_docker//repositories'

Provide the exact sequence of commands / steps that you executed before running into the problem
I followed the tutorial here<EMAIL_ADDRESS>> python configure.py
Python Location (default): C:\Users\Arise\Miniconda3\envs\tensorflow-v1.10\python.exe
Python Libraries Path (default): C:\Users\Arise\Miniconda3\envs\tensorflow-v1.10\lib\site-packages
XLA JIT support: No
ROCm support: No
CUDA support: Yes
CUDA compute capabilities (default): 3.5,7.0
Optimization Flags Bazel (default): --config=opt
Override Eigen Strong Inline (default): Yes

Any other info / logs
Include any logs or source code that would be helpful to diagnose the problem. If including tracebacks, please include the full traceback. Large logs and files should be attached.
(tensorflow-v1.10) C:\Users\Arise\tensorflow-build\tensorflow>bazel build
Starting local Bazel server and connecting to it...
WARNING: Usage: bazel build <options> <targets>.
Invoke `bazel help build` for full description of usage and options.
Your request is correct, but requested an empty set of targets. Nothing will be built.
INFO: An error occurred during the fetch of repository 'io_bazel_rules_docker'
INFO: Call stack for the definition of repository 'io_bazel_rules_docker':
 - C:/users/arise/_bazel_arise/ji3ak47x/external/bazel_toolchains/repositories/repositories.bzl:37:9
 - C:/users/arise/tensorflow-build/tensorflow/WORKSPACE:29:1
ERROR: error loading package '': Encountered error while reading extension file 'repositories/repositories.bzl': no such package '@io_bazel_rules_docker//repositories': Traceback (most recent call last):
        File "C:/users/arise/_bazel_arise/ji3ak47x/external/bazel_tools/tools/build_defs/repo/git.bzl", line 234
                _clone_or_update(ctx)
        File "C:/users/arise/_bazel_arise/ji3ak47x/external/bazel_tools/tools/build_defs/repo/git.bzl", line 74, in _clone_or_update
                fail(("error cloning %s:\n%s" % (ctx....)))
error cloning io_bazel_rules_docker:
+ cd C:/users/arise/_bazel_arise/ji3ak47x/external
+ rm -rf C:/users/arise/_bazel_arise/ji3ak47x/external/io_bazel_rules_docker C:/users/arise/_bazel_arise/ji3ak47x/external/io_bazel_rules_docker
/usr/bin/bash: line 5: rm: command not found
ERROR: error loading package '': Encountered error while reading extension file 'repositories/repositories.bzl': no such package '@io_bazel_rules_docker//repositories': Traceback (most recent call last):
        File "C:/users/arise/_bazel_arise/ji3ak47x/external/bazel_tools/tools/build_defs/repo/git.bzl", line 234
                _clone_or_update(ctx)
        File "C:/users/arise/_bazel_arise/ji3ak47x/external/bazel_tools/tools/build_defs/repo/git.bzl", line 74, in _clone_or_update
                fail(("error cloning %s:\n%s" % (ctx....)))
error cloning io_bazel_rules_docker:
+ cd C:/users/arise/_bazel_arise/ji3ak47x/external
+ rm -rf C:/users/arise/_bazel_arise/ji3ak47x/external/io_bazel_rules_docker C:/users/arise/_bazel_arise/ji3ak47x/external/io_bazel_rules_docker
/usr/bin/bash: line 5: rm: command not found
INFO: Elapsed time: 2.642s
INFO: 0 processes.
FAILED: Build did NOT complete successfully (0 packages loaded)

I managed to fix this by adding the following to the top of my WORKSPACE file:
http_archive(
    name = "io_bazel_rules_docker",
    sha256 = "aed1c249d4ec8f703edddf35cbe9dfaca0b5f5ea6e4cd9e83e99f3b0d1136c3d",
    strip_prefix = "rules_docker-0.7.0",
    urls = ["https://github.com/bazelbuild/rules_docker/archive/v0.7.0.tar.gz"],
)

If you do the same, you probably want to ensure you get the latest version here https://github.com/bazelbuild/rules_docker and copy the code snippet from the README instead of from here.

Same failure, can someone help?
ERROR: error loading package '': Encountered error while reading extension file 'repositories/repositories.bzl': no such package '@io_bazel_rules_docker//repositories': Traceback (most recent call last):
File "C:/users/vcntwtt/_bazel_vcntwtt/cd6duifl/external/bazel_tools/tools/build_defs/repo/git.bzl", line 234
_clone_or_update(ctx)
File "C:/users/vcntwtt/_bazel_vcntwtt/cd6duifl/external/bazel_tools/tools/build_defs/repo/git.bzl", line 74, in _clone_or_update
fail(("error cloning %s:\n%s" % (ctx....)))
error cloning io_bazel_rules_docker:
java.io.IOException: ERROR: src/main/native/windows/processes-jni.cc(456): CreateProcessW("bash" -c "
cd C:/users/vcntwtt/_bazel_vcntwtt/cd6duifl/external
set -ex
( cd C:/users/vcntwtt/_bazel_vcntwtt/cd6duifl/external &&
if ! ( cd 'C:/users/vcntwtt/_bazel_vcntwtt/cd6duifl/external(...)): The system cannot find the file specified.

@QuellaZhang Did you read my comment above? Did it not work?

@Acidic9 : Looks like you were able to resolve this issue. Let us know. Thanks!

Closing the issue since it is resolved. Thanks!

@Acidic9 Thanks for the patch, I can build successfully with the patch.
But the final reason I found it is that the Python library installation is not complete, I reinstall the Python64 and  follow the build steps, then I can successfully build the latest Tensorflow source code without any patch.
In addition, I found that if we did not execute "pacman -S git patch unzip" after installing msys32, it will report similar errors.

I got into the very same issue when I tried to compile TensorFlow 2.0.0-beta1 from source with
Intel-MKL (CPU only) support.
I solved the issue by including the following directive on top of the WORKSPACE file:
# Download the rules_docker repository at release v0.8.1
http_archive(
    name = "io_bazel_rules_docker",
    sha256 = "87fc6a2b128147a0a3039a2fd0b53cc1f2ed5adb8716f50756544a572999ae9a",
    strip_prefix = "rules_docker-0.8.1",
    urls = ["https://github.com/bazelbuild/rules_docker/archive/v0.8.1.tar.gz"],
)

The directive has been taken from here: https://github.com/bazelbuild/rules_docker
HTH

I'm not very impressed with bazel so far, I am not even building a docker image. So I spent 4+ hours compiling, and it didn't even generate the wheel but it said it had completed. Now when I try to build the package again, I get this error. I think makefiles worked quite well, and I am just calling this bagel now.

Well I got it building (again, and again) but it is starting all over. The whole purpose of make is that it tracks the file time and date so you don't have to continously rebuild the same thing over and over.

I think tensorflow is very good and I am glad they have made it for everyone. But I have spent over a day with bazel going nowhere, and I am getting tired.

Well, that is black magic. I see it was waiting all that time for me to issue a command to construct the wheel. Pretty cool, like reading an old DSP books and thinking why the wheel looks like it goes backwards.

Well I did get it to compile on linux before, I forgot that you had to use the actual thing to launch the wheel into creation. The problem was I had moved a drive letter on windows and this broke bazel. Fixing the drive it worked fine. Just confused why that changed. It is important I can build tensorflow for the machine so the logic gates will set correctly to the computer system.

I managed to fix this by adding the following to the top of my WORKSPACE file:
http_archive(
    name = "io_bazel_rules_docker",
    sha256 = "aed1c249d4ec8f703edddf35cbe9dfaca0b5f5ea6e4cd9e83e99f3b0d1136c3d",
    strip_prefix = "rules_docker-0.7.0",
    urls = ["https://github.com/bazelbuild/rules_docker/archive/v0.7.0.tar.gz"],
)

If you do the same, you probably want to ensure you get the latest version here https://github.com/bazelbuild/rules_docker and copy the code snippet from the README instead of from here.

https://github.com/bazelbuild/rules_docker/blob/master/WORKSPACE

http_archive(
    name = "io_bazel_rules_docker",
    sha256 = "aed1c249d4ec8f703edddf35cbe9dfaca0b5f5ea6e4cd9e83e99f3b0d1136c3d",
    strip_prefix = "rules_docker-0.7.0",
    urls = ["https://github.com/bazelbuild/rules_docker/archive/v0.7.0.tar.gz"],
)

Successful!!. but not on the top of workspace file. put these lines after loading http_archive

Hi @Acidic9

http_archive(
    name = "io_bazel_rules_docker",
    sha256 = "aed1c249d4ec8f703edddf35cbe9dfaca0b5f5ea6e4cd9e83e99f3b0d1136c3d",
    strip_prefix = "rules_docker-0.7.0",
    urls = ["https://github.com/bazelbuild/rules_docker/archive/v0.7.0.tar.gz"],
)

to which WORKSPACE file did you added the code snippet above?The exact path would help me a lot. I'm sorry if it should be obvious.Thank you so much!

to which WORKSPACE file did you added the code snippet above?The exact path would help me a lot. I'm sorry if it should be obvious.Thank you so much!

@Tameli the WORKSPACE file is in the root of the project.

@Acidic9 Thank you!!


Reduce bundle Size

Describe the feature
Hi, this is not a feature request per-se, but I see that the size of this package is increasing steadily, is there something that can be done to reduce its size ?
Here is a quick recap for @swc/core-linux-x64-gnu:

Version
Size

1.2.50
22M

1.2.100
25M

1.2.110
25M

1.2.120
28M

1.2.130
36M

1.2.140
44M

1.2.150
60M

Is there a way to reduce the size of the package ?
Babel plugin or link to the feature description
No response
Additional context
No response

It's possible to reduce size if we give up performance, but the binary size is expected to increase as ts/js evolves.
It should handle more input, and should transform more syntax.
Also, removing a feature is a breaking change.

I reduced the binary size recently, although you may already know

I didn't check for each version individually, but I saw in the release notes
I get that it's bound to increase as features are added ( features for which I am very grateful by the way :) )


Tables are not formatted

Hi!
I just found this plugin, and I like it so far!
However, I found an omission: MD tables are not prettified. What do you think, could this be added at some point?
(I haven't looked at the code yet, so I don't know how hard it would be, maybe I'll take a look later.)

Rules for tables are welcome! I don't use tables myself but look forward to PRs. It should be straightforward to implement, follow the instructions in the readme.

Advanced tables is doing a great job in my use cases. Perhaps it would be possible to hook it in?

When we say tables are "prettified" what exactly is meant by this, @Sh4rK ? Does this mean that the table would be made to have the same width character-wise for each row or is there more to it?
As for integrating with another plugin, I am not entirely sure how that works in Obsidian, but if there were an example of how that is done, I would definitely consider it. Do you know of any plugins that already do this @0xlevel ?

As for integrating with another plugin, I am not entirely sure how that works in Obsidian, but if there were an example of how that is done, I would definitely consider it. Do you know of any plugins that already do this @0xlevel ?

Sorry, @pjkaufman, I wouldn’t know and from a quick glimpse at the plugins I use, I came up empty.

When we say tables are "prettified" what exactly is meant by this, @Sh4rK ? Does this mean that the table would be made to have the same width character-wise for each row or is there more to it?

Sorry, I didn't really use this since, so I don't remember exactly. I imagine it would align all table columns, to line them all up visually, like what Prettier does, though this might not be needed in Obsidian with the automatic rendering feature.

I would not be opposed to having rules added for tables, but I am not sure what would be requested for this here.

Looks like we could go ahead and add a feature for it. Here is an NPM package we could use: https://github.com/darkriszty/MarkdownTablePrettify-VSCodeExt#npm
It would make the tables be prettified and allow for the specification of table column padding. I am not sure how customizable this would be.

The only thing is that it looks like it will support latin characters, but Chinese, Japanese, and other similar languages may have issues with the table formatting.

Advanced Tables is one of the most popular community plugin in Obsidian. It has a “Pad cell width using spaces” feature. And yes, it does NOT support CJK characters, but better than nothing, right? I can live with that.
I suggest Linter provide a switch to left tables untouched for Advanced Tables users, otherwise those padded spaces are trimmed in tables on lint right now.

Advanced Tables is one of the most popular community plugin in Obsidian. It has a “Pad cell width using spaces” feature. And yes, it does NOT support CJK characters, but better than nothing, right? I can live with that.
I suggest Linter provide a switch to left tables untouched for Advanced Tables users, otherwise those padded spaces are trimmed in tables on lint right now.

Do you mimd providing an example? I remember updating the table rule to ignore multiple spaces in tables.

Advanced Tables is one of the most popular community plugin in Obsidian. It has a “Pad cell width using spaces” feature. And yes, it does NOT support CJK characters, but better than nothing, right? I can live with that.
I suggest Linter provide a switch to left tables untouched for Advanced Tables users, otherwise those padded spaces are trimmed in tables on lint right now.

Do you mimd providing an example? I remember updating the table rule to ignore multiple spaces in tables.

I made some tests and found out it was my mistake. GFM tables requires a blank line before, but Obsidian's Live Preview mode just render it into a table anyway regardless of this rule. 😂
Multiple spaces in tables are indeed ignored as you say.

To be honest, I've lost interest in this (I don't use Obsidian that much).
Given that there's another plugin specifically for tables, should we close this issue?

To be honest, I've lost interest in this (I don't use Obsidian that much).
Given that there's another plugin specifically for tables, should we close this issue?

I would think that this is fine unless someone else really wants Obsidian Linter to prettify tables.

To be honest, I've lost interest in this (I don't use Obsidian that much).
Given that there's another plugin specifically for tables, should we close this issue?

I would think that this is fine unless someone else really wants Obsidian Linter to prettify tables.

I did not think, integrating table magic would be wise, anyway… unless the linter could pass the job to another plugin, which seems to be unheard of. Some kind of exception (e.g.) for tables (like @ben-yip proposed) might be sensible, though. That said, I am happy with the current state. Cheers.

To be honest, I've lost interest in this (I don't use Obsidian that much).
Given that there's another plugin specifically for tables, should we close this issue?

I would think that this is fine unless someone else really wants Obsidian Linter to prettify tables.

I did not think, integrating table magic would be wise, anyway… unless the linter could pass the job to another plugin, which seems to be unheard of. Some kind of exception (e.g.) for tables (like @ben-yip proposed) might be sensible, though. That said, I am happy with the current state. Cheers.

Using another plugin to handle tables could be done, but its implementation would be hard to test and relies on continued maintenance of the other plugin. Because of this, I am hesitant to do such a thing.

Based on what has been stated on this issue, I am going to close this issue and if there is a need for this feature in the future we can revisit this;.


ppl: update write_pin_placement to write pins from odb

Fixes https://github.com/The-OpenROAD-Project/OpenROAD/issues/5851.

@maliberty Lint Tcl failed, but it doesn't show what is wrong. Running tclfmt in the file change a lot of things completely unrelated to this PR. Do you know how to proceed?

Looks like you'll need to run tclfmt on IOPlacer.tcl

@nmoroze it is possible to get a more descriptive output?

@eder-matheus you might need to make sure you have the right version. I ran into that issue before.

@eder-matheus what tclfmt version/command are you running and what are some examples of the changes you're seeing? @gadfort is right, although I think in this case using any released version that includes tclfmt should give the correct result. Looking at things locally, the only change that needs to happen is:

@maliberty good question, it would be simple for the tool to at least print out what command to run to fix the issue. Another thing I can try is updating the CI job to this:
tclfmt --in-place .
git diff --exit-code

which is a pretty simple way to achieve the equivalent of having something like a diff mode.

tclfmt --in-place .

@nmoroze I'm using tclfmt 0.4.0. When running tclfmt IOPlacer.tcl, there are changes all over the code, similar to the figure below:

But also some larger changes:

@nmoroze it might be helpful to also print the version of tclfmt at the start of the check to make this easier to debug as well.

@maliberty This unit test is failing in the head pipeline, and has nothing to do with this PR:
614/799 Test #628: psm.gcd_em_test_vdd ...........................................***Failed    2.89 sec
@bnmfw reported something similar in one of his DRT PRs.

The CI uses 0.4.1 (https://github.com/The-OpenROAD-Project/OpenROAD/blob/edf00dff99f6c40d67a30c0e22a8191c5d2ed9d6/.github/workflows/github-actions-lint-tcl.yml#L15)

I sounds like psm.gcd_em_test_vdd might have some non-determinism that should be investigated.  Running it with valgrind and/or ASAN would be good.

I sounds like psm.gcd_em_test_vdd might have some non-determinism that should be investigated. Running it with valgrind and/or ASAN would be good.

I'm on it.

@eder-matheus I looked more closely and I think the large errors you saw with tclfmt 0.4.0 probably came from running tclfmt outside of the project root directory (which would have prevented it from picking up the configuration). So if you see that again, that's something to double check.
I plan to fix this behavior as well - there's already an old issue for it (https://github.com/nmoroze/tclint/issues/30), but I'll make it a higher priority to get around to.

@eder-matheus I looked more closely and I think the huge changes you saw with tclfmt 0.4.0 probably came from running tclfmt outside of the project root directory (which would have prevented it from picking up the configuration). So if you see that again, that's something to double check.
I plan to fix this behavior as well - there's already an old issue for it (nmoroze/tclint#30), but I'll make it a higher priority to get around to.

That's it! I run it inside OpenROAD/src/ppl/src directory. Running it in the project root behaves as expected.

I struggled a bit with the tcl formatting. Here are some notes (doubtless to myself!).
I found that I can just run it on the file I changed (eg OpenRoad/src/OpenRoad.tcl)  from OpenRoad project root
To get the linter:
python -m pip install tclint==0.4.1
tclfmt --in-place ./src/OpenRoad.tcl  <-- format the file.  Seems to use configuration in  tclint.toml
tclint --check ./src/OpenRoad.tcl
tclint --no-check-style ./src/OpenRoad.tcl
However there are some issues if you run in the local directory because it does not pick up the configuration in the tclint.toml. The worst of which is the line size (tclint defaults to 80  and ident 8).  To run locally in the directory I used:  tclfmt --indent 2 --spaces-in-braces --in-place source OpenRoad.tcl
(I could not find a line option to set the width).
Running the commands standalone shows the offending lines in the code.

Might be worth reformatting the tcl file so that:
(a) Expressions use { }. eg what is the difference between:
set make_tech [expr { ![ord::db_has_tech] }] and
set make_tech [expr ![ord::db_has_tech]]
(b) No lines > 80 columns
I ran some slightly stricter linting and found a few of these kinds of things. Not sure how important it is ! I had put the changes in pull request 5836 (now backed out)

@andyfox-rushc to address some of your comments:
Yes, the observation about different results depending on where you run tclint or tclfmt is the same issue that @eder-matheus ran into (and is tracked as something to be fixed: https://github.com/nmoroze/tclint/issues/30). A good workaround that I just thought of is to use the -c/--config flag, for example:
export TCLINT_CFG=/path/to/openroad/tclint.toml

# prepend `-c $TCLINT_CFG` to any calls within the repository to always use the config, e.g.:
tclint -c $TCLINT_CFG ...
tclfmt -c $TCLINT_CFG ...

The stricter linting you noticed is also related to the config file not being applied. I don't think there's any need to change specific files to match the repo's tclint configuration, unless that configuration itself is going to be changed.
The particular note about braces around expressions is interesting, since that may be something worth eventually fixing and un-ignoring in the config. The braces actually make a subtle difference in how the expression is interpreted (and I figure in 99% of cases the braced version is what the user actually intends). Without the braces, substitution is performed first and interpreted as part of the expression itself, otherwise it acts like a variable within the expression. Better explained with an example:
set foo "1 + 2"
puts [expr $foo]   ;# outputs "3"
puts [expr {$foo}] ;# outputs "1 + 2"

The Tcl language reference itself suggests adding braces as a performance consideration as well, see "Performance Considerations" under https://tcl.tk/man/tcl/TclCmd/expr.htm.
Anyways, I think this isn't directly related to this PR at this point - happy to clarify more but maybe this discussion should be moved to #5836 or #5812.

@nmoroze please see the comments about braces above.

@maliberty I think I addressed it above, but let me know if there's something else I'm missing!


feat: support pull requests

First of all: Thank you for this action! I use it in many repos and it is very helpful!
It would be great if this action could also support pull requests.

It appears based on the code that pull requests are supported, is anything not working now or did this issue predate support?

You're right. It works: https://github.com/capawesome-team/capacitor-plugins/pull/267 I'm not sure what didn't work when I created the issue.


Distance and Direction toolset help migration complete

This commit has the Distance and Direction toolset tools help migrated
into the PYT.

@csmoore  - Distance and Direction toolset tool help updated for the PYT. Please review and merge.

Looks good - the only thing I noticed was a missing space - but that was in the previous .tbx/toolbox version also so can be fixed later:


feat: added Kwenta to spot balances table.

Description

Related issue

Closes: #1630
Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Awesome draft PR, this looks great already. A few small details I noticed:

sUSD is twice in the list; probably because it is an option on 1inch as well as among the classic synthetic assets we support. We probably want to make sure not to show them twice. Not sure if the same applies to the other synthetic assets (sBTC, sEUR, sLINK and so on).

Naming label is off, most assets just have the name "Synthetic" below their symbol. I believe this is because a few months ago, we were manipulating the string because the contracts were returning something like Synthetic Synthetic US Dollar. This affects both the Spot Balance table as well as the Exchange component, so we need to make sure to get these right.

As discussed in DM, we can probably show Amount values below 0.1 as <0.01. Alternatively, we could also think of a checkbox so users can decide if they want to hide Amounts <2 US$ or similar. Let's discuss this on Discord!


fix(referesher): fix a bug with browser

Short description of what this resolves:
Although I'm not sure about this but leaving translateZ(0px); in scroll content's style could make the content displaced as after it's being done the content now have scroll and in browsers as we know there's a scroll fitting left or right. (although this bug doesn't affect on LTR but you can see the problem on RTL on a browser), besides why leaving translateZ(0px); in css when things have done?
Changes proposed in this pull request:

remove translateZ(0px); when there's no vertical transform

Ionic Version: 3.x
Fixes: maybe #11822?
Screen shot:
Before the fix

After the fix

I found this bug too when I tired to use Menu and pull-to-refresh together.
When pull-to-refresh was triggered once,then opened the menu I found that some content displaced.
I fixed it by replacing 'translateZ(0px)' with '' when there's no vertical transform.
So,I wonder why leaving 'translateZ(0px)'?

Hello and thank you for contributing to Ionic! We have been working on porting all of the Ionic components to web components and have recently updated master to reflect this. This significant change has caused this pull request to break. While we really appreciate the time and effort you put into creating this, we are not able to merge it because of the newly introduced conflicts. We are extremely sorry about this. We will not be merging any more features in to v3. If this is a feature and you have the time, please resubmit this PR against the master branch. If this is a critical security issue in v3, we would greatly appreciate it if you would resubmit the PR against the new v3 branch. Thanks so much for your time!


Very old dependency packages. It's shit, sorry

There is of course no easy way to update all of this. I do not recommend using this tool until it is fixed.

have any other template

have any other template?

You cat try: electron-vue-next
But now I am using the Quasar Framework (it has its own CLI for creating an application)


Custom Meal Request

A text box/text area where one could type in and describe a meal of their choice that is off the restaurant menu which they want prepared by Mathe.

Hello, this is a nice idea, however it has been separated into tow components 1. in app chat support
2. allergen and ingredient filter.
Good trial though, please read through them and maybe create custom issues for those two components

Noted, okay on it...thanks!
On Mon, Jun 5, 2023 at 8:58 AM pauline njuguna @.***>
wrote:

Hello, this is a nice idea, however it has been separated into tow
components 1. in app chat support
2. allergen and ingredient filter.
Good trial though, please read through them and maybe create custom issues
for those two components
—
Reply to this email directly, view it on GitHub
https://github.com/Octal-Ideas/kwa-mathe/issues/25#issuecomment-1576090098,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AF7D5API7L3TBV2F2VIHEDDXJVYSBANCNFSM6AAAAAAYYDA4XY
.
You are receiving this because you authored the thread.Message ID:
@.***>


Feat/add mdfmt

Closes #2099

Worth mentioning, ran tests locally and they all passed.

Disregard this PR. Unfortunately, mdfmt is woefully outdated and doesn't seem to be maintained.


Add docs section to highlight jest.requireActual

First – thanks so much for this project, I've been using Jest for a couple of years and have benefited from it a lot!
Summary
I've been in the situation a few times where I've had a problem that could be solved by require.requireActual but didn't know about it because it seems to be quite hidden away in the docs (as far as I could tell, it's only really documented in the "Globals" section of the API reference). As a result of not knowing about it, I've wasted quite a lot of hours writing my own manual mocks rather than using Jest's automocking features. This PR adds a section to the docs entitled "Bypassing module mocks" which presents an issue similar to one I encountered recently, and talks the reader through how require.requireActual can solve the problem.
Let me know what you think. I've tried to match the tone of the rest of Jest's docs, and tried to pick an example that's simple enough to quickly make sense of but also resonates with the sort of tests people would actually write in real life.
I'm not at all wedded to the particular example I use – I'm mostly just keen that something gets added to the docs that draws attention to require.requireActual.
When I built the docs locally (by running yarn start in the website folder) it didn't seem reflect my changes as I made them, so I haven't been able to verify if the markdown gets rendered into the web page correctly. But I imagine that's a simple task.
Thanks very much.
Test plan
N/A

@bdrobinson you can see a preview with your pr here: https://deploy-preview-6651--jest-preview.netlify.com/

Also, please run yarn lint:md to fix the lint errors on CI 🙂

I've run the linting and updated it to refer to jest.requireActual rather than require.requireActual 👍

Codecov Report

Merging #6651 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #6651   +/-   ##
=======================================
  Coverage   63.73%   63.73%
=======================================
  Files         235      235
  Lines        8938     8938
  Branches        3        4    +1
=======================================
  Hits         5697     5697
  Misses       3240     3240
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 664681a...474ea70. Read the comment docs.

Great doc, thanks!


Support decoding of 16bit PNG images

Hi,
I try to use lwip resize our game's resources. Some of our texture are saved as 16bit channel, and I found lwip didn't support this so the result texture getting wrong.
Here is an example texture we used:

and the way we resize it:
        // start create
        image.resize( size, size, "grid", function (err, image) {
            // check error
            if ( err ) {
                Fire.error(err.message);
                return;
            }

            var extname = Path.extname(fspath);
            var thumbFile = Path.join( dest, uuid + ".thumb" + extname );
            image.writeFile(thumbFile, function(err) {
                if ( err ) {
                    Fire.error(err.message);
                }
            });
        });

@jwu Thanks for the input.


Update README.md

This pull request aims to make the readme file more consistent. I'll list the proposed changes below:

Moved Base Game FLAs to the art section, because I think that it fits the category better
Removed Week 7 Update FLAs, because they're already available in the Base Game repository
Fixed grammar errors, added/improved description for some content.
Commented out some stuff (because I wasn't sure if they should be kept or not)
Removed duplicates in Chromatic Scale Guides section

bruh does the linting really check the comments too

Hi Tom!!!
I'd add back the Week 7 Flas tweet to the resource, a couple of the flas listed in the tweet are actually not in the Funkin' repo (surprisingly), like picoSpeaker's fla for example

oh sry didn't know i'll do it right away


FindFilesTask is not properly stopped when running inside a Swing application.

Add proper shutdown mechanism to prevent FindFilesTask stopping exceptionally at Swing application shutdown.

Something like:
public void shutdown() {
        model.getFileUpdateService().cancel();
}

...would help to eleminate the exceptions in case a Swing application is closed. This method could be called in a WindowListener::windowClosed method.

shutdown() method implemented with 830dc36a5f6f3a3f2cefc2cb5239fbffc9319f7a.


Subclass property inference fails with literal and tuple types

TypeScript Version:  3.8.0-dev.20191115

Search Terms:
subclass property inference string literal tuple type
Code
class Base {
  readonly x: 'a' | 'b' = 'a';
  readonly y: readonly [number, number] = [1, 2];
}

class Sub extends Base {
  x = 'b';
  y = [3, 4];
}

Expected behavior:
It should pass.  The type checker should use the requirement from the base class to inform the subclass property inference, similar to how normal assignment works:
let x: 'a' | 'b' = 'a';
let y: readonly [number, number] = [1, 2];
x = 'b';
y = [3, 4];

Actual behavior:
(property) Sub.x: string
Property 'x' in type 'Sub' is not assignable to the same property in base type 'Base'.
  Type 'string' is not assignable to type '"a" | "b"'.(2416)

(property) Sub.y: number[]
Property 'y' in type 'Sub' is not assignable to the same property in base type 'Base'.
  Type 'number[]' is missing the following properties from type 'readonly [number, number]': 0, 1(2416)

Playground Link:
https://www.typescriptlang.org/play/#code/MYGwhgzhAEBCkFNoG8CwAoa0BOCwBMB7AOxAE9oAPALmgHIw7oAfegIyYF57GBuDLLgIly0MrSFFSFANrEArgFs2CbABpoC5aoC60bjICMGgEw7+6AL4YMoSDADK8ttASUALgmL4Y8CEjRMKn12OgssCgMAZg0AFnMMSyA
Related Issues:
None found

Properties are not contextually typed by the subclass. The way it works is the class is typed independently and then checked against the base class.
Duplicate of: #3667
Related To: #23911, #6118, #10570
If you want tot avoid specifying the type again, using type queries could ease some of the pain:
class Base {
  x: 'a' | 'b' = 'a';
  y: readonly [number, number] = [1, 2];
}

class Sub extends Base {
  x: Base['x'] = 'b';
  y: Base['y'] = [3, 4];
}

Playground Link

Thanks for the reference.  I guess I missed the keyword "contextual".
I'm happy to close this as a duplicate of #10570.


request for scaling on window resize example

Here is an example of scaling a circle based on window resize in D3 using the viewbox attribute:
http://christopheviau.com/d3_tutorial/d3_examples/
How can this be accomplished using r2d3?
Thank you.

Hi there,
This project is no longer being maintained so this issue is being closed. Thank you for using r2d3 and taking the time to report this issue.


Fix exact matching example

Description of your changes

The referenced class should not be namespaced, and also should be a class.
Checklist

I have:

[ ] Run make reviewable to ensure this PR is ready for review.
[x] Ensured this PR contains a neat, self documenting set of commits.
[x] Updated any relevant documentation, examples, or release notes.
[ ] Updated the RBAC permissions in clusterrole.yaml to include any new types.

Were there any examples in the examples folder that should be updated?

Not yet - I think we should wait until the implementation is merged before updating examples.


Feature Request: Respect Atom's tab and tab-width settings when prettifying

It would be nice if it used hard/soft tabs and use tab-width specified in Atom's settings.

I modified the formatter.js to get this working.
  space (scope) {
    const softTabs = atom.config.get('editor.softTabs', {scope})
    const tabLength = Number([atom.config.get('editor.tabLength', {scope})])
    if (softTabs) {
      return Array(tabLength + 1).join(' ')
    } else {
      return '\t'
    }
  },

Thanks for the fix! Published as<EMAIL_ADDRESS>

Hey.
You forgot to change the if (softTabs != null) { to  if (softTabs) {
The Editor-Config editor.softTabs always gives u a boolean.
So, it's still broken in the current version.

Fixed and released as<EMAIL_ADDRESS>🎉


fix(rspack-dev-server): remove webpack dep

Summary
It seems we don't use webpack in rspack-dev-server

Test Plan
No Need

Require Documentation?

[x] No
[ ] Yes, the corresponding rspack-website PR is __

This will cause Error: Cannot find module 'webpack/hot/dev-server', revert in https://github.com/web-infra-dev/rspack/pull/5261/files#diff-fa2af2cbbd416f67bb21aaa181218db15fb78d0b36da8b031ff14bf18d0770dc

@ahabhgk we should reopen this and find alternative solution other than depends on webpack(which increase size)


An admin can toggle the Messaging feature on/off

A PR addressing this issue should...

[ ] Wrap UI and routes (only) related to Messaging in a feature flag
[ ] Expose said feature flag via an environment variable

Closing in favor of a code change and deploy required to enable Messaging.


Resolve some TODOs [ECR-3008, ECR-2796]

Overview

See: https://jira.bf.local/browse/ECR-3008
Definition of Done

[ ] There are no TODOs left in the code
[x] The coding guidelines are followed
[x] Changelog is updated if needed (in case of notable or breaking changes)
[x] The continuous integration build passes

Coverage increased (+0.02%) to 86.148% when pulling 785908f68865cb60c823935cacb6569054f75655 on dmitry-timofeev:resolve-some-todos-ECR-3008 into 5cab71d9d903e1607a4fa471de4a8094ab67c51b on exonum:multiple-services.


Amexio Datagrid Filtering

I'm submitting a...

[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report
[X ] Feature request
[ ] Documentation issue or request
[ ] Support request

Current behavior

Currently if you have a amexio-datagrid and you enabled the enable-data-filter property it allows you to correctly filter the data.  However, if you have multiple pages of data it still displays all of the pages of data at the bottom of the grid even though after filtering there may only be a single page of data.  It is even more confusing if you happen to have multiple pages of filtered data.  It looks like you should be able to click on one of the page numbers at the bottom, but clicking on them actually clears the filter.
Expected behavior

It would be great if filtering could actually filter the page numbers at the bottom as well and the page numbers at the bottom would apply to the filter.  For example, if you have 50 pages of data and the filter results in 2 pages, then there would only be a 1 and 2 page numbers at the bottom.  Then it would allow you to click on page 1 or 2 to go to that page of filtered data without clearing out the filter.
Minimal reproduction of the problem with instructions
For bug reports please provide the STEPS TO REPRODUCE and if possible a MINIMAL DEMO of the problem via
https://plnkr.co or similar (you can use Our Amexio Plunker as a starting point: http://plnkr.co/edit/M9AeGH?p=info)
What is the motivation / use case for changing the behavior?

We use the grid to display a large amount of data (often 50-100 pages of data).  It is working great, but the filtering is difficult to use because of the paging issue.  We would love to continue using the built in filtering since it easily allows client-side filtering, but need the way that the paging with filters is working.
Environment

Angular version: We are currently using 7.0.1

Browser:
- [X ] Chrome (desktop) version XX
- [X ] Chrome (Android) version XX
- [X ] Chrome (iOS) version XX
- [X ] Firefox version XX
- [ X] Safari (desktop) version XX
- [X ] Safari (iOS) version XX
- [ X] IE version XX
- [X ] Edge version XX

For Tooling issues:
- Node version: XX
- Platform:

Others:

Hi teatherconsulting,
we have fixed this issue, Please find working functionality in next point release.

The filtering does work as we expect.  However, now it seems like you can't clear out a filter.  For example, if I type in an a, then it filters and only displays the items that start with an a.  However, if I remove the a it isn't possible to get back the entire list without refreshing the table from scratch again.  Can we make it so it will clear out the filter if you remove the data from the textbox again?


Update dependency: deps/mx-semantics_release

currently blocked on https://github.com/runtimeverification/mx-semantics/pull/324

@bbyalcinkaya there seem to be some issues with types with the latest kwasm/k. Would you be able to take a look? I think the nix stuff should work now


Forced 2D view on Windows?

After a while, I ran wowser (latest master updates) and saw this:

I couldn't interact at all. Any ideas about what's going on?

The orbit controls are currently missing after swapping to Riot as the UI framework. I probably should not have merged that in prematurely.

The forced perspective issue should be fixed in 5aa508ba5e95f80a5e9a4fc519ca43e0bc868054. Thanks!

I'm still having the same problem even after update, I ran gulp and everything. Happens both in Chrome and Firefox

Does it still look skewed? Or are you thinking about the controls?

Well basically I didn't register any change, I have the same top view and no controls as previously.

The controls are on the way, but the skewed view should be fixed. It's still from the top though.

Ah sorry, you are right it's not skewed anymore.

The orbit controls should be back in with f3acd2c468d3877acf055ad6a9537948a9467323.

Nice, thanks! Am closing this.


Let validation service remove all hidden data before validation.

Implements the same solution as in https://github.com/Altinn/app-frontend-react/issues/1709, but in the backend.
This makes a few extra in-memory copies of the data, but at least it is centralised once in the validation service, instead of doing it in each validator.

Tests fails
Currently not opt-in

Related Issue(s)

#461
https://github.com/Altinn/app-lib-dotnet/pull/462

Verification

[ ] Your code builds clean without any errors or warnings
[ ] Manual testing done (required)
[ ] Relevant automated test added (if you find this hard, leave it and we'll help out)
[ ] All tests run green

Documentation

[ ] User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

Implements the same solution as in Altinn/app-frontend-react#1709, but in the backend.
Currently not opt-in

It's unclear to me, the mentioned issue (1709) is about removing hidden data, not only for validation purposes, but everywhere. If this PR enables the feature when actually saving data (removing hidden data from the data moden in Storage) that's not the way to go, I think.
If it's about removing hidden data in the data model copy only when running validation, so that ["component", "..."] lookups return null for hidden components, the way it used to be, that should be fine.

It's unclear to me...

Functionality the same, but obviously not including the cache of removed data in the browser. It removes from a copy used only for validation.

Closing this, as it was decided to wait for https://github.com/Altinn/app-frontend-react/issues/1709 to introduce this form of automatic filtration of data.


added learning resources

I added to a link to Keras learning resources for developers who might want to take a refresher course before deep diving into Huggingface.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Add ability to execute the Polling cleanup logic in Containerized dispatch model

The transition to CONTAINERIZED dispatch model from POLL model can be done gradually by splitting the workload between the 2. In the scenario where both dispatch models are in use both of the logics to cleanup stuck executions are needed.
This PR adds a workaround to run the ExecutorHealthChecker thread from POLL dispatch when Containerization is enabled. The ExecutorHealthChecker thread will start only if the properties azkaban.executor.healthcheck.interval.min and azkaban.executor.max.failurecount are configured in the azkaban.properties file.
A better solution would be to support multiple dispatch models in the web server instead of just one.
Testing:
-Added unit test to make sure the Polling cleanup logic processes executions with POLL dispatch method only.
-Verified that the ExecutorHealthChecker thread starts in a test Azkaban instance where containerization was enabled.

Pull Request Test Coverage Report for Build 6711

13 of 18 (72.22%)  changed or added relevant lines in 7 files are covered.
4 unchanged lines in 2 files lost coverage.
Overall coverage increased (+0.06%) to 45.212%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

azkaban-common/src/main/java/azkaban/executor/JdbcExecutorLoader.java
0
1
0.0%

azkaban-web-server/src/main/java/azkaban/webapp/AzkabanWebServerModule.java
6
10
60.0%

Files with Coverage Reduction
New Missed Lines
%

azkaban-common/src/main/java/azkaban/user/UserUtils.java
1
74.19%

azkaban-exec-server/src/main/java/azkaban/execapp/JobRunner.java
3
76.16%

Totals

Change from base Build 6709:
0.06%

Covered Lines:
17989

Relevant Lines:
39788

💛  - Coveralls


Error  apurl service is not defined

I change Document Service Location
api url : service is not defined
OS version:  CentOS Linux release 8.4.2105
Software version :
[root@localhost ~]# rpm -qa | grep onlyoffice
onlyoffice-xmppserver-11.0.0-107.noarch
onlyoffice-documentserver-6.3.1-32.x86_64
onlyoffice-communityserver-11.5.2-460.noarch
onlyoffice-repo-1.0.0-11.noarch
onlyoffice-controlpanel-3.0.0-381.noarch

Hello @flyingzf Why are you changing that? and for what value? You install workspace, that included local document server.


Switch from flatgeobuffer to geomedea for GTFS

CC @michaelkirk, I'm trying out geomedea for the use case I described in Discord!

Metric
flatgeobuffer
geomedea

File size
99MB
53MB

Bristol
3.6MB in 23 requests
5MB in 20 requests

Elephant & Castle
6.4MB in 935 requests, 1.76 minutes
9.4MB in 24 requests, 8.3s

Bristol doesn't have many GTFS trip shapes intersecting the area, while E&C in London has loads.
Unless I'm measuring something wrong, the current approach with geomedea incurs more bandwidth, but through way less requests and latency.

Unless I'm measuring something wrong, the current approach with geomedea incurs more bandwidth, but through way less requests and latency.

It's not entirely surprising that geomedea might request more data.
In FGB, there is a single buffer of uncompressed features. In FGB, since there is no compression, the index tells us exactly where each feature is in the file. Using this I implemented smart feature batching, so feature requests will only merge adjacent features into a single request if they are "close enough".
To take advantage of compression, geomedea groups features into pages, so you have to download an entire page even if you only need one feature in the page. Because geomedea's features are in compressed pages, it's a little different. It can still be done, but I guess it'd be "page batches" rather than "feature batches". I haven't implemented this yet, but it should be doable in a non-breaking way.

Could you do me a favor?
RUST_LOG=debug
And give me the lines matching: Finished using an HTTP client. used_bytes
e.g.:
Finished using an HTTP client. used_bytes=839712, wasted_bytes=293690, req_count=4
Finished using an HTTP client. used_bytes=17, wasted_bytes=0, req_count=1

wasted_bytes should correspond to the bytes that could be gained by having more clever page-batching.

wasted_bytes should correspond to the bytes that could be gained by having more clever page-batching.

I had a go at "more clever page-batching" here:
https://github.com/michaelkirk/geomedea/pull/12

I was looking at the network traffic for your existing FGB integration - and I feel like there must be a bug. It makes no sense for all those small nearby requests (4 bytes?!).

I'm looking into that now.

With the new property encoding...
Elephant reads 6.3MB over 23 requests.
Finished using an HTTP client. used_bytes=156716, wasted_bytes=0, req_count=5
Finished using an HTTP client. used_bytes=3776001, wasted_bytes=1490472, req_count=17
Finished using an HTTP client. used_bytes=17, wasted_bytes=0, req_count=1
Bristol reads 2.5MB over 25 requests
Finished using an HTTP client. used_bytes=144956, wasted_bytes=1344, req_count=9
Finished using an HTTP client. used_bytes=1078601, wasted_bytes=473493, req_count=15
Finished using an HTTP client. used_bytes=17, wasted_bytes=0, req_count=1
So the new encoding is not giving that huge of an advantage, but still opens the way to doing something nicer later with delta encoding.
I'm going to merge this in now and continue to play with encoding / perf later on. It's a huge improvement with low work, so thanks so much for the new format, adding WASM support, and these page batching fixes!

Here's Elephant & Castle with https://github.com/flatgeobuf/flatgeobuf/pull/376

tldr; there was a bad bug in the http fetch implementation. It hadn't came up in the shape of my data and requests, so thanks for helping to uncover it.
With the bug fix, the two formats seem to be in the same ballpark of network transfer for your queries.


[ObjcHeader] Fix objc header generation when pch is explicited passed

When swift-frontend is explicitly passed the pch file as bridging header on command-line through -import-objc-header, it needs to print the original source file name if needed to the generated objc header.

rdar://109411245

@swift-ci please smoke test


Move  to _app.js

Problem
The website emits this warning:
Warning: <title> should not be used in _document.js's <Head>. https://nextjs.org/docs/messages/no-document-title

Solution
Set  in pages/_app.js instead:
// pages/_app.js
import React from 'react'
import Head from 'next/head'

function MyApp({ Component, pageProps }) {
  return (
    <>
      <Head>
        <title>My new cool app</title>
      </Head>
      <Component {...pageProps} />
    </>
  )
}

export default MyApp

Hi guys, I would like to contribute to this task, is it possible ?


Add MAINTAINERS document to 4.x branch

This is just a direct copy of the one from 3.x as we'll need it when 4.x becomes the default branch.

Coverage remained the same at 98.512% when pulling 8946b946c4feadf7e193eceb5086bc0f9a3b47eb on akrabat:4.x-maintainers-doc into 5f68a6f4ed9c0f052204bad0cf97ffc674d028ce on slimphp:4.x.


Add vm features as alternative to platform checks.

Idea is to use cargo features to disable for example io when that does not work on the wasm target for example.
This pull request only introduces the idea, the features still need to be used in the code.

Something I was considering in working on the WASM library is that it'd be nice to keep some parts of io, e.g. BytesIO, StringIO, and similar, for platform-agnostic IO, but specifically disable items that need e.g. fs access.

I'm inclined to agree with @coolreader18 here, I think some features in the various modules should be supported where they make sense.
With that said, the ability to select feature inclusions on a WASM build might prove extremely interesting, especially if it has a practical impact on the payload size.

Thank you for your feedback. I propose to then keep the compiler feature, to include the python compiler. This way we can enable pre-compiled python bytecode to be bundled with rustpython. This will reduce the size I expect.

Actually, now that I rethink this, having an IO feature might be of use when implementing rustpython on microcontrollers. In that case, things like file io, socket io do not make sense, and should be easily disabled.

So what would that entail, a command line flag?

You are right that running rustpython on microcontrollers is a stretch goal, but it certainly is one of my personal objectives. Also, it should be possible.
What it would entail, is that the main Cargo.toml file would specify which features of the rustpython_vm it wants to use. View rustpython_vm as a library which can be parameterized by features. This can be very handy for the wasm build, but also for microcontroller builds, or a special build which only requires bytecode to be run, no compilation (for example when freezing a script).


Mesh gets darker when spawn further away from the players spawn point

I'm spawning a world in Mesh chunks, sort of like minecraft. But when the mesh is spawned some distance (Not sure of much to be exact) from the players spawn location (I've tried moving the spawn point around, and this holds up) The mesh gets darker, as seen on the image. It's not a transition, it's litterally just the entire chunk that gets darker when spawned. What is the reason for this? Is there some light settings, that does not apply when mesh is creating far from spawn point?

Found the issue. All i had to do was turning off the lighting cache, and everything looks homogeneous now.


Add fill command

Fill .env file according to rules from specification
./keepenv fill

Codecov Report

Merging #1 (abedd76) into main (64b8fab) will decrease coverage by 9.19%.
The diff coverage is 13.33%.

@@             Coverage Diff              @@
##               main       #1      +/-   ##
============================================
- Coverage     92.40%   83.20%   -9.20%
- Complexity      235      259      +24
============================================
  Files            37       40       +3
  Lines           803      905     +102
============================================
+ Hits            742      753      +11
- Misses           61      152      +91

Flag
Coverage Δ

unit_tests
83.20% <13.33%> (-9.20%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

src/Application/Command/FillCommand.php
0.00% <0.00%> (ø)

src/Filling/EnvFileFillingService.php
0.00% <0.00%> (ø)

src/Generator/Presets/LaravelPreset.php
100.00% <ø> (ø)

src/Specification/EnvVariables.php
86.20% <0.00%> (-6.39%)
:arrow_down:

src/Verification/VariableVerification.php
95.65% <ø> (ø)

src/Environment/Writer/EnvFileWriter.php
34.21% <34.21%> (ø)

src/Validation/Rules/EnumRule.php
100.00% <100.00%> (ø)

src/Generator/SpecGenerator.php
94.73% <0.00%> (-0.10%)
:arrow_down:


linux下，解压后，执行启动命令./bin/seata-server.sh，报错Error: Unable to access jarfile /Users/min.ji/Git/github/seata/distribution/target/seata-server.jar

[root@iZwz99ft69kuwh014ttynyZ seata]# ./bin/seata-server.sh
apm-skywalking not enabled
Affected JVM parameters: -Dlog.home=/root/logs/seata -server -Dloader.path=/usr/local/projects/seata/seata/lib -Xmx2048m -Xms2048m -Xss640k -XX:SurvivorRatio=10 -XX:MetaspaceSize=128m -XX:MaxMetaspaceSize=256m -XX:MaxDirectMemorySize=1024m -XX:-OmitStackTraceInFastThrow -XX:-UseAdaptiveSizePolicy -XX:+HeapDumpOnOutOfMemoryError -XX:HeapDumpPath=/root/logs/seata/java_heapdump.hprof -XX:+DisableExplicitGC -Xlog:gc*:file=/root/logs/seata/seata_gc.log:time,tags:filecount=10,filesize=102400 -Dio.netty.leakDetectionLevel=advanced -Dapp.name=seata-server -Dapp.pid=2791821 -Dapp.home=/usr/local/projects/seata/seata -Dbasedir=/usr/local/projects/seata/seata -Dspring.config.additional-location=/usr/local/projects/seata/seata/conf/ -Dspring.config.location=/usr/local/projects/seata/seata/conf/application.yml -Dlogging.config=/usr/local/projects/seata/seata/conf/logback-spring.xml -jar /usr/local/projects/seata/seata/target/seata-server.jar
/usr/local/java/jdk-17/bin/java  -Dlog.home=/root/logs/seata -server -Dloader.path=/usr/local/projects/seata/seata/lib -Xmx2048m -Xms2048m -Xss640k -XX:SurvivorRatio=10 -XX:MetaspaceSize=128m -XX:MaxMetaspaceSize=256m -XX:MaxDirectMemorySize=1024m -XX:-OmitStackTraceInFastThrow -XX:-UseAdaptiveSizePolicy -XX:+HeapDumpOnOutOfMemoryError -XX:HeapDumpPath=/root/logs/seata/java_heapdump.hprof -XX:+DisableExplicitGC -Xlog:gc*:file=/root/logs/seata/seata_gc.log:time,tags:filecount=10,filesize=102400 -Dio.netty.leakDetectionLevel=advanced -Dapp.name=seata-server -Dapp.pid=2791821 -Dapp.home=/usr/local/projects/seata/seata -Dbasedir=/usr/local/projects/seata/seata -Dspring.config.additional-location=/usr/local/projects/seata/seata/conf/ -Dspring.config.location=/usr/local/projects/seata/seata/conf/application.yml -Dlogging.config=/usr/local/projects/seata/seata/conf/logback-spring.xml -jar /usr/local/projects/seata/seata/target/seata-server.jar  >> /dev/null 2>&1 &
seata-server is starting, you can check the /root/logs/seata/ *.log
后续查看日志报错：
Error: Unable to access jarfile /Users/min.ji/Git/github/seata/distribution/target/seata-server.jar
我的目录应该是/usr/local/projects/seata/seata/target

/root/logs/seata/ *.log 请到这里查看日志
Please go here to view the log.

It seems that the past version mistakenly packaged my local log file into the binary package. If the process can start normally, this file can be deleted without affecting the use of it. In the meantime, you are advised to upgrade to the next version.


[FEAT] safely update documents with optimistic locking

Similar to what the repository did in the old client

GET current version
apply changes
index with seq_no, and primary_term set
retry a configurable number of times in case of version conflicts

part of the IndexRepository


Connecting to OSP via UserApp Workflow to Access Middle Tier

We need to securely connect to the middle-tier from a NetIQ UserApp workflow, but Gromit requires an AngularJS connection, and I haven't been able to figure out how to use AngularJS in the workflow (if it's even possible).
Any ideas, on what my options might be, to create an authenticated connection to the middle-tier from a UserApp workflow?
Thanks in advance!!

You could always use yet another proxy …ugh.
Otherwise I think your going to need a custom workflow activity that can do the oAuth.

On Sep 7, 2018, at 10:41, Robert Anderson<EMAIL_ADDRESS>wrote:
We need to securely connect to the middle-tier from a NetIQ UserApp workflow, but Gromit requires an AngularJS connection, and I haven't been able to figure out how to use AngularJS in the workflow (if it's even possible).
Any ideas, on what my options might be, to create an authenticated connection to the middle-tier from a UserApp workflow?
Thanks in advance!!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/MicroFocus/CX/issues/27, or mute the thread https://github.com/notifications/unsubscribe-auth/AH25Q9UYbDRB6PP4znLCZW6fIH7MGo4sks5uYpO5gaJpZM4WfDhp.


table 273 "Bank Acc. Reconciliation" and table 274 "Bank Acc. Reconciliation Line" field(20; "Statement Type"; Option)

Hi,
would it be possible to change type of field 20 "Statement Type" form option to enum in
table 273 "Bank Acc. Reconciliation" and table 274 "Bank Acc. Reconciliation Line"?
        field(20; "Statement Type"; Option)
        {
            Caption = 'Statement Type';
            OptionCaption = 'Bank Reconciliation,Payment Application';
            OptionMembers = "Bank Reconciliation","Payment Application";
        }

        field(20; "Statement Type"; Enum "Recon. Statement Type")
        {
            Caption = 'Statement Type';
        }

enum XYZ "Recon. Statement Type"
{
    value(0; "Bank Reconciliation")
    {
        Caption = 'Bank Reconciliation';
    }
    value(1; "Payment Application")
    {
        Caption = 'Payment Application';
    }
}

Thanks in advance

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 10142.


Create rate limiter that interacts with Redis

Is your feature request related to a specific problem?
In order to offer users the ability to set rate limits on connector requests we need a distributed implementation. We can use redis to maintain this state.
Describe the solution you'd like
According to redis the simplest approach to build a rate limiter is the fixed window implementation.”. This feels like a pretty good place to start.  The rate limiter should be generic and be useful for any use case that requires a simple rate limiter.
Describe alternatives you've considered, if any
If we desire a configurable client side rate limiter then we need an implementation that can work across Fidesops instances. Redis is already used for this shared state so it makes to keep using it.
Alternative algorithms could be used to implement rate limiting but we should be able to start with a simple solution here and expand it if needed.
Additional context
Example
   r = redis.Redis(host='localhost', port=6379, db=0)

   api = request.headers.get('X-API-Key')
   if api == None:
       resp = Response("Please set the X-API-Key header", status=401)
       return resp

   epoch_time = int(time.time())
   pipe = r.pipeline()
   pipe.incrby("%s:hourly:%d" %(api, int(epoch_time/3600.0)*3600), 1)
   pipe.incrby("%s:daily:%d" %(api, int(epoch_time/86400.0)*86400), 1)
   pipe.expire("%s:hourly:%d" %(api, int(epoch_time/3600.0)*3600), 3601)
   pipe.expire("%s:daily:%d" %(api, int(epoch_time/86400.0)*86400), 86401)
   res = pipe.execute()

   if int(res[0]) > CALL_PER_HOUR or int(res[1]) > CALL_PER_DAY:
       resp = Response("DATA Exceeded", status=429)
   else:
       resp = Response("DATA OK", status=200)

   resp.headers['X-Rate-Limit-Hour-Remaining'] = CALL_PER_HOUR - int(res[0])
   resp.headers['X-Rate-Limit-Day-Remaining'] = CALL_PER_DAY - int(res[1])
   return resp

closing in favor of https://github.com/ethyca/fides/issues/1188


NPM and Bower installers are not working

Version info
most up to date
Milligram:
Other (e.g. Normalize.css, Node.js, npm, bower, browser, operating system) (if applicable):
npm 2.15.8
bower 1.7.9
Steps to reproduce
bower install milligram-themes
npm install milligram-themes
Expected behavior
install
Actual behavior
bower ENOTFOUND     Package milligram-themes not found

npm ERR! 404 Registry returned 404 for GET on https://registry.npmjs.org/milligram-themes
npm ERR! 404
npm ERR! 404 'milligram-themes' is not in the npm registry.

@tekand I'll look into this. Thanks, David.


cmd/asm: review assembly instruction argument order and names

At the least, the order of inputs to LUI is wrong. Once we're convinced we have pretty good coverage, it'd be good to review all the instructions and make sure we're happy with them. And--in a first for the Go assembler--document them!

cc @cherrymui

All issues should be re-opened upstream if still relevant (unlikely).


Add Docker development workflow

Add Docker workflow for making easier to start hacking. No devel packages nor development libs installation needed on development host, just Docker and Docker Compose and you're ready to go. People familiar with Docker will figure out themselves
Run:
$ docker-compose up --build

Stop by CTRL+C'ing.
Manifest launches a MariaDB server container based on mariadb[:latest] image and a collectd+python runtime container built from my pataquets/collectd-python-pip base image which just adds the necessary configs to send all collectd readings to stdout using the CSV plugin (see Dockerfile). Both containers are linked to allow collectd to connect to db via the mysql hostname.
The collectd container mounts from the Docker host's git repo directory:

The Python program file.
The mysql.conf config file.

Just hack, change confs and test by CTRL+C and up'ing again. Rinse and repeat.
This is what I've used so far to start tinkering and getting warm to tackle opened issues, some opened by me (#25, #27, #28). Hopefully, it will also help others interested in them to jump in and get up to speed quickly. HTH.

@chrisboulton : Bump, in case you didn't get any notification.

@chrisboulton : ping


EvalError vs dynamic language exception causes #556

This is a fix for issue #556
Catch evaluation errors that are caused by common scripting errors: syntax, name lookup failures, etc.  Allow the BeanShell script authors to catch these exceptions and attempt recovery or graceful shutdown.
The new class EvalException is a subclass of EvalError.  This will be used by benign exceptions where the interpreter can simply unwind from the point of error and carry on in the catch or finally block.

This was a huge help, thank you @opeongo


[QUESTION] There a way to open local links?

Question
Hi,
got to say this is a fun project, really helps out on learning and being more proficient with code. Plus putting my projects and content all together in one place. Anyway, while looking through the docs, I couldn't find anything along the lines to be able to open local links from on your computer.
You know in markdown how you can open links from your local computer, such as using file:///url-here-to-file/program or even other types of syntax of other kinds of languages  (different than markdown). Is there a way to do that here? Or is this something that hasn't been implemented yet?
I use Linux as my main OS and sync three different computers using SyncThing so the file locations are pretty much the same. So that's why I would like to have something like this.
I guess this is a question and an idea if it's not implemented yet.
Category
Search & Shortcuts
Please tick the boxes

[X] You are using a supported version of Dashy (check the first two digits of the version number)
[X] You've checked that this question hasn't already been raised
[X] You've checked the docs and troubleshooting guide
[X] You agree to the code of conduct

I've not tried this out, but in HTML it is the same as your example (like file://), so just putting that as the item's URL should work.
My todo list is very long at the moment, but when I get a moment, I will look into this further, and update you here.

Hey @FormBurden
I've looked into this, and the TDLR is that it's not going to be possible because browser security policies will block access to file://. If you try, you'll see this CORS error: Not allowed to load local resource: <URL> in the console.
A much better solution, would be to have a little web server that serves up your SyncThing files, then use the URL to a given file via that server. If this is just within your LAN it should be pretty simple to setup, and you could also use something like NextCloud or a NAS app to manage this.
Hope that helps. Going to close issue, as nothing to do on my end

Hey I appreciate it. No worries, like I said, was just trying to have central location where I could access pretty much everything in one place. Such as Dashy. I'll look into the web server you're talking about. You wouldn't happen to have something in mind for this solution? I use NextCloud as well, plus I have an entire Proxmox server, so nothing is out of my reach haha.
Thanks again! I really enjoy Dashy, so I'll be continuing to use it. You wouldn't happen to have a time-window possibly of when we would see Multi-Page Support? Currently I have about 4 instances running, due to being an organized fellow haha, so one page for specific things is my go-to. Regardless, thanks for your time!

The very simplest thing you could do is to just start a web server that points to the root of your SyncThing directory :- here are some basic examples of one-line web servers.
A more practical solution would be to use either NGINX + NPM or Traefik, either of those solutions will let you spin up a web server that exposes a directory of files that you can then access anywhere within your LAN.
If you want a nice UI, you could also use a web-based directory lister/ file manager, like DirectoryLister or FileGator, which will give you easy GUI-based read-only access to your files. But both are PHP-based, so needs PHP installed.

Multi-page support is coming very soon, I think it's the most requested feature!!
I'm working on bug fixes at the moment, then finishing sub-items, after that it will be multi-page support.
Thanks for your patience, I know it can be frustrating having to run multiple instances.


Crash on Start [0.4.0, 0.5.0]

I am not able to run the latest version, it crashes the moment I press the start button.
From the crashlog:
Application Specific Information:
fatal error: Couldn't find intended platform in list of platforms: []!: file /Users/honzadvorsky/Documents/Buildasaur/Pods/XcodeServerSDK/XcodeServerSDK/API Routes/XcodeServer+Bot.swift, line 172

It looks like there is an hardcoded path?

This is actually an issue in XcodeServerSDK, I created this issue there (subscribe to that one). I'll take a look at how to nicely handle this case, but basically this means that the Bot can't be created because no supported platforms were found on Xcode Server. Maybe try to reinstall Xcode Server (through OS X Server). Either way, this probably shouldn't be a crash.

Do you have any idea on how to make it work?
I have updated Xcode server to 5.0.4 and all works fine to be fair, apart from Buildasaur.

So when you're creating a Bot, does it let you select devices to test on?

I re-selected the Xcode app from the server app and now is working, weird...

Yeah, I think it re-initializes its internal platforms/SDKs. Glad it's working now, we will need to make that change in XcodeServerSDK anyway, to handle this case more gracefully. Thanks for reporting it! :+1:

np! :+1:


SDFG contains unnecessary intermediate transient

Describe the bug
SDFG contains unnecessary intermediate transient. Might be an issue with the Python frontend.
To Reproduce
Steps to reproduce the behavior:

Run the following Python code:

import dace as dc

@dc.program
def example_sdfg(x: dc.float64[10], y: dc.float64[10]):
    x[0] += y[0]

sdfg = example_sdfg.to_sdfg()
sdfg.simplify()
sdfg.view()

Investigate the produced SDFG (produces SDFG as seen in screenshot).

Expected behavior
I expect to get the same SDFG but without the transient __tmp0 AccessNode and the y[0] memlet flowing directly into the tasklet.
Screenshots
Screenshot of the produced SDFG:

Desktop (please complete the following information):

OS: Ubuntu 20.04
DaCe version: 0.14.4 (current main branch)
Python version: 3.8

My suggestion would be to debug the ArrayElimination pass with your example and see why RedundantSecondArray doesn't apply on y -> __tmp0. Then, we can discuss if the conditions are too conservative or if there are good reasons/concerns for the current behavior.


Base url as parameter

Hi, we are in a situation where we would like to run the stac-fastapi in a virtual machine behind a proxy server. In other words, the uri in the request parameters that the app sees are not the uri that the end user sees, so the urls shown in the catalogue are wrong. Is there a way to set the base url from an environmental variable or through a parameter ? We are currently deploying from docker-compose.

If anyone is facing the same issue, we dealt with it through our nginx reverse proxy.
   location /stac-fast-api/ {
        proxy_http_version  1.1;
        proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
        proxy_set_header X-Forwarded-Proto https;
        proxy_set_header Host $host/stac-fast-api;
        proxy_pass http://stac-api-app:8082/;
    }

Importantly, the following environment variable must be site, here in the docker-compose file

maybe this can help https://github.com/developmentseed/titiler/discussions/345#discussioncomment-1636050

@vincentsarago this is the same solution we ended up using. Thank you.

I'm having a similar issue trying to access stac-fastapi behind AWS API Gateway. I can get through, but all the links are shown as the EC2 instance DNS name, not the advertised API gateway domain name. My docker container has the environment variable FORWARDED_ALLOW_IPS=*, and I added proxy_headers=True to uvicorn.run (required?) as below:
        uvicorn.run(
            "stac_fastapi.sqlalchemy.app:app",
            host=settings.app_host,
            port=settings.app_port,
            log_level="info",
            reload=settings.reload,
            proxy_headers=True,
        )

Any ideas?

#415 added support for forwarding headers


A Tabbed/Stacked nested in another Tabbed/Stacked container doesn't properly show the focused view

To reproduce issue:

Spawn Tabbed/Stacked container
Make a Tabbed/Stacked container inside of that first Tabbed/Stacked container
Add a new view to that nested container
Notice that you can only see the latest one, not any the previous ones that you spawned.

I'll try to fix this one

Fixed

Correct, not sure why it didn't close automatically haha

Note that this issue was not totally fixed by @alexander-smoktal patch, as it caused a regression. Going to keep this closed since it is fixed but refer to #413 for further discussion


invalid conversion from 'const uint8_t* {aka const unsigned char*}' to 'const char*' [-fpermissive]

When compiling I get the following error:
`Arduino: 1.8.5 (Windows 7), Board: "WeMos D1 R2 & mini, 80 MHz, 4M (3M SPIFFS), v2 Lower Memory, Disabled, None, Only Sketch, 921600"
C:\Users\Isaac\Desktop\printer-monitor-master\printermonitor\printermonitor.ino: In function 'void drawWeather(OLEDDisplay*, OLEDDisplayUiState*, int16_t, int16_t)':
printermonitor:808: error: invalid conversion from 'const uint8_t* {aka const unsigned char*}' to 'const char*' [-fpermissive]
display->setFont((const uint8_t*)Meteocons_Plain_42);
                                                  ^

In file included from C:\Users\Isaac\Documents\Arduino\libraries\esp8266-oled-ssd1306-master/SH1106Wire.h:31:0,
             from sketch\Settings.h:48,

             from C:\Users\Isaac\Desktop\printer-monitor-master\printermonitor\printermonitor.ino:28:

C:\Users\Isaac\Documents\Arduino\libraries\esp8266-oled-ssd1306-master/OLEDDisplay.h:187:10: error:   initializing argument 1 of 'void OLEDDisplay::setFont(const char*)' [-fpermissive]
 void setFont(const char *fontData);

      ^

exit status 1
invalid conversion from 'const uint8_t* {aka const unsigned char*}' to 'const char*' [-fpermissive]
This report would have more information with
"Show verbose output during compilation"
option enabled in File -> Preferences.
`

I fixed this by cleaning up my libraries: Now using only OLED_SSD1306_-_SH1106 by Stefan Frings, Fabio Durigon and have no errors anymore.

Yep, that fixed it.
Thanks!