Create text only site

In the style of these sites:

http://thin.npr.org
http://lite.cnn.io

Let's make a text only version of these pages:

home page
article page
tag page
category page
paginated versions of each of those

If someone other than me takes on this issue, let's talk strategy before diving in.

Have you taken this one on yet? Looks like it could be a fun one to pull off.

@jennifermf is working on it.

Initial considerations/questions:

subdomain or separate folder?
serve dynamically or generate static files, with a job?
support/considerations for translations?
re: tag page. Does this page currently exist? I could find /categories for that page?

@socialecologist those are important considerations. i'm not sure how to address the first and third.
for the second... since text files are so small. i wondered if the text-only version could be generated automatically when the non-text version is created.
currently, each article on the main page has a <style="background-image: url(https://cloudfront.crimethinc.com/assets/articles/2018/07/11/header.jpg)"> and i think for maximum accessibility, it would be good to include image alt-text. however, i don't think alt-text exists here on the main page.

Also need to figure out how to handle the routes. Right now the PR has /txt and /txt/:article_id for two of the pages.

re: background images. You'll see I'm just using a new layout for the text only pages, so those aren't showing up. Some of the articles however have html content format with img tags in the content, so those ones are showing up right now.

Yet another thing to consider is how to link to this from the main navigable piece of the website. Could add something to the main footer.

Hi @socialecologist. Thanks for getting into this.
Here's my opinion on what strategy would be best.

subdomain or separate folder?

Subdomain.

serve dynamically or generate static files, with a job?

For now, dynamically like the image-full site. Generate static files is outside the scope of this issue. And if we did do that, it would also benefit doing it for the image-full site. It's not a slam dunk though. Re-generation / replacing old versions if they get updated, where to store them, where to serve them from, deployment process… all of these are trade-offs that come with moving to static site germination. So, for now, let's punt on this idea.

support/considerations for translations

For now, we don't have translations. But they're hopefully coming in the next couple months.

Also need to figure out how to handle the routes. Right now the PR has /txt and /txt/:article_id for two of the pages.

This is the main reason that I'd like us to use a subdomain for this. Because it means all route Just Work™.
Same for translations, when we implement them. However they're represented in the URL (or not) will get passed along all the same to the text only site.

Yet another thing to consider is how to link to this from the main navigable piece of the website. Could add something to the main footer.

I think adding it to the footer is a good idea. Maybe under the site map section.

re: background images. You'll see I'm just using a new layout for the text only pages, so those aren't showing up. Some of the articles however have html content format with img tags in the content, so those ones are showing up right now.

Here's my idea for how to handle linked css / style tags / background images. (More on images in article text later.)
If we put it at a subdomain, we can detect that subdomain in a Rack middleware (like the www redirect middle ware), then we could set a bit in that request life cycle that says "hey, I'm in text only mode".
# application_controller.rb
def text_only?
  # is some variable set by the middle ware because of the subdomain
end
helper_method :text_only?

Then that method could be used in views and controllers to conditionally show images and css.
<% unless text_only? %>
  <style …>
<% end %>

At that point, no need to create a new layout, etc. Just do/don't render images and css that are already there.
This approach will also make it easier to re-apply this strategy to the (coming soon) new site design.

Finally, how to deal with images in articles. This one is definitely the hardest!
For now, I think what we could do is if the request is in text_only? mode, run the rendered markdown through a method that uses nokogiri to find all img/video/audio tags and delete them from the out bound html before sending it to the browser.
In fact, all of them are wrapped up in <figure> tags. So, this method could target just that tag.

It would also be totally ok to punt this particular part of the "text only" site to a separate issue and build that after shipping the rest of this issue first. Your call.


GradebookNG prevents Timeout from Occuring

When on the GradebookNG tool on master, the session timeout will never be reached.
I tested this by doing the following:

Start two sessions in Sakai (using different browsers or private browsing)
In Session A, navigate to the GradebookNG tool
In Session B, navigate somewhere so that you have done something
Leave both sessions alone for a time greater than the timeout period
Come back to it where Session A will still be active and Session B will be logged out

Thanks @master-bob.  This is indeed an issue.  The gradebookng tool has two AJAX polls that may keep the user session from timing out - one for detecting concurrent changes and the other for detecting a dropped connection.
@steveswinsburg do you know if there's a way we can do to avoid reseting the session's lastAccessedTime?  I believe the "dropped connection" ping doesn't need to even touch the user session as it's more of a proof of life endpoint.  However, the concurrent edits call will definitely invoke the user's session.

Adding auto=true as a parameter to the AJAX polls should fix this. For example:
/portal/timeout?auto=true
/portal/presence/mercury?output_fragment=yes&auto=true&_=1479120797887

Thanks @smarquard, I'll give it a go!

Worked a treat, thanks @smarquard.  PR submitted.

Our local testing confirmed that #3584 fixes this issue.

@ottenhoff has this actually been merged to 11x or is this targeted for a merge?

https://github.com/sakaiproject/sakai/commit/a694591810bbeb0518851486e6d97ac11a2a2b8a

Ah, sorry, thanks @ottenhoff!

Just FYI, the commits will not link up in the Github thread unless you put HASH then the number. That's why we couldn't see it 👍


Fix one error with kmeans clusterin

There was a bug in Kmeans clustering when the number of samples was smaller than the number of clusters.

Okay, I have to fix this up.

This should fix the problem. It also adds some tests for the underlying utility function, which I also cleaned up a bit.


Adding cold events to composite knot

Codecov Report

Merging #15 into master will increase coverage by 0.24%.
The diff coverage is 97.05%.

@@             Coverage Diff              @@
##             master      #15      +/-   ##
============================================
+ Coverage     93.82%   94.07%   +0.24%
  Complexity       14       14
============================================
  Files             5        5
  Lines           243      270      +27
  Branches         29       36       +7
============================================
+ Hits            228      254      +26
  Misses            4        4
- Partials         11       12       +1

Impacted Files
Coverage Δ
Complexity Δ

knot/src/main/kotlin/de/halfbit/knot/Knot.kt
95.91% <100%> (+0.08%)
0 <0> (ø)
:arrow_down:

...not/src/main/kotlin/de/halfbit/knot/KnotBuilder.kt
94.44% <100%> (+0.15%)
8 <1> (ø)
:arrow_down:

...ain/kotlin/de/halfbit/knot/CompositeKnotBuilder.kt
88.33% <100%> (ø)
6 <0> (ø)
:arrow_down:

...t/src/main/kotlin/de/halfbit/knot/CompositeKnot.kt
95.52% <96.42%> (+0.17%)
0 <0> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 923113f...0375eb9. Read the comment docs.


Portable Version Issues

Hello,
The portable version has 2 issues:

Once installed (Unzipped) into folder (Will be called Installation Folder) which is located on a drive which is different than the Main Drive (In the cases I checked, Main Drive is C:\ and the program installed on D:) the program creates its AppData folder on 2 locations <Installation Folder>\AppData and C:\Users\<User Name>\AppData\Local\MarkdownEdit\mde.exe_Url_<Random Signature>.
In both AppData folders above a settings file is created. While the program saves the settings the user changes in th UI into the settings file at C:\Users\<User Name>\AppData\Local\MarkdownEdit\mde.exe_Url_<Random Signature> on loading it loads the settings from the settings file in the Installation Folder.

Both issues above are bug and teh application expected to act differently:

Create only 1 Settings folder (In Portable mode in the Installation Folder).
Use and Save settings into the Settings File created in the Installation Folder.

Those issues were verified on 3 different computers all running Windows 10 64Bit.
For all 3 computers MDE installation is a clean one (Namely none of them has ever had MDE installed in Portable or Regular mode).
Thank You.

The C:\Users\<User Name>\AppData\Local\MarkdownEdit\mde.exe_Url_<Random Signature> file contains the last window position and a few other system specific settings. This is by design. Your welcome to disagree with my design decision but the implementation as it stands is not likely to change.

@mike-ward, The file in there is the same JSON settings file I have under <Installation Folder>\AppData.
Is that the decision choice?
I'm not talking about what you explained it is a necessity for .NET.
I'm talking about the Program Settings file (This is the cause settings are not saved).
Anyhow,
I can even share with you my computer (2-3 of them) to show you it happens over and over again.
I'm just a user who tries the report a bug.
I don't understand why I'm describing one thing and you response to other thing.
My question is simple, whys is the settings file is duplicated?
Why aren't settings being saved (The two are connected)?
Thank You.

The only file I have in C:\Users\mike\AppData\Local\MarkdownEdit\mde.exe_Url_htckrcqzc5ek51ufz1skdztxdivvc020\<IP_ADDRESS> is user.config
The files in my portable AppData folder
emoji_sprite.png
user_settings.json
user_template.json
custom_dictionary.txt
snippets.txt

I simply don't see duplicate files.

I can confirm with @mike-ward. On my system, the two locations have files with different names and they hold different settings. This has been the case with both 1.26 and 1.27.

@shnbwmn ,
Do you use the portable version?
Did you have it (the program) installed before?
Thank You.

@RoyiAvital I use the portable version, and didn't have it installed before. But that doesn't matter, because I tested both versions in Sandboxie, which is independent of my computer's files.


Awake module: active until expiration date should not be in the past

Microsoft PowerToys version
0.71.0
Installation method
WinGet
Running as admin
Yes
Area(s) with issue?
Awake
Steps to reproduce
I always use Keep screen on for Awake.

Use a time interval to keep the system awake for some time.
Wait for the time interval to run out and the screen to turn off.
Choose Keep awake until expiration.

I'm not certain as to why (maybe I used this setting once in the past, I can't remember), but the pre-filled date/time fields are using June 6th 2023 (today is July 16 2023).  Regardless, if I had previously set the expiration date to Jume 6 or not, when Keep awake until expiration is selected, the date/time should at least be set to the current date.
✔ Expected Behavior
I expected the expiration date/time to be at least Date.now() (maybe + 1 hour) and not an incorrectly computed or potentially previously selected date that has since past.
❌ Actual Behavior
In my case, the expiration date/time was set to over a month ago.

Other Software
No response

I'm betting it was set / looked at back in feb 24th but wasn't revisited until now looking at the code.

Covered in #32378


feat(validator): add bigint datatype validation

Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
Types of changes
What types of changes does your code introduce?
Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[x] I have read the CONTRIBUTING doc
[ ] Lint and unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works.
[x] I have added necessary documentation (if appropriate)

Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Hey @paoloevan! 👋🏻
Seems that there are two PRs adding the same feature. (https://github.com/adonisjs/validator/pull/175)
Would you mind if we go ahead with the one from MaximeMRF as it seems more complete?

Hi! Sure @RomainLanz


Imagine interations through Discord leads to "Error processing image: unexpected end of JSON input"

Apologies as this is my first time in Github.
I've built both the Stable Diffusion instance and the discord bot and the bot is able to detect the host.
Unfortunately when it comes to actually generating through the bot using /imagine, the console outputs
2022/12/25 02:29:30 Processing imagine #1056277455129825370: apple
2022/12/25 02:29:31 Error processing image: unexpected end of JSON input

I assume that the bot is able to detect the host but cannot seem to communicate with it.
Would appreciate help in troubleshooting

I think this might be due to the -host command line parameter having a trailing "/" at the end.
Instead of -host http://<IP_ADDRESS>:7860/
Try doing -host http://<IP_ADDRESS>:7860

I think this might be due to the -host command line parameter having a trailing "/" at the end.
Instead of -host http://<IP_ADDRESS>:7860/
Try doing -host http://<IP_ADDRESS>:7860

This fixed the issue, Thanks!

Awesome, no problem, glad that it worked out. And thanks for the Github issue, since it might help others that encounter this issue.


Update sklearn model uri

"Fixes #issue-number" or "Add description of the problem this PR solves"
Related to kserve/kserve#3040
Proposed Changes

/lgtm
/approve


Hybrid active/passive liquidity for spot (with a futures and perps concept)

Combine LOBs and AMM-like curves for spot.
1a, spec how passive liquidity interact with order books (this should be built, deployed)
1b, spec passive liq algo for spot (and a dummy algo for futures and perps - to prove out concept in testnet)
2, research offsite (book in 2-4 weeks time)

design a PoC/MVP passive liquidity algo for futures and perps
build something that community can refine the parameters with the PoC/MVP

This should be spiked ahead of fund accounts:

https://github.com/vegaprotocol/specs/issues/866

Once we review / validate this we can decide on bringing fund accounts back in to scope for cosmic-elevator


summonInline in a function in a quoted block causes compiler crash

Compiler version
3.3.1, 3.4.0-RC1-bin-20240109-91db06a-NIGHTLY-git-91db06a
Minimized code
// main.scala

trait SomeImplicits:
  given int: Int

def fn: Unit =
  Macro.testSummon

// macro.scala

import scala.quoted.*
import scala.compiletime.summonInline

object Macro:

  transparent inline def testSummon = ${ testSummonImpl }

  private def testSummonImpl(using Quotes): Expr[SomeImplicits => Int] =
    import quotes.reflect.*
    '{
      (x: SomeImplicits) =>
        import x.given
        summonInline[Int]
    }

Output (click arrow to expand)

  unhandled exception while running pickler on /Users/martin/development/macro-test/main.scala

  An unhandled exception was thrown in the compiler.
  Please file a crash report here:
  https://github.com/lampepfl/dotty/issues/new/choose
  For non-enriched exceptions, compile with -Yno-enrich-error-messages.

     while compiling: /Users/martin/development/macro-test/main.scala
        during phase: pickler
                mode: Mode(ImplicitsEnabled)
     library version: version 2.13.12
    compiler version: version 3.4.0-RC1-bin-20240109-91db06a-NIGHTLY-git-91db06a
            settings: -classpath /Users/martin/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/org/scala-lang/scala3-library_3/3.4.0-RC1-bin-20240109-91db06a-NIGHTLY/scala3-library_3-3.4.0-RC1-bin-20240109-91db06a-NIGHTLY.jar:/Users/martin/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/org/scala-lang/scala-library/2.13.12/scala-library-2.13.12.jar -d /Users/martin/development/macro-test/.scala-build/macro-test_3200b05eac-8a7bba9ae5/classes/main -java-output-version 17 -sourceroot /Users/martin/development/macro-test

  Exception while compiling /Users/martin/development/macro-test/main.scala, /Users/martin/development/macro-test/macro.scala

  An unhandled exception was thrown in the compiler.
  Please file a crash report here:
  https://github.com/lampepfl/dotty/issues/new/choose
  For non-enriched exceptions, compile with -Yno-enrich-error-messages.

     while compiling: <no file>
        during phase: parser
                mode: Mode()
     library version: version 2.13.12
    compiler version: version 3.4.0-RC1-bin-20240109-91db06a-NIGHTLY-git-91db06a
            settings: -classpath /Users/martin/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/org/scala-lang/scala3-library_3/3.4.0-RC1-bin-20240109-91db06a-NIGHTLY/scala3-library_3-3.4.0-RC1-bin-20240109-91db06a-NIGHTLY.jar:/Users/martin/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/org/scala-lang/scala-library/2.13.12/scala-library-2.13.12.jar -d /Users/martin/development/macro-test/.scala-build/macro-test_3200b05eac-8a7bba9ae5/classes/main -java-output-version 17 -sourceroot /Users/martin/development/macro-test

Exception in thread "main" java.lang.AssertionError: assertion failed: unresolved symbols: parameter x (line 10) #32164 when pickling /Users/martin/development/macro-test/main.scala
	at scala.runtime.Scala3RunTime$.assertFailed(Scala3RunTime.scala:8)
	at dotty.tools.dotc.core.tasty.TreePickler.pickle(TreePickler.scala:863)
	at dotty.tools.dotc.transform.Pickler.run$$anonfun$1$$anonfun$1(Pickler.scala:125)
	at scala.runtime.function.JProcedure1.apply(JProcedure1.java:15)
	at scala.runtime.function.JProcedure1.apply(JProcedure1.java:10)
	at scala.collection.immutable.List.foreach(List.scala:333)
	at dotty.tools.dotc.transform.Pickler.run$$anonfun$1(Pickler.scala:180)
	at scala.runtime.function.JProcedure1.apply(JProcedure1.java:15)
	at scala.runtime.function.JProcedure1.apply(JProcedure1.java:10)
	at scala.collection.immutable.List.foreach(List.scala:333)
	at dotty.tools.dotc.transform.Pickler.run(Pickler.scala:180)
	at dotty.tools.dotc.core.Phases$Phase.runOn$$anonfun$1(Phases.scala:354)
	at scala.runtime.function.JProcedure1.apply(JProcedure1.java:15)
	at scala.runtime.function.JProcedure1.apply(JProcedure1.java:10)
	at scala.collection.immutable.List.foreach(List.scala:333)
	at dotty.tools.dotc.core.Phases$Phase.runOn(Phases.scala:360)
	at dotty.tools.dotc.transform.Pickler.runOn(Pickler.scala:197)
	at dotty.tools.dotc.Run.runPhases$1$$anonfun$1(Run.scala:315)
	at scala.runtime.function.JProcedure1.apply(JProcedure1.java:15)
	at scala.runtime.function.JProcedure1.apply(JProcedure1.java:10)
	at scala.collection.ArrayOps$.foreach$extension(ArrayOps.scala:1323)
	at dotty.tools.dotc.Run.runPhases$1(Run.scala:337)
	at dotty.tools.dotc.Run.compileUnits$$anonfun$1(Run.scala:348)
	at dotty.tools.dotc.Run.compileUnits$$anonfun$adapted$1(Run.scala:357)
	at dotty.tools.dotc.util.Stats$.maybeMonitored(Stats.scala:69)
	at dotty.tools.dotc.Run.compileUnits(Run.scala:357)
	at dotty.tools.dotc.Run.compileUnits(Run.scala:267)
	at dotty.tools.dotc.Driver.finish(Driver.scala:58)
	at dotty.tools.dotc.Driver.doCompile(Driver.scala:38)
	at dotty.tools.dotc.Driver.process(Driver.scala:197)
	at dotty.tools.dotc.Driver.process(Driver.scala:165)
	at dotty.tools.dotc.Driver.process(Driver.scala:177)
	at dotty.tools.dotc.Driver.main(Driver.scala:207)
	at dotty.tools.dotc.Main.main(Main.scala)
Compilation failed

This issue was picked for the Issue Spree of March 19th, 2024. @EugeneFlesselle, @KuceraMartin, @nmcb will be working on it. If you have any insight into the issue or guidance on how to fix it, please leave it here.

Issue might be the same as in #19493

@Gedochao @EugeneFlesselle any updates here? This is blocking https://github.com/com-lihaoyi/scalasql from supporting Scala 3, which in future would block a number of experiments around using named tuples etc. to model database queries and the like

any updates here?

I'm still working on it -- and am pretty familiar with was is going wrong -- but I am yet to find a way to fix it.

This is blocking https://github.com/com-lihaoyi/scalasql from supporting Scala 3

Maybe this is obvious but just in case, the situation that fails is one where summonInline isn't needed, so it could be replaced with a normal summon; unless it is necessary for it to be able to resolve an implicit from both the ctx of the caller and the ctx of the body, depending on usages.

Thanks @EugeneFlesselle ! As long as you're working on it that's fine, just worried it got dropped.
As far as I know, we needed summonInline in order to resolve implicits from the context of the caller


[release/1.2] Prepare v1.2.12 release

Update the runc vendor to v1.0.0-rc10 which includes a mitigation for CVE-2019-19921.

Update the opencontainers/selinux which includes a mitigation for CVE-2019-16884.

Update Golang runtime to 1.12.15, which includes a fix to the runtime (Go 1.12.14, Go 1.12.15) and and the net/http package (Go 1.12.15)

A fix to prevent SIGSEGV when starting containerd-shim containerd/containerd#3960

Fixes to exec containerd/containerd#3755

Prevent docker exec hanging if an earlier docker exec left a zombie process
Prevent High system load/CPU utilization with liveness and readiness probes
Prevent Docker healthcheck causing high CPU utilization

CRI fixes:

Update the gopkg.in/yaml.v2 vendor to v2.2.8 with a mitigation for CVE-2019-11253

rebased, as some changes went into the branch

@dmcgowan we didn't merge yet; merge whenever you're ready

This is ready to go, I'll merge it in a bit when ready to do the release. I want to make sure the 1.3.x is also ready to go. I'll open up that PR shortly


Update to docker 1.8.1

This PR updates the Chocolatey package docker to Docker 1.8.1.

haha I was just going to do this. Thanks @StefanScherer. Right now I don't have a windows machine with me, can you please run nuget pack and send me output the package (@gmail.com) so that I can publish right away.


environments cookbook_versions must have a version specifier

I got this error while restoring my backup from a Chef10 install to a Chef11:
ERROR: The data in your request was invalid
Response: Invalid value '0.5.0' for cookbook_versions

I found that my cookbooks versions constraints where not "hard" enough when I did not accept variations (like ~>, >=, etc.) and that I've specified an exact version (like "0.5.0").
I suppose this is a change in Chef 11.
I don't know if this would be correct to filter this kind of constraints in the backup and/or restore tho.
I've fixed my enviroments JSON dumps by filtering them with this small script:
require 'json'

# fake Chef::Environment class for JSON parse
class Chef
  class Environment
  end
end

ARGV.each do |zejsonfile|
  jsonout = ""
  File.open(zejsonfile, 'r') do |zefile|
    parsed = JSON.parse(zefile.read)
    if parsed.include? 'cookbook_versions'
      parsed['cookbook_versions'].each do |cookbook, version|
        if version =~ /^\d/
          parsed['cookbook_versions'][cookbook] = "= #{version}"
        end
      end
      jsonout = JSON.dump parsed
    end
  end
  unless jsonout == ""
    File.open(zejsonfile, 'w') do |zefile|
      zefile.write jsonout
    end
  end
end

Thank you @bencaron @keivnhuang @nshenry03 - closing this since no changes are required for knife-backup


feat: Store receipts

Closes https://github.com/paradigmxyz/reth/issues/1724
Bloom is removed from main structure Receipt, and new type ReceiptWithBloom is added (it is needed for p2p/rpc). small refactor in BlockchainTree.
Receipts are saved inside db.

Codecov Report

Merging #1860 (89f6355) into main (2a457c7) will decrease coverage by 57.62%.
The diff coverage is 0.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@             Coverage Diff             @@
##             main    #1860       +/-   ##
===========================================
- Coverage   73.35%   15.73%   -57.62%
===========================================
  Files         415      415
  Lines       50661    50731       +70
===========================================
- Hits        37162     7984    -29178
- Misses      13499    42747    +29248

Flag
Coverage Δ

integration-tests
15.73% <0.00%> (-4.01%)
:arrow_down:

unit-tests
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

crates/executor/src/blockchain_tree/mod.rs
0.00% <0.00%> (-92.54%)
:arrow_down:

crates/executor/src/executor.rs
0.00% <0.00%> (-90.44%)
:arrow_down:

crates/net/eth-wire/src/types/receipts.rs
3.33% <0.00%> (-96.67%)
:arrow_down:

crates/net/network/src/message.rs
40.77% <ø> (-3.89%)
:arrow_down:

crates/primitives/src/lib.rs
90.00% <ø> (-10.00%)
:arrow_down:

crates/primitives/src/proofs.rs
0.00% <0.00%> (-97.14%)
:arrow_down:

crates/primitives/src/receipt.rs
0.00% <0.00%> (-95.10%)
:arrow_down:

crates/storage/db/src/tables/mod.rs
0.00% <ø> (ø)

crates/storage/provider/src/post_state.rs
0.00% <0.00%> (-89.98%)
:arrow_down:

crates/storage/provider/src/transaction.rs
0.00% <0.00%> (-88.43%)
:arrow_down:

... and 305 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

(Breaking change and will require resync)


Files unable to be accessed via Apache

I have mounted the files on /mnt/site/ folder using:
cd / && ./root/go/bin/goofys --uid 1000 --dir-mode 0777 --file-mode 0777 --gid 1 --region MYREGION --profile default BUCKETNAME /mnt/site/
the bucket is mounted perfectly and I am able to read files using the VI and also write.
Apache is able to read another dir but not the dir the bucket is mounted on.

you need to use -o allow_other


[Request] Docker Hub

Could this repository be copied to Docker Hub? That would allow the image to easily be accessed using the Synology Container Manager.

Hey @LoganJFisher, thanks for opening this issue, it's unfortunate that it's hard to use ghcr with that system, I will look into also publishing to the docker hub.

@LoganJFisher Just published a dev image to Docker Hub: https://hub.docker.com/r/sbondco/watcharr
There's only a few dependency updates that make the image differ from the latest production image release, so it should be safe to use for now until I can get a proper release out.
Let me know if you have any troubles!

Seems to work perfectly! Thank you for this! You were super fast to do this, which was just awesome of you. 😁

Great to hear @LoganJFisher, no problem! Hope you enjoy the app!
I'll close this issue for now, please re-open or create a new issue if you run into any other problems.


Improved Stopwatch

This version of the Stopwatch is both more clear in usage, and has dramatically better performance.

I'm closing this as stopwatch is unnecessary altogether.


Autoscroll down deactivate in output

Godot version:
3.2.1 stable mono
OS/device including version:
win10 64
Issue description:
If you print values in the "Output" window, then the window will automatically scroll so you can always see the last value printed, all OK.
But ... you finish executing the scene and scroll up in the "Output" window to see previous values, then you rerun and now the "Output" window no longer does automatic scrolling, you can no longer view values printing in real time.
To solve this you will have to manually lower the scroll of the "Output" window again towards the lower end, then now the window will automatically scroll down again when printing values.

Steps to reproduce:
1 - Print a large number of values so that the output window must scroll down.
2 - Finish the execution and scroll the scroll of the exit window upwards
3 - Run again and print values again, you can check that the output window no longer scrolls down automatically
Minimal reproduction project:

I always thought this was a feature. If you are at the end of scroll, it scrolls down. Else it stays where it is or stays at top.

In my opinion this should not be passed as a feature.
It doesn't make sense that you are printing values and the scroll does not automatically scroll down.

@Torguen Some people precisely find this to be an annoyance because you can't scroll up at all if values are being printed continuously.

I think the behavior could be:
1 - The scroll at the beginning of each execution ALWAYS automatically scrolls down if you print values.
2 - You can upload the scroll and this will make the scroll stop automatically scroll down until the next execution.

Hi,
I am trying to work on this bug. On rich_text_label, there are validate_line_caches and int first_invalid_line which I do not understand. I tried so hard to understand but it just doesn't click.
This might be obvious for some people. If it is can you kindly tell what each one does?
Thank you so much:)


Bekao/androidinputaction

Updated scenario json files with correct image links (https instead of http)
Updated ImageRenderer's async http bitmap loader so it is more robust
Refactored packages by splitting readonly, input, and action renderers into separate packages.
Implemented Inputs (Text, Number, Date, Time, Toggle, and ChoiceSet)
Implemented Actions (Http, OpenURL, ShowCard, Submit)
Renamed native library from "native-lib" to "adativecards-native-lib" and remove default generated hello function.

@bekao,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

                horizontalLine ? (int) separationConfig.getLineThickness() : LinearLayout.LayoutParams.MATCH_PARENT);

Can we re-use lineThickness variable from the above?

Refers to: source/android/adaptivecards/src/main/java/com/microsoft/adaptivecards/renderer/BaseCardElementRenderer.java:54 in d4a6511. [](commit_id = d4a65113b879b36e3ab769773c3171a1938dc384, deletion_comment = False)

            horizontalLine ? 0 : (int)separationConfig.getSpacing() /* left */,

Shouldn't this be half of the hostconfig spacing?

Refers to: source/android/adaptivecards/src/main/java/com/microsoft/adaptivecards/renderer/BaseCardElementRenderer.java:63 in d4a6511. [](commit_id = d4a65113b879b36e3ab769773c3171a1938dc384, deletion_comment = False)

:shipit:

                horizontalLine ? (int) separationConfig.getLineThickness() : LinearLayout.LayoutParams.MATCH_PARENT);

Agreed

In reply to: 314496916 [](ancestors = 314496916)

Refers to: source/android/adaptivecards/src/main/java/com/microsoft/adaptivecards/renderer/BaseCardElementRenderer.java:54 in d4a6511. [](commit_id = d4a65113b879b36e3ab769773c3171a1938dc384, deletion_comment = False)

            horizontalLine ? 0 : (int)separationConfig.getSpacing() /* left */,

Based on the website, this is the spacing between element.
https://docs.microsoft.com/en-us/adaptive-cards/display/hostconfig#separationconfig
"spacing number - spacing between elements"

In reply to: 314497963 [](ancestors = 314497963)

Refers to: source/android/adaptivecards/src/main/java/com/microsoft/adaptivecards/renderer/BaseCardElementRenderer.java:63 in d4a6511. [](commit_id = d4a65113b879b36e3ab769773c3171a1938dc384, deletion_comment = False)


Refactor static functions into helpers

Description

Removes duplicate definition camelizeKeys of ApiClientBase.ts  (it's already in utils.ts).
Move static function objectToQueryString into the utils module.
Patch a few missing awaits and remove commented code.

On what platform have you tested the change?

[ ] Android - Emulator
[ ] Android - Physical device
[ ] iOS - Emulator
[ ] iOS - Physical device

Screenshots
Please attach screenshots showing the change if relevant
Checklist

[ ] I have updated mockServer
[ ] I've added analytics as relevent
[ ] I have run npm test
[ ] I have run npm run test:i18n

Out of scope and potential follow-up
Is there any related changes that you plan to do in a follow-up PR or voluntarily excluded from the scope?

Resolved merge conflicts!


Report 91 - "Export Consolidation" cannot be scheduled (and email or ftps the file)

We need to be able to execute this process in SaaS from the job queue and send the resulting file by Email o FTPS, but in the current version (v22.2) it is impossible without having to completely duplicate the Report, the XMLPort and some other standard functions.
The problems we encountered in order to do so are the following:
a) The minimum desirable scenario would be to be able to schedule the execution from the UI, but it gives the following Error and stops when trying to download the generated file.

For other scenarios of customizations by code, we have that:
b) The InitializeRequest() function does not allow indicating the Starting / Ending Dates, the Selected Dimensions or the Main Currency.
c) Not being able to initialize these parameters from outside, the process gives an Error due to the existing checks in the "G/LAccount" event. OnPreDataItem()

d) Therefore, cannot be executed under job queue in any way [.RunModal(), .Execute(PageParameters), .SaveAs(PageParameters,...), etc]
d) Even if we managed to execute it, there is no event or RequestPage option that allows us, in SaaS, to recover the content of the file at run time to send it by Email or FTPS (for example).
We request to improve this process in future versions to cover all those scenarios and use cases.
Thanks in advance.

Hello! We have BCIDEAS forum for this kind if improvements, this is actually feature request. Please use this place if you want to get it done.

Please, at least, add the missing RequestPage fields in the InitializeRequest() function and generally avoid the ERROR that throws the background Download of files:
ExportConsolidation.InitializeRequest(
  FileFormat,
  FileName,
  ConsolidStartDate,  // missing
  ConsolidEndDate,  // missing
  ColumnDim,  // missing
  ParentCurrencyCode  // missing
);

[EventSubscriber(ObjectType::Codeunit, Codeunit::"File Management", OnBeforeDownloadHandler, '', false, false)]
local procedure OnBeforeDownloadHandlerSubscriber
(
    var ToFolder: Text;
    ToFileName: Text;
    FromFileName: Text;
    var IsHandled: Boolean;
    var Downloaded: Boolean
);
begin
    if (not GuiAllowed()) then begin
        Downloaded := false;
        IsHandled := true;
    end;
end;

Great!
The best response to solve the Bug of missing parameters in InitializeRequest() procedure.


Gosec complains when creating files with permission higher than 0600 and tests fail in the other case

What steps did you take and what happened:
After moving imageDownload function to common.go gosec started complaining about creating file with permission higher than 0600 however if we created those files with 0600 permission the test will fail.
 [/home/prow/go/src/github.com/metal3-io/cluster-api-provider-metal3/test/e2e/common.go:106] - G306 (CWE-276): Expect WriteFile permissions to be 0600 or less (Confidence: HIGH, Severity: MEDIUM)
    105: 		md5sum := strings.Fields(string(output))[0]
  > 106: 		err = os.WriteFile(fmt.Sprintf("%s/%s.md5sum", ironicImageDir, rawImageName), []byte(md5sum), 0777)
    107: 		Expect(err).To(BeNil())

What did you expect to happen:
Changing permission for 0777 to 0600 and the tests pass
Anything else you would like to add:
Environment:

Cluster-api version:
Cluster-api-provider-metal3 version:
Environment (metal3-dev-env or other):
Kubernetes version: (use kubectl version):

/kind bug

This has been discussed offline and most probably this PR will be closed.

/close


Support configuring scheme for Server

Support for a Server to optionally have a scheme. This allows for a ServerList to support instances with different schemes which enables the gradual migration to secure services without a big bang flip over.
Related to #275 which could not be accepted due to concerns about passivity. This change will allow me to extend ConfigurationBasedServerList and provide the scheme/port on construction of the Server and abstracts the ribbon client IsSecure/SecurePort properties into the individual Server instance.
Without this change I will likely be forced to fork ribbon internally, which I would really like to avoid doing. Added a plethora of tests increase the probability of acceptance.

@twicksell @elandau @qiangdavidliu @tcellucci
Can I get a general idea of where you stand on this PR? The changes are isolated to ribbon-loadbalancer which is listed[1] as one of the modules still used at scale within Netflix. I want to know if I should just give you some time or if I should move on.
[1] https://github.com/Netflix/ribbon#project-status-on-maintenance

Thanks for the contrib @mattnelson


Automated cherry pick of #8369: fix: use correct worker

Cherry pick of #8369 on release/3.2.
#8369: fix: use correct worker

Codecov Report

Merging #8372 into release/3.2 will decrease coverage by 0.52%.
The diff coverage is 0.52%.

@@               Coverage Diff               @@
##           release/3.2    #8372      +/-   ##
===============================================
- Coverage         6.71%    6.18%   -0.53%
===============================================
  Files              665      667       +2
  Lines           118971   105617   -13354
===============================================
- Hits              7983     6536    -1447
+ Misses          110378    98481   -11897
+ Partials           610      600      -10

Flag
Coverage Δ

#aFlag
6.18% <0.52%> (-0.53%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/cloudcommon/db/adminsharablevirtual.go
0.00% <0.00%> (ø)

pkg/cloudcommon/db/domain.go
2.77% <0.00%> (-0.80%)
:arrow_down:

pkg/cloudcommon/db/domainresource.go
0.00% <0.00%> (ø)

pkg/cloudcommon/db/external.go
0.00% <0.00%> (ø)

pkg/cloudcommon/db/infraresource.go
0.00% <0.00%> (ø)

pkg/cloudcommon/db/lockman/etcd.go
11.60% <0.00%> (-1.20%)
:arrow_down:

pkg/cloudcommon/db/lockman/lockman.go
15.38% <0.00%> (+3.61%)
:arrow_up:

pkg/cloudcommon/db/lockman/noop.go
0.00% <0.00%> (ø)

pkg/cloudcommon/db/managed.go
0.00% <ø> (ø)

pkg/cloudcommon/db/opslog.go
1.38% <0.00%> (-0.11%)
:arrow_down:

... and 779 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82a3e65...8943a16. Read the comment docs.


Support Swagger 2

Someone had added this task to a list of potential projects for a first-time open source contributor workshop I was running. I'm doing another one today, so just wanted to create a placeholder for this task. Thanks!
https://github.com/swagger-api/swagger-spec/blob/master/versions/2.0.md

sure no problem, hope you had a good workshop

Did you mean to close the issue? Does it have swagger 2 support yet?

nope, have not checked what's new with swagger 2 to see how difficult would it be, re-opening


[Points] Use marker manager for handling click events

Fixes #603

The reason it didn't get caught by the instrumentation tests is because this error only happens once a GeoJSON layer is added to the map. Our test data doesn't contain any GeoJSON in the feature

Verified by clicking on any pin in "example" project
@gino-m  PTAL?

CLA is stuck. Maybe you can force merge this?

CLA is stuck. Maybe you can force merge this?

Added it back manually. Merging now!


Create Playlist UX

Design Needs

Info box
Clear private / public toggle
Button states

Workflow

"create album or playlist" goes directly to playlist/edit

Info box describing what a playlist is
No ability to add tracks yet
Button says "create playlist"

Playlist/edit (for the first time after create)

No info box
Ability to add tracks shows up
Option to upload track(s) / zipfile
Minimize the metadata / title stuff
Clearly marked as private

Returning to Playlist/edit

Everything is seen, including upload

Private / View / Save button states:

Disabled Button says "Save" until something changes, then it enables
"View" button always present
Very clear private/unpublished state

Bandcamp example:

As stated in #595, would be nice to use the red private branding we use in comments.

Additional design is done here: https://www.figma.com/file/YdjrVsNumbBsWVo82Wje2h6N/alonetone-white-theme?node-id=950%3A4218


Clear French issues

Clear french sentence
Change the commands by the right commands order and words

Hi @aclerbois , your suggestions are being reviewed by our French linguistic moderator. Once he finish the review we will let you know the result.
Thanks for your support,
Microsoft C&E Localization Team

@aclerbois , Thank you for your feedback and suggestion!
The suggestion will be merged to the production, we will re-release this articles in the next loc release round.
Microsoft C&E Localization Team


Initial commit. Create Collision Detection functions

Q
A

Bug fix?
no

New feature?
yes

New sample?
yes

Related issues?
NA

What's in this Pull Request?
Create new sample.
This is a custom function for collision detection.

Thank you @koruneko for your contribution, I'll process it before the end of the week.

Thank you @koruneko, this is going to be a very useful function!


observability/kube-prometheus: allow deploy with argo

Currently, ArgoCD fails to deploy the Prometheus and PrometheusAgent
CRDs because it complains that:
"prometheusagents.monitoring.coreos.com" is invalid: metadata.annotations: Too long: must have at most 262144 bytes (retried 5 times).

To fix this, we can patch the resoruces as described in
https://github.com/prometheus-community/helm-charts/issues/3435.
Signed-off-by: Lucas Servén Marín<EMAIL_ADDRESS>

cc @leonloechner

CI is failing due to https://github.com/actions/labeler/pull/491


Snapshot does not overwrite components with Vecs in them

Hello. I've been experimenting with bevy_save for a bit. I've run into an issue where I'm attempting to use a Snapshot to restore to a previous state of a component with a Vec/Vecdeque.
When I have a component like:
    #[derive(Component, Reflect, Default, Debug, Clone, PartialEq, Eq)]
    #[reflect(Component)]
    struct Collect {
        data: Vec<u32>,
    }

Which is registered as a savable (and the Vec is registered as a type in Bevy):
        app.register_saveable::<Collect>();
        app.register_type::<Vec<u32>>();

Applying a snapshot seems to make no change to the data
I suspect it's more general than just "Vecs". But I couldn't figure it out digging through the code. I guess it has something to with the reflected data though!
I've reproduced this with a test. The first test fails, the second is succeeding as a comparison to the normal behavior. Thanks for your help!
mod tests {
    use super::*;
    use bevy_save::{AppSaveableExt, SavePlugins};

    #[derive(Component, Reflect, Default, Debug, Clone, PartialEq, Eq)]
    #[reflect(Component)]
    struct Collect {
        data: Vec<u32>,
    }

    #[test]
    fn this_does_not_work() {
        let mut app = App::new();
        app.add_plugins(SavePlugins);
        app.register_saveable::<Collect>();
        app.register_type::<Vec<u32>>();
        let world = &mut app.world;

        let entity = world
            .spawn_empty()
            .insert(Collect { data: Vec::new() })
            .id();
        world
            .entity_mut(entity)
            .get_mut::<Collect>()
            .unwrap()
            .data
            .push(1);
        let snapshot = world.snapshot();

        world
            .entity_mut(entity)
            .get_mut::<Collect>()
            .unwrap()
            .data
            .push(2);
        snapshot.applier(world).apply().unwrap();
        assert_eq!(world.entity(entity).get::<Collect>().unwrap().data.len(), 1);
        assert_eq!(
            *world
                .entity(entity)
                .get::<Collect>()
                .unwrap()
                .data
                .first()
                .unwrap(),
            1
        );
    }

    #[derive(Component, Reflect, Default, Debug, Clone, PartialEq, Eq)]
    #[reflect(Component)]
    struct Basic {
        data: u32,
    }

    #[test]
    fn this_works() {
        let mut app = App::new();
        app.add_plugins(SavePlugins);
        app.register_saveable::<Basic>();
        let world = &mut app.world;

        let entity = world.spawn_empty().insert(Basic { data: 0 }).id();
        world.entity_mut(entity).get_mut::<Basic>().unwrap().data = 1;
        let snapshot = world.snapshot();

        world.entity_mut(entity).get_mut::<Basic>().unwrap().data = 2;
        snapshot.applier(world).apply().unwrap();
        assert_eq!(world.entity(entity).get::<Basic>().unwrap().data, 1);
    }
}

Closed by #9a87ba6

If you tell me what version you are using I can backport the fix

Thanks for the quick fix.
I'm using:
bevy = "0.11.3"
bevy_save = "0.9.1"

Fix is out in v0.9.3 and should be available on crates.io, run cargo update


API returns some vulnerabilities which do not conform to the schema specification

After requesting a bunch of vulnerabilities by ID via the batch API, it seems that few of them do not match the schema specification. I've observed the following issues:
Second item in "affected"-array is lacking the mandatory ranges property
{
    "schema_version": "1.2.0",
    "id": "GHSA-7mfw-43c4-45mq",
    "modified": "2022-07-05T00:45:00.054125Z",
    "published": "2022-05-14T03:46:36Z",
    "aliases": [
        "CVE-2017-15717"
    ],
    "summary": "Cross-site Scripting in Apache Sling XSS Protection API",
    "details": "A flaw in the way URLs are escaped and encoded in the org.apache.sling.xss.impl.XSSAPIImpl#getValidHref and org.apache.sling.xss.impl.XSSFilterImpl#isValidHref allows special crafted URLs to pass as valid, although they carry XSS payloads. The affected versions are Apache Sling XSS Protection API 1.0.4 to 1.0.18, Apache Sling XSS Protection API Compat 1.1.0 and Apache Sling XSS Protection API 2.0.0.",
    "severity": [
        {
            "type": "CVSS_V3",
            "score": "CVSS:3.0/AV:N/AC:L/PR:N/UI:R/S:C/C:L/I:L/A:N"
        }
    ],
    "affected": [
        {
            "package": {
                "ecosystem": "Maven",
                "name": "org.apache.sling:org.apache.sling.xss",
                "purl": "pkg:maven/org.apache.sling/org.apache.sling.xss"
            },
            "ranges": [
                {
                    "type": "ECOSYSTEM",
                    "events": [
                        {
                            "introduced": "1.0.4"
                        },
                        {
                            "fixed": "2.0.4"
                        }
                    ]
                }
            ],
            "versions": [
                "1.0.12",
                "1.0.14",
                "1.0.16",
                "1.0.18",
                "1.0.4",
                "1.0.6",
                "1.0.8",
                "2.0.0"
            ],
            "database_specific": {
                "source": "https://github.com/github/advisory-database/blob/main/advisories/github-reviewed/2022/05/GHSA-7mfw-43c4-45mq/GHSA-7mfw-43c4-45mq.json"
            }
        },
        {
            "package": {
                "ecosystem": "Maven",
                "name": "org.apache.sling:org.apache.sling.xss.compat",
                "purl": "pkg:maven/org.apache.sling/org.apache.sling.xss.compat"
            },
            "versions": [
                "1.1.0"
            ],
            "database_specific": {
                "source": "https://github.com/github/advisory-database/blob/main/advisories/github-reviewed/2022/05/GHSA-7mfw-43c4-45mq/GHSA-7mfw-43c4-45mq.json"
            }
        }
    ],
    "references": [
        {
            "type": "ADVISORY",
            "url": "https://nvd.nist.gov/vuln/detail/CVE-2017-15717"
        },
        {
            "type": "WEB",
            "url": "https://s.apache.org/CVE-2017-15717"
        }
    ],
    "database_specific": {
        "cwe_ids": [
            "CWE-79"
        ],
        "github_reviewed": true,
        "severity": "MODERATE"
    }
}

Process finished with exit code 0

First item in the "ranges"-array is lacking an event with the "introduced" property inside it's events array
{
  "id": "PYSEC-2021-333",
  "details": "sqlparse is a non-validating SQL parser module for Python. In sqlparse versions 0.4.0 and 0.4.1 there is a regular Expression Denial of Service in sqlparse vulnerability. The regular expression may cause exponential backtracking on strings containing many repetitions of '\\r\\n' in SQL comments. Only the formatting feature that removes comments from SQL statements is affected by this regular expression. As a workaround don't use the sqlformat.format function with keyword strip_comments=True or the --strip-comments command line flag when using the sqlformat command line tool. The issues has been fixed in sqlparse 0.4.2.",
  "aliases": [
    "CVE-2021-32839",
    "GHSA-p5w8-wqhj-9hhf"
  ],
  "modified": "2021-09-23T00:11:34.256842Z",
  "published": "2021-09-20T17:15:00Z",
  "references": [
    {
      "type": "FIX",
      "url": "https://github.com/andialbrecht/sqlparse/commit/8238a9e450ed1524e40cb3a8b0b3c00606903aeb"
    },
    {
      "type": "ADVISORY",
      "url": "https://github.com/andialbrecht/sqlparse/security/advisories/GHSA-p5w8-wqhj-9hhf"
    }
  ],
  "affected": [
    {
      "package": {
        "name": "sqlparse",
        "ecosystem": "PyPI",
        "purl": "pkg:pypi/sqlparse"
      },
      "ranges": [
        {
          "type": "GIT",
          "repo": "https://github.com/andialbrecht/sqlparse",
          "events": [
            {
              "fixed": "8238a9e450ed1524e40cb3a8b0b3c00606903aeb"
            }
          ]
        },
        {
          "type": "ECOSYSTEM",
          "events": [
            {
              "introduced": "0"
            },
            {
              "fixed": "0.4.2"
            }
          ]
        }
      ],
      "versions": [
        "0.1.0",
        "0.1.1",
        "0.1.10",
        "0.1.11",
        "0.1.12",
        "0.1.13",
        "0.1.14",
        "0.1.15",
        "0.1.16",
        "0.1.17",
        "0.1.18",
        "0.1.19",
        "0.1.2",
        "0.1.3",
        "0.1.4",
        "0.1.5",
        "0.1.6",
        "0.1.7",
        "0.1.8",
        "0.1.9",
        "0.2.0",
        "0.2.1",
        "0.2.2",
        "0.2.3",
        "0.2.4",
        "0.3.0",
        "0.3.1",
        "0.4.0",
        "0.4.1"
      ],
      "database_specific": {
        "source": "https://github.com/pypa/advisory-database/blob/main/vulns/sqlparse/PYSEC-2021-333.yaml"
      }
    }
  ],
  "schema_version": "1.2.0"
}

Hi there!
Thanks for pointing these out.
Re the first example (GHSA-7mfw-43c4-45mq), the "ranges" property is not mandatory at all. Instead, this particular entry specifies exact versions in the versions array:
            "versions": [
                "1.1.0"
            ],

For the second example, that git commit example is indeed wrong. I've fixed this up in https://github.com/pypa/advisory-database/blob/main/vulns/sqlparse/PYSEC-2021-333.yaml

We've fixed that too. Please let us know if there are any more issues. Thanks!


Python version support policy

As a follow-on to #414, we should establish an official policy on what versions of Python we will support. @alubbock suggested "three most recent minor versions" which today would mean 3.5, 3.6 and 3.7. That's fine with me. We should also decide how we'll handle Python major versions, e.g. if Python 4 ever happens. :) Maybe a LTS (long-term support) model, such as:

Upon release of a new major release of Python, the PySB major version will be incremented and its support for the previous Python major version will cease immediately. The previous PySB release will go into Long-Term Support (LTS) mode, receiving only critical bugfixes while retaining support for the previous Python release. LTS releases will be maintained for N years.

Python 4 doesn't seem to be on the horizon yet, and it might turn out to be a relatively minor increment (they don't follow semantic versioning). The Python team also seem to've learned from the 2->3 debacle; a new major release isn't likely to be on the same scale as that.
All that said, it's useful for PySB users to have some certainty. I'd suggest N=2 years is reasonable. If Python 4 turns out to require only minor changes, we could choose to keep Python 3 support in the master branch as well, but I don't think that's something we can commit to until more details are known.

Our Python version support policy is up on our website, and reproduced below:

PySB will support Python 2.7 until January 1, 2020. After that date, PySB's major version number will be incremented (PySB 2.x). From PySB 2.x onward, our policy will be to support the three most recent minor versions of Python (most likely Python 3.6, 3.7, and 3.8 at time of PySB 2.x release).
Upon a new major release of Python, the PySB major version will be incremented and its support for the previous Python major version will cease immediately. The previous PySB release will go into Long-Term Support (LTS) mode, receiving only critical bug fixes while retaining support for the previous Python release. LTS releases will be maintained for 2 years.
Background
Python 2.7 will itself become unsupported from January 1, 2020, as per PEP 373, therefore our decision to end Python 2.7 support is in line with this.
We want a Python version support policy that strikes a balance between taking advantage of new Python features and providing stability. On the current Python release cycle, support for new versions would last around five years, which we feel is a reasonable length of time.
We hope this policy helps to provide clarity to PySB users. If you have comments or questions regarding this policy, please raise them on the relevant GitHub issue. Support is also available on our Gitter chat room.
-- The PySB Development Team


Disable vue-router on static site using rewrites

Summary
I am using gridsome to build language versions of my microsite. I then use server rewrites to redirect microsite.domain.tld to /tld/index.html where gridsome has created a static site per language in a folder of markdown-files. I really like this setup, but unfortunately vue-router kicks in on my static site and wants to redirect back to /index.html
[[redirects]]
from = "https://microsite.domain.tld/"
to = "/tld"
status = 200
force = true
Basic example
I would like to be able to disable vue-routing on a specific template, route or entire site, so I can avoid this behaviour, when using the server to rewrite to generated static pages.
br, Simon

To give another example (assuming it's the same issue)
gridsome create test
cd test
cat << EOF >> netlify.toml
[[redirects]]
  from = "/a/b"
  to = "/"
  status = 200
EOF
netlify dev

Visit http://localhost:8888/a/b.  Should arrive at the default content, but 404s instead.

gridsome 0.7.1
netlify-cli 12.15.0

Now realizing this exists: https://gridsome.org/docs/dynamic-routing/#generating-rewrite-rules

Is there any way to add aliases to the router?

Bump, wondering this myself

Following up here, this looks like I solved my problem by placing this in main.js. Which just pops the hash from the front of the path and redirects to the correct, un-hashed path.
router.beforeEach((to, from, next) => {
    if (to.hash.length) {
      next(to.hash.substr(1));
    } else {
      next();
    }
  });

I've started running into this problem as well if I do something like this
https://company.sitename.co.za/* https://company.sitename.co.za/profiles/:splat 200
and I navigate to
https://company.sitename.co.za/name
then it takes me to the 404.html page

I anyone is having rewrite problems with netlify, try generating sites this way
https://gridsome.org/docs/templates/#setup-templates
instead of this way
https://gridsome.org/docs/pages/#programmatic-pages
thats how I got it to work


Installation on Mac M1 Monterey 12.5.1

Hi there, I have been trying to install TMAP on my macbook pro running M1  and have tried various means after conda didn't work for me (using rosetta etc). I was wondering if anyone has managed to install this successfully?
much appreciated.
Shawn

I have the same problem. 😢

my solution using an ubuntu image via Docker, the commit after break the compilation.
RUN git clone -b development --single-branch https://github.com/reymond-group/tmap.git tmapdev
RUN cd tmapdev && git checkout 37de7b1697dd565db582cf091b83d9e252db4e31
RUN cd tmapdev/ogdf-conda/src &&  mkdir build &&  cd build &&  cmake .. -DCMAKE_BUILD_TYPE=Release   -DCMAKE_INSTALL_PREFIX=/tmp/ogdf_install -DCMAKE_CXX_FLAGS=-fPIC -DBUILD_SHARED_LIBS=ON  &&  make -j4 &&  make install &&  cd .. &&  rm -r build
RUN cd tmapdev && ln -s /tmp/ogdf_install/include /include && cp /tmp/ogdf_install/lib/aarch64-linux-gnu/*.so /lib/aarch64-linux-gnu
RUN cd tmapdev && python setup.py install

Hi @daenuprobst, thanks for putting this package together!
I have the same problem as @hoontlabs and @roman-bushuiev. I got a new M1 MacbookPro and I was trying to run some code which uses TMAP but my Jupyter kernel crashes whenever I try to import the package.
I do appreciate the docker solution that @thegodone put up, but I'd really appreciate a conda package configured for M1 Macs 🤗


[FLINK-1616] [client] Overhaul of the client.

Fix bugs with non-serializable messages
Separate parser and action logic
Clean up tests
Vastly improve logging in CLI client
Additional tests for parsing / config setup in the command line client

The two last build profiles are probably failing because the tests are checking on the output of the CLI frontend.

Except for the YARN test cases which fail, LGTM.

The -h command is not working for the actions (tested with info and run)
[root@sandbox flink-yarn-0.9-SNAPSHOT]# ./bin/flink info -h
10:28:01,440 WARN  org.apache.hadoop.util.NativeCodeLoader                       - Unable to load native-hadoop library for your platform... using builtin-java classes where applicable
The program JAR file was not specified.

Use the help option (-h or --help) to get help on the command.

The YARN application master doesn't start anymore with the following exception:
10:31:01,526 ERROR org.apache.flink.yarn.ApplicationMaster$                      - Error while running the application master.
java.lang.Exception: Missing parameter '--executionMode'
        at org.apache.flink.runtime.jobmanager.JobManager$$anonfun$parseArgs$1.apply(JobManager.scala:796)
        at org.apache.flink.runtime.jobmanager.JobManager$$anonfun$parseArgs$1.apply(JobManager.scala:790)
        at scala.Option.map(Option.scala:145)
        at org.apache.flink.runtime.jobmanager.JobManager$.parseArgs(JobManager.scala:789)
        at org.apache.flink.yarn.ApplicationMaster$.startJobManager(ApplicationMaster.scala:200)
        at org.apache.flink.yarn.ApplicationMaster$$anon$2.run(ApplicationMaster.scala:88)
        at java.security.AccessController.doPrivileged(Native Method)
        at javax.security.auth.Subject.doAs(Subject.java:356)
        at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1471)
        at org.apache.flink.yarn.ApplicationMaster$.main(ApplicationMaster.scala:58)
        at org.apache.flink.yarn.ApplicationMaster.main(ApplicationMaster.scala)

That's probably also the reason why the YARN tests are failing.

Thanks, I addressed your comments. Seems to work now.

Thank you. I'll try it again on my YARN setup later today.

Allright. I was able to start a YARN session from the frontend.
Also the -h is working now.

Manually merged in 5385e48d94a2df81c8fd6102a889cf42dd93fe2f


Add tests for all EditCommand, DeleteCommand and commands related to attendance feature

EditCourseCommand
EditGroupCommand
EditSessionCommand
EditTaskCommand
all DeleteCommand
all attendance command

Good work!


Make map codecs more resistant to erroring entries. Fixes MC-197860

This is a really simple change that I believe fixes MC-197860. More details are in the issue there, but the root of the problem is the UnboundedMapCodec's behavior in the case of erroring entries. Previously, this (along with any other BaseMapCodec implementor) would discard all valid entries after an error, while only actually reporting actual erroring entries.
This PR moves the collection of read results outside the check for the data result in the accumulator, such that all valid entries will get added to the immutable map builder, while keeping intact the behavior of the apply2stable on the actual success or failure of the result in question.

I have this issue on my singleplayer world, would love to get my nether and end dimensions avaliable again, how do I use this fix? I'm not good with code so this is probably really simple and im just dumb :D

Thank you!


Fix comments not saving

Purpose
To fix commenting on prereg submissions for admin users.
Changes
Removed deepcopy copy and used given data. deepcopy was not actually copying the dictionary correctly.
Side effects
Commenting can actually happen
Ticket
https://openscience.atlassian.net/browse/ADM-86

Good to merge when the build passes.


In-app guide: Credential Offer Screen | development

Description of feature / user story
As a new user of BC Wallet, I would like to see a description of important features in the wallet so that I have a good understanding on how to use it
Acceptance Criteria
Given the holder has received a credential for the first time
and the holder has enabled in-app guides
When they open the credential offer
Then they are presented with an in-app guide that describes how credential offer works
Given the holder has dismissed (tapped done) the in-app guide
When they are presented with a proof credential offer
then they are NOT presented with the in-app guide again.
Wireframes or relevant image assets / links
https://xd.adobe.com/view/97441d12-756f-4bff-897d-b1bf29ed7c65-c217/screen/c275c7e7-3eba-4bd1-9c0a-81f4c626b338/

Looks good. Closing.


Fix for TIFF with unassociated alpha

If read_scanlines (et al) was called with the 'format' parameter as
TypeUnknown -- which is supposed to mean "use the native format" -- would
accidentally and silently fall through the switch statement inside
OIIO::premult(), causing it to do nothing.
If called with an explicit type, it all worked find. Subtle to track down.
The particular symptom was that if you were calling ImageBuf::read()
with force=true but relying on the default convert value of UNKNOWN
(meaning, no conversion, stay in native format), it would trigger this
bug and neglect to premultiply the unassociated colors.

LGTM


Homebrew on M1 installs in /opt/homebrew, not /usr/local

Our ci/kokoro/macos/* scripts need to be aware of this sometimes. brew config | grep HOMEBREW_PREFIX will show the setting on either machine.
See also https://github.com/Homebrew/brew/pull/9117 and https://brew.sh/2020/12/01/homebrew-2.6.0/#post

We could also use brew --env --shell=bash to set the appropriate environment in the build scripts.


[misc] Change code to avoid Spotbug "false positive"

ZNodeToMapParser:
try (CuratorFramework client = CuratorFrameworkFactory.newClient(...)) {
    client.start();
...
}

After version 4.3.0 and with Java 11 (not with Java 8(!) ) Spotbug generate false positive warning CN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE on this client.start() call.
Solution is to change the code using CuratorFrameworkFactory.Builder instead of newClient()

done.


Number.parseInt and Number.parseFloat missing from es6 polyfills

Some static methods of Number are implemented in com/google/javascript/jscomp/js/es6/number/, but parseInt and parseFloat are absent. Simple polyfill code is given in MDN: parseInt, parseFloat.

@shicks do you want to add these in?

It should be fine to add them.


Current pypi version broken for current wagtail

Please upload a new pypi build, the last commit from master didn't make it into the current 4.0.1 build I think. But without this commit (from PR #98), the templates crash on new wagtail versions. Of course, the workaround is to install it from github, but I'd still love an updated pypi build. Thanks!

thanks for letting us know, released in 4.1.0


chore: update package dependencies

Updating all out-of-date [dev]dependencies.  The two major ones are eslint and prettier.
This also switches to eslint's flat config file format, which is always a "fun" exercise.  On this occasion, because we're using StandardJS, I ran into this issue.  And I guess there's some opensource clownery going on in that project where the current published version of eslint-config-standard  is broken but there's some debate over governance or... something?  I dunno, I spent way too much time trying to figure out what was broken, and then why it can't be fixed, and then why the project had to be forked, then trying to figure out how to get the fork of the project working here.
And if anyone from StandardJS or NeoStandard ends up reading this... I WANT THE LAST TWO HOURS OF MY LIFE BACK, PLEASE!

/me grants @broofa two extra hours of life and asks for forgiveness – will try to make up for it


material-ui.com website 3.9.3 not working in IE11

When I browse https://material-ui.com/demos/app-bar/ I get the error message: An unexpected error has occurred.

[ x] This is not a v0.x issue.
[x ] I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior 🤔

https://material-ui.com/versions/ is working for browser IE11
Important Info: https://v3-9-0.material-ui.com/demos/app-bar/ or https://v3-9-0.material-ui.com/versions do not show this issue.
Current Behavior 😯

https://material-ui.com is showing an error message in browser IE11
Steps to Reproduce 🕹

Link:

https://material-ui.com/demos/app-bar/
https://material-ui.com/versions/

Context 🔦

the console shows the following:
TypeError: [object Object] is not iterable!
   {
      [functions]: ,
      __proto__: {
         [functions]: ,
         __proto__: {
            [functions]: ,
            __proto__: { },
            message: "",
            name: "Error"
         },
         message: "",
         name: "TypeError"
      },
      message: "[object Object] is not iterable!",
      name: "TypeError",
      stack: "TypeError: [object Object] is not iterable!
   at e.exports (https://material-ui.com/_next/static/chunks/commons.891b7f353281c08e4ebe.js:85:33961)
   at Anonymous function (https://material-ui.com/_next/static/chunks/commons.891b7f353281c08e4ebe.js:9:4000)
   at Anonymous function (https://material-ui.com/_next/static/chunks/commons.891b7f353281c08e4ebe.js:9:3470)
   at n.callback (https://material-ui.com/_next/static/chunks/commons.891b7f353281c08e4ebe.js:103:76163)
   at fo (https://material-ui.com/_next/static/chunks/commons.891b7f353281c08e4ebe.js:103:45727)
   at co (https://material-ui.com/_next/static/chunks/commons.891b7f353281c08e4ebe.js:103:45479)
   at uu (https://material-ui.com/_next/static/chunks/commons.891b7f353281c08e4ebe.js:103:94448)
   at iu (https://material-ui.com/_next/static/chunks/commons.891b7f353281c08e4ebe.js:103:89853)
   at ou (https://material-ui.com/_next/static/chunks/commons.891b7f353281c08e4ebe.js:103:89198)
   at Qi (https://material-ui.com/_next/static/chunks/commons.891b7"
   }

Your Environment 🌎

Tech
Version

Material-UI
v3.9.3

React

Browser
Internet Explorer 11 (11.648.17134.0)

TypeScript

etc.

Duplicate of #14774


ROX-12185: Hide NP-Guard integration behind a feature-flag

Description
This PR adds a runtime feature-flag ROX_ROXCTL_NETPOL_GENERATE that controls whether the command roxctl generate netpol is available or not.
Checklist

[x] Investigated and inspected CI test results
[x] Unit test and regression tests added
~[ ] Evaluated and added CHANGELOG entry if required~
~[ ] Determined and documented upgrade steps~
~[ ] Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)~

Testing Performed

[ ] CI
[x] Locally

$ ROX_ROXCTL_NETPOL_GENERATE=true bin/darwin/roxctl generate netpol
ERROR:  accepts 1 arg(s), received 0

$ bin/darwin/roxctl generate netpol
ERROR:  unknown command "generate" for "bin/darwin/roxctl"
ERROR:  Run 'bin/darwin/roxctl --help' for usage.

$  bin/darwin/roxctl generate
ERROR:  unknown command "generate" for "bin/darwin/roxctl"
ERROR:  Run 'bin/darwin/roxctl --help' for usage.

@vikin91 Please rebase on master

@vikin91 Please rebase on master

I will, but I think my bats tests are also failing currently. I will resolve them first.

I fixed the tests and rebased. Let's see what CI says now.

/retest-required


Notebook cell toolbar edit/stop edit button switches position

I keep trying to toggle that on and off, and I keep ending up splitting the cell because the button changes position
/cc @rebornix @misolori

Given that the split cell is already on a different position that should stay the same which will allow the edit/done button to stay in the same spot.


await dialogContext.continueDialog() returns null

Versions
What package version of the SDK are you using: 4.3.4
What nodejs version are you using: 13.2.0
What browser version are you using: //
What os are you using: Windows 10 1903
Describe the bug
const dialogContext = await this.dialogs.createContext(turnContext);
const results = await dialogContext.continueDialog();

with dialogs being a DialogSet and turnContext the parameter from the onTurn method. While on the first dialogs results.status is correctly "empty" or "waiting" at some point after calling a ChoiceInput dialog, results will be null
To Reproduce
I'm not be able to reproduce it without showing the full code (and I can't) but it would be enough to understand in which cases it can return null
Expected behavior
The docs states it can return undefined or a working object https://docs.microsoft.com/it-it/javascript/api/botbuilder-dialogs/dialogturnresult?view=botbuilder-ts-latest
Screenshots
Additional context
[bug]
Regards,
Samuele

@Samuele I'm not seeing anything in the SDK that jumps out that would cause continueDialog to return null.

If you upgrade your botbuilder/botframework packages, does this still occur?
Are you calling endDialog(null) anywhere?
Although you can't share your code, can you share the exact flow? Something like:

User joins chat ->
  Bot sends welcome message ->
    User says anything ->
      Bot begins Waterfall dialog. First step is Choice prompt ->
        User enters a valid choice. continueDialog returns null

...or whatever the actual flow is. I'd like to try to replicate this so I can dig into it more and see what the cause of this might be.

Hi @mdrichardson thanks for the answer.
I tried different versions of Node.js and BotFramework and I also update all the packages of the project but the error still occur and there is no "endDialog(null)".
The current flow is:

Ask User for language -> Choice Prompt
Ask user how can be helped -> Choice Prompt
Check if the user is in the database. If yes, ask user if he wants to use the saved data. If no, it takes another path.

If the user data is not in the database, ask user the following information:
4) Name -> Text Prompt
5) Email -> Text Prompt
6) Phone Number -> Number Prompt
If the user accept the saved data, skip the previous steps and jump directly to these:
7) Problem Title -> Text Prompt
8) Ask the user if he wants to send audio of the problem -> Choice Prompt
9) If Yes, send audio -> Attachment Prompt
10) If no, send text -> Text Prompt
11) Ask Problem priority -> Choice Prompt
Here, If the user is in the database, whatever is the answer at the step 3, continueDialog() return null and the flow breaks.
Instead, if the user is not in the database, there is no errors and the bot flow continue fine with the other dialogs:
12) Ask user company -> Text Prompt -> Save all user data to database
13) Ask if user wants to send images of the problem -> Choice Prompt
14) If yes, ask images -> Attachment Prompt
15) If no, ask if user wants to send other useful files -> Choice Prompt
16) If yes, ask file -> Attachment Prompt
17) If no, ask user to send the email with the user data -> Choice Prompt
If yes send email else no.

Ask user to maintain the user data or delete it.
End dialog with message. (endDialog(message))

@samueleorfei So, it breaks at step 3 if the user is in the database, before being able to move onto the next step?
This is really difficult to debug without seeing code. I think, at a minimum, it would be helpful to see the code around continueDialog() and the entire dialog around checking if the user is in the database (feel free to remove or obfuscate sensitive code).
I believe I've seen this issue before if you end a prompt or dialog with simply await <xyz> and not return await <xyz>. That shouldn't make a difference, but I have seen this occur with that.

@mdrichardson I just discovered the problem. It was just a string mismatch between the actual Dialog name and the called one, so it was calling a non existing dialog only when the user data was present. But I still don't get why it returns null instead of undefined or any other behaviour that allows me to understand what's going on

@samueleorfei Glad you figured it out! I'm not sure why it would return null, either. I'd imagine it lies somewhere pretty deep in the code. Do you have a repo you can link me to that can reproduce the issue? If so, I'd be happy to dig into it.


Stringify event name to work with symbols correctly

This PR fixes devtools functions to work with symbols correctly. Now it puts symbolic properties as Symbol(propertyName):

Released in 0.8


Add support to MasterCard's 2-Series BINs

Here are some details regarding MasterCard's 2-Series BINs:
https://icepay.com/2016/08/04/mastercard-introduces-new-2-series-bin-range/

Coverage remained the same at 99.104% when pulling 800dded29e41211080af72e544342b591b894415 on andyautida14:master into 9208844cd702bf2f1501961b8eda2fd4dc161559 on chriso:master.

Thanks.

The tests currently fail with:
  1) Validators should validate credit cards:
     Error: validator.isCreditCard(2222155765072228) failed but should have passed
      at test/validators.js:19:15
      at Array.forEach (native)
      at test (test/validators.js:14:19)
      at Context.<anonymous> (test/validators.js:1588:5)

Actually nm, you need to update src/lib/isCreditCard.js rather than the compiled lib/isCreditCard.js.


[VTA] [Chisel] Improved Data Gen, Added ALU Test

Added files for easier data generation
Added ALU Unit test,
all tests passed

hmm I'm not sure about that, I didn't modify anything in it.

Could you update your upstream branch and rebase to the branch used in this PR?


Nvidia drivers not found by flatpak installation of Nuvola

Basic information

Your Linux distribution and its version: Fedora 29
Your desktop environment: GNOME
Nuvola Runtime version: 4.14.0 (0-g0b8ac86)
The web app you use and its version: Google Play Music 6.2.0 (0-g2dc3f5a)

Describe the bug
Can't launch the application due to start-up check failing on:

Graphics driver 'nvidia-410-73' for Flatpak has not been found on your system. Please consult documentation on graphics drivers to get help with installation.

Debugging log
Runner: [DEBUG Δ012038us GVFS-RemoteVolumeMonitor] Error: GDBus.Error:org.freedesktop.DBus.Error.ServiceUnknown: org.freedesktop.DBus.Error.ServiceUnknown

Runner: [DEBUG Δ002761us  GVFS] cannot open directory /usr/share/gvfs/remote-volume-monitors: Error opening directory “/usr/share/gvfs/remote-volume-monitors”: No such file or directory
Runner: [DEBUG Δ001936us  GVFS] org.gtk.vfs.MountTracker.listMountableInfo call failed: GDBus.Error:org.freedesktop.DBus.Error.ServiceUnknown: org.freedesktop.DBus.Error.ServiceUnknown (g-dbus-error-quark, 2)

Gtk-Message: 16:04:03.623: Failed to load module "pk-gtk-module"
Gtk-Message: 16:04:03.625: Failed to load module "pk-gtk-module"
Runner: [DEBUG Δ081612us Nuvola] AboutDialog.vala:54: Nuvola Apps 4.14.0 (0-g0b8ac86)
Runner: [DEBUG Δ000026us Nuvola] AboutDialog.vala:56: Google Play Music script 6.2.0 (0-g2dc3f5a)
Runner: [DEBUG Δ000024us Nuvola] AboutDialog.vala:60: Diorite 4.14.0
Runner: [DEBUG Δ000039us Nuvola] AboutDialog.vala:62: Chromium 70.0.3538.77
Runner: [DEBUG Δ003809us DioriteGtk] DesktopShell.vala:239: Shell: gnome shell 3.30.1, CSD 1, appmenu 1, menubar 0
Runner: [DEBUG Δ066934us Nuvola] Connection.vala:121: Network Proxy: system settings
Runner: [DEBUG Δ220837us Nuvola] AppRunnerController.vala:117: Scale factor: 1
Runner: [DEBUG Δ011653us Nuvola] FormatSupport.vala:86: Trying to play /app/share/nuvolaruntime/audio/audiotest.mp3.
Runner: [DEBUG Δ000753us DioriteGtk] Application.vala:255: XFCE session vanished: org.xfce.SessionManager
Runner: [DEBUG Δ000285us Nuvola] FormatSupport.vala:86: Pipeline state changed from NULL to READY.
Runner: [DEBUG Δ000113us Nuvola] Graphics.vala:47: Nvidia 410.73, i915 0, bumblebeed 0 => ignored 0
Runner: [WARNING Δ000096us Nuvola] StartupWindow.vala:146: opengl-driver-message: Graphics driver 'nvidia-410-73' for Flatpak has not been found on your system. Please consult documentation on graphics drivers to get help with installation.
Runner: [DEBUG Δ010089us Nuvola] FormatSupport.vala:86: Pipeline state changed from READY to PAUSED.
Runner: [DEBUG Δ000420us Nuvola] FormatSupport.vala:86: Pipeline state changed from PAUSED to PLAYING.
Runner: [DEBUG Δ007049us Nuvola] FormatSupport.vala:86: End of stream for file /app/share/nuvolaruntime/audio/audiotest.mp3.
Runner: [DEBUG Δ004170us Nuvola] StartupCheck.vala:164: Checking requirements with Chromium 70.0.3538.77
Runner: [DEBUG Δ000054us Nuvola] Traits.vala:62: Feature[MSE] -> DRT_REQUIREMENT_STATE_SUPPORTED
Runner: [DEBUG Δ000026us Nuvola] Traits.vala:62: Codec[mp3] -> DRT_REQUIREMENT_STATE_SUPPORTED
Runner: [DEBUG Δ000028us Nuvola] Traits.vala:62: Chromium[65] -> DRT_REQUIREMENT_STATE_SUPPORTED

Additional context
The correct version of GL driver is registered with Flatpak:
$ cat /sys/module/nvidia/version
410.73
$ flatpak --gl-drivers
nvidia-410-73
default
host

Indeed the driver doesn't appear to be mounted:
$ flatpak run --command=ls eu.tiliado.NuvolaAppGooglePlayMusic /usr/lib/GL
OpenCL

However, it is fine on other applications:
$ flatpak run --command=ls org.freedesktop.GlxInfo /usr/lib/GL
glvnd  nvidia-410-73  vulkan

$ flatpak run --command=ls org.gnome.Platform/x86_64/3.28 /usr/lib/GL
glvnd  nvidia-410-73  vulkan
$ flatpak run --command=ls org.gnome.Platform/x86_64/3.30 /usr/lib/GL
OpenCL
$ flatpak run --command=ls org.freedesktop.Platform/x86_64/1.6 /usr/lib/GL
glvnd  nvidia-410-73  vulkan
$ flatpak run --command=ls org.freedesktop.Platform/x86_64/18.08 /usr/lib/GL
OpenCL

It seems that the extension point for GL drivers was moved to /usr/lib/x86_64-linux-gnu/GL. What does show this command?
flatpak run --command=ls org.freedesktop.Platform/x86_64/18.08 /usr/lib/x86_64-linux-gnu/GL

$ flatpak run --command=ls org.freedesktop.Platform/x86_64/18.08 /usr/lib/x86_64-linux-gnu/GL
glvnd  nvidia-410-73  vulkan

It should be now fixed. Could you check it?
flatpak update --system && \
flatpak update --user && \
flatpak run eu.tiliado.NuvolaAppGooglePlayMusic//stable

Works fine now. Thanks @fenryxo!

Hi, I have the same issue in September 2020 now. But the solution by fenryxo is still working. Thanks!

I should add it to user documentation then.

Added here: https://github.com/tiliado/nuvolaruntime/wiki/Graphics-Drivers


[Question] Best practises to track inputs and predictions?

Hello,
I am seeking advice on the best practices for tracking all inputs and predictions made by a model when using Triton Inference Server. Specifically, I would like to track every interaction the model handles, including input data and the corresponding predictions.
I have reviewed the documentation about Triton Server Trace, but it is unclear if this feature can track predictions as well. You can find the documentation here: Triton Server Trace Documentation.
Additionally, I am concerned about the impact of tracking on system latency. While I am aware that solutions for traditional ML platforms (such as Seldon-Core) often use technologies like KNative and Kafka to store tracking information, it is not clear how these approaches can be integrated with Triton without compromising performance.
I would appreciate recommendations on:

How to effectively track inputs and predictions in Triton Inference Server.
Whether Triton Server Trace can be utilized for this purpose, and if so, how.
Alternative methods or best practices for tracking interactions in Triton while maintaining low latency.

Thank you for your assistance.

I don't really understand your question. Could you explain more? For "track all inputs and predictions", do you mean the input token/context and the generated token? If so, what do you mean the "track"? Currently, we have returned full inputs tokens and output tokens.

Hello @byshiue
I am asking if there is a way to store all the input data (for example, the payload sent to the model to generate a prediction) and the model response using the previous payload in order to analyse the model behaviour and track all the interactions.
This is an example of the requested funtionality but using another tool: https://docs.seldon.io/projects/seldon-core/en/latest/streaming/knative_eventing.html


feat(client-debugger): Differentiate IDebuggerMessage and ISourcedDebuggerMessage

Description
Separates IDebuggerMessage into IDebuggerMessage (without the source property) and ISourcedDebuggerMessage (with it).
This is prep work split from #14628 to make that one easier to review. The changes there leverage the move of the source property so message senders don't need to provide it when creating their messages, as it gets stamped automatically by the "pipes" that take care of message passing.
This was mostly a rename-all, with a few adjustments needed in exports.

Should the various message interfaces be standard IDebuggerMessages, rather than sourced ones? Otherwise we won't be able to send them unsourced to the message relay, etc. Or will that change come later?

Yeah, I was planning to make that a separate step so this was also easy to review as basically just a rename. I'll hold on merging this until we merge #14507, so I can apply the change to the new messages from that one.

Now that Ji's and Tong's PR were merged into main, I updated this PR to make the necessary adjustments on the new messages from those two PRs. I'll merge it once CI passes.


Set descriptions for topics

The frontend app is currently generating fallback descriptions for topics. This migration adds the same description to the database, so that we don't need special code in frontend or rummager.
We need to run rake rummager:index_topics after deploying this change.
Before

After

This needs collections to be deployed before it can be merged.
Otherwise looks good to me.


To add calculator for Vector Subtraction

Describe the solution you'd like

I would like to add calculator for Vector Subtraction.

Hi, I want to work on this issue I will start working on it as soon as I get assigned!! I am a part of GSSoC'21.
Kindly assign this issue to me!
Discord Username : Abhijeet Sinha(P)
Discord Tag: #4018


integrate register information to the pipeline

Register oscar is available at https://huggingface.co/datasets/mhtoin/register_oscar/
The data are in language-specific files in jsonl. Each line has a structure of: {id: integer, labels: [label, label], text: document}, where id is the integer id in the original Oscar dataset file, labels are a list of the predicted register labels for that document, and text is the text for the document in the original Oscar dataset file.
Can be read in python3 with something like
for line in sys.stdin:
    parsed=json.loads(line)
    print(parsed["id"], parsed["labels"], parsed["text"])

We could integrate access to the HF repo in this file data_tooling/ac_dc/oscar_sample_filter.py.

@mavela , what do you think about sampling say in equal proportions over the various labels, so that we get an equal number of novels, how_to, etc. We can combine this with perplexity sampling. Wdyt? In this way we can reduce our dataset but still keep the variety and quality of the data.

Sounds like a good idea! The only thing I wonder about is the register distribution in the sampled data. Now the distribution reflects (somewhat) what is found online. Would it be useful to keep and do a stratified sample instead of equal class sizes?

I think a stratified sampling would be better but I don’t know what proportions we want :) should we try to match proportions of other datasets like those trained for gpt3 etc?

On Nov 3, 2021, at 8:44 AM, mavela @.***> wrote:

Sounds like a good idea! The only thing I wonder about is the register distribution in the sampled data. Now the distribution reflects (somewhat) what is found online. Would it be useful to keep and do a stratified sample instead of equal class sizes?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.

good point :) We can put running a frequency counter for the labels...? Then we'd get their distribution from the data.

Yup. That would be the easiest way. Like a running average. Samples by some proportion that matches what we think is another dataset after perplexity sampling.

On Nov 3, 2021, at 10:46 AM, mavela @.***> wrote:

good point :) We can put running a frequency counter for the labels...? Then we'd get their distribution from the data.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.

Maybe a running count. Not average. My mistake.

On Nov 3, 2021, at 10:46 AM, mavela @.***> wrote:

good point :) We can put running a frequency counter for the labels...? Then we'd get their distribution from the data.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.

No worries, gotcha!

I think it might be too late now, but when we rerun this script on all of OSCAR again, maybe we can keep the prob of each label. Like NA 0.8, IN 0.2
Just for documentation: Narrative (NA),
Informational Description (IN), Opinion (OP),
Interactive Discussion (ID), How-to/Instruction
(HI), Informational Persuasion (IP), Lyrical (LY)
and Spoken (SP)

I so agree. We actually are printing the scores for some other run now, but didn't think about this when we were running Oscar. Live and learn... But actually hey, we can do this for the couple of BS project languages we are starting to run now!

@HugoLaurencon @olinguyen no we have a way to sample based on these registries? Like, given the meta-info about how many items are NA, we want to sample 20%-25% after we do the perplexity sampling?

@HugoLaurencon @olinguyen no we have a way to sample based on these registries? Like, given the meta-info about how many items are NA, we want to sample 20%-25% after we do the perplexity sampling? Something like...
def filter_for_registry(line, registry):
   if keep_based_on_perplexity(line):
       if random.random() <= self.perpleixty_percentage[registry]:
           return line
   return None

We don’t want to do drop random good examples during the filtering process, but maybe during the training, and this will be done easily by the modeling team.

Good to integrate the register and if the dataset also contains the original text, we can simply start the process from this dataset.
@ontocord & @mavela sampling on the register is an interesting idea. It would probably need extra care and should probably not be done in the early filtering stage.

I agree. We need experimentation. It should be done in later stages. I don’t think it’s something that would be done at training time though. It should be done at tokenization time.

On Nov 13, 2021, at 4:49 PM, ggdupont @.***> wrote:

Good to integrate the register and if the dataset also contains the original text, we can simply start the process from this dataset.
@ontocord & @mavela sampling on the register is an interesting idea. It would probably need extra care and should probably not be done in the early filtering stage.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.

Sounds good. Here's a link to the register distributions in the languages: https://docs.google.com/document/d/1AdQdGTqtaoH_EJzOR3Egg2EPT_GmEv1IhA4CIFS_4Sk/edit?usp=sharing
This will help to do stratified sampling when the time comes.

We should include the info from the above document as metadata I think.

Following up on the progress of this @ggdupont and @HugoLaurencon

@mavela and @sbmaruf  see this issue and https://github.com/bigscience-workshop/data_tooling/issues/71. We need to run the registry information for yoruba and basque from mc4 I think because we don't have enough in OSCAR. Any other languages we want to run the registry for that we can download from mc4? We will probably want to put the data under a different repo than https://huggingface.co/datasets/mhtoin/register_oscar. Maybe https://huggingface.co/datasets/mhtoin/register_mc4 ?


Add completion callback for applying scene updates

It would be nice to be able to get a callback when scene updates complete (after calling applySceneUpdate) in the event you wish to update/add/remove certain UI elements based upon if the map is changing or not.

This is not ios specific I guess. Should we remove that tag?

Sure! I just noticed it on iOS so I didn't know if it was specific or not :)


generated kustomize.yaml is not valid yaml

i'm running yamllint on all manifests as github action.
the generated kustomize.yaml starts with a newline. it should either start with the first key, or even better with ---
My pull request https://github.com/fluxcd/terraform-provider-flux/pull/351 is fixing it.

Closing, see https://github.com/fluxcd/terraform-provider-flux/pull/351#issuecomment-2044692422 for justification.


Change font

This is gonna be a silly question, but I've been looking for a way to change the default for the fancy book, but I'm not able to find the option to do so.

Try something like this:
diff --git a/fancy_book.lua b/fancy_book.lua
index 9d61ef7..28f1df0 100644
--- a/fancy_book.lua
+++ b/fancy_book.lua
@@ -6,6 +6,7 @@ package._name = "fancy_book"
 function package:_init()
   base._init(self)
   self:loadPackage("lorem")
+  SILE.settings.set("font.family", "Familyname", true)
 end

 function package:registerCommands ()

You may also need to call a font command at least one. You can avoid doing this is your document by adding it to the :_init() function too like SILE.call("font").

These solutions didn't work. I also tried running SILE.call("font", { family = "Noto Sans Masaram Gondi" }) and it didn't work either.

If you are using Docker, did you make sure your font of choice was either:

installed in the Docker Container,
in your project's fonts directory,
or mount some directory with the font into the container at run time?

If you want to reset the other fonts there are some command you can redefine. This example was for setting the default base serif font used where no other style commands set something else. If that isn't what you are testing lets at least make sure this works first.

If you are using Docker, did you make sure your font of choice was either:
* installed in the Docker Container,

* in your project's `fonts` directory,

* or mount some directory with the font into the container at run time?

That was the problem. Once I created the fonts directory that fixed it.


Reviewer 2: Comment 13 & Comment 15: Explain Validation

page 23: "However, such exercises are more likely to bring into relief the differences between the modeling paradigms than supply substantial QA and validation.": Right, the QA and validation should be done prior to that exercise. How? This should be better illustrated.

page 23: "Taken together and strictly adhered to, they present a fortress to protect against poorly designed or otherwise undesirable code. », it would be nice to know what is sufficient for validating a software.

[ ] Note that this comment is somewhat in conflict with other comments made by the same reviewer (concerning shortening discussion of the software.)
[ ] Is it possible to flesh out this statement with a reference to QA and validation where it is discussed elsewhere?

Other solutions to this comment are welcome. I'm not sure how to satisfy this one without submitting an entire article on methodologies for validation techniques in simulation science. . . based mostly on the section of this paper in question....

We should maybe remove the However, such exercises are more likely to bring into relief the differences between the modeling paradigms than supply substantial QA and validation. sentence. We should frame validation in terms of the simulation platform, not the physics, which is what I believe this reviewer wants. The best "validation" we have is the Lotka-Volterra simulations.
I think explicitly saying that V&V for a simulation kernel is a different exercise than V&V for a physics code may be needed. We can then highlight that because of our separability, physics-based V&V concerns can be addressed explicitly and separately.