How to get doc for relations fields?

I tried
// Collection
Penalty:{
   _id : "001"
   ..........
}
Product:{
   .............
   penaltyId: "001"
}
-----------------------
// Server
PublishRelations('product', function (proId) {
    let penalty = this.join(Penalty);
    penalty.selector = function (_ids) {
        return {_id: _ids};
    };

    this.cursor(Product.find({_id: proId}), function (id, doc) {
            penalty.push(doc.penaltyId)
        }
    );

    penalty.send();

    return this.ready();
});
----------------------
// Router
FlowRoutes.route('/disbursement/:productId', {
    name: 'disbursement',
    title: 'Disbursement',
    subscriptions: function (params, queryParams) {
        this.register('product', Meteor.subscribe('product', params.productId));
    },
.............
// Client
...helpers({
    product(){
        let pro = Product.findOne(FlowRouter.getParam('productId');
        console.log(pro); // get product doc only (don't have penalty doc)
        return pro;
    },
})

How to find penalty doc relation?

In the Penalty collection. When you do penalty.send(); the package send all documents in a single query.
product () {
  let pro = Product.findOne(FlowRouter.getParam('productId');
  let penalty = Penalty.findOne({_id: pro.penaltyId});
  return pro;
}

// {_id: _ids} is the default selector, so you don't need to write it
penalty.selector = function (_ids) {
  return {_id: _ids};
};

Look great.
Could I embedded penalty document in product or not?
I don't want to use this:
let penalty = Penalty.findOne({_id: pro.penaltyId});

versions back the package allows embedded documents but I remove it for performance reasons, it is not very efficient compared to send each document to their respective collection (mainly to handle the reactivity and avoid many queries).

Thanks again, I close this.


Create a domain transfer run book

Background
Create a runbook with notes and tips on how to conduct a transfer of a domain.

New run book added to site: https://operations-engineering.service.justice.gov.uk/documentation/runbooks/dns/domain-transfer.html
Still in WiP


Hand tracking Quest 2: InputActionReferences Select and SelectValue not firing action.performed

Describe the bug
@Zee2 showed me how to trap InputActionReferences directly, without doing difficult things like looking up controllers. I detailed what I did here . This works fine on HoloLens2. This does not seem to work on  Quest2. This puzzles me a bit as all other interactors seem to be working fine. Using the controllers, it works fine
Expected behavior
I expect the Select and SelectValue's action.performed to be triggered on the Quest 2 as well when I use hand tracking and perform an 'air tap'
Setup

Unity Version 2020.3.35f1
MRTK Version 3 Pre 9
Mixed Reality OpenXR plugin 1.4.3

Target platform

Quest 2

Additional comments
If requested, I can deliver a full working repo

ISSUE MIGRATION
Issue migrated from: https://github.com/microsoft/MixedRealityToolkit-Unity/issues/10856

Original comment by:
 Zee2

Hey @LocalJoost ! This is actually because Quest (the device itself) doesn't actually generate any input/interactions from their hands, unlike other platforms like HoloLens. So, from the Input System's perspective, unless you go query Facebook-specific OpenXR extensions, there's literally no action at all  :(
Right now, the way we get around this is by "polyfilling" the missing input in our ArticulatedHandControllers. Basically, if there's no interaction profile/input actions bound for Select, we read joints from our subsystem and fill in the missing information. So, the XRController's selectInteractionState will always be correct, regardless of what is going on with the input actions.
I'm aware this is significantly less nice than just binding to the input action...
This was sort of the "quick and dirty" approach, because a more robust way to "polyfill" this would be by actually spinning up "fake" input devices for hands without input actions (i.e., there'd be an entire synthetic input device that would stand in for the missing interaction profile).
In the future, we will end up getting actual input actions/bindings from Quest for hands. There's actually a cross-vendor OpenXR extension currently in draft (maybe actually ratified by this point? @keveleigh ) that will get us nice pinch/grab/point/etc actions no matter the vendor of hand; the Hand Interaction Profile!
I'm going to close for now as "known, won't fix" but this will be improved in the future, either with a more comprehensive polyfill (that actually creates an input device) and/or the platform itself submitting interaction profiles/bindings when the new Hand Interaction Profile is ratified and implemented.

Original comment by:
 LocalJoost

Thanks for the clear explanation. So this only works when you are interacting WITH something. The actual gesture does not generate any events. Do I understand that correctly?

Original comment by:
 Zee2

The flow of input in MRTK3 generally works as follows:
OpenXR device implements an interaction profile, which is essentially a spec for what sorts of user actions a device can generate. This includes poses, buttons, triggers, tracking state, velocities, etc.
These interaction profiles then bind to specific input action references in Unity. For example, we have a Select input action that things like trigger or primaryButton will bind down to.
The XRControllers on the rig listen to these input actions, and then tell the interactors to fire when the input actions do.
This is the ideal situation. The problem is that some devices (like Quest hands!) don't implement an interaction profile! This means that the hands can have joint data (i.e., the individual joint poses), but they don't actually bind to an input action. By default, Quest doesn't submit an actual input "control" for something like "pinch". Therefore, there's nothing that gets bound to our Select input action!
We resolve this (currently) by making a modification to the XRController. Instead of only listening to the input actions, it also combines whatever it hears from input actions with the joint data/pinch progress (from the hand joint subsystem). So, the XRController will set its selectInteractionState = Active if the input action tells it to, OR the joint data from the hand says it is pinching.
So, the input action still won't work on Quest (for now), but the XRControllers "fill in the gap" with the joint data.
In the future: Quest will implement a hand interaction profile, which will result in valid input actions on Quest.


feat: New Module - This is a Demo Not for Merging :-)

Description

If you haven't already, read the full contribution guide. The guide may have changed since the last time you read it, so please double-check.
Enable GitHub Workflows in your fork to enable auto-generation of assets with our GitHub Action.
To trigger GitHub Actions after auto-generation, add a GitHub PAT as a secret in your forked repository called PAT.
Adding a new module

[ ] A proposal has been submitted and approved.
[ ] I have included "Closes #{module_proposal_issue_number}" in the PR description.
[ ] I have run brm validate locally to verify the module files.
[ ] I have run deployment tests locally to ensure the module is deployable.

Updating an existing module

[ ] This is a bug fix:

[ ] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
[ ] The bug was found by the module author, and no one has opened an issue to report it yet.

[ ] I have run brm validate locally to verify the module files.
[ ] I have run deployment tests locally to ensure the module is deployable.
[ ] I have read the Updating an existing module section in the contributing guide and updated the version.json file properly:

[ ] The PR contains backwards compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json.
[ ] The PR contains backwards compatible feature updates, and I have bumped the MINOR version in version.json.
[ ] The PR contains breaking changes, and I have bumped the MAJOR version in version.json.

[ ] I have updated the examples in README with the latest module version number.

@dciborow - Please confirm if this is still needed, otherwise we will abandon this PR in 3 days

Dear @dciborow , Azure Verified Modules (AVM) will become the single Microsoft standard for Bicep modules. Transitioning to AVM, requests for new features or bug fixes will need to be submitted against the appropriate AVM module via AVM Module Issues.
For bugs or new features with existing modules in the /modules directory of this repository, we encourage you to first try the AVM equivalent module if available and if the module is lacking any features, you can file an AVM Module Issue. If the module is not available yet, you can file a new AVM Module Proposal.
See this informational notice for more details on the upcoming changes.
Thank you for your understanding!


Update setheum.md

Add link to termination.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


[FEAT] Add color customization for charElapsed and charTotal

Wanted features:
Add color customization for charElapsed and charTotal from display/bar
Motivation:
Just want my fastfetch to look clean and tight

Just use
{
  "charElapsed": "\u001b[32m-",
  "charTotal": "\u001b[35m="
}

display.percent.color.* also affects color of charElapsed


BamSource doesn't return right when using SBIIndex

In org.disq_bio.disq.impl.formats.bam.BamSource class, we get JavaRDD<PathChunk> first and then transform it to JavaRDD<SAMRecord>
Using SBI index, we can get chunks more easily, however the code in line 105 dosen't return immediately, but instead tries to use BgzfBlockGuesser to finding PathChunk again.

Oh wow, nice catch.  Thanks for reporting that.


Doesn't work when copilot is disabled

I have copilot disabled, meaning I only get suggestions when I manually require it. In other words:
vim.g.copilot_filetypes = { ["*"] = false }
vim.keymap.set("i", "<A-p>", "<Plug>(copilot-suggest)", { silent = true })
vim.keymap.set("i", "<A-j>", "<Plug>(copilot-next)", { silent = true })
vim.keymap.set("i", "<A-k>", "<Plug>(copilot-previous)", { silent = true })

This works, but copilot-status.nvim doesn't work because it checks if copilot is enabled, then does nothing.
It would be nice if the status spinner worked even if Copilot is disabled.

Done.


npm run payload -> npx payload ?

Documentation Issue
At https://payloadcms.com/docs/database/postgres and https://payloadcms.com/docs/database/migrations, we're instructed to run, for example, npm run payload migrate:create.
I'm running Node 20.8.0/npm 10.1.0, and this results in:
$ npm run payload migrate:create
npm ERR! Missing script: "payload"
npm ERR!
npm ERR! To see a list of scripts, run:
npm ERR!   npm run

npm ERR!
Running npx payload migrate:create successfully executes the binary and generates the migration.
Apparently, npx has been available since npm 5.2.0.

@denolfe , thanks! I see that the script that should be added references the config. Do you happen to know if my having run npx payload migrate:create, without mentioning the config, is a problem? It seems to have picked up on the various collections based on a quick inspection of the resultant migration.

@DavidOliver It is not required. Payload attempts to find the payload config in an intelligent way, so it may be able to find it and load it automatically.


Load simulation results from DB before scheduling

This ticket builds towards the effort of reducing the number of simulations during scheduling.
Before scheduling, the solver simulates the whole plan to be able to execute expressions. As there is a high chance that the user has already ran a simulation corresponding to the current plan, we could load these simulation results before scheduling and avoid one full simulation.

Original conversation: https://github.com/NASA-AMMOS/aerie/issues/675


Euler number

This PR proposes a group3 analysis_level that extracts the euler numbers from the recon-all.log file (see @adrose Rosen et. al, 2017)
A table is written into <output_dir>/00_group3_quality/euler.tsv
To Do:

[x] update DOC & usage

Let me know what you think.

Looks very useful, but why not merge it with group2?

Done.

Thanks!


add support for manifest lists and fix double deletions

Hello,
i added support for manifest lists (https://docs.docker.com/registry/spec/manifest-v2-2/#manifest-list) to allow cleanup of repositories containing them.
I also lowered the number delete requests.
With regards
Joniw

Hi,
Thanks for your contribution. Can I ask what changed? Also, did you test it (also that it still works with non-manifest images?
Regards,
Morten

I'd just like to make sure that it still works against the normal (non-manifest) use-case - e.g. someone overwriting a latest tag with a nightly build or something like that. I don't have any testing infrastructure up at the moment, so if you could test that, I can merge it right away :)
It'd just be building a regular image and then changing some of the source and rebuilding with the same tag, and then check if the script actually removes the old blobs/layers.

Hello,
i found some time to test the "not manifest list" case. I just built and tagged the image for the cleanup and pushed it to an empty registry. Then i added a line into the dockerfile which created a file and tagged and uploaded again. No manifest lists were used. Then i ran the cleanup and as expected the manifest was cleaned:
/ # ./docker-registry-cleanup.sh
Found 1 manifests. Starting to clean up
## Doing 1 / 1
Job done, Cleaned 1 of 1 manifests.

A subsequent pull was also successful.
docker pull localhost:5000/test/test
Using default tag: latest
latest: Pulling from test/test
d6a5679aa3cf: Already exists
ad0eac849f8f: Already exists
2261ba058a15: Already exists
f296fda86f10: Already exists
bcd4a541795b: Already exists
6b5265f48cd5: Already exists
0324ca172242: Pull complete
5e0d9561fd38: Pull complete
Digest: sha256:4c33bd8b778f18465d1269527b575fb6a5b33fbf2f557abb0a93cd9a732fda5f
Status: Downloaded newer image for localhost:5000/test/test:latest

Thanks a bunch!


Spelling mistake found in folder name

One spelling mistake found in folder name under Beginner Level Folder.

The name of the folder should be "Longest Common Sequence"

@Kushal997-das I would like to work on this issue under Hacktoberfest 2024, kindly assign me.

Hi there!
I am the Mentor of this project .
Although this repo is not part of Hacktoberfest 2024, we have some great alternatives for you. Welcome to SkillShow, a repository focused on skill enhancement!
Guidelines:
Please adhere to the existing guidelines.
No additional rules, thanks!
Check it out here: SkillShow.
Note: Start by creating an issue. Once it’s assigned to you, feel free to open a pull request (PR). Directly opening a PR will lead to an invalid label.
Looking forward to your contributions!


Back-to-Top button

Hi! I'm a new web developer and I want to contribute to this project by making a Back-to-Top button. It will be simple with few HTML, CSS and JS code.
I want to add this feature since I believe this site will grow tremendously in the next few months and when the contents increase, it would be necessary to implement a back-to-top button.
I also believe it would be helpful to create a page which will display all the spacex launches and their details.
I'm a participant of LGM SOC'21 and if you would like to add this small feature plz assign me  this issue.
Thank you

Hello @nKeiros13 the feature you are suggesting is surely necessary, but not as of now maybe sometime in the future when there are new features added. You could think of contributing in some other way!

Hey @manankohlii, thank you for your quick feedback. I just wanted to add this feature before the site became more dynamic but okay. I also wanted to enquire about the api you're using since it's giving a huge JSON file. I think instead of using that, you should use 'https://github.com/r-spacex/SpaceX-API/tree/master/docs/v4' this api since you can use the axioms and other to get better results. Just saying.
Anyway, thank you once again for your quick response.


[BD-46] Reverse values for the Stack directions

Consider adding reverse values for the Stack Component directions. Now we have "horizontal" | "vertical" directions, it would be useful to add "horizontal-reverse" | "vertical-reverse" directions. This way we will give Stack Component more flexibility (this can be very useful when positioning elements on tablet or mobile screens).
Vertical direction

Vertical-reverse direction

@PKulkoRaccoonGang [curious] Is your proposal to include additional options for the direction prop, i.e. horizontal-reverse and vertical-reverse? I'm wondering whether any other alternative props API ideas are worth considering. For example, perhaps there's still just horizontal and vertical, but then we could introduce a separate prop for inverse: true, or similar. Food for thought; curious to hear your opinion :)

@adamstankiewicz Yes, its my proposal. I think your idea is the better 🤔  Let's do it as you suggested, we will leave the horizontal and vertical directions and add a new reverse` prop. What do you think?

@PKulkoRaccoonGang Adding a reverse prop sounds good to me!

PR: https://github.com/openedx/paragon/pull/2678


Practical esporter

For end-users, need to implement a practical exporter, something like YNAB but free.
In this discussion I will list and select the right exporter.

Close: I think the Google Data Studio with the article in #254 is enough for now.


I think here should be an add instead of minus

I think here should use add. Because if we suppose that the vehicle should driving in clockwise，means the ref traj like a circle，and the real point of our car is outside the circle .Then if we use cross product of the (cos_ref_theta, sin_ref_theta) and (dx, dy) , the result is a positive num. But the fuction here want it to be a negative one, because that make the one_minus_kappa_r_d = R_real / R_ref， the R_real is bigger than R_ref

It's quite hard to denote the math formula here.
Please refer to the APPENDIX I of Werling's Optimal Trajectory Generation for Dynamic Street Scenarios in a Frenet Frame paper here[https://www.researchgate.net/publication/224156269_Optimal_Trajectory_Generation_for_Dynamic_Street_Scenarios_in_a_Frenet_Frame]

Thx a lot. But i dont know why should keep 1 - Kr*d > 0 , whitch means Rr - d > 0. Is it a stability criteria ？

It's quite hard to denote the math formula here.
Please refer to the APPENDIX I of Werling's Optimal Trajectory Generation for Dynamic Street Scenarios in a Frenet Frame paper here

Thx a lot. But i dont know why should keep 1 - Kr*d > 0 , whitch means Rr - d > 0. Is it a stability criteria ？

It's quite hard to denote the math formula here.
Please refer to the APPENDIX I of Werling's Optimal Trajectory Generation for Dynamic Street Scenarios in a Frenet Frame paper here

Thx a lot. But i dont know why should keep 1 - Kr*d > 0 , whitch means Rr - d > 0. Is it a stability criteria ？

Yes, It's kind of a stability criteria.
As for we transform our path between Cartesian Space and Frenet Frame, there has to be a criteria that our points should stay close to the reference line, and the angle difference should remain small, or the transformation is not valid any more.

It's quite hard to denote the math formula here.
Please refer to the APPENDIX I of Werling's Optimal Trajectory Generation for Dynamic Street Scenarios in a Frenet Frame paper here

Thx a lot. But i dont know why should keep 1 - Kr*d > 0 , whitch means Rr - d > 0. Is it a stability criteria ？

Yes, It's kind of a stability criteria.
As for we transform our path between Cartesian Space and Frenet Frame, there has to be a criteria that our points should stay close to the reference line, and the angle difference should remain small, or the transformation is not valid any more.

Thank u so much. I will think it carefully. Would you mind I ask another question here? I wonder why use osqp method to solve the MPC matrix without build QP problem like before which used QPOASES and made an H & f with reference to matrix A and B. Now we just use matrix Q & P to solve. I can not understand the QP progress. Could u give me a reference, like a paper or something? Very appreciate！


An error occurred while enabling the op_trajectory_evaluator with autoware.ai

Hello.
I‘m trying to use op_trajectory_evaluator to generate local_weighted_trajectory paths on autoware demo map, but an error occured while enabling op_trajectory_evaluator.
Below are the steps the reproduce the issue:

Execute runtime manager.
Go to "Map" tab and enable "Point Cloud" and "Vector Map" and "TF" - The corresponding file provided by autoware demo.
Go to "Setup" tab and enable "TF" and "Vehicle Model"
Go to "Computing" tab and enable "vel_pose_connect" - Make sure selected the "Simulation Mode", enable lidar_kf_contour_track, enable op_global_planner - Make sure selected the "Lane Changing", "Replaning" and "Rviz Goals", Velocities is set to "Autoware".
Open Rviz by clicking the "RViz" button on Runtime Manager.
selected the start position by using "2D Pose Estimate" tool and Goal position by using "2D Nav Goal" tool  - Make sure the  global path having lane changing like the following picture.

continue to enable some model like the following picture

Publising current pose by using "2D Pose Estimate" tool
enable op_trajectory_evaluator and the error occured in terminal as the following picture

but the error were not occur when the global path don't have lane changing.
Thank you very much in advance for your help!

This issue was fixed in my repository.
kindly check OpenPlanner working group for more details.
https://discourse.ros.org/t/openplanner-2-0-requirements-design-and-implementation/11985/4

Hi @hatem-darweesh I tried to use OpenPlanner With Autoware.Ai master branch...
I have executed all the steps required on documentation. I am simulating with SVL simulator. Unfortunately the OP_Global planner is not drawing/generating the trajectory. I have debuged using RQT from runtime manager and using rostopic echo. I have echoed all the required subscription topics and I have realized all of them have data, with EXCEPTION of vector_map info! Anything is published in this topic.
However I checked and the vector map is provided in my launch file. I also have loaded it in runtime manager setup tab.  The LGSVL provided this vector map:
https://github.com/lgsvl/autoware-data/blob/master/CubeTown/my_launch/my_map.launch
For this reason I don't understand why OP global planner is not generating the trajectory.
I am on cell phone now but I will send later the rosgraph from RQT and videos displaying this attempt.
In addition I see a lot of videos on internet with Toyota2 city and a kind of AUTOWARE internal simulator where the planners work easily...Do you have this map, is it available?
Please take a look here:https://github.com/Autoware-AI/autoware.ai/issues/2387
Do you know what are the problems to distort the global planners? Why the local planners are not avoiding the collision? I will be very grateful if you could send me some advices on this issue too
Finally I just would like to use Autoware.Ai to avoid an obstacle with LGSVL simulator. Is this possible? Until know any planner was able to do that, just the freespace planner, but with a very bad motion performance.

The updated OpenPlannet 2.5 is integrated with Autoware.AI master branch. The integration is at my own fork https://github.com/hatem-darweesh (common, core_planning, core_perception)
check branch "openplanner.1.15"
you can find tutorials about how to install and use it with different Autoware.AI releases.
and more information could be found in the documents and videos here
https://discourse.ros.org/t/the-start-of-autoware-openplanner-development-wokring-group/19241/6?u=hatem

Hi Mr. Darweesh Thanks to provide me this detailed information!
Before testing your planner I have a couple of doubts if you have a time please:
As far as I know Autoware.Ai reached just the 1.14 release tag. I have not found the 1.15 as you said when I clicked over Tags.
In addition I have seen you have a tutorial for Carla simulator. But I am using the LGSVL simulator, with these maps: https://github.com/lgsvl/autoware-data
Does OpenPlanner also work for these maps? Because I have checked the Global planner OpenPlanner core node against  the core node of way_planner global planner. The structure is similar, with exception the OpenPlanner gets more Vector map info (as curbs and others, while way_planner needs to be fed just with vector maps pole, lane, points). Maybe this be the reason why I get no data flow from Vector_map info topic....because LGSVL vector maps just these "basic" vector map info...therefore the OpenPlanner does not work with LG maps?
When you say to get your fork repo, you mean I should download it and replace the code inside the docker image created from Autoware.Ai master repos? That's complicated because when I exit the docker image everything is erased, unless I copy your repos to Dockerfile maybe. What's the best solution for that?
Or is just "git checkout" inside docker terminal and the Branche option "1.15 open planner" will appear?
A last question is:
The Global Open Planner is the same as Global Way Planner? (Same behavior)? The Op Local Planner is the same as Dp planner?
I ask because I have seen this picture on YouTube:
if they be the same,  I believe the car will keep not avoiding collision, considering I have done a lot of tests with these planners and the A* or Dp or even Lattice could not distort/Remake the Global Planner path when an obstacle was found by velodyne/occupancy grid map.
Have you a video of collision avoidance using this planner with SVL simulator?
Thanks in advance.

As far as I know Autoware.Ai reached just the 1.14 release tag. I have not found the 1.15 as you said when I clicked over Tags.

We refer to Autoware.AI master as 1.15

In addition I have seen you have a tutorial for Carla simulator. But I am using the LGSVL simulator, with these maps: https://github.com/lgsvl/autoware-data

It should work the same way, unless LGSVL map has an issue, if these maps can be loaded using assuremaptools then it will work with openplanner

When you say to get your fork repo, you mean I should download the modules: core-planning, core-perception and common, and replace them inside the Autoware folder inside the docker image created from Autoware.Ai master repos? Or must I compile them on Shared_dir?

Clone everything first as the instruction in the tutorial video and documents, then build the docker image it will include the latest.

A last question is:
The Global Open Planner is the same as Global Way Planner? (Same behavior)? The Op Local Planner is the same as Dp planner?

Please don't use way_planner and dp_planner, they are the old openplanner 1.0 nodes. they are left their for compatibility reasons only,. Use op_global_planner + op_local_planner + lidar_kf_contour_tracker

@hatem-darweesh I was following this tutorial https://www.youtube.com/watch?v=7Dg1WT9n1Po to install autoware_ai pkgs from source. However I am having a bunch of errors to successfully compile the pkgs. I believe because these pkgs have complex dependencies as written here (https://gitlab.com/autowarefoundation/autoware.ai/autoware/-/wikis/Source-Build):

I running the Autoware.AI inside docker: https://github.com/Autoware-AI/autoware.ai/wiki/Generic-x86-Docker
CASE 3 of the link above. I have built the master (1.15.0) on my docker image.
In this way your tutorial (From source does not work for me) and is not possible then, to dowload your repo inside this docker image and afterwards switch to your branche:
git checkout openplanner1.15:

Do you have another specific tutorial to build the Docker Image within your repos: common, perpection and core-planning included with other Autoware master repos modules?
Please if you have already worked on the DockerFile to create this customized Autoware-OpenPlanner image could you send me? otherwise unfortunately I will not be able to run your planner in my research as I am using a shared computer and cannot brake the system trying the installation from source.
Thanks in advance

As I still couldn't test the OpenPlanner 2.5 due Docker/Source issues installation I tried the 1.5 OpenPlanner (as your pdf material said, it is included in Autoware.AI masterfile:///home/autoware-auto-ros1/Downloads/OpenPlanner_Presentation.pdf):
I have debugged to understand why the global trajectory was not drawed in rviz. You can take a look if you wish on my debug video to help me if possible (sorry for the slow motion video, but I rent a cloud machine as my notebook is not powerful enough to run the simulations with Apollo/Autoware):
https://youtu.be/D6hrEm9DYGM
Well you can also check my Rosgraph from RQT which I have saved for you take a look:

Comparing with the rosgraph from your pdf and reading as OpenPlanner works (also with much ROS experience that I have and Autoware) everything seems good with exception that I have echoed the topics and no messages available at topic lane_waypoints_array. Then I have echoed all the vector_maps info that feed the op_global_planner node....and for my misfortune more than half of these topics does not send information to the global planner node.  As I was thinking the LGSVL vector maps info are not enough. Just take a look what I have on these maps:

I do not have for example the vector map info from:
-curb
-way_area
-area
-road_edge
-cross_road
-cross_walk
That's why I have said you in the beginning that the Op global planner core node was pretty similar (in structure) to the way_planner. The difference is that the Op global planner requires/asks for more vector_map info, therefore I believe that when these info does not arrive to the node, it cannot produce the global planner to rviz and neither the local ones...
What is your point of view?
Unfortunately I think I will not be able to use your planner with LGSVL simulator. But at least I can give this explanation om my master thesis...it is a pitty because I would like to compare a planner in Autoware vs Apollo. However in Autoware any global+local planner was able to avoid collision. At least with LGSVL simulator...
**Any idea for my specific case (LGSVL-OpenPlanner 1.15 or 2.5 version) Mr. Darweesh? @hatem-darweesh **
Thanks for your attention and congratulations for your job, meeting and open planner project! I have followed your hard work during these 4 years! Pretty nice!

1- Install on a clean version of Ubuntu 18.04
2- Don't build with CUDA (It is difficult because the CUDA versions)
3- Don't use docker (I never used Autoware inside docker)
If you follow these three rules, most probably your issues will disappear.

Ok but I think in the end I will have the same issue with the lgsvl vector maps lack of info to feed the Op global planner node, as I displayed you above right?

The OpenPlanner 1.5 is already integrated with Autoware.Ai Master (1.15) right?
I have read in your pdf presentation that it is enough to collision avoidance. Thus if it works for me fit my needs.
Is it necessary to git checkout to other branche to use the 1.5 Open Planner also or not?

OpenPlanner is integrated with Autoware.AI master (1.15) the same as 1.13, through my repository. not into the official Autoware repo.
This is the way I have been working and testing. please ask someone professional in docker to solve your docker issues.

ok I understood. I really would like to test it, maybe after end my master thesis (unfortunately I have just 1 month to finish it and cannot take the risk to install a new ubuntu in my machine, I will try maybe to rent another pc on cloud. However there are a lot of dependencies to be dowloaded, right?
In addition it seems that LGSVL csv vector maps does not fit all the information that the global planner needs, as RQT returned me.
Anyway thanks very much for your kind feedback.
Wish you success with your planner.

Hi Mr. hatesh @hatem-darweesh  I have finally modified my Dockerfile to accept other repos, not just from Autoware....
Therefore I could test the Open Planner 2.5 in Docker environment. The global path was drawed, but the car did not move and I have followed these instructions from this video: https://www.youtube.com/watch?v=BS5nLtBsXPE
Afterwards I tried to launch all the modules written in your pdf sketches: file:///home/autoware-auto-ros1/Downloads/OpenPlanner_Presentation%20(1).pdf
You can check I have activated all of them:

Also you can check these attempts on my videos:
https://youtu.be/b_NBgBwkRsI
https://youtu.be/GrNl4atR4Vc
Below is the **rosgraph output from RQT instrospection nodes/topics **:

As you can check in videos or through the picture below, the car is receiving /vehicle_cmd

However it is still not moving, it does not follow the path
I have also echoed the topics:
-global_waypoints_rviz
-lane_waypoints_rviz
/pmap_stat
-steer_cmd
-accel_cmd
-brake_cmd
All of them contain messages and are active. I thought the pure_pursuit + twist_filter  nodes would be enough to enable the car following the path and move...
Could you help me please to understand what can be wrong? I mean what is missing to be launched or if I need to configure some specific parameter in a launch file to enable the car move with the simulator?
Thanks in advance

@hatem-darweesh  Just figured out how to enable the car move. The car however had a confuse behavior...I mean it has followed previous global waypoints that I have sent in rviz. Does it kind of cumulate goal points even when you change the goal spot?
Also I have just activated the OP global planner and all op_local planner launch files related to local planner. I did not launch this time the any autoware_connector launch files, neither the Open Planner Simulator launch files and any op_perception_simulator and any op-utilities launch files. I have not launched the wf_simulator from Waypoint follower icon too.
Are some of them necessary to be launched to improve the vehicle,planner behavior? Or have not they any function with SVL simulator? I am not sure if these launch files are related to the use of other simulator...
When I simulated the vehicle got some shortcuts path. I mean it did not identifed or respected the curbs. Probably because the provided maps from LGSVL does not contain a curb info vector map just other info...is this the reason?
Other issue is that the Ego vehicle identified just 70% I would say from the obstacle and therefore after overtake part of it, it returns to the lane too early and collides with the front part of the obstacle. I don't know if the lidar_contour_track is enough to identify the obstacle properly? Must I launch other file? I know other planners work with occupancy grid map to avoid collision. Does your planner take information from occupancy grid too or not? How could I improve obstacle detection/avoidance?
Thanks in advance. And sorry to kind of criticize the non-use of Docker for your branches I did not wish to be rude...just wished to have less compatibility issues...
I know other guys would like to solve the car motion problem and Docker...so I am available to create a new issue in GitHub (because this is not mine) to comment about these topics. If you wish too.

Now the planner is working 100%!!! It was just another issue with track lidar contour detector was subscribing to wrong topic in source code. Now everything is working! Do you have a paper to cite it? I would like to cite in my thesis. Thanks!

@marcusvinicius178 That is great, I am happy to know.
You can cite these papers:
1- https://www.fujipress.jp/jrm/rb/robot002900040668/
2- https://www.jstage.jst.go.jp/article/jsaeijae/10/4/10_20194117/_article/-char/ja/

Hi， @hatem-darweesh ， I also encountered this problem. I now install autoware 1.14. Do I need to uninstall autoware if I want to install openplanner?

@bilibilicharger follow these instruction to use OpenPlanner 2.0+ either with Autoware.AI 1.13 or latest master.

@hatem-darweesh Thank you for reminding me. I'll follow the guidance.


Sync the mapping from leader index and retry for MapperParsingException

Signed-off-by: Ankit Kala<EMAIL_ADDRESS>Description
This change handles the MapperParsingException while replaying the changes on the follower cluster. We will basically sync the mapping from leader index and retry.
Issues Resolved
https://github.com/opensearch-project/cross-cluster-replication/issues/409
Check List

[x] New functionality includes testing.

[x] All tests pass

[x] New functionality has been documented.

[x] New functionality has javadoc added

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #411 (8234ef2) into main (a3d0bf0) will decrease coverage by 1.41%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main     #411      +/-   ##
============================================
- Coverage     74.23%   72.81%   -1.42%
+ Complexity      998      979      -19
============================================
  Files           141      141
  Lines          4561     4562       +1
  Branches        504      504
============================================
- Hits           3386     3322      -64
- Misses          855      922      +67
+ Partials        320      318       -2

Impacted Files
Coverage Δ

...tion/action/replay/TransportReplayChangesAction.kt
82.75% <100.00%> (+0.20%)
:arrow_up:

...arch/replication/metadata/UpdateMetadataRequest.kt
77.27% <0.00%> (-22.73%)
:arrow_down:

...ch/replication/task/index/IndexReplicationState.kt
51.66% <0.00%> (-15.00%)
:arrow_down:

...ication/action/setup/TransportSetupChecksAction.kt
59.52% <0.00%> (-14.29%)
:arrow_down:

...ication/seqno/RemoteClusterRetentionLeaseHelper.kt
80.00% <0.00%> (-11.67%)
:arrow_down:

...tion/repository/RemoteClusterMultiChunkTransfer.kt
90.24% <0.00%> (-9.76%)
:arrow_down:

.../replication/metadata/store/ReplicationMetadata.kt
62.96% <0.00%> (-8.65%)
:arrow_down:

...action/stop/TransportStopIndexReplicationAction.kt
68.00% <0.00%> (-6.67%)
:arrow_down:

...ication/action/stop/StopIndexReplicationRequest.kt
50.00% <0.00%> (-5.00%)
:arrow_down:

...ion/action/resume/ResumeIndexReplicationRequest.kt
50.00% <0.00%> (-5.00%)
:arrow_down:

... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3d0bf0...8234ef2. Read the comment docs.

Security tests are failing as they've already bumped up the version to 2.1. We can't bump up ccr repo version as we're still waiting for our dependency common-utils to bump up the version to 2.1 first.

Codecov Report

Merging #411 (8234ef2) into main (a3d0bf0) will decrease coverage by 1.28%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main     #411      +/-   ##
============================================
- Coverage     74.23%   72.95%   -1.29%
+ Complexity      998      984      -14
============================================
  Files           141      141
  Lines          4561     4562       +1
  Branches        504      504
============================================
- Hits           3386     3328      -58
- Misses          855      918      +63
+ Partials        320      316       -4

Impacted Files 	Coverage Δ
...tion/action/replay/TransportReplayChangesAction.kt 82.75% <100.00%> (+0.20%) 	⬆
...ch/replication/task/index/IndexReplicationState.kt 51.66% <0.00%> (-15.00%) 	⬇
...ication/action/setup/TransportSetupChecksAction.kt 59.52% <0.00%> (-14.29%) 	⬇
...ication/seqno/RemoteClusterRetentionLeaseHelper.kt 80.00% <0.00%> (-11.67%) 	⬇
...tion/repository/RemoteClusterMultiChunkTransfer.kt 90.24% <0.00%> (-9.76%) 	⬇
.../replication/metadata/store/ReplicationMetadata.kt 62.96% <0.00%> (-8.65%) 	⬇
...action/stop/TransportStopIndexReplicationAction.kt 68.00% <0.00%> (-6.67%) 	⬇
...ication/action/stop/StopIndexReplicationRequest.kt 50.00% <0.00%> (-5.00%) 	⬇
...ion/action/resume/ResumeIndexReplicationRequest.kt 50.00% <0.00%> (-5.00%) 	⬇
...tlin/org/opensearch/replication/util/Extensions.kt 65.47% <0.00%> (-4.77%) 	⬇
... and 13 more
Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3d0bf0...8234ef2. Read the comment docs.

Can we also check and try avoiding coverage decrease?


AMQP-583: Fatal @RabbitListener Exceptions

JIRA: https://jira.spring.io/browse/AMQP-583
The ConditionalRejectingErrorHandler now considers irrecoverable
@RabbitListener exceptions as fatal (rejecting the message so it is
discarded or routed to a DLX/DLQ).
Previously, only MessageConversionExceptions were fatal by default
and users had to configure a customized error handler.
o.s.amqp.support.converter.MessageConversionException
o.s.messaging.converter.MessageConversionException
MethodArgumentNotValidException
MethodArgumentTypeMismatchException
are all fatal exceptions.
Also, previously, the stack trace was logged twice; it is now only logged once.
cherry-pick to 1.5.x What's new will need adjustment.

Not sure if Travis failure is related to the PR, but I'm sharing its issue anyway:
org.springframework.amqp.rabbit.core.BatchingRabbitTemplateTests > testDebatchByContainerBadMessageRejected FAILED

    org.mockito.exceptions.verification.TooLittleActualInvocations at BatchingRabbitTemplateTests.java:338

572 tests completed, 1 failed, 46 skipped

:spring-rabbit:test FAILED

Yes, BatchingRabbitTemplateTests.testDebatchByContainerBadMessageRejected fails for me as well.
Just because of this "the stack trace was logged twice; it is now only logged once" change.
Fixing during merger...

OK. IT is fine after fixing and rebasing.
So, merging after the aforementioned polishings.

Merged as https://github.com/spring-projects/spring-amqp/commit/ee51a64f6abdbca459964f7b6c3d3cc54d2d95ab and cherry-picked with conflict fix for the "What's New".


Unspecified Error

Version
3.1.8 (2f583cd)
Seed
R710-7314-ZNQPA0655LP00H3NPVXBKB96ZZZZZZZZZZZZZZZZZZZZZZZZZ
Scenario
RE 1 (Jill)
Player Character
Enrico
What happened?
I loaded the seed and sat through the first cutscene in the main hall. As soon as i entered the dining room the game crashed and i got an error pop up stating Unspecified Error

This a common issue hit by people and has been known to be solved by using the dgvoodoo fix and increasing the VRAM for it. More information is available in the official discord channel.


Provide a generic database implementation.

Make the networking database implementation generic so that it can be used to store data for any component in Ciao. This database implementation can be used to persist any table map, array, slice to a database backed by boltDB+gob.
We may want to consider moving this to a generic util package for ciao.
**Note: As the table name internally has changed, this will break
any in place update of the CN launcher. For a proper update
of the CN, it has to be hard reset to remove all instances
and the database cleaned up.**

@markdryan Could you review this please.

Coverage decreased (-0.02%) to 66.528% when pulling 2cfa1645bcc1f64a21571973baa3ade71d3c9aee on mcastelino:db_cleanup into 92b2d0e66b8af3d4d87dd88f99931472aa50b532 on 01org:master.

@mcastelino , @obedmr We have almost identical database abstractions in this PR and in #632. We need to figure out which one to use, and also where to put it.

@obedmr It does not seem a completely transparent replacement right now. We can consider moving to your final implementation once you merge in. Also right now I need this to implement CNCI agent persistence.

@obedmr also in your implementation does the user of the database need to know that gob is used to store the value? I am going through your implementation, maybe I am mistaken, but I think the user of the db would need to decode?

@rbradford fixed the review comments.

Coverage decreased (-0.06%) to 66.5% when pulling fc0f78bf2d9d8f6c1b21d355de146f9157bf1e7e on mcastelino:db_cleanup into 6fd566135107e62adef6eda8fc5b1d16d235849c on 01org:master.


Feature: Add non-breaking sections

I would like to have sections but optionally not break them.
This comes in handy when you have a large example code snippet but short sections.
It would be nice to have a section that isn't a half page down the screen.

Unfortunately, this is a pretty fundamental feature of how Slate works, so we're not likely to add this to the master branch. That said, if you edit the CSS, you can add this in for yourself! Just look for things that clear: both and remove that for specific section headers that you're interested in not breaking.


[Marker.io] Tablet landscape mode- page is distorted

Steps to reproduce:

open the page
slide on the page from right to left or vice versa

Actual result: page is distorted
Expected result:please fix this

Reported by: Vinod<EMAIL_ADDRESS>- Contact via Marker.io
Source URL: https://proav-stg.webflow.io/about
Issue details: Open in Marker.io
Device typetabletBrowserSafari 17.6Screen Size768 x 1024OSiOS 17.6.1Viewport Size1105 x 753Pixel Ratio@2x

🤖 Marker.io bot - This issue was marked as ✅ Resolved in Marker.io


iOS App crash in the release mode after adding Freerasp:3.0.2

Hi team due to some flutter version restriction I'm using the freerasp 3.0.2 with flutter version 2.5.0 it is working fine with the android but not working properly with the iOS build as soon as I make a release build it start crashing after talsec.start() function I have cross check each and everything from the documentation and implimented the same step by step so can you help me in solving this issue?

Hello.
Could you provide crash logs so I can better understand what could go wrong?
Thanks.

Hello,
We have updated our code to flutter 3 and now it is working with latest version of freerasp but now we are able to bypass the root detection using updated megisk so is there anything we can do for the same

Hello @ganeshswami98,
the freeRASP has limitations regarding the newest versions of Magisk Manager, see the comment here: https://github.com/talsec/Free-RASP-Android/issues/30#issuecomment-1907963329. We will look at it in the future.
The issue regarding the crash is considered solved. Therefore, we are closing the issue.
Kind regards,
Talsec team


[Suggestion] LoggerFactory.default as a default parameter for newLogger()

Hello,
I recently started using this library and I noticed that I quite repetitively use newLogger(LoggerFactory.default)
Because it's "default", can we make it a default parameter so we can use it with just newLogger()?
Thank you for the awesome library by the way :)

Hi !
Happy you like the lib :)
I don't think that's a very good idea, because it would make it easy to mistakenly use default in an application that uses a custom configuration.
What I usually do in my apps is:
val appLoggerFactory = LoggerFactory(defaultLogFrontend.withShortPackageKeepLast(2))

public inline fun <reified T> T.newAppLogger(): Logger = newLogger(appLoggerFactory)

...and use newAppLogger everywhere in the application.
If newLogger took a default argument, it would encourage developers in my team to mistakingly use it rather than looking for the correct newAppLogger.

Thanks! That sounds like a good idea.
I'm closing this issue.


Restructuring

@thomasbarrett I'm a fan of https://github.com/thomasbarrett/io-uring-async, and its made me think about the structure of this library, and hwere it could go
Splitting the runtime, and the Ops apart, into seperate crates seems like a good idea. That allows for a decoupling in API experiments. I think what this repo has shown is that the API for a high level library around io-uring is still in flux.
On reflection, i'm not sure the distinction between the runtime in https://github.com/thomasbarrett/io-uring-async and here is all that great. Its not independent, because of the need for on thread park work. What i do like though is relying on the underlying runtime to implment async drop functionality, rather than doing it manually.
One thing which I think we should do, which we don't do in both libraries, is keep reference counts to the underlying ring in all submitted ops. I think we should we should do that to enable better cancellation support, now io_uring has cancel operations available.
@thomasbarrett, do you have an interest is exploring that design space?

Decoupling runtime and ops is good idea as I've found current implementation is still far from optimal. After  some performance inspections, I am getting more impression that we may need whole different way to use optimal workload patterns.
Personally, I want to explore simple alternative runtime without epoll (so pure uring based even for readiness device) and use uring enter + wait for a tick. Axobe also mentioned this is design choice to be efficient event loop in https://github.com/axboe/liburing/wiki/io_uring-and-networking-in-2023#batching

Personally, I want to explore simple alternative runtime without epoll (so pure uring based even for readiness device) and use uring enter + wait for a tick. Axobe also mentioned this is design choice to be efficient event loop in

I've given this some thought, after investigating the implmentation in here and by https://github.com/thomasbarrett/io-uring-async, which is very similar. Both use a listener on the a tokio epoll backed AsyncFd to wake the thread.. I believe the change shouldn't be too hard to arrange - I think it's as simple as replacing the on_thread park method, which currently called submit, with submit and wait. I intend to give that a go.


Bug: help center navbar redirection to private routes

What happened?
Please find below the screenshot of navbar currently used in Help Center page but the problem is that it has a logout button, home button and account button. It is good when the user is logged in but if the user is not logged in, these buttons are not required.
The proposed fix of this issue is to:

extract the navbar code from home page and make a separate navbar component
use accountId cookie to check whether the user is logged in
based on the cookie, switch between private navbar and public navbar

Add screenshots

What browsers are you seeing the problem on?
Firefox, Chrome, Microsoft Edge, Brave
Record

[X] I agree to follow this project's Code of Conduct
[ ] I want to work on this issue

Please assign this issue to me.

@anirbanmajumder0 assign this issue to you.

@anirbanmajumder0 under which event are you registered? SWOC or IWOC?

Swoc

Swoc


Remove a couple unneeded uses of CompileResult.

Description
Small PR to remove a couple unneeded uses of CompileResult.
Checklist

[x] I have linked to any relevant issues.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] I have updated the documentation where relevant (API docs, the reference, and the Sway book).
[x] I have added tests that prove my fix is effective or that my feature works.
[x] I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
[x] I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
[x] I have requested a review from the relevant team or maintainers.

Ahh conflicts...

does the diff looks correct though?

I messed up the rebase 🤦♀ Thanks for pointing this out!


[Event Change Request] table 207 "Res. Journal Line" - OnAfterCreateDimProcedure

Describe the request
Could you please update the event OnAfterCreateDimProcedure in table 207 "Res. Journal Line" to include some additional parameters?
procedure CreateDim(DefaultDimSource: List of [Dictionary of [Integer, Code[20]]])
begin
    "Shortcut Dimension 1 Code" := '';
    "Shortcut Dimension 2 Code" := '';
    OldDimSetID := Rec."Dimension Set ID"; //CHANGE
    "Dimension Set ID" :=
        DimMgt.GetRecDefaultDimID(
        Rec, CurrFieldNo, DefaultDimSource, "Source Code", "Shortcut Dimension 1 Code", "Shortcut Dimension 2 Code", 0, 0);

    //+CHANGE
    //-OnAfterCreateDimProcedure(Rec, CurrFieldNo, DefaultDimSource);
    OnAfterCreateDimProcedure(Rec, CurrFieldNo, DefaultDimSource,  xRec, OldDimSetID);
    //-CHANGE
end;

[IntegrationEvent(false, false)]
//+Change
//-local procedure OnAfterCreateDimProcedure(var ResJournalLine: Record "Res. Journal Line"; CurrFieldNo: Integer; var DefaultDimSource: List of [Dictionary of [Integer, Code[20]]])
local procedure OnAfterCreateDimProcedure(var ResJournalLine: Record "Res. Journal Line"; CurrFieldNo: Integer; var DefaultDimSource: List of [Dictionary of [Integer, Code[20]]]; xResJournalLine: Record "Res. Journal Line"; OldDimSetID: Integer)
//-Change
begin
end;

### Additional context

We already have those additional parameters in similiar events in `table 36 "Sales Header"`.

With the additional parameters we're able to restore some Dimensions, that are manually entered for specific dimensions.
Those values are cleared by recreating the DimensionsSetID from the DefaultDimSource List.

Internal work item: AB#495329

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 14917.


docker container are running but not accessible in browser it showing error 404 docker installed on aws ubuntu

docker run tomcat is worked only after doing
docker pull tomcat:latest
docker run -d --name mytomcat -p 8080:8080 tomcat:latest
docker exec -it mytomcat /bin/bash
mv webapps webapps2
mv webapps.dist/ webapps
exit
but docker run nginx is not working
docker run hello-world-python is not working
all containers are running in cli but not accessiable in browse how to fix this

Bro cal me on whatsapp we will solve Issue on remote...
I seen you have lot issues we will solve all...
Cal me on whatsapp

Bro cal me on whatsapp we will solve Issue on remote...
I seen you have lot issues we will solve all...
Cal me on whatsapp

plz send your number

plz send your number

If you read entire mail... You can see lab assistant number...
Please reach me on whatsapp same number

If you read entire mail... You can see lab assistant number...
Please reach me on whatsapp same number

okay

okay


B 19030 int

B-19030
Summary
This is a very simple 1-line change to adjust the verbiage associated with the "Edited" status when approving PPM advances. For this story, all that was required was for the display text to be altered, as the Edited status already functions as an approval. Additionally, it's important to keep the status as 'Edited' as it functions differently from the approved status in that allows the API to adjust the approved value when the call is made.
Verification Steps for the Author
These are to be checked by the author.

[ ] Have the Agility acceptance criteria been met for this change?

Verification Steps for Reviewers
These are to be checked by a reviewer.

[ ] Has the branch been pulled in and checked out?
[ ] Have the BL acceptance criteria been met for this change?
[ ] Was the CircleCI build successful?
[ ] Has the code been reviewed from a standards and best practices point of view?

How to test

Access the application as a customer

Create and submit a PPM with an advance request

Login as a Service Counselor

Edit the shipment

Adjust the Advance request value on the second page. Approve the advance request.

Ensure the details page shows "Approved" instead of "Approved with adjustment"

Ensure all client and playwright tests pass.

Frontend

[ ] There are no aXe warnings for UI.
[ ] This works in Supported Browsers and their phone views (Chrome, Firefox, Edge).
[ ] There are no new console errors in the browser devtools.
[ ] There are no new console errors in the test output.
[ ] If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.
[ ] This change meets the standards for Section 508 compliance.

Warnings

:warning:
This PR does not include changes to unit tests, even though it affects app code.

  Generated by :no_entry_sign: dangerJS against 4cc6c9ebfe8f85fe4948e377e4bb53ccd3f8d706


Cannot Specify External Connection

When I try to do:
nats.connect({
    url: '<IP_ADDRESS>',
    port: '4222'
  });

I get:
TypeError: port should be a number or string: null
    at Socket.connect (net.js:914:13)
    at Object.exports.connect.exports.createConnection (net.js:92:35)

It looks like there is no default for opts.port and opts.port is not being assigned as an option.

You are not pasing a url, you are passing an IP which when parsed by url.Parse can not find a scheme or protocol and hence no default port. I can add code to pull the port option in, but it's best to do the following.
nats.connect('nats://<IP_ADDRESS>:4222');

Will this work for Consul as well?

@dlabey 'nats://your-favorite.consul.service:4222' will work.

Ah yes worked well.


Readme update

I think this docs are incorrect when looking at the code. I think the default for hide_from_bots is true.

Oops - just notice https://github.com/orestbida/cookieconsent/pull/448 has already noticed and PR'd this.


Module might be attached to a non-existing ELB.

An ELB resource might not be realised from declaration, i.e count is
set to 0. In that case the module invocation will fail because of the
variables for a non existing resource are accessed. This commit
replaces the output values with empty ones.
For e.g
resource "aws_elb" "myelb" {
  count = "${var.createelb == 0 ? 0 : 1 }"
  name                     = "${var.base_name}-elb"
}

module "ssl-policy-elb" {
  create = "${var.createelb == 0 ? 0 : 1 }"
  source = "$GH/terraform-aws-ssl-ciphers/ELBSecurityPolicy-TLS-1-2-2017-01"
  name = "public-ssl-policy"
  load-balancer-id = "${element(concat(aws_elb.myelb.*.id, list("")), 0)}"
}

I believe this should also fix #1.
Also if you have a cleaner way to solve this I am all ears.

Thanks a lot for this :100:
This looks better than the approach in #1. I'll test this against v0.10 and merge if it passes.


Change local_user default to use environment vars instead of getlogin

The return value of Etc.getlogin is not reliable on at least BSD style systems, because it can be changed any time by processes using the setlogin syscall, even after su to another user.
Instead we rely on USER (BSD style), LOGNAME (SystemV style) or USERNAME (Windows) environment variables. On modern unix systems both USER and LOGNAME should be set, but it doesn't hurt to check for both to be on the safe side.
This also removes the dependency on the Etc module and fixes #1520.
I have removed the dsl spec for local_user, because it gave the wrong impression of testing the default behavior when in reality it only exercised the dsl's set method.

@leehambley It would be great to have a spec that checks the defaults, but I'm not sure what's the best way to load the defaults into a spec. Any ideas?

Should a similar change be made to SSHKit as well? SSHKit uses Etc.getpwuid.name here:
https://github.com/capistrano/sshkit/blob/e06d6b8424979a6a3a2974f375490d2aa15c2ac4/lib/sshkit/host.rb#L29
And I remember we had to patch around it in Airbrussh to get tests passing on Windows:
https://github.com/mattbrictson/airbrussh/blob/2bbe4177d5e29b142068a9c8a85fdbe5f6412617/test/airbrussh/formatter_test.rb#L20

Etc.getpwuid.name should be safe on unix, but won't work on Windows, because it relies on /etc/passwd, so at least there would have to be a fallback. I think we could use environment vars there as well.

@mattbrictson good catch, @felixbuenemann would you mind to make the same patch for SSHKit? I know it's not the domain where you're having problems but it'd be nice to get them both done.

@leehambley Sure, I'll take care of it.

Thanks, I've to do a release last Friday already, and I'm late because my
son was sick all weekend, but maybe I can get it out tonight/tomorrow
night. Thanks x10
On 1 Nov 2015 7:17 p.m., "Felix Bünemann"<EMAIL_ADDRESS>wrote:

@leehambley https://github.com/leehambley Sure, I'll take care of it.
—
Reply to this email directly or view it on GitHub
https://github.com/capistrano/capistrano/pull/1521#issuecomment-152849980
.


HTMLUnitDriver support

Hello,
Thanks for selenoid!
I would like to know if it's possible to use HTMLUnitDriver?
Regards.

@slopy euh, so far as I know it was deprecated years ago. What's the purpose of that?

@vania-pooh not sure but seems like not deprecated http://htmlunit.sourceforge.net/changes-report.html . Well it's lightweight.

@slopy why don't you use it directly?

@leorush what do you mean by use it directly? The idea is to have selenoid grid under one url and have connection distributed properly.
Our selenium network have grown a little from time of my last comment.
Now we have:
3 servers under load balancer, on each there are 1 selenoid (for chrome and FF with limit of connections 45) + 3 selenium-standalone ( for htmlunit with limit of 15 for each ) + ggr + selenoid-ui + ggr-ui
This is working quite well, however I see few things missing and maybe you guys can help with those. (I'm not sure if I should put this topic here as this is related to other services you have built)

ggr-ui is pointing to selenoid-ui and this is working fine, but there are stats for selenoids only. I'm wondering if there is any way we could grab stats also from selenium-standalone servers?
display stats for selenoids in the network but is it possible to make stats separated by IPs? - just to know if distribution so fine

Once again thanks for brilliant tools you are building!

Summon @aandryashin.

@slopy i mean that it seems that there is no need for selenoid to run parallel tests on HTMLUnit.

@slopy we did some investigation. It seems that any Selenium server standalone image has HTMLUnit included. Do you need more instructions on how to build such image?

Yep, true that selenium-standalone has HtmlUnit and we are using it. We have host in quota file pointing to selenium-standalone (and it is working) however would be nice to simply set proper image in browsers.json. That way all stats will be in one place and no need for additional dependencies.
@vania-pooh do you mean like create proper docker image?

@slopy I mean create \ find an image with java -jar selenium-server-standalone.jar as an entrypoint and then specify it in browsers.json.

@vania-pooh I have docker-compose.yml to manage services on each server and I'm using this image there so will try this solutions - sounds promising. Thanks a lot!
Will update with results!

And it works.
Dockerfile
FROM selenium/base
CMD java -jar /opt/selenium/selenium-server-standalone.jar

browsers.json
    "htmlunit": {
        "default": "2.30",
        "versions": {
            "2.30": {
                "image": "selenium_image:latest",
                "port": "4444",
                "path": "/wd/hub"
            }
        }
    }

Once again thanks a lot for help.

TBH I have not published this image - it's on machine.
When it will go public I will try to remember to get back to this topic.

@slopy any progress on this or closing?


Provide stacktrace for react-scripts/build.js build function

Is your proposal related to a problem?

I've encountered a problem that I think could've been diagnosed more easily if build script were more verbose and provided a stack trace aside of error message.
My scenario was pretty simple - I've used CRA, eject, then played a bit with entry record:
https://github.com/facebook/create-react-app/blob/687c4ebf211ad30238f2d59e063b8171e015bfc7/packages/react-scripts/config/webpack.config.js#L151
by replacing an array configuration with an object configuration (which is valid webpack option)
After that I couldn't build my app (which is fine) and I coundn't easily find a problem, see attached image:

As you can see, the error message didn't tell me where the problem occured or what the context was, so if I've played a lot around my configuration then I have to either revert my changes line by line to find which exactly broke the build or debug build script itself.
Describe the solution you'd like

Error message was formed here:
https://github.com/facebook/create-react-app/blob/687c4ebf211ad30238f2d59e063b8171e015bfc7/packages/react-scripts/scripts/build.js#L196
If there would've been an additional stacktrace added to that array:
if (err) {
    messages.errors.push(err.stack);
}
return reject(new Error(messages.errors.join('\n\n'), ));

then I would have a more precise description of a problem that shows me that 'filter of undefined' situation occured exactly at 583 line of my webpack config which I should further work with:

Describe alternatives you've considered

There is an obvious concern that stacktraces might not have a place in defined policy of user-friendly error messages, but they probably could be enabled by additional --verbose flag.

+1. Same issue on start

No clue which file this happened in.
create-react-app --version
3.4.1
node --version
v12.16.2

@Dergash Thanks for posting this issue it saved my many hours :)
I was getting the same issue in prod build there is no clue what is wrong there because app was working fine with yarn start command.
your this code help me to solve that.
for more who is getting the same error in prod build and no clue wht's wrong there
then just do this thing
got file formatWebpackMessages.js  under the node_modules\react-dev-utils\formatWebpackMessages.js

this console.log do the magic
with this   console.log('formatWebpackMessages', json);

without this   console.log('formatWebpackMessages', json); it was only showing

1 for this implementation, this may have a flag to activate the traceback


Missing process.uptime()

Missing from the API https://nodejs.org/api/process.html#process_process_uptime. Returns number of seconds since the process has been running.

in light of https://github.com/defunctzombie/node-process#browser-implementation not adding it might be the best case forward as that allows others to polyfill it if they want

Thank you for pointing to the :memo:, makes perfect sense. If anyone wants to follow the guidelines, here's how I patched mine:
const zulu = Date.now(); // Evaluated when monkeypatch module is first required.

// Seconds since Zulu.
process.uptime = () => Math.ceil((Date.now() - zulu) / 1000);

yeah I put it into my es6 version of this module, because there extra imports are less important.


Change anagram test case input

The input for this function is supposed to be a list containing single word strings, as in all other test cases.

Solving this via upstream... See exercism/problem-specifications#2314 for details.


Missing redirect from https://archives.ipfs.io to https://awesome.ipfs.io/datasets/

https://archives.ipfs.io/ was deprecated by https://awesome.ipfs.io/datasets/ in https://github.com/ipfs/docs/pull/238   but a lot of websites outside of our control still link to the old page, which now returns 404 error:

We should add redirect from https://archives.ipfs.io to https://awesome.ipfs.io/datasets/
cc @jessicaschilling @olizilla (is this repo the right one for reporting this types of issues?)

This actually goes all the way back to issue https://github.com/ipfs/archives/issues/179 - but it looks like the issue with the redirect was never resolved.


Add testing case for the function SearchSheet()

PR Details

Description

Related Issue

Motivation and Context

How Has This Been Tested

Types of changes

[ ] Docs change / refactoring / dependency upgrade
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

Codecov Report

Merging #280 into master will increase coverage by 0.8%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           master    #280     +/-   ##
========================================
+ Coverage      98%   98.8%   +0.8%
========================================
  Files          18      18
  Lines        3854    3854
========================================
+ Hits         3777    3808     +31
+ Misses         59      28     -31
  Partials       18      18

Impacted Files
Coverage Δ

sheet.go
98.58% <0%> (+8.78%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b917466...144f0a5. Read the comment docs.


Creates a patched classpath until HikariCP no longer uses java.beans

This makes a temporary classpath addition which uses commons instead of
Hikari. This buys us time until HikariCP no longer uses java.beans.
See https://github.com/brettwooldridge/HikariCP/issues/415
See https://github.com/openzipkin/zipkin/pull/707
See https://github.com/openzipkin/zipkin/pull/687

Me likes, especially how nicely it's contained, easy to remove once the need for the workaround is gone. :star: :+1:

yeap hopefully, it is mostly a git revert. here's how I've been testing it.
  entrypoint: /bin/sh
  command: -c "java -cp ${ANORMPATCH_CLASSPATH}:/zipkin/zipkin-query.jar com.twitter.zipkin.query.Main -f /query-mysql.scala"


fix: Product name/brands exception

What
Fix NPE when product brands are null.
Screenshot

Fixes bug(s)
Fixes #4701

Codecov Report

Merging #4705 (c214f36) into develop (25068e5) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           develop   #4705   +/-   ##
=======================================
  Coverage     9.90%   9.90%
=======================================
  Files          310     310
  Lines        15808   15807    -1
=======================================
  Hits          1566    1566
+ Misses       14242   14241    -1

Files
Coverage Δ

...es/smooth_app/lib/pages/product/edit_ocr_page.dart
0.00% <0.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Deployment of scheduler fails

Hello,
I'm following the instruction to test charmander with Vagrant, but the second step, deploy scheduler fails. It seems that the gogoprotobuf project has migrated to Github: https://github.com/gogo/protobuf
charmander$ ./bin/deploy_scheduler
package github.com/att-innovate/charmander-scheduler
imports code.google.com/p/gogoprotobuf/proto: unable to detect version control system for code.google.com/ path
Connection to <IP_ADDRESS> closed.

Thanks Claude, and yes there was an issue. Google moved packages to github which broke previous imports. It should be fixed now. Details at
https://github.com/att-innovate/charmander-scheduler/commit/d37dcdf917d90f6674513bfe527f48c2530cd1f3


Add some rules for what PRs needs to include (tests, docs)

While I'm not sure we're 100% ready to enforce all of these rules yet
we should include this as part of our stated set of rules/goals and
slowly "up" our bar as do we add the infrastructure.
Signed-off-by: Doug Davis<EMAIL_ADDRESS>

@duglin Personally, I'm ok with this as-is, and iterating further in future PRs. LGTM (LGTM1 label set)

Personally, I actually prefer NOT to have docs on PR that changes implementation.  Here's the reason why:

Code review is easiest to focus on smaller chunks
Adding doc review to implementation muddies things a lot
It is more time effective to write doc for code that has already merged, so you do not have to continually rewrite doc as you iterate on code

Just my $0.02

This might be a good topic for the next phone call, but in my experience:

people sometimes "forget" to go back to add docs
to me reviewing the docs does the opposite of "muddies" things, it actually helps the reviewer see the bigger picture. Often reviewers focus on just the snippets of code and don't see it from the end-user's point of view. And in some cases they don't even try to build/play with it.
this hammers home the idea that docs are not an afterthought and that we (as a group) view docs as just as important as the code. If its not documented then it might as well not exist.

And to the first bullet, I like to assume that the PR author will vanish once their PR is merged - which means if we want to get something out of them we need to get it at the same time as their code.  Which is why I prefer PRs to be as complete as possible (code, docs, tests...). The idea of "oh skip that little tweak I'll get it in the another PR" kind of bugs me.  Balls get dropped.

BTW - we could adopt what Docker does and have stages to the PR review.
1 - design review
2 - code review
3 - docs review
so that if people want to wait to do the docs until after the code review then we can move the PR past "code review" and then it waits for the docs to be written/reviewed.  Same net result.

Doug, I like that breakdown. I would say though that if we go that route, we should have requirements on completion of Issues, i.e., PRs should have an associated Issue, and Issues should go through all of the phases, design, code and doc.

Let's save the PR review stages proposal for another PR because I think that's an orthogonal issue - which might require a bit more time to fine-tune. And doesn't change this PR - it just adds more "process" for us.

For a data point, here's what Docker has:
https://github.com/docker/docker/blob/master/project/REVIEWING.md
in particular, the "Docs Review" section.

Spoke with @duglin and I withdraw my comments about doc changes... for now.
LGTM

LGTM

rebased


Misleading error message when Optimization Toolbox is not installed

I tried to follow the  "Analyzing Datasets"  example in the tutorial section, but whenever I ran
[B,lam] = fitbackground(V,t,@td_exp);

I received the following error message:
Invalid solver specified. Provide a solver name or handle (such as
'fmincon' or @fminunc).

After some digging around it turned out, that I did not have the Optimization Toolbox installed. However, the error message insinuated that I had not set the paths correctly.
Suggestion: Test for availability of Optimization Toolbox with
license('test','optimization_toolbox')

which returns 1 if the toolbox is installed.

Fixed https://github.com/luisfabib/DeerAnalysis2/commit/273d473f6f5a1915bbd46816082c7791d40e1a65 The program controls the license of the toolbox at the dependent functions and prompts an explanatory error if the toolbox is missing.


added loading lint rules from config file via node-config package and…

This PR only seems to cover the rules config option, but ignores all the options we have in the sample file. What about enabling the--json-schema switch through setting jsonSchema: true, etc?
I know there are a lot of options, but we talked about how each of them should be able to be set in the config file... and this PR doesn't do any of that.

Coverage remained the same at 72.835% when pulling ecf3ad192ee52bf2b1df2750a7a5a5b575c6bcf5 on feature/speccy-config into 52f812ed2d4458b0358a427904d52d663194d301 on master.

Coverage remained the same at 72.835% when pulling ecf3ad192ee52bf2b1df2750a7a5a5b575c6bcf5 on feature/speccy-config into 52f812ed2d4458b0358a427904d52d663194d301 on master.

Coverage remained the same at 72.835% when pulling ecf3ad192ee52bf2b1df2750a7a5a5b575c6bcf5 on feature/speccy-config into 52f812ed2d4458b0358a427904d52d663194d301 on master.

Coverage remained the same at 72.835% when pulling ecf3ad192ee52bf2b1df2750a7a5a5b575c6bcf5 on feature/speccy-config into 52f812ed2d4458b0358a427904d52d663194d301 on master.

Closing in favour of https://github.com/wework/speccy/pull/102. Thanks for the prototype and hard work on this!


validate email

Hello,
How can i have complet test ?
mailbox_verification to true ?
and / or syntax_only to false
thanks

Hi @fturiot what did you mean?
Could you please explain what were you trying to do?

Closing the issue due to lack of activity.


Fix: desc of keymap git staging

Fix #557

Did you mean to rebase the fixup!?

did the rebase.

Excellent, thank you for the help!


edit text changes should wait till loses focus before generating action

great plugin, thanks for building it! Would be nice to wait until loses focus or timer to avoid generating multiple unnecessary lines
    // Set text to 'r' in DollyEditText with id R.id.edit_text_email
    onView(withId(R.id.edit_text_email)).perform(replaceText("r"));

    // Set text to 'ri' in DollyEditText with id R.id.edit_text_email
    onView(withId(R.id.edit_text_email)).perform(replaceText("ri"));

    // Set text to 'ric' in DollyEditText with id R.id.edit_text_email
    onView(withId(R.id.edit_text_email)).perform(replaceText("ric"));

    // Set text to 'rich' in DollyEditText with id R.id.edit_text_email
    onView(withId(R.id.edit_text_email)).perform(replaceText("rich"));

    // Set text to 'riche' in DollyEditText with id R.id.edit_text_email
    onView(withId(R.id.edit_text_email)).perform(replaceText("riche"));

    // Set text to 'rich' in DollyEditText with id R.id.edit_text_email
    onView(withId(R.id.edit_text_email)).perform(replaceText("rich"));

    // Set text to 'richa' in DollyEditText with id R.id.edit_text_email
    onView(withId(R.id.edit_text_email)).perform(replaceText("richa"));

    // Set text to 'richar' in DollyEditText with id R.id.edit_text_email
    onView(withId(R.id.edit_text_email)).perform(replaceText("richar"));

    // Set text to 'richard' in DollyEditText with id R.id.edit_text_email
    onView(withId(R.id.edit_text_email)).perform(replaceText("richard"));

yes, now I've implemented this by purpose. I can handle event that something is pressed in edit text. But it is not efficient to generate event each time something is pressing, it is better to generate one event to set the whole text when it is finished. and the only way I know to found out is it finished or not is to wait for lose focus. And what do you think is the best way to handle this?

We could add a timeout for when keys stop getting pressed while edit text is focused or when the edit text loses focus.

I think timeout is not an option because user can wait any amount of time before pressing something. So I still can see the only option is to wait for loose focus

Let's keep current implementation yet because I do not see any better way to do this now.


feat: start process

Description

Scheduler start process.
CDN start process.
Keepalive retry.
Manager grpc request timeout and backoff config.

Related Issue

Motivation and Context

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation Update (if none of the other choices apply)

Checklist:

[x] Code compiles correctly.
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

Codecov Report

Merging #572 (d5d7998) into main (c34a6e7) will decrease coverage by 0.34%.
The diff coverage is 18.18%.

@@            Coverage Diff             @@
##             main     #572      +/-   ##
==========================================
- Coverage   39.28%   38.94%   -0.35%
==========================================
  Files          86       86
  Lines        6641     6653      +12
==========================================
- Hits         2609     2591      -18
- Misses       3661     3690      +29
- Partials      371      372       +1

Flag
Coverage Δ

e2etests
?

unittests
38.94% <18.18%> (-0.35%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

internal/job/job.go
18.03% <0.00%> (-3.13%)
:arrow_down:

scheduler/config/dynconfig.go
56.79% <100.00%> (ø)

manager/permission/rbac/rbac.go
21.27% <0.00%> (-12.77%)
:arrow_down:

client/daemon/peer/peertask_stream.go
54.00% <0.00%> (-3.49%)
:arrow_down:

client/daemon/peer/peertask_stream_callback.go
62.02% <0.00%> (-2.54%)
:arrow_down:

cdnsystem/supervisor/task/manager.go
10.09% <0.00%> (-0.29%)
:arrow_down:


Non-GOV.UK Page Templates – Desk Research

What
Define the problems we can and can't solve surrounding Non-GOV.UK Page Templates.
Why
We have lots of support queries.
We know people build pages that use GOV.UK branding and protected assets inconsistently.
Who needs to know about this

Most of our team, especially Charlotte, Rosie, Trang and Tim
Thomas Moore on the Proposition team

Further detail

Departmental Page Templates - everything we know and what we want to know
Branding, identity, departmental templates etc.
Departmental headers - google drawing
Case working system started by Chris Taylor at the Home Office
Dave House's thoughts on headers
Things that aren't of GOV.UK - user needs
Non GOV.UK branded services - principles and questions

Done when

[x] Findings gathered from Zendesk tickets
[x] Collect examples of when GOV.UK templates are used incorrectly
[ ] Share with the team for discussion

to put on new card

[ ] Document emerging user needs
[ ] A list of problems which we could look to tackle
[ ] Hypotheses which we can develop designs to test against
[ ] Work out what we need to build/adapt or allow to be customisable

Notes from conversation with GOV.UK Policy and Strategy team
Prototypes that use GOV.UK protected assets (font, logotype, and crown) should ensure that they are at least one of the following:

password protected.
non-indexable.
use a unique url.

Requests to use the GOV.UK font for publications should reach out to the GOV.UK Policy and Strategy for publications.
Things we could do

Provide specific guidance for common use cases when asked about the GOV.UK protected assets on GOV.UK Design System support.
Advise contractors to use the prototype kit if they are developing a service for a central government department going for a service assessment.


Cannot virtualize WASI imports today

This is an issue specific for this repository spawned from https://github.com/bytecodealliance/wasmtime-py/issues/2. Unfortunately it is not possible to virtualize WASI imports and functionality today where the virtualization may eventually delegate to the original implementations. The reason for this has to do with how the original module's linear memory makes its way to the wasi instance. Today this is done via the Caller structure, but this is brittle because once virtualized your Caller is different.
AFAIK we don't have a great answer for this today until we can figure out how to create a WASI instance with a memory or something like that.

This was a major design decision for the component model, so closing.


[MetaSchedule] Filter vector_load_lens based on buffer dtype

This makes the same config generic to work across workloads with different types.
cc @junrushao1994 @zxybazh @spectrometerHBH @masahi

@tvm-bot rerun


[5.2] Model accessors used in custom relationship columns

There is a bug that exists whereby if a model's accessor returns a value other than primitive (such as an array, due to json decoding.etc.), and that same column is used for a join, then the relationship completely fails as an array cannot be used as part of the relationship value.
This PR resolves that by forcing the value to a string, which is great for things like value objects, but should your column return an array or some other object, this will return a value that will still allow the relationship to be resolved.
This is especially useful if values can consist of more than one return type - like a string, and/or array (think custom field values).

Any chance of a test being added please?

@GrahamCampbell I don't think a test is needed here. I'd literally be testing PHP functionality. There's no additional business logic or complexity as a result of this PR.

You need to test that proves you actually need a cast here, otherwise there is no argument for making the change.

Okay that's a good point - I'll add one in to demonstrate the issue.

@GrahamCampbell right, so that manages it - however I think some discussion needs to be had around handling other values. Technically, in the case of array/object.etc. it could create problems in returning a record it shouldn't, so I think maybe even serializing the variable instead of getting the type may be better?
The desired outcome is to have a string return value.

I dunno, this seems odd. I don't think we want foreign key accessors returning things like "StdClass" or something like that and trying to query on it.

I was hoping for more of a discussion on it. Currently were unable to use eager loading because of his issue in a particular use-case. I agree returning the type is odd (and problematic), but is there another solution we can work towards?

@taylorotwell - another idea is to serialize the data or something. It's odd, to be sure - but I'm not sure how else to handle it at the moment.

I feel we should find a solution here, as even casting supported by the library will cause a similar problem if you cast to an array - and it's very hard to debug.


[PE-D][Tester B] Minor bug in handling mode command

Command input: mode fafsf
Before:

After:

It switched mode even with additional inputs after.

Labels: severity.Low type.FunctionalityBug
original: adammangzijun/ped#7

Not a bug, this is intended behaviour.


Machine Controller Locking

Have leader election/locking so that only one machine controller is running in the cluster at a time.
https://github.com/kubernetes/kube-deploy/blob/master/cluster-api-gcp/machine-controller/controller/machinecontroller.go#L94
For locking see:

https://github.com/kubernetes/kubernetes/issues/44857
https://github.com/kubernetes/client-go/tree/master/tools/leaderelection

@scotch-bonnet - have you made any progress on this?

No progress on this yet.

@scotch-bonnet , did you get a chance to make progress on this issue? If not, I might have a try

This issue was moved to kubernetes-sigs/cluster-api#56


Replace import  'BrowserRouter as Route,' to 'BrowserRouter' in examples

Hi, guys!
I did't can understand why my React App doesn't work, it turned out that in examples importing use like
import {BrowserRouter as Router}
and in App used <Router>.
It's confusing.
I have proposal - change import to
import {BrowserRouter}
and use in App <BrowserRouter>

Thanks, but this is pretty common in many areas of the docs and code examples. I think we're going to stick with it for now.


Fix Modrinth Link

🤔 What type of PR is this? (check all applicable)

[ ] 🍕 Addition
[ ] ⌨ Productivity
[ ] 🐛 Bug Fix
[ ] 🔥 Optimization
[ ] ⚙ Configuration
[ ] 🌟 Quality Of Life
[ ] ✨ Enhancement
[x] 📝 Documentation

📝 Description
Button in Readme now Links to to the right Alfheim Modrinth Site

🧐 The Rationale

🎯 Key Objectives

🚦 Testing

⏮ Backwards Compatibility

📚 Related Issues & Documents

🖼 Screenshots/Recordings

📖 Added to documentation?

[x] 📜 README.md
[ ] 📓 Javadoc
[ ] 🍕 Comments
[ ] 🙅 no documentation needed

😄 [optional] What gif best describes this PR or how it makes you feel?

Oh right thanks, I forgot to update it after the slug change


init_empty_weights only works with torchrun is very slow

Running the HF inference example, for "cerebras/Cerebras-GPT-13B" with init_empty_weights can run only with torchrun and as the result init time is ~6x slower on a machine with 4 gpu. 846s vs 134s (from_pretrained(hf_model)).
Error log without torchrun,  https://gist.github.com/HamidShojanazeri/f5c4da7b21717641625015cba04bed99

cc : @jiqing-feng

Hi @HamidShojanazeri . I think you don't need to use init_empty_weights if you only run one process. I will have a look at the init time. BTW, are you running https://github.com/pytorch/PiPPy/blob/main/examples/inference/hf_generate.py ?

BTW added you in Slack to discuss easier pls let me know if you had issues with the invite.

@HamidShojanazeri Sorry for the delay, I am quite busy recently. I only use Teams in my work and I just try to use Slack but didn't find any invitation, could you please invite me again? Thanks!

Fixed via #790, #792, #793.
Previously we have some code that serializes stage initialization. Now it is remove.
According to @HamidShojanazeri, loading 30B model on 4 GPUs takes about 17 second now.


validate command exits on invalid specification file

Describe the bug
When using the validate command for validating the async API specification file, if the file is invalid or has any errors then the cli process exits the process with Error: EEXIT: 1
How to Reproduce
Steps to reproduce the issue. Attach all resources that can help us understand the issue:

Use any invalid file asyncapi validate ./path/to/file/asyncapi.yml
I have used the below one

asyncapi: 2.2.0
info:
  title: Account Service
  version: 1.0.0
  description: This service is in charge of processing user signups
channels:
  user/signedup:
    subscribe:
      message:
        $ref: '#/components/messages/UserSignedUp'
components:
  messages:
    UserSignedUp:
      payload:
        type: object
        properties:
          displayName:
            type: string
            description: Name of the user

            type: string
            format: email
            description: Email of the user

Screenshots

Link to GitHub repository with project that has issues

Files that can help reproduce the issue, like your AsyncAPI file, either paste inside the issue in a code block or in a sharable gist

Expected behavior
Instead of exiting the process we can handle the error and log a statement or so like the asyncapi studio

Hey @chinma-yyy
Can i work on this issue if it gets accepted ? Seems like a reasonable issue. No point in running validations for an inexistent file.

Hey @chinma-yyy Can i work on this issue if it gets accepted ? Seems like a reasonable issue. No point in running validations for an inexistent file.

Actually, I first tried solving the issue and then raised the issue so, the PR is already up.

@Souvikns was this exit not intentional ?


Clustering 512D features using pretrained model

Hi.
I have seen that in your code the default value for feature dimension is 256, also in hfsoftmax pre-trained feature extraction model.
So I am wondering if it is possible to use your pretrained model on my extracted features, which have the dimension is 512?
Besides, is that right that to use GCN-D + GCN-S for clustering, I could test the cluster detection, then test cluster segmentation follow the instruction in https://github.com/yl-1993/learn-to-cluster/tree/master/dsgcn?
Thank you for your concern!

t to use G

Hi @windspirit95
have you find the answer?

@Jar7 @windspirit95 Hello guys, thanks for the discussion! Sorry for the late response, as I have shifted to another field.
I think using 512 or other dimension as feature is totally fine. Note that it is a supervised clustering method, so if the feature extractor changes, the clustering model should also be retrained or finetuned to achieve better results.