@template-covariant type always appears in Uncovered

When analysing following file
<?php

namespace Debug;

/**
 * @template-covariant TEntityId
 */
interface TemplateInterface
{
    /**
     * @return TEntityId
     */
    public function getId(): mixed;

}

With this depfile:
deptrac:
  analyser:
    types:
      - "class"
  paths:
    - ./debug
  layers:
    - name: Foo
      collectors:
        - type: directory
          value: ./debug

I'm getting
 ----------- ---------------------------------------------------------------------
  Reason      Foo
 ----------- ---------------------------------------------------------------------
  Uncovered   Debug\TemplateInterface has uncovered dependency on Debug\TEntityId
              /app/debug/TemplateInterface.php:10
 ----------- ---------------------------------------------------------------------

Using just @template seems to work.

The same problem occurs (arrayAlias reported) when using PHPStan type like this:
/**
 * @phpstan-type arrayAlias array<string, mixed>
 */
class SomeClass
{
    /**
     * @return arrayAlias
     */
    private function someMethod(): array
    {
        return [];
    }
}

The same problem occurs (arrayAlias reported) when using PHPStan type like this:
/**
 * @phpstan-type arrayAlias array<string, mixed>
 */
class SomeClass
{
    /**
     * @return arrayAlias
     */
    private function someMethod(): array
    {
        return [];
    }
}

To be fair in this case it really should be @phpstan-return as you are defining @phpstan-type and therefore the referenced return should also only be scoped to @phpstan.

@psalm-import-type has the same problem

The prefix is not really scoping, tools like PHPStan often introduce some features with prefixed annotation (like @phpstan-return), but later other tools (like PHPStorm) includes such feature in regular annotation (like @return). I have not met a single issue when combining prefixed and non-prefixed stuff since every tool reads annotations of the others. So we use non-prefixed version wherever possible.
But I understand this might be hard for deptrac to be in-sync with all the tools.

I also encountered the same problem. But i just swooped them into the baseline. I mean, it would be nice if deptrac could understand it and work with it, but not a must have i think. Also, there are cases where you define phpstan-return and pslam-return due to different syntax approaches or missing feature in one tool (if you are using both, which i do). So this would also add extra complexity: which return are we then taking into account, or maybe even both?

Currently, I'm using this to avoid this issue in general (as we use only class tokens):
class ExcludeUncoveredHandler implements EventSubscriberInterface
{

    public function handleUncovered(PostProcessEvent $event): void
    {
        $result = $event->getResult();

        /** @var Uncovered $uncovered */
        foreach ($result->allOf(Uncovered::class) as $uncovered) {
            if ($this->isUncoveredIgnored($uncovered)) {
                $result->remove($uncovered);
            }
        }
    }

    private function isUncoveredIgnored(Uncovered $uncovered): bool
    {
        /** @var class-string<object> $class */
        $class = $uncovered->getDependency()->getDependent()->toString();

        try {
            /** @throws ReflectionException */
            $reflectionClass = new ReflectionClass($class);
        } catch (ReflectionException $e) {
            return true; // prevent deptrac bugs like https://github.com/qossmic/deptrac/issues/1399
        }

        return false;
    }

    /**
     * @return array<string, array{string}>
     */
    public static function getSubscribedEvents(): array
    {
        return [
            PostProcessEvent::class => ['handleUncovered'],
        ];
    }

}

services:
  excludeUncoveredHandler:
    class: App\EventHandler\ExcludeUncoveredHandler
    tags:
      - { name: kernel.event_subscriber }

This could catch also other errors no? I would suggest just to utilize the baseline feature. I mean, this is exactly meant for such cases.

We have other tooling to detect non-existing classes in codebase, so this should be safe in our case. If deptrac finds non-class token, it clearly does something wrong and I dont want that to be reported.


Add HTTP2 integration test in CI

to make sure we don't have regression on dropping support for http2 going forward. The test can just be a simple http2 curl call to roapi.

Hey @houqp happy to take this on next if that's ok? Please feel free to assign to me.

sure, thanks!

So I've played around with this a bit and early indications are that testing localhost:8000 for HTTP/2 is not likely to yield results unless we figure out how to run up a server with TLS.
For example:
~ % curl -v --http2 localhost:8080/api/schema
*   Trying <IP_ADDRESS>:8080...
* Connected to localhost (<IP_ADDRESS>) port 8080 (#0)
> GET /api/schema HTTP/1.1
> Host: localhost:8080
> User-Agent: curl/7.80.0
> Accept: */*
> Connection: Upgrade, HTTP2-Settings
> Upgrade: h2c
> HTTP2-Settings: AAMAAABkAAQCAAAAAAIAAAAA
>
* Mark bundle as not supporting multiuse
< HTTP/1.1 200 OK
< content-type: application/json
< content-length: 6579
< date: Fri, 03 Dec 2021 06:22:48 GMT
<
{"uk_cities":{"fields":[<snip>

Update: I've got a possible solution that I would like to sketch out. Essentially I would like to do the following in an integration test:
~ % curl -sI --http2-prior-knowledge localhost:8080/api/schema -o/dev/null -w '%{http_version}\n'
2

So I will check that the curl command there will return 2 (it returns 1.1 if the server does not support HTTP/2).
Notes:
When you use http2-prior-knowledge you are essentially saying that I expect my server to respond with HTTP/2 and I do not want to degrade to HTTP/1.1. See:
https://everything.curl.dev/http/http2
https://curl.se/docs/http2.html#:~:text=curl offers the --http2-prior-knowledge command line option,by default for HTTPS connections.

@novemberkilo There are already some integration tests that use Reqwest. There is an option to set the HTTP version on the request: https://docs.rs/reqwest/latest/reqwest/struct.RequestBuilder.html#method.version
Maybe that will do as well?

that http2-prior-knowledge option is very cool, thanks @novemberkilo for discovering that :D . I am cool with us going either way (curl v.s. reqwest) as long as we are testing http2 end to end.


Program admins can see a filterable, paginated list of applications their program has received

As specified in this doc, program admins should be able to see a list of all applications to their programs in a two-pane view. They should be able to filter viewable programs using a few filters specified in the doc. In addition, they should only see a limited number of applications on one page (50?) and have to click to other pages to see the rest. This will be become important as the admins get 1000s of applications.

That doc doesn't specify a two-pane view.  Do you see that as mandatory?

LGTM


Exporting with translations breaks the first time

Tested versions
v4.2.1.stable.official [b09f793f5]
System information
Windows 10, Godot 4.2.1
Issue description
We recently added translation files to our project and this broke our CI/CD workflow. The generated pck or zip file would not include 90% of our non text assets. Upon further investigation it turns out that when adding (csv) translations it seems it is required to export the project twice. The first time will just create the packfile with only the .remap files and create the .godot folder. The second time it would work as expected. I also noticed that the first export takes considerable time for engine shutdown/cleanup and leaks a lot of resources. The console text is also broken with the cursor being a couple lines above the last output print (for both exports)
Also of note: before applying this fix here #88868, the second export would always segfault (for our full project not the attached MRP)
first export:

second export:

Steps to reproduce

download the attached project
export with godot.exe -e --export-pack windows test.zip --headless
resulting zip file will be missing all textures and meshes and be around 550kb
export again with godot.exe -e --export-pack windows test.zip --headless
resulting zip file will be around 22mb

Minimal reproduction project (MRP)
mrp.zip

After some further investigation. Even a double export doesn't fully solve the issue. A few resources are still not exported.


Adds support for skin variants

This pull request adds support for skin variants which will land in iOS 8.3 and OS X 10.10.3
To get this working I had to add some additional methods added to EmojiChar and update the emoji.json
I'll happily adjust the code should there be any issues with it.
Thanks for building this in the first place. This literally saved my sanity today.

Coverage decreased (-0.97%) to 99.03% when pulling 1aa8dc2465705f60df3604159d98c4b486221ba5 on benedikt:master into 3f1885bcdc39c086cb9fda17704ee7ea4360e4ec on mroth:master.

Coverage decreased (-0.97%) to 99.03% when pulling 1aa8dc2465705f60df3604159d98c4b486221ba5 on benedikt:master into 3f1885bcdc39c086cb9fda17704ee7ea4360e4ec on mroth:master.

Coverage remained the same at 100.0% when pulling f710e7fe81dd6a2676e557992f589781a599ee74 on benedikt:master into 3f1885bcdc39c086cb9fda17704ee7ea4360e4ec on mroth:master.

Coverage remained the same at 100.0% when pulling f710e7fe81dd6a2676e557992f589781a599ee74 on benedikt:master into 3f1885bcdc39c086cb9fda17704ee7ea4360e4ec on mroth:master.

Coverage remained the same at 100.0% when pulling f710e7fe81dd6a2676e557992f589781a599ee74 on benedikt:master into 3f1885bcdc39c086cb9fda17704ee7ea4360e4ec on mroth:master.

Coverage remained the same at 100.0% when pulling f710e7fe81dd6a2676e557992f589781a599ee74 on benedikt:master into 3f1885bcdc39c086cb9fda17704ee7ea4360e4ec on mroth:master.

This is fantastic, thank you for doing this!  I will try to review soon.

Added some line notes.

Some additional questions:

Do you have a device/OS that generates the new emoji and have tested that we properly decode them? I don't think the emojidata.json project is unit tested so I want to make sure we aren't taking for granted as source of truth something that isn't correct.
I think we should probably figure out how to represent the notion of preserving the skin tone of an emojichar once we decode it.  Going from unicode string -> EmojiChar representation it previously didn't matter if we preserved the notion of whether it was variant encoded or not (since those variations were not semantically relevant), but I imagine for these once we decode we will need to have the Object have some awareness of it's "active" skin encoding if present, which would be carried forward into the default render behavior. (Since a number of applications use this library in a unicode -> object representation -> unicode pipeline).

Thanks for bearing with me on this, this actually represents a very large upgrade for EmojiData (again, thank you!), so we need to make sure its bulletproof before pulling in and subsequently porting the logic to other platforms.

@bendikt Apologies, I finally have time to get back to this.  I appreciate massively the work you've done. :bow:
I've re-reviewed this in more detail now.
My thinking in terms of where we would go from here:

Some sort of an active_skin_variant property in EmojiChar (defaulting to nil I assume?), which would be taken into considering when render-ing and properly detected during a scan decode.  Unlike the unicode variation selectors, these skin tone variations have semantic meaning that it is important to preserve.
Update to the latest emoji-data json with the iOS 9.1 emojis (Optional but maybe easier to do in one shot)
Do some baseline performance benchmarking to make sure nothing went crazy with all the additions (I can assist with this).

Is this something you'd be willing to take on? (I promise I can be more active in reviewing now! Including pairing if helpful).

Just a heads up re: updating to latest emoji-data json.
There appear to be characters in there that are regular expression special characters and lead to this error when creating FBS_REGEXP:
RegexpError: target of repeat operator is not specified
from lib/emoji_data.rb:136:in `initialize'

I'm guessing it's the keycap_star character that renders as an asterisk. Using Regexp.escape on each char when generating the regular expression seems to alleviate this issue.
FBS_REGEXP = Regexp.new(
  "(?:#{EmojiData.chars({include_variants: true}).map{|ec| Regexp.escape(ec)}.join("|")})"
)

More than happy to create a PR for updating the json with this fix in the near future.

You might want to look at Regexp.union as well.
If there's any way I could help with merging in this and #4 so we can recognize new emoji, I'd be happy to volunteer!

@bhollis if you want to give it a stab, I'd be grateful! I've been pretty tied up with a number of other projects and this has been lower priority.
(We can chat on IRC or whatnot if that would help coordination. I'm typically on freenode in #emojitracker.)


Remove register endpoint

Description
Removed register from module
Issue ticket number and link
Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my code
[x] I have made corresponding changes to the documentation
[x] Any dependent changes have been merged and published in downstream modules

Please use and fill in the provided github PR template for all module PRs

Updated readme and template.

Updated the PR description and pushed latest changes.

For the hook, probably it shouldn't know about 'profile'. Please let me know how this was handled in other cases. Or maybe changes are needed in pcbs-profile. cc @hosszukalman @nemvalid
Thanks!

@hosszukalman
I pushed changes addressing most of the changes.
I can't use the uniqueness validator as that one works only for records and we need it for users here.
Also, in the user module I'm merging errors coming from the hook with "hash_assign object['errors'] = object['errors'] | hash_merge: result[1]['errors']" so that we have available in the form what the hook says it's not working.
@nemvalid The readme should be updated and all modules should be using the template now.
Thanks!


[otbn] Register representation in python for otbnsim

Python integers are infinite width and signed, bignum registers are a fixed 256-bit width and are not particularly signed or unsigned (though there's no bignum instructions that operate specifically on signed numbers in particular all multiplies assume unsigned integers).
We need a uniform way to map bignum registers on to Python integers.
I would suggest we write things in such a way that integers representing registers are always positive and in the range 0 - (2^256 - 1). Assertions should be used to check all registers match these requirements an appropriate point (e.g. when they are used by an instruction).
Similar consideration needs to be applied for the base registers.

We can do as you suggest, but that means re-writing Stefan's Register class. (No biggie, and I think it would remove the last dependency on his simulator).
Alternatively, we keep with what currently exists, where the Register class internally stores a signed number (the 2's complement intepretation of the 256 bits stored in the register) and you call my_register.unsigned() to get the unsigned interpretation. Since I don't really see any benefit of changing this, I'd do that.

I'm convinced about the "unsigned everywhere" approach, but think it's better to hide the representation and just provide "read_signed" or "write_unsigned" accessors, so it's super explicit. I'm hacking on code to do this now: how hard can it be? :-)


Error when running

I'm running into issues running my json in aws batch based off of the user guide.
My first issue was with S3 permissions and I'm still not sure what is causing this as I am using the same AWS account between S3 and Batch. Setting the bucket and all child objects to public gets it working but I don't want to run it like this beyond initial testing.
I'm hoping this is just a formatting issue with my json.
Thanks,
Ivan De Dios
logs-insights-results.txt
SS-10436446-MY-022820.json.txt

Hi Ivan,
For the S3 permissions issue, are you talking about the bucket provided as the GenomicsS3Bucket parameter?
If yes, well give the following permissions to the AWS Batch compute environment and job definition. Was there a specific permission you found was missing?
            Action:
            - "s3:GetBucketLocation"
            - "s3:ListBucket"
            - "s3:ListBucketVersions"
            - "s3:GetObject"
            - "s3:GetObjectVersion"
            - "s3:PutObject"
            - "s3:ListMultipartUploadParts"
            - "s3:AbortMultipartUpload"
            Resource:
            - !Sub "arn:aws:s3:::${GenomicsS3Bucket}"
            - !Sub "arn:aws:s3:::${GenomicsS3Bucket}/*"

@partha-edico -
can you look at this error when executing d_haul and suggest what might be causing it?
@timestamp	@message
2020-04-09 01:35:52.865	TypeError: cannot concatenate 'str' and 'list' objects
2020-04-09 01:35:52.865	    self.new_args[self.fastq_list_index] = self.input_dir + filename
2020-04-09 01:35:52.865	"  File ""/root/quickstart/dragen_qs.py""	 line 288	 in download_inputs"
2020-04-09 01:35:52.865	    dragen_job.download_inputs()
2020-04-09 01:35:52.865	"  File ""/root/quickstart/dragen_qs.py""	 line 502	 in main"
2020-04-09 01:35:52.865	    main()
2020-04-09 01:35:52.865	"  File ""/root/quickstart/dragen_qs.py""	 line 509	 in <module>"
2020-04-09 01:35:52.865	Traceback (most recent call last):
2020-04-09 01:35:52.865	Executing python /root/quickstart/d_haul --mode download --url https://genomic-compute.s3-us-west-2.amazonaws.com/dragen-reference/GRCh37/targeted-regions/DHS-3501Z.GRCh37.roi.bed --path /ephemeral/inputs/

@vsnyc Not sure how this was running before  .... but looks like there were a couple of recent changes that were missing in the aws master repo

@partha-edico thanks for the pull request, I'll merge it and run through our tests. Looking at the history, it looks like you may have committed your change to your fork but not issues a pull request against this repo.
As to why it has been working, I had updated the policy in January in commit:
https://github.com/aws-quickstart/quickstart-illumina-dragen/commit/e5ad3acbbb2c806554bde4bc39265aca74d0d44c based on an email thread.
Would the code update for package, solve the above issue when using d_haul script?

Hi Ivan,
For the S3 permissions issue, are you talking about the bucket provided as the GenomicsS3Bucket parameter?
If yes, well give the following permissions to the AWS Batch compute environment and job definition. Was there a specific permission you found was missing?
            Action:
            - "s3:GetBucketLocation"
            - "s3:ListBucket"
            - "s3:ListBucketVersions"
            - "s3:GetObject"
            - "s3:GetObjectVersion"
            - "s3:PutObject"
            - "s3:ListMultipartUploadParts"
            - "s3:AbortMultipartUpload"
            Resource:
            - !Sub "arn:aws:s3:::${GenomicsS3Bucket}"
            - !Sub "arn:aws:s3:::${GenomicsS3Bucket}/*"

@vsync sorry for the late reply. Thanks for the S3 permissions help, I was able to resolve that. It looks like I'm still getting that python error when running:
Executing python /root/quickstart/d_haul --mode download --url https://genomic-compute.s3-us-west-2.amazonaws.com/dragen-reference/GRCh37/targeted-regions/DHS-3501Z.GRCh37.roi.bed --path /ephemeral/inputs/

@IvantheDugtrio The download_s3_object method has changed in the last merge commit I did on April 3 in commit 36f53ffb33a93b03daf5062eb011fbaee7962748. Could you confirm you've used that? If not, would it be possible for you to retry with the latest template?

@IvantheDugtrio @vsnyc I think the latest changes could help.
But also, please do not put a trailing 'slash' when specifying an S3 path or bucket, i.e. please remove it from
"s3://genomic-compute/dragen-reference/GRCh37/"
and
"s3://genomic-compute/dragen-scratch/Phase-ins/Q275/AWS-F1-040720/",
I don't think the QS script currently strips the trailing '/' which could cause problems when running.

@partha-edico @vsync Thanks for all the help!
Do I need to make a new stack in CloudFormation to pull the latest version?

I believe you have to delete the current CF stack and rebuild a new one to be sure, but perhaps Vinod can confirm.

So I made a new stack but now I can't figure out why none of my jobs move from "Runnable" to "Starting". I made the new stack using the same config as before and the same VPC and subnets so I don't understand.

@IvantheDugtrio I wouldn't know specifically what is happening in your case, but from my experience sometimes I have found not enough info on the console when I had problems.
In those cases it is helpful for me to use the CLI to query the batch status:
https://docs.aws.amazon.com/cli/latest/reference/batch/index.html
describe-compute-environments
describe-job-definitions
describe-job-queues
list-jobs
describe-jobs

I'm going to close this for now as I have to take on other projects.


update for ocaml 4.14-dev, latest distro list and bump ci-local versions

Pushing to live-engine to try it out


Add client line item tests

Closes #23 and #24.

Looks like there is some unrelated crystal breakage, but I think the tests are more or less complete. Any feedback on the tests while I debug the crystal issue? PATCHing /api/clients/:id/clock_in feels a little strange, for example. Is it okay for a url resource to be a verb?

Just thinking out loud here... it seems a little more RESTful to just clock in with a POST to /api/clients/:id/line_items, and then PUT or PATCH /api/clients/:client_id/line_items/:id to clock out. But that seems a little too low-level to me. Clocking in and out is arguably the core of what Eboshi is, so I'd like to expose that high level concept via the API. I guess the question really boils down to: is this API an app, or a REST wrapper around db tables?

Maybe a singleton clock resource that you POST and DELETE?

Building an API that is a wrapper around tables seems like a terrible idea.  Are you familiar with the original ideas around REST?  That is, hypermedia as the way to update application state?

I'm glad you agree that the API should be high level. I'd say I have a middling-to-good understanding of REST, not great. I'm not super clear about the theory behind HATEOAS, etc.


fix empty imagePullSecret for service scope wasmplugin in ambient

Please provide a description of this PR:
Please provide a description of this PR:
https://github.com/istio/istio/issues/51288
Fix empty image pull secret in ambient mode when wasmplugin targetRefs are services.
This PR is same as #53781.
Apologies for the confusion caused by an accidental rebase in the previous PR. I’ve created a new one to resolve this.

@MaYuan-02: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
64f03c5c14e408ccf34ca24c3800245917bb0869
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@howardjohn @ilrudie
The last reviewed commit was “fix ListAuthorizationPolicies.” I’ve made the changes based on your feedback and adapted it to the master branch. Sorry for the inconvenience caused by reopening the PR.

@MaYuan-02: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ambient_istio
8144127a51cf336291e5b04472558375535cc7cc
link
true
/test integ-ambient

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

/retest-required

@MaYuan-02: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ambient_istio
d122257aa9ef973d576828a21741f4716c8b7c0d
link
unknown
/test integ-ambient

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

/retest
On Tue, Dec 17, 2024 at 8:36 AM Istio Automation @.***>
wrote:

@MaYuan-02 https://github.com/MaYuan-02: The following test failed,
say /retest to rerun all failed tests or /retest-required to rerun all
mandatory failed tests:
Test name Commit Details Required Rerun command
integ-ambient_istio d122257
https://github.com/istio/istio/commit/d122257aa9ef973d576828a21741f4716c8b7c0d
link
https://prow.istio.io/view/gs/istio-prow/pr-logs/pull/istio_istio/54232/integ-ambient_istio/1869048657471344640
unknown /test integ-ambient
Instructions for interacting with me using PR comments are available here
https://git.k8s.io/community/contributors/guide/pull-requests.md. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes-sigs/prow
https://github.com/kubernetes-sigs/prow/issues/new?title=Prow issue:
repository. I understand the commands that are listed here
https://go.k8s.io/bot-commands.
—
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/54232#issuecomment-2548975422, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEYGXLAFQ7HUTICNN22GUD2GBHJLAVCNFSM6AAAAABTHLLB2KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNBYHE3TKNBSGI
.
You are receiving this because you were mentioned.Message ID:
@.***>

Thanks @MaYuan-02 !


allow sending in bch

Allow users to select if they would like to send in their own currency or in bch.

This would be extremely useful.


Is there any special right granted by 'group ownership'?

From what I'm reading, the owner of a file always has "change security", even when otherwise removed or denied.
Is there any special permission that's always granted to the group which owns a file?  If not, it might be useful to explain that it's only really used and assigned when inheriting ACLs which contain ACEs for CREATOR_GROUP (SID S-1-3-1) [assuming that I understand its use correctly -- if I don't, then I haven't been able to figure out what it's used for].

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f59cc28c-947c-e661-03f1-41027669af88
Version Independent ID: a3234bb3-d6b8-47e0-0d10-b19cc7a14bbb
Content: Security Descriptors - Windows drivers
Content Source: windows-driver-docs-pr/ifs/security-descriptors.md
Product: windows-hardware
Technology: windows-devices
GitHub Login: @lorihollasch
Microsoft Alias: loriwhip

Nothing "special", beyond that each user within the group would then have "Change Security", "even when otherwise removed or denied" (except now removing a user from said group will effectively cancel this)
That can be useful for its own purposes, suppose a user transfers departments but they are still a manager of permissions over certain groups, now you just move them to gardening_owners_group from cashiers_owners_group and they lose "change security" over cashier_files and gain "change security" over gardening_files, without ever explicitly changing the user's permissions.(so you don't have to adjust each user's granular permissions but instead manage which permissions-based group they belong to)

Sorry "this" is ambiguous, effectively cancel the removed-user's "Change Security" permissions, while leaving the Group's permissions in-tact

@kyanha , sorry for my late response to this issue! I'm closing it since @deftclaw answered your question (thanks, @deftclaw !), and since there isn't anything to add to the device driver documentation. The SDK has lots of information about DACLs - this page seems relevant to your question.


hello world smart contract

A hello world smart contract in solidity.

A hello world smart contract in solidity.

Hey this look's great ! Please mention the directory in which u want to add this code  file .Then i will assign this issue to u  .
Happy learning ✌

A hello world smart contract in solidity.

Hey this look's great ! Please mention the directory in which u want to add this code file .Then i will assign this issue to u . Happy learning ✌

In the contracts folder present in the truff directory

A hello world smart contract in solidity.

Hey this look's great ! Please mention the directory in which u want to add this code file .Then i will assign this issue to u . Happy learning ✌

Web3.0-World/Level2/MetaNft_Minting/Truff/contracts

Nope u can't do like this .U have to make ur own file for hello world and create ur own truffle structure.Iin this way u will destroy the working of the MetaNft_Minting.

@Vikash-8090-Yadav Is someone still working on this hello world contract ??

@srinjoy-26 are u still working on this issue
?

@AnmolSirola u can work on  this now if u want...

Okay Sir I will work on it . I just want to ask that I have to only create a smart contract inside remix or in my own ide with truffle/ganache.

yes you have to work  on your ide with the Ganache , truffle and make frontend with the smart contract ...

Okay Sir will do it but I need some time

@AnmolSirola  any update ?

Sir, I wont be able to do it because my end sems are going on right now .

@AnmolSirola any updates ?

@Vikash-8090-Yadav Forgot about this issue also working on twitter dapp wont be able to complete this one

Close this then @Vikash-8090-Yadav

@Vikash-8090-Yadav I guess this issue was cursed , that's why no one completed it


URL matcher

Read the documentation before reviewing the code to have a better context.

Thank you @BurnzZ for your review, I've addressed your comments. I'm going to merge this PR and create a new one that can be reviewed properly (sorry for the mess with the files)


Status of the shoppe project

I've been evaluating Rails based e-commerce solutions for an upcoming project. Shoppe looks ideal however I have some concerns about the project, getting help and support and the community around it.
The Google mailing list  has very little activity and there hasn't been an answer to a question for about a year.
The blog is a dead link.
The Twitter Feed  has only one tweet on it.
The commercial support doesn't seem to link anywhere.
There are a few sporadic answers to queries within these issues (which I appreciate is not really the right place for questions on how to do things).
It feels like Shoppe was created for a specific purpose and then open sourced as a bit of a side project. That development is done only really to aid its original use, rather than as a true open source project. And that it's not actually in use in many real world situations.
Don't misunderstand I'm not criticising this approach, it's a very generous thing to open source something that you have created. And I totally understand that the time it takes to answer give help and support (especially to newbies) is hard to come by.
I'm just trying to understand that if we do choose to use Shoppe then to a large extent we should assume that we are on our own and that help and support isn't available (even paid).
Can any of the project owners shed some light on the situation with Shoppe and any future plans for it?

I have posted issues and got answers within 1-2 days

Hey, I understand your concerns. It might be best to bring @adamcooke in to answer as he's the creator 🙂

I have no future plans for Shoppe at the moment. As you've mentioned, we built it for our own use. I haven't, personally, had the time to do any work on it. In light of that, I can't guarantee where it will go in the future at the moment.
I would say that it is best used by someone with experience who is able to debug any issues themselves.


Adding shridharkapshikar file

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[ ] My change requires changes to the documentation.
[ ] I have updated the documentation accordingly.
[x] All new and existing tests passed.
[ ] This PR does not contain plagiarized content.
[x] The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

@shridharkapshikar the page is not automatically deployed when profiles are added which is why it’s not there yet. I’ll trigger a manual deployment now so it should appear shortly


docs: fix typo in README.md

Codecov Report
Patch and project coverage have no change.

Comparison is base (549beec) 99.68% compared to head (b79e572) 99.68%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4119   +/-   ##
=======================================
  Coverage   99.68%   99.68%
=======================================
  Files         214      214
  Lines       13799    13811   +12
  Branches     3237     3242    +5
=======================================
+ Hits        13755    13767   +12
  Misses         41       41
  Partials        3        3

see 2 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


[Azure SignalR Service - Azure Web PubSub] API Review

New API Review meeting has been requested.
Service Name: Azure SignalR Service - Azure Web PubSub
Review Created By: Siyuan Xing
Review Date: 06/14/2023 09:00 AM PT
Onboarding Record:
PR: https://github.com/Azure/azure-rest-api-specs/pull/23927
Hero Scenarios Link: Not Provided
Core Concepts Doc Link: Not Provided
Description:  add new version stable/2023-07-01
Detailed meeting information and documents provided can be accessed here
For more information that will help prepare you for this review, the requirements, and office hours, visit the documentation here

Notes from API Review meeting 6/14/23

Unclear how "connectionFilter" works for addToGroups.
Should rename "filter" to "connectionFilter"? Maybe not.
Maybe improve the description to explain how connectionFilter is used to get a filtered list of connections, and these are added to the groups.
Add a link to the OData filter conceptual docs
But the EBNF in the Syntax section has great potential for confusion -- should probably remove it.  The full formal grammar is shown later in the page.
Search team made their EBNF interactive -- and it looks like that's also the case here
AddTo and RemoveFrom should be idempotent ... seems like they are.  Good.
Min and max values on messageTtlSeconds. Better to just put these in the description and not as formal attributes.

This looks good for GA after addressing the above.


Create Vagrant File for new environment

 Issue by w1stler
Thursday Aug 11, 2016 at 17:48 GMT
Originally opened as https://github.com/stxnext-csr/volontulo/issues/569

As a new programmer,
I want to easily set-up new environment,
In order to start work on tickets

 Comment by krzysztofzuraw
Tuesday Aug 30, 2016 at 06:14 GMT

@magul we want to go ansible or fabric? I'm more onto fabric because:

we already have fabfile
it is easier than ansible to setup

What do you think?

 Comment by magul
Tuesday Aug 30, 2016 at 08:07 GMT

@krzysztofzuraw fabric it is!

Duplicate, closing
#495


occurrences_between gives results in unexpected time zone

I'm creating a schedule with recurrence rules, and when I create one with a weekly recurrence rule, then I run occurrences_between(begin, end), it gives me the results in the time zone of the begin value passed in. However, when I create a schedule with a daily recurrence rule, and I run occurrences_between(begin, end), it gives results in UTC.
Relevant code:
def schedule(starts_at = nil, ends_at = nil)
  starts_at ||= scheduled_from
  ends_at ||= scheduled_to
  if duration > 0
    s = IceCube::Schedule.new(starts_at, end_time: ends_at, duration: duration)
  else
    s = IceCube::Schedule.new(starts_at, end_time: ends_at)
  end
  case repeats
  when 'never'
    s.add_recurrence_time(starts_at)
  when 'daily'
    if repeat_ends == 'never'
      s.add_recurrence_rule IceCube::Rule.daily(repeats_every_n_days)
    else
      s.add_recurrence_rule IceCube::Rule.daily(repeats_every_n_days).until(repeat_ends_on)
    end
  when 'weekly'
    days = repeats_weekly_each_days_of_the_week.map {|d| d.to_sym }
    if repeat_ends == 'never'
      s.add_recurrence_rule IceCube::Rule.weekly(repeats_every_n_weeks).day(*days)
    else
      s.add_recurrence_rule IceCube::Rule.weekly(repeats_every_n_weeks).day(*days).until(repeat_ends_on)
    end
    [...additional config irrelevant to this piece...]
  end
end

Sorry for the late reply...
All the occurrences methods on schedules return the time zone of the schedule itself, which comes from schedule.start_time. Can you confirm what kind of time you are creating your schedule with?
I will reopen this if it still needs further attention.

I'm no longer working on that project so I can't remember any other details. If I find time to investigate this further and still see a problem, I will update.


Use reflection to call cleaner on direct byte buffers in JDK9

In JDK9 sun.misc.Cleaner is replaced with java.lang.ref.Cleaner$Cleanable, a class with a method void clean() just like the old cleaner. By using a method reference we don't need to know if the class is one or the other.

@varming one question...
Could you also please update the commit message to match our template:
http://netty.io/wiki/writing-a-commit-message.html
I will also setup a CI job that will test netty with java9 today.

Oops, I forgot about the commit message template. Fixed.

No worries please fix for the other prs as well

Am 30.06.2016 um 14:05 schrieb Carsten Varming<EMAIL_ADDRESS>Oops, I forgot about the commit message template. Fixed.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub, or mute the thread.

I updated the other PRs.
BTW. It looks like the test run got stuck.

Cherry-picked into 4.1 (34d8b514d7a3b62e6101bade10a445bc448a0e65) and 4.0 (5b92adae1d5529010410d64644e6f039779fd718)


Im not able to get the Aggregators or filter

Hmm, it seems like you have some CSS on the page which is hiding them!

Awesome, Materilize CSS was actually hiding them. Thanks a lot. PivotTable JS is fantastic


error code 2

Does someone have a solution for exit code 2? it's about the fact that the programm is looking for a file somewhere where is doesnt exist, I'd also like to add that when creating the file I didn't add that special  string because it didnt show up for me. (I get that error on the cuda test) full error here: C:\Users\David\miniconda3\envs\pythonProject\python.exe: can't open file 'C:\Users\David\PycharmProjects\Brawl_bot\pythonProject\main.py': [Errno 2] No such file or directory
Process finished with exit code 2
(Hope I was helpful)

hi, can you send a full screenshot of the issue?

this is how it looks

how are you running main.py? Are you using the play button on pycharm or terminal?


Set proxyBeanMethods = false on configuration at build time when possible

See  spring-projects-experimental/spring-graalvm-native#248 for more details. We could probably start by doing such transformation only on configuration classes without @Bean to handle the default @SpringBootApplication case. Step 2 could be to do this transformation only if there is no cross @Bean method invocation. cc @aclement

Currently we don't modify user's code. I don't like doing that really. Don't you think it would be better to warn or fail?

I understand your hesitation but at the same time supporting Spring Boot application unchanged from a programming model perspective is a mandatory goal of ours IMO.
About that @aclement has raised a very interesting point that could change the scope of that issue.

With build time transformation it is possible to behave in the right way out of the box by modifying configuration classes directly to include the necessary guards around multiple requests to a bean method without creating any proxies... I wrote some code to do this in here: https://github.com/aclement/spring-boot-nox/blob/master/src/main/java/io/spring/nox/optimizer/collectors/ConfigurationClassCollectorRewriter.java#L195 - always correct behaviour with no configuration proxies.

I am not sure what kind of modification will be needed, but I tend to think some kind of modification on configuration classes will be needed at least for those with cross @Bean method invocations.

Latest snapshots now support proxyBeanMethods=true by generating subclass implementations at build time and using those in the initializer.


Capture last install/synced Pipfile.lock hash in virtualenv to skip redundant installs/syncs

I'm always frustrated when install/syncs take significant amounts of time when the lockfile hasn't changed. It'd be handy to have this handled automatically.
We can capture last installed/synced Pipfile.lock hash (meta/hash or similar) in virtualenv directory to skip redundant installs/syncs.
Command line parameters, redirecting to other files, and makefile/other infra changes are more time intensive workarounds that require pipenv introspection. Capturing hashes per venv would be a handy universal solution.

Hi @narfman0!  Thanks for using pipenv!  I'm wondering what version of pipenv you are using?  We added in a lot of caching features to help speed the process up.  I do not experience a slow down in sync/install unless I have to relock.  If you want to work on an example of how it could speed things up we welcome contributions!

Pipfiles are the source of truth for a pipenv managed virtualenv.  The minute your pipfile has changed, you need to re-resolve dependencies.
Hashes of the pipfile are already tracked, and we are tracking the overall performance concerns in a few other places, but it is not exactly straightforward to handle.  Just because the lockfile indicates that something was installed doesn't mean it actually is installed, so whenever we run an installation we let pip confirm that the packages specified are actually installed.

Thanks for the feedback! I made an example repo here: https://github.com/narfman0/pipenv-speed-test.
My version is from osx, brew installed, 2018-7-1. After everything was installed, rerunning the command took 0m12.391s. Is this time is expected?
pipfile.lock itself is not a source of truth, but after pipenv is installed/syncd, we would know we are up to date. For a typical user, if the locks contents are the same next time we run the command, could we not at least add an argument to skip actually checking with pip if someone did something unexpected or nefarious?
Is this optimizing for users that dont follow pipenv conventions without giving those following a way around it? Perhaps an extra argument and warning, not impacting usage unless explicitly invoked. I might be able to provide a reference implementation.

Hey, I'm think I'm bothered with the same issue. The first step in my make test target is pipenv sync --dev, so that the CI or the person who just cloned the repo can just run the tests without going through any setup steps. The problem is, even if I run pipenv sync a couple of times in a row, it always takes about 10 seconds for me.
Another issue for me is that in this case sync requires a connection to the Internet, which I don't always have when I'm moving around (and working).
I guess this could be mitigated by a fast comparison of, for example pip freeze and the versions in the lock file. Is there something fundamentally wrong about this assumption?
@erinxocon I guess this issue should be reopened. I'm using the newest pipenv - 2018.7.1

Run a pip freeze first sounds like a good workaround to me. This would however induce a overhead and would slow things down if you only have a few packages. Some benchmarking would be needed to determine whether this is worth it.

For the case of a single dependency (just installed port_for), which is probably quite uncommon, pip sync takes ~1.0s. Pip freeze (running after pipenv shell) takes ~0,38s. Taking that 0,4 seconds where you expect it to run far longer when there are actually dependencies to install is probably not that big of a deal. But then again saving 9,6s when you don't need to do anything, which is often, sounds really nive.


Gpu support for slurm?

Is there any option for requesting a slurm compute node with a gpu here?
Best
Craig

I think that maybe, just like on this gist, using launch-cmd you can specify partition and resources.


Reduce reserves to 10/2

The current network reserves are 10/2 as against the older 20/5. These reserves have been in force for long enough that new validators should not have to vote explicitly for this.

Feel free to steal those changes, and this PR can potentially be merged before the other one.
Thanks! It's probably better to keep this PR as simple as possible so that it can be merged quickly. I've just updated the unit tests that were broken. We want to avoid any chance of "fee flip-flopping" in production voting.

Longest suite times:
   63.5s ripple.tx.Offer
   62.4s ripple.tx.NFTokenBurn
   62.1s ripple.tx.NFToken
   44.4s ripple.app.TheoreticalQuality
   35.3s ripple.app.ValidatorSite
   31.3s ripple.rpc.NodeToShardRPC
   30.8s ripple.app.ShardArchiveHandler
   27.5s ripple.tx.NFTokenDir
   23.5s ripple.app.ReportingETL
   18.8s ripple.app.AccountDelete
606.0s, 204 suites, 1527 cases, 532147 tests total, 0 failures


Initial commit for web UI/API

Web UI first pull
Django REST framework magic
Sadly no tests yet

This isn't an urgent merge—a PR is the easiest way to share what I've been working on.

I added a handful of comments, but I'm okay merging this as is. Nice work!

:+1: Merging now


dolt pull allowed me to stomp my dirty working set

Repro:

Be behind remote master
make a local change
dolt pull
Local changed overwritten

This should fail and tell me to reset or commit.

Test added in #422

Fixed by #436


fix: Initializer checks across txs

The approach in #4807, where I pushed a note-hash for signalling initialization and then pushed a read-request to check initialization later, didn't work. It worked only when initialization is checked in the same tx as the initialization happens. If it happens on a different tx, the note-hash gets siloed and hashed with a nonce before getting added to the note hash tree. While we can silo from the contract (since the contract knows its own address), we cannot hash with the nonce since we don't know it. This nonce is typically stored as part of the associated note in the PXE db, but in this case, we are pusing a note commitment without an associated note. Not only that, but the PXE today just doesn't support read requests not related to a note in the local db.
So this PR changes that approach to just use the nullifier, which was the original idea, since it does not require emitting two pieces of data. It works because nullifiers are siloed but they are not hashed with a nonce, so it's possible to reconstruct them when checking initialization. However, since we don't yet support reading a nullifier in the same tx (or same block even) that it was created, we need to wait for the initialization tx to be mined before we can call any function in the contract.

Benchmark results
No metrics with a significant change found.

Detailed results
All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call  to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.
This benchmark source data is available in JSON format on S3 here.
Values are compared against data from master at commit 237f870c and shown if the difference exceeds 1%.
L2 block published to L1
Each column represents the number of txs on an L2 block published to L1.

Metric
8 txs
32 txs
128 txs

l1_rollup_calldata_size_in_bytes
54,212
214,436
855,332

l1_rollup_calldata_gas
259,904
1,019,792
4,060,100

l1_rollup_execution_gas
354,090
1,139,240
4,281,501

l2_block_processing_time_in_ms
1,203 (-1%)
4,962 (-2%)
18,101 (-1%)

note_successful_decrypting_time_in_ms
204 (+1%)
598 (+3%)
1,961

note_trial_decrypting_time_in_ms
14.4 (-10%)
135 (+13%)
168 (+2%)

l2_block_building_time_in_ms
16,103 (+1%)
63,914 (+1%)
258,789 (+1%)

l2_block_rollup_simulation_time_in_ms
12,329 (+1%)
48,952 (+1%)
199,215 (+1%)

l2_block_public_tx_process_time_in_ms
3,740 (+1%)
14,883 (+1%)
59,285 (+1%)

L2 chain processing
Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric
5 blocks
10 blocks

node_history_sync_time_in_ms
15,055 (-2%)
29,205 (-1%)

note_history_successful_decrypting_time_in_ms
1,281 (-11%)
2,492 (-4%)

note_history_trial_decrypting_time_in_ms
132 (-16%)
212 (-19%)

node_database_size_in_bytes
19,075,152
36,548,688 (+1%)

pxe_database_size_in_bytes
29,923
59,478

Circuits stats
Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit
circuit_simulation_time_in_ms
circuit_input_size_in_bytes
circuit_output_size_in_bytes

private-kernel-init
239 (-2%)
44,664
27,457

private-kernel-ordering
155 (-1%)
45,777
14,627

base-rollup
1,306
175,344
933

root-rollup
71.3 (-1%)
4,192
825

private-kernel-inner
306 (-1%)
73,099
27,457

public-kernel-app-logic
187 (-1%)
32,254
25,379

merge-rollup
5.77
2,712
933

Tree insertion stats
The duration to insert a fixed batch of leaves into each tree type.

Metric
1 leaves
2 leaves
8 leaves
16 leaves
32 leaves
128 leaves
64 leaves
512 leaves
1024 leaves
2048 leaves
8192 leaves

batch_insert_into_append_only_tree_16_depth_ms
10.0
10.7 (-7%)
13.1 (+3%)
16.8 (+1%)
22.4 (+1%)
63.1 (-22%)
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_16_depth_hash_count
16.9
17.5
23.0
31.6
47.0
143
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_16_depth_hash_ms
0.578
0.595 (-7%)
0.552 (+3%)
0.520 (+1%)
0.467 (+1%)
0.435 (-22%)
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_32_depth_ms
N/A
N/A
N/A
N/A
N/A
75.6 (+3%)
46.2
234
445
877 (+1%)
3,459 (+1%)

batch_insert_into_append_only_tree_32_depth_hash_count
N/A
N/A
N/A
N/A
N/A
159
96.0
543
1,055
2,079
8,223

batch_insert_into_append_only_tree_32_depth_hash_ms
N/A
N/A
N/A
N/A
N/A
0.466 (+3%)
0.473
0.427 (+2%)
0.417
0.417 (+1%)
0.415 (+1%)

batch_insert_into_indexed_tree_20_depth_ms
N/A
N/A
N/A
N/A
N/A
101
54.8 (-1%)
336 (-2%)
663
1,314 (-2%)
5,244 (-1%)

batch_insert_into_indexed_tree_20_depth_hash_count
N/A
N/A
N/A
N/A
N/A
197
104
691
1,363
2,707
10,771

batch_insert_into_indexed_tree_20_depth_hash_ms
N/A
N/A
N/A
N/A
N/A
0.481 (+1%)
0.480 (-2%)
0.457 (-1%)
0.455
0.454 (-2%)
0.455 (-1%)

batch_insert_into_indexed_tree_40_depth_ms
N/A
N/A
N/A
N/A
61.9 (-1%)
N/A
N/A
N/A
N/A
N/A
N/A

batch_insert_into_indexed_tree_40_depth_hash_count
N/A
N/A
N/A
N/A
110
N/A
N/A
N/A
N/A
N/A
N/A

batch_insert_into_indexed_tree_40_depth_hash_ms
N/A
N/A
N/A
N/A
0.536
N/A
N/A
N/A
N/A
N/A
N/A

Miscellaneous
Transaction sizes based on how many contracts are deployed in the tx.

Metric
0 deployed contracts

tx_size_in_bytes
18,431

Transaction processing duration by data writes.

Metric
0 new note hashes
1 new note hashes

tx_pxe_processing_time_ms
2,482 (-2%)
1,297 (-1%)

Metric
0 public data writes
1 public data writes

tx_sequencer_processing_time_ms
0.0342 (-4%)
460


--inventory-path throwing an error on v0.29.x

Describe the bug/feature
An error is thrown when trying to compile templates that are not in the current directory
To Reproduce
Steps to reproduce the behavior:

Be in the parent directory
Attempt to compile the templates using kapitan compile --inventory-path ./deployments/inventory --search-paths ./deployments --output-path deployments
Get an Error

Inventory not found in search paths: ['/Users/jamesglennan/code/cert-manager/deployments', '/var/folders/0d/qdh7jkkj65153mzkmblmfnvm0000gn/T/tmp12g0g5wq.kapitan']

Expected behavior
Expect templates to compile, works on v0.28 (and below afaik)
** If it's a bug (please complete the following information):**

python --version: Python 3.8.5
pip3 --version:  pip 20.1.1
Are you using pyenv or virtualenv? No

Additional context
Add any other context about the problem here.
Works if you cd into the directory and just run kapitan compile
Workaround is to use v0.28 or cd into dir.

@jamesglennan thanks for reporting! Looks like we need a test for this :) Will be looking at it soon...

Just for completeness, could you also try your kapitan compile command with --inventory-path ./deployments/ ?
And do --verbose if possible in either run?

kapitan compile --inventory-path ./deployments/inventory --search-paths ./deployments --output-path deployments --verbose
2020-10-06 09:42:06,395 git.cmd      DEBUG    Popen(['git', 'version'], cwd=/Users/jamesglennan/code/navika/cert-manager, universal_newlines=False, shell=None, istream=None)
2020-10-06 09:42:06,407 git.cmd      DEBUG    Popen(['git', 'version'], cwd=/Users/jamesglennan/code/navika/cert-manager, universal_newlines=False, shell=None, istream=None)
2020-10-06 09:42:06,431 kapitan.cli  DEBUG    Running with args: Namespace(cache=False, cache_paths=[], embed_refs=False, fetch=False, force=False, func=<function trigger_compile at 0x10e4eb430>, ignore_version_check=False, indent=2, inventory_path='./deployments/inventory', jinja2_filters='lib/jinja2_filters.py', labels=[], output_path='deployments', parallelism=4, prune=False, quiet=False, refs_path='./refs', reveal=False, schemas_path='./schemas', search_paths=['./deployments'], subparser_name='compile', targets=[], validate=False, verbose=True)
2020-10-06 09:42:06,452 kapitan.resources DEBUG    Using reclass inventory config defaults
2020-10-06 09:42:06,472 kapitan.utils DEBUG    hashable_lru_cache: True not serialiseable, using generic lru_cache instead
2020-10-06 09:42:06,478 kapitan.targets DEBUG    validating target name matches the name of yml file production
2020-10-06 09:42:06,478 kapitan.targets DEBUG    load_target_inventory: found valid kapitan target production
2020-10-06 09:42:06,478 kapitan.utils DEBUG    hashable_lru_cache: True not serialiseable, using generic lru_cache instead
2020-10-06 09:42:06,482 kapitan.targets DEBUG    validating target name matches the name of yml file integration
2020-10-06 09:42:06,482 kapitan.targets DEBUG    load_target_inventory: found valid kapitan target integration
2020-10-06 09:42:06,482 kapitan.utils DEBUG    hashable_lru_cache: True not serialiseable, using generic lru_cache instead
2020-10-06 09:42:06,487 kapitan.targets DEBUG    validating target name matches the name of yml file dev
2020-10-06 09:42:06,487 kapitan.targets DEBUG    load_target_inventory: found valid kapitan target dev
2020-10-06 09:42:06,949 git.cmd      DEBUG    Popen(['git', 'version'], cwd=/Users/jamesglennan/code/navika/cert-manager, universal_newlines=False, shell=None, istream=None)
2020-10-06 09:42:06,951 git.cmd      DEBUG    Popen(['git', 'version'], cwd=/Users/jamesglennan/code/navika/cert-manager, universal_newlines=False, shell=None, istream=None)
2020-10-06 09:42:06,951 git.cmd      DEBUG    Popen(['git', 'version'], cwd=/Users/jamesglennan/code/navika/cert-manager, universal_newlines=False, shell=None, istream=None)
2020-10-06 09:42:06,953 git.cmd      DEBUG    Popen(['git', 'version'], cwd=/Users/jamesglennan/code/navika/cert-manager, universal_newlines=False, shell=None, istream=None)
2020-10-06 09:42:06,963 git.cmd      DEBUG    Popen(['git', 'version'], cwd=/Users/jamesglennan/code/navika/cert-manager, universal_newlines=False, shell=None, istream=None)
2020-10-06 09:42:06,965 git.cmd      DEBUG    Popen(['git', 'version'], cwd=/Users/jamesglennan/code/navika/cert-manager, universal_newlines=False, shell=None, istream=None)
2020-10-06 09:42:06,967 git.cmd      DEBUG    Popen(['git', 'version'], cwd=/Users/jamesglennan/code/navika/cert-manager, universal_newlines=False, shell=None, istream=None)
2020-10-06 09:42:06,968 git.cmd      DEBUG    Popen(['git', 'version'], cwd=/Users/jamesglennan/code/navika/cert-manager, universal_newlines=False, shell=None, istream=None)
2020-10-06 09:42:06,990 kapitan.inputs.base DEBUG    Compiling /Users/jamesglennan/code/navika/cert-manager/deployments/components/app
2020-10-06 09:42:06,991 kapitan.inputs.base DEBUG    Compiling /Users/jamesglennan/code/navika/cert-manager/deployments/components/app
2020-10-06 09:42:06,992 kapitan.inputs.base DEBUG    Compiling /Users/jamesglennan/code/navika/cert-manager/deployments/components/app
2020-10-06 09:42:07,004 kapitan.targets DEBUG    Compile pool terminated
2020-10-06 09:42:07,004 kapitan.targets ERROR

2020-10-06 09:42:07,004 kapitan.targets ERROR    Inventory not found in search paths: ['/Users/jamesglennan/code/navika/cert-manager/deployments', '/var/folders/0d/qdh7jkkj65153mzkmblmfnvm0000gn/T/tmpjgveda4z.kapitan']
Compile error: failed to compile target: production
multiprocessing.pool.RemoteTraceback:
"""
Traceback (most recent call last):
  File "/Users/jamesglennan/Library/Python/3.8/lib/python/site-packages/kapitan/inputs/base.py", line 70, in compile_input_path
    self.compile_file(
  File "/Users/jamesglennan/Library/Python/3.8/lib/python/site-packages/kapitan/inputs/jinja2.py", line 35, in compile_file
    context["inventory"] = inventory(self.search_paths, target_name, self.inventory_path)
  File "/Users/jamesglennan/Library/Python/3.8/lib/python/site-packages/kapitan/resources.py", line 265, in inventory
    raise InventoryError(f"Inventory not found in search paths: {search_paths}")
kapitan.errors.InventoryError: Inventory not found in search paths: ['/Users/jamesglennan/code/navika/cert-manager/deployments', '/var/folders/0d/qdh7jkkj65153mzkmblmfnvm0000gn/T/tmpjgveda4z.kapitan']

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File<EMAIL_ADDRESS>line 125, in worker
    result = (True, func(*args, **kwds))
  File "/Users/jamesglennan/Library/Python/3.8/lib/python/site-packages/kapitan/targets.py", line 453, in compile_target
    input_compiler.compile_obj(comp_obj, ext_vars, **kwargs)
  File "/Users/jamesglennan/Library/Python/3.8/lib/python/site-packages/kapitan/inputs/base.py", line 55, in compile_obj
    self.compile_input_path(input_path, comp_obj, ext_vars, **kwargs)
  File "/Users/jamesglennan/Library/Python/3.8/lib/python/site-packages/kapitan/inputs/base.py", line 80, in compile_input_path
    raise CompileError("{}\nCompile error: failed to compile target: {}".format(e, target_name))
kapitan.errors.CompileError: Inventory not found in search paths: ['/Users/jamesglennan/code/navika/cert-manager/deployments', '/var/folders/0d/qdh7jkkj65153mzkmblmfnvm0000gn/T/tmpjgveda4z.kapitan']
Compile error: failed to compile target: production
"""

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/Users/jamesglennan/Library/Python/3.8/lib/python/site-packages/kapitan/targets.py", line 126, in compile_targets
    [p.get() for p in pool.imap_unordered(worker, target_objs) if p]
  File "/Users/jamesglennan/Library/Python/3.8/lib/python/site-packages/kapitan/targets.py", line 126, in <listcomp>
    [p.get() for p in pool.imap_unordered(worker, target_objs) if p]
  File<EMAIL_ADDRESS>line 868, in next
    raise value
kapitan.errors.CompileError: Inventory not found in search paths: ['/Users/jamesglennan/code/navika/cert-manager/deployments', '/var/folders/0d/qdh7jkkj65153mzkmblmfnvm0000gn/T/tmpjgveda4z.kapitan']
Compile error: failed to compile target: production
2020-10-06 09:42:07,006 kapitan.targets DEBUG    Removed /var/folders/0d/qdh7jkkj65153mzkmblmfnvm0000gn/T/tmpjgveda4z.kapitan

kapitan compile --inventory-path ./deployments/ --search-paths ./deployments --output-path deployments
Inventory reclass error: inventory not found

No such directory: ./deployments/targets

Cheers for getting on this team :)

With --inventory-path specified
I think the issue is that inventory_reclass() gets called first with using kapitan compile --inventory-path ./deployments/inventory --search-paths ./deployments --output-path deployments
https://github.com/deepmind/kapitan/blob/1b8b6b203e20cdfd58cc1a4a29fbd5f705f83775/kapitan/resources.py#L294
with the inventory_path=./deployments/inventory
Later, the inventory() function gets called from jinja2.py. https://github.com/deepmind/kapitan/blob/1b8b6b203e20cdfd58cc1a4a29fbd5f705f83775/kapitan/resources.py#L248
Which tries to set the full_inv_path using:
https://github.com/deepmind/kapitan/blob/1b8b6b203e20cdfd58cc1a4a29fbd5f705f83775/kapitan/resources.py#L259
This sets the full_inv_path as /Users/xyz/deployments/./deployments/inventory, which raises the error.
Without --inventory-path specified
inventory_reclass() raises Inventory reclass error: inventory not found as default inventory path is ./inventory
Solution
May be we can define a function which will check if --inventory-path /path  is specified and then set  full_inv_path = /path
Else, full_inv_path = os.path.join(search_path, "./inventory") and save the full_inv_path to cache?

May be we can define a function which will check if --inventory-path /path  is specified and then set full_inv_path = /path
Else, full_inv_path = os.path.join(search_path, "./inventory") and save the full_inv_path to cache?

That could work. Alternatively a simple solution is also checking in that inventory() function whether the inventory_path =="inventory/" since that's the default. If not, full_inv_path = /path else full_inv_path = os.path.join(search_path, "./inventory"). It's selfcontained and you don't have to worry about cache state (?).

One potential issue could be in  case If --inventory-path is not specified. Then, I think the inventory path i.e full_inv_path = os.path.join(search_path, "./inventory") should be set at an earlier stage since inventory_reclass() is called before inventory(). Else inventory_reclass() will try to search for inventory in ./inventory instead of search_path/inventory (?) In fact, the full_inv_path is only being set in the inventory() function which, afaik, only gets invoked from kapitan/inputs/jinja2.py
https://github.com/deepmind/kapitan/blob/1b8b6b203e20cdfd58cc1a4a29fbd5f705f83775/kapitan/inputs/jinja2.py#L35
So it might be useful to set the full_inv_path in a more global scale?

I had a quick browse and all paths that lead to inventory_reclass() do get the correct path from args directly (?) so this might not be a problem.
I have a suspicion that the inventory( ) function's handling of the inventory path is an exception for jinja2 specifically (?).
@ramaro might have a better idea.

Hey @jamesglennan are you compiling the jsonnet version of cert-manager?

I think the issue is that "inventory/" is hardcoded in the kapitan.libjsonnet native function call at https://github.com/deepmind/kapitan/blob/master/kapitan/lib/kapitan.libjsonnet#L9
So setting the --inventory-path flag won't update the optional parameter in the inventory() native call. This wasn't very clever of us (me!) to write it this way. So I'm updating the default value to null which will default to the flag value.
I fixed it in my personal fork, do you want to give it a try? https://github.com/deepmind/kapitan/compare/master...ramaro:inventory_path_fix

No, we're using Jinja2, cert-manager is an example, but anything we try to compile seems to fail when specifying inventory

@ramaro Quick test and your fix seems to do the trick, thanks for getting on this so quick

@jamesglennan thanks for testing! PR on the way.

@ramaro Out of curiosity, what's the release schedule on Kapitan? Once a month? or thereabouts?

@ramaro Out of curiosity, what's the release schedule on Kapitan? Twice a month? or thereabouts?

No official release schedule, mostly going based on needs.
I can start 0.29.3 for you now. :)

kapitan compile --inventory-path deployments/inventory --search-paths deployments --output-path deployments Unknown (Non-Kapitan) Error occurred
multiprocessing.pool.RemoteTraceback:
"""
Traceback (most recent call last):
  File<EMAIL_ADDRESS>line 125, in worker
    result = (True, func(*args, **kwds))
  File "/Users/jamesglennan/Library/Python/3.8/lib/python/site-packages/kapitan/targets.py", line 453, in compile_target
    input_compiler.compile_obj(comp_obj, ext_vars, **kwargs)
  File "/Users/jamesglennan/Library/Python/3.8/lib/python/site-packages/kapitan/inputs/base.py", line 54, in compile_obj
    self.compile_input_path(input_path, comp_obj, ext_vars, **kwargs)
  File "/Users/jamesglennan/Library/Python/3.8/lib/python/site-packages/kapitan/inputs/base.py", line 69, in compile_input_path
    self.compile_file(
  File "/Users/jamesglennan/Library/Python/3.8/lib/python/site-packages/kapitan/inputs/jinja2.py", line 35, in compile_file
    context["inventory"] = inventory(self.search_paths, target_name)
  File "/Users/jamesglennan/Library/Python/3.8/lib/python/site-packages/kapitan/resources.py", line 260, in inventory
    inventory_path = inventory_path_arg.inventory_path
AttributeError: 'NoneType' object has no attribute 'inventory_path'
"""

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/Users/jamesglennan/Library/Python/3.8/lib/python/site-packages/kapitan/targets.py", line 126, in compile_targets
    [p.get() for p in pool.imap_unordered(worker, target_objs) if p]
  File "/Users/jamesglennan/Library/Python/3.8/lib/python/site-packages/kapitan/targets.py", line 126, in <listcomp>
    [p.get() for p in pool.imap_unordered(worker, target_objs) if p]
  File<EMAIL_ADDRESS>line 868, in next
    raise value
AttributeError: 'NoneType' object has no attribute 'inventory_path'

Should we re-open this? When i tested, i ran it with python3 . ...args using full path
I just tested the installed version with full path and same error?

Interesting... Yes let's reopen this. Thanks for your findings!

Hey @jamesglennan if you can give this fix https://github.com/deepmind/kapitan/pull/661 a shot, please let me know how it works for you 👍  It's now merged in master

@ramaro Running it from the cli with python command works perfectly (same as last time) but im getting an error when i try and run the container version, or build the binary
Successfully built 174271bace8a
Successfully tagged kapitan:latest
----- Testing run of docker image -----
docker run -ti --rm kapitan --help
Traceback (most recent call last):
  File "/opt/venv/bin/kapitan", line 5, in <module>
    from kapitan.cli import main
  File "/opt/venv/lib/python3.7/site-packages/kapitan/cli.py", line 23, in <module>
    from kapitan.refs.cmd_parser import handle_refs_command
  File "/opt/venv/lib/python3.7/site-packages/kapitan/refs/cmd_parser.py", line 17, in <module>
    from kapitan.resources import inventory_reclass
  File "/opt/venv/lib/python3.7/site-packages/kapitan/resources.py", line 28, in <module>
    import reclass
ModuleNotFoundError: No module named 'reclass'
make: *** [test_docker] Error 1

I'm guessing this is more related to release/install problems?

Hey thanks for checking. That looks to be a release problem indeed. cc @uberspot

Hmm, yeah that seems like it didn't git pull the reclass submodule when building on docker.
I'll start another release with this fix and see if this happens on Travis as well.


Toggling autocomplete view doesn't focus the filter editor

The first time autocomplete is used, it focuses the filter editor properly. After that, the filter editor isn't focused, so typing characters to refine the autocomplete search doesn't work.
This happens in safe mode, and regardless of the shadow DOM setting.
/cc @nathansobo

Looking into this.


Lazy loading is added

Related Issue
Closes #435
In this code, I  added the class "lazy" to the elements  to lazy load and specified the URL of the lazy content using the data-src attribute. The script will make an AJAX request to fetch the content from the provided URL and set it as the innerHTML of the lazy element.
Additionally, the code adds a scroll event listener to trigger the lazy loading when the elements come into the viewport. The lazy elements that are already visible on page load will be loaded immediately, while the remaining elements will be loaded as the user scrolls.

Checklist

[x] My code adheres to the established style guidelines of the project.
[x] I have included comments in areas that may be difficult to understand.
[x] My changes have not introduced any new warnings.
[x] I have conducted a self-review of my code.

@Dharmesh177 please review

Add video of demonstration and screenshots for assess

Add video of demonstration and screenshots for assess

You will see difference will website load it is more efficient after lazy loading is enabled

@Dharmesh177 please review my pr

It taking too much load I guess now no need of this

or need improvement

Is there any improvement needed

Kindly resolve conflicts and work on latest branch

@cleveranu I have resolve the conflict please review now


Include styled components as dependency of the CDK

Creating a new react project with vite and installing halstack CSK is not enough to start importing halstack components. The app compilation would fail until that syled-components package is installed.
Example:

Create a new React App using $ npm create vite@latest
Install the @dxc-technology\halstack-react  + project dependencies
import a Halsack component in the App component
Run $npm run dev
See the error.

I would expect styled component to be a Halstack project dependency. Moreover, Using the latest version of styled components, I experienced weird behaviours with containers. Halstack should be using a fixed version.

This "problem" leads to a larger and much more complex discussion about our dependencies as a library of React components. You can join it here: https://github.com/dxc-technology/halstack-react/discussions/1664.
For the moment and to solve the issue, you can update your local version of npm to the 7th and newer to automatically install peer dependencies of libraries in projects (see their release notes):
npm i -g<EMAIL_ADDRESS>


Visualize robot in rviz

@mhubii I am wondering if you could lend a hand. I have been unable to work out how to visualize the robot in Rviz, do you have any idea how to add the robot model to the visualization? Please see the launch script here. You see that I have the robot description, I am wondering how this is then passed to rviz? Perhaps something needs to generate the joint states like gazebo? In which case, do you know the easiest way to achieve this?
Any help greatly appreciated.

I usually add the robot using the rviz gui and then save the rviz config to file, and then from the launch file you should be able to load the rviz config that you saved using the gui which will have the robot.
Programatically I don't know what is the way.

Thanks @joaomoura24. However, the problem is I don't know how to do this in rviz2/ROS2 :wink:

sure, will have a look

Thanks @mhubii
The main issue was that in ROS2, the robot_description (that needs to be set in Rviz2) is a topic, in ROS1 this was a parameter.


MLP dropout > 0.5 causes error

In the FNO, when mlp_dropout > 0, we see the following error:
NotImplementedError: Module [ModuleList] is missing the required "forward" function.

It should work now: ) for all values.


nytimes -> NYTimes

Our organization name is mixed-case. I'd prefer that it wasn't, but it is. Cloning (and go-getting) it in lowercase does work, but could result in multiple copies of the library existing in the GOPATH. This is especially hazardous on OS X, where case is preserved but ignored.

thanks, Adam!


circle key update

@conda-forge-admin, please update circle
https://conda-forge.org/docs/maintainer/infrastructure.html#conda-forge-admin-please-update-circle
@blowekamp

Hi! This is the friendly automated conda-forge-webservice.
I just wanted to let you know that I updated the circle-ci deploy key and followed the project.

@blowekamp can you retrigger the build?

@hmaarrfk  Was there more to trigger than what you did in the PR?

Yeah can you retrigger using the link in the readme. The build on the master branch will cause the upload.

Great! The library has been rebuilt!


Allow real-time collapsing of unifurcations to save space

This should actually happen in Empirical, but I'm putting this issue here so we don't lose it.
@mmore500 had a good point today about how we can collapse the "stem" of the phylogeny after coalescence events to save space. However, it won't help is in the (relatively common) case where we have a couple very deep branches maintained forever by ecological dynamics. However, we could handle both cases by allowing all unifurcations to be collapsed in real time. This could potentially save a decent amount of space.

Post-hoc collapsing of unifurcations would also be very valuable to ensure consistent phylometric results. Alternately, it looks like branch_only options are defaulted to false and it might make more sense to default them to true?


perf: bring back the symlink optimization

#298  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Brooooooklyn and the rest of your teammates on  Graphite


feat(sbb-selection-panel): increase border width for active state

Closes #2461

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (main@92c232b). Click here to learn what that means.

:exclamation: Current head e8e7252 differs from pull request most recent head 81e4e9c. Consider uploading reports for the commit 81e4e9c to get more accurate results

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2463   +/-   ##
=======================================
  Coverage        ?   93.62%
=======================================
  Files           ?      276
  Lines           ?    24085
  Branches        ?     2032
=======================================
  Hits            ?    22549
  Misses          ?     1503
  Partials        ?       33

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


All nodes broken if inputs converted to widgets

If I convert an input to a widget, save the workflow, then reopen, the input is returned, as well as the widget. That is, I get both. This happens on all such modified nodes. Text inputs, Ksamplers, and here in this screen shot,  a prompt.
I have 'fix node (recreate) losing all my structure, values, colours, inputs and widgets and then remade them. But, saving the workflow and reopening it, and everything is doubled once more. To be clear no harm is done when running the workflow, it just looks bad, but does not break anything, it doesn't use the 'ghost' values. Further, it was happening in all workflows that I opened, whether I was using one of your custom nodes within that workflow, or not, so long as I had converted a widget to an input. Deleting your nodes and my problem has gone away.
More here:
https://www.reddit.com/r/comfyui/comments/192dkbt/help_needed_i_get_reapeted_values_on_some_nodes/

Oh, thanks! I'll check now! may with the update of confyUI broken some stuff, let me check right now!

Can you test please? update both extensions, crystools and crystools-save, thanks!


PR: Load history from IPython directly

Pull Request Checklist

[x] Read and followed this repo's Contributing Guidelines
[x] Based your PR on the latest version of the correct branch (master or 3.x)
[x] Followed PEP8 for code style
[x] Ensured your pull request hasn't eliminated unrelated blank lines/spaces,
modified the spyder/defaults directory, or added new icons/assets
[x] Wrote at least one-line docstrings for any new functions
[x] Added at least one unit test covering the changes, if at all possible
[x] Described your changes and the motivation for them below
[x] Noted what issue(s) this pull request resolves, creating one if needed
[x] Included a screenshot, if this PR makes any visible changes to the UI

Description of Changes
Spyder now loads the history from iPython instead of duplicating the history in a local file.
That is less confusing for the user as the history in iPython and the history in historylog are now the same.

Issue(s) Resolved
Fixes #7142

Hello @impact27! Thanks for submitting the PR.

In the file spyder/plugins/history.py, following are the PEP8 issues :

Line 249:1: W293 blank line contains whitespace
Line 255:41: E261 at least two spaces before inline comment

In the file spyder/plugins/ipythonconsole.py, following are the PEP8 issues :

Line 1314:39: W291 trailing whitespace
Line 1324:1: W293 blank line contains whitespace

In the file spyder/widgets/ipythonconsole/client.py, following are the PEP8 issues :

Line 96:5: E303 too many blank lines (2)

In the file spyder/widgets/ipythonconsole/shell.py, following are the PEP8 issues :

Line 495:1: W293 blank line contains whitespace
Line 499:43: W291 trailing whitespace

@impact27, looks good at first glance, but we really need a test for this because it's a major internal change. You need to add it to test_mainwindow.py (because it involves two plugins), and it could be very simple: evaluate a command in the console and register that the last entry in the History Log corresponds to that command.
Also, please create a new issue for this because #7080 is really solved by your other PR.

I did some tests on this and it works.  I think this is the way forward.  Having the history stored per entered commands in this way could lead to great new functionality in the history explorer.
The only regression is the old history had date headers, but they weren't very useful.

@impact27, please also migrate this to the master branch.

I opened #7142

The dates are saved in the ipython database so It could be added back.

Thanks @impact27 . FYI you should rebase your original work on master`, not mergeit, so as to not dirty the history. You can get the original back withreflogin case you don't have it already in a branch, or an interactiverebase -i``.
Also, apparently AppVeyor on Py3 isn't able to find pytest-mock to install it and is thus failing; not sure why. @ccordoba12 ?

@pep8speaks suggest diff for testing purposes

I've been testing this and it's working great.
Summary of text below: I think it would be best to have one history tab per console.
On a more broader view it seems like there is a lot of code here that seems to be used to get all the ipython consoles to talk to one history tab so it mimics the way the previous code worked.
From a use case prospective I think this isn't a good idea to have the history mixed and it would be better and simpler to have IPython take care of the history entirely. We can just take what the console gives not worry about it...it works great. This would require us to have one history tab per console, but luckily the history widget already has tabs implemented.
Currently, If you change between tabs and run commands in each the history gives you a mess of code that is most likely unassociated and you can tell what commands were executed in each console. The up arrow history at the ipython prompt keeps the history separate and when both sessions are closed the two histories are appended into the main history one console after the other so the code is still in blocks that are still associated.
The hardest part would be to synchronize the tab switching between the consoles and the history.
I would open a new issue but this idea would greatly impact this work.

@impact27, as @CAM-Gerlach suggested, please rebase this PR in top of latest master. Your merge was really unnecessary.

I've been testing this and it's working great.

Great!

Currently, If you change between tabs and run commands in each the history gives you a mess of code that is most likely unassociated and you can tell what commands were executed in each console.

What if we use a QStackedWidget instead to only display the history of the current console, but change to another history when users select a different console? That's what we do in the Variable Explorer and I think it works quite well.

I would open a new issue but this idea would greatly impact this work.

Please do. We can work on it after this PR is merged.

What if we use a QStackedWidget instead to only display the history of the current console, but change to another history when users select a different console? That's what we do in the Variable Explorer and I think it works quite well.

The only disadvantage there, that isn't the case for the variable explorer, is if a user wants to view or copy one console's history while working in another. It could be solved by a "lock" toggle locking the history shown to that of the currently selected console (like the one for Help). However, we'd then need to implement tabs in the history log like we have in the console to navigate between different console's logs independently, so not sure if the different use cases that require it would be worth the effort at this point.

@CAM-Gerlach, we can still use a QStackedWidget widget and an option that allows users to select the console's history they want to see at the moment (but that would be change to the current console as soon as they change consoles).
I really don't want to use tabs for this because I really think it makes no sense. In any case, please stop discussing that in this PR (because it's unrelated to @impact27's work) and open a new issue about it.

Sorry :open_mouth:
@bcolsen was the one with the detailed proposal above and said he could create the new issue, so I didn't (and don't) want to just steal it from him.

Sorry

No worries, I just didn't us to keep polluting this PR ;-)

I rebased the pull request

@impact27, this looks good, but you need to preserve saving history in the internal console.

I am not sure where set_historylog is actually called? The only reference I found in the code was already commented out. Are you sure the internal history is not saved? It is working as is in my code.

@impact27 Looks like this got hit big-time by the split-plugins merge. Are you interested in finishing it?
With regard to your question, I'm not really sure why there need be a tab in the History log for Internal Console history, considering it is only used for testing and introspecting Spyder itself rather than production work, and can in any case still be accessed inside the internal console's one pane anyway, but even so it looks like it still works just fine.

Unfortunately I don't really have time these days. Does somebody else want to finish that?

I'll finish it. I'll implement the QStackedWidget solution I proposed some time ago.

@ccordoba12 @impact27 Hey, is this ever going to be finished? A lot of conflicting files have built up over the time this has been sitting around...

@ccordoba12 thoughts on this? Do you want some of the other devs to tackle this at some point?

We'll take another look after we release beta2.

@impact27, could you update and finish this PR? For now let's go with my proposed approach, i.e. showing the history of the current console when switching from one to another.

I rebase it on the master and it still works, but I am not sure how to do the QStackedWidget, so I would be glad if someone else could finish it.

I rebase it on the master and it still works

Thanks a lot for that!

but I am not sure how to do the QStackedWidget

Ok, no problem. We'll help you with that part then.

Closing because too many conflicts accumulated and this would need a rewrite


Add cut rope game

Fix #417 , Add cut rope game.

@iamrahulmahato , This branch has no conflicts with the base branch.


Typealiases and Enum cases

I added referencing type aliases of other typealiases and updating inherited types on top of your changes. Fixes #38
Also squeezed in enum cases, fixes #59

          1 Warning

:warning:
Big PR

  Generated by :no_entry_sign: danger

Good to merge, I think 👍

Thanks :)


Add Framer X wrapper components

[x] I have followed (at least) the PR section of the contributing guide.

Known issues:

Tabs only display correctly when the preview is zoomed to 100% (Framer issue)
ListItem icon / action alignment
Nested component function props aren't currently exposed (for code overrides)
Chip Avatar size wrong after upgrade to 4.5.0.
Some TS wobblies (non-existant props in shared controls)

Todo:

Marketing image, icon & docs
More components

🥁

https://packages.framer.com/package/material-ui/material-ui

Well done! For the MUI icon, did you use https://github.com/mui-org/material-ui/blob/master/docs/static/brand.png?

No, https://github.com/mui-org/material-ui/blob/master/docs/static/brand.png (since the example icon had a transparent background), with some extra padding. It could perhaps have used a bit more - just didn't want to make the logo too small. Next release...