Allow setting lints.workspace as false

Problem
I expect to be able to set lints.workspace to false to explicitly opt out of the workspace lints.
Currently this is not allowed.
It would also be helpful for a potential lint like https://github.com/rust-lang/rust-clippy/issues/11933.
Proposed Solution
Treat lints.workspace = false the same as not setting it at all.
Notes
No response

@rustbot label +A-lints-table

Posted on rust-lang/rust-clippy#11933 with a framing that might not need this.
If we went down this route, we'd need to decide if we should mirror this in all of the rest of workspace inheritance.

I have actually tried setting workspace to false, before knowing about the lint idea.
It just feels natural to disable the workspace lints by setting it to false.
I thought it would be as simple as just allowing it and basically ignoring it, but if it also impacts other workspace stuff, then it would need some more consideration.

The following statements make me suspect its best if we don't support workspace = false for now as it seems like people could do it and get the wrong impression as to what it does
From https://github.com/rust-lang/rust-clippy/issues/11933#issuecomment-1877762065

Oh my gosh, I thought/hoped that this is implicitly on without having to opt in for every workspace member crate. 😱

From https://github.com/rust-lang/cargo/issues/13821#issuecomment-2082997392

I have actually tried setting workspace to false, before knowing about the lint idea.
It just feels natural to disable the workspace lints by setting it to false.

I thought it would be as simple as just allowing it and basically ignoring it, but if it also impacts other workspace stuff, then it would need some more consideration.

We could allow it and it would ignore it.  However, all of workspace inheritance works the same way and has the same behavior of disallowing workspace = false so we'd at least need to evaluate how important consistency is and what it would be like to support workspace = false in the other places.


Add screenshot tests for each page in applicant's user flow

Description
Also removes the existing screenshot from landing_page.test.ts since this is covered by the screenshots added here.
Release notes:
N/A
Checklist

[x] Added the correct label: < feature | bug | dependencies | infrastructure | ignore-for-release >
[ ] Created tests which fail without the change (if possible)
[ ] Extended the README / documentation, if necessary

Issue(s)
#2618

Codecov Report

Merging #3282 (2acfabd) into main (324e6f8) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #3282   +/-   ##
=========================================
  Coverage     79.59%   79.59%
  Complexity     2315     2315
=========================================
  Files           286      286
  Lines          9114     9114
  Branches        607      607
=========================================
  Hits           7254     7254
  Misses         1626     1626
  Partials        234      234

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


File provider doesn't detect changes in subfolders

Welcome!

[X] Yes, I've searched similar issues on GitHub and didn't find any.
[X] Yes, I've searched similar issues on the Traefik community forum and didn't find any.

What did you do?
Using standalone Traefik binary, create a config file, define a file provider on a folder with multiple config files in the folder and multiple subfolders with more config files.
What did you see instead?
Any file located in a subfolder of the folder defined in the file provider don't get detected if modified, files in the defined folder get detected and the config changes accordingly. Traefik should detect changes in all the subfolders on the watching folder, or allow a way to define multiple watched folders.
What version of Traefik are you using?
Version:      2.6.0-rc1
Codename:     rocamadour
Go version:   go1.17.5
Built:        2021-12-20T16:10:10Z
OS/Arch:      linux/amd64
What is your environment & configuration?
[providers]
[providers.file]
directory = "redacted"
watch = true
If applicable, please paste the log output in DEBUG level
No response

Duplicate of #3986


Incorrect version in greptime_app_version

What type of bug is this?
Other
What subsystems are affected?
Other
Minimal reproduce step
Access the /metrics endpoint when the DB is ready:
bash-5.1# curl -q  http://<IP_ADDRESS>:4000/metrics | grep greptime_app
greptime_app_version app version
# TYPE greptime_app_version gauge
greptime_app_version{short_version="0.9.1",version="-fe1cfbf2"} 1

The version should be fe1cfbf2, not -fe1cfbf2.
What did you expect to see?
We should get the correct version without the prefix -.
What did you see instead?
Get the version with prefix -.
What operating system did you use?
Linux
What version of GreptimeDB did you use?
v0.9.1
Relevant log output and stack trace
No response

Maybe I can give it a try.

@leaf-potato it's yours. Have fun. Feel free to ask if anything needs to be clarified.

The version uses the branch-commit format. When git checkout to a commit, there is no branch.
https://github.com/GreptimeTeam/greptimedb/blob/93be81c0410a32f8955769599090de0f4f11e73f/src/common/version/src/lib.rs#L127-L129
Therefore, fix it by using commit id directly when the branch is empty.

The version uses the branch-commit format. When git checkout to a commit, there is no branch.
https://github.com/GreptimeTeam/greptimedb/blob/93be81c0410a32f8955769599090de0f4f11e73f/src/common/version/src/lib.rs#L127-L129
Therefore, fix it by using commit id directly when the branch is empty.

I'm confused with short_version and version. In fact, version is some kind of "short" version.
Can we just return branch and commit_short? For example:
pub const fn branch_and_short_commit() -> (&'static str, &'static str) {
    (BUILD_INFO.branch, BUILD_INFO.commit_short)
}

IMO, version should be semantic, for example, v0.9.1. We can make greptime_app_version looks like:
greptime_app_version{version="0.9.1",short_commit="fe1cfbf2",branch="main"}

I'm confused with short_version(CARGO_PKG_VERSION) and version(${commit_short}-${branch}). In fact, version is some kind of "short" version.

Mabey it's a bug. When calling the log_version function, pass the return value of the short_version() function to the app_version parameter:
https://github.com/GreptimeTeam/greptimedb/blob/2c3fccb516addcfb082a7c12302b3fffafcbbab8/src/cmd/src/flownode.rs#L218-L220
However, inside the function log_version, the value of app_version is assigned to version instead of short_version:
https://github.com/GreptimeTeam/greptimedb/blob/93be81c0410a32f8955769599090de0f4f11e73f/src/cmd/src/lib.rs#L31-L34
https://github.com/GreptimeTeam/greptimedb/blob/93be81c0410a32f8955769599090de0f4f11e73f/src/cmd/src/lib.rs#L79-L86

@leaf-potato It's unusual that "branch" is empty. I was digging into the "shadow-rs"(that find the git info) one time, and suspect the incorrectness was origin from its usage of "git2". Maybe you can disable the "git2" feature and give it a try?

I'm confused with short_version(CARGO_PKG_VERSION) and version(${commit_short}-${branch}). In fact, version is some kind of "short" version.

Mabey it's a bug. When calling the log_version function, pass the return value of the short_version() function to the app_version parameter:
https://github.com/GreptimeTeam/greptimedb/blob/2c3fccb516addcfb082a7c12302b3fffafcbbab8/src/cmd/src/flownode.rs#L218-L220
However, inside the function log_version, the value of app_version is assigned to version instead of short_version:
https://github.com/GreptimeTeam/greptimedb/blob/93be81c0410a32f8955769599090de0f4f11e73f/src/cmd/src/lib.rs#L31-L34
https://github.com/GreptimeTeam/greptimedb/blob/93be81c0410a32f8955769599090de0f4f11e73f/src/cmd/src/lib.rs#L79-L86
The simple solution is to swap the current assignment operation.

Two version labels still confuse the user. The user has to understand(or we assume the user knows) the format of app_version, which is constructed with branch and commit. It will be clearer if we use the raw git info as the metric label, for example, branch and commit.

Two version labels still confuse the user. The user has to understand(or we assume the user knows) the format of app_version, which is constructed with branch and commit. It will be clearer if we use the raw git info as the metric label, for example, branch and commit.

+1

and suspect the incorrectness was origin from its usage of "git2"

@MichaelScofield  Maybe not. Disabling git2 in shadow-rs also has the same problem:
#before:
shadow-rs = "0.31"

#after:
shadow-rs = { version = "0.31", default-features = false}

It's unusual that "branch" is empty.

You can reproduce the problem by following the steps below:
git checkout HEAD^
git branch --show-current

It will be clearer if we use the raw git info as the metric label, for example, branch and commit

Got it!

@leaf-potato If you do git checkout like that, it's in the "detached" mode, there's no branch. A walkaround might be git branch --remote --contains | sed "s|[[:space:]]*origin/||"

git branch --remote --contains | sed "s|[[:space:]]*origin/||"

You also need to filter out HEAD: git branch --remote --contains | sed "s|[[:space:]]*origin/||"|grep -v "HEAD". Should this be supported by shadow-rs?

@leaf-potato Wait...On second thought, do we really need the "branch" info? "commit id" is sufficient to uniquely locate the codes revision. The way to find branch in detached mode is kind of magic, you can try to fire an issue in shardow-rs.

When building GitLab or GitHub, it will check out from a certain branch, causing the command to retrieve the current branch with empty content.
The delivered product (binary) version should be concrete, and in fact, it is more recommended to use the git tag mechanism for tagging, because branches are often deleted, and git tags are usually treated as archives.
When building shadow-rs, it is recommended to use git tag recording in this way. For details, please refer to.
If you want to choose between branch or tag, you need to make a judgment. The pseudocode is roughly as follows:
{
 "version":shadow::PKG_VERSION,
+ "branch/tag":if ! shadow::BRANCH.is_empty(){ shadow::BRANCH} else{shadow::LAST_TAG},
"commit_hash":shadow::SHORT_COMMIT,
"build_time":shadow::BUILD_TIME,
}

Hi, if this is not completed yet, can I give it a try?

@raju130404 It's already resolved in https://github.com/GreptimeTeam/greptimedb/pull/4572.


Import private httpx modules

The public api of httpx has changed in version 0.12.1.
Fixes: https://github.com/lepture/authlib/issues/208
What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update
[ ] Refactor
[ ] Other, please describe:

Does this PR introduce a breaking change?

[x] Yes
[ ] No

If yes, please describe the impact and migration path for existing applications:

Not compatible with httpx<0.12.0: the httpx library has to be updated to a version >=0.12.0 in existing applications. EDIT: Fixed with https://github.com/lepture/authlib/pull/209/commits/116988b61ab8f0910575088c31937c28d84fcc9d as suggested by @phy25 in https://github.com/lepture/authlib/pull/209#issuecomment-601755350
Depends on some private modules from httpx: as explained in https://github.com/lepture/authlib/issues/208. I hope somebody will come up with a better solution than mine!

[x] You consent that the copyright of your pull request source code belongs to Authlib's author.

I think a try...catch ImportError... with attempts of different namespaces would be better?

@lepture could you please get this fix merged? This is a blocking bug for me.

@pdiwan you can use the old version of httpx. It shouldn't be a blocking issue.

I could but just trying to avoid hardcoding versions now and later change when the fix is merged.

Please pin httpx version.


docs enums

closes #1737

Coverage remained the same at 82.276% when pulling c75f7ed00bff73f229f1834af1956e7b5fa7415e on mparke:add-docs-enumerations into ff0c4633c62e3cfadbecba2e3ae3cf5d9ea20641 on linode:master.


What to do with quoted prepared values?

Pattern::prepare(['\\', [$value]]);
Pattern::inject('\\@', [$value]);
Pattern::inject('[@]', [$value]);
Pattern::inject('\\Q[@]\\E', [$value]);

Oh, so there's a whoooole lot of ways prepared patterns can be broken with in-pattern structures.

Escape: \@ - whatever was injected will be malformed
POSIX character group: [@] whatever is quoted will be treated as a single character and/or break the pattern
In-pattern quote: \Q@\E
Comment in Extended mode: /#@/x
Each of those can also be escaped, so it's needed to tokenize the pattern before the bulding process

Aditionally, point 4 is only true in Extended mode, which can be set either by pattern flag, or by in-pattern flag ((?x)), which would require parsing parameters, tokenizing it with polymorphism nad nested structures, since it's possible to also disable the flag (?-x), and they can be turned on and off again. Parsing [, (, #, \Q and \ is like asking for bugs.

Ok, we're gonna handle \@, [@], \Q@\E + variants with escape, and we're gonna ignore comment #@\n, because:

It's toooooooo hard to dedcude whether extended mode is turned on or off
Even if we did, that would require conditional statements in parsing regex
Would pose performance overhead
If we introduce bugs we risk @ not being build where it should
But! :D At least, we don't risk anything if we build @  where we shouldn't (I mean, if we build @ inside a comment, nothing bad is going to happen, it's a comment). To do that we only need to encode every newline character into escaped newline "\n" into '\n'. That way, it won't mess up the comment syntax if it's extended mode.

Okay, only \@ and \Q@\E left to handle

Turns out we can't simply always put @ figure in the pattern regardless whether it's inside # and \n or not, because of this case:
#[@]\n

If It's a comment, alternation of @ should throw. If it's a comment, nothing should happen, since it's a comment.
That leaves us only these options:

Remove alternation from T-Regx (bad idea)
Make alternation work inside [ and ]
Parse the whole regular expression, to determine whether x flag is enabled or not.


Add grid line configuration for x-axis

Add the possibility to configurate grid lines for x-axis

See also:
https://www.chartjs.org/docs/4.4.2/axes/styling.html#grid-line-configuration

Released with version 4.18.08


Crash on breaking bee hive

I'm not sure what mod from 3 mentioned in crash log issue is this, but here is the crash log:
https://mclo.gs/gOrkzOW

It isn't fault of ClearDespawn.


add contents to doc/wise_agents_architecture.md i fixes #148

I've added some very minor comments so adding my approval in case we want to get this merged and address the small comments after.

I've fixed what suggested and add an answer about Assitant Agent. Please have a look and if it's ok we can merge it

@maeste Thanks, I've published the docs on the website.


chore(main): release 1.27.2

:robot: I have created a release beep boop
1.27.2 (2024-12-14)
Bug Fixes

cdn fonts (c8fb7b1)
cfg for rolling effect (4ff2987)
style (b788a8e)
tippy -> tooltip (9d5f882)
tooltip (f900fe3)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v1.27.2
:sunflower:


[Request] Seed planting should work thru snow/plant blocks.

Forge: <IP_ADDRESS>60
Dynamic Trees: 1.12.2-0.8.1i
Currently, right-clicking seeds and acorns on the ground does not work if there is any vanilla plant cover or snow layers in the way. It would be nice if it detected these and checked the block beneath for viability.
I'm also assuming that naturally-planted seeds behave the same way, which prevents natural forest spread in snow biomes- as I haven't seen any baby trees around.
Edit: Upon actual testing I can see that they actually do plant thru grass when done naturally, so nevermind about that portion!

Good catch.  I never noticed that.  I'll see what I can come up with.

In Minecraft some blocks can be placed into grass and replace it IIRC.

I use a mod to apply a similar concept to combat. It only works if there is an enemy on the other side of the grass but maybe it's a useful reference: https://github.com/Exidex/SwingThroughGrass


Add process_isolation option

What does this PR do?
Work around several potential memory issues in the closed source client library
Context:

pymqi report
IBM report

Superseded by https://github.com/DataDog/integrations-core/pull/12986


Addition of Integration_type key in add a new Bot

Fixes: https://github.com/zulip/zulip/issues/30139
Followings things are covered in this PR:

Save the integration field to BotConfigData
Make integration field update-able in Backend
Prepopulate the Integration name in Generate URL for an integration

Added one key integration type in UI and saving it to BotConfigData. And Using this in Services section of the schema
Incoming Schema services:

{[service_name: z.string(),
    integration_name: z.string()]}

Things covered Commit

3e28dc21f7428f52dd4e955666ddf5aad2e5649c: add the Integration Type in Add new Bot

settings_bot.js : get_options_for_integration_input_dropdown_widget method fetch all the integration_type available along with this sending to the backend in formdata.
add_new_bot_form.hbs:  add integration_type in UI.
users.py: Saving the integration_type in the BotConfigData.
Integration_type is also stored in the Services model because in frontend we fetch integration_type from the Services model instead of the BotConfigData model in UI (reference get_services in bot_data.ts).

bcc333e0e9735b5521ce5dec253731601104efe5:

Prepopulated the Integration_type data

integration_url_model.ts: made method get_service_for_bot to fetch the service for the particular bot_id. and uses its value to prepopulate the data in get_default_integration_option  method.
settings_bot.js and user_profile.jsfind the bot_id and pass it to show_generate_integration_url_modal.

Refactored the Services Schema -

bot_types.ts: added general schema for services and add that in services_schema. also created single_service_schema to resolve the typescript error coming in the integration_url_modal.ts file.

Fixed the Unit test Related to Bot - Key changes include in create_new_bot added integration_name as integration_name is mandatory field.

Screenshots and screen captures:

Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[x] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[x] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[x] Visual appearance of the changes.
[x] Responsiveness and internationalization.
[x] Strings and tooltips.
[x] End-to-end functionality of buttons, interactions and flows.
[x] Corner cases, error conditions, and easily imagined bugs.

@zulipbot  add maintainer review

@zulipbot add "maintainer review"

Please clean up your commit history and post again to request a review. See here for guidelines.

@zulipbot add "maintainer review"

Please update your commit message to match the commit style guidelines.
You will also need to complete the self-review checklist. You might want to go through ourguide on submitting a pull request to learn how to present your proposed changes to Zulip, so that your work can be reviewed.

@zulipbot add "maintainer review"

Please update your commit message to match the commit style guidelines.
You will also need to complete the self-review checklist. You might want to go through our guide on submitting a pull request to learn how to present your proposed changes to Zulip, so that your work can be reviewed.

hi @alya
Could you please review it once

@PieterCK would you be able to do an initial review pass here?
@Mukul1235 Your commit titles are missing periods, so please fix that up as well.

@Mukul1235 - Thanks for working on this issue! :smiley:
To get a better understanding of the pull request review process in Zulip, you can check out our documentation on the stages of a pull request. We use labels to track the different stages of the review, and our maintainers and reviewers will generally be the ones to update these labels to track where your PR is in the process. CMIIW, @sbansal1999
@zulipbot remove "maintainer review"

@Mukul1235 - I think you need to make sure your commits to follow our commit discipline. I'll point out a couple of things to consider

Focus on the why and how of the change instead of the whats.

The body of the commit message should explain why and how the change was made. Like a good code comment, it should provide context and motivation that will help both a reviewer now, and a developer looking at your changes a year later, understand the motivation behind your decisions.

I see that in the second commit, you described a couple of changes, are there any changes that you can split down to its own commit? generally, we want to keep each commit small and self-contained.
https://zulip.readthedocs.io/en/latest/contributing/commit-discipline.html#commits-should-generally-be-minimal
You can use our tool to automatically lint your commit description and summary format.

Additionally, it would be helpful to tidy up the PR description. Try to explain in more detail why and how you implemented it the way you did.
Writing clear explanations for your changes not only helps you get reviews faster but also helps you catch bugs and improve as a developer. I'll continue to review the code once you've reorganized the commits. Let me know if you have any concerns or questions!

@Mukul1235 - I think you need to make sure your commits to follow our commit discipline. I'll point out a couple of things to consider

Focus on the why and how of the change instead of the whats.

The body of the commit message should explain why and how the change was made. Like a good code comment, it should provide context and motivation that will help both a reviewer now, and a developer looking at your changes a year later, understand the motivation behind your decisions.

I see that in the second commit, you described a couple of changes, are there any changes that you can split down to its own commit? generally, we want to keep each commit small and self-contained.
https://zulip.readthedocs.io/en/latest/contributing/commit-discipline.html#commits-should-generally-be-minimal
You can use our tool to automatically lint your commit description and summary format.

Additionally, it would be helpful to tidy up the PR description. Try to explain in more detail why and how you implemented it the way you did.
I'll continue to review the code once you've reorganized the commits. Let me know if you have any concerns or questions!

@PieterCK Actually In the second Commit I fixed all the Tests That were failing. So If I Separate the Tests then Commit might not be Coherent

We should make the Integration Name field appear only when the user selects the "Incoming webhook" bot type.

We only need to show the user the "Integration name" dropdown if the selected bot type is an Incoming webhook bot. This should be included in the first commit.

Currently, I have added "Integration name" to every Bot type. Do we only need the integration_name for Incoming Webhook?

Hi @PieterCK
Did you got the time to review this PR?

Hmm the "Generate URL for integration" icon / modal is gone.

@Mukul1235 Hi. sorry for the delay. I've dropped some more reviews around the first commit, I feel like we're starting to move in the right direction. Let's continue polishing the first commit.

@Mukul1235 Hi. sorry for the delay. I've dropped some more reviews around the first commit, I feel like we're starting to move in the right direction. Let's continue polishing the first commit.

Let me know if you have any doubts

Fixed

@Mukul1235 Hi. sorry for the delay. I've dropped some more reviews around the first commit, I feel like we're starting to move in the right direction. Let's continue polishing the first commit.

Let me know if you have any doubts

Hi @PieterCK no problem. I have fixed the changes for the first commit

@Mukul1235 I dropped a couple more reviews. Let's add a validator that checks for "integration_name" before we save it to BotConfigData we want to make sure that its value must be in the WEBHOOK_INTEGRATIONS list. we're already doing a similar thing with Embedded bot:
# view/user.py/add_bot_backend()
...
if service_name not in [bot.name for bot in EMBEDDED_BOTS]:
      raise JsonableError(_("Invalid embedded bot name."))

Other than that, the "Generate URL for an integration" icon/modal is still missing.


deploy gateway in the same workspace as compute

Instead of deploying gateway on a dedicated Workspace (under SRE org), we can have it in the same SRE workspace as compute but in a different namespace.

Now that this process is out of development, I wonder if it should not be folded with either access_setup/setup_compute.sh or cluster_setup/bin/install.sh (depending on the permissions required).

That would be a follow up PR, but I think it needs to be discussed.

@Roming22 both locations may be problematic:

access-setup is just about setting up early access to the cluster that cannot be done via gitops, once access is enabled gitops tool will handle the rest. I think that we would want gateway config to be enforced by gitops.
setup-cluster is for now mainly about looping over existing physical cluster to install pipeline-service there.

The only image that currently deals with kcp setup via gitops is kcp-registrar.
Maybe we can have the following layout:

access_setup image which handles access setup for both kcp in pcluster (setup-compute.sh + setup-kcp.sh): nothing to change here
cluster-setup image which needs to be updated to work in a similar way:

compute-setup.sh to do what is currently done via "images/cluster-setup/bin/install.sh"
kcp-setup.sh which needs to do what "images/kcp-registrar/bin/register.sh" and "images/gateway-deployment/install.sh" are doing


Use poll instead of select to handle large fds

It may be the case that Cargo's running around with a lot of file descriptors,
and in this case we wouldn't be able to call select due to the file
descriptors being too large and not fitting in the bit array. This switches to
what the standard library is currently doing, using poll, which doesn't have
this limitations.

r? @matklad
(rust_highfive has picked a reviewer for you, use r? to override)

LGTM, but could we offload this all to some library? tokio_process should be able to do this.

Perhaps eventually! I think we're not quite ready to pick up that dep yet

@bors: r=matklad

:pushpin: Commit 2380c9e has been approved by matklad

:hourglass: Testing commit 2380c9ea8569552bf0c28247890b7394d180482d with merge b0601b89622d0a73b1c0871a0b5dd152b965d98c...

:broken_heart: Test failed - status-travis

@bors: retry
On Fri, Sep 8, 2017 at 12:00 PM, bors<EMAIL_ADDRESS>wrote:

💔 Test failed - status-travis
https://travis-ci.org/rust-lang/cargo/builds/273310059?utm_source=github_status&utm_medium=notification
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/rust-lang/cargo/pull/4477#issuecomment-328159060, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95FKxzm5rztoVeZmlnab3dvST1M48ks5sgXKrgaJpZM4PQtDZ
.

:hourglass: Testing commit 2380c9ea8569552bf0c28247890b7394d180482d with merge 33250c48b4763b01478d780e76206484a1d5b207...

:sunny: Test successful - status-appveyor, status-travis
Approved by: matklad
Pushing 33250c48b4763b01478d780e76206484a1d5b207 to master...


Adding .php_cs file as proposed by enebe-nb in #20 discussion

Please discuss any changes here (if we need any before this is merged)

Not sure header_comment is working. I ran it a few times and it never seemed to change anything. Also unable to find any docs.

I left the header_comment commented because it is a sugestion. The command php-cs-fixer --dry-run --diff will display the diffs without change any file, that will help to debug.
Now that i'm checking this, it only uses normal comment blocks to avoid conflict with doc blocks, but this way annotations won't work. Probably it won't help (although, the year is working).

related to this: FriendsOfPHP/PHP-CS-Fixer#1297

Removed header. Once we finalize the Code Standards from #20 I'll update the .php_cs as needed and commit the changes files.

@enebe-nb Having some issues with this command on travis:
output=$(php php-cs-fixer.phar fix -v --dry-run); if [[ $output ]]; then while read -r line; do echo -e "$line"; done <<< "$output"; false; fi;
There's always output even if there are no changes. We need to grep for "begin diff" or something similar when there is something to fix.

this command comes from my testing with that older version, it seem the exit code from cs-fixer changed many times. Probably using only php php-cs-fixer.phar fix -v --dry-run will work fine.

Using the command directly works, but it gets a "Undefined Class" error on hhvm

Yeah I see, I'm not terribly worried about HHVM right now since we're still waiting for another issue with it to be resolved.
Looks good, thanks for the work on this!


Getting corrupted data

I'm using Airgram, and when running multiple instances, I get corrupted data. I'm using a different database directory for every instance.
Info
OS: Ubuntu 20.04
TDLib: v1.6.0
Node: v12.16.1
Airgram: v3.0.2
ffi-napi: v3.0.1

https://github.com/airgram/airgram/issues/114#issuecomment-647872370
https://github.com/airgram/airgram/issues/114#issuecomment-648521809

See https://github.com/tdlib/td/issues/643.
This can't be currently fixed on TDLib's side, because the issue is in node-ffi and can be only workarounded by airgram.

There is a workaround - pause all Airgram instances except the active one. You can use airgram.provider.pause() and airgram.provider.resume() methods for it.

Closing as a duplicate of #643.


'onSeek' method ?

Is it possible to add callback when the user slide the seekbar (e.g onSeekStart, onSeekChange, onSeekEnd,...). I want to retrieve the current track's position. Thks !

This isn't yet implemented. I never thought that use case would be necessary. It shouldn't be difficult to implement though but I don't have the time right now since I am working on v2 of the plugin to support Ionic 2. Here's a hint so you can do it yourself:
https://github.com/arielfaur/ionic-audio/blob/master/dist/ion-audio.js#L400
Open the ion-audio.js file and simply add a new line to broadcast the event after that line above. Then capture that even in your controller. Something along the lines of:
        // handle track seek-to
        scope.sliderRelease = function() {
            var pos = scope.track.progress;
            MediaManager.seekTo(pos);
            $rootScope.$broadcast('ionic-audio:seekTo', pos);
        };

Then somewhere in your controller:
$scope.$on('ionic-audio:seekTo', function (e, pos) {
    console.log('Jumping to: ', pos);
})

Let me know if it works.

it leaves the error
ReferenceError: $rootScope is not defined
And I don't know where to insert the rootScope reference

it thrown the error rootScope is not defined

You need to inject  $rootScope in your controller

just use scope.$root instead of $rootScope, and it worked well.


Add missing property description to LineEdit

This pull request adds a missing property description to LineEdit in the class docs.

Superseded by #50203.


Social media links are hard to se in the footer

@richie-south I can pick this up. Anything you had in mind for the icons?

@kev1nboer Yes

@kev1nboer Yes
Would changing the colour be enough?

@kev1nboer We kinda want the footer to have the same color as the top menu bar

@richie-south Alright, so changing the colour on the icons to white would be OK?

@kev1nboer Yes sounds smart 👍

OK! Im on it!

@richie-south #308 Added a pull request!

merged the pull request


IngressGateway istiod connection error deployed with HELM

Bug Description
I am not able to deploy Istio with HELM charts. I am deploying the next charts:

base
istiod
gateway

Istiod deploys correctly but the gateway is giving the next errors:
2022-11-08T14:35:48.275795Z	info	FLAG: --concurrency="0"
2022-11-08T14:35:48.275824Z	info	FLAG: --domain="istio-ingress.svc.cluster.local"
2022-11-08T14:35:48.275831Z	info	FLAG: --help="false"
2022-11-08T14:35:48.275835Z	info	FLAG: --log_as_json="false"
2022-11-08T14:35:48.275838Z	info	FLAG: --log_caller=""
2022-11-08T14:35:48.275842Z	info	FLAG: --log_output_level="default:debug"
2022-11-08T14:35:48.275846Z	info	FLAG: --log_rotate=""
2022-11-08T14:35:48.275849Z	info	FLAG: --log_rotate_max_age="30"
2022-11-08T14:35:48.275853Z	info	FLAG: --log_rotate_max_backups="1000"
2022-11-08T14:35:48.275856Z	info	FLAG: --log_rotate_max_size="104857600"
2022-11-08T14:35:48.275861Z	info	FLAG: --log_stacktrace_level="default:none"
2022-11-08T14:35:48.275877Z	info	FLAG: --log_target="[stdout]"
2022-11-08T14:35:48.275883Z	info	FLAG: --meshConfig="./etc/istio/config/mesh"
2022-11-08T14:35:48.275887Z	info	FLAG: --outlierLogPath=""
2022-11-08T14:35:48.275890Z	info	FLAG: --proxyComponentLogLevel="misc:error"
2022-11-08T14:35:48.275894Z	info	FLAG: --proxyLogLevel="warning"
2022-11-08T14:35:48.275898Z	info	FLAG: --serviceCluster="istio-proxy"
2022-11-08T14:35:48.275901Z	info	FLAG: --stsPort="0"
2022-11-08T14:35:48.275905Z	info	FLAG: --templateFile=""
2022-11-08T14:35:48.275909Z	info	FLAG: --tokenManagerPlugin="GoogleTokenExchange"
2022-11-08T14:35:48.275919Z	info	FLAG: --vklog="0"
2022-11-08T14:35:48.275923Z	info	Version 1.15.3-bc21f4628d31fe5380569db6fa0e73517d956a0d-Clean
2022-11-08T14:35:48.277763Z	info	Maximum file descriptors (ulimit -n): 1048576
2022-11-08T14:35:48.277954Z	info	Proxy role	ips=[<IP_ADDRESS>] type=router id=istio-ingressgateway-5bf56ccc69-qpqbs.istio-ingress domain=istio-ingress.svc.cluster.local
2022-11-08T14:35:48.278049Z	info	Apply proxy config from env {"tracing":{"zipkin":{"address":"jaeger-collector.example.com:30411"}}}

2022-11-08T14:35:48.280568Z	info	Effective config: binaryPath: /usr/local/bin/envoy
configPath: ./etc/istio/proxy
controlPlaneAuthPolicy: MUTUAL_TLS
discoveryAddress: istiod.istio-system.svc:15012
drainDuration: 45s
parentShutdownDuration: 60s
proxyAdminPort: 15000
serviceCluster: istio-proxy
statNameLength: 189
statusPort: 15020
terminationDrainDuration: 5s
tracing:
  zipkin:
    address: jaeger-collector.example.com:30411

2022-11-08T14:35:48.280590Z	info	JWT policy is third-party-jwt
2022-11-08T14:35:48.280595Z	info	using credential fetcher of JWT type in cluster.local trust domain
2022-11-08T14:35:48.282935Z	debug	error in getting aws info for iam/info : unexpected status 401
2022-11-08T14:35:48.283157Z	info	Workload SDS socket not found. Starting Istio SDS Server
2022-11-08T14:35:48.283245Z	info	CA Endpoint istiod.istio-system.svc:15012, provider Citadel
2022-11-08T14:35:48.283380Z	info	Using CA istiod.istio-system.svc:15012 cert with certs: var/run/secrets/istio/root-cert.pem
2022-11-08T14:35:48.283567Z	info	citadelclient	Citadel client using custom root cert: var/run/secrets/istio/root-cert.pem
2022-11-08T14:35:48.296706Z	info	Opening status port 15020
2022-11-08T14:35:48.299126Z	info	ads	All caches have been synced up in 28.205995ms, marking server ready
2022-11-08T14:35:48.299563Z	info	xdsproxy	Initializing with upstream address "istiod.istio-system.svc:15012" and cluster "Kubernetes"
2022-11-08T14:35:48.301264Z	info	Pilot SAN: [istiod.istio-system.svc]
2022-11-08T14:35:48.302841Z	info	Starting proxy agent
2022-11-08T14:35:48.302943Z	info	starting
2022-11-08T14:35:48.303023Z	info	Envoy command: [-c etc/istio/proxy/envoy-rev.json --drain-time-s 45 --drain-strategy immediate --parent-shutdown-time-s 60 --local-address-ip-version v4 --file-flush-interval-msec 1000 --disable-hot-restart --log-format %Y-%m-%dT%T.%fZ	%lenvoy %n	%v -l warning --component-log-level misc:error]
2022-11-08T14:35:48.303622Z	info	sds	Starting SDS grpc server
2022-11-08T14:35:48.303817Z	info	starting Http service at <IP_ADDRESS>:15004
2022-11-08T14:35:48.304008Z	debug	Add CA file var/run/secrets/istio/root-cert.pem watcher
2022-11-08T14:36:08.297252Z	warn	ca	ca request failed, starting attempt 1 in 98.896047ms
2022-11-08T14:36:08.397234Z	warn	ca	ca request failed, starting attempt 2 in 191.840015ms
2022-11-08T14:36:08.589587Z	warn	ca	ca request failed, starting attempt 3 in 367.972657ms
2022-11-08T14:36:08.958254Z	warn	ca	ca request failed, starting attempt 4 in 790.069445ms
2022-11-08T14:36:29.750188Z	warn	sds	failed to warm certificate: failed to generate workload certificate: create certificate: rpc error: code = Unavailable desc = connection error: desc = "transport: Error while dialing dial tcp <IP_ADDRESS>:15012: i/o timeout"

Istiod service:
NAME     TYPE        CLUSTER-IP       EXTERNAL-IP   PORT(S)                                 AGE
istiod   ClusterIP   <IP_ADDRESS>   <none>        15010/TCP,15012/TCP,443/TCP,15014/TCP   177m

Sometime this works, but if I have 2 replicas only works in one. I can see that it is a connectivity error through istiod. But I don't know why.
The HELM Deploy is made by ArgoCD.
Version
EKS version: Server Version: v1.23.13-eks-fb459a0
Istio version: 1.15.3
OS: Bottlerocket

Additional Information
No response

This looks like an underlying K8s issue, not Istio specific. Istio depends on basic Kubernetes networking to function properly.

I don't know what can be happening... The networking of K8S it seems that is working properly. It is a weird error.
Can you think of anything I can check at the istio level?

I have fixed. The problem was with the AWS Security Group.
If you use the EKS Terraform module, you need to add this:
  node_security_group_additional_rules = {
    ingress_self_all = {
      description = "Node to node all ports/protocols"
      protocol    = "-1"
      from_port   = 0
      to_port     = 0
      type        = "ingress"
      self        = true
    }
    egress_all = {
      description      = "Node all egress"
      protocol         = "-1"
      from_port        = 0
      to_port          = 0
      type             = "egress"
      cidr_blocks      = ["<IP_ADDRESS>/0"]
      ipv6_cidr_blocks = ["::/0"]
    }
  }

Here is very well explained:
https://stackoverflow.com/questions/71902887/transport-error-while-dialing-dial-tcp-xx-xx-xx-xx15012-i-o-timeout-with-aws-e


Can Code-GPT support a custom OpenAI API endpoint?

I am a Chinese user, and due to the well-known network firewall, I cannot directly access api.openai.com. I need a reverse proxy to forward requests. I have set up my own reverse proxy server, so I hope Code-GPT can support a user-defined API request address.

This is not only nice for other users, but for users who want to log traffic for debugging.

+1

+1


Uncaught, unspecified "error" event

If ssh-agent is not running properly, sshpk-agent generates following error message.
Sat Jun 24 2017 13:30:06 GMT+0000 (UTC) - error: Sat, 24 Jun 2017 13:30:06 GMT uncaughtException: Uncaught, unspecified "error" event. (undefined)
 Sat Jun 24 2017 13:30:06 GMT+0000 (UTC) - error: Error: Uncaught, unspecified "error" event. (undefined)
     at Client.emit (events.js:163:17)
     at Immediate.<anonymous> (/app/node_modules/sshpk-agent/lib/client-fsm.js:313:9)
     at runCallback (timers.js:649:20)
     at tryOnImmediate (timers.js:622:5)
     at processImmediate [as _immediateCallback] (timers.js:594:5)

It should generate a better error message - something that indicates that ssh-agent is broken.

https://cr.joyent.us/#/c/2368


[ID] Error 500 in console when trying to delete an interested, rejected, or assigned grants

Server logs show:
Sep 28 08:49:49 AM  server: error: select "users"."id" as "user_id", "agencies"."id" as "agency_id" from "users" left join "agencies" on "users"."tenant_id" = "agencies"."tenant_id" left join "tenants" on "tenants"."id" = "users"."tenant_id" where "users"."id" = $1 and "users"."tenant_id" = $2 and "agencies"."id" = $3 - invalid input syntax for type integer: "{"0"}"

@mhuang-usdr a temporary fix is up: https://www.loom.com/share/92e6392256aa4c5980743e1d8ae64eae
Since I'll be out next week it will be good for you and @TylerHendrickson to coordinate deploying this. As I mention in the video and the PR- I don't feel great about this fix since there's many things wrong in this endpoint, but I think this is the simplest way to add a test and resolve the bug for now. We should open a separate Issue to refactor this code a bit more thoroughly once I'm back from vacation.

@as1729 can this be closed?

Yes, looks like @TylerHendrickson was able to make the necessary changes to the PR. 👍


Agent Tests

Added tests for RandomVacuumAgent and compare_agents (the last one comes from #395, after I edited grammar/spelling).
We can now close #395. Thanks @articuno12 for the original test.
NOTE: I did not have much time to research this, but from the tests I ran it seems that RandomVacuumAgent always leaves the environment in the same state. If that is not the case and the agent leaves the environment in a random state, let me know and I will remove/update the test.
EDIT: Set random.seed, so it will now pass each time.

UPDATE: Set random.seed, so that it doesn't matter if the function is deterministic or not. It will now pass every time.

If there is no dirt in an environment, then anything an agent does, even a random one, will not add dirt.


API explorer sending invalid authorization header?

While trying out the API at https://tidbyt.dev/docs/api, my calls would fail with the status code 401 and below response, even though I'd authorized with a valid API key.
{
  "code": 16,
  "message": "auth error: rpc error: code = Unauthenticated desc = Bad authorization string",
  "details": []
}

Inspecting the call in the debugger, I noticed the authorization header does not include the Bearer prefix:
authorization: eyJhbGciOiJFUzI....

Could this be why they're failing?

Yes, I just noticed the same thing myself.
I would expect in the page that it would prepend Bearer and a space for you, but that is not the case.


Windows XR Plugin 2.0.4 preview.3 breaks tracking on HoloLens 2

Windows XR Plugin 2.0.4 preview.3 breaks tracking on HoloLens2 in Unity 2019.31.1f1. When upgrading from Windows XR Plugin 2.0.3 to 2.0.4 preview.3, the tracking of the head and hands does not work properly anymore, i.e. the content, including tracked hands shifts away from the user.
Steps to reproduce the behavior:

Install Unity 2019.3 1f1
Create new project and install MRTK 2.3 following these instructions: https://microsoft.github.io/MixedRealityToolkit-Unity/Documentation/GettingStartedWithTheMRTK.html
Follow these instructions for using the XR SDK: https://microsoft.github.io/MixedRealityToolkit-Unity/Documentation/GettingStartedWithMRTKAndXRSDK.html
Update Windows XR Plugin in Package Manager to 2.0.4 preview 3 as advised in MRTK 2.3 release notes
Set MRTK profile to DefaultXRSDKConfigurationProfile
Build project for Visual Studio 2019
Use Visual Studio to deploy project to HoloLens 2
Observe that the content and hands shift when moving the head, i.e. tracking does not work properly

Expected behavior: Head tracking works properly and content does not shift.
Setup

Unity 2019.3 1f1
MRTK Version 2.3
Windows XR Plugin 2.0.4 preview 3

Target platform:

HoloLens 2

This is currently a known issue with that version of the plug-in. I'm working with Unity to get a fix in for the next release.
In the meantime as a workaround at app launch, covering the HoloLens sensors with your hands to force tracking loss and uncovering them should help you regain positional tracking.

Yes, the workaround with covering the sensors works for now. Thanks!

Thanks @keveleigh. Closing this out for now, since this is an issue with the XR Unity plugin.

Has this been fixed? When is a fix to be expected?

Seriously, this needs a fix, basically cannot develop for HL2 in unity

This was fixed a while ago. The latest several releases should work as expected.
Note that if you're still seeing the camera not track with your headset, you might need a Tracked Pose Driver on your scene camera. This gets added at runtime by MRTK if you're using the XR SDK profile.


Dual-list not rendering correctly with filter=true; filter input boxes appear in the middle of the select lists and filter icons are shifted to the right by approx. the width of the entire dual listbox

In Firefox/Chrome/Edge, with filter="true" the css appears as shown below

with the filter input box appearing midway between, and overlapping. the first and second items.   The filter icons are also shifted all the way to the right of the viewport.

In your example, it looks like you are not loading the Bootstrap 3 css. In the demo's index.html:
<link rel="stylesheet" href="https://maxcdn.bootstrapcdn.com/bootstrap/3.3.7/css/bootstrap.min.css"
  integrity="sha384-BVYiiSIFeK1dGmJRAkycuHAHRg32OmUcww7on3RYdg4Va+PmSTsz/K68vbdEjh4u" crossorigin="anonymous">

Here's the demo with Firefox:


Move lecture notebooks 2020

This PR will move the lecture notebooks from 2020 into a new folder.

LGTM, feel free to merge

LGTM, feel free to merge


Multiple small improvements

I was playing with the project during a boring meeting and came up with some improvements, this is a bit of a mixed bag and I am sorry to mix concerns in a single PR.
@david-poindexter I know you are in vacation but when you are back or if you feel like taking a look at this, feel free to comment. Also if you have other ideas on how to accomplish some of these things...
In This PR:

Adds a custom number input field to solve the problem centering the values with the labels responsively.
Adds a configurable shift multiplier to set by how much to change values when using the keyboard arrows and holding shift
Implements the copy button ( closes #13 )
Uses javascript to make the controls responsive in relation to the component size and not the screen size ( closes #21 ) Let me know what you think of how this wraps on small widths...
Adds some documentation
Replaces the 3 switch mode buttons by a single one
Reduces the size a bit for the circle of the preview color (personal preference here for when the component in a rather small container, open to opinions on this ???
Adds a transition to the switching of input fields

I am merging this because I need this for the next set of changes, we can always edit if required

@valadas I tstarted reviewing this yesterday but just didn’t have enough time since it was my first day back in the office.  I will try to get to this as soon as possible though.

@valadas I finally got some time today to review all this and I think it is all great.  Thanks for the work on this!  I am going to create a few minor issues and submit PRs for them as soon as possible.


Update LICENSE

Codecov Report

Merging #2 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master       #2   +/-   ##
=======================================
  Coverage   88.88%   88.88%
=======================================
  Files           2        2
  Lines           9        9
=======================================
  Hits            8        8
  Misses          1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3332c4...e259042. Read the comment docs.

hey

test


Question: it it possible to exclude cam and TS?

Can I exclude thos from my list? same as I can exclude porn from the list? If yes can anyone tell me how or if no maybe it would be nice in a future version ;-)
Thanks anyway

Anyone? I would like to know how this can be done for a certain user.

Use http://www.brainbytez.nl/spotweb-filter-creator/ to create your own filters.


Add nodePool.LeaseDuration

Add documentation on NodePool.LeaseDuration that shipped with version 2.7.0

These changes get pulled in from https://github.com/smartcontractkit/chainlink/blob/develop/core/config/docs/chains-evm.toml#L323 when a new version releases. But there's still a small fix we can make in this PR so we'll merge it.


API  fs.SyncWriteStream abandoned in node8

$ hexo g
(node:3876) [DEP0061] DeprecationWarning: fs.SyncWriteStream is deprecated.
...

See https://github.com/hexojs/hexo/issues/2598
Therefore I updated hexo-fs in<EMAIL_ADDRESS>Please update your plugin, then this issue would be resolved.
If you do still encounter issues, please let us know.

@grzhan Now can be closed.Thanks for your work.😬


docs: Add Easypanel as a deployment method

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@sum35h @sharat87 can you check this, please?

It's unfortunate to hear that. EasyPanel is a very practical and user-friendly control panel, and it's also included in documentation for many well-known applications. It would have been helpful for your users to be able to install it with just one click. I find it strange that you didn't include such a direction when there are about 10 alternative installation guides available.


useGpu roperty on Mapsui.ios

Fixes this: https://github.com/Mapsui/Mapsui/issues/484 (With setting usepgu to false)

Can somehow not run the Mapsui.ios sample

Main change is that the rendering can be changed for iOS from gpu to cpu due to some gpu bugs on certain platforms


EcoCampus: Create shapefiles of case study

"Empty" shape files needed to run properties/demand script.

@gabriel-happle  The best way is to prepare all the databases in excel to make a join with a shapefile with only the names of the buildings. i can do this.
To do this, please prepare 1 shapefile and three excel files:
shapefile 1: Just all the building geometries with only the field 'Name' in it.
excel file 1: Create an excel file with the column names of age.shp (be aware of upper/lower case). Fill it in if you have the data.
excel file 2: Create an excel file with the column names of occupancy.shp (be aware of upper case). Fill it in if you have the data.
excel file 3: Create an excel file with the column names of zone.shp (be aware of upper case). Fill it in if you have the data.
Attention, all excel files should have the same 'Name' column and the same name of buildings.

OK. I'll do that asap.
Do we want to consider "common space" as occupancy?

maybe in architecture.shp? so during the calculation we discount that space from the occupancy...
On 9 Mar 2017, at 2:07 pm, Gabriel Happle <notifications<EMAIL_ADDRESS>wrote:
OK. I'll do that asap.
Do we want to consider "common space" as occupancy?
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHubhttps://github.com/architecture-building-systems/CEAforArcGIS/issues/528#issuecomment-285263666, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AIjrgsQ_ga2ERrfm9ubzyTaBrOmd5lupks5rj5cKgaJpZM4MVGZL.

OK. So our total of the mixed usage will be smaller than 1?
i.e. OFFICE = GFA_OFFICE / GFA_TOTAL
Or we distribute the common spaces to the other usages and just consider it in Hs and Es?
i.e. OFFICE = GFA_OFFICE / (GFA_TOTAL - GFA_COMMON)

I guess the second… what do you think?
On 9 Mar 2017, at 3:30 pm, Gabriel Happle <notifications<EMAIL_ADDRESS>wrote:
OK. So our total of the mixed usage will be smaller than 1?
i.e. OFFICE = GFA_OFFICE / GFA_TOTAL
Or we distribute the common spaces to the other usages and just consider it in Hs and Es?
i.e. OFFICE = GFA_OFFICE / (GFA_TOTAL - GFA_COMMON)
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHubhttps://github.com/architecture-building-systems/CEAforArcGIS/issues/528#issuecomment-285276157, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AIjrgrdm7yIB8xqSQCvoc7ToVvoBMtpFks5rj6qHgaJpZM4MVGZL.

Yes. Probably. Otherwise we don't have any electric load in that areas (lighting, etc.)... Or we create the common space later.
I will prepare the files for the second one.


[core] Usage of invalid boolean - int comparison in a small method

Class com.google.common.util.concurrent.Monitor
    private void signalNextWaiter() {
        for (Monitor.Guard guard = this.activeGuards; guard != null; guard = guard.next) {
            if (isSatisfied(guard) == 1) { // <<< isSatisfied(...) returns boolean
                guard.condition.signal();
                return;
            }
        }
    }

APK: https://drive.google.com/file/d/1Hmwjs-Qc8kKc7mx90oC_n1YagOd01jar/view?usp=sharing

@bagipro that was a terrible bug. I am glad you spot it. Thank you!


No module named 'langchain.pydantic_v1'

I am getting this error "No module named 'langchain.pydantic_v1' while executing the below code:
with CodeInterpreterSession() as session:
  # generate a response based on user input
  response = session.generate_response(
      "Plot the bitcoin chart of year 2023"
  )

  # output the response
  response.show()

I installed the packages using
pip install "codeinterpreterapi[all]"
Any ideas how to solve it?

Also getting the error "cannot import name 'settings' from 'codeinterpreterapi'"

Same. And when you install it, it ends up conflicting with a couple of things (mainly the issue being FastAPI -- althought Chainlit too if you are using that):
If you are using  pydantic v2+
ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
chainlit 0.6.402 requires pydantic<2.0.0,>=1.10.8, but you have pydantic 2.3.0 which is incompatible.
fastapi 0.99.1 requires pydantic!=1.8,!=1.8.1,<2.0.0,>=1.7.4, but you have pydantic 2.3.0 which is incompatible.

vs
If you are using pydantic v<2
ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
codeboxapi 0.0.19 requires pydantic<3,>=2, but you have pydantic 1.10.12 which is incompatible.
codeinterpreterapi 0.0.12 requires pydantic<3,>=2, but you have pydantic 1.10.12 which is incompatible.
pydantic-settings 2.0.3 requires pydantic>=2.0.1, but you have pydantic 1.10.12 which is incompatible.

for me  fast api and its working  i am using a down graded version (codeinterpreterapi==0.0.7),downgrading may help ,
also while using fast api my openai imports also failed to work then try installing using (conda install -c conda-forge openai)
but when i am using JWT authenticationin fast api ,i am getting error
Process SpawnProcess-1:
Traceback (most recent call last):
File "/data/data/minicoda2/envs/ecom_auto/lib/python3.10/multiprocessing/process.py", line 314, in _bootstrap
self.run()
File "/data/data/minicoda2/envs/ecom_auto/lib/python3.10/multiprocessing/process.py", line 108, in run
self._target(*self._args, **self._kwargs)
File "/data/data/minicoda2/envs/ecom_auto/lib/python3.10/site-packages/uvicorn/subprocess.py", line 61, in subprocess_started
target(sockets=sockets)
File "/data/data/minicoda2/envs/ecom_auto/lib/python3.10/site-packages/uvicorn/server.py", line 48, in run
loop.run_until_complete(self.serve(sockets=sockets))
File "/data/data/minicoda2/envs/ecom_auto/lib/python3.10/asyncio/base_events.py", line 649, in run_until_complete
return future.result()
File "/data/data/minicoda2/envs/ecom_auto/lib/python3.10/site-packages/uvicorn/server.py", line 55, in serve
config.load()
File "/data/data/minicoda2/envs/ecom_auto/lib/python3.10/site-packages/uvicorn/config.py", line 308, in load
self.loaded_app = import_from_string(self.app)
File "/data/data/minicoda2/envs/ecom_auto/lib/python3.10/site-packages/uvicorn/importer.py", line 20, in import_from_string
module = importlib.import_module(module_str)
File "/data/data/minicoda2/envs/ecom_auto/lib/python3.10/importlib/init.py", line 126, in import_module
return _bootstrap._gcd_import(name[level:], package, level)
File "", line 1050, in _gcd_import
File "", line 1027, in _find_and_load
File "", line 1006, in _find_and_load_unlocked
File "", line 688, in _load_unlocked
File "", line 883, in exec_module
File "", line 241, in _call_with_frames_removed
File "/home/datascience.apis/ecom_automation/./JWT_GUI_MAIN.py", line 13, in
from code_interpreter_GUI_test import main_2
File "/home/datascience.apis/ecom_automation/./code_interpreter_GUI_test.py", line 1, in
from codeinterpreterapi.session import CodeInterpreterSession
File "/data/data/minicoda2/envs/ecom_auto/lib/python3.10/site-packages/codeinterpreterapi/init.py", line 1, in
from codeinterpreterapi.session import CodeInterpreterSession
File "/data/data/minicoda2/envs/ecom_auto/lib/python3.10/site-packages/codeinterpreterapi/session.py", line 6, in
from langchain.tools import StructuredTool, BaseTool
File "/data/data/minicoda2/envs/ecom_auto/lib/python3.10/site-packages/langchain/init.py", line 6, in
from langchain.agents import MRKLChain, ReActChain, SelfAskWithSearchChain
File "/data/data/minicoda2/envs/ecom_auto/lib/python3.10/site-packages/langchain/agents/init.py", line 2, in
from langchain.agents.agent import (
File "/data/data/minicoda2/envs/ecom_auto/lib/python3.10/site-packages/langchain/agents/agent.py", line 16, in
from langchain.agents.tools import InvalidTool
File "/data/data/minicoda2/envs/ecom_auto/lib/python3.10/site-packages/langchain/agents/tools.py", line 8, in
from langchain.tools.base import BaseTool, Tool, tool
File "/data/data/minicoda2/envs/ecom_auto/lib/python3.10/site-packages/langchain/tools/init.py", line 3, in
from langchain.tools.arxiv.tool import ArxivQueryRun
File "/data/data/minicoda2/envs/ecom_auto/lib/python3.10/site-packages/langchain/tools/arxiv/tool.py", line 12, in
from langchain.utilities.arxiv import ArxivAPIWrapper
File "/data/data/minicoda2/envs/ecom_auto/lib/python3.10/site-packages/langchain/utilities/init.py", line 3, in
from langchain.utilities.apify import ApifyWrapper
File "/data/data/minicoda2/envs/ecom_auto/lib/python3.10/site-packages/langchain/utilities/apify.py", line 5, in
from langchain.document_loaders import ApifyDatasetLoader
File "/data/data/minicoda2/envs/ecom_auto/lib/python3.10/site-packages/langchain/document_loaders/init.py", line 44, in
from langchain.document_loaders.embaas import EmbaasBlobLoader, EmbaasLoader
File "/data/data/minicoda2/envs/ecom_auto/lib/python3.10/site-packages/langchain/document_loaders/embaas.py", line 54, in
class BaseEmbaasLoader(BaseModel):
File "/data/data/minicoda2/envs/ecom_auto/lib/python3.10/site-packages/pydantic/main.py", line 262, in new
fields[ann_name] = inferred = ModelField.infer(
File "/data/data/minicoda2/envs/ecom_auto/lib/python3.10/site-packages/pydantic/fields.py", line 315, in infer
return cls(
File "/data/data/minicoda2/envs/ecom_auto/lib/python3.10/site-packages/pydantic/fields.py", line 284, in init
self.prepare()
File "/data/data/minicoda2/envs/ecom_auto/lib/python3.10/site-packages/pydantic/fields.py", line 356, in prepare
self.type_analysis()
File "/data/data/minicoda2/envs/ecom_auto/lib/python3.10/site-packages/pydantic/fields.py", line 424, in type_analysis
if isinstance(self.type, type) and isinstance(None, self.type):
File "/data/data/minicoda2/envs/ecom_auto/lib/python3.10/site-packages/typing_extensions.py", line 1073, in subclasscheck
raise TypeError('TypedDict does not support instance and class checks')
TypeError: TypedDict does not support instance and class checks


FW auto land switch yaw to wheel controller

Large yaw actuation during FW landing flare.
http://logs.uaventure.com/view/XDxR5X5pVEjYNULpojSQdB

The main problem is the switch to the wheel controller here - https://github.com/PX4/Firmware/blob/master/src/modules/fw_pos_control_l1/fw_pos_control_l1_main.cpp#L1622
@AndreasAntener @tumbili I think one of you implemented the wheel controller and landing?
How should we solve this? I thought about hiding the switch behind runway takeoff enable, but there are plenty of little planes with steerable landing gear that you might want to hand launch. Should we try to detect touchdown?
The next question is why did the yaw setpoint drop 0 (_target_bearing) instead of maintain yaw?
Reported here - http://discuss.px4.io/t/issues-with-landing-rudder-on-flying-wing/1863/13

@AndreasAntener @tumbili @LorenzMeier thoughts on the following

enable/disable the wheel controller based on RWTO_TKOFF
enable/disable the wheel controller based on a new param
try to detect touchdown before enabling (probably more work with testing)

I'll also figure out what happened with the yaw setpoint at flare, which could be the only thing to actually fix here.

@Kjkinney reported the issue and is willing to help test solutions.

I had a quick look in the source but couldn't find an obvious reason for the strange yaw setpoint.

Reproducible in SITL.
On Sun, Dec 11, 2016 at 10:35 AM, Andreas Daniel Antener <
<EMAIL_ADDRESS>wrote:

I had a quick look in the source but couldn't find an obvious reason for
the strange yaw setpoint.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/PX4/Firmware/issues/5970#issuecomment-266288647, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAFK6MWN3m0RFPa-CnAZUjAGkHirXw-hks5rHBgngaJpZM4LD0q3
.

The problem here is that it's possible to skip over heading hold, but then in flare the uninitialized _target_bearing is used as the yaw setpoint while the wheel controller is enabled.

We can fix this by setting _target_bearing properly, but does heading hold as horizontal distance to the landing waypoint make sense? It seems like progress along the glide slope or simply right before flare would be more appropriate.


Need FloatingRateName for USD-FEDFUND

Existing CCP data references this index as USD-FEDFUND (no dash).
The following names are currently supported
USD-FED-FUND = USD-FED-FUND
USD-Federal Funds-H.15-OIS-COMPOUND = USD-FED-FUND
USD-FEDFUND-H.15-OIS-COMPOUND = USD-FED-FUND

FloatingRateName only includes FpML names. If USD-FEDFUND is an FpML name for that index then it makes sense to add it.
If not, you can add names to FloatingRateName without adding them to Strata. Create a file on the classpath called /com/opengamma/strata/config/application/FloatingRateNameData.ini containing the mappings and it will be loaded by Strata.
Check the Javadoc of ResourceConfig for details.

If the code is an end user application use /com/opengamma/strata/config/application/FloatingRateNameData.ini. If it is a library produced by OpenGamma, use /com/opengamma/strata/config/library/FloatingRateNameData.ini

Thank you. This is for an OG Library. One of the supported CCPs provides reset and curve data under the name USD-FEDFUND. I try out changes to the ini file and close the ticket once I have it working.


API return 502 HTTP error when trying to get full warning

Describe the bug
When I try to get the full warnign with the "get_warning_full()" method, I get a 502 HTTP error.
The  "get_warning_full()" method seams only work with Paris (75)
log
Traceback (most recent call last):
  File "/var/www/html/weather/weather.py", line 137, in <module>
    get_weather(WXCity)
  File "/var/www/html/weather/weather.py", line 46, in get_weather
    wx_warns = getWarnsFromAPI(anMeteoAPI)
  File "/var/www/html/weather/weather.py", line 35, in getWarnsFromAPI
    my_place_warn = aMeteoAPI.client.get_warning_full(aMeteoAPI.my_place.admin2)
  File "/home/pi/.local/lib/python3.9/site-packages/meteofrance_api/client.py", line 275, in get_warning_full
    resp = self.session.request("get", "warning/full", params={"domain": domain})
  File "/home/pi/.local/lib/python3.9/site-packages/meteofrance_api/session.py", line 52, in request
    response.raise_for_status()
  File "/usr/lib/python3/dist-packages/requests/models.py", line 943, in raise_for_status
    raise HTTPError(http_error_msg, response=self)
requests.exceptions.HTTPError: 502 Server Error: Bad Gateway for url: https://webservice.meteofrance.com/warning/full?token=__<token>__&domain=60

Got the same issue, it seams that the endpoint got updated but not in the python lib


Fix docs build

Pull Request Test Coverage Report for Build 41acadaeaaaacc7e5ff11156738259eb79aa9db3-PR-858

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 68.937%

Totals

Change from base Build 3e765139ca807ac57dc5208fa75d92777f1fc8ea:
0.0%

Covered Lines:
992

Relevant Lines:
1439

💛  - Coveralls


Broken texture image in sky for various dimensions

I've been seeing the magenta two offset squares thing in the sky somewhat often in various dimensions. First time, I thought it might be some sort of double moon/planet or something. But last night, there were giant ones wrapping around the sky, and it was quite obvious. Doing /rftdim info [dim number here] told me it was supposed to be the inferno sky. I do have a screenshot, but I'm pretty sure you know what the broken texture thing looks like. :)
rftools-1.10-5.26.jar, rftoolsdim-1.10-4.40.jar, mcjtylib-1.10-2.1.3.jar, on Forge 2094 and MC 1.10.2.

Hmm I'll check it out. Did you have any celestial bodies in your dimension?

I'll take a look shortly at the inferno one to find out. Just needed to MCEdit out some blocks because Chisel is causing Botania to crash the client on load. Yay.

The complete info is:
Dimension ID 7
Description string @Bminecraft:mutated_swampland,CSingle,#mminecraft:stone@0,TFlat
Owned by: Addle42
Base seed:<PHONE_NUMBER>
World version: 1
Terrain: TERRAIN_FLAT
Base block: Stone
Base fluid: null
Biome controller: CONTROLLER_SINGLE
Biome: Swampland M
Sun brightness: 1.0
Star brightness: 1.0
Sky color: 0.0, 0.6, 0.6
Fog color: 1.0, 1.0, 1.0
Sky type: SKY_INFERNO
Weather rain: 1.0
Mob: net.minecraft.entity.monster.EntitySilverfish
Doesn't seem to say there, but looking around, all I have in the sky are giant magenta offset squares wrapping around the horizon. I see no celestial bodies.
A lovely dimension, isn't it? As a side note, I forgot to put it back in the Dimension Builder before going to look for celestial bodies, and died in a collapsing world.

Fixed next release. Note try to report dimension issues in the RFTools Dimension issue tracker

Thanks! And oops, I derped. I did mean to report it in the RFTools Dimensions issue tracker, I swear. XD


2D Character Controller and object-collision

Please add scripts for 2D character controlling (if possible with vector forces assigned to movement hotkeys) and player-object collision.

Coming up.


Falco on Kind with Prometheus and Grafana

/area documentation
What would you like to be added:
The section referenced by this link does not exists: https://falco.org/docs/getting-started/running/#running-falco-in-a-kind-cluster
Why is this needed:
Installing falco inside kind might be useful.

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle stale

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle rotten

Hey @nicop311, just saw this issue. Since you seem to have found out the right link, would you like to open a PR to correct the broken one?

Hi @jasondellaluce , I needed to understand what the problem was since I don't remember anything about this issue :sweat_smile: .
On the website : https://falco.org/blog/falco-kind-prometheus-grafana/, there is a section with a link which should explain how to use Falco with k8s KinD, but the section #running-falco-in-a-kind-cluster does not exist:
On the github, we can see the following: https://github.com/falcosecurity/falco-website/blob/b1852a801294fcd17dfef1473f1d5951d12ebd5e/content/en/blog/falco-kind-prometheus-grafana.md
[...]
## Create a Kind cluster
Running Falco in a Kind cluster is easy, as explained in the [documentation](https://falco.org/docs/getting-started/running/#running-falco-in-a-kind-cluster).
[...]

The link is not broken, but the section #running-falco-in-a-kind-cluster about k8s KinD does not exist.
However the section Running Falco in a Kind cluster seems to exist here:
https://github.com/falcosecurity/falco-website/blob/06f1dcf52561100103fa379e5b60713e7fcb55aa/content/en/docs/running.md
But even on this running.md file, there are not a lot of details on how to run/use Falco on KinD.
I did not tested Falco with KinD, I personally went with Flatcar OS + k3s instead of KinD.
Plus, k8s KinD is using nested containers on top on Docker (k8s nodes are docker containers, k8s pods are running on the nodes). In this situation of nested containers, I do not know how the Falco eBPF probe or the kernel modules should be configured/installed.
Therefore, I am not confident about opening a PR to correct the link, since I am not sure the explanation is enough.
I hope this comment is useful though.

Thanks for spending time in explaining your point. That's still great feedback towards the quality of our docs. 👍🏼

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
Provide feedback via https://github.com/falcosecurity/community.
/close

@poiana: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
Provide feedback via https://github.com/falcosecurity/community.
/close

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


[BUG] No way to block the creation of users.

Describe the bug
Setting allowed users in the GUI and/or the .env file blocks access to non-allowed users, but does not block the creation of new users through the public frontend page IE lnbits.mydomain.com
To Reproduce
Steps to reproduce the behavior:

As admin user, create a new users in the usermanager extension.
Set this new user as "allowed user" in the admin GUI and the .env.
Restart LNbits.
Visit the public frontend and try to create a new user. The GUI states "User not authorized." but the new user is in fact still created, his userID is visible in the URL and the creation is logged.

Expected behavior
Setting "allowed users" blocks the creation of new users by anyone other than the admin.
A clear message is displayed that visitors of the frontend are not allowed to create new users.
LNbits version: 0.10.8
Database: sqlite

But can that new user enter his wallet? That's just the way lnbits works, it checks if the user is allowed after it's creation!

The user can't access the wallet, but the account is still created.
An attacker could create infinite accounts until my disk is full and my machine crashes.


[fountainhead] Add Fountainhead strategy

This strategy can be used for a system which allows gradual unlocking of tokens via streams.
It sums up unlocked, locked and staked tokens.

Hi @d10r What's your space? 🤔
Looks like no space is using your previous strategy
https://snapshot.org/#/strategy/superboring


Feature: an option to use custom highlight groups.

Added a config option to provide highlight group name to use instead of default inverted colors.
This pull request closes #89.

Could you tell me what scheme you used above?

Could you tell me what scheme and hl group name you used above?

Catppuccin Macchiato with highlight group Visual.

Thanks!


CSS for host wrapping

Seems there needs to be an edit for the CSS to force it to wrap hostnames rather than keeping them on one line. As you can see from the screenshot, it is starting to extend beyond its intended container on the right.

Had this issue too - PR submitted.


Need a resource to set a NIC alias so you can reliably use xDnsServerAddress

xDnsServerAddress uses the NIC alias as the key.  You shouldn't have to query ahead of time the nic alias or guess

I think we could add support to use a wildcard NIC alias - e.g. '' or 'ethernet' . The NIC alias would still remain the key.

I think there was a PR floating around to add support for wildcard aliases? I recall there was one but there was some trouble with it so the PR got closed. @tysonjhayes, do you remember if this was the case? I can't find the Issue or PR though. Perhaps the change could be resuscitated?

Yep - there was one floating around that got closed recently. It might have been in another repo though.
I'll check the ones I'm tracking..

Yes it was #57, was recently closed because the author didn't have time to get it fixed up to be merged.

@PlagueHO @tysonjhayes @iainbrighton You may need to query to find the NIC on multiple values (especially on physical machines, Such as the physical media type, the status, etc.  Additionally, predicting the name might be difficult if the hardware is not standardized.).  A separate resource that sets the name would be more salable (the actual interface alias could be used on every resource instead of needing to put the query code in each resource.)
I've prototyped such a resource as xNetworkAdapterName

@TravisEz13, I really like your idea about the xNetworkAdapterName resource instead of needing to change xDNSServerAddress.
I'd also suggest that the xNetworkAdapterName resource should support setting the adapter name based on MAC as well. The reason for this is that I automate VM creation where I know/can set the MAC of each adapter in a VM on creation and automatically assemble the DSC configurations with that in mind. At the moment I'm using unattend.xml to configure the Adapter name on first boot so that xDNSServerAddress etc can be used against a known adapter name. So this would solve a problem for me.
My 2c. Thanks.

@PlagueHO I'm hitting design issues on the resource.  My current thought is to write the helpers to perform the work and expose them in the xNetworking module.  Then the helpers can be used in a script resource for now until the design work is done.

@TravisEz13 - this sounds like a good approach to me.
I'm presuming that the helper would allow any resource to query the available network adapters based on particular requirements (Is it up, Adapter Number, Device driver etc) and then return the appropriate adapter. This would then allow these criteria to be exposed by parameters in each resource - meaning that an adapter could be chosen without knowing the actual name. Or is this not the approach you're thinking of?

@PlagueHO
I would have a get, set, test method, with query parameters and a name parameter.  They would behave like a resource and allow you to build easily a script resource.  I plan only to support 2 query parameters to begin with, physical media type (optional, no default) and status (optional, but defaulted to be 'Up'),   Other query parameter can be added after the, basic concepts have been worked out.
Get- would tell you the name of the first interface which matches the criteria, and how many match the criteria (an interface with the exact name will always be included,)
Test- would return true if you have an interface matching the name (the query parameter are ignored.  I'm assuming you are using a unique name and this shouldn't be a significant issue.)
Set- if there is not already an interface matching the name, take the interface returned my get and rename it to the name you specified.

@PlagueHO FYI, my changes are here NetAdapter.   I've integrated the changes into some test work I'm doing.

@TravisEz13  - ah I see. So these three function of the "NetAdapter helper module" could then be consumed by the other Resources to allow them to identify the specific adapter to work on. So each resource would need to be updated to take the same parameters as the "NetAdapter helper module" - is that correct?
Seems like a pretty good approach to me. It also looks like the xNetAdaperName resource you've created is also a great idea. This actually solves a problem I currently have: I'm assigning Network adapter names of the devices using a script run on first boot of a VM - which is a very nasty approach. This new resource will eliminate this - excellent!
Really great stuff there!

@TravisEz13 The xNetAdapterName resource is badly needed, particularly on hypervisors other than Hyper-V. So; chop, chop :stuck_out_tongue_winking_eye:

@iainbrighton @PlagueHO I've tested my functions.  I'm ready to PR, but the names aren't approved.  My current idea is that I add a warning that the names of the function and parameters are being designed and may change.  Then I can get some feedback about the functions, while there are open questions

@iainbrighton @PlagueHO FYI, I've submitted my PR

I'll close this for now.  Someone can open an new issue if an actual resource is needed.

I might implement an xInterfaceName module using this at some point - I could definitely use that myself. I'll log an "New resource" issue in case someone else wants to have a go. Thanks @TravisEz13


Improve autocorrect for Capybara/CurrentPathExpectation

expect(page.current_path).to eq(EXPECTED_VALUE) is not directly equivalent to expect(page).to have_current_path(EXPECTED_VALUE)
In particular, have_current_path with no options will include the querystring on the path, while page.current_path does not.
This fix ensures the option ignore_query: true is set on have_current_path expect when EXPECTED_VALUE is a string or regexp.
In those cases, it should be safe to not use this param.
Fixes #798

@Darhazer done! :D


fastlane capable of revoking push certificates?

I am on fastlane 2.64.0, getting
[!] You already have 2 active push profiles for this application/environment. You'll need to revoke an old certificate to make room for a new one

And I know how to fix by revoking on website, but wondering, can fastlane revoke those certs programmatically or through CLI?

@fxfactorial There is no way to remove non-expired push certs right now. I'm pretty sure pem can only renew expired ones (right now) 🙃


Alps 587 - Bad sync on director's cut

Fix bad timing synchronization in the Director and CameraAnimation.
Took into account the onSeeked event.

 All committers have signed the CLA.

Sometimes the bad sync is corrected but not in all cases. Tested with low bandwidth.


Added other open-source load testing alternatives

Added open-source load testing tools that support scripting: Artillery, Gatling, k6, and Locust.

@ppcano : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#reassign pboramsft

#sign-off

@ktoliver : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Added two "hello"

Klingon and vulcan language from star trek
https://en.wikipedia.org/wiki/Klingon_language#Vocabulary

Agh, sorry, I thought the update branch would be a rebase rather than a merge back. Will squash anyways so hopefully this won't bork the history too much 😛


Config sanitycheck stops scanning search paths at first unset context variable

In OCIO v2, when a config’s search_path contains a context variable that hasn’t been set, the sanitycheck prevents existing fallback LUTs from being accounted for. Here’s an example:
config.ocio
ocio_profile_version: 1
search_path: $SOMETHING/luts:luts
roles:
  scene_linear: raw
displays:
  default:
    - !<View>
      name: raw
      colorspace: raw
colorspaces:
  - !<ColorSpace>
    name: raw
  - !<ColorSpace>
    name: lut
    from_reference: !<FileTransform> {src: lut.cube}

luts/lut.cube
LUT_1D_SIZE 2
0 0 0
1 1 1

Terminal
$ python
>>> import PyOpenColorIO as ocio
>>> config = ocio.Config.CreateFromFile('config.ocio')
>>> config.validate()
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
PyOpenColorIO.Exception: Config failed sanitycheck.  The search_path '$SOMETHING/luts' cannot be resolved.

Please note that this happens regardless of the ocio_profile_version, and isn’t the expected behaviour in OCIO v1.

Fixed & merged in main, RB-2.0 and RB-2.1.


upload_dir support in Craft CMS, fixes #4302

The Problem/Issue/Bug:

#4302
Related attempt and conversation in #4303

How this PR Solves The Problem:

Remove the wired upload_dir
Remove the wired docroot (seems inappropriate? DDEV will autodetect, and people should be able to override?)
Support specifying upload_dir in tests

TODO:

[x] The Craft CMS test in TestDdevFullSiteSetup is leaving cruft in the project directory (.env file) - need to fix that.

Manual Testing Instructions:

[ ] ddev config --upload-dir=files on a craft project and see if it works with mutagen and ddev start - it should not warn.

There is no need to set --docroot=web unless the code does not yet exist. That's the case in the composer-build quickstart. It will be autodetected otherwise.
But people certainly may put the project in a subdir or have a different docroot, and the existing code would have blown away their configuration I think, right?

@rfay okay I didn't realize that DDEV would auto-detect web/ if so then I agree, it's redundant/pointless.
As for the subdir, I'm assuming the check that was in there if app.Docroot == "" works, because people are using it (see recent docs PR).
But anyway yeah moot point if DDEV auto-detects web/ regardless! Looks good!

tested with ddev import-files with upload_dir set; it imported properly. mutagen/mutagen.yml was properly edited.

I'm researching a upload_dir set behaviour and stumbled upon this issue. was part of the issue that upload_dir will always be a sub directory of the docroot (which should not be) or was that behaviour introduced here? From reading the code it doesn't look like.

@riconeitzel The issue here is that Craft can be configured with multiple local user-generated directories, so there’s little point in hard-coding any single upload_dir. Read more about the general issue at https://github.com/ddev/ddev/issues/4190.

@riconeitzel The issue here is that Craft can be configured with multiple local user-generated directories, so there’s little point in hard-coding any single upload_dir. Read more about the general issue at https://github.com/ddev/ddev/issues/4190.


proposal: wiki: CodeReviewComments: remove guideline against 'this' / 'self' receiver names

The page at https://github.com/golang/go/wiki/CodeReviewComments#receiver-names has this to say about receiver names for struct methods:

Don't use generic names such as "me", "this" or "self", identifiers typical of object-oriented languages that gives the method a special meaning. In Go, the receiver of a method is just another parameter and therefore, should be named accordingly.

This explanation was added in #28475.
But I don't believe this is a good argument:

C++, Python, and Lua all have identical semantics as Go here

This includes the behaviour when calling methods on null this pointers; and
casting to a function with an extra parameter ("just another parameter")

The rest of the paragraph describes how to bypass this rule by creating an equally generic name, by taking some single letters of the type name - that is a needless impediment to good refactoring

In fact, there are benefits to using self/this:

Normalised name for identical concept as other languages

reduces friction in polyglot codebases
improves onboarding speed for new Go developers

Simplifies automated porting

I am interested in removal of this blessed guideline as a first prerequisite towards removing this as a default lint rule in vet and in other tools.
(However, I would support a vet rule enforcing that the names this/self are only used with pointer receivers, for the same reasons above.)

I've always felt an added burden when reading method code which doesn't use a predictable receiver name. Especially as you need to see clearly where a method alters its object's state.
Worse still when the name is one letter among other single-letter names!

The wiki page is a style guideline, and as it says the Go style is not to use names like self or this for method receivers.
I believe that the explanation is accurate.  At least in C++, virtual methods are special, and the name this has a special meaning: it refers to the real object with virtual methods attached, not to the object whose type appears in the method.  Go doesn't have virtual methods, and the method receiver is always the exact type shown in the receiver.
If you want to write code that uses a different style, go ahead.  You can also simply ignore the associated lint errors.

The current style guideline has the advantage of internal consistency: the naming convention for a parameter is the same whether or not it's the receiver. This makes sense to me, since in Go the receiver behaves no differently from other parameters.
Also for what it's worth, I've had substantial experience with both Python and C++ and I still prefer the Go style. It feels odd now to name all method receivers the same, even ones of completely unrelated types.

In bigger projects involving many developers, I find readability much more important than "this has a special meaning in other languages" (who cares about other languages) and "internal consistency" arguments. We read code 10x more often than we write code, and it is important to quickly know what an identifier represents.
this/self enables a reader to quickly know that the identifier is the receiver.
I don't see why naming the receiver this or self would be of such importance that it warrants a section of its own in the idiomatic golang style guide.

We've been writing Go code for a decade with a convention of not using this or self as the receiver name. That's simply not going to change at this point.


Eth1 plugin

Documenting @NIC619's awesome idea
What is wrong?
In eth2 we need to listen to events of the deposit contract on eth1.
How can it be fixed
In production

Run an instance of a Trinity Eth1 chain, or this could be just another eth1 full client like Geth.
Run the Eth1Plugin as a light client, it monitors the deposit event and notifies the BeaconPlugin to take actions.

In development

Eth1Plugin generates fake deposit data.

Close in favor of https://github.com/ethereum/trinity/issues/709.


Update Covalent UI core library to beta.2

It seems there is a bug in @covalent/core that prevents building for production.
See Teradata/covalent#319
Covalent beta.2 is out!
Further info: https://github.com/Teradata/covalent/blob/develop/docs/CHANGELOG.md#100-beta2-hotel-california-2017-02-23

Would be it possible to add the next core changes when you do the PR?

In angular-cli.json, change the styles attribute:
"styles": [<EMAIL_ADDRESS>      "theme.scss",       "styles.scss"     ],

In .gitignore add:
/scripts/*.js or /**/*.js


Don't use alphabetic sort on version list

This is a small thing, but I've noticed that juliaup status puts 1.10 in-between 1.1 and 1.2.
15:27:07 ❯ juliaup st
 Default  Channel  Version                                               Update
--------------------------------------------------------------------------------
          1.0      1.0.5+0.x64.linux.gnu
          1.1      1.1.1+0.x64.linux.gnu
          1.10     1.10.0-beta3+0.x64.linux.gnu
          1.2      1.2.0+0.x64.linux.gnu

This was fixed in https://github.com/JuliaLang/juliaup/pull/724. @davidanthoff, can we get that PR into a release?

About to release a new build, closing


Save to File not working

I've tried this in vanilla and a couple of modpacks but every time I click save to file nothing happens. I had a look to see if it saves a file somewhere in the folder, but still can't find it.

I didn't know about that feature, but looking at it it's part of the material list GUI.  The relevant code is this:
https://github.com/Lunatrius/Schematica/blob/84d6ebb9cdf6922ad76c0ffa40cdb45f4a4a8e1c/src/main/java/com/github/lunatrius/schematica/client/gui/control/GuiSchematicMaterials.java#L131-L138
which seems to me to be saving it in .minecraft/dumps/schematica-materials.txt, or else logging an error (but nothing in chat/on the GUI) if it fails.
Thinking about it, that feature would probably be more useful as a clipboard-copy thing instead (GuiScreen.setClipboardString).

Could you also post the log file? Would help is figure out why the saving fails.
And I agree, copying the entire thing directly to the clipboard might be the best thing to do.


Enhance .data relocation / .bss zero initialization with MEMC managed memory

.bss zero initialization (via z_bss_zero()) and .data relocation (via z_data_copy()) is done early in the boot up via the function z_prep_c().
In addition to initializing RAM, z_bss_zero() also internally calls
bss_zeroing_relocation();
which is the auto-generated code via CMake helper zephyr_code_relocate().
Thus when relocating data to an external RAM (via MEMC driver), the relocation happens before any driver initialization is done.
My setup is for XMC4700 (the MEMC drivers have not been upstreamed yet). But it should be the same issue of the other SoC with MEMC drivers (i.e. Atmel SAM SMC).
Impact
Invalid data in .data section. And a .bss that's not zero-initialized.

@pdgendt, @nandojve, would you mind having a look please, as I believe it also applies to Atmel SAM SMC drivers.

Hm... this is not a memory management issue, but rather an issue related to boot and driver initialization. z_prep_c() is an early boot process to prepare an environment for later initialization steps (including driver initialization). So there is no way for this to work as part of the early boot process if it depends on a driver initializing the needed memory. So the solution would involve initializing the external memory during the early boot process, but before the C environment has already been set up... and this will need some specially crafted code.
TBH, I don't think there can be a generic solution as each architecture has their own z_prep_c(), and it will be hard to cater to all different external memory controllers.

Did you have a chance to look at my PR that's in draft? It adds an extra
property in the DTS that delays relocation for the MEMC Ram regions.
On Tue, Feb 27, 2024, 5:31 PM Daniel Leung @.***> wrote:

Hm... this is not a memory management issue, but rather an issue related
to boot and driver initialization. z_prep_c() is an early boot process to
prepare an environment for later initialization steps (including driver
initialization). So there is no way for this to work as part of the early
boot process if it depends on a driver initializing the needed memory. So
the solution would involve initializing the external memory during the
early boot process, but before the C environment has already been set up...
and this will need some specially crafted code.
TBH, I don't think there can be a generic solution as each architecture
has their own z_prep_c(), and it will be hard to cater to all different
external memory controllers.
—
Reply to this email directly, view it on GitHub
https://github.com/zephyrproject-rtos/zephyr/issues/68884#issuecomment-1967774676,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEFAFWZZ4HW5PLHVYQRRSVTYVZNFDAVCNFSM6AAAAABDFAXWGCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRXG43TINRXGY
.
You are receiving this because you authored the thread.Message ID:
@.***>

Part of me doubt that would work unless you are very careful on where data is placed. The reason is that continue execution of code may require some data having already relocated. So you will need to make sure any code executed between z_prep_c() and relocation being done do not access the relocated region. Relocated BSS may not be as important unless the code relies on it being zero at first.

Yes,  you have to be careful not to reallocate some driver data. It's up to the user to
check that the code they relocate is not used before INIT_LEVEL_PRE_KERNEL_1 level.
My use case is to reallocate some application data or library that is used much later in the boot.

I have a similar request.   I have a board that uses the MCXN947 with external PSRAM.   I need to be able to do some pin muxing and clock init such that the FlexSPI controller is intialized.     This needs to happen before the c startup/copydown routines.
Even having a simple hook or weak function that can be called before C system init would be helpful.
I currently have a prototype that will do the minimal number of calls to get things setup,  I just need a way to call this function right before the branch to z_prep_c
Having something like this:
`
#ifdef CONFIG_PRE_C_START_HOOK
bl z_pre_c_startup_hook
#endif
/*
 * 'bl' jumps the furthest of the branch instructions that are
 * supported on all platforms. So it is used when jumping to z_prep_c
 * (even though we do not intend to return).
 */
bl z_prep_c

`
would be good enough for a 1st implementation.  This would allow me to add some special code in my board files without needed to modify reset.S
I could prepare a PR with some guidance  as to possible alternatives and have the least impact on existing implementations.
The only other option I can think of is to have some sort of  dual image setup (like MCU_BOOT) that is a boot stub that will get the PSRAM setup, then jump to the Zephyr application.  i.e. simulate something like the bootrom in the i.MXRT with the DCD capabilities.


ARROW-8872: [CI] Restore ci/detect-changes.py

This is needed for Travis-CI builds to function properly.
The file was mistakingly removed in db1c49a77f78152d442299082f6a663e59f91174, part of PR #7080 (fixing ARROW-8662).

Travis-CI build: https://travis-ci.org/github/pitrou/arrow/builds/689214234

Will merge.

Oops! I saw that appveyor PR sitting there passing CI so I merged it. Unfortunately the Travis job that used that script again was added between when the commits were done and when I merged it :/

Thanks Antoine!


Updates for PureScript 0.8

@paf31 I renamed Data.Validation to Data.Validation.Semigroup, to go with Data.Validation.Semiring. It seems fair enough, since either one is potentially as desireable as the other. Sound ok?

@paf31 bump!

:+1: Makes sense to me.


[Suggestion] It's better to quit all completion lists after entering "Esc" one time

OS: Windows 10 and Mac
Build Version: 20200818.1
Repro Steps:

Open one template file, such as new-vm.json.
Find any string expression and remove the contents of the string.
Type this into the string "[concat(".
Verify that the completion lists displayed.

Enter "Esc".

Actual:
Not all completion lists are disappeared. ("Esc" should be entered twice to quit all completion lists)

Suggestion:
It's better to quit all completion lists after entering "Esc" one time.
More Info:
All completion lists will be disappeared after clicking other positions of this template file.

@v-ruizh Thanks for entering, but we have no control over this - this is vscode behavior.


Count the length of value using terraform-compliance

Hello :wave:
I am trying to test the length of a value using terraform-compliance.  I am completely open to how to do this or if its even possible, but I think I am misunderstanding the count action.  From my testing, I can only use it to count the amount of occurrences of something, rather than test a values length.
Feature: Test

  Scenario Outline: Naming Standard For Resource Groups
    Given I have output <resource_name> defined
    When it has <name_key>
    Then it must have name
    Then its value must match the "rg-.*-(dev|tst|prd).*" regex
    When I count it
    Then its value must be less to 24

    Examples:
      | resource_name                | name_key |
      | azurerm_resource_group | name        |

This just checks that there is less than 24 groups defined, which of course, there is.  But I want to count the value, not the occurences
Another way round this is testing if a variable exists which is enough for me:
variable "test" {
default = 26
}

Feature: Test
  Scenario: Test Length
    Given I have any variables defined
    When it has default
    Then it must have value to be less to 24

If I could swing this, or even using an output, I could perform a length() check using Terraform and check that it matches a value.
Is it possible?

Hi @craigthackerx ,
Thanks for creating this issue.
Implementing length instead of count should be very easy, let me have a look on this.

Happy to hear suggestions about an understandable BDD directive for using length instead of count
   When I count it

   When I measured it
   When I measured the length of it
   ...
   suggestions :)

Yeah when I measure the length sounds good to me.
Can you @ me on the finished code when it's done so I can read and try and learn? I'd like to be able to contribute more but wouldn't know where to look!


Fix missing plurals from #1928

Coverage remained the same at 65.195% when pulling a90bcb402aba6faec069f4a9c72d4854e88bf876 on iBug:patch-2 into 825a685217f52141f921047facae22b268d35b6b on Charcoal-SE:master.


Adapt OVModel for optimum recent changes

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Make it working on macos

You can see testing result at https://github.com/niku/setup-elixir/actions/runs/45241114.
Notes

At this time, unlike linux, bob don't have prebuild package for macOS.
Homebrew that is package manager for macOS provides packages for erlang and elixir. However, these packages have limitations for version control. For example, elixir package provides only 1.10.1. Therefore, we can't install 1.9.1.

Does this need anything before it can be merged? I'm trying to get https://github.com/elixir-lsp/vscode-elixir-ls/pull/31 merged

It is ready to merge 👍  Go ahead please.

I've reached out to @ericmj to see if there's any plans to build for macOS, but it sounds like their current build platform doesn't offer macOS.
Not knowing exactly what the build dependencies are for OTP/Erlang and Elixir, it looks like this just works, for the most part, so maybe it's at least a good stop-gap solution.

@niku After thinking this through a bit more, I don't think we should offer a solution that builds from source—this would unfortunately re-build OTP and Elixir for every individual workflow run, and I'm wary of users accidentally eating up their usage with this action.
I'm going to close the PR and open an issue to discuss pre-built macOS images.

https://github.com/actions/setup-elixir/issues/23

Thank you for your comment. I agree your concerns. I'll tackle to #23 .