Windows: path, PATH, and exec improvements

This PR further improves Windows support in the Nit standard library and testing tools:

Improve Windows path manipulation and standardize the solution. On Windows, services working on path strings first replace all \ by /. This allows sharing the main code with other OS, data copy should be limited since only the first operation on a string should update it.
All file services depending on the path separator should have been updated, except for relpath. Note that there is still no special treatment for FS root like C:/, so further work is needed.
Support for Windows' PATH where the separator is ;.
Fix pipes left open on the parent side after CreateProcess.
Intro a basic skip list for MINGW64 Windows system with projects that are either incompatible (cocoa & ios) or not available with msys2 and that I don't plan to configure manually on the test server in the near future.

There are still issues (including an int overflow in Float::to_s), but this PR allows a few larger projects to work on Windows. With #2390 gamnit projects can be compiled entirely from a Windows machine (or cross-compiled).

The unit tests are marked ~~~nitish because they are only valid when is_windows == true. Maybe we could have a ~~~nitwindows or something like that for such tests in the future. Note that you can set -D is_windows=true to try them (but not on nitunit sadly).
The Jenkins Windows test server is currently broken. I'll see if I can fix it, otherwise, I'll share the results form my test server later.

Added some blocking tests to the skip list, it looks like a multithreaded libgc config problem.
Fixes 15 tests (not counting the skips):
../src/examples/nitwebcrawl.nit
../src/nitpick.nit
../src/test_model_visitor.nit
base_conflict_class_name.nit
base_conflict_submodule_name.nit
base_module_conditional.nit
error_class_glob.nit
error_gen_f_inh_clash.nit
error_mod_unk.nit
error_unk_class2.nit
test_annot_c_compiler.nit
test_multiconstraint_ref.nit
test_multiconstraint_ref2.nit
test_new_native.nit
test_super_gen_raf.nit


An idea on how to pull off collision

(I know barely anything about modding so if this is dumb I'm sorry)
So I read the FAQ on the forum page, and it mentioned that it was extremely unlikely that collision was going to be implemented due to the fact that you would have to rewrite the system.
I'm sure you're aware that shulkers were implemented in 1.9, and had solid collision boxes. Would it be possible to therefore take that code and apply it to a custom collision box? The shulker collision probably isn't hard-wired to being a box, although I have no idea ¯_(ツ)_/¯

Hard collision isn't the issue. The issue is that Minecraft uses axis-aligned bounding boxes, meaning 1. they have to be square*, and 2. they cannot rotate.
Any sort of real collision for ships would have to be done entirely custom and patched into the Minecraft game engine, which is obviously undesirable.
*: okay, technically, an AABB in Minecraft doesn't have to be square, and you can generate them on-the-fly to simulate rotation by calculating the smallest rectangular solid that would envelope a complex shape, but it still doesn't fix ship collision, since it has to be a continuous rectangular solid.

By the way, an unrelated question - I've seen old videos of full block interaction on an airship. Will this be implemented or has the idea been given up on?

Those were videos of highly experimental and buggy code that pretty much only worked with vanilla blocks; it was far from finished and darkevilmac abandoned it since there was still a lot of grueling work to be done to make it stable.

Ah, I see.  Mods like the RC mod use a java port of the bullet physics engine called jBullet. Would this at all help?

Not really, voxel collision is something general-purpose rigid body engines like Bullet are really bad at.

Okay, thanks for answering my annoying stream of questions anyway :)


Blog marked as active for other content type's archives

Is this a support or usage question? Please post to StackOverflow using the Timber tag
Expected behavior
I'm working on a site where we have several custom post types, each one with its own archive template. In each template we have a structure not too far apart from what is seen on Timber's starter theme:
https://github.com/timber/starter-theme/blob/master/archive.php
That is, we have a get_context at the top and further down the page we have a call to get_posts.
One thing I've noticed is that even before I run the get_posts, the context already has a posts entry loaded. In this scenario, isn't calling get_posts redundant here?
Another issue I'm seeing, and perhaps this is related to the fact that get_context loads posts before any further logic is run on the template, is that the blog archive menu entry is marked as active for other content types.
Problem can be seen here:
https://contenderbicycles.com/our-people/
This URL loads an archive page for a custom post type and the logic looks like this:
<?php

if( !defined( 'ABSPATH' ) ) exit;

use Lumberjack\PostTypes\Staff;

$context = Timber::get_context();

$templates = array('index.twig');

$queried_object = get_queried_object();
$context['taxonomy'] = $queried_object;
$context['posts'] = Staff::all();
$context['title'] = $queried_object->name;

array_unshift( $templates, get_post_type() . '/archive.twig', 'archive.twig' );

Timber::render($templates, $context);

If you notice on the footer menu, you'll see that both the "Blog" and "Our People" menu entries are being marked as active, even though the latter is the correct one.
Is this a bug, or how can one get around the issue above?
How did you install Timber? (for example, from GitHub, Composer/Packagist, WP.org?)
WP.org running latest version

Hey, our people page isn't children of the blog?

No. That would actually possible since the Blog is a custom archive page, but that isn't the case. I've been seeing this issue very frequently for different sites so I was wondering if anyone else seeing it.

Its strange because blog have current_page_parent class.

That is the issue im reporting here.

Experiencing the same issue :'(

Closing this for now as part as a cleanup. If you still run into this issue, please open a new ticket with steps how to reproduce. Preferably without Lumberjack to keep it as close to Timber core as possible.


18938 - Linter and pytest updates

*Issue:18938 *https://github.com/bcgov/entity/issues/18938
Description of changes:
Fixed linter issues
added test to pass 80% coverage
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).

/gcbrun

Temporary Url for review: https://bcregistry-btr-dev--pr-98-lsttrch5.web.app


Third Party cookies not get impacted with --test-third-party-cookie-phaseout testing

Read https://developer.chrome.com/docs/privacy-sandbox/third-party-cookie-phase-out/ for context before raising issues here.
For site-specific issues with third-party cookies, please report this via https://goo.gle/report-3pc-broken
Hello,
I am an engineer on AWS QuickSight Embedding team. We provide Embedding QuickSight application in other enterprise's web application via iframes. We have been manually testing if our customers will be impacted due to 3p cookie phaseout using the steps mentioned in https://developers.google.com/privacy-sandbox/blog/cookie-countdown-2023oct#test but as per our testing so far - the cookies are not getting blocked in chrome on test applications(using a different domain). We are using google sites for building test application in a different domain. This experience is completely different from what is expected or described as a result of 3p cookie phaseout. Is there a reason quicksight's cookies are not getting blocked? We use SameSite=None and Secure flags on the cookies we set.

Is your domain shared with any other product teams within AWS?  Its possible another team has applied for the deprecation trial.
Can you try testing with these flags disabled?
chrome://flags/#tpcd-metadata-grants
chrome://flags/#third-party-cookie-deprecation-trial

Chrome DevTools also includes information on why third-party cookies were included (despite 3PCD), since Chrome M123. You can check the DevTools to find out why Chrome is allowing your cookie to be sent.

Hi Thanks, for your response. We were able to find out why the cookies were not getting blocked. The enterprise managed Chrome we were using at work was overriding the blocking of 3P cookies for amazon domain(always allowing them). We were able to confirm the cookies actually getting blocked on a non-enterprise managed chrome.


[Proof] Remove redundant assertion in new

Motivation
We should not have the assertion here. Clients would call new when constructing the proofs from protobuf objects, but the objects returned by servers are not guaranteed to be correct. So a bad server could cause the clients to crash.
We can either remove the assertion or change it to ensure. Since we will verify the proof later, it's probably redundant to do this particular check in new and we can just remove it?
Have you read the Contributing Guidelines on pull requests?
No.
Test Plan
N/A
Related PRs
None.

good job on reacting so quickly! @bors-libra r=delegate

:pushpin: Commit f19c8a7 has been approved by delegate

:hourglass: Testing commit f19c8a7707b2cd561d30f875f7e9f1cdf3ba6408 with merge 1bb85f8f7a0e443807e8fe02e1f48807671e3b1a...

@metajack I think I made a mistake :D meant delegate+ instead of r=delegate

:bulb: This pull request was already approved, no need to approve it again.

This pull request is currently being tested. If there's no response from the continuous integration service, you may use retry to trigger a build again.

:pushpin: Commit f19c8a7 has been approved by delegate

:v: @wqfish can now approve this pull request

:hourglass: Testing commit f19c8a7707b2cd561d30f875f7e9f1cdf3ba6408 with merge b89a90659fca92cac328100c4c13e64c46d9fa82...

:sunny: Test successful - checks-circle_commit_workflow
Approved by: delegate
Pushing b89a90659fca92cac328100c4c13e64c46d9fa82 to master...


Update request: meli 0.8.6 → 0.8.7

Package name: meli
Latest released version: 0.8.7

Current version on the unstable channel: 0.8.6
Current version on the stable/release channel: 0.8.5

[X] Checked the nixpkgs pull requests

Notify maintainers

@0x4A6F, @matthiasbeyer

Note for maintainers: Please tag this issue in your PR.

Add a :+1: reaction to issues you find important.

Release notes: https://git.meli-email.org/meli/meli/releases/tag/v0.8.7
This will not fix https://github.com/NixOS/nixpkgs/issues/332957#issuecomment-2278578811, since time is still at v0.3.28 in meli 0.8.7.  It was only updated in https://git.meli-email.org/meli/meli/commit/6b05279a0987315c401516cac8ff0b016a8e02a8, which is not part of any release yet.

Sure, do you want to PR an update?

Sure, do you want to PR an update?

I created https://github.com/NixOS/nixpkgs/pull/338258.  It builds, but tests failed locally with "m4 executable not found in PATH".  In addition to fixing that I also need to work through https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md.

Sure, do you want to PR an update?

https://github.com/NixOS/nixpkgs/pull/338258 is done from my point of view, apart from some error in the ofborg-eval-darwin job that I can't explain and don't know how to solve: https://github.com/NixOS/nixpkgs/pull/338258#issuecomment-2322562064


Circuit simulation error: cannot load library 'libngspice.so'

Running the first SKiDL simulation example sim = circ.simulator() results in the error:
Exception has occurred: OSError
cannot load library 'libngspice.so': libngspice.so: cannot open shared object file: No such file or directory.  Additionally, ctypes.util.find_library() did not manage to locate a library called 'libngspice.so'
  File "/home/shanemattner/Desktop/skidl_spice_test/sandbox.py", line 24, in <module>
    sim = circ.simulator()                 # Create a simulator for the Circuit object.

To Reproduce
Steps to reproduce the behavior:

run the 'current through resistor' example in SKiDL documentation

Expected behavior
Simulation should run like example
Screenshots
I followed this thread about the problem and confirmed that ngspice is installed
from skidl import *
print(lib_search_paths)

# Load the SKiDL + PySpice packages and initialize them for doing circuit simulations.
from skidl.pyspice import *
print(lib_search_paths)

from ctypes.util import find_library

ngspice_lib_filename = find_library('ngspice')
print(ngspice_lib_filename)

Results in:
{'kicad': ['.', '/usr/share/kicad/symbols'], 'skidl': ['.', '/home/shanemattner/.local/lib/python3.10/site-packages/skidl/libs'], 'spice': ['.']}
{'kicad': ['.', '/usr/share/kicad/symbols'], 'skidl': ['.', '/home/shanemattner/.local/lib/python3.10/site-packages/skidl/libs'], 'spice': ['.']}
libngspice.so.0

Desktop (please complete the following information):

Fedora 36
Python 3.10
SKiDL version

Additional context
Add any other context about the problem here.

Have you tried creating some links to the shared libraries as in this thread?

After creating the appropriate symbolic link I was able to run the example until this issue blocked the file from running.
Here's the command for anyone running Fedora 36
[shanemattner@fedora-1 lib64]$ sudo ln -s libngspice.so.0.0.4 libngspice.so
[shanemattner@fedora-1 lib64]$ ls -l | grep ngspice
lrwxrwxrwx. 1 root root        19 Aug  6 18:21 libngspice.so -> libngspice.so.0.0.4
lrwxrwxrwx. 1 root root        19 May 20 00:31 libngspice.so.0 -> libngspice.so.0.0.4
-rwxr-xr-x. 1 root root  10464656 May 20 00:45 libngspice.so.0.0.4
drwxr-xr-x. 1 root root       120 Aug  4 19:48 ngspice


feat(express): Added response and request body logging

:tada: This PR is included in version 1.10.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.10.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


add dockerfile

@anandhupvr I'm trying to setup this in docker so that once its working we can easily share it with the other teams without much environment issues. One approach to get this working is to carefully isolate the necessary code one by one and running it.: For eg: we can perhaps start here, https://github.com/google-research/tensor2robot/tree/master/layers and dry run some of the layers to test if there are any issues with the other libs. This approach will also make us understand the whole system to a larger degree.

build command:
sudo docker build --build-arg user_id=99 -t bcz:dev .
run:
./run_docker.sh bcz:dev /home/christie/projects/tensor2robot_bcz/


Incorrect Multi-line Pipeline Indentation when inside a Scriptblock that also has a Pipeline

System Details

Manjaro Linux:
### VSCode version: 1.56.2 054a9295330880ed74ceaedda236253b4f39a335 x64

### VSCode extensions:
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>

### PSES version: <IP_ADDRESS>

### PowerShell version:

Name                           Value
----                           -----
PSVersion                      7.1.3
PSEdition                      Core
GitCommitId                    7.1.3
OS                             Linux 5.12.2-1-MANJARO PowerShell/vscode-powershell#1 SMP PREEMPT Fri May 7 17:53:15 UTC 2021
Platform                       Unix
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

Windows 10 Enterprise:
### VSCode version: 1.56.2 054a9295330880ed74ceaedda236253b4f39a335 x64

### VSCode extensions:
<EMAIL_ADDRESS>
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>

### PSES version: <IP_ADDRESS>

### PowerShell version:

Name                           Value
----                           -----
PSVersion                      5.1.19041.906
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.19041.906
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>

Issue Description
When using IncreaseIndentationForFirstPipeline or IncreaseIndentationAfterEveryPipeline as multiline pipeline indentation style the code is formatted inproperly when inside a Scriptblock which also has pipeline indents.
Examples are with IncreaseIndentationForFirstPipeline and show some Pseudo-Powershell.
Expected Behaviour

# if OTBS and IncreaseIndentationForFirstPipeline is selected this code won't be reformatted as it is already "correct"

$Test = $SomeValues |
    Select-Object Some, Values |
    Sort-Object -Property Values

if ($Test) {
    #Do stuff with test
}

# this should also be considered correct and not getting reformated
Test-Scriptblock -Scriptblock {
    $Test = $SomeValues |
        Select-Object Some, Values |
        Sort-Object -Property Values

    if ($Test) {
        #Do stuff with test
    }
} -PassThru |
    Run-Scriptblock

Actual Behaviour

# as expected nothing was reformatted

$Test = $SomeValues |
    Select-Object Some, Values |
    Sort-Object -Property Values

if ($Test) {
    #Do stuff with test
}

# but here the indentiation does not stop at sort-object (..) but rather indents everything that follows too
Test-Scriptblock -Scriptblock {
    $Test = $SomeValues |
        Select-Object Some, Values |
        Sort-Object -Property Values

        if ($Test) {
            #Do stuff with test
        }
    } -PassThru |
        Run-Scriptblock

# with IncreaseIndentationAfterEveryPipeline the same incorrect indentation will be applied
Test-Scriptblock -Scriptblock {
    $Test = $SomeValues |
        Select-Object Some, Values |
            Sort-Object -Property Values

            if ($Test) {
                #Do stuff with test
            }
        } -PassThru |
            Run-Scriptblock

Attached Logs

No logs to attach -

Can reproduce and agree that it is a bug. Playing a bit with it, the bug is invoked due to the presence of the last pipe after PassThru

I was about to raise a bug on the PowerShell extension when I stumbled upon this one. @bergmeister  I can see the same issue when there is no pipe after the scriptblock. for example:

In this case, I have the Pipeline Indentation Style set to IncreaseIndentationAfterEveryPipeline but the behavior is similar when using IncreaseIndentationForFirstPipeline.


Possibility to dynamically add and remove options from a select

Hey,
it would be really nice if it was possible to add and remove options from a select. maybe somrthing similar to form arrays?
best regards
johannes

@JBusch First of all, thanks for your activities here! You could already do that manually but there is definitely a need for a simple function to achieve this. This will probably be the next little feature to land in the lib. Maybe observable-based (see also #165).


PreferJavaTimeOverload interacts poorly with AssertJ assumeThat

Description of the problem / feature request:
There's already special casing for AssertJ assertThat, however the assumeThat function has similar problems. Perhaps it would be best to exclude invocations with overloads that are not date types (boolean, arrays, etc) as a general solution rather than individually excluding common libraries.
Feature requests: what underlying problem are you trying to solve with this feature?
Same as above.
Bugs: what's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.
org.assertj.core.api.Assumptions.assumeThat(1).isEqualTo(1);
What version of Error Prone are you using?
2.3.4
Have you found anything relevant by searching the web?
no.

Thanks - we should fix this (and thanks for the PR!)


Include a Listening Port ENV Var

Im using the docker compose version of this.
It would be nice to include the LISTENING_PORT Env variable so that I can set it from the compose file.
It seems like nicotine+ does have a cli arg here
https://github.com/nicotine-plus/nicotine-plus/blob/master/pynicotine/__init__.py#L74
that would start the app with that port number. Could we pass in the ENV in the Dockerfile and then send in the listening port arg in the autostart file?
I use this container with gluetun VPN and sometimes glueutn will change the port number for my port forward.

Does the CUSTOM_PORT variable not work in this case? It changes the HTTP port that the VNC viewer listens on.

Ahh I see. Makes sense, thanks! Once you have a chance to test out the PR I'm happy to accept the change.

Thanks for your contribution!


Convert groups to generic views/viewsets

Picking off the lower hanging fruit first.
This converts the groups section of the admin to use generic views/viewsets.
In the process I removed the ability to sort by name, because this is the only field and thought making it default to sorting by name would be more sensible.

@chosak could you have a look through this, please?


Make CORS Headers configurable to server

This change is

Coverage decreased (-0.6%) to 66.929% when pulling 5986f33ed1fe58cd889ff01a68f497f6e2258193 on AddCORSHeaderConfigurationToServer into b80b7be3df695e11e96f22345a71109948655034 on master.

Coverage decreased (-0.6%) to 66.911% when pulling 12c8a7d3607be32f25bfce97a184fcb3972f9763 on AddCORSHeaderConfigurationToServer into b80b7be3df695e11e96f22345a71109948655034 on master.

@timo0 can you check this? I do not have time for a second review.

Coverage decreased (-0.5%) to 67.039% when pulling 1bb17e3814eb4deb40b751080c12efd7079e50fb on AddCORSHeaderConfigurationToServer into b80b7be3df695e11e96f22345a71109948655034 on master.

Coverage decreased (-0.5%) to 67.039% when pulling e516b8a146250fd3ede0a377aa1b78a7667264fb on AddCORSHeaderConfigurationToServer into b80b7be3df695e11e96f22345a71109948655034 on master.

Coverage decreased (-0.4%) to 66.992% when pulling cb81dd2f28f2db686b65e41f77ced4c777ea4a24 on AddCORSHeaderConfigurationToServer into fe88baaa2b458b0eac569cdb261813aa279ef690 on master.


New Scenario Spanish  El Culto de Cthulhu

Description of Problem or Question
Uploaded new scenario. El Culto de Cthlhu
Language Spanish
https://github.com/newusergettingnuts/ElCultodeCthlhu
Valkyrie Version
Attach Save, Quest or Scenario
Log File:
%LOCALAPPDATA%Low\NA\Valkyrie\output_log.txt
Saves:
%appdata%/Valkyrie/MoM/Save
%appdata%/Valkyrie/D2E/Save
Quest:
%appdata%/Valkyrie/D2E/Editor
Scenario:
%appdata%/Valkyrie/MoM/Editor

Hi. I don't speak Spanish so I've just checked the scenario generally.

I'm wondering why there is only one monster/there is any monster at all if there is only one? It'd be good to either put more of them there or none to be consistent, IMO.
Important Change the number of numbers displayed in the final riddle, otherwise, if a random number will be 9, the riddle will be unsolvable as it's impossible to click it:
. The general issue has been mentioned here.

hi, chris thanks.
1-there are many more than one monster.
2-i started the issue you mention and the scenario works fine as it is.
please if possible deleate your previous post, it spoils an important part for players.
Comments in private if possible.

Ok, I deleted the post although I don't think I spoiled anything.
I'm not sure to write comments in private so I'll send you a private mail on GitHub.

I've added the scenario to the manifest, once its updated I'll close this issue.
I am a bit behind on the stats spreadsheet, I'll add the two new scenarios to it when I get some spare time.

I've added the scenario to the manifest, once its updated I'll close this issue.
I am a bit behind on the stats spreadsheet, I'll add the two new scenarios to it when I get some spare time.

thanks scrubbles dont worry once someone plays this one i will check the rawdata and add it to the spreadsheet as i did with Massachussetts.

I have another to add anyway, so will do it I'f I get there before you :D
Its showing in the scenarios list now, closing case

Version 2.0 uploaded (many thanks to all the comments received)


⚠ Jenkins Plugins Artifactory has degraded performance

In 3029da2, Jenkins Plugins Artifactory (https://get.jenkins.io/plugins/artifactory/) experienced degraded performance:

HTTP code: 200
Response time: 1331 ms

Resolved: Jenkins Plugins Artifactory performance has improved in acaf925 after 12 minutes.


Update customer-key-overview.md

@JohanFreelancer9 - kindly do the copy editor review for this PR. Thanks

@sathana87 Please explain the reason of creating this PR. Thanks

@sathana87 Gentle reminder

@sathana87 No reply. Closing it.


Add UI to undo + redo buttons

Needs ctrl+z and ctrl+y support

Added ctrl + z and ctrl + y support


Inaccurate Offset Calculation for a Decoded Transaction witnesses

There appears to be an inconsistency in decoding the Transaction witnesses data.
The witnesses data is the last part of an encoded transaction. Because of this, an accurate offset calculation can be done through the following simple expression:
const witnessesLength = transaction.witnesses.reduce((total, w) => total + w.dataLength + 8, 0)

const witnessesOffset = transactionBytesLength - witnessesLength

However, while debugging fuel-core locally and running tests with many different transactions, I've noticed that the offset calculation is not always accurate. While the calculation is correct in some instances, there are discrepancies ranging from 4 to 20 in others. Could this be an indication that something is off when decoding the transaction witnesses?
Steps to Reproduce

Run fuel-core locally in debug mode.
Within fuel-core external libraries look for the fuel-vm file: fuel-tx/src/transaction/fee.rs
Add breakpoints on function checked_from_values and watch the value of metered_bytes variable.
Submit different types of transactions: simple transfers, contract deployments, coin mintings, contract calls, and multi-contract calls.

I tried calculating the witnessesOffset value in the way you presented above inside of calculateTxChargeableBytes and all the packages/fuel-gauge/src/fee.test.ts tests passed. Does that mean that this is not an issue anymore or are the fee.test.ts tests not testing all possible scenarios?

@nedsalk Not sure what you mean by tests not testing all possible scenarios. I have added tests for all sorts of transactions.
The packages/fuel-gauge/src/fee.test.ts tests are meant to validate that the fee is being properly handled. Which has nothing to do with this corner case.
The error above does not happen on every execution. I couldn't determine why.

Not sure what you mean by tests not testing all possible scenarios. I have added tests for all sorts of transactions.
The packages/fuel-gauge/src/fee.test.ts tests are meant to validate that the fee is being properly handled. Which has nothing to do with this corner case.

Sorry, the second reproduction step you mentioned (2. Within fuel-core external libraries look for the fuel-vm file: fuel-tx/src/transaction/fee.rs) and me stumbling upon this issue while investigating #1428 swayed me into thinking that the fee.test.ts covers this as well :sweat_smile:.

The error above does not happen on every execution and not with every type of transaction. I couldn't determine why.
I will investigate and one corner case example here

Great! It would be best if you could open a PR and add it to master as a skipped test and reference this issue in the test, just so that we have something to work with.


[ST] routers on Mode are not bidding

Describe the bug
It seems none of routers on Mode are bidding for this transaction: https://connextscan.io/tx/0xf8912996ca08c676f2217e82d3ccac3a7055c1a16620b160e46d1b2fd8bf24ad
Link to ticket in discord
https://discord.com/channels/454734546869551114/1234951068681638010
@oncall

this router is bidding https://connextscan.io/router/0x6fd84ba95525c4ccd218f2f16f646a08b4b0a598
not sure why it was slow though

queueing up to check

Was it sufficient to ask Bware Labs to restart the router? 1:38 is not too long. @alexwhte how to check it?


Remove MakeTicker

This change is

For reference, this is what I am reading re modules: https://posener.github.io/branch-strategy/

Sure!
It is not my intention to make things difficult for anybody.  As far as I know, ndt7 is the only user of MakeTicker, and I have fixed it to use NewTicker, so I figured it would be fine to not worry about sem ver for this change.

Abandoning for now


Failed to unwrap RSS feed

Describe the bug
Hi!
Sadly I'm not able to add one of my podcasts. I can't post the URL of RSS here because it's behind the paywall. If you write down your email or something other than mastodon I can send the URL to you.
backtrace=full :
2023-08-31T17:18:50 ℹ - Actix runtime found; starting in Actix runtime
thread 'actix-rt|system:0|arbiter:2' panicked at 'called `Result::unwrap()` on an `Err` value: Eof', src/controllers/podcast_controller.rs:306:47
stack backtrace:
  stack backtrace:
   0:     0x7f690ea22253 - <unknown>
   1:     0x7f690e26dbdf - <unknown>
   2:     0x7f690ea1e917 - <unknown>
   3:     0x7f690ea22025 - <unknown>
   4:     0x7f690ea238a0 - <unknown>
   5:     0x7f690ea23664 - <unknown>
   6:     0x7f690ea23d89 - <unknown>
   7:     0x7f690ea23c94 - <unknown>
   7:     0x7f690ea23c94 - <unknown>
   8:     0x7f690ea22896 - <unknown>
   9:     0x7f690ea23a32 - <unknown>
  10:     0x7f690e123983 - <unknown>
  11:     0x7f690e123e23 - <unknown>
  12:     0x7f690e46d419 - <unknown>
  13:     0x7f690e4481ea - <unknown>
  14:     0x7f690e41cb4b - <unknown>
  15:     0x7f690e5472e8 - <unknown>
  16:     0x7f690e41c39b - <unknown>
  17:     0x7f690e41c6db - <unknown>
  18:     0x7f690e41c6db - <unknown>
  19:     0x7f690e4a60e0 - <unknown>
  20:     0x7f690e38d07f - <unknown>
  21:     0x7f690e5070a3 - <unknown>
  22:     0x7f690e515acd - <unknown>
  23:     0x7f690e777597 - <unknown>
  24:     0x7f690e4099d4 - <unknown>
  25:     0x7f690e785207 - <unknown>
  26:     0x7f690ea6a9b8 - <unknown>
  27:     0x7f690e1e8efe - <unknown>
  28:     0x7f690e1b8e08 - <unknown>
  29:     0x7f690e1e0643 - <unknown>
  30:     0x7f690e1d3748 - <unknown>
  31:     0x7f690e1b924d - <unknown>
  32:     0x7f690e1cae9f - <unknown>
  33:     0x7f690e1e0c63 - <unknown>
  34:     0x7f690e1c0d53 - <unknown>
  35:     0x7f690e1c70fc - <unknown>
  36:     0x7f690ea277f5 - <unknown>

Reproduction
With RSS URL
System Info
Latest docker image, sqlite database

Used Package Manager
n/a
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guide.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
[X] The provided reproduction is a minimal reproducible of the bug.

Thanks for the issue. Seems like the rss feed causes an issue while being parsed. Could you please send the rss feed to<EMAIL_ADDRESS>I'd be glad to take a look at it.

Thanks got the link. 👍


Why is vue-html-loader not set by default?

Hi,
I have spent some time to figurate out I need the `vue-html-loader' to import well html files with vue template code. Otherwise the syntax as '@click' for example would give some troubles. But I don't see the loader is set by default for html files and wondering if there is any reason?
I'm sure many other users would also split their templates into partials and would get into this difficult to debug issue. I could send a PR if clarified. Thanks.

Hmm, I just personally never had the need to import html snippets when using Vue. But it doesn't hurt to have it pre-configured.

Thanks :)


[docs] RTL best practices and naming/structure conventions

During the review process for https://github.com/openedx/paragon/pull/2611, a few comments were left about undocumented best practices.
RTL Best Practices

Use userEvent instead of fireEvent whenever possible (comment)

generally preferable since it simulates more of the true user interactions in the browser
https://blog.mimacom.com/react-testing-library-fireevent-vs-userevent/

Avoid relying on class names in tests (comment)

if we don't rely on class names tests won't break if/when they change

Naming conventions

Use kebab-case for test ids (comment)

Structure

Put common test imports in setupTests.js (comment)

DRY is good

It'd be nice to have these (and any other good patterns) documented somewhere (ideally with links to good real-world examples from throughout the codebase).
I'm not sure where the best place for this documentation to live would be. It doesn't quite feel like it fits with the rest of what is in the decisions directory, and it's not exactly Paragon specific.

In order to consolidate discussion around best practices in a non-paragon-specific location, I've created https://github.com/openedx/docs.openedx.org/issues/380 and I will be closing this issue.


Paths in the build.zig.zon may need updating?

Hi @Not-Nik, thank you for maintaining this library! I'm really looking forward to trying it out.
I've just managed to get the README.md example working using a build.zig.zon dependency (also as per the README) to import raylib zig. This works with both zig 0.13.0-dev.46+3648d7df1 and 0.12, based on your 0.12 branch, but I found that I needed to tweak your build.zig.zon to get builds to work. I chose to do this entirely based off of a hunch from searching for the precise error message I got. My error looked like this:
❯ zig build run
thread 948616 panic: unable to find module 'raylib'
/[...]/installs/zig/master/lib/std/Build.zig:1820:18: 0x10c0b44d0 in module (build)
            panic("unable to find module '{s}'", .{name});
                 ^
/[...]/build.zig:26:37: 0x10c0758bc in build (build)
    const raylib = raylib_dep.module("raylib"); // main raylib module

Searching for that error led me to ziglang/zig#18282, which points to a similar downstream issue fixed here sam701/zig-cli#29. I tried the same thing, and found I needed to add build.zig, build.zig.zon and emcc.zig (as it is used in build.zig) in order to get it to work. Is this something you would want to do? I'm completely new to the Zig package management ecosystem, and have barely used zig itself beyond some toy code for AoC 2 years ago, so my apologies if I've missed something totally obvious.

Yes, perfect! I was having this exact issue while working on #81. Thank you so much for this fix!


net452-api-signed not signed

Hi,
There's a problem with the net452-api-signed version, the assembly is not signed  ;)

:)


Can not build :

Script 'D:\app2\src-cordova\platforms\android\cordova-plugin-qrscanner-nbs\app-qrscanner.gradle' line: 6

What went wrong:
A problem occurred evaluating script.

Could not find method compile() for arguments [com.journeyapps:zxing-android-embedded:4.3.0] on object of type org.gradle.api.internal.artifacts.dsl.dependencies.DefaultDependencyHandler.

app.qrscanner.gradle:
repositories {
jcenter()
}
dependencies {
compile 'com.journeyapps:zxing-android-embedded:4.3.0'
compile 'com.android.support:appcompat-v7:23.1.0'
}
android {
buildToolsVersion '23.0.2' // Older versions may give compile errors
}
i've change com.journeyapps:zxing-android-embedded:4.3.0 from 3.3.0

Hi! You can use my fork of this plugin, where this issue is fixed. Additionally plugin is scanning also barcodes, not only QR codes.
https://www.npmjs.com/package/cordova-plugin-barcode-qrscanner


Successfully get a test neural network working

This will not be related to regex4dummies. It is just a test to be able to create a neural network.

After considerable thought, it has been decided that this is not going to be needed in the near future. In addition, if neural networks are needed, individual issues can be opened regarding each separate network.


similar tool of docker-cleanup

What is the problem you're trying to solve
A clear and concise description of what the problem is.
Describe the solution you'd like
A clear and concise description of what you'd like to happen.
When using docker containers, we have a tool to cleanup docker containers running as daemonset on every node: https://hub.docker.com/r/meltwater/docker-cleanup/, do we have a similar tool for cleaning up containerd containers? thanks.
Additional context
Add any other context about the feature request here.

containerd already has garbage collection built-in but I'm not sure it is a perfect analog to some of the features I quickly read over in the overview of the "docker-cleanup" tool image linked in your report.
Obviously client tools (ctr and crictl) have the capability to perform similar operations against containerd (delete images, containers, etc.), but it would be up to the community to create an exact analog to the tool you point out that is available for Docker.

containerd already has garbage collection built-in but I'm not sure it is a perfect analog to some of the features I quickly read over in the overview of the "docker-cleanup" tool image linked in your report.
Obviously client tools (ctr and crictl) have the capability to perform similar operations against containerd (delete images, containers, etc.), but it would be up to the community to create an exact analog to the tool you point out that is available for Docker.


Taint design options

Should have an options struct that controls taint propagation dials, as well as IR-level design issues. For example:

Should PC be explicitly tainted, i.e. on blx r0. The taint prop would be simulated by mov pc, r0
Should eflags be explicitly tainted, i.e. on eor r0, r0, r1, where r0 is tainted.

Some canonical policies from the literature:

[ ] Copy Propagation
[ ] Arithmetic Propagation
[ ] Address Propagation

It's not feasible to implement Control Propagation using only dynamic analysis, so we punt on this.


Don't sort oversized stacks

[Previous title] Over stack sorting problem (TooManyItem, SMP /give, ... )
A stack that have more item than the max stack size in it will be split if non locked when sorting.
Possible solution:

Don't check the max stack size
Make an option to don't check

In SP it can work, but probability that work in SMP is smaller, so other possibility:
3. An option to automatic lock a OverStacked stack in her place.
[EDIT] Chosen solution
Don't touch oversized stacks at all, to avoid sorting issues (especially in SMP)

That effect potion stack to (Use TMI) but it's quite strange, somme are cut other not, and the result stack are ramdom sized

Yes I it's why I thinking about a 'Lock overstacked' options, that will not moving stack, and the player can move it correctly.
And so it's scary me in SMP, sorting a chest will eject stack of 64 none stackable items, and its boring to fire all...

Yeah I guess I'll make sure not to touch any oversized stack then. Thanks for your advice.

Still getting max-stack-size related reports, I should investigate a bit more.


Sign in - Cursor does not remain in place after wrong password is entered

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Navigate to New Expensify
Enter a existing user email
In Password box enter an incorrect password.
Press enter

Edit: Please, consider the same steps and expected result for Two factor authentication fields too. These two flows are tightly connected and the solution will be basically same so it does not make much sense to create another issue.
Expected Result:
Cursor should stay in password box so user can correct the mistake without the need to lift the hands off the keyboard.
Actual Result:
Cursor no longer remains in password box, user must manually click into password box to try again.
Workaround:
Manually click into password box
Platform:

Where is this issue occurring?

Web
Desktop App

Version Number: 1.0.96-0
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://user-images.githubusercontent.com/44479856/132888502-9ce976ec-ab97-434e-94ef-d908b398433c.mp4
Expensify/Expensify Issue URL:
Issue reported by: @kidroca (Thanks for the video! 🙇♀)
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1631205732121400
View all open jobs on GitHub

Triggered auto assignment to @alex-mechler (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

Looks like a good external issue. cc @kidroca if you wanted to submit a proposal for this

Triggered auto assignment to @stephanieelliott (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

Proposed Solution
We have to set password input field reference. Thereafter we can set focus to password input field if empty or invalid password.
Below code should be added/updated within src/pages/signin/PasswordForm.js

  constructor(props) {
      super(props);
     ....
      this.passwordInputRef = null;      //  *** Added this line
  }

  // *** Added componentDidUpdate to focus password input field if invalid password error
  componentDidUpdate(prevProps) {
      if (this.props.account.error !== prevProps.account.error
          && this.props.account.error === this.props.translate('passwordForm.error.incorrectLoginOrPassword')) {
          this.passwordInputRef.focus();
      }
  }

  validateAndSubmitForm() {
    if (!this.state.password.trim() && this.props.account.requiresTwoFactorAuth && !this.state.twoFactorAuthCode.trim()) {
        this.setState({formError: 'passwordForm.pleaseFillOutAllFields'});
        this.passwordInputRef.focus();  //  *** Added this line
        return;
    }

    if (!this.state.password.trim()) {
        this.setState({formError: 'passwordForm.pleaseFillPassword'});
        this.passwordInputRef.focus();     //  *** Added this line
        return;
    }
  }

  <ExpensiTextInput
     ....
     value={this.state.password}
     ....
      ref={el => this.passwordInputRef = el}    // ** added this line
  />

Other Suggestion  I can see twoFactorAuthCode related input field also there in this form. It will be used  if 2fa requited for the account. But In this issue 2fa input related things not mentioned, So in my proposal focus to 2fa input field related solution not included.
If set focus to 2fa input fields also taken care in this issue then kindly inform me, I will consider in this proposal.
If 2fa input fields focus needs to taken care via separate issue then I will suggest @isagoico to create another issue for 2fa input focus and kindly mention me as bug suggested by. I will also provide solution if issue assigned to me immediately, I have solution ready for it.
Thank you.

I think we should find out why the field looses focus in the first place, and address that - it might be easier to keep focus from leaving the field instead of programatically triggering focus on different occasions

Triggered auto assignment to @mountiny (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

Posted to Upwork: https://www.upwork.com/jobs/~01d33acc9f122f85b8
@mountiny we've got a few proposals already, see above comments!

Hello, it is Sasha from Upwork.
I could solve your problem.

Proposal
The recommended way of solving this would be to addblurOnSubmit to the field.
<ExpensiTextInput
                        label={this.props.translate('common.password')}
                        secureTextEntry
                        autoCompleteType="password"
                        textContentType="password"
                        value={this.state.password}
                        onChangeText={text => this.setState({password: text})}
                        onSubmitEditing={this.validateAndSubmitForm}
                        autoFocus
                        translateX={-18}
                        **blurOnSubmit={false}**
                    />

Working Example:
https://user-images.githubusercontent.com/3069065/133133999-286a91e1-e976-49d2-b715-f2bda967966c.mov

IMO what @mananjadhav proposed looks good if it doesn't affect how ios and Android work, e.g. We should not have regressions like the onscreen keyboard staying open after submit.
I don't mind having someone else propose and implement a solution

IMO what @mananjadhav proposed looks good if it doesn't affect how ios and Android work, e.g. We should not have regressions like the onscreen keyboard staying open after submit.

Well, it does, but if we don't want this behavior,  all we need to do is TextInputFocusable/index.os.js and TextInputFocusable/index.android.js we don't pass the prop.
For example:
// Selection Property not worked in IOS properly, So removed from props.
        const {selection, blurOnSubmit, ...newProps} = this.props;
        return (
            <TextInput
                placeholderTextColor={themeColors.placeholderText}
                ref={el => this.textInput = el}
                maxHeight={CONST.COMPOSER_MAX_HEIGHT}
                rejectResponderTermination={false}
                editable={!this.props.isDisabled}
                /* eslint-disable-next-line react/jsx-props-no-spreading */
                {...newProps}
            />
        );

I tested with  blurOnSubmit={false} within Google chrome, Safari. It is not working as expected i.e. Focus not remain in text input after submit. Tested within Expensify version 1.0.97-0
Google chrome (v93.0.4577.82)
https://user-images.githubusercontent.com/7823358/133194730-e4bdb30d-d25a-42f6-b42a-6cc8ba8a7afb.mov
Google chrome (v93.0.4577.82) Incognito
https://user-images.githubusercontent.com/7823358/133194792-7f32abae-187f-457b-96f0-10866a1b3075.mov
Safari  v14.1.1.
https://user-images.githubusercontent.com/7823358/133194859-6f375467-3580-4af8-9dbb-05ab6b3b8952.mov

Hello all,
I know it could be resolved by setting an initial state of password input
and resetting it once the password was wrong.
On Mon, Sep 13, 2021 at 9:30 PM PrashantKumar Mangukiya <
@.***> wrote:

I tested with blurOnSubmit={false} within Google chrome, Safari. It is not
working as expected i.e. Focus not remain in text input after submit.
Tested within Expensify version 1.0.97-0
Google chrome (v93.0.4577.82)
https://user-images.githubusercontent.com/7823358/133194730-e4bdb30d-d25a-42f6-b42a-6cc8ba8a7afb.mov
Google chrome (v93.0.4577.82) Incognito
https://user-images.githubusercontent.com/7823358/133194792-7f32abae-187f-457b-96f0-10866a1b3075.mov
Safari v14.1.1.
https://user-images.githubusercontent.com/7823358/133194859-6f375467-3580-4af8-9dbb-05ab6b3b8952.mov
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/Expensify/App/issues/5191#issuecomment-918791754, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AUWEV7BY3YSGS4SFRZV35JDUB3FVTANCNFSM5DZWNCLA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Thank you for your proposals! It would nice to figure out why this is happening at first place (as @kidroca mentioned), so we can dig in a bit more since this is not really a blocker but it is rather nice-to-have.
@mananjadhav Could you please double check what @PrashantMangukiya raised about your proposal? Also additionally if you could add screen recording of iOS and Android implementation of your proposal since you wrote you could prevent the keyboard showing up. Thank you! 🙇
If the blurOnSubmit proposal proves to introduce regressions on iOS/Android, the proposal from @PrashantMangukiya is also quite nice. However, we should first make sure there is not more elegant solution available.
Feel free to add some new proposals if you can think of anything useful 🚀

@mountiny It seems @PrashantMangukiya's findings are correct blurOnSubmit doesn't seem to work well.
Here's my updated Proposal:
In PasswordForm, we import:
import withWindowDimensions, {windowDimensionsPropTypes} from '../../components/withWindowDimensions';

and then in validateAndSubmitForm we just focus the field again with the following block:
validateAndSubmitForm() {
        if (!this.props.isSmallScreenWidth) {
            this.passwordInputRef.focus();
        }
        ...
        ...
        ...
}

and finally, add a reference to the field.
<ExpensiTextInput
     label={this.props.translate('common.password')}
     ref={el => this.passwordInputRef = el}
     ...
     ...
     ...
/>

@mananjadhav Thank you for updating the proposal. I would say I prefer this approach a bit more than @PrashantMangukiya's proposal. It is a bit more clearer and straightforward without a compromise (as far as what we can see now).
I realize the 2FA field has not been mentioned in the original issue report, however, I would say it makes sense to make these changes together as it will be basically same code (and it is tightly couple with the password flow). Would you please be able to update the proposal so the same expected for password field applies for 2FA field too?
Let me know what you think about that and I think after that update your proposal should be good to go ahead 🎉

What I understood is that if password is wrong then we need to focus password input field so I suggested my solution that way.
But if we focus password input during validateAndSubmitForm() then It will always focus password field at form submit irrespective of password right or wrong result received after api call. I am sharing my thoughts on this.

@PrashantMangukiya Thank you for bringing that up. I have overlooked this. I have revisited your both proposals and that point (of then to call focus in validateAndSubmitForm) is the main place they differ. Would you be interested to update your proposal to take care of 2FA field as well since that should be fairly similar. Thank you very much! 🙇
In the meantime, @mananjadhav if you can think of a way how to fix your proposal which would be better than Prashant's one, please, feel free to add it here (also 2FA included)

@PrashantMangukiya @mananjadhav
The blurOnSubmit={false} is proved incorrectly - you're using the mouse to click outside the field - it's expected it'll lose focus. Clicking transfers focus to whatever you click on
blurOnSubmit is specifically for pressing Enter key (or Return) on the Keyboard
The solution where you always focus the field during validateAndSubmitForm could work, but there are cases where it might pop out the on screen keyboard for no reason.
validateAndSubmitForm is triggered by the pressing the "Sign In" button, but in the video you shared the field is not getting focused when you do that, can you explain why? From the proposed code it looks like focus would be called and this would bring the keyboard up
One thing is still not clear - would the native iOS or Android experience be affected

with blurOnSubmit={false} the on-screen keyboard would probably stay open
with re-focusing the on-screen keyboard can close and then re-open even when there are no errors

@mountiny I updated my proposal that includes 2fa.

Thank @kidroca for the write up!
@PrashantMangukiya Thank you very much for updating the proposal. As there are valid concerns if this change will not introduced some unexpected behaviour on iOS/Android.

with re-focusing the on-screen keyboard can close and then re-open even when there are no errors

Could you please check how you solution handles on native iOS and Android:

log in successfully
using wrong password
using correct password and wrong 2FA
using wrong password and correct 2FA

Can you confirm (ideally with screen recordings), that there is no weird keyboard flickering, closing/reopening?
This is all to just avoid any regressions down the line, better to test it now than later. If these tests will be successful and the aforementioned concerns will be proved wrong, we can move forward with your proposal!

@mountiny, thanks for the message.
Sure I will test for a given use case for iOS and Android and share screen recording. I hope it work as expected in iOS Android also. As this issue mentioned for web and desktop so not tested that way. At present it was late night so I will test and submit during my day time. Thank you.

@PrashantMangukiya Thank you very much. That is absolutely understandable.
The issue mentions Web and Desktop, but we need to make sure we do not introduce some other problems in native iOS/Android while fixing Web.

@mountiny
Handling each error individually and focusing is fragile logic, especially since error messages are localised and the error text can change
Why treat each error individually? Each new error case would mean another if (that error) focus()
The blurOnSubmit={false} is valid and works
The only problem with it is the on-screen keyboard would remain expanded, which is probably fine, but if it's not we could add something like blurOnSubmit={canUseTouchscreen()} so that the behaviour does not affect mobile

@kidroca Sorry for not following your previous message correctly. This was my mistake.

Why treat each error individually?

I agree this is not the most ideal solution and the problem you mentioned can occur, although in this case I would not expect other error cases to be added.

The only problem with it is the on-screen keyboard would remain expanded

I have misread/misunderstood your previous message and thought the blurOnSubmit would not be ideal. Apologies for that. However, I am not sure if I totally follow you here too.
Would this solve the original problem on Web and Desktop if clicking on the Sign in button? 👀 As far as what I understood, this will fix it for Enter being pressed, but it will not work when we will press the button as mentioned above.
If that could be resolved too, it would definitely be better solution. Otherwise, it solves just half of the problem. cc @PrashantMangukiya for visibility (let's see if the blurOnSubmit approach can be made to work for everything before you start testing the use cases for your original proposal, thank you 🙏 )

Existing behaviour iOS
https://user-images.githubusercontent.com/12156624/133348672-8f5ea444-5b9c-4bbc-9ed4-8545d4333f43.mov

The keyboard would always collapse when you press the "return" button. Even when there are errors
The keyboard would never collapse when you press the "Sign In" button.

Behaviour when blurOnSubmit={false} is added
https://user-images.githubusercontent.com/12156624/133348545-6e7165ba-8a1a-44b9-a54e-e302e313654a.mov

The keyboard would never collapse when you press the "Sign In" button.
The keyboard would never collapse when you press the "return" button.
You can still dismiss the keyboard if you tap outside the input

As a summary blurOnSubmit={false} keeps focus inside the field, which allows us to continue typing in case of an error
On native, since focus remains inside the field the on-screen keyboard is not dismissed. This seems fine as the keyboard is not dismissed if you press the "Sign In" button

We have other fields with the same issue - for example during the fist stage of login, if you enter an invalid email address (like email#hotmail.com or enter no email) and press "return" the input loses focus an you have to target it again
we can apply blurOnSubmit={false} quite easily to any field (or set it as default), while changing each form with focus() handlers would be ...

@mountiny

Would this solve the original problem on Web and Desktop if clicking on the Sign in button? 👀 As far as what I understood, this will fix it for Enter being pressed, but it will not work when we will press the button as mentioned above (I know the video in the issue uses Enter, but we should definitely make the click on Sign in button behave the same way)

We only care for the keyboard handling and the typing experience

Cursor should stay in password box so user can correct the mistake without the need to lift the hands off the keyboard.

If the user is pointing and clicking on the "Sign In" button they already have one of their hands alway from the keyboard

@kidroca

We only care for the keyboard handling and the typing experience (blurOnSubmit={false} solves that)

I agree that this is the more important part of the issue as you noted, user still has their hands on the keyboard.
Let's then go with that one for simplicity. It is true the issue does not state explicitly we are treating the case of clicking the Sign up button too so we can probably omit it for now and treat it in future if issue s created.
@mananjadhav As the one who had proposed this solution first, are you still interested in implementing it. Thank to @kidroca for being persistent. Apologies for my lack of focus here.
@PrashantMangukiya Please, excuse me for being all over the place and now changing to a different proposal. The discussion showed that it will be sufficient to use the blurOnSubmit={false} for this issue.

@mountiny Sure. I'll submit a PR in sometime.

Hi @mananjadhav, I've placed this issue on hold as per this update, as we are prioritising issues related to a feature release scheduled for 9/24. As an apology for the delay, we will add a $100 bonus as a thank you for waiting.

Adding Reviewing label, the PR has been reviewed and is ready to be merged once we are out with N6

Thanks @mountiny

Please refer to this post for updated information on the n6 hold, we've raised the bonus to $250 for all issues where a PR is created before the N6 hold is lifted.

This issue has not been updated in over 15 days. @mananjadhav, @stephanieelliott, @mountiny eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

Weekly, waiting for the n6-hold to be lifted.

N6 hold is lifted, payment for this job will include a $250 bonus. PR is currently undergoing QA

This was deployed to prod yesterday, starting 7-day regression period. Note to include $250 bonus with job payment.

Created an issue to investigate/fix why the deploy comment has not been added here. https://github.com/Expensify/Expensify/issues/183206

All paid up!

Hey @stephanieelliott according to the docs I should be getting a bonus for reporting the issue
https://github.com/Expensify/App/blob/main/CONTRIBUTING.md#proposing-a-job-that-expensify-hasnt-posted

After review in #expensify-open-source, if we choose to implement your proposal, a GitHub issue will be created and your Slack handle will be included in the original post after Issue reported by:
If an external contributor other than yourself is hired to work on the issue, you will also be hired for the same job in Upwork. No additional work is needed. If the issue is fixed internally, a dedicated job will be created to hire and pay you after the issue is fixed.

Ah, that info is usually included in the issue title. thanks @kidroca!
I created a new job posting in Upwork to pay you out for reporting. Here it is: https://www.upwork.com/jobs/~014c5a6b4de03beeba

Thank you, I've applied on Upwork.
I think this is the first issue I've reported and the guidelines weren't fully defined back then


Fixing various doc build issues

What is the change?
Fix numerous doc errors, one per commit.

Why is the change being made?
Because they were bugs and caused doc build errors.

Checklist

[x] This PR has only one purpose or idea.
[x] Tests have been added/updated to verify any new/changed code.

[x] The code style follows good practices.
[x] The commit message(s) follow good practices.

[x] The release notes have been updated if necessary.
[x] The documentation is still up-to-date in the doc folder.
[x] The dependencies are still up-to-date in pyproject.toml.

Can I add one more commit to this?

Sure!

ok ready!


cmd/oci-image-tool/validate.go: create a logger if none exists.

This was causing panics when validating an image with no refs, hitting this line of code, causing a panic on out being nil: https://github.com/opencontainers/image-tools/blob/master/image/image.go#L60
Thanks!

LGTM

It seems duplicate to #46

@xiekeyang this is not nearly as extensive as #46, only fixing a panic. :smile:

LGTM

LGTM


Update version to 1.0.88-0 on staging

Update version to 1.0.88-0

🚀 Deployed to production by @roryabraham in version: 1.0.88-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅


WDL DAG seems to have some issues

Doesn't show for https://staging.dockstore.org/workflows/github.com/vrockai/dockstore-whalesay:master even though it is valid.

I can recreate this in staging using the same descriptor file. However this seems to be fixed in a newer version of develop. @garyluu @denis-yuen Have either of you changed the WDL parsing code in the last few days?

not by me

@agduncan94
Not to my knowledge.
To be clear, are you running develop via IDE or via a compiled jar?

I'm using an IDE

Can confirm the error doesn't occur when running from IDE, but does from the jar.

Weird I didn't close this issue.

Oops

https://help.github.com/articles/closing-issues-using-keywords/

That explains it.

This particular workflow seems better now on staging


Cycling through match errors

Instead of only allowing to jump to the first location found by the given errorMatch regular expression, you can cycle through every error with build:error-match. At the end it loops around to the beginning.
build:error-match-first (cmd-alt-h) jumps directly back to the beginning.

This looks great. Would you mind adding some tests to this?

I hope these tests are fine, it's the first time creating some for me. It tests cycling and wrap around and jumping to the first error match.
I don't know why travis failed. In my own repo the build and test are without error.

I just re-started the build. Seems as there was an outage in the travis service.

Thanks you very much for this contribution. It will make an excellent addition to atom-build!
It will be included in the next version (v0.29.0).


Add graph-cli spec migration for new POI hash

Add a migration to graph-cli to use the new POI hash by default.
https://github.com/graphprotocol/graph-node/issues/3220

Now that 0.28.2 is live on the network, we can add an automigration so all subgraph developers benefit from the new, faster POI


wip: Highlights results

Hello!
I'm opening this PR to introduce the idea and get your opinion on this!
~I started with the idea of highlighting the output for fzf (which I currently use), while at that, I saw that is possible to use the same strategy to highlight TUI output too. Though I'm not sure if I should keep both on the same PR.~
~What it is somewhat working right now:
atuin search --fzf-mode QUERY | fzf --ansi
--fzf-mode invert the order of the output (fzf style : the first line is the most relevant) and highlight the result's~

~The current tui atuin search -i~

Update : I'm working on this again with the goal to only highlight on both tui and --cmd-only

Coloring the interactive search TUI was requested in #503 as well. I think that is definitely a worthwhile change.
On the --fzf-mode change, it should probably be split into a separate PR unless the implementations are very interdependent.

This would be quite nice to have, skim has such highlights too.

Any progress on this? I'm happy to pick up what's left

Any progress on this? I'm happy to pick up what's left

Apologies for the delayed response.
I'm busy lately and couldn't work on this PR. I'd be happy if someome could pick this up!

Writing a comment here as a check-in for where the branch currently is at, and what needs to be done.
Currently there is some partial highlighting:
(main on the bottom, branch on the top)

But it doesn't look like there's fuzzy highlighting:

So getting highlighting working for multiple spans of a command will be my first goal I think. I'll leave updates as I find other things to be done for this to be merged.

Hey! I'm going to close this one as it's pretty inactive. Happy to reopen should that change 🙏


Multiple Queries for same statement

Environment:

Laravel Version: 5.5.28
PHP Version: /
Database Driver & Version: mysql

Description:
Also within the same controller and same request (only one page called) the same DB/SQL Statement is fired multiple times. Shouldn't be there a kind of caching? Not necessarily across multiple page calls but within one instance of an model.

Steps To Reproduce:

Create a Eloquent Model on a MySQL Database.
Build a controller which calls this model and run multiple times the ::find(1) method.
You will that the DB Query is fired multiple times also in the same page request.

Question:
When Laravel has this caching not as default, there are packages out which do model caching, but how to influence vendors model? How can I overwrite the default Laravel Model class Illuminate\Database\Eloquent\Model?

This repo is for bug tracking. Use the forums or slack channel for solving your issue

No, there is no such caching in Eloquent. The Eloquent models are just wrappers against database access. How can you be sure that querying twice will return identical data? What if you've written something to the database between two calls to ::find()?

Please ask on the forums, this repo is for bug reporting only. You can use https://laracasts.com/discuss or https://laravel.io/forum which are forums with a very large community of developers helping each other.


Change confusing function name

Maybe _is_not_finished is more proper name for cond function because tf.while_loop keeps running while cond is True.

@googlebot I signed it!

You're right, this is much better! Thank you!


Removing presenter that got added by mistake to fix version 0.41.0

coverage: 84.165% (+0.2%) from 83.945%
when pulling 5d8f77aab908b6773fc02ec2ee173ae84745cbce on remove-presenter
into 6bfe1a6666e38d74efdd6d33fbae841557c038ef on main.


Failed to create/publish coverage File.

Description
Running vstest command via TFS vnext task with EnableCodeCoverage parameter will create a corrupted coverage file , i.e. 1K, corrupted file.
Can not open it with VS 2017.
Steps to reproduce
Visual Studio Test task - vstest task on TFS
Expected behavior
Publish cover results in my build info.
Actual behavior
1K file  , corrupted file.
Environment
When exactly same CLI command wad done from a cmd command session on the Agent machine , the command creates coverage file.
When running using CodeCoverage.exe, I got cover results  successfully, The issue is that I can not publish results in my TFS build info.
Thanks,

Hi,

Are you on TFS On-Prem or VSTS? If On-Prem, which version?
Can you please enable debug logs in your definition by setting system.debug variable to true and send us the logs? You may choose to mail them to<EMAIL_ADDRESS>as well.

Hi,
Thanks for the response.

TFS 2018 RC1 on-Prem
I enabled , Can you please instruct me what entries should I check , I have organization restriction in order to send my logs
I have in my logs the following error :" unable to publish telemetry due to lower agent version"
Note : No issues publishing the UT results.

Thanks In Advanced,
Thanks In Advanced,

You ran the vstest.console.exe CLI from the same build agent machine where the task generated a corrupted file, and it generates a valid file. Can you please confirm it fails only via vstest task in tfs and not from CLI on the same machine
What was the VS version (You can find the exact version from Help->About in VS)
Since we cannot repro this at our end, we will need task logs, vstest diag logs, and the .coverage files for analysis. You can send them over by email to us, if you are not comfortable attaching them here in public forum.
Do you see the code coverage report in the build summary page
"unable to publish telemetry due to lower agent version" I believe is a warning. You can get past this by using a newer build agent, and it is not related to the code coverage issue you are seeing.

Thanks on the detailed response.

No issues when running via CLI on Agent machine.
VS 15.0.27617.1
unfortunately we have restricted procedure , I can cut part of the log in some parts if that can help.
No cover report , It seems in the log the coverage file have been created but as 1KB size only.

Thanks

Unfortunately, since we don't have an idea as to what is causing your issue, we will not be able to debug without the logs. You may choose to get in touch with us via the customer support team at https://visualstudio.microsoft.com/team-services/tfs-support/ and they will guide you further in the process.


unable to build

We internally use Alpine for our docker containers.
Regardless of this, I am unable to build using the provided ubuntu buildenv or my standard alpine environment.
All builds regardless of build platform result in the same error:
./sign_certd.go:366: certChecker.IsAuthority undefined (type ssh.CertChecker has no field or method IsAuthority)
Using go versions: 1.7.3 on ubuntu, 1.7.5/1.8.1 on OSX and 1.7.3 on Alpine
Any assistance would be appreciated.
I will get one of my internal Go developers to take a look.

This appears to have broken a few days ago due to: https://github.com/golang/crypto/commit/527d12e53572562de9fd348d50e1ee4096803cec
Nice of them to clarify it was a "breaking change." I'm working on a patch now.

Fix pushed.


Fix container image by using the same build environment as the runtime one

This is way simpler and more reliable. The problem at this point in time is that we are pulling in OpenSSL as a dependency, and this requires a build of this library with musl. Rather than rebuilding OpenSSL manually, let's just compile the project in a musl-based distro... and why not use Alpine, which we already use for running the service!
In addition, we just added a release profile to use fat LTO and a single codegen-unit.

thanks  @unleashed

Fixes #66


fix nan while training by conditionally clear input gradient tensor before launch bwd kernel

This fix SWDEV-258416, by clear the input gradient buffer before launch bwd kernel

@carlushuang  This fix will fix both gfx906 and gfx908?

@asroy Yes. As long as I use some strategy like bwd v4r1 (split filter into dot, slice, ...), we will always have some pixels of input tensor not get updated


New layout templates for FancyZones

Summary of the new feature/enhancement
I would love to see the following layouts for FancyZones

left zone 2/3 of the screen and right zone 1/3 of the screen
left zone 1/3 of the screen and right zone 2/3 of the screen
left zone 2/3 of the screen and right zone 1/3 of the screen, the right zone is spit horizontally into two zones:

I am using the layout number 3 (WQHD monitor) and it really helps me a lot organizing my windows.

Why not just create them with the custom zone editor?

As you see on my screenshot I already defined layout number 3 and am also using it.
But it would be more user friendly if some more common layouts are delivered with FancyZones.
This would increase the usability a lot.

I like the layout 1 and 2 and would love to see it in FZ.
But also 3 could be useful when you have larger screens...

Hi @OLLI-S
I changed the title to make it easier to search for this issue.
Thank you.

I want to add:

[ ] 1 half big window, other side 2 vertical windows (3 windows)
[ ] 1 half big window, other side 3 vertical windows (4 windows)
[ ] 1 half big window, other side 4 vertical windows (5 windows)
[ ] 1 central big window 1/2 vertical space, other windows around the central one, all of same size (7 windows)
[ ] 1 central big window 2/3 vertical space, other windows around the central one, right and left one of same height and bottom ones smaller (1/3 vertical space) (7 windows)
[ ] 2 central big window 1/2 vertical space, other windows around the central one, all of same size (1/3 vertical space) (8 windows) (variant of priority grid)

Tracked in https://github.com/microsoft/PowerToys/issues/6611

Templates imply the concept of variable number of zones, it looks like that the suggestion here is not for new templates, but for adding predefined custom layouts.


GH1654: Fix link to ReportUnit project site

Fixes #1654.

@ChrisMaddock thank you very much for taking the time to correct this!

No problem - thanks for the quick merge! 😄


Spears can't be put on pedestal

Spears can't be put on pedestal

It's because this is triggered with rightclick.

fixed https://github.com/MinetestForFun/server-minetestforfun/commit/36e3c44430bd64ed5215da965b59e77e44e8ca32


implemented code splitting

implemented code splitting for our website

check this out @DhairyaBahl @abhijeet007rocks8. Also to see full performance effects of code splitting, we have to make our navbar as a component so that we can load it lazyly. But since its in same app.js file, we have to do prop drilling to shift it to different component

Am making another isssue for this. Also we can make a custom preloader!


Merge in existing code from uclasm

We have an implementation of costs that computes the constrained cost for every possible constraint. This should move over here.

Also, please add tests for the code as you move it.


Error: AceEditorDirective is part of the declarations of 2 modules

ng build --prod is throwing error:

ERROR in Error: Type AceEditorDirective in /sawtooth-explorer/node_modules/ng2-ace-editor/src/directive.d.ts is part of the declarations of 2 modules: AppModule in /sawtooth-explorer/src/app/app.module.ts and AceEditorModule in /sawtooth-explorer/node_modules/ng2-ace-editor/src/module.d.ts! Please consider moving AceEditorDirective in /sawtooth-explorer/node_modules/ng2-ace-editor/src/directive.d.ts to a higher module that imports AppModule in /sawtooth-explorer/src/app/app.module.ts and AceEditorModule in /sawtooth-explorer/node_modules/ng2-ace-editor/src/module.d.ts. You can also create a new NgModule that exports and includes AceEditorDirective in /sawtooth-explorer/node_modules/ng2-ace-editor/src/directive.d.ts then import that NgModule in AppModule in /sawtooth-explorer/src/app/app.module.ts and AceEditorModule in /sawtooth-explorer/node_modules/ng2-ace-editor/src/module.d.ts.

And If I do only ng build, runs without any issues, please help me.
Here's the package.json file content:
{
  "name": "sawtooth-explorer",
  "version": "0.0.0",
  "license": "Apache 2.0",
  "scripts": {
    "ng": "ng",
    "start": "ng serve",
    "build": "ng build",
    "test": "ng test",
    "lint": "ng lint",
    "e2e": "ng e2e"
  },
  "private": true,
  "dependencies": {
    "@angular/animations": "5.0.1",
    "@angular/cdk": "5.0.0-rc.0",
    "@angular/common": "5.0.1",
    "@angular/compiler": "5.0.1",
    "@angular/core": "5.0.1",
    "@angular/forms": "5.0.1",
    "@angular/http": "5.0.1",
    "@angular/material": "5.0.0-rc.0",
    "@angular/platform-browser": "5.0.1",
    "@angular/platform-browser-dynamic": "5.0.1",
    "@angular/router": "5.0.1",
    "@types/lodash": "^4.14.85",
    "angular2-moment": "1.7.0",
    "core-js": "2.5.1",
    "crypto-js": "3.1.9-1",
    "hammerjs": "2.0.8",
    "lodash": "^4.17.4",
    "ng2-ace-editor": "^0.3.8",
    "rxjs": "5.5.2",
    "zone.js": "0.8.18"
  },
  "devDependencies": {
    "@angular/cli": "^1.5.6",
    "@angular/compiler-cli": "5.0.1",
    "@angular/language-service": "5.0.1",
    "@types/jasmine": "2.6.3",
    "@types/jasminewd2": "2.0.3",
    "@types/node": "6.0.88",
    "codelyzer": "4.0.1",
    "jasmine-core": "2.8.0",
    "jasmine-spec-reporter": "4.2.1",
    "karma": "1.7.1",
    "karma-chrome-launcher": "2.2.0",
    "karma-cli": "1.0.1",
    "karma-coverage-istanbul-reporter": "1.3.0",
    "karma-jasmine": "1.1.0",
    "karma-jasmine-html-reporter": "0.2.2",
    "karma-webdriver-launcher": "^1.0.5",
    "protractor": "5.2.0",
    "ts-node": "3.3.0",
    "tslint": "5.8.0",
    "typescript": "~2.4.2"
  }
}

Check your app modules file and feature modules file
You might have imported in two places in the flow of parent and child component


MINOR: mirror integration tests should not call System.exit

406635bcc9f2a4c439d198ea0549170de331323c switched System.exit to using Exit.exit, however the integration tests did not choose to override the exit procedure.
This can cause invalid test runs with errors like this:
[2020-08-18T15:52:01.142Z] * What went wrong:
[2020-08-18T15:52:01.142Z] Execution failed for task ':connect:mirror:integrationTest'.
[2020-08-18T15:52:01.142Z] > Process 'Gradle Test Executor 192' finished with non-zero exit value 1
[2020-08-18T15:52:01.142Z]   This problem might be caused by incorrect test process configuration.
[2020-08-18T15:52:01.142Z]   Please refer to the test execution section in the User Manual at https://docs.gradle.org/6.6/userguide/java_testing.html#sec:test_execution

ok to test

ok to test

@lbradstreet Thanks for the PR, merging to trunk.

@lbradstreet I think the changes to the MM2 tests may have been unnecessary or, at least, inadequate. Embedded Connect clusters automatically mask exit procedures on startup by default, which should apply to the MM2 integration tests.
I believe the issue with the MM2 integration tests is that embedded Connect clusters also automatically reset exit procedures on shutdown. Since the tests use two embedded Connect clusters which are shut down sequentially at the end of each test case, the second cluster to be shut down does so without using the masked exit procedures, which can result in System::exit being invoked.


Hide variant option in typography field?

Is it possible to hide the variant option in a typography field? I would like to just force which variants to load using the 'choices'=>'variant' setting and then hide the variant dropdown.
I tried leaving the 'variant' out of the 'default' settings, but it's still showing.
For example:
Kirki::add_field( 'my_config', array(
	'type'        => 'typography',
	'settings'    => 'my_field',
	'label'       => esc_html__( 'Body Font', 'my-theme' ),
	'section'     => 'my_section',
	'default'     => array(
		'font-family' 	 => 'Poppins',
	),
	'choices'  => array(
		'variant' => array(
			'regular',
			'italic',
			'700',
		),
	),
	'transport'   => 'auto',
	'output'      => array(
		array(
			'element'	=> 'body',
		),
	),
) );

I guess I could use CSS to hide the variant dropdown but I was wondering if there's another way
Thank you!

No, there is no way to hide it other than custom CSS, and the reason is simple:
Example 1:
You may assume that 400 (regular) should be applied to body, but what if I select a font that is by nature a bit thin, and for accessibility purposes I need to use the 500 variation instead?
Example 2:
On my site I want to use the "Lato" font for my headers, and my h1 headers have a size of 50px. At that size, Lato looks really cool with a font-weight of 100. What, I won't be able to do that because it's a header?
Remember, the typography control is not "what webfonts will be loaded". It is "what font will my site show". And I need to be able to select what font-weight my text will use, after all there's nothing more important that typography when it comes to my content.
^ That's why it's not possible to hide the variants selector.

That makes sense! I guess I'm trying to use the field a little different than what it was made for.
I have a typography field for every text element, this is great for complete control, however if people want to change the overall font they would have to change every single typography field.
So I wanted to create a few general font fields which would act as a "Primary" and "secondary" font. Each individual typography field for text elements would be set to inherit, so you could do a quick overall font change by changing the Primary and Secondary fonts and at the same time give the user the option to change the font of individual text elements which would overwrite the primary or secondary font settings.


Edit Zipformer Comments

A few simple edits on the comments of zipformer, which I found to have helped in my understanding of the codes.
On particular point which I'm not sure - I couldn't find zipformer_subsampling_factor anywhere in the codes, so I suspect it's wrong. However, I couldn't understand where (or why) exactly the mask values were repeated. Anyhow I suspect that it's zipformer_downsampling_factor, so that was what I edited to.

We will be slow in response during Chinese New Year.

Thanks.


Could it be used to make a 'dashboard' for controlling a sensor and show measures in real time?

Hi Miguel,
I'm struggling to find the best solution to make a web page communicate (back and forth) between my laptop and a sensor.
For example I'd like this web page to have a form to set measure parameters, a button send them to the sensor asking for a new measure and a plotly graph to show measure result (updated when the measure is actually received). MicroPython is used on the sensor Micro Controller.
Could this package be the way to go? Could you help me with a toy example? (package docs are quite brief at the moment)
Currently, I was communicating through http requests but I was struggling to make the plot update when new data was posted (see this question)

Unfortunately I think you are looking at this from the wrong side. This library provides a communication mechanism. It will just allow you to send information from the client to the server or viceversa. The documentation is brief because this library is small.
You'll be replacing those HTTP requests you have now with WebSocket messages, but everything else will be largely the same. From what you are saying your problem is in updating a chart, which is all in the browser/javascript domain.

@AlekseyFedorovich , not sure if this may help you, I just created a small example of Flask-Sock together with HTMX for a self-updating webpage: https://github.com/paluigi/flask-htmx
I guess you can add a button to request updates from the sensor, or just call to request new data in a loop. Plotly graphs could be saved as images and placed in the static folder (I haven't test image updates in the webpage, but they should work)
This is a toy example, I created it because I was looking for a way to make a small real-time dashboard and I didn't find any other.

@paluigi thank you for your answer. I solved the problem with Ajax (JQuery) enabling front-end  <->  back-end  communication on an interval basis


Update sensitive-information-type-learn-about.md

@chrfox - I have made a couple of edits to the Learn about sensitive information types document. Please have a look and approve the changes if they look good. Please note that one of the changes is to create a table. I hope the format i have followed is correct.

HI @arastogi205
The table doesn't render correctly, so I'll have to look into that. In addition the publishing system is having a major outage, so it may be a day or two before I can get this rendered to work on it

@JohanFreelancer9 - kindly do the copy editor review for this PR. Thanks

@arastogi205
clsoing this without merging. I have added the confidence level results aggregation information in a different format in a different place.  The diagram is unnecessary. The second note is not appropriate for the topic.  All statements about possible future actions belong in a blog post, the roadmap or the message center.  Also, as of this writing the build and publishing system is still down, so publishing will not be immediate.

@chrfox - can you share where you have added the confidence level result aggregation. Since, the publishing is not immediate, I am not sure how can I view the changes made.


great work! any chance to support fp16 inference?

great work! any chance to support fp16 inference? thx!

Hi, thanks for your interest. Our work is mainly built on BasicSR. Unfortunately, it seems that BasicSR doesn't support fp16 at the moment (https://github.com/XPixelGroup/BasicSR/issues/477#issuecomment-934294844).

Hi, thanks for your interest. Our work is mainly built on BasicSR. Unfortunately, it seems that BasicSR doesn't support fp16 at the moment (XPixelGroup/BasicSR#477 (comment)).

I mean for HiT-srf (I only test this), use the pretrain model inference in fp16 will get black image. seems maybe some improve in the scc class select position bias part? thx

Thanks for the quick reply, it was very helpful, appreciated!


fix(compaction): use hybrid picker to fix too many sub level when there are many small files in base level

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
The main branch will decrease score when there are too many files in base level.
But if these files are generated by trivial-move from flush level, or just cut by vnode-partition, we can not trigger intra-l0 compaction because of the small score
Checklist

[ ] I have written necessary rustdoc comments
[ ] I have added necessary unit tests and integration tests
[ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features #7934).
[ ] My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
[ ] All checks passed in ./risedev check (or alias, ./risedev c)
[ ] My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)

[ ] My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

[ ] My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

This problem has been solved by other PR


Never received my 100 tons or my 25,000 dogs.

I paid for my 100 ton and also paid for my 25,000 dogs tokens and I never received. Confirmation of payment is on the blockchain.

And actually I noticed i paid twice for the dogs..

Yea and pay half of lost money

Please  where is my airdrop dog coine

I not claim what why


Update faq.md

Change answer to "When will Haveno be ready for use?" if FAQ from  end of 2022 to 2024.

@woodser @napoly Could you delete this pull request using this github virtual assistant link? I used the wrong github account. I will submit a new PR of the same change with my other account.
https://support.github.com/request?q=delete+a+pull+request

This PR is closed. Why take further action?

Didn't want to associate my work account with my reddit account
On Mon, Apr 1, 2024, 2:07 PM woodser @.***> wrote:

This PR is closed. Why take further action?
—
Reply to this email directly, view it on GitHub
https://github.com/haveno-dex/haveno-site/pull/105#issuecomment-2030556896,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AGRA4XKKRQ6FIQHCXJKJVC3Y3HEAPAVCNFSM6AAAAABFSDSXRKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZQGU2TMOBZGY
.
You are receiving this because you modified the open/close state.Message
ID: @.***>

Ah gotcha. Ok I've submitted the request.

Perfect. Thank you!
On Mon, Apr 1, 2024, 6:03 PM woodser @.***> wrote:

Ah gotcha. Ok I've submitted the request.
—
Reply to this email directly, view it on GitHub
https://github.com/haveno-dex/haveno-site/pull/105#issuecomment-2030893378,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AGRA4XP4YTKUMXQZTNQ2KWLY3H7XXAVCNFSM6AAAAABFSDSXRKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZQHA4TGMZXHA
.
You are receiving this because you modified the open/close state.Message
ID: @.***>


Storage iCloud + Scheme naming + remove shadow

remove from iCloud the files we save in storage
add proper scheme naming for tvOS Hello Mixpanel app
remove redundant shadow around image that can be seen in light version

lgtm


dotnet-watch: add --verbose and --quiet command line flags

Command line options are more intuitive than an environment variable. This adds two command line options as an alternate solution for https://github.com/aspnet/DotNetTools/issues/142
cc @glennc @moozzyk @muratg

To clarify, this is an alternate solution, not an alternate configuration option. This PR would actually remove the environment variable for configuring log level.

:ship::it:

Question from an after thought: dotnet supports a "global verbose" flag, which we currently ignore. Should dotnet --verbose watch be considered equivalent to dotnet watch --verbose?

Furthermore, if dotnet watch --verbose is set, should watch set the global verbose flag?
i.e. dotnet watch --verbose run would launch the equivalent of dotnet --verbose run


[feature] LuckPerms as Forge mod

A version of luck perms as a forge mod would be cool
Reference: https://mcforge.readthedocs.io/en/1.13.x/utilities/permissionapi/

For now, I suggest using Sponge + LuckPerms. Sponge will implement the Forge permissions API and forward the requests onto LuckPerms.,

Sponge is only available for mc <= 1.12


incorrect usages of int for blasint with 64-bit API

When I compile openblas with the 64-bit API, I get a lot of warnings about code which incorrectly assumes that blasint is the same as int.
There are dozens of warnings like:
gemv.c:202:48: warning: absolute value function 'abs' given an argument of type
      'blasint' (aka 'long') but has parameter of type 'int' which may cause
      truncation of value [-Wabsolute-value]
  if (beta != ONE) SCAL_K(leny, 0, 0, beta, y, abs(incy), NULL, 0, NULL, 0);

Maybe you need to define a BIABS(i) macro that expands to abs for the 32-bit API and labs (or llabs if needed) for the 64-bit API?
I also get a few other miscellaneous cases that use the wrong integer type:
lapack/laswp.c:100:8: warning: incompatible function pointer types passing 'int
      (*)(BLASLONG, BLASLONG, BLASLONG, float, float *, BLASLONG, float *,
      BLASLONG, blasint *, BLASLONG)' (aka 'int (*)(long, long, long, float,
      float *, long, float *, long, long *, long)') to parameter of type
      'int (*)()' [-Wincompatible-function-pointer-types]
                     laswp[flag], nthreads);
                     ^~~~~~~~~~~
../common_thread.h:180:39: note: passing argument to parameter 'function' here
                       void *c, BLASLONG ldc, int (*function)(), int threads);

lapack/zlaswp.c:99:80: warning: incompatible function pointer types passing 'int
      (*)(BLASLONG, BLASLONG, BLASLONG, float, float, float *, BLASLONG, float
      *, BLASLONG, blasint *, BLASLONG)' (aka 'int (*)(long, long, long, float,
      float, float *, long, float *, long, long *, long)') to parameter of type
      'int (*)()' [-Wincompatible-function-pointer-types]
  ...k1, k2, dummyalpha, a, lda, NULL, 0, ipiv, incx, laswp[flag], nthreads);
                                                      ^~~~~~~~~~~
../common_thread.h:180:39: note: passing argument to parameter 'function' here
                       void *c, BLASLONG ldc, int (*function)(), int threads);

1 warning generated.
xerbla.c:16:69: warning: format specifies type 'int' but the argument has type
      'blasint' (aka 'long') [-Wformat]
      fprintf(stderr, "Parameter %d to routine %s was incorrect\n", p, rout);

abs() can take any argument type, qwerty-abs() just own type.
As you notice it is a warning that code mifht be wrong, if you read manual then you understand code is correct.
If you try clang you get few more with fabs() in similar position.
PS i cleaned like 9/10ths of warnings recently.PR is welcome, but replacing one call with faux warning to 2-page ifdef system does not sound useful.

Actually in a C context the two are different I think (though the likelyhood that the value of one of the increments actually overflows  an int is going to be very low).

They dont overflow yet ... Leavins small chance to polish the code.

As @martin-frbg said, C does not have overloading: abs, labs, llabs, fabs, fabsl, fabsf, and cabs are all different functions that take and return different types.  If you call the wrong function, as is happening here (and in #1709), you run the risk of inadvertent truncation.

The labs issue should be fixed now, but I do not have a solution for the "incompatible function pointer types" problem (that is not related to INTERFACE64).

@stevengj posix-ly they are different but modern compilers tend to adapt shortest form to other types

@brada4, what compiler does this?   Changing abs(x) to labs(x) changes the meaning of the program, so it is not a valid compiler optimization.  Try the test program:
#include <stdio.h>
#include <stdlib.h>
int main(void) {
     long big = -2147483649;
     printf("abs(%ld) = %ld\n", big, (long) abs(big));
     return 0;
}

Both gcc 6.3.0 and clang (Apple LLVM version 9.1.0) correctly truncate the result to int rather than implicitly converting the cal to labs, printingabs(-2147483649) =<PHONE_NUMBER>.

The function pointer issue can probably be masked by casting to (int(*),()) rather than just int(*), but I am not sure if this is actually a good idea. The underlying problem seems to be that the code equates a pointer to an array member with a pointer to a function, not sure if that is a healthy assumption. Anyone ?


Add  to MJML 4?

Hi there 👋🏼!
I am wondering if you would be interested in a PR that adds <mjml-chart> directly to MJML 4 instead of as a third-party plugin?🤔
I reached out to @FGRibreau on Twitter yesterday who suggested I submit a PR to update it to use MJML 4. After looking at the repo fro MJML, it seems it shouldn't be that difficult to add it as a component to v4.
However, I wanted to double check that this is an enhancement you'd be interested in.  😁

Hey @jjprevite, as it's using a third-party service, we prefer it to be available as a community component as well.

@ngarnier Ah, if I understand you correctly, you'd rather me update <mj-chart> directly rather than import it into mjml?

Yes, that would be the best approach 🙂

Hello @ngarnier,
I'm working on porting mjml-chart to mjml4, here is what I've got so far.

I limited my test to the first one and it silently does not render my mj-chart, could you explain what is going on?
I can't find tests on mjml anymore, where are they? (so I can copy how you test in mjml4) :)
could you validate that component.js.tmpl follows the right new conventions?

Renaming MjChart class to Chart should fix the issue
On Thu, May 3, 2018 at 11:46 PM Francois-Guillaume Ribreau <
<EMAIL_ADDRESS>wrote:

Hello @ngarnier https://github.com/ngarnier,
I'm working on porting mjml-chart to mjml4, here is what I've got so far
https://github.com/image-charts/mjml-chart/pull/3/files.

I limited my test to the first one and it silently does not render
my mj-chart, could you explain what is going on?
I can't find tests on mjml anymore, where are they? (so I can copy
how you test in mjml4) :)
could you validate that component.js.tmpl follows the right new
conventions?

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/mjmlio/mjml/issues/1180#issuecomment-386447349, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAizzX4s6ZHxINv3zAW3lOR2i0Z8idcoks5tu3q9gaJpZM4TxZVF
.

--
Cordialement,
Maxime BRAZEILLES

Hum I don't understand why it would work but I did it nonetheless and I got this:

Element mj-chart doesn't exist or is not registered

I tried different variation (changing template and/or class name) but everytime it did not work (either this error or a silent fail that resulted in mjml2html not displaying my chart), could you take a look at the code? :)

Code seems fine, you need to rename it to Chart instead of  MjChart because it now guess the name based on class name so Chart -> <mj-chart> & MjChart -> <mj-mj-chart>.
Try to check what's inside components object to see if your constructor is well listed. If not I don't really know try to use the boilerplate with the compiled component to see if it works on this repo

Yes it's listed in
import {components } from 'mjml-core';

//
{ chart:
   { [Function: Chart]
     tagOmission: true,
     endingTag: true,
     allowedAttributes:
      { cht: 'string',
        chd: 'string',
       ...
}

but I can't call it with:
mjml2html(`
        <mjml>
          <mj-body>
            <mj-chart
            chs="300x200"
            chd="t:10,20,30|15,25,35"
            cht="bvs"
            chxt="x,y"
            chxl="0:|A|B|C" />
          </mj-body>
        </mjml>`)

I got:
{ line: 4,
       message: 'Element mj-chart doesn\'t exist or is not registered',
       tagName: 'mj-chart',
       formattedMessage: 'Line 4 of /www/image-charts/mjml-chart (mj-chart) — Element mj-chart doesn\'t exist or is not registered' }

My bad we did refactor this part someday, and now it's just the class name in kebab case so name was good https://github.com/mjmlio/mjml/blob/master/packages/mjml-core/src/components.js#L6
And your component is returning a non valid HTML element for now.
As I said try with the boilerplate, might need to check if you do something different https://github.com/mjmlio/mjml-component-boilerplate/blob/master/components/MjBasicComponent.js


[Fzf-lua] No diagnostics found

Hello,
at first the functions FzfLua lsp_document_diagnostics and FzfLua lsp_workspace_diagnostics were working as intended showing the diagnostics from the document or workspace, respectively. But recently, even if the lsp reports the presence of diagnostics errors and warnings, these both functions show nothing.
in :messages it only appears:
[Fzf-lua] No diagnostics found
[Fzf-lua] No workspace diagnostics found
I know that on the last days the interface for vim.lsp.diagnostic has changed to vim.diagnostic. Is it the reason that FzfLua lsp_document_diagnostics and lsp_workspace_diagnostics are showing nothing?
By the way, thanks a lot for the plugin. It's really good.

Actually the commit just before the latest (https://github.com/ibhagwan/fzf-lua/commit/41b657e823f3f0fdfe199450e17fa1e893a1eaed) made the necessary adjustments for the new vim.diagnostic interface but I made a small error which made it seem as if there were no diagnostics at certain scenarios.
Should be fixed now :-)

By the way, thanks a lot for the plugin. It's really good.

And Ty <3

Oh yes, it's working back again.
Thanks for the speedy fix c:


Add "update report" button to table report config view

It'd be useful for fixing/updating a link that was already sent.

Also it would be nice if we could copy over comments from one report to another.


luci/statistics: Fix nut UPS graphs

At some point since I last checked, the nut plugin for collectd changed the
names of the timeleft and percent datasets. Update the luci module to match
so that those graphs are generated correctly again.
Signed-off-by: David Woodhouse<EMAIL_ADDRESS>

Merged, thanks @dwmw2 !