Split AnyType check into two pipeline stages

The existing pipeline stage that catches use of AnyType is split into two.
The stage filterOutDefinitionsUsingAnyType is used earlier in the pipeline to do appropriate filtering, reducing the amount of work done by later stages.
The stage ensureDefinitionsDoNotUseAnyTypes is used later in the pipeline to catch any issues introduced by stages than ran after the filter stage.
Prerequisite of PR #255

Coverage increased (+26.5%) to 72.85% when pulling 357af832a6e026670730710f9138bf02fda2d351 on improve/anytype-checks into 41435cabbfbf121f9728691d20fde0f517461481 on master.


excludes in JS minify being skipped

I've get a situation very close to https://github.com/Polymer/polymer-cli/issues/701 and while I've applied the approach added via https://github.com/Polymer/polymer-cli/pull/952 I'm noticing that the files in question are still being minified in a way that triggers errors in the Firebase code.
Tracking through the build/cli code I noticed that when the files are entering the getOptimizeStreams section of the build pipeline, the file was being tracked with a rewritten file.pathName such that file. relative would return an unmatchable file name when passed to notExcluded for comparison. The can be experienced via https://github.com/Westbrook/polymer-build-filenames which outlines the steps to see this in action.
Upon further review with some help from @justinfagnani I realized that all the the JS files, no matter their origin, were being seen as isInline === true at https://github.com/Polymer/tools/blob/master/packages/build/src/html-splitter.ts#L189 which would clearly cause this issue. It seems be happening because bundle is occurring before getOptimizeStreams here https://github.com/Polymer/tools/blob/master/packages/cli/src/build/build.ts#L84 It seems that this issue can be avoided by moving the if (bundled) { block to just before the if (options.basePath) { block here https://github.com/Polymer/tools/blob/master/packages/cli/src/build/build.ts#L128 and wanted to see if that made sense to someone more knowledgable on this project that I.
I'd be happy to PR this if you'd like, though I know there is lots of dev going against this right now. Either way let me know if I can help get the right fix for this into the codebase!

I thought I was going mad - I've been facing the same issue for weeks.
https://stackoverflow.com/questions/50073467/
Justin - I think this is the same issue (or at least related) I asked you to take a look at (via twitter) regarding a lib  (UnityLoader.js) that keeps getting screwed with in the build process (even taking the code from my custom element and incorporating in directly in my App now breaks during an ES5 build)

FYI, I'm still experiencing this issue with a fresh install of v1.7.3. I'd be happy to submit a PR if the code ordering was seen as an acceptable fix for this issue. Please advice.

Gentle ping.
Seems to be an important issue (... at least preventing me to upgrade).

@usergenic - any chance for the cli to honor minify.exclude as it used to ?

@usergenic - not giving up ; )

Exclusion still doesn't seem to work with 1.9.9. What is the status here? Is there some workaround for the time being? Or would I need to manually copy the excluded dependencies after build?

FYI: while I was able to get by with the code suggested in https://github.com/Polymer/tools/pull/584 I was never able to get the tests to pass and never did the work upgrade the pull to the current version of the CLI. I moved away from using polymerfire to rxfire for the project relying on this feature and have had good success. Particularly, polymerfire being a bit of a blocker to moving to Polymer 3/LitElement I was very happy with the flexibility I achieved with the change. I realize there are other libraries that might suffer from this issue, and in those cases (if you're on Polymer 3/LitElement already) it might be better to use Rollup/Webpack via the suggestions found here: https://open-wc.org/building/#using-index-html-as-an-entry-point

Hey everyone, thanks for your patience.  I'm working on getting this in right now.

Okay so one issue with the PR moving the bundler to after the JS transformation stuff happens is that bundler doesn't know how to bundle anything which has been transformed to AMD.
While I investigate refactoring things, you might try adding the files you want to exclude to the config's bundle > excludes array as well as the js > minify > exclude array (and don't ask why one term is plural and one is singular) in your polymer.json:
{
  "npm": true,
  "moduleResolution": "node",
  "build": [
    {
      "name": "bundled-es",
      "bundle": {
        "excludes": [ "./path/to/whatever.js" ]
      },
      "js": {
        "minify": {
          "exclude": [ "./path/to/whatever.js" ]
        }
      }
    }
  ]
}

The reason why the minify.excludes bit doesn't work is that the bundles have already been constructed when that runs.  You can exclude the specific bundle from minification if you want if you know that bundles name.


Limit to 150 urls

Hello, why the limit is 150 urls?

I dont know if i am doing something bad, but now it just takes 12 urls when searching something

I think it's limited by the bing search engine.


Wakeword not being detected

The wake words "OK nabu" and "hey jarvis" are never detected.

Command:
script/run --host <IP_ADDRESS> --token IUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiI0NDredactedG9kg22mvNO --awake-sound sounds/awake.wav --done-sound sounds/done.wav --vad webrtcvad --debug
Hardware, raspberrypi 3b with Razer blackshark microphone + earphones headset.
speaker-test -t wav -c 2 plays audio succesfully
arecord --format=S16_LE --duration=5 --rate=16000 --file-type=raw out.raw records good quality audio
Homeassistant running on raspberry pi 4.
Using --debug-recording-dir <DIR> successfully records audio that I can playback and listen to that is of good quality.
OpenWakeWord Debug Logs - lots of connections and disconnections (wired network)
s6-rc: info: service s6rc-oneshot-runner: starting
s6-rc: info: service s6rc-oneshot-runner successfully started
s6-rc: info: service fix-attrs: starting
s6-rc: info: service fix-attrs successfully started
s6-rc: info: service legacy-cont-init: starting
s6-rc: info: service legacy-cont-init successfully started
s6-rc: info: service openwakeword: starting
s6-rc: info: service openwakeword successfully started
s6-rc: info: service discovery: starting
DEBUG:root:Namespace(uri='tcp://<IP_ADDRESS>:10400', models_dir=PosixPath('/usr/local/lib/python3.11/dist-packages/wyoming_openwakeword/models'), custom_model_dir=['/share/openwakeword'], preload_model=['ok_nabu'], threshold=0.5, trigger_level=1, output_dir=None, debug=True, debug_probability=False, model=[])
DEBUG:root:Loading ok_nabu from /usr/local/lib/python3.11/dist-packages/wyoming_openwakeword/models/ok_nabu_v0.1.tflite
DEBUG:wyoming_openwakeword.handler:Started thread for ok_nabu
DEBUG:root:Loading /usr/local/lib/python3.11/dist-packages/wyoming_openwakeword/models/melspectrogram.tflite
DEBUG:root:Loading /usr/local/lib/python3.11/dist-packages/wyoming_openwakeword/models/embedding_model.tflite
INFO:root:Ready
DEBUG:wyoming_openwakeword.handler:Client connected:<PHONE_NUMBER>959250
DEBUG:wyoming_openwakeword.handler:Client disconnected:<PHONE_NUMBER>959250
[23:33:50] INFO: Successfully sent discovery information to Home Assistant.
s6-rc: info: service discovery successfully started
s6-rc: info: service legacy-services: starting
s6-rc: info: service legacy-services successfully started
DEBUG:wyoming_openwakeword.handler:Client connected:<PHONE_NUMBER>528512
DEBUG:root:Loading ok_nabu_v0.1 from /usr/local/lib/python3.11/dist-packages/wyoming_openwakeword/models/ok_nabu_v0.1.tflite
DEBUG:wyoming_openwakeword.handler:Started thread for ok_nabu_v0.1
DEBUG:wyoming_openwakeword.handler:Receiving audio from client:<PHONE_NUMBER>528512
INFO: Created TensorFlow Lite XNNPACK delegate for CPU.
DEBUG:wyoming_openwakeword.handler:Client disconnected:<PHONE_NUMBER>528512
DEBUG:wyoming_openwakeword.handler:Client connected:<PHONE_NUMBER>292914
DEBUG:wyoming_openwakeword.handler:Receiving audio from client:<PHONE_NUMBER>292914
DEBUG:wyoming_openwakeword.handler:Client disconnected:<PHONE_NUMBER>292914
DEBUG:wyoming_openwakeword.handler:Client connected:<PHONE_NUMBER>344396
DEBUG:wyoming_openwakeword.handler:Receiving audio from client:<PHONE_NUMBER>344396
DEBUG:wyoming_openwakeword.handler:Client disconnected:<PHONE_NUMBER>344396
DEBUG:wyoming_openwakeword.handler:Client connected:<PHONE_NUMBER>476678
DEBUG:wyoming_openwakeword.handler:Receiving audio from client:<PHONE_NUMBER>476678
DEBUG:wyoming_openwakeword.handler:Client disconnected:<PHONE_NUMBER>476678
DEBUG:wyoming_openwakeword.handler:Client connected:<PHONE_NUMBER>806785
DEBUG:wyoming_openwakeword.handler:Receiving audio from client:<PHONE_NUMBER>806785
DEBUG:wyoming_openwakeword.handler:Client disconnected:<PHONE_NUMBER>806785
DEBUG:wyoming_openwakeword.handler:Client connected:<PHONE_NUMBER>170133
DEBUG:wyoming_openwakeword.handler:Receiving audio from client:<PHONE_NUMBER>170133
DEBUG:wyoming_openwakeword.handler:Client disconnected:<PHONE_NUMBER>170133
DEBUG:wyoming_openwakeword.handler:Client connected:<PHONE_NUMBER>466737
DEBUG:wyoming_openwakeword.handler:Receiving audio from client:<PHONE_NUMBER>466737
DEBUG:wyoming_openwakeword.handler:Client disconnected:<PHONE_NUMBER>466737
DEBUG:wyoming_openwakeword.handler:Client connected:<PHONE_NUMBER>400230
DEBUG:wyoming_openwakeword.handler:Receiving audio from client:<PHONE_NUMBER>400230
DEBUG:wyoming_openwakeword.handler:Client disconnected:<PHONE_NUMBER>400230
DEBUG:wyoming_openwakeword.handler:Client connected:<PHONE_NUMBER>739777
DEBUG:wyoming_openwakeword.handler:Receiving audio from client:<PHONE_NUMBER>739777
DEBUG:wyoming_openwakeword.handler:Client connected:<PHONE_NUMBER>860357
DEBUG:wyoming_openwakeword.handler:Sent info to client:<PHONE_NUMBER>860357
DEBUG:wyoming_openwakeword.handler:Client disconnected:<PHONE_NUMBER>739777
DEBUG:wyoming_openwakeword.handler:Client connected:<PHONE_NUMBER>494943
DEBUG:wyoming_openwakeword.handler:Receiving audio from client:<PHONE_NUMBER>494943
DEBUG:wyoming_openwakeword.handler:Client disconnected:<PHONE_NUMBER>860357
DEBUG:wyoming_openwakeword.handler:Client disconnected:<PHONE_NUMBER>494943
DEBUG:wyoming_openwakeword.handler:Client connected:<PHONE_NUMBER>718724
DEBUG:wyoming_openwakeword.handler:Receiving audio from client:<PHONE_NUMBER>718724
DEBUG:wyoming_openwakeword.handler:Client disconnected:<PHONE_NUMBER>718724
DEBUG:wyoming_openwakeword.handler:Client connected:<PHONE_NUMBER>325951
DEBUG:wyoming_openwakeword.handler:Receiving audio from client:<PHONE_NUMBER>325951
DEBUG:wyoming_openwakeword.handler:Client disconnected:<PHONE_NUMBER>325951
DEBUG:wyoming_openwakeword.handler:Client connected:<PHONE_NUMBER>511985
DEBUG:wyoming_openwakeword.handler:Receiving audio from client:<PHONE_NUMBER>511985
DEBUG:wyoming_openwakeword.handler:Client disconnected:<PHONE_NUMBER>511985
DEBUG:wyoming_openwakeword.handler:Client connected:<PHONE_NUMBER>329691
DEBUG:wyoming_openwakeword.handler:Receiving audio from client:<PHONE_NUMBER>329691
DEBUG:wyoming_openwakeword.handler:Client disconnected:<PHONE_NUMBER>329691
DEBUG:wyoming_openwakeword.handler:Client connected:<PHONE_NUMBER>311120
DEBUG:wyoming_openwakeword.handler:Receiving audio from client:<PHONE_NUMBER>311120
DEBUG:wyoming_openwakeword.handler:Client connected:<PHONE_NUMBER>886166
DEBUG:wyoming_openwakeword.handler:Receiving audio from client:<PHONE_NUMBER>886166
DEBUG:wyoming_openwakeword.handler:Client connected:<PHONE_NUMBER>219707
DEBUG:wyoming_openwakeword.handler:Sent info to client:<PHONE_NUMBER>219707
DEBUG:wyoming_openwakeword.handler:Client disconnected:<PHONE_NUMBER>219707
DEBUG:wyoming_openwakeword.handler:Client disconnected:<PHONE_NUMBER>886166
DEBUG:wyoming_openwakeword.handler:Client connected:<PHONE_NUMBER>350065
DEBUG:wyoming_openwakeword.handler:Receiving audio from client:<PHONE_NUMBER>350065
DEBUG:wyoming_openwakeword.handler:Client disconnected:<PHONE_NUMBER>350065
DEBUG:wyoming_openwakeword.handler:Client connected:<PHONE_NUMBER>553845
DEBUG:wyoming_openwakeword.handler:Receiving audio from client:<PHONE_NUMBER>553845
DEBUG:wyoming_openwakeword.handler:Client connected:<PHONE_NUMBER>387034
DEBUG:wyoming_openwakeword.handler:Sent info to client:<PHONE_NUMBER>387034
DEBUG:wyoming_openwakeword.handler:Client disconnected:<PHONE_NUMBER>387034
DEBUG:wyoming_openwakeword.handler:Client disconnected:<PHONE_NUMBER>553845
DEBUG:wyoming_openwakeword.handler:Client connected:<PHONE_NUMBER>043089
DEBUG:wyoming_openwakeword.handler:Receiving audio from client:<PHONE_NUMBER>043089
DEBUG:wyoming_openwakeword.handler:Client disconnected:<PHONE_NUMBER>043089
DEBUG:wyoming_openwakeword.handler:Client connected:<PHONE_NUMBER>958312
DEBUG:wyoming_openwakeword.handler:Receiving audio from client:<PHONE_NUMBER>958312

Ok so it seems like just a very low sensitivity, getting like 1 in 20. Likely a openwakword problem

script/run --host <IP_ADDRESS> --token eyJhbGciOiJIUzI1redacted --done-sound sounds/done.wav --vad webrtcvad --debug --mic-device plughw:CARD=Device --debug-recording-dir records --noise-suppression 2 --auto-gain 25 --volume-multiplier 4
Ok, so I'm getting about a 50% hit rate with this command, using a tiny usb omnidirectional microphone

I had to remove the awake sound as I was hitting this issue: https://github.com/synesthesiam/homeassistant-satellite/pull/1

script/run --host <IP_ADDRESS> --token eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiI0NDA3ZTM4NjNkZmQ0NmY2YTM4MjE0NDJjZmEzMWI4YyIsImlhdCI6MTY5NzE0ODc4OCwiZXhwIjoyMDEyNTA4Nzg4fQ.CM-43hmuImaukgtrsw2eG6clobjG9kg22mvNOwr94zQ --done-sound sounds/done.wav --vad webrtcvad --debug --mic-device plughw:CARD=Device --debug-recording-dir records --noise-suppression 2 --auto-gain 25 --volume-multiplier 6
So this command is working well with this microphone: https://www.amazon.co.uk/Recording-Microphone-Omnidirectional-Portable-Conferencing-BLACK/dp/B088D6SJBQ/ref=sr_1_3?crid=2BBB3RVD5RGEK&keywords=usb+microphone+raspberry+pi&qid=1697203109&sprefix=usb+microphone+rasp%2Caps%2C73&sr=8-3
Getting about a 70% pickup rate with a threshold of 0.5.

For anyone else with the same issue...
I also had problems with wakeword being detected using a cheap USB microphone.  I used the "--debug-recording-dir " option (mentioned at the very bottom of the homeassistant-satellite page) to listen to the recording and found quite bad audio effects which the audio enhancement options weren't able to clean up :-(
I swapped to a different microphone, and audio is now clear and no enhancements necessary.


Option '--height' destroys results on stdout

[x] I have read through the manual page (man fzf)
[x] I have the latest version of fzf
[x] I have searched through the existing issues

Info

OS

[x] Linux
[ ] Mac OS X
[ ] Windows
[ ] Etc.

Shell

[x] bash
[ ] zsh
[ ] fish

Problem / Steps to reproduce
If running e.g. fzf --height=30% --bind=alt-enter:"execute(echo TEST)" and hitting alt-enter, the text TEST is not printed although the command seems to be executed (can be tested with e.g. touch).
It works without the option --height. It also works if stdout is piped to a file directly (fzf [...] >/tmp/testfile), but it does not work if piped through cat (fzf [...] | cat).

Perhaps related to #1247.

Hi, I spend some time today debugging this and came to the same observation as this issue.
@doak did you manage to find a workaround this (besides redirecting fzf's output?)
I think that the reason it works when redirecting to a file vs. to stdout is because in the latter case the output actually gets printed but it immediately gets overwritten by fzf trying to maintain the --height argument.

Same problem here:
❯ echo -n "Select an option: " && seq 10 | fzf --height 30%
4

❯ echo -n "Select an option: " && seq 10 | fzf
Select an option: 4

It seems --height is performing some carriage return internally than clears current line

Does not seems to be an issue on Windows. When switching to light renderer (i.e. height <=99), there is some garbage (maybe some escape code) printed before the text, but that's it.

(recording is 8 fps)


Cannot Read property 'html' of null

Sometimes I get this strange error
var $ = html.html ? html : cheerio.load(html);
^
TypeError: Cannot read property 'html' of null
at load (/Users/christian/development/beacon/beaconJobs/node_modules/x-ray/index.js:166:19)
at /Users/christian/development/beacon/beaconJobs/node_modules/x-ray/index.js:85:19
at /Users/christian/development/beacon/beaconJobs/node_modules/x-ray/index.js:248:14
at _done (/Users/christian/development/beacon/beaconJobs/node_modules/x-ray/node_modules/x-ray-crawler/node_modules/enqueue/index.js:78:20)
at _once (/Users/christian/development/beacon/beaconJobs/node_modules/x-ray/node_modules/x-ray-crawler/node_modules/enqueue/index.js:93:15)
at result (/Users/christian/development/beacon/beaconJobs/node_modules/x-ray/node_modules/x-ray-crawler/lib/index.js:107:7)
at /Users/christian/development/beacon/beaconJobs/node_modules/x-ray/node_modules/x-ray-crawler/node_modules/wrap-fn/index.js:121:18
at /Users/christian/development/beacon/beaconJobs/init/xrayDriver.js:28:16
at Request.callback (/Users/christian/development/beacon/beaconJobs/node_modules/superagent/lib/node/index.js:788:12)
at Stream. (/Users/christian/development/beacon/beaconJobs/node_modules/superagent/lib/node/index.js:997:12)
at emitNone (events.js:72:20)
at Stream.emit (events.js:166:7)
at Unzip. (/Users/christian/development/beacon/beaconJobs/node_modules/superagent/lib/node/utils.js:108:12)
at emitNone (events.js:72:20)
at Unzip.emit (events.js:166:7)
at endReadableNT (_stream_readable.js:905:12)
at doNTCallback2 (node.js:441:9)
at process._tickDomainCallback (node.js:396:17)
I've checked the index.js file and I've found an odd code for the function load
function load(html, url) {
      var $ = html.html ? html : cheerio.load(html);
      if (url) $ = absolutes(url, $);
      return $;
    }

There is no check for the html variable so if html is null html.html will crash the code for sure
I haven't read all the code but I did a quick fix that is preventing the code to crash
  function load(html, url) {
      var $ = html ? html.html ? html : cheerio.load(html) : null;
      if (url && $) $ = absolutes(url, $);
      return $;
    }

Do you think that this is the solution for the issue? If it is so I can make a PR.
Best Regards

+1


Hunter tier9 2piece Bug

We've done some testing in regards to tier9's  2Set Bonus. It would appear there are couple of bugs present in the sim.
The sim is not applying the following correctly to Serpent Sting:
Crit damage Multipliers:

Mortal shots (marksman talent)

Crit % Multipliers:

Lethal Shots (marksman talent)
Master Tactician (survival talent)

Serpent sting crits are also able to proc Expose Weakness (survival talent)

Fixed this a few days ago. Thanks for reporting!


Change the names for the function get_likes get_following_boards get_…

…following_users get_following_interests and implement these function

@Qungang Can you update REAME to reflect the changes you made. Thanks!!
Awesome job 😄


Migrated shape array, sends recvs and device partitioning related code to graph op inst and strict deabstraction.

Again, simplified a lot of code!
Turned on strict DA for control flow, device placement and sends/recvs tests.
Summary of behavior-altering changes:

When targeting TPU, added a scalar shape for each promoted scalar, to reduce the needs for swift users to manually add such shapes.

Fixed a bug in handling configureGPU or configureTPU – the deabstraction pass turns it into a graph op inst, which gets deleted by performance pipeline, so that when TFPartition.cpp again gets config via getForFunction(), it would not find any, and thus assume the graph is targeting CPU, even if the swift function has TensorFlow.enableTPU().

The fix is to mark GraphOperationInst to be possibly side effecting.

Added sanity check in deabstraction code on a shape (must be an array of ints) or shape array attr (array of array of ints).

Ran into invalid SILLocation in some of the graph_op insts generated from deabstraction pass -- See TODO: fix the wrong diagnostic location in sends_recvs.swift. Filed https://bugs.swift.org/browse/SR-8309 to fix it separately.

@swift-ci please test tensorflow

Thanks for the great round of comments! PTAL.

Test passed again: https://ci-external.swift.org/view/Pull Request/job/swift-PR-TensorFlow-Linux/385/
Merging so that I can send out a follow-up PR. I'd welcome any additional feedback.

Thanks for the additional comments! I address them in https://github.com/apple/swift/pull/18038 -- PTAL.


Szrz command in Linux is not supported

Environment
Windows build number: [run `[Environment]::OSVersion` for powershell, or `ver` for cmd]
Windows Terminal version (if applicable):

Any other software?

Steps to reproduce

Expected behavior

Actual behavior

Thanks for the suggestion! This is actually already being tracked by another issue on our repo - please refer to #1999 for more discussion.
/dup #1999


why it doesn't work in IE? just use the demo which you given

The demo works for me. What Windows and IE versions are you using?

windows7 and IE9, I also test in IE-TESTER

It works fine when I try it.


LDAP Connexion

Hello :)
Just to know, is there a hope having a LDAP connexion possibility in the furure?
Thank you!

It's currently not planned to add this a feature.


Mobile Wallet, the "Notification" page has few critical error messages repeatedly

Description:
In the Mobile Wallet, the "Notification" page has few critical error messages repeatedly,

"UNABLE TO SWITCH ACCOUNT. UNKNOWN ACCOUNT LABEL".
"UNKNOWN ACCOUNT LABEL".

Expected Result:
These error messages are not expected.

@vinayaga07 , somehow you created an account with empty name.  How can we reproduce it?  Also do you see this empty  account in account list?
I think it is not recoverable issue. You will probably need to create another wallet and recover form the seed.

@vinayaga07 , somehow you created an account with empty name.  How can we reproduce it?  Also do you see this empty  account in account list?
I think it is not recoverable issue. You will probably need to create another wallet and recover form the seed.

Steps to be followed to reproduce the issue.

Goto Wallet--> Accounts page
Create a new Account
Click on the Notification icon.

@vinayaga07 , can you reproduce it?  Did you create an account with empty name?

@bayk yes, I'm able to reproduce the issue with the recent build.
Created a new account with the account name and got this issue.

Able to reproduce with Today's build, hence re-opening this ticket.

Yes, I see that problem. The new account name didn't reach the mwc713 request.  But it is hard to fix until new wallet creation bug will be fixed.
@sarawut11   - FYI

@sarawut11 , seems like the problem on your side.  This problem happens when Output page refreshing outputs.  requestOutputs  function is called with empty account value.
Looks like there is some initialization race condition. Other pages looks fine. From the logs I see issues with outputs only.
I can ignore that call,  but I think it is better to understand why the account is empty. For example the accounts list is not initialized yet. In this case you might need to cal this method later to have a valid state.

Verified with the latest build, hence closing this ticket.


refactor(saber-plugin-image): replace vue-lazyload with lozad

Summary
Motivation: https://github.com/saberland/saber/pull/264#issuecomment-514324599
This PR:

Refactor: replace vue-lazyload with lozad, close #196
Refactor: use new lazyload method to preserve src, supporting browsers without srcset support, feed generator, spiders...
Fix: modify fixed transition style, allowing custom style to apply
Fix: remove height attribute, allowing responsive image

What kind of change does this PR introduce? (check at least one)

[x] Bugfix
[ ] Feature
[ ] Code style update
[x] Refactor
[x] Docs
[ ] Build-related changes
[ ] Other, please describe:

If changing the UI/CSS related code, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)

[ ] Yes
[x] No

If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:

[x] When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

[x] Chrome
[ ] Firefox
[ ] Safari
[ ] Edge
[ ] IE

If adding a new feature, the PR's description includes:

[ ] A convincing reason for adding this feature
[ ] Related documents have been updated
[ ] Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information:

IssueHunt Summary

Referenced issues
This pull request has been submitted to:

#196: chore: Replace vue-lazyload with a custom library

IssueHunt has been backed by the following sponsors. Become a sponsor

@krmax44 Can we move the inline transition style to stylesheet? It will override styles added by other libraries such as medium-zoom.

@krmax44 Can we move the inline transition style to stylesheet? It will override styles added by other libraries such as medium-zoom.
If one wants to change the duration, they can use custom styles to override the defaults.

Absolutely.

Done.
Guess nobody is actually passing numbers to blendIn or this might be a little breaking 😂

There is a lint error.

There is a lint error.

That variable is ejected.

Yes, I mean, can you fix it?

It is there from the beginning and I think that's how other plugins handle config (e.g. saber-plugin-google-analytics).
It is given a default value so we shouldn't worry about that.

😅 Sorry I understand what you mean now
Anyway thanks

vue-lazyload can be removed now, readme should also get updated.


[Lint/EndAlignment] Align with start of line

I would prefer an option to align with the indentation of the first line containing the keyword, rather than special casing variable assignment (via the variable option).
Lint/EndAlignment:
  EnforcedStyleAlignWith: variable

I think this would probably cover most cases where variable is the chosen config also.
Expected behavior
Permit the following:
[
  *case letters?
  when foo then bar
  else baz
  end
]

Actual behavior

Wants this indentation:
[
  *case letters?
   when foo then bar
   else baz
   end
]

RuboCop version
0.49.1 (using Parser <IP_ADDRESS>, running on ruby 2.3.4 x86_64-darwin16)

Seems like a bug to me.

There is a start_of_line option already:
https://github.com/bbatsov/rubocop/blob/v0.49.1/config/default.yml#L1391
I think that's what you want, @rhys-vdw. Removing the bug label.

I think that's what you want, @rhys-vdw. Removing the bug label.

Still, I've never seen code starting with a * aligned the way RuboCop wants it to be aligned in this situation. It simply seems wrong to me...

Sorry guys, looks like I was looking at old documentation that doesn't mention that option. Thanks for the help.
Sent from my Samsung SM-A520F using FastHub


Update information from iana for human-readable strings

ARP Hardware Types (from https://www.iana.org/assignments/arp-parameters/arp-parameters.xhtml)
DHCP Message Types (from https://www.iana.org/assignments/bootp-dhcp-parameters)
DHCP Options (from https://www.iana.org/assignments/bootp-dhcp-parameters)
No code changes

Thanks for the contribution!


Simplify getting the SSH key from the logs

As part of #1130 @squaremo and I talked about how to most easily get the SSH keys from the log.
We currently

advertise fluxctl identity (which requires having downloaded the binary and put it into $PATH) in site/using.md.
extract it from Flux's logs:

[daniel@reef flux ]$ git grep "grep identity.pub"
chart/flux/README.md:kubectl -n flux logs deployment/flux | grep identity.pub | cut -d '"' -f2
chart/flux/templates/NOTES.txt:  kubectl -n {{ .Release.Namespace }} logs $FLUX_POD | grep identity.pub | cut -d '"' -f2
site/helm/installing.md:kubectl -n flux logs $FLUX_POD | grep identity.pub | cut -d '"' -f2
site/standalone/installing.md:kubectl logs deployment/flux | grep identity.pub | cut -d '"' -f2
[daniel@reef flux ]$

The latter can be convenient, but maybe we should agree on one way to go about it.
@squaremo brought up the idea of using something like kubectl run --image weaveworks/flux -- identity.

Now that #1212 is landed, shall we cut over our docs to tell people to download fluxctl and use identity instead?

If yes, we should probably land this before the next release? :)

Now that #1212 is landed, shall we cut over our docs to tell people to download fluxctl and use identity instead?

Can you elaborate on this suggestion? I thought the objection to "just use fluxctl" is that it means you have to go on an excursion to explain where to download fluxctl and so on.

Where to download was only one step. This was what we had documented before:
fluxpod=$(kubectl get pod -l name=flux -o name | awk -F / '{ print $2; }')
kubectl port-forward "$fluxpod" 10080:3030 &
export FLUX_URL="http://localhost:10080/api/flux"
fluxctl list-controllers --all-namespaces


Modem Shell missing line ending \r\n

https://github.com/zephyrproject-rtos/zephyr/blob/main/drivers/modem/modem_shell.c @ line 141
	if (i == argc - 1) {
		ret = ms_send(mdm_ctx, "\r", 1);
	} else {
		ret = ms_send(mdm_ctx, " ", 1);
	}

changed to
	if (i == argc - 1) {
		ret = ms_send(mdm_ctx, "\r", 1);
		ret = ms_send(mdm_ctx, "\n", 1);
	} else {
		ret = ms_send(mdm_ctx, " ", 1);
	}

The modem shell only sends back \r, some devices require \r\n. Is there a config to accommodate both options?

can you please submit a PR with the fix?


Dependency resolution issues after upgrading to SBT 13.9

With SBT 13.9 we have been observing build errors like the below.
The basic situations is:

We have a largish project previously built on SBT 13.8 that we recently upgraded to SBT 13.9.
When we bump a version of an sbt-plugin or project dependency, we sometimes see the below error during the next build.  We have also seen it after pulling seemingly minor changes from git.
If we clear the entire ivy cache (rm -rf ~/.ivy2). SBT rebuilds the ivy cache and then appears to stabilize.

[error] /Users/nick/base/coursera/infra-services/libs/courTest/src/main/scala/org/coursera/test/JsAssertions.scala:3: object api is not a member of package play
[error] import play.api.libs.json.Json

Are there any known issues with ivy caches when upgrading to SBT 13.9?
I would love to give an exact means to reproduce but have not been able to find one yet. If I do I'll post it.

[error] /Users/nick/base/coursera/infra-services/libs/courTest/src/main/scala/org/coursera/test/JsAssertions.scala:3: object api is not a member of package play
[error] import play.api.libs.json.Json

How do you know it's a "dependency resolution issue"? show externalDependencyClasspath can show the list of dependencies. Could you define a task that sorts that by file name? When the error happens again you can compare the list to see if it's missing a jar.

Are there any known issues with ivy caches when upgrading to SBT 13.9?

Not that I know of.

Continuing to try to isolate the issue so it can be reproduced.
I've noticed that in many cases the first error reported is:
[error] missing or invalid dependency detected while loading class file 'SSealMessage.class'.
[error] Could not access type StrictLogging in value com.typesafe.scalalogging,
[error] because it (or its dependencies) are missing. Check your build definition for
[error] missing or conflicting dependencies. (Re-run with `-Ylog-classpath` to see the problematic classpath.)
[error] A full rebuild may help if 'SSealMessage.class' was compiled against an incompatible version of com.typesafe.scalalogging.
[error] one error found

I'm reviewing the scalalogging dependencies.

I'm still unable to build a reproducible case :(  I'll close this issue for now and open a new issue if we're able to isolate the issue better.
Thanks for looking at this @eed3si9n

Thanks for the report anyway. I actually won't mind half-baked issue reports since the community may able to step in and fill the gap if they are seeing similar issue.


Info

We have to merge the following branches into main:

[x] improvements @divyagar @Sandra3657
[ ] main-visit-details @peeyush14goyal
[x] visit-details-view @peeyush14goyal - This branch is a subbranch of new-view-status
[ ] treatment @divyagar @Sandra3657
[x] patient-rescript @divyagar - This branch is already merged in main
[x] disease-history @divyagar - This branch is already merged in main
[x] new-view-status - @peeyush14goyal - This branch is a subbranch of main-visit-details
[ ] rescript-dropdown
[x] schedule - This branch is already merged in main
[x] dashboard - This branch is already merged in main
[x] facility - This branch is already merged in main
[x] wire-password-reset - This branch is already merged in main

Pickup branches in this order. I know the code about Patient Management so you can skip those. Once completed along with writing tests create a PR

@sam9111 you can start work on the documentation of the code and features present in the main branch.

@sam9111 you can start work on the documentation of the code and features present in the main branch.

Yes!


fix: make tsdata bug

Codecov Report

Merging #274 (dcaadb3) into main (33f9b66) will not change coverage.
The diff coverage is 50.00%.

@@           Coverage Diff           @@
##             main     #274   +/-   ##
=======================================
  Coverage   14.75%   14.75%
=======================================
  Files         114      114
  Lines       14596    14596
=======================================
  Hits         2154     2154
  Misses      12273    12273
  Partials      169      169

Impacted Files
Coverage Δ

pkg/runtime/nodeflush.go
50.53% <50.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33f9b66...dcaadb3. Read the comment docs.


check permissions in the same transaction as queries

[ ] I added an entry to CHANGELOG.md if knowledge of this change could be valuable to users.

Here is a brief summary of what I did:

 Permissions werden nicht in derselben Transaktion gecheckt in der der Datenzugriff passiert.


Use /sys/class/board-info/ to detect platform type

Awesome

I need to test the PiStorms part but that is what was needed back in #170 (was closed because we had no way to detect if we were running on a pistorms)

Any objections to merging this one in?  I need it to go in so I can post the PR for the buttons API

LGTM


Update winauth-azuread-setup-incoming-trust-based-flow.md

Fix Typo in Module Installation Code Block

@sravanisaluru
Can you review the proposed changes?
Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@Echelon101 Thanks for your contribution! We'll refresh this article in an internal PR, and you'll see the updated article in the next day or so. This PR will automatically close.


[Feature] CDN Support

Search before asking

[X] I had searched in the issues and found no similar issues.

Feature Request
we need cdn support
Are you willing to submit PR?

[X] Yes I am willing to submit a PR!

Sorry about that, we are looking for CDN provider to cooperate.   There are no concrete plans yet.


Make link to video in README stand out more

As I mentioned on the reddit thread about it make the video stand out more in the README. I didn't know to look for it and only your comment on reddit made me look.

Is it possible you're not viewing the repo on github directly?
It is just a link, but that seems to be how github prefers video embeds to work. It looks like this on my screen. Does it look different for you?

I use the official Android app for GitHub on my phone 🤔

Yeah, it seems the github app generally has much worse support for readme features. I've seen it fail with syntax highlighting as well. The website directly works, however.
I can look into updating it somehow to make it more obvious, although this is generally more of a Github App issue than anything.

Yeah, you're right. I didn't realize until now sadly.
If you want you can add a header above with # video or something like that. Otherwise just close the issue.

I put it in a video tag, which github seems to render the same. This does hide the video on mobile, but at least it's not a stray link. I may consider adding a general image for github mobile users in the future (although again, this is definitely a bug with Github Mobile)


Fixed bug issue on TextArea with autosize after validation failed

Description
Reference issue #11428
Fixes bug issue on TextArea form component with autosize() return the height to initial height after validation failed
Visual changes
https://github.com/filamentphp/filament/assets/13638285/e22ea86a-2e85-4faf-bb01-f2456f4ae672
Functional changes

[x] Code style has been fixed by running the composer cs command.
[x] Changes have been tested to not break existing functionality.
[x] Documentation is up-to-date.

Please make changes as per our comments before you request a review


feat: :art: adding authentication and error handeling

how do you know this is running correctly? i don't see any tests for this

how do you know this is running correctly? i don't see any tests for this

Fixed Tests and added one for fail case


"Add external route" from GUI is not sticky

I have external TCP routes set up for both MariaDB and Postgres (originally created from the CLI), but the GUI seems not to know that—the "Create external route for provider" button is still displayed for each of them. If I click the button, it acknowledges that the route exists and will let me see the external connection info, but on refresh or state change it'll forget the external route again.
External access appears to work no matter what, this is just a GUI consistency issue afaik.

+1, observed as well in latest stable release.
Looks like a new port is generated each time "add external route" is hit too. Doesn't seem great. :(

@jvatic Any issue here if multiple routes were generated by having accidentally re-created them? Will they stick around following a cluster backup/restore?

You can remove any duplicate routes via the CLI, for example:
$ flynn -a postgres route
ROUTE     SERVICE   ID                                        STICKY  LEADER  PATH
tcp:3050  postgres  tcp/367504d6-e5d8-4e8d-9857-e3144ac7011d          true
$ flynn -a postgres route remove tcp/367504d6-e5d8-4e8d-9857-e3144ac7011d
Route tcp/367504d6-e5d8-4e8d-9857-e3144ac7011d removed.

Hmm, works for postgres but doesn't seem to work for redis.
➜  ~ flynn -a redis route
ROUTE  SERVICE  ID  STICKY  LEADER  PATH

I definitely do have external routes registered / working though. Just tested one now.

Redis is setup a bit differently and each instance has it's own app on which the route is created:
$ flynn apps | grep redis
ba43d727-f0aa-464c-84f0-012fef5978d0  redis-7a51d08f-5f9d-403b-990e-df114b3a99a7
1b29ed70-df17-41d0-ae3b-f555fe2eff69  redis-2d8f48a7-e7c1-42c0-a80d-868ef926c15a
0b5f91b1-8a26-4cc1-8682-b03a36bcba74  redis
$ flynn -a redis-7a51d08f-5f9d-403b-990e-df114b3a99a7 route
ROUTE     SERVICE                                     ID                                        STICKY  LEADER  PATH
tcp:3427  redis-7a51d08f-5f9d-403b-990e-df114b3a99a7  tcp/8ffbf3f1-da95-4faa-be28-86158553e580          true
$ flynn -a redis-7a51d08f-5f9d-403b-990e-df114b3a99a7 route remove tcp/8ffbf3f1-da95-4faa-be28-86158553e580
Route tcp/8ffbf3f1-da95-4faa-be28-86158553e580 removed.

Awesome, that did the trick. Thank you!


Verify micronaut data with ucp+ojdbc

Environment Details

Helidon Version:  2.0
Helidon MP

Problem Description
We have integrated micronaut data with helidon as part of #2386 and added example/test with hikari+h2
This task is to verify ucp+ojdbc+oracle db with the same.

Have merged the PR #2572 and provided README with it which explains how to verify micronaut data with ucp+ojdbc

Have merged the PR #2572 and provided README with it which explains how to verify micronaut data with ucp+ojdbc


Application on Android

https://github.com/skiptools/skip could be an interesting to try if with the Swift codebase we could potentially release the app on Android.
Keep in mind, as of today, v1 hasn't been released yet on this tool.

Using Expo and React Native would allow us to have one codebase for all platform.
I'll send my project soon as a proof of concept soon.
This swift project is a huge milestone though!

Using Expo and React Native would allow us to have one codebase for all platform. I'll send my project soon as a proof of concept soon. This swift project is a huge milestone though!

@GatienBoquet you could also check https://github.com/Ditectrev/Practice-Exams-Platform/issues/16, which should be way faster.
However, if you'd like to publish an app using React Native, we'll publish it :-)


Fixes #259 - Sidebars now render on multiple pages

Refactored convert_sidebar to mirror behaviour of convert_quote_or_verse, such that multiple pages draw correctly. Requires drawing the block content twice, and there's a small hack, but it works.
I coded this just to get something working, but happy to accept edits - I am using as-is at the moment and seems to work as expected.
Fixes #259

Closing this - looks like it causes NaNs in the output PDF, which Chrome PDF viewer wasn't catching. A proper fix is going to need some more looking at... once/if I figure out how in the heck to make this work, I'll open a new pull request.

Great! I still plan to review your code to see if I can provide some guidance. I apologize for letting this linger. I've been behind on reviews lately.

Awesome thanks - no problem with the lingering. FYI if you take out the "HACK" in this code, which only sort of worked anyway, the specific symptom is as follows for a sidebar that spans three pages (the most interesting case):

First draw of content renders correctly.
Draw of the box skips the second page, and draws the second and third page boxes on the third page
Second draw of content also skips over second page, draws second and third page of content on the third page

The whole thing of moving the second draw down an extra page has me scratching my head; I can only assume that there's some lingering state set in the PDF by the first content draw, but I can't figure out what it is. It's not impossible that this is triggered by earlier non-spanning sidebars as well. I'm still trying to work down to a minimal repro, but I'm at a conference this week so won't make progress for a little while.

@mojavelinux New fix which doesn't break everything is in #780. Something was getting modified in the graphics state that messed things up for subsequent drawing - saving and restoring graphics state made it work.

@mojavelinux Ignore that last one, I got overexcited apparently. #781 actually fixes things.


Provisioning Breaking Change: TokenParser.Constructor() -Exception: startIndex cannot be larger than length of string.

Which PnP repository

PnP Sites Core - https://github.com/OfficeDev/PnP-Sites-Core

Category
[ ] Bug
Environment
[ ] Office 365 / SharePoint Online
Expected or Desired Behavior
Not to raise an exception!
Observed Behavior
I have encountered an issue in the June release of the Core, when calling Web.ApplyProvisioningTemplate in the constructor of the TokenParser, it iterates through the web.Lists of the Subsite I am trying to provision, but it throws an ArgumentOutOfRangeException (startIndex cannot be larger than length of string) on the line:
_tokens.Add(new ListUrlToken(web, rootList.Title, rootList.RootFolder.ServerRelativeUrl.Substring(web.ServerRelativeUrl.Length + 1)));
When processing the first item in the list (AppPackages), the Token Parser seems to be expecting to find the Web ServerRelativeUrl within the RootList ServerRelativeUrl , when it isn't, hence the startIndex cannot be larger than length of string
rootList.RootFolder.ServerRelativeUrl = "/Lists/AppPackages"

web.ServerRelativeUrl = "/Experimental/2000001532"

PnPProvisioningDemo.xml.txt
The same issue applies to the other items in list that I checked.
I had no problems with May release.
Steps to Reproduce
I attach the xml (had to denote it as a text file for the uploader.)
Calling code:
            ProvisioningTemplateApplyingInformation ptai
                    = new ProvisioningTemplateApplyingInformation();
            ptai.ProgressDelegate = delegate (String message, Int32 progress, Int32 total)
            {
                Console.WriteLine("{0:00}/{1:00} - {2}", progress, total, message);
            };

            FileSystemConnector connector = new FileSystemConnector(STR_XmlTemplateFilePath, "");
            defaultTemplate.Connector = connector;

            web.ApplyProvisioningTemplate(defaultTemplate, ptai);

            ctx.ExecuteQueryRetry();

I am happy to provide any other information, you may need.
Thanks for your help!

Since I wrote this bug report version 2.5.1606.02 has been released on NuGet.
I now get a different exception: 'The field was found invalid:  {{listid:Documents} {fieldtitle:Modified} {fieldtitle:Modified}.'  Hopefuily somebody is working on a 2.5.1606.03 release.   If nobody is aware of this problem. let me know and I will provide more detail.

Can you provide a stacktrace of this exception? Preferably also the template you're trying to provision?

Hi Erwin,
Thanks for replying
at OfficeDevPnP.Core.Framework.Provisioning.ObjectHandlers.ObjectListInstance.CreateField(XElement fieldElement, ListInfo listInfo, TokenParser parser, String originalFieldXml, ClientRuntimeContext context, PnPMonitoredScope scope)
at OfficeDevPnP.Core.Framework.Provisioning.ObjectHandlers.ObjectListInstance.ProvisionObjects(Web web, ProvisioningTemplate template, TokenParser parser, ProvisioningTemplateApplyingInformation applyingInformation)
at OfficeDevPnP.Core.Framework.Provisioning.ObjectHandlers.SiteToTemplateConversion.ApplyRemoteTemplate(Web web, ProvisioningTemplate template, ProvisioningTemplateApplyingInformation provisioningInfo)
at Microsoft.SharePoint.Client.WebExtensions.ApplyProvisioningTemplate(Web web, ProvisioningTemplate template, ProvisioningTemplateApplyingInformation applyingInformation)
at MomentusSharePoint.SharePointModel.ManagerSiteServices.ApplyProvisioningTemplate(IManagerInfo manager, ProvisioningTemplate template, Boolean injectHtmlIntoHomePage, Boolean configureSiteColumns) in C:\Perforce\Server\MomentusSharePointServices\SharePointServices\ManagerSiteServices.cs:line 617
at MomentusSharePoint.SharePointModel.ManagerSiteServices.CreateSiteAndProvision(IManagerInfo manager, List`1 fundsForManager, Boolean removeConflicts, Boolean injectHtmlIntoHomePage, Boolean configureSiteColumns) in C:\Perforce\Server\MomentusSharePointServices\SharePointServices\ManagerSiteServices.cs:line 246
at IntegrationTestLibrary.ManagerSiteServicesTests.Test_Site_Creation_Creates_Site_For_Real() in C:\Perforce\Server\MomentusSharePointServices\IntegrationTestLibrary\SharePointModel\ManagerSiteServicesTests.cs:line 156
Just to give some context here:
I have a site that I use as a template to provision other sites, called Default.  It is a fairly simple site based on a teamsite with a document library that has 2 columns that are lookups on 2 lists: one which is a list on the site, the other which is  the list on the parent site.  The library has some views mostly based on the 2 columns.  The sites I create end in a numeric, which is a Manager ID and is unique.
Let me know if you require any more info
Tim
<EMAIL_ADDRESS>From: Erwin van Hunen<EMAIL_ADDRESS>Sent: Monday, June 20, 2016 5:21 PM
To: OfficeDev/PnP<EMAIL_ADDRESS>Cc: Daborn, Tim<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [OfficeDev/PnP] Provisioning Breaking Change: TokenParser.Constructor() -Exception: startIndex cannot be larger than length of string. (#1461)
Can you provide a stacktrace of this exception? Preferably also the template you're trying to provision?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/OfficeDev/PnP/issues/1461#issuecomment-227192289, or mute the threadhttps://github.com/notifications/unsubscribe/ARMwzsO1nPuMP1tr6jNWD7vp1f2CHzPBks5qNr3UgaJpZM4I5jHr.
The information in this e-mail and in any attachments is confidential and intended solely for the attention and use of the named addressee(s). This information may be subject to legal, professional or other privilege and further distribution of it is strictly prohibited without our authority. If you are not the intended recipient, you are not authorised to disclose, copy, distribute, or retain this message or any part of it, and should notify us immediately.
Please note that for business and regulatory purposes, emails and telephone calls to and from us, or our affiliates, may be subject to recording, storage and review. This email has been automatically scanned for the presence of computer viruses, profanities and certain file types but we cannot accept  responsibility for any loss or damage whatsoever caused by same.
Pioneer Investment Management Limited.
1 George’s Quay Plaza, George’s Quay, Dublin 2, Ireland.
Registered in Ireland no. 287793.

Can you extract a template from your 'Default' site and provide me with that template? Just to see what the engine extracts and in which way from your site.

It was attached to the email, but I will upload it here on the site.
PnPProvisioningDemo.xml.txt
A quick note - this should be the raw template, for the May release I had to tweak it to get it how I want, in particular set a string ine th web part and assign a list correctly.  Thanks for your help - any more questions and I will respond tomorrow,  Tim

This issue was moved to OfficeDev/PnP-Sites-Core#768


Add go1.17 directives to db integration test files

Add the go1.17 directives to all remaining files which were missing it. The older format is deprecated and will be removed in go1.18

The older format is deprecated and will be removed in go1.18

We should be able to remove the old format since it is already deprecated. If not, update the description with the reason. Thanks.

According to https://stackoverflow.com/questions/68360688/whats-the-difference-between-gobuild-and-build-directives, it looks like if // +build is completely removed, then older versions of Go which depend on parts of our code which used to have that directive will no longer work. That being said, I don't see this being a problem at all for this particular situation, but I figure if go1.17 allows them to coexist, then I don't see why we don't allow it, too.
If you think we should still just remove it, then that's fine, too

That being said, I don't see this being a problem at all for this particular situation, but I figure if go1.17 allows them to coexist, then I don't see why we don't allow it, too.

It's a little bit confusing to have the two. It opens to questions like: Do we have a problem if I remove it? Is there something depending on these tags? Can I remove them? If there is no actual reason to keep them (as in "I don't see this being a problem at all for this particular situation"), then I think a cleaner approach is to remove them.


Minor fixes to e-mail templates. Comma efter Dear name, Space after s…

…ignature divider. Line break fixes.

@danblah Any other changes you want done while we are at it?


rpc.close() does not end the actvity

First of all I want to thank you for your library it's very useful. However I noticed that rpc.close() closes the websocket, but the actvity doesn't end.
Is this a issue on my end or from this library? I hope you can help me or fix this.

Thanks!!
It takes around 30-40seconds on discord to reflect the changes automatically, if you refresh your discord the activity is gone immediately.

Oh yeah right sorry. Was totally my bad. Thank you for your fast response.


Space is a commit character...?

I was trying to figure out how to turn this off for a while, and this setting did not make it clear that space is also considered a commit character in this context. A lot of people have had this issue and simply didn't turn it off because the description wasn't clear enough.

This PR fixes #

THANK YOU! I was so confused by that. I'm going to start using your fork from now on.

            Cool.  Sent using the mobile mail appOn 6/9/21 at 5:03 PM, BUTTyPOO wrote:

                From: "BUTTyPOO"<EMAIL_ADDRESS>June 9, 2021To: "microsoft/vscode"<EMAIL_ADDRESS>"Subscribed"<EMAIL_ADDRESS>Re: [microsoft/vscode] Space is a commit character...? (#125881)

THANK YOU! I was so confused by that. I'm going to start using your fork from now on.
—You are receiving this because you are subscribed to this thread.Reply to this email directly, view it on GitHub, or unsubscribe.
[
{
@.": "http://schema.org",
@.": "EmailMessage",
"potentialAction": {
@.": "ViewAction",
"target": "https://github.com/microsoft/vscode/pull/125881#issuecomment-858178640",
"url": "https://github.com/microsoft/vscode/pull/125881#issuecomment-858178640",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
@.": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]

Closing because this PR went stale


[SPARK-4874] [CORE] Collect record count metrics

Collects record counts for both Input/Output and Shuffle Metrics. For the input/output metrics, it just appends the counter every time the iterators get accessed.
For shuffle on the write side, we count the metrics post aggregation (after a map side combine) and on the read side we count the metrics pre aggregation. This allows both the bytes read/written metrics and the records read/written to line up.
For backwards compatibility, if we deserialize an older event that doesn't have record metrics, we set the metric to -1.

Test build #25628 has started for   PR 4067 at commit 571cb69.

This patch merges cleanly.

Test build #25628 has finished for   PR 4067 at commit 571cb69.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25628/
Test PASSed.

Can you also paste some screenshots on what the UI changes look like? Thanks.

Test build #25638 has started for   PR 4067 at commit 1572054.

This patch does not merge cleanly.

This change was dependent on https://github.com/apache/spark/pull/3120, that just got merged and now there are some merge conflicts. I need to fix those first and will update the pr.

Hey @ksakellis - Thanks for working on this.
I took a very quick look at the patch. Overall I feel the patch should be fairly straightforward, but the specific implementations might've gone a bit over board with Scala language features (a lot of Options, orElse, closures, etc) and design (too many new classes introduced). If we can reduce those, the pr would be a lot easier to understand.

@rxin I updated the PR after doing a rebase and also incorporated some of your feedback. You made two general comments:

specific implementations might've gone a bit over board with Scala language features
too many new classes introduced
Can you please be more specific here pointing to the specific code. These comments are not very actionable as is.

Hi again - can't find my previous comment since the line is no longer in the diff due to the other pr being merged. Can you still add comment for that one (the part with Option and orElse and set ...)? Want to make sure if we read that code one year from now, we can still understand what's going on.

Test build #25641 has started for   PR 4067 at commit 3c2d021.

This patch merges cleanly.

The Scala stuff was mostly about the previous PR that got merged (and now no longer showing up as part of this diff).

So is this code you were referring to in HadoopRDD?
      // Find a function that will return the FileSystem bytes read by this thread. Do this before
      // creating RecordReader, because RecordReader's constructor might read some bytes
      val bytesReadCallback = inputMetrics.bytesReadCallback.orElse(
        split.inputSplit.value match {
          case split: FileSplit =>
            SparkHadoopUtil.get.getFSBytesReadOnThreadCallback(split.getPath, jobConf)
          case _ => None
        }
      )

Shows a stage that has Input Metrics (reading from a file) and writes data for next stage.

Shows a stage that has both shuffle reading and writing - no input or output metrics.

Shows a stage that has outputting to a file.

Test build #25638 timed out     for PR 4067 at commit 1572054     after a configured wait of 120m.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25638/
Test FAILed.

Test build #25641 has finished for   PR 4067 at commit 3c2d021.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class AfterNextInterceptingIterator[A](sub: Iterator[A]) extends Iterator[A]

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25641/
Test PASSed.

What about combining the input size and records in the same column. Overall this will help with the expansion in the number of columns. The title could be "Input Size / Records"

If we do that we wouldn't be able to sort on num records and bytes independently.

Yes - you'd only be able to sort on bytes. Wouldn't that be okay? These would likely track closely in most cases.

A big motivation to add recordsRead/Written was to detect data skew. In these cases bytes and records might not track very closely.
Thinking more about this, I suspect that having an Avg. record Size column (bytesRead/recordsRead) would be what you'd want to sort on. We could add this metric to the UI, make it sortable and then combine the bytesRead and recordsRead metrics into one column. Thoughts?

New Screenshot that correspond to CR feedback.

Shows a stage that has Input Metrics (reading from a file) and writes data for next stage.

Shows a stage that has both shuffle reading and writing - no input or output metrics.

Shows a stage that has outputting to a file.

@pwendell can you please re-review this? I'd like to get it in to 1.3. Some of our customers have been asking for metrics to help them determine data skew. Thx.

Test build #26441 has started for   PR 4067 at commit fe3f715.

This patch merges cleanly.

Test build #26441 has finished for   PR 4067 at commit fe3f715.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class AfterNextInterceptingIterator[A](sub: Iterator[A]) extends Iterator[A]

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26441/
Test PASSed.

Having a count does seem like a good idea, but I think the current approach of adding function calls for each iteration is too expensive. What about using a counting iterator and just asking it at the end?

BTW we can also just add counting directly to InterruptibleIterator

@rxin yeah that seems good.
@ksakellis one other thing I realized which is a little confusing, right now we report the bytes as "read" from a cached RDD as soon as they are fetched/present on the executor even if they have not been consumed by the task. Tracking consumption incrementally (in bytes) will be really hard, so maybe this is the best answer for now. It's a bit weird though - I think this logic was written before we sent incremental updates back. In terms of getting the total records read, we might need to make the assumption that the iterator is consumed in its entirety.

@pwendell I'm not sure how we can do what you propose without having an O(n) loop through all the records before passing the InterruptableIterator? We could do something fancy like counting incrementally and when we finish the task, if there are more records left, then do the loop to count the rest of the unread records. I don't think the complication is worth it. Also, reporting the accurate records read i think is better.
Alternatively, we can fix the bytesRead to be more accurate. Right now they are computed in ShuffleBlockFetcherIterator and calculated based on the blocks fetched. Since we do the flatMap on that iterator in BlockStoreShuffleFetcher we report that we read all the bytes even if we didn't. We can move the bytesRead collection out of ShuffleBlockFetcherIterator and move it into the same iterator that computes the # records read. So they line up and are more accurate.

If it would save on perf, I would be in favor of adding the counting to InterruptibleIterator.  In core loops like these, I think efficiency is more important than elegance.

Test build #26530 has started for   PR 4067 at commit 1aaa980.

This patch merges cleanly.

Test build #26530 has finished for   PR 4067 at commit 1aaa980.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class ChiSqSelectorModel (val selectedFeatures: Array[Int]) extends VectorTransformer
class ChiSqSelector (val numTopFeatures: Int)

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26530/
Test PASSed.

Test build #26678 has started for   PR 4067 at commit 9ecf912.

This patch merges cleanly.

Test build #26678 has finished for   PR 4067 at commit 9ecf912.

This patch fails MiMa tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class SimpleFunctionRegistry(val caseSensitive: Boolean) extends FunctionRegistry
class StringKeyHashMap[T](normalizer: (String) => String)
case class MultiAlias(child: Expression, names: Seq[String])

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26678/
Test FAILed.

Hey @ksakellis - I did a pretty thorough review here, any chance you could take a look? Most of the things were small. The only major thing is that I think if we are going to always show the output metrics for Hadoop (even for older versions) we need to make sure that we at least do a "best effort" presentation of the output size for older versions. I think it would be good if we could sneak that in, since otherwise that output metrics thing is not so useful for many people running with older versions. However, I'd also be okay just not showing either bytes or count in that case (which I think was the behavior before).
A second issue I realized (let's open a new JIRA for this) is that we never track output metrics (size or bytes) when data is written to cache, which is confusing because we track input metrics when data is read from cache.

New screenshots with the irrelevant columns invisible:

Shows a stage that has Input Metrics (reading from a file) and writes data for next stage.

Shows a stage that has both shuffle reading and writing - no input or output metrics.

Shows a stage outputting to an HDFS file.

Test build #26876 has started for   PR 4067 at commit e156560.

This patch merges cleanly.

Test build #26876 has finished for   PR 4067 at commit e156560.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26876/
Test FAILed.

Jenkins, retest this please

Test build #26896 has started for   PR 4067 at commit e156560.

This patch merges cleanly.

Test build #26896 has finished for   PR 4067 at commit e156560.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26896/
Test PASSed.

Test build #26904 has started for   PR 4067 at commit dad4d57.

This patch merges cleanly.

Test build #26906 has started for   PR 4067 at commit bd919be.

This patch merges cleanly.

Test build #26904 has finished for   PR 4067 at commit dad4d57.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26904/
Test PASSed.

Test build #26906 has finished for   PR 4067 at commit bd919be.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26906/
Test PASSed.

Jenkins, test this please. This LGTM pending tests.

Test build #26936 has started for   PR 4067 at commit bd919be.

This patch merges cleanly.

Test build #26936 has finished for   PR 4067 at commit bd919be.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26936/
Test PASSed.

Merging this, thanks Kos.

It looks like the "InputOutputMetricsSuite input metrics with mixed read methods" and "InputOutputMetricsSuite input metrics with interleaved reads" test may have started failing in the hadoop-2.2 build since this patch:
https://amplab.cs.berkeley.edu/jenkins/view/Spark/job/Spark-1.3-SBT/AMPLAB_JENKINS_BUILD_PROFILE=hadoop2.2,label=centos/29/testReport/

Yikes, @JoshRosen i'm looking into this.

@ksakellis How do I collect these metrics on a console right after the task is done.


Give --tls option to docker daemon when tls_enable => true

Under the conditions tls_enable => true, tls_verify => false, docker daemon listens TCP socket without TLS enabled.
Explicitly giving --tls option, this patch makes the daemon to listen with TLS even when the --tlsverify flag is not set (Note that --tlsverify implies --tls).

@hanazuki thanks, good spot. Thanks in particular for adding the tests. Much appreciated.


Which model is used behind the /v1/ai/text-to-diagram/generate API?

Which model is used behind the /v1/ai/text-to-diagram/generate API?

I see before is gpt-4-vision-preview
btw, I made a fork for configurable AI functions, check https://github.com/excalidraw/excalidraw/issues/8888


npm install fails on Windows

Here is the output.
C:\projects\thirdParty\redux\build\use-lodash-es.js:4
ImportDeclaration(path) {
^
SyntaxError: Unexpected token (
at exports.runInThisContext (vm.js:73:16)
at Module._compile (module.js:443:25)
at Object.Module._extensions..js (module.js:478:10)
at Module.load (module.js:355:32)
at Function.Module._load (module.js:310:12)
at Module.require (module.js:365:17)
at require (module.js:384:17)
at C:\projects\thirdParty\redux\node_modules\babel-core\lib\transformation\file\options\option-manager.js:204:20
at Array.map (native)
at Function.normalisePlugins (C:\projects\thirdParty\redux\node_modules\babel-core\lib\transformation\file\options\option-manager.js:182:20)
npm ERR! Windows_NT 6.3.9600
npm ERR! argv "C:\Program Files (x86)\nodejs\\node.exe" "C:\Program Files (x86)\nodejs\node_modules\npm\bin\npm-cli.js" "run" "build:es"
npm ERR! node v0.12.2
npm ERR! npm  v2.7.4
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>build:es: cross-env BABEL_ENV=es babel src --out-dir es
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>build:es script 'cross-env BABEL_ENV=es babel src --out-dir es'.
npm ERR! This is most likely a problem with the redux package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     cross-env BABEL_ENV=es babel src --out-dir es
npm ERR! You can get their info via:
npm ERR!     npm owner ls redux
npm ERR! There is likely additional logging output above.
npm ERR! Please include the following file with any support request:
npm ERR!     C:\projects\thirdParty\redux\npm-debug.log
npm ERR!  Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>build script 'npm run build:commonjs && npm run build:es && npm run build:umd && npm run build:umd:min && node ./build/es3ify'.
npm ERR! This is most likely a problem with the redux package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     npm run build:commonjs && npm run build:es && npm run build:umd && npm run build:umd:min && node ./build/es3ify
npm ERR! You can get their info via:
npm ERR!     npm owner ls redux
npm ERR! There is likely additional logging output above.
npm ERR! Please include the following file with any support request:
npm ERR!     C:\projects\thirdParty\redux\npm-debug.log
npm ERR! Windows_NT 6.3.9600
npm ERR! argv "C:\Program Files (x86)\nodejs\\node.exe" "C:\Program Files (x86)\nodejs\node_modules\npm\bin\npm-cli.js" "install"
npm ERR! node v0.12.2
npm ERR! npm  v2.7.4
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>prepublish: npm run clean && npm run check:src && npm run build
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>prepublish script 'npm run clean && npm run check:src && npm run build'.
npm ERR! This is most likely a problem with the redux package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     npm run clean && npm run check:src && npm run build
npm ERR! You can get their info via:
npm ERR!     npm owner ls redux
npm ERR! There is likely additional logging output above.
npm ERR! Please include the following file with any support request:
npm ERR!     C:\projects\thirdParty\redux\npm-debug.log

Looks like I had an old version of NodeJS install disregard!! <3

The underlying problem is that you are processing node_modules with Babel. Please don’t do this. We make no guarantees that Redux will work if you compile it again with Babel.
When you use Babel, please disable it for node_modules.

Hmm. Disregard my previous comment. I see now you ran npm install in the project itself.

Hey gaeron,
I was running an old version of NodeJS. Updating to the latest version fixed it for me.
Thanks.

This is because build/use-lodash-es.js uses the ES6 method shorthand and is not being transpiled. If the goal is not to be transpiled then it can simply be written in the ES3/5 flavor. If it is to be transpiled then it needs a config tweak.
@gaearon Which one are you wanting?

We should amend Contributing guide to say that we expect Node >= 4 for contributors. If Node 4 doesn’t support the shorthand notation I am happy to accept a fix to use the ES5 syntax.

Cool. cool. Though it seems like that file is the the only stickler at the moment.
Stats:

count	feature_version%age

5580887940.1229.9%

483561869425.9%

227270007512.2%

https://twitter.com/seldo/status/672569831565078528

https://twitter.com/JavaScriptDaily/status/677741377745240064

My guess is it’s more common on developer machines than in production. Individual contributors are also likely to have something like n or nvm. Also React requires Node 4 for contribution (because Jest wants it), and they’re pretty conservative :smile: .
Mainly I just don’t want to break people when something changes in build process because I don’t plan to test the build on Node 0.12 and such.

Mainly I just don’t want to break people when something changes in build process because I don’t plan to test the build on Node 0.12 and such.

Travis makes that p easy. It's your call though, no worries.

What versions do you think is reasonable to support? I’m not sure if tests in examples would run in 0.12 because they use jsdom and I’m not sure which version of Node it requires.

Ah, if it's a mega pain then don't worry about it.
If it was just a line in a travis.yml and using ES5 then I'd say go for it. I support back to Node 0.10 because it's painless. If I ran into roadblocks though I'd start dropping.

On the topic of jsdom would you dig a browser runnable version?

We only use jsdom to help React not crash when initializing but this really has to be fixed in React. We don’t really require jsdom in tests, and I want to drop it when related React issues are fixed (might even be in master).
The reason I like Node-only testing is it’s easier to set up, run on Travis, and people are usually happier with it than with setting up something like Karma.

I personally had troubles with Webpack + Babel 6 on Node 0.12 -- it just hanged on a large app build. Resolved after updating to Node 5.

Babel 6 is known to be slow with npm@2. Not sure if any Nodes currently include npm@3 as a default.

@gaearon

The reason I like Node-only testing is it’s easier to set up, run on Travis, and people are usually happier with it than with setting up something like Karma.

Once you no longer need jsdom I'll hook you up with cross browser testing.

Not sure if any Nodes currently include npm@3 as a default.

Node 5 comes with npm@3

Browser testing sounds great for the core. (To make sure we don’t regress on something silly.) Not sure it makes as much sense for examples. One of the benefits of using React and Redux is you can test both your logic and UI without the browser.


Stores results to local user's temporary directory

Result files are stored to temporary directory.
Case #85

@netspiri Is this a full or partial solution for #85? Can we close #85 with this one?

@guwirth This resolves #85 fully. I will close it.


[Statistics question]: Generating synthetic data

Question:
I would like to generate some synthetic data in a CSV file. The file should have two columns "A" and "B" and 100 numeric values which are normal distributed. A has a mean of 5 and standard deviation of 2. B has a mean of 6 and standard deviation 3. After writing these numbers in the CSV file, also plot histograms of A and B into one plot.
Python Tools

List of Python libraries we should use for answering this:

numpy
scipy
pandas
seaborn

Note: Your images and the text you enter here may be sent to OpenAI's online service where we use a large language model to answer your request.
Do not upload any data you cannot share openly. Also do not enter any private or secret information. By submitting this Github issue, you confirm that you understand these conditions.
Once submitted, @haesleinhuepf will review and consult git-bob, an AI-assistant for suggestions.

git-bob think about this


Remove ops::Not impl's.

Fixes #656.

Thanks for the PR.
This can't actually be deleted yet as it would be a breaking change. It can be flagged as deprecated and scheduled for removal later.
That said, before this is actually deprecated, I'd like to check the repo history to see if there is any info about it when it was added.

Alright. Seems fine to mark as deprecated.

I somehow pushed the wrong code last time, this should only deprecate the impl's, not remove them.

I rebased against master, which includes the CI fix.


Add clearer secrets recommendations

As a lot of our docs mention secrets, particularly the agent docs, I've gone through and added a bunch of links to the new Secrets doc. I've also added some clearer warnings and notes about not printing or exporting your sensitive info from env vars out into scripts/logs.
This will need to go out after #480.
To-do:

[ ] Check draft words for the buildkite-agent artifact upload --help
[ ] Update the actual --help copy in the agent

Integrated all your words suggestions @toolmantim 👍🏻 In the end, I don't think those callouts are needed, it looks fine with them as is.


fix mill build

Related issue: #1291 #1035

Type of change: bug report

Impact: no functional change

Development Phase: implementation
Release Notes
Bug fix for mill build system, original mill has been deprecated since the update of mill.
This implementation use native mill API as much as possible, which can keep better compatibility to which.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

As for accessing by other build.sc, for example there is a project structure in:
|proj
|-chisel3
|-firrtl

we can give a build.sc under proj,
import $file.chisel3.build
import $file.firrtl.build

object myfirrtl extends firrtl.build.firrtlCrossModule("2.12.10") {
  override def millSourcePath = super.millSourcePath / 'firrtl
}

object mychisel3 extends chisel3.build.chisel3CrossModule("2.12.10") {
  override def millSourcePath = super.millSourcePath / 'chisel3
  def firrtlModule: Option[PublishModule] = Some(myfirrtl)
}

object foo extends ScalaModule {
  def moduleDeps = Seq(mychisel3)
}

to make mychisel3 depend on myfirrtl. Then foo can depend on the mychisel3.

Any update for this PR?


Sensors not showing up in Home.app "Add Accessor" or in Elgato.

The sensors appear to be working in homebridge (and in debug), showing the lux/temperature states. These sensors however do not show up in either the Home app for iOS or Elgato when choosing "Add Accessory"
Config file:
"platforms": [
{
"platform": "Hue",
"name": "Sensors",
"host": "<IP_ADDRESS>",
"users": {
"REDACTED": "REDACTED"
},
"heartrate": 5,
"timeout": 5,
"lights": false,
"philipslights": false,
"groups": false,
"sensors": true,
"schedules": false,
"rules": false
},
Log file:
[2/3/2017, 12:08:20 PM] Loaded plugin: homebridge-camera-ffmpeg
[2/3/2017, 12:08:20 PM] Registering platform 'homebridge-camera-ffmpeg.Camera-ffmpeg'
[2/3/2017, 12:08:20 PM] ---
[2/3/2017, 12:08:21 PM] Loaded plugin: homebridge-http
[2/3/2017, 12:08:21 PM] Registering accessory 'homebridge-http.Http'
[2/3/2017, 12:08:21 PM] ---
[2/3/2017, 12:08:21 PM] Loaded plugin: homebridge-hue
[2/3/2017, 12:08:21 PM] Registering platform 'homebridge-hue.Hue'
[2/3/2017, 12:08:21 PM] ---
[2/3/2017, 12:08:21 PM] Loaded plugin: homebridge-legacy-plugins
[2/3/2017, 12:08:21 PM] Registering accessory 'homebridge-legacy-plugins.AD2USB'
[2/3/2017, 12:08:21 PM] Registering accessory 'homebridge-legacy-plugins.Carwings'
[2/3/2017, 12:08:21 PM] Registering accessory 'homebridge-legacy-plugins.ELKM1'
[2/3/2017, 12:08:21 PM] Registering accessory 'homebridge-legacy-plugins.FileSensor'
[2/3/2017, 12:08:21 PM] Registering accessory 'homebridge-legacy-plugins.GenericRS232Device'
[2/3/2017, 12:08:21 PM] Registering accessory 'homebridge-legacy-plugins.HomeMatic'
[2/3/2017, 12:08:21 PM] Registering accessory 'homebridge-legacy-plugins.HomeMaticThermo'
[2/3/2017, 12:08:21 PM] Registering accessory 'homebridge-legacy-plugins.HomeMaticWindow'
[2/3/2017, 12:08:21 PM] Registering accessory 'homebridge-legacy-plugins.HttpGarageDoorOpener'
[2/3/2017, 12:08:21 PM] Registering accessory 'homebridge-legacy-plugins.HttpHygrometer'
[2/3/2017, 12:08:21 PM] Registering accessory 'homebridge-legacy-plugins.HttpThermometer'
[2/3/2017, 12:08:21 PM] Registering accessory 'homebridge-legacy-plugins.Tesla'
[2/3/2017, 12:08:21 PM] Registering accessory 'homebridge-legacy-plugins.X10'
[2/3/2017, 12:08:21 PM] Registering accessory 'homebridge-legacy-plugins.mpdclient'
[2/3/2017, 12:08:21 PM] Registering platform 'homebridge-legacy-plugins.Domoticz'
[2/3/2017, 12:08:21 PM] Registering platform 'homebridge-legacy-plugins.HomeAssistant'
[2/3/2017, 12:08:21 PM] Registering platform 'homebridge-legacy-plugins.HomeSeer'
[2/3/2017, 12:08:21 PM] Registering platform 'homebridge-legacy-plugins.ISY'
[2/3/2017, 12:08:21 PM] Registering platform 'homebridge-legacy-plugins.LIFx'
[2/3/2017, 12:08:21 PM] Registering platform 'homebridge-legacy-plugins.SmartThings'
[2/3/2017, 12:08:21 PM] Registering platform 'homebridge-legacy-plugins.TelldusLive'
[2/3/2017, 12:08:21 PM] Registering platform 'homebridge-legacy-plugins.ZWayServer'
[2/3/2017, 12:08:21 PM] ---
[2/3/2017, 12:08:21 PM] Loaded plugin: homebridge-platform-wemo
[2/3/2017, 12:08:21 PM] Registering platform 'homebridge-platform-wemo.BelkinWeMo'
[2/3/2017, 12:08:21 PM] ---
[2/3/2017, 12:08:21 PM] Loaded plugin: homebridge-readablehttp
[2/3/2017, 12:08:21 PM] Registering accessory 'homebridge-readablehttp.Http'
[2/3/2017, 12:08:21 PM] ---
[2/3/2017, 12:08:21 PM] Loaded plugin: homebridge-wemo
[2/3/2017, 12:08:21 PM] Registering accessory 'homebridge-wemo.WeMo'
[2/3/2017, 12:08:21 PM] ---
[2/3/2017, 12:08:21 PM] Loaded config.json with 0 accessories and 2 platforms.
[2/3/2017, 12:08:21 PM] ---
[2/3/2017, 12:08:21 PM] Loading 2 platforms...
[2/3/2017, 12:08:21 PM] [Sensors] Initializing Hue platform...
[2/3/2017, 12:08:21 PM] [Sensors] homebridge-hue v0.1.14, node v4.2.2, homebridge v2.1
[2/3/2017, 12:08:21 PM] [Sensors] probing bridge at <IP_ADDRESS>
[2/3/2017, 12:08:21 PM] [Sensors] <IP_ADDRESS>: hue bridge request #1: get /config
[2/3/2017, 12:08:21 PM] Initializing Camera-ffmpeg platform...
[2/3/2017, 12:08:21 PM] Front Camera is running on port 54885.
[2/3/2017, 12:08:21 PM] [Sensors] <IP_ADDRESS>: hue bridge request #1: ok
[2/3/2017, 12:08:21 PM] [Sensors] Philips hue: BSB002 bridge, api v1.16.0
[2/3/2017, 12:08:21 PM] [Sensors] Philips hue: hue bridge request #2: get /
[2/3/2017, 12:08:22 PM] [Sensors] Philips hue: hue bridge request #2: ok
[2/3/2017, 12:08:22 PM] [Sensors] Philips hue: 0 lights
[2/3/2017, 12:08:22 PM] [Sensors] Philips hue: 0 groups
[2/3/2017, 12:08:22 PM] [Sensors] Philips hue: Daylight: Daylight sensor
[2/3/2017, 12:08:22 PM] [Sensors] Philips hue: XFDani[1]sn:state: CLIPGenericStatus sensor
[2/3/2017, 12:08:22 PM] [Sensors] Philips hue: XFDani[1][1]sn:step: CLIPGenericStatus sensor
[2/3/2017, 12:08:22 PM] [Sensors] Philips hue: Matt's iPhone 6: Geofence sensor
[2/3/2017, 12:08:22 PM] [Sensors] Philips hue: HomeAway: CLIPPresence sensor
[2/3/2017, 12:08:22 PM] [Sensors] Philips hue: Hue temperature sensor 1: ZLLTemperature sensor
[2/3/2017, 12:08:22 PM] [Sensors] Philips hue: Living Room sensor: ZLLPresence sensor
[2/3/2017, 12:08:22 PM] [Sensors] Philips hue: Hue ambient light sensor 1: ZLLLightLevel sensor
[2/3/2017, 12:08:22 PM] [Sensors] Philips hue: MotionSensor 7.Companion: CLIPGenericStatus sensor
[2/3/2017, 12:08:22 PM] [Sensors] Philips hue: Hue temperature sensor 2: ZLLTemperature sensor
[2/3/2017, 12:08:22 PM] [Sensors] Philips hue: Kitchen sensor: ZLLPresence sensor
[2/3/2017, 12:08:22 PM] [Sensors] Philips hue: Hue ambient light sensor 2: ZLLLightLevel sensor
[2/3/2017, 12:08:22 PM] [Sensors] Philips hue: MotionSensor 11.Companion: CLIPGenericStatus sensor
[2/3/2017, 12:08:22 PM] [Sensors] Philips hue: 13 sensors
[2/3/2017, 12:08:22 PM] [Sensors] Philips hue: 0 schedules
[2/3/2017, 12:08:22 PM] [Sensors] Philips hue: 0 rules
[2/3/2017, 12:08:22 PM] [Sensors] Philips hue: 14 accessories
[2/3/2017, 12:08:22 PM] [Sensors] Initializing platform accessory 'Philips hue'...
[2/3/2017, 12:08:22 PM] [Sensors] Initializing platform accessory 'Daylight'...
[2/3/2017, 12:08:22 PM] [Sensors] Initializing platform accessory 'XFDani[1]sn:state'...
[2/3/2017, 12:08:22 PM] [Sensors] Initializing platform accessory 'XFDani[1][1]sn:step'...
[2/3/2017, 12:08:22 PM] [Sensors] Initializing platform accessory 'Matt's iPhone 6'...
[2/3/2017, 12:08:22 PM] [Sensors] Initializing platform accessory 'HomeAway'...
[2/3/2017, 12:08:22 PM] [Sensors] Initializing platform accessory 'Hue temperature sensor 1'...
[2/3/2017, 12:08:22 PM] [Sensors] Initializing platform accessory 'Living Room sensor'...
[2/3/2017, 12:08:22 PM] [Sensors] Initializing platform accessory 'Hue ambient light sensor 1'...
[2/3/2017, 12:08:22 PM] [Sensors] Initializing platform accessory 'MotionSensor 7.Companion'...
[2/3/2017, 12:08:22 PM] [Sensors] Initializing platform accessory 'Hue temperature sensor 2'...
[2/3/2017, 12:08:22 PM] [Sensors] Initializing platform accessory 'Kitchen sensor'...
[2/3/2017, 12:08:22 PM] [Sensors] Initializing platform accessory 'Hue ambient light sensor 2'...
[2/3/2017, 12:08:22 PM] [Sensors] Initializing platform accessory 'MotionSensor 11.Companion'...
Scan this code with your HomeKit App on your iOS device to pair with Homebridge:
REDACTED
[2/3/2017, 12:08:22 PM] Homebridge is running on port 51826.
[2/3/2017, 12:08:23 PM] [Sensors] Philips hue: hue bridge request #3: get /
[2/3/2017, 12:08:23 PM] [Sensors] Philips hue: hue bridge request #3: ok
[2/3/2017, 12:08:25 PM] Got SIGINT, shutting down Homebridge..

They're not supposed to.  Homebridge bridges the sensors (and any other resources) exposed by homebridge-hue (or other plugins). You cannot add (or remove) these accessories individually, they appear automatically in the default room when you add (or previously added) the homebridge bridge accessory to HomeKit.
I don't have any experience with legacy plugins, but I understand homebridge used to expose their accessories separately (unbridged), requiring each accessory to be added separately.


Can't build app with 7.0.0 (incomplete shouldShowInAppMessagesAutomatically and showStoreMessages)

I get three error messages with the following version (from Podfile.lock) when I want to build the app:

PurchasesHybridCommon (7.0.0):

RevenueCat (= 4.27.0)

RevenueCat (4.27.0)
RevenuecatPurchasesCapacitor (7.0.0):

Capacitor
PurchasesHybridCommon (= 7.0.0)

Error messages:
/path/ionic-pods/purchases-capacitor/ios/Plugin/PurchasesPlugin.swift:43:83 Extra argument 'shouldShowInAppMessagesAutomatically' in call
/path/ionic-pods/purchases-capacitor/ios/Plugin/PurchasesPlugin.swift:356:37 Type 'CommonFunctionality' has no member 'showStoreMessages'
/path/ionic-pods/purchases-capacitor/ios/Plugin/PurchasesPlugin.swift:360:37 Type 'CommonFunctionality' has no member 'showStoreMessages'

Hi @BigBerny, those error messages seem to indicate you're using an old version of our PurchasesHybridCommon pod after upgrading to version 7.0.0. Unfortunately, I wasn't able to reproduce.
I'm not sure what platform you're running on, but could you try to find the Podfile in your iOS source code and run pod update to see if it updates to the latest version?
If that doesn't work, please share the resulting logs from running that and the relevant parts of your Podfile.lock file if possible.

@tonidero I was running into the same issue. Your suggestion on updating the podfile worked for me.

Same for us. Was an issue with using an outdated Podfile. 👍


Nag for deprecation of TaskActionListener

This issue is about adding nagging by default. As in, even when the STABLE_CONFIGURATION_CACHE feature preview is not enabled.
This should happen in 8.1 with a message that says it will become an error in 9.0.

If this is asking about deprecating Gradle.addListener(...) with a TaskActionListener, that is being done by #30000.

There is no replacement yet.


In search results, show if a question is explore mode or not

Hi @christianp ,
I have submitted the pull request - #685 for this issue. Kindly let me know if any thing is required from my side. Thanks in advance!


dexie-syncable won't install over npm/jspm due to incorrect dependency

PS> jspm install npm:dexie-syncable
     Looking up npm:dexie-syncable
     Updating registry cache...
     Looking up npm:dexie
     Looking up npm:dexie-observable

err  Installing<EMAIL_ADDRESS>no version match for<EMAIL_ADDRESS>
warn Installation changes not saved.
PS> jspm inspect npm:dexie-observable

     Installed versions of npm:dexie-observable

       dexie-observable 0.1.3 (^0.1.3)

PS> jspm inspect npm:dexie

     Installed versions of npm:dexie

       dexie 1.3.3 (^1.3.3)

Not sure what the ~0.8.0 is all about since observable is 0.1.3?

Ok. In package.json, i've specified the range ">=0.1.0 <0.9.0" for dexie-observable, which would try the latest version between 0.1.0 but below 0.9.0. Don't understand why jspm interprts that as 0.8.0. Probably need to use a simpler range.
There's also another issue with JSPM and the addons I need to fix in package.json. Will fix asap.

So, try reinstall the addons (both of versions 0.1.4 now).

Simplified dependency semver
Added "format": "esm" in package.json's jspm element.

Thanks! I'll check now...


Replace 'URL [URL...]' with ... from usage description

Please follow the guide below

You will be asked some questions, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your pull request (like that [x])
Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

[x] Searched the bugtracker for similar pull requests
[ ] Read adding new extractor tutorial
[ ] Read youtube-dl coding conventions and adjusted the code to meet them
[ ] Covered the code with tests (note that PRs without tests will be REJECTED)
[ ] Checked the code with flake8

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

[x] I am the original author of this code and I am willing to release it under Unlicense
[ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

[ ] Bug fix
[x] Improvement
[ ] New extractor
[ ] New feature

Description of your pull request and other information
The current command  could potentially read as youtube-dl URL https://youtube.com/something should be a valid usage when it actually needs to be youtube-dl https://youtube.com/something.

If there's only [URL...], it means "there can be at least 0 URL's to download something". <URL...> would fix it to mean "there can be at least 1 URL to download something".

It seems that italics may be more standard than <>: https://man7.org/linux/man-pages/man1/man.1.html

Fair enough.

I personally prefer <URL> as well but I don't think so that anyone would mistake it with the current syntax.
And even if anyone does,
youtube-dl URL https://youtube.com/something SHOULD still work as it will simply spit out that URL is not a valid url.

youtube-dl URL https://youtube.com/something SHOULD still work as it will simply spit out that URL is not a valid url.

Ya, it will.

but I don't think so that anyone would mistake it with the current syntax.

I did 😅
It's true that you get a warning but I think it would be nice if it were clear what should be replaced with an argument and what should be there as-is

It seems that italics may be more standard than <>: https://man7.org/linux/man-pages/man1/man.1.html

Not so standard that they aren't displayed as underlined text instead in a Linux console!


Count unread teams in team sidebar

Before submitting, please confirm you've

[x] read and understood our Contributing Guidelines
[x] completed Mattermost Contributor Agreement
[x] executed npm run lint:js for proper code formatting

Please provide the following information:
Summary
Support unread indications in team sidebar of Mattermost server 3.6

Issue link
#409
Test Cases

Create multiple teams in the same server.
Get messages in a team where you don't see.

Additional Notes
Tested on Windows 10. This PR just changes a unread counting only, so the feature should work also on other platforms.
Currently teams are counted as "channels" on Windows.
This should be improved in future refactoring because internal parameters of the app would become very complicated.

Testable binaries are availbale here. https://circleci.com/gh/yuya-oc/desktop/131#artifacts

Thanks @yuya-oc! Tested on Windows 10 and works great.

Currently teams are counted as "channels" on Windows.

The system tray icon counted the correct number of channels for me -- said I have 22 unread channels and that seemed to be correct when I reviewed all my tabs (and teams).
What did you mean by teams being counted as channels?

In my first screenshot, the state is below:

team1

there are unread messages.

team2

unread channels: 0
unread mentions: 0

result:

unread channels: 1

The counting is based on DOM scraping, so the app can't know about team1 in detail. As the result, I just counted the number of teams which have unread messages in team sidebar.

Ah I see - yes, I see that know.
Should we then change it to X unread team(s) and add an improvement ticket to count the number of channels later?

For now, we should keep "channels" because it's actually counted.
And yes, please make a ticket. To count unread channels about inactive teams, API should be used. But I don't have good idea to query APIs for now. I feel that simple/stupid polling is not good for server load.

Thanks @yuya-oc! Created a ticket here: https://github.com/mattermost/desktop/issues/417

Thanks @jasonblais!


--input asks same questions multiple times

This is my cookicutter.json
{
  "author": "Tomasz Pluskiewicz",
  "email"<EMAIL_ADDRESS>  "project_name": "Hypermedia App",
  "app_name": "rhodos",
  "organization": "{{ cookiecutter.app_name }}",
  "api_names": "core,users",
  "repository": "https://github.com/your/repo",
  "node_version": "14"
}

I used an earlier version to generate a project which gave me this .cruft.json
{
  "template": "https://github.com/hypermedia-app/hypermedia.app",
  "commit": "4d0fd8e55e266f9e319c13778e9714dd376a62bb",
  "checkout": null,
  "context": {
    "cookiecutter": {
      "author": "wikibus.org",
      "email"<EMAIL_ADDRESS>      "project_name": "wikibus.org",
      "app_name": "wikibus",
      "organization": "wikibus",
      "api_names": "core,users",
      "repository": "https://github.com/wikibus/wikibus",
      "_template": "https://github.com/hypermedia-app/hypermedia.app",
      "apis": [
        "core",
        "users"
      ]
    }
  },
  "directory": null
}

Now, when I run cruft update -i, it asks for some variables multiple times
>  git:(master) cruft update -i
author [wikibus.org]:
email<EMAIL_ADDRESS>
project_name [wikibus.org]:
app_name [wikibus]:
organization [wikibus]:
api_names [core,users]:
repository [https://github.com/wikibus/wikibus]:
author [wikibus.org]:
email<EMAIL_ADDRESS>
project_name [wikibus.org]:
app_name [wikibus]:
organization [wikibus]:
api_names [core,users]:
repository [https://github.com/wikibus/wikibus]:
node_version [14]: 16
Respond with "s" to intentionally skip the update while marking your project as up-to-date or respond with "v" to view the changes that will be applied.
Apply diff and update? (y, n, s, v) [y]:

You will notice that node_version was added but I think it's a red herring


How to animate a single image?

Great work!
I am wondering how to reproduce the Row4 of Figure 2 in the main paper.
Could you please give me some advice?
Do we need inversion latents of the reference video in this case?

Thanks for your interest. The code will be released.

Thanks for your interest. The code will be released.

Please tell us do you have any plans to release the code?
Thank you!

Yes. We are cleaning the code and preparing for appearance customization. We plan to release the code next week. Please stay tuned.

Hi. The code has been released. Please refer to the link for instructions.


[LOC] "_gt" needs to be replaced with ">" (ja-jp)

https://docs.microsoft.com/ja-jp/officeonlineserver/apply-software-updates-to-office-online-server

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7182ae01-c978-29fc-6fcf-52f60fa59aad
Version Independent ID: e2dfe89c-59e7-8e32-ee18-e0b346527b43
Content: Apply software updates to Office Online Server
Content Source: OfficeOnlineServer/apply-software-updates-to-office-online-server.md
Product: office-online-server
GitHub Login: @lorenahuangliu
Microsoft Alias: lohuan

Fixed.
Close #39