Complete review of all tags

Move some links to the index pages
Add image to LFR model

Job VTB Documentation, step Sync Docs on 78d256a wanted to post the following:
View the site here
This comment will be updated on new commits.


core-static is not found

Hi there,
This drives me crazy.
I'm somehow stucked.
So thank you very much for you work, great!
However when I run it, and call the cat, the Login Screen doesn't show the right css / logo.
In Dev Tools I see that the URL is not available: https://cheshire-cat-core/core-static/img/logo.svg
I don't get it why.
Here is my Compose of the cat:
    env_file:
       - .env
    extra_hosts:
      - "host.docker.internal:host-gateway"
    environment:
      # Timezone
      - CCAT_CORS_FORWARDED_ALLOW_IPS="*"
      - CCAT_CORE_HOST=localhost
      - CCAT_CORE_PORT=1865
      - CCAT_QDRANT_HOST=cheshire-cat-vector-memory
      - CCAT_QDRANT_PORT=6333
      - CCAT_CORE_USE_SECURE_PROTOCOLS=false

And here the variable I set via .env File:
# Decide to use https / wss secure protocols
CCAT_CORE_USE_SECURE_PROTOCOLS=true

# Uvicorn and FastAPI operating behind https proxy
CCAT_HTTPS_PROXY_MODE=true

Thy Nginx is part is working fine.
Here the Conf:
server {
    listen  80;
    listen 443 default_server ssl;

    listen  [::]:80;

    server_name  localhost;
    client_max_body_size 3000M;

    ssl_certificate /etc/nginx/ssl/nginx.crt;
    ssl_certificate_key /etc/nginx/ssl/nginx.key;

    location / {
        proxy_pass http://cheshire-cat-core/;
    }

    location /ws {
        proxy_pass http://cheshire-cat-core/ws;
        proxy_http_version 1.1;
        proxy_set_header Upgrade $http_upgrade;
        proxy_set_header Connection "Upgrade";
        proxy_set_header Host $host;
    }
}

What do I miss?

So I cloned your Repo, same issue.

Hi @dell1503, sorry for my late reply.
The login page is something rendered by your browser and your browser is running in localhost.
To avoid in your machine this problem you could edit your /etc/hosts file with this line of code:
<IP_ADDRESS> cheshire-cat-core

So in this way you can resolve the host used for the assets (and for sure other stuff) with localhost.
Let me know pls if this can help you ;-)


Not able to detect the simulator model version

Hello,
When running the application on the simulator I get wrong values such as:
Xamarin.iOS.DeviceHardware.Version => x64
Xamarin.iOS.DeviceHardware.Model => Simulator
However, we don't have all physical phones for testing so we use the simulators. Is it possible to return on simulators the model used for testing? For example: "iPhone X, Simulator" appending the word simulator at the end of it? only when simulator or something different.
Thanks in advance for the amazing work,
Victor

Hi @vhugogarcia the problem is that it doesn't return a hardware string (ex. iPad6,12) to identify the model, we instead get i386 or x86_64 in return. Will check into what else can be done to identify it. Good suggestion by the way.

Thanks @dannycabrera That would be really helpful for us developers.
Thanks again for your work on this library it is really good.

You can query for ProcessInfo().environment["SIMULATOR_MODEL_IDENTIFIER"]. The model identifiers match the ones returned by hardware, eg iPhone X is iPhone10,3.

Huge thanks @russbishop, will get that added here shortly.

Thanks everyone. Code change applied version bumped to 1.3 and pushed to Nuget.


Is this a typo in documents?

In this website http://www.mybatis.org/mybatis-3/configuration.html#properties, I'm not sure whether it is a typo, diplayed as follow. I think it should be replaced by SqlSessionFactoryBuilder.
Snapshot:

@ShawnyXiao Thanks for your reporting !
It's typo. We should be change to the SqlSessionFactoryBuilder.


Adds Jasmine tests to owner.controller.js

https://www.hawaii.edu/jira/browse/GROUPINGS-1086
Groupings-1086
Test Checklist

[x ] Unit Tests Passed:
[x ] Jasmine Tests Passed:
[x ] General Visual Inspection:

Only codacy test failing is the 'inject' not being defined

Have you considered this syntax?
/global inject/
As mentioned by the codacy examples?

Have you considered this syntax? /global inject/ As mentioned by the codacy examples?

Right let me try again, I think may have done this for my previous test pushed.

Seems like removing the 'a' from the global inject statement still ignores the codacy issue. I can go ahead and merge this changes now.

-Rebased and pushed recent UI merges


[Packager] Resolve assets based on platform.

So i have image named js_l1_icon on ios and android. While loading the image on ios, it is picked up the same image from android which is having a different height, width than what i expect on ios.
I just added a console.log generateAssetModule_DEPRECATED from Bundler and the path seems to be of android.
{ __packager_asset: true,
isStatic: true,
path: '/Users/chirag/Desktop/lrn/lrn/android/app/src/main/res/drawable-hdpi/js_l1_icon.png',
uri: 'js_l1_icon',
width: 72,
height: 72,
deprecated: true }
cc @amasad (going by commits in bundler/index.js)

I think this should to be fixed when we ship the new asset system.

FYI, I'm using the master branch. Any ETA for the new asset system to land on master?

No ETA yet but it's being worked on :)

Haha..can't believe i really asked for an ETA here. I guess i just wanted to ask casually. Thanks for the reply. I will wait for it.

:)

@frantic closing this one in favor of the new asset system.


fix(guide): typos and change truthy to falsy

A variable declared without a value, will be undefined, therefore it is falsy, not truthy (the example could have been pasted badly). Also changed falsey to falsy and added '' as another way to declare an empty string.

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

LGTM
both are used pretty interchangeably:
https://english.stackexchange.com/questions/109996/is-it-falsy-or-falsey


[Issue #494] Remove Edit/Delete from Canonical Items

Resolves #494
Description

Removed Edit and Destroy paths from Canonical Items
Removed button to edit Canonical Items
Added test for verifying path doesn't work

Type of change

New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Attempt to access /canonical_items/#{item.id}/edit should raise error

Wow! Awesome turn around speed on this!
I think I may have described the problem poorly in my issue though. @armahillo's PR addresses the adding/editing/etc of canonical items. What I was trying to convey was that items that are canonical items shouldn't be delete or editable.
When we create a diaper bank, we initially seed them with some canonical items, you can see that here. What we want is to make those initial 35 items non-changeable. The reason is that when a request from a partner organization comes in they query by set canonical names and if those names have changed then they won't find the items.
I'm so sorry for not being less clear than I thought. I'm happy to answer questions in slack if you have them.

@seanmarcia So…I think I understand. Basically, we need some sort of bool property on these initial 35 items that is a 'noneditable' flag and then adjust from there?


[v56] cause framerate lagging with no any log when playing in v56

@jake-white is my first time send feedback in here, although i already want to send more issues about this mod, like always maximum flood when doing solo and throwing error (i guess that fixed?);
but now in v56, seems that conflict with new monster, so maybe u should check that out

ok i guess i also have this issue: #7


IAP: Typescript support

What it takes to export types behind JAVA bindings in IAP?

I got as far as here. Perhaps it will help someone.
declare module '@hmscore/react-native-hms-iap' {
    interface CreatePurchaseIntentOptions {
        priceType: any
        productId: string
        developerPayload: any
    }

    interface ObtainProductInfoResult {
        productInfoList: ProductInfo[]
    }

    export interface ProductInfo {
        c: string
        j: 'P1M' | 'P1Y'
        a: string
    }
    interface ObtainOwnedPurchasesOptions {
        priceType: string
    }

    interface ObtainOwnedPurchasesResult {
        inAppPurchaseDataList: string[]
    }

    class Module {
        static PRICE_TYPE_IN_APP_SUBSCRIPTION: any
        static createPurchaseIntent(
            options: CreatePurchaseIntentOptions,
        ): Promise<any>
        static obtainProductInfo(options: any): Promise<ObtainProductInfoResult>

        static obtainOwnedPurchases(
            options: ObtainOwnedPurchasesOptions,
        ): Promise<ObtainOwnedPurchasesResult>
    }

    export default Module
}

Hello @RobertSasak thank you for your contribution.


Different Style/color depending on node.nodeType

Hi,
Thanks for this Tree-Control.
I'm having a bad day and need some help. I want to apply a different color to a group depending on Group type. the Group Type is returned from the server under node.nodeType
the nodeType is either 1, 2, 3 or 4
I need to apply a different color when the nodeType == 1 , different for nodeType == 2 and so on.
Is this possible using the Tree config options?
Kind Regards
Dawood Awan

I think you can do that using a node template. Use ng-class in the template
with condition on node type and have the type icon as part of the template.
(Use the tree icons for just open close icons - [+] [-]
On Wed, Aug 24, 2016, 6:03 PM Dawood Awan<EMAIL_ADDRESS>wrote:

Hi,
Thanks for this Tree-Control.
I'm having a bad day and need some help. I want to apply a different color
to a group depending on Group type. the Group Type is returned from the
server under node.nodeType
the nodeType is either 1, 2, 3 or 4
I need to apply a different color when the nodeType == 1 , different for
nodeType == 2 and so on.
Is this possible using the Tree config options?
Kind Regards
Dawood Awan
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/wix/angular-tree-control/issues/248, or mute the
thread
https://github.com/notifications/unsubscribe-auth/ABDlJ3HJ3GAw-n9B5iM4qy5XJbmB0my0ks5qjF0qgaJpZM4JsGzM
.

This is what I trie:

but the tree doesn't expand any more when I click on the node

you dropped the headClass logic in your ng-class attribute of li. The problem you see is caused because headClass adds the classes tree-leaf, tree-expanded and tree-collapsed classes as well as an optional selection class (from the options.liSelected option).
The tree-expanded and tree-collapsed classes place the display:none and display:block on the li element. Because you do not place those classes anymore, no-one is placing the display CSS and the tree does not expand anymore.


🎨 New Component: Ams Date Selector

Overview
In definition, we use "Ams Date Selector" (different from the definition of Ams Date Picker) to represent the floating selector of a date picker, which is a floating modal, having a list view to select the year, a calendar view to pick the date, and a scroll/drag view to select the time. We are using this new component to replace the old MUI static date picker, which is complicated, buggy, and test-unfriendly.
Feature Checklist

[ ] Popover provider.
[ ] Date/time section switch.
[ ] Year selection.
[ ] Year selection input.
[ ] Month selection.
[ ] Month selection input (with month+day input support).
[ ] Time selection (hour, minute, and second).
[ ] Time selection input.
[ ] Integrate with headless input component.

Design

For v0.0.1, it will be the headless version only. For v0.0.2, it will be the complete version.


fix(FieldWrapper): switch from Field to InputField to pass status

FX-2631
Description

I switched the underlying field component to InputField. Because Field wasn't able to pass status to its children
added test to cover this case

How to test

you can play with the new story under Form page on Picasso

Screenshots

Before.
After.

Review

[ ] Read CONTRIBUTING.md and Component API principles
[ ] Annotate all props in component with documentation
[ ] Create examples for component
[ ] Ensure that deployed demo has expected results and good examples
[ ] Ensure that tests pass by running yarn test
[ ] Ensure that visuals tests pass by running yarn test:visual. If not - check the documentation how to fix visual tests
[ ] Ensure the changed/created components have not caused accessibility issues. How to use accessibility plugin in storybook.

PR commands

List of available commands:

@toptal-bot run all - Run whole pipeline
@toptal-bot run build - Check build
@toptal-bot run visual - Run visual tests
@toptal-bot run deploy:documentation - Deploy documentation
@toptal-bot run package:alpha-release - Release alpha version

PR Review Guidelines

When to approve? ✅
You are OK with merging this PR and

You have no extra requests.
You have optional requests.

Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌
You are not OK with merging this PR because

Something is broken after the changes.
Acceptance criteria is not reached.
Code is dirty.

When to comment (neither ✅ nor ❌)
You want your comments to be addressed before merging this PR in cases like:

There are leftovers like unnecessary logs, comments, etc.
You have an opinionated comment regarding the code that requires a discussion.
You have questions.

How to handle the comments?

An owner of a comment is the only one who can resolve it.
An owner of a comment must resolve it when it's addressed.
A PR owner must reply with ✅ when a comment is addressed.

Currently getting [Object object] upon submission. Is this expected? :thinking: I thought I should see the value, not the object.

Currently getting [Object object] upon submission. Is this expected? thinking I thought I should see the value, not the object.

I see that more items on the page suffer from the same.
You can ignore the previous comment. I'll add a low priority improvement ticket in tech debt. :smile:

Currently getting [Object object] upon submission. Is this expected? thinking I thought I should see the value, not the object.

I see that more items on the page suffer from the same. You can ignore the previous comment. I'll add a low priority improvement ticket in tech debt. 😄

I would fix that. It's not hard to fix, but would improve DX a lot. I also noticed that and it felt awkward

Currently getting [Object object] upon submission. Is this expected? thinking I thought I should see the value, not the object.

I see that more items on the page suffer from the same. You can ignore the previous comment. I'll add a low priority improvement ticket in tech debt. 😄

I would fix that. It's not hard to fix, but would improve DX a lot. I also noticed that and it felt awkward

I agree 👍 This version is pointless. So, @separatio do you want to handle it or do you let me do it? I'm talking about a separate PR to handle all these usages

@ozgurkececioglu Go ahead and fix it in a separate PR. It should be pretty fast.

I have already created the ticket here: https://toptal-core.atlassian.net/browse/FX-2635


Incomplete Example for GetSubnetsFilter

File: themes/default/content/registry/packages/aws/api-docs/ec2/getsubnets/_index.md
Name, use:
then nothing

We do show the examples under use: now:


Azure lab services advanced networking: vnet injection in other subscription

The pages states:
Create a virtual network. The virtual network must be in the same region as the lab plan.
My question: Should the virtual network be in the same subscription as the azure lab as well? Or isn't that a requirement?
From the limited tests I did, it seems to be a requirement?

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 37f118af-59e9-03f9-8b56-6ff6aa2792a3
Version Independent ID: ccbd5b09-fe1e-0b55-2170-06b6ed0e02cc
Content: Connect to your virtual network in Azure Lab Services - Azure Lab Services
Content Source: articles/lab-services/how-to-connect-vnet-injection.md
Service: lab-services
GitHub Login: @ntrogh
Microsoft Alias: nicktrog

@bartvermeersch
Thanks for bringing this to our attention.
I'm going to assign this to the document author so they can take a look at it accordingly

@ntrogh
Can you please check and add your comments on this doc update request as applicable.

@bartvermeersch Thanks a lot for reaching out! The only requirement when attaching a VNet to a Lab Plan is that it needs to be in a subscription as part of the same AAD tenant (can be a different subscription) and the user creating the lab plan must have “Subnet/Join” access to that subscription.
The Azure portal only shows VNETs in the same subscription. To use another subscription, you can use ARM or CLI to create the Lab Plan.
We'll make sure that the docs reflect this information.

Thank you for the info!

#please-close

@ntrogh I also had to grant permissions to a service principal called Azure Lab Services on the subnet since I received an error:
Lab Services does not have permissions to access resource with ID '/subscriptions/.../resourceGroups/.../providers/Microsoft.Network/virtualNetworks/.../subnets/...'.
Make sure 'Azure Lab Services' principal has access to the resource and try again
There are two service principals with the same name on my tenants:
Azure Lab Services: c7bb12bf-0b39-4f7f-9171-f418ff39b76a
Azure Lab Services: 1a14be2a-e903-4cec-99cf-b2e209259a0f
I assumed the first one corresponds with the new labs since August?
After giving network contributor permissions to both, I'm still blocked with another error "The subnet provided is not delegated to Microsoft.LabServices" while it is delegated (confirmed in the GUI and via CLI)
vnet creation:
resource azurelabsvnet 'Microsoft.Network/virtualNetworks@2022-05-01' = {
  name: 'azurelabs-vnet'
  location: location
  properties: {
    addressSpace: {
      addressPrefixes: [
        '<IP_ADDRESS>/22'
      ]
    }
    subnets: [
      {
        name: 'azurelabs-snet'
        properties: {
          addressPrefix: '<IP_ADDRESS>/24'
          delegations: [
            {
              name: 'Microsoft.LabServices/labplans'
              properties: {
                serviceName: 'Microsoft.LabServices/labplans'
              }
            }
          ]
        }
      }
    ]
  }
}

resource labPlanResource 'Microsoft.LabServices/labPlans@2022-08-01' = {
  name: labPlanName
  location: location
  properties: {
    allowedRegions: labCreationAllowedRegions
    defaultAutoShutdownProfile: {
      shutdownOnIdle: 'LowUsage'
      idleDelay: 'PT15M'
      shutdownOnDisconnect: 'Enabled'
      disconnectDelay: 'PT0S'
      shutdownWhenNotConnected: 'Enabled'
      noConnectDelay: 'PT15M'
    }
    defaultNetworkProfile: {
      subnetId: resourceId('<GUID>','azurelabs-rg','Microsoft.Network/virtualNetworks/subnets', 'azurelabs-vnet', 'azurelabs-snet')
      }
  }

az network vnet subnet show

...  "delegations": [
    {
      "actions": [
        "Microsoft.Network/virtualNetworks/subnets/join/action"
      ],
      "etag": "W/\"...\"",
      "id": "/subscriptions/.../resourceGroups/.../providers/Microsoft.Network/virtualNetworks/.../subnets/.../delegations/Microsoft.LabServices/labplans",
      "name": "Microsoft.LabServices/labplans",
      "provisioningState": "Succeeded",
      "resourceGroup": "...",
      "serviceName": "Microsoft.LabServices/labplans",
      "type": "Microsoft.Network/virtualNetworks/subnets/delegations"
    }
  ],
...  "type": "Microsoft.Network/virtualNetworks/subnets"
}

@bartvermeersch thanks for reporting - I'll check with the engineering team.
In the meantime, I'll reopen this issue.
#please-open

Hi @bartvermeersch - I just gave this a try and it appears to be working for me.  I deployed a Lab Plan using an ARM template, see below.
I would guess that maybe the Azure Lab Services resource provider isn't registered in the subscription containing the subnet?  The doc for that is here: https://learn.microsoft.com/en-us/azure/azure-resource-manager/management/resource-providers-and-types#register-resource-provider , you should ensure that "Microsoft.LabServices" is registered in the subscription.  If that's already registered, I think we need to dig deeper - would you be able to open an Azure Support ticket for help?
Thanks!
~Pete  [ MSFT ]
{
    "$schema": "https://schema.management.azure.com/schemas/2019-04-01/deploymentTemplate.json#",
    "contentVersion": "<IP_ADDRESS>",
    "parameters": {},
    "variables": {},
    "resources": [
        {
            "type": "Microsoft.LabServices/labPlans",
            "apiVersion": "2022-08-01",
            "name": "LabPlan-CrossSubNetwork",
            "location": "southcentralus",
            "properties": {
                "defaultAutoShutdownProfile": {
                    "shutdownOnDisconnect": "Enabled",
                    "shutdownWhenNotConnected": "Enabled",
                    "shutdownOnIdle": "LowUsage",
                    "disconnectDelay": "PT0S",
                    "noConnectDelay": "PT15M",
                    "idleDelay": "PT15M"
                },
                "defaultNetworkProfile": {
                    "subnetId": " <<subnet resource id>>"
                },
                "allowedRegions": [
                    "southcentralus"
                ]
            }
        }
    ]
}

Hi @petehauge thank you!
Microsoft.LabServices wasn't registered in the other subscription. I'll check the entire deployment again after the weekend and let you know if it is solved.
It would be helpful if it is stated as a requirement or surfaced in the error message.
This seems a relevant discussion as well for this issue: https://github.com/Azure/bicep/issues/3267

Registering the azure lab services in the VNET subscription didn't resolve the issue. I'll open a service ticket.

Sounds good @bartvermeersch  - thanks for the heads-up!

OK I figured it out, I had to reapply the delegation on the subnet after manually registering Microsoft.LabServices on the VNET subscription.
So the root cause was indeed the missing RP on the subscription, which would have been covered if the bicep had registered it properly.

Oh, great, thanks for the update @bartvermeersch!  @ntrogh - we should add this note to the documentation if possible, when using a subnet from another subscription, ensure that the labs RP is registered in that subnet before getting started...
Thanks!
Peter Hauge [msft]


Revert "Mitigate CVE-2020-15250 and CVE-2020-13956"

Reverts corona-warn-app/cwa-server#914

As an outsider it is unclear to me why this got reverted. May you elaborate please?


Please update this SDK latest version.

Please update this SDK latest version.

Would love that too

still no update? strange

Please update ARCore for Unreal the latest is 4.23 and available new 4.24 Unreal Engine version.

Now you should use open xr, they are leaving this pluggin in order to fully support open xr.

Now you should use open xr, they are leaving this pluggin in order to fully support open xr.

That doesn't help anyone..
An update to this plugin would be incredibly helpful

Now you should use open xr, they are leaving this pluggin in order to fully support open xr.

The problem is that not all functionalities that ARCore provides are integrated in Open XR. For example; the Cloud Anchoring system for Android Devices from ARCore isn't supported in Unreal through Open XR or another framework. Or am I wrong? :/


No colors in task terminal

Issue Type: Bug
Simple c code.
Run build task with clang or cl.
In task terminal no colored output, but in ordinary terminal all fine.

VS Code version: Code 1.69.1 (b06ae3b2d2dbfe28bca3134cc6be65935cdfea6a, 2022-07-12T08:21:24.514Z)
OS version: Windows_NT x64 10.0.19044
Restricted Mode: No
Extensions (3)

Extension
Author (truncated)
Version

cmake-tools
ms-
1.11.26

cpptools
ms-
1.10.8

cmake
twx
0.0.17

(1 theme extensions excluded)

This issue is caused by an extension, please file it with the repository (or contact) the extension has linked in its overview in VS Code or the marketplace for VS Code. See also our issue reporting guidelines.
Happy Coding!

Please, note:
https://github.com/microsoft/vscode-cpptools/issues/9643

@meganrogge Note that this is not caused by the extension.  Rather, something VS Code is doing with the task terminal is preventing compilers (gcc and clang) from detecting that they are in a shell terminal, causing them to disable colorized output.  We can work around the problem by passing command line arguments that force gcc and clang (separately) to enable colorized output.  However, the underlying issue is with VS Code.  Please consider re-opening and addressing the issue in VS Code.

@Colengms thanks for the info. I'm not very familiar with how gcc and clang work, but what are those using to detect that they are in a shell terminal? environment variables?

The code for gcc and clang are available online.
For GCC, I see: https://code.woboq.org/gcc/gcc/diagnostic-color.c.html
It looks like GetConsoleMode() and isatty() are being used to detect the terminal capabilities.
For Clang, I'm not sure.  I just did a quick search, and see similar functionality in:
https://github.com/llvm/llvm-project/blob/main/llvm/lib/Support/Windows/Process.inc
https://github.com/llvm/llvm-project/blob/main/llvm/lib/Support/Unix/Process.inc
i.e. Calls to GetConsoleMode() and isatty() in FileDescriptorIsDisplayed

@Colengms can you link where cppbuild type tasks launch the shell?

Hi @Tyriar .  It looks like cpptools is calling spawn to create this process, so the cause is indeed in cpptools.  You can close this issue.
It looks like the correct solution is for cpptools to use node-pty (which VS Code uses internally) to spawn a process with a pseudo-terminal.  It looks like that would require us to always build the TypeScript component on the target platform, which we're not currently doing.  I'm tracking that with: https://github.com/microsoft/vscode-cpptools/issues/9681

@Colengms I'm not too familiar with how tasks interact with extensions, is it possible to launch a regular shell terminal instead? I think this is how the npm tasks would work since they have color

Nothing to verify?


Add eslint

Hey, pretty nice package! I've added ESLint+Prettier for you so you can keep your code formatting in check, especially with multiple contributors :)

Great, thanks!


[SPARK-21644][SQL] LocalLimit.maxRows is defined incorrectly

What changes were proposed in this pull request?
The definition of maxRows in LocalLimit operator was simply wrong. This patch introduces a new maxRowsPerPartition method and uses that in pruning. The patch also adds more documentation on why we need local limit vs global limit.
Note that this previously has never been a bug because the way the code is structured, but future use of the maxRows could lead to bugs.
How was this patch tested?
Should be covered by existing test cases.

cc @JoshRosen

Test build #80275 has started for PR 18851 at commit 9911176.

Test build #80275 has finished for PR 18851 at commit 9911176.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80275/
Test FAILed.

Looks like the strip global limit is used by at least some test cases.

retest this please

Test build #82285 has started for PR 18851 at commit 9911176.

Test build #82285 has finished for PR 18851 at commit 9911176.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82285/
Test FAILed.


[ros2] rosdep behaves differently on urdfdom_headers

As bootstrapping the dependencies of srdfdom for ROS2, rosdep is used to resolve and install the external dependencies.
However, we noticed that the rosdep treated the urdfdom_header differently than other ROS2 packages. On Linux, we saw that instead of solving it from the ROS package list in the workspace, rosdep fallback to look for Debian package, even when the urdfdom_headers already existed in ROS2 tree.

On Windows, it will render as an error like below:
srdfdom: No definition of [urdfdom_headers] for OS [windows]

Expected Behavior
The urdfdom_headers should work like other ROS2 packages and can be discovered by rosdep if it is already in ROS2 tree.

The same issue was observed for control_msgs and eigen_stl_containers


Conversion to TFLite model does not work -error

Please make sure that this is a bug. As per our GitHub Policy, we only address code/doc bugs, performance issues, feature requests and build/installation issues on GitHub. tag:bug_template
System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): Yes (but, from example at taken from https://colab.research.google.com/github/tensorflow/examples/blob/master/courses/udacity_intro_to_tensorflow_for_deep_learning/l05c02_dogs_vs_cats_with_augmentation.ipynb)
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Windows 10
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device:No
TensorFlow installed from (source or binary):
TensorFlow version (use command below):  2.0.0
Python version: 3.6.1  (via Jupyter notebook)
Bazel version (if compiling from source):
GCC/Compiler version (if compiling from source):
CUDA/cuDNN version:
GPU model and memory:

You can collect some of this information using our environment capture
script
You can also obtain the TensorFlow version with: 1. TF 1.0: python -c "import tensorflow as tf; print(tf.GIT_VERSION, tf.VERSION)" 2. TF 2.0: python -c "import tensorflow as tf; print(tf.version.GIT_VERSION, tf.version.VERSION)"
Describe the current behavior
I can save the tensorflow keras model to an h5 file but, when subsequently try to convert to TFLite using code below it fails.   Following directions at https://www.tensorflow.org/tutorials/keras/save_and_load  to perform conversion to TFLite (see code below)
Describe the expected behavior
Should save a TFLite file after conversion
Code to reproduce the issue
Provide a reproducible test case that is the bare minimum necessary to generate the problem.
`tflite_file  = os.path.join(BASE_DIRECTORY, 'my_tflite_model.h5')
print(" want to save tflite_file" + tflite_file)
Convert the model.
converter = tf.lite.TFLiteConverter.from_keras_model(model)
print("converter = " + str(converter))
tflite_model = converter.convert()
#no save the tflight model to the file
tflite_model.save(tflite_file)`
Other info / logs
Include any logs or source code that would be helpful to diagnose the problem. If including tracebacks, please include the full traceback. Large logs and files should be attached.
Error I am getting:-------------------------------
ConverterError                            Traceback (most recent call last)
 in ()
5 converter = tf.lite.TFLiteConverter.from_keras_model(model)
6 print("converter = " + str(converter))
----> 7 tflite_model = converter.convert()
8
9 #no save the tflight model to the file
~\AppData\Roaming\Python\Python36\site-packages\tensorflow_core\lite\python\lite.py in convert(self)
444         input_tensors=input_tensors,
445         output_tensors=output_tensors,
--> 446         **converter_kwargs)
447
448     if self._is_calibration_quantize():
~\AppData\Roaming\Python\Python36\site-packages\tensorflow_core\lite\python\convert.py in toco_convert_impl(input_data, input_tensors, output_tensors, enable_mlir_converter, *args, **kwargs)
447       input_data.SerializeToString(),
448       debug_info_str=debug_info_str,
--> 449       enable_mlir_converter=enable_mlir_converter)
450   return data
451
~\AppData\Roaming\Python\Python36\site-packages\tensorflow_core\lite\python\convert.py in toco_convert_protos(model_flags_str, toco_flags_str, input_data_str, debug_info_str, enable_mlir_converter)
198       stdout = _try_convert_to_unicode(stdout)
199       stderr = _try_convert_to_unicode(stderr)
--> 200       raise ConverterError("See console for info.\n%s\n%s\n" % (stdout, stderr))
201   finally:
202     # Must manually cleanup files.
ConverterError: See console for info.
Traceback (most recent call last):
File "c:\python36\lib\runpy.py", line 193, in _run_module_as_main
"main", mod_spec)
File "c:\python36\lib\runpy.py", line 85, in run_code
exec(code, run_globals)
File "C:\Python36\Scripts\toco_from_protos.exe_main.py", line 5, in
ModuleNotFoundError: No module named 'tensorflow.contrib'

Please note I have read the issue 25162 that I believe is related but, was not resolved.  Does this have something to do with running on Windows?
https://github.com/tensorflow/tensorflow/issues/25162


How to retrieve build artifact paths?

How do I determine which artifacts cargo produced and where? The used target directory depends on multiple environment variables (e.g. CARGO_TARGETDIR), configuration settings (e.g. build.target-dir and build.target), command-line arguments (--target, --release). Not to mention it gets even more complicated when the package is part of a workspace. Of course it also depends on settings inside Cargo.toml but at least for these settings there's the cargo metadata command.
Now my question is if there is any easy way to know which artifacts were produced and where? Or do I have to parse all of the stuff above and mimic undocumented implementation details of how cargo determines output locations and names? If the latter is the case, then this greatly complicates integrating cargo into any other build system. For my specific use case, I need to provide a post-build step that is project-agnostic, i.e. all of the variables above might change. How should I go about?

Top level artifacts should always show up in predictable locations (if you're controlling the variables above). Otherwise --message-format=json should print out all paths that are compiled

Oh right, I forgot completely forgot about that option. However I would still like the possibility to display warnings and error messages in text form. Are these text messages easy to reconstruct from JSON or is some information lost?

Yeah unfortunately right now once json messages are emitted there's no way to get back the original rendering (currently). It's come up before though and we'd definitely like to be able to enable it!
Also yeah that sounds like a reasonable way to learn about the top-level crate, I believe.

Would it be possible to have rustc print the original messages in addition to the JSON representation in the same way that cargo does this, i.e. original messages on stderr and JSON on stdout?

Perhaps yeah, Cargo doesn't currently try to pick which lines are json and which aren't, but we could perhaps soup up the logic. (this'd require changes to the compiler)

cargo does not seem to output the final file names (inside the release/debug folder)

Fixed in https://github.com/rust-lang/cargo/pull/3752

Thanks @matklad!
@Jascha-N is that sufficient now perhaps?

Yeah, thanks, this works fine for now. The only problem I still have is with rustc's messages being in JSON format.

Actually, having fought with creating a transparent wrapper around cargo for some time now, I can safely say that this is not a solution. There needs to be a better way to obtain the final artifact paths, without butchering all of the rustc output. The only two solutions I can think of is creating a wrapper around rustc that filters out the --error-format json option if --message-format json was not passed to the cargo wrapper or running cargo twice (the second time with --message-format json and output captured) just to obtain the artifact paths. Neither solution is nice in my opinion.

@Jascha-N I've created https://github.com/rust-lang/cargo/issues/3855 about the problem.


process exit

How to stop the process exiting? Need to keep it running to accept SSE's to run an even listener.

Use the .parse(args) method rather than the .parseAndExit(args) method.
Here's a quote from the docs:

This method is suitable for any application use. It treats each call as a stateless operation, accepting the input it needs and returning (as a Promise) the output result. It makes no assumptions about the application and therefore does not call any methods like console.log() or process.exit(). Rather, any potential output content (like help text) or error status (like an exit code) is reported in the result.

Both methods are asynchronous (returning a Promise), but .parse(args) resolves to a "result" object (that wraps the parsed argv) whereas .parseAndExit(args) resolves to the argv object directly.

Yeah, I tried that.


Loops are not bad

Hi Bianca, for loops are not a problem for r, however, dynamic growing of the data frame is.
So of you first create an empty data frame with number of rows equal to dois the loop will be much faster. I'll do a pull request next week or so. Good work so far!

best practice is to create the data frame with rownumbers equal to the number of doi numbers you will request.
Now add information to the rows .
The problem with df<- rbind(df, new_information)  is that R needs to copy the entire dataframe to a new location in memory for every rbind.
In other words the steps are 1. start with df, 2. copy to new location in memory with place for one more row, 3. delete old df <= This is what makes some loops slow in R.
In stead of using:
for (i in 1:100){
  df <- rbind(df,getData(DOI_input$DOI[i]))
}

Use something like this pseudocode:
for(i in 1:100) {
#first download information from getrequest.
doi_info <- getData(DOI_input$DOI[i])
# then add the column information (might be a faster way)
df$DOI[[i]] <- doi_info$DOI
df$DOI_resolver[[i]] <- doi_info$DOI_resolver
etc.
}


Multiple Campaigns Runs Were Created

Current Behavior
Multiple runs were created for some campaigns in  #5961. See https://www.dosomething.org/admin/content/search?title=senior+socials&type=campaign_run&field_cause_tid=All&status=All&language=All as an example. Note Senior Socials the campaign only exists in US English, so this doesn't appear to be a translation issue.
This doesn't seem to have occurred on thor, only production.
Desired Behavior
Only one run 1 should exist for each campaign.
Steps to Replicate
If you go to https://www.dosomething.org/admin/content?sort=asc&order=Title and filter by type = campaign run you can see all the instances in which multiple runs were created.
Why This Matters
Part of the goal of this runs effort was to clean up the data, and having dummy runs associated with campaigns will likely confuse admins in the future.
cc: @angaither
Also note, in trying to resolve a potentially related issue I tried associating duplicate runs for Quitters Always Win (nid 10) with a dummy campaign. However I did not change those back as these duplicate runs should really be deleted anyways.

Thanks, Mike!
@angaither since #5961 was only meant to run once (versus a script we use over and over), I'm thinking the best way to approach this is to make another function in the dosomething_campaign_run.install file to query for all the duplicate runs for a campaign and delete all but one. Let me know if this is the correct path to go down and I'll get on it!

@chloealee no, this did not happen on thor, and the same code ran it doesn't make sense on why it would work differently on production.
cc @sheyd @blisteringherb
is there any reason you can see why this would happen?
query that ran on thor & prod
SELECT t.entity_id, group_concat(t.created) as created_dates, n.language as src_lang, group_concat(t.language) as languages, d.title_field_value
                                FROM entity_translation t
                                INNER JOIN field_data_field_campaign_status s on s.entity_id = t.entity_id
                                INNER JOIN node n on n.nid = t.entity_id
                                INNER JOIN field_data_title_field d on d.entity_id = t.entity_id and t.language = d.language
                                WHERE field_campaign_status_value = 'active'
                                GROUP BY t.entity_id;

it produces the same results in both environments.
for each row returned, it creates a campaign run node.
for node id = 10, one row is returned, so one campaign run should have been created.
this worked correctly on thor, but in prod it produced 3 run nodes.
take a look at here to have a closer look at what is going on in the code https://github.com/DoSomething/phoenix/pull/6037/files

@chloealee @angaither For clarification, is this the order of operations that happened to get us to this state:

Prod Snapshot to Thor
Deploy Campaign Run Test Code (v 2.??)
Test run of dosomething_campaign_run.install code to create campaign runs on Thor
Thor has 1 campaign as tested via query
Deploy to Prod
Prod has 3 campaigns instead.

@sheyd correct and it looks like it was v2.1.19

@angaither Thanks for version! Backtracking to see what could have caused this.

@angaither @mikefantini This was caused by an issue in our deployment process where updb ran multiple times (Sergii is testing a fix for this now). The number of campaigns that have multiple run creations I don't currently know.
Next steps:

Track down all campaigns with multiple runs
Have someone strip them out via script?

Sound like a good course ^^ @angaither @mikefantini ?

@sheyd that course of action makes sense to me.

It might be easier to just manually delete them.
duplicates can be easily seen with this query
SELECT t.entity_id, n.language as src_lang, group_concat(t.language) as languages, group_concat(d.title_field_value) as titles, concat('dosomething.org/node/', t.entity_id, '/edit') as link
FROM entity_translation t
INNER JOIN node n on n.nid = t.entity_id
INNER JOIN field_data_title_field d on d.entity_id = t.entity_id and t.language = d.language
WHERE d.title_field_value LIKE '%run 1'
GROUP BY t.entity_id
ORDER BY titles;

thanks, @angaither! I'll hop on this and finish the above.
@sheyd when you get a chance, would you mind helping me get the prod database set up?

@mikefantini closing, I removed the duplicates.
there's some that appear to still be duplicates, but it's because the actual campaign node has a bunch of duplicates


General questions about routing-release

Hi,
I am note sure if I should have put that on the mailing list, or not, but I will ask the question here. Is there a timeline/roadmap for the routing release to be integrated into the the cf-release, regarding HA Proxy and the PostgreSQL release? Or will it always be a separate release in future?
Does the current version also run with postgres, if I configure it in correctly in the property section?
properties:
  routing_api:
    sqldb:
      host: <IP of SQL Host>
      port: <Port for SQL Host>
      type: mysql
      schema: <Schema name>
      username: <Username for SQL DB>
      password: <Password for SQL DB>

Is the manual configuration of the database stable for upgrade in future release?

We are currently adding support for a relational database for routing api. This work is not complete. We will support MySQL and PostgreSQL when we're done. The plan is to support migrating data in an upgrade, but we have not started that work.
Routing release will not be integrated into cf-release. In the contrary, over the past year almost all components have been removed from cf-release in preparation for cf-deployment, the new way of deploying Cliud Foundry. Routing-release will be part of the default deployment using this new strategy.

On Sep 10, 2016, at 2:12 AM, Johannes Hiemer<EMAIL_ADDRESS>wrote:
Hi,
I am note sure if I should have put that on the mailing list, or not, but I will ask the question here. Is there a timeline/roadmap for the routing release to be integrated into the the cf-release, regarding HA Proxy and the PostgreSQL release? Or will it always be a separate release in future?
Does the current version also run with postgres, if I configure it in correctly in the property section?
properties:
routing_api:
sqldb:
host:
port:
type: mysql
schema:
username:
password:
Is the manual configuration of the database stable for upgrade in future release?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Hello @jhiemer
I'm not sure if we answered your question, as I didn't fully understand it. We'll close this issue for now, but if you have clarifying questions, please feel free to re-open it or create a new one.
Thanks!


Use amazon cloudfront URL instead of S3 bucket URL to deploy my code

Hi,
I have mobile app and I am interested to use your plugin to push my code .But i have an issue that my code remain public on S3 bucket and accessible to all , in order to solve this issue and  make my code secure on amazon S3 bucket I have tried to use Amzon Cloudfront with secret key URL , I need to check the possibility to use the plugin with Cloudfront URL instead of S3 bucket URL and how I can send the secret key from the plugin or the JSON file (cordova-hcp) to Amazon Cloudfront .

After you have done that setting (and whatever securty measures you want to take) you simply change the config value content_url found here: https://github.com/nordnet/cordova-hot-code-push#application-config
We're actually doing this in development to be able to push a test-build to multiple devices at the same time, and then we use JavaScript to change this config value:
https://github.com/nordnet/cordova-hot-code-push#change-plugin-preferences-on-runtime

@hussfelt thank you ,, can you help me if we can send secrete key appended to the Cloudfront URL.

You can send any URL you want, so a secret key appended should not be an issue.
If you need a new secret-key for every request, I guess you would need to prepare that through an API request before even checking for an update. You would need to build your own update-cycle and request a url with a key, then requesting a check for an update and execute the update.


Create Option for Plugin Category

This is in reference to #505. Makes it so that the Wolffram Plugin can be ran in a specific category


When using Forced Tunnelling with Azure Firewall , tracert  and Network Watcher Connection troubleshoot will show an AzureFirewallManagementSubnet IP as the first hop

[Enter feedback here]
as per subject, just working a case with Support , where we saw this and has caused confusion .
It would be call this quirk out in this document somewhere , as this has potential to confuse people / lead people down a rabbit hole of troubleshooting incorrect routing etc
just a thought, thx

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 49421ed5-6252-b24f-2983-ae58cea26df2
Version Independent ID: 0dd3e8b1-319c-1694-4cdd-bb050d0e85f5
Content: Azure Firewall forced tunneling
Content Source: articles/firewall/forced-tunneling.md
Service: firewall
GitHub Login: @vhorne
Microsoft Alias: victorh

Thank you for your feedback! We have assigned this issue to the author to review further and take the next course of action.

@andyjballgit , thank you for your feedback. We have assigned this to the content owner/author for review.
@vhorne , for your review.


Autofill KMLB ASOS data

First I need to make it so that gefs .csv files are automatically added to gefs_all.csv.

gefs_all.csv automatically updates now.


[WIP][Forge] Add forge LBT in ci-test

Motivation
(Write your motivation for proposed changes here.)
Have you read the Contributing Guidelines on pull requests?
(Write your answer here.)
Test Plan
(Share your test plan here. If you changed code, please provide us with clear instructions for verifying that your changes work.)
Related PRs
(If this PR adds or changes functionality, please take some time to update or suggest changes to the docs at https://developers.diem.com, and link to your PR here.)
If targeting a release branch, please fill the below out as well

Justification and breaking nature (who does it affect? validators, full nodes, tooling, operators, AOS, etc.)
Comprehensive test results that demonstrate the fix working and not breaking existing workflows.
Why we must have it for V1 launch.
What workarounds and alternative we have if we do not push the PR.

/canary

:broken_heart: Test Failed - ci-test

/canary

:broken_heart: Test Failed - ci-test

/canary

/canary

/canary

/canary

:sunny: Canary successful

/canary

:broken_heart: Test Failed - ci-test

/canary

:broken_heart: Test Failed - ci-test

/canary

:broken_heart: Test Failed - ci-test

/canary

:sunny: Canary successful

/canary

:broken_heart: Test Failed - ci-test

/canary

:broken_heart: Test Failed - ci-test

/canary

:broken_heart: Test Failed - ci-test

/canary

/canary

/canary

/canary

/canary

/canary

:broken_heart: Test Failed - ci-test

/canary

:broken_heart: Test Failed - ci-test

/canary

:sunny: Canary successful

/land


Optimise SQLite use in dev

Trying to improve SQLite and resolve #1099 using https://fractaledmind.github.io/2023/09/07/enhancing-rails-sqlite-fine-tuning/

All of this is now done by default in Rails 7.1. Hooray! https://www.bigbinary.com/blog/rails-7-1-comes-with-an-optimized-default-sqlite3-adapter-connection-configuration


Add support for Named Reroutes

void UFlowGraphNode_NamedRerouteDeclaration::PostPlacedNewNode()
{
UFlowNode_NamedRerouteDeclaration* Declaration = Cast<UFlowNode_NamedRerouteDeclaration>(GetFlowNode());
if (const UFlowAsset* FlowAsset = GetFlowNode()->GetFlowAsset();
FlowAsset && Declaration)
{
Declaration->MakeNameUnique();
}
Super::PostPlacedNewNode();
}

Found a little issue - new named reroute declarations have the same name, either node placed from palette, created from pin or converted from regular reroute.
There is 2 ways of fixing it - make node title editable and force edit title when node is created (how it is done in Material Graph) or force making unique name when new node is created. Here is the code for the second option (I prefer this one, because IMO the first one will have considerably more code)
Add to "FlowGraphNode_NamedRerouteDeclaration.h"
virtual void PostPlacedNewNode() override;
Add to "FlowGraphNode_NamedRerouteDeclaration.cpp"
void UFlowGraphNode_NamedRerouteDeclaration::PostPlacedNewNode()
{
	UFlowNode_NamedRerouteDeclaration* Declaration = Cast<UFlowNode_NamedRerouteDeclaration>(GetFlowNode());
	if (const UFlowAsset* FlowAsset = GetFlowNode()->GetFlowAsset();
		FlowAsset && Declaration)
	{
		Declaration->MakeNameUnique();
	}
	Super::PostPlacedNewNode();
}

Found another bug, that can cause crash.
Steps to reproduce:

Create named reroute declaration and several usages

Rename reroute declaration

Undo previous action

The problem is in these two lines in UFlowNode_NamedRerouteDeclaration::PostEditChangeProperty():
Usage->SetNodeName();
Usage->GetGraphNode()->ReconstructNode();

Neither of these functions call Modify() on owning object.
To fix this you need to add
void UFlowNode_NamedRerouteUsage::SetNodeName()
{
  Modify();
...
}

and it is better not to call Usage->GetGraphNode()->ReconstructNode(); directly, instead call Usage->OnReconstructionRequested.ExecuteIfBound();
But... I do not see any reason at all to call OnReconstructionRequested.ExecuteIfBound(); in UFlowNode_NamedRerouteDeclaration::PostEditChangeProperty(). It works perfectly fine without it. (You also do not need to chech CustomNodeColor).
This is my working version of this function:
void UFlowNode_NamedRerouteDeclaration::PostEditChangeProperty(FPropertyChangedEvent& PropertyChangedEvent)
{
	if (PropertyChangedEvent.GetMemberPropertyName() == GET_MEMBER_NAME_CHECKED(ThisClass, NodeTitle))
	{
		MakeNameUnique();
		for (const UFlowAsset* FlowAsset = GetFlowAsset();
		     const auto Usage : FlowAsset->FindNamedRerouteUsages(DeclarationGuid))
		{
			if (Usage)
			{
				Usage->SetNodeName();
			}
		}
	}
	Super::PostEditChangeProperty(PropertyChangedEvent);
}

Hi, please grab the latest changes as this change has merge conflicts with just accepted Flow AddOns.

Potential errors,

the nodes (declaration/usage) are apparently not saved properly

copy/duplicate in the same graph

copy/duplicate in another graph

Although everything seems to be working fine, it appears that my implementation is not entirely correct. I am open to suggestions on how to fix these errors. If there is no progress, I will close this PR until further notice.

I've been checking this PR for two days but something felt wrong and I finally understood what was that - reroute nodes should be reversed. Sorry I did not notice this earlier.
Declaration node should have only Output pin (optionally Input), and Usages should have only Input pin. You see, now your implementation looks like this,

and if we convert this to regular reroutes we get this,

which is wrong - Output execution pins can have only one connection (even if you connect more pins by code, only first input pin from LinkedTo array will be executed).

You can see in this example that if I try to add more connections to Output pin of the reroute it will replace all other connections.

But reroutes can have Input pin with many connections and this is what we want to be able to convert to named reroutes and back.
What should have been instead is when you have this setup with reroute,

after converting to named reroute graph should look like this (it is implementation of named reroutes I was working on),

but in your implementation it looks like this

I see that you took parts of code from Material Graph and made reroutes in the same way, but MaterialGraph is executed from right to left and reroutes are for value pins, not execution pins like in FlowGraph. The difference is that value pins have reversed rules for connecting pins - input pin can have only one connection, output pins can have many connections.
Sorry I missed it when I first checked the code, I think it should be fixed.

@MothDoctor what do you think about this? Maybe I missed something again(

@MaksymKapelianovych Thank you for mentioning the problems, yes, I think they should be solved.
Although I really think that the ability to convert named reroutes to reroutes should be limited, maybe just connect the first reference to LinkedTo, because I honestly don't know how to adapt this functionality for Exec pins, in Material it makes sense, but not for our context.
Possible fixes,

Let me know what you think about that so I can start implementing it.

From 4 possible solutions the only suitable one is the thir, IMO. But I really think that the main issue is with the current implementation of named reroutes: there should be many input nodes (usages) and one output node (declaration). Named reroutes are intended to eliminate long wires stretching through the graph, so they must follow the rules of basic reroutes and pin connections, and must be easily convertible to and from basic reroutes.

If you do not know how to implement this behaviour I can help or implement it myself (almost did it anyway)

But if you want to keep current behaviour of your named reroutes, maybe it would be better to untie it from reroutes at all and to make it as an independent feature.

But if you want to keep current behaviour of your named reroutes, maybe it would be better to untie it from reroutes at all and to make it as an independent feature.

As I understand it, my implementation redirects the output of the declaration to all the usages. In contrast, your approach is more conditional, using the usages to call the actual output from the declaration. Considering this, it seems more appropriate to refer to it as a "portal."
To switch to this behavior, all I had to do is call the TriggerFirstOutput within the linked declaration.

After all, this behavior seems more appropriate and controlled than my original implementation. If all goes well, I will proceed to fix the errors mentioned above when converting Named Reroutes to Reroutes.

@MaksymKapelianovych I updated the code, can you check it one more time?

Other issues:

Node palette is not updated when new named reroute is added/deleted, only after pressing Refresh changes will appear on palette. To make it instant you need to add UFlowGraphSchema::OnNodeListChanged.Broadcast(); when new Declaration is added/deleted. Alternatively you can call UFlowGraph::RefreshGraph(), but it will trigger full graph refresh.
Declaration node is not properly registered by Flow debugger. Node execution is captured when its input is triggered, so to make minimal changes we just need to execute Declaration's input as for any other node.
Change UFlowNode_NamedRerouteUsage::ExecuteInput to this (to be able to call TriggerInput you need to add friend class UFlowNode_NamedRerouteUsage; to UFlowAsset class declaration):

void UFlowNode_NamedRerouteUsage::ExecuteInput(const FName& PinName)
{
	if (LinkedDeclaration)
	{
		Finish();
		GetFlowAsset()->Triggerinput(LinkedDeclaration->GetGuid(), PinName);
	}
}

and remove line InputPins = {}; from UFlowNode_NamedRerouteDeclaration's contructor. Declaration node will have default input pin, it will be working fine, but if you want you can hide it in UFlowGraphNode_NamedRerouteDeclaration like this (also require adding friend class UFlowGraphNode_NamedRerouteDeclaration; to UFlowNode class declaration):
void UFlowGraphNode_NamedRerouteDeclaration::AllocateDefaultPins()
{
	check(Pins.Num() == 0);

	if (UFlowNode* FlowNode = Cast<UFlowNode>(GetFlowNodeBase()))
	{
		for (const FFlowPin& OutputPin : FlowNode->OutputPins)
		{
			CreateOutputPin(OutputPin);
		}
	}
}

Before:

After:

The rest looks good)

I noticed that named reroute still does not dissapear from Palette after deleting named reroute declaration node from the graph. I went to investigate how to do it aaand ... guess it is not that simple and straightforward, especially when it is time to deal with transactions. I also checked Material and PCG graphs (they both have named reroutes) and their palettes do not have named reroute declarations. So, maybe it would be easier to remove the named reroute actions from FlowGraph's palette rather than try to handle every corner case?

@MaksymKapelianovych Can you check if the new commit fixes the problem?

Yep, it is working, though I do not like the implementation (calling PostEditChangeProperty manually), but I do not know how to implement it better) I think it is totally fine for now.

Yep, it is working, though I do not like the implementation (calling PostEditChangeProperty manually), but I do not know how to implement it better) I think it is totally fine for now.

Honestly OnNodeListChanged.Broadcast() should have been called automatically when deleting the node, but there's something weird going on with the implementation that I still don't know what it is... I even found another error, when duplicating or copying the node, the palette is not updated because GetGraphNode() always returns null, and the first result of the node is not added but the others are added...

From 4 proposed solutions the only suitable one is the third, IMO. But I really think that the main issue is with the current implementation of named reroutes: there should be many input nodes (usages) and one output node (declaration). Named reroutes are intended to eliminate long wires stretching through the graph, so they must follow the rules of basic reroutes and pin connections, and must be easily convertible to and from basic reroutes.
-- @MaksymKapelianovych

while i think you're correct, that if a named reroute is a "reroute" at hearth it should have multiple inputs but only one output. I have to say: thinking of a "named reroute" as a "Sequence" (with don't-care order of outputs) makes the node itself way more useful.
limiting the named reroute to the capability of a reroute itself means I'd have to create a sequence, move every output into it's own named reroute and use these.
I terms of usage (disregarding technical details) this would feel more like the node in the material graph.

While it would be useful functionality, it will not correlate with existing reroutes, so it should be implemented as a completely separate feature then (without converting to and from reroutes). In theory we can have both features, but it is not up to me)
Material graph is different, it has reroutes for values, not for execution, values pins evaluation is reversed compared to execution and executes from right to left (as well as in AnimGraph, for example). Now in this PR reroutes working just like in Material graph. What you want is completely valid, but slightly different feature. @soraphis

What you want is completely valid, but slightly different feature

Yeah, I agree. And it kind of is my point: I feel like, we should not add this with the current design to the main package. As this would look too similar to the "sequence"-approach, but the sequence approach is way more useful.
but that's just my 2cents, as I would probably disable this one then in my project

@MaksymKapelianovych What do you think about adding both functionalities in this PR?
I modified my code to add the ability to invert the multi-in single-out and single-in multi-out functionality dynamically. To achieve this, it was necessary to modify FFlowPin and add a pin visibility property (bIsVisible). I felt it was necessary to hide the pins instead of adding or removing them in each PropertyChange, as I had problems with removing an input and then trying to call TriggerInput in the linked usage (or declaration).
I also tried using AllocateDefaultPins, but this created orphaned pins in each transaction.
Now the code looks like this,

For reference: https://discord.com/channels/742802606874820619/818589094392889344/1257316766757945415
Let me know if you want me to commit this new feature, or if I should leave the PR as it is now. I believe that extending FFlowPin should be addressed in a separate PR.

I think my decision-making capabilities end there and it is up to @MothDoctor in what form to add this feature. It would be wrong for my personal preferences to influence other people's workflow with the Flow.
But I can check if there are no issues in code)


Add Coastwards

Insert URLs to the project here:
https://github.com/maureentsakiris/coastwards

[x] The projects is active, documented, open source licensed, shows usage from external parties and is directly targeting environmental sustainability. Find more details in the Contribution Guide.

All issues labeled as 'Good First Issue' of the project listed on OpenSustain.tech will be visible on ClimateTriage.com. This is a great way to welcome new community members to your project.

@maureentsakiris @tEErohr


Add rebass component lib to README

Deploy preview for affectionate-nobel-f3a8ec processing.
Built with commit a2f7058b6044dcaac79353b62b908f31c9f466f8
https://app.netlify.com/sites/affectionate-nobel-f3a8ec/deploys/5bc4b0d7792f893e2c446015

Codecov Report

Merging #422 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #422   +/-   ##
=======================================
  Coverage   99.72%   99.72%
=======================================
  Files          77       77
  Lines         364      364
  Branches       16       16
=======================================
  Hits          363      363
  Misses          1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7214141...a2f7058. Read the comment docs.


Restore matter unit tests and fix backwards compatibility.

Codecov Report

Merging #948 (b3bc280) into master (76d6233) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #948      +/-   ##
==========================================
+ Coverage   62.13%   62.15%   +0.01%
==========================================
  Files         155      155
  Lines       16624    16624
  Branches     3674     3674
==========================================
+ Hits        10330    10333       +3
+ Misses       5596     5593       -3
  Partials      698      698

Impacted Files
Coverage Δ

.../matter/app/zap-templates/templates/chip/helper.js
14.53% <0.00%> (+1.06%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

This work also uncovered the fact that gen-matter2.test.js and gen-matter3.test.js were largely useless as unit tests. I dabbled a bit initially (hence some commits to the gen-matter3.test.js and the zapt files), but I'll first fix a functional issue here to unblock some people that are trying to release something, and then we can address that in a separate work.


"There was an error sending the test notification. Please check your notification settings and try again"

Version: 10.5.0
Operating System: Windows
Architecture: X64
installed Pushbullet 3.0,0,0
put in the Pushbullet channel and auth token - get the error:
"There was an error sending the test notification. Please check your notification settings and try again"
console log:
[21:39:28] [ERR] [27] Emby.Server.Implementations.HttpServer.HttpListenerHost: Could not find handler for /Notification/Pushbullet/Test/fd05c8150bce4652800e81887f42d32f
[21:39:28] [ERR] [27] Emby.Server.Implementations.HttpServer.HttpListenerHost: Error processing request: Unable to find the specified file.

Most likely a duplicate of https://github.com/jellyfin/jellyfin-plugin-pushbullet/issues/5, should be fixed in next release. Feel free to re-open if it isn't fixed.


:robot: Add dracut-mkinitrd-deprecated package to Tumblweed

Fixes the CI issue, but I think @Itxaka solution is better since it's a "deprecated" package. Still leaving this here in case we want to make CI green before the other PR gets merged, otherwise feel free to close

Codecov Report

Merging #1202 (a35202f) into master (7bb9af9) will decrease coverage by 0.10%.
The diff coverage is 25.45%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##           master    #1202      +/-   ##
==========================================
- Coverage   22.79%   22.70%   -0.10%
==========================================
  Files          22       15       -7
  Lines        1610     1207     -403
==========================================
- Hits          367      274      -93
+ Misses       1179      886     -293
+ Partials       64       47      -17

Impacted Files
Coverage Δ

internal/agent/agent.go
43.10% <ø> (ø)

internal/agent/interactive_install.go
0.00% <ø> (ø)

internal/agent/notify.go
0.00% <ø> (ø)

internal/agent/recovery.go
0.00% <ø> (ø)

internal/agent/reset.go
0.00% <ø> (ø)

internal/agent/upgrade.go
0.00% <0.00%> (ø)

pkg/config/config.go
51.35% <ø> (ø)

internal/agent/install.go
5.28% <30.43%> (+5.28%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

kind of weird because on my tests, the kernel-default brings the dracut-mkinitrd-deprecated package :S
c37f4a442a39:/ # zypper in --force-resolution kernel-default
Loading repository data...
Reading installed packages...
Resolving package dependencies...

The following 41 NEW packages are going to be installed:
  busybox busybox-gzip dbus-1 dracut dracut-fips dracut-mkinitrd-deprecated elfutils file kbd kbd-legacy
  kernel-default kmod libapparmor1 libargon2-1 libasm1 libcryptsetup12 libcryptsetup12-hmac libdbus-1-3
  libdevmapper1_03 libexpat1 libip4tc2 libjson-c3 libkcapi-tools libkmod2 libseccomp2 pam-config
  perl-Bootloader pigz pkg-config suse-module-tools system-group-kvm systemd systemd-default-settings
  systemd-default-settings-branding-SLE systemd-presets-branding-MicroOS systemd-presets-common-SUSE
  systemd-rpm-macros systemd-sysvinit udev util-linux-systemd zstd

good question, I don't think it's the case anymore though:
zeno% zypper info --requires dracut-mkinitrd-deprecated
Loading repository data...
Reading installed packages...

Information for package dracut-mkinitrd-deprecated:
---------------------------------------------------
Repository     : openSUSE-Tumbleweed-Oss
Name           : dracut-mkinitrd-deprecated
Version        : 059+suse.366.gf45bc67a-1.2
Arch           : x86_64
Vendor         : openSUSE
Installed Size : 14.9 KiB
Installed      : Yes (automatically)
Status         : up-to-date
Source package : dracut-059+suse.366.gf45bc67a-1.2.src
Upstream URL   : https://github.com/dracutdevs/dracut/wiki
Summary        : Dracut mkinitrd wrapper
Description    :
    This package contains the legacy initrd script for dracut.
    Call dracut directly instead.
Requires       : [3]
    /bin/bash
    dracut
    dracut = 059+suse.366.gf45bc67a-1.2

zeno% zypper info --requires kernel-default
Loading repository data...
Reading installed packages...

Information for package kernel-default:
---------------------------------------
Repository     : openSUSE-Tumbleweed-Oss
Name           : kernel-default
Version        : 6.2.8-1.1
Arch           : x86_64
Vendor         : openSUSE
Installed Size : 308.3 MiB
Installed      : Yes
Status         : up-to-date
Source package : kernel-default-6.2.8-1.1.nosrc
Upstream URL   : https://www.kernel.org/
Summary        : The Standard Kernel
Description    :
    The standard kernel for both uniprocessor and multiprocessor systems.

    Source Timestamp: 2023-03-22 18:56:06 +0000
    GIT Revision: 221c28fbd5a8e85b11ef8168a8454521fb5cabba
    GIT Branch: stable
Requires       : [10]
    /bin/sh
    coreutils
    suse-kernel-rpm-scriptlets
    dracut
    awk
    modutils
    suse-module-tools
    distribution-release
    kmod-zstd
    perl-Bootloader >= 0.4.15

zeno% zypper info --requires dracut
Loading repository data...
Reading installed packages...

Information for package dracut:
-------------------------------
Repository     : openSUSE-Tumbleweed-Oss
Name           : dracut
Version        : 059+suse.366.gf45bc67a-1.2
Arch           : x86_64
Vendor         : openSUSE
Installed Size : 1.9 MiB
Installed      : Yes (automatically)
Status         : up-to-date
Source package : dracut-059+suse.366.gf45bc67a-1.2.src
Upstream URL   : https://github.com/dracutdevs/dracut/wiki
Summary        : Event driven initramfs infrastructure
Description    :
    Dracut contains tools to create a bootable initramfs for Linux kernels >= 2.6.
    Dracut contains various modules which are driven by the event-based udev
    and systemd. Having root on MD, DM, LVM2, LUKS is supported as well as
    NFS, iSCSI, NBD, FCoE.
Requires       : [33]
    libc.so.6(GLIBC_2.34)(64bit)
    /usr/bin/pkg-config
    grep
    libgcc_s.so.1()(64bit)
    sed
    findutils
    libgcc_s.so.1(GCC_3.0)(64bit)
    /bin/bash
    ld-linux-x86-64.so.2()(64bit)
    ld-linux-x86-64.so.2(GLIBC_2.3)(64bit)
    libgcc_s.so.1(GCC_3.3)(64bit)
    libgcc_s.so.1(GCC_4.2.0)(64bit)
    bash
    cpio
    file
    zstd
    elfutils
    awk
    filesystem
    modutils
    libkmod.so.2()(64bit)
    libkmod.so.2(LIBKMOD_5)(64bit)
    pigz
    hardlink
    /usr/bin/get_kernel_version
    libkmod.so.2(LIBKMOD_22)(64bit)
    systemd >= 219
    udev > 166
    util-linux >= 2.21
    util-linux-systemd >= 2.36.2
    /bin/sh
    coreutils
    systemd

This is good and it fixes the issue but I still prefer mine as it also merges all the systems into just one IF/ELSE  to simplify the earthfile :D

agreed, closing this one then


PrologLexer may freeze with triple backslashes

(Original issue 891 created by yuja on 2013-07-25T15:49:59.185751+00:00)
PrologLexer freezes with the following input, probably because of inefficient regexp pattern.
How to reproduce:
$ pygmentize -l prolog ADuC_bypassUpgrade.pro

https://bitbucket.org/tortoisehg/thg/issue-attachment/2407/tortoisehg/thg/1360165263.23/2407/ADuC_bypassUpgrade.pro
Pygments version: 1.6 or 7304e4759ae6

(Original issue 891 last updated on 2014-01-09T19:46:03.446330+00:00)
(Issue automaticaly closed due to status in Bitbucket: resolved)

(Original comment by birkenfeld on 2014-01-09T19:46:03.442125+00:00)
Closes #891: remove too broad string escape regex from Prolog lexer.
→ <<cset 10f0c54a87f7>>


Fix prepublish scripts of extensions

vsce pacakge is sometimes useful.

Sorry, but this doesn't work. vsce package seems to ignore ./out directory (maybe because it's in .gitignore).
I'll reopen PR if I found some reasonable workaround for this.


HIVE-27000: Improve the modularity of the *ColumnStatsMerger classes

What changes were proposed in this pull request?

Improving the modularity of the *ColumnStatsMerger classes by introducing a common parent class and moving there all the shared code that is not depending on the data type.
Why are the changes needed?

Those classes host some complex merging logic that is copy-pasted into several classes, a problem that is bound to worsen as we add new (and more complex) statistics.
Does this PR introduce any user-facing change?

No.
How was this patch tested?

Existing and introduced unit-tests relevant for the change:
mvn test -Dtest.groups=org.apache.hadoop.hive.metastore.annotation.MetastoreUnitTest -Dtest='*ColumnStats*Test.java' -pl standalone-metastore/metastore-server

LGTM, +1

@ayushtkn, if you have spare cycles maybe you can help get this in since it's been approved already? Thanks!

And I messed up while committing :-(
Forgot to mention Akshat's name while committing, Have reverted this and committed it again with the correct message. I don't have anything more than sorry here, will be more careful next time

And I messed up while committing :-( Forgot to mention Akshat's name while committing, Have reverted this and committed it again with the correct message. I don't have anything more than sorry here, will be more careful next time

We never make mistakes only if we do nothing at all, you are very very active so it happens. On that note, thanks a lot for always helping out with reviews and merges, much appreciated Ayush!


Problem with unicode text

Having problem with unicode text.
for example converting Georgian text: გამარჯობა, როგორ ხარ? its converted like ????????, ????? ????
I'm using on .Net

Hi @gino4nx
Are you using FFI to invoke the library?
I believe you'll need to let it know that the encoding of the returned string is UTF-8.
E.g. see: UnmanagedType.LPUTF8Str in https://learn.microsoft.com/en-us/dotnet/framework/interop/default-marshalling-for-strings#strings-used-in-platform-invoke.
You can see similar behaviour in the below Ruby example:
Default encoding (ASCII-8BIT)
irb(main):020> puts HTMLToADF.convert("
გამარჯობა, როგორ ხარ?
")
(irb):20:in `write': "\xE1" from ASCII-8BIT to UTF-8 (Encoding::UndefinedConversionError)
	from (irb):20:in `puts'
	from (irb):20:in `puts'
	from (irb):20:in `'
	from <internal:kernel>:187:in `loop'
	from /Users/pico/.rbenv/versions/3.3.0/lib/ruby/gems/3.3.0/gems/irb-1.11.1/exe/irb:9:in `<top (required)>'
	from /Users/pico/.rbenv/versions/3.3.0/bin/irb:25:in `load'
	from /Users/pico/.rbenv/versions/3.3.0/bin/irb:25:in `'

UTF-8
irb(main):021> puts HTMLToADF.convert("
გამარჯობა, როგორ ხარ?
").force_encoding("utf-8")
{"version":1,"type":"doc","content":[{"type":"heading","attrs":{"level":1},"content":[{"type":"text","text":"გამარჯობა, როგორ ხარ?"}]}]}
=> nil


Pretrained MSDS-RCNN model

Hi, I would like to know if it is possible for you to share the pre-trained model of the MSDS-RCNN. I realize you have shared a basic VGG model trained on both annotations.
But I am looking to get the reported MR (11% and 7%) according to the paper. If not possible, please share only the proposals of the MSDS-RCNN
Thanks!.

@Li-Chengyang oh okay.
So the improved vgg model has been trained on the same improved annotations? But only the improved test set annotations are available. Will the improved training annotations be made available?
Also is it possible to share the proposals of the MSDS-RCNN?

In our project page, we have provided download links of all used data. There is no private data.
For proposals, as I can recall, we get ~99% recall using 50 proposals per image. I didn't save proposal files. Now that we have provided pretrained models, maybe you can generate proposal files yourself.


HTML does not autolaunch on first run with new install

Create new, blank execution environment:

new venv
new copy of tests
new install of pytest-tui

pytest --tui
See that auto launch of HTML does not occur
Running pytest --tui again results in correct behavior

With release of 1.6.0:

tui and tuih console scripts have been fixed and tested/working
tuiconf script is removed
Autolaunch option is deprecated/removed (tui and tuih still auto-load the TUI and HTML page in browser, but have to be invoked by user)

Please download/install latest version and let me know if you have any problems!


combined oxidative phosphorylation deficiency (MONDO:0000732) definition is truncated

Mondo term (ID and Label)
combined oxidative phosphorylation deficiency (MONDO:0000732)
Suggested revision of textual definition. Please include a source, like a PubMed ID (in the format PMID:#######)
A mitochondrial oxidative phosphorylation disorder in which multiple mitochondrial respiratory chain complexes.
is not a complete sentance
Your nano-attribution (ORCID)
If you don't have an ORCID, you can sign up for one here

Hi @ValWood,
Thank you for submitting this issue. The definition has been revised to "A mitochondrial oxidative phosphorylation disorder in which multiple mitochondrial respiratory chain complexes are affected."
The change will appear in the next release of Mondo.


Update header tracking to cover for menu and search button toggles

It wasn't clear that the toggle was affecting both buttons, and previously the GA values were the same for both when they should be distinct.
What
Fixes to header menu tracking events.
Why
As part of gathering some baseline data ahead of updating the header design.
Trello
Visual Changes
None

This was superseded by https://github.com/alphagov/govuk_publishing_components/pull/2143


removed extra prints

removed extra print statements in the LPC54018 NetworkInterface
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Calling vTaskNotifyGiveFromISR() without doing a yield, may not result in an immediate wake-up of the receive task rx_task().
+    BaseType_t xSwitchRequired = pdFALSE;
     switch( event )
     {
         case kENET_TxIntEvent:
             break;
         case kENET_RxIntEvent:
             {
                 vTaskNotifyGiveFromISR( receiveTaskHandle, &( xSwitchRequired ) );
+                portEND_SWITCHING_ISR( xSwitchRequired );
             }
             break;

BaseType_t xGetPhyLinkStatus( void )
{
    bool link;

    PHY_GetLinkStatus( &phyHandle, &link );
    return link ? pdTRUE : pdFALSE;
}

Like I said earlier: fetching the link status is expensive, and it may disturb ongoing transfers.  It would be better just to return a variable here, and keep the variable up-to-date in the rx_task() by polling the PHY status while there is no reception.
As long as you receive packets, you can safely assume that the PHY link status is high, and no polling is needed.
About xNetworkInterfaceInitialise(): this function will be called until it returns pdPASS.
In your case, it may happen that the initialisation will be done multiple times, until the PHY status is high.
Now your xNetworkInterfaceInitialise() always returns pdTRUE. If there is no link status yet, that would mean that DHCP will fail.
Please have a look at e.g. "STM32Fxx\NetworkInterface.c", in which a variable xMacInitStatus remembers if initialisation has taken place, and if it was successful..
    BaseType_t xResult = pdFAIL;
    if( xMacInitStatus == eMACInit )
    {
        xTXDescriptorSemaphore = xSemaphoreCreateCounting( ( UBaseType_t ) ETH_TXBUFNB, ( UBaseType_t ) ETH_TXBUFNB );
        if( xTXDescriptorSemaphore == NULL )
        {
            xMacInitStatus = eMACFailed;
        }
        else
        {
            xMacInitStatus = eMACPass;
        }
    }
    if( xMacInitStatus != eMACPass )
    {
        /* EMAC initialisation failed, return pdFAIL. */
        xResult = pdFAIL;
    }
    else
    {
        if( xPhyObject.ulLinkStatusMask != 0uL )
        {
            xResult = pdPASS;
            FreeRTOS_printf( ( "Link Status is high\n" ) ) ;
        }
    }
    return xResult;

Mind you: the function xNetworkInterfaceInitialise() is called from the IP-task, while rx_task() is supposed to check the link status.
Make sure that xNetworkInterfaceInitialise() doesn't access the MMI bus, because that code is "non-reentrant".
Hein


Pending verification > 30 days

10221 декларація не змінила статус pending_verification на active через 30 дні після укладенняPending.csv
person auth method OTP, OFFLINE

Looks like this issue was fixed in commit  583b513e310c1b094e48857fcfdc98445d917720

it has been released to prod already. But obviously it didn't help.

released to prod


[feature] remove call to getWorkflowRun API

The GH env variable contains a GITHUB_WORKFLOW_REF octocat/hello-world/.github/workflows/my-workflow.yml@refs/heads/my_branch.
I think we can parse this variable to set the workflow https://github.com/slsa-framework/slsa-github-generator/blob/main/.github/actions/verify-token/src/predicate.ts#L146
/cc @asraa

I'll do this later today.

Sweet! I also wasn't sure whether the other env vars were present though
https://github.com/slsa-framework/slsa-github-generator/blob/da4aab2134af8742cf08dbbd352b995edc03cb63/.github/actions/verify-token/src/predicate.ts#L165

Right. The context object from actions/toolkit includes woefully few values from the context and they are taken from the environment anyway. One of the reasons including the object in the provenance probably isn't all that helpful.
https://github.com/actions/toolkit/blob/d2b7d85e7cb61467395604aae1b84439c320cb84/packages/github/src/context.ts#L40-L52


Feature/pecl downloader

As mentioned in #726 , --download option doesn't apply to phpbrew ext install and phpbrew ext known when reading info from pecl site.

Coverage increased (+0.04%) to 53.39% when pulling 6bf11dde9b3030eece193c7c9faab4233cbcc80d on feature/pecl-downloader into 3f8d3d1c5078e03bfb7c344e3cee72ac8d686fe7 on master.

Looks good! Thanks!


Select multiple annotations

Used to be able to select (I think using command) multiple, non-contiguous annotations.
Along the same lines, used to be able to select a line, then drag down to select one or more contiguous annotations (for copying a group of annotations).

If you select observation, you can control click to select non-contiguous annotations. Please change this to selection of anywhere on the line.
Control click doesn't work to select a line, then drag down to select one or more contiguous annotations (for copying a group of annotations).

This works now (as a result of other changes).

Fixed in 0.2.1


Lost progress when reuploading large files after error

I was testing the large file (10GB) upload. I intentionally disconnected the network during the upload. The upload failed with an option to re-upload to resume the progress. But it failed to resume from where it left off (see the attached the screen shots).

I also tried a 26GB file and upload stopped a little past an hour. I couldn't resume the upload either through VAMS interface.


Create script to convert post/comments from GolosChain to CyberWay

Full information about

Posts
Comments

In Cyberway database golos.publication save data in format like this:
> db.votetable.find()
{ "_id" : ObjectId("5bd2f66ee5d50a6c855f13be"), "id" : NumberLong(1), "post_id" : NumberLong(1), "voter" : "user2", "percent" : NumberLong(0), "weight" : NumberLong(100), "time" : NumberLong(1540552303), "rshares" : [ ], "count" : NumberLong(-1), "_SCOPE_" : "user1", "_PAYER_" : "user2", "_SIZE_" : NumberLong(51) }
{ "_id" : ObjectId("5bd2f6fae5d50a6c855f13c4"), "id" : NumberLong(2), "post_id" : NumberLong(2), "voter" : "eosio", "percent" : NumberLong(33), "weight" : NumberLong(100), "time" : NumberLong(1540552443), "rshares" : [ { "net_rshares" : NumberLong(0), "abs_rshares" : NumberLong(0), "vote_rshares" : NumberLong(0), "children_abs_rshares" : NumberLong(0) } ], "count" : NumberLong(1), "_SCOPE_" : "user1", "_PAYER_" : "eosio", "_SIZE_" : NumberLong(83) }
>
>
>
>
> db.contenttable.find()
{ "_id" : ObjectId("5bd2f4e9e5d50a6c855f13b4"), "id" : NumberLong(1), "headerpost" : "Header", "bodypost" : "Body", "languagepost" : "ru", "tags" : [ ], "jsonmetadata" : "", "_SCOPE_" : "user1", "_PAYER_" : "user1", "_SIZE_" : NumberLong(25) }
{ "_id" : ObjectId("5bd2f6e5e5d50a6c855f13c1"), "id" : NumberLong(2), "headerpost" : "Header2", "bodypost" : "Body2", "languagepost" : "ru", "tags" : [ ], "jsonmetadata" : "", "_SCOPE_" : "user1", "_PAYER_" : "user1", "_SIZE_" : NumberLong(27) }
>
>
>
> db.posttable.find()
{ "_id" : ObjectId("5bd2f4e9e5d50a6c855f13b3"), "id" : NumberLong(1), "date" : NumberLong(1540551914), "account" : "user1", "permlink" : "permlink", "parentacc" : "", "parentprmlnk" : "", "curatorprcnt" : NumberLong(0), "payouttype" : "", "beneficiaries" : [ ], "paytype" : "", "childcount" : NumberLong(0), "status" : NumberLong(1), "_SCOPE_" : "user1", "_PAYER_" : "user1", "_SIZE_" : NumberLong(62) }
{ "_id" : ObjectId("5bd2f6e5e5d50a6c855f13c0"), "id" : NumberLong(2), "date" : NumberLong(1540552422), "account" : "user1", "permlink" : "permlink2", "parentacc" : "", "parentprmlnk" : "", "curatorprcnt" : NumberLong(0), "payouttype" : "", "beneficiaries" : [ ], "paytype" : "", "childcount" : NumberLong(0), "status" : NumberLong(1), "_SCOPE_" : "user1", "_PAYER_" : "user1", "_SIZE_" : NumberLong(63) }
>
>
>
>
> db.batterytable.find()
{ "_id" : ObjectId("5bd2f169e5d50a6c855f13aa"), "id" : NumberLong("4157831119891456672"), "posting_battery" : { "charge" : NumberLong(0), "renewal" : "2018-10-26T10:50:17" }, "battery_of_votes" : { "charge" : NumberLong(0), "renewal" : "2018-10-26T10:50:17" }, "limit_battery_posting" : { "charge" : NumberLong(0), "renewal" : "2018-10-26T10:50:17" }, "limit_battery_comment" : { "charge" : NumberLong(0), "renewal" : "2018-10-26T10:50:17" }, "limit_battery_of_votes" : { "charge" : NumberLong(0), "renewal" : "2018-10-26T10:50:17" }, "_SCOPE_" : "user1", "_PAYER_" : "user1", "_SIZE_" : NumberLong(38) }
{ "_id" : ObjectId("5bd2f23ce5d50a6c855f13ad"), "id" : NumberLong("4157831119891456672"), "posting_battery" : { "charge" : NumberLong(0), "renewal" : "2018-10-26T10:53:49" }, "battery_of_votes" : { "charge" : NumberLong(0), "renewal" : "2018-10-26T10:53:49" }, "limit_battery_posting" : { "charge" : NumberLong(0), "renewal" : "2018-10-26T10:53:49" }, "limit_battery_comment" : { "charge" : NumberLong(0), "renewal" : "2018-10-26T10:53:49" }, "limit_battery_of_votes" : { "charge" : NumberLong(0), "renewal" : "2018-10-26T10:53:49" }, "_SCOPE_" : "user2", "_PAYER_" : "user2", "_SIZE_" : NumberLong(38) }

#157


IndexError: list index out of range

我在本地语料库（您提供的axciv_data.csv），大模型我使用vllm中兼容openai的接口替换原本的openai的接口，运行的参数是：

但是一直报错：

经过排查发现是knowledge_curation.py  172line中 searched_results: List[StormInformation] = self.retriever.retrieve(list(set(queries)), exclude_urls=[ground_truth_url])无法查到searched_results，searched_results=[]
继续更深一步的排查，发现是rm.py 396line中，related_docs = self.qdrant.similarity_search_with_score(query, k=self.k)，related_docs 为空，请问这是因为什么。

Traceback:
File "/Users/admin/miniforge3/envs/storm/lib/python3.11/site-packages/streamlit/runtime/scriptrunner/script_runner.py", line 535, in run_script
exec(code, module.dict)
File "/Users/admin/AI/storm/frontend/demo_light/storm.py", line 64, in
main()
File "/Users/admin/AI/storm/frontend/demo_light/storm.py", line 60, in main
CreateNewArticle.create_new_article_page()
File "/Users/admin/AI/storm/frontend/demo_light/pages_util/CreateNewArticle.py", line 78, in create_new_article_page
st.session_state["runner"].run(topic=st.session_state["page3_topic"], do_research=False,
File "/Users/admin/AI/storm/src/storm_wiki/engine.py", line 305, in run
draft_article = self.run_article_generation_module(outline=outline,
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/admin/AI/storm/src/interface.py", line 376, in wrapper
result = func(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^
File "/Users/admin/AI/storm/src/storm_wiki/engine.py", line 196, in run_article_generation_module
draft_article = self.storm_article_generation.generate_article(
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/admin/AI/storm/src/storm_wiki/modules/article_generation.py", line 56, in generate_article
information_table.prepare_table_for_retrieval()
File "/Users/admin/AI/storm/src/storm_wiki/modules/storm_dataclass.py", line 161, in prepare_table_for_retrieval
self.encoded_snippets = self.encoder.encode(self.collected_snippets, show_progress_bar=False)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/admin/miniforge3/envs/storm/lib/python3.11/site-packages/sentence_transformers/SentenceTransformer.py", line 565, in encode
if all_embeddings[0].dtype == torch.bfloat16:
~~~~~~~~~~~~~~^^^_

I'm wondering if what's causing the error is that you are initializing an empty "./vector_store" without filling it with the documents in the csv file. Please try adding "--update-vector-store" as one of the arguments. This will tell the model to add the documents in the csv file to the offline vector store.

I'm getting this error either running the GUI with streamlit and in CLI. Tried to remove and reinstall Pytorch, Sentence Transformers etc., but nothing works :(

It is the same error as this one - with Sentence Transformers. Now I'm unable to run it using any of the options (local, GTP, Claude).

Did you check if it’s cause by rm.py line 396 returns empty result? And check @AMMAS1 response above. Does that solve your problem?

I tried running it with --update-vector-store argument with no help. How would i know if rm.py return empty result?

I tried running it with --update-vector-store argument with no help. How would i know if rm.py return empty result? EDIT. The only option which is actually working for me is with this command : python examples/run_storm_wiki_gpt_with_VectorRM.py --output-dir /Users/admin/AI/storm --vector-db-mode offline --offline-vector-db-dir /Users/admin/AI/storm --update-vector-store --csv-file-path /Users/admin/Downloads/polished_literature_articles_detailed.csv --do-research --do-generate-outline --do-generate-article --do-polish-article

Awesome! Glad to know it worked in the end. Would you mind sharing your first command (the one with "--update-vector-store") that didn't work so we can analyze where things went wrong?
For your question, if you're using your own data (as in using VectorRM class from rm.py), rm.py should not return an empty result as long as the vector store is not empty and search_top_k parameter is not 0, which is not the default.
In order to check if your vector store has data, you can call VectorRM.get_vector_count(), and it should return the number of chunks (your documents after chunking them) in the vector store. If that is zero, then rm.py would return an empty list.
Hope that helps!

I would like to use GUI tho. But getting the same error here too:
(storm) admin@teodor--macbook-pro demo_light % streamlit run storm.py
You can now view your Streamlit app in your browser.
Local URL: http://localhost:8501
Network URL: http://<IP_ADDRESS>:8501
root : ERROR    : Error occurs when searching query What is a sentinel node biopsy?: 'hits'
root : ERROR    : Error occurs when searching query How is sentinel node biopsy used in colon cancer?: 'hits'
root : ERROR    : Error occurs when searching query How does sentinel node biopsy help in the treatment of colon cancer?: 'hits'
root : ERROR    : Error occurs when searching query What is sentinel node biopsy in colon cancer?: 'hits'
root : ERROR    : Error occurs when searching query What is a sentinel node biopsy?: 'hits'
root : ERROR    : Error occurs when searching query What is sentinel node biopsy?: 'hits'
root : ERROR    : Error occurs when searching query How does a sentinel node biopsy work?: 'hits'
root : ERROR    : Error occurs when searching query How is sentinel node biopsy used in colon cancer treatment?: 'hits'
root : ERROR    : Error occurs when searching query What is the purpose of sentinel node biopsy in colon cancer treatment?: 'hits'
root : ERROR    : Error occurs when searching query What is the purpose of a sentinel node biopsy?: 'hits'
root : ERROR    : Error occurs when searching query What is the significance of a sentinel node biopsy in cancer treatment?: 'hits'
root : ERROR    : Error occurs when searching query Why is sentinel node biopsy important in colon cancer?: 'hits'
root : ERROR    : Error occurs when searching query Sentinel node biopsy in colon cancer: 'hits'
root : ERROR    : Error occurs when searching query Definition of sentinel node biopsy: 'hits'
root : ERROR    : Error occurs when searching query sentinel lymph node identification: 'hits'
root : ERROR    : Error occurs when searching query What is a sentinel node biopsy?: 'hits'
root : ERROR    : Error occurs when searching query What is a sentinel node biopsy?: 'hits'
root : ERROR    : Error occurs when searching query Sentinel node biopsy in colon cancer: 'hits'
root : ERROR    : Error occurs when searching query sentinel node biopsy colon cancer: 'hits'
root : ERROR    : Error occurs when searching query How is a sentinel node biopsy performed?: 'hits'
root : ERROR    : Error occurs when searching query Purpose of sentinel node biopsy in medical practice: 'hits'
root : ERROR    : Error occurs when searching query colon cancer surgery: 'hits'
root : ERROR    : Error occurs when searching query What is sentinel node biopsy?: 'hits'
root : ERROR    : Error occurs when searching query What is the purpose of a sentinel node biopsy?: 'hits'
root : ERROR    : Error occurs when searching query Explanation of sentinel node biopsy: 'hits'
root : ERROR    : Error occurs when searching query Sentinel node biopsy in colon cancer: 'hits'
root : ERROR    : Error occurs when searching query What is a sentinel node biopsy and how is it used in colon cancer diagnosis?: 'hits'
root : ERROR    : Error occurs when searching query Comparative studies of sentinel node biopsy in colon cancer and other cancers: 'hits'
root : ERROR    : Error occurs when searching query Definition of sentinel node biopsy: 'hits'
root : ERROR    : Error occurs when searching query Benefits of sentinel node biopsy in colon cancer: 'hits'
root : ERROR    : Error occurs when searching query What are the benefits and risks of a sentinel node biopsy compared to other types of biopsies for colon cancer?: 'hits'
root : ERROR    : Error occurs when searching query Sentinel node biopsy in colon cancer: 'hits'
root : ERROR    : Error occurs when searching query What is a sentinel node biopsy?: 'hits'
root : ERROR    : Error occurs when searching query Procedure for sentinel node biopsy in colon cancer: 'hits'
root : ERROR    : Error occurs when searching query How is a sentinel node biopsy performed in patients with colon cancer?: 'hits'
root : ERROR    : Error occurs when searching query Current evidence supporting use of sentinel node biopsy in colon cancer: 'hits'
knowledge_storm.interface : INFO     : run_knowledge_curation_module executed in 11.3001 seconds
knowledge_storm.interface : INFO     : run_outline_generation_module executed in 12.6983 seconds
sentence_transformers.SentenceTransformer : INFO     : Use pytorch device_name: mps
sentence_transformers.SentenceTransformer : INFO     : Load pretrained SentenceTransformer: paraphrase-MiniLM-L6-v2
2024-07-18 11:57:34.601 Uncaught app exception
Traceback (most recent call last):
File "/Users/admin/miniforge3/envs/storm/lib/python3.11/site-packages/streamlit/runtime/scriptrunner/script_runner.py", line 535, in _run_script
exec(code, module.dict)
File "/Users/admin/AI/storm/frontend/demo_light/storm.py", line 60, in
main()
File "/Users/admin/AI/storm/frontend/demo_light/storm.py", line 56, in main
CreateNewArticle.create_new_article_page()
File "/Users/admin/AI/storm/frontend/demo_light/pages_util/CreateNewArticle.py", line 78, in create_new_article_page
st.session_state["runner"].run(topic=st.session_state["page3_topic"], do_research=False,
File "/Users/admin/miniforge3/envs/storm/lib/python3.11/site-packages/knowledge_storm/storm_wiki/engine.py", line 315, in run
draft_article = self.run_article_generation_module(outline=outline,
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/admin/miniforge3/envs/storm/lib/python3.11/site-packages/knowledge_storm/interface.py", line 376, in wrapper
result = func(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^
File "/Users/admin/miniforge3/envs/storm/lib/python3.11/site-packages/knowledge_storm/storm_wiki/engine.py", line 197, in run_article_generation_module
draft_article = self.storm_article_generation.generate_article(
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/admin/miniforge3/envs/storm/lib/python3.11/site-packages/knowledge_storm/storm_wiki/modules/article_generation.py", line 57, in generate_article
information_table.prepare_table_for_retrieval()
File "/Users/admin/miniforge3/envs/storm/lib/python3.11/site-packages/knowledge_storm/storm_wiki/modules/storm_dataclass.py", line 162, in prepare_table_for_retrieval
self.encoded_snippets = self.encoder.encode(self.collected_snippets, show_progress_bar=False)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/admin/miniforge3/envs/storm/lib/python3.11/site-packages/sentence_transformers/SentenceTransformer.py", line 565, in encode
if all_embeddings[0].dtype == torch.bfloat16:
~~~~~~~~~~~~~~^^^
IndexError: list index out of range

I'm wondering if what's causing the error is that you are initializing an empty "./vector_store" without filling it with the documents in the csv file. Please try adding "--update-vector-store" as one of the arguments. This will tell the model to add the documents in the csv file to the offline vector store. # @AMMAS1
谢谢您，如您所说，解决了这个问题