Feature Discussion: Slice selector behavior with combineReducers

Slices have been a great improvement in our code base for isolating all the previous patterns (actions / action creators, reducers, selectors) to slices. The last piece we are looking to isolate is selecting sub-state in a slice when using combineReducers in a tree structure. It seems that the slice's exposed selector expects the state to be the parent relative to that slice but in the connect function from react-redux we are given the rootState. With the rootState we have to know how to get to the sub-state where the slice lives.
I've read several thoughts on here about combineSlices which could be a good approach to solving this. The slice could then expose a function which given a rootState knows how to return the slice.
Our example state tree:
- rootState
   - screens
      - screen1
      - screen2
           - userName
           - userEmail

so if we had a slice for screen2, the connect function on screen2 looks something like:
connect(
     (rootState) => ({
             userName: rootState.screens.screen2.userName
     },
     {
             setUserName: slice.actions.setUsername,
     },
)(screen2Component);

This means the component needs to know the structure of the state. Instead you could imagine something like:
connect(
     slice.selector,
     slice.reducers,
)(screen2Component);

or
connect(
     (rootState) => ({
             userName: slice.selector(rootState).userName
     },
     {
             setUserName: slice.actions.setUsername,
     },
)(screen2Component);

Any thoughts or ideas? I am definitely willing to help work on solving this. I want to minimize the amount of places that know the structure of the actual state. Leaving structure to combineSlices
alone seems to be the best bet.

I really don't have any good answers on this.  This is basically the "encapsulated selectors" question, which Randy Coulman wrote about here and the other linked posts:
Solving Circular Dependencies in Modular Redux.

Coming back around to this.  I think the conclusion is that we're going to remove any slice-specific selector functionality, and leave it up to you to define whatever selectors you feel are appropriate, same as with any other Redux app.  (See #91 for some related thoughts.)


API documentation

Add documentation to https://app-wallet-interface.netlify.com/#create-channel that covers all the new API methods that we have introduced.

Closing in favor of https://github.com/statechannels/monorepo/issues/1853


Redundant delete in update?

What happened:
I am reading the code in /bpf/deserialization_to_bpf_map/deserialization_to_bpf_map.c
https://github.com/kmesh-net/kmesh/blob/25f8959465440ee03362f41126dae7c6afe759af/bpf/deserialization_to_bpf_map/deserialization_to_bpf_map.c#L586-L600
i think the delete operation here is not aligned with bpf map update?
What you expected to happen:
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:
Environment:

Kmesh version:
Others:

cc @nlgwcy


Add feature to allow for automatic wifi connection after reboot.

Add feature to allow for automatic connection to a commonly used wifi connection as is done with an ethernet connection.
The problem is the end user has to manually setup wifi connection each time after a system reboot. For instance, if ethernet is not found to automatically attempt to connect to a previously set wifi connection.

Run these commands to enable and start wpa_supplicant service.
sudo rc-update add wpa_supplicant default
sudo service wpa_supplicant start

No action necessary as enhancement already exists. Closed ticket.


District numbers and outlines

Adds zone numbers to map. Hacky approach, but mostly works
Description

If selected, this option grabs the rendered map features, dissolves the geometries based on the zone assignment, and adds labels to the map with the zone numbers

Reviewers

Primary: @raphaellaude
Secondary: @mariogiampieri

I've taken another pass to optimize and clean up the way this works a bit. Previously, this functionality added a bunch of map.queryRenderedFeatures calls, which are generally not very good.
Now, whenever a tile loads in, the event listener (map.on("data")) caches the IDs for painting by county and sends the geometry to the geometry worker (WebWorker, off-main-thread) and that caches the geometries if not already present. We keep track of the x-y-z index of the tile, so there isn't a ton of work duplicated. The only additional work here is some stringification for data sent from the main thread to the worker, but it is relatively minimal.
Whenever the assignments updates, the results get sent to the worker which mutates its copy of the data with the updated zones. When zone districts are toggled on or the viewport changes, the worker uses bboxClip followed by dissolve(by="zone") to get zone geometries and center of mass. The center of mass is checked to make sure its actually in the geometry, and if not a random point in the geometry is chosen.
I think there are some additional use cases that will be good to have this amount of geometric data available on the client, and having it on a separate thread means that UX performance impact is minimal. I'm fairly convinced this is a reasonable direction, especially in the interest of keeping the backend lightweight -- eager to hear feedback from you all @raphaellaude @mariogiampieri !

Thank you @mariogiampieri! I just updated the unused imports and added a couple notes to our future selves.

PS This closes a few issues:

#96
#98


[Bug] [Doc] [Web] Fix web doc bug

Search before asking

[X] I had searched in the issues and found no similar issues.

What happened
The document version may be faulty.

SeaTunnel Version
2.3.3
SeaTunnel Config
No

Running Command
No

Error Exception
No

Zeta or Flink or Spark Version
No response
Java or Scala Version
No response
Screenshots
No response
Are you willing to submit PR?

[X] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

hi, @ldxwmr Has he made any new progress?


add python 3.13 to build workflow

Testing to see whether python 3.13 will work with our CI

Looks like ray doesn't support 3.13 at the moment

yes, ray is the bottleneck for now.


Move Victim Standard Action on Affiliation child handler with Primary Affiliations

@kyleschmid Hey Kyle, I noticed a problem that I can't seem to get around in my HEDA org.  I also swear I didn't experience this before when I was testing about a month ago.  Here is my scenario:
Contact Parent Handler
Affiliation child handler with Move Victim and Keep Master Actions.
When I merge two Contacts, each with it's own distinct primary Business affiliation (that is, pointing to 2 different business accounts), the HEDA affiliation trigger runs and creates another primary affiliation.  So the master contact now has both original affiliations (desired) plus a new primary affiliation created by the HEDA trigger handler.  This results in duplicate affiliations for the same Business Account.  Also, the new primary affiliation that was created is for the victim Account affiliation and not the master Account affiliation.  It's like it's no longer respecting the Keep Master action and allowing the victim to kick off the HEDA trigger handler.

@dougbennett I think this is actually a bug with HEDA. I tested some things out and it seems that when you re-parent any primary Affiliation with a new Contact, HEDA will populate the primary lookup field on the Contact, resulting in an additional primary Affiliation being created and the primary flag on the existing one getting set to false. This may be worth logging an issue on the HEDAP repo for.

@kyleschmid Ok, thanks for validating that.  I will certainly log an issue in the HEDA repo.


chore: add doc edit button

Summary

Add the config options to show the "edit" button on the docs.

Motivation

Lowering the barrier for contributions.
Author Checklist

[x] Changes are motivated and described in the PR description.
[x] Testing strategy is described if automated tests are not included in the PR.
[x] Documentation is updated if necessary.
[x] Status checks pass.
[x] If the version number is changed, it is updated in pyproject.toml , aineko/__init__.py, aineko/templates/first_aineko_pipeline/{{cookiecutter.project_slug}}/pyproject.toml.

Reviewer Checklist

[ ] Title is accurate and formatted appropriately.
[ ] No unnecessary changes are introduced.
[ ] Description motivates each change.
[ ] Docs are updated if necessary.
[ ] Code is pythonic and consistent with the rest of the codebase.
[ ] The code is consistent with the style guide.

Do you know what this does? Does it create a new PR on the github?

Do you know what this does? Does it create a new PR on the github?

If you have push access:
It will open the page your on in edit mode on GitHub.
Example: https://github.com/aineko-dev/aineko/edit/develop/docs/index.md
Upon saving GH will ask you to commit your change:

If no push access


Fix a bug in use of no_use_multiple_sdk_containers experiment flag.

Fix a bug in use of no_use_multiple_sdk_containers experiment flag.Setting this flag should prevent the addition of use_multiple_sdk_containers experiment.

Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

It will help us expedite review of your Pull Request if you tag someone (e.g. @username) to look at it.


Tests of components using Moment-Timezone throw errors

Describe the bug
I realize this is an outdated library, but we're stuck with it until we can rewrite to get on date-fns or something like that.
Basically, running Vitest causes this error with moment-timzone, which we don't see when running Vite.
TypeError: Cannot read properties of undefined (reading 'format')
 38|                 {moment(props.children)
 39|                     .tz("timezone here")
 40|                     .format("format string here")

I am importing moment timezone like this:
import moment from "moment-timezone";
Any tips/hacks/workarounds would be appreciated!
Reproduction
write a function using moment-timezone's .tz function
run "vitest"
the output of .tz() is undefined
System Info
System:
    OS: Windows 10 10.0.19042
    CPU: (8) x64 Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz
    Memory: 14.38 GB / 31.83 GB
  Binaries:
    Node: 16.13.2 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.22.4 - C:\Program Files (x86)\Yarn\bin\yarn.CMD
    npm: 8.1.2 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Chrome: 100.0.4896.75
    Edge: Spartan (44.19041.1266.0), Chromium (100.0.1185.39)
    Internet Explorer: 11.0.19041.1202
  npmPackages:
    @vitejs/plugin-react: 1.1.4 => 1.1.4
    vite: 2.9.1 => 2.9.1
    vitest: ^0.9.3 => 0.9.3

Used Package Manager
yarn
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

I'm also new to Vitest but I'm thinking if deps.inline might worth a try, see this other issue #843 which seems similar. Also note that Vitest is ESM first and that is causing problem with older libs.

Probably not an option for everyone, but I ended up just refactoring and removing moment-timezone from our codebase entirely.

lol yeah when you have that option to refactor then it's nice even if it takes more time at first. On my side, I was fighting with Axios which doesn't ship an ESM build and had some import and require() in its codebase and the require is the big issue for a Vite prod build (because of RollupJS which doesn't like require) and had to also adjust Vitest to work too, I came up with something like this in my vite.config.js which is not great but seems to work
deps: {
  inline: ['@bundled-es-modules/axios'],
},

@bundled-es-modules is a lib forked from Axios to export semi-ESM code... so kinda related to your issue but yeah it's a bit painful to deal with old lib in both Vite/Vitest, not everything is ESM ready yet :S


Batched PolyOps interface

This change is

Codecov Report
Attention: Patch coverage is 88.99083% with 24 lines in your changes are missing coverage. Please review.

Project coverage is 93.95%. Comparing base (a5e69d9) to head (8669469).

Files
Patch %
Lines

crates/prover/src/core/backend/avx512/circle.rs
89.47%
12 Missing :warning:

crates/prover/src/core/backend/cpu/circle.rs
86.51%
12 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #577      +/-   ##
==========================================
+ Coverage   93.91%   93.95%   +0.04%
==========================================
  Files          67       67
  Lines        8413     8470      +57
  Branches     8413     8470      +57
==========================================
+ Hits         7901     7958      +57
  Misses        448      448
  Partials       64       64

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Have paper key, but can't find any way to use it to recover account.

Hi, I no longer have access to a logged in device, however I do have my paper key. Unfortantely running 'keybase login' only prompts me for a password and I can't find any way to provide my paper key.
I know I have the paper key tied to the account because if I attempt to recover the account via the web it lists the paper key with the exact two starting words as an option with the "power to change your passphrase".
Am I missing something? I can't find any documentation about how to use a paper key other than it exists, how to generate one, and that it can somehow be used to recover my account.

keybase login username shows me the prompt for password. How do I get an option to enter my paper key?


fix: 407 sigsegv when modifying topologies config

Fixes SIGSEGV error triggered by nil pointer dereferenced under certain conditions. Some of these conditions are listed in 407.
Description
After importing an ec_deployment resource with configuration blocks inside topology blocks for elasticsearch, such as user_settings_yaml inside a master topology configuration block, into Terraform, every change to that configuration will trigger a SIGSEGV as a nil pointer is dereferenced. This change fixes the issue by initialising that pointer when needed.
Related Issues
https://github.com/elastic/terraform-provider-ec/issues/407
Motivation and Context
Modifying some ec_deployment resources after importing them into Terraform fails with a SIGSEGV (see issue above).
How Has This Been Tested?
Added unit test.
Types of Changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Refactoring (improves code quality but has no user-facing effect)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation

Readiness Checklist

[x] My code follows the code style of this project
[ ] My change requires a change to the documentation
[ ] I have updated the documentation accordingly
[x] I have added tests to cover my changes
[x] All new and existing unit tests passed
[] All new and existing tests passed

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

Thank you for your contribution @luigibk. I triggered tests, let's wait for their results


For non-master (read - backporting) prs disable all health checks for origin logging tests

We only want to disable them for the origin aggregated logging repo and only if they are release-* branches.
PTAL @sosiouxme @richm @stevekuznetsov

Logging runs into enough random other stuff that reducing what can go wrong seems like a worthy goal. I'm a little skeptical that this helps though... I don't know that this logging test is running into check failures that aren't showing up in every other test too. Backport tests are running into more version failures because the CI env results in more dependency quirks, and since logging does a lot of backports... that's a frequent pain.
But see this test today for instance. Four other tests on the PR had checks fail on the same thing, but in this one the failure happened outside the check anyway. The check's just usually the first thing to fail... something else is likely to fail if the check is disabled. (Notably, not true in the case of the docker-1.13 issue.)
I'm fine with this if you want. The only real harm is in adding another logical branch. Just not sure it's going to help either.

This is no longer needed, the problem has been resolved on 3.7 by https://github.com/openshift/openshift-ansible/pull/7347


Adding "input()" as element to Cli2gui.

Feature

[x] I have read the comment above and have completed each step
[ ] I have filled in each heading below

Is your feature request related to a problem? Please describe

Describe the solution you'd like
A possible options it's to add "input ()" build-in function like readable option.
Describe alternatives you've considered
Instead of;
@Cli2Gui(argparse="argparse"...)
Can be possible put ...?
@Cli2Gui(argparse="inpu" ...)
Def func():
Var=imput ("...")
Many thanks in advance.

Sounds like a pretty good idea. I'll take a look at this over the next few weeks

Thanks. Sorry if now I can't help. Because I have too much work. But after
read your code (BTW; beautiful!) I think the easy way it's recycling one of
the existing  functions. And adapt the code to parsing in a list the
population of inputs and the texts between "".
It's my two cents.
El mié., 14 jul. 2021 19:19, Kieran W @.***> escribió:

Sounds like a pretty good idea. I'll take a look at this over the next few
weeks
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/FHPythonUtils/Cli2Gui/issues/4#issuecomment-880070802,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABVYCAO6CT2JDD7GG3244I3TXXBKVANCNFSM5AGOCU2Q
.

Should be addressed in the latest version


Merge whitelist into devel

I think the whitelist is done for now. There are conflicts between the branches; probably because I moved the header and footer into different files.

@Mcat12 Can you check the merge conflict resolution and see if it looks good to you?

I think it looks good... Were the only conflicts in the readme and api.php?

No, just index.html. The rest merged okay.

Do you mean index.php? I only see the readme and api.php changed in the commit

Sorry, yes I meant index.php. It's in the parent commits. If you pull the whitelist branch it should be set now to what will be merged into devel.

It's so annoying to not be able to see a commit graph since the AdminLTE fork list is too big for github... I'm going to see if I can find an easier way to figure this out.

CLI

Ya. I kind of like Github's a little better though.

Yeah, I guess that would look kind of nasty as a git log prettyprint in ascii

This looks interesting: http://ghv.artzub.com/

You can probably merge this.


Test and deploy a MongoDB backup mechanism

Impact of the new feature
WMCore microservices using MongoDB
Is your feature request related to a problem? Please describe.
The CMSWEB team has been evaluating technologies to backup the MongoDB databases stored in the MongDBAaS cluster.
Right now those databases lack of any backup mechanism and we would like to have automated backup to be able to recover from possible accidents.
This issue is tracked by the HTTP/CMSWEB team in this ticket: https://its.cern.ch/jira/browse/CMSKUBERNETES-242
The corresponding WM wiki page can be found here: https://github.com/dmwm/WMCore/wiki/MongoDB-backup-and-restore-procedure
Backup details

database names: msPileupDBPreProd, msOutputDBPreProd and msUnmergedDBPreProd
frequencies: 4 hour (production) and 12 hours for preproduction
retention policy: 10 days
EOS location: /eos/project-c/cmsweb-http/mongodb/backups/<preprod,prod>

Describe the solution you'd like
Together with the HTTP/CMSWEB team, decide which technology will best suit our needs (which are?) and the CMSWEB/Kubernetes infrastructure.
In addition to providing the CMSWEB team with our requirements for this backup, it will also involve testing things out whenever they are deployed, studying backup options, etc.
Describe alternatives you've considered
None
Additional context
None

@vkuznet Valentin, when self-assigning an issue that you are starting to work on, please remember to move its "Status" from ToDo to In Progress. I have just done so on this issue.

The implementation on CMSWEB is completed and all components are in place. Said that, I need input which routes to use for alerts. So far they will go to alerts-mongodb-k8s-cluster MM channel. Is it sufficient or do we need another MM channel and/or email/e-group. @amaltaro please provide your insight.

I think these alerts need to reach mainly 2 teams:
a) HTTP CMSWEB
b) WMCore
we can discuss potential egroups in mattermost.

Alan, please be specific which channel for WMCore team to use. I can ask for either one on MM< e.g. use WM Ops, etc. I can't guess just based on group name as I need to tell CMS Monitoring team concrete channel to add to AM configuration.

We finished technical implementation on CMSWEB side (https://its.cern.ch/jira/browse/CMSKUBERNETES-242) and I created an additional ticket on CMS Monitoring side (https://its.cern.ch/jira/browse/CMSMONIT-583) to add appropriate e-group (cms-service-webtools) into AlertManager. Once it will be configured we'll get alerts in alerts-mongodb-k8s-cluster MM channel and in this e-group.

@amaltaro , @klannon please review provided new description as we done with technical implementation. All work were done through https://its.cern.ch/jira/browse/CMSKUBERNETES-242 ticket and there is no dedicated PR on WM side (as it is not required). Also, the alerts configuration will be in hands of CMS Monitoring group and I updated description with corresponding entry about their ticket https://its.cern.ch/jira/browse/CMSMONIT-583. I can either close this issue or I will keep it open until CMS Monitoring group will add appropriate changes to AlertManager (add new e-group). Said that, the new image for MongoDB back exists and deployed on mongo test cluster. If you are ok with final proposal I'll ask @arooshap to deploy new image to cmsweb testbed and we'll start using it.

The changes to CMS Monitoring Alert Manager are done over here: https://gitlab.cern.ch/cmsmonitoring/cmsmon-configs/-/merge_requests/56/diffs and if we'll need to change/adjust them we should use https://its.cern.ch/jira/browse/CMSMONIT-583 ticket.

I think now everything is in place and we may close this ticket as resolved. The actual back up now in hands of CMSWEB group. @amaltaro , @klannon please provide your feedback and decide if we should close the issue or anything else should be done here. Alan, I updated wiki page and added failure section where I outlined how alerts will be routed.

Awesome! Thank you for proactively updating the documentation as well:
https://github.com/dmwm/WMCore/wiki/MongoDB-backup-and-restore-procedure
which summarizes policy and decisions that we have taken. I think we can indeed close this out now, here we go!


rotates before resize, to comply with height/width constraints

See #123 , which is still an occuring problem in my case in v3.4.1

Thanks for the bugfix - I haven't tested it, I'm happy to trust that your code is good :-)


Peer to Peer code review

Awsome work 💯
I suggest that you don't need to repeat the commits like when you corrected the image you have committed many commits about the page.
Excellent job overall 🔥 🔥

You have done a Great job on Your Capstone Project👏
There are no issues to be addressed.

Thank you @IfzaRasool  and @abdulrahmanshr75. I really appreciate your reviews. I am going to improve my design like on the margin-bottom of the showcase section and in other parts. so as to make it perfect.


Multiplicity vs cardinality

In the data dictionary, the term "multiplicity" is used, whereas the term "cardinality" is used in the requirements. Preferably, the same term should be used throughout the whole document, and as the modeling language is UML, that should be "multiplicity". If desired, a reference to https://martinfowler.com/bliki/MultiplicityNotCardinality.html could be added.

@heidivanparys The requirement and ATS templates have been updated to use multiplicity rather than cardinality.

Agreed for Chuck to close at 20 August 2020 SWG meeting after Chuck has updated the requirements and ATS.

Agreed by unanimous consent, closed 3 Sept meeting


Compatibility with Python 3.7 and 3.8

Current build has no compatibiliy with python 3.7 and 3.8 as we are  relying on python 3.9 ast.unparse for generation of code. The current compatibility mode using astunparser fails on pthon 3.7 and python 3.8.

Additionaly 3.7 doesn't know the walrus operator := which is introduced first in 3.8.
From the test runner
turms\run.py:5: in <module>
    from turms.helpers import import_string
E     File "D:\a\turms\turms\turms\helpers.py", line 11
E       (module := sys.modules.get(module_path))
E               ^
E   SyntaxError: invalid syntax

This is a monument to why just copy paste from Django source code is not the smartest idea.

In general, you should be able to separate code generation from code usage (e.g. as GQL-Client).
That would allow you, to put the complete code generation into a Dockerimage* with a single python version (you could mount generated and source files + config as volumes).
The generated code may then be used by other projects with arbitrary python 3.x versions that doesn't even require turms as a dependency.
For the latter, you'd need to embedd all imported classes into the generated Code itself.
This would make turms a pure dev-dependency, as it should be for a codegen-tool.
*Dockerimage is just an example for an independent project. It could be another venv with the required python version as well.

Completely agreed. I think that should be the set goal. I did just (accidentally) merge a pull request the other day that should address part of the issue : everything should now rely solely on pydantic.BaseModel.
And I love, love docker container idea! Would you be willing to write a PR?
I also changed the funcs plugin to in theory call any function and pass along additional signature (Addressing  the issue that you don't have to rely on contextvars or global context but can actually pass your gql client). So there is no longer any need for custom query classes as that would happen in the function.
Also there is now docosaurus website, that should host the documentation at some point. If you have some time, let me know what you think or alter as you wish :D
Thanks for your contributions!

Docker should be done pretty fast
It just requires a dockerfile like this:
FROM python:3.9-alpine  # small python base image

RUN pip install turms  # maybe fix version to image tag and include optional dependencies

VOLUME /graphql.config.yaml
VOLUME /generated
WORKDIR /

CMD ["turms", "gen"]

There are two things to notice here:

We need to mount the generated files as a volume, to get them outside of the docker container.
The location must match with the configuration.

It'd also be nice to "bake" a reasonable default config into the dockerimage that can be overriden by file-mounting it with a custom file.
Even better would be an approach via environment variables.
We could leverage pydantic's BaseSettings for this.
Do you know, if pydantics settings support setting nested values through env vars?
Icing on the cake would be CI (e.g. GitHub Action) + a public docker repo (e.g. dockhub)


[v3 rc4] IE11 font XML error (potential solution)

When I try to load in a bitmapFont XML in IE11 PIXI tries to access 'resource.data.frames' but it is 'Permission Denied' and breaks the page with an Exception, adding the mimeType check skips the if statement before it reaches IE and then works as expected.
I think it's line 10 of loaders/spritesheetParser.js    (it was line 23317 is off the fully compiled pixi.3.0.0.js)
if (!resource.data || resource.data.mimeType == "XML File" || !resource.data.frames)

Sounds like one for you @englercj . IE is fun :)

ugh, IE. Do you have a repo page I can test on? Thanks!

IE is always fun, like the mimeType being XML Document and not XML File in different versions! so this new fix is better
if (!resource.data || (resource.data.mimeType && resource.data.mimeType.indexOf("XML") > -1) || !resource.data.frames)
i've created a version for you here
http://kokodev.co.uk/pixifontbugie/index.html  - example of error
http://kokodev.co.uk/pixifontbugie/fixed.html  - a page with my fix in

ahh the issue may be deeper than that line, that fixes it for IE11 but in IE9 I get
Unable to get value of the property 'toString':object is null or undefined
which is from the reqType(xhr) function as xhr is undefined.
when loading a texturejson file the json response body is empty within the network panel even though it gets a 200 headers

Ok, just pushed a commit that should fix this. I added some helpers in v1.4.0 of the resource-loader that allows you to tell what the data is without weird duck typing. So now the parsers in pixi can check if the data is json, xml, etc safely and then operate.
It should clear up this issue, just know you will need to build your own from the latest dev branch and you must update the local install of resource-loader you might have to v1.4.0 (npm update resource-loader --depth=0). Then you can try it out.


[tool_crash] FileSystemException: Cannot copy file to 'C:\Users\admin\Desktop\andrew ng\saltsweet\android\app\src\main\res\mipmap-hdpi\ic_launcher.png', OS Error: Access is denied., errno = 5

Command
flutter create --ios-language swift --android-language kotlin .

Steps to Reproduce

...
...
...

Logs
FileSystemException: Cannot copy file to 'C:\Users\admin\Desktop\andrew ng\saltsweet\android\app\src\main\res\mipmap-hdpi\ic_launcher.png', OS Error: Access is denied.
, errno = 5
#0      _File.throwIfError (dart:io/file_impl.dart:635:7)
#1      _File.copySync (dart:io/file_impl.dart:340:5)
#2      ForwardingFile.copySync (package:file/src/forwarding/forwarding_file.dart:30:50)
#3      ForwardingFile.copySync (package:file/src/forwarding/forwarding_file.dart:30:50)
#4      Template.render.<anonymous closure> (package:flutter_tools/src/template.dart:267:18)
#5      _LinkedHashMapMixin.forEach (dart:collection-patch/compact_hash.dart:377:8)
#6      Template.render (package:flutter_tools/src/template.dart:190:24)
#7      CreateCommand._renderTemplate (package:flutter_tools/src/commands/create.dart:799:21)
#8      _rootRunUnary (dart:async/zone.dart:1198:47)
#9      _CustomZone.runUnary (dart:async/zone.dart:1100:19)
#10     _FutureListener.handleValue (dart:async/future_impl.dart:143:18)
#11     Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:696:45)
#12     Future._propagateToListeners (dart:async/future_impl.dart:725:32)
#13     Future._completeWithValue (dart:async/future_impl.dart:529:5)
#14     _AsyncAwaitCompleter.complete (dart:async-patch/async_patch.dart:40:15)
#15     _completeOnAsyncReturn (dart:async-patch/async_patch.dart:311:13)
#16     Template.fromName (package:flutter_tools/src/template.dart)
#17     _rootRunUnary (dart:async/zone.dart:1198:47)
#18     _CustomZone.runUnary (dart:async/zone.dart:1100:19)
#19     _FutureListener.handleValue (dart:async/future_impl.dart:143:18)
#20     Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:696:45)
#21     Future._propagateToListeners (dart:async/future_impl.dart:725:32)
#22     Future._completeWithValue (dart:async/future_impl.dart:529:5)
#23     _AsyncAwaitCompleter.complete (dart:async-patch/async_patch.dart:40:15)
#24     _completeOnAsyncReturn (dart:async-patch/async_patch.dart:311:13)

[✓] Flutter (Channel stable, 1.22.1, on Microsoft Windows [Version 10.0.18362.1082], locale en-GB)
    • Flutter version 1.22.1 at C:\src\flutter
    • Framework revision f30b7f4db9 (6 days ago), 2020-10-08 10:06:30 -0700
    • Engine revision 75bef9f6c8
    • Dart version 2.10.1

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
    • Android SDK at C:\Users\admin\AppData\Local\Android\sdk
    • Platform android-29, build-tools 29.0.3
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b03)
    • All Android licenses accepted.

[✓] Android Studio (version 3.5)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin version 44.0.1
    • Dart plugin version 191.8593
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b03)

[!] IntelliJ IDEA Ultimate Edition (version 2019.3)
    • IntelliJ at C:\Program Files\JetBrains\IntelliJ IDEA 2019.3.4
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    • Dart plugin version 193.6911.31
    • For information about installing plugins, see
      https://flutter.dev/intellij-setup/#installing-the-plugins

[✓] VS Code (version 1.50.0)
    • VS Code at C:\Users\admin\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.14.1

[!] Connected device
    ! No devices available

! Doctor found issues in 2 categories.

Flutter Application Metadata
No pubspec in working directory.

Hi @ibrahimhadji
Duplicate of https://github.com/flutter/flutter/issues/67141 .
Please see this  comment and try the same at your end to see if it works.
Thank you

Yes this one is a duplicate of https://github.com/flutter/flutter/issues/67141.
Closing as duplicate. Please follow up on that issue.


ja: fix OnlineUsers count

current

new

Fixed variables and phrasing to ensure correct information is displayed.

Thank you very much! Merging this in!


Update README.md

Added English translation of template.yaml

follow the Installation but config error.  Don't know what wrong

Apologies for the Late Reply.🙏
I am not expecting someone making a pull request and surprisingly to see english user to use my fork😁
In the latest release i embedded both apparent temperature and uv index sensor into js file and made it translatable from lovelace's setting.
The English translation referred to hko weather icons and i had made 2 changes to shorten the text when considering the width of lovelace.

Sunny Periods with A Few Showers -> Light Showers
Sunny Intervals with Showers -> Showers

Please feel free to comment if you have any other ideas.

thanks for the card, looks really good!
would be nice to be able to see typhoon related info as well
anyways....im not sure where to put this since i cant seem to report issues for this repo

the install guide does not match the current package downloaded from hacs, i manually added the rest.yaml and template.yaml entries and got it to work
hko_wind_speed and hko_wind_gust sometimes returns blank in the csv causing error messages in homeassistant.log

ValueError: Sensor sensor.hko_wind_gust has device class 'wind_speed', state class 'None' unit 'km/h' and suggested precision 'None' thus indicating it has a numeric value; however, it has the non-numeric value: '' (<class 'str'>) 2023-09-05 19:12:41.592 ERROR (MainThread) [homeassistant.components.sensor] Error while setting up rest platform for sensor Traceback (most recent call last):   File "/usr/src/homeassistant/homeassistant/components/sensor/__init__.py", line 591, in state     numerical_value = int(value)                       ^^^^^^^^^^ ValueError: invalid literal for int() with base 10: ''
replacing the sensor code in rest.yaml with below fixes the error
{% if is_number(ns.s) %}           {{ ns.s }}         {% else %}           {{ 0 }}         {% endif %}

thanks for the card, looks really good! would be nice to be able to see typhoon related info as well
anyways....im not sure where to put this since i cant seem to report issues for this repo

the install guide does not match the current package downloaded from hacs, i manually added the rest.yaml and template.yaml entries and got it to work
hko_wind_speed and hko_wind_gust sometimes returns blank in the csv causing error messages in homeassistant.log

ValueError: Sensor sensor.hko_wind_gust has device class 'wind_speed', state class 'None' unit 'km/h' and suggested precision 'None' thus indicating it has a numeric value; however, it has the non-numeric value: '' (<class 'str'>) 2023-09-05 19:12:41.592 ERROR (MainThread) [homeassistant.components.sensor] Error while setting up rest platform for sensor Traceback (most recent call last): File "/usr/src/homeassistant/homeassistant/components/sensor/__init__.py", line 591, in state numerical_value = int(value) ^^^^^^^^^^ ValueError: invalid literal for int() with base 10: ''
replacing the sensor code in rest.yaml with below fixes the error
{% if is_number(ns.s) %} {{ ns.s }} {% else %} {{ 0 }} {% endif %}

Thanks for reporting and  i had enabled the issues feature in setting and updated the rest.yaml in latest release.
Yeah i am preparing to add the warnsum but also finding how to add to the card looks better, such as using HKO original icons for all warning or, placing warnings other than typhoon in slot section.
Here is my self-made typhoon svg

maybe something like a png to svg converter? https://new.express.adobe.com/tools/convert-to-svg
and manually cleaning up the colors afterwards?
sorry i am useless at anything related to graphics or trying to make things looks nice
anyways keep up the great work and thanks for updating!


release: pg_idkit v0.2.3

This is a release prep branch for pg_idkit release v0.2.3.
Upon merging, this branch will cause a tag to be placed on the commit in main. After the tag has been placed, a build will run that generates artifacts and publishes a release.
Before this release is ready, here is the checklist:

[ ] Update the examples in README.md to use the newest version
[ ] Update generate-rpm configuration in Cargo.toml version references (ex. --0.2.0.sql -> --0.2.1.sql)

See CHANGELOG for changes made to this release before it goes out.

Before this release can go out, https://github.com/VADOSWARE/pg_idkit/pull/64 needs to get merged and this PR should be rebased to it.


Regular donation

Hello !
Is there any way we can make a monthly donation to thank you for django-material development ? Materializecss has patreon and we're sponsoring :guitar:
Note: we're not using any viewflow pro software so we're not buying anything from your company so far, hence my question.
Thanks

No. Django-material has separate commercial licence. Django-material v2 going to be AGPL licenced, that would help to sustain that project.

Thanks, got viewflow pro, I thought it was 450$/month :rofl:
Got my material frontend pro license ;)


Injection molding allocation

Two injection molding processes for polypropylene and LLDPE have two product outputs for packaging scrap. Checking with author if these should be waste flows.

Converted to waste flows

Applied the same process to open molding processes


Enhancement: Remove the "repeat delay" when longpressing the the jog-wheel

When longpressing the jog-wheel for example to enter a seed phrase manually it's a bit annoying to have the "repeat delay" when longpressing the wheel to the left or the right to quickly navigate to a certain letter. After the first move/step its annoying to have to wait that long before the cursor moves further.
Would be awesome to have that removed because it would enable a much quicker control, more responsive navigation.

Obviously its present so what is intended as a single click isn't interpreted as multiple - but we can certainly look to make the delay smaller.

Awesome! Thanks a lot.

Just another idea: Why not have a topic in settings along with screen brightness, where we have "Key repeat delay" with the options "Off, Short Long". That would be really focussing on individual user experience.

Are you finding that any better in the latest fw release, 1.0.24 ?
The lib that handles button events was updated, and this slightly altered the repeat behaviour.
(Obviously we can't make it too sensitive, or it double 'events' when you only intended single.)
Yes, the user preference/setting is a fair idea.

Hey. Not noticing an real difference for now. Actually overall it's okay like it is, the only really annoying part where I wish it would be much shorter is, when I recovery a wallet by words and navigate over the "keyboard". The initial delay only during this process could likely be reduced to around 33% or even 25%. Thanks for workin on it, though.


setValue

Hello and thanks for your library.
i have setup a TGPDiscreteSlider7 on my storyboard and i would like to change its value programmatically. Calling setValue on the control does not seem to do anything. The slider does not move.
Am i missing something in the implementation in order to make it move programmatically?
thanks
EDIT:
calling setValue on your oneTo10Slider in the demo project works as expected.
calling setValue on either of the last 2 sliders in the demo project does not work and i have set them up as a property so i can call them
By the way...calling setValue on anywhere else than viewDidLoad even on the oneTo10Slider does not move it.

i think i have found the issue.
in order to move the slider programmatically using setValue i had to change the layoutTrack method and add [self setNeedsDisplay]; at the end of it. now the slider moves at will
can anyone confirm this?

Can you create a pull request?

:+1:

Sorry for the long delay. This issue eluded my attention since the issue
was closed.
Is there anything else you have noticed that has not been reported?
Cheers,
Xavier
On Sat, Dec 5, 2015 at 11:49 PM, Konstantinos K<EMAIL_ADDRESS>wrote:

[image: :+1:]
—
Reply to this email directly or view it on GitHub
https://github.com/SwiftArchitect/TGPControls/issues/14#issuecomment-162285306
.

no worries. if i find anything else i will of course notify you! thanks for your time


Bridge calls fail to connect to real hardware

Bonjour server seems to have stopped working
$ ruby illuminator/gem/resources/scripts/UIAutomationBridge.rb --callUID=Bridge_call_1 --hardwareID=1d412a68970f5eb5409b5045791365c54a2f87c7 --selector=resetToLogin:
{
  "checkpoints": {
    "ruby": true,
    "argument": null,
    "hardwareID": false,
    "connection": null,
    "request": null,
    "response": null,
    "callUIDMatch": null,
    "actual_request": {
      "selector": "resetToLogin:",
      "callUID": "Bridge_call_1"
    }
  },
  "success": false,
  "message": "Failed to get host/port for hardware ID"
}

Is this issue going to persist for a while?  I would like to start using the bridge on the device if possible.

Debugging this is currently my first priority on illuminator, will post findings soon. Thanks for your patience..

@kviksilver I will plan to close this when #99 is merged, but will the new bridge support hardware?


Finetuned Decoder Parameters

Hi there, I really appreciate your great work!
I have some questions regrading the replication. When I loaded the model weights and tried to visualize the result shown in the readme, I could not find the parameters for the decoder.
Also, these four variables cannot be found:
head.weight not found in Init Model
head.bias not found in Init Model
fc_norm.weight not found in Init Model
fc_norm.bias not found in Init Model
Could you please help me solve this issue? Could you also provide your code for visualizing Figure 2 in your paper? Thank you!

Please refer to this issue: https://github.com/lambert-x/medical_mae/issues/6


BCDB: could not find obj with id

on fresh containers and inconsistenly happening after pulling (packages locations updates .. etc)

index should get rebuilt automatically in that case
maybe relevant: https://github.com/threefoldtech/jumpscaleX_core/issues/168

Maybe related error, when starting threebot server
Sun 10 12:04:39 c28b62fa9a5cf998c.py -  31 - b_ede010359363515c28b62fa9a5cf998c : init index:jumpscale.myjobs.job
Sun 10 12:04:39 129577613d9be1f27.py -  31 - n_2c467e8e2116e34129577613d9be1f27 : init index:jumpscale.myjobs.action
Sun 10 12:04:40 ta/bcdb/BCDBModel.py - 503 - get                                : EXCEPTION:
    no object with id 1 found in model:jumpscale.myjobs.action
    , this means the index gave back an id which is not part of this model.
--TRACEBACK------------------
/sandbox/var/cmds/threebot_default.py in <module>
    5    server.start(background=False)
/sandbox/lib/jumpscale/Jumpscale/servers/threebot/ThreebotServer.py in start
    177    package.start()
/sandbox/lib/jumpscale/Jumpscale/tools/threebot_package/ThreeBotPackage.py in start
    124    self._init_before_action()
/sandbox/lib/jumpscale/Jumpscale/tools/threebot_package/ThreeBotPackage.py in _init_before_action
    78    j.servers.myjobs.schedule(load_wiki, wiki_name=name, wiki_path=path)
/sandbox/lib/jumpscale/Jumpscale/servers/myjobs/MyJobsFactory.py in schedule
    425    name=name, method=method, kwargs=kwargs, dependencies=dependencies, args_replace=args_replace
/sandbox/lib/jumpscale/Jumpscale/core/BASECLASSES/JSConfigsBCDB.py in new
    44    jsconfig = self._new(name=name, jsxobject=jsxobject, autosave=autosave, **kwargs)
/sandbox/lib/jumpscale/Jumpscale/core/BASECLASSES/JSConfigsBCDB.py in _new
    93    jsconfig = jsconfig_klass(parent=self, jsxobject=jsxobject, **kwargs_to_class)
/sandbox/lib/jumpscale/Jumpscale/core/BASECLASSES/JSBase.py in __init__
    63    self._init(**kwargs)
/sandbox/lib/jumpscale/Jumpscale/servers/myjobs/MyJobs.py in _init
    27    self.process_code(method, args_replace)
/sandbox/lib/jumpscale/Jumpscale/servers/myjobs/MyJobs.py in process_code
    46    new, action = j.servers.myjobs.action_get(key)
/sandbox/lib/jumpscale/Jumpscale/servers/myjobs/MyJobsFactory.py in action_get
    60    res = self.model_action.find(key=key)
/sandbox/lib/jumpscale/Jumpscale/data/bcdb/BCDBModel.py in find
    628    res.append(self.get(id))
/sandbox/lib/jumpscale/Jumpscale/data/bcdb/BCDBDecorator.py in wrapper_queue_method
    60    res = func(*args, **kwargs)
/sandbox/lib/jumpscale/Jumpscale/data/bcdb/BCDBModel.py in get
    503    obj_id, self
-----------------------------

Sun 10 12:04:41 BCDB.py              - 338 - bcdb                               : DATAPROCESSOR & SQLITE STOPPED OK
Sun 10 12:04:42 BCDB.py              - 338 - bcdb                               : DATAPROCESSOR & SQLITE STOPPED OK

should be fixed in 4409a78552b0915ff671c5217c08e280ffabd0d4 (we never return an id from bcdb config without explicitly stating it should exist on the model) there should be some rethinking of the current design.

as per this ticket https://github.com/threefoldtech/jumpscaleX_core/issues/168
i did not face this issue again


Feat: Upgrading BDK to 0.7.0

Feat #13 Updated devkit to bdk-android 0.7.0
Fixed issue where blockchain was being created on every screen recomposition.

This looks good to me. The only problem is that the Wallet.sync() method can be called without access to the network, which means the lateinit blockchain variable has not yet been instantiated, making the app crash.
I think a robust solution would probably include error handling and beefing up the sync() method, but I'd like to keep the app lean on those types of things which tend to obfuscate the simple version of using the API through the happy path so to speak.
What do you think of showing greyed out, unclickable buttons for sync, transaction history, and send if the network is not available?

If that sounds like an OK solution to ya I'll merge. Good stuff, thanks for the upgrade!


Fix CentOS build dependency issues

Two quick commits born out of issues I had trying to setup a build environment under CentOS 7.

Hi @kmosher, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
We will now validate the agreement and then real humans will evaluate your PR.
TTYL, MSBOT;

Perfect, thanks.


Update tutorial-configure-ldaps.md

On the pre-requisites, added "* You need global administrator privileges in your Azure AD tenant to enable secure LDAP."
It is mandatory to enable secure LDAP, and has already generated feedback from some Customers asking to add this information as it is not present on the public document.

@husousa : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#label:"aq-pr-triaged"

Hello team!
Any updates on this update?

#sign-off


fix ImGuiKey enum usage

ImGui changed how keyboard is handled. there's no ImGuiKey_ enum anymore

Ran into this on the SFML Discord when helping someone, did make an issue for it just in case no one else had encountered it but I guess you beat me to it! #220

Thanks! Merged.


I can't open terminal on RPi 4B.

Hello! I have a problem with FydeOS. I have a Raspberry Pi 4B with 4GB of RAM and Chromium 80.0.3987.163. I want to open the terminal because I have a problem with the SD card, that only detects 260 MB of free space when I'm using an SD card of 64GB that only haves the system data. I have searched how to solve the problem on FydeOS's GitHub page and I found that I have to open the terminal, and replace one .txt of the system, but when I try to access to the terminal pressing the keys "Ctrl+Alt+F2", my RPi stops showing image. I don't know why this is happening, but if If it helps to try to solve the problem, I also had another problem with my RPi 4. When I bought it, I installed FydeOS as my default OS (that is, I installed FydeOS as "the first OS of my RPi", which I only installed FydeOS, I didn't install any other OS on that RPi before). I connected the RPi to the power and my monitor, and even being the official accessories, my RPi gave no image signal. Searching, again, on the official GitHub page of FydeOS, I found that it was a compatibility problem between the resolution of my monitor and my RPi. I modified the file "config.txt" and now it works correctly. Of accessories for my RPi, I have the official keyboard and mouse, an HDMI switch, since I also have my Nintendo Switch connected to the monitor, and a small fan for my RPi connected to the 3.3V and GND stations of my RPi. Occasionally, I also plug my Razer Kraken Pro V2 headphones into my RPi's 3.5mm Mini Jack port. I think that the latter does not have much to do with the problem, but I put it in case it was related to this and I did not know it, it is that I am a little novice. And finally, I don't know if it will be noticed, but sorry for using Google Translate. I am Spanish and I only know a little English. Thanks for the help!

First of all, there is no OS like FydeOS for rpi4. It's just ChromiumOS for RPI which based on the official raspberry kernel and ChromiumOS sources. "Ctrl+Alt+F2" is never working because of the graphic driver issue, you can use "Ctrl + Alt +T" instead which has to run after login. The hotkey will open a browser tab for a command console, then type 'shell'. For most hardware related issues, you can find the answer on the official site of the raspberry pi.


Base variable calculation

for each variable, we would also need to calculate the base variable (e, m)  so that we can calculate p, z
However note that, for some variables, we can get p and z directly from census by querying XXXXX_01PE or XXXXX_01PM

Potential functions
def calculate_base(self, pff_variable, geotype) -> pd.DataFrame:
    """
    Gets base from metadata then calls calculate_variable(self, base_variable, geotype)
   """

implemented


refactor(@embark/embark-swarm): Re-add swarm storage plugin

Swarm added back in to the refactored code.
Prevent Embark from hanging when Swarm/IPFS crashes.
Use swarm config as per below
To take this PR for a spin, update dapps/templates/demo/config/storage.js with the following:
module.exports = {
  // default applies to all environments
  default: {
    enabled: true,
    ipfs_bin: "ipfs",
    available_providers: ["ipfs", "swarm"],
    upload: {
      provider: "swarm",
      host: "localhost",
      port: 8500
    },
    dappConnection: [
      {
        provider: "swarm",
        host: "localhost",
        port: 8500,
        getUrl: "http://localhost:8500/bzz:/"
      }
    ]
    // Configuration to start Swarm in the same terminal as `embark run`
    , account: {
      address: "SWAM_ACCOUNT_ADDRESS", // Address of account accessing Swarm
      password: "config/development/password" // File containing the password of the account
    },
    /*swarmPath: "PATH/TO/SWARM/EXECUTABLE" // Path to swarm executable (default: swarm)*/
  }
};

NOTE: account.address needs to be a node account. Please make sure embark run2 has been run first, then create a new node account and update the config, then re-run embark.

cd dapps/templates/demo
embark reset
embark run2 - it will fail with

error starting engine
Swarm process exited with error code 1.

geth account new --datadir=.embark/development/datadir --password=config/development/password
NOTE: If the above step is performed, Embark will hang due a bug with node account creation and management. Instead, get the previously created developer account using
geth account list --datadir=.embark/development/datadir.
Copy output from #3 to account.address in storage config, and update the password to be blank, since we are now using the developer account.
Re-run embark run2

NOTE: this branch is based on refactor/add-contract-tracking. Once that is merged in, I'll rebase this on refactor_5_0_0.

Rebased


fix: db insert error for no space left

[x] PR title and description conform to Pull Request guidelines.

Description of changes:

fix db insert error for no space left

How did you test these changes?
(Please add a line here how the changes were tested)
Documentation update required?

[x] No
[ ] Yes (Please include a PR link for the documentation update)

General Checklist

[ ] Added Unit Tests

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report
Attention: Patch coverage is 29.41176% with 12 lines in your changes missing coverage. Please review.

Project coverage is 87.35%. Comparing base (0549134) to head (e0ab694).

Files
Patch %
Lines

...aws/solution/clickstream/client/EventRecorder.java
0.00%
10 Missing :warning:

...ution/clickstream/client/db/ClickstreamDBUtil.java
71.42%
2 Missing :warning:

Additional details and impacted files
@@             Coverage Diff              @@
##               main      #85      +/-   ##
============================================
- Coverage     87.93%   87.35%   -0.59%
- Complexity      488      489       +1
============================================
  Files            40       40
  Lines          1716     1732      +16
  Branches        171      171
============================================
+ Hits           1509     1513       +4
- Misses          140      152      +12
  Partials         67       67

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Add type checks for initialiazion of models

Fixes # (provide issue number of applicable)
#1143: Adds in type checks to try and correct the errors being caused in the issue

Looks good. Did you run black on the code? Perhaps we have a version mismatch.

I am completely overhauling this part of the code, so I will close the PR until my features are finished.

I decided to add in a new feature decided to simplify the type checking process. It lives in praw/models/utils. Suggestions to move it anywhere?

If you have any idea on how to make the function smaller, as it has a lot of if statements to cover every possibility of misuse by end-users. Although, end users are most likely not going to use this function, so I can remove the majority of the checks, such as for using None as an expected type.

@PokestarFan I appreciate all the effort you're putting into these changes. However, I worry it might be a bit overkill to type check every parameter. If someone wants that level of validation a dynamically typed language probably isn't for them. A better use of effort would be to use python's type hinting which is available in python 3.5+, which conveniently is what we support. Thoughts?

@bboe should I add in type hinting through stub files, or directly into the functions/classes?

For now I am going to only add in type checks to the public reddit methods such as submission.

@bboe @jackodsteel I have finished this PR. Every method that can be called from the reddit instance without accessing any attributes (such as Redditor, Comment, Submission, etc.) have been type checked. I did not implement type-checking onto any of the inbox methods, as those are methods of a class, not a callable class on the Reddit instance.

@PokestarFan I think I may not have been clear in my previous message. I don't see a ton of value in introducing explicit runtime type checks. Most issues should surface pretty quickly at runtime anyway if the wrong type is provided without said checks. While I understand that the exceptions as-is may be a little cryptic for people, the added complexity (2000+ lines for this PR, which is only a subset of methods)  doesn't seem worth it. I think parameter type-hinting could help considerably for said cases and it can be done with relatively little effort.
Aside from that, the places where there exist some run-time checks are when parameters are mutually exclusive, or parameters must be grouped together. One could argue that in such cases, we might be better off making separate methods. While that's certainly a possibility, I haven't really heard any complaints about how it's currently done.

Understood. I will look into type-hinting, and work on mutually exclusive methods.

To anyone reading this later, I moved the code into PokestarFan/validate-types and force-pushed master to resemble master of praw


use getCol to save unnecessary data manipulation

WPDB has a built in method to handle what you're trying to do here.

@Flynsarmy beautiful, thanks!


Update to Rx 4.1.3

Minor update but has uwp fixes. I also recommend updating to the latest Extras either 1.x or 2.x.

We are waiting on https://github.com/dotnet/reactive/issues/803 to resolve upstream before we upgrade the minimum version.
Extras we can upgrade.

Extras portion was addressed by 3ab493eb4c8db17e463911671699af093f52ba4e

So based on what I'm seeing in that issue it'll be resolved with Visual Studio 2019, so will upgrade the minimum Rx then.

I just tried @PureWeen sample linked in that thread https://github.com/dotnet/reactive/issues/803#issuecomment-414731885
on my VSfM 2019 (8.0 build 1805) and the problem still happens.
Do you know by any chance what build of VSfM has this fixed?

We upgraded to MSBuild.Sdk.Extras to 2.0.24 recently so that part is covered. Tracking down the offer issues.

Just downloaded the same sample https://github.com/dotnet/reactive/issues/803#issuecomment-414731885 and now it's working with VsfM 8.0.5 (build 9).
Also updated all the nugets and run again: still working, so looks good to me.

Re-opening since we haven't updated to 4.1.3 yet :)

Closing this one, will open a task for upgrading to MSBuild.Sdk.Extras


CommonCrawl: Start and End Date Not Working

Mandatory

[x] I read the documentation (readme and wiki).

[x] I searched other issues (including closed issues) and could not find any to be related. If you find related issues post them below or directly add your issue to the most related one.

Related issues:

Did not see any related issue.

Describe the bug
Even though I assign valid datetime to the below variables, the warc files are downloaded always starting from a very early time period.
To Reproduce
clone repository

In newsplease/examples/commoncrawl.py, change following lines:
 my_filter_valid_hosts =["elrancaguino.cl"]
 my_filter_start_date = datetime.datetime(2020, 2, 1)
 my_filter_end_date = datetime.datetime(2020, 2, 5)

install awscli wit pip

run the changed script

see logs:
processed = 1, remaining = 9323, total = 9326
INFO:newsplease.crawler.commoncrawl_extractor:downloading https://commoncrawl.s3.amazonaws.com/crawl-data/CC-NEWS/2016/08/CC-NEWS-20160827145159-00003.warc.gz
Expected behavior
Instead of start downloading from 2016, it should download only in 2020 February, which is the specified date.
Log
processed = 1, remaining = 9323, total = 9326
INFO:newsplease.crawler.commoncrawl_extractor:downloading https://commoncrawl.s3.amazonaws.com/crawl-data/CC-NEWS/2016/08/CC-NEWS-20160827145159-00003.warc.gz
Versions (please complete the following information):

OS: Debian GNU/Linux 10 (buster)
Python Version 3.7
news-please Version: I do not see any versions. So commit: 39aff553beefe30dac3d359201294291a9f6f57e

Unfortunately, this is expected behaviour and cannot be avoided. Reason is that the datestamp in the filenames of commoncrawl's WARC files, e.g., 2016-08-27 in https://commoncrawl.s3.amazonaws.com/crawl-data/CC-NEWS/2016/08/CC-NEWS-20160827145159-00003.warc.gz only indicates when the WARC file was created but do not allow to conclude anything about the content, i.e., the publisher date can be (will be) different. In fact, when my team processed all WARC files some time ago, we had some cases where the WARC filename was created in 2018, but contained also articles from 2002.
Thus, news-please has to process all WARC files, extract the article information and only then can decide - based on your date filter settings - if an article is kept or discarded.

Feel very free to reopen the issue in case you have more questions or - even better - you see a way to improve the efficiency in this case :-)

Thank you for this very helpful information. As you already processed it, I would like to ask one more question.
For example, if a WARC file composed in 2016-08, I suppose it cannot contain any articles from future, 2017 for example. I dont know the current implementation but thinking from my single example (this can be a mistake :) ), when asked for an article from 2020, downloading from 2016 sounds unnecessary.  At least we can restrict the download start date. Here is a possible logic:
|:u ---> WARC file upload date, u is id of file.
x---> Requested start date of articles
---- |:1 ---- |:2 ---- |:3 ----x-- |:4 ----- |:5
In this case start downloading from |:4 .
A possible case which could discard this logic: If commoncrawl updates WARC files after creating it, and keeping the initial timestamp on the file name fixed, then the WARC file contains articles from future (compared to its timestamp) and the logic does not work.
Sorry for this long writing,
Thanks

Sounds like a great idea! I guess this could easily be integrated in https://github.com/fhamborg/news-please/blob/2b55c2979806fce49c0c4d2aed8dd5cf73ae76f8/newsplease/crawler/commoncrawl_crawler.py#L249 (or somewhere close to that; specifically, before downloading the file). Unfortunately, I currently don't have time to implement and test this, but if you want to give it a try, I'd again gladly review a PR! :-)

Great :+1:
Ok I am on it :)

Any luck? :)

Hi, I am having the same issue, and I created a PR for this.

fixed with moyid's PR

@ozgurakyazi @fhamborg I was checking this issue and after the PR merge, I think it should work as intended i.e. dowload the dates requested. But in my case, it only downloads 2016 file and get 503 error for others. I understand 503 error can be network error but unsure why it always downloads 2016 file?
Code:
# start date (if None, any date is OK as start date), as datetime
my_filter_start_date = datetime.datetime(2022, 1, 1)
# end date (if None, any date is OK as end date), as datetime
my_filter_end_date = datetime.datetime(2022, 12, 31)
# Only .warc files published within [my_warc_files_start_date, my_warc_files_end_date) will be downloaded.
# Note that the date a warc file has been published does not imply it contains only news
# articles from that date. Instead, you must assume that the warc file can contain articlesc
# from ANY time before the warc file was published, e.g., a warc file published in August 2020
# may contain news articles from December 2016.
my_warc_files_start_date = datetime.datetime(2021, 1, 1)
my_warc_files_end_date = datetime.datetime(2023, 6, 31)

Ouput:

my_local_download_dir_warc=./cc_download_warc/
my_local_download_dir_article=./cc_download_articles/
my_delete_warc_after_extraction=True
my_number_of_extraction_processes=1
INFO:newsplease.crawler.commoncrawl_crawler:Failed to read commoncrawl bucket, using monthly WARC file listings
INFO:newsplease.crawler.commoncrawl_crawler:Failed to fetch WARC file list https://data.commoncrawl.org/crawl-data/CC-NEWS/2016/08/warc.paths.gz: <Response [503]>
INFO:newsplease.crawler.commoncrawl_crawler:Failed to fetch WARC file list https://data.commoncrawl.org/crawl-data/CC-NEWS/2016/09/warc.paths.gz: <Response [503]>
INFO:newsplease.crawler.commoncrawl_crawler:Failed to fetch WARC file list https://data.commoncrawl.org/crawl-data/CC-NEWS/2016/11/warc.paths.gz: <Response [503]>
INFO:newsplease.crawler.commoncrawl_crawler:Failed to fetch WARC file list https://data.commoncrawl.org/crawl-data/CC-NEWS/2017/10/warc.paths.gz: <Response [503]>
INFO:newsplease.crawler.commoncrawl_crawler:Failed to fetch WARC file list https://data.commoncrawl.org/crawl-data/CC-NEWS/2017/11/warc.paths.gz: <Response [503]>
INFO:newsplease.crawler.commoncrawl_crawler:Failed to fetch WARC file list https://data.commoncrawl.org/crawl-data/CC-NEWS/2017/12/warc.paths.gz: <Response [503]>
INFO:newsplease.crawler.commoncrawl_crawler:Failed to fetch WARC file list https://data.commoncrawl.org/crawl-data/CC-NEWS/2018/01/warc.paths.gz: <Response [503]>
INFO:newsplease.crawler.commoncrawl_crawler:Failed to fetch WARC file list https://data.commoncrawl.org/crawl-data/CC-NEWS/2018/02/warc.paths.gz: <Response [503]>
INFO:newsplease.crawler.commoncrawl_crawler:Failed to fetch WARC file list https://data.commoncrawl.org/crawl-data/CC-NEWS/2018/12/warc.paths.gz: <Response [503]>
INFO:newsplease.crawler.commoncrawl_crawler:Failed to fetch WARC file list https://data.commoncrawl.org/crawl-data/CC-NEWS/2019/01/warc.paths.gz: <Response [503]>
INFO:newsplease.crawler.commoncrawl_crawler:Failed to fetch WARC file list https://data.commoncrawl.org/crawl-data/CC-NEWS/2019/02/warc.paths.gz: <Response [503]>
INFO:newsplease.crawler.commoncrawl_crawler:Failed to fetch WARC file list https://data.commoncrawl.org/crawl-data/CC-NEWS/2019/03/warc.paths.gz: <Response [503]>
INFO:newsplease.crawler.commoncrawl_crawler:Failed to fetch WARC file list https://data.commoncrawl.org/crawl-data/CC-NEWS/2019/04/warc.paths.gz: <Response [503]>
INFO:newsplease.crawler.commoncrawl_crawler:Failed to fetch WARC file list https://data.commoncrawl.org/crawl-data/CC-NEWS/2019/05/warc.paths.gz: <Response [503]>
INFO:newsplease.crawler.commoncrawl_crawler:Failed to fetch WARC file list https://data.commoncrawl.org/crawl-data/CC-NEWS/2020/07/warc.paths.gz: <Response [503]>
INFO:newsplease.crawler.commoncrawl_crawler:Failed to fetch WARC file list https://data.commoncrawl.org/crawl-data/CC-NEWS/2021/01/warc.paths.gz: <Response [503]>
INFO:newsplease.crawler.commoncrawl_crawler:Failed to fetch WARC file list https://data.commoncrawl.org/crawl-data/CC-NEWS/2021/02/warc.paths.gz: <Response [503]>
INFO:newsplease.crawler.commoncrawl_crawler:Failed to fetch WARC file list https://data.commoncrawl.org/crawl-data/CC-NEWS/2021/03/warc.paths.gz: <Response [503]>
INFO:newsplease.crawler.commoncrawl_crawler:Failed to fetch WARC file list https://data.commoncrawl.org/crawl-data/CC-NEWS/2021/04/warc.paths.gz: <Response [503]>
INFO:newsplease.crawler.commoncrawl_crawler:Failed to fetch WARC file list https://data.commoncrawl.org/crawl-data/CC-NEWS/2021/06/warc.paths.gz: <Response [503]>
INFO:newsplease.crawler.commoncrawl_crawler:Failed to fetch WARC file list https://data.commoncrawl.org/crawl-data/CC-NEWS/2022/02/warc.paths.gz: <Response [503]>
INFO:newsplease.crawler.commoncrawl_crawler:Failed to fetch WARC file list https://data.commoncrawl.org/crawl-data/CC-NEWS/2022/03/warc.paths.gz: <Response [503]>
INFO:newsplease.crawler.commoncrawl_crawler:Failed to fetch WARC file list https://data.commoncrawl.org/crawl-data/CC-NEWS/2022/11/warc.paths.gz: <Response [503]>
INFO:newsplease.crawler.commoncrawl_crawler:Failed to fetch WARC file list https://data.commoncrawl.org/crawl-data/CC-NEWS/2022/12/warc.paths.gz: <Response [503]>
INFO:newsplease.crawler.commoncrawl_crawler:Failed to fetch WARC file list https://data.commoncrawl.org/crawl-data/CC-NEWS/2023/07/warc.paths.gz: <Response [503]>
INFO:newsplease.crawler.commoncrawl_crawler:Failed to fetch WARC file list https://data.commoncrawl.org/crawl-data/CC-NEWS/2023/08/warc.paths.gz: <Response [503]>
INFO:newsplease.crawler.commoncrawl_crawler:Found 24308 WARC files
INFO:newsplease.crawler.commoncrawl_crawler:found 24308 files at commoncrawl.org
INFO:newsplease.crawler.commoncrawl_crawler:creating extraction process pool with 1 processes
INFO:newsplease.crawler.commoncrawl_extractor:downloading https://data.commoncrawl.org/crawl-data/CC-NEWS/2016/10/CC-NEWS-20161001122244-00007.warc.gz (local: ./cc_download_warc/crawl-data%2FCC-NEWS%2F2016%2F10%2FCC-NEWS-20161001122244-00007.warc.gz)


Get compatible with optimizer migration in TF 2.11

Optimizer code change to get compatible with the optimizer migration in TF 2.11.
As a summary the following changes are made:

Adjust how KerasLegacyOptimizer is determined. Now we check if optimizers.experimental and optimizers point to the same module.
In unit tests we should use the legacy optimizer if it is available.
some auto formatting.

@bhack Hi, could you help check this PR? This ensures addon tests will not break with TF 2.11 release, which will happen around late October to early November. Thanks!

LGTM

You need also to add another experimental API exception for:
#14 3.044 E               NameError: The usage of a TensorFlow experimental API was found in file /addons/tensorflow_addons/optimizers/constants.py at line 17:
#14 3.044 E
#14 3.044 E                      hasattr(tf.keras.optimizers, "experimental")
#14 3.044 E
#14 3.044 E               Experimental APIs are ok in tests but not in user-facing code. This is because Experimental APIs might have bugs and are not widely used yet.
#14 3.044 E               Addons should show how to write TensorFlow code in a stable and forward-compatible way.

@bhack Could you take another look? thanks!

#14 3.906 E           typedapi.functions.NotTypedError: The function 'keras.optimizers.optimizer_v2.optimizer_v2.OptimizerV2.__init__' has not complete type annotations in its signature (it's missing the type hint for 'name'). We would like this functions to be typed.If you are not familiar with adding type hints in functions, you can look at functions already typed inthe codebase.
#14 3.906 E           If you don't want to type your function, you can add it to the TODO list of functions to type (also known as

@bhack Thanks! That's an existing error. Basically Keras does not do type annotation.

P.s. check you previous PR https://github.com/tensorflow/addons/commit/339159fc361cc8248a99f6703b4f33aa5c9943ac#diff-73b3a9dcf7f0d703962d3258b17d37bf0e4515906821a17e86149afaf2c28cf5R45

It's not caused by that PR, but kinda revealed. Could you point me to the TODO list to add the optimizer class? thanks!

It's not caused by that PR, but kinda revealed

I didn't mean this. Check the line in the link not the whole PR.

Just a single note to evaluate if you could externalize that logic in an external shared function.

@bhack Thanks! I feel doing it inline is okay? If you have strong opinion please let me know, I will check what I can do, thanks!

Python Op Compatibility Matrix in README still shows versions up to 2.10


Added basic UI Automation TextPattern support.

This provides basic UI Automation Text Pattern support for AvalonEdit.  I say basic because it doesn't properly deal with hidden regions, autocompletion etc.  My interest was in being able to read source code in ILSpy and these changes allow that.

I'm a bit clueless about UI automation. How would I test these changes?
Is it intentional that we need automation peers for both TextArea and TextEditor?

Hi, Daniel,
Thanks so much for getting back to me on this.
By way of background, I’m the original author of the JAWS screen reader for the blind.
I’m blind myself and actually made these changes so I could move away  from Reflector.

But with them, I can actually use JAWS to read disassembled code in ILSpy.
Now to your questions:
There’s a one to one peering relationship between UIAutomation and the controls that they represent.
Because WPF focus is actually on the internal TextArea, that’s the one that needs to implement the ITextProvider pattern.
ITextProvider is the thing that allows Screen Readers to traverse the text area in bite-sized portions: line/word/character.
Two tools from the Windows SDK will help here.
AccEvent will show you the UIA events that are fired as one navigates around the UI with the keyboard.  Make sure that the tool is in UI Automation mode, which it is by default.
Focus events are the ones of greatest interest.
The Inspect tool will let you navigate the UIA hierarchy of the application and exercise the various methods of the ITextProvider pattern.
I was about to tell you that you could use Windows Narrator to verify that one can traverse an editable region with the keyboard and hear the text being read aloud, but decided maybe I better test with it myself first.
Turns out that it requires  firing of a UIAutomation TextSelectionChanged event that I hadn’t added since JAWS doesn’t require it.
I will make that change in the next couple of weeks and submit it.
With that, Narrator should be a reasonable thing to use to verify.
JAWS does have a 40 minute mode which all downloaded versions will run in should you decide to use it to verify instead, but that seems a rather onerous thing to ask of you.
--Glen
From: Daniel Grunwald<EMAIL_ADDRESS>Sent: Saturday, December 3, 2016 12:04 PM
To: icsharpcode/AvalonEdit<EMAIL_ADDRESS><EMAIL_ADDRESS>>
Cc: glenrgordon<EMAIL_ADDRESS><EMAIL_ADDRESS>>; Author<EMAIL_ADDRESS><EMAIL_ADDRESS>>
Subject: Re: [icsharpcode/AvalonEdit] Added basic UI Automation TextPattern support. (#97)
I'm a bit clueless about UI automation. How would I test these changes?
Is it intentional that we need automation peers for both TextArea and TextEditor?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/icsharpcode/AvalonEdit/pull/97#issuecomment-264655050 , or mute the thread https://github.com/notifications/unsubscribe-auth/ARmPEXaK_WMTa6S77aZ_pWvI1rsRHNPWks5rEa8CgaJpZM4J5wV5 .

Thanks for the explanation.
I fixed some issues with your code -- I was getting out-of-bounds exception when moving the caret near the start/end of the document while Narrator was running.
I also added the TextSelectionChanged event. Narrator now spells out individual letters when moving the caret, but I couldn't get it to speak whole words/lines.

Sorry for the out-of-bounds events.  Didn’t get those with JAWS.
Thanks for your continued help.
--Glen
From: Daniel Grunwald<EMAIL_ADDRESS>Sent: Sunday, December 4, 2016 12:00 PM
To: icsharpcode/AvalonEdit<EMAIL_ADDRESS>Cc: glenrgordon<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [icsharpcode/AvalonEdit] Added basic UI Automation TextPattern support. (#97)
Thanks for the explanation.
I fixed some issues with your code -- I was getting out-of-bounds exception when moving the caret near the start/end of the document while Narrator was running.
I also added the TextSelectionChanged event. Narrator now spells out individual letters when moving the caret, but I couldn't get it to speak whole words/lines.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/icsharpcode/AvalonEdit/pull/97#issuecomment-264719339 , or mute the thread https://github.com/notifications/unsubscribe-auth/ARmPEYxby5GQZWxNXTpWKroOiZlW2sGLks5rEv-tgaJpZM4J5wV5 .

Closing, as this was merged in a7babb3fd32c59fea59c95879b43e6c5adaf9651.


made _issmall() a static member of SymbolicOperator addressing #702

PR implementing the change requested in #702

Thanks for sorting that out. I think as soon as you can sort out the CLA issue I can merge.

Thanks for sorting that out. I think as soon as you can sort out the CLA issue I can merge.

I have already asked our legal department to give me permission to sign the CLA.

I have already asked our legal department to give me permission to sign the CLA.

Great, fingers crossed it goes smoothly.

Great, fingers crossed it goes smoothly.

@googlebot I signed it!

@googlebot I signed it!

@googlebot I signed it!

Also this one is now good to go!

Glad this is finally sorted


Unable to Build from Quickstart Page (March 1st, 2024)

Past Issues Searched

[X] I have searched open and closed issues to make sure that the bug has not yet been reported

Issue is a Bug Report

[X] This is a bug report and not a feature request, nor asking for support

Describe the bug
Complete Newbie to Hugo so this may be a mistake on my part.
Followed the instructions from the Quickstart Guide.
High Level Overview:

Installed Hugo & Go.
a. go version = go1.22.0 linux/amd64
b. hugo version = hugo v0.92.2+extended linux/amd64 BuildDate=2023-01-31T11:11:57Z VendorInfo=ubuntu:0.92.2-1ubuntu0.1
Use Hugo to make a new site & cd into said directory.
Initialized project (site) as a Module as a Git Rep.
a. module git.repo.........................................................
go 1.22.0
require (
github.com/colinwilson/lotusdocs v0.1.0 // indirect
github.com/gohugoio/hugo-mod-bootstrap-scss/v5 v5.20300.20200 // indirect
)
Add Lotus Docs as a Module to Project (site).
Create new Content (Example Page). Note: Please let me know if I should not be sharing the full text of the below; AKA, Cipher text.
github.com/colinwilson/lotusdocs v0.1.0 h1:oTC8pAYQp9XDNaUwE4SEY+id3ByNELxIIFrktYEGxYA=
github.com/colinwilson/lotusdocs v0.1.0/go.mod h1:9zu2REJDi+zdPRcR5/bRYSUR7gkNF4NQLvV38SEoCP8=
github.com/gohugoio/hugo-mod-bootstrap-scss/v5 v5.20300.20200             h1:SmpwwN3DNzJWbV+IT8gaFu07ENUFpCvKou5BHYUKuVs=
github.com/gohugoio/hugo-mod-bootstrap-scss/v5 v5.20300.20200/go.mod h1:kx8MBj9T7SFR8ZClWvKZPmmUxBaltkoXvnWlZZcSnYA=
github.com/gohugoio/hugo-mod-jslibs-dist/popperjs/v2 v2.21100.20000/go.mod h1:mFberT6ZtcchrsDtfvJM7aAH2bDKLdOnruUHl0hlapI=
github.com/twbs/bootstrap v5.3.2+incompatible/go.mod h1:fZTSrkpSf0/HkL0IIJzvVspTt1r9zuf7XlZau8kpcY0=
Pushed code to git repo.
Attempt to run this command: hugo server -D

user@machine:~/Documents/sites/site$ hugo server -D
Start building sites …
hugo v0.92.2+extended linux/amd64 BuildDate=2023-01-31T11:11:57Z VendorInfo=ubuntu:0.92.2-1ubuntu0.1
WARNING: calling IsSet with unsupported type "invalid" (<nil>) will always return false.
ERROR 2024/03/01 22:34:21 render of "page" failed: execute of template failed: template: docs/single.html:25:44: executing "docs/single.html" at <partial (printf "%s/%s" ($.Scratch.Get "pathName") "breadcrumbs.html") .>: error calling partial: "/tmp/hugo_cache/modules/filecache/modules/pkg/mod/github.com/colinwilson/lotusdocs@v0.1.0/layouts/partials/docs/breadcrumbs.html:5:55": execute of template failed: template: partials/docs/breadcrumbs.html:5:55: executing "partials/docs/breadcrumbs.html" at <.Ancestors.Reverse>: can't evaluate field Ancestors in type *hugolib.pageState
Error: Error building site: failed to render pages: render of "section" failed: execute of template failed: template: docs/list.html:25:44: executing "docs/list.html" at <partial (printf "%s/%s" ($.Scratch.Get "pathName") "breadcrumbs.html") .>: error calling partial: "/tmp/hugo_cache/modules/filecache/modules/pkg/mod/github.com/colinwilson/lotusdocs@v0.1.0/layouts/partials/docs/breadcrumbs.html:5:55": execute of template failed: template: partials/docs/breadcrumbs.html:5:55: executing "partials/docs/breadcrumbs.html" at <.Ancestors.Reverse>: can't evaluate field Ancestors in type *hugolib.pageState
Built in 709 ms

Expected behavior
As referenced in this page, a generated page.
Screenshots
No response
Environment
- OS: PopOS
- Browser: N/A
- Browser Version: N/A

Your hugo version is too old. You use hugo v0.92.2+extended . But in the Readme it says that you need Hugo Extended (minimum version: 0.120.0). If this version is not available in your OS repository you can use the binary release.

Thanks for sharing something that I overlooked, will close issue based on feedback.


fix(ffe-form): rewrite checkbox animation from keyframes to transition in order to prevent animation playing on page load

Fixes #368

Coverage remained the same at 80.53% when pulling 1fb502a214f86f4d59192abb9a328a1742def184 on checkbox-animation-performance-fix into 037de3a24d2d186a4be96c6911c66405eafda0f9 on develop.


Add links to QueryApi video walkthrough

Nice changes! this should help users a ton. A few improvements on updating links

thanks for the review and fixes @roshaans ! 👍


Improve auto layout of sequence flow when deleting an element

// given
see attached screen cast
// when
I remove an element after an L-shaped sequence flow
// then
the sequence flow will be routed on the direct way to the next element and is not L-shaped anymore

Depends on https://github.com/bpmn-io/bpmn-js/issues/718

This is related to https://github.com/camunda/camunda-modeler/issues/672 and needs a fix via https://github.com/bpmn-io/bpmn-js/issues/718.

This will be fixed by https://github.com/bpmn-io/bpmn-js/pull/971

Closed via aafbda44795d7e2c0bb00aa8a4bbe81956b17b1b


Change menu item to "Logout [user's name or username]"

Adds the operator's full name (if present) or their username to the Logout menu item.
The is useful in shared computer environments in production and permissions configuration in development.
Also adds tests that it works and fixes tests that it broke.

Coverage remained the same at 94.444% when pulling 927ee10fb04d0181d011dd14f47fa24b6bf2ed51 on mkoistinen:add_user_name_to_logout_menu into 92edf033ccc0938e41f3752935516572c3623695 on divio:develop.


Unsure what's happening with Name filter values

Describe the bug

What part of Nexus is affected: Fusion
To Reproduce

Go to the search web app in staging
Search for "morphology"
Click on the Name column dropdown
The list of values doesn't make sense (see screenshot)

Expected behavior
The most common values for the Name should be at the top in decreasing order.

Issue opened to address this: https://github.com/BlueBrain/nexus/issues/2899


Latest update seems to break?

Is there a way to revert to a previous version?  I installed the latest build and all icons are show the generic icon now.   My only means of "fixing" is to uninstall the package and restart.

apm install<EMAIL_ADDRESS>will install the previous version

@jacobmishka awesome, thx. Will give that a try in the morning.

@mikeerickson Are you using Nuclide? This is a known issue that's currently being worked on. Will be fixed in the next version.

@Alhadis no, I am not using Nuclide

Can you run apm ls -i and paste its output, please?

I have the same issue. I'm using<EMAIL_ADDRESS>as my theme; when I use another theme instead the icons show up again<EMAIL_ADDRESS>worked fine though.

@ithil Seti has had problems with file-icons in the past... we used a kludge earlier this year to forcefully override it with an extra CSS class. Seti later made that a non-issue by giving users a checkbox to toggle icons away, which you need to do in order for icons to display properly.
I don't know if seti-classic has such a facility: but from the looks of it, I sorely doubt it...

 This issue is about seti.

I just installed atom, nuclide, and file-icons and the icons don't appear. However, if I disable nuclide the icons appear.

@ihackalot Yikes, fixed. Just cut a patch for that now.
@kennetpostigo Yes, the Nuclide thing is a known issue, but there's actually nothing we can do about it on our end. The Nuclide team need to update their package's code to use Atom's services API.

@mikeerickson The author of the Seti theme merged my PR, so I'm closing this.
If anybody is experiencing new errors that aren't reported, please file new issues so we can keep better track. Thanks!


linter/intellisense not working

i don't get the linter functionality nor the intellisense

Thanks for the report! Can you elaborate a bit? In particular,

What operating system are you using?

What versions of Atom and Ionide are you using?

Did it stop working while you were using it, or did you open the editor and it was already not working? Do you remember it ever working?

Best

OS: OSX El Capitan
Atom ver: 1.0.19
it is a new installation of atom + ionide , never worked...

Same manifestation, same circumstances, perhaps different cause.
When opening in 'developer mode' I get the following:
'C:\Users\tcackowski.atom\dev\packages/ionide-fsharp/bin/fsautocomplete.exe'
could not be spawned. Is it installed and on your path?
If so please open an issue on the package spawning the process.
But there is no .atom/dev/ directory, only .atom/packages,
I will try simply putting it there myself.
Adding to my user path didn't help.

Nevermind.
I had disabled autocomplete-plus, a core package, because of a previous conflict.
I re-enabled it.
Also, one just has to wait a while for the autocomplete provider to load (~15 seconds)
Also, after just guessing from having used VS for so long,
Ctrl+Space seems to stimulate the auto completer.
So maybe there should be, on the ionide-sharp settings, a list of auto-complete stimulating characters, like '.,->,(,=' or so?

@isamuelson, Do You get any error notification? Can You open Developer console (View |> Developer |> Toggle Developer Tools) and check if there is any error logging here?
@theodorecackowski, We are aware that documentation is almost not existing and making it better is our next short term goal :)

no errors when I open atom from a directory

Getting the following in dev mode:

'C:\Users\Jorge.atom\dev\packages\ionide-paket\bin\paket.bootstrapper.exe' could not be spawned.
Is it installed and on your path?
If so please open an issue on the package spawning the process.


ncdump not showing byte type fill values correctly?

I have a test file with a variable of every (classic atomic) type. I write half the values (the first timestep) and leave the rest alone, so they get fill values. The ncdump is attached.
Not that the first var has a byte type. The fillvalue is -127, which is correct. However I expect it to be displayed as an underscore like the other fill values.
netcdf test_pioc_more_classic {
dimensions:
	timestep = 2 ;
	x = 4 ;
	y = 4 ;
variables:
	byte foo_1(timestep, x, y) ;
	char foo_2(timestep, x, y) ;
	short foo_3(timestep, x, y) ;
	int foo_4(timestep, x, y) ;
	float foo_5(timestep, x, y) ;
	double foo_6(timestep, x, y) ;
data:

 foo_1 =
  -42, -42, -42, -42,
  -42, -42, -42, -42,
  -42, -42, -42, -42,
  -42, -42, -42, -42,
  -127, -127, -127, -127,
  -127, -127, -127, -127,
  -127, -127, -127, -127,
  -127, -127, -127, -127 ;

 foo_2 =
  "hi",
  "hi",
  "hi",
  "hi",
  "",
  "",
  "",
  "" ;

 foo_3 =
  -300, -300, -300, -300,
  -300, -300, -300, -300,
  -300, -300, -300, -300,
  -300, -300, -300, -300,
  _, _, _, _,
  _, _, _, _,
  _, _, _, _,
  _, _, _, _ ;

 foo_4 =
  -10000, -10000, -10000, -10000,
  -10000, -10000, -10000, -10000,
  -10000, -10000, -10000, -10000,
  -10000, -10000, -10000, -10000,
  _, _, _, _,
  _, _, _, _,
  _, _, _, _,
  _, _, _, _ ;

 foo_5 =
  -42.42, -42.42, -42.42, -42.42,
  -42.42, -42.42, -42.42, -42.42,
  -42.42, -42.42, -42.42, -42.42,
  -42.42, -42.42, -42.42, -42.42,
  _, _, _, _,
  _, _, _, _,
  _, _, _, _,
  _, _, _, _ ;

 foo_6 =
  -420000000000.5, -420000000000.5, -420000000000.5, -420000000000.5,
  -420000000000.5, -420000000000.5, -420000000000.5, -420000000000.5,
  -420000000000.5, -420000000000.5, -420000000000.5, -420000000000.5,
  -420000000000.5, -420000000000.5, -420000000000.5, -420000000000.5,
  _, _, _, _,
  _, _, _, _,
  _, _, _, _,
  _, _, _, _ ;
}

Note that the same problem appears with the netCDF-4 UBYTE:
 foo_7 =
  255, 255, 255, 255,
  255, 255, 255, 255,
  255, 255, 255, 255,
  255, 255, 255, 255,
  43, 43, 43, 43,
  43, 43, 43, 43,
  43, 43, 43, 43,
  43, 43, 43, 43 ;

The 255s should be shown as underscores since they are the fill value, right?

It turns out there is a comment in ncdump#get_fill_info:

vp->has_fillval = 1; /* by default, but turn off for bytes */
I have no idea why there is an exception for bytes. But see if
the code can shed any light on this.

ok, looking a little further, we see this:

case NC_BYTE:
/* don't do default fill-values for bytes, too risky */
vp->has_fillval = 0;
free(fillvalp);
fillvalp = 0;

But I can find no explanation about what is risky about byte fillvalues.

Hmm, interesting. This of course is the work of our own famous Russ Rew. And I think I get where he was coming from.
There is a default fill value for both bytes and unsigned bytes, and they are defined in netcdf.h. And they are the values that I see when I write some values but leave others unwritten.
#define NC_FILL_BYTE	((signed char)-127)
#define NC_FILL_UBYTE   (255)

But suppose I was using a byte variable, and I was using all the values, and I don't want a fill value. In that case, if ncdump used the default fill value, I would awkwardly get underscores instead of -127 or 255. Hilarious confusion would no doubt ensue.
Well that makes a sort of sense, but on the other hand, and exception is also confusing. Anyway, thanks for helping clear up the mystery. I will leave it for you to decide if this is a bug or a feature.

Ward any objection if I close this ticket? Seems like Denis has answered my question and byte has a different way of displaying in ncdump for historical reasons.

Go for it, or reopen and close if you’d like to but I’ll handle it :).


Image size

Hello,
Maybe I missed that, but how can I change the size of the picture?
Thanks,
Lionel

up


Build: Speed up Razor compilation

Description
See: Reddit Post
See: Visual Studio Developer Community
I'm tired of Razor being very slow. The post suggests that this might help.
Disadvantages:

It's experimental.
It's using a preview razor toolset, which means something might get broken, like the generated razor code might be incorrect.
Need to keep track of new versions.

How Has This Been Tested?
Not sure how can I effectively measure this, except that time can show.
Checklist

[x] The PR is submitted to the correct branch (dev).
[x] My code follows the code style of this project.

Another interesting comment from a Razor developer about ongoing work to improve Razor.
It might make sense to benefit from these improvements now rather than wait.

What do we need to do to make sure it compiles everything correctly? Should we browse through the entire docs or do you think this is unnecessary

Sounds very interesting. I think this package reference could be private. At least it sounds like a tool that is only used during compilation. In this blog post, they also referenced it as private reference.

Sounds very interesting. I think this package reference could be private. At least it sounds like a tool that is only used during compilation. In this blog post, they also referenced it as private reference.

That's a good point.

What do we need to do to make sure it compiles everything correctly? Should we browse through the entire docs or do you think this is unnecessary

I guess we could go through the docs as well

Do you know if this is a feature that they plan to ship with .NET 9?

Do you know if this is a feature that they plan to ship with .NET 9?

That's a good question. I would assume yes if it's called 9.0.0-preview. We can ask in the razor repository.

That's a good question. I would assume yes if it's called 9.0.0-preview. We can ask in the razor repository.

https://github.com/dotnet/razor/issues/6919#issuecomment-2227037777

@ScarletKuro do you want this merged before v7.2.0 or after?

after

Hey all, I noticed 👀 this PR from the referenced thread.  I wanted to be sure to state that the caching primarily works on subsequent builds.  So the benefits won't currently kick in until you build the second time.  The first build creates the cache and subsequent builds pull from that built cache, greatly improving build times.
(I've updated the Reddit thread to emphasize this)
Be aware, however, that effort is being made to improve the first builds, as well. 👍

@ScarletKuro Do you think this affects code analysis too. I believe when analysing Razor files are design time compiled first in order to resolve symbol references

I'm closing this, as net9 will release very soon. We will use .net9 sdk anyway and get the performance boost.


Content development page

Description
Here's a summary of the changes made in the HTML file for the content development page:

Created a basic HTML structure with:

 and  tags for metadata.
Included necessary metadata like charset and viewport.
Added a title for the page.
2. Created a main layout with:
 containing a page title and navigation links.
 section for the content with individual  elements for each part (Summary, Description, Template, Example, Resources).
3. Added content placeholders within each section:
Placeholder content inside each  for Summary, Description, Template, Example, and Resources.
Reference the issue related to this PR as shown below. Every issue has it's own number you can find the issue numbers here.
Please delete options that are not relevant.

[*] Bug fix (non-breaking change which fixes an issue)

[*] New feature (non-breaking change which adds functionality)

[*] This change requires a documentation update

Screenshot (optional)
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[ ] Test A
[ ] Test B

Test Configuration: (optional)

Firmware version:
Hardware:
Toolchain:
SDK:

Checklist

[*] My code follows the style guidelines of this project

[*] I have performed a self-review of my code

[*] I have commented my code, particularly in hard-to-understand areas

[*] My changes generate no new warnings

Also, add a PR reference i.e fixes #12


Dependency update of org.reflections

Hi @xtermi2, thanks for this cool library!
We tried to integrate it in our project but sadly we are not able to downgrade org.reflections:reflections to a 0.9.x version.
I already saw your effort in https://github.com/ronmamo/reflections/issues/391 to solve this update, but long time no answer...
Please consider my PR https://github.com/senacor/elasticsearch-evolution/pull/233 to fix this dependency problem. Sadly I did not find a solution which is compatible to reflections version 0.9.x AND 0.10.x.
Regards

thanks @RiVogel, looks promising :)

released in v0.4.3


Bug: Type coercion from torch to numpy does not work

Description:
casting a TorchTensor NdArray fails
How to reproduce:
from docarray import BaseDoc
from docarray.typing import NdArray
import torch

class MyDoc(BaseDoc):
    tens: NdArray

t1 = torch.rand(512)
doc = MyDoc(tens=t1)

  Expected a numpy.ndarray compatible type, got <class 'torch.Tensor'> (type=value_error)

TODO:

Fix this in the validate function of NdArray
what about coercions to/from tf? do we have tests for this?

Update: the easy way of fixing this produces unwanted side effects. Basicaly, if we make coercion to np too powerful, then it will break AnyTensor == Union[NdArray, TorchTensor, TensorFlowTensor], since it would cast everything to np. This is due to how pydantic resolves validation for unions.
The only solution i see here is defining our own Union with our own validation rules, and then re-defining AnyTensor in terms of that.
This is a bit more involved than the naive fix, so we de-emphasize that for now.

pining so that you can assign it to me!


Remove some cases of test_union_literal_with_other_type

Change Summary
This PR removes two test cases for pydantic-core integration due to the behavior being changed in https://github.com/pydantic/pydantic-core/pull/1132
Checklist

[x] The pull request title is a good summary of the changes - it will be used in the changelog
[x] Unit tests for the changes exist
[x] Tests pass on CI
[x] Documentation reflects the changes where applicable
[x] My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Assigning this to @davidhewitt, as he'll likely review your other PR once he's back from vacation.
Thanks for your contribution!

I don't completely follow why these test cases are no longer wanted? They still seem to contain correct behaviour.

I don't completely follow why these test cases are no longer wanted? They still seem to contain correct behaviour.

This is a case of serialization against Union[int, Literal['False']]. The test cases assume that the result depends on the order of the arguments (False is serialized to 0 if int type is first in the union type arguments list and to "false" otherwise). https://github.com/pydantic/pydantic-core/pull/1132 has conflicting changes: resulting value is now depends only on the type of the serialized value.
Honestly, I am not sure how should I handle this case: https://github.com/pydantic/pydantic-core/pull/1132 can't be merged without failing tests either on pydantic-core main or pydantic main (in the case of tests updated to the new behavior)

I've merged the pydantic-core PR; the integration tests failing is not a blocker but rather just a signal that things are changing and we need to consider their impact.
For now let's leave this one as-is and when we cut a new pydantic-core release and update pydantic main I'll see if we need to pull this commit in.

Right, now that I've opened #8533 I understand what this was changing. The last commit on that PR addresses these items here; rather than remove them I preferred to just update the test parameters. Many thanks again 👍


Replace Lambda State with HTTP

There's a new state type that will probably allow for this to happen. https://docs.aws.amazon.com/step-functions/latest/dg/connect-third-party-apis.html

Not available in CDK quite yet https://github.com/aws/aws-cdk/issues/28278