wingetcreate update different InstallerType

Brief description of your issue
When you do wingetcreate update --id --version --url https://endswith.msi on a manifest which have https://endwith.exe the InstallerType and InstallerSwitches will remain with the exe switches.

Steps to reproduce
wingetcreate update -i TechSmith.Camtasia -v <IP_ADDRESS>371 -u https://download.techsmith.com/camtasiastudio/releases/2104/camtasia.msi

Expected behavior
Replace the EXE Installer or keep the EXE installer (try to update it) and add the MSI installer.

Actual behavior
Only replaces InstallerUrl and InstallerSha256

Environment
Windows Manifest Creator v<IP_ADDRESS>

Windows Package Manager Manifest Creator version? (wingetcreate.exe -?)

Any other software?

Hey @OfficialEsco,
We don't currently support this behavior so we show a friendly error message to the user, but we do have plans to add this functionality. The reason is because we want to preserve updating with multiple installers. We don't want to risk replacing the wrong installer and we also can't tell if the user wants to replace an existing installer or add a new one. I believe this needs to be addressed in a new modify command which I have roughly outlined here #111.


WebWorker compatibility (for browser multi-threading)

The JSCPP distribution has exactly one error when being loaded into a WebWorker via importScripts(). That error has to do with the way window.JSCPP is assigned in index.js. WebWorkers don't have access to the window object. I was able to fix it in the context of my project by doing the following replacement.
Before:
window.JSCPP = require('./launcher').default;
After:
var JSCPP = require('./launcher').default;
This completely fixes the issue and I'm able to run C++ via a worker. However, I am not familiar enough with NodeJS to determine whether this is a reasonable solution. Just wanted to bring this to your attention.
Thank you for this project, it has been extremely helpful so far.

Thanks for pointing it out. I just added two helper classes to make running JSCPP in WebWorkers easier:
https://github.com/felixhao28/JSCPP/tree/master#running-in-webworker
It should be helpful for you. Debugging in WebWorker is supported too. You can find example code in https://github.com/felixhao28/JSCPP/blob/master/dist/index.html.


Accessing Objects Properties with Bracket Notation- Error message" ReferenceError: Can't find variable: entreeValue"

Challenge Accessing Objects Properties with Bracket Notation has an issue.
User Agent is: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_4) AppleWebKit/601.5.17 (KHTML, like Gecko) Version/9.1 Safari/601.5.17.
Please describe how to reproduce this issue, and include links to screenshots if possible.
My code:
// Setup
var testObj = {
  "an entree": "hamburger",
  "my side": "veggies",
  "the drink": "water"
};

// Only change code below this line

testObj["an entree"];
testObj["the drink"];

getting an error message.. any idea please?
Error message**"  ReferenceError: Can't find variable: entreeValue"****

Just tried this as well, seems the challenge was updated at some point, and the ReferenceError is because it is not finding the vars entreeValue and drinkValue
So to pass you need to keep the
var entreeValue
var drinkValue

in the code and assign the values using the bracket notation to those vars.  Perhaps the instructions need to be updated?

Im not sure...I kept
var entreeValue
var drinkValue
and then entered
testObj["an entree"];
testObj["the drink"];
still getting an error :-(

Looks like this challenge could be more explicit. The original code was:
var entreeValue = testObj;   // Change this line
var drinkValue = testObj;    // Change this line

@Kosaladesilva The challenge needs entreeValue and drinkValue to exist. Add those back in so it looks like the code above and you'll be fine.
This challenge needs an update in the instructions saying:

Using bracket notation on testObj, read in the values of the properties of "an entree" and save it to entreeValue. Do the same with the property "the drink" and save it to drinkValue.

Yes could do with instruction update as to pass this challenge those property values of "an entree"  and " the drink " should pass to
var entreeValue  and  var drinkValue

Is it alright if I take care of this issue?

@LibanTheDev go for it! :+1: Please read the contributing guidelines before taking care of the issue and visit the Contributors Help if you have any questions about helping.

var entreeValue = testObj["an entree"];   // Change this line
var drinkValue = testObj["the drink"];    // Change this line

The solution does not look like what is in the example at all.

exactly! @luke818h


Error: Unknown property "wishlistcomment" for BggCollectionItemDto

I'm querying the collection end point using Alan How as my username.
  client.collection
    .query({
      username: 'Alan How',
      own: 1,
      excludesubtype: "boardgameexpansion",
    })

I encounter the following error:
(node:31220) UnhandledPromiseRejectionWarning: Error: Unknown property "wishlistcomment" for BggCollectionItemDto at [Source '{"name":"Small Islands","yearpublished":2018,"image":"https://cf.geekdo-images.com/wj0V1vCpR11kmq1EpWxxkw__original/img/m_YadJyiLlPK1rTXF4X60V9xyJY=/0x0/filters:format(jpeg)/pic3970233.jpg","thumbnail":"https://cf.geekdo-images.com/wj0V1vCpR11kmq1EpWxxkw__thumb/img/DyPhLsGnU_6DBS2CQ8yo5VcCaC4=/fit-in/200x150/filters:strip_icc()/pic3970233.jpg","status":{"@_own":1,"@_prevowned":0,"@_fortrade":0,"@_want":0,"@_wanttoplay":0,"@_wanttobuy":0,"@_wishlist":0,"@_preordered":0,"@_lastmodified":"2020-05-14 12:39:48"},"numplays":1,"wishlistcomment":"Carcasonne like","objectid":236248,"collid":66004367,"objecttype":"thing","subtype":"boardgame"}']
    at new t (C:\Users\gamek\Documents\Websites\shouldiplay-api\node_modules\jackson-js\dist\lib.node.js:16:21428)
    at e.parseJsonCreator (C:\Users\gamek\Documents\Websites\shouldiplay-api\node_modules\jackson-js\dist\lib.node.js:16:82772)
    at e.deepTransform (C:\Users\gamek\Documents\Websites\shouldiplay-api\node_modules\jackson-js\dist\lib.node.js:16:75298)
    at e.parseIterable (C:\Users\gamek\Documents\Websites\shouldiplay-api\node_modules\jackson-js\dist\lib.node.js:16:99411)
    at e.deepTransform (C:\Users\gamek\Documents\Websites\shouldiplay-api\node_modules\jackson-js\dist\lib.node.js:16:75380)
    at e.parseJsonClassType (C:\Users\gamek\Documents\Websites\shouldiplay-api\node_modules\jackson-js\dist\lib.node.js:16:89686)
    at e.parseJsonCreator (C:\Users\gamek\Documents\Websites\shouldiplay-api\node_modules\jackson-js\dist\lib.node.js:16:82526)
    at e.deepTransform (C:\Users\gamek\Documents\Websites\shouldiplay-api\node_modules\jackson-js\dist\lib.node.js:16:75298)
    at e.parseIterable (C:\Users\gamek\Documents\Websites\shouldiplay-api\node_modules\jackson-js\dist\lib.node.js:16:99411)
    at e.deepTransform (C:\Users\gamek\Documents\Websites\shouldiplay-api\node_modules\jackson-js\dist\lib.node.js:16:75380)
(Use `node --trace-warnings ...` to show where the warning was created)
(node:31220) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 2)
(node:31220) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

Note: You may need to query this username twice as described in #18.

Hi,
thank you for pointing out this problem!
I will add this property that i was not aware of to the response model since my collection has no whishlist comment.


[WIP] NIFI-5585

Please refer to https://issues.apache.org/jira/browse/NIFI-5585 for a description of use-cases for decommissioning nodes.  This PR is based off of work that is being done via https://issues.apache.org/jira/browse/NIFI-5516.
This is a work-in-progress PR.  Nodes can be decommissioned, the flowfiles on the decommissioning node get moved to other nodes that are still connected to the cluster.
A node can be decommissioned by first disconnecting it using the cluster node table's "Disconnect" icon, and then clicking on the "Decommission" icon.
Some things that still need to be done in this PR:

[x] Integration into the Toolkit CLI for requesting the decommission of a node
[ ] Unit/integration tests need to be added
[ ] On the decommissioned node's UI, the status should represent its state.  Currently, a node that is being decommissioned will show as "Disconnected" on the node's UI.
[x] Upgrading FontAwesome from 4.6.1 to 4.7.0 to use an icon for the "Decommission" action other than fa-sun-o, most likely fa-window-close-o
[ ] There are various TODO markers in the code, where further testing needs to be done.  Also, some follow-on JIRAs will be created based off of some of the TODOs.

While testing the reconnection of a decommissioned node, with ~24,000 files split between the two nodes, an error occurred after reconnecting the decomissioned node and attempting to drop all the flowfiles in the queue, from both nodes:
2018-09-20 15:25:22,594 ERROR [Drop FlowFiles for Connection cbbf2971-0165-1000-ffff-ffff94b81269] o.a.n.c.q.c.SocketLoadBalancedFlowFileQueue Failed to drop FlowFiles for org.apache.nifi.controller.queue.clustered.SocketLoadBalancedFlowFileQueue@469caf69
java.lang.IllegalArgumentException: null
	at org.apache.nifi.controller.queue.QueueSize.<init>(QueueSize.java:31)
	at org.apache.nifi.controller.queue.QueueSize.add(QueueSize.java:67)
	at org.apache.nifi.controller.queue.clustered.SocketLoadBalancedFlowFileQueue.adjustSize(SocketLoadBalancedFlowFileQueue.java:514)
	at org.apache.nifi.controller.queue.clustered.SocketLoadBalancedFlowFileQueue.dropFlowFiles(SocketLoadBalancedFlowFileQueue.java:903)
	at org.apache.nifi.controller.queue.AbstractFlowFileQueue$2.run(AbstractFlowFileQueue.java:285)
	at java.lang.Thread.run(Thread.java:748)

The decommission operation was successful, all flowfiles were moved from the decommissioned node to the other node.  After reconnecting the decommissioned node, I couldn't clear the flowfile queue.
After restarting the cluster (both nodes), the queue showed as empty.

While testing the reconnecting of a decommissioned node to the cluster, the issue detailed in NIFI-5619 was encountered.

@jtstorck I've reviewed this PR and offloading scenarios, too. Successfully offloaded multiple nodes at the same time, and confirmed I can offload nodes from UI or NiFi CLI. Thanks for this improvement, I'm +1!


Custom Dewey module work

JIRA issue created by: rcook
Originally opened: 2013-05-13 01:41 PM
Issue body:
Peter did this Dewey work, and I can't recall whether it was complete or had bugs?  [~pkiraly] do you know?>
Anyway, we did not want to be a default to be there. This should be configurable to turn on or off, and should default to off and there should be documentation explaining it.
This issue has an attachment associated with it (external link): dewey.PNG

JIRA Comment by user: pkiraly
JIRA Timestamp: 2013-05-13 02:34 PM
Comment body:
It works as you wrote. It can be turned on and off as any other module, it is turned off by default (in the installation profile). It was ready at time of writing, but last automn OCLC improved the Dewey.info service, providing an unlimited tree hierarchy (previously only the first 3 numbers could be resolved), and the module was not reflect this change. However, I have started working on an experimental module which can be outside of XC, and can be used by any other projects. The purpose of that development was to give an estimation for the planned collaboration with the French Drupal developers (http://drupal.org/project/opac). Our current version has some XC dependencies.
So current version is working, however there are two places of improvements:

unlock the depth of 3 levels to unlimited levels
make it as external module

JIRA Comment by user: rcook
JIRA Timestamp: 2013-06-06 12:06 PM
Comment body:
If this is working as it was, and can be turned off, then I suggest we ensure the default is off, have it documented and then we close.  Peter, if you wish to propose new enhancement work, then please open a new issue.

JIRA Comment by user: pkiraly
JIRA Timestamp: 2013-06-20 03:43 PM
Comment body:
I close this issue, but I would like to know the reason why do you not want this module to work?

Issue resolved: 2013-06-20 03:44 PM


Support adding partition keys dynamically

Currently the partition has a static set of keys. We need to be able to add keys dynamically and add corresponding state steps.
The only way to currently mimic adding keys dynamically is to use a default state step as a fallback.
Our current solution is to use dynamo-like rings.  We can hash keys into a ring and determine which worker the key is on via this method.  We do not allow keys to migrate except in grow-to-fit (which involves stop-the-world) because the costs are too high (see discussion below about migration).  For resource-aware applications, we can use sub-partitioning, essentially dividing a state partition into multiple partitions with multiple rings.  The developer would provide a function that determines if a given key should be constrained to a given sub-partition.

We need to create a state step
We need to pass the input along to it
We need to update the partition routers across the cluster
What happens if people want to create the same key concurrently on multiple workers?

We should avoid this happening by using an algorithm

We need to make sure that our recovery information is updated

Do not want to stop the world

Dynamo style ring ->
can’t grow cluster size beyond max number of rings
This would become distribution algo both for initialization and grow-to-fit/shrink-to-fit
Problem as a distribution algo ->
how does this work with weighting?
how does this work with resource aware layout?
it would appear we need to allow workers to give up keys that are part of their ring section.
How does a worker give up a key?
Tell cluster it’s giving it up and migrate the state step to the appropriate worker
Meanwhile set up a “redirect” on the old state step so that straggler messages that still get there are forwarded to the new state step on the new target worker
All workers update their partition routers
Eventually no messages will ever get to the redirect since all partition routers will point to the new state step
Does this cause problems for our ordering guarantees?

It’s possible to have the following scenario: An actor on worker 1 is going to send two messages to key A.  The first message goes to a redirect state step on worker 2.  Meanwhile, key A state step is migrated to worker 1.  The second message goes directly to the new key A state step (which is now on the same worker as the sending actor).  This means message 2 could be processed by the key A state step before message 1, which breaks our guarantee that two messages sent to the same state step from the same source actor should be processed in order.
Not a good idea, but this algorithm seems like it would work: Say we have a sending actor A sending to key X.  X gets migrated from state step B to state step C.  Meanwhile, state step B changes roles and now exists only to inform senders which messages they need to resend to key X (now at step C).  As soon as A learns that X has been migrated, it records that fact and starts queuing message destined for X.  It also sends a recon message to B to help determine when it can start sending to X normally again.  B, in its new role, replies to any incoming message by sending that message back to the sender, indicating that it must be resent to the new target for X.  As soon as A sees such a reply for the recon message it sent out, it knows it can send all the messages in the queue and start resending to X like normal.  Since B sends its replies in order, by the time A gets a reply for its recon message, A will have already resent any message it sent to B that is sequentially prior to the messages in its queue for X.

This solution is overriden by #2154.

@jtfmumm should we close this?

@SeanTAllen We can I think


52 fix imports and build the project including all the code

Codecov Report

Merging #53 (7e5c494) into release-candidate (2e2f652) will not change coverage.
The diff coverage is 100.00%.

@@                 Coverage Diff                 @@
##           release-candidate       #53   +/-   ##
===================================================
  Coverage             100.00%   100.00%
===================================================
  Files                     41        43    +2
  Lines                    625       633    +8
===================================================
+ Hits                     625       633    +8

Files Changed
Coverage Δ

digimon_card_game/assertions/__init__.py
100.00% <ø> (ø)

digimon_card_game/assertions/assertions.py
100.00% <ø> (ø)

digimon_card_game/cards/information/card_color.py
100.00% <ø> (ø)

...n_card_game/cards/information/digimon_attribute.py
100.00% <ø> (ø)

...igimon_card_game/cards/information/digimon_form.py
100.00% <ø> (ø)

...igimon_card_game/cards/information/digimon_type.py
100.00% <ø> (ø)

digimon_card_game/duels/__init__.py
100.00% <ø> (ø)

..._card_game/extensions/attrs/validators/__init__.py
100.00% <ø> (ø)

...ard_game/extensions/attrs/validators/validators.py
100.00% <ø> (ø)

tests/assertions/list/assertions.py
100.00% <ø> (ø)

... and 27 more


OVSDB disconnect event handling

Refer to this link for build results (access rights to CI server needed):
http://jenkins.socketplane.io/job/socketplane-verify/57/
Test PASSed.

Pulling these commits via #145


How to hide Models(Schemas) below Swagger UI document

Using AzureExtensions.Swashbuckle 3.2.2
I have tried with below code but it removing total schemas.
But my requirement is to hide Models(Schemas) section.
x.DocumentFilter();
internal class RemoveSchemasFilter : IDocumentFilter
{
public void Apply(OpenApiDocument swaggerDoc, DocumentFilterContext context)
{
OpenApiComponents var = swaggerDoc.Components;
var.Schemas.Clear();
swaggerDoc.Components = var;
}
}

Guys any help on this...........

Hi @SankarSutapalli
Please give me a bit more details in order to understand what you are trying to achieve.

What is the goal?
Any implementation details or working example would be appreciated

Hi @vitalybibikov
Thanks for response
i have attached sample doc
we want to hide/remove below "Schema" section
Swagger_CM_CustomerInfo.pdf

Hi, @SankarSutapalli
You need to add the following inthe  Startup into ConfigureSwaggerGensection:
                    x.DocumentFilter<RemoveSchemasFilter>();
And a filter:
    public class RemoveSchemasDocumentFilter : IDocumentFilter     {         public void Apply(OpenApiDocument swaggerDoc, DocumentFilterContext context)         {             foreach (KeyValuePair<string, OpenApiSchema> item in swaggerDoc.Components.Schemas)             {                 swaggerDoc.Components.Schemas.Remove(item.Key);             }         }     }


proxyAddresses - Invalid characters -  apostrophe ?

This document does not include apostrophe as Invalid characters for proxyAddresses, userPrincipalName and mail
See https://support.microsoft.com/en-au/help/2001616/a-user-s-office-365-email-address-unexpectedly-contains-an-underscore
Reference:
https://blogs.technet.microsoft.com/rmilne/2015/05/14/managing-directory-synchronisation-notes-from-the-field/
https://www.granikos.eu/de/justcantgetenough/PostId/276/email-address-policies-and-the-apostrophe
https://support.microsoft.com/en-au/help/4101088/debug-csinterpoolreplication-can-not-correct-pool-ownership-conflict
https://office365.uservoice.com/forums/289138-office-365-security-compliance/suggestions/19550350-apostrophe

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c60ee789-fce6-6c95-150d-be4ae895730e
Version Independent ID: d9e96954-3b85-bf8d-c7d3-916a4698fd77
Content: Prepare for directory synchronization to Office 365
Content Source: Enterprise/prepare-for-directory-synchronization.md
Service: o365-administration
GitHub Login: @JoeDavies-MSFT
Microsoft Alias: josephd

@officedocsbot assign @mypil

@DavidTaig - Thank you for submitting this feedback.
I will get this issue over to the Enterprise writing team for investigation.
Thank you for reporting and making the docs better. Much appreciated.
I made a note to request the team to update this when the work is complete.

@DavidTaig Thank you for your feedback. We have added apostrophe to the invalid characters list. this is being tracked on PR  https://github.com/MicrosoftDocs/OfficeDocs-Enterprise/pull/421

@DavidTaig - From our understanding, the issue has been resolved but it may take a few days for the merged content to appear in the article. If you feel it hasn't been resolved, please re-open this issue.
Thank you for your contribution to make the docs better! Much appreciated

@DavidTaig  This updates has been published. Thanks again for letting us know.


1.3: Support additional style values for flagging

Proposal 13090

@drmacro we discussed this a bit last week when you thought "line-through" had been added to flag values. I think I tracked down why it was not - instead of adding new values, the proposal ended up being a more general change to list style values as space-delimited NMTOKENS instead of providing an enumerated list. The 1.3 text says that processors SHOULD support values that existed in 1.2 but the attribute is now open for other values. (Took me a bit to track down the details, I found the final title for 13090 listed as part of our first big spec review log https://wiki.oasis-open.org/dita/DITA1.3SpecReview1 )
Given that this was a change to free-form style values, I'm not sure exactly that is needed by this feature request. I'm not sure if the existing code can handle space-delimited values, or if it still expects single values. If we want to support additional values beyond what 1.3 lists, we probably need to explicitly list them.

I think it would make sense to build in support for line-through since it's now a value in the highlight domain (and I need it for the @status flagging) and then provide an extension point to make it easy to add support for additional values via plugin.


Type in Container Resources Section

File: cloud/ecs-compose-features.md
Hello, I believe there is a typo in the "Container Resources" section of the above documentation. Per https://github.com/docker/compose-cli/blob/main/ecs/compatibility.go#L63 I believe that the documentation referenced above should say "cpus" not "cpu". I was getting an error when using cpu that was corrected by changing it to cpus in my docker compose file.

Thanks for sharing the issue.
Added the issue to the upstream repo containing the file https://github.com/docker/compose-cli/issues/2152
Closing this.


make TTGlyphPen glyphSet optional

It was always intented to be an optional dictionary. Even the ttGlypgPen_test.py or the fontBuilder.py call TTGlyphPen(None).
We caught this because internally we run a type-checker. Originally the glyphSet parameter was not explicitly typed.
Now that it is, make the type hints match the way code is intended to be used.

If you prefer, we can also keep glyphSet a required positional parameter, but we still need to type it as Optional, meaning it can accept a deliberate None value. Otherwise typechecking tool rejects statement like TTGlyphPen(None). I don't mind having to do that explicitly when I know there are no composite glyphs in the source data I want to draw with the pen.

I'd prefer the argument to be required: it's that way with most pens, and I'd prefer client code to be explicit about "I don't care about components".
No contest regarding the type annotation of course, it's clear that None should be an acceptable value.


ell: 0.59 -> 0.61

Changes:

https://git.kernel.org/pub/scm/libs/ell/ell.git/tree/ChangeLog?h=0.60
https://git.kernel.org/pub/scm/libs/ell/ell.git/tree/ChangeLog?h=0.61

Closes #268838
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Priorities
Add a :+1: reaction to pull requests you find important.

Looks like it exposed iwd's incomplete header inclusion (or similar):
error: builder for '/nix/store/31yjgscir510w00a129l5kj10g4dgh4m-iwd-2.8.drv' failed with exit code 2;
       last 10 log lines:
       > src/ip-pool.c:337:34: error: invalid use of undefined type 'const struct ifaddrmsg'
       >   337 |                 rec.ifindex = ifa->ifa_index;
       >       |                                  ^~
       > src/ip-pool.c: In function 'ip_pool_init':
       > src/ip-pool.c:366:39: error: 'RTNLGRP_IPV4_IFADDR' undeclared (first use in this function)
       >   366 |         if (!l_netlink_register(rtnl, RTNLGRP_IPV4_IFADDR,
       >       |                                       ^~~~~~~~~~~~~~~~~~~
       > make[1]: *** [Makefile:2538: src/ip-pool.o] Error 1 shuffle=3868977690
       > make[1]: *** Waiting for unfinished jobs....
       > make: *** [Makefile:1710: all] Error 2 shuffle=3868977690
       For full logs, run 'nix log /nix/store/31yjgscir510w00a129l5kj10g4dgh4m-iwd-2.8.drv'.

iwd was fixed in https://git.kernel.org/pub/scm/network/wireless/iwd.git/commit/?id=653122498aaf660d3bf9263bf95aa6544ef154c6 (included in 2.10 release).

Pulled trivial backport. Ready for review.

@ofborg build ofono bluez

Added iwd update to 2.10 as well.

@ofborg eval

Thanks. I'd rather we bump iwd together with this than pulling a single commit in

eiwd vendors ell for this reason


New User Error

New user was added to the admin side of CEPI
New user tried to log into the tool and this error was established after the duo authenti
ValueError at_account.pdf
cation process
@SachinPawaskarUNO @MansiKamthan

We deleted old wagtail users prior to this happening. Does wagtail users being deleted have implications on the users in the users area of CEPI admin?

After testing this with two people the following was determined:

When users are deleted from wagtail then they are deleted from the user panel of django
All users initially in the list of users that @MansiKamthan put together were deleted (we assumed no connection)
as a result then users were no longer able to access cepi as a campus user
Tested this with two individuals
also campus user box must be selected or the error attached here will happen

Solution:
Ensure that "is active" and the appropriate check boxes are selected while creating the users. There will be a valueError when the right role is not selected.
This image shows an example for how campuspartneruser checkboxes must be selected.


How to Set Drivable Schedule?

How to Set Drivable Schedule?

This question looks unrelated with the library or please provide more information about the question.


[Feature Request] Possibility of adding video to Conversation Hud

As of now, looking at the conversation-hud templates, the conversation hud module only allows for <img> tags to be created and set for any given conversation. It would be great if we could add videos with the <video> tag to any conversation.
We of course can circumvent this with animated webp but it is cumbersome to use when you could just add a mp4 file.
I see that the template allows for conditional statements, we could add a conditional statement like {{#if isVideo}}. The only problem would be to actually detect whether the given file is a video or not. Moreover, I think the best implementation would be for the video to have the autoplay, muted and loop flags.
PD: Thanks for the module, all DMs in my group (me included ofc) use it and its great

Hey there and sorry for the late reply.
I will be looking into this feature but I cannot promise anything yet. Although adding support for the  tag itself would be easy, there might be some technical limitations that might cause issues (I am mostly concerned about various edge cases that could appear). In theory, it should be possible and not too hard. But I need to look into it.
If it's something that can be added easily, I will add support in the next version of the module. If it's something more complex, it might come in a later version of the module (that is if it's doable, if not I will let you know as soon as possible).

With release 5.4.0, you can now use video files for participant portraits. The currently supported video formats are as follows: .mpg, .mp2, .mpeg, .mpe, .mpv, and .mp4. If there are any other formats that you might be using and I have missed, feel free to tell me.
Furthermore, if you have any other questions or issue, feel free to reach out and I will answer as soon as possible.


Error where there is no custom_error_respone when using version 3.0.3

Description
Latest change in version 3.0.3 is breaking terraform scripts where there is no custom_error_respone.

[X] ✋ I have searched the open/closed issues and my issue is not listed.

Versions

Module version [Required]:
3.0.3
Terraform version:
1.3.4
Provider version(s):
aws 4.39.0

Reproduction Code [Required]

Steps to reproduce the behavior:
Try to create a CloudFront Distribution using terraform-aws-cloudfront module version 3.0.3 without having custom error response
Expected behavior
You should be able to create the distribution with no issue
Actual behavior
Terraform exist with the following error:
╷
│ Error: Invalid index
│
│   on .terraform/modules/aws_cloudfront.cloudfront/main.tf line 252, in resource "aws_cloudfront_distribution" "this":
│  252:       error_code = custom_error_response.value["error_code"]
│     ├────────────────
│     │ custom_error_response.value is object with no attributes
│
│ The given key does not identify an element in this collection value.
╵
Operation failed: failed running terraform plan (exit 1)

Terminal Output Screenshot(s)

Additional context
There is no issue when using version 3.0.2

I believe I've fixed it in 3.0.3 (see #91). Make sure that you are using the correct version of the module, 3.0.2 was broken.

@alka2 most of the time I use ~>, like ~> 3.0.1. But now I just fixed the version with version = "3.0.1"
$ terraform init -upgrade
...

Downloading registry.terraform.io/terraform-aws-modules/cloudfront/aws 3.0.1 for cloudfront.cdn...

which produces a working plan.
If I set to version 3.0.3:
Downloading registry.terraform.io/terraform-aws-modules/cloudfront/aws 3.0.3 for cloudfront.cdn...

then the plan shows the reported error.
The code is:
  custom_error_response = {
    "not_found" = {
      error_code            = 404
      response_code         = 404
      response_page_path    = "/404/index.html"
      error_caching_min_ttl = 10
    },
    "forbidden" = {
      error_code            = 403
      response_code         = 404
      response_page_path    = "/404/index.html"
      error_caching_min_ttl = 10
    }
  }


Python extensions don't work

VSCode Version: 1.0.0
OS Version: Windows 10

Steps to Reproduce:

Install VS Code
Install extension MagicPython, AND / OR
Install extension Python

This issue has been present for a while, including the previous version. I just uninstalled and reinstalled VS Code, and it's still present.
For MagicPython there's no option to choose it in styling selection. In previous version I could select it, but it just didn't apply.
For Python, intellisense etc just don't work even though the extension is supposed to add them. This may be related to auto-indentation not working for python language. (I don't know javascript, but when I try just messing with stuff on a JS file, there's a hell of a lot of features that do work. The issues are with python.)
This issue was the same for Ubuntu 15.10, VS Code 0.9 but I haven't tried it with the 1.0 release.

I'm having the same problem with my babel es6/es7 extension.
The mode doesn't seem to appear anymore in the palette, looks like a regression bug

@dzannotti The issue I had had been there ever since I updated VS Code some months ago. Back when I first installed VSC (around September 2015, give or take a month) auto-indentation and code completion worked by default. It stopped working after updating, but at the time I was busy writing code for a final exam and didn't submit a bug report. The point is, issue with python usability is not new to 1.0 version. Addition of the extensions didn't do anything at all. For python VSC is basically a bare bones text-field.
(I posted this on the other thread too dzannotti, but I meant to post here. Sorry for the double mention.)

The issue I had had been there ever since I updated VS Code some months ago. Back when I first installed VSC (around September 2015, give or take a month) auto-indentation and code completion worked by default.

This is another scenario, let's keep this out of this issue :smile: . This is the interesting scenario.
The babel extension, contributes/overloads the JS extension and contributes a tmGrammar for JS
"languages": [
			{
				"id": "javascript",
				"aliases": [
					"Javascript (Babel)"
				],
				"extensions": [
					".js",
					".jsx",
					".es6"
				],
				"firstLine": "^#!.*\\bnode",
				"mimetypes": [
					"text/javascript"
				]
			}
		],

When you open the language menu then javascript (babel) doesn't show up anymore. This has worked in 0.10.11 and looks like a regression. I know we made changes there. CCing some folks
Any ideas what could have caused this change of behaviour
@dbaeumer @bpasero @alexandrudima @jrieken

The Magic Python extension does the same and it is popular 10K of installs, the users of Magic Python will be hit by this as well.

@egamma when I revert https://github.com/Microsoft/vscode/commit/fcb8e57b609f068d4bd05cf09f98a89b6be94049 I can get the overwrite to happen. Looks like a regression from that commit...

I am not sure why @alexandrudima added a check here (https://github.com/Microsoft/vscode/blob/master/src/vs/editor/common/services/languagesRegistry.ts#L151) that would prevent the language override.
@jrieken @dbaeumer any clue?
If I take out this if check, it seems to work.
Btw I think the language is picked up, just the label in the status bar and the picker is not changed.

It seems like it was a bad fix for  #4360 which was about not seeing the language name in the status bar. The regression is definitely worst than the previous bug

@bpasero doesn't looks like it, if i inspect the code with devtools the tags are the default ones

Verified that the MagicPython extension has the same isseu. Labeling as important.

fcb8e57 affects no functionality whatsoever except the UI language name. The change in that commit forces that the language name (the label that shows in the bottom right corner) is always used from the first time a language was contributed.
Here is what gets contributed when installing MagicPython:

from our default python extension:

	"contributes": {
		"languages": [{
			"id": "python",
			"extensions": [ ".py", ".rpy", ".pyw", ".cpy", ".gyp", ".gypi" ],
			"aliases": [ "Python", "py" ],
			"firstLine": "^#!/.*\\bpython[0-9.-]*\\b",
			"configuration": "./python.configuration.json"
		}],
		"grammars": [{
			"language": "python",
			"scopeName": "source.python",
			"path": "./syntaxes/Python.tmLanguage"
		},{
			"scopeName": "source.regexp.python",
			"path": "./syntaxes/Regular Expressions (Python).tmLanguage"
		}]

from MagicPython:

"languages": [
			{
				"id": "python",
				"aliases": [
					"MagicPython",
					"python"
				],
				"extensions": [
					".py",
					".py3",
					".rpy",
					".pyw",
					".cpy",
					".SConstruct",
					".Sconstruct",
					".sconstruct",
					".SConscript"
				]
			}
		],
		"grammars": [
			{
				"language": "python",
				"scopeName": "source.python",
				"path": "./grammars/MagicPython.tmLanguage"
			}
		]

VSCode correctly respect the overwriting of the grammar (see below screenshots of coloring before & after), also all the additional file extensions added to python. The only thing that gets "stuck" is the language name (the UI label) as Python.
At the time of fcb8e57 I thought that to be a good decision (i.e. why would a single programming language have 2 or more different names or why would they be different). I didn't realize extensions use this as a sort of "branding" for the grammars.
IMHO this issue is not important (no need for backporting) as there is 0 functionality impact, it is a usage of the alias in a way I have not foreseen (as a branding mechanism instead of as an alias to a programming language).
Before installing MagicPython in the Quiet Light theme:

After installing MagicPython and restarting (also in the Quiet Light theme):


picking which GPU to run the model on

Hello,
First, thanks for the great lib and great work. I was wondering if there is a way to pick which cuda device to run my model on ? tried to search for it but it seems to automatically detect and just pick.

This is something that should be exposed at the level of SetFit.
Currently, a SentenceTransformer is initialized here:
https://github.com/huggingface/setfit/blob/5313939b638b57668a1b5a67ef600e54da221d9a/src/setfit/modeling.py#L325
If you look at the documentation of the SentenceTransformers constructor, there is an option to pass device info.
I only have one GPU so I can't test it, but my guess is you can do something like:
st = SentenceTransfomer('some_model_name', device=your_device_id) # this is your local model or generic sentence transformer
setfit_model = SetFit(model_body = st, model_head = LogisticRegression()) # Logistic regression from sklearn


Automatically implement interface fields on implementor graphql objects?

Ideally I'd like to be able to do
pub trait Node {
    fn id(&self) -> &Uuid;
}

pub struct Queue {
    pub id: Uuid,
    pub name: String,
    ...
}
impl Node for Queue {
    fn id(&self) -> &Uuid {
        &self.id
    }
}

graphql_interface!(<'a> &'a Node: Context as "Node" |&self| {
    field id() -> &Uuid {
        self.id()
    }

    instance_resolvers: |&context| { ... }
});

graphql_object!(Queue: Context |&self| {
    interfaces: [&Node]
    field name() -> &str {
        &self.name
    }
});

And get
scalar Uuid

interface Node {
  id: Uuid
}

type Queue implements Node {
  id: Uuid
  name: String
}

Currently you can get an invalid schema if you forget to implement the id field on the Queue object.
Python's Graphene works in this way http://docs.graphene-python.org/en/latest/types/interfaces/
I realise this wouldn't be a very backwards-compatible change
Thoughts?

Interesting finds!
The fact that you can create an inconsistent schema is very problematic. I guess another way to cause an inconsistency is to have a mismatch between instance_resolvers and interfaces, too. These kinds of issues need to be guarded against; either by designing the API so they are impossible to create, or making sure that creating an invalid schema panics/returns errors.
The other part, automatically implementing interface fields on object types seems convenient. I'm not sure how to do this in the, though. Juniper can not "upcast" an object into an interface in the general case or vice versa - this is why we need the awkward instance_resolvers. If anyone has any ideas here, let me know :)

@tyranron I would like to help fix this but wouldn't want to interfere with #1072. Are there plans to address this in #1072, should I wait?

@nikis05 doesn't this work already on the latest master? I believe this should have been fixed by #1009.


Smarter install/uninstall

ie don't say we uninstalled something if it was already uninstalled and vice versa

Not gonna do this as it could be too much of a source of error.


fix typo in renderArrowNext ()

The title prop for the Arrow component in renderArrowNext () should be Next (Right arrow key) not Previous (Right arrow key)

This issue was fixed with merge in master #109

Ah I see, closing this.

Sorry I should have been more clear, in #109 you fixed the typo in the Lightbox component. This fixes the typo in PaginatedThumbnails component.


Updated dependencies to latest

Requires Node 8, but then Node 6 has reached end of life, so all npm libraries should now require Node 8.

Updated the engines.node
This change should not affect the target in tsconfig.json

Thanks!


Fixed parsing of empty code blocks.

Fixes #615
There's another test failing (def_blocks), but it was also failing before this fix.

@chjj I don't understand why the test suite removes all whitespace before comparing the actual and expected output. As you can see from my fumbling around with these highly whitespace-sensitive fixes here, it would have been a great help if the fixtures were matched exactly, and it would also make the error messages from the test suite much more readable.
I'll happily contribute a rewrite of the test suite in that direction if you're interested.

Interesting. What's the use-case for empty code blocks? Does GFM allow them? Weird. Anyway, yeah, this looks alright.
As for the test suite, I didn't want to make the html whitespace output 100% accurate to the original markdown. It's a mess, and I like the way marked does it better. Every engine does it a bit differently and a lot of other markdown engines borrowed what I added to the original test suite, so I make the whitespace insignificant: also because it is technically insignificant in the html world.
I agree the test failure output is annoying to read. I wouldn't be opposed to keeping the whitespace insignificant for testing, but giving better error output based on the character index at which it failed. It shouldn't be hard to find the corresponding character index for the whitespace version.

Interesting. What's the use-case for empty code blocks?

Funny story, actually. We're building an assertion library called Unexpected, which is very focused on high quality error messages, which we're trying to improve all the time. That makes it a challenge to keep the documentation up-to-date, so we decided to build a test runner of sorts that actually runs the code snippets in our documentation and compares the error message to the explicitly labelled output, for example:
    In case of a failing expectation you get the following output:

    ```javascript
    expect({ a: 'f00', b: 'bar' }, 'to have own properties', {
      a: 'foo',
      c: 'baz'
    });
    ```

    ```output
    expected { a: 'f00', b: 'bar' } to have own properties { a: 'foo', c: 'baz' }

    {
       a: 'f00', // should equal 'foo'
                // -f00
                // +foo
      b: 'bar',
      c: undefined // should equal 'baz'
    }
    ```

This is already pretty good for regression tests. But sometimes when we're implementing a new feature we just want to base the documentation on the actual error message, so we have another script that runs all the code snippets and updates the output blocks with the resulting error messages. Those changes can then be comfortably reviewed using git diff. In cases where we just want to bootstrap the documentation from the actually output error message, we just use that script, and that's where the empty output blocks come in. They serve as a marker for where we want the actual error message added:
    In case of a failing expectation you get the following output:

    ```javascript
    expect({ a: 'f00', b: 'bar' }, 'to have own properties', {
      a: 'foo',
      c: 'baz'
    });
    ```

    ```output
    ```

This sort of documentation-driven development is working remarkably well for us, so we'll probably try experimenting with it in other projects unrelated to testing soon :)

As for the test suite, I didn't want to make the html whitespace output 100% accurate to the original
markdown. It's a mess, and I like the way marked does it better. Every engine does it a bit differently
and a lot of other markdown engines borrowed what I added to the original test suite, so I make the
whitespace insignificant: also because it is technically insignificant in the html world.

I agree the test failure output is annoying to read. I wouldn't be opposed to keeping the whitespace
insignificant for testing, but giving better error output based on the character index at which it failed.
It shouldn't be hard to find the corresponding character index for the whitespace version.

Since the test cases with both the input and the expected output are checked into the test folder here, I maintain that it would be better to match them against each other whitespace sensitively, and then just adjust the expected output of the 10-ish cases where they currently don't match up. At least then we'd know exactly what comes out.
Oh, it just occurred to me that you might have inherited the fixtures from some other project that you don't want to be completely whitespace-compatible with? If you're not keeping the fixtures in sync with an upstream project, I still think we should just make the adjustments or come up with a matching strategy that only ignores the kinds of differences that you explictly don't care about.

@papandreou, your PR caused 2 tests to fail. I've reverted it to the old rule changing [\s\S]+' to [\s\S]*` which passes your added tests.

Since the test cases with both the input and the expected output are checked into the test folder here, I maintain that it would be better to match them against each other whitespace sensitively, and then just adjust the expected output of the 10-ish cases where they currently don't match up. At least then we'd know exactly what comes out.

Like I said, I think it would be better to keep the tests whitespace-insignificant, but make the error output display the whitespace properly. HTML is whitespace insignificant so this presents no problem.

Oh, it just occurred to me that you might have inherited the fixtures from some other project that you don't want to be completely whitespace-compatible with?

The original tests were taken from the official markdown test suite (released on a mailing list many years back). I don't plan on touching them. In test/new I've added my own tests.

Damn, sorry about that. Reverting to the old rule will mean that certain whitespace won't be emitted as part of the output, though, and in my use case all that whitespace is significant.
I guess I'll have to come back with another attempt later.

@papandreou, I modified the old rule to allow no text within the code fences, so now the tests you added pass, along with all the others.


[SQL Lab] Can't scroll in SQL Lab Query History

Can't scroll in SQL Lab query history - the scroll bar is not there.
Expected results
User was previously able to scroll using a scoler on the right side.
Actual results
User can't scroll to see previous query history details
Screenshots

How to reproduce the bug

Go to SQL Lab
Run few queries
Click on Query history
See you can't scroll

Environment
(please complete the following information):

superset version: master

Checklist
Make sure to follow these steps before submitting your issue - thank you!

[ ] I have checked the superset logs for python stacktraces and included it here as text if there are any.
[x] I have reproduced the issue with at least the latest released version of superset.
[x] I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context
Add any other context about the problem here.

FYI @yousoph

FYI, this just happened again - can't scroll on query history tab (I'll open a new gh# for it)


add a contact page/email address

i guess we need some kind of email contact details?
i'm slightly reluctant to set up email via google, just because it costs money and is a bit un-necessary
maybe we could have a mailing list? or even simply just a general gmail email that is forwarded to a few people? thoughts?

would a free proton mail account suffice?

@marcosh yep that sounds good

done; i made<EMAIL_ADDRESS>

maybe we can add the password as a secret into the org repo somehow.

should we forward mail? Or share the password? Or share somehow a password manager account?

i'm not totally sure
forwarding might work; but it might be confusing as to who should respond, if it ends up going to all the committee members, say.
maybe for now i'll just work out how to put the password in the org repo, and we can deal with it as it comes ...

I would recommend setting up a password manager, since we're probably going to have several passwords flying around


build: downgrade packages with invalid attestations

See https://twitter.com/davidlj95/status/1767222233750028588

#276  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @davidlj95 and the rest of your teammates on  Graphite


Unhandled rejection Error: Cannot find module './au-table'.

I'm trying to use aurelia-table inside the ASP.NET Core SPA Templates project template. I followed the instructions on the aurelia-table docs for Webpack:
npm install au-table --save

Then inside my webpack.config.vendor.js file:
vendor: [
            ...
            'au-table'
        ],

Inside the boot.ts => configure(...):
    aurelia.use
        .standardConfiguration()
        .developmentLogging()
        .plugin('au-table');

During startup, I get the following error:
Unhandled rejection Error: Cannot find module './au-table'.
    at webpackContextResolve (http://localhost:52883/dist/app.js?v=zDdjozsbuRgOZRkI4iCXHAyJTLXuVjqH7rmzHFlXydM:319:9)
    at webpackContext (http://localhost:52883/dist/app.js?v=zDdjozsbuRgOZRkI4iCXHAyJTLXuVjqH7rmzHFlXydM:314:29)
    at http://localhost:52883/dist/app.js?v=zDdjozsbuRgOZRkI4iCXHAyJTLXuVjqH7rmzHFlXydM:1939:47
    at tryCatcher (http://localhost:52883/dist/vendor.js?v=v9GqwVx6JdS5h4Fcp0GWmRCQf4hN06km_igzxc-M6uo:20977:23)
    at Promise._settlePromiseFromHandler (http://localhost:52883/dist/vendor.js?v=v9GqwVx6JdS5h4Fcp0GWmRCQf4hN06km_igzxc-M6uo:18999:31)
    at Promise._settlePromise (http://localhost:52883/dist/vendor.js?v=v9GqwVx6JdS5h4Fcp0GWmRCQf4hN06km_igzxc-M6uo:19056:18)
    at Promise._settlePromise0 (http://localhost:52883/dist/vendor.js?v=v9GqwVx6JdS5h4Fcp0GWmRCQf4hN06km_igzxc-M6uo:19101:10)
    at Promise._settlePromises (http://localhost:52883/dist/vendor.js?v=v9GqwVx6JdS5h4Fcp0GWmRCQf4hN06km_igzxc-M6uo:19180:18)
    at Async._drainQueue (http://localhost:52883/dist/vendor.js?v=v9GqwVx6JdS5h4Fcp0GWmRCQf4hN06km_igzxc-M6uo:15909:16)
    at Async._drainQueues (http://localhost:52883/dist/vendor.js?v=v9GqwVx6JdS5h4Fcp0GWmRCQf4hN06km_igzxc-M6uo:15919:10)
    at Async.drainQueues (http://localhost:52883/dist/vendor.js?v=v9GqwVx6JdS5h4Fcp0GWmRCQf4hN06km_igzxc-M6uo:15793:14)
    at MutationObserver.<anonymous> (http://localhost:52883/dist/vendor.js?v=v9GqwVx6JdS5h4Fcp0GWmRCQf4hN06km_igzxc-M6uo:20231:17)

Am I doing something wrong?

I have never tried it with those templates, I will give a try as soon I have a chance

Ok thanks, just as an FYI, I am using another aurelia plugin, aurelia-validation inside the same project template, without any issues.

I managed to resolve this issue, by adding <require from="au-table"></require> inside a template.

I'm about to release a new version with better support for webpack 2.0, hopefully this will get rid of this problem.


Feature Request: Add CallSign and Timestamp to Backup Filename + JSON Formatting

Hello,
I have several Trackers and iGates with different configurations and various CallSigns. It would be really helpful to have the ability to download the backup file with a filename that includes the corresponding CallSign and a timestamp for easier organization and identification.
Additionally, it would be great if the downloaded JSON could be formatted in a more readable way, with line breaks and proper indentation (pretty-printed).
Thank you for all your hard work and for continuously improving this project!
Best regards,
Aendes

the callsign add could be done without any problem, the time I guess is redundant as you have this as it is downloaded to the PC.
the pretty printed part I dont know (yet) how to achieve it, but will search for it


Uninitialized local still permits provably erroneous use-before-assign in closure

🔎 Search Terms
uninitialized, local, use before assign, control flow
🕗 Version & Regression Information

This changed in commit or PR https://github.com/microsoft/TypeScript/pull/55887

⏯ Playground Link
https://www.typescriptlang.org/play/?ts=5.7.0-dev.20240925#code/DYUwLgBAZg9jBcEDOYBOBLAdgcwNwCh8BjGTFZcAMTggF4IAKASkQDcZ0ATOgPggG98ECOiiNYMAHSgcYABYQAPBACMTAUOHQa9AOQTdBYQF98xgvhAAPAA4xUkfqaA
💻 Code
let foo: string;

const setFoo = (): void => {
  if (foo.length < 1) {
    foo = 'foo';
  }
};

export {}

🙁 Actual behavior
No TS Error
🙂 Expected behavior
Variable 'foo' is used before being assigned.(2454)
Additional information about the issue
(this error is correctly reported if we never assign at all, as below)
let foo: string;

const setFoo = (): void => {
  if (foo.length < 1) {
  }
};

export {}

Related, https://github.com/microsoft/TypeScript/issues/60064.
Otherwise this can be solved by not considering assignments which occur unconditionally after a read.

@RyanCavanaugh Sorry to ping, but I see the label has changed to "Awaiting More Feedback" but there's no other discussion. Is there anything you need from me or is discussion waiting on something else?

Neither? For feedback like this we would be wanting to hear from more than one person encountering a particular kind of situation.

Ah, gotcha, ok. I misunderstood what the label meant. Thanks for clarifying!

class DataProcessor {
    private processedData: string;
    constructor(data: string) {
        if (data.length > 0) {
            this.processedData = this.process(data);
        }
        // Still missing initialization for the empty data case
    }
    logProcessedData() {
        console.log(this.processedData);
        // We should get error in TypeScript 5.7: Variable 'processedData' is used before it is assigned.
    }
}


UHF-1597: Accessibility

How to test (if you have no setup etc.):

composer create-project City-of-Helsinki/drupal-helfi-platform:dev-main hel-platform --no-interaction --repository https://repository.drupal.hel.ninja/
cd hel-platform
Switch to corresponding branches:

composer require drupal/helfi_tpr:dev-UHF-1597_accessibility && composer require drupal/hdbt:dev-UHF-1597_accessibility && composer require drupal/helfi_platform_config:dev-UHF-1597_accessibility

Run make new
Run make shell
cd public
First you need to enable helfi_tpr_config feature since it is not on by default in platform:drush en -y helfi_tpr_config
Next you need to fetch some units from TPR: MIGRATE_LIMIT=500 drush mim tpr_unit and the services drush mim tpr_service
drush cr
Go to https://hel-platform.docker.sh/fi/admin/content/integrations/tpr-unit select Finnish and search with Paloheinän kirjasto

Open the unit and check that the accessibility sentences is themed according to the design

Also check the referenced PRs below.

I think there is some double border on the normal accordions now? Or was it there before already?

Works really well 😍 Just one thing I noticed on the normal accordions that could be because of this or not. Could be by design as well but lets make sure :)

This was indeed a small glitch. Fixed it before merging the PR.


AttributeError with raw_status in on_relationship_update event

Summary
An AttributeError sometimes occurs when trying to read the raw_status attribute of a Relationship
Reproduction Steps
Run the code below, then open Discord and friend a user. The error will occur.
Code
import discord

class Client(discord.Client):
    async def on_ready(self):
        print("Connected.")
    async def on_relationship_update(self, before, after):
        print(after.raw_status)

client = Client()
client.run("<token>")

Expected Results
The code should print the Relationship's raw status when a relationship update occurs.
Actual Results
An error occurs:
Ignoring exception in on_relationship_update
Traceback (most recent call last):
  File "/.../discord/client.py", line 462, in _run_event
    await coro(*args, **kwargs)
  File "/.../test.py", line 7, in on_relationship_update
    print(after.raw_status)
  File "/.../discord/relationship.py", line 169, in raw_status
    return self.presence.client_status.status
  File "/.../discord/relationship.py", line 145, in presence
    return self._presence or state._presences.get(self.user.id) or state.create_offline_presence()
AttributeError: 'Relationship' object has no attribute '_presence'

System Information
discord.py-self is not installed globally, and I'm not sure how to run that command on a local module. I'm using the latest commit from 2 days ago.
Checklist

[X] I have searched the open issues for duplicates.
[X] I have shared the entire traceback.
[X] I am using a user token (and it isn't visible in the code).

Additional Information
No response

This should be fixed now, thanks.


GKE Autopilot cluster fails on private_cluster_config export or import of routes.

Describe the bug
Autopilot cluster creation fails if trying to export or import routes on peering_config in private_cluster_config.
Environment
terraform -version
Terraform v1.7.4
on darwin_arm64```

output from `git rev-parse --short HEAD`
3933a747

To Reproduce
Create an autopilot cluster and set
private_cluster_config = {
  enable_private_endpoint = true
  master_global_access    = false
  peering_config = {
    export_routes = true
    import_routes = true
  }
}

it will pop the an error
Expected behavior
The autopilot cluster is created.
Result
module.cluster.google_compute_network_peering_routes_config.gke_master[0]: Creating...
╷
│ Error: Error creating NetworkPeeringRoutesConfig: googleapi: Error 400: Required field '' not specified, required
│
│   with module.cluster.google_compute_network_peering_routes_config.gke_master[0],
│   on ../../../modules/gke-cluster-autopilot/main.tf line 368, in resource "google_compute_network_peering_routes_config" "gke_master":
│  368: resource "google_compute_network_peering_routes_config" "gke_master" {
│
╵

Additional context
Since gke 1.29 the GKE master is reached via PSC endpoint also for private clusters, so there shouldn't be a peering to configure, an therefore the error. This should be checked on standard cluster as well.

I would be happy to look into this and tackle, raised the bug for double check/tracking.

just set peering_config = null?

yes, that's the workaround I tested and work!
I was wondering if this has to be tackle in the fabric code as well. After 1.28 goes in EOL, peering_config will not make sense anymore, right?

Probably but for the time being I'd keep it


[sysrst_ctrl] Minor fixes to get to D1

Michael,
Looks good to me. Thanks.
-Eric

Can someone approve this one such that we can move sysrst_ctrl into D1?

Thanks!


fix: password read on windows

Signed-off-by: Matej Vasek<EMAIL_ADDRESS>

Beware of the above code; I didn't tested it.

@lkingland I don't even know how to write integration test for this.
First idea might be echo  "mvasek\npasswordhere\n" | f deploy --build=false -v. But that won't work.
It does causes read syscall to get expected input. However for password you also need to invoke ioctl syscall to disable character echoing. result is inappropriate ioctl for device. :disappointed:

@ramo

@lkingland I don't even know how to write integration test for this.
First idea might be echo "mvasek\npasswordhere\n" | f deploy --build=false -v. But that won't work.
It does causes read syscall to get expected input. However for password you also need to invoke ioctl syscall to disable character echoing. result is inappropriate ioctl for device.
EDIT:
it can be done by expect -c 'spawn -noecho func deploy --build=false -v; send "mvasek\npwdhere\n"; interact'

@jrangelramos it might be good to test this in our e2e tests if possible.

@boson-project/core I added just tiny amendment: trimming of \r character.

Yea. @matejvasek That's a good point to test and ensure it won't break on future.  I think using expect as you mentioned could work as well


Type errors (not critical) are popping up in places like TreeChild

Somewhat fixed with commit
https://github.com/frappedevs/FusionRouter/commit/5fc789c75a598c422e3306b57b251dd8f122ebab


Line number not centered

I recently updated asciidoctor-fopub for the first time after a year or so. This is why I can not tell when exactly the page number moved out of the centre.

I wonder if this has to do with upgrading the DocBook toolchain to 1.79.1 (from 1.78.1). That's where I'd start looking.

That's literally the only change that has happened in a long time that affected the XSL. So ?

First, I'm glad you got it working! You also verified that the Gradle 4.9 upgrade is a go.
My thought is that the cleaning itself solved the problem. You may have run it once when it was in some sort of transitional state. It's always good to clear the cache from time to time just to be certain, esp as a developer. (Remember to nuke ~/.gradle, build, and the local .gradle folder).


Custom type name lookup not working

I have a query working with graphql but not with graphlient because of the naming  of the type.
I tried to investigate the issue but it went down pretty deep (graphql-client gem) and couldn't figure out why it works with a simple graphql query and why not with graphlient.
Do you have any ideas where this goes wrong?
The error is the following (It tries to lookup Vehicle, but it should lookup VehicleType).
   Failure/Error: response = client.execute(vehicle_query, id: vehicle.id)

     Graphlient::Errors::ClientError:
       Field 'vehicle_alerts' doesn't exist on type 'Vehicle'
     # /Users/silo/Desktop/carforce/gems/graphlient/lib/graphlient/client.rb:32:in `rescue in execute'
     # /Users/silo/Desktop/carforce/gems/graphlient/lib/graphlient/client.rb:20:in `execute'
     # ./spec/graphql/queries/vehicle_query_spec.rb:49:in `block (5 levels) in <top (required)>'
     # ./spec/rails_helper.rb:72:in `block (3 levels) in <top (required)>'
     # /Users/silo/.rvm/gems/ruby-2.5.1/gems/database_cleaner-1.7.0/lib/database_cleaner/generic/base.rb:16:in `cleaning'
     # /Users/silo/.rvm/gems/ruby-2.5.1/gems/database_cleaner-1.7.0/lib/database_cleaner/base.rb:100:in `cleaning'
     # /Users/silo/.rvm/gems/ruby-2.5.1/gems/database_cleaner-1.7.0/lib/database_cleaner/configuration.rb:86:in `block (2 levels) in cleaning'
     # /Users/silo/.rvm/gems/ruby-2.5.1/gems/database_cleaner-1.7.0/lib/database_cleaner/configuration.rb:87:in `cleaning'
     # ./spec/rails_helper.rb:71:in `block (2 levels) in <top (required)>'
     # ------------------
     # --- Caused by: ---
     # GraphQL::Client::ValidationError:
     #   Field 'vehicle_alerts' doesn't exist on type 'Vehicle'
     #   /Users/silo/Desktop/carforce/gems/graphlient/lib/graphlient/client.rb:29

See my classes the and the queries below:
field :vehicle_lookup,
          resolver: Queries::VehicleLookupQuery,
          description: 'Vehicle from lookup service without ID',
          authenticate: true

module Queries
  class VehicleQuery < Queries::BaseQuery
    type Types::VehicleType, null: false
    argument :id, String, 'id', required: true

    def resolve(id:)
      Vehicle.find(id)
    end
  end
end

module Types
  class VehicleType < GraphQL::Schema::Object
    field :id, ID, 'Primary key', null: false
    field :make, String, 'Make', null: false
    field :vehicle_alerts,
          [Types::VehicleAlertType],
          'Vehicle Alerts',
          null: false do
      argument :state, String, 'state', required: false
    end

    def vehicle_alerts(state: 'active')
      HasManyLoader.for(
        VehicleAlert, :vehicle_id, where_options: { state: state }
      ).load(object.id)
    end
  end
end

See graplient and gql queries below:
let(:vehicle_query) do
  <<-GRAPHQL
    query($id: String!) {
      vehicle(id: $id) {
        id
        make
        vehicle_alerts {
          id
        }
      }
    }
  GRAPHQL
end

This works from any FE/graphql interface (graphiql, etc.)
const vehicleQuery = gql`
  query($id: String!) {
    vehicle(id: $id) {
      id
      make
      vehicleAlerts {
        id
      }
    }
  }
`;

Have you tried replacing the vehicle_alerts field in the let(:vehicle_query) with vehicleAlerts?

Yeah, that's it. Thx!


Return vs Exchange

@nishant-cyro @priyank-gupta When customer is requesting for refund / exchange we should have a clear option for customer to choose from exchange vs refund. Right now if customer don't choose any option from the exchange for dropdown we take it as refund request. We can have a radio button exchange vs refund and show the exchange for dropdown only when exchange is chosen.
Also, Total pre-tax refund amount is displayed even if I have selected for exchange.

@bansalakhil - Thanks for the suggestions, we will look into it ASAP.

@nishant-cyro - Done in PR #19


Fix cross tenant gather

This PR fixes the issue that multi-tenancy may grab the data of wrong tenant and thus lead to unexpected failure.
Verified this issue is fixed.

/approve

/approve

/lgtm

/lgtm


[Custom application]: add validation for dot and multiple slashed at the end for "Completion url' field

EPAM AI DIAL chat version
0.18.0
How to reproduce
Steps:

open Add application form
input in "Completion URL" field values
https://example.
http://example//

Actual result
no error hint displayed
Expected result
incorrect url format should be validated and hint error should be displayed if input format is not correct
Confidential information

[X] I confirm that do not share any confidential information

waiting for #2229


Sigma(M) in 2D

We currently extrapolate sigma(M,z) in z using the linear growth factor. This fixes that.

Currently works but it's rather slow.

Closes #609

Pull Request Test Coverage Report for Build 4916

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.001%) to 96.747%

Totals

Change from base Build 4865:
-0.001%

Covered Lines:
3093

Relevant Lines:
3197

💛  - Coveralls

Now addressed in #843


Problem find sub-windows

I'm trying to automate some WPF application, and it has a couple of windows.
I tried to get a window, but i failed in any way I tried.
I can see that the hwnd has children with spy, and that I get the right window (same hwnd).
But, still I wont get his sub windows.
Images attached (spy++ window, code to check the hwnd, code which fails)

Specifications

Pywinauto version: 0.6.6
Python version and bitness: <IP_ADDRESS>, 64 bit
Platform and OS: desktop pc, windows 10

Are you able to call top_win.dump_tree() ?
Can you find this child_window(auto_id="...") line in the output?

The exception tells you that parent window top_win is found, but child one is not.

Thank you for your answer.
I have been able to call top_win.dump_tree(), and it doesn't show the windows in the tree.

And what is the output? Empty?

It's not empty.
It's contain a few control that the app has on hwnd 0x161464.

Do the app has a log? So I can send it to you.
Or their is anything else that I can do?

Just post the output of the dump_tree() or send to me privately. Find it with "vasily-v-ryabov".replace("-", ".") at gmail dot com.

@aradzu10 thanks a lot for providing sample app.
The picture is clear to me now. The child window has correct parent window, but parent one has no such child in the list of children according to Inspect.exe. But this child window is visible to parent window in Spy++.
So we can workaround it in 2 ways:

Use backend="win32" to obtain the child window and its handle. Then pass this handle to app_uia.window(handle=child_hwnd, top_level_only=False).wrapper_object().
Use .from_point(x, y) method where (x, y) could be coordinates of .rectangle().mid_point() of the main window. It works in Inspect.exe and will work in pywinauto.

But we may implement the first workaround in the library. Let's keep this issue open so far.

Glad to see I could help here.
Thank you for your response.


aie 0.10.0

Microsoft Reviewers: Open in CodeFlow

This app installs and works fine on my pc (winget v0.2.10191)
Is this error happening during installing or the first launching after installation?

This app installs and works fine on my pc (winget v0.2.10191)
Is this error happening during installing or the first launching after installation?

i will retry


reducing uperf test runtime for CI

Just to reduce the runtime as current testing time takes over 500 seconds

Results for minikube_jjb

Test
Result

test_ycsb.sh
Pass

test_fiod.sh
Pass

test_smallfile.sh
Pass

test_pgbench.sh
Pass

test_iperf3.sh
Pass

test_sysbench.sh
Pass

test_uperf.sh
Pass

test_byowl.sh
Pass

Results for minishift_jjb

Test
Result

test_ycsb.sh
Pass

test_fiod.sh
Pass

test_smallfile.sh
Fail

test_pgbench.sh
Pass

test_iperf3.sh
Pass

test_sysbench.sh
Pass

test_uperf.sh
Pass

test_byowl.sh
Pass

Results for kni_jjb

Test
Result

test_ycsb.sh
Pass

test_fiod.sh
Pass

test_smallfile.sh
Pass

test_pgbench.sh
Fail

test_iperf3.sh
Pass

test_sysbench.sh
Pass

test_uperf.sh
Pass

test_byowl.sh
Pass


CRD generation : map values must be a named type, not *ast.StarExpr

Bug Report
What did you do?
Upgraded the operator-sdk to version v0.15.0, and used operator-sdk generate crds, to generate crd from spec : https://github.com/Orange-OpenSource/casskop/blob/master/pkg/apis/db/v1alpha1/cassandracluster_types.go#L818
What did you expect to see?
Having my crd object generated with the following logs :
$ operator-sdk generate crds
INFO[0000] Running CRD generator.
INFO[0001] CRD generation complete.

What did you see instead? Under which circumstances?
$ operator-sdk generate crds
INFO[0000] Running CRD generator.
/Users/aguitton/workspace/casskop/casskop/pkg/apis/db/v1alpha1/cassandracluster_types.go:819:33: map values must be a named type, not *ast.StarExpr
FATA[0001] error generating CRDs from APIs in pkg/apis: error generating CRD manifests: error running CRD generator: not all generators ran successfull

Environment

operator-sdk version : v0.15.0
go-version : 0.13

Possible Solution
The operator sdk have a dependency to sigs.k8s.io/controller-tools v0.2.4, which perform the schema validation during the crd generation, this module is the root cause of the error.
To fix this, there is a PR : https://github.com/kubernetes-sigs/controller-tools/pull/317, which is not merged yet. Once the merge will be done, update the dependency should be enough (until it's done we forked the operator-sdk and the controller-tool).

This is a controller-tools issue. We can bump the controller-tools version once this bug is fixed upstream.

@estroz they just released https://github.com/kubernetes-sigs/controller-tools/releases/tag/v0.4.0 which fixes it. Can you bump
It ?

@cscetbon are you looking for this fix for a legacy project or one created with SDK v0.19+?

@estroz for the project in the description 😬

@cscetbon v0.18 is outside our backport policy unfortunately. We could probably backport this to v0.19.

We can upgrade to 0.19 if you backport it. We’re probably not the only ones to have this issue. And in the meantime use that method (will have to try it)


add Mentor kickoff plan

kickoff date

structure of mentors meeting in the begining

how many staff involved for mentors
Q3 plan
links

play-by-play nasa mentors: https://github.com/NASA-Openscapes/NASA-Openscapes.github.io/blob/4f9b39e3453b7128913cfb4932f79eb5f602176c/mentors.qmd#L55
8h/month
@eeholmes

done


docs[confluent]: add docs for new confluent plugin

Description
This is a DRAFT PR that needs fill-in from @silvolu.
Testing instructions
https://konghq.atlassian.net/browse/KAG-5132
Checklist

[ ] Review label added
[ ] Conditional version tags added, if applicable.

Could you help us getting the preview to work @Guaris @fabianrbz ?

Could you help us getting the preview to work

I'll get that set up for you.

@jschmid1 just merged the schema and example for this plugin (based the example on one of your tests, happy to adjust further after): https://github.com/Kong/docs-plugin-toolkit/pull/52
You can rebase this PR and it should build now.

@jschmid1 this plugin is new and available since 3.8.x right?
In that case, you need to update this line to minimum_version: 3.8.x
also, I don't think you need the overrides section in this case given that minium_version is 3.8.x

thanks @fabianrbz pushed a new commit

it doesn't appear here tho @fabianrbz -> https://deploy-preview-7773--kongdocs.netlify.app/hub/kong-inc/confluent/

3.8.x hasn't been released yet, so you'll need to look for the plugin here

@jschmid1 @silvolu do you think this is ready for merging, or is there more info you wanted to add?

I think it's good to go.


dependencies, frameworks, ... for libraries

I was looking for documentation on frameworks+runtimes+dependencies and found this article: http://dotnet.github.io/docs/core-concepts/app-types.html. This topic should also be written for libraries and explain things like:

How to deal with dependencies when creating a library? Do you also need to add "Microsoft.NETCore.App"? Or should dependencies be handled more fine-grained?
What frameworks to use when creating a library? E.g. difference between netstandard1.3, netstandard1.5, netcoreapp1.0.
How to include native dependencies for specific runtimes?
What preprocessor macros are defined to exclude/include code based on the framework (e.g. #ifdef NET451)?

Some of what you're asking is covered in #412.  I haven't included anything about netcoreapp and Microsoft.NETCore.App because those are for app development and not library development.  Although there's nothing stopping you from including Microsoft.NETCore.App as a dependency in your library, it's not recommended.    For a basic "hello world" console app it should work, but once you start incorporating multiple projects there's no guarantee it'll work.

Cool. By native I mean: bundle native dlls and so-files for specific platforms with your managed dlls.

@cartermp I read and reviewed your article. Together with the app-types it covers all my questions except for the native one. Not sure where it fits in the documentation.

Good to hear!  I'll find out what I can about native deps.  If they're part of the scenarios we want to ship for RC2, I'll include them in the doc.

@cartermp all my questions are covered by the article now. thanks

@tmds great!  I'm happy that's the case.  And if something doesn't work right, feel free to yell at me so that it gets updated 😄.


Fixed broken checkbox issue #2290

Fixes #2290
Fixed broken checkbox issue

@nitin10s, Would you please look at my PR?


Pagination ellipsis starts too early (page 3)

See https://godotengine.org/asset-library/asset?page=2
It shouldn't show an ellipsis between 1 and 2. It should be "1 | 2 | 3", and only starting with page 4, "1 | ... | 3 | 4".
When browsing page 1 or 2, they show "1 | 2 | 3" properly.

Yeah, noticed this a few days ago as well


Is it possible to copy an image by using the clipboard

I have try to find a way copy image in js, so I want know why clipboard.js did not support copy image.

I think it's not possible with clipboardjs (atleast for now)

I think it's not possible with clipboardjs (atleast for now)

Clipboard.js only supports string copying. Thanks for @yuyouwen for asking and @shivarajnaidu for answering!


Wildcard CORS does not work

Bug description
The CorsConfiguration type recommends to use ['*'] as the value to all origins. However when I set the wildcard values I continue to get cors issues. Setting the domains manually works fine, but any wildcards in the domain seems not to work at all.
export interface CorsConfiguration {
    /**
     * AllowedOrigins is a list of origins a cross-domain request can be executed from.
     * If the special "*" value is present in the list, all origins will be allowed.
     * An origin may contain a wildcard (*) to replace 0 or more characters
     * (i.e.: http://*.domain.com). Usage of wildcards implies a small performance penalty.
     * Only one wildcard can be used per origin.
     * Default value is ["*"]
     */
    allowedOrigins: ConfigurationVariable[];

How to reproduce

Go to 'wundergraph.config.ts'
Change 'allowedOrigins to ['*']
Run
See error when loading data from any origin

Expected behavior
CORS allows all origins
WunderGraph information
cors: {
    ...cors.allowAll,
    allowedOrigins: ['*']
}

Environment & setup

OS: Windows, deployed to Ubuntu in production

WunderCtl Version
0.94.2

We were trying to replicate this issue on wunderctl 0.100.0, and seems it works fine. Please reopen this issue if you see it again.


New version: Destruct v1.1.1

Registering package: Destruct
Repository: https://github.com/spalato/Destruct.jl
Created by: @spalato
Version: v1.1.1
Commit: 95ba68bc7aab0e271af04eb41c65f9e54c11c70b
Reviewed by: @spalato
Reference: https://github.com/spalato/Destruct.jl/issues/7

Fixed in #21467


(3.1.0) MNU #asString after browse test method

Here's the shot:

here's the stack
stack.txt

reselecting the class and test method allowed me to finally open the method browser

Eric should take a look at the stack and see if there's anything to be gleaned; otherwise, absent a reproduction case or further reports from Dale, this could be closed.

This appears to be a case where the method service class name wasn't set properly. In the time since this bug was reported, improvements were made to ensure the method service in the test browser has the correct class name set before the method list browser is opened.


ANJALI KUMARI DUBEY : Week - 2,3&4 PROJECTS

Submission of Week-2 Projects for frontend development track.

Well done. You are the only person who made the right pr and heard my instructions carefully. Just add the readme which I suggested on tmp-fe-2022 channel on slack

Thank you so much, @siddhi-244 !✨ I have added readme.md in all the projects, so please review it again.

Thank you!!

I have submitted the week-3 projects in this pr only as it was approved but wasn't merged. @siddhi-24 could you please check my week-3 projects and merge this pr containing my week-2 & 3 projects, if everything is fine.

I have submitted the week-3 projects in this pr only as it was approved but wasn't merged. @Siddhi-24 could you please check my week-3 projects and merge this pr containing my week-2 & 3 projects, if everything is fine.

Now, I have submitted my week-4 projects also in this pr as my projects for week-2 were approved but wasn't merged. @siddhi-244 please check my week-3 and 4 projects and merge this pr if everything is fine asap. Thanks!

I have submitted the week-3 projects in this pr only as it was approved but wasn't merged. @Siddhi-24 could you please check my week-3 projects and merge this pr containing my week-2 & 3 projects, if everything is fine.

Now, I have submitted my week-4 projects also in this pr as my projects for week-2 were approved but wasn't merged. @siddhi-244 please check my week-3 and 4 projects and merge this pr if everything is fine asap. Thanks!

I could have merged but I don't have permissions

I have submitted the week-3 projects in this pr only as it was approved but wasn't merged. @Siddhi-24 could you please check my week-3 projects and merge this pr containing my week-2 & 3 projects, if everything is fine.

Now, I have submitted my week-4 projects also in this pr as my projects for week-2 were approved but wasn't merged. @siddhi-244 please check my week-3 and 4 projects and merge this pr if everything is fine asap. Thanks!

I could have merged but I don't have permissions

So, could you please check my week-3 & week-4 projects and if it is fine leave a comment asking the concerned person to merge it. Thanks!


GitHub action scripts

Tests currently run from the integration repository and make use of multiple repos so not sure what this should involve.
This is potentially blocked until the contract is mocked and unit tests can be run in isolation.
-- Note. This is being done with the existing docker images.

Closes #14


Inliner not adding media query CSS to Body tag

How can we reproduce this bug?
I'm using the SASS version of Foundation for Emails, with the boilerplate 'default.html' left as it was upon install. I have created my own 'index.html' with but only used simple Inky markup.
What did you expect to happen?
When running the npm run build command, it's my understanding that all media query CSS should be moved from 'app.css' to the commented out <style> tag in the <body> of 'index.html' (the full HTML email file that then resides in /dist).
What happened instead?
Neither the default media query CSS from the Ink framework nor any of my own custom media query CSS has been placed with the body of 'index.html'. Therefore the email is not responsive.
What email clients does this happen in?
This isn't an issue with an email client - when running the inliner, it simply seems to ignore the media queries.
If I manually add the CSS to 'index.html' the mailer is fully responsive upon testing. However this is not an adequate solution as each time the inliner process is run, my additions are overwritten.

Hi Antony,
I have had a similar problem and I have solved it by reseting the css comment body from index.html. Maybe you changed it by error and now it is not similar to:

That does indeed seem to have fixed it - thank you. Such a small thing!
I thought I'd tried resetting the whole file to match the default template but evidently I missed something.


ACTPCD Embeddings

Hello, first of all thank you for your amazing work and sharing a well structured and documented repo.
I have a question regarding the coordinate embedding implementation for the ACTPCD model:
In forward_pcb_embed here
There is the following code:
        pcd_pos = self.coord_embedding_sine(coord[: offset[0]])
        features = rearrange(
            features,
            "(b n) c -> b c 1 n",
            n=self.pcd_npoints,
        )
        pcd_pos = repeat(
            pcd_pos,
            "n c -> b c 1 n",
            b=features.shape[0],
        )
        return features, pcd_pos

Based on the indexing of the coordinates and the use of the repeat function call on the output pcd_pos, is the intention here to compute the coordinate embedding for the first point cloud in a batch, then use that embedding for the rest of the batch? If that is the case, won't that lead to significant loss of performance for all point clouds in the batch besides index 0?

 Sorry for that.
I used to apply fixed positional embedding based on sampled points' orders, so I just repeated it over batches. Then I realized that applying positional embedding based on coordinates may be a better choice, but I forgot to change the following codes.
Thank you for pointing this out!


Request: apply some adjustments and suggestions from the IDE

This :

            byte magic = getBytes(i, 1)[0];
            if (magic > 0xff) {
                throw new Exception("wrong version magic oops");
            }

A byte can't be larger... The condition is useless.

This:

            while (bytesRead != -1) {
                bytesRead = i.read(cipherChunk);
                if (bytesRead == -1) break;

No reason to check twice. The condition is enough. You can use while(true) instead.

This:

                for (int j = 0; j < cipherChunk.length; j++) {
                    cipherChunk[j] = 0;
                }

You can use this instead:
Arrays.fill(cipherChunk, (byte) 0);

This:

            if (fos != null) {
                fos.close();
            }

It's already not null. Also, it's recommended to close it in the finally-block, or better: using "try(...)" on it, to auto-close it, as if it's in the finally-block.

This:

    public UnApkm(String filein, String fileout) {

On Java, functions are supposed to start with lower-case letter. Meaning:
    public unApkm(String filein, String fileout) {

You can use Kotlin instead :)

Removed in the latest commit
Refactored in the latest commit, the condition in that bit is checked before actually reading any data which is why it was there but have switched it to while ( (bytesRead = i.read(...)) != -1) instead
Fixed!
Fixed also
Ah but it's a constructor and classes start with a capital letter ;)
Pls no

OK
Nice
Good
Great
That's not a recommended thing to do. CTORs should be very minimal, not handling files, let alone having to deal with tons of calculations and take a long time to be created.
There are various alternatives to this. Examples:
a. Singleton, with a function to extract.  Or let all functions be static, as you don't expect anyone to extend from it.
b. A normal class, which has those parameters but requires a call to an additional function to do the extraction.
c. I'm sure there are more solutions but those are the most common that I know.
Haha ok.

Moved into a static function :) https://github.com/souramoo/unapkm/commit/7b59cc3bcc12dffabb923acb870982d666b5fc1a

Thank you.
The CTOR is useless now though. You can make it private to tell whoever that use it : "this is not intended to be used this way" .

Fixed to all three of the above points!
Yep, I was using it mostly to debug the outputs of the crypto byte arrays when putting the whole thing together, have left it in just in case it's useful for anyone else (and me later if I need to debug it again).

I see. Now it has more stuff though:
        FileOutputStream fos = null;

Not used in decryptFile.
        byte[] data = new byte[(int) num];

"num" is already an int.
copyInputStreamToFile - I think you could use try-with, like here:
https://docs.oracle.com/javase/tutorial/essential/exceptions/tryResourceClose.html
Meaning maybe like this:
        try (OutputStream out = new FileOutputStream(file)) {
          // no need to close it. It auto-closes in "finally" for you, even if "finally" isn't written by you
        } catch (Exception e) {
            e.printStackTrace();
        }

Thanks, have fixed the above!

If you wish, you can also apply this:

And it's a common thing to put constants at the top, at least on Java. On Kotlin sadly it's usually at the bottom :(

Have done! :)

Seems all the nice warnings are gone.
Only thing that's left is this one, as you don't really need to initialize it.
int bytesRead = 0;

You could, however, put "final" for each variable, whenever you can. If you used Kotlin, the IDE would have helped you on this. Back in the days of Eclipse, it had such a suggestion for Java, and even did it for you each time you've formatted the code (optional setting).


Fix documentation builds on Read the Docs

Failed :( https://readthedocs.org/projects/stackhpc-kayobe-config/builds/21626351/

Failed :( https://readthedocs.org/projects/stackhpc-kayobe-config/builds/21626351/

Trying again: https://github.com/stackhpc/stackhpc-kayobe-config/pull/584


refactor: rewrite mlmd charm to sidecar pattern

This commit introduces changes that support the refactoring of the charm from podspec to sidecar pattern.
Fixes #71
Manual testing

Build and deploy the charm from this branch
Exec into the container and ensure the /data directory is there and has contents

$ kubectl exec -nmlmd-test mlmd-0 -c mlmd-grpc-server -ti  -- /bin/bash
root@mlmd-0:/# ls /data/
mlmd.db

Ensure the metadata-grpc-service exists and it exposes port 8080

$ kubectl get svc -A | grep metadata-grpc-service
mlmd-test         metadata-grpc-service   ClusterIP   <IP_ADDRESS>   <none>        8080/TCP                 10m

Ensure you can change the port config

$ kubectl get svc -A | grep metadata-grpc-service
mlmd-test         metadata-grpc-service   ClusterIP   <IP_ADDRESS>   <none>        8080/TCP                 10m
$ juju config mlmd port="9090"
$ kubectl get svc -A | grep metadata-grpc-service
mlmd-test         metadata-grpc-service   ClusterIP   <IP_ADDRESS>   <none>        9090/TCP                 11m

Execute an upgrade from mlmd 1.14/stable to the version in this branch

do we know why the integration tests are failing?

because of the relation not being yet implemented in the integrated charms, as explained here, it's not possible for me to test the upgrade with the bundle and exhibit the functionality of mlmd by using pipelines. How can we make sure it is indeed working within Charmed Kubeflow for this case?

because of the relation not being yet implemented in the integrated charms, as explained here, it's not possible for me to test the upgrade with the bundle and exhibit the functionality of mlmd by using pipelines. How can we make sure it is indeed working within Charmed Kubeflow for this case?

About the library - Since this charm broadcasts its relation data, in reality any charm that uses the new library should be able to retrieve the values of Service number and port name. I wouldn't worry too much about it. To make things better, I have added a test case (test_grpc_relation_with_data_when_data_changes) that ensures the relation data is actually updated with the information that a requirer charm would need. At the moment there is a limitation in the unit tests and the test case has to be skipped. I'll file an issue in chisme to track that.
About testing this in a Kubeflow environment - Since this is a metadata GRPC service and we are testing it in our integration tests, do you think we need extra tests in a Kubeflow environment?


Fix $value parameter types in Formatter::normalizeDatetimeValue()

Q
A

Is bugfix?
✔

New feature?
❌

Breaks BC?
❌

Tests pass?
✔

Fixed issues

Thank you.


gui-apps/qtgreet: keyword for ~riscv

Tested on HiFive Unmatched.

Sorry but I can't add new keywords as I don't have access to this hardware.
As mentioned in the README, if a user wants to use this repo for other than amd64 it is better to unmask locally.


Should we enable gnutls?

Is gnutls supposed to be enabled?
Currently nbd/nbd-client.c have:
#include "cliserv.h"

#if HAVE_GNUTLS && !defined(NOTLS)
#include "crypto-gnutls.h"
#endif

and nbd/cliserv.h have:
#define NOTLS

Is this intentional?

Hello,
Yeah, it is intentional, because nbd doesn't support TLS yet.
Thanks,

Thanks for the answer!


Test on all JDKs 8+

@jamsden @jadelkhoury @axelreichwein FYI, can refimpl also build and pass a basic integration test with Jetty (https://github.com/oslc-op/refimpl/pull/26/checks?check_run_id=1581808359#step:5:251) under every JDK after 8:


[release-1.8] Fix inbound TLS v2 settings

This is an automated cherry-pick of #30590

@istio-testing: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-mc-k8s-tests_istio_release-1.8
80088b58e8ae81632b7b81e38aeb6b2e5482b97d
link
/test integ-telemetry-mc-k8s-tests_istio_release-1.8

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Charles rendle/issue563

This PR adds two scripts to be used when stress testing csvcubed along with the setup and cleanup scripts to address ticket #563
The user must have some essential tooling installed which can be found with an installation guide on confluence
Copied from the confluence page, the stress test follows this structure:

Start running a performance monitor in the background
Generate a "maximally complex" CSV file with the number of rows the user has given as a parameter to the bash script.
The inspect command test then runs 1 build command on this CSV file so that a .csv-metadata.json file can be used.
Run the test's designated command 5 times using the results of the preprocess step above as inputs.
The performance monitor records CPU and Memory usage throughout the duration of the test's 5 runs.
A postprocess removes any unwanted resultant files.
Steps 2 - 4 are repeated for the second command
The metrics files are cleaned up and placed into relevant folders.
Finally, the performance monitor is terminated.

The stresstest has currently only been run locally with plans to run via a VM in the future but for now that aspect has been removed from the ticket.
If there is anything which needs further explanation (no doubt..) please get in contact with myself or @nimshi89

Here's a script you can use to set everything up on OS X:
#!/bin/bash

# Script to install jmeter and associated tools necessary for running the stress test on OSX.

brew install jmeter wget

# Install perfmon ServerAgent
SERVER_AGENT_VERSION="2.2.3"
SERVER_AGENT_ID="ServerAgent-$SERVER_AGENT_VERSION"
wget "https://github.com/undera/perfmon-agent/releases/download/$SERVER_AGENT_VERSION/$SERVER_AGENT_ID.zip"
unzip "$SERVER_AGENT_ID.zip"
rm "$SERVER_AGENT_ID.zip"
chmod +x "$SERVER_AGENT_ID/startAgent.sh"
mv "$SERVER_AGENT_ID" /usr/local/share
echo "#\!/bin/bash\n/usr/local/share/$SERVER_AGENT_ID/startAgent.sh \$@" > /usr/local/bin/startAgent.sh
chmod +x /usr/local/bin/startAgent.sh

# Installing perfmon plugin for jmeter
PLUGIN_VERSION="2.1"
PLUGIN_IDENTIFIER="jpgc-perfmon-$PLUGIN_VERSION"

wget "https://jmeter-plugins.org/files/packages/$PLUGIN_IDENTIFIER.zip"
# Add plugin to jmeter installation directory
JMETER_INSTALLATION_DIR="$(brew --prefix jmeter)"
unzip "$PLUGIN_IDENTIFIER.zip" -d "$JMETER_INSTALLATION_DIR/libexec"
rm "$PLUGIN_IDENTIFIER.zip"

Could you include this somewhere in your documentation?

Oh, and add a follow up ticket to make sure we cover the limited RAM/CPU VM testing we wanted to look in to.


[Debug] Update Qt project file to run with debugger UI.

What is the purpose of this pull request (PR)?
Updates the Qt project file so we can run silk-qt with the debugger UI.

utACK

utACK


Adding iree_wait_source_t and cleaning up iree_wait_handle_t.

Wait sources add an abstraction between the platform primitives such
that core code can pass them around. Wait sources can be implemented
with the platform wait handles or with custom types (such as HAL
semaphores) and enable deferred handle creation. In this way we can
pass around the wait sources and only if/when the consumer of them
wants to perform a system wait will we need to materialize the wait
handle.
This also works to move more out from behind the IREE_ENABLE_THREADING
flag: wait handles are not related to threading.

This also works to move more out from behind the IREE_ENABLE_THREADING
flag: wait handles are not related to threading.

Nice, thanks for this :)

(linux x86 swiftshader stuck due to kokoro being kokoro, but asan variant passed and this is mostly NFC as nothing is using wait sources yet so merging)


wal: fix ReleaseLockTo

ReleaseLockTo should not release the lock on the WAL
segment that is right before the given index. When
restarting etcd, etcd needs to read from the WAL segment
that has a smaller index than the snapshot index.
The correct behavior is that ReleaseLockTo releases
the locks w is holding so that w only holds one lock
that has an index smaller than the given index.

@yichengq Fixed. PTAL.

lgtm


adds Mojo support

cc @kevmoo @davenotik
Could we ask one of you to give us a review? We're making this package work both for JS and Mojo. Thanks very much for your review!

If you create a pull request, travis will kick in – which is nice

Moved discussion to https://github.com/firebase/firebase-dart/pull/70

What's the story here? Just curious...

Flutter's firebase plugin got moved into to flutter/plugins and is no longer a fork of firebase/firebase-dart. Since Flutter no longer provides mojo support, this pull request is obsolete.

I figured 😊
From mobile. Sorry for brevity and/or spelling.
On Aug 29, 2017 13:01, "Collin Jackson"<EMAIL_ADDRESS>wrote:
Flutter's firebase plugin got moved into to flutter/plugins and is no
longer a fork of firebase/firebase-dart. Since Flutter no longer provides
mojo support, this pull request is obsolete.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/collinjackson/firebase-dart/pull/1#issuecomment-325782872,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABCig_ceVCs3q5G7haoHoahjT6Fukdhks5sdG4bgaJpZM4HDpXs
.


index.js template typescript support

🚀 Feature Proposal
Option for index.js to customize the file extension.
Motivation
Complementing the typescript support adding an option for the index.ts to be generated would offer direct support for generating all files with .ts file extension.
Example
CLI: Override: --index-template-ext 'ts'
API Override: indexTemplateExt: 'ts'

An alternative naming could be
Example
CLI: Override: --index-ext 'ts'
API Override: indexExt: 'ts'

Generated template has the .ts extension with TypeScript open isn't it? I am sorry, I don't understand the problem.

As described in https://react-svgr.com/docs/options/ typescript is indeed supported by --typescript for the icon files but not the index file. It would be more obvious and better supported if the "index.js" could also be directly generated as "index.ts". The current situation requires additional config for development environments that only include files with typescript file extensions (.ts, .tsx) into compilation for example. Currently I have to generate the icon component index with a separate script because the index file is not generated as typescript.

This would be nice to have stale bot

This would be nice!  Currently, I'm renaming the index.js to index.ts using a shell. 😅

Seems to be gaining traction, should be re-considered?

@gregberge using TypeScript option, the generated index should be index.ts actually it is index.tsx. I make a fix.

It would be nice to have this as an option, as my index contains more than just one export and it is in tsx format. Right now I have to append the mv command to the end of the svgr script