Where does the example docking menu go on a resize to mobile?

Maybe I'm missing something, but with the example page, when I resize it in a desktop browser window, or when I open it on my iPhone... the menu seems to disappear altogether. Can't find it anywhere to be seen.
It seems like maybe there's a missing icon to make a menu appear... or something like that.
To be clear, this observing the main page on http://getskeleton.com/
Is this a bug?

I was just about to post a request for mobile navigation. Is there any progress on this?

If @dhg decides a way he wants it done I'd be happy to PR.

I'd love to see an example for the docking nav you created as well as a responsive menu.

The page freezes when you scroll (Chrome/Android) I guess it's because the page got to big, that's a terribly bad thing for someone considering using Skeleton.

@yedderson it works fine on my device, GS IV.
@matthewgalena agreed

Would be nice to see growing a menu component for skeleton.
@michaelwayman - which value has a "works ok on my device" comment?

I build a Drupal theme (https://www.drupal.org/project/light_skeleton) base on this project and I had to build a menu mobile menu in order to release an MVP theme. You can see a demo of this menu at http://lightskeleton.com/
If you wish to use the css and js for this menu:
Here is the CSS - https://gist.github.com/darol100/dc7e2466f25cd54fad0d
Here is the JS - https://gist.github.com/darol100/113b70533aa5cb358e1a
In order to implement this menu you probably will need to change the html a little bit.
However, I'm not a fan of that menu so I have plans on rebuild that menu for a something more modern. I have open an issue for that at https://www.drupal.org/node/2576703. But even thought I want fix it for my Drupal theme, I think this should be fix at the skeleton project first in order to help improve this project and both projects get a benefit.
My question to the maintainer is going to be.... Would you be willing to add a JS file to your project in order to get a modern simple mobile nav ? @devanandb, is going to be helping me on creating this menu and this is very important for us to know if you are ok adding this JS as part of Skeleton.

Nice theme but the mobile navigation is surely missing something thats needed. Any status? A very simple mobile compatible menu skeleton should suffice

I'm working with Skeleton and noticed this as well. Other than the lack of mobile menu, loving it so far!

Would like to see a responsive navigation as well.

+1

+1

Should have provision for multi level menus..
On Oct 30, 2015 11:32 AM, "Darryl Norris"<EMAIL_ADDRESS>wrote:

I build a Drupal theme (https://www.drupal.org/project/light_skeleton)
base on this project and I had to build a menu mobile menu in order to
release an MVP theme. You can see a demo of this menu at
http://lightskeleton.com/
If you wish to use the css and js for this menu:
Here is the CSS - https://gist.github.com/darol100/dc7e2466f25cd54fad0d
Here is the JS - https://gist.github.com/darol100/113b70533aa5cb358e1a
In order to implement this menu you probably will need to change the html
a little bit.
However, I'm not a fan of that menu so I have plans on rebuild that menu
for a something more modern. I have open an issue for that at
https://www.drupal.org/node/2576703. But even thought I want fix it for
my Drupal theme, I think this should be fix at the skeleton project first
in order to help improve this project and both projects get a benefit.
My question to the maintainer is going to be.... Would you be willing to
add a JS file to your project in order to get a modern simple mobile nav ?
@devanandb https://github.com/devanandb, is going to be helping me on
creating this menu and this is very important for us to know if you are ok
adding this JS as part of Skeleton.
—
Reply to this email directly or view it on GitHub
https://github.com/dhg/Skeleton/issues/219#issuecomment-152436814.

A starting point is to move everything from @media (min-width: 750px)  to the top section of custom.css.  I moved it under .example-screenshot.coming-soon{} and it works with one important caveat - it doesn't wrap to a  second line very well.  I didn't spend time trying to solve it because I only had three items in my menu so it didn't effect how I was going to use it.  If someday I have to, then I'll tackle it and post an update.


Replaces all instances of 'enfeebled 2', 3 and 4 in equipment.db with…

… @UUID[Compendium.pf2e.conditionitems.Enfeebled]{Enfeebled 2}, 3 and 4.

If this PR is wanted I'll do links to the other numbered conditions in equipment.db as well.

Some of these are fine but we only link the first instance of a condition value normally to avoid filling the text with lots of needless links.

Oh, I thought I caught those. I'll fix that so that each numerical value for enfeebled occurs only once as a link in each item.

Go ahead with the other conditions in one PR if you want.


caught TypeError: Failed to resolve module specifier "lit". Relative references must start with either "/", "./", or "../".

caught TypeError: Failed to resolve module specifier "lit". Relative references must start with either "/", "./", or "../".

open examples/button.html


Add command to install latest node version

Hi,
Node versions are coming out pretty often, and finding out which one is it is cumbersome.
Can you add a nodenv install latest that just installs the latest version?

dupe of https://github.com/nodenv/node-build/issues/145


LICENSE ?

Hey, thanks again for the mod. I wanted to tweak it to make leveling and attribute acquisition slower and ended up changing a lot of stuff and published it in a repository.
Since your repository does not have any license and my code is heavily based on yours I just want to make sure you're okay with me copying some of your code :smile_cat:.
Just put a thumbs up or add a license if you want to let me know. Thanks.

Oh yeah, you can do whatever you like with this.  A comment with a link to this repo is appreciated but not required.  I'll add a license file real quick


Simput ContentEditable react conflict

Occurs when pencil on child attribute is clicked and user tries to change the name.

You can fix that by removing any react inside your ./node_modules/**/react*.
You need to just keep the root one.
Seb
On Mon, Feb 15, 2016 at 5:15 PM, TristanWright<EMAIL_ADDRESS>wrote:

[image: screen shot 2016-02-15 at 17 18 52]
https://cloud.githubusercontent.com/assets/13318121/13063674/bcefb990-d407-11e5-8ab1-25b10ddc676b.png
—
Reply to this email directly or view it on GitHub
https://github.com/Kitware/HPCCloud/issues/174.

remove HPCCloud/node_modules/**/react*?

closed with ca0edf3456fc90380048806d894f9cd2156213a4


Fix link to contribution guideline (#10)

This is a minor bugfix for the link to the contribution guideline in the Readme (#10).

Thx!


Will you support the authorization flow?

Hi,
According to the latest OAuth 2 specs, Authorization flow is now recommended for SPAs. Is this something you'd consider supporting? This would include the ability to request authorization codes instead of tokens directly and also the ability to send requests with the 'state' parameter, which is explicitly recommended (https://www.oauth.com/oauth2-servers/single-page-apps/#authorization) for use by the OAuth 2 spec.
"Note that the lack of using a client secret means that using the state parameter is even more important for single-page apps."
As far as I can see, gapi for js does not support the authorization flow (while I can set the response_type parameter to get a code instead of a token, there's no way to set a state param). While I would much prefer to use gapi over calling your endpoints directly, I have no choice but to do so. It seems like the docs haven't been updated and still recommend the implicit flow, when afaik it is deprecated (https://developers.google.com/identity/protocols/oauth2/javascript-implicit-flow)

Thanks for reaching out. This bug tracker is intended to report bugs in the Google API JavaScript Client. This looks like a question regarding auth & identity flows.
For support with Google auth & identity, please ask a question on Stack Overflow under the google-oauth tag (per https://developers.google.com/identity).

actually i see that this is asking about a state param. let me look into it and follow up shortly.


Add docstring for WOQ&LayerWise

Type of Change
documentation
Description
detail description
Expected Behavior & Potential Risk
the expected behavior that triggered by this PR
How has this PR been tested?
how to reproduce the test (including hardware information)
Dependency Change?
any library dependency introduced or removed

@yiliu30 Could you help add the hqq docstring?

@yiliu30 Could you help add the hqq docstring?

Sure, will add it by a separate PR.

Please update the scan path.
https://github.com/intel/neural-compressor/blob/master/.azure-pipelines/scripts/codeScan/pydocstyle/scan_path.txt

@yiliu30 Could you help add the hqq docstring?

Sure, will add it by a separate PR.

Added docstring for hqq at https://github.com/intel/neural-compressor/pull/1937


Formatting issues that come with vscode

Type: Feature Request
When code needs to be preceded by a semicolon because of some conflict issue. A formatting indentation problem occurs

This will report an error on line 17, So I need to Put a semicolon at the end of line 15 or put a semicolon at the head of line 17.
When I choose the second option, with vscode's own formatting, then It's going to look something like this.

How do I fix it
code:
<!DOCTYPE html>
<html lang="en">

<head>
    <meta charset="UTF-8">
    <meta http-equiv="X-UA-Compatible" content="IE=edge">
    <meta name="viewport" content="width=device-width, initial-scale=1.0">
    <title>Document</title>
</head>

<body>
    <script>
        let a = 3
        let b = 6
        console.log(a, b)

            ;[a, b] = [b, a]
        console.log(a, b)
    </script>
</body>

</html>

VS Code version: Code 1.73.0 (8fa188b2b301d36553cbc9ce1b0a146ccb93351f, 2022-11-01T15:34:06.111Z)
OS version: Windows_NT x64 10.0.22621
Modes:
Sandboxed: No

Please do not attach screen captures of source but copy-paste-friendly plain text. Thanks

Please do not attach screen captures of source but copy-paste-friendly plain text. Thanks

Thanks for reminding. I have re-edited it

Hey @jrieken, this issue might need further attention.
@AsukaSoryu0, you can help us out by closing this issue if the problem no longer exists, or adding more information.

@AsukaSoryu0 What extension are using for the actual formatting operation?

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


React hook form implementation doesn't return error on load

Here is a code snipped and screenshot attached, I am using react hook form implementation and when I edit phone number already saved in the system, It does not return error on load.
If I edit that same some then it make input field invalid but still empty message is returning```
export const PhoneInput = ({
  prefix,
  register,
  validation = { phone: true },
  readonly,
  errors,
  onChange,
  control,
}) => {
  return (
    <>
      <Controller
        name="phone"
        control={control}
        rules={{
          required: validation["phone"],
          validate: matchIsValidTel,
          pattern: {
            value: PHONE_REGEX,
            message: "Please enter a valid phone number",
          },
        }}
        render={({ field: { ref, ...field }, fieldState }) => {
          return (
            <MuiTelInput
              {...field}
              inputRef={ref}
              inputProps={{ readOnly: readonly }}
              InputLabelProps={{ shrink: true }}
              error={!!errors.phone}
              forceCallingCode
              focusOnSelectCountry
              preferredCountries={["US"]}
              defaultCountry="US"
              variant="standard"
              {...commonProps("phone", "", "Phone", validation["phone"])}
            />
          );
        }}
      />
      <ErrorInfo errors={errors} name="phone" prefix={prefix} />
    </>
  );
};

Hey !
I'm not sure it's an issue from 'mui-tel-input'. Here, there is no difference with the MUI error prop on a TextField. If the prop is true, then the TextField will be red. That's all. No more logic.
So I think you have to find a solution with React Hook form on your side.

Thanks @viclafouch , I was indeed react hook form issue and I am able to solve it myself.
Thanks for awesome supports. hats off


Unresolvable ambiguous overload for booleans

When writing wrappers for calling raphtory from python (see https://github.com/Raphtory/Raphtory/pull/704) we ran into an issue with ambiguous overloads for our methods that I was unable to resolve.
I can reproduce the issue using three simple java classes:
public class TestType {}

public class TestTypeDerived extends TestType {}

public class OverloadTest {
    public static void test(boolean a, TestType b) {
        String astr = Boolean.valueOf(a).toString();
        System.out.println("boolean called: " + astr);
    }

    public static  void test(Object a, TestType b) {
        System.out.println("object called: " + a.toString());
    }

    public static void main(String args[])
    {

        test(false, new TestTypeDerived());
        test("that", new TestTypeDerived());
    }
}

Calling this from java works as expected and outputs
boolean called: false
object called: that

However, if I try to call the test method from python using JPype the boolean case raises an ambiguous overload error when called with the derived type. Here is the python script I used to test this:
import jpype.imports
from jpype import JClass, JBoolean, JObject
from pathlib import Path

path = [str(Path(__file__).parents[1] / "out/production/JPypeOverloadIssue")]  # set appropriately

if __name__ == "__main__":
    jpype.startJVM(classpath=path)
    from java.lang import Boolean, Object
    test = JClass("OverloadTest")
    test_type = JClass("TestType")()
    test_type_derived = JClass("TestTypeDerived")()
    test.test(True, test_type)  # works
    test.test("that", test_type)  # works
    test.test("that", test_type_derived)  # works
    test.test(JObject(True, Object), test_type_derived)  # works and calls object overload
    test.test(JObject(True, Boolean), test_type_derived)  # ambiguous overload
    test.test(True, test_type_derived)  # ambiguous overload
    test.test(JBoolean(True), test_type_derived)  # ambiguous overload

I would be willing to spend some time to try to fix this issue myself but I would need some pointers as to where to start.

The issue is in the method resolution.   Current JPype uses a simple scheme for resolution when there is no governing rules provided by the Java method overloading.   There is a 4 level resolution for each match (exact, implicit, explicit, and none).  It goes through each overload and gets the matching of each.   Each match is given the lowest overload match.   If two are at the same match level then it decides that is ambiguous.
In this case the "test_type_derived" is forcing the match to implicit so therefore it can't decide if bool or object match regardless of whether the cast is applied or not.  It is true that (exact, implicit) should be better than (implicit, implicit) but we don't have that level of sophistication.   The underlaying issue is that derived should be like exact, but isn't so that we can resolve the cases where multiple inherited objects are used for the overload.
Oddly if you test Java directly the case ```test.test(new java.lang.Boolean(false), test_type_derived)will go toobject``.
The current resolution would be to cast the second argument which ups its match to exact.
     TestType = jpype.JClass("TestType")
     test.test(True, TestType @ test_type_derived)  # ambiguous overload, resolved by cast
     test.test(JBoolean(True), TestType @ test_type_derived)  # ambiguous overload, resolved by cast

There are two methods that we use to resolve this but they are rather crude.  One is written in C and the other is in Java.   Then it probes for a method the first time in Java there is code that generates the list of which overloads mask others.   That is supposed to resolve this by saying test.test(bool, TestType) masks test.test(Object,TestType).  But it were to do so then test.test(java.lang.Boolean, TestType) would go to test.test(bool, TestType) which doesn't match the Java language.  The C method is the 4 types we discussed earlier.   I have debated for a long type whether there should be a 5th level of derived which is better than implicit.
So lets see if adding a 5th level resolves this problem....
test.test(JBoolean(True), test_type_derived)

matches test.test(bool, TestType) with (exact,derived) => derived
matches test.test(Object, TestType) with (implicit,derived) => implicit

So it is unambiguously better to go to the first.
Next.
test.test(java.lang.Boolean(True), test_type_derived)

matches test.test(bool, TestType) with (implicit,derived) => implicit
matches test.test(Object, TestType) with (derived,derived) => derived
So it is unambiguously better to go to the second.

Conclusion, it is fixable with a change to the C API.
technical details
The enum types are located in common/native/include/jp_match.h  so we can add a new level between _implicit and ``_exact```.
The conversion rules are located in common/native/jp_classhints.cpp in JPConversionObject
        virtual JPMatch::Type matches(JPClass *cls, JPMatch &match) override
        {
                JP_TRACE_IN("JPConversionObject::matches");
                JPValue *value = match.getJavaSlot();
                if (value == NULL || match.frame == NULL)
                        return match.type = JPMatch::_none;
                match.conversion = this;
                JPClass *oc = value->getClass();
                if (oc == NULL)
                        return match.type = JPMatch::_none;
                if (oc == cls)
                {
                        // hey, this is me! :)
                        return match.type = JPMatch::_exact;
                }
                bool assignable = match.frame->IsAssignableFrom(oc->getJavaClass(), cls->getJavaClass()) != 0;
                JP_TRACE("assignable", assignable, oc->getCanonicalName(), cls->getCanonicalName());
                match.type = (assignable ? JPMatch::_implicit : JPMatch::_none);  // <== here would need to use the new level

                // This is the one except to the conversion rule patterns.
                // If it is a Java value then we must prevent it from proceeding
                // through the conversion rules even if it was not a match.
                // Thus the return result and the match type differ here.
                return JPMatch::_implicit;
                JP_TRACE_OUT;
        }

Next up is the audit information which is supposed to be able to report the quality of the match to a user which would need to know about the new level.  That would be PyJPClass_canConvertToJava in native/python/pyjp_class.cpp.
And last would be the documentation section under Java conversions is doc/userguide.rst.
We would not need to touch the Java overload list.   For reference it is in native/java/org/jpype/manager/MethodOverload.java.
@marscher It would be good to get your input on this one.   I can fix it with about a ~5 line change by adding a new level to the enum table, changing the object conversion to use, and then updating the auditing logic so that it reports the new level of matching, but I am somewhat worried that this would be a major change in the resolution policy.   It should in principle never make something ambiguous that wasn't before but it is hard for me to see all of the possible interplay that it could have.   The whole logic of method resolution predates me (though I rewrote it to be easier to maintain), I haven't ever changed its rules.  The current rules are as I see it "exact always wins", "use Java overloading list otherwise", else "report ambiguity".  This would add a new dimension to the third case.   It is also unclear if it should be before or after the second rule.

My guess is that if the new rule is the last rule before reporting an ambiguity then it can only resolve an ambiguity and never change an existing resolution as the only outcome that it avoids is error reporting.   If we place it any higher on the list then it could change which method is resolved which we must avoid.  The test cases here can be added to the test bench, but it is hard to think of test cases that would actually prove that every resolution for each number of arguments will work.   To properly test it we would have to hit every combination of [primitives(including all promotions), boxed, string, specific object instance, derived object instance] for 1 to 3 arguments plus variadic methods.   That would be an very large matrix.

@ljeub-pometry I put in a PR to resolve this issue.  You can test it to see if it fixes your problem.   It may take a while to update the test bench before we can include this as changes to the method resolution process have to be thoroughly tested.

to properly test it we would have to hit every combination of [primitives(including all promotions), boxed, string, specific object instance, derived object instance] for 1 to 3 arguments plus variadic methods. That would be an very large matrix.

I think this is what pytest.parameterize is suited for https://docs.pytest.org/en/latest/example/parametrize.html
The problem would be to compute, when an ambiguity is reported.
But I think you made this very clear. Since it is the last rule in the chain, it should not change the existing behaviour. So actually your added tests are sufficient IMO.

Sounds good.  Lets target this for a review then.   I assume that this should bump the minor number to 1.5?

Yes, that is a change demanding for a minor release.

@ljeub-pometry I put in a PR to resolve this issue. You can test it to see if it fixes your problem. It may take a while to update the test bench before we can include this as changes to the method resolution process have to be thoroughly tested.

I can confirm that #1113 indeed solves the issue we were having in Raphtory. If there is anything we can do to help move this along, let me know!


cmd/compile: unexpected error from constraint type inference

What version of Go are you using (go version)?

$ go version
go version go1.18.3 windows/amd64

What did you do?

type BaseT interface {
	Type1 | Type2
}
type BaseType int
type Type1 BaseType
type Type2 BaseType // float64

type ValueT[T BaseT] struct {
	A1 T
}

func NewType1() *ValueT[Type1] {
	r := NewT[Type1]()
	return r
}
func NewType2() *ValueT[Type2] {
	r := NewT[Type2]()
	return r
}

func NewT[TBase BaseT, TVal ValueT[TBase]]() *TVal {
	ret := TVal{}
	return &ret
}
func TestGoType(t *testing.T) {
	r1 := NewType1()
	r2 := NewType2()
	t.Log(r1, r2)
	t.Log(reflect.TypeOf(r1), reflect.TypeOf(r2))
	fooT1(r1.A1)
	fooT2(r2.A1)
}

func fooT1(t1 Type1) {

}
func fooT2(t2 Type2) {

}

What did you expect to see?
Compile success
What did you see instead?
error:
TBase does not match int
TBase does not match int

CC @griesemer
Standalone reproducer:
package p

type BaseT interface {
	Type1 | Type2
}
type BaseType int
type Type1 BaseType
type Type2 BaseType

type ValueT[T BaseT] struct {
	A1 T
}

func NewType1() *ValueT[Type1] {
	r := NewT[Type1]()
	return r
}

func NewT[TInt BaseT, TVal ValueT[TInt]]() *TVal {
	ret := TVal{}
	return &ret
}

foo.go:15:18: TInt does not match int

I'm not good at generics, maybe there is a flaw here. And I find the compiler will be happy with these cases:
Case one based on @RelicOfTesla's code:
type BaseT interface {
	Type1 | Type2
}
type BaseType int
type Type1 BaseType
type Type2 BaseType // float64

type ValueT[T BaseT] struct {
	A1 T
}

func NewType1() *ValueT[Type1] {
	r := NewT[Type1, ValueT[Type1]]()
	return r
}
func NewType2() *ValueT[Type2] {
	r := NewT[Type2, ValueT[Type2]]()  // add `, ValueT[Type2]`
	return r
}

func NewT[TBase BaseT, TVal ValueT[TBase]]() *TVal {
	ret := TVal{}
	return &ret
}
func TestGoType(t *testing.T) {
	r1 := NewType1()
	r2 := NewType2()
	t.Log(r1, r2)
	t.Log(reflect.TypeOf(r1), reflect.TypeOf(r2))
	fooT1(r1.A1)
	fooT2(r2.A1)
}

func fooT1(t1 Type1) {

}
func fooT2(t2 Type2) {

}

Case two based on @ianlancetaylor's code:
package p

type BaseT interface {
	Type1 | Type2
}
type BaseType int
type Type1 BaseType
type Type2 BaseType

type ValueT[T BaseT] struct {
	A1 T
}

func NewType1() *ValueT[Type1] {
	r := NewT[Type1, ValueT[Type1]]()  // add `, ValueT[Type1]`
	return r
}

func NewT[TInt BaseT, TVal ValueT[TInt]]() *TVal {
	ret := TVal{}
	return &ret
}

Case three is modified by me:
package p

type BaseT interface {
	Type1 | Type2
}

type Type1 int
type Type2 int

var _ = NewT[Type1, Type1]()  // add `Type1` or `Type2`

func NewT[TInt, TVal BaseT]() TVal {
	return TVal(0)
}

From the results, it seems that we do not support indirect type deduction TVal now.

Smaller reproducer:
type T1 int
type T2 int // code works if this is changed to, say int8

type G[_ T1 | T2] struct{}

func _() {
	f[T1]()
	f[T2]()
}

func f[P T1 | T2, Q G[P]]() {}

Even smaller reproducer:
type T1 int
type T2 int

func f[P T1 | T2, _ []P]() {}

var _ = f[T1]

This is a bug with constraint type inference: P is assigned the type T1. Constraint type inference kicks in to determine the type of the 2nd type argument (it doesn't matter what it is). In order to proceed, constraint type inference attempts to unify the type argument T1 for P with the (adjusted) core type of P's constraint T1 | T2. That core type is int. But int and T1 cannot be unified (they are different, named types) and we get an (incorrect) error.
If T1 and T2 are defined as (for instance) struct{}, the core type is struct{} and T1 can be unified with struct{}.
If T1 and T2 have different underlying types, no core type exists, and no unification is attempted with the first type parameter and its constraint. Inference proceeds with the 2nd type parameter and the result is []T1 in that case.
So constraint type inference is a bit too aggressive here. This area is notoriously tricky. May not be safe to address at this point in the release cycle (TBD). Thinking.
For the release team: It's safe to kick this down to Go 1.21 if we don't find a safe fix in time. This is not a regression; the bug existed since 1.18. Also, providing all type arguments manually is a safe work-around.
FYI @findleyr

Per discussion with @findleyr, we believe https://go.dev/cl/454655 is almost certainly correct, but there's no rush to fix this for 1.20. Still thinking about possible ramifications.

In the section on constraint type inference, the spec states:

For all type parameters with an adjusted core type, unify the type parameter with that type. If any unification fails, constraint type inference fails.

which is exactly what the implementation is doing. The fix (https://go.dev/cl/454655) does something else:

For all type parameters with an adjusted core type, unify the type parameter with that type. Proceed even if the unification fails.

I believe this new approach is the correct approach (and does fix this issue), but it is in fact a (backward-compatible, I think) spec change. In other words, the current behavior is "correct" per the spec.
Making this a spec change and moving it to 1.21.


MIP37: Static Reserve For Governance

Thanks for adding the paragraph summary, merging to RFC.

Thanks for adding the paragraph summary, merging to RFC.


Add iTerm capability to ssh-manager

Description

This PR aims to bring iTerm to the ssh-manager extension.
Applescript bases on this one:
https://github.com/raycast/script-commands/blob/master/commands/apps/iterm/iterm-run-shell-command.applescript
Closes #2005
Screencast

Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed outside of the metadata folder

I am going to fix the linter issue later today

Could you test @wglassly?

Hi @scopsy 👋
Can you give it a spin and approve? 🙂

Could you test @wglassly?

Good Job!  It works well while the iTerm2  front tab is the local one.  When the remote tab is fronted, an error occurs.

Could you test @wglassly?

Good Job! It works well while the iTerm2 front tab is the local one. When the remote tab is fronted, an error occurs.

The issue you are facing is that you are then trying to ssh to some destination from a remote computer.
It just uses your local session.


install_ddev.sh should insist on not being run as root

Describe the bug
Installation script on linux debian / ubuntu puts the executables under strange permissions. (user 501; group: 50)
Its not a fatal issue, because its works, but can lead to unexpected behaviors, especially when the uid is taken.
To Reproduce
Run curl -LO https://raw.githubusercontent.com/drud/ddev/master/scripts/install_ddev.sh && bash install_ddev.sh
Take a look at the installed files:
$ ls -lah /usr/local/bin/
-rwxr-xr-x 1  501 staff  20M Feb  3 23:02 ddev
-rwxr-xr-x 1  501 staff 4.6M Feb  3 23:46 mkcert

$ ls -lah /tmp/
-rw-r--r-- 1  501 staff  48K Feb  3 23:46 ddev_bash_completion.sh
-rw-r--r-- 1  501 staff 4.9K Feb  3 23:46 ddev_fish_completion.sh
-rw-r--r-- 1 root root   12M Feb  9 19:05 ddev_linux-amd64.v1.16.6.tar.gz
-rw-r--r-- 1  501 staff  29K Feb  3 23:46 ddev_zsh_completion.sh

$ cat /etc/group | grep staff
staff:x:50:

Expected behavior
User & group permission should be owned by root
Version and configuration information (please complete the following information):

Host computer OS and Version: "Kali 2020.3" and "Ubuntu 20.04.2 LTS"

Thanks - Could you please show the output of id -a on the host (on the linux computer)?

$ id -a
uid=0(root) gid=0(root) groups=0(root)

Please don't install (or do anything else with ddev as root). You're in there as the root user. Please use a normal user account.

Thanks for the fast respond.
Performing the steps under a normal user is done correctly.
docker run --rm -t -i kalilinux/kali-rolling /bin/bash
apt update
apt install curl sudo
adduser test
usermod -aG sudo test
su test
cd ~
curl -LO https://raw.githubusercontent.com/drud/ddev/master/scripts/install_ddev.sh && bash install_ddev.sh

test@ec0c7840af0f:~$ ls -la /usr/local/bin/
-rwxr-xr-x 1 test test 19973847 Feb  3 23:02 ddev
-rwxr-xr-x 1 test test     1642 Feb  9 20:55 macos_ddev_nfs_setup.sh
-rwxr-xr-x 1 test test  4816008 Feb  3 23:46 mkcert

Its currently not documented that the ddev should not be installed by a root user. (https://ddev.readthedocs.io/)
Neither does the installation script stop me from doing the installation via root.
Well then, I know now how to proceed further, thanks for the information.
I leave it to you to decide whether to close the case.

I think the script should insist on not being run as root. The NFS setup scripts do,
https://github.com/drud/ddev/blob/3c45945785554cbe7ab0d0b3b1dcbe7282009013/scripts/debian_ubuntu_linux_ddev_nfs_setup.sh#L23-L26
We can just add that to this one.


Remove Appui-layout-react package

Changes

Completely removes everything related to appui-layout-react package and moves its content to appui-react/layout, everything in there is internal, so it has not been added to the barrel.
Testing

Moved all tests from appui-layout-react to appui-react/test/layout as well, ensured that all tests passed (whch required useFakeTimers removal, and refactored an svg import which was causing problem since now the svg-loader component is "active" by default and caused issues with the snapshot system (svg code is now embeded instead of a separate file, akin the PinToggle)
All full-stack-ui tests works as well.

Prereq: https://github.com/iTwin/itwinjs-core/pull/6392


missing CORS header on trustless-gateway.link

trustless-gateway.link can't be used in browser due to missing CORS header.
Repro steps
@sgtpooki created demo at https://codepen.io/SgtPooki/pen/JjxYpZX
Can be reproduced by looking at Network tab in devtools.
Problem
I think the exact problem is that response is missing access-control-allow-origin: *:
$ curl -i "https://trustless-gateway.link/ipfs/QmawceGscqN4o8Y8Fv26UUmB454kn2bnkXV5tEQYc4jBd6" -H "Accept: application/vnd.ipld.raw"
HTTP/2 200
server: openresty
date: Tue, 16 Jan 2024 16:38:28 GMT
content-type: application/vnd.ipld.raw
content-length: 24862
accept-ranges: bytes
access-control-allow-methods: GET
access-control-allow-methods: HEAD
access-control-allow-methods: OPTIONS
cache-control: public, max-age=29030400, immutable
content-disposition: attachment; filename="QmawceGscqN4o8Y8Fv26UUmB454kn2bnkXV5tEQYc4jBd6.bin"; filename*=UTF-8''QmawceGscqN4o8Y8Fv26UUmB454kn2bnkXV5tEQYc4jBd6.bin
etag: "QmawceGscqN4o8Y8Fv26UUmB454kn2bnkXV5tEQYc4jBd6.raw"
vary: Accept-Encoding
x-content-type-options: nosniff
x-ipfs-path: /ipfs/QmawceGscqN4o8Y8Fv26UUmB454kn2bnkXV5tEQYc4jBd6
x-ipfs-roots: QmawceGscqN4o8Y8Fv26UUmB454kn2bnkXV5tEQYc4jBd6
x-ipfs-pop: ipfs-bank4-fr2
timing-allow-origin: *
x-ipfs-datasize: 24862
x-ipfs-lb-pop: gateway-bank2-fr2
x-bfid: 9a831c6b4e1115eac081897c46ace271
strict-transport-security: max-age=31536000; includeSubDomains; preload
x-proxy-cache: MISS

cc @sgtpooki @ns4plabs @2color

@hacdias i wonder if we should make liberal CORS a configuration option in boxo/gateway, so we don't have to set them up every time on public gateways?

Access to fetch at 'https://trustless-gateway.link/ipfs/QmW9pMY7fvbxVA2CaihgxJRzmSv15Re2TABte4HoZdfypo?format=raw' from origin 'https://cdpn.io' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource. If an opaque response serves your needs, set the request's mode to 'no-cors' to fetch the resource with CORS disabled.

@hacdias i wonder if we should make liberal CORS the default in boxo/gateway, so we don't have to set them up every time on public gateways?

@lidel, also, do we have recommended config for trustless gateways in the IPIP or elsewhere? i.e. CORS should allow any origin?

@lidel we already have a function that applies the liberal CORS: https://github.com/ipfs/boxo/blob/main/gateway/gateway.go#L431. If your suggestion is to apply it by default, I would also suggest stopping to export it.
It seems fine to me to change the default, as long as we make it clear.

I assumed we forgot to enable CORS in Rainbow, and it had to be added in Nginx, but I've checked latest Kubo and ghcr.io/ipfs/rainbow:main-latest and both have Access-Control-Allow-Origin: *, so we don't need to change anything in boxo, this seems to be an infra thing.
@ns4plabs any idea why Access-Control-Allow-Origin: * gets dropped on trustless-gateway.link and not ipfs.io?

I'm not sure this is working in Kubo 0.25.0, unless I've misconfigured it.
I have enabled CORS on the API with:
ipfs config --json API.HTTPHeaders.Access-Control-Allow-Origin '["*"]'
ipfs config --json API.HTTPHeaders.Access-Control-Allow-Methods '["GET", "POST"]'

And turned on the routing API on the gateway and enabled CORS with:
ipfs config --json Gateway.ExposeRoutingAPI 'true'
ipfs config --json Gateway.HTTPHeaders.Access-Control-Allow-Origin '["*"]'
ipfs config --json Gateway.HTTPHeaders.Access-Control-Allow-Methods '["GET", "POST"]'

I can make a fetch request to the API from any origin with:
await fetch('http://<IP_ADDRESS>:5101/api/v0/id', { method: 'POST' })
Response { type: 'cors', url: 'http://<IP_ADDRESS>:5101/api/v0/id' ...

But I get errors from the routing api:
await fetch('http://<IP_ADDRESS>:8180/routing/v1/ipns/bafzaajaiaejcbsm3udfhqd6ailaazwtte7543vgezji6ultv43jkdxhd4elgc5wr', { headers: { Accept: 'application/vnd.ipfs.ipns-record' }})
Access to fetch at 'http://<IP_ADDRESS>:8180/routing/v1/ipns/bafzaajaiaejcbsm3udfhqd6ailaazwtte7543vgezji6ultv43jkdxhd4elgc5wr' from origin 'http://<IP_ADDRESS>:5101' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource. If an opaque response serves your needs, set the request's mode to 'no-cors' to fetch the resource with CORS disabled.

@achingbrain that is indeed a bug. The config gateway headers are applied solely to the gateway handler, and to nothing else on that HTTP listener.
@lidel I see two options:

Add a headers option to the routing server handler. More things to pass around in more places.
Remove the HTTPHeaders option from boxo/gateway. The implementer is then responsible for setting up some middleware (< 10 lines) that sets the headers they want. In Kubo this is trivial with the corehttp.Option system.

It is a bug, since /routing/v1 is exposed on gateway port, it should have the same implicit config and user-provided  Gateway.HTTPHeaders applied as /ipfs handler.
I am afraid (2) is not trivial, it has been around for years, entire ecosystem uses these headers for setting custom headers, who knows what we will break for people if we suddenly remove this config.
@hacdias If (1) is tedious, maybe add a middleware handler (example, we would write our own version) that adds implicit headers and CORS from boxo/gateway + adds any user provided configuration from Gateway.HTTPHeaders and put it in front of both /routing/v1 and /ipfs handlers?
This way it is in one place and we don't need to pass anything into the routing handler.

We rolled out https://github.com/protocol/bifrost-infra/pull/2826 and now the Rainbow headers are passed through

I believe we can probably close this now. confirmed that requests are working properly at https://codepen.io/SgtPooki/pen/JjxYpZX

Confirming this is working too. Can be closed @lidel (I don't have permissions)


Fix no error message appears when trying to create an impossible route

Details

The app doesn't give an error when selecting a valid and then impossible waypoints twice. This PR fix it.
Fixed Issues

$ https://github.com/Expensify/App/issues/40934
PROPOSAL: https://github.com/Expensify/App/issues/40934#issuecomment-2120425842
Tests

Same as QA Steps

[x] Verify that no errors appear in the JS console

Offline tests

Same as QA Steps
QA Steps

Press FAB > Submit Expense
Switch to Distance tab
Select San Diego and Hawaiian Garden as the Start and Stop waypoints
Change the Stop from Hawaiian Garden to Hawaii
Verify there is an error above the next button
Open the Stop waypoint again and select the same Hawaii
Verify there is an error above the next button
Verify pressing next won't navigate you to next page

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/Expensify/App/assets/50919443/23ba4af1-791a-4bf9-b7de-534db921cbb5

Android: mWeb Chrome

https://github.com/Expensify/App/assets/50919443/c2b41c11-0f73-4f17-9c45-972d6484e64e

iOS: Native

https://github.com/Expensify/App/assets/50919443/a0b92205-446d-4be7-9616-24ca87ddad13

iOS: mWeb Safari

https://github.com/Expensify/App/assets/50919443/641f2b8f-a696-4d6a-a6c4-e5be0660479d

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/50919443/f7c2f311-ecfe-454d-914b-4eef9311756c

MacOS: Desktop

https://github.com/Expensify/App/assets/50919443/0068d5fb-da0c-46fb-b5a8-a6093d5f5270

Let me know if we should do this:

Optionally, we can ignore the update if the waypoint is the same. We can compare the currentWaypoint with the values

or maybe the current behavior is expected?

🚀 Deployed to staging by https://github.com/chiragsalian in version: 1.4.76-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/Beamanator in version: 1.4.76-7 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Cannot paginate & search multiple datatables

I'm currently using this template in Django. I cannot get the search and pagination to work across multiple datatables however, it only applies to the first instance of the datatable. I have attached a scheenshot for clarity

Can you provide your code to create the DataTable instance?

Sure, here you go:
{% for project in projects %}

 Project:
                      {{project}}

                          Date Created
                          Title
                          Priority
                          Due In
                          Reported By
                          Status

                        {% for issue in issues %}
                        {% if project == issue.project %}

                          {{issue.dateCreated|date:"d/m/y" }}
                          {{issue.title}}

                            {{issue.priority}}
                          {{issue.return_date|timeuntil}}
                          {{issue.user}}

                            {{issue.state}}

                        {% endif %}
                        {% endfor %}

              {% endfor %}

I have tried to remove the the table id but that completely removes the pagention and search. I assumed that since all the tables would have the same id then it would apply to them all (I don't know beforehand how many tables there will be, the number changes dynamically)

You should use different id for each table. If you already have, modify the simple-datatables.js file in these lines:
https://github.com/zuramai/mazer/blob/4fd27737dd9949a84560388f96e645ca2c797dc7/src/assets/js/pages/simple-datatables.js#L1-L3
Create two Datatables with two new simpleDatatables.DataTable and simply change the id based on the tables you made

Thanks for the help!


Added support to update a Customer

Hmm, I'm not totally familiar with this pull requests and forks and so on. But I just pushed a new commit to add support for creation of subscriptions aswell. That push is not supposed in this PR but still it's good if it could be merged aswell.

Thanks for you contribution! Please see my comments then I'll merge.


IE11 Syntax error on arrow function in config

Hello, I have a Nuxt project with @nuxtjs/tailwindcss module.
On IE11 I am getting a syntaxerror on the index page.
It points to webpack:///node_modules/tailwindcss/stubs/defaultConfig.stub.js
    backgroundColor: theme => theme('colors'),

I know arrow functions are not supported by IE11 but I don't get why this part is referred to on the production environment, as this is a devDependency and buildModule and I would expect this code not being loaded at all on the production environment.

Oh wow, I am kinda stupid :(
I just found that I am actually resolving the theme to refer to screen breakpoints in the code
import resolveConfig from 'tailwindcss/resolveConfig';
import tailwindConfig from '~/tailwind.config.js';

const {theme} = resolveConfig(tailwindConfig);

if (window.innerWidth < parseInt(theme.screens.lg)) {
  window.addEventListener('scroll', this.onScroll);
 } else {
   window.removeEventListener('scroll', this.onScroll);
}

Is there a better way to solve this? I would love to keep using the config variables and I thought resolveConfig would handle this. (I am aware TailwindCSS has limited support for IE)

I think you will need to prepare yourself for the future : https://tailwindcss.com/docs/upgrading-to-v2#support-for-ie-11-has-been-dropped 😅

@Atinux so I should use exposeConfig instead of resolveConfig? I don't know how I got to the code of resolveConfig but as it worked for FF, Chrome and Edge I didn't care much untill the client wanted IE11 support
@Geminii Well, I am all about the future as it comes to development, sadly our clients are not. This is really one of the downsides when developing for a broad audience: all the people that think "The internet" means Internet Explorer have to be kinda supported too

Yes @snakemastr
We created exposeConfig so it faster, lighter and IE compatible than resolveConfig of Tailwind

@snakemastr Yes unfortunatly ...
But IE 11 will end to August 17th, 2021 so we can keep hope that the logic of clients will evolve in this direction to migrate to Edge 😀


Cache module imports for the same specifier in different module blocks in the same file

The goal of this PR is to make sure that the two import "./foo.js" declarations in this file import the same module and evaluate it only once (point 2 of https://github.com/tc39/proposal-js-module-blocks/pull/68):
import "./foo.js";
import(module {
  import "./foo.js";
});

Note that we already have this guarantee for
import "./foo.js";
import "./foo.js";

This is done by passing down the top-level Module/Script Record to the inner module blocks, so that the per-Realm cache key becomes (top-level Module/Script Record of the referencing Module/Script Record, specifier) instead of just (referencing Module/Script Record, specifier).
There are some problems with this approach because it makes module blocks non-serializable (because they now transitively contain a reference to a whole Environment Record): I plan to allow hosts to provide their own representation of the top-level Module/Script Record, and in practice HTML will use the file URL. The cache key would thus become (referrer URL, specifier). (if you read the diff, I left a TODO for this)
Hosts can now use this top-level Module/Script Record representation stored on the Module Record to build import.meta.url, so we don't need to attach special [[HostDefined]] data on ModuleBlock objects and I removed the HostInitializeModuleBlock host hook. In practice, HTML will do something like import.meta.url = moduleRecord.[[TopLevelScriptOrModule]].[[URL]].
We might still need to allow hosts to inject some [[HostDefined]] data in the Module Record created when importing module blocks, but that would be a new host hook called by ImportModuleBlockDynamically and not when a ModuleBlock is defined. (if you read the diff, I left a TODO for this)

I'm closing this because I want to pursue a different approach. Since this PR is tightly coupled to the HTML integration, I want to first define exactly how things should behave and then worry about which parts are in 262 and which are in HTML.


Ledvance Smart+ A60 RGBW AC33911

https://www.ledvance.com/consumer/products/smart-home/smart-home-products-with-wifi-technology/smart-lamps-with-wifi-technology/smart-classic-lamps-with-wifi-technology/classic-bulb-shape-with-wifi-technology-c6443?productId=83025
Ledvance_Smartplus-A60-AC33911-RGBW.bin.zip
Dumped with lightleak
Thank you !

Regarding the Tuya OEM API, have a look at this: https://github.com/rospogrigio/localtuya/pull/1131

This has been added as LEDVANCE SmartPlus AC33911 RGBCT Bulb.
That link is interesting, but is not the API we use in cloudcutter, and I'm not going to attempt to implement that as it requires entering credentials, which is never a good idea.  I have however found that if you follow the profile builder instructions, but instead open the LEDVANCE Smart+ Wifi app instead of the Smart Life app, the token it generates is enough to work over the regular API, so it's restricted by the generated token.
We actually had another dump from #229 but I wasn't able to locate the correct LEDVANCE app until now, as it is region locked and I needed to find an alternate source.


ModellingConnectionHandler refresh after creating a new connection

should close #2549
@tpurschke can you review this and tell me if this O.K?

looks simple enough - need to watch in prod environment if the bug is gone now
What do you think about moving the line further down (before Close) so that we also refresh in case of connection updates?

Actualy had it there before moving it because i wasn't sure if it could create problems. Will do...


Make some service abstraction improvements.

I found these things while creating the abstract timers, I have opened up another PR for.
As I said there, I was browsing through the documentation of systemd. I stumbled across some of the configuration keys and their sensible defaults chosen by the package maintainer.
As you see, I have changed the default values of 'restart', 'wantedBy' and the outputs.
The restart thing could come in handy for standalone services, but would not be that useful for timer based services. Sometimes, services are just there to 'run once in a while', because they have a much better API than a file lying in an application folder with no configuration surrounding it and ppl asking: What should I do with this.
The second thing: 'wantedBy'.
There seems to be not such thing as a 'default' here. So I do not get, why you would want to force it onto services. I have removed it, because of that.
The output is pretty much unecessary. Forcing it to syslog might break with the modules default of going into journalctl which is the much better choice with systemd. So, gone it is.
I know, the first two MIGHT introduce breaking changes, but hey, that's what major versions are for ;)
The second thing I have done, was getting rid of logic in a template file. Logic does not belong in a template file. There should be as few ifs or in general logical constructions as possible. The 'array check' of execstart and execstop belongs in the service.pp.
Yeah..that's all :)
I hope you appreciate the help.
Let me hear, what you think.

Ah, I see there are more occurences of logic in the template. I will fix them, too, and come back with this.


use new tmx api

they are such awesome gentlemen its crazy

Low priority since it doesn't really change anything


Updated rendering of the files in web-ui

I have modified a few functions to render PDF and other files in an iframe.

Dharmesh -- please check out the sugested changes. I've added the Download button back and made it configurable whether to link to the console or a direct object link (depending on auditing permissions etc).
There are other ways this can be improved, but I'm conscious of limiting the focus and getting things merged.
In terms of mimetype -- I removed this logic, and I was thinking we could add logic in there that if the GCS object as octet-stream then we can infer the type from the extension.


Update BufferSegment and BufferList

@ahsonkhan @davidfowl @pakrym mostly api change issue; however looks like there is one bug with .First https://github.com/dotnet/corefx/pull/27691

I cherry-picked https://github.com/dotnet/corefxlab/pull/2143/commits/6851d4ba6c08c784199da2c65aa88feed17e09b1 (and modified it a bit) from here into https://github.com/dotnet/corefxlab/pull/2142


ExtractModuleTask should have a proper getter for moduleFile property

This fixes https://github.com/jfrog/build-info/issues/325

Hi @yahavi , any chance you could take a look at this one?

@rpalcolea,
Thanks for a lot for this fix.
It looks though that you haven't joined our contributors community by signing JFrog's CLA. Can you sign it please?

@rpalcolea - disregard my last comment.
I see you signed the CLA already.
Thanks!

Hi @eyalbe4 @yahavi
Thanks again for looking at this
Are there plans to release this soon?

@rpalcolea
Gradle Artifactory plugin 4.15.2 is released.


Re-check case stake more for pool in case have unstake request

Describe the bug
Do not stake more for pool in case have unstake request
To reproduce the behavior
Steps:

Perform unstake a part pooled
After unstaked successfully
Perform stake more

Actual: Do not stake more show error "exists unstake request"

Allow staking more in case has unstaking in nomination pool

Version test: https://file.cdmteck.com/s/4oimk9zDJ8R5Aai/download?path=%2F&files=./upgrade-ui-pr-1465-build-1.0.7-0-2023-05-31T10-41-08UTC.zip
Validation passed for cases:

stake more
stake more in case unstake
stake more in case unstake all

Check with TZERO & DOT token


So many dependencies....

Quite a few of these are really small, and mention that the functionality might already be included by something like lodash... Since we're depending on so many, is it time to make the cut over to use lodash or similar? Also, lodash has modularized packages that might be worthwhile...

propprop -> lodash.property
array-uniq -> lodash.uniq
arrify -> lodash.castarray
etc

If we shrink the number of our dependencies in favor of lodash, then the download size goes up:
$ npm install --save lodash
$ ls node_modules/lodash*
lodash/ 591 files
lodash._baseassign/ 4 files
lodash._basecopy/ 4 files
lodash._baseflatten/ 4 files
lodash._bindcallback/ 4 files
lodash._createassigner/ 4 files
lodash._getnative/ 4 files
lodash._isiterateecall/ 4 files
lodash.assign/ 4 files
lodash.flatten/ 4 files
lodash.isarguments/ 4 files
lodash.isarray/ 4 files
lodash.keys/ 4 files
lodash.noop/ 4 files
lodash.restparam/ 4 files

If we simply switch over to using the lodash module versions of things we are already using (lodash.property, etc), what benefit does that give us? I haven't dug very deep, but at a quick glance, arrify works differently than castArray in how it treats undefined arguments.
So we're trading one metric (dep count) for another (download size), and I don't think either one really matters-- at least not in this scenario. But using small, focused modules that are doing the job we need and nothing more offers a bigger win than the other options at this point, doesn't it?

I'm worried about the bus-factor (seeing as most of these libraries are owned and maintained exclusively by you).

I don't understand how that's relevant?

If you're hit by a bus and there's a problem, we have to actually figure out what to do. More maintainers and more users usually means more coverage in case there's a problem. It also means that people who need to debug a problem have to go look at how arrify works (and how it's different from castArray).
I'm just a smidge worried because creating so many packages hints at a case of NIH syndrome.

Gotcha on the bus part. If you need fixes on the modules and I'm not... available... you can transition to a new one after the appropriate grieving period :)
I only wrote one of the modules which you mentioned above, the other two are @sindresorhus. Small modules is an npm philosophy. This is not NIH syndrome. This is npm and Node.

OK you own only one of the dependencies for all of gcloud-node? I thought it was more when I looked last....

In the case of propprop, I can deprecate that in favor of lodash.property. The modularized releases of lodash weren't available back then. If I have any others, I'll do the same.

No, I own a few (google-auto-auth, gce-images, retry-request, more). I'm just talking about the ones that can be replaced by lodash equivalents.

Would you like me to make anyone owners on the other modules I own? I would gladly drop most of them in the GoogleCloudPlatform org.

I get that Node "does lots of packages" (even though it leads us to do some stuff I can't say I fully agree with -- see http://www.haneycodes.net/npm-left-pad-have-we-forgotten-how-to-program/). My worry is simply that we're taking dependencies on a lot of things rather than a few larger (likely better maintained) things.
I noticed a few patterns when looking through our deps:

There are a lot of packages.
a good chunk of them seem like they're common utility functions, which might be swapped out with a library like lodash.
another chunk of them seem focused on streams, which might be swapped out with a library like mississippi/2
a few of these are google cloud specific, which makes me wonder if maybe those are better owned by GoogleCloudPlatform... not sure if that's the right answer, but maybe.
a lot of these packages (i counted 10 which is about a third) are owned by @stephenplusplus

as always, point out where i have things wrong. im all for languages doing things their own way, but i cant say i understand the 30+ deps where 10+ are utility/stream-focused.... any help you can offer would be appreciated.
stuff to be swapped by (say) lodash

"array-uniq": "^1.0.2",

"arrify": "^1.0.0",

"methmeth": "^1.0.0",

"prop-assign": "^1.0.0",

"propprop": "^0.3.0",

"lodash.flatten": "^4.2.0",

"string-format-obj": "^1.0.0",

stuff to be swapped with (say) mississippi or mississippi2

"concat-stream": "^1.5.0",

"duplexify": "^3.2.0",

"through2": "^2.0.0"

"pumpify": "^1.3.3",

"stream-events": "^1.0.1",

"split-array-stream": "^1.0.0",

stuff that seems googley and might be better owned elsewhere

"gce-images": "^0.2.0",

"gcs-resumable-upload": "^0.7.1",

"google-auto-auth": "^0.2.4",

"google-proto-files": "^0.2.1",

libs owned by stephenplusplus

"hash-stream-validation": "^0.2.1",

"string-format-obj": "^1.0.0",

"methmeth": "^1.0.0",

"prop-assign": "^1.0.0",

"propprop": "^0.3.0",

"gce-images": "^0.2.0",

"gcs-resumable-upload": "^0.7.1",

"google-auto-auth": "^0.2.4",

"google-proto-files": "^0.2.1",

"stream-events": "^1.0.1",

ones that i guess seem ok...

"JSONStream": "^1.0.7",

"async": "^1.4.2",

"create-error-class": "^2.0.1",

"ent": "^2.2.0",

"grpc": "^0.14.1",

"hash-stream-validation": "^0.2.1",

"dns-zonefile": "0.1.18",

"extend": "^3.0.0",

"mime-types": "^2.0.8",

"is": "^3.0.1",

"once": "^1.3.1",

"rgb-hex": "^1.0.0",

"retry-request": "^1.2.3",

"request": "^2.70.0",

"modelo": "^4.2.0",  <- do we use this all the time though?

array-uniq - I'm not opposed to switching to lodash, though I see it as a wasted effort (as stated earlier)
arrify - discussed above; not identical, would rather stick with what we're using.
methmeth - discussed later
prop-assign - discussed later
propprop - discussed later
lodash.flatten
string-format-obj - discussed later

--

hash-stream-validation -> nothing existed like this, so I made it
string-format-obj -> many existed with strange quirks of how you need to use them. If this exists in lodash, I'll gladly replace.
methmeth -> same, didn't see that this exists anywhere. Does lodash have it? Again, I'll glady replace.
prop-assign -> same as above
propprop -> same as above

--

gce-images - happy to move to the org or add owners.
gcs-resumable-upload - same as above.
google-auto-auth - same as above, though google-auth-library is still supposed to receive changes that deprecates this one (#832), so I can't see the org wanting to claim it.
google-proto-files - happy to move to the org or add owners.

--

"modelo": "^4.2.0", <- do we use this all the time though?

We use it where we need multiple inheritance, which Node doesn't support out of the box. A Pub/Sub Subscription is both an EventEmitter and a GrpcServiceObject, for example.
--
I don't want to point out where you're wrong, you're just stating your thoughts. But to respond to your points:

There are a lot of packages.

We have a big library that supports many unique APIs, which is why we have many dependencies. Instead of being a thin layer on top of an HTTP transport, we set out to decorate things so that the user is happier. That carried with it the cost of dependencies.

a good chunk of them seem like they're common utility functions, which might be swapped out with a library like lodash.

I'll need to do a deeper dive into what lodash offers, but it seems like maybe we can replace 2-3 of our dependencies here. I wouldn't say that's worth it, personally. Not sure what the magic number would be that makes me "feel" like it's "worth it"-- maybe 10. I like small, focused modules, so my magic number might be higher than yours.

another chunk of them seem focused on streams, which might be swapped out with a library like mississippi/2

Streams are hard, the number of libraries reflects the number of scenarios, use cases, and problems that need to be solved. Mississippi is just a wrapper around some of them, but not the ones we need.

a few of these are google cloud specific, which makes me wonder if maybe those are better owned by GoogleCloudPlatform... not sure if that's the right answer, but maybe.

As stated above, I'm willing to move repos or add owners to make the concerned parties feel more comfortable.

a lot of these packages (i counted 10 which is about a third) are owned by @stephenplusplus

For the google-themed modules, see above. For the bus factor, I answered that earlier in the thread. For the "NIH syndrome", I addressed that earlier in the thread as well as in this post.

stuff to be swapped with (say) mississippi or mississippi2

"concat-stream": "^1.5.0",
"duplexify": "^3.2.0",
"through2": "^2.0.0"
"pumpify": "^1.3.3",
"stream-events": "^1.0.1",
"split-array-stream": "^1.0.0",

Uhm, mississippi is just a collection of many of those modules. https://github.com/maxogden/mississippi/blob/24ad398bf642bc7a55abf4f1e820aac5e443efcc/index.js

Gotcha -- if we really think we're doing the right thing, then this LGTM. I'll close by EOD unless we get a bit more feedback.

I will close on your behalf, but just re-open if you still wanted to invite anyone to the discussion.

I think the most important part of this discussion is part about the "googley" packages (though maybe not google-auto-auth, per your comment). Either moving them to GoogleCloudPlatform org or adding some Googlers as collaborators works for me. I'd think that the protos (googleapis org) team would be interested in owning/generating google-proto-files.

👍 to everything. I'll start by adding you both to the googley packages and as npm owners.

Done!

google-proto-files
google-auto-auth
gce-images
gcs-resumable-upload


Fix river-9999.ebuild

Current river needs wlroots >=0.14.0 and zig >=0.8.0.
Also, installation complained about missing /usr/etc directory, so I create it with mkdir as an easy fix.

Thanks a lot for the fix and update!


Optional user based secret key

Use JWT_GET_USER_SECRET_KEY only when you actually pass user_id in the payload.
This way you are able to use user-based secret keys and fallback to a default secret key when user is irrelevant.
Also, without this check, you will be getting DoesNotExist error when trying to generate a token for payload without user_id.

@slykar Hey, what about wrapping the call to User.objects.get(...) in try...except catching DoesNotExist errors and re-raising them as jwt.InvalidTokenError or smth?

@sergeynikiforov I'm not sure. What I would like to achieve is to use the default key if user_id is not passed. I wan't to control whether to use user based secret or not when calling jwt_encode_handler.


[Feature] Exclude directories containing file

Is this feature missing in the latest version?

[X] I'm using the latest release

Is your feature request related to a problem? Please describe.
N/A
Describe the solution you'd like?
I use a monorepo to build containers based on file changes. I'd like to get any changes in directories or submodules that contain Dockerfile.windows, so they can be built on Windows runners. Ie changes in any folder that has a file matching **/Dockerfile.windows.
Describe alternatives you've considered?
The files and files_ignore options let me specify individual files, but the parent folder isn't targeted.
Anything else?
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

@pl4nty Can you provide logs or an example of what you mean by "The files and files_ignore options let me specify individual files, but the parent folder isn't targeted." ?

Here's an example directory structure:
* app1
  * Dockerfile.windows
  * app1.js
* app2
  *  Dockerfile
  * app2.js
* app3
  * Dockerfile.windows
  * Dockerfile
  * app3.js

Say I make a commit that changes all three .js files. I'd like to setup tj-actions/changed-files to detect app1 and app3 since their parent folders contain a Dockerfile.windows. Then I can build app1 and app3 on a Windows runner.
I'd also like to detect app2 and app3 since their parent folders contain a Dockerfile. And I would build them on a Linux runner.
This concept could also help monorepos with multiple languages (eg detect package.json to run npm build).

Given the complexity of handling this within this action, I suggest using a third-party Github action or taking a look at using the files_yaml input which lets you specify custom-named filters.

Example
      - name: Get all app1, app2 and app3 files that have changed
        id: changed-files-yaml
        uses: tj-actions/changed-files@v37
        with:
          files_yaml: |
            app1: &shared
              - app3/Dockerfile.windows
            app2:
              - app2/Dockerfile
            app3:
              - *shared

Thanks @jackton1. I'm using something similar at the moment, but was trying to avoid hardcoding directories since I add new directories regularly. I'll have a look for other actions and post here if I find anything

Let me know how it goes. I’ll revisit adding support for this when I have some more time on my hands.


Replace generators with IteratorIterator in custom iterators

Feature Request

Q
A

New Feature
improvement

RFC
no

BC Break
no

Summary
The HydratingIterator and CachingIterator classes use generators to wrap the given traversable. As described in #2092 and fixed in #2100, this can leak memory if the iterator class is destroyed while the generator isn't exhausted completely.
IteratorIterator can be used instead, but since there are some changes to generators with respect to rewind, the change shouldn't be done in a patch release.

What's the status on this @alcaeus !

The status is the same as five years ago, except that I have no recollection of what the issue was 🤦♂
Did you encounter an issue around iterators that needs addressing?

I think we should close this, I'll open a new one if I can reproduce!

No complaints from me 😊


Avoid be_falsey and be_truthy

This PR first fixes Configuration#any_predicate? to return true/false instead of any_predicate.
No spec fail for this change, because all specs on those predicates use be_truthy, like this one which passed even though config.custom_option? used to be a simple alias for config.custom_option and return 'a value'.
Second commit removes all uses of be_truthy and be_falsey except the two for testing the matchers themselves. I believe most of these date from before they were renamed to avoid confusion
Most of these changes are trivial be_truthy => be(true). A non-trivial example is this spec that was not updated now that fail-fast defaults to 1 instead of true.

rspec-rails specs

Yes, the rspec-rails have a few tests for "Configuration adds settings '...'" which now have errors because the predicates now return false/true instead of nil/whatever_value.
IMO these tests should consider that add_setting is not their responsibility (it is rspec-core's) and could simply check that they add_setting was called, or a more basic check that readers/writers exist, not exactly how they behave.

Fixed the spec in RSpec Rails, but it fails there because it depends on master rspec-core that doesn't have this change merged and still returns nil instead of false for global_fixtures?, use_transactional_fixtures?, use_instantiated_fixtures?, rendering_views?, and fixture_path?.

Fixed the spec in RSpec Rails, but it fails there because it depends on master rspec-core that doesn't have this change merged and still returns nil instead of false for global_fixtures?, use_transactional_fixtures?, use_instantiated_fixtures?, rendering_views?, and fixture_path?.

😆 if you want, you could commit an intermediate step with is_falsey and is_truthy that would pass on all versions. I still have a feeling these tests are testing the correctness of an external library.

these tests are testing the correctness of an external library

We prefer to be on the safe side.

I propose to merge this despite underlying rspec-rails failure. That failure is fixed in https://github.com/rspec/rspec-rails/pull/2353
That RSpec Rails PR is red since its specs expect predicate methods to return a boolean. Before this change, they were returning the same value as the reader (which doesn't make much sense to me).


Elastic/Opensearch as vector store

Having elastic/opensearch as a vector store would be useful. Happy to work on a PR if you think it makes sense to have those supported in this proj

@jaylmiller would love that! i've been meaning to look into this for a while now but haven't had the time

Elasticsearch as a vector store actually didn't make too much sense (I'm using Opensearch but wanted to add both for consistency) due to it's limited knn index functionality.


fix: error message width

uses a fixed px value for width of error message to prevent formatting errors when root font-size is changed

Could you post a screenshot before you merge with different screen sizes. One small one regular one big.

Before fix:

After fix:

Can confirm the fix applies across all screen sizes (including mobile).


Reworking the organization and header of the website

Homepage needs to be changed.
Search bar could be at the header of every page on the site for convenient use.
"Foods" link in the header doesn't need to be there.
"About Us"is useless right now, perhaps remove it?
"How it Works" describes the prototype requirements, will it be renovated in our final version or do we remove it?
Add link at the top for login/register

"About Us"is useless right now, perhaps remove it? Replaced "About us" by "login/register"
Removed Food

Added the search bar in "How It Works" page, so it's pretty much in every page.


Insufficient balance error when sending small amount

When I was trying to send 0.0009 BTC to another address my wallet prompted "insufficient funds". Actually, I had 0.015 BTC in my wallet.

Possibly related to: https://github.com/hirosystems/wallet/issues/3661 and #3796
Working to get more details on this case and other cases. I will add it here as I get it.
This case address: https://mempool.space/address/bc1q6rd60efuphvffll4yhxs45w6dkppyxqhc3a8hu
User using Chrome browser/extension
Address has 57 transactions, and several look like Stamp mints. Does the issue have something to do with that?

Another case like this user with 150$ worth of bitcoin in the wallet. unable to send about a fifth of the amount.
I see transactions in the history of this wallet that look like Stamp mints again.

please see #3814 possibly related and examples of affected addresses in there.

@314159265359879 is this still relevant? couldn't reproduce

I am checking with some of the users who were affected by this, I will update here as I get more info.

@314159265359879 Were you able to confirm this is still an issue or should we perhaps close out for now?

@314159265359879 Were you able to confirm this is still an issue or should we perhaps close out for now?

@markmhx I have not been able to confirm with users who were affected by this in the past. I do believe it is safe to close I have not been able to recreate this either and haven't seen new reports for over a month now.
We should consider also closing #3814 as those cases have likely also been resolved with this.


How to release an instance?

Summary
with the below code snippet, the virtual memory used by the application increases 6G in every iteration.
	wasmer.NewConfig()
	engine := wasmer.NewEngine()
	store := wasmer.NewStore(engine)
	module, _ := wasmer.NewModule(store, code)
	importObject := wasmer.NewImportObject()

	for {
		_, e := wasmer.NewInstance(module, importObject)
		if e != nil {
			fmt.Println("failed to create instance:", e.Error())
		}
		var b []byte = make([]byte, 1)
		fmt.Println("hit enter to continue..")
		os.Stdin.Read(b)
	}

Is there a way to release this memory? Thanks

Hello,
That's a good question. I'm not a Go expert, so my answer might be incorrect or incomplete. I would suggest to force the GC to run, which will run the SetFinalizer registered function of the wasmer.Instance, and thus will free the memories, and everything else attached to the Instance.
Thoughts?

Thanks for the suggestion, I've tried a force GC, but it doesn't work, the virtual memory is still there. I also add some logs to the finalizer, and can confirm it is called during the GC.

So, if the Instance is correctly dropped, then everything is alright, and it's up to the Go runtime or the OS to truncate the virtual memory, but it's not super critical, or is it?

Yes, not critical.
But after more investigation, it doesn't look like a Go or OS issue.
if the wasm code is compiled from below wat then everything is ok:
(module
    (func (export "foo")
    )
)

but when it is compiled from the below C code then I can see the issue:
void foo() {
}

The C code is compiled by emcc version 2.0.21 by emcc foo.c -O3 -o foo.wasm -s EXPORTED_FUNCTIONS=_foo --no-entry and my OS version is Ubuntu 20.04.1 LTS.
BTW, I met the same issue in wasmtime.

Can you please share with me the emscripten-generated Wasm module?

Github doesn't allow me to attach a wasm file, so I convert it to wat format:
(module
  (type (;0;) (func (result i32)))
  (type (;1;) (func))
  (type (;2;) (func (param i32)))
  (type (;3;) (func (param i32) (result i32)))
  (func (;0;) (type 1)
    nop)
  (func (;1;) (type 0) (result i32)
    global.get 0)
  (func (;2;) (type 2) (param i32)
    local.get 0
    global.set 0)
  (func (;3;) (type 3) (param i32) (result i32)
    global.get 0
    local.get 0
    i32.sub
    i32.const -16
    i32.and
    local.tee 0
    global.set 0
    local.get 0)
  (func (;4;) (type 0) (result i32)
    i32.const 1024)
  (table (;0;) 2 2 funcref)
  (memory (;0;) 256 256)
  (global (;0;) (mut i32) (i32.const 5243920))
  (export "memory" (memory 0))
  (export "foo" (func 0))
  (export "_initialize" (func 0))
  (export "__indirect_function_table" (table 0))
  (export "__errno_location" (func 4))
  (export "stackSave" (func 1))
  (export "stackRestore" (func 2))
  (export "stackAlloc" (func 3))
  (elem (;0;) (i32.const 1) func 0))
``

Thank you. I'll investigate as soon as I have time. By reading the given wat, nothing pops in my mind for the moment.

In #277, I'm fixing some memory leaks on the Go land. It appears that runtime.SetFinalizer isn't working as expected in all scenarios. See #262 too.

@localvar is your issue soluted by the latest release? i still have this problem


JoErNanO: Watch onlinevisavietnam.org

JoErNanO requests the watch of the watch_keyword onlinevisavietnam\.org. See the Metasmoke search here and the Stack Exchange search here.

onlinevisavietnam\.org has been seen in 4 true positives, 0 false positives, and 0 NAAs.

!!/approve


Installation Failure

System Info
I am trying to set up Falconlite on an ec2 instance. However,  I am not able to install the lib
I tried pip install text-generation and tried with version as well, but, I got below errors.

Information

[ ] Docker
[ ] The CLI directly

Tasks

[X] An officially supported command
[ ] My own modifications

Reproduction

SSH into an EC2 instance with GPU (I am using p3.2x large)
Activate a python environment with python version 3.6 ( my case, 3.6.9)
Try pip install text-generation

Expected behavior
Successful installation of text-generation lib

Python 3.6 has reacher end of life back in 2022:
https://devguide.python.org/versions/
You can still probably install from source though (clone this repo go to client/python and then pip install -e .
Closing for now, feel free to comment if that doesn't work out.

I upgraded to python3.10, and now things are working!


Add end-to-end test for easier refactoring

We are adding an end-to-end test so that we can exercise the gem's
behavior with all parts together (integration). Hopefully this will ease
refactoring in the future.

:+1:

:+1: LGTM


git::items::list recursion_level should be an enum rather than a String

The current API defines the git::items::list::ClientBuilder::recursion_level() function to take an Into<String> parameter:
pub fn recursion_level(self, recursion_level: impl Into<String>) -> Self
// The recursion level of this request. The default is ‘none’, no recursion.

However the operation only takes a fixed set of values:

None
OneLevel
OneLevelPlusNestedEmptyFolders
Full

Should fix up the spec to make this parameter an enum with the set of valid values.
See VersionControlRecursionType

Worth noting that the spec does currently define the parameter as an inline enum:
          {
            "in": "query",
            "name": "recursionLevel",
            "description": "The recursion level of this request. The default is 'none', no recursion.",
            "required": false,
            "type": "string",
            "enum": [
              "none",
              "oneLevel",
              "oneLevelPlusNestedEmptyFolders",
              "full"
            ],
            "x-ms-enum": {
              "name": "VersionControlRecursionType",
              "values": [
                {
                  "value": "none",
                  "description": "Only return the specified item."
                },
                {
                  "value": "oneLevel",
                  "description": "Return the specified item and its direct children."
                },
                {
                  "value": "oneLevelPlusNestedEmptyFolders",
                  "description": "Return the specified item and its direct children, as well as recursive chains of nested child folders that only contain a single folder."
                },
                {
                  "value": "full",
                  "description": "Return specified item and all descendants"
                }
              ]
            }
          },


Crash in vkCreateComputePipelines when layout is VK_NULL_HANDLE

Set PipelineInfo.layout = VK_NULL_HANDLE; and it will crash inside the validation layers on:
    skip |= validate_compute_pipeline(dev_data, pPipeState[i].get());

VkLayer_core_validation.dll!PIPELINE_LAYOUT_NODE::operator=(__that)	C++
VkLayer_core_validation.dll!core_validation::CreateComputePipelines(device, pipelineCache, count, pCreateInfos, pAllocator, pPipelines) Line 4547	C++

pPipeState's size is 0.

SDK <IP_ADDRESS>

This requires continuing past the check in parameter validation, yes?

@RCalocaO, as @chrisforbes pointed out, an error will be generated in Parameter Validation saying something like:

vkCreateComputePipelines: required parameter pCreateInfos[0].layout specified as VK_NULL_HANDLE

The deeper layers rely on PV for just that purpose and do not repeat null checks, so this behavior is by design.


Implement-config

https://github.com/stolostron/backlog/issues/18354

Implement config for gated features consistently.
Cleanse 2.3.z of depricated FeatureGate resource.

/hold

/cc @KevinFCormier

@KevinFCormier I've got a couple of 2.3 loaner clusters in the wings, let me know if you'd like to test this live yourself using one.

/cc @jamestalton

/unhold


missing README.md

This repo is missing a README.md with a brief description of what it logs for a p2pool

Created PR https://github.com/WeebDataHoarder/p2pool-log/pull/6 to have a basic README.me.

Now covered under https://git.gammaspectra.live/P2Pool/p2pool-observer (and has README!)


can't connect to keybase because x509 certificate signed by unknown auth

I cant do anything with keybase right now after the most recent macOS update.
I saw several issues with the same error message but I don't see any easy solution. no firewall or proxy, WFH.
any suggestions?
this is from the gui from the people tab but the cli gives the same certificate error.
Error: ERROR CODE 1601 - API network error: Post "https://api-0.core.keybaseapi.com/_/api/1.0/logdump/send.json": x509: certificate signed by unknown authority in method keybase.1.config.logSend at new RPCError (file:///Applications/Keybase.app/Contents/Resources/app/desktop/dist/main.bundle.js:1:4125048) at convertToRPCError (file:///Applications/Keybase.app/Contents/Resources/app/desktop/dist/main.bundle.js:1:4102243) at convertToError (file:///Applications/Keybase.app/Contents/Resources/app/desktop/dist/main.bundle.js:1:4102334) at file:///Applications/Keybase.app/Contents/Resources/app/desktop/dist/main.bundle.js:1:2473166 at file:///Applications/Keybase.app/Contents/Resources/app/desktop/dist/105.bundle.js:2:215977 at Deferrals._call (file:///Applications/Keybase.app/Contents/Resources/app/desktop/dist/105.bundle.js:2:894539) at file:///Applications/Keybase.app/Contents/Resources/app/desktop/dist/105.bundle.js:2:894731 at trampoline (file:///Applications/Keybase.app/Contents/Resources/app/desktop/dist/105.bundle.js:2:894267) at Deferrals._fulfill (file:///Applications/Keybase.app/Contents/Resources/app/desktop/dist/105.bundle.js:2:894684) at ret (file:///Applications/Keybase.app/Contents/Resources/app/desktop/dist/105.bundle.js:2:893677)
{ "code": 1601, "fields": null, "desc": "API network error: Post \"https://api-0.core.keybaseapi.com/_/api/1.0/logdump/send.json\": x509: certificate signed by unknown authority", "details": "Error code 1601: API_NETWORK_ERROR in method keybase.1.config.logSend" }```

Same error seen here under Linux.
I have a few files I need to pull off of kbfs.  If Zoom isn't going to maintain these servers anymore, they should fix the cert, and issue a shutdown notice.

Keybase had an expired certificate authority and an issue with the auto updater so you’ll need to download and install keybase from https://keybase.io/docs/the_app/install_macos to be able to access keybase again
I see this after updating


found "committed" a misspelling of "comitted"

After upgrading to the latest version earlier today, I think there might be a mistake with the misspelling error: committed should be the correct spelling
+ misspell
./tuf/tuf.go:317:64:found "committed" a misspelling of "comitted"

(code comment here: https://github.com/docker/notary/blob/master/tuf/tuf.go#L317)

hmm, I will look!
thanks for report

should be fixed now.  The problem was caused by conflicting rules for "omit" and "commit"

just verified, thanks for resolving this so quickly! :+1:


Fix the reference to rxjs commonJS library

Since angular 10 when you try to build something with dependency of commonJS library, it's warn you that your application can be  larger slower application because of this. (reference : https://blog.angular.io/version-10-of-angular-now-available-78960babd41#16c4).
To fix this, you need to import ECMAScript module instead if possible.
In rxjs package is just a little different as shown in this PR.
It's fix two issues (#197 #181) .
Also i fixed issue #215 by checking if element is not null.

You mean #215

Yes, correct. I mean #215
When will this be released?

I don't know.
Soon, i hope.
It's waiting to @piotrdz

At the moment, I am working on stabilising v2 branch of the slider, targeting Angular 6 and rxjs 6. This is next on the list. I will need to run a few compatibility checks to see which version it will land in.

Okay, I have just upgraded my project to Angular 9 and it appears the only issue I am having is reported in bug #215, which this change fixes.  Do you have a timeframe?  Is it possible to merge this into the current branch?

@silvl It's done now.
Please have some patience when asking for merge, as I have to check compatibility before pushing the button. My usual pre-merge and pre-release testing is using the component in Angular apps for each of supported Angular versions (5+ for v1).
v2 and the re-brand to ngx-slider is also coming by the end of the week at the latest.


fingerprints.pk

Sorry，where is fingerprints.pk？

Hi, thanks for your interest. Have a look at the example in the README file:
>>> main.main('/path/to/testpics/', sim=0.5)
no fingerprints database /path/to/testpics/fingerprints.pk found

So it is /path/to/testpics/fingerprints.pk.

Thank for your reply, and now I have another issue. How to set the number of cluster in this code?

You do not define the number of clusters beforehand. Instead you choose a value for the similarity index sim=0...1 and thereby define where to cut the dendogram build up by the hierarchical clustering. That gives you the clusters at that level of similarity (sim=0 -> ncluster=1 cluster_size=nimages, sim=1 -> ncluster=nimages cluster_size=1). Note that we don't report single-file clusters, though (imagecluster.make_links()), so with sim close to 1, you may not get any clusters at all, unless you have very similar images.
Thanks for the question, I'll update the docs to make that more clear.

Thank you very much! I got it!


how to support DNA one-hot coding?

Hello, may I ask if we want to use your fastISM package? Does it support DNA one-hot coding as 4*n?

Hi! Yes that's correct, you can send in an input of size batch_size x sequence_length x 4, which should typically be same as model input dimensions.

Thanks Surag. But my model input dimensions is batch_size x 4 x sequence_length, and my input is the same as the input dimension of my model.
tensorflow==2.4.0.  Keras==2.4.3
`mutations = [[1,0,0,0],
[0,1,0,0],
[0,0,1,0],
[0,0,0,1]]
fast_ism_model = fastism.FastISM(model, test_correctness=False)
naive_ism_model = fastism.NaiveISM(model)
fast_ism_out = [fast_ism_model(x, replace_with=mut) for mut in mutations]
naive_ism_out = [naive_ism_model(x, replace_with=mut) for mut in mutations]`
InvalidArgumentError: Invalid reduction dimension (1 for input with 0 dimension(s) [Op:All]

Would it be possible to share your model architecture? Or perhaps the first few layers after the input?

Thanks, this is my model architecture.
Model: "model"

Layer (type)                 Output Shape              Param #
input_1 (InputLayer)         [(None, 4, 3001)]         0

conv1_1 (Conv1D)             (None, 4, 64)             768320

conv1_2 (Conv1D)             (None, 4, 64)             16448

max_pooling1d (MaxPooling1D) (None, 1, 64)             0

dropout (Dropout)            (None, 1, 64)             0

conv2_1 (Conv1D)             (None, 1, 128)            32896

conv2_2 (Conv1D)             (None, 1, 128)            65664

max_pooling1d_1 (MaxPooling1 (None, 1, 128)            0

dropout_1 (Dropout)          (None, 1, 128)            0

conv3_1 (Conv1D)             (None, 1, 128)            65664

conv3_2 (Conv1D)             (None, 1, 128)            65664

max_pooling1d_2 (MaxPooling1 (None, 1, 128)            0

dropout_2 (Dropout)          (None, 1, 128)            0

flatten (Flatten)            (None, 128)               0

dense (Dense)                (None, 128)               16512

activation (Activation)      (None, 128)               0

dropout_3 (Dropout)          (None, 128)               0

dense_1 (Dense)              (None, 2)                 258

activation_1 (Activation)    (None, 2)                 0
Total params: 1,031,426
Trainable params: 1,031,426
Non-trainable params: 0

Thanks. This is my model architecture.
Model: "model"

Layer (type)                 Output Shape              Param #
input_1 (InputLayer)         [(None, 4, 3001)]         0

conv1_1 (Conv1D)             (None, 4, 64)             768320

conv1_2 (Conv1D)             (None, 4, 64)             16448

max_pooling1d (MaxPooling1D) (None, 1, 64)             0

dropout (Dropout)            (None, 1, 64)             0

conv2_1 (Conv1D)             (None, 1, 128)            32896

conv2_2 (Conv1D)             (None, 1, 128)            65664

max_pooling1d_1 (MaxPooling1 (None, 1, 128)            0

dropout_1 (Dropout)          (None, 1, 128)            0

conv3_1 (Conv1D)             (None, 1, 128)            65664

conv3_2 (Conv1D)             (None, 1, 128)            65664

max_pooling1d_2 (MaxPooling1 (None, 1, 128)            0

dropout_2 (Dropout)          (None, 1, 128)            0

flatten (Flatten)            (None, 128)               0

dense (Dense)                (None, 128)               16512

activation (Activation)      (None, 128)               0

dropout_3 (Dropout)          (None, 128)               0

dense_1 (Dense)              (None, 2)                 258

activation_1 (Activation)    (None, 2)                 0
Total params: 1,031,426
Trainable params: 1,031,426
Non-trainable params: 0

It looks like you are applying the convolution along the channels instead of the sequence. For example, your input is of size (None, 4, 3001), but after the first convolution it is (None, 4, 64) and after the second it is also (None, 4, 64). Typically the sequence width only reduces slightly after convolutions, e.g. from 3001->3001 - filter_width + 1.
To correct that it would help to make input of size (None, 3001, 4). You can see here that Conv1D expects channel (4) in the last dimension. Try it out and let me know!

Thanks ! I will re-train my model and try it again.

You can see if it works even before you retrain your model. Good luck!

Sorry to bother you again. I would like to ask if the package does not support Concatenate layer now？
I want to use dilated convolution, so I add the Concatenate layer at the end.
This is my model architecture.
Model: "model"

Layer (type)                    Output Shape         Param #     Connected to
input_1 (InputLayer)            [(None, 3001, 4)]    0

conv1_1 (Conv1D)                (None, 3001, 64)     1600        input_1[0][0]

conv1_2 (Conv1D)                (None, 3001, 64)     24640       conv1_1[0][0]

max_pooling1d (MaxPooling1D)    (None, 500, 64)      0           conv1_2[0][0]

dropout (Dropout)               (None, 500, 64)      0           max_pooling1d[0][0]

conv2_1 (Conv1D)                (None, 500, 128)     49280       dropout[0][0]

conv2_2 (Conv1D)                (None, 500, 128)     98432       conv2_1[0][0]

max_pooling1d_1 (MaxPooling1D)  (None, 83, 128)      0           conv2_2[0][0]

dropout_1 (Dropout)             (None, 83, 128)      0           max_pooling1d_1[0][0]

conv3_1 (Conv1D)                (None, 83, 128)      98432       dropout_1[0][0]

conv3_2 (Conv1D)                (None, 83, 128)      98432       conv3_1[0][0]

max_pooling1d_2 (MaxPooling1D)  (None, 13, 128)      0           conv3_2[0][0]

dropout_2 (Dropout)             (None, 13, 128)      0           max_pooling1d_2[0][0]

conv4_1 (Conv1D)                (None, 13, 64)       24640       dropout_2[0][0]

conv4_2 (Conv1D)                (None, 13, 64)       24640       dropout_2[0][0]

conv4_3 (Conv1D)                (None, 13, 64)       24640       dropout_2[0][0]

concatenate (Concatenate)       (None, 13, 192)      0           conv4_1[0][0]
conv4_2[0][0]
conv4_3[0][0]

flatten (Flatten)               (None, 2496)         0           concatenate[0][0]

dense (Dense)                   (None, 128)          319616      flatten[0][0]

activation (Activation)         (None, 128)          0           dense[0][0]

dropout_3 (Dropout)             (None, 128)          0           activation[0][0]

dense_1 (Dense)                 (None, 2)            258         dropout_3[0][0]

activation_1 (Activation)       (None, 2)            0           dense_1[0][0]

Concatenate is not supported in general for now, but for your model can you try
import fastism
fastism.fast_ism_utils.STOP_LAYERS.add("Concatenate")

and then try
fast_ism_model = fastism.FastISM(model, test_correctness=True)

You can generally

Thanks ! I will try.


Update teams in settings.yml

@lelia @detiber please take a look.
For reference on why the settings look like this: https://github.com/cisco-open/homebrew-tap/pull/33#discussion_r1324559611

FYI @svrnm I believe that if you edit this PR description to something like "Fixes #34" it will automatically close that issue once this PR is merged ✨

ty, I linked both manually for now, but will keep this in mind for future issues&PRs :-)


Describe how to use AutoDeps

Hello,
When one has a tool that produces artifacts, with msbuild and visualstudio one can hook into the process and record implictly the dependencies.
Like dlls whch this file depends on, what files the tool opens during the transformation and potential outputs. This functionality is important in the context of game development for example, during the so called binarization or cook process, when you produce data from binary files with tools, not typical code compilation, also the tools change quite often there,.
How this can be done in shake in a similar way, sort of automatic dependency generation.
All the best.

There is an option to use https://github.com/jacereda/fsatrace with the AutoDeps flag to cmd - which you can turn on globally with shakeCommandOptions. I confess I haven't really tried this mode much, so it is insufficiently documented and insufficiently tested - but it does have some tests and some docs - so I'd be very keen to know your experiences with it.

@ndmitchell I dont get AutoDeps to work on windows with shake from stack lst-12.11
I try to use it when running (python) nose tests to find which files it should re run the tests for.
"report" %> \out -> do
     files <- getDirectoryFiles "" ["//test*.py"]
     need files
     cmd_ AutoDeps (EchoStderr True) (FileStderr out) "python" (["-m", "nose"] ++ file  s)

touching one of the test files works, but they are also needed in the action. touching any files used by the test does not allow a rebuild.
running
./fsatrace r - -- python -m nose

lists the test dependency. so I don't know what I'm doing wrong and why shake don't needes the files it should.