feat(Menu): tweak nav variant + add nav condensed example

Overview

Changes navigation variant to new designs + adds nav condensed example

PR Checklist

[x] Related to designs: biz / gamut
[x] Related to JIRA ticket: gm-451
[x] I have run this code to verify it works
[ ] This PR includes unit tests for the code change

📬Published Alpha Packages:@codecademy/gamut-kit@0.6.15-alpha.e2c4bc.0@codecademy/gamut-labs@28.0.10-alpha.e2c4bc.0@codecademy/gamut@40.3.2-alpha.e2c4bc.0@codecademy/monaco@0.5.12-alpha.e2c4bc.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://618ead9439c997100cff0990--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-kit@0.6.15-alpha.60ce4d.0@codecademy/gamut-labs@28.0.10-alpha.60ce4d.0@codecademy/gamut@40.3.2-alpha.60ce4d.0@codecademy/monaco@0.5.12-alpha.60ce4d.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://618ec5781eb54513e898b5d2--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-kit@0.6.15-alpha.68806b.0@codecademy/gamut-labs@28.0.10-alpha.68806b.0@codecademy/gamut@40.3.2-alpha.68806b.0@codecademy/monaco@0.5.12-alpha.68806b.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://618eeacf9b5a3100a75fe477--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-kit@0.6.15-alpha.661ad2.0@codecademy/gamut-labs@28.0.10-alpha.661ad2.0@codecademy/gamut@40.3.2-alpha.661ad2.0@codecademy/monaco@0.5.12-alpha.661ad2.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://6192e61b8ff0010c5667e28e--gamut-preview.netlify.appDeploy Logs

🚀 Styleguide deploy preview ready!https://619526238f5c562b940d7f19--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-kit@0.6.19-alpha.8bb3bd.0@codecademy/gamut-labs@28.0.14-alpha.8bb3bd.0@codecademy/gamut@40.3.4-alpha.8bb3bd.0@codecademy/monaco@0.5.14-alpha.8bb3bd.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://619c1df04e2f5200816907de--gamut-preview.netlify.appDeploy Logs


Remove Monch from supported systems

Since Monch has been taken out of service, its references in the test cases should be removed. The MonchAcceptance tests, on the other hand, should be kept, since they can be reused (latest example being Fulen).

Most of the tests which include monch have the tag related to monch acceptance. Should monch be removed and keep only the ones dedicated completely to monch?


Parser changes related to on fail check node

Purpose

Describe the problems, issues, or needs driving this feature/fix and include links to related issues.

Fixes #40324
Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

[x] Read the Contributing Guide
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

@DamithaSenevirathne We need to enable the build (Ubuntu build at least) via workflows for this branch.

Checked the testMatchStmtRecoveryInvalidErrorMatchPatterns() failure. New recovery is okay. Let's update the json file.


Add executor thread pool

Currently the client's thread pool is responsible for query execution as well. This limits the number of concurrent clients that we can support without over-comitting to the number of cores and is (potentially?) responsible for some of the performance problems we face with TPCC. Decouple the client thread pool from the execution thread pool by handing over the query plan from the client thread to an executor thread and synchronizing using future-promise constructs.

Performance tests showed that this approach made NOP/empty query execution 1.5x slower. This is because boost threadpool uses mutexes and condition variables to assign tasks from the queue to threads in the pool. Conclusion: We need a custom-made thread pool for query execution.


RN 0.68 and ViewPropTypes deprecation

Hi! 👋
Firstly, thanks for your work on this project! 🙂
Today I used patch-package to patch<EMAIL_ADDRESS>for the project I'm working on.
It is related to version 0.68 of react-native where the ViewPropTypes import was deprecated.
Here is the diff that solved my problem:
diff --git<EMAIL_ADDRESS><EMAIL_ADDRESS>index 610e54d..1daced9 100644
---<EMAIL_ADDRESS>+++<EMAIL_ADDRESS>@@ -1,6 +1,6 @@
 // @flow
 import { type Node, type Element } from 'react';
-import { ViewPropTypes } from 'react-native';
+import { ViewPropTypes } from 'deprecated-react-native-prop-types'

 export type MaskedViewProps = typeof ViewPropTypes &
   $ReadOnly<{|

This issue body was partially generated by patch-package.

Hi,
ViewPropTypes is still present in @react-native-masked-view/masked-view/js/MaskedViewTypes.js

@jakrim may I ask what version of masked-view you're using? It should be fixed in v0.2.7

I'm not sure why the latest version that comes up is not 0.2

the package has been renamed to @react-native-masked-view/masked-view, sorry for the confusion


Remove horizontal scroll bar in chapter 3 mining challenges

It is not important to show a scroll bar here at all. Horizontal scrolling is a really common interaction people are familiar with. As far as communicating to users that the area is scrollable, the standard is simply that some items are cut off and go beyond the screen edge.

Also the content on the right should go all the way to the edge and not be cut off 15px from the browser edge.
If there's insistence that we need a scrollbar, I can come up with a much more subtle one that this big white block.

Hi Christoph.
I was the one who suggested adding the scrollbar back into the challenge. The issue I ran into was when the width of the screen nicely landed and cut off BitRey as a hasher. So it wasn't immediately obvious or clear that I had to scroll horizontally to see BitRey. Here's my comment and screenshot:
https://github.com/saving-satoshi/saving-satoshi/pull/604#issuecomment-1686657637
WDYT? Should we still remove the scroll? Or should we add something different?

Here are two options (in addition to having the option of having nothing), both are pretty common. The first one is a scrollbar, but way more subtle (it can become brighter on hover). The second one is an arrow indicator on the right edge (so you can scroll via mouse or click that indicator and a similar indicator on the left appears once you have scrolled a bit).

I kinda like the first option with the subtler scroll bar.


fix: unlink not working

Summary:
Fix unlink error from this comment: https://github.com/react-native-community/react-native-releases/issues/79#issuecomment-464082880
Test Plan:
Try unlinking any dependency

@ltcaosj - thank you for reporting this issue. We are going to merge it now and release a patch version.

Yeah, interesting 🗡


Investigate file extension workflow requirements

Problem / Motivation
Libero Publisher requires xref links to figure files within the XML coming from a publisher to contain .jpeg file extensions in order to load the content to the site
Proposed solution
Cannot be decided until more investigation happens
Tasks
Production to investigate

[ ] Why .tiff files are currently supplied to Continuum
[ ] What file formats are sent to PMC and other downstream hosts
[ ] What impact it would have on the whole process to add .jpeg to the XML delivered to Libero Publisher
[ ] Talk to other publishers about their workflows when delivering to website hosts VS other downstream and what they need during production and when conversions take place

Clarification needed and assumptions
Technical notes
User interface / Wireframes
@BlueReZZ @thewilkybarkid @GiancarloFusiello @FAtherden-eLife

@Maelplaine I cannot assign this ticket to anyone - it should be assigned to Fred and Me.
Linked to #200
Thanks!

PMC requires .tiff format files
"Uncompressed high-resolution TIFF or EPS files are required for all images."
Examples of crosslink tagging in the system do not include a file type suffix:
eg:
<graphic id="gra2" xlink:href="pnas.1207965110fig01"/>
HighWire:
HWX Specification (tiff format)
Color images – 300 dpi, Gray scale images – 600 dpi, Line art – 1200 dpi

Examples of crosslink tagging in the system do not include a file type suffix:
eg:
<graphic id="gra2" xlink:href="pnas.1207965110fig01"/>

Could just be that the filename doesn't have the extension? Reading https://www.ncbi.nlm.nih.gov/pmc/pmcdoc/tagging-guidelines/article/tags.html#el-graphic it says "The name of the file"; on other elements it's "Include the full filename, including file extension, in the @xlink:href value".
Except:

<related-article>
[...] When specifying a DOI, tag the DOI value in @xlink:href and specify @ext-link-type="doi".

So that's where that came from. Which is crazy, as it's violating the XLink spec?

So that's where that came from. Which is crazy, as it's violating the XLink spec?

I wonder whether it's because a publisher can keep one XML source of truth if they don't add the file extension to figures.
We have to send .tiffs to everyone, or eps...but internal systems then convert them to .jpegs to display on the web.
I wonder why we cannot allow non-file extension figure file references in Libero when every other system we've worked with has not had a problem with this?
Also, publishers will need to output as .tiff probably from production so you won't get input with .jpeg extensions as that's not what Libero is going to get...
You cannot download XML from the PMC site directly, but it would be interesting if someone has access to the corpus via the API to see whether PMC add file extensions to the XML they "process".
I would suggest if you add .jpeg to the XML, this needs to be throwaway XML only for the purpose of the site, which is not then delivered anywhere else or used as the archive version - the "source of truth" needs to be exactly what the publisher sent. This is because the Libero display/internal needs do not match all requirements in a full workflow

Hindawi XML might clarify this a little:
JCNC_6826984_Final_1
It looks like they include various formats of the same image (eps, jpg, svg) in the folder, and refer to it without filename extension (e.g. xlink:href="6826984.fig.002), so that actual file being used is deliberately ambiguous, and the extension is probably picked out depending on how the XML is transformed - presumably in the Hindawi case the eps is used for the PDF, the jpg for online, and SVG is included for archival purposes.


DNS Zone with different name

After doing the creation process (Private Endpoint) the value for the DNS Zone is privatelink.mongocluster.cosmos.azure.com

@gahl-levy
IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@gahl-levy
(second request) IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.

I sent a Teams message to the author today.

@seesharprun - Can you help review the proposed changes in this PR?

This change has been made via a different PR.


Fix variable assignments for use with react-native-web

Summary
In some hooks variables were assigned without the const/let keyword. I'm not sure why this works in a native build, but when used in a browser with react-native-web it does not. The keywords have been added.
Also fixed:

useKeyboard event handler names and removing all four listeners.
useDeviceOrientation useEffect only needs to be run on mount, so empty dependencies array.

Test Plan
What's required for testing (prerequisites)?
Set up a project for the browser using react-native-web.
What are the steps to reproduce (after prerequisites)?
Observe the hooks work fine with the const keywords added.
Compatibility

OS
Implemented

iOS
✅

Android
✅

Any plans to merge this?

Is this still relevant? If yes, would it be possible for someone to clean this up?

Closing since it seems inactive, if this is still a problem we would welcome an updated PR ☺


4.0.0 Needs Updated README

Looks like a pretty significant changeset came in from 3.1.1 -> 4.0.0, but the README doc was not properly updated to indicate the new usage. I'm currently working through what I have to migrate and will submit a PR when I have time, but thought opening an issue was a good start.

Just adding as a reminder because i ran into it today .enableCompression is no longer a property on a WebSocket instance

I also noticed that the url string constructor is no longer available too? Was this intended? I see we now have to pass a URLRequest

Also, the disableSSLCertValidation option is missing and it was useful during development stage

isConnected is also not a property on the socket as well

Self-signed certificate is not working when instance init by:
self.init(request: request, engine: WSEngine(transport: FoundationTransport(), certPinner: certPinner, compressionHandler: compressionHandler))

Should changelog be updated too?
I'm not sure if I should update my projects pod to 4.0 or just leave at 3.1.1.
Thanks

Looks like 4.0 version isn't production-ready. Getting a lot of errors e.g. "POSIXErrorCode: Software caused connection abort". Wouldn't recommend to update from 3.1.1. Waiting for fixes

After solving:

Self signed certificate parameter
connection.state check instead of weboSocket.isConnected
new delegate event switch
everything seems fine
👍

@ergunkocak would you mind posting a code snippet/example for the first two items in the list (self signed and connection.state)? Would be greatly appreciated!

Self signed certificate parameter
self.webSocket = WebSocket(url: encodedURLRequest.url!)

becomes
self.webSocket = WebSocket(request: URLRequest(url: encodedURLRequest.url!), certPinner: FoundationSecurity(allowSelfSigned: true))

connection.state check
public override func send(_ connection: SRConnectionInterface, data: String, connectionData: String, completionHandler block: SRWebSocketStartBlock?) {
    if let socket = webSocket, socket.isConnected {
        socket.write(string: data)
    }

becomes
public override func send(_ connection: SRConnectionInterface, data: String, connectionData: String, completionHandler block: SRWebSocketStartBlock?) {
    if let socket = webSocket, connection.state == .connected {
        socket.write(string: data)
    }

We also ported https://github.com/DyKnow/SignalR-ObjC to Swift so SRConnectionInterface is a part of it

Thanks @ergunkocak!

WebSocketDelegate's callback method's error also changed to Error type form NSError.

After solving:

Self signed certificate parameter
connection.state check instead of weboSocket.isConnected
new delegate event switch
everything seems fine
👍

I need to know how do you that.

Thanks @ergunkocak for answering these questions. I updated the README a bit with some examples of the new API.


[WIP/RFC]  Bootstrap EC2 with Ansible

The purpose is to make user data (#cloud-config) very short and easier to parametrise.
Current version of phase1/aws-ec2-terraform/phase2_implementations/simple-weave-single-master.yaml (as shown in #114) has many lines of bash that install Docker and create systemd units etc.
The idea is to turn it into a two-step version:

install and start Docker
run Ansible through toolbox container

New #cloud-config is included now, and you can see how much simpler it has become.

This is getting better now, the phase separation will be much clearer. The Ansible playbook is custom right now, and some things like config object handling and attribute naming could be improved, but it's looks like a successful PoC now. There only shell script it uses create-pki-containers, and for the rest it leverages systemd units and container images from before, which works quite well, I find. Also, abstracting EC2-specific bits is yet to be done, but it's pretty concise as is.

The idea is to turn it into a two-step version:
install and start Docker
run Ansible through toolbox container

This makes sense to me. So the prefered method of running a "startup script" is use cloud-init in aws?

So the prefered method of running a "startup script" is use cloud-init in aws?

Yes. There isn't a more explicit script, like you have in GCE. The only two alternatives would involve either SSH or pre-baked images.


[Viewer App] Local file stream is not shown in the viewer app when streamed from publisher app

When publisher starts the streaming with the local file, on the viewer app local file stream is not shown.
STEPS:

Open the Publisher App
Add the Local File Streaming Source [Stream Local File]
Go Live
Copy the invite viewers link and open the viewer app
Only the camera source streaming is shown in the viewer app

Int Branch: int-issue-145-multisources
Environment:
OS: macOS Ventura Version 13.1
Browser: Chrome Version 108.0.5359.124 (Official Build) (x86_64)
https://user-images.githubusercontent.com/110803586/214165104-a2b0b237-c683-44f2-a510-197d7f7e72b6.mov

Thank you Vishal, this is a known issue, we will fix it in issue #195


Story: changes needed to maintain default (and former default) stream integrity for inter-stream delta/delete calculations

Blocked by #601 & #602
Some possible requirements, although this is tentative depending on what is required to maintain inter-stream delta/delete integrity as best we can:

Prevent organization owners from deleting streams that are or have been the default stream?
When making a stream a default warn and require acknowledgement that making a stream default should only be done after the stream is complete (contains a full dump). And whatever other warnings make sense.

As noted in an predecessor to this issue, in order to support incremental harvesting streams that have been default need to persist (or at least their contents do) for as long as incremental harvesting is supported.  (OAI lets us limit the time horizon for going back for incremental harvests; from previous discussions with Index Data, it sounds like a reasonable time horizon would be somewhere around six months.)
Also as noted in prior discussion, the API (which includes default stream designation as one of its options) might not easily support a method of warning users about making streams default, as opposed to simply allowing or disallowing it.  If it's possible to check in a timely fashion, we may want to disallow designating default streams in the API that are much smaller than previous defaults.


Getting "Request is missing required authentication credential"

Environment details

OS: CentOS Linux release 7.6.1810
Python version: Python 3.6.4
pip version: pip 18.0 from /home/admin/.pyenv/versions/3.6.4/lib/python3.6/site-packages/pip (python 3.6)
google-api-python-client version:
google-api-python-client==1.7.8
google-auth==1.6.3
google-auth-httplib2==0.0.3
google-auth-oauthlib==0.3.0

Steps to reproduce
Error:- After doing the oauth authorization by getting authorization code and pasting in browser
Authentication successful.
Storing credentials to /home/admin/.credentials/script-python-quickstart.json

 '{\n  "error": {\n    "code": 401,\n    "message": "Request is missing required authentication credential. Expected OAuth 2 access token, login cookie or other valid authentication credential. See https://developers.google.com/identity/sign-in/web/devconsole-project.",\n    "errors": [\n      {\n        "message": "Login Required.",\n        "domain": "global",\n        "reason": "required",\n        "location": "Authorization",\n        "locationType": "header"\n      }\n    ],\n    "status": "UNAUTHENTICATED"\n  }\n}\n'

Code
def get_credentials():
   //Gets valid user credentials from storage.

  //If nothing has been stored, or if the stored credentials are invalid,
  // the OAuth2 flow is completed to obtain the new credentials.

  // Returns:
  //     Credentials, the obtained credential.

   home_dir = os.path.expanduser('~')
   credential_dir = os.path.join(home_dir, '.credentials')
   if not os.path.exists(credential_dir):
       os.makedirs(credential_dir)
   credential_path = os.path.join(credential_dir,
                                  'script-python-quickstart.json')

   store = Storage(credential_path)
   creds = store.get()
   if not creds or creds.invalid:
       flow = client.flow_from_clientsecrets(CLIENT_SECRET_FILE, SCOPES)
       flow.user_agent = APPLICATION_NAME
       if flags:
           creds = tools.run_flow(flow, store, flags)
       else: # Needed only for compatibility with Python 2.6
           creds = tools.run(flow, store)
       print('Storing credentials to ' + credential_path)
   return creds

def main():

 SCRIPT_ID = 'XXXXXXX'
 // Authorize and create a service object.
 creds = get_credentials()
 http = creds.authorize(httplib2.Http())
// using credentials below instead of http due to this error- https://github.com/googleapis/google-api-python-client/issues/628
 service = discovery.build('script', 'v1', credentials=creds)

 fields=[1];
 try:
   request = {'function': 'assignEditUrls',"parameters": [fields[0]]}
   t = time.process_time()

   //Make the API request.
// tried with both requests below with http and without http
 // response = service.scripts().run(body=request,scriptId=SCRIPT_ID).execute(http=http)
   response = service.scripts().run(body=request,scriptId=SCRIPT_ID).execute()

For benefit of others, i have found another piece of code lying among multiple samples on Google api Quickstarts, most of which were not working. I have attached my code for getting credentials from token.json which is also called token pickle in some documentation.
There was a timeout atleast in my case, even before actual execution of the script took place. Primarily the problem is the httplib bundled with googleapiclient, so i have overriden it with latest httplib2 wherever needed. So i made some changes also in googleapiclient and its now working.
httplib2==0.12.1
google-api-python-client==1.7.8
google-auth==1.6.3
google-auth-httplib2==0.0.3
google-auth-oauthlib==0.3.0
Changes in googleapiclient/discovery.py
// Im always overriding discovery_http with httplib2.Http() instead of httplib coming from google
if http is None:
discovery_http = build_http()
else:
discovery_http = http
discovery_http = httplib2.Http()
My Code:-
from googleapiclient.discovery import build
from httplib2 import Http
CLIENT_SECRET_FILE = '/home/admin/client_secret.json'

  store = oauth_file.Storage('/home/admin/token.json')
  creds = store.get()
  if not creds or creds.invalid:
      flow = client.flow_from_clientsecrets(CLIENT_SECRET_FILE, SCOPES)
      creds = tools.run_flow(flow, store)
  service = build('script', 'v1', credentials=creds)

  try:
    request = {'function': 'test','parameters': 'one','devMode': True}
    t = time.process_time()

// Again i use HTTP from httplib2
    **http=creds.authorize(Http())**

    response = service.scripts().run(body=request,scriptId=SCRIPT_ID).**execute(http=http)**
    if 'error' in response:
            error = response['error']['details'][0]
            print("Script error message: {0}".format(error['errorMessage']))

except errors.HttpError as e:
    print(e.content)


Cannot Send Images on Whatsapp

Bug:
I cannot send images on whatsapp after jailbreaking .
Device:
iOS Version: 13.1.3
iOS Device: iPhone XR
unc0ver Version: 4.2.1

Same problem on my iphone Xr ios 13.1.2 unc0ver v4.2.1... can’t send pictures or videos on whatsapp

Duplicate of #1744


Required Fields for the Covax Demo app for WHO

Required Fields for Immunization tracking
General Patient info

[x] 1. Name - The full name of the vaccinated person  - String
[x] 2. Date of birth  - The vaccinated person's date of birth (DOB) if known. If unknown, use assigned DOB for administrative purposes - Date - Complete date, following ISO 8601 (YYYYMMDD or YYYY-MM-DD)
[x] 3. Unique identifier - Unique identifier for the vaccinated person, according to the policies applicable to each country. There can be more than one unique identifier used to link records (e.g. national ID, health ID, immunization information system ID, medical record ID)  - ID
[x] 4. Sex - Documentation of a specific instance of sex information for the vaccinated person.

COVID-19 specific Immunization details

[ ] 1. Vaccine or prophylaxis - Generic description of the vaccine or vaccine sub-type, e.g. COVID-19 mRNA vaccine, HPV vaccine.

COVID-19 vaccine
COVID-19 vaccine inactivated virus
COVID-19 vaccine, live attenuated virus
COVID-19 vaccine, non-replicating viral vector
COVID-19 vaccine, replicating viral vector
COVID-19 vaccine, virus protein subunit
COVID-19 vaccine, virus-like particle (VLP)
COVID-19 vaccine, DNA based
COVID-19 vaccine, RNA based

[ ] 2. Vaccine brand - The brand or trade name used to refer to the vaccine received.
[ ] 3. Vaccine manufacturer - Name of the manufacturer of the vaccine received. e.g. Serum institute of India, AstraZeneca. If the vaccine manufacturer is unknown, the market authorization holder is REQUIRED.
[ ] 4. Vaccine market authorization holder - Name of the market authorization holder of the vaccine received. If the market authorization holder is unknown, the vaccine manufacturer is REQUIRED.
[ ] 5. Vaccine batch number  - Batch number or lot number of vaccine
[ ] 6. Date of vaccination - Date in which the vaccine was provided
[ ] 7. Dose number - Vaccine dose number.
[ ] 8. Total doses - Total expected doses as defined by Member State care plan and immunization programme policies
[ ] 9. Country of vaccination - The country in which the individual has been vaccinated
[ ] 10. Administering centre - The name or identifier of the vaccination facility responsible for providing the vaccination.
[ ] 11. Signature of health worker - REQUIRED for PAPER vaccination certificates that have been filled out with handwriting ONLY.   A printed paper vaccine certificate does not require the handwritten signature of a health worker. The health worker who provided the vaccination or the supervising clinician's hand-written signature.
[ ] 12. Health worker identifier - OPTIONAL for DIGITAL and PAPER vaccination certificates. The unique identifier for the health worker is determined by the member state. There can be more than one unique identifier used. (e.g. system-generated ID, health profession number, cryptographic signature, or any other form of health worker unique identifier). This can be used in lieu of a paper-based signature.
[ ] 13. Disease or agent targeted - Name of disease vaccinated to protect against (such as COVID-19).

COVID-19 Immunization tracking

[ ] 14. Due date of next dose - Date on which the next vaccination should be administered if the next dose is required. - Date	Complete date, following ISO 8601 (YYYYMMDD or YYYY-MM-DD)
[ ] 15. Certificate issuer - The authority or authorized organization that issued the vaccination certificate. String
[ ] 26. Health Certificate Identifier (HCID)  - Unique identifier is used to associate the vaccination status represented in a paper vaccination card to its digital representation(s). ID
[ ] 27. Certificate valid from - Date in which the certificate became valid.   No health or clinical inferences should be made from this date - Date	Complete date, following ISO 8601 (YYYYMMDD or YYYY-MM-DD)
[ ] 528 Certificate valid until - Last date in which the certificate is valid.  No health or clinical inferences should be made from this date.  - Date	Complete date, following ISO 8601 (YYYYMMDD or YYYY-MM-DD)
[ ] 19. Certificate schema version - Version of the core data set and HL7 FHIR Implementation Guide that the certificate is using.  String

SubTasks

[ ] #176
[ ] #195

Base Implementation

Load the StructureDefinition
Create a new Java model

a. Sync Client

New Java class
QA

Server-side

Add Controllers
Add API EndPoints - To post data based on the provided StructureDefinition
Add New Table maybe

Android  FHIRCore
Change the methods in

Save
Retrieve
Status

WHO should have a complete package NPM to also support this and also do the SVC generation Endpoint to retrieve the QR code

Base Implementation
1. Load the provided [StructureDefinition ](https://worldhealthorganization.github.io/ddcc/StructureDefinition-DDCCCoreDataSetPoV.html)

2. Create a new Java model

a. Sync Client

1. New Java class

2. QA

Server-side
1. Add Controllers

2. Add API EndPoints - To post data based on the provided [StructureDefinition ](https://worldhealthorganization.github.io/ddcc/StructureDefinition-DDCCCoreDataSetPoV.html)

3. Add New Table maybe

Android FHIRCore
Change the methods in
1. Save

2. Retrieve

3. Status

WHO should have a complete package NPM to also support this and also do the SVC generation Endpoint to retrieve the QR code

I don't think this is related to the issue here

@ndegwamartin

Next steps

Agree on the contractual agreement
We are currently storing the Immunization resource for a patient using the Immunization resource https://www.hl7.org/fhir/immunization.html
They would like us to adhere to the  shared StructureDefiniton  here https://worldhealthorganization.github.io/ddcc/StructureDefinition-DDCCCoreDataSetPoV.html
We can check and share feedback on any missing field that is not mapped based on the StructureDefiniton i.e The country should be mapped to Location etc.
Have the app generate the following QuestionnaireResponse here https://worldhealthorganization.github.io/ddcc/Bundle-DDCC-TX-SHE-bundle-example-1.json.html for consumption by the SVC server. This could be a button on the patient profile for the fully vaccinated patient and log the QuestionnaireResponse required for this
Let WHO SVC team know if the LOE for 2 weeks is feasible to do this  & Push forward the  demo slotted for this coming Friday


feat: write the first part of the tutorial in English

Background

Continuation of #574
Changelog

Replaced the English tutorial with part 1 of the new one. It should be better than the old one even when only consisting of one part.

This tutorial is no good as well


Improved Unit Testing

Broken Tests are now checked to see if they're passing (they'll "fail" and tell you to move them)
Muted most compiler output while unit testing is running. This removes a ton of bloat from the console output and makes it much more readily apparent which tests are failing
Moved some now-working Broken Tests to Tests

Ike being based as usual

Going to revisit this when I can figure out why Rider isn't letting me debug unit tests.


"Toggle Pomodoro" command not working

SINCE
Last version 0.6.0
PROBLEM
When in the middle of a Pomodoro, the command Toggle Pomodoro doesn't show in the Command Palette.
Akwardly, it's present and working when in the Breaks.
(POSSIBLE) SOLUTION
I'm not that knowledgeable to create a Pull request and fix this problem but I've had a look at the last commits. My best bet is that the problem may be on: "main.ts" line 212 by setting the if condition to this.isInactive(). I guess...

Hello,
What's the exact command you're using ?
Is this Toggle pomo workbench location ?
Thanks


Suggest using npm "version" script to update changelog

Update the readme to mention that the developer can add a "version" script to their npm scripts in package.json to make it so that the npm version command automatically updates the changelog as it also bumps the version and commits+tags the change. As mentioned in the npm version script docs, any files added using git add will be included in the tagged version-bump commit:

Run the version script. These scripts have access to the new version in package.json (so they can incorporate it into file headers in generated files for example). Again, scripts should explicitly add generated files to the commit using git add.

Coverage remained the same at 94.03% when pulling 2d8c37a7cf320cbdf72c8ddc6c04392e8c4a43b3 on bantic:patch-2 into 024990a6ee593e716871e61bf62a7715fa74f629 on conventional-changelog:master.

We're closing this pull request out as this repository has been merged into our conventional-changelog mono-repository.
If you would like to see this change incorporated into conventional-changelog please consider re-opening the pull request against the conventional-changelog mono-repository.


[v5] Explicit spawn

This PR makes spawn more explicit and introduces the following changes:

The external (magical) spawn function and related CapturedState code has been removed
Spawning in initial context now comes from an object passed into initial context:

-import { spawn } from 'xstate';

// ...

-context: () => ({
+context: ({ spawn }) => ({
  ref: spawn(someBehavior)
}),

Spawning in assign actions now comes from the 3rd "meta" argument:

-import { spawn } from 'xstate';

// ...

actions: assign({
- ref: (ctx, e) => {
+ ref: (ctx, e, { spawn }) => {
    return spawn(someBehavior);
  }
})

Spawning actors from string references is now possible:

actions: assign({
  ref: (ctx, e, { spawn }) => {
    return spawn('someBehavior');
  }
}),

// ...

{
  actors: {
    someBehavior: (ctx, e) => /* return a Behavior */
  }
}

Event observables work as before, sending events to the parent:

invoke: {
  src: () => fromEventObservable(() => value$.pipe(map(val => ({ type: 'VAL', val })))),
},
on: {
  VAL: {
    actions: (ctx, e) => { console.log(e.val) }
  }
}

Observables with fromObservable deliver values rather than events:

 invoke: {
-  src: () => fromObservable(() => value$.pipe(map(val => ({ type: 'VAL', val })))),
+  src: () => fromObservable(() => value$),
+  onEmit: {
+    actions: (ctx, e) => { console.log(e.data) }
+  }
 },
-on: {
-  VAL: {
-    actions: (ctx, e) => { console.log(e.val) }
-  }
}

This PR closes STA-1269

Spawning actors from string references is now possible:

actions: assign({
  ref: (ctx, e, { spawn }) => {
    return spawn('someBehavior');
  }
}),

// ...

{
  actors: {
    someBehavior: (ctx, e) => /* return a Behavior */
  }
}

Is there a reason for naming the config object actors instead of behaviors? It only contains behaviors that are used to spawn actors, so I would expect it to be named behaviors. Storing behaviors under an actor key might lead to confusion around behaviors and actors?!

Spawning actors from string references is now possible:

actions: assign({
  ref: (ctx, e, { spawn }) => {
    return spawn('someBehavior');
  }
}),

// ...

{
  actors: {
    someBehavior: (ctx, e) => /* return a Behavior */
  }
}

Is there a reason for naming the config object actors instead of behaviors? It only contains behaviors that are used to spawn actors, so I would expect it to be named behaviors. Storing behaviors under an actor key might lead to confusion around behaviors and actors?!

Good feedback; open to renaming this to behaviors

An additional thing that we've discussed at the meeting was that we could drop the invokePromise etc functions and only support this:
{
  actors: {
    myActor: () => createPromiseBehavior()
  }
}

Let the value in the actor map be a regular, plain-function, factory for a behavior.

Looking forward to seeing this PR being merged! 😃

@Andarist I reworked the actors to do the original thing - send events directly to the parent. It turns out that this was a better approach that avoided the complexity of dealing with observers and implicit observer method calls.
This is also inspired by a relevant approach in Akka with dealing with futures (promises): https://blog.rockthejvm.com/pipe-pattern/
I think you'll appreciate this change 👍

Congratulations!
Could we expect the v5 to be published soon to the xstate@next NPM? :-D

It's already available as @alpha

Awesome, thank you very much for publishing it!


Remove unnecessary ref parameters from String.cs

For some reason, there seems to be some code in String.Split that takes ref parameters, even though they aren't actually assigned to. This PR removes the ref annotations from the methods and their callers.
Related CoreCLR pull request: dotnet/coreclr#3274

Hi @jamesqo, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.
TTYL, DNFBOT;


DocVQA reproduce problem using StructuralLM

I tried to finetune StructuralLM on DocVQA dataset using the released weights, but I only get 76.85 ANLS on the test set.
Can the finetuning code on DocVQA be open-sourced ?

Thanks for the attention.  Actually, we used some optimization techniques the same as layoutlmv2. You can refer to the paper. At the same time, based on the StructuralLM model, we still do some continue pre-training on the DocVQA data, mainly to add 2D-position on the question. This can refer to the method of the champion in the CVPR‘20 challenge. We will consider making this code and model open-source in the future.

Thanks for the attention. Actually, we used some optimization techniques the same as layoutlmv2. You can refer to the paper. At the same time, based on the StructuralLM model, we still do some continue pre-training on the DocVQA data, mainly to add 2D-position on the question. This can refer to the method of the champion in the CVPR‘20 challenge. We will consider making this code and model open-source in the future.

I have the same problem with @Cppowboy, using the released weight can not reach 83.94. Without any trick, how many anls can DocVQA reach?

Thanks for the attention. Actually, we used some optimization techniques the same as layoutlmv2. You can refer to the paper. At the same time, based on the StructuralLM model, we still do some continue pre-training on the DocVQA data, mainly to add 2D-position on the question. This can refer to the method of the champion in the CVPR‘20 challenge. We will consider making this code and model open-source in the future.

I have the same problem with @Cppowboy, using the released weight can not reach 83.94. Without any trick, how many anls can DocVQA reach?

Thanks for the attention. Just using the released weight can reach 78+ ANLS on the test set with some post-processing, which is always used on the data set. As we mentioned above, we will consider making this continue pre-training code and model open-source in the future.

Thanks for the attention. Actually, we used some optimization techniques the same as layoutlmv2. You can refer to the paper. At the same time, based on the StructuralLM model, we still do some continue pre-training on the DocVQA data, mainly to add 2D-position on the question. This can refer to the method of the champion in the CVPR‘20 challenge. We will consider making this code and model open-source in the future.

I have the same problem with @Cppowboy, using the released weight can not reach 83.94. Without any trick, how many anls can DocVQA reach?

Thanks for the attention. Just using the released weight can reach 78+ ANLS on the test set with some post-processing, which is always used on the data set. As we mentioned above, we will consider making this continue pre-training code and model open-source in the future.

thanks

Thanks for the attention. Actually, we used some optimization techniques the same as layoutlmv2. You can refer to the paper. At the same time, based on the StructuralLM model, we still do some continue pre-training on the DocVQA data, mainly to add 2D-position on the question. This can refer to the method of the champion in the CVPR‘20 challenge. We will consider making this code and model open-source in the future.

I have the same problem with @Cppowboy, using the released weight can not reach 83.94. Without any trick, how many anls can DocVQA reach?

Thanks for the attention. Just using the released weight can reach 78+ ANLS on the test set with some post-processing, which is always used on the data set. As we mentioned above, we will consider making this continue pre-training code and model open-source in the future.

Can you briefly introduce the  continue pre-training  and QG？How much benefit can bring for each？

The continue pre-training on the DocVQA set can bring about 2.0+ ANLS. train set and validation set.  QG can bring about 2.4+ANLS. In addition, merge the train set and dev set can also bring 1.8+ANLS. Tips, the results on the test set are greatly affected by the parameters, which may lead to a difference of 1+ANLS

The continue pre-training on the DocVQA set can bring about 2.0+ ANLS. train set and validation set. QG can bring about 2.4+ANLS. In addition, merge the train set and dev set can also bring 1.8+ANLS. Tips, the results on the test set are greatly affected by the parameters, which may lead to a difference of 1+ANLS

How much data is used for the continue pre-training？how much data for QG？

The continue pre-training on the DocVQA set can bring about 2.0+ ANLS. train set and validation set. QG can bring about 2.4+ANLS. In addition, merge the train set and dev set can also bring 1.8+ANLS. Tips, the results on the test set are greatly affected by the parameters, which may lead to a difference of 1+ANLS

How much data is used for the continue pre-training？how much data for QG？

The data for continue pre-training is all the DocVQA data set, and the data for QG is more than one million.

The continue pre-training on the DocVQA set can bring about 2.0+ ANLS. train set and validation set. QG can bring about 2.4+ANLS. In addition, merge the train set and dev set can also bring 1.8+ANLS. Tips, the results on the test set are greatly affected by the parameters, which may lead to a difference of 1+ANLS

How much data is used for the continue pre-training？how much data for QG？

The data for continue pre-training is all the DocVQA data set, and the data for QG is more than one million.

想问下模型83.94结果是否有使用十折


[HUDI-3598] Row Data to Hoodie Record Operator parallelism needs to always be consistent with input operator     for chaining purpose

…o adjust the number of parallelism
Tips

Thank you very much for contributing to Apache Hudi.
Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.

What is the purpose of the pull request
(For example: This pull request adds quick-start document.)
Brief change log
(for example:)

Modify AnnotationLocation checkstyle rule in checkstyle.xml

Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end.
Added HoodieClientWriteTest to verify the change.
Manually verified the change by running a job locally.

Committer checklist

[ ] Has a corresponding JIRA in PR title & commit

[ ] Commit message is descriptive of the change

[ ] CI is green

[ ] Necessary doc changes done or have another open PR

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@wangxianghu
thanks for review, I had fixed the problem you pointed out

@danny0405
in the real product scene，source operator don't use the default parallelism of job. for example,  kafka source will set the parallelism  mapping to partition num. in this case we can't chain the source operator with map function.that's why we need the config.

@danny0405
in the real product scene，source operator don't use the default parallelism of job. for example,  kafka source will set the parallelism  mapping to partition num. in this case we can't chain the source operator with map function.that's why we need the config.

@danny0405 in the real product scene，source operator don't use the default parallelism of job. for example, kafka source will set the parallelism mapping to partition num. in this case we can't chain the source operator with map function.that's why we need the config.

The more proper way is using the source/input parallelism so that the options can be avoided.

@wangxianghu thanks for review, I had fixed the problem you pointed out

Thanks @JerryYue-M, I am ok with the change.
will merge as long as  @danny0405 approve it

@danny0405 in the real product scene，source operator don't use the default parallelism of job. for example, kafka source will set the parallelism mapping to partition num. in this case we can't chain the source operator with map function.that's why we need the config.

The more proper way is using the source/input parallelism so that the options can be avoided.

This could be a better way, avoid introducing new options.

@danny0405 @wangxianghu
indeed, i will follow this way
thanks all

@hudi-bot run azure

@JerryYue-M could you rebase this PR on the latest master?  The CI failure is due to clustering failure which has been fixed on the latest master.  Once CI passes, the PR is ready for merging.

@yihua I would just merge it because this change is trivial.


Async traits implementation from nightly

This crate currently uses the async_trait crate to support async functions in traits.
My understanding of async is not very deep but I wonder if it would be possible to use the implementation that is available on nightly instead? (see https://blog.rust-lang.org/inside-rust/2022/11/17/async-fn-in-trait-nightly.html)

This is indeed posiible. However the async fn in trait RFC is still in early development and not stablized yet, so I think it more appropriate to add a feature gate to do so.

Working on this.

I released 0.2.9 which add async fn in traits support. For compatibilty reason, a AFIT flag is used to indicate an native async fn in traits. So the api is like the following:
#[maybe_async::maybe_async(AFIT)]
trait A {
    async fn async_fn_in_trait() -> Result<(), ()>;
}

struct Foo;

#[maybe_async::maybe_async(AFIT)]
impl A for Foo {
    async fn async_fn_in_trait() -> Result<(), ()> {
        Ok(())
    }
}

It will become the default in the future major release, but not for now.

Close as solved in 0.2.9.


Cross-origin image load denied by Cross-Origin Resource Sharing policy.

While using html2canvas in Chrome, function methods.loadImage crashes after img.crossOrigin="anonymous" and img.src=src

Those following this issue may also want to follow #509.


How do I log the result of wall_clock_breakdown from all ranks?

Hi!
I'm trying out the pipeline parallelism example in microsoft/DeepSpeedExamples here on DeepSpeed commit ebed51df787579b8b3f836bb155ce0bf97f4ab66.
I turned on wall_clock_breakdown in ds_config.json and have four pipeline stages across four A40 GPUs. Training runs well.
However, I was wondering if there's an option to have all four pipeline stages report their time breakdowns. This is an excerpt of the output I'm currently getting, which looks like only rank 0 is reporting the computation & communication time for its own stage (i.e. first stage of the pipeline):
steps: 20 loss: 4.6178 iter time (s): 0.994 samples/sec: 257.601
[2022-08-25 02:58:04,341] [INFO] [logging.py:68:log_dist] [Rank 0] rank=0 time (ms) | pipe_send_output: 41.71 | pipe_recv_grad: 1725.64
[2022-08-25 02:58:13,587] [INFO] [logging.py:68:log_dist] [Rank 0] step=30, skipped=0, lr=[0.001], mom=[[0.9, 0.999]]
[2022-08-25 02:58:14,298] [INFO] [logging.py:68:log_dist] [Rank 0] rank=0 time (ms) | batch_input: 209.59 | forward_microstep: 2785.85 | backward_microstep: 5153.22 | backward_inner_microstep: 5153.13 | backward_allreduce_microstep: 0.00 | step_microstep: 12.50
[2022-08-25 02:58:14,299] [INFO] [logging.py:68:log_dist] [Rank 0] rank=0 time (ms) | forward: 2785.85 | backward: 5153.18 | backward_inner: 5153.08 | backward_allreduce: 0.00 | step: 12.50
steps: 30 loss: 5.8922 iter time (s): 0.995 samples/sec: 257.271
[2022-08-25 02:58:14,300] [INFO] [logging.py:68:log_dist] [Rank 0] rank=0 time (ms) | pipe_send_output: 41.68 | pipe_recv_grad: 1725.21
[2022-08-25 02:58:23,540] [INFO] [logging.py:68:log_dist] [Rank 0] step=40, skipped=0, lr=[0.001], mom=[[0.9, 0.999]]
[2022-08-25 02:58:24,251] [INFO] [logging.py:68:log_dist] [Rank 0] rank=0 time (ms) | batch_input: 204.02 | forward_microstep: 2786.27 | backward_microstep: 5153.85 | backward_inner_microstep: 5153.75 | backward_allreduce_microstep: 0.00 | step_microstep: 12.51
[2022-08-25 02:58:24,252] [INFO] [logging.py:68:log_dist] [Rank 0] rank=0 time (ms) | forward: 2786.28 | backward: 5153.80 | backward_inner: 5153.71 | backward_allreduce: 0.00 | step: 12.51

Thanks a lot.

Thanks for looking into this.
I think it's not too trivial to do this nicely because the semantics of distributed training matters. That is, when doing pure data parallel training (which is what DeepSpeed and ZeRO are originally for), the wall clock breakdowns across every rank are going to be similar by design and printing out information from all ranks is just going to confuse people. I suppose this is why all-rank wall clock breakdown is currently not supported. In contrast, while doing pipeline parallel training, each rank is doing different computation, and measurements from different ranks may have differences. Plus, data parallel and pipeline parallel can be combined, so even when pipeline parallel is active, it doesn't make sense to log from all ranks. Only the ranks that have DP rank zero (i.e., one rank per pipeline parallel stage) should print, for example.
Also some thoughts in bullets:

All-rank wall clock breakdown should be an off-by-default feature since it's going to lead to an explosion of logging outputs.
How can we aggregate all wall clock breakdown information across multiple nodes? Do we want to even support that?
Maybe you can utilize deepspeed.runtime.pipe.topology.ProcessTopology to pick out global ranks that have DP rank 0 and only print out info in those ranks.


Support iPhone 13 series, iPad mini (6th), iPad (9th)

Support iPhone 13, iPhone 13 mini, iPhone 13 Pro, iPhone 13 Pro Max, iPad mini (6th generation), and iPad (9th generation)

https://github.com/dannycabrera/Get-iOS-Model/issues/29


Clarify the principles that guide Jupyter Media Strategy Group when accepting a post

We discussed this concept on Nov 5th, 2024.
We should develop a set of principals that empower the JMS to make decisions without always coming to the EC for final decision.

FYI, the 2023 JupyterCon CFP might be a useful reference or comparison point: https://cfp.jupytercon.com/2023/cfp


Deployment of iRODS at NCSA

Except running instance, this should also cover all deployment scripts.

Deployed at <IP_ADDRESS>, scripts will be a part of 2nd issue


disable chat list user select on mobile web

@eVoloshchak , @neil-marcellini PR is ready for review.
I have addressed Neil's finding on slight outline in https://github.com/Expensify/App/issues/20470#issuecomment-1597039847, but looks like that is due to Webkit browser behaviour, only happens on long press right after page reload, does not affect the app functional behaviour.
The PR here has fixed the text selection problem reported in the original issue.
Details
disable user select on mobile web sidebar chat list, so that long pressing on mobile web will not select huge chunk of text, and does not trigger mobile OS copy/paste menu.
Fixed Issues
$ https://github.com/Expensify/App/issues/20470
PROPOSAL: https://github.com/Expensify/App/issues/20470#issuecomment-1583972828
Tests
Note: Only applicable for mobile devices

Login with any user on using mobile web Safari / Chrome
Long press one of the chats
Validate no text are getting selected, and "Pin" context menu appear at bottom

[x] Verify that no errors appear in the JS console

Offline tests
N/A
QA Steps
Note: Only applicable for mobile devices

Login with any user on using mobile web Safari / Chrome
Long press one of the chats
Validate no text are getting selected, and "Pin" context menu appear at bottom

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://github.com/Expensify/App/assets/5896391/e00f6050-05d2-417a-82fe-bc89e6e71bcd

Mobile Web - Chrome
https://github.com/Expensify/App/assets/5896391/f640af3a-3729-420f-9151-06dfa72e28aa

Mobile Web - Safari
https://github.com/Expensify/App/assets/5896391/dd7b2891-d929-40cc-ba31-0452b4b0183e

Desktop
https://github.com/Expensify/App/assets/5896391/cf2fbd17-25d4-4a73-bda6-7369640a3f1f

iOS
https://github.com/Expensify/App/assets/5896391/1321d224-ffc9-4ab5-b864-3c1a3713acaf

Android
https://github.com/Expensify/App/assets/5896391/ae0f1692-f67c-4cc6-9441-b249981d2770

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/neil-marcellini in version: 1.3.30-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.30-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Full stack Web Development YT link added

Fixes Issue #761

Changes proposed

Screenshots

@khushbumaheshwarii could you please resolve merge conflicts?

@khushbumaheshwarii could you please resolve merge conflicts?
i will do it soon give me some time

@khushbumaheshwarii could you please resolve merge conflicts?
i will do it soon give me some time

Sure, also please reference the respective issue

@khushbumaheshwarii could you please resolve merge conflicts?
i will do it soon give me some time

Sure, also please reference the respective issue

can you please review conflicts changes


Console output error breaks build on Windows 10

Description:
Running build-release on Win 10 Pro, PowerShell 7, Node 12.13.0 throws an error and stops the build

unknown parse/stringMarkup
✖ Unclosed blue tag

Steps To Reproduce:
Using these instructions:

clone rome
run build-release
get console output seen above

Expected Results
build-release to finish successfully
Seems to be an issue with the library that formats and prints to the console during build. Specifically the square brackets inside the <blue> tag.
Let me know if I can provide more detail or try something different to solve.

Hey @tbeseda could you check if https://github.com/facebookexperimental/rome/pull/242 would fix your issue?

@Lagily It does progress further in the build, but I get this error
✖ Expected to close pad but found brightBlack
<brightBlack><pad count="7" dir="right">--quiet</brightBlack>  no description found

Can you try again @tbeseda?

@Lagily I'm able to build and install Rome. Some of the console output is a bit off, but I think that would be a different issue/scope:

I see, looks like I broke something with the backslash escaping, I'll have a look

the pull request should now also not break the output in your console

node ./scripts/build-release ./dist
Building trunk
ℹ Bundling<EMAIL_ADDRESS>✔ Saved to ~/AppData/Local/Temp/rome-dev
Executing trunk
⚠ Disk caching has been disabled due to the ROME_CACHE=0 environment variable ⚠
unknown parse/stringMarkup ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
✖ Expected token Word but got Slash

1 │   \[MemoryFileSystem] Adding new project folder C:\Users\myUserName\rome\\
│                                                                              ^
2 │         ^

━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
✖ Found 1 problem
what can I do?
OS: windows 10

This, along with other Windows improvements, were fixed in #260.


[3pt] Compare NWS stage to HAND stage

Per FS
Do we calculate the average HAND Thalweg Elevation for each river segment? If so, it'd be interesting to take NWS Flood Stage, convert to Flood Water Surface Elevation, and then subtract HAND Thalweg Elevation from Flood Water Surface Elevation to determine HAND value for NWS Flood Stage. Perhaps worth testing in next iteration of AHPS FIM Libraries.

@TrevorGrout-NOAA Can this be closed?

@BradfordBates-NOAA Yeah this is essentially what we did in the Crane method.


Glass circle changes to a circle filled with different medium

I am working on a project where we need to know the glare points location on a soap bubble (soap skin but air inside the bubble). When the light sources are in different positions, the glare points are expected to show up in different places on the bubble. In the current application, I could only put a glass circle but the refractive index of the glass is not close to the refractive index of the air, therefore I am not able to obtain what I want.
Could users set the medium of the glass circle, for example, make it an air circle.

This is probably way too late for your needs, but for others: you can change the index of refraction of any of the glass elements in the Settings portion of the toolbar.


[MRG] the local web server to display the MLE suggestions

User description
Closes #169
The backend server can be started under the mle project by using mle serve.
The web is placed outside the mle-agent SDK, and should be launched individually.
Before submitting this PR, please make sure you have:

[x] confirmed all checks still pass OR confirm CI build passes.
[x] verified that any code or assets from external sources are properly credited in comments and/or in
the credit file.

PR Type
enhancement, dependencies

Description

Introduced a FastAPI server with a root endpoint and CORS middleware.
Added a new CLI command serve to start the FastAPI server with configurable host and port.
Updated requirements.txt to include fastapi and uvicorn dependencies.

Changes walkthrough 📝
Relevant filesEnhancement

cli.pyAdd CLI command to start FastAPI server

mle/cli.py
Added import for uvicorn and app from mle.server.  Introduced a new CLI command serve to start the FastAPI server.  Configured server host and port options with default values.

+11/-0

__init__.pyInitialize server module with app import

mle/server/init.py

Initialized the server module by importing app.

+1/-0

app.pyImplement FastAPI application with CORS middleware

mle/server/app.py
Created a FastAPI application instance.  Added CORS middleware to allow all origins and methods.  Defined a root endpoint returning a welcome message.

+22/-0

Dependencies

requirements.txtAdd FastAPI and Uvicorn to dependencies

requirements.txt

Added fastapi and uvicorn as dependencies.

+2/-0

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

could you write down the how users use this feature?

Yes, sure! I will update the document when this feature is well-tested

free to merge so we can test it

awesome! we can merge at first 👨🏻💻


[SPARK-45269][K8S] Use Java 21-jre in K8s Dockerfile

What changes were proposed in this pull request?
This PR aims to use Java 21 JRE in K8s Dockerfile. This PR uses Zulu OpenJDK 21 because Eclipse Temurin doesn't have Java 21.
Why are the changes needed?

Enable Java 21 test coverage in the K8s integration tests to make it sure all K8s-related library works in Java 21.
Recommend K8s users to use Java 21 when they build images from Apache Spark 4.0.0 binary distribution

Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the CIs.
Was this patch authored or co-authored using generative AI tooling?
No.

Could you review this, @LuciferYang ?

All tests passed.

Could you review this too, @HyukjinKwon ?

Thank you, @LuciferYang !

Merged to master for Apache Spark 4.0.0.


label_keys

I think I suggested changing from "labels" to "label_keys", but now that I see it in context I don't know. Is there a better name for this? Maybe "label_indices"?

@bendichter and I discussed this and decided to rename "label_keys" to "data". Fixed in https://github.com/rly/ndx-events/commit/4d41e4b7264790498e76acf681e6923b57096d3b


Blog: Add Link Back to ThreeFold.io in Header

Can we please make the header two different buttons?
THREEFOLD | BLOG
THREEFOLD | WEBSITE

This is minor but if someone has the time to handle, would be nice.
In the Menu:
ThreeFold Websites

ThreeFold.io
ThreeFold Wiki
ThreeFold Forum

If there is a better solution, please tell me.


Change excludeLocation to exclude-location

Because they seem to be rendered as lower in reveal.js.
Same goes for includeLocation.
Then we should also be able to use it inside of markdown files (no index.html necessary) like so
<!-- .slide: excludeLocation="print-pdf" -->

If this works, update in demo.

<!-- .slide: excludeLocation="print-pdf" -->

Seems impossibe as this point :(


Expand configuration to pass remote monitoring address within the node

This is part of the GRPC conversion of the monitoring tool. The blockchain node will act as a client for remote monitoring platforms, which would range from a central monitoring server to the desktop node application

Merged upstream via #371


[REQUEST] Set default Pick and Break DC

It would be nice if you could set the default DC for picking the lock or breaking the lock. That way it would save time when you quickly need to lock a door you forgot during a session and just in general makes life easier.
In addition it would be nice if the two default DCs can be different values, seems obvious but felt like i should mention it anyway.

I will include it in the next version

World settings for the default DCs have been added with v2.0.0


Regent Independent Region Requirements

In the versioning branch, there is now an option for users to specify that all the region requirements in a task launch are independent from each other (different from non-interfering). Independent means that either the field sets are independent, or the logical regions being accessed are independent (as determined by a region tree analysis, not a simple test that the set of index points are independent).
Importantly, this is a property of the call-site and not the task variant as different logical regions or field sets can be passed to the same logical task.  Therefore, this is specified by a flag on the launcher (right now just on task launchers because they are the only ones that are permitted to have aliased but non-interfering requirements right now).
https://github.com/StanfordLegion/legion/blob/versioning/runtime/legion/legion.h#L1147
https://github.com/StanfordLegion/legion/blob/versioning/runtime/legion/legion.h#L1213
It should be possible for Regent to know in some cases that the region requirements are actually independent and tell the runtime about it.  My guess is that this should not be too hard for Regent to figure out in a lot of cases, and if it doesn't specify it, everything just falls back to the normal dynamic analysis (no big deal).

@lightsighter Is this still a useful optimization?

This is still a useful optimization to do.


Updated packages in Python environment

Added a few packages (contextily, folium, rioxarray, pip, and the pip package echopy), including two language packs (spanish & portuguese). Updated pangeo-notebook to 2023.02.11.
Tried to update conda-lock but ran into problem with pip dependencies.
See https://github.com/oceanhackweek/jupyter-image/issues/42#issuecomment-1427276476, https://github.com/oceanhackweek/Hub-Management/issues/2 and https://github.com/oceanhackweek/Hub-Management/issues/3

Lets just go a cross post this: https://github.com/oceanhackweek/jupyter-image/issues/42#issuecomment-1428193354

@emiliom It looks like echopy is a simple enough package to quickly get on Conda-Forge that grayskull probably can auto scaffold the recipe for staged-recipies, so that might be the best route currently, as I don't think conda can directly ingest the non-rendered lockfiles.
@ocefpaf only mamba and micromamba can use the intermediate lockfiles right?

I don't think I'm going to be able convert to a mamba/micromamba based image before this event, and if there are any issues the cross-language debugging might be messy so it's probably better not to try.

How about if I remove echopy from this PR? That way it can move forward with the other updates, and come back with echopy later, when there might also be other package additions/updates.

@abkfenris and @ocefpaf The current Python image includes xlrd. IMHO it is useful to have Excel read capability. But xlrd is no longer maintained and doesn't read .xlsx files. Do you have any concerns about replacing it with openpyxl?

I don't have an issue swapping it out, especially since Pandas supports using it.

Thanks.
I forgot that openpyxl doesn't support reading .xls files, but xlrd does. I'm inclined to still drop xlrd altogether, given that it's getting old (though it doesn't seem to have any dependencies). So, I'll do that.

Do you have any concerns about replacing it with openpyxl?
I don't use xlrd anymore and we rarelly have non xlsx files. So I'm ok dropping it.

PS: I would also drop the conda-lock.yml file here b/c we only create the Linux lock anyway. You can do it with conda-lock-f environment.yml -p linux-64

I've removed conda-lock.yml and updated the PR.
Regarding conda-lock-f environment.yml -p linux-64, I get an error "conda-lock-f: command not found". Maybe you meant conda-lock -f environment.yml -p linux-64? That's the statement I've used, per @abkfenris 's instructions in #42, followed by conda-lock render -p linux-64

Alright, I've re-created the conda environment (again with mamba) now with the new conda-forge echopy package, and updated the conda-lock file. This is now ready to go, hopefully!

Thanks!


StatefulSets stuck in ContainerCreating on M5 generation

I've been trying to use M5s as they are slightly cheaper. However whenever the workers are changed to an M5 instance the pods in statefulsets will not start due to the persistent volumes:
from kubectl describe pod
21h		59s		630	kubelet, ip-10-172-81-220.eu-west-1.compute.internal			Warning		FailedMount	Unable to mount volumes for pod "zipkin-cassandra-0_default(f65705fa-d8e7-11e7-8cd7-060ac5ac5984)": timeout expired waiting for volumes to attach/mount for pod "default"/"zipkin-cassandra-0". list of unattached/unmounted volumes=[data-storage]
21h		59s		630	kubelet, ip-10-172-81-220.eu-west-1.compute.internal			Warning		FailedSync	Error syncing pod

The pvc is definitely bound, I can see it on the console and when I run kubectl get pvc it is marked as bound:
NAME                              STATUS    VOLUME                                     CAPACITY   ACCESSMODES   STORAGECLASS               AGE
data-storage-zipkin-cassandra-0   Bound     pvc-f6565e28-d8e7-11e7-8cd7-060ac5ac5984   20Gi       RWO           zipkin-cassandra-storage   21h

Switching back to M4s fixed this.
kubectl version
Client Version: version.Info{Major:"1", Minor:"7", GitVersion:"v1.7.4", GitCommit:"793658f2d7ca7f064d2bdf606519f9fe1229c381", GitTreeState:"clean", BuildDate:"2017-08-17T17:03:43Z", GoVersion:"go1.8.3", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"7", GitVersion:"v1.7.4+coreos.0", GitCommit:"4bb697e04f7c356347aee6ffaa91640b428976d5", GitTreeState:"clean", BuildDate:"2017-08-22T08:43:47Z", GoVersion:"go1.8.3", Compiler:"gc", Platform:"linux/amd64"}

kube-aws version 0.9.8
Are you aware of any way this generation is different that we might need to compensate for?

Hi @mclarke47, it seems like we have to wait until K8S 1.9 for that!
Ref: https://github.com/kubernetes/kops/blob/master/docs/releases/1.8-NOTES.md#significant-changes

@mumoshu Thanks for the quick response!


Fix schema docs for InstallerReturnCode

Resolves https://github.com/microsoft/winget-pkgs/discussions/115765
cc @stephengillie @denelon

This change is for the InstallerReturnCode field inside ExpectedReturnCodes
https://github.com/microsoft/winget-cli/blob/abd0f94866e51a0e64c5aa363248dd7da321aa15/schemas/JSON/manifests/v1.4.0/manifest.installer.1.4.0.json#L218-L220

This change is for the InstallerReturnCode field inside ExpectedReturnCodes
https://github.com/microsoft/winget-cli/blob/abd0f94866e51a0e64c5aa363248dd7da321aa15/schemas/JSON/manifests/v1.4.0/manifest.installer.1.4.0.json#L218-L220

Ahh, I see now


GetOrCreate/GetOrCreateAsync may lead to memory leaks?

While analyzing some memory leaks, while trying to reduce closures to the minimum, I may have found a bug with the extensions GetOrCreate and GetOrCreateAsync. Because the current design requires the entry to be disposed so the value would be added to the cache, it can't implement the disposable pattern as expected, by invoking the Dispose in the finalizer. The problem is that it hold references for other disposable instances and, at least the GetOrCreate methods, may have some unexpected behavior. Lets imagine the following code:
await cache.GetOrCreateAsync("potatoes", async k => {
    var potatoes = // get value from database
    if (potatoes == null)
        thrown new Exception("Value is null");
    return potatoes;
});

When looking at the implementation and comments, the expected behavior is not to add the value in case of an exception, but the problem is that an entry will be created but the dispose won't be called if an exception is thrown:
https://github.com/aspnet/Caching/blob/56447f941b39337947273476b2c366b3dffde565/src/Microsoft.Extensions.Caching.Abstractions/MemoryCacheExtensions.cs#L92-L121
Because removing the dispose now would be a breaking change (#340), my recommendation to patch this bug is to invoke the factory before creating the entry with new overloads and obsolete the current ones. This would ensure that, in case of an exception, the entry wouldn't be created and nothing would be added to the cache, as expected. Something as follows:
public static TItem GetOrCreate<TItem>(this IMemoryCache cache, object key, Func<TItem> factory, Action<ICacheEntry> config = null)
{
	if (!cache.TryGetValue(key, out object result))
	{
                result = factory();
		using(var entry = cache.CreateEntry(key))
                {
                        entry.SetValue(result);
                        config?.Invoke(entry);
                }
	}

	return (TItem)result;
}

The code as-is is almost correct, at least with respect to the actual implementation. Not calling the dispose on CacheEntry would be fine if it were not for the CacheEntryStack. If that were not present, nothing would actually get leaked.
For some background, what the CacheEntryStack system does is cause any new cache entry to expire when any of the entries it used in its delegate expire. that is to say in the following, "a" will expire when "b" expires.
memCache.GetOrCreate("a", _ => 2 * memCache.Get<int>("b") + 5);

This whole system means that gravity00's suggestion won't fix this correctly.
Of course, the whole EntryCacheStack breaks if cache entry delegate throws. Consider the following:
memCache.GetOrCreate("a", _ =>
{
	int c;
	try
	{
		c = memCache.GetOrCreate(
                    $"int_value:{someFilePath}",
                    __ => int.Parse(File.ReadAllText(someFilePath)));
	}
	catch(FileNotFoundException)
	{
		// File not found is expected, since
                // the file will not always be present.
                // Use a default of 15 in this case.
		c=15;
	}
	var b=memCache.Get<int>("b");

	return b+c;
});

in this case "a" will not inherit "b"'s cache expiration because the EntryCacheStack was messed up when "c" threw. Now obviously that code as shown is not something somebody would actually write, but it is not unreasonable for the basic structure to occur. The file read caching might be deeply nested in some complex business process, with specific expected exception types only handled at a higher level.
So this is not only a memory leak, but a correctness bug as well, since expiration of "a" upon expiration of "b" is documented behavior, but throwing an exception while trying to cache the file read caused that behavior to be violated.

@KevinCathcart yes, you are correct. I didn't know about that nested behavior at the time.
At the time, I also didn't went into more details about how using Dispose to commit is not a great idea because there was already a related issue for that: https://github.com/aspnet/Extensions/issues/719
It seems in version 3 they made a work around so no breaking changes will be made but I'm still very reluctant about that.


Feature/multiple email

Added the possibility to have multiple email addresses in one vcard.

Hi @mgrundkoetter
I just merged your PR. Thanks a lot.

You can find the new release here, I've mentioned you, woehoe :+1:

Referencing issue #34


Standardize references to file

Nit: I've noticed that references to files could be standardized bit more while working on #1135

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

On tasks' end I'm in favor of keeping existing ones for the sake of readability, unless we have any other objection.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Shift + Enter - adds new line but resets cursor position to zero

@apurvns Managed to reproduce the bug. Should be an easy one to fix. I will make Shift+Enter work like Enter. Shift+Enter seem to do different things in different web apps. From quick testing, it seems that Twitter just handles it the same way it handles pressing Enter, so I will replicate their behaviour.

I think you should also make twitter like content viewer. There are libraries out there which highlights mentions and tags but not having media (images,videos,links, etc) options in it and for that you have to use other library or write it yourself. Just a thought.

It definitely is a good idea in general. However, it is a bit out of scope for what I wanted from this component. It is mainly intended to be used as part of a whole to give you the ability to get the highlighting that matches exactly what you get on Twitter. I personally haven't found any libraries that does exactly that. Maybe they exist and I just couldn't find them. But the ones I managed to find never matched Twitter's behaviour exactly.
This component gives you that. You can then use it in conjunction with other components that give you the content viewing ability as well.
Maybe in the future, I will consider adding content viewing abilities. But for now, I would like to focus on a small set of features. After all, as you have noticed, the component is still not working perfectly.

also if you start typing and add space, it never works in first try, you have to repeatedly press space to get space working (I encountered this issue in mobile)

Mobile support isn't properly implemented yet. It is probably a good idea to add a disclaimer to the README to make this clear. I will do it tomorrow or, if you want, you can open a pull request to add it and I will merge it to the repo.
Let me know if you encounter this issue on a PC because I have never seen it happen there. Space works for me exactly as expected.
I am planning on implementing mobile support, but with limited time on my hands, I don't have an exact ETA on when I will be able to do it.

Btw, a quick update on the original issue. It is almost fixed. Most likely will release a patch tomorrow that addresses it.

This should be fixed by the latest patch. Can you please re-install the component and test it to confirm it is working for you?

That's great will test it soon

I am closing this for now. If you still experience this bug, let me know.


One syntax error in a schema file triggers identical errors in other GraphQL files

Issue workflow progress

Progress of the issue based on the
Contributor Workflow

[x] 1. The issue provides a reproduction available on GitHub, Stackblitz or CodeSandbox

For example, you can start off by editng the
'basic' example on Stackblitz.

Please make sure the graphql-eslint version under package.json matches yours.

[ ] 2. A failing test has been provided

[ ] 3. A local solution has been provided

[ ] 4. A pull request is pending review

Describe the bug
If there are multiple GraphQL schema files, a syntax error in one schema file will cause all other schema files to report the same error.
To Reproduce Steps to reproduce the behavior:
https://stackblitz.com/edit/github-gtadcw
There are three schema files:
root.graphqls
type Query {
  foo: Foo
  bar: Bar
}

foo.graphqls (this file has a syntax error due to a missing })
type Foo {
  id: ID!

bar.graphqls
type Bar {
  id: ID!
}

The expected output when running ESLint should be to report the error only in the foo.graphqls file. However, it reports the same error for all files on the third line.
Current ESLint output:
$ eslint .

/.../schema/bar.graphqls
  3:0  error  Parsing error: [graphql-eslint] Error while loading schema: Syntax Error: Expected Name, found <EOF>

/.../schema/foo.graphqls
  3:0  error  Parsing error: [graphql-eslint] Syntax Error: Expected Name, found <EOF>

/.../schema/root.graphqls
  3:0  error  Parsing error: [graphql-eslint] Error while loading schema: Syntax Error: Expected Name, found <EOF>

✖ 3 problems (3 errors, 0 warnings)

Expected behavior
Expected ESLint output:
$ eslint .

/.../schema/foo.graphqls
  3:0  error  Parsing error: [graphql-eslint] Syntax Error: Expected Name, found <EOF>

✖ 1 problems (1 errors, 0 warnings)

Environment:

OS: macOS 13.2.1
@graphql-eslint/eslint-plugin: 3.18.0
Node.js: v18.14.0

Additional context

Known limitation, unable to fix


playdate-sdk: init at 2.5.0

Description of changes
Add Playdate SDK

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Base on CONTRIBUTING.md requirement,
please use git rebase to squash the different commit ( add atomicptr to maintainers list, nixfmt maintainer file ) on a same topic into one, and forced push it back to your repos.

When adding yourself as maintainer in the same pull request, make a separate commit with the message maintainers: add . Add the commit before those making changes to the package or module. See Nixpkgs Maintainers for details.

Thanks for the review! I made the requested changes :)


use mkPoetryEnv from out-of-tree poetry2nix

Fixes nix develop which was throwing an error since we were still using mkPoetryEnv from nixpkgs:
error:
       … while calling the 'derivationStrict' builtin

         at //builtin/derivation.nix:9:12: (source not available)

       … while evaluating derivation 'nix-shell'
         whose name attribute is located at /nix/store/4fgs7yzsy2dqnjw8j42qlp9i1vgarzy0-source/pkgs/stdenv/generic/make-derivation.nix:348:7

       … while evaluating attribute 'buildInputs' of derivation 'nix-shell'

         at /nix/store/4fgs7yzsy2dqnjw8j42qlp9i1vgarzy0-source/pkgs/stdenv/generic/make-derivation.nix:395:7:

          394|       depsHostHost                = elemAt (elemAt dependencies 1) 0;
          395|       buildInputs                 = elemAt (elemAt dependencies 1) 1;
             |       ^
          396|       depsTargetTarget            = elemAt (elemAt dependencies 2) 0;

       error: poetry2nix is now maintained out-of-tree. Please use https://github.com/nix-community/poetry2nix/

Thanks for a fix!


NextDNS

Backstory

Data

[ ] name:
[ ] url:
[x] difficulty: easy
[x] notes: account deletion is easy possible in account settings with clicking one button
[ ] email:
[ ] domains:

Hi, could you please link to the deletion page?
A name of 'NextDNS' and domain of it would be needed as well. Probably something like NextDNS.org or NextDNS.com.

Hi, could you please link to the deletion page?
A name of 'NextDNS' and domain of it would be needed as well. Probably something like NextDNS.org or NextDNS.com.

Sure:
URL is: https://my.nextdns.io/account
name: NextDNS
domain: https://nextdns.io/


Create a webpage showing 5 formulas using "sup" tag

@prasad353-dev  can you assign this to  me

@pavankumarraju13 hey, i am new to hacktoberfest,can you assign me this issue.

can you pls assign me this issue?

Can u plz assign me this issue?

Can you please assign me this issue?
I would love to contribute in this


How to embed the Monaco editor with TS service in your own HTML page?

Hi,
sorry if this is the wrong place to ask for this.
It is really awesome that VS Code is now open-source. Some time ago I created a issue in the TypeScript repo (https://github.com/Microsoft/TypeScript/issues/5324) asking if it'd be possible to embed the Monaco Editor (as used in the TypeScript Playground) into your own HTML pages.
I'd like to:

Show the Monaco editor in the HTML page using the Typescript Language Service.

Specify the initial TypeScript editor contents and my own .d.ts definition files to be used by the TS Language Service.

Get the displayed TypeScript and the transpiled Javascript when e.g. a button is clicked.

Be able to dispose of the editor when e.g. another button is clicked.

So I'd like to use the editor similar to the Typescript Playground, with the difference that I would specify my own .d.ts files and to not have a JavaScript editor at the right-hand side.
However I don't know how to do this correctly.
I checked out the vscode repository and invoked tsc in the src folder. Then I created a HTML page in that folder using the TS playground as a template:
<!DOCTYPE html>

<meta charset="UTF-8" />

Test Monaco

However, when hosting the directory in IIS Express and opening the HTML file in a browser, I'm getting errors such as
GET
http://localhost:8080/vs/editor/contrib/comment/common/color.css [HTTP/1.1 404 Not Found 16ms]
GET
http://localhost:8080/vs/editor/contrib/inPlaceReplace/common/gotoError.css [HTTP/1.1 404 Not Found 13ms]
GET
http://localhost:8080/vs/editor/contrib/referenceSearch/browser/rename.css [HTTP/1.1 404 Not Found 125ms]
TypeError: Browser.isInWebWorker is not a function browserService.js:25:17
TypeError: nls.localize is not a function pluginsRegistry.js:330:30
TypeError: EditorCommon.LineTokensBinaryEncoding is undefined tokenIterator.js:7:9

Can anybody give me some pointers how to embed the editor correctly using the TS service?
Thank you!

+1

@T18970237136 @malekpour stay tuned. we plan to do something regarding the editor soon

Hi,
any news on this before the holidays?
Thanks!

@T18970237136, sorry this didn't make it for the December update.
Closing as a duplicate of #446.

I got it working! Thanks T18970237136 for the start. This HTML hosts the editor when served from the 'out' directory VSC builds to:
<!DOCTYPE html>

<title>VSC Editor</title>


Change AWS API Gateway to Lambda Function URL

Update "AWS Lambda Bolt Python Examples" page to include Lambda URL
Category (place an x in each of the [ ])

[ ] slack_bolt.App and/or its core components
[ ] slack_bolt.async_app.AsyncApp and/or its core components
[ ] Adapters in slack_bolt.adapter
[ ] Document pages under /docs
[x] Others

Requirements (place an x in each [ ])
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

[x] I've read and understood the Contributing Guidelines and have done my best effort to follow them.
[x] I've read and agree to the Code of Conduct.
[x] I've run ./scripts/install_all_and_run_tests.sh after making the changes.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@Globart1337 Thank you very much for submitting this PR quickly! Since I live in a bit different timezone (+09:00), I am unable to check your pull request now. My teammates may be able to check this PR today.
One thing that I would like to ask you is to check the above comment by CLA bot. We are unable to merge your contributions without your CLA signature. Please check the CLA content and consider signing it 🙇

@Globart1337 Thank you very much for submitting this PR quickly! Since I live in a bit different timezone (+09:00), I am unable to check your pull request now. My teammates may be able to check this PR today.
One thing that I would like to ask you is to check the above comment by CLA bot. We are unable to merge your contributions without your CLA signature. Please check the CLA content and consider signing it bow

signed :heavy_check_mark:

Hey I tested this out and this is working great! Huge improvement, and simpler setup. I like this a lot 👍
The only request I would have is that at the top of this document, between lines 6 and 11, there are still a few references to API Gateway. Can we update those, please?

Oh, didn't see them, will make an update

@filmaj please review

@seratch please review the change to PR or atleast ping @filmaj

Thanks a lot for this @Globart1337 ! Sorry I didn't respond earlier: it was my weekend so I try to stay away from the computer 😄

Thanks a lot for this @Globart1337 ! Sorry I didn't respond earlier: it was my weekend so I try to stay away from the computer 😄

Oh, okay then, no worries 😃