[BUG] java.lang.RuntimeException: Failed to create driver

Context:

Playwright Version: 1.17.2
Operating System: [e.g. Windows]
Browser: [Chrome]
Extra: standalone Selenium Grid 4 is set up in a windows remote machine.
Getting below error while running testcase through standalone selenium grid 4(created in a remote windows machine)
playwright version used 1.17.2

[INFO] Running org.example.AppTest
java.lang.RuntimeException: Failed to create driver
	at com.microsoft.playwright.impl.Driver.ensureDriverInstalled(Driver.java:54)
	at com.microsoft.playwright.impl.PlaywrightImpl.create(PlaywrightImpl.java:39)
	at com.microsoft.playwright.Playwright.create(Playwright.java:92)

code snippet
public void shouldAnswerWithTrue()
{
    List<String> list=new ArrayList<String>();
    list.add("--start-maximized");
    Map<String, String> env = new HashMap<>();
    env.put("SELENIUM_REMOTE_URL", "http://testing.net.int:4444/");
    try(Playwright playwright = Playwright.create(new Playwright.CreateOptions().setEnv(env))){
        Browser browser = playwright.chromium().launch(new BrowserType.LaunchOptions().setHeadless(false).setSlowMo(100).setArgs(list));
        BrowserContext browserContext = browser.newContext();
        Page page = browserContext.newPage();
    }
    catch (Exception e) {
            e.printStackTrace();
        }
}

Do you run the test via Maven or use some custom packaging?

Does it reproduce if you remove .setHeadless(false)? Does the same error occur if you don't pass env to Playwright.create ? Also try running with DEBUG=pw:browser to see extra logs. It'd be helpful if you could share a repro.

First i removed .setHeadless(false), but same error occurs.And its not going to Browser browser = playwright.chromium().launch(new BrowserType.LaunchOptions().setSlowMo(100).setArgs(list)); its failing at try(Playwright playwright = Playwright.create(new Playwright.CreateOptions().setEnv(env))){
Then i removed env variable and added SELENIUM_REMOTE_URL=http://testing.ext.int:4444 in the environment variable and ran the testcase like this try(Playwright playwright = Playwright.create()){ still same issue occurs. Then added DEBUG=pw:browser in the environment variables no extra log came in intellij console. Could you please help me.

Then added DEBUG=pw:browser in the environment variables no extra log came in intellij console.

Try running it with maven from terminal and without SELENIUM_REMOTE_URL for now, just to see if local browser works.

Could you please help me.

We need a repro to help, the error is too generic.

i ran through terminal using command mvn test after removing SELENIUM_REMOTE_URL . I am getting same error as below. As i dont admin privileges in corporate laptop driver cannot be initiated from there. By using selenium 4 also i cannot initiate my chrome driver in my local machine. Thats y i am using selenium grid 4. And the same selenium grid i want to try with playwright for one of the scenario(HTML5 drag and drop) which is not possible in selenium 4 now.

Any update on this

if I am using same repo in another machine(amazon workspace), local chrome browser opens and is working fine with same playwright version.

It seems that browser download fails, try updating to playwright 1.20.1 and running with  PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD to skip the failing step.

As you said I upgraded the playwright version to 1.20.1 and used PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD=1 in environment variables and ran with command mvn test and I got following error.
[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.example.AppTest
Skipping browsers download because PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD env variable is set
com.microsoft.playwright.PlaywrightException: Failed to read message from driver, pipe closed.
at com.microsoft.playwright.impl.PipeTransport.poll(PipeTransport.java:75)
at com.microsoft.playwright.impl.Connection.processOneMessage(Connection.java:157)
at com.microsoft.playwright.impl.ChannelOwner.runUntil(ChannelOwner.java:101)
at com.microsoft.playwright.impl.Connection.sendMessage(Connection.java:105)
at com.microsoft.playwright.impl.ChannelOwner.sendMessage(ChannelOwner.java:94)
at com.microsoft.playwright.impl.Connection$Root.initialize(Connection.java:76)
at com.microsoft.playwright.impl.Connection.initializePlaywright(Connection.java:138)
at com.microsoft.playwright.impl.PlaywrightImpl.create(PlaywrightImpl.java:47)
at com.microsoft.playwright.Playwright.create(Playwright.java:96)
at com.microsoft.playwright.Playwright.create(Playwright.java:100)
at org.example.AppTest.shouldAnswerWithTrue(AppTest.java:30)

Closing as part of the triage process since it seemed stale or did not get enough upvotes in the past. Please create a new issue with a detailed reproducible or feature request if you still face issues.

Any update on this?

Hello yury-s Did you solve this issue?

We need more info to act on this, can you run with DEBUG="pw:install,pw:channel" and share the logs?

@yury-s As you suggested i have added DEBUG="pw:install,pw:channel" i am getting below logs.

[WARNING]
[WARNING] Some problems were encountered while building the effective model for org.example:playwrightDemo:jar:1.0-SNAPSHOT
[WARNING] 'dependencies.dependency.(groupId:artifactId:type:classifier)' must be unique: junit:junit:jar -> version 4.11 vs 4.13 @ line 33, column 17
[WARNING] 'dependencies.dependency.(groupId:artifactId:type:classifier)' must be unique: junit:junit:jar -> version 4.11 vs 4.13 @ line 39, column 17
[WARNING]
[WARNING] It is highly recommended to fix these problems because they threaten the stability of your build.
[WARNING]
[WARNING] For this reason, future Maven versions might no longer support building such malformed projects.
[WARNING]
[INFO]
[INFO] ---------------------< org.example:playwrightDemo >---------------------
[INFO] Building playwrightDemo 1.0-SNAPSHOT
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- maven-resources-plugin:3.0.2:resources (default-resources) @ playwrightDemo ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory C:\Users\dasatya\workspace\playwrightDemo\src\main\resources
[INFO]
[INFO] --- maven-compiler-plugin:3.8.0:compile (default-compile) @ playwrightDemo ---
[INFO] Nothing to compile - all classes are up to date
[INFO]
[INFO] --- maven-resources-plugin:3.0.2:testResources (default-testResources) @ playwrightDemo ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory C:\Users\dasatya\workspace\playwrightDemo\src\test\resources
[INFO]
[INFO] --- maven-compiler-plugin:3.8.0:testCompile (default-testCompile) @ playwrightDemo ---
[INFO] Nothing to compile - all classes are up to date
[INFO]
[INFO] --- maven-surefire-plugin:2.22.1:test (default-test) @ playwrightDemo ---
[INFO]
[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.example.AppTest
2022-04-20T20:26:41.514Z pw:install created DriverJar: C:\Users\dasatya\AppData\Local\Temp\1\playwright-java-8170381812242527446
2022-04-20T20:26:41.518Z pw:install initializing driver
2022-04-20T20:26:43.592Z pw:install extracted driver from jar to C:\Users\dasatya\AppData\Local\Temp\1\playwright-java-8170381812242527446\playwright.cmd
java.lang.RuntimeException: Failed to create driver
at com.microsoft.playwright.impl.Driver.ensureDriverInstalled(Driver.java:61)
at com.microsoft.playwright.impl.PlaywrightImpl.create(PlaywrightImpl.java:40)
at com.microsoft.playwright.Playwright.create(Playwright.java:96)
at org.example.AppTest.shouldAnswerWithTrue(AppTest.java:31)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:365)
at org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:273)
at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:238)
at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:159)
at org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:384)
at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:345)
at org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:126)
at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:418)
Caused by: java.lang.RuntimeException: Failed to install browsers, exit code: 1
at com.microsoft.playwright.impl.DriverJar.installBrowsers(DriverJar.java:76)
at com.microsoft.playwright.impl.DriverJar.initialize(DriverJar.java:48)
at com.microsoft.playwright.impl.Driver.ensureDriverInstalled(Driver.java:57)
... 31 more
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.208 s - in org.example.AppTest
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  8.019 s
[INFO] Finished at: 2022-04-20T22:26:46+02:00
[INFO] ------------------------------------------------------------------------
Process finished with exit code 0

[yury-s] any update on this?

According to the log running driver commands from the temp folder fails for some reason. Can you run it under debugger, pause at line DriverJar.java:47 and then try running command  C:\Users\dasatya\AppData\Local\Temp\1\playwright-java-8170381812242527446\playwright.cmd install from terminal to see why it fails (replace location with the actual path for that playwright run)? My hunch is that there is some permission issue or some policy/antivirus restriction that prevents the launch.

Really appreciate for your quick reply. Sorry to bother you more. I did not get the point mentioned  by you " That command is supposed to download 3 browsers on the first run and cache them locally". But if you see the main issue description I am trying to connect selenium grid(which is a different remote machine) from my local machine. so browser should downloaded in remote machine right not locally? for your information the selenium grid is working fine when i am running testcases from selenium 4 code but same selenium grid is not working from playwright code. if this is related to permission issue or a policy/antivirus restriction then selenium grid should not work from selenium code as well right? Could you please explain it in detail for better understanding or else Could you please explain playwright to selenium grid connection architecture in detail how it is different from selenium to selenium grid connection architecture. Thank you so much. Waiting for your answer.

I did not get the point mentioned by you " That command is supposed to download 3 browsers on the first run and cache them locally". But if you see the main issue description I am trying to connect selenium grid(which is a different remote machine) from my local machine. so browser should downloaded in remote machine right not locally?

Sorry, you are right, looks like playwright tries to download browsers unconditionally(on local machine) even if you are connecting to Selenium grid. Can you try disabling that behavior by running your code with PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD=1 environment variable and see if it helps? It it helps we'll update playwright to not try loading browsers if SELENIUM_REMOTE_URL is specified.

for your information the selenium grid is working fine when i am running testcases from selenium 4 code but same selenium grid is not working from playwright code. if this is related to permission issue or a policy/antivirus restriction then selenium grid should not work from selenium code as well right?

I believe it has something to do with the local playwright setup, we should make sure that it can run the driver successfully, as it's the driver who establishes connection to the grid.

I too faced the same problem when trying to use playwright for a simple web scrappy (see attached source below) on android device.
On tracing, found that the returned resource path is "driver/linux-arm64", but classloader.getResource returns null; hence .toURI throws an exception.

classloader.getResource("driver/" + platformDir())

I see that the driver-bundle v1.22.0 jar does contain the required path i.e. "driver/linux-arm64".
Please advice if playwright is also designed for use with android OS?
If so, any advice to resolve the problem.
//======== Driver.jar =========
  private void extractDriverToTempDir() throws URISyntaxException, IOException {
    ClassLoader classloader = Thread.currentThread().getContextClassLoader();
    URI originalUri = classloader.getResource("driver/" + platformDir()).toURI();
    URI uri = maybeExtractNestedJar(originalUri);
    ....
}

    public static String getSource(String url) throws IOException
    {
        String content = null;
        try (Playwright playwright = Playwright.create()) {
            final BrowserType chromium = playwright.chromium();
            final Browser browser = chromium.launch();
            final Page page = browser.newPage();
            page.navigate(url);

            content = page.content();
            browser.close();

        } catch (Exception e) {
            e.printStackTrace();
        }
        return content;
    }

2022-06-24 08:16:54.114 6940-7088/org.cog.hymnchtv W/System.err: java.lang.RuntimeException: Failed to create driver
2022-06-24 08:16:54.115 6940-7088/org.cog.hymnchtv W/System.err:     at com.microsoft.playwright.impl.Driver.ensureDriverInstalled(Driver.java:61)
2022-06-24 08:16:54.115 6940-7088/org.cog.hymnchtv W/System.err:     at com.microsoft.playwright.impl.PlaywrightImpl.create(PlaywrightImpl.java:40)
2022-06-24 08:16:54.115 6940-7088/org.cog.hymnchtv W/System.err:     at com.microsoft.playwright.Playwright.create(Playwright.java:96)
2022-06-24 08:16:54.116 6940-7088/org.cog.hymnchtv W/System.err:     at com.microsoft.playwright.Playwright.create(Playwright.java:100)
2022-06-24 08:16:54.116 6940-7088/org.cog.hymnchtv W/System.err:     at org.cog.hymnchtv.utils.SocketConnection.getSource(SocketConnection.java:108)

I too faced the same problem when trying to use playwright for a simple web scrappy (see attached source below) on android device.
On tracing, found that the returned resource path is "driver/linux-arm64", but classloader.getResource returns null; hence .toURI throws an exception.

Do you run the tests with Maven or you have a custom deployment? Note that depending on what Java runtime you use the classloaders may behave differently and may require extra configuration / build steps to make the driver loading work.  Since you run it on Android it's likely a different issue even though the symptom is similar, feel free to open a separate bug for it.

I am having the same problem. I'm not sure why this issue was closed?

I am having the same problem. I'm not sure why this issue was closed?
@satya081 @elfiorr did you have a solution?

public static void browserSet(String browsers) {
Map<String, String> env = new HashMap<>();
env.put("PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD", "1");
Playwright.CreateOptions createOptions = new Playwright.CreateOptions();
createOptions.setEnv(env);
browser = Playwright.create(createOptions).chromium().launch(
new BrowserType.LaunchOptions()
.setExecutablePath(Paths.get("Path/to/browser.exe")))
.setHeadless(false)
.setChromiumSandbox(true));
context = browser.newContext(
new Browser.NewContextOptions()
.setViewportSize(1800, 1080)
);
}

I am facing similar issue; any updates ?

From Yesterday... I too facing same issue. Can any one help me on this
Browser name is: chromium
java.lang.RuntimeException: Failed to create driver
at com.microsoft.playwright.impl.driver.Driver.createAndInstall(Driver.java:105)
at com.microsoft.playwright.impl.driver.Driver.ensureDriverInstalled(Driver.java:57)
at com.microsoft.playwright.impl.PlaywrightImpl.createImpl(PlaywrightImpl.java:45)
at com.microsoft.playwright.impl.PlaywrightImpl.create(PlaywrightImpl.java:35)
at com.microsoft.playwright.Playwright.create(Playwright.java:110)
at com.microsoft.playwright.Playwright.create(Playwright.java:114)
at com.qa.factory.PlaywrightFactory2.initBrowser(PlaywrightFactory2.java:30)
at com.qa.base.BaseTest.setup(BaseTest.java:40)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:568)
at org.testng.internal.invokers.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:139)
at org.testng.internal.invokers.MethodInvocationHelper.invokeMethodConsideringTimeout(MethodInvocationHelper.java:69)
at org.testng.internal.invokers.ConfigInvoker.invokeConfigurationMethod(ConfigInvoker.java:390)
at org.testng.internal.invokers.ConfigInvoker.invokeConfigurations(ConfigInvoker.java:325)
at org.testng.TestRunner.invokeTestConfigurations(TestRunner.java:663)
at org.testng.TestRunner.beforeRun(TestRunner.java:652)
at org.testng.TestRunner.run(TestRunner.java:614)
at org.testng.SuiteRunner.runTest(SuiteRunner.java:443)
at org.testng.SuiteRunner.runSequentially(SuiteRunner.java:437)
at org.testng.SuiteRunner.privateRun(SuiteRunner.java:397)
at org.testng.SuiteRunner.run(SuiteRunner.java:336)
at org.testng.SuiteRunnerWorker.runSuite(SuiteRunnerWorker.java:52)
at org.testng.SuiteRunnerWorker.run(SuiteRunnerWorker.java:95)
at org.testng.TestNG.runSuitesSequentially(TestNG.java:1280)
at org.testng.TestNG.runSuitesLocally(TestNG.java:1200)
at org.testng.TestNG.runSuites(TestNG.java:1114)
at org.testng.TestNG.run(TestNG.java:1082)
at org.testng.remote.AbstractRemoteTestNG.run(AbstractRemoteTestNG.java:115)
at org.testng.remote.RemoteTestNG.initAndRun(RemoteTestNG.java:251)
at org.testng.remote.RemoteTestNG.main(RemoteTestNG.java:77)
Caused by: java.lang.RuntimeException: Failed to extract driver from jar:file:/C:/Users/songolu/.m2/repository/com/microsoft/playwright/driver-bundle/1.36.0/driver-bundle-1.36.0.jar!/driver/win32_x64, full uri: jar:file:/C:/Users/songolu/.m2/repository/com/microsoft/playwright/driver-bundle/1.36.0/driver-bundle-1.36.0.jar!/driver/win32_x64
at com.microsoft.playwright.impl.driver.jar.DriverJar.lambda$extractDriverToTempDir$0(DriverJar.java:154)
at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:183)
at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
at java.base/java.util.Iterator.forEachRemaining(Iterator.java:133)
at java.base/java.util.Spliterators$IteratorSpliterator.forEachRemaining(Spliterators.java:1845)
at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509)
at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499)
at java.base/java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:150)
at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:173)
at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
at java.base/java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:596)
at com.microsoft.playwright.impl.driver.jar.DriverJar.extractDriverToTempDir(DriverJar.java:134)
at com.microsoft.playwright.impl.driver.jar.DriverJar.initialize(DriverJar.java:66)
at com.microsoft.playwright.impl.driver.Driver.initialize(Driver.java:64)
at com.microsoft.playwright.impl.driver.Driver.createAndInstall(Driver.java:101)
... 31 more
Caused by: java.io.IOException: There is not enough space on the disk
at java.base/sun.nio.ch.FileDispatcherImpl.write0(Native Method)
at java.base/sun.nio.ch.FileDispatcherImpl.write(FileDispatcherImpl.java:68)
at java.base/sun.nio.ch.IOUtil.writeFromNativeBuffer(IOUtil.java:132)
at java.base/sun.nio.ch.IOUtil.write(IOUtil.java:97)
at java.base/sun.nio.ch.IOUtil.write(IOUtil.java:67)
at java.base/sun.nio.ch.FileChannelImpl.write(FileChannelImpl.java:288)
at java.base/java.nio.channels.Channels.writeFullyImpl(Channels.java:74)
at java.base/java.nio.channels.Channels.writeFully(Channels.java:96)
at java.base/java.nio.channels.Channels$1.write(Channels.java:171)
at java.base/java.io.InputStream.transferTo(InputStream.java:783)
at java.base/java.nio.file.Files.copy(Files.java:3171)
at java.base/java.nio.file.CopyMoveHelper.copyToForeignTarget(CopyMoveHelper.java:126)
at java.base/java.nio.file.Files.copy(Files.java:1308)
at com.microsoft.playwright.impl.driver.jar.DriverJar.lambda$extractDriverToTempDir$0(DriverJar.java:147)
... 45 more

My code is here,
       Playwright playwright = Playwright.create();
   Browser browser = playwright.chromium().launch(
		   new BrowserType.LaunchOptions().setHeadless(false).setChannel("Chrome"));
   Page page = browser.newPage();
   page.navigate("sprsika.simplesolve.com");
   String title = page.title();
   System.out.println(title);

   page.close();
   browser.close();
   playwright.close();

I am facing the same issue,
    Exception in thread "main" java.lang.RuntimeException: Failed to create driver
at com.microsoft.playwright.impl.driver.Driver.createAndInstall(Driver.java:105)
at com.microsoft.playwright.impl.driver.Driver.ensureDriverInstalled(Driver.java:57)
at com.microsoft.playwright.impl.PlaywrightImpl.createImpl(PlaywrightImpl.java:45)
at com.microsoft.playwright.impl.PlaywrightImpl.create(PlaywrightImpl.java:35)

@anthonyalayo public static void browserSet(String browsers) { Map<String, String> env = new HashMap<>(); env.put("PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD", "1"); Playwright.CreateOptions createOptions = new Playwright.CreateOptions(); createOptions.setEnv(env); browser = Playwright.create(createOptions).chromium().launch( new BrowserType.LaunchOptions() .setExecutablePath(Paths.get("Path/to/browser.exe"))) .setHeadless(false) .setChromiumSandbox(true)); context = browser.newContext( new Browser.NewContextOptions() .setViewportSize(1800, 1080) ); }

u saved my life, thanks!


Finding subtree size of each node.

Is your feature request related to a problem? Please describe.
Given a tree and its root node.We have to find the subtree size of each node .
Describe the solution you'd like
I will do it using DFS ,with inline comments and short description as well as with user's input and output.
Do you want to work on it
Yes, i would like to work on it in  C++  language.

@tarun26091999 @rudrakshi99 @plazzy99 @nakul-19  please assign this issue to me.Thank you

Hi,
I want to solve this in Python. Please assign it to me.


feat: Implement permission system into group chats

Currently, group chats dont have any direct semblance of permissions besides group settings, however this type of implementation could easily create more complexities down the road when expanding group chats. Instead, it would be better to implement a permission system into group chats and extend that outward instead of having two forms of permissions, which would create complexity when expanding down the road

resolved by #604


Strange generation of 'PhoneNumber' faker

Describe the bug
I've been generating phone numbers in my project and noticed some strange and incorrect results.
To Reproduce
Faker faker = new Faker();
faker.phoneNumber().phoneNumber();

The result of 50 repeated generations:
755-482-2234
085-863-3865 x3172
1-065-305-4959 x8047
314.976.7963 x734
330-099-4886 x670
916.255.0603 x527
725-431-2485 x2418
212-342-1988
342-146-2804 x670
(085) 866-9161 x22174
952-205-3782 x28369
(116) 263-6437 x19870
(767) 394-5938 x16583
106-499-4984 x0279
742-522-5959 x09797
(369) 671-5077
(228) 198-2966 x883
1-308-449-2513 x34799
1-941-533-0634 x464
1-473-386-5272 x7908
(609) 208-8335 x1751
1-569-094-9768 x527
559.581.5058 x13411
372-047-9918 x8116
942.389.2238
955.419.1339 x350
(860) 978-1565 x11785
906-710-1553 x40711
1-226-999-7832 x309
510.265.6294 x3466
1-009-496-8327
1-070-132-9366 x88195
292.279.7325 x65075
1-891-998-7425
619-452-1971 x0025
(195) 188-3605
1-099-630-3627 x726
520-057-5025 x683
1-614-603-4667
356.356.3680 x787
(610) 582-2496 x3466
733.494.4426
746.041.2609 x2698
281-908-1136
(227) 044-7571 x869
1-922-095-8040 x7974
371.030.3800 x756
1-173-703-9945 x73683
1-011-256-6217 x0112
860.554.2778 x555

Versions:

OS: Windows 11
JDK: 11
Faker Version 1.5.0

Probably would be helpful if you specify what exactly is incorrect

@snuyanzin For example this:<PHONE_NUMBER> x756.
x756 is this correct?

no idea, i'm not an expert in phone numbers, that's why put a comment about clarification like how to determine which one is correct and which one is not

@snuyanzin me too, but I don't think phone numbers should have x### at the end

Also, the fact that some numbers were generated in International Format, some with dots(don't know how)

I will try to fix it

x### - I guess it might be an extension number

@snuyanzin The problem in phone_number.yml phone_number.formats, there are incorrect formats.
Also, I have a question, how to correctly run the test PhoneNumberValidityFinderTest.testAllCellPhoneForLocale(), I don't which region to take in testAllCellPhoneForLocale String region = "?" to test phone_number.yml in resources/en/phone_number.yml

Faker by default uses Locale.ENGLISH. Maybe this is obvious, but I can't understand In the Locale class, ENGLISH locale is written without defining region: public static final Locale ENGLISH = createConstant("en", ""); . So, which .yml file does Datafaker use to generate when using the default locale? resource/en.yml?

@bodiam When generating phone numbers using Faker without specifying Locale, Faker uses phone_number.yml with not accurate formats but the most interesting thing is that phone_number.yml and en-US.yml phone_number.formats are both USA phone number formats, but phone_number.formats in en-US.yml has error count = 0 and phone_number.yml is incorrect. I'd like to know what to do. Copy formats from en-US.yml to phone_number.yml? What do you think?

Good find. I have no issue if you want to copy them from en-US to phone_number, though it's a little strange we have two files for this. I  assumed it would use en-US by default.


Adds replace method to skbio.sequence

Fixes #1222

@Kleptobismol done reviewing

@jairideout all comments addressed

@Kleptobismol done reviewing, this is ready for merge once final comments are addressed

Thanks @Kleptobismol!


Remove uses of keys via snarky, manage them directly in pickles

This PR builds upon o1-labs/snarky#618, moving the management of proving/verification keys out of snarky and into pickles. That PR should be reviewed and merged before this is reviewed.
This

removes the ancient Mina_base.How_to_obtain_keys library
uses snarky's constraint_system generator instead of generate_keypair
moves the Keypair.t type defined amidst the snarky functor hell to an explicit module inside Pickles.Impls

The diff of this PR is negligible, but it allows us to remove ~300 LOC of barely-used from snarky no longer belongs there.
Checklist:

[ ] Modified the current draft of release notes with details on what is completed or incomplete within this project
[ ] Document code purpose, how to use it

Mention expected invariants, implicit constraints

[ ] Tests were added for the new behavior

Document test purpose, significance of failures
Test names should reflect their purpose

[ ] All tests pass (CI will check this if you didn't)
[ ] Serialized types are in stable-versioned modules
[ ] Does this close issues? List them

Awesome, I waded through these functors often enough to know that this is great.
I'll have to adapt snarkyjs -- AFAIU, the changes would look like this:
let module Impl = Pickles.Impls.Step
- Impl.generate_keypair ~exposing:[ typ ] main)
+ Impl.constraint_system ~exposing:[ typ ] main |> Impl.Keypair.generate)

I want more of these PRs!


Mess with section display

Godot version:

3.2.4 rc3
OS/device including version:

win10 64
Issue description:

The "inspector" dock is confusing when selecting different areas.
In the gif you can see that the information of the animationTree node is displayed correctly, then a Blend2 node is selected and the "inspector" dock shows the information of the Blend2 node but when selecting the animationTree node again, the "inspector" dock no longer displays its information, then you need to select another node and reselect the animationTree node.
The animationTree node information should be displayed in the "inspector" dock when selected, even if it is already selected.

Steps to reproduce:
Necesary?
Minimal reproduction project:

Necesary?

Necesary?

Yes, we'd prefer not having to set up an AnimationTree setup to be able to reproduce this as it takes a bit of time to do :slightly_smiling_face:

Ok added.

This also happens with nodes like "Tilemap".
You select the "Tile set", the tilesets window opens and the "Inspector" dock shows the tileset information but now the information of the "Tilemap" node has disappeared from the "Inspector" dock, so even though the "Tilemap" node is selected, its information is not displayed and even if you select it again, the information will not be displayed.
Solution:
Select another node and select the "Tilemap" node again, now the information for the "Tilemap" node appears in the "Inspector" dock.

This continues to happen in 3.3 rc8 mono.
This time it happens when executing.

It doesn't seem the be the same issue, even if it might be related. Please open a dedicated issue for this one.


Use discrete uniform distributions instead of categorical distributions for defining certain hyperparameter spaces

tl;dr: should we do the hack I propose in this issue https://github.com/optuna/optuna/issues/3335 if the Optuna people don't want to have the this or it doesn't happen in a reasonable length of time? To my knowledge, this should result in meaningfully improved sample efficiency during sampling, especially in environments that are highly sensitive to tuning the discount factor (which is how I stumbled upon this in the first place).

Hello,
thanks for suggesting the feature to Optuna.
If I understand, you want to automate something that is similar to https://github.com/optuna/optuna-examples/blob/main/rl/sb3_simple.py#L44 ?
My main concern with that is the need to add user attributes to actually know what is the value used.
Let's see what Optuna devs say.

So it looks like we'd need to add this her per the newest comment in https://github.com/optuna/optuna/issues/3335. I'll ask someone to work on it.


RUMM-1230: Solve some dependencies warnings in React Native build, fix Android and iOS example apps compilation

What does this PR do?
This change fixes some dependencies warnings in React Native build coming from the fact that React Native v0.63.4 depends on React v16.13.1, see here. I chose not to update to v0.64.0 which depends on React v17.0.1, because it is a) major version change; b) is too recent, was released just 3 weeks ago, so I don't think we want to force customers to update their codebase (if they didn't do it yet).
Also this change removes manual linking on the native Android package, because auto-linking is available since RN v0.6 (see here), and having both resulted in the build failure (because of the duplicate classes).
Review checklist (to be filled by reviewers)

[x] Feature or bugfix MUST have appropriate tests
[x] Make sure you discussed the feature or bugfix with the maintaining team in an Issue
[x] Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

I also pushed a change to fix iOS app compilation, it removes explicit linking in Podfile.
Before the change:
➜  ios git:(_) pod install
Auto-linking React Native modules for target `DdSdkReactNativeExample`: RNCMaskedView, RNGestureHandler, RNReanimated, RNScreens, dd-sdk-reactnative, and react-native-safe-area-context
Analyzing dependencies
[!] There are multiple dependencies with different sources for `dd-sdk-reactnative` in `Podfile`:

- dd-sdk-reactnative (from `../node_modules/dd-sdk-reactnative`)
- dd-sdk-reactnative (from `../..`)

After the change:
➜  ios git:(_) pod install
Auto-linking React Native modules for target `DdSdkReactNativeExample`: RNCMaskedView, RNGestureHandler, RNReanimated, RNScreens, dd-sdk-reactnative, and react-native-safe-area-context
Analyzing dependencies
Downloading dependencies
Installing RNGestureHandler 1.10.3 (was 1.10.0)
Installing dd-sdk-reactnative 1.0.0-alpha3 (was 1.0.0-alpha2)
Generating Pods project
Integrating client project
Pod installation complete! There are 34 dependencies from the Podfile and 36 total pods installed.


NbMenuService: How to remove a NbMenuItem?

Issue type
I'm submitting a ...  (check one with "x")

[ ] bug report
[x] feature request
[ ] question about the decisions made in the repository

Issue description
Current behavior:

When using the NbMenuService, one can add NbMenuItem's to an existing menu, but not remove it.
Expected behavior:

Have a method that allows to remove an existing NbMenuItem or clear the whole menu in order to reconstruct the menu from a subcomponent.

Answered in nebular repo akveo/nebular#1193


Issue with pressing alt, ctrl, shift at the same time

There is a problem with pressing 2 or 3 buttons (alt/ctrl/shift) at the same time.
When pressing, for example: ctrl + shift + w + space at the same time and then letting go of either ctrl/shift/alt, then every other input in use is being cancelled so you stop moving and need to press w + space and every other key that you used again.
Tested on: 0.0.5 version
Minecraft version: 1.21 (Fabric Loader 0.15.11)
No other mods other than: Fabric API (0.102.0+1.21) and Fabric Language Kotlin (1.12.2+kotlin.2.0.20)

Thank you for the bug report.
I have read and tested it. I see what you are talking about. However, I don't know how to fix it.
What is happening is
A key release happens and triggers the active key binding to stop. What I will need to do is check if any kind of bindings match the new set of keys.

is there a fix yet?

is there a fix yet?

No, I am extremely busy with work and school and have no time to do anything.


ibc-go v.7.5.0 (and v7.6.0) breaks ICS27 backwards compatibility by default

Summary of Bug
7.5.0 introduces channel ordering options in the interchain accounts controller module. Older versions of ibc-go will fail to create the ICA channel if the ordering is not ORDER_ORDERED. However, the default ordering in NewMsgRegisterInterchainAccount is ORDER_UNORDERED, meaning that existing code that has been upgraded to ibc-go >=7.5.0 will no longer be compatible with older chains.
Relevant code:
https://github.com/cosmos/ibc-go/blob/b605529d6ccd1170e3d4bdec9fb9b79fd22a2141/modules/apps/27-interchain-accounts/controller/types/msgs.go#L34-L41
Expected Behaviour
Channels are ORDER_ORDERED by default, to preserve compatibility with older ibc-go versions
Version
Observed on ibc-go 7.6.0 (Kujira)
Steps to Reproduce
N/A

Note: I haven't taken a look at ibc-go v8 and beyond, as we are not yet using it on Kujira.

Hi @AmitPr. This change was documented in the release notes of v7.5.0 and in the documentation. You can keep the previous behaviour by setting the ordering to UNORDERED in the MsgRegisterInterchainAccount, or if you are using the legacy API, you can also use the RegisterInterchainAccountWithOrdering function to explicitly set the ordering to UNORDERED. Does this help?

@crodriguezvega the issue is that the default method for creating MsgRegisterInterchainAccount creates an UNORDERED channel, which is not backwards compatible, since previous versions of ibc-go default to ORDERED.
A module we have creates ICAs, and this default behavior silently broke the functionality and backwards compatibility of this module because of the change in default behavior. I will also note that this breakage was implemented in a minor semver upgrade.

Hi @AmitPr. Sorry for the late reply. We discussed this internally and we agree that we should probably not have introduced this change in a minor release, but the reason why we did it is because reopening ordered channels that close due to timeouts was one of the biggest complaints about ICA, so we decided to address it as soon as possible. We realise that this change in the default behaviour might be a bit surprising for existing users of ICA, but using unordered channels as the default for new ICA channels provides a better experience. We take for the future the learning point that we shouldn't make behavioural changes in minor releases, but we will not make a new minor release now to change back the ordering, since it would potentially make things even more confusing for our users.
I will close the issue now, but thanks for raising this problem. Feel free still to leave a comment if you have any more thoughts.


Disk IO hanging

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

[X] I understand that I will be blocked if I remove or skip any mandatory* field

Checklist

[X] I'm reporting a bug unrelated to a specific site
[X] I've verified that I'm running yt-dlp version 2022.11.11 (update instructions) or later (specify commit)
[X] I've checked that all provided URLs are playable in a browser with the same IP and same login details
[X] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[X] I've searched the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue

Provide a description that is worded well enough to be understood
When I run yt-dlp with CMD.exe on Windows 10, I type Ctrl + C in the middle of the process, abort the process, and immediately run it again, NTFS file search and DiskIO hangs.Explorer stops reading and after a while the second run of yt-dlp also stops writing. trying to delete the file with a non-explorer tool confirms that the Disk cannot be written.
Provide verbose output that clearly demonstrates the problem

[X] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[X] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output
[debug] Command-line config: ['--config-location', 'C:\\Users\\[MY_USERNAME]\\AppData\\Roaming/yt-dlp/audio_config', 'https://www.youtube.com/channel/UC2ne9XqtBWKJKLfIAKtmjAg', '-vU']
[debug] | Config "C:\Users\[MY_USERNAME]\AppData\Roaming/yt-dlp/audio_config": ['--yes-playlist', '--windows-filenames', '--mtime', '--merge-output-format', 'mp4', '--ignore-errors', '--parse-metadata', '%(creator,uploader,channel)s:%(mod_creator)s', '--parse-metadata', '%(track,title)s:%(meta_title)s', '--parse-metadata', '%(upload_date>%Y-%m-%d)s:%(meta_date)s', '--parse-metadata', '%(artist,mod_creator)s:%(meta_artist)s', '--parse-metadata', '%(album_artist,channel)s:%(meta_album_artist)s', '--parse-metadata', '%(track_number|1)s:%(meta_track)s', '--parse-metadata', '%(description).500s:%(meta_description)s', '--parse-metadata', 'playlist_index:%(track_number)s', '--parse-metadata', 'playlist_title:%(album)s', '--embed-metadata', '--embed-thumbnail', '--embed-chapters', '-x', '--format', 'bestaudio', '--audio-format', 'mp3', '--audio-quality', '0', '--output', '%USERPROFILE%\\Music\\%(channel)s\\%(title)s.%(ext)s']
[debug] User config "C:\Users\[MY_USERNAME]\AppData\Roaming\yt-dlp\config": ['--yes-playlist', '--windows-filenames', '--mtime', '--merge-output-format', 'mp4', '--ignore-errors', '--parse-metadata', '%(creator,uploader,channel)s:%(mod_creator)s', '--parse-metadata', '%(track,title)s:%(meta_title)s', '--parse-metadata', '%(upload_date>%Y-%m-%d)s:%(meta_date)s', '--parse-metadata', '%(artist,mod_creator)s:%(meta_artist)s', '--parse-metadata', '%(album_artist,channel)s:%(meta_album_artist)s', '--parse-metadata', '%(track_number|1)s:%(meta_track)s', '--parse-metadata', '%(description).500s:%(meta_description)s', '--parse-metadata', 'Please show description:%(meta_synopsis)s', '--embed-metadata', '--embed-thumbnail', '--embed-chapters', '--paths', '%userprofile%', '--format', 'bestvideo*+bestaudio', '--output', 'Videos/%(channel)s/%(title)s.(ext)s']
[debug] Encodings: locale cp932, fs utf-8, pref cp932, out utf-8, error utf-8, screen utf-8
[debug] yt-dlp version 2022.11.11 [8b64402] (pip)
[debug] Python 3.10.4 (CPython AMD64 64bit) - Windows-10-10.0.19044-SP0 (OpenSSL 1.1.1n  15 Mar 2022)
[debug] exe versions: ffmpeg N-106443-g723065a346-20220327 (setts), ffprobe N-106443-g723065a346-20220327
[debug] Optional libraries: Cryptodome-3.15.0, brotli-1.0.9, certifi-2022.06.15, mutagen-1.45.1, sqlite3-2.6.0, websockets-10.3
[debug] Proxy map: {}
[debug] Loaded 1723 extractors
[debug] Fetching release info: https://api.github.com/repos/yt-dlp/yt-dlp/releases/latest
Latest version: 2022.11.11, Current version: 2022.11.11
yt-dlp is up to date (2022.11.11)
[debug] [youtube:tab] Extracting URL: https://www.youtube.com/channel/UC2ne9XqtBWKJKLfIAKtmjAg
[youtube:tab] UC2ne9XqtBWKJKLfIAKtmjAg: Downloading webpage
[debug] [youtube:tab] Selected tab: 'videos' (videos), Requested tab: ''
[youtube:tab] Downloading all uploads of the channel. To download only the videos in a specific tab, pass the tab's URL
[youtube:tab] UC2ne9XqtBWKJKLfIAKtmjAg/streams: Downloading webpage
[debug] [youtube:tab] Selected tab: 'streams' (live), Requested tab: 'streams'
[youtube:tab] Downloading as multiple playlists, separated by tabs. To download as a single playlist instead, pass https://www.youtube.com/playlist?list=UU2ne9XqtBWKJKLfIAKtmjAg

I've never seen such an issue, and it doesn't sound like the problem is actually caused by yt-dlp. Can you try to reproduce on another system?
Your log shows only till the playlist extraction starts. Is that the point where the issue happens? yt-dlp isn't even accessing the disk at this point. Check task manager for what is actually accessing the disk

I am sorry for my sub system, Ubuntu, being currently not available. Therefore, I cannot try to reproduce on another system.
the log
The log is uploaded following this.
ytdlp.log
No further logging was output on CMD.exe.


Aaf 63 models

Merging this into dev so it doesn't become any bigger than it is right now.  We'll be able to branch from dev after this.
Maybe close the original issue since it is too broad.

@phuchle we need to fix the bcrypt stuff. I can run update on it and just push the update but no guarantees that the bcrypt stuff will work

I'd say lets wait on deleting branches cause i know we had some work in progress that haven't been merged in, we can bring those up to date, and see if we can get PRs out for those

Why wait? Squash > Merge > Delete

when i said "clearing rest of branches" I meant by way of PRs

Oh, i meant the other branches

:+1:


License?

Hi macintoshpie
This project is unlicensed...
I would like to translate this project for Korean speakers.
Thank you

Just added an MIT license 👍
I'd definitely be interested in figuring out how to add different languages -- happy to help figure this out if you're interested in contributing to the site


Update deadline module based on ynput and quad code

Changelog Description
Refacto Deadline Module based on Ynput 3.17 and current Quad repo
Fix :

Deadline Management
Thumbnails & Review
Settings Issue

Testing notes:

Launch any soft in any context
Create Render Instance
Send publish in farm

As mentioned in DM theses reverts shouldn't be necessary, this code should add robustness and avoid plugins form others hosts to be loaded in the current launched host.
We use the same syntax in https://github.com/quadproduction/openpype-custom-plugins and this works fine.
Don't know exactly why theses edits seems to mess around with the thumbnails, this need more investigations.


JSON parse error

Version
1.5.2
Node version
n/a
Operating System type
Other
Operating system version
Home Assistant 2022.6
Describe the bug
Home Assistant Add-on: eufy-security-ws installs OK and configuration is accepted.  No custom options are input.
username: xxxxxxxxxxx
password: yyyyyyyyyyy
country: PH
port: 3000
polling_interval: 10
accept_invitations: true
debug: false
event_duration: 10
stations: []
=========
Base Station and doorbell are detected and installed in the Home Assistant integration and seem to be working OK
To reproduce
Set up add-on in Home Assistant
Screenshots & Logfiles
s6-rc: info: service s6rc-oneshot-runner: starting
s6-rc: info: service s6rc-oneshot-runner successfully started
s6-rc: info: service fix-attrs: starting
s6-rc: info: service fix-attrs successfully started
s6-rc: info: service legacy-cont-init: starting
s6-rc: info: service legacy-cont-init successfully started
s6-rc: info: service legacy-services: starting
s6-rc: info: service legacy-services successfully started
2023-06-22 14:38:17.815  INFO  Eufy Security server listening on host <IP_ADDRESS>, port 3000
SyntaxError  Unexpected end of JSON input
error stack:
• utils.ts:151 parseJSON
usr/src/app/node_modules/eufy-security-client/src/utils.ts:151:21
• parameter.ts:45 readValue
usr/src/app/node_modules/eufy-security-client/src/http/parameter.ts:45:41
• device.ts:132 updateRawProperty
usr/src/app/node_modules/eufy-security-client/src/http/device.ts:132:45
• device.ts:64
usr/src/app/node_modules/eufy-security-client/src/http/device.ts:64:22
• device.ts:63 update
usr/src/app/node_modules/eufy-security-client/src/http/device.ts:63:35
• device.ts:37 initializeState
usr/src/app/node_modules/eufy-security-client/src/http/device.ts:37:14
• device.ts:45 initialize
usr/src/app/node_modules/eufy-security-client/src/http/device.ts:45:14
• eufysecurity.ts:625
usr/src/app/node_modules/eufy-security-client/src/eufysecurity.ts:625:32
2023-06-22 14:38:29.423  INFO  Push notification connection successfully established
2023-06-22 14:38:29.453  INFO  Connected to station T8010P13204543DB on host <IP_ADDRESS> and port 14745
2023-06-22 14:38:30.492  ERROR JSON parse error {"r
Additional context
I have this set up on another Home Assistant install and it's working OK.  This is another Home Assistant using same NUC clone hardware etc.

I have the same error, but with a secondary eufy account. If I use the 'primary', no error, but if I use an account (secondary account) that was added after as a 'home resident' I get this error exactly, including the parse error of 'r'.
After I logged in as that secondary account on mobile and confirmed I could see the devices on web and mobile, I tried again. I don't get the parse error now, I just get INFO  Eufy Security server listening on host <IP_ADDRESS>, port 3000  with no progression.
Still investigating, thought I'd share.

This has nothing to do with the config file of this project.
The problem is in the project eufy-security-client and it is in getting the device properties from the Eufy Cloud. Some properties have the value in json format and there seems to be a parsing problem with a property of a device.

Hello, I have the exact same problem through Jeedom plugin.
Posted here on eufy-security-client repo: https://github.com/bropat/eufy-security-client/issues/344

I am having the same issue with all Homebase devices, the solo cameras are actually detected properly and working as normally.
this is what I am getting:
2023-08-30 08:12:19.232  ERROR JSON parse error
{
data: '{"r',
error: SyntaxError: Unexpected end of JSON input
at JSON.parse ()
at parseJSON (/usr/src/app/node_modules/eufy-security-client/build/utils.js:147:21)
at ParameterHelper.readValue (/usr/src/app/node_modules/eufy-security-client/build/http/parameter.js:50:63)
at Camera.updateRawProperty (/usr/src/app/node_modules/eufy-security-client/build/http/device.js:127:57)
at /usr/src/app/node_modules/eufy-security-client/build/http/device.js:54:22
at Array.forEach ()
at Camera.update (/usr/src/app/node_modules/eufy-security-client/build/http/device.js:53:35)
at EufySecurity.updateDevice (/usr/src/app/node_modules/eufy-security-client/build/eufysecurity.js:344:44)
at EufySecurity.handleDevices (/usr/src/app/node_modules/eufy-security-client/build/eufysecurity.js:560:22)
at HTTPApi. (/usr/src/app/node_modules/eufy-security-client/build/eufysecurity.js:167:50)
}
2023-08-30 08:12:19.233  WARN Non-parsable parameter value received from eufy cloud. Will be ignored.
{
type: 2708,
value: '{"r'
}
2023-08-30 08:12:39.633  WARN Station T8124P31230354D0 - Tried all hosts, no connection could be established
2023-08-30 08:12:39.633  INFO  Timeout connecting to station T8124P31230354D0
2023-08-30 08:12:53.928  INFO  Connected to station T8124P31230354D0 on host <IP_ADDRESS> and port 23012
2023-08-30 08:13:24.097  INFO  Initiated closing of connection to station T8124P31230354D0 for saving battery.
2023-08-30 08:13:24.097  INFO  Disconnected from station T8124P31230354D0
I haven't been able to identify when this started happening, as I have a nightly docker update process and I lost track of it until I realized that it wasn't working properly.
any idea on what I could do to fix it?, even this is an eufy mal-formed response, I suppose there is a way for the client to be updated?

This issue should be reopened, not sure bropat sees it as it is closed. idk how to reopen it

This is an eufy cloud problem. I cannot do anything here. Only the above mentioned property is not updated, everything else works.
There is no point in reopening this issue.
Otherwise, I remove this error and the matter has an end ;)


Docker image based on Windows Platform

Description:
As of now the docker image provided by ballerina is a linux based docker image. Users who use windows needs to do several changes to their OSs in order to get it worked with linux based platforms.

Fixed with https://github.com/ballerinax/docker/pull/215.


Using UIButtonTypeSystem for buttons when disableBlurEffects is YES

I'm using a new fork for this pull request.
One of my projects uses custom tint color for buttons.
I would like to apply this customization on this awesome control as well. :)
Therefore to achieve this when the disableBlurEffects is set to YES the button is instantiated with UIButtonTypeSystem.

Thanks for the contribution! :)
I will include the change in the next version of RMActionController


bug: NPC doesn't get properly deleted from npc_spawn_db

Sometimes the NPC doesn't get deleted well from the DB when the event from torii is received. So the next time a user asks to spawn an NPC he gets the same, this cannot happen in a production environment as the two NPCs will then be on-chain until the end of time.
We should fix this and just in case have an owner only function in the smart contracts that kills off an NPC in case a bug like that happens

Regarding the kills off npc, we can delete an entity from the executor contract if we're owner (or writer as well, not sure about that), so no need for it :)

Fixed by #89
The delete query statement was not being committed properly


1.19 release with the versions only to 1.18.2

I downloaded the 1.19 release and I did find the liftable structures for the seed, it came up with no results twice. Then I did /seed gui and checked the latest versions. The latest version is 1.18.2 for the 1.19 mod. 1.19 terrain generation should be different than 1.18.2 so thats why my mod did not work? 19MisterX98 if this was an actual problem please change this. Thanks.

1.19 gen is no different, it should work fine if you set it on 1.18.2

I'm not convinced the generation didn't change.  One server I play on updated and there are huge changes, particularly in terrain/biome.  It looks like structure placement didn't change though (seeing shipwrecks in weird places).

the gen did change, structures are in slightly different places, and the new biomes probably messed with the placements of biomes overall... (I only checked structures) go to chunkbase and load up a seed, and view it in 1.18 and 1.19

Biomes are different but the mod doesn't use them. There might be some changes required somewhere. The normal structure cracking works the same way as though. Just use 1.18.2 for now until i add 1.19 to the selection

You are on a paper server . Color signs wont work here 反推不来是填写的时候种子是0没有种子吗？

Y ou a re on a p aper s erver . Co lor si gns wo nt wo rk he re


Icon is missing on resume from sleep

From Discord:

@Daisuke88
plugin working great, even after suspend. However, I noticed that the icon disappears when the PC wakes but returns on press. Is this normal??

Also missing on first startup

Should now be resolved with #15

unfortunately, #15 hasn't fixed it for my stream deck mini, i'm still having the same issue as before

unfortunately #15 doesn't seem to have fixed the issue for me, im still having the same problems as before even after updating the plugin


[META] Documentation website enhancements w/ engineering support

Is your feature request related to a problem? Please describe
Yes. The Docs as Code process can be improved by adding sign offs to development PRs. This would ensure documentation is created and managed alongside the code.
Describe the solution you'd like
Add a task list item (Documentation) through GitHub Actions.
Describe alternatives you've considered
No response
Additional context
No response

Issues:

opensearch-project/documentation-website#6400

Specifically, we're proposing the following changes:

Adding a mechanism so that a developer can indicate if documentation is required for the feature.
If documentation is required, preventing the dev PR from being merged until a documentation PR is in place in the doc repo.
If the feature adds new APIs, for each new API, the documentation PR must contain a filled out API Template, that provides all parameters, whether they are required or optional, default values, descriptions, and types.

Needs more discussion on this specific request.
Will add more acceptance criteria later.

Have some discussion with Heather offline, and seems like this requires some more testing. There are generally two models as in opt-in vs. opt-out.
If we do the opt-in model where developers need to check a box or add a label, it does not guarantee the issue creation if the label is missed. If we do the opt-out model then the timing of creating such issues and avoid unnecessary noise is key.
Still need some thoughts and discussion or even a one pager / poc before proceed with implementation.

Some ideas to consider: https://about.gitlab.com/blog/2022/10/12/five-fast-facts-about-docs-as-code-at-gitlab/

Working on GitHubApp POC and will send one pager design later.

Seems like core already have a basic workflow for creating the docs issues:
https://github.com/opensearch-project/OpenSearch/blob/main/.github/workflows/create-documentation-issue.yml

We have decided on this workflow:

Use core/plugin issue template to allow contributors to select whether they need to add a doc for their feature with needs-documentation label.
The label will trigger a issue creation in documentation-website repo.
The doc issue will inherit core/plugin issue on assigning users, add release branch, and more.

We will also add other checks later such as block PR merge, link backports to original opened issues, and more later, to help the docs team and core/plugin team avoid missing documentations, and start working on those early on.
Thanks.


zulip.Client.call_endpoint: Add retry_on_rate_limit_error.

Hi :)
I'd like to suggest a new option for the call_endpoint method of zulip.Client. It's something I added to my bot. @timabbott suggested to also consider this for the API, see https://chat.zulip.org/#narrow/stream/378-api-design/topic/Rate.20limits/near/1217048 for the discussion.
Short description of the patch:
If the call_endpoint method is called with the retry_on_rate_limit_error parameter set to true, wait and retry automatically on rate limit errors.

@timabbott Thanks for the feedback! :+1:
I updated the code (the layout of the if-statement with the closing bracket on its own line has been done by ./tools/lint btw. ;) ).
And you would also think that retry-after has always been a float, not a string? I'm not sure how that has been handled by older Zulip versions. And I'm not sure what happened to the capitalized Retry-After I found here...


raw.plot() does not work in ipython notebook

Here is the code to reproduce
%matplotlib inline
import mne
from mne.datasets import sample
data_path = sample.data_path()

raw_fname = data_path + '/MEG/sample/sample_audvis_filt-0-40_raw.fif'
raw = mne.io.Raw(raw_fname, preload=False)
raw.plot()

and here is the traceback
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
<ipython-input-8-6c1dd611695c> in <module>()
      1 raw = mne.io.Raw(raw_fname, preload=False)
      2 print(raw)
----> 3 raw.plot()

/home/mainak/Desktop/projects/mne-python/mne/io/base.pyc in plot(self, events, duration, start, n_channels, bgcolor, color, bad_color, event_color, scalings, remove_dc, order, show_options, title, show, block, highpass, lowpass, filtorder, clipping)
   1088                         color, bad_color, event_color, scalings, remove_dc,
   1089                         order, show_options, title, show, block, highpass,
-> 1090                         lowpass, filtorder, clipping)
   1091
   1092     @verbose

/home/mainak/Desktop/projects/mne-python/mne/viz/raw.pyc in plot_raw(raw, events, duration, start, n_channels, bgcolor, color, bad_color, event_color, scalings, remove_dc, order, show_options, title, show, block, highpass, lowpass, filtorder, clipping)
    697
    698     if show:
--> 699         plt.show(block=block)
    700
    701     return fig

/home/mainak/anaconda/lib/python2.7/site-packages/matplotlib/pyplot.pyc in show(*args, **kw)
    153     """
    154     global _show
--> 155     return _show(*args, **kw)
    156
    157

TypeError: show() got an unexpected keyword argument 'block'

cc @Eric89GXL

That should be an easy fix, either try except or use inspect. Hopefully I
can get to it today unless you have time @mainakjas


cannot unmarshal number into Go value of type map[string]interface {}

I am just trying to get through a basic tutorial. I installed through go install:
go install github.com/jschaf/pggen/cmd/pggen@latest
Then tried to run the following command against my postgres database:
pggen gen go \     --schema-glob author/schema.sql \     --query-glob author/query.sql
it creates the author schema in the database correctly, but I get the following error while trying to generate code for query.sql:
ERROR: parse template query file "C:\\code\\api-brand-allocation\\author\\query.sql": infer typed named query FindAuthorByID: infer output types for query: infer output type nullability: explain prepared query: can't scan into dest[0]: json: cannot unmarshal number into Go value of type map[string]interface {}
I pulled my query.sql and schema.sql from the following location:
https://github.com/jschaf/pggen/tree/main/example/author
Can't figure out what I missed, hopefully something simple. Thanks!

I just verified that installing via go install and running the author example works on main:
go install github.com/jschaf/pggen/cmd/pggen@latest
cd pggen/example
~/go/bin/pggen gen go --schema-glob author/schema.sql --query-glob author/query.sql

Does running the example from the repo work? My guess is that either schema file or query file has changed.  The author example doesn't use json so that's odd. Can you verify the content hasn't changed?

thanks so much for getting back to me. I just pulled the repo and then tried again. I am getting the same error. It is really odd it's complaining about json. Is that how it serializes the data?
Here is my error

Could this have anything to do with me running on windows?

I’d suspect the database setup before blaming Windows. Pggen mostly just connects to Postgres
You’ll need Docker to run pggen without a Postgres connection. If the Docker approach works it’s probably the DB setup.

Going to close as issue was resolved.


8 home page mobile app

Ive use this issue to explore react native because the mockup have change since I started.
For now it will behave as a placeholder, home page will be replace.
I had questions and other exploration that I dont know if they belong in github issue.
Questions :

How to deploy on mobile.
Best practice for global theming.

LGTM


Units in mne.utils.sizeof_fmt() not quite correct

The helper function mne.utils.sizeof_fmt() creates a string of a given number of bytes in a human-readable format (with appropriate prefixes). However, it uses base 2, so the units should be kiB, MiB, GiB, ... and not kB, MB, GB, ... (which are base 10).
We should either change the displayed units or the base. Which one would you prefer?

Personal preference for MiB etc but I don't really care as long as it's accurate


"custom" filters are not supported by Datashader

If you add a filter and use the "Edit As Query DSL" it will be passed to Datashader with type equal to "custom" and the dsl itself will be in a field equal to "value".  Code similar to this needs to be added:
elif f.get("meta", {}).get("type") == "custom" and f.get("meta", {}).get("key") is not None:
  filter_key = f.get("meta", {}).get("key")
  if f.get("meta", {}).get("negate"):
    filter["must_not"].append({filter_key : f.get(filter_key) })
  else:
    filter["filter"].append({filter_key : f.get(filter_key) })

This code is just an example and likely would want additional protection and/or checking of corner cases.

Was this ever added, @maihde?

support was added October 7th, 2020


Setting raycast parameters to exclude self causes Godot runtime window to crash without error

Godot version
v4.0.beta5.mono.official [89a33d28f]
System information
Windows 10 x64
Issue description
The following code (in a class derived from Node) causes Godot's runtime window to crash.  The editor reports no errors.
var rayParam = new PhysicsRayQueryParameters3D();
rayParam.Exclude.Add(Variant.CreateFrom(this));

Steps to reproduce
Just run the repro project.
Minimal reproduction project
MinReproProject.zip

Can you test again with the latest 4.0 beta 8? Note the exclude array has changed to be strongly typed, accepting only RIDs, which can be obtained from collision objects (such as areas and physics bodies) using the get_rid() method.

Yes, that appears to fix the problem.  However, the code is now more cumbersome:
rayParam.Exclude.Add(GetNode<CollisionShape3D>("Collider").Shape.GetRid());
It would be nice to have a helper method that adds all CollisionShapes on a given node or its children to the list.

You may have misread the terminology; probably we should say

CollisionObject3D-derived node (such as an Area3D node or a PhysicsBody3D-derived node).

in the documentation of the exclude parameter.
So you can just call get_rid() on a physics body; then all its collision shapes will be excluded.
Does what you wrote actually work? (It will compile, but I don't think it works.)

I don't know if it worked or not.  It was my first attempt to use the exclude function, so I don't have great use cases to test that in my current setup, unfortunately.
I think I can close this issue, though, since it's no longer relevant in the latest beta.


Fetch menu from WordPress

Create a guide in the Guides section on fetching a menu from WordPress.
WordPress does not expose menus in the REST API. Should we recommend installing a plugin (such as this one: https://github.com/WP-API/menus-endpoints [note: requires authentication]) to expose menus in the REST API, or demonstrate the code that would need to be added to functions.php?
https://community.frontity.org/t/how-to-fetch-menu-from-wordpress/415
https://community.frontity.org/t/i-have-a-problem-with-the-menu/2359/9

Should we recommend installing a plugin (such as this one: https://github.com/WP-API/menus-endpoints [note: requires authentication]) to expose menus in the REST API, or demonstrate the code that would need to be added to functions.php?

I would cover both options

Closed as there's a video + demo covering this explanation
https://github.com/frontity-demos/frontity-examples/blob/master/fetch-menu-from-wp/README.md


Fix IISIntegration folder structure

Flatten IISIntegration folder structure
Remove unused scripts from build

We should consider moving the build directory into the repo root too.

What about sln files?


re-raise Zappa exception with full traceback; pep8

Description
Raise long error traceback instead of short one (old raise ex gave us quite an unuseful error reports)
Sorry, no github issues here - it's just a quick fix.

Coverage decreased (-0.01%) to 78.722% when pulling 4811f99a776653338c8737f8c9a7c167ef75c670 on koriaf:master into 02a440d8f06bcf6978141777f6eb72893879295e on Miserlou:master.


[server] Flow preset for babel does not allow webpack to run

On branch develop:
$ yarn dev
yarn run v1.5.1
$ ./node_modules/.bin/concurrently --kill-others "npm run dev-relay" "npm run dev-webpack" "npm run dev-server"
[1]
[1] ><EMAIL_ADDRESS>dev-webpack /cfw/urb/main
[1] > webpack-dev-server --mode development --hot --inline --no-info --colors
[1]
[0]
[0] ><EMAIL_ADDRESS>dev-relay /cfw/urb/main
[0] > relay-compiler --src ./units/ --extensions=js jsx --schema schema.graphql --watch
[0]
[2]
[2] ><EMAIL_ADDRESS>dev-server /cfw/urb/main
[2] > export NODE_ENV=development && ./node_modules/.bin/babel-watch -e js,jsx ./units/urb-base-server/server.js
[2]
[0]
[0] Writing js
[0] Unchanged: 43 files
[0] Watching for changes to js...
[0] Watching for changes to graphql...
[1] /cfw/urb/main/node_modules/@babel/core/lib/config/config-descriptors.js:162
[1]     throw new Error(`Plugin/Preset files are not allowed to export objects, only functions. In ${filepath}`);
[1]     ^
[1]
[1] Error: Plugin/Preset files are not allowed to export objects, only functions. In /cfw/urb/main/node_modules/babel-preset-flow/lib/index.js
[1]     at createDescriptor (/cfw/urb/main/node_modules/@babel/core/lib/config/config-descriptors.js:162:11)
[1]     at items.map (/cfw/urb/main/node_modules/@babel/core/lib/config/config-descriptors.js:87:50)
[1]     at Array.map (<anonymous>)
[1]     at createDescriptors (/cfw/urb/main/node_modules/@babel/core/lib/config/config-descriptors.js:87:29)
[1]     at createPresetDescriptors (/cfw/urb/main/node_modules/@babel/core/lib/config/config-descriptors.js:79:10)
[1]     at presets (/cfw/urb/main/node_modules/@babel/core/lib/config/config-descriptors.js:61:19)
[1]     at presets (/cfw/urb/main/node_modules/@babel/core/lib/config/config-descriptors.js:51:25)
[1]     at mergeChainOpts (/cfw/urb/main/node_modules/@babel/core/lib/config/config-chain.js:308:26)
[1]     at /cfw/urb/main/node_modules/@babel/core/lib/config/config-chain.js:271:7
[1]     at buildRootChain (/cfw/urb/main/node_modules/@babel/core/lib/config/config-chain.js:119:22)
[1] npm ERR! code ELIFECYCLE
npm ERR! errno 1
[1] npm ERR<EMAIL_ADDRESS>dev-webpack: `webpack-dev-server --mode development --hot --inline --no-info --colors`
[1] npm ERR! Exit status 1
[1] npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>dev-webpack script.
[1] npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
[1]
[1] npm ERR! A complete log of this run can be found in:
[1] npm ERR!     /Users/alex/.npm/_logs/2018-05-19T22_13_01_195Z-debug.log
[1] npm run dev-webpack exited with code 1
--> Sending SIGTERM to other processes..
[0] npm run dev-relay exited with code null
[2] npm run dev-server exited with code null
error An unexpected error occurred: "Command failed.
Exit code: 1
Command: sh
Arguments: -c ./node_modules/.bin/concurrently --kill-others \"npm run dev-relay\" \"npm run dev-webpack\" \"npm run dev-server\"
Directory: /cfw/urb/main
Output:
".
info If you think this is a bug, please open a bug report with the information provided in "/cfw/urb/main/yarn-error.log".
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Resolved by upgrading deps, and possibly removing unused units.


More cleanup.

This is the sequel to https://github.com/maidsafe/crust/pull/620

This change is

r? @vinipsmaker
(maidsafe_highfive has picked a reviewer for you, use r? to override)

can you rebase against master?

Rebased.

Reviewed 13 of 20 files at r1, 1 of 1 files at r3.
Review status: all files reviewed at latest revision, 4 unresolved discussions.

src/config_handler.rs, line 96 [r3] (raw file):
next time just add #[ignore]. commenting/uncommenting code like this just make git blame a lot harder to use

src/ip_info.rs, line 29 [r3] (raw file):
I think it mirrored an is_global Rust function that was unstable at the time, so it may be safe to remote it from here. We're using this function to only add global addresses to bootstrap cache.

src/service.rs, line 631 [r3] (raw file):
this looks very unclean to me. why not gather the result as a variable whose name starts with _ in case you're doing this just because the lints complained?
or maybe better, create a function that instantiates a Service and wraps it into a struct containing the relevant data.

src/udp_listener.rs, line 161 [r3] (raw file):
mention uTP here, as it is more specific and may help debug problems faster

Comments from the review on Reviewable.io

src/service.rs, line 631 [r3] (raw file):
It is unclean, but it's only for tests. Nowhere in the tests do we explicitly use that channel but if we don't keep it alive then the tests fail.
If you like, I can instead instead return the channel from get_event_sender then assign it to a _category_rx everywhere it's used.

Comments from the review on Reviewable.io

src/ip_info.rs, line 29 [r3] (raw file):
Should I remove it right now? There's a few little utility functions like this around the place that aren't currently being used but were obviously written for a reason. I slapped #[allow(unused)]on the ones that I can imagine being used in the future.

Comments from the review on Reviewable.io

Review status: all files reviewed at latest revision, 3 unresolved discussions.

src/ip_info.rs, line 29 [r3] (raw file):
Go for it.

src/service.rs, line 631 [r3] (raw file):

If you like, I can instead instead return the channel from get_event_sender then assign it to a _category_rx everywhere it's used.

I prefer that approach.

Comments from the review on Reviewable.io

src/ip_info.rs, line 29 [r3] (raw file):
How about peer_id::get_pub_key and Connection::get_protocol?

Comments from the review on Reviewable.io

src/ip_info.rs, line 29 [r3] (raw file):
Or the other stuff in ip_info.rs that hasn't been stabilised upstream?

Comments from the review on Reviewable.io

Review status: all files reviewed at latest revision, 3 unresolved discussions.

src/ip_info.rs, line 29 [r3] (raw file):

How about peer_id::get_pub_key and Connection::get_protocol?

I think they were requested by the routing guys, but I don't remember why. I'd vote for removal and we can add back later if requested. But I'll leave it for you if you want to do in this PR or in another.

Or the other stuff in ip_info.rs that hasn't been stabilised upstream?

If it's not used, I think it should be removed. By the moment we might need it, it might be in stable Rust anyway.

Comments from the review on Reviewable.io

src/ip_info.rs, line 29 [r3] (raw file):
I've removed them in this PR :)

Comments from the review on Reviewable.io

Reviewed 6 of 6 files at r4.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

Comments from the review on Reviewable.io

And now we wait for AppVeyor...


98 alter all parents on altering dependents

Now we indicate which icons have changed so the process of updating all icons can be made easier.
Resolves #98.

Summary by CodeRabbit

New Features

Enhanced functionality for processing diagrams with updated methods for handling icon dependencies.
Improved return types for key functions, allowing for more comprehensive data output.
Introduced a new function for accumulating results related to valent points.

Bug Fixes

Streamlined handling of valent points, ensuring accurate processing and validation without altering core functionality.

In the proposed modification I am only returning:

newly added valent points
icons that will have to get modified to leverage those valent points

as opposed to the full set of paths that would have to be partially incorrect (no point potentially updating icons in all paths just for them to be discarded as we merge the results with the original icons).

I believe we are there now, the concept of automatic injection of valent points works. Now to switch back to the main branch and do the cleanup.

Not relevant anymore.


mermaid in marddown file not rendered

Please provide the environment you discovered this bug in.
node --version
v18.18.2
Which area/package is the issue in?
create-analog
Description
I created up a repository for you just do
npm i
npx nx run analog-app:serve

please see discord discussion
Please provide the exception or error you saw
No response
Other information
No response
I would be willing to submit a PR to fix this issue

[ ] Yes
[ ] No

@DrMabuse23 the referenced repo seems not to be public, or even exist.
have configured to use mermaid as described in the docs?
withMarkdownRenderer({
  loadMermaid: () => import('mermaid'),
});

Sorry I changed the
Visibility

It is a bug because the MarkdownRouteComponent does not load the necessary mermaid functionality
https://github.com/analogjs/analog/blob/main/packages/content/src/lib/markdown-route.component.ts
The AnalogMarkdownComponent does.
https://github.com/analogjs/analog/blob/main/packages/content/src/lib/markdown.component.ts

Is the separate route component necessary at all? They are the same except the mermaid functionality 👀


Async read methods on nrf twim lead to unsoundness when canceled (?)

I've been debugging lockup issues with twim and async cancelation in my project (investigation still ongoing), started reading the embassy_nrf::twim code to understand my problem and came across the following potential issue.
Consider the following snippet:
let mut twim: embassy_nrf::twim::Twim<'_,_> = build_twim(...);
let mut buf = [0u8; 4];
let _ = embassy_futures::poll_once(async {
     twim.read(27, &mut buf).await .unwrap();
});
do_something_with(buf);

As far as I understood, twim.read sets up the read operation by writing the slice pointer and length into the respective registers and the twim hardware then uses these to write the obtained bytes into the buffer.
Assuming the transfer is not yet done when the async_wait future is called (once), the future in then dropped and (crucially) the read operation is not aborted, continuing to write to buf in the above example. This, however, violates the exclusive access assumption of the mutable reference to buf in the following code and may lead to data races, for example.
Do you agree?
If so, what do you think would be the best way to fix this? I've seen that in the qspi-code an OnDrop-guard is used to wait for the operation to finish in case of cancelation. Should we implement this here as well? If you agree I could prepare a PR.
PS: From a cursory glance I suspect the same issue might be present for spim as well.

True, this is a problem.
The fix is to stop DMA when the future is canceled early (ie dropped). The uart driver does do it: https://github.com/embassy-rs/embassy/blob/ab85eb4b60cd49ebcd43d2305f42327685f5e5a6/embassy-nrf/src/uarte.rs#L642

Alright, I'll have a look some time in the next days. I think a similar problem exists with write methods. Although I don't see a problem with mutable aliasing, the input slice might be deallocated in the meantime and bogus data would be sent by the twim device. So I think writes should be cancelled accordingly.


Can't train BERT with loaded weights on QA Task

Hey everyone!. Thanks for this awesome repo
So I loaded some BERT weights that I obtained through customized BERT pretraining on a Spanish corpus.
I loaded my weights as indicated by the team on previous issues:
params = bert.params_from_pretrained_ckpt('/content/drive/MyDrive/Proyectos IA/Vicky chatbot/entrenamiento_tf/berto/berto_checkpoint/berto_manuales')

berto = bert.BertModelLayer.from_params(params)

model = tf.keras.models.Sequential([berto])
model.build((3, 128))

bert.load_bert_weights(berto, '/content/drive/MyDrive/Proyectos IA/Vicky chatbot/entrenamiento_tf/berto/berto_checkpoint/berto_manuales/model.ckpt-20')

So after I load my weights I try to pass it input data that looks like this:
{'input_mask': <tf.Tensor: shape=(4, 384), dtype=int32, numpy=
 array([[1, 1, 1, ..., 0, 0, 0],
        [1, 1, 1, ..., 0, 0, 0],
        [1, 1, 1, ..., 0, 0, 0],
        [1, 1, 1, ..., 0, 0, 0]], dtype=int32)>,
 'input_type_ids': <tf.Tensor: shape=(4, 384), dtype=int32, numpy=
 array([[0, 0, 0, ..., 0, 0, 0],
        [0, 0, 0, ..., 0, 0, 0],
        [0, 0, 0, ..., 0, 0, 0],
        [0, 0, 0, ..., 0, 0, 0]], dtype=int32)>,
 'input_word_ids': <tf.Tensor: shape=(4, 384), dtype=int32, numpy=
 array([[    4,  1036,  4920, ...,     0,     0,     0],
        [    4,     3,  1013, ...,     0,     0,     0],
        [    4,     3, 12767, ...,     0,     0,     0],
        [    4,  1030,  1641, ...,     0,     0,     0]], dtype=int32)>}

As you know these are inputs from SQuAD dataset. Problem is that I get the following error msg;
Layer bert_model_layer_14 expects 1 input(s), but it received 3 input tensors. Inputs received: [<tf.Tensor: shape=(4, 384), dtype=int32, numpy=
array([[1, 1, 1, ..., 0, 0, 0],
       [1, 1, 1, ..., 0, 0, 0],
       [1, 1, 1, ..., 0, 0, 0],
       [1, 1, 1, ..., 0, 0, 0]], dtype=int32)>, <tf.Tensor: shape=(4, 384), dtype=int32, numpy=
array([[0, 0, 0, ..., 0, 0, 0],
       [0, 0, 0, ..., 0, 0, 0],
       [0, 0, 0, ..., 0, 0, 0],
       [0, 0, 0, ..., 0, 0, 0]], dtype=int32)>, <tf.Tensor: shape=(4, 384), dtype=int32, numpy=
array([[    4,  1036,  4920, ...,     0,     0,     0],
       [    4,     3,  1013, ...,     0,     0,     0],
       [    4,     3, 12767, ...,     0,     0,     0],
       [    4,  1030,  1641, ...,     0,     0,     0]], dtype=int32)>]

By the way I don't get this error msg when I load a pretrained model from tensorflow hub but I need to use my own weights on this problem.
Thanks in advance!

I believe, by calling build() like this:
   model.build((3, 128))

you are effectively telling the BertModelLayer to expect a single tensor of token_ids (with batch_size=3) and use the default segment type 0:
https://github.com/kpe/bert-for-tf2/blob/55f6a6fd5d8ea14f96ee19938b7a1bf0cb26aaea/bert/model.py#L45-L54
If you want to specify segment ids, i.e. token_type_ids, try passing a list of shapes, i.e. something like:
l_input_ids           = keras.layers.Input(shape=(max_seq_len,), dtype='int32')
l_token_type_ids = keras.layers.Input(shape=(max_seq_len,), dtype='int32')

# provide a custom token_type/segment id as a layer input
output = l_bert([l_input_ids, l_token_type_ids])          # [batch_size, max_seq_len, hidden_size]
model = keras.Model(inputs=[l_input_ids, l_token_type_ids], outputs=output)
model.build(input_shape=[(None, max_seq_len), (None, max_seq_len)])

Hey KPE!. Thank you for your answer, I implemented the code to accept the additional inputs. Is there a way to make it accept input_mask as a third input as well? Or should I include that in another way? it seems like the base code would only allow up to two. Thanks in advance and I apologize for asking again, any help is kindly appreciated, thanks again!

@danielesposito27 - the mask is kind of auto generated internally (i.e. all zero token_ids get masked), and I believe, there is no way to explicitly specify it (but it should not be needed - in most cases I guess).


Adding settings option into pause menu QoL

https://user-images.githubusercontent.com/61670787/180659245-4f00be7b-83cc-4521-b941-27d529747176.mp4
small QoL i added to be able to change your settings through the pause screen mid-week and standalone songs.

Duplicate of Mode) #8899

Duplicate of #8899

this one is closed

this one is closed

Still a duplicate

this one is closed

Still a duplicate

this is different code though
the other one only works through charting mode
this one works whenever

his is different code though
the other one only works through charting mode
this one works whenever

it was fixed…

his is different code though
the other one only works through charting mode
this one works whenever

it was fixed…

wdym

if this made it into the next update i would freak out i've been trying to import this feature from kade for so long

his is different code though
the other one only works through charting mode
this one works whenever

it was fixed…

what was fixed???

cool!!

Duplicate of #8899

this is closed


Avoid accessing undefined array index in Page\Type\Composer\Control\Control::getRequestValue

This looks like a prime place to use array_get($array, $key, $defaultValue);

This looks like a prime place to use array_get($array, $key, $defaultValue);

Yes, I didn't think about that function


Bluetooth: Submitting more GATT writes than available buffers blocks for 30s and then errors out

Describe the bug
If I after subscribing to a characteristic fire away too many bt_gatt_write's, the thread will block for 30 seconds.
I have:
CONFIG_BT_CONN_TX_MAX=10
CONFIG_BT_L2CAP_TX_BUF_COUNT=10
CONFIG_BT_BUF_ACL_TX_COUNT=10

If I after subscribing do:
    LOG_INF("subscribed");
    for (int i = 0; i < (CONFIG_BT_CONN_TX_MAX - 1); ++i) {
        if (bt_gatt_write(ble_api_conn->conn, &wr_params) != 0)
            LOG_ERR("write failed");
    }
    LOG_INF("wrote");

Everything works as expected:
[00:00:06.715,942] <inf> main: subscribed
[00:00:06.716,094] <inf> main: wrote

But if I iterate 10 (or more) times, this happens:
[00:00:12.633,605] <inf> main: subscribed
[00:00:42.633,911] <err> main: write failed
[00:00:42.633,941] <inf> main: wrote

To Reproduce
Steps to reproduce the behavior:

Connect and subscribe to a GATT characteristic
Write at least CONFIG_BT_CONN_TX_MAX times

Expected behavior
Either having bt_gatt_write return an error, or get an error in the registered callback.
Impact
Annoyance - I keep track of the number of outstanding writes to avoid this.
Environment (please complete the following information):

OS: Linux
Toolchain gcc-arm-none-eabi-10.3-2021.07
v2.7.0 (but i'm pretty sure this has been an issue for a long time)

Reproducing
I can reproduce this without any subscriptions on samples/bluetooth/central:
prj.conf:
CONFIG_BT_DEBUG_LOG=y
CONFIG_BT_GATT_CLIENT=y

Add to main.c:
#include <logging/log.h>
LOG_MODULE_REGISTER(central);

void write_a_lot_callback(struct bt_conn *conn, uint8_t err,
				     struct bt_gatt_write_params *params)
{
	LOG_INF("Write request completed with BT_ATT_ERR 0x%02x", err);
}

static void write_a_lot(struct bt_conn * conn, uint16_t attr_handle)
{
	static uint8_t data[] = { 0x00 };
	static struct bt_gatt_write_params write_op;
	write_op = (struct bt_gatt_write_params){
		.handle = attr_handle,
		.offset = 0,
		.data = &data,
		.length = sizeof(data),
		.func = write_a_lot_callback,
	};

	LOG_INF("Writing a lot");
    for (int i = 0; i < (CONFIG_BT_CONN_TX_MAX + 5); ++i) {
		int err = bt_gatt_write(conn, &write_op);
        if (err) {
			LOG_ERR("Write request failed (%d)", err);
		}
		else {
			LOG_INF("Write request succeeded");
		}
    }
	LOG_INF("Done writing a lot");
}

Use the function at end of static void connected(struct bt_conn *conn, uint8_t err):
// The handle value does not matter
write_a_lot(conn, 1234);

Stack trace
BT RX thread gets stuck on a timeout while the rest is idle:
>>> info threads
  Id   Target Id                                     Frame
  2    Thread 536875024 (idle 00 UNKNOWN PRIO 15)    arch_cpu_idle () at /home/alwa/zephyrproject/zephyr/arch/arm/core/aarch32/cpu_idle.S:110
  3    Thread 536872936 (logging PENDING PRIO 14)    arch_swap (key=0) at /home/alwa/zephyrproject/zephyr/arch/arm/core/aarch32/swap.c:53
  4    Thread 536875392 (sysworkq PENDING PRIO 255)  arch_swap (key=0) at /home/alwa/zephyrproject/zephyr/arch/arm/core/aarch32/swap.c:53
  5    Thread 536873120 (BT TX PENDING PRIO 247)     arch_swap (key=0) at /home/alwa/zephyrproject/zephyr/arch/arm/core/aarch32/swap.c:53
  6    Thread 536874152 (BT RX pri PENDING PRIO 246) arch_swap (key=0) at /home/alwa/zephyrproject/zephyr/arch/arm/core/aarch32/swap.c:53
* 7    Thread 536874336 (BT RX RUNNING PRIO 248)     bt_att_req_alloc (timeout=...) at /home/alwa/zephyrproject/zephyr/subsys/bluetooth/host/att.c:3031

>>> bt
#0  bt_att_req_alloc (timeout=...) at /home/alwa/zephyrproject/zephyr/subsys/bluetooth/host/att.c:3031
#1  0x0001c92c in gatt_req_alloc (encode=0x1c701 <gatt_write_encode>, op=18 '\022', len=3, params=0x20001264 <write_op>, func=0x1c5cb <gatt_write_rsp>) at /home/alwa/zephyrproject/zephyr/include/sys/time_units.h:378
#2  gatt_req_send (conn=conn@entry=0x20000958 <acl_conns>, func=0x1c5cb <gatt_write_rsp>, params=0x20001264 <write_op>, encode=0x1c701 <gatt_write_encode>, op=18 '\022', len=3) at /home/alwa/zephyrproject/zephyr/subsys/bluetooth/host/gatt.c:2047
#3  0x0000b8d8 in bt_gatt_write (conn=conn@entry=0x20000958 <acl_conns>, params=params@entry=0x20001264 <write_op>) at /home/alwa/zephyrproject/zephyr/subsys/bluetooth/host/gatt.c:4323
#4  0x000034bc in write_a_lot (conn=conn@entry=0x20000958 <acl_conns>, attr_handle=1234) at /home/alwa/zephyrproject/zephyr/samples/bluetooth/central/src/main.c:99
#5  0x0000367a in connected (conn=0x20000958 <acl_conns>, err=<optimized out>) at /home/alwa/zephyrproject/zephyr/samples/bluetooth/central/src/main.c:133
#6  0x00007c7a in notify_connected (conn=conn@entry=0x20000958 <acl_conns>) at /home/alwa/zephyrproject/zephyr/subsys/bluetooth/host/conn.c:1274
#7  0x0001bfd6 in bt_conn_connected (conn=conn@entry=0x20000958 <acl_conns>) at /home/alwa/zephyrproject/zephyr/subsys/bluetooth/host/conn.c:1198
#8  0x000066a2 in bt_hci_le_enh_conn_complete (evt=evt@entry=0x20003840 <recv_thread_stack+960>) at /home/alwa/zephyrproject/zephyr/subsys/bluetooth/host/hci_core.c:1306
#9  0x0001bdca in enh_conn_complete (evt=0x20003840 <recv_thread_stack+960>) at /home/alwa/zephyrproject/zephyr/subsys/bluetooth/host/hci_core.c:1350
#10 le_legacy_conn_complete (buf=<optimized out>) at /home/alwa/zephyrproject/zephyr/subsys/bluetooth/host/hci_core.c:1350
#11 0x00006bf6 in hci_event (buf=0x20005248 <net_buf_hci_rx_pool>) at /home/alwa/zephyrproject/zephyr/subsys/bluetooth/host/hci_core.c:2325
#12 bt_recv (buf=buf@entry=0x20005248 <net_buf_hci_rx_pool>) at /home/alwa/zephyrproject/zephyr/subsys/bluetooth/host/hci_core.c:3386
#13 0x0000d6ca in recv_thread (p1=<optimized out>, p2=<optimized out>, p3=<optimized out>) at /home/alwa/zephyrproject/zephyr/subsys/bluetooth/controller/hci/hci_driver.c:527
#14 0x0001aaa6 in z_thread_entry (entry=0xd61d <recv_thread>, p1=<optimized out>, p2=<optimized out>, p3=<optimized out>) at /home/alwa/zephyrproject/zephyr/lib/os/thread_entry.c:36
#15 0x0001aaa6 in z_thread_entry (entry=0xd61d <recv_thread>, p1=<optimized out>, p2=<optimized out>, p3=<optimized out>) at /home/alwa/zephyrproject/zephyr/lib/os/thread_entry.c:36
#16 0x0c431924 in ?? ()
Backtrace stopped: previous frame identical to this frame (corrupt stack?)

Analysis
bt_gatt_write is called from a bt event listener (struct bt_conn_cb::connected in this case). The event listener executes on the BT RX thread. bt_gatt_write() involves a bt_att_req_alloc(BT_ATT_TIMEOUT) that will block waiting for a req. But the req will be made available in the same BT RX thread, in the event loop further up the stack, after connected has returned. Thus the thread soft deadlocks until timeout.
I believe the original intention of the code is that bt_att_req_alloc and transitvely bt_gatt_write should not be called on BT RX thread. However, our samples do just this, which implies that this is expected to work.
Needed fixes
The doc for bt_gatt_write specifies it's async. We have to adhere and never block. I'll open a PR replacing BT_ATT_TIMEOUT with K_NO_WAIT.
Docs must make it clear that bt event listeners are running on the BT RX thread and must be treated as ISRs. Do only thread-safe minimal work. Best practice is to just signal application thread, e.g. by semaphore or queue. Blocking will delay bluetooth event handling. I'll open a enchancement proposal.

This issue has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this issue will automatically be closed in 14 days. Note, that you can always re-open a closed issue at any time.

please remove the stale label


custom adjoints

What is the recommended way here to use a custom adjoint for an objective and/or constraints defined using ChainRulesCore.jl for the use in the value_jacobian function? Lets say I have defined my adjoint at the driver level and that I want that to be picked up rather than relying on the default autodiff. How should I tell Nonconvex I have the derivative information? If something like what is below worked that would be great:
using Nonconvex, LinearAlgebra, Test

function f(x::AbstractVector)
    val = sqrt(x[2])
    jac = [0.5*x[1]^-0.5,0]
    val, jac
end

function g(x::AbstractVector,a,b)
    val = ( a*x[1] + b)^3 - x[2]
    jac = [3* (a)  *(x[1]+ (b) )^2,-1]
    val, jac
end

options = MMAOptions(
    tol = Tolerance(kkt = 1e-6, f = 0.0),
    s_init = 0.1,
)

m = Model(f)
addvar!(m, [0.0, 0.0], [10.0, 10.0])
add_ineq_constraint!(m, x -> g(x,2,0))
add_ineq_constraint!(m, x -> g(x,-1,1))
alg = MMA87()
convcriteria = KKTCriteria()
r = Nonconvex.optimize(m, alg, [1.234, 2.345], options = options, convcriteria = convcriteria)
@test abs(r.minimum - sqrt(8/27)) < 1e-6
@test norm(r.minimizer - [1/3, 8/27]) < 1e-6

Thanks for your help

Hi Connor, glad to see you are giving Nonconvex a try. Gridap-TopOpt integration is still on my mind. Let me know if you want to help with that!
Re: your question, the way to define custom adjoints is using ChainRulesCore. Here is an example from TopOpt.jl https://github.com/mohamed82008/TopOpt.jl/blob/ad1cde7bfff891e9dd8ee03c928ba9b1fe946b3d/src/Functions/volume.jl#L92. So you would do something like this:
f(x::AbstractVector)  = sqrt(x[2])
function ChainRulesCore.rrule(::typeof(f), x::AbstractVector)
   val = f(x)
   grad = [0.0, 0.5*x[2]^-0.5]
   val, Δ -> (nothing, Δ * grad)
end

nothing is the adjoint of f wrt the function f itself because f is a simple function (not a closure or a callable struct). Δ * grad is the adjoint wrt x. I need to add this to the documentation.

Thanks Mohamed!
That's good to hear, lets get it going. I didn't realise the rrule would be picked up like that. Very cool.

That's good to hear, lets get it going.

If you want to join a meeting with @yijiangh and I to talk specifics, I would be happy to arrange that. There is also the #topopt channel in the Julia slack for quick discussions.
I will close this issue for now.


package section in tutorial markdown can cause duplicate extension import

Describe the bug
Loading a tutorial in a github repo includes the tutorial itself as an extension. If the tutorial md includes a ```package snippet to import the extension (e.g. to make it work in the tutorial tool),
To Reproduce
Steps to reproduce the behavior:

Go to https://arcade.makecode.com/#tutorial:github:jwunderl/dedup-tutorial-ext/test1
see error (it imports the same extension twice -- once for the repo
see pxt.json:

{
    "name": "dedup-tutorial-ext",
    "description": "",
    "dependencies": {
        "device": "*",
        "dedup-tutorial-ext": "github:jwunderl/dedup-tutorial-ext#v0.0.1",
        "arcade-background-scroll": "github:microsoft/arcade-background-scroll/",
        "please-dont": "github:jwunderl/dedup-tutorial-ext"
    },
    "files": [
        "main.blocks",
        "main.ts",
        "README.md",
        "assets.json",
        "images.g.jres",
        "images.g.ts"
    ],
    "preferredEditor": "tsprj"
}

Expected behavior
we should probably notice that the extension is the same an not include it as a dep twice. (we might need to leave the name / entry in dependencies though, because tutorials might use the name for coloring the inline blocks)

@jwunderl is this fixed? I vaguely remember the discussion.


Update Syntax

Update of the syntax so removes the compile warnings.

Hey @RolfHuisman, you can also use the branch from this PR: Classiq-Technologies/qsharp-integrations#5
It includes some updates.


[gym] Version bump

Added new code signing guide (#5178)
Support patching of signing script in Xcode 8 (#5391)
Support relative path like "~/file" (#5350)
Add warnings when using Xcode's 7 build options with legacy build api (#5229)
Deprecated provisioning_profile_path (#5106)
Proper escaping of codesigning identity (#5148)
Escape code signing identity
Add support for rbenv in wrap_xcodebuild/xcbuild-safe.sh (#4625)
Print out legacy information every time you run gym (#4890)
Fix gym with path with spaces (#4721)

👍


New Activity : VEDIC MATHS

Vedic Maths is an activity that focuses on improving the mathematical calculation skills of users. It helps the user to learn various mathematical calculation tricks that can be employed by the user to do faster calculations in an interactive way.

@llaske please share your thoughts on this activity.
Working on: Full Screen functionality and responsiveness of activity.

The target for Sugar/Sugarizer is children between 6 and 12. It seems too complex for this target.
If you're interested by a Math activity, I suggest you to the Mind math activity proposal here.

@llaske we can reduce the level of difficulty of tricks that children can learn . If you like the concept of the activity

No I think it's too close to the Mind Math activity.


Make libavif-{image,sys} workspace members of libavif

First of all, thanks for making this. I'm also interested in working with libavif in Rust and your crates made it so I won't have to do everything from scratch.
This PR makes libavif-image and libavif-sys workspace members of libavif

Thank you for your contribution. I look forward to receiving more patches!


Default to flat trend

default the timseries generator to a flat trend

not relevant anymore with the algebra of
maybe work on the transtyping.
eg (java like) something like my_timeseries = (Signal) 3 should be equivalent to my_timeseries = FlatTrend(3)
or implement a default signal of zeroes


5.4. Session Key Computation - how to derive the salt

I have a question regarding the current draft https://openid.net/specs/openid-4-verifiable-presentations-over-ble-1_0.html.
In section “5.4. Session Key Computation” you specify the key exchange and state that the salt should be derived via sha-256:
https://github.com/openid/openid4vp_ble/blob/e5370d5b7a2fa82b627b67bda6858ff81a64114d/main.md?plain=1#L273-L287
What is the input for the hash function?
seems like there is a related ongoing discussion in this pr: https://github.com/openid/openid4vp_ble/pull/18

Please assume we will use a SHA256(random nonce). It is under discussion in #18 .  If you would like to contribute it would be nice to discuss there.

Ok, i will use the sha256(nonce from identify packet) for now (using the raw bytes of the nonce).


drivers: hwinfo: Add drivers for NXP SoC

This PR adds hwinfo device id driver support for NXP LPC and kinetis SOC.

This drivers are not tested. Looking for someone who can test them since i have no NXP boards.
Tests:
cmake -DBOARD=lpcxpresso54114_m0 ../../tests/drivers/hwinfo/api
cmake -DBOARD=frdm_k64f ../../tests/drivers/hwinfo/api

Codecov Report

Merging #13018 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #13018   +/-   ##
=======================================
  Coverage   48.78%   48.78%
=======================================
  Files         311      311
  Lines       46518    46518
  Branches    10728    10728
=======================================
  Hits        22695    22695
  Misses      19352    19352
  Partials     4471     4471

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be1c18d...07aa957. Read the comment docs.

was the return value positive?

Yes. It suggests that the special area of flash where this value is stored has been erased on my particular board, hence my question to @galak and @stanislav-poboril to check their boards.

Please add hwinfo to the supported list for frdm_k64f and lpcxpresso54114_m4 to ensure these drivers get built in CI. I tested both on hardware and they pass the test, however the lpcxpresso54114_m4 returns a unique ID of 0xFFFFFFFF which is suspicious. @galak, @stanislav-poboril could you please test this on your lpc board?

I tested on my board and got 0xFFFF0000000000000000000000000000.

Resolved the conflicts

Removed LPC driver because of unreliable results.

I tested the imx rt driver on mimxrt1050_evk and it works well.

@chtavares592 please use this PR for testing when reworking #13039 to use hwinfo API.


Add variables for popover

Add two variables popover-padding-y and popover-padding-x

Almost thinking we nuke that inner padding entirely to avoid setting the extra styles. Let me noodle on that for a bit.

Alternate fix coming in #19889. Thanks!