ec2 server create command is failing while bootstrap

Version:
master branch of knife-ec2
Environment:
ubuntu 18.04
Scenario:
ec2 server create command
Steps to Reproduce:
Run knife ec2 server create command
Expected Result:
It should create the server as well as finish bootstrap successfully
Actual Result:
Bootstrap fails with *Net::HTTPServerException: 401 "Unauthorized**"
bundle exec knife ec2 server create -I ami-xxxxxxx -U ubuntu -N ddubey-ubu-msys --sudo -c /home/dheerajdubey/Downloads/chef-repo/.chef/knife.rb --region us-east-1 --use-sudo-password --yes -VV
INFO: Using configuration from /home/dheerajdubey/Downloads/chef-repo/.chef/knife.rb
DEBUG: Checking if we need to accept Chef license to bootstrap node
DEBUG: Reading products and relationships...
DEBUG: Successfully read products and relationships
DEBUG: License acceptance required for chef version: 16
DEBUG: Searching for the following licenses: ["infra-client", "inspec"]
DEBUG: Found license chef_infra_client at /etc/chef/accepted_licenses/chef_infra_client
DEBUG: Found license inspec at /etc/chef/accepted_licenses/inspec
DEBUG: Missing licenses remaining: []
DEBUG: All licenses present
DEBUG: Using AWS region us-east-1
DEBUG: Setting up AWS connection using aws_access_key_id: ASIAXXXXXXXXXXXXXXXX aws_secret_access_key: HTc+XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX aws_session_token: FwoGXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX

Generated keypair file: /home/dheerajdubey/Downloads/chef-repo/.chef/ubuntu-cbcf83cd1aff1bc53740.pem

Waiting for EC2 to create the instance
Instance ID: i-050d5b895da2df946
Flavor: m1.small
Image: ami-xxxxxxxxx
Region: us-east-1
Availability Zone: us-east-1a
AWS Tags: Name: ddubey-ubu-msys
SSH Key: ubuntu-cbcf83cd1aff1bc53740
T2/T3 Unlimited: Disabled

Public DNS Name: ec2-xxxxxxx.compute-1.amazonaws.com
Public IP Address: xxxxxxx
Private DNS Name: ip-172-31-11-103.ec2.internal
Private IP Address: <IP_ADDRESS>

Waiting for sshd access to become available
SSH Target Address: ec2-xxxxxxx.compute-1.amazonaws.com(public_dns_name)
DEBUG: No ssh gateway found, making a direct connection
DEBUG: sshd accepting connections on ec2-xxxxx.compute-1.amazonaws.com, banner is SSH-2.0-OpenSSH_8.2p1 Ubuntu-4

done

SSH Target Address: ec2-xxxxx.compute-1.amazonaws.com(public_dns_name)
Connecting to ec2-xxxxx.compute-1.amazonaws.com
DEBUG: [SSH] opening connection to<EMAIL_ADDRESS>DEBUG: [SSH] using options {:user_known_hosts_file=>"/dev/null", :port=>22, :compression=>false, :compression_level=>0, :keepalive=>true, :keepalive_interval=>60, :timeout=>60, :auth_methods=>["none", "publickey"], :keys_only=>true, :keys=>["/home/dheerajdubey/Downloads/chef-repo/.chef/ubuntu-cbcf83cd1aff1bc53740.pem"], :password=>"<hidden>", :forward_agent=>nil, :non_interactive=>true, :verify_host_key=>:always}
Connecting to ec2-xxxxxx.compute-1.amazonaws.com
DEBUG: [SSH] opening connection to<EMAIL_ADDRESS>DEBUG: [SSH] using options {:user_known_hosts_file=>"/dev/null", :port=>22, :compression=>false, :compression_level=>0, :keepalive=>true, :keepalive_interval=>60, :timeout=>60, :auth_methods=>["none", "publickey"], :keys_only=>true, :keys=>["/home/dheerajdubey/Downloads/chef-repo/.chef/ubuntu-cbcf83cd1aff1bc53740.pem"], :password=>"<hidden>", :forward_agent=>nil, :non_interactive=>true, :verify_host_key=>:accept_new}
DEBUG: [SSH]<EMAIL_ADDRESS>cmd = cmd.exe /c ver
DEBUG: [SSH]<EMAIL_ADDRESS>cmd = Get-WmiObject Win32_OperatingSystem | Select Caption,Version | ConvertTo-Json
DEBUG: [SSH]<EMAIL_ADDRESS>cmd = uname -s
DEBUG: [SSH]<EMAIL_ADDRESS>cmd = uname -m
DEBUG: [SSH]<EMAIL_ADDRESS>cmd = test -f /etc/debian_version
DEBUG: [SSH]<EMAIL_ADDRESS>cmd = test -f /etc/lsb-release && cat /etc/lsb-release
DEBUG: [SSH]<EMAIL_ADDRESS>cmd = sh -c '(sudo echo) < /dev/null'
DEBUG: [SSH]<EMAIL_ADDRESS>cmd = sudo echo '[SSH] Established'
**bundler: failed to load command: knife (/home/dheerajdubey/Chef_Repo/knife-ec2/vendor/cache/ruby/2.7.0/bin/knife)**
**Net::HTTPServerException: 401 "Unauthorized**"
  /opt/chef-workstation/embedded/lib/ruby/2.7.0/net/http/response.rb:124:in `error!'
  /home/dheerajdubey/Chef_Repo/knife-ec2/vendor/cache/ruby/2.7.0/gems/chef-16.1.16/lib/chef/http.rb:152:in `request'
  /home/dheerajdubey/Chef_Repo/knife-ec2/vendor/cache/ruby/2.7.0/gems/chef-16.1.16/lib/chef/http.rb:115:in `get'
  /home/dheerajdubey/Chef_Repo/knife-ec2/vendor/cache/ruby/2.7.0/gems/chef-16.1.16/lib/chef/knife/bootstrap/client_builder.rb:191:in `resource_exists?'
  /home/dheerajdubey/Chef_Repo/knife-ec2/vendor/cache/ruby/2.7.0/gems/chef-16.1.16/lib/chef/knife/bootstrap/client_builder.rb:176:in `sanity_check'
  /home/dheerajdubey/Chef_Repo/knife-ec2/vendor/cache/ruby/2.7.0/gems/chef-16.1.16/lib/chef/knife/bootstrap/client_builder.rb:55:in `run'
  /home/dheerajdubey/Chef_Repo/knife-ec2/vendor/cache/ruby/2.7.0/gems/chef-16.1.16/lib/chef/knife/bootstrap.rb:578:in `register_client'
  /home/dheerajdubey/Chef_Repo/knife-ec2/vendor/cache/ruby/2.7.0/gems/chef-16.1.16/lib/chef/knife/bootstrap.rb:557:in `run'
  /home/dheerajdubey/Chef_Repo/knife-ec2/vendor/cache/ruby/2.7.0/gems/chef-16.1.16/lib/chef/knife.rb:490:in `block in run_with_pretty_exceptions'
  /home/dheerajdubey/Chef_Repo/knife-ec2/vendor/cache/ruby/2.7.0/gems/chef-16.1.16/lib/chef/local_mode.rb:42:in `with_server_connectivity'
  /home/dheerajdubey/Chef_Repo/knife-ec2/vendor/cache/ruby/2.7.0/gems/chef-16.1.16/lib/chef/knife.rb:489:in `run_with_pretty_exceptions'
  /home/dheerajdubey/Chef_Repo/knife-ec2/vendor/cache/ruby/2.7.0/gems/chef-16.1.16/lib/chef/knife.rb:229:in `run'
  /home/dheerajdubey/Chef_Repo/knife-ec2/vendor/cache/ruby/2.7.0/gems/chef-16.1.16/lib/chef/application/knife.rb:163:in `run'
  /home/dheerajdubey/Chef_Repo/knife-ec2/vendor/cache/ruby/2.7.0/gems/chef-16.1.16/bin/knife:24:in `<top (required)>'
  /home/dheerajdubey/Chef_Repo/knife-ec2/vendor/cache/ruby/2.7.0/bin/knife:23:in `load'
  /home/dheerajdubey/Chef_Repo/knife-ec2/vendor/cache/ruby/2.7.0/bin/knife:23:in `<top (required)>'
dheerajdubey@PUN-LAP-DHEERAJ:~/Chef_Repo/knife-ec2$

It is working as expected with current code :
bundle exec knife ec2 server create -I ami-0bcc094591f354be2 -U ubuntu -N ddubey-ubu-msys-testnow --sudo -c /home/dheerajdubey/Downloads/chef-repo/.chef/knife.rb --region us-east-1 --use-sudo-password --yes

Generated keypair file: /home/dheerajdubey/Downloads/chef-repo/.chef/ubuntu-45d4d22beeeb53c54c07.pem

Waiting for EC2 to create the instance
Instance ID: i-0ecab8ae55662f779
Flavor: m1.small
Image: ami-0bcc094591f354be2
Region: us-east-1
Availability Zone: us-east-1a
AWS Tags: Name: ddubey-ubu-msys-testnow
SSH Key: ubuntu-45d4d22beeeb53c54c07
T2/T3 Unlimited: Disabled

Public DNS Name: ec2-3-222-113-99.compute-1.amazonaws.com
Public IP Address: <IP_ADDRESS>
Private DNS Name: ip-172-31-3-21.ec2.internal
Private IP Address: <IP_ADDRESS>

Waiting for sshd access to become available
SSH Target Address: ec2-3-222-113-99.compute-1.amazonaws.com(public_dns_name)
done

SSH Target Address: ec2-3-222-113-99.compute-1.amazonaws.com(public_dns_name)
Connecting to ec2-3-222-113-99.compute-1.amazonaws.com using ssh
Connecting to ec2-3-222-113-99.compute-1.amazonaws.com using ssh
Creating new client for ddubey-ubu-msys-testnow
Creating new node for ddubey-ubu-msys-testnow
Bootstrapping ec2-3-222-113-99.compute-1.amazonaws.com
 [ec2-3-222-113-99.compute-1.amazonaws.com] -----> Installing Chef Omnibus (stable/16)
downloading https://omnitruck.chef.io/chef/install.sh
  to file /tmp/install.sh.1516/install.sh
 [ec2-3-222-113-99.compute-1.amazonaws.com] trying wget...
 [ec2-3-222-113-99.compute-1.amazonaws.com] ubuntu 18.04 x86_64
Getting information for chef stable 16 for ubuntu...
downloading https://omnitruck.chef.io/stable/chef/metadata?v=16&p=ubuntu&pv=18.04&m=x86_64
  to file /tmp/install.sh.1520/metadata.txt
 [ec2-3-222-113-99.compute-1.amazonaws.com] trying wget...
 [ec2-3-222-113-99.compute-1.amazonaws.com] sha1	9f4ca8a682e53678899391ae08af026c8c455de1
sha256	00b18c6060de4b93171ebf08cc5e465258a69ca24aaf7c35b280f272978c131f
url	https://packages.chef.io/files/stable/chef/16.3.45/ubuntu/18.04/chef_16.3.45-1_amd64.deb
version	16.3.45
 [ec2-3-222-113-99.compute-1.amazonaws.com]
 [ec2-3-222-113-99.compute-1.amazonaws.com] downloaded metadata file looks valid...
 [ec2-3-222-113-99.compute-1.amazonaws.com] downloading https://packages.chef.io/files/stable/chef/16.3.45/ubuntu/18.04/chef_16.3.45-1_amd64.deb
  to file /tmp/install.sh.1520/chef_16.3.45-1_amd64.deb
 [ec2-3-222-113-99.compute-1.amazonaws.com] trying wget...
 [ec2-3-222-113-99.compute-1.amazonaws.com] Comparing checksum with sha256sum...
 [ec2-3-222-113-99.compute-1.amazonaws.com] Installing chef 16
installing with dpkg...
 [ec2-3-222-113-99.compute-1.amazonaws.com] Selecting previously unselected package chef.
 [ec2-3-222-113-99.compute-1.amazonaws.com] (Reading database ... 57084 files and directories currently installed.)
 [ec2-3-222-113-99.compute-1.amazonaws.com] Preparing to unpack .../chef_16.3.45-1_amd64.deb ...
 [ec2-3-222-113-99.compute-1.amazonaws.com] Unpacking chef (16.3.45-1) ...
 [ec2-3-222-113-99.compute-1.amazonaws.com] Setting up chef (16.3.45-1) ...
 [ec2-3-222-113-99.compute-1.amazonaws.com] Thank you for installing Chef Infra Client! For help getting started visit https://learn.chef.io
 [ec2-3-222-113-99.compute-1.amazonaws.com] Starting the first Chef Infra Client Client run...
 [ec2-3-222-113-99.compute-1.amazonaws.com] +---------------------------------------------+
✔ 2 product licenses accepted.
+---------------------------------------------+
 [ec2-3-222-113-99.compute-1.amazonaws.com] Starting Chef Infra Client, version 16.3.45
 [ec2-3-222-113-99.compute-1.amazonaws.com]
 [ec2-3-222-113-99.compute-1.amazonaws.com] resolving cookbooks for run list: []
 [ec2-3-222-113-99.compute-1.amazonaws.com]
 [ec2-3-222-113-99.compute-1.amazonaws.com] Synchronizing Cookbooks:
 [ec2-3-222-113-99.compute-1.amazonaws.com]
 [ec2-3-222-113-99.compute-1.amazonaws.com] Installing Cookbook Gems:
Compiling Cookbooks...
 [ec2-3-222-113-99.compute-1.amazonaws.com] [2020-08-11T12:27:04+00:00] WARN: Node ddubey-ubu-msys-testnow has an empty run list.
 [ec2-xxxxx.compute-1.amazonaws.com] Converging 0 resources
 [ec2-xxxxx.compute-1.amazonaws.com]
 [ec2-xxxxx.compute-1.amazonaws.com]
 [ec2-xxxxx.compute-1.amazonaws.com] Running handlers:
 [ec2-xxxxx.compute-1.amazonaws.com]
 [ec2-xxxxx.compute-1.amazonaws.com] Running handlers complete
 [ec2-xxxxx.compute-1.amazonaws.com] Chef Infra Client finished, 0/0 resources updated in 03 seconds
 [ec2-xxxxx.compute-1.amazonaws.com]

Instance ID: i-0ecab8ae55662f779
Flavor: m1.small
Image: ami-xxxx
Region: us-east-1
Availability Zone: us-east-1a
Security Group Ids: sg-166d9563
AWS Tags: Name: ddubey-ubu-msys-testnow
SSH Key: ubuntu-45d4d22beeeb53c54c07
Root Device Type: ebs
Root Device Name: /dev/sda1
Root Volume ID: vol-0dd033a81ede86893
Root Device Delete on Terminate: true

Block devices
===========================
Device Name: /dev/sda1
Volume ID: vol-0dd033a81ede86893
Delete on Terminate: true

===========================
Public DNS Name: ec2-xxxx.compute-1.amazonaws.com
Public IP Address: xxxxxx
Private DNS Name: ip-172-31-3-21.ec2.internal
Private IP Address: <IP_ADDRESS>
Environment: _default
JSON Attributes: {"run_list"=>[]}

Closing the issue now


helm: attempt to dynamically discover the master node during helm CLI run to set nodeSelector

When deploying on K8s, it is expected for all NE components to be collocated on a single node and preferably be running on a master node. Hence, there is a need to provide nodeSelector for each Pod.
ATM, the solution is to provide --set kubernetesNode=<TARGET_KUBERNETES_NODE_NAME> on helm CLI, asking user to obtain the TARGET_KUBERNETES_NODE_NAME by running kubectl get node and selecting a master node.
An optimization to the discovery process would be run the command below as
--set kubernetesNode=$(kubectl get node --selector='node-role.kubernetes.io/master=true' -o=jsonpath='{.items[0].metadata.name})'

Is there a way to run the above command as part of the helm CLI run to discover and set the node variable to be used in interpolation when rendering Pod object definitions from the templates?

Helm provides hooks https://helm.sh/docs/topics/charts_hooks/. However, the closest one pre-install is run already after the objects are rendered from the templates.
So, with the current edge +Add UI and helm command the only "dynamic" way would be to provide the user with the following
--set kubernetesNode=$(kubectl get node --selector='node-role.kubernetes.io/master=true' -o=jsonpath='{.items[0].metadata.name})'

The ultimate solution would be to use NE installer (where the command above would just be a part of the installation script).


kernel: configs: Add EFI support for Arm64

As x86_64 has updated the guest kernel to enable EFI support for NEMU,
because OVMF that is used by NEMU is an EFI firmware. Although the
NEMU is not ready for Arm64, we'd better to enable EFI support in
kernel to keep sync with x86_64.
Fixes #228
Signed-off-by: Wei Chen<EMAIL_ADDRESS>

lgtm


libhip_hcc.so not found in rocm-3.5.1

Please make sure that this is a build/installation issue. As per our GitHub Policy, we only address code/doc bugs, performance issues, feature requests and build/installation issues on GitHub. tag:build_template
System information

OS Platform and Distribution (e.g., Linux Ubuntu 16.04):
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device:
TensorFlow installed from (source or binary):
TensorFlow version:2.2.0
Python version:3.6.8
Installed using virtualenv? pip? conda?:pip
Bazel version (if compiling from source):
GCC/Compiler version (if compiling from source):
ROCm/MIOpen version:3.5.1
GPU model and memory:4GB

Describe the problem
Provide the exact sequence of commands / steps that you executed before running into the problem
import tensorflow as tf
hello = tf.constant('Hello, TensorFlow!')
Any other info / logs
Include any logs or source code that would be helpful to diagnose the problem. If including tracebacks, please include the full traceback. Large logs and files should be attached.
Could not load dynamic library 'libhip_hcc.so'; dlerror: libhip_hcc.so: cannot open shared object file: No such file or directory
the libhip_hcc.so is a symbolic link to libamdhip64.so  in /opt/rocm-3.5.1/hip/lib/libhip_hcc.so
but not found
/opt/rocm-3.5.1/hip/lib/ have already in ld.so.conf

I am experiencing this same error after upgrading from 3.5.0.
My case:
OS Platform and Distribution: Ubuntu 18.04 LTS (up to date)
TensorFlow installed from: pip install rocm-tensorflow
TensorFlow version: 2.2.0
Python version: 3.6.9
Installed using: pip in virtualenv environment
ROCm/MIOpen version: 3.5.1
GPU model and memory: RX 590 8GB

You need to reinstall (uninstall 3.5 and install 3.5.1).
On Tue, Jun 23, 2020 at 1:12 PM helfio<EMAIL_ADDRESS>wrote:

I am experiencing this same error after upgrading from 3.5.0.
My case:
OS Platform and Distribution: Ubuntu 18.04 LTS (up to date)
TensorFlow installed from: pip install rocm-tensorflow
TensorFlow version: 2.2.0
Python version: 3.6.9
Installed using: pip in virtualenv environment
ROCm/MIOpen version: 3.5.1
GPU model and memory: RX 590 8GB
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/ROCmSoftwarePlatform/tensorflow-upstream/issues/1019#issuecomment-648077948,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AIHXCONSFWNFZ6GRXDXR7OTRYCE2ZANCNFSM4OD2IJDQ
.

You need to reinstall (uninstall 3.5 and install 3.5.1).

I have the same exact problem. I removed all rocm packages and then re-installed but unfortunately the error message is still there.
2020-06-23 15:10:17.516520: F tensorflow/stream_executor/lib/statusor.cc:34] Attempting to fetch value instead of handling error Failed precondition: Could not load dynamic library 'libhip_hcc.so'; dlerror: libhip_hcc.so: cannot open shared object file: No such file or directory Aborted (core dumped)

You need to reinstall (uninstall 3.5 and install 3.5.1).

I have the same exact problem. I removed all rocm packages and then re-installed but unfortunately the error message is still there.
2020-06-23 15:10:17.516520: F tensorflow/stream_executor/lib/statusor.cc:34] Attempting to fetch value instead of handling error Failed precondition: Could not load dynamic library 'libhip_hcc.so'; dlerror: libhip_hcc.so: cannot open shared object file: No such file or directory Aborted (core dumped)

You need to reinstall (uninstall 3.5 and install 3.5.1).

I have the same exact problem. I removed all rocm packages and then re-installed but unfortunately the error message is still there.
2020-06-23 15:10:17.516520: F tensorflow/stream_executor/lib/statusor.cc:34] Attempting to fetch value instead of handling error Failed precondition: Could not load dynamic library 'libhip_hcc.so'; dlerror: libhip_hcc.so: cannot open shared object file: No such file or directory Aborted (core dumped)

i try to reinstall to 3.5.1 and change /etc/ld.so.conf.d/ but still error. untill i use LD_LIBRARY_PATH declare the rocm librarys. it's ok

I guess this is a problem with the packaging of ubuntu deb files. Maybe it should be kept open until the packages are fixed?

I guess this issue should be kept open. A lot of users have problems with the current deb packages.
AMD please improve your QC

#1022

issue fixed using the following commands
cp /opt/rocm/hip/lib/libamdhip64.so.3.5.30501 /usr/lib/libhip_hcc.so
ldconfig

@codecor-cn in my case no "magic tricks" were necessary, I just reinstalled

Running ldconfig -v shows the weird result libamdhip64.so.3 -> libhiprtc.so for /opt/rocm/lib.
I would expect a link like libhiprtc.so -> libamdhip64.so.3. So I guess maybe there are some cyclic dependencies?
On workaround that I am currently using is to:
a) Delete libhiprtc.so from /opt/rocm/lib
b) Add a file rocm-hip.conf in /etc/ld.so.conf.d with the following content (needs root permission)
/opt/rocm/hip/lib
c) Run ldconfig as root
Then everything should work as expected


spdx-utils: Implement the SPDX 2.2.1 document model

This change adds the model classes for SPDX documents for SPDX version
2.2.1 and supports serialization and deserialization of JSON and YAML
SPDX document files. All properties are supported except for 'ranges'
which are not properly specified yet [1], and thus cannot be implemented yet.
There is some design flexibility regarding how strong the typing is for
the respective properties, e.g. a propery could use a String or a
dedicated type. This change does not implement the strongest possible
typing for both, fault tollerance and most importantly to limit the
scope of this first iteration. Adding a dedicated type for SPDX IDs or
references are good candidates for future improvements.
The SPDX specification [2] is targeting mainly RDF and thus does not
provide enough information to derive the actual JSON or YAML format.
To fill the gap the examples [3] are taken as referrence additionally.
The tests proof that the JSON and YAML examples are (apart from the
mentioned ranges property) fully implemented, e.g.
serialize(deserialize(example)) == example holds.
[1] https://github.com/spdx/spdx-spec/issues/412
[2] https://github.com/spdx/spdx-spec/tree/development/v2.2.1/chapters
[3] https://github.com/spdx/spdx-spec/tree/development/v2.2.1/examples
Signed-off-by: Frank Viernau<EMAIL_ADDRESS>

As a general feedback, and as mentioned before, I'm a bit concerned we might be reinventing the wheel here WRT https://github.com/spdx/Spdx-Java-Library. I'd expect some convincing justification we're not using / contributing to that library as part of the commit message.

As a general feedback, and as mentioned before, I'm a bit concerned we might be reinventing the wheel here WRT https://github.com/spdx/Spdx-Java-Library. I'd expect some convincing justification we're not using / contributing to that library as part of the commit message

I've updated the commit message.

@fviernau please give me a few hours today to go through this once more so I can also approve before you merge.

@fviernau please give me a few hours today to go through this once more so I can also approve before you merge.

Sure, if there are no major issues I'd be happy to merge it soon and file a follow up PR.


Identify the set of differences between APP-6(D) and MIL-STD-2525D

Background
APP-6(D) data products will be created from ones produced for MIL-STD-2525D. These data products include:

Mobile style
Schema/GDB
Metadata used to produce Mobile style, GDB

In order to create these products the team should first produce a short synopsis/document that highlights and identifies the set of differences between APP-6(D) and MIL-STD-2525D.
Current State
No document of set of differences between APP-6(D) and MIL-STD-2525D exists.
Steps to Reproduce / Requirement / Workflow
Create document/writeup/report that explains differences between APP-6(D) and MIL-STD-2525D with respect to:

[ ] Symbols/icons
[ ] Attributes
[ ] Labels

Expected Results / Behavior
Writeup of set of differences between APP-6(D) and MIL-STD-2525D exists.
Version
MIL-STD-2525D 10 JUNE 2014
http://www.jcs.mil/Portals/36/Documents/Doctrine/Other_Pubs/ms_2525d.pdf
APP-6D Edition D Version 1 OCTOBER 2017
http://nso.nato.int/nso/zPublic/ap/PROM/APP-6 EDD V1 E.pdf

Quick Note: a very quick/high level diff analysis is here: https://github.com/Esri/military-features-data/issues/293#issuecomment-363813115
@joebayles - the APP-6D standard does mention cyberspace is several sections (Ex: A-6, Table A-4: Symbol Set) - are you sure this has been removed?

@csmoore it hasn't been removed. I should clarify: MIL-STD-2525D Change 1 has brand-new cyberspace symbology (including it's own frame shape). MIL-STD-2525D and APP-6D have the same cyberspace symbols. I apologize for the confusion.

This issue was moved to Esri/military-symbology#290


Backup failed with error "Failed to list APIResources"

Adding API NamespacedGVRsIgnoreAPIGroupErr, which returns
Namespaced GVRs and ignores error in APIGroups in exclude filter.
Change Overview

Pull request type
Please check the type of change your PR introduces:

[x] :construction: Work in Progress
[ ] :rainbow: Refactoring (no functional changes, no api changes)
[ ] :hamster: Trivial/Minor
[ ] :bug: Bugfix
[ ] :sunflower: Feature
[ ] :world_map: Documentation
[ ] :robot: Test

Issues

#XXX

Test Plan

[ ] :muscle: Manual
[ ] :zap: Unit test
[ ] :green_heart: E2E

you can move the CRD test to the discovery package to fix the cycle


Comments causing SQLite error

I create a new bookmark, and then comment on it from a Mastodon account.
In the log, I'm seeing this
Actor https://social.lol/users/andypiper matches an allowlist item, marking comment visible
[Error: SQLITE_CONSTRAINT: UNIQUE constraint failed: comments.url] {
  errno: 19,
  code: 'SQLITE_CONSTRAINT'
}

The comment still shows up on the web page. I'm not sure how to further debug the SQLite error here.

I'm getting that same error as well


[feat] Implement CI Pipeline for Linting

Description:
We need to set up a Continuous Integration (CI) pipeline for our project to ensure code quality and consistency. The CI pipeline should run linting checks automatically and fix any issues when possible.
Tasks:
Configure Linting:

Ensure npm run lint is set up to check for code style and quality issues.
Ensure npm run lint:fix is set up to automatically fix linting issues.

Set Up CI Pipeline:

Integrate a CI service (e.g., GitHub Actions, Travis CI, CircleCI) with our repository.
Create a configuration file (e.g., .github/workflows/lint.yml for GitHub Actions) to run linting commands on every push and pull request.

Expected Outcome:

Automated linting checks on each commit and pull request.
Consistent code style and reduced manual linting effort.

Additional Notes:

Ensure the pipeline is set up to provide clear feedback on linting errors.
Optionally, set up a badge in the README to display the CI status.

Can you please assign me this issue for hacktoberfest? Thanks!


All content always being removed on "clean"

Hi,
I have this setup with summernote 0.8.3;
e.g.
 $('.js-summernote').summernote({     toolbar: [       [         'view',         //['cleaner',['cleaner']],         ['cleaner','picture', 'link', 'table', 'codeview']       ]     ],     lang: 'en-US',     cleaner:{           notTime: 2400, // Time to display Notifications.           action: 'button', // both|button|paste 'button' only cleans via toolbar button, 'paste' only clean when pasting content, both does both options.           newline: '
', // Summernote's default is to use '

'           notStyle: 'position:absolute;top:0;right:0;width:40%;', // Position of Notification           icon: '',           keepHtml: false, // Remove all Html formats           keepClasses: false, // Remove Classes           badTags: ['style', 'script', 'applet', 'embed', 'noframes', 'noscript', 'html'], // Remove full tags with contents           badAttributes: ['style', 'start'] // Remove attributes from remaining tags     },     width: "100%",     height: 180,     // set editor height     minHeight: 180, // set minimum height of editor     maxHeight: null, // set maximum height of editor     focus: false, // set focus to editable area after initializin     callbacks: {       onInit: function() {         that = $(this);       },       onImageUpload: function(files) {         for(var i=0; i < files.length; i++) {           console.log(files);           summernoteSendFile(files[i], that);         }       }     }   });
What's happening is that on click on the button its always removing all content - any thoughts?
Thanks!

@StudioJunkyard, @gr0g, I've encountered the same problem and was about to submit a pull request with a slight change, but then had a deeper look at the cleaner button's handler:
click: function () {
    if ($note.summernote('createRange').toString()) {
        var text = cleanText($note.summernote('createRange').toString(), options.cleaner.newline);
        $note.summernote('pasteHTML', text);
    } else {
        // var text=cleanText($note.summernote().text(),options.cleaner.newline);
        // That is the initial idea for the pull request: .text() returns nothing
        var text = cleanText($note.summernote('code'), options.cleaner.newline);
        $note.summernote('code', text);
    }

    // irrelevant to the issue notification part
}

What bothers me:
Competely different behavior if anything is selected by user and if nothing is selected. As well, there is a difference with pasting.
If some text is selected, then $note.summernote('createRange').toString() returns already plain text, well, bypassing the cleaner logic at all. The cleanText() call looks redundant, because it is called on already plain text. So, the main plugin's cleanText() is just not applied in this scenario. A solution could be getting a range's HTML string (but not sure, it is possible) instead of getting plain text.
If no text is selected, then cleanText() is called on, seems, correct .summernote('code') (assuming my fix is applied). This scenario looks correct.
So, there is behavior ambiguity.
Meanwhile, @StudioJunkyard, thank you for the nice plugin.

The latest push update using changes via @DaniilVeriga seems to have fixed things on me end. Open a new issue if the problem persists.


Issue 79 - Work reg. Trailers & Videos

@Naliath do comment :)

checking all the updates now, been working all day so didn't have the time before :)

Looks good :+1:

Merge it in. Heading out :D

Done


Feature proposal: Allow divider to be a component too

For array.map operations inside a Stack it would be nice if the divider could also be a component that is rendered instead of the default line.

@pke 👋 thanks for the suggestion! I have added the divider prop in v1.3.0, it allows adding a custom divider. You can see more in the documentation: https://mobily.github.io/stacks/docs/components/stack


Add default_locale details to readme

It took me a little while to work out why all my fields had no content, this documents the reason why.

I had this issue too - when working primarily in en-GB it took ages to figure out that it was defaulting to en-US.


LineChart crashes when not supplied with borderRadius style

Should use a sensible default (0) here.

@N1ghtly did you fixed it?


Setting up Own Server to Host a Matchbox Server

I am using my own server to host a matchbox server and I tried to change it from only working locally to working globally.
I tested it with my public IP address and a forwarded port, but it doesn't seem to work. The peers are able to connect to the server (see logs below), but it isn't able to establish a proper connection.
Note that I am testing with one peer on the same local network as the server and one peer on a remote network.
When I have both peers in the local network things work fine. They connect without issue and my game plays like it did before.
I didn't test to have both peers be remote, but if that is gonna work I am gonna lose it.
In the following <IP_ADDRESS> is my public IP address.
Both ports 2124 and 3536 have been forwarded.
Game Logs
The logs of the different network parties.
Matchbox Server Log
my-server$ matchbox_server <IP_ADDRESS>:2124
2023-10-21T09:47:12.439671Z  INFO Matchbox Signaling Server: <IP_ADDRESS>:2124
2023-10-21T09:47:17.469757Z  INFO Client connected <IP_ADDRESS>:22895: PeerId(30b14bd8-3a85-470d-8dd8-ce9365ce4ac2)
2023-10-21T09:47:18.863468Z  INFO Client connected <IP_ADDRESS>:42516: PeerId(fae1d11e-307c-4cfa-92b3-8054264e724c)
2023-10-21T09:47:18.863806Z  INFO 30b14bd8-3a85-470d-8dd8-ce9365ce4ac2 -> "{\"NewPeer\":\"fae1d11e-307c-4cfa-92b3-8054264e724c\"}"
2023-10-21T09:49:28.452442Z  WARN Unrecoverable error with PeerId(30b14bd8-3a85-470d-8dd8-ce9365ce4ac2): Axum(Error { inner: Protocol(ResetWithoutClosingHandshake) })
2023-10-21T09:49:28.452512Z  INFO Removing peer: PeerId(30b14bd8-3a85-470d-8dd8-ce9365ce4ac2)
2023-10-21T09:49:28.452760Z  INFO Sent peer remove to: PeerId(fae1d11e-307c-4cfa-92b3-8054264e724c)
2023-10-21T09:49:30.293243Z  WARN Unrecoverable error with PeerId(fae1d11e-307c-4cfa-92b3-8054264e724c): Axum(Error { inner: Protocol(ResetWithoutClosingHandshake) })
2023-10-21T09:49:30.293344Z  INFO Removing peer: PeerId(fae1d11e-307c-4cfa-92b3-8054264e724c)

Local Peer Log
Both of the peer logs are practically identical (from what I can tell).
2023-10-21T09:47:18.858288Z  INFO ace_of_the_heavens::network::session: connection to matchbox server: ws://<IP_ADDRESS>:2124/
2023-10-21T09:47:18.899220Z  INFO webrtc::peer_connection: signaling state changed to have-remote-offer
2023-10-21T09:47:18.899285Z  INFO webrtc_ice::mdns: mDNS is using <IP_ADDRESS>:5353 as dest_addr
2023-10-21T09:47:18.899540Z  INFO webrtc_mdns::conn: Looping and listening Ok(<IP_ADDRESS>:5353)
2023-10-21T09:47:18.899827Z  INFO webrtc_ice::agent::agent_internal: [controlled]: Setting new connection state: Checking
2023-10-21T09:47:18.899865Z  INFO webrtc::peer_connection: ICE connection state changed: checking
2023-10-21T09:47:18.899887Z  WARN webrtc_ice::agent::agent_internal: [controlled]: pingAllCandidates called with no candidate pairs. Connection is not possible yet.
2023-10-21T09:47:18.899915Z  INFO webrtc::peer_connection: signaling state changed to stable
2023-10-21T09:47:18.900103Z  WARN webrtc_ice::agent::agent_internal: [controlled]: pingAllCandidates called with no candidate pairs. Connection is not possible yet.
2023-10-21T09:47:18.900486Z  WARN webrtc_ice::agent::agent_gather: [controlled]: could not listen udp fd::: io error: Cannot assign requested address (os error 99)
2023-10-21T09:47:18.900522Z  WARN webrtc_ice::agent::agent_gather: [controlled]: could not listen udp fe:80::: io error: Cannot assign requested address (os error 99)
2023-10-21T09:47:18.900615Z  WARN webrtc_ice::agent::agent_internal: [controlled]: pingAllCandidates called with no candidate pairs. Connection is not possible yet.
2023-10-21T09:47:18.900739Z  WARN webrtc_ice::agent::agent_internal: [controlled]: pingAllCandidates called with no candidate pairs. Connection is not possible yet.
2023-10-21T09:47:18.912168Z  WARN webrtc_ice::agent::agent_gather: [controlled]: could not get server reflexive address udp6 stun:stun.l.google.com:19302: io error: Network is unreachable (os error 101)
2023-10-21T09:47:18.913876Z  WARN webrtc_ice::agent::agent_gather: [controlled]: could not get server reflexive address udp6 stun:stun1.l.google.com:19302: io error: Network is unreachable (os error 101)
2023-10-21T09:47:48.989217Z  WARN webrtc_ice::agent::agent_internal: [controlled]: Failed to close candidate udp4 host <IP_ADDRESS>:57187: the agent is closed
2023-10-21T09:47:48.989243Z  WARN webrtc_ice::agent::agent_internal: [controlled]: Failed to close candidate udp4 host <IP_ADDRESS>:34060: the agent is closed
2023-10-21T09:47:48.989251Z  WARN webrtc_ice::agent::agent_internal: [controlled]: Failed to close candidate udp4 srflx <IP_ADDRESS>:27431 related <IP_ADDRESS>:54440: the agent is closed
2023-10-21T09:47:48.989262Z  WARN webrtc_ice::agent::agent_internal: [controlled]: Failed to close candidate udp4 srflx <IP_ADDRESS>:28872 related <IP_ADDRESS>:40121: the agent is closed
2023-10-21T09:47:48.989271Z  WARN webrtc_ice::agent::agent_internal: [controlled]: Failed to close candidate udp6 host :::46363: the agent is closed
2023-10-21T09:47:48.989280Z  INFO webrtc_ice::agent::agent_internal: [controlled]: Setting new connection state: Failed
2023-10-21T09:47:48.989321Z  INFO webrtc::peer_connection: ICE connection state changed: failed
2023-10-21T09:47:48.989331Z  INFO webrtc::peer_connection: peer connection state changed: failed

Note that after this point nothing happens anymore. I let it run for some minutes but nothing happend on either client or server side.
Remote Peer Log
2023-10-21T09:47:17.398532Z  INFO ace_of_the_heavens::network::session: connection to matchbox server: ws://<IP_ADDRESS>:2124/
2023-10-21T09:47:18.872610Z  INFO webrtc_ice::mdns: mDNS is using <IP_ADDRESS>:5353 as dest_addr
2023-10-21T09:47:18.872823Z  INFO webrtc_mdns::conn: Looping and listening Ok(<IP_ADDRESS>:5353)
2023-10-21T09:47:18.873005Z  INFO webrtc::peer_connection: signaling state changed to have-local-offer
2023-10-21T09:47:18.873150Z  WARN webrtc_ice::agent::agent_gather: [controlled]: could not listen udp fe:80::: io error: Cannot assign requested address (os error 99)
2023-10-21T09:47:18.903003Z  WARN webrtc_ice::agent::agent_gather: [controlled]: could not get server reflexive address udp6 stun:stun.l.google.com:19302: io error: Network is unreachable (os error 101)
2023-10-21T09:47:18.904533Z  WARN webrtc_ice::agent::agent_gather: [controlled]: could not get server reflexive address udp6 stun:stun1.l.google.com:19302: io error: Network is unreachable (os error 101)
2023-10-21T09:47:18.910266Z  INFO webrtc::peer_connection: signaling state changed to stable
2023-10-21T09:47:18.910381Z  INFO webrtc_ice::agent::agent_internal: [controlling]: Setting new connection state: Checking
2023-10-21T09:47:18.910454Z  INFO webrtc::peer_connection: ICE connection state changed: checking
2023-10-21T09:47:18.910478Z  WARN webrtc_ice::agent::agent_internal: [controlling]: pingAllCandidates called with no candidate pairs. Connection is not possible yet.
2023-10-21T09:47:48.955580Z  WARN webrtc_ice::agent::agent_internal: [controlling]: Failed to close candidate udp4 host <IP_ADDRESS>:33784: the agent is closed
2023-10-21T09:47:48.955600Z  WARN webrtc_ice::agent::agent_internal: [controlling]: Failed to close candidate udp4 host <IP_ADDRESS>:58126: the agent is closed
2023-10-21T09:47:48.955605Z  WARN webrtc_ice::agent::agent_internal: [controlling]: Failed to close candidate udp4 host <IP_ADDRESS>:40218: the agent is closed
2023-10-21T09:47:48.955609Z  WARN webrtc_ice::agent::agent_internal: [controlling]: Failed to close candidate udp4 srflx <IP_ADDRESS>:36014 related <IP_ADDRESS>:36014: the agent is closed
2023-10-21T09:47:48.955612Z  WARN webrtc_ice::agent::agent_internal: [controlling]: Failed to close candidate udp4 srflx <IP_ADDRESS>:37775 related <IP_ADDRESS>:37775: the agent is closed
2023-10-21T09:47:48.955616Z  WARN webrtc_ice::agent::agent_internal: [controlling]: Failed to close candidate udp6 host :::40618: the agent is closed
2023-10-21T09:47:48.955619Z  INFO webrtc_ice::agent::agent_internal: [controlling]: Setting new connection state: Failed
2023-10-21T09:47:48.955650Z  INFO webrtc::peer_connection: ICE connection state changed: failed
2023-10-21T09:47:48.955656Z  INFO webrtc::peer_connection: peer connection state changed: failed

Debuggin with Curl
I also tried to curl the server with both local and remote. In both cases I got the same (positive) result.
Note that I am using a different port here, but both have been forwarded in the same manner.
I also tried the 3536 port in the game and it got me the same results.
Local Curl Log
local-peer$ curl -i -N -H "Connection: Upgrade" -H "Upgrade: websocket" -H "Sec-WebSocket-Version: 13" -H "Sec-WebSocket-Key: 21" "http://<IP_ADDRESS>:3536"
HTTP/1.1 101 Switching Protocols
connection: upgrade
upgrade: websocket
sec-websocket-accept: I/NEPdKfVBOgESWYT1P625pwr6s=
date: Sat, 21 Oct 2023 10:03:18 GMT

�5{"IdAssigned":"303d3925-8aaa-44a5-9b27-df04300322c7"}

Remote Curl Log
remote-peer$ curl -i -N -H "Connection: Upgrade" -H "Upgrade: websocket" -H "Sec-WebSocket-Version: 13" -H "Sec-WebSocket-Key: 21" "http://<IP_ADDRESS>:3536"
HTTP/1.1 101 Switching Protocols
connection: upgrade
upgrade: websocket
sec-websocket-accept: I/NEPdKfVBOgESWYT1P625pwr6s=
date: Sat, 21 Oct 2023 10:06:49 GMT

5{"IdAssigned":"704906c1-40ac-41e1-9e68-ca396e46ce24"}

I have also a dummy HTML script on the server and have forwarded port 80 and I can successfully curl the html.index file. That's why I highly doubt that port forwarding is the issue.

I tested two more things:
Peers on the same Remote Network
This was successful! I had two peers on the same remote network connecting to the server. This worked without any issues.
Peers on different Remote Networks
This gave me the same errors as the attempt above.

I think that sometimes, it's just not possible to pierce through specific routers, setups, and you have to resort to a relay server (TURN).
You could try a couple of webrtc test sites and see if they successfully get a direct connection, between the peers you have trouble with, if they do, then it's hopefully something we can fix on our end.

Ah okay I see, that is actually kinda good news to me. I was a little but under the suspicion that you need more then the matchbox server to facilitate proper online signaling, but the server as it is right now is sufficient to connect peers across different networks? Running the matchbox server on a server with properly forwarded ports should be all you need to do in order for peers to connect to it, right?
I will definitely try out the webrtc tests, might me something with my router, though I also tested the connection of two peers on two different mobile data (using a hotspot) and that also didn't work. I also tested some other matchbox servers besides mine and got the same results, so who knows, will run those tests now. Thanks for your help, very much appreciated :+1:

Running the matchbox server on a server with properly forwarded ports should be all you need to do in order for peers to connect to it, right?

No, there are cases where webrtc on stun alone can't get a direct connection. You'll have to configure it with a TURN server. Those usually require some kind of authentication, otherwise people could exploit it as "free" service.
This is the API you need to use: https://docs.rs/matchbox_socket/latest/matchbox_socket/struct.RtcIceServerConfig.html
You could use xirsys.net free tier for testing development with a turn server, or run an instance of coturn if you have a place to easily/cheaply run docker containers.

Ahh okay I see, that makes a lot of sense. I will have a look at that.

EDIT: And sorry this isn't more clearly explained in the docs... Ideally, we'd have an example that uses TURN with a captcha or something.

No worries, glad you took your time to help me out :)

It works now 🎉
I had to setup a TURN server which I struggled a little bit with. In future versions this will be easier, but there are some pitfalls right now. More info in https://github.com/PraxTube/ace-of-the-heavens/issues/32.

@PraxTube Congrats. If any ways we can improve matchbox, please submit issues. Big picture items for TURN servers.

Thanks <3. It's mostly that there are some bugs that are already fixed in main but aren't in the latest version yet. So you either have to use main or create a fork with the necessary PR merged into it. If I find any ways to improve this project, I will of course report them :+1:


⚠ Samsung has degraded performance

In c5514f0, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2544 ms

Resolved: Samsung performance has improved in 9b146cc.


i need to change my fps how tho?

https://github.com/pizzaboxer/bloxstrap/blame/fd26e4d86889723770922e557c9c3e45466bb51a/Bloxstrap/Models/FastFlag.cs#L3

What? Use the config options provided in the Bloxstrap Menu.


Verify that all required properties are included in OpenAPI specifications being read.

The OpenAPI schema indicates that some of the properties of many object types are required. Enhance the compiler to verify that these required properties are present and if not, provide specific error messages indicating what properties should be added.

Verified with unit tests in this commit


Width of table of contents

With longer class names the line breaks reduce readability, because there is no separating element between classes. A solution would either be to increase the width of the table of contents or add a visual separation between the class names.

Also, some kind of sorting would be nice...

Yep, I see this issue myself in some of my ontologies. I'll try and actually put some effort in here shortly!


Synchronize warming the reflection cache

In addition, we should have been checking for KVisibility == PUBLIC not isAccessible. As is, the second part of the reflection warming was filtering out all properties.
Here is a benchmark in which I switched from FlowViewModel in which I added 80 @PersistState properties to another app and back several times with background processes turned off
without declaredMemberProperties warming:
06-14 08:05:05.240  5295  5344 D Gabe    : persistState: 21
06-14 08:05:05.308  5295  5295 D Gabe    : persistState: 7
06-14 08:05:09.341  5390  5431 D Gabe    : persistState: 32
06-14 08:05:12.328  5390  5390 D Gabe    : persistState: 7
06-14 08:05:16.948  5484  5517 D Gabe    : persistState: 28
06-14 08:05:19.604  5484  5484 D Gabe    : persistState: 4
06-14 08:05:24.098  5569  5599 D Gabe    : persistState: 37
06-14 08:05:24.568  5569  5569 D Gabe    : persistState: 5
06-14 08:05:28.866  5652  5682 D Gabe    : persistState: 16
06-14 08:05:29.542  5652  5652 D Gabe    : persistState: 5
06-14 08:05:34.043  5736  5769 D Gabe    : persistState: 21

with declaredMemberProperties warming:
06-14 08:05:50.617  5865  5916 D Gabe    : persistState: 5
06-14 08:05:50.670  5865  5865 D Gabe    : persistState: 8
06-14 08:05:54.826  5971  6004 D Gabe    : persistState: 9
06-14 08:05:54.981  5971  5971 D Gabe    : persistState: 3
06-14 08:05:59.318  6067  6100 D Gabe    : persistState: 5
06-14 08:05:59.811  6067  6067 D Gabe    : persistState: 5
06-14 08:06:03.791  6149  6185 D Gabe    : persistState: 9
06-14 08:06:04.899  6149  6149 D Gabe    : persistState: 4
06-14 08:06:10.128  6235  6265 D Gabe    : persistState: 5
06-14 08:06:15.794  6318  6351 D Gabe    : persistState: 6

Fixes #231

Were you be able to check if this fixes the crash mentioned in #231? Our app starts to crash when R8/Proguard is enabled and I suspect it is because of this change.
I wonder if it is possible to make this change configurable? Users would enable it if they have reflection based performance issues with their usage.

@tasomaniac at Tonal, we're on 1.0.2 and we haven't seen the crash since so I'm going to say that it probably does but I can't say 100% since it's not easily reproducible.
I think every app will have reflection based performance issues since kotlin-reflect init is slow. There is probably a way to fix the R8 issue while leaving this intact. Could you try and get the mvrx sample app to crash by adding R8?
@rossbacher @BenSchwab Any chance you can help out with this as well? It'll block Airbnb from upgrading.


Galaxy S4 User Agent - "Unknown/unsupported"

The Galaxy S4 on Chrome 34 and Android 5 resulted in an "Unknown/Unsupported status from Polyfill.io. Exact message returned at this URL was:
/* Polyfill service v3.12.1
 * For detailed credits and licence information see http://github.com/financial-times/polyfill-service.
 *
 * UA detected: samsung_mob/2.1.0 (unknown/unsupported; using policy `unknown=ignore`)
 * Features requested: String.prototype.includes
 *
 * Version range for polyfill support in this family is: >=4
 *  */

User agent: Mozilla/5.0 (Linux; Android 5.0.1; SAMSUNG SCH-I545 4G Build/LRX22C) AppleWebKit/537.36 (KHTML, like Gecko) SamsungBrowser/2.1 Chrome/34.0.1847.76 Mobile Safari/537.36
I've updated my unknown policy to polyfill to meet these edge cases, but I just wanted to know if this was an error, or if there was some reason GS4 wasn't supported. Thanks!

It seems to be detected as samsung's browser and at a version we don't support.
The useragent you posted looks very similar to this useragent which is from a different Samsung Galaxy S4 and it's samsung browser.
Mozilla/5.0 (Linux; Android 5.0.1; SAMSUNG GT-I9506-ORANGE Build/LRX22C) AppleWebKit/537.36 (KHTML, like Gecko) SamsungBrowser/2.1 Chrome/34.0.1847.76 Mobile Safari/537.36

If you are certain you were using chrome for android and not samsung browser then this looks to be a bug in the useragent module we use. It would need to be fixed in the uap-core project which provides the regex to the useragent module. uap-core matches samsung browser before it matches chrome mobile, making a fix for this a little bit tricky.

I'm not 100% sure it's Chrome for Android, I was just going off of our @getsentry logs which detected this as Chrome 34 (not sure what they use for this detection); you are probably right. Thanks for the help!


Failing unit tests on clean master

Describe the bug
I cloned the project and ran npm run test on master and received the below errors.

Chokidar 3.6.0 #7c50e25d10a497ce4409f6e52eb630f0d7647b97
Node v18.19.1
macOS 14.2.1

To Reproduce:
git clone https://github.com/paulmillr/chokidar
cd chokidar
npm i
npm run test

Expected behavior
Tests should pass, right?
Additional context
Test output, trimmed. I'll attach the full results as a file.
chokidar-unit-test-failure.txt
  6 failing

  1) chokidar
       fsevents (native extension)
         watch symlinks
           should survive ENOENT for missing symlinks when followSymlinks:false:
     AssertionError: expected spy to have been called exactly twice, but it was called thrice
    spy('addDir', '/Users/samuelneff/projects/chokidar/test-fixtures/49/subdir', ...) at FSWatcher.emit (node:events:517:28)
    spy('add', '/Users/samuelneff/projects/chokidar/test-fixtures/49/subdir/add.txt', ...) at FSWatcher.emit (node:events:517:28)
    spy('add', '/Users/samuelneff/projects/chokidar/test-fixtures/49/subdir/broken', ...) at FSWatcher.emit (node:events:517:28)
      at Context.<anonymous> (test.js:1200:28)

  2) chokidar
       fsevents (native extension)
         watch symlinks
           should watch symlinks within a watched dir as files when followSymlinks:false:
     AssertionError: expected spy to not have been called with arguments 'add', '/Users/samuelneff/projects/chokidar/test-fixtures/50/link/add.txt'
      at Context.<anonymous> (test.js:1220:32)
      at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

  3) chokidar
       fsevents (native extension)
         reproduction of bug in issue #1024
           should detect changes to symlink folders, even if they were deleted before:

      AssertionError: expected [ …(2) ] to deeply equal [ …(5) ]
      + expected - actual

       [
         "[ALL] addDir: test-fixtures/110/test-link"
         "[ALL] addDir: test-fixtures/110/test-link/dir"
      +  "[ALL] unlinkDir: test-fixtures/110/test-link/dir"
      +  "[ALL] addDir: test-fixtures/110/test-link/dir"
      +  "[ALL] add: test-fixtures/110/test-link/dir/file"
       ]

      at Context.<anonymous> (test.js:2182:21)

  4) chokidar
       fs.watch (non-polling)
         watch individual files
           should detect safe-edit:
     AssertionError: expected spy to have been called exactly thrice, but it was called once
    spy('change', '/Users/samuelneff/projects/chokidar/test-fixtures/138/change.txt', ...)
      at Context.<anonymous> (test.js:637:57)
      at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

  5) chokidar
       fs.watch (non-polling)
         reproduction of bug in issue #1024
           should detect changes to symlink folders, even if they were deleted before:

      AssertionError: expected [ …(2) ] to deeply equal [ …(5) ]
      + expected - actual

       [
         "[ALL] addDir: test-fixtures/223/test-link"
         "[ALL] addDir: test-fixtures/223/test-link/dir"
      +  "[ALL] unlinkDir: test-fixtures/223/test-link/dir"
      +  "[ALL] addDir: test-fixtures/223/test-link/dir"
      +  "[ALL] add: test-fixtures/223/test-link/dir/file"
       ]

      at Context.<anonymous> (test.js:2182:21)

  6) chokidar
       fs.watchFile (polling)
         reproduction of bug in issue #1024
           should detect changes to symlink folders, even if they were deleted before:

      AssertionError: expected [ …(2) ] to deeply equal [ …(5) ]
      + expected - actual

       [
         "[ALL] addDir: test-fixtures/336/test-link"
         "[ALL] addDir: test-fixtures/336/test-link/dir"
      +  "[ALL] unlinkDir: test-fixtures/336/test-link/dir"
      +  "[ALL] addDir: test-fixtures/336/test-link/dir"
      +  "[ALL] add: test-fixtures/336/test-link/dir/file"
       ]

      at Context.<anonymous> (test.js:2182:21)

I'm looking at the tests now to see if I can resolve them. Are they expected to pass on master right now?

no, they are expected to fail

Thanks for confirming.

#1305

@paulmillr Are they expected to fail in that they were designed that way or in that they are not working right now? Should I look into addressing them? The failures seem a bit inconsistent--some tests fail intermittently.

They should not fail.
#413, #923, #1006


Add missing var

This actually caused a problem for me in my strict build environment. I would get key is not defined.

I'm cleaning up my open PRs, if this isn't merged soon I will close it


Including CWE information

closes #612
This PR includes CWE mappings for every vulnerability.

Thanks a lot @ericwb for your review 👍
I addressed your comments by replacing the integer parameters for the CWEs with variables; I have also integrated a Cwe class and added the url as meta-data. The class will make it easier to add more CWE meta-data in future if needed. In addition, I have linked the issue that corresponds to this PR.

@julianthome Thank you! Bug what about B301-B323, B325, B401-B413,B504, B603-B607 ?

@julianthome Thank you! Bug what about B301-B323, B325, B401-B413,B504, B603-B607 ?

Thanks for you response @dvyakimov. Yes, thanks for pointing this out. Going to update the MR soon 👍

This is an awesome improvement. Looking forward to using this soon!

@dvyakimov I changed the MR according to your and @prabhu's comment. I put all the CWE mappings into a separate file cwemap.py to simplify the book-keeping.
I suppose the MR is ready for another round of review.

Any thoughts on this PR? @ericwb @dvyakimov ?

@ericwb @dvyakimov. Could you have another look at this PR?

Can this PR be merged? I looked over it and could not see any major issues.

Just wanted to ask whether someone could have another look at this PR? Maybe @ericwb?

Just merged master @sigmavirus24 @ericwb @lukehinds @ghugo. As all the requested changes are addressed, it would be awesome if one of you could have another look at this PR?

Just merged master @sigmavirus24 @ericwb @lukehinds @ghugo. As all the requested changes are addressed, it would be awesome if one of you could have another look at this PR?


FIX define_i18n_url_helper with Rails 4.2

Hi,
I just discovered that this gem wasn't working anymore with Rails 4.2.
I figured out that the problem was that the @module variable isn't present anymore in ActionPack NamedRouteCollection class. There is now two separated variables.
Regards,
Steve

Any news on this ?

I'm sorry for the delay, I will check the merge today.

I notice was all green because travis was not testing against rails 4.2, there were some others thing broken, I just fix those.
Feel free to open an issue if you find something else not working problem.


KOGITO-4436: Allow component to be embedded in a div as an alternative to the iframe

Out of interest; how will this work? The BC legacy editors inject a ton of resources into the IFRAME's document; which presumably is not possible when using the DIV. I am just curious.

@manstis Baby steps, Michael!!
Just kidding :)
This PR is a first step towards a very sophisticated way of loading and sharing modules among different components. This first version does not do any of that, of course. This PR is allowing components (Kogito Views) to be embedded on an simple div and not know about it, since the whole communication remains done through our Channel/Enveope abstraction.
The changes @paulovmr did are infrasctructure-related and will not be used in DMN/BPMN/SceSim/PMML Editors for now. Although, at least the way I see it, the PMML Editor could be a very good first candidate, given its dependencies on React and PatternFly 4, which are already present at the Online Editor.
Anyways, hope that helps!
@paulovmr can give more details about the intrincacies of the code.

@manstis I believe @tiagobento already explained most of it. Basically this PR improves the message routing between components. With the iframe, we only had to worry about sending and receive messages using the window scope. Once we have multiple components in the same window, we need to track the messages destinations and only process them in the targeted component.


Suggestion: Add support for general assembly

I noticed that EnlighterJS supports AVR-Assembly. I would like to suggest that assembly for the 8051 or general assembly syntax be added to EnlighterJS (unless the "avrasm" shortcode in the WordPress plugin already covers that).
By the way, I know JavaScript. How could I contribute by adding support for various programming languages?

Dear Devyn,
is there any general language-reference (keywords, commands) available for assembly code ?
i thought it is platform/compiler depending ?
To develope language "addons" for EnlighterJS you can take a look into the following files

Source/Language/Template.mylang.js (Demo Language implentation used as entry point)
LanguageDevelopment.phtml (General Language Development Environment, requires a local webserver)

best regards, Andi

There are some forms of assembly that use different syntax and commands. However, 8051 assembly is used by numerous devices (mostly embedded), and many related forms of assembly use most of the same commands. Here is the instruction set and syntax - https://en.wikipedia.org/wiki/Intel_MCS-51#Instruction_set
Thanks for the info. By the way, I thought EnlighterJS supported HTML, but I am not seeing the file in https://github.com/AndiDittrich/EnlighterJS/tree/master/Source/Language . I am wanting to add MathML to the HTML template (MathML is included in the W3C HTML5 standard).

By the way, if I added support for Cython (an implementation of Python), should I make it its own file or in the Python file since Cython and Python share most of the same keywords?

The HTML language is an alias for XML. But im currently working on EnlighterJS v3 which includes a new tokenizer engine with major (incompatible changes) which means that especally the XML/HTML language will change completely.
in case a language is a superset of another you should create a own file which extends the origin language. For example https://github.com/AndiDittrich/EnlighterJS/blob/master/Source/Language/Less.js

Okay, thank you for the help and info. I look forward to adding additional language support

i've just added general assembly language support as well as some avr assembly improvements.
feel free to try it out.

Excellent! I look forward to seeing this in the next WordPress plugin update.


Questions regarding changes to yolo plugin

Hi, I'm trying to update the yolo plugin in https://github.com/isarsoft/yolov4-triton-tensorrt to a more recent version with your fixes to batchsize and updates to compatiblity etc.
Could you briefly explain a few changes that you made to the plugin in comparison to the original from tensorrtx?

Input for the yolo layer plugin originally was "all output conv" layers, but now seems to be just one conv layer? So for example the full yolov4 network now needs three instances of the plugin instead of one? And also the output is three marked blobs instead of just one, correct?
Original implementation had MAX_OUTPUT_BBOX_COUNT how did you handle this change regarding output size etc?
What's input_multiplier for? I found input_multiplier = w // yolo_whs[i][0]. So this is just to not pass input_width and input_height? It could be calculated if the plugin knew those values?
You reduced int mThreadCount = 256; to int mThreadCount = 64;, is there a performance reason for this?

Thanks already for all those great fixes to the plugin, really helpful.
Could you very briefly explain other changes that you made to  the plugin that you think would be significant enough to mention?

Input for the yolo layer plugin originally was "all output conv" layers, but now seems to be just one conv layer? So for example the full yolov4 network now needs three instances of the plugin instead of one? And also the output is three marked blobs instead of just one, correct?

Yes. I would add 2 or 3 (or more) yolo plugins into the network depending on how many output conv layers there are.  The code is here: https://github.com/jkjung-avt/tensorrt_demos/blob/af878962d27af457f886225e5d51ee2f01fa7afb/yolo/plugins.py#L82-L83

Original implementation had MAX_OUTPUT_BBOX_COUNT how did you handle this change regarding output size etc?

I don't set an upper limit on output bbox count.  All detection boxes with "scores" higher than the threshold would be kept.  They would go through NMS before the final detection results are generated.  The relevant code is here: https://github.com/jkjung-avt/tensorrt_demos/blob/af878962d27af457f886225e5d51ee2f01fa7afb/utils/yolo_with_plugins.py#L100-L101

What's input_multiplier for? I found input_multiplier = w // yolo_whs[i][0]. So this is just to not pass input_width and input_height? It could be calculated if the plugin knew those values?

Yes, I pass the particular information to the plugin as 1 single value instead of 2.  This is to avoid a problem as described here: https://github.com/NVIDIA/TensorRT/issues/238.  TensorRT plugin code seems to handle pluginField values incorrectly if there are too many of them.

You reduced int mThreadCount = 256; to int mThreadCount = 64;, is there a performance reason for this?

Lower-end Jetson SoCs, such as TX2 and Nano, have only 256 GPU cores in total.  I don't want the yolo plugin to occupy all GPU cores in such systems (i.e. trying to keep some GPU cores available for processing other TensorRT OPs/kernels in parallel).  However, based on my own tests, it doesn't seem to make much difference (between 64 and 256).

Thanks for the answers, they make perfect sense.

Hi @jkjung-avt
Have to bother you again, sorry. I only now realised that your plugin was different from the one in tensorrtx from the very beginning in that it does not compute Logistic Activation. Can you confirm that I have to do Logistic Activation in the last Convolutional Layer before the Yolo Layer myself? Is there anything else that I have to apply to the inputs?

For "yolov4-tiny" and "yolov4" models, the conv layers proceeding yolo layers are with "linear" activation, e.g. yolov4.cfg
```
[convolutional]
size=1
stride=1
pad=1
filters=255
activation=linear
```

In this case, my yolo plugin would calculate "sigmoid" on the input values.  Refer to code here: https://github.com/jkjung-avt/tensorrt_demos/blob/58ad1e9c58af2c8f86a3053a388ee0ef5ca286a5/plugins/yolo_layer.cu#L230-L231
In contrast, "yolov4-csp" and "yolov4x-mish" models would have those conv layers with "logistic" activation, e.g. yolov4x-mish.cfg
```
[convolutional]
size=1
stride=1
pad=1
filters=255
activation=logistic
```

So in this latter case, I don't need to calculate "sigmoid" in the plugin code: https://github.com/jkjung-avt/tensorrt_demos/blob/58ad1e9c58af2c8f86a3053a388ee0ef5ca286a5/plugins/yolo_layer.cu#L288
In case you are interested in reading the code which handles different types of conv activations, check here: https://github.com/jkjung-avt/tensorrt_demos/blob/58ad1e9c58af2c8f86a3053a388ee0ef5ca286a5/yolo/yolo_to_onnx.py#L699

Yes I only now realised that sigmoid and logistic are practically the same thing. I'm using the TensorRT Layer API (as in tensorrtx) but for converting weights I have to use the python ScaledYolov4 Repo. And there seem to be minor differences in the cfg files of the Python Implementation and Darknet which is VERY annoying.
Starting with this:
https://github.com/WongKinYiu/ScaledYOLOv4/issues/202#issuecomment-810913378
And also this:
https://github.com/WongKinYiu/ScaledYOLOv4/issues/202#issuecomment-810917873
And furthermore this (route layer versus route_lhalf):
https://github.com/WongKinYiu/ScaledYOLOv4/issues/165
I guess I'll have to check all implementations for differences...

I'm currently trying to implement yolov4-tiny from here: https://github.com/tjuskyzhang/Scaled-YOLOv4-TensorRT/tree/master/yolov4-tiny-tensorrt
But using your plugin. With little success.

I believe I need to add a Sigmoid Activation function and use new_coords. I will check that out. Thanks for the help jkjung.

Nevermind.... yolov4-tiny does not use anchor 0....
https://github.com/hunglc007/tensorflow-yolov4-tflite/issues/111#issuecomment-650205659
That fixed it...


[beta] backport remove --host flag

This is a beta backport of #10327.  I would feel more comfortable having the complete fix for #10145 since the deprecation notice was removed in that PR.

r? @alexcrichton
(rust-highfive has picked a reviewer for you, use r? to override)

:warning: Warning :warning:

Pull requests are usually filed against the master branch for this repo, but this one is against rust-1.59.0. Please double check that you specified the right target!

@bors: r+

:pushpin: Commit 83b3e3573accf10a78c7b0464be831ff941dcbe9 has been approved by alexcrichton

:sunny: Test successful - checks-actions
Approved by: alexcrichton
Pushing 5ad495c6839f34ead56177829575da443d3e01d0 to rust-1.59.0...


MigPlan: Validation should check whether registry pods are healthy

Describe the bug
I had CAM 1.2.4 installed on my source cluster. I upgraded to 1.2.5 by only deleting the migration operator pod, and left the metadata untouched in the operator deployment. The REGISTRY_IMAGE value was set to an older image tag which is no longer available in RH container catalog. As a result, after creation of migplan, the registry pods did not come up and were stuck in ImagePullBackOff. However, that didn't stop MigPlan from becoming Ready. Unaware of the issue, I created a migmigration and it failed at InitialBackupFailed phase reporting PartiallyFailed error on the backup object. There were no obvious errors in the Velero log. It took me significant amount of time to reach to the actual cause of the issue.
To Reproduce
You can simulate the failure by deliberately setting REGISTRY_IMAGE value to something non-existent.
Steps to reproduce the behavior:

Edit mig-operator deployment on the source cluster, and set environment variable MIGRATION_REGISTRY_TAG to 0ae610db4f73b6a5353c4821165bd60a8c4e86ac5ba5f1d60cd532f5bcd814bd
Run a migration.

Expected behavior
I'd expect either of these two behaviours to happen:

MigPlan validation fails and the plan shows NotReady condition
OpenShift velero plugin handles this failure more gracefully and shows a relevant error message in the status or logs

@pranavgaikwad I think this plays into the work with the registry readiness/health check @shubham-pampattiwar and I are looking into this sprint

This has been fixed.


what about babel@^7 support

hey,
looks like jest-preset-coffeescript does not work with 7th version of babel
config:
  "jest": {
    "preset": "jest-preset-coffeescript",
    "testRegex": "test\\.(coffee|litcoffee|coffee.md)$"
  },

error:
 FAIL  utils/iterator.test.coffee
  ● Test suite failed to run

    [BABEL] unknown: Plugin/Preset files are not allowed to export objects, only functions.

      at createDescriptor (node_modules/@babel/core/lib/config/option-manager.js:466:11)
      at node_modules/@babel/core/lib/config/option-manager.js:173:12
          at Array.map (<anonymous>:null:null)
      at node_modules/@babel/core/lib/config/option-manager.js:172:48
      at cachedFunction (node_modules/@babel/core/lib/config/caching.js:40:17)
      at node_modules/@babel/core/lib/config/option-manager.js:90:14
          at Array.map (<anonymous>:null:null)
      at OptionManager.mergeConfigChain (node_modules/@babel/core/lib/config/option-manager.js:89:43)
      at OptionManager.init (node_modules/@babel/core/lib/config/option-manager.js:114:12)
      at manageOptions (node_modules/@babel/core/lib/config/option-manager.js:33:30)
      at loadConfig (node_modules/@babel/core/lib/config/index.js:15:37)
      at transformSync (node_modules/@babel/core/lib/transform-sync.js:13:36)
      at Object.transform (node_modules/@babel/core/lib/transform.js:20:65)
      at CoffeeScript.transpile (node_modules/coffeescript/lib/coffeescript/index.js:26:18)
      at Object.<anonymous> (node_modules/coffeescript/lib/coffeescript/coffeescript.js:187:26)
      at Object.<anonymous> (node_modules/coffeescript/lib/coffeescript/coffeescript.js:54:19)
      at CoffeeScript.compile (node_modules/coffeescript/lib/coffeescript/index.js:41:29)
      at Object.exports.process (node_modules/jest-preset-coffeescript/index.js:17:36)
          at Generator.next (<anonymous>:null:null)
          at new Promise (<anonymous>:null:null)
          at Generator.next (<anonymous>:null:null)
          at <anonymous>:null:null
      at process._tickCallback (internal/process/next_tick.js:188:7)

Thanks @a-x-, I'll look into this as soon as I can…

Any updates on this?

CoffeeScript now indifferently uses Babel 6 or 7, so jest-preset-coffeescript also works but it forces install of Babel 6. It would be nice to upgrade to Babel 7 indeed.

jfyi, we started to move from coffee2 to es6+jsx+optional-chaining ;)
Thanks to decaffeinate (I use my forked version with re-enabled optional-chaining support)

And, may be you'll be interested in plugin for eslint that I initially created based on solution posted here
Community improved it even more:
https://www.npmjs.com/package/@fellow/eslint-plugin-coffee
We lived much better with eslint+coffee last year

I see JavaScript and even more TypeScript as a good choice for corporate people as it enforces standards and communication between teams.
As an independent developer for me CoffeeScript (with Floweret) is a better choice because it improves my productivity. :wink:

There was a CoffeeScript update (2.3.2) to support Babel 7, so I just updated dependencies and fixed a small issue that seemed to throw up… but it should be fully supported now.
@a-x- @laurentpayot @MicMonen CI passed obviously; but please test and confirm that it works. Thanks!

@danielbayley  Awesome. Will test on Monday.

@danielbayley Tests passed. Thanks for the update :+1:


Workstation docs update

Basic EESSI and podman documentation added in this patch.

Would be good to get this merged ASAP as the Azimuth UI currently says "See user docs for information on EESSI" etc. but the docs don't mention any of those things.


feature-flag: Remove/inline long-obsolete feature flags.

I remove/inline two feature flags dating back to 2013.
  It's pretty easy to remove the conditionals, including this chunk from the template:
 20     {{#if should_display_reminder_option}}
 21

 22
 23              {{t "Remind me about this" }}
 24
 25

 26     {{/if}}

Then the only reference to reminder_button is its click handler:
 919     $('body').on('click', '.reminder_button', function (e) {
 920         const message_id = $(e.currentTarget).data('message-id');
 921         exports.render_actions_remind_popover($(".selected_message .actions_hover")[0], message_id);
 922         e.stopPropagation();
 923         e.preventDefault();
 924     });

But then there's some related code related to remind.custom that we should probably also remove.

The reason that I want to kill off feature_flags altogether is that it tends to lead to bitrot, plus it's pretty trivial to resurrect if we ever want it again.
In the early days of this file (2013), most of the feature flags were (at least temporarily) truly conditional on some piece of data.  For example, we'd only set a particular feature flag to true for the MIT realm or one or two of our devs.
I think we've mostly outgrown those use cases.

Merged these two commits, they're great.  I think for reminders, that is in fact an unfinished feature.  We should probably just move it to a setting in zproject/default_settings.py like our other unfinished features that we have disabled by default, and maybe open an issue documenting that needs to happen to finish implementing that feature.


library target umd - Uncaught TypeError: x is not a constructor

Bug report
class Point {
    constructor(x, y) {
        this.x = x;
        this.y = y;
    }

    toString() {
        return `(${this.x}, ${this.y})`;
    }
}

export default Point;

const path = require('path');

module.exports = {
  entry: './src/index.js',
  output: {
    library: 'point',
    libraryTarget: 'umd',
    umdNamedDefine: true,
    path: path.resolve(__dirname, 'dist'),
    filename: 'bundle.js'
  }
};

so when i include in my index.html file like this:
<!DOCTYPE html>
<html>
<head>
    <title>Webpack</title>
</head>
<body>

    <!-- Scripts -->
    <script src="dist/bundle.js"></script>

    <script type="text/javascript">
        new point(1, 3).toString()
    </script>
</body>
</html>

so i have this error in console

"Uncaught TypeError: point is not a constructor"

why i'm seeing this error while compile with webpack?
same scenario working fine with rollup
and one more thing i saw almost every developer use rollup for es6 package development to compile "esm", "umd" versions of the script.
but i want to use webpack instead of rollup.
any guide?
thanks
Other relevant information:
webpack version: 4.27.1
Node.js version: 11.3.0
Operating System: Windows 10
Additional tools:

What's the value of point?
Could you try https://webpack.js.org/configuration/output/#output-libraryexport

@sokra it should show in console "(1, 3)" string.
same scenario working fine with rollup umd
i tried lot's of things but failed.

Try console.log(point) and check what it say. I assume is says { default: [Point] } and this can be changed with output.libraryExport: "default"

@sokra Thanks
webpack is rock!

I had the same error message and discovered that the cause was circular import statements. That is: I had two files that imported each other, wherein one file contained an export default class that contained a method that was dependent upon an export function from the other file. My solution was to move one of the dependencies (functions) out of the class and into a utils.js file, which was a more appropriate place for it anyway!

@the1abel I've been trying to debug this issue for a few hours now and your comment helped me resolve it. Thanks!


Defaults have to be capital

https://github.com/pact-foundation/pact-broker-chart/blob/b2e7a5de5c8323f4822190200af4f52510cc4fa9/charts/pact-broker/values.yaml#L75

@ChrisJBurns Does this mean that the defaults should all be uppercased? when they are passed in? Based on the pactbroker docs I read it seemed they should be lowercased

Ah, not sure why I felt they had to be uppercased. Closing


[firestore-semantic-search] queryIndex does not respect neighbors param

[READ] Step 1: Are you in the right place?
Yes.
[REQUIRED] Step 2: Describe your configuration

Extension name: firebase-semantic-search
Extension version: 0.1.7
Configuration values (redact info where appropriate):

Embeddings method: palm
Distance measure type: DOT_PRODUCT_DISTANCE
Algorithm Config: bruteForceConfig
Approximate number of neighbors: 100

[REQUIRED] Step 3: Describe the problem
Steps to reproduce:

Install Extension
Query index with param neighbours != 10

Expected result
number of datapoints in results === neighbors
Actual result
number of datapoints in result === 10
Investigation
I tried to debug this myself but the lack of documentation and console visibility around Vertex AI, as well as the inconsistent spelling of neighbor vs neighbour in docs and code made it almost impossible. This is about as far as I was able to get:
const response = await axios.post(
      `https://${endpoint}/v1beta1/projects/${config.projectId}/locations/${config.location}/indexEndpoints/${indexEndpoint}:findNeighbors`,
      {
        queries: queries.map(query => query.toVertexQuery()),
        deployed_index_id: `ext_${config.instanceId.replace(/-/g, '_')}_index`,
        neighbor_count: searchResults,
      },
      {
        headers: {
          'Content-Type': 'application/json',
          Authorization: `Bearer ${accessToken}`,
        },
      }
    );

Query Index correctly passes searchResults (more confusing naming) into the findNeighbors request
The request returns 10 results, independent of the value of searchResults
This really seems like something that should be caught by test cases - so very possible I'm doing something wrong. Would appreciate some more knowledgable eyes on this.

Hi @jbraunschweiger I've just installed it and getting this error:
TypeError: Cannot destructure property 'index' of 'metdata.data(...)' as it is undefined.     at updateIndexConfigHandler (/workspace/lib/functions/update_index_config.js:29:17)     at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
Have you seen it or it worked fine for you?

Hi - @AlexZhidkov I didn't get that issue, but your turnaround time seems to fast for the index to have deployed. Is your index showing as deployed in GCP? Does your metadata doc in firebase have an index ore deployed_index_id field?

Where do I see if index is deployed in GCP?
I don't see metadata doc in my firestore. There's  _ext-firestore-semantic-search collection  with tasks.status: "PENDING"
I guess, I have to wait for it to complete? How would I know when I can start using the search?

When Pending changes to Index_Deployed your gtg. It can take a few hours not worth staring at XD

I think the problem was that the Browser key (auto created by Firebase) API key was restricted to Websites. When I removed the restriction, the extension worked fine.


Change fields to correctly reflect, that we return the installs

New repo version of https://github.com/flathub/backend/pull/165 and https://github.com/flathub/frontend/pull/276
I'm still puzzled, why we think it shouldn't be installs in the frontend, as I find that much clearer from a user POV.

@razzeee Is this API now safe for the shields.io badge?

yes


Excuse me, do you support IPv6?

The audit was rejected because it was not compatible with IPv6

SwiftHTTP doesn't do any specific with IPv6. This is all handled by the underlining NSURLSession APIs, thus should be supported in proper IPv6 setup of NSURLSession. I'm not sure what audit you are referring to, but there shouldn't be anything specific in SwiftHTTP to cause an issue.
https://developer.apple.com/videos/play/wwdc2015/719/


Fix uneven space for social buttons on mobile

The social buttons were not evenly spaced in mobile view, there was more space on the left than on the right. I tested the following solution using chrome tools and reproduced the desired behavior. 1. Removed margin-left from "&__doc-button, .MarketingButton" class , 2. Changed justify-content in "&__button-container " class from center to space-evenly.

Hi @kagisojamesthomba , thank you for your contribution. Is this PR connected to an issue? If yes, please link a reference to that issue here, as the rules require that every PR should be connected to an issue. If there is no issue, please create one and link it to this PR with a reference.

bug #686

The text centering was not fixed, I fixed it, but there is still an issue on a screen ~458px width:

Also, this is a duplicate with #696 , so whoever commit a better solution, I will accept the PR.

Fixed in #716 - Thanks for the effort.


Unbreak the metadata of the page

@JasonMAnderson accidentally modified a starting hyphen to a 7 in 5efc305256e5f544a0e8120799e071400ec3e435

@ranieuwe : Thanks for your contribution to the Azure documentation! The author, @v-chenyh, has been notified to review your proposed change.

#sign-off


gamepad support

e.g. https://wiki.libsdl.org/CategoryGameController and
https://www.sfml-dev.org/documentation/2.5.1/classsf_1_1Joystick.php

closed with #171 171


Translated Advanced Algorithm Scripting in Italian

Pre-Submission Checklist

[x] Your pull request targets the staging branch of FreeCodeCamp.
[x] Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
[x] You have only one commit (if not, squash them into one commit).
[ ] All new and existing tests pass the command npm run test-challenges. Use git commit --amend to amend any fixes.

Type of Change

[ ] Small bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds new functionality)
[ ] Breaking change (fix or feature that would change existing functionality)
[x] Add new translation (feature adding new translations)

Checklist:

[ ] Tested changes locally.
[x] Closes currently open issue (replace XXXX with an issue no): Closes #XXXX

Description
Italian translation for the challenge Advanced Algorithm Scripting
Closes #9716 - @Em-Ant hints implemented

@devilicecream, please ask someone in the Italian rooms to review your translation :smiley:

@atjonathan I did, and actually @Em-Ant has already reviewed this on my fork, where I created the first pull request by mistake. He or somebody else from the group will come to check it here as well anyway. 😄

@dakshshah96 awesome:tada:

@atjonathan I guess you mean @devilicecream? 😛

I've already reviewed the first version of this on @devilicecream 's fork, and we added some small improvement. I'm an Italian native speaker and  in my opinion this is a very good translation of an intricate technical subject. :+1:

We will merge for now and if something is incorrect, it can be changed later. Thanks for your PR @devilicecream :+1:
@dakshshah96 sorry :joy:


Requirements like git+https://github.com/foo/bar.git#egg=bar not recognized

Describe the bug
Packages can be listed in requirements files like this: git+https://github.com/sbywater/django-assets.git@0d6dc38d588e7607352b013da34a27f8a10abe81#egg=django-assets
When they are, deptry reports them as transitive.
System [please complete the following information]:

OS: Ubuntu 22.06
Language Version: Python 3.10
Poetry version: n/a

Additional context

Should be solved in release 0.4.4 by this PR.
If you have the time, please give it a try and let me know if it fixed your issue. Thanks :)


Current module is not comparable with master branch of puppetlabs-rabbitmq

There's been some drift on the parameters, since the rabbitmq module was updated.
They got rid of the erlang_manage, and have added 2 new SSL verification options.
file in question is:  manifests/middleware/rabbitmq.pp

closing for inactivity, out-datedness, and most probably fixed-ness ;)


Colorbar plus

Based on #2120, but trying to get CI working.

Hm, looking at the errors, they don't seem to be really related to changes in this PR, no?

Don't think so. I think these are closer to errors I was getting locally a few weeks ago, but couldn't get CI to reproduce.


New Linerenderer.

I updatet the line renderer. There was a bug where a specific direction wouldn't show. Also the material now never gets stretched but instead repeats itself which looks much better (Tiling via the material is still possible).
I also added Dots at each corner of the path. The Texture for the mesh should have a resulotion of 1 by 2 (100px x 200px) the top half is the part for the line the second half is for the dots at the corners.
I added an example Texture and material.

Cool will get this integrated

:+1:


Layout Issue in code blocks in version 6.2.2

After upgrading jekyll-theme-chirpy to version 6.2.2, my code block section looks as shown in the picture..

The three dots as indicated by the arrow seem to have zero top left padding.
How can I get it fixed?
Here's my site if you want to check it out.
https://biplabdutta.com.np
Also, this is how it looks on mobile phone on portrait mode.

I think you have some files that were not upgraded to v6.2.2, for example _sass/addon/syntax.scss in this issue.
Your site:

Demo site:

Update:
No, I think it’s because the definition of $code-header-height is missing in the _sass/addon/variables.scss file.

Update:
No, I think it’s because the definition of $code-header-height is missing in the _sass/addon/variables.scss file.

Is there anything I can do on my side to get it fixed?

It will be easier for investigation the cause if you are willing to share your repository link :)

@NichtsHsu Sure. It's open sourced.
https://github.com/Biplab-Dutta/personal_site

Hi @Biplab-Dutta ,
Version of jekyll-sass-converter in your Gemfile.lock is too old.
Just run bundle update and all will be fine.

Shall give it a try tonight and shall let you know and close the issue if that fixes my problem. Thanks.

@NichtsHsu Tried updating the bundle. But didn't work.
My gemfile.lock shows no any git difference even after running bundle update.

Do you build your site on linux-musl? It seems that jekyll-sass-converter v3.0 is not supported on the linux-musl platform:
https://github.com/cotes2020/chirpy-starter/blob/bcb2c56f84502ec60e946dc4f15b3f6e7fd6c6f4/Gemfile#L25C50-L28

@NichtsHsu I don't know what that is. It was there when I created the project with the starter template.

You can try removing the Gemfile.lock from your repository and triggering the Github Action again.


Add support for S3 Express One Zone

S3 Express One Zone Buckets are currently unsupported. Recent AWS SDKs for other languages added dedicated support, detecting the s3 express style bucket names and updating the singing algorithm and endpoints accordingly.
It would be great to get full support, including S3 session management, directly in Soto

As far as I can tell all the operations are available to do this already.
I don't see anything about a custom signing process in the docs. As far as I can tell you extract the credentials out of the s3.createSession response and use those. Have you tried this? If so how far did you get and what errors did you see?
If you want to ensure you have valid credentials all the time you could use a RotatingCredentialProvider to request new credentials when your current ones are about to expire.

Yes I have a bucket setup that I'm testing against and actually creat session using Soto just times out against the directory bucket, works fine using awslabs/aws-sdk-swift.
But even then we must support the new sigv4-s3express signing scheme. If you do some grepping on GitHub you'll see if in their other sdks. Unfortunately the docs are so bad around this, but it's effectively just one extra header that gets passed a long with the value of the session token. I'll see what I can help dig up here

I opened a similar issue on aws-sdk-swift: https://github.com/awslabs/aws-sdk-swift/issues/1844

@adam-fowler Here's a full project to help test this: https://github.com/AndrewBarba/swift-s3-express-demo
Assuming you have docker installed, and was credentials locally, you can deploy the whole stack with:
swift run Infra deploy --stage demo

I had a very quick look at this and found the Soto version fails because it doesn't return credentials. I know aws-sdk-swift sets everything to optional so it doesn't matter if the credentials are returned. Does the aws-sdk-client example have credentials set in the response?

Yes it does. Has values for all 4 properties. Here's my deployed url: https://ba3qux3gvwwyc5ndtsbutlfmhu0yjsgy.lambda-url.us-east-1.on.aws

Looks like I'm gonna have to set up my own EC2 instance to work out what is going on here. S3 express seems to only be available in the same zone as it is setup.
As far as I can tell to use S3 express you need to use custom endpoints but the createInstance operation still uses the standard endpoints. I haven't got anywhere near to considering the signing process yet.

You do not need to be in the same zone that the bucket is deployed. It's recommended to get those single digit TTFBs but it is not a requirement. The project I sent you would be a sufficient setup to test everything you need.
The main hiccup is if you deploy into a VPC, you need to configure a VPC endpoint. But the project I sent does not deploy the lambda into a VPC so it works just fine.

Running on a lambda is no use. I can't debug it. There is very little visibility on what is happening outside of print statements.
Ideally I would be running code locally on my Mac, but if that doesn't work I can use an EC2 instance and VSCode and ssh. I tend to use awscli to find out what is required, if docs are sparse. But calling createSession with it on my Mac fails.

Understood. Calling create session from your Mac should be fine assuming your credentials have access to s3express:CreateSession

Yes of course. I've got admin rights on everything and it is saying I don't have access. I'll have another look see if I can work out what is going on.

Did you also try calling create session with aws swift sdk? When I initially tested that did work, and the Soto create session did not. And I did this from my Mac as well as the deployed lambda (not in a VPC). I didn't have a chance to dig further into the Soto error. My main suspicion though is that Soto is not using the regional endpoint when making the call, where as the aws sdk is. The endpoints for express buckets are a bit different. You use the regional endpoint to create a session and then zonal for object calls

Haha worked out why awscli was failing. I was running create-session from the wrong region 🤦

https://github.com/soto-project/soto-core/pull/629

So I think I know what is required. Basically the session id needs to be in a different header. It just makes me wonder why does S3 have to do it different to everyone else. The number of special cases required by S3 keeps growing.

#749

Looking good! I can successfully PUT/GET objects now. I am seeing on issue on listObjectsV2 returning a decoding error:
The operation could not be completed. The data isn't in the correct format.

Released

Really appreciate the work on this! Thanks a ton


✨ Introducing hardhat-starknetjs

Hi @0xlny if this is approved can it be merged? I don't seem to be able to do that myself


Investigate numpy.complex64 type

This is incomplete, don't merge!
Just thought I would share with you as it easier to see that reading Gists.
Does it make sense to support complex data types?

Good point, definitely something we currently do not support. A workaround that should already work is to 'cast' complex arrays into a 2-channel floating point array as shown here https://stackoverflow.com/a/47086801/242594

does #11 resolve this?

I think it must do. If the tests pass, that's a great solution to serialising arrays. I am right, it casts complex to two float arrays? Makes perfect sense.

I believe it does. I will close this for now. In case something comes up, feel free to reopen. And thanks for your contribution!


Aggregated data from all tenants from central application

Description
I'm not sure if this feature exists or there's an existing approach to go about this, but it would be great to be able to get all data from all tenants from the central application for reporting purposes.
A simple dumbed down example would be seeing all posts across all tenants, their comments, and tags in the central application, along with what subdomain they belong to.
Why this should be added
For reporting purposes, gathering statistics, and more.

Syncing resources and aggregating data are different things. I think he wants the former here.
Either way, this is implemented so I'm closing

tenancy()->all()->runForEach()

When I run this it says that the all() method does not exist.  And looking at the Tenancy.php class I do not see it in there.  Am I doing this incorrectly?

Ah sorry, you're right. tenancy()->all() was the syntax in v2, now we removed the method because it's easy to do that with Eloquent 👍🏻


Fix typo setup.sh -> setup.py

Coverage remained the same at 89.617% when pulling 768543ec261990e4208b5ac6eae4cf0c4cdb9b38 on fix/readme_typo into 3fcfd8a31fc94c7d0be4998fda8f04cd7e7b5cfa on master.

Coverage remained the same at 89.617% when pulling 768543ec261990e4208b5ac6eae4cf0c4cdb9b38 on fix/readme_typo into 3fcfd8a31fc94c7d0be4998fda8f04cd7e7b5cfa on master.

Coverage remained the same at 89.617% when pulling 768543ec261990e4208b5ac6eae4cf0c4cdb9b38 on fix/readme_typo into 3fcfd8a31fc94c7d0be4998fda8f04cd7e7b5cfa on master.

Coverage remained the same at 89.617% when pulling 768543ec261990e4208b5ac6eae4cf0c4cdb9b38 on fix/readme_typo into 3fcfd8a31fc94c7d0be4998fda8f04cd7e7b5cfa on master.


Pass triggering event on ContextMenu.Trigger to event handler

Feature request
Overview
My application includes a map, which can be right-clicked in order to bring up more details. The map is rendered with WebGL, so is basically opaque to React. I'd like to be able to use the ContextMenu component and show more details about what was right-clicked. To make this possible, it would be nice to pass the event that triggered the context menu open to a method that looks up map details.
Who does this impact? Who is this for?
This will be nice if any of the things that trigger a context menu are, well, contextual to what was right-clicked. This map example is certainly one, but something like having one context menu at a top element and using, basically, delegation to trigger different right-click menus, would be an example.
Additional context
API might look like:
<Root onOpenChange={((open: boolean, event: React.MouseEvent | React.PointerEvent))}>

Hey @tmcw, thanks for opening an issue.
In the case of your map example, can I ask how you're planning to decide what to show then?
I'm curious cause you say it's basically a webGL thing, opaque to React. Would you be working out what to show based on the pointer position in the event?

I'd like to be able to use the ContextMenu component and show more details about what was right-clicked

If you're wanting to render information about something then it's probably not the appropriate use of the ContextMenu component which is meant for menus.
The Popover can be controlled and might be more suited to your use-case?

[..] but something like having one context menu at a top element and using, basically, delegation to trigger different right-click menus, would be an example

For this, your app can be a <ContextMenu.Trigger as="div" /> and you can nest ContextMenus inside.

I'm curious cause you say it's basically a webGL thing, opaque to React. Would you be working out what to show based on the pointer position in the event?

Yep, exactly this. In particular, using Mapbox, which gives you a method to query features at a particular point within the WebGL canvas, based on the offset from the top-left corner.

If you're wanting to render information about something then it's probably not the appropriate use of the ContextMenu component which is meant for menus.

This will be a menu - basically, think of it as the same as the right-click menu on Figma. For example: right click on a stack of overlapping features and choose which feature to select.

@tmcw the reason I asked is because I know we have a similar instance in our product (Modulz) where we haven't been able to use the primitive for that reason so it's definitely of interest for us to provide a way to make this work somehow.
I tested this solution quickly yesterday and it is workable. However, I am not sure that it is the best solution semantically. We may be better off raising a custom event.
The reason for this is that, if it wasn't for touch support, you could already do what you want:

wrap your canvas in a ContextMenu.Trigger
attach your own onContextMenu event to get access to the point coordinates in time

However, because we support touch via a long-press, it wouldn't be straightforward for you to hook into that one or re-create it. So I'm thinking perhaps we raise a custom event/callback for when we generally detect an event (context menu or long press) that should open the menu.

So I'm thinking perhaps we raise a custom event/callback for when we generally detect an event (context menu or long press) that should open the menu.

We already have an onOpenChange that triggers when that happens so it sounds like the combination of the two is what is needed?
export default () => {
  const pointRef = React.useRef<number[] | null>(null);

  return (
    <ContextMenu.Root
      onOpenChange={(open) => {
        if (open) {
          queryRenderedFeatures(pointRef.current);
        } else {
          pointRef.current = null;
		}
      }}
    >
      <ContextMenu.Trigger
        as="canvas"
        onContextMenu={(event) => (pointRef.current = [event.clientX, event.clientY])}
      />
      <ContextMenu.Content>
        <ContextMenu.Item>One</ContextMenu.Item>
        <ContextMenu.Item>Two</ContextMenu.Item>
        <ContextMenu.Item>Three</ContextMenu.Item>
      </ContextMenu.Content>
    </ContextMenu.Root>
  );
}

That wouldn't work with the long press event though, like I was saying above.

I think the fact that I used onContextMenu has confused things.
The onOpenChange will fire when the menu is opened (when long press has occurred) which is where I look up the map details. My thinking is that the snippet just needs updating to get the point using whichever events @tmcw wants to support... it could be onMouseDown/onPointerDown instead if preferred.
Unfortunately though, I just tried onPointerDown to demonstrate and it doesn't get the point in time if the menu is already open 🤔 https://codesandbox.io/s/weathered-bash-2ze4e

Yeah I mean technically you could do it like that, perhaps even always update the point ref on pointermove for example.
What I'm trying to get to is that I think semantically it's abusing the onOpenChange callback a bit.
It only works because ContextMenu cannot be controlled but if it could, the menu would have other ways of opening potentially.
That's why I suggested potentially a custom event because, the information needed is rather about where the point was in the interaction that triggered the menu to open. If all browsers worked properly with only onContextMenu this is how you'd do it, so it seems to me it should still be done the same way.

Why would it matter if it was controlled? My immediate thought when I saw this ticket was to control it, but obviously we don't allow that atm.

the information needed is rather about where the point was in the interaction that triggered the menu to open

I'm curious what the new event you're thinking of would look like? onPointerOpen? The things is, we should already be able to get this information without something like that because onPointerDown on trigger + open === true is onPointerOpen.
I'd favour allowing it to be controlled and figuring out why onPointerDown event doesn't fire when the menu re-opens. Otherwise, it feels we'll end up going off-piste in regards to consistency. Where do we draw the line? What if someone needs to know if it was a long press that opened it, do we provide a longpress bool as part of our API?
The coords requirement is very specific to @tmcw's product (because of taking things out of React-land) and that is what controlling things is for in my mind.
However, I do wonder if it is worth considering the CustomEvent idea more seriously that we spoke about a while ago (where all our callbacks would be CustomEvents). That would allow us to provide event.detail with information like this without exposing implementation detail (the native event).
onOpenChange={event => {
	console.log(event.detail) // { open: true, triggerPoint: null } - trigger wasn't clicked
	console.log(event.detail) // { open: true, triggerPoint: [12, 100] } - trigger was clicked
	event.preventDefault() // doesn't prevent anything native
}}

I'm interested in this kind of implementation too so I thought I'd outline my use case here to add some fuel to the fire.
I have a "Layout Editor" component using SVGs to build a floorplan and wanted to use a context menu to allow users to add elements at a particular place. (Right-click > Add Shape)
This is workable currently in a rather roundabout way (though in my case this is more of how I wanted it to work). I have the following DOM structure. My way of detecting "what" to show in the menu is kind of a bit custom in that I handle the "mousedown" of the svg and then figure out what was clicked to then populate the context menu. Radix ContextMenu places it in the correct place for here so all I needed was to be able to figure out "what" was clicked. With the canvas you may be able to use the same approach.
  <ContextMenu.Content>...</ContextMenu.Content>
  <ContextMenu.Trigger>
    <svg onMouseDown={setTarget}>...</svg>
  <ContextMenu.Trigger>
</ContextMenu.Root>

Closing this as we are tracking in #1307