March 2023 Endgame

3/20 Code freeze for the endgame
3/24 Endgame done
3/29 Expected release date (this may change)

Monday

[x] Check that all queries in this issue use the current milestone @TylerLeonhardt
[x] Run OSS tool @TylerLeonhardt
[x] Update links in the Endgame notebooks to point to new milestone @TylerLeonhardt
[x] Code freeze at 5pm PT
[x] Ensure we have a green build on all platforms at 5pm PT
[x] 🔖All closed feature-requests either have a verification-needed or on-testplan label
[x] Create test plan items following the template here by 6pm PT
[x] Update your availability for testing here - https://tools.code.visualstudio.com/team-manifest team

[x] Update availability of testers in vacation. Double check N/A testers. @TylerLeonhardt

Tuesday

[x] Test plan items assigned (using https://tools.code.visualstudio.com/test-plan-items)

Run the tool multiple times to balance load if test items come in later and assignments are already made
Assigned to you

[x] Test build starts at 7am CET
[x] Test plan ready by 8am CET
[x] 🔖Testing
[x] 🔖Verification needed

Wednesday

[x] 🔖Testing
[x] Remind team members to assign issues that they intend to fix to the current milestone
[x] Fixing (self-assigned, milestone assigned)
[x] 🔖Verification needed

Thursday

[x] Fixing (self-assigned, milestone assigned, no need for PR or review)

Increased scrutiny sets in due to testing being completed. Fixes pose a much higher risk
Move issues to the next month that can be deferred

[x] 🔖Verification needed
[x] 🔖Verification

Friday

[x] Build a stable build to ensure stable build is green @TylerLeonhardt
[x] Pause scheduled insider builds (includes vscode.dev publishing) @TylerLeonhardt
Satellite modules/npm packages ready, version updated, smoke tested

[x] yo generator @aeschli
[ ] js-debug @connor4312
[ ] Debug Adapter Protocol @connor4312
[x] vscode-debugadapter-node @roblourens
[x] Mock Debug @roblourens
[x] vscode-test-web @aeschli
[ ] vsce @joaomoreno

[ ] Only candidate issues are open and assigned to 🔖milestone
[x] All issues 🔖verified
[x] All open PRs on the milestone 🔖merged or deferred
[x] Branch code to release/<x.y> after all expected fixes are in (latest 5PM PST) @TylerLeonhardt
[x] Branch distro to release/<x.y> after all expected fixes are in (latest 5PM PST) @TylerLeonhardt
[x] Branch vscode.dev to release/<x.y> after all expected fixes are in (latest 5PM PST) @TylerLeonhardt
[x] Bump up the version in package.json on main - @TylerLeonhardt
[x] Localization: Run Update VS Code Branch build with release/* as the VS Code Branch parameter (it's the default so you shouldn't have to change anything) @TylerLeonhardt
[x] Create next milestone and ensure that it has a due date. The created milestone and its due date will be automatically synced across our repos @TylerLeonhardt
[x] Announce main is open for business @TylerLeonhardt
[x] Fixing (PR + review required once branched - major bugs only - to be discussed in stand-up meeting, labeled as candidate)
[ ] All release notes updated

release notes are collected in a file named v<Major>_<Minor>.md in this repo directory
[ ] @aeschli
[x] @alexdima
[ ] @alexr00
[ ] @andreamah
[x] @aiday-mar
[ ] @bhavyaus
[ ] @bpasero
[ ] @chrmarti
[ ] @connor4312
[ ] @daviddossett
[ ] @dbaeumer
[ ] @deepak1556
[ ] @egamma
[ ] @hbons
[ ] @hediet
[ ] @isidorn
[ ] @joaomoreno
[x] @joyceerhl
[ ] @jrieken
[ ] @kieferrm
[ ] @lramos15
[ ] @lszomoru
[ ] @meganrogge
[ ] @mjbvz
[ ] @rebornix
[x] @roblourens
[ ] @rzhao271
[ ] @sandy081
[ ] @sbatten
[x] @tylerleonhardt
[ ] @tyriar
[ ] @ulugbekna

[x] Acknowledge pull requests in release notes. We acknowledge PRs from outside the team. We have improved the tooling so that the endgame champion can generate the pull request acknowledgment for all repositories at once. @TylerLeonhardt

[ ] debug-adapter-protocol, inno-updater, jsonc-parser, language-server-protocol, lsif-node, vscode, vscode-codicons, vscode-css-languageservice, vscode-debugadapter-node, vscode-dev-containers, vscode-docs, vscode-emmet-helper, vscode-eslint, vscode-extension-samples, vscode-generator-code, vscode-hexeditor, vscode-html-languageservice, vscode-js-debug, vscode-js-debug-companion, vscode-js-profile-visualizer, vscode-jshint, vscode-json-languageservice, vscode-languageserver-node, vscode-livepreview, vscode-loader, vscode-lsif-extension, vscode-node-debug, vscode-node-debug2, vscode-pull-request-github, vscode-recipes, vscode-references-view, vscode-textmate, vscode-vsce

[ ] Acknowledge issue trackers from the community @chrmarti
[x] Add notable fixes to the release notes all
When done fixing/verifying and there are changes since last build at the end of day PT

[x] Build and manually release Insider from release/<x.y> for Code @TylerLeonhardt
[x] Build and manually release Insider from release/<x.y> for vscode.dev (if required) @TylerLeonhardt

Friday/Monday

[ ] Polish release notes redmond
[ ] Fixing (only critical bugs - no string changes)

Monday - Wednesday

[ ] 🔖milestone issues
[ ] 🔖candidate issues
[ ] Polish release notes redmond
[ ] Cherry-pick hand-picked and reviewed changes to release/<x.y> @TylerLeonhardt
[ ] Build Insider from release/<x.y> @TylerLeonhardt
[ ] Manually release Insider @TylerLeonhardt
[ ] Build stable for all platforms as new candidate issues come in @TylerLeonhardt
[ ] Documentation updated

[ ] @aeschli
[ ] @alexdima
[ ] @alexr00
[ ] @andreamah
[ ] @aiday-mar
[ ] @bhavyaus
[ ] @bpasero
[ ] @chrmarti
[ ] @connor4312
[ ] @daviddossett
[ ] @dbaeumer
[ ] @deepak1556
[ ] @egamma
[ ] @hbons
[ ] @hediet
[ ] @isidorn
[ ] @joaomoreno
[ ] @joyceerhl
[ ] @jrieken
[ ] @kieferrm
[ ] @lramos15
[ ] @lszomoru
[ ] @meganrogge
[ ] @mjbvz
[ ] @rebornix
[x] @roblourens
[ ] @rzhao271
[ ] @sandy081
[ ] @sbatten
[ ] @tylerleonhardt
[ ] @tyriar
[ ] @ulugbekna

[ ] Run scripts/test-documentation.sh|bat and add file or fix issues if there are new colors that are not documented. @TylerLeonhardt

Note: The Insiders build needs to be in the wild for 24 hours before we can enter the last phase of the endgame. @TylerLeonhardt

Wednesday/Thursday - Expected release day (this may change)

[ ] Build stable for all platforms @TylerLeonhardt
[ ] Sanity check of installable bits (server instructions)

[ ] Windows 32 bit owner

[ ] signed installer 32-bit
[ ] signed user installer 32-bit
[ ] zip 32-bit
[ ] server 32-bit
[ ] cli 32-bit

[ ] Windows 64 bit owner

[ ] signed installer 64-bit
[ ] signed user installer 64-bit
[ ] zip 64-bit
[ ] server 64-bit
[ ] cli 64-bit

[ ] Windows ARM64 owner

[ ] signed installer ARM64
[ ] signed user installer ARM64
[ ] zip ARM64
[ ] cli ARM64

[ ] macOS

[ ] Intel + Universal owner
[ ] cli Intel
[ ] server Intel
[ ] Apple Silicon + Universal owner
[ ] cli Silicon
[ ] server Silicon

[ ] Linux x64

[ ] deb owner
[ ] rpm owner
[ ] archives owner
[ ] snap (sudo snap install --classic --dangerous <file>.snap) owner
[ ] cli

[ ] Linux server owner

[ ] x64
[ ] ARM32
[ ] ARM64
[ ] x64 Alpine
[ ] ARM64 Alpine

[ ] Publish website @gregvanl
[ ] Publish to stable @TylerLeonhardt
[ ] Trigger the vscode.dev Deploy pipeline for the prod deployment target. @TylerLeonhardt

[ ] Request approval from another team member at the necessary step to deploy the vscode.dev build. @TylerLeonhardt

[ ] Create an official release @TylerLeonhardt

[ ] Create a tag (make sure you pull the release branch first): git tag <x.y.z>
[ ] Push the tag: git push origin <x.y.z>
[ ] Create a GitHub release: Open the GitHub tags, and click far right ... > Create Release. Use the correct title and description from our release notes. Also change the relative links for the key highlight list items to absolute links Example

[ ] Twitter announcement @chrisdias
[ ] Enable scheduled insider builds @TylerLeonhardt
[ ] Publish @types/vscode @TylerLeonhardt
[ ] Close the milestone on GitHub @TylerLeonhardt
[ ] If no Patch Tuesday release is planned, let the Updates team know of that fact<EMAIL_ADDRESS>@TylerLeonhardt
[ ] If a recovery build is needed, proceed to https://github.com/microsoft/vscode/wiki/Endgame-Recovery-Template or https://github.com/microsoft/vscode-internalbacklog/wiki/Patch-Tuesday-Release-Endgame-Template/ @TylerLeonhardt

https://github.com/xtermjs/xterm.js/issues/4120 has been fixed by https://github.com/xtermjs/xterm.js/pull/4438/files.
@Tyriar Will these changes make it into v1.77? I.e. are there new beta versions of xterm and its addons and will package.json be updated accordingly?

@benz0li that fix is coming in 1.78 with this PR https://github.com/microsoft/vscode/pull/178443.


Add docstrings to graph2 channel

Change namedtuples to classes with docstrings
Address Flake8 for these files

Well that didn't work as I expected. I was trying https://github.com/sindresorhus/refined-github/pull/975 and didn't realize I shouldn't click the merge and that I should just leave the tab open. The more you know...


dataSize invalid prop error

Hi, i've installed the latest version 0.5.0 that added invisible option, but Vue still throws invalid prop error when passing invisible as the value.

Hello, I forgot to release it :)

@fauzymk check out the 0.5.1 update 😊


[BE] Improve the email address validation for contact and newsletter subscription API endpoints

Task Requirements
Currently, we are validating the email addresses for both contact and newsletter subscription API endpoints but that's not enough.
People can still send fake email addresses and it will cause the emails to bounce.
We need to verify that the email address that is being used in the form is valid by adding additional validation rules:
'email' => 'email:rfc,dns'

Additionally, we can integrate something like Mailbox Layer to actually verify the email addresses and reduce the potential spam by bots or malicious actors.
You can find details on how to integrate it by checking out this tutorial
I'll provide you with the API keys.

@davorminchorov paketot so si go preporacal e staj go frknav i abedjtutvav da raboti na laravel11 da cekam sopstvenikot da go abdejtuva ili da ja koristaj mojata verzija

I didn’t notice that the package was old, I’ll look for an alternative package or if the API still works, you can probably integrate it manually based on the package that I linked.

@davorminchorov I will do the integration without  package no need :)


34727.79 - Unable to download Smooth Motion Pack SE 5.3.3.FOMOD

What happened?
34727.79 - Unable to download Smooth Motion Pack SE 5.3.3.FOMOD (GoogleDriveDownloader+State|1MLyn1f44aEBlO0NNJGDLA0OXwDvk7hvD)
34727.79 - Cannot continue, was unable to download one or more archives
the file is exist. im not sure the problem is the modlist or wabbajack itself.
Modlist version
1.1.74

read the readme


SS4 Migration - classname_value_remapping doesn't work with subsites

Affected Version
4
Description
By default the subsite filter is applied so the query which searches for existing objects doesn't account for any which have a subsite ID of anything other than 0.
Steps to Reproduce
Run dev/build with a database with a subsite where a page type only exists on a specific subsite.

Worked around locally but adding Subsite::disable_subsite_filter() do DatabaseAdmin::doBuild().

related to #8626 ? I encounter this kind of problem with pretty every sitetree related task when subsites is installed.
Are there any hooks we could implement like "beforeRun" to disable e.g. subsites instead of subclassing every task and use injector? This could go in TaskRuner::runTask()

This is a tricky issue because other modules could also be augmenting SQL queries via our public API. Translatable comes to mind (also it currently doesn't support SilverStripe 4). In my head I'm thinking that if the dev/build controller provided either middleware support or extension points before/after doBuild like @wernerkrauss suggested for subsites to disable its query filtering.

I am working on a fix for this at the moment. Should have a PR up soon


Gps Tracker example Problem! "check acc"

Hi I was trying this code and following all the doc I ran into a break in the code the moment before I print the axis data, I am left with "check acc" in the console and it all jams and the console freezes. help me? Thanks in advance

@danieleberibe
Can you give a little bit more information? Do you have the log before the crash and can you share it?
The code works just fine for me here.

Can the WisBlock connect to a LoRaWAN server?
Does it show OTAA Mode, Network Joined! in the log?
Is the RAK1904 in the Slot D of the RAK5005-O Base Board?
Is the RAK1910 in the Slot A of the RAK5005-O Base Board?

Yes, of course then I am using the 2nd gen board and I saw that the 1910 module must be inserted in slot D. If I then insert the 1904 module in A or C the code stops me here (attached image) while if I put it as you have me recommended you don't even join.

As we are discussing this now in Discord, I close it here.


Exemption certificate validation fails during "Rules Validation"

Hello,
I am testing an Exemption Certificate that gets correctly validated by VerificaC19.
This is my code:
var _trustListProvider = ItalianTrustListProvider.Create(_httpClient, new ItalianTrustListProviderOptions()
            {
                RefreshInterval = TimeSpan.FromMinutes(refreshIntervalMinutes),
                MinRefreshInterval = TimeSpan.FromMinutes(minRefreshIntervalMinutes),
                MaxFileAge = TimeSpan.FromDays(60),
                BasePath = basePath,
                SaveCertificate = true,
                UseAvailableListWhileRefreshing = true
            });

var _rulesValidator = DgcItalianRulesValidator.Create(_httpClient, new DgcItalianRulesValidatorOptions
            {
                RefreshInterval = TimeSpan.FromMinutes(refreshIntervalMinutes),
                MinRefreshInterval = TimeSpan.FromMinutes(minRefreshIntervalMinutes),
                MaxFileAge = TimeSpan.FromDays(60),
                BasePath = basePath,
                UseAvailableValuesWhileRefreshing = true,
                ValidationMode = ValidationMode.Basic3G
            });
var  _blacklistProvider = ItalianDrlBlacklistProvider.Create(_httpClient,
                    new ItalianDrlBlacklistProviderOptions
                    {
                        RefreshInterval = TimeSpan.FromMinutes(refreshIntervalMinutes),
                        MinRefreshInterval = TimeSpan.FromMinutes(minRefreshIntervalMinutes),
                        MaxFileAge = TimeSpan.FromDays(60),
                        BasePath = basePath,
                        UseAvailableValuesWhileRefreshing = true,
                    });
var reader = DgcReaderService.Create(_trustListProvider, _blacklistProvider, _rulesValidator);
var res = await reader.VerifyForItaly(qr, ValidationMode.Basic3G, throwOnError: false);

The validation fails with Status NeedRulesVerification and RulesValidation field set to null.  The signature is correctly detected as Valid and the Dgc Name and Birth is correctly parsed. The StatusMessage field is: Riferimento a un oggetto non impostato su un'istanza di oggetto.
This is the Stack Trace I get by setting the throwOnError parameter to true:
   at DgcReader.DgcReaderService.<Verify>d__5.MoveNext()
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at DgcReader.ItalianValidationResultsExtensions.<VerifyForItaly>d__4.MoveNext()
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()

I have already tried to re-download the updated rules, but with no luck. I am on version 2.5.0.
Am I doing something wrong?
Please let me know if you need more details

Hi @mircoianese , thank you for reporting this, is it possible for you to send me in private the exemption certificate?

Hi @mircoianese , thank you for reporting this, is it possible for you to send me in private the exemption certificate?

Hi @DevTrevi,
unfortunately at the moment we can't send you the certificate. We are asking the owner for permission.
Meanwhile I did some investigations by debugging the source code.
The Exemption schema is implemented only inside the ItalianDGC class, which is related to the RuleValidators.Italy module, but not to the BlacklistProviders.Italy module.
The first issue I encountered is that the call of this method does not return any certificate (so no certificate identifier for the Blacklist check to be completed):

Then I think there is also another issue in the Rules Validation, the crash happen on this line:

Inside this function:

Some data is still missing:

And the exception thrown is: Operazione o metodo non implementato.
Hope this helps you identify the issue.
Please let me know if something else is needed.
Thanks

I think that I have already found the issue, I missed to implement some properties in the ExemptionEntry...
It is possible for you to download the latest commit in develop branch and test it with the exemption certificate? I think that this should fix the issue, but I can't test with a real exemption certificate

Mhm you are right... I missed that, I think that at this point I will need to make the deserializer injectable too, in order to allow deserialization of custom schema like the italian one... I will work on it this afternoon, hopefully it will be available in few hours

Mhm you are right... I missed that, I think that at this point I will need to make the deserializer injectable too, in order to allow deserialization of custom schema like the italian one... I will work on it this afternoon, hopefully it will be available in few hours

Thank you a lot!

Hi @mircoianese , can you try again with the latest version in develop? You can also download it from nuget, version 2.5.1-rc1

Hi @mircoianese , can you try again with the latest version in develop? You can also download it from nuget, version 2.5.1-rc1

Hi @DevTrevi,
just tested it through nuget, it seems to be working!
I will wait for the 2.5.1 final release (which I see has also the School Mode removed), do you plan to release it today?
Thanks again!

Hi @mircoianese , I have just released version 2.5.1
If you need to access Exemption details, you can try to cast the Dgc property of the result to ItaliandDGC with .AsItalianDgc() method
ItalianDGC inherits from EuDGC, and the certificate will be deserialized into this type when the issuer of the certificate is "IT"
Thank you for your help :)


PHP 7.2 Support

Sorry, it should be that one: https://github.com/zendframework/ZendService_Google_C2dm/pull/2


Update Make an Image

GitHub Issue:  #1040
What does this Pull Request do?
Some minor updates to the "Make and Image" page including changing the name to the more general "Make a Resource Node" and changing the file name itself to get "object" out of the url. The rest is mostly style guide compliance stuff.
How should this be tested?
Preview & consult the style guide (although I am also suggesting updates to the style guide; they don't conflict)
Interested parties
@DonRichards

@Islandora/8-x-committers needs an 'official' approve & merge 😄


Not receiving output for certain function calls.

Hello,
I'm running into an issue when running the telemetry.py file found in the examples directory. Specifically, the function call 'drone.telemetry.position()' does not produce an output to the terminal window, whereas the other functions in the file do produce an output.
I installed Mavsdk-python using pip3. I manually run the mavsdk-server in a separate terminal window with this command:
./mavsdk_server -p 50051 serial:///dev/tty.usbmodem01

And then run the telemetry.py script with the following line changed:
await drone.connect(system_address="serial:///dev/tty.usbmodem01")

After starting the script, I receive the following output from mavsdk_server:
[05:11:03|Info ] MAVSDK version: v0.50.0 (mavsdk_impl.cpp:28)
[05:11:03|Info ] Waiting to discover system on serial:///dev/tty.usbmodem01... (connection_initiator.h:20)
[05:11:03|Debug] New: System ID: 1 Comp ID: 1 (mavsdk_impl.cpp:484)
[05:11:03|Debug] Component Autopilot (1) added. (system_impl.cpp:355)
[05:11:03|Debug] Discovered 1 component(s) (system_impl.cpp:523)
[05:11:03|Info ] System discovered (connection_initiator.h:63)
[05:11:03|Info ] Server started (grpc_server.cpp:52)
[05:11:03|Info ] Server set to listen on <IP_ADDRESS>:50051 (grpc_server.cpp:53)
[05:11:11|Info ] heartbeats timed out (system_impl.cpp:257)
[05:11:13|Debug] Discovered 1 component(s) (system_impl.cpp:523)
[05:11:17|Info ] heartbeats timed out (system_impl.cpp:257)
[05:11:19|Debug] Discovered 1 component(s) (system_impl.cpp:523)
[05:11:20|Warn ] sending again after 0.500246 s, retries to do: 3  (520). (mavlink_commands.cpp:275)
[05:11:20|Warn ] sending again after 1.01174 s, retries to do: 2  (520). (mavlink_commands.cpp:275)
[05:11:23|Info ] heartbeats timed out (system_impl.cpp:257)
[05:11:24|Debug] Discovered 1 component(s) (system_impl.cpp:523)

And partial output from the terminal window running telemetry.py:
In air: False
In air: False
GPS info: GpsInfo: [num_satellites: 0, fix_type: NO_GPS]
GPS info: GpsInfo: [num_satellites: 0, fix_type: NO_GPS]
In air: False
GPS info: GpsInfo: [num_satellites: 0, fix_type: NO_GPS]
Battery: -0.009999999776482582
GPS info: GpsInfo: [num_satellites: 0, fix_type: NO_GPS]
GPS info: GpsInfo: [num_satellites: 0, fix_type: NO_GPS]
GPS info: GpsInfo: [num_satellites: 0, fix_type: NO_GPS]
In air: False
GPS info: GpsInfo: [num_satellites: 0, fix_type: NO_GPS]
GPS info: GpsInfo: [num_satellites: 0, fix_type: NO_GPS]
GPS info: GpsInfo: [num_satellites: 0, fix_type: NO_GPS]
Battery: -0.009999999776482582
GPS info: GpsInfo: [num_satellites: 0, fix_type: NO_GPS]
GPS info: GpsInfo: [num_satellites: 0, fix_type: NO_GPS]
GPS info: GpsInfo: [num_satellites: 0, fix_type: NO_GPS]
In air: False
GPS info: GpsInfo: [num_satellites: 0, fix_type: NO_GPS]
Battery: -0.009999999776482582
GPS info: GpsInfo: [num_satellites: 0, fix_type: NO_GPS]
GPS info: GpsInfo: [num_satellites: 0, fix_type: NO_GPS]
In air: False
GPS info: GpsInfo: [num_satellites: 0, fix_type: NO_GPS]
Battery: -0.009999999776482582

My question: is there a reason why this section of telemetry.py doesn't produce output to the terminal?
async def print_position(drone):
    async for position in drone.telemetry.position():
        print(position)

I ran into the same issue with drone.telemetry.heading(). For both cases, is the issue due to the fact that the GPS module can't reach a satellite? I have completed the calibration for the GPS module using QGroundControl.
System info:
Running on macOS Catalina (ver. 10.15.7).
Python 3.9.10.
PX4 FMU V2, running PX4 Pro Stable Release v1.12.
Attached is a 3D Robotics GPS Module for Pixhawk.

I think there is something not working correctly in  the device connection , the server terminal keeps printing heartbeat time out , and even for gps fix it indicates no gps .
Could u connect to ur device using qgroundcontrol or mission planner and see if you will get gps infos ??

@MehdiRifi Thank you for the response. I plugged the Pixhawk into a seperate machine running QGC, ensured that the GPS module is plugged in, and then went to: Select Tool menu -> Analyze Tools -> MAVLink Inspector -> GPS_RAW_INT.
The value for Count and time_usec are increasing, while every other value remains the same. If I unplug the GPS module while inspecting the GPS data, Count and time_use stop. If I plug the GPS module back in, they continue to increase. The value of "satellites_visible" remains 0 in this case as well.
I also looked at the status of the GPS under the MAVLink Console. "sat info" is being output as "disabled", so it is unclear whether that is also part of the issue.

Sorry for the late response, hmm seems weird to me, did u try:
test another gps module to ensure gps module is working fine !?
Are you indoor ??

@MehdiRifi No worries.
I don't have another GPS module available, so I couldn't give that one a try.
I had tested outside prior but was getting the same messages. However, I tried again, but this time much further away from the building. Fortunately, that proved to be the trick and fixed the issues I was having. Thank you for your help with this issue.
If it is not too uncourteous, I have one more quick question that I was not able to solve by referencing the MAVSDK-Python documentation.
If I want to print the number of satellites using the Telemetry plugin, I use the following code:
async def print_num_satellites(drone):
    async for gps_info in drone.telemetry.gps_info():
        print(f"GPS info: {gps_info.num_satellites}")

The above code now works, so long as I'm outside the building. However, if I want to print the latitude of the Pixhawk, I assumed I would follow the same name convention as the "GpsInfo" class. As such, I use the following code:
async def print_latitude(drone):
        async for gps_global_origin in drone.telemetry.gps_global_origin():
            print(f"Latitude: {gps_global_origin.latitude_deg}")

I get the following error, though:
Task exception was never retrieved
future: <Task finished name='Task-3' coro=<print_latitude() done, defined at /Users/user/Documents/example_heading.py:20> exception=AttributeError("'Telemetry' object has no attribute 'gps_global_origin'")>
Traceback (most recent call last):
  File "/Users/user/Documents/example_heading.py", line 21, in print_latitude
    async for gps_global_origin in drone.telemetry.gps_global_origin():
AttributeError: 'Telemetry' object has no attribute 'gps_global_origin'

Same happens if I attempt to access the Telemetry object with "drone.telemetry.GpsGlobalOrigin()". Both fail when I'm outside. Could you provide insight on the mistake I am making here?

Latitude, Longitude and Altitude are available at The Position object , for getting latitude you should use:
async def print_position(drone):
    async for position in drone.telemetry.position():
        print(position.latitude_deg)

here is what available at the position class:

PS: the problem was that there is no attribute called 'gps_global_origin' in the telemetry object, here is the full documentation of the telemetry class Telemetry Definition

@MehdiRifi Awesome, thank you.
In the documentation, I also found this command in the Telemetry class that addresses the GpsGlobalOrigin() attribute. However, I'll be using Position() instead, so I won't be using the attribute.
get_gps_global_origin()

Thank you again MehdiRifi for all of your help with this issue.


When i open vscode in directory with venv/ folder, it does not detect virutalenviroment

Environment data

VS Code version: 1.56.2
Extension version (available under the Extensions sidebar): v2021.5.842923320
OS and version: Windows 10 20H2
Python version (& distribution if applicable, e.g. Anaconda): 3.8.8
Type of virtual environment used (N/A | venv | virtualenv | conda | ...): venv
Relevant/affected Python packages and their versions: XXX
Relevant/affected Python-related VS Code extensions and their versions: XXX
Value of the python.languageServer setting: Pylance

[NOTE: If you suspect that your issue is related to the Microsoft Python Language Server (python.languageServer: 'Microsoft'), please download our new language server Pylance from the VS Code marketplace to see if that fixes your issue]
Expected behaviour
Detect virtual enviroment in current directory
Actual behaviour
Does not detect it even if creating from the vscode terminal
Steps to reproduce:
[NOTE: Self-contained, minimal reproducing code samples are extremely helpful and will expedite addressing your issue]

code .  in directory with venv

Logs

Output for Python in the Output panel (View→Output, change the drop-down the upper-right of the Output panel to Python)

User belongs to experiment group 'pythonaacf'
User belongs to experiment group 'pythonJoinMailingListVar2'
User belongs to experiment group 'pythonJediLSP'
User belongs to experiment group 'pythonDiscoveryModuleWithoutWatcher'
User belongs to experiment group 'pythonTensorboardExperiment'
User belongs to experiment group 'pythonSurveyNotification'
User belongs to experiment group 'PythonPyTorchProfiler'
User belongs to experiment group 'ShowExtensionSurveyPrompt - enabled'
User belongs to experiment group 'CollectLSRequestTiming - control'
Python interpreter path: ~\AppData\Local\Programs\Python\Python38\python.exe
Starting Pylance language server.
> conda --version

Doesnt work even with folder with only venv and python file

Any ideas?

Hi, can you please first try to restart the extension. If that not works can you please tell us how did you create the venv. Thanks.

Restarted extension: nothing
I created venv multiple ways and no one worked:

python -m venv .venv and then code .
code . in empy dir and python -m venv .venv
I even tried virtualenv and didn't work and I tried to name the virtual environments these names and it didnt work:
venv
.venv
env
.env`

I run into the same issue. Started working on one of my Python projects again after 2 months and now the virtual environments in my project/workspace folders are not detected anymore. After I choose a venv interpreter as an attempt to get it to work it says "Select Python Interpreter" in the status bar instead of the one I chose. I have a different virtual environment for every Python project with a folder called "venv" inside the project/workspace directory. This still worked only 2 months ago.


IntelliJ implementation for super-initializer parameters

See https://github.com/dart-lang/sdk/issues/48055 for the main tracking issue.

cc @jwren

Note: in our planning meeting on Dec 13, it was suggested that when the user hovers over an optional super parameter that inherits a default value from the corresponding parameter on the base class, the IDE should show the default value that's being inherited from the base class constructor.  Doing so requires work in the analysis server, and possibly in some of the IDE integration logic.


pana should enable super mixins over flutter packages

URL: https://pub.dartlang.org/packages/pdrpulm#-analysis-tab-
Pretty easy
analyzer:
  strong-mode: true
  language:
    enableSuperMixins: true

Not sure if we should do all of these for flutter -
https://github.com/flutter/flutter/blob/37f216bfabfb2cba3a882c819e373b141a1aac89/packages/flutter/lib/analysis_options_user.yaml#L22

We could just use this file straight from the cloned flutter SDK, right @isoos ?

Supermixin is not available on the web, so the setting mustn't be global. If the package is known to be flutter-only, we could use the stricter superset of the settings, and also enable the supermixin.

Will be fixed when we land pana 0.8.1 - https://github.com/dart-lang/pub-dartlang-dart/issues/833

This is fixed in latest analysis! https://analyzer-dot-dartlang-pub.appspot.com/packages/pdrpulm/0.0.2/5649050225344512


Add 'liquidhelium' to the reactor's registered fluids.

Add 'liquidhelium' to the list of fluids that can be used in the reactor - it is, naturally, incredibly cold, so absorbs heat well, but does not moderate radiation as well. It is the ideal coolant (IRL), if ever there was one.

i think your refering to actualy inworld liquid, much like cryotium
the problem with it is that helium cools by evaporation, so you would constandly need to add more.
then the presence of noble gasses like helium in a reactor is not realy smart.
in short. helium ocurs in nuclear decay its one of the reasons reactors cant be run for long at max power.. the gasses decay to krypton witch basicly go into the rods and saturate them so they wont fision
heat and radiation will speed things up.
reallife reactors that get worked hard will eventualy endup with krypton poisening and need to be powered down for the krypton to decay into rubdium to get below a level that things will chain again. or replace there fuel.
you dont want to introduce any noble gasses as they will eventually interact with the uranium after they decayed (a few times)
so id say the idea of helium in a fission reactor is a tad fubar, other non-noble gasses might do the trick. but i think the future lays in more dense metal like fluids.
fusion & helium (3) however.. thats a difrent story. tho for fission its poisen


plugin-stripe / plugin-seo: do not depend on @payloadcms/next for endpoints

Link to reproduction
No response
Payload Version
3.0.0-beta.90
Node Version
20
Next.js Version
15rc
Describe the Bug
Example:
Instead of https://github.com/payloadcms/payload/blob/4bbc593dc5936d0f53e036488680c968df20bc2c/packages/plugin-seo/src/index.tsx#L136
we should just do
 const data = await req.json!()

Reason: the Payload config depends on @payloadcms/next and so its peer dependencies. You may want to import the config outside of Next.js, like into a separate Astro website in a monorepo.
Reproduction Steps
.
Adapters and Plugins
plugin-stripe, plugin-seo

Fixed in https://github.com/payloadcms/payload/pull/7879


Make Jekyll minify generated CSS

Currently all the comment from normalize.css are left in the generated style.css file.
These can be removed, and CSS can be shrunk further, by using this setting in _config.yml:
sass:
  style: compressed

Implemented at commit 56e3fc9


fix: added new "preformatted" transform option to properly display newlines in query results

This also includes a new "multiline" column type which is assigned when a string contains newlines (\n). The initial use case for this feature was to be able to display the results of a "show create view" or "show create table" query properly without expanding the query results.

Before:

After:

"preformatted" CSS:
https://github.com/pinterest/querybook/blob/master/querybook/webapp/stylesheets/_utilities.scss
It does the same thing as expanding the cell, but it does it automatically for results with newlines without requiring the user to select the option

lgtm. @czgu do you have any other concerns?


docs: 1.17.1 kickoff

Signed-off-by: Shikugawa<EMAIL_ADDRESS>
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]

@moderation cherry-picked kafka dependency update to this. Could you take a look?

/lgtm deps

I think you need to cherry-pick #14870 to fix examples.


bug:

Describe the problem
I'm running into failures with copier update
Template
The project is internal and hosted on Gitea, so I, unfortunately, can't share it
To Reproduce

Run copier update
See error below

Logs

>copier update
Initialized empty Git repository in C:/Users/king.kyle/AppData/Local/Temp/copier.main.update_diff.itkaampw/.git/
Applying new template file: C:\Users\king.kyle\AppData\Local\Temp\copier.main.update_diff.itkaampw\pyproject_cpt-new.toml
ERROR: could not locate "C:\Users\king.kyle\AppData\Local\Temp\copier.main.update_diff.itkaampw\copier-answer.yml"

error: No such remote 'origin'
Traceback (most recent call last):
  File "c:\python39\lib\runpy.py", line 197, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "c:\python39\lib\runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "C:\Users\king.kyle\.local\bin\copier.exe\__main__.py", line 7, in <module>
  File "C:\Users\king.kyle\.local\pipx\venvs\copier\lib\site-packages\plumbum\cli\application.py", line 614, in run
    inst, retcode = subapp.run(argv, exit=False)
  File "C:\Users\king.kyle\.local\pipx\venvs\copier\lib\site-packages\plumbum\cli\application.py", line 609, in run
    retcode = inst.main(*tailargs)
  File "C:\Users\king.kyle\.local\pipx\venvs\copier\lib\site-packages\copier\cli.py", line 70, in _wrapper
    return method(*args, **kwargs)
  File "C:\Users\king.kyle\.local\pipx\venvs\copier\lib\site-packages\copier\cli.py", line 335, in main
    self.parent._worker(
  File "C:\Users\king.kyle\.local\pipx\venvs\copier\lib\site-packages\copier\main.py", line 652, in run_update
    old_worker.run_copy()
  File "C:\Users\king.kyle\.local\pipx\venvs\copier\lib\site-packages\copier\main.py", line 587, in run_copy
    self._execute_tasks(
  File "C:\Users\king.kyle\.local\pipx\venvs\copier\lib\site-packages\copier\main.py", line 187, in _execute_tasks
    subprocess.run(task_cmd, shell=use_shell, check=True, env=local.env)
  File "c:\python39\lib\subprocess.py", line 528, in run
    raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command 'git remote get-url origin' returned non-zero exit status 2.

Expected behavior
Expected update to work
Environment

OS: Windows 10
Copier version: I've tried 4.1.0, 5.1.0, and 6.0.0a7
Python version: 3.9.5
Installation method: pipx

Additional context
I'm still troubleshooting this error. I couldn't replicate the problem from a fresh copier copy .. and copier update for the same template repository. I made sure to clear the temporary clone cache, but the origin error still reappears

Update: I tested adding git+ with copier copy git+http://... . and that worked? Previously, the link had been the .git version
Possibly related to #217
Closing since this appears to be sort of resolvable


URL Broken - LOJ 1053 - False Ordering

The custom sorting tutorial link was broken added a new tutorial link.

I see.
I would have approved this if the new link you shared had the content in English. But it's Hindi.

@Tahanima can you please look into this and propose an alternative working url? Or, decide whether to accept this PR if @anikakash proposes a good new link.

@anikakash, you can use this link https://www.onlycode.in/custom-comparators-in-c/


adding a favicon

Hi, loving the app, and I think it would be even better with a favicon. I'm thinking of making a basic branch symbol with lively colors like in the app. Any thoughts?

That would be great! I’m not sure if github static hosting supports
favicons though
On Fri, Jun 7, 2019 at 12:31 AM Lucian Condrea<EMAIL_ADDRESS>wrote:

Hi, loving the app, and I think it would be even better with a favicon.
I'm thinking of making a basic branch symbol with lively colors like in the
app. Any thoughts?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/pcottle/learnGitBranching/issues/585?email_source=notifications&email_token=AAIVDH6U3ZVRNXY46FQPG5LPZIFDLA5CNFSM4HVSXGXKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GYF7OQA,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAIVDH32THT75I7JKAJS5JLPZIFDLANCNFSM4HVSXGXA
.

--
-Sent from Gmail Mobile

Sounds like it does!
https://medium.com/@LazaroIbanez/how-to-add-a-favicon-to-github-pages-403935604460
On Fri, Jun 7, 2019 at 4:52 PM Peter Cottle<EMAIL_ADDRESS>wrote:

That would be great! I’m not sure if github static hosting supports
favicons though
On Fri, Jun 7, 2019 at 12:31 AM Lucian Condrea<EMAIL_ADDRESS>wrote:

Hi, loving the app, and I think it would be even better with a favicon.
I'm thinking of making a basic branch symbol with lively colors like in the
app. Any thoughts?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/pcottle/learnGitBranching/issues/585?email_source=notifications&email_token=AAIVDH6U3ZVRNXY46FQPG5LPZIFDLA5CNFSM4HVSXGXKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GYF7OQA,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAIVDH32THT75I7JKAJS5JLPZIFDLANCNFSM4HVSXGXA
.

--
-Sent from Gmail Mobile

--
-Sent from Gmail Mobile

Made 2 designs:

I prefer the second (I would still adjust by rounding the corners and such things but have no time now). Any thoughts?

I like the second as well but being colorblind actually makes it a bit
difficult to see the blue on the pink for whatever reason (the yellow is
fine).
Mind if we tweak the colors? The first is also great as well. Thanks again!
On Sat, Jun 8, 2019 at 4:02 AM Lucian Condrea<EMAIL_ADDRESS>wrote:

Made 2 designs:
[image: untitled]
https://user-images.githubusercontent.com/17990875/59146302-2145fc80-89ed-11e9-9d3f-c5315d1d8ff5.png
[image: Learn Git Branching favicon(1)]
https://user-images.githubusercontent.com/17990875/59145980-a4fee980-89eb-11e9-9db3-f4e3ccb6dc92.png
I prefer the second (I would still adjust by rounding the corners and such
things but have no time now). Any thoughts?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/pcottle/learnGitBranching/issues/585?email_source=notifications&email_token=AAIVDHYLN43NVECUAB2SA2TPZOGUBA5CNFSM4HVSXGXKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXHSQPY#issuecomment-500115519,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAIVDH4RTMIMQAVCX5VI4ADPZOGUBANCNFSM4HVSXGXA
.

--
-Sent from Gmail Mobile

Sure thing, what colors are easier to see? Perhaps red and green on blue? I'm thinking it should somehow match the color scheme of the app

Yeah maybe keep the background and just add either a small border or black
or use those colors.
On Sat, Jun 8, 2019 at 7:06 AM Lucian Condrea<EMAIL_ADDRESS>wrote:

Sure thing, what colors are easier to see? Perhaps red and green on blue?
I'm thinking it should somehow match the color scheme of the app
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/pcottle/learnGitBranching/issues/585?email_source=notifications&email_token=AAIVDH2S6UTE3OAYDQOOYUDPZO4GBA5CNFSM4HVSXGXKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXHVIUY#issuecomment-500126803,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAIVDH5XMZBQSJ2P3RIFEFTPZO4GBANCNFSM4HVSXGXA
.

--
-Sent from Gmail Mobile

Sounds good. I'll have another go tomorrow

For future reference, this was fixed in PR #586.

I think it's better to change the purple below to pink or yellowish.

@z6102075 we ended up changing the icon colors. Check it out on the site and let us know if you like it. However, I'd be hesitant to change a live site's favicon too often


Add spaces between words and "is"

@JohnWTownsend : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Looks good. Thanks for this fix @JohnWTownsend.


Is it possible to "anchor" the last row (and ignore when sorting)?

I think this is possible with a custom sort function, but is there an easier way to "anchor" the last row of the table so that when sorting, it's always the last row?
My use case is a table where the last row is an input box to add values, and should therefore always be at the end.

Just stick it in a <tfoot>! :smile:

...come to think of it, that might not work. It should, though

Related to #123

@glittershark I just confirmed, that did not work.

:+1: I'll get on implementing this, then.

awesome. You're the man!


cell formula refering to DefinedName is not calculated correctly

Description

Here's a unit to show the issue:
func TestCalcCellValueWithDefinedName(t *testing.T) {
	cellData := [][]interface{}{
		{1, 4, nil, "Month", "Team", "Sales"},
	}
	prepareData := func() *File {
		f := NewFile()
		for r, row := range cellData {
			for c, value := range row {
				cell, _ := CoordinatesToCellName(c+1, r+1)
				assert.NoError(t, f.SetCellValue("Sheet1", cell, value))
			}
		}
		assert.NoError(t, f.SetDefinedName(&DefinedName{Name: "ref_to_sheet1_a1", RefersTo: "Sheet1!A1", Scope: "Workbook"}))
		return f
	}
	f := prepareData()
	assert.NoError(t, f.SetCellFormula("Sheet1", "C1", "=ref_to_sheet1_a1"))
	_, err := f.CalcCellValue("Sheet1", "C1")
	assert.NoError(t, err)
}

Describe the results you received:
=== RUN   TestCalcCellValueWithDefinedName

    TestCalcCellValueWithDefinedName: calc_test.go:817:
        	Error Trace:	calc_test.go:817
        	Error:      	Received unexpected error:
        	            	#NAME?
        	Test:       	TestCalcCellValueWithDefinedName
--- FAIL: TestCalcCellValueWithDefinedName (0.00s)
FAIL

Describe the results you expected:
Successful unit test
Output of go version:
go version go1.14.4 windows/amd64

Excelize version or commit ID:
Excelize 2.2.0 or commit ID 0aa15106947965bdae9daae7571a4a3f569bf32d

Environment details (OS, Microsoft Excel™ version, physical, etc.):
Windows 10

Thanks for your issue. CalcCellValue is currently in working processing, not support defined name yet.


New component proposal: Admin site

Pretty much in every project, there is some kind of admin routine. There are some key things, which are required pretty much by any product:

Users listing. As an admin, I can see who signed up along with some key user activities/metrics.
Shadow login into the user account. As an admin, I would like to be able to login into a user account to troubleshoot any kind of support issues.
Company listing. Probably optional, but pretty much any SaaS has companies.

I think we can take some core admin functionality from one of our products.

@umitskevich Can we take this component out of your last project? In a first version, I propose to start from a simple user listing and shadow login feature.


Implement observability using Prometheus ebpf_exporter

It would be great to have the functionality of ebpf_exporter also on Windows. There seems to be already work underway (https://github.com/cloudflare/ebpf_exporter/pull/130) to have the exporter support libbpf/CORE.
Implementing a Windows-port of ebpf_exporter would increase the observability of Windows using eBPF.

Blocked on bcc, and pt_regs and kprobes. #206, #731, #732.

CORE support in ebpf_exporter recently got some significant updates: https://github.com/cloudflare/ebpf_exporter/pull/130.


chore(deps): update dependency @sentry/cli to v1.51.1

This PR contains the following updates:

Package
Type
Update
Change

@sentry/cli (source)
devDependencies
patch
1.51.0 -> 1.51.1

Release Notes

getsentry/sentry-cli
v1.51.1
Compare Source

fix: Skip files larger than 1MB (#662)

Renovate configuration
:date: Schedule: At any time (no schedule defined).
:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.
:recycle: Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".
:no_bell: Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

Available now for Enterprise: Renovate Pro with real-time webhook handling and priority job queue.

:tada: This PR is included in version 3.0.48 :tada:
The release is available on:

v3.0.48
GitHub release

Your semantic-release bot :package::rocket:


Tunnel function broken

Bug description
I can't connect ssh tunnel.
Screenshots

Steps to reproduce

tap Tunnel connection
Error is thrown

The setting of the connection should be valid because I haven't changed the settings. I could had connected to the server at least untill June. I guess such failure appeared the end of July.

Hello @melonsode 👋
Thanks for your feedback 🙏
Please use this howto : https://webssh.net/documentation/help/howtos/Tunnel/NEVPNErrorDomain/
Have a nice day ☀

thank you. I have successed to connect again.


doc: Fix assets and accounts documentation

PR Checklist
PR Structure

[x] This PR has reasonably narrow scope (if not, break it down into smaller PRs).
[x] This PR avoids mixing refactoring changes with feature changes (split into two PRs
otherwise).
[x] This PR's title starts with name of package that is most changed in the PR, ex.
services/friendbot, or all or doc if the changes are broad or impact many
packages.

Thoroughness

[ ] This PR adds tests for the most critical parts of the new functionality or fixes.
[x] I've updated any docs (developer docs, .md
files, etc... affected by this change). Take a look in the docs folder for a given service,
like this one.

Release planning

[ ] I've updated the relevant CHANGELOG (here for Horizon) if
needed with deprecations, added features, breaking changes, and DB schema changes.
[ ] I've decided if this PR requires a new major/minor version according to
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.

Summary
I noticed the documentation on the accounts and assets resources does not reflect what's returned by Horizon. I updated them accordingly.

Codecov Report

Merging #1704 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1704      +/-   ##
==========================================
+ Coverage   45.14%   45.14%   +<.01%
==========================================
  Files         381      381
  Lines       25760    25760
==========================================
+ Hits        11629    11630       +1
+ Misses      12955    12953       -2
- Partials     1176     1177       +1

Impacted Files
Coverage Δ

services/horizon/internal/txsub/system.go
71.87% <0%> (+0.78%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 838ae21...ffe9762. Read the comment docs.

Should be up to date now.

Thanks @fracek!


Resource Leak False Positive

Hello!
I was testing various Java analyzer tools on different projects used as test projects. One analyzer tool was the test project of another one :-) Last time Spotbugs was the test project for Facebook Infer.
I used the latest (at the time of the test) master version of Infer, which is v1.0.0-01c8024a5. The analyzer command was: infer --keep-going --html --biabduction --bufferoverrun --eradicate --pulse --quandary --racerd --starvation -o infer-results -- ./gradlew build
Operating system is Ubuntu 18.04.1 LTS, the machine has 2 pieces of Intel Xenon X5670 CPUs which means 24 logical CPU threads. The system has 48Gb RAM.
I experienced a high number of false positives, some of them are very obvious. I am not sure whether I am doing something wrong (I miss an argument or use the wrong one) or Infer lacks some deduction capabilities. However, there are two strange resource leak errors:
#2626
spotbugs/src/main/java/edu/umd/cs/findbugs/util/Util.java:136: error: Resource Leak
resource of type java.io.FileInputStream acquired by call to FileInputStream(...) at line 136 is not released after line 136.
134.
135.       public static Reader getFileReader(String filename) throws FileNotFoundException {
136. >         return getReader(new FileInputStream(filename));
137.       }
138.
It is true that the reader is not closed in the same function where it is opened, but its reference is not lost, but returned to the caller. This is a standard pattern where the opening of streams are done indirectly by special functions.
#2724
spotbugs-ant/src/main/java/edu/umd/cs/findbugs/anttask/UnionBugs.java:150: error: Resource Leak
resource of type java.io.FileInputStream acquired to inStream by call to FileInputStream(...) at line 150 is not released after line 150.
Note: potential exception at line 151
148.        */
149.       private static void copyFile(File in, File out) throws IOException {
150. >         try (FileInputStream inStream = new FileInputStream(in);
151.                   FileOutputStream outStream = new FileOutputStream(out);) {
152.               FileChannel inChannel = inStream.getChannel();
This is a so called try-with-resources syntactical construction, introduced in Java 7. Is it not supported (yet) in Infer?
Thank you for your answers and sorry for the inconvenience.

duplicate of #619 ?


[0.74] npx react-native init should warn users but it's currently not

Description
As per RFC0759:

https://github.com/react-native-community/discussions-and-proposals/pull/759

Users on 0.74 should start seeing a warning when they run npx react-native init.
This was implemented on:

https://github.com/facebook/react-native/pull/43127

It seems like this warning is actually not working properly.
Steps to reproduce

Run npx react-native@latest init RN074 --skip-install
Observe that the warning is not emitted

React Native Version
0.74.0
Affected Platforms
Build - MacOS, Build - Windows, Build - Linux
Output of npx react-native info
Not relevant.

Stacktrace or Logs
Here the output of the log:

$ npx react-native@latest init RN074 --skip-install

               ######                ######
             ###     ####        ####     ###
            ##          ###    ###          ##
            ##             ####             ##
            ##             ####             ##
            ##           ##    ##           ##
            ##         ###      ###         ##
             ##  ########################  ##
          ######    ###            ###    ######
      ###     ##    ##              ##    ##     ###
   ###         ## ###      ####      ### ##         ###
  ##           ####      ########      ####           ##
 ##             ###     ##########     ###             ##
  ##           ####      ########      ####           ##
   ###         ## ###      ####      ### ##         ###
      ###     ##    ##              ##    ##     ###
          ######    ###            ###    ######
             ##  ########################  ##
            ##         ###      ###         ##
            ##           ##    ##           ##
            ##             ####             ##
            ##             ####             ##
            ##          ###    ###          ##
             ###     ####        ####     ###
               ######                ######

                  Welcome to React Native!
                 Learn once, write anywhere

✔ Downloading template
✔ Copying template
Resolving 1.22.22 to a url...
error https://api.github.com/repos/yarnpkg/yarn/releases: API rate limit exceeded for <IP_ADDRESS>. (But here's the good news: Authenticated requests get a higher rate limit. Check out the documentation for more details.)
yarn config v1.22.22
success Set "nodeLinker" to "node-modules".
✨  Done in 0.02s.
✔ Processing template
✔ Dependencies installation skipped

info 💡 To enable automatic CocoaPods installation when building for iOS you can create react-native.config.js with automaticPodsInstallation field.
For more details, see https://github.com/react-native-community/cli/blob/main/docs/projects.md#projectiosautomaticpodsinstallation

✔ Initializing Git repository

  Run instructions for Android:
    • Have an Android emulator running (quickest way to get started), or a device connected.
    • cd "/private/tmp/RN074" && npx react-native run-android

  Run instructions for iOS:
    • cd "/private/tmp/RN074/ios"

    • Install Cocoapods
      • bundle install # you need to run this only once in your project.
      • bundle exec pod install
      • cd ..

    • npx react-native run-ios
    - or -
    • Open RN074/ios/RN074.xcodeproj in Xcode or run "xed -b ios"
    • Hit the Run button

  Run instructions for macOS:
    • See https://aka.ms/ReactNativeGuideMacOS for the latest up-to-date instructions.

### Reproducer

N/A

### Screenshots and Videos

N/A

cc @byCedric

Closing as this has been resolved


Modifying the filter on the server

Hi,  I have a scenario where I want to add additional parameters to the filter that is passed up to the server.  I'm not sure if it is possible, but any help would be appreciated.
Thanks

The $filter representation is immutable so you can't modify the ODataQueryOptions.Filter.Expression object, however you could modify the incoming URL before ODataQueryOptionsHttpParameterBinding reads the URL to build the ODataQueryOptions object.
Your other option is to apply any additional constraints after parsing the ODataQueryOptions.Filter.Expression.
If you can provide an example of what you are thinking of doing and how you use the ODataQueryOptions.Filter.Expression currently, I may be able to offer some other ideas?

So what we kind of have is a multi tenant system running from one database. What I was hoping to do was to inject the 'ClientId', and maybe even a 'ClientLocationId' into every single request.  This information is stored on the server and never passed down to the client.

OK, have you written your own code to parse the ODataQueryOptions.Filter.Expression?

Not yet, I will try and take a look at that later on this evening. I'll keep you posted.

What's parsing it at the moment?


negative gauge value not supported for external probes

the external probe does not support negative gauge values which is an issue since a negative value is totally accepted in prometheus gauge definition
https://prometheus.io/docs/concepts/metric_types/
and float64 of course supports negative values.
Why this limitation in Cloudprober?
I would like to measure temperature which can go under 0 but it's currently not possible.
metrics/metrics.go
        // A float value
        case '0' <= c && c <= '9':
                f, err := strconv.ParseFloat(val, 64)
                if err != nil {
                        return nil, err
                }
                return NewFloat(f), nil

here's my logs
W1114 13:57:07.779486    9205 payload.go:267] [cloudprober.test] could not parse value (-1.0) for the new metric name (mytest): unknown value type

This is an interesting scenario. We don't even parse negative values:
https://github.com/cloudprober/cloudprober/blob/d3c7f47a9c2fbb1d9ba716da4467c8340c70ea4e/metrics/metrics.go#L49
I'll try to fix it soonish.

Thanks @manugarg


Updating AFNI dependencies

Howdy-
I recently checked in on the AFNI install on Neurodesk.  I think there are a couple of things to update there:

We now use the Python modules Flask and Flask-Cors for setting up a local server to interact with afni_proc.py's QC HTML.  Those don't appear to be available after ml afni.
We also use NiiVue as part of the same APQC HTML.  We distribute this with our binaries and as part of our build scripts, which basically means building+copying in a compiled niivue_afni.umd.js file in the same location as the main AFNI binaries (i.e., where which afni points).  We actually put a copy of the niivue_afni.umd.js file that we build in an openly accessible spot for ease of access, and so it could be gotten with: curl -O https://afni.nimh.nih.gov/pub/dist/bin/misc/niivue_afni.umd.js

It would be great if both of those aspects could be updated.
thanks,
pt

This is now completed in our latest afni container with version 24.3.00

Thank you for flagging this with us:)


[5.5] In WMO, treat all inputs as displayInputs for parsable-output

Cherry-pick of https://github.com/apple/swift-driver/pull/671
Otherwise these jobs today have input-less parsable-output:
  "command_executable" : "\/usr\/bin\/swift-frontend",
  "inputs" : [

  ],
  "kind" : "began",

Resolves rdar://78321174

@swift-ci please test


Checkbox convert

Describe the bug
context
When I save file with checkbox.
- [ ] a
- [x] b
- [X] c

expectation
- [ ] a
- [x] b
- [X] c

bug
but i get
- /[ /] a
- /[x/] b
- /[X/] c

Reproduce the bug

List your environment

Task lists are not included in CommonMark specification so mdformat has no support out of the box. Please install mdformat-gfm.


StringBuilder.Length should have setter

It is a read/write property.

Probably can just be a Field.


Add allergies exercise

@BNAndras could you please take a look? ;)

Looks good. I’ll need to compare with the canonical data.

@BNAndras thank you for your review, I will update my code soon ;) Could you please check if other PRs also need any changes?

@BNAndras Sorry for the delay :) I've added comments to split the tests into groups, like in the canonical data. I've also added a prefixe to each test to indicate the group.


[OTHER]

📝 Other Issue
Description
Improve and add data to the property listing page
Type of Issue
Select the type of issue:

[ ] 📄 Documentation
[ ] 🛠 Build/Deployment
[*] 🖼 UI/UX Design
[ ] ⚙ Performance
[ ] Other (please specify)

Steps to Reproduce (if applicable)
go to the propery listing page or click
https://visionary-fenglisu-db1b1d.netlify.app/dashboard/propertylisting
Additional Context

I would like to add more data to this page
Only 3 houses for rent dont look good
This page needs work in UI AND UX
I would like to work under Gssoc Extd 2024 an Hacktoberfest 2024

Checklist

[*] I have searched the existing issues, and this issue is not a duplicate.
[*] I have starred this repository.
[*] I have provided all necessary details.

📝 Other Issue
Description
Improve and add data to the property listing page
Type of Issue Select the type of issue:

[ ]  📄 Documentation
[ ]  🛠 Build/Deployment
[*] 🖼 UI/UX Design
[ ]  ⚙ Performance
[ ]  Other (please specify)

Steps to Reproduce (if applicable)
go to the propery listing page or click
https://visionary-fenglisu-db1b1d.netlify.app/dashboard/propertylisting
Additional Context

I would like to add more data to this page
Only 3 houses for rent dont look good
This page needs work in UI AND UX
I would like to work under Gssoc Extd 2024 an Hacktoberfest 2024

Checklist

[*] I have searched the existing issues, and this issue is not a duplicate.
[*] I have starred this repository.
[*] I have provided all necessary details.


Enforce stricter checks for book equality

Closes #146

Codecov Report

Merging #155 (d1cc94a) into master (f167553) will decrease coverage by 2.49%.
The diff coverage is 28.81%.

 Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


ResultSet executeQuery(Map<ClickHouseQueryParam, String> additionalDBParams, List externalData) throws SQLException;

Describe the bug
I occasionally report an error when I use this function in JDBC to add external data in batches.
Each error is caused by the format of the data sample.
The sample position is different each time the error is reported.
When I reduce the amount of data, it works.
I have tried to use Wireshark to capture packets. It is found that the request data packets received by the server when the request fails are the same as those received by the server when the request succeeds.
Code example
try (PreparedStatement statement = prepareStatement(dataSource, sql)) {
List useData = new ArrayList<>();
for (int i = 0; i < externalData.size(); i++) {
ClickHouseExternalData tmpData = externalData.get(i);
useData.add(new ClickHouseExternalData(tmpData.getName(),
new ByteArrayInputStream(input.get(i).getBytes(StandardCharsets.UTF_8)))
.withStructure(tmpData.getStructure()).withFormat(tmpData.getFormat()));
}
ClickHousePreparedStatement clickHousePreparedStatement = (ClickHousePreparedStatement) statement;
try (ResultSet rs = clickHousePreparedStatement.executeQuery(null, useData)){
LOGGER.debug("ExecuteShardQuery: {},Use DataSource Url: [{}]", exeMethod,
dataSource.getAllClickhouseUrls());
return callBack.call(rs);
}
}
Error log
First error log
2023.05.18 10:19:55.190332 [ 27874 ] {}  DynamicQueryHandler: Code: 27, e.displayText() = DB::ParsingException: Cannot parse input: expected '\t' before: '\nsi\tslot1202\nsi\tslot1203\nsi\tslot1204\nsi\tslot1205\nsi\tslot1206\nsi\tslot1207\nsi\tslot1208\nsi\tslot1209\nsi\tslot1210\nsi\tslot1211\nsi\tslot1212\nsi\tslot1213\nsi\tslot1214\nsi\t':
Row 1203:
Column 0,   name: tagname,  type: String, parsed text: "si"
Column 1,   name: tagvalue, type: String, parsed text: "slot1201"
Row 1204:
Column 0,   name: tagname,  type: String, parsed text: "201"
ERROR: Line feed found where tab is expected. It's like your file has less columns than expected.
And if your file have right number of columns, maybe it have unescaped backslash in value before tab, which cause tab has escaped.
: While executing SourceFromInputStream: (at row 1204)
, Stack trace (when copying this message, always include the lines below):

DB::throwAtAssertionFailed(char const*, DB::ReadBuffer&) @ 0x8667d25 in /usr/bin/clickhouse
DB::TabSeparatedRowInputFormat::readRow(std::__1::vector<COWDB::IColumn::mutable_ptrDB::IColumn, std::__1::allocator<COWDB::IColumn::mutable_ptrDB::IColumn > >&, DB::RowReadExtension&) @ 0xfa43b52 in /usr/bin/clickhouse
DB::IRowInputFormat::generate() @ 0xf970c58 in /usr/bin/clickhouse
DB::ISource::tryGenerate() @ 0xf8ff205 in /usr/bin/clickhouse
DB::ISource::work() @ 0xf8fedfa in /usr/bin/clickhouse
DB::ParallelParsingInputFormat::InternalParser::getChunk() @ 0xf9c7aae in /usr/bin/clickhouse
DB::ParallelParsingInputFormat::parserThreadFunction(std::__1::shared_ptrDB::ThreadGroupStatus, unsigned long) @ 0xf9c710e in /usr/bin/clickhouse
ThreadPoolImpl::worker(std::__1::__list_iterator<ThreadFromGlobalPool, void*>) @ 0x8654088 in /usr/bin/clickhouse
ThreadFromGlobalPool::ThreadFromGlobalPool<void ThreadPoolImpl::scheduleImpl(std::__1::function<void ()>, int, std::__1::optional)::'lambda1'()>(void&&, void ThreadPoolImpl::scheduleImpl(std::__1::function<void ()>, int, std::__1::optional)::'lambda1'()&&...)::'lambda'()::operator()() @ 0x865603f in /usr/bin/clickhouse
ThreadPoolImplstd::__1::thread::worker(std::__1::__list_iterator<std::__1::thread, void*>) @ 0x865165f in /usr/bin/clickhouse
? @ 0x86550f3 in /usr/bin/clickhouse
start_thread @ 0x7dc5 in /usr/lib64/libpthread-2.17.so
__clone @ 0xf9d1d in /usr/lib64/libc-2.17.so
(version <IP_ADDRESS> (official build))

Second error log
2023.05.18 10:26:41.058246 [ 2668 ] {}  void DB::ParallelParsingInputFormat::onBackgroundException(size_t): Code: 27, e.displayText() = DB::ParsingException: Cannot parse input: expected ',' before: '\nsi,slot1706\nsi,slot1707\nsi,slot1708\nsi,slot1709\nsi,slot1710\nsi,slot1711\nsi,slot1712\nsi,slot1713\nsi,slot1714\nsi,slot1715\nsi,slot1716\nsi,slot1717\nsi,slot1718\nsi,':
Row 1707:
Column 0,   name: tagname,  type: String, parsed text: "si"
Column 1,   name: tagvalue, type: String, parsed text: "slot1705"
Row 1708:
Column 0,   name: tagname,  type: String, parsed text: "5"
ERROR: Line feed found where delimiter (,) is expected. It's like your file has less columns than expected.
And if your file have right number of columns, maybe it have unescaped quotes in values.
: (at row 1708)
, Stack trace (when copying this message, always include the lines below):

DB::throwAtAssertionFailed(char const*, DB::ReadBuffer&) @ 0x8667d25 in /usr/bin/clickhouse
? @ 0xf991adb in /usr/bin/clickhouse
DB::CSVRowInputFormat::readRow(std::__1::vector<COWDB::IColumn::mutable_ptrDB::IColumn, std::__1::allocator<COWDB::IColumn::mutable_ptrDB::IColumn > >&, DB::RowReadExtension&) @ 0xf991c2e in /usr/bin/clickhouse
DB::IRowInputFormat::generate() @ 0xf970c58 in /usr/bin/clickhouse
DB::ISource::tryGenerate() @ 0xf8ff205 in /usr/bin/clickhouse
DB::ISource::work() @ 0xf8fedfa in /usr/bin/clickhouse
DB::ParallelParsingInputFormat::InternalParser::getChunk() @ 0xf9c7aae in /usr/bin/clickhouse
DB::ParallelParsingInputFormat::parserThreadFunction(std::__1::shared_ptrDB::ThreadGroupStatus, unsigned long) @ 0xf9c710e in /usr/bin/clickhouse
ThreadPoolImpl::worker(std::__1::__list_iterator<ThreadFromGlobalPool, void*>) @ 0x8654088 in /usr/bin/clickhouse
ThreadFromGlobalPool::ThreadFromGlobalPool<void ThreadPoolImpl::scheduleImpl(std::__1::function<void ()>, int, std::__1::optional)::'lambda1'()>(void&&, void ThreadPoolImpl::scheduleImpl(std::__1::function<void ()>, int, std::__1::optional)::'lambda1'()&&...)::'lambda'()::operator()() @ 0x865603f in /usr/bin/clickhouse
ThreadPoolImplstd::__1::thread::worker(std::__1::__list_iterator<std::__1::thread, void*>) @ 0x865165f in /usr/bin/clickhouse
? @ 0x86550f3 in /usr/bin/clickhouse
start_thread @ 0x7dc5 in /usr/lib64/libpthread-2.17.so
__clone @ 0xf9d1d in /usr/lib64/libc-2.17.so
(version <IP_ADDRESS> (official build))

Configuration
Environment

Client version: ru.yandex.clickhouse clickhouse-jdbc 0.3.2
Language version: jdk 1.8
OS: win10

ClickHouse server

ClickHouse Server version: <IP_ADDRESS>
ClickHouse Server non-default settings, if any:
CREATE TABLE statements for tables involved:
Sample data for all these tables, use clickhouse-obfuscator if necessary

Hi @rhy429081492, have you validated data captured by Wireshack? Taking the first error log as an example, did you see  si\tslot1201\n201\nsi\tslot1202 in Wireshack? Is that same as in the input.get(i)? If you're certain that you passed valid data to the JDBC driver, then it could be a bug.
Lastly, please pay attention that you're using an obsoleted driver which is no longer supported. I'd suggest you upgrade to a more recent version like 0.4.6.

Hi @rhy429081492, have you validated data captured by Wireshack? Taking the first error log as an example, did you see si\tslot1201\n201\nsi\tslot1202 in Wireshack? Is that same as in the input.get(i)? If you're certain that you passed valid data to the JDBC driver, then it could be a bug.
Lastly, please pay attention that you're using an obsoleted driver which is no longer supported. I'd suggest you upgrade to a more recent version like 0.4.6.
I confirm that the packets captured by Wireshark contain this information.
The data is valid. This problem occurs only when the data volume increases.
Initially, my main purpose is to solve the problem that the latency increases due to excessive data after the in statement.
In the latest version of the JDBC client, the interface that I use is no longer available. Use the new interface to solve this problem by creating temporary tables. However, the way temporary tables are created is not ideal for performance optimization. Does not perform as well as the interface I raised the issue with.
When creating a temporary table, the new interface communicates with the server for multiple times. The packet of the new interface is completely different from that of the interface used by me.
I'd rather do something similar to this in clickhouse docs. https://clickhouse.com/docs/en/engines/table-engines/special/external-data

Use the new interface to solve this problem by creating temporary tables. However, the way temporary tables are created is not ideal for performance optimization. Does not perform as well as the interface I raised the issue with.

Are you referring to the following example? The name might indeed be somewhat confusing. Internally, it utilizes an external table within the same http request. Moreover, you can invoke the ClickHouseExternalData.asTempTable() function if you prefer to employ a temporary table instead of an external table. This can be particularly useful for handling complex data types, as mentioned in ClickHouse/ClickHouse#32171.
https://github.com/ClickHouse/clickhouse-java/blob/c25ffc62c886c0cdc1fcf8d8bf2234690c131dca/examples/jdbc/src/main/java/com/clickhouse/examples/jdbc/Advanced.java#L63-L83
In conclusion, if your application demands high performance, I strongly recommend upgrading to 0.3.2-patch11(use com.clickhouse.jdbc.ClickHouseDriver since both old and new drivers co-exist in 0.3.2). This version offers a significant speed increase compared to its predecessors, as detailed in #768. Additionally, version 0.4 doubles the performance of nested type serialization. Furthermore, you might consider utilizing the Java client, which provides a lower-level API with minimal overhead, typically resulting in superior performance.


Not showing any trending repos

Yesterday everything worked fine, today nothing. No languages work either.

It's a network or server error.
You can pull to refresh it, or try it later


Running Litmus workflows in Openshift throws "cannot set blockOwnerDeletion if an ownerReference refers to a resource you can't set finalizers on:"

Bug
What happened:
I deployed Litmus 2.6 on Openshift in a disconnected environment. While I had issues with RBAC for starting Litmus, I finally got everything working and Litmus seems to be running fine.
Next I wanted to run the workflow to do some chaos experiments in the cluster
What you expected to happen:
I expected the workflow to run or atlesat kickoff
How to reproduce it (as minimally and precisely as possible):
Deploy it in an Openshift cluster
Anything else we need to know?:
When I try to schedule a workflow using Litmus Portal Chaos Hub I can see the following errors in the Workflow Operator.
pods "custom-chaos-workflow-1647427227-1647432738-3411883899" is forbidden: cannot set blockOwnerDeletion if an ownerReference refers to a resource you can't set finalizers on: , " namespace=litmus workflow=custom-chaos-workflow-1647427227-1647432738
Also attaching the logs
LitmusWorkflowLogs.txt

Thanks for the issue, we're taking a look at this.

We have fixed the permission in RBAC for the same. Refer the release notes: 2.12.0.


[FR] Switch ID and Name

What happened?
Just recently I replaced a handful of devices and as a consequence had to rework all logic that relied on these devices due to a change in the IEEE address.
What did you expect to happen?
I'd like to ask for an option to switch ID (IEEE address) and the device name, so that the data-point contains the device name instead of the IEEE address.
In my view this has some advantages:

Devices with the same end-points can easily be replaced by a different model with the same end-points
The device name is easier to follow inside some logic (scripts, Node Red etc)
It aligns with the zigbee2mqtt logic as it also uses the "friendly name" for its messages

To avoid breaking existing logics, this could be a setting that defaults to the current naming scheme.
Thanks for this incredibly useful adapter and thanks in advance for giving this proposal some thoughts.
How to reproduce it (minimal and precise)
n/a
Adapter version
v2.13.6
Adapter Config Log
n/a
Log
n/a

this adapter is like zigbee adapter.. with same logic.. and NO we dont switch the ID to name..
its maybe for you project better but not for all.. sry


Fixed error of pint from previous commit and added new functionality

Fixed an issue where if we passes a BaseQuantiy it will try to
override it and remove its units. Now, it just return the Class
itself,
Added new functionallity to pass any float or int and will convert it
to the unit that was specificed on the Field. This requires
base__unit to exists.
Added better serialization where we can pass custom dictionary to
change the serialization of a pint.Quantity. By default, it return a
string of the quantity (e.g. '10 volt'), but now if we just want to
export the magnitude we pass
.model_dump(context={"magnitude_only":True}) will return '10'

Codecov Report
Attention: Patch coverage is 33.33333% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 94.08%. Comparing base (dd818c2) to head (0e443c2).

Files
Patch %
Lines

src/infrasys/base_quantity.py
33.33%
14 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #26      +/-   ##
==========================================
- Coverage   95.44%   94.08%   -1.37%
==========================================
  Files          25       25
  Lines        2131     2130       -1
==========================================
- Hits         2034     2004      -30
- Misses         97      126      +29

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


⚠ Bofrost.lu has degraded performance

In 8b70a31, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1039 ms

Resolved: Bofrost.lu performance has improved in 6088620 after 6 minutes.


📦 Adds support for Swift Package plugin command

Following a conversation with @krzysztofzablocki and the creation of issue #1090, this PR starts the work to add support for Swift Package Plugins for Sourcery
At the moment, this PR only includes support for Swift Package command plugins but not for build plugins yet, I'll be investigating those next as there are a set of challenges which must be overcome.
This PR also updates to using swift-tools version 5.6 to be able to make use of SPM plugins.
Discussion
I have left the --disableCache flag in this PR as I wanted to hear your opinion on how we can tackle the issue. From what I can see, since cacheBasePath is only an argument on config and not a cli argument, we have a few options:

Remove the --disableCache parameter and not do anything else. The client will have to provide a cacheBasePath in the configuration file that is within the package directory. It might be a bit misleading and the plugin won't work out of the box.
Read and re-write the .sourcery.yml to always provide a cacheBasePath that is in the pluginWorkDirectory. This could be done only when the key isn't present on the .sourcery.yml file?
Make cacheBasePath a command line argument which can be used only when the config key isn't present. This allows the package to provide a 'default value' that works while allowing the user to modify it?

I think my preferred option is the last one, but keen to hear your thoughts as you might have a different opinion on it 👍
How to test the plugin
I have create a small repo called sourcery-plugins-playground which will help with the testing. There are two folders:
swift-package-playground
Command Line

cd into swift-package-playground.
Do swift package plugin --list and verify that sourcery-command is part of the list.
Run swift package --allow-writing-to-package-directory sourcery-command.
Assert that a file named AutoMockable.generated.swift is generated in the right directory.

Xcode 14

cd into swift-package-playground.
Open Package.swift
Right click on swift-package-playground package
Run the sorcery-command from the list.
This should generate the same file.

xcodeproj-playground
Xcode 14

cd into xcodeproj-playground.
Open SourceryPluginSampleProj.xcodeproj
Right click on the project and select the plugin
The file that is missing should now be present, you can see it in the file explorer.

@pol-piella I agree with 3rd option sounding the most reasonable

@pol-piella I agree with 3rd option sounding the most reasonable

Amazing! I will get that done and let you know when it’s ready to be reviewed again. So excited to get this into Sourcery ❤

          1 Error

:no_entry_sign:
Any changes to library code need a summary in the Changelog.

  Generated by :no_entry_sign: Danger

@krzysztofzablocki Updated with the changes suggested to provide a default cache path 👍
Let me know if you're happy with the changes and we can get it merged 🚀

lgtm, you can go ahead and merge 👏


web ui cannot login

Describe the bug
The OAuth2 request resulted in an error
i installed Self-Hosted Pixie，when login the web ui ，got this error
all pods  is in runnging state，please help me solve this.
The OAuth2 request resulted in an error.
Error: invalid_client
Description: Client authentication failed (e.g., unknown client, no client authentication included, or unsupported authentication method). The requested OAuth 2.0 Client does not exist.
Hint:
Debug:
You are seeing this page because configuration key urls.error is not set.

If you are an administrator, please read [the guide](https://www.ory.sh/docs) to understand what you need to do. If you are a user, please contact the administrator.

[root@wf-dev-mid-k8s-m ~]#kubectl get po -n plc
NAME                                       READY   STATUS    RESTARTS      AGE
api-server-5786447d4d-gmbwj                1/1     Running   2 (75m ago)   76m
artifact-tracker-server-866c4445bc-7s69t   1/1     Running   1 (76m ago)   76m
auth-server-7bb85d5b68-j2bz6               1/1     Running   1 (76m ago)   76m
cloud-proxy-56dc46fd6-bbwpm                2/2     Running   3 (75m ago)   76m
config-manager-server-5dbf7f8c6c-q7zvt     1/1     Running   0             76m
cron-script-server-97b698d6c-wkf4s         1/1     Running   3 (76m ago)   76m
hydra-db5559f85-pxg2k                      2/2     Running   0             76m
indexer-server-57b48dcbfb-hq8tb            1/1     Running   3 (75m ago)   76m
kratos-bb9cd6c6f-t28nr                     2/2     Running   0             76m
metrics-server-d5c5bfbbc-47jpk             1/1     Running   3 (76m ago)   76m
pl-elastic-es-data-0                       1/1     Running   0             76m
pl-elastic-es-master-0                     1/1     Running   0             76m
pl-elastic-es-master-1                     1/1     Running   0             76m
pl-nats-0                                  1/1     Running   0             77m
pl-nats-1                                  1/1     Running   0             76m
pl-nats-2                                  1/1     Running   0             75m
plugin-server-7976c454dc-znn49             1/1     Running   1 (76m ago)   76m
postgres-7879b5f8cc-7wk69                  1/1     Running   0             77m
profile-server-768679bb7d-68n7g            1/1     Running   1 (76m ago)   76m
project-manager-server-9574475f-s4285      1/1     Running   1 (76m ago)   76m
scriptmgr-server-6bf4c74686-mjmbt          1/1     Running   0             76m
vzconn-server-88977684d-flh59              1/1     Running   4 (76m ago)   76m
vzmgr-server-77f4585d5-m22fx               1/1     Running   4 (75m ago)   76m

I had the same problem.
Navigate to dev.withpixie.dev requests https://work.dev.withpixie.dev/api/authorized and return "failed to fetch token - unauthenticated"

any updates?

FYI, we have the same issue - across several installations. It actually seems to be the norm rather than the exception.
Upon investigating more, we found that the kratos deployment is at fault. It has a secondary container that is supposed to execute this once to completion:
set -x;

URL="${ADMIN_URL}/admin/health/ready";
until [ $(curl -m 0.5 -s -o /dev/null -w "%{http_code}" --cacert /certs/ca.crt ${URL}) -eq 200 ];
    do echo "waiting for ${URL}";
    sleep 2;
done;

curl --cacert /certs/ca.crt -s -H "Content-Type: application/json" --data "${ADMIN_IDENTITY}" "${ADMIN_URL}/admin/identities";
sleep infinity;

but in the deployments where we see the error, this second container never passes the "awaiting readiness" stage (the until -> curl -> done code).
Interestingly, the main container is up and working correctly, so it seems something is either wrong with the API reporting readiness or with the above command checking for it.
To bypass the auth-issue, it's as simple as executing the identity creation command that would be executed, if only the readiness check were to pass. Interestingly it won't work on the pod IP, so you can just use localhost (as the secondary container is in the same pod):
get a shell on the secondary container inside the kratos pod:
kubectl -n plc exec -ti  kratos-<your-kratos-pod-name> -c admin-create-if-not-exists -- sh`

and then execute the second part of the container code:
curl \
  --insecure \
  --cacert /certs/ca.crt \
  -H "Content-Type: application/json" \
  --data "${ADMIN_IDENTITY}" \
  "https://localhost:4434/admin/identities"

the only thing we added was --insecure (since we're talking to localhost) and -v instead of -s
This will create the "admin" identity that is needed to login


[21.11] mysql80: 8.0.26 -> 8.0.28

Motivation for this change
Backport of #157386 and #152706.
https://www.oracle.com/security-alerts/cpujan2022.html#AppendixMSQL
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 160350 run on x86_64-linux 1

2 packages built:

libmysqlconnectorcpp
mysql80

Result of nixpkgs-review pr 160350 run on x86_64-linux 1

2 packages built:

libmysqlconnectorcpp
mysql80


Qualify CannotMockFinalClass

As of Mockito 2.1 one can mock final classes. This is an opt-in feature, enabled by storing the value mock-maker-inline in the mockito-extensions/org.mockito.plugins.MockMaker classpath resource.
Suggestions:

Update the CannotMockFinalClass documentation and error message, to inform users about this new feature. (And if used, they'll have to disable this check.)
(Preferred.) Have the checker look for the presence of the aforementioned classpath resource and warn about mocked final classes only in the "inline mock maker" is not enabled.

NB: I started working on a PR for option (2), but hit an issue: the only classloader using which I can seem to find the resource is the one returned by JavacProcessingEnvironment.instance(state.context).getProcessorClassLoader().  Using that classloader I have a passing Error Prone unit test, and it also seems to work in a simple Maven project in which Error Prone is enabled. But this classloader no longer exposes the resource once the maven-compiler-plugin is configured with custom <annotationProcessorPaths>. Given the method's name this doesn't surprise me at all, but the question is then: how does one properly look up resources on the compile classpath?
(If the above blurb of text is unclear, I can open a PR to showcase the current approach.)

Yesterday Mockito 5.0.0 was released, and with it mock-maker-inline became the default. This means that final classes can now be mocked by default. This might cause more people to hit this issue.
Next to the two options suggested above, there's also third option: rename the check to  DoNotMockFinalClass, making it a sibling of DoNotMockAutoValue and DoNotMockChecker. Then users can en- or disable the check on ideological grounds.
@lowasser I see that you're the original author of the check; WDYT?
NB: W.r.t. the issue I hit with solution (2): this approach might work, but that's to be tested.


The text shape when using Attention

Hi, thank you for sharing such great work! I am a novice and found sth i cannot understand:
The AttnLabelConverter encodes the labels into text, length. The text has shape [batch_size, max_length+2] where '2' means [go] and [stop].
When the text pass into Attention.forward(), however, the notes said text : the text-index of each image. [batch_size x (max_length+1)]. +1 for [GO] token. text[:, 0] = [GO].
Are these two text the same object? If so, why the shape is different?
Thanks for you help!

@SakuraRiven
Hello,
Yes, they are the same object.
I just fix it, with below code :)
https://github.com/clovaai/deep-text-recognition-benchmark/blob/a239f46df35b85f5c39af9f74152bd45b1301639/train.py#L138
Before fixed it, even if the model get input 'text' whose shape is [batch_size, max_length+2], the attention decoder loops [batch_size, max_length+1] as below.
https://github.com/clovaai/deep-text-recognition-benchmark/blob/a239f46df35b85f5c39af9f74152bd45b1301639/modules/prediction.py#L30
Thus, the result would be the same before :)
best.


Is it possible assign affinity field to workflow?

I'd like to add the affinity filed in the workflow spec, but in the docs and the code I don't find the correct way.
is it possible with Hera?
In my yaml I write this code, as indicated in the documentation Affinity.
affinity:
  nodeAffinity:
    requiredDuringSchedulingIgnoredDuringExecution:
      nodeSelectorTerms:
        - matchExpressions:
            - key: node_group
              operator: In
              values:
                - argo-workflow

Hi @MichaelLan! Not yet 🙂 this is a feature that would be great for Hera. I am going to mark this as an enhancement. In the mean time, since Hera uses the auto-generated Argo SDK, you can expand on Hera by using that. Here's an example with affinity:
"""This example showcases the hello world example of Hera"""
from argo_workflows.models import (
    Affinity,
    NodeAffinity,
    NodeSelector,
    NodeSelectorRequirement,
    NodeSelectorTerm,
)

from hera.task import Task
from hera.workflow import Workflow
from hera.workflow_service import WorkflowService

def hello():
    print('Hello, Hera!')

# TODO: replace the domain and token with your own
ws = WorkflowService(host='https://my-argo-server.com', token='my-auth-token')
w = Workflow('hello-hera', ws)

t = Task('t', hello)
setattr(
    t.argo_template,
    'affinity',
    Affinity(
        node_affinity=NodeAffinity(
            required_during_scheduling_ignored_during_execution=NodeSelector(
                node_selector_terms=[
                    NodeSelectorTerm(
                        match_expresssions=[
                            NodeSelectorRequirement(key='node_group', operator='In', values=['argo-workflow'])
                        ]
                    )
                ]
            )
        )
    ),
)
t.argo_task = t.get_task_spec()

w.add_task(t)
w.create()

Excellent, but is it in the workflow spec? WorkflowSpec Docs

If you'd like to set it on the workflow you can write the same affinity as above but set the attribute of w.spec! 🙂

@MichaelLan would you like to contribute a way to set the affinity in Hera? 🙂

Yes, I would like to contribute. I'm also working in this feature https://github.com/argoproj-labs/hera-workflows/issues/120#issue-1194474317

:+1:, would also like this feature!


Absolute value bars

Currently unable to write absolute value bars in Drasil.

Again, please provide an example of where it is necessary and I'll get on it.

Sure. Once again, I need it for an equation in a table. I don't actually have an example for the abs themselves, but I do have one for the norm below and I assume they're closely related:

Abs is implemented, norm is not yet.

Closing this as there is a separate issue (#23) for norm.


Ds 3689 facet dates in DiscoverQuery

JIRA ticket
https://jira.duraspace.org/projects/DS/issues/DS-3689
The addition of date facets can be done similarly to "normal" facet fields

@jonas-atmire : I'd recommend resubmitting this against dspace-6_x.  As DSpace 6 is the latest release, new features should be aimed at that release.  While there may be additional DSpace 5 releases, they are no longer guaranteed, and in fact will only occur to backport fixes to any discovered major bugs and/or security fixes (if any).  So, new features or code improvements should be aimed at DSpace 6 at this time.  Thanks!

Closing, replaced by #1849


Update intro/index.html with meaning of acronyms

Hello,
I just wanted to help the readability of this nice introduction,
by giving the meaning of acronyms for non-specialists like me :).
Best regards,
Laurent Lyaudet

Hello @bhosmer :)
You're welcome !
I corrected the typo FFA -> FFN as you requested :)


[Event Request] Table 38 - "PurhaseHeader" OnValidateLocationCodeBeforeTestStatusOpen

Could you please add an integration event OnValidate of "Location Code" field of table 38, as per below sample of code?
field(28; "Location Code"; Code[10])
{
Caption = 'Location Code';
TableRelation = Location WHERE("Use As In-Transit" = CONST(false));
        trigger OnValidate()
        begin
           **_**OnValidateLocationCodeBeforeTestStatusOpen(Rec, IsHandled);
           if IsHandled then
                exit;**_**

            TestStatusOpen();
            if ("Location Code" <> xRec."Location Code") and
               (xRec."Buy-from Vendor No." = "Buy-from Vendor No.")
            then
                MessageIfPurchLinesExist(FieldCaption("Location Code"));

            UpdateShipToAddress();
            UpdateInboundWhseHandlingTime;
        end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


When asp.net core sends a confirm email, it adds "amp;" string after the & sign inside a link

I am currently working with ASP.NET CORE 2.0
When a user registers the server sends a confirmation link to the email, so that the user can confirm his/her email.
Here is the link:
https://localhost:44388/Account/ConfirmEmail?userId=eb550f3a-a518-40ca-bcbc-954960f95ebe&code=CfDJ8IqAQvtamy5FgGRftg8pggBe6UPvc1or%2BmGgA9Rps%2BL7CY14mur8s1o4oNN6etI%2BTBQ0e4gdas%2BrrCEageAtg63SdjcR%2FVzPy1GBMs5AEx47%2FQ%2F5bwSa5R%2FfuYMaOK3N%2FQPMHRjh7Ws%2FCUxNhjFypji10HktHwR2ztGwjSlkU2e7CCoornFwQ%2FjqS85mLrgNHOz88SnvM%2BUpJaQr2rwmN%2F80s54NJVNeFs9BiBVEN1cjV87uAEdt08t5mj97%2FcRN3A%3D%3D
It consist of the userID and the code. After the '&' sign there is "amp;", which prevents account controller class action to recognize the code;
Account controller action
public async Task ConfirmEmail(string userId, string code)
This only happens on email confirmation, not forget password link.
My workaround right is to do the following
    public Task SendEmailAsync(string email, string subject, string message)
    {

        // glitch in asp.net core
        if (message.Contains("amp;"))
        {
            message = message.Replace("amp;", "");
        }

      ........

this issue is the same as https://github.com/aspnet/Home/issues/2152

This issue is being closed because it has not been updated in 3 months.
We apologize if this causes any inconvenience. We ask that if you are still encountering this issue, please log a new issue with updated information and we will investigate.


threshold-config: New test for issue in 2190

Continuation of #374
This commit adds a test case for large IP address handling in the
threshold.config file.
Updates:

Rebased.

Merged. Thanks!


dejagnu: no tests on aarch64-darwin

https://hydra.nixos.org/log/4ilhqfxwbsdj49ywq9qna93aj1nilc06-dejagnu-1.6.3.drv
Things done

Built on platform(s)

[ ] ~x86_64-linux~
[ ] ~aarch64-linux~
[ ] ~x86_64-darwin~
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

@ofBorg build dejagnu

Of course it would be better to fix this or at least avoid just the broken tests, but I don't even have a machine capable of testing this.

Wait, this is only on aarch64-darwin (with the sandbox disabled), and not x86_64? Ugh. (Enabling the sandbox fixes it, as I said earlier, but that doesn't help here...)
I'd say this is probably the best fix for now, if we'd rather not block -next...

Yes, the build seems OK on x86_64-darwin, on Hydra and I think also locally.

OfBorg shows the first dejagnu build passing (unsurprisingly) and so far continuing with stdenv bootstrapping.

Bad news: I can't reproduce this successful build on my machine. So it may just be pure luck that it's been working all this time...

My guess is that the regression depends on the system version. The build failure of Zig started in late December on that branch, and we all know that Zig 0.9.1 does not build on macOS 13.

My guess is that the regression depends on the system version.

I was also thinking the same, yeah. Let me poke the infra folks real quick to confirm that hypothesis...


Pushover: Resolved alerts are sent as emergency alerts

This is a follow-up from #90:

Well, now that you made me look at it again, I wonder whether "resolved" notifications should not be emergencies :) (@juliusv)

Confirmed, this totally should be the case! Shocked me a little bit to receive three new emergency notifications after the first bunch… xD

@Luzifer Wanna send a fix? :)


[DEV-15] Fix GridSearchCV ranking issue with ties in highest test_mean_score

Reference Issues/PRs

https://github.com/scikit-learn/scikit-learn/issues/21895
What does this implement/fix? Explain your changes.
This fixes an bug with GridSearchCV where the ranking of test scores could be incorrect if there was a tie in the highest mean_test_score.
Previously, the best_params would be arbitrarily be determined based on the order of the input params if there was a tie.
Now, the best params will be the one with a smaller difference between the mean_test_score and mean_train_score among those with the highest `mean_test_score.
Unit tests to validate this bugfix have been added to test_search.py, you can run the tests with the following command:
pytest -v .\sklearn\model_selection\tests\test_search.py
Any other comments?

LGTM!


Remove use of deprecated enable-dynamic-certificates CLI flag

Dynamic mode is enabled by default and cannot be turned off, although option is still there but just to display deprecation warning.

Going with a ping.