remove extra files from npm, general cleanup, & improve requireability

remove trailing whitespace
remove extra files from npm
clean package.json with fixpack
move main entrypoint into ./lib - this allows us to require only parts of the library by doing a call like
require('bencode/encode')
clean up code with standard-format
remove lib/dict.js - it looks like it was the beginning of support for binary keys, but there
are no tests supporting it and (AFAIK) it's not doing anything useful. It seems like it a precursor to https://github.com/themasch/node-bencode/pull/27, but that PR died.

This is what the contents of the package looked like before:
├── AUTHORS
├── benchmark
│   ├── buffer-vs-string.js
│   ├── decode.js
│   ├── encode.js
│   ├── encoding-length.js
│   ├── instanceof.js
│   └── test.torrent
├── bencode.js
├── CHANGELOG.md
├── CONTRIBUTORS
├── dist
│   ├── bench.html
│   ├── bencode.js
│   ├── bncode.js
│   ├── tape.html
│   ├── tape.js
│   ├── test.html
│   ├── test.js
│   └── tests.js
├── flamegraph.html
├── isolate-0x2630e60-v8.log
├── lib
│   ├── decode.js
│   ├── decoder.js
│   ├── dict.js
│   └── encode.js
├── LICENSE.md
├── Makefile
├── package.json
├── README.md
└── test
    ├── abstract-encoding.test.js
    ├── a.js
    ├── data.js
    ├── decode.buffer.mocha-test.js
    ├── decode.buffer.test.js
    ├── decode.utf8.mocha-test.js
    ├── decode.utf8.test.js
    ├── encode.mocha-test.js
    ├── encode.test.js
    ├── lib.js
    ├── mocha.opts
    └── specifications.md

This is what the contents of the package look like now:
├── CHANGELOG.md
├── CONTRIBUTORS
├── lib
│   ├── decode.js
│   ├── encode.js
│   └── index.js
├── LICENSE.md
├── package.json
└── README.md

looks good for me but I'd like to hear @jhermsmeier's opinion on this, especially it removes the Dict-"feature".
Since the tests still work, it doesn't really "change" the public api. :+1: from my side

This looks pretty good at first glance, I'll have to spend a few more minutes on this though, I think.
Especially because there was a reason for the binary keys support, and removing it just because we don't have any tests for it seems like we might be breaking someone's use of bencode by doing that.
I'd rather like to add tests for binary keys and keep the functionality.

@jhermsmeier - Cool, be sure to leave comments if you find anything. And right now binarySet is the only function that we're calling from Dict, and that just does this[key] = value, so we basically are just using it as a regular hash-map. Some other package might be using Dict.binaryKeys, so we could release 1.0.0 just to be safe, but I don't think there would be any reason to use it and it doesn't seem to be documented anywhere.

PS: turns out I was wrong about being able to do require('bencode/encode')... That doesn't work and I'd need to do require('bencode/lib/encode'). I could've sworn those requires resolved relative to main, but I can't find any docs on that having changed, so I guess we'd have to move the stuff out of lib, add in placeholders at the root dir like readable-stream does, or move them up during a build step before publishing. :disappointed:

so I guess we'd have to move the stuff out of lib

Yeah, I think we might leave that for another PR.
I've looked over it now, and from what I can see the binary key dict didn't really work and also not in a nice fashion – so removing that is cool.
Do you also want to add standard to npm test, so that we'll be forced to stick with it and it lints PRs etc.? Then this will be good to merge from my side – @themasch?
Just a note for future PRs: You might want to do things like changing code style formatting in a separate PR, as people might not be too fond of standard (I myself am not using it, for example), which could make separating the functionality related changes from the formatting a bit of a hassle ;)

Do you also want to add standard to npm test

Sure, I'll add that in a sec

You might want to do things like changing code style formatting in a separate PR, as people might not be too fond of standard

Yeah - I split stylistic changes into separate commits for that very reason... with an interactive rebase or simple cherrypicking you can select a subset of the changes and only merge those.

Thank you! Published as 0.10.0 now.

sweet, thanks!

:+1:


[Feature request] Color blind options

Ability to customize the bar colors would be extremely useful especially when having the bar on second screen it would be nice to use something with more high contrast, also red/green color blindness is rather common issue so the bars are basically invisible for some people with the default colors.

I have made my own fork of this plugin in which I added settings to change the progress bar color. Just waiting on the plugin to be updated on RuneLite
https://github.com/runelite/plugin-hub/pull/4072

@guillaume009 Would be great to also propose a pull request from the fork to this remote repo. That way the author can merge it whenever before ever making other changes. Elsewise your change might end up getting removed in later updates by not being present in this repository.

The plugin now points to my repo, so for now we should be ok. But it's a good suggestion. I'll try to periodically do PR toward this repo so that it's easy to merge if ever Caleb wants to take back the ownership

By the way, this has now been fixed in RuneLite. Feel free to close the issue when you are available


ERROR! Could not generate Meteor bundle

Script version (listed in .config/azure/deploy.sh)
1.4.5

Deployment log

mdell@UK134489 ~/W/R/my-website> git push azure master
Counting objects: 1, done.
Writing objects: 100% (1/1), 182 bytes | 0 bytes/s, done.
Total 1 (delta 0), reused 0 (delta 0)
remote: Updating branch 'master'.
remote: Updating submodules.
remote: Preparing deployment for commit id '48f614b45f'.
remote: Running custom deployment command...
remote: Running deployment command...
remote: meteor-azure: Setting Node version
remote: Version 0.10.40 is already installed.
remote: meteor-azure: Now using Node v0.10.40 (32-bit)
remote: meteor-azure: Setting NPM version
remote: ...
remote: meteor-azure: Now using NPM v1.4.28
remote: meteor-azure: Installing NPM dependencies
remote: ...............
remote: npm WARN package.json<EMAIL_ADDRESS>No README data
remote: ...
remote: meteor-azure: Building app
remote: The system cannot find the path specified.
remote: meteor-azure: ERROR! Could not generate Meteor bundle
remote:
remote: Error - Changes committed to remote repository but deployment to website failed.

I'm getting this when I run the script. It seems to be failing in build.sh around here...
echo meteor-azure: Building app
cmd //c meteor build "%DEPLOYMENT_TEMP%" --directory --server-only
if [ ! -e "$DEPLOYMENT_TEMP\bundle\programs\server\package.json" ]; then
  echo "meteor-azure: ERROR! Could not generate Meteor bundle"
  exit 1
fi

Presumably it can't find that package.json file. Any ideas?

Have you configured your application settings on Azure?

This is the bare minimum, yeah?

App structure is...

You need to set the correct NPM/Node versions based on your Meteor release.
If you want to confirm what these are, just run meteor node -v and meteor npm -v on your local machine.

Hmm... that's a good spot. I've updated the values to 4.6.2 and 3.10.9 respectively but I still get the same error.
remote: Updating branch 'master'.
remote: Updating submodules.
remote: Preparing deployment for commit id '3baba2aa82'.
remote: Running custom deployment command...
remote: Running deployment command...
remote: meteor-azure: Setting Node version
remote: Downloading node.js version 4.6.2 (32-bit)... Complete
remote: Creating D:/home/meteor-azure/nvm\temp
remote:
remote: Downloading npm version 2.15.11... Complete
remote: ..................................................
remote: Installing npm v2.15.11...
remote:
remote: Installation complete. If you want to use this version, type
remote:
remote: nvm use 4.6.2
remote: meteor-azure: Now using Node v4.6.2 (32-bit)
remote: meteor-azure: Setting NPM version
remote: .......................................................................................................................................
remote: D:\home\meteor-azure\nvm\v4.6.2\npm -> D:\home\meteor-azure\nvm\v4.6.2\node_modules\npm\bin\npm-cli.js
remote: ....
remote<EMAIL_ADDRESS>D:\home\meteor-azure\nvm\v4.6.2\node_modules\npm
remote: meteor-azure: Now using NPM v3.10.9
remote: meteor-azure: Installing JSON tool
remote: ...........
remote: D:\home\meteor-azure\nvm\v4.6.2\json -> D:\home\meteor-azure\nvm\v4.6.2\node_modules\json\lib\json.js
remote: D:\home\meteor-azure\nvm\v4.6.2
remote: `--<EMAIL_ADDRESS>remote:
remote: meteor-azure: Installing NPM dependencies
remote: .............................................
remote: meteor-azure: Building app
remote: The system cannot find the path specified.
remote: meteor-azure: ERROR! Could not generate Meteor bundle

Further digging... I've output the path it's looking for which is
D:\local\Temp\8d456129ea5ac45\bundle\programs\server\package.json

If I go into the Azure console a cd to D:\local\Temp\8d456129ea5ac45 the directory is empty.

You're mixing up cause with effect, that check was written to ensure the script does not proceed unless the app is built correctly.
I have a feeling the working directory (which you identified as D:\local\Temp\8d456129ea5ac45) is not being assigned properly.
Can you try rebuilding the app with the same configuration and then paste the full deployment log.

I'm not sure which command you meant exactly for "rebuilding the app". From what I can tell I simply deploy my unbuilt meteor app with the config files and deployment script to Azure and it builds from there.
I attempted to deploy onto another App Service and have the same result. I found that I forgot to mention that previously the script times out when downloading Meteor. Perhaps that is the cause? Regardless here is the full deployment log from start to finish including the timeout.
mdell@UK134489 ~/W/R/my-website> git push azure master
Password for 'https://username@my-website.scm.azurewebsites.net:443':
Counting objects: 9302, done.
Delta compression using up to 8 threads.
Compressing objects: 100% (6643/6643), done.
Writing objects: 100% (9302/9302), 17.12 MiB | 744.00 KiB/s, done.
Total 9302 (delta 2226), reused 9266 (delta 2209)
remote: Updating branch 'master'.
remote: Updating submodules.
remote: Preparing deployment for commit id '9eea349237'.
remote: Running custom deployment command...
remote: Running deployment command...
remote: meteor-azure: Installing Meteor
remote:   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
remote:                                  Dload  Upload   Total   Spent    Left  Speed
remote:
remote:   0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
remote:   0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
remote:   0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
remote:
remote:   2  165M    2 4895k    0     0  4176k      0  0:00:40  0:00:01  0:00:39 4176k
remote:   7  165M    7 12.9M    0     0  6121k      0  0:00:27  0:00:02  0:00:25 8400k
remote:  12  165M   12 21.0M    0     0  6809k      0  0:00:24  0:00:03  0:00:21 8352k
remote:  18  165M   18 29.9M    0     0  7355k      0  0:00:23  0:00:04  0:00:19 8597k
remote:  22  165M   22 37.8M    0     0  7492k      0  0:00:22  0:00:05  0:00:17 8464k
remote:  28  165M   28 47.3M    0     0  7854k      0  0:00:21  0:00:06  0:00:15 8716k
remote:  33  165M   33 56.3M    0     0  8044k      0  0:00:21  0:00:07  0:00:14 8880k
remote:  38  165M   38 63.9M    0     0  7834k      0  0:00:21  0:00:08  0:00:13 8461k
remote:  42  165M   42 70.4M    0     0  7862k      0  0:00:21  0:00:09  0:00:12 8284k
remote:  47  165M   47 78.5M    0     0  7910k      0  0:00:21  0:00:10  0:00:11 8342k
remote:  53  165M   53 87.9M    0     0  8065k      0  0:00:21  0:00:11  0:00:10 8326k
remote:  57  165M   57 96.0M    0     0  8077k      0  0:00:21  0:00:12  0:00:09 8124k
remote:  62  165M   62  104M    0     0  8087k      0  0:00:21  0:00:13  0:00:08 8526k
remote:  67  165M   67  112M    0     0  8106k      0  0:00:20  0:00:14  0:00:06 8553k
remote:  72  165M   72  120M    0     0  8122k      0  0:00:20  0:00:15  0:00:05 8553k
remote:  77  165M   77  128M    0     0  8152k      0  0:00:20  0:00:16  0:00:04 8345k
remote:  82  165M   82  136M    0     0  8133k      0  0:00:20  0:00:17  0:00:03 8268k
remote:  87  165M   87  144M    0     0  8135k      0  0:00:20  0:00:18  0:00:02 8262k
remote:  92  165M   92  152M    0     0  8160k      0  0:00:20  0:00:19  0:00:01 8313k
remote:  96  165M   96  160M    0     0  8164k      0  0:00:20  0:00:20 --:--:-- 8294k
remote: 100  165M  100  165M    0     0  8156k      0  0:00:20  0:00:20 --:--:-- 8172k
fatal: The remote end hung up unexpectedly
error: error in sideband demultiplexer
To https://my-website.scm.azurewebsites.net:443/my-website.git
 * [new branch]      master -> master

Error here 👆🏻
Then continue 👇🏻
mdell@UK134489 ~/W/R/my-website> git commit --allow-empty -m "deploy azure"
[master c8e1dff] deploy azure
mdell@UK134489 ~/W/R/my-website> git push azure master
Counting objects: 1, done.
Writing objects: 100% (1/1), 182 bytes | 0 bytes/s, done.
Total 1 (delta 0), reused 0 (delta 0)
remote: Updating branch 'master'.
remote: Updating submodules.
remote: Preparing deployment for commit id 'c8e1dff867'.
remote: Running custom deployment command...
remote: Running deployment command...
remote: meteor-azure: Installing NVM
remote:   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
remote:                                  Dload  Upload   Total   Spent    Left  Speed
remote:
remote:   0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
remote: 100   594    0   594    0     0   1000      0 --:--:-- --:--:-- --:--:--  1027
remote:
remote:   0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
remote:   7 2409k    7  185k    0     0   112k      0  0:00:21  0:00:01  0:00:20  179k
remote:  43 2409k   43 1052k    0     0   400k      0  0:00:06  0:00:02  0:00:04  526k
remote: 100 2409k  100 2409k    0     0   744k      0  0:00:03  0:00:03 --:--:--  923k
remote: Archive:  nvm-noinstall.zip
remote:   inflating: nvm/LICENSE
remote:   inflating: nvm/elevate.cmd
remote:   inflating: nvm/elevate.vbs
remote:   inflating: nvm/install.cmd
remote:   inflating: nvm/nvm.exe
remote: meteor-azure: Setting Node version
remote: Downloading node.js version 4.6.2 (32-bit)... Complete
remote: Creating D:/home/meteor-azure/nvm\temp
remote:
remote: Downloading npm version 2.15.11... Complete
remote: .................................
remote: Installing npm v2.15.11...
remote:
remote: Installation complete. If you want to use this version, type
remote:
remote: nvm use 4.6.2
remote: meteor-azure: Now using Node v4.6.2 (32-bit)
remote: meteor-azure: Setting NPM version
remote: ...........................................................................................................................................................................
remote: D:\home\meteor-azure\nvm\v4.6.2\npm -> D:\home\meteor-azure\nvm\v4.6.2\node_modules\npm\bin\npm-cli.js
remote: ......
remote<EMAIL_ADDRESS>D:\home\meteor-azure\nvm\v4.6.2\node_modules\npm
remote: .
remote: meteor-azure: Now using NPM v3.10.9
remote: meteor-azure: Installing JSON tool
remote: ................
remote: D:\home\meteor-azure\nvm\v4.6.2\json -> D:\home\meteor-azure\nvm\v4.6.2\node_modules\json\lib\json.js
remote: D:\home\meteor-azure\nvm\v4.6.2
remote: `--<EMAIL_ADDRESS>remote:
remote: ..
remote: meteor-azure: Installing NPM dependencies
remote: ............................................
remote: npm WARN deprecated<EMAIL_ADDRESS>Project renamed to HSLuv
remote: ...................................................................................................................................................................................................
remote: npm WARN prefer global<EMAIL_ADDRESS>should be installed with -g
remote: .......
remote: my-website@ D:\home\site\repository
remote: +--<EMAIL_ADDRESS>remote: | +--<EMAIL_ADDRESS>remote: | +--<EMAIL_ADDRESS>remote: | +--<EMAIL_ADDRESS>remote: | | +--<EMAIL_ADDRESS>remote: | | +--<EMAIL_ADDRESS>remote: | | +--<EMAIL_ADDRESS>remote: | | +--<EMAIL_ADDRESS>remote: | | | `--<EMAIL_ADDRESS>remote: | | +--<EMAIL_ADDRESS>remote: | | +--<EMAIL_ADDRESS>remote: | | +--<EMAIL_ADDRESS>remote: | | | `--<EMAIL_ADDRESS>remote: | | +--<EMAIL_ADDRESS>remote: | | | +--<EMAIL_ADDRESS>remote: | | | | +--<EMAIL_ADDRESS>remote: | | | | +--<EMAIL_ADDRESS>remote: | | | | +--<EMAIL_ADDRESS>remote: | | | | `--<EMAIL_ADDRESS>remote: | | | +--<EMAIL_ADDRESS>remote: | | | +--<EMAIL_ADDRESS>remote: | | | | +--<EMAIL_ADDRESS>remote: | | | | +--<EMAIL_ADDRESS>remote: | | | | | `--<EMAIL_ADDRESS>remote: | | | | +--<EMAIL_ADDRESS>remote: | | | | `--<EMAIL_ADDRESS>remote: | | | `--<EMAIL_ADDRESS>remote: | | |   `--<EMAIL_ADDRESS>remote: | | +--<EMAIL_ADDRESS>remote: | | | +--<EMAIL_ADDRESS>remote: | | | +--<EMAIL_ADDRESS>remote: | | | +--<EMAIL_ADDRESS>remote: | | | `--<EMAIL_ADDRESS>remote: | | +--<EMAIL_ADDRESS>remote: | | | +--<EMAIL_ADDRESS>remote: | | | +--<EMAIL_ADDRESS>remote: | | | | +--<EMAIL_ADDRESS>remote: | | | | +--<EMAIL_ADDRESS>remote: | | | | `--<EMAIL_ADDRESS>remote: | | | `--<EMAIL_ADDRESS>remote: | | |   +--<EMAIL_ADDRESS>remote: | | |   +--<EMAIL_ADDRESS>remote: | | |   +--<EMAIL_ADDRESS>remote: | | |   +--<EMAIL_ADDRESS>remote: | | |   | `--<EMAIL_ADDRESS>remote: | | |   +--<EMAIL_ADDRESS>remote: | | |   +--<EMAIL_ADDRESS>remote: | | |   | `--<EMAIL_ADDRESS>remote: | | |   +--<EMAIL_ADDRESS>remote: | | |   +--<EMAIL_ADDRESS>remote: | | |   `--<EMAIL_ADDRESS>remote: | | +--<EMAIL_ADDRESS>remote: | | +--<EMAIL_ADDRESS>remote: | | +--<EMAIL_ADDRESS>remote: | | +--<EMAIL_ADDRESS>remote: | | | `--<EMAIL_ADDRESS>remote: | | +--<EMAIL_ADDRESS>remote: | | +--<EMAIL_ADDRESS>remote: | | +--<EMAIL_ADDRESS>remote: | | +--<EMAIL_ADDRESS>remote: | | | `--<EMAIL_ADDRESS>remote: | | +--<EMAIL_ADDRESS>remote: | | `--<EMAIL_ADDRESS>remote: | +--<EMAIL_ADDRESS>remote: | | +--<EMAIL_ADDRESS>remote: | | | `--<EMAIL_ADDRESS>remote: | | +--<EMAIL_ADDRESS>remote: | | | +--<EMAIL_ADDRESS>remote: | | | +--<EMAIL_ADDRESS>remote: | | | | `--<EMAIL_ADDRESS>remote: | | | `--<EMAIL_ADDRESS>remote: | | +--<EMAIL_ADDRESS>remote: | | | `--<EMAIL_ADDRESS>remote: | | `--<EMAIL_ADDRESS>remote: | |   +--<EMAIL_ADDRESS>remote: | |   `--<EMAIL_ADDRESS>remote: | +--<EMAIL_ADDRESS>remote: | | +--<EMAIL_ADDRESS>remote: | | | `--<EMAIL_ADDRESS>remote: | | +--<EMAIL_ADDRESS>remote: | | +--<EMAIL_ADDRESS>remote: | | +--<EMAIL_ADDRESS>remote: | | `--<EMAIL_ADDRESS>remote: | `--<EMAIL_ADDRESS>remote: |   +--<EMAIL_ADDRESS>remote: |   | +--<EMAIL_ADDRESS>remote: |   | | `--<EMAIL_ADDRESS>remote: |   | `--<EMAIL_ADDRESS>remote: |   +--<EMAIL_ADDRESS>remote: |   +--<EMAIL_ADDRESS>remote: |   +--<EMAIL_ADDRESS>remote: |   +--<EMAIL_ADDRESS>remote: |   | `--<EMAIL_ADDRESS>remote: |   |   `--<EMAIL_ADDRESS>remote: |   +--<EMAIL_ADDRESS>remote: |   | +--<EMAIL_ADDRESS>remote: |   | | `--<EMAIL_ADDRESS>remote: |   | `--<EMAIL_ADDRESS>remote: |   |   +--<EMAIL_ADDRESS>remote: |   |   | +--<EMAIL_ADDRESS>remote: |   |   | +--<EMAIL_ADDRESS>remote: |   |   | | `--<EMAIL_ADDRESS>remote: |   |   | |   `--<EMAIL_ADDRESS>remote: |   |   | +--<EMAIL_ADDRESS>remote: |   |   | `--<EMAIL_ADDRESS>remote: |   |   |   `--<EMAIL_ADDRESS>remote: |   |   +--<EMAIL_ADDRESS>remote: |   |   | +--<EMAIL_ADDRESS>remote: |   |   | +--<EMAIL_ADDRESS>remote: |   |   | | `--<EMAIL_ADDRESS>remote: |   |   | +--<EMAIL_ADDRESS>remote: |   |   | `--<EMAIL_ADDRESS>remote: |   |   |   +--<EMAIL_ADDRESS>remote: |   |   |   | `--<EMAIL_ADDRESS>remote: |   |   |   `--<EMAIL_ADDRESS>remote: |   |   `--<EMAIL_ADDRESS>remote: |   +--<EMAIL_ADDRESS>remote: |   +--<EMAIL_ADDRESS>remote: |   +--<EMAIL_ADDRESS>remote: |   +--<EMAIL_ADDRESS>remote: |   | +--<EMAIL_ADDRESS>remote: |   | `--<EMAIL_ADDRESS>remote: |   |   `--<EMAIL_ADDRESS>remote: |   +--<EMAIL_ADDRESS>remote: |   +--<EMAIL_ADDRESS>remote: |   +--<EMAIL_ADDRESS>remote: |   `--<EMAIL_ADDRESS>remote: |     `--<EMAIL_ADDRESS>remote: +--<EMAIL_ADDRESS>remote: | +--<EMAIL_ADDRESS>remote: | `--<EMAIL_ADDRESS>remote: +--<EMAIL_ADDRESS>remote: | `--<EMAIL_ADDRESS>remote: |   +--<EMAIL_ADDRESS>remote: |   | `--<EMAIL_ADDRESS>remote: |   `--<EMAIL_ADDRESS>remote: +--<EMAIL_ADDRESS>remote: +--<EMAIL_ADDRESS>remote: | +--<EMAIL_ADDRESS>remote: | | +--<EMAIL_ADDRESS>remote: | | | +--<EMAIL_ADDRESS>remote: | | | +--<EMAIL_ADDRESS>remote: | | | `--<EMAIL_ADDRESS>remote: | | +--<EMAIL_ADDRESS>remote: | | | `--<EMAIL_ADDRESS>remote: | | +--<EMAIL_ADDRESS>remote: | | +--<EMAIL_ADDRESS>remote: | | +--<EMAIL_ADDRESS>remote: | | +--<EMAIL_ADDRESS>remote: | | +--<EMAIL_ADDRESS>remote: | | +--<EMAIL_ADDRESS>remote: | | +--<EMAIL_ADDRESS>remote: | | +--<EMAIL_ADDRESS>remote: | | +--<EMAIL_ADDRESS>remote: | | +--<EMAIL_ADDRESS>remote: | | +--<EMAIL_ADDRESS>remote: | | +--<EMAIL_ADDRESS>remote: | | `--<EMAIL_ADDRESS>remote: | +--<EMAIL_ADDRESS>remote: | | +--<EMAIL_ADDRESS>remote: | | | `--<EMAIL_ADDRESS>remote: | | +--<EMAIL_ADDRESS>remote: | | `--<EMAIL_ADDRESS>remote: | +--<EMAIL_ADDRESS>remote: | +--<EMAIL_ADDRESS>remote: | +--<EMAIL_ADDRESS>remote: | | `--<EMAIL_ADDRESS>remote: | +--<EMAIL_ADDRESS>remote: | | +--<EMAIL_ADDRESS>remote: | | | +--<EMAIL_ADDRESS>remote: | | | | +--<EMAIL_ADDRESS>remote: | | | | `--<EMAIL_ADDRESS>remote: | | | `--<EMAIL_ADDRESS>remote: | | `--<EMAIL_ADDRESS>remote: | +--<EMAIL_ADDRESS>remote: | `--<EMAIL_ADDRESS>remote: +--<EMAIL_ADDRESS>remote: +--<EMAIL_ADDRESS>remote: | +--<EMAIL_ADDRESS>remote: | +--<EMAIL_ADDRESS>remote: | +--<EMAIL_ADDRESS>remote: | | `--<EMAIL_ADDRESS>remote: | `--<EMAIL_ADDRESS>remote: +--<EMAIL_ADDRESS>remote: | +--<EMAIL_ADDRESS>remote: | +--<EMAIL_ADDRESS>remote: | | +--<EMAIL_ADDRESS>remote: | | +--<EMAIL_ADDRESS>remote: | | +--<EMAIL_ADDRESS>remote: | | +--<EMAIL_ADDRESS>remote: | | `--<EMAIL_ADDRESS>remote: | |   +--<EMAIL_ADDRESS>remote: | |   +--<EMAIL_ADDRESS>remote: | |   +--<EMAIL_ADDRESS>remote: | |   +--<EMAIL_ADDRESS>remote: | |   +--<EMAIL_ADDRESS>remote: | |   `--<EMAIL_ADDRESS>remote: | +--<EMAIL_ADDRESS>remote: | `--<EMAIL_ADDRESS>remote: |   +--<EMAIL_ADDRESS>remote: |   +--<EMAIL_ADDRESS>remote: |   | `--<EMAIL_ADDRESS>remote: |   +--<EMAIL_ADDRESS>remote: |   `--<EMAIL_ADDRESS>remote: +--<EMAIL_ADDRESS>remote: +--<EMAIL_ADDRESS>remote: | +--<EMAIL_ADDRESS>remote: | +--<EMAIL_ADDRESS>remote: | +--<EMAIL_ADDRESS>remote: | +--<EMAIL_ADDRESS>remote: | +--<EMAIL_ADDRESS>remote: | +--<EMAIL_ADDRESS>remote: | +--<EMAIL_ADDRESS>remote: | +--<EMAIL_ADDRESS>remote: | +--<EMAIL_ADDRESS>remote: | +--<EMAIL_ADDRESS>remote: | +--<EMAIL_ADDRESS>remote: | +--<EMAIL_ADDRESS>remote: | +--<EMAIL_ADDRESS>remote: | +--<EMAIL_ADDRESS>remote: | +--<EMAIL_ADDRESS>remote: | +--<EMAIL_ADDRESS>remote: | +--<EMAIL_ADDRESS>remote: | +--<EMAIL_ADDRESS>remote: | +--<EMAIL_ADDRESS>remote: | +--<EMAIL_ADDRESS>remote: | +--<EMAIL_ADDRESS>remote: The system cannot find the path specified.
remote: | +--<EMAIL_ADDRESS>remote: | +--<EMAIL_ADDRESS>remote: | +--<EMAIL_ADDRESS>remote: | +--<EMAIL_ADDRESS>remote: | +--<EMAIL_ADDRESS>remote: | +--<EMAIL_ADDRESS>remote: | +--<EMAIL_ADDRESS>remote: | +--<EMAIL_ADDRESS>remote: | +--<EMAIL_ADDRESS>remote: | +--<EMAIL_ADDRESS>remote: | +--<EMAIL_ADDRESS>remote: | +--<EMAIL_ADDRESS>remote: | +--<EMAIL_ADDRESS>remote: | +--<EMAIL_ADDRESS>remote: | +--<EMAIL_ADDRESS>remote: | +--<EMAIL_ADDRESS>remote: | +--<EMAIL_ADDRESS>remote: | +--<EMAIL_ADDRESS>remote: | +--<EMAIL_ADDRESS>remote: | +--<EMAIL_ADDRESS>remote: | +--<EMAIL_ADDRESS>remote: | +--<EMAIL_ADDRESS>remote: | +--<EMAIL_ADDRESS>remote: | +--<EMAIL_ADDRESS>remote: | +--<EMAIL_ADDRESS>remote: | +--<EMAIL_ADDRESS>remote: | +--<EMAIL_ADDRESS>remote: | +--<EMAIL_ADDRESS>remote: | +--<EMAIL_ADDRESS>remote: | +--<EMAIL_ADDRESS>remote: | +--<EMAIL_ADDRESS>remote: | +--<EMAIL_ADDRESS>remote: | +--<EMAIL_ADDRESS>remote: | +--<EMAIL_ADDRESS>remote: | +--<EMAIL_ADDRESS>remote: | +--<EMAIL_ADDRESS>remote: | +--<EMAIL_ADDRESS>remote: | +--<EMAIL_ADDRESS>remote: | | `--<EMAIL_ADDRESS>remote: | +--<EMAIL_ADDRESS>remote: | +--<EMAIL_ADDRESS>remote: | `--<EMAIL_ADDRESS>remote: +--<EMAIL_ADDRESS>remote: | `--<EMAIL_ADDRESS>remote: |   +--<EMAIL_ADDRESS>remote: |   `--<EMAIL_ADDRESS>remote: +--<EMAIL_ADDRESS>remote: +--<EMAIL_ADDRESS>remote: | +--<EMAIL_ADDRESS>remote: | | +--<EMAIL_ADDRESS>remote: | | +--<EMAIL_ADDRESS>remote: | | | +--<EMAIL_ADDRESS>remote: | | | | +--<EMAIL_ADDRESS>remote: | | | | | `--<EMAIL_ADDRESS>remote: | | | | `--<EMAIL_ADDRESS>remote: | | | `--<EMAIL_ADDRESS>remote: | | +--<EMAIL_ADDRESS>remote: | | | `--<EMAIL_ADDRESS>remote: | | +--<EMAIL_ADDRESS>remote: | | `--<EMAIL_ADDRESS>remote: | +--<EMAIL_ADDRESS>remote: | | `--<EMAIL_ADDRESS>remote: | `--<EMAIL_ADDRESS>remote: +--<EMAIL_ADDRESS>remote: +--<EMAIL_ADDRESS>remote: +--<EMAIL_ADDRESS>remote: | `--<EMAIL_ADDRESS>remote: +--<EMAIL_ADDRESS>remote: +--<EMAIL_ADDRESS>remote: +--<EMAIL_ADDRESS>remote: | +--<EMAIL_ADDRESS>remote: | `--<EMAIL_ADDRESS>remote: |   +--<EMAIL_ADDRESS>remote: |   | +--<EMAIL_ADDRESS>remote: |   | | `--<EMAIL_ADDRESS>remote: |   | +--<EMAIL_ADDRESS>remote: |   | | +--<EMAIL_ADDRESS>remote: |   | | +--<EMAIL_ADDRESS>remote: |   | | | `--<EMAIL_ADDRESS>remote: |   | | |   `--<EMAIL_ADDRESS>remote: |   | | +--<EMAIL_ADDRESS>remote: |   | | | `--<EMAIL_ADDRESS>remote: |   | | +--<EMAIL_ADDRESS>remote: |   | | | `--<EMAIL_ADDRESS>remote: |   | | `--<EMAIL_ADDRESS>remote: |   | +--<EMAIL_ADDRESS>remote: |   | | +--<EMAIL_ADDRESS>remote: |   | | | `--<EMAIL_ADDRESS>remote: |   | | +--<EMAIL_ADDRESS>remote: |   | | `--<EMAIL_ADDRESS>remote: |   | `--<EMAIL_ADDRESS>remote: |   +--<EMAIL_ADDRESS>remote: |   | +--<EMAIL_ADDRESS>remote: |   | | `--<EMAIL_ADDRESS>remote: |   | `--<EMAIL_ADDRESS>remote: |   +--<EMAIL_ADDRESS>remote: |   +--<EMAIL_ADDRESS>remote: |   +--<EMAIL_ADDRESS>remote: |   | `--<EMAIL_ADDRESS>remote: |   |   `--<EMAIL_ADDRESS>remote: |   `--<EMAIL_ADDRESS>remote: |     `--<EMAIL_ADDRESS>remote: +--<EMAIL_ADDRESS>remote: | +--<EMAIL_ADDRESS>remote: | `--<EMAIL_ADDRESS>remote: +--<EMAIL_ADDRESS>remote: | +--<EMAIL_ADDRESS>remote: | | `--<EMAIL_ADDRESS>remote: | `--<EMAIL_ADDRESS>remote: +--<EMAIL_ADDRESS>remote: +--<EMAIL_ADDRESS>remote: +--<EMAIL_ADDRESS>remote: | `--<EMAIL_ADDRESS>remote: +--<EMAIL_ADDRESS>remote: | `--<EMAIL_ADDRESS>remote: +--<EMAIL_ADDRESS>remote: | `--<EMAIL_ADDRESS>remote: +--<EMAIL_ADDRESS>remote: | +--<EMAIL_ADDRESS>remote: | +--<EMAIL_ADDRESS>remote: | | `--<EMAIL_ADDRESS>remote: | |   `--<EMAIL_ADDRESS>remote: | `--<EMAIL_ADDRESS>remote: +--<EMAIL_ADDRESS>remote: | +--<EMAIL_ADDRESS>remote: | +--<EMAIL_ADDRESS>remote: | | `--<EMAIL_ADDRESS>remote: | |   +--<EMAIL_ADDRESS>remote: | |   | +--<EMAIL_ADDRESS>remote: | |   | `--<EMAIL_ADDRESS>remote: | |   |   `--<EMAIL_ADDRESS>remote: | |   +--<EMAIL_ADDRESS>remote: | |   +--<EMAIL_ADDRESS>remote: | |   `--<EMAIL_ADDRESS>remote: | `--<EMAIL_ADDRESS>remote: |   `--<EMAIL_ADDRESS>remote: +--<EMAIL_ADDRESS>remote: | +--<EMAIL_ADDRESS>remote: | +--<EMAIL_ADDRESS>remote: | `--<EMAIL_ADDRESS>remote: +--<EMAIL_ADDRESS>remote: | `--<EMAIL_ADDRESS>remote: `--<EMAIL_ADDRESS>remote:
remote: meteor-azure: Building app
remote: D:\local\Temp\8d4565464017bab\bundle\programs\server\package.json
remote: meteor-azure: ERROR! Could not generate Meteor bundle
remote:
remote: Error - Changes committed to remote repository but deployment to website failed.

Deploying your example app it at least builds but still errors during the deployment... 🤔
remote: meteor-azure: Building app
remote: meteor-azure: Setting Node runtime
remote: meteor-azure: Setting entry-point
remote: meteor-azure: Deploying bundle
remote: meteor-azure: Installing Meteor server
remote: .config/azure/deploy.sh: line 169: cd: D:\home\site\wwwroot\programs\server: No such file or directory
remote: ..........
remote: meteor-azure: Finished successfully
remote: Running post deployment command(s)...
remote: Deployment successful.

Further digging... it seems like Meteor isn't installing fully. It seems like Azure is timing out before Meteor finishes installing.
I'm currently letting Meteor install manually and it's taking nearly an hour, so it's no wonder this script is failing. Will update when I know how this goes.

So I've updated the tar command from tar -zxf meteor.tar.gz to tar -vzxf meteor.tar.gz to make it verbose which seems to stop Azure from timing out. My assumption is that it doesn't like the console doing nothing for up to an hour.
So that gets me a bit further along where now it's just stuck on
remote: meteor-azure: Building app

I've tried to leave it running but it doesn't seem to be doing anything as far as I can tell.

I let it run while I was out (for about 4 hours so not sure how long the script took) and it seems to have run!
remote: meteor-azure: Building app
remote: ..............................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................
remote: meteor-azure: Setting Node runtime
remote: meteor-azure: Setting entry-point
remote: meteor-azure: Deploying bundle
remote: ...................................................................................................................................................................................
remote: meteor-azure: Installing Meteor server
remote: ..................................................
remote:
remote: ><EMAIL_ADDRESS>install D:\home\site\wwwroot\programs\server\node_modules\fibers
remote: > node build.js || nodejs build.js
remote:
remote: `win32-ia32-46` exists; testing
remote: Binary is fine; exiting
remote<EMAIL_ADDRESS>D:\home\site\wwwroot\programs\server
remote: +--<EMAIL_ADDRESS>remote: npm WARN<EMAIL_ADDRESS>No description
remote: +--<EMAIL_ADDRESS>remote: +--<EMAIL_ADDRESS>remote: +--<EMAIL_ADDRESS>remote: +--<EMAIL_ADDRESS>remote: | +--<EMAIL_ADDRESS>remote: | | `--<EMAIL_ADDRESS>remote: | +--<EMAIL_ADDRESS>remote: | | +--<EMAIL_ADDRESS>remote: | | +--<EMAIL_ADDRESS>remote: npm WARN<EMAIL_ADDRESS>No repository field.
remote: | | | `--<EMAIL_ADDRESS>remote: npm WARN<EMAIL_ADDRESS>No license field.
remote: | | +--<EMAIL_ADDRESS>remote: | | `--<EMAIL_ADDRESS>remote: | +--<EMAIL_ADDRESS>remote: | +--<EMAIL_ADDRESS>remote: | | `--<EMAIL_ADDRESS>remote: | |   +--<EMAIL_ADDRESS>remote: | |   `--<EMAIL_ADDRESS>remote: | +--<EMAIL_ADDRESS>remote: | | `--<EMAIL_ADDRESS>remote: | +--<EMAIL_ADDRESS>remote: | | `--<EMAIL_ADDRESS>remote: | +--<EMAIL_ADDRESS>remote: | | +--<EMAIL_ADDRESS>remote: | | | +--<EMAIL_ADDRESS>remote: | | | `--<EMAIL_ADDRESS>remote: | | +--<EMAIL_ADDRESS>remote: | | +--<EMAIL_ADDRESS>remote: | | | +--<EMAIL_ADDRESS>remote: | | | +--<EMAIL_ADDRESS>remote: | | | +--<EMAIL_ADDRESS>remote: | | | +--<EMAIL_ADDRESS>remote: | | | +--<EMAIL_ADDRESS>remote: | | | +--<EMAIL_ADDRESS>remote: | | | | +--<EMAIL_ADDRESS>remote: | | | | `--<EMAIL_ADDRESS>remote: | | | |   `--<EMAIL_ADDRESS>remote: | | | +--<EMAIL_ADDRESS>remote: | | | | `--<EMAIL_ADDRESS>remote: | | | `--<EMAIL_ADDRESS>remote: | | `--<EMAIL_ADDRESS>remote: | +--<EMAIL_ADDRESS>remote: | | +--<EMAIL_ADDRESS>remote: | | `--<EMAIL_ADDRESS>remote: | +--<EMAIL_ADDRESS>remote: | | `--<EMAIL_ADDRESS>remote: | |   +--<EMAIL_ADDRESS>remote: | |   | `--<EMAIL_ADDRESS>remote: | |   `--<EMAIL_ADDRESS>remote: | |     +--<EMAIL_ADDRESS>remote: | |     `--<EMAIL_ADDRESS>remote: | |       `--<EMAIL_ADDRESS>remote: | +--<EMAIL_ADDRESS>remote: | | +--<EMAIL_ADDRESS>remote: | | +--<EMAIL_ADDRESS>remote: | | +--<EMAIL_ADDRESS>remote: | | +--<EMAIL_ADDRESS>remote: | | | `--<EMAIL_ADDRESS>remote: | | +--<EMAIL_ADDRESS>remote: | | +--<EMAIL_ADDRESS>remote: | | +--<EMAIL_ADDRESS>remote: | | | `--<EMAIL_ADDRESS>remote: | | +--<EMAIL_ADDRESS>remote: | | | +--<EMAIL_ADDRESS>remote: | | | | +--<EMAIL_ADDRESS>remote: | | | | +--<EMAIL_ADDRESS>remote: | | | | +--<EMAIL_ADDRESS>remote: | | | | `--<EMAIL_ADDRESS>remote: | | | +--<EMAIL_ADDRESS>remote: | | | | `--<EMAIL_ADDRESS>remote: | | | +--<EMAIL_ADDRESS>remote: | | | | +--<EMAIL_ADDRESS>remote: | | | | +--<EMAIL_ADDRESS>remote: | | | | | `--<EMAIL_ADDRESS>remote: | | | | +--<EMAIL_ADDRESS>remote: | | | | `--<EMAIL_ADDRESS>remote: | | | `--<EMAIL_ADDRESS>remote: | | |   `--<EMAIL_ADDRESS>remote: | | +--<EMAIL_ADDRESS>remote: | | | +--<EMAIL_ADDRESS>remote: | | | +--<EMAIL_ADDRESS>remote: | | | +--<EMAIL_ADDRESS>remote: | | | `--<EMAIL_ADDRESS>remote: | | +--<EMAIL_ADDRESS>remote: | | | +--<EMAIL_ADDRESS>remote: | | | +--<EMAIL_ADDRESS>remote: | | | | +--<EMAIL_ADDRESS>remote: | | | | +--<EMAIL_ADDRESS>remote: | | | | `--<EMAIL_ADDRESS>remote: | | | `--<EMAIL_ADDRESS>remote: | | |   +--<EMAIL_ADDRESS>remote: | | |   +--<EMAIL_ADDRESS>remote: | | |   +--<EMAIL_ADDRESS>remote: | | |   +--<EMAIL_ADDRESS>remote: | | |   | `--<EMAIL_ADDRESS>remote: | | |   +--<EMAIL_ADDRESS>remote: | | |   +--<EMAIL_ADDRESS>remote: | | |   | `--<EMAIL_ADDRESS>remote: | | |   +--<EMAIL_ADDRESS>remote: | | |   +--<EMAIL_ADDRESS>remote: | | |   `--<EMAIL_ADDRESS>remote: | | +--<EMAIL_ADDRESS>remote: | | +--<EMAIL_ADDRESS>remote: | | +--<EMAIL_ADDRESS>remote: | | +--<EMAIL_ADDRESS>remote: | | | `--<EMAIL_ADDRESS>remote: | | +--<EMAIL_ADDRESS>remote: | | +--<EMAIL_ADDRESS>remote: | | +--<EMAIL_ADDRESS>remote: | | +--<EMAIL_ADDRESS>remote: | | | `--<EMAIL_ADDRESS>remote: | | +--<EMAIL_ADDRESS>remote: | | `--<EMAIL_ADDRESS>remote: | +--<EMAIL_ADDRESS>remote: | +--<EMAIL_ADDRESS>remote: | | `--<EMAIL_ADDRESS>remote: | `--<EMAIL_ADDRESS>remote: |   `--<EMAIL_ADDRESS>remote: +--<EMAIL_ADDRESS>remote: | +--<EMAIL_ADDRESS>remote: | | +--<EMAIL_ADDRESS>remote: | | +--<EMAIL_ADDRESS>remote: | | +--<EMAIL_ADDRESS>remote: | | `--<EMAIL_ADDRESS>remote: | +--<EMAIL_ADDRESS>remote: | `--<EMAIL_ADDRESS>remote: |   +--<EMAIL_ADDRESS>remote: |   | `--<EMAIL_ADDRESS>remote: |   +--<EMAIL_ADDRESS>remote: |   +--<EMAIL_ADDRESS>remote: |   +--<EMAIL_ADDRESS>remote: |   | +--<EMAIL_ADDRESS>remote: |   | +--<EMAIL_ADDRESS>remote: |   | +--<EMAIL_ADDRESS>remote: |   | +--<EMAIL_ADDRESS>remote: |   | +--<EMAIL_ADDRESS>remote: |   | `--<EMAIL_ADDRESS>remote: |   `--<EMAIL_ADDRESS>remote: +--<EMAIL_ADDRESS>remote: +--<EMAIL_ADDRESS>remote: +--<EMAIL_ADDRESS>remote: +--<EMAIL_ADDRESS>remote: `--<EMAIL_ADDRESS>remote:
remote: meteor-azure: Finished successfully
remote: Running post deployment command(s)...
remote: Deployment successful.

I'm struggling to understand why I'm the first person to have this problem with the script. It seems to work flawlessly for everyone else. 🤔

I am having the same issue. How do you force Meteor to install again on Azure? When I try to deploy it just goes straight to building app after installing NPM dependencies.
Here's my output when i git push:
Counting objects: 5, done.
Delta compression using up to 4 threads.
Compressing objects: 100% (5/5), done.
Writing objects: 100% (5/5), 532 bytes | 0 bytes/s, done.
Total 5 (delta 2), reused 0 (delta 0)
remote: Updating branch 'master'.
remote: Updating submodules.
remote: Preparing deployment for commit id '8f7c82f710'.
remote: Running custom deployment command...
remote: Running deployment command...
remote: meteor-azure: Setting Node version
remote: Version 4.6.2 is already installed.
remote: meteor-azure: Now using Node v4.6.2 (32-bit)
remote: meteor-azure: Setting NPM version
remote: ....
remote: meteor-azure: Now using NPM v3.10.9
remote: meteor-azure: Installing NPM dependencies
remote: ...................
remote: meteor-azure: Building app
remote: The system cannot find the path specified.
remote: meteor-azure: ERROR! Could not generate Meteor bundle
remote:
remote: Error - Changes committed to remote repository but deployment to website failed.

@matfantinel you'll need to at least delete the meteor.bat file at D:\home\meteor-azure\meteor\meteor.bat, though could be worth deleting the whole meteor folder if you're so inclined.

@mattdell thank you, I have changed the tar command like you've said and managed to start meteor install again by deleting the file. However, after a while, it got stuck on the .meteor/packages/meteor-tool/1.4.2_7/mt-os.windows.x86_32/isopackets/cordova-support/npm/node_modules/meteor/babel-compiler/node_modules/babel-generator/lib/buffer.js file.
I'm not sure if I should try starting over or wait. :/

I let it continue, and after 2 hours it stopped with this error:
fatal: protocol error: bad line length character: <!DO
error: error in sideband demultiplexer
error: failed to push some refs to {git_url}

I'm posting on this thread since the root issue appears to be the same.

Another update: I tried installing Meteor again, and it succeeded this time. Then, it started the meteor-azure: Building app step, which after about 5 minutes gave the same "bad line length character" error as above. Now, when I try deploying it again, it errors out after a few seconds. Checking deployment logs only give me this line:
Could not open 'D:/home/site/repository/.config/azure/deploy.sh' for writing: Access is denied.\r\n

So I was able to solve it by deleting the home/site/repository folder and deploying it again. Now my website is working! The issues appear to be all related with timeouts.

That's good to hear @matfantinel !
Glad you got it working. Is it just us who are experiencing problems?

Apparently yes. There is a possibility that the problem may be with the Meteor package or with Azure itself when deploying, maybe some recent update. Sadly I don't know much to help.

Hey guys, sorry for not jumping in earlier. There are a lot of separate points raised here (many of which need to be addressed with better documentation). Unfortunately I've got a lot on my plate at the moment, but I should have some time to spend on this early next week.

No problems mate, I wanna thank you for maintaining this project. Saved me from a big headache.
Let me know if I can give you any info to help when you look into this issue.

@mattdell Thanks!
replacing tar -zxf meteor.tar.gz to tar -vzxf meteor.tar.gz
helped.
Also i did a complete resetup of the app service.

I am trying this to see if it helps with the issue I opened. Going on 3.5 hours for deployment and I will update whether this worked or not

Sorry to say, but despite my 1 success I haven't been able to replicate it again.
My solution has now become to use demeteorizer as suggested by MSDN: https://blogs.msdn.microsoft.com/azureossds/2016/08/24/meteor-1-4-on-azure-app-services/
This consistently works for me.

@mattdell do you need to delete .demeteorized/ everytime you build with that tool?
I think I am going to switch to this too for now.

@jkd65 I just have it as part of my .gitignore file.
I suppose a better approach is to have it as part of a deployment script which then deletes it after deployment.

Having similar issues, Here is my deployment log
Command: bash .config/azure/deploy.sh
meteor-azure: Setting Node version
Version 8.0.0 is already installed.
meteor-azure: Now using Node v8.0.0 (32-bit)
meteor-azure: Setting NPM version
meteor-azure: Now using NPM v5.0.0
meteor-azure: Installing NPM dependencies
npm WARN read-shrinkwrap This version of npm is compatible with lockfileVersion@1, but npm-shrinkwrap.json was generated for lockfileVersion@0. I'll try to do my best with it!
up to date in 3.794s
up to date in 3.045s
meteor-azure: Building app
'"D:\home\meteor-azure.meteor\packages\meteor-tool\1.5.0\mt-os.windows.x86_32\meteor.bat"' is not recognized as an internal or external command,
operable program or batch file.
meteor-azure: Setting Node runtime
.config/azure/deploy.sh: line 150: cd: D:\local\Temp\8d4ac22f73c0a6b\bundle: Not a directory
meteor-azure: Setting entry-point
.config/azure/deploy.sh: line 155: cd: D:\local\Temp\8d4ac22f73c0a6b\bundle\programs\server: Not a directory
meteor-azure: Deploying bundle
meteor-azure: Installing Meteor server
.config/azure/deploy.sh: line 169: cd: D:\home\site\wwwroot\programs\server: No such file or directory
up to date in 3.571s
meteor-azure: Finished successfully
Can someone help?

@varunkumar17 I ended up switching to demeteorizer as I could not get this issue figured out

Closing this as v2 has now been officially released.
See full announcement here.


Get rid of the problem with bad type of apiKey variable

Description
PR fixes following problem:

WARNING	o.j.p.s.d.DescribableModel#uninstantiate2: Cannot create control version of class org.jenkinsci.plugins.workflow.steps.CoreStep using {delegate=@ghostInspector$GhostInspectorBuilder(apiKey=${GI_API_KEY},startUrl=https://url-to-website.com/v2/,suiteId=5f563fe5f9d41d44b7dc8346)}
java.lang.ClassCastException: com.ghostinspector.jenkins.GhostInspector.GhostInspectorBuilder.apiKey expects class java.lang.String but received class hudson.util.Secret
Caused: java.lang.IllegalArgumentException: Could not instantiate {apiKey=${GI_API_KEY}, startUrl=https://url-to-website.com/v2/, suiteId=5f563fe5f9d41d44b7dc8346} for com.ghostinspector.jenkins.GhostInspector.GhostInspectorBuilder
Caused: java.lang.IllegalArgumentException: Could not instantiate {delegate=@ghostInspector$GhostInspectorBuilder(apiKey=${GI_API_KEY},startUrl=https://url-to-website/v2/,suiteId=5f563fe5f9d41d44b7dc8346)} for org.jenkinsci.plugins.workflow.steps.CoreStep

Communication with Ghost Inspector worksfine , but everytime when it tries to connect to Ghost Inspector above problem appear in jenkins logs. It seems that jenkins is changing apiKey variable which is String at the beginning to the Secret type.
My proposal is to add apiKeySecret field for GhostInspectorBuilder class to not override somehow apiKey variable.

@aaronfay - can you review the change? If not, @justinklemm can we assign someone else?

Hi @MichalAugustyn, sorry for the delay here. We have this in our backlog and scheduled for review. I suspect someone will get to it shortly after the holidays. Thanks for your patience.

@aaronfay please make sure this will be verified

Thanks for your patience here, version 3.4 has been released today and should be available on the Jenkins repository shortly. @aowczarek618 thanks for the contribution 🙏🏻


Make it possible to "auto-fix" documents

Currently, omnisharp is not supporting "auto-fix" functionality to VSCode.
Implementing this functionality would lead to a very efficient way to produce clean code.
One possibility would be to add an action "omnisharp: fix document", have a setting in the vscode user json file like
"omnisharp.autofixactions": [
    "RemoveUnusedUsings",
    "SimplifyNames",
   ...
]

This will be possible once #1526 is merged. We'll then be able to add a fix endpoint that fixes everything according to .editorconfig settings.

Perfect, thanks!

Currently working on this, may be few weeks before i push PR though.

fixed by https://github.com/OmniSharp/omnisharp-roslyn/pull/1581


[QA] - Refactor Service Worker and UI

[ ]  The functionality of the "Reload" button appears to be non functioning properly. Clicking on it does not trigger the expected action of reloading the page.

[ ] The "Analyze This Tab" button is not working properly. On click on it the page gets reloads as intended but the button remains visible.

[ ] "Export Cookies" button not visible properly.

The functionality of the "Reload" button appears to be non functioning properly. Clicking on it does not trigger the expected action of reloading the page.
reload.webm

The "Analyze This Tab" button is not working properly. On click on it the page gets reloads as intended but the button remains visible.
analyzethis button.webm

"Export Cookies" button not visible properly.

In the command-line interface (CLI), the blocked reason for the cookies is not visible.

When users switch back to single-tab processing, the "Analyze This Tab" button is not be visible on all tabs.
analyze.webm

Closing this issue as fixed.


"Ceparii Pământeni" is listed in the drop-down menu

Description:
"Ceparii Pământeni" is listed in the drop-down menu alongside its corresponding county and commune, according to the law
Precondition:
The website is up an running.

Step 1
Type "Ceparii Pământeni" in the search bar.

Expected results
The location is listed in the drop-down menu as "Ceparii Pământeni, Argeș (Cepari)".


Custom Image Decoder Implementation

Description
Is it possible to implement a custom operator in C++ for mxnet which takes in a buffer as input instead of ndarray?  I think it would be good to be able to implement custom image decoders that straight away decode data into ndarray.
I tried following the instructions here but it seems to require ndarray type for the data input.
An example is the jpeg2dct project which decodes jpeg buffer into numpy/tensorflow data types. This extracts the dct coefficients from the jpeg image and load it into numpy array or tensorflow tensor.
References

https://github.com/uber-research/jpeg2dct

NDArray is object describing array, but under the hood it contains normal memory. You can access this memory by calling i.e:
int16_t* in_ptr = in_data.dptr<mshadow::kInt16>();

(bsaed on example)
All offsets of different dimensions you can deduce by calling proper ndarray functions.
You can also utilize numpy array to create mxnet's ndarray
from jpeg2dct.numpy import load, loads

import mxnet as mx
#read from a file
jpeg_file = 'test.jpg'
dct_y, dct_cb, dct_cr = load(jpeg_file)
print ("Y component DCT shape {} and type {}".format(dct_y.shape, dct_y.dtype))
print ("Cb component DCT shape {} and type {}".format(dct_cb.shape, dct_cb.dtype))
print ("Cr component DCT shape {} and type {}".format(dct_cr.shape, dct_cr.dtype))

print(type(dct_cr))
print(dct_cr)
mxnet_array = mx.nd.array(dct_cr)

print(mxnet_array.shape)
print(type(mxnet_array))
print(mxnet_array)

However if you wish to load file directly and operate on bytes you can check this operator:
https://github.com/apache/incubator-mxnet/blob/9de2a48fabf1b8a60eb539640dea4c0637b5522b/src/io/image_io.cc#L371

Is the type int_16 usable? I tried
NDArray(mshadow::Shape3(out_shape), Context::CPU(), false, mshadow::kInt16);

but got the following error
MXNetError: Unknown type enum 8

Looks like there is no support for int16 in NDArray interface. @szha is this known issue?
>>> mx.nd.ones((3,2), dtype='int16')
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/bg/incubator-mxnet/python/mxnet/ndarray/ndarray.py", line 3301, in ones
    return _internal._ones(shape=shape, ctx=ctx, dtype=dtype, **kwargs)
  File "<string>", line 39, in _ones
  File "/home/bg/incubator-mxnet/python/mxnet/_ctypes/ndarray.py", line 82, in _imperative_invoke
    check_call(_LIB.MXImperativeInvokeEx(
  File "/home/bg/incubator-mxnet/python/mxnet/base.py", line 246, in check_call
    raise get_last_ffi_error()
mxnet.base.MXNetError: MXNetError: Invalid Input: 'int16', valid values are: {'bfloat16', 'bool', 'float16', 'float32', 'float64', 'int32', 'int64', 'int8', 'uint8'}, in operator _ones(name="", dtype="int16", ctx="cpu(0)", shape="(3, 2)")

Yes. I think we should support it.

@wms2537 Would you like to contribute and add such support? I think adding new dtype into mshadow library shouldn't be problematic

Should I also add in the cudnnDataType_t? As int32 is not available there.
'''
typedef enum {
CUDNN_DATA_FLOAT    = 0,
CUDNN_DATA_DOUBLE   = 1,
CUDNN_DATA_HALF     = 2,
CUDNN_DATA_INT8     = 3,
CUDNN_DATA_INT32    = 4,
CUDNN_DATA_INT8x4   = 5,
CUDNN_DATA_UINT8    = 6,
CUDNN_DATA_UINT8x4  = 7,
CUDNN_DATA_INT8x32  = 8,
CUDNN_DATA_BFLOAT16 = 9,
CUDNN_DATA_INT64    = 10,
} cudnnDataType_t;
'''

I'm not sure, @MoisesHer @szha maybe you can confirm

cudnnDataType_t doesn't come from mxnet and it doesn't support int16.
I haven't looked into the exact request, so the following comment is about adding new dtype in general. Adding a new dtype involves several steps, including:

Adding the dtype definition: https://github.com/apache/incubator-mxnet/blob/5722f8b38af58c5a296e46ca695bfaf7cff85040/3rdparty/mshadow/mshadow/base.h#L352-L366
Adding support in the desired operator. Lots of the operators in MXNet use macros for supporting multiple data types: https://github.com/apache/incubator-mxnet/blob/5722f8b38af58c5a296e46ca695bfaf7cff85040/src/operator/mxnet_op.h#L198-L241
Adding option for operators that take explicit dtype. https://github.com/apache/incubator-mxnet/blob/66a65924f03e6e62ca0619afb02e2a674fcccbfd/src/operator/random/sample_op.h#L103-L105
Adding frontend support for the dtype: https://github.com/apache/incubator-mxnet/blob/5722f8b38af58c5a296e46ca695bfaf7cff85040/python/mxnet/numpy/utils.py#L24-L55 https://github.com/apache/incubator-mxnet/blob/5722f8b38af58c5a296e46ca695bfaf7cff85040/python/mxnet/ndarray/ndarray.py#L65-L112
Adding dlpack support. https://github.com/apache/incubator-mxnet/blob/5722f8b38af58c5a296e46ca695bfaf7cff85040/python/mxnet/dlpack.py#L46-L60
Test for the new dtype. https://github.com/apache/incubator-mxnet/blob/5722f8b38af58c5a296e46ca695bfaf7cff85040/tests/python/unittest/test_numpy_ndarray.py#L38-L53

I tried adding but got the following error when compiling, it seems that atomicAdd dows not support int16. How to fix this?
../src/operator/numpy/np_bincount_op.cu(46): error: no instance of overloaded function "atomicAdd" matches the argument list
            argument types are: (uint16_t *, const uint16_t)
          detected during:
            instantiation of "void mxnet::op::BincountFusedKernel::Map(int, const DType *, const OType *, OType *) [with DType=float, OType=uint16_t]"
../src/operator/numpy/./../mxnet_op.h(1213): here
            instantiation of "void mxnet::op::mxnet_op::mxnet_generic_kernel<OP,Args...>(int, Args...) [with OP=mxnet::op::BincountFusedKernel, Args=<float *, uint16_t *, uint16_t *>]"
../src/operator/numpy/./../mxnet_op.h(1234): here
            instantiation of "void mxnet::op::mxnet_op::Kernel<OP, mxnet::gpu>::Launch(mshadow::Stream<mshadow::gpu> *, int, Args...) [with OP=mxnet::op::BincountFusedKernel, Args=<float *, uint16_t *, uint16_t *>]"

https://github.com/apache/incubator-mxnet/blob/5722f8b38af58c5a296e46ca695bfaf7cff85040/src/operator/numpy/np_bincount_op.cu#L103-L111
https://github.com/apache/incubator-mxnet/blob/5722f8b38af58c5a296e46ca695bfaf7cff85040/src/operator/numpy/np_bincount_op.cu#L146-L152
Template mechanism here create Kernel with int16 data type, because it can be returned by MSHADOW_TYPE_SWITCH - as cudnn doesn't support int16 you can define new macro (or search for existing one) which doesn't support int16 e.g ( MSHADOW_TYPE_SWITCH_NO_INT16) and replace it (I believe it's not the only one). However to avoid potential bugs for GPU implementations should be check whether input/output is int16 datatype and if it is, there should be fallback mechanism implemented to CPU implementation. Something like:
https://github.com/apache/incubator-mxnet/blob/66a65924f03e6e62ca0619afb02e2a674fcccbfd/src/operator/tensor/elemwise_sum.cc#L117-L121


Always return a Version object for indirect gomodule dependencies

When dealing with an indirect gomodules dependency, we were retuning a
string value that came from the Dependency object. We use this version
to compare with a Dependency object in
common/lib/dependabot/update_checkers/base.rb:216, which resulted in an
ArgumentError. We already return a Version object when the dependency is
top_level.

Maybe related to https://github.com/dependabot/dependabot-core/pull/2312 ? I think that's the same error from another ecosystem's UpdateChecker?
WDYT about combining those approaches? Maybe emit a warning so we can defer fixing checkers for these ~known issues?

Maybe related to #2312 ? I think that's the same error from another ecosystem's UpdateChecker?

Yes, it seems like it is 👍

WDYT about combining those approaches? Maybe emit a warning so we can defer fixing checkers for these ~known issues?

Great idea! Should we reopen your PR so we can add it there?


Swift Reorder of Problems

Here is the current list of problems with the number of submissions per each problem.
@hankturowski you are right about the Bob problem. 54% of people drop out of the track on the second problem!
Leap (126)
Bob (58)
Hamming (47)
Word Count (48)
Etl (35)
Anagram (34)
Nucleotide Count (30)
Phone Number (24)
Grade School (18)
Robot Name (22)
Perfect Numbers (16)
Allergies (12)
Accumulate (11)
Sum Of Multiples (9)
Twelve Days (9)
Space Age (10)
Gigasecond (8)
Meetup (5)
Triangle (5)
Scrabble Score (6)
Roman Numerals (5)
Binary (4)
Prime Factors (3)
Raindrops (4)
Strain (5)
Atbash Cipher (5)
Crypto Square (5)
Trinary (4)
Rna Transcription (4)
Sieve (4)
Octal (4)
Luhn (4)
Series (4)
Pig Latin (4)
Pythagorean Triplet (4)
Difference Of Squares (4)
Secret Handshake (4)
Clock (3)
Simple Linked List (2)
https://github.com/exercism/xswift/issues/54

Okay, so right off the bat, I say we arbitrarily move Bob to about the middle of the list to remove that block. Then let's start a careful study of the rest of the problems.
How about we each go through and identify the "easy" problems first and get those to the top. We can decide on the ordering for the rest once we have a gentler introduction.

Made the change and issued a pull request. I'll let you merge it so we get two sets of eyes. I know it's an easy one, but it's better this way I think.

This is such a great initiative. I've been wanting to start doing some of this analysis across the various tracks.
If you find that there are some queries or whatever that would help make this easier, we could totally make a simple admin-only page with stats or something.

superseded by #170


chore(deps): upgrade compiler dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-compiler-dependencies-2.x" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 2825

Questions ?
Please refer to the Backport tool documentation


Fix a bug where failed migrations were overwritten by later successful migrations

Hey @aschleck! Thanks a lot for opening this PR. My code is definitely incorrect but I think the correct fix is to fully break the loops and not continue processing (which is probably what I aimed to do with the break). I fixed this just now: 7be3afa336f808f0dc3c9c622b02c6994a85e3f4. Thanks for raising! :)


chore(docs): fix for release

@rahul-kothari is this still relevant or gone stale?

Closing in favour of https://github.com/AztecProtocol/aztec-packages/pull/5655 - thanks Sean!


test: create automation test for Bridge - Deposit

List of test cases for automation:
#756 Bridge - Deposit - Artifacts (done)
https://allure.matterlabs.dev/project/17/test-cases/756
#1598 Bridge - Deposit - Artifacts(Wallet not connected) (done)
https://allure.matterlabs.dev/project/17/test-cases/1598
#785 Bridge - Deposit - Transactions - make a Deposit (done)
https://allure.matterlabs.dev/project/17/test-cases/785
#1609 Bridge - Deposit - Redirection - "Explore ecosystem" button (done)
https://allure.matterlabs.dev/project/17/test-cases/1609
#1611 Bridge - Deposit - Edit recipient address (done)
https://allure.matterlabs.dev/project/17/test-cases/1611
#1607 Bridge - Deposit - Artifacts - "Transaction submitted" pop up(in progress)
https://allure.matterlabs.dev/project/17/test-cases/1607

@pcheremu can you please review the PR?
Thank you in advance!

@abilevych can you please review the PR?
Thank you in advance!


Add Leafcutter tool

Add first steps of leaf cutter splicing quantification to the pipeline.
PR checklist

[x] This comment contains a description of changes (with reason).
[x] If you've fixed a bug or added code that should be tested, add tests!
[x] If you've added a new tool - have you followed the pipeline conventions in the contribution docs
[ ] If necessary, also make a PR on the nf-core/rnasplice branch on the nf-core/test-datasets repository.
[ ] Make sure your code lints (nf-core lint).
[x] Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
[ ] Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
[ ] Usage Documentation in docs/usage.md is updated.
[x] Output Documentation in docs/output.md is updated.
[x] CHANGELOG.md is updated.
[ ] README.md is updated (including new tool citations and authors/contributors).

fixed the linting action. just guessed what the current template version for this pipeline code is. please change the version in .nf-core.yml to the actual version, so the linting is a bit more precise.

I'll merge this, the linting will be fixed in another PR


Add proper single file js bundle to build

This PR adds a single-file es6 format .js bundle to the webpack output. It also adds a corresponding single-file .css bundle to the output. It also changes around the top level exports and initialization code for the conda-store-ui package. Previously, importing the package would automatically create a top-level demo App element. This behavior is retained for the normal dev webpack build, but the production build now omits any aggressive initialization or demo code. As well there is now a helper createApp function to make it super easy to render a new App element into any artbitrary <div>.
Overall the effects of this PR will make it possible to integrate conda-store-ui directly into conda-store, as well as improving integrations of conda-store-ui in general (eg jupyterlab-conda-store)
pinging @pierrotsmnrd @costrouc

@costrouc @anirrudh can you please review.

@telamonian I've included the bits from https://github.com/Quansight/conda-store-ui/pull/209/commits/571541153f2d7aad4b762fc2da89f778fdacd68d in main https://github.com/Quansight/conda-store-ui/commit/2be4d9629a64cc5681fc757dba5a9e861e14c66b and created a new release. The new release 0.1.1 includes the files as a dist.


Adds support for more of the rendering pipeline

Currently it doesn't take the parent's x, y into account when positioning the objects (I assume I need to read the SVG spec and find  some kind of grouping mechanism) - however it will render a JSX component into a working SVG:

I should export some SVGs from Sketch to see what they look like.

SVG form sketch looks good to me 👍
Just gotta make this kind of structure:


docs: migrate docs from venus-docs

从venusdocs文档迁移。
fix https://github.com/filecoin-project/venus/issues/5012

@zl03jsj 亮兄，review看看？暂时就是搬运文档。按照 文档管理规范 https://github.com/ipfs-force-community/dev-guidances/tree/master/质量管理/文档

Codecov Report

Merging #87 (5a52b97) into master (939f867) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #87   +/-   ##
=======================================
  Coverage   28.81%   28.81%
=======================================
  Files          30       30
  Lines        2950     2950
=======================================
  Hits          850      850
  Misses       1965     1965
  Partials      135      135

Flag
Coverage Δ

unittests
28.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


License headers changed in hoogdalem project to standard USEF license

suggestion to set all license headers in the Hoogdalum project to standard USEF license header format.

Dear Sender,
Please be aware that I will be abroad from Monday 31 October until and including Friday 18 November. I will read and answer your email less frequently during my absence.
Best regards,
Jeroen Bode,
Director USEF.
www.usef.energy


Zephyr 4.0  security related modules update overview

Umbrella issue for tracking security related modules which may require an update before Zephyr 4.0.

[x] https://github.com/zephyrproject-rtos/mbedtls (@ceolin , @d3zd3z , @tomi-font)

Looks to be on upstream latest 3.6.2 LTS https://github.com/Mbed-TLS/mbedtls

[ ] https://github.com/zephyrproject-rtos/tinycrypt (@ceolin )

Is marked as deprecated.  Should the MAINTAINERS.yml also be updated?

[ ] https://github.com/zephyrproject-rtos/trusted-firmware-m (@d3zd3z , @ithinuel , @tomi-font  )

Seems to have been update to the latest upstream 2.1.0 as 2.1.1 is in RC.
https://tf-m-user-guide.trustedfirmware.org/releases/index.html

[ ] https://github.com/zephyrproject-rtos/trusted-firmware-a (@povergoing, @sgrrzhf, @ithinuel )

Seems to be behind (2.7) and not on the LTS (2.10).
I thought we updated to 2.10 with https://github.com/zephyrproject-rtos/zephyr/pull/74111 but I don't see those tags in our repo.

[ ] https://github.com/zephyrproject-rtos/uoscore-uedhoc (@rlubos , @StefanHri )

I'll take care of updating TF-M to 2.1.1 once it is officially released.

uoscore-uedhoc is up to date with upstream.

tinycrypt deprecation is moved to 4.1

All items addressed.


Sort order

It's impossible to change sort order in console->management->wathermaps. I hope this feature in a to-do-list.

Thanks for reporting.  This is why we have Beta's.  How's it  going otherwise?

Fixed in my personal repo.


saveToMemSQLApp.scala question

Hi,
I'm trying to run the example code in WriteToMemSQLApp.scala.
I'm running it through spark-shell, as a yarn-client (my Spark version is 1.3.1).
When I run :
val rdd = sc.parallelize(values)
rdd.saveToMemSQL(dbName, outputTableName, host, port, user, password)
I get an error because saveToMemsql is not a method of rdd.
It seems to me that sc is a org.apache.spark.SparkContext object and that sc.parallelize() returns an org.apache.spark.rdd.RDD object which has no saveToMemsql method.
Where am I wrong ?
Thanks a lot for any hint,
Kimchitsigai

some things to check:

are the correct dependencies included when you start spark-shell? you will need to specify memsqlrdd (the name for 1.0.0) or memsql-connector (1.1.0 and above) in your --jars option

is your rdd of type RDD[Row]? saveToMemSQL is an implicit method that is only available for that type.

closing for now - this can be re-opened if you're still seeing this issue


enable all virtual file systems

Hi! I wanted to use gdal's /vsitar virtual file system and found only checks for curl and mem, so I added the rest. I also modified the if condition a bit to use startswith. I haven't added any test; the best I could do is to provide a tar file and check with that. But I won't be able to check s3, az etc as I don't have any data there.

Great! maybe put all the virtual file system strings in a const above the function to keep things clean?
I'm ok with not testing  them, its not really feasable and we test vsicurl already.

Done!

Thanks!

You're welcome :)


DOCKER-376: support for limiting the number of days application log files are being kept.

Change WORKDIR, so that alfresco logs are being written in /usr/local/tomcat/logs.

As discussed: this can move to the docker-tomcat project
I would also propose to rename the variable to TOMCAT_LOGS_xxx

As discussed: this can move to the docker-tomcat project
I would also propose to rename the variable to TOMCAT_LOGS_xxx

Can you approve this please? The only change is WORKDIR.
New PR in docker-tomcat: https://github.com/xenit-eu/docker-tomcat/pull/27


Rocket League Still Down

Just dark blue, any fixes planned soon?

Will do today

Awesome, love you man, keep up the good work!

I pushed a minor update with new Rocket League pointers. It should automatically update when updater is run.


Audit Logs Docs

@jnikhila @Pranay105 just reiterating what I added in one of the review comments here.
We log about 25+ different events. This is missing from the draft but the event names and descriptions are available here. Hope this helps.
https://www.notion.so/appsmith/579671b3503b48b1a5967b969e3823e2?v=92a738b1dbc5438c97ca27ca87bc30fd


Getting unexpected results with readonly parameter in class constructor

Bug Report

🔎 Search Terms

Class Constructor
Readonly Parameter
Parameter Properties

🕗 Version & Regression Information
all(from 3.3.3 to 4.6.4 and 4.7.0-beta)

This is a crash
This changed between versions ______ and _______
This is the behavior in every version I tried, and I reviewed the FAQ for entries about _________
I was unable to test this on prior versions because _______

⏯ Playground Link

Playground link with relevant code
💻 Code

class Foo {
    constructor(readonly bar: string) { }
}

🙁 Actual behavior

"use strict";
class Foo {
    constructor(bar) {
        this.bar = bar;
    }
}

🙂 Expected behavior

"use strict";
class Foo {
    constructor(bar) {
    }
}

This is working as intended. See the documentation: Parameter Properties

I'm surprised as well, but readonly is listed.

These are called parameter properties and are created by prefixing a constructor argument with one of the visibility modifiers public, private, protected, or readonly.

It's probably read as "one of the modifiers (public, private, protected) or alternatively readonly."

See also: https://github.com/microsoft/TypeScript/issues/7590#issuecomment-199094100

It makes sense. Close this issue.


[eas-cli] Remove workaround for gitignore parsing (fixed upstream)

Checklist

[ ] I've added an entry to CHANGELOG.md if necessary. You can comment this pull request with /changelog-entry [breaking-change|new-feature|bug-fix|chore] [message] and CHANGELOG.md will be updated automatically.

Why
Remove workaround for some git ignore files. Issue was fixed upstream in https://github.com/kaelzhang/node-ignore/issues/81
How
Remove workaround, package was updated in https://github.com/expo/eas-cli/pull/1617
Test Plan
run build with a .gitignore including test\ entry.

/changelog-entry chore Remove unnecessary workaround for trailing backslash in .gitignore.


ISPN-8978 Remove usage of deprecated GMS#install_view_locally_first

Jira
https://issues.jboss.org/browse/ISPN-8978
GMS#install_view_locally_first was deprecated and is never used but does not issue a warning message (JGRP-2258).
This should be removed from the stack configuration.
Cross-check
https://github.com/belaban/JGroups/blob/master/src/org/jgroups/protocols/pbcast/GMS.java#L107

Merged, thanks


fix(darwin): fix mac address matching

macOS decided to drop leading zeroes on mac address octets so we now have to match on 1 or 2 characters in the regex.
Also fixed the regex to include an optional "permanent " before the device type.
Lastly, added a decode to make python 3 happy.

Added, thanks :)


Added support for "text" type of OPML outlines

curseradio-improved used to crash whenever one navigates into an outline
of the type "text".  Now it shows the outline's text instead

Sounds reasonable! I'm not actively maintaining this project (thus the late reply), but I'll merge it so "cloners" can benefit from your changes :)


moment("0004-01-01T07:59:59+08:00").format() result error

Environment:
Chrome 67 on OSX
console.log( (new Date()).toString())
// Thu Jul 19 2018 14:20:08 GMT+0800 (中国标准时间)

console.log((new Date()).toLocaleString())
// 2018/7/19 下午2:20:08

console.log( (new Date()).getTimezoneOffset())
// -480

console.log( navigator.userAgent)
// Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/67.0.3396.99 Safari/537.36

console.log(moment.version)
// 2.10.6

bug:
moment("0004-01-01T07:59:59+08:00").format()
// 0004-01-01T08:05:42+08:00

other message:
new Date("0004-01-01T07:59:59+08:00")
// Thu Jan 01 0004 08:05:42 GMT+0805 (中国标准时间)

Chrome 67 added and uses historic timezone information - which leads to some surprising date/time formatting before countries started aligning and standardising around GMT / UTC offsets.
Example: Chongqing has an offset of 7 hours 6 minutes 20 seconds until 1928, when it aligned as +7 hours.
moment isn't doing anything wrong, and neither is Chrome.  It's just surprising, and inconsistent as Chrome appears to be the only browser using such historic timezone information.

I know it's because chrome use historic timezone info.
But I think moment's result is incorrect.
moment("0004-01-01T07:59:59+08:00").format()
// 0004-01-01T08:05:42+08:00

result should be:
// 0004-01-01T08:05:42+08:05
or
// 0004-01-01T07:59:59+08:00

like chrome's result:
new Date("0004-01-01T07:59:59+08:00").toISOString()
// 0003-12-31T23:59:59.000Z


A plugin system (for custom file types, etc)

Offer a way to allow developers to publish custom file types as part of their Worker.

@petebacondarwin Is this addressed by module rules?

Hmm. I'm not sure. Rules support the following type: ESModule, CommonJS, CompiledWasm, Text or Data.
So I guess Data could cover custom types?
Honestly I am not sure what the original requirement was.
Let's close this since no one seems to be asking for it.


Change icon classes

For instance I use FontAwesome instead of glyph icons in my project, so would be great to have an opportunity to change icons classes.

You can change search icons classes starting from version 3.0.0

@diegofsza you missed remove icon.. :)
In any case, thank you for the component!


LDAP settings v2 resource does not support search filter as variables

Describe the bug
If you use a variable as input for the search_filter argument in the artifactory_ldap_settings_v2 resource, it will fail even if the supplied string is a correct ldap search filter.
Versions
Terraform v1.3.9
on darwin_amd64
+ provider registry.terraform.io/jfrog/artifactory v10.1.0

❯ jf rt curl api/system/version
{
  "version" : "7.77.1",
  "revision" : "77701900",
  [...]
}

Failing code sample
terraform {
  required_providers {
    artifactory = {
      source  = "jfrog/artifactory"
      version = "~>10.0"
    }
  }
}

provider "artifactory" {
  url           = "https://company.jfrog.io"
  check_license = false
  access_token  = "xxx"
}

variable "search_filter" {
  type    = string
  default = "(&(objectClass=inetOrgPerson)(uid={0}))"
}

resource "artifactory_ldap_setting_v2" "this" {
  key      = "my_ldap"
  ldap_url = "ldaps://my.ldap.example.com"

  search_base = "ou=my,dc=company,dc=com"
  search_filter    = var.search_filter
  manager_password = "password"
  manager_dn       = "dn=user.name"
  search_sub_tree  = true
}

❯ tf plan
╷
│ Error: Incorrect Attribute Configuration
│
│   with artifactory_ldap_setting_v2.this,
│   on repro.tf line 25, in resource "artifactory_ldap_setting_v2" "this":
│   25:   search_filter    = var.search_filter
│
│ Expected search_filter to be a valid LDAP search filter, LDAP Result Code 201 "Filter Compile Error": ldap: filter does not start with an '('
╵

Working code sample
terraform {
  required_providers {
    artifactory = {
      source  = "jfrog/artifactory"
      version = "~>10.0"
    }
  }
}

provider "artifactory" {
  url           = "https://company.jfrog.io"
  check_license = false
  access_token  = "xxx"
}

resource "artifactory_ldap_setting_v2" "this" {
  key      = "my_ldap"
  ldap_url = "ldaps://my.ldap.example.com"

  search_base = "ou=my,dc=company,dc=com"
  search_filter    = "(&(objectClass=inetOrgPerson)(uid={0}))"
  manager_password = "password"
  manager_dn       = "dn=user.name"
  search_sub_tree  = true
}

Terraform used the selected providers to generate the following execution plan. Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # artifactory_ldap_setting_v2.this will be created
  + resource "artifactory_ldap_setting_v2" "this" {
      + allow_user_to_access_profile = false
      + auto_create_user             = true
      + email_attribute              = "mail"
      + enabled                      = true
      + id                           = (known after apply)
      + key                          = "my_ldap"
      + ldap_poisoning_protection    = true
      + ldap_url                     = "ldaps://my.ldap.example.com"
      + manager_dn                   = "dn=user.name"
      + manager_password             = (sensitive value)
      + paging_support_enabled       = true
      + search_base                  = "ou=my,dc=company,dc=com"
      + search_filter                = "(&(objectClass=inetOrgPerson)(uid={0}))"
      + search_sub_tree              = true
    }

Plan: 1 to add, 0 to change, 0 to destroy.

───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────

Note: You didn't use the -out option to save this plan, so Terraform can't guarantee to take exactly these actions if you run "terraform apply" now.

Expected behavior
The ability to use a variable as input for the search_filter argument to the artifactory_ldap_settings_v2 resource.

@lsc Thanks for the report. I'll look into this.


Simplyfying configuration

Ad-hoc changes aimed towards configuration simplification.
Humbly requesting comments on the suggested changes.

hotovo, ohodnotit, zamergovat, pls


Seems to infinite-loop

I may be doing something incredibly wrong, but I figured I'd post this in case you've seen it before. I cannot seem to get this library to work with any of my zip files. Whenever I call JSInflate.inflate on a zipped entry (from the js-unzip library), my processor gets pegged at 100% and it seems to be causing an infinite loop in this: while((i = zip_inflate_internal(buff, 0, buff.length)) > 0)
Here is my full code:
$('input:file').live('change', function() {
  var file = this.files[0],
  r = new FileReader();

  r.onload = function(e) {
    var unzipper = new JSUnzip(r.result);

    if (unzipper.isZipFile()) {
      unzipper.readEntries();
      for (var i = 0, var len = unzipper.entries.length; i < len; i++) {
        var entry = unzipper.entries[i];
        getEntry(entry);
      }
    }

  r.readAsBinaryString(file);
});

getEntry = function(entry) {
  var uncompressed;
  if (entry.fileName.match(/some_file_name/)) {
    if (entry.compressionMethod == 0) {
      // Uncompressed
      uncompressed = entry.data
    } else if (entry.compressionMethod == 8) {
      // Deflated
      console.log('inflating...');
      uncompressed = JSInflate.inflate(entry.data);
      console.log(uncompressed);
    }
};

As you can see, I'm only trying to uncompress one file within the Zip (and it's a small 1.5KB text file). It get's to the inflating... line, but that's when the CPU gets pegged in Chrome (in FF, it'll say the script has stopped responding).
Also, I tried the dankogai/js-deflate library, and it does the exact same thing.

@casaschi, awesome thanks! Reverting to js-unzip/663d892c did the trick. I'm not clear where that & 0xff was supposed to go or what issue it fixed though.

So reverting to the previous release (mentioned above) of js-unzip worked for me. I'm unclear if I should leave this ticket open, as I'm not sure if it's an issue with js-unzip or rather a conflict between js-unzip and js-inflate. I'll leave it open for now, and someone else may close it if they'd like.

Hey :) Just deprecated this project. There are now well maintained alternative modules that didn't exist when I orginally created this project. I've linked to a few of them in the README :)


direct block refs resolve to empty

sample
test "hello" {
    data = "world"
}

output = test.hello

observed
output: {}

expected
output: { data: world }

actually, it happens only when the block defined is below the variable that needs resolved


Bug/Enhancement - Incompatability with AlpineJS

Describe the bug
Trialling Sprig with a client site that's already using AlpineJS. The two work alongside each other just fine until I add any AlpineJS within a Sprig Component, the x-data, @click etc. is stripped from the element.
x-data declares the scope of the AlpineJS component (ie x-data="{ foo: 'bar' }"), @click attaches an event listener, but then when loading up the page, it seems Sprig/HTMX has removed all of this from within the component.
Technically a bug, but I understand the two both serve similar purposes so it may be unrealistic to expect compatibility, figured I'd submit though just in case.
To reproduce

Setup a file that uses both AlpineJS and a Sprig Component.
Add some AlpineJS to an element within the Spring Component.
Load up the page. AlpineJS will now have been stripped from the component.

Expected behaviour
AlpineJS directives to remain intact in the DOM.
Ps. thanks for an awesome plugin, Ben!

I've added a section to the docs that addresses compatibility with AlpineJS:
https://putyourlightson.com/plugins/sprig#javascript-in-components
Let me know if that solves it for you.

Perfect, thanks for that. Tested and working 👍


Implement a cancellable CallContext() method

Use the RfcCancel method to push down a context to the CallContext(ctx context.Context, ...) method.

👍

Hello,
this project is not any more supported by SAP. Please see https://github.com/SAP/gorfc/issues/42
You can contact new maintainers, when found


Enhancement: Update Data Connector Error Messages

Goal-State/What/Result

All Data Connector error messages succinctly describe the source the error originates for, like the catalog or dataset name, in the error message.
All Data Connector errors accurately describe the error being returned, and use the most specific available error message for that error type.
Error handling guidelines are updated to reflect the changes introduced by this enhancement as a general guide, for principles-based error handling

Why/Purpose

To improve the user experience by providing accurate error information, so users know what dataset failed and why.
To assist with debugging and fixing failing Spicepods.

By When
A target date for done-done completion of the entire enhancement.
Issue/Spec written and reviewed: 18th Nov, 2024
Done-Done: 20th Nov, 2024
Done-Done

[x] Principles Driven
[x] The Algorithm
[x] PM/Design Review
[x] DX/UX Review
[ ] Threat Model / Security Review
[ ] Tests
[ ] Performance / Benchmarks
[ ] Documentation
[ ] Samples/Quickstarts/Tutorials
[ ] Release Notes

The Algorithm

[x] Every requirement questioned?
[x] Delete (Scope) any part you can.
[x] Simplify.
[x] Break down into smaller iterations/milestones.
[x] Opportunities for automation.

Specification

Data Connector error messages are updated to include the catalog or dataset the error relates to.
Data Connector errors are updated to include more specific error types, like an error for rate limiting.

Security Review

Updated error messages should not contain secret values

UX Changes
A summary of UX changes:

Error messages are re-written to exclude internal concepts. E.g. Unable to get read provider -> Failed to register the dataset/catalog ...
Error messages are updated to include references to the source catalog/dataset. E.g. Invalid configuration for <connector> -> Invalid configuration for the <dataset/catalog> <name> (<connector>)
A new rate limit specific error type is created like The <dataset/catalog> <name> (<connector>) has been rate limited: <error>
Error return types for data connectors are updated to use more specific error types instead of generic UnableToGetReadProvider

How/Plan

Update Data Connector error messages to exclude references to internal concepts

For example, Unable to get read provider ... - a read provider is an internal concept, typically referring to the construction of a read-only table provider. This error occurs outside the realm of DataFusion, so cannot be caught by DataFusion error handling (like those from TableProvider).
These error messages should instead be updated to use language that a user can better understand, like:
Failed to register the <dataset/catalog> <name> (<connector name>): <inner error>

Where <inner error> is a generic Box<dyn Error> that could represent any kind of unknown error message encountered when constructing a table provider for a data connector.

Update Data Connector error messages to refer to the source catalog or dataset

For example, the InvalidConfiguration error has an error message Invalid configuration for <data connector>. <message>.
These error messages should be updated to a standard format, like Invalid configuration for the <dataset/catalog> <name> (<connector name>): <message>.

New Data Connector Error types should be created for more specific errors

For example, more specific errors like rate limiting. A new error type should be created for RateLimited, that has a message like:
The <dataset/catalog> <name> (<connector name>) has been rate limited: <inner error>

<inner error> usually contains more information from the specific data connector about the nature of the rate limit. For example, in the GitHub data connector:
The dataset spiceai.pulls (github) has been rate limited: GitHub API rate limit exceeded. Try again later, and add a LIMIT clause to your query to reduce the number of requests.

Data Connectors are updated to return more specific error messages (where applicable)

Again, GitHub data connector as the example. In some locations, it returns a generic error when a more specific error is available.
For example, this error:
let Some(tree_sha) = tree_sha.filter(|s| !s.is_empty()) else {
            return Err(DataConnectorError::UnableToGetReadProvider {
                dataconnector: "github".to_string(),
                source: format!("Branch or tag name is required in dataset definition; must be 'github.com/{owner}/{repo}/files/BRANCH_NAME'").into(),
            });
        };

could be updated to DataConnectorError::InvalidConfiguration, as the error refers to the input from the user being incorrect.

Error handling guidelines are updated

Implementation (Sub-Issues)
Updates for all connectors:

[x] #3573
[ ] #3574

Connector specific updates/passes:

[ ] DuckDB
[ ] GitHub
[ ] MySQL
[ ] PostgreSQL
[ ] S3
[ ] DataBricks
[ ] Delta Lake
[ ] FlightSQL
[ ] ODBC
[ ] Spice.AI
[ ] ABFS
[ ] Clickhouse
[ ] Debezium
[ ] Dremio
[ ] File
[ ] FTP/SFTP
[ ] GraphQL
[ ] HTTP/HTTPS
[ ] Localpod
[ ] MS SQL
[ ] Sharepoint
[ ] Snowflake

Done-Done: 28th Nov


Treat referrer policy as fully supported even absent strict-origin-when-cross-origin

The note is about the default behavior, which is what happens when you don't use the feature (header or attributes).

Sounds good, thanks!


Release freeze status check

Create a release freeze GitHub status check that can be used to block merging to master except by the release manager. This will help enforce releases created from a clean nightly dashboard.

Ping

An alternative approach here is to shepherd commits into the release branch. With GitHub, we have testing for both master and release branches.


Feature/rework postgres block query with shared model

Description of the Change
migrates postgres_block_query to the shared_model

Benefits
more shared_model

Possible Drawbacks
no

Usage Examples or Tests [optional]
no

Alternate Designs [optional]
no

You can remove unused optional paragraphs from the PR description


Managed Node Group Cluster Provider: KubectlLayer comparison is false

Describe the bug
When using the Managed Node Group Cluster Provider we are receiving the following warning:
"[Warning at /dev-harness-infrastructure-cluster/dev-harness-infrastructure-cluster] You created a cluster with Kubernetes Version 1.25 without specifying the kubectlLayer property. This may cause failures as the kubectl version provided with aws-cdk-lib is 1.20, which is only guaranteed to be compatible with Kubernetes versions 1.19-1.21. Please provide a kubectlLayer from @aws-cdk/lambda-layer-kubectl-v25]"
We are setting the cluster version as follows:
const k8sVersion = KubernetesVersion.V1_25
const clusterId = `${id}-cluster`
this.blueprintStack = builder
  .version(k8sVersion)
  .addOns(...addOns)
  .clusterProvider(mngProvider)
  .enableControlPlaneLogTypes(...logTypes)
  .teams(new PlatformTeam(`${id}-team`, platformTeamRole))
  .build(scope, clusterId, props)

Expected Behavior
The appropriate layer for v1.25 should be matched in the condition and used.
Current Behavior
The switch statement is comparing objects and not evaluating to the correct version.
Reproduction Steps
Create a new blueprint similar to:
const k8sVersion = KubernetesVersion.V1_25
const clusterId = `${id}-cluster`
this.blueprintStack = builder
  .version(k8sVersion)
  .addOns(...addOns)
  .clusterProvider(mngProvider)
  .enableControlPlaneLogTypes(...logTypes)
  .teams(new PlatformTeam(`${id}-team`, platformTeamRole))
  .build(scope, clusterId, props)

run
cdk diff

A warning will be logged to the console.
Possible Solution
In the getKubectlLayer function, its is comparing objects and failing whereas comparing the string version i.e. version.version against the KubernetesVersion then the layer version is correctly determined.
e.g.
const getKubectlLayer = (scope, version) => {
  switch (version.version) {
    case eks.KubernetesVersion.V1_25.version:
      return new lambdaLayerKubectlv25.KubectlV25Layer(scope, 'kubectllayer25')
    case eks.KubernetesVersion.V1_26.version:
      return new lambdaLayerKubectlv26.KubectlV26Layer(scope, 'kubectllayer26')
  }

  const minor = version.version.split('.')[1]
  if (minor && parseInt(minor, 10) > 26) {
    return new lambdaLayerKubectlv26.KubectlV26Layer(scope, 'kubectllayer26') // for all versions above 1.25 use 1.25 kubectl (unless explicitly supported in CDK)
  }

  return undefined
}

Additional Information/Context
No response
CDK CLI Version
2.84.0
EKS Blueprints Version
1.9.1
Node.js Version
18
Environment details (OS name and version, etc.)
Ubuntu 20.04.6 LTS
Other information
Similar to #607

@pennywisdom I believe this was addressed in the latest versions, e.g 1.11.0. Please let me know if you still experience this behavior.

@pennywisdom Closing this issue as the issue is addressed and we have not heard back. Please reach back if you still face this issue.


Add documentation to tracing

@richardwxn: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

operator-test
550afabe958a6d47f17e062ace7037961a99754d
link
/test operator-test

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test operator-test


Image not working with text beside it

testing (img)tera(/img) <-- not working

FIXED!!!

And now uploaded to the stores.

Issue fixed.


#335: Filter featured content on chosen category

GlobalDigitalLibraryio/issues#335

TODO

[ ] Release.
[ ] Deploy to test.
[ ] Deploy to staging.
[ ] Deploy to prod.


Auto-generate keys when none is being specified

In the authentication plugins, auto-generate keys when they're not being specified.

This should probably be explicit, with a querystring parameter like:
curl -d "autogenerate_credentials=true" ...

For generating keys and more: https://github.com/openresty/lua-resty-string
I think they should be generated if none is in the parameters. Or maybe all the time, as it is safer.

It will generate a key if none has been specified (only applies to Key Authentication).


File Menu, recent files

LogoRRR should have a 'file menu' like any decent desktop app.
Entries:
LogoRRR

About LogoRRR (opens an about dialog, only logo with link to various homepages (twitter, buymeacoffee, github, website)
Quit

File

Open File (file dialog)
Recent Files
Most recent file .. (open when selected)
... up to 10 files (check if they still exist, if not mark them somehow)

Those entries should be saved in ProgramData in an easy readable format and be persistent.
Anyhow, the next run opens the last opened files automatically.

implemented - at last!

...

considering the work and the added value i currently see in this feature, I close this ticket - in the meantime i'm happy with how it works at the moment.


#hypotheses >= #codes

The current decoder interface assumes #hypotheses = #codes.
For example, the implementation of Decoder.number_of_remaining_codes is:
let number_of_remaining_codes t = hypotheses t ~strict:true |> List.length

This is a conceptual bug since in general, even though each hypothesis implies a unique code, there is no guarantee that 2 hypotheses imply different code. Another way to state the same is that the same code can result from two different hypotheses.
This issue currently did not come up in practice through the problems that have been tested, but this may come up in a problem in the future.
To fix this would mean stopping to rely on the incorrect assumption, and modifying the decoder interface and solver logic accordingly.

Fixed by c5efcd9e25c515bc1ab5fa15d4b2910a2c22dc87 and related commits.


Remove outdated user section in docs

What would you like to be added:

Remove all pages under https://distro.eks.amazonaws.com/users/build-prerequisites/
https://distro.eks.amazonaws.com/users/build/

Why is this needed:

Directions are in the repo. The ones on the website are redundant and out-of-date.

Fixed by #1920


Tool bar size adjustment when contextually zooming out

The toolbar icons will now increase in size to compensate when zooming out to help with visibility. Fixes #317.
https://github.com/codepod-io/codepod/assets/105993789/4d4f570d-2d28-47c4-a560-f4b96f8a8c46
I also adjusted the toolbar placement for scopes slightly so it would not block the scope title when zoomed out.

Nice, thanks!


pdn/pad: remove deprecated versions of these tools

Removes old versions of PDNgen and ICeWall.

I believe gf12/bp_single is still on the old icewall.  I'll look at converting it so we can move forward with this PR.  I may have some questions :)

@maliberty no rush to merge this in, for PDN it's been more than a year and ICeWall its been about 5-6 months.

@maliberty with the removal from ORFS this is ready to merge

I'll do a secure CI to ensure I didn't miss anything.


Time blocking Search Results

From my experience, it may be more useful to only return one result per time block of some length when searching. Currently, all frames with the text are returned, so this means there are often dozens of frames from really the same "instance" of the found text.
I'm thinking return the most recent frame within a 10 minute block or something like that?
Rewind does something along these lines, and it's pretty helpful!

Maybe there's a grouped view? Like each row is a bucket of matching frames in order that are within some time frame?
We skip taking screenshots if OCR returned the exact same result fwiw (assuming the setting is enabled).

Grouped view could be good! A little worries it would still be cluttered and you could only have a couple groups at once. Another option could be groups by time and when you click on the frame group it shows all frames within.
Oh cool! Where is that skipping implemented I can't find it?

You know, I partially retract - that's what I wrote on a branch, but opted to instead do pixel perfect comparison:
https://github.com/jasonjmcghee/rem/blob/f4f68049a064557bddeb93753f82aa41af776b98/rem/remApp.swift#L341
I ended up not doing the OCR comparison approach as I was concerned about things like photoshop, blender, etc. having high frame loss.


Fixing return type of verifySnapshotWithResolvedTimestamps

This should address a crash that happens when a debugger is attached.

@wilhuff Gil, do you know why the 'id' return type might cause a segfault in the test run? I can only reproduce this when I have a debugger attached.


Std lib feature gate

Enables the std library.
Close #37

Closed to integrate all the changes on the development branch instead


Latest releases not showing up in OSS repositories

I'm not seeing any releases since 3.10 in the OSS maven repositories.  It would be good if the recent releases could get published.
Also, it would be nice if the git repo is tagged per release so git history doesn't have to be used to determine what sha corresponds to a release.

Thanks ddimensia, I'll be uploading the artifacts to maven very soon

3.13 has been deployed into maven central


Appdata directory is invalid

I got the same error

QEditor - Located at path C:\Users\my_username\AppData\Roaming\QEditor This is appdata file comes pre-installed with any version of editor and can be downloaded from here QEditor Full Version.

Its build in latest commit

Fixed in version 0.4


Delete commands should have a confirmation message

Same for clear command

As discussed, will not pursue as it is not trivial


Using the latest (v2.64.0) version of the Blowfish theme as a Hugo module provokes an error

Description
Using the Blowfish theme, following Hugo module  instructions, fails while it was possible to use it without any trouble with previous versions.
How to reproduce

Create a new site with Hugo
Manually set Blowfish as the theme using hugo module
Start hugo server
(Blowfish theme) Module is downloaded but server exists with an error:

(...)
hugo  | go: no module dependencies to download
hugo  | hugo: downloading modules …
hugo  | go: downloading github.com/nunocoracao/blowfish/v2 v2.64.0
hugo  | go: added github.com/nunocoracao/blowfish/v2 v2.64.0
(...)
hugo  |   -v, --verbose                    verbose output
hugo  |
hugo  | Use "hugo server [command] --help" for more information about a command.
hugo  |
hugo  | Error: command error: failed to load modules: module "blowfish" not found in "/src/themes/blowfish"; either add it as a Hugo Module or store it in "/src/themes".: module does not exist
hugo exited with code 1

This bug doesn't affect previous versions
Tested from versions 2.61.1 up to v2.63.0

How I checked previous versions being OK:

Using the same containerized hugo (using docker) to get a clean environment each time (and minimize the risk of local stuff -cache/whatev- being the source of this issue)
Replacing the required version in go.mod (and nothing else = keeping  "github.com/nunocoracao/blowfish/v2" unchanged in hugo configuration)

Expected behavior
Create a fully functional Hugo site using Blowfish theme ... like it was possible few weeks ago using the very same instructions 🤷
Environment

OS: Linux
Hugo: 0.124.1 (latest)
Blowfish theme: v2.64.0 (latest)

Additional information
For those relying on Hugo modules to use this theme, this issue can make your CI/CD workflows (pushing to GitHub/GitLab Pages) fail with the same error, depending on how you're handling that process.
Workaround
Pin the version to the previous one: v2.63.0 ... while this issue is fixed or another version is pushed without provoking the same error 🤷

Hey @Usual-Coder thanks for this. I'll have a look. I would advise against pinning the version and instead hold on updating the theme. If this gets solved quickly people will forget to unpin the version.

Hello @Usual-Coder - fixed in https://github.com/nunocoracao/blowfish/releases/tag/v2.65.0

Hi @nunocoracao
When your workflow is automated "holding without pinning" may not be easily achieved (or even possible) ... may I suggest to have a little faith in your users' capabilities to take a workaround for what it is (something temporarily useful "(...)while this issue is fixed or another version is pushed(...)") = the ones bothering reading the issues will probably keep an eye on the resolution for those affecting them = temporary workarounds having the tendency to become permanent when the resolution is long overdue ... just my 2 cents 🤷😇😅
Anyway, thanks for fixing that so quickly ... the theme/time you've given to the community is greatly appreciated 🙇

@Usual-Coder don't agree but appreciate the feedback :)
I will try to do better...