Is it possible to validate is Schema without producing a message with a Kafka agent?

Hello,
I am currently developing services to produce and consume messages with a Kafka cluster in MSK, currently I need to use schema validation, for this I am trying to use Glue Schema Registry, however I find myself with the problem that the services to produce and consume messages must be developed in .NET as required by the project I am working on, while Glue Schema Registry only has support in JAVA, it occurs to me as a possible solution, separating the tasks of consuming and producing messages in .NET services and validate schemas with services in JAVA.
For example, deliver a message to the producer developed in .NET, send the message to a JAVA service to validate the schema and, if everything is correct, return a positive response to the .NET producer so that it proceeds to produce the message, but I don't know if this idea is feasible, so I would like to ask if this is possible? Or can only schema validation be used with Kafka agents developed in JAVA as can be seen in the examples?
Thank you very much.

Hello @cr-urra,
We are actually working on supporting .NET for our client library, once it is released, you should be able to use our client library in your .NET application.
Going back to your idea, I think it is totally feasible and can be a work-around until our .NET client library is ready.


Use StringUtils.equals in expression in src/main/java/org/trebol/jpa/services/conversion/BillingTypesConverterJpaServiceImpl.java

https://github.com/trebol-ecommerce/spring-boot-backend/blob/3b07112388854b6c7a4003ea2de381ebb12cd2bd/src/main/java/org/trebol/jpa/services/conversion/BillingTypesConverterJpaServiceImpl.java#L61
Thanks @NyorJa

Instead of !name.isBlank() use StringUtils.isNotBlank
https://github.com/trebol-ecommerce/spring-boot-backend/blob/3b07112388854b6c7a4003ea2de381ebb12cd2bd/src/main/java/org/trebol/jpa/services/conversion/BillingTypesConverterJpaServiceImpl.java#L61

Hi @mepox we can use StringUtils.equals() directly since it can deal on null checking and comparison

Hi, @mepox  I'm new to open source. could you assign me this issue I would like to give it a try on this.

Hi @amaan0o7 ! @bglamadrid need to confirm if it's ok to work on this as he might do some redesign/refactor..

okay @mepox  can you point me to an issue that I can address?

Hi @amaan0o7 sorry but this issue is blocked by PR #227
It is likely that this will be resolved once I'm done

My suggestion is that you please be patient until #227 is over and closed
After that we'll be counting with a new, tidier, cleaner codebase. Issues should be easier to spot if any one ever raises.

okay @mepox can you point me to an issue that I can address?

@amaan0o7 #225 is a good first issue

thanks, @bglamadrid @mepox  I'll look into that one.

have a good one @amaan0o7

This issue is not present in the current version of the BillingTypesConverterJpaServiceImpl (since the recent merging of #227), so I'm closing it.


Can't launch unless TE version < 5.4.0, 5.4.0 was a big update

Unless you were already planning on doing this, could you possibly make it compatible with the newest TE version?

Any and all mods using the cofh API prev to 5.4 would now have to change things to allow for vers to use the old API and the new API depending on cofh version used

Ouch, alright. Guess I can't use Simply Jetpacks then.


Add Prettier

This PR adds the Prettier code formatter, by adding docs about it, adding CI to make sure the formatter is ran, and formatting the existing files.

i have no idea why this messes up travis

I'm pretty sure development needs to still be possible directly from the browser (especially within the web IDE). Adding packages that need to be installed for all devs won't be possible anytime soon.
I know this because I started working on global, shared, TypeScript support and a very important requirement was to be entirely optional.
As far as I understand you want to force it onto all apps, which would entail such forced package installation.

I'm pretty sure development needs to still be possible directly from the browser (especially within the web IDE). Adding packages that need to be installed for all devs won't be possible anytime soon.

Development in the browser is still possible. prettier is just a devDependency. It was just accidentally added as production dependency.

As far as I understand you want to force it onto all apps, which would entail such forced package installation.

No, you don't have to install the NPM packages. The CI build will fail, if your code isn't formatted as expected and then you can fix those formatting issues manually or via some prettier editor plugin.
It would be nice, if the WebIDE had a "format code" button, but this merge request is already large enough and I wouldn't add this feature here.

i have no idea why this messes up travis

I have also no idea.
BangleApps/apps/setting/settings-icon.js was changed from
require("heatshrink").decompress(atob("mEw4UA///+Nj5lCt9TH+cBqtVoALWqALTgoLUiALFgoLDqoBBAAQGCHAdRBYdFKwZECqv614ECGQQsCr2q1W1BYkVAoPqBYOrAoNUBYdXBQIAB6oLDEQgkEBYdaBYelBYt6BYetBYYvBtWq0EK1WpF4ZfBIwIFBJATCDBY6PDiuq1AEBlWqBdA7KKZZrLQZabNWZLLLcZb7LBYVV/WvAgRfCNYNRBAVVoq/FJQRECR4gnBEwQEBggLDGQg4CBag4DBaBWBBaoATA"))

to
require("heatshrink").decompress(
  atob(
    "mEw4UA///+Nj5lCt9TH+cBqtVoALWqALTgoLUiALFgoLDqoBBAAQGCHAdRBYdFKwZECqv614ECGQQsCr2q1W1BYkVAoPqBYOrAoNUBYdXBQIAB6oLDEQgkEBYdaBYelBYt6BYetBYYvBtWq0EK1WpF4ZfBIwIFBJATCDBY6PDiuq1AEBlWqBdA7KKZZrLQZabNWZLLLcZb7LBYVV/WvAgRfCNYNRBAVVoq/FJQRECR4gnBEwQEBggLDGQg4CBag4DBaBWBBaoATA"
  )
);

and now acorn believes, that there is an unexpected token at (5:1).

I have also no idea.

I think, the problem is, that the sanity check wraps the JavaScript code in braces for some reason
https://github.com/espruino/BangleApps/blob/d9d5926416566762e59b953c745f989d23c9b334/bin/sanitycheck.js#L150

Hi!

It would be nice, if the WebIDE had a "format code" button, but this merge request is already large enough and I wouldn't add this feature here.

It does! Ctrl-B. All shortcuts are listed in when you click settings in top-right.
Thanks for this, but I'm afraid I'm not sure about merging this at all. It looks like you've spent ages on this but it would have been really good to have some kind of discussion about it first.
While in theory it'd be good, we're trying to be friendly to new contributors who are generally completely new to version control and CI. For the majority I think jumping through code formatting hurdles as well would really put them off.
I think the reality is that 75% of all new commits would immediately fail the CI test, and I (or whatever maintainer) would just end up having to merge them regardless and then waste extra time trying to fix the CI checks by running the reformatter. IMO the real issue is that CI fails for formatting would then end up hiding serious failures - so we'd end up merging something that appeared just to be badly formatted, then finding out after reformatting that it was totally broken, and having to manually revert the commit.
I'm open to others' views on this, but I think it does need to be discussed with the wider community - not just those on GitHub who are already more likely to be used to this kind of thing.
Even failing that I've got some issues with the formatting rules which IMO sometimes make the code less readable. Also reformatting all the icons to add newlines is (IMO) only a negative thing. You can no longer just paste code direct from the image converter, and I can't remember offhand whether icons are minified before upload but it's possible it'll could even hurt upload speed.
Having said all that as @T0TProduction says having a tool that could be used if a user wanted to would only be a good thing - it's just requiring all users to do it could I feel be problematic.

Thanks for this, but I'm afraid I'm not sure about merging this at all.

Understandable, a pull request, which touches almost all files shouldn't get merged light-heartedly. Maybe there is a way to introduce Prettier more gradually.

While in theory it'd be good, we're trying to be friendly to new contributors who are generally completely new to version control and CI. For the majority I think jumping through code formatting hurdles as well would really put them off.

I don't think, that telling people to format their code consistently, when committing to a shared code base is asking too much. Fixing the formatting can be done really easy with Prettier. You don't have to read any complicated style guide or something, just run npx prettier --write . and commit the changes.
Even for novice users, the WebIDE could be used to format the code.

I think the reality is that 75% of all new commits would immediately fail the CI test,

Yes, definitely, I forget to format my code all the time. It's possible to set up git commit hooks, but that's not straight forward.
From my experience, if you don't enforce a certain style with the CI, then the formatting will always get messed up over time and then you get all those random formatting changes in pull requests. One person forgets to format the code and then another person makes a small change, but also reformats the file.
Documenting the code style and onboarding new staff also becomes a lot easier. Just tell anyone to use Prettier.
People also seem to prefer a machine telling them, that their code might need some improvements over a human doing the same.

so we'd end up merging something that appeared just to be badly formatted, then finding out after reformatting that it was totally broken, and having to manually revert the commit.

But that's why git uses branches, so you can make sure, that the code works before merging it. Branches which fail the CI build, should not get merged.

Even failing that I've got some issues with the formatting rules which IMO sometimes make the code less readable.

Before my company introduced code formatting tools, I was also sceptical. However, after more than two year, I have to say, that those cases happen very rarely and if they happen, you can still disable Prettier for a certain code block.
Overall the advantages outweigh the disadvantages. I can focus on the code and I don't have to think about the formatting. Merge conflicts due to formatting issues also happen a lot rarer. When doing code reviews, there is absolutely no time wasted on pointing out formatting issues. Code written by other people will also feel a lot less alien, if the formatting matches your own.

Also reformatting all the icons to add newlines is (IMO) only a negative thing.

If the icons follow a certain name pattern, then they can easily get excluded by adding the name pattern to .prettierignore.

Having said all that as @T0TProduction says having a tool that could be used if a user wanted to would only be a good thing - it's just requiring all users to do it could I feel be problematic.

An alternative could be to run Prettier over the whole code base from time to time. However, I wouldn't use this approach in my projects since it results in a messy git commit history.

I am 100% for consistent formatting in code.
And IMO a shared config would be great.
But as Gordon said, If we have additions by users that are not necessarily devs, but "just" tinkerers, adding too much around simply "uploading" code makes it much more difficult to contribute.
If the maintainers (aka. just Gordon?) are willing and able to reformat PRs it's fine to enforce it. But if that's simply out of scope, I think it just adds unwanted complexity (If forced by CI mind you, not the adding it as optional part)
Another thing to take into consideration is that while this is a shared repo, the codebase is not shared. Every app is essentially its own codebase, so a lot of the benefits of a universally shared format might not be as useful here anyways.
TLDR;
I think adding a config that anyone can and maybe even should use is a great idea. This should probably have rules that are discussed in the community just like Gordon proposed.
I think the CI checks should be removed, and the changes to existing code (formatting others apps within this PR) should be removed.

I think adding a config that anyone can and maybe even should use is a great idea

Just FYI Prettier doesn't want configuration files. One is supposed to use the tool with the default configuration as much as possible.

I think adding a config that anyone can and maybe even should use is a great idea

Just FYI Prettier doesn't want configuration files. One is supposed to use the tool with the default configuration as much as possible.

Huh, I've never used prettier without adjusting it. But if we don't need to add a config, so be it, doesn't influence the rest tbh.
Another Idea I just had:
If/When Typescript support is added, we could force the use of prettier there. (Even with CI checks)
Since all TS apps need a Local Dev Environment anyway, adding prettier there is no big deal. Would probably be very easy to run only on .ts files as well. (In the CI)

I left for a bit, and a whole bunch happened.
I'm a bit confused what I should do now - GitHub says there's merge conflicts, Travis won't run, and it sounds like there's some other things I should do?
Should I try to apply these changes more manually, instead of all-at-once?

GitHub says there's merge conflicts, Travis won't run

It's pretty much guaranteed by PRs like this that change over 900 files. Merging this is now a bit of a nightmare, but even if it is merged, it then forces pretty much any contributor or anyone with a fork to have their own merge nightmare too.
The travis build failed because of https://github.com/espruino/BangleApps/pull/1178#issuecomment-1004609724 - @mabuchner the issue here is not that the sanity check is wrong, it's that the sanity check has detected that the icons are now broken. The icons need to not have a semi-colon on the end because the JS file is evaluated as an expression.
@KTibow thanks for doing this - but I just feel that right now this is too much, especially as a first contribution...

this PR changes basically every app in the repo
In many cases the code is actually changed away from what we suggest at http://www.espruino.com/Code+Style
It also refactors all the markdown files away from a format that we use for the rest of Espruino
merging would seriously inconvenience pretty much every contributor by giving them huge merge conflicts on any change they made, and I don't think the improvements here outweigh that
This merge also destroys any commit history so we no longer know who made a specific change in an app file
Given this change breaks the icons in the app loader, I'm a bit concerned this is pretty much untested on real devices? While formatting changes are unlikely to be an issue, it still worries me that 300 apps have been changed and probably very few of those (if any) will have been tested for regressions

I think right now it's best just to close this... While we could have a tool to allow contributors to apply formatting rules to their specific apps, right now all you have to do is hit Ctrl-B in the web IDE to do it automatically, so I wonder if a special tool is that much of a benefit.

this PR changes basically every app in the repo

Commentary:
It's at least supposed to come out with an identical result.
Solution:
Yes, it does modify them, but it depends on your definition of "change".

In many cases the code is actually changed away from what we suggest at http://www.espruino.com/Code+Style

Commentary:
Thanks for that link, I couldn't find it before.
Solution:
I'll address this more further down.

It also refactors all the markdown files away from a format that we use for the rest of Espruino

Commentary:
I originally had it set up as **/*.js, so it was only JS files, but someone convinced me to use ..
Solution:
Anyway, I believe a .prettierignore file could fix this (if we continued to use Prettier).

merging would seriously inconvenience pretty much every contributor by giving them huge merge conflicts on any change they made, and I don't think the improvements here outweigh that

Commentary:
I thought about that too, but any big change will cause that.
Solution:
No idea, but still, I don't think it would be that hard to reformat some code using an automatic tool.

This merge also destroys any commit history so we no longer know who made a specific change in an app file

Commentary:
Well, it's git, so it keeps around all commits, however GitHub only shows you the latest one when you're just viewing a file.
Solution:
I could try to stack the changes onto the previous commits, or try to edit the commits to be based off of a formatted version.

Given this change breaks the icons in the app loader, I'm a bit concerned this is pretty much untested on real devices? While formatting changes are unlikely to be an issue, it still worries me that 300 apps have been changed and probably very few of those (if any) will have been tested for regressions

Commentary:
That's just me being lazy and not uninstalling/reinstalling all my apps.
Solution:
Addressed further down.

I think right now it's best just to close this...

Understandable.

right now all you have to do is hit Ctrl-B in the web IDE to do it automatically

What tool is used for this? If it's made just for Espruino, has anyone bothered porting it to run on multiple files? If you use this on the app icons, will it break them?
(Couldn't find any info from a quick search)

It seems to be js_beautify

I tried it on the codebase, it still modified a ton. Does the web app use some special config? Or should I just drop this all (which I can)?

If you look at the code in the EspruinoWebIDE repo there may be some config, but...

Or should I just drop this all

Sorry, but I think you should drop it, yes.
There are loads of issues with Bangle.js software and your help with those would be hugely appreciated, but really I've haven't heard of anyone that has had any issues with code formatting. At most the formatting is a minor inconvenience to one or two people, and those people probably don't like the default formatting style we use anyway.
But if I merge these changes it's going to cause a lot of inconvenience. There are almost 600 forks, many by users who aren't properly familiar with Git and are even just using the GitHub online editor - for them it'll be a total mess. I really think that right now the small improvement to readability doesn't outweigh the trouble this will cause many of the contributors.

Okay. I'll see if there's anything else interesting that would help.


Creates an example dockergen plist

An example launchd plist file that I use along with corectl to let docker-gen monitor docker and restart dnsmasq.  This is essentially an de-containerized hack of docker-dns-gen and uses the base templates from that utility.
Not sure if this is too involved to make a good example or not.  I figured someone else out there might appreciate it either way.

@buchdag should the template examples just get merged, or is it maybe better to just close them vs have a random assortment of examples here?


[WIP] Convert to pull stream

Current State

[ ] New multiplex implementation using only pull-streams in src/multiplex.js

[ ] Spec compliant

[ ] Do not encode the header with a length prefix
[ ] Check maximum size of data

[ ] finish destroy method
[ ] All tests passing

[ ] Mega stress test, does not run out of memory, but doesn't finish either.
[ ] Close tests

[ ] Split into their own package

[ ]  src/pull-end
[ ] src/pull-split
[ ] src/multiplex

[ ] Cleanup code
[ ] https://github.com/libp2p/interface-stream-muxer/compare/fix/multiplex?expand=1
[ ] Add documentation

Have you tested this with the stress tests? Any luck?

@diasdavid

stress tests from interface-stream-muxer pass except on error case
https://github.com/libp2p/js-libp2p-spdy/issues/48#issuecomment-269137170 is the interesting part

There is an updated branch based on this work but by using multiplex from npm rather than a re-implementation of the core of multiplex here: https://github.com/libp2p/js-libp2p-multiplex/pull/49

pull-wrap branch was merged in 0f3bc8ce0ca9b62a81e425866690f1d9d85a96c2 and exposes a pull-stream interface identical to the one here, but with using multiplex module instead of our implementation.
We'll keep this one open for the future.

@dryajov now that you are attempting #73, make sure to go through the work @dignifiedquire did here


Parameterize ITs to run with concurrent search enabled

Description
Parameterizing first batch of ITs with concurrent search enabled as part of this PR.
List of ITs Parameterized in this PR:
1. IndicesRequestCacheIT
2. IndexStatsIT
3. ScriptCacheIT
4. StressSearchServiceReaperIT
5. DeletePitMultiNodeIT
6. PitMultiNodeIT
7. ScriptQuerySearchIT
8. DuelScrollIT
9. SearchScrollIT
10. SearchScrollWithFailingNodesIT
11. SearchAfterIT
12. GeoDistanceIT
13. GeoDistanceSortBuilderIT
14. SortFromPluginIT
15. CompletionSuggestSearchIT
16. ContextCompletionSuggestSearchIT
17. SuggestSearchIT
18. SimilarityIT

Related Issues
#9443
Check List

[ ] New functionality includes testing.

[ ] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[ ] Commits are signed per the DCO using --signoff
[ ] Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@harishbhakuni thanks for the changes, it would be good to add the classes for which we are adding the parameterization in the pr description.

@harishbhakuni There is a conflict with server/src/internalClusterTest/java/org/opensearch/search/sort/GeoDistanceIT.java, can you please resolve that

below tests are failing in gradle check and are marked flaky (not able to reproduce them in local):
org.opensearch.search.SearchWeightedRoutingIT.testSearchAggregationWithNetworkDisruption_FailOpenEnabled: #5957
org.opensearch.indices.replication.SegmentReplicationSuiteIT.classMethod: #9499
org.opensearch.index.ShardIndexingPressureSettingsIT.testShardIndexingPressureEnforcedEnabledDisabledSetting: #2348


Convert Perl from Docbook to CommonMark

This issue tracks the conversion of /doc/languages-frameworks/perl.xml from Docbook to CommonMark per RFC 72.
If you intend to work on this conversion, please comment below!
Instructions for performing this conversion

Post in this issue that you intend to work on it. (Please also post if you stop working on it)
Checkout a new branch of nixpkgs master.
Edit doc/languages-frameworks/index.xml: change perl.xml to perl.section.xml.
Move doc/languages-frameworks/perl.xml to doc/languages-frameworks/perl.section.md.
Convert the contents from Docbook to CommonMark. Use existing .md sections for inspiration.
Use nix-build from the doc/ folder to build the manual.
Preview the manual on your computer at http://<IP_ADDRESS>:8000/manual.html after running from doc/ folder:

nix-shell -p python3 --run 'python3 -m http.server --directory ./result/share/doc/nixpkgs'

When it looks good, submit a PR and reference this issue.

Done. Works on my machine. Will send PR. Roast me.


Inconsistency for default values in documentation

Description of the bug
It seems that documentation contains inconsistency about ignore-init-method and ignore-nested-classes in configuration section and command line options. Command line options seems to match to default values here (i.e. set on False) while the configuration section indicates that they are set to True by default.
I guess if this error is correct, it is required to modify the README.rst file?
Thanks

Thanks! fixed


fixshould bind expr using no slot to currect tuple

Proposed changes
pick from master https://github.com/apache/doris/pull/28656

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


file db.js is created inside config and promises is handled with mongoose

What is the change?
created a new folder named config and created the file inside it called db.js and put the database connection code inside it.
Related issue?
close: #320
How was it tested?
yes i have tested the code
Checklist:
Before you create this PR, confirm all the requirements listed below by checking the checkboxes [x]:

[x] Have you followed the Contribution Guidelines while contributing.
[x] Have you checked there aren't other open Pull Requests for the same update/change?
[x] Have you made corresponding changes to the documentation?
[x] Your submission doesn't break any existing feature.
[x] Have you tested the code before submission?

Screenshots or Video:
Add a screenshot or demo video if appropriate.

why did the check failed ??

/reviewed

i did npm install to generate node_modules and it changes package-lock

i did npm install to generate node_modules and it changes package-lock

Ok, I'll check it then. Can you change base branch to develop so that I can merge ?


Handle invalid option tag with name only

We have some of these in our codebase:
@option :foo

Handle them gracefully, even though they are invalid.
These were causing errors in VSCode, via Solargraph:
[WARN] Error processing request: [NoMethodError] undefined method `length' for nil:NilClass
[WARN] /Users/Evan.Goldenberg/.asdf/installs/ruby/2.7.3/lib/ruby/gems/2.7.0/gems/yard-0.9.28/lib/yard/tags/default_factory.rb:148:in `extract_types_and_name_from_text_unstripped'
/Users/Evan.Goldenberg/.asdf/installs/ruby/2.7.3/lib/ruby/gems/2.7.0/gems/yard-0.9.28/lib/yard/tags/default_factory.rb:132:in `extract_types_and_name_from_text'
/Users/Evan.Goldenberg/.asdf/installs/ruby/2.7.3/lib/ruby/gems/2.7.0/gems/yard-0.9.28/lib/yard/tags/default_factory.rb:79:in `parse_tag_with_types_name_and_default'
/Users/Evan.Goldenberg/.asdf/installs/ruby/2.7.3/lib/ruby/gems/2.7.0/gems/yard-0.9.28/lib/yard/tags/default_factory.rb:93:in `parse_tag_with_options'
/Users/Evan.Goldenberg/.asdf/installs/ruby/2.7.3/lib/ruby/gems/2.7.0/gems/yard-0.9.28/lib/yard/tags/library.rb:237:in `send_to_factory'
/Users/Evan.Goldenberg/.asdf/installs/ruby/2.7.3/lib/ruby/gems/2.7.0/gems/yard-0.9.28/lib/yard/tags/library.rb:169:in `option_tag'
/Users/Evan.Goldenberg/.asdf/installs/ruby/2.7.3/lib/ruby/gems/2.7.0/gems/yard-0.9.28/lib/yard/tags/library.rb:274:in `tag_create'
/Users/Evan.Goldenberg/.asdf/installs/ruby/2.7.3/lib/ruby/gems/2.7.0/gems/yard-0.9.28/lib/yard/docstring_parser.rb:215:in `create_tag'
/Users/Evan.Goldenberg/.asdf/installs/ruby/2.7.3/lib/ruby/gems/2.7.0/gems/yard-0.9.28/lib/yard/docstring_parser.rb:156:in `block in parse_content'
/Users/Evan.Goldenberg/.asdf/installs/ruby/2.7.3/lib/ruby/gems/2.7.0/gems/yard-0.9.28/lib/yard/docstring_parser.rb:142:in `each'
/Users/Evan.Goldenberg/.asdf/installs/ruby/2.7.3/lib/ruby/gems/2.7.0/gems/yard-0.9.28/lib/yard/docstring_parser.rb:142:in `each_with_index'
/Users/Evan.Goldenberg/.asdf/installs/ruby/2.7.3/lib/ruby/gems/2.7.0/gems/yard-0.9.28/lib/yard/docstring_parser.rb:142:in `parse_content'
/Users/Evan.Goldenberg/.asdf/installs/ruby/2.7.3/lib/ruby/gems/2.7.0/gems/yard-0.9.28/lib/yard/docstring_parser.rb:117:in `parse'
/Users/Evan.Goldenberg/.asdf/installs/ruby/2.7.3/lib/ruby/gems/2.7.0/gems/solargraph-0.48.0/lib/solargraph/source.rb:518:in `parse_docstring'
/Users/Evan.Goldenberg/.asdf/installs/ruby/2.7.3/lib/ruby/gems/2.7.0/gems/solargraph-0.48.0/lib/solargraph/pin/base.rb:246:in `parse_comments'
/Users/Evan.Goldenberg/.asdf/installs/ruby/2.7.3/lib/ruby/gems/2.7.0/gems/solargraph-0.48.0/lib/solargraph/pin/base.rb:99:in `docstring'
/Users/Evan.Goldenberg/.asdf/installs/ruby/2.7.3/lib/ruby/gems/2.7.0/gems/solargraph-0.48.0/lib/solargraph/pin/base.rb:129:in `deprecated?'
/Users/Evan.Goldenberg/.asdf/installs/ruby/2.7.3/lib/ruby/gems/2.7.0/gems/solargraph-0.48.0/lib/solargraph/language_server/message/workspace/workspace_symbol.rb:18:in `block in process'
/Users/Evan.Goldenberg/.asdf/installs/ruby/2.7.3/lib/ruby/gems/2.7.0/gems/solargraph-0.48.0/lib/solargraph/language_server/message/workspace/workspace_symbol.rb:8:in `map'
/Users/Evan.Goldenberg/.asdf/installs/ruby/2.7.3/lib/ruby/gems/2.7.0/gems/solargraph-0.48.0/lib/solargraph/language_server/message/workspace/workspace_symbol.rb:8:in `process'
/Users/Evan.Goldenberg/.asdf/installs/ruby/2.7.3/lib/ruby/gems/2.7.0/gems/solargraph-0.48.0/lib/solargraph/language_server/host.rb:112:in `receive'
/Users/Evan.Goldenberg/.asdf/installs/ruby/2.7.3/lib/ruby/gems/2.7.0/gems/solargraph-0.48.0/lib/solargraph/language_server/host/message_worker.rb:53:in `tick'
/Users/Evan.Goldenberg/.asdf/installs/ruby/2.7.3/lib/ruby/gems/2.7.0/gems/solargraph-0.48.0/lib/solargraph/language_server/host/message_worker.rb:44:in `block in start'

Completed Tasks

[x] I have read the Contributing Guide.
[x] The pull request is complete (implemented / written).
[x] Git commits have been cleaned up (squash WIP / revert commits).
[x] I wrote tests and ran bundle exec rake locally (if code is attached to PR).

I think "gracefully" would require at least a warning for the invalid tags.


fix(chore): added if condition for createall db call

Breaking Change
if the array is not passed error will be thrown
gh-1124
Description
Added the if condition to check the entity length before calling the repo.createAll call
to avoid error.
Fixes #1124
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Intermediate change (work in progress)

Checklist:

[ ] Performed a self-review of my own code
[ ] npm test passes on your machine
[ ] New tests added or existing tests modified to cover all changes
[ ] Code conforms with the style guide
[ ] API Documentation in code was updated
[ ] Any dependent changes have been merged and published in downstream modules

This will be released when there is a breaking change

Raised another PR with same changes to avoid merge conflicts - https://github.com/sourcefuse/loopback4-microservice-catalog/pull/1881


NameError: name 'note_rows' is not defined

Traceback (most recent call last):
File "/home/red/workflowy2markdown/workflowyconvert/wf2md.py", line 37, in
note_df = pd.DataFrame(note_rows, columns=['Tags', 'Title', 'Level', 'Text'])
NameError: name 'note_rows' is not defined. Did you mean: 'note_dfs'?

Can you tell me a bit about how you got this error, how I can reproduce it?


shouldChangeTextInRange:(NSRange) Delegate?

Is there a way to implement a delegate similar to UITextView's

(BOOL)textView:(UITextView *)textView shouldChangeTextInRange:(NSRange)range replacementText:(NSString *)text

Using for autocorrect manipulation

This is something I wanted to add from the beginning. I don't think there is a good way to do it, unfortunately. The reason being that the JS callback doesn't get called until the text is already added in. Sorry!
If you come up with something that works well, I'd like to know, so feel free to open a pull request if you do.


ThePBone.GalaxyBudsClient version 4.2

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?

[x] Does your manifest conform to the 1.0 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

Someone has already submitted pr for this application. #15955


dead links

Error
URL
Anchor Text
Linked From

-1 Not found: The host name in the certificate is invalid or does not match
https://www.vidhyalayam.online/
വിദ്യാലയം.online is under Apache 2.0 License
https://vidhyalayam.online/

999 Non-standard
https://www.linkedin.com/company/67515803/

https://vidhyalayam.online/

fized


Cluster agent controllers should only run once

Related issue: https://github.com/rancher/rancher/issues/17148

Note to other reviewers: this should not be merged until @dramich lgtms

Updated

Hi @dramich
Could you look at this PR again, please?

LGTM

LGTM

@orangedeng I didnt catch it until after I merged, but as previously discussed, you need a better commit message next time.


Supports “SGCaps” Feature

The AZERTY-NF layout also includes the "SGCaps" feature. Used originally for the Swiss-German layout, this feature changes the behaviour of the Caps Lock key.
Traditionnaly, Caps Lock acts like maintaining the Shift key. This means that in a traditionnal AZERTY layout, enabling Caps Lock and typing é produces the number 1.
The AZERTY-NF layout allows you to type the corresponding accented characters when Caps Lock is toggled on.
Thus, enabling Caps Lock and typing à, é, ê, è, ^, i, ^, o, ù produces ÀÉÊÈÎÔÙ.
More realistically, enabling Caps Lock and typing c, ', e, s, t, Space, à, Space, d, i, r, e produces C'EST À DIRE. Notice that neither the apostrophe (') nor the accented character (à) did require extra precautions. This would not be normally feasible on a traditional AZERTY layout.

For reference, I was thinking that it's was primary a difference between windows and macos/linux:

on windows, the shift key operates exactly like if the shift key is pressed.
on macos/linux, the caps lock only uppercase letters, and the shift key must still be used for other keys

I did not know that MSKLC allow the SGCaps modifier. Will be happy to test it.


New ignore platform feature of discovery component not working

Home Assistant release (hass --version):
0.39.0
Python release (python3 --version):
Python 3.5.2
Component/platform:
discovery
Description of problem:
Trying to ignore the netgear platform from the discovery component and receiving the following error in the home-assistant.log:
17-02-26 15:38:32 ERROR (MainThread) [homeassistant.bootstrap] Invalid config for [discovery]: value is not allowed @ data['discovery']['ignore'][0].
 Got 'netgear'. (See /home/hass/.homeassistant/configuration.yaml, line 100). Please check the docs at https://home-assistant.io/components/discovery

Expected:
Platform to be ignored by discovery and no errors output in home-assistant.log.
Problem-relevant configuration.yaml entries and steps to reproduce:
discovery:
  ignore:
    - netgear

Traceback (if applicable):
N/A

Additional info:
I believe the ignore functionality is actually working, but there may be a conflict with the new configuration checking code? When I ignore the netgear platform I resolve (or rather, workaround) another bug referenced in #4318

@postlund any ideas?

I'm not sure why exactly, but there is some name mapping going on that makes using ignore for the discovery component not so straight forward.  From the code, the list looks like this:
SERVICE_NETGEAR = 'netgear_router'
SERVICE_WEMO = 'belkin_wemo'
SERVICE_HASS_IOS_APP = 'hass_ios'

SERVICE_HANDLERS = {
    SERVICE_HASS_IOS_APP: ('ios', None),
    SERVICE_NETGEAR: ('device_tracker', None),
    SERVICE_WEMO: ('wemo', None),
    'philips_hue': ('light', 'hue'),
    'google_cast': ('media_player', 'cast'),
    'panasonic_viera': ('media_player', 'panasonic_viera'),
    'plex_mediaserver': ('media_player', 'plex'),
    'roku': ('media_player', 'roku'),
    'sonos': ('media_player', 'sonos'),
    'yamaha': ('media_player', 'yamaha'),
    'logitech_mediaserver': ('media_player', 'squeezebox'),
    'directv': ('media_player', 'directv'),
    'denonavr': ('media_player', 'denonavr'),
    'samsung_tv': ('media_player', 'samsungtv'),
    'yeelight': ('light', 'yeelight'),
    'flux_led': ('light', 'flux_led'),
    'apple_tv': ('media_player', 'apple_tv'),
    'openhome': ('media_player', 'openhome'),
}

So try using netgear_router instead of just netgear.

Yes, config is validated against supported platforms. So it must be platforms listed in SERVICE_HANDLERS as mentioned above.

Changing it to the 'netgear_router' platform name did the trick. Should the discovery component documentation be updated to include that list of viable platforms? Or does the netgear platform/service handler name scheme need to be brought in sync?


Feature request: Configure watermark plugin to override regex'es for each of the props

Currently bitten by restraint to not use comma char in watermark text. So, would be great if we could add our custom regex'es overriding the default ones as specified in Processing.config.
I'm not sure if that's the best place to put those custom regex'es.
Feedback appriciated!

To be honest I think we would be better off reworking the plugin to be less restrictive than add more complexity through regular expressions.
I plan, one day to switch the whole thing to use a more Json style parsing method. This should remove most of the parsing complexity within the application.

Just to update. I'm replacing the parser in the next release with a much improved one. This will allow a watermark to be made from any url encoded string value.

Fixed in v4.3.0


[build] fix pip install issues on OSX High Sierra

I think requirements.txt was out-of-sync as well.
Also had to, not sure if necessary though:
export LDFLAGS="-L/usr/local/opt/openssl/lib"
export CPPFLAGS="-I/usr/local/opt/openssl/include"
export PKG_CONFIG_PATH="/usr/local/opt/openssl/lib/pkgconfig"

Codecov Report

Merging #6201 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #6201   +/-   ##
=======================================
  Coverage   76.91%   76.91%
=======================================
  Files          47       47
  Lines        9393     9393
=======================================
  Hits         7225     7225
  Misses       2168     2168

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9580103...550c019. Read the comment docs.

+1


Implement planning update from RFC

This brings over content from https://docs.google.com/document/d/1Yjn54T6rpd99vkUcGx-M_nMraxX0Xlp73zfMe-mCYQ8/edit# with some readability improvements and reorganizing of content to make the whole thing more approachable.
Because of the structural changes to the content, the easiest way to review is via the review app: https://deploy-preview-2681--sourcegraph-handbook.netlify.app/departments/product-engineering/process/planning-process/

Closing to avoid confusion


【statistics】The custom statistics are inconsistent with the actual data after the data is deleted. Procedure

Steps to reproduce the behavior (Required)

CREATE TABLE '...'

CREATE TABLE `duplicate_table_with_null` ( `k1`  date, `k2`  datetime, `k3`  char(20), `k4`  varchar(20), `k5`  boolean, `k6`  tinyint, `k7`  smallint, `k8`  int, `k9`  bigint, `k10` largeint, `k11` float, `k12` double, `k13` decimal(27,9) ) ENGINE=OLAP DUPLICATE KEY(`k1`, `k2`, `k3`, `k4`, `k5`) COMMENT "OLAP" DISTRIBUTED BY HASH(`k1`, `k2`, `k3`) BUCKETS 3 PROPERTIES ( "replication_num" = "3", "storage_format" = "v2" );

INSERT INTO '....'

curl --location-trusted -u root: -T /home/disk4/lvchenyang/code/StarRocksTest/lib/../common/data/basic_types_data -XPUT -H label:stream_load_1660048352044 http://ip:port/api/test_manual_full_statistics56d461a6_17df_11ed_a911_00163e0e550b/duplicate_table_with_null/_stream_load

show analyze  '....'

CREATE ANALYZE TABLE duplicate_table_with_null(k1,k10,k11,k12,k13,k2,k3,k4,k5,k6,k7,k8,k9) PROPERTIES('statistic_auto_collect_ratio'='0.8');
SHOW ANALYZE JOB where `Database` = 'test_manual_full_statistics56d461a6_17df_11ed_a911_00163e0e550b';

4
select db_id, table_id, column_name,sum(row_count), cast(avg(data_size) as bigint), min, max,hll_union_agg(ndv), sum(null_count),partition_name from _statistics_.column_statistics where table_name='test_manual_full_statistics56d461a6_17df_11ed_a911_00163e0e550b.duplicate_table_with_null' group by db_id, table_id, column_name,min,max,partition_name order by column_name,partition_name;
drop analyze id;

5 insert
insert into duplicate_table_with_null values ('2020-08-31','2020-08-31 18:12:15','shanxi','xian','0',117,32737,-2147418223,-9223372036854220273,-18446744073709434081,6520.4,652.91,62.334);
CREATE ANALYZE TABLE duplicate_table_with_null(k1,k10,k11,k12,k13,k2,k3,k4,k5,k6,k7,k8,k9) PROPERTIES('statistic_auto_collect_ratio'='0.8');
SHOW ANALYZE JOB where `Database` = 'test_manual_full_statistics56d461a6_17df_11ed_a911_00163e0e550b';
select db_id, table_id, column_name,sum(row_count), cast(avg(data_size) as bigint), min, max,hll_union_agg(ndv), sum(null_count),partition_name from _statistics_.column_statistics where table_name='test_manual_full_statistics56d461a6_17df_11ed_a911_00163e0e550b.duplicate_table_with_null' group by db_id, table_id, column_name,min,max,partition_name order by column_name,partition_name;
drop analyze id;

6
delete from duplicate_table_with_null where k1='2020-08-31' and k2='2020-08-31 18:12:15' and k3='shanxi' and k4='xian' and k5=False;
CREATE ANALYZE TABLE duplicate_table_with_null(k1,k10,k11,k12,k13,k2,k3,k4,k5,k6,k7,k8,k9) PROPERTIES('statistic_auto_collect_ratio'='0.8');
SHOW ANALYZE JOB where `Database` = 'test_manual_full_statistics56d461a6_17df_11ed_a911_00163e0e550b';
select db_id, table_id, column_name,sum(row_count), cast(avg(data_size) as bigint), min, max,hll_union_agg(ndv), sum(null_count),partition_name from _statistics_.column_statistics where table_name='test_manual_full_statisticse8722b50_17e1_11ed_bb45_00163e0e550b.duplicate_table_with_null' group by db_id, table_id, column_name,min,max,partition_name order by column_name,partition_name;

Expected behavior (Required)
max data
['2020-08-25', '-18446744073709486081', '6550.4', '652.21', '62.394000000', '2020-08-25 18:12:15', 'shenzhen', 'xuhui', '1', '127', '32767', '-2147418113', '-9223372036854710273']
Real behavior (Required)
max data
['2020-08-31', '-18446744073709434081', '6550.4', '652.91', '62.394000000', '2020-08-31 18:12:15', 'shenzhen', 'xuhui', '1', '127', '32767', '-2147418113', '-9223372036854220273']
StarRocks version (Required)

You can get the StarRocks version by executing SQL select current_version()

+----------------------+
| current_version()    |
+----------------------+
| MAIN-RELEASE 2b4fbe5 |
+----------------------+

The automatic collection of statistics does not consider delete, and currently it is impossible to perceive the effect of delete on the number of rows.


Add Warning about failures due to minAPIVersion

A common cause for customer's opening support cases is if they set minAPIVersion property of API Management to a very recent version, newer than what we tell az mon to use to connect to us when creating a diagnostic settings object. This results in a failure and the error message is not very descriptive. Az Mon team has indicated they can't change the error message reported back to users, hence the doc update is being submitted.

I've committed the editorial change and resolved a merge conflict. @dlepow - If this PR is ready for merge, could you sign off?

#sign-off


#1529 Fix: collections social card display image

Thank you for your contribution to the KodaDot NFT gallery.
👇  _ Do a quick check before the merge.
PR type

[x] Bugfix
[ ] Feature
[x] Refactoring

Before submitting Pull Request, please make sure:

[x] My contribution builds clean without any errors or warnings
[x] I've merged recent default branch -- main and I've no conflicts
[x] I've tried respect high code quality standards
[x] I've didn't break any original functionality
[ ] I've posted screenshot of demonstrated change in this PR

Optional

[ ] I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
[ ] I've tested PR on mobile and everything works
[ ] I found edge cases

What's new?

[x] PR closes #<issue_number>
[ ] <brief_description_of_what_I've_added>

Had issue bounty label?

[ ] Fill up your KSM address: Payout

Community participation

[x] Are you at KodaDot Discord?

Screenshot

[ ] My fix has changed something on UI, a screenshot for others, is best to understand changes.

hey, please fill up PR template so we know more context and don't forget add you KSM address! :)

here is deploy preview url https://deploy-preview-1671--koda-nuxt.netlify.app/

for some bad ass reason netlify did not post it :D

using https://cards-dev.twitter.com/validator

@yangwao can you approve the deploy again? It's pending, thanks.

yeah I see, you must be special! haven't approving for one pr more than once, now three times lol

@yangwao sadly this fix cannot be tested locally, as it's something that breaks only on deploy :(

yeah no worries, we have some spare build  minutes! :D

done in https://github.com/kodadot/nft-gallery/pull/1676


rename network controller properties state property

This PR renames properties network controller state property to networkDetails.
Related issue #1019

Marking this as DO-NOT-MERGE until we get the base PR merged

Base PR now merged; this should be ready to review once rebased onto main

PR has been rebased onto main

@cryptodev-2s FYI if you use the "Update branch" button on GitHub, it will preserve any PR approvals. Rebasing manually requires re-approving.


compilation fail with foundation 6.4.1 and breadcrumbs or off-canvas components

More precisely scssphp crash with this code :
foundation-sites/scss/components/_breadcrumbs.scss, line 52 :
$breadcrumbs-item-separator-item-rtl: '\' !default;
foundation-sites/scss/components/_off-canvas.scss, line 341 :
@at-root .#{$content}.has-reveal-#{$position} {
margin-#{$position}: $offcanvas-size;
}
Comment out these lines makes it possible to compile the project with scssphp.

6.4.3 fails too!
parse error: failed at $breadcrumbs-item-separator-item-rtl: '\\' !default;

Also reported in #446

should be solved now, to be confirmed

Foundation 6.4.3 & 6.4.1 are now compiling without any modification.
This can be closed @robocoder


error: "Can't open dynamic library: cef_artifacts/libgdcef.dll" when execute a build for windows platform

OS: windows 11
Godot version: 4.2.1
Description: gdcef extension works fine on godot editor, but when I try to export for windows, an execute the build, I get this error stack
ERROR: Can't open dynamic library: cef_artifacts/libgdcef.dll. Error: Error 126: The specified module could not be found..
   at: (platform/windows/os_windows.cpp:394)
ERROR: GDExtension dynamic library not found: cef_artifacts/libgdcef.dll
   at: open_library (core/extension/gdextension.cpp:719)
ERROR: Failed loading resource: res://libs/gdcef.gdextension. Make sure resources have been imported by opening the project in the editor at least once.
   at: (core/io/resource_loader.cpp:274)
ERROR: Error loading extension: res://libs/gdcef.gdextension
   at: (core/extension/gdextension_manager.cpp:234)

this is how looks in editor, vs windows build

this is how looks the windows build folder: (I added "cef_artifacts" folder manually)

@AaronClaros it seems the .gdextension file is missing. It's present in demos/xx/libs.

Reopen the ticket if needed

@Lecrapouille
Hello, I have the same problem. Browser runs fine in Godot Editor. But it doesn't work when I export it to Windows.
Build files:
$ ls -lr .
total 68024
-rwxr-xr-x 1 Pastew 197121   593920 Jun 10 00:37  libgdcef.dll*
-rw-r--r-- 1 Pastew 197121    68352 Jun 10 00:37 'CEF in 3D.pck'
-rwxr-xr-x 1 Pastew<PHONE_NUMBER>0384 Jun 10 00:37 'CEF in 3D.exe'*
-rwxr-xr-x 1 Pastew 197121   109056 Jun 10 00:37 'CEF in 3D.console.exe'*

If I copy cef_artifacts to build folder it doesn't help.
Output from debug console:
ERROR: Can't open dynamic library: cef_artifacts/libgdcef.dll. Missing dependencies: libcef.dll. Error: Error 126: The specified module could not be found..
   at: (platform/windows/os_windows.cpp:392)
ERROR: GDExtension dynamic library not found: cef_artifacts/libgdcef.dll
   at: open_library (core/extension/gdextension.cpp:719)
ERROR: Failed loading resource: res://cef_artifacts/gdcef.gdextension. Make sure resources have been imported by opening the project in the editor at least once.
   at: (core/io/resource_loader.cpp:274)
ERROR: Error loading extension: res://cef_artifacts/gdcef.gdextension
   at: (core/extension/gdextension_manager.cpp:234)
Godot Engine v4.2.2.stable.official.15073afe3 - https://godotengine.org
OpenGL API 3.3.0 NVIDIA 546.33 - Compatibility - Using Device: NVIDIA - NVIDIA GeForce RTX 3060

ERROR: Viewport Texture must be set to use it.
   at: get_height (scene/main/viewport.cpp:137)
ERROR: Viewport Texture must be set to use it.
   at: get_width (scene/main/viewport.cpp:127)
WARNING: Glow is not supported when using the GL Compatibility backend yet. Support will be added in a future release.
     at: environment_set_glow (servers/rendering/storage/environment_storage.cpp:387)
ERROR: Cannot get class 'GDCef'.
   at: (core/object/class_db.cpp:358)
WARNING: Node CEF of type GDCef cannot be created. A placeholder will be created instead.
     at: instantiate (scene/resources/packed_scene.cpp:254)
SCRIPT ERROR: Invalid call. Nonexistent function 'initialize' in base 'Control'.
          at: _ready (res://GUI.gd:151)

I don't see libs directory you mentioned in this issue inside 3D or 2D demos in this version 0.10.0

Libs no longer exist with 0.10.0. Remove it. I will ask testing for export since I do not have windows

@Pastew effectively, Godot does not copy the cef_artfacts folder. From memory, Godot3 did it correctly. Maybe opening a bug on Godot team. You can copy it manually. Other point, there is a small issue on my side. In godot script "exported_artifacts" that can be set with CEF.initialize( is by default equal to the folder path holding with your binary instead of path to cef_artifacts, therefore forcing either to set it each time or to remove the folder cef_artifcats. Ok I'll fix it but also manage absolute pathes. Thnak you!

Sorry, I had no time for testing my last commit fixing. @Pastew if you want to check.

Sure, I will test it when a new tag appears (but not earlier than June 22nd).
For now - I just moved cef_artifacts content to .exe's directory and it works.

Same problem here, and also caught something weird and a weird solution to the problem.
This solution isn't ideal because it's really messy and wastes more disk space, but adding the cef_artifacts content on to the root of exported build directory and adding the cef_artifacts folder with the same content works. Yes you really need to duplicate for it to work.
However, while I was debugging the error using Process Monitor in order to see what paths it was using, I saw that it's able to find the libgdcef.dll file just fine inside my cef/ folder, but for everything such as the libcef.dll, it's unable to find it and goes through most of the Windows filesystem.

ok @pimhakkert we have to investigate

@AaronClaros @Pastew @c0if I've installed a Windows. After investigation, for the moment dll SHALL be on either on the c:/windows/system32 folder or on the same folder as the exe. BUT since I'm also checking their presence inside the cef_artifacts they SHALL be duplicated. Why is this working well inside Godot, I'm still investigating !! @eliopark-nsuslab any ideas ? I also noticed that C++17 std::filesystem is also broken on Windows (log are not created on the desired folder). This is fixed by using C++20.

Almost fixed when switching to C++20 (v 0.14.1) The dll are now loaded but the cefinitialize() now return an error. I have not yet understand why

All I can do is another commit fixing missing path to locales to pak files (not present in 0.14.1). CEF (at least for Windows have hardcoded pathes). The mimimum files on the same level of the exe is the following:

Beware: when exporting the .dll created by Godot is useful: you can remove BUT you need libcef.dll, .pak files, iuctl.data and probably *.bin

Hello, I downloaded 0.14.1.
I can confirm now Windows build runs.
However browser doesn't open, I have this error msg:
USER ERROR: Cannot get class 'GDCef'.
   at: _instantiate_internal (core/object/class_db.cpp:515)
USER WARNING: Node CEF of type GDCef cannot be created. A placeholder will be created instead.
   at: instantiate (scene/resources/packed_scene.cpp:277)
USER SCRIPT ERROR: Invalid call. Nonexistent function 'initialize' in base 'Control'.
   at: _ready (res://web_browser/GUI.gd:158)

I understand this commit should fix it and it will be available in next release?
Thanks!

You should give me more details.  Or launching from the editor?

And yes I have to tag 0.15.0 have you compiled the HEAD ?

In Godot Editor it worked fine before and after 0.14.1.
In exported exe it didn't work before 0.14.1 and it works ein 0.14.1.
I only use builds with tags, I don't compile your project. I used v0.14.1-godot4

I will re-test once new tag will be available and let you know.

@Pastew I released 0.15.0 can you give me logs displayed when running the console version of your application

Thank you @Lecrapouille !

I downloaded v0.15.0-godot4 for Windows.
(It still works fine in Godot Editor)
I exported .exe. Exported directory looks like this, note there is libgdcef.dll in game's root directory:

$ ls -l
total 713224
-rwxr-xr-x 1 Pastew 197121    185856 Dec 14 19:59 Game.console.exe*
-rwxr-xr-x 1 Pastew 197121  84108800 Dec 14 19:59 Game.exe*
-rw-r--r-- 1 Pastew<PHONE_NUMBER>78752 Dec 14 19:59 Game.pck
-rwxr-xr-x 1 Pastew 197121    687104 Dec 14 19:59 libgdcef.dll*
-rwxr-xr-x 1 Pastew 197121   1678848 Dec 14 19:59 libgodotopenxrkhronos.windows.template_debug.x86_64.dll*
-rwxr-xr-x 1 Pastew 197121   1673216 Dec 14 19:59 libgodotopenxrlynx.windows.template_debug.x86_64.dll*
-rwxr-xr-x 1 Pastew 197121   1841664 Dec 14 19:59 libgodotopenxrmeta.windows.template_debug.x86_64.dll*
-rwxr-xr-x 1 Pastew 197121   1673216 Dec 14 19:59 libgodotopenxrpico.windows.template_debug.x86_64.dll*

It doesn't work.
I deleted libgdcef.dll and I copied whole cef_artifacts directory to my game's directory. It doesn't work. Error msg:

PS C:\build\MyGame> .\MyGame.console.exe
ERROR: Can't open dynamic library: cef_artifacts/libgdcef.dll. Error: Error 126: The specified module could not be found..
   at: (platform/windows/os_windows.cpp:449)
ERROR: Can't open GDExtension dynamic library: cef_artifacts/libgdcef.dll
   at: (core/extension/gdextension.cpp:802)
ERROR: Failed loading resource: res://cef_artifacts/gdcef.gdextension. Make sure resources have been imported by opening the project in the editor at least once.
   at: (core/io/resource_loader.cpp:283)
ERROR: Error loading extension: res://cef_artifacts/gdcef.gdextension
   at: (core/extension/gdextension_manager.cpp:234)
Godot Engine v4.3.stable.official.77dcf97d8 - https://godotengine.org

After some trial and error, I figured out that I need to keep the cef_artifacts directory and copy its files to the game's root directory to make it work

chrome_elf.dll*
icudtl.dat
libcef.dll*

So, this is how my game's dir looks like:

$ ls -l
total 946016
-rwxr-xr-x 1 Pastew 197121    185856 Dec 14 19:59 Game.console.exe*
-rwxr-xr-x 1 Pastew 197121  84108800 Dec 14 19:59 Game.exe*
-rw-r--r-- 1 Pastew<PHONE_NUMBER>78752 Dec 14 19:59 Game.pck
drwxr-xr-x 1 Pastew 197121         0 Dec 14 20:07 cef_artifacts/
-rwxr-xr-x 1 Pastew 197121   1447936 Dec 13 23:16 chrome_elf.dll*
-rw-r--r-- 1 Pastew 197121  10464176 Dec 13 23:16 icudtl.dat
-rwxr-xr-x 1 Pastew<PHONE_NUMBER>55552 Dec 13 23:16 libcef.dll*
-rwxr-xr-x 1 Pastew 197121    687104 Dec 14 19:59 libgdcef.dll*
-rwxr-xr-x 1 Pastew 197121   1678848 Dec 14 19:59 libgodotopenxrkhronos.windows.template_debug.x86_64.dll*
-rwxr-xr-x 1 Pastew 197121   1673216 Dec 14 19:59 libgodotopenxrlynx.windows.template_debug.x86_64.dll*
-rwxr-xr-x 1 Pastew 197121   1841664 Dec 14 19:59 libgodotopenxrmeta.windows.template_debug.x86_64.dll*
-rwxr-xr-x 1 Pastew 197121   1673216 Dec 14 19:59 libgodotopenxrpico.windows.template_debug.x86_64.dll*

T'es dll iucdata pak shall be duplicated. I do not understand why


Proper handling of left-padded inputs

At least for some models including Codegen, I'm observing very inconsistent outputs using ORTModelForCausalLM when the same inputs have different amounts of left padding (but correct corresponding attention mask). In other words an equivalent problem to the one with vanilla transformers reported in https://github.com/huggingface/transformers/issues/21080 and with fixes in https://github.com/huggingface/transformers/pull/21853 and https://github.com/huggingface/transformers/pull/22069.
This comment alludes to something w.r.t. handling of position_ids which I was wondering might be related.

Thank you for the report, will have a look shortly!


fix 'location is not defined' error

I receive the error ReferenceError: location is not defined when running Mocha tests via Gulp. I'm using jsdom to mock the document and window, which is resulting in the global location being undefined unless I explicitly do global.location = '{}; (or utilize this fix).

When does this fail? Doesn't it by default get window.location?

@dasilvacontin edited to explain when I get the error!

@jakemmarsh This looks fine to me; please rebase though.

I hope it doesn't break with people that decided to go with the explicitly do global.location = '{}'; route.

Maybe (window.location || location) just to be sure.

Closing in favor of #1654


[Hardware][intel GPU] add async output process for xpu

FILL IN THE PR DESCRIPTION HERE
async output process is only supported on cuda and hpu, this pr add xpu support.
I observed about 10% perf gain with this patch.
BEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESCRIPTION ABOVE

 PR Checklist (Click to Expand)
Thank you for your contribution to vLLM! Before submitting the pull request, please ensure the PR meets the following criteria. This helps vLLM maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Only specific types of PRs will be reviewed. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:

[Bugfix] for bug fixes.
[CI/Build] for build or continuous integration improvements.
[Doc] for documentation fixes and improvements.
[Model] for adding a new model or improving an existing model. Model name should appear in the title.
[Frontend] For changes on the vLLM frontend (e.g., OpenAI API server, LLM class, etc.)
[Kernel] for changes affecting CUDA kernels or other compute kernels.
[Core] for changes in the core vLLM logic (e.g., LLMEngine, AsyncLLMEngine, Scheduler, etc.)
[Hardware][Vendor] for hardware-specific changes. Vendor name should appear in the prefix (e.g., [Hardware][AMD]).
[Misc] for PRs that do not fit the above categories. Please use this sparingly.

Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:

We adhere to Google Python style guide and Google C++ style guide.
Pass all linter checks. Please use format.sh to format your code.
The code need to be well-documented to ensure future contributors can easily understand the code.
Include sufficient tests to ensure the project to stay correct and robust. This includes both unit tests and integration tests.
Please add documentation to docs/source/ if the PR modifies the user-facing behaviors of vLLM. It helps vLLM user understand and utilize the new features or changes.

Adding or changing kernels
Each custom kernel needs a schema and one or more implementations to be registered with PyTorch.

Make sure custom ops are registered following PyTorch guidelines: Custom C++ and CUDA Operators and The Custom Operators Manual
Custom operations that return Tensors require meta-functions. Meta-functions should be implemented and registered in python so that dynamic dims can be handled automatically. See above documents for a description of meta-functions.
Use torch.libary.opcheck() to test the function registration and meta-function for any registered ops.  See tests/kernels for examples.
When changing the C++ signature of an existing op, the schema must be updated to reflect the changes.
If a new custom type is needed, see the following document: Custom Class Support in PT2.

Notes for Large Changes
Please keep the changes as concise as possible. For major architectural changes (>500 LOC excluding kernel/data/config/test), we would expect a GitHub issue (RFC) discussing the technical design and justification. Otherwise, we will tag it with rfc-required and might not go through the PR.
What to Expect for the Reviews
The goal of the vLLM team is to be a transparent reviewing machine. We would like to make the review process transparent and efficient and make sure no contributor feel confused or frustrated. However, the vLLM team is small, so we need to prioritize some PRs over others. Here is what you can expect from the review process:

 After the PR is submitted, the PR will be assigned to a reviewer. Every reviewer will pick up the PRs based on their expertise and availability.
 After the PR is assigned, the reviewer will provide status update every 2-3 days. If the PR is not reviewed within 7 days, please feel free to ping the reviewer or the vLLM team.
 After the review, the reviewer will put an  action-required label on the PR if there are changes required. The contributor should address the comments and ping the reviewer to re-review the PR.
 Please respond to all comments within a reasonable time frame. If a comment isn't clear or you disagree with a suggestion, feel free to ask for clarification or discuss the suggestion.

Thank You
 Finally, thank you for taking the time to read these guidelines and for your interest in contributing to vLLM. Your contributions make vLLM a great tool for everyone!

This seems reasonable to me, are there any XPU test resources in the CI that could validate this?

Currently, CI resources for xpu is limited, so we just run a simple offline_inference.py to check build & functionality.
cc @zhouyuan

/ready

@mogin any more comments?


Added support for alias to Bracket term

Fixes #217

Coverage increased (+0.06%) to 98.292% when pulling 58b0eaf8e1fd96e77e9bf762cbfdd052e216e51f on mikeengland:master into 431e5beaba0990767551c100a78b09e49bb9dc47 on kayak:master.

Coverage increased (+0.06%) to 98.292% when pulling 58b0eaf8e1fd96e77e9bf762cbfdd052e216e51f on mikeengland:master into 431e5beaba0990767551c100a78b09e49bb9dc47 on kayak:master.

Coverage increased (+0.06%) to 98.292% when pulling 58b0eaf8e1fd96e77e9bf762cbfdd052e216e51f on mikeengland:master into 431e5beaba0990767551c100a78b09e49bb9dc47 on kayak:master.

Coverage increased (+0.06%) to 98.292% when pulling 58b0eaf8e1fd96e77e9bf762cbfdd052e216e51f on mikeengland:master into 431e5beaba0990767551c100a78b09e49bb9dc47 on kayak:master.


Hex Resolution Table error

The Hex resolution table at https://uber.github.io/h3/#/documentation/core-library/resolution-table has an error. The column heading "Average Hexagon Edge Length (km)" should read "Average Hexagon Radius Length (km)."
If you use this length to calculate area, you'll be off by 1/3.

If we were assuming regular hexagons, edge length and radius length would be the same - they're both sides of an equilateral triangle.
H3 hexagons are not regular hexagons, however - they have some distortion due to projection, and are neither perfectly uniform in shape nor perfectly uniform in area. That's why we can only give averages in the table. But AFAIK the assumption that edge length and radius length are equivalent still holds.

Nick,
Thanks for the quick response!
The examples that follow are for Resolution 7; when r (inradius or apothem) is 1.220629759 km then the areas is 5.16129km^2—same as in the table. See https://www.calculatorsoup.com/calculators/geometry-plane/polygon.php?n=6&given_data=i&i=1.220629759&units_length=m&sf=6&n_last=6&given_data_last=i&action=solve
However, when the side length (“edge”  or a) is 1.220629759 km then the area comes out at 3.877097km^2—which is just 75% of the area shown in the table. See https://www.calculatorsoup.com/calculators/geometry-plane/polygon.php?n=6&given_data=s&s=1.220629759&units_length=m&sf=6&n_last=6&given_data_last=s&action=solve
I think the problem is that the inradius (apothem) is not the same as the edge (side length). The circumradius and the edge are the same.
Am I looking at this correctly?

My mistake, I thought you were discussing the circumradius. It's possible the table is incorrectly labeled, as you suggest, though I'm surprised we had a metric for the inradius at all.
I think that table was originally produced mathematically, rather than empirically, and we've had a TODO item for a bit to provide better (or more easily confirmable) stats through empirical sampling.
@isaacbrodsky, do you know more about that column and whether it may be mislabeled?

@KeithFolkerts You're calculating the area of a planar hexagon, but H3 hexagons are on the sphere. I didn't create the average edge length column, so don't know how that was determined. But for the average area column I just divided the surface area of the earth by the number of hexagons at each resolution (accounting for the fact that the 12 pentagons have the same area as 10 hexagons).

@sahrk Cool we can describe the surface area of the globe to that many significant digits!
You're right, I am calculating the area of a planar hexagon, whereas H3 hexes are on the sphere (o,r I suppose, projected on  icosahedron faces). There will be sphere-to-icosahedron projection error. Also, the Table of Cell Areas for H3 Resolutions [(https://h3geo.org/#/documentation/core-library/resolution-table)] provides averages that account for the odd pentagon. I can't quote you a precise amount of error associated with these, but I assume it would be a minuscule fraction of 1% as you get to the finer resolution hexes.
From the table's stats the Resolution 11 hex has an average area of 0.0021496 sq km (slightly over 1/2 acre). Using this area with this online (planar) hex calculator https://www.calculatorsoup.com/calculators/geometry-plane/polygon.php we get the inradius (apothem) of 0.024910561--to eight significant digits the same as the number in the "Average Hexagon Edge Length" column. Clearly, what the table shows is the inradius not the edge length (or "circumradius"). I'm no mathematician, but I would chalk up this discrepancy to incorrect labeling rather than an error resulting from projections, pentagons, etc.

@KeithFolkerts It has nothing to do with the icosahedron, the projection, accounting for pentagons, etc. Given the edge length of a hexagon, the hexagon will have a different area if it is is on the surface of a sphere than if it is on the plane. You are using a planar hexagon calculator, but H3 hexagons are not planar hexagons. They are spherical polygons, so you would have to use a calculator (or formula) for the area of a spherical hexagon to get the correct area values.

I was about to add a comment agreeing with @KeithFolkerts.  For a planar hexagon with an area of 0.0021496, the inradius is 0.0249 (the figure shown in the table) while the edge length is 0.0288 (bigger by a non-trivial sqrt(4/3)).  I can't believe that at the higher resolutions, the earth's curvature is a significant factor.
But then I remembered that the mean of a sqrt is, in general, less than the sqrt of a mean.  So the means of both radii will be smaller than we would naively calculate.  (I suppose it's possible that this somehow makes the actual mean of the edge length equal to the naive mean of the inradius, but that seems unlikely.)  I also learned about distortion vertices which makes the whole thing a little weirder.
It seems to me that an empirical approach to radii would be better, as used for the areas column by @sahrk.
In the mean time, on balance I still think the column should be re-labelled something like "Radius (apothem)".
Finally, I find it unclear in the table whether non-hexagons are included in the averages or not (although it would make little difference at the higher resolutions).


Set up github actions for CI. Support testing with older redis server versions. Start testing with node 16

Note that enabling github workflows requires that a github workflows file be set up on master first for PRs by non-owners of a repo. (never mind, seemed to work)
(for first-time contributors, github workflows also requires that maintainers manually approve the run, to avoid bot activity wasting CI machine resources)
This adds commits on top of https://github.com/luin/ioredis/pull/1468

@luin thoughts? This is ready for review.


RFC: Annotation Data Model

DiSSCo Annotation Data Model is open for review. Deadline: 2023-10-31.

Our current schema will be implemented. Some of the suggestions received from the RFC process is already in the schema. The rest will be address in the next iteration. We will revisit the RFC after that.


Permissions for "Replies" chat

Currently, "Replies" chat's "permissions" have can_send_messages set to true,  however, if you send a message to the chat it results in an error.
Maybe set can_send_messages to false, so client won't have any specific treatment for "Replies" chat and handle permissions (and UI for them) as for ordinary chats, what do you think?
Thanks

The "Replies" chat needs some additional handling anyway, like support of the method blockMessageSenderFromReplies, so only the option "replies_bot_chat_id" was added instead. But you aren't the first to ask for this feature and the feature will not harm, so it was implemented in the recent master version.


4.7 Docs corrections - config-settings.rst

@amyblais Fixed. For them to show up, the text needs to be wrapped inside a box as attached

Thanks @amyblais
@esethna - can you check formatting please?

I think this can be merged without further review. (?)


Creates Jar release file

Codecov Report
Base: 62.23% // Head: 62.23% // No change to project coverage :thumbsup:

Coverage data is based on head (1af5199) compared to base (f0e0ece).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #80   +/-   ##
=========================================
  Coverage     62.23%   62.23%
  Complexity      502      502
=========================================
  Files            98       98
  Lines          1867     1867
  Branches        215      215
=========================================
  Hits           1162     1162
  Misses          636      636
  Partials         69       69

Impacted Files
Coverage Δ

src/main/java/seedu/address/MainApp.java
0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Compatibility issue with spartan weaponry 1.4.0

Currently this addon presents the same issue as the original did, its not compatible with the latest release of the main mod, version 1.4.0, released 5 days ago (19/12/2021). It specifically asks for beta 1.3.8.
I'm not totally sure but my guess its that it might be easily fixable by doing some minor changes in the Spartanlands.java file, probably just removing that specific version check.
Also, just a heads up, other addons are crashing the game, due to referencing some class file that got renamed in the newest SW update, according to this bug report: https://www.curseforge.com/minecraft/mc-mods/spartan-weaponry/issues/241 . Since the main dev said he might fix it himself I guess its fine for you to ignore it, but then again this is just a heads up regarding that very specific bug.

Also, hence my suggestions in #1.
SW has some breaking changes in 1.4.0, so.

Currently this addon presents the same issue as the original did, its not compatible with the latest release of the main mod, version 1.4.0, released 5 days ago (19/12/2021). It specifically asks for beta 1.3.8.
I'm not totally sure but my guess its that it might be easily fixable by doing some minor changes in the Spartanlands.java file, probably just removing that specific version check.
Also, just a heads up, other addons are crashing the game, due to referencing some class file that got renamed in the newest SW update, according to this bug report: https://www.curseforge.com/minecraft/mc-mods/spartan-weaponry/issues/241 . Since the main dev said he might fix it himself I guess its fine for you to ignore it, but then again this is just a heads up regarding that very specific bug.

I was the one who found out about this, btw. May occur with other addons too, but this was mainly tested with Spartan Compat.


[T3A4][F12-A3]Gabriel Sim

ready for review

@gabrielsim1993
Some comments added. Please ack & close the PR after reading comments.


[Feature request] switching to most recent desktop

It would be nice if there could be a key combination to switch to the most recently opened virtual desktop. (e.g., i find myself often switching back and forth between a "browser" and a "work" desktop, and a "toggle" key would be nice for that)

I agree, sounds useful. I'll implement it at some point.

Does this have a chance of being merged?  This is a great feature.

@robertmeta actually I had forgot about this issue and the related branch...
I'll have a look into it and discuss this with @sdias


ansible plugin downloads playbook to the plan directory, not workdir

I use plan like https://github.com/lukaszachy/testing-farm-konflux/blob/main/examples/tmt-plan/konflux.fmf
and once ti finishes I always have files like playbook-la0vgbpg.yml in the directory with the plan (fmf root as well as git root).
tmt version: 1.37.dev26+g1238dcaa
The command line used is tmt -c trigger=commit -c initiator=konflux run -avvv --environment-file envfile.yaml report -h html -o login -w error -w fail
IMO tmt should refrain from modifying plan directory (or any input files/directories).

That was a price for the "all playbooks must be under fmf tree root" rule which has been relaxed a bit recently. I suppose prepare/ansible should use its workdir, correct? Root selection (https://github.com/teemtee/tmt/blob/main/tmt/steps/prepare/ansible.py#L171) is correct for file-backed playbooks, for the downloaded different root will be needed, but that's easy to achieve, set root_path before the if branch and set it to workdir for remote playbooks.


feat: Add namespace field for pipeline, isb, monovertex and numaflow controller metrics

Fixes #226
Modifications

Added metrics with namespace

# HELP numaflow_pipelines_running Number of Numaflow pipelines running
# TYPE numaflow_pipelines_running gauge
numaflow_pipelines_running{intuit_alert="true",namespace="example-namespace"} 1
# HELP numaflow_isb_services_running Number of Numaflow ISB Service running
# TYPE numaflow_isb_services_running gauge
numaflow_isb_services_running{intuit_alert="true",namespace="example-namespace"} 1
# HELP numaflow_monovertices_running Number of Numaflow monovertices running
# TYPE numaflow_monovertices_running gauge
numaflow_monovertices_running{intuit_alert="true",namespace="example-namespace"} 1
# HELP numaflow_controller_running Number of Numaflow controller running
# TYPE numaflow_controller_running gauge
numaflow_controller_running{intuit_alert="true",name="numaflow-controller",name_namespace="example-namespace",version="1.3.0"} 1

Verification

Just looking at your PR description screen capture, why is the label for numaflow_controller_running called name_namespace instead of namespace like the others?

Oh, I have updated the code but forgot to update description. Let me do it..


plugin_scores: Fastlane docs parse only the last line of multiline action Description

New Issue Checklist

[x] Updated fastlane to the latest version
[x] I read the Contribution Guidelines
[x] I read docs.fastlane.tools
[x] I searched for existing GitHub issues

Issue Description
On docs.fastlane.tools, action description is only the last line when multi-line Ruby string is used:
https://github.com/fastlane/docs/blob/93169702a4f3c090824c08747f3b7050f3094ee1/plugin_scores_cache.yml#L4560
vs
https://github.com/dotdoom/fastlane-plugin-flutter/blob/23d517049d11da95563d35f76bfd44a64eb54eeb/lib/fastlane/plugin/flutter/actions/flutter_generate_action.rb#L36-L39

Turns out although this is a docs problem, the code for this actually does like in fastlane/fastlane as a special action: https://github.com/fastlane/fastlane/blob/master/fastlane/actions/plugin_scores.rb

The problem is probably inside this somewhere: https://github.com/fastlane/fastlane/blob/master/fastlane/helper/plugin_scores_helper.rb

The action is parsed into a file:
              actions = Dir["**/actions/*.rb"].map do |action_file|
                FastlaneActionFileParser.new.parse_file(action_file)
              end

The FastlaneActionFileParser iterates each line. It basically looks for a string, and places it in last_string_statement until is_end? returns true.
The parser even implicitly acknowledges multi-line strings won't work with the comment:
# All the ways ruby can represent single-line strings

So we either need to:

Add multiline string support to FastlaneActionFileParser, or
Disallow multiline strings in fastlane actions (maybe some kind of spec in https://github.com/fastlane/fastlane/tree/master/fastlane/spec/plugins_specs?)

Also as far as I can tell, FastlaneActionFileParser isn't under test :(

Hey guys 👋
@getaaron thank you so much for your help! ❤
I've spent some time on investigation of this issue and would like to share my findings:

PR with the fix is ready for review

I created the PR with the fix, although @dotdoom you will need to update the description of your plugin. More details in the PR's description.

Workaround

As a quick workaround, you could write a description in a single line. A long, single line description renders pretty well on Available Plugins site, i.e. airwatch_workspaceone

🙇

Thank you, I made this change when I discovered about this issue, but looks like it hasn't been picked up yet:
https://docs.fastlane.tools/plugins/available-plugins/#flutter
Thanks @mollyIV for sending a PR so quickly and @janpio for CCing me on it.

I think update of this is only done on release of fastlane.


The channel closed unexpectedly. Did the context die? | Used in Rest API

** Error **
Type:  Amp\Parallel\Sync\ChannelException
Message: The channel closed unexpectedly. Did the context die?
File: /vendor/amphp/parallel/lib/Sync/ChannelledStream.php

Without any further information, we can't help you. What's your code to trigger this?

The issue has been resolved and found out that it's not related to this library.
This library help us a lot. Thanks so much!

I'm glad to hear that. Would be cool to see some blog posts on how other people use Amp and its libraries. :-)


vscode.previewHtml not found!

Hello! I've just tried to install chrome-vs-code but every time I try to open the browser, vs code gives me this error msg; vscode.previewHtml not found, any ideas?

+1

+1

+1

+1


Warn the user about outdated EDSL version

Note: This can be merged safely without changes on production. If the header doesn't exist, nothing will happen.

@onmyraedar feel free to merge if make test-coop passes!


Fix the push-tags job from the docker-publish pipeline

The push-tag job is pushing a tag without the v prefix.
https://github.com/iolave/docker-clamav/blob/4dd56f1f626a4414011cdf2c1a92865218b6a57d/.github/workflows/docker-publish.yml#L88
As a side-note the create-release step also pushes a tag so it might be unnecessary to even have a push-tags job.

Resolved by #14


Prevent unnecessary update of observatorium in MCO

Everytime we create an Observatorium CR we create a new tenantID for default tenant and then ensure that the tenant ID is the same as the ID created the first time. Because of which the comparison in old and new spec differs and we update the spec again although nothing has changed.

/retest-required

Worth a backport perhaps?


[Types] Improve types for evaluate and evaluateHandle on various types (and JSHandle<T>)

Currently the evaluate and evaluateHandle functions and JSHandle<T> itself are very loosely typed, for example, this is allowed:
async function demo(handle1: JSHandle<number>, handle2: JSHandle<string>) {
	const notActuallyBoolean: JSHandle<'wait what'> = await handle1.evaluateHandle<JSHandle<boolean>>(
		  (num, notActuallyNumber: number, notActuallyString: string) => 'hi', handle2, 42);
}

Problems are:

Argument types are not checked (except for the subject handle itself).
Return type is not checked for evaluateHandle.
JSHandle<A> extends JSHandle<B> for any A,B. Same for ElementHandle<E>.

Solution
This could be solved by typing the functions as follows:
type Passed<H extends SerializableOrJSHandle> = H extends JSHandle<infer U> ? U : H;
type PassedArgs<Args extends SerializableOrJSHandle[]> = { [K in keyof Args]: Passed<Args[K]> };

class JSHandle<HandleObjectType> {
  /** Make sure that not e.g. `JSHandle<string> extends `JSHandle<number>` */
  private _dummy?: HandleObjectType;

  evaluateHandle<Args extends SerializableOrJSHandle[], Return>(
      pageFunction: (subject: HandleObjectType, ...args: PassedArgs<Args>) => Return,
      ...args: Args
  ): Promise<JSHandle<Return>> { ... }

  evaluate<
      Args extends SerializableOrJSHandle[],
      Return extends Serializable | PromiseLike<Serializable> | void
  >(
      pageFunction: (subject: HandleObjectType, ...args: PassedArgs<Args>) => Return,
      ...args: Args
  ): Promise<Awaited<Return>> { ... }

  ...
}

class Frame {
  evaluateHandle<Args extends SerializableOrJSHandle[], Return>(
      pageFunction: (...args: PassedArgs<Args>) => Return,
      ...args: Args
  ): Promise<JSHandle<Return>> { ... }

  evaluate<
      Args extends SerializableOrJSHandle[],
      Return extends Serializable | PromiseLike<Serializable> | void
  >(
      pageFunction: (...args: PassedArgs<Args>) => Return,
      ...args: Args
  ): Promise<Awaited<Return>> { ... }

  ...
}

// Same idea for ExecutionContext, Page, DOMWorld

With this version, the TypeScript compiler will complain about the demo function from earlier.
Feel free to copy parts of this code if you would want to.
Note that without the _dummy field it is not just the case that we can assign any JSHandle to any other, but we also have that Passed<ElementHandle<HTMLElement>> extends unknown instead of HTMLElement.
Wrapper/workaround for current Puppeteer versions (informational)
You can already accomplish this in current versions using the following wrapper functions:
// Workaround: Need the ElementHandle case because inferring U on JSHandle gives unknown because currently JSHandle<A> extends JSHandle<B> for any A,B...
type HandleValue<H extends JSHandle> = H extends ElementHandle<infer U> ? U
	  : H extends JSHandle<infer U> ? U : never;

type Passed<H extends SerializableOrJSHandle> = H extends JSHandle ? HandleValue<H> : H;
type PassedArgs<Args extends SerializableOrJSHandle[]> = { [K in keyof Args]: Passed<Args[K]> };

type PageFunction<Target extends Frame | Page | ExecutionContext | DOMWorld | JSHandle,
	  Args extends SerializableOrJSHandle[], Return> =
	  Target extends JSHandle
			? (obj: HandleValue<Target>, ...args: PassedArgs<Args>) => Return
			: (...args: PassedArgs<Args>) => Return;

/** Typed version of {@link Frame#evaluateHandle}, {@link JSHandle#evaluateHandle}, etc. */
export async function evaluateHandle<Subject extends Frame | Page | ExecutionContext | DOMWorld | JSHandle,
	  Args extends SerializableOrJSHandle[], Return>(
	  subject: Subject, pageFunction: PageFunction<Subject, Args, Return>, ...args: Args): Promise<JSHandle<Return>> {
	// eslint-disable-next-line @typescript-eslint/ban-ts-comment
	// @ts-ignore This compiles for all Targets individually
	return await subject.evaluateHandle(pageFunction, ...args) as JSHandle<Return>;
}

/** Typed version of {@link Frame#evaluate}, {@link JSHandle#evaluate}, etc. */
export async function evaluate<Subject extends Frame | Page | ExecutionContext | DOMWorld | JSHandle,
	  Args extends SerializableOrJSHandle[], Return extends Serializable | PromiseLike<Serializable> | void>(
	  subject: Subject, pageFunction: PageFunction<Subject, Args, Return>, ...args: Args): Promise<Awaited<Return>> {
	// eslint-disable-next-line @typescript-eslint/ban-ts-comment
	// @ts-ignore This compiles for all Targets individually
	return await subject.evaluate(pageFunction as never, ...args) as Awaited<Return>;
}

Thanks for helping us improve our types! It seems you've already investigated this. Mind opening a PR?

@jrandolf nice. First a question: I think for backwards compatibility the evaluate* functions should probably retain their first generic type parameter as the type of the function passed to them? Especially since the current docs recommend specifying it.
Related to that: Should the EvaluateFn<T,U,V> and EvaluateHandleFn remain around with the same signatures for backwards compatibility? They won't really be used in the new typings anymore, but they are exported members so some people may have used them. Although, because of their use of the any type the code using them probably needs to be re-typed anyway, so maybe removal would be ok, idk.

Oh, actually: TypeScript does not support partially specifying generic parameters, so even if we keep the first parameter the same, no other parameters can be added... I'll see if that is even possible.

At some point, the types will have to be redone due to an separate issue of our types not matching the API docs. Because of this, we can work through this on a PR while we wait for this to happen :)

@jrandolf Ok! I'm struggling a bit with the types, mostly because TypeScript gets a bit confused with the function and string union, since the evaluate functions can also take a string parameter. Maybe it's not impossible, but it requires extra code and really doesn't want to work well. It would massively simplify the typing if the option to pass a string was just removed. It's usecase is covered anyway by just using something like () => <string here>. In my opinion, the string option was never useful to begin with, since it doesn't even support passing arguments.

Actually, I guess it's necessary for dynamically constructed functions... Not sure how to solve this

I created a draft PR! #8540

@jrandolf I just checked and the issue that e.g. JSHandle<number> is assignable to JSHandle<string> is not fixed yet. This is what I did with the dummy field in class JSHandle.

I think this was fixed via the branded types? cc @jrandolf

This doesn't seem to work well with xpath... I was using Page["$x"] which probably should be deprecated as Frame["$x"]? Anyway, Page["$$"] seems to accept the selector as generic but then this doesn't really help when I have xpath/... prefix... Sticking with ... as ... for now, hope this helps improve the lib, cheers!

@Maxim-Mazurok Take a look at #8579, they could try to improve the template string types for xpath query handlers.
I don't think Page#$x will be deprecated btw.


ValidationPlugin: Zod types seem to mismatch what Pothos expect

const ipSchema = zod.string().ip(); returns a ZodString type
When I use it here:
 t.field({
    args: {
      endpointId: t.arg.id({ required: true }),
      ip: t.arg.string({
        required: true,
        validate: {
          schema: ipSchema,
        },
      }),
    },
    ...

    Type 'import("/redacted/node_modules/zod/lib/ZodError").ZodErrorMap | undefined' is not assignable to type 'Zod.ZodErrorMap | undefined'.
      Type 'import("/redacted/node_modules/zod/lib/ZodError").ZodErrorMap' is not assignable to type 'Zod.ZodErrorMap'.
        Types of parameters 'issue' and 'issue' are incompatible.
          Type 'Zod.ZodIssueOptionalMessage' is not assignable to type 'import("/redacted/node_modules/zod/lib/ZodError").ZodIssueOptionalMessage'.
            Type 'ZodInvalidLiteralIssue' is not assignable to type 'ZodIssueOptionalMessage'.
              Property 'received' is missing in type 'Zod.ZodInvalidLiteralIssue' but required in type 'import("/redacted/node_modules/zod/lib/ZodError").ZodInvalidLiteralIssue'.ts(2322)```

Zod version is 3.21.4, Pothos Validation is 3.9.0

This looks a little like you have multiple versions of zod installed, is your schema coming from another package in a monorepo or something?

@hayes, it's a monorepo but just has one version of Zod. There is one dependency with a slightly older version of Zod but the installed version that this should be using is 3.21.4

I haven't been able to reproduce, this is an example of this working for me:
https://stackblitz.com/edit/typescript-ka6und?file=index.ts
If you can provide some more details on how to reproduce the issue, happy to help debug what's going in

Since I haven't heard back here, I am going to close this, but happy to take a look if you can provide more details!


Facebook prove not work

Hello iam new to this and everytime i try to prove my facebook identity he tells me error 500 after making the public facebook post ... any idea i can proof facebook identity ? i dont know what to do:(

Hi. I've got almost the same issue. My problem is that I have a personal Facebook account. I could verify it. But when it comes to verify my enterprise's Facebook account... I just can't: that's because it hasn't the same way of using it like a normal user account. For instance, with a normal user account you just log into it, type the message, and it's done... but with an enterprise account you must login like an authorized user (e.g. your "normal user account"), and that user puts the verification message... but it doesn't work. You can't do it directly. You must first login like a normal user, send the message, copy that message (link), and then go to the enterprises account to paste the link... and it doesn't work!!
Perhaps your problem is not like mine... perhaps it's just a matter of making the proof (message) public.

perhaps add a screenshot of the Facebook post? a friend had a similar issue and it was resolved by changing the post setting from "only friends" to "public."


Add iat check

Q
A

Bug fix?
no

New feature?
yes

BC breaks?
no

Deprecations
no

Fixed tickets
#239

Tests pass?
yes

Closes #239

We'll keep the claim not checked on 1.x, it would be somehow a BC break, e.g. for people who don't use our built-in encoder and build their own payloads without this claim.


Fix missing default lightEmission for light blocks

Fixes #34

I ended up handling this slightly differently in #37 (just removing the default completely instead). Thank you for raising the issue.


Add cancelled status to syncjob

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #2399
Description
Clear and concise code change description.
Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
Type
Choose one: (Bug fix | Feature | Documentation | Testing | Code health | Builds | Releases | Other)
Screenshots (if applicable)
Checklist

[x] I have read and acknowledged the Code of conduct.
[x] I have read the Contributing page.
[ ] I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
[x] I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
[x] I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
[x] I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
[ ] I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

@sharon2719 this pr has never been out of draft state - if you want a review can you pls makr this as ready for review
@santosh-pingle did some similar work so he should do the first round of review
this pr also looks stale - so if there's no further movement i think we should close this. @sharon2719 in that case if you still need this change can you just raise a new pr? thanks very much for your contribution - really appreciate it!