Missing make rule on Fedora

I am attempting to compile the hello_world example following the instructions in the wiki, on a Fedora installation. I have installed all the listed dependencies. I am running the following command: conan install ../hello_world -pr gcc-9.2.1-linux-x86_64 --build
With the corresponding conan profile:
[build_requires]
binutils/2.31@includeos/toolchain
[settings]
os=Linux
os_build=Linux
arch=x86_64
arch_build=x86_64
compiler=gcc
compiler.version=9.2
compiler.libcxx=libstdc++11
cppstd=17
build_type=Release
[options]
[env]
CC=/usr/bin/gcc
CXX=/usr/bin/g++
CFLAGS=-msse3 -mfpmath=sse -O2 -g
CXXFLAGS=-msse3 -mfpmath=sse -O2 -g

Which gives the following error:
includeos/0.15.1-5@includeos/latest:
includeos/0.15.1-5@includeos/latest: ERROR: Package '9369a710a73af862c4f6665e44c0c8894ca8587e' build failed
includeos/0.15.1-5@includeos/latest: WARN: Build folder /home/matan/.conan/data/includeos/0.15.1-5/includeos/latest/build/9369a710a73af862c4f6665e44c0c8894ca8587e
ERROR: includeos/0.15.1-5@includeos/latest: Error in build() method, line 84
	cmake.build()
	ConanException: Error 2 while executing cmake --build '/home/matan/.conan/data/includeos/0.15.1-5/includeos/latest/build/9369a710a73af862c4f6665e44c0c8894ca8587e' '--' '-j4'

When I copy out the cmake command, and remove the '-j4' flag, I get a bunch of syntax errors:
[  2%] Built target crt
[  3%] Building CXX object src/hal/CMakeFiles/hal.dir/machine.cpp.o
In file included from /usr/include/c++/9/x86_64-redhat-linux/bits/c++config.h:2594,
                 from /usr/include/c++/9/bits/functexcept.h:39,
                 from /usr/include/c++/9/memory_resource:42,
                 from /home/matan/.conan/data/includeos/0.15.1-5/includeos/latest/source/src/../api/pmr:4,
                 from /home/matan/.conan/data/includeos/0.15.1-5/includeos/latest/source/src/../api/util/alloc_buddy.hpp:24,
                 from /home/matan/.conan/data/includeos/0.15.1-5/includeos/latest/source/src/../api/kernel/memory.hpp:25,
                 from /home/matan/.conan/data/includeos/0.15.1-5/includeos/latest/source/src/../api/util/typename.hpp:20,
                 from /home/matan/.conan/data/includeos/0.15.1-5/includeos/latest/source/src/../api/hal/detail/machine.hpp:24,
                 from /home/matan/.conan/data/includeos/0.15.1-5/includeos/latest/source/src/../api/hal/machine.hpp:95,
                 from /home/matan/.conan/data/includeos/0.15.1-5/includeos/latest/source/src/hal/machine.cpp:17:
/usr/include/c++/9/x86_64-redhat-linux/bits/os_defines.h:44:19: error: missing binary operator before token "("
   44 | #if __GLIBC_PREREQ(2,15) && defined(_GNU_SOURCE)
      |                   ^
In file included from /home/matan/.conan/data/includeos/0.15.1-5/includeos/latest/source/src/../api/pmr:4,
                 from /home/matan/.conan/data/includeos/0.15.1-5/includeos/latest/source/src/../api/util/alloc_buddy.hpp:24,
                 from /home/matan/.conan/data/includeos/0.15.1-5/includeos/latest/source/src/../api/kernel/memory.hpp:25,
                 from /home/matan/.conan/data/includeos/0.15.1-5/includeos/latest/source/src/../api/util/typename.hpp:20,
                 from /home/matan/.conan/data/includeos/0.15.1-5/includeos/latest/source/src/../api/hal/detail/machine.hpp:24,
                 from /home/matan/.conan/data/includeos/0.15.1-5/includeos/latest/source/src/../api/hal/machine.hpp:95,
                 from /home/matan/.conan/data/includeos/0.15.1-5/includeos/latest/source/src/hal/machine.cpp:17:
/usr/include/c++/9/memory_resource:332:30: error: ‘__uses_alloc1’ does not name a type
  332 |       using __uses_alloc1_ = __uses_alloc1<polymorphic_allocator>;
      |                              ^~~~~~~~~~~~~
/usr/include/c++/9/memory_resource:333:30: error: ‘__uses_alloc2’ does not name a type
  333 |       using __uses_alloc2_ = __uses_alloc2<polymorphic_allocator>;
      |                              ^~~~~~~~~~~~~
/usr/include/c++/9/memory_resource:337:17: error: ‘__uses_alloc0’ has not been declared
  337 |  _S_construct_p(__uses_alloc0, _Ind, tuple<_Args...>& __t)
      |                 ^~~~~~~~~~~~~
/usr/include/c++/9/memory_resource:342:17: error: ‘__uses_alloc1_’ has not been declared
  342 |  _S_construct_p(__uses_alloc1_ __ua, index_sequence<_Ind...>,
      |                 ^~~~~~~~~~~~~~
/usr/include/c++/9/memory_resource:352:17: error: ‘__uses_alloc2_’ has not been declared
  352 |  _S_construct_p(__uses_alloc2_ __ua, index_sequence<_Ind...>,
      |                 ^~~~~~~~~~~~~~
/usr/include/c++/9/memory_resource: In member function ‘typename std::pmr::polymorphic_allocator<_Tp>::__not_pair<_Up>::type std::pmr::polymorphic_allocator<_Tp>::construct(_Tp1*, _Args&& ...)’:
/usr/include/c++/9/memory_resource:241:13: error: ‘__uses_alloc_t’ in namespace ‘std’ does not name a template type
  241 |      = std::__uses_alloc_t<_Tp1, polymorphic_allocator, _Args...>;
      |             ^~~~~~~~~~~~~~
/usr/include/c++/9/memory_resource:242:31: error: ‘__uses_alloc0’ was not declared in this scope
  242 |    if constexpr (is_base_of_v<__uses_alloc0, __use_tag>)
      |                               ^~~~~~~~~~~~~
/usr/include/c++/9/memory_resource:242:46: error: ‘__use_tag’ was not declared in this scope
  242 |    if constexpr (is_base_of_v<__uses_alloc0, __use_tag>)
      |                                              ^~~~~~~~~
/usr/include/c++/9/memory_resource:244:36: error: ‘__uses_alloc1_’ was not declared in this scope
  244 |    else if constexpr (is_base_of_v<__uses_alloc1_, __use_tag>)
      |                                    ^~~~~~~~~~~~~~
/usr/include/c++/9/memory_resource: In member function ‘void std::pmr::polymorphic_allocator<_Tp>::construct(std::__1::pair<_U1, _U2>*, std::__1::piecewise_construct_t, std::__1::tuple<_Args1 ...>, std::__1::tuple<_Args2 ...>)’:
/usr/include/c++/9/memory_resource:259:6: error: ‘__use_alloc’ was not declared in this scope
  259 |      __use_alloc<_Tp1, polymorphic_allocator, _Args1...>(*this);
      |      ^~~~~~~~~~~
/usr/include/c++/9/memory_resource:259:22: error: expected primary-expression before ‘,’ token
  259 |      __use_alloc<_Tp1, polymorphic_allocator, _Args1...>(*this);
      |                      ^
/usr/include/c++/9/memory_resource:261:22: error: expected primary-expression before ‘,’ token
  261 |      __use_alloc<_Tp2, polymorphic_allocator, _Args2...>(*this);
      |                      ^
/usr/include/c++/9/memory_resource: In static member function ‘static std::__1::tuple<std::__1::allocator_arg_t, std::pmr::polymorphic_allocator<_Tp>, _Args&& ...> std::pmr::polymorphic_allocator<_Tp>::_S_construct_p(int, std::__1::index_sequence<_Ind ...>, std::__1::tuple<_Args2 ...>&)’:
/usr/include/c++/9/memory_resource:346:29: error: request for member ‘_M_a’ in ‘__ua’, which is of non-class type ‘int’
  346 |        allocator_arg, *__ua._M_a, std::get<_Ind>(std::move(__t))...
      |                             ^~~~
/usr/include/c++/9/memory_resource: In static member function ‘static std::__1::tuple<_Args&& ..., std::pmr::polymorphic_allocator<_Tp> > std::pmr::polymorphic_allocator<_Tp>::_S_construct_p(int, std::__1::index_sequence<_Ind ...>, std::__1::tuple<_Args2 ...>&)’:
/usr/include/c++/9/memory_resource:354:54: error: request for member ‘_M_a’ in ‘__ua’, which is of non-class type ‘int’
  354 |  { return { std::get<_Ind>(std::move(__t))..., *__ua._M_a }; }
      |                                                      ^~~~
/usr/include/c++/9/memory_resource: At global scope:
/usr/include/c++/9/memory_resource:427:26: error: ‘vector’ in namespace ‘std::pmr’ does not name a template type
  427 |     _GLIBCXX_STD_C::pmr::vector<_BigBlock> _M_unpooled;
      |                          ^~~~~~
/usr/include/c++/9/memory_resource: In member function ‘std::pmr::memory_resource* std::pmr::__pool_resource::resource() const’:
/usr/include/c++/9/memory_resource:416:14: error: ‘_M_unpooled’ was not declared in this scope; did you mean ‘_M_npools’?
  416 |     { return _M_unpooled.get_allocator().resource(); }
      |              ^~~~~~~~~~~
      |              _M_npools
/usr/include/c++/9/memory_resource: At global scope:
/usr/include/c++/9/memory_resource:492:5: error: ‘__gthread_key_t’ does not name a type; did you mean ‘pthread_key_t’?
  492 |     __gthread_key_t _M_key;
      |     ^~~~~~~~~~~~~~~
      |     pthread_key_t
In file included from /home/matan/.conan/data/includeos/0.15.1-5/includeos/latest/source/src/../api/util/alloc_buddy.hpp:24,
                 from /home/matan/.conan/data/includeos/0.15.1-5/includeos/latest/source/src/../api/kernel/memory.hpp:25,
                 from /home/matan/.conan/data/includeos/0.15.1-5/includeos/latest/source/src/../api/util/typename.hpp:20,
                 from /home/matan/.conan/data/includeos/0.15.1-5/includeos/latest/source/src/../api/hal/detail/machine.hpp:24,
                 from /home/matan/.conan/data/includeos/0.15.1-5/includeos/latest/source/src/../api/hal/machine.hpp:95,
                 from /home/matan/.conan/data/includeos/0.15.1-5/includeos/latest/source/src/hal/machine.cpp:17:
/home/matan/.conan/data/includeos/0.15.1-5/includeos/latest/source/src/../api/pmr:14:29: error: ‘vector’ in namespace ‘std::pmr’ does not name a template type
   14 |   using buffer  = std::pmr::vector<uint8_t>;
      |                             ^~~~~~
/home/matan/.conan/data/includeos/0.15.1-5/includeos/latest/source/src/../api/pmr:15:35: error: ‘buffer’ was not declared in this scope; did you mean ‘setbuffer’?
   15 |   using buf_ptr = std::shared_ptr<buffer>;
      |                                   ^~~~~~
      |                                   setbuffer
/home/matan/.conan/data/includeos/0.15.1-5/includeos/latest/source/src/../api/pmr:15:41: error: template argument 1 is invalid
   15 |   using buf_ptr = std::shared_ptr<buffer>;
      |                                         ^
gmake[2]: *** [src/hal/CMakeFiles/hal.dir/build.make:63: src/hal/CMakeFiles/hal.dir/machine.cpp.o] Error 1
gmake[1]: *** [CMakeFiles/Makefile2:195: src/hal/CMakeFiles/hal.dir/all] Error 2
gmake: *** [Makefile:130: all] Error 2

When I add '-n' to the make flags to show all executed commands, I see the following error:
gmake[2]: *** No rule to make target 'src/hal/CMakeFiles/hal.dir/machine.cpp.o', needed by 'lib/libos.a'.  Stop.
gmake[1]: *** [CMakeFiles/Makefile2:140: src/CMakeFiles/os.dir/all] Error 2
gmake: *** [Makefile:130: all] Error 2

I am currently using a newer version of gcc than the instructions (9.2.1), could that have something to do with it? Any help would be appreciated!

Btw, it appears the command that causes the failure is /usr/bin/gmake -f src/CMakeFiles/os.dir/build.make src/CMakeFiles/os.dir/build, and I've confirmed that just running that command outside of the conan build results in the same 'No rule to make target' error as listed above

From me it looks like an issue with the PMR which was experimental. we tried making it optional and therefore future safe. please try with the clang profile to see if this is the case..
https://github.com/includeos/IncludeOS/blob/master/api/pmr

I wonder if I made some PMR changes in my last PR, perhaps its fixed now?

@KristianJerpetjon @MatanSilver I keep getting this error on Fedora 32 with the clang profile
CMake Error at /opt/build_hello_world/conanbuildinfo.cmake:2457 (message):
  Incorrect 'clang', is not the one detected by CMake: 'clang++-6.0'

(conanenv) [jeff@jeffs-machine build_hello_world]$ cmake ../hello_world
-- The C compiler identification is Clang 6.0.0
-- The CXX compiler identification is Clang 6.0.0
-- Check for working C compiler: /usr/bin/clang-6.0
-- Check for working C compiler: /usr/bin/clang-6.0 - works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /usr/bin/clang++-6.0
-- Check for working CXX compiler: /usr/bin/clang++-6.0 - works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Conan: Adjusting output directories
-- Conan: Using cmake global configuration
-- Conan: Adjusting default RPATHs Conan policies
-- Conan: Adjusting language standard
-- Current conanbuildinfo.cmake directory: /opt/build_hello_world
CMake Error at /opt/build_hello_world/conanbuildinfo.cmake:2457 (message):
  Incorrect 'clang', is not the one detected by CMake: 'clang++-6.0'
Call Stack (most recent call first):
  /opt/build_hello_world/conanbuildinfo.cmake:2020 (conan_check_compiler)
  CMakeLists.txt:6 (conan_basic_setup)

-- Configuring incomplete, errors occurred!
See also "/opt/build_hello_world/CMakeFiles/CMakeOutput.log".


Modify get /hw feature

Currently it takes into account outpatients which are not assigned a hospital wing.
Also resolves the Invocation Target Error.

Codecov Report
Base: 69.45% // Head: 69.36% // Decreases project coverage by -0.08% :warning:

Coverage data is based on head (342f5fc) compared to base (e15cc07).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #52      +/-   ##
============================================
- Coverage     69.45%   69.36%   -0.09%
  Complexity      465      465
============================================
  Files            81       81
  Lines          1542     1544       +2
  Branches        192      192
============================================
  Hits           1071     1071
- Misses          397      399       +2
  Partials         74       74

Impacted Files
Coverage Δ

...address/logic/commands/GetHospitalWingCommand.java
0.00% <0.00%> (ø)

src/main/java/seedu/address/model/Model.java
100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

LGTM!


cleaned up practical part

Added zenodo data and most explanations

@bgruening @hexylena @shiltemann -> can you please merge this draft?

@nekrut would you like to nominate one of your own staff to be responsible for this? we can ensure they have powers to merge things, and you can ping them directly. (I can think of two off the top of my head that have write permissions already)
pinging three Europeans maybe isn't optimal in terms of scheduling and our holiday schedules :)


14 points model?

can you provide your 14 points model?

I have no plans of doing that, but note that you can train it yourself passing the --predict_14 flag.
Cheers,

Closing for lack of activity. Please reopen if the issue is still ongoing.


Checking for typeof number instead of String number

The number pattern in backbone.validation checks whether the value being set is a string matching the number pattern. What is the best way to validate if the value set is a number type - not just a string matching a number. Does this require writing a custom validator?

Does this require writing a custom validator?

If you need to compare if a number is really an integer, then you have to write your own validation — which is simple as hell.


WARN  com.provectus.kafka.ui.exception.ErrorCode - Multiple class

Describe the bug
Trying to upgrade to last 3.3 version after the kafka-ui started, when trying to access to the Web UI  I get immediately disconnected and in containers log I see these lines:
15:45:34.875 [parallel-1] DEBUG com.provectus.kafka.ui.service.MetricsUpdateService - Start getting metrics for kafkaCluster: strimzi 15:45:55.587 [boundedElastic-1] WARN  com.provectus.kafka.ui.exception.ErrorCode - Multiple class com.provectus.kafka.ui.exception.ErrorCode values refer to code 4001 15:45:55.708 [boundedElastic-2] DEBUG org.springframework.http.codec.json.Jackson2JsonEncoder - [694106d4] Encoding [class ErrorResponse {     code: 5000     message: 404 NOT_FOUND     timestamp:<PHONE_NUMBER>588     req (truncated)...] 15:45:55.709 [boundedElastic-1] DEBUG org.springframework.http.codec.json.Jackson2JsonEncoder - [cfe32b23] Encoding [class ErrorResponse {     code: 5000     message: 404 NOT_FOUND     timestamp:<PHONE_NUMBER>588     req (truncated)...] 15:46:04.875 [parallel-1] DEBUG com.provectus.kafka.ui.service.MetricsUpdateService - Start getting metrics for kafkaCluster: strimzi
After few minutes containers restart because probing fails.
The old kafka-ui 2.0 version works fine on the same Kubernetes.
Set up
version 0.3.3
Kubernetes 1.21 on Amazon EKS
Steps to Reproduce
1)Install last version with Helm chart
2)Modify generated server to create an Internal Load Balancer on AWS EKS
3)try to access to the Web UI
Expected behavior
I can access the UI

Hi @montebove

2)Modify generated server to create an Internal Load Balancer on AWS EKS
Do you mean the service? If so, could you please share the details of the service that you have now after the changes? As yaml file if possible please.

Here is the service.yaml. With identical modifications works fine on old 2.0 version. I changed extension to .txt because .yaml it's no supported  by github
service.yaml.txt

The warning you mentioned itself shouldn't be a problem itself.

@montebove thank you. Do I understand it correctly: as soon as the load balancer is up, you are trying to access the webui via the load balancer hostname and port 80?

@montebove if you have time we could jump into our discord to discuss the situation in more details. Just let me know if it's OK with you.

SOLVED:
There is a problem in the chart but not a real bug. I was using last helm chart version but as Kubernetes download new images only if it is a different version as ifnotpresent is specified I actually used always the old 2.0 version docker image. Forcing deployment to download the image all started to work. The problem originated from the fact I previously, some months ago,  installed the 2.0 version and the Helm chart indicated as image version provectuslabs/kafka-ui:latest (at that time 2.0), but after months the new Helm chart asked for the same provectuslabs/kafka-ui:latest and Kubernetes doesn't distinguishes that actually are not the same. I would suggest to use an explicit docker image version in Helm chart something like for the current version provectuslabs/kafka-ui:0.3.3

@montebove thank you for the info. Glad it works. We'll take a look.


Bug fix/internal issue #725

Analyzers revision reading is reworked to include not only current but also system database revision in query json.
To reduce json size MIN revision is default and never  included in json so if current and/or system database contains no custom analyzers -> nothing is transferred.
Also to keep backward compatibility revision value was excluded from analyzer properties output for user.

https://jenkins.arangodb.biz/view/PR/job/arangodb-matrix-pr/10677/

http://jenkins01.arangodb.biz:8080/job/arangodb-matrix-pr/10687/ Tests blue


Disk caching only works for the same running instance.

Which version of PhantomJS are you using? Tip: run phantomjs --version.
1.9.7 and 2.1
Which operating system are you using?
linux mint 17.3 rosa
Did you use binary PhantomJS or did you compile it from source?

I use binary PhantomJS

Please provide any additional information below.

I am running the same url by starting phantomjs process each time and its not using the cache. I am using the following options:
--ignore-ssl-errors=true --ssl-protocol=tlsv1 --disk-cache=true --max-disk-cache-size=1000000
but the caching seems to work only for the same process.

Is there any update for this issue?? I am facing the same. Also would want to know if there is any alternative to it. My PhantomJs version is 2.1.1


unzip slow

hi，i use unzip scrom zip file in  linux pod envionment ,I  found slowly(100 m zip files  need 20 s),  my pod use  mount azure blob .
my code is

what i can do,. imporve the unzip perfermance?

I don't see anything obvious, but using managed code (SharpZipLib) to do CPU-heavy tasks will always be slower than native. If speed is an issue you could try using a native executable like 7za.


Fix/generic aot fun

Attempt to fix the 'generic' AOT issue. Since we manually create a provider in NgReduxModule.forRoot(), the @Injectable decorator is redundant on NgRedux. I'm working on the theory that the Injectable with the generic type is what's causing AoT to barf.

FYI @watrool


Color Jenkins logs support

Gradle: can force colors with --console=rich output, but without a terminal the captured Jenkins output contains a lot of repeated progress text.
https://github.com/gradle/gradle/issues/6843
tox: colors can be forced with PY_COLORS=1
pytest: can force colors with --colors=yes on the command line (pytest.ini didn't work for me). Looks ugly on a terminal, though (in color):

... [ 91%]
.======-------...0% EXECUTING [3m 1s]estPy37.cp       ...                           .         ....                                    .         .         ...                     .
..s...s.....................................                                                                                .
........ [ 93%]

However, with Gradle defaulting to --console=plain (no terminal control chars), this should be fine under Jenkins.

docker output - always outputs color, looks fine (see :sdks:python:container:py35:docker in https://builds.apache.org/job/beam_PreCommit_Portable_Python_Phrase/576/console).

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Aborting

run seed job

Run Python PreCommit

Run Python PreCommit

Run Python PreCommit

run seed job

run python precommit

R: @tvalentyn
Sadly this doesn't fix the codecov link with ansi color code at the end. The code is not displayed but the link still has it:
https://codecov.io/github/apache/beam/commit/2489cf1e6f7d9772449a052165de3139c5d2e8a1%1B[0m

run python precommit

run python precommit


Android: Node type updates only after starting to type

When I toggle/switch node types no change is visible. I have to start typing to see the change.
I would expect an instant update of the node type.
Screenrecording

This is a bug by Prosemirror itself.


Doesn't meet requirements

Describe the Bug

Summary:
Tried Everything
nothing is working
Output folder: C:\Program Files\Intel\HAXM
Extract: checktool.exe
Execute: C:\Program Files\Intel\HAXM\checktool.exe --verbose
CPU vendor          -  AuthenticAMD
Intel64 supported   *  Yes
VMX supported       -  No
VMX enabled         *  Yes
EPT supported       *  Yes
NX supported        *  Yes
NX enabled          *  Yes
Hyper-V disabled    *  Yes
OS version          *  Windows 10.0.19042
OS architecture     *  x86_64
Guest unoccupied    *  Yes. 0 guest(s)
Execute: cmd.exe /c type "D:\Dataset\haxm-windows_v7_7_0\haxm_install-20210626_1719.log" > "C:\Users\Admin\AppData\Local\Temp\haxm_install-20210626_1719.log"
Delete file: D:\Dataset\haxm-windows_v7_7_0\haxm_install-20210626_1719.log
WHAT SHOULD I DO ?
Host Environment

HAXM version:

Host OS version:

Host OS architecture: x86_64

Host CPU model:

Host RAM size:

(Optional) Host computer model:

Guest Environment

Android Emulator or QEMU version:

Guest OS version:

Guest OS architecture:

To Reproduce

Steps to reproduce the behavior:
1.
2.
3.
Expected Behavior

Expectation:
Reproducibility

Diagnostic Information

Host crash dump:

HAXM log:

Android Emulator or QEMU log:

Screenshots:
Additional context

None

CPU vendor - AuthenticAMD

HAXM does not support AMD cpus.


Footer-Social Media Icons Issue

Hi Team,
While comparing the developed Footer block with the legacy site Footer block, identified a couple of issues which are mentioned below.
Issue-1:-
While the size is reducing, there is an alignment issue in the social media icons section.

Issue-2
When the page is in mobile view the icons should get shuffled like the legacy site but it's not happening in the EDS.

Hi Kumaresan,
They are used earlier in the existing site float, this is the issue with the existing issue. We cleared it with Flex display property. So This is not an issue. @umamenda , @teshukatepalli1 , @Kummu007 , @pardeepgera23

Thaks for the update @Vinaykumargujja
As mentioned in the above thread, this is not an issue. Hence closing the ticket.


chore(SetTheory/Ordinal/Notation): improve documentation

We improve comment formatting and perform some simple golfing.

There's a lot with this file that can be improved. Auxiliary theorems are inconsistently named and poorly documented, the use of NF as a typeclass is contentious (at least to myself, see Zulip), the use of OfNat instead of the NatCast typeclass is somewhat idiosyncratic, and a lot of the proofs can definitely be simplified. But I think it's better to go about this in stages.

There's still a fair amount of work going on here, and not just documentation. Could you split further or update the summary?

Yeah, I'll split this PR sometime in the following days. There's a lot of stuff I want to do with this file and I might have gone overboard for an initial PR.

I've moved the documentation related stuff to #16283


Invalid argument supplied for foreach()

hello...
i'have installed on laravel 6.
but i get some error..
vendor/silviolleite/laravelpwa/Services/ManifestService.php:27
url : https://flareapp.io/share/dmknY653#F56
can you fix this ?

try php artisan config:clear. It helpes me

@Jalbf  thanks I run this command and it worked

@Jalbf  thanks I run this command and it worked


Feature show elementid detail

Purpose
get and show element in method value which return a ElementId
Description

if get fail, will return null value

Declarations
Check these if you believe they are true

[x] This PR for new feature

Reviewers
@chuongmep @weianweigan

@sapiens-code  whether we can add feature this support properties include ?

@sapiens-code whether we can add feature this support properties include ?

sure. I can update this feature.

Thank you very much for this feature, I will wait for you to complete the information with the properties and review again code before merge them into branch dev.

hi @chuongmep @weianweigan, I have finished the feature of displaying the element for the propẻty, now you can check it out

Look good for me .

@weianweigan  you have any problem about pull request this ? if do't have i will merge to dev branch , this is a good feature .


Backup function having unwanted side effects

When a program crashes the calculator and I've made a RAM backup before, after the calculator turns on again I get a memory error, which stays whatever you try. Well, I've managed to get it away, but that doesn't matter because when you then try to do something the calculator crashes again.
So basically after a crash you have to do a reset again and then you won't have the problem, but then you can't recover RAM anymore from backup.
This happens on: TI-84+ CE-T Python Edition.
Boot: <IP_ADDRESS>6
OS: <IP_ADDRESS>0
Cesium version: 3.3.1
Steps to reproduce this bug:

Make a program that will crash the calculator.
Do some calculations on the home screen.
Backup RAM with [on]+[8].
Run the program that crashes the calculator.
If you don't get the memory error do one or two more calculations.  (987*6 for example)
If you have to do step five, backup again and run the program that crashes the calculator again.

I can't reproduce this in CEmu

Hmm.....
Whit what OS version?
I was able to reproduce it in CEmu...

Why can't you just tell me exactly what you did.

have a program that will crash the calculator here
do 6 times the calculation: 123456789*55
Backup using on+8
run the program "BJA"

Yay thank you :)

Sorry if I'm disturbing but backup doesn't really works :'(
Check this out (TI-83 Premium CE) :
[on]+8
I deleted a program
[on]+2
The program isn't here

[2ND] should launch a program (it essentially executes the command prgmPROGRAM but from Cesium in lieu of the homescreen) after backing up the RAM (if enabled). [ENT] launches the program without backing up the RAM.
Was the program you deleted in RAM?

No

That probably explains it -- it backs up the RAM in case of a crash, not all programs. Wouldn't it be cool if it did, though...
Oh, wait. Haha, silly me. BlastFIS already does that! I think you can find it on ACagliano's website. Ho[e this solves what you were asking about!

It does back up all programs. Please stop commenting on random GitHub issues you are clueless about.

How do you mean "all programs"? Do you mean all programs? Or all programs in RAM? A program might not necessarily be in RAM.
It's called RAM backup for a reason...
Also, I'm not clueless. Inexperienced, perhaps. But definitely not clueless.

Do not comment on GitHub issues when you have nothing to offer.

Same thing here, I couldn't even get the calculator to boot up, until I used the hard reset button.


check if there is a vcf config file first

Requirements
None
Description
This is a fix for a bug which I noticed on staging. The problem being that there was no vcf config file under public-plugins/ensembl/conf/json/ for the species.
Views affected
Variant summary page
Possible complications
Is $c->{'CONFIG'} always pointing to public-plugins/ensembl/conf/json/ if there is a config file for the given species stored in that directory?
Merge conflicts
None
Related JIRA Issues (EBI developers only)
None

This looks OK, but do you know why we have a flag in the config called 'ENABLED'? If it's significant, it would better to check for this value, but as we always set it to 1 it seems a bit pointless. See here:
https://github.com/Ensembl/ensembl-webcode/blob/release/95/modules/EnsEMBL/Web/SpeciesDefs.pm#L575

It looks a bit more complicated to get filename and confdir information where I want to check for existence of a vcf config file. Enabled differentiates between different values: 0 (no vcf), 1 (only vcf), 2 (vcf and database). This is how the variation API uses the value stored in the use_vcf method.

Oh, OK - anything to keep the variation API happy! However looking at it more closely, I think it would be better practice to put this check in the methods that return data, to keep the code as cleanly MVC as possible. Thus in Variation::Object::CADD_score, just add:
return unless $self->hub->species_defs->ENSEMBL_VCF_COLLECTIONS;
at the start of the method. I also note that the CADD_score method can return an array of undefs, which is not what the change_tolerance method is checking for, here:
$self->hub->species_defs->ENSEMBL_VCF_COLLECTIONS;
Feel free to come and talk to me if this doesn't make sense.

Thank you for the feedback. Did I get it right or where you thinking of something else?

No, you're right - I needed to get some coffee and reread Component::Variation::Summary :)

Thank you!


JsonFormatter: Don't even try to attempt normalizing iterators or generators in context

Iterators and Generators may not be rewindable, so foreach is not safe
to use on them.
Iterators and especially Generators may trigger irreversible actions on
calling next(), so iterating over all values can potentially cause harm,
e.g. imagine an iterator over a set of HTTP POST requests that are sent
when the next value is requested . The only sufficiently safe thing to
iterate and include here are primitive arrays.
similar fix is applied to NormalizerFormatter: https://github.com/Seldaek/monolog/pull/891/files
It throws Exception : Cannot traverse an already closed generator vendor/monolog/monolog/src/Monolog/Formatter/JsonFormatter.php:152:
    public function getGenerator(): \Generator
    {
        yield 111;
        yield 222;
    }

    public function testNormalizeClosedGenerator()
    {
        $formatter = new JsonFormatter();

        $generator = $this->getGenerator();
        foreach ($generator as $i) {
            // Consume generator...
        }

        $res = $formatter->format(array(
            'level_name' => 'CRITICAL',
            'channel' => 'test',
            'message' => 'bar',
            'context' => array($generator),
            'datetime' => new \DateTime,
            'extra' => array(),
        ));
    }

Thanks for the updates


JavaScript client

Hi there!
We've started using the mahuta recently, and wrote a simple implementation of js client (right now it's not a separate lib, but rather the util, inherited from our common packages). So, in case you haven't started working on it - let me know.

Hi,
I haven't started yet so if you extract your code into a separate npm package, that would be a great contribution !
Thanks !
Greg
PS: Feel free to contact me


Kubelet TLS bootstrapping

This PR introduces an experimental feature for provisioning TLS certificates for worker nodes via the also experimental certificate signing requests workflow. Since this workflow is used by kube-adm, I think we can rest assured it won't be dropped anytime soon.
If RBAC is enabled in cluster.yaml, I also made sure to set up the appropriate cluster role bindings so that the token used for sending the certificate signing requests can only make requests related to certificate provisioning, as instructed by the official documentation.
Checklist:

[x] Add a kube-aws render token-file that creates a token auth file with a cluster TLS bootstrap (if the feature is turned on in cluster.yaml, or an empty file otherwise)
[x] Check whether the auth token file has a proper bootstrap token when the TLS bootstrap feature is turned on, and return a self-explaining message so the user knows what to do in order to fix the problem
[x] Read the bootstrap token from the auth token file and generate an encrypted version of it
[x] Send the encrypted bootstrap token in worker userdata
[x] Replace the decrypted token in the kubeconfig used for the TLS bootstrapping workflow
[x] Fix / add more tests wherever possible
[x] Manual tests

[x] Create clusters with TLS bootstrapping enabled and disabled
[x] Make sure it plays well with other experimental features (i.e. AWS node labels, node draining)
[x] Try to add worker nodes (and stop/start the kubelet on an existing node) to see if they can join the cluster without the need to manually approve every new certificate signing request

Closes #406.

Codecov Report

Merging #449 into master will increase coverage by 0.13%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #449      +/-   ##
==========================================
+ Coverage   41.02%   41.15%   +0.13%
==========================================
  Files          38       38
  Lines        2679     2685       +6
==========================================
+ Hits         1099     1105       +6
  Misses       1420     1420
  Partials      160      160

Impacted Files
Coverage Δ

core/controlplane/config/config.go
64.11% <100%> (+0.27%)
:arrow_up:

core/controlplane/config/tls_config.go
68.53% <100%> (+0.11%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f08f3b...43e938e. Read the comment docs.

Just when I thought I was almost done with this PR. 😅

I believe this PR is ready for review! 🎉
PS: This changes quite a few things, so please take your time to review this and let me know of any changes you guys think of to get this working as smooth as possible.
/cc @mumoshu

Thanks for efforts @danielfm!
First of all, regarding your comment, should we or do we need to translate this work with the bootstrap tokens after k8s 1.6?

This stuff just came out, so I'm still reading and learning how it compares to what I did here, but for now I think the bootstrap tokens might not be the ideal solution for kube-aws as it is for a few reasons:

Bootstrap tokens are new to Kubernetes 1.6, while the implementation in this PR can be used for 1.4.x as well; the only requirements are RBAC and CSR support.
If I understood correctly, the format used for bootstrap tokens ([a-z0-9]{6}\.[a-z0-9]{16}) don't follow the security guidelines outlined here, which states that a token, to be considered secure, should represent at least 128 bits of entropy. The implementation in this PR, on the other hand, generates tokens that satisfy this requirement.
Bootstrap tokens have an expiration date, after which the token will be no longer valid. This is nice for security reasons, but it might cause problems for less careful operators in more long-lived clusters. In this PR, the token is valid for as long as it's listed in ./credentials/tokens.csv, and the operator can rotate the token at any time by changing this file, without risking problems due to expired tokens when trying to scale the cluster up (or adding new node pools) at a later moment.
Bootstrap tokens' usage scope are defined by usage-bootstrap-* attributes (like authentication and signing), which for me doesn't make much sense since we can use RBAC to restrict (with greater flexibility) which actions can be performed on which resources.

That's my first opinion on this, but I'm eager to hear what you guys think.

@mumoshu et al: I updated my previous comment regarding the new bootstrap tokens feature in Kubernetes 1.6, let me know what you think.

LGTM 👍
Could you squash and rebase commits?

Just made a mess trying to squash the whole thing. 😅
Let me spend a little more time testing things to ensure everything is still working so you can merge.

@mumoshu fixed, and changed a few other minor things as well.
I also took the opportunity to test this PR with Calico enabled, which I forgot to do in my previous tests. I found a bug there, which I'm going to fix ASAP.

Okay, now apparently everything's working. 😄

LGTM. Thanks a lot for the great work @danielfm 👍


upgrade gems

will address deprecations in another PR

@macool needs a rebase

Note config/initializers/secret_token.rb changes need to also be made to the deployment files.


License?

package.json references LICENSE.txt which isn't present in the project.  Can you provide a license?

Add MIT license.


Fixes for 2.0

I'm leaving this as a draft until I get things fully working on my current project. Feel free to update master in the meantime, I'll just leave it draft if so.

I'm getting a hard thread exception on Heaps HL "Can't cast (void (dynamic,virtual<className:String,customParams:hl.types.ArrayDyn,fileName:String,lineNumber:i32,methodName:String>)) to (void (String))", so I'm gonna stop for now and check the diff

All working now on HL

Thanks for this! I'm on vacation right now, ill try to take a look at this soon.

When i tried the openfl sample project with HL on your branch I got this error after I clicked the start button:

SIGNAL 11
sys.ssl.$Certificate.loadDefaults(/usr/local/lib/haxe/std/hl/_std/sys/ssl/Certificate.hx:54)
sys.ssl.Socket.init(/usr/local/lib/haxe/std/hl/_std/sys/ssl/Socket.hx:128)
sys.net.$Socket.constructor(/usr/local/lib/haxe/std/hl/_std/sys/net/Socket.hx:130)
sys.ssl.$Socket.constructor(/usr/local/lib/haxe/std/hl/_std/sys/ssl/Socket.hx:102)
sys.Http.customRequest(/usr/local/lib/haxe/std/sys/Http.hx:108)
sys.Http.request(/usr/local/lib/haxe/std/sys/Http.hx:68)
io.newgrounds.utils.$AsyncHttp.sendSync(io/newgrounds/utils/AsyncHttp.hx:95)
io.newgrounds.utils.$AsyncHttp.sendThreaded(io/newgrounds/utils/AsyncHttp.hx:222)
sys.thread._Thread.$HaxeThread.~create.0(/usr/local/lib/haxe/std/hl/_std/sys/thread/Thread.hx:131)

this works fine on my master branch

I changed loaderData's (any:Any, ?pos:PosInfos)->Void (msg:String, ?pos:PosInfos)->Void and now I'm just getting SIGNAL 11
are you using latest lime/openfl/swf? are you testing on a personal project?
when i try on the test project with -Dsimple I get this error:

hl(72318,0x700009559000) malloc: Incorrect checksum for freed object 0x7fdba9086c78: probably modified after being freed.
Corrupt value: 0x3
hl(72318,0x700009559000) malloc: *** set a breakpoint in malloc_error_break to debug

also, I've only got my mac until Saturday

I'm using heaps HL, no openfl or lime at all.
If you're getting bytecode level errors for code that runs fine for me, and I get compiler errors for code that works for you, then I have to assume openfl is doing something weird.
If master works completely fine for you, I guess we have to ifdef these changes in some way? I don't get why even Timer doesn't error for you since that is just a normal int/float type check.

That commit breaks in heaps HL, so it's not something I want to add to the PR without an ifdef

I tried testing HL on my wndows device, got the following error:

../lib/Source/io/newgrounds/Call.hx:215: [Newgrounds API] :: Error: SSL - No CA Chain is set, but required to operate

All of the threads I can find regarding this seem out of date and unrelated
https://github.com/HaxeFoundation/hxcpp/issues/570
https://github.com/yupswing/akifox-asynchttp/issues/43

I was under the impression that the signal 11 error and malloc errors were introduced by these changes, however when I change logVerbose to (String, ?PosInfos)->Void, I get them in master as well. I'll just make a separate issue for that

Thanks again for this! I was worried these changes were too drastic and no one would want to upgrade to 2.0.0, so this gives me confidence.
That said, I still think I'm going to build a version 1.4.0, which is just 1.3.0 with the new external app_id feature, just in case people need that feature but don't want to migrate an entire project


Front home

navbar : adding loigin/logout
home.twig : top anime sort by vote number
details.twig : color, text center
signin/signout : color, text center (buttons are yolo)
panda's color !!!!!!

@FBanitz @mdumont67


Add option to disable showing progress in taskbar

PR for #164

Awesome! Thanks for submitting this.
I can't believe someone figured out the awful spaghetti code I have for adding one of these options.
(I fixed a couple of comments in f877f7d3d29d9cfa1c4d99d44a12167906e624bd, and made one minor adjustment in TimerWindow.xaml.cs.)


Bug on discrete messaging

Alcione has discovered a bug which causes occasional launch failures for discrete message input (of discrete agents). Code sent to Paul for testing.

This is not the same bug as the one effecting visualisation


AsciiMath support

AsciiMath support is now viable via the recently integrated LaTeX backend of asciidoctor/asciimath! Rendering AsciiMath blocks should now be as simple as transpiling the block to LaTeX and rendering it with Mathematical.
The only LaTeX command outputted by asciidoctor/asciimath which is not currently supported by Mathematical is \twoheadrightarrowtail. Solutions to this issue are discussed in https://github.com/asciidoctor/asciimath/pull/17#issuecomment-621939890 and https://github.com/asciidoctor/asciimath/pull/17#issuecomment-622411392.

A PR is welcome.

Could you help me figuring out which is the relevant section for this fix? Where are AsciiMath blocks processed?

The regex to parse inline stem is at  https://github.com/asciidoctor/asciidoctor-mathematical/blob/f81c3a0d3e4ea9fe10fa223010267b1239a030e5/lib/asciidoctor-mathematical/extension.rb#L9. You need to add one more for asciimath.
You need to handle asciimath stem blocks here at https://github.com/asciidoctor/asciidoctor-mathematical/blob/f81c3a0d3e4ea9fe10fa223010267b1239a030e5/lib/asciidoctor-mathematical/extension.rb#L72.
You need to handle asciimath inline macros here at https://github.com/asciidoctor/asciidoctor-mathematical/blob/f81c3a0d3e4ea9fe10fa223010267b1239a030e5/lib/asciidoctor-mathematical/extension.rb#L127.
The above three places shall be enough for asciimath support.

Alright. As soon as the new version of asciimath get's released I'll work on this changes (I've just realized the changes were merged to the masterbranch but they haven't being released to RubyGems yet).

Thanks for your contribution.

Fixed on https://github.com/asciidoctor/asciidoctor-mathematical/commit/d82041ddce64ea6014f3f3d613f3d5e6c4d257d3.


Fix sudo

Fixes https://github.com/ARM-software/devlib/issues/703
@marcbonnici Can you remember why we used a one-space prompt with sudo -p ' ' instead of a completely empty prompt ? This prompt seems to be picked up in stdout or stderr when using Target.execute(), modifying the return value as a result.

It seems that empty prompt used to not work at the time of Ubuntu 18.04:
https://serverfault.com/questions/967859/disable-sudo-prompt-without-disabling-the-need-for-sudo-password
I'll try to find what version is the cutoff date

It works on Ubuntu 20.04 at least, so the cutoff date is earlier than that

Just checked and I can confirm on my WSL 1 environment the bug is still present, however it does appear to be fixed when switching to WSL2.
Just to try and understand better, why was the additional space added causing a breakage here? Could the check to determine whether there are additional messages printed not ignore the single additional space?
However worst case, if we wanted to try and maintain compatibility with WS1 maybe we could default to the no prompt option and if this fails, try the spaced version before bailing?

Just checked and I can confirm on my WSL 1 environment the bug is still present, however it does appear to be fixed when switching to WSL2.

Thanks for checking, that's partly good news. Apparently WSL 1 is not dead though ...
https://learn.microsoft.com/en-us/windows/wsl/faq#what-will-happen-to-wsl-1--will-it-be-abandoned-

Just to try and understand better, why was the additional space added causing a breakage here?

execute() is supposed to be returning stdout + stderr. With as_root=True, it did not: it returned it with an extra space in front. As a baseline, having a different output just because we are root is not really acceptable for a command that is otherwise completely unaffected by permissions. For example we routinely end up adding an as_root=True to some commands that missed them, without necessarily revalidating everything. On top of that, we may not even be using sudo in some cases if we are already root AFAIR, so as_root=True may or may not add a space to the output.
I discovered this when modifying check_connection() to ensure that a command with no stdout and no stderr content actually returns an empty string (which was not the case, both because of that prompt and because of the password expiry printed by the PAM module in my case).

However worst case, if we wanted to try and maintain compatibility with WS1 maybe we could default to the no prompt option and if this fails, try the spaced version before bailing?

Honestly I don't think it's a good idea considering the above. The only other alternative I see is to postprocess the output to remove the prompt in case sudo was used (and precisely sudo, not just as_root=True), but if no prompt works that's even better.

Thanks for the information.

Thanks for checking, that's partly good news. Apparently WSL 1 is not dead though ...

I see, I'm not sure if there are still any requirements to use WSL1 over WSL2, I do vaguely recall there being some issues with WSL2 but these could have been fixed by now.

Honestly I don't think it's a good idea considering the above. The only other alternative I see is to postprocess the output to remove the prompt in case sudo was used (and precisely sudo, not just as_root=True), but if no prompt works that's even better.

Makes sense, I can't think of another option to maintain the compatibility other than post processing either. The only other options would be to require the use of WSL2 but that also wouldn't be ideal if WSL1 is being kept around.

Do we actually care about WSL at all ? If not, it could make sense to just use -p '', and if one day we do want to add explicit support for it, we can revisit and add the post processing where needed, especially if the error from sudo is obvious.

That's a fair comment, I guess the real world scenarios where the target platform is required to be WSL(1) is likely very limited. Just for the background, the issue was originally found when running the devlib test suite from WSL (which creates a localtarget) as opposed to an actual use case.
As you say, perhaps just documenting this issue might be the cleaner option.

@marcbonnici Is there a specific place you'd see to document that ? I don't think there is any list of officially supported targets in devlib ATM

True... Looks like we don't really have a good place for this in the current documentation. Perhaps we might need to make do with some comments in the code next to the default prompt and a summary of this discussion in the commit message so at least if we need to revisit this in the future there is a simple way to determine a potential issue and what a solution could be?

PR updated with inline comments and more details in the commit message


Merge PyUtils into ITKCommon module

There is no need for this to be a special module,
which complicates its build setup. Closes #5027.
PR Checklist

[x] No API changes were made (or the changes have been approved)
[x] No major design changes were made (or the changes have been approved)

The latest force-push is a plan rebase on master.


ResourceImporterLayeredTexture: rename compress modes to match enum

It's sort of misleading to leave it like it is right now.
Lossless won't necessarily use PNG, Lossy won't necessarily use WebP, Uncompressed is VRAM.

For reference, this PR matches ResourceImporterTexture: https://github.com/godotengine/godot/blob/4dc2c8ae6fe954f8c5c6627803f0a087ee1a2488/editor/import/resource_importer_texture.cpp#L218

Yes, I've been touching both files for a while.


How to get filestream from user sended audio or image files?

Hey there.
Is there any way to get the posted filestream from the user.
I wanna get audio file and process it.

Currently that's not possible.

see
https://twitter.com/telegram/status/614468951926509568

Thank you MrRoundRobin.


Set explicitly the type button for buttons.

When the editor is in a form the search buttons will submit the form.

Good idea. There's also the close button, which isn't created through the button function.
And don't put your release note in the changelog—put it in a FIX: ... line in the commit message.

Thanks. Just one more nitpick: Please use double quoted strings.

Woops I missed this close button. fixed.

Also is it possible to release a patch version for 0.18?
The version 0.19 of codemirror works fine in the browser but for an obscure reason it makes the CI stuck in an infinite loop (jest + testing-library). I'll come with a more detailed investigation on your discuss website as soon as possible.

Sorry, I'm not backporting changes to previous releases at this point.


Testing Mounted Engine request.path_info Improperly Set

Ruby version: ruby 2.6.3p62
Rails version: rails 5.2.3
RSpec version: RSpec 3.9
Observed behaviour
When testing mounted engines in an application:
application's config/routes.rb:
Rails.application.routes.draw do
  mount PseudoKiosk::Engine => "/test"
end

engine's config/routes.rb:
PseudoKiosk::Engine.routes.draw do
  namespace :pseudo_kiosk do
    get 'authentication/unlock'
  end
end

I am creating controller and request specs:
# this is a controller inside the engine
RSpec.describe PseudoKiosk::AuthenticationController, type: :controller do
  routes { PseudoKiosk::Engine.routes }

  describe "GET #unlock" do
    it "returns http success" do
      get :unlock, params: {}
      expect(response).to have_http_status(:success)
    end
  end
end

In the app, when I check for request.path_info, I get: /pseudo_kiosk/authentication/unlock.
Expected behaviour
I expect to be getting the engine properly namespaced through the mount syntax, but I am not receiving the expected /test/pseudo_kiosk/authentication/unlock for the request.path_info within the controller.
Can you provide an example app?
https://github.com/jonmchan/pseudo_kiosk/blob/8600321a702c9c6b0d418f04064099cc5e29bc72/spec/controllers/pseudo_kiosk/authentication_controller_spec.rb
You can utilize the pry breakpoint at https://github.com/jonmchan/pseudo_kiosk/blob/8600321a702c9c6b0d418f04064099cc5e29bc72/lib/pseudo_kiosk/controller.rb#L18 and inspect the request.path_info to view the issue.
As a current workaround, I am mount PseudoKiosk::Engine => "/" to get around the issue and make my tests pass.

I think you'll find your issue is this:
routes { PseudoKiosk::Engine.routes }
If your engine is installed in your app, your apps routes will contain the engines routes, and thus you don't need to override them.

@JonRowe Thanks for your reply. I had to add that line in because it couldn't find the routes when I ran the test without it:
ActionController::UrlGenerationError:
       No route matches {:action=>"process_submit", :controller=>"pseudo_kiosk/authentication", :passcode=>"swordfish"}

However, my bin/rails app:routes show:
$ bin/rails app:routes
                                          Prefix Verb URI Pattern                                                                              Controller#Action
...
                             pseudo_kiosk_engine      /                                                                                PseudoKiosk::Engine
...

Routes for PseudoKiosk::Engine:
        pseudo_kiosk_authentication_unlock GET  /authentication/unlock(.:format)         pseudo_kiosk/authentication#unlock
pseudo_kiosk_authentication_process_submit POST /authentication/process_submit(.:format) pseudo_kiosk/authentication#process_submit

Basically when you override the routes, you need to use the sub route to get it to match, if you don't, you need to provide the context in which it is mounted to get it to match. I'm not sure how rails expects you to provide the later, but I suggest you use the former and not worry about what the path shows in the tests (which are now independant of where they are mounted).
If you truely need integrations tests for your engine within your app, then remove the route override, and use get "/path/to/controller" rather than trying to autogenerate.

@JonRowe the issue I am having is the engine I am creating is a security gem which checks endpoints against a whitelist. Somehow, the code in working within the engine to generate the whitelist using the proper named routes ( PseudoKiosk::Engine.routes.url_helpers.pseudo_kiosk_authentication_unlock_path generates  /pseudo_kiosk/authentication/unlock ), however the request.path_info populated by rspec is (/authentication/unlock). My gem sees that as an endpoint not in the whitelist and blocks that route.
I am not trying to test the engine in an app, I solely am trying to use a dummy app within the spec folder mount the engine and properly test the engine.

Trying to manually specify the route still won't work:
Failure/Error: get '/pseudo_kiosk/authentication/unlock'

     ActionController::UrlGenerationError:
       No route matches {:action=>"/pseudo_kiosk/authentication/unlock", :controller=>"pseudo_kiosk/authentication"}

Ah that might only be available in a proper integration / request spec rather than a controller spec. Controller tests are soft-deprecated by the Rails team and this is one of the reasons why.

@JonRowe that's important to note... if I was to convert all these tests to request specs, the issue I was running is I don't have direct access to the session. Is there a recommended workaround for that or am I to be making getter and setter endpoints to read and write to the session variables I need? Seems sorta clunky, especially since I would have to make sure everything can be serialized/deserialized properly.
Thanks for your input - I appreciate it.

If you're happy with controller tests I suggest going back to your original configuration and accepting that the path will be the subpath and not the full path. Engines shouldn't depend on their mount points anyway?

Closing because this is a "configuring Rails" issue we're not able to do much about, happy to get providing help here.

accepting that the path will be the subpath and not the full path

That's hard for me to do because it fails in checking if the endpoint is on the whitelist.
See:
https://github.com/jonmchan/pseudo_kiosk/blob/3b01585027cb7a01c6ed06fd84e61fede7dc42ee/lib/pseudo_kiosk/controller.rb#L24-L35
The engine generated urls does not match the path_info from the request.
The workaround I have achieved is setting the engine mount point to be / so subpath and full path are equal.
I opened an issue here because I feel this issue makes controller testing engine mounted controllers impossible if the mounted controller does any calculations with the pathinfo. It sounds like this can't be fixed directly in rspec-rails but has to addressed by the underlying rails controller. Since controller testing is soft-deprecated, I'll just leave all this information here in case someone else runs into this issue.

I think you have overlooked something here, its possible to mount an engine multiple times at different endpoints, so you need to account for that which would also fix this for you. I'm not sure you should be trying to introspect the path in this fashion, if you are trying to secure various controller/action combos you are better off using those parts rather than the string url. Just my 2¢.

Good point, I'll secure these engine endpoints by controller and action. Thanks!


Refactor/Rewrite: garden-feat.go in Python

What would you like to be added:
garden-feats.go is the only script which is written in Go. Garden Linux mainly uses Shell or Python. Therefore, we should rewrite this one in Python. However, this script is only used by users while a redundant code is already used by the Tekton pipeline which is written in Python. As a result, we should write this script to run standalone and to be importable by other Python scripts.
Why is this needed:

Getting rid of Go

No further needs for creating Go build container
No more issues obtaining Go modules

Less issues while building artifacts
Less time for building a Garden Linux artifact from scratch
Language consistency
Remove code duplication

complex topic
testcases would be appreciated :-D

Okay, inlcuded PyTest with tests for all positional args including options:
Test: https://github.com/gardenlinux/gardenlinux/pull/1152/files#diff-db06df5f8476a253cb2f079048139dd22abe9d1a2395bd1de80e4efb21d7cbf4
Test-Params: https://github.com/gardenlinux/gardenlinux/pull/1152/files#diff-efcdc7c50b481b6040954943d437bdd0702882b7d5ac88b7a0274936b613f95f


Fix Bug with Missing First Node

Description
While testing PyCG-Stitch by executing the micro-benchmark, I noticed that on the produced output:
{
  "edges": [
    [0, 1],
    [2, 3],
    [2, 4],
    [2, 5],
    [3, 6],
    [4, 7],
    [5, 8]
  ],
  "nodes": {
    "1": {
      "URI": "fasten://trans-dep2$1.0/trans_dep2.trans_dep2/smth()",
      "metadata": {}
    },
    "2": {
      "URI": "fasten://root$1.0/root.root/",
      "metadata": {}
    },
    "3": {
      "URI": "fasten://root$1.0/root.root/A.fn()",
      "metadata": {}
    },
    "4": {
      "URI": "fasten://root$1.0/root.root/func2()",
      "metadata": {}
    },
    "5": {
      "URI": "fasten://trans-dep1$1.0/trans_dep1.trans_dep1/ClsPar.__init__()",
      "metadata": {}
    },
    "6": {
      "URI": "fasten://dep1$1.0/dep1.dep1/Cls.dep_fn()",
      "metadata": {}
    },
    "7": {
      "URI": "fasten://dep2$1.0/dep2.dep2/func()",
      "metadata": {}
    },
    "8": {
      "URI": "fasten://trans-dep1$1.0/trans_dep1.trans_dep1/fun()",
      "metadata": {}
    }
  }
}

The node 0 of the call graph was missing from the nodes list.
After some investigation, I noticed that this happends due to a bug.
More specifically, we have a dictionary  named node_to_id which has as a key all the strings of the unique nodes (modules) and as value a unique integer id, which is auto-incrementing.
On the _assign_id() method:
https://github.com/fasten-project/pycg-stitch/blob/ed5d10957c48924d54bc138773031f4facc46c27/stitcher/stitcher.py#L151-L154
We check whether a node exists on the dictionary, and if not we add it by assigning to it a unique id.
Therefore, the method self.node_to_id.get(node_str, None) returns an integer if it finds the specified node, or None otherwise.
In order to check whether the string exists, we use the if not operator:
https://github.com/fasten-project/pycg-stitch/blob/ed5d10957c48924d54bc138773031f4facc46c27/stitcher/stitcher.py#L152
The problem is, that in Python,  zero values are false and non-zero values are true.
Therefore, if the node with id equal to 0 is revisited at some point, the if statement will be true, meaming that the program will falsely assume that the node does not exist in the dictionary, and consequently it will erase it and assign to it a new id.
Therefore, in order to fix this issue, I modified the if statement to check whether the method self.node_to_id.get(node_str, None) returns None or not, in order to keep the node having id equal to 0.

Nice work, LGTM


[Proposal] Add some type of look-behind support

Is your request related to a specific problem you're having?
Yes, there is no easy way to do look behind or to say:

match this, but only if immediately proceeded by that...

 For example here's how to match say instanceof [class] and do it with no ambiguity: (where [class] is the only part I want highlighted)
      {
        begin: regex.concat('(?=', /\binstanceof /, IDENT_RE, ')'),
        contains: [
          { begin: /\binstanceof /,
            keywords: KEYWORDS,
            starts: {
              contains: [
                { begin: IDENT_RE, className: "title"}
              ],
            }
          },
        ],
      },

First we match the whole thing with a look-ahead... then our mode starts and our first rule has to re-include keywords from above (because now the context has changed), and then we have to match instance of and then start a new mode [for IDENT_RE] with starts to avoid the chance of our two expressions being similar enough that the first rule might fire for the second.
The solution you'd prefer / feature you'd like to see added...
Well if JS just supported look behind, we'd be all set but since it doesn't... Sample code from Javascript we're trying to match:
if (str instanceof Token) { ...
// and
var token = new Token()

And how we might go about doing it:
 {
  skipBefore: /(\binstanceof[ ]+)/,
  begin: IDENT_RE,
  className: "title"
}, {
  skipBefore: /(\bnew[ ]+)/,
  begin: IDENT_RE,
  className: "title"
},
// and for comparison: look-ahead, which is already possible;
{
  begin: regex.concat(IDENT_RE, /(?=\.(constructor|prototype))/),
  className: "title"
},

This is actually only a 5 line patch. Building this into the parser means the mode context doesn't change, so your existing keyword scope "just works"... and these become very simple rules.
Potential Caveats

It might have interactions with returnBegin... I'm not sure why you'd ever want to use them both... but we could either:

have returnBegin disable skipBefores "skip" ability, making it more of a "prefix"
throw an error for grammar developers and just say these two things don't mix.

The naming isn't perfect... technically this is matchBeforeAndSkip... I hesitate to name it lookbehind though because that's NOT what it's doing... it's still looking forward the whole time.  If another rule has consumed the content already this can't match it by "looking backwards", because there is no backwards looking going on.

Any alternative solutions you considered...
Writing code to write the complex version... but the keyword complexity and mode context switches make it a pain even if you had a helper, since you'd still have to pass in KEYWORDS from the parent context (as far as I can see)...

CC @egor-rogov  @allejo
I started working on this after seeing how trivial some of these types of things are to do in Prism and how hard they are to do in Highlight.js.  Prism calls this feature lookbehind.

Ping. CC @egor-rogov @allejo

It seems it would be nice to have some sort of look-behind / skip-before. The code snippet above makes sense for me.
Do you have some real use cases in mind?

The two cases shown above are all real.   new instanceof which in JS indicate that what follows is a class or class like constructor function (which we could then highlight with title).  I'm pretty sure this will have real applications everywhere in so many languages.

https://github.com/highlightjs/highlight.js/pull/2680#issuecomment-707718580
\b boundary x 8,682 ops/sec ±1.25% (84 runs sampled)
negative lookbehind x 8,353 ops/sec ±1.52% (84 runs sampled)
hack with begin/end x 8,047 ops/sec ±0.56% (89 runs sampled)
with callback x 3,244 ops/sec ±0.64% (94 runs sampled)

Referencing some tests done elsewhere... Seems a manual implementation based on callbacks would be ~50-60% slower than the real thing.

Now I'm wondering about the possibility of a lookbehind that we compiled into either an ACTUAL lookbehind or a virtual lookbehind...
{
  lookbehind: [ /\bnew[ ]/, 4],
  lookbehind: { match: /(\bnew[ ]/), length: 4/ },
  lookbehind: "new ",
  lookbehind: {literal: "new "} ,
  begin: IDENT_RE,
  className: "title"
},

We need the length because look-behinds typically need to be "pinned" (so they know the scope that they are working within).  A real regex engine analyzes the regex to determine the length, but I don't think we want to attempt that, so it would be necessary to specify the look behind length... OR perhaps if a string was provided we could assume a literal vs regex... though that would be different than how we typically handle strings.

Now I'm wondering about the possibility of a lookbehind that we compiled into either an ACTUAL lookbehind or a virtual lookbehind... Safari is the only major engine right now that would need the virtual look-behind.

You caught my attention with this. How do envision this working?  So a function checking the browser support and returning a native regex with the lookbehind built-in or a hack otherwise?
{
  // it's not clear what the 4 means in this case
  lookbehind: [ /\bnew[ ]/, 4],

  // please tell me this is a typo
  lookbehind: { match: /(\bnew[ ]/), length: 4/ },

  // you have my vote for this if this \/ is how it's ^ supposed to look
  lookbehind: { match: /(\bnew[ ])/, length: 4 },

  // meh...
  lookbehind: "new ",
  lookbehind: {literal: "new "} ,
  begin: IDENT_RE,
  className: "title"
},

I'd prefer verbosity over simplicity. Language authors should know exactly what they're doing with the lookbehind, make them look up the spec and at least see the warning of a possible performance hit by using this feature.

 So a function checking the browser support and returning a native regex with the lookbehind built-in or a hack otherwise?

Yep. If you call using a callback function to perform the look behind a hack.

Then I like that solution. We shouldn't wait for Safari to catch up with the other two major browsers just for this feature.

I just worry about someone writing a grammar naïvely and then it being 20 times slower in safari than anywhere else. 😬￼

What about adding a console warning when debug mode is activated and lookbehind is used on a browser that doesn't support native lookbehinds?

No guarantee the person is even testing on Safari... I think the problem is that unless you really understand the engine it might just be too easy to write such a poor performing look-behind... so even if we spewed the warning everywhere someone isn't going to be able to figure it out or just ignore it and go "well it's fast enough"... now we can sort of guard the core library with detailed PR review but 3rd party languages that worked great but then randomly failed terribly on Safari isn't a great thing to create the possibility of.
There is a whole other approach here that involves rewriting some internals of the engine but seems like a poor idea given this is only a momentary problem and eventually time is going to fix it.

I agree that writing poor lookbehind code would be too easy. My only thought is do we keep blocking lookbehind support until Safari has support? Once the latest version of Safari has support, do older macOS versions upgrade or do they continue using older versions of Safari? i.e. Will there still be a longish delay while we wait for all Safari users to catch up or do we just break older Safari support at that point?

I think if the operating system is still supported then it still getting safari updates.
But as far as exactly how long we wait I think we first need to see what the landscape looks like when safari finally adds support. ￼￼￼

I think we should consider codifying this into a fakeLookbehind helper using just skip and starts.  It's not a true look-behind of course - it's a look-forward... but it works in any cases where there are no other rules eating the prior content... and this is almost exactly how we already do it in all the cases where it's hard coded.
IE:
hljs.fakeLookbehind{
  behind: "booger ",
  begin: "picking"
}

Which just compiles into a "first, then" style mode:
{
  begin: "booger ",
  starts: {
    contains: [
      begin: "picking",
      endsParent: true
    ]
}

And using starts and endsParent would be off-limits for lookbehind modes and be a hard error.  Though I wonder if we could find a better name than fake look-behind?

R language has support for this now but it hasn't made it into the core compiler yet.


Get quantity from text input

When user enters ex: 6 apples, have apples be displayed in the new item, and 6 in the quantity field.

Implemented.


haskellPackages.feedback: Fix build

This is for merging into haskell-updates (PR #331380).
It fixes the build of the feedback utility. cc @NorfairKing.

[x] PR #333379 needs to be merged before this one.
[x] nix build .#haskellPackages.feedback works on x86_64-linux.
[x] ./result-bin/bin/feedback "nom build .#haskellPackages.feedback" command works as expected.

@rvl :heart: do you need anything from me?

Just a FYI courtesy ping @NorfairKing.
But actually, does the feedback tool have an auto-generated man page?

@rvl Not yet, once it starts using opt-env-conf, it will :)

Thank you!


fix(FN-2123): fix off by one csv row error

Introduction :pencil2:
Errors when submitting csv files were off by one when reporting the row the error happened on.
Resolution :heavy_check_mark:
Fix off by one error, accounting for both the index starting at 0 and the header column taking up the first row.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (eeb7eb7) 27.22% compared to head (84142c4) 23.01%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2693      +/-   ##
==========================================
- Coverage   27.22%   23.01%   -4.22%
==========================================
  Files        1290      613     -677
  Lines       29873    14975   -14898
  Branches     4864     1957    -2907
==========================================
- Hits         8134     3447    -4687
+ Misses      18914    10423    -8491
+ Partials     2825     1105    -1720

Flag
Coverage Δ

api-test
?

ui-test
91.78% <ø> (+27.27%)
:arrow_up:

unit-test
7.04% <ø> (-3.25%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Avoid CommonJS in Cycle DOM codebase

To better support tree-shaking tools that assume ES2015 modules.

Can you provide some more context here? Maybe an instance of CommonJS usage that you want to get rid of...

basicly replace any require call with es6 imports
basicly just cloning the repo, grepping for require (i suggest the_silver_searcher), editing those files

Thanks, @jvanbruegge! I did a quick grep and it seems like there are more than 14k occurrences.
I'll see if I can come up with a sed script or something and report back.

btw, I don't know if github allows it, but... Can you assign this issue to me?

you have to limit the search to src folders

Indeed: most occurrences were inside dom/node_modules. I couldn't find any occurrence under dom/src. Maybe this issue is already solved?

Indeed: most occurrences of require were inside dom/node_modules. I couldn't find any under dom/src, though.
Maybe this issue is already solved?

Can't find any occurrences of exports either...

Did a git bisect and the last require statement went down with commit f459adaf51. This issue is probably stale.

did a quick ag search, this is the result:
ag require --ignore node_modules --ignore examples/ --ignore yarn.lock --ignore docs --ignore test --ignore lib --ignore package.json
html/src/makeHTMLDriver.ts
5:const init: Init = require('snabbdom-to-html/init');
6:const modulesForHTML: ModulesForHTML = require('snabbdom-to-html/modules');

jsonp/src/index.ts
4:import jsonp = require('jsonp');

devtool/src/panel/view.ts
14:    p('This DevTool requires that your app is built using the following ' +

devtool/README.md
11:This DevTool requires that your app is built using the following packages:

dom/CHANGELOG.md
23:* **dom:** switch from require() to import statements for es6 map polyfill ([f459ada](https://github.com/cyclejs/cyclejs/commit/f459ada))

time/src/mock-time-source.ts
14:const combineErrors = require('combine-errors');

time/src/scheduler.ts
2:const makeAccumulator = require('sorted-immutable-list').default;

time/src/time-driver.ts
11:const requestAnimationFrame = require('raf');
12:const now = require('performance-now');

time/src/assert-equal.ts
3:const variableDiff = require('variable-diff');

time/src/run-virtually.ts
1:require('setimmediate');

http/src/index.ts
15: * - `url` *(String)*: the remote resource path. **required**

Oh, right... I thought the issue was limited to cycle dom...
Will take a look at that!

So far I've tried changing
const combineErrors = require('combine-errors');

to
import combineErrors from 'combine-errors';
As I understand, this is the equivalent CommonJS/TS syntax for importing the default export from combine-errors and naming it combineErrors. But I keep getting this error:
Could not find a declaration file for module 'combine-errors'

I'm not sure what I'm supposed to do here. Judging from the Typescript docs it seems like one can add a .d.ts file to some kind of type definitions repo so that it becomes possible to say
npm install --save @types/combine-errors

I'm still learning both ES6 and TS. Maybe I'll be able to come back to this once I level up some more.
If anyone else wants to grab this, please do.

@thiagoarrais
To import a commonjs default export in typescript the format is actually neihter that you tired :) See the modules docs for TS
import combineErrors = require('combine-errors');
The error indicate the file cannot be found and as you did't prefix your file path with .\ I'm pretty sure it will be copying node lookup and it will looking for the file in node_modules. Perhaps that is not correct?
If the file is is plane js then yes, you will need to provide a .d.ts to give what they call "ambient declations" for the types. There are various approaches for doing that. but if it is a npm module try making types@combine-errors a dependency. If that is part of cycle (or extras) the types are there

In this specific case, combine-errors is an external npm module. Here it is. I guess this is also the case for every other occurrence of CommonJS requires. I've also tried to install the corresponding @types depencency with no success...
:disappointed:

How can I test the use of tree shaking tools with Cycle.js? I've found the webpack guide, but I can't easily see how to use it.

There is the bundleAnalyse plugin and the stats plugin. The stats can be used to see the module dependencies. See my polyfill WIP PR

But tree shaking is broken ATM, also see the PR

How can we demonstrate that tree shaking is broken? Can you give me a one-liner for that? (Remember I'm a JS/TS newbie)

Import the time driver from @cycle/time, webpack removes the mockTimeSource but still pulls in all dependencies of the mockTimeSource

So I guess this is done now?

@staltz I don't think this is fixed.  I'm having trouble with a very basic rollup project, even when using rollup-plugin-commonjs.  The culprits are those require calls.

@micahscopes: I have made a PR that removes all usages of require from the @cycle/time codebase. https://github.com/cyclejs/cyclejs/pull/761
After that is merged hopefully Rollup will work.

@micahscopes<EMAIL_ADDRESS>is now released with no more require calls, let me know if this solves your problem 😄


pg_cron: 1.0.2 -> 1.1.2

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/pg_cron/versions.
meta.description for pg_cron is: '"Run Cron jobs through PostgreSQL"'.

Checks done (click to expand)

built on NixOS

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

directory tree listing: https://gist.github.com/46824f2e25d7a95d0d6ff058fa89ddbe

du listing: https://gist.github.com/bc77d65dac723ec9b9578b0fdad72534

Instructions to test this update (click to expand)

One-time optional setup to skip building using Cachix:
nix-shell -p cachix --run 'cachix use r-ryantm'

Test this update by entering a nix shell, seeing what is inside the
result, and if applicable, running some binaries:
nix-shell --pure -I nixpkgs=https://github.com/r-ryantm/nixpkgs/archive/170c6104b66c8f5a12314ee96121876862182901.tar.gz -p pg_cron
ls -la /nix/store/mw5kjcbwfd656y80mnxlg8r9vvl5jz3a-pg_cron-1.1.2

cc @thoughtpolice for testing.

No attempt on x86_64-darwin (full log)
The following builds were skipped because they don't evaluate on x86_64-darwin: pg_cron
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

Success on x86_64-linux (full log)
Attempted: pg_cron
Partial log (click to expand)
cat pg_cron.sql pg_cron--0.1--1.0.sql > pg_cron--1.0.sql
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/mw5kjcbwfd656y80mnxlg8r9vvl5jz3a-pg_cron-1.1.2
shrinking /nix/store/mw5kjcbwfd656y80mnxlg8r9vvl5jz3a-pg_cron-1.1.2/lib/pg_cron.so
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/mw5kjcbwfd656y80mnxlg8r9vvl5jz3a-pg_cron-1.1.2/lib
patching script interpreter paths in /nix/store/mw5kjcbwfd656y80mnxlg8r9vvl5jz3a-pg_cron-1.1.2
checking for references to /build in /nix/store/mw5kjcbwfd656y80mnxlg8r9vvl5jz3a-pg_cron-1.1.2...
/nix/store/mw5kjcbwfd656y80mnxlg8r9vvl5jz3a-pg_cron-1.1.2

Success on aarch64-linux (full log)
Attempted: pg_cron
Partial log (click to expand)
cat pg_cron.sql pg_cron--0.1--1.0.sql > pg_cron--1.0.sql
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/94sxxahy36pafsc9fcrkxjbx9yqwl0f8-pg_cron-1.1.2
shrinking /nix/store/94sxxahy36pafsc9fcrkxjbx9yqwl0f8-pg_cron-1.1.2/lib/pg_cron.so
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/94sxxahy36pafsc9fcrkxjbx9yqwl0f8-pg_cron-1.1.2/lib
patching script interpreter paths in /nix/store/94sxxahy36pafsc9fcrkxjbx9yqwl0f8-pg_cron-1.1.2
checking for references to /build in /nix/store/94sxxahy36pafsc9fcrkxjbx9yqwl0f8-pg_cron-1.1.2...
/nix/store/94sxxahy36pafsc9fcrkxjbx9yqwl0f8-pg_cron-1.1.2


Types not being found

Current Behavior
Cannot find type modules after basic initial installation. VSCode shows squiggly lines under .$types
Error: Cannot find module './$types' or its corresponding type declarations.
Reproduction / Steps To Reproduce
This error does not happen using:
npm create svelte@latest my-app
Brand new install using skeleton caused issue:
npm create skeleton-app@latest my-skeleton-app
Add basic route file:
<script lang="ts">
	import type { PageData } from './$types';

	export let data: PageData;
</script>

Error: Cannot find module './$types' or its corresponding type declarations.
Anything else?
I have tested this in a couple different installs, and they are all the same, posted to Svelte Discord with no suggestions.

I didn't npm install and then start my server. Starting the server after an npm install cleared out the errors.

@aunumever this one bit me yesterday as well, running the server will solve it! Thanks for sharing the solution to help others!


New package - FiberUIPrimitives

A new package that create primitive UI components, that exposes functionality, but no visual representation of the UI components.

This is started and implemented under the Fiber.InteractiveUI package.


how can i make multiple select filter on datatable?

Hello,
I did a filter clear that clears the total table filter values:
https://stackblitz.com/edit/clear-allfilter?file=src/app/app.component.ts
I would be wondering how I can do a custom filter, by adding an option to delete all filters? - I need both them

Hello there - could you create a repro from one of our starters: https://cds.wtf/
Add more information about what you're trying to do and what you've tried and we can try and help.

Hello there - could you create a repro from one of our starters: https://cds.wtf/
Add more information about what you're trying to do and what you've tried and we can try and help.

Done

Thanks for the reproduction.
Please use updateFilterValue instead of filterValue. That's what's bound to the clrFilterValue input.
Like this:
clearFilter() {
    this.columns.forEach((column) => (column.updateFilterValue = ''));
}


SystemServices json & md files updated as per code

Documentation enhancement for SystemServices plugin
Jira Link: https://ccp.sys.comcast.net/browse/RDK-35198

Result of "getLastFirmwareFailureReason" method contains "failReason", not the "failureReason".
"getStoreDemoLink", "fileURL" should be removed from "required", since it depends on STORE_DEMO_FILE existence, otherwise there will be "error".
"getTimeZones", there is "zoneinfo" in the response, not "zoneInfo".
"deletePersistentPath", looks like it takes "callsign" or "type" parameters, but there is "callsign" in "required".


Update 'breakpad' to 0.0.0-12ecff3-p2

I've followed this guide
step by step carefully. [Yes]

I've tested this package remotely and have excluded all broken builds.
Here is the links to the Travis/AppVeyor with status "All passed":

https://ci.appveyor.com/project/FredrikAppelros/hunter/builds/24088366
https://travis-ci.com/FredrikAppelros/hunter/builds/109562970

This update will break few old toolchains.
They are excluded in this pull request: https://github.com/ingenue/hunter/pull/360

Testing:

https://ci.appveyor.com/project/ingenue/hunter/builds/24089977
https://travis-ci.org/ingenue/hunter/builds/524392098?utm_source=github_status&utm_medium=notification

Uploading:

https://ci.appveyor.com/project/ingenue/hunter/builds/24091249
https://travis-ci.org/ingenue/hunter/builds/524411331?utm_source=github_status&utm_medium=notification

Released: https://github.com/ruslo/hunter/releases/tag/v0.23.163


Properly load config file

The global variable holding the configuration was shadowed in the method that loades the configuration file. Hence, the configuration file was never applied.

Yes, we can. Unfortunately, testing cobra is a bit involved and i wanted to get this fix in immediately. We can copy test setup for cobra from crs-toolchain.


Refs #30581 -- Allowed sql.Query to be used without model.

buildbot, test on oracle.

Maybe the allow_joins thing was actually for oracle? I don't know enough about oracle to tell about it though.

Maybe the allow_joins thing was actually for oracle? I don't know enough about oracle to tell about it though.

No, it's sth different. It seems that generated SQL is not valid on Oracle, I will check it tomorrow.

@Gagaro Oracle doesn't support boolean expressions in the SELECT clause, so we need to wrap it with CASE WHEN expression. I fixed tests.

buildbot, test on oracle.

@Gagaro Oracle doesn't support boolean expressions in the SELECT clause, so we need to wrap it with CASE WHEN expression. I fixed tests.

Awesome, thanks for looking that up.


Won't authenticate in DoneSSR

This line prevents can-connect from ever authenticating in done-ssr, therefore pages are rendered without authentication, even if user's cookies are provided to done-js.

I'm not sure if we can just prevent setJWT from saving the internal state though.  app.accessToken gets set so that service hooks can run correctly on the client. If, for instance I prevent the app from ever setting accessToken none of my service requests will work because the hooks will prevent this.
In my test app you can see the issue arise if you add this to the application.js set method:
(public/node_modules/@feathersjs/feathers/lib/application.js:35)
    set (name, value) {
        if(name === 'accessToken' && window.doneSsr){
            debugger;
            return this;
        }
        this.settings[name] = value;
        return this;
    },

If you add that does it fix the cookie issue?

Yes, that does fix the issue, where users are getting mixed up. But donejs is unable to access any data from the api's since its not properly authenticated in feathers.

Okay, I think I have a solution. Its a relatively simple fix in feathers-authentication.
In populate-access-token,
Object.assign(hook.params, { accessToken: app.get('storage').getItem(app.passport.options.storageKey) });

in passport:
remove references to app.set and app.get accessToken


Add some more tests for Rewards

What was wrong?
Fixes Issue #1315
Cute Animal Picture

@cburgdorf please review. Thankyou.

I assume that all of the numbers here were simply derived from what the existing code produces (which is fine, just checking).  This strikes me as the type of thing that we could contribute upstream.  cc @lithp as a use case for upstream contributions to the ethereum/tests repo.

@pipermerriam yes these numbers were generated by the current existing code. But I did verify a few based on the block rewards as to see whether the numbers are matching are not.

Cool, I'd like to wait for @lithp to review this and give his thoughts on whether these tests would be better suited for a fixture based approach.  If that was the case this will be an ideal time for us to streamline the manner in which such fixtures are generated and I expect the existing code you've written will get re-used in some form.


Output Unification

📚 Context
Currently, the off-chain machine is able to generate two types of outputs: vouchers and notices. On-chain, these outputs can be validated by anyone with the help of validity proofs.
The proof consists on reconstructing the epoch hash and comparing it with the epoch hash that was claimed by the DApp's consensus. If they are equal, then we can be sure the output is valid.
Currently, this epoch hash is composed by the following components.

The machine Merkle root hash
The voucher Merkle root hash
The notice Merkle root hash

As you can see, vouchers and notices each have their own separate Merkle tree. This helps to avoid misinterpreting notices as vouchers and vice versa.
There are, however, two main issues with this design. First, it unnecessarily complicates the on-chain and off-chain code. Second, it hinders the implementation of new output types, since we would have to add a new Merkle tree, which would result in a breaking change in the validation procedure.
✔ Solution
And so, we noticed that things would be much simpler if we had a single tree for all outputs. To differentiate between output types, we could add a prefix to each output. For example, 0x00 for vouchers and 0x01 for notices. As a result, the epoch hash would only be composed of two components:

The machine Merkle root hash
The output Merkle root hash

Now, from the perspective of the machine, outputs can be thought of as arbitrary blobs. You will be able to tell them apart by the first 4 bytes, which correspond to the function selector of the function call. How this will be reflected on the HTTP API is still under discussion, but some options are:

The generic approach: outputs are blobs.

Pros: Extensible.
Cons: User must encode outputs.

The typed approach: outputs are either notices or outputs or [...]

Pros: User-friendly.
Cons: Forbids users to emit new types of outputs.

The mixed approach: outputs are blobs, which can be notices or outputs or [...]

Pros: User-friendly and extensible.
Cons: User needs to encode outputs not covered by the API.

Given that this changes the public API that devs use, maybe it would be nice to consider inputs from the Prototyping and DevAd units. @cf-cartesi @gbarros would you like to comment?

Encoding and decoding outputs in Solidity
So, recently I discovered a nice idiomatic, type-safe way to encode function calls (which we'll be doing a lot). Here's the step-by-step process. I'll link to files from the output unification branch for reference.

Define the function in an interface. The nice thing about this approach is that we can use this definition elsewhere, either when encoding or decoding these function calls. You can also easily add documentation in NatSpec format, which can be later used by solidity-docgen to generate documentation in Markdown. Furthermore, off-chain code will be able to easily encode/decode data through the contract ABIs and their language bindings. https://github.com/cartesi/rollups-contracts/blob/8c0a23ec835d9b58191a9f60f979526f1410776e/onchain/rollups/contracts/common/Outputs.sol#L9-L20
Encode the function call data using abi.encodeCall, passing the function pointer as the first argument. After that, the function arguments are passed as a single tuple. And good news: this method is completely type-safe! That means that the compiler will raise an error if you try to encode a function call with the wrong arguments. Language bindings in typed languages will most likely perform these type checks as well. https://github.com/cartesi/rollups-contracts/blob/8c0a23ec835d9b58191a9f60f979526f1410776e/onchain/rollups/test/foundry/dapp/CartesiDApp.t.sol#L728-L732
Decode the function call. First, you need to check if the byte array starts with the right selector. For this, I wrote a library called LibCalldata, which has a function called trimSelector. https://github.com/cartesi/rollups-contracts/blob/8c0a23ec835d9b58191a9f60f979526f1410776e/onchain/rollups/contracts/library/LibCalldata.sol#L14-L24
With the selector trimmed, you can decode the function arguments with abi.decode. Here, you'll have to specify the argument types, unfortunately.
https://github.com/cartesi/rollups-contracts/blob/8c0a23ec835d9b58191a9f60f979526f1410776e/onchain/rollups/contracts/dapp/CartesiDApp.sol#L140-L143

abi.encodeCall was introduced in 0.8.11 and bug fixed in 0.8.13 (ref), so we probably need pragma solidity ^0.8.13;

I created an issue in rollups-node repository to track the changes on our side: https://github.com/cartesi/rollups-node/issues/103

The machine-sdk side changes are being tracked here: https://github.com/cartesi/machine-emulator/issues/137

OpenZeppelin v5 also migrated from abi.encodeWithSelector and abi.encodeWithSignature to abi.encodeCall.
https://github.com/OpenZeppelin/openzeppelin-contracts/pull/4293


CMS 5: POST request to /admin/graphql redirected with trailing slash in live mode

Affected Version
CMS 5 stable
Setup (simplified)
https://github.com/silverstripe/silverstripe-linkfield
Extension:
class SiteConfigExtension extends DataExtension
{
    private static array $has_one = [
        'CtaLink' => Link::class,
    ];

    public function updateCMSFields(FieldList $fields): void
    {
        $fields->addFieldToTab(
            'Root.Footer',
            LinkField::create('CtaLink')
        );
    }
}

Apply extension:
SilverStripe\SiteConfig\SiteConfig:
  extensions:
    - App\Extensions\SiteConfigExtension

Trailing slashes enabled (not sure if this is relevant for admin):
SilverStripe\Control\Controller:
  add_trailing_slash: true

Environment type:
SS_ENVIRONMENT_TYPE="live"

Description

Open browser Network tab, limit to XHR requests.
Access the Settings area of the CMS and then switch to the Tab containing the LinkField.
See 2 requests:

One POST request containing our payload to https://domain/admin/graphql that gets a 301 response.
One GET request now missing the payload to https://domain/admin/graphql/ (i.e. with a trailing slash) that now gets a 200 response.

Result:
{"errors":[{"message":"This endpoint requires a \"query\" parameter"}]}

Debugging
I noticed that the CanonicalURLMiddleware is only applied on live environments by default:
protected $enabledEnvs = [
    CoreKernel::LIVE
];

I updated one of our other (working) environments to SS_ENVIRONMENT_TYPE="live", and then started to experience the issue on that environment as well.
I then tried removing the add_trailing_slash config, and also specifically disabled it in CanonicalURLMiddleware:
SilverStripe\Core\Injector\Injector:
  SilverStripe\Control\Middleware\CanonicalURLMiddleware:
    properties:
      enforceTrailingSlashConfig: false

I deployed this to a live environment, and the redirect no longer occurs.

Additional context: The above mentioned LinkField - but this is not limited to LinkField. This also can be seen by simply visiting the /admin/assets admin from silverstripe/asset-admin.

This is technically a impact/medium according to https://docs.silverstripe.org/en/5/contributing/code/#labels because there are workarounds available (disable the redirect or don't add trailing slashes in the first place) - but it's also pretty egregious regardless of label.

disable the redirect or don't add trailing slashes in the first place

Respectfully, I would argue these aren't workarounds for projects that need to use the trailing slash feature.

That's what the enforceTrailingSlashConfig property is meant to do, which is what seems to be broken. I take your point that if you need the trailing slash and you need the redirects on the front-end, then there's not really any valid workaround. I'll bump to impact high with that context.

@chrispenny This has been fixed and tagged as 5.0.1


transactions never show as confirmed when "ALL" is sent.

This is likely a mwc713 issue. Will look into it later. This is as a reminder.

I'll look into it. Pretty sure fees are calculated correctly because if not
the receiver would reject the transaction. In any case, will check though
and make sure everything is correct.
On Tue, Aug 27, 2019 at 10:45 AM bayk<EMAIL_ADDRESS>wrote:

Chris, it is looks like mwc713 issue. I guess fee not calculated correctly.
I had an account with 0.1 mwc. I send "ALL". Transaction amount is 0.1 and
it is incorrect. Fees are not deducted. May be it is a reason?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/mwcproject/mwc-qt-wallet/issues/60?email_source=notifications&email_token=ABXFVN55NAGOVTDDLEZSHJLQGVR2LA5CNFSM4IPZCXE2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5IRZHQ#issuecomment-525409438,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABXFVNYLGAGCLSTFL44NPG3QGVR2LANCNFSM4IPZCXEQ
.

Fixed


package.json: Update jquery package dependency

Check for any outstanding update of point version of any outstanding NPM package dependency

[ ] npm-update

npm-update in progress on bos-tasks-vrg4v.
Log: https://<IP_ADDRESS>:8493/logs/npm-update-659-20190504-083737/

npm-update in progress on bos-tasks-gdpmk.
Log: https://<IP_ADDRESS>:8493/logs/npm-update-659-20190504-083737/

npm-update jquery done: https://github.com/cockpituous/welder-web/commits/npm-update-jquery-20190504-083838

Please manually check features related to these files:
package.json:    "jquery": "3.4.1",
webpack.config.js:  // automatically load jquery instead of having to import or require them everywhere
webpack.config.js:    $: "jquery",
webpack.config.js:    jQuery: "jquery"
webpack.config.js:  externals: { cockpit: "cockpit", jQuery: "jquery" },


ArgumentNullException: Value cannot be null.

Hi,
Whenever I create a new graph, upon adding the first node, this error pops up :
ArgumentNullException: Value cannot be null.
Parameter name: source
System.Linq.Enumerable.Where[TSource] (System.Collections.Generic.IEnumerable`1[T] source, System.Func`2[T,TResult] predicate) (at <f2c7716883204ec0bfd759bf7e66dafc>:0)
PeartreeGames.EvtGraph.Editor.EvtGraphView.RecreateGraph () (at Library/PackageCache/com.peartreegames.evtgraph@f7e4b71063/Editor/EvtGraphView.cs:166)
PeartreeGames.EvtGraph.Editor.EvtGraphView.LoadGraph () (at Library/PackageCache/com.peartreegames.evtgraph@f7e4b71063/Editor/EvtGraphView.cs:146)
PeartreeGames.EvtGraph.Editor.EvtGraphView..ctor (PeartreeGames.EvtGraph.Editor.EvtGraphEditor editorWindow, PeartreeGames.EvtGraph.EvtTrigger evtTrigger) (at Library/PackageCache/com.peartreegames.evtgraph@f7e4b71063/Editor/EvtGraphView.cs:38)
PeartreeGames.EvtGraph.Editor.EvtGraphEditor.Init () (at Library/PackageCache/com.peartreegames.evtgraph@f7e4b71063/Editor/EvtGraphEditor.cs:57)
UnityEditor.EditorApplication.Internal_CallHierarchyHasChanged () (at /Users/bokken/buildslave/unity/build/Editor/Mono/EditorApplication.cs:392)

I'm using Unity 2021.3.10f1 and both Evt-variables and evt-graph have been freshly installed on a fresh project using the package manager (git method).
Any ideas what might be causing this issue?

Hey sorry! This got lost in my github notifications. This looks like it was an issue with Unity not creating serialized fields on a component add (the EvtTrigger.edges is null but shouldn't be in editor), I've pushed a change to help initialize with a default value.
Try updating and let me know if that helps!

Hey thanks so much for your reply. The update seems to have fixed the issue. The only other minor issue that I'm seeing (not sure if it was there before or not to be honest) but if you open the Graph Editor, and add a trigger to the object, you have to select a different object and back, for the nodes to show in the editor. Not really a big deal but thought you should know. Other than that, so far it's working perfectly. This is indeed a marvelous system.

Awesome! Glad it works.
The selection is definitely something I've noticed and been meaning to get to! I'll create an issue now to track it.
Cheers!