Cannot create and send mouse clicks to viewport

The docs advise a little bit of code that looks like:

var ev = InputEvent()
ev.type = InputEvent.MOUSE_BUTTON
ev.button_index = BUTTON_LEFT

Well, just try it! Use cases might include something like this.  Problem is, I'm not sure if those links can be clicked because in VR one does not use a mouse. One does not simply mouse into VR.
I modified the GUI in 3D example to continuously send mouse clicks inside the _on_area_input event, rather than just whatever you actually do with the mouse. On the Web, which those fruitcakes at Mozilla seem to be pushing for, you can send a click event and you can do this or that to your heart's content because it's for babies, but Godot's GUI system is really stripped down.  I kid, I kid. It's April Fools' Day so I think I'm entitled to a little verbal kickboxing. So when you comment out line 33, suddenly no trabaja.
Anyways, I hope I'm getting the point across. Need to generate MOUSE_BUTTON event from scratch in order to replace mouse with (for instance) key, cannot do so, angry. Above mentioned modified GUI in 3D example attached below.
broken_gui_in_3d.zip
EDIT: Sorry, these fonts are TINY. If you have trouble reading it you can send me an email @ AOL and I'll send it to you in big fonts.

So apparently Viewport skips events that have an ID of zero, which unfortunately is the default value for newly constructed InputEvents :/
A quick workaround would be to set ev.ID = 1 in your code. (Might also want to do ev.pressed = true to actually see an effect)

Unfortunately, setting ID to 1 does not work, nor does setting it to 2. I look forward to any feedback that comes on April 2nd.

and yeah yes ID =1 and pressed = true
works for me but may need to be documented

so things work and sense we're on the subject
there seems to be a special case for text fields
clicking and dragging scroll controls not affected
clearly Godot has not been idiot-proofed

var ev = InputEvent()
var ev = event # try commenting this out and see how it affects
selecting text
ev.type = event.type
ev.ID = 1
ev.pos = pos
if event.type == InputEvent.MOUSE_BUTTON:

ev.button_index = BUTTON_LEFT
ev.pressed = event.pressed
viewport.input( ev )

I mean you can't select text
On 04/01/2017 08:35 PM, Fluff Rabbit wrote:

so things work and sense we're on the subject
there seems to be a special case for text fields
clicking and dragging scroll controls not affected
clearly Godot has not been idiot-proofed

var ev = InputEvent()
var ev = event # try commenting this out and see how it affects
selecting text
ev.type = event.type
ev.ID = 1
ev.pos = pos
if event.type == InputEvent.MOUSE_BUTTON:

ev.button_index = BUTTON_LEFT
ev.pressed = event.pressed
viewport.input( ev )

I'm hoping that somebody has a mobile device and bluetooth controller to
experience how text fields do not get defocused when clicking in then
out of them in TestVRGUI. It seems that there are missing pieces here in
the generation of mouse click events. Aside from an inability to
click-and-drag-highlight text, there are basically no bugs when it's an
actual mouse event getting sent (and modified), but when generating a
new mouse event it's a nightmare.

First of all thank you for your report and sorry for the delay.
We released Godot 3.0 in January 2018 after 18 months of work, fixing many old issues either directly, or by obsoleting/replacing the features they were referring to.
We still have hundreds of issues whose relevance/reproducibility needs to be checked against the current stable version, and that's where you can help us.
Could you check if the issue that you described initially is still relevant/reproducible in Godot 3.0 or any newer version, and comment about its current status here?
For bug reports, please also make sure that the issue contains detailed steps to reproduce the bug and, if possible, a zipped project that can be used to reproduce it right away. This greatly speeds up debugging and bugfixing tasks for our contributors.
Our Bugsquad will review this issue more in-depth in 15 days, and potentially close it if its relevance could not be confirmed.
Thanks in advance.
Note: This message is being copy-pasted to many "stale" issues (90+ days without activity). It might happen that it is not meaningful for this specific issue or appears oblivious of the issue's context, if so please comment to notify the Bugsquad about it.

As there was no answer to the above request, we're closing this issue as inactive.
If you can still reproduce it, please open a new issue against a currently supported release of Godot.


Bugfix/no support of wildcard directly

The dotnet nuget push command does not allow wildcards.
I updated the release action with some powershell code, that will function the same way as I expect the wildcard was meant to function.
It uses Get-ChildItem to find the nuget package, and pushes the top 1 result.
Tested on my own fork, and it seems like it finds the correct package, but have not tested the nuget push itself.

@matt-lethargic This merge request should fix the release part. (hopefully)


$scope. Api is null when using cue points

I am trying to use cue points to show ads after random interval of times. i have studied videogular tutorials ans implemented the code but but i am getting null api error.  I also reffered your closed bug regarding $scope.api is null but did not get success Here is my controller
                 this.API = null;
                      $scope.onPlayerReady = function(API)
                      {
                            $scope.API = API;
                            console.log($scope.API);
                      };
                        var timePoint = [];
                        var start = 0;
                        var end = 5;
                        var result = {};
                        result.timeLapse =
                        {
                            start: start,
                            end: end
                        };
                        result.onLeave = function onLeave(currentTime, timeLapse, params)
                        {
                            console.log('onleave');
                        };
                        result.onUpdate = function onUpdate(currentTime, timeLapse, params)
                        {
                           if(Math.round(currentTime)=='3')
                           {
                              console.log('onUpdate');
                              $scope.API.stop();
                                //console.log(currentTime);
                           }
                        };
                        result.onComplete = function onComplete(currentTime, timeLapse, params)
                        {
                            console.log('onComplete');
                        };
                        timePoint.push(result);
                        $scope.config =
                        {
                          sources: [
                          {
                            src: $sce.trustAsResourceUrl("http://localhost:8090/public/uploads/"+res.data.files), type: "video/mp4"
                          },
                            ],

                          theme: "lib/videogular-themes-default/videogular.css",
                          cuePoints:
                          {
                                timePoint: timePoint
                          },
                          plugins:
                          {
                            controls: {
                                autoHide: true,
                                autoHideTime: 5000
                                }
                          }
                      };

My html is here
<videogular vg-theme="config.theme" vg-cue-points="config.cuePoints" vg-player-ready="lessonCtrl.onPlayerReady($API)">
            <vg-media vg-src="config.sources"
                    vg-tracks="config.tracks" vg-update-time="onUpdateTime($currentTime)">
            </vg-media>
            <vg-controls>
                <vg-play-pause-button></vg-play-pause-button>
                <vg-time-display></vg-time-display>
                <vg-scrub-bar>
                    <vg-scrub-bar-current-time></vg-scrub-bar-current-time>
                </vg-scrub-bar>
                <vg-time-display></vg-time-display>

                <vg-volume>
                    <vg-mute-button></vg-mute-button>
                    <vg-volume-bar></vg-volume-bar>
                </vg-volume>
                <vg-fullscreen-button></vg-fullscreen-button>
            </vg-controls>

            <vg-overlay-play></vg-overlay-play>
            <vg-poster vg-url='config.plugins.poster'></vg-poster>
        </videogular>

Your help will be really appreciated

html code is here

{{ currentTime | date:'mm:ss':'+0000' }}

{{ timeLeft | date:'mm:ss':'+0000' }}
            <vg-volume>
                <vg-mute-button></vg-mute-button>
                <vg-volume-bar></vg-volume-bar>
            </vg-volume>
            <vg-fullscreen-button></vg-fullscreen-button>
        </vg-controls>

        <vg-overlay-play></vg-overlay-play>
        <vg-poster vg-url='config.plugins.poster'></vg-poster>
    </videogular>

Here attachment
html.zip
chment of html file

Nothing stands out. It would be helpful if you could write up a codepen, if this is still an issue.


upgrade to nats.js and deno 2

https://github.com/nats-io/nats.js/issues/68
just putting it here to remind us.

This is already done in https://github.com/nats-io/nats.js/pull/70


Scalable 4d vertex time radius

The 4d vertices have a long temporal existence, i.e. a long radius in the time direction. It would be good for this to be adjustable.

If #404 is addressed maybe we can ignore this


Option to re-order css properties on beautify

Would be great if there was an option for SassBeautify to sort the properties and enforce the sort order from scss-lint.
https://github.com/brigade/scss-lint/blob/master/data/property-sort-orders/concentric.txt

Of interest, Sublime CSSComb does this reordering perfectly. But it doesn't get the spacing issues right, as Sassbeautify does.
I spent a bunch of time trying to get the two to work together — the formatting from sassbeautify, and the reordering from csscomb but no beueno. Might be possible, but I couldn't figure it out.

And finally, I think I've found a decent compromise. I currently have reordering on via CSSComb, triggered by a custom key map, and then run sassbeautify on save. Not bad.


Some suggestions

Different icons for small, medium, and large backpacks.

So it's easier to distinguish among the three.

Change the recipe of the enderpack from requiring a small backpack to a large one.

Enderpacks and global packs are too powerful in-game for how much they cost.
Enderpack being an ender chest that doesn't need to be placed and thus won't break when being mined.
Globalpack can literally transfer items between players million blocks away

Thanks for the suggestion.
Understandable, I will do both of these.


🚀 Feature: Add Link21 Transit Features and Fixes

User Story
The Link21 work tested the original tm2py transit features and made several improvements/corrections. As a starting point for TM2.2.2, the Link21 transit features will be integrated.
Progress:

[ ] Sufficiently defined
[ ] Approach determined
[ ] Tests developed
[ ] User story satisfied
[ ] Doc strings
[ ] General documentation
[ ] Passing tests

Priority
High
Level of Effort
High
Resolution Ideas
Start with the Link21 version of tm2py and merge into the new tm2py architecture
Project
MTC, Task Order 4
Who should be involved?
Users: @arashasadabadi, @gregerhardt
Reviewers: @DavidOry, @i-am-sijia
Risk
Yes. Will need to run full set of tests to make sure it is working properly.
Tests

[ ] Test for dummy PNR buses are working properly

Closes #117

Close #124


refactor: remove unneeded comment

This PR cleans up the code by removing an unneeded comment.

@0xRezaa often these commented lines are left in for ease of debugging or as a reminder (note to self). 🧑💻💭
Agree that it can be removed. ✂👌

I totally agree. This is why I checked if this is a "duplicate" or not. See here.
Nice package btw

Hey there. wanted to notify you that I cannot merge this PR on my own. So if you plan to merge it, feel free to do it or tell me and I close the PR.
Great thanks!


Sm/remove-fs-extra

What does this PR do?
fs-extra was being used only in the old federated deploy command.
root@509a1a8f6419:/usr/local/sf/node_modules/@salesforce/plugin-deploy-retrieve# du -sh * | sort -nr
368K	lib
196K	node_modules
160K	schemas
124K	messages
108K	oclif.manifest.json
12K	package.json
4.0K	LICENSE.txt
root@509a1a8f6419:/usr/local/sf/node_modules/@salesforce/plugin-deploy-retrieve# cd node_modules/
root@509a1a8f6419:/usr/local/sf/node_modules/@salesforce/plugin-deploy-retrieve/node_modules# ls
fs-extra

What issues does this PR fix or reference?
[skip-validate-pr]

perf NUTs could be interesting, I don't see these methods being called a lot to cause fs failures like why we used fs-extra in the first place

perf NUTs could be interesting, I don't see these methods being called a lot to cause fs failures like why we used fs-extra in the first place

I might if it weren't a deprecated command


Some suggestions

Hi, I've been using your extension for the last few days, I am very pleased with it, nevertheless, I would like to submit some suggestions.

I would rather have new tabs added to one single list, or at least have this option. Currently, if I add new tabs individually (not in a batch), they become new lists of their own.
It would be nice to be able to move tabs around lists with the mouse alone.
In the original OneTab, I could Ctrl + click to open the tab without removing it from the list. It would also be nice to have this functionality, as it works as a "keyboard shortcut" for this task.

Thank you!

Oh another one:

Select several tabs in a list from the options page holding Shift down.


how to use Keys build settings for resource filtering

steps
From an sbt plugin, create a Map[String,String] of entries like
"baseDirectory" -> whateverPathSbtFiguresOutAtCompileTime

for all interesting Settings in object sbt.Keys (like target, etc).
problem
In order to do resource filtering (like in Maven) with an sbt plugin or some sbt code, you somehow need to get hold of all interesting keys that sbt knows about when building, for example the target directory or the base directory.
But how do you do that? Can you suggest a way without using reflection on Keys?
Or, even better, is there a plugin? Seems pretty standard functionality, but i was not able to find anything near to whatever Maven has out of the box on this. The two plugins i found, xsbt-filter and sbt-editsource, are close in functionality, but do not satisfy the use case (see baseDirectory, for example).
expectation
The expectation would be to have a standard sbt plugin doing resource filtering like in Maven for resource files in different scopes (main, test, it) with tokens like ${mytoken} that the user defines from a filter file or standard ones like ${baseDirectory}.
In lack of that, the expectation would be to get hold of a simple API that provides what is needed, that is all standard tokens like "baseDirectory".
notes
Maybe the answer to this is trivial, in which case, i am simply not knowledgeable enough on scala or sbt to code this. In that case, some direction will help.
I tried reach out on stackoverflow (http://stackoverflow.com/questions/36510188/token-substitution-resource-filtering-with-sbt), but got no answers.

Github issue is set up for bug reports. "But how do you do that?" is not a problem of sbt.
Resource filtering does sound like a fun problem to solve tho.
http://www.scala-sbt.org/community.html#how-can-I-get-help

I am sure is fun, but unsure if it can be done with this version of sbt.
I guess by "how do you do that" i meant "there is no way to do that currently".
So, is this the place for feature requests, or only bugs?
If it is the place for feature requests, then the request is (should i open another item?):
provide an API in such a way that the sbt user can possibly do resource filtering (given that there is no such thing out of the box).
If there is a way to do this without reflection, then please say "yes, there is" and then please close this item.

never mind, just noticed your answer on stackoverflow: will try that, and then maybe open a feature request if needed. Thanks


Improve macro edit form UX and styling

At the moment, the experience of configuring midi macros is clunky and unintuitive. The task here is to readjust the UI styling and possibly rethink the UX flow of setting up and using macros.
UI components related to configuring macros are all defined throughout the files in this folder. Essentially any.tsx file there
https://github.com/jamtools/jamtools/tree/main/packages/jamtools/core/modules/macro_module/macro_handlers
Any existing styling done in those components is done through style attributes, partially due to previous lack of support for including css in the webapp bundle. SCSS is now supported by the webapp build scripts. In order for a particular module or react component to have stylings defined in scss, we can have the given component file import its own scss or css file.

All macros instantiated by all modules are currently shown on the centralized page http://localhost:1337/modules/macro. Specifically that page renders all edit components for all created macros.
Modules can also display these on their own pages via accessing the given macro's exported edit and show components like so:
https://github.com/jamtools/jamtools/blob/30aba0e40d489d30ad2d11d1ad8afcc98da9fd75/packages/jamtools/features/modules/dashboards/keytar_and_foot_dashboard/single_octave_root_mode_supervisor.tsx#L276-L279
The eventual plan is to have the components for these macros shown on the module's page itself, without the module needing to manually render those. The framework will take care of organizing those instead. This will be more relevant when the snack system is implemented. This piece is out of scope for this task, though just explaining this for context of where these components will eventually be shown automatically.

The task here is to:

Try out configuring a macro as a user
Take note of the clunky process
Consider and discuss any functional improvements
Consider and discuss any styling improvements

After discussing this, we can decide the desired result and determine what code needs to change to accomplish the feature

I've added some more docs including some information on macros here https://docs.jam.tools/jamtools/macro-module
I also added to the project README how to start up the application for development https://github.com/jamtools/jamtools#development

The snack system should also be in discussion of this probably


Minecraft Solution Packge

Child of #147

This will require a minecraft flist

I have worked on the chatbot and since the data is static so I have made just a loading bar.

@xmonader  there's already an flist with explanation to convert from  docker image

This will require a minecraft flist

I have one at: https://hub.grid.tf/zaibon/itzg-minecraft-server-latest.md


Binary packages

This comes up from time to time.  It is in our roadmap, but we have not scheduled the work.
There are many binary packages we may consider. See #333 for an old list,  or #3355 and #9233 for more recent lists.  Some package managers already create binary packages for at least some of the libraries in google-cloud-cpp. For example, Conda:
https://github.com/conda-forge/google-cloud-cpp-feedstock#current-release-info
and Conan Center:
https://conan.io/center/google-cloud-cpp
But we should consider binary packages for popular OS distributions (Ubuntu, Fedora, openSUSE, etc.).
There are some difficult questions to answer for distros that change very very slowly compared to our code base.  We cannot backport all fixes, we cannot promise ABI compatibility.  Maybe start with distros life Fedora that goes EOL in about a year anyway?  Or maybe only support the "tumbleweed" equivalents?

I think we should consider support for Bazel modules and the Bazel central registry part of this larger task.

Revisit for H2/2023

Not for Q3/2023, maybe Q4.

Hi All,
if I have to contribute to conan recipe for google cloud cpp, where i have to raise the issue and where can I find source for the same.

@joshyjoseph the recipe for conan.io already exists: https://github.com/conan-io/conan-center-index/tree/master/recipes/google-cloud-cpp

We will want to revisit this, but closing for now.


[BUG] When using custom filters, handers are firing twice

I am finding that I am hitting Unique SQL constraint errors. When digging in it seems my handlers are firing twice.
My error:
DecodeLogTopicsMismatch: Expected a topic for indexed event parameter "previousOwner" on event "OwnershipTransferred(address previousOwner, address newOwner)".

Version<EMAIL_ADDRESS>    at decodeEventLog (/Users/dennisonbertram/Develop/auto-ponder/node_modules/viem/_cjs/utils/abi/decodeEventLog.js:30:19)
    at /Users/dennisonbertram/Develop/auto-ponder/node_modules/@ponder/core/dist/event-aggregator/service.js:77:66
    at Array.reduce (<anonymous>)
    at EventAggregatorService.getEvents (/Users/dennisonbertram/Develop/auto-ponder/node_modules/@ponder/core/dist/event-aggregator/service.js:66:42)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async /Users/dennisonbertram/Develop/auto-ponder/node_modules/@ponder/core/dist/user-handlers/service.js:208:34
Am I firing twice? 0x81a28c76b0e3c86720e899e388f12c21d3c1d09762beba02e277b5b412cd8fef-0xb9
Am I firing twice? 0x81a28c76b0e3c86720e899e388f12c21d3c1d09762beba02e277b5b412cd8fef-0xb9
01:37:42.551 ERROR handlers   Error while handling "ERC20Votes_Ownable:OwnershipTransferred" event at block 17000001: SQLite error: UNIQUE constraint failed: OwnershipTransferred_EVENT_a57756f6.id, OwnershipTransferred_EVENT_a57756f6.effectiveTo
Statement:
  insert into "OwnershipTransferred_EVENT_a57756f6" ("id", "previousOwner", "newOwner", "contract", "block", "transaction", "log", "effectiveFrom", "effectiveTo") values (?, ?, ?, ?, ?, ?, ?, ?, ?) returning *
Parameters:
  1:  0x81a28c76b0e3c86720e899e388f12c21d3c1d09762beba02e277b5b412cd8fef-0xb9-Ownershi...
  2:  0x0000000000000000000000000000000000000000
  3:  0xd12c6E1Ee11997d4f97f5F13F3060178A74Cd49E
  4:  0x55a35e9e0faadc8e04a47e2436f8b9cb87d1dd81
  5:  0x81a28c76b0e3c86720e899e388f12c21d3c1d09762beba02e277b5b412cd8fef
  6:  0xdc477f979e53c946ef84a4e49fe1a176655d9c6167b3bdf1866967f6b3fa1450
  7:  0x81a28c76b0e3c86720e899e388f12c21d3c1d09762beba02e277b5b412cd8fef-0xb9
  8:<PHONE_NUMBER>
  9:<PHONE_NUMBER>

  at async Object.fn (/Users/dennisonbertram/Develop/auto-ponder/src/handlers/ERC20/registerOwnershipTransfered.ts:10:4)
   8 |   const { newBlock, newTransaction, newLog, sender, contract } = await createCommonEntities(event, context);
   9 |
> 10 |     await OwnershipTransferred_EVENT.create({
     |    ^
  11 |       id: `${event.log.id}-OwnershipTransferred`,
  12 |       data: {
  13 |         previousOwner: event.params.previousOwner,
Event params:
  previousOwner:  0x0000000000000000000000000000000000000000
  newOwner:       0xd12c6E1Ee11997d4f97f5F13F3060178A74Cd49E
01:37:42.551 INFO  handlers   Processed 8148 events (up to Apr 8, 2023)

Take note of the line:
Am I firing twice? 0x81a28c76b0e3c86720e899e388f12c21d3c1d09762beba02e277b5b412cd8fef-0xb9
Am I firing twice? 0x81a28c76b0e3c86720e899e388f12c21d3c1d09762beba02e277b5b412cd8fef-0xb9

This comes from my code:
import { createCommonEntities } from "../../utils";

export function registerOwnershipTransferredEvent() {
  ponder.on("ERC20Votes_Ownable:OwnershipTransferred", async ({ event, context }) => {
    console.log("Am I firing twice?", event.log.id)
    const { OwnershipTransferred_EVENT } = context.entities;
  const { newBlock, newTransaction, newLog, sender, contract } = await createCommonEntities(event, context);

    await OwnershipTransferred_EVENT.create({
      id: `${event.log.id}-OwnershipTransferred`,
      data: {
        previousOwner: event.params.previousOwner,
        newOwner: event.params.newOwner,
        contract: contract.id,
        block: newBlock.id,
        transaction: newTransaction.id,
        log: newLog.id,
      },
    });
  });
}

This filter is described like this:
    name: "ERC20Votes_Ownable",
    network: "mainnet",
    startBlock: 17000000,
    abi: "/Users/dennisonbertram/Develop/auto-ponder/abis/ERC20Votes_Ownable.json",
    filter: {
      event: parseAbiItem("event OwnershipTransferred(address indexed previousOwner, address indexed newOwner)")
    }
  },

I just updated to the latest (.93) and this problem seems to have gone away so I'll close this.

Sorry that was premature, the problem with the duplicate handler firing is still there.


Change prometheus dummy metric to a more unique label

https://issues.apache.org/jira/browse/SOLR-17368

Description
TestPrometheusResponseWriter was failing ~25% of tests due to dummy metric dummyMetrics.2xx-responses not unique enough for exporting compared to org.eclipse.jetty.server.handler.DefaultHandler.2xx-responses which could leak between tests creating a duplicate metric.
Solution
Change the dummy jetty metric with 999xx that exports a unique enough label that 2xx cannot clash with it, even with real leaking jetty metrics.
Checklist
Please review the following and check all that apply:

[ ] I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
[ ] I have created a Jira issue and added the issue ID to my pull request title.
[ ] I have given Solr maintainers access to contribute to my PR branch. (optional but recommended)
[ ] I have developed this patch against the main branch.
[ ] I have run ./gradlew check.
[ ] I have added tests for my changes.
[ ] I have added documentation for the Reference Guide

@dsmiley This should make the dummy metric unique enough to not clash with real leaking jetty metrics from other tests. I ran tests locally multiple times. Any ideas what we can do to make sure that is resilient enough? I want to avoid breaking CI and generating noise for a 3rd time...

Were you able to reproduce the problem?  If I understand the cause, you'd need to run a number of tests, not just this one test.
The root fix would be to stop metric leaks between tests!  Albeit not today -- okay.

Yes, on main branch it fails the same way when running Jetty based tests next to it. From Chris's suggestion, ./gradlew -p solr/core test -Ptests.jvms=1 -Ptests.verbose=true --tests TestPrometheusResponseWriter --tests \*Jetty\* Ran is multiple times and this looks to clean up the issue on my branch.
Current test failure looks to be from LocalFSCloudIncrementalBackupTest? Don't think this is related to this though.


req.query on nested resources

This directory structure: /site/_name/schema/_name overwrites the site name in req.query
Maybe it should look like this:
{ site: { name: 'hello' }, schema: { name: 'project' } }

Then you can do:
$.req.site.name and $.req.schema.name
BTW, consider removing $.query?

Just don't name them the same, solved.
/site/_site_name/schema/_schema_name


preview error : Cannot find module .svelte-kit/output/server/index.js imported from vite.js

Describe the bug
The command npm run preview throws the following error

Cannot find module '.svelte-kit/output/server/index.js' imported from<EMAIL_ADDRESS>
Reproduction
A fresh install also throws the error
https://github.com/fcrozatier/kit_preview_issue
Logs
at new NodeError (node:internal/errors:388:5)
    at finalizeResolution (node:internal/modules/esm/resolve:405:11)
    at moduleResolve (node:internal/modules/esm/resolve:966:10)
    at defaultResolve (node:internal/modules/esm/resolve:1174:11)
    at ESMLoader.resolve (node:internal/modules/esm/loader:605:30)
    at ESMLoader.getModuleJob (node:internal/modules/esm/loader:318:18)
    at ESMLoader.import (node:internal/modules/esm/loader:404:22)
    at importModuleDynamically (node:internal/modules/esm/translators:106:35)
    at importModuleDynamicallyCallback (node:internal/process/esm_loader:35:14)
    at preview (file:///.../node_modules/@sveltejs/kit/dist/vite.js:2533:69)

System Info
System:
    OS: macOS 11.6.7
    CPU: (16) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
    Memory: 4.32 GB / 32.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 18.4.0 - /usr/local/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 8.12.1 - /usr/local/bin/npm
  Browsers:
    Brave Browser: <IP_ADDRESS>
    Chrome: 103.0.5060.53
    Firefox Developer Edition: 103.0
    Safari: 15.5
  npmPackages:
    @sveltejs/adapter-auto: next => 1.0.0-next.53
    @sveltejs/kit: next => 1.0.0-next.357
    svelte: ^3.44.0 => 3.48.0

Severity
serious, but I can work around it
Additional Information
No response

You need to run build first before running preview.

getting the same while I do run build... Any ideas?


[BUG] - Table

NextUI Version
v2.6.8
Describe the bug
when table  selectionMode="multiple" then face error
Your Example Website or App
No response
Steps to Reproduce the Bug or Issue
just create a simple table component from the next UI & send props selection mode multiple, then the error is occurs
Expected behavior
expected see checkbox for se;ect multiple items
Screenshots or Videos
No response
Operating System Version
Linux voyeger
Browser
Chrome

Couldn't reproduce. Please provide more details. A minimal reproducible sandbox is preferred.

duplicate - https://github.com/nextui-org/nextui/issues/4385


Resource Not Found Error for Offline Videos as Input

Thanks for the great work!!
Instead of RTSP stream, I used an offline locally stored video as an input.
changed the config. to
type=2
uri=file:///home/test.mp4
Both Yolo3 and CustomVision.ai models couldn't be able to pick up this path and shows "Resource NOT found error"
The same video runs on Resnet10 model of DeepStream samples.
Do I need to add any more changes to the config file to run videos as input.

It sounds like the video file is not accessible to the container.  Have you properly mounted the path to the video file to make it accessible to for playback in the DeepStream module?  The default configuration bind mounts the /data/misc/storage path, you may have luck by referencing the file from within that path.


Failing to replacce moderation messages with their PubSub variant despite PubSub connection being alive

As shown above, PubSub connection is still alive (the reward redemption confirms that).
Actions taken to reproduce:

Timed out for 1s from another client.
Banned from another client.
Unbanned from another client.
Banned from this client.
Unbanned from this client.

Version d937254b (based on 8c113c2)

With some gdb magic I managed to inspect log output of Chatterino instance with the "bug" - it seems like we don't receive messages for moderation topics for some reason.
Logs for nerds: https://haste.zneix.eu/raw/cywepyjymu

Note to self: test this


GraphQL over HTTP spec compliance (#1120)

Resolves #1120
Synopsis

Currently in draft but it is an official project:
https://graphql.github.io/graphql-over-http/draft/

Checklist

[ ] Correct media type for responses and appropriate response codes.
[ ] Add extensions parameter to GraphQLRequest.
[ ] Handle null correctly for optional GraphQLRequest parameters and emptiness in GET query params.
[ ] Consider "well-formness" of GraphQLRequest.
[ ] Consider Accept HTTP header and its priority.
[ ] Disallow mutations for GET requests with 405 Method Not Allowed.
[ ] Consider strict and non-strict semantics regarding Content-Type in POST requests.
[ ] Support additional validation rules.
[ ] Provide correct legacy support for application/json responses.

Integration

[ ] juniper_actix
[ ] juniper_axum
[ ] juniper_hyper
[ ] juniper_rocket
[ ] juniper_warp

@LegNeato after investigating it closely, the rabbit hole seems to be way deeper that I thought it would be. There are quite a lot of nuisances and details to be handled properly regarding different media types (for example, response codes for application/json and application/graphql-response+json are treated very differently), and moreover, spec implies few points for extension by user-side, while the core should remain.
Implementing all this separately for each integration crate would be painful and fragile. Moreover, integration crates are not doing well with extensibility. That's why, to implement this properly, it seems right to introduce a new juniper_graphql_http crate, providing a core http-crate-based implementation and being framework-agnostic, just as we have the juniper_graphql_ws crate for GraphQL over WebSocket specs.
This, however, quite a huge and time-consuming task, so I decided to move it from 0.16 milestone to 0.17 one.

Make sense to me! I've been thinking that we'd probably need something similar, mirroring the http / tower stack


Themes

Looks like theres been an oversight, the original docs don't make any mention of themes.
Yet on the original Atom.io Website you are able to browse and search themes.
We currently only implement /api/themes/featured. So this must be expanded.
Now considering the huge rework that may be needed to support every single endpoint properly, I'll propose the following.
Since we have placed such care into meeting the original spec, it would seem wrong to deviate now, and we likely could achieve full support of the Themes slug with the following.

/api/themes: This would need a new endpoint and a new Database call, keep in mind packages that are themes do have a key in package.json with "theme": "syntax" or "theme": "ui", so having those filtered via that key would allow us to have a full listing of themes on this endpoint.
/api/themes/featured: This endpoint is already supported and requires zero work.
/api/themes/search: Again this would require new handling, again filtering like done on /api/themes
/api/themes/:themeName: Once we are into any endpoints that deal with a singular specific theme we should be safe to stop the specific handling. By having these endpoints in main.js simply redirect to the equivalent functions in package_handler.js

On a second thought, we may want to instead of creating new endpoints, have the packages slug on endpoints be instead a route parameter, and we can direct the query in main.js from there. Since the vast majority will end up in the same place it won't be that much extra work, except we will have to build in a handler to navigating to a 404 in each request. Or alternatively, we import the next value in each request and pass it along if we don't have a match for that slug. Since doing this so close to the root could mean it will try and fail against many of the endpoints

I've put up an example of how we should go about this on 17c8950ed47cf6301674649b8ef4ebb32eeb6192 where you can view how we should add the theme support, which ideally will result in the least amount of rewrites, but will need more testing.
Then for any of the single item handlers we just use the same handler for both packages or themes

Alright, so now I've actually added the handling for themes and packages onto every single endpoint.
Now all that's needed is to actually write the functions getThemes and getThemesSearch, then of course test the nearly doubled amount of endpoints this creates

Is this needed before v1?

Yeah this looks about right.
I'll take a look at running this soon, after of course making a backup.
But sounds like you've got a proper understanding of it, in other words a theme would look like so
{
  "name": "packageName",
  "theme": "theme"

Whereas the theme key would be missing in a non-theme package.
Thanks for the assistance on creating this script, I'll get to it soon

Alright @Digitalone1 I've tried adding this script to our startup of the dev server (just to give it a dry run before being used in prod)
I did have to make one small edit based on this but otherwise here is my exact code
ALTER TABLE packages ADD COLUMN package_type VARCHAR(20);

UPDATE packages
SET package_type = 'theme'
WHERE LOWER(data ->> 'theme') = 'syntax' OR LOWER(data ->> 'theme') = 'ui';

UPDATE packages
SET package_type = 'package'
WHERE package_type != 'theme';

CREATE TYPE packageType AS ENUM('package', 'theme');

ALTER TABLE packages
ALTER COLUMN package_type TYPE packageType,
ALTER COLUMN package_type SET NOT NULL;

But I receive the following error when running it:
error: column "package_type" cannot be cast automatically to type packagetype

Any ideas? Is it because there is no data inserted yet?

Although it seems by further modifying
ALTER COLUMN package_type TYPE packageType USING (package_type::packageType),
I was able to get past that step, but now receive error: null value in column "package_type" of relation "packages" violates not-null constraint
Which does feel more related to a lack of data? Let me see if adding a value to the inserted data to our dev instance fixes this

Alright, the above commands have now been run against production.
@Digitalone1 I've updated our dev db as well, this will likely cause some tests to fail until we bake in this new value into our actual code as well.
But we are on the way

@confused-Techie So when we needs themes, we search for theme type, but when we need packages we return both package and theme or only package?

Alright, I've written some basic tests for themes and it works. The dedicated endpoints are looking good, and some basic tests to check that every package endpoint works for themes as well is good.
So looks like I can close this issue as themes are fully implemented as it's own dedicated endpoint.
Obviously there is only things to gain by additional testing and fail safes like you've been doing elsewhere. But overall we are good here


[BUG] IndexError: list index out of range while  Loading raw image data

Describe the bug
Cellfinder yields an IndexError while loading raw images from a list of file paths. [While running on the HPC cluster and fetching data from winstor]
From the Log file:
**************  COMMAND LINE ARGUMENTS  **************

Command: /nfs/nhome/live/federicoc/.conda/envs/cellfinder/bin/cellfinder
Input arguments: ['-s', '/nfs/winstor/branco/BrainSaw/AY_246_4/stitchedImages_100/3', '/nfs/winstor/branco/BrainSaw/AY_246_4/stitchedImages_100/2', '-b', '/nfs/winstor/branco/BrainSaw/AY_246_4/stitchedImages$

...

**************  LOGGING  **************

2020-01-29 18:17:50 PM - INFO - MainProcess fancylog.py:257 - Starting logging
2020-01-29 18:17:50 PM - INFO - MainProcess fancylog.py:259 - Multiprocessing-logging module found. Logging from all processes
2020-01-29 18:17:50 PM - INFO - MainProcess main.py:32 - Registering to atlas
2020-01-29 18:17:50 PM - INFO - MainProcess prep.py:398 - Checking whether the atlas exists
2020-01-29 18:17:50 PM - DEBUG - MainProcess prep.py:417 - Making registration directory
2020-01-29 18:17:50 PM - DEBUG - MainProcess system.py:111 - Determining the maximum number of CPU cores to use
2020-01-29 18:17:50 PM - DEBUG - MainProcess system.py:120 - Number of CPU cores available is: 8
2020-01-29 18:17:50 PM - DEBUG - MainProcess system.py:145 - Setting number of processes to: 8
2020-01-29 18:17:50 PM - INFO - MainProcess main.py:85 - Preprocessing data for registration
2020-01-29 18:17:50 PM - INFO - MainProcess main.py:86 - Loading data
2020-01-29 18:17:50 PM - INFO - MainProcess batteryrunners.py:274 - pixdim[0] (qfac) should be 1 (default) or -1; setting qfac to 1
2020-01-29 18:17:50 PM - INFO - MainProcess brain_processor.py:79 - Loading raw image data
2020-01-29 18:17:50 PM - DEBUG - MainProcess brainio.py:72 - Data type is: directory of files
2020-01-29 18:17:53 PM - DEBUG - MainProcess utils.py:104 - Determining the maximum number of CPU cores to use
2020-01-29 18:17:53 PM - DEBUG - MainProcess utils.py:116 - Setting number of processes to: 8

Complete error message:
"""
Traceback (most recent call last):
  File "/nfs/nhome/live/federicoc/.conda/envs/cellfinder/lib/python3.7/concurrent/futures/process.py", line 239, in _process_worker
    r = call_item.fn(*call_item.args, **call_item.kwargs)
  File "/nfs/nhome/live/federicoc/.conda/envs/cellfinder/lib/python3.7/site-packages/brainio/brainio.py", line 304, in load_from_paths_sequence
    img = tifffile.imread(p)
  File "/nfs/nhome/live/federicoc/.conda/envs/cellfinder/lib/python3.7/site-packages/tifffile/tifffile.py", line 716, in imread
    return tif.asarray(**kwargs)
  File "/nfs/nhome/live/federicoc/.conda/envs/cellfinder/lib/python3.7/site-packages/tifffile/tifffile.py", line 2373, in asarray
    series = self.series[series]
IndexError: list index out of range
"""

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/nfs/nhome/live/federicoc/.conda/envs/cellfinder/bin/cellfinder", line 8, in <module>
    sys.exit(main())
  File "/nfs/nhome/live/federicoc/.conda/envs/cellfinder/lib/python3.7/site-packages/cellfinder/main.py", line 61, in main
    debug=args.debug,
  File "/nfs/nhome/live/federicoc/.conda/envs/cellfinder/lib/python3.7/site-packages/amap/main.py", line 98, in main
    n_free_cpus=n_free_cpus,
  File "/nfs/nhome/live/federicoc/.conda/envs/cellfinder/lib/python3.7/site-packages/amap/register/brain_processor.py", line 87, in __init__
    n_free_cpus=n_free_cpus,
  File "/nfs/nhome/live/federicoc/.conda/envs/cellfinder/lib/python3.7/site-packages/brainio/brainio.py", line 79, in load_any
    n_free_cpus=n_free_cpus,
  File "/nfs/nhome/live/federicoc/.conda/envs/cellfinder/lib/python3.7/site-packages/brainio/brainio.py", line 190, in load_from_folder
    paths, x_scaling_factor, y_scaling_factor, n_free_cpus=n_free_cpus
  File "/nfs/nhome/live/federicoc/.conda/envs/cellfinder/lib/python3.7/site-packages/brainio/brainio.py", line 279, in threaded_load_from_sequence
    stack = np.dstack([s.result() for s in stacks])
  File "/nfs/nhome/live/federicoc/.conda/envs/cellfinder/lib/python3.7/site-packages/brainio/brainio.py", line 279, in <listcomp>
    stack = np.dstack([s.result() for s in stacks])
  File "/nfs/nhome/live/federicoc/.conda/envs/cellfinder/lib/python3.7/concurrent/futures/_base.py", line 428, in result
    return self.__get_result()
  File "/nfs/nhome/live/federicoc/.conda/envs/cellfinder/lib/python3.7/concurrent/futures/_base.py", line 384, in __get_result
    raise self._exception
IndexError: list index out of range

@FedeClaudi has this happened since?

Closing as I haven't been able to replicate. @FedeClaudi feel free to reopen.


[CLOUD-296] Add required_recipe endpoint

Adds the ability to serve a required recipe file to chef-clients.
See the chef-rfc for full details on the motivation.

/organizations/<orgname>/required_recipe returns 404 for all organizations
by default.
/organizations/<orgname>/required_recipe returns 401 when the request is
not made by a client from the requested org.
/organizations/<orgname>/required_recipe returns the required recipe and
200 when the endpoint is enabled and requested by an authorized client.
required_recipe["enable"] = true in chef-server.rb enables the required
recipe.
required_recipe["path"] in chef-server.rb specifies the recipe file to
serve.

Per @srenatus:

Hmm this also has HA downsides, doesn’t it? you’d have to put that on each FE

Since this is being presented as a "super advanced" feature, perhaps we can just document that you have to keep them in sync; but things could get /very/ confusing if they were out of sync.

I'm wondering if we want to send a header such as Content-MD5 or similar that the client could use to verify the contents weren't modified/corrupted in transit?

@stevendanna @srenatus Sorry y'all, this is very much a WIP PR that I hadn't cleaned up, added documentation for, or added tests for. That said, I appreciate the feedback.

When reviewing the RFC, it occurred to me that doing this in lua means we don't (currently) have access to the API versioning stuff (and also don't return API version information), which could make this harder to deprecate in the future if we ever replace it with a more robust feature.

However, I can't think of a reason we couldn't move this into erchef at the point of wanting to deprecate it.

That's exactly the plan. I don't anticipate that happening any time soon though.

Hmm this also has HA downsides, doesn’t it? you’d have to put that on each FE
Since this is being presented as a "super advanced" feature, perhaps we can just document that you have to keep them in sync; but things could get /very/ confusing if they were out of sync.

Yep, this was definitely a consideration but we've decided that the scope is limited to standalone installs. If we ever chose to support HA we'd probably move it into erchef and make the create API limited to server admins/pivotal.

I'm wondering if we want to send a header such as Content-MD5 or similar that the client could use to verify the contents weren't modified/corrupted in transit?

I don't really see a way to have nginx add that header for static content. It should be easy enough to calculate it during the reconfigure and inject it into the nginx location block though.

Overall this looks okay, but I see this as something that belongs more properly in the erchef API in the longer term.  I know that we're in a situation where that may not be an option right now.
To that end, I'd like to create a sustainable interface contract now so that we can address this in the future without further client updates being necessary.
This should behave not as a recipe endpoint, but as a cookbook endpoint.  Chef Client already knows how to to load a cookbook in full.  Let's have our response look the same. Some modifications will still be needed  on the client (may not be a metadata.rb that's downloadable).
On the nginx side, the endpoint would give a JSON response that looks like a versioned cookbook get.  It  would contain the storage URL for the recipe we want the client to grab. The recipe file we care about would come out of the backing file store (S3/bookshelf) , but still proxied via nginx and able to take advantage of caching if it's enabled.    This would be something we could more easily expand in the future, with support for cookbook files and dependencies if we wanted  to go that route.
On the nginx side, this should  mean constructing the JSON response and generating the S3 url.
On the client side, some further changes required because this isn't really a full cookbook, and won't have the files it expects (specifically metadata.rb).
More importantly than the potential to expand it in the future though: I am increasingly less comfortable with the path of adding one-off behaviors into the reverse proxy instead of into the application that houses our API.
If we want to have a separate lightweight API service for some of these tasks , we should design it and build it (even if in nginx) - but accumulating one-off by_lua behaviors isn't a sustainable approach.
Separately: we will also need to add pedant coverage for this endpoint.

To give a little more context here:
A few customers have asked for the ability to enforce certain items being in a node's run list at the server level, but this isn't that feature. There are a lot of possible designs that include having a side channel for a single cookbook, validating the run list at create/edit time to enforce required content, or having multiple run lists on the node. Each of these has variations on how the cookbook content could be uploaded/managed. On top of that, there are a lot of trade-offs related to attribute visibility between the various pieces and so on that would need to be decided upon in the client implementation. We would also need to look at the end to end development/testing/deployment story. To have a better chance at getting all of this right, we would want to engage some development partners and do a fair bit of research with them to work through the various trade-offs that various approaches could have. However, we haven't seen enough demand for such a feature that we moved it to the top of the priority list, and some folks (me especially) think that such a feature could discourage users from taking a more productive route to solving their problems, such as collaborating via shared Ci infrastructure.
Given all that, we're inclined to go hard on the YAGNI principle here. A lot of our strategy for long term scalability (in functionality terms) of the feature is to implement as little functionality as possible so it's not a huge cost to throw away and replace. We know so little about what shape a replacement would look like that a lot of work we might try to do to anticipate future improvements would very likely end up as wasted work.
In terms of the client work, Chef Client also already knows how to load single recipes in addition to its run list (see chef-client -z path/to/recipe.rb) so we are re-using that code path.
All that said, while we are targeting standalone installations for now, we do want to write the code so that an HA-compatible implementation could be written in the future without changing the configuration interface or Chef Client's download mechanism.

@ryancragun @dan: I am sorry - I should have done a much better job at not being an ass in my initial comment.  Next time our paths cross, :beer: (or other drink of choice) is on me.

@marcparadise @stevendanna @srenatus @sdelano
Howdy y'all. I think that this and https://github.com/chef/chef-server/pull/1226 are ready for 👀. All of the feedback should be addressed and an integration test plan has been formed on #1226.
Thanks!

@ryancragun I left 2 very minor comments related to dual config (enabled and recipe_path) and how we render the nginx config. In the end, the functionality remains the same, so I'll leave it up to you on whether you'd like to address those two issues. If not, merge away!

@markan

I think we're probably better off all around copying the required recipe over to a secure location than guarding it with checks, but if we are diligent with guards that could be made to work.

The only problem I see is that the user might want to change the content, so it will always be the case that we need to read it in from the user-provided location so we will always want that user-provided location to have safe permissions.

Checking the permissions at reconfigure time is a good idea. I agree that copying it instead of linking is needed. The content md5 header has to be regenerated if you intend to change the file content, a case the previous link method did not address. By validating and copying we ensure that:

the file is always in a directory we own
can only be changed by root
source has to use a file owned by root
that the md5 header is always in sync

👍  LGTM


Hack removal - MHD

Hardcoded unknown-linux-gnueabi passed to configure

dupe of https://github.com/doublethinkco/cpp-ethereum-cross/issues/96


Skip failing tests related to DatasetFilter

Related to https://github.com/huggingface/huggingface_hub/pull/1250.
For now and until we fix that, let's skip the failing tests. It's annoying in CI checks.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

Thanks for the quick review @LysandreJik :)


Registering the governance key as a controller removes governance role

Description/Reasoning
A register controller request allows registering the governance key as the controller key. But this has the effect of overwriting the role of that account to that of a chain maintainer. As a consequence, the governance key doesn't have the role of access control in the keeper anymore, and can't submit governance requests anymore. One question to discuss here is whether we want to allow a governance key to also take the role of a controller.
Current Behaviour
Expected Behaviour
Steps to reproduce (for bugs)
Relevant Logs or Files

Fixed by #1195


[New Feature] Blit Advanced

Hi,
Hi had a problem and find this solution very optimizing for me...
It changes an obfuscate image script to process an 400x400 pixels image from 40 seconds to 120ms.
The source code
Jimp.prototype.blitAdv = function (src, x, y, srcx, srcy, srcw, srch, cb) {
	if ("object" != typeof src || src.constructor != Jimp)
		return throwError.call(this, "The source must be a Jimp image", cb);
	if ("number" != typeof x || "number" != typeof y)
		return throwError.call(this, "x and y must be numbers", cb);

	// round input
	x = Math.round(x);
	y = Math.round(y);

	var that = this;

	src.scan(0, 0, srcw ? srcw : src.bitmap.width, srch ? srch : src.bitmap.height, function(sx, sy, idx) {
		var dstIdx = that.getPixelIndex(x+sx, y+sy);
		var ix = that.getPixelIndex(srcx ? srcx+sx : sx, srcy ? srcy+sy : sy);
		that.bitmap.data[dstIdx] = this.bitmap.data[ix];
		that.bitmap.data[dstIdx+1] = this.bitmap.data[ix+1];
		that.bitmap.data[dstIdx+2] = this.bitmap.data[ix+2];
		that.bitmap.data[dstIdx+3] = this.bitmap.data[ix+3];
	});

	if (isNodePattern(cb)) return cb.call(this, null, this);
	else return this;
};

It's basically a blit function with source parameters.
Before this the closer solution is use jimp.crop and then paste using  jimp.blit
Now you can just use jimp.blitAdv , that works like ctx.drawImage canvas
Hope you guys like it.

I've added this to the latest version. Rather than adding an "advanced blit", I extended the normal blit to take optional crop parameters. Will release tonight.

Nice, :+1: :tada:
Thanks

That's available on NPM now. Thanks for the contribution!


delete gameservices

It doesn't appear to be maintained.  See #2218

Waiting on googleapis/java-gameservices#73

b/147371479 #13 approves merging this.


Audio cracking a lot

Steps to reproduce
Everytime I play any video it starts to crack the audio . I have been facing this issues for months and I have been hoping it would get fixed in the next update please help me fix it . I think it's the hardware decoding something. I switch to HW+ and the issues gets worse . Even in SW it's bad . The audio cracks a lot .
Expected behavior
I hoped the audio would be more clear but it isn't
Actual behavior
The audio cracks a lot
Crash logs
No response
Aniyomi version
version 0.14.6-6691
Android version
Android 12
Device
Realme c12
Other details
https://github.com/aniyomiorg/aniyomi/assets/116457473/8fc7de2d-e045-4146-bdb4-1622fdf5bf3a
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] If this is an issue with an extension, I should be opening an issue in the extensions repository.
[X] I have gone through the FAQ and troubleshooting guide.
[X] I have updated the app to version <IP_ADDRESS>.
[X] I have updated all installed extensions.
[X] I will fill out all of the requested information in this form.

Please this is very important

Please this is very important

can try settings - player - advanced player settings - debanding change your debanding according to your need or try them all.
also you can try updating your app to see if that solves it.

How can I change it . Can u give me an example

Alright I have found it . Let me try it out

It's still cracking. The sound itself is the issue or probably the decoding issues . It's the first time i am ever facing this kind of issue.

Tried it but it's still not working
On Fri, Jan 12, 2024, 12:55 PM fakebhai @.***> wrote:

Please this is very important
can try settings - player - advanced player settings - debanding change
your debanding according to your need or try them all.
also you can try updating your app to see if that solves it.
—
Reply to this email directly, view it on GitHub
https://github.com/aniyomiorg/aniyomi/issues/1265#issuecomment-1888558609,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A3YQAAICVHPISALTOK3O5C3YODQORAVCNFSM6AAAAABBW6CGB6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBYGU2TQNRQHE
.
You are receiving this because you modified the open/close state.Message
ID: @.***>

Me too right now I'm reinstalling the old version from releases since it was working fine.

Indeed, I did make a backup before uninstalling but had the fear that the backup wouldn't work on the old version but it worked, and the player is working too

Really. Which version are you using and can u send me the version

Aniyomi v<IP_ADDRESS>

You should update

You should update

Yeah I agree but the bug make me stick to the old version,
I'm gonna be trying the new ones

This is most likely an issue with mpv. Use mpv as an external player and see if the problem still persists. If it does, there's not much we can do. If it doesn't please open a new issue.


[HOLD for payment 2023-04-24] [$1000] When sending an attachment, along with text, if you hit enter twice quickly the text message is duplicated.

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Copy a file/image to paste into the compose box
Type a sentence in the compose box
Paste the file in and tap return/enter twice quickly

Expected Result:
For there to be only one line of text
Actual Result:
The text is duplicated, showing above and below the attachment
Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[x] MacOS / Desktop

Version Number: 1.2.84-0
Reproducible in staging?: Need reproduction
Reproducible in production?: Need reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
https://user-images.githubusercontent.com/43996225/225101284-a8a6a7fa-520e-438b-b60b-e1a677efd12a.mp4
Expensify/Expensify Issue URL:
Issue reported by: @mallenexpensify
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1678720133261089
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01d818be187a45e3b9
Upwork Job ID:<PHONE_NUMBER>544971264
Last Price Increase: 2023-04-04

Current assignee @mallenexpensify is eligible for the Bug assigner, not assigning anyone new.

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)

If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead

[ ] This bug is reproducible using the reproduction steps in the OP. S/O

If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
If the reproduction steps aren't clear and you determine the correct steps, please update the OP.

[ ] This issue is filled out as thoroughly and clearly as possible

Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.

[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Checking to see if this might be related to deprecate sequence numbers
https://expensify.slack.com/archives/C04DC6LU2UB/p1678821566733629

Triggered auto assignment to @grgia (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

I can reproduce consistently so I'm removing the Needs Reproduction label. (Kavi wasn't able to).
@grgia can you try to reproduce?  (it's not urgent)

Yes, I was able to reproduce

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

Proposal
Please re-state the problem that we are trying to solve in this issue.
When we type in a text in the composer, immediately follow by pasting an image and send quickly, the composer old input still remains. Pressing enter another time will send the duplicated message
This is not only happening in Desktop, it's happening in all platforms.
What is the root cause of that problem?
First, let's look at the flow of sending the text from the composer only (without attachment).
When the user send a message, the submitForm function would be triggered here
https://github.com/Expensify/App/blob/8452784b6c4a3dc5e3ec3a8af2e0f4b01813e9f9/src/pages/home/report/ReportActionCompose.js#L657-L673
Notice the this.debouncedSaveReportComment.cancel(); function call. Here, we are not saving the draft text when sending the message, since it may cause the saved message being rendered again in the composer after it was send. Therefore, we have a correct logic here, which is cancel debouncedSaveReportComment when the message is being submitted.
Now, let's look at the flow of sending the text together with the attachment.
When the user type in a message, then send an attachment, both the text and the attachment will be send by the onConfirm function here, which calls to addAttachment() function
https://github.com/Expensify/App/blob/8452784b6c4a3dc5e3ec3a8af2e0f4b01813e9f9/src/pages/home/report/ReportActionCompose.js#L646-L650
And let's look at the prepareCommentAndResetComposer() function
https://github.com/Expensify/App/blob/8452784b6c4a3dc5e3ec3a8af2e0f4b01813e9f9/src/pages/home/report/ReportActionCompose.js#L625-L641
We can notice that's there is no cancel debouncedSaveReportComment when the message is being submitted logic similar to when we send text only. Therefore, after the text and attachment are sent, the debounce function now takes effect and save the old message draft, which cause it to be rendered in the composer. Now, pressing enter another time will send the message with the old content
What changes do you think we should make in order to solve the problem?

We should add the debounce cancellation in the prepareCommentAndResetComposer() function
// Don't submit empty comments or comments that exceed the character limit
        if (this.state.isCommentEmpty || ReportUtils.getCommentLength(trimmedComment) > CONST.MAX_COMMENT_LENGTH) {
            return '';
        }
+      this.debouncedSaveReportComment.cancel()
        this.updateComment('');
        this.setTextInputShouldClear(true);

What alternative solutions did you explore? (Optional)
We can apply cancellation in the beginning of prepareCommentAndResetComposer() function or the addAttachment() function to furthermore strengthen the check.
Result
Working well after the fix (sharing ggdrive link because the file is too big for GH)
https://drive.google.com/file/d/1qJSQUfR-nLIQ6F0nr6ayWN8Zr9c2ybiL/view?usp=share_link

@parasharrajat Thanks for your review. The debouncedSaveReportComment was not triggered on the attachment modal, but on the previous typed message. Because it needs to wait for ~200ms, when we paste in an attachment and send it fast, the debounced function (from the composer) is still triggering, saving the message in Onyx.
My point here is, we need to cancel the debounced function whenever we send the text, with or without the attachment.

@parasharrajat do you have any suggestions for how we should move this forward?

@mallenexpensify @parasharrajat @grgia this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ and will need to go internal. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

@grgia can you please review @tienifr 's proposal? https://github.com/Expensify/App/issues/15954#issuecomment-1486464385
This happens to me regularly still, so ping me if you need me to test anything

Yep, @tienifr's proposal looks good to me. Assigning now!

📣 @tienifr You have been assigned to this job by @grgia!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖

@parasharrajat @grgia  This PR is ready for review

@tienifr @parasharrajat can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~01d818be187a45e3b9
Also... very happy this is getting fixed, this issue happens to me every...single...day

@mallenexpensify accepted, thanks!

Regression Test Proposal
Bug: When sending an attachment, along with text, if you hit enter twice quickly the text message is duplicated
Proposed Test Steps:

Copy a file/image
Open any report and enter some text
Then paste a file/image into the compose box immediately
Pressing enter 2 times
Verify that the text entered in step 2 isn't displayed in composer and only displayed one time in chat

Do we :+1: or :-1:

Thanks @tienifr I updated it a tiny bit and created the GH ^

Reviewing label has been removed, please complete the "BugZero Checklist".

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.3.0-2 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/17067

If no regressions arise, payment will be issued on 2023-04-24. :confetti_ball:
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

[ ] External issue reporter
[ ] Contributor that fixed the issue
[ ] Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[ ] [@parasharrajat / @grgia] The PR that introduced the bug has been identified. Link to the PR:
[ ] [@parasharrajat / @grgia] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[ ] [@parasharrajat / @grgia] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[ ] [@mallenexpensify] Determine if we should create a regression test for this bug.
[ ] [@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[ ] [@mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@grgia or @tienifr any chance either of you know the PR that introduced this bug?
I've created the TestRail GH https://github.com/Expensify/Expensify/issues/276790
Also, i tested a bunch and wasn't able to reproduce. It used to happen to me all...the.... time.  Thanks for fixing it!

@mallenexpensify I haven't found the PR that introduced it

Before potentially starting a discussion in Slack, @grgia @parasharrajat , do you think it's beneficial to keep hunting for the PR? If so, why?  My understanding was that by commenting on the offending PR it helps others learn what when wrong and to help avoid similar issues in the future.

Bump @mallenexpensify

Sorry, was OOO for a bit.  @tienifr paid $1500 (inc. timeliness bonus, PR was merged in two days)
@parasharrajat can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~01d818be187a45e3b9

Thanks all, Rajat paid, closing


test iam user

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

Codecov Report

Merging #18 (5b3639b) into master (c35e84e) will increase coverage by 1.40%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #18      +/-   ##
==========================================
+ Coverage   79.28%   80.69%   +1.40%
==========================================
  Files         936      315     -621
  Lines       47411    25283   -22128
  Branches     5778        0    -5778
==========================================
- Hits        37592    20402   -17190
+ Misses       9693     4881    -4812
+ Partials      126        0     -126

Flag
Coverage Δ

cypress
?

hive
?

javascript
?

mysql
80.57% <ø> (ø)

postgres
80.61% <ø> (ø)

presto
?

python
80.69% <ø> (-0.46%)
:arrow_down:

sqlite
80.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

superset/db_engines/hive.py
0.00% <0.00%> (-82.15%)
:arrow_down:

superset/db_engine_specs/hive.py
74.42% <0.00%> (-16.42%)
:arrow_down:

superset/db_engine_specs/presto.py
81.83% <0.00%> (-6.48%)
:arrow_down:

superset/views/database/mixins.py
81.03% <0.00%> (-1.73%)
:arrow_down:

superset/connectors/sqla/models.py
89.08% <0.00%> (-1.68%)
:arrow_down:

superset/db_engine_specs/base.py
86.62% <0.00%> (-0.46%)
:arrow_down:

superset/models/core.py
89.10% <0.00%> (-0.28%)
:arrow_down:

superset/utils/core.py
88.83% <0.00%> (-0.13%)
:arrow_down:

superset-frontend/src/explore/dateFilterUtils.ts

...src/dashboard/components/FiltersBadge/selectors.ts

... and 619 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c35e84e...5b3639b. Read the comment docs.

/testenv up

/testenv up

/testenv up

/testenv up


:ActiveHover  is not a valid selector error

I'm trying to use this lib css http://cdnjs.cloudflare.com/ajax/libs/semantic-ui/2.2.11/semantic.min.css with react-snap which uses puppeteer  to pre-render static html and I get this error:
Failed to execute 'querySelector' on 'Document': '.ui.labels a.active.label:ActiveHover:before' is not a valid selector.

The error is correct, provided selector is not valid.
https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_Selectors

@layershifter any suggestion on  what I should do to get this lib working with react-snap ? since this is the error that is the cause for not being able to integrate the two libs.

@jasan-s that CSS file is built using SUI core. I'd open an issue on the core project about this. The error is indeed correct. That's not a valid CSS selector.
I did a quick search for you though and didn't see any issues open about it (https://github.com/Semantic-Org/Semantic-UI/search?utf8=✓&q=%3AActiveHover&type=). It only occurs in the Label component. If you are not going to use the label component, you could do your own build of the CSS that does not contain the label component and it would work fine. That would be outside of the scope of the SUIR project here.


Numpy Based Indexing and Updates in Tensors

Issue type
Feature Request
Have you reproduced the bug with TensorFlow Nightly?
Yes
Source
binary
TensorFlow version
2.15
Custom code
Yes
OS platform and distribution
WSL Ubuntu 22.04.3 LTS
Mobile device
N/A
Python version
3.11
Bazel version
No response
GCC/compiler version
No response
CUDA/cuDNN version
N/A
GPU model and memory
No response
Current behavior?
Can eager tensors finally get support for numpy indexing? Since eager mode is design to reduce programming fatigue, it personally makes no sense to index using a function like tf.scatter_nd. It also makes the code less readable, when implementing SOTA models and considering the expectations of modern frameworks, it might be better to overhaul the immutability.
Standalone code to reproduce the issue
This code should ideally work:

import tensorflow as tf
from tensorflow import keras

array = tf.constant([1, 2, 3, 4])
array[1] = 1

print(array) # [1, 1, 3, 4]

Relevant log output
No response

or at least support this type of indexing after experiment_enable_numpy_behavior has been applied.

Are there any updates or plan for this feature?

I have, but the reason I added this as a feature request is because a function is a bit verbose to replace standard indexing. I was wondering if it was possible to add standard index update instead, since it would make ease use better.

I see.


doc Add English version of regression test doc

Proposed changes
Added English version of regression test doc, according to the original Chinese version  https://doris.apache.org/community/developer-guide/regression-testing/
Searched for existing issues and active PRs and found no duplicate (doing the same thing)
Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

I checked and see the english documentation is already up to date. Closing this PR.


When will pre-training code be released?

This  pre-training model：pretrained/ETP/mlm.sap_r2r/ckpts/model_step_82500.pt

Thanks for your interest!
I'm busy with other things recently and we are still tidying the pre-training code.
Please stay tuned.


middleware not executing after request is complete

I'm facing 2 issues:

After a response is sent, no other middleware afterwards is executed, even if next is called

// index.ts
router
  .get("/live", live, logRequest);

await server
  .use(router)
  .listen(env.port, () => {
    logger.info(`server listening on port ${env.port.toString()}`);
  });

// live.ts
import { MiddlewareNext, Request, Response } from "hyper-express";

const bootTime = performance.now();

export const live = (req: Request, res: Response, next: MiddlewareNext) => {
  const uptime = Math.round((performance.now() - bootTime) / 1000);

  res.json({ uptime });

  next();
};

// logRequest.ts
export const logRequest = (
  req: Request,
  res: Response,
  next: MiddlewareNext,
) => {
  console.log("this line is never reached!");

  next();
};

How do I inspect the current state of the response object? e.g

const middleware1 = (req, res, next) => {
  res.setHeader("foo", "bar");
}

const middleware2 = (req, res, next) => {
  console.log(res); // headers are not inspectable anywhere
  // console.log(res.getHeaders()); // getHeaders is not a function
}

I've worked around the issues:

diff --git a/src/components/router/Route.js b/src/components/router/Route.js
index 97c7e12a1f52484d7dcedba9b3599126420997c2..087d86fb24c5b78842bcea6fc83880372efccb49 100644
--- a/src/components/router/Route.js
+++ b/src/components/router/Route.js
@@ -67,9 +67,6 @@ class Route {
      * @param {Number=} cursor The middleware cursor.
      */
     handle(request, response, cursor = 0) {
-        // Do not handle the request if the response has been sent aka. the request is no longer active
-        if (response.completed) return;
-
         // Retrieve the middleware for the current cursor, track the cursor if there is a valid middleware
         let iterator;
         const middleware = this.options.middlewares[cursor];

This patch makes it so the middleware chain doesn't stop when the request is completed. If this behavior is desirable in general (I don't see why not), it's probably a very easy change to make.

I set the headers in res.locals - a bit cumbersome, but it did the trick

Hey, HyperExpress stops executing requests / middlewares If the request is disconnected or closed during traversal. This is a decision primarily made due to the expected behavior of request always being connected while execution of middlewares and also to prevent accidental bugs from calling Response methods which can no longer interact with the underlying uWS.HttpResponse object.


A rather common but vital problem about confidence map

Thank you for your good work!
I notice that in both CD-branch and DD-branch, confidence maps(concatenated with CD-depth and DD-depth respectively) are generated by the last convolutional layer, which are comprized of ordinary conv+bn+relu layer.
self.rgb_decoder_output = deconvbnrelu(in_channels=32, out_channels=2, kernel_size=3, stride=1, padding=1, output_padding=0)

rgb_output = self.rgb_decoder_output(rgb_feature0_plus)
rgb_depth = rgb_output[:, 0:1, :, :]
rgb_conf = rgb_output[:, 1:2, :, :]

self.decoder_layer6 = convbnrelu(in_channels=32, out_channels=2, kernel_size=3, stride=1, padding=1)

depth_output = self.decoder_layer6(decoder_feature5)
d_depth, d_conf = torch.chunk(depth_output, 2, dim=1)
rgb_conf, d_conf = torch.chunk(self.softmax(torch.cat((rgb_conf, d_conf), dim=1)), 2, dim=1)

I wonder how convbnrelu layer can output a neat confidence map and a depth map without confidence supervision. Would you please provide me with some relavant works or papers to see? Thanks.

Thanks for your interest! In this work, the confidence maps are neat because we impose intermediate supervision on their corresponding depth maps respectively, leading to implicit constraints for confidence.

Thank you for your reply! Does intermediate supervision requires a ground truth confidence in corresponding scale?

Thanks for your interest! In this work, the confidence maps are neat because we impose intermediate supervision on their corresponding depth maps respectively, leading to implicit constraints for confidence.

Thank you for your reply! Does intermediate supervision requires a ground truth confidence in corresponding scale?

No, only ground truth depth maps are required. Meanwhile the sum of exponential confidence is regularized to one by the softmax function.


[Tech Debt] - Updated Stripe library

What ❓

Updated the Stripe version to 8.1.0

Story 📖
External Library Sweep

Have you also tested this on the settings v3 branch? That's where we actually use Stripe

Tested this on v3 I added a new card it works!.


Simplify the code in firmament pkg

1，format the import style
2, simplify the const int from 0  to 10 using iota

@jiaxuanzhou Thanks for the PR.
The files that you have modified are auto-generated from the .proto files.
Changing them is not a good idea in my opinion.
If we add more service function's or other field's to the .proto file and again generate them,
your changes will be lost in the newly generated files and one will have to redo them again.
So I think we can ignore them.

/close


[DRAFT] feat: removes bux dependencies by adding bux-models package layer

@wregulski this is also failing tests/linter

@wregulski this is also failing tests/linter

@mrz1836 could you please take a look if it's only utils/utils.go
file?
I think I didn't touch it while creating my solution so I am not sure what is the best way to fix this to-do.

@wregulski @dorzepowski tests are still failing

Requires rebasing, tests are also failing
@mrz1836  I hope everything is currently up to date and tests are fixed

Codecov Report

Merging #140 (b3eac03) into master (1182d46) will increase coverage by 2.46%.
The diff coverage is 52.92%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files

@@            Coverage Diff             @@
##           master     #140      +/-   ##
==========================================
+ Coverage   40.01%   42.48%   +2.46%
==========================================
  Files          18       20       +2
  Lines        2169     2314     +145
==========================================
+ Hits          868      983     +115
- Misses       1244     1248       +4
- Partials       57       83      +26

Flag
Coverage Δ

unittests
42.48% <52.92%> (+2.46%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

examples/register_xpub/register_xpub.go
0.00% <0.00%> (ø)

paymail_addresses.go
0.00% <0.00%> (ø)

transports/graphql_admin.go
5.72% <2.85%> (+0.05%)
:arrow_up:

transports/http_admin.go
5.39% <5.55%> (+0.08%)
:arrow_up:

access_keys.go
50.00% <50.00%> (ø)

destinations.go
62.50% <62.50%> (ø)

transports/authentication.go
62.85% <62.85%> (ø)

transports/http.go
42.36% <63.75%> (+1.06%)
:arrow_up:

utils/utils.go
64.28% <64.28%> (ø)

transports/graphql.go
57.58% <65.51%> (-0.34%)
:arrow_down:

... and 3 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1182d46...b3eac03. Read the comment docs.


Locale selector: Finalize design & obtain approval

Wonil-Suh1 created the following on Jul 15:
This issue is for the approval process for the locale selector final design.
Acceptance criteria

[ ] Complete the visual design
[ ] Socialize with key stakeholders (Mary O'Donnell, DGC and IDL)
[ ] DGC approval

Original issue: https://github.ibm.com/webstandards/digital-design/issues/1230

On Aug 08, larahanlon commented:
Making some suggestions for locale selector behaviors/motion. @james-dow this is just to get started. Please take a look at this PDF for notes.
Sketch file is here.

On Aug 08, larahanlon commented:
Hey @Wonil-Suh1 @Olivia-Flory @james-dow
I'm looking for your feedback on these explorations for country-language pages that are unavailable. Which do you think is most successful, considering user interaction + layout + component usage:
—

List item text style is disabled-02 with info tooltip on the left.

List item text style is disabled-02 with info tooltip on the far-right, note the edge alignment.

List item text style is disabled-02 with info tooltip on the right, slightly different position than above.

Both the text style and area is disabled with no info icon or tooltip.

Both the text style and area is disabled but with a tooltip.

On Aug 08, Wonil-Suh1 commented:
Thank you @larahanlon. Should the icons be gray as well, and turn dark on hover?
I lean towards the last option where there is no icon, I feel that it has a fairly good affordance.

On Aug 08, Wonil-Suh1 commented:
One comment about the type scales, I wonder if this makes more sense:

The region is the top heading
"Choose your language" is smaller and secondary text color

Because the actions are pretty self evident at this point.

The call to action and the search field is attached to the list

On Aug 08, larahanlon commented:
Cool thanks @Wonil-Suh1 I agree with the disabled + tooltip option.
RE: type scales. I considered this in earlier studies but after exploring I don't think it makes logical sense in the overall flow: In the region selector step, the large text prompts an action. If we change the text scale in the following screen then the larger text becomes a label/title rather than a prompt.

If we look at the initial modal it also opens up with a prompt:

Although connecting Choose your country-language and Search field makes a lot of sense, my thought is to keep the type scales consistent with the purpose of the message.

On Aug 08, james-dow commented:
Is there a reason we aren't just hiding the ones we don't have translations for? Or maybe if we still want to show them group at the bottom of everything with a label "unavailable" or something. I like the cleanliness of not having the info icon, but I can see the tooltip getting on my nerves as I scroll and try to read things.

On Aug 08, Wonil-Suh1 commented:
Yep, I understood why you designed that way. But another way to look at this is that "Europe" is the region you selected - it directly corresponds to the prompt on the first screen. I'm not sure if presenting "Europe" as a small heading makes sense.

On Aug 08, Wonil-Suh1 commented:
@james-dow that's a good point - the tooltip popping up on every unavailable entry will be annoying. then how about grayed out info icon that turns darker on hover?

On Aug 08, james-dow commented:
Quickly threw this together in reference to the grouping comment above. Just another way to think about it. Also, we might could explore in the future having a link to request an unavailable translation.

On Aug 08, larahanlon commented:
Yep you're right @james-dow it would be so annoying. My understanding is that we need to show the country-language even if the page is unavailable (because there may be other pages in that country-language). Grouping them at the bottom is a good suggestion. The grayed-out icon may also help to solve.
I'd like to do an A/B test of the locale selector in general (there are many alternative solutions for similar moments) so we could include two options for the disabled view in that.

On Aug 08, james-dow commented:
Oh, I would think a single scroll. Two probably would be way too much. The list of unavailable grouped at the bottom would be getting them out of the way so people can quickly select from what's available, and yet still find the list of unavailable if necessary.

On Aug 08, Wonil-Suh1 commented:
@james-dow interesting idea. will the two lists scroll together or are they two separate scrolling lists?

On Aug 08, Olivia-Flory commented:
You could consider only showing the tooltip upon hover of the icon vs the entire country name, I think people are pretty used to having to hover over the info icon.
I also prefer options 2 and 3 where the icon is on the left and doesn't alter the alignment of the type, I feel option 1 is more difficult to scan because the icon is left aligned and indents the disabled fields.
Did you consider moving the info icon to the right of either the country or language? I had left the info icon at 16px for tooltip in our theme because it is a secondary/functional item.

On Aug 12, larahanlon commented:
@Wonil-Suh1 @Olivia-Flory
Question about alignment of search and country-language list. Which of the following looks better / fits with our overall system approach?
1.
The search field hangs 16px over left and right. The search icon aligns with the rest of the text in the modal. The horizontal dividers between country-language is inset at 32px and aligns with the text.

2.
The search field hangs 16px over left and right. The search icon aligns with the rest of the text in the modal. The horizontal dividers between country-language also hang 16px left and right and does not align with the text.

3.
The search field is inset at 32px and aligns with all text and dividers.

—
—
—
I think option 1 is visually the most successful. I think our hover states can still hang 16px from the divider lines:

On Aug 12, larahanlon commented:
Feedback from Friday 9 discussion (Wonil, Olivia, Lara)

Go back to smaller margins. There should be 32px between the edge of modal and left-aligned text, 16px between the edge of modal and card.
Check grid alignment.
Agreed not to use link for languages in the list.
Need to provide 2 options for disabled country-languages: 1) Disable the text, add info icon in gray beside language 2) move all disabled links to the bottom of the list
Alt solution for disabled items = do not include at all. Need to clarify with Mary.
Search should be inset 32px from the edge. Position above the list items.

On Aug 12, Olivia-Flory commented:
Initially, I lean towards 3 because we talked about search+icon being inset with the rest of the content.  But I think 1 could work too, and Carbon seems to overhang search on their icon library page.
I tried to find examples on Wake of aligning to the columns vs overhang and couldn't find much.
Something about 2 feels a bit off, for whatever reason the horizontal rules feel too tight.

On Aug 13, Wonil-Suh1 commented:
One thing - i feel that the space between the top row and the search field should not be there - repeating 48px through out may simplify the layout further.

On Aug 13, Wonil-Suh1 commented:
Hmmm, in 3, the search field feels small - i know it's an optical illusion, but it does impact the overall visual balance to me. For that reason I lean towards 1 or 2. One potential issue with 1 might be that as the list scrolls, that the inset rules do not align with the search field may become visible, and for this reason I lean towards option 2. The hover state in 1 and 3 feels awkward.
All things considered, option 2 feel the right way to go.

On Aug 13, larahanlon commented:
Thanks! @Wonil-Suh1 @Olivia-Flory
@Wonil-Suh1  that extra 8px space below the search was intentional to show one way that we could visualize the scroll-behind:

The other option could look like this, which is arguably neater but lacks some depth:

On Aug 13, Wonil-Suh1 commented:
I lean towards the second option where the search touches the list — being essential. and that does create a bit of a delightful moment too, AND aligned very well with the concept of IBM.com as a platform.

On Aug 13, larahanlon commented:

👆I'd like to still vote for this option – option 1 with added 8px spacer and inset dividers – for the following reasons:
1. 8px spacer is common across IDL/Carbon nav components.
So if we look at the left-nav panel, 8px (or 16px) is used to separate either different nav components or sub-menu items:
Carbon

Brand Center

2. Masthead alignment
In our new masthead we inset the dropdown divider lines but allow the hover to fill the width of the component:
L0 dropdown

Brand Center do the same (see above).
3. Readability
I worry that there isn't enough delineation between the Search text field and the list item that could be scrolling behind. Maybe the drop shadow will be enough but I'm not 100% convinced:
Search and Botswana are competing here

4. Interaction / safe zone
What if I'm trying to select Search here but accidentally click the country-language behind the field?
Oops

Adding 8px and the drop shadow clearly separates the two clickable fields IMO:

—

On Aug 13, Wonil-Suh1 commented:
I see what you are talking about, but in this case I feel that it's very similar to data table UX model where the tool is attached to the content.

And the same applies to the rules - this is way closer to tables than dropdown menu.

Also considering the impact on the overall layout, I feel that overhanging rules actually simplify the overall look and feel better than two different widths mixing with each other.

On Aug 16, hahnrob commented:
Included in the Aug 16, 2019 sprint review meeting. Can be closed.


Command API

Description
Will solve issue: #332
This is draft, because I want to get feedback on early stage.
API contains Parsable objects (like integers, floats, entity selectors and etc..)
Each Parsable object implements Parsable trait.
The things I think the most will find strange:

Error and Suggestions are the objects which are implementing a trait to convert them to text error and suggestions.
Parsable accepts ParsingSuggestion which says for what ParsingResult will be used. I think it will be useful for objects which are expensive to calculate.
ParsingResult is not an actual standard result but the struct which contains suggestions and result. I didn't found another way to do it better (I would like ParsingResult to be an std result)
Error contain position of it. Brigadier doesn't require it but I think it would be a useful thing for e.g. snbt

Not a full review from me yet, but that's what I've noticed so far.

I changed the whole system again. Now:

Nodes are entities, that are connected with each other using NodeFlow
Executable nodes have NodeSystem component, which contains a bevy's system, which will be executed when the command is executed
Argument nodes have NodeParser component, which contains a boxed trait, which parses reader and puts the parsed object into special struct called ParseResultsWrite
Literal nodes have just NodeName on them (no NodeParser)
Root nodes can have NodeExclude component on them to exclude nodes that this specific root node don't want to use
Multiple nodes which can be chosen using EntityNode component (if there is not such component on an entity then PrimaryRootNode will be chosen)
Now commands have a few methods to manipulate with node's entities ( spawn_node, node, spawn_root_node)

Check out example command.rs

I know that this is likely completely of the rails compared to the current implementation but cant we just use bevy plugins and events? this way we are tightly coupled with bevy and would make it much nicer to code. I have a few ideas on how this could look here is one (I just typed these up on the textbox so could have errors):
struct TeleportCommand;

impl Command for TeleportCommand {
    fn command(&self) -> impl Into<String> {
        "tp"
    }
    fn params(&self) -> impl Into<Vec<CommandParameter>> { // with CommandParameter being some kind of enum
        vec![CommandParameter::Position]
        // This might also be vec![CommandParameter::Position(None)] or even vec![CommandParameterMarker::Position]
    }
    // ...
}

// ...
app.add_plugins(CommandHandler::from_command(TeleportCommand))
// this should send out events that look something like CommandExecutionEvent<TeleportCommand>
// this event should contain the params.

I have good ideas on how to make this happen and if you think it is a good idea I could work on the code? again I am really just throughing something out into the blue here but I would like to see an as ergonomic as possible API for this.

I haven't looked too much into this PR yet, but would it be possible to make command parsing work via the clap crate? I feel like that'd make things a lot simpler and reliable long-term.
Sorry if this PRs already doing that or anything, it was just a thought in my head and I thought I'd go ahead and mention it.

No, the way that minecraft commands work is not compatible with clap. IIRC, this was explicitly discussed on the thread in discord. Minecraft commands can have cyclic references for suggestions, and parsers for stuff like coordinates and entity references (eg, @p) would be very hard under clap's model.

Suggestions are done. @rj00a, can you review current code?

Sorry, I might be a bit slow to review this.

The basic things are done and the problem with storing nodes as bevy's entities also. Now I just need to do a macro and other's arguments

This should be closed or renamed as #446 has been merged.

@rj00a this should be closed.


Expose ImporterMesh.create_shadow_mesh() to scripting

Following the suggestion in:
https://github.com/godotengine/godot-proposals/issues/8567
Tested with both an editor and a template_release build. The methods are confirmed to work as desired in the editor build.

For the record, your commit seems not to be linked to your GitHub account. See: Why are my commits linked to the wrong user? for more info.
(In this case you authored your commit with<EMAIL_ADDRESS>which is obviously not a valid email for your account.)

You would also need to generate the class reference for these new exposed methods, and fill their descriptions. See https://docs.godotengine.org/en/stable/contributing/documentation/updating_the_class_reference.html#updating-class-reference-when-working-on-the-engine

Seems fine once docs are added as pointed out by Akien

@laurentmackay Can you look into addressing the above comment? If you don't have time, let us know and someone else can salvage the pull request :slightly_smiling_face:

Thanks for the feedback!
Sorry for the delay, I was running into git issues....
I have generated the required documentation. I also rebased which hopefully is not a problem.

Lots of unrelated commits show up, you probably messed up the rebase :(


cloudfront does not forward query string

Compare:
% curl -s 'https://dkyhjv0wpi2dk.cloudfront.net/api/v1/test-list/urls?limit=17&probe_cc=IT'|jq '.results|length'
1421

to:
% curl -s 'https://ps.ooni.io/api/v1/test-list/urls?limit=17&probe_cc=IT'|jq '.results|length'
17

I have added as assignees me, Federico, and Arturo and tentatively the next sprint. I am most likely not the owner of this issue, though, so feel free to shuffle / modify / change.

This documentation should allow us to fix the issue: https://docs.aws.amazon.com/cloudfront/latest/APIReference/API_ForwardedValues.html

I think I figured out how to do this, hence there's no need to keep others posted.

Fixed!

I configured the CloudFront to pass along the query string and the Authorization header. I set zero seconds as the caching interval because that looked like right. It's now WAI.


[helm3] helm template with --output-dir doesn't write template with a hook to file

Output of helm version:
3.1.2
Output of kubectl version:
1.18.0
Cloud Provider/Platform (AKS, GKE, Minikube etc.):
CentOS Linux release 7.7
The same problem still persists in Helm 3.1.2.
https://github.com/helm/helm/issues/7001
If a template contains hook annotation helm template --output-dir mydir works incorrectly.
It does not write generated text for template with a hook to the file.
Instead it prints the output to the console.
Example
cat init-job.yaml

apiVersion: batch/v1
kind: Job
metadata:
  annotations:
    "helm.sh/hook": "post-install"
    "helm.sh/hook-weight": "0"
    "helm.sh/hook-delete-policy": "before-hook-creation"
  name: init
  ...

helm template --debug --output-dir /test/out -f values-my.yaml

install.go:158: [debug] Original chart version: ""
install.go:175: [debug] CHART PATH: /test/mychart

wrote /test/out/secret.yaml
wrote /test/out/service.yaml
...

---
# Source: init-job.yaml
apiVersion: batch/v1
kind: Job
metadata:
  annotations:
    "helm.sh/hook": "post-install"
    "helm.sh/hook-weight": "0"
    "helm.sh/hook-delete-policy": "before-hook-creation"
  name: init
  ...

I've replicated this bug on the tip of master. The linked issue that previously reported this and was closed does not appear to have a PR in 3.1.0 where it says it was fixed.
@obolobova thanks for reporting this.

/assign

/assign waveywaves

Hi @ware you still interested in working on this issue?

@hickeyma  could you please review the PR ? thanks!😄

@bacongobbler  could you please review the PR if you are fee.


Create PITCHME.md

Created basic PITCHME. #60

Sorry @TheSteelBarr, I had to dismiss your review as it was stale (I added more stuff after you reviewed). You'll have to re-approve the new changes before I can merge.
Nice reviewing though :1st_place_medal:


Update to hubpress last version

can't remove ... sorry

No problem, Stanislas. If you haven't already worked out the reason why you
got the PR wrong, check out Updating Your HubPress Blog Instance:
https://youtu.be/KCylB780zSM for the method (and don't worry: I made the
same mistake ;) )
On Wed, Mar 18, 2015, 20:07 Stanislas Boyet<EMAIL_ADDRESS>wrote:

can't remove ... sorry
—
Reply to this email directly or view it on GitHub
https://github.com/HubPress/hubpress.io/pull/141#issuecomment-82866142.