double click to add field to a sheet

(Similar to Tableau’s Show Me: Add to Sheet)
We can easily leverage https://github.com/uwdata/compass to implement this.

We already have this in Voyager 2, just need to merge it back here.

Duplicate of https://github.com/uwdata/voyager2/issues/161


Simplify the environment variables

Theres still a lot of duplicated variables, these need merging and clarifying.

There is even more too 👅
For the consumer, after i converted to modules, I moved them all here as modules are instantiated once
https://github.com/Gabisonfire/torrentio-scraper-sh/blob/master/src/node/consumer/src/lib/config.js
For the producer, anything in the json files in the Configuration folders can be an env var.

@iPromKnight yeah, I am not well versed in JS so it’s a nightmare. I’m almost learning as I’m going lol. Feel free to pull the branch from my fork and push some changes and PR it 😂
I’m done for today. It’s sit on the sofa and watch crappy TV time

@iPromKnight or @Gabisonfire
Can one of you offer me the way to change:
ScrapeConfiguration__StorageConnectionString=host=postgres;username=postgres;password=postgres;database=selfhostio;

so it will use the
# PostgreSQL
POSTGRES_HOST=postgres
POSTGRES_PORT=5432
POSTGRES_USER=postgres
POSTGRES_PASSWORD=postgres
POSTGRES_DB=selfhostio

variables instead. Ideally I want to strip out all double coded values.
I can see in this file:
https://github.com/Gabisonfire/torrentio-scraper-sh/blob/57f4757541eceda82c553e2a7ca7e7063ffb7ee8/src/producer/Extensions/ServiceCollectionExtensions.cs

I'm going to add comments into the code, if we can make a habit of this going forward I'd be a lot happier.
I can see a few undocumented environment variables, like:
const NO_CACHE = process.env.NO_CACHE || false;

I'm curious what the consequences would be if we disabled the cache, is this a functionality we wish to keep or am I safe in assuming this could be removed.
Can I confirm @iPromKnight that you have no plans to drop a 32k commit completely rewriting the addon or consumer 😂😂😂😂😂😂
If you do please let me know 😋

I'm currently changing this to be 1:1 functionality with the old, just a simple rewrite.
    MONGO_URI: process.env.MONGODB_URI || 'mongodb://mongo:mongo@localhost:27017/selfhostio?authSource=admin',

becomes:
    MONGODB_HOST: process.env.MONGODB_HOST || 'mongodb',
    MONGODB_PORT: process.env.MONGODB_PORT || '27017',
    MONGODB_DB: process.env.MONGODB_DB || 'selfhostio',
    MONGO_INITDB_ROOT_USERNAME: process.env.MONGO_INITDB_ROOT_USERNAME || 'mongo',
    MONGO_INITDB_ROOT_PASSWORD: process.env.MONGO_INITDB_ROOT_PASSWORD || 'mongo',

I want to remove the defaults, and set a few variables as necessary. Some others can remain optional, and they all need documenting.
Error handling needs adding.

Pausing for a few hours. Haven't tested the latest push yet. It should work.

@iPromKnight or @Gabisonfire
Can one of you offer me the way to change:

ScrapeConfiguration__StorageConnectionString=host=postgres;username=postgres;password=postgres;database=selfhostio;

so it will use the

# PostgreSQL

POSTGRES_HOST=postgres

POSTGRES_PORT=5432

POSTGRES_USER=postgres

POSTGRES_PASSWORD=postgres

POSTGRES_DB=selfhostio

variables instead. Ideally I want to strip out all double coded values.
I can see in this file:
https://github.com/Gabisonfire/torrentio-scraper-sh/blob/57f4757541eceda82c553e2a7ca7e7063ffb7ee8/src/producer/Extensions/ServiceCollectionExtensions.cs
and then your comment @iPromKnight:
For the producer, anything in the json files in the Configuration folders can be an env var.

Morning Emily
Sorry out this am for a few hours.
Yeah I will sort that out we'd have to introduce new properties for them in the Models/ScraperConfig file and turn the connection string into a computed property. I'll do later 😃

I'm going to add comments into the code, if we can make a habit of this going forward I'd be a lot happier.
I can see a few undocumented environment variables, like:

const NO_CACHE = process.env.NO_CACHE || false;

I'm curious what the consequences would be if we disabled the cache, is this a functionality we wish to keep or am I safe in assuming this could be removed.
Can I confirm @iPromKnight that you have no plans to drop a 32k commit completely rewriting the addon or consumer 😂😂😂😂😂😂
If you do please let me know 😋

Haha no nothing like that. I'm going to try to see how they run under bun as opposed to nodejs when I get home as it's really gaining traction now

@iPromKnight yeah, I am not well versed in JS so it’s a nightmare. I’m almost learning as I’m going lol. Feel free to pull the branch from my fork and push some changes and PR it 😂
I’m done for today. It’s sit on the sofa and watch crappy TV time

Me neither really. Not used it in years but it's all been coming back this week lol. I much prefer strongly typed typescript.
I've been a .net dev for 23 years though lol

@iPromKnight or @Gabisonfire
Can one of you offer me the way to change:

ScrapeConfiguration__StorageConnectionString=host=postgres;username=postgres;password=postgres;database=selfhostio;

so it will use the

# PostgreSQL

POSTGRES_HOST=postgres

POSTGRES_PORT=5432

POSTGRES_USER=postgres

POSTGRES_PASSWORD=postgres

POSTGRES_DB=selfhostio

variables instead. Ideally I want to strip out all double coded values.
I can see in this file:
https://github.com/Gabisonfire/torrentio-scraper-sh/blob/57f4757541eceda82c553e2a7ca7e7063ffb7ee8/src/producer/Extensions/ServiceCollectionExtensions.cs
and then your comment @iPromKnight:
For the producer, anything in the json files in the Configuration folders can be an env var.

Morning Emily Sorry out this am for a few hours.
Yeah I will sort that out we'd have to introduce new properties for them in the Models/ScraperConfig file and turn the connection string into a computed property. I'll do later 😃

Great! You think it’s worth doing the same with RabbitMQ as well? The service you proposed in #45 will need access to Rabbit as well right? Tidy the Rabbit vars up so it’s easier to switch to an unattached service if the user already has one.
I think Mongo and Postgres are done. Just needs testing to make sure nothing is broken.
I am trying to back edit some of the changes you made into the consumer into the add on.
How much of the code from addon/consumer is reused? Could these two be merged into one folder with a different entrypoint.sh/command.
From my quick perusal a lot of the code is duplicated anyway so all we are doing is doubling the maintenance cost.

I'm going to add comments into the code, if we can make a habit of this going forward I'd be a lot happier.
I can see a few undocumented environment variables, like:

const NO_CACHE = process.env.NO_CACHE || false;

I'm curious what the consequences would be if we disabled the cache, is this a functionality we wish to keep or am I safe in assuming this could be removed.
Can I confirm @iPromKnight that you have no plans to drop a 32k commit completely rewriting the addon or consumer 😂😂😂😂😂😂
If you do please let me know 😋

Haha no nothing like that. I'm going to try to see how they run under bun as opposed to nodejs when I get home as it's really gaining traction now

I’ll nod along and trust your judgement. The only bun I’m thinking of is 🧁

@iPromKnight
Is this a bug? Addon cache is hard coded as: selfhostio_addon_collection
Consumer cache is using cacheConfig.COLLECTION_NAME which is selfhostio_consumer_collection
Should these be the same value?

I'm going to add comments into the code, if we can make a habit of this going forward I'd be a lot happier.
I can see a few undocumented environment variables, like:

const NO_CACHE = process.env.NO_CACHE || false;

I'm curious what the consequences would be if we disabled the cache, is this a functionality we wish to keep or am I safe in assuming this could be removed.
Can I confirm @iPromKnight that you have no plans to drop a 32k commit completely rewriting the addon or consumer 😂😂😂😂😂😂
If you do please let me know 😋

Haha no nothing like that. I'm going to try to see how they run under bun as opposed to nodejs when I get home as it's really gaining traction now

I’ll nod along and trust your judgement. The only bun I’m thinking of is 🧁

Haha 👅
Unfortunately Bun is a no go..
For now at least
3 Hours of fixes getting the database to connect only for it to fail on ingestion as bun doesn't currently implement dgram, so the torrent info extracted doesn't work (no UDP support)
Hey-ho - one day ^^. They have it on the backlog

@iPromKnight
Is this a bug? Addon cache is hard coded as: selfhostio_addon_collection
Consumer cache is using cacheConfig.COLLECTION_NAME which is selfhostio_consumer_collection
Should these be the same value?

No no - the consumer one is just for imdbIds - once its found one for a series etc, it keeps it cached for 7 days so that if it finds another episode or another file in the torrent it needs to look up, it can get the id without having to go off and use name-to-imdb, which is rate limited, or the fall-back google search
Should probably be an env var on the addon though - and not hard coded 😄
I'm actually about to push a PR that updates cache-manager to the latest version, and I definitely agree with the reuse issue
I think for lib - it kinda makes sense to create a shared project, and bring it into both the consumer and addon, get rid of all this duplication.

I'm going to add comments into the code, if we can make a habit of this going forward I'd be a lot happier.
I can see a few undocumented environment variables, like:

const NO_CACHE = process.env.NO_CACHE || false;

I'm curious what the consequences would be if we disabled the cache, is this a functionality we wish to keep or am I safe in assuming this could be removed.
Can I confirm @iPromKnight that you have no plans to drop a 32k commit completely rewriting the addon or consumer 😂😂😂😂😂😂
If you do please let me know 😋

Haha no nothing like that. I'm going to try to see how they run under bun as opposed to nodejs when I get home as it's really gaining traction now

I’ll nod along and trust your judgement. The only bun I’m thinking of is 🧁

Haha 👅
Unfortunately Bun is a no go..
For now at least
3 Hours of fixes getting the database to connect only for it to fail on ingestion as bun doesn't currently implement dgram, so the torrent info extracted doesn't work (no UDP support)
Hey-ho - one day ^^. They have it on the backlog

@iPromKnight
Is this a bug? Addon cache is hard coded as: selfhostio_addon_collection
Consumer cache is using cacheConfig.COLLECTION_NAME which is selfhostio_consumer_collection
Should these be the same value?

No no - the consumer one is just for imdbIds - once its found one for a series etc, it keeps it cached for 7 days so that if it finds another episode or another file in the torrent it needs to look up, it can get the id without having to go off and use name-to-imdb, which is rate limited, or the fall-back google search
Should probably be an env var on the addon though - and not hard coded 😄
I'm actually about to push a PR that updates cache-manager to the latest version, and I definitely agree with the reuse issue
I think for lib - it kinda makes sense to create a shared project, and bring it into both the consumer and addon, get rid of all this duplication.

Agree with the shared library idea.

Just the producer left to tidy up @iPromKnight to get everything on the same level.
The library idea can be done in another request.

I'll pull down in a few and sort it out cheers Emily


🌱 Update quickstart guide with upstream ccm

What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1401
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs:

[ ] squash commits
[ ] include documentation
[ ] add unit tests

@janiskemper PTAL when you get time. Thanks!

Looks like the lychee lint check is passing, but marking it as fail GitHub action.

@guettli can you review and check why the linting fails? Looks very weird. exit code 2 but no error is shown

thanks a lot @SD-13 for this PR btw ;)

@janiskemper Happy to help🙂

Looks like the lychee lint check is passing, but marking it as fail in GitHub action.

@SD-13 this is fixed on the main branch.

@guettli Thanks for fixing the lint check, now CI looks green!

@guettli can you review / approve?


Cash show alternative?

Was wondering, if you could modify this slightly to get cash show questions?

I'll look into it.


Retain member order when lazy fields are evaluated out of order

Codecov Report

Merging #63 into master will decrease coverage by 0.29%.
The diff coverage is 39.02%.

@@            Coverage Diff             @@
##           master      #63      +/-   ##
==========================================
- Coverage   99.14%   98.84%   -0.30%
==========================================
  Files          62       62
  Lines        8196     8235      +39
==========================================
+ Hits         8126     8140      +14
- Misses         70       95      +25

Impacted Files
Coverage Δ

iommi/traversable__tests.py
87.50% <11.53%> (-12.50%)
:arrow_down:

iommi/style.py
98.63% <33.33%> (-1.37%)
:arrow_down:

iommi/member.py
97.70% <100.00%> (+0.05%)
:arrow_up:

iommi/member__tests.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9630171...e964f11. Read the comment docs.


Are you affected by CVE-2019-5021 ?

https://talosintelligence.com/vulnerability_reports/TALOS-2019-0782
I've had a quick look, but I'm still learning, and this seems relatively recent news. Just figured I'd pop it on your radar, feel free to close immediately if it doesn't affect your dockerfiles.

I'm glad you asked. I had read about the vulnerability, but then forgot to check on my image.
It seems to be fine since the shadow file has the proper ! placeholder:
$ docker run -it --rm --entrypoint bash itzg/minecraft-server
bash-4.4# head -n 1 /etc/shadow
root:!::0:::::


[Updater] DependencyChange passes any group to the PR message builder

In order to ensure the PR title and message body are built using the right strategy, we need to pass any group assigned to the Dependabot::DependencyChange on to the Dependabot::PullRequestCreator::MessageBuilder class.
I've also made a small agreement change to the name of the placeholder group we use if no configuration is supplied to use the same placeholder name we use elsewhere.

Smoke test re-alignment here: https://github.com/dependabot/smoke-tests/pull/57


backend: fix stream with custom tools, add tests

Thank you for contributing to the Cohere Toolkit!

[ ] PR title: "area: description"

Where "area" is whichever of interface, frontend, model, tools, backend, etc. is being modified. Use "docs: ..."  for CI changes.
Example: "deployment: add Azure model option"

[ ] PR message: Delete this entire checklist and replace with

Description: a description of the change
Issue: the issue # it fixes, if applicable
Dependencies: any dependencies required for this change

This PR fixes some issues regarding using custom tools with /chat-stream. Key changes are:

add support for the appropriate event types
add unit test
make sure custom tool call messages with /chat and /chat-stream are not stored

[ ] Add tests and docs: Please include testing and documentation for your changes
[ ] Lint and test: Run make lint and make run-tests

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


4 plotting api

This PR completes the first version of the plotting API from onTime.

Somehow, I can't make PR. I'll merge locally and push the results on develop.

Somehow, I can't make PR. I'll merge locally and push the results on develop.


Remove dependency on cert-manager

Goal
Remove the dependency on the cert-manager.
Action Item
Currently, we need a valid certificate for the mutating webhook. We should try to not rely on this dependency for this small task.

This sounds like a valid approach to me: https://www.velotio.com/engineering-blog/managing-tls-certificate-for-kubernetes-admission-webhook


docs: fix references to the deprecated feature list

Now that the deprecated features list is included in the version
history, update the various docs that referenced it to point at
the correct locations. Also removes a method from the deprecate
versions script that appears to be unused.
Risk Level: low (docs only)
Testing: n/a
Release Notes: n/a
Signed-off-by: Stephan Zuercher<EMAIL_ADDRESS>

cc @htuch in regard to the method I deleted. Perhaps it's need somewhere I didn't find.

@zuercher it's probably some vestigial method from a former version of the script, fine to delete.

@zuercher Thanks for fixing this. I found all the references to version_history.rst in my change, but forgot about deprecated.rst.


Profiling and optimizations

We may start with node --prof server.js and apache benchmark
For example: ab -k -c 100 -n 50000 <IP_ADDRESS>/examples/simple/jsonGet.json
See:

https://nodejs.org/en/docs/guides/simple-profiling/
http://httpd.apache.org/docs/2.2/programs/ab.html

Guys, please assign somebody to this important but not urgent issue
@lundibundi @belochub @nechaido

Also, I'd recommend using https://github.com/mcollina/autocannon or https://github.com/giltene/wrk2.
You may find useful any flame graph visualization tool (e.g. https://github.com/mapbox/flamebearer or even simple v8s v8/tools/profview/index.html).

+1 to @lundibundi's suggestion, I have no experience with autocannon, but wrk/wrk2 are way more modern, can produce a lot more load than ab and, while being simple to use out-of-the box, support sophisticated testing scenarios written as Lua scripts when you need that. Also keep in mind that ab is HTTP/1.0 only and doesn't support keep-alive.

ab supports keep-alive with -k switch but you are right it's a part of archaic web, let's use something new and node-related, if we have something

I, with @lundibundi, investigated this question. Impress falls on HTTP requests with error.
2018-12-14T08:05:52.335Z	 error  	HTTP 404	Not Found	/
2018-12-14T08:05:52.339Z	 error  	TypeError: this.application.accessLog is not a function
	Client.end (/impress/lib/client.js:351:46)
	include (/impress/lib/client.js:414:16)
	done (/impress/lib/client.js:1059:7)
	Immediate.next (/metasync/lib/array.js:181:7)
	processImmediate (timers.js:632:19)
	process.topLevelDomainCallback (domain.js:120:23)

@bugagashenkj how to reproduce?

autocannon -c 1 -d 5

https://gist.github.com/bugagashenkj/77508fde0672e32533aeb662ce516b93

@bugagashenkj @belochub I tried to use new vm api to avoid runInContext but this need more research and experiments to compare. See this branch: https://github.com/metarhia/impress/tree/compile-func

@bugagashenkj we have significantly improved performance in Version 1.0.0-alpha.10

Might be interesting to check this blog, really structured information regarding node.js
https://os-system.com/blog/12-types-of-node-js-applications-with-examples/


Keep focus on the Composer when send button is clicked

Details

https://github.com/Expensify/App/issues/7798#issuecomment-1062973852
Fixed Issues

$ https://github.com/Expensify/App/issues/7798
Tests

Contributor (PR Author) Checklist

[x] I verified the PR has a small number of commits behind main
[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I clearly indicated the environment tests should be run in (Staging vs Production)

[x] I wrote testing steps that cover success & fail scenarios (if applicable)
[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests & veryfy they passed on:

[x] iOS / native
[x] Android / native
[x] iOS / Safari
[x] Android / Chrome
[x] MacOS / Chrome
[x] MacOS / Desktop

[x] I verified there are no console errors related to changes in this PR
[x] I followed proper code patterns (see Reviewing the code)

[x] I added comments when the code was not self explanatory
[x] I put all copy / text shown in the product in all src/languages/* files (if applicable)
[x] I followed proper naming convention for platform-specific files (if applicable)
[x] I followed style guidelines (in Styling.md) for all style edits I made
[x] I followed the JSDocs style guidelines (in STYLE.md)

[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I corroborated the UI performance was not affected (the performance is the same than main branch)
[x] If I created a new component I verified that a similar component doesn't exist in the codebase

PR Reviewer Checklist

[ ] I verified the PR has a small number of commits behind main
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the testing environment is mentioned in the test steps

[ ] I verified testing steps cover success & fail scenarios (if applicable)
[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] iOS / native
[ ] Android / native
[ ] iOS / Safari
[ ] Android / Chrome
[ ] MacOS / Chrome
[ ] MacOS / Desktop

[ ] I verified there are no console errors related to changes in this PR
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified comments were added when the code was not self explanatory
[ ] I verified any copy / text shown in the product was added in all src/languages/* files (if applicable)
[ ] I verified proper naming convention for platform-specific files was followed (if applicable)
[ ] I verified style guidelines were followed
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components are not impacted by changes in this PR (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[ ] I verified the UI performance was not affected (the performance is the same than main branch)
[ ] If a new component is created I verified that a similar component doesn't exist in the codebase

QA Steps

Open any chat on each platforms.
Type a message in composer.
manually click the send button.
Notice that cursor should remain on the Composer after message is sent.
On Mobile devices(native or mWeb) Virtual keyboard should not close after message is sent.

[ ] Verify that no errors appear in the JS console

Screenshots

Web | Desktop

https://user-images.githubusercontent.com/24370807/157866148-3769724d-0d91-4fca-935a-af6d99cb5fd8.mp4
Mobile Web

https://user-images.githubusercontent.com/24370807/157866185-aab45ac5-f7b4-4f86-9157-1a9022de8e6a.mp4
https://user-images.githubusercontent.com/24370807/157883113-94f502c6-b140-414c-a9d8-cad23520fd17.mp4
iOS

https://user-images.githubusercontent.com/24370807/157881126-1a24705c-b624-4a14-bd2d-844356d4c9b5.mp4
Android

https://user-images.githubusercontent.com/24370807/157866172-56b96bfb-5d6d-4b96-ba3a-bb52b28dcbb5.mp4

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by @roryabraham in version: 1.1.43-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by @roryabraham in version: 1.1.43-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

Yup, I think this PR is behind that.

So I guess the next step is to revert this PR and fix the original issue with a different approach?

No. is the new issue a deploy blocker?
The regression period for this issue is over. so it would be best to fix the new issue separately.


Doc typo fix for struct winit::Window

Whoops, didn't [ci skip] this, sorry!

Did you spot the 'matches' on the line below? With that, I think it reads fine.
What's an example of a linking verb you were thinking of?

I would like to preface this by stating that I have not attempted to learn this particular dialect by going through previous comments, so take this with a grain of salt. The phrase I'm keying in on is "if nothing". It sounds like it is missing an object compliment after it (i.e. "if nothing has happened" or "if nothing is present"). I think the parsimonious way to make this flow better is to say "if it is nothing" (which is the linking verb I was thinking of). I can tell that the line of thinking for this comment is a basic branch structured as "if x than y or if not x than z", but that doesn't translate well into natural language. Personally I would rephrase to more explicitly follow the schema of "if x than y, or if not possible z" (for example "...or the primary monitor if there is no current monitor"). I am aware that this new schema is semantically identical to the previous one, but it translates better into natural language. It is a tad redundant, but it does more explicitly explain what is going on while still being succinct.
I did not spot the "matches". I believe it is semantically null, so would be in favor of axing it entirely.

True, it isn't exactly clear what it means for there to be no matches.
I'm not familiar enough with the codebase to know why there wouldn't be any matches for the current monitor. I'll look into that, and then maybe this sentence could be rewritten to be a bit more descriptive.

I was initially going to tell you that this was fine as-is, but...

I'm not familiar enough with the codebase to know why there wouldn't be any matches for the current monitor.

...then I realized that I don't actually know this either. I've thus investigated:

Windows: stubbed as unimplemented!(), though #457 implements it. The monitor that the majority of the window is on is returned.
macOS: stubbed as unimplemented!().
X11: the monitor that the majority of the window is on is returned. There's a default value that's used when get_position or get_outer_size return None (though it's dubious that it makes sense to return a monitor at all in that case, since AFAIK this would really only be hit for a window that's been closed). That default value is the first monitor returned by get_available_monitors, which is the first monitor enumerated by XRRGetMonitors on XRandR 1.5 and onward, and XRRGetScreenResources otherwise. Neither of these claim to always have the primary monitor as the first one.
Wayland: due to inavailability of positioning info, the window's most recent monitor is returned.
Android, iOS, and emscripten: these implementations don't really do anything, so it's not an issue here.

So you've inadvertently caused the discovery that the doc comment isn't even accurate, which I'd say is a victory for winit!

In that case, do you think it's even necessary to mention the possiblity of 'no matches' in the documentation? Or something akin to "if a window's monitor cannot not be determined for certain, a platform-specifc best guess is returned."

Oh, I'll bet that that was what the "matches" comment was for!

I personally don't think it's necessary. There aren't really any reasonable cases where there won't be a match.

I probably should have been more clear, I still believe that the "matches" comment is semantically null. Any use it may have had is met with a descriptive comment about the purpose of the function. I merely now understand it's (probable) former purpose.

@virome I see that you updated your commit, so I assume you're ready for me to merge this. For future reference, GitHub didn't send me a notification when that happened; IIRC it only notifies me if you add commits, so it's always good to comment to give me a heads up.
Anyway, thanks for the contribution!

@francesca64 Good to know!


automate creating the cluster account

Creating the cluster with sacctmgr is still manual:
sacctmgr create cluster vslurm, then input 'y'
so i would like to

check the man page for a way to automate it
find a way to make ansible do it idempotently

this is the current manual procedure for running vslurm:

i run make ec2-vslurm
i copy the ansible dir onto the deployer with scp -ri ./ec2_id_rsa -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null ./../ansible <deployer_username_and_host>:/home/ec2-user
i log in to the deployer (bootstrapper?) as ec2-user
i do sudo mv ansible /root/
i do sudo su -
i do cd ./ansible
i run the ansible playbook.

ansible-playbook cluster.yaml --tags common_init
ansible-playbook cluster.yaml --tags slurm_common
ansible-playbook cluster.yaml --tags slurm_server

i do ssh ec2-user@server "sudo sacctmgr create cluster vslurm"
i do ansible-playbook cluster.yaml --tags slurm_compute
i do ansible-playbook cluster.yaml --tags slurm_login
i do ansible all -m ansible.builtin.reboot
and then ansible-playbook cluster.yaml

Steps 2-7 are automated in ec2-vslurm/scripts/deployer_user_data.
Basically, I'm happy running the ansible commands there.
There are two tasks that are still truly manual as of 70d5e5c, both to do with the accounting database:

step 8 described above, which asks for 'y' input
and getting the encoded password to put into the mysql user creds in ansible/slurm_server/tasks/main.yaml

the input is not a problem; sacctmgr takes the -i option. i set up a task that bases its failure/changed status on the return code for sacctmgr -i create cluster. Fixed with f011d14e7ea32ec207f225cb780c56d7c8cd839f


For info, here is a similar tool

Hello Romain,
For info, here is a tool called imagedownloader which I have in my starred repositories: https://github.com/alcinos/imagedownloader
It is a fork by a Facebook guy which implements (*). The original tool can be installed with:
%pip install imgdl

As far as I understand, this tools serves a similar purpose to img2dataset, with a few differences:

there is no subfolder,
filenames are either hashed, or determined by a user-defined function (*),
persistent cache,
etc.

Is there any advantage to switch from imagedownloader to img2dataset?

hi,
yes resizing, subfolders, number indexed files, and being maintained.
but more importantly what I listed in the roadmap here https://github.com/rom1504/img2dataset#road-map
the goal of this repo is to turn a list of url in an usable dataset, not only to download the files

Thank you for the answer! :)

I saw your message in https://github.com/felipeam86/imagedownloader/issues/1
Good job for all the work! I will try your tool next time I need to download lots of images!


ImportError: BeautifulSoup

Hey there,
first of all, I'd like to say thank you :) I finally managed to get it up and running, but it has been quite a journey to get to this point.
A couple of weeks ago it took me ages to fix the image_build script, because my version still contained the yanked mimemagic package. I was quite happy that it seems to be fixed now, because I added this feature to another BigBlueButton server today, and the script ran through this time without any issues.
Am I missing something, or is it normal that I had to install BeautifulSoup via pip manually? Before doing so, I had this kind of error message in /var/log/nginx.error several times, there were no thumbnails in greenlight's recording list, and trying to access the record via BBB's playback failed with an internal server error:
2021/05/06 15:08:54 [error] 25690#25690: *208 FastCGI sent in stderr: "Traceback (most recent call last):
File "/var/www/html/gl-auth/auth.py", line 7, in
from bs4 import BeautifulSoup
ImportError: No module named 'bs4'" while reading response header from upstream ...
Now that I have manually installed BeautifulSoup, it works like a charm. I didn't fiddle around with virtualenv or something, do you think this might be a security problem when going to production?
Since I had to do this on both servers to get it working, it seems worth mentioning in the installation guide, because it took me a couple of days the first time I tried to install this.
Thanks for this great feature! Although it obviously can't fix what's wrong with BBB itself (like this guessable url stuff, once the meeting id has been provided via sharing the playback link - only 9 digits left to guess) - it is definitely an advantage being able to mark records as private.
Looking forward to hearing from you,
fnord235

Heho,
thanks for pointing this out. I adjusted the documentation. Instead of installing it via pip, you should do an apt-get install python3-bs4.
Related: You can also use the extended version of rec-perm that allows you to authenticate recordings against your greenlight user database (if you are not using a form of remote users). That is probably even a bit better than just setting recordings to private. :-)


RP2040 not waking up from dormant mode (external gpio, active low)

I am using a nRF24L01+ 2.4GHz transceiver which has an IRQ pin that can fire (active low) when data has been received.
Unfortunately, the RP2040 doesn't wake up properly and therefore I cannot process any packets after it goes to dormant mode.
https://github.com/nRF24/RF24/issues/857

I'm also interested in this problem.
Gonna try my own NRF24L01+ with Pico soon.


Updated files in examples folder to use Bower instead of CDN

@steveathon Alright ready to go :shipit:

@steveathon this PR is still good to go. I just wanted to put all the UI fixes in one PR.

Unless I'm mistaken, this PR in addition to #79 fixes all known UI bugs.


Add to google news

https://support.google.com/news/publisher-center/answer/9606708?visit_id=637374188450058328-3826822855&rd=1

submitted for review 11/24


Add cluster autoscaler support for CLI

This checklist is used to make sure that common guidelines for a pull request are followed.

[x] The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).

[x] I adhere to the Command Guidelines.

@qwordy please help with this PR.

@qwordy @yonzhan , we need this PR for S160 milestone (for Ignite). Could you make sure to merge it for the Ignite release.

@qwordy  please help merge it before Ignite release.

@qwordy  should be good to go now

@qwordy should be good to go now

Thanks for making the changes.


DOC/DEV: mention -b option in contributor guide on testing

Reference issue
Toward gh-20844.
What does this implement/fix?
In the contributor guide on testing, advertise the -b backend option.

LGTM and preview is good, thanks @fancidev !


make compilation work on mac os x

here's a fresh update of SConstruct to make compiling work on mac.
compilation of PngImage.cc failed with a lot of c++ errors. replacing it with the version (by the same author) availably on http://warp.povusers.org/ makes it compile without problems.

Thanks. I'll check if there any substantial functionality differences in pngImage before merging. Shouldn't take too long.

the version i linked seems to has the exact same header file

did a fresh rebase on your master, and a forced push

Thanks. Hope to pull this as soon as possible (when I have a Mac ready to test).

PngImage.cc seems to be only the header.

Fixed the compile woes of pngImage. OS X ships a newer version of libpng that uses a slightly different API. PngImage on the other hand relied on a deprecated API. Lucky for us, both the 1.2 and the 1.5 branch support this. The code compiles fine on Linux and os x. Only the include and library paths need to be adjusted on Mac.
Will push the changes to master repo tomorrow.

great!

So, I merged this one and made a few changes that were necessary to get it to work smoothly on Linux. Please test on Mac OS X.

thanks. i'll test.

i checkout out your master, and deleted config.log and all *.o files. but i'm experiencing a few problems:
~/Project-OSRM$ ((3f7437f...)) scons
scons: Reading SConscript files ...
Using default C++ Compiler:  g++
Checking for C header file omp.h... no
Compiler does not support OpenMP. Exiting
~/Project-OSRM$ ((3f7437f...)) scons --no-march
scons: Reading SConscript files ...
Using default C++ Compiler:  g++
Checking for C header file omp.h... yes
Checking for C++ library bz2... yes
Checking for C++ library png... no
png library not found. Exiting
so far i've been compiling without openmp on mac, since it requires a newer version of gcc. if this is still the case, sconstruct shouldn't need to look for omp.h at all?
config.log contains "ld: library not found for -lpng" after running the two above attempts:
file /Users/emil/Project-OSRM/SConstruct,line 60:
Configure(confdir = .sconf_temp)
scons: Configure: Checking for C header file omp.h...
.sconf_temp/conftest_0.c <-
|
|#include <omp.h>
|
|
gcc -o .sconf_temp/conftest_0.o -c -O3 -DNDEBUG -I/usr/include/libxml2 -I/usr/X11/include -I/usr/local/Cellar/libstxxl/1.3.1/include -I/usr/local/Cellar/boost/1.48.0/include .sconf_temp/conftest_0.c
scons: Configure: yes
scons: Configure: Checking for C++ library bz2...
.sconf_temp/conftest_1.cpp <-
|
|
|#include "bzlib.h"
|
|int
|main() {
|
|return 0;
|}
|
g++ -o .sconf_temp/conftest_1.o -c -O3 -DNDEBUG -I/usr/include/libxml2 -I/usr/X11/include -I/usr/local/Cellar/libstxxl/1.3.1/include -I/usr/local/Cellar/boost/1.48.0/include .sconf_temp/conftest_1.cpp
g++ -o .sconf_temp/conftest_1 .sconf_temp/conftest_1.o -L/usr/local/Cellar/libstxxl/1.3.1/lib -L/usr/local/Cellar/boost/1.48.0/lib -lbz2
scons: Configure: yes
scons: Configure: Checking for C++ library png...
.sconf_temp/conftest_2.cpp <-
|
|
|#include "png.h"
|
|int
|main() {
|
|return 0;
|}
|
g++ -o .sconf_temp/conftest_2.o -c -O3 -DNDEBUG -I/usr/include/libxml2 -I/usr/X11/include -I/usr/local/Cellar/libstxxl/1.3.1/include -I/usr/local/Cellar/boost/1.48.0/include .sconf_temp/conftest_2.cpp
g++ -o .sconf_temp/conftest_2 .sconf_temp/conftest_2.o -L/usr/local/Cellar/libstxxl/1.3.1/lib -L/usr/local/Cellar/boost/1.48.0/lib -lbz2 -lpng
ld: library not found for -lpng
collect2: ld returned 1 exit status
scons: Configure: no

Two problems come in combination here. The GCC frontend that comes with OS X does not like the 'march' switch. That can be handled easily.
The other problem is an unset libpath. Apple distributes libpng with OS X, you can find it in /usr/X11/lib.
I updated the SConstruct accordingly with the latest push. Please retry.

progress, but fails because it's trying to link openmp stuff:
~/Project-OSRM$ ((fdb4198...)) scons
[...]
g++ -o osrm-routed -lboost_thread-mt -lboost_regex-mt -lboost_system-mt -fopenmp routed.o Descriptors/DescriptionFactory.o ThirdParty/PngImage.o -L/usr/X11/lib -L/usr/local/Cellar/libstxxl/1.3.1/lib -L/usr/local/Cellar/boost/1.48.0/lib -lbz2 -lpng -lzip -lprotobuf -lstxxl -lxml2 -lz -lboost_thread-mt -lboost_regex-mt -lboost_system-mt
Undefined symbols for architecture x86_64:
"_gomp_thread_attr", referenced from:
_initialize_env in libgomp.a(env.o)
ld: symbol(s) not found for architecture x86_64
collect2: ld returned 1 exit status
scons: *** [osrm-routed] Error 1
scons: building terminated because of errors.
unless you want to use gcc 4.6 (which doesn't come with os x by default) i don't think it's possible to use openmp. there is a brew formula for gcc 4.6. when i tried it it created malfunctioning binaries, but it has been updated since and might work. but if course it's much easier if compilation can be done with the compilier that comes with os x. clang is where apple is heading, but it doesn't support openmp either (yet).

Please retry (again).

it builds!

Perfect


Support for triple-quoted comments?

Your README.md says:

Comments coming from the GraphQL schema are reported in the generated code

And that does seem to work for # comments like this.
But I'm working with a schema generated by graphql-js's printSchema function, which outputs:
"""comments like this"""

"""
and sometimes
like
this
"""

It would be nice if that were supported too.  Though maybe this is just a case of that library doing the wrong thing?  (I couldn't find any documentation about using such strings as documentation/comments in GraphQL SDL.)
Thanks for this library!

Hum,
I'm the 'responsible' for reading the comments. The graphql-java library is.
And according the [GraphQL Spec](file:///C:/APPLIRTE64/appli/Mes%20Sites%20Web/graphql%20(spec%20juin%202018)/spec.graphql.org/June2018/index.html#sec-Comments), comments are marked with a #
I'll check that.
But I think it's up to graphql-java:

If it reads those samples as a comment, then the plugin will find them as comments, and use them.
If it doesn't read those comments, then the plugin won't even know they exist

Did you try to change these comments at the exact same place in the schema, to check if it actually works ?
Etienne

graphql-java still can't read these comments.
And it's not a valid syntax according to the GraphQL specifications. I guess that graphql-java will take it into account as soon as the specification does. Then it will be ok for the plug-in.
I close this issue.

The spec does allow for single or double quoted comments. The spec differentiates between # line comments and " or """ block comments. The latter is the official way to provide descriptions for types, fields, arguments, etc. Graphql-java also supports single or triple quotes for descriptions and recommends that over the legacy # comments.
@etienne-sf Can we re-open this and consider supporting quoted comments?

Oups I missed this one
Yes, if it's not entirely treated, you can re-open it.
But then I'm sad: I thought it was ok.
Étienne

Unfortunately, I don't have permission to re-open. Can you or @NfNitLoop re-open it?


[ LP ] A Database error occurred [ in localhost ]

Hi i have a little problem lol : https://imgur.com/enToFMP

Check your log for errors. Especially during startup


ImportError: cannot import name 'textwriter' from 'botocore.docs.bcdoc' (Python3.7.7)

It lets me pip install aws-shell correctly but when I try to run the shell it keeps giving me the same import error (even for different python versions)

I am having a similar issue but it is thrown during the handling of another exception:
`ADIs-MacBook-Pro-37:~ adiloaner$ aws-shell
First run, creating autocomplete index...
Traceback (most recent call last):
File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/awsshell/utils.py", line 84, in file_contents
with open(filename, mode) as f:
FileNotFoundError: [Errno 2] No such file or directory: '/Users/adiloaner/.aws/shell/cache/completions-1.18.142.json'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/awsshell/index/completion.py", line 63, in load_index
contents = self._fslayer.file_contents(filename)
File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/awsshell/utils.py", line 87, in file_contents
raise FileReadError(str(e))
awsshell.utils.FileReadError: [Errno 2] No such file or directory: '/Users/adiloaner/.aws/shell/cache/completions-1.18.142.json'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/awsshell/init.py", line 39, in main
index_str = indexer.load_index(utils.AWSCLI_VERSION)
File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/awsshell/index/completion.py", line 65, in load_index
raise IndexLoadError(str(e))
awsshell.index.completion.IndexLoadError: [Errno 2] No such file or directory: '/Users/adiloaner/.aws/shell/cache/completions-1.18.142.json'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/Library/Frameworks/Python.framework/Versions/3.8/bin/aws-shell", line 8, in
sys.exit(main())
File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/awsshell/init.py", line 43, in main
from awsshell.makeindex import write_index
File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/awsshell/makeindex.py", line 8, in
from botocore.docs.bcdoc import textwriter
ImportError: cannot import name 'textwriter' from 'botocore.docs.bcdoc' (/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/botocore/docs/bcdoc/init.py)`

Confirmed with Python 3.8 also. This seems related to aws-cli and boto3:

https://github.com/aws/aws-cli/pull/5538
https://github.com/boto/boto3/issues/2596

Same error for Python3.8.1

Also seeing this issue on Python 3.8, Windows 10:
$ pip freeze
aws-shell==0.2.1
awscli==1.18.144
boto3==1.15.3
botocore==1.18.3
colorama==0.4.3
configobj==5.0.6
docutils==0.15.2
jmespath==0.10.0
prompt-toolkit==1.0.18
pyasn1==0.4.8
Pygments==2.7.1
python-dateutil==2.8.1
PyYAML==5.3.1
rsa==4.5
s3transfer==0.3.3
six==1.15.0
urllib3==1.25.10
wcwidth==0.2.5

Same here, using the latest builds of aws-shell and aws-cli from the repo.
$ pip freeze
astroid==2.4.2
aws-shell @ git+https://github.com/awslabs/aws-shell.git@8950f03d9d720879890af6c11537b8f9789ce5a9
awscli @ git+https://github.com/aws/aws-cli@dabd57baa645ac3e56f39ffcc0e8bec76ccfd50a
boto3==1.15.8
botocore==1.18.8
certifi==2020.6.20
chardet==3.0.4
colorama==0.4.3
configobj==5.0.6
docutils==0.15.2
idna==2.10
isort==4.3.21
jmespath==0.10.0
lazy-object-proxy==1.4.3
mccabe==0.6.1
prompt-toolkit==1.0.18
pyasn1==0.4.8
Pygments==2.7.1
pylint==2.5.3
python-dateutil==2.8.1
PyYAML==5.3.1
requests==2.24.0
rsa==4.5
s3transfer==0.3.3
six==1.15.0
toml==0.10.1
urllib3==1.25.9
wcwidth==0.2.5
wrapt==1.12.1

Experiencing the same error

Experiencing the same error

+1

Confirming this as an issue. I've opened a fix in: #250
As a temporary working around, you'll need to pin below aws-cli<1.18.140 and boto3<1.15.0.


Request to Add a License to the Code Repository

First, thank you for sharing your work with the community!
I kindly ask if you could consider adding an open-source license to your repository for enabling others to reference your work.
Thank you for considering our request!

I have added the MIT license. Thanks for your advice!

Thank you for your prompt response and for adding the licence!


Problem in thinking about mutation rate?

Hello!
I've (hopefully) attached the code I've written for problem 1.
The code seems to work if I run it with the reference.fa, control.fa, theraptrix.fa files respectively, and I get a p value that is written to a file. However, when I upload this code on the class website, I get an error saying my answer is incorrect. I was wondering if this is due to a flaw in the way I'm thinking about the problem, or if it's due to syntax, etc.
I'm not super familiar with the zip function, or list comprehension, so maybe my roundabout way of solving the problem is the problem.
Thanks for the help, and sorry for the last minute question!!
problem1.txt

Hey! Your p-value is super close, but not quite correct. I'm looking over your code now, but haven't spotted the bug yet. I'll keep you posted.

Turns out to be an easy fix! On lines 21, 25, and 29, you're trimming the first nucleotide off of the sequences  by doing [1:].
Based on your variable names, I suspect this is a leftover from processing headers instead of the sequences.

Whoops! Definitely an easy enough fix. Thanks so much for looking over it and catching that for me!!


⚠ Bofrost.fr has degraded performance

In 2ffa63d, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1076 ms

Resolved: Bofrost.fr performance has improved in 9b9116f.


feat(web) snap frame attach/detach with snapping

probably needs some cleanup, but this is feeling pretty good!

you can now drag items in/out of frames to attach/detach
New parent is based on cursor position rather than what each component is hovering over
we highlight the new parent so you can see what it will be attached to
we optimistically update parent id so it feels snappy
there is logic that bumps children into the new parent if they are outside, which means things sort of snap into the parent...

It's not perfect, but it feels pretty good!
Main issue is that when snapping things into place, you can still end up with items hovering over each other that are not actually attached.

@theo I just fixed up the conflict here - this PR isn't quite ready - any movement of a component inside the frame will actually detach it - it's not calculating that the component is outside the frame to detach

Will take a look! Likely a few other issues as well… but hopefully it feels
pretty good?
On Fri, Jan 19, 2024 at 9:53 AM Paul Stack @.***> wrote:

@theo https://github.com/theo I just fixed up the conflict here - this
PR isn't quite ready - any movement of a component inside the frame
will actually detach it - it's not calculating that the component is
outside the frame to detach
—
Reply to this email directly, view it on GitHub
https://github.com/systeminit/si/pull/3181#issuecomment-1900845225, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAI26LB3HERCOZTOLRGBQGLYPKXKZAVCNFSM6AAAAABCBEC6PGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBQHA2DKMRSGU
.
You are receiving this because you authored the thread.Message ID:
@.***>

bors merge


[dev] Google home Timers card by me

Where should i make pull request to so we can separat the integration and the card ?
See card here

This is great stuff and additive! I actually don't know if we can add frontend files together with this custom integration, but it would be awesome to make them work together. We need to research HA documentation a little more how to do it, otherwise we ll have to have the frontend cards as a separate repository that should follow HACS documentation to be able to expose it via HACS

Agreed!
Right now this integration is my main focus, when we are closer to a release i will focus more on this card :smile:

@KapJI, @ArnyminerZ, @DurgNomis-drol  does any of you guys know if we can introduce frontend stuff in the same repo as integration? I know we can def do it in two separate repos, but I am wondering if it's possible to deliver through one and the same integration both backend and frontend related things?

Well, you can place it in www folder in the repo. Not sure about HACS though.

Please check my simple card out 😄 Here and leave some feedback over there

That's really nice! Couldn't really test it without "next timer" dedicated sensor just yet, but I'm excited. I can also see there are some other community driver projects that can help achieve good looking countdown cards (example). As a suggestion, you could add somee screenshots to your repo, so it can be visually "selling" before even installing? :)

It works with the current timer sensor 😄
I will look into that link, and take some screenshots very soon


Update vendor/hackclub to latest commit

Will merge after tests pass because I'm the only FTE on this project right now.


Documentation link broken

The regexp for license statement link in the docs is broken.
Therefore it is not clear enough how this component works.
Related with https://github.com/terinjokes/gulp-uglify/issues/234

Fixed link is: https://github.com/shinnn/uglify-save-license/blob/master/index.js#L7

Thanks for the report, @alvarotrigo.
@SebastianS90 Your link will be soon broken when I add an additional line above L7. https://github.com/shinnn/uglify-save-license/blob/451c8b0f549dbb74d62096f00b939f9c35942632/index.js#L7 is more stable.
=========
PR welcome 👐

Thanks for the quick reply!


README: Fix alignment of title

The title, i.e. the first header, in the README file should be centered. Fix the broken attempt by using the align attribute of the <h1> tag.

Build failures are unrelated as this is a pure documentation change.
This seems to be a general problem many others also encountered:
https://github.community/t5/GitHub-Actions/ubuntu-latest-Apt-repository-list-issues/td-p/41122

Tests passed after the root cause has been fixed.


transitionTo without triggering

Is there currently a way to call transitionTo(url) silently, ie replacing the url in the browser without triggering any middleware? (Other libraries seem to provide this but I can't see it in the docs here.)

Yes and no.
I've personally always used Cherrytree in a "unidirectional data flowy way" and I'd probably recommend doing that. That is, you never update something in your app outside of the "transition > changes url > calls middleware > updates your app" loop. For example, if you click on a filter and want to update app state + url, you should transition, which will update url, which will call middleware, which should update the app.
Having said that, there might be use cases for updating URL that I haven't thought about and I'd be interested to here what your use case is.
You could try updating it directly via the location handler, which isn't something documented, but would work today:
router.location.setURL(url, {trigger: false})
router.location.replaceURL(url, {trigger: false})

(you can try running that code in console here: http://kidkarolis.github.io/cherrytree-redux-react-example)
Trigger false here means location will just update URL and won't trigger events, which means cherrytree will not call middelwares. The only drawback of this that I can think of is that this will put the router into incosistent state where router.state will still be representing the previous URL. But if that's not a problem for you - then it's all good. But if you use transition.prevRoutes, that might cause issues. In the future, I'm interested in completely removing state and prevRoutes from the router making it stateless, which might solve this particular issue.


Move docs on the build API out of 'misc' and under 'Images' section

It seems odd to have such an important API hidden under 'misc'.
While in there I noticed that during the "-f Dockerfile" PR I changed
the query param from f to dockerfile and missed this one spot in the docs.
Signed-off-by: Doug Davis<EMAIL_ADDRESS>

@duglin you are definitely getting some good testing in of my "docs-only" autolabeler :)
you should win a cleanup award :)

LGTM @fredlf @jamtur01


CornerRadius property doesn't work

If I tried to set a different cornerRadius property, for HTPressableButtonStyleRounded but I couldn't. Never change the value of that property.
I take a look to the code, and you set always:
FILE: HTPressableButton.m
LINE: 62
case HTPressableButtonStyleRounded:
        _cornerRadius = 10.0;

So, the property never change.

@bubudrc Thanks for the catch! :+1:


Allow the file encoding to be specified in smart_open()

Thank you very much for the effort made in providing this useful package.
I would like to request the following feature: that the encoding can be specified when calling gzip.open() or open() in smart_open().
I am currently using GEOparse 2.0.1 with Python 3.8.3 on Windows 10. I have successfully downloaded GSE files from GEO (e.g. GSE134809_family.soft) and have also used GEOparse to read the .soft (or .soft.gz) files stored locally on my computer.
I have discovered that some special characters in the .soft files are not being interpreted correctly, due to gzip.open() or open() using Python's default encoder ('cp1252' in my computer) instead of 'utf-8' even though the .soft files use 'utf-8' encoding. Due to smart_open() ignoring errors when reading the file with fh = fopen(filepath, mode, errors="ignore"), the special characters do not prevent the file from being read, but they are not interpreted correctly.
The types of characters that I've found to be problematic are letters with accents, and some punctuation marks, e.g.  Naïve, 4°C, 3’ prime, “union” (those single and double quotation marks are not the standard ones even though they look similar).
This could be solved by allowing the encoding argument to be passed to gzip.open() or open() when calling smart_open():
@contextmanager
def smart_open(filepath, encoding):
    """Open file intelligently depending on the source and python version.

    Args:
        filepath (:obj:`str`): Path to the file.
        encoding (:obj:`str`): Encoding to use when reading the file.

    Yields:
        Context manager for file handle.

    """
    if filepath[-2:] == "gz":
        mode = "rt"
        fopen = gzip.open
    else:
        mode = "r"
        fopen = open
    if sys.version_info[0] < 3:
        fh = fopen(filepath, mode)
    else:
        fh = fopen(filepath, mode, encoding=encoding)
    try:
        yield fh
    except IOError:
        fh.close()
    finally:
        fh.close()

Alternatively, **kwargs could be passed through smart_open() and into gzip_open() and open().
Additionally, it would be beneficial if the errors were not ignored when reading the files, so that the user can be aware of them. This could be done by using a try/except block to attempt to open the file, and if errors are raised, display them to the user and then try to read the file again but this time ignoring errors. This would mean that the file would still be read but the user would be aware that there was a problem.

Hi, thanks a lot for the hint and detailed description. I am starting to implement this.

Hi, the newest version allows to pass the dictionary that will be subsequently passed to the smart_open function. It should do the trick for you. If not, let me know, I will figure out something else.

This is perfect, thank you.


⚠ Turnos 24x7 has degraded performance

In 39be2ed, Turnos 24x7 (https://reservas-dev.alternativasinteligentes.com/) experienced degraded performance:

HTTP code: 200
Response time: 1082 ms

Resolved: Turnos 24x7 performance has improved in 0a64fa2.


Agent' object has no attribute 'prompt where dose it come from?

when I run the App .It shows : Command ask_genius_bing returned: Error: 'Agent' object has no attribute 'prompt'

-=-=-=-=-=-=-= COMMAND AUTHORISED BY USER -=-=-=-=-=-=-=
SYSTEM:  Command ask_genius_bing returned: Error: 'Agent' object has no attribute 'prompt'
\ Thinking...

Same question

It seems that it caused by upgraded autogpt 4.0 when the 'Agent' class dosent have 'prompt' anymore but have two 'xxx-prompt' like attributes

Sembra che sia causato dall'aggiornamento di autogpt 4.0 quando la classe 'Agent' dosent ha 'prompt' più ma ha due attributi 'xxx-prompt' come

Thank you.
any suggestions on how to fix it?


Update Operation ID for Microsoft.Resources/changes for docs

MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Changelog
Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?

[ ] new service onboarding
[ ] new API version
[ ] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[x] Other, please clarify: we are looking to generate documentation for the Microsoft.Resources/changes API. With the current operation IDs, the generated doc will look like this

We want a single section called Changes with GET and LIST as operations underneath. This PR will make that change.
2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
4. If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
- [ ] SDK of .NET (need service team to ensure code readiness)
- [ ] SDK of Python
- [ ] SDK of Java
- [ ] SDK of Js
- [ ] SDK of Go
- [ ] PowerShell
- [ ] CLI
- [ ] Terraform
- [ ] No refresh required for updates in this PR
Contribution checklist:

[ ] I commit to follow the Breaking Change Policy of "no breaking changes"
[ ] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

Applicability: :warning:
If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs
Adding new properties
All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

[ ] Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

Adding a new service
Adding new API(s)
Adding a new API version
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.

[ ] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

[ ] Removing API(s) in a stable version
[ ] Removing properties in a stable version
[ ] Removing API version(s) in a stable version
[ ] Updating API in a stable or public preview version with Breaking Change Validation errors
[ ] Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.

https://github.com/Azure/sdk-release-request/issues/2688

/azp run

/azp run

/azp run

/azp run

/azp run


Unify connect.go channels into one

many listeners that does the same work more or less can be unified into one listener.

Please add a little bit of discription for that issue.

I think we'll put this issue on hold since many changes to the interface of Memphis <-> SDKs is going to change.
also, we depend on this issue for any progress on this one.


Knock back zoom functionality when rendering digitised content

Problem to solve
Usability testing demonstrated that people still have trouble using deep zoom in OpenSeadragon on book-type things. This is because the action of zooming in to enlarge text then doesn't allow them to fall back on ingrained behaviour, like:

scrolling to move up/down the page
moving to the next page
right-click to save image.

There is a tension here with the deepzoom world.
If we can maximize the page viewing area, and downgrade the zoom functionality to secondary function, I hypothesise that users will be able to use this material much more naturally.
We know that:

People are actively downloading/saving PDFs to read offline
The majority of collections users are still primarily on larger screens (not doing their research on mobile)
Zoom is great for detail on pictures, but not as useful as part of a reading experience.

TODO

[ ] Detach OpenSeadragon from default JS-enhanced viewer

Part of #4848


Get keydown node

When keydown is fired, is it possible to recover the node where the keydown had been pressed?
It is actually not present in the event fired.
I tried keydown but it is not precise enough to give me the node where the key was pressed.

They keydown target will be the editor node itself. To find the current cursor position, you can use editor.getSelection(). This is how browsers work with contenteditable.


Feature Request: An API to write different backends for different chat programs, possibly with some way to indicate what features that backend supports

The idea is I'd be able to write another mod that would tell BlockBot what features it supports (IE, skins for avatars, embeds, etc.) and then configure BlockBot to use that backend instead of the built-in Discord one. This could be used for writing Slack, IRC, etc. bridges without having to modify BlockBot itself or write a mod from scratch.

This should be implemented in c4e5347, let me know if you have any feedback for that change

I like how this is going! I would maybe have a section in the config file with a list of the built-in bot types, and options to enable or disable them. They'd then have their own configuration in a subfolder. Discord bot would be the only one enabled by default. It might also be helpful to have commands to list the registered bots, as well as a console-only command to delete the configuration files for unused bots, in case a server ends up having a lot of them. It's a dangerous command, so should be permission level 4 (same as /stop is)

So I don't plan on official support for other platforms, but if anyone else wants to use the API, feel free

I guess that means only discord bot would be listed by default
Sections for the other bots registered at launch should probably be added so they can be enabled or disabled.

They can - in the BlockBot class bots can be registered. The idea is the mod handles config loading as they control the logic for the bot

Fair enough.


json and xlf update for 8-13-2022

This PR fixes #

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
6 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.01%) to 41.656%

Files with Coverage Reduction
New Missed Lines
%

extensions/notebook/src/book/bookTreeView.ts
2
38.03%

extensions/notebook/src/jupyter/serverInstance.ts
4
75.5%

Totals

Change from base Build<PHONE_NUMBER>:
-0.01%

Covered Lines:
27854

Relevant Lines:
62293

💛  - Coveralls


Cherrypick 39024

Fixes https://github.com/istio/istio/issues/39044

@ingwonsong: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ingwonsong: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_istio
ae98730ce9d665c2e52e8c894805fb5aa416fe45
link
true
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ingwonsong: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_istio
ae98730ce9d665c2e52e8c894805fb5aa416fe45
link
true
/test gencheck_istio

integ-helm_istio
ae98730ce9d665c2e52e8c894805fb5aa416fe45
link
true
/test integ-helm_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ingwonsong: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_istio
ae98730ce9d665c2e52e8c894805fb5aa416fe45
link
true
/test gencheck_istio

integ-helm_istio
ae98730ce9d665c2e52e8c894805fb5aa416fe45
link
true
/test integ-helm_istio

lint_istio
ae98730ce9d665c2e52e8c894805fb5aa416fe45
link
true
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ingwonsong: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_istio
ae98730ce9d665c2e52e8c894805fb5aa416fe45
link
true
/test gencheck_istio

integ-helm_istio
ae98730ce9d665c2e52e8c894805fb5aa416fe45
link
true
/test integ-helm_istio

lint_istio
ae98730ce9d665c2e52e8c894805fb5aa416fe45
link
true
/test lint_istio

analyze-tests_istio
ae98730ce9d665c2e52e8c894805fb5aa416fe45
link
true
/test analyze-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ingwonsong: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_istio
ae98730ce9d665c2e52e8c894805fb5aa416fe45
link
true
/test gencheck_istio

integ-helm_istio
ae98730ce9d665c2e52e8c894805fb5aa416fe45
link
true
/test integ-helm_istio

lint_istio
ae98730ce9d665c2e52e8c894805fb5aa416fe45
link
true
/test lint_istio

analyze-tests_istio
ae98730ce9d665c2e52e8c894805fb5aa416fe45
link
true
/test analyze-tests_istio

release-notes_istio
ae98730ce9d665c2e52e8c894805fb5aa416fe45
link
true
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Relicense as GPL-2.0-or-later with exceptions

The sole use of the GPL-3.0-or-later license prohibited the use of the
Basement project in other projects and left a gray area when patches are
applied to other software that is licensed under an incompatible
license.
There are two important exceptions that are granted beyond the usual
GPL-2.0 (or later) license that now applies to this project:

Included patches are covered by the licence of the affected software.
This exception is taken from Buildroot where it did stand the test of
time.
Using the Basement recipes as a separate layer from another Bob
project is considered normal use and does not fall under the heading
of "derived work".

Closes #7.

@Ferruck Do you agree with this relicensing? It would be good to get your explicit acknowledgement...

Don't you think that the mention of config.yaml in the exception is a bit too technical and explicit? Seems like it could be a future problem. I'd rather use a more general term there.
Apart from that, regarding the contents of this pull request, I fully agree.

Don't you think that the mention of config.yaml in the exception is a bit too technical and explicit? Seems like it could be a future problem. I'd rather use a more general term there.

You are probably right. I will try to come up with something better.

Apart from that, regarding the contents of this pull request, I fully agree.

:+1:

After thinking a while about it, how about
2. As a special exception, you may create a larger work that references
   the Basement project as a separate recipes layer through the recipe
   layering techniques provided by your build tool. Using part or all of
   the Basement recipes as a separate layer is merely considered normal
   use of the Basement project, and does *not* fall under the heading of
   "derived work".

I'm not sure if this can be formulated waterproof at all. What's the judicial difference in terms of the copyright in
a) adding some recipe in the basement repository, or
b) creating a project with said recipe and using the basement repository as a layer?
In either case the build result will be the same. From my perspective the amount of "derived work" is also the same. Just the technical realization differs. IMHO this is a contradiction to the original intention. Both cases use the same recipes to produce the same result. Now we either
a) lied to ourself that using the basement project by means of a layer is something different or
b) adding some recipes without modifying the existing ones is not creating a derived work.
I think its hard to argue (b) in the light of the GPL. Reading the LGPL blew my mind by how much is written in section 5 and 6 to specify the "L" in LGPL. Also reading https://lkml.org/lkml/2006/12/17/79 opened my eyes. So I think (a) is actually true.
What does it all mean? I think there are again two possiblities:

Scrap the exception and let the user judge what is "derived work" and what not. This may prohibit the usage by some non-open source users but so be it.
Allow any usage and move to some permissive license.

While I'm typically inclined to the first option I'm more and more convinced that it doesn't gain anything practically. There is no big open source community for Bob and basement. If we want to foster the adoption of Bob and the basement project then using the MIT or BSD license will be better than adding some half baked exception that nobody really understands.
What do you think?

First of all, I think we're both out of our profession here, so the following are merely not-that-much-educated guesses.

What's the judicial difference in terms of the copyright in
a) adding some recipe in the basement repository, or
b) creating a project with said recipe and using the basement repository as a layer?

Well, in the former case I change other peoples work whereas in the latter I use it.

In either case the build result will be the same. From my perspective the amount of "derived work" is also the same. Just the technical realization differs. IMHO this is a contradiction to the original intention. Both cases use the same recipes to produce the same result.

You're right that the end result - the build result - may be the same, but the way you've used to achieve it differs.

Now we either
a) lied to ourself that using the basement project by means of a layer is something different or
b) adding some recipes without modifying the existing ones is not creating a derived work.

I'd say it's not that hard to argue for point b, since I'd rather call it an aggregate work (referring to Linus' explanation given in the link you've provided later on). I could easily swap out the basement layer with a layer I've come up on my own or someone else's layer, as long as it provides the same recipes. Compare that with Linus' glibc example. As long as I don't use any glibc specifics, every linkage with the glibc is easily exchangeable with every other POSIX-conformant libc.
And I think that these considerations are well in line with the intention of the LGPL (referring to version 2.1 here). First of all, IMHO, using the base layer perfectly fits the first sentence of paragraph 5:

A program that contains no derivative of any portion of the Library, but is designed to work with the Library by being compiled or linked with it, is called a "work that uses the Library". Such a work, in isolation, is not a derivative work of the Library, and therefore falls outside the scope of this License.

(At least as long as you consider your recipes a program) Additionally, paragraph 6, section b, supports my understanding of aggregate in this context. Of course, these paragraphs aren't in the GPL (I guess neither in version 2.0 nor in version 3.0), but here I'd like to come back to Linus who argues that the creation of the LGPL was just about comfort, not about changing any of the intentions of the GPL.
But there's another big point here. You - as the basement layer user - are probably not redistributing neither your nor the basement layer's recipes. IMHO, this is what is widely considered private use and that's compatible with both GPL and LGPL independent on whether we're talking about aggregate or derived work. I think we have to think about the recipes more like we think about a tool like, let's say, the compiler. Would you consider it a GPL violation if you're distributing binaries compiled with a GCC that has in-house modifications?

What does it all mean? I think there are again two possiblities:

Scrap the exception and let the user judge what is "derived work" and what not. This may prohibit the usage by some non-open source users but so be it.
Allow any usage and move to some permissive license.

IMHO, point one is a no-option. To keep the wording, licensing is about rules and laws - obviously - but it's also about intentions and comfort. Especially when dealing with multiple international laws that you can't satisfy all at the same time, clearly stating your initial intentions is really important. Point two on the other hand seems like the more secure way for both parties. I fully agree with your following paragraph - I also prefer copyleft licenses - but if we want to gain some traction to Bob, we need to ease adoption. Which non-copyleft license would you prefer and why?
In the end, maybe software licenses simply cannot provide what we need for recipes. Looking at other projects like Bazel and Yocto, the problem is either ignored or not solved for them, either. Have you ever thought about things like CC for the recipes (though I admit that at least CC doesn't solve our derived or not derived problem)?

I also looked at CC and I didn't find it a good match either. In the end it all boils down to what is considered "derivative work". And there I think we have to admit that there will be no definitive answer because it is something that a court has to answer in each particular case.
Looking at the permissive licenses I'm in favour of Apache-2.0. It's permissive, keeps away patents as far as possible and requires preservation of the copyright notice and disclaimer. The other possibility would be MIT. In any case there should be an additional clause that patches are under the licence of the patched sources to assure compatibility. This is also done by the Yocto project which is MIT-based.

Looking at the permissive licenses I'm in favour of Apache-2.0. It's permissive, keeps away patents as far as possible and requires preservation of the copyright notice and disclaimer.

And to list all changes you've made to the distributed software, IIRC, which can get quite awkward. I've never reasoned about the patent-related parts of the license (are they even relevant here?), but for me the Apache license has always been the sluggish and hard-to-understand sister of the MIT, thus I'd personally prefer the latter. The final decision is up to you, of course.

Ok. So it's MIT. No frills...

Any legal obligations? Do I need to sign that commit of or something? Or is this discussion saved in Github's cloud enough for future record?

Hmm, I'll add your signed-off-by and when you explicitly consent here then I think it will be enough. Not sure how you could possibly sign this commit.

Thanks! Hereby I grant you the irrevocable right to relicense the recipes to the MIT license using the exception mentioned earlier in this thread. :wink:


test: use jsx for generated tests

Codecov Report

Merging #295 (9a4a96c) into main (54583f3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #295   +/-   ##
=======================================
  Coverage   89.48%   89.48%
=======================================
  Files          34       34
  Lines        1217     1217
  Branches      273      273
=======================================
  Hits         1089     1089
  Misses        125      125
  Partials        3        3

Impacted Files
Coverage Δ

...gen-ui-react/lib/react-studio-template-renderer.ts
90.82% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54583f3...9a4a96c. Read the comment docs.


Changes for #1005 and #1028.

Current coverage is 100% (diff: 100%)

Merging #1031 into master will not change coverage

@@           master   #1031   diff @@
=====================================
  Files          21      21
  Lines        1882    1882
  Methods         0       0
  Messages        0       0
  Branches        0       0
=====================================
  Hits         1882    1882
  Misses          0       0
  Partials        0       0

Powered by Codecov. Last update 602d591...551255d


WritableSocket#write: raise EAGAIN if socket is full and SNDTIMEO is set

This seems to have failed really hard on CI ... care to nudge this along?


make auto-loaded parents available programatically

it handy to be able to reference auto-loaded pym.Parent instances.
if any instances are auto-loaded pym.autoloaded will be an Array of those instances, instances are also available via object properties on the Array object that match their element.id value.
e.g.

var pym  = require('pym');
var me1  = pym.autoloaded[0];
var me2 = pym.autoloaded['example'];

console.log(me1 === me2); // outputs "true", assuming the first autoloaded parent is bound to an DOM element with an id set to "example".

@iamjochem with another implementation the feature was added in v1.0.0 release eb8d39c


Add Some Good Tutorial

You can add tutorial where anyone can start there journey to become blockchian developer with practical implementation.

Hi, make sure all content is in English. I'll review later


Make compute lock be more fine grained for start

On container activate we may need to pull an image or wait for container
IP to be assigned.  During this time we do not want to block other
container operations.

LGTM


Bugsnag prevents JVM from shutting down normally

Expected behavior
When all non daemon threads of any app  finish, the JVM shuts down normally... After implementing Bugsnag JVM still runs. This behavior is not what I expect, especially for AWT/Swing apps.
Steps to reproduce
`public class Test {
public static final void main(String[] args) {
    Bugsnag instance = new Bugsnag("api key");
}

}`
JVM will never shut down...
Version
3.6.1
Additional information
If this cannot be fixed, please update your implementation guide to call System.exit(0) or bugsnag.close() somewhere in the code. Calling System.exit(0) is not common in AWT/Swing apps as user closes window and UI thread finishes normally.
This issue made our app update mechanism broken as JVM was running and old  jar couldn't be overwritten with new one. Also it made our app unusable after broken update as we use FileLock to enable single instance of app and and lock was never released as JVM kept running. This has broken around 100 installations of our app before we realized what has happened and stopped update. Unfortunately we didn’t discover this bug during our testing, only after it was released to production.

Hi @smory
Thanks for the report. Our team are just discussing the best way forward to resolve this issue.

Possible solution would be to periodically check if there are any running deamon threads and if not call shutdown now on the sessionExecutorService.
Example of how to check threads using apache library
for (Thread t : ThreadUtils.getAllThreads()) {       System.out.println(t.getName() + ", " + t.isDaemon()); }

Hey, we just encountered this same issue at Robinhood. Is there an update on a fix?

Hi @bootstraponline thanks for letting us know! We do not currently have an eta for work on this. We will be sure to update back here when we have an update.

I just got bitten by this issue in a Dataflow project, the Bugsnag logback appender was causing the process to hang.
Any updates?

Hi @nullobject no updates at present. We will be sure to update here when there are.

This has now been fixed and released in v3.6.2


Update code to  supported OpenShift Kubernetes API

Upgrade the k8s api dependency to newer APIs

MCAD deployment fails on OpenShift 4.13

duplicate #468


readthedocs and python 3.5

Build failed, cause readthedocs does not deal with python 3.5. Maybe post documentation to github pages?

Documentation moved to github pages, until readthedocs update python version.
http://pohmelie.github.io/aioftp


Certificate verification, unkown CA

As mitmproxy using OpenSSL to verify certificates, mitmproxy won't allow HTTPS communication with an HTTPS server who's certificate is signed by a CA that is not known by OpenSSL. In order to solve my problem, I tried to run mitmdump with --set ssl_verify_upstream_trusted_ca=PEM_CA, then mitmproxy was able to connect via HTTPS to that site, but was using only the custom CA, instead of using it + all of OpenSSL known CAs, so all other HTTPS connections to the internet failed. (unable to get local issuer certificate error...).
How should this one be handled? Isn't there an option for telling mitmproxy to trust a custom CA in addition to all of OpenSSL known CAs?

Wouldn't this work ?
https://docs.mitmproxy.org/stable/concepts-certificates/#using-a-client-side-certificate

The logic in mitmproxy is as follows (this is for 5.0, but also applies for previous versions):

In the default configuration, we use https://pypi.org/project/certifi/ for ssl_verify_upstream_trusted_ca.
If ssl_verify_upstream_trusted_ca is set manually, only that is used.

If you want both, take the list from certifi and append it to your PEM file. 😃


[usbdev,dv] Adds Usbdev_bitstuff_err_vseq

Adds new sequence to verify usb device bitstuff error functionality.

@alees24

Thanks for this PR. Superseded now that USBDEV has reached V2S status.


super keyword type error

Bug report

[x] I confirm this is a bug with Supabase, not with my own application.
[x] I confirm I have searched the Docs, GitHub Discussions, and Discord.

Describe the bug
When trying to compile our Next.js app which uses the supabase client, we are getting the following build/lint error:
./node_modules/@supabase/functions-js/src/types.ts:21:11
Type error: Only public and protected base class methods are accessible via the 'super' keyword.

  19 |   constructor(message: string, name = 'FunctionsError', context?: any) {
  20 |     super(message)
> 21 |     super.name = name
     |           ^
  22 |     this.context = context
  23 |   }
  24 | }

To Reproduce
Steps to reproduce the behavior, please provide code snippets or a repository:

N/A

Expected behavior
No type errors occur.
Im sure the fix is:
//replace
super.name = name

// with
this.name = name

Screenshots
If applicable, add screenshots to help explain your problem.
System information

Version of supabase-js: 2.24.0

Additional context
Add any other context about the problem here.

Merged the PR, thanks!


Entropy uncertainty

Current coverage is 86.68% (diff: 84.61%)

Merging #79 into master will decrease coverage by 0.26%

@@             master        #79   diff @@
==========================================
  Files            26         26
  Lines           789        796     +7
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits            686        690     +4
- Misses          103        106     +3
  Partials          0          0

Powered by Codecov. Last update b73e9be...eae4a7f


Suggestion: add it for all lazy developers :))

Suggestion:
    /**
     * Function send
     * @param $text
     * @param bool $tts
     * @param null $embed
     * @return \React\Promise\Promise
     */
    public function send($text, $embed = null, $tts = false){
        return $this->sendMessage($text, $embed, $tts);
    }

    /**
     * Function sendEmbed
     * @param Embed $embed
     * @return \React\Promise\Promise
     */
    public function sendEmbed($embed){
        return $this->sendMessage("", $embed, false);
    }

    /**
     * Sends a message to the channel if it is a text channel.
     *
     * @param string $text  The text to send in the message.
     * @param Embed  $embed An embed to send.
     * @param bool   $tts   Whether the message should be sent with text to speech enabled.
     *
     * @return \React\Promise\Promise
     */
    public function sendMessage($text, $embed = null, $tts = false){
        $deferred = new Deferred();

        if ($this->getChannelType() != self::TYPE_TEXT) {
            $deferred->reject(new \Exception('You cannot send a message to a voice channel.'));

            return $deferred->promise();
        }

        $this->http->post(
            "channels/{$this->id}/messages",
            [
                'content' => $text,
                'tts' => $tts,
                'embed' => $embed,
            ]
        )->then(
            function ($response) use ($deferred) {
                $message = $this->factory->create(Message::class, $response, true);
                $this->messages->push($message);

                $deferred->resolve($message);
            },
            \React\Partial\bind([$deferred, 'reject'])
        );

        return $deferred->promise();
    }

sendMessage() > Parameter 2 changed to 3, because i use more Message-Embeds instedof TextToSpeech messages, lol

Added the sendEmbed function but don't want to add the send function as it will cause confusion with the parameter order.

sure, thanks.


Problem installing GitHub packages: "Cannot find command 'git' - do you have 'git' installed and in your PATH?"

C:\Users\Erick\Downloads\PokemonRedExperiments-master\PokemonRedExperiments-master\baselines>pip install -r requirements.txt
Collecting mediapy@ git+https://github.com/PWhiddy/mediapy.git@45101800d4f6adeffe814cad93de1db67c1bd614 (from -r requirements.txt (line 94))
Cloning https://github.com/PWhiddy/mediapy.git (to revision 45101800d4f6adeffe814cad93de1db67c1bd614) to c:\users\erick\appdata\local\temp\pip-install-n111e2vg\mediapy_764d51226f3847c0aa82f633e4c029ce
ERROR: Error [WinError 2] The system cannot find the file specified while executing command git version
ERROR: Cannot find command 'git' - do you have 'git' installed and in your PATH?
I have already checked that 'git' is in the PATH and I've also uninstalled git and reinstalled it but it's not working

so if you type git in the same command line and hit enter you don't see the same error?


Add full podSpec to all job types

Summary
With this commit it's now possible to specify a full podSpec for each job type available.
Checklist
For Code changes

[x] Categorize the PR by setting a good title and adding one of the labels:
bug, enhancement, documentation, change, breaking, dependency
as they show up in the changelog
[x] PR contains the label area:operator
[x] Link this PR to related issues
[x] I have not made any changes in the charts/ directory.

Still working on the docs, but the code should already be ready for review.

make test is broken
ok      github.com/k8up-io/k8up/v2/operator/locker      0.019s  coverage: 29.5% of statements
--- FAIL: TestRestore_args (0.00s)
    --- FAIL: TestRestore_args/givenS3RestoreResource_whenArgs_expectS3RestoreType (0.00s)
        executor_test.go:255:
                Error Trace:    /home/wejdross/vshn/shedar/k8up/operator/restorecontroller/executor_test.go:255
                Error:          Not equal:
                                expected: []string{"-varDir", "/k8up", "-restore", "-restoreType", "s3"}
                                actual  : []string{"-varDir", "", "-restore", "-restoreType", "s3"}

                                Diff:
                                --- Expected
                                +++ Actual
                                @@ -2,3 +2,3 @@
                                  (string) (len=7) "-varDir",
                                - (string) (len=5) "/k8up",
                                + (string) "",
                                  (string) (len=8) "-restore",
                Test:           TestRestore_args/givenS3RestoreResource_whenArgs_expectS3RestoreType
    --- FAIL: TestRestore_args/givenFolderRestoreResource_whenArgs_expectFolderRestoreType (0.00s)
        executor_test.go:255:
                Error Trace:    /home/wejdross/vshn/shedar/k8up/operator/restorecontroller/executor_test.go:255
                Error:          Not equal:
                                expected: []string{"-varDir", "/k8up", "-restore", "-restoreType", "folder"}
                                actual  : []string{"-varDir", "", "-restore", "-restoreType", "folder"}

                                Diff:
                                --- Expected
                                +++ Actual
                                @@ -2,3 +2,3 @@
                                  (string) (len=7) "-varDir",
                                - (string) (len=5) "/k8up",
                                + (string) "",
                                  (string) (len=8) "-restore",
                Test:           TestRestore_args/givenFolderRestoreResource_whenArgs_expectFolderRestoreType
    --- FAIL: TestRestore_args/givenFolderRestoreResourceWithAdditionalArguments_whenBuildRestoreObject_expectJobResource (0.00s)
        executor_test.go:255:
                Error Trace:    /home/wejdross/vshn/shedar/k8up/operator/restorecontroller/executor_test.go:255
                Error:          Not equal:
                                expected: []string{"-varDir", "/k8up", "-restore", "--tag", "testtag", "--tag", "another", "-restoreFilter", "testfilter", "-restoreSnap", "testsnapshot", "-restoreType", "folder"}
                                actual  : []string{"-varDir", "", "-restore", "--tag", "testtag", "--tag", "another", "-restoreFilter", "testfilter", "-restoreSnap", "testsnapshot", "-restoreType", "folder"}

                                Diff:
                                --- Expected
                                +++ Actual
                                @@ -2,3 +2,3 @@
                                  (string) (len=7) "-varDir",
                                - (string) (len=5) "/k8up",
                                + (string) "",
                                  (string) (len=8) "-restore",
                Test:           TestRestore_args/givenFolderRestoreResourceWithAdditionalArguments_whenBuildRestoreObject_expectJobResource
FAIL
coverage: 30.3% of statements

Huh, interesting. The CI Pipeline isn't running make test for some reason.
This specific test, checks the function setupArgs which hasn't been touched in a while.
I'm fixing it and adding make test to the CI tests :D

@wejdross one of the tests had the wrong build tag, that's why it failed, it was actually an integration test.


Clarification on Diffusion Timestep and Feature Extraction Process when using GenAD for Planning

Dear Authors,
First of all, thank you for your excellent work on the paper.
I have studied your approach and have some questions regarding the feature extraction process when using GenAD encoder for planning as described in the following paragraph:

Tab. 5 shows the planning results on nuScenes where ground truth poses are available for the ego vehicle. By freezing the GenAD encoder and only optimizing an additional MLP on top of it, the model can effectively learn to plan. In particular, by pre-extracting image features using GenAD's UNet encoder, the entire learning process for plan adaptation takes only 10 minutes on a single NVIDIA Tesla V100 device, which is 3400 times more efficient than training the UniAD planner.

I am particularly interested in understanding the following points:

Since GenAD is a diffusion denoising network that takes a diffusion timestep as input, could you specify which diffusion timestep is used during the feature extraction process?
Can you confirm that cleaned frames are used as input during this feature extraction process?
In addition, I would appreciate if you could provide more details about

From which GenAD encoder layer (or layers) are the features extracted?
Could you please provide more details on how the features are processed in the MLP?

Thank you very much for your time and help.
Best regards,

Hi Alberto,

Since GenAD is a diffusion denoising network that takes a diffusion timestep as input, could you specify which diffusion timestep is used during the feature extraction process?

We adopt timestep 0, which corresponds to the lowest diffusion level without noise. Note that GenAD's UNet takes $\sigma$ as a condition to indicate the timestep. The translation follows this implementation.

Can you confirm that cleaned frames are used as input during this feature extraction process?

Yes, original frames are applied without noise augmentation.

From which GenAD encoder layer (or layers) are the features extracted?

Our feature extraction ends at the middle block of GenAD's UNet (see the illustration below), and the upsample blocks are not used for this task.

Could you please provide more details on how the features are processed in the MLP?

We simply flatten the feature map after it is extracted by the UNet. The feature sequence is then sent to an MLP that regresses the planning waypoints.

Great!
Thank you so much for your detailed explanation!


Passkey/password pairing with NimBLE?

Hello,
I have the following question. I have a BLE device based on ESP32. It does not have input or output capabilities. I am using ESP-IDF and the NimBLE stack, which I'm very pleased with so far.
I want to do password authentication as follows:

User pairs to the ESP32 device from a smartphone app.
User generates a passkey or password and sends it to the ESP32 device, which in turn sets it as a password for pairing.
The next time a user wants to connect, the ESP32 device sends him a request for password.
If he enters the correct password, he pairs to the device. If not, he cannot pair.

Is this possible with the NimBLE stack and is there example code for this scenario?
Thank you in advance.
P.S. obviously I read the part about security in BLE user guide (https://mynewt.apache.org/latest/network/ble_sec.html), but there were no examples on exactly how to implement passkey pairing.

No replies, so I guess this is not possible.
In that case, has anyone had any success in modifying the BLE peripheral API to include a password for pairing?

Hi,
You can check btshell, it implements all pairing models

Hi,
You can check btshell, it implements all pairing models

As far as I can see, when you have a "no input/no output" device (as I do), you can't set a passkey.

yes, no input/no output iocapa doesn't allow for authenticated pairing

Let me rephrase the question: in the project I am using for a template, the GATT server is started with gatt_svr_init().

How do I stop it during runtime, since I can't find a gatt_svr_deinit() function?
Can I initialize GATT with a custom array of services, something like ble_gatts_add_svcs(my_custom_array)?