Don't call deprecated [RCTRootView cancelTouches]

According to the message in the commit it should not be needed anymore https://github.com/facebook/react-native/commit/36307d87e1974aff1abac598da2fd11c4e8e23c1. Not sure if we have a good test case for this to make sure it doesn't break but I've used it in my app for a while and everything seems fine (although I don't really mix RN and RNGH gesture components).
I kept didActivateInRootView empty since it is needed by the protocol but it might be possible to remove it from the protocol also.

👍

Is this change only compatible with a specific version of RN?
The simplest test case to verify this works correctly is:

RN's TouchableSth in a container with PanHandler assigned. In that case when you start press at Touchable it should highlight but cancel when Pan is detected (similar to a very popular case of having a button in scrollview)

@kmagiera According to the comment by @shergin the need for calling this was removed in 2017 so I assume this is fine compatibility wise.
I can try testing this case.

Yea I can confirm this breaks the case you mentionned
<PanGestureHandler
      onHandlerStateChange={e => {
        console.warn(e.nativeEvent.state);
      }}
    >
      <View style={{ flex: 1, alignItems: 'center', justifyContent: 'center' }}>
        <TouchableOpacity
          onPress={() => {}}
          style={{ backgroundColor: 'blue', width: 200, height: 100 }}
        />
      </View>
    </PanGestureHandler>

Not sure what the best way forward would be, @shergin do you know why this api was deprecated?

I also tried this change and I'm afraid calling cancelTouches is in fact necessary. I'd suggest that we change core to remove deprecated annotation for that method as it is needed for the cases when touch stream needs to be cancelled as some other gesture recognizer takes over (note that on IOS gesture recognizers does not get notified if some other gesture recognizer takes over the touch stream)

How can this be deprecated if it's still needed?
Sorry if I am ignorant, but I don't get what the actual problem is and where it needs to be fixed

is there a PR open on react-native core that removes the deprecation? My app is crashing due to this right now (in a release build on a real device).

is there a PR open on react-native core that removes the deprecation? My app is crashing due to this right now (in a release build on a real device).

Wow. On iOS or Android?

@IjzerenHein same here. Crashes on iOS (don't tested yet on Android).

Same here!!

same here!

I had crashes on both android and ios release builds.
Fixed for android by adding import 'react-native-gesture-handler' on top of index.js.
Going to try it for ios now.
Source

this was already fixed? Still happing here when focus on any TextInput.
Panthom solution above doesn't work here

I see that the warning will not be triggered if you put multiline TextInput  property (iOS). RN 61

This error crashes in production. This is terrible. Has anyone fixed it?

@Andriiklymiuk did you try  adding import 'react-native-gesture-handler' on top of index.js

@phantom1299 I tried and it worked. Really strange fix, but thanks)

Is there any solution right now? If Facebook isn't going to add back the cancelTouches function, will this package use an alternative solution for this error? Thanks.

release build on IOS crashes , anywork around ?

I try put
1 - import 'react-native-gesture-handler' at the top of index.js
2 - YellowBox.ignoreWarnings([
'RCTRootView cancelTouches'
]);
And don't works. Any news about the solution?

@kmagiera is there any issue in main fb/rn repo to track needed fix? Right now, the fix with importing the rn-gesture in top lvl index.js file is bit hacky.

Any news? Tried importing in index.js, tried wrapping screens in gestureHandlerRootHOC but with no success.

YellowBox.ignoreWarnings([
'RCTRootView cancelTouches'
]);
works for me

@devilabhi The problem is for production builds, where this warning is basically crashing the app

@Andriiklymiuk did you try adding import 'react-native-gesture-handler' on top of index.js

it Work for Android but No for IOS

Same here, it works for android but not for IOS.
Even when I do:
import 'react-native-gesture-handler';
and
import {gestureHandlerRootHOC} from 'react-native-gesture-handler';
AppRegistry.registerComponent(appName, () => gestureHandlerRootHOC(App));

"react": "16.9.0",
"react-native": "0.61.2",
"react-native-maps": "^0.26.1",
"react-native-reanimated": "^1.3.0",
"react-native-gesture-handler": "^1.4.1",

@kmagiera Krzysztof, could you please describe why exactly react-native-gesture-handler needs this feature; why it cannot use standard UIGestureRecognizer-based conflict-resolution approach?
I assume the library contains some GR, so why it's a problem to "ask" RN built-in GR to fail in favoour of your GR using standard UIKit APIs (which are way more flexible)?

Hey @shergin – so the reason why it is needed it to keep RN's JS touch system and native gesture system in sync in case an external gesture handler captures the touch stream. What happens now in RN core is that we send touch down, move, up, and cancel events to javascript where there is a state machine relying on receiving all the events in order not to dispatch them properly to the respective targets.
When there are other native gesture recognizers taking part in the process what could happen is that they start recognizing along with the main RN's touch recognizer. When they ended up recognizing the gesture and want to take precedence over RN's touch recognizer the RN's gesture handler will stop receving events. Apparently UIGestureRecognizer does not get notified when some other recognizer captures the touch stream. In particular it does not receive a state change event. This has been a bit counterintuitive for me when I started learning more about gesture rezognizers on iOS but it is just how they work. As a result we need a way to tell the RN's gesture recognizer that some other recognizer has captured the stream in order for it to dispatch touch cancel event to the JS to keep the JS state machine in sync.
An example of this is with native UIViewNavigationController in case when the builtin UIScreenEdgePanGestureRecognizer can kick in when swiping back (same thing happens with new iOS 13 modals that can be pulled down). If the swipe starts at a place where we have TouchablHighlight it will highlight and not get back to the normal state when the swipe starts. It is because both gesture recognizers will start recognizing, the edge one will recognize at some point but JS will never learn of that fact unless we call cancelTouches.
This is a very similar case to when we have touchables inside a ScrollView, however for the case of scrollview JS state machine uses scroll events to reset its state.
I am not sure if there is another way to workaround this problem as I don't have enough time now to verify this, but one possibility could be that we can rely on reset being called in case some other recognizer steals touch stream https://github.com/facebook/react-native/blob/aee88b6843cea63d6aa0b5879ad6ef9da4701846/React/Base/RCTTouchHandler.m#L354 – I suspect what may happen in this case is that _nativeTouches may have more than 0 touches registered. It could be because of the reasons I mentioned and the fact that touchesCancelled will never be called when other recognizer activates.
Hope this is helpful, lmk if you need more details.

Should the cancelling of touches not at least be more discriminating? ie only if the gesture recognizer has cancelsTouchesInView set? Otherwise the GR is indicating it is happy to cooperate with other touch consumers.
This cancelTouches code is caused me issues with a native module that attaches gesture recognizers to the main window that have no interaction with the RN system but trigger this code and that breaks other touch/gesture recognition.

Hi for anyone facing this problem,
@osdnk has already committed the fix to the master branch.
You can now fix this error by updating the package.json with following:
"react-native-gesture-handler": "git@github.com:kmagiera/react-native-gesture-handler#1f47596713a709af0d368b45ac3ba02a67375347",

and npm install again. This solution is a temporary work before react-native-gesture-handler releases v1.4.2.

hi @richardgroves – appreciate your comment , however in order to answer your question I'd need to learn more about your setup. What I don't quite understand is how your window GR that has no integration with RN code may trigger a method in a RN library. What would work best in this case is if you could open a new issue and provide a small repository illustrating this problem. I'd prefer in this particular issue to focus on the problem of crashes related to calling a deprecated method.

@swingywc FYI I just published 1.5.0 version with this update (we bump 1.4.1 -> 1.5.0 and not 1.4.2 because of native changes made on top of 1.4.1)

Thanks @kmagiera.

I have updated to 1.5.0 version. At the moment there is no warning in debug mode but my app still continue to crash in same situations in release mode.

1.5.0 update, followed by unlinking and relinking the library, seems to solve the issue for me.

@hkan deleted that from mine after updating thinking it was not longer necessary, will try that

That did the trick, but was already working with the previous version of gestures handler. At least the warning is gone in dev builds

@kmagiera We are mostly on the same page! Thank you for your awesome effort to make gesture handling better! ❤
Let's talk the tech stuff:

The reason why it is needed it to keep RN's JS touch system and native gesture system in sync in case an external gesture handler captures the touch stream.

Yeah!

What happens now in RN core is that we send touch down, move, up, and cancel events to javascript where there is a state machine relying on receiving all the events in order not to dispatch them properly to the respective targets.

Yes!

When there are other native gesture recognizers taking part in the process what could happen is that they start recognizing along with the main RN's touch recognizer. When they ended up recognizing the gesture and want to take precedence over RN's touch recognizer the RN's gesture handler will stop receving events.

I am deeply aware of this issue.
I think, that's not exactly what happens. IIRC, by design, RN's GR always fails in favor of any native gesture recognizer. When it happens, it sends cancel touch events to JS side notifying the state machine that those touches are not valid anymore.
I know about that because I implemented that ~3 years ago especially to solve all GR problems which we have internally at Facebook (and we have plenty of them). That's why I strongly believe that global cancelTouches is not a good API for that.

Apparently UIGestureRecognizer does not get notified when some other recognizer captures the touch stream.

Which one? AFAIK, iOS has several dedicated methods on GR class that designed to solve this exact problem.

In particular it does not receive a state change event. This has been a bit counterintuitive for me when I started learning more about gesture recognizers on iOS but it is just how they work.

Really? Could you please elaborate on that?
I think we can force state to be ended when all touches got cancelled (via  touchesCancelled:withEvent:).

As a result we need a way to tell the RN's gesture recognizer that some other recognizer has captured the stream in order for it to dispatch touch cancel event to the JS to keep the JS state machine in sync.

That's the most controversial part to me. I think any attempt to mess with touch recognizers bypassing GR resolution protocol will eventually messy and fail miserably.

An example of this is with native UIViewNavigationController in case when the builtin UIScreenEdgePanGestureRecognizer can kick in when swiping back (same thing happens with new iOS 13 modals that can be pulled down). If the swipe starts at a place where we have TouchablHighlight it will highlight and not get back to the normal state when the swipe starts. It is because both gesture recognizers will start recognizing, the edge one will recognize at some point but JS will never learn of that fact unless we call cancelTouches.

Something wrong happens somewhere else. RN GR must deliver cancel touches to JS side which must help internal state machine to be in-sync.

This is a very similar case to when we have touchables inside a ScrollView, however for the case of scrollview JS state machine uses scroll events to reset its state.

Same.

I am not sure if there is another way to workaround this problem as I don't have enough time now to verify this, but one possibility could be that we can rely on reset being called in case some other recognizer steals touch stream https://github.com/facebook/react-native/blob/aee88b6843cea63d6aa0b5879ad6ef9da4701846/React/Base/RCTTouchHandler.m#L354 – I suspect what may happen in this case is that _nativeTouches may have more than 0 touches registered. It could be because of the reasons I mentioned and the fact that touchesCancelled will never be called when other recognizer activates.

Oh yeah! That's probably how it works. I don't remember details anymore, 3 years passed.

Hope this is helpful, lmk if you need more details.

Krzysztof, we both share the passion of majestic gestures working properly. Let's figure this out together.

@swingywc @osdnk Which fix exactly?

@shergin
https://github.com/kmagiera/react-native-gesture-handler/commit/1f47596713a709af0d368b45ac3ba02a67375347#diff-317a7c9e735ce50581669d39ea18c805L162
I know that this is not perfect

It's actually fix for displaying a warning, not a bug itself

Thanks @shergin for your input on this. Really appreciate you chiming in here.
I want to be mindful of your time spend on this so will do my best to explain what we're trying to achieve here and if you have time to read through all of that would appreciate if you could suggest on how this is resolved in fb codebase.
First, for the sake of simplicity let us focus on the following usecase:
In an app we render a native view with an attached pan gesture recognizer (UIPanGestureRecognizer) which is set up in a way that you can drag that view around. Inside that view (as a subview) we render RN's touchable element – say a TouchableHighlight with some text.
Now when you tap on touchable you want its onPress to be triggered. When you hold finger on touchable and start dragging it should first highlight, then pan recognizer should kick in and the view should start moving along while the touchable should unhighlight. When you lift the finger the onPress should not trigger.
In order for the above to work what needs to happen is that JS responder should deliver touch cancel to touchable when the pan gesture recognizer activates.
A very similar situation occurs when we have touchable inside of a ScrollView. I believe that in this case the following code is responsible for cancelling JS responder: see ResponderEventPlugin.js
However, in case of pan gesture responder we are not sending scroll events and the only alternative to make JS responder deliver cancel touchable is to dispatch topTouchCancel.
After checking how topTouchCancel can be dispatched on iOS the only place I've found was touchesCancelled:withEvent method in RCTTouchHandler.m. And so we should expect that method to be invoked when pan gesture handler from the described use case kicks in. However based on Apple's GR documentation this method is only called when system event cancels touch sequence (e.g. when alert dialog appears while the touch sequence is ongoing). From the testing I've done, this method also gets triggered when recognizer gets disabled while receiving touch sequence (this is what RCTTouchHandler#cancel does).
I do not see a way based on GR API means how that method could've get triggered otherwise. From my expirience working with gesture recognizer the fact that some other gesture recognizer activates does not result in any of the delegate method getting triggered. I also analyzed the case of reset method I mentioned earlier and it turns out that reset only gets called when touch sequence is over (so in our usecase it'd get triggered when you lift the finger up and not when the pan gesture activates).

I am sure I'm definitely missing something and I wonder if you could share any pointers on how touchables might get cancel event delivered in fb codebase if there exists a similar usecase there.

Sure.
If some gesture recognizer needs to "win" over RN one, it returns yes in shouldRequireFailureOfGestureRecognizer: (or something like this). RN GR always obeys.

Now when you tap on touchable you want its onPress to be triggered. When you hold finger on touchable and start dragging it should first highlight, then pan recognizer should kick in and the view should start moving along while the touchable should unhighlight (cancel). When you lift the finger the onPress should not trigger.

FB blue app has swipe-left-to-pop-view-controller GR. That just works. They (that GR and RN GR) know nothing about each other. The first one is just "being bold" and return YES in shouldRequireFailureOfGestureRecognizer: (or some similar method, I don't recall the exact semantic, GR has like a four of those methods) and RN GR just obeys. It sends cancel touches to JS and the JS-based state machine react accordingly.

Correction: I think it works this way: The bold GH does this:

Returns NO for  canBePreventedByGestureRecognizer:;
Returns YES canPreventGestureRecognizer:.

Hey @shergin, so I played with the suggested methods and what I found out is:

RCTTouchHandler#canBePreventedByGestureRecognizer returns YES only for GR that are attached to react root's parent views. In the described use case the pannable view is a subview of the react root view. For testing purposes I changed the condition to fail for my RG
With the condition changed RCTTouchHandler properly fails recognition. However as mentioned earlier cancel events are not being delivered because touchesCanceled only gets triggered when system event occurs. In the described usecase the touchable does not fire onPress handler when we stop panning but the element stays highlighted while we are panning.

@kmagiera Hmmmm...

I think I am okay with changing that condition. I don't recall any special reasons for that besides being afraid to break something unrelated. (Implementing that originally was a huge risk.) Anyway, I think we can figure out some approach that works for your GR. For now, let's assume that we return the value there unconditionally.

It's really hard to believe in that knowing that so much stuff is dependent of that internally. Imagine how many unrelated to RN gesture recognizes hybrid apps (and FB blue app as an example) have; if just one of them will force RN GR fail and if RN GR does not issue cancel touches, from this exact moment, the whole touches RN infra will be screwed (practically touches will not work at all).

Man, you are the world's best expert in the area, really, I cannot believe you cannot figure it out. If not you, who will?
Do I understand right that you are observeing this:

Your GR forces RN GR to fail;
RN GR fails;
RN GR does not issue cancel-touches, so JS part still think that those touches are still down.

Hey @shergin, thanks for getting back.

It's really hard to believe in that knowing that so much stuff is dependent of that internally. Imagine how many unrelated to RN gesture recognizes hybrid apps (and FB blue app as an example) have; if just one of them will force RN GR fail and if RN GR does not issue cancel touches, from this exact moment, the whole touches RN infra will be screwed (practically touches will not work at all).

I know, right? I am as much surprised as you are. I think this is actually due to the fact that the issue is very subtle. It only applies to the cases where you interact with a touchable while that external GR gets activated. In such case you end up having both GR active and touchable highlighted. I don't know if you have any examples of that in your codebase and if not I can work on a small repro app to illustrate that.
Also note that this issue is much more apparent when you consider not only external gesture recognizers. In that case it is much more common that you have a mix of GR and touchable that can both interact with the same touch stream (e.g., swipeable table rows).

Do I understand right that you are observeing this:

Your GR forces RN GR to fail;
RN GR fails;
RN GR does not issue cancel-touches, so JS part still think that those touches are still down.

Yes, this is exactly what happens. If you think that'd be helpful I can work on a small repro case that illustrates what's going on.

Hey @shergin – so I went ahead and made a small repro app here: https://github.com/kmagiera/CancelTouchesExample
There is also a comprehensive instruction on how to make changes both to gesture-handler and RN's RCTTouchHandler which hopefully illustrates the case I was trying to make.
Hope you can find some time to try it or at least read the README of that repo that should provide a better insight into the problem.

Hey @shergin any chance you'll have time to take a look at that repo I prepared?

@kmagiera Thank you so much for such comprehensive test case!!1 I have some questions about that; I asked them in Discord.


Fix post 1.13.2 textures

The textures for post 1.13.2 blocks are buggy, we should fix them

This may be relevant: https://github.com/iceiix/stevenarella/pull/71
If you only want to support post-flattening resource packs, easiest solution would be to update RESOURCES_VERSION, and the corresponding texture names

Fixed by #191

Sadly, this isn't fully fixed as the 1.13 don't load yet.

Fixed by #256


issue #3312 (SQL login) implemented on new branch

👍 looks good pls bring up to date with master.

does not log in on the 1st try.  i made a cell that should run in s particular DB, and set up its jdbc string like:
jdbc:sqlserver://zzzz.twosigma.com:1433;DatabaseName=xxxxxx;user=yyyyyy;password=<prompt>

and then ran the cell, it failed with an error:
java.sql.SQLException: Cannot create PoolableConnectionFactory (Login failed for user 'yyyyyyy'. ClientConnectionId:c7c2be9d-5f21-48da-be4b-caa8fe88503c)

then i run it and and the 2nd time it prompts for password.  i enter it and the user and get the same error again.

cool, the login procedure works!  some remaining issues:

if you press enter after typing the password, that should be the same as pressing OK
if you press ESC or click cancel, then it should fail the execution with an error "no password provided".  right now, if you close the dialog the evaluation gets stuck "pending" and cannot be canceled.

the connection string should wrap sooner so that a scrollbar does not appear.
"Default data source" should go across the dialog, not be restricted to the left column.
delete "connection string" and start the jdbc string on the left column and let it flow all the way across.
keep only one hrule, the one between the jdbc string and the name field.  delete the other 3 lines.

All PR notes are done

👍
will merge after the spark changes settle down.


Remove warning when using it without bootstrap-sass

I'm just integrated this package into my app, but I want to use it without boostrap-sass. We're providing bootstrap css internally in the app. It works ok but the warning is annoying. Is there a way to disable it? If it needs change in the package code, and you're ok with it, please give me some pointers and I can work on it myself.

@gnapse Can you please post the output of ember bootstrap:info, and which warning are you receiving?

@simonihmig here it is
$ ember bootstrap:info
Npm packages:
ember-bootstrap: 1.0.0-beta.1 -> 1.0.0-beta.1
ember-cli: 2.13.2 -> 2.13.2
bootstrap: n/a
bootstrap-sass: n/a
ember-cli-sass: 5.5.1 -> 5.5.1
ember-cli-less: n/a
Bower packages:
bootstrap: n/a
bootstrap-sass: n/a
ember-bootstrap configuration:
bootstrapVersion: 3
importBootstrapFont: false
importBootstrapCSS: false

$ ember build --watch
Npm package "bootstrap-sass" is missing, but is typically required for SASS support.
Please run `ember generate ember-bootstrap` to install the missing dependencies!

So you want to use SASS for something else, but not with ember-bootstrap? If you want to use Bootstrap 3 with SASS, we recommend the bootstrap-sass packaging of Bootstrap.
We recently downgraded it to a warning instead of an error, but it's a configuration that only makes sense for more advanced or unusual use cases. I think we need some level of safety net for newer users.
@simonihmig Do you think the more intelligent blueprint may justify removing some of the warnings or only generating them in a verbose mode that has to explicitly be turned on? Do we still need the same level of safety net?

If I state that I don't want to load bootstrap's css, can't that setting be used to decide wether to show the warning or not? I thought that stating in the settings not to load the bootstrap css, would mean this package is not needed.

That setting determines whether the load the static CSS, where true implies you aren't using a preprocessor and false implies you are using a preprocessor in the dominant configurations.
What is your use case for using ember-bootstrap and not wanting to import any bootstrap package? Do you have a customized bootstrap or equivalent set of classes? You need some bootstrap equivalent for ember-bootstrap to be useful.

Never mind. I just realized bootstrap also worked because we were importing it via bower prior to incorporating your gem. Now that I incorporated this package, which requires bootstrap-sass, I'll remove the bower dependency and use that instead.

@gnapse Cool. Thanks for talking through this. I recommend running the generator. It will make all the changes for you.
ember g ember-bootstrap --bootstrap-version=3 --preprocessor=sass


Reenable test/Concurrency/Runtime/executor_deinit1.swift on iOS simulator.

The failure no longer reproduces. rdar://76611676

@swift-ci Please test


TextField doesn't loose focus on Android

When using Android simulator Nexus5X API 27 tapping on ('Android') button to dismiss keyboard doesn't remove focus from TextField thus preventing layout update after keyboard is dismissed. I have not found other way to listen for keyboard dismiss, and would expect that this is the correct way to do it. I guess this is an issue for all devices which have button to dismiss keyboard.
Steps to Reproduce
import 'package:flutter/material.dart';

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        primarySwatch: Colors.blue,
      ),
      home: MyHomePage(title: 'Flutter Demo Home Page'),
    );
  }
}

class MyHomePage extends StatefulWidget {
  MyHomePage({Key key, this.title}) : super(key: key);

  final String title;

  @override
  _MyHomePageState createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  FocusNode _focusNode = FocusNode();

  @override
  void initState() {
    super.initState();

    _focusNode.addListener(() {
      print('Something happened');
    });
  }

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text(widget.title),
      ),
      body: Center(
        child: TextField(
          focusNode: _focusNode,
          autofocus: true,
        ),
      ),
    );
  }
}

Logs

Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel beta, v1.3.8, on Mac OS X 10.14.3 18D109, locale en-US)
[✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
[✓] iOS toolchain - develop for iOS devices (Xcode 10.2)
[✓] Android Studio (version 3.3)
[!] IntelliJ IDEA Ultimate Edition (version 2018.1.2)
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
[✓] Connected device (3 available)

! Doctor found issues in 1 category.

Using your code, I see that the FocusNode listener is not called when clicking the Android "down arrow" button to dismiss the keyboard, but it is called when clicking the checkmark in the keyboard.  I'll try to figure out what the desired behavior is.
Besides the event, I think that visually keeping the cursor in the input after dismissing the keyboard is desired, though.  I see the same behavior in native Android.

If keeping the cursor in the input in that case is desired then it explains why focus node doesn't push new event after keyboard dismiss and why this approach doesn't handle all use cases. Then I would need some other way to listen for keyboard change and I do not know any other listener for that. Something like UIKeyboardWillShowNotification and UIKeyboardWillHideNotification in iOS. Am I missing something? I would suggest to either expand listener for focus node so that we can listen for keyboard change events as well  or to have some completely different listener for keyboard change events.

@gspencergoog This is the focus issue I mentioned to you.  Will your work affect this at all?

No, this won't be affected by my work.  I don't know of a way to listen for the keyboard show/hide events at the moment, but that would be a good addition, especially since the platform can hide the keyboard independent of losing focus.

In latest stable (1.20.2) using given code sample, tapping on down arrow key keeps the cursor focused in textfield, while tapping on Done on keyboard removes the cursor focused.  Tested on Android 8.1.0 device.

I have the same issue on Android. I show an overlay with a complex widget of search results for a search field. I would like to hide the overlay when the user dismisses the keyboard, however it can only be closed using the check icon on the keyboard. I have other controls on the page (slider) but those does not seem to grab the focus when used so I am stuck with an always open search box. Is there a workaround or any suggestion that I could implement? Thanks for the help.

I can reproduce the issue on the latest stable and the master channel, On tapping the Android back button the cursor stil stays inside the TextField but on submitting (click the check icon on the keyboard) the TextField loses focus completely (cursor disappears).
I checked the behavior in a few other apps Instagram and youtube seem to have cursor on pressing back button
while Whatsapp does remove the cursor on pressing the back button, So Perhaps being able to configure this behavior would be ideal.

Youtube
Instagram
Flutter

flutter doctor -v (mac)
[✓] Flutter (Channel master, 3.6.0-6.0.pre.33, on macOS 12.6 21G115 darwin-arm64,
    locale en-IN)
    • Flutter version 3.6.0-6.0.pre.33 on channel master at
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision a9858ec524 (72 minutes ago), 2022-11-21 10:58:11 -0500
    • Engine revision 46a6b54295
    • Dart version 2.19.0 (build 2.19.0-406.0.dev)
    • DevTools version 2.19.0
    • If those were intentional, you can disregard the above warnings; however it is
      recommended to use "git" directly to perform update checks and upgrades.

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0-rc4)
    • Android SDK at /Users/mahesh/Library/Android/sdk
    • Platform android-33, build-tools 33.0.0-rc4
    • ANDROID_HOME = /Users/mahesh/Library/Android/sdk
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.0.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14A400
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)

[✓] IntelliJ IDEA Community Edition (version 2021.2.1)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 61.2.4
    • Dart plugin version 212.5080.8

[✓] VS Code (version 1.70.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.53.20221101

[✓] Connected device (3 available)
    • iPhone 12 Pro (mobile) • 026D5789-9E78-4AD5-B1B2-3F8D4E7F65E4 • ios
      • com.apple.CoreSimulator.SimRuntime.iOS-14-5 (simulator)
    • macOS (desktop)        • macos                                • darwin-arm64
      • macOS 12.6 21G115 darwin-arm64
    • Chrome (web)           • chrome                               • web-javascript
      • Google Chrome 107.0.5304.110

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

[✓] Flutter (Channel stable, 3.3.9, on macOS 12.6 21G115 darwin-arm, locale en-IN)
    • Flutter version 3.3.9 on channel stable at /Users/mahesh/Development/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision b8f7f1f986 (24 hours ago), 2022-11-23 06:43:51 +0900
    • Engine revision 8f2221fbef
    • Dart version 2.18.5
    • DevTools version 2.15.0

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0-rc4)
    • Android SDK at /Users/mahesh/Library/Android/sdk
    • Platform android-33, build-tools 33.0.0-rc4
    • ANDROID_HOME = /Users/mahesh/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.0.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14A400
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)

[✓] IntelliJ IDEA Community Edition (version 2021.2.1)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 61.2.4
    • Dart plugin version 212.5080.8

[✓] VS Code (version 1.70.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.53.20221101

[✓] Connected device (3 available)
    • iPhone 12 Pro (mobile) • 026D5789-9E78-4AD5-B1B2-3F8D4E7F65E4 • ios            •
      com.apple.CoreSimulator.SimRuntime.iOS-14-5 (simulator)
    • macOS (desktop)        • macos                                • darwin-arm64   • macOS 12.6 21G115 darwin-arm
    • Chrome (web)           • chrome                               • web-javascript • Google Chrome 107.0.5304.110

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

You could use MediaQuery.viewInsets for keyboard visibility


Add JSON support

As alluded to on Twitter, this allows users to use JSON in request and response bodies. E.g.:
stubRequest(@"POST", @"http://server.dev/user")
    .withJSON(@{ @"name": @"robb", @"pw": @"foobarbaz" })
    .andReturn(201);

BOOL success = [client signUpWithUserName:@"robb" password:@"foobarbaz"];

It works by parsing the JSON contents if the header are set appropriately and comparing the dictionaries, which makes us independent of internals of NSJSONSerialization.
 I updated some of the dependencies to please the compiler but had to mark two tests as pending for the time being.

@robb I just outlined here the ideal way of implementing support for arbitraty matching logic. This approach has been possible from day one, it didn't occur to me to use it for json, apologies.
I like better the approach outlined there because it keep the surface of the DSL to a minimum, and does not couple the DSL to specific content types, which has been always my concern about implementing JSON support this particular way.
Let me know what you think.


No Code Generated for dotnetcoreapp2.0

I've been working on documenting a microservice written in .NET Core 2.0. I've used the GUI to point it at the solution file and an individual csproj file. Both attempts failed to create an documentation from the XML comments.
Is documentation from XML comments for .NET Core a known limitation or am I just doing something wrong configuring.
SDOX:
<?xml version="1.0" encoding="utf-8" standalone="yes"?>
<SDConfig>

    <item key="ConfigFileName" value="html-documentation-builder" />
    <item key="ProjectName" value="Awesome Microservice" />
    <item key="AuthorUrl" value="" />
    <item key="VersionNumber" value="1" />
    <InputFile>
      <Relative>..\microservice\AwesomeProject.sln</Relative>
      <Full>C:\git\awesome-project\microservice\AwesomeProject.sln</Full>
    </InputFile>
    <OutputPath>
      <Relative></Relative>
      <Full>C:\git\awesome-project\docs</Full>
    </OutputPath>
    <item key="DocLanguage" value="en" />
    <item key="ExcludePrivate" value="False" />
    <item key="ExcludeProtected" value="False" />
    <item key="ExcludeInternal" value="False" />
    <item key="ExcludedIdentifiers" value="" />
    <item key="ActivatedExporters" value="Html" />

    <item key="Theme" value="sharpDox" />
    <item key="ShowCode" value="True" />
    <item key="PrimaryColor" value="#F5F4F0" />
    <item key="SecondaryColor" value="#F58026" />
    <item key="DisableSequenceDiagrams" value="False" />

</SDConfig>

It is not necessary to active the XML documentation generation. Unfortunately sharpDox was not tested on .NET Core until now. I think there are some changes necessary. Maybe I can look into this in a few days.


'types.SimpleNamespace' object has no attribute 'synchro'

I was trying to use this lib with:
sanic = "21.9.3"
sanic-cors = "^1.0.0"
sanic-jwt = "^1.6.0"
sanic-routing = "^0.7.2"
sanic-ext = "^22.1.2"
sanic-synchro-ctx = "^0.1.0"
Output
request.app.ctx.synchro.set_default({"counter": 0})
AttributeError: 'types.SimpleNamespace' object has no attribute 'synchro'

@jonra1993
Thanks for the bug report.
Looks like this specific bug is caused by a combination of using Sanic-Synchro-CTX in conjuction with sanic-ext (that puts synchro-ctx in "ext-mode", acting as a sanic-ext extension) and only on v21.9.3, because Sanic doesn't call "startup" on the extensions Sanic less than 21.12.
Its a simple fix, I'll push out a fix for this later today.

@jonra1993
Sorry, my answer above was completely wrong.
The error you're seeing here is caused because when you have sanic-ext installed, you must use plugins a little differently.
See the this example (this is the same as simply.py from examples, but modified for use with sanic-ext).
from sanic import Sanic
from sanic.response import html
from sanic.request import Request
from sanic_ext import Extend
from sanic_synchro_ctx import SanicSynchroCtx

app = Sanic("simple")
Extend(app, extensions=[SanicSynchroCtx])

@app.after_server_start
def handler(app, loop=None):
    # This will only set this value if it doesn't already exist
    # So only the first worker will set this value
    app.ctx.synchro.set_default({"counter": 0})

@app.route("/")
def index(request: Request):
    counter = request.app.ctx.synchro.increment("counter")

    print("counter: {}".format(counter), flush=True)
    return html("
Hello World
")

app.run("<IP_ADDRESS>", port=8000, workers=8, debug=False, auto_reload=False, access_log=False)

Thanks, @ashleysommer that solving the error message and the example is working. One question do you think I can use this synchro context to share more complex data structures different than dictionaries and numbers. I need to share between workers an instantiated object of an ML.

Thats a good question. To be honest, I haven't tried it other than simple dicts, lists, strings and numbers.
I don't think you can pass an instantiated object between workers, unless that object can be pickeled. Python needs to covert the instantiated object into a pickle object in order to send it between workers, and some things simply cannot be picked.
Best to try it out and see.

Hello, @ashleysommer thanks for the information I was able to add dicts, lists, strings and numbers but when I try add an object it returns None. I want to go to check more about it.


SQL Based_SQL Action: Before adding long running scenario query, the workflow is succeeded.

Describe the Bug with repro steps
1.Create a project and add Stateful workflow in VS code.
2.Convert your workflow in SQL Based.
3.Open Designer and add http trigger and sql_Execute query_EXEC wait2;
4.Save and Debug the workflow.
Expected: The workflow should be failed after 2 minutes.
Actual: The workflow is succeeded after 2 minutes.

What type of Logic App Is this happening in?
Standard (VSCode)
Are you using Preview Designer or GA Designer
Preview
Workflow JSON
No response
Screenshots or Videos
No response
Browser
VS Code
Additional context
Vendor Testing
VS Code extension - vscode-azurelogicapps-2.15.10.vsix
NuGet package: https://artprodeussu2.artifacts.visualstudio.com/A41bf5486-7392-4b7a-a7e3-a735c767e3b3/b32aa71e-8ed2-41b2-9d77-5bc261222004/_apis/artifact/cGlwZWxpbmVhcnRpZmFjdDovL21zYXp1cmUvcHJvamVjdElkL2IzMmFhNzFlLThlZDItNDFiMi05ZDc3LTViYzI2MTIyMjAwNC9idWlsZElkLzcyNDMyOTY3L2FydGlmYWN0TmFtZS9kcm9wX2J1aWxkX0J1aWxkQXJ0aWZhY3RzX1dpbmRvd3M1/content?format=file&subPath=%2FMicrosoft.Azure.Workflows.WebJobs.Extension.1.19.4.nupkg
Extension Bundle (CDN URL): https://cdnforlogicappsv2.blob.core.windows.net/logicapps-vendortesting
Extension Bundle (Direct Download): https://cdnforlogicappsv2.blob.core.windows.net/logicapps-vendortesting/ExtensionBundles/Microsoft.Azure.Functions.ExtensionBundle.Workflows/1.19.4/Microsoft.Azure.Functions.ExtensionBundle.Workflows.1.19.4_any-any.zip

@v-prakumar - Please share your workflow definition so we know what inputs or settings you have provided.

@ccastrotrejo Issue is same in the VSIX - 2.18.0, and also it is succeeded with this error.PFA.


Most points in SIDE_LEFT(SIDE RIGHT, FRONT LEFT, FRONT RIGHT) are invalid

Most points captured by SIDE_LEFT laser are invalid (>95%) since their RANGE values in the range image are -1. While for TOP laser, the invalid points only take up ~10%. Is there any reason why these range images are so different? I also noted that the range in SIDE_LEFT is limited to 20 meters. But in the TOP range image, the points in [0, 20meters] take up ~80%. So the range limit seems not a reason.
Besides, the height of the SIDE_LEFT range image is 200. Does that mean the laser has 200 beams?

This is expected


Update to esbuild 0.17+

Esbuild version 0.17 (see changelog) dropped support for the watch variable in "build.initialOptions.watch". In situations where a current version of esbuild is used, esbuild-os-notifier will stop working entirely.
The attached PR therefore:

removes the problematic line
updates esbuild dependency to version 0.17.19
updates esbuild-os-notifier version to 1.1.0

Hey @danielperez9430 did u have any chance to check this PR?

Hello good morning,
LGTM
I had not received the MR notification in the mail 🫤
But I will merge it now


IK Post Processing pass using SkeletonModifier

Depending on the MMSynchronizer being used, capsule to skeleton synchronization may cause foot sliding. This requires a SkeletonModifier to use IK to lock feet in place.

Godot 4.4 built in IK
https://github.com/GuilhermeGSousa/godot-motion-matching/discussions/29

What are the expected inputs and outputs for the ik?

I haven't given this much thought yet, but for feet IK we might only need the feet's bone names.
This isn't implemented yet, but we might want to run motion matching queries against world points, to do stuff like touching a wall when moving past one, touching a surface when vaulting, etc. In that case, the skeleton modifier would also need both the bones affected by IK, and the world position they must reach.
Depending on the synchronization method used to sync character capsule and character skeleton, we might also want to do some stride warping. I've used this method in Unreal, it works pretty well, it allows us to clamp the skeleton to the player capsule, then warp the leg stride of the animation to match the speed of the capsule.
In that case we'd need

The character speed and character thigh bone, so we can estimate the correct stride distance.
An influence coeficient from 0 to 1. Depending on how much we rely on root motion to move around we might not need the full effect of stride warping.

If you want to see for yourself what these MMSynchronizer actually do, if you play the demo you'll notice that the player capsule and skeleton are two independent nodes with no parenting relationship. Without a sychronizer the only thing that allows the skeleton to follow the capsule is animation selection from motion matching. This can look good, but its often not enough and depending on the cases we need a way of sychronizing player capsule and skeleton. Depending on the approach you get different pros and cons:

Move the capsule to the skeleton's position: no foot sliding, but the character is harder to control for a player. At Naughty Dog they use this approach for AI character
Move the skeleton to the capsule's position: you get perfect controllability, but with foot sliding. This is the case that needs IK solutions the most


Flutter web: how can I run chrome on another machine?

I cannot find any way to get
flutter run -d chrome
work with a browser that runs in a machine other than the development machine. flutter always runs chrome on the local machine in this case. Is there any way I can make flutter use the chrome device but not start it immediately and wait for chrome to connect to running flutter?
Or probably more easier, can I tell flutter to use an already running chrome instance on another machine? Once chrome is running, all traffic between flutter and chrome must be taking place over the network, so if I could start chrome on another machine and set port redirecting, then I could use the command above so that flutter works with chrome running on another machine, even though it thinks it is running locally.
I'm using a development machine remotely but I want to run a local browser with support for debugging and hot reloading. I could get this running if I could convince  run -d chrome to not to start a local instance and assume one is already in place.

@serefarikan , as of now, your best option is to add --web-port=<custom_port> and setup port forwarding

Hi @serefarikan
You can't run on another machine but you can use the local port as mentioned above on different browsed,  including chrome that is outside the launch window and you can use the same port for mobile web on emulator
flutter run -d chrome --release  --web-hostname localhost --web-port 7357

Closing, as this isn't an issue with Flutter itself. If you disagree, please write in the comments and I will reopen it.
Thank you

Many thanks @TahaTesser I realised I forgot to mention I would like to debug with this configuration. I suspect the --release flag would not allow that? Or would debugging be possible with the run command you provided?

@serefarikan
flutter run -d chrome --debug  --web-hostname localhost --web-port 7357
you change to debug or profile, can add  --dart-define=FLUTTER_WEB_USE_SKIA=true too

@TahaTesser that's brilliant. Thanks a lot!


[Feature]: Add static files for maps

Feature type
New Feature
Description
Frontend will render maps using "tiled" maps. Make sure to add proper images related to maps

Outdated. Will move images to CDN server


feedback sm

[ ] make test specs on feedback state machine
[ ] make necessary classes for feedback state machine
[ ] pass all tests

Preparations for creating feedback state machine:

[ ] How to determine the start state of the feedback SM
[ ] how to define the first output of the feedback
[ ] How to handle 'undefined" feedback especially in the early phase of the feedback SM

[ ] Exercise 4.4
How could you use feedback and a negation primitive machine (which is a pure function that takes a Boolean and returns the negation of that Boolean) to make a machine whose output alternates between true and false.


x/tools/go/internal/gcimporter: TestBExportData_stdlib uses a lot of RAM

What version of Go are you using (go version)?

(master)mwhudson@ringil:/opt/opensource/gopath/src/golang.org/x/tools$ /snap/bin/go version
go version go1.12.9 linux/amd64

but it's similar with 1.11, 1.10 at least.
Does this issue reproduce with the latest release?
yes.
What operating system and processor architecture are you using (go env)?
go env Output
(master)mwhudson@ringil:/opt/opensource/gopath/src/golang.org/x/tools$ /snap/bin/go env
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/mwhudson/.cache/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/opt/opensource/gopath"
GOPROXY=""
GORACE=""
GOROOT="/snap/go/4301"
GOTMPDIR=""
GOTOOLDIR="/snap/go/4301/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build976150766=/tmp/go-build -gno-record-gcc-switches"

What did you do?
(master)mwhudson@ringil:/opt/opensource/gopath/src/golang.org/x/tools$ /snap/bin/go test -c ./go/internal/gcimporter/
(master)mwhudson@ringil:/opt/opensource/gopath/src/golang.org/x/tools$ /usr/bin/time ./gcimporter.test -test.v -test.run=TestBExportData_stdlib

What did you expect to see?
The test using a reasonable amount of memory.
What did you see instead?
=== RUN   TestBExportData_stdlib
haserrors/haserrors.go:2:22: cannot convert "" (untyped string constant) to untyped int
haserrors/haserrors.go:3:18: undeclared name: undefined
--- PASS: TestBExportData_stdlib (23.56s)
PASS
21.93user 17.20system 0:23.67elapsed 165%CPU (0avgtext+0avgdata 1263756maxresident)k
30276inputs+1880outputs (109major+593642minor)pagefaults 0swaps

That's a single testcase using about 1.2 GiB of RAM. This causes problems for Ubuntu because we run tests of all packages in VMs which by default have 1GiB of RAM. If the test cannot easily be reduced in footprint, maybe it should be skipped in -short mode?

/cc @ianthehat


Recommend against using Polari.

https://wiki.gnome.org/Apps/Polari
Why? The client tries to do things "different" and this creates confusion for both new and long time IRC users.
These are just some of the issues during my limited testing:
Cannot see mode changes in channel while you are in the channel. This includes bans/quiets/op/voice/whatever.
Does not show any numerics or messages. This includes 'user is +R', 'user is +g', you are banned/quieted/invite only channel, registered users only, and everything else. This makes it very difficult to figure out things.
Unidentified user tries to join a cmode +r channel, the channel window is created but the user is not actually in the channel. User will think they are actually in the channel.
Client "eats" the first # from channel names in the channel sidebar if the channel has two or more.
Cannot see /msg @#channel test while op.
/mode is a unknown command
/quote  is an unknown command, so you are effectively limited to using whatever is built into the IRC client.
/whois output is extremely lacking. /whois memoserv only shows User: Memo Services - Last activity: Unavailable
I used version 3.38 from https://packages.debian.org/bullseye/polari for this.

I think you're right that people should perhaps avoid this client, but we don't currently make any client recommendations beyond an intentionally limited list to get new people started. There wouldn't be a good place to put this kind of information, and I wouldn't want us to get in the business of expressing various strong opinions on various software.


Update package.json to point to build directory

Currently the package.json points to /source instead of /build. This can cause errors if you ignore node_modules within babel as you'll receive an error on a import statement.

thank you @codymorrison


Feature Request - Auto-complete for JSON Objects

JSON support in dbeaver is awesome.
It would be really nice if we could traverse a JSON tree as part of the auto-complete when writing a query.

Sounds interesting but I'm not quite understand how will it look.
Do you mean some database-specific queries?
And what is your database?

I'm connecting to a MySQL instance.
Today, a normal database auto-completion looks like this:

When writing JSON syntax, I need to write a query that might look something like this:
select t.id, t.features->>'$.models."PMUniversal-2_1".score' as score
from prod_com_sector9_acconfig_pilot_features t
where t.features->>'$.models."PMUniversal-2_1".score' is not null
It would be great for me to type:
select t.id, t.features  <<-- This is where dbeaver would realize that features is a JSON object and let me see the top-level notes of the features object (e.g., models).  Using my up and down mouse keys, I would traverse the top-level notes of the features object, and then using the right arrow, see a top level node's children (e.g., PMUniversal).  The up and down arrows would let me to continue traversing this (2nd level) tree, back arrow would take me back to the top node, and right arrow wold take me down one more element of the tree (if it existed).


Getting column name causing import error

Hi,
I try to import CSV data from a file into a Django DB. I've a column called "price" containing a floating point value. But this value has the "," as decimal separator which leads of course into an "<class 'decimal.ConversionSyntax'>" error. That's fine.
But I try to get the column name "price" causing this conversion error, but can't find it in the result of the "import_data()" function. I call "import_data()" like this:
        result = resource.import_data(
            dataset=dataset,
            dry_run=False,
            raise_errors=False,
            use_transactions=True,
            collect_failed_rows=True,
            rollback_on_validation_errors=True,
        )

Any idea how to get the column name?
Thank you!

The column name price will be in the dataset. e.g.
price = dataset["price"]

Does this help answer the question?

No no. What I mean: How can I get the column name causing the import error? The column name "price" was just an example, it could also be "foo" or anything else... The import failes because one column causes this problem. But which column?
Thank you!

You could inspect the Result object which is returned from the import_data() call.  Some more info here (although this documentation relates to the v4 beta release, the interface for v3 should be the same).

Well, of course I evaluate the result of "import_data()" according to the documentation and I can see the "ConversionSyntax" error. But where can I find the corresponding column name?

My best suggestion would be to set a breakpoint here and see which field throws the error.
We have an open issue to improve the error reporting.

Yes, I already found this line of code. But that's not the issue. I want to know it at runtime when the customer imports a CSV file. No debugger possible at this time... :-) The issue you mentioned goes exactly towards this problem.
Thanks a lot for your support!

If you are able to submit a PR for #1359 that would be appreciated.  We are planning our v4 release for the new year, so it could well go into that.
Or, if this is for a commercial venture, you could consider sponsoring development of the feature.

We added better support for identifying the underlying error here

Thank you very much! This seems to be very helpful!
Unfortunately the new "result.invalid_rows" element is empty, although there is an import error (wrong decimal separator; "," instead of "."). Therefore, there's also no "row.error.error_dict" containing the invalid field/column.

I'll take a look - are you are testing with the release-4 branch?

 I though it would be integrated in "https://pypi.org/project/django-import-export/3.3.6/".
My mistake, sorry for that! I'll re-test.

Ok, re-tested. And now I see...
In my case the "decimal.ConversionSyntax" error (because of the "," instead of the "." decimal separator; a frequently occuring user mistake) is saved in "row_result.errors" (ressources.py#932ff):
        if row_result.errors:
            result.append_error_row(i, row, row_result.errors)

And not in "row_result.validation_error" (ressources.py#940ff):
        elif row_result.validation_error:
            result.append_invalid_row(i, row, row_result.validation_error)

Therefore, in my case there's no benefit of the "invalid_rows" member with the interesting "error_dict" member where the field/column name causing the import error is located:
for row in result.invalid_rows:
print(f"--- row {row.number} ---")
for field, error in row.error.error_dict.items():
print(f"{field}: {error} ({row.values})
My bad luck. :-(

You could look at a custom widget to detect this error and raise ValueError, this should give you the column information because it would know which field caused the error.
You could try to pass the collect_failed_rows param.  This creates a new Dataset in the result, with the failed row and the errors appended.  However, I don't think this will give you any more information.
Let me know if this helps.

I already set "collect_failed_rows=True", which unfortunately doesn't help.
I wasn't aware of the "clean_modal_instance" feature, I'll give it a try.
Finally, the custom widget should help.
Thank you, I'll keep you informed.

Wow! The custom widget did the trick. Thank you!


error always log

Continue from saltyaom/kingworld#15
Question

import { KingWorld } from 'kingworld';

new KingWorld()
    .get('/', () => 'Hi')
    .get('/error', () => {
        throw new Error('test')
    })
    .onError(error => {
        console.log(error.name === 'test');
    })
    .listen(8080)

If you start the app and visit http://localhost:8080/error should only see "false" in the logs, instead I see this.
➜  bun-test git:(main) ✗ bun run ./src/index.ts
[0.09ms] ".env"
false
1 | import { KingWorld } from 'kingworld';
2 |
3 | new KingWorld()
4 |     .get('/', () => 'Hi')
5 |     .get('/error', () => {
6 |         throw new Error('test')
                  ^
error: test
      at /Users/xo/code/bun-test/src/index.ts:6:14
      at /Users/xo/code/bun-test/node_modules/kingworld/build/es/index.js:285:24
      at handle (/Users/xo/code/bun-test/node_modules/kingworld/build/es/index.js:220:17)

Answer

I understand that the all error log is annoying, tbh I also looking for a way to disable error logging.
From what I found, if an Error is thrown in the async function in Bun, it will always log an error, the bug is now reported and pending on Bun.
Please keep this issue until oven-sh/bun#1435 is fixed, to see if the issue still occurs.

Fixed with 0.1.0-rc.5

Hello SaltyAom!
Do you know if we still have this issue?
I am running bun 0.6.14 and Elysia latest and still getting the error logs - this way the onError does not work properly.
Thank you very much!

No worries here! For some reason, for a GET, I can put the onError after it, for a POST, worked well only when I put the onError before it. But it is working fine.


Static /31 address is force to use DHCP server

Important notices
Before you add a new report, we ask you kindly to acknowledge the following:

[ x ] I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
[ x ] I am convinced that my issue is new after having checked both open and closed issues at https://github.com/opnsense/core/issues?q=is%3Aissue

Describe the bug
I have another interface opt15 and this is a point-to-point link to another router. The subnet is /31. The issue now is the DHCP server was complaining that the range was wrong. I could not disable the DHCP server. The DHCP services has stopped at this point. I could not start it due to the problematic force DHCP service to the interface that does not need it.
Tip: to validate your setup was working with the previous version, use opnsense-revert (https://docs.opnsense.org/manual/opnsense_tools.html#opnsense-revert)
To Reproduce
Steps to reproduce the behavior:

Add a new VLAN interface
Enabled the VLAN interface
Give the VLAN interface a static IP with a /31 mask
Go to DHCP server and disable the DHCP server

Expected behavior
I should be able to disable the DHCP server for this interface.
Describe alternatives you considered
The DHCP server should be optional. Not all interface need to be a DHCP server for every subnets.
Screenshots
N/A
Relevant log files
N/A
Additional context
N/A
Environment
N/A
OPNsense 23.7.10_1-amd64
FreeBSD 13.2-RELEASE-p7
OpenSSL 1.1.1w

I’m wondering why it would be enabled in the first place unless it’s a leftover from another interface. I mean you clearly did not want it or it even makes sense. 😉
I need to double check if unassign deletes the DHCP server but I would think it does which only leaves switching interfaces which leaves DHCP running on purpose?
Cheers,
Franco

The assignment part is as I mentioned, but I've added c2f7998 to be able to disable a server with an invalid range.
# opnsense-patch c2f7998

Cheers,
Franco


Tab border color doesn't change when installing custom themes

Even though the custom theme has a yellow tab border color, the tab border color does not change when the theme is applied.

How it should be
How it appears

Firefox Dev 127.0b3
userChrome.Style.ThirdParty.Enabled
userChrome.Tabs.Option2.Enabled
userChrome.LightTheme.Tabs.Borders.Enabled
userChrome.DarkTheme.Tabs.Borders.Enabled

I'm going to change the way tab borders are handled in v1.6.127. The old method is quite complicated, inflexible and does not work with translucent surfaces. This can be bypassed, but then there will be problems with compatibility with some themes from AMO. Just enable the key userChrome.Tabs.SelectedTabIndicator.Enabled.

Could you please tell if in the future it will be possible to show the selected tab indicator as a border like in the original Firefox theme?

This is not easy to do and will require a lot of compromises. Most likely I won't even try.

I made shadows compatible with AMO themes. As much as possible, given the limitations. Should work starting with v1.7.131.


add computed property name support for template inputs

Clear and concise description of the problem
Would like to be able to set the name for a property through template input, repo here
Checklist

[X] Follow our Code of Conduct
[X] Read the docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

Note:  augment decorator usage would be problematic / impossible


refactor(submodules): Use git submodules

https://github.com/TOSIT-IO/tdp-getting-started/issues/117

Fixes #117
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004 and that you give permission to TOSIT,
you have to acknowledge this by using the following check-box.

[x] I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
[x] I hereby agree to grant TOSIT a copyright license to use my contributions.

@pm-McFly thank you for your contribution to TDP!
In a fully open-source approach, all Issues/Pull Requests are fairly examined for integration.
A review process is in progress in order to validate this PR before merging to master branch. We will keep you updated as soon as possible.
Thank you again for your contribution to TDP.

@pm-McFly , this PR has been reviewed and some of its chenges will soon be taken into account into a big refactoring of the tdp-getting-started project.
Please note that some changes could be made for better integration.
Thank you again for your contribution to TDP.

I will merge this into refactor branch. It is a good start to use git submodule for the refactor.
Thank you again for your contribution to TDP.


Jack/update documentation

Updated:

Added back support document types for partitioning
Added more tabs for python code in the API page
Added a RAG section in Key Concepts
Added a Common Use case section in overview

i think we're due for a release, especially with the element ordering change with fast + hi_res strategies for images and PDF's.
may as well make this a release? (remove -devX from the top line of the changelog, edit unstructured/version.py to be consistent)

Looks like a markdown format issue for one row:


Implement MCM endpoints

Do you want to request a feature or report a bug?
feature
What is the current behavior?
the methods at MultiClusters API Client are not available on the JS api client
What is the expected behavior?

API Method
Description
JavaScript name

Assign or Move userID
Assign or Move a userID to a cluster
assignUserID

Get top userID
Get userID with highest number of records per cluster
getTopUserID

Get userID
Returns the userID data stored in the mapping
getUserID

List clusters
List the clusters available in a multi-clusters setup for a single appID
listClusters

List userID
List the userIDs assigned to a multi-clusters appID
listUserIDs

Remove userID
Remove a userID and associated data from the multi-clusters
removeUserID

Search userID
Search for userIDs
searchUserIDs

closed in #643

GG


[iOS] Open License Page from AboutView

Issue

close #429

Overview (Required)

Open License page from AboutView
I used LicenseList library because LicensePlist cannot generate SPM dependencies. (ref)

I wrote package plugin of LicenseList, but it's not officially supported by LicenseList. I'm offering support in https://github.com/cybozu/LicenseList/issues/4

For reviewer

I implemented navigations only by standard library, but I'm not sure it is good way.

I also found this library. https://github.com/johnpatrickmorgan/TCACoordinators
Honestly, I want to use NavigationStack 😂

Links

Nothing

Screenshot
https://user-images.githubusercontent.com/465697/190327609-da0ebee6-08b6-454e-9088-9d91c018aa81.mp4

How about adding app-ios/Sources/AboutFeature/license-list.plist file to .gitignore ?

I understand and agree, but LicenseList program cannot generate file properly without template file.
I'll try to generate template file in plugin code 👍

I tried it. But It seems that Xcode cannot recognize the file generated during plugin execution phase that didn't exist originally.
So if we run the code, app crash only at first time.
Anyone does have some solutions of this?

Hmm...
It's okey! Let's try with another issue or PR :pray:


you can click or flag squares after you click mine or win the game

Arrinao introduced this bug in cf51d48. I'm quite sure I told him about it at least 3 times before he did that commit.
<Akuli> why do you keep writing "if self.game_status.in_progress"
<Akuli> it just does not make any sense
<Akuli> please, don't write that
<Akuli> if you want to check if the status is something, then do that
<Akuli> if self.game_status == GameStatus.in_progress
<Akuli> you need to use == if you want to check if the status is same as whatever status you want to check it to be
<Akuli> aaaaaaaaaaaaaaa

Fixed

Fixed


Why no-inner-html rule (noInnerHtmlRule) is marked as typescriptOnly?

Hi, I'm wondering why most of the rules and noInnerHtmlRule specifically are not available for JavaScript. Is this because of some technical issue (e.g. incompatible AST, API or missing utils) or is that the policy of the company?

Hi @schubar-tibco! In short, we can't get full type intelligence without a tsconfig.json.
Rules that are marked as typescriptOnly are ones that require use of TypeScript's compiler program APIs to inspect static types, which requires the existence of a TypeScript project. See https://palantir.github.io/tslint/usage/type-checking/ for a bit more info.
It's certainly not a policy of the company, we'd very much like to have these be as easy as possible 😊.


Telling and titles for dialog

tell application "Brave Browser" to display dialog "Some Message from Brave" with title "A title"

This will show a dialog with a title at the top, and move focus to Brave Browser.
If you tell application then display an alert, it will show Brave's icon.
But showing a notification after tell will not change the notification's icon, unfortunately.

Titles have been added. As for telling, it'll be nice if something like with Tell("Application Name"): can be done


Prevent vaccine waste by notifying vaccination volunteers

Feature description
Prevent vaccine waste by notifying vaccination volunteers

Users can agree to receive a notification if vaccine needs to be used up.

Vaccination centers can enter the quantity and expiration period via their account.

The system uses a bit of IT voodoo to determine the next vaccination volunteers. They then have X amount of time to respond. According to the principle of first come, first serve, those who have responded the fastest get the commitments. In the confirmation you will find the address, OTP and the deadline for the vaccinated person to come to the center. Otherwise the next request will be sent out.

Problem and motivation
Once prepared, the COVID-19 vaccine has a shelf life of only a few hours and must be administered during this period.
If no vaccine candidate is found, the vaccine is discarded.
Even with the very first COVID-19 vaccination in Germany, 7 vaccine doses remained at the end of the day.
Fortunately, people willing to vaccinate could be found quickly from the vaccination team.
Currently, for example, surrounding hospitals and their staff are also supplied with the surplus vaccine.
However, it is foreseeable that additional persons willing to vaccinate spontaneously will be needed to avoid disposal of the vaccine.
This is where a reporting function in the Corona app would be helpful as a vaccinator.
Currently, I am trying to establish contacts with vaccination centers and public health departments in NRW to get a public position on the procedure with leftover vaccine doses.
However, my research so far shows that in every case vaccine doses have been left over, but then distributed to employees of care facilities and surrounding hospitals. However, this resource of vaccination volunteers is limited. (All my friends in this area have already been vaccinated). I am trying to get some numbers and relevant Statistics to this.

Is this something you're interested in working on
I wont' be able to code, as this is an ASAP Feature and i am not familiar with mobile dev. But i will in support in Product Owning and PM

Internal Tracking ID: EXPOSUREAPP-3429

@manuliner
It sounds like your proposal would need to know the user's location in order to be effective, however the Corona-Warn-App does not know the device's location and is forbidden to use it. (See for instance https://www.coronawarn.app/assets/documents/cwa-privacy-notice-en.pdf Section 5). Did I understand your proposal correctly?
"The app’s entire system has been programmed to process as little personal data as possible. This means that, when you use exposure logging, warn other users, or retrieve a test result, the system does not collect any data that would allow the RKI or other users to infer your identity, your name, your location or other personal details."
The organisation of vaccinations is being handled by each State according to the information on https://www.zusammengegencorona.de/. I'm not in NRW, so I'm not following how it is being done there. I do know though that in Bavaria, where I am located, that anybody can sign up with an account on http://impfzentren.bayern/ to be informed by e-mail / SMS when they can come to be vaccinated. It asks a lot of questions starting with your date-of-birth, medical conditions, including your environment (such as the type of work you do, if applicable, etc.). It uses all that information to prioritise the order of appointments. A system like that could perhaps be extended to offer short-term vaccination appointments.

@manuliner
It sounds like your proposal would need to know the user's location in order to be effective, however the Corona-Warn-App does not know the device's location and is forbidden to use it. (See for instance https://www.coronawarn.app/assets/documents/cwa-privacy-notice-en.pdf Section 5). Did I understand your proposal correctly?
"The app’s entire system has been programmed to process as little personal data as possible. This means that, when you use exposure logging, warn other users, or retrieve a test result, the system does not collect any data that would allow the RKI or other users to infer your identity, your name, your location or other personal details."
The organisation of vaccinations is being handled by each State according to the information on https://www.zusammengegencorona.de/. I'm not in NRW, so I'm not following how it is being done there. I do know though that in Bavaria, where I am located, that anybody can sign up with an account on http://impfzentren.bayern/ to be informed by e-mail / SMS when they can come to be vaccinated. It asks a lot of questions starting with your date-of-birth, medical conditions, including your environment (such as the type of work you do, if applicable, etc.). It uses all that information to prioritise the order of appointments. A system like that could perhaps be extended to offer short-term vaccination appointments.

Yes there will be a need for a rough location ( city would be enough, to determine the next "Impfzentrum"). So probably  CWA will be not the right place for this functionality.
@MikeMcC399  thank you for the Input. I am already contacting all Vaccaination Administration regarding this issue. There is no need to develop a new Application for this, as long as the State has one already running. But they should consider this Feature to solve the Issue. I mean, even if the automatically inform already registered People over there Database, that an short term appointment will be availible, would make a huge difference.
As is did found out yesterday, in Rheinland Pfalz they where forced to throw 228 Vaccinces into the rubbish, since 27.12.2020
https://www.rheinpfalz.de/lokal/kreis-germersheim_artikel,-impfzentrum-wörth-noch-keine-impfdosis-weggeworfen-_arid,5158876.html?reduced=true

Yes there will be a need for a rough location ( city would be enough, to determine the next "Impfzentrum"). So probably  CWA will be not the right place for this functionality.
@MikeMcC399  thank you for the Input. I am already contacting all Vaccaination Administration regarding this issue. There is no need to develop a new Application for this, as long as the State has one already running. But they should consider this Feature to solve the Issue. I mean, even if the automatically inform already registered People over there Database, that an short term appointment will be availible, would make a huge difference.
As is did found out yesterday, in Rheinland Pfalz they where forced to throw 228 Vaccinces into the rubbish, since 27.12.2020
https://www.rheinpfalz.de/lokal/kreis-germersheim_artikel,-impfzentrum-wörth-noch-keine-impfdosis-weggeworfen-_arid,5158876.html?reduced=true

Is there now a solution for this problem for interested doctors? The inefficient communication for appointments is still a problem in Germany, anecdotal evidence: https://twitter.com/hodisplace/status/1461656270629482501

Yes after @MikeMcC399  answer we started www.impfbruecke.de to support official vaccination centres nearly free of charge. Later there where others which made an approach for doctors www.sofortimpfen.de. We didn't serve doctors with impfbrücke due the realy high ammount of customer support. So basically it is an money problem. Most doctors who where needing an appointment system can actually get them at calendly, doctolib and jameda. But they don't want to pay for it. Impfbrücke and sofortimpfen where services who ran on really low budget.  After this budget was used we are not able to provide this service anymore.  If you take money to keep it running, no one will use it.
I still believe cwa would be the best place for a "centralised"  appointment system. And there are ways to do it. Sofort Impfen has proven it.
At the moment we are thinking about collecting money to start impfbruecke again but it would be nicer to use this money to implement this kind of functionality in cwa.
Open API for every appointment system as jameda,  doctolib and the official ones to use cwa as an appointment finder in your surrounding area
If someone at cwa is willing to think about a approach impfbrücke will be happy to support with the experience of the last year in this field. An I believe that the persons from sofortimpfen will be in board as well

Is Impfbrücke open-source software? What services need to be paid to get it running?

currently Impfbruecke is not opensource, but i am willingly to do change it but i must discuss this topic with the other teammembers.
sofort-impfen is opensource (https://github.com/kiebitz-oss/)
Technical Services:

As Impfbrucke  is an service using SMS the cost of theses needs to be covered ( apporx 0,70€ to 5 € per appointment, depending on the database).
Servers

Human Services:

During the vaccination campaign this year the management of all the vaccination centers and bugfixing was a fulltime job for 3 People.


Bump Pydantic version to 2.x

Pydantic released their 2.x version earlier last month, which is causing a little bit of issues when trying to use permit on projects that already use the new version, namely with fastapi.
Would it be possible to bump the requirements to update pydantic to >= 2.0? They offer an easy way to use it with the new 2.x branch, according to their docs:
The Pydantic V2 package also continues to provide access to the Pydantic V1 API by importing through pydantic.v1. For example, you can use the BaseModel class from Pydantic V1 instead of the Pydantic V2 pydantic.BaseModel class:
from pydantic.v1 import BaseModel

hi @tr11, thanks for opening this issue, we are looking into a solution!
Just FYI, the suggested solution won't work because it forces the users of the permit library to upgrade pydantic to v2.
They might not be able to, because a migration might be quite difficult depending on the project.
What we'll do is either build a cross compat layer or remove pydantic altogether from this SDK.


feat(internal): add docs generation command

Description
Adds cobra cli documentation generation command under a new internal command
Intending to add good first issues to update command documentation natively in the code for propagation to generated cli docs.
Related Issue
Resolves #605
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Other (security config, docs update, etc)

Checklist before merging

[x] Test, docs, adr added or updated as needed
[x] Schema Updates applied
[x] Contributor Guide Steps followed

Looks like some of the information contained in some of the cli docs (thinking specifically like evaluate.md) may have been lost. Should we take some of this info and perhaps move to oscal/assessment-results.md? Some of these synopses are also pretty sparse, may want to add some follow-on issues to be a bit more verbose about particularly generate, validate, and evaluate

Agree that the aperture on cli documentation was quite wide initially. Will review some of that lost info and port it over if there are no other big items that stand out.
Otherwise this puts in motion more incentive to have better help messages and creating more issues was the intent of my mention of good first issue's

I noticed the assess.md doc was removed but not re-added as lula_assess.md
Is that because lula assess dosen't exist yet? I don't have any reservations for removing or keeping it, just curious.

Correct! All generation is driven from cobra cli code. Optimally the target directory is entirely driven by automatic docs generation and so I opted not to re-include it.


docs: Provide Azure Data Explorer Scaler

Signed-off-by: Yarden Siboni<EMAIL_ADDRESS>This is the documentation for an Azure Data Explorer scaler. This is related to this issue:
https://github.com/kedacore/keda/issues/1488
Checklist

[x] Commits are signed with Developer Certificate of Origin (DCO)

Fixes #1488

Just a few last alignments but LGTM for the rest

Closed by mistake


SCAN  and KEYS missing from API ?

I am trying to retrieve all keys on Redis but I don't see in the API an option to use
SCAN "" nor KEYS *.
I assume that KEYS * is not present for performance issue but scan is pretty much needed to search through records. Perhaps I am missing something ?

it seems that the function scan exist but is not documented (https://ibm-swift.github.io/Kitura-redis/Classes/Redis.html) can someone please consider add it as an example in the readme?  Examples of edit records and delete would also be necessary to have a complete overview.


Creating / Editing / Showing statute paragraph amendments [WIP]

A very basic first implementation of the specification for the statute paragraphs:

If statute paragraphs are defined: When creating a motion, a checkbox appears to set this motion as a statute paragraph amendment. If the checkbox is activated, a SELECT appears, allowing to select the paragraph. If one is selected, the title and text below are pre-filled.
After creating the statute amendment, the amendment is shown in simple diff view.

Questions for potential enhancements would be:

Do statute amendments have line numbering? Or does the statute in itself have line numbers, for that matter? (If so, it would probably have to be continuous along the different paragraph objects)
What views does such an amendment have? Diff, obviously. But also the "changed" view?
How to handle the workflows? I'd be glad if that could be implemented by someone else, as I'm not very familiar with them.

What is the use case if you de-select the "Statute amendment" checkbox from an existing statute amendment motion? It seems like it was converted into a normal motion.

That would be up to discussion, if changing the statute paragraph afterwards should be supported. It sounds reasonable to just not provide this functionality alltogether.

Furthermore, using this feature seems to substitute the while motion text with the text defied in the Statute paragraphs. Is this intended?

As far as I know, that was in the original specification that I got for this feature. @emanuelschuetze can probably clarify.

As for the config variables:

motions_amendments_enabled: Ok, is done.
motions_amendments_prefix: Hm, not sure here. Do statute amendments have the same prefixes and numbering system as regular amendments?
motions_amendments_text_mode: Not sure here either, especially as the values from that variables do not really match the logic of statute amendments, esp. "Edit the whole motion text" and "Paragraph-based, Diff-enabled". "Empty text field" might be possible to implement, but then again, what would be the point of selecting a statute paragraph in the first place? :)

Instead of motions_amendments_enabled, the new variable motions_statutes_enabled is now used. It's currently in motions -> general, and I had to rebuild my database (configstore) for it to work.

@tsiegleauq Please review and merge!


Update lodash ? (Low vulnerability)

Hi Can fix this ?
https://nodesecurity.io/advisories/577
Current version of jshint use lodash 3.7.x
Thanks in advance.
Regards

@mroberty8, looks like @jugglinmike already fixed it hasn't been released. I'm actually checking this project every morning, waiting for it 🙂

Soon! Closing this as a duplicate of gh-3257


How to use the config component with Silex

What's the best way to wire the symfony config component with the silex application?

My attempt at doing it is http://github.com/flint/tacker

// src/MyApp/AppKernel.php

class AppKernel extends Kernel{
   //...
    public function registerContainerConfiguration(LoaderInterface $loader)
    {
        $loader->load($this->rootDir.'/app/config/app_'.$this->getEnvironment().'.php');
    }
}

// public/index.php

$app = new Silex\Application();

$kernel = new AppKernel("dev", false);

$app->run();

How can i attach the Kernel to the Silex application to make it load my specific configuration!

You cannot, the AppKernel uses the DependencyInjection component, so it is not possible to just add all those services to pimple. If you just want the AppKernel to be accessible then you could just add it like so:
<?php

$kernel = new AppKernel('dev', false);

$app = new Silex\Application['app_kernel' => $kernel]);
$app->run();

Do you know where the registerContainerConfiguration is called?

I assume it is called in the boot method or something, isnt that hard to look up with a search on github or in the class.
This is not really a support forum.


Any clue what could cause that?


Enable opening of an existential var

Perform appropriate lvalue adjustments when opening a var of existential type.
Fixes rdar://95874158. Thank you to @johnno1962 for doing 99% of the work here.

@swift-ci please smoke test

macOS failure looks totally unrelated. Trying again...

@swift-ci please smoke test macOS

@swift-ci please clean smoke test macOS

Thanks for picking this up @DougGregor, checks out this end 👍

@swift-ci please clean smoke test macOS

@swift-ci please clean smoke test macOS

@swift-ci please clean smoke test macOS

@swift-ci please clean smoke test macOS

https://github.com/apple/swift-driver/pull/1140
@swift-ci please smoke test macOS


Removing text from compare page

The subheadline of this page: https://www.cockroachlabs.com/docs/stable/cockroachdb-in-comparison.html# indicates you can click on feature but you can't.
It would be great if we could remove the text that says: and click CockroachDB answers to view related documentation.

@jseldess can i work on this issue? :)

@olgaromashko, sure. Please be sure to update the page in both the v20.2 and v21.1 directories.

@jseldess I opened a PR, if anything needs to be edited, let me know :)


Azure Static Web App Configuration App Settings doesn't work

Describe the bug
Adding app settings values to the static web app doesnt overwrite the app settings value for the deployed environments.
To Reproduce
Steps to reproduce the behavior:

Create App Settings Value in .env file for VueJS application
Use import.meta.env throughout the VueJs application to access the environment variable
Add the created app settings value to the azure static web app application settings for deployed environment
Modify the value to be different (example: different database connection string)
Click Save
The app settings value in the deployed application is not affected by how it is defined in the azure static web app configuration section (even after a new release)

Expected behavior
value entered in azure static web app application settings should override what is defined in the .env file
Screenshots

You have to remember that vite is a build tool, not a run time.
Therefore variables that you set at runtime will take no effect, since the variables will have already been replaced as strings in your app at buildtime.
https://vitejs.dev/guide/env-and-mode.html#production-replacement

Hey @wengera  I am facing a similar issue, were you able to find a workaround?

I have searched everywhere for a solution but nothing seems to work. This is extremely frustrating.

I have searched everywhere for a solution but nothing seems to work. This is extremely frustrating.

Please read my response.

Yes thank you for this it makes sense now

@markcouvaras, that's correct, because we don't hide the build process (you can use GitHub Actions, Azure DevOps pipelines, etc.), you must configure this yourself

@markcouvaras, that's correct, because we don't hide the build process (you can use GitHub Actions, Azure DevOps pipelines, etc.), you must configure this yourself

Would be great if the build process was able to pull the env variables out of the Azure SWXA config though.


Update date/time picker widgets to use template-based rendering.

This allows us to reuse a single template for all three widgets (date, time, datetime).

The only pending thing - release notes update.

I've added to the release notes. Also removed a duplicated line that must have appeared during merge.


ENH: updating remote modules

PR Checklist

[X] :no_entry_sign: Makes breaking changes
[X] :no_entry_sign: Makes design changes
[X] :no_entry_sign: Adds the License notice to new files.
[X] :no_entry_sign: Adds Python wrapping.
[X] :no_entry_sign: Adds tests and baseline comparison (quantitative).
[X] :no_entry_sign: Adds test data.
[X] :no_entry_sign: Adds Examples to ITKExamples
[X] :no_entry_sign: Adds Documentation.

Refer to the ITK Software Guide for
further development details if necessary.

We added backwards-compatible testing macros without ITK_ prefix under legacy. So all the remotes should be working with common configuration options.

It is now easy to run the script UpdateRemoteModules.sh. My motivation was these outdated warnings in Montage module. Whenever some improvement is made in remote modules, the script could be run and PR created.


Error in global md 🙂😥

Hello qasim nice work on global md ..but I'm stuck in the big world of error requiring module node js not found in file ..but global bug ..is so straight forward ..no single eror s at all 😍😎..if you can message me here lemme show you the error logs on whatsapp ..i will be happy brr, qasim Ali<PHONE_NUMBER>474 ....noted !

ok, brother I'm on it and trying to resolve all errors, don't worry, let me finish debugging first then I'll let you know that now it can be deployed

Okay brotha ..


[Feature Request] - dotsStyle prop

Could we also add a dotsStyle to overwrite the default dots style?

The ability to pass a component to be used for the dots, receiving indexes and other suitable data as props (like it's possible with the arrows), would also be great.

You can use customPaging  option to style the dots according to your requirement.
Check this example
https://github.com/akiran/react-slick/blob/master/examples/CustomPaging.js

Wow, I overlooked that! Thanks!


Window Position

I wanted to place my window near to tray. How do I do that?
new BrowserWindow({width: 800, height: 600});

I think you can use x, y positions in the options. or use BrowserWindow.setPosition(x, y) API.

I think he's asking how to know where the tray IS (it's not always bottom-right) - I suspect the answer to that is "you can't" - certainly it will be a bespoke thing for Windows (normally bottom-right), Linux (normally top) and OSX (always top?)
Even if you assume it is always in the same place (based on the OS) you then need to know how wide/high the screen is for "for right or bottom-right position)
I can't find any way to detect screen size in "main.js" but you can within a browserwindow so you'll need to create a window (set to not show), open it - it's code can then move it to where it should be and then show it (via remote.getCurrentScreen()....) and voila...

@shrewdlogarithm Please describe your problem with using screen from browser-side?
I have no problem with 0.21.2 on win32.
var app = require('app');
app.on('ready', function() {
  var atomScreen = require('screen');
  console.log(atomScreen.getAllDisplays());
});

I don't have a problem - I said I didn't know how to do it
Also - why do people call main.js "browser side" when it's actually "node side" surely?
"browser side" is inside browserwindow surely?

That's the renderer-side...
Yeah, those names can definitely get confusing (althogh they do make sense). If we had better distinguishable (new) names and a majority of people we're using those it would be good.
But currently I'll stick to the official names (from the docs), this way it is defined what you meant and not open to interpretation what the "browser" is.
Sorry for going off-topic on this...

There is no reliable way to get position of Tray icon on all platforms, so I don't think we will have support for this.


[To Main] Tenant CRUD implementation

Issue #: https://apps.itsm.gov.bc.ca/jira/browse/DESENG-605
Issue #: https://apps.itsm.gov.bc.ca/jira/browse/DESENG-606
Description of changes:

Feature Finish tenant management UX

Added a new tenant detail page
Added a form for filling out tenant details
Added a new tenant creation page
Added a new tenant edit page

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the met-public license (Apache 2.0).

Codecov Report
Attention: Patch coverage is 80.50459% with 85 lines in your changes are missing coverage. Please review.

Project coverage is 75.96%. Comparing base (3acdbcd) to head (db22915).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2524      +/-   ##
==========================================
+ Coverage   75.81%   75.96%   +0.14%
==========================================
  Files         597      617      +20
  Lines       21432    21968     +536
  Branches     1575     1686     +111
==========================================
+ Hits        16249    16687     +438
- Misses       4926     5017      +91
- Partials      257      264       +7

Flag
Coverage Δ

metweb
64.73% <80.50%> (+0.84%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files
Coverage Δ

met-api/src/met_api/models/tenant.py
100.00% <ø> (ø)

met-api/src/met_api/resources/tenant.py
84.84% <ø> (-0.87%)
:arrow_down:

met-api/src/met_api/schemas/tenant.py
100.00% <ø> (ø)

met-api/src/met_api/services/tenant_service.py
80.95% <ø> (+5.95%)
:arrow_up:

met-web/src/apiManager/endpoints/index.ts
100.00% <ø> (ø)

met-web/src/components/common/Input/FormField.tsx
100.00% <100.00%> (ø)

met-web/src/components/common/Input/TextInput.tsx
100.00% <100.00%> (ø)

met-web/src/components/common/Input/index.tsx
100.00% <100.00%> (ø)

met-web/src/components/common/Layout/index.tsx
81.81% <100.00%> (ø)

...eb/src/components/common/Navigation/Breadcrumb.tsx
100.00% <100.00%> (ø)

... and 16 more

... and 5 files with indirect coverage changes


Merge master into release

I need to update the debugger packages one more time before we are ready. Builds are inflight now.

Sounds good.

When you update the debugger packages, do you want to just update them in the release branch? I'll be merging release back into master once 1.8 ships.

Will do


Volatility weighting NB seems to fail

--------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
<ipython-input-6-3ab88e0b88b5> in <module>()
      2                                                                        weight_function=np.std,
      3                                                                        weight_function_window=126,
----> 4                                                                        inverse_weight=True
      5                                                                       )
      6 to_plot = ['SPY', 'GLD', 'FXE'] + ["port_ret"]

/home/wiecki/working/projects/quant/pyfolio/pyfolio/timeseries.py in portfolio_returns_metric_weighted(holdings_returns, exclude_non_overlapping, weight_function, weight_function_window, inverse_weight, portfolio_rebalance_rule, weight_func_transform)
   1251             holdings_df_weights = holdings_df[transform_columns] / \
   1252                 holdings_df[transform_columns].sum(axis=1)
-> 1253         holdings_df_weights.columns = holdings_cols
   1254         holdings_df = holdings_df.join(holdings_df_weights, rsuffix='_w')
   1255         holdings_df_weighted_rets = np.multiply(

/home/wiecki/miniconda3/lib/python3.4/site-packages/pandas/core/generic.py in __setattr__(self, name, value)
   2255         try:
   2256             object.__getattribute__(self, name)
-> 2257             return object.__setattr__(self, name, value)
   2258         except AttributeError:
   2259             pass

pandas/src/properties.pyx in pandas.lib.AxisProperty.__set__ (pandas/lib.c:44611)()

/home/wiecki/miniconda3/lib/python3.4/site-packages/pandas/core/generic.py in _set_axis(self, axis, labels)
    422
    423     def _set_axis(self, axis, labels):
--> 424         self._data.set_axis(axis, labels)
    425         self._clear_item_cache()
    426

/home/wiecki/miniconda3/lib/python3.4/site-packages/pandas/core/internals.py in set_axis(self, axis, new_labels)
   2458         if new_len != old_len:
   2459             raise ValueError('Length mismatch: Expected axis has %d elements, '
-> 2460                              'new values have %d elements' % (old_len, new_len))
   2461
   2462         self.axes[axis] = new_labels

ValueError: Length mismatch: Expected axis has 2342 elements, new values have 3 elements

This is working for me on my local branch.  are you trying on Master?  any package updates that you've done (like the new pandas?) that may be causing it?  i'm still on this pandas:

I'm on 0.17.0 which might be the issue. Can you try upgrading and see if you can reproduce that way?

cool, yea., I'll clone my current virtual env, and then just update to pandas 0.17.0 to try and isolate it to pandas

(but i probably won't get to trying this untill later today in the afternoon as I have some meetings in the morning)

confirmed. It fails on me when upgrading to pandas 0.17.0. ohhh pandas and how you consistently break backcompat... ;)
i think they messed around with how indexes should be set in this new release. let me see if its a quick fix

Related: https://github.com/pydata/pandas/issues/11336

@twiecki PR for your review
https://github.com/quantopian/pyfolio/pull/173

http://pandas.pydata.org/pandas-docs/stable/whatsnew.html#removal-of-prior-version-deprecations-changes


About MultiNet

Hi Marvin
MultiNet is a very amazing job, will you have some plans to release the codes?
Or could I do some contribution based on your codes?
Looking forward to your replay!

Hi lbin,
I am glad that you like my project. I am on it ;). KittiSeg and KittiBox are submodules of MultiNet. Releasing those repositories over the last couple of weeks were first steps towards releasing MultiNet. Providing scripts and docu to make code easily useable takes some time unfurtionatly.

Thanks for your reply. Be willing to help anytime:)

@lbin, the multinet code is now public and can be found here.

Thanks for reminding me, I will try it ASAP!