Couple of questions for bindings

Hi, I found your xtouch project while googling. I'm going to assume it's all python3, correct?

alternate_event_up - is that the layer B?
not sure what a trigger is
do you have the slider/fader working as well? Not sure that's even doable through simconnect.

I wonder if it could be mapped to https://github.com/odwdinc/Python-SimConnect/blob/master/SimConnect/EventList.py#L103

alternate_event_up - is that the layer B?

To use layer b just continue numbering up the indexes. So encoder with index 9 should be the first encoder on layer B.
There are some challenges with the LED feedback, because the x-touch does not send a message when you switch layers. I only see it when you press a button/ rotate an encoder. that's the reason for activelayer.py.

not sure what a trigger is

Regarding alternate event up and triggers, I'll explain how encoder 5 and encoder 6 works in my config file.
Encoder 5 by default controls the SPD parameter of the autopilot (generally used for FLC), but when the AUTOPILOT_VERTICAL_HOLD is activated (VS) it switches automatically to control vertical speed. Basically AUTOPILOT_VERTICAL_HOLD triggers encoder 5 to alternate mode.
Encoder 6 controls the nav frequency, first it controls the whole digits, when you press the encoder it switches to the fractional digits and when you long press it swaps the frequency.

do you have the slider/fader working as well?

Not yet, but I should be able to add that fairly easily. And then it can be mapped to any of the simevents that require a value

I'm going to assume it's all python3, correct?
Yes, that's correct

Thank you, I'll give it a got later.

Just added support for the fader, it's in the main branch.
Also added some details about the encoder configuration through the x-touch editor, which is important to do. Otherwise the software will behave very strange

Wow that was quick, I'll fork the repo and send a readme PR back. I've only used python on Mac and Linux so far, I'll make note of the steps.

Thanks, that worked quite well. Biggest hurdle was windows actually. (images for github hosting, see PR)


insolvency-data-api tech debt

Replace Companies House Parent version to 2.1.6
Upgrade Spring Boot Version to at least 3.3.0
Make sure the Jib plugin docker images are correct
Implement the new vulnerability suppression method

Jira: JU-523

CI: Security warnings found!

CI: No security warnings found

CI: Security warnings found!

CI: Security warnings found!

CI: No security warnings found

CI: Security warnings found!

CI: Security warnings found!

CI: No security warnings found

CI: No security warnings found


⚠ Bofrost.lu has degraded performance

In 0089fd6, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1602 ms

Resolved: Bofrost.lu performance has improved in 7271c28 after 13 minutes.


Improve bookmark button accessibility

Issue

close #462

Overview (Required)

Use IconToggleButton instead of IconButton for the Check state.
Added accessibility statements based on whether or not to add a bookmark.

Links

None

Record
Before
https://github.com/DroidKaigi/conference-app-2023/assets/1534926/3eaa8fac-b877-41e7-b7d0-9c7172ccabbd
After
https://github.com/DroidKaigi/conference-app-2023/assets/1534926/3be43433-92c3-4f9d-879e-ee0be39f6195

The icon color looks changed. Looks good though. Is there any opinion about this? 👀

@takahirom Oh!! My mistake.
I just realized this is different from the Figma design.
I'll make sure to expose it with the existing colors.

@takahirom I used the same Color value for the IconToggleButton as in Figma.
Figma

Preview


Update auth docs

LGTM

I might have missed it, but looks like we don't have a section anymore which lists all the available backends.
Imo, we should have such section. At the very least, it should include short backend description and link to the corresponding github repo with readme.

LGTM please merge.

@Kami, there's a link included that will filter to all the st2-auth repos.  But I can add a section that list links for a few examples.  I just don't want to keep updating this file everytime we add a new auth plugin. @dzimine, Also, I just realize we're missing a CLI section here, I probably accidentally deleted it. So I'll fix before merge.

Accidentally closed this PR... lame...


Nothing Updating

Hi, I don't know if this problem is a tileboard specific problem, but when I hosted the files directly on my home assistant server (raspberry pi), I could not edit those files again. The edits I made would not be reflected when i visited xxx.duckdns.org/local/index.html. This stayed true to all of my other files that I had hosted through the local www directory. For example, I had an mp3 file that I hosted. Upon deletion, I could still access it through .../local/xxx.mp3. In fact, I deleted this projects contents, and to this day its still on my server. For whatever reason I cannot edit the files to my liking which renders this project useless for me. The only thing I've tried is deleting the database file. If you have any other suggestions please help me out.
Thanks,
Aravind

Sounds like the files are cached in your browser. Clear the cache and try again.

Thanks a million! This had me quite frustrated!


Tuning the behavior of teb planner for tricycle kinematics with front steering and drive

I'm trying to use the teb local planner for a tricycle robot with a front steered wheel. The front wheel is also the driven wheel. I am noticing a lot of rapid oscillations in the steering angle. I believe this could be because the horizon of the model predictive control is 1, i.e., it is re-computing a plan at every control iteration.
Would planning behavior improve if N velocity controls were taken before re-computing the plan? Is this a settable parameter? (N would be a number > 1, i.e, the open loop horizon of the controller)

Hi @olivebardoza ,
I don't think that relying on the open-loop solution for some controller cycles is appropriate due to the dynamically changing environments and non-modelled effects.
For clarification, in the context of model predictive control, the horizon is defined as the temporal length of the underlying optimal control problem, and not the rate of re-computing the optimal control problem.
Maybe the oscillations are similar to those in #92 ?
Do you have a simulation setup that you can share with me?

I am also having issues with a tricycle drive for finer maneuvers.  My tricycle drive is slightly different in that it has a back steered wheel.  I'm testing a simulated vehicle in Gazebo and all goes well until the vehicle gets very close to the goal.  This issue I believe occurs because the command velocity at this point alternates very quickly between negative and positive values for the linear velocity but maintains the same sign for angular velocity.  This approach works for a pure differential drive, but fails with a tricycle drive because this alternating command velocity causes the steering wheel to change drastically, and repeatedly-- thus, the oscillation.
I tried increasing the 'weight_prefer_rotdir' when within a certain distance from the goal, but that doesn't solve the problem because I believe it is attempting to maintain a similar signed angular velocity, not linear velocity.  I'm going to keep working on it and update if I make any progress, but any suggestions are of course welcome.

I am also having issues with a tricycle drive for finer maneuvers. My tricycle drive is slightly different in that it has a back steered wheel. I'm testing a simulated vehicle in Gazebo and all goes well until the vehicle gets very close to the goal. This issue I believe occurs because the command velocity at this point alternates very quickly between negative and positive values for the linear velocity but maintains the same sign for angular velocity. This approach works for a pure differential drive, but fails with a tricycle drive because this alternating command velocity causes the steering wheel to change drastically, and repeatedly-- thus, the oscillation.
I tried increasing the 'weight_prefer_rotdir' when within a certain distance from the goal, but that doesn't solve the problem because I believe it is attempting to maintain a similar signed angular velocity, not linear velocity. I'm going to keep working on it and update if I make any progress, but any suggestions are of course welcome.

Hi...Have you found any solution for this issue.I am also facing the same problem of oscillating steering angle.Like you mentioned even i found that the linear velocity changes its sign back and forth after logging the cmd_vel values. This hinders the on spot rotation of the robot. Initially I tried to eliminate it by limiting the linear velocity to a particular value below which it is always 0, this did not solve it completely.I was also inclined to use some outlier elimination algorithm but seems like this happens quite frequently.Still unable to figure out a concrete solution.
I just wanted to know your progress.


feat: Ethereum RPC " chain_id" call

Description
Implement "chain_id" Ethereum RPC call
Helios implmentation: https://github.com/a16z/helios/blob/94bf458d941f30e34faeaa7d2484898dba54234d/client/src/rpc.rs#L67
Acceptance Criteria

Beerus can query a Ethereum's block number
Associated cli command
Associated rest api wrapper
Helios integration
Units tests
Integration tests

Taking this one :)

Ok 👍

Implemented


Smoke test track 2 packages against live Azure

Requirements

Create a smoke test in each supported language
Use the latest public release of the SDK for each supported service
Use the Mgmt SDK to create resources to test against and to clean up after
Execute a single request against each supported live service in public Azure

Languages

[x] .NET
[ ] Java
[ ] Python
[ ] JavaScript

Closing this Epic.  Smoke tests created and running regularly.  We have another epic (#586) tracking further integration.


Implement BACK button from blog to main site

Right now there is no way to get from https://pnp.github.io/blog to https://pnp.github.io, our main landing page.

Hey @Adam-it - thank you! I think it would be nice if it matches the experience that people have on the PnP landing page https://pnp.github.io?

I'll try to do my best.
Assigning myself to this one then 👍

you go!!


sign comparison warnings from .stan programs

You can get unnecessarily confusing compiler warnings from a .stan program like
functions {
  vector normal_vec_rng(int N) {
    vector[N] ret;
    for (n in 1:rows(ret)) ret[n] <- normal_rng(0,1);
    return ret;
  }
}
model {}
file79a1192eb904.cpp: In function ‘stan::math::vector_d normal_vec_rng(const int&, const int&)’:
file79a1192eb904.cpp:52:31: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
             for (int n = 1; n <= rows(ret); ++n) {
                               ^

Can we do something about that in the parser? Or do we need to change rows, cols, etc. to return a plain int?

On Aug 20, 2015, at 4:45 PM, bgoodri<EMAIL_ADDRESS>wrote:
You can get unnecessarily confusing compiler warnings from a .stan program like
functions {
vector normal_vec_rng(int N) {
vector[N] ret;
for (n in 1:rows(ret)) ret[n] <- normal_rng(0,1);
return ret;
}
}
model {}
file79a1192eb904.cpp: In function ‘stan::math::vector_d normal_vec_rng(const int&, const int&)’:
file79a1192eb904.cpp:52:31: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
for (int n = 1; n <= rows(ret); ++n) {
^
Can we do something about that in the parser? Or do we need to change rows, cols, etc. to return a plain int?

No, we only have signed ints.  So rows, cols, etc. should be returning a plain int.
I can fix.

Bob

I think this may also be a stan/math issue.

If the problem is the return type of rows, cols, etc. rather than the
parser, then yeah it could move to math/issues.
On Thu, Aug 20, 2015 at 5:24 PM, Bob Carpenter<EMAIL_ADDRESS>wrote:

I think this may also be a stan/math issue.
—
Reply to this email directly or view it on GitHub
https://github.com/stan-dev/stan/issues/1594#issuecomment-133181455.

Moved to https://github.com/stan-dev/math/issues/151 in stan-dev/math


Make String.simplify_path keep the protocol identifier for urls

Fixes https://github.com/godotengine/godot/issues/67246
I ran the units tests and they passed, so I guess it should be fine.

Indeed, adding tests for this would be great. Also stuff like file://, Windows network shares, absolute and relative paths without protocol, etc.

Thanks!


re-enable iOS magnifier sample

This sample is not currently being shown in the sample viewer due to a groups.json omission. This PR fixes that.

Note also that the code was changed to avoid a NRE; MapView interaction options is null by default.

@dkemlage Can you please take a look at this? Thanks! :)

Thanks for the review! :)


KAFKA-15377: Don't expose externalized secret values in tasks-config API endpoint

From https://issues.apache.org/jira/browse/KAFKA-15377:

The GET /connectors/{connector}/tasks-config endpoint added in KIP-661 exposes externalized secret values in task configurations (see KIP-297). A similar bug was fixed in https://issues.apache.org/jira/browse/KAFKA-5117 / https://github.com/apache/kafka/pull/6129 for the GET /connectors/{connector}/tasks endpoint. The config provider placeholder should be used instead of the resolved config value.

Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

Test failures appear unrelated, and the tests pass locally for me.

Thanks Greg!


Update LICENSE

Coverage remained the same at 100.0% when pulling fa1e2e09b13fd8b60e331cfc15d67fab4fa2bd88 on update-license-year into e76e6f4b2d45419e44d25700b3f6a409db119ba5 on master.


Better subjective billing for soft_fail/hard_fail/CFAs in scheduled transactions

[ ] ensure we bill CFA at time it is scheduled
[ ] ensure we bill for executed cycles up until the error and then cycles for error handler

@wanderingbort @heifner I am thinking this is OBE (overcome by events).  If I don't hear from you I will presume that is the case.

OBE (Overcome By Events)


EDITOR: fix spelling mistake on the spanish theme importer

Changed line 7942 of the Spanish editor translation, which said "Editor de theme" but it's an incorrect translation as it means "Theme editor" and not "Editor theme", The correct translation is "Theme del Editor"

Thank you for your contribution
However this is not where these files are edited, instead you edit them on the webplate, see here
Closing as this is not a valid change


Returning empty Statues for an empty spark partition caused due to incorrect bin packing

This PR is a temporary fix until the real underlying issue is resolved. Find all the details here : https://github.com/uber/hudi/issues/499
@leletan FYI this should resolve your issue

@vinothchandar added to insert as well although hasn't happened for inserts yet.


ember-cli 2.17 breaks initializer

ember-cli 2.17 changed the way the application is set up: source
This means that for acceptance tests, the initializer for this addon uses will fire before the app has a container (i.e. like a fastboot app.)
I'm guessing that migrating this to an instance initializer would solve it.  Alternatively documentation could be updated to indicate that for acceptance tests you need to use manualSetup as well.
What is the ideal solution for this?

I think all you have to do is add a beforeEach hook just like you do for the other tests, and I will update the docs with a new acceptance test in this style to show how it's done. thanks for heads up on this.
  hooks.beforeEach(function() {
    manualSetup(this);
 });

The docs are now updated and I converted a test to use the new style
example here:
https://github.com/danielspaniel/ember-data-factory-guy/blob/master/tests/acceptance/user-view-test.js

:+1:  I like that approach.  I agree it is less magical, as well as more inline with the overall testing philosophy they've been moving towards (more API parallels between acceptance and integration/unit testing).


Delete YAML support - all on Open API (in both cloud & oss)

[Ticket is based on discussion with @jdegoes ]

This should be really 1 hour

Fixes in #356


Specs: Pricing mechanism

Figure out how to define pricing to run jobs.
@Zorlin has the idea of using steps for a job to define effort which can be a good 1:1 to price.

Let's use @Zorlin powerplug meter to set a baseline

Benchmark known processes.
When a new provider comes online, based on their specs, they have to prove process power - every now and then (TBD).

Unit of effort task: https://github.com/Lilypad-Tech/lilypad/issues/59

Keep in radar: when finding a match for a deal, there may be several checks to consider an we need to be accurate and explicit about those:

if the deal is coming from a targeted submission - potentially targeting more than one node, this may be setting a preference for RPs.
if we want to add a max price attribute to jobs, what is more important? the max price or the order of targeted nodes

reference


Post-mission drop cost always showing 0 cbills

This appears to be happening with the master branch.

Update
This mission showed it.  No bonuses, maybe that's related.

I'm on friggin crack or something... whatever!  It went away magically.

Further testing w/ my branch.

Not a bug

it is a bug i don't save the drop costs, so if you load into a mission after game restart it will show zero.

Cool.  My issue#2 branch is doing the same thing but otherwise working.
On Sat, Jun 9, 2018 at 9:59 AM, Morphyum<EMAIL_ADDRESS>wrote:

it is a bug i don't save the drop costs, so if you load into a mission
after game restart it will show zero.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/Morphyum/DropCostPerMech/issues/6#issuecomment-395979765,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ARmQpQ59BLku-jQl4dUO7FJ9UW03Aoixks5t6_D0gaJpZM4UhHpU
.

fixed in 1.0


CSS footer margin is gone and swagger UI authorization box is broken

Environment

Nautobot version (Docker tag too if applicable): v1.5.1b1
Python version: 3.10.7
Database platform, version: Postgres 13
Middleware(s):

Steps to Reproduce
Go to test.nautobot.com, scroll to the footer and then navigate to the API

It looks like this was a regression from #2553. #2747 resolves the footer issue without impacting the margin or the swagger API. Reverting #2553 appears to resolve this issue.

In general if we're making changes to the header and footer, we need to check for impact to:

Ordinary Nautobot UI pages
Swagger UI
GraphiQL

In general if we're making changes to the header and footer, we need to check for impact to:

Ordinary Nautobot UI pages
Swagger UI
GraphiQL

Agreed. After reverting I made sure this looks ok in large and small viewports on the home page, list view with a lot of objects, swagger ui and graphql. We should also check light mode and dark mode.


fix: no return routing and wait for ping

This PR adds some improvements to return routing. Mainly it adds two things:

Messages returned as a http response are now emitted using an event, meaning the sendMessage await won't wait for the returned message to be processed. This could lead to a chain of send / receive messages that would take a long time to resolve. Especially if the socket was kept open because no response was returned this could lead to unwanted behaviour. (see https://github.com/hyperledger/aries-cloudagent-python/pull/1853 for more context on socket staying open)
Do not include the return route decorator if not response is expected. The return route decorator is automatically added if we don't have an endpoint. This only happens with the mediator in most cases. What would happen is that the trust ping was sent to complete the connection, and we didn't receive a response. This would lead to the socket staying open for 15 seconds, before the mediation request message was sent. Now if the return route is already set (in this case to none) we won't add it in the message sender..

As mentioned in https://github.com/hyperledger/aries-cloudagent-python/pull/1853, this reduces the connection + request mediation flow time from ~17 seconds to around 1.5 seconds :)

Codecov Report

Merging #946 (de90918) into main (fc1f382) will decrease coverage by 0.00%.
The diff coverage is 76.92%.

@@            Coverage Diff             @@
##             main     #946      +/-   ##
==========================================
- Coverage   87.75%   87.74%   -0.01%
==========================================
  Files         475      475
  Lines       11358    11366       +8
  Branches     1879     1927      +48
==========================================
+ Hits         9967     9973       +6
- Misses       1324     1326       +2
  Partials       67       67

Impacted Files
Coverage Δ

.../core/src/modules/connections/ConnectionsModule.ts
68.50% <33.33%> (-0.86%)
:arrow_down:

...ckages/core/src/transport/HttpOutboundTransport.ts
13.63% <50.00%> (+2.00%)
:arrow_up:

packages/core/src/agent/MessageSender.ts
84.61% <100.00%> (ø)

.../connections/handlers/ConnectionResponseHandler.ts
82.35% <100.00%> (+1.10%)
:arrow_up:

...connections/handlers/DidExchangeResponseHandler.ts
81.81% <100.00%> (+0.86%)
:arrow_up:

.../modules/connections/services/ConnectionService.ts
87.14% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc1f382...de90918. Read the comment docs.

Would it be appropriate to add a new decorator or add to the return route decorator to address this specific use case, as that way it might not be as hacky?

Could you elaborate a bit on what you mean?

Interesting. Well the question arises for me, what does keep-alive mean then. This implies a message is always instantly processed and a message may be returned directly, or the socket will be closed. Maybe we should approach it more as the keep alive header in HTTP: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Keep-Alive?
I think ACA-Py's implementation shouldn't hang on to the http connection after a message has been processed, which means this wouldn't be an issue anymore.


Change how extraction works for better concurrency

This is a substantial internal refactoring of the extract flow which should dramatically increase extract performance in cases which previously saw lower extract performance compared to create performance for the same workload.
It completely rewrites the code that uploads from a tar archive to object storage.  Now the max concurrency configured for the job will always be used, even in cases of multi-part upload or a mix of multi-part and single-part upload.  The code is more complicated, which is why it wasn't initially implemented this way, but the result should be substantially faster writes to object storage.
Closes #19

@NDVas IIRC you were doing the performance testing on ssstar most recently.  I'd like your help testing the performance impact of this change.
Please repeat your earlier test with the same objects and data sizes, using the version of ssstar from this branch.  To install that version use this command:
cargo install --git https://github.com/elastio/ssstar.git --branch bug/19-extract-performance --locked ssstar-cli

Nadia got back to me with her tests:
https://docs.google.com/spreadsheets/d/1NYJUv1Hr_KPKu1k9w2t-zKpAfAt-idKM-dPbuf16b80/edit?usp=sharing
Unfortunately no significant improvement.  That makes no sense!  This new implementation is much more aggressive about concurrent operations.
Back to the drawing board...


Completed Project

In this branch I:

Installed React Redux, Redux Logger, and React Router
Wrote actions and reducers for fetching coins.
Added coin details page to show more details and display chart statistics using charts.js
Added tests functionality for coin component
Added tests functionality for Home component
Video presentation of project

please ignore Netlify errors, the site is up and running


[Extensibility enhancement] Table 36 - Delete Sales Lines

Could you move this code from the OnDelete-Trigger of Table 36 to a global function so that it can be called from an extension (would make life easier if I want to delete all lines that belong to a header):

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


Add maven checkstyle

So we can have the code style using the same style as Apache Camel

Please do it now so we don't have to modify a tons of files later 🤓
Den 1. jan. 2017 6.37 PM skrev "Claus Ibsen"<EMAIL_ADDRESS>
So we can have the code style using the same style as Apache Camel
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/davsclaus/camel-idea-plugin/issues/53, or mute the
thread
https://github.com/notifications/unsubscribe-auth/ABEj1U48P1YZhj90456JGHtaGlYT342Uks5rN-RcgaJpZM4LYvsN
.

Please do it now so we don't have to modify a tons of files later 🤓
Den 1. jan. 2017 6.37 PM skrev "Claus Ibsen"<EMAIL_ADDRESS>
So we can have the code style using the same style as Apache Camel
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/davsclaus/camel-idea-plugin/issues/53, or mute the
thread
https://github.com/notifications/unsubscribe-auth/ABEj1U48P1YZhj90456JGHtaGlYT342Uks5rN-RcgaJpZM4LYvsN
.

Yep was working on it, after I push you may need to update your PR so the check passes again.

Yep was working on it, after I push you may need to update your PR so the check passes again.

Is there a IDEA settings I can import from the Camel project, so I don't
have to fight with how IDEA organize imports and reformat code?
2017-01-01 18:57 GMT+01:00 Claus Ibsen<EMAIL_ADDRESS>
Closed #53 https://github.com/davsclaus/camel-idea-plugin/issues/53 via
c913fec
https://github.com/davsclaus/camel-idea-plugin/commit/c913feca2c08e665d9333e6a21525885b0b59f86
.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/davsclaus/camel-idea-plugin/issues/53#event-908699988,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABEj1RPx6nwu3Oyjj65jsEYeWMd9R9n4ks5rN-jsgaJpZM4LYvsN
.

--
Kind regards / Med Venlig Hilsen
Flemming Harms

https://twitter.com/fnharms
https://dk.linkedin.com/in/fharms

Is there a IDEA settings I can import from the Camel project, so I don't
have to fight with how IDEA organize imports and reformat code?
2017-01-01 18:57 GMT+01:00 Claus Ibsen<EMAIL_ADDRESS>
Closed #53 https://github.com/davsclaus/camel-idea-plugin/issues/53 via
c913fec
https://github.com/davsclaus/camel-idea-plugin/commit/c913feca2c08e665d9333e6a21525885b0b59f86
.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/davsclaus/camel-idea-plugin/issues/53#event-908699988,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABEj1RPx6nwu3Oyjj65jsEYeWMd9R9n4ks5rN-jsgaJpZM4LYvsN
.

--
Kind regards / Med Venlig Hilsen
Flemming Harms

https://twitter.com/fnharms
https://dk.linkedin.com/in/fharms

You can install this plugin
https://github.com/jshiell/checkstyle-idea
You can find it in the IDEA plugins, its called IDEA Checkstyle plugin.
Then you can configure it from the preference -> other settings.
There you can add the configuration file camel-checkstyle.xml
Then it can real time show mistakes in your code, or you can run an inspection by name, and find it with the checkstyle name.
Also you can import the checkstyle file into IDEA configured code style. In preference -> code style. Click manage -> import... -> import from checkstyle -> pick the camel-checkstyle.xml file.
Maybe you can update the readme file with nice steps how to do this. I also sometimes forget how to do this as I have been using this checkstyle for so many many years now.


[FR] Change order of precedence of zoom and frame scrubbing for videos

Currently, when viewing videos in the expanded modal, using ESC to escape the current context will reset to frame 1 before resetting the zoom.
I find that my analysis process is almost always:

Play the video for awhile until I see something interesting
Pause and then zoom in to inspect something
(Ideal) reset zoom and continue playback, looking for the next frame to study in more detail

Changing the order of escape precedence so that zoom is reset before frame scrubbing would best enable step 3.

This has been released as of fiftyone==0.18.0 🎉


Stealth address tab not available

There is no way of creating stealth addresses. How do I make one?

Stealth addresses are deprecated in v0.11 of Core. We hope to bring them back in the next version.


Wrong start date in week view when dragging events from month view

Hi @antoniandre ,
I've detected a bug. I have submitted a pull request to address it.
Bug description:

Drag an event from any view (i.e. week)
Drag it to month view
Drag the event over a day different than monday
Calendar switches to week view with the selected day on monday (wrong).

Glad to help!!

Thanks @pedroprieto for reporting and fixing that!
Awesome, I'll merge in soon.


fdsa

Routes
/fdsa
Full routes
/fdsa/ff
Related documentation
https://docs.rsshub.app/asdf.html
What is expected?
BBB
CCC
DDD
What is actually happening?
QQW
EEE
Deployment information
Self-hosted
Deployment information (for self-hosted)
No response
Additional info
X

This is not a duplicated issue

[X] I have searched existing issues to ensure this bug has not already been reported

/wip

wip

/wip

/wip

/wip

/test
/epicgames/freegames

/test
/epicgames/freegames

/test
/epicgames/freegames

/test
/epicgames/freegames

/test
/epicgames/freegames

/test
/epicgames/freegames

/test
/epicgames/freegames

/test
/pincong/hot

/wip

/test
/epicgames/freegames

/test
/epicgames/freegames

/test
/epicgames/freegames

/test
/rsshub/sponsors

/test
/rsshub/sponsors

/test
/xiaohongshu/user/5c8889770000000016003acb/notes


parallelize cis on x (conc or percent) values

should be same as bootdist functionality

Went with futures in the end. To parallelize bootstrapping simply execute the following code.
doFuture::registerDoFuture()
future::plan(future::multisession)


Improve the client bundle size and number of files generated

Looking at: https://template-default.hydrogen-devs.workers.dev/
And we're loading 60 JS files and ~150kb of JavaScript in the client. We need to reduce both of those numbers.
A couple ideas:

Teach Vite/Rollup not to bundle entry points for every single client component, and instead create shared chunks which we can reference in the RSC manifest.
~Spike on moving cart functionality to API functions~

Chatted with @developit who has some ideas on this front.
My (naive) summary: Our dynamic import() of these components means they are all addressable chunks. Perhaps Vite instructs Rollup to do this when we call import.meta.globSync(). Rollup thinks this means they need to be individual bundles, but in reality, they just need to be addressable exports of shared bundles. Jason thinks there might be a solution at the Rollup level as an additional plugin — something closer to Webpack's resolveWeak, which just asks for an addressable ID rather than a unique bundle.
cc @frandiox who can share more about the architecture of our Vite RSC plugin.

Chatted with @developit who has some ideas on this front.
My (naive) summary: Our dynamic import() of these components means they are all addressable chunks. Perhaps Vite instructs Rollup to do this when we call import.meta.globSync(). Rollup thinks this means they need to be individual bundles, but in reality, they just need to be addressable exports of shared bundles. Jason thinks there might be a solution at the Rollup level as an additional plugin — something closer to Webpack's resolveWeak, which just asks for an addressable ID rather than a unique bundle.
cc @frandiox who can share more about the architecture of our Vite RSC plugin.

On the plus side, combining files should dramatically reduce total JS weight due to compression benefiting from repetition.

On the plus side, combining files should dramatically reduce total JS weight due to compression benefiting from repetition.

We have about 67 JS files downloaded in the default template (prod build). From that, 47 are client components (build without hashing to see this). The other 20 are vendor libs and utilities that are used in more than 1 client component chunk (so they are extracted as separate chunk to re-use the code).
Therefore, the root of the issue seems to reside in having all the client components generated as separate chunks. However, I don't think we want to bundle all of them automatically into 1 single chunk either, right? That would mean we download all of them during hydration, even things that are not used in the current view (unless I'm missing something).
I think we might be misusing client component files. Perhaps this could help:

Rename our *.client.jsx files to be shared components instead.
Group them in areas: cart stuff, product stuff, etc.
Re-export areas as a whole from *.client.jsx files that can be imported by server components.

That feels closer to the "client boundaries" mentioned in the latest RSC RFC comments.
For example, we currently have 14 cart-related client components + 2 cart utilities across Hydrogen itself and the default template, which means we download 16 different chunks just for the cart:

Theoretically, this could be reduced to 2 if we export all the cart-related client components from a single Cart.client.jsx in Hydrogen and another one in the user app. These files would be downloaded during hydration only if the current view needs the cart.
Perhaps it can even be reduced to just 1 chunk if we export from Hydrogen as "shared components" and it is all used in a single *.client.js component in the user app. This would be like moving the "client boundary" from Hydrogen to the user app 🤔


maltparser log4j dependency

I wanted to note that malt.py appears to have a log4j dependency. Any recommendations on how to eliminate any concerns with the recent exploit?

MaltParser is not packaged within NLTK, thus general use of NLTK should not be vulnerable to log4j.
To use NLTK's malt.py, then you must also install a version of a MaltParser jar. Then, NLTK simply calls the MaltParser jar. If you wish to avoid a potential Log4j vulnerability, then I would advise downloading a new MaltParser jar to some version without this dependency/vulnerability, if one exists. If one does not exist, then I would recommend to raise your concerns to the MaltParser developers instead, or create a community version that has the exploit patched.
Long story short - you may only be vulnerable if:

you have installed the MaltParser jar,
you are using the MaltParser parser imported from nltk, and
you are a version of the MaltParser jar that has not been patched.

I would not be concerned unless all 3 of these are true for you.

Tom Aarsen


[Enhancement] only call getAliveComputeNodes once per OlapScanNode

Why I'm doing:
I found some queries which were slow (order of 3-5 seconds) which were bottlenecked in the frontend. Their query profiles indicated that much of the query execution time was spent planning. I did some jstack profiling of the frontends while sending this type of query, see jstack_example9.txt for an example of the profile. The takeaway is that the large majority of threads were busy doing WarehouseManager.getAliveComputeNodes from OlapScanNode.addScanRangeLocations, just to check if there are any living compute nodes. This is done once per PhysicalPartition, even though the check for living CN is not parameterized by anything other than warehouse id. This is wasteful and seriously slow when there are large partition/tablet counts. We can eliminate this bottleneck.
What I'm doing:
Ensuring that getAliveComputeNodes is called once per instance of OlapScanNode (once per query).
This can be seen as a follow up to https://github.com/StarRocks/starrocks/pull/46913
Fixes #issue
What type of PR is this:
This is a fix for a performance issue, which I'll call an enhancement.

[ ] BugFix
[ ] Feature
[x] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[ ] Yes, this PR will result in a change in behavior.
[x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[x] I have added test cases for my bug fix or my new feature
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

[ ] This is a backport pr

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[x] 3.3
[ ] 3.2
[ ] 3.1
[ ] 3.0
[ ] 2.5

skip backport to branch-3.2, the check logic added in #45499 is not backported to branch-3.2

ignore backport 3.2.13


Updating loading toast is dismissed instantly

When creating a loading toast with duration: infinite, you must pass another duration in the update otherwise the update keeps the infinite duration. I would expect that the default duration should override the loading toasts duration.
However, when passing a new duration for the updated toast, it is not respected and closes instantly. (regardless of value set)
see: https://codesandbox.io/s/xenodochial-grass-jfsdrp?file=/src/App.js

what would be an real world example of passing duration: infinite?

Almost all instances where you need to control the loading toasts' state or an event that takes an indeterminate amount of time to complete.
If you don't set duration: infinite the loading toast will auto-close, after the default duration. (which I fail to see a use for)
my usage:

long-running requests
batch requests, grouped in one toast, updated with progress.

This has been fixed in #206


Closures don't run in parallel

Might want to notate that closures don't run in parallel (at least on windows).  php binaries/other commands do.

Hello, could you paste some code to reproduce issue?

These will run one at at a time and the total time of the scheduled run will be 10*len($arr) seconds.
foreach($arr as $item)
{

    $task = $schedule->run(function() use ($item) {

      sleep(10);

    });
  $task

       ->everyMinute()
        ->description($item["name"])
        ->appendOutputTo("/tmp/". $item["name"] . ".txt");

}
return $schedule

Tested on v3.3 and works as expected on WIndows. What version are you using (Crunz and PHP)?
You can run Crunz with schedule:run -vvv to get some debug info, also there is task:debug command to get more info about specific task, maybe preventOverlapping is enabled?
Currently doesn't look like issue in Crunz.
Here is my reproducing code:
<?php

use Crunz\Schedule;

$scheduler = new Schedule();

$closure = function (): void {
    \sleep(3);

    echo 'Done', PHP_EOL;
};

for ($i = 1; $i <= 2; $i++) {
    $event = $scheduler->run($closure);
    $event
        ->everyMinute()
        ->description("Closure {$i}")
        ->appendOutputTo("/tmp/closure-{$i}.txt")
    ;
}

return $scheduler;


Inconsistent Persona Naming

The persona naming scheme is inconsistent across documentation.
Intro Page:

Platform Provider
Platform Operator
Service Operator

Concepts Page:

Infrastructure Provider
Cluster Operator
Application Developer

@robscott and I prefer the concepts page naming scheme. Thoughts?
/assign @mark-church
/cc @hbagdi

I think we have usually discussed the API with the naming in Concepts doc.
I personally prefer the naming in Concepts doc as well.

I think we have usually discussed the API with the naming in Concepts doc.
I personally prefer the naming in Concepts doc as well.

Yeah makes sense, I like the ones from the concepts doc as well. I can go ahead and change it later this week.

Yeah makes sense, I like the ones from the concepts doc as well. I can go ahead and change it later this week.

Great, thanks!
I'll assign this to you for now.
/assign @mark-church

Great, thanks!
I'll assign this to you for now.
/assign @mark-church

Hey @mark-church, do you still have the bandwidth to take this on?

Yup, fixed it with https://github.com/kubernetes-sigs/gateway-api/pull/551


Feature request: search for any string

Hi,
Fist off, thanks for making this tool!
As a feature request, it would be great to search for any string (e.g . “Amazon” to see a list of all certs generated for a domain containing the string “Amazon”).
This would allow you to use the tool for phishing monitoring as well.
Thanks 🙏

Hi,
Thanks for filing this issue. The tool was mainly designed for subdomains monitoring but if you want to monitor phishing attempts, you can use Facebook transparency which was built for that purpose https://developers.facebook.com/docs/certificate-transparency
Regards.


chore: use semver to determine API compatibility

Fixes #5

@MSNev the biggest changes here are related to the diag logger because it behaves differently than the other APIs so I would appreciated a peek

@MSNev While trying to get together an implementation that would not allow changing log levels in the global logger, I came across the test titled 'diag setLogLevel is ignored when using a specific logger'. It seems to me if the global log level is INFO and i create a filtered logger with the DEBUG level. I should be able to see debug level logs when I call it. But this test appears to assert the opposite? What is the point of creating a separate logger if not to get more specific logging from one component than what the global logger is set to?

@MSNev Nev Wylie FTE While trying to get together an implementation that would not allow changing log levels in the global logger, I came across the test titled 'diag setLogLevel is ignored when using a specific logger'. It seems to me if the global log level is INFO and i create a filtered logger with the DEBUG level. I should be able to see debug level logs when I call it. But this test appears to assert the opposite? What is the point of creating a separate logger if not to get more specific logging from one component than what the global logger is set to?
edit: I resolved it by doing this. Can you please take a look? dyladan#1

The test is asserting that if you just create a new level of "X" but the user / application set the level higher globally AND you have created a filtered logger using the default (without specifying a logger), it will default to delegating the logging api.diag, which will then obey the global logging level request. And if you want to override the global level then you need to specify the specific logger, so you need to get the underlying (unfiltered logger) via api.diag.getLogger()
This is documented explicitly in the TS doc of the createLogLevelDIagLogger()
https://github.com/open-telemetry/opentelemetry-js/blob/main/packages/opentelemetry-api/src/diag/logLevel.ts#L67-L79

@MSNev Nev Wylie FTE While trying to get together an implementation that would not allow changing log levels in the global logger, I came across the test titled 'diag setLogLevel is ignored when using a specific logger'. It seems to me if the global log level is INFO and i create a filtered logger with the DEBUG level. I should be able to see debug level logs when I call it. But this test appears to assert the opposite? What is the point of creating a separate logger if not to get more specific logging from one component than what the global logger is set to?
edit: I resolved it by doing this. Can you please take a look? dyladan#1

The test is asserting that if you just create a new level of "X" but the user / application set the level higher globally AND you have created a filtered logger using the default (without specifying a logger), it will default to delegating the logging api.diag, which will then obey the global logging level request. And if you want to override the global level then you need to specify the specific logger, so you need to get the underlying (unfiltered logger) via api.diag.getLogger()
This is documented explicitly in the TS doc of the createLogLevelDIagLogger()
https://github.com/open-telemetry/opentelemetry-js/blob/main/packages/opentelemetry-api/src/diag/logLevel.ts#L67-L79

That's quite confusing to me. I would expect that if I called createLogLevelDiagLogger with a level the returned logger would respect that level. With no logger passed, I would expect it to use the same destination as the global, but not necessarily respect the global level.

That's quite confusing to me. I would expect that if I called createLogLevelDiagLogger with a level the returned logger would respect that level. With no logger passed, I would expect it to use the same destination as the global, but not necessarily respect the global level.

Yes, I agree. It came about from a comment from Bart where if the user has set the global logging level to NONE then he did not expect that we (by default) would override their level request. But we still had code (now removed as part of the config) that wanted to override and set directly.

@obecny do you mind if we reverse this behavior?

That's quite confusing to me. I would expect that if I called createLogLevelDiagLogger with a level the returned logger would respect that level. With no logger passed, I would expect it to use the same destination as the global, but not necessarily respect the global level.

Yes, I agree. It came about from a comment from Bart where if the user has set the global logging level to NONE then he did not expect that we (by default) would override their level request. But we still had code (now removed as part of the config) that wanted to override and set directly.

which comment ?

which comment ?

I said:

I would expect that if I called createLogLevelDiagLogger with a level the returned logger would respect that level. With no logger passed, I would expect it to use the same destination as the global, but not necessarily respect the global level.

Nev said:

Yes, I agree. It came about from a comment from Bart where if the user has set the global logging level to NONE then he did not expect that we (by default) would override their level request. But we still had code (now removed as part of the config) that wanted to override and set directly.

Would you be ok if that was the behavior?

which comment ?

I said:

I would expect that if I called createLogLevelDiagLogger with a level the returned logger would respect that level. With no logger passed, I would expect it to use the same destination as the global, but not necessarily respect the global level.

Nev said:

Yes, I agree. It came about from a comment from Bart where if the user has set the global logging level to NONE then he did not expect that we (by default) would override their level request. But we still had code (now removed as part of the config) that wanted to override and set directly.

Would you be ok if that was the behavior?

@dyladan I would expect the behaviour you exactly described, if you pass some params to a function it should respect this params, otherwise it doesn't make sense to insert any params......, not sure why it would be different. But then @MSNev said that it is working differently because of my comment, so @MSNev which comment I did that it is working differently ???

I found the original comment and sorry @obecny I miss-attributed (and slightly miss-remembered) it to you when it was actually @vmarchaud on this comment.
The comment was around having the "forcedInfo" and specifically this bit

i don't expect having log coming where i explicitly dont want them

https://github.com/open-telemetry/opentelemetry-js/pull/1880#discussion_r573183063

@vmarchaud do you have an opinion on this?

The comment was around having the "forcedInfo" and specifically this bit

i don't expect having log coming where i explicitly dont want them

I was refering to the fact that we couldn't (from my understand of the proposal) silence "forcedInfo".
If i get correctly the problem here, we are talking about the situation where i would have set the level to INFO on the global diag api but someone created another logger with a different level, in this case should we respect the global level or the level provided when constructing the logger ?
I believe the correct way (and whats possible with other APIs) is to use the level provided by the constructor, so i agree with @dyladan.
I understand why it oppose with my previous comment, but i think we should never construct a diag logger in any sdk components, only users should use this, so we can't really have a situation where the logger is using a level that wasn't choosen by the user

but i think we should never construct a diag logger in any sdk components, only users should use this, so we can't really have a situation where the logger is using a level that wasn't choosen by the user

I TOTALLY agree with this, having the constructors / helpers is a "nice' to have for SDK / component developers during development ONLY.

@MSNev I marked our previous conversation around globals as resolved because it was a long conversation largely about code that has been removed. If you still feel my use of globals is invalid please open a new comment thread. Otherwise I would appreciate another review.

Maybe create a separate PR for the diag refactoring? At least for me it's hard to follow this PR here which says it's about semver checks but more or less all discussions and a large amount of the changes are about diagnostics.
Please update PR description in first message at some allow people to get some hints what this is good for without the need to read through the old PR.

Maybe create a separate PR for the diag refactoring? At least for me it's hard to follow this PR here which says it's about semver checks but more or less all discussions and a large amount of the changes are about diagnostics.
Please update PR description in first message at some allow people to get some hints what this is good for without the need to read through the old PR.

Sorry, the diag refactoring was a requirement for this. I'll split it into another PR to make this one more directed.

Closing this PR in order to have the diag refactor in its own PR. Creating a new PR which depends on that PR. I will keep this branch without deleting until I'm sure we don't need it.
Diag refactor: #9
New global semver PR: #10


Ansible Galaxy

Need to re-organize the ansible roles folder so that each component can exist on its own at https://galaxy.ansibleworks.com/. This would involve setting up a sub-tree split script for all existing components so they can be used independently outside protobox.

New version #155 will allow any ansible galaxy playbooks.


[builtins] handle reading mixed layer directories (e.g. with .csv)

References and relevant issues
Closes https://github.com/napari/napari/issues/5460
Description
This PR handles reading the output of write_layer_data_with_plugins ('Save to folder' in the GUI).
If a directory is passed to the reader, then a check is made whether it contains .csv files. If so, it reads each file in the directory using either the csv reader or the magic imreader.
The layer names are set to the file names (but source will still show the folder name).
If a file type cannot be handled, it is skipped with a notification.
Otherwise, the behavior is left unchanged.
The goal here is not universal handling of complex folder structures, just handling the common case of folders saved by napari containing layers.
I added a test to reflect this.

@psobolewskiPhD so sorry for the delay in getting to this... I've been playing with it today and I have some comments.
With napari==0.4.19.post1, when I drag a folder with 2 tiffs and a csv in, it stacks the tiffs with the csv, and when I try to scroll to the third slice, it errors. Is this the behavior you see? I couldn't quite tell from the issue whether you see the error with nothing open or whether it stacks.
With this PR, the tiffs don't stack, and I think that's a significant change. What do you think about stacking tiffs but reading csvs individually, since as you mention in the issue, csvs don't stack.
In general I'm worried about always trying to read in the csvs, but I totally see what you're saying about fixing reading for things we save out. @jni thoughts? I think maybe this is better than nothing, with yet another comment on us needing to do a bigger I/O overhaul...

@DragaDoncila I should update the issue, but the bug you observe is something that came up recently when working with an end user that had 2 tifs (image, labels), and a csv (points).
I tired to ensure that this  PR IMO resolves that, by not stacking if there is a csv. The goal is to handle outputs of napari save to folder, which is super nice -- just need to get the svg issue resolved, so people know about it!
(I've just told people to uninstall the svg plugin, it's not really functional or maintained at this point anyways)
If someone has a folder of tiffs they shouldn't be affected.
(I mean the auto stack is hit or miss anyways. But it's beside the point, the default has been that way for a while.)
If they have a folder of tiffs with random other stuff in them, then the current behavior isn't good either.

The goal is to handle outputs of napari save to folder, which is super nice

Yeah I'm fully onboard with this goal, I'm just concerned that this changes behavior for all folders, not just those saved by napari. If people are relying on the stacking, it could be pretty grim to now get 600 layers trying to open because you have timelapse data with one tiff per frame (this is what I work with so it's close to my heart 😆 ). Maybe we do want to associate some metadata when we save... 😬 That's basically the only way we can guarantee a return trip

Is there any case where napari currently works "as expected" but this would break that?
Because a folder of tiffs or whatnot as a time series is not affected.

Because a folder of tiffs or whatnot as a time series is not affected.

Right, I guess it's unaffected so long as it doesn't happen to have a csv in it, I just think storing features etc. in these folders is kinda common? But maybe that's just me being messy 😆

Could adda heuristic that if there are more than n non-csv files that have the same extension, then stack em? But what would be n? 5? 10?

@psobolewskiPhD yeahhh I thought along those lines too but it immediately spiked my blood pressure and I shied back away 😆

Other option: Open Folder as Stack menu item

Other option: Open Folder as Stack menu item
Less magic, more explicit.
Edit2: and maybe rename the other Open Folder as Layers?

This would work, but we'd have to change the drag and drop behavior too, probs by also using Shift, same as we do for Files...

That sounds reasonable though, makes it consistent -- dragging a batch of files or a folder of the same files should work identically, with the same options.

Yeah I think that sounds sorta reasonable...

OK, ill put this in draft and poke around.
So the idea is:

Have Open Folder > (sub menu)
- as Layers
- as Stack
Have drag-n-drop of folder use keybind to modify the behavior as above.

For the stack case, do we just ignore non-image files? or error if there are more then 2 extension?

Of course zarr and other things will be annoying to handle or explain. 😡

Frankly, I have no idea whether a zarr should be as a file or as a folder.

if we use the system file browsing dialogs I think there's basically no way to tell them to open a zarr folder from the Open File menu... But yeah ideally you could just select anything and we would know under the hood whether it was a folder or not, but the user wouldn't have to care

@DragaDoncila I spent some time on this but as far as I can tell npe2 readers don't get stack passed to them anywhere?
magic_imreader just has stack=True set by default
So with a folder, which is a single path string, there is no way to pass a stack variable that could be used to handle whether the contents should be stacked or not.

@DragaDoncila I spent some time on this but as far as I can tell npe2 readers don't get stack passed to them anywhere?

Gahhhh yes I think you're right. There was a push at once stage to get that through to the readers but hasn't been exposed. Currently the "idea" is that if you get a list of images you're supposed to stack them, and if you get just one folder you're not. But I don't know to what extent, if at all, that convention is followed. We should update the manifest, it's just a matter of what that's going to mean for older readers that can't take the stack argument at all

Any thoughts where that leaves this PR?

"do you want this to be stacked or what?"

🤣 I will insta-merge a PR adding this modal 😂

For the stack case, do we just ignore non-image files?

I think yes.

Frankly, I have no idea whether a zarr should be as a file or as a folder.

zarr v3 should help here because the files will be zarr.json instead of .zarray/.zgroup/.zattrs. So we could instruct people to open zarr.jsons and not the containing folder.
In the meantime, it has to be a folder, indeed.

Any thoughts where that leaves this PR?

Wow it's super tricky. 😂 One idea: provide two different plugins, builtins-layers and builtins-stack?
Another idea (more out there): when we save all layers to folder, we save a napari-layers.yaml file within the folder that contains all the layer info (this file makes up this layer etc) and tells the builtins plugin to do the right thing? (And/or maybe we instruct users to open that file directly?)

Another idea (more out there): when we save all layers to folder, we save a napari-layers.yaml file within the folder that contains all the layer info (this file makes up this layer etc) and tells the builtins plugin to do the right thing?

yeah, I think that's the only way to really guarantee a return round trip, and could be useful for other stuff as well. I would say we accept either the file or a folder containing the file. It's a relatively low-impact approach...
But ultimately for the GUI the best thing to do is build a richer I/O experience, with or without the native dialog. The number of file I/O issues is concerning so it would be good to get started on that experience soon...

@DragaDoncila what do you think about the two-plugins idea, vis-a-vis solving the issue for existing datasets in the wild? It's kinda ugly but might work as a bandaid until we overhaul readers...

@jni sorry so the idea with the two plugins is that we allow users to select builtins-layers for opening a folder of mixed stuff and builtins-stack for opening a folder in stack form? I think that's maybe ok. builtins-layers is the only one that knows about our sneaky yaml to read stuff back in? builtins-stack is the current implementation? And maybe we fix it somehow so it doesn't try to stack tiffs and csvs together?


parse setup.py?

deleted at in favor of PyPI API
https://github.com/andriyor/ghpypideps/commit/88d9b4ee0527b670bf013603b01b98c580cc17a4
for example to support tests_require, docs_requirements in PyNaCl

unsupported

[ ] https://github.com/nedbat/coveragepy/blob/master/setup.py


Bugs and improvements observed in H2 Migration tool migration.sh script to migrate H2 embedded DB

How to reproduce:

Clone the repo and get the below script
https://github.com/wso2/samples-is/blob/master/h2-migration-tool/migration.sh
Run the script as sh migration.sh

[x] When you execute the script with below command as mentioned in the guide using the given command
curl -s https://raw.githubusercontent.com/wso2/samples-is/master/h2-migration-tool/migration.sh | bash
Script execution is not allowing the user to input the below parameters. path to the previous database file and path to target files. And the script execution will end up in below error. But if you run the script with sh migration.sh without the curl then the script will work. We may need to improve the script to support the curl or need to remove it from the guide.

Refer https://docs.google.com/document/d/1vIL1ExpXt4i5q_XYaGCseAxe5obfAZkxFWW_hxJQbtY/edit#

[x] Script will ask for a file path as Enter the path to the previous database files: eg. /old-databases
Here Better to give the sample folder path for a user as /repository/database. Currently its mentioning as old-database but its not meaningful. So better to give a sample file path suggestion by including the exact database path here. So that it will be clear for a fresh user too

[x] When the script is executing its not checking whether it has already downloaded the old and new h2 jars (h2-2.1.210.jar, h2-1.4.199.jar) for the same location. When we execute the script it will download the same resources multiple times. This consumes more data and time. Therefore shall we add a check to check and download the H2 jars if they are not previously downloaded and to skip download if its already downloaded

Environment information (Please complete the following information; remove  any unnecessary fields) :

Product Version: [e.g., IS 5.10.0, IS 5.9.0]
OS: [e.g., Windows, Linux, Mac]
Database: [e.g., MySQL, H2]
Userstore: [e.g., LDAP, JDBC]

Optional Fields
Related issues:

Suggested labels:

Verified these fixes and the reported issues are fixed.


No add_osd_to_crush function at jewel release images

Guys, as I can see after the latest re-build of jewel release images add_osd_to_crush function was removed from /common_functions.sh script, is this normal behaviour?

Fixed, sorry about that.


Feature request: Support for envelope encryption for secrets with AWS KMS

I'm submitting a...

[ ] bug report
[x] feature request
[ ] support request - read the FAQ first!
[ ] kudos, thank you, warm fuzzy

Description
Amazon just released support for envelope encryption for secrets using KMS.  -> https://aws.amazon.com/about-aws/whats-new/2020/03/amazon-eks-adds-envelope-encryption-for-secrets-with-aws-kms/
It looks like the terraform resource has been updated and already supports it -> https://www.terraform.io/docs/providers/aws/r/eks_cluster.html#encryption_config-1
This feature request is to add support in this module. I'm willing to take a stab at it since it looks pretty straightforward, just wanted to make sure no one is already working on this before I give it a try.
Edit : Not sure if it'll be that straightforward since the encryption_config parameter is an optional block that includes a required block.
The only solution I can think of is to duplicate the cluster resource and add encryption_config to the new one. And control which one is used with a count and a ternary. Open to suggestions for a better way.
Edit 2 : I guess I could use a for_each and a dynamic block for that.

Resolved by https://github.com/terraform-aws-modules/terraform-aws-eks/pull/772


runSetup possible bug.

https://github.com/lkerr/groundfish-MSE/blob/463ec28fd1712145707e234617dc00da5beae791/processes/runSetup.R#L160-L175
This bit of code creates a save folder called Run_YYYYY, where YYYYY is randomly generated. There is a chance that the code will try to create a folder that already exists.  dir.create() will give a warning when this happens, but the code will continue to run.
I don't know enough about how the subsequent code works -- it may overwrite existing results invisibly, which would be bad. It may also write new results into that folder, which is probably okay-ish.
A safer way might be to replace lines 167-169 with

list.dirs() in file.path(tempwd,"assessment","ASAP"), full.names=FALSE
find the largest "Run_YYYYY" using substr() and max()
Add 1.
use this to construct rundir

Something will be needed if the list.dirs() command returns nothing.
I don't know who best to address this, so I've flagged @lkerr

This is an rmd code chunk that I have that looks through a folder for files that match a pattern. It could be modified to address the issue.
{r reset_vintage_string, include=TRUE, echo=TRUE, results=FALSE}
#This code looks into data_intermediate and sets the vintage_string according to the most recent data
datasets_list<-list.files(path=here("data","intermediate"), pattern="RESULT_COMPILED_")
datasets_list<-gsub("RESULT_COMPILED_","",datasets_list )
datasets_list<-gsub(".Rds","",datasets_list)
datasets_list<-gsub(".csv","",datasets_list)
vintage_string<-max(datasets_list)
rm(datasets_list)

I think I was the one who wrote that odd chunk of code. The issue was that when running in parallel on the HPCC I wanted to do the best I could to not overwrite runs when many iterations of the model were running simultaneously. One approach that is kind of along the lines of @mle2718 's suggestion might be to add a text file counter that gets read/written over every time the folder is queried. I'm thinking that if the count is internalized within an instance of R there might be some overwriting going on. There are surely better ways than random number assignment :) .


Feature Request - SQL Callbacks - more than one .sql file

What version of Flyway are you using?
4.0.1
What database are you using (type & version)?
Oracle 11.2
What operating system are you using?
Windows 7 & RHEL
Feature Request
At present, a Sql Callback can execute only one .sql file eg afterMigrate.sql. This file can't import code from another .sql files or 'call' another .sql file. I would like to execute multiple .sql files in a callback.
At present, I use Oracle SqlPlus to execute a list of files after migration but I would prefer if I could do this with Flyway.
Suggested implementation:
Have flyway scan for callback files named something like this: afterMigrate.sql.list
Execute all the .sql files listed.
# This is a comment

# Execute this file
test/validate-code.sql

# Execute another file
reports/generate-mi.sql

# Scan this folder and apply every .sql file
unit-test/

+1 on this.

Could we make the callback names only be prefixes instead?
So for example you could have multiple "afterMigrate" SQL files. Something like:

afterMigrate1__my_first_after_migrate.sql
afterMigrate2__my_second_after_migrate.sql

One additional aspect:

It would be nice to have callbacks before and after a specific migration only.
An example of the file name could be: prefixVERSIONseparatorDESCRIPTIONseparatorCALLBACKsuffix
This could be used to insert test data after schema creation to allow that the next migrations could be run with existing data. For example, having the sql scripts for the migration in an sql location and the callbacks on other location like test, running flyway for migrations only with the sql location and for testing with the sql,test location.

@tinproject Multiple locations combined with dotted version numbers (7.1, 8.1, ...) already let you achieve this today.

@axelfontaine could you explain a little bit more?

This has now been implemented. Multiple SQL callbacks for the same event are now allowed. They then must have a description and are executed in the order of their description.
Example: beforeRepair__vacuum.sql


Configuration Clashes

Am updating the docs and looking at the config page
http://revel-docs.daffodil.uk.com/manual/appconf.html
The issue is the "build in properties"

the idea I think is that these are "reserved variables"
Ie u can use your own custom config, but also DONT clash with revel..

If revel detects as clash somehow , eg a new key added to reserved and not recognised..
Then it should crash..
Make sense ?? am thinking out loud

Also when does Config and getting variables come into scope ?
And are there triggered to register config changes, eg changing a database config and live switch ??

Built-in properties may not be the correct name. Perhaps "Supported Config Properties"? There is nothing wrong with them being overridden. No worries there unless you can think of a problem.
app.conf is loaded in revel.go Init()


NEXT-8142 - Thumbnails of variants use full image size

EN:
Variants have the same photos as the products themselves assigned (2048px).
The thumbnails of the variants use these large images for display and scale the whole thing using HTML instead of responsive picture elements.
This means that a lot of unnecessary data has to be loaded. In our case an article with 24 variants which makes up a few MB in the end.

Die Thumbnails der Varianten verwenden diese großen Bilder für die Darstellung und skalieren das ganze per HTML statt mit responsive Picture Elementen.
Dadurch müssen extrem viel unnötige Daten geladen werden. In unserem Fall ein Artikel mit 24 Varianten was dann unterm Strich gleich ein paar MB ausmacht.

I think here is another problem: thumbnails were not generated. IF there is a srcset there is a possibility you couId see the big image loaded, when the bigger size has been loaded into cache before of browser.
I cannot reproduce this error.

I think here is another problem: thumbnails were not generated. IF there is a srcset there is a possibility you couId see the big image loaded, when the bigger size has been loaded into cache before of browser.
I cannot reproduce this error.


Updated for biorbd-viz 1.3.0

Codecov Report

Merging #134 into master will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master     #134   +/-   ##
=======================================
  Coverage   87.02%   87.02%
=======================================
  Files          15       15
  Lines        2112     2112
=======================================
  Hits         1838     1838
  Misses        274      274

Impacted Files
Coverage Δ

biorbd_optim/plot.py
76.48% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbdd2c5...8c34511. Read the comment docs.


ethpool.py all pages return 404

Hi! When I run ethpool.py, all of urls returns 404 error code. How can I repair that?

This problem solved by setting SERVER_NAME with correct ip address:port


239 replace hardcoded navigation with sanity

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.97%. Comparing base (67b9675) to head (87689e9).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #241      +/-   ##
==========================================
- Coverage   97.98%   97.97%   -0.02%
==========================================
  Files          21       21
  Lines         199      198       -1
  Branches       59       59
==========================================
- Hits          195      194       -1
  Misses          4        4

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[stdlib] Expanded string slicing test

What's in this pull request?
This updates the tests for substrings to include sharing indices with string view slices. The tests are currently xfail'd for CharacterView, UnicodeScalarView, and UTF16View.

Current test output:
[ RUN      ] SubstringTests.String
[       OK ] SubstringTests.String
[ RUN      ] SubstringTests.CharacterView (XFAIL: [Always(reason: CharacterView slices don't share indices)])
stdout>>> check failed at ...swift/test/1_stdlib/subString.swift, line 16
stdout>>> expected: "a" (of type Swift.Character)
stdout>>> actual: "c" (of type Swift.Character)
stdout>>> check failed at ...swift/test/1_stdlib/subString.swift, line 16
stdout>>> expected: "b" (of type Swift.Character)
stdout>>> actual: "d" (of type Swift.Character)
stdout>>> check failed at ...swift/test/1_stdlib/subString.swift, line 16
stdout>>> expected: "e" (of type Swift.Character)
stdout>>> actual: "g" (of type Swift.Character)
stdout>>> check failed at ...swift/test/1_stdlib/subString.swift, line 16
stdout>>> expected: "a" (of type Swift.Character)
stdout>>> actual: "C" (of type Swift.Character)
stdout>>> check failed at ...swift/test/1_stdlib/subString.swift, line 16
stdout>>> expected: "C" (of type Swift.Character)
stdout>>> actual: "e" (of type Swift.Character)
stdout>>> check failed at ...swift/test/1_stdlib/subString.swift, line 16
stdout>>> expected: "d" (of type Swift.Character)
stdout>>> actual: "f" (of type Swift.Character)
stdout>>> check failed at ...swift/test/1_stdlib/subString.swift, line 16
stdout>>> expected: "e" (of type Swift.Character)
stdout>>> actual: "g" (of type Swift.Character)
[    XFAIL ] SubstringTests.CharacterView
[ RUN      ] SubstringTests.UnicodeScalars (XFAIL: [Always(reason: UnicodeScalarsView slices don't share indices)])
stdout>>> check failed at ...swift/test/1_stdlib/subString.swift, line 16
stdout>>> expected: "a" (of type Swift.UnicodeScalar)
stdout>>> actual: "c" (of type Swift.UnicodeScalar)
stdout>>> check failed at ...swift/test/1_stdlib/subString.swift, line 16
stdout>>> expected: "b" (of type Swift.UnicodeScalar)
stdout>>> actual: "d" (of type Swift.UnicodeScalar)
stdout>>> check failed at ...swift/test/1_stdlib/subString.swift, line 16
stdout>>> expected: "e" (of type Swift.UnicodeScalar)
stdout>>> actual: "g" (of type Swift.UnicodeScalar)
stdout>>> check failed at ...swift/test/1_stdlib/subString.swift, line 16
stdout>>> expected: "a" (of type Swift.UnicodeScalar)
stdout>>> actual: "C" (of type Swift.UnicodeScalar)
stdout>>> check failed at ...swift/test/1_stdlib/subString.swift, line 16
stdout>>> expected: "C" (of type Swift.UnicodeScalar)
stdout>>> actual: "e" (of type Swift.UnicodeScalar)
stdout>>> check failed at ...swift/test/1_stdlib/subString.swift, line 16
stdout>>> expected: "d" (of type Swift.UnicodeScalar)
stdout>>> actual: "f" (of type Swift.UnicodeScalar)
stdout>>> check failed at ...swift/test/1_stdlib/subString.swift, line 16
stdout>>> expected: "e" (of type Swift.UnicodeScalar)
stdout>>> actual: "g" (of type Swift.UnicodeScalar)
[    XFAIL ] SubstringTests.UnicodeScalars
[ RUN      ] SubstringTests.UTF16View (XFAIL: [Always(reason: UTF16View slices don't share indices)])
stdout>>> check failed at ...swift/test/1_stdlib/subString.swift, line 16
stdout>>> expected: 97 (of type Swift.UInt16)
stdout>>> actual: 99 (of type Swift.UInt16)
stdout>>> check failed at ...swift/test/1_stdlib/subString.swift, line 16
stdout>>> expected: 98 (of type Swift.UInt16)
stdout>>> actual: 100 (of type Swift.UInt16)
stdout>>> check failed at ...swift/test/1_stdlib/subString.swift, line 16
stdout>>> expected: 101 (of type Swift.UInt16)
stdout>>> actual: 103 (of type Swift.UInt16)
stdout>>> check failed at ...swift/test/1_stdlib/subString.swift, line 16
stdout>>> expected: 97 (of type Swift.UInt16)
stdout>>> actual: 99 (of type Swift.UInt16)
stdout>>> check failed at ...swift/test/1_stdlib/subString.swift, line 16
stdout>>> expected: 99 (of type Swift.UInt16)
stdout>>> actual: 101 (of type Swift.UInt16)
stdout>>> check failed at ...swift/test/1_stdlib/subString.swift, line 16
stdout>>> expected: 100 (of type Swift.UInt16)
stdout>>> actual: 102 (of type Swift.UInt16)
stdout>>> check failed at ...swift/test/1_stdlib/subString.swift, line 16
stdout>>> expected: 101 (of type Swift.UInt16)
stdout>>> actual: 103 (of type Swift.UInt16)
[    XFAIL ] SubstringTests.UTF16View
[ RUN      ] SubstringTests.UTF8View
[       OK ] SubstringTests.UTF8View
SubstringTests: All tests passed

Resolved bug number: n/a

Before merging this pull request to apple/swift repository:

[ ] Test pull request on Swift continuous integration.

Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
    Platform     | Comment
    ------------ | -------------
    All supported platforms     | @swift-ci Please smoke test
    OS X platform               | @swift-ci Please smoke test OS X platform
    Linux platform              | @swift-ci Please smoke test Linux platform

Validation Testing
    Platform     | Comment
    ------------ | -------------
    All supported platforms     | @swift-ci Please test
    OS X platform               | @swift-ci Please test OS X platform
    Linux platform              | @swift-ci Please test Linux platform

Note: Only members of the Apple organization can trigger swift-ci.

Thanks @natecook1000!

@swift-ci Please test and merge

@swift-ci Please test and merge

@swift-ci test

CI issues are unrelated.


[Feature] Wandering ship tracker

It would be nice to be able to report Luterra/Vernese ship by indicating which channel they are on and the time left

Duplicate of #17. Still unsure if I'll do this or not, but probably lower priority in any case.


Fix lab10+ requests to allow omitting the trailing slash in a URL

Does this work when resolve_url receives a current URL without a terminating slash?

Yes. That's why I had to edit resolve_url in lab6. Without that fix it wasn't working.

(There is also a test in this PR for that situation).


TOP: Create New Volunteer Hour Entry

A user can login, upon logging in, enter the date and hours they worked from

Adam has said that he wants the timestamping function, i.e. just a 'Check In' / 'Check Out' button for a volunteer that records the current time. The manual time/date entry should be on the admin backend.

So the timestamping function. Can you or Adam clarify. What sort of details are required for the timestamp to work? Obviously we need a record to record the time in. Does he want the exact time in and time out and then we factor and update the hours and minutes spent?


Fix for #200257 plus existing trailing non-numerics regex fix

This is a draft PR for a fix for issue #200257
Whilst figuring how to fix the issue I created, it appeared that the regex at terminalLinkOpeners.ts:111 was incorrect. Here are the old and new regex side by side, with what I expect the original coder intended. I also tested grep output with filenames/line numbers, and that seems to be correct also.

The trailing period issue has also been fixed with a new text.replace step with (hopefully) a correct regex, that currently only removes trailing periods from line/column numbers (for instance, "test.ts." should be left alone).
The big question possibly is, is there any reason why a trailing period on a link should remain? If not, I guess you could just remove any trailing period regardless of it's preceding text.

@microsoft-github-policy-service agree

Thanks Tyriar
Regarding the trailing period issue, although this will catch this:
Check your code at Test.ts:10.
It won't catch this:
Check your code in Test.ts.
If I changed the trailing period regex line to
text = text.replace(/\.$/, '');
Then it would gracefully handle Test.ts., but would in theory break anyone using trailing periods in filenames (if that is even going to be a concern).

It's hard to say what the right behavior is here as these links are meant to be very simple and driven by the terminal.integrated.wordSeparators setting. I guess it is preferable to go with the optimistic case and remove the . as excluding it will show results both with and without the ., but including it will only show results including the .


add jscs

@blond is there any recommended set of rules for enb techs?

No, better ask me f you have problems ;)

My problem is what styles to use.
I'm to young in js world and I don't have own prefered style set.
Would be great just copy-paste jscs rule set from somewhere.

https://github.com/enb-bem/enb-bh/blob/master/.jscs.js

resolved in https://github.com/bem-incubator/enb-ng-techs/commit/19f57ec030b71a8ee6bbccc36006c5752bdb95a3


VSCode Version:

VSCode Version:
OS Version:

Steps to Reproduce:

Does this issue occur when all extensions are disabled?: Yes/No

windows 7 64

No actual information given.


Clarified when methods should end in Async

Clarified when methods should end in Async
Related to #10734
Addresses dotnet/roslyn#33082

@AArnott may be good to review.


Update documentation with a chapter about changed stuff

Godot version
4.x
System information
Windows 11
Issue description
I find hit hard to have to search trough "discussions" and blog posts about what has changed between 3.x to 4.x, can't we have a section in the latest manual / documentation that covers this? when i search for "hint_color" i want to be presented with a page that says it has been converted to "source_color". instead of scouring the web about and answer when it should be in the documentation. if it is then the search function is flawed :P
Steps to reproduce
Simple, search for it.
Minimal reproduction project
https://docs.godotengine.org/en/latest/search.html?q=hint_color&check_keywords=yes&area=default#

There is a page already which is where you are meant to go, though it's somewhat incomplete in parts: https://docs.godotengine.org/en/stable/tutorials/migrating/upgrading_to_godot_4.html
Though this specific rename is missing there


CVE-2024-44082: Harden all image handling and conversion code

It was recently learned by the OpenStack community that running qemu-img
on un-trusted images without a format pre-specified can present a
security risk. Furthermore, some of these specific image formats have
inherently unsafe features. This is rooted in how qemu-img operates
where all image drivers are loaded and attempt to evaluate the input data.
This can result in several different vectors which this patch works to
close.
This change imports the qemu-img handling code from Ironic-Lib into
Ironic, and image format inspection code, which has been developed by
the wider community to validate general safety of images before converting
them for use in	a deployment.
This patch contains functional changes related to the hardening of these
calls including how images are handled, and updates documentation to
provide context and guidance to operators.


Feedback

Well done, good work.

Document all the created functions
In your .py files, Interface part, check and rectify #Output
Better comment the components of the interface

add useless things to .gitignore : .vs, .vscode cache, etc ...

include screenshots in your readme ...

Consider this feedback for the second project also

Hello Emmanuel, thank you for the feedback. Here's a list of actions taken:

Document functions ✅
Rectify #Output in Interface ✅
Better comments on components of the interface ✅
Add useless things to .gitignore ✅
Include screenshots in readme ✅

I would be grateful for your review and comments. Thank you.

AltLayer Airdrop Season One Update

🚀 Exciting Announcement! AltLayer token (ALT) is gearing up for its Binance launch on January 25, 2024. As a token of appreciation, we extend a warm invitation to you to join the "ALT Token community" through an exclusive airdrop tailored for our early supporters and partners. Here's a quick overview:

Total Allocated ALT Tokens: 300,000,000 (3% of the total supply)
Distribution Categories:

Ethereum Mainnet
Binance Mainnet

For a comprehensive breakdown of criteria and further details, refer to the complete announcement Oficial Website.
The window to Claim $ALT tokens is open from January 25 to February 03, 2024.
Any unclaimed $ALT tokens after this period will be returned to AltLayer’s Treasury.
We deeply appreciate your contribution to AltLayer's success! Stay tuned for more exciting developments in Season One.
Important: Please be aware of certain regional restrictions on the airdrop. Review the disclaimer before participating.
ricardoprins, @Jammasanju, @SucreCC, @bibil85, @zhiyuan-lu, @codeogc, @Youhan, @M3rkr, @artcz, @egorsmkv, @skrzepto, @hxpGit512, @askmetoo, @menxia, @johncordeiro, @ihongChen, @chrinide, @ethan1027, @animaltechno, @SooWenQiao


Feature/refactor quit if only left

Only take action when we are in NERDTree window, and no more
window with normal buffer open.
Before quitting Vim, delete the buffer so that the '0 mark
is correctly set to the previous buffer. This avoids NERDTree
buffer being the last displayed buffer if Vim fails to quit
due to the last file in the argument list has not been edited
yet.
Then quit as usual, we have autocmd nesting open, so the 'quit'
will trigger other plugin window's quiting behavior. If we are
quiting Vim, our current buffer is successfully reset to the
last file buffer, no need to warry about failure.

I see you are a fan of linear commit history and git cherry-pick,
but git merge --no-ff could keep the merge history which is better
I think, just my thought, nothing important.

@jistr I was also currently getting the problem of the nerd tree window resizing to most of the screen size after updating a couple days ago.  I don't have the g:nerdtree_tabs_synchronize_view option enabled.  I was able to roll-back to fix the problem but the issue definitely exists in master right now.

@sentilesdal Did you try with the very latest master? :) I think the issue has been fixed a few days ago by reverting a commit. See issue #84

@jistr, I pulled last week sometime so I'm not sure.  I'll try again later tonight after work ;) to cofirm.  Thanks!


Extending a tuple with an optional member causes an error

Search terms
tuple, optional, convertType
Expected Behavior
Docs should be generated for valid code.
Actual Behavior
Extending a tuple type that includes an optional member causes TypeDoc to exit with an unexpected error. This might be related to #1439.
Steps to reproduce the bug
Try to generate docs for this:
export function fails<T extends [foo: any, bar?: any]>(a: T): T {
  return a;
}

This causes an error Cannot read property 'name' of undefined to be thrown from here https://github.com/TypeStrong/typedoc/blob/0c3b1a0c4ea9168a0500ae13422f35935654df83/src/lib/converter/types.ts#L819
due to elements having a length that's one greater than the length of namedMembers.
Minimal reproduction: https://gist.github.com/eemeli/a860c474d8a8a221985aa3fc883baed0
Environment

Typedoc version: 0.20.10
TypeScript version: 4.1.3
Node.js version: 14.9.0
OS: macOS Mojave 10.14.3

Oh shoot.. this is another instance of #1408. TS does weird things with generic constraints. Fixed in 0.20.11

Oh shoot.. this is another instance of #1408. TS does weird things with generic constraints. Fixed in 0.20.11


Canon Coaching Gunman Minigame doesn't work at 60+ fps

Gun doesn't fire in the Canon Coaching Gunman minigame if above 60 fps. Disabling the fps unlock in the INI fixed the issue. The Swordsman version of the Canon Coaching minigame works fine at 120 fps though.
Would an option that uncaps fps in cutscenes, but keeps the cap in place for minigames be possible?

Thanks for reporting this, at the moment the FPS uncap fix is very simple and just removes the ability to cap FPS entirely. I will look and see if I can add some logic to it so that it uncaps FPS only when in cutscenes.
I remember the other Yakuza/Like a Dragon games having FPS caps during minigames so I assume they have some logic tied to framerate in there.

Can you give this version a try? I have changed the behaviour of the FPS uncapping to only affect cutscenes. I've tested out 2 minigames and they both cap at 60fps as expected.

Everything seems to work as expected. Thanks for the update.

Great, I'll close the issue now.


Notebook Launcher not Working

I am trying to create a Notebook Launcher in jupyter lab, but i get the next error

In the contanier logs I get the following Permision denied:

sagemaker-notebook-container    | [I 21:45:05.171 NotebookApp] Creating new notebook in /
sagemaker-notebook-container    | [W 21:45:05.188 NotebookApp] 403 POST /api/contents/?1566942305168 (<IP_ADDRESS>): Permission denied: Untitled.ipynb

Going back, when using docker-compose up sagemaker-notebook-container, i get the following:

Starting sagemaker-notebook-container ... done
Attaching to sagemaker-notebook-container
sagemaker-notebook-container    | id: ‘jovyan’: no such user
sagemaker-notebook-container    | Executing the command: jupyter notebook
sagemaker-notebook-container    | [I 21:38:37.768 NotebookApp] JupyterLab extension loaded from /home/ec2-user/anaconda3/lib/python3.7/site-packages/jupyterlab
sagemaker-notebook-container    | [I 21:38:37.768 NotebookApp] JupyterLab application directory is /home/ec2-user/anaconda3/share/jupyter/lab
sagemaker-notebook-container    | [I 21:38:37.777 NotebookApp] [nb_conda] enabled
sagemaker-notebook-container    | [I 21:38:38.024 NotebookApp] Serving notebooks from local directory: /home/ec2-user/SageMaker
sagemaker-notebook-container    | [I 21:38:38.024 NotebookApp] The Jupyter Notebook is running at:
sagemaker-notebook-container    | [I 21:38:38.024 NotebookApp] http://18959a11f25e:8888/?token=060991626e63a4541e8faa40cdf46d9f97b03874ee2d90a7
sagemaker-notebook-container    | [I 21:38:38.024 NotebookApp]  or http://<IP_ADDRESS>:8888/?token=060991626e63a4541e8faa40cdf46d9f97b03874ee2d90a7
sagemaker-notebook-container    | [I 21:38:38.024 NotebookApp] Use Control-C to stop this server and shut down all kernels (twice to skip confirmation).
sagemaker-notebook-container    | [C 21:38:38.028 NotebookApp]
sagemaker-notebook-container    |
sagemaker-notebook-container    |     To access the notebook, open this file in a browser:
sagemaker-notebook-container    |         file:///home/ec2-user/.local/share/jupyter/runtime/nbserver-9-open.html
sagemaker-notebook-container    |     Or copy and paste one of these URLs:
sagemaker-notebook-container    |         http://18959a11f25e:8888/?token=060991626e63a4541e8faa40cdf46d9f97b03874ee2d90a7
sagemaker-notebook-container    |      or http://<IP_ADDRESS>:8888/?token=060991626e63a4541e8faa40cdf46d9f97b03874ee2d90a7

it seems maybe the problem is in the user id "jovyan". If it is then, how can I change the id?

This message is produced by Jupyter's start.sh file, it doesn't affect anything so you can ignore it.

id: ‘jovyan’: no such user

Have you updated this line in docker-compose.yml to use a proper folder in your machine? I put /Users/foobar/projects/SageMaker only as an example.

/Users/foobar/projects/SageMaker:/home/ec2-user/SageMaker

I'm glad you managed to get it working.


CommonHTML: Pass full font URL to Ajax.fileURL

Rather than just passing the base font dir, pass the
full font file path. This allows for user code that overrides
fileURL() to properly map font file URLs as well.
I need this because in my application I am loading MathJax from IndexedDB, which means all mathjax files become blob urls, and my application has to map all MathJax URLs to Blob URLs, which it does by monkeypatching Ajax.fileURL() in the AuthorInit() function. See https://github.com/kovidgoyal/calibre/blob/master/src/pyj/read_book/mathjax.pyj#L15

Closed only for technical reasons -- PRs must go to to the develop branch. See also https://github.com/mathjax/MathJax/blob/master/CONTRIBUTING.md#submitting-pull-requests

In particular, we'd need https://www.mathjax.org/cla/ but maybe wait until @dpvc comments on the actual code :smile:

I am not particularly attached to the code. All I care about is having some way to implement my end goal -- which is user controlled mapping of web font URLs. So if you agree with this patch let me know and I'll jump through whatever hoops you need for accepting PRs. Otherwise, I'll open a bug report asking for this feature and let you implement it however you like.

Thanks so much, @kovidgoyal! Let's see what Davide writes.

I guess I'm OK with the changes in principle, but I'd want to do it very slightly differently, and also do the corresponding thing in the HTML-CSS @font-face creation as well (for consistency).  I take it you are dropping the .eot and .otf references, which is why you are using if (src) ....  The current fileURL() method never returns falsey values, so that test is redundant as far as MathJax is concerned.  I feel a little funny adding code just for one person's application, but I guess it doesn't hurt too much.
Since I want to add the same to HTML-CSS, why don't I make the changes and we won't have to bother with a CLA from you.

Fine by me. Yes, I am dropping those, as otherwise it leads to error messages in the console when the security policy in the browser prevents those files from being loaded 9I have MathJax running in an isolated iframe).  If you dont like it, I suggest making it a separate option in the CommonHTML backend that defaults to [eot, woff, otf].
Do you want me to open a bug report?

I feel a little funny adding code just for one person's application, but I guess it doesn't hurt too much.

Let's discuss this at the next F2F?

What ever happened to this? @kovidgoyal's fork is still used for calibre, and is now 477 commits behind this repository, would be nice if this was upstreamed and then general improvements automatically made use of by calibre.

Nothing was done about it.  There is, however, a way to handle this without the need for changes to MathJax itself.  You can use
<script type="text/x-mathjax-config">
(function () {
  var StyleString = MathJax.Ajax.StyleString.bind(MathJax.Ajax);
  MathJax.Ajax.StyleString = function (styles) {
    return StyleString(styles).replace(/url\('?(.*?)'?\)/g, function (match, url) {
      //  ... translage url to whatever you want ...
      return url;
    });
  };
})()
</script>

to trap and replace all the url() references in the stylesheets.  Place this just before the script that loads MathJax.js itself.

@dpvc that is not sufficient. calibre runs mathjax inside a sandboxed iframe, which means all URLs, including those for other js files have to be re-written so that they can be loaded from within the sandbox, because of CSP restrictions.

I had expected that you would continue to have a modified MathJax.Ajax.fileURL() to handle those other cases.  Your pull request only deals with the font URLs, so that is what I provided above.  If you did
<script type="text/x-mathjax-config">
(function () {
  var StyleString = MathJax.Ajax.StyleString.bind(MathJax.Ajax);
  MathJax.Ajax.StyleString = function (styles) {
    return StyleString(styles).replace(/url\('?(.*?)'?\)/g, function (match, url) {
      return MathJax.Ajax.fileURL(url);
    });
  };
})()
</script>

I think that would be equivalent to your pull request.  Of course, you would still want to override the fileURL() method in order to get whatever URL translation you need.  You can do that in a similar way to the above, so you should be able to get the adjustments you need through configuration, without having to modify MathJax itself.

ah ok that makes sense, thanks :)


Control plane upgrade from 1.0.6 to 1.1.0 resulted in a batch of 503's

I decided to test some load against a simple echo endpoint during a 1.0.6 to 1.1.0 upgrade of about 200 requests/second.
We experienced a whole batch of 503s (43 to be precise):

It's important that we're able to roll out control plane upgrades without any downtime!  Maybe this will be improved in 1.1.0 with the transparent retries?
Are you doing testing of loaded control planes as part of upgrade testing?

/cc @nmittler @costinm

yes, we are doing continuously ping test (probably not much load) think we are testing ~85% passing rate.
If you are NOT using mixer, it is probably good to disable mixer or mixer check before the upgrade, because that is the only thing intercepts the app flow.

We have policyCheckFailOpen = true, which I thought was doing the same thing?
So just to be clear, you're saying there's currently not zero downtime method of upgrading the istio control plane?

I don't think these two params are the same. policyCheckFailOpen will perform the policy check but still allow the call to go through to mixer which could get stuck when mixer is down, where disablePolicyCheck will disable check completely.
Our test currently checks for 85% passing rate:  https://github.com/istio/istio/blob/release-1.1/tests/upgrade/test_crossgrade.sh#L47  In 1.0.x we didn't implement pod disruption budge (which is added in 1.1) as that is the k8s support to help ensure 1 replica stays up for a given deployment, all times.  cc @ostromart if I missed anything.
I'd defer to mixer team for mixer related upgrade issue.  cc @mandarjog

I think this can be closed?  @stono indicated he was able to not get 503 by disable mixer check, leverage pod disruption budget and rolling strategy.  I opened an issue to improve our rolling strategy configuration:  https://github.com/istio/istio/issues/13552

pls reopen if needed.  for 1.0.6, we didn't implement pod disruption budget so it will have issue, however from 1.1 to 1.1.x, PDB is in place.