Can I config handler for JavaLanguageFrontEnd?

Hello, I'm using JavaLanguageFrontend and I found that modifiers of classes are discarded during handleJavaClassOrInterfaceDeclaration. Besides, if there is EnumDeclaration inside a class, the enum is also discarded.
Now I want to rewrite handleJavaClassOrInterfaceDeclaration and change declarationHandler of JavaLanguageFrontend. However, declarationHandler is private and there isn't setter method. I'm wondering how I can cope with the problem.

Hi! Discarding the modifiers is not intentionally, we just had not the time yet to implement this. If you have any interest in implementing this, we would be very interested, unfortunately we have not yet set up all the processes for external contributions through CLAs etc., so it might take a while for us to accept it into the main branch.
In the meantime, if it helps, we could set declarationHandler to protected so that you can extend the JavaLanguageFrontend with your own extended implementation

Hi! Discarding the modifiers is not intentional, we just had not the time yet to implement this. If you have any interest in implementing this, we would be very interested, unfortunately we have not yet set up all the processes for external contributions through CLAs etc., so it might take a while for us to accept it into the main branch.
In the meantime, if it helps, we could set declarationHandler to protected so that you can extend the JavaLanguageFrontend with your own extended implementation

I tried to defined a subclass of DeclarationHandler and set declarationHandler via Reflection. However, my self-defined subclass isn't ParameterizedType and ClassCastException is throwed when the following code is invoked  (Class<S>)   ((ParameterizedType) getClass().getGenericSuperclass()).getActualTypeArguments()[1]; to init typeOfT of Handler. It seems that we can't set declarationHandler  since the existence of typeOfT even declarationHandler is protected.

Hi! Discarding the modifiers is not intentional, we just had not the time yet to implement this. If you have any interest in implementing this, we would be very interested, unfortunately we have not yet set up all the processes for external contributions through CLAs etc., so it might take a while for us to accept it into the main branch.
In the meantime, if it helps, we could set declarationHandler to protected so that you can extend the JavaLanguageFrontend with your own extended implementation

I tried to defined a subclass of DeclarationHandler and set declarationHandler via Reflection. However, my self-defined subclass isn't ParameterizedType and ClassCastException is throwed when the following code is invoked  (Class<S>) ((ParameterizedType) getClass().getGenericSuperclass()).getActualTypeArguments()[1]; to init typeOfT of Handler. It seems that we can't set declarationHandler since the existence of typeOfT even declarationHandler is protected.

I have addressed this particular issue in #672 although I want to make it a bit more robust.


BrowserWindow's webPreferences.nodeIntegration not work

On an Render Process Window, i want to  open a new window without Node:
var BrowserWindow = require('remote').require('browser-window');
var testWin = new BrowserWindow({width:650, height:480,webPreferences: { nodeIntegration: false }}); testWin.loadUrl('http://www.baidu.com');
testWin.webContents.openDevTools();

then i checked in console of the new window's DevTool, it still has the rights to access node(for example: successfully visiting the require function).
Don't know why

Okay! I just learn from https://github.com/atom/electron/blob/master/docs/api/browser-window.md, it shows the key in BrowserWindow's options do use camel-case naming, but actually using delimiter '-' is the right way.
Still Don't know why using that style for doc?

The webPreferences.nodeIntegration style is only available after v0.35.x, you should view the documents that match the version of Electron you use. The README of docs explained this.

sorry for my carelessness, the electron-prebuilt in npm's registry is behind the HEAD version


bump spark version

Codecov Report

Merging #150 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #150   +/-   ##
=======================================
  Coverage   85.37%   85.37%
=======================================
  Files          34       34
  Lines        1922     1922
  Branches       41       41
=======================================
  Hits         1641     1641
  Misses        281      281

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f42fb76...4f36f26. Read the comment docs.

LGTM


Make itunes compatible optional

in generated xml to address issue #1408
If this is acceptable, I'll update the rspec files as well

I think there should be a migration that turns the flag on for existing agents.  Otherwise this will break existing feeds that are expected to be the way it is now.

Good point. How would I do that?

I agree that a spec and migration are needed for this.  The migraion could probably be similar to db/migrate/20160224120316_add_mode_option_to_ftpsite_agents.rb

Sounds good. I'll have a look and try to submit later in the week.

Sorry for taking so long. Hopefully this does the trick?

Other than my one comment, looks great and worked when I tested the migration.


Maya: Validate Model Content

Changelog Description
assemblies in cmds.ls does not seem to work;
from maya import cmds

content_instance = ['|group2|pSphere1_GEO', '|group2|pSphere1_GEO|pSphere1_GEOShape', '|group1|pSphere1_GEO', '|group1|pSphere1_GEO|pSphere1_GEOShape']
assemblies = cmds.ls(content_instance, assemblies=True, long=True)
print(assemblies)

Fixing with string splitting instead.
Testing notes:

Setup model instance with geometry from two different top level parents.
Publish and verify validation fails.

assemblies in cmds.ls does not seem to work;

from maya import cmds

content_instance = ['|group2|pSphere1_GEO', '|group2|pSphere1_GEO|pSphere1_GEOShape', '|group1|pSphere1_GEO', '|group1|pSphere1_GEO|pSphere1_GEOShape']
assemblies = cmds.ls(content_instance, assemblies=True, long=True)
print(assemblies)

This for me actually works fine - it returns an empty list because assemblies returns root level nodes only. Maybe that's not what you were expecting but it is what the maya.cmds.ls flag described for assemblies. :)
Anyway, there's another downside to allowing adding the geometry into the model instance directly. Are we expecting the output publish to then EXCLUDE the parents, or INCLUDE the parents? The maya scene publish for a model will by default include them for e.g. which might be the unexpected behavior? If we were expecting to EXCLUDE them the technically they will always end up not being a unique top level node (since it'd be each individual geometry mesh at the top level that was added to the instance) and thus the validation doesn't make too much sense. To me it's a bit unclear what the expected behavior is actually.

Anyway, there's another downside to allowing adding the geometry into the model instance directly. Are we expecting the output publish to then EXCLUDE the parents, or INCLUDE the parents? The maya scene publish for a model will by default include them for e.g. which might be the unexpected behavior? If we were expecting to EXCLUDE them the technically they will always end up not being a unique top level node (since it'd be each individual geometry mesh at the top level that was added to the instance) and thus the validation doesn't make too much sense. To me it's a bit unclear what the expected behavior is actually.

I agree its not very clear.
Would you mind making an issue for this? Dont think this PR, which is just a bugfix, is the place to evaluate and implement any of this.


Bounding box error when initializing a graph

With Cytoscape v3.4.2 and cytoscape-dagre v2.2.2, I'm getting the following error when initializing a fairly large, compound graph:
ERROR TypeError: Cannot read property 'x1' of undefined
    at updateBoundsFromBox (cytoscape.cjs.js:8653)
    at cachedBoundingBoxImpl (cytoscape.cjs.js:9172)
    at Collection.push../node_modules/cytoscape/dist/cytoscape.cjs.js.elesfn$j.boundingBox (cytoscape.cjs.js:9233)
    at update (cytoscape.cjs.js:8507)
    at Element.push../node_modules/cytoscape/dist/cytoscape.cjs.js.elesfn$j.updateCompoundBounds (cytoscape.cjs.js:8614)
    at Element.dimImpl [as width] (cytoscape.cjs.js:9342)
    at Element.outerDimImpl [as outerWidth] (cytoscape.cjs.js:9370)
    at Element.layoutDimensions (cytoscape.cjs.js:10602)
    at Layout.DagreLayout.run (cytoscape-dagre.js:158)
    at setElesAndLayout (cytoscape.cjs.js:17611)

The graph is not rendered and the "ready" event is never emitted. This happens consistently in Firefox 65 but only rarely in Chrome 72.
Unfortunately I cannot attach the graph for reproduction as the data is under an NDA, but if you need specific information I'll try my best to provide it. When reducing the number of elements (from 102 nodes and 135 edges), the error doesn't seem to occur.

Unfortunately, there's nothing that we can do until we have a reproducible test case including data.  You could consider anonymising your existing data by removing and renaming the appropriate fields.  The output topology and style should be all that matters.

I've put together a StackBlitz to reproduce the issue and eventually managed to find what exactly triggers it, so anonymizing will not be necessary.
So first, while the stack trace seems to imply that it is Dagre-related, the issue actually appears with other layouts (e.g. breadth-first). Then, it looks like it is triggered by a node which has a parent node but also the style display: 'none'.
// In the stylesheet:
{
  selector: 'node.hidden',
  style: {
    display: 'none',
  }
}

// In the node list:
{
  "data": {
    "id": "C1",
    "name": "Compound node",
    "type": "Category"
  }
},
{
  "data": {
    "id": "2",
    "name": "Hidden node",
    "parent": "C1",
  },
  "classes": "hidden"
}

Here's the StackBlitz for quick reproduction (remove the "hidden" class from the last node in the list to have a working graph): https://stackblitz.com/edit/cytoscape-dagre-42?file=src/app/graph-data.ts

It doesn't make sense to include display:none elements in a layout:  They take up no space.
I could remove the exception, but you'll still get no result for display:none elements.

In my application, 'hidden' is a class added or removed to some nodes at runtime, through a button. But in some cases, I need to recreate the graph and have them still hidden, so that I can show them again later with the same button (by removing the class).
This is why I sometimes have display: none nodes in the initial dataset. They're meant to be displayed later, and it is convenient not having to add them at runtime - it doesn't trigger any errors if they don't have a parent node.

I thought this was just an issue of specifying display:none element in a layout, but it turns out it's a more general issue.  See https://github.com/cytoscape/cytoscape.js/issues/2339


Adding dev container and updating configs

Adding devcontainer for project
Updating launch.json to only include relevant config and updating type to debugpy

cc @luabud


Input names mismatch while converting ResNet-18(number of input names provided (1) did not match number of inputs (103))

Describe the bug
I am trying to convert ResNet-18 from pytorch to keras. But, I am getting the following error.
Traceback (most recent call last):   File "convert_py2keras.py", line 100, in <module>     model_ke = pytorch_to_keras(model_py, input_var, [(3, 224, 224,)])     File "/home/vamsidhar/miniconda3/lib/python3.6/site-packages/pytorch2keras/converter.py", line 76, in pytorch_to_keras     torch.onnx.export(model, args, stream, verbose=verbose, input_names=input_names, output_names=output_names)   File "/home/vamsidhar/miniconda3/lib/python3.6/site-packages/torch/onnx/__init__.py", line 25, in export     return utils.export(*args, **kwargs)   File "/home/vamsidhar/miniconda3/lib/python3.6/site-packages/torch/onnx/utils.py", line 84, in export     _export(model, args, f, export_params, verbose, training, input_names, output_names)   File "/home/vamsidhar/miniconda3/lib/python3.6/site-packages/torch/onnx/utils.py", line 142, in _export     _set_input_and_output_names(trace.graph(), input_names, output_names)   File "/home/vamsidhar/miniconda3/lib/python3.6/site-packages/torch/onnx/utils.py", line 201, in _set_input_and_output_names     set_names(list(graph.inputs()), input_names, 'input')   File "/home/vamsidhar/miniconda3/lib/python3.6/site-packages/torch/onnx/utils.py", line 197, in set_names     % (descriptor, len(name_list), descriptor, len(node_list))) RuntimeError: number of input names provided (1) did not match number of inputs (103)
To fix it, I modified input_names in converter.py of pytorch2keras from input_names = ['input_{0}'.format(i) for i in range(len(args))] to  input_names = ['input_0']+['layer_{0}'.format(i) for i in range(len(model.state_dict().items()))].
This fixed the above error and the model got converted to onnx, but failed to convert to keras with the following error.
Traceback (most recent call last):   File "convert_py2keras.py", line 100, in <module>     model_ke = pytorch_to_keras(model_py, input_var, [(3, 224, 224,)])     File "/home/vamsidhar/miniconda3/lib/python3.6/site-packages/pytorch2keras/converter.py", line 82, in pytorch_to_keras     verbose=verbose, change_ordering=change_ordering)   File "/home/vamsidhar/miniconda3/lib/python3.6/site-packages/onnx2keras/converter.py", line 94, in onnx_to_keras     input_shape = input_shapes[i] IndexError: list index out of range
Giving the input name of one input layer is not working as it expects names for all the 103 layers(conv,pool,relu). Leaving the input_names parameter is also not working. Do I need to give shapes of all the layers for the conversion to work?

Hello @vamsidharmuthireddy.
Please, show your converter function call. Do you use modified resnet-18 or torchvision version?

I tried on both. I am getting the same error even while using test code from repo

Please try again with libraries versions listed below:
tensorflow                       1.14.0
Keras                            2.3.0
onnx2keras                       0.0.12
pytorch2keras                    0.2.3
torch                            1.2.0
onnx                             1.5.0

Thanks for the swift response. Models are getting generated now. Just to avoid similar issues in future, please update your requirements.txt with versions.


Running FD on gait2392 model from tutorial results in unexpected motion

Reported by Beta tester

Impossible to reproduce with no details, closing


Getting java.lang.NullPointerException for a query.

Issue
Getting
ProcessingException(errorCode:150, message:SQLParsingError:
java.lang.NullPointerException: _Fields.STRING_VALUE
	at java.base/java.util.Objects.requireNonNull(Objects.java:246)
	at org.apache.pinot.common.request.Literal.setStringValue(Literal.java:601)
	at org.apache.pinot.common.utils.request.RequestUtils.getLiteralExpression(RequestUtils.java:124)
	at org.apache.pinot.sql.parsers.CalciteSqlParser.toExpression(CalciteSqlParser.java:676))

when I wanted to try some non-aggregated functions
SELECT CASE WHEN "some_field" IS NOT NULL THEN "some_field" ELSE NULL END AS "some_alias"
FROM "some_table"

The type of "some_field" can be String, Int, Float, List etc.

Use Case of this Query:
Wanted to explicitly return Null if it is Null value, instead of returning default value (0, or MIN_INTEGER or 'null' ) to outside.

@shenyu0127 Can you please take a look?

If you run a Pinot that is built on HEAD, you will not get this error.
Details:

You were running a Pinot that is a few months old. (The line 601 of Literal.java is Objects.requireNonNull means it is before https://github.com/apache/pinot/pull/10217).
I tested your query using a Pinot built on HEAD and it worked. You may need to add OPTION(enableNullHandling=true) in the query.

@shenyu0127 Thank you for your reply

May I ask the full query example with OPTION(enableNullHandling=true)? We have turned it on in table configuration. Is it good enought?
Is the latest version of pinot 0.12.1 ? Unfortunately I still get the error.

If you put a ; after your SET statement, your query will be parsed correctly.
Your query will not work in v0.12.1.

The IS NOT NULL feature is added in https://github.com/apache/pinot/pull/10594, which is not included in v0.12.1.
If you build a Pinot from source on HEAD (https://docs.pinot.apache.org/basics/getting-started/running-pinot-locally), your query will work. Or you can wait for the next Pinot release to include this feature.

Closing this as it is working on pinot 1.0.0


WIP Create Loan ID Manager class

WIP to address issue #99.
The next (and final) step is

Integrating the Loan ID Manager class into the AddressBook class (and its storage)

Pull Request Test Coverage Report for Build 300

84 of 85 (98.82%)  changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.3%) to 92.501%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/main/java/seedu/address/model/loan/LoanIdManager.java
49
50
98.0%

Totals

Change from base Build 294:
0.3%

Covered Lines:
1690

Relevant Lines:
1827

💛  - Coveralls


Prettier for tests

Tests look good, and there's never enough of them to cover all the use-cases :)


Create policy to allow service migrations in user interface of blue teams

Service Level Value to allow changing parrent host to some other host in the same team


[Dynamic Region] Some large regions did not split as expected

Bug Report

What version of TiKV are you using?
./tikv-server -V
TiKV
Release Version:   6.1.0-alpha
Edition:           Community
Git Commit Hash:   a23fd680807d35d60828dc298cf99eca7448faa2
Git Commit Branch: HEAD
UTC Build Time:    2022-05-19 04:37:08
Rust Version:      rustc 1.60.0-nightly (1e12aef3f 2022-02-13)
Enable Features:   jemalloc mem-profiling portable sse test-engine-kv-rocksdb test-engine-raft-raft-engine cloud-aws cloud-gcp cloud-azure
Profile:           dist_release
2022-05-19T18:30:12.351+0800	INFO	k8s/client.go:107	it should be noted that a long-running command will not be interrupted even the use case has ended. For more information, please refer to https://github.com/pingcap/test-infra/discussions/129
./pd-server -V
Release Version: v6.1.0-nightly
Edition: Community
Git Commit Hash: 85918318d7a127a845af25e208b82b153820fc0d
Git Branch: heads/refs/tags/v6.1.0-nightly
UTC Build Time:  2022-05-18 10:57:30
2022-05-19T18:30:12.527+0800	INFO	k8s/client.go:107	it should be noted that a long-running command will not be interrupted even the use case has ended. For more information, please refer to https://github.com/pingcap/test-infra/discussions/129
./tidb-server -V
Release Version: v6.1.0-nightly
Edition: Community
Git Commit Hash: 381e870c5ca018d9b5b6e89233d2cbd9a3b41cac
Git Branch: heads/refs/tags/v6.1.0-nightly
UTC Build Time: 2022-05-18 11:04:58
GoVersion: go1.18.2
Race Enabled: false
TiKV Min Version: v3.0.0-60965b006877ca7234adaced7890d7b029ed1306
Check Table Before Drop: false
What operating system and CPU are you using?
8core、16GB
Steps to reproduce
update config repeatedly while run tpcc
[2022/05/19 18:42:08.656 +08:00] [INFO] [cmd.go:124] ["Start remote command"] [cmd="go-tpc tpcc run -D tpcc --host tc-tidb.glh-dynamic-regions-jw8pv -P4000 --warehouses 1000 -T 64 --time 36000m --ignore-error '2013,1213,1105,1205,8022,8027,8028,9004,9007,9001'"] [nodename=benchtoolset]
What did you expect?
big region can split
What did happened?
current config
"coprocessor": {
"split-region-on-table": false,
"batch-split-limit": 10,
"region-max-size": "800MiB",
"region-split-size": "512MiB",
"region-max-keys": 8000000,
"region-split-keys": 4800000,
"consistency-check-method": "mvcc",
"enable-region-bucket": true,
"region-bucket-size": "128MiB",
"region-size-threshold-for-approximate": "384MiB",
"region-bucket-merge-size-ratio": 0.33
},
"max-merge-region-keys": 1000000,
"max-merge-region-size": 100,

Some large regions did not split as expected

/pd-ctl region topsize 1

/type bug
/severity major
/assign 5kbpers

/remove-label may-affects-4.0
/remove-label may-affects-5.0
/remove-label may-affects-5.1
/remove-label may-affects-5.2
/remove-label may-affects-5.3
/remove-label may-affects-5.4
/remove-label may-affects-6.0
/label affects-6.1

duplicated with https://github.com/tikv/tikv/issues/12597.


Question about recommended dongle's

Hello,
I have an official DS4 controller.
But an unofficial bluetooth dongle from aliexpress, that supports bluetooth 2.0
When using it wired i get a solid 4 ms.
But when using bluetooth it goes between 5 and 10 ms.
If i get an bluetooth adapter with bluetooth 4.0, will my latency go down?
And why is the wired connection 4ms minimum? As i would expect that wired would be 0-1ms.

Actually vice versa for me (also dongle from aliexpress, connected to usb 3.0, bluetooth on chip CSR8510 A10), wired - 4ms, wireless - 1,5 ms..Indeed strange!

Do you have a link to the one you bought?

Do you have a link to the one you bought?
https://ru.aliexpress.com/item/Bluetooth-4-0-Dongles-Mini-USB-2-0-3-0-Bluetooth-Dongle-Adapters-Dual-Mode-adapter/32292553074.html


evictThreshold not work at Kubelet version v1.24.8

Hello, evictThreshold not work at Kubelet version v1.24.8
load5=55.39 load15=53.83 threshold=20.00 but pods dont evict from node

Hey 👋 -- thanks for the report. However, I need to point out that this project is (not officially, but effectively) unmaintained (as the last release is from 2019), and we're not using the loadwatcher ourselves in production anymore.
I'd be happy to review and accept a simple PR, but need to advise that this project would probably need extensive care to even get a proper build pipeline running. If anyone would be interested in getting in on properly maintaining this project, we'd welcome any level of engagement.


Image Flickers when conditionally rendering an image using React Context state

Brief bug description
When using variables from React.Context, the image flickers on scroll or on window width adjustments.
I tried to see if this was a problem with the way we were implementing things and tested this by creating a standard implementation of Gatsby-Plugin-Image locally. The flickering only happens when using the Kentico image component, which lead me to log the bug here.
Repro steps
clone the following repo
https://github.com/SeanDYoko/image-glitch

run yarn install, and then yarn build.
Once done, run yarn serve or yarn develop and navigate to the author page via the "Image Resolution" example link
Scroll and watch the main image under John Doe flicker

Expected behavior
We expect to be able to resize and scroll without the images flickering and reloading.
Images should behave as standard gatsby-plugin-image does.
Test environment

Platform/OS: Windows 10
Browser Chrome/firefox
Version latest

Thank you @SeanDYoko for the detailed report.
I will need to investigate and debug the issue in more detail, I was not able to find the root cause after a quick code walkthrough.
Could you also describe your use case, maybe there might be some workaround for now?
Or do you have any workaround?
From the code, you might want to try the "full width" layout for the gatsby image component: https://www.gatsbyjs.com/docs/reference/built-in-components/gatsby-plugin-image/#layout

Maybe @ascorbic or @makma have some idea what would cause the issue.
Comparison of @SeanDYoko showcase:
https://github.com/SeanDYoko/image-glitch/compare/6d37c243b7cec139940b475f3bc563d815b6630c...a4088d89e6c90584f35565d2e18990db8b8dcfc2

Hey. I don't work at Gatsby anymore, but flickering can usually be sorted out with something like React.memo. It usually means props are being updated too much

I have tested React.memo and it looks like it worked.
@SeanDYoko - could you try to do the same I did in #187 in your repro repo and try your use case?
It if is fine, I can release some beta version to test it out properly and then we can decide if the React Memo should be used all of the time, or I should rather make it configurable?

Hey. I don't work at Gatsby anymore, but flickering can usually be sorted out with something like React.memo. It usually means props are being updated too much

Thanks, @ascorbic for the quick response! I know you are already in the team Netlify, but it worth a shoot :)

I'm a little bit late, sorry, I'm afraid I have no clue what could cause the issue...

@Simply007 Sorry for the late reply, I'm going to run through this and see if I can replicate. Our work around for now is still to use Gatsby V2. I have paternity leave on Fridays until my little one is out of the NICU.

No rush @SeanDYoko, once you find some time to test it, leave a comment with your feedback!

@SeanDYoko - any update on this - did you have a chance to test it out?
Plus - I am still thinking about whether the React Memo should be used all of the time, or I should rather make it configurable - do you have any opinion on this?

Just a heads-up I am on vacation from 2021-08-05 to 2021-08-08 so I will be available next week.

@Simply007 I'm so sorry, I've not had a chance to go back and investigate this.
Our priorities shifted and I'm working on getting back to this task as soon as I can.
For an image component, it seems to me using react memo would be smart as the component's purpose is to render a static image. The image doesn't need a state update unless there's a specific reason for it to do so. So my opinion is to memoize it all of the time. I don't see a reason for it to need to not be memoized. If there is any reason you can see please let me know your thoughts and feel free to let me know!

Thanks for the message @SeanDYoko.
I will include the Momeoization in the upcoming release (7.2.0)). I have tested the issue locally and everything worked as expected, so I am quite confident about the solution.
If you find this issue again on the latest version, feel free to re-open this.

Released in https://github.com/Kentico/kontent-gatsby-packages/releases/tag/7.2.0

Thanks @Simply007, I was off last week for Paternity leave. Really appreciate this. Have a great deay


Digital-239: Custom 12 hour logout

Jira ticket

DIGITAL-239
Purpose

This PR will create a custom module to add the 12 hour log out timer for logging users out
Includes the following PRs that must be merged first

n/a
Deployment and testing
Local Setup

lando rebuild -y && lando si
QA/Testing instructions

Visit /admin/config/people/dg_autologout and verify that the time is set to 12 hours and will log a user out no matter role or use
Checklist for the Developer

[ ] A link to the JIRA ticket has been included above.
[ ] No merge conflicts exist with the target branch.
[ ] Automated tests have passed on this PR.
[ ] A reviewer has been designated.
[ ] Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

[ ] The file changes are relevant to the task objective.
[ ] Code is readable and includes appropriate commenting.
[ ] Code standards and best practices are followed.
[ ] QA/Test steps were successfully completed, if applicable.
[ ] Applicable logs are free of errors.

@clmedders this is looking good. There is some slight functionality things I noticed that seemed intermittent.  And the new custom module doesn't redirect to logout, it just logs you out. It also does not work if they are both using the modal popup. I found a few more things in the JS where the function names were off or IDs overlapped that might stop it, but apparently it's not perfect.
If we can just 'fix' the new coding standards errors that we inherited from their project, we should be good. https://github.com/GSA/digital-gov-drupal/actions/runs/12469381577


[MUGEN] Add GPT Module

Stack from ghstack (oldest at bottom):

#203
-> #202
#201
#176

Codecov Report

Merging #202 (30e5b61) into gh/langong347/15/base (17431ec) will decrease coverage by 3.87%.
The diff coverage is 0.00%.

@@                    Coverage Diff                    @@
##           gh/langong347/15/base     #202      +/-   ##
=========================================================
- Coverage                  93.07%   89.19%   -3.88%
=========================================================
  Files                         47       48       +1
  Lines                       2829     2952     +123
=========================================================
  Hits                        2633     2633
- Misses                       196      319     +123

Impacted Files
Coverage Δ

torchmultimodal/models/gpt.py
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17431ec...30e5b61. Read the comment docs.


Add configuration to make window stay on top of other windows

Cool app!
I would love to have the ability to keep the extended display window on top of all other windows. This would allow for making a video fullscreen on the extended display and mimicking Picture-in-Picture mode, when it's not available.

Yes, this would be a useful feature for many usecase. This seems to be the only feature that I'm missing from DeskPad.


Navigation view separator line does not update when the size of the content changes. Only updates when the window is resized.

Navigation view separator line does not update when the size of the section content changes. Only updates when the window is resized. Ignore the separator line above settings in the screenshot. That one is added by our code.
To repro make the content there visible, then collapsed it. The separator will still appear at the height where it should have been when the content was visible.

Steps to reproduce the bug

Steps to reproduce the behavior:

Go to '...'
Click on '....'

Expected behavior

Screenshots

Version Info

NuGet package version:
MUXC 2.5.0

Windows app type:

UWP
Win32

Windows 10 version
Saw the problem?

Insider Build (xxxxx)

October 2020 Update (19042)

May 2020 Update (19041)

November 2019 Update (18363)

May 2019 Update (18362)

October 2018 Update (17763)

April 2018 Update (17134)

Fall Creators Update (16299)

Creators Update (15063)

Device form factor
Saw the problem?

Desktop

Xbox

Surface Hub

IoT

Additional context

@ranjeshj and @karenbtlai FYI

@dannyp32 Would you be able to link a repro? I'm unable to repro this in the MUXC test app.


How often are hubot scripts run?

I have a hubot script (full disclosure: with slack adapter), that references a _members closure variable roughly like so:
module.exports = (robot) ->
    _members = (robot.brain.get('clubMembers') || []).concat CAPTAINS
   ...

where CAPTAINS is a hard coded array of strings.
I'm running into an issue where the script is getting run something around once a day, but robot.brain.get('clubMembers') is returning a falsy value, and thus _members is a list that includes only CAPTAINS.  However, running hubot show storage reveals clubMembers to be persistent, as expected, containing a list of the names of all members.
I'm not really sure why robot.brain.get('clubMembers') would ever return a falsy value.  It's as though this script gets rerun while redis is restarting and it returns null.  Do you have any insight as to why this might happen?
Thank you!!

Are you running your bot on heroku? My first crazy idea:

bot is running on heroku
heroku kills the dyno due to low activity
sending a slash command wakes up the bot
bot hasn't finished loading when it processes the command (brain is empty)
when you run show storage the bot has finished loading and gives the expected reply

Not sure if that is your issue, but an idea until I have time to think in depth.

This is less about frequency of running, but a different possible problem with the script. The modules.exports method gets run pretty early in the hubot's boot up. Depending on what brain script you are using, this line might run before the brain is loaded:
_members = (robot.brain.get('clubMembers') || []).concat CAPTAINS

To fix that, you can use this to only happen after the brain is loaded.
   robot.brain.on 'loaded', () ->
    _members = (robot.brain.get('clubMembers') || []).concat CAPTAINS

Actually, depending on when you robot.brain.set('clubMembers', 'some value'), the brain loading thing could account for when it's coming back as falsy.

ahh that makes a lot of sense, i'll try that!! thanks!!

@noahgrant Let us know if that doesn't work for you.

it did, sorry for not responding.  Thank you!!


Linux homeworks

Your work have conflicts with our base. It seems like you have deleted some of our original files and that is prohibited.
The files should be placed:

LICENSE
README.md
demo.png

You can download all those files from the original repo : unisatkz/studentswork  and then put them where they are originally, and then pull request again.


Not saving checkpoint when monitor is None and save_top_k is -1

🐛 Bug
When monitor is None, current will be None here
https://github.com/PyTorchLightning/pytorch-lightning/blob/6bc4490d01aed21c2d52f884d4afbeaa24a47ca0/pytorch_lightning/callbacks/model_checkpoint.py#L553
And check_monitor_top_k will return False because of that:
https://github.com/PyTorchLightning/pytorch-lightning/blob/6bc4490d01aed21c2d52f884d4afbeaa24a47ca0/pytorch_lightning/callbacks/model_checkpoint.py#L340
_update_best_and_save also doesn't take None current. raise error here: https://github.com/PyTorchLightning/pytorch-lightning/blob/6bc4490d01aed21c2d52f884d4afbeaa24a47ca0/pytorch_lightning/callbacks/model_checkpoint.py#L605
Currently, checkpointing is associated with validation, which is not necessarily always the case. I just want to save the checkpoint every k iterations.
Please reproduce using the BoringModel
Sorry, no time to reproduce for now.
To Reproduce
Use following BoringModel and post here

Expected behavior
Should save the checkpoint always if save_top_k == -1.
Environment
Note: Bugs with code are solved faster ! Colab Notebook should be made public !

IDE: Please, use our python bug_report_model.py template.

Colab Notebook: Please copy and paste the output from our environment collection script (or fill out the checklist below manually).

You can get the script and run it with:
wget https://raw.githubusercontent.com/PyTorchLightning/pytorch-lightning/master/tests/collect_env_details.py
# For security purposes, please check the contents of collect_env_details.py before running it.
python collect_env_details.py

PyTorch Version (e.g., 1.0):
OS (e.g., Linux):
How you installed PyTorch (conda, pip, source):
Build command you used (if compiling from source):
Python version:
CUDA/cuDNN version:
GPU models and configuration:
Any other relevant information:

Additional context

When monitor is None, the _save_last_checkpoint function is the one to save the model (even if save_last is True), not _update_best_and_save.
I just manually checked and it seems to work properly
def test_bug(tmpdir):
    model_ckpt = ModelCheckpoint(dirpath=tmpdir, monitor=None, save_top_k=-1, save_last=False)
    model = BoringModel()
    trainer = Trainer(
        default_root_dir=tmpdir,
        logger=False,
        max_epochs=3,
        callbacks=[model_ckpt],
    )
    trainer.fit(model)

    print(os.listdir(tmpdir))
    # ['epoch=0-step=63.ckpt', 'epoch=2-step=191.ckpt', 'epoch=1-step=127.ckpt']

Can you elaborate on what is the problem?

I see the code doing that. Interesting, let me check with my code.

I c. this is because you set save_last to False. If you set save_last to True, the checkpoints will always be last.ckpt.


Cant start with flutter snap package

Is there an existing issue for this?

[X] I have searched the existing issues
[X] I have read the guide to filing a bug

Steps to reproduce
I have installed flutter via snap on ubuntu 22.04
and try run program for the firs time but get this output
$ flutter
clang++: /snap/flutter/141/usr/lib/llvm-10/bin/../../../../lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found (required by /lib/x86_64-linux-gnu/libgtk3-nocsd.so.0)
Initializing Flutter
curl: /snap/flutter/141/usr/bin/../../lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found (required by /lib/x86_64-linux-gnu/libgtk3-nocsd.so.0)
cat: releases_linux.json: No such file or directory
jq: /snap/flutter/141/usr/bin/../../lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found (required by /lib/x86_64-linux-gnu/libgtk3-nocsd.so.0)
cat: releases_linux.jsonjq: /snap/flutter/141/usr/bin/../../lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found (required by /lib/x86_64-linux-gnu/libgtk3-nocsd.so.0)
: No such file or directory
jq: /snap/flutter/141/usr/bin/../../lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found (required by /lib/x86_64-linux-gnu/libgtk3-nocsd.so.0)
cat: releases_linux.json: No such file or directory
jq: /snap/flutter/141/usr/bin/../../lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found (required by /lib/x86_64-linux-gnu/libgtk3-nocsd.so.0)
Downloading /
curl: /snap/flutter/141/usr/bin/../../lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found (required by /lib/x86_64-linux-gnu/libgtk3-nocsd.so.0)
tar: /snap/flutter/141/bin/../lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found (required by /lib/x86_64-linux-gnu/libgtk3-nocsd.so.0)
Flutter initialization failed
Could not find working copy of Flutter

running flutter from root user does not cause any issues
and if I download SDK and extract it from archive does not cause any problems
Actual results
$ flutter --verbose
clang++: /snap/flutter/141/usr/lib/llvm-10/bin/../../../../lib/x86_64-linux-gnu/libc.so.6: version GLIBC_2.34' not found (required by /lib/x86_64-linux-gnu/libgtk3-nocsd.so.0) Initializing Flutter curl: /snap/flutter/141/usr/bin/../../lib/x86_64-linux-gnu/libc.so.6: version GLIBC_2.34' not found (required by /lib/x86_64-linux-gnu/libgtk3-nocsd.so.0)
jq: /snap/flutter/141/usr/bin/../../lib/x86_64-linux-gnu/libc.so.6: version GLIBC_2.34' not found (required by /lib/x86_64-linux-gnu/libgtk3-nocsd.so.0) cat: releases_linux.json: No such file or directory cat: releases_linux.json: No such file or directory jq: /snap/flutter/141/usr/bin/../../lib/x86_64-linux-gnu/libc.so.6: version GLIBC_2.34' not found (required by /lib/x86_64-linux-gnu/libgtk3-nocsd.so.0)
jq: /snap/flutter/141/usr/bin/../../lib/x86_64-linux-gnu/libc.so.6: version GLIBC_2.34' not found (required by /lib/x86_64-linux-gnu/libgtk3-nocsd.so.0) cat: releases_linux.json: No such file or directory jq: /snap/flutter/141/usr/bin/../../lib/x86_64-linux-gnu/libc.so.6: version GLIBC_2.34' not found (required by /lib/x86_64-linux-gnu/libgtk3-nocsd.so.0)
Downloading /
curl: /snap/flutter/141/usr/bin/../../lib/x86_64-linux-gnu/libc.so.6: version GLIBC_2.34' not found (required by /lib/x86_64-linux-gnu/libgtk3-nocsd.so.0) tar: /snap/flutter/141/bin/../lib/x86_64-linux-gnu/libc.so.6: version GLIBC_2.34' not found (required by /lib/x86_64-linux-gnu/libgtk3-nocsd.so.0)
Flutter initialization failed
Could not find working copy of Flutter
Logs

Logs
$ flutter --verbose
clang++: /snap/flutter/141/usr/lib/llvm-10/bin/../../../../lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found (required by /lib/x86_64-linux-gnu/libgtk3-nocsd.so.0)
Initializing Flutter
curl: /snap/flutter/141/usr/bin/../../lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found (required by /lib/x86_64-linux-gnu/libgtk3-nocsd.so.0)
jq: /snap/flutter/141/usr/bin/../../lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found (required by /lib/x86_64-linux-gnu/libgtk3-nocsd.so.0)
cat: releases_linux.json: No such file or directory
cat: releases_linux.json: No such file or directory
jq: /snap/flutter/141/usr/bin/../../lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found (required by /lib/x86_64-linux-gnu/libgtk3-nocsd.so.0)
jq: /snap/flutter/141/usr/bin/../../lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found (required by /lib/x86_64-linux-gnu/libgtk3-nocsd.so.0)
cat: releases_linux.json: No such file or directory
jq: /snap/flutter/141/usr/bin/../../lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found (required by /lib/x86_64-linux-gnu/libgtk3-nocsd.so.0)
Downloading /
curl: /snap/flutter/141/usr/bin/../../lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found (required by /lib/x86_64-linux-gnu/libgtk3-nocsd.so.0)
tar: /snap/flutter/141/bin/../lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found (required by /lib/x86_64-linux-gnu/libgtk3-nocsd.so.0)
Flutter initialization failed
Could not find working copy of Flutter

Flutter Doctor output

Doctor output

 $flutter doctor -v
clang++: /snap/flutter/141/usr/lib/llvm-10/bin/../../../../lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found (required by /lib/x86_64-linux-gnu/libgtk3-nocsd.so.0)
Initializing Flutter
curl: /snap/flutter/141/usr/bin/../../lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found (required by /lib/x86_64-linux-gnu/libgtk3-nocsd.so.0)
cat: releases_linux.json: No such file or directory
jq: /snap/flutter/141/usr/bin/../../lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found (required by /lib/x86_64-linux-gnu/libgtk3-nocsd.so.0)
cat: releases_linux.json: No such file or directory
jq: /snap/flutter/141/usr/bin/../../lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found (required by /lib/x86_64-linux-gnu/libgtk3-nocsd.so.0)
jq: /snap/flutter/141/usr/bin/../../lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found (required by /lib/x86_64-linux-gnu/libgtk3-nocsd.so.0)
cat: releases_linux.json: No such file or directory
jq: /snap/flutter/141/usr/bin/../../lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found (required by /lib/x86_64-linux-gnu/libgtk3-nocsd.so.0)
Downloading /
curl: /snap/flutter/141/usr/bin/../../lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found (required by /lib/x86_64-linux-gnu/libgtk3-nocsd.so.0)
tar: /snap/flutter/141/bin/../lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found (required by /lib/x86_64-linux-gnu/libgtk3-nocsd.so.0)
Flutter initialization failed
Could not find working copy of Flutter

@rajabiy
Issues specific to the snap installation need to be reported at https://github.com/canonical/flutter-snap/issues.
Closing from here.


[GCP, Azure] Cross-cloud --ping rule between GCP and Azure VMs fails.

Started up Paraglider with the following file:
server:
  host: "localhost"
  port: 8080
  rpcPort: 8081

cloudPlugins:
  - name: "gcp"
    host: "localhost"
    port: 8082
  - name: "azure"
    host: "localhost"
    port: 8083

tagService:
  host: "localhost"
  port: 8084

namespaces:
  default:
    - name: "gcp"
      deployment: "projects/project-name"
    - name: "azure"
      deployment: "/subscriptions/subscription-id/resourceGroups/resource-group-name"

glided startup paraglider_config.yaml
Created two VMs:
$ glide resource create gcp vm-gcp gcp_vm.json
Creating resource: vm-gcp
Resource Created.
tag: default.gcp.vm-gcp
uri: https://www.googleapis.com/compute/v1/projects/project-name/zones/us-east4-a/instances/vm-gcp
ip: <IP_ADDRESS>

$ glide resource create azure vm-azure azure_vm.json
Creating resource: vm-azure
Resource Created.
tag: default.azure.vm-azure
uri: /subscriptions/subscription-id/resourceGroups/resource-group-name/providers/Microsoft.Compute/virtualMachines/vm-azure
ip: <IP_ADDRESS>

both created successfully.
Following user guide to create permit rule (ping) between them - failed:
$ glide rule add gcp vm-gcp --ping default.azure.vm-azure
Adding permit list rule
Error: failed to create resource: Request failed with status code 400: {"error":"rpc error: code = Unknown desc = unable to get peering cloud infos: permit list rule target must belong to a specific cloud if it's a private address"}
Usage:
  glide rule add [<cloud> <resource name> | <tag>] [--rulefile <path to rule json file>] [--ping <tag>] [--ssh <tag>] [flags]

Flags:
  -h, --help              help for add
      --ping string       IP/tag to allow ping to
      --rulefile string   The file containing the rules to add
      --ssh string        IP/tag to allow SSH to

Whoops. There was an error while executing your command:

failed to create resource: Request failed with status code 400: {"error":"rpc error: code = Unknown desc = unable to get peering cloud infos: permit list rule target must belong to a specific cloud if it's a private address"}

I wonder if I am missing something. Thanks a lot.

I am closing this issue as I do not encounter it anymore. I will re-open if it fails again and provide more info.


BUG: Signup Validations

@itsmohit097
Description
Please provide a brief description of the issue or feature request.
Actual Behavior

signup work without any infomration

Expected Behavior

we add validation in signup so if there are any missing value we gor error message

Please describe what you expected to happen.
when we click on signup withouot any information, it still display toast message with
"Form submitted success"
Steps to Reproduce (if applicable)

Step 1 we can add validations using js

Screenshots (if applicable)
Actual:
(screenshot)

@RanjanaShenoy @dhruv8433 already assigned to someone else


Connections to the broker should be disconnected after the MArginLoader is killed

It looks like the MarginLoader doesn't set a heartbeat / idleTimeout. As a result the connections after a killed MarginLoader are not always detected by the broker and disconnected.
Heartbeat should be added to the AMQP connection.

Should be fixed with PR #82


[TESTS] #63 - Add unit tests for SfRating

Related issue
Fixes #63
Scope of work
Changed the slot names to camel case so they will work in the unit test
Checklist

[x] I followed composition rules for my component
[x] I tested the component in most common device sizes (can be tested in Storybook from viewport addon in top menu)

@leomp12 seems like a good idea for a new issue. I will merge this one though :)


Please review - missing type declararations

okayButton.TouchUpInside += (sender, e) => {
//Create Alert
var okAlertController = UIAlertController.Create ("Title", "The message", UIAlertControllerStyle.Alert);

//Add Action
okAlertController.AddAction (UIAlertAction.Create ("OK", UIAlertActionStyle.Default, null));

// Present Alert
PresentViewController (okAlertController, true, null);

};

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 704a0841-9815-7e6a-60f9-b2034dc96571
Version Independent ID: 8c41841a-09d7-c86f-0ca7-6145283cdd5f
Content: Displaying Alerts in Xamarin.iOS - Xamarin
Content Source: docs/ios/user-interface/controls/alerts.md
Product: xamarin
Technology: xamarin-ios
GitHub Login: @davidortinau
Microsoft Alias: daortin

Thanks for submitting an issue and we apologize for the delayed response. The requested updates haven't been made since the creation of the issue, and the timeline for resolution may vary based on resourcing, so the issue is being moved to an internal repo to better track it.


Please add support for 0.17

Would love my heli on my 0.17 server! Thanks in advance!

it is cooming wait a liitle bit more i test it right now

@unfunf22, does your fix also fix the remote control?

My fix does, check the current build on downloads page or my fork.


Fixed typo in Azure AD .NET Desktop (WPF) getting started

@devlead : Thanks for your contribution to the Azure documentation! The author, @jmprieur, has been notified to review your proposed change.

#sign-off


Docs: Create design docs for Button Group

Document best design practices for using Button Group.

Verified design guidelines for button group.
See Screen-cast : http://somup.com/c3iF1KuYvB
RM Link : https://next--upbeat-sinoussi-f675aa.netlify.app/design/button-group/
Thanks!


test: Add test connectionless verification

Description:
Integration test for connectionless verification
Alternatives Considered (optional):
Link to existing ADR (Architecture Decision Record), if any. If relevant, describe other approaches explored and the selected approach. Documenting why the methods were not selected will create a knowledge base for future reference, helping prevent others from revisiting less optimal ideas.
Checklist:

[x] My PR follows the contribution guidelines of this project
[x] My PR is free of third-party dependencies that don't comply with the Allowlist
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have checked the PR title to follow the conventional commit specification

coverage: 48.741%. remained the same
when pulling 5f0ff375497b8b69142a26865cdae8fa8db598fb on ATL-6401-Connectionless-Verification-Integration-Test
into c5071d5707e8c79b450f82c0c891f77d2eb26b95 on main.


add phylogenetic diversity metrics

The user measures alpha- and beta-diversity using phylogenetically-aware metrics.

[ ] Faith's Phylogenetic Diversity (PD) (#820)
[ ] weighted/unweighted UniFrac (#46)

Depends on:

[ ] add ContingencyTable (#821)
[ ] refactor TreeNode (#809)

See #730 re: PD and UniFrac implementations in IAB.


Behavior filter_chain's application_protocols when the listener has both tls_inspector and http_inspector filters

Description:
As per the documentation in https://www.envoyproxy.io/docs/envoy/latest/configuration/listeners/listener_filters/http_inspector and https://www.envoyproxy.io/docs/envoy/latest/configuration/listeners/listener_filters/tls_inspector, it seems like both the tls_inspecter and http_inspector listener filters set the application_protocols field that a filter chain can match on.
Per my understanding, the tls_inspector sets this based on the ALPN set by the client during the TLS handshake, while the http_inspector sets this to either http/1.x or http/2.
So if a listener has both the tls_inspector and http_inspector listener filters, what is the expected behavior of the value set for the application_protocols to be used in the filter_chain_match?
The documentation https://www.envoyproxy.io/docs/envoy/latest/api-v3/config/listener/v3/listener_components.proto#envoy-v3-api-field-config-listener-v3-filterchainmatch-application-protocols isn't too clear either because it doesn't describe how http_inspector filter updates this field.
For my use case, I want to be able to reliably differentiate between HTTP vs TCP traffic on the same listener via filter chain matching, irrespective of the ALPN set by clients.
[optional Relevant Links:]

Any extra documentation required to understand the issue.
Updating https://www.envoyproxy.io/docs/envoy/latest/api-v3/config/listener/v3/listener_components.proto#envoy-v3-api-field-config-listener-v3-filterchainmatch-application-protocols to describe how http_inspector affects it will be helpful.

http inspector is skipped when tls_inspector sniff out the traffic is TLS. The reason is that http inspector cannot really inspect TLS traffic.
If it is TLS traffic both servername and transport socket name is set while http inspector wont set transport socket name

http inspector is skipped when tls_inspector sniff out the traffic is TLS. The reason is that http inspector cannot really inspect TLS traffic.
If it is TLS traffic both servername and transport socket name is set while http inspector wont set transport socket name

Thanks @lambdai. What are the allowed values for application_protocols that http_inspector can set (ex. [http/1.0, http/1.1, http/2, h2c ..])?

http inspect has very limited value space, you can find it in the code.
For tls inspector, the value space is way much wider. I don't know if there is an allowlist
https://tools.ietf.org/html/rfc7301

EDIT: servername -> alpn
http inspector is skipped when tls_inspector sniff out the traffic is TLS. The reason is that http inspector cannot really inspect TLS traffic.
If it is TLS traffic both alpn and transport socket name is set while http inspector wont set transport socket name

Per the docs the http_inspector only sets application_protocol and not the transport socket. Is that correct?
What are the allowed values for application_protocol that http_inspector can set? From the code it looks like one of [http/1.0, http/1.1, http/2, h2c].

EDIT: servername -> alpn
http inspector is skipped when tls_inspector sniff out the traffic is TLS. The reason is that http inspector cannot really inspect TLS traffic.
If it is TLS traffic both alpn and transport socket name is set while http inspector wont set transport socket name

Per the docs the http_inspector only sets application_protocol and not the transport socket. Is that correct?
What are the allowed values for application_protocol that http_inspector can set? From the code it looks like one of [http/1.0, http/1.1, h2, h2c].

Ok I found the values here: https://github.com/envoyproxy/envoy/blob/da403fa7b67b9331ca1d129a4035950d2e23c752/source/common/http/utility.h#L37

@lambdai, on the inbound filter chain is there a way to distinguish between HTTP TLS vs TCP TLS traffic?
Since the TLS traffic is decrypted based on the DownstreamTlsContextspecified in the filter chain, I am not sure if there is a way to even distinguish between TCP vs HTTP when the incoming traffic is TLS encrypted.

Since the TLS traffic is decrypted based on the DownstreamTlsContextspecified in the filter chain, I am not sure if there is a way to even distinguish between TCP vs HTTP when the incoming traffic is TLS encrypted.

The inspection happens before a network filter chain is selected. The major goal of inspector is to determine the network filter chain.
Since DownstreamTlsContext is provided in filter chain which is after the inspection, there is no tls context for the inspectors.

Since the TLS traffic is decrypted based on the DownstreamTlsContextspecified in the filter chain, I am not sure if there is a way to even distinguish between TCP vs HTTP when the incoming traffic is TLS encrypted.

The inspection happens before a network filter chain is selected. The major goal of inspector is to determine the network filter chain.
Since DownstreamTlsContext is provided in filter chain which is after the inspection, there is no tls context for the inspectors.

Got it, thank you.


translation problem

Quote Style translates to 报价风格
should be translated as：引用样式  namely citation style
In addition, there is a special symbol 「」 for quotations in Chinese, can you add such an option?
example：什么什么「引用样式」什么什么

I can make the update for the wording, but as for the addition of 「」, I would need to know whether it is a single or double quote style and a name that it goes by in English so I can add it to the code as a variable.

I see that you included a lot of information on when to use quotes, which is good to know. However Quote Style does not do anything with adding quotes that were not already present. It just updates a list of single quotes to what the selected option is and the same for double quotes. Single quotes for contractions are handled by themselves before dealing with other single quotes.
Thus all that is happening is a find and replace of existing.
As for 「」 and 『』, I am not sure what their names are. I will see if I can find the quote style names since so far there are straight and smart quotes.

I think I will call it pinyin since that is where it comes from according to wikipedia (sorry if this is incorrect as I am not sure where else to look for the naming and quotation styles).

Do note that the Linter does not know the difference in languages so if you choose  「」 and 『』 as your quote style. It will not differentiate between what to use in one file versus another.

It's a problem, it seems that the easiest way is for me to type the correct symbols when typing... In fact, these symbols Chinese mainland have discarded them.

To clarify, when you say It's a problem, are you saying that you don't want this feature added as the Linter does not distinguish between languages?

I have added the the translation change to the Linter. I will break this into another issue for you for the potential addition of the Chinese citation style and see if there is a desire to get it added.

@zhl111 , here is the related issue: https://github.com/platers/obsidian-linter/issues/771
I am closing this as part of the translation change and the other issue will count as the feature request.


Add selftest for sync and aux pins

Currently there is no selftest for the sync and aux pins of revC. These should be added.
For a loop test they should be connected like on the test jig pcb: sync to A0, Aux A10 to A1 and Aux C9 to A2.
As the Aux pin headers are marked DNP, the tests for them should be optional. They should probably get their own command like "pins-aux" and "pins-aux-loop".
These tests also require the internal pullups on the ice40 which are not yet supported in nmigen.

Sync to A0?

Yeah. When executing "pins-sync-loop" the user is required to connect the sync pin to port A pin 0.
I don't like looping Aux together as they could probably have a short between them. Connecting them to port A, which was tested independently by the other tests, seems to be a better idea to me.

Makes sense


support fish

create fish-ported script for the bash completions and have installation instructions

hm it looks like someone beat me to it: https://github.com/fish-shell/fish-shell/blob/master/share/completions/yarn.fish

Glad to hear! PS: Your username is awesome and I'm jealous.


New error

This just started happening today. Not sure what's causing it.
Sentinel stat issue: Server returned HTTP response code: 500 for URL: http://neo.mcmonkey.org/plugins/public_stats?plugin=Sentinel&version=1.3.1+(build+126)

Sorry about that, the public stats server crashed apparently... it's back online, so that error should be gone.


Gradient Color Specimen

It would be great, if the Color Specimen would be extended to also support the display and specification of simple color gradients. For example:

Ideally, the label can also be displayed within the color swatch — similarly to how it's currently implemented in the Color Palette specimen.
The following props could be added to support customizing the gradient:
Style

Linear
Radial

Direction

Top
Top right
Right
Bottom right
Bottom
Bottom left
Left
Top left

Colors

Color 1
Color 2

Thanks for the input!
I just checked, for swatches something like
span: 2
name: "Gradient name"
value: "linear-gradient(to bottom, #da22ff, rebeccapurple)"

seems to work fine because the string is passed directly. For  color-palette it fails, because there is some contrast calculation for the label going on. Which leads to the question how this should work / look like with an inline label to ensure legibility.
If the swatch would be sufficient, it is only a matter of documentation. If not, it gets a bit complicated because then I think we should introduce something that handles svg gradients and patterns nicely.

Agree, would be great to have available in color-palette as well.

As a work around, I used the HTML specimen to show the gradient.


Generate Postgres Arrays with Nullable elements by default

It's not possible to enforce non-nullability of Postgres array elements.
The previous behaviour of mapping to Array<ST> works fine in practice because Diesel would never itself insert arrays with NULL elements. This was at the risk of deserialization errors though, should NULL values ever be made present (e.g. by some other process/manually).

This is a break change and it make code verbose.

Or is it possible to add an option to allow generate array without Nullable  wrapper?

@chrislearn We are aware that this is a breaking change. That's why it is included in a major version update. We do not have any planes to make this behaviour configurable as this is essentially a correctness fix. Checkout the relevant part of the migration guide for possible ways to "workaround" your problem.


Feature request: config option to disable pieces of RFTools

Can config options be added to disable individual pieces of RFTools, not registering the items or mentioning them in the in-game manual? For example:

A "teleportation" option that would disable the matter receiver and all other teleporting-related blocks and items
An "endergenic" option that would disable the endergenic generator, pearl injector, and ender monitor
Individual options to disable more-or-less standalone things like the coal generator and elevator

This could be achieved with MineTweaker, by just removing the recipes.

True, but then they'd still be referenced in the manual and would still exist in the Forge registries


AttributeError:'W90Downfolder' object has no attribute 'params'

Dear Mr.Xu
Lately I have downloaded and used this banddownfolder project.  I copied the tutorial code as script and modified some parameters such as folder, prefix, methd, kmesh and kverctors. Then I put the script, wannier90.win and wannier90_hr.dat in a folder. As a result, it occured AttributeError:'W90Downfolder' object has no attribute 'params'. I also have installed past versions trying to solve the problem but it still didn't work.
I think W90Downfolder may not inherits Banddownfoler,  namely lacking of a command like super()init().
Do you kown how to handle this error?
Finally, thanks  for providing a way to get low energy bandstrcuture.

Hi,
Thanks for reporting this. I will try to see if the W90downfolder is broken.
Note that BandDownfoler is currently under heavy development and it is not yet ready for production usage. The tutorials are probably outdated. If you're interested in using that, probably it would be good to discuss with me what kind of features are used so that It doesn't cause damages. Also I would be happy to know the results of the tests. Any feedback will be welcome.
Best wishes,
HeXu

I make some slightly changes and fix some typos, and test two examples in example/Wannier90 and example/Phonopy/PbTiO3. Now it works well for me. please see my fork version. Have fun with downfolding.

Hi, Thanks for the bug fix.
I am sorry that I didn't put the message that the development of this repository has been transferred to https://github.com/mailhexu/lawaf , as the package has been renamed. The bugs have been fixed there. There will soon be a lot of updates there. Stay tuned if you're interested.
Thank you for your contribution!!
Best regards,
HeXu

Hi,
Sorry that I didn't put the information on this repository. The development of the banddownfolder has been migrated to here:
https://github.com/mailhexu/lawaf
These bugs are fixed there.
Best regards,
HeXu


Implementation of Kruskals Algorithm in C++ to find Minimum Spanning Tree

Is your feature request related to a problem? Please describe.
I would like to implement one of the most asked problems of finding Minimum Spanning Tree using Kruskals Algorithm
Describe the solution you'd like
A clear and concise description of what you want to happen.
I would be including a proper description of the problem with all the necessary details and will then be coding the solution
Do you want to work on it
Mention the one language you want to be assigned for this issue.
Please assign this issue to me under GSSOC'21 @admin for the language C++

Please assign this to me Python

Please assign this to me in Java


build(weaver): eliminate need for package-local.json for besu/node

Related to #2601.
VSCode does not recognize package-local.json files semantically as package.json manifests meaning that the convenience functionalities it offers for editing package.json files are turned off.
It has been made sure that the original package-local.json has been renamed. The corresponding build scripts updated to delete the logic that copies/moves around package.json files at build time. The package.json files that are getting used can always be looked at just based on what's stored in version control instead of having to guess what changes are being made to the files by the build at runtime.
Pull Request Requirements

[x] Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
[x] Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
[x] Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

[x] Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
[x] Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

@krisstern Can this be done in a way that the package-local.json file can be deleted completely instead of having to be put under a separate directory? The way you did it here technically satisfies the requirement of having the VSCode package.json integration working, but it still leaves us with the maintenance burden of having to test everything with 2 package.json files.

Hi @petermetz, yes I think that it is possible to have one "package.json" file only. Let me try it over the next few days and update the PR shortly after.

@krisstern Thank you!

Hi @krisstern Thanks for this PR.
The CI workflow that tests Besu SDK build is failing.
Check logs here: https://github.com/hyperledger/cacti/actions/runs/9116432968/job/25065050908?pr=3269

@krisstern Are you still working on this? If not, that's totally fine, but then please let me know because I'm doing some housecleaning and this is one of the oldest pull requests we have open so if it's not happening I'll just close it down.

Hi @petermetz, I may need more time working on this. But let me close this now and submit another PR soon to replace it.

@krisstern Got it thank you. One very important thing: Please do not open another PR. Re-open this one so that the context, review and commit history is intact.

Okay, noted!


unable to add any new items from vanilla minecraft or mods without crash on initialisation.

any time i try to add a new line of text to skill lock a item, weapon/tool, or armor from vanilla minecraft or modds it will instantly crash upon starting up  saying game crashed whilst rendering overlay , exit code: -1. here is the crash log. i noticed that it mentions the : after "minecraft is not a valid option even though all the commands do this for example "minecraft:iron_sword attack:5"
https://gist.github.com/SirDynamite/6737f3926cdfd6604867ab99f78eecd1

ok so after spending a lot of time trying different things and methods to get this to work. it finally worked for me when i copied and pasted the "code" from the read me file posted here on the site. visually it looked identical to what i have been typing up manually (and even copy pasting from the default skill locks). so i guess im no longer in any trouble but i would apreciate if someone could explain to me what might have went wrong.

Good to hear you figured it out, but in order to help you figure out what went wrong, I'll need to see the config files that did and did not work.


OCPBUGS-19789: Backport OCPBUGS-14698: Rename ClusterRoles created by OperatorGroups

Backport OCPBUGS-14698: Rename ClusterRoles created by OperatorGroups.
Handle bad OG names by using the new format, keep good OG names as-is.

/jira cherrypick OCPBUGS-14698

/retest

/retest

@tmshort The unit-olm test looks perma-failed to me based on the test runs history. You may want to run it locally to see what the deal is.

@tmshort The unit-olm test looks perma-failed to me based on the test runs history. You may want to run it locally to see what the deal is.

I've never been able to run the unit-tests locally... (machine config)

@tmshort The unit-olm test looks perma-failed to me based on the test runs history. You may want to run it locally to see what the deal is.

I've never been able to run the unit-tests locally... (machine config)

Yah. I know it's a bit tricky to run tests on this downstream repo. You will need to get a OCP cluster and supply the config into some test commands in Makefile. So it requires some tinkering. I assume you didn't encounter this issue on upstream?

@tmshort The unit-olm test looks perma-failed to me based on the test runs history. You may want to run it locally to see what the deal is.

I've never been able to run the unit-tests locally... (machine config)

Yah. I know it's a bit tricky to run tests on this downstream repo. You will need to get a OCP cluster and supply the config into some test commands in Makefile. So it requires some tinkering. I assume you didn't encounter this issue on upstream?

OK, I got them to run, and the issue is that this is not a complete backport, but a partial backport; only "badnames" are have the ClusterRoles renamed (to avoid weird behavior of changing existing ClusterRoles), so checking for the new names will not work 99% of the time, so the tests will have to be modified.
Thanks!

ping @awgreene

ping @awgreene

Let me make some quick changes upstream; and it should get downstreamed fairly quicky?

See https://github.com/operator-framework/operator-lifecycle-manager/pull/3048

@awgreene downstreaming finally happpend, so this needs a LGTM and BACKPORT-RISK-ASSESSED

/retest

We're gonna wait on this one until 4.14.0 is released as it has existed since OLM was introduced and isn't worth the risk of delaying 4.14.0 GA.

/retest
/label backport-risk-assessed

/retest unit-olm
/retest e2e-upgrade

/test unit-olm
/test e2e-upgrade


jQuery.inputmask - swapped digits on paste with specific prefix

Pasting into a masked input with the mask +3719{8}, if the pasted value starts with 27, the 2 is shifted to the end of the input (e.g. 27000000 is replaced with 70000002). The same happens if the prefix is just +37, optionally with any fixed digits other than 2 after it. It's fixed if I remove the +, but it's a phone number, so not a great solution.
Update: I checked the code and after adding some logging I figured out that it's checkVal that's modifying this value after pasting. I've yet to find out exactly where and why it does that though.
From my experiments, it looks like all values that start with 27 are affected, and it doesn't matter what follows, it will just put the 2 at the end. This is huge because we have over 16k users with phone numbers that start with +37127....
Here's a fiddle to demonstrate: https://jsfiddle.net/jurchiks/uchqv5de/7/

OS: Windows 10 Home 1903 build 18362.535
Browser: Chrome 79.0.3945.117 (64-bit) and Firefox 73.0b3 (64-bit)
Inputmask version: jquery, 5.0.2

#2255

@RobinHerbots doesn't seem to be the same, although I thought about it before making this.

Anyway, I've narrowed it down to a specific point in code: isTemplateMatch changes the inputmask.caretPos.begin to the incorrect index after the first digit, thus prepending instead of appending everything that follows 2.

So, I cloned the repository and added a test for this case, but npm test doesn't run tests! It runs grunt validate, but the gulpfile contains no mention of tests at all. How do you run them?

@jurchiks ,
You need to run qunit.html in the qunit folder.
Anyway have a look at https://jsfiddle.net/md2goxhb/1/
I pushed a fix

Yep, works.

When could I reasonably expect a stable version?

Version 5.0.3 is a patch so very soon.  (After I fix #2255)

Awesome, thank you!


object type attribute search fails

Hello, this library is amazing but I don't seem able to use functionalities available to nodes when the data assigned to the nodes are classes.
For example:
class Objects:
    def __init__(self,a,b):
        self.a = a
        self.b = b

    def get_b(self):
        return self.b

def test():
    root = Node("a", data=Objects({"nae":1,"surname":2},20))
    b = Node("b", data=Objects({"nae":1,"surname":2},3))
    c = Node("c", data=Objects({"nae":1,"surname":2},3))
    d = Node("d", data=Objects({"nae":1,"surname":2},3))

    root.children = [b, c, d]

    print(findall(root,lambda node: node.data.b))
    print(findall(root,lambda node: node.data.get_b()))

with results being
 (Node(/a, data=<__main__.Objects object at 0x7fd4014274f0>), Node(/a/b, data=<__main__.Objects object at 0x7fd3e9d2d090>), Node(/a/c, data=<__main__.Objects object at 0x7fd3e9d2d5a0>), Node(/a/d, data=<__main__.Objects object at 0x7fd3e9d2d5d0>))
Or if I try
    print(find(root,lambda node: node.data.b > 2))

    raise SearchError(
bigtree.utils.exceptions.SearchError: Expected less than 1 element(s), found 4 elements
(Node(/a, data=<__main__.Objects object at 0x7f945e67b490>), Node(/a/b, data=<__main__.Objects object at 0x7f9446f910f0>), Node(/a/c, data=<__main__.Objects object at 0x7f9446f91600>), Node(/a/d, data=<__main__.Objects object at 0x7f9446f91630>))

How do I extract the actual value from my object?

Hello, thanks for using bigtree!
The output of findall is tuple of one or more nodes. The results being
(Node(/a, data=<__main__.Objects object at 0x7fd4014274f0>), Node(/a/b, data=<__main__.Objects object at 0x7fd3e9d2d090>), Node(/a/c, data=<__main__.Objects object at 0x7fd3e9d2d5a0>), Node(/a/d, data=<__main__.Objects object at 0x7fd3e9d2d5d0>))
is intended because it is returning a tuple of nodes. If you want to extract the values out, let me assume you want to extract the object variable a which is a dictionary, you can loop the results as such
nodes = findall(root, lambda node: node.data.b == 3)
print([node.data.a for node in nodes])
# [{'nae': 1, 'surname': 2}, {'nae': 1, 'surname': 2}, {'nae': 1, 'surname': 2}]

For your other point, the output of find is a single node, hence the criteria for find has to be unique. You can change the criteria to something more unique such as
print(find(root, lambda node: node.data.b == 20))


What would you change...?

Hi guys,
New to riot and redux and trying to follow better practices and patterns.
So, I've done this example:
https://github.com/Sendoushi/code-examples/blob/redux-riot/src/bootstrap.js
How would you improve?
I know this isn't an issue, a help wanted.

Closing this issue because it's related to an old router version. Please update to the latest @riotjs/route version if you can.


dge different distribtuions?

i want a distribution that can shift to under or over expressed and it should behave the same as normal distribution if both tails are the same

too complicated wont implement


Allow to choose multiple CSV files for the Import list filter

I checked this feature wish and it requires quite some changes to the IdList core API on which the import list filter is built. Thus, these changes will also have an impact on all plugins using an IdList.
Some additional questions:

Currently, the CSV file to be parsed is shown using a simple JTextField in the UI. I guess this should be changed to a JList to show multiple files? We could keep a simple JTextField but then would need a unqiue separator (for example embrace all files names by double quotes and use a white space inbetween: "fileA" "fileB" "fileC").
All files must, of course, share the same CSV settings. When doing a preview, I would still just preview the first file, not all files. Agreed?

Thanks for looking into this feature wish.

JList looks better.
Fully agree

Solved with #271


Update junit-jupiter-engine to 5.10.3

About this PR
📦 Updates org.junit.jupiter:junit-jupiter-engine from 5.9.3 to 5.10.3
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.junit.jupiter", artifactId = "junit-jupiter-engine" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.junit.jupiter", artifactId = "junit-jupiter-engine" }
}]

labels: test-library-update, early-semver-minor, semver-spec-minor, commit-count:1

Superseded by #1705.


Update to github-pages v177

Thanks for the Docker image!  Makes total sense to have a standard image to run for GitHub Pages repos.  Very helpful.
I noticed that the current version is 177, so I thought I'd make this PR.  I haven't done much testing, so this is a bit of a "drive-by PR".  Please let me know if you need any help with that.
Related: there's a handy RSS feed of github-pages gem versions here.

Thanks a lot @benjaminoakes 👍

No problem!  Thanks for contributor rights.
I added a simple IFTTT applet that will make a new issue when there's an entry here: https://rubygems.org/gems/github-pages/versions.atom
If that gets annoying, please let me know!  (Or just revoke my rights if I'm not getting back to you quickly enough.  😆)

That's just a first iteration... Another idea would be to read from their API and update the versions in a cronjob (even on TravisCI or CircleCI), maybe with some kind of smoke test.  Probably not something I'll get to anytime soon, but I thought I'd share the idea.  😄


RENZOBOT: Build backend scripts for Renzo re-staking bot

EPIC: https://www.notion.so/volumefi/EPIC-02-16-24-Renzo-Re-Staking-LP-Bot-65c497236c5a461aae46b967a98ead2b
Vyper contract https://github.com/VolumeFi/renzo_bot_vyper
CW contract: https://github.com/VolumeFi/renzo_bot_cw
This bot requires a backend to take actions off-chain and execute various smart contract function calls to implement the bot's pipeline. The backend depends on the implementation of the Vyper and CW contracts above.
The backend should handle:

user deposit and bot creation
store bot info
change user liquidity to another pool
query bot status
withdrawal
provide API on bot status for FE to query
etc

downprioritized


Update

Hey are we getting an update for 9.2 or is the project abandoned?

Hey, I'm sorry but I stopped playing WoW a while ago and don't have the time to provide updates. I will happily accept any contributions though.

I just discovered this AddOn from Naowhs stream and it's just awesome! I've been using Angry Keystones and the M+ Timer WA before but this AddOn does all the same but looks sooo much better and cleaner! Going to keep using it and hope someone can pick up the development of this addon. I suspected that it is going to become more popular now when some streamers have picked it up over GottaGoFast which hasn't been updated in ages.

I think this issue can be closed?

I understood this issue to be more about features for the new game version instead of just the client version bump, but I guess people can open new issues for specific features.


Update GSoC-interest.md

Signed-off-by: Matt Germonprez<EMAIL_ADDRESS>Removing names from 2021 and doing a few date updates. I suspect there are a few additional changes that we'll need to do to this document but this PR starts the process.

this looks good. I am going to merge.


os/exec: don't use a thread to wait on processes

See https://github.com/docker/docker/issues/11529
There's no reasons why Docker should have to work around the standard library to reduce their thread count with large numbers of processes.
We could make os/exec.Cmd.Wait efficient instead.
/cc @ianlancetaylor

Do "modern" systems have anything like Plan 9's wait file? http://plan9.bell-labs.com/magic/man2html/3/proc

At least for Linux, we can use signalfd(2) and the runtime network poller
to wait for SIGCHLD without a new thread. On BSD, we could use kqueue(2)
with NOTE_EXIT.


[cxx-interop] Treat C++ structs that store iterators as unsafe

C++ types that store pointers as fields are treated as unsafe in Swift. Types that store other types that in turn store pointers are also treated as unsafe.
Types that store raw C++ iterators are also treated as unsafe in Swift. However, a type that stores another type that stores a raw iterator was previously imported as safe. This change fixes that.
rdar://105493479

@swift-ci please smoke test


qe_pre_installation_tasks: configure selinux to permissive mode

Looks good. That said, could you link the reason for this change either into description of this pull request of in the commit message?

Also, when this pull request is merged, we should create an issue for usmqe-setup titled "Remove Workaround: SELinux should not be disabled" which would link to this particular commit, so that we could track workarounds in usmqe-setup (it would be easily filterable in list of issues) and revertable.


Demo link is not working / seems broken

Hi there and thanks for your amazing work!
I just wanted to let you know that the demo link seems to be broken.
I also tried the huggingface demo, which also didn't work.
Am I alone with this issue?
Thanks in adavance!

Thanks so much! I will fix shortly

Thanks so much! I will fix shortly

Hello, the demo link still does not work, could you fix it? Thanks.

Thanks for the reminder, it is fixed last week : )


[release-1.5] Use JSON merge to update objects (#21083)

Manual cherry pick.

@ostromart: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio_release-1.5
8dd5d51aac5fb6aafca902aabd139fccd0a0de9c
link
/test gencheck_istio_release-1.5

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ostromart: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio_release-1.5
8dd5d51aac5fb6aafca902aabd139fccd0a0de9c
link
/test gencheck_istio_release-1.5

e2e-bookInfoTests-envoyv2-v1alpha3_istio_release-1.5
8dd5d51aac5fb6aafca902aabd139fccd0a0de9c
link
/test e2e-bookInfoTests-envoyv2-v1alpha3_istio_release-1.5

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ostromart: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio_release-1.5
8dd5d51aac5fb6aafca902aabd139fccd0a0de9c
link
/test gencheck_istio_release-1.5

e2e-bookInfoTests-envoyv2-v1alpha3_istio_release-1.5
8dd5d51aac5fb6aafca902aabd139fccd0a0de9c
link
/test e2e-bookInfoTests-envoyv2-v1alpha3_istio_release-1.5

integ-istioio-k8s-tests_istio_release-1.5
8dd5d51aac5fb6aafca902aabd139fccd0a0de9c
link
/test integ-istioio-k8s-tests_istio_release-1.5

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Add arrow switching system

A feature to switch between arrow types (normal, fire, ...) could be implemented. So far there have been implementations of this feature. However, they come with the price of quite some drawbacks and limitations which would make the scripts a lot more convoluted and prone to bugs.
One example is the overwriting of the munition property in local instances of bows, which causes misbehavior if the bow is equipped.
Without a better idea of implementation, this feature will not be included.

This will not be part of this package for now.


[kddockwidgets] new port

Note that there is #19548.

Note that there is #19548.

yeah but that one is probably never going to finish and is the qt5 version.

Thanks for the new port!


Update wabt and fix the tests

This PR:

restores the test coverage
add dynamic resolving of the want version to latest through GH API
checkout the testsuite at a previous commit as wabt doesn't correctly parse if.wast

Upstream Issue: https://github.com/WebAssembly/wabt/issues/2347

@andreaTP thanks for fixing this! Just tried this out locally and it works great!

Verified your branch locally and it worked great, thanks @andreaTP for fixing this :)


Fix PHP 7.2 count error

count(): Parameter must be an array or an object that implements Countable

:+1:

@mlocati the checks have failed, but I can't believe that the reason is in my simple changes.

Don't worry, the tests fail because of a recent change in the core (fixed by #7035).

Thanks for the update


Read Error from vcontrold kills the adapter

I currently have a strange problem: After an indefinite time the vcontrold seems to report a read error and then the Viessmann adapter hangs up:
2018-05-25 03:10:37.397  - debug: viessmann.0 Wait for next run: 31 in ms
2018-05-25 03:10:37.429  - debug: viessmann.0 Next poll: getLeistungIst
2018-05-25 03:10:37.491  - silly: viessmann.0 redis publish io.viessmann.0.get.LeistungIst {"val":0,"ack":true,"ts":1527210637491,"q":0,"from":"system.adapter.viessmann.0","lc":1527208866356}
2018-05-25 03:10:37.494  - debug: viessmann.0 Wait for next run: 9435 in ms
2018-05-25 03:10:45.263  - silly: viessmann.0 redis publish io.system.adapter.viessmann.0.alive {"val":true,"ack":true,"ts":1527210645262,"q":0,"from":"system.adapter.viessmann.0","lc":1527025532172}
2018-05-25 03:10:45.266  - silly: viessmann.0 redis publish io.system.adapter.viessmann.0.connected {"val":true,"ack":true,"ts":1527210645265,"q":0,"from":"system.adapter.viessmann.0","lc":1527025532174}
2018-05-25 03:10:45.267  - silly: viessmann.0 redis publish io.system.adapter.viessmann.0.memRss {"val":32.2,"ack":true,"ts":1527210645267,"q":0,"from":"system.adapter.viessmann.0","lc":1527210645267}
2018-05-25 03:10:45.268  - silly: viessmann.0 redis publish io.system.adapter.viessmann.0.memHeapTotal {"val":14.98,"ack":true,"ts":1527210645268,"q":0,"from":"system.adapter.viessmann.0","lc":1527025757250}
2018-05-25 03:10:45.270  - silly: viessmann.0 redis publish io.system.adapter.viessmann.0.memHeapUsed {"val":11.54,"ack":true,"ts":1527210645269,"q":0,"from":"system.adapter.viessmann.0","lc":1527210645269}
2018-05-25 03:10:45.271  - silly: viessmann.0 redis publish io.system.adapter.viessmann.0.uptime {"val":185115,"ack":true,"ts":1527210645271,"q":0,"from":"system.adapter.viessmann.0","lc":1527210645271}
2018-05-25 03:10:45.272  - silly: viessmann.0 redis publish io.system.adapter.viessmann.0.inputCount {"val":0,"ack":true,"ts":1527210645272,"q":0,"from":"system.adapter.viessmann.0","lc":1527108724068}
2018-05-25 03:10:45.274  - silly: viessmann.0 redis publish io.system.adapter.viessmann.0.outputCount {"val":14,"ack":true,"ts":1527210645273,"q":0,"from":"system.adapter.viessmann.0","lc":1527210645273}
2018-05-25 03:10:46.933  - debug: viessmann.0 Next poll: getTempKist
2018-05-25 03:10:46.936  - warn: viessmann.0 Vctrld send ERROR: ERR: <RECV: read eof
>FRAMER: read failure 1
Error in send, terminating
Error executing getTempKist
vctrld>
2018-05-25 03:10:46.937  - debug: viessmann.0 Wait for next run: 110 in ms
2018-05-25 03:10:47.048  - debug: viessmann.0 Next poll: getTempAbgas
2018-05-25 03:10:47.050  - warn: viessmann.0 Vctrld send ERROR: ERR: <RECV: read eof
>FRAMER: read failure 1
Error in send, terminating
Error executing getTempAbgas

2018-05-25 03:10:47.051  - debug: viessmann.0 Wait for next run: 67 in ms
2018-05-25 03:10:47.118  - debug: viessmann.0 Next poll: getTempKsoll
2018-05-25 03:10:47.121  - warn: viessmann.0 Vctrld send ERROR: ERR: <RECV: read eof
>FRAMER: read failure 1
Error in send, terminating
Error executing getTempKsoll

It does not seem to be a be a problem (at least not a permanent one) of vcontrold. When I restart the adapter it again connects fine to vcontrold and resumes operation.
Is there a way to make the adapter handle such errors more gracefully?

[31318] Thu May 31 10:16:16 2018 : >FRAMER: read failure 1
[31318] Thu May 31 10:16:16 2018 : Error in send, terminating
[31318] Thu May 31 10:16:16 2018 : Error executing getTempKsoll
[31318] Thu May 31 10:16:16 2018 : <RECV: read eof
[31318] Thu May 31 10:16:16 2018 : >FRAMER: read failure 1
[31318] Thu May 31 10:16:16 2018 : Error in send, terminating
[31318] Thu May 31 10:16:16 2018 : Error executing getVolStrom
[31318] Thu May 31 10:16:16 2018 : <RECV: read eof
[31318] Thu May 31 10:16:16 2018 : >FRAMER: read failure 1
[31318] Thu May 31 10:16:16 2018 : Error in send, terminating
[31318] Thu May 31 10:16:16 2018 : Error executing getBrennerStatus
[31318] Thu May 31 10:16:16 2018 : <RECV: read eof
[31318] Thu May 31 10:16:16 2018 : >FRAMER: read failure 1
[31318] Thu May 31 10:16:16 2018 : Error in send, terminating
[31318] Thu May 31 10:16:16 2018 : Error executing getLeistungIst
[31318] Thu May 31 10:16:22 2018 : <RECV: read eof
[31318] Thu May 31 10:16:22 2018 : >FRAMER: close read failure for ack
[30297] Thu May 31 10:16:33 2018 : TCP socket 3002 opened
[30297] Thu May 31 10:17:34 2018 : Client connected <IP_ADDRESS>:35896 (FD:6)
[30297] Thu May 31 10:17:44 2018 : >FRAMER: unexpected data 0x00

The log above is from vcontrold.
[30297] Thu May 31 10:16:33 2018 : TCP socket 3002 opened <-- First reload
[30297] Thu May 31 10:17:34 2018 : Client connected <IP_ADDRESS>:35896 (FD:6) <--- Second reload
[30297] Thu May 31 10:17:44 2018 : >FRAMER: unexpected data 0x00

This is 2 reloads of the viessman adapter. First reload it did not connect cleanly and second reload it again connected cleanly and continued to work. I did not restart vcontrold

Sorry for the late answer, but i haven´t a lot of time at the moment. How many values and in what time do you ask vcontrold.

No urgency. Thanks for looking into it
I have 6 gets: 5x 10 sec and 1x 1 min

Hello,
for the moment you can try this main.js. after your response, I check the error handle in a new version.
But it is not a issue from the adapter.

i create a new version for you. You can try it........

Many thanks. Will try and report back.

After 5 times of error answers, the adapter try a new connection to vcontrold. If you use this option in the adapter setting.

Having a strange issue:

Admin v3.4.7
Viessmann Adapter 0.5 installed via git. Shows up as 0.5.0 under instances. No error in the installation

Viessmann Adapter settings:

Looks like it is using index.html instead of index_m.html. Tried complete reinstall, cleared browser cache and adding instances. Result is the same. Any idea?

Puhhh....can  you install over admin (last report)

Wich node version?

root@piheizung /opt/iobroker # node -v
v6.13.1

Tried to install via admin as well. No avail.

Can you post the browser console after you open the adapter settins

hmm...
root@piheizung /opt/iobroker # locate index |grep vie
/opt/iobroker/iobroker-data/files/viessmann.admin/index.html.bak
/opt/iobroker/iobroker-data/files/viessmann.admin/index_m.html
/opt/iobroker/node_modules/iobroker.viessmann/admin/index.html.bak
/opt/iobroker/node_modules/iobroker.viessmann/admin/index_m.html

I have renamed the index.html files but this also did not change anything

window.controllers/Controllers sollte nicht mehr verwendet werden. Verwenden Sie es nicht für die Browser-Erkennung. ace.js:1
unreachable code after return statement[Weitere Informationen] tabs.js:199
unreachable code after return statement[Weitere Informationen] tabs.js:358
Passwort-Felder sind auf einer unsicheren (http://) Seite vorhanden. Dies ist ein Sicherheitsrisiko, durch das Zugangsdaten gestohlen werden können.[Weitere Informationen] <IP_ADDRESS>:8081
Subscribe: system.adapter.* admin.js:1355
Subscribe: system.host.* admin.js:1355
Subscribe: *.info.connection admin.js:1355
"Import": {"en": "Import", "de": "Import", "ru": "Import", "pt": "Import", "nl": "Import", "fr": "Import", "es": "Import", "pl": "Import", "it": "Import"}, translate.js:24:9
"Close": {"en": "Close", "de": "Close", "ru": "Close", "pt": "Close", "nl": "Close", "fr": "Close", "es": "Close", "pl": "Close", "it": "Close"}, translate.js:24:9
unreachable code after return statement[Weitere Informationen] tabs.js:199
unreachable code after return statement[Weitere Informationen] tabs.js:358
de

Which browser do you use? Can you try Chrome?

Just tried. The same :-S

Since I have renamed index.html to index.html.bak, I wonder where this is coming from

give me one hour....i will check it on my computer when i come home

Oh well, I deleted the adapter gain, cleared the npm cache, manually deleted everything viessmann related and installed again. Works now

Just a slight typo left.
Many thanks for your support and this great adapter. Really appreciated.

Nice... import for you is, use the error option. I hope that works for you.
Please give me a feedback

Sorry, i have seen a little issue in translate the error option. Please install new, when you want.

Please repeat the installation now. Over the night i have found a little thinking error with the error handle. I changed it in the morning

Thanks.

Your addition worked great, unfortunately it did not solve my issue.
The strange thing is: Manually restarting the adapter from the Admin UI made it connect to the vcontrold just nicely.
What I do not understand:

The vcontrold seems to work OK
The Viessmann adapter works OK
Sometimes the communications crashes and is not able to recover

The ECONNREFUSED would point to something like

the port not open
firewall issue
daemon not running etc.

But again this does not match to the fact that a restart of the adapter makes it work again.


fan02 speed problem

Hi
I have fan02 installed
I install the component, I found the name for Fan and the name for light.
but I cant find name for the speed of the fan
for example
switch.sonoff_10005b26e9_1 is light
switch.sonoff_10005b26e9_2 is Fan
switch.sonoff_10005b26e9_3 is medium speed of the fan
switch.sonoff_10005b26e9_4 is fast speed
but with your component I only see no: 1, 2 cant see no 3,4
please help
Regards
David

Duplicate #153


[stable/stellar-core] Support the ready.sh probe from upstream docker images

Add support for ready.sh script that is in upstream docker images so pod is restarted if not syncd,

I still think it needs to be included.

I still think it needs to be included.

does anyone look at these?


Wrong date format for locales

I am trying to parse some dates and noticed some locales differ from the standards. For example, given this simple code
var localeData = moment.localeData('af-ZA');
console.log(localeData._config.longDateFormat.L);

It will display DD/MM/YYYY. Although this is 'commonly used', it is not technically the correct format for South Africa, it should be YYYY-MM-DD. Is it possible to change the locale info to include both formats?

You say you're parsing dates: do you need to parse locale-specific date formats, or can you achieve what you need by passing multiple format strings to the moment constructor?

They are locale-specific dates, so they user stores their locale and based on that we assume the date format.

Thanks for writing.
We have a default format per locale. If you think a particular locale has an incorrect format, please submit a patch and tag the locale author. Then, we can have a discussion about the specific change.


Feedback posted as comments instead of annotations

I enabled annotations in my config, but all the feedback still got posted as comments. What could be going wrong?

Oh, if you're using split_workflow, that needs to be on the post action, rather than review. Sorry, that's not very clear in the docs

Aha, thanks. What about lgtm_comment_body?


Fetch boringssl-with-bazel submodule from GitHub instead of GoogleSource.com

Fixes https://github.com/grpc/grpc/issues/13701

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

[trickle] No significant performance differences

[microbenchmarks] No significant performance differences


#label breaks Polylux slide header

Hi, I have a strange issue with the label given to a dedicated slide. Indeed, when a label is given to a slide, the (custom) header of the next slide disappears.
As you can see in the following MWE, the first, second and fourth slides have their headers. I put a label to the second slide, which makes the header of the third slide disappear.
#import "@preview/polylux:0.3.1": *
#import themes.metropolis: *

#show: metropolis-theme

#set text(font: "Fira Sans", weight: "light", size: 20pt)
#set strong(delta: 100)
#set par(justify: true)

#title-slide(
  author: [Authors],
  title: "Title",
  subtitle: "Subtitle",
  date: "Date",
  extra: "Extra"
)

#slide(title: "First title")[
  #lorem(20)
]

#slide(title: "Second title")[
  #lorem(20)
]<app>

#slide(title: "Third title")[
  #lorem(20)
]

#slide(title: "Fourth title")[
  #lorem(20)
]

Is there a workaround to solve this issue ? Thank you.

That's strange indeed! Looks rather like a Typst bug. Why would you want a label on a slide though?

So ypu want to make a reference to a slide?

Yes, exactly.

Currently, you can only make references to figures and a few bespoke Typst elements in Typst. So referencing slides  cannot really work by itself.

Actually except this problem of header, using #label + #link works (I swear ! :)).

I think I find how to do this. To make a reference between slides, we just have to add the lable into the slide and make a link in another slide to jump to it.


deis-logger is eating whole cpu

3-node cluster, fresh 1.7.0 with 1.6.1 publisher (due to issue with 404's).
One node where I've deis-logger, logger and etcd process together are eating whole cpu. If I stop deis-logger.service, etcd cpu usage is dropping. journalctl -f all together on all nodes combined is showing on average maybe <100 lines per minute.
journalctl -f -u for etcd or deis-logger doesn't show any warnings/errors.
Strace on etcd process is showing lots of GET requests to '/v2/keys/deis/logs/drain?con...', but if I remove log drain it doesn't change much in case of cpu usage.
Any advice where I should look?

I think I found it: missing .Seconds() on logger/main.go.
Seriously guys. 10 nanoseconds as publish interval is not nice. ಠ_ಠ