Update constraint metrics for mt variants

Existing Helix constraint info is old. Remove Helix constraint info which currently shows as a red tag.
Update with Nicole Lake's new data from supplemental tables in the study (https://www.biorxiv.org/content/10.1101/2<IP_ADDRESS>0778v2)
Display the mitochondrial local constraint score (MLC) in a traffic light system like we do for the in silico tools
High constraint is >=0.75 - red; 0.50-0.74 is yellow; <0.50 is green

local_constraint_mito is now present on the MITO annotations table:
In [4]: hl.read_table('gs://seqr-hail-search-data/v03/GRCh38/MITO/annotations.ht').local_constraint_mito
Out[4]: <StructExpression of type struct{score: float32}>

@lynnpais We'll need a UI ticket to implement the traffic light in the UI.


How to enable only specific date?

Hi,
I want to disable all the dates except today and previous four days. How can I achieve this in pickerjs Datepicker?
That means today is 30th Dec and I want to allow user to select Date from 26th Dec. to today.

I don't think this feature is implemented in pockerjs. But it is in his datepicker script : https://github.com/fengyuanchen/datepicker

Not support this for now.

现在特定日期功能实现了吗

@itMyron 暂时没有，没有时间更新，不好意思～


fix: update to new angular control flow

ng generate @angular/core:control-flow

:tada: This PR is included in version 3.3.13 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


From camera frame to world frame using habitat.utils.geometry_utils

Hi there, I am trying to convert coordinates of point cloud coordinates which are initially in the depth camera's coordinate frame back to the simulator's world frame. I am not sure what's the correct way to do it here since I am not familiar with the use of quaternions in Habitat.
I have the following 2 transformation logic:
            points_world[idx] = (
                quaternion_rotate_vector(depth_camera_rot, points_world[idx])
                + depth_camera_pos
            )

or
            points_world[idx] += depth_camera_pos
            points_world[idx] = quaternion_rotate_vector(
                depth_camera_rot, points_world[idx]
            )

where depth_camera_rot is the quaternion of the depth camera, and depth_camera_pos is the world coordinate of the camera.
        depth_camera_pos = np.asarray(depth_camera_info.position)
        depth_camera_rot = quaternion.as_quat_array(
            np.asarray(depth_camera_info.rotation)
        )

Can you help me confirm which logic will work?

Rotation + translation works the same with quaternions and matrices. First apply the rotation then apply the translation.
To create the quaternion from a list, please use habitat.utils.geometry_utils.quaternion_from_coeff as there are different ways to store the coefficients of a quaternion and that'll make sure it's consistent.

@yhymason Feel free to re-open the issue, if you still have questions.

@rpartsey — we get this question about Habitat coordinate system quite frequently. We should create a page or tutorial on it with visuals so that we can point people to it. I believe Eric has a draft PR on it that you might want to take over.

@dhruvbatra Thanks! That's exactly what I planned to do. Opend a new Issue https://github.com/facebookresearch/habitat-lab/issues/954 and assigned to myself.


Add Nong Song

Song Name
Can you feel my heart - remix (gigachad)
Artist Name
G6400
Source
Direct file download
Youtube Link
No response
Direct File Link
No response
Song ID
1110953
Extra
82786090

reject
as Flafy said, Im just cleaning up


[zlib] fixed filename of zlib archive

Hi @patrigg, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
We will now validate the agreement and then real humans will evaluate your PR.
TTYL, MSBOT;

Thanks!
(I did a rebase, so github couldn't figure out that this was merged)


Automated Package Upgrade

:tada: This PR is included in version 12.4.93 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


tests: add TestBackEnd AIO and NULL Get and Stats

Signed-off-by: Boris Glimcher<EMAIL_ADDRESS>

@artek-koltun all great comments.
But commonality across tests is more important for me now.
If/When we going to make a change it should be across all tests
you already opened #265 to track this

For some cases, this is ok. However, in my opinion, we just add maintainability burden with some tests, which just test some spdk json rpc module behavior, but not business logic of an opi call

I agree. One of reasons I suggested to have a sperate package for gospdk ...


TIKA-1800 -- decode the escape character before parsing it as a new p…

…arameter

Thanks for your contribution to Apache Tika! Your help is appreciated!
Before opening the pull request, please verify that

there is an open issue on the Tika issue tracker which describes the problem or the improvement. We cannot accept pull requests without an issue because the change wouldn't be listed in the release notes.
the issue ID (TIKA-XXXX)

is referenced in the title of the pull request
and placed in front of your commit messages surrounded by square brackets ([TIKA-XXXX] Issue or pull request title)

commits are squashed into a single one (or few commits for larger changes)
Tika is successfully built and unit tests pass by running mvn clean test
there should be no conflicts when merging the pull request branch into the recent main branch. If there are conflicts, please try to rebase the pull request branch on top of a freshly pulled main branch
if you add new module that downstream users will depend upon add it to relevant group in tika-bom/pom.xml.

We will be able to faster integrate your pull request if these conditions are met. If you have any questions how to fix your problem or about using Tika in general, please sign up for the Tika mailing list. Thanks!

And also a test case too :3

Your commit seems to remove a test zip file, which seems to be by accident, any chance you could re-do it without the accidental deletion?
Would you also be able to add a comment explaining what your new for loop is doing, so anyone looking at that code later can quickly figure out what it's doing?


Put all Win32::Registry monkeypatches together

Moves the monkeypatch for Win32::Registry#write from some random file into the file with all the other Win32::Registry monkeypatches.

Ready for review @chef/client-windows

:+1:

:+1:


[Feature Request] Recursive Suspend/Resume

This is an excellent library which addresses a shortcoming of vanilla NodeJS. It would be beneficial if an option could be added in where the suspend/resume functions apply to children/grandchildren of a spawned process.
A common scenario this would greatly assist in is controlling executables that were lauched with spawn.

I don't know of any Windows kernel function that does that. If you manage to get a list of the PIDs of the children processes you could just loop through that and suspend each process one by one. You could get the process tree from tasklist or pslist and then traverse it to get the PID of all the processes you want to suspend.
I think gathering this kind of process information is a bit out of the scope of this library since Windows doesn't provide it in an accessible manner (for example process info in Linux is easily accessible under /proc).
Did you find any programs that weren't suspended correctly because of their children processes? If so, having a concrete example may help.

As per your suggestion, I have found that the wmic command on Windows is able to give STDOUT data which lists the childprocesses. Just a matter of capturing with regex and repeating things recursively after that. Example I use is as follows:
/**
 * Retrieve an array of process IDs in a Windows setting.
 * @param startingPid The PID from which to retrieve the PIDs of all descendants.
 * @returns An array of PIDs, the order of which follows child1 > grandchild1_1 ; child2 > grandchild2_1, grandchild2_2, etc.
 */
export function getWindowsPIDS(startingPid: number) {
  if (process.platform !== "win32") {
    throw new Error("This function must only be executed on a Windows platform.");
  }

  // Instantiate the PIDs array which will be referenced in the recursive function
  const pids: number[] = [];

  /**
   * Adds the process ids of child processes to the outer-scope pids array.
   * @param parentPid The process ID of a parent process.
   */
  function getChildPids(parentPid: number) {
    const { stdout } = spawn.sync("wmic", ["process", "where", `(ParentProcessId=${parentPid})`, "get", "ProcessId"], {
      encoding: "ascii",
    });

    if (/\d+/gm.test(stdout)) {
      const childPids = stdout.match(/\d+/gm).map(pid => parseInt(pid));
      for (const childPid of childPids) {
        pids.push(childPid);
        getChildPids(childPid);
      }
    }
  }
  getChildPids(startingPid);
  return pids;
}

I opted for a flat array approach instead of a nested object. From here, a user may loop over the array of PIDs and suspend/resume as their project requires.


loading from .ini files API changes

Describe your changes

[API Change] When loading connections from a .ini file via %sql --section section_name, the section name is set as the connection alias
[API Change] Starting connections from a .ini file via %sql [section_name] has been deprecated

Also:

Added missing documentation about reading .ini files
Added missing unit tests

Issue number
Closes #X
Checklist before requesting a review

[ ] Performed a self-review of my code
[ ] Formatted my code with pkgmt format
[ ] Added tests (when necessary).
[ ] Added docstring documentation and update the changelog (when needed)

:books: Documentation preview :books:: https://jupysql--803.org.readthedocs.build/en/803/

Can we display some message when running %sql --section duck? Right now it's not clear if it worked or not

Can we display some message when running %sql --section duck? Right now it's not clear if it worked or not

good catch. this is unrelated to the .ini feature, opened: https://github.com/ploomber/jupysql/issues/807

2. Entire stack trace displayed if duplicate sections present:

fixed and added unit tests https://github.com/ploomber/jupysql/pull/803/commits/ba6616edd49c4e02cefe02b85d57005421ac74f1 (also covers duplicate keys)

After loading section duckdb if we run %sql [duck2] it doesn't throw any deprecation warning:

this is the default behavior for the warnings module, it'll only show the warning once


Support Kubernetes v1.25

If trying to run the chart on k9s version 1.25, it will cause the release not to deploy with the following error:
❯ helm install traefik-mesh traefik-mesh/traefik-mesh
Error: INSTALLATION FAILED: unable to build kubernetes objects from release manifest: [resource mapping not found for name: "grafana" namespace: "" from "": no matches for kind "PodDisruptionBudget" in version "policy/v1beta1"
ensure CRDs are installed first, resource mapping not found for name: "prometheus" namespace: "" from "": no matches for kind "PodDisruptionBudget" in version "policy/v1beta1"
ensure CRDs are installed first, resource mapping not found for name: "jaeger" namespace: "" from "": no matches for kind "PodDisruptionBudget" in version "policy/v1beta1"
ensure CRDs are installed first, resource mapping not found for name: "traefik-mesh-controller" namespace: "default" from "": no matches for kind "PodDisruptionBudget" in version "policy/v1beta1"
ensure CRDs are installed first]

This should use the right API version.

Thanks 👍

Thank you for doing all the actual fixes 😂


Added the  line made with love by eddiehubbers

Just to make read me attractive

! a small effort
Fixes #52

@eddiejaoude Give a review I forgot to add reviewer


Aries RFC 0528: Biometric Enrollment Protocol - Added Tiara Johnson to Authors

Great job. Almost perfect — and the only problem is something I omitted. I forgot to tell you that my fork has many interesting branches where I’m working on different RFC projects. The PR that you want to create should be from your fork’s master branch to my fork’s “bsp” branch. That will result in a PR with only one commit (yours), instead of lots of commits.
I’m going to close this PR without merging it. Then, next time you are working, please reopen the PR against the other branch, and it should be exactly right.


We should start using releases

https://github.com/ggtracker/sc2reader/releases is empty but the old repo used releases.

@cclauss I would be happy to let you do this — is there anything I need to do to permit you to do this?

IBM webcast just starting now that features sc2reader...
Use data science to up your game performance
Live On August 24, 2017 at 11am Eastern US (and again at 4pm Eastern)
Join on Twitch: https://www.twitch.tv/calvinpowers

Where did you see this promoted / advertised?
On Thu, Aug 24, 2017 at 11:10 AM, cclauss<EMAIL_ADDRESS>wrote:

IBM webcast just starting now that features sc2reader...
Use data science to up your game performance
Live On August 24, 2017 at 11am Eastern US (and again at 4pm Eastern)
Join on Twitch: https://www.twitch.tv/calvinpowers
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/ggtracker/sc2reader/issues/39#issuecomment-324664227,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAvzqVRYbdApMx_h0_qvXd3WNtIaBJFQks5sbZJIgaJpZM4PBgJC
.

I work for IBM.

With the powers vested in me by @dsjoerg, no open GitHub issues, a clean CircleCI, and no apparent gaps for MVP, I move to mark a sc2reader 1.0 release. Any objections?
Going forward, we should have regularly released versions. I propose that we use a standard semantic versioning https://semver.org/
Notably, I suggest we should generally use minor versions whenever blizzard releases new protocol versions since that is new functionality by supporting potentially new data.
What do you guys think?

Amazing progress!
On Mon, May 14, 2018 at 8:14 PM Kevin Leung<EMAIL_ADDRESS>wrote:

With the powers vested in me by @dsjoerg https://github.com/dsjoerg, no
open GitHub issues, a clean CircleCI, and no apparent gaps for MVP, I move
to mark a sc2reader 1.0 release. Any objections?
Going forward, we should have regularly released versions. I propose that
we use a standard semantic versioning https://semver.org/
Notably, I suggest we should generally use minor versions whenever
blizzard releases new protocol versions since that is new functionality by
supporting potentially new data.
What do you guys think?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ggtracker/sc2reader/issues/39#issuecomment-389002061,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAvzqXjApGzoJejamBZRbpRYQI1WQDENks5tyh3VgaJpZM4PBgJC
.

v1.0.0 is out

https://github.com/ggtracker/sc2reader/releases/tag/v1.0.0
https://pypi.org/project/sc2reader/

Help to keep me honest with future changes as well because I will probably forget to update versions


mvn site site:stage -- staging has empty dependency-check-report.html

I noticed that the aggregate goal does not work for a multi-module project with the site:stage goal.
The dependency-check-report.html file exists, but is 0 bytes.
Note that mvn site works -- the problem is unique to site:stage.

Thank you for pointing this out. I have been able to replicate the issue on my side - now I just have to figure out why....

The good news is I've figured out why this happens - the bad news, I haven't come up with a solution yet. I'm likely going to have to email the maven dev list. A basic description of the problem is that the dependencies must be resolved in order for dependency-check-maven to work. The order of execution for a generic multi-module pom would be:

parent
module1
module2

Because parent runs before the child modules the dependencies of the child modules are not resolved at the time the parent is executing. As such, when dependency-check-maven:aggregate is executing against parent there is no (easy/obvious) way to know what the dependencies of the children are. The aggregate goal works for mvn site because it cheats - for each module it will execute and create a serialized data file containing the information on the dependencies; however, a blank HTML report is written. When maven gets to the last project in the build the aggregate goal will go back and re-write all of the HTML reports based off of this serialized data.
The problem is site:stage executes on each of the projects in order - so the blank html report gets copied instead of waiting until the last project and then copying the correct html report.
--Jeremy

Has there been any recent traction/research on this?
I'm a little puzzled by this problem; I'm trying to think about how other plugins solve this.

The real issue comes down to dependency resolution. I haven't found another reporting plugin with an aggregation goal that requires dependency-resolution.
When the parent runs the aggregation goal the child modules have not undergone dependency resolution. I can't find an easy api to kick off dependency-resolution. Thus, the only thing I have come up with is to require a second run to actually make the aggregate goal work. I.e. the first run we produce the serialized data files and the second run an aggregate goal could read these files. So you would do something like this:
$ mvn verify
$ mvn site site:stage

This is of course assuming that the check goal is configured in the build and that the aggregate goal is configured in the reportingg section.

We are also quite interested in getting this fixed. I can see the problem, it seems more logical to run the parent goal last but that's not how it works.

Right.  The only solution I've been able to come up with would require
running maven twice.
If no one can suggest any other ideas I will likely implement this soon.
-jeremy
On Feb 24, 2016 10:50 AM, "Erik Wramner"<EMAIL_ADDRESS>wrote:

We are also quite interested in getting this fixed. I can see the problem,
it seems more logical to run the parent goal last but that's not how it
works.
—
Reply to this email directly or view it on GitHub
https://github.com/jeremylong/DependencyCheck/issues/325#issuecomment-188314012
.

I am wondering if a lifecycle extension would help.

The issue is that all of the lifecycles run on the parent before going to
the next project. Thus, unless you run Maven twice we don't have all
dependencies on all child projects (first run we can create the serialized
dependency-check data, second run for reporting we can read it in and
create the report).
--Jeremy
On Sat, Mar 12, 2016 at 2:07 PM, Anthony Whitford<EMAIL_ADDRESS>wrote:

I am wondering if a lifecycle extension
http://maven.apache.org/examples/maven-3-lifecycle-extensions.html
would help.
—
Reply to this email directly or view it on GitHub
https://github.com/jeremylong/DependencyCheck/issues/325#issuecomment-195792709
.

It's been a long, long time since I wrote a Maven plugin from scratch, but
IIRC, you can add an annotation for a mojo to get access to the reactor
order. If this project is the last one in the reactor, it could read the
serialized data from all the child projects, then write the report to the
root of the reactor. Yes - it's a kludge.
On Sat, Mar 12, 2016 at 2:56 PM, Jeremy Long<EMAIL_ADDRESS>wrote:

The issue is that all of the lifecycles run on the parent before going to
the next project. Thus, unless you run Maven twice we don't have all
dependencies on all child projects (first run we can create the serialized
dependency-check data, second run for reporting we can read it in and
create the report).
--Jeremy
On Sat, Mar 12, 2016 at 2:07 PM, Anthony Whitford <
<EMAIL_ADDRESS>wrote:

I am wondering if a lifecycle extension
http://maven.apache.org/examples/maven-3-lifecycle-extensions.html
would help.
—
Reply to this email directly or view it on GitHub
<
https://github.com/jeremylong/DependencyCheck/issues/325#issuecomment-195792709
.

—
Reply to this email directly or view it on GitHub
https://github.com/jeremylong/DependencyCheck/issues/325#issuecomment-195798184
.

The aggregation code has been completely re-written in 1.4.3-SNAPSHOT. The fix will be released with the next release.


hotfix-1.4.1

Correct the behavior of empty columns and rows.

Codecov Report

Merging #95 (64208b5) into main (c9dbbc5) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #95   +/-   ##
=======================================
  Coverage   99.94%   99.94%
=======================================
  Files          25       25
  Lines        1857     1879   +22
=======================================
+ Hits         1856     1878   +22
  Misses          1        1

Impacted Files
Coverage Δ

rumydata/__init__.py
100.00% <100.00%> (ø)

rumydata/table.py
100.00% <100.00%> (ø)

tests/test_other.py
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Flutter Localization is not compatible with on-demand resources

I don't believe that iOS apps include all localizations by default, but maybe?  If they don't, we will want to be compatible with whatever on-demand system exists.
https://developer.apple.com/library/content/documentation/FileManagement/Conceptual/On_Demand_Resources_Guide/index.html#//apple_ref/doc/uid/TP40015083
FYI @cbracken

Localized Android apps are deployed from the play store bundled with the resources needed for all supported locales. See https://developer.android.com/distribute/best-practices/launch/localization-checklist.html

As far as I'm aware iOS apps do include all locales by default. App Slicing is done by device architecture and resolution (for code/asset thinning), and based on docs and local testing (iOS 10.3.3) it doesn't appear they're using on-demand loading behind the scenes for locale data.
I can imagine for apps with heavy localized assets (e.g. maybe a localized PDF user guide, or a lot of graphics that include text) we'll definitely want to support on-demand loading, but it doesn't appear to be part of UIKit's i18n implementation.

Sounds like we can close this. :)


Some options have been deprecated in Tor versions 0.2.3.x and above

This change makes torjail use the proper configuration proper syntax, appropriate for detected version.
Changed TOREXEC variable to TORBIN

I'll merge this, but for the future, I do prefer not to add other externals dependencies (egrep, xargs in this PR).


Prepare for internal/ice package

Removed SDP dependency from ice files. Exported string to ice enum
functions. Exported ICEServer.Validate.
Reference issue
Rel #645

Codecov Report

Merging #693 into master will increase coverage by 0.29%.
The diff coverage is 90.9%.

@@            Coverage Diff            @@
##           master    #693      +/-   ##
=========================================
+ Coverage   77.31%   77.6%   +0.29%
=========================================
  Files          57      57
  Lines        3641    3644       +3
=========================================
+ Hits         2815    2828      +13
+ Misses        585     577       -8
+ Partials      241     239       -2

Impacted Files
Coverage Δ

iceserver.go
92.85% <100%> (+0.85%)
:arrow_up:

peerconnection.go
72.14% <100%> (+0.28%)
:arrow_up:

icecandidatetype.go
100% <100%> (ø)
:arrow_up:

icetransportpolicy.go
75% <100%> (ø)
:arrow_up:

iceprotocol.go
100% <100%> (ø)
:arrow_up:

icecandidate.go
64.51% <100%> (-6.92%)
:arrow_down:

icegatheringstate.go
100% <100%> (ø)
:arrow_up:

icegatherer.go
82.05% <100%> (ø)
:arrow_up:

iceconnectionstate.go
100% <100%> (ø)
:arrow_up:

ice_go.go
90.24% <86.2%> (-9.76%)
:arrow_down:

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2049be...51ebcfe. Read the comment docs.

BTW should we eventually move the code that parses ICE candidates to pion/ice package?
IMO it's ice package responsibility :thinking:

@ernado if you mean sdp.ICECandidate  <-> webrtc.ICECandidate <-> ice.Candidate conversions, that's a good question, not sure where these would be best at.


fix: revert packaging change

:wrench: Summary
Revert https://github.com/evilmartians/lefthook/pull/794

@dalisoft, this didn't work, so I am reverting.

I am working on new approach, which should solve that case. npx or bunx does not work with current direct binary approach


(maint) Add in beaker run options listed as deprecated

When the beaker run options were defined, those listed as deprecated
were left out; in order to have parity with the current beaker
functionality, those should have been included.

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker_btc-intn/3932/


NIFI-11057 - add NAR provider nifi-registry

Summary
NIFI-11057
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking

[X] Apache NiFi Jira issue created

Pull Request Tracking

[X] Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
[X] Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

[X] Pull Request based on current revision of the main branch
[X] Pull Request refers to a feature branch with one commit containing changes

Verification
Please indicate the verification steps performed prior to pull request creation.
Checked that providing the env variable NIFI_NAR_LIBRARY_PROVIDER_NIFI_REGISTRY_URL  does add the two properties in nifi.properties
Build

[ ] Build completed using mvn clean install -P contrib-check

[ ] JDK 8
[ ] JDK 11
[ ] JDK 17

Licensing

[ ] New dependencies are compatible with the Apache License 2.0 according to the License Policy
[ ] New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

[ ] Documentation formatting appears as expected in rendered files

hello,
is this PR miss something to be accepted, or is it just a question of time for someone to have a look at it ?
Thanks 😀

Well, I'm not sure I completely followed the normal process for the review. I applied the requested change, but I don't know if the status of this PR is as expected.


No 0.0.6 alpha release for Debian Distributions ? :/

@amilajack
I use Ubuntu. I was checking for .deb files in the latest release and couldn't find one. Can you please build it for Debian Distributions too ?

Actually I'm thinking of taking down 0.0.6 because it's not finished yet

Thanks for the info!
I was actually surprised when git actually didn't show me any branch other than master when I did git branch, but looks like it detects them only when I check them out using git checkout branch_name. I will build it and check it out! :smile:

The reason why its difficult for me to build for all environments at once is because the app has native deps. Currently I have to manually compile on each machine and upload to github 😢

Oh. Just get some more people, say moderators, to compile for different machines. Choose them such that they use that corresponding machine extensively.

The proper way of doing this is using travis and appveyor artifacts. Haven't had the time to implement them yet :(

Oh okay..


Mouse highlight and clicks on multiple monitors

Currently I am only getting the mouse highlight on clicks displayed when the mouse clicks on my primary monitor (of a 3 monitor setup).  I still get the icon to show which mouse button I clicked when I click on another screen, but I only see the highlights on the mouse itself while on the primary screen.
I moved the display of key presses and mouse clicks to another monitor, thinking that the entire overlay was restricted to a single monitor, but even if I displayed the clicks on monitor 2, only monitor 1 would have mouse highlights directly on the cursor.

I guess you are talking about my fork? Unfortunately currently only the primary monitor shows the clicks If you switch primary monitor does it change?

tested on your fork 3.1 beta - key and click display follows (also during runtime) the primary screen


CocUpdate failed @types/node version not found

 verbose cwd /Users/beke/.config/coc/extensions/node_modules/@yaegassy_coc-intelephense-8b155473-dacf-48a9-af59-
d63de268
 verbose Darwin 22.3.0
 verbose node v19.8.0
 verbose npm  v9.5.1
 error code ETARGET
 error notarget No matching version found for<EMAIL_ADDRESS> error notarget In most cases you or one of your dependencies are requesting
 error notarget a package version that doesn't exist.
 verbose exit 1
 timing npm Completed in 3515ms
 verbose unfinished npm timer reify<PHONE_NUMBER>418
 verbose unfinished npm timer reify:loadTrees<PHONE_NUMBER>421

npm list -g
/usr/local/lib
├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>

I cannot reproduce it in my environment. I have checked it with Node.js 18.15.0 (LTS).
Try reinstalling coc-intelephense just to be sure.
:CocUninstall @yaegassy/coc-intelephense
:CocInstall @yaegassy/coc-intelephense


MAINT: Follow Nep29, bump minimum numpy.

As usual this is open for discussion.
See previous thread in #5089.
Also add a Nep29 badge to the readme.
for info Nep29 suggests:

On Jan 31, 2023 drop support for NumPy 1.20 (initially released on Jan 31, 2021)

This also remove any conditional branching based on numpy version.
Note that this is technically a change of API ad DTypeLiike is not exposed by napari.types anymore. I did not manage to keep it there as ruff is removing is as an unused import. I think that's ok as this was likely only used internally.
Type of change

[ ] Bug-fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

References
https://numpy.org/neps/nep-0029-deprecation_policy.html
Final checklist:

[x] My PR is the minimum possible work for the desired functionality
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[x] If I included new strings, I have used trans. to make them localizable.
For more information see our translations guide.

The ubuntu archive seem to have been down.
GitHub does not seem happy about it and won't let me restart the failing workflow for now... I'll do it later.

Minreq failure is unrelated, but maybe this PR could also affect that... maybe we shoudl wait? @Czaki any progress on the minreq issue?

I have created #5560.
I do not like it, but I do not think that I will be able to ship something better in short time.
My attempt for better solution is here but require time to polish https://github.com/Czaki/tox-min-req

Tests are good now, let's merge!


[TODO][good first issue] Uncap pylint-pytest in the dependency lists and lock files

It's pinned in a few files @ requirements/: https://github.com/search?q=repo%3Anedbat%2Fscriv pylint-pytest&type=code. This is due to https://github.com/reverbc/pylint-pytest/issues/20. The original project repository has been archived but the successor is being published to PyPI under the same project name and is hosted under @pytest-dev. They've ported my PR https://github.com/reverbc/pylint-pytest/pull/22 and merged it as https://github.com/pylint-dev/pylint-pytest/pull/15, releasing that under v1.1.6.
I just tried it out in another project and it ended up displaying a more informative error
. (C  0), ::F6401
************* Module cheroot.test.test_conn
cheroot/test/test_conn.py:L   1:(cannot-enumerate-pytest-fixtures) pylint-pytest plugin cannot enumerate and collect pytest fixtures. Please run `pytest --fixtures --collect-only cheroot/test/test_conn.py` and resolve any potential syntax error or package dependency issues. stdout: . stderr: ERROR: usage: pylint [options] [file_or_dir] [file_or_dir] [...]
pylint: error: unrecognized arguments: --numprocesses=auto --cov=cheroot --cov-report --cov-report xml:.test-results/pytest/cov.xml ~/src/github/cherrypy/cheroot--maintenance--macos-13/cheroot/test/test_conn.py
  inifile: ~/src/github/cherrypy/cheroot--maintenance--macos-13/pytest.ini
  rootdir: ~/src/github/cherrypy/cheroot--maintenance--macos-13

which made it more obvious that I'm lacking a few pytest plugins in the env where pylint is installed.
Action items

[ ] Delete the plugin entry from requirements/constraints.txt along with a comment explainer
[ ] Regenerate requirements/dev.txt and requirements/quality.txt with pip-tools using -P pylint-pytest arg
[ ] Check what pylint outputs after that, fix any linting violations and perhaps add more missing deps to requirements/quality.in, repeating the previous steps

@olenayefymenko would you like to give it a go?

@OlenaYefymenko would you like to give it a go?

Yes, I'll solve this.

Fixed in commit 53473f0fd108ade35df51d073fcb9cd9d56051bb


Customisable day length for .humanize()

Hi there.
Someone naievely tossed moment.humanize calls all through our application which has resulted in some epic confusion.
it'd be super awesome to be able to define that a day is "8 hours" or "7.5 hours"
Not super urgent, just would be a nifty feature.

+1
The 8 hours are a business day so yes, it would be super awesome.

i don't think we will take a change like this.
But, you can set relative time thresholds to show things in hours instead of days.
https://momentjs.com/docs/#/durations/humanize/
Best of luck with your projects!


InvertedListView example not working

Which version of the app?
WinUI 3 Gallery
Description
Following the example in the latest version of Windows App SDK does not produce the same results as in the WinUI3 Gallery App.
Screenshots
XAML code as provided in the example produces this:
<DataTemplate x:Key="MessageViewTemplate" x:DataType="local1:Message">
    <Grid Height="Auto" Margin="4" HorizontalAlignment="{x:Bind MsgAlignment}">
        <StackPanel MinHeight="75" Width="350" Padding="10, 0, 0, 10" Background="{x:Bind BgColor}" CornerRadius="{StaticResource ControlCornerRadius}">
            <TextBlock Text="{x:Bind MsgText}" Padding="0, 10, 0, 0" FontSize="20" Foreground="{ThemeResource SystemControlForegroundAltHighBrush}"/>
            <TextBlock Text="{x:Bind MsgDateTime}" Padding="0, 0, 0, 10" FontSize="15" Foreground="{ThemeResource SystemControlForegroundAltMediumHighBrush}"/>
        </StackPanel>
    </Grid>
</DataTemplate>

XAML code corrected (not a direct replacement, for my implementation):
<DataTemplate x:Key="MessageViewTemplate" x:DataType="models:StatusMessage">
    <Grid Height="Auto" Margin="4" Width="350">
        <StackPanel MinHeight="60" MinWidth="150" Padding="10, 0, 0, 10" Background="{x:Bind Background, Mode=OneWay}" CornerRadius="10" HorizontalAlignment="{x:Bind Alignment, Mode=OneWay}">
            <TextBlock Text="{x:Bind MessageText, Mode=OneWay}" Padding="0, 10, 0, 0" FontSize="16" Foreground="{ThemeResource SystemControlForegroundAltHighBrush}"/>
            <TextBlock Text="{x:Bind MessageTime, Mode=OneWay}" Padding="0, 0, 0, 10" FontSize="10" Foreground="{ThemeResource SystemControlForegroundAltMediumHighBrush}"/>
        </StackPanel>
    </Grid>
</DataTemplate>

Issues corrected:

HorizontalAlignment was set on the grid instead of the stackpanel
Width was set on the stackpanel instead of the grid

Not sure how the app works as intended but I could not produce the same results in the latest Windows App SDK version.
Windows version
November 2021 Update/21H2 (19044)
Additional context
No response

Thank you for your feedback! I'm afraid though, this is not a bug since the XAML Code shown in the gallery is the same as the code that is powering the sample you are seeing there. The only thing that was out of date were the colors which will be adjusted by #1383. Hence I'll close this issue, if you feel this is an issue, feel free to reopen this issue.


Enable upwards thread continuation [draft]

This PR implements upwards thread continuation. Pending UI polish, and tests/testing. It looks like this:

(screenshot taken with max depth of 3, instead of the usual 6, for illustration purposes)
Testing this requires corresponding changes to getPostThread, made in https://github.com/bluesky-social/atproto/pull/1062 (however, this PR can/should be merged first - there ought not to be any observable changes until getPostThread is changed)
(in theory) the Continue Thread button will appear at the top of a thread, if it detects that the thread has been truncated, with similar logic to the existing (downwards) Continue Thread button.
This fixes recursion depth errors encountered when viewing "hellthreads" on mobile devices, or even longer threads on desktop devices.
Edit: I have only tested this on desktop web thus far

It might be nice to also have a button that navigates directly to the thread root, not sure how the UI/UX should work there though

Is this needed? The thread route is supposed to give you all parents right now

The thread route is supposed to give you all parents right now

Not any more! My PR that limits it to 80 by default was merged already and is in prod, but the UI just shows it as an abrupt cutoff.
You can see this in my very long test thread https://staging.bsky.app/profile/test2.retr0.id/post/3jvxho3cvlc24 (click the topmost post to see more of the thread)

oops I just nuked my branch for this because I suck at git (shouldn't have used main in the first place...)
I can bring it back if there is sufficient interest, but this PR was kinda stale anyway.


"Received an action call without an action" - Custom Actions, POST Request

Rasa version: 1.4.3
Python version: 3.7
Operating system (windows, osx, ...): Mac OS X High Sierra
Issue: Custom Action via POST Request not working
Error (including full traceback): I have set up a custom action and defined it in my domain.yml, and also set up the endpoint in endpoint.yml at "http://localhost:5055/webhook", however, when I call the post request I get a 200 response but there is no output by the bot and I get a warning that "Received an action call without an action". If I call the action just by conversing with the bot it works well, the message is dispatched.

2019-11-05 19:14:14 WARNING  rasa_sdk.endpoint  - You are using an old version of rasa which might not be compatible with this version of rasa_sdk (1.4.0).
To ensure compatibility use the same version for both, modulo the last number, i.e. using version A.B.x the numbers A and B should be identical for both rasa and rasa_sdk.
2019-11-05 19:14:14 WARNING  rasa_sdk.executor  - Received an action call without an action.
<IP_ADDRESS> - - [2019-11-05 19:14:14] "POST /webhook HTTP/1.1" 200 144 0.005133

Content of configuration file (config.yml) (if relevant):

language: en
pipeline: supervised_embeddings
policies:
- name: MemoizationPolicy
- name: KerasPolicy
- name: MappingPolicy

Content of domain file (domain.yml) (if relevant):

intents:
- greet
- goodbye
- affirm
- deny
- mood_great
- mood_unhappy
- bot_challenge
- bored
- joke

templates:
  utter_greet:
  - text: Hey! How are you?
  utter_cheer_up:
  - text: 'Here is something to cheer you up:'
    image: https://i.imgur.com/nGF1K8f.jpg
  utter_did_that_help:
  - text: Did that help you?
  utter_happy:
  - text: Great, carry on!
  utter_goodbye:
  - text: Bye
  utter_iamabot:
  - text: I am a bot, powered by Rasa.
  utter_joke:
  - text: Would you like to hear a joke?
  utter_onejoke:
  - text: There was once a person talking to a bot.
  utter_nojoke:
  - text: Alright, suit yourself.

actions:
- utter_greet
- utter_cheer_up
- utter_did_that_help
- utter_happy
- utter_goodbye
- utter_iamabot
- utter_joke
- utter_onejoke
- utter_nojoke
- action_main

ACTION.PY
from rasa_sdk import Action
from rasa_sdk.events import SlotSet
from datetime import datetime
from crontab import CronTab
import schedule
import timE
class ActionMain(Action):
def name(self):
    return "action_main"

def run(self, dispatcher, tracker, domain):

    dispatcher.utter_message("Our chatbot is live")

    return []

POST REQUEST:
import requests
import json
url = 'http://localhost:5055/webhook'
#url = "http://localhost:5055/conversations/default/execute"
headers = {'Content-type': 'application/json'}
dx = json.dumps({"name": "action_main"})
requests.post(url, data=dx, headers=headers)
Please help me, I am not being able to call my custom action when running via post. Thanks.

Thanks for raising this issue, @erohmensing will get back to you about it soon✨
Please also check out the docs and the forum in case your issue was raised there too 🤗

Hi there @aejaex. From your code, it looks like you're posting to /webhook, not /conversations/default/execute. The latter is the correct endpoint for the external actions, can you confirm which you're using when you're getting the "received an action... " warning?
Also, what channel are you using to test this functionality?

Hello @erohmensing, I tried using "/conversations/default/execute", however I get a 404 error in my terminal when I post to it. My full URL for POST requests is:
http://localhost:5055/conversations/default/execute
and I have defined the same in my endpoints.yml file as well....
This is my POST request code:
/////////////////////////////
import requests
import json
url = "http://localhost:5055/conversations/default/execute"
headers = {'Content-type': 'application/json'}
dx = json.dumps({"name": "action_hello_world"})
requests.post(url, json={"name": "action_hello_world"}, headers=headers)
/////////////////////////////
Please help...

What command are you using to run your server? In order to use the /conversations/default/execute endpoint, you have to enable the api with the --enable-api flag.

Hi @erohmensing , I have run my shell using the enable-api flag, using: "rasa shell --enable-api". The shell works fine, I can have my conversation. Then I run "rasa run actions" and activate my action server. However, I am still not able to call my actions through the API - I keep getting a 404 error.
My terminal output:
"POST /conversations/default/execute HTTP/1.1" 404 341 0.001052
My URL endpoint:
"http://localhost:5055/conversations/default/execute"
Please help...

Ah, I see the problem, I think. POST /conversations/default/execute is part of the Rasa API, not the rasa sdk (actions server) API. so you should be posting to
"http://localhost:5005/conversations/default/execute"

instead of
"http://localhost:5055/conversations/default/execute"

Didn't catch that in the initial code.

@erohmensing Just tried that Ella - I don't get a response from the server when I change it to localhost:5005...
So just to add some details -

I am running the rasa shell to test my bot, using "rasa shell" in my terminal. My shell activates on localhost:5005.

I run my actions using "rasa run actions" - My action server activates on localhost:5055.

Do I need to enable something in the credentials or any other file?
My credentials.yml looks like this:
# This file contains the credentials for the voice & chat platforms
# which your bot is using.
# https://rasa.com/docs/rasa/user-guide/messaging-and-voice-channels/

rest:
#  # you don't need to provide anything here - this channel doesn't
#  # require any credentials

#facebook:
#  verify: "<verify>"
#  secret: "<your secret>"
#  page-access-token: "<your page access token>"

#slack:
#  slack_token: "<your slack token>"
#  slack_channel: "<the slack channel>"

#socketio:
#  user_message_evt: <event name for user message>
#  bot_message_evt: <event name for but messages>
#  session_persistence: <true/false>

#mattermost:
#  url: "https://<mattermost instance>/api/v4"
#  team: "<mattermost team>"
#  user: "<bot username>"
#  pw: "<bot token>"
#  webhook_url: "<callback URL>"

rasa:
  url: "http://localhost:5002/api"

And my config.yml looks like:
# Configuration for Rasa NLU.
# https://rasa.com/docs/rasa/nlu/components/
language: en
pipeline: pretrained_embeddings_spacy

# Configuration for Rasa Core.
# https://rasa.com/docs/rasa/core/policies/
policies:
  - name: MemoizationPolicy
  - name: KerasPolicy
  - name: MappingPolicy
  - name: "FallbackPolicy"
    nlu_threshold: 0.1
    ambiguity_threshold: 0.01
    core_threshold: 0.3
    fallback_action_name: "fallback_action"

My POST request file looks like:
import requests
import json

#url = 'http://localhost:5055/webhook'

url = "http://localhost:5005/conversations/default/execute"

headers = {'Content-type': 'application/json'}

dx = json.dumps({"name": "fallback_action"})

requests.post(url, data=dx, headers=headers)

And my endpoints.yml looks like:
# This file contains the different endpoints your bot can use.

# Server where the models are pulled from.
# https://rasa.com/docs/rasa/user-guide/running-the-server/#fetching-models-from-a-server/

#models:
#  url: http://my-server.com/models/default_core@latest
#  wait_time_between_pulls:  10   # [optional](default: 100)

# Server which runs your custom actions.
# https://rasa.com/docs/rasa/core/actions/#custom-actions/

action_endpoint:
  url: "http://localhost:5055/webhook"

# Tracker store which is used to store the conversations.
# By default the conversations are stored in memory.
# https://rasa.com/docs/rasa/api/tracker-stores/

#tracker_store:
#    type: redis
#    url: <host of the redis instance, e.g. localhost>
#    port: <port of your redis instance, usually 6379>
#    db: <number of your database within redis, e.g. 0>
#    password: <password used for authentication>
#    use_ssl: <whether or not the communication is encrypted, default false>

#tracker_store:
#    type: mongod
#    url: <url to your mongo instance, e.g. mongodb://localhost:27017>
#    db: <name of the db within your mongo instance, e.g. rasa>
#    username: <username used for authentication>
#    password: <password used for authentication>

# Event broker which all conversation events should be streamed to.
# https://rasa.com/docs/rasa/api/event-brokers/

#event_broker:
#  url: localhost
#  username: username
#  password: password
#  queue: queue

Again thanking you for your prompt response ! I have had good success using rasa for my chatbot's intelligence, but I now need to get it out of the terminal and into a production environment so needing this to work !

Okay. The issue is with the shell as an input channel -- it waits for you to enter input before proceeding to do anything. therefore the server itself is kind of stuck. If you for example press enter in the shell after posting the request, you should see the action process (albeit it should also process an extra empty input, which you obviously don't want). However that shouldn't be an issue once you are getting it out of the terminal!

@erohmensing Great ! Looks like we're making progress. So now I'm on Rasa X, and when I call the post request at localhost:5005, I get a 200 response, which means it's working fine. However still no output on the chat screen yet. It appears that since the bot is already on action_listen it doesn't dispatch a message. How do I get around this ?

Hm, that's probably the same issue that it's waiting for your input, unfortunately

Right, I guess I'll need to make a new issue to sort that out - any tips to not do action_listen and allow the bot to initiate a conversation? I've gone through these:
https://forum.rasa.com/t/bot-initiated-notifications-again/12562/6
https://github.com/RasaHQ/rasa/issues/2155

@erohmensing @aejaex. I also facing the same problem. can I downgrade rasa?
rasa==1.4.3
rasa-sdk==1.4.0
rasa-x==0.22.1

is it fine?

2019-11-08 06:39:42 INFO     rasa_sdk.endpoint  - Starting action endpoint server...
2019-11-08 06:39:42 INFO     rasa_sdk.executor  - Registered function for 'action_program'.
2019-11-08 06:39:42 INFO     rasa_sdk.executor  - Registered function for 'action_Python_program'.
2019-11-08 06:39:42 INFO     rasa_sdk.endpoint  - Action endpoint is up and running on http ('<IP_ADDRESS>', 5055)
<IP_ADDRESS> - - [2019-11-08 06:45:55] "POST /webhook/ HTTP/1.1" 404 341 0.002695
<IP_ADDRESS> - - [2019-11-08 06:46:50] "POST /webhook/ HTTP/1.1" 404 341 0.002077

@erohmensing Hmm, it seems the mechanism to have a bot initiate the conversation is rather complicated. I am going to start a new issue for that because I'm using UserUttered() and while the action is called, there is no output from the bot on the chat front.

Hi guys, I have similar problem. I have a local webpage that is a photo viewer base on Mirador, and I implemented a bot rasa.
Every time I change photo there is a function that sends to Rasa bot an intent with the link of the page, and this intent triggers a custom action. If I do "run rasa actions" and "rasa run -m models --enable-api --cors “*” --debug -p 5005" , the intent looks like isn't sent to rasa bot (or the custom action isn't triggered, I don't know) , but if I exit the cmd with "rasa run action", it works like in photo:

Can you help me?
This is the intent:
- intent: EXTERNAL_page_change   examples: |     - page change [HERE I PUT THE LINK OF PHOTO](page_url)
This is the action:
`utter_EXTERNAL_page_change:

text: "You have changed page : {page_url}."This is the custom action:from rasa_sdk import Action, Tracker
from rasa_sdk.executor import CollectingDispatcher
from rasa_sdk.events import SlotSet

class setTopic(Action):
def name(self):
    return "action_set_Topic"

def run(self, dispatcher, tracker, domain):
    link_page = tracker.get_slot("page_url")

    return[SlotSet("topic", link_page)]`


Drag content integration test preparation

[x] Move test templates from helper to current repo (to have possibility to adjust according to test needs)
[x] Add second plugin for testing purposes

Related to https://divio-ch.atlassian.net/browse/CMS-882

Duplicates https://github.com/FinalAngel/django-cms/pull/106


Starting client error

Hi, i installed all modules which he required and when i try to start OblivionClient i get this error:
# python3 OblivionClient.py
qt.qpa.plugin: Could not load the Qt platform plugin "xcb" in "" even though it was found.
This application failed to start because no Qt platform plugin could be initialized. Reinstalling the application may fix this problem.

Available platform plugins are: eglfs, linuxfb, minimal, minimalegl, offscreen, vnc, wayland-egl, wayland, wayland-xcomposite-egl, wayland-xcomposite-glx, webgl, xcb.

Aborted (core dumped)

PyQt5 is installed

Hi, i installed all modules which he required and when i try to start OblivionClient i get this error:
# python3 OblivionClient.py
qt.qpa.plugin: Could not load the Qt platform plugin "xcb" in "" even though it was found.
This application failed to start because no Qt platform plugin could be initialized. Reinstalling the application may fix this problem.

Available platform plugins are: eglfs, linuxfb, minimal, minimalegl, offscreen, vnc, wayland-egl, wayland, wayland-xcomposite-egl, wayland-xcomposite-glx, webgl, xcb.

Aborted (core dumped)

PyQt5 is installed

Hello, can you send me please your python version and OS name/version?

Hi, i installed all modules which he required and when i try to start OblivionClient i get this error:
# python3 OblivionClient.py
qt.qpa.plugin: Could not load the Qt platform plugin "xcb" in "" even though it was found.
This application failed to start because no Qt platform plugin could be initialized. Reinstalling the application may fix this problem.

Available platform plugins are: eglfs, linuxfb, minimal, minimalegl, offscreen, vnc, wayland-egl, wayland, wayland-xcomposite-egl, wayland-xcomposite-glx, webgl, xcb.

Aborted (core dumped)

PyQt5 is installed

Hello, can you send me please your python version and OS name/version?

hi, i have python2.7 and 3.6
CentOS Linux release 7.9.2009 (Core)
tnx

hi, i have python2.7 and 3.6
CentOS Linux release 7.9.2009 (Core)
tnx

Hello, y0d4a. Currently the CentOS Linux is not compatible with the Oblivion.
It's recomended that you use the Windows 10 for graphical use or Ubuntu 20.04 for the server use. By the way you can try another OS, but is not guarented the instabilitie or correctly functionalite and  make sure that you are using the Python 3.8.
For more informations please read the documentation.

Hello, y0d4a. Currently the CentOS Linux is not compatible with the Oblivion.
It's recomended that you use the Windows 10 for graphical use or Ubuntu 20.04 for the server use. By the way you can try another OS, but is not guarented the instabilitie or correctly functionalite and  make sure that you are using the Python 3.8.
For more informations please read the documentation.

thank you

thank you

hi, i just setup it on latest ubuntu.
But when i try to start client he breaks:
`$ sudo python3.8 OblivionClient.py
qt.qpa.plugin: Could not load the Qt platform plugin "xcb" in "" even though it was found.
This application failed to start because no Qt platform plugin could be initialized. Reinstalling the application may fix this problem.
Available platform plugins are: eglfs, linuxfb, minimal, minimalegl, offscreen, vnc, wayland-egl, wayland, wayland-xcomposite-egl, wayland-xcomposite-glx, webgl, xcb.
Aborted
`

Hello, y0d4a!
For your can use the Client mode (GUI) you will need to work with Windows 10. The Client mode is not compatible with GNU/Linux.
If you want to use the Oblivion with Linux you'll need to use the Server mode. The Ubuntu Server is focused unique to Oblivion Server hosting.


Dependency audit

Before really deploying this, we'll need to really audit our dependencies. Let's use this issue for any notes related to this

I was just looking at reed-solomon-erasure crate and saw a concerning "Merged several PRs ... Not fully reviewed as I am no longer maintaining this crate" note for version 5.0 in the changelog.

If you are already going to spend the effort on reviewing stuff, consider using cargo-crev to publish the results. There are some plans to use it for rust-bitcoin already.

Just noticed that hbbft is compiled by the client crate ... which is silly

Just noticed that hbbft is compiled by the client crate ... which is silly

cargo tree -p mint-client says we need to move hbbft dep from fedimint-api to fedimint-server.

Think this is closed by https://github.com/fedimint/fedimint/pull/2187


Mistake in checking for duplicates.

In index.php on line 156, no argument for filesize:
    filesize() === $_POST['filesize']

I have a question - how are you dealing with duplicate names (not necessarily duplicate content)?

how are you dealing with duplicate names (not necessarily duplicate content)?

If the name matches an existing file but the file size is different, we assume that the previously uploaded file was uploaded incompletely and overwrite it with the new one.
This is modelled after the canonical Python implementation.

That's actually BAD. The thing is that all photos from different folders on the client are uploaded into one folder on server - name collision may happen (and eventually data loss in case user removes file(s) from his device).

I agree. You can easily solve this right now with a small code tweak:
--- index.php
+++ index.php
@@ -143,7 +143,10 @@
  * Sanitize the file name to maximise server operating system compatibility and
  * minimize possible attacks against this implementation.
  */
-$filename = preg_replace('@\s+@', '-', $_FILES['upfile']['name']);
+$filename = explode('.', $_FILES['upfile']['name']);
+array_splice($filename, -1, 0, array(md5_file($_FILES['upfile']['tmp_name'])));
+$filename = implode('.', $filename);
+$filename = preg_replace('@\s+@', '-', $filename);
 $filename = preg_replace('@[^0-9a-z._-]@i', '', $filename);
 $target = $MediaRoot . '/' . $filename;

I am not sure what the best place would be to file that as an issue for PhotoBackup as a whole, possibly at PhotoBackup/api. (Ping @stephanepechard.) I would love to put some time into PhotoBackup again, but life has been getting in the way.

How can I apply this patch (yeah, I know, dumb question, still learning things about GitHub)?

Sorry, I was at work and just threw this out there real quick. For further reading, what I posted is a patch file and could be applied using different diff tools. The simplest is putting it in a text file in the same folder as the index.php and then use patch on the command line:
$ patch < change.diff

It would automatically put the changes into your index.php.
Here is the patched index.php for your convenience.

And for my own use, here is the patch for this issue:
--- index.php
+++ index.php
@@ -153,7 +153,7 @@
  */
 if (
     file_exists($target) &&
-    filesize() === $_POST['filesize']
+    filesize($target) === $_POST['filesize']
 ) {
     header($protocol . ' 409 Conflict');
     exit();

Thank you!


Suggestion about deep/shallow copying

Maybe it would be better to define/describe the meaning of "deep/shallow copy" at first and then give examples for them.

In "Recursion" section there are some typos in the code part.
"class Node(object)" should be change to "class Tree(object)" based on the rest of the code.
"self.value" = value should be change to "self.value = name"

Thanks @elnazazizi for these, I'll make those changes (or feel free to do a PR)

fixed in c6f9e36


Upload all containers of Blob Storage IoT Edge module

We are currently trying to implement the Azure Blob Storage on IoT Edge module into an existing IoT Edge solution. The solution dynamically creates blob storage containers with names that are generated at runtime.
The desired properties configuration "storageContainersForUpload" allows us to define static source container names and dynamic target container names.
"storageContainersForUpload": {
  "sourceContainer": {
    "target": "%c"
  }
}

Since the solution produces dynamic source container names, we need a way to tell the storage module to treat every existing container as a source container and to use its container name as the target container name.
Please tell me there is a way to implement this behavior. This module is doing everything we need to accomplish, but handling dynamic source container names.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 07a44a28-a19c-f68e-167c-5e8ad91605e0
Version Independent ID: 33eacdff-4f0a-c543-d8f9-e7b208bab015
Content: Store block blobs on devices - Azure IoT Edge
Content Source: articles/iot-edge/how-to-store-data-blob.md
Service: iot-edge
GitHub Login: @kgremban
Microsoft Alias: kgremban

Hello @langebo Thanks for reaching out to us!.
Looks like the issue is more related to 'Product-Implementation' which can be posted on Microsoft Q&A  Or Azure/IotEdge Github page to get a solution from community champions or MVPs or directly from Product Team.
I suggest you to post this "How-To" query on

Directly under the Azure-IoTEdge-GitHub Feature Request page , Or
Microsoft Q&A forum with tag 'azure-iot-edge'

Please let us know if you need further help in this matter.

@SatishBoddu-MSFT Thank you. I have posted this question to the Microsoft Q&A portal.
You can find the question here: https://docs.microsoft.com/en-us/answers/questions/168262/upload-all-containers-of-blob-storage-iot-edge-mod.html
Closing this issue, since it's probably continued on the Microsoft Q&A portal


String or File

https://github.com/bcbio/test_bcbio_cwl/blob/master/somatic/somatic-workflow/steps/prep_samples.cwl
Here there is a task that where two of the inputs are listed as String and/or File. What does that mean?
    - name: config__algorithm__variant_regions
      type:
      - 'null'
      - string
      - File

    - name: config__algorithm__coverage
      type:
      - 'null'
      - string
      - File

Thanks!

Ruchi;
Some CWL implementations had trouble with the CWL null as an input so I pass in a string "null" instead (and then convert this into None properly as part of bcbio). So these types are allowing that, the input can essentially be either a file or nothing, but nothing is represented by either the CWL null or a string null. Let me know if this is causing any issues. Thanks again.

Hey @chapmanb ,
If I understand you correctly, the syntax above is to represent an optional file, which should officially be written as:
type:
- File?

And the current mixed string/file syntax is a workaround to accommodate that not all CWL implementations have support for passing in a null File. From Cromwell's perspective, it interprets the final type of config__algorithm__variant_regions to be a String (and not File) and hence it was not staging inputs properly.
A few questions:

When you say bcbio converts null strings into a None, how does that happen? Does that mean running a step before the workflow starts to generate null task outputs?
Sorry I'm still new with the CWL spec, but is a user required to provide a string null as an input for File? types? Isn't that the assumed default?
Whats the difference between:
a.

type:
- File?

and
b.
type:
- "null"
- File

Are CWL implementations supposed to treat them the same way?

Ruchi;
The File? is fairly new, I believe but is meant to be the same as ["null", File]:
https://www.commonwl.org/v1.0/Workflow.html#Document_preprocessing
So they should be equivalent. I'm not sure how many engines support the ? syntax so have been trying to stay more vanilla and conservative with the bcbio syntax.
To be clear the string "null" sentinel usage isn't a specification, just a workaround/hack for issues with runners that treat null inconsistently. Some of them remove it so lists of items like:
["file_name1", null, "file_name2"]

end up as:
["file_name1", "file_name2"]

which results in confusion since the null is a placeholder for a missing/not present value in one of the samples. So instead we do:
["file_name1", "null", "file_name2"]

and within bcbio it turns the "null" into None as part of the processing steps.
Why does Cromwell prefer "string" over "File" here? Is it possible to use File preferentially if it's one of the options? We do use the null/string workaround pretty regularly in bcbio but I could revisit if it's breaking things, just explaining why we're doing it this way now.
Thanks again for the discussion.

Hey Brad,
Thanks for explaining the syntax! On the Cromwell side, I think the coercion never really turned into a None, and Cromwell keeps trying to localize a file called "null" and failing.
We're looking into it further on our end, and I will create a separate and more specific issue based on findings!


Connection mode usage tips missing ?

The Java Async SDK supports "Direct" mode for a while now (guess a few months back, support was added) and we started using Direct mode based on experiences with Sync SDK. The page misses recommendation on the usage between Gateway and Direct.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 050823fb-8a4b-b86e-cadf-f55f81399a7b
Version Independent ID: 439cd1dd-2e7a-5e0e-77bc-6127292d62fb
Content: Azure Cosmos DB performance tips for Async Java
Content Source: articles/cosmos-db/performance-tips-async-java.md
Service: cosmos-db
GitHub Login: @SnehaGunda
Microsoft Alias: sngun

@Ramji-S, Thanks for the feedback!  We are investigating and will update you shortly.

@Ramji-S We are checking this with our author for further help.
@SnehaGunda Please check this further and help to get the document enhanced.

@Ramji-S I think the connectivity mode details for Java Async and the sync SDKs are pretty much the same. Not sure though I sent a confirmation email to our dev team. For the Sync SDK, you can find the details here: https://docs.microsoft.com/en-us/azure/cosmos-db/performance-tips-java#networking

@kushagraThapar is our dev SME on the Async Java SDK. He mentioned Sync Direct mode is much different from async Direct mode. He will be updating the doc soon to call out the differences.
Thanks Kushagra.

@Ramji-S Please let us know if you have any further questions in this regard.

@NavtejSaini-MSFT Thanks for the follow up. I am good. Please have the "ports" part as well if its needed for DirectHttps mode in Async. I am being told that even for Async Java, ports (10000 - 20000)need to be opened for direct mode. Any insights on this in documentation would greatly help.

@SnehaGunda Can you please check if the document can be enhanced with this information.

The above PR has doc updates with connection mode details. We will now close this issue.
#please-close


Update to run with notebook 4.2

Do not merge until notebook 4.2 is released.

Use the new canonical API from https://github.com/jupyter/notebook/pull/879

[ ] update __int__.py with new structure
[ ] remove internal nbextension structure
[ ] update conda.recipe

[ ] meta.yml
[ ] (post|pre)-(un)link.(bat|sh)

[ ] investigate whether the kernel manager can be hot-swapped

Unlike some of the other extensions, nb_conda_kernels might not be able to be a "pure" server extension, as it needs something changed in the configuration outside of the (new) nbserver_extensions key, namely kernel_spec_manager_class which will already have been loaded by the time the server extension hits.
An issue was created to allow general enable-time configuration:
https://github.com/jupyter/notebook/issues/1196
With an eye towards keeping scope creep down, this will likely not land in notebook 4.2, unless we advocate strongly for it, and do the work... but since we don't really care how many commands a user has to run (i mean, conda install), this wouldn't buy us much.

this is pretty off-topic. sorry

:handbag:-o-files
A proposed long-term approach (5.0) is to adopt a bag-of-files approach for configuration. This would be great for us, as it would make it very easy to put extensions into Anaconda, would remove the need for post-link/pre-unlink scripts, etc. as we'd just have to create a unique (built!) JSON file (per package) in a predictable location which would be automatically read on Jupyter app launch.
Right now, the jupyter apps look in the $CONF paths (or the equivalent win paths):

~.jupyter
${PREFIX}/etc/jupyter
/usr/local/etc/jupyter
/etc/jupyter
some command line thing

for:

jupyter_notebook_config.json
nbconfig/

tree.json
notebook.json
common.json
terminal.json
editor.json

other stuff

All these will likely be maintained for backwards-compatibility's sake, as they are countable, and a good place to put different user config choices. In addition, a new folder (say, conf.d) in each $CONF path would contain, for example, nbconfig/conf.d/nb_conda_kernels.json.
Inside of this would be either a pure config object:
{"NotebookApp" : {
  "nbserver_extensions": {"nb_conda_kernels": true},
  "kernel_spec_manager_class": "nb_conda_kernels.CondaKernelSpecManager"},
}

...or a wrapped one, to provide metadata suitable to drive an (unconfigurable!) GUI, introspection, etc...
{
  "version": "0.1.0",
  "name": "nb_conda_kernels",
  "title": "Conda Kernels",
  "description": "Use R, Python and other languages from local conda environments as Jupyter kernels",
  "autoenable": true,
  "...": ..., # other things i haven't imagined
  "config": ..., #the thing from above
}

These would certainly be schema constrained.
Some issues arise, such as in what order to load the config (or thought differently, precedence).  What if nb_conda_kernels is fighting something else for kernel_spec_manager_class? Who wins?
The proven approach from, say, apache httpd is to use natural ordering, i.e. 001_nb_conda_kernels.json. This could also be hidden inside the config wrapper... probably better.
Whoever is "better" (let's say, larger) wins.
In addition, in a wrapper one could include a validation step: perhaps using the JSON Patch test op, a JSON schema, or some home-rolled validation. This would amount to duplicating the config, probably, but would be a declarative, data-driven way to ensure the health of the system. Basically, one could say "if nb_conda_kernels is enabled, then kernel_spec_manager_class must be CondaKernelSpecManager".
Other approaches could involve JSON Patch or JSON-LD.

Fixed by #20


Closing button in scene tabs still uses the 2.x theme

Ubuntu 17.04 - Build: b034c4e
Issue description:
Self-explanatory.

CC @toger5 @djrm


Support for rosbag

I can as it is record with rosbag from topics posted by kinect2_bridge. However it would be nice if I only needed to record raw depth, ir and rgb. If kinect2_bridge could have an option to grab raw input from topics instead of from libfreenect2, and then process all of the derived topics. Things would be greatly simplified.
Maybe it would be cleaner to make a kinect2_bag package. Or possibly to split kinect2_bridge into a grabber and a processor.

Hi,
yes it is a good idea. I will look into it.

I divided the single parts into multiple nodelets. One nodelet that just receives the data from libfreenect2 and published it through ROS topics, and others for the processing, for example the registration, etc. But it seems to create too much overhead, even with zero-copy pointer transfers between the nodelets. It was not able to provide 30 fps for compressed registered depth images, while the CPU load was between 70 to 80 percent. The current implementation manages 30 fps on compressed depth and rgb images while having a CPU of ~40 percent.
But it's still possible to just record the topics that your nodes listen too. And recording the compressed images reduces the bag file size.


Unless debugging, show a more useful format for the askfors

Will show a human readable time that the getdata will be triggered. Easier to follow.

Aww... you don't like unix timestamps? :P

Don't get me wrong I like them but I also like something that's more human readable haha


video  orientation

So grateful for your admirable code，but when I record in landscape mode with front camera  the video was reversed In the vertical direction，if it was the reason of the  variable private boolean upsideDown ?

Hi,
I'm not currently maintaining this unfortunately. However, I do recall issues with certain camera sensors being mounted upside down, hence the video being reversed. This could be the case for you, and if it is - you'll have to manually flip the video.


Remove autologin

Remove the "autologin" behaviour, where chainlit automatically opens the oauth provider when there is only one set.

Thank you so much for opening PR for this.

@dokterbob sorry, mistake on my end... I will PR only the https://github.com/Chainlit/chainlit/commit/ec86e35cc6fa0640fe94cc587042badbecd9bc17 commit


Build.gradle: always target newest react-native version

0.62.0-rc.2 fails for me with the following error:
* What went wrong:
Execution failed for task ':react-native-build-config:javaPreCompileDebug'.
> Could not resolve all files for configuration ':react-native-build-config:debugCompileClasspath'.
   > Failed to transform react-native-0.13.0.aar (com.facebook.react:react-native:0.13.0) to match attributes {artifactType=android-classes, org.gradle.category=libra
ry, org.gradle.libraryelements=jar, org.gradle.status=release, org.gradle.usage=java-api}.
      > Execution failed for AarToClassTransform: /home/coco/.gradle/caches/transforms-2/files-2.1/782808d835a5233e0664f2d391bb55b3/jetified-react-native-0.13.0.aar.
         > duplicate entry: META-INF/MANIFEST.MF

I am not exactly sure why this is, but making sure that the lib targets the latest react-native version solves the problem. Maybe bumping up the version instead of using + is more appropriate.

@hsjoberg thanks for your contribution.
I think is more appropriate in this case to use the + only.
Cheers


Boilerplate for maps for now

Map for ionic demo

closing in favor of https://github.com/xiyuoh/ionic_demo/pull/5


documentation-site

I made some changes to the documentation site

Whoa thanks! Can you walk me through the high level changes? The diff is pretty large.

I modified the theme with docz-theme-extended. The normal docz website does not have some basic documentation features plus is also not good looking.

Hey Caddy 👏🏿,
I need you to go through the website menu and check for any improvements that can be made. I want to know if there are any other new sections that you would like to be added to the website and if you are okay with the current naming and structuring.
I'm also thinking of creating a quick start guide with the warthog-starter project, the tutorial will guide a new user through executing queries and permutations.

Just started reviewing :)

Hey, the changes look great, thanks.  I've left some comments.  In general, before we can merge, we'll need:

COMING SOON is too large... let's shrink it a bit and use Coming soon casing
I'd like to get some docs on each of the coming soon pages, even if it's just a quick blurb
I need to clean up the docs that are there, they're really messy

I'm on vacation right now - will try to get this done over the weekend.

As for the warthog-starter quickstart guide, pls open an issue in that repo and let me know what you're thinking.

As for the warthog-starter quickstart guide, pls open an issue in that repo and let me know what you're thinking.

I just want to create a quick start guide for warthog with the project, something like prisma quickstart.
The guide will involve issuing queries and mutations with warthog, just something to just give newcomers a brief overview of working with warthog without making them go through the full installation process.

Sure, sounds good.  Ideally this would be hosted in the main docs, not on the starter repo.  Why don't you come up with something in markdown format and I'll take a look at it?


Update deploy-a-zola-site.md

The documentation is related to Zola, but the instructions talk about Hugo, so I change this section:
pkg install hugo

This issue appears is a duplicate of #908. I'm going to close it now, but feel free to open a new issue or ask any questions.


[Nicety] Class Averages

Teachers can input weights and scales that will create class averages and student reports.

Closed due to lack of time


Using sh.cd to go to the home directory

Is there some way to simulate cd (in order to go to the home directory) without giving arguments to sh.cd? Currently:
>>> sh.cd
<bound method Environment.b_cd of {}>
>>> sh.cd()
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
TypeError: b_cd() takes exactly 2 arguments (1 given)

Another question: what other "Environment" methods are there besides cd?

No
Take a look at the source

Maybe it is possible to use os.path.expanduser('~') to provide a cd:

def b_cd(self, path):
    if path:
        os.chdir(path)
    else:
        os.chdir(os.path.expanduser('~'))

Thanks

@rsmith31415 that looks pretty close.  I would make path have a default value of None though in the function.  Open a PR and I will likely merge it :)

If you think it is that simple to solve, sure.


adding blank lines to test the workflow

adding blank lines to test the workflow. this is no change, and don't need to approve the PR.

Closing PR per Max's comment above.


Pulling large images not working via Ingress

Problem/Motivation
It is not possible to pull larger images like "homegear/rpi-homegear:latest".
Expected behavior
The image should be pulled.
Actual behavior
I get an error that the image does not exist. This error only occurs when working via hassio Ingress. The function is working correctly when directly accessing your portainer instance via a defined port.
Steps to reproduce

Go to "Images" in the left hand menu in portainer.
Enter "homegear/rpi-homegear:latest" intro the image field.
Click "Pull the image".

Proposed changes
Pulling larger images should work via Ingress as well.

I've looked into this, first of all, I'm unable to reproduce this.
However, with this add-on, direct access vs ingress are exactly the same from the add-on side of things. So the only thing I can come up with, it an issue in the Ingress handling inside Home Assistant.

Still having the same problem. In the log on the supervisor page, I always get an "proxy error: context canceled" error, when the download of an image failed. I recently tried it with "homegear/rpi-homegear:nightly". As it is no longer possible to access portainer via a defined port, there is no workaround for me left.

@stefangries As a workaround you could use the SSH/Web Terminal addon, with protection mode disabled.


[MM-38991] Remove mentions and unreads when unloading a view

Summary
When removing a server, mentions and unreads that were on that server would remain visible in the global count and wouldn't go away until restart. This PR removes those when the view is destroyed so that they don't persist when the view doesn't exist.
Ticket Link
https://mattermost.atlassian.net/browse/MM-38991
Release Note
NONE

Cherry pick is scheduled.


SamlApplicationSettingsApplication/missing app key

I'm currently working on a DR solution for Okta that allows us to backup our configuration in serialised format to be later restored.
To do this, we're relying primarily on the ability to instantiate the appropriate OktaObject type using the config dict, and then calling the relevant create_x method.
Most of the other application types (e.g BookmarkApplication) have a corresponding class to which it delegates a settings key (e.g BookmarkApplicationSettings), which in turn delegates an app key to another corresponding class (e.g BookmarkApplicationSettingsApplication. It appears that this convention is missing for SAML application types, and as a result we are missing crucial information needed to be able to restore a SAML application.
An example partial response from Okta API containing this information:
{'name': 'yourcausesaml', 'label': 'YourCause',
....
'settings': {'app': {'envType': 'yourcause', 'subDomain': 'foo'}
...
}
SamlApplicationSettings(config=saml_api_response['settings']).app
{}

@rdark Thanks for posting this issue. Could you please, share some code on how serialisation/deserialisation is performed in your project? I'll take a look at SAML applications meanwhile.

If I understood correctly, SamlApplicationSettings has signOn attribute, while others have app attribute, that's the root of the issue. The thing is, this config is set in openapi spec, and our code is auto-generated, based on spec. Let me investigate what we can do. To unblock you, I can suggest using dynamic serialisation, i.e. check type of app or existing fields before serialisation and use appropriate code. I'll keep you posted on any updates.

Thanks for quick response @sergiishamrai-okta!
In terms of serialisation, I'm just calling the .as_dict() method on the result (in this case, the output of list_applications, which returns a List[Application]).
The issue appears before any serialisation on my side - the response object returned as second element in tuple from here contains the missing information within it's ._body, you can see in the lines above why this information doesn't make it's way through to the final destination, as you say - it only looks for signOn - even if there were support for it within a theoretical SamlApplicationSettingsApplication class.
As a short-term workaround, I can probably just grab this info from the response and munge into a custom model on my side.

Thanks for more details, but it seems to me like signOn and signOnMode are a bit different essences. signOnMode attribute should be present in response, while signOn is an attribute of few specific models, like SamlApplicationSettings, mentioned above. Could you please, share some traceback or code? I'd like to reproduce the issue and/or have better understanding on how I can help you.

Sure - the following code illustrates the difference between the settings from the application object and the settings from the response object - ideally the application object should retain all of the data needed to reconstruct itself rather than discarding it.
import asyncio
from okta.client import Client
from os import environ

config = {
    'orgUrl': environ['OKTA_ORG_URL'],
    'token': environ['OKTA_API_TOKEN'],
}
# ID of an existing SAML application
saml_app_id = 'REDACTED'
okta_client = Client(config)
loop = asyncio.get_event_loop()

coro = okta_client.get_application(appId=saml_app_id)
app, response, error = loop.run_until_complete(future=coro)

print('settings property on application object')
print(app.settings)

print('settings key on response.get_body() method')
print(response.get_body()['settings'])

settings property on application object

{'app': {}, 'implicit_assignment': None, 'inline_hook_id': None, 'notifications': {'vpn': {'help_url': None, 'message': None, 'network': {'connection': 'DISABLED', 'exclude': [], 'include': []}}}, 'sign_on': {'acs_endpoints': [], 'allow_multiple_acs_endpoints': None, 'assertion_signed': None, 'attribute_statements': [], 'audience': None, 'audience_override': None, 'authn_context_class_ref': None, 'default_relay_state': None, 'destination': None, 'destination_override': None, 'digest_algorithm': None, 'honor_force_authn': None, 'idp_issuer': None, 'recipient': None, 'recipient_override': None, 'request_compressed': None, 'response_signed': None, 'signature_algorithm': None, 'sp_issuer': None, 'sso_acs_url': None, 'sso_acs_url_override': None, 'subject_name_id_format': None, 'subject_name_id_template': None}}

settings key on response.get_body() method

{'app': {'afwOnly': False, 'domain': 'thedomain.com', 'afwId': None}, 'notifications': {'vpn': {'network': {'connection': 'DISABLED'}, 'message': None, 'helpUrl': None}}, 'signOn': {'defaultRelayState': None, 'ssoAcsUrlOverride': None, 'audienceOverride': None, 'recipientOverride': None, 'destinationOverride': None, 'attributeStatements': []}}

@rdark Thanks for additional details. Let me investigate it. So, in the sample above, you would like to delete app (with given appId) and recreate it using the same app object as a parameter?

Yep, exactly this 👍

@rdark
According to my investigations so far, we can't create any application in this way, but I'd like to investigate a bit more about your particular case. Are you able to create your app via curl request (or postman, doesn't matter)? And if yes, then could you pls share body of request, i.e. app parameters?
For example if we're creating bookmark app, it will look like this:
curl -v -X POST \
-H "Accept: application/json" \
-H "Content-Type: application/json" \
-H "Authorization: SSWS ${api_token}" \
-d '{
  "name": "bookmark",
  "label": "Sample Bookmark App",
  "signOnMode": "BOOKMARK",
  "settings": {
    "app": {
      "requestIntegration": false,
      "url": "https://example.com/bookmark.htm"
    }
  }
}' "https://${yourOktaDomain}/api/v1/apps"

@rdark
I've investigated a bit more and successfully re-created custom saml app. I've got sample body from postman collection (can be found here https://developer.okta.com/docs/reference/api/apps/).
But, the thing is, when we use method get_application it returns additional information about given application, for example, status of application, assigned name, etc. This additional info doesn't allow to recreate app, thus we need to get rid of it. And yes, it's better to use response body, more information is provided:
app, response, error = loop.run_until_complete(future=coro)
body = response.get_body()

# remove additional info
body.pop('name')
body.pop('status')
body.pop('created')

# then it is possible to create app (you may need to delete some apps before recreating, but it works for custom saml app without deleting):
coro = okta_client.create_application(body)
app, response, error = loop.run_until_complete(future=coro)

Does it work for you?

@rdark I'm going to close this issue as resolved. Feel free to reopen this issue or reach out to us if you have any additional questions or concerns.


Add a load step

[ ] Get yesterday's file
[ ] Get today's file
[ ] Loop through every source, compare today's hashes to yesterday, when they match exactly nothing has changed and those rows can be put aside. The remaining rows are either new or amended.
[ ] Loop through the new or amended list and compare each dict against all of yesterday's dict that didn't have an exactly match. In cases where there is a match above a certain fancy threshold to be determined later, these are potential amendment and should be filed seperately. In cases where there is no close match, the records are assumed to be new.
[ ] New records are added to yesterday's list with a current timestamp
[ ] Amended records give a customized test based on what we know about the fields. In cases where the fields that have changed suggest it's highly likely the record is amended, we write the amended with an update timestamp.
[ ] In cases where the field comparison doesn't suggest the record is a likely amendment, we may ask a human to decide if it ought to be filed as new.
[ ] Log all new records and all amendments to console, but also maybe Slack, a GitHub Issue, something else.
[ ] Write out an updated version of our "loaded.csv" file that has the reconciled database with our additional timestamp metadata columns

We might be able to use this for the comparisons https://pypi.org/project/jellyfish/

I also considered training Dedupe to generate candidates.

Tried csvdedupe with somewhat frustrating results. Probably could do better with some heuristics.


Nick: Watch<PHONE_NUMBER>8

Nick requests the watch of the watch_number<PHONE_NUMBER>8. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

Rejected by cigien in Charcoal HQ. Reason: 'already watched before seeing the PR'


API.text align option error

In the API.text function (jspdf.js at line 1254):
for ( i = 1, len = da.length ; i < len; i++ ) { ... }

the variable 'i' is not defined and the script is in strict mode, so it crashes.
I don't really have time right now to do a pull request. I'm, sorry.

This is because we are in strict mode. Just a matter of adding a var declaration before i. Like this:
for ( var i = 1, len = da.length ; i < len; i++ ) {

I too don't have time at the moment, but will try later :-)

Hmm. There has already been a pull request: Fix issue inserting aligned text #518, but somehow it seems to fail some continuous build!?

This should now be fixed in v1.3.x.

You can close this issue if it is fixed. I cannot test this as I no longer have access to the project where I used this library.

var was added to the foor loop. So you can close the issue. I don't have permission to do so.


Ignore generated PDF files

Files in question:
images/qualifier-combinations-eps-converted-to.pdf
images/qualifier-conversions-eps-converted-to.pdf

General policy is that instead of adding more things to .gitignore, to move the files to .generated instead. Would that be trivial here?

Would that be trivial here?

It's the LaTeX pipeline that generates these files, so I am not sure whether it would be trivial.


Add configmap cluster-metadata to the helm chart. (#348)

Signed-off-by: Revital Sur<EMAIL_ADDRESS>

@froesef @tomersolomon1 is it really optional? Or di we always need it even in single cluster

@roee88 I think its not optional but I am not sure what the default values should be set to as they are configuration specific.

I changed the config map following a talk with Roee.


refactor: coverage rake task

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.64%. Comparing base (64034d1) to head (6407dc0).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #16      +/-   ##
==========================================
+ Coverage   98.57%   98.64%   +0.06%
==========================================
  Files           9       11       +2
  Lines         352      369      +17
  Branches       19       19
==========================================
+ Hits          347      364      +17
  Misses          5        5

Flag
Coverage Δ

ruby-2-7
98.64% <ø> (+0.06%)
:arrow_up:

ruby-3-0
98.64% <ø> (+0.06%)
:arrow_up:

ruby-3-1
?

ruby-3-2
?

ruby-3-3
?

ruby-3-4
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


controllers: do not skip cephfs creation in provider mode

we do want to create default cephfs in provider mode however the svg is left untouched as they will be created on demand based on requests from consumer.

generated diff isn't easy to read, the main change is removal of if condition and else block.

/lgtm

/test ocs-operator-bundle-e2e-aws