[DRAFT-7] DNS over HTTPS

Working prototype for early review, to iterate on and land once RFC is final
https://github.com/square/okhttp/issues/3969
https://tools.ietf.org/html/draft-ietf-doh-dns-over-https-07

@swankjesse no rush, but a second review would be great

Should the buffer be closed explicitly in decodeAnswers()?  There are 3 places to consider, two exceptions and one normal return.

@TomMD good point, I think you are right by contract.  But I think Buffer.close is effectively a Noop anyway.  It doesn't have any open resources associated with it, so it all just gets Garbage Collected together.

If you want to test this, I've backported this implementation to my test client
$ brew install yschimke/tap/oksocial
$ oksocial --debug --dns dnsoverhttps https://facebook.com/robots.txt
09:34:18.354	url https://facebook.com/robots.txt
09:34:18.360	Request Request{method=GET, url=https://facebook.com/robots.txt, tag=TokenSet(name=default)}
09:34:18.515	>> CONNECTION 505249202a20485454502f322e300d0a0d0a534d0d0a0d0a
09:34:18.516	>> 0x00000000     6 SETTINGS
09:34:18.516	>> 0x00000000     4 WINDOW_UPDATE
09:34:18.517	<< 0x00000000    18 SETTINGS
09:34:18.517	--> GET https://dns.google.com/experimental?ct=application/dns-udpwireformat&dns=AAABAAACAAAAAAAACGZhY2Vib29rA2NvbQAAAQABCGZhY2Vib29rA2NvbQAAHAAB h2
09:34:18.517	Accept: application/dns-udpwireformat
09:34:18.517	>> 0x00000000     0 SETTINGS      ACK
09:34:18.517	Host: dns.google.com
09:34:18.517	<< 0x00000000     4 WINDOW_UPDATE
09:34:18.517	Connection: Keep-Alive
09:34:18.518	Accept-Encoding: gzip
09:34:18.518	User-Agent: okhttp/3.10.0
09:34:18.518	Accept-Encoding: br
09:34:18.518	--> END GET
09:34:18.524	>> 0x00000003   147 HEADERS       END_STREAM|END_HEADERS
09:34:18.591	<< 0x00000000     0 SETTINGS      ACK
09:34:18.605	<< 0x00000003   315 HEADERS       END_HEADERS
09:34:18.605	<< 0x00000003    46 DATA
09:34:18.606	<< 0x00000003     0 DATA          END_STREAM
09:34:18.606	<< 0x00000000     8 PING
09:34:18.606	>> 0x00000000     8 PING          ACK
09:34:18.607	<-- 200 https://dns.google.com/experimental?ct=application/dns-udpwireformat&dns=AAABAAACAAAAAAAACGZhY2Vib29rA2NvbQAAAQABCGZhY2Vib29rA2NvbQAAHAAB (89ms)
09:34:18.608	strict-transport-security: max-age=31536000; includeSubDomains; preload
09:34:18.608	date: Sat, 12 May 2018 08:34:18 GMT
09:34:18.608	expires: Sat, 12 May 2018 08:34:18 GMT
09:34:18.608	cache-control: private, max-age=298
09:34:18.608	content-type: application/dns-udpwireformat
09:34:18.608	server: HTTP server (unknown)
09:34:18.608	content-length: 46
09:34:18.608	x-xss-protection: 1; mode=block
09:34:18.608	x-frame-options: SAMEORIGIN
09:34:18.608	alt-svc: hq=":443"; ma=2592000; quic=51303433; quic=51303432; quic=51303431; quic=51303339; quic=51303335,quic=":443"; ma=2592000; v="43,42,41,39,35"
09:34:18.608	<-- END HTTP
09:34:18.609	Dns (facebook.com): /<IP_ADDRESS>
09:34:18.735	>> CONNECTION 505249202a20485454502f322e300d0a0d0a534d0d0a0d0a
09:34:18.735	>> 0x00000000     6 SETTINGS
09:34:18.735	>> 0x00000000     4 WINDOW_UPDATE
09:34:18.735	<< 0x00000000    30 SETTINGS
09:34:18.735	--> GET https://facebook.com/robots.txt h2
09:34:18.735	User-Agent: oksocial/1.40.0
09:34:18.736	Host: facebook.com
09:34:18.736	<< 0x00000000     4 WINDOW_UPDATE
09:34:18.736	Connection: Keep-Alive
09:34:18.736	>> 0x00000000     0 SETTINGS      ACK
09:34:18.736	Accept-Encoding: gzip
09:34:18.736	Accept-Encoding: br
09:34:18.736	--> END GET
09:34:18.737	>> 0x00000003    45 HEADERS       END_STREAM|END_HEADERS
09:34:18.843	<< 0x00000000     0 SETTINGS      ACK
09:34:18.843	<< 0x00000003     4 WINDOW_UPDATE
09:34:18.883	<< 0x00000003   422 HEADERS       END_HEADERS
09:34:18.883	<< 0x00000003   519 DATA
09:34:18.883	<-- 200 https://facebook.com/robots.txt (146ms)
09:34:18.883	<< 0x00000003    10 DATA          END_STREAM
09:34:18.883	x-frame-options: DENY
09:34:18.883	x-xss-protection: 0
09:34:18.883	access-control-allow-credentials: true
09:34:18.883	access-control-allow-origin: https://facebook.com
09:34:18.884	access-control-expose-headers: X-FB-Debug, X-Loader-Length
09:34:18.884	pragma: no-cache
09:34:18.884	vary: Origin
09:34:18.884	access-control-allow-methods: OPTIONS
09:34:18.884	strict-transport-security: max-age=15552000; preload
09:34:18.884	content-type: text/plain; charset=utf-8
09:34:18.884	x-content-type-options: nosniff
09:34:18.884	expires: Sun, 13 May 2018 08:34:18 +0000
09:34:18.884	cache-control: private, no-cache, no-store, must-revalidate
09:34:18.884	vary: Accept-Encoding
09:34:18.884	content-encoding: gzip
09:34:18.884	x-fb-debug: 2V9MWspBOpYw/ByjuIoDNcR9UhRCob8YuaBJnF7kEhUfB7trFLVim467yDjN66GrklREv7XiLsBZSDbIs/a/6Q==
09:34:18.885	date: Sat, 12 May 2018 08:34:18 GMT
09:34:18.885	<-- END HTTP
09:34:18.887	OkHttp Platform: ConscryptPlatform
09:34:18.887	TLS Version: TLS_1_2
09:34:18.887	Protocol: h2
09:34:18.887	Cipher: TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256
09:34:18.887	Peer Principal: CN=*.facebook.com, O="Facebook, Inc.", L=Menlo Park, ST=California, C=US
# Notice: Crawling Facebook is prohibited unless you have express written
# permission. See: http://www.facebook.com/apps/site_scraping_tos_terms.php

User-agent: Applebot

Implemented more aggressive caching (avoiding network), @swankjesse would be great if you can see if I'm doing it right
uncached
********

Testing https://dns.google.com/experimental?ct=application/dns-udpwireformat
google.com: [/<IP_ADDRESS>]
graph.facebook.com: [/<IP_ADDRESS>]
sdflkhfsdlkjdf.ee: java.net.UnknownHostException: sdflkhfsdlkjdf.ee: NXDOMAIN

Testing https://dns.google.com/experimental
google.com: [/<IP_ADDRESS>]
graph.facebook.com: [/<IP_ADDRESS>]
sdflkhfsdlkjdf.ee: java.net.UnknownHostException: sdflkhfsdlkjdf.ee: NXDOMAIN

Testing https://cloudflare-dns.com/dns-query?ct=application/dns-udpwireformat
google.com: [/<IP_ADDRESS>]
graph.facebook.com: [/<IP_ADDRESS>]
sdflkhfsdlkjdf.ee: java.net.UnknownHostException: sdflkhfsdlkjdf.ee: NXDOMAIN

Testing https://dns.cloudflare.com/.well-known/dns-query
google.com: [/<IP_ADDRESS>]
graph.facebook.com: [/<IP_ADDRESS>]
sdflkhfsdlkjdf.ee: java.net.UnknownHostException: sdflkhfsdlkjdf.ee: NXDOMAIN

Testing https://doh.cleanbrowsing.org/doh/family-filter
google.com: [/<IP_ADDRESS>]
graph.facebook.com: [/<IP_ADDRESS>]
sdflkhfsdlkjdf.ee: java.net.UnknownHostException: sdflkhfsdlkjdf.ee: NXDOMAIN

Testing https://doh.securedns.eu/dns-query
google.com: [/<IP_ADDRESS>]
graph.facebook.com: May 19, 2018 1:31:18 PM okhttp3.internal.platform.Platform log
WARNING: Incorrect protocol: http/1.1
[/<IP_ADDRESS>]
May 19, 2018 1:31:18 PM okhttp3.internal.platform.Platform log
WARNING: Incorrect protocol: http/1.1
sdflkhfsdlkjdf.ee: java.net.UnknownHostException: sdflkhfsdlkjdf.ee: NXDOMAIN

Testing https://doh.crypto.sx/dns-query
google.com: May 19, 2018 1:31:19 PM okhttp3.internal.platform.Platform log
WARNING: Incorrect protocol: http/1.1
[/<IP_ADDRESS>]
graph.facebook.com: [/<IP_ADDRESS>]
sdflkhfsdlkjdf.ee: java.net.UnknownHostException: sdflkhfsdlkjdf.ee: NXDOMAIN

Testing https://dns.dnsoverhttps.net/dns-query
google.com: java.net.UnknownHostException: google.com
java.io.IOException: response: 400
graph.facebook.com: java.net.UnknownHostException: graph.facebook.com
java.io.IOException: response: 400
sdflkhfsdlkjdf.ee: java.net.UnknownHostException: sdflkhfsdlkjdf.ee
java.io.IOException: response: 400

Time: 4.911 seconds

cached first run
****************

Testing https://dns.google.com/experimental?ct=application/dns-udpwireformat
google.com: [/<IP_ADDRESS>]
graph.facebook.com: [/<IP_ADDRESS>]

Testing https://cloudflare-dns.com/dns-query?ct=application/dns-udpwireformat
google.com: [/<IP_ADDRESS>]
graph.facebook.com: [/<IP_ADDRESS>]

Testing https://doh.cleanbrowsing.org/doh/family-filter
google.com: [/<IP_ADDRESS>]
graph.facebook.com: [/<IP_ADDRESS>]

Time: 0.612 seconds

cached second run
*****************

Testing https://dns.google.com/experimental?ct=application/dns-udpwireformat
google.com: [/<IP_ADDRESS>]
graph.facebook.com: [/<IP_ADDRESS>]

Testing https://cloudflare-dns.com/dns-query?ct=application/dns-udpwireformat
google.com: [/<IP_ADDRESS>]
graph.facebook.com: [/<IP_ADDRESS>]

Testing https://doh.cleanbrowsing.org/doh/family-filter
google.com: [/<IP_ADDRESS>]
graph.facebook.com: [/<IP_ADDRESS>]

Time: 0.014 seconds

https://daniel.haxx.se/blog/2018/06/03/inside-firefoxs-doh-engine/
Interesting points
Blacklisting/fallback
Captive portals
Intermediate Cname ttl
Bootstrapping
Server push

...Local addresses

Of the above.  I think blacklisting/fallback, captive portals, bootstrapping and local addresses all have a common solution.  Provide a default strategy (DnsFallbackStrategy?) that we default to

lookup the url host via (bootstrap dns)
allow fallback (default none)
use system dns for local addresses (default localhost, *.local)

In Kotlin terms something like
sealed class DnsSource
object System : DnsSource()
object DnsOverHttps : DnsSource()
data class Configured(val addresses: List<InetAddress>) : DnsSource()

fun dnsStrategy(host: String): List<DnsSource>

Also wondering whether to strictly express the query as a URI Template https://tools.ietf.org/html/rfc6570
https://cloudflare-dns.com/dns-query?ct=application/dns-udpwireformat{&query}

Nothing much in https://tools.ietf.org/html/draft-ietf-doh-dns-over-https-10 so most relevant is when to land this and get more testing of this.  Marked experimental in next release? or wait until just after the next release?

I think we do experimental in the next release.
Can we use the topPrivateDomain stuff to differentiate between local and Internet hostnames?

The fallback logic could be pulled out to a separate DNS used as a forwarding decorator.  But at the same time I don't think the intention is to build a dns toolkit.
I have considered whether this should be a separate library, but it feels small enough that I hope it's just a useful core feature for anyone worried about App security.  Some of this depends on DNS over HTTPS being a well supported standard in years to come.

@swankjesse they went with DoH for the abbreviation.  I'm happy to stick with full naming we have.

Addressed comments, merging and will fix anything else in incremental changes.


ReplaceAttrs incompatible with slog

I found two things that tint does different to slog, which makes Options not quite a drop-in replacement for slog.HandlerOptions:
First, slog calls Resolve before ReplaceAttr, as documented:

ReplaceAttr is called to rewrite each non-group attribute before it is logged. The attribute's value has been resolved (see [Value.Resolve]).

tint calls Resolve after ReplaceAttr.
Second, tint does not call ReplaceAttr recursively for groups. With the tint handler, slog.Info("foo", slog.Group("bar", "x", "y")) causes a call to ReplaceAttr with an empty groups argument and slog.GroupValue("bar", "x", "y"). slog's handlers instead call ReplaceAttr with []string{"bar"}, slog.Attr{Key:"x", Value: slog.StringValue("y")}.
The documentation on slog.HandlerOptions.ReplaceAttr reads

ReplaceAttr is never called for Group attributes, only their contents.

The two things together interact surprisingly in slog in Go 1.21.1. With a value that Resolves to a GroupValue, slog does call ReplaceAttr with the Group attribute (and after that once for each member of the group). This is either a bug in the implementation or the docs. I opened golang/go#62731 about this. Maybe keep an eye on that.

Thanks for raising this.


Error building package xerces-c:x64-windows

Building on Windows 7SP1 x64 with Visual Studio 2017 15.4
  Package: xerces-c:x64-windows
  Vcpkg version: 0.0.91-2017-10-11-7cd465b8897bd9487db6d990e58dcac472b3d4d6

Fails with the following error log:
     1>Project "C:\vcpkg\buildtrees\xerces-c\src\xerces-c-Xerces-C_3_1_4\projects\Win32\VC14\xerces-all\xercesLib\xercesLib.vcxproj" on node 1 (Rebuild target(s)).
     1>C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\MSBuild\15.0\bin\Microsoft.Common.CurrentVersion.targets(94,27): error MSB4086: A numeric comparison was attempted on "$(TargetPlatformVersion)" that evaluates to "10.0.16299.0" instead of a number, in condition "'$(UseOSWinMdReferences)' == '' and ('$(TargetPlatformWinMDLocation)' == '' and '$(TargetPlatformIdentifier)' == 'Windows' and '$(TargetPlatformVersion)' > '7.0')". [C:\vcpkg\buildtrees\xerces-c\src\xerces-c-Xerces-C_3_1_4\projects\Win32\VC14\xerces-all\xercesLib\xercesLib.vcxproj]
     1>Done Building Project "C:\vcpkg\buildtrees\xerces-c\src\xerces-c-Xerces-C_3_1_4\projects\Win32\VC14\xerces-all\xercesLib\xercesLib.vcxproj" (Rebuild target(s)) -- FAILED.

$(TargetPlatformVersion) appears to have a "ZERO WIDTH NO-BREAK SPACE", unicode character 0xFEFF before the number (10.0.16299.0), I don't know if that could cause any problems

It looks to be a problem with the getWindowsSDK.ps1, I saved the output from the script to file and saw the same 0xFEFF character at the start.  I did manage to get tbb and libusb to build by either commenting out the /p:WindowsTargetPlatformVersion=${_csc_TARGET_PLATFORM_VERSION} line in vcpkg_build_msbuild.cmake or replacing ${_csc_TARGET_PLATFORM_VERSION} with 10.0.16299.0

Should be fixed by #2034. Thanks for reporting this issue!


Can't git clone ITK while building SimpleElastix

Hi there,
I am currently trying to get SimpleElastix running on my Windows 7 PC.
When trying to build SimpleElastix by following the tutorial I ran into some errors, which got fixed by uninstalling previous Python versions and only leaving Python 3.7.4 on my PC.
I was able to build the Super Build with CMake and tried to compile with the msbuild command in x64 native tools command prompt.
It completes with errors and I can't find the setup.py nor the Wrapping/Python folder in my SimpleITK-build folder.
I believe the problem is that ITK can't get cloned from github dew to my internet connection breaking off during the process.
Is there a way of downloading ITK seperately and telling the build to just take ITK from my machine instead of downloading it from git?
With other repos there is no problem with git cloning it in x64 native tools command prompt by the way. I think it's just that ITK is too big and my router isn't cut out for  that much Download traffic.
I hope my explanation to the problem wasn't too confusing and let me know if you need more details.
Thanks in advance and best regards,
Leon

Yes, run ccmake in the build directory where you build the SuperBuild, and use ccmake to set USE_SYSTEM_ITK to ON and then set ITK_DIR to the build directory of ITK on your own system.

Thank you!
Regards, Leon

Gesendet: Montag, 22. Juli 2019 um 02:41 Uhr
Von: "Kasper Marstal"<EMAIL_ADDRESS>An: SuperElastix/SimpleElastix<EMAIL_ADDRESS>Cc: Leomeror<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Betreff: Re: [SuperElastix/SimpleElastix] Can't git clone ITK while building SimpleElastix (#315)
Yes, run ccmake in the build directory where you build the SuperBuild, and use ccmake to set USE_SYSTEM_ITK to ON and then set ITK_DIR to the build directory of ITK on your own system.
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
https://github.com/SuperElastix/SimpleElastix/issues/315#issuecomment-513602597


the connect method flags in c#

Godot version
3.5.1
System information
Windows 10
Issue description
The connect method in c# does not have any type  a flag parameter which is hard to know and code it. This hard to code because this parameter only gets unit and does not contain any information the flags value. you can see in this sample
_player.Connect("DiedEventHandler", this, nameof(_OnPlayerDied),flags:1);

Steps to reproduce
start to coding with c# and use connect method.
_player.Connect("DiedEventHandler", this, nameof(_OnPlayerDied),flags:1);

Minimal reproduction project
N/A

I suggest this flags become an enum and in the body of the connect function cast it to a unit.

I think this is resolved in 4.0.

Yes, In version 4 this problem was fixed by adding the ConnectFlags enum. However, the connect function signature does not have changed, which is
        public Error Connect(StringName signal, Callable callable, uint flags = 0u)
        {
            return (Error)NativeCalls.godot_icall_3_690(MethodBind31, GetPtr(this), (godot_string_name)(signal?.NativeValue ?? default(godot_string_name.movable)), in callable, flags);
        }

Also, I see this code in my visual studio editor, but I cannot find it in the git repository.
I suggest This signature change to like this
        public Error Connect(StringName signal, Callable callable, ConnectFlags flags= ConnectFlags.None)
        {
            return (Error)NativeCalls.godot_icall_3_690(MethodBind31, GetPtr(this), (godot_string_name)(signal?.NativeValue ?? default(godot_string_name.movable)), in callable, flags);
        }

I want to help and contribute to the Godot engine, If it's possible tell me about how I can fix this issue and where is the connect method to change its signature?

Can't we change ConnectFlags to be a uint backed enum in C#? I'm pretty surprised that the Connect method signature can't accept the enum specifically made for that one case.

Changing the underlying type of the ConnectFlags enum won't solve this issue, since the method still takes uint and C# considers them different types (even if the enum's underlying type is the same).
Adding a method overload that takes the ConnectFlags enum instead of uint would create ambiguity for the case where the user was passing a number literal. I don't know how common this case is, it's probably very rare, so we may want to break source compatibility to fix the issue.
So, if we decide to break source compatibility we can fix this in Godot 4.x, no need to wait for 5.0. We would change the Connect method signature in Core, then add a compat method for GDExtension and C# to avoid breaking binary compatibility.

This sort of tiny targeted change seems like a perfect time to cut my teeth on the engine source code. Can you explain further what the “compat” method would be? The idea is to change the signature of the main one to take the enum, right? Wouldn’t the compat method cause the ambiguity you mentioned?

A compat method is a method with the signature of the old method, it's bound using ClassDB::bind_compatibility_method[^1] instead of ClassDB::bind_method.

Wouldn’t the compat method cause the ambiguity you mentioned?

Yes, in C# the compat method is just an overload with the old signature, so it would cause ambiguity. But this ambiguity is only a source breaking change so maybe it's worth breaking compat for this, not sure.
Before you do anything, I'd advise waiting for a decision to be made. I'd like to know what @godotengine/production thinks of breaking source compatibility for this.
[^1]:  To add compat methods to GDExtension, see https://github.com/godotengine/godot/pull/76577.
To add compat methods to C#, see https://github.com/godotengine/godot/pull/78452.

This is a pretty old thread but im still seeing this issue in latest stable Godot version.

Did anyone ever get a chance to look into this?


Notification Service

The whole notification service doesn't seem to be functioning.
I noticed the preload feature, which should send a notification when the application starts in a developer environment, but it doesn't seem to work. Besides that, I also tried to add a new notification by using the service, but that notification doesn't seem to pop up either. Could you maybe have a look?

Yes， The notification menu is not yet functional because I haven't decided how to use it yet.

Ahh, that makes sense. I got confused since it seemed like an actual feature already, but I couldn't see why the notifications weren't being handled properly. I'm currently working on a PR, where I further improve certain stuff, so expect a PR soon. :-)

Should I keep this Issue open and close it when it's completed? Regarding the Notification service, do you want to implement it using SignalR?

@Bram1903
I've been added to the mange group of our project. try out, you should now have the necessary permissions to close old issues and help us keep the project organized.

I just got an invite through my notifications! I indeed now have some additional permissions, so that's nice. I'll see if I can keep the issues a bit more structured by adding labels, etc. I'll also try and create a project board!


Allow empty namespace to monitor any namespace

and handle permissions errors when creating the webhook. Also create the
webhook secret in the same namespace where the webhook is deployed,
rather than the monitored namespace.
[Fixes #45]
Signed-off-by: Kieron Browne<EMAIL_ADDRESS>

I can't tell if this is the correct value or not: https://github.com/cloudfoundry-incubator/eirinix/pull/46/files#diff-4539540c8184ee5eccb973e7db8911e7R316

Superseded by: https://github.com/cloudfoundry-incubator/eirinix/pull/47 .Closing.


Expose the operation name from juniper_rocket::GraphQLRequest

Measuring the runtime of queries will only tell if there are slow
queries. To find out which queries are slow you need the operation name.
Getting the operation name was previously not possible from a Rocket
request handler. This fixes that.

I ran into this issue recently when implementing performance performance
monitoring for an app using juniper-rocket.

Codecov Report

Merging #353 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #353   +/-   ##
=======================================
  Coverage   88.32%   88.32%
=======================================
  Files         103      103
  Lines       14922    14922
=======================================
  Hits        13180    13180
  Misses       1742     1742

Impacted Files
Coverage Δ

juniper/src/http/mod.rs
0% <ø> (ø)
:arrow_up:

juniper_rocket/src/lib.rs
89.76% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbfcc76...db5eae6. Read the comment docs.

Looks good.
Two nits:

Formatting is failing (please run cargo fmt on stable)
also update the juniper changelog

@theduke Done

cargo test fails for me on nightly, which is necessary for rocket to work. Not quite sure what is wrong. I get this output
$ cargo test
warning: /Users/davidpdrsn/dev/major/juniper-fork/integration_tests/juniper_tests/Cargo.toml: file found to be present in multiple build targets: /Users/davidpdrsn/dev/major/juniper-fork/integration_tests/juniper_tests/src/lib.rs
   Compiling juniper_hyper v0.2.0 (/Users/davidpdrsn/dev/major/juniper-fork/juniper_hyper)
error: internal compiler error: src/librustc_mir/borrow_check/nll/universal_regions.rs:741: cannot convert `ReScope(Node(257))` to a region vid

thread 'rustc' panicked at 'Box<Any>', src/librustc_errors/lib.rs:637:9
note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
error: aborting due to previous error

note: the compiler unexpectedly panicked. this is a bug.

note: we would appreciate a bug report: https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#bug-reports

note: rustc 1.36.0-nightly (3f5152e20 2019-05-08) running on x86_64-apple-darwin

note: compiler flags: -C debuginfo=2 -C incremental --crate-type bin

note: some of the compiler flags provided by cargo are hidden

error: Could not compile `juniper_hyper`.
warning: build failed, waiting for other jobs to finish...
error: internal compiler error: src/librustc_mir/borrow_check/nll/universal_regions.rs:741: cannot convert `ReScope(Node(257))` to a region vid

thread 'rustc' panicked at 'Box<Any>', src/librustc_errors/lib.rs:637:9
note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
error: aborting due to previous error

note: the compiler unexpectedly panicked. this is a bug.

note: we would appreciate a bug report: https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#bug-reports

note: rustc 1.36.0-nightly (3f5152e20 2019-05-08) running on x86_64-apple-darwin

note: compiler flags: -C debuginfo=2 -C incremental

note: some of the compiler flags provided by cargo are hidden

error: Could not compile `juniper_hyper`.

To learn more, run the command again with --verbose.

Exact toolchain is rustc 1.36.0-nightly (3f5152e20 2019-05-08)

The bug you are hitting is https://github.com/rust-lang/rust/issues/59344.

It seems a solution was recently merged. I'll give it another shot on the latest nightly.

I have added an integration test now. I wasn't quite sure if it also made sense to test the path where there is no operation name provided. I decided to trust the typesystem 😊 Let me know if you would like that.

Thanks!


Taking long time to Deploy the Code

Hi,
Whenever I made any changes in the code. I need to run ./clean.sh and ./build_ubuntu.sh, which is taking very long time to deploy.
Is this the correct way of deploying the code or there are some other way around to deploy the code to see the changes?
Need help of this.
Thanks in advance

@ishangulhane - fyi see comment above

very sorry can not see any comment above.
could you please write your comment as a new comment
Thanks

if i update the chaincode for one of the peers, even then do i need to run the stand clean.sh and build_ubuntu.sh scripts?
It usually takes around 15 min to setup again. how can i save time when i have to test even a very small change?


Fix unsoundness in definition of stack for spawning core1

Implementation of the approach suggested in https://github.com/rp-rs/rp-hal/issues/864#issuecomment-2463262058

[x] also update rp235x code
[x] test on hardware

Looks great. Much nicer.


Cannot override JVM options for plugins

Under logstash 5, I was able to set the environment parameter on plugin resources to do something like:
LS_JVM_OPTIONS="-Xms1g -Xmx1g"
And all was good.  Having now upgraded to logstash 6, the LS_JVM_OPTIONS environment variable no longer functions and was replaced with LS_JAVA_OPTS, which should work in the same way.  However, when I pass an environment variable of LS_JAVA_OPTS="-Xms1g -Xmx1g" to the plugin resource, I get errors when puppet runs:
Notice: /Stage[main]/Profile::Logstash/Logstash::Plugin[logstash-filter-translate]/Exec[install-logstash-filter-translate]/returns: Error: Could not find or load main class "-Xms1g"
Error: '/usr/share/logstash/bin/logstash-plugin install logstash-filter-translate' returned 1 instead of one of [0]
Error: /Stage[main]/Profile::Logstash/Logstash::Plugin[logstash-filter-translate]/Exec[install-logstash-filter-translate]/returns: change from notrun to 0 failed: '/usr/share/logstash/bin/logstash-plugin install logstash-filter-translate' returned 1 instead of one of [0]
This would also probably be a good time to update the example config here: https://github.com/elastic/puppet-logstash/blob/master/manifests/plugin.pp#L31 to use the LS_JAVA_OPTS variable.

Could you share the plugin declaration to reproduce this error, please? Thanks.

I try to keep everything in Hiera - so my puppet code related to plugins is this:
$hiera_pluginlist = lookup({name => 'logstash::pluginlist', default_value => undef, merge => deep})
if $hiera_pluginlist {
create_resources('logstash::plugin', $hiera_pluginlist)
}
And in my heira data I have this:
logstash::pluginlist:
logstash-filter-translate:
ensure: present
environment: LS_JAVA_OPTS="-Xms1g -Xmx1g"
If it matters, running the following command in a terminal on the same node works just fine:
LS_JAVA_OPTS="-Xms1g -Xmx1g" bin/logstash-plugin install logstash-filter-translate

Thanks. That's really interesting. Check out the debug output:
Debug: Executing with uid=logstash: '/usr/share/logstash/bin/logstash-plugin list ^logstash-filter-translate$'
Debug: /Stage[main]/Main/Logstash::Plugin[logstash-filter-translate]/Exec[install-logstash-filter-translate]/unless: Op
enJDK 64-Bit Server VM warning: If the number of processors is expected to increase from one, then you should configure
 the number of parallel GC threads appropriately using -XX:ParallelGCThreads=N
Debug: /Stage[main]/Main/Logstash::Plugin[logstash-filter-translate]/Exec[install-logstash-filter-translate]/unless: Er
ror: Could not find or load main class "-Xms1g
Debug: Exec[install-logstash-filter-translate](provider=posix): Executing '/usr/share/logstash/bin/logstash-plugin inst
all logstash-filter-translate'
Debug: Executing with uid=logstash: '/usr/share/logstash/bin/logstash-plugin install logstash-filter-translate'

The command being exec'd looks fine. I can't yet see how the flag is leaking into the JVM invocation, but it clearly is... somehow.

If it matters, running the following command in a terminal on the same node works just fine:
LS_JAVA_OPTS="-Xms1g -Xmx1g" bin/logstash-plugin install logstash-filter-translate

This matters a lot. 💯
Thanks for providing such a good reproduction.
Here's what I pulled out of my process list when running successfully from the shell:
/bin/java -Dfile.encoding=UTF-8 -Djava.awt.headless=true -XX:+DisableExplicitGC -XX:+HeapDumpOnOutOfMemoryError -XX:+UseCMSInitiatingOccupancyOnly -XX:+UseConcMarkSweepGC -XX:+UseParNewGC -XX:CMSInitiatingOccupancyFraction=75 -Xmx1g -Xms1g -Xss2048k -Djffi.boot.library.path=/usr/share/logstash/vendor/jruby/lib/jni -XX:+TieredCompilation -XX:TieredStopAtLevel=1 -noverify -Djruby.compile.invokedynamic=false -Xbootclasspath/a:/usr/share/logstash/vendor/jruby/lib/jruby.jar -classpath : -Djruby.home=/usr/share/logstash/vendor/jruby -Djruby.lib=/usr/share/logstash/vendor/jruby/lib -Djruby.script=jruby -Djruby.shell=/bin/sh org.jruby.Main -X-C /usr/share/logstash/lib/pluginmanager/main.rb install logstash-filter-translate

...and here's what is run when using Puppet:
/bin/java -Dfile.encoding=UTF-8 -Djava.awt.headless=true -XX:+DisableExplicitGC -XX:+HeapDumpOnOutOfMemoryError -XX:+UseCMSInitiatingOccupancyOnly -XX:+UseConcMarkSweepGC -XX:+UseParNewGC -XX:CMSInitiatingOccupancyFraction=75 "-Xms1g -Xmx1g" -Xms256m -Xss2048k -Djffi.boot.library.path=/usr/share/logstash/vendor/jruby/lib/jni -XX:+TieredCompilation -XX:TieredStopAtLevel=1 -noverify -Djruby.compile.invokedynamic=false -Xbootclasspath/a:/usr/share/logstash/vendor/jruby/lib/jruby.jar -classpath : -Djruby.home=/usr/share/logstash/vendor/jruby -Djruby.lib=/usr/share/logstash/vendor/jruby/lib -Djruby.script=jruby -Djruby.shell=/bin/sh org.jruby.Main -X-C /usr/share/logstash/lib/pluginmanager/main.rb install logstash-filter-translate

The fail state contains this nasty piece of work: "-Xms1g -Xmx1g" -Xms256m.
That string quoting not our friend.

So, if you remove the quotes from your Hiera YAML, it works:
logstash::plugin list:
  logstash-filter-translate:
    ensure: present
    environment: LS_JAVA_OPTS=-Xms1g -Xmx1g

The environment parameter of the exec resource expects a string (or an array of strings) in the form "VAR=value". This example is valid:
"VAR=a multi-word value"

But in your case, Hiera is sending the equivalent of this:
"VAR=\"a multi-word value forced into qoutes\""

It not super intuitive, with so many layers of string handling: YAML -> Hiera -> Puppet -> Shell.
Here's an example of the problem in pure Puppet:
# example.pp
exec { 'test':
  command     => '/bin/echo $CANARY > /tmp/target',
  provider    => 'shell',
  environment => 'CANARY=a yellow bird',
}

$ puppet apply example.pp
Notice: Compiled catalog for rasa.home.jarpy.net in environment production in 0.06 seconds
Notice: /Stage[main]/Main/Exec[test]/returns: executed successfully
Notice: Applied catalog in 0.01 seconds

$ cat /tmp/target
a yellow bird

# example.pp
exec { 'test':
  command     => '/bin/echo $CANARY > /tmp/target',
  provider    => 'shell',
  environment => 'CANARY="a yellow bird in a cage"',
}

$ puppet apply example.pp
Notice: Compiled catalog for rasa.home.jarpy.net in environment production in 0.04 seconds
Notice: /Stage[main]/Main/Exec[test]/returns: executed successfully
Notice: Applied catalog in 0.01 seconds

$ cat /tmp/target
"a yellow bird in cage"

Ok - I'll give it a go tomorrow when I'm back in the office, based on everything here I expect it should be fine.  One last point to make though - back on previous versions of the puppet module and elastic components (when it was still LS_JVM_OPTIONS) the quotes didn't cause any problems.  When I upgraded everything, the only change I made (besides new versions) was replacing LS_JVM_OPTIONS with LS_JAVA_OPTS - same puppet code, same hiera data, same quotes, etc.  Quotes didn't cause a problem before, but they do now.
Thanks for the help.

I understand. The plugin command (which is a shell script) must have changed its behaviour.
I updated the README and comments here to be correct for the new way.
Sorry you hit this and thanks again for the excellent report.


Add an example: "Off-Internet-topology-options"

Scenario:
Customer wants to keep all traffic 'off-public-internet' while using their on-premises APIs, Integration Suite and BTP in Azure.
Recommending the following topology:

@sjain07p can you please add you changes in main branch? right now you are trying to merge with "reuse-branch"


Azure: Enabled Azure subscription authentication using Azure context files and Manual Login

Please use one of the following method to authenticate Azure powershell session.

Provide service principal details in XML secrets file.
a. SubscriptionServicePrincipalClientID
b. SubscriptionServicePrincipalTenantID
c. SubscriptionServicePrincipalKey
Provide the path of authenticated context file in XML secrets file.
a. AzureContextFilePath
Copy authenticated context file in LISAv2 root directory
Authenticate this current session by running Connect-AzureRmAccount command.

Is this a requested feature?
In previous workflow of using a secret file, there have been steps taken to ensure that besides the secrets xml, the credentials are not stored in other lisav2 places, Lili or Liz had a PR on that recently.
With these changes here it seems you're introducing things as cached/stored credentials that might not be monitored for access.
But I might be lacking the context behind this PR, just sharing some thoughts here.

Is this a requested feature?
In previous workflow of using a secret file, there have been steps taken to ensure that besides the secrets xml, the credentials are not stored in other lisav2 places, Lili or Liz had a PR on that recently.
With these changes here it seems you're introducing things as cached/stored credentials that might not be monitored for access.
But I might be lacking the context behind this PR, just sharing some thoughts here.

Yes Chris, this is a requested feature.

@juhlee-microsoft Will address comments this week.

ill address comments this week.

I am not sure if this PR is live. Will close it on Monday until I see the followup/update, @iamshital

Scenario 1 : Service principal authentication given in Secret File
06/13/2019 08:00:37 : [INFO ] Using provided secrets file: .\XML\AzureSecretsTESTONLY.xml
06/13/2019 08:00:37 : [INFO ] .\XML\AzureSecretsTESTONLY.xml found.
06/13/2019 08:00:37 : [INFO ] ------------------------------------------------------------------
06/13/2019 08:00:37 : [INFO ] Authenticating Azure PS session using Service Principal...
06/13/2019 08:00:41 : [INFO ] Current Subscription : 0cc2a67a-xxxx-xxxx-xxxx-bfa46a28e896.
06/13/2019 08:00:41 : [INFO ] ------------------------------------------------------------------
06/13/2019 08:00:41 : [INFO ] Auto selecting storage account : lisaeastus as per your test region.
06/13/2019 08:00:41 : [INFO ] ------------------------------------------------------------------
06/13/2019 08:00:42 : [INFO ] SubscriptionName       : Linux Integration Services TEST ONLY
06/13/2019 08:00:42 : [INFO ] SubscriptionId         : 0cc2a67a-xxxx-xxxx-xxxx-bfa46a28e896
06/13/2019 08:00:42 : [INFO ] User                   : f781dc82-f748-4b25-9b85-01e723e9bdcc
06/13/2019 08:00:42 : [INFO ] ServiceEndpoint        : https://management.core.windows.net/
06/13/2019 08:00:42 : [INFO ] CurrentStorageAccount  : lisaeastus
06/13/2019 08:00:42 : [INFO ] ------------------------------------------------------------------
.
.
.
[LISAv2 Test Results Summary]
Test Run On           : 06/13/2019 08:00:43
ARM Image Under Test  : Canonical : UbuntuServer : 16.04-LTS : latest
Test Category         : Functional
Test Area             : CORE
Total Test Cases      : 1 (1 Passed, 0 Failed, 0 Aborted, 0 Skipped)
Total Time (dd:hh:mm) : 0:0:6

   ID TestArea             TestCaseName                                                                TestResult TestDuration(in minutes)
-------------------------------------------------------------------------------------------------------------------------------------------
    1 CORE                 VERIFY-DEPLOYMENT-PROVISION                                                       PASS                 2.72
        FirstBoot : PASS
        FirstBoot : Call Trace Verification : PASS
        Reboot : PASS
        Reboot : Call Trace Verification : PASS

Logs can be found at D:\GitHub\LISAv2-2\TestResults\2019-13-06-01-00-36-6880

06/13/2019 08:06:47 : [INFO ] Creating 'D:\GitHub\LISAv2-2\Azure-Functional-CORE-TK40-TestLogs.zip' from 'D:\GitHub\LISAv2-2\TestResults\2019-13-06-01-00-36-6880'
06/13/2019 08:06:47 : [INFO ] D:\GitHub\LISAv2-2\Azure-Functional-CORE-TK40-TestLogs.zip created successfully.
06/13/2019 08:06:47 : [INFO ] Analyzing results..
06/13/2019 08:06:47 : [INFO ] LISAv2 exit code: 0

Scenario 2 : Azure context file path given in secret file
06/13/2019 08:08:34 : [INFO ] .\XML\AzureSecretsTESTONLY.xml found.
06/13/2019 08:08:34 : [INFO ] ------------------------------------------------------------------
06/13/2019 08:08:34 : [INFO ] Authenticating Azure PS session using saved context file C:\Users\v-shsave\Desktop\AzureSessionContext.json...
06/13/2019 08:08:39 : [INFO ] Current Subscription : 0cc2a67a-xxxx-xxxx-xxxx-bfa46a28e896.
06/13/2019 08:08:39 : [INFO ] ------------------------------------------------------------------
06/13/2019 08:08:39 : [INFO ] Auto selecting storage account : lisaeastus as per your test region.
06/13/2019 08:08:39 : [INFO ] ------------------------------------------------------------------
06/13/2019 08:08:40 : [INFO ] SubscriptionName       : Linux Integration Services TEST ONLY
06/13/2019 08:08:40 : [INFO ] SubscriptionId         : 0cc2a67a-xxxx-xxxx-xxxx-bfa46a28e896
06/13/2019 08:08:40 : [INFO ] User<EMAIL_ADDRESS>06/13/2019 08:08:40 : [INFO ] ServiceEndpoint        : https://management.core.windows.net/
06/13/2019 08:08:40 : [INFO ] CurrentStorageAccount  : lisaeastus
06/13/2019 08:08:40 : [INFO ] ------------------------------------------------------------------
.
.
.
[LISAv2 Test Results Summary]
Test Run On           : 06/13/2019 08:08:40
ARM Image Under Test  : Canonical : UbuntuServer : 16.04-LTS : latest
Test Category         : Functional
Test Area             : CORE
Total Test Cases      : 1 (1 Passed, 0 Failed, 0 Aborted, 0 Skipped)
Total Time (dd:hh:mm) : 0:0:5

   ID TestArea             TestCaseName                                                                TestResult TestDuration(in minutes)
-------------------------------------------------------------------------------------------------------------------------------------------
    1 CORE                 VERIFY-DEPLOYMENT-PROVISION                                                       PASS                 2.77
        FirstBoot : PASS
        FirstBoot : Call Trace Verification : PASS
        Reboot : PASS
        Reboot : Call Trace Verification : PASS

Logs can be found at D:\GitHub\LISAv2-2\TestResults\2019-13-06-01-08-34-1650

06/13/2019 08:14:34 : [INFO ] Creating 'D:\GitHub\LISAv2-2\Azure-Functional-CORE-AH61-TestLogs.zip' from 'D:\GitHub\LISAv2-2\TestResults\2019-13-06-01-08-34-1650'
06/13/2019 08:14:34 : [INFO ] D:\GitHub\LISAv2-2\Azure-Functional-CORE-AH61-TestLogs.zip created successfully.
06/13/2019 08:14:34 : [INFO ] Analyzing results..
06/13/2019 08:14:34 : [INFO ] LISAv2 exit code: 0

Scenario 3 : Azure context file present in LISAv2 root directory (Secret file doesn't contain any Authentication info)
06/13/2019 10:16:11 : [INFO ] .\XML\AzureSecretsTESTONLY.xml found.
06/13/2019 10:16:11 : [INFO ] ------------------------------------------------------------------
06/13/2019 10:16:12 : [INFO ] Authenticating with context file D:\GitHub\LISAv2-2\AzureSessionContext.json
06/13/2019 10:16:15 : [INFO ] Current Subscription : 0cc2a67a-xxxx-xxxx-xxxx-bfa46a28e896.
06/13/2019 10:16:15 : [INFO ] ------------------------------------------------------------------
06/13/2019 10:16:15 : [INFO ] Auto selecting storage account : lisaeastus as per your test region.
06/13/2019 10:16:15 : [INFO ] ------------------------------------------------------------------
06/13/2019 10:16:15 : [INFO ] SubscriptionName       : Linux Integration Services TEST ONLY
06/13/2019 10:16:15 : [INFO ] SubscriptionId         : 0cc2a67a-xxxx-xxxx-xxxx-bfa46a28e896
06/13/2019 10:16:15 : [INFO ] User<EMAIL_ADDRESS>06/13/2019 10:16:15 : [INFO ] ServiceEndpoint        : https://management.core.windows.net/
06/13/2019 10:16:15 : [INFO ] CurrentStorageAccount  : lisaeastus
06/13/2019 10:16:15 : [INFO ] ------------------------------------------------------------------
.
.
.
[LISAv2 Test Results Summary]
Test Run On           : 06/13/2019 10:16:17
ARM Image Under Test  : Canonical : UbuntuServer : 16.04-LTS : latest
Test Category         : Functional
Test Area             : CORE
Total Test Cases      : 1 (1 Passed, 0 Failed, 0 Aborted, 0 Skipped)
Total Time (dd:hh:mm) : 0:0:5

   ID TestArea             TestCaseName                                                                TestResult TestDuration(in minutes)
-------------------------------------------------------------------------------------------------------------------------------------------
    1 CORE                 VERIFY-DEPLOYMENT-PROVISION                                                       PASS                  2.7
        FirstBoot : PASS
        FirstBoot : Call Trace Verification : PASS
        Reboot : PASS
        Reboot : Call Trace Verification : PASS

Logs can be found at D:\GitHub\LISAv2-2\TestResults\2019-13-06-03-16-11-1000

06/13/2019 10:22:00 : [INFO ] Creating 'D:\GitHub\LISAv2-2\Azure-Functional-CORE-TQ46-TestLogs.zip' from 'D:\GitHub\LISAv2-2\TestResults\2019-13-06-03-16-11-1000'
06/13/2019 10:22:00 : [INFO ] D:\GitHub\LISAv2-2\Azure-Functional-CORE-TQ46-TestLogs.zip created successfully.
06/13/2019 10:22:00 : [INFO ] Analyzing results..
06/13/2019 10:22:00 : [INFO ] LISAv2 exit code: 0

Scenario 4 : Use already authenticated session (Only if Scenario 1, 2, 3 is failed)
06/13/2019 08:06:52 : [INFO ] .\XML\AzureSecretsTESTONLY.xml found.
06/13/2019 08:06:52 : [INFO ] ------------------------------------------------------------------
06/13/2019 08:06:52 : [WARN ] No Azure authentication methods were available in Secret File.
06/13/2019 08:06:52 : [WARN ] No Azure authentication context files detected in D:\GitHub\LISAv2-2.
06/13/2019 08:06:52 : [INFO ] Checking if current Azure powershell session is already authenticated...
06/13/2019 08:06:54 : [INFO ] Authenticated.
06/13/2019 08:06:54 : [INFO ] Current Subscription : 0cc2a67a-xxxx-xxxx-xxxx-bfa46a28e896.
06/13/2019 08:06:54 : [INFO ] ------------------------------------------------------------------
06/13/2019 08:06:54 : [INFO ] Auto selecting storage account : lisaeastus as per your test region.
06/13/2019 08:06:54 : [INFO ] ------------------------------------------------------------------
06/13/2019 08:06:55 : [INFO ] SubscriptionName       : Linux Integration Services TEST ONLY
06/13/2019 08:06:55 : [INFO ] SubscriptionId         : 0cc2a67a-xxxx-xxxx-xxxx-bfa46a28e896
06/13/2019 08:06:55 : [INFO ] User<EMAIL_ADDRESS>06/13/2019 08:06:55 : [INFO ] ServiceEndpoint        : https://management.core.windows.net/
06/13/2019 08:06:55 : [INFO ] CurrentStorageAccount  : lisaeastus
06/13/2019 08:06:55 : [INFO ] ------------------------------------------------------------------
.
.
.
[LISAv2 Test Results Summary]
Test Run On           : 06/13/2019 08:06:56
ARM Image Under Test  : Canonical : UbuntuServer : 16.04-LTS : latest
Test Category         : Functional
Test Area             : CORE
Total Test Cases      : 1 (1 Passed, 0 Failed, 0 Aborted, 0 Skipped)
Total Time (dd:hh:mm) : 0:0:5

   ID TestArea             TestCaseName                                                                TestResult TestDuration(in minutes)
-------------------------------------------------------------------------------------------------------------------------------------------
    1 CORE                 VERIFY-DEPLOYMENT-PROVISION                                                       PASS                 2.81
        FirstBoot : PASS
        FirstBoot : Call Trace Verification : PASS
        Reboot : PASS
        Reboot : Call Trace Verification : PASS

Logs can be found at D:\GitHub\LISAv2-2\TestResults\2019-13-06-01-06-51-8198

06/13/2019 08:12:48 : [INFO ] Creating 'D:\GitHub\LISAv2-2\Azure-Functional-CORE-NR52-TestLogs.zip' from 'D:\GitHub\LISAv2-2\TestResults\2019-13-06-01-06-51-8198'
06/13/2019 08:12:49 : [INFO ] D:\GitHub\LISAv2-2\Azure-Functional-CORE-NR52-TestLogs.zip created successfully.
06/13/2019 08:12:49 : [INFO ] Analyzing results..
06/13/2019 08:12:49 : [INFO ] LISAv2 exit code: 0

Scenario 5 : No authentication methods available.
06/13/2019 08:05:16 : [INFO ] Using provided secrets file: .\XML\AzureSecretsTESTONLY.xml
06/13/2019 08:05:16 : [INFO ] .\XML\AzureSecretsTESTONLY.xml found.
06/13/2019 08:05:16 : [INFO ] ------------------------------------------------------------------
06/13/2019 08:05:16 : [WARN ] No Azure authentication methods were available in Secret File.
06/13/2019 08:05:16 : [WARN ] No Azure authentication context files detected in D:\GitHub\LISAv2-2.
06/13/2019 08:05:16 : [INFO ] Checking if current Azure powershell session is already authenticated...
06/13/2019 08:05:18 : [ERROR] Unable to proceed with unauthenticated Azure powershell session.
06/13/2019 08:05:18 : [INFO ] Please use one of the following method to authenticate this session.
06/13/2019 08:05:18 : [INFO ] 1. Provide service principal details in XML secrets file.
06/13/2019 08:05:18 : [INFO ]     a. SubscriptionServicePrincipalClientID
06/13/2019 08:05:18 : [INFO ]     b. SubscriptionServicePrincipalTenantID
06/13/2019 08:05:18 : [INFO ]     c. SubscriptionServicePrincipalKey
06/13/2019 08:05:18 : [INFO ] 2. Provide the path of authenticated context file in XML secrets file.
06/13/2019 08:05:18 : [INFO ]     a. AzureContextFilePath
06/13/2019 08:05:18 : [INFO ] 3. Copy authenticated context file in D:\GitHub\LISAv2-2
06/13/2019 08:05:18 : [INFO ] 4. Authenticate this current session by running Connect-AzureRmAccount command, and then run LISAv2 again.
06/13/2019 08:05:18 : [ERROR] EXCEPTION: There was an error when selecting 0cc2a67a-xxxx-xxxx-xxxx-bfa46a28e896.
06/13/2019 08:05:18 : [ERROR] Source: Line 2462 in script .\Libraries\Azure.psm1.
06/13/2019 08:05:18 : [INFO ] LISAv2 exit code: 1

Scenario 1 : Service principal authentication given in Secret File
06/18/2019 11:07:42 : [INFO ] Using provided secrets file: .\XML\AzureSecretsTESTONLY.xml
06/18/2019 11:07:42 : [INFO ] .\XML\AzureSecretsTESTONLY.xml found.
06/18/2019 11:07:43 : [INFO ] ------------------------------------------------------------------
06/18/2019 11:07:43 : [INFO ] Authenticating Azure PS session using Service Principal...
06/18/2019 11:07:45 : [INFO ] Current Subscription : 0cc2a67a-xxxx-xxxx-xxxx-bfa46a28e896.
06/18/2019 11:07:45 : [INFO ] ------------------------------------------------------------------
06/18/2019 11:07:45 : [INFO ] Auto selecting storage account : lisaeastus as per your test region.
06/18/2019 11:07:45 : [INFO ] ------------------------------------------------------------------
06/18/2019 11:07:46 : [INFO ] SubscriptionName       : Linux Integration Services TEST ONLY
06/18/2019 11:07:46 : [INFO ] SubscriptionId         : 0cc2a67a-xxxx-xxxx-xxxx-bfa46a28e896
06/18/2019 11:07:46 : [INFO ] User                   : f781dc82-f748-4b25-9b85-01e723e9bdcc
06/18/2019 11:07:46 : [INFO ] ServiceEndpoint        : https://management.core.windows.net/
06/18/2019 11:07:46 : [INFO ] CurrentStorageAccount  : lisaeastus
06/18/2019 11:07:46 : [INFO ] ------------------------------------------------------------------
06/18/2019 11:07:46 : [INFO ] Setting global variables
.
.
.
[LISAv2 Test Results Summary]
Test Run On           : 06/18/2019 11:07:47
ARM Image Under Test  : Canonical : UbuntuServer : 16.04-LTS : latest
Test Category         : Functional
Test Area             : CORE
Total Test Cases      : 1 (1 Passed, 0 Failed, 0 Aborted, 0 Skipped)
Total Time (dd:hh:mm) : 0:0:6

   ID TestArea             TestCaseName                                                                TestResult TestDuration(in minutes)
-------------------------------------------------------------------------------------------------------------------------------------------
    1 CORE                 VERIFY-DEPLOYMENT-PROVISION                                                       PASS                 2.82
        FirstBoot : PASS
        FirstBoot : Call Trace Verification : PASS
        Reboot : PASS
        Reboot : Call Trace Verification : PASS

Logs can be found at D:\GitHub\LISAv2-2\TestResults\2019-18-06-04-07-42-3094

06/18/2019 11:14:03 : [INFO ] Creating 'D:\GitHub\LISAv2-2\Azure-Functional-CORE-HO15-TestLogs.zip' from 'D:\GitHub\LISAv2-2\TestResults\2019-18-06-04-07-42-3094'
06/18/2019 11:14:03 : [INFO ] D:\GitHub\LISAv2-2\Azure-Functional-CORE-HO15-TestLogs.zip created successfully.
06/18/2019 11:14:03 : [INFO ] Analyzing results..
06/18/2019 11:14:03 : [INFO ] LISAv2 exit code: 0

Scenario 2 : Azure context file path given in secret file
06/18/2019 11:29:39 : [INFO ] Using provided secrets file: .\XML\AzureSecretsTESTONLY.xml
06/18/2019 11:29:39 : [INFO ] .\XML\AzureSecretsTESTONLY.xml found.
06/18/2019 11:29:39 : [INFO ] ------------------------------------------------------------------
06/18/2019 11:29:39 : [INFO ] Authenticating Azure PS session using saved context file C:\Users\v-shsave\Desktop\AzureSessionContext.json...
06/18/2019 11:29:39 : [INFO ] Imported<EMAIL_ADDRESS>user session.
06/18/2019 11:29:41 : [INFO ] Current Subscription : 0cc2a67a-xxxx-xxxx-xxxx-bfa46a28e896.
06/18/2019 11:29:41 : [INFO ] ------------------------------------------------------------------
06/18/2019 11:29:41 : [INFO ] Auto selecting storage account : lisaeastus as per your test region.
06/18/2019 11:29:41 : [INFO ] ------------------------------------------------------------------
06/18/2019 11:29:42 : [INFO ] SubscriptionName       : Linux Integration Services TEST ONLY
06/18/2019 11:29:42 : [INFO ] SubscriptionId         : 0cc2a67a-xxxx-xxxx-xxxx-bfa46a28e896
06/18/2019 11:29:42 : [INFO ] User<EMAIL_ADDRESS>06/18/2019 11:29:42 : [INFO ] ServiceEndpoint        : https://management.core.windows.net/
06/18/2019 11:29:42 : [INFO ] CurrentStorageAccount  : lisaeastus
06/18/2019 11:29:42 : [INFO ] ------------------------------------------------------------------
06/18/2019 11:29:42 : [INFO ] Setting global variables
.
.
.
[LISAv2 Test Results Summary]
Test Run On           : 06/18/2019 11:29:43
ARM Image Under Test  : Canonical : UbuntuServer : 16.04-LTS : latest
Test Category         : Functional
Test Area             : CORE
Total Test Cases      : 1 (1 Passed, 0 Failed, 0 Aborted, 0 Skipped)
Total Time (dd:hh:mm) : 0:0:6

   ID TestArea             TestCaseName                                                                TestResult TestDuration(in minutes)
-------------------------------------------------------------------------------------------------------------------------------------------
    1 CORE                 VERIFY-DEPLOYMENT-PROVISION                                                       PASS                 2.69
        FirstBoot : PASS
        FirstBoot : Call Trace Verification : PASS
        Reboot : PASS
        Reboot : Call Trace Verification : PASS

Logs can be found at D:\GitHub\LISAv2-2\TestResults\2019-18-06-04-29-38-5472

06/18/2019 11:35:48 : [INFO ] Creating 'D:\GitHub\LISAv2-2\Azure-Functional-CORE-KL79-TestLogs.zip' from 'D:\GitHub\LISAv2-2\TestResults\2019-18-06-04-29-38-5472'
06/18/2019 11:35:48 : [INFO ] D:\GitHub\LISAv2-2\Azure-Functional-CORE-KL79-TestLogs.zip created successfully.
06/18/2019 11:35:48 : [INFO ] Analyzing results..
06/18/2019 11:35:48 : [INFO ] LISAv2 exit code: 0

Scenario 3 : Azure context file present in LISAv2 root directory (Secret file doesn't contain any Authentication info)
06/18/2019 12:00:23 : [INFO ] Using provided secrets file: .\XML\AzureSecretsTESTONLY.xml
06/18/2019 12:00:23 : [INFO ] .\XML\AzureSecretsTESTONLY.xml found.
06/18/2019 12:00:24 : [INFO ] ------------------------------------------------------------------
06/18/2019 12:00:24 : [INFO ] Authenticating Azure PS session using D:\GitHub\LISAv2-2\AzureSessionContext.json found in working directory.
06/18/2019 12:00:24 : [INFO ] Imported<EMAIL_ADDRESS>user session.
06/18/2019 12:00:26 : [INFO ] Current Subscription : 0cc2a67a-xxxx-xxxx-xxxx-bfa46a28e896.
06/18/2019 12:00:26 : [INFO ] ------------------------------------------------------------------
06/18/2019 12:00:26 : [INFO ] Auto selecting storage account : lisaeastus as per your test region.
06/18/2019 12:00:26 : [INFO ] ------------------------------------------------------------------
06/18/2019 12:00:27 : [INFO ] SubscriptionName       : Linux Integration Services TEST ONLY
06/18/2019 12:00:27 : [INFO ] SubscriptionId         : 0cc2a67a-xxxx-xxxx-xxxx-bfa46a28e896
06/18/2019 12:00:27 : [INFO ] User<EMAIL_ADDRESS>06/18/2019 12:00:27 : [INFO ] ServiceEndpoint        : https://management.core.windows.net/
06/18/2019 12:00:27 : [INFO ] CurrentStorageAccount  : lisaeastus
06/18/2019 12:00:27 : [INFO ] ------------------------------------------------------------------
06/18/2019 12:00:27 : [INFO ] Setting global variables
.
.
.
[LISAv2 Test Results Summary]
Test Run On           : 06/18/2019 12:00:28
ARM Image Under Test  : Canonical : UbuntuServer : 16.04-LTS : latest
Test Category         : Functional
Test Area             : CORE
Total Test Cases      : 1 (1 Passed, 0 Failed, 0 Aborted, 0 Skipped)
Total Time (dd:hh:mm) : 0:0:5

   ID TestArea             TestCaseName                                                                TestResult TestDuration(in minutes)
-------------------------------------------------------------------------------------------------------------------------------------------
    1 CORE                 VERIFY-DEPLOYMENT-PROVISION                                                       PASS                 2.76
        FirstBoot : PASS
        FirstBoot : Call Trace Verification : PASS
        Reboot : PASS
        Reboot : Call Trace Verification : PASS

Logs can be found at D:\GitHub\LISAv2-2\TestResults\2019-18-06-05-00-23-1804

06/18/2019 12:06:25 : [INFO ] Creating 'D:\GitHub\LISAv2-2\Azure-Functional-CORE-SU57-TestLogs.zip' from 'D:\GitHub\LISAv2-2\TestResults\2019-18-06-05-00-23-1804'
06/18/2019 12:06:25 : [INFO ] D:\GitHub\LISAv2-2\Azure-Functional-CORE-SU57-TestLogs.zip created successfully.
06/18/2019 12:06:25 : [INFO ] Analyzing results..
06/18/2019 12:06:25 : [INFO ] LISAv2 exit code: 0

Scenario 4 : Use already authenticated session (Only if Scenario 1, 2, 3 is failed)
06/18/2019 11:49:13 : [INFO ] Using provided secrets file: .\XML\AzureSecretsTESTONLY.xml
06/18/2019 11:49:13 : [INFO ] .\XML\AzureSecretsTESTONLY.xml found.
06/18/2019 11:49:13 : [INFO ] ------------------------------------------------------------------
06/18/2019 11:49:13 : [WARN ] No Azure authentication methods were available in Secret File.
06/18/2019 11:49:13 : [WARN ] No Azure authentication context files detected in D:\GitHub\LISAv2-2.
06/18/2019 11:49:13 : [INFO ] Checking if Current Azure powershell session is authenticated...
06/18/2019 11:49:14 : [INFO ] Current Azure powershell session is authenticated by<EMAIL_ADDRESS>06/18/2019 11:49:15 : [INFO ] Current Subscription : 0cc2a67a-xxxx-xxxx-xxxx-bfa46a28e896.
06/18/2019 11:49:15 : [INFO ] ------------------------------------------------------------------
06/18/2019 11:49:15 : [INFO ] Auto selecting storage account : lisaeastus as per your test region.
06/18/2019 11:49:15 : [INFO ] ------------------------------------------------------------------
06/18/2019 11:49:16 : [INFO ] SubscriptionName       : Linux Integration Services TEST ONLY
06/18/2019 11:49:16 : [INFO ] SubscriptionId         : 0cc2a67a-xxxx-xxxx-xxxx-bfa46a28e896
06/18/2019 11:49:16 : [INFO ] User<EMAIL_ADDRESS>06/18/2019 11:49:16 : [INFO ] ServiceEndpoint        : https://management.core.windows.net/
06/18/2019 11:49:16 : [INFO ] CurrentStorageAccount  : lisaeastus
06/18/2019 11:49:16 : [INFO ] ------------------------------------------------------------------
06/18/2019 11:49:16 : [INFO ] Setting global variables
.
.
.
[LISAv2 Test Results Summary]
Test Run On           : 06/18/2019 11:49:16
ARM Image Under Test  : Canonical : UbuntuServer : 16.04-LTS : latest
Test Category         : Functional
Test Area             : CORE
Total Test Cases      : 1 (1 Passed, 0 Failed, 0 Aborted, 0 Skipped)
Total Time (dd:hh:mm) : 0:0:5

   ID TestArea             TestCaseName                                                                TestResult TestDuration(in minutes)
-------------------------------------------------------------------------------------------------------------------------------------------
    1 CORE                 VERIFY-DEPLOYMENT-PROVISION                                                       PASS                 2.62
        FirstBoot : PASS
        FirstBoot : Call Trace Verification : PASS
        Reboot : PASS
        Reboot : Call Trace Verification : PASS

Logs can be found at D:\GitHub\LISAv2-2\TestResults\2019-18-06-04-49-13-1107

06/18/2019 11:55:14 : [INFO ] Creating 'D:\GitHub\LISAv2-2\Azure-Functional-CORE-QM57-TestLogs.zip' from 'D:\GitHub\LISAv2-2\TestResults\2019-18-06-04-49-13-1107'
06/18/2019 11:55:14 : [INFO ] D:\GitHub\LISAv2-2\Azure-Functional-CORE-QM57-TestLogs.zip created successfully.
06/18/2019 11:55:14 : [INFO ] Analyzing results..
06/18/2019 11:55:14 : [INFO ] LISAv2 exit code: 0

Scenario 5 : No authentication methods available.
06/18/2019 11:49:59 : [INFO ] Using provided secrets file: .\XML\AzureSecretsTESTONLY.xml
06/18/2019 11:49:59 : [INFO ] .\XML\AzureSecretsTESTONLY.xml found.
06/18/2019 11:49:59 : [INFO ] ------------------------------------------------------------------
06/18/2019 11:49:59 : [WARN ] No Azure authentication methods were available in Secret File.
06/18/2019 11:49:59 : [WARN ] No Azure authentication context files detected in D:\GitHub\LISAv2-2.
06/18/2019 11:49:59 : [INFO ] Checking if Current Azure powershell session is authenticated...
06/18/2019 11:49:59 : [ERROR] Current Azure powershell session is not authenticated.
06/18/2019 11:49:59 : [ERROR] Unable to proceed with unauthenticated Azure powershell session.
06/18/2019 11:49:59 : [INFO ] Please use one of the following method to authenticate this session.
06/18/2019 11:49:59 : [INFO ] 1. Provide service principal details in XML secrets file.
06/18/2019 11:49:59 : [INFO ]     a. SubscriptionServicePrincipalClientID
06/18/2019 11:49:59 : [INFO ]     b. SubscriptionServicePrincipalTenantID
06/18/2019 11:49:59 : [INFO ]     c. SubscriptionServicePrincipalKey
06/18/2019 11:49:59 : [INFO ] 2. Provide the path of authenticated context file in XML secrets file.
06/18/2019 11:49:59 : [INFO ]     a. AzureContextFilePath
06/18/2019 11:49:59 : [INFO ] 3. Copy only 1 authenticated context file in D:\GitHub\LISAv2-2
06/18/2019 11:49:59 : [INFO ] 4. Authenticate this current session by running Connect-AzAccount command, and then run LISAv2 again.
06/18/2019 11:49:59 : [ERROR] EXCEPTION: User authenticatin failed / not available.
06/18/2019 11:49:59 : [ERROR] Source: Line 2507 in script .\Libraries\Azure.psm1.
06/18/2019 11:49:59 : [INFO ] LISAv2 exit code: 1

@juhlee-microsoft , I've re-structured the code and posted the results for all scenarios again.
Please check and let me know.

@juhlee-microsoft Waiting for your sign-off...


Terminal Icon picker weird placement

The terminal icon picker is positioned at the far top of the window. This looks a bit weird as the top border of the widget is not visible. I would have expected the widget to be placed bellow the command center.

Code pointer: https://github.com/microsoft/vscode/blob/191a248afd908b018bbf05087be8898498e1eec6/src/vs/workbench/contrib/terminal/browser/terminalIconPicker.ts#L60

@sossost ideally we would position it below the command center when it's triggered via the command palette, or near the terminal tab if it's triggered from there.

Wow.

@Tyriar Like @abhijit-chikane has expressed his concern in the PR raised should we probably change the position of the terminal icon colour change tab as well if not it might look weird where one shows the position on bottom and the other on top .

@Tyriar I'm working on this one if you don't mind.
I took over the PR but I had to make some changes to it because the icon picker was still at the top when there was only one terminal instance.
I'm also changing the color picker so we have it positioned like the icons picker

I want to work on this issue as my first ever proper issue. Can I be assigned to this?

How do I test this code?

@benibenj FYI I don't think we should do the placement change for the command center as the quick pick puts itself over it. It does however hide the command center which we should do instead to remain consistent.
The icon hover attached to the tab should still happen though.


Report: Local TDO by name

I took a stab at this in Pull Request: https://github.com/pdarg/tmlpstats/pull/74

Pull request #124


Date/Time picker Not available like adminLTE

Hello,
Date/Time Picker plugin is also not supporting in this template, please provide supportable plugin for date time picker like aminLTE

 test

 Date/Time picker Not available like adminLTE #150

Thank You So Much For Reply, Waiting For Update


https://github.com/tzutalin/labelImg/issues/31 add support for displa…

…ying and saving unicode labels

Nice.


Added bidirectional support for a startDate and endDate

When selectedSecondDate is provided then all dates between selectedSecondDate and selectedDate will be highlighted as long as selectedSecondDate is early.

Need to deal with week mode first, thanks for doing this~


Provide source code lines when reporting breaking changes

Is your feature request related to a problem? Please describe.
Currently, breaking change detection provides no source code lines. As a result, the annotations placed in GitHub via the githubactions format are always attached to the first line of the file. This makes it harder than necessary to trace the origin of the problematic source code change.
Describe the solution you'd like
Where possible, detected breaking changes should be associated with the source line of the closes affected concept. For instance, if a mandatory property is removed from a model, then the source code line could be the start of the model or, even better, the line the removal took place.
Describe alternatives you've considered
None
Additional context
None

Are your specs written in json or yaml?

We use yaml

Looks like we may have a way to implement this but it requires some heavy lifting.
Before making this investment, it would be great to hear from users how much value this would provide.

For other people looking at this, here is a demonstration of this limitation:
https://github.com/oasdiff/github-demo/actions/runs/9797247511
When clicking the annotations you get redirected to the first line of the spec instead of the specific line that was changed.

Update:
I am making good progress on this.
Here's a working example of oasdiff providing the source code line within a GitHub annotation: https://github.com/oasdiff/github-demo/actions/runs/12018342867
Click the annotation to see the breaking change in the context of the OpenAPI spec:
https://github.com/oasdiff/github-demo/commit/ee32aefdce17a7e6e0422178479775e2744a51a5#annotation_29032785074


Setting "Selected" Value of Select Boxes via Controller

Hey everyone,
Here's an issue I'm running into. I'm building a form that submits JSONs to a server. The form also lets users to load pre-built JSONs and then populates the form accordingly.
I'm using simple scope assignments like the following:
    $scope.formData.institution = json.general.institution;

Trouble is that for chosen select boxes, this approach doesnt change the value inside the select box. Setting scope variables like this works fine for multi-select chosen boxes, as with select boxes when I've removed the chosen directive.
But for single select chosen boxes -- I'm unsure of how to assign a value, outside of users directly selecting one themselves.  Suggestions?

Issue gets resolved when you switch from explicit s to using ng-options.


Changes in local filesystem are not being broadcasted

I use the following configuration for my spring config server:
spring:
  profiles:
    active: native
  application:
    name: cloudconfig
  cloud:
    config:
      server:
        native:
          search-locations: file:${user.home}/localrepo

Is there any way to broadcast the changes in the local configuration files to the clients? For example when i would like to add a new route to the zuul's config file.

See https://github.com/spring-cloud/spring-cloud-config/blob/master/docs/src/main/asciidoc/spring-cloud-config.adoc#push-notifications-and-spring-cloud-bus


Performance optimization + part removal fix

Changelog category (leave one):

Performance Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fix CNCH part removal logic
Fix wrong logic that causes recreating buffer even while seeking within same diskcache segment

Detailed description / Documentation draft:
...
If you are doing this for the first time, it's recommended to read the lightweight Contributing to ByConity Documentation guide first.

@linkwk7 @hustnn help review


gitops by env doc

Thanks for contributing to the Harness Developer Hub! Our code owners will review your submission.
Description

Please describe your changes: \ gitops by env doc
Jira/GitHub Issue numbers (if any): \DBOPS-428
Preview links/images (Internal contributors only): __________________

PR lifecycle
We aim to merge PRs within one week or less, but delays happen sometimes.
If your PR is open longer than two weeks without any human activity, please tag a code owner in a comment.
PRs must meet these requirements to be merged:

[X] Successful preview build.
[X] Code owner review.
[X] No merge conflicts.
[X] Release notes/new features docs: Feature/version released to at least one prod environment.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://67002e731ba990952e489b4a--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://670070ac20b63c3dbcf0a26f--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://67195cbf67db368c84379bb5--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://671a9f14c6e19e3df2be7e81--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://671aa00f86046651af1fb24f--harness-developer.netlify.app


[ISSUE #8777] enhance error log when when can't connect to namesrv addrs

Which Issue(s) This PR Fixes

Fixes #8777
Brief Description

How Did You Test This Change?

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 47.38%. Comparing base (551c8c3) to head (abba5c3).

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #8778   +/-   ##
==========================================
  Coverage      47.37%   47.38%
+ Complexity     11558    11557    -1
==========================================
  Files           1282     1282
  Lines          89864    89864
  Branches       11563    11563
==========================================
+ Hits           42575    42579    +4
+ Misses         42040    42032    -8
- Partials        5249     5253    +4

Flag
Coverage Δ

?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


”Leoști”, ”Rusca”, ”Todireni”, ”Văleni” are listed in  the drop-down menu

Description:
When user writes ”Leoști”, ”Rusca”, ”Todireni”, ”Văleni” the locations appear in the drop-down menu next to the comune and the county which is a part according to the law.
Precondition:
The website is up an running.

Step 1
Write in the search bar "Leoști"

Expected results
The location appears in the drop-down menu as "Sat Leoști, VASLUI (Pădureni)".

Step 2
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 3
Write in the search bar "Rusca"

Expected results
The location appears in the drop-down menu as "Sat Rusca, VASLUI (Pădureni)".

Step 4
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 5
Write in the search bar "Todireni"

Expected results
The location appears in the drop-down menu as "Sat Todireni, VASLUI (Pădureni)".

Step 6
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 7
Write in the search bar "Văleni"

Expected results
The location appears in the drop-down menu as "Sat Văleni, VASLUI (Pădureni)".


have you computed the EER?

Thank you for your complete code with the detailed description.
After completing the Training, have you computed/ calculated the Equal Error Rate using the classification dataset by using the pre-trained model?

No, I haven't, because the goal of the evaluation was to compare with other state-of-the-art methods, and this metric is not typically reported.  But I also don't understand how it is applicable here - the Equal Error Rate can be used only in cases of binary classification. At any rate, you have access to the prediction scores, so you can certainly use e.g. sklearn to get the AUROC, EER, etc.


Adding Gaussian Naive Bayes classifier

This PR contains the GaussianNaiveBayesClassifier class. There is a working example in the class's main(). @jdpigeon let me know if you have any questions or comments!

@jdpigeon :

We will need two collection periods (one for each class). E.g., 30 s eyes open, then 30 s eyes closed. The classifier computes the probability that an incoming set of data belongs to each one of the classes it was previously fit on. In our case, that would be P(new data = eyes open) and P(new data = eyes closed). The predicted class is then chosen as the one with the highest probability. In practice, we don't really need to show the probabilities, we could only show the predicted class (although using probabilities could make pretty cool visualizations).
No, using partialFit is not necessary to achieve good accuracy. It's just a cool way to update a model without having to learn the parameters from scratch again. A use case that might be useful for us is the following: after the user trains their classifier and starts using it, we show a button "Add more training data" that the user can click if they feel like the classifier is not accurate enough. Instead of retraining the classifier from scratch, this would let us just update the parameters (which should be faster and less memory-intensive than saving that new data, concatenating it with the previous data, and then training). A second interesting use case would be to train the classifier on-the-fly: instead of collecting 30-s for each class and then training, we could update the weights every time we get a single example (e.g., the band powers for the last 1-s window). Training then becomes an online process, which lets us do other cool stuff (e.g., show the accuracy of the model as it's being trained, or classify during training so the user can see how more data increases accuracy).
yHat stands for the estimated y (the predicted labels). We could rename it something like yPredicted or prediction!

Also, another visualization that could be cool is the decision boundary of the trained classifier. Something like this:

How easy would it be to plot something like that with AndroidPlot?


Source Link should have more detailed information as it has unexpected consequences

Type of issue
Missing information
Description
I want to mention this issues: https://github.com/dotnet/runtime/issues/95134, https://github.com/dotnet/sdk/issues/36885, https://github.com/dotnet/sdk/issues/34568, https://github.com/dotnet/sdk/issues/37158, stackoverflow
As the issues show, the SourceLink adds commit hash to the product version. This might be unexpected because this wasn't included in .net 6 & 7.
For example my application extracts the product version and the commit hash wasn't expected, also we use product version for SCCM and the hash is also not desired.
My problem with the current documentation is that the SourceLink description is too vague, it doesn't say anything about the consequences, for example i did not know it includes commit hash to the product version. It also doesn't link to the sourcelink build properties, in my opinion <IncludeSourceRevisionInInformationalVersion>false</IncludeSourceRevisionInInformationalVersion> is hard to discover if you want everything to work as before.
Maybe it would make sense to add this information to the https://learn.microsoft.com/en-us/dotnet/core/compatibility/8.0 instead of the "What's new".
Page URL
https://learn.microsoft.com/en-us/dotnet/core/whats-new/dotnet-8
Content source URL
https://github.com/dotnet/docs/blob/main/docs/core/whats-new/dotnet-8.md
Document Version Independent Id
b22cffcc-898f-a3cf-83f9-a3c7349a1b14
Article author
gewarren
Metadata

ID: 9d8a154a-d129-7e5a-e2aa-8d1a720252c5
Product: dotnet-fundamentals

Apparently there is this documentation https://learn.microsoft.com/en-us/dotnet/core/compatibility/sdk/8.0/source-link
But I don't understand why it's not listed in the overview https://learn.microsoft.com/en-us/dotnet/core/compatibility/8.0

I feel like this should have been disabled by default. It had a lot of negative consequences in our system, including disabling our entire logging system because the version # was too long to insert into logs.

Edit: I want to clarify our project files still target .NET 7.

Yes, if you target .net7 in TFM but build against net8 SDK, you still will be affected.

@baronfel FYI

I feel like this should have been disabled by default

What about adding <IncludeSourceRevisionInInformationalVersion>false</IncludeSourceRevisionInInformationalVersion> for the target frameworks below .NET 8, then we would not break the project already using it for .NET 8 projects, though it's still a breaking-change

Echoing everyone's comments here and in related threads, this is terrible behaviour to enable by default, especially when most .net8 documentation pages fail to mention it.
One of our newer projects is running .net8 which required .net8 to be installed on our Azure build agents, now to maintain functionality we now have to add falseto hundreds (maybe even thousands) of csproj files.
Having this long version string breaks a lot of integrations with installer creators, deployment services, and artefact services.
User experience for looking at these long version strings is also really bad, not that I think users should even be getting commit IDs etc told to them about the software they have. If MS really wanted to force this behaviour, it really shouldn't be in the version string property IMO.


Exclude jettison version brought in with hadoop-minicluster.

Signed-off-by: Marc Handalian<EMAIL_ADDRESS>Description
See https://github.com/advisories/GHSA-56h3-78gp-v83r. The version was previously bumped in discovery-azure-classic but hadoop-minicluster still brings in a vulnerable version of jettison. This excludes the transitive dependency and brings in the patched version 1.5.1.  This PR also moves the version declaration to version.properties.
Issues Resolved
[List any issues this PR will resolve]
Check List

[ ] New functionality includes testing.

[ ] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[ ] Commits are signed per the DCO using --signoff
[ ] Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #4787 (00e9dbb) into main (d15795a) will increase coverage by 0.12%.
The diff coverage is 44.81%.

@@             Coverage Diff              @@
##               main    #4787      +/-   ##
============================================
+ Coverage     70.66%   70.78%   +0.12%
- Complexity    57578    57670      +92
============================================
  Files          4661     4675      +14
  Lines        276662   276918     +256
  Branches      40325    40347      +22
============================================
+ Hits         195501   196020     +519
+ Misses        64926    64595     -331
- Partials      16235    16303      +68

Impacted Files
Coverage Δ

.../delete/DeleteDecommissionStateRequestBuilder.java
0.00% <0.00%> (ø)

...te/ClusterDeleteWeightedRoutingRequestBuilder.java
0.00% <0.00%> (ø)

...apshots/restore/RestoreSnapshotRequestBuilder.java
15.78% <0.00%> (-0.88%)
:arrow_down:

.../org/opensearch/client/support/AbstractClient.java
32.77% <0.00%> (-0.16%)
:arrow_down:

.../java/org/opensearch/common/util/FeatureFlags.java
50.00% <ø> (ø)

...ateway/TransportNodesListGatewayStartedShards.java
51.00% <0.00%> (-0.68%)
:arrow_down:

...h/index/shard/RemoveCorruptedShardDataCommand.java
81.51% <ø> (ø)

...java/org/opensearch/index/shard/StoreRecovery.java
67.88% <ø> (+0.01%)
:arrow_up:

...h/index/store/InMemoryRemoteSnapshotDirectory.java
0.00% <0.00%> (ø)

...in/java/org/opensearch/indices/IndicesService.java
69.19% <0.00%> (-0.72%)
:arrow_down:

... and 505 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

windows precommit failure again with timeouts to central.
      > Could not resolve org.apache.httpcomponents:fluent-hc:4.5.13.
         > Could not get resource 'https://repo.maven.apache.org/maven2/org/apache/httpcomponents/fluent-hc/4.5.13/fluent-hc-4.5.13.pom'.
            > Could not GET 'https://repo.maven.apache.org/maven2/org/apache/httpcomponents/fluent-hc/4.5.13/fluent-hc-4.5.13.pom'.
               > Connect to repo.maven.apache.org:443 [repo.maven.apache.org/<IP_ADDRESS>] failed: Connection timed out: connect
   > Could not resolve org.apache.logging.log4j:log4j-jcl:2.17.1.
     Required by:
         project :qa:os
      > Could not resolve org.apache.logging.log4j:log4j-jcl:2.17.1.
         > Could not get resource 'https://repo.maven.apache.org/maven2/org/apache/logging/log4j/log4j-jcl/2.17.1/log4j-jcl-2.17.1.pom'.
            > Could not GET 'https://repo.maven.apache.org/maven2/org/apache/logging/log4j/log4j-jcl/2.17.1/log4j-jcl-2.17.1.pom'.
               > Connect to repo.maven.apache.org:443 [repo.maven.apache.org/<IP_ADDRESS>] failed: Connection timed out: connect

https://github.com/opensearch-project/OpenSearch/issues/4829


Possible wrong pluralisation

Hi,
I believe there's a pluralisation where none is needed.
URL: https://opencollective.com/vuejs/order/1054

I have seen this as well. Thanks for reporting.

Fix here: https://github.com/opencollective/frontend/pull/129. Live later today.


How to access query parameters

Things like /objects?page=2.
When doing:
    async data ({ params }) {
      try {
        let BASE_URL = `http://localhost:8080/api/v1/nations`

        const { data } = await axios.get(BASE_URL)

        return {
          currentPage: data.currentPage,
          nations: data.data
        }
      } catch (e) {
        console.error(e)
      }
    }

I'm not sure how to access the this.$route.query.page.
this is undefined and params doesn't hold any query data, just the id i believe.

You can access with the key query which is an alias of this.$route.query.
More info on the documentation : https://nuxtjs.org/api/pages-context

Thanks, i should've checked the API part instead of just the guide :)

No worries, the documentation is still messy now. :)


arm image doesn't work on quad core armv7 system

when trying to run the arm image available at: http://gsdview.appspot.com/dart-archive/channels/stable/release/1.12.1/sdk/
I get a:
"Illegal instruction"
error
The relevant gdb output:
Reading symbols from dart-sdk/bin/dart...(no debugging symbols found)...done.
[New LWP 15797]
[New LWP 15794]
[New LWP 15795]
[New LWP 15796]
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/arm-linux-gnueabihf/libthread_db.so.1".
Core was generated by `dart-sdk/bin/dart testdart.dart'.
Program terminated with signal SIGILL, Illegal instruction.
#0  0xb5d87644 in ?? ()

the 'testdart.dart' program is a simple hello word:
void main() {
  print("Hello, World!");
}

The machine is a quadcore armv7 running Debian (jessi)
uname -a:
Linux <hostname> 4.1.6-249 #1 SMP Mon Aug 31 12:34:47 UTC 2015 armv7l GNU/Linux
/proc/cpuinfo:
processor       : 0
model name      : ARMv7 Processor rev 2 (v7l)
BogoMIPS        : 1332.01
Features        : half thumb fastmult vfp edsp thumbee vfpv3 tls idiva idivt vfpd32 lpae
CPU implementer : 0x56
CPU architecture: 7
CPU variant     : 0x2
CPU part        : 0x584
CPU revision    : 2

processor       : 1
model name      : ARMv7 Processor rev 2 (v7l)
BogoMIPS        : 1332.01
Features        : half thumb fastmult vfp edsp thumbee vfpv3 tls idiva idivt vfpd32 lpae
CPU implementer : 0x56
CPU architecture: 7
CPU variant     : 0x2
CPU part        : 0x584
CPU revision    : 2

processor       : 2
model name      : ARMv7 Processor rev 2 (v7l)
BogoMIPS        : 1332.01
Features        : half thumb fastmult vfp edsp thumbee vfpv3 tls idiva idivt vfpd32 lpae
CPU implementer : 0x56
CPU architecture: 7
CPU variant     : 0x2
CPU part        : 0x584
CPU revision    : 2

processor       : 3
model name      : ARMv7 Processor rev 2 (v7l)
BogoMIPS        : 1332.01
Features        : half thumb fastmult vfp edsp thumbee vfpv3 tls idiva idivt vfpd32 lpae
CPU implementer : 0x56
CPU architecture: 7
CPU variant     : 0x2
CPU part        : 0x584
CPU revision    : 2

Hardware        : Marvell Armada 370/XP (Device Tree)
Revision        : 0000
Serial          :<PHONE_NUMBER>000000

The disassemble command: http://visualgdb.com/gdbreference/commands/disassemble
So the address you have above was 0xb5d87644, so you'd do:
$ disassemble 0xb5d87604,+128
And gdb will spit out the 16 instructions on either side of the illegal instruction.
A stack trace at the faulting instruction could be useful as well, you can get that with:
$ bt
A bit surprised we're hitting an illegal instruction, this looks like a pretty standard ARMv7-A chip:
http://www.marvell.com/embedded-processors/armada-xp/assets/ARMADA-XP-Functional-SpecDatasheet.pdf

here the dis:
Dump of assembler code from 0xb5d87604 to 0xb5d87684:
   0xb5d87604:  strtlt  r8, [r10], -r1, lsr #32
   0xb5d87608:  strtlt  r8, [r10], -r1, lsr #32
   0xb5d8760c:  strtlt  r8, [r10], -r1, lsr #32
   0xb5d87610:  andseq  r5, r0, r0, lsl #20
   0xb5d87614:  ldrblt  r0, [pc, #3097] ; 0xb5d88235
   0xb5d87618:  ldrblt  r0, [pc, #2929] ; 0xb5d88191
   0xb5d8761c:                  ; <UNDEFINED> instruction: 0x000002bc
   0xb5d87620:  ldr     r0, [sp]
   0xb5d87624:  ldr     r1, [sp, #4]
   0xb5d87628:  orr     r12, r0, r1
   0xb5d8762c:  tst     r12, #1
   0xb5d87630:  bne     0xb5d87654
   0xb5d87634:  cmp     r0, #0
   0xb5d87638:  beq     0xb5d87654
   0xb5d8763c:  asr     r0, r0, #1
   0xb5d87640:  asr     r1, r1, #1
=> 0xb5d87644:                  ; <UNDEFINED> instruction: 0xe7100011
   0xb5d87648:  cmp     r0, #1073741824 ; 0x40000000
   0xb5d8764c:  lslne   r0, r0, #1
   0xb5d87650:  bxne    lr
   0xb5d87654:  mov     r7, r10
   0xb5d87658:  ldr     r10, [pc, #-72] ; 0xb5d87618
   0xb5d8765c:  ldr     r6, [r10, #11]
   0xb5d87660:  mov     r10, r7
   0xb5d87664:  ldr     r7, [r6, #47]   ; 0x2f
   0xb5d87668:  add     r7, r7, #1
   0xb5d8766c:  str     r7, [r6, #47]   ; 0x2f
   0xb5d87670:  movw    r12, #23000     ; 0x59d8
   0xb5d87674:  cmp     r7, r12
   0xb5d87678:  movwge  r12, #33792     ; 0x8400
   0xb5d8767c:  movtge  r12, #46630     ; 0xb626
   0xb5d87680:  bxge    r12

and the bt:
(gdb) bt
#0  0xb5d87644 in ?? ()
#1  0xb6269ba8 in ?? ()
Backtrace stopped: previous frame identical to this frame (corrupt stack?)

Works on Raspberry Pi 2, which lists
Features	: half thumb fastmult vfp edsp neon vfpv3 tls vfpv4 idiva idivt vfpd32 lpae evtstrm
I wonder if we use something from vfpv4.
Can you try running with --use-vfp=false?

Thanks for posting the disassembly. It's the sdiv instruction, which is weird because /proc/cpuinfo is showing integer division support. Might need to add a special case to feature detection. I'll investigate further tomorrow.

I can arrange an access for you to the server if you want. it's empty and unused atm so there is no privacy/security concerns. I can pm you the ip & ssh priv key if you want. just tell me.

Sounds good. In the meantime, to make sure we've really found the problem, could you try passing --no-use-integer-division on the dart command line?

Doing a bit of Googling about this chip, I haven't been able to find any evidence that it misreports the presence of integer division, but Linux does occasionally twiddle these bits before reporting them, so it could be something that is kernel version dependent. The docs say this chip is ARMv7A compliant, and integer division is optional there. If --no-use-integer-division fixes the issue, I'll add a special case for this chip so that the flag isn't needed.

It works with "--no-use-integer-division"! good find!
do you still need access to the server or is this case closed ?

Just landed a special case for this chip in our feature detection at top-of-tree. Closing this issue, but please feel free to re-open if you're unable to verify the fix. Thanks for the bug report!


Documentation issue: Many to many relationships

Should the ShoppingCartEntries columns have references method as per the documentation on foreign key references.

Good point, you're right! I've changed this in cbcde53da63a9c085321ad09ad1493f5b6ddda09 (not deployed yet).


TimeZone Europe/Rome Not Working

I am trying the nodecron in Italy and I set the timezone to Europe/Rome.
No cron strings are working.
If I do not set the timeone, everything is fine.
Why?

Hello @japita-se
It may be a bug, may you send me an example? And how are your current timezone?

My current timezone is Europe/Rome.
The example is very basic:
cron.schedule ("*/1 12 * * Monday-Sunday", () => console.log("Ehi!"), {timezone:'Europe/Rome'})

Hey, I'm wondering about this issue, are you in daylight saving time?

Got the same bug for Europe/Berlin — it triggers one hour before the scheduled time because it's using CET instead of CEST.

Switched to cron for now.
Seems to handle CEST correctly.

@felixheck thanks for getting in touch.
Node-cron will support DST soon, I've created this issue https://github.com/node-cron/node-cron/issues/111 to do that.

@merencia drop a line asa it’s available 😉 node-cron has a much better documentation and a better syntax imho. But without DST it’s currently kinda useless for me.
Keep me updated.
Thanks!

@merencia America/Vancouver is also missing

Unfortunately it doesn't seem possible to catch and handle this edge case, because it happens in a setTimeout

America/New_York doesn't seem to work either.


chore: Update prost, prost-derive and prost-types to 0.10, tonic, and tonic-build to 0.7

Update prost, prost-derive and prost-types to 0.10
Closes https://github.com/apache/arrow-rs/pull/1500
Closes https://github.com/apache/arrow-rs/pull/1501
Closes https://github.com/apache/arrow-rs/pull/1502
Closes https://github.com/apache/arrow-rs/pull/1520
Closes https://github.com/apache/arrow-rs/pull/1521

We probably need to wait for a new version of tonic that updates prost: https://crates.io/crates/tonic/0.6.2/dependencies

Yup, ticket to follow is here - https://github.com/hyperium/tonic/issues/946

FYI tonic 0.7 has now been released and updates prost to 0.10

I have updated to use tonic and tonic-build 0.7 and checked in the newly generated code

Codecov Report

Merging #1510 (a3e3385) into master (d797543) will decrease coverage by 0.01%.
The diff coverage is 61.94%.

:exclamation: Current head a3e3385 differs from pull request most recent head 4767b3b. Consider uploading reports for the commit 4767b3b to get more accurate results

@@            Coverage Diff             @@
##           master    #1510      +/-   ##
==========================================
- Coverage   82.74%   82.72%   -0.02%
==========================================
  Files         188      190       +2
  Lines       54375    54724     +349
==========================================
+ Hits        44993    45273     +280
- Misses       9382     9451      +69

Impacted Files
Coverage Δ

arrow-flight/src/arrow.flight.protocol.rs
0.00% <0.00%> (ø)

arrow/src/array/builder.rs
86.68% <50.00%> (-0.05%)
:arrow_down:

arrow/src/array/equal/utils.rs
74.45% <50.00%> (-3.24%)
:arrow_down:

arrow/src/ffi_stream.rs
79.03% <79.03%> (ø)

arrow/src/array/equal/mod.rs
93.98% <98.78%> (+0.65%)
:arrow_up:

arrow/src/array/equal/union.rs
100.00% <100.00%> (ø)

arrow/src/ffi.rs
87.50% <100.00%> (ø)

parquet_derive/src/parquet_field.rs
66.21% <0.00%> (-0.23%)
:arrow_down:

arrow/src/array/transform/mod.rs
86.57% <0.00%> (+0.22%)
:arrow_up:

arrow/src/datatypes/field.rs
54.10% <0.00%> (+0.30%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d797543...4767b3b. Read the comment docs.


hope to add "Telechat"

https://github.com/Tele-AI/Telechat

Hey!
This seems to be entirely in Chinese. Can you explain in English what this model is for those who don't know/don't have the time to translate?

I'm looking into this model recently as well and it would actually be very helpful if it could be incorporated into Ollama.
Per the intro on their Github README (translated by chatGPT and proof read by me):
The TeleChat language model is developed and trained by the AI subsidiary of China Telecom. The 7B model is trained on 1.5 trillion tokens of high-quality Chinese and English corpus, while the 12B model is trained on 3 trillion tokens of high-quality Chinese and English corpus.
We have open-sourced the chat models TeleChat-1B, TeleChat-7B, and TeleChat-12B, along with their HuggingFace format weights. Additionally, we have released the int8 and int4 quantized versions of the 7B and 12B models.
TeleChat-12B has undergone improvements in model architecture, training data, and training methods, achieving significant performance gains over TeleChat-7B in general Q&A, knowledge, code, and mathematics tasks.

In terms of model architecture, we experimented with a variety of architectural combinations using small-scale models and selected the optimal structure. Compared to the TeleChat-7B model, TeleChat-12B adopts a decoupled structure between the word embedding layer and the output layer, separating the parameters of the word embedding layer from the output lm head layer, enhancing training stability and convergence.
In terms of training data, we collected a vast amount of bilingual data covering areas such as books, encyclopedias, news, government affairs, law, medicine, patents, academic papers, mathematics, and code. By optimizing data cleaning strategies, we significantly improved the cleanliness, neutrality, effectiveness, and formatting of the data.
In terms of training methods, we employed scientific data ratio learning and curriculum learning methods. Small-parameter models were used to fit data with various distributions, providing prior estimates of the difficulty of each dataset. During training, periodical autonomous evaluation of the model’s loss across all datasets and its generation performance on evaluation sets was performed, which dynamically increasing the weight of more difficult datasets to ensure optimal fitting across all datasets.

The TeleChat-12B-V2 version utilizes dynamic data ratios and curriculum learning methods for continuous training and enhancement of the base model. Its dialogue model has seen a 5.5% improvement in general capability evaluation, with a 24.6% improvement in mathematical capabilities, a 9% improvement in translation capabilities, a 10.3% improvement in hallucination testing, and varying degrees of enhancement in safety refusal, knowledge Q&A, and casual conversation Q&A.
https://github.com/Tele-AI/Telechat/blob/master/README.md

Looks fascinating. Thanks @mighty-laolin for the translation. On first glance a model by China Telecom should be of high quality based on the potential training data they have access to. +1 for working towards incorporating it into Ollama.


Add string autocomplete & Bazel mode

Add mechanisms for offering autocomplete options in strings (load paths & strings elsewhere)
Add --bazel flag that spins up an alternative LspContext that implements everything from the current eval.rs, as well as Bazel specific stuff. After the LspContext interface stabilizes, this will be removed and extracted to an external project.

Seems we have a conflict with something - not obvious how to resolve quickly, so can you rebase on master?

@ndmitchell Sure, rebased and force-pushed.

Trying it out quickly in neovim, go-to-defintion mostly works like expected :tada:, with just a few weird cases where it jumps to the top of the file. Completion seems to work fine, have too many sources of stuff to check that it always predicts what should be there. But the end result is good :)

One minor tweak I had to make - StringCompletionResult avoid capturing the &str literal - a clone there doesn't make any real perf difference and it made the implementation of some other LSP traits in Buck2 harder.

Again thank you! I just now saw that it auto-loads providers when they are selected from autocompletion :)


Add funds returns 'created at' error

host of WWCodeDC is trying to manually add funds to the collective and they are getting an error that says 'CreatedAt must be less than or equal to "Tue Apr 12 2016 17:00 GMT-7 PDT" idem for a different date.

From what I can tell, the validator check is failing. https://github.com/OpenCollective/app/blob/master/frontend/src/validators/transaction.js#L22. (Notice CreatedAt is with a capital C. We use it everywhere with a small C, except in the validator.

I couldn't repro this in production or staging or localhost
First guess was the user's clock on computer was screwed up (hard to imagine in this day and age but who knows). I couldn't reproduce it on my machine either after messing with the clock.
Other theories: Maybe they are using IE?

IE8 doesn't support Date.now(), which is what we are using.
@piamancini can you pls find out what browser she's using?

Don't get where that 9-day difference comes from. The validation only accepts dates up to "tomorrow". The error message shows what the code thought was tomorrow's date = April 12th and so "today" was 11th -- vs. the reality being April 20th. One idea to debug is asking the WWCodeDC host to:

go to that "add funds" page
open the Javascript console (in Google Chrome on Mac OS X it's Alt-Cmd-j)
Note what time it really is
type the following commands one by one in order to see what they print ( between each):

var createdAt = Date.now(); createdAt
var today = new Date(); today
var tomorrow = new Date(today); tomorrow.setDate(today.getDate()+1); tomorrow
var tomorrowIso = tomorrow.toISOString(); tomorrowIso
var tomorrowSlice = tomorrowIso.slice(0,10); tomorrowSlice

add the fund by clicking Submit
observe the error message in the banner
send screenshot(s) showing (if possible in same screenshot) the banner error and the console messages

(And I will evaluate myself the result of Joi.validate(createdAt, Joi.date().max(tomorrowSlice).required().raw()))

She tried it again and it went through, it might gave been a setting on her side. I'm going to close this. We'll re open it if it happens again.


Error when image selection is cancelled

To Reproduce
Steps to reproduce the behavior:

Go to Explore > Regions.
Join a region, if not joined.
Tap + to create a new event.
Go through the screen.
Once on Step 5, tap + Add picture.
Once on the photo selection screen, tap Cancel.

Current behavior
Observe the error toast showing Error on selecting image.
Expected behavior
User is not expected to see an error upon cancelling photo selection.
Platform & App Version

iOS
release/2.9.0

✅ Test Case 1

Go to Explore > Regions.
Join a region, if not joined.
Tap + to create a new event.
Go through the screen.
Once on Step 5, tap + Add picture.
Once on the photo selection screen, tap Cancel.
Observe no errors shown upon cancelling photo selection.


⚠ Bofrost.fr has degraded performance

In 2e27df4, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1310 ms

Resolved: Bofrost.fr performance has improved in 09f7991 after 9 minutes.