Replace reference numbers with inline comments

Background
I'm brand new to Kotlin and working through Kotlin by Example. I've noticed that each topic is organised into a structure similar to the following:

package org.kotlinlang.play         // 1

fun main() {                        // 2
    println("Hello, World!")        // 3
}

Kotlin code is usually defined in packages. Package specification is optional: If you don't specify a package in a source file, its content goes to the default package.
An entry point to a Kotlin application is the main function. In Kotlin 1.3, you can declare main without any parameters. The return type is not specified, which means that the function returns nothing.
println writes a line to the standard output. It is imported implicitly. Also note that semicolons are optional.

Problem
Personally, I find this difficult to follow. For each line of code, I need to:

Read the line of code
Memorise the reference number at the end of the line
Skip down the page to the reference notes
Find the reference note with the memorised reference number
Read the reference note
Skip back up the page to the code
Find the line of code I was last at

By the time I finish the topic, I have skipped up and down the page several times.
Solution
Inline the reference notes into the code:

// Kotlin code is usually defined in packages.
// Package specification is optional: If you don't specify a package in a source file,
// its content goes to the default package.
package org.kotlinlang.play

// An entry point to a Kotlin application is the main function.
// In Kotlin 1.3, you can declare main without any parameters.
// The return type is not specified, which means that the function returns nothing.
fun main() {
    // println() writes a line to the standard output.
    // It is imported implicitly. Also note that semicolons are optional.
    println("Hello, World!")
}

Benefits
Now, instead of having to keep skipping down and up the page, I can just follow it from top to bottom. So for each line of code, I need to:

Read the comment
Read the line of code

I find this significantly easier to follow than the way it's currently done.
Alternative solution
If you don't like the look of detailed notes inside code comments, then you could interleave the notes with the code:

Kotlin code is usually defined in packages. Package specification is optional: If you don't specify a package in a source file, its content goes to the default package.
package org.kotlinlang.play

An entry point to a Kotlin application is the main function. In Kotlin 1.3, you can declare main without any parameters. The return type is not specified, which means that the function returns nothing.
fun main() {

println writes a line to the standard output. It is imported implicitly. Also note that semicolons are optional.
    println("Hello, World!")
}

This way is a bit nicer to read, but now it's hard to copy and run the full code block since it's split up, so I'm not sure if it's worth it.
Pull request
I'm happy to make the changes myself and submit a pull request.

Hi!
Thanks for using Kotlin by Example and suggesting your help in improving it.
Your solution looks pretty neat; however, there are certain issues which are major for the current structure:

The first solution significantly decreases the readability since there is no text formatting and all the text is grey. This would be good for reading in an IDE but on web pages, it lacks expressiveness.
The alternative solution makes it impossible to run the entire code sample. We find this unsuitable for interactive learning as well.

So, we find the current design acceptable despite its drawbacks. It's widely used in documentation for other languages and programming learning resources.
Thanks again and good luck in learning Kotlin!
Feel free to contact us on GitHub or in Kotlin slack. BTW, there is a separate channel for Kotlin by Example.
Regards, Pavel,
Kotlin Technical Writer,
JetBrains


Add Linux Persistence through Autostart

Creating persistence by adding the python launcher to the ~/.config/autostart directory. This is based on the CrossRat analysis (https://digitasecurity.com/blog/2018/01/23/crossrat/) and the other links in the comments.
Tested in Ubuntu 16 and Oracle Linux 7.

@jarrodcoulter Thanks! No issues found during testing.


feat: Add ambient types

It is a result of few iterations and testing against a real APP test suite.
It covers most of the current public APIs and provides you with auto-complete or errors when you mistype something.
Some of currently public APIs are intentionally ignored. For example, the current implementation of create supports the following signatures:
  function create(definition) {}
  function create(definition, options) {}
  // not supported
  function create(url, definition) {}
  function create(url, definition, options) {}

I believe, url in create should be avoided in favor of visitable action, so typings from this PR does only support 2 first signatures. This approach allows us to simplify typings and signal a user about a recommended way of doing stuff.
Here is a list of all public API, which are currently exposed to the consumers, but don't have types:

buildSelector
getContext
setContext
is

Limitations
There are some hints for those who decide to write their page objects in TS.
alias
Typescript isn't able to follow nested string paths, like a.path.to.some.deep.property, so each alias returns any:
const page = create({
  doSomething: alias('nestedObject.click'),
  nestedObject: {}
});

page.doSomething(); // returns `any`

Custom methods
Because page object definitions are POJOs, which are static instances, in custom methods we can't have a valid this type. So for custom methods and getters we have to set this to any:
export default {
  something: getter(function(this: any) {
    return this.text as string; // but you can still provide a hint about your return value!
  })
}

the same is true for custom actions:
const page = create({
  doSomething(this: any) {
    return this.click();
  }
})

page.doSomething(); // returns `any`

Documentation
It's missing because I didn't want to duplicate it by copy-pasting it from the JS source code. Someday I hope we would have a truly typed codebase, which would solve the documentation issue, but today I had few stoppers for doing this:

create - not sure if it's possible to type underlying Ceibo
code coverage doesn't work with ec-typescript@2 - https://github.com/kategengler/ember-cli-code-coverage/issues/213

A sidenote: I believe most of the this: any issues should go away, once we figure out a class syntax for definitions.

Coverage remained the same at 98.646% when pulling d637f2b4456e59f61947f10da545205077bbb185 on ro0gr:feature/add-typings into d3daa1062ae09167f64b932ebe16b8ad24f52281 on san650:master.

Yaaaaaas.gif


Fix S3 creation date for AWS Java SDK

Fixes #3306
Verified against AWS CLI and the Java SDK
Re-uses solution from #3182

Coverage decreased (-0.3%) to 94.15% when pulling 8c94893869971de369be7c98492e2548c34fe0f6 on bblommers:bugfix/3306 into da4de072a9a12818a2a9d869a98d4fd7caf10744 on spulec:master.

Thanks!


Adding a feature to crop image uploaded using camera

Summary:
When uploading an Image using camera the camera takes the image and before uploading asks for retake or OK.
Also after user clicking OK we should ask the user to crop the image as per the need.
Would you like to work on the issue?
Yes

The library is using SDK 28 and AndroidX. That is causing conflicts. After #2289 is merged, we should plan migration to AndroidX from our current usage of support libs.

@maskaravivek Now shall I start working upon this cropping feature

Sure. And lets continue the discussion on #1192.


Internship for ECL kernel ?

received this morning on the Mailing list:
https://groups.google.com/forum/?utm_medium=email&utm_source=footer#!msg/jupyter/jTo5WVsh0Co/MjPf6HYxDgAJ
We're offering the opportunity this summer, for a student to work alongside our developers
to develop a Jupiter kernel for our HPCC Systems open source project.

You must be a student in full time education that would be able to work on this project
between June and August, as your only job. There is an option to do this work remotely.
To qualify, you will need Python programming skills and familiarity with the programming
model for kernels in Jupyter.

You'll also need to become familiar with the HPCC Systems platform.

Get more details about our intern program and find out more about the Jupyter
project and other projects we are offering as internships in 2016.

Is that something we want to add in newsletter ?

Cool program. Deadline for applications has passed so closing the issue.


cmd/bosun: window function

Query errors do not bubble up.

Syntax errors now bubble.

updated with improved var names and named params for parse.Func, which I've been wanting to do for a while anyway.

Looks good to me. Can we make a test that exercises it?

Added tests for window function. Also suitable for testing other functions, should we so choose. Other change is to modify cache to accept a nil value that does nothing.

Also the test found a tiiiiiny bug if you happened to have data at the Unix epoch. Worth.

LGTM


bug: fix the missing log.Lmsgprefix in go1.13

name: Pull request
about: Propose changes to the code
title: ''
labels: ''
assignees: ''

1. Are you opening this pull request for bug-fixs, optimizations or new feature?
bug-fixs
2. Please describe how these code changes achieve your intention.

暂时先在 ants.go 里自定义了一个 log.Lmsgprefix 的值 64 。
3. Please link to the relevant issues (if any).

[Bug]: go.mod 中的go version(1.13)和ants.go存在不匹配 #274
4. Which documentation changes (if any) need to be made/updated because of this PR?

ants.go
4. Checklist

[x] I have squashed all insignificant commits.
[x] I have commented my code for explaining package types, values, functions, and non-obvious lines.
[x] I have written unit tests and verified that all tests passes (if needed).
[x] I have documented feature info on the README (only when this PR is adding a new feature).
[x] (optional) I am willing to help maintain this change if there are issues with it later.

Thanks~


Fix-#795 No Scoll Behaviour on Overflow

Fix- #795
Change- Made Changes in BaseModal Css, hid the scrollbar for good looking UI and Made the Header and Footer Sticky for good UX

Extremely fast, thank you for the fix! 🔥

Extremely fast, thank you for the fix! 🔥

Pleasure is all mine. Loving this!


Dev

It looks like you are still using handlebars. Is there a reason for this?

No, was old code, removed it


Update axes on example Envoy latency graphs to match metric

Fixes #1207

Thanks for this PR, @mwhittington21! Could you please sign your commit and repush? The easiest way is to run: git commit --amend  --signoff

git commit --amend -s && git push -f should do it @mwhittington21

Rebased and signed!


Don't compile tests with make

Is it possible to modify the cmake files to avoid the compilation of the tests when only "make" is used?

+1

On Tue, May 10, 2016 at 01:09:34AM -0700, Carlos Aguilar Melchor wrote:

+1

I'll have a look at it

See #15

Thanks!


Revert handling of template exceptions when generating indexable content

Description
Trello card: https://trello.com/c/W7EDHYFB
This PR (mostly) reverts this commit. Note, however,  that I have not reverted the introduction of IndexableContentTest, because it's still a useful test to make sure we don't introduce any more code which results in raising exceptions.
The reverted commit was originally introduced so that we could generate indexable_content for the outcome_os_other_countries outcome in marriage-abroad. We had to add this special case to handle the potential exception raised by the outcome.
This later pull request updates the outcome_os_other_countries outcome such that it no longer raises an exception, which means that we can simplify the code by reverting the commit mentioned above.
However, in the meantime there have been some other changes which also cause template exceptions to be raised. Initially I was thinking that I might just not bother implementing the idea in this card, but then I realised there's a danger that we may unknowingly keep introducing problematic code thereby reducing the indexable content that we can generate.
To this end, all of the commits in this PR except for the last one fix place where template exceptions were being raised during the generation of indexable content. Once all of these were applied, I was able to do revert the commit as planned.
External changes
It's likely that the changes in this PR will mean that more indexable content is supplied to Panopticon (and thence Rummager?) for the flows in which template exceptions were previously being raised (register-a-birth, register-a-death & marriage-abroad). However, there's no easy way to test this directly and in any case such changes are very low risk.

Rebased against master to resolve conflicts and force-pushed. Ready for review.

Commit: "Add MethodMissingObject#to_str" (6fd4263202e503a32129152a833e49974ae8d659)
Is there a reason you didn't test this alias?

Commit: "Allow custom return value for MethodMissingObject#to_s" (b6299034d23bba5939ed1c45f293786c31844894)
Is there a reason you didn't test this change in behaviour?

Commit: "Extract oru_documents_variant_for_death? method in RegistrationsDataQuery" (30a63db3a455295abad9f433367f51d6a144d1b2)
The test context name (oru_documents_variant_for_birth?) doesn't match the method being tested (oru_documents_variant_for_death?).

How did you work out that you needed to make the changes you've made in commits 1 to 8 (i.e. all but the final revert commit)? By removing the error handling in FlowRegistrationPresenter#indexable_content and then running the indexable_content_test?

I'm holding off adding the LGTM label until @floehopper has chance to respond to my questions.

Commit: "Add MethodMissingObject#to_str" (6fd4263202e503a32129152a833e49974ae8d659)
Is there a reason you didn't test this alias?

Commit: "Allow custom return value for MethodMissingObject#to_s" (b6299034d23bba5939ed1c45f293786c31844894)
Is there a reason you didn't test this change in behaviour?

I think it was because there weren't any unit tests for MethodMissingObject and I felt as if they were small changes that were covered by the IndexableContentTest. That and me being lazy, obviously! 😄

Commit: "Extract oru_documents_variant_for_death? method in RegistrationsDataQuery" (30a63db3a455295abad9f433367f51d6a144d1b2)
The test context name (oru_documents_variant_for_birth?) doesn't match the method being tested (oru_documents_variant_for_death?).

Thanks. Well spotted. I will fix this.

How did you work out that you needed to make the changes you've made in commits 1 to 8 (i.e. all but the final revert commit)? By removing the error handling in FlowRegistrationPresenter#indexable_content and then running the indexable_content_test?

Yes. That's exactly what I did. In fact I reverted the commit, then wrote commits to fix the problems, and finally reordered the commits to put the revert last. I'll explain that somewhere in a commit note or the PR description.

Superseded by #2565. Closing.

In the new version of this PR (#2565) I've added a new commit which introduces a unit test for MethodMissingObject (af46c0e9fbb0fcef09b418a0b0d8bc4a51aed4e8)

Commit: "Add MethodMissingObject#to_str" (6fd4263202e503a32129152a833e49974ae8d659)
Is there a reason you didn't test this alias?

In the new PR, I've added unit tests for this change (3bf979f4c93a05de2589968a8538605e250f3a63)

Commit: "Allow custom return value for MethodMissingObject#to_s" (b6299034d23bba5939ed1c45f293786c31844894)
Is there a reason you didn't test this change in behaviour?

In the new PR, I've added unit tests for this change (d47a50b776d97b270e3b7bf6ebd15bd69ff54278)

How did you work out that you needed to make the changes you've made in commits 1 to 8 (i.e. all but the final revert commit)? By removing the error handling in FlowRegistrationPresenter#indexable_content and then running the indexable_content_test?

I've added a paragraph towards the end of the new PR (#2565) description which hopefully explains this a bit more.

I've added a comment on #2565 to say that all the changes look good.


Various bug fixes and codestyle improvements

Fixed shebang in Makefile to work properly
Take advantage of GNU Make's automatic variables
Use an anonymous enum for token constants ("more extensible" - really just less verbose)
Use uintptr_t for INSTRUCTION_IDX since uint64_t isn't guaranteed to be the size of a pointer
Change INSTRUCTION_IDX to be a typedef - avoid unhygienic macro usage where possible!

Thank you for the PR! Was able to learn quite a bit from just reading the changes and comments.


Roll engine 195425e04480..400e3b00fb4c (8 commits)

git@github.com:flutter/engine.git/compare/195425e04480...400e3b00fb4c
git log 195425e04480..400e3b00fb4c --no-merges --oneline
2019-10-23<EMAIL_ADDRESS>Wires the locale provided by Fuchsia. (flutter/engine#13045)
2019-10-23<EMAIL_ADDRESS>Add FlutterEngineRunsAOTCompiledDartCode to the embedder API. (flutter/engine#13319)
2019-10-23<EMAIL_ADDRESS>[web] [test] Adding firefox install functionality to the test platform (flutter/engine#13272)
2019-10-23<EMAIL_ADDRESS>Roll src/third_party/skia 32803ff74448..6863bb0930cf (7 commits) (flutter/engine#13318)
2019-10-23<EMAIL_ADDRESS>Roll src/third_party/dart 5fd6c8a3c1..b359ac0a1e (2 commits)
2019-10-23<EMAIL_ADDRESS>[recipe] Upload opt flutter_tester (flutter/engine#13311)
2019-10-23<EMAIL_ADDRESS>Update the dependencies for the Fuchsia build of flutter_frontend_server (flutter/engine#13316)
2019-10-23<EMAIL_ADDRESS>NO_SUGGESTIONS keyboard flag in Android (flutter/engine#13099)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Auto-roller completed checks. About to merge.


Fix "popd: not found" by switching from dash to bash as sh

Hi,
Would you be open to change from dash to bash so srcds_run runs without warnings like this?
/server/srcds_run: 32: /server/srcds_run: pushd: not found
/server/srcds_run: 35: /server/srcds_run: popd: not found

For example by doing something like this:
RUN cp /bin/bash /bin/sh

Or a more sophisticated version:
# make /bin/sh symlink to bash instead of dash:
RUN echo "dash dash/sh boolean false" | debconf-set-selections
RUN DEBIAN_FRONTEND=noninteractive dpkg-reconfigure dash

https://superuser.com/questions/715722/how-to-do-dpkg-reconfigure-dash-as-bash-automatically/1064247#1064247

Do you find the errors affecting behavior of the server in any way? Source games tend to spit out a lot errors but that often do not pose issues with functionality. If it is a major issue, perhaps we'll consider adding that into the build Dockerfile.

@MPV We can resolve the /bin/sh to /bin/bash mapping, since /bin/sh has quirks in ubuntu such as exec not working as expected.
Is there any particular reason for to use srcds_run wrapper, instead of directly calling the srcds_linux binary directly? If we don't use the wrapper script then simply skip over any of its associated quirks and its incompatibility with containerization.

Thanks, I tried again now using srcds_linux and finally got it working properly.
I'm setting it up to run using Kubernetes, and when I had tried to send arguments to srcds_run/linux using multiple lines which I didn't get to work, but now adding them to the same line I got it to work well.
Closing this, now agreeing with your reasoning and recommendation on srcds_linux over srcds_run.
Thanks for taking your time to help and share.


Update README.md

This PR corrects ta typo in the main README.md

Submission type

[x] This submission fixes a bug (link to related issue: )
[ ] This submission adds a new feature not listed above

Submission guidelines

[x] This submission follows the guidelines in our Contributing document
[x] I have checked to ensure there aren't other open Pull Requests for the same update/change

Codecov Report

Merging #245 (884790f) into master (bbb9313) will decrease coverage by 0.09%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #245      +/-   ##
==========================================
- Coverage   95.92%   95.82%   -0.10%
==========================================
  Files          68       68
  Lines        1399     1366      -33
  Branches       85       85
==========================================
- Hits         1342     1309      -33
  Misses         29       29
  Partials       28       28

Flag
Coverage Δ

unittests
95.82% <ø> (-0.10%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...s/tasks/multimodal_data_integration/metrics/mse.py
81.25% <0.00%> (-1.11%)
:arrow_down:

openproblems/patch.py
96.87% <0.00%> (-0.19%)
:arrow_down:

openproblems/data/utils.py
96.42% <0.00%> (-0.07%)
:arrow_down:

openproblems/tools/normalize.py
100.00% <0.00%> (ø)

openproblems/tools/decorators.py
100.00% <0.00%> (ø)

openproblems/tasks/denoising/metrics/mse.py
100.00% <0.00%> (ø)

openproblems/tasks/denoising/methods/magic.py
100.00% <0.00%> (ø)

openproblems/tasks/denoising/metrics/poisson.py
100.00% <0.00%> (ø)

openproblems/tasks/label_projection/metrics/f1.py
100.00% <0.00%> (ø)

openproblems/tasks/label_projection/methods/mlp.py
100.00% <0.00%> (ø)

... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbb9313...884790f. Read the comment docs.


incorrect initialization of static member with const

A description of the issue.
Steps To Reproduce
https://deck.net/fc744eb3d41d006b41236e739756264b
https://dotnetfiddle.net/fzrxK6
public class Program
{
    public static void Main()
    {
        var msg = c2.p2.p1;

        Console.WriteLine(msg);
    }
}

public class c1
{
    public string p1 {get; set; }
}

public class c2
{
    private static c1 _s = _init();

    private static c1 _init()
    {
        c1 o1 = new c1
        {
            p1 = Z1
            //works: p1 = "A"
        };

        return o1;
    }

    public static c1 p2 { get { return _s; }}

    public string p3 {get; set; }

    public const string Z1 = "A";
}

Expected Result
'A'

Actual Result
null

note: replacing constant with literal works, since constant is initialized after static member initialization, what is wrong

Fixed! Will make it to the next Bridge release (see attached milestone).


cursor should follow the reference in peek view when set "editor.peekWidgetDefaultFocus": "editor"

Version: 1.49.0 (user setup)
Commit: e790b931385d72cf5669fcefc51cdf65990efa5d
Date: 2020-09-10T13:22:08.892Z
Electron: 9.2.1
Chrome: 83.0.4103.122
Node.js: 12.14.1
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.19041

Steps to Reproduce:

set "editor.peekWidgetDefaultFocus": "editor"
right click and select Go to references
select another reference item
the cursor just disappear, but I think should move to the current reference

Does this issue occur when all extensions are disabled?: Yes/No
Yes

select another reference item

And then? You didn't write what you expect to happen and what actually happens

select another reference item

And then? You didn't write what you expect to happen and what actually happens

Sorry, I  have add the 4th step to reproduce.

the cursor just disappear, but I think should move to the current reference

No, it cannot do that automatically because then keyboard navigation in the tree would be broken. There is the togglePeekWidgetFocus-command (cmd+k f2) to toggle focus between the two sides.


Waiting after SIGINT even though no connection is open

Hi,
I am using graceful with Negroni:
package main

import (
    // Stdlib
    "flag"
    "time"

    // Vendor
    "github.com/codegangsta/negroni"
    "gopkg.in/tylerb/graceful.v1"
)

func main() {
    flagAddress := flag.String("addr", ":3000", "network address")

    n := negroni.Classic()
    graceful.Run(*flagAddress, 10*time.Second, n)
}

It just serves index.html from the public folder.
Now, for some reason, when I send SIGINT to the server, it waits for 10 seconds even though there is no active connection. Is that the desired behaviour? I was thinking that it would just exit when there are no pending requests...
$ make run
[negroni] Started GET /
[negroni] Completed 200 OK in 36.588592ms
[negroni] Started GET /favicon.ico
[negroni] Completed 0  in 33.599µs
^C
(10 seconds)
$

It is simply a case that has never been addressed. It makes sense to exit immediately if no connections are open, though.

Ah, right :-)

So, do you feel like implementing it or shall I try to dig into the code?

Interesting. This case is handled at https://github.com/tylerb/graceful/blob/master/graceful.go#L244. It should return immediately if no connections are present. Care to debug it?

Don't really have time right now, but I will take a look let's say tomorrow.

It's doing keepalive I guess.
$ make run
[negroni] Started GET /
[negroni] Completed 200 OK in 5.364411ms
[negroni] Started GET /bootstrap-3.3.4-dist/css/bootstrap.css
[negroni] Completed 200 OK in 290.399µs
[negroni] Started GET /bootstrap-3.3.4-dist/js/bootstrap.js
[negroni] Completed 200 OK in 178.651µs
[negroni] Started GET /js/jquery-2.1.4.js
[negroni] Completed 200 OK in 341.359µs
[negroni] Started GET /bootstrap-3.3.4-dist/css/bootstrap-theme.css
[negroni] Completed 200 OK in 177.584µs
[negroni] Started GET /bootstrap-3.3.4-dist/css/bootstrap-theme.css.map
[negroni] Completed 200 OK in 354.736µs
[negroni] Started GET /bootstrap-3.3.4-dist/css/bootstrap.css.map
[negroni] Completed 200 OK in 2.139425ms
[negroni] Started GET /favicon.ico
[negroni] Completed 0  in 20.705µs
^Clen(connections) = 6

That would do it. :)

:facepalm: :-)


feature request: choosing statefulSet instead of deployment

Hello!
Please add the ability to choose statefulset instead of deployment.
if you can :)
UPD:
for workers
I need VolumeClaimTemplates

This is needed to store cache and spills when deploying the chart to the cloud.
It should be easy to add a switch from deployment to statefulset.
You can take all the configuration from the deployment, and add the switch (in valuess) to the deployment section
in templates it is 2 if conditions
1 for kind
2 for volumeClaimTemplates
3 for volumeMounts
or add a separate template with a small modification.
Translated with DeepL.com (free version)

Isn't cache and spills ephemeral? Why would you need to bind it to specific pods?
Are you interested in contributing this?

We can't use any code you write if you don't sign the CLA.
The docs say to use a separate disk device to avoid saturating the IO, it doesn't mention anything about reusing the same spilled or cached data after a node restarts.
You should still be able to use automatically provisioned volumes with deployments, and make sure you have some policy to clean up unused ones.

I am not sure about the motivation for this change. It works perfectly fine to use spilling (not recommended but nevertheless) or file system caching as it stands now. What would the change to statefulSet actually fix or improve.

Hi!
We are assuming cache + spills to be 200+ GB.
Kubernetes node volume is simply not enough in a normal configuration.
I will prepare a PR if you are willing to consider it.
I also apologize for my English :)

what do you think?

You don't need StatefulSets for generic ephemeral volumes: https://kubernetes.io/docs/concepts/storage/ephemeral-volumes/#generic-ephemeral-volumes


Keyboard Lockout

Issue: Player is locked out of the keyboard. You cannot use any keys except ` (console) unless they use a different wire_keyboard or leave the server.
How to reproduce:
Enable synchronous
Bind leave keyboard to Use (e)
Wire "Kick the bastard out of the keyboard" to "InUse"
Use (e) they keyboard

Well, I checked the bug with workshop version of Wiremod and I got exactly same results. Maybe the workaround is to not allow the player to bind the keyboard leaving key to key bound to +use or add the delay for the "Kick the bastard out of the keyboard" to at least 1/100th of a second. The exact line for synchronous wire keyboard is here: https://github.com/wiremod/wire/blob/master/lua/entities/gmod_wire_keyboard/init.lua#L88
It's probably caused by race condition I think.

merged


Update Module for Foundry VTT v11 Compatibility

Dear maintainer,
Could you please update the module to be compatible with Foundry VTT v11? It would greatly enhance our gaming experience and allow us to continue using this wonderful tool. Thank you in advance for your support.

Yes, This is a amazing product that lets us do so much that can't be done any other way.

I’ll make sure to get some free time to update it. I’ll have to relearn Foundry, and I’ll probably rewrite the entire module from scratch.  So I can’t give you a time frame for when it will be done.

Yes , is my favorite module to foundry.

For anyone else who is looking for similar functionality, the Inline Webviewer module can also create HTML scenes and it works with v11!

any news for update to v12?

I just updated Foundry VTT to v12 and now html-to-scene doesn't work anymore.
Help

Here a fix : https://github.com/Javiondox/html-to-scene/pull/24


perf: refactor interpreter internals (take 2)

Split off from (and supersedes) #558, see that PR for benches and list of changes.
Best reviewed on a commit-by-commit basis.
Results
Cachegrind

download cachegrind.tar.gz, extracts into crates/cachegrind
run:

cargo b -r -p revm-cachegrind --bin snailtracer
valgrind --tool=cachegrind target/release/snailtracer

Commit
Snailtracer (I)
Improvement

449d6b99ce19c51900782db1c4ea2b9c1c8a5199 (main)
505,445,058
N/A

b3440b1f83fd08c3c067be57bf0f0c58dfc79b02
441,772,332
-12.6%

Marking as draft until the other PRs are merged, so I can then rebase on top of main.

@DaniPopes added mostly nits, moved all instructions to be public as that can be useful, and added some small changes.
very nice PR!


POC Module Registry / Listing: One-Way Sync of ModuleTemplateList into SKR

To enable Introspection of all available Modules we want to make sure that we offer a convenient way to know which modules can be installed within SKR. For this we want to enable a synchronization that is write-only copying any active ModuleTemplateCR in the KCP into the runtime cluster. That way Busola as well as CLI and other independant toolings can use it for introspection and coding things like value-help or discovery toolings.
Trade-Offs:

A change or newly introduced / changed / deleted module-template can potentially lead to devastating control-loops and we will have to consider this feature performance-relevant.
There is no way to currently determine if the ModuleTemplate has been maliciously changed in the cluster between reconciliations

AC

[x]  All ModuleTemplates in Cluster are synced into SKR
[x] Any change of ModuleTemplates in SKR are ignored
[x] Any ModuleTemplate change in Control-Plane is reconciled into SKR
[x] Module-Template Synchronization is done in a separate Control-Loop to avoid cluttering the Kyma-Operator Control-Loop
[x] A deleted Module Template needs to be removed from all SKRs
[x] We should include a flag to disable this synchronization in case it turns out to be too demanding for big control-planes (see trade-off above)
[x] In Local Mode we also should create that list but not into SKR

Developer Notes:

Control Loop will need to synchronize based on Kyma (Watches Kyma CR) and will need to list all module-templates and reconcile them.
Control Loop will need a change handler for new / changed module templates and will need to write them into the SKR on change.
There should be a reasonable but not too inefficient time interval for refreshing the module templates of the remote clusters

As part of trade-offs a change module template should ideally not affect the list of available module on SKR right?
For sycning newly created / deleted templates as a stable solution we could think of updating module list on SKR on a KCP Kyma re-queue. It's not going to be immediate, but it will happen at some point? Question is how soon do we want to update the SKR modules list.

While I agree we could requeue, for me it is the same as introducing a new control loop for module templates that continously syncs the resources

Quick Update: Ideally we want to make the available Modules in SKR immutable. In this case it might make sense to change the AC to instead contain a validated CR that resolves all available ModuleTemplates or use an API that offers these information freely into the SKR as by suggestion of @ruanxin

The CLI will also need to include an interface to make this accessible, maybe @clebs you can read through this issue and see if there are any ideas on how to nicely integrate listing / adding / removing modules

We should also create that list if we are in local mode

Implementation of https://github.com/kyma-project/kyma-operator/pull/103 still pending

Implementation of #112 is covering the switch to local in case the "sync.remote" flag is set to false

Waiting on Confirmation Meeting with @valentinvieriu

Meeting Outcome:

Busola will provide preintegrated Module Dashboards that will be delivered with the modules. For this the CLI scaffolding probably needs to be extended in the Layering Engine with a new Default layer if its found (@clebs)
We will stick with the current approach, but transition to a kubernetes style API definition (with GVK) in case we want to switch from config maps to direct CR creation later on, for now we stick we ConfigMaps as its much more performant.


Ingress-azure container won't start - AZURE_AUTH_LOCATION error

Describe the bug
When I create the helm templates with the service principal option (not aad-pod-identity) when the container starts up it reports the following error:
I0206 12:30:59.179672       1 main.go:63] Creating authorizer from file referenced by AZURE_AUTH_LOCATION
F0206 12:30:59.179815       1 main.go:68] Error creating Azure client from config: invalid character 'c' looking for beginning of value
One suggest would be to provide clearer instructions on how to setup service principal configuration, you only have it for aad-pod-identity it seems in your docs.
To Reproduce
Setup a service principal in Azure and created an associated secret in AKS cluster using the following YAML:
apiVersion: v1
kind: Secret
metadata:
name: networking-appgw-k8s-azure-service-principal
type: Opaque
data:
username: removed
password: removed
I then use the following helm values configuration for the service principal:
armAuth:
type: servicePrincipal
secretName: networking-appgw-k8s-azure-service-principal
secretKey: password
Ingress Controller details
Pod describe
Name:               *****************
Namespace:          default
Priority:           0
PriorityClassName:
Node:               **********************
Start Time:         Wed, 06 Feb 2019 12:43:22 +0000
Labels:             app=ingress-azure
pod-template-hash=2740828966
release=release-name
Annotations:
Status:             Running
IP:                 <IP_ADDRESS>
Controlled By:      ReplicaSet/release-name-ingress-azure-6c84d6dfbb
Containers:
ingress-azure:
Container ID:   docker://d78c07da94becbe167e1942cd5c29afb75d2457ea123214a3db4f05e15aa9193
Image:          mcr.microsoft.com/azure-application-gateway/kubernetes-ingress:0.1.4
Image ID:       docker-pullable://mcr.microsoft.com/azure-application-gateway/kubernetes-ingress@sha256:b996e8d9812d4d92cf55d2b02fe8f404352b08e137757c4b8d8dabd11fb1901b
Port:
Host Port:
State:          Waiting
Reason:       CrashLoopBackOff
Last State:     Terminated
Reason:       Error
Exit Code:    255
Started:      Wed, 06 Feb 2019 13:50:20 +0000
Finished:     Wed, 06 Feb 2019 13:50:20 +0000
Ready:          False
Restart Count:  18
Environment Variables from:
release-name-cm-ingress-azure  ConfigMap  Optional: false
Environment:
AZURE_AUTH_LOCATION:           /etc/Azure/Networking-AppGW/auth/password
KUBERNETES_PORT_443_TCP_ADDR:
KUBERNETES_PORT:
KUBERNETES_PORT_443_TCP:
KUBERNETES_SERVICE_HOST:
Mounts:
/etc/Azure/Networking-AppGW/auth from networking-appgw-k8s-azure-service-principal-mount (ro)
/var/run/secrets/kubernetes.io/serviceaccount from release-name-sa-ingress-azure-token-mmsvd (ro)
Conditions:
Type              Status
Initialized       True
Ready             False
ContainersReady   False
PodScheduled      True
Volumes:
networking-appgw-k8s-azure-service-principal-mount:
Type:        Secret (a volume populated by a Secret)
SecretName:  networking-appgw-k8s-azure-service-principal
Optional:    false
release-name-sa-ingress-azure-token-mmsvd:
Type:        Secret (a volume populated by a Secret)
SecretName:  release-name-sa-ingress-azure-token-mmsvd
Optional:    false
QoS Class:       BestEffort
Node-Selectors:
Tolerations:     node.kubernetes.io/not-ready:NoExecute for 300s
node.kubernetes.io/unreachable:NoExecute for 300s
Events:
Type     Reason   Age                From                               Message

Warning  BackOff  2m (x296 over 1h)  kubelet,   Back-off restarting failed container
Pod logs (are posted above in the bug description)

@dan-jackson-github the reason we don't have documentation for using service principal directly, with using the AAD-POD-IDENTITY integration for using MSI, was that the support service principal was introduced primarily to support development activities. Is there a specific reason you need to use the service princiapl and not an MSI to access the AG?

hi @asridharan thanks for the response. The reason is I would like to keep the k8s configuration as minimal as possible, introducing aad-pod-identity introduces more complexity and another point of failure, it seems the only thing that is going to use it in my AKS implementation is this ingress controller. I prefer to use service principal approach because that keeps my configuration consistent. I also have no experience with aad-pod-identity, have never seen or supported it before!
What is the reason that service principal support is only intended for development? It seems to be a standard approach in AKS for other areas such as load balancer services, storage access and container registry access. Are we saying you don't recommend this approach for productive use? Is it not secure?

Was this ever answered or set as a supported approach? I also do not understand why a service principal would only be used for development. It's pretty common practice to prefer service principals over MSI in Azure.


Installing on Windows 2016 fails because of TLS versions

When trying to install uv in our CI env I noticed that Windows 2016 boxes failed to download
the install script because of Could not create SSL/TLS secure channel. Later Windows versions were fine.
I worked around it with:
[Net.ServicePointManager]::SecurityProtocol = [Net.SecurityProtocolType]::Tls12;
irm https://astral.sh/uv/install.ps1 | iex

Perhaphs it'd be good to add it to the docs?

We explicitly pass --tlsv1.2 to curl for the shell installer already, so that seems supremely reasonable for the powershell installer to set too.

Could you confirm for me that this expression works on your windows server?
irm -SslProtocol Tls12 https://astral.sh/uv/install.ps1 | iex

(It's probable once the script downloads it will then error trying to fetch the actual binaries, but that's easier to fix than the raw irm | iex)

Unfortunately not:


AnimatedSwitcher with conditional render problem

Steps to Reproduce

write code using AnimatedSwitcher with conditional render like the following snippets

                        /// TabBarContent
                        AnimatedSwitcher(
                          duration: Duration(milliseconds: 400),
                          child: [
                            CourseDetailsIntroduce(
                                key: ValueKey<String>("details_introduce"),
                                course: course),
                            CourseDetailsComment(
                                key: ValueKey<String>("details_comment"))
                          ][_tabController.index],
                        ),

The child content of the AnimatedSwitcher is different height, the first one is higher then the second one.
When switch from tab1 to tab2, then you can see the content of tab2 is appear from bottom to top, not hold its original position.

Expected results:
The content of tab is no moving horizontally.
Actual results:
see the following gif.

Without seeing anymore code, we cannot deduce what the problem is. However, this doesn't look like a bug with flutter, but with your app ui code.

Hi @liudonghua123
can you please provide your flutter doctor -v and flutter run --verbose?
Also, to better address the issue, would be helpful if you could post a minimal code sample to reproduce the problem
Thank you

@TahaTesser @joekendal Thanks for interesting in this issue, I write a small demo to demonstrate this issue, see https://dartpad.cn/1af2ade4cde5ed5862b8481fe5b89d32 or http://dartpad.dev/1af2ade4cde5ed5862b8481fe5b89d32.
This problem exists in web platform (dartpad) too.

Here is my flutter doctor output.
D:\code\flutter\flutter_chips_input>flutter doctor -v
[✓] Flutter (Channel unknown, v1.18.0-7.0.pre.1, on Microsoft Windows [Version
    10.0.18363.778], locale en-US)
    • Flutter version 1.18.0-7.0.pre.1 at D:\apps\flutter
    • Framework revision 3495ba76c4 (6 days ago), 2020-04-21 15:42:33 +0800
    • Engine revision 2bde4f0ae4
    • Dart version 2.9.0 (build 2.9.0-1.0.dev a12c36dd97)

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
    • Android SDK at D:\apps\android_sdk
    • Platform android-29, build-tools 29.0.2
    • ANDROID_HOME = D:\apps\android_sdk
    • Java binary at: D:\apps\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b04)
    • All Android licenses accepted.

[✓] Chrome - develop for the web
    • Chrome at C:\Program Files (x86)\Google\Chrome\Application\chrome.exe

[✓] Visual Studio - develop for Windows (Visual Studio Community 2019 16.5.4)
    • Visual Studio at C:\Program Files (x86)\Microsoft Visual Studio\2019\Community
    • Visual Studio Community 2019 version 16.5.30011.22

[✓] Android Studio (version 3.6)
    • Android Studio at D:\apps\Android Studio
    • Flutter plugin version 45.1.1
    • Dart plugin version 192.7761
    • Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b04)

[✓] VS Code, 64-bit edition (version 1.44.2)
    • VS Code at C:\Program Files\Microsoft VS Code
    • Flutter extension version 3.9.1

[✓] Connected device (4 available)
    • Android SDK built for x86 64 • emulator-5554 • android-x64    • Android 10 (API 29)
      (emulator)
    • Windows                      • Windows       • windows-x64    • Microsoft Windows
      [Version 10.0.18363.778]
    • Chrome                       • chrome        • web-javascript • Google Chrome
      81.0.4044.122
    • Web Server                   • web-server    • web-javascript • Flutter Tools

• No issues found!

D:\code\flutter\flutter_chips_input>

Hi @liudonghua123
Do would be solved by implementing #48217 this?

@TahaTesser Hi, I tried to use IndexedStack with AnimatedSwitcher, it did not have this problem, however using IndexedStack will case another problem, the height of IndexedStack will always use the maxium height of the children. If I navigate to a tight height tab, then there will some blank spaces below it. see https://github.com/flutter/flutter/issues/55464 for more details. So I dropped this solution.
The first version of code is write using TabBar and TabBarView, but using TabBarView will case not have size problem. Because I need to use TabBarView in a Column, the children of TabBarView is dynamic height, I can't give a specified height to the TabBarView. see https://github.com/flutter/flutter/issues/54968 for more details.
For the demo code, I can make it work expected by wrapping the conditional rendering child with Container, but this fix will not work for mine own code. I think if the key reasons found or bugs fixed for the demo code, then mine code will work too.

For me, the best solution is to use TabBar and TabBarView, and make TabBarView to fit the children's height ,like the Wrap widget does.
In this way, the logic is clear, and the switch animation is also fit my designs.

For me, the best solution is to use TabBar and TabBarView, and make TabBarView to fit the children's height ,like the Wrap widget does.
In this way, the logic is clear, and the switch animation is also fit my designs.

@liudonghua123
Do you have a clear solution for this issue?
I'm stuck in this situation as you did before.

@ChickenAhn Currently, I do not have a perfect solution, I use the code mentioned in the issue.

@liudonghua123, @ChickenAhn
Had the same issue today
The "problem" is the alignment (center) if previous widget and current widget have different heights.
By default, AnimatedSwitcher uses this method to layout both widget:
static Widget defaultLayoutBuilder(Widget currentChild, List<Widget> previousChildren) {
    return Stack(
      children: <Widget>[
        ...previousChildren,
        if (currentChild != null) currentChild,
      ],
      alignment: Alignment.center,
    );
  }

My Solution is just to adjust this by layoutBuilder:
              AnimatedSwitcher(
                  layoutBuilder: (Widget currentChild, List<Widget> previousChildren) {
                    return Stack(
                      children: <Widget>[
                        ...previousChildren,
                        if (currentChild != null) currentChild,
                      ],
                      alignment: Alignment.topCenter,
                    );
                  },
              child: (...)

@moodstubos, Thanks for the workable solution.  😄

@liudonghua123 Have you achieved swipe animation with the AnimatedSwitcher approach?
Or any other elegant solution you can propose?

@chakrihacker Hi, I did not achieve the same swipe animation with the AnimatedSwitcher compare to the TabView animation.

How about using my package? https://pub.dev/packages/animated_indexed_stack


Scala.js artifacts are not published

Scala.js artifacts are not published due to some configuration error that results in the following:
java.lang.RuntimeException: error uploading to
 https://api.bintray.com/maven/noelwelsh/maven/maven/underscoreio/doodle_sjs0.6_2.11
 /a78e60eee4873ec2328fe748f49023226c98635d-SNAPSHOT/doodle_sjs0.6_2.11-
 a78e60eee4873ec2328fe748f49023226c98635d-SNAPSHOT.pom:
{"message":"Provided artifact path does not comply with Maven's convention"}

(Manual line breaks added for readability above.)
Somebody with too much time on their hands needs to dig into the build to work out what is going wrong.

This is fixed in the 0.6.x series.


_wireguard_config.py assumes sysconfdir=/etc

Merely running make install is more or less guaranteed to generate a broken package, because prefix ?= /usr/local and sysconfdir ?= $(prefix)/etc, i.e. by default, $(sysconfdir) expands to /usr/local/etc. But _wireguard_config.py explicitly refers to a path under /etc, which will fail unless sysconfdir=etc.
Technically I suppose this qualifies as technical debt, since the ipks work, and if you follow the instructions in the README to the letter, it will work too. Still.

The core of this issue is really that the Makefile installs wireguard configuration files to ${DESTDIR}${sysconfdir}/wireguard and ${DESTDIR}${sysconfdir}/init.d, despite neither wireguard-tools nor sysvinit searching any conf directories other than /etc. So the installation paths in the Makefile should just be changed over to ${DESTDIR}/etc/wireguard (or similar for init.d).


Alias/rename old_data_on_error to stale_if_error for consistency with Cache-Control: stale-if-error (backwards-compatibile)

Coverage remained the same at 99.496% when pulling 061936bcb3200b55efed0f3cd2e977534b4fef7f on JWCook:stale-if-error into e36e851716c35877fc373440a8f0c96669aeb082 on reclosedev:master.


[GCKSSecurityCertificate initWithData:] crash

Hi, we're experiencing the below crash. Please assist.
Crashed: com.apple.main-thread
0  CoreFoundation                 0x1852bb2a0 CFRelease + 120
1  GoogleCast                     0x1007f5168 -[GCKSSecurityCertificate dealloc] + 36
2  GoogleCast                     0x1007f50ac -[GCKSSecurityCertificate initWithData:] + 116
3  GoogleCast                     0x100731288 -[GCKCertificateVerifier verifyCertificate:withPeerTrust:error:] + 312
4  GoogleCast                     0x10073fdd8 -[GCKDeviceAuthChannel didReceiveBinaryMessage:] + 1388
5  GoogleCast                     0x100716540 -[GCKCastDeviceConnector castMessageDesegmenter:didProduceBinaryMessage:withNamespace:destinationID:] + 136
6  GoogleCast                     0x100728448 -[GCKCastMessageDesegmenter notifyDidProduceBinaryMessage:withNamespace:destinationID:] + 128
7  GoogleCast                     0x1007282a0 -[GCKCastMessageDesegmenter consumeChunk:] + 1428
8  GoogleCast                     0x100716980 -[GCKCastDeviceConnector castSocket:didReceiveMessage:] + 108
9  GoogleCast                     0x100730ab0 __41-[GCKCastSocket notifyDidReceiveMessage:]_block_invoke + 120
10 libdispatch.dylib              0x18429a9e0 _dispatch_call_block_and_release + 24
11 libdispatch.dylib              0x18429a9a0 _dispatch_client_callout + 16
12 libdispatch.dylib              0x18429f5e8 _dispatch_main_queue_callback_4CF + 996
13 CoreFoundation                 0x1853910c8 __CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE__ + 12
14 CoreFoundation                 0x18538ece4 __CFRunLoopRun + 1572
15 CoreFoundation                 0x1852beda4 CFRunLoopRunSpecific + 424
16 GraphicsServices               0x186d28074 GSEventRunModal + 100
17 UIKit                          0x18b572058 UIApplicationMain + 208
18 MyApp                        0x1000639d0 main (main.swift:6)
19 libdyld.dylib                  0x1842cd59c start + 4

We get the same crash. Any progress on this?

Please file a bug with a complete log: https://issuetracker.google.com/issues?q=componentid:190205 status:open&s=modified_time:desc


backend: fix is_available in gdrive tool

Noticed that we're checking CLIENT_ID is None twice instead of also checking CLIENT_SECRET
AI Description

This pull request updates the is_available method in the GoogleDrive class of tool.py.
Summary
The is_available class method now checks for the presence of both CLIENT_ID and CLIENT_SECRET to determine availability, whereas previously, it only checked for CLIENT_ID twice.
Changes

Updates the is_available class method in GoogleDrive class to check for CLIENT_SECRET.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (main@a332c51). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #672   +/-   ##
=======================================
  Coverage        ?   76.25%
=======================================
  Files           ?      238
  Lines           ?    10591
  Branches        ?        0
=======================================
  Hits            ?     8076
  Misses          ?     2515
  Partials        ?        0

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


CMake Error: Internal CMake error, TryCompile configure of cmake failed

Hello,
I want to compile libnabo. I have used VS 2010 in win32. When I run CMake I have this error

The C compiler identification is MSVC 16.0.40219.1
The CXX compiler identification is MSVC 16.0.40219.1
Check for working C compiler: C:/Program Files/Microsoft Visual Studio 10.0/VC/bin/cl.exe
Check for working C compiler: C:/Program Files/Microsoft Visual Studio 10.0/VC/bin/cl.exe -- works
Detecting C compiler ABI info
Detecting C compiler ABI info - done
Check for working CXX compiler: C:/Program Files/Microsoft Visual Studio 10.0/VC/bin/cl.exe
Check for working CXX compiler: C:/Program Files/Microsoft Visual Studio 10.0/VC/bin/cl.exe -- works
Detecting CXX compiler ABI info
Detecting CXX compiler ABI info - done
Detecting CXX compile features
Detecting CXX compile features - done
Could NOT find Doxygen (missing:  DOXYGEN_EXECUTABLE)
Boost version: 1.49.0
CMake Warning (dev) at C:/Users/ACER/Downloads/cmake-3.7.1-win32-x86/cmake-3.7.1-win32-x86/share/cmake-3.7/Modules/FindOpenMP.cmake:179 (if):
if given arguments:
"TRUE"

An argument named "TRUE" appears in a conditional statement.  Policy
CMP0012 is not set: if() recognizes numbers and boolean constants.  Run
"cmake --help-policy CMP0012" for policy details.  Use the cmake_policy
command to set the policy and suppress this warning.
Call Stack (most recent call first):
C:/Users/ACER/Downloads/cmake-3.7.1-win32-x86/cmake-3.7.1-win32-x86/share/cmake-3.7/Modules/FindOpenMP.cmake:224 (_OPENMP_GET_SPEC_DATE)
CMakeLists.txt:54 (find_package)
This warning is for project developers.  Use -Wno-dev to suppress it.
CMake Warning (dev) at C:/Users/ACER/Downloads/cmake-3.7.1-win32-x86/cmake-3.7.1-win32-x86/share/cmake-3.7/Modules/FindOpenMP.cmake:179 (if):
if given arguments:
"TRUE"

An argument named "TRUE" appears in a conditional statement.  Policy
CMP0012 is not set: if() recognizes numbers and boolean constants.  Run
"cmake --help-policy CMP0012" for policy details.  Use the cmake_policy
command to set the policy and suppress this warning.
Call Stack (most recent call first):
C:/Users/ACER/Downloads/cmake-3.7.1-win32-x86/cmake-3.7.1-win32-x86/share/cmake-3.7/Modules/FindOpenMP.cmake:266 (_OPENMP_GET_SPEC_DATE)
CMakeLists.txt:54 (find_package)
This warning is for project developers.  Use -Wno-dev to suppress it.
OpenCL disabled, not looking for it
ANN not found, disabling it in benchmarks
FLANN not found, disabling it in benchmarks
CMake Error at D:/Project/build/tests/CMakeFiles/CMakeTmp/CMakeLists.txt:11 (add_definitions):
Syntax error in cmake code at
D:/Project/build/tests/CMakeFiles/CMakeTmp/CMakeLists.txt:11

when parsing string
-IC:\Program

Invalid character escape '\P'.
CMake Error at D:/Project/build/tests/CMakeFiles/CMakeTmp/CMakeLists.txt:11 (add_definitions):
Syntax error in cmake code at
D:/Project/build/tests/CMakeFiles/CMakeTmp/CMakeLists.txt:11

when parsing string
Files\Eigen

Invalid character escape '\E'.
CMake Error: Internal CMake error, TryCompile configure of cmake failed
Configuring incomplete, errors occurred!
See also "D:/Project/build/CMakeFiles/CMakeOutput.log".

there is any one who can help me
thank you

@mounaattia your error seems to be related to the path in: D:/Project/build/tests/CMakeFiles/CMakeTmp/CMakeLists.txt:1
the expression Files\Eigen contains a slash in the wrong direction. Also the space in Program Files is not interpreted correctly.

This seems wrong usage only. Closing it.


Is there a way to change endpoint of the incoming webhook for different teams?

Since each team in slack generates different incoming webhook for each app, is there a way this package can manage to change the endpoint for different users? I see that on Slack for PHP it's possible, but here you have just one preconfigured endpoint in the config/slack.php file.
Am I getting something wrong?
Thank you!

I just do
Slack::setEndpoint($webhook->url);
Slack::to($webhook->channel)->send('testing');


Add nb-culler cronjob

relevant issues: https://github.com/nerc-project/operations/issues/404,
https://github.com/nerc-project/operations/issues/387,
https://github.com/nerc-project/operations/issues/337
In this PR, I didn't change the namespace from our testing namespace ope-rhods-testing-1fef2f to rhods-notebooks because we need to confirm that everything operates as expected before we proceed to apply this cronjob to rhods-notebooks.

Thanks for working hard on this @DanNiESh and @dystewart to ensure this culler cronjob doesn't affect every notebook. I'm following up with Professor Lance Galletti to identify the uptime constraints for his class as well.


Error 'Cannot find 'Messaging' in scope' after installing with Swift Package Manager

Xcode version: 12.0.1
Firebase SDK version: 6.31-spm-beta
Firebase Component: Messaging
Component version: 6.31-spm-beta
Installation method: Swift Package Manager

Installed all Firebase components with Swift package manager 6.31-spm-beta branch.
All manuals describe steps to setup Firebase messaging:
import Firebase
....
FirebaseApp.configure()
Messaging.messaging().delegate = self

...

func application(_ application: UIApplication, didRegisterForRemoteNotificationsWithDeviceToken deviceToken: Data) {
        Messaging.messaging().apnsToken = deviceToken
    }

Xcode failed with error:
'Cannot find 'Messaging' in scope'

As documented at https://github.com/firebase/firebase-ios-sdk/blob/master/SwiftPackageManager.md, SwiftPM support for Messaging has not yet been released.  It has been implemented in the upcoming Firebase 7 milestone and will be released in the next month or two.

@paulb777 what would recommend doing if we needed Messaging as a dependency but are using the spm beta branch for all other Firebase dependencies?
Would it possible to add only Messaging as a binary target to an SPM package which depends on the spm beta branch? And if not, would it be possible to add only the Messaging .xcframeworks at the project level?

@rrozenv It's a bit ugly but probably workable to add the Messaging .xcframework (and its dependencies not part of SwiftPM) from the Firebase binary or Carthage distributions.

@paulb777 Thank you for the quick reply. Do you know if there is any way to get around having some dependencies be pulled from the spm branch, but then also linking Messaging as a binary target?
The problem is that some of the lower level dependencies like FirebaseCore and FirebaseInstallations are required for both Messaging and by those pulled from the spm branch. Below I have included my Package.manifest file which illustrates what I am attempting to do. This package actual compiles perfectly fine, but when I add it to an Xcode project I get the following errors:
-ld: warning: Could not find or use auto-linked framework 'FirebaseCore'

ld: warning: Could not find or use auto-linked framework 'FirebaseInstallations'

And if I attempt to add 'FirebaseCore' and 'FirebaseInstallations' as binary targets then the package does not compile any longer and I get the following error: "multiple targets named Firebase Core"
I feel like mixing and matching dependencies in this manner won't work, but just wanted to see if you had any ideas. If it doesn't work then would the next approach be to actually add every single Firebase dependency as a binary target and not depend on the spm branch at all? That would defeat the purpose of having a swift package at all, but do you believe it would work in theory?
let package = Package(
	name: "QuarkFirebase",
	platforms: [
		.iOS(.v13),
		.macOS(.v10_15),
		.tvOS(.v13)
	],
	products: [
		.library(
			name: "QuarkFirebase",
			targets: ["QuarkFirebase"]
		)
	],
	dependencies: [
		.package(
			name: "Firebase",
			url: "git@github.com:firebase/firebase-ios-sdk.git",
			.branch("6.32-spm-beta")
		)
	],
	targets: [
		.target(
			name: "QuarkFirebase",
			dependencies: [
				.target(name: "FirebaseMessaging"),
				.target(name: "FirebaseInstanceID"),
				.target(name: "Protobuf"),
				.product(name: "FirebaseAuth", package: "Firebase"),
				.product(name: "FirebaseStorage", package: "Firebase"),
				.product(name: "FirebaseDatabase", package: "Firebase"),
				.product(name: "FirebaseFirestore", package: "Firebase"),
				.product(name: "FirebaseFirestoreSwift", package: "Firebase"),
				.product(name: "FirebaseDynamicLinks", package: "Firebase")
			]
		),
		.binaryTarget(
			name: "FirebaseMessaging",
			path: "BinaryFrameworks/FirebaseMessaging.xcframework"
		),
		 .binaryTarget(
			 name: "FirebaseInstanceID",
			 path: "BinaryFrameworks/FirebaseInstanceID.xcframework"
		 ),
		 .binaryTarget(
			 name: "Protobuf",
			 path: "BinaryFrameworks/Protobuf.xcframework"
		 )
	]
)

Are the Could not find or use auto-linked framework warnings actually causing something to fail?
Your approach seems reasonable to me, but I don't have too much time to dive too deep in the near future.


Draggable pan/zoom controls

Enables dragging pan/zoom controls; centers subject image in viewable SVG area (to do: update on window resize); consolidates views for both transcription and annotation workflows into a single nav-tool directive

@itsravenous: just finished. have a look if you get a chance


Add GitHub action for header-gen build

@microbit-carlos I've attempted the merge with header-gen.yml.

@microbit-robert just a friendly ping that there are still a couple of open comments on this PR before we can merge it, which we might want to do to publish this package for (https://github.com/microbit-foundation/pxt-ml-extension-poc/pull/5)

@microbit-robert Publishing failed in:
https://github.com/microbit-foundation/pxt-ml-runner-poc/actions/runs/9479430290/job/26117936317
npm error code ENEEDAUTH
npm error need auth This command requires you to be logged in to https://registry.npmjs.org/
npm error need auth You need to authorize this machine using `npm adduser`

Does the access right for this repo has to be managed from the org settings?

@microbit-robert Publishing failed in: https://github.com/microbit-foundation/pxt-ml-runner-poc/actions/runs/9479430290/job/26117936317
npm error code ENEEDAUTH
npm error need auth This command requires you to be logged in to https://registry.npmjs.org/
npm error need auth You need to authorize this machine using `npm adduser`

Does the access right for this repo has to be managed from the org settings?

It's trying to publish in the wrong place. I'm guessing it's not reading the .npmrc file in working-directory. We can try moving it the root of the project and also changing the name in the package.json from "ml-header-generator" to "@microbit-foundation/ml-header-generator".

In the end it only needed the @microbit-foundation in the package name:
https://github.com/microbit-foundation/pxt-ml-runner-poc/pkgs/npm/ml-header-generator


No Bin Files

The instructions say run wacs.exe in bin folder I see no exe or bin folder.

Downloaded the zip from releases?
If yes, then your antivirus might be targeting the files

Yes, sounds like the good-old anti-virus thing, see #781


Add of marks

Added the ability to use KPLOT_MARKS and KPLOT_LINESMARKS

I'm reviewing your patch---meanwhile, do you have any exemplar graph pictures of this in action?

Hello.
Do you mean here: https://github.com/lock042/kplot/tree/marks/man ?

Finally checked all this in.  Thanks again!


Opentracing not tracing graphql traces

I have a JSON grpc server backed by this graphql library. The grpc server is instrumented using the grpc-opentracing package and I am using zipkin as the tracer. In the zipkin ui, I can see all the traces for the GRPC span, but I do not see any child graphql spans.
At the moment, I have only tested my mutations and have not tested any queries yet. The resolvers look like this:
func (r *Resolver) DoSomething(args *struct {
	Input *DoSomethingInput
}) (*doSomethingPayload, error) {

}

I've added the following to https://github.com/neelance/graphql-go/blob/master/graphql.go#L86:
sp := opentracing.SpanFromContext(ctx)
fmt.Println(sp)

It does find a span, but I see nothing in the zipkin ui:
&{0xc4203fc310 <nil> {0 0} {{{0<PHONE_NUMBER>0346085}<PHONE_NUMBER>697199075 true map[] <nil> 8 true} /eventstore.GraphQL/Query {63621715428 560669386 0x22de200} -1 map[span.kind:server component:gRPC] []} 0 <nil>}

It does work for me but as the Readme says  Fields are marked as trivial if they have no context.Context argument, no field arguments and no error result. You can use this to avoid unnecessary clutter in the trace: Do you think that could be it?

Which tracer are you using? I am using zipkin.
Having said that, my handlers have field arguments and an error result, so it shouldn't be marked as trivial. However, even if it was marked as trivial, I should still see the trace because I am not doing any filtering.

I don't use zipkin, but just collect them in memory and just display per request (traceid is matched again client request). I them trivially display trace, span and log in my frontend in case any error.

Do you mind sharing some sample code of how you are doing that in memory? I will give that a go tomorrow (getting late here) to see if the spans show up.

I am just starting my day here. will look into it later.

Awesome. Thanks! 😄

I keep local structures for Span, Log` to map to data I am interested in, and also indices of span in trace id etc for serving. I will use zipkin etc later, but now just want to see the error during development.
func main() {
	opentracing.InitGlobalTracer(monit.NewTracer())
  ...

  }

func (h *Handler) ServeHTTP(w http.ResponseWriter, r *http.Request) {
....
	span, c := opentracing.StartSpanFromContext(ctx, "HTTP")
	defer span.Finish()
span.LogFields(
		log.Object("header", getHeaderFromReq(r)),
		log.String("query", params.Query),
		log.String("operationName", params.OperationName),
		log.Object("variables", params.Variables),
	)
}

pkg monit
-----
  import (
   ...
  	basictracer "github.com/opentracing/basictracer-go"
  	opentracing "github.com/opentracing/opentracing-go"
  )

  var (
  	rec *basictracer.InMemorySpanRecorder
  )

  func NewTracer() opentracing.Tracer {
  	return basictracer.New(rec)
  }

  func SpansOnTrace(traceID string) ([]Span, error) {
  	raws := rec.GetSpans()
  	var pp []Span
  	for _, r := range raws {
  		s, err := mapFromRaw(r)
  		if err != nil {
  			return nil, err
  		}
  		pp = append(pp, s)
  	}
  	return pp, nil
  }

  ..

  func mapFromRaw(r basictracer.RawSpan) (Span, error) {
  	l, err := mapLogs(r.Logs)
  	if err != nil {
  		return Span{}, err
  	}
  	return Span{
  		TraceID:      strconv.FormatUint(r.Context.TraceID, 10),
  		SpanID:       strconv.FormatUint(r.Context.SpanID, 10),
  		Sampled:      r.Context.Sampled,
  		ParentSpanID: strconv.FormatUint(r.ParentSpanID, 10),
  		Operation:    r.Operation,
  		Start:        r.Start.UTC().Format(time.RFC3339),
  		Duration:     int32(r.Duration.Nanoseconds()), // TODO may need to divide first to get better precision
  		Logs:         l,
  	}, nil
  }

@bsr203 Thanks! Your code was really useful.
I did some debugging over the weekend and found the source of the problem. In my case, the grpc opentracing intercept requires me to explicitly pass in a tracer. I was under the assumption that once a tracer was passed in at the top most entrypoint of the app, that would be it. However, StartSpanFromContext which is called by graphql-go will start a span from the global tracer (which is a noop tracer if we do not set a global tracer).
In my case, I set a global tracer using opentracing.SetGlobalTracer() at the earliest part of my code and replaced method arguments that required an explicit tracer to opentracing.GlobalTracer().


property functions being flagged as invalid code in js files

From @jefflindholm on June 15, 2016 12:33

VSCode Version: 1.2.1
OS Version:
windows 10
Steps to Reproduce:

create a js file
create a class file and add a property
get "[js] 'property declarations' can only be used in a .ts file." with the property code highlighted.
I am attempting to use code to do react coding and using the property functions keep me from littering my code with myfunc = myfunc.bind(this); unless I actually need to rebind something. It is more an annoying visual thing to have a lot of code underlined than anything else, but it would seem to be something you should allow in js/jsx files.

class MyClass {
  someFunction = () => {

  }
}

Copied from original issue: Microsoft/vscode#7718

Duplicate of #6997. Fixed in https://github.com/Microsoft/TypeScript/pull/9189.


Remove net451 desktop target from Wilson6x

The behavior of the library is the same for both the net 45 and net 451 targets, so having both is unnecessary.

@Tratcher Sorry for not clarifying. We have both a net45 and a net451 target.
Just modified the issue to include this.


Update experimental qos_policy_config_test.go

Added experimental ECN queue-management-profiles config

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 69.611%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1663

Relevant Lines:
2389

💛  - Coveralls


Update index.mdx

Add .use in the examples of action$s
What is it?

[ ] Feature / enhancement
[ ] Bug
[x] Docs / tests

Description
Fix the doc by adding the .use onto action$s.
Use cases and why
N/C
Checklist:

[ ] My code follows the developer guidelines of this project
[x] I have performed a self-review of my own code
[x] I have made corresponding changes to the documentation
[ ] Added new tests to cover the fix / functionality

Hi @tleperou 👋
Thanks a lot for creating this PR 🎉
Since things are changing very fast atm, we sometimes have the situation, that a newer way was already shipped w/o deprecating the other solution. This is the case for .use() in combination with the loader$. Atm you can use it with and without the .use() fn call. The new way is to use it without, so the docs are correct.
Related changes:
https://github.com/BuilderIO/qwik/pull/2905
https://github.com/BuilderIO/qwik/pull/2981
Therefor i'll close this PR, but would really appreciate to see others from you (soon 😄 ) 🙏
Have a nice day and thanks again!

Indeed, I could solve all warnings by upgrading to the latest.
More than happy to hear that everything's going qwikly forward.
✌
I'll checkout around in the issues and PRs to find opportunities to get involve.
Thanks!


Tunnel with no client certificate?

Doing:
ghostunnel client --listen <IP_ADDRESS>:27017 --target [redacted]:27017 --status <IP_ADDRESS>:8080
Prints:
ghostunnel: error: required flag --keystore not provided, try --help
I understand from this that a valid cert is mandatory for client mode, but I don't want to auth client. Just want to use ghostunnel as a TLS tunnel as in stunnel, but with the added metrics and status features.
Is it possible? Am I doing anything wrong?
TIA.

It currently doesn't support doing that, as the ghostunnel client mode is intended to be used with a ghostunnel server backend which always requires a valid client certificate. I'd be happy to accept a pull request to make it optional if that's useful to you.

The CONTRIBUTING.md file in the root of the repo has some info on what's required to contribute (in particular, it has a link to Square's CLA).

Won't ghostunnel client work against any standard TLS remote server (ie. not ghostunnel server)?
Would it make a difference if using ghostunnel as TLS client without cert if the server is not another ghostunnel?

Sure, you can use it with any backend that supports SSL/TLS if you wish, but our primary goal is for them to be used together. Hence all the settings/options are set to assume you're talking to ghostunnel on the other end.

This is supported in master now, see #150.


Vulnerability roundup 84: jbig2dec-0.17: 1 advisory

search, files

[ ] CVE-2020-12268 CVSSv3=9.8 (nixos-20.03, nixos-unstable)

Scanned versions: nixos-20.03: 82b5f87fcc7; nixos-unstable: 0f5ce2fac0c. May contain false positives.

This will be fixed by #87815 :)

https://github.com/NixOS/nixpkgs/pull/87815 is merged, closing


Changing "Kerko Demo" Text

This looks like a wonderful contribution - huge thanks
Question - Is it possible to edit the "Kerko Demo" text in the top left?

Have a look at Kerko's variables. The one you'll want to set in your .env file is KERKO_TITLE.

Thanks.
Since it says the default is "Kerko" does that mean that the word "Demo" is hardcoded?

If you see "Kerko Demo" when running the application, then it would (normally) imply that your .env file has the line KERKO_TITLE=Kerko Demo. You may edit the .env file.

Thanks


Allow watching or blacklisting domains from metasmoke

When I click on a post in metasmoke, it tells me which domains were found in that post. I can also search for those domains to see how many times it's been seen.
Now, if I want to watch or blacklist any of those domains, I then have to go back to chat, and type the command manually.
Can it please be easier to watch or blacklist domains seen in a post when looking at its metasmoke record? It would be nice if there were buttons to watch or blacklist a domain from the domain record, or better yet, the post itself.

The easiest way to do this would probably be a userscript which would just send a chat message to CHQ with the !!/watch or !!/blacklist command.

@makyen It would be nice to have it in metasmoke itself, so I can use it even on mobile devices (on which user scripts can't be installed, and on which typing in the request manually is a much bigger pain).

Marking as deferred because it seems like a lot of work for not a lot of gain, it would require changes both smokey-side and MS side


Bibtex Support

@treyhunner : Thank you very much for the awesome CV template. I have been using your template for some time now.
Recently, Some of the work I did got published and now I need to add them to my CV. I played with your template a bit but couldn't figure out how to add the publications with bibtex (Of course I can add a Reference section with citations but I need to add them under a rSection).
I will be really grateful if you can give some pointers on how to do this.

Perhaps this will help others, if not the OP. What worked for me is using the package bibentry, which allows me to add references to notable publications inside a section. Below is an example:
\newcommand{\entry}[1]{\cite{#1} \bibentry{#1}}
\begin{rSection}{Publications}
		%\let\thefootnote\relax\footnote{Particularly notable publications marked with \ding{42}.}
    \bibliographystyle{alpha}
    \nobibliography{publications}
    \item \entry{PUB1}
    \smallskip{}
    \item \entry{PUB2}
    \smallskip{}
\end{rSection}

P.S., Thanks @treyhunner  for your Latex template, which I have happily used for 6 years now.


adding quarkus for bootstrap

With help from @ebullient & @maxandersen.

Hi @dandreadis, there are some required changes missing from the PR. Could you also update:

CONTACTS.yaml
PROJECTS.yaml
TRADEMARKS.md

Thanks

@kenfinnigan my bad - missed those in my review and @dandreadis is travelling atm. I've pushed the files so you can verifyu/validate and then @dandreadis can squash and sign so he confirms it as Quarkus EGC rep.

Are all reviewed changes in now? Thanks folks!

Are all reviewed changes in now? Thanks folks!

Yes. Internal discussions now (project review and agreement).


[FLINK-18755][docs-zh] RabbitMQ QoS Chinese Documentation

What is the purpose of the change
Add Chinese documentation for the new QoS settings in the RabbitMQ connector. The added English documentation can be found in the PR here: https://github.com/apache/flink/pull/12729/files#diff-6b432359b51642a8fad3050c4b73f47cR134-R167
Brief change log

add Chinese documentation for the new QoS settings in the RabbitMQ connector into  docs/dev/connectors/rabbitmq.zh.md

Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? no
If yes, how is the feature documented? no

@adiaixin thanks for your contribution, could you please get rid of the git merge operator, and use git rebase instead.


Link to the pre-processed dataset cannot be opened

Thank you for providing this awesome dataset. I found that this link cannot be opened anymore. Could you take a look? Thanks!

Preprocessed Kyoto-2006+ data available at: https://share.bitdefender.com/s/9D4bBE7H8XTdYDB

Hello! We are in process of changing the data storage system and unfortunately the URL we provided is unavailable for now. We will get back to you as soon as possible with the new data access link.
Best regards!

Hello!
The dataset is now available at: https://storage.googleapis.com/bitdefender_ml_artifacts/anoshift/Kyoto-2016_AnoShift.tar
:)


k8s: don't set node-selector for sk-tracer in kustomize files

[2] I certify that this PR does not contain any code that has been generated with GitHub Copilot or any other AI-based code generation tool, in accordance with this project's policies.

Description
don't set node-selector for sk-tracer in kustomize files
Testing done

manual testing
pre-commit passes

Updating Kubernetes DAG...
Please wait until the job has finished.


Initial API implementation

Consulting API specs in the GitLab wiki, make initial version of the Flask API that will be very subject to change.

Cancelled, see #86


digitalmarketplace-utils dependency: bump to 36.2.2

This includes fixes for security issues https://snyk.io/vuln/SNYK-PYTHON-BOTO3-40617 and https://snyk.io/vuln/SNYK-PYTHON-WTFORMS-40581, the fix for the latter requiring a synchronized rollout across all frontends

Are we bothered about the deprecation warnings on the FE apps? Running the tests on this branch gives me 182 warnings...

Yup I get these too but was prioritizing security fix speediness.


python311Packages.requests-pkcs12: 1.18 -> 1.21

Diff: https://github.com/m-click/requests_pkcs12/compare/1.18...1.21
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 256039 run on x86_64-linux 1

10 packages built:

faraday-agent-dispatcher
faraday-agent-dispatcher.dist
python310Packages.pytenable
python310Packages.pytenable.dist
python310Packages.requests-pkcs12
python310Packages.requests-pkcs12.dist
python311Packages.pytenable
python311Packages.pytenable.dist
python311Packages.requests-pkcs12
python311Packages.requests-pkcs12.dist


Generalize HttpState to handle client-side error state

Move to separate, general ErrorModule
Refactor naming of actions, effects, state, reducer to match generalization
Create specific HttpModule
Review locations of ErrorComponent and ErrorEffects
Move ErrorComponent, ErrorLayoutComponent and NotFoundComponent to error module

superseded by dx


Accessibility issues in L3:02

L3:02
Departure and arrival autocomplete entries are not read aloud when navigated with the keyboard.
Furthermore they do not inherit the styling from the parent wrapper div:  <div class="wrapper blur">

@SMEmp I see, I think you're referring to using the down/up arrow keys to select a field using ChromeVox Lite? I noticed that VoiceOver on Mac also does not read the fields aloud. This may just be a screen reader quirk. Tagging @alice in case she knows more

Yep, this is a browser/screen reader quirk. I note this works with VO in Firefox - Safari doesn't seem to support datalist at all 😞
It's not going to be feasible to fix this issue in ChromeVox Lite, unfortunately. I will definitely file a bug on Chrome regarding the VO issue and follow up here.
Since it's possible to type in the departure city, and this isn't a production form, I'm ok with leaving it as is for now, but very much appreciate the bug report!

Closing this but happen to reopen if there are additional issues.


WIP: Convert quint Map operator (TLA functions)

[ ] Tests added for any new code
[ ] Ran make fmt-fix (or had formatting run automatically on all files edited)
[ ] Documentation added for any new functionality
[ ] Entries added to ./unreleased/ for any new functionality

Codecov Report

Merging #2480 (b9c1af4) into main (91ad7b4) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #2480      +/-   ##
==========================================
- Coverage   78.37%   78.33%   -0.04%
==========================================
  Files         441      441
  Lines       15428    15436       +8
  Branches     2483     2486       +3
==========================================
+ Hits        12091    12092       +1
- Misses       3337     3344       +7

Impacted Files
Coverage Δ

...ain/scala/at/forsyte/apalache/io/quint/Quint.scala
79.27% <0.00%> (-3.43%)
:arrow_down:

... and 1 file with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

:warning: Automerge enabled!


OTU data page

Please add "OTU radial" in the OTU data page

@jlpereira could you check this one, this should be easy to fix. OTU page has one radial annotator, it should have two. OTU annotator is missing.

Its a shared view, not sure if there is a "clean" way to add it in this case, I will look the code

It is fine if it is in the Attributes or Annotations section. As long as it is accessible.

Try now

Great!


feat: doc tools remark container implement

PR Details
实现 container 语法插件。同时兼容 doc-tools 原有写法与 VuePress/Docsaurus 对应语法。

删除原有的 remark-directive 插件
开发 @modern-js/remark-container 包，并补充测试用例和 snopshot

后续 TODO:

设计和完善 doc-tools 插件机制，将 container 插件和相关样式封装为单独的 doc-tools 插件

Description

Related Issue

Motivation and Context

How Has This Been Tested

Types of changes

[ ] Docs change / refactoring / dependency upgrade
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[ ] My code follows the code style of this project.
[ ] I have updated changeset
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

👍🏻


How can i specify the vault ID?

We are using several vaults in our repo and a couple of them have different passwords.
Ansible supports providing several vaults IDs and different passwords for them, the same in about Ansibel Tower/AWX.
How can I use the plugin in order to set up the vault witn an ID and password?
Ansible Vault and several passwords documentation

Hi, thanks for your question. Using this plugin you can manually add any vault ID at the end of vault header line, like: $ANSIBLE_VAULT;1.2;AES256;vault-id-label and official Ansible tool will understand this. It will detect required password using this ID.
At the same time, this plugin do not need vault id labels to store different passwords for vaults. It stores passwords using full file path in your project.
So you can use different passwords without providing Vault ID labels in this plugin. But you can add label to the vault and plugin will work correctly with it.

@sadv1r thank you for the reply. I wonder what would happen if we decide to change the vault later? Will the plug-in replace the "header"?

Plugin will use existing version and ID label.


setMockMethodCallHandler was removed from MethodChannel after upgrading flutter to v2.5.2

I have upgraded Flutter recently and couldn't build after this upgrade due to the use of a method that was removed from MethodChannel which is setMockMethodCallHandler,
I don't think this is a big issue since method setMethodCallHandler is working fine after I temporarily replaced it in file controller.dart.
can you please upgrade this package to resolve this issue for everyone?

Should be fixed by #2


Pandas dependency missing

PDM, version 2.7.4.
[tool.pdm.dev-dependencies]
tests = [
    "pytest>=7.2.1",
    "psycopg2>=2.9.6",
    "snowflake-connector-python>=3.0.4",
    "fakesnow>=0.1.0",
]

When I run my pyunit tests, I get:
Traceback:
/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
tests/readers/test_snowflake.py:3: in <module>
    import fakesnow
.venv/lib/python3.10/site-packages/fakesnow/__init__.py:17: in <module>
    import fakesnow.fakes as fakes
.venv/lib/python3.10/site-packages/fakesnow/fakes.py:9: in <module>
    import pandas as pd
E   ModuleNotFoundError: No module named 'pandas'

It looks like fakesnow is importing pandas but doesn't declare it as a dependency.
I do see that the [pandas] snowflake extra_requires does declare it as a dependency, but it doesn't appear to be installing from your package.

Oh interesting, it looks like the pdm resolver effectively takes your snowflake-connector-python>=3.0.4 requirement and overrides fakesnow's dependency on snowflake-connector-python[pandas], and so pandas isn't installed. I haven't seen this behaviour with the pip resolver, which I'm more familiar with. I'll look into it.


Task: make wit-bindgen CLI registry-aware

The intent behind this task is to make wit-bindgen (or a similar) CLI registry-aware so bindings can be generated directly from a registry package (world/interface/component).
I envision this being needed for certain language tooling (e.g. C) where integration with tools will be more manual.

Cleaning up old issues


[$500] #gsc.tab=0 appears at the end of help links

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.3.98-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @quinthar
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1699660021286779
Action Performed:

Go to help.expensify.com
Click on "expensify classic"

Expected Result:
Redirects to https://help.expensify.com/expensify-classic/hubs/
Actual Result:
At the end "#gsc.tab=0" appends
Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01be9da36f7e51b34b
Upwork Job ID:<PHONE_NUMBER>041632768
Last Price Increase: 2023-11-12

It seems need to update the setting of Custom Google Search Engine.

Proposal
Please re-state the problem that we are trying to solve in this issue.
#gsc.tab=0 appears at the end of help links
What is the root cause of that problem?
The root cause is that the help links have #gsc.tab=0 attached to them in the redirects.csv.
What changes do you think we should make in order to solve the problem?
Change redirects.csv to read:
sourceURL,targetURL
https://community.expensify.com/discussion/5634/deep-dive-how-long-will-it-take-for-me-to-receive-my-reimbursement,https://help.expensify.com/articles/expensify-classic/get-paid-back/reports/Reimbursements
https://community.expensify.com/discussion/4925/how-to-dispute-an-expensify-card-transaction,https://help.expensify.com/articles/expensify-classic/expensify-card/Dispute-A-Transaction
https://community.expensify.com/discussion/5184/faq-how-am-i-protected-from-fraud-using-the-expensify-card,https://help.expensify.com/articles/expensify-classic/expensify-card/Dispute-A-Transaction
https://community.expensify.com/discussion/4887/deep-dive-understanding-your-expensify-card-statement,https://help.expensify.com/articles/expensify-classic/expensify-card/Statements
https://community.expensify.com/discussion/4883/how-to-export-your-expensify-card-statement,https://help.expensify.com/articles/expensify-classic/expensify-card/Statements
https://community.expensify.com/discussion/9528/how-to-understand-the-amount-owed-figure,https://help.expensify.com/articles/expensify-classic/expensify-card/Statements
https://community.expensify.com/discussion/4806/how-to-pay-your-expensify-card-balance,https://help.expensify.com/articles/expensify-classic/expensify-card/Statements
https://community.expensify.com/discussion/7303/how-to-track-and-report-on-fringe-benefits-tax-fbt,https://help.expensify.com/articles/expensify-classic/insights-and-custom-reporting/Fringe-Benefits
https://community.expensify.com/discussion/8984/how-to-display-report-ids-or-transactionids-correctly-in-excel,https://help.expensify.com/articles/expensify-classic/insights-and-custom-reporting/Other-Export-Options
https://community.expensify.com/discussion/5799/deep-dive-date-formatting-for-formulas,https://help.expensify.com/articles/expensify-classic/insights-and-custom-reporting/Custom-Templates
https://community.expensify.com/discussion/5795/deep-dive-expense-level-formula,https://help.expensify.com/articles/expensify-classic/insights-and-custom-reporting/Custom-Templates
https://community.expensify.com/discussion/5798/deep-dive-gl-code-formula,https://help.expensify.com/articles/expensify-classic/insights-and-custom-reporting/Custom-Templates
https://community.expensify.com/discussion/5797/deep-dive-report-level-formula,https://help.expensify.com/articles/expensify-classic/insights-and-custom-reporting/Custom-Templates
https://community.expensify.com/discussion/5794/deep-dive-understanding-custom-export-templates-and-formulas,https://help.expensify.com/articles/expensify-classic/insights-and-custom-reporting/Custom-Templates
https://community.expensify.com/discussion/5802/deep-dive-understanding-math-and-substring-formula-for-custom-exports,https://help.expensify.com/articles/expensify-classic/insights-and-custom-reporting/Custom-Templates
https://community.expensify.com/discussion/5796/deep-dive-user-level-formula,https://help.expensify.com/articles/expensify-classic/insights-and-custom-reporting/Custom-Templates
https://community.expensify.com/discussion/4750/how-to-create-a-custom-export,https://help.expensify.com/articles/expensify-classic/insights-and-custom-reporting/Custom-Templates
https://community.expensify.com/discussion/4642/how-to-export-reports-to-a-custom-template,https://help.expensify.com/articles/expensify-classic/insights-and-custom-reporting/Custom-Templates

sorry, this is helpdot related. no need for proposals here

Nice work, @rushatgabhane!

payment day!

@rushatgabhane anything needed here?


chore: make sure main cluster ingress domain appears in the external-dns domain filter

/approve

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: rawlingsj
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [rawlingsj]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rawlingsj: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

gsm
754fdd194043c8aec1959eb0014a04b2ee5c99e0
link
/test gsm

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@rawlingsj: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

gsm
754fdd194043c8aec1959eb0014a04b2ee5c99e0
link
/test gsm

vault
754fdd194043c8aec1959eb0014a04b2ee5c99e0
link
/test vault

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@rawlingsj: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

gsm
754fdd194043c8aec1959eb0014a04b2ee5c99e0
link
/test gsm

vault
754fdd194043c8aec1959eb0014a04b2ee5c99e0
link
/test vault

kube
754fdd194043c8aec1959eb0014a04b2ee5c99e0
link
/test kube

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

/retest

@rawlingsj: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

gsm
754fdd194043c8aec1959eb0014a04b2ee5c99e0
link
/test gsm

vault
754fdd194043c8aec1959eb0014a04b2ee5c99e0
link
/test vault

kube
754fdd194043c8aec1959eb0014a04b2ee5c99e0
link
/test kube

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

/retest


ANCOVA for pretest-posttest designs

Add ANCOVA as a new capability of the package

[ ] Glossary: add post-test only and pretest-posttest variants to the nonequivalent group design section

[ ] Flesh out with more detail?

[ ] Find an appropriate example dataset, preferably from a published paper

[ ] Add dataset
[ ] example notebook
[ ] add to docs

Possible studies:

Cummins, S., Petticrew, M., Higgins, C., Findlay, A., & Sparks, L. (2005). Large scale food retailing as an intervention for diet and health: quasi-experimental evaluation of a natural experiment. Journal of Epidemiology & Community Health, 59(12), 1035-1040.
Huang, E. Y., Lin, S. W., & Lin, S. C. (2011). A quasi-experiment approach to study the effect of e-mail management training. Computers in Human Behavior, 27(1), 522-531.


How to configure DNS on the DC's

Please can you provide more information on how DNS should be set up on Domain controllers in Azure. If you have 2 domain controllers in a vnet and set the DNS to custom on the VNET (Using the two IP's of the DC's\DNS servers), what should the settings be in DNS within the TCP\IP properties of the nic in the VM. If you set it to 'Obtain DNS server address automatically' then both domain controllers will point to the IP address that is top of the list on the custom DNS servers on the vnet. Is this the correct way of configuring this?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 60b0097c-668e-1d37-22b0-89d0bf649f8a
Version Independent ID: 49ccfef6-05bb-9c93-5a05-a2e2fe632b3c
Content: Install Active Directory Domain Services on an Azure virtual machine
Content Source: WindowsServerDocs/identity/ad-ds/deploy/virtual-dc/adds-on-azure-vm.md
Product: windows-server
Technology: ad-ds
GitHub Login: @iainfoulds
Microsoft Alias: daveba

Hi @iainfoulds.  Is there any update on the issue I raised? I can't see this documented anywhere by MS.

Hi @gerrynicol,
Thanks for the feedback. It's not clear in the article the VM requires restart for the change. It's covered in the "for more information" reference https://docs.microsoft.com/en-us/azure/virtual-network/manage-virtual-network#change-dns-servers. I added a line of text to the section that the VM requires restart.
Thanks for the feedback. I'll close the issue. #please-close
Pat


Typo in serial.rs

I encountered what seems to be a typo in serial.rs when building with feature "io-STM32L021"
index 190c40d..7b46ea9 100755
--- a/src/serial.rs
+++ b/src/serial.rs
@@ -173,7 +173,7 @@ impl_pins!(
     PA0, AF6, LPUART1, RxPin;
     PA1, AF6, LPUART1, TxPin;
     PA2, AF4, USART2, TxPin;
-    PA2, AF6, LPUART1, TxPin,
+    PA2, AF6, LPUART1, TxPin;
     PA3, AF4, USART2, RxPin;
     PA3, AF6, LPUART1, RxPin;
     PA4, AF6, LPUART1, TxPin;

That does indeed look like a typo! We should make sure that all 4 IO features are tested in CI :confused:

I'll provide a fix for this case and the CI.

Thank!

On a separate note I was able to toggle a pin and output on the uart very quickly: good job and thank you for the work on this crate!

This should now be fixed on master, so the issue can be closed.
@arkorobotics maybe there should be a patch release on crates.io since 0.6.0 breaks compilation for some targets?

Done! Released v0.6.1.


Metric-specific tags

Hey there; I wanted to know if there's any plans for metric-specific tags.
Since conn{} functions already accept tags as string, we can just expose this via a tags... string option to each metric type.
For example:
func (c *Client) Histogram(bucket string, value interface{}, tags... string) {
	if c.skip() {
		return
	}
        tags := // Join c.tags with tags
	c.conn.metric(c.prefix, bucket, value, "h", c.rate, tags)
}

Let me know what you think.

You should use the Clone method and customize the cloned client with the options you want.
The cloned client share the same connection so you can create as many clone as you want.


feat: add yarn action

The yarn action allows for setting up node_modules with caching while using yarn.

Since this caches node_modules, setting up node with yarn cache was redundant and caused a significant slowdown in my tests.  I removed it to help our caching go faster.