Peer-to-peer code review module-2 day- 3

Good work getting this far, Your code looks good.
Optional

We suggest using a li tag for the nav list since it's a SPw

Your app look very beautiful and attractive however here are a few issues I found in your app.

Remove button would look more decent in the centre,  right now it's not in the centre.
I Think you should remove all scroll bars in your app since it's a single page app.
I think you must use some borders on header and footer so that it look more beautiful and decent.


Update in attachment proccess

Hi Greg,
https://github.com/gregsdennis/Manatee.Trello/issues/318#issuecomment-564684929 is working fine and is uploading all types of file correctly. However, the problem occurs when your tired to download the uploaded files (from trello board) specifically pdf, excel and document files etc. In addition when ones tries to view .pdf,  .docx files will not be able to view it on trello board.
However, if  the WebApiClient file method GetContent is modified like this
private static HttpContent GetContent(WebApiRestRequest request)
{
    if (request.File != null)
    {
	var formData = new MultipartFormDataContent();
	foreach (var parameter in request.Parameters)
	{
		var content = new StringContent(parameter.Value.ToString());
		formData.Add(content, $"\"{parameter.Key}\"");
	}
       var fileStream = File.Open(request.File, FileMode.Open);
       var fileInfo = new FileInfo(request.File);
       formData.Add(new StreamContent(fileStream), "\"file\"", string.Format("\"{0}\"", "as" + fileInfo.Extension));
       formData.Add(new StringContent("mimeType"), "image/png");
       formData.Add(new StringContent("name"), request.FileName);
       TrelloConfiguration.Log.Debug($"\tContent: {formData}");
       return formData;
  }

 if (request.Body == null) return null;

     var body = TrelloConfiguration.Serializer.Serialize(request.Body);
     var jsonContent = new StringContent(body);
     jsonContent.Headers.ContentType = new MediaTypeHeaderValue("application/json");
     TrelloConfiguration.Log.Debug($"\tContent: {body}");
     return jsonContent;
}

This code is still be able to upload all types of files, and the user will also be able to download file in original format, and can view it on the trello board as well.

I don't know what your editor is doing, but it keeps putting spaces in instead of tabs.  The alignment is all off.
Also, for the build, the card attachment test is failing.  I'd like to also see a test that uses your method to attach a file.  The BasicData test has been resolved on the current master branch, so don't worry about that.  I'll rebase the target branch so that it's fixed.

Trello has reported an error with the request: {"message":"Must provide either url or file","error":"VALIDATOR_INVALID_VALUE"}


Updates

Summary by Sourcery
Refactor character and object interactions, introduce a password policy for account registration, and implement a waypoint system.
New Features:

Implement a waypoint system that allows users to save and recall room locations.

Tests:

Update tests to reflect changes in character movement and object interaction logic.

@sourcery-ai review

@sourcery-ai review


ImportError: Not able to import BasketMiddleWare

Found a bug? Please fill out the sections below.
Issue Summary
I tried to use django-oscar and follows the steps given in docs, but I am getting error
ImportError: Module "oscar.apps.basket.middleware" does not define a "BasketMiddleWare" attribute/class

The exact traceback I got is:-
/home/kapil/Development/___/project/project/project/settings.py changed, reloading.
Watching for file changes with StatReloader
Performing system checks...

System check identified no issues (0 silenced).
October 18, 2020 - 00:11:01
Django version 3.0.10, using settings 'project.settings'
Starting development server at http://<IP_ADDRESS>:8000/
Quit the server with CONTROL-C.
Exception in thread django-main-thread:
Traceback (most recent call last):
  File "/home/kapil/Development/___/project/venv/lib/python3.8/site-packages/django/utils/module_loading.py", line 20, in import_string
    return getattr(module, class_name)
AttributeError: module 'oscar.apps.basket.middleware' has no attribute 'BasketMiddleWare'

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/usr/lib/python3.8/threading.py", line 932, in _bootstrap_inner
    self.run()
  File "/usr/lib/python3.8/threading.py", line 870, in run
    self._target(*self._args, **self._kwargs)
  File "/home/kapil/Development/___/project/venv/lib/python3.8/site-packages/django/utils/autoreload.py", line 53, in wrapper
    fn(*args, **kwargs)
  File "/home/kapil/Development/___/project/venv/lib/python3.8/site-packages/django/core/management/commands/runserver.py", line 137, in inner_run
    handler = self.get_handler(*args, **options)
  File "/home/kapil/Development/___/project/venv/lib/python3.8/site-packages/django/contrib/staticfiles/management/commands/runserver.py", line 27, in get_handler
    handler = super().get_handler(*args, **options)
  File "/home/kapil/Development/___/project/venv/lib/python3.8/site-packages/django/core/management/commands/runserver.py", line 64, in get_handler
    return get_internal_wsgi_application()
  File "/home/kapil/Development/___/project/venv/lib/python3.8/site-packages/django/core/servers/basehttp.py", line 42, in get_internal_wsgi_application
    return get_wsgi_application()
  File "/home/kapil/Development/___/project/venv/lib/python3.8/site-packages/django/core/wsgi.py", line 13, in get_wsgi_application
    return WSGIHandler()
  File "/home/kapil/Development/___/project/venv/lib/python3.8/site-packages/django/core/handlers/wsgi.py", line 127, in __init__
    self.load_middleware()
  File "/home/kapil/Development/___/project/venv/lib/python3.8/site-packages/django/core/handlers/base.py", line 35, in load_middleware
    middleware = import_string(middleware_path)
  File "/home/kapil/Development/___/project/venv/lib/python3.8/site-packages/django/utils/module_loading.py", line 22, in import_string
    raise ImportError('Module "%s" does not define a "%s" attribute/class' % (
ImportError: Module "oscar.apps.basket.middleware" does not define a "BasketMiddleWare" attribute/class

Steps to Reproduce
Follows

Follow instructions given at https://django-oscar.readthedocs.io/en/2.1.0/internals/getting_started.html

Run python manage.py runserver command after migrate

Technical details

Python version: 3.8.5
Django version: 3.0.10
Oscar version: 2.1

You have a typo: BasketMiddleWare is not the same as BasketMiddleware


@hurumap/core/LineChart

Move LineChart to Hurumap-Core

There is also this comment left by @Arame93:

Issue while attempting to produce a line chart for the HURUmap using the Django admin. Despite following the standard procedures, we are unable to generate the desired chart. When trying to create a line chart, the graph fails to render as shown on the screenshot. I have done some researches to try to fix it but it seems to be a site configuration problem.

Whoever is working on this issue, please reach out to her (here or in Slack) to figure out what is/was the issue.

@kilemensi I'm working on this... @Arame93 I would like to know more about the chart you were attempting to generate


Possible cyclic dependency with numpy

An issue regarding a potential cyclic dependency was brought up on the Debian bug tracker:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=870426
Apparently cython needs numpy to run its tests, but numpy also depends on cython. If we build cython without numpy, does this result in the same binary or does it have less capabilities? I can see for example:
Cython-0.26$ grep -Ri numpy
[..]
Cython/Build/Inline.py:    elif 'numpy' in sys.modules and isinstance(arg, sys.modules['numpy'].ndarray):
[..]

which suggests that this might be the case.
If true, is it possible to split off the numpy-related parts of the cython build into separate files, so that they can be put into separate binary Debian packages that can be omitted if one wishes to run the build without numpy? Importantly, the non-numpy files would then remain identical, when running the build with/without numpy.
(The alternative is that the "cython" packages contains different content when built with/without numpy, which is problematic for binary reproducibility purposes.)

Both the C code that Cython generates and the installed Cython binaries will always be the same, regardless of any externally installed dependencies. That's an intentional and highly valued feature.
The only reason why there is a build dependency on NumPy is the Cython test suite. It contains tests that use NumPy, and they will be disabled if NumPy is not installed. If you want a complete test suite run, you should install NumPy, as well as the other external packages listed in the test runner, currently IPython/Jupyter and Jedi (the other modules in that list come with Cython or Python). Since Debian builds on so many different platforms, running the complete test suite seems desirable, especially with the native data types that NumPy makes available. But it's not a strict requirement for the resulting package. After all, you could also build the Cython package without running the test suite at all...


Wrong source map is generated

The source maps generated by the react-native packager seem to not be generated properly. We've seen in several projects that the mapping to/from around the React Tags code seems to not be correct.
For example, a user reported this issue: https://github.com/Microsoft/vscode-react-native/issues/206#issuecomment-209109389 in our project, and the root cause of the issue is because the source map file generated  by the react-native packager is not correctly mapping to the original source code (The original source code has 76 lines, and the .map files point to line 85 on that file).

Could you provide an example repo where we can reproduce this issue?

Yes, @gilesbradshaw was having this issue on his app, and he told us we can install it by doing:
git clone https://github.com/gilesbradshaw/ua-ql-mobile.git awesome2
cd awesome2
npm i

In https://github.com/Microsoft/vscode-react-native/issues/206#issuecomment-209109389 he describes exactly where to put the breakpoint to reproduce this issue (Which is also where the source maps aren't being correctly generated).

Thanks for looking let me know if you cannot replicate with that repo

I also had this issue recently where sources maps were off by ~10-20 lines. It only happened in component files with jsx.

The more import-statements, jsx-syntax or es6-classes in the module, the more difference is between correct lines and the generated source map.

@satya164 Any updates on this?

I've found a different symptom: the source maps are pointing to the entirely wrong files. Has anyone else experienced this?

@spikebrehm we are experiencing the same. At first by combining some of the imports we could get it back to work, however when the project goes, we lost more and more correct file mapping when debugging in Chrome. We have to try debugging in Nuclide to get to the exact breakpoints in exact file in those cases but it's not as powerful as Chrome.

Hi there! This issue is being closed because it has been inactive for a while.
But don't worry, it will live on with ProductPains! Check out its new home: https://productpains.com/post/react-native/wrong-source-map-is-generated
ProductPains helps the community prioritize the most important issues thanks to its voting feature.
It is easy to use - just login with GitHub.
Also, if this issue is a bug, please consider sending a PR with a fix.
We're a small team and rely on the community for bug fixes of issues that don't affect fb apps.

@facebook-github-bot label Icebox

@facebook-github-bot close

I also see this occurring. I'm getting completely wrong filenames from sourcemaps.

I have the problem where iOS works, but android bundlemap is of with 10-20 lines. Is this a common issue around here?

I'm having this... rn 0.44

I too am having this issue - has anyone else been able to solve it?  @brunolemos @vongohren - thanks!

Rn 0.48 still has this issue on android release build.

I'm seeing something similar, but from my research I don't believe the issue is with the source maps rather the raw stack traces point to the wrong locations in the bundle. As an example if we do throw new Error('test'); at 479:1837 in our bundle the actual location in the stack trace is 479:2150 which has nothing to do with the code path that leads to the error being thrown

@charpeni can we reopen this?

@k0nserv Sure.

@facebook-github-bot reopen

I've been doing some more research on this and it seems that it only happens with Android production builds. I've tried with the dev server and a bundle built with --dev true; in both those cases it correctly identifies the source of the exceptions. For Android bundles with --dev false however it's wrong

I was noticing that there's a line difference between 10-16 on the sourcemaps on an Android production app when logging errors to an error tracking service. Certainly is a bit annoying finding the actual lines affected.
Not sure about iOS though.

Many customers of ours (Sentry) also reported this issue and I can confirm that there definitely is an issue with android source maps.

Same issue. Any solution?
React native cli 2.0.1
React native 0.50.3

+1

Any resolution to this issue?
react-native-cli: 2.0.1
react-native: 0.53.3

The packager has been moved out to its own repo at https://github.com/facebook/metro. This issue has been open for a while and per records seems to still be happening. Please open a new issue at https://github.com/facebook/metro and make sure to provide all the relevant details.

For future navigators. I move the issue: https://github.com/facebook/metro/issues/148

@hramos looks like the root cause of this issue may come from React Native itself, since the sourcemaps generated from metro are correct (more information in https://github.com/facebook/metro/issues/148).
Can you reopen this issue?

@hramos & @rafeca is someone looking into this issue ?

I'm facing the same issue
react-native:0.54

I'm facing the same issue.
react-native: 0.51

Yes... any update on this ?
I'm also having this issue and the wrong stracktrace is showing up when I use BugSnag.

Bugsnag does not work properly because of this issue.
react-native: 0.53

This bug happens the same way on both iOS and Android for me, on RN 0.54.2. Why are there so many comments saying this is Android only? Has something changed?

Still doesn't work out of the box with RN 0.55.3, but I may have found a workaround.
By specifying --minify false, it appears the sourcemaps line up correctly.  This would explain why dev is working, and not release.
In Android, I use the following in app/build.gradle:
project.ext.react = [
    ...
    extraPackagerArgs: ["--minify", "false"]
]

This causes bugsnag to show me the correct line for javascript errors.  Not specifying --minify false, I get wrong line numbers like everyone else.
In my case, the js bundle size went from 2.5mb to 4.1mb. The obvious downside of this is that you'd expect the APK to be larger, but interestingly, I didn't see a noticeable difference in the APK size, since the APK is a zip archive.  Also, theoretically it will take longer to initialize the app, but also, I didn't really notice.
I'm now going to see if I need to do the same thing for IOS, and I'll report back here with findings.

Thanks for the information @seanadkinson! Let me know if you can repro also on iOS

Bugsnag line numbers line up with IOS as well.  Just need to specify EXTRA_PACKAGER_ARGS="--minify false" in the Build Phase.

Since the issue is apparently just with the minification, it seems relatively simple to send the bundle through minification manually, and translate the sourcemap accordingly.  I don't know if a tool like that exists, but my team will be looking into it shortly I'm sure.
For now, having the sourcemaps correct, at the cost of less than 1mb build size, is a pretty good trade for us.

@seanadkinson using the minify = false for Android works fine with the line numbers but the iOS is messed up now. We are using the Sentry though.

@seanadkinson & @HazAT the above settings works fine with the Sentry SDK also

I'm getting the same issue as well. And the approach suggested by @seanadkinson was the only workaround I could find.

For those of us who use CodePush, minifying the bundle is a necessity... Not doing so increases the size of the bundle by ~2x, which would slow down required OTA updates via Codepush.
@charpeni @hramos can we get an update on this?

I don't have anything to add - this was not on my radar.

@cpetzel Curious if code-push is configured to use gzip when downloading the bundle, and whether that significantly reduces the 2x size factor for download.

After investigating much more, I've found that this is actually caused by an issue when generating the source maps from metro. I'm going to land a commit that fixes it
Apologies for the issue 😞

Is this issue solved now ?  Do we need to use the latest react-native version ?

It's fixed on master, but will not be available until next stable version of react-native (0.56.0)

@rafeca with react-native 0.56.0 stable released does this fix added into it. I am not able to see it in the changelog of the 0.56.0 release

@anandwahed yes, it should have been fixed there 😃

Just in case anyone comes across this before RN bumps their metro dependency, I finally finally got working line numbers by adding this to my package.json file (make sure you use yarn not NPM)
"resolutions": {
    "react-native/metro": "0.39.1"
}

I'm still experiencing this in 0.56.0-rc.2.
node_modules/metro-source-map/package.json has "version": "0.38.1", so this has the changes from @rafeca.

I've updated to 0.56, added the false minify flag and also tried to use 0.39.1 resolution method by jsheader, but I still cannot get the source-maps to match.

We've tested this out in an example app that uses React Native 0.56, and it seems as though the original issue can still be reproduced. Here are the steps we followed to observe this behaviour:

Build Android app in release mode:

react-native run-android --variant=release

Generate sourcemaps:

react-native bundle \
--platform android \
--dev false \
--entry-file index.js \
--bundle-output android-release.bundle \
--sourcemap-output android-release.bundle.map

Apply the sourcemaps to an error and inspect the line numbers:

@rafeca please let us know if you require any further information to reproduce this, or whether we're missing some additional step required to get things working - we're more than happy to help out.

This sadly is still broken 😞
I took the time and put together a "minimal" repro case including tests with our symbolication library symbolic https://github.com/getsentry/symbolic/pull/78
See this repo: https://github.com/HazAT/react-native-source-map with the repro case.
The readme should explain how to run and test is locally.
Hope this helps debugging this issue since we (Sentry) still getting reports that this is broken.

As I understood it in my tests it's not a problem with sourcemap because if you see the where the error is referenced in index.bundle it's already wrong.
When you look at the symbolicated version using sourcemap, you just have to the original code pointed by index.bundle. So I think index.bundle.map and index.bundle are always coherent together.
Also, there's a similar behaviour when you work with iOS Simulator in dev version. When I tested it with an slow machine I could see dinstinctly a first red error page with the same wrong line number as I can see in sentry. A second after it's updated with the correct line number.
I don't know if any of this can help 😅.

Could we please reopen this? Upgraded to 0.56 and still no help :(

We've been experiencing this issue on Android specifically. I'll try to reproduce on Android in your test app as soon as I have time.

Ok, from the thread I've seen people complaining for both iOS and Android.
If the issue can only be reproduced in Android, it may be related to the device itself (maybe JSC is reporting the stacktrace position incorrectly).
To verify that, can you please doublecheck if the original line/column reported in the error is correct?

@rafeca If I try to run your example repo on Android it fails.
I create an release build and put it on a device.
cd android && ./gradlew assembleRelease --stacktrace && \
jarsigner -verbose  -digestalg SHA1 -sigalg MD5withRSA -keystore your-keystore.keystore -storepass ***** app/build/outputs/apk/app-release-unsigned.apk release && \
adb install -r app/build/outputs/apk/app-release-unsigned.apk

react-native bundle --entry-file index.js --platform android --dev false --bundle-output main.jsbundle --sourcemap-output main.map

yarn run sourcemap main.map 306 751

{ source: '/Users/haza/Downloads/rn-test-app-master/App.js',
  line: 38,
  column: 10,
  name: 'createElement' }

tbh I am pretty sure under special circumstances this is also broken on iOS, I am just not sure how to reproduce it there.

Thanks for the info! 👍 After some fights I've been able to compile the app for Android in release mode and indeed I've been able to reproduce the problem.
If I check line 306, column 751 on the generated production bundle, that position does not correspond to the generated Error position, so the original line/columns that the JS vm are reporting are already wrong:

Actually, the symbolicated line/column (38:10), corresponds to the (wrong) original position, so the issue seems to be coming from JSC and Metro is just doing the right thing.
I recommend creating a different issue for this specific problem (since this issue refers to the sourcemap generation on Metro which was already fixed). Unfortunately I'm not going to be able to assist you with this new one, since this is not my area of expertise... but something I noticed is that this can potentially get fixed once RN upgrades the JSC version for Android.

That's what I meant when I said "index.bundle.map and index.bundle are always coherent together". I really don't think it's a sourcemap issue, the line in the Error doesn't point to the good line in the bundle.
However, try to get the bundle used by you metro server by downloading it from localhost:
curl -L "http://localhost:8081/index.bundle?platform=ios&dev=false&minify=true" > index.ios.bundle.map

(the parameters here are just an example)
You'll see that the bundle you download is never the same you get using react-native bundle and with this one, the error line is correct.

However, try to get the bundle used by you metro server by downloading it from localhost:
curl -L "http://localhost:8081/index.bundle?platform=ios&dev=false&minify=true" > index.ios.bundle.map

The bundle generated by the devserver should be the same as the one generated by react-native build (using the same dev and minify params on both). The only thing that could change is the module ids (the numbers that are inserted at the end of each compiled file) if you generate several different bundles with the metro server (since these numbers are autoincremental), but they do not affect the sourcemaps.
Do you have any repro steps that make Metro generate different bundles? If so, that's an issue in Metro

For any future reader landing here because potential sourcemap issues in Metro, I've just created an end to end test that ensures that SourceMaps work fine on a very similar scenario.

@rafeca

I recommend creating a different issue for this specific problem (since this issue refers to the sourcemap generation on Metro which was already fixed). Unfortunately I'm not going to be able to assist you with this new one, since this is not my area of expertise... but something I noticed is that this can potentially get fixed once RN upgrades the JSC version for Android.

As you said, I think it is a issue about android jsc, so I open the issue #20628

@all
Inspired by @rafeca

upgrades the JSC version for Android

I found that it's working to get the correct line/column of a error stack by using react-community/jsc-android-buildscripts

The fix that @YeatsLu found works indeed.
Just tried it in my test repo and it works, this it the commit:
https://github.com/HazAT/react-native-source-map/commit/a559cb54482e80b9191b45ee7ea41f247086aa57
So updating JSC for react-native fixes the source map issue for Android.
🎉

Any updates on when this fix will be released?

@yaronlevi , update to RN 0.57.3, react and react-test-renderer to 16.6.0-alpha.8af6728.

0.57.3 and 16.6.0-alpha.8af6728 worked for me! Thanks guys! 🥇

Hello, Is required to update react to fix this?? Any stable version working?

Tried in RN 0.57.6 and the issues is still there. Im using bugsnag 2.12.6.

I tried RN 0.57.8 with react-native-sentry 0.38.2 and the line numbers are still incorrect.

This worked for me

Close the Metro Bundler terminal window
Run watchman watch-del-all && rm -rf $TMPDIR/react-*
Run the project react-native run-xx

I am on "react-native": "0.57.7"

This worked for me
react-native start --reset-cache

Source maps are off after I updated to 0.59.1 on Android.

Experiencing the same issue as @yurykorzun, any workaround?

Happens also on 0.59.0

Experiencing the same issue as @yurykorzun, any workaround?

I wish I knew what causes it, so I could try to create fix, but I have no idea. For now, I am debugging only on iOS. I hope there will be a fix soon.

Source maps are off after I updated to 0.59.1 on Android. Works fine for iOS.

Same here. Happens after updating to 0.59.1.

I am getting this issue too on Android for 0.59.1
"react": "16.8.5",
"react-native": "0.59.1",
"react-test-renderer": "16.8.5",
"metro-react-native-babel-preset": "^0.53.1",

related -> https://github.com/facebook/metro/issues/380


DRAFT: Challenge-based authentication

This is a draft of the work to add support for challenge-based authentication.

FYI @Azure/adp-keyvault


Custom action.py - no attribute dispatcher.utter_response

Rasa Core version:
0.11.12
Python version:
3.6.2
Operating system (windows, osx, ...):
Win 10
Issue:
I am able to send a response using dispatcher.utter_message in my custom action.py. However, I wanted to be able to send buttons and image along with text using dispatcher.utter_response. When I used dispatcher.utter_response (I can see this is mentioned as being available here https://rasa.com/docs/core/master/api/dispatcher/#rasa_core.dispatcher.Dispatcher.utter_response), python gives me this error
AttributeError: 'CollectingDispatcher' object has no attribute 'utter_response'.
Is this not available in v0.11.12? Or am I doing something wrong in my code?
Thanks for the help! 😃

Thanks for raising this issue, @MetcalfeTom  will get back to you about it soon.

Hi @johnjacobkenny no need to worry,
Your function call is fine.  I am wondering where you are importing the dispatcher from?  CollectingDispatcher is from rasa_core_sdk and does not have the utter_response() method.  The class you want is Dispatcher from rasa_core/dispatcher.py

I am using the dispatcher object provided in the run method,
def run(self, dispatcher, tracker, domain):
Is there any configuration that needs to be enabled to get a Dispatcher type object here?

No problem!
No, seems good to me in there.  I'm just trying to work out exactly where this rogue Dispatcher class is being imported.  Does your action class inherit another?  Are you using any custom or non-default classes in your bot?  (particularly the processor)

Here's a skeleton
from rasa_core_sdk import Action
from rasa_core_sdk.events import SlotSet

class ActionCustomAction(Action):
    def name(self):
        return "..."

    def run(self, dispatcher, tracker, domain):
        ...
        dispatcher.utter_response(...)

I'm new to Rasa, so I'm trying out the simplest use case right now. Does this code shed any light on the issue? The code I stripped out involves using python's request API to make an API request.

Yes it does!
Please replace your first line with
from rasa_core.actions.action import Action

And we should be good to go

no no, the import should be from the rasa_core_sdk

In that case, please use dispatcher.utter_attachment() as described in rasa_core_sdk here

Does that allow sending buttons and images in a single message?

No, that would currently have to be handled with another call to dispatcher.utter_button_message().
If you wanted both buttons and images in one call, you could inherit the dispatcher and build a simple custom function for it.  If you wrote this function, I see no reason why we could not also add it to the source code as well 😊

@MetcalfeTom the dispatcher.utter_attachment() didn't work as expected. Instead of sending, lets say, and image with:
attachment = {                     "type": "image",                     "payload": {"src": "http://image.jpg"}                 }
, it just sends a text with the above content and a capital 'A' in Attachment to the output channel.
I'm using the SocketIO as input/output channel.

@jonDel Was your issue resolved

@mrcoolhp no it wasn't.

please create a new issue as this one is already closed


Japanese text doesn't load

Japanese (and a few other languages) seem to be broken and won't load the text in NCC.

It seems that not a specific language is broken. I could switch to Japanese without problems and then tried out all other languages. At some point (German in that case) it just didnt switch any more. Even a restart of NCC did not help.

fixed in 0.6.31 rel


Refactoring of operators_converters

This PR:

removes the skl prefix to sklearn converters
removes the onnx prefix to onnx converters
moves lightgbm and xgb converters out of the sklearn folder

Codecov Report

Merging #249 into master will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #249   +/-   ##
=======================================
  Coverage   93.53%   93.53%
=======================================
  Files          39       39
  Lines        2104     2104
  Branches      382      382
=======================================
  Hits         1968     1968
  Misses         72       72
  Partials       64       64

Flag
Coverage Δ

#unittests
93.53% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...perator_converters/onnx/array_feature_extractor.py
100.00% <ø> (ø)

hummingbird/ml/operator_converters/onnx/linear.py
84.09% <ø> (ø)

...mingbird/ml/operator_converters/onnx/normalizer.py
100.00% <ø> (ø)

...ird/ml/operator_converters/onnx/one_hot_encoder.py
87.50% <ø> (ø)

hummingbird/ml/operator_converters/onnx/scaler.py
100.00% <ø> (ø)

...gbird/ml/operator_converters/onnx/tree_ensemble.py
84.10% <ø> (ø)

...ator_converters/sklearn/array_feature_extractor.py
100.00% <ø> (ø)

...rd/ml/operator_converters/sklearn/decision_tree.py
100.00% <ø> (ø)

hummingbird/ml/operator_converters/sklearn/gbdt.py
89.02% <ø> (ø)

...mingbird/ml/operator_converters/sklearn/iforest.py
90.21% <ø> (ø)

... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46c35fc...29abb68. Read the comment docs.


class Mix_RGBE_Encoder(nn.Module) BUG

Hello, thank you for your open source code.
Maybe class Mix_RGBE_Encoder(nn.Module) has two BUGs in these two lines, one is self.image_encoder(input_images) only returns two variables, but you wrote three here, image_tokens are not mentioned. The other one is masks here are not declared cause code to run incorrectly. Can you solve it?
image_tokens, image_embeddings_dict, token_weights_dict = self.image_encoder(input_images)
evimg_embeddings_dict = self.evimg_encoder(input_evimgs,image_tokens,masks)

These code bugs will be addressed within this week.

It seems that there are still problems with the code, for example image_tokens are not defined.
        input_images = self.image_preprocess(images)
        input_evimgs = self.evimg_preprocess(evimgs)
        image_embeddings_dict, token_weights_dict = self.image_encoder(input_images)
        evimg_embeddings_dict = self.evimg_encoder(input_evimgs,image_tokens)

        return image_embeddings_dict,evimg_embeddings_dict,token_weights_dict


Bokeh update

Fixes #220
Description of the Change
Fixes the page layout issues described in #220.

Ran unit tests with bash run/blast.run.sh ci for commit b2f6e77 with success after rebuilding the base dependencies image:
docker build app/ -f app/Dockerfile.deps -t hub.ncsa.illinois.edu/blast/deps:latest

After pushing the updated deps image I updated the associated digest in the application Dockerfile. After merging this PR I will push the rebuilt hub.ncsa.illinois.edu/blast/blast:latest image.


OCPBUGS-12629: Bump x/net to v0.7.0

Bumps x/net to fix CVE

/jira refresh

/cherry-pick release-4.13

/jira refresh


docs: add myself as author for bosnian language

FYI @marwahaha
Added myself as author for bosnian language

Coverage decreased (-0.09%) to 88.435% when pulling ead1f4a7aec22b238c3baf4475f837b5e36115de on rasidre:add-locale-author into 52019f1dda47c3e598aaeaa4ac89d5a574641604 on moment:develop.

Merged in d753d96b16c80234375dda81186685cb0e577e4d


Disable format-security warnings for the SWIG wrappers.

Sometimes we don't have a choice but to be unsafe when bridging.
rdar://problem/46500945.

@swift-ci test and merge

@swift-ci test and merge


Layout proposal: nodes "clustered" by groups

In various projects where I used VisJS, I often had the need to implement a node clustering feature based on the groups. I'm not talking about the already implemented clustering feature where one node can contain other nodes, but a layout which places nodes of the same group in the same region of space in VisJS canvas. I also reported this "problem" in an issue on the original VisJS GitHub project.
One good example where you can see what I mean for this is the world cup example hosted on the site, where all the nodes are nicely clustered and "all nearly placed" based on their group.
But... in the examples, the effect is obtained by the physics engine - as far as I understood - which tends to place highly connected components all together, while I needed a feature where the user simply puts some groups to the nodes and VisJS magically places them in a clustered way.
So, after some experimenting and having fun with VisJS, I came up with a prototypical implementation for this layout, which I'll describe there in a form of simple list of steps.
In short, the algorithm for the feature works by dividing the canvas space where VisJS places the nodes and programmatically assigning xy positions to all the nodes.

The space where VisJS works is considered to be a circle that gets sliced in n partitions, where n is the number of the distinct groups specified in the dataset of nodes. This is simply done by slicing the 360° space for the number of groups with some basic trigonometry.
Each of those partitions of space is related to a group of the nodes and has its own center. XY positions of nodes are then calculated in order to be placed on the circumference of such partitions, with the radius of the partition scaled according to how much nodes belong to that group partition (a group of two nodes will get a smaller partition compared to a partition related to a 50 nodes group). Still, this is done by using some trigonometric basic concepts.
Physics engine is disabled in order to place the nodes in the xy calculated positions.
(optional?) I also used a "fancy" way to visualize the obtained clusters by using a convex hull algorithm. Clusters of node are surrounded within a colored polygon (this is done on the canvas in the afterDrawing function). This can be CPU intensive because convex hull is calculated for each rendering frame for each group, but works pretty well in practice.
Result is that different groups of nodes are placed and clustered in circles, placed around the VisJS canvas, amongly spaced, independently from their connections/edges (screenshots attached).

I implemented such prototype in a local minimal project, and I'm attaching some screenshots to show the results.
Problems:

is this a really needed layout or it is useful only in niche/rare use cases? :) is all of this a not needed overkill?
design and produce a general version of the algorithm which responds well to highly populated groups and high variance between the population of the groups

400 nodes, 8 groups

2 groups clusters

4 groups clusters

Convex hull detail

I can't really image why someone would do this but that may be just my limited imagination. Could you, please, showcase some projects that good make use of it? Because to me it seems quite weird and the edges go all over the place in a very chaotic manner. Seems really hard to navigate. Though I can't say anything definitive before I actually see it in action and also the code anyway.
In the future I'd like to have the layouts reworked into modular design and custom layout support (something like network.addLayout("custom-layout-name", customLayoutFunction);). We could then provide a library with all kinds of niche layouts (like this one) without cluttering the library with code vast majority of people will never use.

Hi Michele! Thanks for opening this issue! Please feel free to also share your implementation progress e.g. in a draft pull-request.
As @Thomaash already mentioned it would also be useful to describe how these kind of layout could be used.

@Muntaner, I'd imagine creating densely connected subgraphs with hidden layers cateters very well for placing them close via the physics engine. You can have physically active (present) but hidden edges.
edges.push({
  from: 1,
  to: 2,
  label: "1--2",
  hidden: true
});

Did you experiment with that?

I actually really, really need such a feature!
I thought it was already implemented, because I don't really see the point of having groups of nodes if the groups don't "regroup" the nodes in the same area... now I have this gigantic network with nodes from groups scattered all around when I really need them to be in separate areas, because right now you can't see anything, there's way too much information.
You can see my network here: https://clemsmusic.com/thechart/chart_example.php
The nodes are characters, and the groups are shows that these characters belong to. When you click on a node, a popup appears, and if you click on the name of the show in the popup, the nodes from the group (= the characters from the show) appear in red. You can see they're not in the same area at all... which makes it all really hard to read.
So I vote a big YES to this layout!

Hi @clem-41,
could you provide some more info about this? Ideally disable physics, position the nodes the way you want and post before and after screenshots. If you want some background highlighting of groups, borders or so sketch it there too (it doesn't have to be pretty or contain a million nodes, just to show what you want so that we're all on the same boat).
Thanks.
PS: If you want to know why it makes sense to have groups of nodes that don't group in the same area look on https://thomaash.github.io/me/#/canvas. There is a group for computers, a group for switches, another group for ports and so on.

An idea here: We already have groups and clusters. Could we call this districts? Thumbs up? Thumbs down? Better names?

Yes I think districts is a good name for this.
In my specific case, I don't need a precise shape for the districts (like the circles from Muntaner's post). I just want the nodes to stay in the same area, next to the nodes from the other groups.
Here's what my network looks like now: the nodes that belong to a same group aren't next to each other, they're all scattered across the network.

And here's what I would like to get (I only detached the nodes of three groups from the rest of the nodes to show you what it would look like): roughly the same presentation, but with nodes from a group next to the other nodes of the same groups.

(Please note that the red borders are just here to show the different groups of nodes, but I don't want them to appear on the network)

This is mostly brainstorming but:

A node could belong to a district.
All nodes in each district would be positioned in isolation.
All first level districts (districts of nodes) would be positioned.
All second level districts (districts of districts of nodes) would be positioned.
All third level districts (districts of districts of districts of nodes) would be positioned.
And so on.
All top level districts and nodes not belonging to any district would be positioned.
Absolute positions would be written into the nodes.

Each district would be done independently in isolation (parallelization opportunity here). This would allow different configurations, layout algorithms etc. for each district. I don't see a difference between a node and a district for layouting (a node has some bounding box and position, a district has some bounding box and position). This could easily be implemented as recursive algorithm running from bottom to top. Basically solving this and  #136 in one go.
The districts could have some basic optional styling:

borders,
labels,
backgrounds.

And someone would have to go, throw away all the algorithms (they're poorly documented and in ancient JS, plus having them in TS would be nice, also the people who wrote them are long gone) and write brand new ones. I think that adapting what we have for such drastic change would be more work though as always I may be wrong.
PS: There's no exact algorithm behind this. If I'm missing something important, please tell.

I'm really not good at this so I can't tell you if something's missing, but what you said sounds good so far! I hope Muntaner comes back here soon so that they can give their opinion on this.
I'm guessing this will take a while to do, right?

Yeah, this will take a while. Especially since I want to solve a few other issues first.
PS: Contributions are always welcome and deeply appreciated. Just saying in case anyone has some free time.

This is very useful! I want to add another use case / some more ideas for this feature.  We use vis.js for helping create better/cheaper/safer medications in the pharmaceutical industry.  This example below is test data that's dumbed down a lot.  Imagine here that we're analyzing how to create a better cake:

So at the top are the "Final Quality Attributes" of the cake.  This is an analysis of the cake after it's made, like the external color, gluten content, etc.  On the right are the attributes of the incoming materials (think flour, eggs, etc), and on the bottom are the important things to measure at each stage of making the cake.  In this very contrived example, you might mix the dry ingredients separately from the wet ingredients, then mix them all together.  You'll have different mixing times, as well as different measurements of fat content, etc.  This graph helps scientists figure out what they understand, what they don't understand and how it's all related.  The context of which attributes are in which steps of the manufacturing process is very, very helpful. Real-world examples are obviously much, much more complex.
I've created the above grey boxes listening to the beforeDrawing event and drawing the boxes on the canvas.  My users would love to drag and drop those grey boxes around, in order to move the manufacturing steps around and think through different ways to solve various problems.  This feature literally can help design cures to many terrible diseases, including cancer.

Hi @rsshilli,
thanks for your use case. This is pretty much exactly what I imagine this to look like. It's great to have it on a nice picture and to know there are many people who would use it.

This would be great for me too. My use-case for this would be for generating database entity relationship diagrams, where clusters of tables are grouped together into "apps" (in Django terminology).
This would be a particularly nice use for it, as most of the connections would most likely be within the app-groups.

Hello to everyone, sorry for the delay in the reply.
I'll try to share my thoughts based on the discussion.
@Thomaash: I agree that it is hard to spot the real purpose of such a feature with random data, randomly connected (as I've showcased in the opening comment), but there are some real use cases which need this kind of separation.
Imho, it's needed when you have some strongly interconnected node groups with low inter-group correlation. Apart from the practical cases reported in previous comments, networking and social scenarios come to my mind.
On the naming of the feature, I really like the "district" term!
By the way, here it is a small repository containing a minimal project with an implementation of the discussed feature. No tests and all, just some quick and ugly code to make the feature work.
Some comments on the implementation:

the district disposition of the nodes is applied by using the "computeNodesPositionsDistricts" method in the draw() function, in the attempt of making this feature 100% optional and modular;
same goes for the convex hull groups rendering, which is contained in the "afterNetworkDrawing" method and is 100% optional;
in the discussion, I've noticed that the circle disposition of the nodes of a district isn't always a good approach. By the way, this should be easily customizable by changing the "getContourPoint" function logic in districts.js.

I don't know if this is useful or it is the right approach in providing a way to eventually integrate this layout in VisJS code without cluttering the code, but I hope it's a starting point.

Hi @rsshilli by any chance, do you have an example for rendering the network like you have in https://github.com/visjs/vis-network/issues/203#issuecomment-571164712 ?
Thanks!

@ccamacho No, unfortunately, I don't. It's quite a bit of code in a private repository.
The gist though is to figure out how to lay everything out and then:

listen to the "beforeDrawing" event to use raw drawing events to draw the boxes

        network.on("beforeDrawing", this.onBeforeGraphDrawing);

list to the "dragStart" event to figure out if one of the boxes is being dragged

        network.on("dragStart", this.onDragStart);

Then if the user is dragging the box, select the all of the nodes so they're dragging that instead:
  onDragStart(event) {
    // Search for a container box that might be clicked on.
    const canvasPosition = event.pointer.canvas;
    const allNodeIdsInContainerBox = this.getAllNodeIdsInContainerBoxAt(canvasPosition);

    if (allNodeIdsInContainerBox) {
      window.network.selectNodes(allNodeIdsInContainerBox);
    }
  }

As they drag the nodes around now, the box will still keep getting drawn using the beforeDrawing event as they drag the items around the screen.
Hopefully, that helps.

I totally need this for my project. I am currently working on a dependency mapping tool and I want the user to be able to arrange dependencies by it’s group, if they want to. Just like in your example layout. I am surprised nobody has ever thought of adding this to vis us before, but goodness I need this.

This would also be really useful for epidemiology, where individual cases are connected to some other cases, but then also might be connected to (or only connected to) a "cluster" (i.e. a location or event associated with multiple cases).

I also have a similar usecase. Would be great if it is possible.

@Muntaner Great work! I believe this is a long-waited feature for some vis.js users. Is there a code repo?

I used to have a repo for this feature, but I realized I really don't have the time to dedicate to the project in order to polish it and properly find a way to integrate it with the VisJS codebase and I decided to close it.
All the code (raw, rough, untested, whatever :P ) that produces the districts we discussed in this ticket is available in the codebox I linked in the previous comment. It must not be considered at all production-ready code, but a quick way to implement the feature on top of the existing VisJS release - no need to hijack in the original code or patch it.
It would be great if anyone with more time and dedication could start from that dirty implementation and improve it, and eventually understand if it can be someway integrated with the existing library.

Another example case
For a directed graph there will be source point, which have the in-degree=0. I want to group all nodes that are descendants of a source point together, and draw a border outside of them. So a graph with many source points will have many components like that. And if a node is a descendant of many source points, then it will be in the intersect of many components.
This is also asked in Stack Overflow: Bordered group of nodes in a network graph?

Another example case
For a directed graph there will be source points, which have the in-degree=0. I want to group all nodes that are descendants of a source point together, and draw a border outside of them. So a graph with many source points will have many components like that. And if a node is a descendant of many source points, then it will be in the intersect of many components.
This is also asked in Stack Overflow: Bordered group of nodes in a network graph?

This proposal would probably solve the "group all descendants together", but you would still need some tweaks and customization to correctly place the source points and to correctly implement the intersection part.

Our use case is: we have (about 10-200) projects (vertices) with dependencies (edges). Projects are organized in (about 3-10) groups. We want to show and edit project dependencies (edges). However the projects - vertices should be in a "group" bubble (rectangle), so that a user can find it quickly.
Maybe this feature could be called "opened cluster"?


Switching between tabs in browser

In the browser, going to a different tab and coming back to the current tab, triggers ResizeSensor - even though the element was not resized.
It's ok because I can filter by recognizing that the size is unchanged, but I was wondering if this behavior is expected ?

Never mind. This is an artefact of using Firefox developer console.


Remove master/slave terminology from OpenNebula

Description
Being aware of the role that language plays in naturalizing negative social constructs, structural inequalities and unfair stereotypes, this issue is aimed at removing the master/slave terminology from OpenNebula.
Use case
This is part of an internal process to find an appropriate substitute (e.g. primary/secondary) that could be used from version 5.12 onwards.
Interface Changes
This change has implications for both the source code and the project's documentation: http://docs.opennebula.io/5.11/search.html?q=slave&check_keywords=yes&area=default
Additional Context
https://en.wikipedia.org/wiki/Master/slave_(technology)#Terminology_concerns

Progress Status

[ ] Branch created
[ ] Code committed to development branch
[ ] Testing - QA
[ ] Documentation
[ ] Release notes - resolved issues, compatibility, known issues
[ ] Code committed to upstream release/hotfix branches
[ ] Documentation committed to upstream release/hotfix branches

Ok, let's change colors of figures in chess too.

I believe that you are trying to show empathy in for a cause  the least useful way possible

What else do you suggest: replace word German to Gerwoman or Gerperson, because it is not friendly to women and other sex genders?

Everyone is familiar, but IT simply isn't the right place for it.

Thank you all for sharing your opinions on this topic.

Here you have some food for thought:

Just how was it that a morally criminal social practice became the metaphor of choice for a ubiquitous phenomenon in engineering? (https://www.jstor.org/stable/40061475)

If we start speaking about masters and slaves in ways that speak only of hierarchy and erase the context of exploitation and brutality, it allows us to get a bit too close and comfortable with something we should be neither close nor comfortable with... (https://medium.com/@zookkini/masters-and-slaves-in-the-tech-world-132ef1c87504)

Honestly, my first association with master/slave terminology is BDSM, not slavery, but maybe I'm just a pervert :-)))
Maybe it's also a trap of writing technical terms in your mother tongue. For a non-native English speaker "slave" is merely a technical term and not an actual slave. :-) however I don't know if it's the only cause because I'd still vote against renaming whitelist/blacklist as Golang devs did recently, and whitelist/blacklist terms are the same in Russian...

@albert0marti the documentation link you provided show two cases:

When master/slave terminology is used to describe OpenNebula federation mode
When master/slave terminology is used to describe network interfaces in linux.

I can understand your intention to change master/slave terms in first case, especially since OpenNebula's RAFT already uses different leader/follower terminology.
But I'm not sure if we could do anything about second case, because this terminology is base for linux kernel to describe network devices state:
https://man7.org/linux/man-pages/man8/ip-link.8.html

@vitalif, I see what you mean, but I think it's important, especially for non-native English speakers (among whom I include myself), to question the English terms we use in IT and whose meaning(s) we might be taking for granted.
A couple of years ago, for instance, the Internet Engineering Task Force (IETS) discussed the use of terminology like master/slave or blacklist/whitelist, and drafted a series of strong recommendations, so IMHO this debate is relevant for any technological project: https://tools.ietf.org/id/draft-knodel-terminology-00.html#rfc.section.2 (BTW, OpenZFS has taken a similar measure just a few days ago: https://github.com/openzfs/zfs/pull/10435)
@kvaps, you are absolutely right, there are limitations imposed by the terminology still in place and being used by other third-party projects with which we have some connection and need to be referred to on our documentation. I guess we can always to do changes to the maximum extent possible, while we hope for those other projects to eventually reconsider. I see this as our small contribution as an open source community to a broader domino effect in Technology that won't necessarily take place overnight...

Well, that "domino effect" might take shorter than I thought! :D https://www.zdnet.com/article/github-to-replace-master-with-alternative-term-to-avoid-slavery-references/

Como nadie se atreve a decirtelo y a mi esta cuenta me suda la polla ya te lo digo yo. Eres un gilipollas, alberto, compañero.

Hard to see how this relates to slavery since in OpenNebula a slave can easily become the master and the other way around. Perhaps more related to BDSM @vitalif ? :smile:

I urge you to stop supporting political correctness in IT.
People that participate in such moves will hunt for more things they can get offended about tomorrow—a genuinely meaningless couch-potato movement that we must ignore at all costs. Besides, the affected group, their justification, doesn't care about it in the first place, why should we worry about it then? The best course of action, IMHO, is to either ignore them or outright close the pull request or issue.
FYI: Nearly every alternative of the master/slave terminology is offensive to various groups. I'll list a few futuristic "I'm offended" sentences below:

primary/secondary implies that second class citizens exist as well as the massive gap between poor and rich. Everyone isn't equal; the center of society is one primary thing.¹ Primary has a monopoly and will eventually exploit it to gain power over everyone else.
leader/follower implies every world war, or rather a significant figure. I don't know how they didn't catch that.
?/dependents point out that we've got a drug issue. Drug addicts depend on a drug dealer. For further information, read primary/secondary verse 1.

"...questions have resurfaced about problematic language in open source communities and code, and specifically the use of terminology like 'master' and 'slave'. This isn’t a new conversation - you can find instances where people have flagged this language’s use since the early 2000s. Despite pockets of change in a few communities throughout the years, broad progress has never occurred. (...) That must change." --> https://www.redhat.com/en/blog/making-open-source-more-inclusive-eradicating-problematic-language


This adds two functions to modify your PATH.

Both functions check to see if the directories that will be inserted
into your PATH are currently on the system.  This is good for having
one zshrc file and deploying it to myltiple enviroments.
example:
prepend_path "${HOME}/bin"
postpend_path "/usr/local/bin/heroku"

@apjanke Thanks for the feedback.
I updated the PR


Executing AtlasTexture.get_data crashes Godot

Godot version
3.4.beta.custom_build. 01ae4888e
System information
Ubuntu 21.04 - Nvidia GTX 970, Gnome shell 3.38 X11
Issue description
When executing
	var temp_variable3941 = AtlasTexture.new()
	temp_variable3941.set_atlas(StreamTexture.new())
	temp_variable3941.get_data()

Godot crashes with backtrace
core/image.cpp:2228:19: runtime error: member access within null pointer of type 'const struct Image'

================================================================
handle_crash: Program crashed with signal 11
Engine version: Godot Engine v3.4.beta.custom_build (01ae4888e938cee7e067f0aa09d1298ae40e78b8)
Dumping the backtrace. Please include this when reporting the bug on https://github.com/godotengine/godot/issues
[1] godots() [0x17cf10a] (/mnt/Miecz/godot3.2/platform/x11/crash_handler_x11.cpp:56)
[2] /lib/x86_64-linux-gnu/libc.so.6(+0x41040) [0x7f0781e12040] (??:0)
[3] Image::get_rect(Rect2 const&) const (/mnt/Miecz/godot3.2/core/image.cpp:2228 (discriminator 7))
[4] AtlasTexture::get_data() const (/mnt/Miecz/godot3.2/scene/resources/texture.cpp:967)
[5] MethodBind0RC<Ref<Image> >::call(Object*, Variant const**, int, Variant::CallError&) (/mnt/Miecz/godot3.2/./core/method_bind.gen.inc:593 (discriminator 4))
[6] Object::call(StringName const&, Variant const**, int, Variant::CallError&) (/mnt/Miecz/godot3.2/core/object.cpp:918 (discriminator 1))
[7] Variant::call_ptr(StringName const&, Variant const**, int, Variant*, Variant::CallError&) (/mnt/Miecz/godot3.2/core/variant_call.cpp:1175 (discriminator 1))
[8] GDScriptFunction::call(GDScriptInstance*, Variant const**, int, Variant::CallError&, GDScriptFunction::CallState*) (/mnt/Miecz/godot3.2/modules/gdscript/gdscript_function.cpp:1049)
[9] GDScriptInstance::call_multilevel(StringName const&, Variant const**, int) (/mnt/Miecz/godot3.2/modules/gdscript/gdscript.cpp:1184)
[10] Node::_notification(int) (/mnt/Miecz/godot3.2/scene/main/node.cpp:54)
[11] Node::_notificationv(int, bool) (/mnt/Miecz/godot3.2/./scene/main/node.h:45 (discriminator 14))
[12] CanvasItem::_notificationv(int, bool) (/mnt/Miecz/godot3.2/./scene/2d/canvas_item.h:163 (discriminator 3))
[13] Node2D::_notificationv(int, bool) (/mnt/Miecz/godot3.2/./scene/2d/node_2d.h:37 (discriminator 3))
[14] Object::notification(int, bool) (/mnt/Miecz/godot3.2/core/object.cpp:929)
[15] SceneTree::_notify_group_pause(StringName const&, int) (/mnt/Miecz/godot3.2/scene/main/scene_tree.cpp:973)
[16] SceneTree::idle(float) (/mnt/Miecz/godot3.2/scene/main/scene_tree.cpp:528 (discriminator 3))
[17] Main::iteration() (/mnt/Miecz/godot3.2/main/main.cpp:2183)
[18] OS_X11::run() (/mnt/Miecz/godot3.2/platform/x11/os_x11.cpp:3641)
[19] godots(main+0x326) [0x17c5d8c] (/mnt/Miecz/godot3.2/platform/x11/godot_x11.cpp:57)
[20] /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xd5) [0x7f0781df9565] (??:0)
[21] godots(_start+0x2e) [0x17c59ae] (??:?)
-- END OF BACKTRACE --
================================================================

This example was found by fuzzer, so I don't recommend trying understand in what situation such code could be used in real project, because such situation probably doesn't exists.
Steps to reproduce
Above
Minimal reproduction project
No response

#53157 needs additional validation for invalid API usage (CC @boruok).

oh, missed that scenario.
Need additional check for atlas data is empty. I didn't find any idea except size comparison, something like:
Ref<Image> AtlasTexture::get_data() const {
	if (!atlas.is_valid()) {
		return Ref<Image>();
	}

	// check atlas is empty
	Vector2 size = atlas->get_size();

	if (size.x == 0 || size.y == 0)
	{
		return Ref<Image>();
	}

	return atlas->get_data()->get_rect(region);
}

I think it might be sufficient to check that get_data() is valid: if (!atlas.is_valid() || !atlas->get_data().is_valid()) { return Ref<Image>(); }.
There could still be invalid combinations of atlas texture types but hopefully not ones that trigger a crash (would be worth checking how it fares if you try to make an AtlasTexture that uses an AtlasTexture as atlas, though I think we might have added an error check for that already).

@akien-mga Problem is here get_data() method cause unwanted behiavour, like crash or throwing error to debugger. It's that good?

E 0:00:01.178   texture_get_data: Condition "!texture->active" is true. Returned: Ref<Image>()
  <C++ Source>  drivers/gles3/rasterizer_storage_gles3.cpp:1009 @ texture_get_data()
  <Stack Trace> Node.gd:8 @ _ready()

so that's why i didn't used it.

That error is OK, it's not the most user-friendly but it comes from invalid API usage. The same would happen with just:
var tex = StreamTexture.new()
print(tex.get_data())

So if it should be improved that's something to improve in StreamTexture::get_data() itself, no need to prevent it in AtlasTexture::get_data() if the user set an invalid texture. What's important is that it shouldn't crash, but it's OK if it throws errors when the user code is wrong.

Why revert? Fixing the crash is easy with what I suggested.

@akien-mga  i didn't found documentation about making changes in already merged PR. So, revert and make a new PR?

No, you can simply make a new PR that fixes the bug introduced by the first PR.

@akien-mga alright, can you check PR's?


added the read customer test in test_models

added read customer in model and routes and added tests

Fixed the merge conflicts in test_models.py.


String value in RFC3339 date format is changed

Hello folks,
Having issue with string variable with value of date in RFC3339 format. Replace Token modify this string from RFC3339 to computer date time format. The final replacement has been modified to wrong format.
Example:
The source Azure DevOps variable:

Replace task with modified values

Reading variables directly from dev ops by pipeline:

I need to replace string as is written in devops variable into target without any modification (1 to 1).

Hi @MarianSimo,
Unfortunately this is not a bug from the task but from the SDK, the issue was already raised but so far no fix:
https://github.com/microsoft/azure-pipelines-agent/issues/4530
One workaround seems to set those variables as secrets.

Thank you for the answer. The secret can be a way. Thank you


move metadata to the right place

Moves src/SDKs/_metadata/apimanagement_resource-manager.txt to eng/mgmt/mgmtmetadata/apimanagement_resource-manager.txt, overwriting the older one.

Closing as the file was already deleted


Attach, FixUp Relations  and Insert scenario with Identity Not Working

Consider the following scenario:
A graph of entities is sent over the wire in serialized form without relationships, just scalar and foreign key properties  (Typical case for serializes that do not support cyclic references: IE: Microsoft Bond) in order to be inserted.
The graph is attached to the context in the Added state.
Then Entity Framework performs the Relationship FixUp.
The issue
Expected:
Entity Framework to insert the graph obeying the Identity specification.
Actual:
Exception: Cannot insert explicit value for identity column in table 'Node' when IDENTITY_INSERT is set to OFF
Repro application:
class Program
    {
        static void Main(string[] args)
        {
            //Simulate deserialising a list of entities
            var nodes = new[]
            {
                new Node {Id = -1, Name = "Root"},
                new Node {Id = -2, Name = "Child1", ParentId = -1},
                new Node {Id = -3, Name = "Child2", ParentId = -1},
                new Node {Id = -4, Name = "Child3", ParentId = -2},
                new Node {Id = -5, Name = "Child4", ParentId = -3},
                new Node {Id = -6, Name = "Child5", ParentId = -3},
            };

            using (var db = new TreeContext())
            {
                db.Node.AddRange(nodes);

                //Assert Fixup works
                Debug.Assert(nodes[4].Parent != null && nodes[4].Parent.Id == -3);

                try
                {
                    db.SaveChanges();
                    // Exception: Cannot insert explicit value for identity column in table 'Node' when IDENTITY_INSERT is set to OFF
                }
                catch (Exception ex)
                {
                    Console.WriteLine("Insert failed!");
                }
                // UGLY Workaround !!!
                foreach (var entityEntry in db.ChangeTracker.Entries().ToArray())
                {
                    entityEntry.State = EntityState.Detached;
                    entityEntry.Property("Id").CurrentValue = 0;
                    entityEntry.State = EntityState.Added;
                }

                //Assert Fixup works
                Debug.Assert(nodes[4].Parent != null && nodes[4].Parent == nodes[2]);

                try
                {
                    db.SaveChanges();
                }
                catch (Exception ex)
                {
                    Console.WriteLine(ex.ToString());
                }
            }
        }
    }

    public class TreeContext : DbContext
    {
        public DbSet<Node> Node { get; set; }

        protected override void OnConfiguring(DbContextOptionsBuilder optionsBuilder)
        {
            optionsBuilder.UseSqlServer(@"Server=(localdb)\mssqllocaldb;Database=ConsoleApp.TreeDb;Trusted_Connection=True;");
        }

        protected override void OnModelCreating(ModelBuilder modelBuilder)
        {
            modelBuilder.Entity<Node>(entity =>
            {
                entity.HasKey(e => e.Id);
                entity.Property(e => e.Id).UseSqlServerIdentityColumn();

                entity
                    .HasOne(e => e.Parent)
                    .WithMany(e => e.Children)
                    .HasForeignKey(e => e.ParentId)
                    .IsRequired(false);
            });
        }
    }

    public class Node
    {
        public Node()
        {
            Children = new List<Node>();
        }

        public int Id { get; set; }
        public string Name { get; set; }
        public int? ParentId { get; set; }
        public virtual Node Parent { get; set; }
        public virtual ICollection<Node> Children { get; set; }
    }

The workaround to detach the graph, set the id to 0 is quite ugly for this scenario.
The better approach would be for the API to be explicit whether a to perform the insert using the temporary key or not.
Further technical details
EF Core version: 1.0.0-rc2-final
Operating system:  Windows 10
Visual Studio version: VS 2015
Other details about my project setup:

@popcatalin81 You can tell EF that values are temporary, but we don't have any nice top-level API for this yet, so you have to drop down to our lower-level "internal" APIs:
using (var db = new TreeContext())
{
    db.Node.AddRange(nodes);

    var idProperty = db.Model.FindEntityType(typeof(Node)).FindProperty("Id");
    foreach (var node in nodes)
    {
        db.Entry(node).GetInfrastructure().MarkAsTemporary(idProperty);
    }

    //Assert Fixup works
    Debug.Assert(nodes[4].Parent != null && nodes[4].Parent.Id == -3);

    db.SaveChanges();
}

Keep in mind that these internal APIs may change between releases, so use only at your own risk. We will add top-level public API to do this in a future release.

Thanks @ajcvickers this is great until feature is surfaced.


UI: Autoscroll to Error Field

Description
fixes #4798

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[x] Bug fix (non-breaking change which fixes an issue)
[x] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

https://user-images.githubusercontent.com/53378650/131230082-358ac204-4925-43da-8d26-bfbe66cbd76e.mp4

@blueorangutan ui

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5200 (SL-JID-348)

@blueorangutan ui

@apurv-1 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5200 (SL-JID-356)

Hi @apurv-1 can you please fix the conflicts. thanks.

Done @sureshanaparti

Hi @apurv-1 can you please fix the conflicts. thanks.

@blueorangutan ui

@apurv-1 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5200 (SL-JID-543)

@blueorangutan ui

@apurv-1 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5200 (SL-JID-572)

Merged this as it appears this has been already tested by @borisstoyanov and others.


Integration tests should use Docker networking instead of relying on host's networking

The redis integration tests connect to redis by going out of Docker, to the host machine, then back into Docker via the exposed port, using the IP address of the host machine.
This is fragile because it might break depending on the network setup of the host machine. A more reliable way would be to use Docker networks (and just connect to redis:6379 inside the model container) or the bridge IP of the Redis container.

Judging by #118 this approach also doesn't work on Linux.


Make nodenames unique in Gossip cluster

Conflicting names in the cluster can lead to silent failures in the service discovery, routing mesh etc. When joining the cluster make sure the nodenames are unique.
Signed-off-by: Santhosh Manohar<EMAIL_ADDRESS>

LGTM

LGTM


Is there a way to merge 2 pie chart? (or use multiple datasets)

Hi guys, very nice and excellent project!
In our project we decide to make your solution to build a dashboard app, and we faced with such issue
We need to build a Pie Chart using data from 2 separate databases (actually postgres and druid), and present this data in a single Pie chart.
Is there a way to use multiple datasets (from different databases) and multiple queries to build a single chart?
Or maybe we can somehow use the results of 2 different Pie Charts?
Or maybe your app provides some interface for customizing result of SQL query which will be used in order to build a chart?
Hope you can help us to decide what should we do, thanks!

We faced ths same issue,wo want to merge multiple datasets with data from two datasource to build single chart

There's not really a way to do cross-database joins like this in Superset. This is where you'd want to get into the wide world of other tools that cater to ETL/pipelines/etc.


Valid Moves Generation Test

closes #4
closes #6

Before merging this pull request, the Perft Test needs to be run on the Test Positions and return the correct number of generated moves in all the positions.

Here is an overview of the current state of the test development, it shows whether the test yields the correct results.

Test Name
FEN
Depth 1
Depth 2
Depth 3
Depth 4
Depth 5
Depth 6
Expected Reason for the Error

En Passant White
8/2p5/8/1P6/8/8/8/K1k5 b - - 0 1
✅
✅
✅
✅
✅
❌
Pawn Promotion

En Passant Black
K1k5/8/8/8/2p5/8/1P6/8 w - - 0 1
✅
✅
✅
✅
✅
❌
Pawn Promotion

Castling
r3k2r/8/8/8/8/8/8/R3K2R w KQkq - 0 1
✅
❌
❌
❌
❌
❌
Not Undoing Moves Correctly

Starting Position
rnbqkbnr/pppppppp/8/8/8/8/PPPPPPPP/RNBQKBNR w KQkq - 0 1
✅
✅
✅
✅
❌
❌
#6


VSTS Pester test extension: Parameters containing semicolons cannot be passed to scriptfolder property

VSTS Extension you are using
VSTS Pester test extension
Where are you running it?
VSTS, agent on-premise
Version of Extension/Task
v7* (latest)
Expected behaviour and actual behaviour
A build variable is defined as follows: $files = 'foo.txt;bar.txt'
Then this variable is being passed into the extension (using a yaml build):
@{Path='.\tests\script.tests.ps1'<EMAIL_ADDRESS>Parameters=@{otherparam='$(files)'}}

In the Pester test, only 'foo.txt' get passed to it despite the parameter value being surrounded by single quotes

I'll have a look at this and see what we're doing to parse those parameters. It could be something involved in that which is dropping the extra values out, probably due to the semicolon I'd guess.
I'm guessing you want to keep the semicolon there for use within the tests?

@ChrisLGardner I created an hello-world example and sent you an invitation to your email address on your public GitHub profile.

The YAML of the task is:

- task: richardfennellBM.BM-VSTS-PesterRunner-Task.Pester-Task.Pester@7
  inputs:
    scriptFolder: '@{Path=''$(Build.SourcesDirectory)\fancypants.tests.ps1'; Parameters=@{Param1='foo.txt;bar.txt'}}'
    ForceUseOfPesterInTasks: true

The contents of fancypants.tests.ps1 in the root directory is:

Param($Param1)

Write-Verbose $Param1 -Verbose # Does not get displayed, another extension bug?
Write-Host $Param1 # RIP to a puppies

-When running it (e.g. on Hosted VS2017), then the log output is:
2018-05-08T17:52:44.5660970Z ##[section]Starting: Pester Test Runner
2018-05-08T17:52:44.5915473Z ==============================================================================
2018-05-08T17:52:44.5915674Z Task         : Pester Test Runner from Black Marble
2018-05-08T17:52:44.5915839Z Description  : Run Pester tests without the need to install Pester in with the PMModule folder or in the source repo (Using Pester 3.4.3 or 4.3.1)
2018-05-08T17:52:44.5916030Z Version      : 7.1.6
2018-05-08T17:52:44.5916136Z Author       : Richard Fennell
2018-05-08T17:52:44.5916274Z Help         : Version: 7.1.6. [More Information](https://github.com/rfennell/vNextBuild/wiki/Pester-Task/)
2018-05-08T17:52:44.5916440Z ==============================================================================
2018-05-08T17:52:44.6231634Z Preparing task execution handler.
2018-05-08T17:52:47.1289506Z Executing the powershell script: D:\a\_tasks\Pester_31ef0033-64e3-4c55-b888-f446541474a6\7.1.6\Pester.ps1
2018-05-08T17:52:55.6553466Z Executing all tests in 'D:\a\1\s\fancypants.tests.ps1'
2018-05-08T17:52:55.6554219Z
2018-05-08T17:52:55.6554731Z
2018-05-08T17:52:55.7883463Z
2018-05-08T17:52:55.7883788Z
2018-05-08T17:52:55.7904139Z Executing script D:\a\1\s\fancypants.tests.ps1
2018-05-08T17:52:55.7904413Z
2018-05-08T17:52:55.7904551Z
2018-05-08T17:52:55.7975350Z foo.txt
2018-05-08T17:52:55.7975633Z
2018-05-08T17:52:55.7975814Z
2018-05-08T17:52:55.9221612Z Tests completed in 0ms
2018-05-08T17:52:55.9222357Z
2018-05-08T17:52:55.9222597Z
2018-05-08T17:52:55.9443552Z Tests Passed: 0,
2018-05-08T17:52:55.9466132Z Failed: 0,
2018-05-08T17:52:55.9489112Z Skipped: 0,
2018-05-08T17:52:55.9515510Z Pending: 0,
2018-05-08T17:52:55.9539309Z Inconclusive: 0
2018-05-08T17:52:55.9539646Z
2018-05-08T17:52:55.9539854Z
2018-05-08T17:52:57.9446885Z ##[section]Finishing: Pester Test Runner

I would have expected to see foo.txt;bar.txt but it shows foo.txt

I've managed to refactor the code we use to parse that hashtable so it's much nice and handles more random cases too. I'll try to get it merged in today and will probably release it as part of some other fixes I was working on (possibly as 8.x due to some breaking changes I was doing).

Released as part of 7.2.1

@ChrisLGardner Thanks. I can confirm this is fixed now


gpu option for doctr

As far as I know, the only way to use doctr on gpu is by adding to(device) like this
from doctr.models import ocr_predictor, from_hub

reco_arch = from_hub('tilman-rassy/doctr-crnn-vgg16-bn-fascan-v1')
model = ocr_predictor(det_arch="db_resnet50", reco_arch=reco_arch, pretrained=True).to(device)

So there is no kw to be passed to doctr.
from img2table.ocr import DocTR

ocr = DocTR(detect_language=False, kw={"det_arch": "db_resnet50", "reco_arch": reco_arch, "pretrained": True})

Is there another way or could you add a gpu option like this?
ocr = DocTR(detect_language=False, device="cuda", kw={"det_arch": "db_resnet50", "reco_arch": reco_arch, "pretrained": True})

How to use doctr? How to train?


Cilium agent fails to install feeder rule

INFO [2019-08-03T14:04:26.767554987Z] cilium.io/agent: "Setting up base BPF datapath" subsys=daemon
ERROR [2019-08-03T14:04:28.279607007Z] cilium.io/agent: "Error while initializing daemon" error="cannot install feeder rule []: exit status 4" subsys=daemon
ERROR [2019-08-03T14:04:28.27965417Z] cilium.io/agent: "Error while creating daemon" error="cannot install feeder rule []: exit status 4" subsys=daemon

Based on discussion with @brb , this issue is fixed by https://github.com/cilium/cilium/pull/8701 .


Four Max Mean not handling Nan's correctly

The four max mean functions are pulling out Nan's before they Sum, allowing Nan's to leek into the data base.

Check with Marina, if she wants us to do the 4mm if there are lots of missing values.


docs: ApisixUpstream reference need to be updated

@tao12345666333
Hi,
discovery related fields seem missing in ApisixUpstream reference
It would be good if a spec for a discovery related fields are added.
Originally posted by @yujinchoi-94 in https://github.com/apache/apisix-ingress-controller/issues/948#issuecomment-1478807186

@tao12345666333 is this up for grabs?

no one pick up this.

@tao12345666333 hi, could assign this to me? Will fix it later.

@AuruTus sure, go for it!

assigned, thanks


Tree

Describe the requested icon
A tree. For depicting nature.
Screenshots

Thanks!

Love it. More nature and animals!

v1.3.1 adds cat, dog, fish, fish-simple, tree, tree-evergreen, and others to the nature family!


Unsupported argument validation_records in cloudflare_certificate_pack

Confirmation

[X] My issue isn't already found on the issue tracker.
[X] I have replicated my issue using the latest version of the provider and it is still present.

Terraform and Cloudflare provider version
Terraform v1.5.5
on darwin_amd64

provider registry.terraform.io/cloudflare/cloudflare v4.26.0

Affected resource(s)

cloudflare_certificate_pack

Terraform configuration files
resource "cloudflare_certificate_pack" "example" {
  zone_id                = "0da42c8d2132a9ddaf714f9e7c920711"
  type                   = "advanced"
  hosts                  = ["www.example.com"]
  validation_method      = "txt"
  validity_days          = 90
  certificate_authority  = "google"
  cloudflare_branding    = false
  wait_for_active_status = false
  validation_records = [
    {
      txt_name = "_acme-challenge-www.example.com"
      txt_value = "fixed-value-xpto"
    }
  ]
}

Link to debug output
https://gist.github.com/EdsonLuisVieira/1259dfa255dc8f32b0f6b8d51f9b9a14
Panic output
No response
Expected output
resource created with txt values defined for validation
Actual output
Releasing state lock. This may take a few moments...
╷
│ Error: Unsupported argument
│
│   on ../../../modules/cloudflare/site/main.tf line 125, in resource "cloudflare_certificate_pack" "this":
│  125:   validation_records = [
│
│ An argument named "validation_records" is not expected here. Did you mean to define a block of type "validation_records"?
╵

Steps to reproduce

apply the resource to create a new certificate using the optional argument  validation_records that exists in doc

Additional factoids
I need to create a certificate where I can define the dns entry and the txt value in advance, looking in the documentation I saw that there was an optional argument validation_records where I imagined that they were only parameters where I could customize my type, but when running the apply I receive the error that the argument is not expected, I am using the latest version of the module and would like to understand if this option works,
References
No response

this is working as intended; validation_records is a block (not an attribute as you've used) and is a computed field. you cannot set this value, only read it once the resource is populated.

I think the misunderstanding comes from the documentation not listing validation_records in the read-only section. From the documentation it looks like it could be set on resource creation.


Retarget Community Module's TargetPlatformMinVersion

RNW .72 upgrades WinUI from 2.7 to 2.8 and WinUI 2.8 requires a higher TargetPlatformMinVersion (10.0.17763.0). This breaks the following CMs that have a lower TargetPlatformMinVersion with the following error Microsoft.UI.Xaml nuget package requires TargetPlatformMinVersion >= 10.0.17763.0 (current project is 15063). We should keep track of these CM here and fix them

[x] ReactNativeWebView https://github.com/react-native-webview/react-native-webview/pull/2955
[ ] RNSensitiveInfoCPP (last commit in 2021) https://github.com/mCodex/react-native-sensitive-info/pull/378
[x] RNTrackPlayer https://github.com/doublesymmetry/react-native-track-player/pull/2010
[ ] RNTTS (last commit in 2021) https://github.com/ak1394/react-native-tts/pull/244
[x] RNPermissions https://github.com/zoontek/react-native-permissions/pull/771
[ ] RNPrint https://github.com/christopherdro/react-native-print/pull/205
[x] RNDeviceInfoCPP https://github.com/react-native-device-info/react-native-device-info/pull/1537
[ ] RNCCConfig https://github.com/luggit/react-native-config/pull/752
[x] ReactNativePicker https://github.com/react-native-picker/picker/pull/484 (already merged, need to bump package version in Gallery
[x] RNSketchCanvas https://github.com/wwimmo/react-native-sketch-canvas/pull/23
[x] Progress-view (https://github.com/react-native-progress-view/progress-view/pull/118)
[x] DateTimePickerWindows https://github.com/react-native-datetimepicker/datetimepicker/pull/757
[x] ReactNativeExpander https://github.com/microsoft/fluentui-react-native/pull/2827
[x] SliderWindows https://github.com/callstack/react-native-slider/pull/508
[x] Clipboard https://github.com/react-native-clipboard/clipboard/pull/182
[x] CheckboxWindows https://github.com/react-native-checkbox/react-native-checkbox/pull/198

unassigning this, nothing more to do than wait for Community Modules to accept PRs!


make run-local-shift fails on minishift due to the lack of helm

minishift by default doesn't ship helm (it could be installed via minishift-addons) so  make run-local-shift fails with ./scripts/package-release.sh: line 26: helm: command not found
[stirabos@t470s operator-lifecycle-manager]$ make run-local-shift
. ./scripts/build_local_shift.sh
-- Starting profile 'minishift'
The 'minishift' VM is already running.
Logged into "https://<IP_ADDRESS>:8443" as "system:admin" using existing credentials.

You have access to the following projects and can switch between them with 'oc project <projectname>':

    default
    kube-dns
    kube-proxy
    kube-public
    kube-system
  * myproject
    openshift
    openshift-apiserver
    openshift-controller-manager
    openshift-core-operators
    openshift-infra
    openshift-node
    openshift-web-console

Using project "myproject".
Sending build context to Docker daemon 53.41 MB
Step 1/6 : FROM golang:1.10
Trying to pull repository docker.io/library/golang ...
1.10: Pulling from docker.io/library/golang
05d1a5232b46: Pull complete
5cee356eda6b: Pull complete
89d3385f0fd3: Pull complete
80ae6b477848: Pull complete
94ebfeaaddf3: Pull complete
e132030a369d: Pull complete
c67c5750c788: Pull complete
Digest: sha256:a325153f1f1e2edb76a76ad789aff172b89dd6178e8f74d39ef87c04d87d1961
Status: Downloaded newer image for docker.io/golang:1.10
 ---> a4afc24299ee
Step 2/6 : WORKDIR /go/src/github.com/operator-framework/operator-lifecycle-manager
 ---> 80c03d68299f
Removing intermediate container 7a9f43d79279
Step 3/6 : COPY . .
 ---> e9063da745a2
Removing intermediate container 2a58de286bf7
Step 4/6 : RUN make build && cp bin/olm /bin/olm && cp bin/catalog /bin/catalog
 ---> Running in 421ecb380f26

building bin/catalog
building bin/olm
building bin/package-server
building bin/validator
 ---> 139d17cad118
Removing intermediate container 421ecb380f26
Step 5/6 : COPY deploy/chart/catalog_resources /var/catalog_resources
 ---> c288d3e16ea7
Removing intermediate container dcb0a8633750
Step 6/6 : CMD /bin/olm
 ---> Running in 6e79ac9a47a2
 ---> 4befc491f3d9
Removing intermediate container 6e79ac9a47a2
Successfully built 4befc491f3d9
mkdir -p build/resources
. ./scripts/package-release.sh 1.0.0-local build/resources Documentation/install/local-values-shift.yaml
./scripts/package-release.sh: line 26: helm: command not found
cp: cannot stat '/tmp/tmp.LLaaVzSG0x/chart/olm/templates/.': No such file or directory
make: *** [Makefile:63: run-local-shift] Error 1

@tiraboschi Thanks for the feedback! In this case the helm client is a prerequisite for our package-release.sh script to run (no Tiller required). We'll definitely need to add this to a prereq list for running locally somewhere in our docs.

Added doc via https://github.com/operator-framework/operator-lifecycle-manager/pull/528
Can this issue be closed now? :)


Migration to NodeJS

There are a lot of conflicts. Please make sure to merge the current master branch.

Should you delete the requirements.txt file as well?

And do we still need the setup python in the test workflow?

I wasn't sure if we plan on completing switching over to NodsJS right now, should I instead store all files related to python in a separate folder ?

Are we still using Python? I thought this pull request migrates but maybe misunderstood it.


[Feature][Document] Add example and notice about task type seatunnel

We missing task seatunnel in our document, and remember should also add task description with some detail, and give an example in the document

I add a PR in apache/dolphinscheduler-website#638, maybe someone who is interested in this feature could take it as an example

I will do this task.

I'm interested. May I take this one? QAQ

I'm interested. May I take this one? QAQ

@huahuacheng Great! Looking forward to your PR!

I'm interested. May I take this one? QAQ

@huahuacheng Looks like we have already had the docs but forgot to close this issue. However, you still could polish this doc if you like to. Thanks. https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/guide/task/seatunnel.md

Closed due to inactivity.


x/benchmarks/sweet: support for arm64

I am testing on a GCE T2A arm64 instance running Debian bullseye. So far I've encountered a few issues:

[ ] fogleman-fauxgl is either extremely slow or completely stuck. Needs more investigation.
[ ] go-build fails due to error creating systemd-run user scope: test.scope: Failed to add PIDs to scope's control group: Permission denied

cc @mknyszek

(The latter issue in particular may be a general Debian bullseye issue, rather than an arm64 issue)

@prattmic The error message when running system-run is printed in the benchmark result file, which can easily lead users to mistakenly think that the benchmark itself has failed.
Can we not print the error message of running system-run? Or are there other considerations?
Below is the result of the go-build benchmark.
`# warning: systemd-run not available: system-run failed: exit status 1
output: Failed to connect to bus: Invalid argument
journalctl output: -- No entries --
systemctl cleanup error: exit status 1
output: Failed to reset failed state of unit systemd-run-test-1706769187427737350.scope: Unit systemd-run-test-1706769187427737350.scope not loaded.
skipping cgroup wrapper...
BenchmarkGoBuildKubelet 1<PHONE_NUMBER>2 ns/op
BenchmarkGoBuildKubeletLink 1<PHONE_NUMBER>0 ns/op
`
Thank you.

I think it would be nice to print the warning once, but I agree the full output is noisy. Feel free to send a CL simplifying it.

Feel free to send a CL simplifying it.


Update openai.py

fix the bug:
File "/home/xxx/.conda/envs/xxx/lib/python3.10/site-packages/langchain_community/chat_models/openai.py", line 493, in _astream
if len(chunk["choices"]) == 0:
TypeError: object of type 'NoneType' has no len()

@danny-zhu could you provide a snippet to reproduce this?


unable to compile proto files

Summary of Bug
The make proto-gen command fails with an error
Generating Protobuf files
Generating gogo proto code
cp: can't stat 'github.com/cosmos/ibc-go/v*/modules/*': No such file or directory
make: *** [Makefile:317: proto-gen] Error 1

Version
main
Steps to Reproduce
Run make proto-gen command on main branch.

For Admin Use

[ ] Not duplicate issue
[ ] Appropriate labels applied
[ ] Appropriate contributors tagged/assigned

Hmm, this seems to be working for me... Could this be some permissions issue with the docker client?


Review/Explain buttons

Currently, if a user adds a code snippet to the chat and then clicks "Review Code" or "Explain Code" from the sidebar, those snippets are overridden by the main review/explain commands that use the user's current selection or entire document.
Instead, if there are snippet(s) already added, the review/explain buttons should be a review/explanation of those snippet(s). If there are no snippets, then the commands should operate as they currently do.

Outdated. Now requires re-adding some version of the "Review Code" and "Explain Code" buttons if desired, or just adding back in as context menu commands only.

Perhaps implement after #176 and have buttons for all/applicable/pinned shortcut actions


fixing/adding/updating deps

Fixes #166, #168
Fixes the broken build, plus fixes issues related to the following dependencies:

github.com/docker/docker

This fix removes the version tag ^1.12.1 so that the latest version is fetched from master in the source repo. This is because engine-api has been deprecated and the packages are now part of docker/docker. This fix also updates the sub-package mapping because types moved to api/types.

github.com/golang/protobuf

This fix handles an error cause by the protobuf repo's lack of semantic versioning. Based on dependency ordering, glide was populating its cache with an older version of protobuf that didn't support version 2. The fix was to manually update glide.lock and force it to use the latest commit (currently: https://github.com/golang/protobuf/tree/1f49d83d9aa00e6ce4fc8258c71cc7786aec968a).
Verification
$ glide cc && rm -rf vendor
$ glide install
$ make install

Because the build is broken for master, I'm going to merge my own PR.


updated obs defaults

@doutriaux1 @zshaheen  rstnetcre has been added.... not sure there is anything else (other than sftlf).

@gleckler1 can you just refresh me here - is there a reason we have two identical versions of the obs_info_dictionary.json in two separate places?

@doutriaux1 are you happy to review and merge this? It changes some of the default obs products..

@gleckler1 is this tweak required in v1.1.2?


Add a warning to bash script if output fails

At the moment it does nothing.
Although, I think the python code will warn, so actually this may not be necessary...

actually python already warns so unnecessary


Change OT to CRDT

This requires syncing with changes to the server
https://github.com/automerge/automerge

This didn't work out.  Maybe I'll do it another time.


Save & Commit commands

This checklist is used to make sure that common guidelines for a pull request are followed.
Related command

Added firewall policy Save&Commit commands:
az network firewall policy draft create
az network firewall policy draft update
az network firewall policy draft intrusion-detection add
az network firewall policy draft intrusion-detection remove
az network firewall policy draft intrusion-detection list
az network firewall policy rule-collection-group draft
az network firewall policy rule-collection-group draft create
az network firewall policy rule-collection-group draft update
az network firewall policy rule-collection-group draft collection add-nat-collection
az network firewall policy rule-collection-group draft collection add-filter-collection
az network firewall policy rule-collection-group draft collection remove
az network firewall policy rule-collection-group draft collection rule add
az network firewall policy rule-collection-group draft collection rule update
az network firewall policy rule-collection-group draft collection rule remove
General Guidelines

[X] Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
[X] Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
[X] My extension version conforms to the Extension version schema

For new extensions:

[X] My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Thank you for your contribution! We will review the pull request and get back to you soon.

Please fix CI issues

Please fix CI issues

fixed, can you help merging?

could you please provide your pr in the aaz repo?