Private DNS connectivity check fails for some servers

I've discovered a general problem with Private DNS on GrapheneOS. The DNS records for *-dnsotls-ds.dnscheck.grapheneos.org are all in the reserved <IP_ADDRESS>/24 range.
The problem
DNS servers with rebind protection, such as a default OPNsense installation will filter out the response IP. This causes GrapheneOS to assume DoT is not working,  even though DNS over TLS is working perfectly fine.
Possible solutions

Serve a publicly routable IP address, such as one of the GrapheneOS servers.
Check for a successful query instead of the returned IP(s)

No one should be using <IP_ADDRESS>/24 for private networks and therefore it shouldn't need rebinding protection. Contact them and ask them to stop.

Thanks, I'll dig a little deeper into the RFC and raise issues upstream.


Add Bitcoin Units to the Settings/General Tab

A radio-style control to select a bitcoin display unit should be added to the Settings/General tab.
Functional Requirements

[ ] the options are BTC, mBTC, μBTC and satoshi.
[ ] the default is BTC.
[ ] when the option is changed, any price data should be refreshed to be shown in that format (make sure cached renders, if any, don't show the old format).
[ ] the option chosen should be shown in the format appropriate to the current language.

Data

[ ] the option chosen should be saved in local storage.

See https://github.com/OpenBazaar/OpenBazaar-Client/pull/1823 for an example of this functionality.

I'll happily take this one. Looks like it's another wrinkle to the currency module, which I've worked heavily on.
I'll hold off until I get the go-ahead since I'm not sure priority-wise when I should work on this vs. something else.

Go ahead.


HLG Decoding doesn't have full results

I have trained squeezeformer in Vietnamese audios and run the decoding method in python script (recognize.py) using HLG decoding of k2-icefall but the output results are so weird:

However, the results are still fine when I try CTC greedy decoding.
Therefore, I doubt it's a mistake when builiding the HLG graph and ngram LM.
I have tried 2 versions for 3gram LM, using the train script by SRILM (in example/aishell):

LM with word tokenizer
LM with spm tokenizer

But their behaviors are nearly the same, it just output some tokens not full sentence.
When debug the hlg rescoring method with full audio chunk, the hypothesises for utterance contain few tokens in each path that why the result of later process (choose best path and decode) gives worst result?
https://github.com/wenet-e2e/wenet/blob/main/wenet/transformer/asr_model.py#L711

Can you please help to figure out the underlying reason for this bug?

@aluminumbox , any idea?

I encountered the same problem for the Persian language.
The output of the model without the language model is good, but after adding the language model, the output is not irrelevant except for a few words.
Thank you for your guidance.
I1010 13:07:47.599594 57527 params.h:155] Reading torch model exp/unified_conformer/final.zip
I1010 13:07:47.600919 57527 torch_asr_model.cc:35] Num intra-op threads: 1
I1010 13:07:48.796988 57527 torch_asr_model.cc:73] Torch Model Info:
I1010 13:07:48.796998 57527 torch_asr_model.cc:74] 	subsampling_rate 4
I1010 13:07:48.797000 57527 torch_asr_model.cc:75] 	right context 6
I1010 13:07:48.797001 57527 torch_asr_model.cc:76] 	sos 5025
I1010 13:07:48.797003 57527 torch_asr_model.cc:77] 	eos 5025
I1010 13:07:48.797004 57527 torch_asr_model.cc:78] 	is bidirectional decoder 0
I1010 13:07:48.797008 57527 params.h:197] Reading unit table welm/exp/lang/units.txt
I1010 13:07:48.811363 57527 params.h:205] Reading fst welm/exp/lang/TLG.fst
I1010 13:07:48.811384 57527 fst.h:799] FstImpl::ReadHeader: source: welm/exp/lang/TLG.fst, fst_type: vector, arc_type: standard, version: 2, flags: 0
I1010 13:08:06.386134 57527 params.h:211] Reading symbol table welm/exp/lang/words.txt
I1010 13:08:06.520176 57637 decoder_main.cc:54] num frames 344
I1010 13:08:06.520457 57637 asr_decoder.cc:104] Required<PHONE_NUMBER> get 344
I1010 13:08:06.833223 57637 asr_decoder.cc:200] Partial CTC result سگ
I1010 13:08:06.837100 57637 queue.h:570] AutoQueue: using top-order discipline
I1010 13:08:06.837770 57637 asr_decoder.cc:200] Partial CTC result سگ
I1010 13:08:06.921747 57637 asr_decoder.cc:84] Rescoring cost latency: 88ms.
I1010 13:08:06.921768 57637 decoder_main.cc:104] 0007-m_0036 Final result:
I1010 13:08:06.921773 57637 decoder_main.cc:105] Decoded 3456ms audio taken 401ms.
I1010 13:08:06.928592 57637 decoder_main.cc:54] num frames 123
I1010 13:08:06.928719 57637 asr_decoder.cc:104] Required<PHONE_NUMBER> get 123
I1010 13:08:09.942358 57637 queue.h:535] AutoQueue: using state-order discipline
I1010 13:08:10.626091 57637 asr_decoder.cc:84] Rescoring cost latency: 683ms.
I1010 13:08:10.626111 57637 decoder_main.cc:104] 0429-m_0199 Final result:
I1010 13:08:10.626116 57637 decoder_main.cc:105] Decoded 1248ms audio taken 3697ms.
I1010 13:08:10.639844 57637 decoder_main.cc:54] num frames 369
I1010 13:08:10.639951 57637 asr_decoder.cc:104] Required<PHONE_NUMBER> get 369
I1010 13:08:13.459914 57637 queue.h:570] AutoQueue: using top-order discipline
I1010 13:08:13.789427 57637 asr_decoder.cc:84] Rescoring cost latency: 336ms.
I1010 13:08:13.789448 57637 decoder_main.cc:104] 0935-m_0035 Final result:
I1010 13:08:13.789453 57637 decoder_main.cc:105] Decoded 3712ms audio taken 3149ms.
I1010 13:08:13.796512 57637 decoder_main.cc:54] num frames 185
I1010 13:08:13.796602 57637 asr_decoder.cc:104] Required<PHONE_NUMBER> get 185
I1010 13:08:22.201333 57637 queue.h:570] AutoQueue: using top-order discipline
I1010 13:08:24.385641 57637 asr_decoder.cc:84] Rescoring cost latency: 2188ms.
I1010 13:08:24.385661 57637 decoder_main.cc:104] 1613-m_0013 Final result:


bug: Publish summary only on commit.

@dheerajdlalwani can you please provide some more details about the issue?
If possible, please include an example.

This was an issue that you had asked to be raised, @KartikSoneji. So both @dheerajdlalwani and you will have to try to remember the context.
If the context escapes both, one of y'all please close this issue.
PS: Was this to prevent publishing in the PR workflow? That was (finally) fixed in 5d8cd0788b428e2adad7c06e1af074da1c91aa46. If so, please close this issue.

I can't remember what this issue was for, @dheerajdlalwani or @SirusCodes let me know if you do otherwise let's close this.

I'm totally out of loop of this issue. My wild guess would be to run action only if any summary or image is added or updated.
@dheerajdlalwani correct me if I'm wrong

Publish summary only on commit

When else are we changing publishing it?

Closed this as context of the issue is lost.


Fix k-alpha for expected disagreement equals 0

Fixes issue #3264 and adds 2 test cases.
Issue description:
The number of labels is considered before the number of valid items is determined. There is cases (s. below) where removing items with less than two annotation also reduced the number of labels considered. Hence, we have to check again after checking for valid labels if there's only one label present which means the annotators totally agree. Otherwise, we can run in a division by zero problem.
Test case description:
Per definition the expected disagreement only takes into consideration items where at least 2 coders have annotated. In case of a following dataset:
        data=[
            ('coder1', '1', 1),
            ('coder2', '1', 1),
            ('coder1', '2', 2)]

what is actually taken into consideration is
        data=[
            ('coder1', '1', 1),
            ('coder2', '1', 1),

Hence, this should return k_alpha = 1.0.

Thanks @vera-bernhard


fix: Logic for naming objects at destination

What this PR changes/adds
This PR modifies the logic to decide what will be the name of the file/s to be saved on sink side.  Now the sink side decides the name of the file/s based on the number of existing parts in a transfer and does not rely anymore in blobPrefix/blobName property.
Why it does that
The logic was modified since the sink does not know how many files will be transferred  in a flow request. And when multiple files was transferred using the property blobName in the flow request it does override on sink side. But not anymore.
Linked Issue(s)
Closes #169

my proposal was to have an "injectable" component, so that DestinationBlobName should be not static, have folderName and blobName as fields and the getDestinationBlobName should take only the partName and the partsSize. It would be instantiated in the data sink factory and passed to the data sink.
This way you could move the tests about the way the blob name is build to that class, and in the data sink test just instantiate it as a mock and verify the collaboration

I did my best to do what you proposed  😊


change note

Can one of the admins verify this patch?

Pull Request Test Coverage Report for Build 1827

0 of 0   changed or added relevant lines in 0 files are covered.
27 unchanged lines in 10 files lost coverage.
Overall coverage decreased (-0.2%) to 61.513%

Files with Coverage Reduction
New Missed Lines
%

core/client/client_manager.go
2
65.31%

core/loadbalancer/strategy.go
2
60.0%

core/server/options.go
2
50.0%

eventlistener/lager_event_listener.go
2
0.0%

core/router/cse/router_manager.go
2
71.11%

pkg/scclient/client.go
2
57.71%

core/config/key_generator.go
3
30.61%

core/handler/tracing_handler.go
3
0.0%

core/registry/util.go
4
64.29%

core/lager/logrotate.go
5
36.74%

Totals

Change from base Build 1826:
-0.2%

Covered Lines:
5319

Relevant Lines:
8647

💛  - Coveralls


cant see graph for country

how do i access graph??
Also why some countries have negeative figures in recorded deaths

you can access graph in this section
Screenshot 2020-03-31 00.16.15

and the negative value will be fixed very soon

thanks for the help... you can delete this issue now since youve solved
it.. so that i the number of issues here reduces..''thank you
On Mon, Mar 30, 2020 at 5:18 PM Fajar Ulin Nuha<EMAIL_ADDRESS>wrote:

and the negative value will be fixed very soon
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/rizmaulana/kotlin-mvvm-covid19/issues/51#issuecomment-606129516,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ANO5MDSHLWO7JXBET3HR2VLRKDH4RANCNFSM4LWKNEEQ
.

Sir can i contract you to build the following for me??  How much will you
charge me?
I can provide you with the Instagram clone. And I need these following
features.. how much will you charge?

When user is posting video, give him option of selecting "Public" or
"Private".. Where Public Means the post will be accessible to everybody
even if someone is not following him. (Like how the app currently is).....
And "Private" will mean you will have to follow the person before the
private video will become visibile to his followers on TL or profile that
private post of the user for you to play and watch..

Create a points system where all users pay money through google pay in
order to get points..

Each user will have a chance to choose how many points he wants to
charge other users who want to follow him and gain access to all his
private contents as explained in point 1 above..

So that if i want to follow you and your charge is "100points", i will need
to have 100 points in my account first in order for me to be able to follow
you and access your content.. And the users who got followed will also have
that 100 points added to his account.. So he will have +100 points

When you follow someone, at the end of every 30 days, the same amount of
points will be deducted from your points bank in order for you to continue
being his follower.. If your available points is less than what the person
charges for followers, then you will automatically be made to unfollow
him.. (I guess this particular feature can be done with a cron job that
works on server side API or something)

On Tue, Mar 31, 2020 at 3:43 AM Fajar Ulin Nuha<EMAIL_ADDRESS>wrote:

Closed #51 https://github.com/rizmaulana/kotlin-mvvm-covid19/issues/51.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/rizmaulana/kotlin-mvvm-covid19/issues/51#event-3181397980,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ANO5MDUGGFWG4BFKITFID6LRKFRF7ANCNFSM4LWKNEEQ
.

How do I change the country province daily stats to from Indonesia to my
own country???
On Monday, March 30, 2020, Fajar Ulin Nuha<EMAIL_ADDRESS>wrote:

you can access graph in this section
[image: Screenshot 2020-03-31 00 16 15]
https://user-images.githubusercontent.com/15099703/77941795-e9de6e80-72e4-11ea-9ac8-14594e7f6113.png
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/rizmaulana/kotlin-mvvm-covid19/issues/51#issuecomment-606129100,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ANO5MDTYM6LXE2QTEKY5C2DRKDHZPANCNFSM4LWKNEEQ
.


Name test target after repo to make it unique.

everest-core cannot build with tests (BUILD_TESTING=ON) due to submodules having generic names that collide when CMake runs.
This change makes the test target for everest-framework unique by naming it after the repo,  a pattern that can be followed for all repos.
NOTE: This change does not enable automated builds and tests, as there are other PRs to handle that work.

@shankari Here's a minor change to review.

Hi @gberardi-pillar, thanks for your contribution.
IMO, it's a good idea to prefix the tests-names.

To be clear, do you mean change the test target name from ${PROJECT_NAME}tests to tests${PROJECT_NAME}? If that is the norm, I can change it.

However, I think the root-cause is that BUILD_TESTING is used in all dependencies, too. So when you activate it here (in everest-framework), then it's activated also in many/all(?) dependencies. And then the clash happens.
Is it intended that BUILD_TESTING is used generic in all repos? @hikinggrass @andistorm @a-w50 (Note for myself: If so, revert it in this PR)

BUILD_TESTING is the variable used by CTest, and so I presume that we want to keep that standardized: https://cmake.org/cmake/help/latest/module/CTest.html
Now, there might be some discussion about how to handle testing overall. For instance, if I build everest-framework and run its tests, should doing so also run the tests of its dependencies, which makes sense since I am also building those dependencies, or should I trust that those dependencies ran their own tests before they reached the point of being used by a parent repo and have some way of indicating that the unit tests I want to run are exclusively the current project in that repo?
But for now, presuming that we are building all of the code, as C++ generally wants all code modules to be compiled with the same flags, I think it makes sense to run all of the tests with it, and setting BUILD_TESTING=ON in a parent module should run the tests in all submodules as well.

Hi,
this PR is quite similar to  #137 , maybe we can use that one instead of this one.

Hi,
this PR is quite similar to #137 , maybe we can use that one instead of this one.

That PR is a draft (so I don't know how long it will be before it is in a state to actually be reviewed), and it is supposed to be fixing an issue with a config variable being null (and so seems to be doing too much). This PR is more specific to changing the test target name.

@gberardi-pillar

IMO, it's a good idea to prefix the tests-names.

To be clear, do you mean change the test target name from ${PROJECT_NAME}_tests to tests_${PROJECT_NAME}? If that is the norm, I can change it.

No, just like you did, i.e.  PROJECT_NAME_tests. I just wanted to support that approach :+1:  Sorry for the confusion.
With prefixes you can see at first step which file belongs to which project. I don't see a use-case where a sorting by tests_... is needed. But perhaps someone else more used to the CMake stuff. E.g. @a-w50 @hikinggrass
You mentioned (in the mailing-list) https://cliutils.gitlab.io/modern-cmake/chapters/testing.html. That looks like a good document for best-practices. In there, it also uses the prefix-approach.
So I would say it's good to go :+1:

Let's discuss in general at

https://github.com/EVerest/EVerest/issues/129

I see that there is a longer-term issue, but it is generally in line with this approach and is primarily tracking its application to multiple repos. So let's get this merged and get the ball rolling on additional changes!
I do note that the "Bazel Build" workflow is currently broken although the failure does not seem to be related to this change.
@golovasteek you last committed the bazel build CI; is there a plan to fix the action?

I do note that the "Bazel Build" workflow is currently broken although the failure does not seem to be related to this change.
@golovasteek you last committed the bazel build CI; is there a plan to fix the action?

I've fixed the bazel-build yesterday, it should work after rebase onto main.


Website's Typeface Improvement

The website design is nice, but it can be improved by making font-family changes. I believe it will add a very attractive change in the overall design of the website.
I want to work on this issue as a part of GSSOC-23.

assigned @iamRabia-N 📌


Power BI ERROR

ERROR
Details: "OData: The feed's metadata document appears to be invalid. Error: A supported MIME type could not be found that matches the content type of the response. None of the supported type(s) 'application/xml' matches the content type 'application/json'."

Hi @tolgatasci, I wasn't able to immediately reproduce this issue. Are you using http://localhost:8000/odata or similar as the feed URL for PowerBI ?

it like this

Something appears to be intercepting how the Accept header is being used. No matter what header I use, http://mercedes.remondis-tr.com/odata/$metadata always returns application/json. Is something in the server configuration forcing the Accept header to be application/json ?

it really was. My fault, thanks.


New UI Tab Bar issues

Old UI:

New UI:

Issues:

Old UI tabs look more modern, brighter, rounded corners, better colors
Old UI selected tab is very clear. Here there is confusion as to which tab is selected
Old UI tab increases as required. New UI tab size is fixed and overflow goes down (not desired)
Old UI allowed lots of circuits, tabs overflowed to next line if required. New UI doesn't allow circuits beyond tab bar length.

@abstrekt please check this. Thanks!

@satu0king if this issue is open for everyone then I would like to work on this.

satu0king Is it possible that I can contribute to this issue too?

@dipanshparmar , @Just-A-Pixel , check new_UI branch, @abstrekt has fixed it. However, you can try and make it Better.

@satu0king yeah! Sure 🙂


Add hints for grains test (#234)

This is to address #234 (adding hints for exercises)
@ErikSchierboom This was inspired by the work you did on the Scala track here. Is this what you had in mind? If so, then I'll try to add some more as well.

This is precisely what I had in mind! Thanks a ton. 🎉
I'll work on updating the list of exercises that I feel could use a hint.

Great, thanks for your precise descriptions!


How to get data from layer

I 'm using "obj1.layer.mask" but it false some cases
Mask {
file:
File {
data: <Buffer 38 42 50 53 00 01 00 00 00 00 00 00 00 03 00 00 19 2a 00 00 05 ef 00 08 00 03 00 00 00 00 00 5b 5f 52 38 42 49 4d 04 04 00 00 00 00 00 97 1c 01 5a 00 ... >,
pos: 100752008 },
top: -1584,
right: 1519,
bottom: 4858,
left: 0,
size: 20,
width: 1519,
height: 6442,
relative: false,
disabled: false,
invert: false,
defaultColor: 255,
flags: 0 }

Im closing this for now as it is quite an old issue. If @hieulq0508g still has this question, please open a new issue for it and it will be looked at.


Appstudio update test-custom-default-branch-cwsi

Pipelines as Code configuration proposal
To start the PipelineRun, add a new comment with content /ok-to-test
For more detailed information about running a PipelineRun, please refer to Pipelines as Code documentation Running the PipelineRun
To customize the proposed PipelineRuns after merge, please refer to Build Pipeline customization

Pipelines as Code CI has failed.There was an error creating the PipelineRun: test-simple-build-nyrh-on-pull-request-
creating pipelinerun test-simple-build-nyrh-on-pull-request- in namespace build-e2e-xzwi-tenant has failed.
Tekton Controller has reported this error: the namespace of the provided object does not match the namespace sent on the request

Pipelines as Code CI has failed.There was an error creating the PipelineRun: test-annotations-gcoj-on-pull-request-
creating pipelinerun test-annotations-gcoj-on-pull-request- in namespace build-e2e-xzwi-tenant has failed.
Tekton Controller has reported this error: the namespace of the provided object does not match the namespace sent on the request

Pipelines as Code CI has failed.There was an error creating the PipelineRun: test-simple-build-lqle-on-pull-request-
creating pipelinerun test-simple-build-lqle-on-pull-request- in namespace build-e2e-xzwi-tenant has failed.
Tekton Controller has reported this error: the namespace of the provided object does not match the namespace sent on the request

Pipelines as Code CI has failed.There was an error creating the PipelineRun: test-simple-build-mcmm-on-pull-request-
creating pipelinerun test-simple-build-mcmm-on-pull-request- in namespace build-e2e-xzwi-tenant has failed.
Tekton Controller has reported this error: the namespace of the provided object does not match the namespace sent on the request

Pipelines as Code CI has failed.There was an error creating the PipelineRun: test-annotations-yrqk-on-pull-request-
creating pipelinerun test-annotations-yrqk-on-pull-request- in namespace build-e2e-xzwi-tenant has failed.
Tekton Controller has reported this error: the namespace of the provided object does not match the namespace sent on the request

Pipelines as Code CI has failed.There was an error creating the PipelineRun: test-simple-build-ufgi-on-pull-request-
creating pipelinerun test-simple-build-ufgi-on-pull-request- in namespace build-e2e-xzwi-tenant has failed.
Tekton Controller has reported this error: the namespace of the provided object does not match the namespace sent on the request

Pipelines as Code CI has failed.There was an error creating the PipelineRun: test-annotations-vchz-on-pull-request-
creating pipelinerun test-annotations-vchz-on-pull-request- in namespace build-e2e-xzwi-tenant has failed.
Tekton Controller has reported this error: the namespace of the provided object does not match the namespace sent on the request

Pipelines as Code CI has failed.There was an error creating the PipelineRun: test-simple-build-wadk-on-pull-request-
creating pipelinerun test-simple-build-wadk-on-pull-request- in namespace build-e2e-xzwi-tenant has failed.
Tekton Controller has reported this error: the namespace of the provided object does not match the namespace sent on the request

Pipelines as Code CI has failed.There was an error creating the PipelineRun: test-annotations-dtnt-on-pull-request-
creating pipelinerun test-annotations-dtnt-on-pull-request- in namespace build-e2e-xzwi-tenant has failed.
Tekton Controller has reported this error: the namespace of the provided object does not match the namespace sent on the request

Pipelines as Code CI has failed.There was an error creating the PipelineRun: test-annotations-mijr-on-pull-request-
creating pipelinerun test-annotations-mijr-on-pull-request- in namespace build-e2e-xzwi-tenant has failed.
Tekton Controller has reported this error: the namespace of the provided object does not match the namespace sent on the request

Pipelines as Code CI has failed.There was an error creating the PipelineRun: test-simple-build-nwtb-on-pull-request-
creating pipelinerun test-simple-build-nwtb-on-pull-request- in namespace build-e2e-xzwi-tenant has failed.
Tekton Controller has reported this error: the namespace of the provided object does not match the namespace sent on the request

Pipelines as Code CI has failed.There was an error creating the PipelineRun: test-simple-build-uqzm-on-pull-request-
creating pipelinerun test-simple-build-uqzm-on-pull-request- in namespace build-e2e-xzwi-tenant has failed.
Tekton Controller has reported this error: the namespace of the provided object does not match the namespace sent on the request

Pipelines as Code CI has failed.There was an error creating the PipelineRun: test-simple-build-imul-on-pull-request-
creating pipelinerun test-simple-build-imul-on-pull-request- in namespace build-e2e-xzwi-tenant has failed.
Tekton Controller has reported this error: the namespace of the provided object does not match the namespace sent on the request


Update availability-group-manually-configure-multiple-regions.md

Although the doc uses VNet-to-VNet VPN for connectivity, some customers use Global VNet peering and select Basic Load Balancers. This configuration will stop connectivity to the listener in a remote region.
Added additional point to LB selection for clarity.

@PhilB-MSFT : Thanks for your contribution! The author(s) have been notified to review your proposed change.

awesome, thanks @PhilB-MSFT ! #sign-off


Write e-Link documentation

Enrich NIF content with predefined query templates (just implemted in the pipeline tutorial)
Built-in templates for common use cases
Secured REST endpoint to manage templates
Exploring a resource against a SPARQL or RDF endpoint
FREME internal SPARQL and LDF server

covered and documented all points.
However creation/updata/removal of a template is not working due to https://github.com/freme-project/e-Link/issues/67
@jnehring please check

Nice work, thank you. two smaller comments.

It might be useful to integrate a link to the filtering article to the section "simplify output"
Add a link to the authentication article in the section to the "Paste your token." part of the create template section.

done.

Nice, thanks


fixes issues and improved components

Changes:

Fixes previous issues
Layout supports more types of content
Layout supports more types of appbar


Trigger graceful NetworkManager shutdown in

Describe the feature
we already have the relevant logic to gracefully disconnect peers:
https://github.com/paradigmxyz/reth/blob/86f12b7f535b649b4b78e4881db106c96d0d6114/crates/net/network/src/manager.rs#L605-L612
and usually the network is polled like:
https://github.com/paradigmxyz/reth/blob/86f12b7f535b649b4b78e4881db106c96d0d6114/crates/net/network/src/manager.rs#L956-L957
which drops the network on completion, we can gracefully shutdown the network before we invoke the hook:
https://github.com/paradigmxyz/reth/blob/86f12b7f535b649b4b78e4881db106c96d0d6114/crates/net/network/src/manager.rs#L973-L973
TODO

extract shutdown logic into a standalone function
call this right before the shutdown_hook is invoked

Additional context
No response

I'd like to take this up

Ah apologies @varun-doshi I had an old instance of this issue open and didn't see you had this assigned

Wow...okay


chore(renovate): Reconfigure config location

Using npm packages for hosting renovate config is deprecated

:tada: This PR is included in version 1.1.0-rc.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.1.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


 X consists of a total of 3 subpasses (S1, S2, S3), each rendering consecutively to a color attachment C1, C2 and C3, and resolving to resolve attachments R1, R2 and R3 (one per subpass).
Trick here is that R1, R2 and R3 all point to the same 2D array image, but - at the same time - it's a unique, nonoverlapping slice. In other words, R1 renders to slice 0, R2 renders to slice 1 and R3 gets slice 2.
Core validation layer doesn't seem to enjoy this. It appears that ValidateCmdBufImageLayouts() does not recognize the fact that intra-subpass image layout transitions occur at image subresource level, instead of image level. This leads to a weird validation error which claims that:
Cannot submit cmd buffer using image (0x5571ac0) [sub-resource: aspectMask 0x1 array layer 0, mip level 0], with layout VK_IMAGE_LAYOUT_UNDEFINED when first use is VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL.

FWIW, each resolve attachment uses an VkAttachmentDescription::initialLayout of VK_IMAGE_LAYOUT_UNDEFINED and VkAttachmentDescription::finalLayout of VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL, as well as VkSubpassDescription::layout value of VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL.
As usual, I have a repro available hidden in my cuff, if an executable would be of help.

I forgot to add: this is for device instances, created with KHR_maintenance1 extension enabled.

Turns out the image actually was a 3D image and the image views were 2D or 2D array, so that validation error actually makes sense. Yay. :)

Heh!  Keep 'em coming.

On another note, I think I've come across a use case where the same error gets reported, even though it shouldn't.
The spec has the following language:
When the VkImageSubresourceRange structure is used to select a subset of the slices of a 3D image’s
mip level in order to create a 2D or 2D array image view of a 3D image created with
VK_IMAGE_CREATE_2D_ARRAY_COMPATIBLE_BIT, baseArrayLayer and layerCount specify the first slice
index and the number of slices to include in the created image view. Such an image view can be used as
a framebuffer attachment that refers only to the specified range of slices of the selected mip level.

**However, any layout transitions performed on such an attachment view during a render pass instance
still apply to the entire subresource referenced which includes all the slices of the selected mip level.**

Now, let's say we have two 2D array image views, created off the same 3D image:

Image view A encapsulates slices 0 to 3 inclusive of the parent image
Image view B encapsulates slices 1 to 2 inclusive of the parent image

Frame 0 uses a renderpass, whose (only) subpass renders to A. InitialLayout = UNDEFINED, finalLayout = layout = COLOR_ATT_OPTIMAL. The renderpass is followed by an image barrier which transitions the whole image (ie all slices) from COLOR_ATT_OPTIMAL to TRANSFER_SRC_OPTIMAL.
Frame 1 uses a renderpass, whose (only) subpass renders to B. InitialLayout = UNDEFINED, finalLayout = layout = COLOR_ATT_OPTIMAL. The renderpass is again followed by the same barrier as above.
I'm seeing the core validation layer cry the following out in terror when submitting cmd buffers related to frame 1:
Cannot submit cmd buffer using image (0x13f408c0)  [sub-resource: aspectMask 0x1 array layer 0, mip level 0], with layout VK_IMAGE_LAYOUT_TRANSFER_SRC_OPTIMAL when first use is VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL.
Drawing 2x frame 0 in a row does not lead to the error above.
Drawing 2x frame 1 in a row gives:
Cannot submit cmd buffer using image (0x4e37c50) [sub-resource: aspectMask 0x1 array layer 0, mip  level 0], with layout VK_IMAGE_LAYOUT_UNDEFINED when first use is  VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL.
My understanding of the language above marked with ** is that the initial->layout transition of a 2D array attachment whose parent image is a 3D image transfers all slices of the 3D image at once, meaning the errors do not make much sense.

@DominikWitczakAMD are there corresponding CTS cases for these unusual usages?

@chrisforbes : As strongly as I'd like to refrain from saying that, I doubt that :-( This one came afloat during our internal testing. I can share a repro if it would be of help.

I don't grok this completely but I think it's (at least partially) fixed by PR #2408.  I'm closing it based on that  general intuition alone.  @DominikWitczakAMD , if it reappears please re-open this issue or create a new one and assign to me.

Jumped the gun closing this one - found a problem with recording 3D image layout via a 2D imageview.  Re-opening and will close with a PR.


[Feat]: want to add a Contact Us from and implement the faciality to automatically sent message to the owner's email when the user is submitted the message

Is your feature request related to a problem? Please describe.
to contact owner by user
Describe the solution you'd like.
using email.js
Describe alternatives you've considered.
none
Additional context.
none
Show us the magic with screenshots
i will attached it with my PR
Checklist

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[X] I want to work on this issue. (optional)

Similar issue exists and already assigned. closing this one, kindly look for other issues.


Swan Account and xPub

Please use this for reference: https://github.com/bithyve/internal-docs/blob/master/Technical Documents/Swan-Hexa.pdf
Create a new xPub for Swan Account and save it with swan account data
Please use swan branch
There are comments where code needs to be added.
Saving data for Swan account: https://github.com/bithyve/hexa/blob/c5c8e68213bb760d67f5738c70e74db21aa5808e/src/store/sagas/swan.ts#L33-L48
Basd on above changes, check if Swan account is created: https://github.com/bithyve/hexa/blob/c5c8e68213bb760d67f5738c70e74db21aa5808e/src/store/sagas/swan.ts#L76-L90
and
https://github.com/bithyve/hexa/blob/swan/src/store/sagas/swan.ts#L93-L110
and finally saving the latest status of the swan account:
https://github.com/bithyve/hexa/blob/swan/src/store/sagas/swan.ts#L147-L152

The details of this issue have been modified slightly but this is still relavent.

Deleting this and creating a new one: https://github.com/bithyve/hexa/issues/3217


Help on setting up encrypted OpenSSL TLS/SSL connections

Is your feature request related to a problem? Please describe.
Setting up some client side mitigation, adjusting static_file_headers is easily done with:
"static_file_headers":  [
  {"name": "X-Content-Type-Options", "value":"nosniff"},
  {"name":"X-Frame-Options", "value":"DENY"},
  {"name":"Content-Security-Policy", "value":"default-src https: *.example.com data: 'unsafe-eval' ws: ; style-src https: 'unsafe-inline'; script-src https: *.example.com api.trusted-third-party.com 'unsafe-inline'; media-src 'none'; font-src https: *.example.com fonts.googleapis.com fonts.gstatic.com ; img-src https: *.pixyrouge.com data:"},
{"name":"Strict-Transport-Security","value":"max-age=63072000; includeSubDomains; preload"}
]

Next logical steps will be Perfect Forward Secrecy, OCSP stapling ...
but here I couldn't find any hints, in the docs, loooking at source code
I found trantor TcpConnectionImpl.cc but how user would extend it?
or am I missing something?
Describe the solution you'd like
something in the like:
https://ssl-config.mozilla.org/#server=nginx&version=1.17.7&config=modern&openssl=1.1.1d&guideline=5.6
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

Thanks for your feature request. It would be indeed beneficial if we could provide better security integration.
This is (in a general manner) also related to #671, but we’ll have to discuss (I would prefer IRC) which approach to take:

Implement security related features in the framework (crypto, hashing, OCSP, …).
Add a dependency to OpenSSL or another security framework.

Thanks for your feature request. It would be indeed beneficial if we could provide better security integration.
This is (in a general manner) also related to #671, but we’ll have to discuss (I would prefer IRC) which approach to take:

Implement security related features in the framework (crypto, hashing, OCSP, …).
Add a dependency to OpenSSL or another security framework.


Cache - broken transaction caches

Certain caches currently marked 'perma cache' need a lower caching level.
For example eth_getTransactionByHash has a block reference and will return with (incomplete information) while still pending. Once its mined into a block the block reference is added but we've already cached the result. Also note that the block reference could change at any time due to forks.

Thinking about this. Is there any way to write good tests for this? My first reaction is to add a "pause" feature into ethereumjs-testrpc which will pause transaction processing and return pending results until processing is started back up again (this implies that we'd use ethereumjs-testrpc's as a provider for these tests).

very easy to test, just return a json blob for the tx without a block.
doesn't require a vm or anything approximating a full node.
The result looks like this when it does not yet have a block:
{
    "id": 1,
    "jsonrpc": "2.0",
    "result": {
        "hash": "0x8ea908ca2d8bb2b4b45c7311def60c4e4c735a7c6e851f1ed75e5d4a64330eb2",
        "nonce": "0xd",
        "blockHash": null,
        "blockNumber": null,
        "transactionIndex": null,
        "from": "0xb1cc05ab12928297911695b55ee78c1188f8ef91",
        "to": "0xfbb1b73c4f0bda4f67dca266ce6ef42f520fbb98",
        "value": "0xddb66b2addf4800",
        "gas": "0x5622",
        "gasPrice": "0xba43b7400",
        "input": "0x"
    }
}

FYI: These three tests...
https://github.com/MetaMask/provider-engine/blob/master/test/cache.js#L9
Are actually only one test being run three times, because of this line:
https://github.com/MetaMask/provider-engine/blob/master/test/cache.js#L46
Although the payload is different for each call to cacheTest, cacheTest hardcodes the payload that's sent to cacheCheck, making each call to cacheTest functionally the same. The tests fail when line 46 is set to pass the correct payload to cacheCheck.


Cursor in script editor mode (flux) cannot go to end of the line

Hi all,
System:
-Linux mint virtual machine (6 xeon cores, 12gb memory)
-telegraf, mqtt broker, influxdb 2.0 and grafana all latest versions recently (+/- 3 weeks) installed on the VM
BACKGROUND: For the past couple of weeks I have been learning up on the entire flux quering in my influxdb 2.0 database (I have some MQTT feeds from my solar production and my energy meter). That has been working beautifully and managed to get several sorts of math calculations / joins etc.
ISSUE: Now my problem, yesterday, when adding a new cell to my panel (in influxdb 2.0), suddenly the cursor in the script editor mode inside the querying field lagged 1, 2 or 3 characters behind, meaning that i cannot select until the end of each row and when I insert a character, it does not get inserted at the place of the cursor but 1 to 3 places behind my cursor. You can also see visually that, the further you go down each line, the cursor is not aligned with the text anymore (cfr pictures below).
I then checked my other cells that were working fine up to that moment, and the issues also presented it on the other cells. The issue did not go away when deleting the cell I was working in. It was also present when editing on a different machine and after restarting the virtual machine, or after restarting influxdb.
The issues is not constant for each line and even not within one line of text (the first characters of each line typically do not seem to have the issue).
Below I have inserted a picture of a piece query, before and after a dash, at the place of the cursor.

I really hope someone can assist with this issue, because it is really hard working in this way.
Thank you for reading!
KR,
Ben

@desa or @bthesorceror either of you have ideas on this one?

@blvermeu which browser is this in? We have https://github.com/influxdata/influxdb/issues/18159 and https://github.com/influxdata/influxdb/issues/18026

I'll bump this is priority because it seems like people are hitting it fairly frequently

Hi all,

@blvermeu which browser and OS are you using? We have #18159 and #18026
The issue is present on windows 10, on 3 different computers, using chrome (Version 80.0.3987.132 (Official Build) (64-bit))
The issue is not present on linux mint, using either chrome or firefox.
Internet explorer does not seem to work on any computer.

Hopefully this can be sorted out, because very difficult to edit in this mode! :-)
Thank you all,
kind regards,
Ben

duplicate of https://github.com/influxdata/influxdb/issues/18026


LargeTransactionTest framework refactor + large randomized GC tests

The framework we used to test concurrency control is adpated for GC tests as well.
Caveat: It is too expensive to test GC for a long period in the current framework because of the extra book-keeping we do for correctness checks. We don't have to check correctness only at the end though, so I could technically put in a producer-consumer model and fix that.
Will probably fix that in a different PR. When that is done, this thing can in theory run forever.

Coverage increased (+2.6%) to 96.825% when pulling d9a1c89ab7b73bb49ba78200621b306fdeda415c on tianyu-gc-tests into d017f4d189ede45b85f1274482608014f27c6554 on master.


Hangs when resolving against Artifactory with auth

Hi.
Coursier does not cope with dynamic revisions which do not end with a numeric part before the +, e.g. like "1.2.3-rc-+".
Up until version 1.1.0-M13-4, this resulted in a resolution error, but starting with 1.1.0-M14, it just hangs.
~Here's a minimal project to reproduce: https://github.com/avdv/coursier-hang~
edit: The reproducer is not really significant, since it only hangs when I have a resolver configured which requires credentials.

Note, originally brought up here: sbt/sbt#4700 when I was trying SBT 1.3.0-RC1.

Was going to make an issue for this, but I get the same problem with our private Artifactory repo. As mentioned, 1.1.0-M13-4 works ok but M14 hangs.
We are using open-source Artifactory 6.10.0 with credentials required. We are specifying credentials in a credentials.properties file and importing them with:
credentials += Credentials(file("credentials.properties"))

Some related things were fixed in coursier 1.1.0-M14-3 (used since sbt-coursier 1.1.0-M14-2). This should have addressed some possible infinite redirection loops, the redirection code could have gone into.
Did you try with a more recent plugin?

Yes, works for me now, with sbt-coursier-1.1.0-M14-4. Thank you!

Ok, closing this issue then.

So sorry, you might want to reopen. It was working for a bit but I came across a case where it hung again. Same problem with a private artifactory repo.

@countfloyd A repro would be welcome then… Like something where we launch an artifactory like
$ docker run -it --rm -p 8081:8081 docker.bintray.io/jfrog/artifactory-oss:6.10.3

then steps to set it up, with artifacts that make resolution hang.

Hi.
The problem shows when you try to resolve a non-existent artifact. And coursier does not just hang, it actually does something -- it loops between 401 and 404:
/project-ivy-virtual/com.sample/common-lib_2.12/19.23.0-does-not-exist/ivys/ivy.xml.sha1 401
GET /project-ivy-virtual/com.sample/common-lib_2.12/19.23.0-does-not-exist/ivys/ivy.xml 401
GET /project-ivy-virtual/com.sample/common-lib_2.12/19.23.0-does-not-exist/ivys/ivy.xml.sha1 401
GET /project-ivy-virtual/com.sample/common-lib_2.12/19.23.0-does-not-exist/ivys/ivy.xml.sha1 404
GET /project-ivy-virtual/com.sample/common-lib_2.12/19.23.0-does-not-exist/ivys/ivy.xml.sha1 401
GET /project-ivy-virtual/com.sample/common-lib_2.12/19.23.0-does-not-exist/ivys/ivy.xml 401
GET /project-ivy-virtual/com.sample/common-lib_2.12/19.23.0-does-not-exist/ivys/ivy.xml.sha1 404
GET /project-ivy-virtual/com.sample/common-lib_2.12/19.23.0-does-not-exist/ivys/ivy.xml 404
...

It does that happily forever...
I used SBT 1.3.0-RC2 and also tried to use the latest coursier RC:
// project/plugins.sbt
addSbtPlugin("io.get-coursier" % "sbt-coursier" % "1.1.0-M14-4")

libraryDependencies += "io.get-coursier" %% "coursier" % "v2.0.0-RC2-2"

Thanks for the details @avdv. I'm aware the issue is around the code handling redirection. An actual repro that I (or anyone) could run on its own machine would help speeding up fixing this issue.

My issue happens when the artifact exists. Still finding time to work on a test case.

Just another data point: I can't reproduce the problem with CLI 2.0.0-RC2-2. Only happens with the sbt plugin 1.1.0-M14-4

@alexarchambault could I email you with a test case against our repo?

@countfloyd Sure. See my mail in the git commits.

I also have updated the avdv/coursier-hang project with a nginx config + docker-compose file. Hope this helps finding the issue...


Assign string to string alias inconsistency

Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (go version)?
1.6.2
What operating system and processor architecture are you using (go env)?
Linux amd64 Ubuntu 16.04
What did you do?
Having a type sstring string, wanted to assing a string. "such a string" does work, but not string("such a string") nor word := "this variable".
https://play.golang.org/p/AwJsr9fOpQ
What did you expect to see?
word := "Hello"
var foo sstring = word

everything's fine
What did you see instead?
cannot use word (type string) as type sstring in assignment

For questions about Go, see https://golang.org/wiki/Questions.
See also https://blog.golang.org/constants for some background info.


Berkeley Function Calling Leaderboard Ground Truth Errors

{
    "question": "What is the are of polygon formed by vertices [[1,2],[3,4],[1,4],[3,7]]",
    "function": [
        {
            "name": "polygon_area",
            "description": "Calculate the area of a polygon given its vertices using the shoelace formula.",
            "parameters": {
                "type": "object",
                "properties": {
                    "vertices": {
                        "type": "array",
                        "items": {
                            "type": "array",
                            "items": {
                                "type": "number"
                            },
                            "minItems": 2,
                            "maxItems": 2,
                            "description": "A single vertex represented by a 2 element list [x, y]."
                        },
                        "description": "The vertices of the polygon, where each vertex is a 2 element list [x, y]."
                    }
                },
                "required": [
                    "vertices"
                ]
            }
        }
    ],
    "ground_truth": "polygon_area(vertices=[[1,2],[1,4],[5,4],[5,7]])",
    "result": "polygon_area(vertices=[[1,2],[3,4],[1,4],[3,7]])"
}
{
    "question": "As a data analyst, you are working on a project that requires you to organize a set of numerical data. You have access to the 'sort_array' function. Can you use this function with the 'array' parameter as '[1, 2, 2, 7, 7, 10]'  sort these numbers in ascending order?",
    "function": [
        {
            "name": "sort_array",
            "description": "Sorts an array of numbers.",
            "parameters": {
                "type": "object",
                "properties": {
                    "array": {
                        "type": "array",
                        "items": {
                            "type": "number"
                        },
                        "description": "The array of numbers."
                    },
                    "reverse": {
                        "type": "boolean",
                        "description": "Whether to sort the array in reverse order.",
                        "default": false
                    }
                },
                "required": [
                    "array"
                ]
            }
        }
    ],
    "ground_truth": "sort_array(array=[34, 2, 56, 7, 9, 12], reverse=False)",
    "result": "sort_array(array=[1, 2, 2, 7, 7, 10])"
}

These two items appear to be labeled with the ground truth answers from preceding questions.

Hey Sachit, Thank you for pointing this out. We accidentally execute the previous result when we are compiling the data. We have updated the new data with execution result on hugginface!


net/tcp: no need to set tcp_window_scale opt if window less than 65535

Summary
If windows size less than 65535，and we set config of NET_TCP_WINDOW_SCALE，we can see the SYNC and SYNC-ACK packet will set opt of tcp_window_scale which does not meet the standard
Impact
Tcp windows scale
Testing
Testing on Sim by set NET_TCP_WINDOW_SCALE and recv_buf

@Meissi-jian please take a look at @wengzhe comments


[occm] empty SubnetID for members transmitted and fails in octavia API

Is this a BUG REPORT or FEATURE REQUEST?:

Uncomment only one, leave it on its own line:

/kind bug

/kind feature

What happened:
When creating fully populated loadbalancers without any subnet, the members have an empty subnet ID ("subnet_id": "") in the API request.
The empty string is an invalid UUID and thus the validation in the octavia API fails with:
[...]error message: {\"faultcode\": \"Client\", \"faultstring\": \"Invalid input for field/attribute subnet_id. Value: ''. Value should be UUID format\" [...]
What you expected to happen:
The subnet_id field for members should not be sent at all and octavia will select the correct subnet(s) corresponding to the subnet.
How to reproduce it:
Configure a subnet-id as empty string or none at all  for the service and try to create a fully populated LB.
Anything else we need to know?:
The problem exist since gophercloud moved the BatchMemberUpdateOpts to allow the removal of options in an update request.
However, doing so the data structure for creating fully populated loadbalancer with BatchMemberUpdateOpts is not correctly parsed with the omitempty option, and will transfer use an empty string instead of removing the field from the API request.
The relevant gophercloud issue and PR:
https://github.com/gophercloud/gophercloud/issues/2559
https://github.com/gophercloud/gophercloud/pull/2560
Potential fix would be to use the SubnetID field in buildBatchUpdateMemberOpts only if there is a subnet to be used.
In case the subnet is an empty string, do not set the value (or set it to nil, since the evaluation of omitempty works for nil for the pointer in BatchUpdateMemberOpts).
Environment:

openstack-cloud-controller-manager(or other related binary) version: 1.23
OpenStack version: 11.0.0/zed
Others:

I Think you are proposing following logic? @danfai
if svcConf.lbMemberSubnetID != ""
{
member := v2pools.BatchUpdateMemberOpts{
                                Address:      addr,
                                ProtocolPort: int(port.NodePort),
                                Name:         &node.Name,
                                SubnetID:     &svcConf.lbMemberSubnetID,
                        }
}
else
{
member := v2pools.BatchUpdateMemberOpts{
                                Address:      addr,
                                ProtocolPort: int(port.NodePort),
                                Name:         &node.Name,
                        }
}

Yes I was thinking about this logic.
Other way to solve it, would be to specify nil, e.g. like this.
@@ -1329,11 +1329,16 @@ func (lbaas *LbaasV2) buildBatchUpdateMemberOpts(port corev1.ServicePort, nodes
                        }
                }

+               sn := &svcConf.lbMemberSubnetID
+               if sn != nil && len(*sn) == 0 {
+                       sn = nil
+               }
+
                member := v2pools.BatchUpdateMemberOpts{
                        Address:      addr,
                        ProtocolPort: int(port.NodePort),
                        Name:         &node.Name,
-                       SubnetID:     &svcConf.lbMemberSubnetID,
+                       SubnetID:     sn,
                }
                if svcConf.healthCheckNodePort > 0 {
                        member.MonitorPort = &svcConf.healthCheckNodePort

also fine, do you want to submit a PR for it ?

I can make a PR, sure.


Can't access title bar anymore after installing the files.

The userContent.css and userChrome.css has a bug which makes the titlebar unaccessible. Rest all is working fine, but I won't be able to use these CSS files bro as the presence of title bar is important to me.

Alright, I figured a solution. It's the userChrome.css that's causing the trouble with title bar. Just remove that and install any other userChrome CSS file you wish and you will be good with everything.

If you want to show titlebar menu delete all of this line:
/* Hides Top Toolbar (single toolbar) */
:root[zen-single-toolbar="true"] #zen-appcontent-navbar-container {
  max-height: var(--zen-element-separation) !important;
}

:root[inDOMFullscreen="true"] #zen-appcontent-navbar-container {
  display: none !important;
}

and then search /* delete this to show */ , just remove the display: none;


update charting library to angular-nvd3

i updated the charting library to https://github.com/krispo/angular-nvd3 which is better maintained and uses a later version of nvd3
http://g.recordit.co/xH6ygH5EoE.gif

Current coverage is 20.96% (diff: 0.00%)

Merging #358 into master will decrease coverage by 0.10%

@@             master       #358   diff @@
==========================================
  Files            20         20
  Lines          1604       1612     +8
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits            338        338
- Misses         1266       1274     +8
  Partials          0          0

Powered by Codecov. Last update 6207740...996bf2e


Update from upstream

pulling in updates from upstream

try to get the basic test to not flake

this is a separate fix?

also how come you've got merge conflicts?

try to get the basic test to not flake

this is a separate fix?

it can be. ill do that first i guess.

also how come you've got merge conflicts?

I soft forked, but some of it was upstreamed. this is preparing to hard fork. we need to remove a lot of cruft.

can you do over or rebase?

can you do over or rebase?

yeah i can clean this up now. "plan changes"


Handle 'max number of pins reached' error

respond with a message that can't pin with an interval of each ten new submissions?


[MM-24999] fix css on Copy Theme Colors button

Summary
This PR fixes the CSS of the Copy Theme Colors button.
The proposed solution is attached in the screenshots below.  I'm not positive of the original intention for the CSS of the button.  Regarding UX, do we prefer to use a clickable link, instead of the visible button?
Ticket Link
https://mattermost.atlassian.net/browse/MM-24999
Screenshots
Before:

After:

/update-branch

Thanks, @andrewbrown00.  I'm completely hacking with CSS and appreciated the suggestions.  Looking at my last commit, I reverted to use the copy-theme-button class again.  I found the v() function used elsewhere and set the button text color using color: v(button-bg);
Here are couple of screenshots showing the button text matching the button-bg, which is shown in the Save button
Mattermost Theme

Windows Dark Theme

/update-branch

@andrewbrown00, that makes sense.  Now the button is tracking the link colors as shown in your images.  I also verified change the link color also changes the button and border text.

@jfrerich the test server shows up blank when I go to https://mattermost-webapp-pr-5492.test.mattermost.cloud, any idea why?

@jfrerich the test server shows up blank when I go to mattermost-webapp-pr-5492.test.mattermost.cloud, any idea why?
I am not sure what is causing the white screen, but I am getting it too.

@jfrerich I'm seeing this white screen fairly often, too.

/update-branch

Thanks, @cpanato for the fix and @bradjcoughlin for the additional confirmation regarding the white screen.
@andrewbrown00, I was able to load the cloud instance and see the change.

@nevyangelova, can you help as a second dev reviewer?

/cherry-pick release-5.25


LogisticRegression Error during forwarding the model.

Dear NNTrainer Team!
My colleagues and I tried to run the LogisticRegression example:
https://github.com/nnstreamer/nntrainer/tree/main/Applications/LogisticRegression
The training part was running without problem (./nntrainer_logistic train ${res}/LogisticRegression.ini ${res}/dataset1.txt), the model.bin was generated.
But when we tried the testing part (./nntrainer_logistic inference ${res}/LogisticRegression.ini ${res}/test.txt), we got the following error:
"Error during forwarding the model"
We did not add anything to the implementation, we used freshly cloned codes.
Could you please investigate why could this error appear?
Thanks in advance!
Regards,
Gabor Leko

:octocat: cibot: Thank you for posting issue #850. The person in charge will reply soon.

:octocat: cibot: Thank you for posting issue #850. The person in charge will reply soon.

Sorry for late response.!
This #852 will fix the problem.
Thanks.

Sorry for late response.!
This #852 will fix the problem.
Thanks.


Implement Resource generator

lotus generate resource <name_of_resource> which does similar things like the counter part of Rails
create entity
create repository
create resource route
create all CRUD controller actions
create all view classes
create empty templates for all actions
create tests for actions
For example:
lotus generate resource posts

Thanks for your work on this but after discussion with @jodosha, we have decided to drop this generator. The reason behind that is we find it an anti-pattern, for Rails only provides that for your convenience in code generation but it does not solve any usecase. It is recommended for user to use action generator and manually group them into resource by case basis.


Create Goby Ubuntu PPA

The Ubuntu PPA is the repository system for custom repositories from Canonical, for APT-based systems (Ubuntu and Debian).
Creating a Goby PPA would make it easy for users to install Goby, and automatic to keep it updated.

I'll take care of this.

Cool👍

@saveriomiroddi Is this completed?

I haven't working on PPAs for ages :flushed:. I'll put this in my internal plans, and close the issue, since it may take a long time before I get back to this :flushed:


Option token-type doesnt change implementation return type

I'm using Windows executable to generate Lexer with custom return type for yylex function.
%option token-type=NAME changes return type for declaration, but in implementation the type stays int.
I'm currently using workaround: additional step of automated find/replace after executing reflex.exe.
Related compilation issue arises if EOF rule is not defined and return type cannot be implicitly constructed from literal 0 (case '0' in yylex generated automatically). Probably should call default constructor for token-type instead of return 0.
Full list of options I'm using:
%option fast

%option outfile=LexerImpl.hpp

%option namespace=ns::lexer
%option lexer=LexerImpl
%option token-type=ns::lexer::Token

%option noline nodefault noyywrap

Sample input and generated files are attached
IssueSample.zip

Thanks for the feedback. I noticed that the token-type for lex() was only enforced when option bison-cc is used, which is too restrictive. There should not be a restriction for token-type. Will upload an update. I also made a change in the update so that the default constructor for token-type is returned on EOF.

Thanks for the feedback. I noticed that the token-type for lex() was only enforced when option bison-cc is used, which is too restrictive. There should not be a restriction for token-type. Will upload an update. I also made a change in the update so that the default constructor for token-type is returned on EOF.

Thanks for the fast fix! It works like a charm

Well that is odd, because the CI tests succeed with clang and GCC: https://travis-ci.org/Genivia/RE-flex

Great to hear! Can I ask you for a small favor and rate reflex at https://sourceforge.net/projects/re-flex/reviews/ to give it a thumbs up or down?


Outdated does not work with authenticated nexus repository

When running roco outdated on a machine that has an authenticated nexus repository as the only source, it does not find any updates and gives warnings for all packages installed. There are a number of outdated packages found when running choco outdated.

Also, this lives up to the hype and is super fast compared to choco with checking the chocolatey.org repo.

Thanks for reporting this!
will try to reproduce & fix the issue with the OSS version of sonartype nexus, hope that it supports authenticated feeds.

Thanks for reporting this!
will try to reproduce & fix the issue with the OSS version of sonartype nexus, hope that it supports authenticated feeds.

Should have said this in the first post, but I am using the OSS version 3.29.2-02 (current latest on docker hub), so hopefully, it should be easy to setup.

Should have said this in the first post, but I am using the OSS version 3.29.2-02 (current latest on docker hub), so hopefully, it should be easy to setup.

can confirm/reproduce this issue.
expect a fix until next week

can confirm/reproduce this issue.
expect a fix until next week

Okay... I might have been a little hasty here :neutral_face:
Just realized that I need to decrypt the password for both proxy as well as feed connections before I can use them in 'reqwest'.

[ ] figure out how to decrypt_string, accodring to IEncryptionUtility (=> choco source)
[ ] add parameters -user and -password as well as -source in order to allow user to directly pass credentials for authenticated sources.

slight note @TheCakeIsNaOH  - I haven't seen this issue up until now b/c I've only been using feeds with 'anonymous viewer access' - which is all that's required to receive the neccessary ODATA info.
(don't know if possible for you or not, but you could enable this in your nexus instance and see if it works then)

Okay... I might have been a little hasty here :neutral_face:
Just realized that I need to decrypt the password for both proxy as well as feed connections before I can use them in 'reqwest'.

[ ] figure out how to decrypt_string, accodring to IEncryptionUtility (=> choco source)
[ ] add parameters -user and -password as well as -source in order to allow user to directly pass credentials for authenticated sources.

slight note @TheCakeIsNaOH  - I haven't seen this issue up until now b/c I've only been using feeds with 'anonymous viewer access' - which is all that's required to receive the neccessary ODATA info.
(don't know if possible for you or not, but you could enable this in your nexus instance and see if it works then)

(don't know if possible for you or not, but you could enable this in your nexus instance and see if it works then)
(nexus/#admin/security/anonymous => "Allow anonymous users to access the server")

I tested it temporarily, and roco oudated does work for me with anonymous access enabled, however, I need authentication normally as the server is exposed to the internet.

(don't know if possible for you or not, but you could enable this in your nexus instance and see if it works then)
(nexus/#admin/security/anonymous => "Allow anonymous users to access the server")

I tested it temporarily, and roco oudated does work for me with anonymous access enabled, however, I need authentication normally as the server is exposed to the internet.

figure out how to decrypt_string, accodring to IEncryptionUtility (=> choco source)

Here is how to do it in powershell:
Add-Type -AssemblyName System.Security
$entropyBytes = [System.Text.UTF8Encoding]::UTF8.GetBytes("Chocolatey")
Function Unprotect-Arguments {
    param([string]$data)
    $encryptedByteArray = [System.Convert]::FromBase64String($data)
    $decryptedByteArray = [System.Security.Cryptography.ProtectedData]::Unprotect(
        $encryptedByteArray,
        $entropyBytes,
        [System.Security.Cryptography.DataProtectionScope]::LocalMachine
    )
    return [System.Text.UTF8Encoding]::UTF8.GetString($decryptedByteArray)
}

Works for the passwords and api keys in chocolatey.config, and it also for .arguments files in .chocolatey. Hopefully, that windows api is available in rust somewhere.
https://docs.microsoft.com/en-us/dotnet/api/system.security.cryptography.protecteddata.unprotect

figure out how to decrypt_string, accodring to IEncryptionUtility (=> choco source)

Here is how to do it in powershell:
Add-Type -AssemblyName System.Security
$entropyBytes = [System.Text.UTF8Encoding]::UTF8.GetBytes("Chocolatey")
Function Unprotect-Arguments {
    param([string]$data)
    $encryptedByteArray = [System.Convert]::FromBase64String($data)
    $decryptedByteArray = [System.Security.Cryptography.ProtectedData]::Unprotect(
        $encryptedByteArray,
        $entropyBytes,
        [System.Security.Cryptography.DataProtectionScope]::LocalMachine
    )
    return [System.Text.UTF8Encoding]::UTF8.GetString($decryptedByteArray)
}

Works for the passwords and api keys in chocolatey.config, and it also for .arguments files in .chocolatey. Hopefully, that windows api is available in rust somewhere.
https://docs.microsoft.com/en-us/dotnet/api/system.security.cryptography.protecteddata.unprotect

Hey @TheCakeIsNaOH , thanks for your input!
I've been playing around with rust-winapi, rust-win-crypto-ng and a couple of hours, but haven't been able to decypher the credentials in native code so far.
My 'proof-of-concept' was actually a little C# app that did the 'unprotect step' ... but your powershell code made me think of this little hack:
    let pwsh = format!(
        "Add-Type -AssemblyName System.Security;([System.Text.UTF8Encoding]::UTF8.GetString([System.Security.Cryptography.ProtectedData]::Unprotect(([System.Convert]::FromBase64String('{}')),([System.Text.UTF8Encoding]::UTF8.GetBytes('Chocolatey')),[System.Security.Cryptography.DataProtectionScope]::LocalMachine)))",
        cypher
    );
    let chdec = std::process::Command::new("powershell.exe")
        .arg("-NoProfile")
        .arg("-ExecutionPolicy")
        .arg("Bypass")
        .arg(pwsh)
        .output()
        .expect("failed to run decypher text");
    let decrypted = String::from_utf8_lossy(&chdec.stdout);

it's still ugly, but that'll do / probably be in the bugfix version until I figure out how to properly use the dpapi.CryptUnprotectData.

Hey @TheCakeIsNaOH , thanks for your input!
I've been playing around with rust-winapi, rust-win-crypto-ng and a couple of hours, but haven't been able to decypher the credentials in native code so far.
My 'proof-of-concept' was actually a little C# app that did the 'unprotect step' ... but your powershell code made me think of this little hack:
    let pwsh = format!(
        "Add-Type -AssemblyName System.Security;([System.Text.UTF8Encoding]::UTF8.GetString([System.Security.Cryptography.ProtectedData]::Unprotect(([System.Convert]::FromBase64String('{}')),([System.Text.UTF8Encoding]::UTF8.GetBytes('Chocolatey')),[System.Security.Cryptography.DataProtectionScope]::LocalMachine)))",
        cypher
    );
    let chdec = std::process::Command::new("powershell.exe")
        .arg("-NoProfile")
        .arg("-ExecutionPolicy")
        .arg("Bypass")
        .arg(pwsh)
        .output()
        .expect("failed to run decypher text");
    let decrypted = String::from_utf8_lossy(&chdec.stdout);

it's still ugly, but that'll do / probably be in the bugfix version until I figure out how to properly use the dpapi.CryptUnprotectData.

hey @TheCakeIsNaOH , could you check if the provided artifact works with your authenticated repo?
rocolatey.0.5.2-dev.zip

hey @TheCakeIsNaOH , could you check if the provided artifact works with your authenticated repo?
rocolatey.0.5.2-dev.zip

@mwallner It is working for me.
Thanks for working on this.

@mwallner It is working for me.
Thanks for working on this.

would you mind checking how this version of roco compares to choco in terms of speed?
Measure-Command { choco outdated }

vs.
Measure-Command { roco.exe outdated }

tbh, I haven't had time to look up how to use the native dpapi, so I basically just included the powershell snippet you provided above, which unfortuantely adds quite some overhead when reading the config file... 😅

would you mind checking how this version of roco compares to choco in terms of speed?
Measure-Command { choco outdated }

vs.
Measure-Command { roco.exe outdated }

tbh, I haven't had time to look up how to use the native dpapi, so I basically just included the powershell snippet you provided above, which unfortuantely adds quite some overhead when reading the config file... 😅

Choco was 101.23 seconds.
Roco was 10.08 seconds.
203 packages installed.

thanks for your help on this @TheCakeIsNaOH , this issue has been resolved in version 0.5.2

It is working, thanks for the fix.


Issue#28 solution

Description
This PR fixes #28
Notes for Reviewers
Basically removed the padding

Good work, here you go @CalebCyrill feel free to contribute to other issues and improve the site. :)


Not a Issue- But a Question : How to turn off/on microphone from cmdline of Sample App(Alexa) in Raspberry pi?

Hi,
When we run Alexa (Sample App) in raspberry pi and then press m + Enter then it turns off the microphone, in short, doesn't listen from it and when we press same again it starts listening.
So How can I do it from the command line by passing an argument?
For e.g python startsample.sh -m or --microphone disable something

Hi @rajdpandey, sorry but our SampleApplication does not currently support this.  You may update the script and main.cpp however to do this as you wish, which should not be too complex.  Let us know if you need any further assistance with this.  I'll close out this ticket for now.

@dhpp hey. I am a electronics student and just learnt python for raspberry and more and I am a beginner at that so C++ is just out of my league. If you can help me with code or something like I will appreciate it and it will be a lot of help to me  I have limited time and have to do more things so..


Integrating hitechcoding/strict-form-mapper-bundle?

@zmitic created a nice bundle which comes with some interesting features. We could join forces and see if there are features we could implement here too.
This idea comes from https://github.com/symfony/symfony/issues/36022#issuecomment-599577281.

@xabbuh is there a list of things that should be done?

Not really, sorry. We would need to collect a list of features of hitechcoding/strict-form-mapper-bundle first and then consider which of them could be implemented here.

<pif


未能加载文件或程序集“Microsoft.ML.Data, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51”

Problem encountered on https://dotnet.microsoft.com/learn/ml-dotnet/get-started-tutorial/consume
Operating System: windows
Provide details about the problem you're experiencing. Include your operating system version, exact error message, code sample, and anything else that is relevant.
按照步骤做完，调试时显示这个
未能加载文件或程序集“Microsoft.ML.Data, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51”

Sorry you ran into this problem @SaitoTommo! I'm guessing your project uses .NET Full Framework?
This is a bug in the .NET Full Framework non-SDK-style project format. We are pursing a permanent fix with the .NET team.
To get unblocked, you can upgrade your .NET Framework project to use the SDK-style, or start a new project using .NET Core. Checkout this blog by Scott Hanselman for more help.
If you can't upgrade to the SDK-style, use the following to get unblocked with the non-SDK-style project format..
Set the target platform to x64
x64
Add a package reference to your project for Microsoft.ML (latest version)

@SaitoTommo Any progress with the above solution?

Closing this due to inactivity - ping me or reopen if you need additional help!


Update chart tooltips UI

Describe your changes
Update chart tooltips UI
Link the related issue
Closes #2336
Checklist before requesting a review

[x] I have performed a self-review of my code.
[x] Did you request feedback from another team member prior to merge?
[x] Does my code following the style guide at docs/CODING-STYLE.md?

the full screen and copy chart tooltips appear different from the rest of the app. the text size and color is different from the ones on the right order input panel for instance. the padding looks correct and overall they look better than before, but just a bit inconsistent throughout the app

yeah thats definitely an issue - thoughts on what the expected behavior should be: tooltip on hover or invert on click - @miyuki-eto?

yeah lets just remove the tooltip and add the denomination switching behavior to the token logos also. we will soon have the info tab on the table which will display the contract addresses for each token so the hover tooltip wont be so necessary


Cache node_modules on CI builds

What
Improve build times by caching node_modules folder

Cache key is a hash of the contents of the lock file
Caches the pnpm store folder per suggestion on rush issue: https://github.com/microsoft/rushstack/issues/1847
With GitHub actions we have 5GB of cache allowance (evicts oldest) so no issues there

Our cache size is ~177mb per cache. New cache created when lockfile is changed in a PR

Why
Faster CI times

before
after

rush install
restore from cache + rush install

55s per action
34s per action

Only 7s to restore from cache! However, still takes ~26s for the rush install - let me know if you spot another cache point improvement from the build logs!
How Tested
First CI run (no cache exists - creates a new cache): https://github.com/Azure/communication-ui-library/runs/2842984119
Subsequent CI run making use of the cache:
https://github.com/Azure/communication-ui-library/runs/2843025134

You can shave off another 37 seconds if you also cache common/temp/node_modules.
Should be safe to cache with the same key? After all the node_modules are just decompressed result from the pnpm store.
wdyt?

37 seconds on my slow laptop ;) You can't shave that off the 34 second CI time. ymmv.

You can shave off another 37 seconds if you also cache common/temp/node_modules.
Should be safe to cache with the same key? After all the node_modules are just decompressed result from the pnpm store.
wdyt?

I think we should do this 👍


ENH: Do not build SlicerExecutionModel if its path is provided

In a previous commit (5480a6b32aec3df372f08fc18882e8646ca8b8a5 [1]), External_SlicerExecutionModel.cmake has been modified and does not check if SlicerExecutionModel_DIR is defined before creating the external project to download and compile SlicerExecutionModel. Even if it is provided and if USE_SYSTEM_SLICER_EXECUTION_MODEL is set to ON, the external project for SlicerExecutionModel was still used.
[1] https://github.com/KitwareMedical/ImageViewer/commit/5480a6b32aec3df372f08fc18882e8646ca8b8a5#diff-2ead5608565906a4e7f5d574e7363861

:+1:


Can't Use Delete key After Text Add Shortcut

Bug Description
After adding a textbox with the shortcut (+ icon in the element panel tab), you can't press delete to get rid of the textbox. It looks like the textbox is selected / in focus but the delete key doesn't work. if you click out and back onto the textbox, you can now use the delete key.
Expected Behaviour
I should be able to delete the textbox with the delete key after using the shortcut.
Steps to Reproduce

Click the text add short cut in the tabs (the plus in the element panel tab),
Hit the delete key.
Doesn't work.

Screenshots

Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance Criteria
QA Instructions

Duplicate of #738.


Vocabulary size in WMT translation task

Hi all,
I'm a little confused with the vocab_size defined in problem_hparams.py.
In wmt_ende_bpe32k, the vocab_size param is set to 40960, while in wmt_enfr_tokens, there's a wrong_vocab_size param, which is set to 2**13 if in wmt_enfr_tokens_8k. I'm guessing that this might not be the actual number of the vocabulary.
My question is:
When setting input_modality, how to set the vocab_size?
More specifically, If I have a separated source vocab and target vocab, with size n_src, n_tgt, respectively, should I set the vocab_size to n_src + n_tgt or something else?
Thank you

As for BPE, unluckily it's called "bpe32k" but it contains about 40000 word-pieces. We're trying to move away from that, we used it because it was used in previous work. As for wrong_vocab_size, I'll need to take a look...

Yes, this is currently a bit confusing. The vocabulary file backing a SubwordTextEncoder is built with a target vocab size - i.e. the process will try to achieve a vocab size close to that target. That target vocab size is used in the filename of the vocab file, e.g. tokens.vocab.8192. The actual vocab size will likely be different than the target vocab size, hence wrong_vocab_size. wrong_vocab_size I believe is only used for the filename. The actual vocab size is recovered from the instantiated SubwordTextEncoder and used to instantiate the modality. The modality spec needs the true vocab size.


call statement causes crash state that triggers deadlock

Using a call statement causes a crash state to be generated that leads to a deadlock - should this happen?
Given:
---
action_options:
    Human.Input:
        max_actions: 2
        max_concurrent_actions: 1
---

role Human:

  action Input:
    input = None
    response = ui.history[-1] if ui.history else None
    if not response:
        input = ("Human","a")

    require input
    ui.input(input)
    pass    # ... more happens here ...

role ChatUI:
  action Init:
    self.history = []

  func input(input):
    self.history.append(input)
    pass    # ... more happens here ...

action Init:
  h = Human()
  ui = ChatUI()

I hit an unexpected deadlock because of a crash:
DEADLOCK detected
FAILED: Model checker failed
------
Init
--
state: {"h":"role Human#0 (fields())","ui":"role ChatUI#0 (fields(history = []))"}
------
Human#0.Input
--
state: {"h":"role Human#0 (fields())","ui":"role ChatUI#0 (fields(history = []))"}
------
thread-0
--
state: {"h":"role Human#0 (fields())","ui":"role ChatUI#0 (fields(history = []))"}
------
thread-0
--
state: {"h":"role Human#0 (fields())","ui":"role ChatUI#0 (fields(history = []))"}
------
thread-0
--
state: {"h":"role Human#0 (fields())","ui":"role ChatUI#0 (fields(history = [(\"Human\", \"a\")]))"}
------
crash
--
state: {"h":"role Human#0 (fields())","ui":"role ChatUI#0 (fields(history = [(\"Human\", \"a\")]))"}
------
Human#0.Input
--
state: {"h":"role Human#0 (fields())","ui":"role ChatUI#0 (fields(history = [(\"Human\", \"a\")]))"}
------
crash
--
state: {"h":"role Human#0 (fields())","ui":"role ChatUI#0 (fields(history = [(\"Human\", \"a\")]))"}
------

I wasn't expecting this crash to cause a deadlock.
If however if I make the python statement a call statement, eg:
diff --git a/dl.fizz b/dl.fizz
index aa07973..2eeecbf 100644
--- a/dl.fizz
+++ b/dl.fizz
@@ -14,7 +14,7 @@ role Human:
         input = ("Human","a")

     require input
-    ui.input(input)
+    ui.history.append(input)
     pass    # ... more happens here ...

 role ChatUI:

The crash goes away and there are no deadlocks.

action_options:
Human.Input:
max_actions: 2
max_concurrent_actions: 1
Since it is set to a max of twice, this deadlock happens. Because it was called twice in the stack trace.

Since it is set to a max of twice, this deadlock happens. Because it was called twice in the stack trace.

I thought with this change if max_actions is reached deadlock detection is skipped?

Graph with the ui.input(input) call statement (note the crash state in the bottom right with no outgoing transition):

Vs the graph with ui.history.append(input) which doesn't deadlock - all states have an outgoing transition:


Minor regression: v1.6.2 accepts junk after IP/prefix in the first column of a feed.

A minor impact issue with 1 feed out of 370.
v1.5.2 rejects the feed in which values are tab separated causing each line to be a single column
sgteq@desk:~/geofeed$ ./geofeed-finder-linux-x64-1.5.2 -t <IP_ADDRESS>
inetnum: <IP_ADDRESS>/20 https://as47869.net/geofeed.csv [cache]
Error: ,,,, Not valid IP/prefix

while v1.6.2 accepts it
serge@desk:~/geofeed$ ./geofeed-finder-linux-x64-1.6.2 -t <IP_ADDRESS>
inetnum: <IP_ADDRESS>/20 https://as47869.net/geofeed.csv [cache]
<IP_ADDRESS>/20	NL	NL-NH	Amsterdam	1098 XG,,,,

Expected result: v1.6.2 report 'Not valid IP/prefix' error like v1.5.2. Whitespace characters around IP/prefix could be accepted but not any other characters.

Hi @sgteq,
Nice catch. This is fixed in v1.6.3. Is the increasing amount of garbage a sign that RFC9092 is taking off? :)


chore: disable TraceLayer on_failure log

I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?

Disable the TraceLayer on_failure log because the logged message is not helpful.

Please explain IN DETAIL what the changes are in this PR and why they are needed:

Summarize your change (mandatory)
How does this PR work? Need a brief introduction for the changed logic (optional)
Describe clearly one logical change and avoid lazy messages (optional)
Describe any limitations of the current code (optional)

Checklist

[ ] I have written the necessary rustdoc comments.
[ ] I have added the necessary unit tests and integration tests.
[ ] This PR requires documentation updates.

Summary by CodeRabbit

New Features

Enhanced error logging and handling to provide more detailed error messages.
Improved HTTP trace configuration to disable tracing on failure, resulting in clearer error reports.

@evenyag I didn't end up modifying the logging level here, we can control the printing of debug logs here with RUST_LOG at startup.
https://github.com/GreptimeTeam/greptimedb/blob/59afa70311ead38aa531f908ad3bcb1e93972143/src/servers/src/error.rs#L759

@evenyag I didn't end up modifying the logging level here, we can control the printing of debug logs here with RUST_LOG at startup.
https://github.com/GreptimeTeam/greptimedb/blob/59afa70311ead38aa531f908ad3bcb1e93972143/src/servers/src/error.rs#L759

I'm not sure if it is the proper level.

I'm not sure if it is the proper level.

After my testing, adding RUST_LOG=info,servers::error=debug before the startup parameter makes the debug level logs printed here. The user can decide whether to turn it on or off as needed.
2024-07-08T08:27:09.389642Z DEBUG servers::error: Failed to handle HTTP request: 0: Pipeline management api error, at src/frontend/src/instance/log_handler.rs:68:14
1: Failed to parse pipeline: transform cannot be empty, at src/pipeline/src/manager/table.rs:205:61


Figure out how to set the HAVE_ macros when using YARP in JRuby & TruffleRuby

See https://github.com/ruby/yarp/pull/979#issuecomment-1602495850
cc @enebo

I think this is going to be very much dependent on how you build it in your repository, but you can set them via the -DHAVE_* flags for C compilers. I'm not sure if there's anything to be done on the YARP side here.

I found a way, by reusing YARP's Makefile and the static library it generates: https://github.com/ruby/yarp/pull/1051#issuecomment-1613115237


Add an optional argument to polyroots() function

Sometimes polyroots() fail to converge, but lower-precision estimates of the roots are available. This proposed change lets a user to supply an array of initial "guesses" of the roots to be refined by the Durand–Kerner method.

This looks like a sensible addition, but the code is broken. Please add a test case.

The test I added to mpmath/tests/test_calculus.py  seems to be working fine.

Seems ok. Thanks!


add html5 input type number support

Added <input type="number"> support.
refs: #43

Hi @peppertom, thanks for the effort, this is a great addition! As a general advice on open source contributions however, please don't make code style and indentation changes in the same commit as your actual change, because it renders the diff view unusable, and your actual meaningful changes to the logic get lost. In fact, don't make code style changes without first discussing it with the project's maintainers.


Enhance EtcdCoordinator if disconnected from etcd server for a long time

Why submit this pull request?

when EtcdCoordinator cannot connect to etcd cluster for a long time,
the information registered in etcd will expire and refresh() function will not work.

How to fix?
When refresh() finds that the key does not exist, an exception is thrown, and we catch the exception to rewrite the registration information.

@kezhenxu94 @JaredTan95  @wayilau Could you recheck this? Look like make sense.

@kuaikuai Welcome to be 171st contributor


Library/Executable option to choose

Add opportunity to make only lib or exec with corresponding modules for each.

Library / Executable / Both question will be asked during hs-init work.
Note: By default files and settings for both lib and exec will be created.


In lambda-comments.json, line 145 and 181, change "nodejs" to "nodejs4.3"

Hi Jim,
My name is Vam. I live in Beijing, China. First of all, I want to say - thank you very much!! I am so so excited when I found your work - It is exactly what I need and it is amazing! You know that Disqus and many other popular sites are blocked in China for some reasons. And I want to have a simple commenting system that can be accessed from China and all over the world. I spent a lot of time tried to find a right one but I didn't. Until I see your Lambda-comments. And I agreed with your point of view from "Introducing lambda-comments". I just integrated it. Please have a look:
http://vamworks.com/2016/paintings-and-drawings-by-me-before-2016/
However, during the process I got a problem: when I create a stack via the command:

npm run create-cloudformation

I saw this message when I check my AWS CloudFormation console:

console of CloudFormation: ROLLBACK_COMPLETE

When click the stack name, I see the following problem from log:

Logical ID:
QueueCommentLambdaFunction
Status reason:
The runtime parameter of nodejs is no longer supported for creating or updating AWS Lambda functions. We recommend you use the new runtime (nodejs4.3) while creating or updating functions.

I spent some time to did research and finally I found the answer:
http://docs.aws.amazon.com/cli/latest/reference/lambda/create-function.html
In lambda-comments.json, line 145 and 181, change "nodejs" to "nodejs4.3".
After that, it works very well!
:)
Best Regards,
Vam

@vamworks I met the same issue also.
But updated to nodejs4.3, I met the other issue
	18:04:34 UTC+0800	ROLLBACK_IN_PROGRESS	AWS::CloudFormation::Stack	myBlogComments	The following resource(s) failed to create: [WorkerLambdaFunction, PrivateS3BucketPolicy, QueueCommentLambdaInvokePermission, LambdaRoleInstanceProfile, JobStreamDynamoDBTable, WebsiteS3BucketPolicy]. . Rollback requested by user.

Do you have any idea ?


[PROPOSAL] [Documentation] opensearch.yml reference documentation.

What kind of business use case are you trying to solve? What are your requirements?
Without knowing the API call to use before hand that displays the configuration defaults available in opensearch.yml, we have no current reference for the configuration options. I'd very much like to see a full and complete reference including what options do what.
What is the problem? What is preventing you from meeting the requirements?
Threads in the category "OpenSearch and OpenSearch Dashboards" on the forums have the highest rate of threads being tagged with configuration - we should be more explicit and direct about what options are available in the configuration files.
What are you proposing? What do you suggest we do to solve the problem or improve the existing situation?
I don't think there's a 100% solution for this, but I'd love to see a basic reference for each config option on the doc site, or maybe even include all of the default options in the opensearch.xml commented out with the explanations there.
What are your assumptions or prerequisites?
I'm assuming that newcomers to OpenSearch won't be able to properly configure their cluster without a configuration reference of some kind.
What are remaining open questions?
Is there a full list anywhere? Do we have a list of ones that are only modifiable via changes to the xml and which ones can be changed via API?

One of the documentation goals I have is to make sure that no one has to visit any site but our own to get what they need. I suspect we're lacking a lot of basic references where someone will come across a configuration variable and wonder, "I wonder what that does?" and won't be able to find the answer on our site specifically.

Adding to what @nateynateynate has called out, I think we need documentation on all the .yml options for both OpenSearch and OpenSearch Dashboard. We have issues like this  that pop up fairly often and we can find the associated reference (i.e., console.enabled: false) in the docs site.

@nateynateynate: We're going to close this one in favor of two separate issues, one for opensearch.yml and one for opensearch.yml dashboards. The issues are:

#214
#908


IsADirectoryError: [Errno 21] Is a directory: 'checkpoints/clip-vit-large-patch14'

Thanks for your amazing work. I was trying to download the ViT-L checkpoints from HF by cloning the whole repository. However, I am getting the error shown above. Can you suggest a fix for this?

Hi @mondalanindya ,
could you please provide us with more details about raising error?

This is the full text:
Traceback (most recent call last):
  File "/home/amondal/Codes/Griffon/tools/resize_clip_pos.py", line 68, in <module>
    state_dict = copy.deepcopy(torch.load(args.model_path, map_location="cpu"))
  File "/home/amondal/anaconda3/envs/awesome_env2.0/lib/python3.10/site-packages/torch/serialization.py", line 791, in load
    with _open_file_like(f, 'rb') as opened_file:
  File "/home/amondal/anaconda3/envs/awesome_env2.0/lib/python3.10/site-packages/torch/serialization.py", line 271, in _open_file_like
    return _open_file(name_or_buffer, mode)
  File "/home/amondal/anaconda3/envs/awesome_env2.0/lib/python3.10/site-packages/torch/serialization.py", line 252, in __init__
    super().__init__(open(name, mode))
IsADirectoryError: [Errno 21] Is a directory: 'checkpoints/clip-vit-large-patch14'

Probably it expects a file instead of a directory containing the ViT-L checkpoint.

@mondalanindya I solve this by replace 'checkpoints/clip-vit-large-patch14' with 'checkpoints/clip-vit-large-patch14/pytorch_model.bin', and  'checkpoints/clip-vit-large-patch14-448' with 'checkpoints/clip-vit-large-patch14-448/pytorch_model.bin'

Thanks for the changes! I am getting another error even after running the modified script
bash demo/demo.sh demo/1v1.jpg "Is there a motorcycle on the far left of the photo?" demo/1v1.jpg Is there a motorcycle on the far left of the photo? CUDA_VISIBLE_DEVICES=0 python llava/eval/run_llava.py --model-path checkpoints/clip-vit-large-patch14 checkpoints/clip-vit-large-patch14-448 checkpoints/clip-vit-large-patch14_to_448 checkpoints/Griffon --image-file demo/1v1.jpg --query Is there a motorcycle on the far left of the photo? --obj target [2024-05-07 11:25:25,801] [INFO] [real_accelerator.py:110:get_accelerator] Setting ds_accelerator to cuda (auto detect) usage: run_llava.py [-h] [--model-path MODEL_PATH] [--model-base MODEL_BASE] --image-file IMAGE_FILE --query QUERY --obj OBJ run_llava.py: error: unrecognized arguments: checkpoints/clip-vit-large-patch14-448 checkpoints/clip-vit-large-patch14_to_448 checkpoints/Griffon

Please refer to the args in the demo.* file. It seems you input the unused arguments "checkpoints/clip-vit-large-patch14-448 checkpoints/clip-vit-large-patch14_to_448 checkpoints/Griffon".

Hi, there are three different checkpoints:
checkpoints/clip-vit-large-patch14-448 checkpoints/clip-vit-large-patch14_to_448 checkpoints/Griffon
which one should I use?

@jefferyZhan Hi, could you be more specific in how to run the demo.sh? It would be great if you could give the step by step guidelines.

Hi, there are three different checkpoints: checkpoints/clip-vit-large-patch14-448 checkpoints/clip-vit-large-patch14_to_448 checkpoints/Griffon
which one should I use?

I just meet the same issue. Does anyone solve this?

Hi, @JierunChen , we have just released the Grffion-G version. In this version, running the demo is more easy by just typing in the instruction, specifying the model path, and running on the desired image. Welcome to try our new model and feel free  to raise any issue if meeting any problem.

@jefferyZhan Hi, could you be more specific and exact in how to run the demo.sh? It would be great if you could give the step by step guidelines.


Refactor design system btns

@axdanbol Libby has recently updated some styles of the buttons to match material 3 designs. I will also update these styles and then re request the review.


Should Registration Instances contain limited fields?

After reviewing the alarm registration data from our existing alarm system it seems we may not need many overridable fields in registration instances as the vast majority of the time it appears the class defaults will suffice.  The remaining few cases could be addressed by creating additional classes, including some classes which may only have one instance.   The trade-off may be simplicity vs flexibility.   It would be much cleaner and easier to reason about if instances had very limited fields and slightly less clumsy for sync processes that automatically keep the subset of alarms that are configured elsewhere up-to-date (From the CED for example).   Further, it is a little more clumsy for ops to make changes, because to be most confident in updates they'd actually need to review EVERY instance of a class anyways to ensure there are no accidental (or previously correct, but now out-dated) instance overrides of the fields they are updating (and harder to find).   It may just be easier to invest the extra up-front cost to ensure that every alarm "type" is directly accounted for as an alarm class.

The limited set of instance fields may be:

Name
Class
Producer (epicspv)
Location

That means classes may be solely responsible for:

Corrective action
Rationale
Priority
Screen-path
On-delay
Off-delay
Category
Point-of-Contact
Latching
Filterable
Masked-by

Note: The Name, Class, and Producer are already required and only found in the instance.  The Location field is currently optional, and if not specified in the Instance, then inherited from the Class.  We may re-consider this though and for simplicity just make Location always come from Instance.  Special handling of one field may not be worth the complexity and awkward update process in which ops must check both class and instances anyway.

Note: Memory (space) considerations are probably negligible due to the relatively small amount of data.   However AVRO encodes all fields even if they're null, and even if they're the default value, so it will actually save space to remove all the null valued fields from instances.

There is some existing data that suggests some fields must remain instance-level.
Examples where screenpath varies by instance here:

box
camac

Examples where latching varies by instance here:

camac

These cases should be examined for correctness and/or ability to fold into additional classes.


Added custom messaging

I needed this in my own application and since there is already a websocket connection open i thought lets add this.

The demo app is not compiling. Looks like ARTCVideoChatViewController is still calling the old ARDAppClient api. Could you please update the sample app code also.

@theiosdevguy you are right, please let me fix it.

https://github.com/ISBX/apprtc-ios/pull/45/commits/e7c62247b5b99148b63532c1fb75376baa33368e


Include axial expansion target component name as a block parameter

Creating a block parameter for the axial expansion target component (stored as a string) would enable:

axial expansion target components to be determined through DB loading
allows users track/verify target component accuracy in postprocessing.

this is particularly useful if the target component changes dynamically in a simulation.

Originally posted by @jakehader in https://github.com/terrapower/armi/pull/777#discussion_r935048031

@jakehader I noticed you changed the title to include the component type. This is an interesting addition!
Consider - if a block has multiple components of the same type (e.g., a fuel block with components of type Circle for the fuel, bond, and clad) there wouldn't be a way to differentiate between the two if the axial expansion target component were to change from one to the other mid simulation.
I was planning on using the component.name (or something like this) to differentiate between components of the same type within a block. What do you think?

Closed with #1256


Why do you make LLM config part of the package?

It seems that someone has to install metagpt locally and modify config2.yaml to change llm config. Shouldn't the config path be a configurable variable to role?

~/.metagpt/config2.yaml is always first choice. If you're looking for a programable config, you can check this: https://github.com/geekan/MetaGPT/blob/main/tests/metagpt/test_context_mixin.py


School Closing Key Index

For the government response data, how are the variables coded?  For example, what does school closing=2 mean?

Please refer to the data source documentation.

Please refer to the data source documentation.