{ buffer: false } seems to impose a limit on the number/size of files

I've just started with gulp trying to automate mostly product image processing. As you can imagine we have a large number of product images. For my tests I started with 5000 images, exactly 1 MB each (they were generated by a script during my tests).
Setup
My first objective is to just copy the files from source to destination without further processing. As gulp does not need to read the file contents (yet), I pass { buffer: false } to gulp.src:
gulp.task('test', function() {
  return gulp
    .src('source/data/images/*.jpg'), { buffer: false })
    .pipe(gulp.dest('dist/products'));
});

When I run gulp the process starts and then just stops without further information (no "finished" line):
$ gulp test
[21:22:06] Using gulpfile C:\somewhere\gulp-static-site\gulpfile.js
[21:22:06] Starting 'test'...

C:\somewhere\gulp-static-site
$

Results
After that I have exactly 1985 files in my dist/products directory. 1984 of these are 1 MB in size, 1 has 0 bytes. The sum of these files is 2 GB, and that limit seems somewhat special. This is reproducible.
If I pass { buffer: false } (or omit it), all files get copied, but the memory footprint is much higher.
$ gulp test
[21:26:51] Using gulpfile C:\somewhere\gulp-static-site\gulpfile.js
[21:26:51] Starting 'test'...
[21:27:50] Finished 'test' after 58 s

C:\somewhere\gulp-static-site
$

Technical information
I tested both on Windows:
$ node --version
v0.12.0

$ gulp --version
[21:23:39] CLI version 3.8.11
[21:23:39] Local version 3.8.11

And on Fedora 21, where only 985 files are copied:
$ node --version
v0.10.36

$ gulp --version
[22:05:13] CLI version 3.8.11
[22:05:13] Local version 3.8.11

Probably JS running out of memory which I think was the whole thing streaming mode was supposed to solve. Hmm. Can you try messing with the highWaterMark in gulp.src (its an option passed to through2) and see if that fixes anything?

The node executable on Windows has a memory footprint around 70 MB. So I guess memory is not the issue here.
But as you suggested I modified through2's index.js and set highWaterMark: 1. Unfortunately, that doesn't change anything.
What's really strange is that the copy process succeeds if { buffer: false } is unset.

FYI, I'm running node 64-bit.

I traced this down to an EMFILE error happening while opening the file:
$ NODE_DEBUG=GFS gulp test

...
GFS 12840: open done { [Error: EMFILE, open 'C:\somewhere\gulp-static-site\dist\products\2838.jpg']
  errno: -4066,
  code: 'EMFILE',
  path: 'C:\\somewhere\\gulp-static-site\\dist\\products\\2838.jpg' } undefined
GFS 12840: enqueue 1 OpenReq { path: 'C:\\somewhere\\gulp-static-site\\dist\\products\\2838.jpg',
  flags: 'w',
  mode: 33206,
  cb: [Function],
  done: [Function],
  failures: 1 }
GFS 12840: fds { fd3: 'C:\\somewhere\\gulp-static-site\\dist\\products\\1.jpg',
  fd4: 'C:\\somewhere\\gulp-static-site\\dist\\products\\10.jpg',
  fd5: 'C:\\somewhere\\gulp-static-site\\dist\\products\\100.jpg',
  fd6: 'C:\\somewhere\\gulp-static-site\\dist\\products\\1000.jpg',
  fd7: 'C:\\somewhere\\gulp-static-site\\dist\\products\\1001.jpg',
... (lots more)

GFS 12840: [ { path: 'C:\\somewhere\\gulp-static-site\\dist\\products\\2838.jpg',
    flags: 'w',
    mode: 33206,
    cb: [Function],
    done: [Function],
    failures: 1 } ]

assert.js:86
  throw new assert.AssertionError({
        ^
AssertionError: 1 == 0
    at process.<anonymous> (C:\somewhere\gulp-static-site\node_modules\gulp\node_modules\vinyl-fs\node_modules\graceful-fs\graceful-fs.js:28:12)
    at process.emit (events.js:129:20)

I wonder, why does node not close the fd once the file has been copied?

Possibly related: https://github.com/joyent/node/issues/6041, https://github.com/isaacs/node-graceful-fs/issues/20

Moving to https://github.com/wearefractal/vinyl-fs/issues/56


MNT: Re-rendered with conda-smithy 3.1.12 and pinning 2018.10.08

Build for R 3.5.1

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


[Popup] In menu should render

Repro

see https://jsfiddle.net/mez8xokt/2/ which does the following
create a menu
insert an item to display a popup
wire up the js

Expect

popup should display when trigger element is clicked

Actual

popup doesn't display on click
however, if you click and then resize the frame the popup becomes visible

Version 2.1.8
Workaround

embed content in data-html and remove the popup element

Popups can't operate in every location inside the DOM.
Try it outside the menu
https://jsfiddle.net/u9n0uLxs/

in case anyone else runs into this ...
looks like adding position: 'bottom left' in the js config allows the popup to sit next to the trigger.
https://jsfiddle.net/pbL5uo59/1/


add_job filed: This Job cannot be serialized since the reference to its callable

code:
jobstores = {
    'default': DjangoJobStore()
}

scheduler = BackgroundScheduler(jobstores=jobstores, timezone=timezone('Asia/Shanghai'))
scheduler.start()

class CommandView(BaseView):

    def post(self, request):

        @register_job(scheduler, "interval", seconds=10)
        def test_job():
            print('123')

        register_events(scheduler)
        return self.base_json_response({'1': 123})

log:

Traceback (most recent call last):
File "/work/apps/task_execute/venv/lib/python3.6/site-packages/django/core/handlers/exception.py", line 34, in inner
response = get_response(request)
File "/work/apps/task_execute/venv/lib/python3.6/site-packages/django/core/handlers/base.py", line 126, in _get_response
response = self.process_exception_by_middleware(e, request)
File "/work/apps/task_execute/venv/lib/python3.6/site-packages/django/core/handlers/base.py", line 124, in _get_response
response = wrapped_callback(request, *callback_args, **callback_kwargs)
File "/work/apps/task_execute/venv/lib/python3.6/site-packages/django/views/generic/base.py", line 68, in view
return self.dispatch(request, *args, **kwargs)
File "/work/apps/task_execute/venv/lib/python3.6/site-packages/django/views/generic/base.py", line 88, in dispatch
return handler(request, *args, **kwargs)
File "/work/apps/task_execute/schedule/views.py", line 27, in post
@register_job(scheduler, "interval", seconds=10)
File "/work/apps/task_execute/venv/lib/python3.6/site-packages/django_apscheduler/jobstores.py", line 247, in inner
scheduler.add_job(func, *a, **k)
File "/work/apps/task_execute/venv/lib/python3.6/site-packages/apscheduler/schedulers/base.py", line 439, in add_job
self._real_add_job(job, jobstore, replace_existing)
File "/work/apps/task_execute/venv/lib/python3.6/site-packages/apscheduler/schedulers/base.py", line 864, in _real_add_job
store.add_job(job)
File "/work/apps/task_execute/venv/lib/python3.6/site-packages/django_apscheduler/jobstores.py", line 29, in inner
return func(*a, **k)
File "/work/apps/task_execute/venv/lib/python3.6/site-packages/django_apscheduler/jobstores.py", line 95, in add_job
job_state=pickle.dumps(job.getstate(), self.pickle_protocol)
File "/work/apps/task_execute/venv/lib/python3.6/site-packages/apscheduler/job.py", line 237, in getstate
'instead.' % (self.func,))
ValueError: This Job cannot be serialized since the reference to its callable (<function CommandView.post..test_job at 0x7f2491ef2d08>) could not be determined. Consider giving a textual reference (module:function name) instead.

@Near-Zhang job functions must static and not be local to a class (see pickle). Workaround:
def my_job_func(self):
   # do your stuff

scheduler.add_job(self.my_job_func, trigger=None, ...)

Closing based on answer provided by @mkoertgen - please re-open if necessary.


IJCAI Touches June/12

[x] Title area - Contact e-mails - Contact e-mails should be written below the affiliations, using a 12pt regular (non-monospace) font.
Editor's comment: Please write all the contact e-mails on one single line, below the two affiliations (keeping the superscripts as they are now):
IST, University of Lisbon & INESC-ID, Portuga
Federal University of Pernambuco, Brazil
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>

[x] Typesetting - Main text font/size - Main text body must be in Adobe's Times Roman font at 10pt.
Editor's comment: Please use regular font for the footnotes.

[x] Typesetting - Subsubsection headings - Subsubsection headings must be in Title Case, 10-point bold type. There must be a blank space of approximately 6 points above subsubsection headings.
Editor's comment: Please do not use italics for the subsubsection headings (on page 4).
Please use Title Case.

[x] Layout - Figure/table font sizes - All figures must be clearly readable (text is not too small, graph's bars/lines are distinguishable enough when printed in grayscale).
Editor's comment: Text in Table 5 and Figure 5 is too small.

[x] Layout - Figure/table positioning - Figures and Tables should be floated to the top/bottom of the page unless there's a good reason not to.
Editor's comment: Figures shouldn’t be wrapped in text.
Figures/Tables should be floated on top/bottom of the page.

[x] References - Formatting style - References must follow the named bibliography style.
Editor's comment: Do not balance the columns in the last page of the paper. It is fine if only one is full and the other contains (almost) nothing.
Please use same font size as for the main text.

[x] Metadata - Affiliations - The author's affiliations must be in "Institution, Address" format, one affiliation per line. The address is optional.
Editor's comment: Please write exactly the same information as on the paper.

7f19d6c


No Icon!

Downloaded unsubscribed-master, no icon, its an empty gray box!  Suggestions?

Hi @oldhickory30! Did you check out #12? This is a common issue, because of the way that N1 loads packages.

Yes I checked it out, reinstalled etc, still will not work.
Here is how its appearing.

On May 9 2016, at 4:12 pm, Colin<EMAIL_ADDRESS>wrote:

Hi @oldhickory30! Did you check out
#12? This is a common
issue, because of the way that N1 loads packages.

—
You are receiving this because you were mentioned.
Reply to this email directly or [view it on GitHub](https://github.com/colinki
ng/n1-unsubscribe/issues/26#issuecomment-218005653)![](https://github.com/noti
fications/beacon/APa9IAnjWbvPsemwdyf-ioxXwKPAsqJ8ks5p_7E7gaJpZM4IakdV.gif)

Ah, thanks for the photo. When you download the master version of this repo, you need to change the name of the directory from "n1-unsubscribe-master" to "n1-unsubscribe". The name of the directory is used as the name of the package (the text in the photos you provided). If done right, you should see the package labeled as "n1-unsubscribe" on the plugin panel!

That appears to have done the trick!
Thanks!![](https://link.nylas.com/open/ep5x1z03l7qa2mf9l06sgbubu/local-
0e61301d-2b71)
On May 9 2016, at 4:23 pm, Colin<EMAIL_ADDRESS>wrote:

Ah, thanks for the photo. When you download the master version of this repo,
you need to change the name of the directory from "n1-unsubscribe-master" to
"n1-unsubscribe". The name of the directory is used as the name of the package
(the text in the photos you provided). If done right, you should see the
package labeled as "n1-unsubscribe" on the plugin panel!

—
You are receiving this because you were mentioned.
Reply to this email directly or [view it on GitHub](https://github.com/colinki
ng/n1-unsubscribe/issues/26#issuecomment-218007852)![](https://github.com/noti
fications/beacon/APa9ICYT7ROaAKWG-lECe1NCYrlVA_i2ks5p_7PBgaJpZM4IakdV.gif)

Great, glad it is working!


added missing pip

When I tried to build the html pages, it complained click was missing. I know in the doc it mentions having tower-cli installed but, when you source the virtualenv, tower-cli is not installed there. I don't think we don't need to use sudo since its installing in the virtualenv.

Coverage remained the same at 89.986% when pulling 4e5fa91e57efd998bfc0e5e4a20d5f27a1da5e63 on jlozadad:jlozadad_docs into 02c2b97d4769424cb8a3c8009871ad97d5779f07 on ansible:master.

@jangsutsr can I get an update on the status of this PR?

@AlanCoding Let's close this one. This is a duplicate of instructions below. But @jlozadad puts up a good point, we should figure out a better way of arranging docs so that readers won't miss that step. Will open an issue for that.


Make username simpler : )

It would be easier for you to have a simpler username so we can easily download the image and not having to find lllllllllllillllllllilllll.

I don't know what you're talking about, that's just the name my parents gave me.
I'm considering a new username and possibly a different name for the project.
Currently rewriting a lot of the code.

No keep the project name dweebui is a cool name


Add support for Bosch Smart Home ETRV's

The ETRV's of Bosch Smart Home use a different device identification

I wasn't aware it's possible to pair Bosch devices to the CCU. Or does the Bosch-Hub expose a CCU-compatible XML-RPC API?

I wasn't aware it's possible to pair Bosch devices to the CCU. Or does the Bosch-Hub expose a CCU-compatible XML-RPC API?

Hello @danielperna84 as far as I know it is only possible to pair Bosch Devices with the HM-OCCU-SDK (https://github.com/eq-3/occu)

Hello @danielperna84 as far as I know it is only possible to pair Bosch Devices with the HM-OCCU-SDK (https://github.com/eq-3/occu)


Possible unexpected behavior in simulate due to resource path

Dear Colleagues,
I am using MuJoCo 3.1.1 in WSL,2 with Ubuntu 22.04.3 LTS. I have just cloned the MuJoCo Menagarie. I have included the model for Trossen VX300s in one of my own models. As required I have used the relative path like so
<include file="../../mujoco_menagerie/trossen_vx300s/vx300s.xml"/>
When I run
$~/mujoco-3.1.1/bin/simulate ~/hil_lab/slider_bots/beam_slider.xml
I get this error
Error: resource not found via provider or OS filesystem: '/home/xxx/hil_lab/slider_bots/assets/vx300s_1_base.stl'
I have fixed the problem by specifying the meshdir and texturedir with relative paths as well, in the top XML file, beam_slider.xml
<compiler meshdir="../../mujoco_menagerie/trossen_vx300s/assets"/>
<compiler texturedir="../../mujoco_menagerie/trossen_vx300s/assets"/>

Is the error above an expected behavior when one uses <include .../> due to my beginner's mistake of not properly specifying resource paths?
Thank you.
BU

I have created a question instead of a bug issue.

I have created a question and closed the bug.


Add support for logback.xml configuration file

$ ./gradlew bootBuildImage
...
    [creator]     javax.xml.parsers.FactoryFinder was unintentionally initialized at build time. org.slf4j.impl.StaticLoggerBinder caused initialization of this class with the following trace:
    [creator]           at javax.xml.parsers.FactoryFinder.<clinit>(FactoryFinder.java:46)
    [creator]           at javax.xml.parsers.SAXParserFactory.newInstance(SAXParserFactory.java:147)
    [creator]           at ch.qos.logback.core.joran.event.SaxEventRecorder.buildSaxParser(SaxEventRecorder.java:79)
    [creator]           at ch.qos.logback.core.joran.event.SaxEventRecorder.recordEvents(SaxEventRecorder.java:57)
    [creator]           at ch.qos.logback.core.joran.GenericConfigurator.doConfigure(GenericConfigurator.java:151)
    [creator]           at ch.qos.logback.core.joran.GenericConfigurator.doConfigure(GenericConfigurator.java:110)
    [creator]           at ch.qos.logback.core.joran.GenericConfigurator.doConfigure(GenericConfigurator.java:53)
    [creator]           at ch.qos.logback.classic.util.ContextInitializer.configureByResource(ContextInitializer.java:75)
    [creator]           at ch.qos.logback.classic.util.ContextInitializer.autoConfig(ContextInitializer.java:150)
    [creator]           at org.slf4j.impl.StaticLoggerBinder.init(StaticLoggerBinder.java:84)
    [creator]           at org.slf4j.impl.StaticLoggerBinder.<clinit>(StaticLoggerBinder.java:55)

I'm testing now without this but I believe the codepath is when it hit src/main/resources/logback.xml

Not an easy one:
Error: Classes that should be initialized at run time got initialized during image building:
 javax.xml.parsers.FactoryFinder was unintentionally initialized at build time. org.slf4j.impl.StaticLoggerBinder caused initialization of this class with the following trace:
	at javax.xml.parsers.FactoryFinder.<clinit>(FactoryFinder.java:45)
	at javax.xml.parsers.SAXParserFactory.newInstance(SAXParserFactory.java:127)
	at ch.qos.logback.core.joran.event.SaxEventRecorder.buildSaxParser(SaxEventRecorder.java:79)
	at ch.qos.logback.core.joran.event.SaxEventRecorder.recordEvents(SaxEventRecorder.java:57)
	at ch.qos.logback.core.joran.GenericConfigurator.doConfigure(GenericConfigurator.java:151)
	at ch.qos.logback.core.joran.GenericConfigurator.doConfigure(GenericConfigurator.java:110)
	at ch.qos.logback.core.joran.GenericConfigurator.doConfigure(GenericConfigurator.java:53)
	at ch.qos.logback.classic.util.ContextInitializer.configureByResource(ContextInitializer.java:75)
	at ch.qos.logback.classic.util.ContextInitializer.autoConfig(ContextInitializer.java:150)
	at org.slf4j.impl.StaticLoggerBinder.init(StaticLoggerBinder.java:84)
	at org.slf4j.impl.StaticLoggerBinder.<clinit>(StaticLoggerBinder.java:55)

We do our best to limit build time initialization but with SLF4J that's hard to avoid and here SLF4J build time init trigger logback SaxEventRecorder which performs javax.xml.parsers.FactoryFinder static init at build time.
Trying to intialize javax.xml.parsers.FactoryFinder at build time requires to configure a lot of other classes initialized at build time too so that seems a dead end to me.
Any thoughts @aclement?

It worked  for me just by deleting the file (I got further), so I'm not blocked.

I move this issue to 0.10 since solving that will require deeper changes.

Hi,
I stumble upon this issue as well, and want to add some points;
It seems like having the logback file logback-spring.xml will result in below error:
Logging system failed to initialize using configuration from 'null'
java.lang.IllegalStateException: Could not initialize Logback logging from classpath:logback-spring.xml
        at org.springframework.boot.logging.logback.LogbackLoggingSystem.loadConfiguration(LogbackLoggingSystem.java:168)
        at org.springframework.boot.logging.AbstractLoggingSystem.initializeWithConventions(AbstractLoggingSystem.java:80)
        at org.springframework.boot.logging.AbstractLoggingSystem.initialize(AbstractLoggingSystem.java:60)
        at org.springframework.boot.logging.logback.LogbackLoggingSystem.initialize(LogbackLoggingSystem.java:132)
        at org.springframework.boot.context.logging.LoggingApplicationListener.initializeSystem(LoggingApplicationListener.java:312)
        at org.springframework.boot.context.logging.LoggingApplicationListener.initialize(LoggingApplicationListener.java:281)
        at org.springframework.boot.context.logging.LoggingApplicationListener.onApplicationEnvironmentPreparedEvent(LoggingApplicationListener.java:239)
        at org.springframework.boot.context.logging.LoggingApplicationListener.onApplicationEvent(LoggingApplicationListener.java:216)
        at org.springframework.context.event.SimpleApplicationEventMulticaster.doInvokeListener(SimpleApplicationEventMulticaster.java:203)
        at org.springframework.context.event.SimpleApplicationEventMulticaster.invokeListener(SimpleApplicationEventMulticaster.java:196)
        at org.springframework.context.event.SimpleApplicationEventMulticaster.multicastEvent(SimpleApplicationEventMulticaster.java:170)
        at org.springframework.context.event.SimpleApplicationEventMulticaster.multicastEvent(SimpleApplicationEventMulticaster.java:148)
        at org.springframework.boot.context.event.EventPublishingRunListener.environmentPrepared(EventPublishingRunListener.java:82)
        at org.springframework.boot.SpringApplicationRunListeners.lambda$environmentPrepared$2(SpringApplicationRunListeners.java:63)
        at java.util.ArrayList.forEach(ArrayList.java:1259)
        at org.springframework.boot.SpringApplicationRunListeners.doWithListeners(SpringApplicationRunListeners.java:117)
        at org.springframework.boot.SpringApplicationRunListeners.doWithListeners(SpringApplicationRunListeners.java:111)
        at org.springframework.boot.SpringApplicationRunListeners.environmentPrepared(SpringApplicationRunListeners.java:62)
        at org.springframework.boot.SpringApplication.prepareEnvironment(SpringApplication.java:362)
        at org.springframework.boot.SpringApplication.run(SpringApplication.java:320)
        at org.springframework.boot.SpringApplication.run(SpringApplication.java:1311)
        at org.springframework.boot.SpringApplication.run(SpringApplication.java:1300)
        at id.co.telkomsel.digitalcore.bs.networkprofile.api.Application.main(Application.java:18)
Caused by: ch.qos.logback.core.LogbackException: Unexpected filename extension of file [resource:logback-spring.xml]. Should be either .groovy or .xml
        at ch.qos.logback.classic.util.ContextInitializer.configureByResource(ContextInitializer.java:58)
        at org.springframework.boot.logging.logback.LogbackLoggingSystem.configureByResourceUrl(LogbackLoggingSystem.java:191)
        at org.springframework.boot.logging.logback.LogbackLoggingSystem.loadConfiguration(LogbackLoggingSystem.java:165)
        ... 22 more

Which is quite odd since the logback file is actually have the correct extensions.
While in my case, when using logback.xml logback file, it will result in build error (I'm using maven btw);
...
[INFO]     [creator]     Error: Classes that should be initialized at run time got initialized during image building:
[INFO]     [creator]      org.springframework.boot.ansi.AnsiOutput was unintentionally initialized at build time. To see why org.springframework.boot.ansi.AnsiOutput got initialized use --trace-class-initialization=org.springframework.boot.ansi.AnsiOutput
[INFO]     [creator]     org.springframework.boot.logging.logback.ColorConverter was unintentionally initialized at build time. To see why org.springframework.boot.logging.logback.ColorConverter got initialized use --trace-class-initialization=org.springframework.boot.logging.logback.ColorConverter
[INFO]     [creator]
[INFO]     [creator]     Error: Use -H:+ReportExceptionStackTraces to print stacktrace of underlying exception
[INFO]     [creator]     Error: Image build request failed with exit status 1
[INFO]     [creator]     unable to invoke layer creator
[INFO]     [creator]     unable to contribute native-image layer
[INFO]     [creator]     error running build
[INFO]     [creator]     exit status 1
[INFO]     [creator]     ERROR: failed to build: exit status 1
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  02:51 min
[INFO] Finished at: 2021-03-19T05:32:17+07:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.springframework.boot:spring-boot-maven-plugin:2.4.3:build-image (default-cli) on project networkprofile-bs-api: Execution default-cli of goal org.springframework.boot:spring-boot-maven-plugin:2.4.3:build-image failed: Builder lifecycle 'creator' failed with status code 145 -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/PluginExecutionException

and yes, deleting the logback file causes the issue to disappear.

This temporary limitation is now documented.
When we fix that, let's make sure <springProperty /> is supported as described in #607.

logback.xml support seems more complicated than I thought originally, especially with Janino (a java compiler) involved.

Ran into this one while upgrading to 0.9.x. Did not occur in previous versions.

To trace same issue with other XML stuff :
After removing logback.xml but keeping com.fasterxml.jackson.core:[jackson-core, jackson-databind, jackson-annotations] got the same error :
Error: Classes that should be initialized at run time got initialized during image building:
[INFO]     [creator]      jdk.xml.internal.SecuritySupport was unintentionally initialized at build time. To see why jdk.xml.internal.SecuritySupport got initialized use --trace-class-initialization=jdk.xml.internal.SecuritySupport
[INFO]     [creator]     javax.xml.parsers.FactoryFinder was unintentionally initialized at build time. To see why javax.xml.parsers.FactoryFinder got initialized use --trace-class-initialization=javax.xml.parsers.FactoryFinder

As you can see on this POC app : https://github.com/scalastic/virusapp

I am wondering whether Spring Boot should add more documentation (or features) about Logback's Configurator which allows for programmatic configuration instead of XML configuration.
Favoring programmatic configuration would probably be a good way to mitigate this issue, but I'm having some problems finding good documentation for extending Spring Boot configuration.
What do you think ?

Has this task been scheduled in the plan?

@snicoll @bclozel Any thoughts on @celcius112 comment?

This should be discussed in: https://github.com/spring-projects/spring-boot/issues/25847

This was a blocker for me. I wanted to convert to native but our projects need the logback-spring.xml and springProperty and also the compiler (for if statements).
A way forward might be to implement a new configuration file format but with native 'if' support without using janino compiler? Perhaps a more lean method of setting your appenders (that is somewhat compatible with logback on a basic level).

same error as @cipley over here with version "0.9.2"

Having the same issues with my project. So far we've been able to copy a standard logback-spring.xml between our projects. This enables our Splunk HTTP Appender. We're using the follwoing code and other springProperty placeholders:
    <!-- Import Non-Production Spring Properties & Set Defaults -->
    <springProperty name="LOGGING_SPLUNK_URL" source="logging.splunk.url" defaultValue="---"/>
    <springProperty name="LOGGING_SPLUNK_TOKEN" source="logging.splunk.token" defaultValue="---"/>

    <springProfile name="prod">
        <!-- configuration to be enabled when the "prod" profile is active -->
        <!-- Import Production Spring Properties & Set Defaults -->
        <springProperty name="LOGGING_SPLUNK_URL" source="logging.splunk.url" defaultValue="----"/>
        <springProperty name="LOGGING_SPLUNK_TOKEN" source="logging.splunk.token" defaultValue="---"/>
    </springProfile>

Also fails for me with version 0.9.2. After seeing Logback is supported, but not configuration with logback.xml
I wondered if configuration via logback.groovy would work.  It does not build via ./gradlew bootBuildImage:
Error: Classes that should be initialized at run time got initialized during image building:
[snip]
quite a lot of org.codehaus.groovy.NAME was unintentionally initialized at build time. To see why
[snip]

Not advocating for logback.groovy, but I would have used it to workaround this issue.  The basic customization via application.properties is not sufficient.  I'm forward to https://github.com/spring-projects/spring-boot/issues/25847 , I always thought logback.xml was a weird way to configure logback.

@joeyslalom don't hesitate to add a 👍 to the related issue. If we show that we would like this feature the spring boot team will be more motivated to do it :)

same error as @cipley over here with version "0.10.0"

Hm, now I'm wondering what is the reproducible case :) What I did is I enabled xml support removeXmlSupport = false added type hints to all the different logback's converters, encoders and policies my app is using and now I'm able to run app just fine with my xml config including springProfile using Dlogging.config=/path/to/my/logback-config.xml. No error during build or runtime.

With janino on CP and janino if condition in xml file (as far as I can tell I've added necessary TypeHints) the generated image just exit without any message with exit code 1.

Hm, now I'm wondering what is the reproducible case
I see now it happens in case logback.xml is embedded in the application.

See #889 for a workaround.

https://github.com/spring-projects-experimental/spring-native/commit/a9e661b4104a93c02cb8203f4422e082ad22f365 assume this feeds here https://docs.spring.io/spring-native/docs/current/reference/htmlsingle/#_application_failed_to_start_when_running_code_mvn_spring_boot_run_code eventually

See https://docs.spring.io/spring-native/docs/current-SNAPSHOT/reference/htmlsingle/#logback-workaround/

See also my recent update of Logback support documentation with explain how to specify configuration with logback-config.xml at runtime.

I created ch.qos.logback.classic.spi.Configurator file, CustomConfigurator class, and added @InitializationHint annotation as described in the documentation below
https://docs.spring.io/spring-native/docs/current/reference/htmlsingle/#logback-workaround.
But anyway, when I build, I get the following error,
> Task :nativeCompile
Toolchain detection is disabled, will use GraalVM from C:\graalvm-ce-java11-21.3.0.
[native-image-plugin] Using executable path: C:\graalvm-ce-java11-21.3.0\bin\native-image.cmd
[mystore:14228]    classlist:   3,766.58 ms,  1.19 GB
[mystore:14228]        (cap):   2,916.83 ms,  1.19 GB
Warning: Could not register org.springframework.boot.liquibase.LiquibaseChangelogMissingFailureAnalyzer: allDeclaredConstructors for reflection. Reason: java.lang.NoClassDefFoundError: liquibase/exception/ChangeLogParseException.
[mystore:14228]        setup:   4,625.32 ms,  1.19 GB
The bundle named: org.apache.tomcat.util.threads.res.LocalStrings, has not been found. If the bundle is part of a module, verify the bundle name is a fully qualified class name. Otherwise verify the bundle path is accessible in the classpath.
To see how the classes got initialized, use --trace-class-initialization=org.springframework.boot.logging.logback.ColorConverter
[mystore:14228]     analysis:   7,318.84 ms,  2.98 GB
Error: Classes that should be initialized at run time got initialized during image building:
 org.springframework.boot.logging.logback.ColorConverter was unintentionally initialized at build time. To see why org.springframework.boot.logging.logback.ColorConverter got initialized use --trace-class-initialization=org.springframework.boot.logging.logback.ColorConverter

Error: Use -H:+ReportExceptionStackTraces to print stacktrace of underlying exception
[mystore:14228]      [total]:  15,945.31 ms,  2.98 GB
# Printing build artifacts to: C:\workspace\mystore\build\native\nativeCompile\mystore.build_artifacts.txt
Error: Image build request failed with exit status 1

> Task :nativeCompile FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':nativeCompile'.
> Process 'command 'C:\graalvm-ce-java11-21.3.0\bin\native-image.cmd'' finished with non-zero exit value 1

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 36s
10 actionable tasks: 10 executed

am I missing something?

Indeed, I can reproduce. Since embedded logback-spring.xml is now a better way to solve this as discussed here, I will just remove this programmatic Logback configuration from the documentation.

This will be support in Spring Boot 3 RC1 to be released tomorrow via https://github.com/spring-projects/spring-boot/commit/4a76fbf93c03b45917f06c65bbd877ac160a6149 thanks to @wilkinsona.


Work with the directory structure

The directory structure:
[RFA installation directory]
|
+---/frame (Framing device location)
|   |
|   +---/frame/disk (Virtual file system)
|   |
|   +---/frame/exec (Framing device)
|   |
|   +---/frame/install (Games before install)
|
+---/games (Fic directory)
|
+---/noteye (NotEye location)

Roguefics are supposed to be installed to /games through a framing device.

This is important because Python is having trouble interfacing with NotEye.

DIRECTORY RESTRUCTURE!!
[RFA installation directory]
|
+---/frame (Framing device location)
|   |
|   +---/frame/disk (Virtual file system)
|   |
|   +---/frame/exec (Framing device)
|   |
|   +---/frame/install (Games before install)
|
+---/games (Fic directory)
We will be moving away from NotEye!!


[Bug]: Cannot connect with outline in Windows 11: outline-ipc-start-proxying

Application
Outline Client
Describe the bug
In windows 11 I'm getting this error when I want to connect:
ERR_INTERNAL_ERROR
Internal service error
Caused by:
Error: Error invoking remote method 'outline-ipc-start-proxying' Error
in outline trace log:
Sentry Logger [log]: Starting Electron crashReporter
Sentry Logger [log]: Integration installed: SentryMinidump
Sentry Logger [log]: Integration installed: ElectronBreadcrumbs
Sentry Logger [log]: Integration installed: Net
Sentry Logger [log]: Integration installed: MainContext
Sentry Logger [log]: Integration installed: ChildProcess
Sentry Logger [log]: Integration installed: OnUncaughtException
Sentry Logger [log]: Integration installed: PreloadInjection
Sentry Logger [log]: Integration installed: AdditionalContext
Sentry Logger [log]: Integration installed: Screenshots
Sentry Logger [log]: Integration installed: RendererProfiling
Sentry Logger [log]: Integration installed: InboundFilters
Sentry Logger [log]: Integration installed: FunctionToString
Sentry Logger [log]: Integration installed: LinkedErrors
Sentry Logger [log]: Integration installed: Console
Sentry Logger [log]: Integration installed: Http
Sentry Logger [log]: Integration installed: Undici
Sentry Logger [log]: Integration installed: OnUnhandledRejection
Sentry Logger [log]: Integration installed: ContextLines
Sentry Logger [log]: Integration installed: LocalVariablesSync
Sentry Logger [log]: Integration installed: Modules
Sentry Logger [log]: Integration installed: RequestData
Sentry Logger [log]: Integration installed: MainProcessSession
Sentry Logger [log]: The preload script could not be injected automatically. This is most likely caused by bundling of the main process
Outline is starting
loading web app from file:///C:/Program%20Files%20(x86)/Outline/resources/app.asar/client/www/index_electron.html?debug=true&appName=Outline
Could not load active tunnel:  [Error: ENOENT: no such file or directory, open 'C:\Users\Parisa-pc\AppData\Roaming\Outline\connection_store'] {
errno: -4058,
code: 'ENOENT',
syscall: 'open',
path: 'C:\Users\Parisa-pc\AppData\Roaming\Outline\connection_store'
}
Sentry Logger [log]: Deleted Crashpad metadata file C:\Users\Parisa-pc\AppData\Roaming\Outline\Crashpad\metadata
connecting to Outline Server ...
[tun2socks] - checking connectivity ...
CryptAcquireContext failed with error -2146893813, trying to create NEWKEYSETAssertion "CryptAcquireContext failed with error -2146893809" failed at line 70 in<EMAIL_ADDRESS>[tun2socks.exe - EXIT]: Exited with code 3
could not connect: a [Error]
at t.ChildProcessHelper.b (C:\Program Files (x86)\Outline\resources\app.asar\output\client\electron\index.js:2:674688)
at ChildProcess.emit (node:events:526:28)
at ChildProcess.emit (node:domain:475:12)
at ChildProcess._handle.onexit (node:internal/child_process:291:12) {
exitCode: 3
}
Error occurred in handler for 'outline-ipc-start-proxying': a [Error]
at t.ChildProcessHelper.b (C:\Program Files (x86)\Outline\resources\app.asar\output\client\electron\index.js:2:674688)
at ChildProcess.emit (node:events:526:28)
at ChildProcess.emit (node:domain:475:12)
at ChildProcess._handle.onexit (node:internal/child_process:291:12) {
exitCode: 3
}
disconnected from ...
[5108:1205/183127.283:ERROR:gpu_init.cc(481)] Passthrough is not supported, GL is disabled, ANGLE is
Steps to reproduce
1- Open the application
2- trying to connect to my server
What did you expect to happen?
No response
What actually happened?
No response
Outline Version
1.14.0
What operation system are you using?
Windows
Operating System Version
Windows 11
Screenshots and Videos
No response

Thank you for reaching out! Please contact us through the application on the device where you’re experiencing this issue  – or at support.getoutline.org – and include the GitHub issue number so that we can better support your needs.
If you haven’t already, check out the Outline Support Site at support.getoutline.org for access to help articles and more.


Cannot access file

Hi. When tapping on a file with a custom extension on iOS (that I registered as a type in Xcode), my Flutter app gets triggered and opened and I receive a file url such as this: file:///private/var/mobile/Containers/Shared/AppGroup/1822654E-3DCE-480F-9C5E-BEF214FEAFC6/File%20Provider%20Storage/DAVIRW_240120_09-13-39.protern
I'm calling you start method before trying to work with the file but I still get an error that the file does not exist. Any idea why?

Are you using the URL version of the API startAccessingSecurityScopedResourceWithURL (not the file path version)? If yes, sorry I have no clue why it happens as my knowledge of this API is limited to working with icloud directories :-)


Dub + Coverage + LDC = Game over (DUB#1758)

https://github.com/dlang/dub/issues/1758

This has been merged upstream, and worked around on our side.


fake keys not working?

When I try to set a single-key binding for any mode, it seems it gets swallowed. Nothing happens when h is pressed in switcher mode in the following example:
switcher - h :  khd -p "- x"

The command itself seems to work well when done from the terminal. The following produces x keyboard input after 3 seconds:
sleep 3 && khd -p "-x"

Device: MacBook Pro 2016
Mac OS X: 10.12.3
Installation: Homebrew tap

@dominiklohmann Thanks, that was the reason! I didn't realize khd can block its own keypresses. Since this was for implementing a vim mode, I opted for 2, which works great. Thanks again. :)


Add a placeholder overview page to Storybook

Add a new Intro page to Storybook. This does not describe a specific component—the first of it's kind.

Goals of this PR

Example standalone Storybook page to practice and show others
My first PR in this repo. I needed to fix some setup issues.

This change is

Thanks for the review, @tjcouch-sil

not really much of a fan of embedding code into a markdown document

I'd like to hear more about this stance; it's the first I've heard it.
As far as I can tell, TS(X) is the primary file format for Storybook Stories using Autodocs.  is the recommended file format for Storybook these days, with MDX and Docs blocks being options for extending. I chose an MDX file here because this file isn't associated with a component. I'm also exploring how I might enable non-coding designers to make (relatively) direct contributions to Storybook as a shared Source of truth, and Markdown was way more approachable than Typescript. I'm still learning about the pros and cons of that approach.

Should I be merging this commit myself? Who takes the next step?

when mentioning SIL we should also mention UBS

Right. This is placeholder just to see what it can look like. I fully intend to rewrite the entire page.

src/stories/Intro.mdx line 1 at r2 (raw file):
Previously, Sebastian-ubs wrote…
when mentioning SIL we should also mention UBS

Done. Removed mention of organizations.


Clickhouse FTBS in Ubuntu Eoan (MySQL 8 + GCC 9)

Reference:
Ubuntu Bug LP: #1840511
https://bugs.launchpad.net/ubuntu/+source/bareos/+bug/1840485/
Operating system
Ubuntu Eoan (in development, to be frozen Aug 22)
Cmake version
3.13.4
Ninja version
1.9.0
Compiler name and version
gcc (Ubuntu 9.2.0-1ubuntu1) 9.2.0
and
gcc-8 (Ubuntu 8.3.0-19ubuntu1) 8.3.0
Full cmake and/or ninja output
https://launchpadlibrarian.net/429654087/buildlog_ubuntu-eoan-amd64.clickhouse_18.16.1+ds-4build1_BUILDING.txt.gz

[ 6%] Building CXX object libs/libmysqlxx/CMakeFiles/mysqlxx.dir/src/Connection.cpp.o
cd /<>/clickhouse-18.16.1+ds/obj-x86_64-linux-gnu/libs/libmysqlxx && /usr/bin/c++ -I/<>/clickhouse-18.16.1+ds/libs/libmysqlxx/include -I/<>/clickhouse-18.16.1+ds/libs/libcommon/include -I/<>/clickhouse-18.16.1+ds/obj-x86_64-linux-gnu/libs/libcommon/include -I/<>/clickhouse-18.16.1+ds/contrib/cityhash102/include -g -O2 -fdebug-prefix-map=/<>/clickhouse-18.16.1+ds=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -pipe -fno-omit-frame-pointer -Wall -Wnon-virtual-dtor -O2 -g -DNDEBUG -O3 -flto -fno-fat-lto-objects -fPIC -std=c++17 -o CMakeFiles/mysqlxx.dir/src/Connection.cpp.o -c /<>/clickhouse-18.16.1+ds/libs/libmysqlxx/src/Connection.cpp
In file included from /<>/clickhouse-18.16.1+ds/libs/libmysqlxx/include/mysqlxx/ResultBase.h:4,
from /<>/clickhouse-18.16.1+ds/libs/libmysqlxx/include/mysqlxx/UseQueryResult.h:3,
from /<>/clickhouse-18.16.1+ds/libs/libmysqlxx/include/mysqlxx/Query.h:6,
from /<>/clickhouse-18.16.1+ds/libs/libmysqlxx/include/mysqlxx/Connection.h:10,
from /<>/clickhouse-18.16.1+ds/libs/libmysqlxx/src/Connection.cpp:7:
/<>/clickhouse-18.16.1+ds/libs/libmysqlxx/include/mysqlxx/Types.h:7:23: error: conflicting declaration ‘using MYSQL = struct st_mysql’
using MYSQL = st_mysql;
^
In file included from /<>/clickhouse-18.16.1+ds/libs/libmysqlxx/src/Connection.cpp:4:
/usr/include/mysql/mysql.h:335:3: note: previous declaration as ‘typedef struct MYSQL MYSQL’
} MYSQL;

We are upgrading MySQL to version 8 in the next Ubuntu (Eoan) and we faced the regression above. C and C++ differ in the form of types being defined. While C++ structs are defined also as new types, in C you have to explicitly typedef the struct to have a new type.
If I edit file libs/libmysqlxx/include/mysqlxx/Types.h and comment the following lines:
//struct st_mysql;
//using MYSQL = st_mysql;
//
//struct st_mysql_res;
//using MYSQL_RES = st_mysql_res;
//
//using MYSQL_ROW = char**;
//
//struct st_mysql_field;
//using MYSQL_FIELD = st_mysql_field;
and add
#include <mysql/mysql.h>
I solve the issue, as MYSQL, MYSQL_RES, MYSQL_ROW and MYSQL_FIELD types are defined by the mysql.h header file (as C++ would expect). Not sure if this would be the best way to address this, any recommendation ?

Note: Unfortunately doing that with gcc-9 was not successful not because of the change, per se, but gcc-9 crashed during clickhouse compilation. When changing gcc-9 to gcc-8 as the default compiler (Ubuntu Eoan userland) I was able to compile clickhouse libmysqlxx library successfully with the mentioned changes.

Not sure if this would be the best way to address this, any recommendation?

If it works both for libmysqlclient and libmariadbclient, it's fine.

You can send a pull request with this change and it will be tested automatically.

Also you can change
using MYSQL = st_mysql;

to
using MYSQL = struct st_mysql;

We avoid to include <mysql/mysql.h> in header files to avoid namespace pollution. Better to include in .cpp whenever possible. So, we use forward declarations.

Alright, let me propose a merge then. Thx for the advices.

Im testing our Ubuntu Builds and will propose a patch tomorrow (basically a #ifndef _mysql_h before the declarations, seem to have worked pretty well with minimum changes).

https://github.com/yandex/ClickHouse/pull/6569

Pull request made! Thx for reviewing this.

GCC 9 issue is being tracked here:
https://github.com/yandex/ClickHouse/issues/6560
Closing this since the patch was merged.
Thx a lot for considering the fix.


update vendors

except docker related repos
Signed-off-by: Lai Jiangshan<EMAIL_ADDRESS>

retest this please @hykins


Differing behaviors between classic Jupyter Notebook and JupyterLab & VS Code for ipywidgets

Environment data

VS Code version: 1.58.2 (Universal)
Jupyter Extension version (available under the Extensions sidebar): v2021.8.1046824664
Python Extension version (available under the Extensions sidebar): v2021.6.944021595
OS (Mac) and version: macOS Big Sur (11.4)
Python and/or Anaconda version: Python  3.6.12 |Anaconda, Inc.| (default, Sep  8 2020, 17:50:39) [GCC Clang 10.0.0 ]
Type of virtual environment used (conda): See above
Jupyter server running: Local

Expected behaviour
Updating or interacting with widgets triggers handlers which sends output to cell
Actual behaviour
Included in summary
Steps to reproduce:
import ipywidgets
import IPython

import numpy as np
import pandas as pd

import seaborn as sns

np.random.seed(1)
df_1 = pd.DataFrame(np.random.randint(1, 5, (10, 5))).add_prefix("X")

def getHist(df, var_name):
    import matplotlib.pyplot as plt
    table = df
    fig, ax = plt.subplots()
    try:
        sns.histplot(table[var_name])
    except:
        sns.distplot(table[var_name])
    IPython.display.display(fig)
    plt.close()

class UI():
    def __init__(self):
        self._select_widget = ipywidgets.Dropdown(options = df_1.columns.tolist())
        self._select_widget.observe(self._on_value_change, names = "value")

        self._print_Data_syntax_button = ipywidgets.Button(description = "Data Syntax")
        self._print_Data_syntax_button.on_click(self._on_button_clicked_print_Data_syntax)

        self._vbox = ipywidgets.VBox([self._print_Data_syntax_button,
                                      self._select_widget,
                                     ])

        self._display()

    def _on_value_change(self, change):
        self._display()

    def _displayUI(self):
        IPython.display.clear_output()
        IPython.display.display(self._vbox)

    def _display(self):
        self._displayUI()
        getHist(df_1, self._select_widget.value)

    def _on_button_clicked_print_Data_syntax(self, change):
        print(str(self._select_widget.value))

ui1 = UI()
# Pushing button or changing dropdown triggers behavior noted in Summary

Logs
Included in summary
Summary
I recently inherited some code from someone and in the process of trying to run it in a classic Jupyter Notebook and in JupyterLab & VS Code, I noticed it behaves slightly different in each. Below is stripped down minimal code to reproduce the behavior I'm seeing, and I've preserved the structure of the code (my disclaimer that it’s a bit odd and not optimal) in case that comes into play.
In a classic Jupyter Notebook, when either the button is clicked or the dropdown changes new output is produced and sent to the output of the cell. But in JupyterLab the output is sent to the Log and the output in the cell stays the same. This also happens when I use the same notbook server for the classic notebook that I'm using for JupyterLab. Interestingly VS Code has similar behavior as JupyterLab in that the output in the cell stays the same and warnings/info messages are thrown. Also if it helps, in VS Code, in the Output - Jupyter section it gives the following warnings/info messages when the dropdown widget is changed:
Info 2021-07-19 10:36:07: Unhandled widget kernel message: display_data [object Object]
Unhandled kernel message from a widget: display_data : {"data":{"text/plain":"<Figure size 432x288 with 1 Axes>","image/png":"iVBORw0KGgoAAAANSUhEUg [truncated]

and the following when the button is clicked:
Info 2021-07-19 10:38:18: Unhandled widget kernel message: stream [object Object]
Unhandled kernel message from a widget: stream : {"name":"stdout","text":"X4\n"}

My hunch is that this isn't a bug per-se but that, but rather that the code improperly relies on behavior that differs between a classic Jupyter Notebook and JupyterLab & VS Code. Any ideas as to what the issue may be or what the differing behaviors are and why it works in a classic Jupyter Notebook but not JupyterLab / VS Code?
Thanks
Setup versioning:
Python  3.6.12 |Anaconda, Inc.| (default, Sep  8 2020, 17:50:39)
notebook  6.4.0
jupyterlab  3.0.16
ipywidgets  7.6.3
IPython  7.16.1
matplotlib 3.3.4
seaborn  0.11.1
Firefox 90.0.1
macOS Big Sur (11.4)
I'm also posting this on the VS Code - Jupyter Extension and JupyterLab forums/github.

Internally those events in VS Code are fired by this code here:
https://github.com/jupyter-widgets/ipywidgets/blob/355eea58b154e9857085e0a37a989174a6b68786/jupyterlab_widgets/src/manager.ts#L70
Which I believe happens when the kernel object is not being listened to in the UI script. Not sure why it wouldn't be though.

@mwh3780 Apologies for never getting to this, we're looking at fixing this issue in the current iteration.
Marking as a duplicate of https://github.com/microsoft/vscode-jupyter/issues/9503 (which will be fixed in the next release)


Update docker-machine to v0.14.0

https://github.com/docker/machine/releases/tag/v0.14.0
Fixes for:
https://github.com/rancher/rancher/issues/11376
https://github.com/rancher/ui/pull/1704

Updated in backend. UI changes for other issues, will be tested separately.


format comment format

Signed-off-by: fengshunli<EMAIL_ADDRESS>

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 94.194%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
3894

Relevant Lines:
4134

💛  - Coveralls


Call to undefined method PDO::close() when closing connection pool

Any attempt to call $pool->close() on a ClientPool with PDO connections ends with:
Error: Uncaught Error: Call to undefined method PDO::close() in ./vendor/openswoole/core/src/Coroutine/Client/PDOClient.php:46
  Stack trace:
  #0 ./vendor/openswoole/core/src/Coroutine/Pool/ClientPool.php(89): OpenSwoole\Core\Coroutine\Client\PDOClient->__call()
  #1 ./src/WebSocket/PoolRunner/AbstractRunner.php(19): OpenSwoole\Core\Coroutine\Pool\ClientPool->close()

Client pool attempts to close remaining collections by calling non-existent close method on underlying objects.

I have the same problem.

@jsanahuja Sure, I will test it on Monday on one of my main projects :+1:

As discussed in discord, the problem is at: https://github.com/openswoole/openswoole/blob/master/core/src/Coroutine/Pool/ClientPool.php#LL89C17-L89C34 Where ClientPool calls which "redirects" the call from to object here: https://github.com/openswoole/openswoole/blob/master/core/src/Coroutine/Client/PDOClient.php#L46 While has no method.$client->close()``PDOClient``PDO``PDO``close
The best approach in my opinion would be to define the close method in PDOClient and simply unset $__object in it.

this change you made in the other project tolerated the problem 🤔
https://github.com/openswoole/core/pull/4

As discussed in discord, the problem is at: https://github.com/openswoole/openswoole/blob/master/core/src/Coroutine/Pool/ClientPool.php#LL89C17-L89C34 Where ClientPool calls which "redirects" the call from to object here: https://github.com/openswoole/openswoole/blob/master/core/src/Coroutine/Client/PDOClient.php#L46 While has no method. $client->close()PDOClientPDOPDOclose
The best approach in my opinion would be to define the close method in PDOClient and simply unset $__object in it.

this change that I made in the other project, solved the problem 🤔 openswoole/core#4

Your change would work with ClientPool because PDOClient exits the Channel and is therefore destroyed destroying PDO as well. But the use of PDOClient is not limited to ClientPool and without it, the close method is useless: it does not close the connection.
Also, as far as I know, openswoole/core is a read-only repository and all the changes have to be done here first.

I have no idea where (which project) this change needs to be but I agree with @jsanahuja that the close() method should not just do nothing but trying to unset / null the active connection object ($this->__object)
I completely overlooked in core pr 3 that the PDOClient is just another wrapper. I wrongly assumed it has an "extends" relationship, hence the proposed do nothing approach in the close() method.

I have no idea where (which project) this change needs to be but I agree with @jsanahuja that the close() method should not just do nothing but trying to unset / null the active connection object ($this->__object)
I completely overlooked in core pr 3 that the PDOClient is just another wrapper. I wrongly assumed it has an "extends" relationship, hence the proposed do nothing approach in the close() method.

I added a comment on my PR https://github.com/openswoole/openswoole/pull/42#issuecomment-1566876085 about if we should control if the connection was closed in other methods. What do you think? Should other methods be aware of closed connections?

Personally, I like this addition! I would even throw the exception everywhere the object in question is accessed. "Fail early" or "as soon as possible".
Reason I mention this is that I've seen the code you proposed in isInTransaction. The exception would currently not be thrown there.

Personally, I like this addition! I would even throw the exception everywhere the object in question is accessed. "Fail early" or "as soon as possible". Reason I mention this is that I've seen the code you proposed in isInTransaction. The exception would currently not be thrown there.

I didn't mean to throw an exception unless the use of __object was really necessary. For isInTransaction, I thought we could simply return false. There's no need for the __object to indicate that we're not in a transaction if we're not even connected.
But I agree that the earlier we fail, the better. Also, a call to isInTransaction after close makes no sense, and without throwing the exception, the developer wouldn't realize they're doing something wrong.
I will implement it soon, and let's wait until Bruce finds time to review it.
Thanks @dhobi !


EntitySearchedEvent not usable for Entity Mandatories

PHP Version
7.4
Shopware Version
6.4
Expected behaviour
Criteria can be changed by Event Subscriber.
Actual behaviour
Criteria is cloned and can't be used outside the event.
How to reproduce
No need to reproduce, just remove clone here:
https://github.com/shopware/platform/blob/trunk/src/Core/Framework/DataAbstractionLayer/Event/EntitySearchedEvent.php#L30

Here is an example how I want to use the event:
    public function onSearch(EntitySearchedEvent $event) {
        $entityDefinition = $event->getDefinition();
        $organisationId = null;

        foreach (AppflixMarketplace::MARKETPLACE_MANDATORIES as $table) {
            if ($entityDefinition->getEntityName() === $table) {
                $entityDefinition->getFields()->addNewField(
                    new FkField('amp_organisation_id', 'organisationId', OrganisationDefinition::class),
                );

                $criteria = $event->getCriteria();
                $criteria->addFilter(new EqualsFilter('product.organisationId', $organisationId));
            }
        }
    }

https://issues.shopware.com/issues/NEXT-15541


UI stays on 'file participants' for almost a minute

OS/Web Information

Web Browser: Firefox
Local OS: Ubuntu 20.04.2 LTS
Remote OS: Debian 10
Remote Architecture: 64 bit
code-server --version: 3.11.0

Hello 👋
I am creating my own docker image with code-server 3.11.0 right now.
After opening code-server in docker container, I have noticed that actions (create, copy, delete)
in explorer panel take a really long time
to complete but in bash those commands are working just fine. —>
Screenshot

One more thing. When I click cancel the task is completed right away.
It’s almost like the command is completed but code-server
must still check something. This is code-server without any extensions, so no ESlint for example.
Steps to Reproduce

Create docker image from release-standalone folder
Use “docker run -d ‘docker image’ —auth none”
Try to create file/folder using explorer panel buttons

Logs
Using code-server --log debug
shows that nothing is wrong but when I use 'docker logs' on that container
It is showing this error.
`Error: /usr/lib/x86_64-linux-gnu/libstdc++.so.6: version 'GLIBCXX_3.4.26' not found (required by /usr/local/lib/vscode/node_modules/spdlog/build/Release/spdlog.node)
at Object.Module._extensions..node (internal/modules/cjs/loader.js:1122:18)
at Module.load (internal/modules/cjs/loader.js:928:32)
at Function.Module._load (internal/modules/cjs/loader.js:769:14)
at Module.require (internal/modules/cjs/loader.js:952:19)
at require (internal/modules/cjs/helpers.js:88:18)
at bindings (/usr/local/lib/vscode/node_modules/bindings/bindings.js:112:48)
at Object. (/usr/local/lib/vscode/node_modules/spdlog/index.js:3:35)
at Module._compile (internal/modules/cjs/loader.js:1063:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:1092:10)
at Module.load (internal/modules/cjs/loader.js:928:32)
at Function.Module._load (internal/modules/cjs/loader.js:769:14)
at Module.require (internal/modules/cjs/loader.js:952:19)
at require (internal/modules/cjs/helpers.js:88:18)
at t (/usr/local/lib/vscode/out/vs/loader.js:5:101)
at r.load (/usr/local/lib/vscode/out/vs/loader.js:4:1722)
at r.load (/usr/local/lib/vscode/out/vs/loader.js:3:10249)
at l (/usr/local/lib/vscode/out/vs/loader.js:5:10314)
at Object.errorback (/usr/local/lib/vscode/out/vs/loader.js:5:10435)
at r.triggerErrorback (/usr/local/lib/vscode/out/vs/loader.js:3:10613)
at /usr/local/lib/vscode/out/vs/loader.js:3:10319
at r.load (/usr/local/lib/vscode/out/vs/loader.js:4:1739)
at r.load (/usr/local/lib/vscode/out/vs/loader.js:3:10249)
at l (/usr/local/lib/vscode/out/vs/loader.js:5:10314)
at r._loadModule (/usr/local/lib/vscode/out/vs/loader.js:5:10444)
at r._resolve (/usr/local/lib/vscode/out/vs/loader.js:6:452)
at r.defineModule (/usr/local/lib/vscode/out/vs/loader.js:5:6145)
at r._relativeRequire (/usr/local/lib/vscode/out/vs/loader.js:5:6831)
at n (/usr/local/lib/vscode/out/vs/loader.js:5:9420)
at P.f (/usr/local/lib/vscode/out/vs/server/entry.js:24:4512)
at new Promise ()
at P (/usr/local/lib/vscode/out/vs/server/entry.js:24:4492)
at _createSpdLogLogger (/usr/local/lib/vscode/out/vs/server/entry.js:24:5472)
at new _ (/usr/local/lib/vscode/out/vs/server/entry.js:24:5288)
at Ae.initializeServices (/usr/local/lib/vscode/out/vs/server/entry.js:41:95222)
at async Ae.initialize (/usr/local/lib/vscode/out/vs/server/entry.js:41:92228)
at async process. (/usr/local/lib/vscode/out/vs/server/entry.js:41:98916) {
phase: 'loading',
moduleId: 'spdlog',
neededBy: [ '===anonymous3===' ]
}
Error: /usr/lib/x86_64-linux-gnu/libstdc++.so.6: version 'GLIBCXX_3.4.26' not found (required by /usr/local/lib/vscode/node_modules/spdlog/build/Release/spdlog.node)
at Object.Module._extensions..node (internal/modules/cjs/loader.js:1122:18)
at Module.load (internal/modules/cjs/loader.js:928:32)
at Function.Module._load (internal/modules/cjs/loader.js:769:14)
at Module.require (internal/modules/cjs/loader.js:952:19)
at require (internal/modules/cjs/helpers.js:88:18)
at bindings (/usr/local/lib/vscode/node_modules/bindings/bindings.js:112:48)
at Object. (/usr/local/lib/vscode/node_modules/spdlog/index.js:3:35)
at Module._compile (internal/modules/cjs/loader.js:1063:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:1092:10)
at Module.load (internal/modules/cjs/loader.js:928:32)
at Function.Module._load (internal/modules/cjs/loader.js:769:14)
at Module.require (internal/modules/cjs/loader.js:952:19)
at require (internal/modules/cjs/helpers.js:88:18)
at t (/usr/local/lib/vscode/out/vs/loader.js:5:101)
at r.load (/usr/local/lib/vscode/out/vs/loader.js:4:1722)
at r.load (/usr/local/lib/vscode/out/vs/loader.js:3:10249)
at l (/usr/local/lib/vscode/out/vs/loader.js:5:10314)
at Object.errorback (/usr/local/lib/vscode/out/vs/loader.js:5:10435)
at r.triggerErrorback (/usr/local/lib/vscode/out/vs/loader.js:3:10613)
at /usr/local/lib/vscode/out/vs/loader.js:3:10319
at r.load (/usr/local/lib/vscode/out/vs/loader.js:4:1739)
at r.load (/usr/local/lib/vscode/out/vs/loader.js:3:10249)
at l (/usr/local/lib/vscode/out/vs/loader.js:5:10314)
at r._loadModule (/usr/local/lib/vscode/out/vs/loader.js:5:10444)
at r._resolve (/usr/local/lib/vscode/out/vs/loader.js:6:452)
at r.defineModule (/usr/local/lib/vscode/out/vs/loader.js:5:6145)
at r._relativeRequire (/usr/local/lib/vscode/out/vs/loader.js:5:6831)
at n (/usr/local/lib/vscode/out/vs/loader.js:5:9420)
at P.f (/usr/local/lib/vscode/out/vs/server/entry.js:24:4512)
at new Promise ()
at P (/usr/local/lib/vscode/out/vs/server/entry.js:24:4492)
at _createSpdLogLogger (/usr/local/lib/vscode/out/vs/server/entry.js:24:5472)
at new _ (/usr/local/lib/vscode/out/vs/server/entry.js:24:5288)
at Ae.initializeServices (/usr/local/lib/vscode/out/vs/server/entry.js:41:95222)
at async Ae.initialize (/usr/local/lib/vscode/out/vs/server/entry.js:41:92228)
at async process. (/usr/local/lib/vscode/out/vs/server/entry.js:41:98916) {
phase: 'loading',
moduleId: 'spdlog',
neededBy: [ '===anonymous3===' ]
}
[2021-07-23T14:12:16.626Z] error exthost console {"arguments":"["Error: /usr/lib/x86_64-linux-gnu/libstdc++.so.6: version 'GLIBCXX_3.4.26' not found (required by /usr/local/lib/vscode/node_modules/spdlog/build/Release/spdlog.node)\n    at Object.Module._extensions..node (internal/modules/cjs/loader.js:1122:18)\n    at Module.load (internal/modules/cjs/loader.js:928:32)\n    at Function.Module._load (internal/modules/cjs/loader.js:769:14)\n    at Function.n._load (/usr/local/lib/vscode/out/vs/workbench/services/extensions/node/extensionHostProcess.js:103:27915)\n    at Module.require (internal/modules/cjs/loader.js:952:19)\n    at require (internal/modules/cjs/helpers.js:88:18)\n    at bindings (/usr/local/lib/vscode/node_modules/bindings/bindings.js:112:48)\n    at Object. (/usr/local/lib/vscode/node_modules/spdlog/index.js:3:35)\n    at Module._compile (internal/modules/cjs/loader.js:1063:30)\n    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1092:10)\n    at Module.load (internal/modules/cjs/loader.js:928:32)\n    at Function.Module._load (internal/modules/cjs/loader.js:769:14)\n    at Function.n._load (/usr/local/lib/vscode/out/vs/workbench/services/extensions/node/extensionHostProcess.js:103:27915)\n    at Module.require (internal/modules/cjs/loader.js:952:19)\n    at require (internal/modules/cjs/helpers.js:88:18)\n    at t (/usr/local/lib/vscode/out/vs/loader.js:5:101)\n    at r.load (/usr/local/lib/vscode/out/vs/loader.js:4:1722)\n    at r.load (/usr/local/lib/vscode/out/vs/loader.js:3:10249)\n    at l (/usr/local/lib/vscode/out/vs/loader.js:5:10314)\n    at Object.errorback (/usr/local/lib/vscode/out/vs/loader.js:5:10435)\n    at r.triggerErrorback (/usr/local/lib/vscode/out/vs/loader.js:3:10613)\n    at /usr/local/lib/vscode/out/vs/loader.js:3:10319\n    at r.load (/usr/local/lib/vscode/out/vs/loader.js:4:1739)\n    at r.load (/usr/local/lib/vscode/out/vs/loader.js:3:10249)\n    at l (/usr/local/lib/vscode/out/vs/loader.js:5:10314)\n    at r._loadModule (/usr/local/lib/vscode/out/vs/loader.js:5:10444)\n    at r._resolve (/usr/local/lib/vscode/out/vs/loader.js:6:452)\n    at r.defineModule (/usr/local/lib/vscode/out/vs/loader.js:5:6145)\n    at r._relativeRequire (/usr/local/lib/vscode/out/vs/loader.js:5:6831)\n    at n (/usr/local/lib/vscode/out/vs/loader.js:5:9420)\n    at l (/usr/local/lib/vscode/out/vs/workbench/services/extensions/node/extensionHostProcess.js:75:7572)\n    at new Promise ()\n    at k (/usr/local/lib/vscode/out/vs/workbench/services/extensions/node/extensionHostProcess.js:75:7552)\n    at C._createSpdLogLogger (/usr/local/lib/vscode/out/vs/workbench/services/extensions/node/extensionHostProcess.js:75:8532)\n    at new C (/usr/local/lib/vscode/out/vs/workbench/services/extensions/node/extensionHostProcess.js:75:8348)\n    at new C (/usr/local/lib/vscode/out/vs/workbench/services/extensions/node/extensionHostProcess.js:84:86356)\n    at s._createInstance (/usr/local/lib/vscode/out/vs/workbench/services/extensions/node/extensionHostProcess.js:73:1371)\n    at s._createServiceInstance (/usr/local/lib/vscode/out/vs/workbench/services/extensions/node/extensionHostProcess.js:73:3772)\n    at s._createServiceInstanceWithOwner (/usr/local/lib/vscode/out/vs/workbench/services/extensions/node/extensionHostProcess.js:73:3288)\n    at s._createAndCacheServiceInstance (/usr/local/lib/vscode/out/vs/workbench/services/extensions/node/extensionHostProcess.js:73:2963)\n    at s._safeCreateAndCacheServiceInstance (/usr/local/lib/vscode/out/vs/workbench/services/extensions/node/extensionHostProcess.js:73:2161)\n    at s._getOrCreateServiceInstance (/usr/local/lib/vscode/out/vs/workbench/services/extensions/node/extensionHostProcess.js:73:1882)\n    at Object.get (/usr/local/lib/vscode/out/vs/workbench/services/extensions/node/extensionHostProcess.js:73:450)\n    at /usr/local/lib/vscode/out/vs/workbench/services/extensions/node/extensionHostProcess.js:92:9543\n    at s.invokeFunction (/usr/local/lib/vscode/out/vs/workbench/services/extensions/node/extensionHostProcess.js:73:319)\n    at new E (/usr/local/lib/vscode/out/vs/workbench/services/extensions/node/extensionHostProcess.js:92:9523)\n    at Object.i [as startExtensionHostProcess] (/usr/local/lib/vscode/out/vs/workbench/services/extensions/node/extensionHostProcess.js:103:31795)\n    at processTicksAndRejections (internal/process/task_queues.js:93:5)"]","token":"5e547c73-fe79-465f-a09c-30229483d0e7"}`
I found also this in issues https://github.com/cdr/code-server/discussions/2308#:~:text=failed to start-,%232308,-Unanswered but I don’t know if this is what creates that problem.

I am spitballing here, but looking at the error:
Error: /usr/lib/x86_64-linux-gnu/libstdc++.so.6: version 'GLIBCXX_3.4.26' not found (required by /usr/local/lib/vscode/node_modules/spdlog/build/Release/spdlog.node)

Temporarily, would upgrading the glib version inside your environment fix this?
Not sure why this is happening though. cc the experts @oxy @code-asher

Agreed with the assessment, it appears that whatever you used to build
release-standalone is using a newer version of glib than the Docker
image that is running the build.
One way to resolve this would be to use the same Docker image for both
building and running the build.

Thanks for answers. Tried all day building images with different versions of Libstdc++.so.6
For example : apt-get update && apt-get install libstdc++6
When i get to this part of image building, the message i get is
libstdc++6 is already the newest version (8.3.0-6). but the error with 'GLIBCXX_3.4.26' not found
is still present. Now I will try to do what you have suggested.

@AceSpadeAble is on vacation so let me say this - your suggestion worked! Thanks @code-asher


email based authentication

there is already code, be careful
use https://modules.vlang.io/net.smtp.html
use e.g. https://app.brevo.com/settings/keys/smtp is free secure smtp service
use htmx
use e.g. login form from https://flowbite.com/docs/components/forms/
remember login state in browser datsstor, so next time we come back we don't have to do every time the check on email

completed with b337858, examples can be found in spiderlib/auth/examples. Done using brevo so please reach out to run examples to get the SMTP credentials, or create your own credentials. Moving remembering login state to separate issue since that is beyond email auth and also concerns tfconnect/basic_auth


First steps toward GPU compatibility

This PR does a first very rough sweep at the tests in runtests and fixes the low-hanging fruit for some tests to pass.
I modified runtest.jl to use a new gpu_broken that signals which tests are known to fail on GPU. Eventually, the goal is to have no gpu_broken runtests.jl.

I force pushed a few times because I realized I accidentally mixed some old code in my previous commits. Nothing major should have changed.

I force pushed a few times because I realized I accidentally mixed some old code in my previous commits. Nothing major should have changed.

Aaand something has changed. I think I lost some of the bug fixes I applied this morning. Will try to restore them.

Everything green again. I am going to merge!


Beam Search Implementation

Hello Exllama friends,
I was curious what the thoughts are on implementing beam search in v2.
In the v1. Beam search was implemented in the core generator.
I was curious what would the requirements be to migrate the same source over to v2.
And if there is anything I should be mindful of, if creating a PR migrating v1 beam search to v2.

It definitely needs to be adapted for the new version, so expect it to need some minor changes at least. But I'm not sure I'd do it the same way. In V1 I avoided using batches so the beam search wouldn't have VRAM overhead, but then of course there was extra latency instead. I think you should be able to get the best of both worlds with a slightly different approach, though. Just haven't quite figured it out yet.

@turboderp have you put more thought into this? I barely understand any of it, but the way I see it there are different decoding strategies where in terms of advantages you have to pick "either or" between the different strategies, correct?
With that being said, would it not be possible to combine different decoding strategies? Thus gaining the benefits of all strategies while even mitigating the disadvantages of some, like those that give generic and monotone outputs.
Oh and by the way: When autosplitting across GPUs, would it not make more sense to always (or at least have a parameter to) choose last-to-first order of  GPU loading? That way we reserve the left-aligned space for the system and the right-aligned space for the model-loading, meaning we'd only see an overload when all GPUs are at full capacity.
Currently working on a chatbot application where I want to make some of the more complicated processes simplified, so this would be a great addition if such an implementation is possible 😇

Hey @cohan8999, @turboderp has done a ton of work and there is still tons of work to do and it's my bad for suggesting I'd commit to creating this.
I'll be honest with you. I haven't been doing a lot of llama based SFT these days and am mostly doing with Claude, GPT4/GPT4 SFT these days.
In terms of strategies @cohan8999, no, this does not impact Top K and Top P sampling. This actually enhances the token picking process.
In regards to multiple algorithms. I'm not sure what you mean. I'm not fully updated to date on the latest token sampling processes and I highly recommend you do a deep dive on the current ecosystem for token sampling.
Cheers, Chris

Part of the motivation for the dynamic generator is to have a better framework for sampling strategies like beam search, so it's probably coming at some point. It's not in particularly high demand, though, as it's a super-greedy algorithm, and everyone's looking away from that towards more creative random sampling approaches.


Exception if source Smartsheet contains no rows

@RCoff
When I run the get_sheet_as_df function on an empty sheet, an exception is thrown at line 172 based on the key 'row' not being available in object_dict. I was able to get around this issue by adding the following in a local copy before line 172:

if not object_dict.get('rows', None):
return pd.DataFrame(columns=columns_list)

I am not familiar with PRs on GitHub so am submitting this issue using this method. I also realize there may be a more optimal way of doing the same check, and figured you'd know what is best.
And much thanks - your utility has been a huge time-saver for me!

Resolved in latest PR


feat: Delete Progress.PendingSnapshot and improve snapshot handling

Summary
This PR addresses issue #124 by cleaning up and improving snapshot handling in the Raft library. The main objectives include removing the PendingSnapshot, improving the handling of ReportSnapshot() and MsgSnapStatus, and cleaning up related state transitions to enhance clarity and robustness in the Raft snapshot management logic.
Change
Removal of PendingSnapshot

Eliminated Progress.PendingSnapshot, which is no longer necessary after changes in #110.
Simplified state transitions related to snapshot handling.

Enhancements to ReportSnapshot() and MsgSnapStatus

Updated  ReportSnapshot() and MsgSnapStatus to accept the index of the applied snapshot.
This change allows Raft to handle cases where the snapshot’s applied index differs from the requested index, as seen in complex systems like CockroachDB.
Logic now directly updates Match and transitions to StateReplicate when applicable.

Additional Improvements

Improved comments for snapshot-related state handling.
Added test cases to ensure correctness for scenarios involving differing snapshot indices.

Breaking Changes
Public API Changes

ReportSnapshot() and MsgSnapStatus now require the applied snapshot’s index as a parameter.
These changes are not backward-compatible and necessitate updates in all downstream implementations.
The changes are designed for inclusion in version 4.0.0 to prevent breaking compatibility with existing 3.x users.

References

Issue: Clean up and improve snapshot handling #124
PR: Snapshot handling improvements in #110
Issue: CockroachDB’s snapshot logic #87583

How I tested
$ make test
PASSES="unit" ./scripts/test.sh
Starting at: Wed Nov 27 22:33:49 JST 2024

'unit' started at Wed Nov 27 22:33:49 JST 2024
ok      go.etcd.io/raft/v3      0.634s
ok      go.etcd.io/raft/v3/confchange   0.626s
ok      go.etcd.io/raft/v3/quorum       (cached)
ok      go.etcd.io/raft/v3/raftpb       (cached)
ok      go.etcd.io/raft/v3/rafttest     1.544s
ok      go.etcd.io/raft/v3/tracker      0.772s
'unit' completed at Wed Nov 27 22:33:52 JST 2024
SUCCESS

@ahrtr
Hello, I hope you are doing good.
I handled one of the tickets in the v4.0.0 milestone.
Please take a look after you prepare the branch
Thank you

cc @joshuazh-x
Can you help with review?

Thank you for checking this
I appreciate your help

/retest


Add nvcomp to kvikio-exports export set

Thanks @trxcllnt, all the CI errors are hopefully fixed by https://github.com/rapidsai/kvikio/pull/156

/merge


IOU - In scan request, tapping download file shows error pop up

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.22
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:

Launch app
Tap fab--- Request money---Scan
Upload a corrupt pdf file
Select a contact
Tap request
Tap on request created and enter amount and merchant field
Tap in receipt and note error message can't upload file
Navigate back to scan request created and note error message "Receipt didn't upload, download the file. "
Tap download the file

Expected Result:
In scan request uploading corrupt pdf, tapping download file must allow user to download the file and it must show pop up message " Attachment downloaded successfully
Actual Result:
In scan request uploading corrupt pdf, tapping download file shows error pop up "Attachment cannot be downloaded"
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/b7bacd4d-3517-447d-8250-eb8c9abfdef9
View all open jobs on GitHub

Not able to reproduce on latest main

Still repro on build 1.4.22-2
https://github.com/Expensify/App/assets/43995119/a0cc60f4-b578-4dde-9bab-fba9390c0131

https://expensify.slack.com/archives/C01GTK53T8Q/p1704699988214449?thread_ts=1704683805.547759&cid=C01GTK53T8Q

@thienlnam Reopening the issue. We might need a second chance to review it. This PR (https://github.com/Expensify/App/pull/34087) introduced the issue where users can download the invalid file on step 6.
https://github.com/Expensify/App/assets/93399543/f6c31d78-21b9-4c1e-87ff-bcc781d0326d

I think this can still be closed since it's around handling a corrupt PDF and the error messages seem to be correct. cc @thienlnam if you feel differently


Fix mgpu init issue with new version of keras

Ran into this issue while using keras_experiments as a multi-GPU benchmark with newer version of keras (2.2.0).
RuntimeError: It looks like you are subclassing `Model` and you forgot to call `super(YourClass, self).__init__()`. Always start with this line.

Adding this line seems to solve the issue.

Thanks. Let me test this. I recently refactored a few things and updated examples. I did not change the API for ModelMGPU though so it should still work.
I was already calling the super init in line 344:
https://github.com/avolkov1/keras_experiments/blob/99cd23118ad731553ef708d9eff480da35db7ec9/keras_exp/multigpu/_multigpu.py#L344
Let me test with latest Keras.

Good to know. Thank you!


Fix the example in usage.rst

Hello,
First of all, kudos for making this package! I wanted to try it out, and I am a total newbie to async code, so looked at the usage examples and ran into issues:
from healthchecks_io import AsyncClient, CheckCreate

async with AsyncClient(api_key="myapikey") as client:
    check = await client.create_check(CreateCheck(name="New Check", tags="tag1 tag2")
print(check)

There's CreateCheck – I'm guessing it needs to be changed to CheckCreate?
There's a missing closing ")"
When I ran it, I got SyntaxError: 'async with' outside async function. Would be great to fix the example so that it would work as-is, with just putting a valid API key in

Thanks for the feedback. I cleaned up the examples in usage.rst so they should ready to go now.
Let me know if you have any other problems and I'll be happy to fix them up


fix[Link component]: focus and active states

fix[Link component]: focus and active states
(Right now there’s a 3px line underneath for both :focus and :active)

[ ] Change to a one pixel box for :focus (box is 18px in height; 1px weight; 2px offset on either side of type)

[ ] Make sure link token is $body-short-01

[ ] Only difference for :active is that it turns black: underline should stay the same as hover state

[ ] 32px of space between enabled and disabled link in component display window (has nothing to do with the component, this is just website display)

[ ] Restore default distance between underline and link (right now it looks like there’s an offset of 5px); the spec has Sketch default underline (looks like about 1px distance)

Spec:

I think this feedback is based on an outdated version of the component (if it was based on the documentation website's examples then it's outdated)
https://github.com/IBM/carbon-components/pull/1802 should have addressed most if not all of these points if I'm not mistaken

@emyarod Does the Netlify link in #1802 show that this issue is fixed? Thanks!

I believe there is confusion over :focus and :active and that both can be applied on a mouse click (additional discussion here https://github.com/IBM/carbon-components/issues/1909#issuecomment-467183947)

@emyarod
I didn't see these issues linked in air table and I'm not that familiar with the status of link... I checked out those issues and checked off boxes that appear resolved, there are still some fixes here though.
My goals is to try to consolidate all of these audit issues into one and close the others.

just to clarify, on :focus we want the box drawn around the link, and on :active we want the underline is that correct? what do we want to happen when both :focus and :active are applied? it seems like the audit feedback is about :focus together with :active rather than just a single state

Yes that's correct according to the spec... the spec treats them as distinct states...
i would say, if you are focusing and you click the link, you'd see only the active state (just the black underline) not a black focus state. Does that make sense? Or are you thinking that it needs to be a unique combo state for some reason?

got it so :focus:active should be identical to :active, that's what I wanted to clarify since the spec only showed the individual states and not what should happen when both were applied (which occurs on mouse clicks and also when keyboard users press space bar while the link is focused)

Only difference for :active is that it turns black: underline should stay the same as hover state

is there a color token for the :active color and :hover color?

Restore default distance between underline and link (right now it looks like there’s an offset of 5px); the spec has Sketch default underline (looks like about 1px distance)

can I see an example of this with letters like p/q/y etc?

Tokens:

Active state is just $text-01
Hover state is $hover-primary-text

This seems to be working on the next site right now, although I don't think we're calling our link component

got it, opened #1960 @jeanservaas


Flutter plugins not working under Android

In my Flutter App, I make usage of many plugins.
However, there are some of them that simply won't work under Android (i.e. under iOS they work perfectly fine).
Inside pubspec.yaml File I have the following list of packages that I intend to use in my Flutter app.
The ones commented-out do not work under Android !
dependencies:
  flutter:
    sdk: flutter
  shared_preferences: ^0.5.2+1
  sqflite: ^1.1.5
  intl: ^0.15.8
  tuple: ^1.0.2
  material_design_icons_flutter: ^3.2.3695
  launch_review: ^2.0.0
  fit_image: ^0.1.2
  datetime_picker_formfield: ^0.1.8
  flutter_screenutil: ^0.5.2
  path_provider: ^1.1.0
  # image_picker: ^0.6.0+8
  # url_launcher: ^5.0.2
  # permission_handler: ^3.1.0
  # flutter_downloader: ^1.1.7
  large_file_copy: ^0.0.1
  flutter_localizations:
    sdk: flutter
  cupertino_icons: ^0.1.2

I work with Android SDK 28
My Flutter project, I create with:
flutter create --org ch.myorg -i swift -a kotlin <my_app_name>

How can I get these packages to work under Android ????
  image_picker: ^0.6.0+8
  url_launcher: ^5.0.2
  permission_handler: ^3.1.0
  flutter_downloader: ^1.1.7

I did the following trials:

typed flutter clean
typed flutter packages get
opened Android Studio to see if it cleans the bugs - but no chance
migrated to AndroidX (but this is the biggest mess you can imagine since corrupting the other packages that worked fine before the migration)
I created a completely new Flutter project and added no code whatsoever (i.e. work with the hello-world app) and keep adding packages to the pubspec.yaml file to see which packages crash the Android version. Then for the first one crashing, I try to step back versions in order to find any package-version that might not crash. But this is like finding a needle in a haystack... No chance either...
I went to get the package-creator's GitHub project and tried their example app (i.e. each package has an example) - but the same issue: Android does not work !
I created a completely new Flutter app and took the main.dart content of a package-provider-example main.dart code (in order to have all the android\local.properties etc. in a correct state given by the flutter create) and then I added the pubspec.yaml content form the package also into the new flutter app in order to get the necessary dependency. But same, thing: Android does not work !! (iOS works always..)
I uninstalled Android Studio and re-installed it. I uninstalled Flutter and Dart and re-installed it. No effect...

I am more than desperate to get this to work since I lost 6 days so far trying to get these Flutter packages to run under Android... :(
Any help highly appreciated.
Here is my flutter doctor -v output:
flutter doctor -v
[✓] Flutter (Channel stable, v1.5.4-hotfix.2, on Mac OS X 10.14.5 18F132, locale
    en-CH)
    • Flutter version 1.5.4-hotfix.2 at /Users/user/Documents/flutter
    • Framework revision 7a4c33425d (4 weeks ago), 2019-04-29 11:05:24 -0700
    • Engine revision 52c7a1e849
    • Dart version 2.3.0 (build 2.3.0-dev.0.5 a1668566e5)

[✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
    • Android SDK at /Users/user/Library/Android/sdk
    • Android NDK location not configured (optional; useful for native profiling
      support)
    • Platform android-28, build-tools 28.0.3
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_152-release-1343-b01)
    • All Android licenses accepted.

[✓] iOS toolchain - develop for iOS devices (Xcode 10.2.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 10.2.1, Build version 10E1001
    • ios-deploy 1.9.4
    • CocoaPods version 1.6.1

[✓] Android Studio (version 3.4)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 35.3.1
    • Dart plugin version 183.6270
    • Java version OpenJDK Runtime Environment (build
      1.8.0_152-release-1343-b01)

[✓] VS Code (version 1.34.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.0.2

[✓] Connected device (1 available)
    • Android SDK built for x86 • emulator-5554 • android-x86 • Android 9 (API
      28) (emulator)

• No issues found!

Here is an example of getting one single package to work under Android - my trial is with file_downloader (Link to package definition):
Below you find the cryptic error log when I try with the file_downloader package:
Step 1 : create a completely new Flutter project with flutter create --org com.myorg -i swift -a kotlin testy
Step 2 : fill in the package-dependencies inside the pubsep.yaml file (i.e. taken from the package-example). Here are the dependencies for this package example:
dependencies:
  flutter:
    sdk: flutter
  path_provider: ^0.4.0
  permission_handler: ^3.0.0
  flutter_downloader: ^1.1.7
  cupertino_icons: ^0.1.2

Step 3 : Keep the main.dart as the default "hello world" app (i.e what is there after flutter create...)
Therefore we only changed a few pubspec.yaml dependencies in comparison with a fresh new Flutter create app. And the dependecies is what the package-provider suggests in his/her example !
The "hello world" App works fine under Android & iOS. However, adding a few pubspec.yaml dependencies makes the Android crash (iOS works fine)...
Here is the error log when Android is launched:
* Error running Gradle:
ProcessException: Process "/Users/user/Flutter_applications/01_MyOwn_Flutter_apps/testy/android/gradlew" exited abnormally:
Starting a Gradle Daemon, 5 stopped Daemons could not be reused, use --status for details

FAILURE: Build failed with an exception.

* Where:
Script '/Users/user/Documents/flutter/packages/flutter_tools/gradle/flutter.gradle' line: 200

* What went wrong:
A problem occurred configuring project ':flutter_downloader'.
> Failed to notify project evaluation listener.
   > Could not get unknown property 'android' for project ':flutter_downloader' of type org.gradle.api.Project.
   > Could not find method debugProvided() for arguments [file collection] on object of type org.gradle.api.internal.artifacts.dsl.dependencies.DefaultDependencyHandler.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 7s
  Command: /Users/user/Flutter_applications/01_MyOwn_Flutter_apps/testy/android/gradlew app:properties

Exited (sigterm)

Other packages deliver slightly different errors. But it is always something with a gradle-issue or an android-incompatibility. What Android version do I need to install ? Isn't the newest stable one the best option ??  How do I find out which package-versions fit which Android-version ? How can I match the two ??? (and still keep all my other packages running).
After my odyssey, I wonder, isn't Flutter a bit of a mess if it comes to Android dependencies ???
Any suggestion on how to deal with these kind of problems are highly appreciated. How do you proceed normally with Flutter packages and Android compatibility ???

Or here another example with image_picker package (coming from Flutter Team here):
Steps 1-3 are the same as above. All I do is creating a hello-world Flutter app and adding the dependencies as stated in the package-example:
Here the image_picker dependencies:
dependencies:
  flutter:
    sdk: flutter
  video_player: 0.5.2
  image_picker: ^0.6.0+8
  cupertino_icons: ^0.1.2

And here the Android Error:
* Error running Gradle:
ProcessException: Process "/Users/user/Flutter_applications/01_MyOwn_Flutter_apps/testy/android/gradlew" exited abnormally:

FAILURE: Build failed with an exception.

* Where:
Script '/Users/user/Documents/flutter/packages/flutter_tools/gradle/flutter.gradle' line: 200

* What went wrong:
A problem occurred configuring project ':image_picker'.
> Failed to notify project evaluation listener.
   > Could not get unknown property 'android' for project ':image_picker' of type org.gradle.api.Project.
   > Could not find method debugProvided() for arguments [file collection] on object of type org.gradle.api.internal.artifacts.dsl.dependencies.DefaultDependencyHandler.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 0s
  Command: /Users/user/Flutter_applications/01_MyOwn_Flutter_apps/testy/android/gradlew app:properties

Please review your Gradle project setup in the android/ folder.
Exited (sigterm)

I somewhat advanced (i.e. getting at least 2 out of the 4 corrupt dependencies to work).
Step 1 : Inside my flutter SDK install folder, I typed into a terminal:
git clean -xfd

git stash save --keep-index

git stash drop

git pull

flutter doctor

Step 2 : Inside my flutter app folder, I did also type in the terminal:
flutter packages pub cache repair

Step 3 : Inside Visual-Studio-Code, I also did a Flutter deinstall and Dart deinstall. And re-installed the two. I restarted Visual-Studio-Code.
Having completed these three steps, I get two out of 4 dependencies back alive and my Android "hello world" app at least compiles (except for the last two buggers). The two buggers still not working under Android are commented-out in the following pubspec.yaml dependency list :
dependencies:
  flutter:
    sdk: flutter
  shared_preferences: ^0.5.2+1
  sqflite: ^1.1.5
  intl: ^0.15.8
  tuple: ^1.0.2
  material_design_icons_flutter: ^3.2.3695
  launch_review: ^2.0.0
  fit_image: ^0.1.2
  datetime_picker_formfield: ^0.1.8
  flutter_screenutil: ^0.5.2
  path_provider: ^1.1.0
  image_picker: ^0.6.0+8
  url_launcher: ^5.0.2
  # permission_handler: ^3.1.0
  # flutter_downloader: ^1.1.7
  large_file_copy: ^0.0.1
  flutter_localizations:
    sdk: flutter
  cupertino_icons: ^0.1.2

For the two dependencies (i.e. permission_handler and flutter_downloader), I now get a new error when trying to build for Android:
* What went wrong:
Execution failed for task ':app:preDebugBuild'.
> Android dependency 'androidx.core:core' has different version for the compile (1.0.0) and runtime (1.0.1) classpath. You should manually set the same version via DependencyResolution

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 3s
*******************************************************************************************
The Gradle failure may have been because of AndroidX incompatibilities in this Flutter app.
*******************************************************************************************
Gradle task assembleDebug failed with exit code 1
Exited (sigterm)

Now I am back to the need for AndroidX migration, it seems. But I really fear of doing that since it corrupts all the other nicely working packages.
What do you suggest to do here as for the error message ?? How do I get the last two packages to work as well (next to all the other packages) ???
Any help appreciated !!

I FINAAALLY FOUND A SOLUTION:
Some more Android Studio steps to go through made the last two dependencies finally work. (i.e. mixed with some prayers and hopeful thought that the Flutter Team will make this more simple in the future).
Wit the next three steps I get all four buggers up-n-running !!!
Step A : Open Android Studio
This can best be done inside VSCode by right-clicking the /android folder inside your Flutter project and selecting Open in Android Studio

Step B : Press the Make Project hammer inside Android Studio to cause some Android Studio checkups to run...

Step C : Wait and pray (so that Android Studio makes the magic cleansing)
It turns out that Android Studio does not really grasp all mistakes as for the package compatibilities. Therefore, I went through all Gradles and checked manually for...
a) newest build.gradle version (i.e. hovering over any grey'isch gradle line by the mouse will show the newest version and you can change manually accordingly)
b) newest Kotlin version (to find out which Kotlin version is the newest one, please go to the SDK-manager inside Android Studio and select Kotlin. This will reveal the newest version. Make sure to integrate this version in every gradle accordingly)
Here is an illustration where and what to change:

And here an illustration on where to change for the newest Kotlin version :

WITH THE ABOVE STEPS 1-3 AND STEPS A-C, I ACHIEVED GETTING ALL THE DEPENCENCY PACKAGES RUNNING UNDER ANDROID.
I hope that the Flutter Team will be able to make this process somewhat more transparent in the future - and I am sure they will.

I have the same problem, but only with cloud_firestore and flutter_webview_plugin. According to their release releases, the support AndroidX since March. I have tried Migrate to AndroidX... button and the first time it did some refactoring, but didn't help at all. I can run the app in Android Emulator (most of the time). Of course I followed the steps on the Flutter documentation page, but still no luck. Can someone please just tell me what I'm doing wrong? Either this is a total failure of Android/Flutter team, or I'm just not getting it.

Did you try Step 1 - 3 (as described in my post here)  or maybe also Step A - C (as described in my last post here).
I know how frustrating it can be to get Flutter plugins/packages to work!
I recommend, really, to start with a hello world app, then add your dependency inside pubspec.yaml and compile to see.
If a simple hello-world app with the dependencies does not compile out of the box - then you know that your Android (and/or Android Studio) is corrupt. I then recommend the steps A - C as described. That's the best I can come up with. Good luck !!

@iKK001 Thanks! I will try just that. I also think that there's something wrong in my project.

@iKK001 as soon as I add cloud_firestore in pubspec.yaml the build fails. I will now try Migrate to AndroidX...

The project seems to be building just fine now, somehow! Going to move my code to this empty project. Thanks @iKK001

Going to move my code to this empty

sadly this is quite a common thing I have to do with the android config files. I wish there was a nicer way to edit things like the manifests and grade files. but thats more of a general android problem

Thanks JAicewizard. I really hope, Google is recognising the pain the dependency-jungle (as good as its intentions might be) puts on all of us. Especially, Flutter-packages/plugins do not get easy with this dependency-jungle. I am happily waiting and have good faith that this will eventually be addressed by Google and Teams.

Hi @iKK001
are you still experiencing this issue with the latest version of Flutter?
If so can you please provide your flutter doctor -v?
Also, to better address the issue, would be helpful
if you could post a self contained app on github
or the steps to reproduce it.
Thank you

Without additional information, we are unfortunately not sure how to resolve this issue. We are therefore reluctantly going to close this bug for now. Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.


Product stream has no filters exception

Description:
When creating products via the Admin API (Action Sync), we would like to add cross-selling and product streams directly. A dynamic product group should be assigned to the cross-selling, which is created at the same time. This works as expected. cross-sellings and dynamic product groups are created. The problem is that all created product groups are invalid until the index is finished. While the dynamic groups are invalid and the cross-selling is active, a NoFilterException is displayed in the frontend for this product and the detail page is not usable
Steps to reproduce:
update a product (See payload down below) with cross-selling and product_stream and use queue indexing ("indexing-behavior": "use-queue-indexing"). Open the product in the frontend
Expected result:
No exception in the frontend, instead just display no cross-sellings
Actual result:
NoFilterException is thrown
payload:
{
"write-product": {
"entity": "product",
"action": "upsert",
"payload": [
{
"id": "7fc79315598ead595285968e5f561865",
"crossSellings": [
{
"id": "ef23268669fb6d8a7def2b9f2da0aceb",
"name": "Test Crossselling",
"position": 1,
"sortBy": "cheapestPrice",
"sortDirection": "DESC",
"active": true,
"type": "productStream",
"productStream": {
"id": "49561f6faa0badfce831a183d2ec7c2f",
"name": "Product Stream Test",
"filters": [
{
"type": "multi",
"id": "018c0feb0baf7e5088102469dfce2e77",
"productStreamId": "49561f6faa0badfce831a183d2ec7c2f",
"operator": "OR",
"queries": [
{
"id": "49561f6faa0badfce831a183d2ec7c2f",
"productStreamId": "49561f6faa0badfce831a183d2ec7c2f",
"type": "contains",
"field": "productNumber",
"value": "DJR0-MEF",
"position": 0
},
{
"id": "018bf5feb3da7d6eafb53e810f1debc0",
"productStreamId": "49561f6faa0badfce831a183d2ec7c2f",
"type": "contains",
"field": "productNumber",
"value": "DJR0-5CW",
"position": 1
}
]
}
]
}
}
]
}
]
}
}

[public] Automated response: This issue is linked to the internal issue https://shopware.atlassian.net/browse/NEXT-32090.
[created from NEXT-32090, comment 485446]

[public] Hello,
Within our company roadmap and work capacity, we try to address each bug or improvement request but admit that not each one will be resolved. To continue our culture of honesty and openness, we are closing this issue to focus on our roadmap on behalf of all Shopware users.
If you feel like this issue is still impacting you, please create a new issue and let us know. Thank you again for your valuable feedback.
[created from NEXT-32090, comment 501296]


Support node 4.0.0

Update dependency jsdom and engines so we can run in node 4.0.0

:heart_eyes: