add CITATION.cff and lint workflow

Changes
add CITATION.cff
Related Issues
Closes #567
Checks

[x] update manifest file

please feel free to update your ORCID or other metadata @vhirtham @marscher

we just need to make sure to fill out/update these fields before tagging a release
version:
date-released:

the release workflow is currently documented in a github discussion, right? Otherwise I'd update that guide document in the repo.

the release workflow is currently documented in a github discussion, right? Otherwise I'd update that guide document in the repo.

it was in discussions but it is probably easier to spot in the repo right? (also to follow updates)
see https://github.com/BAMWelDX/weldx/pull/570

the release workflow is currently documented in a github discussion, right? Otherwise I'd update that guide document in the repo.

it was in discussions but it is probably easier to spot in the repo right? (also to follow updates) see #570

As an alternative or addition, we could also just create a pull request template for releases. As far as I can remember this is possible, but you need to know that it exists and you have to manually update the url when creating a new PR


[BUG] Removing vault from folder, removes in every view

Describe the bug
When removing a added vault from a folder, this vault won't appear in the vault selection view until the edit button is triggered.
To Reproduce
Steps to reproduce the behavior:

Remove a vault from a folder
go back to vault selection view
See error
toggle edit to fix it

Expected behavior
Show vault in vault selectoin view after removing from folder

on main branch

QA done.


Space combat chatter overlaps with banter

When engaging in space combat, your crew will call out things disabled or repaired systems on the enemy or your own vessel. This will often overlap with companion banter if you have multiple on board, making the dialogue both very hard to understand and to follow. This happens particularly often when jumping straight into an active combat.

Game Version
<IP_ADDRESS>
New Game
No
Reproduction Steps

Have companions with banter dialogue on your vessel (Barrett seems particularly prone, combine with Sam, Andreja, or Sarah)
Jump/travel to a location where space combat immediately commences

This is fixable (I have a mod to do this), but this is less of a bug and more of a design decision. Not s good one though, mind you.


[SPARK-6024][SQL] When a data source table has too many columns, it's schema cannot be stored in metastore.

JIRA: https://issues.apache.org/jira/browse/SPARK-6024

Test build #28020 has started for   PR 4795 at commit 12bacae.

This patch merges cleanly.

Test build #28022 has started for   PR 4795 at commit cc1d472.

This patch merges cleanly.

Test build #28020 has finished for   PR 4795 at commit 12bacae.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28020/
Test PASSed.

Test build #28022 has finished for   PR 4795 at commit cc1d472.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28022/
Test PASSed.

Test build #28025 has started for   PR 4795 at commit 143927a.

This patch merges cleanly.

Test build #28025 has finished for   PR 4795 at commit 143927a.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28025/
Test PASSed.

Test build #28031 has started for   PR 4795 at commit 73e71b4.

This patch merges cleanly.

Test build #28031 has finished for   PR 4795 at commit 73e71b4.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28031/
Test PASSed.

Test build #28043 has started for   PR 4795 at commit 4882e6f.

This patch merges cleanly.

lgtm

Test build #28043 has finished for   PR 4795 at commit 4882e6f.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28043/
Test PASSed.

Merging in!


 Each tx consists of a batch call  to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.
This benchmark source data is available in JSON format on S3 here.
L2 block published to L1
Each column represents the number of txs on an L2 block published to L1.

Metric
8 txs
32 txs
64 txs

l1_rollup_calldata_size_in_bytes
740
740
740

l1_rollup_calldata_gas
6,692
6,680
6,692

l1_rollup_execution_gas
586,877
586,865
586,877

l2_block_processing_time_in_ms
1,622
6,028
11,932

l2_block_building_time_in_ms
:warning: 35,289 (+32%)
:warning: 138,524 (+32%)
:warning: 274,890 (+32%)

l2_block_rollup_simulation_time_in_ms
:warning: 35,071 (+32%)
:warning: 137,746 (+32%)
:warning: 273,377 (+32%)

l2_block_public_tx_process_time_in_ms
:warning: 16,510 (+38%)
:warning: 70,574 (+39%)
:warning: 141,499 (+38%)

L2 chain processing
Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric
5 blocks
10 blocks

node_history_sync_time_in_ms
18,071 (+1%)
33,660

node_database_size_in_bytes
21,319,760
38,068,304

pxe_database_size_in_bytes
29,868
59,425

Circuits stats
Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Metric
1 leaves
16 leaves
64 leaves
128 leaves
512 leaves
1024 leaves
2048 leaves
4096 leaves
32 leaves

batch_insert_into_append_only_tree_16_depth_ms
13.1
21.5 (+1%)
N/A
N/A
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_16_depth_hash_count
16.7
31.8
N/A
N/A
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_16_depth_hash_ms
0.767
0.660
N/A
N/A
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_32_depth_ms
N/A
N/A
61.4 (-1%)
96.9
315
609 (-1%)
1,191
2,354
N/A

batch_insert_into_append_only_tree_32_depth_hash_count
N/A
N/A
95.9
159
543
1,055
2,079
4,127
N/A

batch_insert_into_append_only_tree_32_depth_hash_ms
N/A
N/A
0.631 (-1%)
0.600
0.574
0.570 (-1%)
0.565
0.564
N/A

batch_insert_into_indexed_tree_20_depth_ms
N/A
N/A
73.9
143
454
895
1,768
3,520
N/A

batch_insert_into_indexed_tree_20_depth_hash_count
N/A
N/A
106
208
692
1,363
2,707
5,395
N/A

batch_insert_into_indexed_tree_20_depth_hash_ms
N/A
N/A
0.645
0.645
0.619
0.616
0.614
0.614
N/A

batch_insert_into_indexed_tree_40_depth_ms
N/A
N/A
N/A
N/A
N/A
N/A
N/A
N/A
80.6

batch_insert_into_indexed_tree_40_depth_hash_count
N/A
N/A
N/A
N/A
N/A
N/A
N/A
N/A
108

batch_insert_into_indexed_tree_40_depth_hash_ms
N/A
N/A
N/A
N/A
N/A
N/A
N/A
N/A
0.709

Miscellaneous
Transaction sizes based on how many contract classes are registered in the tx.

Metric
0 registered classes
1 registered classes

tx_size_in_bytes
:warning: 84,440 (+23%)
673,183 (+1%)

Transaction size based on fee payment method
| Metric |  |
| - |  |
Transaction processing duration by data writes.

Metric
0 new note hashes
1 new note hashes
2 new note hashes

tx_pxe_processing_time_ms
:warning: 37,338 (+34%)
:warning: 3,676 (+20%)
:warning: 114,473 (+25%)

Metric
0 public data writes
1 public data writes
2 public data writes
4 public data writes
8 public data writes

tx_sequencer_processing_time_ms
:warning: 1,296 (+59%)
:warning: 2,243 (+44%)
:warning: 1,916 (+45%)
:warning: 2,840 (+33%)
:warning: 1,820 (+38%)


Doesn't work for large integers

This is probably an issue with the the numerical calculation of the square root:
>>> from pairing_functions.cantor import pair, unpair
>>> unpair(pair(129315199267255490,<PHONE_NUMBER>15119))
>>><PHONE_NUMBER>86870608, 0)

I'm wondering if the integer-root can be efficiently calculated non-numerically.

I've read a bit about this here and came across Newton's method. Implementation for Cantor pairing seems to work
def isqrt(n):
    x = n
    y = (x + 1) // 2
    while y < x:
        x = y
        y = (x + n // x) // 2
    return x

def pair(k1, k2):
    return (k1 + k2) * (k1 + k2 + 1) // 2 + k2

def unpair(z):
    a = 8 * z + 1
    # rewrite the pairing thing as sqrt((8z + 1)/4) - 1/2
    # floor(sqrt(a/4) - 1/2) is in [floor(a/4), floor(a/4)-1]
    # depending on whether sqrt(a/4) has the first decimal number < 5
    m = isqrt(100 * a // 4)
    w = m // 10

    if m % 10 < 5:
        w -= 1

    t = (w * w + w) // 2
    y = z - t
    x = w - y
    return x, y

The pairing thing refers to w inside the calculation of unpair from here

Hello @kuco23!
Thank you for raising this (interesting) behavior! We will try to find some time to review it more thoroughly in the next couple of weeks.
But, since you've already done the majority of the mental work, it would be even better if you would like to submit a Pull Request on this and discuss it further there =)
p.s. If you have any other feedback as a package user, always glad to hear it!

Maybe it's not that relevant, but there exists Gödel numbering, which pairs any sequence, while also encoding its length (so, when unpairing you don't need to specify it). In a way, it's a generalization of pairing. It's pretty useless, though somewhat mathematically relevant.
But the same functionality can be implemented efficiently by e.g. pairing (1,2,3) to 1|2|3 and then interpreting | as an extra symbol in the base-11 system. Or interpreting each 1,2 and 3 in binary, then separating those by 3 (and maybe then interpreting that in trinary system, as only 3 symbols are ever used).
Just brainstorming here. I needed some of those things in relation to a cryptography project.


add missing support for esriSMS symbol

[ ] angle

xoffset and yoffset is not possible, not supported by ol3

The angle property defines the number of degrees (0 to 360) that a marker symbol is rotated. The rotation is from East in a counter-clockwise direction where East is the 0° axis.

In ol3: Rotation in radians (positive rotation clockwise). Default is 0.


Refactor fetch logic to be separated from Client

This PR is an initial draft/proposal to introduce "exchanges". It's a structure that will enable us to implement more features in the future and to clean up the existing logic.
On the TypeScript side it introduces some new interfaces:

IOperation — This is an instruction for an "Exchange" to go talk to the GraphQL API
IExchange — This is an "Exchange". It's a function that accepts an IOperation and returns an Observable of a GraphQL ExecutionResult

Effectively with just two new type "primitives" we can separate the fetch logic from the Client and clean everything up. This means that the Client now calls the exchange to actually start a request.
To demonstrate what this means I've implemented the dedupExchange. This is a first attempt at separating some concerns out of the client. We might even want the cache to be an exchange eventually? The dedupExchange looks at the operation's key (which is the hash that we had before) and only sends off a single request, i.e. passes the operation on only once.
As an experiment of what we might want to do with Observables I've added some request cancellation to the httpExchange. It's unused as currently we pass on Promises to the components and not Observables.
There might be a couple of details that I've left out here in the description, so just post comments with any concerns and questions please 😅
Edit: @kenwheeler the executeMutation accepted an IMutation which is the component prop's type before. I suppose that was a mistake so I swapped it out with the IQuery :+1:
Also, their promises resolved to object[] quite often, which I guess should be object? I've also refactored more things to use ExecutionResult instead.

Pull Request Test Coverage Report for Build 109

60 of 63 (95.24%) changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-1.3%) to 94.586%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/modules/http-exchange.ts
25
28
89.29%

Totals

Change from base Build 107:
-1.3%

Covered Lines:
218

Relevant Lines:
222

💛  - Coveralls


how to get the non-normalize depth value?

Hi,
Thank you for you amazing project.
Now when I use
depth_map, _ = kal.render.mesh.rasterize(dims[1], dims[0], face_vertices_camera[:, :, :, -1], face_vertices_image, face_vertices_camera[:, :, :, -1:])#torch.Size([1, 1024, 1024, 1])
to get depth map, I find the depth is in the range of 0 to 1, how can I get the non-normalize depth map with true distance?
Thank you.

Hi,
thank you for your reply,
this is face_vertices_camera function
face_vertices_camera, face_vertices_image, face_normals = kal.render.mesh.prepare_vertices(
                verts.to(self.device), faces.to(self.device), self.camera_projection, camera_transform=camera_transform)

this is self.camera_projection
kal.render.camera.generate_perspective_projection(np.pi / 3).to(device)
this is camera_transform
camera_transform = self.get_camera_from_view(torch.tensor(elev), torch.tensor(azim), r=radius,
                                                look_at_height=look_at_height).to(self.device)

the face_vertices_camera is only post extrinsics, so the depth you are seeing is not normalized.
Do mind that the current depth that you are display is the distance to camera plane, depending the definition of "depth" you may have to interpolate the whole face_camera instead of z and then compute the norm (torch.linalg.norm)


Question about CLIP's zero-shot performance on the UCF101 dataset

Hi, thanks for your great paper.
I have a question about CLIP's zero-shot performance on the UCF101 dataset. In Table 1b of this paper, the zero-shot top1 accuracy of CLIP in UCF101 is 74.5%, but according to Figure 3 of the ActionCLIP, the zero-shot accuracy of CLIP is near 70%.
Is there any difference in implementation?

Hey, I don't remember the details of ActionCLIP, but here are some potential differences that come to my mind:

We reported only the split 1 on UCF101, I think the same as CLIP did.
The frame sampling strategy. We take 4 frames uniformly.
The text prompting. We use text prompts, the same ones as CLIP.

I think a 5% top-1 accuracy difference is reasonable if the evaluation protocol is not exactly the same.

thanks a lot


Add hetznercloud plugin into molecule image

Closes https://github.com/ansible-community/molecule/issues/2673.
Despite my unwillingness, the plugin is now tested again py36,37,38. The plugin has full integration testing implemented (see CI build here). The plugin is being used actively. The release schedule will follow semver. If this doesn't make it in I don't know what will ;)

https://pypi.org/project/molecule-hetznercloud/

This PR is likely obsoleted by https://github.com/ansible-community/molecule/pull/2680

Running with https://github.com/ansible-community/molecule/pull/2680 then.


Avoid template naming conflict

Have you thought about renaming the template method to avoid conflicting with the HTML <template> tag? For example, render?
This would completely remove that gotcha/caveat, and also makes a little more sense from a naming POV.

I have thought about it a lot and I haven’t been able to come up with a good name that isn't taken. The instance method render is used to render other things inside the template. call is part of the external API so doesn't make sense to define that directly. I’m not a fan of build or perform.

Maybe it's because I know Vue a little, but because of Vue there's kind of a precedent for using template as the markup generating block in single file components. Sure, it's more correct in javascript land, but it still feels conceptually right to me. (Also, I think the conflict with the template element is pretty niche unless you use the template tag a lot, and when you write HTML with a Ruby DSL, I think adjustments are to be expected anyway.)

It's worth noting that it is possible to correct template calls from inside the template method using the compiler. I just don't know if I want to go down that path because then it's not really Ruby anymore. It's a new language that operates slightly outside of the Ruby rules.

I think this might be a way out. https://github.com/joeldrapper/phlex/pull/260

Oh nice! 👏
And as a happy side note, I think this should also work for #259...
# ...
if block.instance_variable_get(:@rendering)
  respond_to?(:before_render) && before_render
  super(&block)
else
# ...

I still can't help but thinking that render would be a better name for the template method, and rename the internal methods that conflict.  But the above is ✨

render is a verb, it's a "so something" method. template conceptually doesn't do anything, it is something.
As things stand, we go through three methods to render a template and I think they're well named: when I render a view, the view is called and outputs its template.

When you describe it like that, it makes sense, but as far as a public API is concerned, the template method is all that matters, and I see that as I am rendering the content of the method that is currently called template. So a verb makes sense.
But hey, each to their own. You've already solved the template HTML tag conflict, so I'm happy 👏
thx

Naming is hard.

Oh don't remind me 😫

I’ve closed #260. I’ll keep this issue open until 1.0 if anyone wants to suggest another approach or alternative name.

You know if we pick one of these, within hours there'll be an update to the HTML spec adding a tag by the same name. 🙃

You know if we pick one of these, within hours there'll be an update to the HTML spec adding a tag by the same name. 🙃

🤣 The html maintainer is watching this thread.
Btw, I think template is a good name, I think it's a pain you can live with. An alternative would be call to define structure (like some service objects, interactors, etc) and rename the current call method to another name

I used to think template was perfect even though the template tag exists, but markup is growing on me. def markup is kinda what the method does, isn't it? It literally defines what the markup of the component will be.

I was actually just about to +1 on markup. It's kinda like template, but HyperTextMarkupLanguage 😄

What about phlexml? 🙃

I actually found a way to get the template method to work, but it's slow. If the compiler turns out to be as reliable as I hope it will be, we could use this slow technique but then optimise it in the compile step.

OMG 😱 I love it! 🤣

If the compiler does it's job, then I would guess we wouldn't have to worry about performance as much.

If the compiler does it's job, then I would guess we wouldn't have to worry about performance as much.

Right, the compiler can completely remove this problem as long as we can solve it (slowly) without it. I’m just not confident enough that the compiler will be reliable enough to commit to it yet, but it's looking good so far.


Artifacts with depth maps?

Hi there I noticed some potential issues with a few depth maps, where pixels that belong to a open window have large depth values, instead of 0. Here is the 0003 image of the released bedroom scene.

Note the yellow strip in the center figure, which are inside the white area of the 'window hole'; the pixels have large depth values but ideally should be infinite (0) because they correspond to the outdoor env. I pick two locations (red dot and green dot) on the figures, and query the depths, getting 4.3840003 3.1920002 respectively, but the former one should be 0.
As a result, if you simply back-project depth to 3D, you get fantom geometry (in red circle).

Not sure if this is an issue with the way I read the depth file (cv2.imread(filename, -1)), or the depth file itself.

Thanks for your careful observation! This is because our original scene in fact is a model of a large house containing several rooms. The "yellow strip" in the depth map you observed is the outer wall of another room, which happens to be seen by some cameras😂

From my point of view, these observations of "other rooms out of the window" should happen rarely. I think this will cause negligible impacts.

Oh I see. Thanks for the timely explanation! Yeah geometry that lie outside of the room do not exactly following the inverse rendering assumption and lighting model, that light transport only happens between objects/emitters inside the room plus received light from outside envmap through a window, so there is a chance that those pixels yield larger re-rendering errors. But I agree that given the number of those pixels are small compared to all pixels, this might not be a big issue.


Pathfinder initial web page not loading

I have this problem every time i try to load Pathfinder, any idea how to solve it?
I get the issue both in firefox and google/chrome?

In chrome pres f12 to get the dev console open and then go to the tab Network, refresh pathfinder and take a printscreen of that.
Should look something like this:

@SentientPulse This issue is a dublicate of #677
Please read my comment and let me know if you have a similar issue:
https://github.com/exodus4d/pathfinder/issues/677#issuecomment-419486250


olimexino_stm32: Use stm32flash runner

olimexino_stm32 board doesn't have a
debugger. Now that stm32flash
runner is available, let's use it.
Signed-off-by: Yannis Damigos<EMAIL_ADDRESS>

@boretom Could you also have a look?

Hi @ydamigos

@boretom Could you also have a look?
Your call of the stm32flash runner looks fine to me.

As @mbolivar mentioned there can be multiple runners in the board.cmake. Leave the jlink runner in and add the stm32flash runner before the jlink to have it as the default runner. If someone wants to use the jlink runner she can use the --runner parameter of west flash. Have a look at boards/arm/nrf52840_pca10059/board.cmake to see an example of multiple runners for a board.
To be a bit of stickler: stm32flash runner is only useful for flashing or reading the firmware AFAIK, not debugging. That'd be jlink job :)
Have a good day
Thomas

@mbolivar, @boretom Thanks for the tips.


Try set CMP0068

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


Don't start agent until user has setup profile

To prevent unnecessary mediation requests, we should hold off on starting the agent until after their profile has been setup. See #5

We now redirect to a onboarding page that must be completed before we allow for a DID to be generated


Query Callback error when including delay

I'm Using version 2.7 and whenever I use the callback function with a delay after the function it crashes. Works fine without the delay though.
Message:
/home/ricardo/testing/node_modules/taffydb/taffy.js:806
          f.call( that.getroot( that.context() ) );
            ^

TypeError: f.call is not a function
    at Timeout._onTimeout (/home/ricardo/testing/node_modules/taffydb/taffy.js:806:13)

After a while I noticed that the issue was with my local version of the package. I'l closing this issue.


[AutoPR compute/resource-manager] Dev/ccelik/dedicatedhostswagger

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/6612

This PR has been merged into https://github.com/Azure/azure-sdk-for-go/pull/5212


Routes ending with an optional slug are not working anymore

Version
nuxt-i18n: 6.27.3
nuxt: 2.15.7
Nuxt configuration
mode:

[x] universal

Nuxt-i18n configuration
i18n: {
    strategy: 'prefix',
    lazy: true,
    detectBrowserLanguage: false
}

Steps to reproduce
nuxt.config.js
i18n: {
    strategy: 'prefix',
    lazy: true,
    detectBrowserLanguage: false
},
router: {
    trailingSlash: true
}
modules: [
    '~/modules/routes'
]

modules/routes.js
export default async function asyncModule() {
  this.extendRoutes(function extendRoutes(routes, resolve) {
    routes.push({
      name: 'product-page',
      path: `/:product(game|software)/:uid/:slug?`, // <-- notice the optional slug used with "?"
      component: resolve(__dirname, 'pages/product.vue')
    });
  }
}

What is Expected?

A route with a path of /es-ES/:product(game|software)/:uid/:slug?/ should be created and listed in $nuxt.$router.options.routes
Browsing to /game/98f76a/cod/ should return the correct page as worked in<EMAIL_ADDRESS>
What is actually happening?

A route with a path of /es-ES/:product(game|software)/:uid/:slug/? gets created (Notice the ? got moved to the end of the path) and listed in $nuxt.$router.options.routes.
Browsing to /game/98f76a/cod/ returns a 404 error page.

Hello,
A simple reproduction? Might be related #1002.
Thanks!

I can reproduce. It's caused by #1214


Add Special Case for CCLW urls

@THOR300 The code has diverged quite a lot since this PR was raised, but it would be really nice to integrate the naming changes to make the update code a bit clearer...

This is three days short of being exactly a year old, so its getting closed 😄


fix(mp4): no longer hang on export when taking a video

This fixes a hang that occured on mp4 conversion when capturing a new video.
Also fixes the filename.

:tada: This PR is included in version 5.3.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Setup Prow for this project

Goal: Setup Prow to enable the use of commands on issues and PRs in this project
Acceptance Criteria:

Prow is enabled for this repository
Commands can be used on issues and PRs (/assign, /lgtm, /approve, etc.)

Just a note, this seems like it could already be done by default as being a part of the operator-framework org


PR: Add support for eslint-plugin-flowtype-errors

This plugin allows flow to be run as an eslint plugin 🎉 Would a PR for this be welcome?

@amilajack Thanks for your interest in Pepperoni! 🍕 🚀
Right now Pepperoni isn't using Flow, so integrating this would require more flow modules/plugins to be added? Also we don't want to mandate users of Pepperoni to use Flow, so maybe a PR would be best in the newly created #129. What do you think?

That would be great. Thanks!


[WFCORE-6617] Clean out ts.elytron profile cruft

Issue: https://issues.redhat.com/browse/WFCORE-6617 [WFCORE-6617] Clean out ts.elytron profile cruft

Thanks @soul2zimate !


IBM Docs and IBM Masthead new AI slug in search bard

The problem
IBM Docs and IBM Masthead search are getting ready to put into production watsonx on IBM Docs and watsonx on IBM Search
This corporate sponsored and approved use of watsonx is designed to augment the current customer search and will reuse the current search experience
In preparation for this,  @dallashudgens designs include the AI slug in our search bar:

In reviewing the documentation for use of the AI slug, we reviewed your airtable that is tracking all the different ways you are adding the component. But you have not included in the search bar. This is a critical use case for us to meet our deadline to get watsonx on masthead search and IBM Docs search into test env then into product within the quarter
We noticed in “Demo 1” column we go to a react story book and you have a great example of a slug in a drop down: https://web-components.carbondesignsystem.com/?path=/story/experimental-slug-examples--select
As I said, we do not  see one added to search yet, but we are fromally requesting that it be added.
Please advise when this might happen.
I reviewed your open issues 11091 and 11289 that contain list of core components and i did not see one for search bar
The solution
Add the AI slug componenet into search bar as a component so we do not have to code a customized search bar.
Application/website
ibm.com/docs/en
Business priority
High Priority = pressing release
What time frame would this ideally be needed by (if applicable)
By mid-March to meet our deadline for release on IBM Docs test
Examples
see screenshot above
Code of Conduct

[X] I agree to follow this project's Code of Conduct
[X] I checked the current issues for duplicate issues

@kcbuchanan The slug should appear only where AI generates or recommends the content. The user inserts the text in the search prompt; therefore, the slug should not be shown in the search field. Instead, the Slug would appear on any AI-suggested type-ahead prompts or alongside the search results in themselves.

@dallashudgens I recommend you bring your design work to a Carbon Office Hours for review.  Thx

@dallashudgens @kcbuchanan
If you wanted to inform the user of the existence of AI in the process, I would recommend doing in either or both the following ways:

Change the search trigger to AI generate button using the new "ai-launch" icon.
In the search results loading, you can add a slug (inline) there because the AI is doing the processing/searching in that instance.

@aagonzales Thanks for the feedback! I’ve been trying to keep up with the guidance and clearly misunderstood the use of the slug.
Is there a way for us to indicate there is an AI-launch but also the regular search is enabled? We can always do some testing and change, just wondering if there’s a hybrid approach defined?
I do plan to go through reviews with the design for AI team and y’all, just been pressed for time on another project. Will circle back with you soon.


User Name coming empty in activity.From.Name

I am initializing my chat bot . I am sending username as 'Agent Bot'👍
var user = {
id: 'userid1',
name: 'AgentBot '
};
        var bot = {
            id: params['botid'] || 'botid',
            name: params["botname"] || 'botname'
        };

        window['botchatDebug'] = params['debug'] && params['debug'] === "true";

        var botConnection = new BotChat.DirectLine({
            secret: params['s'],
            token: params['t'],
            domain: params['domain'],
            webSocket: params['webSocket'] && params['webSocket'] === "true" // defaults to true
        });

        BotChat.App({
            botConnection: botConnection,
            user: user,
            bot: bot
        }, document.getElementById("BotChatGoesHere"));

Now I need to get the username information in my bot code to send a welcome message to user with username. I am trying to fetch username from message.From.Name . But this is giving me empty value. Please guide me how to get the username in Bot code.
private async Task HandleSystemMessage(Activity message)
{
if (message.Type == ActivityTypes.DeleteUserData)
{
// Implement user deletion here
// If we handle user deletion, return a real message
}
else if (message.Type == ActivityTypes.ConversationUpdate)
{
//await CallDirectLine();
IConversationUpdateActivity iConversationUpdated = message as IConversationUpdateActivity;
if (iConversationUpdated != null)
{
ConnectorClient connector = new ConnectorClient(new System.Uri(message.ServiceUrl));

See https://github.com/Microsoft/BotFramework-WebChat/issues/536 for a discussion and workaround. Closing as duplicate.
@dandriscoll here is your weekly notification that this is our #1 issue report.
@danmarshall we should probably document this workaround in the README, maybe in an "Identity" section that talks about the DL identity system or lack of same.

@rachita0311 see this C# sample fro getting the members of a conversation

@danmarshall the problem is that no messages have been sent, so the bot has no user ID to access.

@billba OIC. Purely speculating, could this be solved if the WebChat sent a backchannel message upon startup?

That is the workaround linked to above, but it still requires custom code on the bot. The correct solution is to pass the user identity when connecting to the conversation. But that is a protocol level change.
If you're suggesting building the workaround into WebChat, I'm disinclined to institutionalize a hack.


Update storage-network-security.md

@mohsin-mehmood : Thanks for your contribution! The author(s) have been notified to review your proposed change. @santoshc

@mohsin-mehmood : Thanks for your contribution! The author(s) have been notified to review your proposed change. @santoshc

@mohsin-mehmood : Thanks for your contribution! The author(s) have been notified to review your proposed change. @santoshc

@mohsin-mehmood : Thanks for your contribution! The author(s) have been notified to review your proposed change. @santoshc

Looks good; thanks for the typo fix @mohsin-mehmood.

Looks good; thanks for the typo fix @mohsin-mehmood.


[WIP] Rearrangement Task

Motivation and Context
This PR will add the following for the rearrangement task:

Dataset Spec & first version of the episodes.
New Sensors
New Measurements
Grab/Release action using the magic pointer abstraction.

Creating this PR to keep track of changes and incorporate early feedback.
How Has This Been Tested
Types of changes

New Feature (non-breaking change which adds functionality)

Checklist

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have completed my CLA (see CONTRIBUTING)
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

Merge from master to fix the tests failing.


Message format

Is it possible to format xmpp notifications like smtp notifications (wiki format etc) ?

@tdx idea itself looks nice, but it seems nobody, who can add such functionality is either not interested, or have no amount time, needed for that.
Anyway, Pull Requests are welcome any time.
P.S. Maybe, someday I made it myself, but I'm in a deadline time with few current projects, so, I'd not counting on that.


[libjpeg-turbo] Update to 3.0.2

Release notes are here: https://github.com/libjpeg-turbo/libjpeg-turbo/releases/tag/3.0.2

[x] Changes comply with the maintainer guide.
[x] SHA512s are updated for each updated download.
The "supports" clause reflects platforms that may be fixed by this new version.
Any fixed CI baseline entries are removed from that file.
[x] Any patches that are no longer applied are deleted from the port's directory.
[x] The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
[x] Only one version is added to each modified port's versions file.

All features are tested successfully in the following triplet:
x86-windows
x64-windows
x64-windows-static


i18n: namespace the i18n keys for all languages

The goal is to prevent collisions.

Thanks for your contribution!


Grid unit calculation

Using this link  as an example,
despite the fact that the row height is set at 100, I inspect element the grid item and saw that its height is 210 instead.
Should't the height be 200? how is it being calculated??

i just set margin to be [0,0] and it work
  static defaultProps = {
    // items: 5,
    // charts:2,
    margin:[0,0],
    className:"layout",
    cols: { lg: 1, md: 10, sm: 0, xs: 0, xxs: 0 },
    rowHeight: 50
  };

This is the link to the calculation


Banner like SA?

@owikle @evanwill is there a reason we make the banner so small and unattractive? Looking at the docs, it would be simpler for all our banners to look/act the same.

historically different because -GH is set up without the org logo and link concept. The other banners require a org logo and link to fill that extra space-- in the -GH context assuming everyone has an org and logo doesn't really make sense.
I actually sort of prefer the simpler GH one though!
But ultimately, we should just make one version that has a fall back if there is no org logo and link, and have the same thing in all versions. Could use a bit of a design freshen-up, maybe navbar better color scheme or something?

single banner was ported to all templates


Fine tuning using colbert-ir/colbertv2.0 using training script now gives error

Failure at:
ColBERT/colbert/modeling/colbert.py", line 173, in colbert_score
assert Q.size(0) in [1, D_padded.size(0)]
I see that colbert_config.nway = 64
Q.size(0) = batch_sizecolbert_config.nway =  3264
D_padded.size(0) = 64 = bsize in indexer.py
Am I setting up something incorrectly?

@DeepaliP98
My environment: sagemaker jupyter notebook
sagemaker jupyter notebook (amazon machine learning environment)
GPU: Tesla T4
Cuda: 11.8
I also encountered the same error. Restarting the runtime kernel solved the problem. I don't understand why, but I assume that the ColBERTConfig settings need to be initialized.
I am not sure, but I suspect that Q.size(0) represents the number of tokens in the Query and D_padded.size(0) represents the number of tokens in the document

Ahh this is probably related to a recent improvement by @bclavie but it ends up loading a lot more config than he intended, since config is currently all or none

The temporary fix for @DeepaliP98 and @1mono2 is to manually set nway to 2 in your script (in the config)

Oh yes this is definitely what’s going on…
What do you think should be the best behaviour here @okhat ? Breaking compatibility like this is a very unpleasant side effect of loading the full config… Maybe we should load it then reset the breaking arguments (just nway?) to default values?

@okhat  what do you thing?  a fallback default values should be fine, with a warning log or something?

@DeepaliP98 can i get your email to contact? I have some problems in finetuning colbert and i think i need your help!


Fix actions auth errors

What needs to happen?
With recent changes to linking github accounts for the institute, a bunch of actions are failing with: "Resource protected by organization SAML enforcement. You must grant your Personal Access token access to this organization." I'm not sure if this needs to be done on a per account basis, if that's the case we need instructions for everyone on how to do this.
Why should we do this?
We need our actions to work.
When does this need to get done?
Early July 2023

I believe this is something that a simple configuration change to our github enterprise settings will fix (based on reading this). However, I do not have an admin account so I can't do this independently. I'll go to Software Engineering Office Hours on Wednesday and try to get this sorted

Tracked in ServiceNow ticket: INC0011051

Alright everything is all good! The last step was updating the relevant personal access tokens associated with secrets referenced in the actions to have SSO properly configured. I just generated a new personal access token and updated the simularium secret, and now that seems to be all good! If there are any other actions that are failing that use a different secret, all one has to do is make sure the token that is affiliated with it has single sign on authorized for the relevant project.


Fix possible header / URI corruption when discardReadBytes() is calle…

…d in HTTPDecoder
Motivation:
When discardReadBytes() was called and we still did not pass the Head to the user it was quite possible that the headers / URI could be corrupted as the stored readerIndex did not matchup anymore.
Modifications:

Override most of the functionality of ByteToMessageDecoder in HTTPDecoder to better work with the provided state machine of http_parser
Remove allocations by removing the pendingInOut Array as its not needed anymore.
Add guards against re-entrance calls
Add unit test that shows that everything works as expected now.

Result:
Fixed bug and reduced allocations (8% - 10% perf win).

@weissi @Lukasa PTAL again

@weissi @Lukasa PTAL again

Ok, this looks good to me.


Add handlebars support on cli

Hello, I'm sorry for the delay.  I've had no time to review changes or to fix the issue with the CI tools. Please be patient.


Fix the type of RenderTable.get rowDecorations.

This changes the return type from List<Decoration> to List<Decoration?>, matching the corresponding setter.
As such it is a breaking change.
I believe the current type is a bug, and this is the correct fix.
The underlying value has a nullable element type, and the setter accepts a list which can contain null, but the getter tries to create a list with non-nullable elements from the stored value.
Calling this getter while the list contains null will throw.
(If this fix is too simplistic, I'll file a bug for the issue instead.)

(Feel free to land, I don't have commit autority.)

OK, this needs a secondary LGTM then.


custom domain for gh page

I have seen you have set up a GitHub Page. If you are interested in the custom domain dragula.js.org for free you should have a look at JS.ORG. I would appreciate your request.

No thanks


add CDNJS version badge in README.md

This badge will show the version on CDNJS!

Coverage remained the same at 100.0% when pulling 405f21532a48166f449acad52f86c7743665e0b6 on pvnr0082t:add-badge into 90d82f88428f057c4b7a1d46aa38fc7c44d2d869 on blakeembrey:master.

Thanks. Would you mind following the existing README pattern and add the badge URLs to the bottom?

Coverage remained the same at 100.0% when pulling 2ca86d79e9ba1858fb517becc005fdb33a546697 on pvnr0082t:add-badge into 90d82f88428f057c4b7a1d46aa38fc7c44d2d869 on blakeembrey:master.

Coverage remained the same at 100.0% when pulling 2ca86d79e9ba1858fb517becc005fdb33a546697 on pvnr0082t:add-badge into 90d82f88428f057c4b7a1d46aa38fc7c44d2d869 on blakeembrey:master.

Coverage remained the same at 100.0% when pulling 2ca86d79e9ba1858fb517becc005fdb33a546697 on pvnr0082t:add-badge into 90d82f88428f057c4b7a1d46aa38fc7c44d2d869 on blakeembrey:master.

Coverage remained the same at 100.0% when pulling 2ca86d79e9ba1858fb517becc005fdb33a546697 on pvnr0082t:add-badge into 90d82f88428f057c4b7a1d46aa38fc7c44d2d869 on blakeembrey:master.

@blakeembrey done! :tada:

Awesome, cheers! 😄


VS Browser shows blank page after the vscode new update

After VSCode 1.86 I got this problem, every site can't be visited and it always shows white page.

Im getting the same issue

Sorry for the long response @Stefan2142 @samislam
Can you help me confirm is the extension still working or not?
I have tried it with google and it still work
Thank you!

After turning on proxy mode, tho it displays google search page in Arabic, it can't do anything.

@Heather77malinmama
It's the limit of the current proxy mode
I'm working on local proxy that let you do those things but because I have zero experience in Nodejs proxy server so it may take time for a completely working proxy
Thank you for using my extension!


Add more window API functions

Hey how to open file in vscode,
vscode.env.open_external(link)

using this or any other way

Hey how to open file in vscode,
vscode.env.open_external(link)

using this or any other way

You'll need to use vscode.window.show_text_document which has been newly added to v1.5.3. This function takes in 2 parameters, the uri of the file and TextDocumentShowOptions


store translations for unavailable locales if enforce_available_locales is false

Fixes issue described in #404 where the enforce_available_locales setting is not respected by the optimization added in #391.
Adds I18n.enforce_available_locales && to the early-exit conditional in #store_translations, so that translations for locales not in the available_locales array will not be stored only if enforce_available_locales is set to true.
Updated tests to reflect changed behavior.

I've investigated #404 and can confirm that there's still an issue in 0.9.4. Your wonderful steps to reproduce worked a treat. I checked out to this branch locally and it does indeed fix the issue. The code + tests are great too.
Just re-running build 529.10. It failed for what appeared to be a glitch-y reason. Once that passes, I'm happy to merge this and to release 0.9.5 with this fix.
Thanks for your work @wjordan! :heart:

Is it possible to release this fix in a 0.9.6 version ?
Rails (in the last version 5.1.5) require ~> 0.7 so it is not possible to have this fix in a Rails project.
I think it would make sense to have a 0.9.6 versions.

@btrd I am not sure what you mean. The merge commit for this PR shows that the commit is in the v0.9.5 and the v1.0.0 branch.
I just installed a new Rails 5.1.5 app locally and it is using i18n v0.9.5 which contains this fix. Why would I need to do a v0.9.6 release, if v0.9.5 already includes this fix and is used by default in new Rails applications?


Add consistency check of backward propagation between 2D and ND pooling functions

Fix #2109.
This PR adds a test to check consistency of backward methods of 2D and ND pooling layers:

max pooling layer
average pooling layer

Pooling
CPU/cuDNN/CuPy
forward/backward
Status

Max pooling
CPU
forward
Doing

Max pooling
CPU
backward
Doing

Max pooling
cuDNN
forward
Doing

Max pooling
cuDNN
backward
Doing

Max pooling
CuPy
forward
Doing

Max pooling
CuPy
backward
Doing

Average pooling
CPU
forward
Doing

Average pooling
CPU
backward
Doing

Average pooling
cuDNN
forward
Doing

Average pooling
cuDNN
backward
Doing

Average pooling
CuPy
forward
Doing

Average pooling
CuPy
backward
Doing

I have finished to implement the test for consistency check between 2D and ND pooling layers. This PR eventually covers the tests for the following conditions extending the original issue #2109:

Max pooling layer / Average pooling layer
CPU / cuDNN / CuPy implementations
forward / backward computation

LGTM, I am running Jenkins to see if all GPU will pass successfully.

LGTM


[Event Request] Codeunit 80 "Sales-Post" - procedure FindNotShippedLines - OnBeforeFindNotShippedLines

Please add an Event OnBeforeFindNotShippedLines in procedure FindNotShippedLines in Codeunit 80 "Sales-Post"
local procedure FindNotShippedLines(SalesHeader: Record "Sales Header"; var TempSalesLine: Record "Sales Line" temporary)
var
        IsHandled: Boolean; <-- NEW VAR
    begin
        IsHandled := false;
        OnBeforeFindNotShippedLines(SalesHeader, TempSalesLine, IsHandled); <-- NEW EVENT
        If IsHandled then
            exit;

        with TempSalesLine do begin
            ResetTempLines(TempSalesLine);
            SetFilter(Quantity, '<>0');
            if SalesHeader."Document Type" = SalesHeader."Document Type"::Order then
                SetFilter("Qty. to Ship", '<>0');
            SetRange("Shipment No.", '');
        end;
    end;

    [IntegrationEvent(false, false)]
    local procedure OnBeforeFindNotShippedLines(SalesHeader: Record "Sales Header"; var TempSalesLine: Record "Sales Line" temporary; var IsHandled: Boolean)
    begin
    end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 44246.


Grackle: port stdlib

The current executor supports around 66 stdlib calls. Currently, only startSketchAt, extrude, close and lineTo have been ported to Grackle. Port the rest.

[x] abs (@lf94 https://github.com/KittyCAD/modeling-api/pull/222)
[x] acos (@lf94 https://github.com/KittyCAD/modeling-api/pull/222)
[ ] angleToMatchLengthX
[ ] angleToMatchLengthY
[ ] angledLine (@lf94 https://github.com/KittyCAD/modeling-app/pull/1787)
[ ] angledLineOfXLength (@lf94 https://github.com/KittyCAD/modeling-app/pull/1787)
[ ] angledLineOfYLength (@lf94 https://github.com/KittyCAD/modeling-app/pull/1787)
[ ] angledLineThatIntersects
[ ] angledLineToX (@lf94 https://github.com/KittyCAD/modeling-app/pull/1787)
[ ] angledLineToY (@lf94 https://github.com/KittyCAD/modeling-app/pull/1787)
[ ] angledLineToX (original) -> angledLineX (@lf94 https://github.com/KittyCAD/modeling-app/pull/1787)
[ ] angledLineToY (original) -> angledLineY (@lf94 https://github.com/KittyCAD/modeling-app/pull/1787)
[ ] arc (@lf94)
[x] asin (@lf94 https://github.com/KittyCAD/modeling-api/pull/222)
[x] atan (@lf94 https://github.com/KittyCAD/modeling-api/pull/222)
[ ] bezierCurve
[x] ceil (@lf94 https://github.com/KittyCAD/modeling-api/pull/222)
[ ] circle (@lf94)
[x] close
[x] cos (@lf94 https://github.com/KittyCAD/modeling-api/pull/222)
[x] e (@lf94 https://github.com/KittyCAD/modeling-api/pull/231)
[x] extrude
[ ] fillet
[x] floor (@lf94 https://github.com/KittyCAD/modeling-api/pull/222)
[ ] getExtrudeWallTransform
[ ] getNextAdjacentEdge
[ ] getOppositeEdge
[ ] getPreviousAdjacentEdge
[ ] hole
[x] import (@lf94, https://github.com/KittyCAD/modeling-api/pull/184, https://github.com/KittyCAD/modeling-app/pull/1643)
[ ] lastSegX
[ ] lastSegY
[ ] legAngX (@lf94 https://github.com/KittyCAD/modeling-app/pull/1787)
[ ] legAngY (@lf94 https://github.com/KittyCAD/modeling-app/pull/1787)
[ ] legLen (@lf94 https://github.com/KittyCAD/modeling-app/pull/1787)
[x] line (@lf94 https://github.com/KittyCAD/modeling-app/pull/1754)
[x] lineTo
[x] ln (@lf94 https://github.com/KittyCAD/modeling-api/pull/222)
[x] log (@lf94 https://github.com/KittyCAD/modeling-api/pull/223)
[x] log10 (@lf94 https://github.com/KittyCAD/modeling-api/pull/222)
[x] log2 (@lf94 https://github.com/KittyCAD/modeling-api/pull/222)
[x] max (@lf94 https://github.com/KittyCAD/modeling-api/pull/223)
[x] min (@lf94 https://github.com/KittyCAD/modeling-api/pull/223)
[ ] patternCircular2d
[ ] patternCircular3d
[ ] patternLinear2d
[ ] patternLinear3d
[x] pi (@lf94 https://github.com/KittyCAD/modeling-api/pull/231)
[x] pow
[ ] segAng
[ ] segEndX
[ ] segEndY
[ ] segLen
[x] sin (@lf94 https://github.com/KittyCAD/modeling-api/pull/222)
[x] sqrt (@lf94 https://github.com/KittyCAD/modeling-api/pull/222)
[ ] startProfileAt
[x] startSketchAt
[ ] startSketchOn
[x] tan (@lf94 https://github.com/KittyCAD/modeling-api/pull/222)
[ ] tangentialArc
[x] tangentialArcTo (@iterion, https://github.com/KittyCAD/modeling-app/pull/1731)
[ ] tau (@lf94 https://github.com/KittyCAD/modeling-app/pull/1787)
[x] toDegrees (@lf94 https://github.com/KittyCAD/modeling-api/pull/222)
[x] toRadians (@lf94 https://github.com/KittyCAD/modeling-api/pull/222)
[x] xLine  (@lf94 https://github.com/KittyCAD/modeling-app/pull/1754)
[x] xLineTo  (@lf94 https://github.com/KittyCAD/modeling-app/pull/1754)
[x] yLine  (@lf94 https://github.com/KittyCAD/modeling-app/pull/1754)
[x] yLineTo  (@lf94 https://github.com/KittyCAD/modeling-app/pull/1754)

Note to self:

[ ] expose unary functions in KCL
[ ] expose remaining binary functions in KCL

NOTE: I must call toRadians on the Grackle backend for all trig functions...

The reason why I have those functions as radians is I could not find a popular programming language where they were not radians, meaning any ai model and human is going to assume they are radians, if we are the outlier its unintuitive

Oh so we want cos and sin to remain radians? Because that's 100% what I want lol, but I know we have the whole "default to degrees" thing.

These functions are the exception since it’s unintuitive

Make them work like the current stdlib which is radians

atan2 is important too.

We are only porting the current stdlib adding new functions can be outside this


train problem

why the training process is freezing

Hey, xinyuxiao. May I inquire about the computing resources you are utilizing for running the tasks?


Import from node_modules with bare module specifiers

We currently support npm: protocol imports for importing directly from npm (via the jsDelivr CDN). But we could also support importing from your local node_modules with bare module specifiers, using rollup to build an ES module as needed.

I've started to experiment with this — sharing in #1101 (current status: "it works for 'earcut'").

Hello! I'm new to Framework, so perhaps I'm missing a nuance of importing modules. Was there a design decision to specifically not use package.json as a way to specify dependencies? I've also seen #1009 that seems like might also have an industry-solved solution via usage of (both yarn & npm) package-lock files.
Lock files also have the added benefit of being crawled by Dependabot for security patches.

@danmarshall Framework supports “implicit imports” for convenience, so you can e.g. start using d3 and it “just works” without you having to remember to npm install d3 ahead of time. By the same extension, we’ve made import * from "npm:whatever" “just work” for any library you want to use without needing to run npm install first.
Our intent is to support both implicit imports and explicit imports using a package manager (such as npm); that’s what this issue is about. So if you would rather manage your dependencies and versions explicitly using npm and package.json, you will be able to do that. But it won’t be a requirement — we’ll offer implicit imports in addition.

Adding node_modules support would also make versioning of specific packages more transparent, as well as allow better typescript support if we can have it as a devDependency.


Create: Add helper text for Project details

What does this PR do and why?
Provide a description of what this PR does. Link to any relevant GitHub issues, Notion tasks or Discord discussions.
Screenshots or screen recordings
If applicable, provide screenshots or screen recordings to demonstrate the changes.
Acceptance checklist

[ ] I have evaluated the Approval Guidelines for this PR.
[ ] I have tested this PR in all supported browsers.
[ ] I have tested this PR in dark mode and light mode (if applicable).

Current dependencies on/for this PR:

main

PR #2510   👈

This comment was auto-generated by Graphite.

Graphite Merge Job
Current status: 🔄 Waiting for checks to pass
This pull request is currently waiting for CI and mergeability checks to pass before being merged.
This comment was auto-generated by Graphite.

Job Reference: XJjT605R1Sdi2CUgZUbX


Flexbox Table

Create a flexbox table which is responsive for mobile devices.

Ref

Features from antd
https://css-tricks.com/accessible-simple-responsive-tables/
codepen example
codepen react example


Bring back A9 and Criteo tags

Due to problems with their implementation in Tealium (they introduced dependency on DFP; not added to Tealium yet).

👍


Update in 5.10 swift-certificates to 1.x, swift-crypto to 3.x

========================================
Failures:
  FAIL: MovieSwift, 5.0, 237010, MovieSwift, generic/platform=iOS
========================================

@justice-adams-apple is this known issue with release/5.10?

@shahmishal yes, this is a known issue, this PR should be good to go

We no longer need this as we moved to update-checkout for source compat


Provide ability to add ssh public key to instance user data

When launching unencrypted guests on ESX, currently there are no
means to pass the SSH public key to the instance. As a result, if
a (dev) user tries to SSH to the metavisor, it would fail.
This change allows creating a user-data blob with the ssh public
key to be used by the metavisor instance. The user-data is then
passed to the instance at launch time which allows it to download
the public key and allow anyone having the associated private key
to be able to SSH in to the metavisor.
The option is kept hidden since the primary audience for the use is
Bracket (internal) engineering who would want access to the Metavisor.
A debug Metavisor version would still be required for the SSH to work.

LGTM


Use boolean json representation for obscureText

Corrects type from string introduced in
21712a49a76af0fab63246a9acbe61f3e1928070.

LGTM.
Is this a breaking change? (i.e. is this a "public" API that people might be working against?)
Does this involve a corresponding change to some engine or plugin code?

Is this a breaking change? (i.e. is this a "public" API that people might be working against?)

In theory someone could hook into it, but I wouldn't expect that to happen at this stage.  (This code was also just added yesterday or the day before).

Entirely possible, though as Adam says, unlikely in the 15h or so it's been out. I can send a mail if we think it's worth it.


💡[FEATURE]: ASELSAN Stock Price Prediction

Is your feature request related to a problem? Please describe.
This project involves the analysis and prediction of ASELSAN stock prices using historical stock price data from 2017 to 2022. The aim is to create an accurate predictive model by exploring the dataset, visualizing different aspects of the stock prices, and implementing various machine learning algorithms.
Describe the solution you'd like
Implement a more robust model that includes external market indicators and news sentiment analysis to improve prediction accuracy.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

@Akshat111111  i am a gssoc 24 contributor, can i please work on this?


Add support for Windows

Does this program work in windows? I see there code in here referencing Sudo which is just for Linux so is that the only system that this program works for? I kept getting an error when trying to use it in windows

I'd like to take a stab at this if possible.

@fuzzmz Go ahead


iframe no longer supported in collection introductory text

In DSpace 5 and 6, iframes could be included in community and collection introductory text and would display (in this way videos or maps could be embedded, see https://demo.dspace.org/xmlui/handle/10673/101 for example). In DSpace 7 this is no longer the case.
Was this changed intentionally? If not, can it be added back? I don't see documentation or discussion of the change anywhere...
I don't see the list of allowed HTML tags defined in the code, maybe it is predefined by Angular? Is it the same as the list in the documentation at https://wiki.lyrasis.org/display/DSDOC7x/Simple+HTML+Fragment+Markup ?

See https://demo7.dspace.org/handle/10673/245528 for an example of an iframe failing to display in DSpace 7.

@dagrenzer : This appears to be managed by Angular itself.  In these Collection/Community fields we are using Angular's built in [innerHtml] property.  Angular itself "sanitizes" all HTML that flows through that property in order to avoid XSS vulnerabilities/attacks.  Here's an article that summarizes why Angular does this: https://angular.io/guide/security#preventing-cross-site-scripting-xss
It doesn't look like there's a definitive "reference" from Angular regarding which tags it allows.  But, I found these links to the source code from Angular, which shows what is allowed and not allowed:
Allowed HTML tags (elements) are here: https://github.com/angular/angular/blob/main/packages/core/src/sanitization/html_sanitizer.ts#L36-L64
Allowed HTML attributes (on those tags) are here: https://github.com/angular/angular/blob/main/packages/core/src/sanitization/html_sanitizer.ts#L69-L84
So, looking at that list, <iframe> is definitely not allowed.  It does appear you can use tags like <img> or <video> though, if you are just looking for a way to embed an image or video.
I don't think know that we'd want to bypass this sanitization in DSpace 7, as it's protecting us from potential security vulnerabilities.  (Arguably, we shouldn't have allowed this in DSpace 6 either).
I'll update the docs you linked to above with this information to ensure it is formally documented https://wiki.lyrasis.org/display/DSDOC7x/Simple+HTML+Fragment+Markup

Closing as "answered".  I've updated the docs at https://wiki.lyrasis.org/display/DSDOC7x/Simple+HTML+Fragment+Markup with more details.  It appears that there are corresponding HTML5 tags you can use instead of iframe (e.g. img, audio, video, map, etc)


Missing lodash dependency in build

lodash is not included in the build version and throws a error if i try to use SDL from /build/sdl
You can reproduce it with this example repository: https://github.com/zJuuu/akashjs-examples

Hey @zJuuu could you fix it please?


Redirect only via Javascript

Hi i like to implement a pluging to redirect only via javascript instead of headers, i was able to do it on 1.7.6 via changing functions.php yourls_redirect to this:
function yourls_redirect( $location, $code = 301 ) {
yourls_do_action( 'pre_redirect', $location, $code );
$location = yourls_apply_filter( 'redirect_location', $location, $code );
$code     = yourls_apply_filter( 'redirect_code', $code, $location );
// Redirect, either properly if possible, or via Javascript otherwise
yourls_redirect_javascript( $location );

die();

but now updagrade to 1.7.9 and funtion is diferents and anyhow i like not to mess with core files and implement this via pluging..
any way to make this work?

To redirect only with javascript, something like the following in a plugin:
yourls_add_action('pre_redirect', 'uniextra_redir');
function uniextra_redir($args) {
    $url = $args[0];
    yourls_redirect_javascript( $url );
    exit;
}

There are numerous plugin dealing with redirection that can serve as examples to build on


Repo Maintenance: November 2023

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (1ade5d1) 97.94% compared to head (1250d0f) 97.94%.

:exclamation: Current head 1250d0f differs from pull request most recent head 3e050ab. Consider uploading reports for the commit 3e050ab to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #298   +/-   ##
=======================================
  Coverage   97.94%   97.94%
=======================================
  Files         108      108
  Lines        1999     1999
=======================================
  Hits         1958     1958
  Misses         41       41

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🔗 Improve Navigation: Back Button Added to Policy, Terms, and Contact Us!

Related Issue:

Closes #151

Pull Request Title:
🔗 Improve Navigation : Add Back Button to Policy, Terms, and Contact Us Pages!
Pull Request Description:
Description:
This pull request adds a back button to the Policy, Terms, and Contact Us pages, enhancing user navigation by allowing users to easily return to the previous page they visited.
Changes Made:

Added a back button to the following pages:

Policy
Terms
Contact Us

Ensured the button is styled consistently with the overall design of the website.

Testing:

The back button has been tested on all three pages to ensure functionality, and it correctly navigates back to the previous page.
Verified that the button is visually aligned with the site’s design.

Screenshots :

Unfortunately, due to a wrong PR that got merged, the website's structure became disorganized. We had to revert to the old code. Kindly pull the latest changes and create a new PR for your issue, as your current PR shows conflicts. I apologize for the inconvenience and appreciate your understanding. Looking forward to your new PR soon. Thank you! 😊


Ego4D dataset

Hello, thank you for your outstanding work. I have a question about the Ego4D dataset. Since the full Ego4D dataset is too large(7.1TB),  I was wondering if you only use one part of the Ego4D dataset? If it is, could you share the command to download the
part of dataset that you use? Thanks!

is this solved? need two, thanks


[Installing TensorFlow offline] $ ./configure fails because no Internet connection is available for my server.

My environment without Internet
My server can't access the Internet because my company's firewall blocks any external network or the Internet. To install Tensorflow on this server, I have to install TensorFlow offline. In other words, I have to correct tens of errors by myself. Upon this error, I had to submit an issue.
I moved the template below because it's way too long. (I filled in some information.) I'd appreciate your feedback.
Questions
My question nails down to two core questions.
Q1. How can I manually fetch all the packages for tensorflow without using bazel command?
I took a closer look at the "configure" file and the following line causes the problem.
$bazel fetch //tensorflow/...
  This bazel command fetches all the packages in target "tensorflow".
   No Internet connection in my server, so this command fails!.
   I'll have to download all these packages in ANOTHER computer with Internet connection and
   move them to my server.

   In another computer with Internet connection, how can I download them without bazel command? Alternative commands can be wget, git, apt-get, pip and so on.

Q2. Where should I place the downloaded packages?
Say all the packages for target "tensorflow" are downloaded.
Where should I place them to run the next command successfully?
 $ bazel build -c opt -config=cuda //tensorflow/cc:tutorials_example_trainer

I'll have to move all the package to my server from another computer.

So I need some information about the directory that the above command refers to.
(This is all because of the security measure in my company. As a matter of fact, this process is more complex than using another computer, but this gives you an idea about my installation environment without the Internet)
NOTE: Only file GitHub issues for bugs and feature requests.  All other topics will be closed.
For general support from the community, see StackOverflow.
To make bugs and feature requests more easy to find and organize, we close issues that are deemed
out of scope for GitHub Issues and point people to StackOverflow.
For bugs or installation issues, please provide the following information.
The more information you provide, the more easily we will be able to offer
help and advice.
What related GitHub issues or StackOverflow threads have you found by searching the web for your problem?
"How to make the ./configure find package in local place #5428"
GaofengCheng opened this issue on 6 Nov and there're 13 comments, but no solution is presented.
Environment info

Operating System: Ubuntu Linux 14.04

NO INTERNET CONNECTION.
My company's firewall blocks my server from the Internet connection.  So no Internet connection is available. A comment in Issue #5029 says "Long story short, [...] a network access is required.", but a network access on this server is not an option. I'll have to download necessary packages from another computer with Internet connection and upload them to my server via sftp.

CUDA & cuDNN are installed in ~/local/ because of the system admin asked me to do so.
When I run " $ ./configure", CUDA & cuDNN installation was done manually.

Installed version of CUDA and cuDNN:
(please attach the output of ls -l /path/to/cuda/lib/libcud*):
~/local/cuda-8.0/lib64$ ls -l libcud*
-rw-r--r-- 1 root root   558720 Dec  9 01:00 libcudadevrt.a
lrwxrwxrwx 1 root root       16 Dec  9 01:00 libcudart.so -> libcudart.so.8.0
lrwxrwxrwx 1 root root       19 Dec  9 01:00 libcudart.so.8.0 -> libcudart.so.8.0.44
-rwxr-xr-x 1 root root   415432 Dec  9 01:00 libcudart.so.8.0.44
-rw-r--r-- 1 root root   775162 Dec  9 01:00 libcudart_static.a
lrwxrwxrwx 1 root root       13 Dec  9 01:05 libcudnn.so -> libcudnn.so.5
lrwxrwxrwx 1 root root       17 Dec  9 01:05 libcudnn.so.5 -> libcudnn.so.5.1.5
-rwxr-xr-x 1 root root 79337624 Dec  9 01:05 libcudnn.so.5.1.5
-rw-r--r-- 1 root root 69756172 Dec  9 01:05 libcudnn_static.a
If installed from source, provide

The commit hash (git rev-parse HEAD)
$ git rev-parse HEAD
fatal: Not a git repository (or any parent up to mount point /home)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).

The output of bazel version
$ bazel version
Build label: 0.4.0
Build target: bazel-out/local-fastbuild/bin/src/main/java/com/google/devtools/build/lib/bazel/BazelServer_deploy.jar
Build time: Wed Nov 2 17:54:14 2016<PHONE_NUMBER>)
Build timestamp:<PHONE_NUMBER>
Build timestamp as int:<PHONE_NUMBER>

If possible, provide a minimal reproducible example (We usually don't have time to read hundreds of lines of your code)
$ ./configure
[...]
ERROR: package contains errors: tensorflow/examples/android.
ERROR: error loading package 'tensorflow/examples/android': Encountered error while reading extension file 'protobuf.bzl': no such package '@protobuf//': Error downloading from http://github.com/google/protobuf/archive/008b5a228b37c054f46ba478ccafa5e855cb16db.tar.gz to /home/the.kim/.cache/bazel/_bazel_the.kim/e904ac0e4fbd2c03039cdbaeea674781/external/protobuf: Error downloading http://github.com/google/protobuf/archive/008b5a228b37c054f46ba478ccafa5e855cb16db.tar.gz to /home/the.kim/.cache/bazel/_bazel_the.kim/e904ac0e4fbd2c03039cdbaeea674781/external/protobuf/008b5a228b37c054f46ba478ccafa5e855cb16db.tar.gz: Timed out connecting to http://github.com/google/protobuf/archive/008b5a228b37c054f46ba478ccafa5e855cb16db.tar.gz : connect timed out.
(tensorflow) $
(The following line within configure causes my problem.
My server has no Internet connection, so download fails.)
$ bazel fetch //tensorflow/...
INFO: Downloading from http://github.com/google/protobuf/archive/008b5a228b37c054f46ba478ccafa5e85
5cb16db.tar.gz: 0B
Logs or other output that would be helpful
(If logs are large, please upload as attachment or provide link).
the.kim@clover3:~/tensorflow/downloads/tensorflow$ source ~/tensorflow/bin/activate
(tensorflow) the.kim@clover3:~/tensorflow/downloads/tensorflow$ ls
008b5a228b37c054f46ba478ccafa5e855cb16db.tar.gz  eigen.BUILD        LICENSE          tensorflow
ACKNOWLEDGMENTS                                  farmhash.BUILD     linenoise.BUILD  third_party
ADOPTERS.md                                      gif.BUILD          models.BUILD     tools
AUTHORS                                          gmock.BUILD        nanopb.BUILD     util
bower.BUILD                                      grpc.BUILD         png.BUILD        WORKSPACE
BUILD                                            ISSUE_TEMPLATE.md  README.md        zlib.BUILD
configure                                        jpeg.BUILD         RELEASE.md
CONTRIBUTING.md                                  jsoncpp.BUILD      six.BUILD
(tensorflow) the.kim@clover3:~/tensorflow/downloads/tensorflow$ ./configure
~/tensorflow/downloads/tensorflow ~/tensorflow/downloads/tensorflow
Please specify the location of python. [Default is /home/the.kim/tensorflow/bin/python]: /home/the.kim/tensorflow/bin/python3
Do you wish to build TensorFlow with Google Cloud Platform support? [y/N] n
No Google Cloud Platform support will be enabled for TensorFlow
Do you wish to build TensorFlow with Hadoop File System support? [y/N] n
No Hadoop File System support will be enabled for TensorFlow
Found possible Python library paths:
/home/the.kim/tensorflow/lib/python3.4/site-packages
Please input the desired Python library path to use.  Default is [/home/the.kim/tensorflow/lib/python3.4/site-packages]
Using python library path: /home/the.kim/tensorflow/lib/python3.4/site-packages
Do you wish to build TensorFlow with OpenCL support? [y/N] y
OpenCL support will be enabled for TensorFlow
Do you wish to build TensorFlow with CUDA support? [y/N] y
CUDA support will be enabled for TensorFlow
Please specify which gcc should be used by nvcc as the host compiler. [Default is /usr/bin/gcc]:
Please specify the CUDA SDK version you want to use, e.g. 7.0. [Leave empty to use system default]: 8.0
Please specify the location where CUDA 8.0 toolkit is installed. Refer to README.md for more details. [Default is /usr/local/cuda]: /home/the.kim/local/cuda-8.0
Please specify the Cudnn version you want to use. [Leave empty to use system default]:
Please specify the location where cuDNN  library is installed. Refer to README.md for more details. [Default is /home/the.kim/local/cuda-8.0]:
libcudnn.so resolves to libcudnn.5
Please specify a list of comma-separated Cuda compute capabilities you want to build with.
You can find the compute capability of your device at: https://developer.nvidia.com/cuda-gpus.
Please note that each additional compute capability significantly increases your build time and binary size.
[Default is: "3.5,5.2"]: 3.7
Please specify which C++ compiler should be used as the host C++ compiler. [Default is /usr/bin/g++]:
Please specify which C compiler should be used as the host C compiler. [Default is /usr/bin/gcc]:
Please specify the location where ComputeCpp 1.2 is installed. Refer to README.md for more details. [Default is /usr/local/computecpp]: /home/the.kim/local/ComputeCpp-CE-0.1.1-Linux
INFO: Starting clean (this may take a while). Consider using --expunge_async if the clean takes more than several minutes.
........
ERROR: package contains errors: tensorflow/examples/android.
ERROR: error loading package 'tensorflow/examples/android': Encountered error while reading extension file 'protobuf.bzl': no such package '@protobuf//': Error downloading from http://github.com/google/protobuf/archive/008b5a228b37c054f46ba478ccafa5e855cb16db.tar.gz to /home/the.kim/.cache/bazel/_bazel_the.kim/e904ac0e4fbd2c03039cdbaeea674781/external/protobuf: Error downloading http://github.com/google/protobuf/archive/008b5a228b37c054f46ba478ccafa5e855cb16db.tar.gz to /home/the.kim/.cache/bazel/_bazel_the.kim/e904ac0e4fbd2c03039cdbaeea674781/external/protobuf/008b5a228b37c054f46ba478ccafa5e855cb16db.tar.gz: Timed out connecting to http://github.com/google/protobuf/archive/008b5a228b37c054f46ba478ccafa5e855cb16db.tar.gz : connect timed out.
(tensorflow) the.kim@clover3:~/tensorflow/downloads/tensorflow$
(Before the error, $ ./configure attempts this.)
INFO: Downloading from http://github.com/google/protobuf/archive/008b5a228b37c054f46ba478ccafa5e85
5cb16db.tar.gz: 0B

@martinwicke can you see an easy way to automate the download of necessary packages before build?

I would use bazel fetch on another computer and copy the result.
The full paths of all of the packages are in the workspace.bzl file, so if you really want you can use wget and get them all. You can then change all the rules in the workspace file to be "local_repository" instead, and that will use the previously downloaded files from the paths you provide.

Dear @martinwicke,
Thanks for your feedback.

I would use bazel fetch on another computer and copy the result.
Yes, this is what I've been doing. The command "$bazel fetch //tensorflow/..." fetches the repository and the only way I can install the repo to my server (without Internet) is to copy the result. Anyways it's good to confirm to use another computer.

You can then change all the rules in the workspace file to be "local_repository" instead, and that > will use the previously downloaded files from the paths you provide.
Well, yes. That's exactly what I'm trying to do. The question is where is the "local_repository" located. If the local_repository can be any directory, how can I specify the directory when I build with bazel command?

I wasn't able to find about local_repository on Command-Line Reference.
@martinwicke, I'd appreciate if you can tell me a bit more in detail with concrete command. Thanks in advance!

It's not a command line option, you'll have to edit the workspace.bzl file to replace how bazel finds its dependencies from their current sources (often, http_archive) to local_repository.

@mrtonnet Did you solve your problem?  I'm having the same issue and was wondering if you could share your results.

bazel --output_user_root=/tmp/bazel fetch  //tensorflow/tools/pip_package:build_pip_package

downloads the packages required for the "bazel build ... //tensorflow/tools/pip_package:build_pip_package" stage and put the downloaded files in
 /tmp/bazel/<md5sum hash>/external/

Correct?
Now how I am supposed to convert the URL such as "http://bazel-mirror.storage.googleapis.com/ftp.exim.org/pub/pcre/pcre-8.39.tar.gz" from ./tensorflow/workspace.bzl into "file:///tmp/bazel/da36536f347c0e23d2402d33213b5c40/external/pcre/pcre-8.39.tar.gz" ?
or from the WORKSPACE file : "https://github.com/polymerelements/paper-slider/archive/v1.0.10.tar.gz" -> "/tmp/bazel/da36536f347c0e23d2402d33213b5c40/external/paper_slider/v1.0.10.tar.gz"

@mrtonnet @truatpasteurdotfr  Did you solve your problem? I'm having the same issue and was wondering if you could share your results.

not solved for me :( I ended up building a docker image and build inside.

see this：
https://github.com/amutu/tensorflow_offline

Hi @amutu
I have followed your amazing introduction of how to install offline tensorflow.
But now I have one more question...
When I try to view the data flow graph through tensorboard
It seems the browser(firefox) keeps trying to download something from website (google?)
And after waiting for a long time (~5mins), it still can't show anything from my browser.
I was wondering if there is anyway to run tensorboard with internet connection..
Thanks for your help in advance!

I think it needs some javascript libs to show the graph, these libs are only available on the public network and not included in the tensorflow pkg. I am sorry I can not help you because I am not a front end guy. You can open an issue to the tensorflow project to ask help.

Better yet, open an issue against tensorflow/tensorboard. You should be able to run this just fine without an internet connection.

@amutu Thank you for your contribution of tensorflow-offline. Everything seems to work for me when not using cuda, but when trying to follow your instructions with cuda I get the following error:
ERROR: error loading package 'tensorflow/tools/pip_package': Encountered error while reading extension file 'cuda/build_defs.bzl': no such package '@local_config_cuda//cuda': Traceback (most recent call last):
File "/home/ec2-user/tensorflow-1.2.1/third_party/gpus/cuda_configure.bzl", line 958
_create_cuda_repository(repository_ctx)
File "/home/ec2-user/tensorflow-1.2.1/third_party/gpus/cuda_configure.bzl", line 915, in _create_cuda_repository
_host_compiler_includes(repository_ctx, cc)
File "/home/ec2-user/tensorflow-1.2.1/third_party/gpus/cuda_configure.bzl", line 144, in _host_compiler_includes
get_cxx_inc_directories(repository_ctx, cc)
File "/home/ec2-user/tensorflow-1.2.1/third_party/gpus/cuda_configure.bzl", line 119, in get_cxx_inc_directories
set(includes_cpp)
depsets cannot contain mutable items.
Any idea what I can do?

CUDA is not supported for the offline build now.

Ended up creating a twin VM, build there then deploy the libs to the target server.


Catch exceptions for csv uploads in entire app

Now, whenever a user uploads a bad csv file (either malformed
or a binary file with csv extension) the problem will be caught
and gracefully handled by flashing an error. This error message
has been localized with Google Translate. Tests have been written
for all of the affected files. Fixes #2075.

Should a separate issue be opened to get proper localization?

@paymog Yay! Don't worry about localization right now.


test: use new runtime in status integration tests

Use hook decorator API in configure_builtin_status_hooks.
Configure hooks in run_workflow so they are ready to be used in tests.

:tada: This PR is included in version 3.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Open TSC Meeting, Thursday 27 August 2020

NOTE: This meeting is on Thursday at 9am - 10am PT - click for local time
Zoom Meeting link: https://zoom.us/j/975841675
In order to give some more visibility into the topics we cover in the TSC meetings here is the planned agenda for the next meeting.  Hopefully this will allow people to plan to attend meetings for topics that they have an interest in.  And for folks who cannot attend they can comment on this issue prior to the meeting.  Feel free to suggest other potential agenda topics.
Please submit comments below for topics or proposals that you wish to present in the TSC meeting

Topic
Owner
Decision/NextStep

Webhooks/callbacks/ReadOnly/WriteOnly
@webron
Clarify that JSON Schema annotations do not have explicit  semantics defined by OpenAPI.

Revisit #1809 server variable enum guidance
@webron
Ron will turn SHOULD into MUST

Agree location / wording of 1.2 EOL notice, close #2312
@OAI/tsc
Define process for making spec versions obsolete/deprecated.  Define what obsolete and deprecated means.  Update specs with status.  Add to development.md (Looking for volunteers to write something)

New issues / PRs labelled review
@OAI/triage

New issues without response yet
@OAI/triage

/cc @OAI/tsc Please suggest items for inclusion

We didn't have facilitators in the meeting today so we cut it short. Perhaps these agenda items could run into next week?

Topic: JSON Schema consuming tools / implementers forum.
A fair amount of work went into JSON Schema draft 2019-09 to enable the formal proposal for inclusion in OAS.
Now achived with 3.1, we (JSON Schema) need an approach to iliciting feedback on specific issues moving forward.
JSON Schema draft in progress (2020-something) includes numerous fixes and clarifications on the back of discussing with one or two implementers and consumers, but we want to make it possible for all those who have a stake in JSON Schema to be called to review and feedback on specific issues and pre releases.
Considering using github teams (which now includes discussions). Slack is emphermal.
Open to other suggestions.

Apologies @Relequestual I saw your comment but forgot to mention we had an additional agenda item. Can we discuss next week?

No problem. Yeah of course =]


Fix go lint in iscsi.go

Following file has a lint issue:
maya/cmd/maya-agent/app/command/iscsi.go
The lint  issue is :
comment on exported function NewCmdIscsi should be of the form "NewCmdIscsi ..."
Help Links :
Contributors guide

@sonasingh46 I would like to fix it.

@yo-ga
Sure!Go ahead.


Unable to open generated parquet files in python

I'm getting following error when opening in python3 with latest pyarrow, fastparquet:
pyarrow.lib.ArrowInvalid: Could not open Parquet input source '<Buffer>': Parquet magic bytes not found in footer. Either the file is corrupted or this is not a parquet file.

Apologies for a false alarm. It was a mistake on my end.


Compiled CSS oddities

See: https://github.com/jessepollak/card/blob/master/lib/css/card.css#L407
This line has one linear-gradient with a -webkit- prefix despite the rest not having the prefix.
Also I have no idea why the background-images are repeated twice each. The single difference is in the sheen on the top left. The top one has a degree of 245 and the other has -115, functionally identical in every way.
I'm not used to scss, so I couldn't find the issue at hand.

Thanks for all the feedback here.
I'm closing as this has been stale for a long time and we switched CSS compilers a while ago. Please reopen if it's still an issue for you!

Looks like you didn't have the energy!

:)

We have been noticing this issue as well. Seems as though bourbon currently doesn't have support for prefixing of any repeating gradient. Quite easy to add support to the newest bourbon version though.


Problems with Static Buildpack

Hi,
I created this little repo: https://github.com/philiplb/swagger-ui-on-flynn
It is using the static buildpack via a .buildpacks file: https://github.com/pearkes/heroku-buildpack-static
But on git push flynn master, I get this error?

Counting objects: 66, done.
Delta compression using up to 4 threads.
Compressing objects: 100% (65/65), done.
Writing objects: 100% (66/66), 1004.63 KiB | 0 bytes/s, done.
Total 66 (delta 4), reused 0 (delta 0)
-----> Building swaggerui...
-----> Multipack app detected
=====> Downloading Buildpack: https://github.com/pearkes/heroku-buildpack-static
=====> Detected Framework: Static
-----> Bundling Apache v2.2.19
remote:
remote: gzip: stdin: not in gzip format
remote: tar: Child returned status 1
remote: tar: Error is not recoverable: exiting now
remote: ERROR: Build failed: exec: job exited with status 2
To https://git.flynn.....com/swaggerui.git
! [remote rejected] master -> master (pre-receive hook declined)
error: failed to push some refs to 'https://git.flynn.....com/swaggerui.git'

Do you have any clue, what's wrong here?

I just used the PHP buildpack now by adding an composer.json containing "{}" and removing the .buildpacks. Feels like a bit of resource waste as the PHP interpreter gets installed and not used, but that doesn't matter much.

Try using the built-in Staticfile buildpack by creating an empty file in the root of the repo called Staticfile.


openstack-crowbar: enable cloud7 builds (SCRD-8855)

Update the openstack-crowbar core job and ansible scripts to
support deploying cloud 7 in the ECP.

Tested with: https://ci.suse.de/blue/organizations/jenkins/cloud-crowbar7-job-x86_64/detail/cloud-crowbar7-job-x86_64/10/pipeline

Seems that the backports repo is not available for soc7 sle12sp2: https://ci.suse.de/blue/organizations/jenkins/cloud-crowbar7-job-x86_64/detail/cloud-crowbar7-job-x86_64/10/pipeline/#step-135-log-21.
The only solution that I see left is to download a tar and install it that way.
The HA failure should not be happening, there's no set up of the python backports repo at that point. It seems that both were run on the same ci slot, cloud-ardana-ci-slot8.

Tested with:

2 nodes: https://ci.suse.de/blue/organizations/jenkins/cloud-crowbar7-job-x86_64/detail/cloud-crowbar7-job-x86_64/10/pipeline
4 nodes/HA and this crowbar-ha patch: https://ci.suse.de/blue/organizations/jenkins/cloud-crowbar7-job-ha-x86_64/detail/cloud-crowbar7-job-ha-x86_64/7/pipeline

@viccuad , those jobs both failed due to the missing python backports repository. I had to switch to using rpm packages for all our tempest JUnit dependencies, and resort to using the official Leap repositories, which are better aligned to the SLE ones.
New jobs to test this change:

2 nodes: https://ci.suse.de/blue/organizations/jenkins/cloud-crowbar7-job-x86_64/detail/cloud-crowbar7-job-x86_64/12/pipeline
4 nodes: https://ci.suse.de/blue/organizations/jenkins/cloud-crowbar7-job-ha-x86_64/detail/cloud-crowbar7-job-ha-x86_64/9/pipeline


Updated ticket support for /access and /stream endpoints (4-2-stable)

added #'s

hold on this, I need to change the spdlog cmake reference to the cmakelists file

if we ship this as is - we can ship against 4.2.9

then we can bump and ship against 4.2.11 with the CMAKE variable

confirmed - merging.


Updated documentation to add environment variables required to build NetCFD

In reference to #72

ok, was this while using ifort or gfortran? (was a comment about LIBRARY_PATH and ifort/icc)

gfortran


Create a search based document for CLIP

This document is generated using: https://github.com/james4ever0/prometheous
You can view the website at: https://james4ever0.github.io/CLIP/

Hi James, it's an interesting project but i'd like to keep this repo minimal. thanks for your interest!


Update values.yaml to include iptablesRandomFully

Please ensure your pull request adheres to the following guidelines:

[x] For first time contributors, read Submitting a pull request
[x] All code is covered by unit and/or runtime tests where feasible.
[x] All commits contain a well written commit description including a title,
description and a Fixes: #XXX line if the commit addresses a particular
GitHub issue.
[x] If your commit description contains a Fixes: <commit-id> tag, then
please add the commit author[s] as reviewer[s] to this issue.
[x] All commits are signed off. See the section Developer’s Certificate of Origin
[x] Provide a title or release-note blurb suitable for the release notes.
[x] Are you a user of Cilium? Please add yourself to the Users doc
[x] Thanks for contributing!

Update values file to include flag iptablesRandomFully.
Documentation for: cilium/cilium#13037
Update values file to include flag iptablesRandomFully

/test

Seems like CI is unhappy due to the docs not being regenerated. Please run make -C Documentation update-helm-values and squash the changes into the existing commit. Thanks!

@rbankston When you get a chance, could you update the docs as per @gandro suggestion? Thank you!

The commit message has a double sign-off, which is why the Check Patch workflow is failing. Use git commit --amend to fix

Thank you.

/test

/test


Update for getDerivedStateFromProps

Trying to fix issue https://github.com/beefe/react-native-actionsheet/issues/84
Changed

_calculateHeight() &&  get styles() out of class
Use getDerivedStateFromProps instead of componentWillReceiveProps

for me seems to work

Could it be mergeable?

will this be merged?

Any updates for merge?

Thanks for the PR. Maybe @xiaoyann could merge?

@walaman Is it possible to merge ? It would be great for all of us. Thanks in advance.

Maybe @xwenliang @skyRen @xiaoyann @chunyanzhu @penghongsun or @skinTest can merge? Thanks in advance guys, it would be great for all of us. And Thanks @walaman for his work.

@walaman Is it possible to merge ? It would be great for all of us. Thanks in advance.

Sorry Im not the owner, and I don't have the permission to merge it.
Seems this project have been abandoned and outdate, it would be better to rewrite using react hook

I released the fix to npm, read #131


Potentially breaking changes on NS QA??

@sbsmith86 and I have tried logging into gladiator (locally and on staging)
and each time we get a "whoops northstar returned an error for that request"
It seems like prod is on an older version than qa/thor has something changed? NS is returning a 403 for all login attempts there

It'd be helpful to see the actual error response. If you're sending an Accepts: application/json header with your API requests, it should return a more helpful message (it'd make sense in the future to perhaps differentiate response by route, rather than by headers, so this doesn't happen).
My guess is that those servers were using the old abc4324 seeded API keys, which I had removed from Northstar QA a few weeks ago since that'd allow anyone that looked at our old seed data to access/modify QA account details.

@DFurnes AHHA. you would be correct, using old keys. Alright so we need to set up new keys for this app on aurora QA?

@angaither @sbsmith86 Yep! You can check out existing clients on Aurora QA, and create a new one with the "New Client" button there! To work with Gladiator, I'm pretty sure it should have the admin and user scopes.

@DFurnes rare footage ron swanson filling out this form.

Also I'm very dense and don't know what to update the .env with?
Do we also need to update calls from gladiator?
Am I looking in the wrong place?

Also I'm very dense and don't know what to update the .env with?
Do we also need to update calls from gladiator?

Yeah, it's not really documented. Since Gladiator doesn't use OAuth, you can just place the client secret into the NORTHSTAR_API_KEY environment variable.

Am I looking in the wrong place?

There's a little documentation on the legacy auth mechanisms here, but definitely let me know if I can help out. Ideally we don't use it for new builds, so I haven't focused much on making sure that documentation is all that great.

@DFurnes no worries, that makes sense. THANK YOUUUUU for halping. it is back to working meow! 🙇 🙇 🙇


Can't import streamlit after !pip install -qU unpackai[deploy].

Can't import streamlit after !pip install -qU unpackai[deploy].
After import streamlit as st, it throws an error: ContextualVersionConflict: (ipykernel 4.10.1 (/usr/local/lib/python3.7/dist-packages), Requirement.parse('ipykernel>=5.1.2; python_version >= "3.4"'), {'pydeck'})

colab notebook

Installation is indeed via !pip install unpackai[deploy] that installs the extra dependencies for deployment (streamlit in particular)
Streamlit shall not be used directly in jupyter but rather in the code of the app so don't do import streamlit as st in a cell (unless you have the magics %%writefile app.py at the top to write in a file)
Write the code of the app either via %%writefile app.py or StreamlitApp("CV").render_fastai(......).save()

Then it will work.
Note: for deployment, it's better to export the model rather than save learn.export("model.pkl") because then you can just reload it in your app without having to create a new learning and add the learned weights.

And after that, you can just run in a new cell:
deploy_app()

or deploy_app("app.py") (or whatever you named your app) to run it.

https://colab.research.google.com/gist/jfthuong/e926c35ba6cefd2de471814581dcc0c3/01_cv_coursebook.ipynb#scrollTo=6atd2mkw6fw9
See here for reference


Fix comment line's end to be on same line

The comment text and span should not include the newline.
Previously on windows it would actually only include half of a \r\n and only include the \r.
This change also seems to improve the compiled JS indentation.

I might have missed updating some tests because when I run the test command it outputs the following:
thread 'test262::golden::6b5e7e125097d439.js' has overflowed its stack
test test262::golden::6b63d36394b0ffb3.js ... error: test failed, to rerun pass '--test test262'

I was able to get past this by skipping the following tests:
if file_name.contains("6b5e7e125097d439.js")
    || file_name.contains("714be6d28082eaa7.js")
    || file_name.contains("882910de7dd1aef9.js")
    || file_name.contains("dd3c63403db5c06e.js")
{
    continue;
}

Thank you for the pr!!


[wip] Implement Fractional Voting - roll our own uint85s, truncate votes by 3 decimals

Compare with #3 and #4
This is the most sophisticated approach to vote storage that we've considered. We store the different vote types (for, against, abstain) as three de-facto uint85s packed into 1 slot to save gas. Solidity does not have a uint85 type, so we are manually bitshifting before we write and after we read the values from the slot to accomplish this. The max number that can fit in a uint85 is ~3.9e25, and unfortunately that's not big enough to fit the votes from past proposals when you take into account governance token decimals -- e.g. with 100 mil votes cast and 18 decimals on the token, this proposal would have required putting ~1e26 in storage. To remedy this, we strip 3 digits of precision from the votes before storing them, giving us a max number of 3.9e28 votes per type.
From a high level, here are some stats on the approach:

castVoteWithReasonAndParams costs 75115 gas on average
max vote count per type is ~3.9e28
we lose 3 decimals of precision on votes

Here's the full gas estimation report of the latest test run from hardhat:
·----------------------------------------------------------|---------------------------|-------------|-----------------------------·
|                   Solc version: 0.8.9                    ·  Optimizer enabled: true  ·  Runs: 200  ·  Block limit: 10000000 gas  │
···························································|···························|·············|······························
|  Methods                                                                                │
···························|·······························|·············|·············|·············|···············|··············
|  Contract                ·  Method                       ·  Min        ·  Max        ·  Avg        ·  # calls      ·  usd (avg)  │
···························|·······························|·············|·············|·············|···············|··············
|  ERC20VotesMock          ·  delegate                     ·          -  ·          -  ·      48386  ·           80  ·          -  │
···························|·······························|·············|·············|·············|···············|··············
|  ERC20VotesMock          ·  mint                         ·          -  ·          -  ·     118134  ·           20  ·          -  │
···························|·······························|·············|·············|·············|···············|··············
|  ERC20VotesMock          ·  transfer                     ·     102971  ·     103067  ·     103019  ·           37  ·          -  │
···························|·······························|·············|·············|·············|···············|··············
|  GovernorFractionalMock  ·  castVote                     ·      71056  ·      88211  ·      84587  ·           19  ·          -  │
···························|·······························|·············|·············|·············|···············|··············
|  GovernorFractionalMock  ·  castVoteWithReason           ·          -  ·          -  ·      89520  ·            1  ·          -  │
···························|·······························|·············|·············|·············|···············|··············
|  GovernorFractionalMock  ·  castVoteWithReasonAndParams  ·      75013  ·      75169  ·      75115  ·           10  ·          -  │
···························|·······························|·············|·············|·············|···············|··············
|  GovernorFractionalMock  ·  execute                      ·          -  ·          -  ·      64134  ·            3  ·          -  │
···························|·······························|·············|·············|·············|···············|··············
|  GovernorFractionalMock  ·  propose                      ·      87694  ·      87706  ·      87705  ·           19  ·          -  │
···························|·······························|·············|·············|·············|···············|··············
|  Deployments                                             ·                                         ·  % of limit   ·             │
···························································|·············|·············|·············|···············|··············
|  CallReceiverMock                                        ·          -  ·          -  ·     342850  ·        3.4 %  ·          -  │
···························································|·············|·············|·············|···············|··············
|  ERC20VotesMock                                          ·          -  ·          -  ·    1753134  ·       17.5 %  ·          -  │
···························································|·············|·············|·············|···············|··············
|  GovernorFractionalMock                                  ·    2742059  ·    2742071  ·    2742070  ·       27.4 %  ·          -  │
·----------------------------------------------------------|-------------|-------------|-------------|---------------|-------------·

Fixes #????

PR Checklist

[ ] Tests
[ ] Documentation
[ ] Changelog entry

Closing out in favor of #3


Use the workspace feature of Cargo to include sqllogictests and pg_analytics two packages

What feature are you requesting?
Use the workspace feature of Cargo to include sqllogictests and pg_analytics two packages
Why are you requesting this feature?
It would benefit #144
What is your proposed implementation for this feature?
No response
Full Name:
Weijun Huang
Affiliation:
Individual

/take

no needed