Remove unused argument of lib/ms

Description of the Change
Since options argument is unused in Mocha, this removes it.
https://github.com/mochajs/mocha/blob/2303c669ef1b47fef7cf86f5ef486d537033d443/lib/suite.js#L108-L110
https://github.com/mochajs/mocha/blob/2303c669ef1b47fef7cf86f5ef486d537033d443/lib/runnable.js#L82-L84
https://github.com/mochajs/mocha/blob/1bb6b3977a482c144a61d68ea2e499b22a7db01b/lib/reporters/base.js#L324-L326

Coverage increased (+0.01%) to 89.895% when pulling 5b19f7d16d967646acfe9778c5b83b4bb6942a74 on 38elements:ms-options into 1bb6b3977a482c144a61d68ea2e499b22a7db01b on mochajs:master.

Coverage increased (+0.01%) to 89.895% when pulling 8b42df689185db6250b0caf59680d4112ff8de50 on 38elements:ms-options into 1bb6b3977a482c144a61d68ea2e499b22a7db01b on mochajs:master.

@38elements lgtm, thanks!


Refactoring: Consistent use of single- and double quotes.

As I am not a real PHP programmer, the code is full of mixed uses of 'string' and "string" for string literals. Of course, as this is using HTML, too, it would be nice to go through the code and make it use 'string' in the PHP parts and attribute="value" in the HTML parts, consistently.

End of maintenance. See README!


Fix missing '-' in powershell parameter

Command doesn't work without it...

Cross-reference : https://github.com/MicrosoftDocs/azure-docs.fr-fr/pull/714

@cnotin : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Looks good. Thanks @cnotin
Merging in this repository is suspended until Tuesday, May 19. Merging will resume at 7:00 AM PT Tuesday. This PR is ready to merge. Thanks.

#sign-off for queue management
No further action is needed by the content team. The PR will be merged 5/19.

@ktoliver: I'm sorry - only the author of this article, @Deland-Han, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.


[Patcher] [ERR] Account store name not found in main.js

I got this error and app not working

mac os  sequoia 15.1
http toolkit version 1.19.1

kirmozor@localhost ~/G/httptoolkit-pro-patcher (master)> /opt/httptoolkit/httptoolkit
[Patcher] Selected temp path: /tmp/httptoolkit-patch
[Patcher] Server listening on port 5067
failed to open /usr/lib64/dri/hybrid_drv_video.so
Not using hybrid_drv_video.so
[Patcher] Request to: /?authToken=df5sBUiNMQPRNb7OtKm19NCJE78&desktopVersion=1.19.1
[Patcher] File not found in temp path, downloading
Config checked in 16 ms
Certificates setup in 26 ms
Standalone server started in 9 ms
Server started in 37 ms
Total startup took 88 ms
[Patcher] File downloaded and saved: /tmp/httptoolkit-patch/index.html
[Patcher] Request to: /fonts.css
[Patcher] Request to: /mockttp.js
[Patcher] Request to: /a219baaae146da8ee8f5.png
[Patcher] File not found in temp path, downloading
[Patcher] File not found in temp path, downloading
[Patcher] File not found in temp path, downloading
[Patcher] File downloaded and saved: /tmp/httptoolkit-patch/a219baaae146da8ee8f5.png
[Patcher] File downloaded and saved: /tmp/httptoolkit-patch/mockttp.js
[Patcher] Request to: /apis.js
[Patcher] File not found in temp path, downloading
[Patcher] File downloaded and saved: /tmp/httptoolkit-patch/fonts.css
[Patcher] Request to: /vendors-node_modules_ajv_dist_ajv_js-node_modules_base64-js_index_js-node_modules_browserify--bb5eaa.js
[Patcher] File downloaded and saved: /tmp/httptoolkit-patch/apis.js
[25625:1107/170135.096854:ERROR:gl_surface_presentation_helper.cc(260)] GetVSyncParametersIfAvailable() failed for 1 times!
[Patcher] Request to: /vendors-node_modules_bn_js_lib_bn_js-node_modules_path-browserify_index_js.js
[Patcher] Request to: /vendors-node_modules_ethersproject_abi_lib_esm_abi-coder_js-node_modules_fortawesome_free-bra-6b000d.js
[Patcher] Request to: /main.js
[Patcher] File not found in temp path, downloading
[Patcher] File not found in temp path, downloading
[Patcher] File downloaded and saved: /tmp/httptoolkit-patch/vendors-node_modules_bn_js_lib_bn_js-node_modules_path-browserify_index_js.js
[Patcher] File not found in temp path, downloading
[Patcher] File not found in temp path, downloading
[Patcher] Patching main.js
[Patcher] [ERR] Account store name not found in main.js
[25625:1107/170156.139257:ERROR:gl_surface_presentation_helper.cc(260)] GetVSyncParametersIfAvailable() failed for 2 times!

same issue for me

How I can fix this error >?  Help me

Sorry guys i can't reproduce this error, i tried 3 different machines and operating systems but patcher just perfectly works fine 😞

I have a problem as in this issue (https://github.com/XielQs/httptoolkit-pro-patcher/issues/6), and when I click on reload or force reload several times, the problem occurs as in this issue.

I have a problem as in that issue (#6), and when I click on reload or force reload several times, the problem occurs as in this issue.

i tried force reloading 10 times but i still opens without any problem

Me too reinstall program tried installing latest node version still get struck to logo if u want i can give u anydesk

I run this on new windows10 virtualbox:

httptoolkit 1.19.1
node 22.11.0
npm 10.9.0

I have the same error, it worked fine just about a couple of days ago. Mine just is responding with "Internal server error". Tried reinstalling it with several versions of node and httptoolkit.

yea i think i fixed it

should be working with bbd71da

Now all the errors reported disappeared, all working great.
Thanks <3

Good to see its working!!

Good to see its working!!

Thanx alot 😊❤

Good to see its working!!

Good to see its working!!

THANKS BROTHER

Good to see its working!!

Chad dev! Thanks a lot! It's all working great:)

Hi , Brother this error appears

How I can solve this error please help me

Hi , Brother this error appears

maybe try force reload

if I restore then it works and if I patch then this error appears

Hi , Brother this error appears

maybe try force reload

HTTP Toolkit's servers simply returns 428 probably because of fraud system. I'm still trying to fix it ASAP!!

Should be fixed with 20fc45df20533b2a10b0b9c18aff7bca066fadaa

same issue

 node . start
[+] HTTP Toolkit found at C:\Users\el3za\AppData\Local\Programs\httptoolkit
[+] Starting HTTP Toolkit...
[+] Done

[Patcher] Selected temp path: C:\Users\el3za\AppData\Local\Temp\httptoolkit-patch
[Patcher] Server listening on port 5067
[Patcher] Request to: /?authToken=S-nfKymn0Jygb3m-LExLg-xAGC4&desktopVersion=1.19.1
[Patcher] File not changed, serving from temp path
[Patcher] Request to: /mockttp.js
[Patcher] Request to: /apis.js
[Patcher] Request to: /a219baaae146da8ee8f5.png
[Patcher] Request to: /vendors-node_modules_ajv_dist_ajv_js-node_modules_base64-js_index_js-node_modules_browserify--bb5eaa.js
[Patcher] Request to: /vendors-node_modules_bn_js_lib_bn_js-node_modules_path-browserify_index_js.js
[Patcher] Request to: /vendors-node_modules_ethersproject_abi_lib_esm_abi-coder_js-node_modules_fortawesome_free-bra-6b000d.js
Config checked in 23 ms
Certificates setup in 6 ms
Standalone server started in 5 ms
Server started in 19 ms
Total startup took 53 ms
[Patcher] File not changed, serving from temp path
[Patcher] Request to: /main.js
[Patcher] File not changed, serving from temp path
[Patcher] File not changed, serving from temp path
[Patcher] File not changed, serving from temp path
[Patcher] File not changed, serving from temp path
[Patcher] File not changed, serving from temp path
[Patcher] File not found in temp path, downloading
[Patcher] Patching main.js
[Patcher] [ERR] Account store name not found in main.js

same issue

 node . start
[+] HTTP Toolkit found at C:\Users\el3za\AppData\Local\Programs\httptoolkit
[+] Starting HTTP Toolkit...
[+] Done

[Patcher] Selected temp path: C:\Users\el3za\AppData\Local\Temp\httptoolkit-patch
[Patcher] Server listening on port 5067
[Patcher] Request to: /?authToken=S-nfKymn0Jygb3m-LExLg-xAGC4&desktopVersion=1.19.1
[Patcher] File not changed, serving from temp path
[Patcher] Request to: /mockttp.js
[Patcher] Request to: /apis.js
[Patcher] Request to: /a219baaae146da8ee8f5.png
[Patcher] Request to: /vendors-node_modules_ajv_dist_ajv_js-node_modules_base64-js_index_js-node_modules_browserify--bb5eaa.js
[Patcher] Request to: /vendors-node_modules_bn_js_lib_bn_js-node_modules_path-browserify_index_js.js
[Patcher] Request to: /vendors-node_modules_ethersproject_abi_lib_esm_abi-coder_js-node_modules_fortawesome_free-bra-6b000d.js
Config checked in 23 ms
Certificates setup in 6 ms
Standalone server started in 5 ms
Server started in 19 ms
Total startup took 53 ms
[Patcher] File not changed, serving from temp path
[Patcher] Request to: /main.js
[Patcher] File not changed, serving from temp path
[Patcher] File not changed, serving from temp path
[Patcher] File not changed, serving from temp path
[Patcher] File not changed, serving from temp path
[Patcher] File not changed, serving from temp path
[Patcher] File not found in temp path, downloading
[Patcher] Patching main.js
[Patcher] [ERR] Account store name not found in main.js

are you using the latest version of patcher?

are you using the latest version of patcher?
yup, i just clone it

it's 2 am right now in my country I'm gonna take a look at it tomorrow

I installed the latest version of HttpToolkit (v1.19.1), then cloned the latest version of patcher to proceed with the work. But after Patching, the error was displayed as 2 screenshots I attached here. Please fix it.

OS: Windows 11 Pro 23H2 22631.4317
Node: v20.15.1
Npm: v10.7.0
HttpToolkit: v1.19.1

Same error appears.Please fix it.

can you clone the repository again and re-patch and share debug logs. If you get an error message, press OK first.

C:\Users\Goku\Desktop\NEW PATCHER HTTP\httptoolkit-pro-patcher>node . start
[+] HTTP Toolkit found at C:\Users\Goku\AppData\Local\Programs\httptoolkit
[+] Starting HTTP Toolkit...
[+] Done
[Patcher] Selected temp path: C:\Users\Goku\AppData\Local\Temp\httptoolkit-patch
[Patcher] Server listening on port 5067
[Patcher] Request to: /?authToken=FyGaZPjSKBgO8SRHs-jNW2Bp4MI&desktopVersion=1.19.1
[Patcher] File not found in temp path, downloading
[Patcher] File downloaded and saved: C:\Users\Goku\AppData\Local\Temp\httptoolkit-patch\index.html
[Patcher] Request to: /mockttp.js
[Patcher] Request to: /apis.js
[Patcher] Request to: /a219baaae146da8ee8f5.png
[Patcher] File not found in temp path, downloading
[Patcher] Request to: /vendors-node_modules_ajv_dist_ajv_js-node_modules_base64-js_index_js-node_modules_browserify--bb5eaa.js
[Patcher] Request to: /vendors-node_modules_ethersproject_abi_lib_esm_abi-coder_js-node_modules_fortawesome_free-bra-6b000d.js
[Patcher] Request to: /vendors-node_modules_bn_js_lib_bn_js-node_modules_path-browserify_index_js.js
[Patcher] File not found in temp path, downloading
[Patcher] File not found in temp path, downloading
[Patcher] File not found in temp path, downloading
[Patcher] File not found in temp path, downloading
[Patcher] File not found in temp path, downloading
[Patcher] File downloaded and saved: C:\Users\Goku\AppData\Local\Temp\httptoolkit-patch\a219baaae146da8ee8f5.png
[Patcher] File downloaded and saved: C:\Users\Goku\AppData\Local\Temp\httptoolkit-patch\mockttp.js
[Patcher] Request to: /main.js
[Patcher] File not found in temp path, downloading
[Patcher] File downloaded and saved: C:\Users\Goku\AppData\Local\Temp\httptoolkit-patch\vendors-node_modules_bn_js_lib_bn_js-node_modules_path-browserify_index_js.js
[Patcher] Patching main.js
[Patcher] [ERR] Account store name not found in main.js
[Patcher] [ERR] Empty response for file: C:\Users\Goku\AppData\Local\Temp\httptoolkit-patch\main.js {
status: 204,
statusText: 'No Content',
headers: Object [AxiosHeaders] {
date: 'Sun, 10 Nov 2024 09:24:48 GMT',
connection: 'keep-alive',
server: 'BunnyCDN-PK1-850',
'cdn-pullzone': '1110200',
'cdn-uid': '84940c56-1bd0-4fc0-b14b-dda6f6ba9cf3',
'cdn-requestcountrycode': 'PK',
vary: 'Accept-Encoding',
'cache-control': 'public, max-age=60, s-maxage=3600, stale-while-revalidate=600, stale-if-error=86400',
etag: '"smn02kfscv"',
'last-modified': 'Fri, 08 Nov 2024 14:54:20 GMT',
'cdn-cachedat': '11/08/2024 14:56:40',
'content-security-policy-report-only': "base-uri 'self'; object-src 'none'; script-src 'report-sample' 'unsafe-eval' 'self' https://cdn.auth0.com/ https://cdn.eu.auth0.com/ https://secure.gravatar.com 'sha256-KNb7+L5hR1W7Qq9KGtmfflR0uNjBu+BojZP+TXdIXxw=' 'sha256-/rzZmZSRZW5iB5KM/CN5xPTuX5BijhjFmaaj35lmUV4='; style-src 'report-sample' 'self' 'unsafe-inline'; default-src 'none'; frame-ancestors 'none'; img-src 'self' data: https://httptoolkit.com https://secure.gravatar.com; font-src 'self'; frame-src https://login.httptoolkit.tech; connect-src 'self' data: http://<IP_ADDRESS>:45456 http://<IP_ADDRESS>:45457 ws://<IP_ADDRESS>:45456 https://.httptoolkit.tech https://.sentry.io; report-uri https://o202389.ingest.us.sentry.io/api/1316304/security/?sentry_key=548601eca36246bdac73dc086d231db1&sentry_release=5ddef60c30799fe05acf12fd8cdc8b47cab3315b; report-to csp-endpoint",
'referrer-policy': 'strict-origin',
'reporting-endpoints': 'csp-endpoint="https://o202389.ingest.us.sentry.io/api/1316304/security/?sentry_key=548601eca36246bdac73dc086d231db1&sentry_release=5ddef60c30799fe05acf12fd8cdc8b47cab3315b"',
'x-clacks-overhead': 'GNU Terry Pratchett',
'x-envoy-upstream-service-time': '80',
'cdn-proxyver': '1.06',
'cdn-requestpullcode': '200',
'cdn-requestpullsuccess': 'True',
'cdn-edgestorageid': '850',
'cdn-status': '200',
'cdn-requesttime': '0',
'cdn-requestid': '909eb5d1d70d294b4b8be83615e53916',
'cdn-cache': 'HIT'
},
config: {
transitional: {
silentJSONParsing: true,
forcedJSONParsing: true,
clarifyTimeoutError: false
},
adapter: [ 'xhr', 'http', 'fetch' ],
transformRequest: [ [Function: transformRequest] ],
transformResponse: [ [Function: transformResponse] ],
timeout: 0,
xsrfCookieName: 'XSRF-TOKEN',
xsrfHeaderName: 'X-XSRF-TOKEN',
maxContentLength: -1,
maxBodyLength: -1,
env: { FormData: [Function], Blob: [class Blob] },
validateStatus: [Function: validateStatus],
headers: Object [AxiosHeaders] {
Accept: '/',
'Content-Type': undefined,
host: 'app.httptoolkit.tech',
connection: 'keep-alive',
'accept-encoding': 'gzip, deflate, br',
'accept-language': 'en-US',
origin: 'https://app.httptoolkit.tech',
referer: 'https://app.httptoolkit.tech/',
'sec-fetch-dest': 'script',
'sec-fetch-mode': 'no-cors',
'sec-fetch-site': 'same-origin',
'user-agent': 'Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) httptoolkit/1.19.1 Chrome/122.0.6261.130 Electron/29.1.5 Safari/537.36',
'sec-ch-ua': '"Not(A:Brand";v="24", "Chromium";v="122"',
'sec-ch-ua-mobile': '?0',
'sec-ch-ua-platform': '"Windows"'
},
baseURL: 'https://app.httptoolkit.tech',
responseType: 'arraybuffer',
method: 'get',
url: '/main.js',
data: undefined
},
request: <ref *1> ClientRequest {
_events: [Object: null prototype] {
error: [Array],
abort: [Function (anonymous)],
aborted: [Function (anonymous)],
connect: [Function (anonymous)],
socket: [Function (anonymous)],
timeout: [Function (anonymous)],
finish: [Function: requestOnFinish]
},
_eventsCount: 7,
_maxListeners: undefined,
outputData: [],
outputSize: 0,
writable: true,
destroyed: true,
_last: true,
chunkedEncoding: false,
shouldKeepAlive: true,
maxRequestsOnConnectionReached: false,
_defaultKeepAlive: true,
useChunkedEncodingByDefault: false,
sendDate: false,
_removedConnection: false,
_removedContLen: false,
_removedTE: false,
strictContentLength: false,
_contentLength: 0,
_hasBody: true,
_trailer: '',
finished: true,
_headerSent: true,
_closed: true,
socket: TLSSocket {
_tlsOptions: [Object],
_secureEstablished: true,
_securePending: false,
_newSessionPending: false,
_controlReleased: true,
secureConnecting: false,
_SNICallback: null,
servername: 'app.httptoolkit.tech',
alpnProtocol: false,
authorized: true,
authorizationError: null,
encrypted: true,
_events: [Object: null prototype],
_eventsCount: 9,
connecting: false,
_hadError: false,
_parent: null,
_host: 'app.httptoolkit.tech',
_closeAfterHandlingError: false,
_readableState: [ReadableState],
_maxListeners: undefined,
_writableState: [WritableState],
allowHalfOpen: false,
_sockname: null,
_pendingData: null,
_pendingEncoding: '',
server: undefined,
_server: null,
ssl: [TLSWrap],
_requestCert: true,
_rejectUnauthorized: true,
timeout: 5000,
parser: null,
_httpMessage: null,
[Symbol(alpncallback)]: null,
[Symbol(res)]: [TLSWrap],
[Symbol(verified)]: true,
[Symbol(pendingSession)]: null,
[Symbol(async_id_symbol)]: -1,
[Symbol(kHandle)]: [TLSWrap],
[Symbol(lastWriteQueueSize)]: 0,
[Symbol(timeout)]: Timeout {
_idleTimeout: 5000,
_idlePrev: [TimersList],
_idleNext: [Timeout],
_idleStart: 4976,
_onTimeout: [Function: bound ],
_timerArgs: undefined,
_repeat: null,
_destroyed: false,
[Symbol(refed)]: false,
[Symbol(kHasPrimitive)]: false,
[Symbol(asyncId)]: 614,
[Symbol(triggerId)]: 612
},
[Symbol(kBuffer)]: null,
[Symbol(kBufferCb)]: null,
[Symbol(kBufferGen)]: null,
[Symbol(kCapture)]: false,
[Symbol(kSetNoDelay)]: false,
[Symbol(kSetKeepAlive)]: true,
[Symbol(kSetKeepAliveInitialDelay)]: 1,
[Symbol(kBytesRead)]: 0,
[Symbol(kBytesWritten)]: 0,
[Symbol(connect-options)]: [Object]
},
_header: 'GET /main.js HTTP/1.1\r\n' +
'Accept: /\r\n' +
'host: app.httptoolkit.tech\r\n' +
'connection: keep-alive\r\n' +
'accept-encoding: gzip, deflate, br\r\n' +
'accept-language: en-US\r\n' +
'origin: https://app.httptoolkit.tech\r\n' +
'referer: https://app.httptoolkit.tech/\r\n' +
'sec-fetch-dest: script\r\n' +
'sec-fetch-mode: no-cors\r\n' +
'sec-fetch-site: same-origin\r\n' +
'user-agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) httptoolkit/1.19.1 Chrome/122.0.6261.130 Electron/29.1.5 Safari/537.36\r\n' +
'sec-ch-ua: "Not(A:Brand";v="24", "Chromium";v="122"\r\n' +
'sec-ch-ua-mobile: ?0\r\n' +
'sec-ch-ua-platform: "Windows"\r\n' +
'\r\n',
_keepAliveTimeout: 0,
_onPendingData: [Function: nop],
agent: Agent {
_events: [Object: null prototype],
_eventsCount: 2,
_maxListeners: undefined,
defaultPort: 443,
protocol: 'https:',
options: [Object: null prototype],
requests: [Object: null prototype] {},
sockets: [Object: null prototype],
freeSockets: [Object: null prototype],
keepAliveMsecs: 1000,
keepAlive: true,
maxSockets: Infinity,
maxFreeSockets: 256,
scheduling: 'lifo',
maxTotalSockets: Infinity,
totalSocketCount: 5,
maxCachedSessions: 100,
_sessionCache: [Object],
[Symbol(kCapture)]: false
},
socketPath: undefined,
method: 'GET',
maxHeaderSize: undefined,
insecureHTTPParser: undefined,
joinDuplicateHeaders: undefined,
path: '/main.js',
_ended: true,
res: IncomingMessage {
_readableState: [ReadableState],
_events: [Object: null prototype],
_eventsCount: 4,
_maxListeners: undefined,
socket: null,
httpVersionMajor: 1,
httpVersionMinor: 1,
httpVersion: '1.1',
complete: true,
rawHeaders: [Array],
rawTrailers: [],
joinDuplicateHeaders: undefined,
aborted: false,
upgrade: false,
url: '',
method: null,
statusCode: 204,
statusMessage: 'No Content',
client: [TLSSocket],
_consuming: false,
_dumped: false,
req: [Circular *1],
responseUrl: 'https://app.httptoolkit.tech/main.js',
redirects: [],
[Symbol(kCapture)]: false,
[Symbol(kHeaders)]: [Object],
[Symbol(kHeadersCount)]: 50,
[Symbol(kTrailers)]: null,
[Symbol(kTrailersCount)]: 0
},
aborted: false,
timeoutCb: null,
upgradeOrConnect: false,
parser: null,
maxHeadersCount: null,
reusedSocket: true,
host: 'app.httptoolkit.tech',
protocol: 'https:',
_redirectable: Writable {
_writableState: [WritableState],
_events: [Object: null prototype],
_eventsCount: 3,
_maxListeners: undefined,
_options: [Object],
_ended: true,
_ending: true,
_redirectCount: 0,
_redirects: [],
_requestBodyLength: 0,
_requestBodyBuffers: [],
_onNativeResponse: [Function (anonymous)],
_currentRequest: [Circular *1],
_currentUrl: 'https://app.httptoolkit.tech/main.js',
[Symbol(kCapture)]: false
},
[Symbol(kCapture)]: false,
[Symbol(kBytesWritten)]: 0,
[Symbol(kNeedDrain)]: false,
[Symbol(corked)]: 0,
[Symbol(kOutHeaders)]: [Object: null prototype] {
accept: [Array],
host: [Array],
connection: [Array],
'accept-encoding': [Array],
'accept-language': [Array],
origin: [Array],
referer: [Array],
'sec-fetch-dest': [Array],
'sec-fetch-mode': [Array],
'sec-fetch-site': [Array],
'user-agent': [Array],
'sec-ch-ua': [Array],
'sec-ch-ua-mobile': [Array],
'sec-ch-ua-platform': [Array]
},
[Symbol(errored)]: null,
[Symbol(kHighWaterMark)]: 16384,
[Symbol(kRejectNonStandardBodyWrites)]: false,
[Symbol(kUniqueHeaders)]: null
},
data:
}
Config checked in 205 ms
Certificates setup in 99 ms
Standalone server started in 15 ms
Server started in 103 ms
Total startup took 423 ms
[Patcher] File downloaded and saved: C:\Users\Goku\AppData\Local\Temp\httptoolkit-patch\vendors-node_modules_ajv_dist_ajv_js-node_modules_base64-js_index_js-node_modules_browserify--bb5eaa.js
[Patcher] File downloaded and saved: C:\Users\Goku\AppData\Local\Temp\httptoolkit-patch\apis.js
[Patcher] File downloaded and saved: C:\Users\Goku\AppData\Local\Temp\httptoolkit-patch\vendors-node_modules_ethersproject_abi_lib_esm_abi-coder_js-node_modules_fortawesome_free-bra-6b000d.js

These are logs

can you clone the repository again and re-patch and share debug logs. If you get an error message, press OK first.

The patch worked! Thanks for helping me out!

Thanks Brother For Fixing it.

can you clone the repository again and re-patch and share debug logs. If you get an error message, press OK first.

 The patch worked! Thanks for helping me out!

Still getting the 204 response, when I checked the folder, the file main.js did not exist.

Any solutions yet ?

kirmozor@localhost ~/Git> git clone https://github.com/XielQs/httptoolkit-pro-patcher.git --depth 1
Клонирование в «httptoolkit-pro-patcher»...
remote: Enumerating objects: 8, done.
remote: Counting objects: 100% (8/8), done.
remote: Compressing objects: 100% (8/8), done.
remote: Total 8 (delta 0), reused 6 (delta 0), pack-reused 0 (from 0)
Получение объектов: 100% (8/8), 10.12 КиБ | 80.00 КиБ/с, готово.
kirmozor@localhost ~/Git> cd httptoolkit-pro-patcher/
kirmozor@localhost ~/G/httptoolkit-pro-patcher (master)> clear
kirmozor@localhost ~/G/httptoolkit-pro-patcher (master)> ls
index.js  LICENSE  package.json  patch.js  README.md
kirmozor@localhost ~/G/httptoolkit-pro-patcher (master)> npm install
npm warn deprecated<EMAIL_ADDRESS>This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.
npm warn deprecated<EMAIL_ADDRESS>Glob versions prior to v9 are no longer supported

added 40 packages, and audited 41 packages in 13s

4 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities
kirmozor@localhost ~/G/httptoolkit-pro-patcher (master) [1]> node . restore
[+] HTTP Toolkit found at /opt/httptoolkit
[+] Restoring HTTP Toolkit...
[+] HTTP Toolkit restored
[+] Done
kirmozor@localhost ~/G/httptoolkit-pro-patcher (master)> node . patch
[+] HTTP Toolkit found at /opt/httptoolkit
[+] Started patching app...
[+] Extracting app...
✔ Enter a email for the pro plan …<EMAIL_ADDRESS>[+] Patched index.js
[+] Installing dependencies...

added 71 packages, removed 1 package, changed 7 packages, and audited 248 packages in 13s

33 packages are looking for funding
  run `npm fund` for details

4 vulnerabilities (2 low, 2 moderate)

To address all issues (including breaking changes), run:
  npm audit fix --force

Run `npm audit` for details.
[+] Backup created at /opt/httptoolkit/resources/app.asar.bak
[+] Building app...
[+] HTTP Toolkit patched successfully
[+] Restart HTTP Toolkit to apply changes
[+] Removing /tmp/httptoolkit-patch
[+] Removing /tmp/httptoolkit-patcher-temp
[+] Done
kirmozor@localhost ~/G/httptoolkit-pro-patcher (master)> /opt/httptoolkit/httptoolkit
[Patcher] Selected temp path: /tmp/httptoolkit-patch
[Patcher] Server listening on port 5067
failed to open /usr/lib64/dri/hybrid_drv_video.so
Not using hybrid_drv_video.so
[Patcher] Request to: /?authToken=bmZH1er5jZlLzhN_q6HV4YZtKuk&desktopVersion=1.19.1
[Patcher] File not found in temp path, downloading
Config checked in 36 ms
Certificates setup in 13 ms
Standalone server started in 8 ms
Server started in 24 ms
Total startup took 82 ms
[Patcher] File downloaded and saved: /tmp/httptoolkit-patch/index.html
[Patcher] Request to: /mockttp.js
[Patcher] Request to: /apis.js
[Patcher] Request to: /a219baaae146da8ee8f5.png
[Patcher] Request to: /vendors-node_modules_ajv_dist_ajv_js-node_modules_base64-js_index_js-node_modules_browserify--bb5eaa.js
[Patcher] Request to: /vendors-node_modules_bn_js_lib_bn_js-node_modules_path-browserify_index_js.js
[Patcher] Request to: /vendors-node_modules_ethersproject_abi_lib_esm_abi-coder_js-node_modules_fortawesome_free-bra-6b000d.js
[Patcher] File not found in temp path, downloading
[Patcher] File not found in temp path, downloading
[Patcher] File not found in temp path, downloading
[Patcher] File not found in temp path, downloading
[Patcher] File not found in temp path, downloading
[Patcher] File downloaded and saved: /tmp/httptoolkit-patch/mockttp.js
[Patcher] Request to: /main.js
[Patcher] File not found in temp path, downloading
[Patcher] File not found in temp path, downloading
[Patcher] File downloaded and saved: /tmp/httptoolkit-patch/a219baaae146da8ee8f5.png
[Patcher] Patching main.js
[Patcher] [ERR] Account store name not found in main.js
[14165:1111/104317.438460:ERROR:gl_surface_presentation_helper.cc(260)] GetVSyncParametersIfAvailable() failed for 1 times!
[14165:1111/104317.449928:ERROR:gl_surface_presentation_helper.cc(260)] GetVSyncParametersIfAvailable() failed for 2 times!
[Patcher] [ERR] Empty response for file: /tmp/httptoolkit-patch/main.js {
  status: 204,
  statusText: 'No Content',
  headers: Object [AxiosHeaders] {
    date: 'Mon, 11 Nov 2024 05:43:17 GMT',
    connection: 'keep-alive',
    server: 'BunnyCDN-SE1-725',
    'cdn-pullzone': '1110200',
    'cdn-uid': '84940c56-1bd0-4fc0-b14b-dda6f6ba9cf3',
    'cdn-requestcountrycode': 'KZ',
    vary: 'Accept-Encoding',
    'cache-control': 'public, max-age=60, s-maxage=3600, stale-while-revalidate=600, stale-if-error=86400',
    etag: '"smn02kfscv"',
    'last-modified': 'Fri, 08 Nov 2024 14:54:20 GMT',
    'cdn-cachedat': '11/08/2024 14:56:33',
    'content-security-policy-report-only': "base-uri 'self'; object-src 'none'; script-src 'report-sample' 'unsafe-eval' 'self' https://cdn.auth0.com/ https://cdn.eu.auth0.com/ https://secure.gravatar.com 'sha256-KNb7+L5hR1W7Qq9KGtmfflR0uNjBu+BojZP+TXdIXxw=' 'sha256-/rzZmZSRZW5iB5KM/CN5xPTuX5BijhjFmaaj35lmUV4='; style-src 'report-sample' 'self' 'unsafe-inline'; default-src 'none'; frame-ancestors 'none'; img-src 'self' data: https://httptoolkit.com https://secure.gravatar.com; font-src 'self'; frame-src https://login.httptoolkit.tech; connect-src 'self' data: http://<IP_ADDRESS>:45456 http://<IP_ADDRESS>:45457 ws://<IP_ADDRESS>:45456 https://*.httptoolkit.tech https://*.sentry.io; report-uri https://o202389.ingest.us.sentry.io/api/1316304/security/?sentry_key=548601eca36246bdac73dc086d231db1&sentry_release=5ddef60c30799fe05acf12fd8cdc8b47cab3315b; report-to csp-endpoint",
    'referrer-policy': 'strict-origin',
    'reporting-endpoints': 'csp-endpoint="https://o202389.ingest.us.sentry.io/api/1316304/security/?sentry_key=548601eca36246bdac73dc086d231db1&sentry_release=5ddef60c30799fe05acf12fd8cdc8b47cab3315b"',
    'x-clacks-overhead': 'GNU Terry Pratchett',
    'x-envoy-upstream-service-time': '80',
    'cdn-proxyver': '1.06',
    'cdn-requestpullcode': '200',
    'cdn-requestpullsuccess': 'True',
    'cdn-edgestorageid': '725',
    'cdn-status': '200',
    'cdn-requesttime': '0',
    'cdn-requestid': '09f226b71603d648505aa6e67ebcbc9e',
    'cdn-cache': 'HIT'
  },
  config: {
    transitional: {
      silentJSONParsing: true,
      forcedJSONParsing: true,
      clarifyTimeoutError: false
    },
    adapter: [ 'xhr', 'http', 'fetch' ],
    transformRequest: [ [Function: transformRequest] ],
    transformResponse: [ [Function: transformResponse] ],
    timeout: 0,
    xsrfCookieName: 'XSRF-TOKEN',
    xsrfHeaderName: 'X-XSRF-TOKEN',
    maxContentLength: -1,
    maxBodyLength: -1,
    env: { FormData: [Function], Blob: [class Blob] },
    validateStatus: [Function: validateStatus],
    headers: Object [AxiosHeaders] {
      Accept: '*/*',
      'Content-Type': undefined,
      host: 'app.httptoolkit.tech',
      connection: 'keep-alive',
      'accept-encoding': 'gzip, deflate, br',
      'accept-language': 'ru',
      origin: 'https://app.httptoolkit.tech',
      referer: 'https://app.httptoolkit.tech/',
      'sec-fetch-dest': 'script',
      'sec-fetch-mode': 'no-cors',
      'sec-fetch-site': 'same-origin',
      'user-agent': 'Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) httptoolkit/1.19.1 Chrome/122.0.6261.130 Electron/29.1.5 Safari/537.36',
      'sec-ch-ua': '"Not(A:Brand";v="24", "Chromium";v="122"',
      'sec-ch-ua-mobile': '?0',
      'sec-ch-ua-platform': '"Linux"'
    },
    baseURL: 'https://app.httptoolkit.tech',
    responseType: 'arraybuffer',
    method: 'get',
    url: '/main.js',
    data: undefined
  },
  request: <ref *1> ClientRequest {
    _events: [Object: null prototype] {
      error: [Array],
      abort: [Function (anonymous)],
      aborted: [Function (anonymous)],
      connect: [Function (anonymous)],
      socket: [Function (anonymous)],
      timeout: [Function (anonymous)],
      finish: [Function: requestOnFinish]
    },
    _eventsCount: 7,
    _maxListeners: undefined,
    outputData: [],
    outputSize: 0,
    writable: true,
    destroyed: true,
    _last: true,
    chunkedEncoding: false,
    shouldKeepAlive: true,
    maxRequestsOnConnectionReached: false,
    _defaultKeepAlive: true,
    useChunkedEncodingByDefault: false,
    sendDate: false,
    _removedConnection: false,
    _removedContLen: false,
    _removedTE: false,
    strictContentLength: false,
    _contentLength: 0,
    _hasBody: true,
    _trailer: '',
    finished: true,
    _headerSent: true,
    _closed: true,
    socket: TLSSocket {
      _tlsOptions: [Object],
      _secureEstablished: true,
      _securePending: false,
      _newSessionPending: false,
      _controlReleased: true,
      secureConnecting: false,
      _SNICallback: null,
      servername: 'app.httptoolkit.tech',
      alpnProtocol: false,
      authorized: true,
      authorizationError: null,
      encrypted: true,
      _events: [Object: null prototype],
      _eventsCount: 9,
      connecting: false,
      _hadError: false,
      _parent: null,
      _host: 'app.httptoolkit.tech',
      _closeAfterHandlingError: false,
      _readableState: [ReadableState],
      _maxListeners: undefined,
      _writableState: [WritableState],
      allowHalfOpen: false,
      _sockname: null,
      _pendingData: null,
      _pendingEncoding: '',
      server: undefined,
      _server: null,
      ssl: [TLSWrap],
      _requestCert: true,
      _rejectUnauthorized: true,
      timeout: 5000,
      parser: null,
      _httpMessage: null,
      [Symbol(alpncallback)]: null,
      [Symbol(res)]: [TLSWrap],
      [Symbol(verified)]: true,
      [Symbol(pendingSession)]: null,
      [Symbol(async_id_symbol)]: -1,
      [Symbol(kHandle)]: [TLSWrap],
      [Symbol(lastWriteQueueSize)]: 0,
      [Symbol(timeout)]: Timeout {
        _idleTimeout: 5000,
        _idlePrev: [TimersList],
        _idleNext: [Timeout],
        _idleStart: 5816,
        _onTimeout: [Function: bound ],
        _timerArgs: undefined,
        _repeat: null,
        _destroyed: false,
        [Symbol(refed)]: false,
        [Symbol(kHasPrimitive)]: false,
        [Symbol(asyncId)]: 573,
        [Symbol(triggerId)]: 571
      },
      [Symbol(kBuffer)]: null,
      [Symbol(kBufferCb)]: null,
      [Symbol(kBufferGen)]: null,
      [Symbol(kCapture)]: false,
      [Symbol(kSetNoDelay)]: false,
      [Symbol(kSetKeepAlive)]: true,
      [Symbol(kSetKeepAliveInitialDelay)]: 1,
      [Symbol(kBytesRead)]: 0,
      [Symbol(kBytesWritten)]: 0,
      [Symbol(connect-options)]: [Object]
    },
    _header: 'GET /main.js HTTP/1.1\r\n' +
      'Accept: */*\r\n' +
      'host: app.httptoolkit.tech\r\n' +
      'connection: keep-alive\r\n' +
      'accept-encoding: gzip, deflate, br\r\n' +
      'accept-language: ru\r\n' +
      'origin: https://app.httptoolkit.tech\r\n' +
      'referer: https://app.httptoolkit.tech/\r\n' +
      'sec-fetch-dest: script\r\n' +
      'sec-fetch-mode: no-cors\r\n' +
      'sec-fetch-site: same-origin\r\n' +
      'user-agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) httptoolkit/1.19.1 Chrome/122.0.6261.130 Electron/29.1.5 Safari/537.36\r\n' +
      'sec-ch-ua: "Not(A:Brand";v="24", "Chromium";v="122"\r\n' +
      'sec-ch-ua-mobile: ?0\r\n' +
      'sec-ch-ua-platform: "Linux"\r\n' +
      '\r\n',
    _keepAliveTimeout: 0,
    _onPendingData: [Function: nop],
    agent: Agent {
      _events: [Object: null prototype],
      _eventsCount: 2,
      _maxListeners: undefined,
      defaultPort: 443,
      protocol: 'https:',
      options: [Object: null prototype],
      requests: [Object: null prototype] {},
      sockets: [Object: null prototype],
      freeSockets: [Object: null prototype],
      keepAliveMsecs: 1000,
      keepAlive: true,
      maxSockets: Infinity,
      maxFreeSockets: 256,
      scheduling: 'lifo',
      maxTotalSockets: Infinity,
      totalSocketCount: 6,
      maxCachedSessions: 100,
      _sessionCache: [Object],
      [Symbol(kCapture)]: false
    },
    socketPath: undefined,
    method: 'GET',
    maxHeaderSize: undefined,
    insecureHTTPParser: undefined,
    joinDuplicateHeaders: undefined,
    path: '/main.js',
    _ended: true,
    res: IncomingMessage {
      _readableState: [ReadableState],
      _events: [Object: null prototype],
      _eventsCount: 4,
      _maxListeners: undefined,
      socket: null,
      httpVersionMajor: 1,
      httpVersionMinor: 1,
      httpVersion: '1.1',
      complete: true,
      rawHeaders: [Array],
      rawTrailers: [],
      joinDuplicateHeaders: undefined,
      aborted: false,
      upgrade: false,
      url: '',
      method: null,
      statusCode: 204,
      statusMessage: 'No Content',
      client: [TLSSocket],
      _consuming: false,
      _dumped: false,
      req: [Circular *1],
      responseUrl: 'https://app.httptoolkit.tech/main.js',
      redirects: [],
      [Symbol(kCapture)]: false,
      [Symbol(kHeaders)]: [Object],
      [Symbol(kHeadersCount)]: 50,
      [Symbol(kTrailers)]: null,
      [Symbol(kTrailersCount)]: 0
    },
    aborted: false,
    timeoutCb: null,
    upgradeOrConnect: false,
    parser: null,
    maxHeadersCount: null,
    reusedSocket: false,
    host: 'app.httptoolkit.tech',
    protocol: 'https:',
    _redirectable: Writable {
      _writableState: [WritableState],
      _events: [Object: null prototype],
      _eventsCount: 3,
      _maxListeners: undefined,
      _options: [Object],
      _ended: true,
      _ending: true,
      _redirectCount: 0,
      _redirects: [],
      _requestBodyLength: 0,
      _requestBodyBuffers: [],
      _onNativeResponse: [Function (anonymous)],
      _currentRequest: [Circular *1],
      _currentUrl: 'https://app.httptoolkit.tech/main.js',
      [Symbol(kCapture)]: false
    },
    [Symbol(kCapture)]: false,
    [Symbol(kBytesWritten)]: 0,
    [Symbol(kNeedDrain)]: false,
    [Symbol(corked)]: 0,
    [Symbol(kOutHeaders)]: [Object: null prototype] {
      accept: [Array],
      host: [Array],
      connection: [Array],
      'accept-encoding': [Array],
      'accept-language': [Array],
      origin: [Array],
      referer: [Array],
      'sec-fetch-dest': [Array],
      'sec-fetch-mode': [Array],
      'sec-fetch-site': [Array],
      'user-agent': [Array],
      'sec-ch-ua': [Array],
      'sec-ch-ua-mobile': [Array],
      'sec-ch-ua-platform': [Array]
    },
    [Symbol(errored)]: null,
    [Symbol(kHighWaterMark)]: 16384,
    [Symbol(kRejectNonStandardBodyWrites)]: false,
    [Symbol(kUniqueHeaders)]: null
  },
  data: <Buffer >
}
[Patcher] File downloaded and saved: /tmp/httptoolkit-patch/vendors-node_modules_bn_js_lib_bn_js-node_modules_path-browserify_index_js.js
[Patcher] File downloaded and saved: /tmp/httptoolkit-patch/apis.js
[Patcher] File downloaded and saved: /tmp/httptoolkit-patch/vendors-node_modules_ajv_dist_ajv_js-node_modules_base64-js_index_js-node_modules_browserify--bb5eaa.js
(node:14177) Warning: Using insecure HTTP parsing
(Use `node --trace-warnings ...` to show where the warning was created)
Shutting down after API call...

OS: openSUSE Leap 15.6
Kernel: 6.4.0-150600.23.25-default

can you clone the repository again and re-patch and share debug logs. If you get an error message, press OK first.

 The patch worked! Thanks for helping me out!

What is the version of HTTP Toolkit?

Doesnt work for me on v1.19.1 httptoolkit

@XielQs It seems the issue might be related to Axios. There could be a TLS fingerprinting block in place?. Just guessing though. When Axios is used to fetch main.js, it returns a status 204, meaning no content is received. However, using got-scraping seems to bypass the 204 status, allowing the request to succeed.
if (data === '') {
   const remoteFile = await fetchWithGotScraping(req.url);
   data = remoteFile.body.toString()
   console.log("remoteFile", remoteFile.statusCode)
 }

let's have a try!

PR merged, can guys try again?

PR merged, can guys try again?

Now new error

I am using latest HTTP Tookit.

PR merged, can guys try again?

Now new error

I am using latest HTTP Tookit.

can you share debug logs?

node index.js start

OK I have fixed this by updating my node js version
Here was error
[+] Installing dependencies... npm WARN EBADENGINE Unsupported engine { npm WARN EBADENGINE   package<EMAIL_ADDRESS>npm WARN EBADENGINE   required: { node: '>=20' }, npm WARN EBADENGINE   current: { node: 'v18.8.0', npm: '8.18.0' } npm WARN EBADENGINE }
After update nodejs to v22.11.0, I have patched again, now its working fine.
Thank you <3 @XielQs

PR merged, can guys try again?

Now new error

I am using latest HTTP Tookit.

can you share debug logs?

PR merged, can guys try again?

Hey, yesterday it worked for me, failed again today. So I tried the new merge,
First try:
[Patcher] Selected temp path: /tmp/httptoolkit-patch [Patcher] Server listening on port 5067 All server versions installed are outdated, deleting [Patcher] Request to: /?authToken=iUMI_2IjujqZw9tKgOO2PQAsdwA&desktopVersion=1.19.1 [Patcher] File not found in temp path, downloading [Patcher] File downloaded and saved: /tmp/httptoolkit-patch/index.html Config checked in 12 ms Certificates setup in 11 ms Standalone server started in 8 ms Server started in 22 ms Total startup took 53 ms [Patcher] Request to: /mockttp.js [Patcher] Request to: /apis.js [Patcher] Request to: /a219baaae146da8ee8f5.png [Patcher] No internet connection, trying to serve directly from temp path [Patcher] File not found in temp path: /tmp/httptoolkit-patch/mockttp.js [Patcher] Request to: /vendors-node_modules_ajv_dist_ajv_js-node_modules_base64-js_index_js-node_modules_browserify--bb5eaa.js [Patcher] Request to: /vendors-node_modules_bn_js_lib_bn_js-node_modules_path-browserify_index_js.js [Patcher] Request to: /vendors-node_modules_ethersproject_abi_lib_esm_abi-coder_js-node_modules_fortawesome_free-bra-6b000d.js [Patcher] Request to: /main.js [Patcher] No internet connection, trying to serve directly from temp path [Patcher] File not found in temp path: /tmp/httptoolkit-patch/a219baaae146da8ee8f5.png [Patcher] File not found in temp path, downloading [Patcher] File not found in temp path, downloading [Patcher] No internet connection, trying to serve directly from temp path [Patcher] File not found in temp path: /tmp/httptoolkit-patch/vendors-node_modules_ethersproject_abi_lib_esm_abi-coder_js-node_modules_fortawesome_free-bra-6b000d.js [Patcher] File not found in temp path, downloading [Patcher] File downloaded and saved: /tmp/httptoolkit-patch/apis.js [Patcher] Patching main.js [Patcher] File downloaded and saved: /tmp/httptoolkit-patch/vendors-node_modules_ajv_dist_ajv_js-node_modules_base64-js_index_js-node_modules_browserify--bb5eaa.js [Patcher] File not found in temp path, downloading [Patcher] File downloaded and saved: /tmp/httptoolkit-patch/vendors-node_modules_bn_js_lib_bn_js-node_modules_path-browserify_index_js.js remoteFile 200 [Patcher] main.js patched [Patcher] File downloaded and saved: /tmp/httptoolkit-patch/main.js [Patcher] Request to: /ui-update-worker.js [Patcher] Preventing service worker from loading ^C(node:11729) Warning: Using insecure HTTP parsing (Use node --trace-warnings ... to show where the warning was created) Shutting down after API call..
Second try
╰─ ./httptoolkit                                                                                ─╯ [Patcher] Selected temp path: /tmp/httptoolkit-patch [Patcher] Server listening on port 5067 [Patcher] Request to: /?authToken=TKAfaYRcgX61GFwooGexm1cIXlc&desktopVersion=1.19.0 [Patcher] No internet connection, trying to serve directly from temp path [Patcher] File not found in temp path: /tmp/httptoolkit-patch/index.html Config checked in 7 ms Certificates setup in 10 ms Standalone server started in 8 ms Server started in 21 ms Total startup took 47 ms [Patcher] Request to: /ui-update-worker.js [Patcher] Preventing service worker from loading

Sometimes I got error "No internet connection", sometimes I got a zero byte index.html
https://github.com/user-attachments/assets/b64c386d-5ca5-47fb-b759-bf26e0eff929

yea i'm working on it right now!!

finally HTTP Toolkit's server banned my ip, so i can work with my own computer 😋

This is weird because it's working now and I can't produce the error anymore.
Before that I cd node_modules then npm i got-scraping then cd .. and npm i got-scraping again.

looks like they have a scape protection?

This is weird because it's working now and I can't produce the error anymore. Before that I cd node_modules then npm i got-scraping then cd .. and npm i got-scraping again. Edit: Sometimes it works sometimes not.

maybe that's because server blocks your connection idk


image_straighten.py line 32 angle hardcoded

Why is angle hardcoded at 12?  This does not seem quite right.

Hey thanks for pointing this out,I was trying the code on other images,and was surprised why it was failing,I think the hard coded value would explain why the code fails to generalize on other examples.
One such case is as follows


Fix unused parameter compiler warnings

Towards #1064. First chunk of fixes for compiler warnings of the shape
parameter value arg in {class, method} MySymbol is never used

Rationale for the fix in the commit message.

Codecov Report

Merging #1469 (e0d8c7d) into unstable (3834a20) will increase coverage by 0.01%.
The diff coverage is 40.00%.

:exclamation: Current head e0d8c7d differs from pull request most recent head a5634ad. Consider uploading reports for the commit a5634ad to get more accurate results

@@             Coverage Diff              @@
##           unstable    #1469      +/-   ##
============================================
+ Coverage     74.66%   74.68%   +0.01%
============================================
  Files           359      358       -1
  Lines         11512    11505       -7
  Branches        543      548       +5
============================================
- Hits           8596     8593       -3
+ Misses         2916     2912       -4

Impacted Files
Coverage Δ

...in/scala/at/forsyte/apalache/tla/bmcmt/Arena.scala
77.90% <0.00%> (ø)

...a/at/forsyte/apalache/tla/bmcmt/LazyEquality.scala
73.52% <0.00%> (ø)

.../forsyte/apalache/tla/bmcmt/SymbStateDecoder.scala
79.20% <0.00%> (ø)

...yte/apalache/tla/bmcmt/SymbStateRewriterAuto.scala
50.00% <ø> (-1.22%)
:arrow_down:

...n/scala/at/forsyte/apalache/io/OutputManager.scala
15.38% <0.00%> (ø)

...at/forsyte/apalache/tla/pp/TlcConfigImporter.scala
84.09% <ø> (ø)

...apalache/tla/pp/passes/ConfigurationPassImpl.scala
0.00% <0.00%> (ø)

...e/apalache/tla/pp/passes/ReTLAInlinePassImpl.scala
0.00% <ø> (ø)

...e/apalache/tla/pp/passes/ReTLAPreproPassImpl.scala
0.00% <ø> (ø)

...te/apalache/tla/typecheck/etc/EtcTypeChecker.scala
83.55% <ø> (ø)

... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3834a20...a5634ad. Read the comment docs.


Create SECURITY.md

Dear @Malith3019
Please do the code review and do the needful also Please send me the current yml log report
Thank you
@kulasekara02


[WIP] New site for the new architecture

[ ] new landing page from https://www.figma.com/proto/sKvm2ghvKJFnID2nst974V/Alephjs.org?page-id=0%3A1&node-id=14%3A5&scaling=min-zoom
[ ] documentation for the new architecture
[x] deploy to deno deploy https://aleph.deno.dev

Did you mean to deploy this to Production? 'cause right now alephjs.org and aleph.deno.dev only have placeholder content.


Fixed Grammatical Errors.

Fixed grammatical errors and amended the paragraphs to make them syntactically correct. Notable changes in line 6, line 12, and line 14.

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

Thank you for your contribution. At this time we have decided not to merge your pull request. We welcome future pull requests from you.
Reason:
The modifications in this PR do not significantly improve the previous material and may introduce new issues.
Happy Coding!


Stop using app.py in samples and screenshot

This makes the tool look like a poor man's syntax highlighter, which it is not

Won't do


Revert "Revert "Replace navigation blur listeners with useFocusEffect""

Reverts Expensify/App#54244

Straight revert

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.


A package shouldn't be able to edit other package settings

Currently any package can edit, save and even erase settings for other packages without any security prevention in between.
Maybe, somehow, every package should receive actions intended for that package only.

I agree, but due to the complexity of the implementation and the fact that we are going to control all the code from packages for a while, it's not needed for the launch.

Won't fix.


Images and videos not being download for newly added blogs

I'm using the latest release and seems all the images and videos are not being download when the blog is newly added, only the url lists are presented in the download folder.  The strange thing is this does not affect blog added long time ago, such as added 1 week ago, which updated fine with the latest images and videos.
After a while, I decided to test in a virtual machine, where it never run TumblThree before, and surprisingly the files are downloaded for any newly added blog!  I wonder is anything corrupted due to upgrade the tool from an older release? Or the settings file?

I guess that you have the enabled function of downloading url lists in the details view. Uncheck this checkbox and after that the files should be downloaded normally.

Thanks for the reply!
My fault to change the setting to enable download url list by default since I thought this will download both contents and url list at the same time.  Sorry!


I created a fork due to inactivity

Hey guys, I've only stumbled upon this project recently and it rocks.
Sadly it doesn't cater to all my needs and I was eager to contribute back.
After seeing there is huge backlog of Pull Request I decided to Fork and incorporate all the mayor ones.
Of course nobody likes projects which don't have a canonical source of truth so I am more than willing to put to merge all changes back if EmulationStation gets unfrozen, I just want to move the project forward.
Right now I changed the config directory to something sensible on every platform (.config/emulationstation on linux, Appplication Support or .config/emulationstation on OSX and My Documents on Windows) so you have to move your config there if you want to use the fork.
I've also fixed the build on OSX maybe breaking Linux in the process so it would be nice if someone would check that.
The top of the roadmap is reading all issues and pulls for the next few days
https://github.com/Herdinger/EmulationStation

Thanks for this. I would love to see this project continue to move forward!

Hey @Herdinger  - I've been thinking of doing the same. I'd hate to fork this, but unless @Aloshi can comment on the status of the project, it might make sense. I'm currently running my own fork on a few platforms (MacOS, Windows, and hopefully soon the RPI). I also looked on RetroPie's fork, and they're trying not to deviate too much from upstream.
I'd be happy to collaborate with you on your fork if you want. I have several opinions on how to make this a better project over all. I've currently pulled in a couple PRs and added support for hiding files in my fork.
Send me an email listed on my profile, and we can chat more if you want.

Good job @Herdinger and @t3hi3x , i will start following your fork. This project has definitely been missing some attention. There are alot of good PR's waiting to be merged in :-)

Great work guys, I have recently started to work on the repo as weill, I like to contribute however
While trying to compile emulationstation  on a board called orange pi, its fails at 90% using the below error message.
Running an ubuntu arm distribution, and have mali drivers installed.
any ideas why ?
make[2]: *** No rule to make target '/usr/lib/arm-linux-gnueabihf/libGL Sv1_CM.so', needed by 'emulationstation'.  Stop.    CMakeFiles/Makefile2:301: recipe for target 'es-app/CMakeFiles/emulation station.dir/all' failed      make[1]: *** [es-app/CMakeFiles/emulationstation.dir/all] Error 2   Makefile:137: recipe for target 'all' failed make: *** [all] Error 2

Could you include a -nosplash option for ES, and maybe allow for a color/alpha option for the main screen white bar in the theme?  I dont know if I am able to add a feature request to your repository separately, so I just replied to you here :)

@joeelliott I've added a --no-splash option (also the boolean SplashScreen int the settings file) since it was a quick fix. I haven't looked at any GUI code yet but I will look into it.
@eddywebs Sorry I have no idea right now. Basically your Makefile expects a library which isn't there. The weird thing is that CMake detects the library and that's the reason it put it in the Makefile in the first place. It would be helpful if you rebuild from the newest commit with "cmake . > logfile.txt" and post the result

Just to check, do we need to compile your fork ourselves?

@slikvik55 - yeah, at the moment yes. @Herdinger and I are working on some options to download nightly binaries, but the infrastructure isn't setup yet.

Any interest in a metadata API strictly for EmulationStation? I'd imagine that it would just return a simple JSON response with release date, publisher, and whatever else people consider important information.

Api work is already done by someone > https://github.com/neolao/recalbox-api
It says recalbox but under the hood its all emulationstation, recalbox is
just a buildroot unix with emulationstation.
On Wed, Mar 2, 2016 at 5:52 PM, Donovan Hernandez<EMAIL_ADDRESS>wrote:

Any interest in a metadata API strictly for EmulationStation? I'd imagine
that it would just return a simple JSON response with release date,
publisher, and whatever else people consider important information.
—
Reply to this email directly or view it on GitHub
https://github.com/Aloshi/EmulationStation/issues/563#issuecomment-191479749
.

--
Best Wishes;
Adi

@eddywebs feel free to read the doc and the source code before telling that recalbox is just buildroot + ES. Check the api and you will se that none of the rest methods have anything to do with ES.

@eddywebs As indicated by his name, Recalbox API is an API for Recalbox. It doesn't control EmulationStation.
If you look at the documentation, you can modify Recalbox configuration, upload files, create virtual gamepads and launch games.

@heydonovan What sort of uses were you thinking of for the API?

@slikvik55 Well, for one I think it's silly to have to resort to scraping of any sort. There should be an API that only returns the information needed. Perhaps support for custom box art (from vgboxart.com).
I'm not too sure what else it would need to do. What does the community want? :p

@eddywebs I'm having the same issue as you.https://github.com/Aloshi/EmulationStation/issues/563#issuecomment-187489874
Did you figure out how to fix it? I installed EmulationStation about a month ago on SteamOS without any problems but now I'm on Debian 8. It doesn't make any sense, it should work on Debian, SteamOS is Debian

Awesome stuff guys! I'm building a steam machine and would love to use ES as a front-end for all my console games.
I haven't used ES in a way but the major pitfall I remember was having to manually configure each game for each emulator via an XML file. Lets say I have 900 Sega Genesis ROMs, would there be an easy way to batch create XML files for all of them using a pre-configured command string? For Unix-like platforms you could have sed edit the scraped artwork/info XML file and inject in the command string, no idea how you'd do it on Windows though.

Hi @brando56894
The XML files are auto-generated in these current versions and use a scraper to pull metadata down. You can also confirm which one you want when there is more than one match. You can edit the metadata from ES.
We are planning on pulling in a PR to manage this via sqlite DB (https://github.com/Herdinger/EmulationStation/pull/12), so that might help a bit too.
Does this make sense? Does it address your concerns?

Hey, this is a good idea. I was hoping I'd get the motivation to work on EmulationStation again, but I think it's safe to say that hasn't happened, and I should probably give up on waiting for it to happen.
I think this is the first fork that has actually wanted to improve the core program and maintain cross-platform support. Best of luck...if this is something you're serious about (like "long term maintenance" and "providing binaries" serious), I can put up a link somewhere on the website.

It's great to hear those news! I built my emulation machine in 2015 using EmulationStation as a frontend. I'd love it to get updates and especially better scraping.

interesting i have absolutely no idea what this fork means. but if someone is making new updates to the ES, it sure sounds great.  is it something that can be downloaded now?..
also Aloshi sad to hear if you wont be working on it anymore, but even so you absolutely destroyed Hyperspin and any other front-end WE LOVE ES

Hi @Aaskari1988 - yeah, we're making updates to ES on https://github.com/Herdinger/EmulationStation
There aren't any binary downloads yet, but you can download and compile on there.
@Aloshi - THANKS for the support! We definitely are serious, but I'm working on some infrastructure stuff to support that effectively. I'll keep you in the loop on that as we get closer.
Alex

cool. looks to complicated  for me, for now.  but interesting definitely keeping an eye on it

@Aaskari1988 I may compile a Windows binary this weekend if I get time and will upload it to my site.
I'll post in here if I do.

will it work on my Portable ES ?

any chance we could see new systems added ?

Sorry for my ignorance, but what is Portable ES? Do you mind linking to some details?

i got from this guy. i never could get the normal install working but this did https://www.youtube.com/watch?v=oHtCnBiyzOY

I also run ES in portable mode - it should be fine. Regarding the Win32 compile, I forgot it's Easter weekend in the UK so I may not get as much time as I hoped!

So thus is maybe just me thinking way into the future.  But could we see new systems li the Wii U added to emulationstation?

Hey folks,
OK, I got buildbot uploading binaries automatically to dropbox. Take a look at https://github.com/Herdinger/EmulationStation 's Readme for a link (incase I change it :) )
All platforms are automatic except Windows...working on writing the batch script for that. I do have the latest binaries (including an install) out there.

I think the best would be to shift the ownership of this repository to new maintainer.

Hi @zgoda - definitely open to that (and agree it's better than maintaining a fork), but obviously, that's up to @Aloshi.

Is there any way to give this fork a portable option? I keep my ".emulationstation" folder in ES's program directory and launch it via a batch file containing:
@echo off
set HOME=%~dp0
emulationstation.exe
This batch file doesn't work with your fork. Is there any other way for this to be done?

thegamesdb down again. suggestion a different scrapper would be great

@OmenBoy - I thought about making a parameter for pointing to the config folder to make it easy to do this type of thing. We moved the config folder around. I'd try doing "Documents\EmulationStation" in your ES program folder instead of .emulationstation to see if that works.

@t3hi3x No luck :(

@OmenBoy the suggestion made by @t3hi3x doesn work never.. guindows does not handle references in bat process due does not hadle it very well..
inlinux either are working due POSIX are follow by OS, and if env variable are imported (eg. import HOME=./usbdrive) will ever work due previously variable set
swicht to linux or try to import a variable, but as i understant "set" its the equivalent of "import" right?

@Aloshi u can made @t3hi3x and @Herdinger collaborators with write permission ot write pull request on oficial ES repository.. tjhis solves the problem of owership or manteniance of the ES proyect for a while
if u added those guys as collaborators the can work in a brand or by pull request
can we made a brand named "es-comunity" and other "es-official", just like cinellerra (of course not so like) and then comunity can obtain "fan made" releases of the ES proyect.. and the u original author later can track those changes and releases in the oficial brand
another its that those collaborators can continue a more dinamic proyect as comunity-driven of the ES proyect for users only!

Thank you so much for adding the --config-directory command line option! It's working perfect :)

Thanks for all your hard work everyone.

Are any of the participants still interested in maintaining and/or forking?

@t3hi3x and @Herdinger  had been working, i suggested to made those users collaborators with write permisions, that will solve the problem

@mckaygerhard that was 3 months ago though and it looks like there hasn't been a commit to @Herdingers repo in a month.   Thus why ink bringing it up again.  Doesn't look like that is going to happen.

Definitely still engaged, just slow due to travel and life.
Our main priority is getting unit tests built for the the functionality side of the house. From there, we're looking at features around library management and efficiency.
As always if people want to contribute code, feel free! Especially if you're willing to help build some unit tests.

well @dissolve we need to former a team and a group in github and a folk official using all the other works and make it a reallity!
but nobody are in pronuncie! i can organize and give to the leqders the passwords, integrate a "faisbuk" and "twitter" accoounds and make it for the .. but i dont see any leader to make it!
i can start tomorrow at the night and in the friday all are ready to commit and post news!

Hello and thanks you for your fork that is still alive this project.
I got this problem, while I was compiling the program.
img
I'm on Archlinux.
pd: sorry, I'm learning English.

Good to hear @Herdinger , i'll track this project for my packages at packages.libregeek.org. Mainly SteamOS, but if anyone wants semi-regular packages for Ubuntu/Debian/Fedora, let me know.


Other item and focus

Auto focus input after choose "other".

Thought I'd add this here rather than in a new ticket: other validation happens too early as the "provide Other option" (or whatever it says) error appears as soon as Other box is checked and doesn't disappear when focus is lost on other input box.


Yahoo! Destination Documentation

@cgarcia1980 - Thank you for submitting the documentation for your destination. The documentation is now live at https://experienceleague.adobe.com/docs/experience-platform/destinations/catalog/advertising/datax.html?lang=en


[Trufflehog Update] Deprecation of GitGuardian and mandatory update to Trufflehog

Description
The GitGuardian secret scanning tool licence is now going to be expired, therefore in order to maintain the Security of the Tractus-X Repositories there will be inforced the TRG-8.03 for all Tractus-X repos.
In order to keep the secret scanning functionality, it is required to add a workflow, so that before PRs are merged, there will be scanned for any API secrets, passwords, etc. Preventing you to publish into the open source repo main branch important secrets.
Why?
TruffleHog is an open source tool designed to identify sensitive information, such as API keys, passwords, and other credentials, that may have been inadvertently committed to your code repository. This tool is expected to be used in parallel to the native GitHub Secret Scanning tool.
Goal

Remove all GitGuardian workflows/documentation and substitute them to Trufflehog workflows, resolving all the vulnerabilities raised

TRG 8.03
Detecting and removing these secrets is crucial for maintaining the security of your application and infrastructure. TruffleHog performs a thorough search by checking the entire repository history, not just the latest commits. This means it can find secrets that were committed in the past and might still pose a security risk.
Configure your GitHub Actions to include:
workflow dispatch: Manual workflow execution.
schedule: Schedule the workflow to run at least once a week with 0 0 * * 0.
push and pull_request: Activate the workflow on both push and pull request events targeting the branch that contains the code for the currently supported version, which may not necessarily be the main branch. This is the branch from which new releases will be made.
Note: extra_args: --filter-entropy=4 --results=verified,unknown
Including extra_args: --filter-entropy=4 --results=verified,unknown in the GitHub Actions workflow ensures that TruffleHog focuses on detecting high-entropy strings, which are more likely to be sensitive information such as passwords or API keys. This setup also instructs TruffleHog to report both verified secrets and potential but unverified secrets, providing a comprehensive security scan that helps identify and address all possible vulnerabilities in the code.
Including run: exit 1 in a step of a GitHub Actions workflow, as demonstrated below, commands the workflow to halt execution. This ensures that should TruffleHog uncover any secrets during its scan, the workflow promptly terminates in failure.
GitHub Actions allows you to define workflows to automatically run TruffleHog scans on your code. You'll see the output that triggered the failure directly in the logs.
Here’s how you can set it up:
name: "TruffleHog"

on:
  push:
    branches: ["main"]
  pull_request:
    # The branches below must be a subset of the branches above
    branches: ["main"]
  schedule:
    - cron: "0 0 * * *" # Once a day
  workflow_dispatch:

permissions:
  actions: read
  contents: read
  security-events: write
  id-token: write
  issues: write

jobs:
  ScanSecrets:
    name: Scan secrets
    runs-on: ubuntu-latest
    steps:
      - name: Checkout Repository
        uses: actions/checkout@v4
        with:
          fetch-depth: 0  # Ensure full clone for pull request workflows

      - name: TruffleHog OSS
        id: trufflehog
        uses: trufflesecurity/trufflehog@7e78ca385fb82c19568c7a4b341c97d57d9aa5e1
        continue-on-error: true
        with:
          path: ./  # Scan the entire repository
          base: "${{ github.event.repository.default_branch }}"  # Set base branch for comparison (pull requests)
          extra_args: --filter-entropy=4 --results=verified,unknown --debug

      - name: Scan Results Status
        if: steps.trufflehog.outcome == 'failure'
        run: exit 1  # Set workflow run to failure if TruffleHog finds secrets

I have runned a scan https://github.com/eclipse-tractusx/sig-infra/pull/545 for checking which repos have the Trufflehog and which ones not:
eclipse-tractusx/digital-product-pass contains .github/workflows/trufflehog.yaml
eclipse-tractusx/tractusx-edc contains .github/workflows/secrets-scan.yml
eclipse-tractusx/portal-backend contains .github/workflows/trufflehog.yml
eclipse-tractusx/portal contains .github/workflows/trufflehog.yml
eclipse-tractusx/puris contains .github/workflows/trufflehog.yml
eclipse-tractusx/portal-frontend contains .github/workflows/trufflehog.yml
eclipse-tractusx/ssi-dim-wallet-stub contains .github/workflows/trufflehog.yml
eclipse-tractusx/portal-iam contains .github/workflows/trufflehog.yml
eclipse-tractusx/portal-assets contains .github/workflows/trufflehog.yml
eclipse-tractusx/ssi-credential-issuer contains .github/workflows/trufflehog.yml
eclipse-tractusx/ssi-authority-schema-registry contains .github/workflows/trufflehog.yml
eclipse-tractusx/portal-frontend-registration contains .github/workflows/trufflehog.yml
eclipse-tractusx/policy-hub contains .github/workflows/trufflehog.yml
eclipse-tractusx/bpdm contains .github/workflows/trufflehog.yml
eclipse-tractusx/managed-service-orchestrator contains .github/workflows/trufflehog.yml
eclipse-tractusx/sldt-bpn-discovery contains .github/workflows/trufflehog.yml
eclipse-tractusx/sldt-discovery-finder contains .github/workflows/trufflehog.yml
eclipse-tractusx/sldt-semantic-hub contains .github/workflows/trufflehog.yml
eclipse-tractusx/sldt-digital-twin-registry contains .github/workflows/trufflehog.yml
eclipse-tractusx/demand-capacity-mgmt contains .github/workflows/trufflehog.yml

List of Repositories that do not contain Trufflehog (archived are excluded):
eclipse-tractusx/eclipse-tractusx.github.io
eclipse-tractusx/.eclipsefdn
eclipse-tractusx/api-hub
eclipse-tractusx/charts
eclipse-tractusx/sig-release
eclipse-tractusx/portal-shared-components
eclipse-tractusx/tutorial-resources
eclipse-tractusx/tractusx-edc-template
eclipse-tractusx/bpn-did-resolution-service
eclipse-tractusx/sldt-semantic-models
eclipse-tractusx/knowledge-agents-aas-bridge
eclipse-tractusx/managed-simple-data-exchanger-frontend
eclipse-tractusx/traceability-foss
eclipse-tractusx/managed-identity-wallet
eclipse-tractusx/item-relationship-service
eclipse-tractusx/sd-factory
eclipse-tractusx/data-exchange-test-service
eclipse-tractusx/knowledge-agents
eclipse-tractusx/knowledge-agents-edc
eclipse-tractusx/tractus-x-umbrella
eclipse-tractusx/vas-country-risk
eclipse-tractusx/sldt-ontology-model
eclipse-tractusx/sig-security
eclipse-tractusx/tractus-x-release
eclipse-tractusx/managed-simple-data-exchanger-backend
eclipse-tractusx/sig-infra
eclipse-tractusx/managed-simple-data-exchanger
eclipse-tractusx/.github
eclipse-tractusx/SSI-agent-lib
eclipse-tractusx/eclipse-tractusx.github.io.largefiles
eclipse-tractusx/testdata-provider
eclipse-tractusx/tractusx-profiles
eclipse-tractusx/app-dashboard

Since the gitguardian do not needed a worflow but was there by the default, now we need to include the workflows in order to keep the secret scanning functionality.

I have runned a scan https://github.com/eclipse-tractusx/sig-infra/pull/545 for checking which repos have the Trufflehog and which ones not:
eclipse-tractusx/digital-product-pass contains .github/workflows/trufflehog.yaml
eclipse-tractusx/tractusx-edc contains .github/workflows/secrets-scan.yml
eclipse-tractusx/portal-backend contains .github/workflows/trufflehog.yml
eclipse-tractusx/portal contains .github/workflows/trufflehog.yml
eclipse-tractusx/puris contains .github/workflows/trufflehog.yml
eclipse-tractusx/portal-frontend contains .github/workflows/trufflehog.yml
eclipse-tractusx/ssi-dim-wallet-stub contains .github/workflows/trufflehog.yml
eclipse-tractusx/portal-iam contains .github/workflows/trufflehog.yml
eclipse-tractusx/portal-assets contains .github/workflows/trufflehog.yml
eclipse-tractusx/ssi-credential-issuer contains .github/workflows/trufflehog.yml
eclipse-tractusx/ssi-authority-schema-registry contains .github/workflows/trufflehog.yml
eclipse-tractusx/portal-frontend-registration contains .github/workflows/trufflehog.yml
eclipse-tractusx/policy-hub contains .github/workflows/trufflehog.yml
eclipse-tractusx/bpdm contains .github/workflows/trufflehog.yml
eclipse-tractusx/managed-service-orchestrator contains .github/workflows/trufflehog.yml
eclipse-tractusx/sldt-bpn-discovery contains .github/workflows/trufflehog.yml
eclipse-tractusx/sldt-discovery-finder contains .github/workflows/trufflehog.yml
eclipse-tractusx/sldt-semantic-hub contains .github/workflows/trufflehog.yml
eclipse-tractusx/sldt-digital-twin-registry contains .github/workflows/trufflehog.yml
eclipse-tractusx/demand-capacity-mgmt contains .github/workflows/trufflehog.yml

List of Repositories that do not contain Trufflehog (archived are excluded):
eclipse-tractusx/eclipse-tractusx.github.io
eclipse-tractusx/.eclipsefdn
eclipse-tractusx/api-hub
eclipse-tractusx/charts
eclipse-tractusx/sig-release
eclipse-tractusx/portal-shared-components
eclipse-tractusx/tutorial-resources
eclipse-tractusx/tractusx-edc-template
eclipse-tractusx/bpn-did-resolution-service
eclipse-tractusx/sldt-semantic-models
eclipse-tractusx/knowledge-agents-aas-bridge
eclipse-tractusx/managed-simple-data-exchanger-frontend
eclipse-tractusx/traceability-foss
eclipse-tractusx/managed-identity-wallet
eclipse-tractusx/item-relationship-service
eclipse-tractusx/sd-factory
eclipse-tractusx/data-exchange-test-service
eclipse-tractusx/knowledge-agents
eclipse-tractusx/knowledge-agents-edc
eclipse-tractusx/tractus-x-umbrella
eclipse-tractusx/vas-country-risk
eclipse-tractusx/sldt-ontology-model
eclipse-tractusx/sig-security
eclipse-tractusx/tractus-x-release
eclipse-tractusx/managed-simple-data-exchanger-backend
eclipse-tractusx/sig-infra
eclipse-tractusx/managed-simple-data-exchanger
eclipse-tractusx/.github
eclipse-tractusx/SSI-agent-lib
eclipse-tractusx/eclipse-tractusx.github.io.largefiles
eclipse-tractusx/testdata-provider
eclipse-tractusx/tractusx-profiles
eclipse-tractusx/app-dashboard

fyi: secret scanning and secret scanning push protection is already enabled for all repos in the eclipse-tractusx organization and currently all committers are setup as security managers so can access information in the security tab of the organization / repo to access whether any secrets have been detected (push protection is not able to prevent all secrets from being pushed). So thats a good start, having a second way to do secret scanning is certainly a good idea.
However, may I suggest that you add the template e.g. to the sig-security repo so that the other repo just have to call that workflow instead of copy & pasting the whole workflow. This would be similar to how the mavenLicenseCheck.yml is setup as you can see here: https://github.com/eclipse-dash/dash-licenses/blob/master/.github/workflows/mavenLicenseCheck.yml
That way you can adjust that easily in one place without having to check it for every repo if something has to change. Also I would suggest to pin the action to a specific version and update as needed.

btw the overview here https://entro.security/blog/securing-the-code-navigating-code-and-github-secrets-scanning/ does not talk so well about trufflehog due to its high number of false positives, but I guess you did some research beforehand, I actually never used that tool.

Hi @netomi, thank you for your support 💯
The Trufflehog tool was selected by our security experts as the preferred open source security scan tool.
There was already a researched done by them previously and also the repositories that I have mentioned have already implemented the workflow and tested.
I am aware it can raise several false positives, but the same was happening with GitGuardian if I am honest...
Good point! It's a good idea to place the Trufflehog workflow in one of our "main" repositories for security.
I will bring this topic and your comments in our next office hour and committer meeting.
@evegufy and @stephanbcbauer lets this discuss this further on 💯

@eclipse-tractusx/automotive-tractusx-committers remember to add the Trufflehog commit 7e78ca385fb82c19568c7a4b341c97d57d9aa5e1 as version on your workflows!
We should also discuss in the committer round which repos do not need the workflow at all :)

its fine for me to use that additional secret scanning tool. I am wondering a bit how potentially detected secrets are reported. In the workflow log?
Also the .eclipsefdn would ideally be exempted from that workflow. We do get notifications if the GitHub secret scanning detects some though and that should be enough for now afaict.

@netomi they should ideally be reported in the security tab when run in main, and if run in a PR in the workflow I suppose.
Sure I believe we also don't need in other repos like .github or other ones, we will close the issues from the repos that do not require the double secrets scanning check :)

eclipse-tractusx/managed-simple-data-exchanger-frontend#187
eclipse-tractusx/traceability-foss#1371
eclipse-tractusx/managed-identity-wallet#351 -> Not yet merged
eclipse-tractusx/tutorial-resources#428 -> Not yet merged
eclipse-tractusx/sd-factory#210
eclipse-tractusx/data-exchange-test-service#100
eclipse-tractusx/knowledge-agents-edc#246
eclipse-tractusx/vas-country-risk#226
eclipse-tractusx/managed-simple-data-exchanger-backend#220
eclipse-tractusx/managed-simple-data-exchanger#57
eclipse-tractusx/eclipse-tractusx.github.io.largefiles#19

We need to add the --only-verified and add the workflow in the .github.

Update TRG

Ticket open in eclipse help desk to deprecate the gitguardian: https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/5281

Gitguardian is desactivated... Please integrate the  trufflehog as soon as posible, if secrets are leaked is in your own risk  now. ☠
Thank you very much for everyone that has added the trufflehog workflow! 🎉 💯
@eclipse-tractusx/automotive-tractusx-committers please note that is recommended to use the --only-verified  in  case you have much false positives. ✅
This Repos still not have it, they are added  to the list of candidates to be deprecated: 📛

https://github.com/eclipse-tractusx/data-exchange-test-service/issues/100
https://github.com/eclipse-tractusx/vas-country-risk/issues/226

Please not that I have added the workflow in  .github: https://github.com/eclipse-tractusx/.github/blob/main/.github/workflows/trufflehog.yaml

I am closing this issue then! Great Job everyone!


Invalid parameter key_source on Apt::Source[zabbix] at /etc/puppet/environments/myenv/modules/zabbix/manifests/repo.pp:144 on node XXXXX

I'm having an interesting error.
According to the docs I don't need to add anything more than:
class { 'zabbix::agent':
server => 'ipaddress',
}
which I did.
Here is the code snippet:
  'ubuntu' : {
    apt::source { 'zabbix':
      location   => "http://repo.zabbix.com/zabbix/${zabbix_version}/ubuntu/",
      release    => $ubuntu,
      repos      => 'main',
      key        => 'FBABD5FB20255ECAB22EE194D13D58E479EA5ED4',
      key_source => 'http://repo.zabbix.com/zabbix-official-repo.key',
    }

my version is 1.5.0
I'm using ubuntu
I'm using puppetlabs/apt 2.0.1 which I think is the root of the problem.

Are you using an "old" apt::source definition?
David Thornton

Had the same issues and needed to downgrade apt to 1.8 to get it working again.

apt patched.. going to test with the update 2.1.0

Does the 2.1.0 version work?

sorry for missing this response, after the patch, everything worked fine.

i've the same problem, but im using debian wheezy

Hi @luiszandonadi
What version of the yum module are you using?

+1 I have exactly the same error on a Debian 8.2 server.
├── puppetlabs-apt (v2.2.0)
└── wdijkerman-zabbix (v1.6.0)
It's really weird because sometime all is fine and zabbix is installed without error message, and sometine not.
Regards.

I too have this problem, apt v 2.2.0, tried to downgrade to 2.1.0 and no luck, the apt module change how it deals with keys some time back if I remember correctly

Looking at their site,

if $key_source != undef {
warning("$key_source is deprecated and will be removed in the next major release, please use $key => { 'source' => ${key_source} } instead.")
}

It appears we need to change to $key this was detailed in 2.2.x at https://github.com/puppetlabs/puppetlabs-apt/blob/2.2.x/manifests/source.pp#L59

@dj-wasabi I believe you can close this, looks like edits required were already performed.

Will close the issue. It can always be reopened again.


Cleanup: Merge adjustCpuShares to adoptContainerSettings

Signed-off-by: Qiang Huang<EMAIL_ADDRESS>

Can you point me to the original issue for this CPUShares adjustment?

@hqhq what is the problem this is fixing?

@tiborvass No logic changed, just clean up, we can have the unified entry to adjust configs, as we have a unified entry to check configs.

@hqhq small nit and needs a rebase :(

@tiborvass Updated, thanks.

@hqhq Awfully sorry, needs another rebase :(

@tiborvass  Done.

@hqhq i promise if you rebase again I'll give it priority, sorry!

LGTM apart from small nit (if you can address it, the better)

LGTM (same comment as @tiborvass)

Compile error on the Windows daemon: daemon\create.go:19: too many arguments in call to daemon.adaptContainerSettings

Gone those days where i could assume bad windows CI ... :P
@hqhq please fix compile error! Thanks @jhowardmsft

Life is green again :) Finally!

@tiborvass Updated, thanks.

Much better :)

LGTM

LGTM


Add hero groups to support hero animations with nested navigators

This is an implementation for the solution (1b) mentioned in #28042.

I think a simpler solution would be to avoid walking into nested Navigators.

@goderbauer Ian is out for a while.  Can you take a look (and approve or reject as you see fit) for customer: solaris.  Thank you.

Alternative approach: https://github.com/flutter/flutter/pull/29069

Closing, since @goderbauer's alternative looks better.


Test framework has to support variables

To allow running tests in different configurations test framework should support variables that can be overridden form command line.

Fixed in PR #345


Location doesn't work

When I tried $location = "West US", it throws ErrorMessage: The source blob xxx.vhd does not belong to the same region as the disk. I tried with $location = "WestUS", it works

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 52d62229-f4fb-481a-ed46-704e25334cb5
Version Independent ID: 3fd579d5-51c6-642b-144a-f92a3401416c
Content: Upload a generalize VHD to create multiple VMs in Azure
Content Source: articles/virtual-machines/windows/sa-upload-generalized.md
Service: virtual-machines-windows
GitHub Login: @cynthn
Microsoft Alias: cynthn

@simonlzn , Great find. I will look into this and update you.

@msrini-MSFT can you please open a bug in the PowerShell repo to have them address inconsistencies between acceptable syntax for -location across the Az module?
@simonlzn Thanks for catching this! Looks like not all cmdlets allow spaces in the -location, so this is something we need to look at a little more broadly :)

@MicahMcKittrick-MSFT @jpconnock FYI

Opened a PowerShell bug.
https://github.com/Azure/azure-powershell/issues/8886
Closing this issue.


make v2.2 (master branch) stable

Issues that need to be fixed:

[ ] nydus-image subcommand not work with --bootstrap, for example nydus-image check --bootstrap
[ ] nydus-image Tar/TargzToRafs losts file xattrs
[ ] zran TarToRef not works
[ ] nydusd throws error if image chunk size > 1MB
[ ] prefetch module throws some errors
[ ] test compatibility with v2.1 binaries

We can reproduce aboves in this PR https://github.com/dragonflyoss/image-service/pull/983 (with cd smoke && make test)
CIs need to be fixed:

[ ] convert ci broken
[ ] nydus test ci broken
[ ] nydus release ci broken

Per my tests, "nydus-image check --bootstrap bootstrap" and "nydus-image check bootstrap" works as expected.
But "nydus-image inspect --bootstrap bootstrap" doesn't work because we don't support --bootstrap for inspect, it has been changed to nydus-image inspect bootstrap


Does not work with Python 3.9

After installing with
pip install --user beanstalkc

Trying this will fails:
~> python
Python 3.9.5 (default, May 14 2021, 00:00:00)
[GCC 11.1.1 20210428 (Red Hat 11.1.1-1)] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import beanstalkc
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/user/.local/lib/python3.9/site-packages/beanstalkc.py", line 78
    except CommandFailed, (status, results):
                        ^
SyntaxError: invalid syntax

https://github.com/seveas/beanstalkc
conda install -c bjrn beanstalkc3


[Event Request] codeunit 5940 ServContractManagement - OnCreateRemainingPeriodInvoiceOnBeforeConfirm

Can you add event OnCreateRemainingPeriodInvoiceOnBeforeConfirm to procedure CreateRemainingPeriodInvoice?
        if (InvFrom = 0D) or (InvFrom > InvTo) then
            exit;
        // >>>>>>>>>>>>>>>>>>>>>>
        //if ConfirmManagement.GetResponseOrDefault(StrSubstNo(Text006, InvFrom, InvTo), true) then begin
        OnCreateRemainingPeriodInvoiceOnBeforeConfirm(IsConfirmed, IsHandled);
        if not IsHandled then
            IsConfirmed := ConfirmManagement.GetResponseOrDefault(StrSubstNo(Text006, InvFrom, InvTo), true);
        if IsConfirmed then begin
        // <<<<<<<<<<<<<<<<<<<<<<
            InvoiceNo := CreateServHeader(CurrServContract, PostingDate, false);
            ServHeader.Get(ServHeader."Document Type"::Invoice, InvoiceNo);
            ServMgtSetup.Get();
            if not CurrServContract.Prepaid then
                CurrServContract.Validate("Last Invoice Date", InvTo)

    [IntegrationEvent(false, false)]
    local procedure OnCreateRemainingPeriodInvoiceOnBeforeConfirm(var IsConfirmed: Boolean; var IsHandled: Boolean)
    begin
    end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


Drop Googles horrible conscrypt

I have no idea why this was added to a patch release. Google makes horrible stuff and their repos are a mess. Now netty depends on conscrypt, which in turn depends now on Google's boringssl. Which they recommend others not use.
"BoringSSL is a fork of OpenSSL that is designed to meet Google's needs.
Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability."
All furthering stuff from tomcat-native, that netty modifies to netty-tc-native, and now Google messing up further with conscrypt. Its making a real mess and a nightmare for packagers. Even the conscrypt sources google puts on Maven no longer build due to missing constants. That conscrypt generates from a c file, generate_constants.cc, Which in of itself is insane. That includes borringssl modified openssl headers. Its a complete mess.
I already dislike Google, their java stuff is horrendous. I would never use any Google Java or other software. This type of packaging madness is making me really hate Java.
Please please use projects with good upstreams. Please do not add dependencies to a project on patch releases. Please ensure outside projects are of release quality and not rapidly changing. None of this would be the case if netty did not use conscypt. Its become problematic since.
This effects both 4.0.x and 4.1.x with both switching to conscrypt at 4.1.10 and 4.0.45. That is really something that should be done on a major or minor release, not a patch.

@wltjr its a optional dependency so you are free to just not use it by not put it on your class path. Netty will still work and just either use netty-tcnative if its on the class path or JDK SSL impl.

@normanmaurer maybe optional runtime but not build time. This is regarding my efforts in packaging Netty on Gentoo. I do not have a choice in packaging conscrypt. Unless I delete the optional code using it.
A user may still want to, and then I will have to see about packaging boringssl which is a build and runtime dependency of conscrypt. It is NOT like netty-tc-native. That does not require extra packages to build. If boringssl was intended for 3rd parties and had a release that would be one thing. The relationship between conscrypt and boringssl is odd. conscrypt uses a C program to create a NativeConstants class. Which you must compile, then run that program to get the NativeConstants.java. Which is not present in rc9 of conscrypt on maven. You cannot even build it from their sources on maven.
conscrypt needs at minimum the C headers from boringssl to be able to compile the generate_natives program, and then run that to get NativeConstants.java. Which cannot be avoided. Since it seems netty-handler needs at least rc8 or rc9 of conscrypt now.
Its a big mess, easily avoided by not using conscrypt. Google has made a mess of that. Go look into building conscrypt, boringssl, and see if that is really something Netty wants to be connected to, and dependent on. Even if an optional runtime, it is still mandatory build time.

@nmittler any idea how to "fix this"...

@wltjr btw I think you would be better of to be less "aggressive" with your issue titles etc otherwise people may feel not really motived to help you.  Netty itself receive a lot of contributions from google and we even have google engineers in the core team...
Just my 2 ' cents ....

And just to clarify I am not saying there is no issue with how conscrypt is packaged / build and how it is integrated with netty its just not the "nicest" way to report an issue... Anyway let us wait for @nmittler and see if he can help here...

One thought it  netty-handler could be split further, netty-handler-conscrypt etc. Though I really think you all should look into how conscrypt is build. If it was using openssl it would be one thing. Google needs to decide on what they are going to do with boringssl. Both conscrypt and boringssl are Google projects and tightly coupled, as conscrypt needs live headers from boringssl. Thus it really needs to be present and "installed" to build conscrypt. I am not sure why Google cannot contribute to openssl and/or netty-tc-native, and must make a fork of a fork regarding netty-tc-native. Or at least make boringssl usable for others, do a release, etc.
Thank you for your consideration! Conscrypt was not a big deal when I first packaged it using maven sources. Though I was questioning why maven sources vs being able to build directly. Which I am now. I do not like having to constantly touch things I have packaged. I had to some what re-do the conscrypt package. I know I have a considerable amount of work to do still to make conscrypt usable. I had to be creative to package rc9 as it was.
I would like it if Linus Torvalds was a nice guy. I would like it if I did not have frustrations from projects that considered dependency when added. Sorry for the aggressiveness, but it comes from frustration resulting from time loss and the mess.
When it comes to anything relating to Google, nice is out the door. I do not want to take this off topic. I have numerous technical issues with Google. I am a Linux and Java guy, anti Microsoft. But I never hated any company.  Their stuff is a mess, a joke, and I do not use it. I would really question their contributions to Netty.
For example, their Youtube Java APIs and code is HORRIBLE!!! I packaged all that mess. I will never use it. I used JSON simple to do what I needed. I find it interesting I can use say one facebook4j for most all of facebook.  Every version of Guava must be slotted,  on Gentoo. Various packages need specific versions etc. Google has destroyed Android. I have issues on maps, chromium, etc. Technical stuff.
I also have personal and business issues with Google, recently delisted from maps after some google certified contributor left me a 1 star review with no feedback. Which Google argued with me and then removed my business entirely. Google is causing me so many problems. I am trying to do what I can daily to avoid them.
 With how I see them being socially, being a republican. I know I would never fit in at google, be accepted, listened to etc.  My frustrations and gripes with them are 100% legitimate, technical, and I can back up with facts, links, etc.
Not one of my issues only effects me. Google just does not care. They are always right, everyone else is wrong. Their influence and reach is ever growing, as is the mess they are creating.
Please please please consider this information. I have no ill will towards Google.  They are absolute evil! I have sent them thousands in business in the past as well....

https://github.com/fantasylandinst/fcop or some of the ideas might be of use.

Something that kills innovation -> Google I/O 2008 - Open Source Projects and Poisonous People
Something that breeds innovation -> Steve Jobs - Beautiful Polished Rocks
Proof
https://www.infoworld.com/article/3109830/linux/why-did-gentoo-linux-fade-into-obscurity.html
http://distrowatch.com/table.php?distribution=exherbo
I always conduct myself professionally. You may not like what I am saying or the manner in which I state it, aggressive, etc. But it is not violating almost any CoC, including the referenced one... Its called work not fun. Many times in life people say things you do not want to hear, or state it in a manner you do not like. That does not mean it is not professional or even insulting, though you may take it as such. Maybe others need to learn people skills to handle people who have a style and point of view that differs with their own. Most anyone who works in a call center is faced with such daily. Do they drive customers away or find means to calm them and find out the cause of the frustration/aggressiveness. Either way, they find a way to deal, or hang up and make it worse. Ever work retail, there is no escaping, short of calling security or the police... Good luck doing that with an irate customer....
Having seen what CoC enforcement does to communities. If you want to stifle innovation and drive people away. Go right ahead and proceed with such. Not to mention inconsistent application of CoC. Which I have seen more than once, as its always up to interpretation. I tend to look more to the root cause vs some sort of punishment to appease others, usually a minority.
Something that maybe of interest -> Partial Initial Patches to update Zookeeper trunk to Netty 4.x API
There is still legacy stuff in wide use that needs to be updated. While others fork and create a mess of new projects. With no mind to what this does to others, the downstream effect. I am not sure people making this stuff even care about others per the text on boringssl readme.
I do not see how stuff like conscrypt helps others FOSS projects update to current Netty. Zookeeper is still using 3.x from org.jboss not even io.netty...

For someone who claims to harbor no ill will towards google, you sure do love piling on unnecessary commentary that adds nothing new to the (closed) issue. Your assertion that you conduct yourself professionally is laughable. The project marked the issue as closed. If you have nothing new to contribute, no new commentary is needed. Irrelevant rants about CoC belong on your blog, not github.

@jeffjirsa What are you adding that is on topic? Or @dimitarg
Judging and making comments such as ones conduct is not professional and laughable is a direct insult. That is something covered by CoC. Why I said interpretation, as I am sure @jeffjirsa you think your comments are pertinent to this issue, while calling me out for my comments on an issue I opened. While you proceed to add nothing of value, and seem to violate CoC yourself.
Having a strong dislike even hatred for a business, Google. Is not the same as having ill will. I am not saying I want to see anything happen to Google. Like you all point out my conduct. I want to see Google change its conduct. So does the EU. it will only be a matter of time before other Governments like the US one act. None of that am I talking about, supporting etc. I am not saying anything should happen to Google.
I just have major issues with most all being technical and a few other, relating to my business, etc. 100% legitimate gripes. Given how often Google is being talked about in the news. Many clearly have  growing issue with them. This is all off topic.
Why I tried to bring alls attention to things like the Zookeeper situation. Which I was working on, and the comments who rather bring up CoC, say its a rant needs to go to blog etc. They are not helping there. Maybe coding in other areas, but i am adding things of value...
Why I conclude with saying adding conscrypt to netty does not really help. It will not help any project using older netty move to newer. I was very shocked to see it added as a new dependency for a patch release. Not even a minor version release. Added to both 4.0.x and 4.1.x about the same time. I assume netty users wanted that.


[BUG] Can't type in the rich text editor

Describe the bug
I'm trying to create a very simple rich text editor, just using the startup code from the README. However, although the toolbar shows up fine and the text editor is displayed, the toolbar is interactive but there is no cursor within the text editor and tapping on it and typing does nothing. I even tried adding a callback for onChangeContent in case the text just wasn't visible for some reason, but that's not getting fired either. What am I missing?
HtmlEditorController controller = HtmlEditorController();

return HtmlEditor(
      controller: controller, //required
      htmlEditorOptions: HtmlEditorOptions(
        hint: "Your text here...",
        initialText: "text content initial, if any",
      ),
      otherOptions: OtherOptions(
        height: 400,
      ),
    );

To Reproduce
Steps to reproduce the behavior:
Add the code above to a Flutter view and then try to type in the text editor.
Expected behavior
That you can type in the text editor.
Screenshots

Device:
iOS Simulator 15.4
Additional context
Flutter 2.10.4

Never mind, it looks like hot reload was messing with me on this one. A clean rebuild / run, and now it's working perfectly. Thanks for your work on this!


Deployment Kind override

Is your feature request related to a problem? Please describe.
Some time there is a need of overriding deployment.kind to something like StatefulSet
Describe the solution you'd like
Something like deployment.kind to be set using chart values
Describe alternatives you've considered
nothing
Additional context

@aslafy-z what do you think about this? The original idea and intention for the application chart is for stateless applications