Hide Weekend Days - with last version 7.1.6 is not working anymore

Hi,
Before switching to swift 4.2 and update JTAppleCalendar to the last version, I was hiding the weekend days by changing the cellSize property, followed by a calendar reloadData. Also the scrolling mode is set to .stopAtEachSection. After the migration, this feature is not working anymore or something has changed and I'm missing what's new. I've tested also your demo project, same behaviour. Any hints? Thanks

ok it looks like i definitely broke something.
Let me work on this.

thanks ;)

i just pushed an update to master branch.
can you test it and let me know if it was fixed?
To test master branch, follow the instructions here

everything ok with the weekend days now ... still have some issues with visibleDates, but will create a new ticket because this issue is fixed
thanks a lot for your implication and for this awesome library ;)

cool.


Add docker image?

It could be nice to have a docker image with Zap cli installed - something like what I created in zaproxy/zaproxy#4091.

Sounds good, so just basically the one from your PR there will do, right?

Yes, I can open a PR next week if you'd like


Add table horizontal resizing

Enable table horizontal resizing by adding div accompanied by mouse event handler at the right of each td,
The solution is based on this : https://www.brainbell.com/javascript/making-resizable-table-js.html

Hi @khalilmansouri
Thank you for your contribution.!
But, this PR is not working at the Chrome, FireFox.
Please check again.

I'll check it


Query editor for the dataframe view

What

Fixes https://github.com/rerun-io/rerun/issues/7065
Supersedes  #6961

This PR introduce a new blueprint archetype and related bespoke UI to configure the query underlying a dataframe view. As a consequence of this new scheme, Visible Time Range is no longer shown in dataframe view selection panel.

Checklist

[x] I have read and agree to Contributor Guide and the Code of Conduct
[x] I've included a screenshot or gif (if applicable)
[x] I have tested the web demo (if applicable):

Using examples from latest main build: rerun.io/viewer
Using full set of examples from nightly build: rerun.io/viewer

[x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
[x] If applicable, add a new check to the release checklist!
[x] If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

PR Build Summary
Recent benchmark results
Wasm size tracking

To run all checks from main, comment on the PR with @rerun-bot full-check.

Have a few comments about this, however they may not belong to this particular issue. I leave that up to you!

When segment select is 'Follow timeline' we shall also display what is the value of following that timeline, like what is the timeline and what is the latest at. This educates users on how this control works and creates a connection with through the familiar pattern. Also nicer because if users want to see what is the time value they don't need to gaze all the way down to the timeline. See the little video:

https://github.com/user-attachments/assets/bd2be7d1-6edf-4a0a-9134-55b1d9e8a39b

some spacing in the list. so the inline spacing subconsciously gives us signals what belongs to what, right? (like whatever is closer to each other = related and vice versa). So see how in the screenshot the space C is much bigger than B or A. This gives an idea that selector is related only to 'view property' and a bit to the 'timeline', but 'showing' is kinda it's own thing. while actually 'showing' and 'timeline' are an entity that should be closer and then they are related to the segment, which is also related to the 'view property' with other things in the panel.

My guess this could be a part of this issue: https://github.com/rerun-io/rerun/issues/6708


Improve accuracy of xmlrpc timeouts

Enhancement Request
Description
Current XML-RPC timeouts are set for the underlying transport (usually curl). The timeouts are not accurately set. This issue is to improve timeouts on the xml rpc client.
Use case
Accurate timeouts for Raft
Interface Changes
NaN

Progress Status

[ ] Branch created
[ ] Code committed to development branch
[ ] Testing - QA
[ ] Documentation
[ ] Release notes - resolved issues, compatibility, known issues
[ ] Code committed to upstream release/hotfix branches
[ ] Documentation committed to upstream release/hotfix branches

This issue also resets the timeout when turning into follower, to not expire an election timeout and let the new leader to settle down.


UCP: Migrate scalar function substring_index from TiDB

Signed-off-by: longfangsong<EMAIL_ADDRESS>UCP: #6955

What problem does this PR solve?
Issue Number: close #6955
Problem Summary: Migrate scalar function substring_index from TiDB
What is changed and how it works?
What's Changed:
Implemented scalar function substring_index
Related changes

PR to update pingcap/docs/pingcap/docs-cn:
PR to update pingcap/tidb-ansible:
Need to cherry-pick to the release branch

Check List
Tests

Unit test

@iosmanthus PTAL

@longfangsong please handle the conflicts 😊

@longfangsong Please handle the conflicts. @zhongzc PTAL.


Apply the same status to every scenario in a feature

Another point that could help is if an entire feature could have the same status added to it in one selection.

Done in https://github.com/wearefriday/gherkin-test-report/pull/6


Introduce Quick Deploy

One way to reduce the size of a Unity-based instant app is to place some assets in an AssetBundle and download that AssetBundle from a loading screen at game startup.
Quick Deploy makes it easier to use AssetBundles in this fashion via two main features:

it simplifies the creation of an AssetBundle from existing scenes
it provides a loading screen that displays progress in downloading the AssetBundle from a server

Here is #38 redone with one extra squash step in between to simplify the merge.
Jake has some good comments in #38, but my suggestion is that we merge this PR as-is and then make any fixes in follow-up PRs.

Sounds good to me!

Woot, this is exciting :)


error when creating new menu item

Laravel Version: 5.3.*
Voyager Version: 0.11.5#
PHP Version: 7
Database Driver & Version: mysql

Description:
ErrorException in VoyagerMenuController.php line 56:
Undefined variable: menuItem
in VoyagerMenuController.php line 56
at HandleExceptions->handleError('8', 'Undefined variable: menuItem', 'C:\xampp\htdocs\voyager53\vendor\tcg\voyager\src\Http\Controllers\VoyagerMenuController.php', '56', array('request' => object(Request), 'data' => array('title' => 'title', 'url' => '/admin/title', 'icon_class' => '', 'color' => '#000000', 'target' => '_self', 'menu_id' => '1', '_token' => 'SC0EYhx5eeR2Y6CjEPzvC8srZnV2HnszRHa8ttxl', 'route' => null, 'parameters' => '', 'order' => '13'), 'highestOrderMenuItem' => object(MenuItem))) in VoyagerMenuController.php line 56
Steps To Reproduce:
always get this error when creating menu item

Please update to the latest version (currently 0.11.7), cause I am not getting this error.

hey @hyugihc,
This is an issue specific to the 0.11.5 release, please update to a later version to solve this,

hey guys, I am currently using dev-master version.
How do you view the exact version you are currently on?
Or do you check out some branch like dev-0.11.7 ?
If so, could you tell me which one?

@marco-solare you can see the version in the dashboard, at the bottom of the page.

thanks dude, might have even seen it before but overlooked/forgotten about it - that was easy ;)


Overlays are inaccessible

Easy (good first issues):

[ ] Use role="dialog".
[ ] Label them with aria-label or aria-labelledby.
[ ] "Invite users" popup does not focus first element.

More difficult:

[ ] Prevent tab and shift + tab from focusing elements in the background, i.e. the focus should wrap around.
[ ] Closing the overlay should return the focus to the previously focused element.
So e.g. opening the drafts with d or the help with ? should remember document.activeElement and closing the overlay should focus it again. For overlays opened with the settings dropdown, changing the focus back should also work (which means opening the settings dropdown with g must already remember the focus and should restore it on Escape, no matter if you close the dropdown without selecting something or if you open the settings and close the overlay).

Fixing these problems is very much appreciated! Just reply to this issue on which part you want to work.
Resources:

https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/dialog_role
https://bitsofco.de/accessible-modal-dialog/
https://alastairc.uk/gists/7340946/PopOvers-Content.html

[ ]  "Invite users" popup does not focus first element.
I would like to work on this part.

I've made the emails field focus on opening the invite users window. But what is to be done after the user clicks the invite button?

If the data is valid, focus on the emails field or focus nowhere?
If data is invalid, focus on the emails field or focus on the field which is invalid?

I don't think we need to change the focus after submitting the form. Another accessibility problem I however just noticed is that we are forcing keyboard users to tab through every stream checkbox to reach the Invite button. We should instead support submitting the form by pressing Ctrl+Enter (like we do for compose).
I also just noticed a bug: Open the compose box and then the Invite more users popup. If you now click on Check all or Uncheck all the compose box textarea is focused (and you can type there).

I've done Ctrl+Enter to submit part. One thing I noticed is that after the form is submitted, it does not scroll up to the top of the window. Is this to be done too? (Since this would directly show any error/success alerts which appear at the top after submitting, without the need to scroll)

Good catch, that's indeed a UX problem. We don't want to just scroll without changing focus though (because then the focused element can be out of view), so I now like your initial proposal, i.e. after submitting the form we scroll to the top of the modal (so that you can see the success or error message) and focus the email input, assuming it is the only input that can lead to errors (so that you can invite more users or correct an error).

@zulipbot claim

@sumit-kushwah which part of this issue do you want to work on?

[ ]  Use role="dialog".

Hello, I can try to fix this if you can direct me to the file that needs fixing.

@zulipbot claim

@Gittenburg Hi I want to work on the easy part I'm a beginner and I want to contribute I just don't know which file to modify

A good way to find the source code for some frontend element is to right-click on the element in your browser and choose Inspect in the context menu. Then in the inspector of the developer console look around the HTML for some unique id or class and then do a git grep "whatyoufound" in the cloned repository.

Since we want to add the role="dialog" and aria-label to all overlays, it however probably makes more sense to do this in the open_overlay function in static/js/overlays.js, instead of editing each handlebars template individually.

so basically what I have to do is opts.overlay.attr("role","dialog") and opts.overlay.attr("aria-labe") I want to test my code

Yeah, that would work for role=dialog. The label however should be set to something descriptive. I initially thought we could just use opts.name for this but just realized that this wouldn't be ideal since it isn't translated and aria-label should be translated for non-English users. (In the Handlebars templates the translation is done with the t function e.g. {{t 'Streams' }}).
So I guess the simplest way is to manually add role=dialog and arial-label={{t 'whatever the title is'}} to our nine overlays (which you can find with git grep data-overlay=). For consistency I think it makes sense to always add both attributes to the div that has the data-overlay attribute.

Actually I think we should prefer aria-labelledby as shown on MDN (for this you will need to add ids to the h1 tags in the overlays.

okay got you so one example would be aria-labelledby={{t 'Drafts' }}, I assigned it the value in h1 and add the attribute
id={{t 'Drafts' }} to h1

No the ids shouldn't be translated (since they are never shown to users). An example would be:

{{t 'Drafts'}}

@Gittenburg  can you review if I need to add anything

@Gittenburg I would like to work on this issue  Label them with aria-label or aria-labelledby.  Please guide me if this is not fixed already.

Hey @Gittenburg is the role=dialog issue fixed? If not I would like to collaborate with @tareq12345 on this.

I think @tareq12345 is already doing both of these in the PR #16471, and there is not much room for collaboration there, so you should probably take on some other issue.


App logs not being aggregated when scheduler is k8s

When using k8s as the scheduler, one can use docker logs to observe that an example app is writing log messages, but these same messages aren't visible via deis logs.  Application events written by deis-controller do show up, but that's it.  My best guess is that deis-logspout is somehow not forwarding logs from such containers.

Possibly related to #3633

I'm no longer thinking this is technically related to k8s, but I do think it's a problem of scale.  I'll close this and move further discussion ot #3633


Bind missing namespaces to host

What type of PR is this?
/kind bug
What this PR does / why we need it:
We now bind all namespaces, independently if unshared or not. If a namespace is not being unshared, then we fallback to the host.
Which issue(s) this PR fixes:

Required for https://github.com/cri-o/cri-o/pull/6590
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?

Fixed pinning all namespaces to the host when not selected for unsharing in `conmonrs pause`

@haircommander @rphillips PTAL

/lgtm


Switch to rest_for_one on application supervisor

Because the SSHConsole depends on the network being properly set up, if NetworkManager were to get into an inconsistent state, crash, and restart, we'd also want SSHConsole to restart.
I don't feel strongly about this change because in reality, the underlying OS is maintaining some state outside of these GenServers and they communicate via SystemRegistry, so it would likely be fine to leave them in one_for_one mode.

Looking through SSHConsole, it doesn't bind to any network interface. It should work fine regardless of what NetworkManager does.
@ConnorRigby What SSH issue are you referring to? The two that I'm aware of are that a DoS attack on SSH can exceed the :ssh application's supervisor restart intensity and cause the app to crash. Shoehorn can work around that. The other one is more of an annoyance of having to use ~. to exit ssh sessions.

@fhunleth the DoS issue is what i was thinking of. I've noticed it works great without networking being started and never noticed it crash.

Yeah, let’s just not make this change for now.


Multiple elements with same id when spec referenced 3 ways

Given:
<pre class='metadata'>
Title: Your Spec Title
Shortname: your-spec
Level: 1
Status: w3c/UD
Group: WGNAMEORWHATEVER
URL: http://example.com/url-this-spec-will-live-at
Editor: Your Name, Your Company http://example.com/your-company<EMAIL_ADDRESS>http://example.com/your-personal-website
Abstract: A short description of your spec, one or two sentences.
</pre>

Introduction {#intro}
=====================

[[REPORTING]]

[[REPORTING#try-delivery]]

[=report/url=]

Bikeshed gives the warning:
WARNING: Multiple elements have the same ID 'biblio-reporting'.
Deduping, but this ID may not be stable across revisions.

Removing any of the 3 ways of referring to the reporting spec eliminates the warning.

....huh. Reproduced locally, but this is sure a head-scratcher at first. It's generating two identical biblio entries, but more importantly, how in the hell is it only doing so when given all three, but any two doesn't cause this? I'll dig into this.

Logging some details for Monday Tab to deal with:

I only get a duped URL ref (found by dedupBiblioReferences) when both the biblio and section links are present
Biblio and section links are generating a REPORTING-1 key in normativeRefs, the autolink is generating a REPORTING key

I thought you'd enjoy that symptom.

On their own:

biblio link generates a "REPORTING" informative ref
section link generates a "reporting-1" normative ref
autolink generates a "reporting-1" normative ref

(all have the same url; "REPORTING" is from SpecRef while "reporting-1" is from Shepherd)
Two at a time:

biblio + section => "reporting-1" normative, "REPORTING" informative, duped "shepherd + specref" url detected
biblio + autolink => "REPORTING" normative, "REPORTING" informative, no duped url detected (both either a shepherd or specref reference)
section + autolink => "reporting-1" normative, "REPORTING" informative, duped "shepherd + specref" url detected

All three:

"REPORTING" and "reporting-1" normative, "REPORTING" informative, duped url detected, and two entries in the index

So biblio will always get from SpecRef if possible. Autolink gets its linking data from Shepherd, but then fetches a biblio ref according to the dfn's spec name; this can potentially get either but uses the same "prefer SpecRef when possible" rules. But it looks like section autolinks always just use Shepherd data, presumably since I'm drawing the heading data from Shepherd as well.
I think I should make section autolinks fetch the biblio ref in the same way as normal autolinks.

And yup, that did it, and it fixes a persistent issue I've seen where the same spec shows up twice in the refs.


Add missing alt tag to all images

Hey , I came across this issue and would love to work on it.
Could you confirm if it's still open? If available, could you please assign it to me?

Hello @Virtual4087,
I would like to work on this issue, can you please assign it to me.
It will be helpful for my academics.


cut v2.2.0

What this PR does:

[CHANGE] Removed config.storage.engine and any reference of it #488
[ENHANCEMENT] Add appProtocol field to templates/svc-memberlist-headless.yaml to fix issues wirth Istio #485
[ENHANCEMENT] Add option to autoscale on multiple metrics and custom metrics metrics #467
[ENHANCEMENT] Add control on store-gateway statefulset when autoscale (HPA) enabled or disabled #472
[DEPENDENCY] Update quay.io/cortexproject/cortex Docker tag to v1.15.0 #453
[DEPENDENCY] Update quay.io/cortexproject/cortex Docker tag to v1.15.1 #456
[DEPENDENCY] Update quay.io/cortexproject/cortex Docker tag to v1.15.2 #459
[DEPENDENCY] Update quay.io/cortexproject/cortex Docker tag to v1.15.3 #471
[DEPENDENCY] Update quay.io/cortexproject/cortex Docker tag to v1.16.0 #489
[BUGFIX] Correctly interpret .Capabilities.KubeVersion when it looks like a prerelease #457
[BUGFIX] Removed non-existent purger.enable flags in some components #488
[BUGFIX] Fix podTargetLabels in all Prometheus ServiceMonitor CRDs #487

Checklist

[x] CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Hey folks, I think it's a good time to cut v2.2.0 as it's almost a year since our last release. Was thinking I could open an issue to ask for it or make a similar one like v2.1.0 which I did here.
Here are the steps I took:

Updated Chart.yaml/CHANGELOG.md/README.md
Ran helm package, move the compressed chart to docs directory and ran helm repo index there
I assume the last step would be cutting the release manually with a new tag

Other notes:

Please feel free to close/update this PR if it's not the right release process we are doing
Do/should we have a plan for quarterly or yearly release? Just for small patches like image tag updates

I think you packaged the content helm package... before updating the README.md right?  I'm getting sha256sum mismatch when trying to hash my archive against yours @locmai.
Can you just rerun helm package -u . again?

Thank you @nschad !


Remove dependencies to rand and rand_macros

rand_macros won't be available for Rust 1.0 and seems to break twice a week. I propose to just remove these trait implementations.

Oh, benches are using the traits.

For nalgebra I opted to implement Rand manually and to depend on rand. I think this is pretty useful functionality for some testing setups and the rand crate itself should be stable. Of course, it is a bit more work.

Let's implement them manually.

Merged with #188


neovim python rplugins @property and @.setter issue in :UpdateRemotePlugins command

nvim --version:

NVIM v0.2.2
Build type: Release
LuaJIT 2.0.5
Compilation: /usr/local/Homebrew/Library/Homebrew/shims/super/clang -Wconversion -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1 -DNVIM_MSGPACK_HAS_FLOAT32 -DNVIM_UNIBI_HAS_VAR_FROM -DNDEBUG -DMIN_LOG_LEVEL=3 -Wall -Wextra -pedantic -Wno-unused-parameter -Wstrict-prototypes -std=gnu99 -Wimplicit-fallthrough -Wvla -fstack-protector-strong -fdiagnostics-color=auto -DINCLUDE_GENERATED_DECLARATIONS -I/tmp/neovim-20180209-66903-ukwirj/neovim-0.2.2/build/config -I/tmp/neovim-20180209-66903-ukwirj/neovim-0.2.2/src -I/usr/local/include -I/usr/local/include -I/usr/local/include -I/usr/local/include -I/usr/local/include -I/usr/local/include -I/usr/local/opt/gettext/include -I/usr/include -I/tmp/neovim-20180209-66903-ukwirj/neovim-0.2.2/build/src/nvim/auto -I/tmp/neovim-20180209-66903-ukwirj/neovim-0.2.2/build/include
Compiled by<EMAIL_ADDRESS>
Features: +acl +iconv +jemalloc +tui
See ":help feature-compile"

   system vimrc file: "$VIM/sysinit.vim"
  fall-back for $VIM: "/usr/local/Cellar/neovim/0.2.2_1/share/nvim"

Run :checkhealth for more info

Vim (version: ) behaves differently? neovim only (rplugin)
Operating system/version: Debian (Ubuntu) and Darwin (Mac OSX)
Terminal name/version: (None (vimr, nyaovim), Tmux, iTerm2 and mac Terminal)
$TERM: screen-256color

Steps to reproduce using nvim -u NORC
I have an example rplugin (python3) with a nose2 test script
version with @property decorators diffed against version without.  Version with will not be updated by :UpdateRemotePlugins while version without imports fine:
f17f705e3b6f68abe7507465a8fffcd4 diff against bb4e74460f26a5eb91436a174d074d2c703e2db2

I believe I just found another plugin which causes the same bug: chromatica.vim .
Is a fix still being worked on?


Invalid Address for token allocations if wallet is disconnected

@christopherdancy I have looked this I believe this might have been because you needed to set your fallback api keys. Closing this issue


[website] Update sponsor grid

[X] I have followed (at least) the PR section of the contributing guide.

Removing IPinfo.AI as requested.

Does any of you have any idea what to do given the test_browser-1 test is failing? 🤔

@danilo-leal it should be fine after updating with latest master.


Phaser 3.54 draw offset layer

Version

Phaser Version: 3.54.0
Operating system: Windows
Browser: Chrome

Description
TileWidth = 62, TileHeight  = 31
White grid layer is the tilemap layer area.
Phaser 3.54 draw isometric map offset of tilemap layer position.
Example Test Code

Thanks for opening this issue, and for submitting a PR to fix it. We have merged your PR into the master branch and attributed the work to you in the Change Log. If you need to tweak the code for whatever reason please submit a new PR.

Hi @moJiXiang, how to show correct the position of tilemap in Scene canvas?

@danh121097 I think @photonstorm link to the change log is not yet updated because the change was merged to the to-be-released 3.60 branch. The change log for the latest 3.60 is https://github.com/photonstorm/phaser/releases/tag/v3.60.0-beta.10. You can try it out the beta release at npm i<EMAIL_ADDRESS>When loading tilesets you will be able to use the tileoffset parameter.


Get LatLong with street address and number

How to get Latitude and Longitude using street address and house number?
i.g.: Address: Rua Doutor Aluízio França - 709 - Bigorrilho, Curitiba - PR
return LatLong(-25.4254644, -49.3083217)

You can use this api for that https://nominatim.org/release-docs/develop/api/Search/

use can use this library :
https://pub.dev/packages/osm_nominatim
to convert adr to LatLng

Thanks @suvindran3 and @liodali , I will verify this options.


Setup a performance test suite

This gem does a lot of metaprogramming by adding methods and scopes to a base ActiveRecord model.
The goal of this suite would be to test the amount of overhead added to base ActiveRecord as we add more features.
Not critical, but would be nice to have as an objective yardstick.

I really think we need a performance test suite. I am using jsonb_accessor and am finding my AR object instantiation is dog slow (over 10x slower). I love the functionality but I've had to rip it out due to the performance.

Hey @blizkreeg. If you could provide the specific use case that would be great. We're currently looking at implementing #36 and #37 as well as a bigger change which came from investigation on #30. If you could provide a base case for us to test before and after it would be helpful.

hey @jhirn, PR https://github.com/devmynd/jsonb_accessor/pull/37 was exactly my finding and I was going to open a similar PR myself. The base case is really simple - a model with a dozen or so attributes. Instantiate/find a model. When you're reading dozens or hundreds of records from the database, this instantiation from db is the biggest hit. Each individual object instantiation takes up to 300-400ms, which is just extremely slow. A huge part of it is spend in the type lookup code fixed in the PR above.

@blizkreeg have a look at #44. Running that test against #37 shows no improvement in run time. In fact it is a bit slower, but still 2 orders magnitude.
Just curious if you were thinking of something else for your PR or if something like #37 speeds up some other slow aspect of jsonb_accessor.

There is now the beginning of a performance test suite in master, along with a simple test that should be greatly improved.
I'm closing this issue (as it is now setup) but work remains to actually speed up jsonb_accessor.

I can confirm that this gem added a huge overhead to queries on a model containing many jsonb fields. We had to rip out the gem and replace with a bit of our own code.


Fixed import of toKebabCase helper function

What is the purpose of this pull request?

[ ] New Icon
[ ] Bug fix
[ ] New Feature
[ ] Documentation update
[x] Other:

Description

There were comments in multiple files asking to import the 'toKebabCase' helper function instead of redefining the function everywhere. So, fixed the import statements in all such instances and removed the existing comments asking for this to be done. Overall, not a feature or a bug fix, just some code cleanup.
Before Submitting

[x] I've read the Contribution Guidelines.
[x] I've checked if there was an existing PR that solves the same issue.

@ericfennis Ok got it! I'll work on it!
Thanks @jguddas


JSON Output Improvements

[x] Use Event Names in Event Sink
[x] Add UDID to FBSimulator JSON.
[x] Add runtime validation of objects that poport to be JSON serializable to prevent exception throwing
[x] Fix busted JSON Serialization
[x] Report Errors in JSON
[x] Redirect stderr to stdout with logger events in JSON.
[x] Replace Writer in a Runner with an EventReporter.
[x] Remove SuccessFailureWriter
[x] Simplify Event Reporting via Extensions on EventReporter bridging to EventReporterSubject
[x] Create a JSON enum that conforms to FBJSONDescribeable, so that Swift-expressed values get the benefit of strong-typing.
[x] Timestamp all the things.

@facebook-github-bot shipit


Consider "Skeet" and "Reskeet"

I’m sure it’s challenging to come up with brand-exclusive recognizable terms for things that exist on other platforms, but please consider “skeet”. Users frequently mention enjoyment of this term; I’ve yet to see a skeet in opposition of the name
I humbly suggest that there is no real need to use generic terms and that simply using "skeet" and "reskeet" would be much more popular.
/

Please stop


when entering field not from choices getting 503 Internal Server Error

implemented model as such:
class MyModel(BaseModel):
    type = ndb.StringProperty(choices=['Plumber', 'Cleaner'])

...

    @MyModel.method(request_fields=('name' , 'type'),
                    path='professional',
                    name='professional.add')
    def addProfessional(self, pro):
        pro.put()
        return pro

when entering type="myumyu" getting:
{
 "error": {
  "code": 503,
  "errors": [
   {
    "domain": "global",
    "message": "Internal Server Error",
    "reason": "backendError"
   }
  ],
  "message": "Internal Server Error"
 }
}

also in the API explorer i don't get a dropdown menu for selecting from the choices.
I also can't validate this myself because it crashes before it gets to my handler.
what would be ideal is for the api to say type must be from ['Plumber', 'Cleaner'] or something like that.

You should use a protorpc Enum via ndb.msgprop.
from protorpc import messages
from google.appengine.ext.ndb import msgprop

from endpoints_proto_datastore.ndb import EndpointsModel

class Type(messages.Enum):
  PLUMBER = 1
  CLEANER = 2

class MyModel(EndpointsModel):
  type = msgprop.EnumProperty(Type, required=True)

...

This produces the following schema in the discovery document:
  "MyModelFoo": {
   "id": "MyModelFoo",
   "type": "object",
   "properties": {
    "id": {
     "type": "string",
     "format": "int64"
    },
    "type": {
     "type": "string",
     "enum": [
      "CLEANER",
      "PLUMBER"
     ],
     "enumDescriptions": [
      "",
      ""
     ]
    }
   }
  }

Though for some reason the APIs explorer doesn't give a dropdown.

@matantsu I'm closing this out because I think this answer accomplishes what you need.
Please re-open if you have remaining questions.

thanks ! that works , although it misses the point of having the choices parameter...
why bother with it if it's not used ?

Well it is used, both by the backend and by most clients. Just not by the
APIs explorer
Danny Hermes
On Feb 1, 2015 10:43 AM, "Matan Tsuberi"<EMAIL_ADDRESS>wrote:

thanks ! that works , although it misses the point of having the choices
parameter...
why bother with it if it's not used ?
—
Reply to this email directly or view it on GitHub
https://github.com/GoogleCloudPlatform/endpoints-proto-datastore/issues/124#issuecomment-72377514
.


Blur Filter problem on latest dev version.

The slots example isn't working with the latest development version.
https://pixijs.io/examples/?v=dev#/demos-advanced/slots.js
v5.3.0 works fine.
Seems to be a problem with the blur being applied to the reel.

@SukantPal This is probably related to #6683. That build produces the error and is the earliest thing after 5.3.0.
https://pixijs.io/examples/?v=fix/projection-system#/demos-advanced/slots.js
Would you mind debugging this?


[R24.12] DCM KIT: Glossary Content

Description
Add additional explanation of DCM Standard content to the DCM KIT,
To be able to provide additional content around the DCM standard to enable a better understanding of the standard content for new adopters of the DCM Use Case and providing guidelines to apply the DCM standards.
Focus will also be to illustrate various topics to make the standard more touchable and attracting for new adopters.
A glossary or list of terms commonly used for the use case DCM can foster the fast adoption of the standards, if widely spread among all interested and involved partners.
Common terminology allows business partners to improve communication around the DCM use case and it facilitates direct collaboration and quick issue resolution.
Terms were collected during the Catena-X consortium period (08.2021 - 07.2024) and published in the CX-0128 DCM standard documents. The latest standard version (v.2.0.0 - Rel. 24.05) has been used as a basis for enhancements.
Tile for chapter DCM Glossary will be added in the DCM KIT within the Adoption View.
Impact
No impact or dependencies to other components or teams.
Additional information

[ ] Check handover documents regarding Glossary
[ ] Prepare Glossary chapter for DCM KIT
[ ] Finalize Glossary chapter for DCM KIT
[ ] Initial PR
[ ] Final PR

Risk: Rare deep Technical Git-Hub Knowledge in the group to run the PR properly

Presented in the DRAFT Feature Freeze -> Committer needed

By integrating a glossary into the KIT all existing KIT content needs be be srcraped and changed to fully utilize the glossary.
Integrate into: https://github.com/eclipse-tractusx/eclipse-tractusx.github.io/tree/main/docs-kits/kits/DCM-Kit/ as glossary.md

Hi Lukas, I cannot assign myself - please consider me as Assignee (let's solve the tech problem later...)

Happy to support :-)

Work in progress here: https://github.com/catenax-eV/cx-ex-dcm/tree/main/PI-14/[R24.12] DCM KIT Glossary Content

Hallo @LukasSchmetz und @Frank-Globisch , habt ihr Zeit nächster Woche 1 Stunde über die Feature zu sprechen?
Mögliche Zeitslots:

20.8. ab 14:30 Uhr
21.8.  jederzeit ausser 9-10 und 15-15:30 Uhr
22.8. zw 10 und 11:30 Uhr oder zw. 13 und 15:30 Uhr
bis bald!! LG, Stefania

Hi @lanfrans, schön, dass du zurück bist :) Mittwoch Nachmittag oder Donnerstag (egal ob der vor- oder nachmittags) würde bei mir passen.
@Frank-Globisch  ist wieder da ab nächster Woche
@ClosedSourcerer  noch eine Woche im Urlaub.

Hi @Frank-Globisch and @ClosedSourcerer , do you have some time (max 60 Min)  on 18.9. or 19.9. to finalize some things re: glossary?

Hi @Frank-Globisch and @ClosedSourcerer , do you have some time (max 60 Min) on 18.9. or 19.9. to finalize some things re: glossary?

19.09.2024 between 09:00 and 11:00 would suit me fine

Hi @ClosedSourcerer , please check if the .md file for DCM glossary has been uploaded correctly. Thanks! https://github.com/catenax-eV/cx-ex-dcm/tree/main/PI-14/[R24.12] DCM KIT Glossary Content and https://github.com/ClosedSourcerer/eclipse-tractusx.github.io/tree/DCM-KIT-Glossary-Content

I added a header, renamed the file and integrated it into the sidebar. Content itself seems fine.


icon request

BGMI (pubg) : https://play.google.com/store/apps/details?id=com.pubg.imobile
PhonePe : https://play.google.com/store/apps/details?id=com.phonepe.app
Download Navi - Download Manager : https://play.google.com/store/apps/details?id=com.tachibana.downloader
zArchiver : https://play.google.com/store/apps/details?id=ru.zdevs.zarchiver
gcams : com.google.android.GoogleCamerb , com.GoogleCamera.Burial31, com.GoogleCamera.Burial10 , com.agc.cam

Hello! Weʼre switching to a new system for icon requests in order to be able to better manage them. From now on, icon requests can be submitted here: https://forms.gle/Fx8vZAiWdW1Tyjo57. If your icon request hasnʼt yet been fulfiled, it has been copied to our new icon request database, meaning no action is required. Consequently, this issue will be closed.


dev-docs: Add GPUTable roadmap

For #3758

Background

GPUTable roadmap

Change List

Will be rebased on top of #3818 before landing, should only contain gpu-table-roadmap.md

Coverage remained the same at 80.17% when pulling c4c35ccce8a49e621c7c313382dd50a7f9c6f252 on ib/gpu-table-roadmap into 49d53eadb77889a1b662457f09f9cb0204f020e1 on master.


Update the remaining custom icons with FontAwesome counterparts

This issue is imported from pivotal - Originaly created at Aug 1, 2018 by Michiel Kodde
In #158719730, most of the icons used in the material theme have been substituted with their FontAwesome counterparts. Some icons have been left out of this change, as these icons seemed custom made.
These icons are (also see screenshot):

burger.svg (shown on most screens when viewport is very small)
search.svg (shown on WAYF in the search bar)
spinner.svg (shown on the 'POST' screens)
user.svg (no longer in use?)

These icons could be changed out for their FA counterparts, but this might upset the designers of the screens these icons are used on. How should we go about this? Please discuss in the comment section below!

(Michiel Kodde - Aug 1, 2018)

@arnoutt  (Thijs Kinkhorst - Dec 10, 2018)

First of all, I _assume_ there is some gain in replacing the icons by FontAwesome. If there is, then my suggestion would be to indeed replace them, using the following:

burger.svg -> whichever is used elsewhere (bars?)
search.svg -> search
spinner.svg -> I'm not sure whether this one can be replaced by FA? Any suggestions/examples?
user.svg -> Could this one be used on the groups consent page? If found somewhere, replace with user-tag (Arnout Terpstra - Dec 10, 2018)


Cross compile erlang

Description of changes
This, building on top of NixOS/nixpkgs#100835, builds a minimal erlang for the build platform as an input for the cross-compiled erlang. Still need to get the rest of this bootstrap OTP into the path for the rest of the build system to find, as some utilities are not installed by default.

Things done
Tested with nix build .#pkgsCross.aarch64-multiplatform.beam.packages.erlangR25.erlang. Build completes, but I have no ARM machines to test with.

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

There was a review comment about setting an assert so that enableHipe isn't set on cross-compiles. I think that'd be too disruptive because it would require everyone doing this to make an overlay or something to override the default value of enableHipe on every version of Erlang. The whole purpose of Hipe (as best I can tell) is to speed up compilation when you have are doing a native-arch compile, so it makes sense for it to be disabled automatically.

could you ping me again once this is tested ?
Also, just in case if @DianaOlympos has some time to help testing.

I sadly do not have an arm machine but i may try to recruit a mac owner

@IslandUsurper honestly i would just disable hipe, it is not supported on OTP24+ anymore anyway. And we will drop OTP 23 soon. So let's not deal with it.

What's the nixpkgs policy on removing Erlang versions? Just whatever the last 5 versions of Elixir need?

@IslandUsurper we only support the last 3 versions modulo 4 versions if the latest OTP was "just released", like right now. So rn, we would support 23, 24, 25 and add 26. And we would probably drop 23 after the next nixos release.

Updated with suggestions.

Please follow the contributing guide when naming your commits.
For this PR, this likely means to just squash everything into one commit.
Are you done with the testing?

I have an M3 mac, I'm happy to help with testing anything.

Building on mac yields:
… while evaluating attribute 'buildInputs' of derivation 'erlang-25.3-aarch64-unknown-linux-gnu'
/.../
error: Package ‘libcap-2.67’ in /nix/store/v5qkgmj239gi06priqj1nfildgp4743v-source/pkgs/os-specific/linux/libcap/default.nix:61 is not available on the requested hostPlatform:
         hostPlatform.config = "aarch64-apple-darwin"
/.../

LMK If I can help with further testing.

ping @IslandUsurper Please fix the merge conflict, and update your PR. Rebasing to master would be ideal.

Please enable strictDeps.

Errors at fixupPhase:

nix build .#pkgsCross.aarch64-multiplatform.beam.packages.erlang_25.erlang

I got a build error with nix build .#pkgsCross.aarch64-multiplatform.beam.packages.erlang_25.erlang involving modemmanager, which comes in from GTK and wxWidgets. But nix build .#pkgsCross.aarch64-multiplatform.erlang_nox built successfully.
Going to test removing zlib  from inputs. Not sure if it used to be required, and dependencies changed in OTP since I started this PR, or what exactly. I'll also test other versions of OTP, and if all looks good I'll squash down the commits.

Oh right. OTP 27 docs are done in exdoc, and we can't cross-compile Elixir yet.

That last commit almost certainly could be done better. I thought splicing meant that we didn't have to use pkgsBuildHost directly when using inputs in different places.
Still can't build ex_doc because something gets messed up in the fixupPhase.

The commit messages are not following nixpkgs guidelines.
It should be:

package-name: xxx

Also, squash the commits per package.

Cross-compile Elixir.
Cross-compile rebar.

Prefer:

elixir: fix cross compilation
rebar: fix cross compilation

Also, lowercase only in all commit titles.

❯ nix build .#pkgsCross.aarch64-multiplatform.beam_nox.packages.erlang_26.ex_doc
error: builder for '/nix/store/gi6ddzqqnjdl7xx08rr3vw14c9fg0x7c-ex_doc-aarch64-unknown-linux-gnu-0.34.1.drv' failed with exit code 127;
       last 10 log lines:
       > Running phase: fixupPhase
       > shrinking RPATHs of ELF executables and libraries in /nix/store/h2yk4pyqsxj7gqn25icy9w8wcqsjvk35-ex_doc-aarch64-unknown-linux-gnu-0.34.1
       > checking for references to /build/ in /nix/store/h2yk4pyqsxj7gqn25icy9w8wcqsjvk35-ex_doc-aarch64-unknown-linux-gnu-0.34.1...
       > patching script interpreter paths in /nix/store/h2yk4pyqsxj7gqn25icy9w8wcqsjvk35-ex_doc-aarch64-unknown-linux-gnu-0.34.1
       > stripping (with command aarch64-unknown-linux-gnu-strip and flags -S -p) in  /nix/store/h2yk4pyqsxj7gqn25icy9w8wcqsjvk35-ex_doc-aarch64-unknown-linux-gnu-0.34.1/bin
       > removing files for Microsoft Windows
       > wrapping programs in /nix/store/h2yk4pyqsxj7gqn25icy9w8wcqsjvk35-ex_doc-aarch64-unknown-linux-gnu-0.34.1/bin with their runtime deps
       > /nix/store/5vnac2x480gx7abw7kb7w5dk0kxj0a6r-erlang-<IP_ADDRESS>-aarch64-unknown-linux-gnu/lib/erlang/bin/../erts-<IP_ADDRESS>/bin/dyn_erl: line 1: ELF��@@@8: not found
       > /nix/store/5vnac2x480gx7abw7kb7w5dk0kxj0a6r-erlang-<IP_ADDRESS>-aarch64-unknown-linux-gnu/lib/erlang/bin/../erts-<IP_ADDRESS>/bin/dyn_erl: line 3: syntax error: unexpected ")"
       > /nix/store/5vnac2x480gx7abw7kb7w5dk0kxj0a6r-erlang-<IP_ADDRESS>-aarch64-unknown-linux-gnu/lib/erlang/bin/.erl-wrapped: exec: line 57: ./erts-<IP_ADDRESS>/bin/erlexec: not found
       For full logs, run 'nix log /nix/store/gi6ddzqqnjdl7xx08rr3vw14c9fg0x7c-ex_doc-aarch64-unknown-linux-gnu-0.34.1.drv'.

Hm. dyn_erl seems to have the right header, but that ) does look odd. I don't know enough about ELF, to really know why it's breaking.

@IslandUsurper
I'm no longer active as a maintainer/commiter at nixpkgs.
Please, add other reviewer for this PR (from git history).
Your PR is valid and will be eventually merged. (After build failure for ex_doc is sorted.)
Sorry about this.

I don't have the permissions to change assignee or reviewers, @superherointj. Guess I'll find a chat room somewhere to bring it up.

I don't have the permissions to change assignee or reviewers, @superherointj. Guess I'll find a chat room somewhere to bring it up.

You can ping people using @.

@wegank or @chiroptical, do either of you have time or energy to review this PR?

@wegank or @chiroptical, do either of you have time or energy to review this PR?

I can try to cross compile to my OSX machine. The code seems fine. I don't have merge privileges so we'll need to find someone to do that assuming this works.

I tried to build from x86_64-linux to aarch64-linux
> nix-build -A pkgsCross.aarch64-multiplatform.beam_minimal.packages.erlang_27
<SNIP>
 GEN    man_index.md
{error,"ERL_TOP environment variable doesn't match the PATH /nix/store/aclb8fi43i91v1ch3vp9ql87zgscqdjy-erlang-27.0/lib/erlang/lib/sasl-4.2.2/ebin/alarm_handler.beam",
       [{otp_man_index,module_path_to_app_vsn,1,
                       [{file,"src/otp_man_index.erl"},{line,80}]},
        {otp_man_index,'-module_table/0-fun-0-',1,
                       [{file,"src/otp_man_index.erl"},{line,55}]},
        {lists,filtermap_1,2,[{file,"lists.erl"},{line,2279}]},
        {otp_man_index,module_table,0,
                       [{file,"src/otp_man_index.erl"},{line,50}]},
        {otp_man_index,gen,1,[{file,"src/otp_man_index.erl"},{line,37}]},
        {init,start_it,1,[]},
        {init,start_em,1,[]},
        {init,do_boot,3,[]}]}{exit,1,[{otp_man_index,gen,1,[{file,"src/otp_man_index.erl"},{line,41}]},{init,start_it,1,[]},{init,start_em,1,[]},{init,do_boot,3,[]}]}
Runtime terminating during boot (1)

Crash dump is being written to: erl_crash.dump...done
make[3]: *** [Makefile:78: man_index.md] Error 1

And for armv7-hf-multiplatform
> nix-build -A pkgsCross.armv7l-hf-multiplatform.beam_minimal.packages.erlang_27
<SNIP>
 GEN    html/index.html
qemu-arm: /nix/store/vwa9v14s5h36zmqk976rfzaaa7npkl4g-erlang-27.0-armv7l-unknown-linux-gnueabihf/lib/erlang/bin/escript: Error mapping file: Operation not permitted
make[5]: *** [/build/source/make/doc.mk:62: html/index.html] Error 255
make[5]: Leaving directory '/build/source/lib/stdlib/doc'
make[4]: *** [/build/source/make/otp_release_targets.mk:41: release_docs] Error 2
make[4]: Leaving directory '/build/source/lib/stdlib/doc'
make[3]: *** [/build/source/make/otp_subdir.mk:29: release_docs] Error 2
make[3]: Leaving directory '/build/source/lib/stdlib'
make[2]: *** [/build/source/make/otp_subdir.mk:29: release_docs] Error 2
make[2]: Leaving directory '/build/source/lib'
make[1]: *** [Makefile:439: release_docs] Error 2
make[1]: Leaving directory '/build/source'
make: *** [Makefile:859: install-docs] Error 2
error: builder for '/nix/store/b1afds9xiqrn5jfxakcn3q3y1lhng0mz-erlang-27.0-armv7l-unknown-linux-gnueabihf.drv' failed with exit code 2;
       last 25 log lines:
       > === Entering application stdlib
       > make[4]: Entering directory '/build/source/lib/stdlib/src'
       > make -j24 --jobserver-auth=fifo:/build/GMfifo50229 RELEASE_PATH="/nix/store/vwa9v14s5h36zmqk976rfzaaa7npkl4g-erlang-27.0-armv7l-unknown-linux-gnueabihf/lib/erlang"   release_docs_spec
       > make[5]: Entering directory '/build/source/lib/stdlib/src'
       > make[5]: warning: -j24 forced in submake: resetting jobserver mode.
       > make[5]: Nothing to be done for 'release_docs_spec'.
       > make[5]: Leaving directory '/build/source/lib/stdlib/src'
       > make[4]: Leaving directory '/build/source/lib/stdlib/src'
       > make[4]: Entering directory '/build/source/lib/stdlib/doc'
       > make -j24 --jobserver-auth=fifo:/build/GMfifo50229 RELEASE_PATH="/nix/store/vwa9v14s5h36zmqk976rfzaaa7npkl4g-erlang-27.0-armv7l-unknown-linux-gnueabihf/lib/erlang"   release_docs_spec
       > make[5]: Entering directory '/build/source/lib/stdlib/doc'
       > make[5]: warning: -j24 forced in submake: resetting jobserver mode.
       >  GEN       html/index.html
       > qemu-arm: /nix/store/vwa9v14s5h36zmqk976rfzaaa7npkl4g-erlang-27.0-armv7l-unknown-linux-gnueabihf/lib/erlang/bin/escript: Error mapping file: Operation not permitted
       > make[5]: *** [/build/source/make/doc.mk:62: html/index.html] Error 255
       > make[5]: Leaving directory '/build/source/lib/stdlib/doc'
       > make[4]: *** [/build/source/make/otp_release_targets.mk:41: release_docs] Error 2
       > make[4]: Leaving directory '/build/source/lib/stdlib/doc'
       > make[3]: *** [/build/source/make/otp_subdir.mk:29: release_docs] Error 2
       > make[3]: Leaving directory '/build/source/lib/stdlib'
       > make[2]: *** [/build/source/make/otp_subdir.mk:29: release_docs] Error 2
       > make[2]: Leaving directory '/build/source/lib'
       > make[1]: *** [Makefile:439: release_docs] Error 2
       > make[1]: Leaving directory '/build/source'
       > make: *** [Makefile:859: install-docs] Error 2
       For full logs, run 'nix log /nix/store/b1afds9xiqrn5jfxakcn3q3y1lhng0mz-erlang-27.0-armv7l-unknown-linux-gnueabihf.drv'.


Addedd Responsive tabs

Resolves #123
Implementation:
https://www.loom.com/share/b3b35d868fe84fa4a7831d5a9eaa4362

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.05%. Comparing base (f910885) to head (190fe14).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #130   +/-   ##
=======================================
  Coverage   99.05%   99.05%
=======================================
  Files          53       53
  Lines        1056     1063    +7
  Branches      286      257   -29
=======================================
+ Hits         1046     1053    +7
  Misses         10       10

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

@asimonok
Ready for review

@vitPinchuk What will happened if saved group will be one of the hidden?
Can we display saved group as first one in the list as a part of this PR or another?

@vitPinchuk What will happened if saved group will be one of the hidden?
Can we display saved group as first one in the list as a part of this PR or another?

I think I can update and add logic to display the saved group as the first one in the list. I can do this in a separate PR, so as not to hold up this PR.


[resources] Mobile view button text missing in lightmode

In light mode on the Resource Center, the button text Search and Sort by select are not visible. On desktop in lightmode the search button text (magnify glass) is also not visible.

@jabby09 raised this with @0xemc - this is addressed with his great work in https://github.com/KlimaDAO/klimadao/pull/882 :D

@0xMakka can you see if this is still reproducible, if not lmk and ill close this

@Atmosfearful the issue looks to be resolved with the search icon, however on light mode the icon is missing from the sort button.

Also the circle button looks to have a different height than width making it look slightly skewed, so I'm happy to address these issues under this ticket? Below is the proposed UI fixes I would be making

Ignore what I mentioned above, I've just noticed on production this is resolved.
@Atmosfearful I reckon this ticket can be closed off. 👍

@0xMakka @Atmosfearful can confirm this is now resolved!


Configure logging using this gem

GOV.UK applications use logstasher to output logs as JSON so they can be shipped to Kibana.
Over the years copy-and-changing has led to a complete circus of different logging configurations.
Here's a list of applications and versions:

Application
Logstasher version

asset-manager
0.4.8

authenticating-proxy
0.6.5

calculators
0.6.5

calendars
1.2.1

collections
0.6.2

collections-publisher
1.2.1

content-performance-manager
1.2.1

content-store
0.5.0

content-tagger
1.2.1

design-principles
0.4.8

email-alert-api
1.2.1

feedback
0.6.2

finder-frontend
0.4.9

frontend
1.1.0

government-frontend
0.6.1

hmrc-manuals-api
0.5.3

imminence
0.4.8

info-frontend
0.6.0

licence-finder
0.6.5

link-checker-api
0.9.0

local-links-manager
0.6.2

manuals-frontend
0.6.2

manuals-publisher
0.4.8

maslow
0.4.8

publisher
1.2.1

publishing-api
0.6.2

release
0.4.8

router-api
0.6.2

service-manual-frontend
0.6.1

service-manual-publisher
1.2.1

short-url-manager
0.5.3

signon
0.4.8

smart-answers
0.4.8

specialist-publisher
0.6.2

static
0.4.8

support
0.4.8

support-api
0.6.2

transition
0.6.5

travel-advice-publisher
0.4.8

whitehall
1.2.1

And the following apps don't use logstasher at all:

bouncer
contacts-admin
email-alert-frontend
policy-publisher
search-admin

This PR adds logstasher as a dependency and sets up an initialiser to set it up correctly. By centralising the config we can get rid of divergent config in different apps and use the same version everywhere.
We're doing this now because we need to bump the logstasher gem in all apps to make it work with log.it. Moving the config into this gem now will make future upgrade processes easier.
Todo

[x] ~Add tests~ it's crazy hard to test this..
[x] Add documentation
[x] Fix logstasher crashing: https://github.com/shadabahmed/logstasher/pull/142
[ ] Test with Rails app & non-Rails apps (bouncer, rummager, email-alert-service)

On bouncer not using logstasher: we didn't make bouncer log requests from the application in the past because we thought it wouldn't add much to what the nginx logs already give us. Upstart logs cover the app being unable to start, and other exceptions should be logged to Sentry. That isn't necessarily still a good reason to not do it, if consistency is more important to us now.

Tested this on https://github.com/alphagov/collections/pull/392.
Blue is STDERR, white STDOUT:

√ Logs JSON to SDTOUT
√ Logs Rails.logger.info to STDERR
√ Logs other cruft to STDERR

Hey @tijmenb. Can this be reviewed, or should it wait until you've ticked off the final item in the todo list ("Test with Rails app & non-Rails apps (bouncer, rummager, email-alert-service)")?

@chrisroos yes! That would be great. I've only been meaning to test it on integration.

I've tried this on integration (via https://github.com/alphagov/collections/pull/392) and it works, data is being sent correctly.

https://kibana.logit.io/app/kibana#/doc/*/filebeat-2017.11.28/log?id=AWAD-GgN14uVNDqnd4Nk&_g=()
@kevindew would you like to review?

Apologies for not making the time to review this, @tijmenb. Good work on getting it merged :-)


New nightly build URL not accessible by Ansible due to SNI

Directions
Ansible fails to install packages from dl.influxdata.com with a security error because it uses SNI. Versions of python prior to 2.7.9 don't support ansible downloads over SNI, and the default in ubuntu is 2.7.6.
I've spent most of today trying to update python versions and trying other alternative fixes without success. I'm hosting the package myself for now, but it would make automating installs much easier in the future if the download domain was hosted over non-SNI SSL.
Is this a possibility?

We currently rely on AWS CloudFront (which uses SNI) for hosting of the dl.influxdata.com domain, so I don't think there's a way to disable it from that side. As a workaround, you can use the S3 links directly (which doesn't use SNI) by prepending s3.amazonaws.com to any link. For example, the nightly DEB package can be found here:
https://s3.amazonaws.com/dl.influxdata.com/influxdb/nightlies/influxdb_nightly_amd64.deb
We will most likely migrate away from CloudFront in the future, but, for now, I'd recommend just using the S3 links directly.

Thanks @rossmcdonald, the direct S3 link works great 👍


Pressing enter when there are no results throws an error

Reproduction steps:

search for something (that hopefully doesn't exist)
see no results
press enter anyway
see error:

Thanks for reporting.  I guess I'll just make it close the dialog.  Sound good?

yeah, I think that matches what I'd expect / I don't think I'd be surprised by that behavior


pjclStatisticalRNG: RangeError: invalid array length

I'm trying to use this library on Firefox ESR, but one of the functions seems to be broken.
<EMAIL_ADDRESS>.then(pjcl => {
  console.info("A random byte:", pjcl.pjclStatisticalRNG(0n, 256n));
  }
).catch(error => {
    console.error(error);
});

RangeError: invalid array length
    pjclSub https://cdn.jsdelivr.net/npm/pjcl@1.0.0/pjcl.js:705
    pjclStatisticalRNG https://cdn.jsdelivr.net/npm/pjcl@1.0.0/pjcl.js:2535
    <anonymous> debugger eval code:3
    promise callback* debugger eval code:2
debugger eval code:6:13

(I get the same error even when downloading the source manually from GitHub; I only use cdnjs above for ease of reproduction.)

Interesting! Thanks for submitting an issue.

PJCL predates ECMAScript2020 and does not use the JavaScript BigInt type.  In PJCL, big integers are encoded as arrays of 24-bit limbs, list significant limb first, as described in section 2.2 of the documentation.  So to compute a statistically random number in the range 0 to 256, you call pjclStatisticalRNG([ ], [256]), where the empty array [ ] encodes the number 0, and the one-limb array [256] encodes the number 256.  By the way, if you had used pjcl-with-argument-checking.js instead of pjcl.js, the encoding error would have been caught by the argument checking performed by the function pjclStatisticalRNG, before the call to pjclSub.

I'm closing this issue but opening two follow-up ones, asking for volunteers to write conversion routines between BigInt encodings and performance comparison tests.


Meta variants

I've added clippy at least in this PR https://github.com/sigp/superstruct/pull/37
I wonder if we could also generate tests via fuzzing (we'd need to decide on semantics for what should work, which might be hard)


Pretrained SPADE on CAOS

Hi @YingdaXia,
I could not find the pretrained weights of Spade for Anomaly Segmentation on CAOS benchmark. Could you please share them?
Thank you

Hi DarioFontanel,
The pretrained weight is in checkpoints/caos/.  Please copy it to spade-caos/checkpoints/caos before use them. If other issues come out, please contact us.
Thanks,
Yingda

Found it, thank you.


Use a separate admin page to show global stats, remove actions stat

Before, Gitea shows the database table stats on the "admin dashboard" page.
It has some problems:

count(*) is quite heavy, if some tables have plenty of records, this admin entry page blocks for long time

Some user had ever reported similar issues that they can't go to their admin page because this entry page causes 500

Some stats like actions is not useful, such table is too big, does it really matter if it contains 1,000,000 rows or 9,999,999 rows?
The translation admin.dashboard.statistic_info is difficult to maintain.

So, this PR uses a separate page to show the stats of some tables, and remove the useful-less stats.

Since actions stat has been removed, I think adding a break label is necessary.

Why?
Since when are template changes breaking?

Yup, a "breaking" label is good. It also affects the prometheus collector output.


cool

duplicate of #4323

duplicate of #4323

I am sorry, but I can copy your content. Whilst in my environment it is not possible. Different topic.


Filter out non-ascii characters Openstack VM names

Description
The accounting data is not sent well to APEL because the VM name has non-ascii characters.

@aidaph, is there any update on this?


Redownload file

Add the ability to redownload a file with COMPLETE status
so that we have something like
fetch.redownload(id);

@duncanokeyo I do not understand your issue clearly. Fetch current behavior: If a file is already downloaded/has a status of COMPLETE, and you enqueue it again with request.setEnqueueAction(EnqueueAction.REPLACE_EXISTING);. The download will start again from the start. Note that is the default behavior.

okay, thanks


Query to monero-site admin

Hello
In website section https://www.getmonero.org/downloads/#cli, is description of feature Pay-for-RPC
As per Monero Dev. Team info,support for this feature dropped more than a year ago:
https://github.com/monero-project/monero/issues/9248
So info on webpage https://www.getmonero.org/downloads/#cli, regarding Pay-for-RPC feature is deprecated and just not deleted on time, or there is other reward model under this feature?
Thanks.

Please change title


Add (choose) a license

Coose a license. Please add a LICENSE.md to the repo.
MIT would be a no brainer given the acknowledgement.

This is fairly important: organizations that choose to use this software in a product are technically unable to comply with the terms of the license, because the MIT license specifically requires that a copy of the license be provided when distributing.  Can this please be addressed?

https://github.com/ruby/vscode-rdbg/commit/27963ffa27bbd283e322fe478bbd4953b576aece


Large file uploads fail through Tornado behind nginx

Large files don't get uploaded at all. They work while in development mode (without websockets) but they fail in production.
The upload bar just stays stuck at 100% and never moves forward:

Trying with smaller files <5 MB or so, works perfectly. Please have a look at my code and see if there's something obvious that stands out to you:
PywebIO code:
def interactive1():
    file_upload_data = pywebio.input.file_upload("Upload Excel File", accept='.xlsx', multiple=False, max_size='50M', required=True)
    pywebio.output.put_success("File Uploaded Successfully")

Here's the relevant parts of my nginx config:
# nginx.conf:

worker_processes auto;
worker_rlimit_nofile 4096;

events {
    worker_connections 4096;
}

http {
    client_max_body_size 100M;
    upstream pywebio_app {
	server my_app:8501;
    }

    server {
        listen 80;
        server_name my.domain;
        client_body_buffer_size 10M;
        location /.well-known/acme-challenge/ {
            root /var/www/certbot;
        }
        location / {
            return 301 https://$host$request_uri;
        }
    }

    server {
        listen 443 ssl;
        server_name my.domain;
        ssl_certificate /etc/letsencrypt/live/my.domain/fullchain.pem;
        ssl_certificate_key /etc/letsencrypt/live/my.domain/privkey.pem;
        include /etc/letsencrypt/options-ssl-nginx.conf;
        ssl_dhparam /etc/letsencrypt/ssl-dhparams.pem;
        proxy_busy_buffers_size 512k;
        proxy_buffers 4 512k;
        proxy_buffer_size 256k;

        location /pywebio {
	    proxy_pass http://pywebio_app;
	    proxy_read_timeout 300s;
	    proxy_send_timeout 300s;
	    proxy_http_version 1.1;
	    proxy_set_header Host $http_host;
	    proxy_set_header Upgrade $http_upgrade;
	    proxy_set_header Connection "upgrade";
        }
    }
}

There's nothing in the logs for either nginx or tornado when this happens.
Environment Information

OS and Version:  Server - Ubuntu 20.04.3 LTS
Browser and Version:  Chrome Version 109.0.5414.75 (Official Build) (64-bit)
Python Version: 3.9.13
PyWebIO Version: 1.7.0

@wang0618 could you suggest any workaround for this? It's quite critical to my workflow. :(

Sorry for the late reply.
Try to increace the max_payload_size parameter in pywebio.start_server(), see doc
If the problem persists, try to use another backend (such as aiohttp, see this) to start the pywebio server.

Sorry for the late reply.
Try to increace the max_payload_size parameter in pywebio.start_server(), see doc
If the problem persists, try to use another backend (such as aiohttp, see this) to start the pywebio server.

Thanks for the response; this is how I'm starting Tornado currently. How can I modify this?
if __name__ == "__main__":
    application = tornado.web.Application([
        (URL_PREFIX_PYWEBIO_CUSTOMAPP, webio_handler(tornado_handlers.handle_customapp, reconnect_timeout=60*60)),
        (URL_PREFIX_PYWEBIO_BUILTINAPP, webio_handler(tornado_handlers.handle_builtinapp, reconnect_timeout=60*60)),
    ])
    application.listen(port=8501, address='<IP_ADDRESS>')
    tornado.ioloop.IOLoop.current().start()

if __name__ == "__main__":
    from pywebio import start_server
    start_server({"index": tornado_handlers.handle_customapp, "builtinapp": tornado_handlers.handle_builtinapp}, port=8501, address='<IP_ADDRESS>', max_payload_size='500MB')

or

if __name__ == "__main__":
    from pywebio.platform.aiohttp import start_server
    start_server({"index": tornado_handlers.handle_customapp, "builtinapp": tornado_handlers.handle_builtinapp}, port=8501, address='<IP_ADDRESS>')

@wang0618 This doesn't work in my case, because my handler function is not the PywebIO function. What my handler functions do is:
def handle_customapp():
	dotted_fn_path = pywebio_battery.get_query('function_path')	## Get function path from URL
	function_to_run = importlib.import_module(dotted_fn_path)	## Import module
	function_to_run()	## Run the Pywebio function

This enables me to run different applications by changing the URL without loading them at the time of starting the server.

I can't see why your handle_customapp() is not a PywebIO function 😂. The code I provide should work.
Anyway, you can try to pass max_buffer_size=500*2**20 to application.listen() to get same effect as start_server(..., max_payload_size='500MB')

Sorry about that, the reason I couldn't use it that way was because I needed Tornado to handle the custom URL parts URL_PREFIX_PYWEBIO_CUSTOMAPP and URL_PREFIX_PYWEBIO_BUILTINAPP.
Pywebio looks for the ?app= URL query and not the URL part. I think I may need to refactor my application to use the URL query instead, then try and see if it works.

After refactoring my app to use query parameter to identify the app and using start_server, the problem has been resolved.
I also had to change the nginx config to add a trailing slash to proxy_pass, so that the URL parts aren't sent to the tornado server.
Thanks a lot @wang0618 for your help. 🙂


Update utils.py

On some usage 'file' object can be left at 'None' which in my case prevents Flask to start correctly.

I don't understand this change. file can indeed be omitted from the call, in which case it defaults to stdout. This is not an issue.


Fix Terraform issues with v1.1.x

Hi all,
@c0dyhi11
When running the terraform on a baremetal cloud env, I get the following error:
│ Error: file provisioner error
│
│   with module.PNAP_Infra[0].null_resource.node_networking_cp[1],
│   on modules/phoenixnap/main.tf line 87, in resource "null_resource" "node_networking_cp":
│   87:   provisioner "file" {
│
│ Upload failed: scp: $HOME/bootstrap: No such file or directory

Reproduction steps:

create a terraform.tfvars file with the required parameters (including client id/secret)
gcloud auth application-default login
terraform init, plan, apply creates the control plane and worker nodes but fails to complete the deployment with the error shown above.

This issue only shows up with Terraform newer than v1.0.x We need to make this repo work with the latest version of terraform.

destination - (Required) This is the destination path. It must be specified as an absolute path.
https://www.terraform.io/language/resources/provisioners/file#:~:text=destination - (Required) This is the destination path. It must be specified as an absolute path.


CDS-78790 Automation with the Terraform Provider

https://harness.atlassian.net/browse/CDS-78790
Harness Developer Pull Request
Thanks for helping us make the Developer Hub better. The PR will be looked at
by the maintainers.
What Type of PR is This?

[x ] Issue
[ ] Feature
[ ] Maintenance/Chore

If tied to an Issue, list the Issue(s) here:

https://harness.atlassian.net/browse/CDS-78790

House Keeping
Some items to keep track of. Screen shots of changes are optional but would help the maintainers review quicker.

[ ] Tested Locally
[ ] Optional Screen Shoot.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app


Internal Server Error / Runtime.ExitError

I cannot get this to work whatsoever, and because of a lack of logs I don't know where it's going wrong.
I have a Laravel project that I want to deploy using the CDK like this:
this.backend = new PhpFpmFunction(this, `Backend-${STAGE}`, {
            handler: 'public/index.php',
            code: packagePhpCode('code/backend'),
            phpVersion: '8.3',
            vpc: props.vpc
}

It all deploys fine, but when visiting the resulting URL, I get an Internal Server Error, with the CloudWatch containins only this:
INIT_REPORT Init Duration: 404.55 ms	Phase: invoke	Status: error	Error Type: Runtime.ExitError
START RequestId: dc4f6c9f-eee8-44d2-82ea-317cda3ac07b Version: $LATEST
RequestId: dc4f6c9f-eee8-44d2-82ea-317cda3ac07b Error: Runtime exited with error: exit status 255 Runtime.ExitError

No further useful info at all.
I tried debugging locally using docker and found out the same Runtime.ExitError happened there, which was due to not having bref/bref and bref/laravel-bridge installed.
However, after installing, the error went away locally, but it still happens on Lambda after redeploying.
I did notice that when I download the code from lambda, the vendor directory only contains aws/ and autoload.php, not any of the dependencies. If I run locally on docker with only these present, I also get a Runtime.ExitError.

It seems that missing packages in vendor are indeed the problem; something causes packagePhpCode to not include anything other than vendor/aws and vendor/autoload.php.
After manually zipping and using lambda.Code.fromAsset, the lambda includes all packages in vendor and it works.

It seems to still not work perfectly, the invocation itself succeeds now, but I'm getting a 500 internal server error response on any path. CloudFront now looks like this:
REPORT RequestId: 9902b69e-2126-4df7-89f9-e7f3603debab	Duration: 1.77 ms	Billed Duration: 2 ms	Memory Size: 1024 MB	Max Memory Used: 89 MB
START RequestId: 5887e595-a18e-4193-9563-0441d6d35083 Version: $LATEST
[AWS Parameters and Secrets Lambda Extension] 2024/03/04 03:02:03 INFO ready to serve traffic
END RequestId: 5887e595-a18e-4193-9563-0441d6d35083

with no output from PHP or Laravel at all.


Feature request: Screen Sharing

Love what you're doing here!!
I'd like to request a feature: screen sharing, something like muaz-khan has acchieved, would be super useful feature :)
I hope I am able to contribute in your repo soon-ish, but a bit busy ATM.
You can ping me at GUN discord/gitter tho :)
BR,
Jabis

Hi Jabis,
this is definitely something that possible and we will consider implementing it when we expand the features.
Thanks for the request.

Thanks @jabis ! Any contribution is super welcome and being this based off standard webrtc demos, it should be quite easy to import features such as muazkhan's demos. Happy to help you whenever you want to give this a try!


Reimagine the time-of-day driver

Motivation
I don't like the time-of-day driver:

It's writing uninteresting data constantly to redis.
It's difficult, to impossible, to reliably get a logic block to work if it needs more than one time-of-day field

To illustrate the second point: I want a light to be on after 5:30 pm. With the tod driver, the logic block has to monitor the minute and hour devices. Those devices' values currently need to be read from different channels. When the time goes from 5:59 to 6:00, it could be that the minute's channel changes from 59 to 00 first, which means the logic block will perform calculations for 5:00pm and turn off the light and then immediately get the hour update yielding 6:00 and turn them on again. The users would see this as the lights briefly changing at the wrong time.
The time-of-day should be removed as a driver and, instead, be made an async task that posts the time-of-day to a broadcast channel. Logic blocks can use the channel, if they need time-of-day.
Tasks

[x] Delete tod driver
[x] Before initializing any drivers or logic blocks, create a time-of-day task (or tasks if we decide local and UTC time can't be supported in the same task.) A broadcast::Receiver<> handle will receive once-a-second updates.
[x] When logic blocks are initialized, they are passed a clone of the Receiver<> handle.

The expressions in the logic block will determine whether the handle is used or dropped.

[x] Once all logic blocks are initialized, the original Receiver<> is dropped.

If all logic blocks dropped the handle, then the time-of-day will recognize there are no clients and can terminate itself.

Logic blocks:

[ ] need to have a notation added to their grammar to refer to these time values.
[ ] need to recognize when time is required for them and save the receive handle
[ ] need to know how to access the time values when a new value is generated (1 Hz)

These are a few ideas as to how we refer to time in logic block expressions.
Treat as Devices
We could leave the grammar alone and, instead, have specially named devices to refer to the time values. For instance, seconds in UTC time could be a utc:second device name. The user would add all the required time devices to the inputs map and the expression handler would just work. There would be some work in knowing how to access the time devices. All the time values, UTC and local, arrive in one message so all the fields change at once. If an expression uses more than one time field, it should only update the expression once (since all the fields have already changed) and it should see the new values of all the field in its calculation.
Add Grammar Syntax

We could add some syntax to the grammar. Expressions can only have simple identifers from the inputs map, so there are no device names in the expressions. This allows us to use the device notation for time values: utc:second or local:hour, for example.
We could use a function notation: second(UTC) or hour(LOCAL).
We could use method notation: utc.second() or local.hour().
Maybe a "substitution" notation: $UTC_SECOND$ or $LOCAL_HOUR$.
We already use curly braces to substitute inputs. Maybe combine this with the first option: {utc:second} or {local:hour}, for example.

Any of these would require scanning expressions to see if the receive handle needs to be saved and awaited upon.


Endpoint to retrieve Note field data along with Asset

Problem
See https://github.com/algorandfoundation/ARCs/issues/3. Basic issue is that we need to efficiently store and retrieve the metadata. Having it on-chain has advantages.  But doing separate requests for metadata will mean for example doubling the number of HTTP requests to be able to render a gallery, because the Asset records do not have a place for file type (MIME type).
Solution
When querying the Asset information (or a separate endpoint), the Indexer could also supply the Asset Config transaction which would contain the metadata in the Note field.
Dependencies
Note sure
Urgency
Depends on whether we care about having an efficient system for NFTs, or whether we want to encourage people to put the MIME type random places like the Metadatahash or Reserve Address out of desperation.  Proposed off-chain solution seems to be inefficient as it would use the URL field for the metadata location, thus requiring even more requests to render a gallery.  People are already using the Note field and doing multiple requests out of necessity.

Not necessary. Can use transactions endpoint just as well.


v3 Released in Packagist

Describe the bug
v3 was tagged back in May, even though the newest version is (currently) v0.1. Composer/Packagist now download this old version by default if you follow the steps in the documentation.
To Reproduce
Steps to reproduce the behavior:

Install the package using Composer

Expected behavior
I expected to download the most recently released version.

This is what I just ran into as well!

The current fix for this is to just update your composer.json to have the correct version specified (^0.1) but I think the incorrect version should be removed from Packagist at least so it stops downloading/updating, and probably untagged in git so it doesn't cause any confusion when v3 actually gets released.

Looks like @calebporzio fixed this in response to #58 👍


Broken link to PBI Install doc

The link to PBI Install doc is broken.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 614f5dfe-e89b-9ccf-1585-c86a67efa9b3
Version Independent ID: 614f5dfe-e89b-9ccf-1585-c86a67efa9b3
Content: Microsoft Dynamics 365 Finance business performance planning requirements - Finance | Dynamics 365
Content Source: articles/finance/business-performance-planning/Install-BPP2.md
Service: dynamics-365-finance
Product: ****
Technology: ****
GitHub Login: @ShielaSogge
Microsoft Alias: twheeloc

@riblack-microsoft, thank you for letting us know. The updated link will be live later today.


Three dots appear in splide__list after update to 0.6.3

Checks

[x] Not a duplicate.
[X] Not a question, feature request, or anything other than a bug report directly related to Vue Splide. Use Discussions for these topics: https://github.com/Splidejs/splide/discussions

Version
0.6.3
Description
I updated from version 0.5.18 to 0.6.3. When I pick the carousel with mouseclick, pull it to side a bit and then release, after the track come back to its normal position. three dots with class splide__sr appear. This did not happen in previous version. Video is attached below, I cannot provide reproduction.
Carousel settings:
type: 'slide',
  rewind: false,
  waitForTransition: false,
  width: '100%',
  perMove: 1,
  speed: 700,
  pagination: false,
  arrowPath: 'M30.3,18.9L11.8,0.5c-0.6-0.6-1.6-0.6-2.2,0C9,1.1,9,2,9.7,2.6L27.1,20L9.7,37.4C9,38,9,38.9,9.7,39.5 c0.3,0.3,0.7,0.5,1.1,0.5c0.4,0,0.8-0.2,1.1-0.5l18.5-18.4c0.3-0.3,0.5-0.7,0.5-1.1C30.8,19.6,30.6,19.2,30.3,18.9z',
  breakpoints: {
    7000: {
      perPage: 6,
      gap: '30px',
    },
    1900: {
      perPage: 5,
      gap: '25px',
    },
    1400: {
      perPage: 4,
      gap: '20px',
    },
    1279: {
      perPage: 4,
      gap: '15px',
    },
    1024: {
      perPage: 3,
      gap: '10px',
    },
    768: {
      perPage: 2,
      gap: '10px',
    },
    640: {
      perPage: 1,
    },

https://user-images.githubusercontent.com/50501921/162427338-5d21b6c9-a605-4c9c-81fc-5411d7e99daa.mp4
Reproduction Link
No response
Steps to Reproduce

Install v0.6.3 of vue-splide
Pick and pull carousel to the side, then release and wait for animation to end
Three dots appear

Expected Behaviour
Three dots not appearing.

You need to update CSS too.

Sorry, I did not thought about that. My bad. Thank you.


create comment trigger option for running longer running e2e tests

What type of PR is this?

What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
TODOs:

[ ] squashed commits
[ ] includes documentation
[ ] adds unit tests
[ ] adds or updates e2e tests

/test deploy


Footnotes order inside table is reversed

Initial checklist

[X] I read the support docs
[X] I read the contributing guide
[X] I agree to follow the code of conduct
[X] I searched issues and couldn’t find anything (or linked relevant results below)

Affected packages and versions
"remark-gfm": "^3.0.1"
Link to runnable example
No response
Steps to reproduce
// Node v18.13.0
/* Input */
Before tableeeeeeeeeee [^t0]

| h1 [^h1] | h2 [^h2] | h3 [^h3] |
| --- | --- | --- |
| 1 [^c1] | 2 [^c2] | 3 [^c3] |
| 4 [^c4] | 5 [^c5] | 6 [^c6] |
| 7 [^c7] | 8 [^c8] | 9 [^c9] |

After table[^t1]

[^t0]: t0
[^h1]: h1
[^h2]: h2
[^h3]: h3
[^c8]: c8
[^c9]: c9
[^t1]: t1
[^c1]: c1
[^c2]: c2
[^c3]: c3
[^c4]: c4
[^c5]: c5
[^c6]: c6
[^c7]: c7

/* mdsvex.config.js */
const config = defineConfig({
	extensions: ['.svelte.md', '.md', '.svx'],

	remarkPlugins: [
		remarkParse,
		remarkGfm,
	],
	rehypePlugins: [
		rehypeStringify,
	 ],
	... More Code ...
});

/* svelte.config.js */
... More Code ...
import { mdsvex } from 'mdsvex';
import mdsvexConfig from './mdsvex.config.js';

const config = {
	extensions: ['.svelte', ...mdsvexConfig.extensions],

	preprocess: [
		mdsvex(mdsvexConfig)
	],
	... More Code ...
}

Expected behavior
Before tableeeeeeeeeee 1

h1 2
h2 3
h3 4

1 5
2 6
3 7

4 8
5 9
6 10

7 11
8 12
9 13

After table14Footnotest0 ↩h1 ↩h2 ↩h3 ↩c1 ↩c2 ↩c3 ↩c4 ↩c5 ↩c6 ↩c7 ↩c8 ↩c9 ↩t1 ↩
Actual behavior
Before tableeeeeeeeeee t0

h1 h1
h2 h2
h3 h3

1 c1
2 c2
3 c3

4 c4
5 c5
6 c6

7 c7
8 c8
9 c9

After tablet1t0↩c9↩c8↩c7↩c6↩c5↩c4↩c3↩c2↩c1↩h3↩h2↩h1↩t1↩
The point is that the footnote order inside table is reversed :/
Runtime
Other (please specify in steps to reproduce)
Package manager
npm 8
OS
macOS
Build and bundle tools
Vite

This was solved a year ago: https://github.com/syntax-tree/mdast-util-to-hast/releases/tag/12.1.1

This was solved a year ago: https://github.com/syntax-tree/mdast-util-to-hast/releases/tag/12.1.1

did you checked with svelte+vite+mdsvex?

Why should I check those tools? I don’t work on them. If it’s an issue there, raise it there

Why should I check those tools? I don’t work on them. If it’s an issue there, raise it there

the issue is just on remark-gfm itself. actually other remark- packages are all working fine

No it’s not, remark-gfm doesn’t handle how tables are turned into HTML. That’s what remark-rehype/mdast-util-to-hast do. It’s fixed there.
All remark packages are working fine. The problem is in your other tools.

What?

actually there is no problem with table.
markdown is converted perfectly with just remark-parse and remark-gfm.
but the issue is just on footnotes inside table.
if I remove remark-gfm and just use remark-rehype & remark-footnotes, then the footnotes order is fine but the table is not converted. the only way I can see table is using remark-gfm, but if I use that, footnotes order breaks.

Codesandbox has some caching issues. Try on your computer:
import {unified} from 'unified'
import remarkParse from 'remark-parse'
import remarkGfm from 'remark-gfm'
import remarkRehype from './index.js'
import remarkStringify from 'rehype-stringify'

const file = await unified()
  .use(remarkParse)
  .use(remarkGfm)
  .use(remarkRehype)
  .use(remarkStringify)
  .process(
    `Before tableeeeeeeeeee [^t0]

| h1 [^h1] | h2 [^h2] |
| --- | --- |
| 1 [^c1] | 2 [^c2] |

After table[^t1]

[^t0]: t0
[^h1]: h1
[^h2]: h2
[^t1]: t1
[^c1]: c1
[^c2]: c2
`
  )

console.log(String(file))

Before tableeeeeeeeeee 1

h1 2
h2 3

1 4
2 5

After table6

Footnotes

t0 ↩

h1 ↩

h2 ↩

c1 ↩

c2 ↩

t1 ↩

I gave you the solution three times: it’s not here, it’s in your other tools.

Yeah, it's working on local.
seems the issue is on other part.
Thanks.  👍


[BUG] SlateDrawingExample scene doesn't have a description box

Describe the bug
SlateDrawingExamplescene doesn't have a description box
To reproduce
Steps to reproduce the behavior:

Go to SlateDrawingExamplescene
See error: the scene does not contain a description box

Expected behavior
When opening the scene a description box should be part of it
To reproduce
Steps to reproduce the behavior:

Go to InputFieldExamples scene
See error: the input field scene doesn't have a description box.

Expected behavior
When opening the scene a description box (selectable and draggable) should be part of it.
Your setup (please complete the following information)

Unity Version [e.g. 2021.3.21f1]

MRTK Version 3 or Commit https://github.com/MixedRealityToolkit/MixedRealityToolkit-Unity/commit/d74d59f828d9eb6a169a29e6693ba32439d9c068

HoloLens 2

Additional context
This was detected as part of manual testing for next release signoff.

It would be good if all samples had a description box.

It would be good if all sample scenes had description box. The following issues are related, and are about samples missing description boxes.

https://github.com/MixedRealityToolkit/MixedRealityToolkit-Unity/issues/678
https://github.com/MixedRealityToolkit/MixedRealityToolkit-Unity/issues/681
https://github.com/MixedRealityToolkit/MixedRealityToolkit-Unity/issues/682
https://github.com/MixedRealityToolkit/MixedRealityToolkit-Unity/issues/684
https://github.com/MixedRealityToolkit/MixedRealityToolkit-Unity/issues/685
https://github.com/MixedRealityToolkit/MixedRealityToolkit-Unity/issues/690


Mock login

Hello, is there a way to mock login? For example, you use $auth.login and maybe pass a parameter to tell that it shouldn't really try to login, but to mock success or failure?

I am not sure why you would want to do that, but no there isn't a way to perform a fake login.


Replace url with onclick action

There could be use cases where not everyone needs to open a url on cover click. A better approach would be to make it customisable action function, so that we can do anything we want with it.

Good idea

I will use data-action to replace data-url next version


Update jackson-module-scala to 2.12.1

Updates com.fasterxml.jackson.module:jackson-module-scala from 2.12.0 to 2.12.1.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.fasterxml.jackson.module", artifactId = "jackson-module-scala" } ]

labels: library-update, semver-patch

Some code changes were done manually. Thanks @scala-steward

Some code changes were done manually. Thanks @scala-steward


ProfileValidation is not working for STU3

When using the FhirInstanceValidator it will accept all data as successfully verified
Reason: there will be no Codesystems and Valuesets be loaded into the underlaying DefaultProfileValidationSupport
This is because the load is done by:
DefaultProfileValidationSupport.class.getResourceAsStream(theClasspath);
line 150 of
hapi-fhir\hapi-fhir-structures-dstu3\src\main\java\org\hl7\fhir\dstu3\hapi\validation\DefaultProfileValidationSupport.java
this fails  because
DefaultProfileValidationSupport.class is in hapi-fhir-structures-dstu3-2.1.jar
but the resources xml files are in
hapi-fhir-validation-resources-dstu3-2.1.jar

Strange enough, after recompiling at work,
validation is working now.
so i'll close this issue again


Human 1.16

Main improvements in this PR:

Fixes (PR #643)

removes MAR20015, MAR20014, MAR20052 for being duplicates of MAR04689, MAR06981, MAR00067, repectively, based on #630
also merges all annotations (E.C. codes, corresponding IDs in other models/databases) from the removed reactions into the kept ones

Fixes (PR #629)

fix Yaml file's bug found in #628

Fixes (PR #623)

update GPRs and PMID for 5-aminolevulinate transport reactions MAR09985 and MAR11307
, as suggested in #588:

Fixes (PR #619)

change metCharges field to int64 type and fix bug in readlines reported in #608:
Fixes (PR #612)
reorganize redox reactions catalyzed by electron transfer flavoprotein, as proposed in #608

update GPR of MAR06911
Remove MAR00562 and MAR00563 for being redundant with MAR06911
Removes MAM03573m and MAM03574m

Fixes (PR #606)

revise GPRs and modify reactions related to CLYBL (ENSG00000125246), as discussed in #586

add CLYBL to the GPR of MAR08666
add PMID:24334609 as a reference of MAR08666
create new reaction MAR020111 to represent malate synthase activity of CLYBL: MAM02007m + MAM01261m + MAM02040m -> MAM02439m MAM01597m, GPR: ENSG00000125246, reference: PMID:24334609
remove MAR05294 and MAR11421 since neither CLYBL nor any other human enzyme catalyzes those reactions

Fixes (PR #605)

merge duplicate Malonyl Carnitine metabolites MAR05434 and MAR02599, as reported in #595

rename MAM02443c, MAM02443m, MAM02443r, and MAM02443x to "malonyl-carnitine"
create new metabolite MAM02443e
replace MAM03494c and MAM03494e with MAM02443c and MAM02443e in MAR04886 and MAR11256
remove MAR05434 for being redundant with MAR02599
remove MAM03494c and MAM03494e for being redundant with MAM02443c and MAM02443e
merge old annotations for MAM03494c/e into current annotations for MAM02443c/e in metabolites.tsv

Fixes (PR #602)

assign compartment-specifc GPRs to carbonic anhydrase reactions MAR03955 and MAR05407, as detailed in #597

Fixes (PR #601)

deal with duplicate carbonic anhydrase reaction sets by removing two-stpe versions and keep one-step reactions, as listed in #589

Fixes (PR #600)

updates NA+/Pi transport reactions GPRs as referenced in #568

remove reaction MAR04411 and MAR05413
add ENSG00000143324 (XPR1) to the GPR of MAR02351, add ENSG00000144136 (SLC20A1) and ENSG00000168575 (SLC20A2) to the GPR of MAR04910

Fixes (PR #596)

changes the GPR of MAR04372 from ENSG00000172331 to ENSG00000119640 or ENSG00000170634, as discussed in #587

Fixes (PR #592)

add Acylpyruvase FAHD1 (ENSG00000180185) to Human-GEM and to GPR of MAR20110 and MAR11430, as proposed in #585

Fixes (PR #591)

add AUH to previously-empty GPRs of MAR05999, MAR08664, and MAR11514, derived from the discussion in #590
update Rhea Ids and PMID to above reactions

Fixes (PR #581)

revise reactions, GPRs, and references for glucose Uptake and Na+/K+ pumps, as detailed in #570

Remove MAR05295, MAR06894, and MAR06895
Remove ENSG00000140675 from MAR05029
Copy references from MAR05429 to MAR05295
Change MAR01444 to ATP [c] + H2O [c] + K+ [e] + H+ [e] + 2 Na+ [c] ⇒ ADP [c] + Pi [c] + K+ [c] + H+ [c] + 2 Na+ [e], GPR: ENSG00000075673 and ENSG00000186009

Fixes (PR #576)

remove chloride-dependent transporter SLC6A14 (ENSG00000268104) from GPRs of 22 reactions without Cl- listed in #567

Features (PR #575)

add 39 new rxns related to histidine metabolism, as reported in #553

Fixes (PR #573)

remove/merge duplicate reactions reported in #561
adds ENSG00000198099 to the GPR of MAR06644

Featurs (PR #564)

add GH action check for both essential and basic verification tasks, as mentioned in #390

Featurs (PR #563)

add essentiality analysis suite using Hart2015 datasets, as discussed in #390

Features (PR #560)

curate GPRs for cysteine metabolism reactions, as reported in #552

Fixes (PR #559)

curate reactions and GPRs for Alanine, Aspartate and Glutamate subsystem, as proposed in #548

Fixes (PR #557)

make a total of 180 non-transport/exchange pyrophosphate reactions irreversible, based on the report in #527

Features (PR #556)

improves GH actions in sanityCheck.py by enabling detection of unused metabolites, triggered by mistakes found in #525

now the Hart2015 essentiality suite (#563) is added to this release, with following results:

'cellLine'
'TP'
'TN'
'FP'
'FN'
'accuracy'
'sensitivity'
'specificity'
'F1'
'MCC'
'Penr'
'logPenr'
'PenrAdj'
'logPenrAdj'

'DLD1'
95
2109
143
223
0.85758755
0.29874214
0.93650089
0.34172662
0.26721557
1.04E-30
29.9838919
3.11E-30
29.5067706

'GBM'
85
2081
153
250
0.84312962
0.25373134
0.93151298
0.29668412
0.21515393
1.78E-21
20.7503043
2.67E-21
20.5742131

'HCT116'
113
2137
130
246
0.85681645
0.31476323
0.94265549
0.37541528
0.3051743
3.02E-40
39.519913
1.81E-39
38.7417618

'HELA'
86
2182
157
202
0.86334222
0.29861111
0.9328773
0.32391714
0.24962285
2.74E-27
26.5616613
5.49E-27
26.2606313

'RPE1'
63
2115
175
216
0.8478007
0.22580645
0.92358079
0.24371373
0.16031484
6.69E-13
12.1747792
6.69E-13
12.1747792

'all'
41
2308
202
76
0.89417587
0.35042735
0.91952191
0.22777778
0.19220101
2.19E-15
14.6589606
2.63E-15
14.5797793


Fix TabContainer tab offset moving when not needed

fixes https://github.com/godotengine/godot/issues/97133

It was caused by the call to set_anchors_and_offsets_preset(PRESET_TOP_WIDE); since it reset the left and right offsets and then the TabBar resizes and changes the tab offset to fit. The offsets were fixed after, but the tab offset was already changed. The call to _update_margins is no longer needed.
I made sure that the anchors and offsets are the same as before:
tabs_position: top
anchors: top 0, bot 0, left 0, right 1
offsets: top 0, bot 31, left 8, right 0
tabs_position: bottom
anchors: top 1, bot 1, left 0, right 1
offsets: top -31, bot 0, left 8, right 0

Thanks!


[TC-176] fix minor typo in  -- affects only 2.0.x branch

causes traffic_router to fail to build

thanks for catching this, will merge into 2.0.x

@limited @dangogh looks like @hbeatty already addressed this in #331

Merged this in #331, please close this one


net/http/httputil: reverseproxy.removeConnectionHeaders not removing all headers

Problem
In my testing, the reverse proxy doesn't remove all the header fields from a message that are listed in the Connection header.
Relevant code lines
(Header).Get only returns the first value if there are multiple values (also the strings.Split appears not do do anything, since only one value is returned).
Per the comment on (Header).Get:

To access multiple values of a key, or to use non-canonical keys, access the map directly.

Example
I've set this out in the playground. In this example, the upstream is returning the following headers:
Connection: Thing1, Thing2
Thing1: value1
Thing2: value2

However, the output shows that Thing2 header field is still present.
Thing1:
Thing2: value2
Connection:

Per RFC 7230, since Thing1 and Thing2 are both their own header fields, and also values of Connection, my understanding is that all three fields should be removed.
Potential Solution
If my understanding of this is correct, then we could do something like the following below, which would iterate over all the values of Connection.
func removeConnectionHeaders(h http.Header) {
	if c := h["Connection"]; len(c) > 0 {
		for _, v := range c {
			if v = strings.TrimSpace(v); v != "" {
				h.Del(v)
			}
		}
	}
}

Thank you for this report @jonathon-l and welcome to the Go project!
In deed, as you've reported and noticed this is a minor oversight that comes from the usage of Header.Get instead of Header[key]. We introduced this in CL https://go-review.googlesource.com/c/go/+/28810/ but unfortunately our test only involved comma-concatenated header values
		w.Header().Set("Connection", "Upgrade, "+fakeConnectionToken)
		w.Header().Set("Upgrade", "should be deleted")
		w.Header().Set(fakeConnectionToken, "should be deleted")

instead of .Add values and this produced the subtle bug that you've noticed e.g.
https://play.golang.org/p/ionUhg2dYXp or inlined below in
package main

import (
	"bytes"
	"fmt"
	"net/http"
)

func main() {
	buf := new(bytes.Buffer)

	h1 := make(http.Header)
	h1.Add("C", "a")
	h1.Add("C", "b")
	h1.Write(buf)
	fmt.Printf("header by .Add on wire:\n%#v\n\n", buf.String())

	buf.Reset()

	h2 := make(http.Header)
	h2.Add("C", "a, b")
	h2.Write(buf)
	fmt.Printf("header by ',' values on wire:\n%#v\n\n", buf.String())

	hm1 := map[string][]string(h1)
	fmt.Printf("1. Cast to map[string][]string: %#v\n", hm1)
	hm2 := map[string][]string(h2)
	fmt.Printf("2. Cast to map[string][]string: %#v\n", hm2)
}

which produces
header by .Add on wire:
"C: a\r\nC: b\r\n"

header by ',' values on wire:
"C: a, b\r\n"

1. Cast to map[string][]string: map[string][]string{"C":[]string{"a", "b"}}
2. Cast to map[string][]string: map[string][]string{"C":[]string{"a, b"}}

Please feel free to send a patch( for Go1.13 and tag @bradfitz and myself, where the patch will involve your suggestion and updating the test in  https://github.com/golang/go/blob/01f34cbf525bcdef5ca0040960e029ac92b62642/src/net/http/httputil/reverseproxy_test.go#L153
to for instance
		w.Header().Add("Connection", "Upgrade, "+fakeConnectionToken)
		w.Header().Add("Connection", "X-Extra")
		w.Header().Set("Upgrade", "should be deleted")
		w.Header().Set(fakeConnectionToken, "should be deleted")
		w.Header().Set("X-Extra", "should be deleted")

and perhaps a tighter test to check for the serialized output(number of expected headers and values) to augment the .Get checks.

@jonathon-l are you working on this? If not, I'd be glad to give it a shot.

Hey @dphan72, I am working on this, I should have a PR ready tomorrow.

@jonathon-l Gentle nudge for updates on this.
Let us know if you are facing any problem sending in the patch! 😄

Kindly paging you @jonathon-l to take a look at the comments that I left on your CL in March. Thank you!

Will take a look. Thanks for the reminder, was off my radar.


Windows on travis

Mind adding a brief description to the PR? Were windows builds running somewhere else before, and we're migrating to Travis? Or were we not running any builds on windows?
Also looks like the build is failing