Finalize basic Commons-specific schema template specifications: Information, Artwork, Art Photo, Book

We've continued thinking about Wikimedia Commons-specific template support inside OpenRefine's Wikibase schema builder.
We've come up with the concept of 'schema templates': basically, these are empty Wikibase schemas inside OpenRefine. For the Wikimedia Commons use case, we want to add a few default ones corresponding to frequently-used file information templates that are also Structured Data on Commons-driven (Information, Artwork, Art Photo, Book - for now). Users will be able to add their own.

Current wireframes by @lozanaross were based on a spreadsheet by Sandra, but need some tweaking and finalization (basically, there will be other custom statements that reflect current SDC modeling conventions). @trnstlntk will create these based on her knowledge of these modeling practices.

I think there is one additional TO DO with this issue.

[ ] Check all this with commons community / relevant staff.

I was thinking about this issue of how confusing it is to indicate what something depicts vs what it is a representation of - slightly controversial proposal, but do we have any chance of proposing 2 properties here to the community (instead of just the one): 1) representation of - to indicate what work of art the image is representing (there is already one such WD property although it's used differently of course: https://www.wikidata.org/wiki/Wikidata:Property_proposal/representation_of) 2) depicts - to indicate what the image is depicting - e.g. a sculpture on a pedestal, outdoors, etc.

For reference, this is the code that @multichill uses to generate SDC and Wikitext (including the much-feared license templates) when uploading new files to Commons: https://github.com/multichill/toollabs/blob/master/bot/commons/wikidata_uploader.py#L398

I think there is one additional TO DO with this issue.
* [ ]  Check all this with commons community / relevant staff.

I was thinking about this issue of how confusing it is to indicate what something depicts vs what it is a representation of - slightly controversial proposal, but do we have any chance of proposing 2 properties here to the community (instead of just the one): 1) representation of - to indicate what work of art the image is representing (there is already one such WD property although it's used differently of course: https://www.wikidata.org/wiki/Wikidata:Property_proposal/representation_of) 2) depicts - to indicate what the image is depicting - e.g. a sculpture on a pedestal, outdoors, etc.

The current consensus is documented at https://commons.wikimedia.org/wiki/Commons:Structured_data/Modeling/Depiction#Works_of_art and it doesn't include https://www.wikidata.org/wiki/Property:P4646 . P4646 is for performances.

I am documenting this here: https://docs.google.com/document/d/1TTKmjg8pL4f2OZTrobeZcem_Ns-O8Y_cwHHWt9zFd2g/edit#
I'm still working on the help text but the structure should be in place.
The instructions reflect current SDC modeling best practices, and I feel pretty good and confident about these. However, the help text can still use a bit of improvement. More broadly, I think the documentation on Wikimedia Commons can still use a big improvement - community members don't spontaneously find Commons:Structured data/Modeling at all, and I think it would be very good to actually have dedicated documentation pages for the SDC equivalents of the basic information template, for visual artworks, and for books. I may put that on my to do list too.

Following up on #5043 (schema templates developed in the Wikibase extension), I am developing the current Commons-specific schema templates there.
I am also in progress of developing documentation re: data modeling for artworks: https://commons.wikimedia.org/wiki/Commons:Structured_data/Modeling/Visual_artworks


files with ignore build tag are not ignored

For example this file: odin/core/image/png/example.odin
has a file tag: //+build ignore
but is still getting parsed and included in completions
eg png.main and png.demo are showing up

Should be fixed in rename branch.


How to select multiple images from library ?

Since support for multiple selection isn't baked into UIImagePickerController on iOS, I have no plans to implement this. That would require a completely custom implementation.

That's interesting, think I might implement my own (:

@kyle-ssg Did you do it?

No not in the end, there are a few libs that accomplish this now though e.g. react-native-image-crop-picker

That has few issues. Well more than few:
https://github.com/ivpusic/react-native-image-crop-picker/issues/491


Add djinni distribution in binary form

Please add djinni binaries for windows/linux/mac so developer can just "download and use".
It is not possible to build djinni on some machines. I think this is location-related. Internet accessibility is fine, but djinni downloads during build may take more than 24hrs and still be in progress, moving veeery sloooow.
Screenshot shows that the downloads are progressing, but super-slow.

You can build it by your own on a machine where it's working:
https://github.com/dropbox/djinni#generate-a-standalone-jar

Thanks, I will definitely do it. But it is still great to have an option to just download it and use.

That's true, but unfortunately the repository is not maintained any more.

Maintenance note: This repo is stable but no longer actively maintained. No further development is planned, and no new feature PRs will be merged. Bug fixes may be merged on a volunteer basis. If you have questions or want to talk to other users of Djinni, you can join the Slack community via the link at the end of this document.

I don't see any obvious failures in your screenshot.  Perhaps it was related to the issues with repo.typesafe.com described in #449?
Regardles, as a1lu says, Djinni isn't getting any more feature work, so if you different packaging options I'd encourage you to look into providing them yourself.

I faced the same problem. the project was not built during the whole day. But in the end, some tricks were found that helped reduce assembly time to a few minutes. Firstly, I tried with https://github.com/LedgerHQ/djinni, the time for downloading packages on my Windows machine was reduced, but the process of resolving dependencies was still very long. The next step was to use WSL bash and disable Windows Defender, and the total build time was about ten minutes (instead of a whole day). I leave binary jar below. Good luck!
binary .jar


land use 0..1 to 0..*

Also converted to an observable property.

ontology change. on LandsurveySite hasLandUse max 1 to 0..*


feature: out of the box copy support on Windows

Observed behavior

copy and paste on Windows does not work out of the box

Fixed via  this add on to /.doom/.config.el
(defmacro with-system (type &rest body)
  "Evaluate BODY if `system-type' equals TYPE."
  (declare (indent defun))
  `(when (eq system-type ',type)
     ,@body))

(with-system windows-nt
     ;; based on https://rufflewind.com/2014-07-20/pasting-unicode-in-emacs-on-windows
  (set-selection-coding-system 'utf-16-le) ; required to paste unicode in emacs on windows
     ;;
  (message "end of windows-nt specific configs."))

Qs

What would be the right place to embed this to the doom-emacs source,
that this can work out of the box.

37525bb should hopefully address this issue. Please update and let me know!


Cleaning up promise-from-getHeadStylesheets test page

Cleaning up getHeadStylesheets with promises test page.
@gigabo encouraged me to be cute, so I added a date endpoint for test pages that echoes CSS back.

BTW, I noticed some weird behavior that I filed as #116. I didn't have time to dig into it though.

@gigabo encouraged me to be cute

😘
This is great!  Plus you found a bug while you were working on it!


permission denied: spotty

Trying to get this setup using pipenv (python 3.7), running pip install -U spotty doesn't throw any errors but running spotty results in permission denied: spotty.
This also happens if I run this outside of the environment, or with sudo.
EDIT:
Tried to clone the repo, and install using python3 setup.py install. Runs the installation OK, but running create-ami results in:
  File "/Users/zohaibahmed/.virtualenvs/Tacotron-2-p0EfLM-4/bin/spotty", line 4, in <module>
    __import__('pkg_resources').run_script('spotty==1.1.1', 'spotty')
  File "/Users/zohaibahmed/.virtualenvs/Tacotron-2-p0EfLM-4/lib/python3.7/site-packages/pkg_resources/__init__.py", line 661, in run_script
    self.require(requires)[0].run_script(script_name, ns)
  File "/Users/zohaibahmed/.virtualenvs/Tacotron-2-p0EfLM-4/lib/python3.7/site-packages/pkg_resources/__init__.py", line 1448, in run_script
    exec(script_code, namespace, namespace)
  File "/Users/zohaibahmed/.virtualenvs/Tacotron-2-p0EfLM-4/lib/python3.7/site-packages/spotty-1.1.1-py3.7.egg/EGG-INFO/scripts/spotty", line 7, in <module>
  File "/Users/zohaibahmed/.virtualenvs/Tacotron-2-p0EfLM-4/lib/python3.7/site-packages/spotty-1.1.1-py3.7.egg/spotty/commands/create_ami.py", line 8, in <module>
ModuleNotFoundError: No module named 'cfn_tools'

Even though cfn-tools is installed already.

It's a wrong requirement in the setup.py file :(. Thank you for the report!
"setup.py" contains the package "cfn_tools", but it's a wrong third-party package. Actual package with the right module is the "cfn_flip". I changed it on the dev branch, will do a release now.
Regarding the "permission denied: spotty" problem I'm not sure what it is. What OS are you using? What the permissions for the "spotty" file?

Thanks @apls777, it works with cfn_flip.
I'm running OS X 10.12. Its strange because the privileges seem to be correct and the binary exists there..
▲ pipenv shell --three
Virtualenv already exists!
Removing existing virtualenv...
Creating a virtualenv for this project...
Pipfile: /Users/zohaibahmed/Pipfile
Using /usr/local/bin/python3 (3.7.0) to create virtualenv...
⠋Running virtualenv with interpreter /usr/local/bin/python3
Using base prefix '/usr/local/Cellar/python/3.7.0/Frameworks/Python.framework/Versions/3.7'
/usr/local/Cellar/pipenv/2018.7.1/libexec/lib/python3.7/site-packages/virtualenv.py:1041: DeprecationWarning: the imp module is deprecated in favour of importlib; see the module's documentation for alternative uses
  import imp
New python executable in /Users/zohaibahmed/.virtualenvs/zohaibahmed-5rCr62Yh/bin/python3.7
Also creating executable in /Users/zohaibahmed/.virtualenvs/zohaibahmed-5rCr62Yh/bin/python
Installing setuptools, pip, wheel...done.
Setting project for zohaibahmed-5rCr62Yh to /Users/zohaibahmed

Virtualenv location: /Users/zohaibahmed/.virtualenvs/zohaibahmed-5rCr62Yh
Warning: Your Pipfile requires python_version 3.6, but you are using 3.7.0 (/Users/z/./z/bin/python).
  $ pipenv check will surely fail.
Launching subshell in virtual environment…
 . /Users/zohaibahmed/.virtualenvs/zohaibahmed-5rCr62Yh/bin/activate
▲ ~  . /Users/zohaibahmed/.virtualenvs/zohaibahmed-5rCr62Yh/bin/activate
(zohaibahmed-5rCr62Yh) ▲ ~ pip3 install -U spotty
Collecting spotty
  Downloading https://files.pythonhosted.org/packages/6b/3c/0ada8ba142e9f900281b2a55870c94e70edd46f4a514077c4398d0cc5e62/spotty-1.1.2-py3-none-any.whl
Collecting boto3>=1.7.0 (from spotty)
  Using cached https://files.pythonhosted.org/packages/73/c9/838562a62089587a31e8ecb160ccf8c4cf017bc749d6193fca41cc534753/boto3-1.9.19-py2.py3-none-any.whl
Collecting cfn-flip (from spotty)
Collecting schema (from spotty)
  Using cached https://files.pythonhosted.org/packages/7b/6e/2b6b764a9a3d3aa366a857f4c5f34d27de4fca54c2b9b88f93ccf2821353/schema-0.6.8-py2.py3-none-any.whl
Collecting botocore>=1.10.0 (from spotty)
  Using cached https://files.pythonhosted.org/packages/10/5e/f74ce6c79bcf6b634c0fe721c45d7e5e2d67bcecb29142412b8587fc5ab0/botocore-1.12.19-py2.py3-none-any.whl
Collecting jmespath<1.0.0,>=0.7.1 (from boto3>=1.7.0->spotty)
  Using cached https://files.pythonhosted.org/packages/b7/31/05c8d001f7f87f0f07289a5fc0fc3832e9a57f2dbd4d3b0fee70e0d51365/jmespath-0.9.3-py2.py3-none-any.whl
Collecting s3transfer<0.2.0,>=0.1.10 (from boto3>=1.7.0->spotty)
  Using cached https://files.pythonhosted.org/packages/d7/14/2a0004d487464d120c9fb85313a75cd3d71a7506955be458eebfe19a6b1d/s3transfer-0.1.13-py2.py3-none-any.whl
Collecting six (from cfn-flip->spotty)
  Using cached https://files.pythonhosted.org/packages/67/4b/141a581104b1f6397bfa78ac9d43d8ad29a7ca43ea90a2d863fe3056e86a/six-1.11.0-py2.py3-none-any.whl
Collecting PyYAML (from cfn-flip->spotty)
Collecting Click (from cfn-flip->spotty)
  Using cached https://files.pythonhosted.org/packages/fa/37/45185cb5abbc30d7257104c434fe0b07e5a195a6847506c074527aa599ec/Click-7.0-py2.py3-none-any.whl
Collecting urllib3<1.24,>=1.20 (from botocore>=1.10.0->spotty)
  Using cached https://files.pythonhosted.org/packages/bd/c9/6fdd990019071a4a32a5e7cb78a1d92c53851ef4f56f62a3486e6a7d8ffb/urllib3-1.23-py2.py3-none-any.whl
Collecting python-dateutil<3.0.0,>=2.1; python_version >= "2.7" (from botocore>=1.10.0->spotty)
  Using cached https://files.pythonhosted.org/packages/cf/f5/af2b09c957ace60dcfac112b669c45c8c97e32f94aa8b56da4c6d1682825/python_dateutil-2.7.3-py2.py3-none-any.whl
Collecting docutils>=0.10 (from botocore>=1.10.0->spotty)
  Using cached https://files.pythonhosted.org/packages/36/fa/08e9e6e0e3cbd1d362c3bbee8d01d0aedb2155c4ac112b19ef3cae8eed8d/docutils-0.14-py3-none-any.whl
Installing collected packages: jmespath, urllib3, six, python-dateutil, docutils, botocore, s3transfer, boto3, PyYAML, Click, cfn-flip, schema, spotty
Successfully installed Click-7.0 PyYAML-3.13 boto3-1.9.19 botocore-1.12.19 cfn-flip-1.0.3 docutils-0.14 jmespath-0.9.3 python-dateutil-2.7.3 s3transfer-0.1.13 schema-0.6.8 six-1.11.0 spotty-1.1.2 urllib3-1.23
(zohaibahmed-5rCr62Yh) ▲ ~ spotty
zsh: permission denied: spotty
(zohaibahmed-5rCr62Yh) ▲ ~ which spotty
spotty not found
(zohaibahmed-5rCr62Yh) ▲ ~ which pip
/Users/zohaibahmed/.virtualenvs/zohaibahmed-5rCr62Yh/bin/pip
(zohaibahmed-5rCr62Yh) ▲ ~ /Users/zohaibahmed/.virtualenvs/zohaibahmed-5rCr62Yh/bin
(zohaibahmed-5rCr62Yh) ▲ bin ls -al
total 256
drwxr-xr-x  32 zohaibahmed  staff   1088  9 Oct 17:49 .
drwxr-xr-x   8 zohaibahmed  staff    272  9 Oct 17:49 ..
drwxr-xr-x  15 zohaibahmed  staff    510  9 Oct 17:49 __pycache__
-rw-r--r--   1 zohaibahmed  staff   2111  9 Oct 17:49 activate
-rw-r--r--   1 zohaibahmed  staff   1053  9 Oct 17:49 activate.csh
-rw-r--r--   1 zohaibahmed  staff   2207  9 Oct 17:49 activate.fish
-rw-r--r--   1 zohaibahmed  staff   1137  9 Oct 17:49 activate_this.py
-rwxr-xr-x   1 zohaibahmed  staff    266  9 Oct 17:49 cfn-flip
-rwxr-xr-x   1 zohaibahmed  staff    284  9 Oct 17:49 easy_install
-rwxr-xr-x   1 zohaibahmed  staff    284  9 Oct 17:49 easy_install-3.7
-rwxr-xr-x   1 zohaibahmed  staff   1725  9 Oct 17:49 jp.py
-rwxr-xr-x   1 zohaibahmed  staff    266  9 Oct 17:49 pip
-rwxr-xr-x   1 zohaibahmed  staff    266  9 Oct 17:49 pip3
-rwxr-xr-x   1 zohaibahmed  staff    266  9 Oct 17:49 pip3.7
lrwxr-xr-x   1 zohaibahmed  staff      9  9 Oct 17:49 python -> python3.7
-rwxr-xr-x   1 zohaibahmed  staff   2370  9 Oct 17:49 python-config
lrwxr-xr-x   1 zohaibahmed  staff      9  9 Oct 17:49 python3 -> python3.7
-rwxr-xr-x   1 zohaibahmed  staff  12552  9 Oct 17:49 python3.7
-rwxr-xr-x   1 zohaibahmed  staff    644  9 Oct 17:49 rst2html.py
-rwxr-xr-x   1 zohaibahmed  staff    764  9 Oct 17:49 rst2html4.py
-rwxr-xr-x   1 zohaibahmed  staff   1189  9 Oct 17:49 rst2html5.py
-rwxr-xr-x   1 zohaibahmed  staff    841  9 Oct 17:49 rst2latex.py
-rwxr-xr-x   1 zohaibahmed  staff    650  9 Oct 17:49 rst2man.py
-rwxr-xr-x   1 zohaibahmed  staff    814  9 Oct 17:49 rst2odt.py
-rwxr-xr-x   1 zohaibahmed  staff   1748  9 Oct 17:49 rst2odt_prepstyles.py
-rwxr-xr-x   1 zohaibahmed  staff    651  9 Oct 17:49 rst2pseudoxml.py
-rwxr-xr-x   1 zohaibahmed  staff    687  9 Oct 17:49 rst2s5.py
-rwxr-xr-x   1 zohaibahmed  staff    921  9 Oct 17:49 rst2xetex.py
-rwxr-xr-x   1 zohaibahmed  staff    652  9 Oct 17:49 rst2xml.py
-rwxr-xr-x   1 zohaibahmed  staff    720  9 Oct 17:49 rstpep2html.py
-rw-r--r--   1 zohaibahmed  staff   1768  9 Oct 17:49 spotty
-rwxr-xr-x   1 zohaibahmed  staff    262  9 Oct 17:49 wheel
(zohaibahmed-5rCr62Yh) ▲ bin sudo spotty
Password:
sudo: spotty: command not found

@ZohaibAhmed "spotty" is not executable for some reason. Try to use the following command:
sudo chmod +x /Users/zohaibahmed/.virtualenvs/zohaibahmed-5rCr62Yh/bin/spotty
After that, you should be able to call it.

Didn't notice that 👍 Thanks! Made a PR for it.

@ZohaibAhmed Thank you! Merged the PR. Probably this file must be executable inside the PIP package as well, so will make a package and release this bugfix tomorrow from a Linux machine.


Version support for 9.4.0

Hi,
from reading this article, I see that the supported versions are 6.4 to 8.22.1. I am wondering if this is a oversight since the latest version is 9.4.0

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: d38cad90-6574-38c2-3262-059a9f975064
Version Independent ID: dd08d5c5-65a4-c2cc-8b51-7a35268dde68
Content: Tutorial: Azure AD SSO integration with JIRA SAML SSO by Microsoft - Microsoft Entra
Content Source: articles/active-directory/saas-apps/jiramicrosoft-tutorial.md
Service: active-directory
Sub-service: saas-app-tutorial
GitHub Login: @dhivyagana
Microsoft Alias: dhivyag

Hi @jtruong-uipath, thanks for letting me know. We do support 9.X versions of JIRA.  I will check the PR that is being raised to see why this hasn't been updated in the document.

@dhivyagana thank you for the quick reply!

@jtruong-uipath
Thanks for pointing this out. Author has performed the required changes.
We are going to close this thread as resolved but if there are any further questions regarding the documentation, please tag me in your reply and we will be happy to continue the conversation.


Handling UuidInterface instances in UuidType::convertToPHPValue

The methods UuidType::convertToDatabaseValue and UuidType::convertToPHPValue should be symetric, but I realize that changes in PR #59 should be present in UuidType::convertToPHPValue.

I noticed that, too, so I made the same changes here: https://github.com/ramsey/uuid-doctrine/commit/64e60182010c5ea0d57c176f6f70062165fa48db
:smile:
I'm happy to accept your test, but I'm confused as to why GitHub is showing the diff as making changes to UuidType.php, since those changes are already present in the master branch.

I was not synchronize with the master branch.

Thanks for contributing!


Fix path to rust examples in github action

Fixes the path to the rust examples in the github action.

Please wait before merging this, I am going to add some CI improvements as well. Currently we are blind if the docs can be built without an error on PRs. We should change that to a more robust system where we

[ ] build docs on PR if we changed something in docs/ or examples
[ ] reuse build workflow and deploy docs on merge to main if we changed something in docs/ or examples

Let's open a new issue for this, we need to get the docs back to working order, and what you're proposing is new functionality anyway.


Added new Feature which counts characters in Contact Us page when message entered.

Fixes Issue🛠

#1704
Closes #
Description👨💻

I added a new feature , In Contact Us page when the user enters a message then the characters will be counted . when the characters are less than 50 the message will be red in color and when the number of characters are greater than are equal to 50 the message color change to green.
Type of Change📄

[ ] New feature (non-breaking change which adds functionality)

Checklist✅

[ ] I am an Open Source contributor
[ ] I have performed a self-review of my code
[ ] My code follows the style guidelines of this project

Screenshots/GIF📷

Before:

After:

@Rakesh9100
Please check my work.
Thank You.

@Rakesh9100

We already have the alert saying Your message must be at least 50 characters long., why do we need this extra count feature @Vaishnavigunti2801

We already have the alert saying Your message must be at least 50 characters long., why do we need this extra count feature @Vaishnavigunti2801

@Rakesh9100
By adding a feature like counting message makes user easily understand the characters limit reached or not . If it is not there user always have to check whether the message is 50 characters long or not by clicking on submit button. I added a color feature to the message count in which if the count is less than 50 it is marked with red otherwise green which makes user comfortable to check the limit.


Not an issue…

…but a praise - thank you for that :) looking forward to new features by the way :)

Thanks, there is a way to go before new features are introduced, but will get there :)

Closing as this is not an issue ;)

Closing as this is not an issue ;)


ViewContainer replaces AppContainer

[Debug]ViewContainer seems to be the name used in the source :)

Thanks!


Update dependencies

Switch to the latest genie to kick training alive again

Pull Request Test Coverage Report for Build 1848

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.007%) to 66.502%

Totals

Change from base Build 1846:
0.007%

Covered Lines:
6869

Relevant Lines:
9706

💛  - Coveralls


sometimes voms-proxy-info fails with exitcode=0

Impact of the bug
CRAB TaskWorker
Describe the bug
I know it is hard to believe, and I could not reproduce this in a test stand, so it is likely related to load or concurrency, but I have evidence that at times voms-proxy-info -file xxxx -timeleft was returning exit code = 0 while file xxxx is not there
How to reproduce it
I could not reproduce it myself. But somehow it was persistently failing for 4 users (not others) until I patched the code.
Expected behavior
Even if retcode is 0, should properly handle any exception from parsing the stdout
Additional context and error message
see https://github.com/dmwm/CRABServer/issues/8625#issuecomment-2312553960
I will make a tested PR

@novicecpp correctly pointed out that this happened becasue of my change #12075 where I have changed command to  <command> | tail -1 ,  so the exit code comes from the tail command.
I will address that as well.

I am closing this since it was a wrong diagnosis. Correct code will appear as a fix to https://github.com/dmwm/WMCore/issues/12075#issuecomment-2313015599
Sorry for the mess


fix(build): support building selectors as functions with glamor

see https://github.com/pluralsight/design-system/pull/957

closes #957 resolves #953


Windows msi package building improvement

CI was switched to use windows runner and full WiX toolset package.
In addition many improvements was added in wxs file:
* UI addedd
* Preserve config file during upgrades
* Service Installation
* Setting environment variables

One more question -- does this work to install via the windows CLI? I haven't been able to get it working.

One more question -- does this work to install via the windows CLI? I haven't been able to get it working.

Yes It's work but during installation required properties have to be pass. E.g.
msiexec /i ktranslate.msi /qn /l* installation.log SERVICE_TYPE=snmp NEW_RELIC_API_KEY=xxx NR_REGION=xxx NR_ACCOUNT_ID=xxx
Also installation have to be executed with admin privileges


Worker mode

Thank you for your efforts on this project!
It's an amazing idea, and I hope FrankenPHP will work well with WordPress.
I've been looking through the repository, but I'm having trouble determining if this is designed to work in worker mode.
The only mention I found of worker mode is in the Caddyfile:
https://github.com/StephenMiracle/frankenwp/blob/e05bcc3d951dc57636c87befa63357ec1350006d/Caddyfile#L7
Could you please clarify if this project is intended to function in worker mode, and if it has been tested in that environment?
I'd appreciate any additional information you can provide on this aspect of the project - the suggested value of $FRANKENPHP_CONFIG for a worker mode.
Thanks again!

Hey, due to the architecture of WordPress it's not possible to use worker mode in WordPress at all. It requires specific patches of the Request / Response lifecycles.
You can read more about that here: https://github.com/WordPress-PSR/swoole


Instructions comparation

Description
Record instructions comparations between CITA and ETHEREUM latest version.

Instruction
CITA
ETH

EXTCODEHASH
N
Y

Additional Information
#366

Close it temporarily.


can you release ? I failed to compile

can you release ? I failed to compile

A package for NixOS is work in progress.
As soon a it's available you could do on your Linux box (should work on a wide variety of distribution):
curl -L https://nixos.org/nix/install | sh
source ~/.nix-profile/etc/profile.d/nix.sh
nix-channel --add https://nixos.org/channels/nixpkgs-unstable
nix-channel --update
nix-env -i godspeed


Checking custom checkboxes

We were thinking of switching our project to use poltergeist, but many of our tests are now failing to work with our custom checkboxes.
We do the label-wrapped approach.. here's a simplified example:
<label class="checkbox"><input type="checkbox">Label Text</label>

.checkbox:before { /* custom checkbox visual */ }
.checkbox:checked:before { /* custom checkbox checked visual */ }
.checkbox input {
    position: absolute;
    width: 1px;
    height: 1px;
    margin: -1px;
    padding: 0;
    overflow: hidden;
    clip: rect(0, 0, 0, 0);
    border: 0;
}

The styles on the input are intended so that it's not technically hidden so that accessibility tools can still register it.. similar styles to what bootstrap uses for it's .sr-only class to do screen reader text.
Then our test uses the check method
check 'Label Text'

I think the issue is around poltergeist determining the x/y coordinate of what to click on, then not seeing the element there? Is there anyway to fix this or an alternate approach we could take? We considered clicking the label and a couple other workarounds but that loses the functionality of not clicking if it's already checked and it's not as elegant as the check method.

Clicking on the labels is the best option, and more accurately emulates what a user would be doing.  Losing the 'only click it if it's not set' is a bit of an issue although you should be able to work around that with a helper.  Something along the lines of
def check_label(label_text)
   label = find(:css, 'label', text: label_text)
   label.click if find(:checkbox, label_text, checked:false, visible: :all, wait: 0)
end

It's not 100% perfect and could do with passing more of the options the :checkbox selector supports through, but it'll basically do what you want.  I have been thinking of adding a way to specify the label of checkboxes should be clicked rather than the box to capybara -- maybe it'll make it into Capybara 2.7

That'd be nice if it clicked the label when the input is 'hidden' .. the screen-reader only code used to work on an old version of capybara, but I think it stopped working in 2.4.
Maybe not a best practice, but to avoid touching our dozens and dozens of test files and making hundreds of edits, I ended up just overriding the check, uncheck, and choose methods based on your feedback, @twalpole thanks!
def get_input_element(type, locator, options)
  # checkbox and radio inputs aren't visible in our codebase
  options[:visible] = :all
  # support passing in an element directly to support all(selector).each { |el| uncheck el }
  return locator if locator.respond_to?(:click)
  return find(type, locator, options)
end

def get_input_element_target(element)
  # parent should always be a label so target clicks on that
  parent = element.find(:xpath, '..')
  return parent if parent.tag_name == 'label'
  return element
end

module Capybara
  module Node
    module Actions
      def check(locator, options={})
        checkbox = get_input_element(:checkbox, locator, options)
        get_input_element_target(checkbox).click unless checkbox.checked?
      end

      def choose(locator, options={})
        radio = get_input_element(:checkbox, locator, options)
        get_input_element_target(radio).click unless radio.selected?
      end

      def uncheck(locator, options={})
        checkbox = get_input_element(:checkbox, locator, options)
        get_input_element_target(checkbox).click if checkbox.checked?
      end
    end
  end
end


Update spacing

Adjusting line height in order to improve readability on the blog.

Partially addresses #1106

We try to put all the css into styles.scss located here: gcp/appengine/frontend3/src/styles.scss.
At the bottom of that file you'll find the .blog-post-page section, should look something like this:
...

.blog-post-page {
  .post {
    ...
    p {
      margin-bottom: 16px;
// Add line height here
    }
  }
}

I think putting the line height value in p tag at the bottom would work.
I would suggest also putting it in the p tag under the .blog-post section just above:
...

.blog-page {
  .posts {
...
    .blog-entry {
...
      p {
        padding-bottom: 16px;
// another line height entry here
      }
    }
  }
}

.blog-post-page {
...

this will change the line height on the base /blog/ page where the blog summaries are listed.

@another-rex @oliverchang
Thanks for pointing me in the right direction. I am going to close this, and will open another PR editing this file tomorrow. I might include a couple of other properties besides line-height.

Also, just playing around with the values in inspect element, 1.8 line height seems pretty big, maybe 1.6 or 1.7 looks a bit better?
I'm not sure what the guidelines around this is though.


Change sidepanel logo

You are using the Nespresso logo as the sidepanel logo. RuneLite cannot distribute copyrighted material. Please change it.

Yes, was not aware of it, Will change it soon

https://github.com/EIKOOT/nyloer/commit/57a4f6dc43b7675256fac6fd2f13c303bc48f22d


Port dev branch CI to dev_2x branch

Ports the new CI workflows introduced in https://github.com/isofit/isofit/pull/421 onto the dev_2x branch. I was hoping this could be accomplished with some $ git cherry-pick operations, but it will require some manual effort.
I would also like to backport these PRs given the prevalence of a $PYTHONPATH-based install.

https://github.com/isofit/isofit/pull/422
https://github.com/isofit/isofit/pull/452

@jammont @unbohn Since the PR introduces a new GitHub Actions workflow, I think maybe a maintainer needs to allow it to run?

@unbohn Ahhhh yep – thanks!

I'm halting work on this until the tests on the dev branch are fully recovered.

Now that 3.0 is released (https://github.com/isofit/isofit/pull/479), I'm going to abandon this effort.


Set the namesapce for the istiocontrolplane CR

@sdake: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

gencheck_operator
081a269637dc1b21c9964ab2f31a6eb8abe00a6a
link
/test gencheck_operator

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Travis

There have been some discussion about setting up Travis CI in #67. I ran a small experiment in my fork https://github.com/PatrickMassot/gerby-website
It means I asked for Travis acces using https://github.com/marketplace/travis-ci and then added https://github.com/PatrickMassot/gerby-website/blob/master/.travis.yml in my fork (no other change).
After quite a bit of trial and error (waiting half an hour for each try...), the result is: https://travis-ci.org/PatrickMassot/gerby-website
Now each time I push to my fork, some remote computer (virtual machine actually) follows the steps listed in my .travis.yml file to clone your plastex fork, stacks-project, gerby-website and create the database (without search and stats because I wanted to save time when figuring out the process). The green color you see means that every step was executed without error.
There are various ways this could be useful, both in the final developing stages that you are entering and in production. In production you can imagine that each push to the stacks projects triggers the full build and deploys to the live web site if there have been no error.
Currently it also serves to document the full build process. We have all seen that blog posts and Github issue discussions can't be kept up to date. With Travis you immediately see if some change to the code requires updating the build instructions, because the Travis build fails until you correctly update .travsi.yml. Also you can guarantee that these instructions do not secretly rely on some specific setup of your computer: Travis uses a fresh Ubuntu with python3.6 install. Of course one could add configuration for MacOS or Windows.
Something voluntarily silly: the build steps include cloning again the current repo (which is done at the very beginning by Travis). This is because I wanted to document the full build process, and also because you may want to move this to another repository (stacks-project probably).

Oh, I just saw https://github.com/PatrickMassot/gerby-website/commit/9bd297bfa62df84e800bf080114d80c1d53adc78#commitcomment-27808995 My surprised had been discovered :wink:

This is awesome! Thanks a lot for doing this. Feel free to make this a pull request, for the time being it would make sense to have this running for this repository.
Continuous deployment is also an interesting idea, not necessarily for the Stacks project I think (because of stacks/stacks-history) but it could be great for other (smaller) projects.

It's really up to you what you want to do with Travis. I only wanted to help you start experimenting with this.
However there is a time limit of 50 minutes per job:
https://docs.travis-ci.com/user/customizing-the-build#Build-Timeouts
I hit the limit when trying to include search and stats. I'll PR the working one and let you play with this (maybe one can split the build in several jobs, I don't know).

You are right, it should indeed be possible to split the build into several jobs: on https://docs.travis-ci.com/user/customizing-the-build/#Build-Timeouts it says

There is no timeout for a build; a build will run as long as all the jobs do as long as each job does not timeout.

We can also try to get the PDF build in its own separate job (in particular when we are actually running Travis on the Stacks project repository, not from within this repository). None of the different steps (pdflatex, plastex, update script) should take longer than 50 minutes.


more assertions in unit tests for all

Date class a prime example. probably lots of inconsistencies with the js one as not really asserted only printed.

date class is one heck of a curve ball. I've looked at that serveral times. Btw every functions needs tests. so if you find any missing please do jump in.

output of coverage report added to discussions


Cleanup

feel free to scrutinize and reject whatever!

Also, pretty sure you're going to get this: Unable to merge dex
Should be fixed with a Clean

Nice, looks good to me. I'll merge + give it a test run.


Comment to HEAD on Actions page

Should be hooked up so it goes to /diffs, to the right file (needs anchoring), to the right base/head comparison (needs query params), to the right line (needs anchoring).

This is annoying to do without re-loading the page.


Bluetooth: Keys: Fix BT_KEYS_OVERWRITE_OLDEST logic for BT_MAX_CONN > 1

When the Bluetooth stack is configured for CONFIG_BT_MAX_CONN > 1
the oldest key might currently be in use.  Fix the logic to ensure the
oldest key overwritten is from the set of keys currently not in use.
Fixes: https://github.com/zephyrproject-rtos/zephyr/issues/35999
Signed-off-by: Faisal Saleem<EMAIL_ADDRESS>Signed-off-by: Nick Ward<EMAIL_ADDRESS>

@jhedberg thanks for reviewing so quick.  I've added a commit on top of the previous commit (to remove ASAP) to show the changes when using the bt_conn_foreach but unfortunately it didn't get rid of the #if ... use as I had to re-introduce it when building with CONFIG_BT_MAX_CONN==1to fix the warning that the foreach callback wasn't used.  I also had to create a struct to pass in the key id and to get the 'in use' bool state out.  All up line count went up by 4.   See what you think, I'm happy to go either way.

I think the core of the problem is bt_keys.aging_counter which is build-time conditional. Otherwise we could remove most (possibly all) ifdefs by converting the code to use if (IS_ENABLED(...)) { kind of constructs.

Just a follow-up not on IS_ENABLED() - when using that it's perfectly fine to have non-ifdefed static functions or variables which never get used in the end (because some Kconfig option is enabled or disabled). The compiler won't warn and they'll get stripped out of the binary. But as I said, we can't fully convert the code to follow this if there are dependencies to some build-time conditional struct members.

@jhedberg ok #if ...  use now removed and lines of code from beginning of pull request dropped by 3.  I'll repeat testing when I get a chance.

@jhedberg FYI I repeated my tests and the fix is still working.


⚠ Bofrost.es has degraded performance

In 627f7ce, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1487 ms

Resolved: Bofrost.es performance has improved in 8bbe65d after 7 minutes.


orchestrator/update: Update spec version when rolling back

There is an oversight in this code that prevents it from changing the
spec version to match the spec that's put in place during a rollback.
This could cause a service not to get rolled back all the way.
Currently, tasks may stay on the new version until they fail and are
replaced with an older version.
cc @cpuguy83 @thaJeztah

LGTM, with the caveat that I am not super familiar with this code, but it makes sense and the updated test fails without the change.


Avoid canonicalizing executables on Windows

Summary
If you have an executable path on a network share path (like \\some-host\some-share\...\python.exe), canonicalizing it adds the \\? prefix, but dunce cannot safely strip it.
This PR changes the Windows logic to avoid canonicalizing altogether. We don't really expect symlinks on Windows, so it seems unimportant to resolve them.
Closes: https://github.com/astral-sh/uv/issues/5440.

Let's give it a try.


[Fix] newline-after-import: recognize decorators

Hi, this is my fix issue https://github.com/benmosher/eslint-plugin-import/issues/1004

Coverage decreased (-3.8%) to 93.478% when pulling 950bff311742fb9b2c33c54d1580f60b2ec9b13d on atos1990:issue#1004 into 5480240b50653e4bd5ed486cf8a6db3a9020ea6c on benmosher:master.

@ljharb, done

ping @atos1990, this also needs a rebase

@atos1990, please rebase

Came here looking for this fix. ETA on merge? With this rule not working with decorators, it pretty much means it won't work with any of my ts files in Angular, which is the only thing I'm using ESLint for.

thanks @ljharb

We continue with this error in the latest version, I am thinking that the next version could contain this fix, is it right?

Yes.

@skoblenick as you can see if you click on the commit that closed the PR, it is in both main, and every version v2.21.0 and later.


TypeNotFound when using classes

Steps to reproduce
class SecretComparer : System.Collections.IComparer {

    [int] $ChangeInDays = 7

    [bool] ShouldChangeSecret() {

        #throw "method not implemented"
        return $true
    }

    # this will compare if the secret is same
    [int] Compare([object] $obja, [object] $objb) {

        throw "method not implemented"
    }

}

using module .\Clarksons.Scripts.PlatformEngineering.DevsKeyVault.SecretComparer.psm1

class KeyVault {

    [string] $KeyVaultName

    KeyVault([string] $KeyVaultName, [SecretComparer] $comparer) {

        write-host $comparer
    }

}

$t = [SecretComparer]::new()
$x = [KeyVault]::new('gfdgfd', $t)

Expected behavior
This message should not appear as I'm loading classes into the sessions

Actual behavior

If an unexpected error was thrown then please report the full error details using e.g. $error[0] | Select-Object *
Environment data

> $PSVersionTable
Name                           Value
----                           -----
PSVersion                      5.1.14393.693
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.14393.693
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>

> (Get-Module -ListAvailable PSScriptAnalyzer).Version | ForEach-Object { $_.ToString() }
1.17.1

This is by design and a limitation of the PowerShell parser. In the future, we should address #1041 though and return a warning instead of a diagnostic record for Parser exceptions. cc @rjmholt

Apols if this is a simple answer but how do I get around this in vscode? Right now I have several dozen green files in an otherwise clean powershell library due to this issue. I simply want to stop the files being displayed as having problems.

@abelal83 This is what issue #1041 is about: Currently those warnings cannot be suppressed other than filtered out via command line. Previously, PSSA failed completely, hence why it was decided to accept graceful parser errors but still display them as warnings to the user that only a part of the script could be analysed due to the limitation of the parser (PSSA completely relies on the parser in order to do its work). In hindsight, it was a mistake to return an object, which is being displayed as an issue in VSCode instead of just returning a warning and let VSCode deal with the display of the warning.

@bergmeister gotcha, thank you for explaining.


[SR-3378] Replace deprecated methods test/stdlib/NSStringAPI.swift

This PR replaces usage of the deprecated methods addingPercentEscapes(using:) and replacingPercentEscapes(using:) in test/stdlib/NSStringAPI.swift.
Resolves SR-3378.

attn: @parkera

@swift-ci please test

Looks good thanks.

@gparker42 @parkera polite ping
Anything you need from me before this can be merged?

I'll do another smoke test just to make sure it didn't regress and then merge for you.

@swift-ci Please smoke test


[🚩esl-share]: final follow up

Closes: #2012
Contains next points:

fixed deduplication behavior on selecting buttons from config
fixed visual issue with displaying a huge list of share buttons in a popup
added ready state attribute and ready state event
revised observed attributes
retired esl-share and renamed esl-share-popup-trigger into esl-share
added ExportNS using
added support types for correct use in Typescript

:tada: This PR is included in version 4.14.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Support colons as a VT parameter separator

Environment
Windows build number: Microsoft Windows [Version 10.0.19041.21]
Windows Terminal version (if applicable): 0.8.10091.0

Any other software?  WSL, Ubuntu

Steps to reproduce
I have TERM set to xterm-24bit using the standard termconfig instructions that are online.  Running emacs in terminal mode (emacs -nw) and then using M-x list-display-colors
Behavior (windows terminal on the left, wsltty on the right)

In both cases, emacs knows about all 500+ colors available, but wsltty shows them and windows terminal doesn't.  Also this has been like this for a couple months at least, but now it's bugging me enough to ask for a fix. :)

I'm working on this. First step is #7220, and the additional delta over switching the VT engine to it is +/- 26/2 lines (not accounting for tests). :smile:

Since I don't see it mentioned anywhere here, ansi-vte52.sh briefly demonstrates the ITU-T T.416 forms of SGR 38 and SGR 48, including an incorrect form of the truecolour specification (where the colourspace ID was missed) apparently originating from the KDE konsole application.

This is an important feature, hopefully it can get some attention.  As long as popular terminals don't support the correct syntax it incentivizes everyone to continue building with and relying on the broken syntax.
To be honest, it probably should have gone in before 1.0 was declared to minimize the damage.  Windows has an oversized influence and so a greater responsibility, just like Spider-man.  ;-)

I'd love to see this happen soon-ish. I have a bunch of in-house tools that have to support both fancy (256 / truecolor) and limited (16-color only) terminals, and the lack of support for the : separator means Windows Terminal doesn't get full colors.
I can safely use the \e[...;38:2:R:G:B;...m form and the truecolor part will be ignored as a single unknown control sequence by the old 16-color terminal. But if I were to use ; as a separator, it will instead interpret it as 5 separate control sequences, and then ignore those that it doesn't recognize and interpret the others, and then I end up e.g. with blinking inverted text and stuff like that.
I can't just detect the terminal type, as large parts of the output are static text files that have been pre-generated. (And I can't justify re-architecting that just for Windows Terminal.) So I'm stuck with only using : as a separator, and effectively only getting 16 colors on Windows.

I can safely use the \e[...;38:2:R:G:B;...m form and the truecolor part will be ignored as a single unknown control sequence by the old 16-color terminal.

@229c9cf0 Just FYI, there are terminals out there that will simply echo the sequence parameters to the screen when they encounter a colon in an escape sequence, so it's not really that safe. Also, the "correct" syntax for the colon format is actually 38:2::R:G:B. Some terminals support both colon variants, some only support one or the other, but everyone seems to support the semicolon syntax (assuming they support true color at all).

And I can't justify re-architecting that just for Windows Terminal

I don't know what your target audience is, but in case you aren't aware, Windows Terminal is by no means the only terminal that doesn't support the colon syntax. You can get a general idea of the level of support at this website: https://gist.github.com/XVilka/8346728. But note that it's not always correct, so it's best to confirm for yourself. For example, I'm pretty sure that Konsole doesn't support colons, while more recent versions of Alacritty actually do support colons now.

You can get a general idea of the level of support at this website: https://gist.github.com/XVilka/8346728. But note that it's not always correct, so it's best to confirm for yourself.

Updates for that Gist now go to https://github.com/termstandard/colors, and they also take PRs to fix out of date or wrong info.

Thanks so much for doing all this work! I'm really excited to dig into your PR.


Autoamted test: Custom MAC on ovs-cni (multus) interface + fixes.

Included in this PR:

Autoamted test: Custom MAC on ovs-cni (multus) interface.
Refer to the correct DaemonSet, so automated multus tests won't be skipped anymore.
Fix test ID's to the correct label.
Fix NodeAffinity usage, so VM's will be created on computre node rather than on master.
Fix RFE ID of L2 netowkring tests (used to be network policy RFE).

/release-note-none

@yossisegev can you please rebase this PR?

@SchSeba The CI fails on the quemu guest agent Multus test, which is not something I modified in this PR, and is a known issue which was already discussed in the network sync.
Can you please CR so I can merge it? Thanks.

ci please test

for reference https://jenkins.ovirt.org/job/kubevirt_kubevirt_standard-check-pr/3606/artifact/ci_build_summary.html
looks like there is a problem with fedora repo, lets try to run the tests again.

ci tests please

ci please test


Pasting links on Android still doesn't work (since 1.5.0 update).

The previous issue has been closed, so I'm not sure if it shows the replies, that's why I'm opening it again.
Actually, the new update (1.5.2) didn't help with Android, still doesn't paste anything at all.
I did manage to run developer console for android, here's the error when I try to paste a link to obsidian, maybe it'll help you somehow. It's the same error regardless of the new option enabled or disabled.
Below is the log with the error from the console.
localhost-1705223419935.log

Thank you very much for the log!
Looks like the crypto module doesn't work on Android so I've reverted back to my old manual method of generating the hash.
Can you confirm that the new version fixes it for you?

Now it works. The new scraper method shows "site unreachable", but with this option turned off it works perfectly, thanks :)

Tested and works fine with the "legacy" method, thank you for update, @zolrath !
Super keen on testing crypto module someday if you'd like to fix it someday for mobile (on PC it works great!)

Glad to hear it works, and a bummer to hear that the new scraping method is also unavailable on mobile as it's an Obsidian API, was hoping it would work on all devices.
Thanks for the confirmation!


style: Cancel the io/outil libraries used in the project and switch to using native methods of os and io libraries

What type of PR is this?
style
Check the PR title.
Cancel the io/outil libraries used in the project and switch to using native methods of os and io libraries
(Optional) Translate the PR title into Chinese.
取消项目中使用的io/ioutil库, 变更为使用os及io库原生方法
(Optional) More detailed description for this PR(en: English/zh: Chinese).

en: Cancel the io/outil libraries used in the project and switch to using native methods of os and io libraries
zh(optional): 取消项目中使用的io/ioutil库, 变更为使用os及io库原生方法
(Optional) Which issue(s) this PR fixes:
unknown
(Optional) The PR that updates user documentation:
unknown

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@miajio PR title 使用英文，格式参考其它已经合并的 PR；点击上述链接签署下 CLA 协议。

@miajio 还没有签署 CLA


Memory Leak on hands function?

Have I written custom code (as opposed to using a stock example script provided in MediaPipe)
Yes
OS Platform and Distribution
Windows 10
Mobile device if the issue happens on mobile device
No response
Browser and version if the issue happens on browser
No response
Programming Language and version
Python
MediaPipe version
0.10.5
Bazel version
No response
Solution
Hands
Android Studio, NDK, SDK versions (if issue is related to building in Android environment)
No response
Xcode & Tulsi version (if issue is related to building for iOS)
No response
Describe the actual behavior
Hands recognitions goes to memory leak (out of memory)
Describe the expected behaviour
Take the landmarks
Standalone code/steps you may have used to try to get what you need
Hi, i'm trying the basic example of mediapipe hands recognition with opencv code on

My code is basic:

import cv2
import mediapipe as mp

mp_hands=mp.solutions.hands
mp_drawing=mp.solutions.drawing_utils
webcam = cv2.VideoCapture(0,cv2.CAP_DSHOW)
while webcam.isOpened():
    success, img = webcam.read()
    img=cv2.cvtColor(img,cv2.COLOR_BGR2RGB)
results=mp_hands.Hands(max_num_hands=3,min_detection_confidence=0.7,min_tracking_confidence=0.6).process(img)
    img = cv2.cvtColor(img, cv2.COLOR_RGB2BGR)
    cv2.imshow('Test', img)
    results=[]
    print("passo")
webcam.release()
cv2.destroyAllWindows()

Unfortunately the ML line results=mp_hands.Hands(max_num_hands=3,min_detection_confidence=0.7,min_tracking_confidence=0.6).process(img)
creates an increase of the memory usage from some MB up to 32 GB.
Where I'm doing it wrong?

Other info / Complete Logs
No response

@thecas89-teacher,
You are currently utilising the legacy MediaPipe hand solution, which is no longer maintained by our team. We kindly advise you to refer to our guide, where it is indicated that the hand solution has been upgraded to the new Hands API.
We earnestly request that you transition to our new Hand Task API as outlined in the provided documentation here. Additionally, you can find a code example in the same resource for your reference. Also, we request please report back if you observe similar behaviour in the upgraded task API. Thank you


Most recent update broke slash sweeper

At least for me. Just doesn't work currently

It seems to work fine for me.
/ -> clan chat
// -> friends chat
if you enable "Swap Guest Chat" it will behave different and send to guest chat on / and // on friends chat

yea dunno what happened but i rebooted rl/reinstalled and seems to work fine now. dunno what was up


feat: transform v-if into ternary expression

Codecov Report

Merging #61 (5908e5c) into master (1eb5011) will increase coverage by 0.07%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##           master      #61      +/-   ##
==========================================
+ Coverage   58.38%   58.46%   +0.07%
==========================================
  Files          42       43       +1
  Lines        2857     2884      +27
  Branches      926      938      +12
==========================================
+ Hits         1668     1686      +18
- Misses       1189     1198       +9

Impacted Files
Coverage Δ

...es/compiler-tsx/src/transforms/transformElement.ts
52.13% <0.00%> (-5.13%)
:arrow_down:

...ackages/compiler-tsx/src/transforms/transformIf.ts
88.46% <88.46%> (ø)

packages/compiler-tsx/src/index.ts
88.13% <100.00%> (+0.20%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fde529...d7986ca. Read the comment docs.


Detect if an application is in use before updating

The request
It would be beneficial to avoid updating an application if it’s currently running to prevent unexpected closures. For instance, if a user is in a Zoom meeting and the update initiates, the meeting could be unexpectedly closed. One workaround for this would be to check if the application process is running, and if it is, skip the update for that specific program. Process names could be manually populated in a separate ".txt" file, or the "included_apps.txt" file could be utilized in conjunction with the applications’ IDs.
Is your feature request related to a problem?
I tested several apps listed in the ‘included_apps.txt’ file using Intune deployment. All the apps, except for 7-Zip, were closed during the update process, which was not ideal.

Additional information
No response

Idea

Process names could be manually populated in a separate ".txt" file, or the "included_apps.txt" file could be utilized in conjunction with the applications’ IDs.

An interesting idea, but full implementation is economically unfeasible within WAU.
Let me explain why (I will elaborate further, perhaps someone will come back with this idea one day when the winget reaches the maturity that allows it).
Problem with consistency of data relations
WAU is a "wrapper" on top of the winget.
Winget itself is a wrapper on top of random setups using various technologies.
Sometimes those setups are wrappers themselves (F.ex. Oracle JRE pre-8u402).
The solution would require a connection of a consistent and unambiguous package ID relationship with the metadata of the final setup.
Missing connection in schema
Let stake a look at the Zoom.Zoom case. The manifest file of the manifest of the latest version is there:
https://github.com/microsoft/winget-pkgs/blob/master/manifests/z/Zoom/Zoom/<IP_ADDRESS>859/Zoom.Zoom.installer.yaml
There is no information which could allow anyone to link package ID of any given package (operation level of WAU) with INSTALLDIRs (operation level of setups which kill processes).
INSTALLDIRs are not be defined in manifests, but are internal and individual logic of each setup. Each vendor has own idea how to manage those. Often defined using various parameters even stored under different names in the registry.
As of now there is no place for such data in the official YAML schema.
If metadata with information about where processes are to be killed is not provided by the manufacturer, it will be reactive tilting at windmills, at best.
implementation (system solution)
WAU could be expanded to look for such list, in WYSIWYG form, most likely an empty file + readme instruction how to fill it by You.
User may be greeted with a popup asking him/her to allow installation, that would be an another WYSIWYG generic "one-size fits all" solution. Customization of UX most likely would not be permitted. In the end most likely You would be forced to write your own popup routine anyway.
example
In a company I work for, each new application package has that metadata field populated manually. and each installation is preceded by a "selective process killer" task which does exactly that, terminates processes in defined paths.
If process is evaluated as business critical, then users are given a choice to postpone the install/uninstall a couple of times before action is finally enforced and the process(-es) is/are killed.
That is a completely custom solution written in PowerShell and triggered via task scheduler just like the Toast notification.
You may find a better one, more suitable to your needs.
implementation (user-side actions)
If such TXT file would be maintained outside of automated process on GitHub, then consistency would have to guaranteed by You.
extra workload/maintenance/support of such feature
For individual consideration:
Who would maintain something like this if not the sellers/manufacturers themselves?
If WAU kills/doesn't kill/kills the wrong processes, who will be at fault?

WAU maintainers?
A manufacturer who changed his path because he could?
IT support in the company where the incident occurred?

hopefully a wrong prediction
if everything is automated, what's the point of keeping us as software delivery specialists?

In addition, you can still use MODs to customize a bit more your WAU implementation.
By experience, a lot of apps are always running (or even start with Windows). If you implement this, it will be similar to put these apps in the blakclist.
From my point of view, I hope one day to have the program to "close if running" inside the Winget manifests. This way, it would be easier for us to propose a manageable solution to force the kill or prompt user to close the app for instance.


Look over TravisCI integration

The .travis.yml file is basically just a copy of the AlamoFire one right now. A lot of builds seem to be passing when they shouldn't. This needs to be fixed ASAP.

 Review Travis CI integration


leaflet-controls flashing

I want to describe the situation of leaflet-controls flashing with a lot of downloaded layers in Google Chrome. Demonstration of this effect on the video below
Look video example for leaflet 1.2.0
Look video example for leaflet 0.7.7
In the test application, the flashing occurs at 100 or more layers. But in a real application (connection via rdp), blinking can occur with 10-20 added layers.
Code

sorry for the music in the videos

I can confirm this bug and have additional info:

It stably reproduced in Chrome for Windows versions from v52 to current v62 (tested on different PC), it never happens in IE and FF.
This trouble could be reproduced on any PC just with 10-15 layers when Chrome setting 'Use hardware acceleration when available' is disabled (on modern office desktop PC with integrated Intel GPU on board). Without accelaration 50 layers caused all map controls to disappear from screen at all.

I have the same issue with leaflet v1.3.3.
In a Chrome v63 the controls flash and fade out when loading layers.
In Firefox it runs without problems.
Any news or workarounds about this problem?

I also have this problem. If I have more layers on the map in Chrome controls are flashing, but in Firefox in the same case everything works well. What can we do to resolve this issue? Help us, please.

I also have this problem. If I have more layers on the map in Chrome browser Leaflet's controls are flashing, but in Firefox in the same case everything works well. What can we do to resolve this issue? Help us, please.
When I open "Rendering developer tool" (Ctrl+Shift+P and find "Show rendering" option) and check option "FPS meter" I see that the consumption of GPU is very high - in my case 512 MB/512 MB. Maybe should we try going this path? Is any possibility to limit this consumption?

We've found a solution. When tiles are not <img> elements, but rather are drawn on the canvas, GPU memory consumption looks much better. We've prepared package for this. You can check it here - https://github.com/GIAPspzoo/L.TileLayer.Canvas. I hope it'll help you.


fix: bigint builtins are foreigns

Description
Problem*
Resolves #6594
Summary*
I just changed the attribute, foreign and builtin are handled almost identically.
Additional Context
Documentation*
Check one:

[X] No documentation needed.
[ ] Documentation included in this PR.
[ ] [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

[X] I have tested the changes locally.
[X] I have formatted the changes with Prettier and/or cargo fmt on default settings.

We needed to take on some tech debt with this fallback handler here: https://github.com/noir-lang/noir/blob/b23e85bfbff4192d228bcaae4421d6cdfa5614f2/compiler/noirc_frontend/src/hir/comptime/interpreter/builtin.rs#L239-L241
We should remove this in this PR to make sure that we've got all of the instances of this issue.

We should remove this in this PR to make sure that we've got all of the instances of this issue.

Done

I dont't understand why CI is failing on some boundedvev doc that is not modified here, but anyways I fixed the typo in the doc.

I dont't understand why CI is failing on some boundedvev doc that is not modified here, but anyways I fixed the typo in the doc.

Thanks, I think this got affected by the release PR which got merged.


Add instructions to install WSL in other than C Drive

Currently, some contributors want to install WSL in the D drive instead of the default C Drive. Add instructions to make it simpler.

Hey @U8NWXD , I would like to take this issue.
We can achieve the solution by:
To install the Windows Subsystem for Linux (WSL) on a drive other than the C drive, you will need to perform the following steps:

Open the PowerShell as an administrator and run the command:

  dism.exe /online /enable-feature /featurename:Microsoft-Windows-Subsystem-Linux /all /norestart

This command enables the Windows Subsystem for Linux feature on the running operating system without restarting the system, allowing the user to use Linux environments and commands within Windows.

Create a new folder on the drive you wish to install WSL on. For example, if you wish to install it on the D drive, you can create a folder called "WSL" in the root of the D drive.

Open the Microsoft Store and search for the Linux distribution you wish to install (e.g. Ubuntu).

Install the Linux distribution to the folder you created in step 2. This will set the distribution's root filesystem to the folder you created.

Once the installation is complete, launch the distribution from the Start menu to finish the setup process.

You should now be able to use the distribution as if it was installed on the C drive.
Note: It's not recommended to install WSL in other than C Drive, as it may cause some issues with system files and software compatibility.

@Patel-Muhammad Thanks! I'm checking with some people more familiar with WSL to see what they think

@U8NWXD thank you for considering.

@aks681 uses WSL, so I'm letting them review the proposed solution

Hey @Patel-Muhammad. Thanks for the info, couple of comments:

Can you detail how to change directory when installing from Store? Since, I think that automatically installs to C as well.
Have you confirmed this works, and any caveats for this process? You mentioned some issues, any examples?

hey @U8NWXD @aks681 @gp201 i was also using wsl before, now I switched to ubuntu tho.....I know the solution so kindly assign me this issue.

open PowerShell as Administrator: Right-click on the Start menu, select "Windows PowerShell (Admin)."
Run the following command to set the default installation drive for WSL:
wsl --set-default-location <drive_letter i.e. D>:
3)After setting the default installation location, we can proceed to install WSL using our preferred Linux distribution
4)Once the installation is complete, initialize the newly installed distribution by running it for the first time.

@vaishnavi192 Can you provide a video/documentation link showing that it worked

hey @gp201 idky but My microsoft store is not working rn in windows(hanging). And btw I thought we have to download ubuntu. So, those instructions won't work sorry. Today I read about this article https://dev.to/mefaba/installing-wsl-on-another-drive-in-windows-5c4a
According to this we can't directly change the location and download wsl(I checked in other websites also)... we have to export it in other drive with given commands.

@vaishnavi192 That's unfortunate. If someone is able to test it, we can include it in the wiki. This is to guarantee that all commands we instruct developers to execute are verified by us.


Constrain integration tests with build tags

Currently we have many test targets like mixer-test galley-test and then combine them with test. This adds reliance on our makefiles, rather than standard go tooling (go test ./galley/...). Additionally, I think its a bit slower since it isn't properly parallelized
I suggest we instead add build tag to integration tests:
// +build integ

Then to run these tests you would run go test -tag=integ. To run all unit tests, you can just run go test ./..., and avoid makefiles. Any thoughts?

Pros:

Would like to see a tag for those tests that don't alter the control plane (can be run with --istio.test.kube.deploy=false). This might help with running tests on immutable infrastructures. So maybe we could publish a set of common tags.

Cons:

Removes the running of tests from the makefile which means that one would do a make shell and then run the tests there, or run them locally outside the build container. Does this make it a little more complex?

Removes the running of tests from the makefile

We can still keep them if we want. This just makes it more flexible for people using go test directly. Also you can do ./common/scripts/run.sh go test ./.... But for the most part I think all unit tests work on pretty much all platforms? Maybe some of rthe envoy ones do not on osx though


Record revisions: multi-value field tracking doesn't track additions correctly

Steps to reproduce

I have an ingredient multi-value string field
I added 3 values (fruit, pineapple, cake) and then edited the thing with adding sprinkles
The old column should be fruit, pineapple, and cake while the new column should be sprinkles, fruit, pineapple, cake (I moved the newly added sprinkles to the top)

Screenshot with values

Server-side everything is fine; the issue is how the data is displayed in the revisions table

Fixed
What
fixed invalid record revision history for multi value fields.
The first value appeared duplicated, the last value was omitted, and when a value was removed the value was no longer visible in the old version.
Refs
Monorepo

2022.9.x commit b203224df

Tested and confirming that this now works as expected.


Do not fail if logs folder does not exists

This patch makes sure that the log output folder exists so
that the script does not die silently when starting tiller with logging
without the logs folder existing.

Thank you for the PR 👍


Android build error

Hi, I can't build on andorid and error on "LineAccessToken" ( LineLogin.java line53)
please add "import com.linecorp.linesdk.LineAccessToken;" into LineLogin.java
thanks!

Please tell me the development environment and version of various tools.

Tools:
CLI: Command for windows10
IDE: vscode 1.26.1
Device: Android phone

cordova -v
8.0.0
cordova create CordovaLineLogin
cordova plugin add https://github.com/nrikiji/cordova-line-login-plugin.git --variable LINE_CHANNEL_ID=xxx

cordova plugin
cordova-line-login-plugin 0.3.3 "Line Login"
cordova platform add android
Saving<EMAIL_ADDRESS>into config.xml file ...

build on vscode with android device.
It's work for me when I edit java file.thanks!

Thanks. Is this issue settled?
In my mac environment it did not reproduce with cordova 8.
Is it specific to windows?
Please tell me if there is a solution.

I am not sure, because I am not an Ionic project. And my solution is just to add that code.
If there is no problem, maybe I am a special case.


Fixes erroneous closing behavior in JtaConnection.java

Consider the use case where a method is annotated with jakarta.transaction.Transactional and close() is called on a Connection obtained therein. close() in this case should not actually close the Connection at that very moment, but closing should happen after the completion of the transaction. The prior version of this class was OK on the first point, and butchered the second point, so these changes fix the behavior. Note that the JtaConnection class is not currently used in Helidon, but will be soon.

@tjquinno I've incorporated your suggestion to bake an explicit state model into ConditionallyCloseableConnection without changing existing signatures etc. and without disturbing existing test behavior. While the change was a bit hairy for me to implement I greatly prefer it, so thank you for the suggestion. I'll resolve the other discussions above.

@ljnelson Please add link to corresponding issue


Add privacyheroes.io to tosdr data

Reviewer: @MariagraziaAlastra

Description:
Add entry for privacyheroes.io to tosdr data.
Steps to test this PR:

npm run dev-chrome
Navigate to privacyheroes.io
Open pop up, privacy practices should now appear there.

Automated tests:

[ ] Unit tests
[ ] Integration tests

Reviewer Checklist:

[ ] Ensure the PR solves the problem
[ ] Review every line of code
[ ] Ensure the PR does no harm by testing the changes thoroughly
[ ] Get help if you're uncomfortable with any of the above!
[ ] Determine if there are any quick wins that improve the implementation

PR Author Checklist:

[ ] Get advice or leverage existing code
[ ] Agree on technical approach with reviewer (if the changes are nuanced)
[ ] Ensure that there is a testing strategy (and documented non-automated tests)
[ ] Ensure there is a documented monitoring strategy (if necessary)
[ ] Consider systems implications

👍


Delete CONTRIBUTING.md

What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:

Closing since not a valid PR. CONTRIBUTING.md is useful for new contributors.


Issue/21 user friendly parameter definition

Hey, please check out my implementation. Especially the DWDRequest needs still improvement for a better logic. However so far this could already work in a good manner.

I'll continue working in the

I'll overhaul thhe definition of the request in the upcoming days.


Add  gethrtime() and dummy getrlimit() setrlimit(), add some dependency

Summary
Add  gethrtime() and dummy getrlimit() setrlimit(), add some dependency
Impact
Testing

Could you please also add documentation for gethrtime in "clocks & timers" user reference page of the Documentation?

@v01d done

You will have to rebase since we merged something that conflicts with this.

Please have a look at the CI failure

@v01d done


Add FAQ about why the recommended distributions

ssd_dists_bcanz()
[1] "gamma"       "lgumbel"     "llogis"      "lnorm"       "lnorm_lnorm" "weibull"

distributions vignette updated with additional details


Always show window on first startup after being installed

Yes, that's the expected behavior, but probably it's not what everyone wants.
So I found the BrowserPicker a few minutes ago and wanted to at least look at it, but I had my browser open with some livestreams going etc., so I didn't want to close my browser yet. Double clicking the executable doesn't work either.
Had to look at the code to figure out how to do this, so I found a workaround:
I made a new DWORD (32 bit) value that is set to 1 in HKEY_CURRENT_USER\Software\BrowserPicker .
Can we please make some FAQ section to readme or add wiki for the project and mention this somewhere? Or even better, explain all registry keys that BrowserPicker uses.

Clicking the executable is supposed to bring up the UI for configuration, I guess it must have broken at some point without getting caught. The installer is also supposed to put a shortcut in the start menu, but it seems that to has been broken?

This bug should be resolved in the upcoming 1.7 and 1.8 patch releases.

I just reread the issue and now realize I misread the original issue.
The bug where it was not showing up when started without a URL has been fixed, but your actual inital suggestion has not.

Maybe throw in a short "welcome" introductory message with some tips?

Not doing tips now, but I added a new issue for that if someone wants to contribute something at some point.
Starting from the next version, the first time the application is started by the user, it will now show the configuration window with a small welcome message being displayed.


teachR cheat sheet should use proper Bloom's Taxonomy objectives

I came across the teachR cheat sheet because I wanted to get to the tidyr cheat sheet and I avoided reading the filename. I believe that this cheat sheet needs some attention because many modern courses on R are tailored towards the taxonomy categories "create", "evaluate" and "analyse" rather than the other end. This also goes for the books on r4ds, tidytextmining, and ggplot2. Since this is particularly good practice for novices, the teachR cheat sheet should not propagate otherwise. From this viewpoint the related objective should be rephrased to "Learners will integrate the principles of reactivity while building a simple application", which translates "integrate" to 4.1/4.2 (Analyse+Differentiating/Organising) and "build" to 6.3 (Create+Produce) within Bloom's Taxonomy.
The cheat sheet also contains a colourful triangle. It states next to it "Bloom's Taxonomy". I know the triangle is taken from  https://cft.vanderbilt.edu/. Yet, it is strongly discouraged to use the triangle visualisation for the "Taxonomy for Learning, Teaching, and Assessing" (Anderson et al., 2001). In fact, none of the five original books on the Taxonomy contains, mentions or even suggests any triangles. On page 90f of the abridged edition of Anderson et al. (2001) it is made very clear that a unit of learning at any level is not constrained to one certain set of categories but can span across the entire board. I assume that the triangle relates to the origins of other "learning triangles" as reported here: https://www.tandfonline.com/doi/full/10.1080/2331186X.2018.1518638
If a triangle must be used then it should be upside down because the Taxonomy consistently refers to the "create" category for the most complex cognitive processes and remember for the least cognitively demanding activities. Please note that greater cognitive complexity means more effective learning.
Moreover, the arrows into the graphic are really irritating as they are pointing to "understand" and "apply", while they really should point to "analyse" and "create", as such learning objective is really proven by analysing and creating something. I know that the words used in the objective show up at these levels in the triangle diagram, which leads to another reason why this diagram should not be used: Several of the terms shown in the triangle do not appear in the Taxonomy. Instead variants of describe and demonstrate appear across all Taxonomy categories (btw. this is also elaborated and visible on the page that has the triangle at the beginning).  Really, the triangle is very much not helpful.
A proper learning objective for the levels on the  cheat sheet would be "Learners will explain the key principles of reactivity and use the related functions for extending an existing application". Oof this does not come easy. Strictly speaking this is already half way in "creating" or "evaluating" in terms of the Taxonomy. The category "apply" of the Taxonomy is not very helpful for objectives for programming skills, although it sounds so much like "application". I would use this category at best for objectives such as: "Learners will use the t-test for accepting or rejecting hypotheses using normally distributed data", which would be a category 3.1 objective (Apply+Executing).

Since this is a contributed cheatsheet from @adisarid, you might be better off discussing it directly with them. https://github.com/adisarid/cheatsheets

Thanks @phish108 for these insightful comments.
If you want, you are more than welcome to apply these to the original, downloadable here, send it and I can issue a PR  with an update to the current version.
The triangle is not necessary, but perhaps it is advised to illustrate the taxonomy in some other way. What would you suggest?

I close this for now and return to to it on the other repo.


Only Works In Incognito Mode

I can't explain this. All CORS requests to log.php work perfectly fine, but loghandler.php returns "Failed to load resource: net::ERR_BLOCKED_BY_CLIENT". And there are a looooot of requests made to loghandler.php. Because push notifications are basically the same thing as making a lot of consecutive requests to the same file, right?
Please don't answer that.

I've found an easy fix: update from PHP 5.6 to [any other language please for the love of god]. Should fix the problem; works just find on my machine with such change.

Are the file permissions the same?

@AdrianVovk 777 on both lol

Update: apparently it works perfectly fine on mobile Chrome. It's just on desktop that it doesn't work. Haven't tried any other browsers yet :P

Update (again): so I tried using the website with a different (simpler) php file on the same server under the same circumstances... and it works fine. I really cannot think of a reason that could cause an issue with one php file, while other php files on the same server with the same permissions work fine, and still be dependent on which browser (or incognito window) you're using. The CORS request should be exactly the same regardless of whether it's from an incognito window or not, right? :P

Just FYI I'm not legitimately trying to fix this, as far as I'm concerned this website deserves to be sent to the inner depths of the giant internet wormhole, but I am somewhat curious why this happens because I'm completely unable to comprehend anything that's happening here.


Flow-typed libdef for v4

Hello. Can you add flow definitions for version 4?

We don’t maintain external flow types for the library. Feel free to
recreate your issue or help out over at flow-types.
On Wed, Nov 7, 2018 at 2:11 PM Aleksei Kosianenko<EMAIL_ADDRESS>wrote:

Hello. Can you add flow definitions for version 4?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/styled-components/styled-components/issues/2194, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAiy1kat7JNJlYLFfV4fOkTnGIie3jOZks5usz5xgaJpZM4YTJvC
.


Can not use custom sentence for QG

Problem
Hi. I want to try the QG using decode_seq2seq.py. It works when I try use the sample data. But when I use another data, it encounter Key Error: 'H.E.
Note

I use BERT-LARGE-CASED
It will success if I remove that word, and error with another 'weird' word.

Question

Is the decode seq2seq will match each the input word with a BERT LARGE CASED vocab?
How to preprocess the text before decode seq2seq? any guidance for preprocessing?
I also read similar issue from pytorch-bert-transformer https://github.com/huggingface/transformers/issues/63 ?

Terminal Output
File "/root/code/unilm/src/pytorch_pretrained_bert/tokenization.py", line 117, in convert_tokens_to_ids
    ids.append(self.vocab[token])
KeyError: 'H.E.' # or another weird word

I think the problem is caused by the tokenization. The training examples should be tokenized as follows:
    tokenizer = BertTokenizer.from_pretrained(
        args.bert_model, do_lower_case=args.do_lower_case)
    r_list = []
    for idx, line in enumerate(chunk):
        tk_list = tokenizer.tokenize(line)
        r_list.append((idx, tk_list))

For example, the sentence Who did the Panthers beat to become the NFC champs ? is tokenized to
Who did the Panthers beat to become the NFC ch ##amp ##s ?, so that all the tokens are in the vocabulary.

Hey @donglixp,
I also see lsb and rsb tokens. So any source text like a paragraph needs to be StanfordTokenized then passed through BertTokenizer?

Hi @aretius ,
If you would like to directly run the provided fine-tuned checkpoint, the same preprocessing pipeline is recommended. For custom fine-tuning, other toolkits should also work as long as both fine-tuning and inference use the similar input formats.


Polygon2d.contains() returns false for a clearly true result

For a polygon with 4 points as shown below, the point (1,-3) is given as not contained.
                                          (1000,1)
(0, -1)
         (1,-3)---->                      (1000,-3)
(0,-5)

For each line segment, the method checks whether it intersects with a line from the point that is tested towards the right (---->). This is tested using 4 conditions:

y >= Math.min(prevPointY, curPointY)
y <= Math.max(prevPointY, curPointY)
x <= Math.max(prevPointX, curPointX)
prevPointY != curPointY

Condition 3 checks that the intersection is indeed of a line towards the right. The 4th conditions checks that the intersected line segment is not on the line towards the right. The first two conditions check for an intersection solely by y-coordinates (which is possible due to the horizontal line we check).
The first two conditions will hold true for two consecutive line segments if the shared point by the line segments is where the intersections are found. This happens in the example, at exactly y = -3. The intersection counter is thus increased by 2, while there is actually only 1 intersection. In my estimation, this would be solved if '=' is removed from either condition.
This issue was revealed by LaneTest.contourTest() in OTS.

Found the cause. There was a "<=" in the contains code that should have been a "<". Added a unit test for this issue to ensure that we can't accidentally re-recreate this bug.


Comes up without sshd when run_command: /sbin/init

Data: https://gist.github.com/jordansissel/dc98a4684b2b07b5a3a8
kitchen converge ... ends up looping saying:
       Waiting for <IP_ADDRESS>:49168...
       Waiting for <IP_ADDRESS>:49168...
       Waiting for <IP_ADDRESS>:49168...

Seems like forever, so I checked the docker container:
% docker exec $(grep container_id .kitchen/default-ubuntu-1404.yml | fex 2) ps -ef
UID        PID  PPID  C STIME TTY          TIME CMD
root         1     0  0 06:25 ?        00:00:00 /sbin/init
root        23     1  0 06:25 ?        00:00:00 @sbin/plymouthd --mode=boot --attach-to-session
root        29     1  0 06:25 ?        00:00:00 plymouth-upstart-bridge
root        32     1  0 06:25 ?        00:00:00 mountall --daemon
root      2893     0  0 06:27 ?        00:00:00 ps -ef

Thoughts?
If I docker exec ... to start sshd manually, things work ok.

% kitchen version
Test Kitchen version 1.3.1

While kitchen converge is waiting, if I do this in another terminal, it recovers quickly:
% docker exec 758a5f693186 /etc/init.d/ssh start
 * Starting OpenBSD Secure Shell server sshd
   ...done.

I may be a bit lost also. In an effort to try and reproduce this reliably, I destroyed all containers and images (docker rm + rmi). kitchen converge default-ubuntu-1404 now fails differently, and earlier:
% kitchen converge default-ubuntu-1404
-----> Starting Kitchen (v1.3.1)
-----> Converging <default-ubuntu-1404>...
       Preparing files for transfer
       Preparing dna.json
       Berksfile, Cheffile, cookbooks/, or metadata.rb not found so Chef will run with effectively no cookbooks. Is this intended?
       Removing non-cookbook files before transfer
       Preparing solo.rb
       [SSH] connection failed, retrying (#<Errno::ECONNREFUSED: Connection refused - connect(2) for "<IP_ADDRESS>" port 49168>)
       [SSH] connection failed, retrying (#<Errno::ECONNREFUSED: Connection refused - connect(2) for "<IP_ADDRESS>" port 49168>)
$$$$$$ [SSH] connection failed, terminating (#<Errno::ECONNREFUSED: Connection refused - connect(2) for "<IP_ADDRESS>" port 49168>)
>>>>>> ------Exception-------
>>>>>> Class: Kitchen::ActionFailed
>>>>>> Message: Failed to complete #converge action: [Connection refused - connect(2) for "<IP_ADDRESS>" port 49168]

It is because you are overriding the run command so the sshd deamon is not running.
The driver sets its own run_command:
https://github.com/portertech/kitchen-docker/blob/master/lib/kitchen/driver/docker.rb#L36
You should not really rely on /sbin/init when using Docker containers. If you really do need to start services then consider supervise, but from experience I'd not go down that route.

You should not really rely on /sbin/init when using Docker containers

Predictably, I expected this response. My particular endeavor requires a real init system to test against. If you need context, see https://github.com/jordansissel/pleaserun.
Any recommendations on having kitchen-docker running init and also starting sshd? Custom Dockerfile per machine? Any prior art in this area?

One of the key ideas around using Docker is to run single process in their own container and then linking them together (if required). From memory, Docker actually replaces /sbin/init with their own version.
Even when running init, Docker does things behind the scene that means services are not started automatically, you need to each one manually. I went through the pain of discovering that 6 months ago.
One option is to use supervisor which is the recommend approach from the Docker team if you do actually need more than one service running.
The other option would perhaps try the driver https://github.com/marcy-terui/kitchen-docker_cli as it uses docker exec to copy stuff across instead of ssh/scp. Still not sure it will work though, as you would still have to start the services manually.
Looking at the project you have, maybe you have to add support for supervise when running in a Docker container? Or a helper that works out what services to start?

@peterabbott you are really not understanding what I am asking. "Use supervisord" is a solution to a problem I do not have. I am not asking for a lesson on what you believe Docker to be for.
This kind of "Let me tell you how I use Docker, and therefore your way is wrong" is the same noise I get nearly every time I ask questions near the Docker community.
I'm out.

Then I guess Docker is the wrong tool for the problem you are trying to solve.
If the Docker team are suggest you to use supervisord then using anything else is probably just going to be waisting your time.
I was in the same spot you were a few months ago, trying to get upstart working. I just didn't work in the way we would expect in other setups.
Was just trying to save you the pain of discovering what I went through trying to get init.d/upstart running automatically on Docker.

I'm in a situation similar to @jordansissel.
I'm using kitchen-docker because kitchen-vagrant (virtualbox) doesn't work on cloud CI systems, not because I want to use docker. I need to test a setup that uses SysV init. All of my ansible is failing because SSHD isn't running.
It would be nice if there was a way to make this work.

@aerickson Unfortunately this is a good example of how Docker is not the same as a tiny VM. It's close, but definitely not the same thing. SysV is functionally dead at this point so most effort is going to making systemd work well for testing, and even that is currently way harder than it should be with kitchen-docker. I would recommend using something like kitchen-ec2 or another cloud driver if you really do need true VMs.

Thanks. Realized my setup used Upstart and found this.
http://www.tddfellow.com/blog/2015/08/05/running-kitchen-docker-tests-with-upstart/

People are so touchy jesus...delicate sensibility I mean ...SIGH Yes supervisord would fix the issue then again , fix the root of the issue, moe than like ly as aerickson said, sound like theres an upstart assigned to it yeh? Yeah.... can be considered a virtual enviroment since procces do come in and out fro the container to the pc ... making its have the awesome flexibility but also being a HUGE security issue being that the distrobustion of images really sisnt just get started being scanned and sanitized on cokers repos and and I dound gitbud does any that....  Almost makes me think every docker image should have snort or w.e IDS just attached.... HA! and possibly a supervisord to ... keep it tight.


vscode.dev: Hitting the save shortcut in a webview triggers the browser save dialog

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: vscode.dev
OS Version: Mac OS 12.3.1

Steps to Reproduce:

Go to vscode.dev and open a folder containing a png file
Install the luna paint extension
Open the png and hit cmd+s

Fixed by https://github.com/microsoft/vscode/commit/82f2db788bc1a9efb0d0c9dc5599947c457c087a

I still see the browser save dialog

Works for me on Linux Edge and insiders.vscode.dev

I am on Safari btw

@sandy081 I'm also not able to reproduce this error on Safari with insiders.vscode.dev. Tested with both the built-in image preview and with Luna paint
Any extra steps to trigger this?

I am getting this dialog on every file. May be this shortcut (cmd+s) is not being handled by VS Code but instead by the browser. Is there a way I can prevent this?

@sandy081 Are you using a different keyboard layout that could be causing this?

I do not think if I have configured any. Is there a way to reset or do something?

@alexdima Are you aware of any safari specific issues when intercepting keypresses such as cmd+s?

No, nothing special as far as I know. FWIW I also cannot reproduce i.e. cmd+s saves the file for me, it doesn't show the browser save dialog.

Seems like specific to my env. Feel free to close this.