Fix mysql container startup check for docker

Sometimes bitbucket pipeline would fail due to MySQL dependency container not being fast enough to initialise, so instead of waiting for 3 seconds we need to check for port 3306 to be available:

Remove the 3 seconds ping of mysql
Add waiting for port 3306 to become available

@alex-mamchenkov very elegant! :+1:


[PeoplePicker] Add a parameter to hide empty personaListView

Platforms Impacted

[x] iOS
[ ] macOS

Description of changes
Add a parameter hidePersonaListViewWhenNoSuggestedPersonas to PeoplePicker to give the client ability to hide empty personaListView. Use this parameter in PeoplePickerDemoController to show how it works.
Verification

Before
After

Pull request checklist
This PR has considered:

[ ] Light and Dark appearances
[ ] VoiceOver and Keyboard Accessibility
[ ] Internationalization and Right to Left layouts
[ ] Different resolutions (1x, 2x, 3x)
[ ] Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)

Microsoft Reviewers: Open in CodeFlow

Thanks for contributing @huanlums!
Could you edit the verification section in the PR description removing the template text ("(how the change was tested, including both manual and automated tests)") and adding screenshots (before and after) in the demo app for documentation purposes?

Rafael, thank you for looking at the PR and giving advice. Change has been made per you request. Thanks again.


templateValidationHelpers: update error message for nested resource p…

…roperty with no specified nested template
Why was this change made?
Fixes #2860
After

Before:

How was this change tested?
locally ^^
Which documentation and/or configurations were updated?

@michelleif I changed it slightly from your suggestion to this (removed the word nested so it didn't say "nested template in Nested resource attributes"):


Improve diagnostic message when the user is trying to access record fields using square brackets

Description:
When the user is trying to access a record field by using square brackets and, by providing a non-string value, the bellow diagnostic message is displayed.
incompatible types: expected 'string', found 'int'(BCE2066)

sample code:
covid19:CovidCountry getStatusByCountryResponse = check covid19Endpoint->getStatusByCountry(country);
string population = getStatusByCountryResponse[0];

This message makes confusions for some users since it is not providing what/where expects string.
Since ballerina does not support record field access for non-string indexes, it would be better if we can optimize this error message. It will be more clear if we can include something like the field name must be a 'string' within the diagnostic.

@nadeeshaan please tag the relevant people.


Mirroring to the multi-destination seems not working

Is this the right place to submit this?

[X] This is not a security vulnerability or a crashing bug
[X] This is not a question about how to use Istio

Bug Description
The Istio 1.19.0-rc.0 version incorporates the mentioned PR, and I made an attempt to leverage the mirroring feature for multi-destinations. Nevertheless, I encountered an issue where the traffic wasn't being properly mirrored to the specified destinations. In my case, I utilized httpbin with subset v1/v2 and v3 for testing purposes.
apiVersion: networking.istio.io/v1alpha3
kind: DestinationRule
metadata:
  name: httpbin
spec:
  host: httpbin
  subsets:
    - name: v1
      labels:
        version: v1
    - name: v2
      labels:
        version: v2
    - name: v3
      labels:
        version: v3
---
apiVersion: networking.istio.io/v1alpha3
kind: VirtualService
metadata:
  name: httpbin
spec:
  hosts:
    - httpbin
  http:
    - route:
        - destination:
            host: httpbin
            subset: v1
          weight: 100
      mirrors:
        - destination:
            host: httpbin
            subset: v2
        - destination:
            host: httpbin
            subset: v3
---

Is there anyone who can guide me where I can start digging into more?
Version
$ istioctl version
client version: 1.19.0-rc.0
control plane version: 1.19.0-rc.0
data plane version: 1.19.0-rc.0 (7 proxies)
$ kubectl version
Client Version: v1.28.0
Kustomize Version: v5.0.4-0.20230601165947-6ce0bf390ce3
Server Version: v1.27.3-gke.1700

Additional Information
No response

This is a new feature in 1.20 and has not been cherry-picked into 1.19 because the 1.19 branch was already frozen at that time.

please try 1.20


Crash on Jason.encode_to_iodata/2

Hello!
I am converting maps and tuples to string with data |> Kernel.inspect () before sending to Logger and I am having some crashes
I would like to send the logs in json format also, do you think it would be possible to change Jason.encode_to_iodata / 2 to Jason.decode or is there any way to log in as json?
Crashes
Jason.EncodeError
(Jason.EncodeError) invalid byte 0xE7 in <<67, 104, 101, 99, 107, 111, 117, 116, 115, 46, 68, 105, 112, 108, 111, 109, 97, 116, 46, 77, 101, 115, 115, 97, 103, 101, 115, 46, 79, 114, 100, 101, 114, 115, 32, 58, 111, 114, 100, 101, 114, 115, 32, 114, 101, 99, 101, 105, 118, 101, ...>>
and
ErlangError
(ErlangError) Erlang error: {:EXIT, {%Jason.EncodeError{message: "invalid byte 0xE7 in <<67, 104, 101, 99, 107, 111, 117, 116, 115, 46, 68, 105, 112, 108, 111, 109, 97, 116, 46, 77, 101, 115, 115, 97, 103, 101, 115, 46, 79, 114, 100, 101, 114, 115, 32, 58, 111, 114, 100, 101, 114, 115, 32, 114, 101, 99, 101, 105, 118, 101, ...>>"}, [{Jason, :encode_to_iodata!, 2, [file: 'lib/jason.ex', line: 199]}, {LoggerJSON, :format_event, 5, [file: 'lib/logger_json.ex', line: 299]}, {LoggerJSON, :log_event, 5, [file: 'lib/logger_json.ex', line: 234]}, {LoggerJSON, :handle_event, 2, [file: 'lib/logger_json.ex', line: 139]}, {:gen_event, :server_update, 4, [file: 'gen_event.erl', line: 577]}, {:gen_event, :server_notify, 4, [file: 'gen_event.erl', line: 559]}, {:gen_event, :handle_msg, 6, [file: 'gen_event.erl', line: 300]}, {:proc_lib, :init_p_do_apply, 3, [file: 'proc_lib.erl', line: 249]}]}}

@damboscolo Hello. Can you provide a code snippet where you log something which leads to crash? I'll take look into it, just need a way to reproduce first :).

hey!
im formatting the log string before calling Logger.info () or Logger.error () like this:
  def format(env, map, key) when env in [:prod, :stag] and is_map(map), do:
    map
    |> Map.put(:key, key)
    |> Kernel.inspect()

  def format(env, value, key) when env in [:prod, :stag], do:
    "#{key}: #{Kernel.inspect(value)}"

these are the logs that generated the crashes, maybe these null values caused the problem? 🤔
{"cid":"aU9uVHJzZz0.dWZQNw","log":"Checkouts.Diplomat.Messages.Orders :orders received unexpected message in handle_info/2: {#Reference<0.4097939000.1447821313.2842>, {:ok,<PHONE_NUMBER>}}\n","logging.googleapis.com/sourceLocation":{"file":null,"line":0,"function":null},"severity":"ERROR","time":"2019-06-07T17:39:18.413Z","user_uid":"13"}
{"cid":"aU9uVHJzZz0.dWZQNw","log":"Checkouts.Diplomat.Messages.Orders :orders received unexpected message in handle_info/2: {:DOWN, #Reference<0.4097939000.1447821313.2842>, :process, #PID<0.9685.0>, :normal}\n","logging.googleapis.com/sourceLocation":{"file":null,"line":0,"function":null},"severity":"ERROR","time":"2019-06-07T17:39:18.413Z","user_uid":"13"}
{"cid":"aU9uVHJzZz0.dWZQNw","log":"Checkouts.Diplomat.Messages.Orders :orders received unexpected message in handle_info/2: {:DOWN, #Reference<0.4097939000.1447821313.2839>, :process, #PID<0.9682.0>, :normal}\n","logging.googleapis.com/sourceLocation":{"file":null,"line":0,"function":null},"severity":"ERROR","time":"2019-06-07T17:39:18.413Z","user_uid":"13"}

Hey @damboscolo. Sorry for taking so long to respond. nils should be fine, it is more likely that some value not supported by Jason sneaked in, eg. pid, tuple or reference in the metadata.


forevolve.git-extensions-for-vs-code not working while in remote ssh session - worng path !

while i use remote SSH Linux session for my project, i try to use this utility but it failed in init stage due to wrong path
as can be seen in the pop-up window that states the path of incoming gitExt which is empty in this case.
local folder run flawlessly, and correct path can be seen

Thanks for reporting the issue. I also noticed this and would need to explore how to fix it. Maybe #5 could help. I don't know when I'll have time to look at this, though. If you find a fix, please let me know.


[FEATURE] remove spinner from the input, at the Profile page

What would you like to share?
Hello
I think the input, would look much cleaner without the spinners

Additional information
No response
👀 Have you checked if this issue has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Contributing Guidelines?

[X] I have read and understood the rules in the Contributing Guidelines

Are you willing to work on this issue ?
Yes I am willing to submit a PR!

Thanks for raising, not an accepted issue👍🏽


release: v0.14.1

Description: 概要

Changes: 変更内容

Changes

fix: stop auto input address when not empty (e3262cf027e4ad889b78433137df63a8e0116de2)

Expected Impact: 影響範囲

Operating Requirements: 動作要件

Additional context: 補足

Command results

Details:

add path
/home/runner/work/_actions/technote-space/create-pr-action/v2/node_modules/npm-check-updates/bin

yarn update
yarn run v1.22.5
$ yarn update:core && yarn workspaces run update && yarn install && yarn upgrade && yarn audit
$ npx npm-check-updates -u --timeout 100000
Upgrading /home/runner/work/frourio-demo/frourio-demo/package.json

 @typescript-eslint/eslint-plugin  ^4.15.0  →  ^4.15.1
 @typescript-eslint/parser         ^4.15.0  →  ^4.15.1

Run npm install to install new versions.

> @frourio-demo/constants
$ npx npm-check-updates -u --timeout 100000
Upgrading /home/runner/work/frourio-demo/frourio-demo/shared/constants/package.json

All dependencies match the latest package versions :)

> @frourio-demo/types
$ npx npm-check-updates -u --timeout 100000
Upgrading /home/runner/work/frourio-demo/frourio-demo/shared/types/package.json

All dependencies match the latest package versions :)

> @frourio-demo/utils
$ npx npm-check-updates -u --timeout 100000
Upgrading /home/runner/work/frourio-demo/frourio-demo/shared/utils/package.json

All dependencies match the latest package versions :)

> @frourio-demo/admin
$ npx npm-check-updates -u --timeout 100000 -x @date-io/date-fns,next-transpile-modules
Upgrading /home/runner/work/frourio-demo/frourio-demo/apps/admin/package.json

 next                   ^10.0.6  →  ^10.0.7
 @next/bundle-analyzer  ^10.0.6  →  ^10.0.7

Run npm install to install new versions.

> @frourio-demo/front
$ npx npm-check-updates -u --timeout 100000 -x next-transpile-modules
Upgrading /home/runner/work/frourio-demo/frourio-demo/apps/front/package.json

 @auth0/auth0-react      ^1.2.0  →   ^1.3.0
 next                   ^10.0.6  →  ^10.0.7
 @next/bundle-analyzer  ^10.0.6  →  ^10.0.7

Run npm install to install new versions.

> @frourio-demo/lock
$ npx npm-check-updates -u --timeout 100000 -x next-transpile-modules
Upgrading /home/runner/work/frourio-demo/frourio-demo/apps/lock/package.json

 next                   ^10.0.6  →  ^10.0.7
 @next/bundle-analyzer  ^10.0.6  →  ^10.0.7

Run npm install to install new versions.

> @frourio-demo/server
$ npx npm-check-updates -u --timeout 100000
Upgrading /home/runner/work/frourio-demo/frourio-demo/apps/server/package.json

 @prisma/client  ^2.16.1  →  ^2.17.0
 @prisma/cli     ^2.16.1  →  ^2.17.0

Run npm install to install new versions.

[1/5] Validating package.json...
[2/5] Resolving packages...
[3/5] Fetching packages...
info<EMAIL_ADDRESS>The platform "linux" is incompatible with this module.
info<EMAIL_ADDRESS>is an optional dependency and failed compatibility check. Excluding it from installation.
[4/5] Linking dependencies...
[5/5] Building fresh packages...
success Saved lockfile.
[1/5] Validating package.json...
[2/5] Resolving packages...
[3/5] Fetching packages...
info<EMAIL_ADDRESS>The platform "linux" is incompatible with this module.
info<EMAIL_ADDRESS>is an optional dependency and failed compatibility check. Excluding it from installation.
[4/5] Linking dependencies...
[5/5] Rebuilding all packages...
success Saved lockfile.
success Saved 2 new dependencies.
info Direct dependencies
├─<EMAIL_ADDRESS>└─<EMAIL_ADDRESS>info All dependencies
├─<EMAIL_ADDRESS>└─<EMAIL_ADDRESS>0 vulnerabilities found - Packages audited: 3106
Done in 462.37s.

stderr:
npx: installed 315 in 13.851s

npx: installed 315 in 8.965s

npx: installed 315 in 106.52s

npx: installed 315 in 9.003s

npx: installed 315 in 8.764s

npx: installed 315 in 8.998s

npx: installed 315 in 9.635s

npx: installed 315 in 8.559s

warning " ><EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>|| ^17.0.0".
warning " ><EMAIL_ADDRESS>has unmet peer dependency "webpack@*".
warning "workspace-aggregator-48ed77cc-388e-4bf8-93ef-cabe47771fb6 > @frourio-demo/admin ><EMAIL_ADDRESS>has unmet peer dependency "<EMAIL_ADDRESS>warning "workspace-aggregator-48ed77cc-388e-4bf8-93ef-cabe47771fb6 > @frourio-demo/admin ><EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>warning "workspace-aggregator-48ed77cc-388e-4bf8-93ef-cabe47771fb6 > @frourio-demo/admin ><EMAIL_ADDRESS>has incorrect peer dependency<EMAIL_ADDRESS>warning "workspace-aggregator-48ed77cc-388e-4bf8-93ef-cabe47771fb6 > @frourio-demo/admin ><EMAIL_ADDRESS>has incorrect peer dependency<EMAIL_ADDRESS>warning "workspace-aggregator-48ed77cc-388e-4bf8-93ef-cabe47771fb6 > @frourio-demo/admin ><EMAIL_ADDRESS>has unmet peer dependency "<EMAIL_ADDRESS>warning "workspace-aggregator-48ed77cc-388e-4bf8-93ef-cabe47771fb6 > @frourio-demo/admin ><EMAIL_ADDRESS>has unmet peer dependency "<EMAIL_ADDRESS>warning "workspace-aggregator-48ed77cc-388e-4bf8-93ef-cabe47771fb6 > @frourio-demo/admin ><EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>|| ^5.0.0".
warning "workspace-aggregator-48ed77cc-388e-4bf8-93ef-cabe47771fb6 > @frourio-demo/front ><EMAIL_ADDRESS>has unmet peer dependency "<EMAIL_ADDRESS>warning "workspace-aggregator-48ed77cc-388e-4bf8-93ef-cabe47771fb6 > @frourio-demo/front ><EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>warning "workspace-aggregator-48ed77cc-388e-4bf8-93ef-cabe47771fb6 > @frourio-demo/lock ><EMAIL_ADDRESS>has incorrect peer dependency "react@~16".
warning "workspace-aggregator-48ed77cc-388e-4bf8-93ef-cabe47771fb6 > @frourio-demo/lock ><EMAIL_ADDRESS>has incorrect peer dependency "react-dom@~16".
warning "workspace-aggregator-48ed77cc-388e-4bf8-93ef-cabe47771fb6 > @frourio-demo/admin > @technote-space/material-table ><EMAIL_ADDRESS>has incorrect peer dependency<EMAIL_ADDRESS>warning "workspace-aggregator-48ed77cc-388e-4bf8-93ef-cabe47771fb6 > @frourio-demo/admin > @technote-space/material-table ><EMAIL_ADDRESS>has incorrect peer dependency<EMAIL_ADDRESS>warning "workspace-aggregator-48ed77cc-388e-4bf8-93ef-cabe47771fb6 > @frourio-demo/front > @chakra-ui/icons ><EMAIL_ADDRESS>has unmet peer dependency "<EMAIL_ADDRESS>warning "workspace-aggregator-48ed77cc-388e-4bf8-93ef-cabe47771fb6 > @frourio-demo/front > @emotion/styled ><EMAIL_ADDRESS>has unmet peer dependency "<EMAIL_ADDRESS>warning "workspace-aggregator-48ed77cc-388e-4bf8-93ef-cabe47771fb6 > @frourio-demo/server > cross-blob ><EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>warning "workspace-aggregator-48ed77cc-388e-4bf8-93ef-cabe47771fb6 > @frourio-demo/front > @emotion/styled > @emotion/babel-plugin ><EMAIL_ADDRESS>has unmet peer dependency "<EMAIL_ADDRESS>warning jest > @jest/core > jest-config > jest-environment-jsdom > jsdom ><EMAIL_ADDRESS>request-promise-native has been deprecated because it extends the now deprecated request package, see https://github.com/request/request/issues/3142
warning jest > @jest/core > jest-config > jest-environment-jsdom > jsdom ><EMAIL_ADDRESS>request has been deprecated, see https://github.com/request/request/issues/3142
warning jest > @jest/core > jest-config > jest-environment-jsdom > jsdom > request ><EMAIL_ADDRESS>this library is no longer supported
warning jest > @jest/core > jest-haste-map > sane > micromatch > snapdragon > source-map-resolve ><EMAIL_ADDRESS>https://github.com/lydell/resolve-url#deprecated
warning jest > @jest/core > jest-haste-map > sane > micromatch > snapdragon > source-map-resolve ><EMAIL_ADDRESS>Please see https://github.com/lydell/urix#deprecated
warning " ><EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>|| ^17.0.0".
warning " ><EMAIL_ADDRESS>has unmet peer dependency "webpack@*".
warning "workspace-aggregator-76a92c82-307e-4da6-905c-942c9b1963c8 > @frourio-demo/admin ><EMAIL_ADDRESS>has unmet peer dependency "<EMAIL_ADDRESS>warning "workspace-aggregator-76a92c82-307e-4da6-905c-942c9b1963c8 > @frourio-demo/admin ><EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>warning "workspace-aggregator-76a92c82-307e-4da6-905c-942c9b1963c8 > @frourio-demo/admin ><EMAIL_ADDRESS>has incorrect peer dependency<EMAIL_ADDRESS>warning "workspace-aggregator-76a92c82-307e-4da6-905c-942c9b1963c8 > @frourio-demo/admin ><EMAIL_ADDRESS>has incorrect peer dependency<EMAIL_ADDRESS>warning "workspace-aggregator-76a92c82-307e-4da6-905c-942c9b1963c8 > @frourio-demo/admin ><EMAIL_ADDRESS>has unmet peer dependency "<EMAIL_ADDRESS>warning "workspace-aggregator-76a92c82-307e-4da6-905c-942c9b1963c8 > @frourio-demo/admin ><EMAIL_ADDRESS>has unmet peer dependency "<EMAIL_ADDRESS>warning "workspace-aggregator-76a92c82-307e-4da6-905c-942c9b1963c8 > @frourio-demo/admin ><EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>|| ^5.0.0".
warning "workspace-aggregator-76a92c82-307e-4da6-905c-942c9b1963c8 > @frourio-demo/front ><EMAIL_ADDRESS>has unmet peer dependency "<EMAIL_ADDRESS>warning "workspace-aggregator-76a92c82-307e-4da6-905c-942c9b1963c8 > @frourio-demo/front ><EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>warning "workspace-aggregator-76a92c82-307e-4da6-905c-942c9b1963c8 > @frourio-demo/lock ><EMAIL_ADDRESS>has incorrect peer dependency "react@~16".
warning "workspace-aggregator-76a92c82-307e-4da6-905c-942c9b1963c8 > @frourio-demo/lock ><EMAIL_ADDRESS>has incorrect peer dependency "react-dom@~16".
warning "workspace-aggregator-76a92c82-307e-4da6-905c-942c9b1963c8 > @frourio-demo/admin > @technote-space/material-table ><EMAIL_ADDRESS>has incorrect peer dependency<EMAIL_ADDRESS>warning "workspace-aggregator-76a92c82-307e-4da6-905c-942c9b1963c8 > @frourio-demo/admin > @technote-space/material-table ><EMAIL_ADDRESS>has incorrect peer dependency<EMAIL_ADDRESS>warning "workspace-aggregator-76a92c82-307e-4da6-905c-942c9b1963c8 > @frourio-demo/front > @emotion/styled ><EMAIL_ADDRESS>has unmet peer dependency "<EMAIL_ADDRESS>warning "workspace-aggregator-76a92c82-307e-4da6-905c-942c9b1963c8 > @frourio-demo/server > cross-blob ><EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>warning "workspace-aggregator-76a92c82-307e-4da6-905c-942c9b1963c8 > @frourio-demo/front > @emotion/styled > @emotion/babel-plugin ><EMAIL_ADDRESS>has unmet peer dependency "<EMAIL_ADDRESS>

Changed files

Changed 6 files:

apps/admin/package.json
apps/front/package.json
apps/lock/package.json
apps/server/package.json
package.json
yarn.lock

:octocat: Repo | :memo: Issues | :department_store: Marketplace

Codecov Report

Merging #124 (3b7f03e) into main (56d21df) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main      #124   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files          142       142
  Lines         2088      2088
  Branches       224       224
=========================================
  Hits          2088      2088

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56d21df...3b7f03e. Read the comment docs.


By default, free asset dispensing is not open to all

Background
I found this when publishing the CEXA price feed. (Published here).
This meant that, in the README that uses the price feed, no one was allowed to come along and request tokens from the dispenser.
Core problem
The problem was that by default, in the dispenser contract, it sets allowedSwapper to nonzero address (not 0x00...). Which meant that only the publishing account can dispense tokens, unless it's changed via setAllowedSwapper().
I looked around in Ocean Market to try to change it, such that I could allow anyone to request tokens. Eg next to "change ddo". Such an option did not exist.
But I did find a workaround, in code: via Python, I updated the allowedSwapper to zero address (0x00..) manually. In that setting, it means that anyone can request tokens (ref).
Candidate solutions
What to do for Ocean Market? I see four design options A, B, C, D.
Option A. Market could offers two choices:

anyone can request
only pre-set address can request. If this: can set the address within Ocean Market

Option B. Only offer choice (1) - anyone can request
Option C. Only offer choice (2) - only pre-set address can request, without an affordance to set address. (This is the status quo.)
Option D. Only offer choice (2) - only pre-set address can request, with some affordance to set the address.
Analysis:

any flow with (2) adds complexity, because it implies that someone is managing access and doling out tokens. This is options A, C, or D.
whereas if we do just (1) - option B where anyone can request - it's simple and non-constraining. Making this change in Ocean Market is likely just changing one line of code: wherever it calls dispenser.create(), set the parameter allowedSwapper to 0x00...

I recommend that we do just (1) - option B where anyone can request. Simple change, keep UX simple, move on.

wherever it calls dispenser.create(), set the parameter allowedSwapper to 0x00...

that's exactly what we do:
https://github.com/oceanprotocol/market/blob/c8b8db9b52729cd4c137f651561cf15d1af3f6aa/src/components/Publish/_utils.ts#L266
I can successfully download any other free asset on the market, like this one.
If you publish outside of market UI we can't control what parameters you set when publishing.

Actually, I published the asset inside the market UI.
Re-opening

Here's how you can reproduce:

Publish any asset via Market UI. Note its did.
Try to request dispense from ocean.js or ocean.py, from an address different than the one you published with. It will fail

Still not reproducible, no other free asset has this problem. No newly published free asset has this problem. Published multiple free assets (like this one), can download them all with another account. Non-reproducible issue should be closed.

Try reproducing by

Publish any asset via Market UI. Note its did.
Do steps 1 & 2 of this flow, replacing the did with the previous step's did

So dispensing vs. ordering. By design only the publisher is allowed to dispense datatokens as otherwise everybody can drain the dispenser of all available tokens. Everybody else needs to go through order flow, which in market we do with ocean.js which calls buyFromDispenserAndOrder() on the datatoken contract, like here for mentioned new asset: https://mumbai.polygonscan.com/tx/0x26ca081cb956bf794324340cdb0482a5fe4ef10dc384801a0d8f0d3d0172f590
So not sure if this design should be changed.
As for allowedSwapper, I indeed find a lot of weird things. My asset creation tx in the end sets allowedSwapper to the datatoken address despite market sending a zero address along the stack. So I would expect allowedSwapper to always be the zero address when publishing from market.

So I would expect allowedSwapper to always be the zero address when publishing from market, but this seems to be a problem somewhere further down the stack.

Interesting that you got the error too. "It was supposed to work, but it doesn't"
FYI in my original problem, I'd queried the allowedSwapper address; and it was not 0x00.

Think I'm back again at isolating it to market. Over in ocean.js added specific tests for this and there the event emitted always has allowedSwapper as the zero address, run against barge:

When calling same method with same params from market, run against Mumbai, I instead get datatoken address returned as allowedSwapper, so it stays mysterious:

So either something gets lost in market when passing params or something is different with the deployed remote contracts, but for both things I just can't find anything yet

More fun findings: when using createNftWithDatatokenWithDispenser() from market, an additional DispenserAllowedSwapperChanged event is emitted, which is not emitted when run in ocean.js tests. And this event then shows the datatoken address has been set.

It seems an issue in the contract. Check this tx . The input data is ok _DispenserData.allowedSwapper	address	0x0000000000000000000000000000000000000000
But in the events :

Okk..i went down the rabbit hole and got confused as well :) . The market works fine, i can download the assets published by @kremalicious . If you are using the enterprise template (we are using it in our market ) you need to call datatoken.buyFromFreAndOrder  (in contracts it's buyFromDispenserAndOrder ).
In the readme you are trying to buy a datatoken and then order, this will work for the simple datatoken template.
So instead of this:
ocean.dispenser.dispense_tokens(datatoken, amt_dispense_wei, consumer_wallet=alice_wallet)
bal = ocean.from_wei(datatoken.balanceOf(alice_wallet.address))
print(f"Alice now holds {bal} datatokens to access the data asset.")

# Alice sends datatoken to the service, to get access
order_tx_id = ocean.assets.pay_for_access_service(asset, alice_wallet)
print(f"order_tx_id = '{order_tx_id}'")

you just neet to call  buyFromDispenserAndOrder

Thanks @mihaMI a and @kremaliciou for the digging.
I will update the ocean.py READMEs accordingly.
And for that, I will take this ticket, and transfer it to ocean.py repo.


always return non nil Rows in fakesqldb.Conn

fakesqldb.Conn will not init proto.QueryResult.Rows if RowsAffected is zero.
However, according to go/mysql/mysql.go, the ideal response should be an empty
proto.QueryResult.Rows.

lgtm


Inexact error when running the Heisenberg example

I'm trying to run the Heisenberg chain example but I get an Inexact error.
The stack trace points to the problem being the derivation of the costfunction with Zygote.

After some more digging this turns out to work on the latest version of TensorKit.
https://github.com/Jutho/TensorKit.jl/issues/90


Include except

This PR introduces a new feature: the include-except processor. Similar to include processor, it reads contents of other files and adds them to the including file.
The include-except process take two arguments, an inclusion file, and an exclusion file. First, the inclusion file is treated as it would be for the inclusion processor. Then, all lines from the exclusion file are removed from the inclusion file. The result of this operation is that the including file contains the contents of the inclusion file, as usual, but with some entries removed.
Entries must be identical to match.

@coreruleset/core-developers This is a proposal for a new processor. I would appreciate some feedback. An example of how it would be used:
some prefix

##!> include-except unix-shell unix-shell-dangerous

some suffix

The "exclusion files" will reside in a separate directory called exclude and will be allowed to contain only comments (##!)  or lines that match lines in an inclusion file.

Two questions came to mind when reading the description of this new functionality.

It seems entirely possible for one to update an include file (remove a pattern, amend an anti-evasion technique, etc.) but forget to update all of the corresponding exclude files that may exist. Is there a way to ensure that invalid excludes are flagged, which would force us to keep everything synchronised?
E.g. if an exclude file is trying to exclude the pattern abc but I've already updated my include file which now contains the updated pattern \babc\b, could that cause an error and present a message to the user?

Is it possible to directly exclude a problematic entry? Like:
##!> include-except colours.list purple orange

Thanks @RedXanadu.

It seems entirely possible for one to update an include file (remove a pattern, amend an anti-evasion technique, etc.) but forget to update all of the corresponding exclude files that may exist. Is there a way to ensure that invalid excludes are flagged, which would force us to keep everything synchronised? Or would that just fail silently and not be caught? Or is that a linter task?
E.g. if an exclude file is trying to exclude the pattern abc but I've already updated my include file which now contains the updated pattern \babc\b, could that cause an error and present a message to the user?

Only matching lines matter. Superfluous entries in exclude files will be ignored. We could add a linter step at some point.

Is it possible to directly exclude a problematic entry? Like:
##!> include-except colours.list purple orange

No, currently not. I have thought about that and decided against it. There are two reasons for the decision:

While the length of a line is technically unlimited, reading the line becomes hard very quickly when the number of entries grows, especially when the line contains more complex entries (entries can be arbitrary regular expressions)
The alternative to 1. would be to represent the list of entries as individual lines, as it is done everywhere else. However, this doesn't work at the moment for a technical reason. The include and include-except steps actually happen at the parser stage, before the processors run and we don't have a way to go backwards in the parser stage. I could work around that limitation by introducing special internal processors but I try to avoid such hacks.

Yes, changing the syntax there would be very easy.


New nbDetails block?

It would be cool to have a block using the <summary> and <details> html tags like this:
<details>
  <summary>

      summary

   </summary>

  details
</details>

This could be used in a Q&A section, long blobs of text, etc...

indeed we showed how to produce a simple implementation of that in our latest nimib presentation: https://github.com/pietroppeter/nimconf22-nimib/blob/bb874c6f2d2fcb77c7bd4fbffbe906a8df95ebdc/pietros_slides.nim#L343
(in principle you could see the slides here but I do not know how to link to a specific slides in nimislides).
ideally an improved version would make use of the container block concept (still not available) to support multiple mixed blocks  (code + text + images + ...) inside the details.
Not sure if we want already to put the simple implementation inside nimib or not...

The simple implementation looks fine to me!


--wait is not released when workspace trust dialog

Two bugs related to having core.editor = code-insiders --wait and Workspace Trust:

Open a trusted workspace
In an external terminal, run git config --global -e. You should see a workspace trust popup in the existing window

🐛 If you cancel the dialog, the editor never returns
🐛 If you decided to open in a new window, the editor doesn't return even if you close the file or the new window

Steven, Lad, can any of you investigate please.

/duplicate https://github.com/microsoft/vscode/issues/124618

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for similar existing issues. See also our issue reporting guidelines.
Happy Coding!

🤷 not sure anymore, I guess I forgot to link.
You mean to force open a new window only if the current window is trusted and the file would be untrusted or in general? I think in general we do not want to do that for perf reasons because opening a window is much slower.
But if we could know from the main process that the window the file opens is trusted and would result in a trust dialog (not sure we can do that), it would be good to force a new window I suppose.

So, should we reopen this issue, at least for exploration?

Actually, it might still frustrate users that we force open a new window when the target window is trusted but the file is untrusted because as a user you can still allow the file to open. So I think we are back to square one and my comment still applies that such a change is costly (I did the investigation back then).

I pushed a fix to release the waiting process as soon as you click "Cancel" or "Open in new Window" because that was clearly a bug.
For supporting --wait across new windows, I have opened https://github.com/microsoft/vscode/issues/152858
Verification:

open a folder that is trusted
from the command line run code-insiders --wait <path to a file of a untrusted folder>
you will see a workspace trust dialog
select "Cancel" or "Open in untrusted window"
verify your command line run returns back to prompt
do above steps again, but this time select to open the file
close the file and verify your command line run returns back to prompt

This is fantastic, thank you! 👏

Very strange. When I try this today, the file just opens, completely ignoring the Trust feature:

Oh it's because of this:

Will file a new issue for this.


[WIP] Merge dav1d 0.2.0 x86 assembly

Advances #1750.
Difference between upstream commit list and this PR:
-Remove unused data from x86/cdef.asm
-Speed up finding the best cost in avx2 cdef
-x86: optimize AVX2 cdef filters
-x86: optimize 4 by X cdef filters for HAVE_RIGHT=0
-x86: add AVX2 cdef_filter_4x8
-x86: remove redundant code in cdef filter AVX2
-x86: improve AVX2 cdef_filter macro consistency
-Remove carriage return characters
-Fix AVX2 itx crash on 64-bit Windows
-Improve the fast path of IDCT 8x32 AVX2

The ITX commits were squashed in #864.
Our CDEF assembly is divergent from dav1d.

Coverage increased (+0.1%) to 75.121% when pulling 772ea022c2884e14a6964bc72cabc9c4233b1bd7 on barrbrain:merge-dav1d-0.2.0 into 1ecbae4aaeb24991021517f0163d55305e86c7e8 on xiph:master.

AWCY results at speed 2 show a reduction in encoding time of 6% to 7.8%.
The integration of inverse transform functions can be deferred to 0.3.0 merge:

Release 0.2.2 includes all remaining such SSSE3 functions;
Release 0.3.0 contains a crash fix for inv_txfm2d_add_identity_identity_32x32_ssse3.


Add Protobuf serialization example from blog post

Use CMakeToolchain + CMakeDeps + cmake_layout instead of legacy cmake generator
Update Protobuf to the latest version available in Conan Center
Use Protobuf syntax version 3 instead of 2 (legacy).
Include protobuf as tool requirement too, to make possible to parse .proto file
Use protobuf targets instead of old CONAN_PKG

closes #102

As always, Windows opposes to accept my PR. I'll check at home, as I don't have access to a Windows machine right now.

Fixed Windows build!


[release 1.7] fix istioctl authz check to print authz policies applied in pod

Fix https://github.com/istio/istio/issues/26675
This cherry-picks https://github.com/istio/istio/pull/26625 and https://github.com/istio/istio/pull/26697
Please provide a description for what this PR is for.
And to help us figure out who should review this PR, please
put an X in all the areas that this PR affects.
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[ ] Does not have any changes that may affect Istio users.

@yangminzhu: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio_release-1.7
ba41f068241d4f651ea1c5d34920f5fecf02a72c
link
/test release-notes_istio_release-1.7

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangminzhu: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio_release-1.7
13e88fbf2b758023217f2696c31fb8b862ed4236
link
/test release-notes_istio_release-1.7

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangminzhu: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio_release-1.7
a4dc48f2b7d94ee1accfed6fa4ec4ddc76c4a849
link
/test release-notes_istio_release-1.7

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangminzhu: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio_release-1.7
ff0fb28efcfc435ed41d1785c6530ec12ea9c4cf
link
/test release-notes_istio_release-1.7

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangminzhu: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio_release-1.7
ff0fb28efcfc435ed41d1785c6530ec12ea9c4cf
link
/test release-notes_istio_release-1.7

integ-pilot-k8s-tests_istio_release-1.7
ff0fb28efcfc435ed41d1785c6530ec12ea9c4cf
link
/test integ-pilot-k8s-tests_istio_release-1.7

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-pilot-k8s-tests_istio_release-1.7

@yangminzhu: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio_release-1.7
ff0fb28efcfc435ed41d1785c6530ec12ea9c4cf
link
/test release-notes_istio_release-1.7

integ-pilot-k8s-tests_istio_release-1.7
ff0fb28efcfc435ed41d1785c6530ec12ea9c4cf
link
/test integ-pilot-k8s-tests_istio_release-1.7

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangminzhu: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio_release-1.7
ff0fb28efcfc435ed41d1785c6530ec12ea9c4cf
link
/test integ-pilot-k8s-tests_istio_release-1.7

release-notes_istio_release-1.7
48f66f30934d5d405a8aa3161a52af735a459b21
link
/test release-notes_istio_release-1.7

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangminzhu: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio_release-1.7
ff0fb28efcfc435ed41d1785c6530ec12ea9c4cf
link
/test integ-pilot-k8s-tests_istio_release-1.7

release-notes_istio_release-1.7
48f66f30934d5d405a8aa3161a52af735a459b21
link
/test release-notes_istio_release-1.7

unit-tests_istio_release-1.7
48f66f30934d5d405a8aa3161a52af735a459b21
link
/test unit-tests_istio_release-1.7

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangminzhu: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio_release-1.7
48f66f30934d5d405a8aa3161a52af735a459b21
link
/test release-notes_istio_release-1.7

unit-tests_istio_release-1.7
48f66f30934d5d405a8aa3161a52af735a459b21
link
/test unit-tests_istio_release-1.7

integ-pilot-k8s-tests_istio_release-1.7
48f66f30934d5d405a8aa3161a52af735a459b21
link
/test integ-pilot-k8s-tests_istio_release-1.7

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangminzhu: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yangminzhu Could you please fix the conflicts?

@yangminzhu: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio_release-1.7
48f66f30934d5d405a8aa3161a52af735a459b21
link
/test unit-tests_istio_release-1.7

integ-pilot-k8s-tests_istio_release-1.7
48f66f30934d5d405a8aa3161a52af735a459b21
link
/test integ-pilot-k8s-tests_istio_release-1.7

release-notes_istio_release-1.7
eb837a220f5283bf9e7f6ad490b2a0331f0ae173
link
/test release-notes_istio_release-1.7

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangminzhu: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio_release-1.7
48f66f30934d5d405a8aa3161a52af735a459b21
link
/test unit-tests_istio_release-1.7

integ-pilot-k8s-tests_istio_release-1.7
48f66f30934d5d405a8aa3161a52af735a459b21
link
/test integ-pilot-k8s-tests_istio_release-1.7

release-notes_istio_release-1.7
eb837a220f5283bf9e7f6ad490b2a0331f0ae173
link
/test release-notes_istio_release-1.7

integ-security-k8s-tests_istio_release-1.7
eb837a220f5283bf9e7f6ad490b2a0331f0ae173
link
/test integ-security-k8s-tests_istio_release-1.7

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangminzhu: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio_release-1.7
48f66f30934d5d405a8aa3161a52af735a459b21
link
/test unit-tests_istio_release-1.7

integ-pilot-k8s-tests_istio_release-1.7
48f66f30934d5d405a8aa3161a52af735a459b21
link
/test integ-pilot-k8s-tests_istio_release-1.7

release-notes_istio_release-1.7
eb837a220f5283bf9e7f6ad490b2a0331f0ae173
link
/test release-notes_istio_release-1.7

integ-security-k8s-tests_istio_release-1.7
eb837a220f5283bf9e7f6ad490b2a0331f0ae173
link
/test integ-security-k8s-tests_istio_release-1.7

integ-multicluster-k8s-tests_istio_release-1.7
eb837a220f5283bf9e7f6ad490b2a0331f0ae173
link
/test integ-multicluster-k8s-tests_istio_release-1.7

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@yangminzhu: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio_release-1.7
eb837a220f5283bf9e7f6ad490b2a0331f0ae173
link
/test integ-security-k8s-tests_istio_release-1.7

integ-multicluster-k8s-tests_istio_release-1.7
eb837a220f5283bf9e7f6ad490b2a0331f0ae173
link
/test integ-multicluster-k8s-tests_istio_release-1.7

release-notes_istio_release-1.7
eb837a220f5283bf9e7f6ad490b2a0331f0ae173
link
/test release-notes_istio_release-1.7

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


[MAJOR] issue(s) with raw_data3.json

I've noticed some problems with raw_data3.json :

In the “numcases” field, which mentions the number of cases in that district. there are negative values in some cases. (I'm genuinely confused if it's a feature or bug!)

for entryid(s) : 938, 1021, 1367

According to  raw_data3.json, the confirmed cases in last 3 days (27, 28 & 29) add up-to (adding values of “numcases” field)  a total  of 7392 Vs 5172 in data.json

my bad, if I misunderstood the new API or if it's an Irrelevant Issue.

-ve values are a feature. This happens when states reduce a patient from one district and (we guess, ) add to a different district. We are trying structurally capture what is happening in state bulletins.
Regarding the total cases : Did you filter only 27,28,29 AND Current Status = "Hospitalized". I am getting the 5173 (+1 because we added on case to yesterday after you posted this issue) value.

Thanks, I wasn't aware of the -ve values.
Regarding the total cases: Yes, I filtered only 27, 28, 29, but NOT Current Statues = "Hospitalized". I was treating it like the old API where each entry = new confirmed case.
and according to my understanding (correct me if I'm wrong) with the new API, all three (confirmed/hospitalized, deceased & recovered) are unified into one API?

Yes. In raw_data3, confirmed, deceased and recovered all entered in the same sheet.

Closing this issue. If there are more questions regarding the format of raw_data3. Please use this thread : https://github.com/covid19india/api/issues/195

Thanks a lot!
It all makes sense now!


mLipok plans for next months

Feature request
Is your feature request related to a problem? Please describe
Things to do after 'Opera' projects.
Please treat it as a notebook, sketch, draft, remainder.
Please do not analyze before finishing the 'Opera project'.
Please assign this ticket to me.
I just don't want to disrupt the ongoing design work for now, but I also don't want to forget what I want to do in the future.
Describe the solution you'd like

review: _WD_Option() for such kind of variables lik $_WD_ERROR_MSGBOX which is not possible to set with _WD_Option()

refactor: __WD_Error to use also $iExt - currently it use only $iErr

magic number removall : MsgBox(16,
4a.
__WD_ConsoleWrite : preserve @error and @extended
4n.
__WD_ConsoleWrite: move @CRLF to internall processing - not needed in all __WD_ConsoleWrite line
4c.
__WD_ConsoleWrite: support for other @CRLF  will be needed in case you have your own function defined .... If IsFunc($_WD_CONSOLE) Then
Example:
Global $_WD_CONSOLE_SUFFIX = @crlf

Func __WD_ConsoleWrite($sMsg)
	If IsFunc($_WD_CONSOLE) Then
		Call($_WD_CONSOLE, $sMsg & $_WD_CONSOLE_SUFFIX)
	ElseIf $_WD_CONSOLE = Null Then
		; do nothing
	Else
		FileWrite($_WD_CONSOLE, $sMsg& $_WD_CONSOLE_SUFFIX)
	EndIf
EndFunc   ;==>__WD_ConsoleWrite

DllCall("kernel32.dll", "none", "OutputDebugString", "str", $sMsg) can not be obligatory
It need to have an option to switch it off.
More: it should be switched off by design (get a look for GDPR law act).

_WD_GetBrowserPath() not always coresponds to _WD_CapabilitiesAdd('binary','******') settings
Describe alternatives you've considered
not releated
Additional context
not releated

__WD_ConsoleWrite : preserve @error and @extended

Can this be done without adding additional parameters to __WD_ConsoleWrite? If not, then I don't think I can support this.

Can this be done without adding additional parameters to __WD_ConsoleWrite? If not, then I don't think I can support this.

take a look here: __WD_ConsoleWrite : preserve @error and @extended


building faces are missing

Testing dev against prod with exactly the same stylesheet removed 2 faces of extruded 3d buildings.
This is a ship block for v0.5!
Is this related to the multipart change we landed for MVT? When I set this to topojson (instead of mvt) it works fine.
sources:
osm:
# EraserMaps the app only supports MVT format tiles
type: TopoJSONTiles #MVT
url:   //vector.dev.mapzen.com/osm/all/{z}/{x}/{y}.topojson  #mvt
16/37.7857/-122.4014
https://github.com/tangrams/eraser-map
dev (v0.5-pre)

prod (v0.4)

Whoa interesting. Is it possible winding order is backwards on that ring?
This can be a visual symptom of that. We enforce/fix winding order on
standalone/non-tiled data sources, but by default assume it is already
correct on tiled sources.
Can you try adding this option in the 'source' block, with the MVT source
and see if it makes any difference?
enforce_winding: true
On Tuesday, November 10, 2015, Nathaniel V. KELSO<EMAIL_ADDRESS>wrote:

Testing dev against prod with exactly the same stylesheet removed 2 faces
of extruded 3d buildings.
This is a ship block for v0.5!
Is this related to the multipart change we landed for MVT
https://github.com/mapzen/mapbox-vector-tile/issues/20? When I set this
to topojson (instead of mvt) it works fine.
sources:
osm:
EraserMaps the app only supports MVT format tiles
type: TopoJSONTiles #MVT
url: //vector.dev.mapzen.com/osm/all/{z}/{x}/{y}.topojson
http://vector.dev.mapzen.com/osm/all/{z}/{x}/{y}.topojson
#mvt
16/37.7857/-122.4014
https://github.com/tangrams/eraser-map
dev (v0.5-pre)
[image: screen shot 2015-11-10 at 15 16 04]
https://cloud.githubusercontent.com/assets/853051/11079018/35716c9c-87be-11e5-985d-de61d9a671d4.png
prod (v0.4)
[image: screen shot 2015-11-10 at 15 15 54]
https://cloud.githubusercontent.com/assets/853051/11079019/358b8e92-87be-11e5-89bb-d1dfcf5b6e84.png
—
Reply to this email directly or view it on GitHub
https://github.com/mapzen/vector-datasource/issues/402.

So that totally fixes it, but what!?
Does that mean v0.5 tiles require Tangram v0.4 with this feature? That
seems weird. Is this a Tangram regression?
On Tue, Nov 10, 2015 at 3:34 PM, Brett Camper<EMAIL_ADDRESS>wrote:

Whoa interesting. Is it possible winding order is backwards on that ring?
This can be a visual symptom of that. We enforce/fix winding order on
standalone/non-tiled data sources, but by default assume it is already
correct on tiled sources.
Can you try adding this option in the 'source' block, with the MVT source
and see if it makes any difference?
enforce_winding: true
On Tuesday, November 10, 2015, Nathaniel V. KELSO <
<EMAIL_ADDRESS>wrote:

Testing dev against prod with exactly the same stylesheet removed 2 faces
of extruded 3d buildings.
This is a ship block for v0.5!
Is this related to the multipart change we landed for MVT
https://github.com/mapzen/mapbox-vector-tile/issues/20? When I set
this
to topojson (instead of mvt) it works fine.
sources:
osm:
EraserMaps the app only supports MVT format tiles
type: TopoJSONTiles #MVT
url: //vector.dev.mapzen.com/osm/all/{z}/{x}/{y}.topojson
http://vector.dev.mapzen.com/osm/all/{z}/{x}/{y}.topojson
http://vector.dev.mapzen.com/osm/all/{z}/{x}/{y}.topojson
#mvt
16/37.7857/-122.4014
https://github.com/tangrams/eraser-map
dev (v0.5-pre)
[image: screen shot 2015-11-10 at 15 16 04]
<
https://cloud.githubusercontent.com/assets/853051/11079018/35716c9c-87be-11e5-985d-de61d9a671d4.png
prod (v0.4)
[image: screen shot 2015-11-10 at 15 15 54]
<
https://cloud.githubusercontent.com/assets/853051/11079019/358b8e92-87be-11e5-89bb-d1dfcf5b6e84.png
—
Reply to this email directly or view it on GitHub
https://github.com/mapzen/vector-datasource/issues/402.

—
Reply to this email directly or view it on GitHub
https://github.com/mapzen/vector-datasource/issues/402#issuecomment-155602331
.

No it's a tile data issue, it means you are probably right that it's from
that MVT change, which is apparently encoding some rings backwards.
On Tuesday, November 10, 2015, Nathaniel V. KELSO<EMAIL_ADDRESS>wrote:

So that totally fixes it, but what!?
Does that mean v0.5 tiles require Tangram v0.4 with this feature? That
seems weird. Is this a Tangram regression?
On Tue, Nov 10, 2015 at 3:34 PM, Brett Camper<EMAIL_ADDRESS><javascript:_e(%7B%7D,'cvml','notifications@github.com');>>
wrote:

Whoa interesting. Is it possible winding order is backwards on that ring?
This can be a visual symptom of that. We enforce/fix winding order on
standalone/non-tiled data sources, but by default assume it is already
correct on tiled sources.
Can you try adding this option in the 'source' block, with the MVT source
and see if it makes any difference?
enforce_winding: true
On Tuesday, November 10, 2015, Nathaniel V. KELSO <
<EMAIL_ADDRESS><javascript:_e(%7B%7D,'cvml','notifications@github.com');>>
wrote:

Testing dev against prod with exactly the same stylesheet removed 2
faces
of extruded 3d buildings.
This is a ship block for v0.5!
Is this related to the multipart change we landed for MVT
https://github.com/mapzen/mapbox-vector-tile/issues/20? When I set
this
to topojson (instead of mvt) it works fine.
sources:
osm:
EraserMaps the app only supports MVT format tiles
type: TopoJSONTiles #MVT
url: //vector.dev.mapzen.com/osm/all/{z}/{x}/{y}.topojson
http://vector.dev.mapzen.com/osm/all/{z}/{x}/{y}.topojson
http://vector.dev.mapzen.com/osm/all/{z}/{x}/{y}.topojson
<http://vector.dev.mapzen.com/osm/all/{z}/{x}/{y}.topojson

#mvt
16/37.7857/-122.4014
https://github.com/tangrams/eraser-map
dev (v0.5-pre)
[image: screen shot 2015-11-10 at 15 16 04]
<

https://cloud.githubusercontent.com/assets/853051/11079018/35716c9c-87be-11e5-985d-de61d9a671d4.png

prod (v0.4)
[image: screen shot 2015-11-10 at 15 15 54]
<

https://cloud.githubusercontent.com/assets/853051/11079019/358b8e92-87be-11e5-89bb-d1dfcf5b6e84.png

—
Reply to this email directly or view it on GitHub
https://github.com/mapzen/vector-datasource/issues/402.

—
Reply to this email directly or view it on GitHub
<
https://github.com/mapzen/vector-datasource/issues/402#issuecomment-155602331
.

—
Reply to this email directly or view it on GitHub
https://github.com/mapzen/vector-datasource/issues/402#issuecomment-155607811
.

@rmarianski over to you to debug as final preflight check for https://github.com/mapzen/mapbox-vector-tile/issues/20.

/cc @zerebubuth for second pair of eyes as this seems to be the last thing blocking v0.5 going out the door.

This is really odd. According to the Shapely docs the way we're using orient is correct:

A sign of 1.0 means that the coordinates of the product’s exterior ring will be oriented counter-clockwise.

Which, with y positive, matches what the v1.0.2 spec says about exterior rings:

In a frame where the Y axis is positive up, this would make the winding order appear counter clockwise.

However, I just wrote a little script to check these things on dev, and it's erroring all over the place. Either one of these bits of documentation is wrong, or the "Shoelace formula" produces opposite-signed areas to whatever method GEOS/Shapely is using. Confusement.
I'll see if just flipping the sign helps.

I think mapzen/mapbox-vector-tile#22 will fix this issue.
The reason isn't that either the docs are wrong, or that the area calculations are different: It's that "a frame where the Y axis is positive up" does not mean "geographic coordinate system", although that's how I interpreted it.
In fact, the y coordinates in an MVT tile are flipped from the geographic coordinate system, so a polygon that's in CCW orientation in geographic coordinates will continue to be CCW in the y-down tile coordinate system. The only problem with that is that we want the opposite orientation: clockwise orientation in geographic (y-up) coordinates, which will produce clockwise orientation in screen tile (y-down) coordinates, but counter-clockwise orientation in numeric tile coordinates and therefore a positive area.
TL;DR: before encoding polygons from a geographic coordinate system, they should be clockwise oriented, which is the opposite of the usual OGC convention.

I've confused myself so much that I've made a diagram to try and convince myself.

Why would we not have seen this problem before? A new processing step for
the multi-poly flattening?
On Wed, Nov 11, 2015 at 8:09 AM, Matt Amos<EMAIL_ADDRESS>wrote:

I've confused myself so much that I've made a diagram to try and convince
myself.
[image: tile_coords]
https://cloud.githubusercontent.com/assets/271360/11091739/796ccdf8-8875-11e5-8708-8e5b901c5eeb.png
—
Reply to this email directly or view it on GitHub
https://github.com/mapzen/vector-datasource/issues/402#issuecomment-155782457
.

Why would we not have seen this problem before? A new processing step for the multi-poly flattening?

Yup, we landed mapzen/mapbox-vector-tile#20, and that's what has caused this. We previously weren't enforcing an order, so it's possible that we are 99% right and 1% wrong in prod. That PR should have changed it to 100% right but, because confusedness, it looks like it as actually 100% wrong.
If there was a facepalm emoji, I would add it in here.

Thanks for investivating! Let's get this on dev to verify the fix.

Verified :)


Increased extensibility, added more questions

I added some new 'murica spellings too.

Everything's all together now

Hey, unfortunately this will have to be merged with the latest. While we were #keepingTheInternetGreat unfortunately a conflict came up. Sorry!

This probably should be closed due to #13


CORS plugin usage is illegal.

Hi!
cors plugin doesn't have a licence. There's an issue but no progress so far for 9 months.
Currently, any commercial or private usage is prohibited with no explicit licence chosen.
PS Personally, I don't care much about these licences but my company's lawyer.

Still no progress?

@sirkon
https://github.com/captncraig/cors/pull/14
MIT was added.

@My1 Licence seems to be Apache.
https://github.com/mholt/caddy/blob/15fecbc16151308959674a5ce3843efb9e66bd5f/LICENSE.txt#L1

@atilkan this issue was not about caddy's license, but rather about the license of the cors plugin, which is MIT, which is basically "do whatever you want but don't blame us".
while what you are stating is true, caddy's license totally doesnt matter for this specific issue.


fix(watch): fix gulp watch errors

Fixes #252 where gulp watch fails because the file is removed

This does not fix #252. Running the build task also runs the clean task, so gulp-changed does nothing and all .ts files are passed to typescript.
See my comment.

Not merging yet since this doesn't seem to resolve the issue. Can @PWKad @Gheoan provide some feedback?

Not sure this fix was confirmed by a few users in the gitter channel.  I think someone mentioned PRing a more robust solution but I don't see that out there yet so any recommendations welcome @Gheoan

Closing this for now until we get a better recommendation.


Add zsh completion

This PR aims to provide zsh completion for the sdk command.
Many completions are provided as zsh plugins through oh-my-zsh, although I find it more convenient to have them in each project. This way, both the project and the completions can evolve accordingly instead of relying on the plugin author to keep the completions up to date.
Other projects such as hub or docker-compose manage zsh completions this way.

Thanks for yet another great PR! Great work!

Hi @marc0der,
I've noticed this doesn't make much sense unless we include the sdk.zsh_completion file into the sdkman installation files (so it's available under .sdkman/etc). WDYT?


[eralchemy2] Fork of ERAlchemy for further development

Unfortunatley, this repo became stale for a quite a while.
As it is not compatible with current SQLAlchemy versions I created a fork of it.
I wrote Alexis by mail and asked if he could integrate the needed change, but did not get an answer for a few months.
My fork can be found here:
https://github.com/maurerle/eralchemy2/
Or installed from here:
https://pypi.org/project/eralchemy2/
Or by writing
pip install eralchemy2
You can support further development there.
If Alexis comes back to this repo I would be happily handing this back over to the original eralchemy which was very good supported for years.
Thank you @Alexis-benoist - I hope this is also okay for you.

@maurerle thanks a lot for your efforts and the fork

Relly cool that you've done the fork and released it @maurerle ! Thanks a lot - we just merged a PR in Apache Airlfow that helps us to produce automatically (via pre-commit) generated documentation for our internal DB schema thanks to your fork https://github.com/apache/airflow/pull/26217).
:bow:

Thank you @maurerle for your effort maintaining eralchemy !
We have just updated using eralchemy2 also for @globaleaks: https://github.com/globaleaks/GlobaLeaks/blob/devel/documentation/data/database.pdf

@maurerle can you please comment on the current state and maybe just close this one?

The latest release is now available on eralchemy:
https://pypi.org/project/eralchemy/
You can read more about it here:
https://github.com/eralchemy/eralchemy/releases/tag/v1.5.0
and install it using pip install eralchemy[graphviz].


file name (%t) is not hightlighted in non-focused windows

Dear all,
when working with multiple splitted windows in VIM. only the file name on the current window is hightlightted. Do you know how to hightlight the file names on all windows?
Please see my snapshot and explainations here:
https://drive.google.com/file/d/0B9EysH9zt-OIS0pWckJKc2g4Slk/view?usp=sharing

Note: my setttings in ~/.vimrc are:
let g:airline_section_c = '%t%m%r'
set t_Co=256"
colorscheme   badwolf
many thanks
David Duc

apologies for the late reply.  you can fix this by modifying the theme directly.  easiest way is to just copy the theme you like into your ~/.vim/autoload/airline/themes and modify the inactive colors to your liking.
alternatively, you can also use g:airline_theme_patch_func to make minor updates, which is in the docs.

alternatively, you can also use g:airline_theme_patch_func to make minor updates, which is in the docs.

This looks very promising, but I don't see much on using this g:airline_theme_patch_func in the docs nor the wiki. There is an example use of it in each the :help and the wiki, which is more than nothing. I'm using the default airline theme and would like the inactive window's filename to be readable. Can you please provide an example snippet of code which does this? I know nothing about color themes and I'm happy with the default airline theme except for this issue. Looking at the dark.vim file for inactive is a bit intimidating to me:
let s:airline_a_inactive = [ '#4e4e4e' , '#1c1c1c' , 239 , 234 , '' ]
let s:airline_b_inactive = [ '#4e4e4e' , '#262626' , 239 , 235 , '' ]
let s:airline_c_inactive = [ '#4e4e4e' , '#303030' , 239 , 236 , '' ]
let g:airline#themes#dark#palette.inactive = airline#themes#generate_color_map(s:airline_a_inactive, s:airline_b_inactive, s:airline_c_inactive)
let g:airline#themes#dark#palette.inactive_modified = {
      \ 'airline_c': [ '#875faf' , '' , 97 , '' , '' ] ,
      \ }

Thank you @bling for interacting with the community on this issue!

alternatively, you can also use g:airline_theme_patch_func to make minor updates, which is in the docs.

This looks very promising, but I don't see much on using this g:airline_theme_patch_func in the docs nor the wiki.

I am new to this as well. I poked around and the following seems to do the trick for me:
let g:airline_theme_patch_func = 'AirlineThemePatch'
function! AirlineThemePatch(palette)
    for colors in values(a:palette.inactive)
      " The colors array has the following elements:
      "   [guifg, guibg, ctermfg, ctermbg, opts]
      " Using '' should get them back to the default values.
      let colors[0] = ''
      let colors[2] = ''
    endfor
endfunction


Proper compute n-body sample synchronization

Description
This PR adds proper synchronization to the compute N-Body sample for implementations with separate graphics and compute queues. Fixes #3.
General Checklist:
Please ensure the following points are checked:

[x] My code follows the coding style
[x] I have reviewed file licenses
n/a I have commented any added functions (in line with Doxygen)
[x] I have commented any code that could be hard to understand
[x] My changes do not add any new compiler warnings
[x] My changes do not add any new validation layer errors or warnings
n/a I have used existing framework/helper functions where possible
[x] My changes build and run on Windows, Linux, macOS and Android. Otherwise I have documented any exceptions

I'm still not able to build this. The third approval will need to come from someone other than me.

Sorry to hear Matt. I just checked this with a clean new system and I could compile it without problems, but I can imagine that this once again may be caused by some submodule not properly getting updated.

It's likely user error on my part. Let me take another look.

Yep, my fault. Looks good to me now.


[ISSUE-9168] DOCS: Update the batch delay default value

Fixes #9168

@sijia-w Thanks for your contribution.
Except code, the values in client-libraries-go and client-libraries-cgo also need updating for different versions.

@sijia-w Thanks for your contribution.
Except code, the values in client-libraries-go and client-libraries-cgo also need updating for different versions.

/pulsarbot run-failure-checks

@sijia-w Can you rebase this pull request?

/pulsarbot run-failure-checks

@sijia-w Could you rebase this pull request when you read the message? Thank you.


Improvements for the event system

I have a few points for improvements here:
- Language change event:

I would only fire it when the language really has been changed: changing the language from en to en should not fire an unnecessary language change event.
Providing the old and new set locale as arguments can be useful in some cases: on('lang:change', function (oldLocale, newLocale) {}).

- Dictionary change event:

Passing the locale in what the dictionary was changed in can be useful too: on('dict:change', function (inWhatLocale) { }).

Everything implemented in v2 :+1:


Create solution patches hyperlink is broken

Hyper link for Create solution patches is broken under See also section

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1dda8ad9-01d8-aa29-704a-c8f13868a350
Version Independent ID: ef98dcae-9534-425c-1e27-7255228af17f
Content: Update a solution - Power Apps
Content Source: powerapps-docs/maker/data-platform/update-solutions.md
Service: powerapps
GitHub Login: @Mattp123
Microsoft Alias: matp

@subhankars - thank you for posting this issue. The link has been fixed in the article and will be published live in a few hours. Closing issue.


remove kotlin dependency, rename plugin

Pull Request Test Coverage Report for Build #8

7 of 8 (87.5%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+2.1%) to 59.358%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/main/kotlin/CoverallsJacocoPlugin.kt
0
1
0.0%

Totals

Change from base Build #7:
2.1%

Covered Lines:
111

Relevant Lines:
187

💛  - Coveralls


Add simple sinatra example

I'm working on OSS for the other side of SAML and a simple / faked IDP is really useful for our CI, QA and demo purposes - thanks so much for this gem!
I used this to to hack together a sinatra app and thought I might add back a simple example for getting that working.
I'd love to figure out how to use the views from the gem rather than my recreated ones. I think also this gem might need an xmlenc runtime dependency?
I'm using a deployed version of the sinatra app in the flow described here - https://github.com/nextauthjs/next-auth/pull/928

there is an open PR already to add the xmlenc gem as a runtime dependency.
it was initially decided to have that optional since not everybody needs/wants it.

thanks for the sinatra example

@sbauch Good job!
But, one small request that I have. Can you add very simple test that prove your example app will work with gem itself. Because, for future maintenance we might need to change or update gems. And if we don't have a test we might need to ask manual test all that kind of changes.

@mjobin-mdsol about xmlenc.
I think gem is required to into Gem spec's gem because, this gem has part of logic that actually using xmlenc.

I was thinking the exact same thing as @Zogoo when revisiting this. If you could add a test that runs your Sinatra example, that would be super awesome
About xmlenc @Zogoo we can talk about it on #128 but it is only required if you add the encryption: {} option hash to encode_response call in your POST response. which is the default in the readme, thus the confusion.

I'm happy to write a better test, but not sure what you all are looking for beyond what I added.
Maybe a quick little pseudocode to show what you'd want?


Upgrade client libraries and remove unused ones

Along with upgrading the packages, remove unused ones. jQuery, Morgan and Merge seem to be unused.
Acceptance Criteria

[ ]

Steps for QA:

There has been no known issues in staging as a result of these removed libraries. Closing this issue.


Win32 "Spyder Documentation" fails to open

From grizzly.nyo on 2013-08-31T09:01:29Z
See patch below for possible fix:
Please note that reporting bugs from Spyder's help menu ("?" > "Report
issue...") will fill version details for Spyder, Python and Qt in this description for you.
What steps will reproduce the problem?

build/install spyder 2.2.3 from source
start spyder
*hit F1 What is the expected output? What do you see instead? CHM doc file open. Nothing What version of the product are you using? On what operating system? Spyder 2.2.4dev, Python 2.7.5 32bits, Qt 4.8.4, PyQt4 (API v2) 4.9.6 on Windows

Please provide any additional information below
. File is created as expected.
diff -r f9204b9b5799 setup.py
--- a/setup.py	Sat Aug 31 10:52:12 2013 +0300
+++ b/setup.py	Sat Aug 31 17:01:00 2013 +0300
@@ -97,7 +97,9 @@
sys.path.insert(0, os.path.abspath(build.build_lib))
dirname = self.distribution.get_command_obj('build').build_purelib
self.builder_target_dir = osp.join(dirname, 'spyderlib', 'doc')
-

       if not osp.exists(self.builder_target_dir):

           os.mkdir(self.builder_target_dir)

       hhc_exe = get_html_help_exe()
       self.builder = "html" if hhc_exe is None else "htmlhelp"

diff -r f9204b9b5799 spyderlib/spyder.py
--- a/spyderlib/spyder.py	Sat Aug 31 10:52:12 2013 +0300
+++ b/spyderlib/spyder.py	Sat Aug 31 16:53:11 2013 +0300
@@ -841,8 +841,7 @@
# * Trying to find the chm doc
spyder_doc = osp.join(doc_path, "Spyderdoc.chm")
if not osp.isfile(spyder_doc):

           spyder_doc = osp.join(doc_path, os.pardir, os.pardir,

                                 "Spyderdoc.chm")

           spyder_doc = osp.join(doc_path, os.pardir, "Spyderdoc.chm")
       \# * Trying to find the html doc
       if not osp.isfile(spyder_doc):
           spyder_doc = osp.join(doc_path, "index.html")

Original issue: http://code.google.com/p/spyderlib/issues/detail?id=1545

From ccordoba12 on 2013-12-30T16:00:09Z
Thanks for the patch and sorry for overlooking it.
I'm going to trust you because I don't have a Python(x,y) installation to test.
Labels: MS-v2.3

From ccordoba12 on 2014-01-02T08:45:45Z
This issue was updated by revision 32cd5a09b788 .

Thanks to grizzly.nyo for the patch

Status: Fixed


Only two digits after floating point

There are only 2 digits after floating point for transaction  at Latest transaction section at main page and Transaction section at an address page. This result in additional request to explorer  and increase server load.

It should be 9 digits.

Resolved in #33.


"Test type arguments in operator ==(Object other)" is a very confusing error message

This code:
  @override
  bool operator ==(dynamic other) {
    if (other.runtimeType != runtimeType)
      return false;
    final AvatarImage typedOther = other as AvatarImage; // line 465
    return username == typedOther.username
        && photoManager == typedOther.photoManager
        && twitarr == typedOther.twitarr;
  }

Led to this message from the analyzer:
[info] Test type arguments in operator ==(Object other) (/home/ianh/dev/cruisemonkey/lib/src/logic/cruise.dart:465:36)

I have no idea what this means.

See also https://github.com/dart-lang/sdk/issues/35523 which is about the lint itself being bad. This specific issue is about the wording of the lint being unclear.


Fix typo in IDX10638 log message.

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@nazukj our normal mode of checkin in into dev, then when we are close to release, we merge into release, then once released, merge into master.
Can you please submit a new PR against dev.
Thanks

sure thing

@brentschmaltz this is my id. :) Not my PR.


Golem pet Third Ability Bug?

Describe the bug
Basically the title of the third ability, "Toss",  doesn't show up(Check screenshot for clarification). Can't confirm it's only me so could just be something on my side.
Profile/Location
It happens with every player that has a golem pet.
Screenshots

Desktop (please complete the following information):

OS: Windows 10
Browser Chrome
Version 86.0.4240.198

Fixed with https://github.com/SkyCryptWebsite/SkyCrypt/commit/ea604793af43f83fb671abac124fef7f2bc75a45


import of sqlite3 is incomplete

VSCode Version:1.47.3
OS Version:Win 10

Steps to Reproduce:
The following code produces this error:
import sqlite3
print(sqlite3.version)
1.Exception has occurred: AttributeError
partially initialized module 'sqlite3' has no attribute 'version' (most likely due to a circular import)
File "C:\Users\howar\Google Drive\PythonCode\database\sqlite3.py", line 5, in
sqlite3.version
File "C:\Users\howar\Google Drive\PythonCode\database\sqlite3.py", line 3, in
2.From the terminal console the code works correctly
hgc@HP-Z440-MX:~
$ python3
Python 3.7.3 (default, Dec 20 2019, 18:57:59)
[GCC 8.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.

import sqlite3
print(sqlite3.version)
2.6.0

Does this issue occur when all extensions are disabled?: Yes/No

Duplicate of https://github.com/microsoft/vscode/issues/103512
Again, this is not a VS Code problem. Please don't open duplicate issues


MM-47457: Removed global state from 'actions/views/posts.js'

Summary
Removed global state from 'actions/views/posts.js'
Ticket Link
Fixes https://github.com/mattermost/mattermost-server/issues/21359
Jira https://mattermost.atlassian.net/browse/MM-47457
Release Note
NONE

Hello @codewithshariq,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

E2E tests not automatically triggered, because PR has no approval yet. Please ask a developer to review and then try again to attach the QA label.

Closing as per https://github.com/mattermost/mattermost-webapp/pull/11367#issuecomment-1282969494


Caution  "Don't use azbb - it is in sustain mode and the npm package is out of date"

The entire script post this message uses AZBB, and the link provided refers to this architecture!
So what command should be used?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 104eba32-c77e-b013-e161-ff616d16a0f7
Version Independent ID: 3bc27d0a-ef32-f5f6-4c85-fe8e2e45155e
Content: Hub-spoke network topology in Azure - Azure Reference Architectures
Content Source: docs/reference-architectures/hybrid-networking/hub-spoke.md
Service: architecture-center
Sub-service: reference-architecture
GitHub Login: @adamboeglin
Microsoft Alias: pnp

Thanks for reporting - this issue is under review.  This is a Microsoft Internal DevOps Bug ID AB#

@JerryMWeeks thanks for the suggestion.  I will update the content
In the mean time please refer to:
ARM Template: https://github.com/Azure/azure-quickstart-templates/tree/master/101-hub-and-spoke-sandbox
Using Terraform: https://docs.microsoft.com/en-us/azure/developer/terraform/hub-spoke-introduction


Feature/runtimeclasses for v8.0.0

If this PR passes tests, I'm going to merge

Probably can remove the PHP 5.4 checks from the version 8 branch

@joe-meyer way ahead of you :)


Add phantom types to HMAC type

Added two phantom types to the HMAC type to define the context and digest of the underlying hash.

I was conflicted about this, but since we export the MacKey constructors, people can make their own (very questionable) decision to re-cast and reuse a MacKey with more than one Hash.


Automatically log out and display a warning when receiving a 412 precondition not met

We won't be using the 412 Precondition Failed response any time soon, so I am closing this. But it will be useful to refer to this for the X-Session-Expires header stuff, since the handleSessionInvalidation(...) method could be useful!


[SPARK-44000][SQL][FOLLOWUP] Add comments when picking build side for BNLJ

What changes were proposed in this pull request?

This PR adds comments to give context which build side to use for BNLJ as per this discussion.
Why are the changes needed?

These changes are needed to address the feedback.
Does this PR introduce any user-facing change?

No.
How was this patch tested?

Not applicable.

cc @dongjoon-hyun @viirya

Merged to master. Thank you, @viirya , too.


Incomplete Instructions

"To trigger an event, you need to turn on the Delivery Report option of the SMS that you send. Try sending a message to your phone with Delivery Report turned on."
And how, pray tell, do you turn Delivery Report on?

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: d6110855-d907-888e-feff-ad1407d7fd48
Version Independent ID: b88eef5b-77e7-6da2-688c-84d1f713cd05
Content: Quickstart - Handle SMS and delivery report events - Azure Communication Services
Content Source: articles/communication-services/quickstarts/sms/handle-sms-events.md
Service: azure-communication-services
Sub-service: sms
GitHub Login: @tophpalmer
Microsoft Alias: chpalm

@mmichaels1970
Thanks for your feedback! We will investigate and update as appropriate.

Hi @mmichaels1970, thanks for your patience. You can turn on DeliveryReports for SMS events by using the optional parameter "enableDeliveryReport" and set it to true when sending SMS. There's some documentation here: Quickstart - Send an SMS message - Azure Communication Services | Microsoft Learn
Hope that helps!

We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


Typo in /config/module.config.php

Hi I've found a typo on line 10 in module.config.php
use Zend\View\Modle\ViewModel;
should be Zend\View\Model\ViewModel;

Created a Pull Request to fix this issue

This repository has been closed and moved to laminas-api-tools/api-tools-documentation; a new issue has been opened at https://github.com/laminas-api-tools/api-tools-documentation/issues/9.


How to add the domain and setup a secured MQTT broker for the VPS docker

Hi,
I have successfully set up the Mosquitto Docker on my server, but I'm not sure how to add a domain for it and also enable Let's Encrypt.

Easiest way is to use CaddyServer as SSL proxy and expose websocket port.
I have that setup already and will see if I get time to do the write-up.

This won't work since Websocket uses ws:// and Secure Websocket uses wss:// prefix.
CaddyServer gives both Free SSL and reverse proxy together.

@sayidhe
Check README.md 5.1 for instructions.


Buffer Overflow @Unverified

Hi,
I am facing buffer overflow in the following location.
\tokenizer\tokenizer_kernel_1.cpp
The size of the buffer used by get_token is not properly verified before writing data to the buffer.
get_token (
…….
ch = streambuf->sgetc();
while ( bodyset[static_cast(ch)] && ch != EOF )
…….
ch = streambuf->snextc();
Can you kindly solve this

This isn't a bug.  And please stop posting these auto generated messages.


Question: Can we just suppress error TS2311?

As currently there is no big progress for extension classes, I want to just suppress the error temporarily to subclass some built-in types. It seems that there is only one tag to suppress an error ("suppressImplicitAnyIndexErrors"), but is there any way to suppress this one?
error TS2311: A class may only extend another class.

Sorry, this doesn't enable anything.


Task - Comprehensive collection object - date format

Please change the fields for the date in the Day - Month - Year order.
Most of the specimen labels have the date in this format, and it is hard to process data in reverse order. I do mistake every second time I work with the form. This will also match to the filed order on the Source task.

I think that's fine, as long as it isn't month-day-year maddness.

Please return the date format.

The format follows the standard as it is rendered.  There was a long chat about this.

It is following the standard, which is good for the data exchange, but the task is designed for efficiend data parcing. 99.9% of the labels has data in a format DD-MM-YYYY, or MM-DD-YYYY, or something similar. The task was originally designed in YEAR-DD-MM, and it was extremely difficult to work with the data. When rendering or exporting data, the date could (and should) be exported in a preferred format.

YYYY MM DD is unambiguous, and reduces the risk of confusing MM/DD and DD/MM formats.

Some confusion, but not all, is eliminated by validation.

The format is unumbiguous, but we work with specimen labels and literature, this is data exchange format, but not the format of the data presentation, at least in historical specimen labels, MM/DD, DD/MM is another issue, you have to interpret the label data and know the origin. MM/DD is mostly used in US, while DD/MM in Europe. if you have label 07/12/1950, you would have hard time resolving it. I really like to parse data the way they are presented on the label, not the "standard" way, which is designed as a standard for data exchange. At the very beginning ot TW development we agreed that the tasks should be optimized for workflow. The standards are embeded in the model, but hidded from the user in all cases where standards make data processing more complicated.

Closing as out of date.


Analytics doesn't show up in the AppCenter on iOS

Description
I implemented the analytics sdk for my cordova application on iOS and Android. It works fine on Android but on iOS I do not have any metrics being shown in the appcenter analytics pane.

Repro Steps
Please list the steps used to reproduce your issue.

Install SDK and set APP_SECRET
Run on iOS
Test the SDK

window.AppCenter.Analytics.isEnabled(() => showDebugDialog('is enabled'), (err: any) => showDebugDialog('not enabled ' + err));
window.AppCenter.Analytics.trackEvent('Object opened', null, () => showDebugDialog('success'), (err: any) => showDebugDialog(err));
(both shows success)

Go to appcenter diagnostic pane => nothing shows up.

Details

Which SDK version are you using?

0.3.0

Which OS version did you experience the issue on?

iOS 12.1.2

What version of Cordova, Cordova platforms, Cocoapods, and Ruby are you using?

Cordova 6.5.0

What device version did you see this error on?  Were you using a simulator or a physical device?

iPhone 6s Plus / iPhone 8 Plus

What third party plugins are you using?

platforms/ios
 pod repo update
before any operations.
In case of difficulties to uninstall a previous broken version, follow @annakocheshkova instructions


Bug while creating addon

I chose to use "behaviour pack" module and then it says it's done and it's running npm install. It doesn't ask me to chose between javascript/typescript and it only creates 2 files:
package.json
gulpfile.js
So no "packs" folder.
I am using version 6.9.0(node js)

@mariglenpupa When you chose the behavior pack module, did you press "space" to select "Behaviors" or did you just press enter at the prompt?
I'm able to reproduce this behavior if I don't choose any module at all at the prompt.
It should look like this:

oh my bad mate... it works now thank you!


Azure Static Web App build

I really like this theme and was devastated when I could not deploy to Azure using GitHub Actions.
Per the README, a requirement is Hugo extended with npm postcss installed. Default Azure Static Web App does not install. If following the standard process to deploy.
Default workflow:
jobs:
  build_and_deploy_job:
    if: github.event_name == 'push' || (github.event_name == 'pull_request' && github.event.action != 'closed')
    runs-on: ubuntu-latest
    name: Build and Deploy Job
    steps:
      - uses: actions/checkout@v3
        with:
          submodules: true
      - name: Build And Deploy
        id: builddeploy
        uses: Azure/static-web-apps-deploy@v1
        with:
          azure_static_web_apps_api_token: ${{ secrets.AZURE_STATIC_WEB_APPS_API_TOKEN_MANGO_SKY_0950B4610 }}
          repo_token: ${{ secrets.GITHUB_TOKEN }} # Used for Github integrations (i.e. PR comments)
          action: "upload"
          ###### Repository/Build Configurations - These values can be configured to match your app requirements. ######
          # For more information regarding Static Web App workflow configurations, please visit: https://aka.ms/swaworkflowconfig
          app_location: "/" # App source code path
          api_location: "" # Api source code path - optional
          output_location: "public" # Built app content directory - optional
          app_build_command: ""
          ###### End of Repository/Build Configurations ######

Standard message is:
Error: Error building site: POSTCSS: failed to transform "css/main.css" (text/css). Check your PostCSS installation; install with "npm install postcss-cli"

Solution:
Modify workflow to add actions to extend Hugo and install required npm modules. I went back and forth with node.js and running Hugo. In the end, running Hugo --minify was needed for the site to rebuild. Don't understand why, but when I don't use those lines, I'm back to the failed postcss error.
jobs:
  build_and_deploy_job:
    if: github.event_name == 'push' || (github.event_name == 'pull_request' && github.event.action != 'closed')
    runs-on: ubuntu-latest
    name: Build and Deploy Job
    steps:
      - uses: actions/checkout@v3
        with:
          submodules: true

      - name: Setup Hugo
        uses<EMAIL_ADDRESS>        with:
          hugo-version: 'latest'
          extended: true

      - name: Setup Node.js environment
        uses: actions/setup-node@v3

      - name: Install npm pre-reqs
        run: |
          npm install -g postcss postcss-cli autoprefixer
          npm fund

      - name: Run Hugo
        run: hugo --minify

      - name: Build And Deploy
        id: builddeploy
        uses: Azure/static-web-apps-deploy@v1
        with:
          azure_static_web_apps_api_token: ${{ secrets.AZURE_STATIC_WEB_APPS_API_TOKEN_MANGO_SKY_0950B4610 }}
          repo_token: ${{ secrets.GITHUB_TOKEN }} # Used for Github integrations (i.e. PR comments)
          action: "upload"
          ###### Repository/Build Configurations - These values can be configured to match your app requirements. ######
          # For more information regarding Static Web App workflow configurations, please visit: https://aka.ms/swaworkflowconfig
          app_location: "/" # App source code path
          api_location: "" # Api source code path - optional
          output_location: "public" # Built app content directory - optional
          app_build_command: ""
          ###### End of Repository/Build Configurations ######

Hope this helps anyone trying to use this theme in Azure using Static Web App.
I did try this initially in Netlify and got the same error. I'm assuming the same fix would work there if using GitHub actions to deploy.

Hi @kendrickcc ... I'm running into the same issue but not solving even with following what you posted above. Did you need to add scripts to your package.json file as well to make this work?

I don't recall editing the package.json, and I'm not able to reproduce it successfully. I will keep trying, but it appears I'm broken now as well.

Sorry for the belated response, I should have posted this sooner. I did figure it out. This might not be the most technically correct explanation, but how I understand it is the Github Action Azure Static Web Apps creates does not support installing Hugo Extended. So, in order to work around it, I ended up altering the Build and Deploy section as the screenshot shows:

change app_location to /public
comment out the output_location
add skip_app_build: true to Azure does not try to build the site again.

Essentially GitHub Actions is building the site already, so I don't need Azure to do it again, when I can just push the published files to Azure instead.
Hopefully this helps someone... !


API has confusing/wrong description

Bug description
Class LLM in litgpt/api.py has argument prompt which according to the function signature is a str. However in the docstrings prompt is a tensor apparently. Line 217 calls prompt_style apply so this indicates that the docstrings are not updated.
This is confusing. In the Readme/Tutorial files, the api is always used by first calling prompt_style before passing that to the .generate function. This indicates that prompt_style is being applied twice (which isnt great  if during training prompt_style has been applied only once.)
What operating system are you using?
Linux
LitGPT Version
Version: 0.4.3

Thanks a lot for the note. I think this was just a docstring issue (just fixed it).
The generate function itself does not apply the prompt_style unless I am overlooking something. The prompt style in generate would only be applied if you use the main function, which is what's used when you use litgpt generate:
https://github.com/Lightning-AI/litgpt/blob/1ede90dc281e60ff963bbfea345e998a358082be/litgpt/generate/base.py#L228
the API is using generate function in that file.
Please feel free to reopen, it's possible that I am not seeing it correctly. In any case, thanks for raising that!


archivist: fix recent semantic drift in S3 SDK

PR Checklist
PR Structure

[x] This PR has reasonably narrow scope (if not, break it down into smaller PRs).
[x] This PR avoids mixing refactoring changes with feature changes (split into two PRs
otherwise).
[x] This PR's title starts with name of package that is most changed in the PR, ex.
services/friendbot

Thoroughness

[ ] This PR adds tests for the most critical parts of the new functionality or fixes.
[ ] I've updated any docs (developer docs, .md
files, etc... affected by this change). Take a look in the docs folder for a given service,
like this one.

Release planning

[ ] I've updated the relevant CHANGELOG (here for Horizon) if
needed with deprecations, added features, breaking changes, and DB schema changes.
[ ] I've decided if this PR requires a new major/minor version according to
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.

Summary
Fixes to the S3 backend for stellar-archivist. The S3 APIs changed semantics since I last tested it.

Codecov Report

Merging #1637 into master will decrease coverage by <.01%.
The diff coverage is 16.66%.

@@            Coverage Diff             @@
##           master    #1637      +/-   ##
==========================================
- Coverage   45.16%   45.15%   -0.01%
==========================================
  Files         381      381
  Lines       25768    25771       +3
==========================================
  Hits        11638    11638
- Misses      12952    12955       +3
  Partials     1178     1178

Impacted Files
Coverage Δ

support/historyarchive/s3_archive.go
0% <0%> (ø)
:arrow_up:

support/historyarchive/scan.go
52.61% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0c0e00...2d41016. Read the comment docs.

@ire-and-curses updated with enough fixes to the unit testing system to enable me to test against s3 again. this should land now.


Fix spelling error in readme.md

Module: 00
Lab/Demo: 00
Fixes # .
Change "repro" to "repo" in the "How do I contribute?" section of the readme.md file.
Changes proposed in this pull request:

Thank you for the heads-up on the typo.  I have fixed it as part of other updates/PRs I am doing on labs and demos, so will close your PR.  Thank you again!!


feat: option to send individual sensor values to MQTT

This makes integration in Home Assistant more straightforward.

thanks!


Chapter 14 - npm run lint fails

command npm run lint
gives an error
> lint
> next lint

Failed to load config "next/core-web-vitals" to extend from.
Referenced from: /myroute/nextjs-dashboard/.eslintrc.json

Hey @hyojoongit 👋🏼
What does your .eslintrc.json file look like?
Can I double check you have this:
{
  "extends": "next/core-web-vitals"
}

The file was not in the root directory(was one step outside).. moved the file, and now it works.
But it is not showing any warnings as in the tutorial.

Glad to hear it! 😌


Added Forestry.io as CMS

Great site but missing Forestry.io (Gatsby supporting coming soon) :)

@scottgallant hey, thanks for this :)
I just added Forestry before seeing this PR
https://github.com/peduarte/jamstack-wtf/blob/master/src/components/GettingStarted.js#L209-L213


3D Car Racing Game JS Extension

I would like to add a 3D Car Racing Game for fun. please assign this task to me.
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
What problem is this feature trying to solve?
How do we know when the feature is complete?

@Sulagna-Dutta-Roy I'd like to work on this issue, if it hasn't been solved yet.
Thank you!


Error "Object reference not set to an instance of an object." if FlatTreeDataGridSource is recreated with changing edit mode

Error "Object reference not set to an instance of an object." if FlatTreeDataGridSource is recreated
I`am trying to change EditMode and ReadOnly modes in treeDataGrid in method TreeDataGridInit (code below).
Scenario

Change mode from ReadOnly to Edit (IsGridEditable = true)
Change mode from Edit to ReadOnly (IsGridEditable = false)

Result: "Object reference not set to an instance of an object.". Debugger shows that Hint in TemplateColumn is null. Whats wrong, i cant understand how to avoid this error.
Avalonia 11.0.2. Windows 10 Pro 19045.3930
public void TreeDataGridInit()
{
    var invisible = new GridLength(0);

    if (IsGridEditable)
    {
        var EditOptions= new TextColumnOptions<Hint>
        {
            BeginEditGestures = BeginEditGestures.Tap,
            IsTextSearchEnabled = true
        };

        Source = new FlatTreeDataGridSource<Hint>(Hints)
        {

            Columns =
            {
                //new TextColumn<Hint, int>("Id", x => x.Id, options: new TextColumnOptions<Hint>{MaxWidth = invisible}),
                new TextColumn<Hint, string>("Text", x => x.HintText, (r, v) => r.HintText = v, options: EditOptions),
                new TextColumn<Hint, string>("Comment", x => x.Comment, (r, v) => r.Comment = v, options: EditOptions),
                new TemplateColumn<Hint>("", new FuncDataTemplate<Hint>((a, e) => DeleteButtonInit(a.Id)))
            },
        };
        IsAddButtonVisible = true;
    }
    else
    {
        Source = new FlatTreeDataGridSource<Hint>(Hints)
        {
            Columns =
            {
                new TextColumn<Hint, int>("Id", x => x.Id, options: new TextColumnOptions<Hint>{MaxWidth = invisible}),
                new TextColumn<Hint, string>("Text", x => x.HintText),
                new TextColumn<Hint, string>("Comment", x => x.Comment)
            },
        };
        IsAddButtonVisible = false;
    }
    Source.Selection = new TreeDataGridCellSelectionModel<Hint>(Source) { };
}

Error is avoided by "supportsRecycling: true" but i cant understand why its working

Whatever


feat(typescript-vue-urql): support externally imported DocumentNodes

Description
clones related code and tests from plugin typescript-urql into typescript-vue-urql
Related #7360
Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

validate config properties
validate expected output / generated code

Test Environment:

OS: Darwin 21.2.0 Darwin Kernel Version 21.2.0: Sun Nov 28 20:28:54 PST 2021; root:xnu-8019.61.5~1/RELEASE_X86_64 x86_64
"@graphql-codegen/typed-document-node": "2.2.2"
"@graphql-codegen/typescript": "2.4.2"
"@graphql-codegen/typescript-operations": "2.2.2"
"@graphql-codegen/typescript-vue-urql": "2.2.2"
"@graphql-typed-document-node/core": "3.1.1"
NodeJS: 14.18.1

Checklist:

[x] I have followed the CONTRIBUTING doc and the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

Looks great! Could you create a changeset with yarn changeset?

Looks great! Could you create a changeset with yarn changeset?

I could... but is this a minor or patch update? Since the feature has been in the docs for a long time and just didn't work, I'd expect this to be a patch?!

changeset with patch level added

@ardatan do you need anything else from me to take this forward?

Thank you for your contribution, @benkroeger!
I'll ping you when it is released 📦


#8 convert rtdose

Hi @rnfinnegan & @dalmouiee,
here a contribution for #8. Let me know what you think! :)

Forgot to mention, no test again since it actually uses the platipy function to convert the dose (which should be tested in that repo). But everything around it will be tested with an end-to-end test whenever we get around to that :)