chrome's shortcut is not working

I made some chrome's shortcut icon and successfully added them to taskbar-groups, but nothing happened when I clicked them

This is a desktop shortcut icon, can be opened normally

This is the icon's properties page

Other types of shortcut icons work fine
e.g.

Same here.  I have created a group for browsers, as I use Firefox Nightly, Firefox stable, 2 profiles in Chrome stable and 2 profiles in Edge stable.  Both Firefox are set to open the profile manager every time via argument -p and they work perfectly fine.  Both Edge Profiles are set to run with arguments --profile-directory=Default and --profile-directory="Profile 1", and they work perfectly fine.
Both Chromes are set to run with arguments --profile-directory=Default and --profile-directory="Profile 1", but neither works.  As direct shortcuts, the shortcuts set to run with arguments --profile-directory=Default and --profile-directory="Profile 1" both work perfectly fine.  I also tried removing the double quotation marks, but still did not work.
Using those shortcuts in BINS application (similar application from a StarDock Dev) also work perfectly fine.  Only in here do they not work.

Same here. I have created a group for browsers, as I use Firefox Nightly, Firefox stable, 2 profiles in Chrome stable and 2 profiles in Edge stable. Both Firefox are set to open the profile manager every time via argument -p and they work perfectly fine. Both Edge Profiles are set to run with arguments --profile-directory=Default and --profile-directory="Profile 1", and they work perfectly fine.
Both Chromes are set to run with arguments --profile-directory=Default and --profile-directory="Profile 1", but neither works. As direct shortcuts, the shortcuts set to run with arguments --profile-directory=Default and --profile-directory="Profile 1" both work perfectly fine. I also tried removing the double quotation marks, but still did not work.
Using those shortcuts in BINS application (similar application from a StarDock Dev) also work perfectly fine. Only in here do they not work.

Some path issues
Error message： System.IO.FileNotFoundException: C:\Program Files (x86)\Google\Chrome\Application\chrome_proxy.exe
the 32-bit version is not installed ，so this path not exist
Now I have installed the Canary version [32 or 64 bit]，and recreated the shortcut icon, it works fine after adding to taskbar-groups
the program path becomes to "C:\Users\DeskminiA300\AppData\Local\Google\Chrome SxS\Application\chrome.exe"
https://www.google.com/intl/en/chrome/canary/
I don't know how to change the stable version chrome's installation path, maybe it will work

Same here. I have created a group for browsers, as I use Firefox Nightly, Firefox stable, 2 profiles in Chrome stable and 2 profiles in Edge stable. Both Firefox are set to open the profile manager every time via argument -p and they work perfectly fine. Both Edge Profiles are set to run with arguments --profile-directory=Default and --profile-directory="Profile 1", and they work perfectly fine.
Both Chromes are set to run with arguments --profile-directory=Default and --profile-directory="Profile 1", but neither works. As direct shortcuts, the shortcuts set to run with arguments --profile-directory=Default and --profile-directory="Profile 1" both work perfectly fine. I also tried removing the double quotation marks, but still did not work.
Using those shortcuts in BINS application (similar application from a StarDock Dev) also work perfectly fine. Only in here do they not work.

Some path issues
Error message： System.IO.FileNotFoundException: C:\Program Files (x86)\Google\Chrome\Application\chrome_proxy.exe
the 32-bit version is not installed ，so this path not exist
Now I have installed the Canary version [32 or 64 bit]，and recreated the shortcut icon, it works fine after adding to taskbar-groups
the program path becomes to "C:\Users\DeskminiA300\AppData\Local\Google\Chrome SxS\Application\chrome.exe"
https://www.google.com/intl/en/chrome/canary/
I don't know how to change the stable version chrome's installation path, maybe it will work

Yeah, this is a (relatively recent) change to Chrome installations:
https://www.ghacks.net/2020/06/11/google-chrome-is-soon-going-to-be-installed-in-a-different-directory-on-windows/
It used to always use %ProgramFiles(x86)% (and before that, *ProgramData%, and before that, for single user use in %UserProfile%).....
Mine exists in %ProgramFiles% which is =/= %ProgramFIles(x86)% since my OS is 64 bit.  So the code will likely need to be changed so that it looks in the location specified by the shortcut itself.

Yeah, this is a (relatively recent) change to Chrome installations:
https://www.ghacks.net/2020/06/11/google-chrome-is-soon-going-to-be-installed-in-a-different-directory-on-windows/
It used to always use %ProgramFiles(x86)% (and before that, *ProgramData%, and before that, for single user use in %UserProfile%).....
Mine exists in %ProgramFiles% which is =/= %ProgramFIles(x86)% since my OS is 64 bit. So the code will likely need to be changed so that it looks in the location specified by the shortcut itself.

It will require some tedious operation, cause headaches,, everything-default works better for me
There are also some new issues, some site's shortcuts cannot be added，Illegal character error
1 sites involving chinese characters....like jd.com
2 rarbg.com   (and this special english website)
I am not able to solve it. Looking forward to future updates

Release.zip
Sorry for the headaches! The build was set to x86 so it was looking for x86 program files by default. I had changed it in this small build change. Please test this and see if the same issue occurs.

Release.zip
Sorry for the headaches! The build was set to x86 so it was looking for x86 program files by default. I had changed it in this small build change. Please test this and see if the same issue occurs.

【solved】
Thank you very much for your work
Another questions about chinese characters
Like this website
https://convertio.co/en/             ok
https://convertio.co/zh/             System.Exception: The stub received bad data.
(use chrome to make icons and add them to taskbar-groups)

Error messages will appear when adding icons via + .    (drag to add will not respond)

Can you open a new issue for this if possible? Just easier to track issues overall.

Can you open a new issue for this if possible? Just easier to track issues overall. Keep this one opened though because it is not solved on master yet.

ok, I'll open  a new issus
Thanks again for your reply

It's working on my end perfectly fine now.
Now, to just get Windows UWP apps working and it'll be perfect.  💯

@dzigner
Did you use the version in this post above?

Yes, thank you for pointing that out. I downloaded, and now its working fine.


wasm-bindgen memory optimization seems to have broken the plugin

Steps to reproduce:

Do the wasm-pack tutorial
Install Vite with this plugin
Get error: Cannot access memory before initialization on the bg file. (Truncated below):

import * as wasm from '/-/hello-wasm/hello_wasm_bg.wasm?import';

let cachedUint8Memory0;
function getUint8Memory0() {
    if (cachedUint8Memory0.byteLength === 0) {
        cachedUint8Memory0 = new Uint8Array(wasm.memory.buffer);
    }
    return cachedUint8Memory0;
}

cachedUint8Memory0 = new Uint8Array(wasm.memory.buffer); // Uncaught ReferenceError: Cannot access 'memory' before initialization

The memory checking seems to have been changed since this PR: https://github.com/rustwasm/wasm-bindgen/pull/2886 and I'm guessing the initialization logic is different from what's now needed since the wasm file is referenced in the top level.

Could you please test this WASM binding with Webpack5's asyncWebAssembly and check if Webpack 5 could handle this correctly?

@Menci I've tried to look into it, and in the process it seems like I should have checked the related issues of the one I linked - the bug seems to have been fixed by this PR:
https://github.com/rustwasm/wasm-bindgen/pull/2965
Closing as it's a wasm-bindgen issue.

Could you please test this WASM binding with Webpack5's asyncWebAssembly and check if Webpack 5 could handle this correctly?

I tested that everything was normal in webpack5

Yes, I also found that Webpack 5 could load buggy bindings successfully. But Node.js's native ESM WASM loader fails.


Need more names book titles

When using Faker::Book.title I don't get that many different sample book titles, it would be neat to see more variety like how it is for Faker::Name or so.

Well, it's fixed now.


Added AWS Glue Job Compatibility to Airflow

Make sure you have checked all steps below.
JIRA

[x] My PR addresses the following Airflow JIRA issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"

https://issues.apache.org/jira/projects/AIRFLOW/issues/AIRFLOW-2310
In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a JIRA issue.

Description

[x] Here are some details about my PR, including screenshots of any UI changes:
Currently, there is no integration with AWS Glue Jobs. My pull request is basically an improvement to integrate running AWS Glue jobs with Airflow.

Tests

[x] My PR adds the following unit tests OR does not need testing for this extremely good reason:
Added tests.contrib.test_aws_glue_job_hook.py.
However, moto the test class for boto3 does not support AWS Glue mock currently

Commits

[x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

[x] Passes git diff upstream/master -u -- "*.py" | flake8 --diff

Codecov Report

Merging #3209 into master will increase coverage by 0.06%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #3209      +/-   ##
==========================================
+ Coverage   74.21%   74.27%   +0.06%
==========================================
  Files         194      195       +1
  Lines       14471    14472       +1
==========================================
+ Hits        10739    10749      +10
+ Misses       3732     3723       -9

Impacted Files
Coverage Δ

airflow/operators/glue_job_operator.py
0% <0%> (ø)

airflow/task/task_runner/base_task_runner.py
79.31% <0%> (ø)
:arrow_up:

airflow/models.py
87.36% <0%> (ø)
:arrow_up:

airflow/jobs.py
82.89% <0%> (+0.26%)
:arrow_up:

airflow/utils/log/logging_mixin.py
97.46% <0%> (+2.53%)
:arrow_up:

airflow/task/task_runner/bash_task_runner.py
100% <0%> (+6.66%)
:arrow_up:

airflow/utils/helpers.py
62.83% <0%> (+11.68%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfff046...01789cf. Read the comment docs.

Could you:

Squash the commits into on single commit according to the guidelines
Extend the test, and mock the actual calls.

Thanks!

Please also add it to the documentation, see: https://github.com/apache/incubator-airflow/pull/3201/files

@OElesin thanks. Can you squash your commits? This will trigger another build. If the error persists, I'll look into it.

@Fokko, all done

@OElesin Could you squash your commits? Cheers!

@OElesin Could you squash your commits? Cheers!

@OElesin If you want this in to 1.10 please squash your commits

@OElesin This PR looks a little crazy. A lot of files seem to be touched that don't need to be touched. I'm closing this. Please reopen it after falling the contrib guidelines.

@r39132, I tried to merge all commits into one. I only touched the files I needed to. I guess I rebased wrongly which must have caused the issues.

@Fokko, new PR: https://github.com/apache/incubator-airflow/pull/3504


is it possible to translate an onnx model into onnxscript?

Hi guys.
It's difficult for us to do operation fusion on onnx model, because we need to look into the model, identify the pattern and match the pattern exactly for fusion. when the model changes slightly, the pattern can't match, then we failed to fuse the op. And also this process takes more effects.
Here i got an idea. If we can translate an onnx model into onnxscript, then we can modify the script, fuse some ops into function just using python. it will more efficient.

Yes, there is already a preliminary version of an "onnx model to onnxscript" converter, namely onnxscript.proto2python (which is an alias for export2python
I am a bit confused, however, as to whether you are trying to do fusion automatically or manually. When you mention the pattern-matcher, it looks like an automated onnx optimizer. But if you convert it to onnxscript, do you plan to edit it manually?

yes, I want to modify the model manually.
I am trying to fuse rotary_embedding in llamav2 model. At first i want to write a pattern matcher like onnxruntime's transformer optimizer to fuse this op.
but i found the structure it too complex to match, part of it looks like this:

so i think it may be more easier for me to convert this model into onnxscript, and directly modify it to a fused onnx function.

Please try onnxscript.proto2python(model, use_operators=True, inline_const=True). The options generate more readable encodings.
I would also recommend converting the model to use external_data, because there isn't a convenient way of encoding large tensors in text-form in onnxscript. If the model already uses external_data, use the load_external_data=False when you load the model.
If the model doesn't use external_data, you can first convert it to external_data format via
onnx.save(model, modelfile, save_as_external_data=True, all_tensors_to_one_file=True, size_threshold=64, convert_attribute=True, location=datafile)

But the conversion from onnx to onnxscript is still experimental. If you run into any issues, please do let us know, thanks!

Thanks @gramalingam

2. the variable name 'transformer.block_list.0.attn_norm.weight' is not valid

Right, I ran into this yesterday while trying it out. It's already been fixed in this PR: https://github.com/microsoft/onnxscript/pull/956
Not sure about the missing bracket. If you have a model to share, I'd appreciate that, I can work on fixing it, thanks!

yes, you can use this llamav2 model: https://github.com/microsoft/Llama-2-Onnx-7-FT-16
import onnx
from onnxscript import proto2python

onnx_model_file = './Llama-2-Onnx-7-FT-16/ONNX/LlamaV2_7B_FT_float16.onnx'

onnx_model = onnx.load(onnx_model_file, load_external_data=False)

code = proto2python(onnx_model, use_operators=True, inline_const=True)

with open('llamav2-7b-model.py', 'w') as fp:
    fp.write(code)

but i found the structure it too complex to match, part of it looks like this:

The latest dynamo onnx exporter should greatly help with this as it keeps nn.Module calls as functions in onnx model.
cc @kunal-vaishnavi

Strong +1 on this request!
Small differences from HuggingFace implementations used by the optimizer tool require digging into gnarly operator fusion pattern matching to use ops like MultiHeadAttention. This is brittle, hard to maintain and honestly feels like a needlessly roundabout approach if you know you want to use this op in a particular place.
Either of these two would be very welcome:

Directly authoring a full model in ONNXScript as in https://github.com/microsoft/onnxscript/issues/820. User has full control on using the best fused ops. Even if this means a separate file from one's pytorch training code, this is far more readable and maintainable. Implementing a full transformer by hand is much less code than pattern matching.
Loading a pre-existing ONNX model into ONNXScript and then rewriting code instead of graph pattern-matching as suggested by @kailums

Thanks - we are looking to make (2) as well as pattern matching much easier. (1) is also possible with the up coming tracing support.

In the landing page of onnxscript.ai in the overview section it includes the statement

A converter that translates ONNX models and functions into ONNX Script. This capability can be used to fully round-trip ONNX Script ↔ ONNX graph.

Yet it took me around an hour to eventually find this thread as the only clue so far as to how to achieve this!

Feel free to reopen if the question is not answered.


Load into folder

Need a button for user to send PDF to server by node for conversion into JPG

#190
#189
#188
#187
#179

Need to load all images and the then complete. Will do Friday!


Log metrics and do not panic when the channel receives a corrupted signal

Coverage increased (+0.3%) to 68.608% when pulling 3af4bf82b5b37bcd16c2794b26b500a195dc912b on halakaraki:corrupted-signal-exception into 97e1a8920de44d82bcc940471986f6e44f524c08 on uber-go:master.


resolves gh-142

use mappingContext to resolve entity prefix
fix document repository to use derived key
additional testcases

@setu9760 thanks! I'll review today and post any feedback.


publish an official docker image

Description and motivation
It would be better if aihwkit could publish an official docker image with GPU support.

Alternatives and other information
So that you know, instructions are available to build your image using the CUDA file provided.

Thank you @matifali, we are working on publishing docker images with GPU support to conda forge soon. Thank you for your help providing instructions for building the docker image.

Thank you @matifali, we are working on publishing docker images with GPU support to conda forge soon. Thank you for your help providing instructions for building the docker image.

I assume you mean publishing to dockerhub or GitHub container registry.

This issue could be close right @kaoutar55 i´m seen that in the PR https://github.com/IBM/aihwkit/pull/551 are attached that

@Borjagodoy #551 added a Dockerfile while this issue requests to build and publish official Docker images on a container registry.


Don't treat StrcturedBuffer as a specializable param.

Fixes #5629.
When we have a StructuredBuffer<IFoo> parameter, we shouldn't treat it as a statically specializable parameter because we never want to directly replace IFoo with any concrete type. Instead we want to always rely on the dynamic dispatch handling logic to insert proper header to maintain data layout consistency.

"_S" is the start of any mangled name.
"T" means the thing being mangled is a type.

"_S" is the start of any mangled name. "T" means the thing being mangled is a type.

Aha. Thanks for the explanation.


Milestone 4 To Do list

Makefile dependency graph
Docker file
More interpretation about metrics
Improve EDA part (change bar plots to correlation plots)
Add Hyperparameters and feature selection in Logistic Regression
Modify the plots labels/titles/...

4 and 6 complete

3 and 5 complete

Complete


Adding DeleteApp func to AzureClient and returning appObjectID in CreateApp

What this PR does / why we need it:
This PR adds functionality to delete an AAD App. An AAD App can be deleted by providing in the application Object ID. Currently, the CreateApp function does not retrieve or return this parameter.
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Special notes for your reviewer:
If applicable:

[ ] documentation
[x] unit tests
[ ] tested backward compatibility (ie. deploy with previous version, upgrade with this branch)

Release note:

whoops a nit : should be "PointerToString returns a pointer to a string"

I hadnt saved the file with the change :)

/lgtm

Thanks once again @shrutir25


JPGs to video

Is there any sample code to convert multiple JPG files into a video file?

Hi,
there are multiple ways of doing so:

Re-encode as a proper video with tools like ffmpeg, x264, x265 or
create an MJPEG movie which might be based on the OneJpegPerIframe class
(the class needs some minor work to support MJPEG tracks which are not tied
to another 'normal' video track)

What do you want to do ?
Best Regards,
Sebastian
2015-07-08 13:36 GMT+02:00 baole<EMAIL_ADDRESS>
Is there any sample code to convert multiple JPG files into a video file?
—
Reply to this email directly or view it on GitHub
https://github.com/sannies/mp4parser/issues/94.

Thanks Sebastian for promptly response. Actually, I want to convert multiple images to a video on Android. This SO  gives me a hint to create a video from h264 files. I stuck at how to convert jpg/png image into h264 file.

Hi Sebastian,
I changed OneJpegPerIframe which changed ImageIO by Android specific classes and try to create a video from .jpeg files. However, OneJpegPerIframe requires alignTo's track object in its constructor and then align to existent track. Is there anyway to make a jpeg file to a (independent) track?

I'll close the issue as there was no more activity.

Why're you not providing a clean example!
I found almost same thing here https://github.com/sannies/mp4parser/issues/182.


29: Add sidecar's for application ELK logging

I am open to suggestions to reduce the duplication of config map's. I tried moving them to the common library but they could not have data defined and without that did not see a point in having them in the library just to consume the metadata portion.

2 comments on moving config to an image:

Right now the configs are largely the same for all services, but they will start diverging (eg. no logstash)
One of my requirements was that the config could be updated without restarting the application - that is achievable with the way the volumes are mounted.  If we remove these volumes, we'll need to maintain a way to edit the config without causing application restart

I agree that right now there is tons of duplication between helm charts that use these sidecars, but we have problems to work through before we remove these patterns.


SQL error - The column prefix 't0' does not match with a table name or alias name used in the query.

Steps to reproduce
I wrote that query:
from usr in _dbContext.AppUsers
from asc in _dbContext.Ascents.Where(a => a.ClimberId == usr.Id &&
                                     a.AscentDate >= ascentsStartingFromDate).DefaultIfEmpty()
select new
{
      ClimberId = usr.Id,
      FirstName = usr.FirstName,
      LastName = usr.LastName
};

The issue
SQL generated can not be executed on server and finaly we get error.
SQL looks like that:
SELECT [usr].[Id], [usr].[FirstName], [usr].[LastName]
FROM [Users] AS [usr]
CROSS APPLY (
    SELECT [t0].*
    FROM (
        SELECT NULL AS [empty]
    ) AS [empty0]
    LEFT JOIN (
        SELECT [a0].*
        FROM [Ascents] AS [a0]
        WHERE ([a0].[ClimberId] = [usr].[Id]) AND ([a0].[AscentDate] >= '2016-01-01 00:00:00')
    ) AS [t] ON 1 = 1
) AS [t1]

Exception message:
An exception of type 'System.Data.SqlClient.SqlException' occurred in Microsoft.EntityFrameworkCore.dll but was not handled in user code
Additional information: The column prefix 't0' does not match with a table name or alias name used in the query.
It is enough to remove zero from 4 line (so not SELECT [t0]. but just SELECT [t].*) of that SQL and query work like a glance* What do you think it is a bug?
Further technical details
Project.json
  "dependencies": {
    "AutoMapper": "5.1.1",
    "EntityFramework.Core": "7.0.0-rc1-final",
    "Microsoft.AspNetCore.Authentication.Cookies": "1.0.0",
    "Microsoft.AspNetCore.Diagnostics": "1.0.0",
    "Microsoft.AspNetCore.Diagnostics.EntityFrameworkCore": "1.0.0",
    "Microsoft.AspNetCore.Identity.EntityFrameworkCore": "1.0.0",
    "Microsoft.AspNetCore.Mvc": "1.0.1",
    "Microsoft.AspNetCore.Server.IISIntegration": "1.0.0",
    "Microsoft.AspNetCore.Server.Kestrel": "1.0.1",
    "Microsoft.AspNetCore.StaticFiles": "1.0.0",
    "Microsoft.EntityFrameworkCore": "1.0.0",
    "Microsoft.EntityFrameworkCore.SqlServer": "1.0.0",
    "Microsoft.EntityFrameworkCore.Design": "1.0.0-preview2-final",
    "Microsoft.Extensions.Configuration.EnvironmentVariables": "1.0.0",
    "Microsoft.Extensions.Configuration.Json": "1.0.0",
    "Microsoft.Extensions.Configuration.UserSecrets": "1.0.0",
    "Microsoft.Extensions.Logging": "1.0.0",
    "Microsoft.Extensions.Logging.Console": "1.0.0",
    "Microsoft.Extensions.Logging.Debug": "1.0.0",
    "Microsoft.VisualStudio.Web.BrowserLink.Loader": "14.0.0",
    "Microsoft.VisualStudio.Web.CodeGeneration.Tools": "1.0.0-preview2-final",
    "Microsoft.VisualStudio.Web.CodeGenerators.Mvc": "1.0.0-preview2-final"
  },

  "tools": {
    "Microsoft.AspNetCore.Razor.Tools": "1.0.0-preview2-final",
    "Microsoft.AspNetCore.Server.IISIntegration.Tools": "1.0.0-preview2-final",
    "Microsoft.Extensions.SecretManager.Tools": "1.0.0-preview2-final",
    "Microsoft.EntityFrameworkCore.Tools": "1.0.0-preview2-final"
  },

  "frameworks": {
    "net461": { }
  },

Other details about my project setup:

dupe of #6636
It is fixed in the latest release 1.1.0-preview1-final.


Fix 12PM bug in TimePickerPresenter

What does the pull request do?
fixes a bug in TimePickerPresenter, when using 12hour clock and selecting 12:XX PM
What is the current behavior?
the time span returns 24 hours instead of 12 hours
What is the updated/expected behavior with this PR?
ignore +12 when hour is exactly 12 and period is 1

You can test this PR using the following package version. 0.10.999-cibuild0021371-beta. (feed url: https://nuget.avaloniaui.net/repository/avalonia-all/index.json) [PRBUILDID]

You can test this PR using the following package version. 0.10.999-cibuild0021374-beta. (feed url: https://nuget.avaloniaui.net/repository/avalonia-all/index.json) [PRBUILDID]

@maxkatz6 if appropriate, would it be possible to add backport-candidate label to this. thanks


Add barriers after FPU enabling

This only seems to be required for M7 cores, but since we can't know the specific core, we can't filter on that.
I thought about using the SCB's RegisterBlock from cortex-m to enable the FPU, but the registers are just the generics RW which isn't that different from what we're doing right now, and we would need Peripherals::steal to use the methods from SCB which would set the CORE_PERIPHERALS/TAKEN flag.
And one question, with this change, can we get rid of the trampoline() function? I don't think the compiler will do reordering across foreign functions calls (dsb/isb), but I might be missing something.

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @adamgreig (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
Please see the contribution instructions for more information.

And one question, with this change, can we get rid of the trampoline() function? I don't think the compiler will do reordering across foreign functions calls (dsb/isb), but I might be missing something.

The problem isn't reordering but any use of VFP functions. For example in this snippet because foo takes an f32 but first calls a function, it pushes the input onto the stack before calling the function, and vpush and vmov both fault if the FPU is disabled. Of course in our case main won't take a float argument; off the top of my head I can't make up an example that fails in our case but I don't think there's any reason to believe it's impossible. I'd be happy if someone could demonstrate otherwise of course.

On this actual PR: I agree we should have the fences; do you think there's any downsides to bringing in a dependency on cortex-m though?

I thought about using the SCB's RegisterBlock from cortex-m to enable the FPU, but the registers are just the generics RW which isn't that different from what we're doing right now, and we would need Peripherals::steal to use the methods from SCB which would set the CORE_PERIPHERALS/TAKEN flag.

I think we could just use the unsafe ptr() methods, which would be neater than redefining these memory addresses if we are including cortex-m.

I think we could just use the unsafe ptr() methods, which would be neater than redefining these memory addresses if we are including cortex-m.

The problem is that ptr() gives us a RegisterBlock not the zero sized SCB type that has the helper methods. Also, differently from the usual pacs, all of the registers in scb::RegisterBlock are just generics RW without any field's methods (maybe we should change that ?). Using cortex-m would only get rid of
const SCB_CPACR: *mut u32 = 0xE000_ED88 as *mut u32;

we would still need the others constants and all the bit shifting that we are doing now. Because of that I thought it wasn't really worth the code change and the (small) increase of optimization "dependency".

The problem is that ptr() gives us a RegisterBlock

Oh, yea, that's annoying. All issues to be addressed by a hypothetical "cortex-m-pac"/"cortex-m-hal" split I guess. Seems fine to leave it for now then.
bors merge


Zlib: deflateEnd() fails after deflateInit2()/deflateReset()

This duplicate of issue #250 created under madler project here https://github.com/madler/zlib/issues/250.
In summary, following call sequence fails for "Raw deflate i.e. deflateInit() done with window bits -15":
deflateInit() -->deflateEnd().
deflateInit() --> deflateReset() -->deflateEnd().
More details on link above.

Invalid example. Can be closed.

how come this is an invalid example. Can you prove me?
A simple sequence of calling deflateInit() --> deflateEnd() should work. Secondly,
deflateInit --> deflateReset --> deflateEnd() should also work.
In issue https://github.com/madler/zlib/issues/250, i described even 3rd example.
If you could prove these are invalid example, that would make better sense to me,

@1234sv The second example is missing last Z_FINISH outside the loop. Like I already mentioned there, Z_FINISH is only supposed to be used right before deflateEnd(). deflate() already knows when the stream has ended so there is no reason to use Z_FINISH inside the loop. When deflate() returns no more bytes, the stream has ended, so one only needs to check how many bytes there is in output buffer.

to simplyfy it .. its like:
deflateInit()
deflate(Z_FINISH)
deflateReset();
deflateEnd();
So, is this a valid call flow?

@1234sv You can't use Z_FINISH before deflateReset(), it has to come after it.

why that's the dependency?

@1234sv Most likely to warn user about truncated output. When deflate is used with Z_FINISH and big enough buffer, the output is guaranteed to be full length. deflateReset() will - like the name suggests - reset the result of sanity checks. When deflate is used with Z_FINISH but too small buffer, it will return Z_OK or Z_BUF_ERROR instead of Z_STREAM_END.

"When deflate is used with Z_FINISH but too small buffer, " -- in this case, deflateEnd() too will fail as zlib is in middle of operation. so a simple sequence like this:
deflateinit()
deflate(Z_FINISH); // buf is just 1 byte
deflateEnd(); // --> this will fail regardless.
so, this explanation doesn't explain situation why a Reset cannot be called before End().
Anyways, if I further simply my question that its
why follow call flow cannot work
deflateInit()
deflateEnd(). ?

deflateReset() cannot be called before deflateEnd() because deflateEnd() depends on deflate state that deflateReset() doesn't preserve.
Simple deflateInit() -> deflateEnd() doesn't work because deflateInit() doesn't actually output anything, first deflate() call does the actual work.

Simple deflateInit() -> deflateEnd() doesn't work because deflateInit() doesn't actually output anything, first deflate() call does the actual work.

but it works if we open stream for ZLIB decode. and it should work same of raw deflate as well

@1234sv deflateInit() and deflateInit2() internally call deflateReset() so that is why it doesn't work for raw deflate. The state is undefined until first deflate() call. It doesn't matter how many times user or zlib code calls deflateReset() in raw mode, the state is always undefined.

So, what is ideal sequence of operation for Raw deflate?

For ideal sequence, see https://github.com/Dead2/zlib-ng/issues/123#issuecomment-328253511

I understand your input how zlib implementation for Raw deflate works and that's what my observation is as well. However,
I still dont understand why user is forced to call deflate(Z_FINISH) just before End() as user can always choose to End operation anytime , say ctrl+c pressed or any other situation. And why user just cannot call deflateEnd() if it is already reset. As a user, I see algorithm should be allow user to close it anytime by not putting some hard requirements on sequencing. So, following some specific call flow may result in some erroneous results but API should allow it.

@1234sv I think Mark Adler can explain the reason behind the logic better than I... I only know what I have read from the manual or the source tree.

Waiting on Mark to look at this. Thanks for your input on this issue.

Looks like this was fixed upstream.


Fix google sign up/in

On both Dev and Prod, signing up via google integration is broken.
After the integration modal, it loads the homepage fine (and I can view browse bills). But I can't view my profile.
Also - it doesn't send a validation link to my email (although perhaps that was always bypassed when signing-up via google?)

Maybe this is relevant?
https://developers.google.com/workspace/guides/configure-oauth-consent
From a ticket @alexjball created in Feb: https://app.zenhub.com/workspaces/design-and-development-629389aa02e9d200139c90b8/issues/gh/codeforboston/maple/929

Also maybe this is relevant?
https://app.zenhub.com/workspaces/design-and-development-629389aa02e9d200139c90b8/issues/gh/codeforboston/maple/716


Xerces 1.1

Adapted and implemented the new version of Xerces2-J (which supports XSD 1.1). The forked version of Xerces should be added to the repository. Also I'd recommend adding org.eclipse.wst.xml.xpath2.processor to the repository as well.
Created new tests for testing some basic functionality such as override, redefine, assert, etc.
Current Status: Requires extra testing on Jenkins.

Thanks for these works, I included it in another merge. Therefore this Pull Request will be closed.


support force-push

I am not sure what you mean by this, but if you mean "force pushing to the upstream", I am pretty sure git push -o force does this, based on my own experimentatino.


Remove unused package, expo-linear-gradient

expo-linear-gradient was left over from the previous (before Maverick) components, where we had a GradientBackground. This no longer exists and does not need to be in the boilerplate.
Making a task out of this because although it has Experimental Fabric support in Expo v47, it would help get use closer to New Architecture compatible if we drop it.

:tada: This issue has been resolved in version 8.2.10 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Disabling the legacy mode.

Due to the following issue:
https://github.com/egoist/tsup/issues/938
which does not seem to be fixed soon.
I decided to drop the legacy mode.

That's even better


Improve resize behavior and add font resize, fixes #17

LGTM

Not quite done yet.

Ready.

Actually, wait.


现在下载不了 ？？？

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

你好，因为个别原因，链接已失效。
如果你是iOS用户，在 app store 是可以找到 滴雀 的，安卓用户的话，暂时下载不了。

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

目前可以暂时使用这个链接进行下载


CodegenLLVMHelperVisitor renames LOCAL statements in all StatementBlocks

CodegenLLVMHelperVisitor is supposed to replace LOCAL statements in codegen functions with appropriate type. e.g.
 PROCEDURE rates(arg_v(mV)) {
     LOCAL alpha, beta, sum, q10
     UNITSOFF
     q10 = 3^((celsius-6.3)/10)
     alpha = .1*vtrap(-(arg_v+40), 10)
     ...

should be converted to
 INTEGER rates(DOUBLE arg_v){
     INTEGER ret_rates
     DOUBLE alpha, beta, sum, q10
     UNITSOFF
     q10 = 3^((celsius-6.3)/10)
     alpha = .1*vtrap(-(arg_v+40), 10)
     ...

This is working fine. But LOCAL statement in original procedures rates also getting converted as:
 PROCEDURE rates(arg_v(mV)) {
     DOUBLE alpha, beta, sum, q10        => this is a bug
     UNITSOFF
     q10 = 3^((celsius-6.3)/10)
     alpha = .1*vtrap(-(arg_v+40), 10)
     ...

This is not the case anymore.


For external tasks, show camunda:taskPriority inherited value from Process level

Is your feature request related to a problem? Please describe.
The priority for an external task (camunda:taskPriority) can be defined directly on the task or on process level. When defined on process level, the priority is inherited to the external tasks within the process (but can be overwritten).
See https://docs.camunda.org/manual/7.15/user-guide/process-engine/external-tasks/
Describe the solution you'd like
As a user, I find it very hard to understand the External Task Priority configuration when having selected a Process. I propose to add:

Description on process level (ala All external tasks inside the process will inherit this priority)
Dynamic description on external task lavel (ala Inherited value from process level: xyz. Will be overwritten, when defining a local value).

Describe alternatives you've considered
n/a
Additional context
When implemented, then we should implement it in the new properties panel: https://github.com/bpmn-io/bpmn-properties-panel

Likely makes sense to consider once were done with properties-panel@next.

Dynamic description on external task lavel (ala Inherited value from process level: xyz. Will be overwritten, when defining a local value).

Could be a placeholder on the field: "10 (inherited from process)".

I would like us to stop adding help texts to the UI as long as they are permanently visible and blow up the properties panel.
The priority could be a value but also an expression. Showing an expression plus a description in brackets as a placeholder is a no-go, in my opinion.


evaluate function issue of the Image Classification - Quick Start tutorial

the evaluate result seems incorrect.
Top-1 test acc: nan
I have tried on my pc. it shows similar messages as the tutorial and return the wrong evaluate result too
"UserWarning: Ignoring data/test/BabyPants of type . Only support .jpg, .jpeg, .png"
is it a bug of getting class names or listing the images? or is there changes about dataset and/or evaluate function?
Thank you

Thanks for reporting. It is a bug recently introduced. We will fix it.

built_in_tasks = {
    'mrpc': MRPCTask,
    'qqp': QQPTask,
    'qnli': QNLITask,
    'rte': RTETask,
    'sts-b': STSBTask,
    'cola': CoLATask,
    'mnli': MNLITask,
    'wnli': WNLITask,
    'sst': SSTTask,
    'toysst': ToySSTTask,
}


Modal not working

hi,
i am trying to show modal in this template
https://themes.getbootstrap.com/product/black-dashboard-pro-premium-bootstrap-4-admin/
but it didn't work and also it didn't work in your live version or in your documentations
thanks

Hi @marmarKamel,
Thank you for working with our products.
Can you please tell me what browser and operating system are you using?
Thank you,
Rares


chore: Added last release date check to the release-note generate script

fixed #681

If you want others to use this script properly, please consider adding a README file with instructions on how to use it or using script parameters instead of hardcoding values.


What is Version support policy for 3.10.x ?

The official site version does not have version support policy for 3.10.x as of today (2nd Jan 2023).   (Reference: https://helm.sh/docs/topics/version_skew/ )
Does it support Kubernetes 1.26?   What is min and max k8s versions supported by 3.10.x ?
[For future reference  , if there is any source of truth in source code , do point us there ]

Thanks for the report. I've created https://github.com/helm/helm-www/pull/1408
To your question, my understanding is that the version support policy is driven by the linked version of the client-go lib (which can be found in go.mod). Which determines the range of supported Kubernetes versions (see: https://github.com/kubernetes/client-go#compatibility-client-go---kubernetes-clusters (also out of date :( )

Since k8s skew is +1/-1 , 3.10.x supports 1.26 also , is that correct ?


release version 0.0.7

Codecov Report

Merging #101 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #101   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           1      1
  Lines          73     73
  Branches       13     13
=====================================
  Hits           73     73

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d12030b...a3ae6c7. Read the comment docs.


How to train a model with 16GB GPU

Hey,
thanks for your PyTorch implementation. I am trying to train a model with my custom dataset. I managed to set the dataset (tfrecords) up but I run out of memory on training loop step 0.
RuntimeError: CUDA out of memory. Tried to allocate 128.00 MiB (GPU 0; 15.90 GiB total capacity; 14.61 GiB already allocated; 53.75 MiB free; 14.84 GiB reserved in total by PyTorch)

Sadly, I do not have more GPU RAM options. My config is the following:
from configs.default_lsun_configs import get_default_configs

def get_config():
  config = get_default_configs()
  # training
  training = config.training
  training.sde = 'vesde'
  training.continuous = True

  # sampling
  sampling = config.sampling
  sampling.method = 'pc'
  sampling.predictor = 'reverse_diffusion'
  sampling.corrector = 'langevin'

  # data
  data = config.data
  data.dataset = 'CUSTOM'
  data.image_size = 128
  data.tfrecords_path = '/content/drive/MyDrive/Training/tf_dataset'

  # model
  model = config.model
  model.name = 'ncsnpp'
  model.sigma_max = 217
  model.scale_by_sigma = True
  model.ema_rate = 0.999
  model.normalization = 'GroupNorm'
  model.nonlinearity = 'swish'
  model.nf = 128
  model.ch_mult = (1, 1, 2, 2, 2, 2, 2)
  model.num_res_blocks = 2
  model.attn_resolutions = (16,)
  model.resamp_with_conv = True
  model.conditional = True
  model.fir = True
  model.fir_kernel = [1, 3, 3, 1]
  model.skip_rescale = True
  model.resblock_type = 'biggan'
  model.progressive = 'output_skip'
  model.progressive_input = 'input_skip'
  model.progressive_combine = 'sum'
  model.attention_type = 'ddpm'
  model.init_scale = 0.
  model.fourier_scale = 16
  model.conv_size = 3

  return config

Are there any options to improve memory efficiency? I would like to stay at a 128x128 resolution (if it is possible).
Thanks!

The default batch size 128 is intended for training on multiple GPUs. You can improve memory efficiency by reducing the batch size. The batch size can be set either in the config files, or by command line config.training.batch_size.

Great, thank you!
For (future) colab users, I am now using a batch size of 16 for 16GB RAM (P100) and 128x128.

Hey,
the training worked really well, thanks for that. Now I am trying to do the evaluation. I managed to create my stats file and now I want to calculate the FID for 50k images. The process seems really slow on one V100 16GB. My eval config is:
evaluate = config.eval
evaluate.begin_ckpt = 1
evaluate.end_ckpt = 20
evaluate.batch_size = 16
evaluate.enable_sampling = True
evaluate.num_samples = 50000
evaluate.enable_loss = False
evaluate.enable_bpd = False
evaluate.bpd_dataset = 'test'

Is there any chance to optimize this for one GPU?
Thanks a lot!
P.S.: The PyTorch requirements.txt do not include jax and jaxlib but you need them to run the code. I am not sure if they are just forgotten imports or if they are really needed for the code but this lead to errors for me.

You may increase evaluate.batch_size by quite a large factor, as evaluating models do not require backpropagation and requires much less GPU memory. jax and jaxlib can be refactored out and technically evaluation code shouldn't depend on them. Thanks for catching these imports and I will optimize them out in the next revision.

Thanks for the help. I increased it to 64, anything above that runs out of memory. It takes really long either way. I have 782 (50000//64+1) sampling rounds and each round takes about 35 minutes. So getting the 50kFID of one model takes about 19 days :joy: Do you have any experience with reducing the sample size and the corresponding FID accuracy?
Thanks!

Yeah, that’s unfortunately due to the slow sampling of diffusion score models. Using the JAX version can be slightly better, since JAX code can sample faster than PyTorch. In my previous papers I also reported FID scores on 1k samples for some experiments, but in that case the FID score will be way larger than that evaluated on 50k samples.

Thanks for the info👍


Getting the error: master_token doesn't follow the AAS_ET format

Describe the bug

I am using HA 2023.12.2 and the google_home v1.10.2 . I used the Docker method to get the master token using the app password. The token was generated successfully.
I then tried to add the integration and then I get the following error in the log.
2023-12-14 11:35:27.482 ERROR (MainThread) [glocaltokens.client] master_token doesn't follow the AAS_ET format
I have tried out all possible combinations with/without @gmail.com, app password/account password, tripple checked for any blank spaces and etc but nothing worked out.
My master token is in the format:
aas_et/AKppINabdfhtfy6ughnghjghjgjghbhhbnmnghjhjghjghjghjghjgh

Version of the integration
If you are unsure about the version check the github release here.

1.10.2

Logs

2023-12-14 11:35:27.482 ERROR (MainThread) [glocaltokens.client] master_token doesn't follow the AAS_ET format

The check is pretty simple.

Token must start with aas_et/
Token must be exactly 223 characters long.

Make sure you copied the whole thing.

Yes, I did. I cropped it for the purpose of this ticket.

When I pasted the token in MS Office Word, it tells me that there are only 203 characters. I have copied the token exactly as it was generated.

Word is not the best tool for this, it can automatically replace some characters with something else. Try Notepad instead.

I tried an online character count website as well. Same thing.

Any advice @leikoilja?

this is the first time we heard that token length is 203 instead of 223 characters. @kaizersoje do you have access to any other accounts to check the length of the master token there?
We can cater for 203 chars as well as 223, but we would need to know if it's google's new pattern? 🤔

Hi @leikoilja I am away on holiday at the moment. So it will be a while I can look into this.

Hi, I'm having a similar issue but my token is 224 chars long (checked with echo 'aas_et/.....=' |wc -c)
Before upgrading (I don't know from wich version to the last one) it was working well

Hi, I'm having a similar issue but my token is 224 chars long (checked with echo 'aas_et/.....=' |wc -c) Before upgrading (I don't know from wich version to the last one) it was working well

me too my token have 224 chars long

Probably we should relax this check a bit.

Probably we should relax this check a bit, feel free to submit a PR. You will need to check that your token indeed works.

how I can check if my token works

how I can check if my token works

You need to modify glocaltokens library here: https://github.com/leikoilja/glocaltokens/blob/master/glocaltokens/utils/token.py
And install modified version in order to test it.

I found that it says Token must be exactly 223 characters long, which is not the same as my token.
Finally, I discovered that the token I copied had an EOL (end-of-line) character. After removing it, I successfully logged in.
Thanks for your help 😄


Please rename default branch from 'master' to 'main' per Khronos policy

To repository owners: please rename the default branch of this repository from 'master' to 'main', using the Github renaming tool. This request is per policy set by the Khronos Promoters in May 2021, to follow Github community practice for respectful naming.
The Github renaming tool sets up URL redirections and retargets outstanding pull requests, so the impact on repository users is minimal. The most visible issue is that people with local repo clones will probably want to rename their clone's 'master' branch, following the popup instructions that will be seen when browsing the github repository after the change; or just delete 'master' and pull the new 'main', if it's purely a tracker with no local content.
You may wish to coordinate with @outofcontrol if you are doing auto-updates from this repository to another location, whether via push/pull mirroring or other mechanisms. The redirects setup by Github should accommodate most such uses transparently, but it's still good practice.
Based on experience with other KhronosGroup repositories which have undergone this renaming already, this is a reasonable approach:

Agree on a date for the renaming within the Working Group or other owners of the repository, and document that date here.

Date can be adjusted to avoid interaction with major releases in flight.

Provide notice to repository users outside Khronos, insofar as possible (adding a comment in the repo README with the switchover date is one way).
Once the renaming is done, edit the new 'main' branch to replace hardwired references to 'master' with (preferably) 'default branch' or 'main'.
Update the repo README to note the change.

If you have questions or issues about this, please raise them on Khronos internal gitlab 'khronos-general' issue 106 if possible. If not possible, you can @-tag me here.
While we will not force any WG into acting precipitously, this is our agreed policy. Please try to accommodate renaming relatively soon.
Note that this issue is automatically generated, due to the large number of KhronosGroup repositories it's being raised in.

It's been a year since this was posted with no response from repo owners, and I will be going ahead with this renaming on Friday unless I get pushback before then.

To my understanding, the concept of "repository owners" does not exist within Khronos. (And one could see that as a problem, but ... it is what it is). When this is about something that could vaguely be described as ~"feeling  'somehow responsible' for a repository", then I could say: Yes, I feel 'somehow responsible' for the glTF-Tutorials repository. But I don't care about the branch name. So when someone else wants (and has the authority) to rename it, then ... *shrugs*. No pushback here.

"Owner" is actually a github role, so it would be more accurate had I said "Admins" or perhaps "Responsible WG". In any event, I'll proceed on Friday - thanks.

Done.

The link at the lower right of the "deployed" version at https://github.khronos.org/glTF-Tutorials/ says Improve this page, leading to master. I thought that this "deployed" version was completely managed by GitHub (and they would handle their own master/main update thingy transparently). It's not a big deal, but ... does someone know why this was not updated, or how to update it?

does someone know why this was not updated, or how to update it?

Yes.  Try pushing a new commit to main, to cause it to rebuild the pages.

Thanks Ed. I'm about to push a few smaller fixes soon anyhow (probably today), so that may resolve itself.

There's a PR at https://github.com/KhronosGroup/glTF-Tutorials/pull/88  - I'll let that "sink in" for a while, and in doubt, self-merge it soon, let's see whether the "deployed" version is then updated as well.

Seems to have worked 🎉


bindgen_test_layout_max_align_t ... FAILED

Input C/C++ Header
// Define 'max_align_t' to match the GCC definition.
typedef struct {
  long long __clang_max_align_nonce1
      __attribute__((__aligned__(__alignof__(long long))));
  long double __clang_max_align_nonce2
      __attribute__((__aligned__(__alignof__(long double))));
} max_align_t;

I take it from llvm/clang header.
Bindgen Invokation
$ bindgen --no-unstable-rust test.h

Actual Results
#[repr(C)]
#[derive(Debug, Copy)]
pub struct max_align_t {
    pub __clang_max_align_nonce1: ::std::os::raw::c_longlong,
    pub __bindgen_padding_0: u64,
    pub __clang_max_align_nonce2: f64,
}

test gen_c::bindgen_test_layout_max_align_t ... FAILED

failures:

---- gen_c::bindgen_test_layout_max_align_t stdout ----
        thread 'gen_c::bindgen_test_layout_max_align_t' panicked at 'assertion failed: `(left == right)` (left: `24`, right: `32`): Size of: max_align_t', gen_c.rs:12
note: Run with `RUST_BACKTRACE=1` for a backtrace.

failures:
    gen_c::bindgen_test_layout_max_align_t

test result: FAILED. 1 passed; 1 failed; 0 ignored; 0 measured

Expected Results
All generated tests should be "green".
$ bindgen --version
bindgen 0.22.1
I also tried 1320efeb79d373acb8dd92fb2722732c251497d8, but it also generate failed test.

Right, this is a dupe of https://github.com/servo/rust-bindgen/issues/550. See there for workarounds. Thanks for reporting!

The link is 404 though. I'm also getting this issue :/

The correct link is now: #550
The underlying issue was apparently fixed.  However, the fix relies on the final build being done with a recent version of rustc, so we need to promise bindgen that we'll use such a version.  E.g.:
Builder::default()
  .rust_target(bindgen::RustTarget::Stable_1_28)


GE/Jasco 1274/ZW3003 Dimmer Switch Missing Some Manual Actuations

Is your problem within Home Assistant (Core or Z-Wave JS Integration)?
NO, my problem is NOT within Home Assistant or the ZWave JS integration
Is your problem within ZWaveJS2MQTT?
NO, my problem is NOT within ZWaveJS2MQTT
Checklist

[X] I have checked the troubleshooting section and my problem is not described there.

[X] I have read the changelog and my problem was not mentioned there.

Describe the bug
What causes the bug?
Manual actuation of the dimmer switch sometimes does not get reflected in the HA UI..  This appears to be very similar to another issue named:  Jasco 45609 missing some manual switch presses #4008.  However it appears that the "solution" was to replace the devices with new ones - but am not sure because the issue was closed.  I have three of the devices and they all seem to have the same issue.  A week ago they all seemed to work OK using my VERA Edge hub.
What do you observe?
HA UI does not always follow the actual operation of the switch when manually changed.  HA UI follows state of switch fine when changed from the UI or by an automation.
What did you expect to happen?
I expected the switches to operate the same as it did when used with VERA recently.  With VERA, the switches worked just fine - as expected.  Even manual switch operations were immediately reflected in the UI.
Device information
Manufacturer:   GE/Jasco
Model name: 12724/ZW3003
Node ID in your network: 29, 39, 40
How are you using node-zwave-js?

[ ] zwavejs2mqtt Docker image (latest)
[ ] zwavejs2mqtt Docker image (dev)
[ ] zwavejs2mqtt Docker manually built (please specify branches)
[ ] ioBroker.zwave2 adapter (please specify version)
[X] HomeAssistant zwave_js integration  (please specify version)
[ ] pkg
[ ] node-red-contrib-zwave-js (please specify version, double click node to find out)
[ ] Manually built from GitHub (please specify branch)
[ ] Other (please describe)

Which branches or versions?
version: HA:  2022.2.0
node-zwave-js branch: 8.11.2
zwavejs2mqtt branch:  6.5.0
Did you change anything?
no
If yes, what did you change?
No response
Did this work before?
Yes (please describe)
If yes, where did it work?
Devices worked previously with VERA hub
Attach Driver Logfile
config_entry-zwave_js-d7e4374b64cdf223fd69cc2e06859182.json (1).txt

A week ago they all seemed to work OK using my VERA Edge hub.

This means the only relevant thing that changed is the controller hardware - and maybe its placement?
Please read and apply the things mentioned under general troubleshooting here:
https://zwave-js.github.io/node-zwave-js/#/troubleshooting/connectivity-issues?id=general-troubleshooting

On a side note:

config_entry-zwave_js-d7e4374b64cdf223fd69cc2e06859182.json (1).txt

This isn't a driver logfile. Maybe the explanation above the textbox where you paste it isn't obvious enough yet?

Thanks for your very quick response AlCalzone.  The z wave stick I am using is a Aeotec Gen5+ that is at the end of a 6 foot USB extension cord to keep it well away from the Raspberry Pi 4 I am using to run Home Assistant.  The Raspberry Pi is within a foot, or so, of the Vera Edge hub.  I have not had any problem getting the z wave stick to communicate with devices all over the house - up to 50 ft away and through multiple walls.  All devices communicate directly with the stick - no hops through repeaters.  One of my dimmer switches that I am having difficulty with is within 6 ft of the z wave stick so signal strength should not be an issue.
Sorry about the file type.   I will try again.  Thanks for your patience with me, I am just part way up the Home Assistant learning curve.
zwavejs2mqtt-store (2).zip

Just as a follow up to this topic, I have a newer in wall switch that seems to work perfectly.  It is a GE/Jasco 14291/ZW4005.  This is not a dimmer but just an ON / OFF paddle switch, located in the garage and is the farthest away of any z wave devices I have.  However I believe it is a Z-wave Plus.   It is shown as connected to the "lifeline" which is Node1 - the USB Z wave stick.  It would appear that the dimmer switches cannot be so connected.

Can you please re-interview (note this does not mean re-include!) the problematic device, then actuate it manually 1-2 times and post a log of just that? I wonder if the association just failed to be set up correctly the first time.
Don't forget to mention the node ID then, so I know what to look for.

OK, will do,  I will have a chance to try that later today.  I have tried to re-interview Node 39 once today but for some reason, after doing that, my z wave stick seemed to loose all connection to all z wave devices.  A Home Assistant restart did not solve it but a reload from a full back up did.  I am not sure how that happened?  Anyway I will try again later and give you the result with a log.

I re-interviewed Node 39 (which is a GE/Jasco 1274/ZW3003 Dimmer Switch) then started a verbose log which I have attached.   This time I had no trouble after the re-interview.  I toggled the switch manually a couple of times from fully off to fully bright while the log was underway.  I hope this helps.
Recall that I have three of these switches.  They all seem to operate the same and the node data shown all seems the same to me.  I will  understand if these older switches are not fully supported now and will never be fully supported.  There are literally thousands of Z wave devices out there.  I can imagine that supporting even the newer ones is a huge task.!!
Only one of the three switches is "mission critical" to me from the standpoint of needing to know the state of the device (even if changed manually) for the purpose of an important automation.  I would plan to change that switch to a new version if these older ones are not supported.
Kind regards,
zwavejs2mqtt-store (3).zip
.

Ok, Node 39 is one of those devices that needs polling to work around the old instant reporting patent. In order to avoid unnecessary queries, the driver only polls devices under very specific circumstances. Prior to the re-interview we might not have had all the information to determine that, likely due to a timeout in the previous interview. It does look like this is working now:
2022-02-07T16:34:35.698Z DRIVER « [Node 039] [REQ] [ApplicationUpdateRequest]
                                    payload: 0x270a04110126277370867277
2022-02-07T16:34:35.702Z CNTRLR « [Node 039] Received updated node info
2022-02-07T16:34:35.704Z CNTRLR   [Node 039] Node does not send unsolicited updates; refreshing actuator and sen
                                  sor values...
2022-02-07T16:34:35.709Z CNTRLR » [Node 039] requesting current switch state...
... state is queried and returned...

This means if you're still losing some switch actuations now, its most likely a connectivity issue.

Thanks for looking into this.  It does look like Home Assistant is still not following manual actuations of Node 39, but I am satisfied that we have done what we can do on this topic.
Again thanks for your help.

If we can trust the above log, the information at least reaches the driver, so the question is why it doesn't show in HomeAssistant... Maybe https://github.com/home-assistant/core can help you?

Agreed.  I will at least post this as an issue for the lads developing Home Assistant Core.

There recently was another issue opened about the same device: https://github.com/zwave-js/node-zwave-js/issues/4220
The verdict there was that the manual activations DO reach us, but the new status has to be polled and sometimes this happens too quickly while transitioning, so the status is outdated (e.g. almost off instead of off). Could that be your problem aswell?

OK I have created a file “test.json” and pasted the contents of the file, as requested.  I then saved and did a soft reset (restart).  None of the z wave devices now respond.  I get a message like “Failed to call service light.turn_on.  Zwave error 102.  The driver is not ready or has been destroyed ZW0103”.  See attachment.
It looks like I am going to recover using a backup????
Gerald Kiffiak
(403) 347-4464  ●<PHONE_NUMBER> – cell  ●<PHONE_NUMBER> – fax  ●    @.> @.
From: AlCalzone @.>
Sent: February 10, 2022 1:43 PM
To: zwave-js/node-zwave-js @.>
Cc: CeasarPrime @.>; Author @.>
Subject: Re: [zwave-js/node-zwave-js] GE/Jasco 1274/ZW3003 Dimmer Switch Missing Some Manual Actuations (Issue #4188)
within the “store” directory using the Z Wave JS UI in Home Assistant
To be sure - you are using zwavejs2mqtt, right? Then you can create a file in that folder, name it, paste the file contents on the right side and save it.
https://user-images.githubusercontent.com/17641229/153493103-6d17e8eb-f4e1-4f2d-8788-ac8c87db7904.png
Don't forget to restart z2m afterwards.
—
Reply to this email directly, view it on GitHub https://github.com/zwave-js/node-zwave-js/issues/4188#issuecomment-1035491752 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AVJVYQF2Y2VPDJP5TT4I2ADU2QPOTANCNFSM5NSVWAVQ .
Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675  or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub .
You are receiving this because you authored the thread.  https://github.com/notifications/beacon/AVJVYQFUAYFIGFWT6IMZFNLU2QPOTA5CNFSM5NSVWAV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOHW4FTKA.gif Message ID: @.*** @.***> >

When trying the soft reset again I get the attached error.
Gerald Kiffiak
(403) 347-4464  ●<PHONE_NUMBER> – cell  ●<PHONE_NUMBER> – fax  ●    @.> @.
From: AlCalzone @.>
Sent: February 10, 2022 1:43 PM
To: zwave-js/node-zwave-js @.>
Cc: CeasarPrime @.>; Author @.>
Subject: Re: [zwave-js/node-zwave-js] GE/Jasco 1274/ZW3003 Dimmer Switch Missing Some Manual Actuations (Issue #4188)
within the “store” directory using the Z Wave JS UI in Home Assistant
To be sure - you are using zwavejs2mqtt, right? Then you can create a file in that folder, name it, paste the file contents on the right side and save it.
https://user-images.githubusercontent.com/17641229/153493103-6d17e8eb-f4e1-4f2d-8788-ac8c87db7904.png
Don't forget to restart z2m afterwards.
—
Reply to this email directly, view it on GitHub https://github.com/zwave-js/node-zwave-js/issues/4188#issuecomment-1035491752 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AVJVYQF2Y2VPDJP5TT4I2ADU2QPOTANCNFSM5NSVWAVQ .
Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675  or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub .
You are receiving this because you authored the thread.  https://github.com/notifications/beacon/AVJVYQFUAYFIGFWT6IMZFNLU2QPOTA5CNFSM5NSVWAV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOHW4FTKA.gif Message ID: @.*** @.***> >

You can't attach things to e-mails. You need to upload them via the Github UI.

I then saved and did a soft reset (restart)

I meant an actual restart as in stop zwavejs2mqtt and start it again. If your stick isn't responsive, you might have to unplug it for a few seconds aswell.

I am prepared to try this again but I will need some detailed instructions.  Please elaborate on:
an actual restart as in stop zwavejs2mqtt and start it again
How exactly is it best to do that?

I don't know? How are you running zwavejs2mqtt? Is there not a way to stop that?
Anyways, it looks like this is a recurring issue on this particular device. Can you follow the instructions there please? https://github.com/zwave-js/node-zwave-js/issues/4220#issuecomment-1040353844

We're working with Jasco to get these things cleaned up soon.


Add support for EdgeProxy

Add support for creating and managing EdgeProxy instances that connects to an Unleash instance.
https://github.com/Unleash/unleash-edge

We also discussed having the edge proxy as a sidecar container, but that is out of scope for this issue.


jlink plugin: need mechanism for explicitly adding additional modules

Currently the jlink goal only adds modules based on the project's dependencies:
addArgument("--add-modules", String.join(",", javaDependencies));

This request is to add the ability to configure the plugin with additional modules. For example a configuration parameter like:
addModules: additional modules to pass to jlink's add-modules option
One use case for this is described here:
https://stackoverflow.com/questions/54770538/received-fatal-alert-handshake-failure-in-jlinked-jre
In this case you need to explicitly add the jdk.crypto.ec module. One could do this by creating a module-info.java file for the project, but one of our goals with the jlink support is not to require this.

I've had a bash at addressing this. Not sure how to unit test it, but I have tried it manually and looks good.

Need to port to 2.2.0


Remove requirement for jQueryUI when grid is static

Coverage increased (+0.03%) to 72.252% when pulling 4399e1a455b20dfbc7c357efa453ba94b3dc15ba on rharriso:master into 61ed99ab5c337211c04a9a6ca107a67e06e0f87b on troolee:master.


Update cordova hooks for iOS for Cordova 5.4

After updating Cordova to v5.4 - when building for iOS following message is displayed:
The module "ConfigParser" has been factored into "cordova-common".
Consider update your plugin hooks.

Nothing critical, everything works, but still - need to clean it up.

This is an issue of the local development add-on - https://github.com/nordnet/cordova-hot-code-push-local-dev-addon/issues/4

fix issue:
var ConfigParser = ctx.requireCordovaModule('cordova-common').ConfigParser;


Enhancement: add service entry for token endpoint

Description
The service key for the credential service must be present in the DID document of all did subjects, but it is currently missing.
Acceptance Criteria

[ ] Add a service key to the DID document
[ ] The service key is a set/list of service entries
[ ] service entries consist of id, type and serviceEndpoint
[ ] The only requirement for the serviceEndpoint is to be a valid URI (the mapping and list/set variants can be omitted)
[ ] Calling the /<bpn>/did.json will include this new service entry

Additional Information
The types of service fields are described here: https://www.w3.org/TR/did-core/#services
Example service entry:
...
"service": [
{
    "id": "did:web:<miw_specific_id>#SecurityTokenService",
    "type": "SecurityTokenService",
    "serviceEndpoint": "https://<miw_host>/api/token"
},
{
    "id": "did:web:<miw_specific_id>#CredentialService",
    "type": "CredentialService",
    "serviceEndpoint": "https://<miw_host>/presentations/query"
}
],
...

Hi @borisrizov-zf , please note that serviceEndpoint should be the base url. So the end url for presentation query should look like: {serviceEndpoint}/presentations/query .
If serviceEndpoint has value https://<miw_host>/api/token, then presentation query endpoint will be https://<miw_host>/api/token/presentations/query.
May be serviceEndpoint should have value https://<miw_host>/api so that presentation query endpoint looks like https://<miw_host>/api/presentations/query.

Hi @hemantxpatel, these are two different service entries imo. One is the SecurityTokenService and one is the CredentialService. The former has the service URL /api/token and the ladder /presentations/query. That would be reasonable?
I've updated the description, to account for both.

Hi @borisrizov-zf , that's correct. Only thing is /presentations/query should not be part of the serviceEndpoint as it is appended by EDC.
It should look like this:
"service": [
{
    "id": "did:web:<miw_specific_id>#SecurityTokenService",
    "type": "SecurityTokenService",
    "serviceEndpoint": "https://<miw_host>/api/token"
},
{
    "id": "did:web:<miw_specific_id>#CredentialService",
    "type": "CredentialService",
    "serviceEndpoint": "https://<miw_host>"
}
],

@hemantxpatel Ah, thanks for the heads up, I'll update that this week.


When will Netty new version with log4j security fix be available

Hello All
This is a kind of urgent regarding "log4j" security issue.
We are using hivemq client dependency in our android project. Hivemq client internally uses netty as a dependency as per below link:
https://search.maven.org/artifact/com.hivemq/hivemq-mqtt-client/1.3.0/jar
I see that current netty/common version is 4.1.71.Final which uses log4j dependencies
https://mvnrepository.com/artifact/io.netty/netty-common/4.1.71.Final
Regarding the "log4j" version update I have below 2 queries:
1.Does netty internally use any of log4j classes since its mentioned its optional?
2. When will the new version  netty be available with security fix for "log4j" so that dependent libraries can update their versions ?
Thank you

Please properly read the mvnrepository page you linked: log4j is flagged as optional, meaning netty won't pull it.
Netty has its own abstraction layer that lets you pull your favorite logging library, hence the optional dependency.


Explore: Erasure coding with Pyrsia

This issue is to track work to use erasure coding to improve durability and availability of artifacts by erasure coding slices of artifacts then distribute the slices to the peer network.

Currently IPFS doesn't support Erasure coding.  it maybe a long term goal of IPFS.  https://github.com/ipfs/ipfs-cluster/issues/6

We may need to do that separate but this issue I believe was for the peer metrics. There is an existing erasure coding library we can leverage.

Trust in the artifacts themselves can be achieved. The "trust" will be bound to the artifacts that we are sharing. This will can be achieved using signatures for the artifacts. Ultimately, the signature on the final assembled artifact will need to match the signature published by our signing authority.


Uncomment koji requires in setup.cfg

rhbz#1968618 has been fixed in fedora
Can be merged once koji-1.25.1-1.fc33 gets into stable.

/packit test


Add b:formatters_ and b:formatdef_ overrides

Not sure whether you'll be interested in this, I added support for per-buffer overrides
for formatters and formatdef, so I can be working on multiple projects at the same time that use different formatting standards
Note variable name fix at line 45/48

I introduced b:current_formatter_index for this. You can set it to the index of the formatter of your choice. You can also interactively change this using the commands :NextFormatter and :PreviousFormatter. The command :CurrentFormatter prints the current index.
You could set the correct index in your vimrc based on some criteria. Would this mechanism suffice for you?

Hi,
The way I am using this right now is that I set b:formatdef_astyle_c
per buffer to point to per-project .astylerc file that is stored
out-of-tree because I do not "own" the code I am working on so am not
free to add a .astylerc file there.
Regards,
MV
On 09/02/16 03:10, Chiel ten Brinke wrote:

I introduced b:current_formatter_index for this. You can set it to the index of the formatter of your choice. You can also interactively change this using the commands :NextFormatter and :PreviousFormatter. The command :CurrentFormatter prints the current index.
You could set the correct index in your vimrc based on some criteria. Would this mechanism suffice for you?

Do you set this each time you start vim, or do you set this in your vimrc based on e.g. the directory of the file that youre working on?

The latter, sort-of.
I have per-project 'vimrc' and the appropriate one is sourced
based on what project the file being edited belongs to.
If I understand b:current_formatter_index, I could use it as follows
(assuming C code for the sake of argument):

Add 'project1', 'project2', 'project3' to g:formatters_c
Define g:formatdef_project1, g:formatdef_project2, etc.
Set b:current_formatter_index to the index of projectN as
appropriate

Is that correct?
My concerns about doing it this way:

Now 'project1' etc. are in the global list, and might end up
getting used for some other code that's not part of project1.
Unlikely to happen if there is a working formatter earlier in
the list, and probably not a big deal. But might be surprising.

A bigger concern is that I have to know the correct index for
the project in the list of formatters. As I add and remove
projects the index will change. It could also change on a new
release of vim-autoformat. I suppose I could look-up the index
at run-time by looking for 'projectN' in g:formatters_c.

All in all, I think I could make it work with
b:current_formatter_index. What I like about my solution is that
it is very "localized" because only the current buffer is affected.
MV
On 09/02/16 06:29, Chiel ten Brinke wrote:

Do you set this each time you start vim, or do you set this in your vimrc based on e.g. the directory of the file that youre working on?

Thanks for your motivation. I can see the benefit of this feature. Especially when one works with more then one vimrc. Would you be so kind to mention this feature briefly in the README? I intend to merge in after that.

Will do and advise.
Thanks!
MV
On 09/08/16 12:32, Chiel ten Brinke wrote:

Thanks for your motivation. I can see the benefit of this feature. Especially when one works with more then one vimrc. Would you be so kind to mention this feature briefly in the README? I intend to merge in after that.

Done. I hope you won't mind, I took the liberty of fixing a couple
typos I stumbled across at the same time.
Let me know if you want me to change anything.
Thanks for all your work on this great plug-in.
Regards,
MV
On 09/08/16 12:32, Chiel ten Brinke wrote:

Thanks for your motivation. I can see the benefit of this feature. Especially when one works with more then one vimrc. Would you be so kind to mention this feature briefly in the README? I intend to merge in after that.

Thanks!


cyglidar_d1: 0.0.2-1 in 'melodic/distribution.yaml' [bloom]

Increasing version of package(s) in repository cyglidar_d1 to 0.0.2-1:

upstream repository: https://github.com/CygLiDAR-ROS/cyglidar_d1.git
release repository: https://github.com/CygLiDAR-ROS/cyglidar_d1-release.git
distro file: melodic/distribution.yaml
bloom version: 0.10.7
previous version for package: null

Looking to pass checks. To note, Melodic is on hold at the moment.

@imsorapark can you please reply to @clalancette's feedback. Thanks!

With no response to multiple pings over a month I'm going to close this. Please resubmit if you'd like another review.


feat(celery): Allow to override propagate_traces per task

Adds support for a sentry-propagate-traces header on apply_async that
overrides the default behavior set through the Celery integration's
propagate_traces flag.
Example usage:
my_task.apply_async(..., headers={"sentry-propagate-traces": False})

Example use case:
We ourselves have a task that is running once every two weeks and it is sampled with ~0.01 Percent. So we can one transaction from this task a year (give or take). This task starts hundreds of child tasks. All those child tasks will inherit the sampling decision from the original task and thus will be dropped most of the times. But we want to have those child tasks transactions in our backend no matter the sampling decision of the parent.

Documentation PR: https://github.com/getsentry/sentry-docs/pull/7757

Diff looks now ugly, but code is way more readable! 💯


Implement timeout on the scan functions

Process can get stuck forever at the moment.

I started a root_filesystem scan yesterday on a 1GB image (using 21.4.14) and it's still running.  Is this possibly still the same issue?

@cco3 Yes, it's most likely related to multiprocessing, 1GB image should not take more than 1h max.
We are looking into solving those issues at the moment.
In the mean time, could you try to turn off multiprocessing a run the scan again (as a new project)?
See https://scancodeio.readthedocs.io/en/latest/scancodeio-settings.html#scancodeio-processes

Hasn't finished after about 5 hours.  There's a report, but the "running" progress indicator is still going and the log is stuck at Step [scan_for_files] starting


Using std::make_unique_for_overwrite() for more efficiency

We don't need to zero-initialize heap memory if we are going to overwrite it immediately. For sure, it have a little sense for stuff like hooks and fonts, changed only for consistency. But it doing a real deal with PlayerAvatar initialization in PlayerData::PlayerData(). With "std::make_unique" i got microstutters on large casual publics everytime when new player connected and new avatar getting cached. With "std::make_unique_for_overwrite()" it's a lot less, almost unnoticeable.
Btw, as we have constant rgbaDataSize i've tried to replace heap allocation with std::array but got extreme stutters on avatars downloading. Probably because lack of move operation for std::array.

Interesting.


rbtree insert

Implement red black tree insert & insert_fixup.

We lack of document of red-black-tree algorithm. It's hard to understand why you do this or that. I read some references like Introduction to Algorithms, but it has not explained why rb-tree does work. So it's necessary to introduce the story of rb-tree.

We lack of document of red-black-tree algorithm. It's hard to understand why you do this or that. I read some references like Introduction to Algorithms, but it has not explained why rb-tree does work. So it's necessary to introduce the story of rb-tree.

better to create an issue to trace this?


AWS > 2.304 Breaks Bluebird Promisify in NPM-Register

See: https://github.com/aws/aws-sdk-js/issues/2229

the issue #135 is also related, and I finally managed to fix it by setting this dependency with a fixed version:
"aws-sdk": "2.227.1"

@canercandan yea I see the issue now. Because we have the flag to update minor versions. It's a little annoying that AWS-sdk implemented a breaking change like that. I'll have to republish with a fixed version.

@canercandan I published v2.8.2 on npm. This should be compatible with s3

@dgautsch awesome thanks for the heads-up


[Bug] Adder's Touch not working

The 30% chance to apply poison on crit does not get factored into poison chance

Correct; since it only applies on crit it's not as straightforward to implement as a global poison chance increase. I'll look into it though; I think I know a way I can factor it in without going to too much trouble.

wouldn't crit chance  * 30% (chance to Poison from adders touch) give you the correct % chance to poison on any given hit ?

Yep, that's how it'll be factored in. It'll be in the next update. I've managed to do it without actually changing the poison chance calculation, which is what I meant by "not going to too much trouble".
Strictly speaking, this passive affects the average poison damage too, since poison will deal more damage on crits, and with this passive, the likelihood of any given poison stack having been applied by a crit is higher than your crit chance would suggest. In the extreme case, where you have no other poison chance, all poison stacks will be applied by crits, so the poison damage calculation will be way off. The thought of trying to factor that in gives me a headache though!

You could calculate the poison chance it grants as a ratio of hit damage vs crit damage. For example if 90% of your damage is dealt by crits then 30% chance to poison on crit would be worth 27% chance to poison.

That might correctly account for it under normal circumstances, but I guarantee Toxic Delivery will make a mess of it. It'll take a more complex approach to correctly simulate this, unfortunately.

The next update changes the handling of crit and dot calculations such that Adder's Touch and other modifiers that grant a chance to bleed/poison on crit can now be handled 100% correctly.


Allow using parallel option in tempest CR

NFV test cases cannot run in parallel added a
parallel option to the CR to allow disabaling it
if required.
https://github.com/openstack-k8s-operators/test-operator/blob/44b0b132e34039dbcb9089ad01d23c873e70e7e4/api/bases/test.openstack.org_tempests.yaml#L98
Print CR before applying
As a pull request owner and reviewers, I checked that:

[ ] Appropriate testing is done and actually running
[x] Appropriate documentation exists and/or is up-to-date:

[x] README in the role
[x] Content of the docs/source is reflecting the changes

This is not needed, there is already cifmw_test_operator_concurrency  - please use that and the workflows (https://github.com/openstack-k8s-operators/ci-framework/pull/1333) if you need to run various set of tests with different concurrency


[Storage Blobs Service] Blob Tags

blocked by https://github.com/Azure/azure-sdk-for-cpp/issues/407


Event when player enters/leaves scene

Have an event triggered whenever the player enters or leaves the parcels that make up the scene
Something like this was already developed by Mateo, but it was never released as it only worked in production, not in preview. It can nevertheless be a good starting point
This can be used, for example, to pause the action in a scene, to connect a player to a websockets server for the scene only when on the scene, to start a video stream only when the player is on the scene, etc.
Currently it's possible to use a TriggerArea from the utils library for the same purposes. Doing that involves several more steps, and can get tricky for non-square scenes.
Important consideration: this should be able to contemplate cases where the scene is not necessarily square shaped.

moving this back to the "to do" column.
me should need a message from the renderer when avatar enter o leave scene to make sure the event match with what user is seeing.
we can't use kernel events cause renderer is interpolating avatars' position

renderer: https://github.com/decentraland/unity-renderer/pull/1586
kernel: https://github.com/decentraland/kernel/pull/117
sdk: https://github.com/decentraland/js-sdk-toolchain/pull/53


[2.8] Backup and Restore Extensions

Extensions in this PR are to enable and enhance backup/restore checks.

Charts extensions were moved into the actions/extensions part of r/r so this PR is no longer needed.


updating particle theme submodule to latest

This fixes the particle and soapstone theme submodules, that should be the last of them.

Thanks!


Reorganization of Events/Tokens

Something to consider as an enhancement for a future update might be a way to reorganize the various Events and Tokens that are created. Maybe a drag and drop system, or even trees to keep events together.

Duplicates #392


Think about to fix the issues found by adapter checker

I am an automatic service that looks for possible errors in ioBroker and creates an issue for it. The link below leads directly to the test:
https://adapter-check.iobroker.in/?q=https://raw.githubusercontent.com/sbormann/ioBroker.iqontrol

[x] [E605] No actual year found in copyright. Please add "Copyright (c) 2020 Sebastian Bormann<EMAIL_ADDRESS>at the end of README.md
[x] [E701] No actual year found in LICENSE. Please add "Copyright (c) 2020 Sebastian Bormann<EMAIL_ADDRESS>at the start of LICENSE
[x] [E815] file tsconfig.json found in repository, but not found in .npmignore

Thanks,
your automatic adapter checker.
P.S.: There is a community in Github, which supports the maintenance and further development of adapters. There you will find many experienced developers who are always ready to assist anyone. New developers are always welcome there. For more informations visit: https://github.com/iobroker-community-adapters/info

should be fixed in next version


Faulty dictionary comprehension syntax used in spark_to_pandas decorator

Description
spark_to_pandas decorator breaks due to the way that kwargs are iterated over in python 3. The code uses {k:v for k,v in d} instead of {k:v for k,v in d.items()}. This throws a too many values to unpack error.
Context
I was trying to use the spark_to_pandas utilitity decorator to convert a node input from spark dataframe to pandas dataframe (from kedro.contrib.decorators import spark_to_pandas)
-- File ".../lib/python3.6/site-packages/kedro/contrib/decorators/decorators.py", line 123, in <dictcomp>
    **{key: _to_pandas(value) for key, value in kwargs}
ValueError: too many values to unpack (expected 2)

Your Environment
Include as many relevant details about the environment in which you experienced the bug:

Kedro version used (pip show kedro or kedro -V): kedro 0.15.1
Python version used (python -V): python 3.6
Operating system and version: CentOS 7

@roumail Thank you for your feedback! Yes, indeed this is a bug that needs to be fixed. I've created a ticket to resolve these. Thanks again for spotting!

Hi @roumail, this has been addressed in https://github.com/quantumblacklabs/kedro/commit/705887df117a8faf6df935897f5c657445e5b990. We gave you a shout-out in the contributors list as well. Thanks again for surfacing this issue, hope you have a great day!


Use Terrajet

Hi,
I am currently researching whether I can adopt crossplane for my hybrid cloud infrastructure and one thing my IaC also manages is my GitHub repos.
I saw that there has not been a lot of activity recently, but I saw that Terrajet is become more and more mature. Would it make sense to overhaul this repository by generating all resources with it?
The Terraform provider that could be used for this could be this one.

Hey @nicklasfrahm , thanks for raising this issue!
I think we would need to create another repository (e.g provider-jet-github) and them generate Crossplane managed resources from terrajet there.
Have you tried to create your own github terrajet repository? In the terrajet tutorial it uses GitHub as an example to create a provider. If you have something already created, maybe we can start from it

I don't yet, but I'd love to look into it. I am starting a new position as a Cloud Architect on the 1st of April and I think that crossplane is the way of exposing IaC within your enterprise, so this would be a great PoC for me. I will throw in an update once I have something to show.

Hi @nicklasfrahm, I'm currently in a similar situation, already tried creating a crossplane provider with terrajet for another component of my infrastructure and think I'd start with the provider-jet-github soon.
Did you already make progress or should I start from scratch? We could maybe try to pool ressources...

We are using github/safe-settings to manage our organization (which is a fork of repository-settings/app), but we would love to use this :)

I am not currently using crossplane anymore, so if anyone wants to take the lead, please go ahead.

Hey everyone, I really like crossplane and have started working on github provider with terrajet.
https://github.com/HotThoughts/provider-jet-github
For now, there are only very basic branch, repository, and team resources. Free feel to open an issue or PR if you have any suggestions!
Plan to add more resources and examples when I have more time. 😄


What hosts support VFS For Git?

Is there any list of hosts that currently support VFS For Git?
These are the only ones i know currently support it:

Visual Studio Team Services

These do not as of this time:

GitHub
Gitlab

These i don't know:

Bitbucket

Are there any others?

Right now Azure Repos (formerly VSTS) is the only service with VFS for Git support that's available. I believe GitHub is currently working on adding that support. Bitbucket supports it via an addin for Bitbucket server, but they don't support it on the Bitbucket service. I think GitLab has it on their backlog but I don't know the status.

We have been testing our large repos using VFS for Git on Bitbucket. We haven't seen any server related issues. Atlassian have not been forthcoming on any plans to officially confirm the add-in is fully supported. Strangely they want confirmation from customers that it works before providing such a statement.  There is no enablement of Bitbucket smart mirror which is a significant issue for geographically dispersed teams requiring to work with large repos.

Closing, since I think this question has been answered.


[Bridge] [Solidity] Pool balance used to guard withdrawMOVE function

Problem
In the AtomicBridgeInitiatorMOVE.sol contract, the poolBalance variable that is supposed to track the current amount of locked tokens in the bridge is used in withdrawMOVEand can prevent a withdrawal (moveToken.transfer).
function withdrawMOVE(address recipient, uint256 amount) external {
        if (msg.sender != counterpartyAddress) revert Unauthorized();
        if (poolBalance < amount) revert InsufficientMOVEBalance();
        poolBalance -= amount;
        if (!moveToken.transfer(recipient, amount)) revert MOVETransferFailed();
    }

[!WARNING]

We have no guarantee that the poolBalance tracks the number of tokens locked in the bridge via bridge transfers. The moveToken is an ERC-20 token, and there could be transfers to and from the account that do not go through the bridge. Examples are if the bridge is compromised we may have to move MOVE tokens in or out manually.
as a result, the test poolBalance >= amount does not guarantee that the transfer (next line) will be successful.
the fact that poolBalance and the actual balance in the bridge moveToken.Balance may be different could create some issues: assume the bridge is compromised, the poolBalance is zero, and we have to manually refill with say $1B MOVE tokens. Because amount is zero, users won't be able to withdraw (bridge back from L2) even if there is $1B MOVE in the bridge, which is probably not what is expected as we just refilled the bridge.
another issue is that the withdraw function is in the AtomicBridgeInitiatorMOVE.sol contract but is not used in this contract, only in the AtomicBridgeCounterpartyMOVE.sol.

Here is the completeBridgeTransfer function in AtomicBridgeCounterpartyMOVE.sol:
 function completeBridgeTransfer(bytes32 bridgeTransferId, bytes32 preImage) external {
        BridgeTransferDetails storage details = bridgeTransfers[bridgeTransferId];
        if (details.state != MessageState.PENDING) revert BridgeTransferStateNotPending();
        bytes32 computedHash = keccak256(abi.encodePacked(preImage));
        if (computedHash != details.hashLock) revert InvalidSecret();
        if (block.timestamp > details.timeLock) revert TimeLockExpired();

        details.state = MessageState.COMPLETED;

        atomicBridgeInitiatorMOVE.withdrawMOVE(details.recipient, details.amount);

        emit BridgeTransferCompleted(bridgeTransferId, preImage);
    }

This results in at least two issues:

[Issue 1] the guard poolBalance >= amount may prevent use from fixing a compromised bridge
[Issue 2] the  AtomicBridgeCounterpartyMOVE.sol contract uses a contract call to unlock the tokens:
a) this is not gas-efficient and
b) creates a dependency between the two contracts; if  withdraw in AtomicBridgeInitiatorMOVE.sol is modified, this impacts the behaviour of the counter party.

Possible changes
One thing that should probably be done is:  remove the line if (poolBalance < amount) revert InsufficientMOVEBalance(); in the AtomicBridgeInitiatorMOVE.sol contract as it does not serve any purpose and can be dangerous (Issue 1 above).

[!NOTE]
We can keep the poolBalance variable to track what has been locked and unlocked in the bridge (which may be different to the balance of the contract). Option 2 below proposes an alternative solution.

Once this is done we have two options to address the cross-contract call:

keep the poolBalanceand merge the code of the two contracts
split the poolBalance into poolLocked and poolUnlocked, with poolLocked (respectively poolUnlocked) tracking what has been locked in the bridge (via initiateBridgeTransfer) and poolUnlocked tracking what has been unlocked from the bridge (via completeBridgeTransfer in AtomicBridgeCounterpartyMOVE.sol. Concretely, we remove poolBalance and replace with poolLocked in AtomicBridgeInitiatorMOVE.sol and we add poolUnlocked in AtomicBridgeCounterpartyMOVE.sol.

Option 1 has one advantage: it is easy to implement, but a serious drawback as we may not be able to track the bridge poolBalance (or anything related to how much went in and out the bridge).
Option 2 above has two advantages:

we are able to track what goes in and out of the bridge, and the bridge poolBalance can be reconstructed from poolLocked - poolUnlocked
if keeps the two contracts Initiator (bridging L1 to L2) and the CounterParty (bridging L2 to L1) indepedent as we can move the withdraw function out of   AtomicBridgeInitiatorMOVE.sol into in  completeBridgeTransfer (or inline it) in AtomicBridgeCounterpartyMOVE.sol.

Implementation
One we have decided whether or not we want to fix issues 1 and 2, and which option is preferred, we can implement the changes.
This requires:

potentially adding two variables poolLocked and poolUnlocked in the two contracts
removing the cross-contract call and migrating (or inlining) the withdraw function.

In practice, in  AtomicBridgeInitiatorMOVE.sol, we rename poolBalance into poolLocked, and in AtomicBridgeCounterpartyMOVE.sol we add a variable poolUnlocked and modify the function
completeBridgeTransfer to:
// Total MOVE token transferred out of the bridge on L1 (unlocked)
uint256 public poolUnlocked;

function completeBridgeTransfer(bytes32 bridgeTransferId, bytes32 preImage) external {
        // Only bridge transfer operator can perform the unlock
        requires(msg.sender == counterpartyAddress, Unauthorized());

        // Check bridge transfer details
        BridgeTransferDetails storage details = bridgeTransfers[bridgeTransferId];
        // Must not have been completed yet
        requires(details.state == MessageState.PENDING, BridgeTransferStateNotPending();
        // Secret is known and deadline (timeLock) not elapsed
        bytes32 computedHash = keccak256(abi.encodePacked(preImage));
        requires(computedHash == details.hashLock, InvalidSecret());
        requires(block.timestamp <= details.timeLock, TimeLockExpired());

         // Mark transfer as complete
        details.state = MessageState.COMPLETED;
        // Update amount of unlock
        poolUnlocked += amount;
        // Try to transfer to recipient or revert
        if (!moveToken.transfer(recipient, amount)) revert MOVETransferFailed();

        emit BridgeTransferCompleted(bridgeTransferId, preImage);
    }

Validation
We need to add some unit tests to test that:

reverting conditions are correctly triggered (the calls revert when we expect them to)
the poolLocked and poolUnlocked variables are updated properly (and this for each function in each contract).

On L1:
poolUnlocked is the difference between 10B (max supply) and current balance and poolLocked is the balance of bridgeInitiator Contract
On L2:
poolUnlocked is the current supply and poolLocked is the difference between 10B (max supply) and the current supply. Don't think adding more params helps us, we could these constants for extra care.
One issue I can foresee is if there's an exploit, using poolUnlocked and poolLocked will lead to bugs as invalid minting or removal of tokens would lead to an unbalance between the tokens.
note: removal of poolBalance has already shown to bug and ERC20() _transfer already handles the logic it was meant to serve.  removal of poolBalance has been merged into Solidity Bridge Deployment Scripts

One issue I can foresee is if there's an exploit, using poolUnlocked and poolLocked will lead to bugs as invalid minting or removal of tokens would lead to an unbalance between the tokens.

How can variables that are just updated but do not change the control flow create bugs?
The poolLocked and poolUnlocked are not related to minting (this is in the ERC-20).
This comment does not seem relevant here.

note: poolBalance has already shown to bug and ERC20() _transfer already handles the logic it was meant to serve. > removal of poolBalance has been merged into https://github.com/movementlabsxyz/movement/pull/681

How can a variable in a bridge contract "bug" another contract (an ERC-20)?

it bugs, it doesn't bug another contract. They are performing the same logic and we would need to implement the same logic twice else it will continue bugging.
It's redudant logic.