Obj-C protocol conformance is dropped from types

While migrating plugin code from native to Dart, at one intermediate stage I had this:
- (instancetype)initWithPlayerItem:(AVPlayerItem *)item
                      viewProvider:(id<FVPViewProvider>)viewProvider
                         AVFactory:(id<FVPAVFactory>)avFactory
                displayLinkFactory:(id<FVPDisplayLinkFactory>)displayLinkFactory;

which was turned into:
FVPVideoPlayer initWithPlayerItem_viewProvider_AVFactory_displayLinkFactory_(
      AVPlayerItem item,
      objc.ObjCObjectBase viewProvider,
      objc.ObjCObjectBase avFactory,
      objc.ObjCObjectBase displayLinkFactory)

Without any of the protocols in the types, it's incredibly easy to call incorrectly, and also much less self-documenting. Ideally Obj-C protocols would be reflected as Dart abstract interfaces that are implements'd.

We can experiment with this, but I held off doing it in the initial implementation for a few reasons:

Dart's interface checking is way stricter than ObjC's, so there will probably be use cases that would compile fine in ObjC that don't compile in Dart
Not all interfaces declare which protocols they implement, so I'd need to proactively check which protocols are implemented
I'm not sure how to handle protocols that have optional methods.

I suppose I could just make the codegenned protocol empty, so we get some type checking without actually verifying that the methods exist. You still wouldn't be able to call methods on the protocol from Dart land.

Also not sure how to handle args that implement multiple protocols: - (void)method:(id<Foo, Bar>)obj;

We could codegen a FooBar interface, but that gets complicated because now that's another interface that the implementation needs to implement. Better solution is probably to just take the first protocol and ignore the rest.

1. Dart's interface checking is way stricter than ObjC's, so there will probably be use cases that would compile fine in ObjC that don't compile in Dart.

Do you have an example of this to illustrate the kind of problem that would happen?

2. Not all interfaces declare which protocols they implement, so I'd need to proactively check which protocols are implemented

Can you elaborate on this one? Are you talking about conformsToProtocol: runtime checks? If so, I wouldn't expect that to be reflected in the type system.

3. I'm not sure how to handle protocols that have optional methods.

I suppose I could just make the codegenned protocol empty, so we get some type checking without actually verifying that the methods exist. You still wouldn't be able to call methods on the protocol from Dart land.

I think starting with just the type would be a big improvement. (Type and required methods would be even better, for better code completion and Dart-side IDE experience.)

4. Also not sure how to handle args that implement multiple protocols: - (void)method:(id<Foo, Bar>)obj;

I can't remember ever seeing that used in practice, so it probably wouldn't matter much what happened.

An example for both 1 and 2:
@protocol SomeProtocol<NSObject>
@required
- (int32_t)instanceMethod;
@end

@interface UndeclaredImplementation : NSObject
- (int32_t)instanceMethod;
@end

@implementation UndeclaredImplementation : NSObject
- (int32_t)instanceMethod {
  return 123;
}
@end

@interface Consumer : NSObject
- (int32_t)callInstanceMethod:(id<SomeProtocol>)protocol;
@end

@implementation Consumer : NSObject
- (int32_t)callInstanceMethod:(id<SomeProtocol>)protocol {
  return [protocol instanceMethod];
}
@end

int32_t foo() {
  return [[Consumer new] callInstanceMethod: [UndeclaredImplementation new]];
}

This compiles and runs, and foo returns 123 as expected. But the corresponding Dart bindings would not be invocable, (you couldn't write foo in Dart).
All I get from clang is a warning:
protocol_test.m:139:46: warning: sending 'UndeclaredImplementation *' to parameter of incompatible type 'id<SomeProtocol>'
  return [[Consumer new] callInstanceMethod: [UndeclaredImplementation new]];
                                             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
protocol_test.m:129:49: note: passing argument to parameter 'protocol' here
- (int32_t)callInstanceMethod:(id<SomeProtocol>)protocol;
                                                ^

Whether or not this matters depends on whether there are any APIs that do this in practice. I suppose we can just put this behind a config flag, so users can opt out if necessary.

I got around this issue by creating a "proxy" class which takes the protocol object in the init function and calls the methods on that object. For example, for FlutterTextureRegistry:
@objc public class FlutterTextureRegistryProxy: NSObject {
    public init(textures: FlutterTextureRegistry) {
        self.textures = textures
    }

    let textures: FlutterTextureRegistry;

    @objc public func registerTexture(texture: any FlutterTexture) -> Int64 {
        return self.textures.register(texture);
    }

    @objc public func textureFrameAvailable(textureId: Int64) {
        return self.textures.textureFrameAvailable(textureId);
    }

    @objc public func unregisterTexture(textureId: Int64) {
        return self.textures.unregisterTexture(textureId);
    }
}

But it would be great to have the protocols be generated to avoid this hassle

@kekland I think your work around is solving a different problem. Are you trying to make a protocol invocable? My fix probably won't help with that.
The fix I'm planning will add a Dart interface for each protocol, have the classes implement those interfaces, and then pass around those interfaces instead of ObjCObjectBase. These protocol interfaces would be empty placeholders (at least initially).
I guess if we want to support methods that return protocols, the protocol interface can't actually be abstract. I'll have to make it also be a concrete implementation of the protocol, so that I have something to construct and return. This will also act as an escape hatch for users to work around the type restrictions if necessary. I suppose if we code gen all the required methods, then this would make the protocol invocable.

@liamappelbe ah, you're right, was a long day yesterday :D
but yes, it would be great to have both of those things


Update wrangler.toml

Hello.
Thanks for updating the program.
Please go to https://github.com/EDtunnel-rev/EDtunnel-rev for an improved project. This one is a archive for an older version. Thank you.


add hsa

Since clang2py generate broken names for unnamed/anon structs, patching of generated file is quite heavy, so did with inline python.

Can clang2py be fixed instead of heavy patching?

done.

Yea, put a PR on there


How to keybind?

I know keybinds are not the preferred method, however this must be an instant action that is performed by key-press not via menu.
My question, how does one make a keybind?
I am new to LUA scripting, I have looked and looked but can't figure it out.
This may seem like "if you can't figure out a keybind, you couldn't possibly do anything else" but I assure you that's not the case.

CyberEngineTweaks is using ImGui for it's overlays, menus, buttons, key presses, etc.
Here is a link to the readme within the CyberEngineTweaks repository: src/sol_imgui
Here is an example of how to detect a keypress:
registerForEvent("onUpdate", function()
	if ImGui.IsKeyPressed(0x44, false) then -- Hotkey D
		print('You pressed the letter D')
	end
end)

Virtual key codes (such as 0x44 shown above) can be found here: Virtual-Key Codes (Winuser.h) - Win32 apps | Microsoft Docs

CyberEngineTweaks is using ImGui for it's overlays, menus, buttons, key presses, etc.
Here is a link to the readme within the CyberEngineTweaks repository: src/sol_imgui
Here is an example of how to detect a keypress:
registerForEvent("onUpdate", function()
	if ImGui.IsKeyPressed(0x44, false) then -- Hotkey D
		print('You pressed the letter D')
	end
end)

Virtual key codes (such as 0x44 shown above) can be found here: Virtual-Key Codes (Winuser.h) - Win32 apps | Microsoft Docs

This will be removed in the update, do not rely on this, use registerHotkey

This will be removed in the update, do not rely on this, use registerHotkey


No error on indirect calls

Fixes: #35866 (in case you want to accept that issue)
@RyanCavanaugh for review

Yes we have

@ajafff Do you still want to work on this? Otherwise I'd like to close it to reduce the number of open PRs.

Closing since this has gotten stale.


Merge sfMaps and sfCollectionMaps?

e.g.
    "sfMaps": [
        "Obj_SupplyExtraction_CI"
    ],
    "sfCollectionMaps": [
        {
            "name": "StrategyCollection_CI",
            "packages": [
                "GeoscapeMesh_CI",
                "UILibrary_CI_ChainPreview",
                "UILibrary_CovertInfiltration"
            ]
        }
    ]

could become
    "sfMaps": [
        "Obj_SupplyExtraction_CI",
        {
            "name": "StrategyCollection_CI",
            "packages": [
                "GeoscapeMesh_CI",
                "UILibrary_CI_ChainPreview",
                "UILibrary_CovertInfiltration"
            ]
        }
    ]

(short form and long form)

No longer relevant with the change to DLC cook (#46)

Again relevant as DLC cook was reverted (#53)


[WIP] Add the single node cluster profile

Add the single node cluster profile and update the associated Makefile hack until https://github.com/openshift/api/pull/1282 is merged.

It looks like the Makefile hack update that you mentioned didn't come through unless I'm missing something.

/retitle Add the single node cluster profile
This is a prerequisite to payload introduction so adding the required labels
/label px-approved
/label qe-approved
/label docs-approved


[core] Loading of APK files slow

Using the latest unstable version jadx-1.1.0-b1301-65553c15 loading larger APK files, such as Spotify or any other APK files has become very slow.
I noticed that while the initial loading process dozens of temporary zipfs* temporary files are created and deleted next to the APK file. Mostly the temporary files I have seen are just a few KB large, hence processing them in-memory would be preferable instead of creating a temporary file that lives just a few milliseconds.

@skylot Thanks loading works much better now.
Just for curiosity: What dependencies are you talking about - Jadx dependencies or dependencies of the APK that is loaded?

@jpstotz apk class dependencies and usage of fields and methods.
I will use such info for many things:

deterministic class decompilation order
(done, now changes between runs must considered as a bug)
fixing access modifiers
aggressive anonymous and lambda inlining
help for gui features: rename and find usage


1.add the showing adjacent nodes feature;

Can someone plz merge this PR? (Is support needed?)
I like that feature very much, it works (also with the current src/netjsongraph.js file and manual changes) and I appreciate the changes.

No bandwidth to work on this now, fork this repo and maintain your own fork for now. This library will undergo important changes in the next months.

We published a new version which is a rewrite of the old unmaintained version. I am sorry we couldn't merge and maintain this.


Feat: devmode launcher implementation

closes #10104

@mattsse

ok, will do that and probably ask for help in the next pr

all of this should go in a separate file to not pollute the existing code.
I'd even prefer a new crate for now because we need more stuff from the engine crate
https://github.com/paradigmxyz/reth/blob/1f5fb90bc83dd48d38e2f376790125d68ba92f3e/crates/engine/tree/Cargo.toml#L2-L2
what we need is like an Orchestrator that is a stream that advances the chain by polling the mining mode. It would actually be great if we could leverage the existing payloadbuilder stack for this and trigger a payload based on the MindingMode
lmk if I should provide step by step instructions
I think first we want a fresh crate for this, then a minimal mining task that is ideally wired with a PayloadBuilderHandle and a miningmode

@mattsse what should i name the new crate ?

maybe dev-node or smth

@mattsse can I get some instructions?

@mattsse made some new changes

marking as complted via #11703


update readme with badges

This PR adds badges for the github actions to the readme. I'll be merging this in once documentation is reworked.

LGTM, made some changes with @jonzeper.


Add error-chain.

Here's a preview of what it might look like using error-chain.
It currently doesn't compute the line/column for the error message.  I'd like to take a crack at showing a non-copying approach that would make it easier to do this.  I think I'll do it in a separate PR.
There are no tests to assert invalid input.  I could start adding these if you decide to go with this.

Great, I think we can build on this.
I'll merge and open a new issue for reporting positions.


[Consensus 2.0] extract timestamp method to a Clock component.

Description
This PR refactors the method to retrieve the current system timestamp and instead creates a dedicated Clock obj to facilitate the functionality. The refactor will fix the failing sim tests here
The static initialisation of the unix epoch instant is creating issues with simulation testing framework which is not allowing the re-initalisation from one iteration to another, and effectively making simtests with multiple iterations fail. Different iterations are initialised with different dates, thus making a test run with multiple iterations going back and forth in time effectively making Mysticeti producing timestamps from the first run (which intialised the static context). Failures here: https://github.com/MystenLabs/sui/actions/runs/8813919886
With the new approach we don't deal with any static initialisation but we rather construct from the beginning when the consensus authority node gets created. In the future we can also easily mock the Clock object as well for tests. Also putting the Clock behind the Context it made the whole integration very seamless.
Test plan
CI/Simulation tests

Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

[ ] Protocol:
[ ] Nodes (Validators and Full nodes):
[ ] Indexer:
[ ] JSON-RPC:
[ ] GraphQL:
[ ] CLI:
[ ] Rust SDK:

Nice! Do you think we should version clock? We discussed plans of building our own consensus clock that would not be reliant on system time and might be nice to repurpose this for that.

Hey @arun-koshy we can certainly do but maybe we that could be done as part of follow up PR?


Changed HybridpathReference message

Does no longer include eta and nu.
Namefixes

By the way, I will add theory in the readme for the guidance and for the controller


Cannot Name Cheats

Been trying to add cheat codes with names to my 3DS & it keeps displaying this number & invisible letters/numbers as you can see in the picture? can this be fixed?

As of the latest source, cheats should now be in an ini formatted like so:
[name]
value=(value)
enabled=(0/1)


Adapt "Dump frame raster stats for the current frame" of CLI to multi-view

Currently the "Dump frame raster stats for the current frame" function of CLI (shortcut J), which calls Shell::OnServiceProtocolRenderFrameWithRasterStats, assumes that Flutter has a single view. The returned message contains:

A snapshot of the last layer tree (got from Rasterizer::DrawLastLayerTree).
The size of the last layer tree as frame_width and frame_height.

The file format does not seem compatible to multi-view. As I'm working on multi-view, I'm planning to keep the current behavior of targeting the implicit view (view 0) for now, but we'll need to make it somehow contain all views.

From tool bug triage assigning p2, feel free to modify if priorities are different.

Closing as obsolete, we're removing the raster stats feature


DT_SERVICE_ENDPOINT_ID not set

Hi,
I've been trying to use this plugin for AppMon v7.0 and TFS v17.2
I get the problem that the environment variable is not set in Registertestrun.
This is where it stops.
if (-not $env:DT_SERVICE_ENDPOINT_ID){
Write-Host "##vso[task.logissue type=error;]This task can only be used in combination with the -Dynatrace Register Testrun- task which should be executed first!"
exit 1
}
I am using the release for AppMon v7.0

There are only changes to the set property for two variables from what I could see. In "RegisterTestrun.ps1"
Write-Host "##vso[task.setvariable variable=VARIABLE;]$variable"
don't have the possibility to create a pull request. But you will notice.

In the latest release 2.4.7, this is fixed


CircleCI config using outdated convenience images/orbs

Affected Packages
Potentially all packages, depending on dependencies and requirements per node version
Problem
We are seeing a message that we are using a deprecated docker image in our CI setup:

We also have some YAML configuration in our CircleCI settings that are invalid.
Additionally, the version we are using in CI of Node 10.13.0, which is no longer in LTS.
Proposed solution
Upgrade our repository CI to use an updated node orb for CircleCI with an LTS version of Node.

Hm... I'm somewhat unsure how this affects you. I mean - we don't provide any example CircleCI config for executing Changesets on your CI. So it seems that the problem~ is with your custom configuration 🤔
We might indeed use some outdated docker images in our own CircleCI config but I'm not sure how this would affect consuming projects.
Sorry if I misunderstood the issue.

...actually, we would not have to drop support for Node 10. This is only for a devDependency that is not compatible with our current CI environment.
@Andarist again, I am happy to own doing this. It looks like there are a few other issues and PRs hanging around that I can also help with if you're interested in my participation. I know it sucks getting a waterfall of feature requests and bug reports with little to no offers to help. Kind of not how OSS is supposed to work.

@brianespinosa could you check if this PR has resolved this ticket: https://github.com/changesets/changesets/pull/796 ? Or do you believe there is some other work that has to be done here?


Support iris.plot.fill_betweenx and iris.quickplot.fill_betweenx

✨ Feature Request
#4647 implemented an iris.plot wrapper for matplotlib's fill_between function but not fill_betweenx.  Was this an oversight or is there a reason why fill_betweenx is trickier to implement?

@SciTools/peloton Hey @SimonPeatman, thanks for raising this issue.
It just implemented fill_between on request from a users, but it would make total sense to also support fill_betweenx ... fancy taking a punt at it?


ROX-19490: Script for which collection methods are run in osci jobs

Description
Adds a script to get the collection method and kernel version from OSCI artifacts, and outputs the results in csv format. There is another script which runs the first script for a set of commit SHAs. The commit SHAs are the ncommit most recent SHAs and or a specified SHA.
Checklist

[x] Investigated and inspected CI test results
- [ ] Unit test and regression tests added
- [ ] Evaluated and added CHANGELOG entry if required
- [ ] Determined and documented upgrade steps
- [ ] Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.
This just adds a script that just provides information about OSCI tests.
Testing Performed
git checkout e1c93ba4246289af968ba9a7c40d0092177504ce

$ ./get-info-for-shas.sh ncommit=11

OSCI Job, Kernel Version, Collection method
master-merge-gke-nongroovy-e2e-tests,5.15.0-1037-gke,core_bpf
master-merge-gke-qa-e2e-tests,5.15.107+,core_bpf
master-merge-gke-ui-e2e-tests,5.15.0-1037-gke,core_bpf
master-merge-gke-upgrade-tests,5.15.0-1037-gke,ebpf
master-merge-gke-version-compatibility-tests,5.15.0-1037-gke,ebpf
master-ocp-4-10-merge-compliance-e2e-tests,4.18.0-305.100.1.el8_4.x86_64,core_bpf
master-ocp-4-10-merge-ebpf-qa-e2e-tests,4.18.0-305.100.1.el8_4.x86_64,ebpf
master-ocp-4-10-merge-qa-e2e-tests,4.18.0-305.100.1.el8_4.x86_64,core_bpf
master-ocp-4-10-merge-ui-e2e-tests,4.18.0-305.100.1.el8_4.x86_64,core_bpf
master-ocp-4-13-merge-compliance-e2e-tests,5.14.0-284.28.1.el9_2.x86_64,core_bpf
master-ocp-4-13-merge-ebpf-qa-e2e-tests,5.14.0-284.28.1.el9_2.x86_64,ebpf
master-ocp-4-13-merge-qa-e2e-tests,5.14.0-284.28.1.el9_2.x86_64,core_bpf
master-ocp-4-13-merge-ui-e2e-tests,5.14.0-284.28.1.el9_2.x86_64,ebpf

$ ls *.csv
OSCI_Collector_Info_42179fc9a69254c5e5bd899abcbe76a023e0c753.csv  OSCI_Collector_Info_bf2dd12ec9a8b728f5cec42334a5dc2f46ba7680.csv  OSCI_Collector_Info_f2eef88038ba5a71efe24e96b70f8d0702e909e6.csv

$ more *.csv
::::::::::::::
OSCI_Collector_Info_42179fc9a69254c5e5bd899abcbe76a023e0c753.csv
::::::::::::::
OSCI Job, Kernel Version, Collection method
master-merge-gke-nongroovy-e2e-tests,5.15.0-1037-gke,core_bpf
master-merge-gke-qa-e2e-tests,5.15.107+,core_bpf
master-merge-gke-ui-e2e-tests,5.15.0-1037-gke,core_bpf
master-merge-gke-upgrade-tests,5.15.0-1037-gke,ebpf
master-merge-gke-version-compatibility-tests,5.15.0-1037-gke,ebpf
master-ocp-4-10-merge-compliance-e2e-tests,4.18.0-305.100.1.el8_4.x86_64,core_bpf
master-ocp-4-10-merge-ebpf-qa-e2e-tests,4.18.0-305.100.1.el8_4.x86_64,ebpf
master-ocp-4-10-merge-qa-e2e-tests,4.18.0-305.100.1.el8_4.x86_64,core_bpf
master-ocp-4-10-merge-ui-e2e-tests,4.18.0-305.100.1.el8_4.x86_64,core_bpf
master-ocp-4-13-merge-compliance-e2e-tests,5.14.0-284.28.1.el9_2.x86_64,core_bpf
master-ocp-4-13-merge-ebpf-qa-e2e-tests,5.14.0-284.28.1.el9_2.x86_64,ebpf
master-ocp-4-13-merge-qa-e2e-tests,5.14.0-284.28.1.el9_2.x86_64,core_bpf
master-ocp-4-13-merge-ui-e2e-tests,5.14.0-284.28.1.el9_2.x86_64,ebpf
::::::::::::::
OSCI_Collector_Info_bf2dd12ec9a8b728f5cec42334a5dc2f46ba7680.csv
::::::::::::::
OSCI Job, Kernel Version, Collection method
master-merge-gke-nongroovy-e2e-tests,5.15.0-1037-gke,core_bpf
master-merge-gke-qa-e2e-tests,5.15.107+,core_bpf
master-merge-gke-ui-e2e-tests,5.15.0-1037-gke,core_bpf
master-merge-gke-upgrade-tests,5.15.0-1037-gke,ebpf
master-merge-gke-version-compatibility-tests,5.15.0-1037-gke,ebpf
master-ocp-4-10-merge-compliance-e2e-tests,4.18.0-305.100.1.el8_4.x86_64,core_bpf
master-ocp-4-10-merge-ebpf-qa-e2e-tests,4.18.0-305.100.1.el8_4.x86_64,ebpf
master-ocp-4-10-merge-qa-e2e-tests,4.18.0-305.100.1.el8_4.x86_64,core_bpf
master-ocp-4-10-merge-ui-e2e-tests,4.18.0-305.100.1.el8_4.x86_64,core_bpf
master-ocp-4-13-merge-compliance-e2e-tests,5.14.0-284.28.1.el9_2.x86_64,core_bpf
master-ocp-4-13-merge-ebpf-qa-e2e-tests,5.14.0-284.28.1.el9_2.x86_64,ebpf
master-ocp-4-13-merge-qa-e2e-tests,5.14.0-284.28.1.el9_2.x86_64,core_bpf
master-ocp-4-13-merge-ui-e2e-tests,5.14.0-284.28.1.el9_2.x86_64,ebpf
::::::::::::::
OSCI_Collector_Info_f2eef88038ba5a71efe24e96b70f8d0702e909e6.csv
::::::::::::::
OSCI Job, Kernel Version, Collection method
master-merge-gke-nongroovy-e2e-tests,5.15.0-1037-gke,core_bpf
master-merge-gke-qa-e2e-tests,5.15.107+,core_bpf
master-merge-gke-ui-e2e-tests,5.15.0-1037-gke,core_bpf
master-merge-gke-upgrade-tests,5.15.0-1037-gke,ebpf
master-merge-gke-version-compatibility-tests,5.15.0-1037-gke,ebpf
master-ocp-4-10-merge-compliance-e2e-tests,4.18.0-305.100.1.el8_4.x86_64,core_bpf
master-ocp-4-10-merge-ebpf-qa-e2e-tests,4.18.0-305.100.1.el8_4.x86_64,ebpf
master-ocp-4-10-merge-qa-e2e-tests,4.18.0-305.100.1.el8_4.x86_64,core_bpf
master-ocp-4-10-merge-ui-e2e-tests,4.18.0-305.100.1.el8_4.x86_64,core_bpf
master-ocp-4-13-merge-compliance-e2e-tests,5.14.0-284.28.1.el9_2.x86_64,core_bpf
master-ocp-4-13-merge-ebpf-qa-e2e-tests,5.14.0-284.28.1.el9_2.x86_64,ebpf
master-ocp-4-13-merge-qa-e2e-tests,5.14.0-284.28.1.el9_2.x86_64,core_bpf
master-ocp-4-13-merge-ui-e2e-tests,5.14.0-284.28.1.el9_2.x86_64,ebpf

Also tested
$ ./get-info-for-shas.sh ncommit=10 sha=3c7bc3b7e08d11eeef2122c7b3ea801db4e07599

Testing the 4.2 release OSCI jobs
./get-info-for-shas.sh sha=d3962cdcf42d0e65aa8c6f646f05df22952c01d3

OSCI Job, Kernel Version, Collection method
release-4.2-merge-aro-qa-e2e-tests,4.18.0-372.59.1.el8_6.x86_64,core_bpf
release-4.2-merge-eks-ebpf-qa-e2e-tests,5.10.186-179.751.amzn2.x86_64,ebpf
release-4.2-merge-eks-qa-e2e-tests,5.10.186-179.751.amzn2.x86_64,core_bpf
release-4.2-merge-gke-ebpf-qa-e2e-tests,5.15.120+,ebpf
release-4.2-merge-gke-nongroovy-e2e-tests,5.15.0-1039-gke,core_bpf
release-4.2-merge-gke-qa-e2e-tests,5.15.120+,core_bpf
release-4.2-merge-gke-race-condition-qa-e2e-tests,5.15.120+,core_bpf
release-4.2-merge-gke-ui-e2e-tests,5.15.0-1039-gke,core_bpf
release-4.2-merge-gke-version-compatibility-tests,5.15.0-1039-gke,ebpf
release-4.2-merge-osd-gcp-qa-e2e-tests,4.18.0-372.71.1.el8_6.x86_64,core_bpf
release-4.2-ocp-4-10-merge-compliance-e2e-tests,4.18.0-305.103.1.el8_4.x86_64,core_bpf
release-4.2-ocp-4-10-merge-ebpf-qa-e2e-tests,4.18.0-305.103.1.el8_4.x86_64,ebpf
release-4.2-ocp-4-10-merge-qa-e2e-tests,4.18.0-305.103.1.el8_4.x86_64,core_bpf
release-4.2-ocp-4-10-merge-ui-e2e-tests,4.18.0-305.103.1.el8_4.x86_64,core_bpf
release-4.2-ocp-4-13-merge-compliance-e2e-tests,5.14.0-284.30.1.el9_2.x86_64,core_bpf
release-4.2-ocp-4-13-merge-ebpf-qa-e2e-tests,5.14.0-284.30.1.el9_2.x86_64,ebpf
release-4.2-ocp-4-13-merge-fips-qa-e2e-tests,5.14.0-284.30.1.el9_2.x86_64,core_bpf
release-4.2-ocp-4-13-merge-qa-e2e-tests,5.14.0-284.30.1.el9_2.x86_64,core_bpf
release-4.2-ocp-4-13-merge-ui-e2e-tests,5.14.0-284.30.1.el9_2.x86_64,core_bpf

Reminder for reviewers
In addition to reviewing code here, reviewers must also review testing and request further testing in case the
performed one does not seem sufficient. As a reviewer, you must not approve the change until you understand the
performed testing and you are satisfied with it.

/test gke-nongroovy-e2e-tests

/test ocp-4-10-ebpf-qa-e2e-tests
/test ocp-4-13-ebpf-qa-e2e-tests
/test gke-operator-e2e-tests


GCC-H and DoD availability

@SerdarSoysal Can you check please?
Source https://www.microsoft.com/en-us/microsoft-365/roadmap?filters=&searchterms=82954
closes https://github.com/MicrosoftDocs/OfficeDocs-SkypeForBusiness/issues/8737

@SerdarSoysal

Yes, this is correct, but it was already fixed by a PR submitted by the product team. The live version of the article doesn't have the note that this PR deletes.
I'm closing this PR without merging since the issue is already addressed.


Wrong .NET SDK version number when using winget upgrade

Brief description of your issue
winget list does correctly detect the versions of the .NET SDK that I have installed by using the manifest field which matches version from Apps & Features with actual version numbers.
PS C:\Users\jjpfs> winget list dotnet

Name                             ID                     Version Source
-----------------------------------------------------------------------
Microsoft .NET SDK 7.0.201 (x64) Microsoft.DotNet.SDK.7 7.0.201 winget
Microsoft .NET SDK 6.0.406 (x64) Microsoft.DotNet.SDK.6 6.0.406 winget

However, when I run winget upgrade, it offers an update and mixes up .NET 6 and 7 as you can see by the different name and ID.
PS C:\Users\jjpfs> winget upgrade

Name                             ID                     Version   Available Source
----------------------------------------------------------------------------------
Microsoft .NET SDK 6.0.406 (x64) Microsoft.DotNet.SDK.7 < 7.0.100 7.0.201   winget

Steps to reproduce
Have different .NET SDKs installed and run winget upgrade
Expected behavior
Show the right version number and don't offer an update
Actual behavior
Shows wrong version number and offers an update
Environment
Windows 11
Winget v1.5.441-preview

Oh, sorry, I didn't find those other issues because I was searching for .NET SKD and both of those issues talk about the runtime.

No worries. We've identified a fix for a few scenarios. I'm trying to map "Area-Matching" to help group these related issues together so we can see which ones are addressed.

👍

Also seems to happen for a PowerShell Preview, currently my PowerShell shows:
PowerShell 7.4.0-preview.2
PS C:\Users\jjpfs> winget upgrade
Name                             ID                           Version   Available Source
----------------------------------------------------------------------------------------
PowerShell 7-preview-x64         Microsoft.PowerShell.Preview > <IP_ADDRESS> <IP_ADDRESS>   winget
Microsoft .NET SDK 6.0.407 (x64) Microsoft.DotNet.SDK.7       < 7.0.100 7.0.202   winget

Also seems to happen for a PowerShell Preview, currently my PowerShell shows:

This would be fixed once these PRs get merged

https://github.com/microsoft/winget-pkgs/pull/99811
https://github.com/microsoft/winget-pkgs/pull/99812
https://github.com/microsoft/winget-pkgs/pull/99813

Also seems to happen for a PowerShell Preview, currently my PowerShell shows:

This is another issue and would be fixed once below PRs get merged. I'll mark this comment as off-topic once these get merged; if you still have problems I'd say we open a new issue for it.

https://github.com/microsoft/winget-pkgs/pull/99811
https://github.com/microsoft/winget-pkgs/pull/99812
https://github.com/microsoft/winget-pkgs/pull/99813

Okay, thanks 👍

A bit more information:
When running winget list it recognized all SDKs as Microsoft.DotNet.SDK.7:
Microsoft .NET SDK 8.0.100-preview.6.23330.1… Microsoft.DotNet.SDK.7                               > 7.0.306        8.0.100-previ… winget
Microsoft .NET SDK 7.0.306 (x64)              Microsoft.DotNet.SDK.7                               7.0.306                         winget
Microsoft .NET SDK 6.0.412 (x64)              Microsoft.DotNet.SDK.7                               < 7.0.100        7.0.306        winget

@CanePlayz same like for me with the .net runtime where list shows IDs correctly, but upgrade command treats 6 runtime as 7 runtime.

@CanePlayz same like for me with the .net runtime where list shows IDs correctly, but upgrade command treats 6 runtime as 7 runtime.

Yeah, it's all just a big mess right now and all over the place.

Interestingly, it works on my Surface:
Microsoft .NET SDK 8.0.100-preview.6.23330.1… Microsoft.DotNet.SDK.Preview                              8.0.100-preview.6… winget
Microsoft .NET SDK 7.0.306 (x64)              Microsoft.DotNet.SDK.7                                    7.0.306            winget
Microsoft .NET SDK 6.0.412 (x64)              Microsoft.DotNet.SDK.6                                    6.0.412            winget

It might be worth looking into more feedback, cause it seems to be working on my PC now too! Did you change anything with those packages that could have done this?

The problem seams to be the way you installed the SDK/Runtime. If you used winget in works fine, if you used the installer (https://dotnet.microsoft.com/en-us/download/dotnet/thank-you/runtime-desktop-6.0.20-windows-x64-installer) you get an update 'error'.

for me the issue with Dotnet Runtime is still the same even after this weeks patchday.

for me the issue with Dotnet Runtime is still the same even after this weeks patchday.

How about now?

for me the issue with Dotnet Runtime is still the same even after this weeks patchday.

How about now?

since November 2023 and installing .net 8 it works for me on that 1 laptop that suffered the issue for over 1 year.

Great, then I will close this issue.

Great, then I will close this issue.

doe it work for you now, too for the SDKs?

Yup, been working for quite a while now

Yup, been working for quite a while now

just noticed that on one system I see the SDK mismatch again where 6.0.419 is detected as Mirosoft.DotNet.SDK.7 and offers 7.0.406 as upgrade


getting started guide is outdated

https://github.com/coreos/rkt/blob/v0.5.3/Documentation/getting-started-ubuntu-trusty.md
Seems like this should be updated in sync with the release.  In particular, trusting the signing key can be done with rkt trust --prefix coreos.com/etcd.  The actual output is different, too, but that's not a huge deal unless you expect the shas to be the same. :-)

Thanks for catching, fixed via #781


Draft of updated installation instructions

I've updated the README with a simplified version of our previous installation instructions.   Can @jcrist and @brendancol check to see if there are any packages missing or other problems?
I don't think it's ready to merge, because it just says to get "taxi.castra", and there's no way for anyone to do that.  We need to have a reasonably efficient mechanism for people to fetch data for the examples.

Closing; will make a new PR with just the minimal changes.


How to support debugging Android studio plug-ins ?

How can I debug my desktop app like a mobile app in Android studio, so that I can use the plugins "flutter inspector" and "flutter outline"

From what I currently know, this isn't possible at the moment. https://github.com/flutter/flutter-intellij/issues/2250
Somewhat duplicate of https://github.com/go-flutter-desktop/go-flutter/issues/213

This isn't something the go-flutter can work on.
The flutter plugin on android studio is less polished than the one on vs-code.


No such file "current_avg" in sysfs-class-power

Propose to read current_now when current_avg is missing.
sysfs power info from my laptop:
$ cat /sys/class/power_supply/BAT0/uevent                                                                                POWER_SUPPLY_NAME=BAT0
POWER_SUPPLY_STATUS=Discharging
POWER_SUPPLY_PRESENT=1
POWER_SUPPLY_TECHNOLOGY=Li-poly
POWER_SUPPLY_CYCLE_COUNT=0
POWER_SUPPLY_VOLTAGE_MIN_DESIGN=11400000
POWER_SUPPLY_VOLTAGE_NOW=12600000
POWER_SUPPLY_CURRENT_NOW=756000
POWER_SUPPLY_CHARGE_FULL_DESIGN=4912000
POWER_SUPPLY_CHARGE_FULL=4804000
POWER_SUPPLY_CHARGE_NOW=4723000
POWER_SUPPLY_CAPACITY=98
POWER_SUPPLY_CAPACITY_LEVEL=Normal
POWER_SUPPLY_MODEL_NAME=DELL M7R9677
POWER_SUPPLY_MANUFACTURER=Samsung SDI
POWER_SUPPLY_SERIAL_NUMBER=40738

Amazing! Thanks a lot for contributing this. :1st_place_medal:


Fix 23245, 23246 - std.format regressions

In general, we should be wary of forcibly converting user-defined types to const in generic code.

Needs https://github.com/dlang/phobos/pull/8508 to unblock CI

Rebased and re-targeted to master per instructions from @ibuclaw


Add fetch_html script

Thanks for contributing to making this project better.😊I hope you liked the project.


add validators API protos

@jeremyletang man.. Could you please help me to try re-generated locally and push it again? I can't seem to get this passing...


Do not work any redirect in docker

What steps will reproduce the problem?

install docker CE
build image and up it:

docker-compose.yml
version: '2'
services:
    php:
        #image: php:7.1-apache
        build: ./php-apache2
        volumes:
            - ./:/var/www/html/
            - ./apache_conf:/etc/apache2/sites-enabled/
        ports:
            - "8080:8080"

Dockerfile
FROM php:7.1-apache
RUN a2enmod rewrite

#Add Microsoft repo for Microsoft ODBC Driver 13 for Linux
RUN apt-get update && apt-get install -y \
    apt-transport-https \
    && curl https://packages.microsoft.com/keys/microsoft.asc | apt-key add - \
    && curl https://packages.microsoft.com/config/debian/8/prod.list > /etc/apt/sources.list.d/mssql-release.list \
    && apt-get update
#Install Dependencies
RUN ACCEPT_EULA=Y apt-get install -y \
    unixodbc \
    unixodbc-dev \
    libgss3 \
    odbcinst \
    msodbcsql \
    locales \
    && echo "en_US.UTF-8 UTF-8" > /etc/locale.gen && locale-gen
#Install PHP extensions
RUN pecl install \
        pdo_sqlsrv-4.3.0 \
        sqlsrv-4.3.0 \
    && docker-php-ext-install \
        pdo \
        pdo_mysql \
    && docker-php-ext-enable \
        pdo_sqlsrv \
        sqlsrv

virtualhost config
Listen 8080
<VirtualHost *:8080>
        ServerName localhost
	ServerAdmin webmaster@localhost
	DocumentRoot /var/www/html/frontend/web/
	LogLevel debug
	ErrorLog ${APACHE_LOG_DIR}/error.log
	CustomLog ${APACHE_LOG_DIR}/access.log combined
	# Set up rewrites so that all requests go to index.php
       RewriteEngine on
</VirtualHost>

download and install yii2 advance
try any redirect

What is the expected result?
Redirect
What do you get instead?
Nothing
Redirect do not work
Additional info

Q
A

Yii version
2.0.12

PHP version
7.1

Operating system
debian 9

Web server
Apache2

How do you redirect?

Like this
return Yii::$app->response->redirect(['@web/customer']);

and this
return $this->redirect(['index']);

What headers are being sent to the browser? You can check these w/ Chronme "Network" tab.

http://www.yiiframework.com/doc-2.0/guide-start-installation.html#recommended-apache-configuration

Response header
Connection:Keep-Alive
Content-Length:1
Content-Type:text/html; charset=UTF-8
Date:Fri, 25 Aug 2017 07:11:50 GMT
Keep-Alive:timeout=5, max=100
Server:Apache/2.4.10 (Debian)
X-Powered-By:PHP/7.1.8

@githubjeka Thanks, but did not help

        ServerName localhost
	ServerAdmin webmaster@localhost

Change ServerName to a service name from docker-compose.yml, in your case is a php\

if not work
change listen address
<VirtualHost php:8080>

@bscheshirwork Unfortunately, the same behavior

You can directly go to target url?

You .htaccess is correct?

@bscheshirwork yes, i can directly go to target url
my .htaccess in frontend/web
RewriteEngine on
# If a directory or a file exists, use it directly
RewriteCond %{REQUEST_FILENAME} !-f
RewriteCond %{REQUEST_FILENAME} !-d
RewriteCond %{REQUEST_FILENAME} !-l
# Otherwise forward it to index.php
RewriteRule . index.php

Hmm http://httpd.apache.org/docs/current/rewrite/flags.html#flag_l

You can directly go to for <IP_ADDRESS>/index.php?r=controller/action or <IP_ADDRESS>/?r=controller/action or <IP_ADDRESS>/controller/action?
You analyze access.log / error.log for Apache and for yii2?
note: this settings is change the url:
        'urlManager' => [
            'enablePrettyUrl' => true,
            'showScriptName' => false,
            'rules' => [
            ],
        ],

@bscheshirwork I configurate urlManger like:
'urlManager' => [
            'class' => 'yii\web\UrlManager',
            // Disable index.php
            'showScriptName' => false,
            // Disable r= routes
            'enablePrettyUrl' => true,
            'rules' => array(
                '<controller:\w+>/<id:\d+>' => '<controller>/view',
                '<controller:\w+>/<action:\w+>/<id:\d+>' => '<controller>/<action>',
                '<controller:\w+>/<action:\w+>' => '<controller>/<action>',
            ),
        ],

So i use <IP_ADDRESS>/controller/action

And after redirect url is <IP_ADDRESS>/controller/action php/controller/action localhost/controller/action into access log's files?

apache logs:
php_1  | [Fri Aug 25 09:05:39.219766 2017] [authz_core:debug] [pid 22] mod_authz_core.c(809): [client <IP_ADDRESS>:34386] AH01626: authorization result of Require all granted: granted
php_1  | [Fri Aug 25 09:05:39.219777 2017] [authz_core:debug] [pid 22] mod_authz_core.c(809): [client <IP_ADDRESS>:34386] AH01626: authorization result of <RequireAny>: granted
php_1  | [Fri Aug 25 09:05:39.219807 2017] [authz_core:debug] [pid 22] mod_authz_core.c(809): [client <IP_ADDRESS>:34386] AH01626: authorization result of Require all granted: granted
php_1  | [Fri Aug 25 09:05:39.219810 2017] [authz_core:debug] [pid 22] mod_authz_core.c(809): [client <IP_ADDRESS>:34386] AH01626: authorization result of <RequireAny>: granted
php_1  | <IP_ADDRESS> - - [25/Aug/2017:09:05:39 +0000] "GET /site/login HTTP/1.1" 200 229 "-" "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3112.78 Safari/537.36"

header('Location: https://www.google.com/');
in frontend/web/index.php on top redirect on google.
curl http://php:8080
in docker in terminal return start page

so... i can see /site/login, not /customer

Like this

return Yii::$app->response->redirect(['@web/customer']);

You can not have any problem with authorization?

Also alias @web into advanced template is not exist by default. May be can use @frontend or @backend instead it?

@bscheshirwork
no, authorization work, it is just example (in browser = http://localhost:8080/site/login)
in frontend/controllers/SiteController.php i have action
public function actionLogin()
    {
        // test
        return Yii::$app->response->redirect(['/customer']);
    }

CustomerController.php also have

Ok, i.e. in logs you see only first request, nothing about redirect, it's correct?
i.e. target of redirect is out of responsibility Apache / not catch

also you can check target of redirect ($url) like a redirect source
    public function redirect($url, $statusCode = 302, $checkAjax = true)
    {
        if (is_array($url) && isset($url[0])) {
            // ensure the route is absolute
            $url[0] = '/' . ltrim($url[0], '/');
        }
        $url = Url::to($url);
        if (strpos($url, '/') === 0 && strpos($url, '//') !== 0) {
            $url = Yii::$app->getRequest()->getHostInfo() . $url;
        }
...
}

and compare it with Apache config

@bscheshirwork in apache logs not informations about redirect.
var_dump() in redirect func return _http://localhost:8080/customer_ exactly what i need, but still empty page.

You php service IP address (in internal Docker network for your docker-compose) is typically <IP_ADDRESS>
(If I correct read a log). Also you can see it with commands:
docker network ls
find yourdockercomposefolder_default
docker network inspect yourdockercomposefolder_default
Also you can access to it use Docker DNS as "php" from any containers inside this network.
outside you can access by your system IP or by default <IP_ADDRESS>
localhost loop is not correct I think

@bscheshirwork you are right: i can invoke need action with url <IP_ADDRESS>:8080, but redirect still not work.
But i remark some interesting in logs:
php_1  | [Mon Aug 28 05:09:27.376296 2017] [reqtimeout:info] [pid 18] [client <IP_ADDRESS>:39482] AH01382: Request header read timeout
php_1  | <IP_ADDRESS> - - [28/Aug/2017:05:09:27 +0000] "-" 408 0 "-" "-"
php_1  | <IP_ADDRESS> - - [28/Aug/2017:05:09:27 +0000] "-" 408 0 "-" "-"
php_1  | [Mon Aug 28 05:09:27.376444 2017] [reqtimeout:info] [pid 26] [client <IP_ADDRESS>:39486] AH01382: Request header read timeout
php_1  | [Mon Aug 28 05:09:27.376504 2017] [reqtimeout:info] [pid 19] [client <IP_ADDRESS>:39488] AH01382: Request header read timeout
php_1  | <IP_ADDRESS> - - [28/Aug/2017:05:09:27 +0000] "-" 408 0 "-" "-"
php_1  | [Mon Aug 28 05:09:27.392312 2017] [reqtimeout:info] [pid 27] [client <IP_ADDRESS>:39484] AH01382: Request header read timeout

I think, that redirect work, but need set correct url.
If i find solution, i will write here

Also try to make redirect on DNS name php directly.
also you config is different
RewriteEngine on
# If a directory or a file exists, use it directly
RewriteCond %{REQUEST_FILENAME} !-f
RewriteCond %{REQUEST_FILENAME} !-d
RewriteCond %{REQUEST_FILENAME} !-l
# Otherwise forward it to index.php
RewriteRule . index.php

recommended
# Set document root to be "basic/web"
DocumentRoot "path/to/basic/web"

<Directory "path/to/basic/web">
    # use mod_rewrite for pretty URL support
    RewriteEngine on
    # If a directory or a file exists, use the request directly
    RewriteCond %{REQUEST_FILENAME} !-f
    RewriteCond %{REQUEST_FILENAME} !-d
    # Otherwise forward the request to index.php
    RewriteRule . index.php

    # ...other settings...
</Directory>

I've tried config from the first post with some adjustments:
composer create-project --prefer-dist yiisoft/yii2-app-advanced@dev yii-docker-application
cd yii-docker-application
docker pull php:7.1-apache
cat <<EOF > php-apache2
FROM php:7.1-apache
RUN a2enmod rewrite
EOF
cat <<EOF > docker-compose.yml
version: '2'
services:
    php:
        build:
          context: ./
          dockerfile: php-apache2
        volumes:
            - ./:/var/www/html/
            - ./apache_conf:/etc/apache2/sites-enabled/
        ports:
            - "8080:8080"
EOF
mkdir apache_conf
cat <<EOF > apache_conf/site.conf
Listen 8080
<VirtualHost *:8080>
        ServerName localhost
	ServerAdmin webmaster@localhost
	DocumentRoot /var/www/html/frontend/web/
	LogLevel debug
	ErrorLog ${APACHE_LOG_DIR}/error.log
	CustomLog ${APACHE_LOG_DIR}/access.log combined
	# Set up rewrites so that all requests go to index.php
       RewriteEngine on
</VirtualHost>
EOF
./init --env=Development
docker-compose up

In this environment redirect works exactly as it should, so I'm closing the issue.

31 Aug 2017
http://php.net/ChangeLog-7.php
Session:
Fixed bug #74892 (Url Rewriting (trans_sid) not working on urls that start with "#").
may be already fix it...


Resource leaking in http-stream-request

If I stop a stream request before it's finished, the stream function will never finish, without any exception or warning.
So, if I want to release something (such as threading.Lock) in the end of the function, I will never be able to release it.
Here's an example.
# flask server
import time
from flask import *

def stream():
    print("acquire something")
    for i in range(5):
        yield str(i)
        time.sleep(1)
    print("release something")

app = Flask(__name__)

@app.route("/")
def _():
    return Response(stream())

if __name__ == '__main__':
    app.run("<IP_ADDRESS>", 45678)

when I request it and stop it early (for example, I'm timeout)
>>> curl http://localhost:45678 --max-time 2
01curl: (28) Operation timed out after 2002 milliseconds with 2 bytes received

then, the function stream() will never stopped, here's the log.
acquire something
<IP_ADDRESS> - - [13/Aug/2023 18:17:01] "GET / HTTP/1.1" 200 -

I wish, flask will do like one of these:

throw a ResourceWarning when the request has stopped
run stream() to the end, whatever the request stop or not
if stream() is an AsyncIterator(Coroutine), send an Exception into it when the request has stopped

Environment:

Python version: 3.9
Flask version: 2.2.3

It would be up to the WSGI server to close the response or destroy the worker. It's not something the WSGI application (Flask) can control. There's no way to do the things you suggest from our end.

I see, it's a bug from werkzeug, not from Flask. Thanks.

Werkzeug is also the application side. If you're referring to the dev server, it won't be fixed there. Use a production WSGI server.


found conflicting dependencies while installing the automatic1111 plugin

ERROR: Cannot install -r ./extensions/Auto-Photoshop-StableDiffusion-Plugin/requirements.txt (line 22), click==8.1.3 and duckduckgo-search==3.9.3 because these package versions have conflicting dependencies.
ERROR: ResolutionImpossible: for help visit https://pip.pypa.io/en/latest/topics/dependency-resolution/#dealing-with-dependency-conflicts

The above error prevents webui from starting.
Removing version limit for duckduckgo-search allows webui to start but generates another error :
python_server_full_path:  /stable-diffusion-webui/extensions/Auto-Photoshop-StableDiffusion-Plugin/server/python_server
*** Error loading script: main.py
    Traceback (most recent call last):
      File "/stable-diffusion-webui/extensions/Auto-Photoshop-StableDiffusion-Plugin/server/python_server/search.py", line 4, in <module>
        from duckduckgo_search import AsyncDDGS
    ImportError: cannot import name 'AsyncDDGS' from 'duckduckgo_search' (/opt/conda/lib/python3.10/site-packages/duckduckgo_search/__init__.py)

    During handling of the above exception, another exception occurred:

    Traceback (most recent call last):
      File "/stable-diffusion-webui/modules/scripts.py", line 382, in load_scripts
        script_module = script_loading.load_module(scriptfile.path)
      File "/stable-diffusion-webui/modules/script_loading.py", line 10, in load_module
        module_spec.loader.exec_module(module)
      File "<frozen importlib._bootstrap_external>", line 883, in exec_module
      File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
      File "/stable-diffusion-webui/extensions/Auto-Photoshop-StableDiffusion-Plugin/scripts/main.py", line 25, in <module>
        import search
      File "/stable-diffusion-webui/extensions/Auto-Photoshop-StableDiffusion-Plugin/server/python_server/search.py", line 6, in <module>
        raise ImportError(
    ImportError: duckduckgo_search is required to image search. Please install it with `pip install --upgrade duckduckgo_search`.

finally found the problem, must make the plugin work to receive the correct inpaint result.


Are there any android performance data compare to other frameworks?

For example,
ncnn from tencent,
caffe2

Last week I had test the squeezenet on the three frameworks(mdl,ncnn,caffe2) with the Qualcomm 820 devices.
Framework           Comsuming time with single-core or multi-cores ( ms )
mdl                                 130 / 98
ncnn                               310 / 68
caffe2                             170 / null
For reference only,Thanks a lot !


How to add new function to this library?

Hi,
I am trying yo add additional function to library.
I want to open another app from my carplay app.
So I added:
RCT_EXPORT_METHOD(launchmap:(NSString*)templateId) {
    CPTemplate *template = [[RNCPStore sharedManager] findTemplateById:templateId];
    if (template) {
        CPMapTemplate *mapTemplate = (CPMapTemplate*) template;
        [mapTemplate hideTripPreviews];

        NSString *urlString = @"http://maps.apple.com/?daddr=\(42.3773697),\(7.3966319)&dirflg=d";

        [[RNCPStore sharedManager] openURL:urlString];
    }
}

I also added to MapTemplate.d.ts
launchmap(): void;
But when I call it from my code:
mapTemplate.launchmap();
It doesn't work.
What should I do to extend library with additional function?

So with this library, you have to add it in a few more places. MapTemplate.ts has a place where it actually connects it to the native module. I would do a global search of "updateMapButtons" in your code and look at all the places it is declared. Just insert yours along the chain, and it will work!

@vvusts you may want to just add an onClick handler to a button / menu within your carplay template and then execute this code in the callback. I may be missing something but I do not believe that the functionality you are suggesting is generic enough to warrant being added to this codebase. Happy to be corrected on this if you feel otherwise.

Have to agree with @tomdye. Feel free to open the issue if you still feel this is something we should consider.
Or if there is some specific CarPlay linking things we need to do.


FYI: you're using an old version of poetry

I noticed poetry.lock says generated by Poetry 1.4.2, which is nearing a year old. If you updated, maybe resolving would be faster, or it might result in different packages. As I worked on https://github.com/moj-analytical-services/splink/pull/1968 the diff in the the poetry.lock file was quite different simply due to me using poetry 1.7.1, so it was hard to separate the changes due to the looser dependency ranges, and simply due to a newer version of poetry.

Splink4 should have resolve any issues with lockfile


File association on windows

Hi @stefanjudis, @demetris-manikas and @vxsx,
In the PR, a new option is created to define a custom file association on Windows.
Thank in advance for reviewing and leaving comments.

@vQuagliaro sorry for delay.
I'm currently on vacation  but will be back tomorrow. So I'm trying to get to it asap.
If nothing happened in 2day - feel free to ping again. :bowtie:

Very good!

Hi @stefanjudis,
I'm back :smile: !
Thank in advance for reviewing and leaving comments.

@vQuagliaro
Hey hey, I finally had some time to look at it. Sorry again for the delay.

a custom file association on Windows.

Can you explain me the use case for this. I'm not familiar with this file association thing. :(

@stefanjudis I worked with Vincent on a project with Electron.
File association in Windows is the feature that allows you to tell Windows that a .myapp file type is to be opened with your Electron application.
Then, when the user double-clicks on the files with your custom file type, it opens them automatically with your application.
Here is a blog article we wrote on this feature to explain it in more detail: http://www.theodo.fr/blog/2015/12/link-files-to-application-in-windows/

@TristanPouliquen @vQuagliaro
Uhhh nice!!! Thanks for explanation.
I will have a look at it tonight.
What about the macos counterpart. Did you folks play around with that too?

@stefanjudis It is on our TODO list. But the mechanism seems to be quite different and it is not in the scope of the project we are working on at work for the moment.
But we are building an electron-boilerplate to help bootstrap complete Electron applications for all platforms so we will come to it !

But the mechanism seems to be quite different and it is not in the scope of the project we are working on at work for the moment.

Fair enough - probably we would need a proper package installer for that. :)
I will check this PR tonight then and probably also ship a new version of electron-builder tonight.

Shi....
I was working through the PR's from top. :(
@vQuagliaro Can you please resolve conflicts.
Sorry.

Yes, I'm resolving conflicts now.

WIP, I'm testing.

@stefanjudis
Conflicts have been resolved and it has just been tested manually.
The same feature for osx is always on our TODO list.
Thanks for all.

@stefanjudis,
I'm back :smile: !
If you have time, could you please check and merge this PR?

LGTM! :+1:
Just a little side note... please check commit messages of the project. ;)
No need for [...] foo here. :)
But thanks for contribution. :)


[SPARK-16285][SQL] Implement sentences SQL functions

What changes were proposed in this pull request?
This PR implements sentences SQL function.
How was this patch tested?
Pass the Jenkins tests with a new testcase.

Test build #61575 has started for PR 14004 at commit f29a8c3.

Test build #61575 has finished for PR 14004 at commit f29a8c3.

This patch fails from timeout after a configured wait of `250m`.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class Sentences(

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61575/
Test FAILed.

Test build #61590 has started for PR 14004 at commit d5f84c9.

Test build #61590 has finished for PR 14004 at commit d5f84c9.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class Sentences(

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61590/
Test PASSed.

cc @rxin and @cloud-fan

Just rebased.

Test build #61664 has started for PR 14004 at commit c9e235a.

Test build #61664 has finished for PR 14004 at commit c9e235a.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class Sentences(

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61664/
Test PASSed.

Test build #61680 has started for PR 14004 at commit ea75373.

Test build #61680 has finished for PR 14004 at commit ea75373.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61680/
Test PASSed.

Rebased to resolve conflicts.

Test build #61694 has started for PR 14004 at commit d021d39.

Test build #61694 has finished for PR 14004 at commit d021d39.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61694/
Test PASSed.

Test build #61710 has started for PR 14004 at commit 922e6e7.

Test build #61710 has finished for PR 14004 at commit 922e6e7.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61710/
Test PASSed.

Test build #61807 has started for PR 14004 at commit f1a5c1b.

Test build #61816 has started for PR 14004 at commit 50629b5.

Test build #61818 has started for PR 14004 at commit a98c05e.

Now, the PR became more concise. Thank you for decision, @cloud-fan .

Oh, @cloud-fan .
Is there some misunderstanding?

If then, I will reposition that.
Do you mean making a new java file containing not-really-UTF8String function?

Test build #61807 has finished for PR 14004 at commit f1a5c1b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61807/
Test PASSed.

By the way, I found that TernaryExpression.eval seems not compatible for sentences('', null, null).
I'll let you know after finishing the update.

Test build #61816 has finished for PR 14004 at commit 50629b5.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61816/
Test PASSed.

Test build #61818 has finished for PR 14004 at commit a98c05e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61818/
Test PASSed.

Test build #61827 has started for PR 14004 at commit d2da078.

Test build #61829 has started for PR 14004 at commit 9e8cfbc.

Test build #61832 has started for PR 14004 at commit 4529d43.

Hi, @cloud-fan . I've updated the PR. The following is a summary of changes.

To support sentence('', null, null), Sentences extends Expression instead of TerneryExpression.
getLocale is merged into getSentences. (according to the comment.)
getSentences is now in Sentences expression. (Yep. I know. It's accidentaly due to my misunderstanding)
Add more testcases and move test location into StringExpressionsSuite and StringFunctionsSuite.

Test build #61827 has finished for PR 14004 at commit d2da078.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test build #61829 has finished for PR 14004 at commit 9e8cfbc.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61829/
Test PASSed.

Test build #61832 has finished for PR 14004 at commit 4529d43.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61832/
Test PASSed.

If you think UTF8String.sentences is needed, please let me know. I'll recover again.

LGTM except some style comment, thanks for working on it!

Thank you, @cloud-fan .
I updated the PR according to your comments.

Test build #61895 has started for PR 14004 at commit 8d7c3d4.

Test build #61899 has started for PR 14004 at commit 4144e7f.

Test build #61895 has finished for PR 14004 at commit 8d7c3d4.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61895/
Test PASSed.

Merged build finished. Test PASSed.

Test build #61899 has finished for PR 14004 at commit 4144e7f.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61899/
Test PASSed.

Hi, @cloud-fan .
Finally, it passed again.

and one comment for the old thread: https://github.com/apache/spark/pull/14004#discussion_r69893328

Test build #61920 has started for PR 14004 at commit 9164f54.

Test build #61920 has finished for PR 14004 at commit 9164f54.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61920/
Test PASSed.

Hi, @rxin .
Could you review and merge this sentences PR?

This looks alright. I left some minor comments. Please move this out of the regex file. Seems like it should go into stringExpressions file.

LGTM pending Jenkins.

Test build #61969 has started for PR 14004 at commit 7912bf7.

Thank you for review again!

Test build #61969 has finished for PR 14004 at commit 7912bf7.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class Sentences(

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61969/
Test PASSed.

Hi, @cloud-fan .
Could you merge this sentences PR, too?

Oops. You already did. Thank you, @cloud-fan .
And, thank you, @rxin .

thanks, merging to master and 2.0!


Clarify Azure Stack family support : Hub and/or HCI

I guess this pages refers to OpenShift support on  Azure Stack Hub ; please add official support policy for V3 & V4 , see also  :
https://access.redhat.com/articles/3413531#header11
https://access.redhat.com/solutions/4515401
Azure Stack HCI is a Hyper-V plateform, like WS 2019.
It does support RHEL 7.8 & 7.9.
The OpenShift Container Platform docs does not officially states that it does Azure Stack HCI, Hyper-v neither.
OpenShift Container Platformsupport policy  states : Non-RHCOS compute nodes aren't supported. For example, you can't use a RHEL compute node.
OpenShift Container Platform docs states:

Red Hat Enterprise Linux CoreOS (RHCOS) represents the next generation of single-purpose container operating system technology. Created by the same development teams that created Red Hat Enterprise Linux Atomic Host and CoreOS Container Linux, RHCOS combines the quality standards of Red Hat Enterprise Linux (RHEL) with the automated, remote upgrade features from Container Linux. RHCOS is supported only as a component of OpenShift Container Platform 4.7 for all OpenShift Container Platform machines.
RHCOS is the only supported operating system for OpenShift Container Platform control plane, or master, machines.
While RHCOS is the default operating system for all cluster machines, you can create compute machines, which are also known as worker machines, that use RHEL as their operating system

Based on RHEL: The underlying operating system consists primarily of RHEL components. The same quality, security, and control measures that support RHEL also support RHCOS.

For example, RHCOS software is in RPM packages, and each RHCOS system starts up with a RHEL kernel and a set of services that are managed by the systemd init system.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 96c87901-6786-bd3f-a4e2-af292f6eb49a
Version Independent ID: e3c47a7b-ce1e-6667-2494-d8db3e10d099
Content: Deploy OpenShift in Azure Stack - Azure Virtual Machines
Content Source: articles/virtual-machines/linux/openshift-azure-stack.md
Service: virtual-machines
Sub-service: openshift
GitHub Login: @haroldwongms
Microsoft Alias: haroldw

@ezYakaEagle442 Thanks for the feedback! I have assigned the issue to content author to check and update the document as appropriate. We will update you accordingly.

@haroldwongms Can you please check and add your comments on this doc update request as applicable

@Karishma-Tiwari-MSFT Can we get the tags on this changed to azure-stack from virtual-machines?

Thanks for your dedication to our documentation. Unfortunately, at this time we have been unable to review your issue in a timely manner and we sincerely apologize for the delayed response. If you are still experiencing a problem, you might want to move this question to Microsoft Q&A: https://learn.microsoft.com/en-us/answers/tags/94/azure-virtual-machines.  #please-close


Created Italian translation

@omame Can you take a look at this?

@marcostudios  Can you also please fix line 7?
After that it's :+1: for me.
PS: I swear I'm not a grammar nazi. :stuck_out_tongue_winking_eye:

Sure :+1:


Add support for optional marked content.

Add a new method to the API to get the optional content configuration. Add
a new render task param that accepts the above configuration.
For now, the optional content is not controllable by the user in
the viewer, but renders with the default configuration in the PDF.
All of the test files added exhibit different uses of optional content.
Fixes #269.

/botio test

/botio test

/botio test

You should push a { visible: true } object also in beginMarkedContent ("BMC").
https://github.com/mozilla/pdf.js/blob/d69fb446bff53e4d8eddc520635b004f4ac986d3/src/display/canvas.js#L2444
"EMC" is the end of both "BMC" and "BDC" sections. "BMC" is not related to optional content but some PDFs may use it and the marked content stack might go wrong.

@brendandahl Given that this PR seems really close to being done, since there's just a few more comments to fix (such that all tests pass), do you perhaps have time to fix the remaining things such that this can land?
I've been playing around with this patch a fair bit locally[1], and it seems to work really well in practice :-)
Also, the overall implementation is a lot simpler than I thought it would be when reading the specification.

[1] I've got, more-or-less, finished patches for the viewer integration.

/botio test

By the way, the unit test failures (and most likely the reference test failures as well) are known intermittents and are tracked in #12123 (the Windows one is a new one that I now mentioned there).

/botio test

/botio makeref


The CUPS out of order on my arm board  [Website shows not found] [lpinfo cannot normally execute]

Hello, Dear every developer:
I am new to CUPS. Recently, I want to port the CUPS to my arm board. When I finished the work of cross compilation and run CUPS on my board, I found that I only can visit the home page. When I click other pages , it shows NOT FOUND.
At the same time , when i input command "lpinfo -v" and "lpinfo -m", the screen show me "lpinfo: cups-deviced failed to execute." and "lpinfo: cups-drived failed to execute." . I don't know what went wrong with CUPS.
Here are my log files and conf file.
github_issue_cups_20230620202209.zip
Thank you.

These log files, I do something, and the steps are as follows:

dbus-daemon --system
avahi-daemon &
./cups start
I clicked the PRINTER page and JOB page.
I input "lpinfo -v" and "lpinfo -m" command.
I input command "kill" to kill the cups.

Directories where you put the installation don't have the correct permissions:
E [01/Jan/1970:00:08:51 +0000] Directory \"/mnt/app/printer/lib/cups/cgi-bin\" has insecure permissions (040777/uid=0/gid=0).
...
E [01/Jan/1970:00:08:59 +0000] Directory \"/mnt/app/printer/lib/cups/daemon\" has insecure permissions (040777/uid=0/gid=0).

Usually they have 755 and root:root.

@zdohnal Hi zdohnal, I meet a new question.  I do the cmd "chmod 777 -R" , it shows "has insecure permissions (0100777/uid=0/gid=0)" . But，  I do the cmd "chmod 755 cgi-bin -R " , the error_log shows "stopped with status 113 (permission denied)". Could you tell me why ? I dont't dnow how to solve this problem. Here's the log.
error_log_20230627112309.zip

Is there anything I can do to keep him it checking permissions？

@zdohnal Hi zdohnal, I did what you said. And I meet new question:  I do the cmd "chmod 755 printers.cgi" and error_log shows "(/mnt/app/printer/lib/cups/cgi-bin/printers.cgi) stopped with status 113 (Permission denied)". Then I do the cmd "chmod 777 printers.cgi" and error_log shows "File "/mnt/app/printer/lib/cups/cgi-bin/printers.cgi" has insecure permissions (0100777/uid=0/gid=0)". Seems to be either 755 or 777, the CUPS still run abnormally.
Did I do something wrong? Is there any way to not check permissions？ Here 's error_log. Thank you.
error_log_20230627144746.zip

What are the configure option you used for building CUPS?
I'm sorry, I haven't done any cross compilation stuff, so I'm not entirely sure, but are you running cupsd under root? It could be the reason.

Hi zdohnal，my configure option is as follow:
./configure --prefix=/mnt/app/printer --host=aarch64-mix210-linux CFLAGS="-I/mnt/app/printer/include" CXXFLAGS="-I/mnt/app/printer/include" LDFLAGS="-L/mnt/app/printer/lib -lssp -lavahi-client -lavahi-common -lgnutls -lz -lffi -lgmodule-2.0 -lglib-2.0 -ldbus-1 -lunistring -lp11-kit -ltasn1 -lnettle -lhogweed -lgmp -ludev -lusb-1.0" --enable-libusb --enable-debug --enable-debug-guards --enable-debug-printfs --disable-gssapi --with-adminkey --with-operkey --with-cachedir=/mnt/app/printer/var/cache/cups --with-tls=gnutls --with-dnssd=avahi --with-systemd=/mnt/app/printer/systemd/cups --with-log-level=debug --with-access-log-level=debug --with-idle-exit-timeout=60 --with-dbusdir=/mnt/app/printer/etc/dbus-1

And I use "sudo make DESTDIR=${PWD}/_n2 install " to install in my PC. Then I copy the files to my arm board. After copying, I change permission by using "chown" and "chgrp". I start service use "root".
But at now I find that, when I change permission "700" for "printers.cgi" it also shows "permission denied", I suspect CUPS is not run as root. But I use command "stat cgi-bin" and "ls -l" to view the permission, it shows root. And I use cmd "ps aux|grep cups", it also shows runing as root.

One more thing, my arm board only have root 1 user.

I also use other configure option , but the result is same. As follow:
./configure --prefix=/mnt/app/printer --host=aarch64-mix210-linux CFLAGS="-I/mnt/app/printer/include" CXXFLAGS="-I/mnt/app/printer/include" LDFLAGS="-L/mnt/app/printer/lib -lssp -lavahi-client -lavahi-common -lgnutls -lz -lffi -lgmodule-2.0 -lglib-2.0 -ldbus-1 -lunistring -lp11-kit -ltasn1 -lnettle -lhogweed -lgmp -ludev -lusb-1.0" --enable-libusb --enable-debug --enable-debug-guards --enable-debug-printfs --disable-gssapi --with-adminkey --with-operkey --with-cachedir=/mnt/app/printer/var/cache/cups --with-tls=gnutls --with-dnssd=avahi --with-systemd=/mnt/app/printer/systemd/cups --with-exe-file-perm=0777 --with-config-file-perm=0777 --with-cupsd-file-perm=0777 --with-log-file-perm=0777 --with-log-level=debug --with-access-log-level=debug --with-idle-exit-timeout=60 --with-dbusdir=/mnt/app/printer/etc/dbus-1

I'm sorry, I don't know how to help you further :( @michaelrsweet do you know what culprit can be or how to debug further? The only thing I can think of is capture syscalls with strace, which can give some insight...

@zdohnal It doesn't matter, zdohnal. I found the same question on(https://stackoverflow.com/questions/32462340/cups-permission-denied).  I do the same thing , but cups still shows permission denied or insecure permission. Could I modify the code for skipping the permission checking? And how to modify?

Hello, can someone help me ?

HI, By modifying the code in process.c,  I had solved my question. Thanks.


**/lib/ directory are not managed in this repo

This repository must manage ./src/lib directory.

Even if #4 was merged, cannot fix all the bug.
./test/lib directory is not managed.


question about the dimension of the net

If the input of the net is of 643224224 dimension,where 64 is the batch size,3 is the channels and 224 is the size of the original image,and i run the code and find out that the output's dimension of the net is 480210,where 10 is the classes to predict.
Is the output correct?Shouldn't the dimension of the output be 64*10?
Maybe i get something wrong?

If the input of the net is of 643224224 dimension,where 64 is the batch size,3 is the channels and 224 is the size of the original image,and i run the code and find out that the output's dimension of the net is 480210,where 10 is the classes to predict.
Is the output correct?Shouldn't the dimension of the output be 64*10?
Maybe i get something wrong?

If the input of the net is of 64x3x224x224 dimension,where 64 is the batch size,3 is the channels and 224 is the size of the original image,and i run the code and find out that the output's dimension of the net is 4802x10,where 10 is the classes to predict.
Is the output correct?Shouldn't the dimension of the output be 64x10?
Maybe i get something wrong?

Hi @Agito555 the problem is that the network expects images of size 32, so inputting 224 results in bigger feature maps with mess up with the average pooling https://github.com/prlz77/ResNeXt.pytorch/blob/master/models/model.py#L138
I suggest you just change the above line by x.mean((2,3))
Hope this helps!
Pau

Yeah,thanks for your reply. I take it for granted that the input size of the image is the same as the size in the paper.
I also want to know whether the network architecture is a little bit different from the architecture(Resnext50) in the paper?

Well in the paper they also try CIFAR (Table 7) for which the input is 32x32. There should be no differences with respect to the CIFAR model. If there are, it could be due to many reasons such as differences in the frameworks used to train the models.


Support lz4 block format

To help with https://github.com/dask/fastparquet/pull/580

benchmarks look good

This will add block format for lz4, but not (yet) _into options as lz4 doesn't support compression into slices, only outputting new Vecs.
There is a possibility _intos could be added later as lz4_flex may be adding this API in the future, trade off there being no guarantee their the API would follow a similar Python API as lz4 crate does now; so would almost certainly require re-implementing the store_size component. Could always get creative and use some unsafe code to trick whatever slice we have into a Vec if it's really desired; as I'm pretty sure lz4 crate won't be chaining its API anytime soon; but have opened an issue anyway

@martindurant is this good with you?  I'll come back for the _intos depending on what becomes of that issue I made.

Yes, totally good.
It turns out there is also a hadoop-specific version of lz4 that was used by map-reduce, but I think we can safely ignore it.


[material-ui] Change React.ReactElement<any,any> type from any to unknown

Part of: https://github.com/mui/material-ui/issues/42380
since no one has taken up the issue since last 3 months, i opened PR fixed it

[x] I have followed (at least) the PR section of the contributing guide.

I could find other instances of ReactElement<any> still present.

Ah okay, I've changed closes to part of. Regarding remaining instances, I'll open new PR as it will be easier for you to review

@DiegoAndai opened follow up PR for left over instances https://github.com/mui/material-ui/pull/43402


Remove dockerize in dev image

Feature Request
Is your feature request related to a problem or unsupported use case? Please describe.
A dockerize image exists and can be added as a service in our docker-compose configuration. Not having dockerize installed in the marsha development image will lighten it a little bit and speed its build.
Describe the solution you'd like
Remove dockerrize in the Dockerfile and add a new service in our docker-compose.yml file like we did in the repo openfun/openedx-docker. All call to dockerize should also be changed, mostly in the Makefile

@lunika I'd like to work on this one, can you assign it to me?

@venkatramanareddy done. Don't forget to read our contributing guide first: https://github.com/openfun/marsha#contributing


cloud-fabric: Update for Minecraft 1.19.3

I'm not sure we want to wholesale delete the MobEffectArgument -- it's kinda an API break. What about deprecating it and having it use a RegistryEntryArgument parser instead?

Sounds reasonable to me


bcm283x (or new pkg): BCM2711 clock source is off

Describe the bug
With the Pi4 and BCM2711, the oscillator clock changed from 19.2Mhz to 54Mhz, which leads to the wrong clock source being selected.
I'd suggest to either explicitly drop support or when a BCM2711 chip is detected, use the new oscillator frequency

Acknowledging the problem. This code needs a revamp, which I filed a separate issue for.


[Requirements and Updates] Feature Flag Service UI

Goals

[ ] Form to Create new feature flag
[ ] Have an Dashboard UI for displaying all feature flags
[ ] UI for updating an existing feature flag
[ ] A super user only dashboard to view the requests served
[ ] Feature flags Dashboard UI improvements: sort, filter, search.

Discussions on Dashboard UI:
on 17th Dec

Old feature flag service repo has initial dummy UI for dashboard which we can use as inspiration.
Screenshot:

Also discovered dashboard site has initial dummy UI built for dashboard, This UI isn't in sync with how we want but will start with updating this to our needs.
Screenshot:

Update: Discussion with Ankush
on 19th Dec

Is feature flag UI to be built in dasboard site or another site?
Not sure yet. Waiting for answer from Ankush.

Will each user be able to enable/disable feature flag for themselves?
No, only super users and members can update feature flag for other users.

Is there any role based enable/disable feature? i.e. enable/disable a feature flag for users with particular users.
No.


Image / vision API support

Just discovered this, and I both detest and greatly respect that you actually built (and surpassed) something I merely daydreamed about idly one day. Congrats! :D
As of recently, images serve as both LLM input (Vision API beta) and output (DALL-E). Now I can't help but wonder about the potential for image nodes in Cannoli!
I haven't familiarized myself with the code yet, but in theory I'm very much down to contribute as well.

I've been testing vision with the action nodes. got it working like this:

Thanks so much for trying cannoli!
Yes this would be awesome, and with all the new API features out it's high on my list.
Also, awesome work solarbotanist, are you saying that this is working as intended, and the images are being sent and received correctly? That's amazing! I always wanted to write an openai action node for the meme, but hadn't yet.

Yes everything is working as intended! The action node as described can proces both online image URI's as well as base64 encoded images.
A base64 encoding function could be implemented in the TS so that images in the vault could be used directly.

any updates on this?

Not yet, but I just looked at the vision docs for OpenAI at least, and it's not as bad as I thought it would be. So maybe not that far off after all.

Vision is now implemented! All you have to do is embed an image from a url or your vault using markdown syntax: ![[your_image.jpg]] or ![description](imageurl.com)
We've also added a built-in dalle action.


Schema Migrations Maven Plugin

A plugin that allows schema migrations with just one command

fixed in 0.2.0


Unrepresented footer should only appear on PrEP, not other HIV topics

Describe the bug
Footer is present on all HIV topics
Expected behavior
The unrepresented race is only used by PrEP, so the footer should only appear on that topic
Screenshots

This was resolved in PR #2111.


fixed formatting + clippy warnings

It's a good idea to set your editor to remove trailing spaces, and layout code using either all tabs or spaces (I personally prefer 4 spaces, and so does rustfmt by default).
The clippy-induced changes are mostly trivial, but I removed two loops in uci.rs, using .iter().position(..) instead.

Thanks a lot!

You're welcome.


vcs_PullRequest: Add Source and Target Branch

Pull/Merge Requests generally have information about the head/source and base/target branches of interest, but the current data model for vcs_PullRequest does not capture this information. It would be useful to have source/target branch references as part of vcs_PullRequest to derive workflow information.

Adding image of unit-test results


bug plugin not working

hi,
i'm using this plugin and out of nowhere the plugin stopped working and gives this error:
/opt/flutter/.pub-cache/hosted/pub.dartlang.org/pdf_viewer_jk-2.1.2/lib/src/document.dart:75:14: Error: The class 'File' is abstract and can't be instantiated.
file = File("${dir.path}/file.pdf");
^^^^
/opt/flutter/.pub-cache/hosted/pub.dartlang.org/pdf_viewer_jk-2.1.2/lib/src/document.dart:83:26: Error: Non-nullable variable 'file' must be assigned before it can be used.
document._filePath = file.path;
^^^^
/opt/flutter/.pub-cache/hosted/pub.dartlang.org/pdf_viewer_jk-2.1.2/lib/src/document.dart:86:24: Error: Non-nullable variable 'file' must be assigned before it can be used.
{'filePath': file.path, 'clearCacheDir': clearPreviewCache});
^^^^
edit:
I also tested with the code that is in the github repository and gives the same problem

I have the same error on version 2.1.0. I upgraded from 2.0.0-nullsafety.

same error, any workaround? i'm on flutter 2.2.1

What is your flutter , and dart version?

The error occurred after "pub upgrade". Latest version library:  pdf_viewer_jk: ^2.1.0
[✓] Flutter (Channel beta, 2.2.0, on Mac OS X 10.15.7 19H2 darwin-x64, locale ru-RU)
• Flutter version 2.2.0
• Framework revision b22742018b (3 weeks ago), 2021-05-14 19:12:57 -0700
• Engine revision a9d88a4d18
• Dart version 2.13.0
[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
• Platform android-S, build-tools 30.0.2
• Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6916264)
• All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS
• Xcode at /Applications/Xcode.app/Contents/Developer
• Xcode 12.4, Build version 12D4e
• CocoaPods version 1.10.1

The bug arises after upgrade to Flutter 2.2. It was OK with Flutter 2.0. I will be publishing an update soon for Flutter 2.2.

published pdf_viewer_jk-2.1.3.. Please upgrade.


Synchronization of "development" branches between ESMValTool and ESMValTool-private

Are there plans to sync the branches?
My problem is - I would like to start developing diagnostic in the private repository (ESMValTool-private), but I need features already added to "development" branch of the public one (ESMValTool). I can re-implement the features in the private branch, but it's kind of ugly.
Ping @mattiarighi

Yes, I think it makes sense to keep the "master" and "development" branches of ESMValTool synchronized at all times.
This would mean every pull request to either branches in either repo's would need to be followed up with a git pull-push synchronize step. Perhaps we should make a script.

Agree, only point is that we need to ensure that also the devbranch is a running version.
But that's what is envisaged anyway.

The possible problem is that private and public repositories are not linked in github, at least I can not make PR to one from another. Maybe I don't have enough rights.

don't know how to do it via github, But one can easily sync in principle
by having two "remotes" locally and sync there and then push to each of
repos again.
On 6/26/17 1:17 PM, Nikolay Koldunov wrote:

The possible problem is that private and public repositories are not
linked in github, at least I can not make PR to one from another.
Maybe I don't have enough rights.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/ESMValGroup/ESMValTool/issues/71#issuecomment-311031182,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACt0Cy-zcuZvAqTZ7iUUfwE8x3zI7CQJks5sH5MygaJpZM4OFIzp.

Yes, this is an unfortunate side effect of the workaround we used to get two copies of the same repo into one GitHub organization with different public/private settings: as far as GitHub is concerned, these two repo's are not related in any way.
@bulli92 is right in that on the command line it is fine.
I discussed this with @bjoernbroetz before (actually before the github was setup). I guess we should write that down somewhere :-)

Can someone then, please, take an action on this?

@mattiarighi @axel-lauer @bjoernbroetz @veyring
can you please comment on this. I think we need some general agreement and responsibility assignment.
But first we would need to agree on the overall procedure to always keep the masters and dev's in sync. Do you agree with such an approach?

The master / development branches have been synchronized (September 1, 2017).
For the future, we developed and tested a set of instructions for the core development team how to synchronize the master and development branches in the different repositories. Currently, the synchronization has to be done by hand. The current strategy is that synchronization is done as soon as one of the master or development branches is modified (in any of the repositories). The core team member performing the updates of the master / development branch would be the primary person responsible for synchronizing the branches / repositories. The instructions are available for discussion and further refinement here on the wiki.


Get rid of CoinInputAdvanced component

in favour of BigNumberInput component (will be introduced with https://github.com/thorchain/asgardex-electron/pull/397)

Resolved by #401


DepthImage flickering in rerun 0.18

Describe the bug

The depthimage logged in rerun 0.18 may become inconsistent between frames. It looks like flickering. The same behavior does not exist in 0.17. I feel like it could be related to the background rrd file compression?
To Reproduce
Steps to reproduce the behavior:

compile and run code in https://github.com/makeecat/Peng
you will see depthimage flickering in the logged data
The rerun related code is https://github.com/makeecat/Peng/blob/a936a9dd47ecde4719b268004082aa0d06eba670/src/main.rs#L1276

Desktop (please complete the following information):

OS: macOS, Ubuntu 22.04 (x64)

Rerun version
0.18.0

Can you please elaborate - inconsistent how? Do you have some screenshots or video you can add?
You're using an 8-bit buffer for the depth image - this will cause severe quantizing. You can use a full f32 instead:
-    let depth_image_buffer: image::GrayImage =
-        image::ImageBuffer::from_fn(width as u32, height as u32, |x, y| {
-            let depth = depth_image[y as usize * width + x as usize];
-            if depth.is_infinite() {
-                image::Luma([0u8])
-            } else {
-                let normalized_depth = (depth - min_depth) / (max_depth - min_depth);
-                image::Luma([(normalized_depth * 255.0) as u8])
-            }
-        });
+    let depth_image_buffer = ndarray::Array::from_iter(depth_image.iter().cloned())
+        .into_shape((height, width))
+        .unwrap();

with
ndarray = "0.15"

in your Cargo.toml

I will try to use f32 or u16 illustrated in https://rerun.io/docs/reference/types/archetypes/depth_image. I am using u8 since that is the only way I can work with related to https://github.com/rerun-io/rerun/issues/7134
Here is the flickering video:

It could be related to https://github.com/rerun-io/rerun/issues/6106

Yes, I think this is just  #6106 aggravated by using u8 instead of f32


Rename get_points_count() to get_point_count() in Gradient

It's already exposed to users as get_point_count() but internally we use get_points_count(). But "point count" is grammatically correct, so this is just confusing and longer.

Thanks!


Correct wasm failing validation

        thread 'evm::wasm::tests::suicide_not' panicked at 'Interpreter to execute without any errors: Wasm("Runtime error:
Interpreter(Validation(\"Expected block to return NoResult while it has returned Some(Specific(I32))\"))")', src/libcore/res
ult.rs:859

https://github.com/paritytech/wasm-tests/blob/master/compiled/suicidal.wasm

Also there is no way to find out what function is invalid

Oh with this fix is better,
but this one still fails with the same error:
https://github.com/paritytech/wasm-tests/blob/master/compiled/logger.wasm

fail was unrelated to the validator


scrollToElement:Center in horizontal scroll not working.

I want to center element to screen.
I do this myScroll.scrollToElement(document.querySelector('#scroller li:nth-child(25)'), null, null, true)
it's working in vertical scroll but not working in horizontal scroll.

if you are using iscroll 5,
the param is (el, time, offsetX, offsetY, easing)
you apparently set offsetX to null and offsetY to true
thus, your final offset will be offsetX=0 offsetY=center.
which means your target will be at center on y axis and at left side on x axis.
according to https://github.com/cubiq/iscroll/blob/master/src/core.js#L508

@TotooriaHyperion 谢谢，我试试


unzipped size must be smaller - large next project

recieved this error when trying to deploy
112s » nextApp » InvalidParameterValueException: Unzipped size must be smaller than 262144000 bytes

Sorry for the late reply @jschimmoeller .
Here is my idea to solve this problem:
1 - Create a separate cache behaviour for /api requests.
This allows separating the deployment packages for /api pages and standard pages. API pages would have 50MB zipped up and standard pages another 50MB.
2 - If the above is not enough, we can detect this and create more granular cache behaviours with their own lambda function associations. For example, in your app 2 more cache behaviours could be created for series/ and watching/. Again this frees up some space in the main Lambda allowing for bigger apps.
I'm not very sure about 2. as it adds a lot of complexity to the project but 1. certainly makes a lot of sense.

@danielcondemarin
My api directory as it is right now is 90mb.  The series and watch folder are dynamic routes which together are only 17mb.  The remaining pages are 147mb.
Based on your input above I would need to be able to setup multiple "cache behavior" in order to get around what appears to be the 50MB limit.
thanks
james

@jschimmoeller Are those numbers after zipping up?

@danielcondemarin sorry but no that is just based on the directory /files sizes
i used 7-zip and here are my values:
api folder - 16.6mb zipped
remaining pages - 31.2mb zipped
so based on your original reply it would be under 50mb
thanks
James

@jschimmoeller Just published 1.2.0-alpha.0 which should address this issue.
I've added the api/* cache behaviour for api pages. Also, fixed an issue where HTML static pages where getting put in the lambda@edge src producing bigger packages unnecessarily.
Let me know how it goes and feel free to re-open if you encounter any problems 👍

@danielcondemarin just updated package.json and did a deploy was able to deploy it 👍   I am currently tracking down a 500 :( I hope it is on my end

@danielcondemarin just updated package.json and did a deploy was able to deploy it 👍 I am currently tracking down a 500 :( I hope it is on my end

Good stuff! Let me know if it isn't :)


sorpaas: retain at rank III

Closing in reference to https://polkadot.subsquare.io/referenda/1070 .


Add another space to src_files list in jasmine.yml

Very minor change, but when adding a new item to the list my text editor
seems to get confused by the single space here.

:+1: weird typo. I won't cut a release over it but it'll just come in whenever the next is

Landed in 0.11.0


Rejecting conflicting field paths

Second attempt for https://github.com/GoogleCloudPlatform/google-cloud-java/pull/2582
This is the same PR, but I removed the clashing isPrefixOf.

This LGTM but wasn't #2582 already merged? Was it reverted or something?

This LGTM but wasn't #2582 already merged? Was it reverted or something?

Yeah, I had to revert it because it broke the google-cloud-java build.


honour sketch mode after execute

Nice quality of life fix (all of these kinds of bugs are so much easier to solve with XState 🎉 because its so easy to figure out where the solution needs to go in the diagram)
Implemented a on-execute call back that triggers an XState action so that we can put the engine back into edit/sketch mode for the new ids that are generated from a fresh execute
https://github.com/KittyCAD/modeling-app/assets/29681384/868c6609-d912-444f-a2a7-d8f855e8dfac
@franknoirot one thing I'm curious about is I had to add the same event with the same three actions in three places for sketchId, line tool and move tool, because the event needs to be available in all three of these states. I think that's the correct way to do that but not 100% sure?

Dope, yeah would be sick to get some advice from the pros.
A quick expansion of why the "re-execute" event might trigger different actions later on, basically here the re-execute actions here are responsible for putting the engine back into sketch mode after new ids have come through from the execution because we're in the sketch state. But later if we re-execute while in some other state (that hasn't been created yet) then we might need to get to send different commands to the engine.


Code Review

What this PR does
This PR is meant for code review

Changes Unknown when pulling 74fb711566180d661a4d63ff55c7d7d8bc384581 on staging into ** on master**.

Changes Unknown when pulling 5aabb749dca3d32b5ccc2ff2ed962aaf6c60163d on staging into ** on master**.

Changes Unknown when pulling 3017b10b6cfc242b32687f811942eb67ac82b883 on staging into ** on master**.

Changes Unknown when pulling d8fdcfd7ad1a4e4ae76506d683e165dfb87b9eda on staging into ** on master**.