Request collaboration on krafix for Metal

Hi Rob...
Wonderful architecture! Quite succinct and easy to expand.
We're using krafix as part of MetalVK, a larger project to run Vulkan on top of Metal on iOS & OS X. Metal support in krafix is a great start, and we've made a number of changes to add enhancements, as in the attached pull request. We've tried to keep the changes as non-disruptive as possible, but since we're only interest in Metal, none of these changes have been tested against the other krafix translators.
Our main Metal conversion is handled in a subclass of MetalTranslator, but which is not part of this repo yet. The reason we chose to do that is because our approach was not easily compatible with the MetalTranslator. In our subclass, we use stage-in attributes instead of vertex indexes, need to handle larger shaders with multiple functions, and pass in structures to map descriptor set bindings to Metal resource indices.
Anyway, I thought we'd offer to contribute what makes sense. With that in mind, what are your future plans for Metal support? Is that something we could contribute to directly? If Metal is not something that you've got significant investment in, we do, so perhaps we could work out a way for us to contribute what we can to that segment.
I'd also like to discuss design approaches to other issues. In the past month, we added Member support as first-class objects. In doing the most recent merge, I see you've added Members now, but with a different approach. Perhaps we could discuss options there. We need to be able to handle decorations, etc, hence our design choice. In addition, we need to add better Function support. For some reason, SPIR-V encodes functions in reverse order, relative to how they have to be spit out. Something to discuss from a design perspective.
Thanks...
...Bill

I've separated out the proprietary code from our MetalTranslator subclass and I've added a new MetalStageInTranslator class to this repo, which contains all of the Metal features we added that are not connected in some way to our particular internal use. The components that are unique to our environment have now been moved to a custom subclass of MetalStageInTranslator in our own environment. I'll try keep any further generic enhancements in the MetalStageInTranslator class.

Thanks a lot for that! Will check and merge everything ASAP and will prepare everything I consider relevant to discuss.

OK, it's all merged. We discussed function support. Is there anything left to discuss about member support? It looks fine to me.

Great!
Thanks for taking the time to review it all and roll it into your code base.
Looks good so far from a manual review. I’ll find some time tomorrow to test it all out at my end.
Your change to use Type references looks like a good move, too!
Thanks..
…Bill

On Feb 4, 2016, at 8:49 AM, Robert Konrad<EMAIL_ADDRESS>wrote:
OK, it's all merged. We discussed function support. Is there anything left to discuss about member support? It looks fine to me.
—
Reply to this email directly or view it on GitHub https://github.com/KTXSoftware/krafix/pull/3#issuecomment-179848589.


Update README with task board

SolidOS tasks needs an update.

Done also with PR: https://github.com/SolidOS/solidos/pull/158


Two sliding button issue resolved in the index.js

Successfully fixed the issue of two sliding button in the first carousel of the page.
Please review this and merge my PR

Please verify this and merge my PR


Modifications in local procedure InsertShipmentLine in codeunit 80 "Sales-Post"

Dear AL Development Team
When creating a new sales shipment line in codeunit 80 "Sales-Post", we need to perform some calculations and update several customized fields that we have created in table Sales Header. In order to achive this, we need two modifications in local procedure InsertShipmentLine:

We need that the parameter SalesHeader in local procedure InsertShipmentLine  is declared by reference:
OLD CODE:
local procedure InsertShipmentLine(SalesHeader: Record "Sales Header"; SalesShptHeader: Record "Sales Shipment Header"; SalesLine: Record "Sales Line"; CostBaseAmount: Decimal; var TempServiceItem2: Record "Service Item" temporary; var TempServiceItemComp2: Record "Service Item Component" temporary)
NEW CODE:
local procedure InsertShipmentLine(var SalesHeader: Record "Sales Header"; SalesShptHeader: Record "Sales Shipment Header"; SalesLine: Record "Sales Line"; CostBaseAmount: Decimal; var TempServiceItem2: Record "Service Item" temporary; var TempServiceItemComp2: Record "Service Item Component" temporary)
Related to this issue, we also need that parameter SalesHeader in the event publisher OnBeforeInsertShipmentLine in this same procedure is declared by reference too:
OLD CODE:
[IntegrationEvent(false, false)]
local procedure OnBeforeInsertShipmentLine(SalesHeader: Record "Sales Header"; SalesLine: Record "Sales Line"; var IsHandled: Boolean)
begin
end;
NEW CODE:
[IntegrationEvent(false, false)]
local procedure OnBeforeInsertShipmentLine(var SalesHeader: Record "Sales Header"; SalesLine: Record "Sales Line"; var IsHandled: Boolean)
begin
end;
Thanks in advance!

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 13351.


chore: clippy & fix

cargo clippy fix
Add clippy workflow ci
Add Makefile

LGTM.  @ibmp33 @cyl19970726 @JangoCCC @BC-A @0x1900matrix, plz review too.

LGTM. Respect to your work.


Update to openjdk8 to openjdk8-openj9 for the scala base image to dea…

…l with vulnerabilities
Description
Update to openjdk8 to openjdk8-openj9 for the scala base image to deal with vulnerabilities
Updating the image in the Dockerfile will also update the Controller and Invoker.
Related issue and scope

[ ] I opened an issue to propose and discuss this change (#????)

My changes affect the following components

[ ] API
[x] Controller
[ ] Message Bus (e.g., Kafka)
[ ] Loadbalancer
[x] Invoker
[ ] Intrinsic actions (e.g., sequences, conductors)
[ ] Data stores (e.g., CouchDB)
[ ] Tests
[ ] Deployment
[ ] CLI
[ ] General tooling
[ ] Documentation

Types of changes

[ ] Bug fix (generally a non-breaking change which closes an issue).
[x] Enhancement or new feature (adds new functionality).
[ ] Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

[x] I signed an Apache CLA.
[x] I reviewed the style guides and followed the recommendations (Travis CI will check :).
[ ] I added tests to cover my changes.
[ ] My changes require further changes to the documentation.
[ ] I updated the documentation where necessary.

PG2-4376

Could please summarize the performance impact if any of making this change in the PR.

Closing as outdated.


Added post-processing module for c++ inference

Hi, guys. Recently, I have been working on developing C++ routines for Wenet. I have completed the development work, and the accuracy is aligned with your Python examples. This C++ post-processing module is based on Slyne's work, and it mainly involves some interface refactoring. This means that you no longer need to recompile third-party libraries like fst and KenLM when using these post-processing interfaces. Additionally, I have provided some utility functions, such as ctc_decoding and file reading functions. By the way, I am also developing a speech pre-processing module based on Armadillo, which is mainly used to extract fbank or mfcc features from WAV files. The reason for this is that Kaldi has too many dependencies, which is not very user-friendly for C++ users. I will gradually improve this module, and it will be open-sourced soon. I hope these are useful to you.

@robin1001 @yuekaizhang


removed unused re import

Thanks for your commit Ali! Could you change this to merge to develop branch?

@bcoltin thanks for reply! I have created pull request on develop!

Thank you!!!


Undeclared configure_requires dependency Pod::Readme

Please see https://rt.cpan.org/Ticket/Display.html?id=129131

Resolved in version 5.67


 doesn't work

When typing 2 strings, and putting each on a new line using Enter. Instead of rendering a BR it will render each in a separate span (including empty span)

Discovered softBreak="br". That works.
Does it make "Softbreak" and "Hardbreak" in allowedTypes obsolete?

Hi and thanks for the report,
No, a soft break is usually treated as just a hint, while a hardbreak is always treated as an explicit linebreak. A hardbreak can be achieved by having two or more spaces at the end of a line, followed by a newline character. This is according to the markdown "standard".
The softbreak option is included because many people find the default behavior of newlines confusing, and depending on what you are building, this might make more sense in your case.


Major folder restructure and fixing minor design issues

Fixed issues #95 and #96
Site looks cleaner and website assets are easier to manage due to new organisation

Hi, I've fixed merge conflicts. Please mark this as hacktoberfest-accepted and if you like it changes, merge it to master.
😄

Sorry, I have finally fixed all conflicts and the PR can now be merged. Please add the hacktoberfest-accpeted label. Thanks!


[2D] Group follow mode is biased towards first target when multiple targets are present

Issue description
When two nodes (and probably more) are present in the Follow Targets variable of a PhantomCamera2D with a Follow Mode set to Group, the camera will be biased towards the first target

Steps to reproduce

Add a PhantomCamera2D
Set the Follow Mode to Group
Add the two (or mode) nodes to Follow Targets
Swap the order of the nodes to better see the bias

(Optional) Minimal reproduction project
No response

After a bit of digging, it looks like the bias is due to setting the follow_position to rect.get_center() which is created around the first target. To be perfectly centered, follow_position should be set to the mean of every target position

Refactored a fair bit for the 0.8, so the initial issue you shared seems to have already been resolved a little while ago.
But spotted that it was still occurring when auto zoom was enabled when doing some repro tests, which should now be resolved as well.
Thanks for calling attention to this!


Add types

It'd be nice to have types for this module to use it within a typescript project!
I started on a boilerplate, if anyone else wants to see it through
declare module "electron-promise-ipc" {
	export type Listener = (...dataArgs: any, event?: IpcMessageEvent) => void
	export type Options = { maxTimeoutMs: number }
	export class PromiseIpcBase {
		constructor(opts?: Options, eventEmitter: IpcRenderer | IpcMain)
		public send(route: string, sender: WebContents | IpcRenderer, ...dataArgs: any): Promise<void>
		public on(route: string, listener: Listener): WebContents | IpcRenderer
		public off(route: string, listener: Listener): void
		public removeListener(route: string, listener: Listener): void
	}

	export class PromiseIpcMain extends PromiseIpcBase {
		constructor(opts?: Options)

		// Send requires webContents -- see http://electron.atom.io/docs/api/ipc-main/
		public send(route: string, webContents: WebContents, ...dataArgs: any): Promise<void>
	}

	export class PromiseIpcRenderer extends PromiseIpcBase {
		constructor(opts?: Options)
		public send(route: string, ...dataArgs: any): Promise<void>
	}
}

This sounds cool!
If it's alright with you I'd like to work to finish this!

Yes please! I’d be happy to accept a PR to add types. Love TypeScript.
On Sun, Oct 20, 2019 at 9:29 PM Jacob Shuman<EMAIL_ADDRESS>wrote:

This sounds cool!
If it's alright with you I'd like to work to finish this!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/sibnerian/electron-promise-ipc/issues/15?email_source=notifications&email_token=AAW3BRFMAAVA6FB2URWGA5TQPUAYLA5CNFSM4JCSXWGKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBYZTII#issuecomment-544315809,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAW3BRANFER6REW3DMTZJ43QPUAYLANCNFSM4JCSXWGA
.

Yes please! I’d be happy to accept a PR to add types. Love TypeScript.
…

Awesome! I really appreciate the response, would it be alright if I added ts annotations to this project as well?

Hell yeah, you can refactor the whole thing to TypeScript if you want :)
On Mon, Oct 21, 2019 at 3:00 PM Jacob Shuman<EMAIL_ADDRESS>wrote:

Yes please! I’d be happy to accept a PR to add types. Love TypeScript.
… <#m_-4112703290123829085_>
Awesome! I really appreciate the response, would it be alright if I added
ts annotations to this project as well?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/sibnerian/electron-promise-ipc/issues/15?email_source=notifications&email_token=AAW3BRB36V2XYP7PVSG5F23QPX33XA5CNFSM4JCSXWGKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEB3NI4Y#issuecomment-544658547,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAW3BRGUBDZAE77GFOWFBD3QPX33XANCNFSM4JCSXWGA
.


Source code mirror shared service

TBD

Make sure git LFS works.

This needs to be able to support a mix of both public and private sources.

@iankelly-github when you ay private, do you mean "private repos on GitHub" or private as in "repos on a private internal network"?

This may overlap with https://github.com/microsoft/AzureTRE/issues/21 - lets see if we can meet both needs with a single solution.

Hi Marcus, Sorry for the delayed reply. By 'private' I meant 'confidential', only accessible to those that have a need.

As described in #40 , we'll most likely use Gitea for Git mirroring


Fetch Istio CRDs from Istio version specified in go.mod (#318)

Previously, the version of Istio CRDs was determined by the crdSourceVersion field in versions.yaml. This change ensures that Istio CRDs are now pulled directly from the istio.io/istio version specified in the go.mod file.

@luksa: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_sail-operator_release-0.1
01eb44181fd5b90abe0875f53109d94c4732716c
link
true
/test gencheck

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@luksa: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_sail-operator_release-0.1
1ad1a69ddca4c823f0b4c52cb847ee395a6ecb8a
link
true
/test gencheck

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.


kube-up.sh fails on non-default network with GCE

When changing the NETWORK to anything other than the default, the cluster will not launch using kube-up.sh on GCE.
Receive this error:
Creating minions.
./../cluster/gce/util.sh: line 504: @: unbound variable
Attempt 1 to create kube-minion-template
Created [https://www.googleapis.com/compute/v1/projects/***/global/instanceTemplates/kube-minion-template].
NAME                 MACHINE_TYPE  PREEMPTIBLE CREATION_TIMESTAMP
kube-minion-template n1-standard-2             2015-08-02T14:04:32.743-07:00
Traceback (most recent call last):
File "/Users/ccc/google-cloud-sdk/./lib/googlecloudsdk/gcloud/gcloud.py", line 193, in main
_cli.Execute()
File "/Users/ccc/google-cloud-sdk/./lib/googlecloudsdk/calliope/cli.py", line 548, in Execute
result = args.cmd_func(cli=self, args=args)
File "/Users/ccc/google-cloud-sdk/./lib/googlecloudsdk/calliope/backend.py", line 1102, in Run
result = command_instance.Run(args)
File "/Users/ccc/google-cloud-sdk/./lib/googlecloudsdk/preview/commands/managed_instance_groups/create.py", line 105, in Run
body=new_group)
File "/Users/ccc/google-cloud-sdk/./lib/apiclient/discovery.py", line 669, in method
cast_value = _cast(value, to_type)
File "/Users/ccc/google-cloud-sdk/./lib/apiclient/discovery.py", line 310, in _cast
return str(int(value))
ValueError: invalid literal for int() with base 10: '8ye'
If you would like to report this issue, please run the following command:
gcloud feedback
Waiting for minions to run. 0 out of 8ye running. Retrying.
ERROR: (gcloud.preview.instance-groups.instances.list) ResponseError: code=404, message=The resource 'https://www.googleapis.com/resourceviews/v1beta2/projects/***/zones/us-central1-b/resourceViews/kube-minion-group' was not found.
The nodes will not be configured correctly or able to communicate with each other.  I've seen similar issues with GKE and non-default networks.
Everything works fine with using the default network though.

we use the 'e2e' network for end to end testing, so I know it works at least for a network named 'e2e'...
can you send the contents of your config-default.sh?
My guess is that there is some sort of problem in your shell script.
Thanks

Upgraded to 1.0.2 and the issue seems to be gone now.
Still see this error however:
./../cluster/gce/util.sh: line 504: @: unbound variable
This is from running kube-up.sh on a fresh download of 1.0.2 after changing config-default.sh like this:
#!/bin/bash
Copyright 2014 The Kubernetes Authors All rights reserved.

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
TODO(jbeda): Provide a way to override project
gcloud multiplexing for shared GCE/GKE tests.
GCLOUD=gcloud
ZONE=${KUBE_GCE_ZONE:-us-central1-c}
MASTER_SIZE=${MASTER_SIZE:-n1-standard-1}
MINION_SIZE=${MINION_SIZE:-n1-standard-2}
NUM_MINIONS=${NUM_MINIONS:-8}
MASTER_DISK_TYPE=pd-ssd
MASTER_DISK_SIZE=${MASTER_DISK_SIZE:-20GB}
MINION_DISK_TYPE=pd-ssd
MINION_DISK_SIZE=${MINION_DISK_SIZE:-200GB}
OS_DISTRIBUTION=${KUBE_OS_DISTRIBUTION:-debian}
MASTER_IMAGE=${KUBE_GCE_MASTER_IMAGE:-container-vm-v20150715}
MASTER_IMAGE_PROJECT=${KUBE_GCE_MASTER_PROJECT:-google-containers}
MINION_IMAGE=${KUBE_GCE_MINION_IMAGE:-container-vm-v20150715}
MINION_IMAGE_PROJECT=${KUBE_GCE_MINION_PROJECT:-google-containers}
CONTAINER_RUNTIME=${KUBE_CONTAINER_RUNTIME:-docker}
RKT_VERSION=${KUBE_RKT_VERSION:-0.5.5}
NETWORK=${KUBE_GCE_NETWORK:-prodnet}
INSTANCE_PREFIX="${KUBE_GCE_INSTANCE_PREFIX:-kbr}"
MASTER_NAME="${INSTANCE_PREFIX}-master"
MASTER_TAG="${INSTANCE_PREFIX}-master"
MINION_TAG="${INSTANCE_PREFIX}-minion"
MASTER_IP_RANGE="${MASTER_IP_RANGE:-<IP_ADDRESS>/24}"
CLUSTER_IP_RANGE="${CLUSTER_IP_RANGE:-<IP_ADDRESS>/16}"
MINION_SCOPES=("storage-ro" "compute-rw" "https://www.googleapis.com/auth/monitoring" "https://www.googleapis.com/auth/logging.write")
Increase the sleep interval value if concerned about API rate limits. 3, in seconds, is the default.
POLL_SLEEP_INTERVAL=3
SERVICE_CLUSTER_IP_RANGE="<IP_ADDRESS>/16"  # formerly PORTAL_NET
ALLOCATE_NODE_CIDRS=true
Optional: Cluster monitoring to setup as part of the cluster bring up:
none           - No cluster monitoring setup
influxdb       - Heapster, InfluxDB, and Grafana
google         - Heapster, Google Cloud Monitoring, and Google Cloud Logging
googleinfluxdb - Enable influxdb and google (except GCM)
standalone     - Heapster only. Metrics available via Heapster REST API.
ENABLE_CLUSTER_MONITORING="${KUBE_ENABLE_CLUSTER_MONITORING:-google}"
Optional: Enable node logging.
ENABLE_NODE_LOGGING="${KUBE_ENABLE_NODE_LOGGING:-true}"
LOGGING_DESTINATION="${KUBE_LOGGING_DESTINATION:-gcp}" # options: elasticsearch, gcp
Optional: When set to true, Elasticsearch and Kibana will be setup as part of the cluster bring up.
ENABLE_CLUSTER_LOGGING="${KUBE_ENABLE_CLUSTER_LOGGING:-true}"
ELASTICSEARCH_LOGGING_REPLICAS=1
Optional: Don't require https for registries in our local RFC1918 network
if [[ ${KUBE_ENABLE_INSECURE_REGISTRY:-false} == "true" ]]; then
EXTRA_DOCKER_OPTS="--insecure-registry <IP_ADDRESS>/8"
fi
Optional: Install cluster DNS.
ENABLE_CLUSTER_DNS=true
DNS_SERVER_IP="<IP_ADDRESS>"
DNS_DOMAIN="cluster.local"
DNS_REPLICAS=1
Admission Controllers to invoke prior to persisting objects in cluster
ADMISSION_CONTROL=NamespaceLifecycle,NamespaceExists,LimitRanger,SecurityContextDeny,ServiceAccount,ResourceQuota
Optional: if set to true kube-up will automatically check for existing resources and clean them up.
KUBE_UP_AUTOMATIC_CLEANUP=${KUBE_UP_AUTOMATIC_CLEANUP:-false}

We’re going through old support issues and asking everyone to direct your questions to stackoverflow.
We are trying to consolidate the channels to which questions for help/support are posted so that we can improve our efficiency in responding to your requests, and to make it easier for you to find answers to frequently asked questions and how to address common use cases.
We regularly see messages posted in multiple forums, with the full response thread only in one place or, worse, spread across multiple forums. Also, the large volume of support issues on github is making it difficult for us to use issues to identify real bugs.
The Kubernetes team scans stackoverflow on a regular basis, and will try to ensure your questions don't go unanswered.


environment:branch to create an inactive environment?

Hi @pjcdawkins - For reasons I won't explain, I'd kind of need environment:branch to be able to create an inactive environment. Is this something the API behind the command supports?

@vincenzo Simply branch a plain git branch and push it. With environment:info you can fix the parent, and it's inactive by default.

@patkar Thanks! It was the "fix the parent" bit that I was missing. Cheers.

When using the workaround environment:info parent <name> it doesn't seem to copy the users and permissions of the parent branch. Is this an option that can be added in the future?

Just to bump this as I've hit this issue today using GitHub Actions to push a PR to platform.
I want to be able to create an environment, activate it and push my PR to Platform using the Platform CLI:
platform environment:branch "${PLATFORM_BRANCH}" "${PARENT}"

platform push --force --activate --parent "${PARENT}" --target "${PLATFORM_BRANCH}"

My problem here though is that platform environment:branch checks out a new branch. I need to be able to create a new environment (branching off a parent) without checking out a new git branch. I also don't want to use git directly, since I don't want to mess about with SSH keys in GitHub Actions (The CLI is much nicer with a single token secret).
So to me here there are a couple of ways to solve this:

Add a new flag to platform push to branch a new environment (which requires --parent).
Add a new flag to platform environment:branch which forces the CLI not to checkout a new git branch locally.
Make it possible to git push using a CLI token rather than SSH keypair (sounds like a bit job, not recommended).

So to me this issue needs bumping to provide this new functionality.


Array transformations

This is a super easy question, I'm just confirming to make sure I'm not screwing up
a = np.random.randint(0,10,(2,2,2))
If I generate a random 2x2x2 cube with dataset
[[[2 6]
 [1 9]]
[[7 9]
 [2 6]]]

When I flatten it to produce dataset
[2 6 1 9 7 9 2 6]
Is the histogram I'm producing supposed to have 1 one, 2 twos, 2 sixes, 1 seven, 2 nines?

yes.


Add Theory of Everything 2 [Piano Cover] by PNG - Music

Song Name
Theory of Everything 2 [Piano Cover]
Artist Name
PNG - Music
Source
Youtube
Youtube Link
xvkBphyhvf4
Direct File Link
No response
Song ID
17
Start Offset [ms]
4750
Extra
Created from Auto Nong.
Created for level: 77239599
Downloaded: Yes

This submission is stale because it has been open for 14 days with no activity. If it is still relevant, please leave a comment and we will reopen it.

ok

accept


fix: send interpreted variants to clin

This PR should send interpreted variants to clin.

quarantest build successful. Demo link at
http://a33588bd.quarantest.iobio.io


Included EM tests to test rolling update deployment

Included EM tests to test rolling update deployment

Closing as this is stale. Re-open if needed.


Replace fake-smtp-server with smtp4dev

I found out that the fake-smtp-server did not work at all in local dev mode with docker compose. The Dapr SMTP Binding always requires a TLS connection and I wasn't able to get it working.
I thus replaced it with [smtp4dev], a .NET-based SMTP server which generates a self-signed certificate automatically if needed.
I also added a sign-up command to the AdminCLI in this PR. This way, we can perform the following commands with it:
./AdminCli products list
./AdminCli products sign-up -e<EMAIL_ADDRESS>-p a028d630-2da8-432d-ad8c-b4990d288841 -t 9.5
./AdminCli products drop-price -p a028d630-2da8-432d-ad8c-b4990d288841 -d 0.2

Furthermore, the price watcher service and the products service now use the same products. I created a migration that inserts products with the appropriate ID. A single transaction now spans a migration.

The Helm charts for fake-smtp still need to be updated.


[Bug] Responsive Desgin Bugs

Hand Pointer should occur when hovering over the links in socials section.

Sign in/Sing up buttons not aligned properly on smaller screens.

I can fix these issues.

I haven't added the links for twitter and youtube

Yeah there are a lot of issues with mobile responsiveness so please fix them..

I haven't added the links for twitter and youtube

Yes, but you haven't even created the boilerplate for them. Never mind, i will fix them. Just assign appropriate labels onto them.

I would like to work on this issue under hacktoberfest, please assign it to me

Hey!

Hey! I want to work on this issue under Hacktoberfest please assign it to me.

@Sidd2024 I have made a PR #24  for this issue, please look into it and verify it.


Removed user from group should no longer update

After a user is removed from a group the group should no longer update for them.

Working as expected but good to add a test. See documentation here: https://openmls.tech/book/user_manual/remove_members.html


Typo in CLI code for deployment section

Currently the CLI code is the following:
`
az group create --name arm-vscode --location eastus
az deployment group create --resource-group arm-vscode --template-file azuredeploy.json --parameters azuredeploy.parameters.json
`
The second line is incorrect. The keywords 'deployment' and 'group' have been accidentally swapped in their order, and the command will not work as shown.   Given the context of creating a group to use first, and then using the --resource-group flag on the second line, it is clear that the intent is to do:
az group deployment create ...

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 01f23d33-97df-a48c-1f45-81baa9ea5e00
Version Independent ID: d6f768af-4b97-828f-970e-e79d31d0e285
Content: Create template - Visual Studio Code - Azure Resource Manager
Content Source: articles/azure-resource-manager/templates/quickstart-create-templates-use-visual-studio-code.md
Service: azure-resource-manager
Sub-service: templates
GitHub Login: @neilpeterson
Microsoft Alias: nepeters

@trailstrider - Thanks again for bringing this to our attention. We have updated the Doc and it will be live once its merged.  We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


Go definition doesn work

A couple of questions first

Your IDE/editor (e.g. vscode, emacs,...) you use with verible LSP ? vscode
IDE version: 1-65-1
What other SystemVerilog plugins are active alongside ? None

What activity failed
(what functionality did not work as expected (e.g. Linting, Formatting, AUTO-expansion, go-to-definition, outline, hover,...)
Go to Definition
Expectation
What actually happened
The Go To Definition function doesn't work not for module instances not for  IO ports.
Test case
If needed, include SystemVerilog sample file(s) that show the code you want to do an operation on
module InstModule (
    o,
    i
);
  output [31:0] o;
  input i;
  wire [31:0] o = {32{i}};
endmodule

module ExampInst (
    o,
    i
);

  output o;
  input i;

  InstModule instName (  /*AUTOINST*/);

endmodule

Logfiles
If you invoke your editor with the environment variable VERIBLE_LOGTHRESHOLD set to 0, then useful log information will
be generated that you can include here
export VERIBLE_LOGTHRESHOLD=0
code foo.sv

How to see the log output

vscode: go to View -> Output, then choose Verible Language Server in the dropdown
emacs: there is a buffer *verible-ls::stderr* that contains the log output
kate: output is printed on the terminal

(paste log output here)

CC @tgorochowik

Alex, did you have a verible.filelist ? This could be #1647 (which is already fixed after the release version).
At least for the module.
The IO ports might be a separate issue. Will hand over to Grzegorz to determine.

I am taking a look at it

I didn't use verible.filelist.

The issue is being resolved in PR #1678 - I will provide the current status there

Acknowledging that my initial implementation (~2 years ago) did not support this style of ports.


typo: Double word "the"

@nschonni : Thanks for your contribution! The author(s) have been notified to review your proposed change. @ashannon7

@chbain looks like the metadata still lists a former employee, but I don't know who that should be changed to

Verified the updates; merging.
@deepakpalled - Could you update the author metadata value to a current authorized GitHub user, such as yourself? Thanks.


regress-sv_sv_wildcard_import4_iv

Surelog issue: https://github.com/chipsalliance/Surelog/issues/2551

Issue fixed.


Add GA4 tracking id

Add the Google Analytics 4 tracking id

@chochihim Please merge to main and prod


Integration Test - Release - 2019/03/28 01:46:30

Auto create for integration test. IssueCommandFlow

@PRMergerTest3 : Thanks for your contribution! The author, @v-caxian, has been notified to review your proposed change.


Update to version 5.0

Checklist

[x] Used a fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Close #10, #11, #12, #13

I just updated to version to 5.0 as https://github.com/sloria/sphinx-issues/issues/162 broke sphinx for me.

@conda-forge-admin, please rerender

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@conda-forge-admin, please restart ci

@asmeurer this is ready for review

@conda-forge-admin, please rerender

@conda-forge/core This feedstock is quite outdated and the recipe maintainers do not respond. @zaneselvans & me are offering help as recipe maintainers (and I already added us to the recipe). We are asking for a review and merge here.


THRIFT-5794: Add tests

Based on Thrift5794 I worked on improving CI-testing for netstd. As sideeffect I found, that the thrift-exe is not found on windows, which is fixed by commit

"make MSBuild ignore errors when thrift-binary is not found and continue search"
"include .exe extension, when looking for compiler"

To address Thrift5794 this PR  switches to use default C# languagelevel for the Thrift.PublicInterfaces.Compile.Tests  (dropping "net8" option from calling the compiler). To keep testing with "net8 / C#12" a 2nd project Thrift.PublicInterfaces.Compile-C#12.Tests is added, which keeps using the "net8" option.
The Thrift-files are shared between both projects, to reduce amount of duplicated code.

Alternative ways I tried/had in mind:

generating code for all language-levels inside one project (generate to different folders inside the project): will not work, as it causes double definitions of generated symbols
having the test-job changing the code to run for all language-levels: feels ugly and hard to follow. Github tests can for sure do this way, but might be pain when testing locally. (something like "for {default|net6|net8} in LANG: sed /var/$LANG/ *.cssproj")

When using these changes it turns out that the netstd-test failing after removing the "net8" option from calling the compiler
I can see this when runnig localy and a also in GithubActions (using #2998)
Test run for /home/runner/work/thrift/thrift/lib/netstd/Tests/Thrift.Tests/bin/Debug/net8.0/Thrift.Tests.dll (.NETCoreApp,Version=v8.0)
Microsoft (R) Test Execution Command Line Tool Version 17.10.0 (x64)
Copyright (c) Microsoft Corporation.  All rights reserved.

Starting test execution, please wait...
A total of 1 test files matched the specified pattern.
  Failed Test_Complex_DeepCopy [16 ms]
  Error Message:
   Assert.IsNotNull failed.
  Stack Trace:
     at Thrift.Tests.DataModel.DeepCopyTests.InitializeInstance(RaceDetails instance, Int32 nesting) in /home/runner/work/thrift/thrift/lib/netstd/Tests/Thrift.Tests/DataModel/DeepCopy.cs:line [90](https://github.com/SvenRoederer/thrift/actions/runs/9959985460/job/27518257532#step:10:91)
   at Thrift.Tests.DataModel.DeepCopyTests.Test_Complex_DeepCopy() in /home/runner/work/thrift/thrift/lib/netstd/Tests/Thrift.Tests/DataModel/DeepCopy.cs:line 36
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)

Failed!  - Failed:     1, Passed:    30, Skipped:     0, Total:    31, Duration: 113 ms - Thrift.Tests.dll (net8.0)

I'm not that deep in C# and test-code at all, to debug this/fix. Maybe this fail should become a new Issue (to be treated by anyone with the power/access to Jira).

The idea was not to rewrite the whole thing. The net8 option is very deliberately placed there.

To keep testing with "net8 / C#12"

I occasionally think about making the last release the default (currently net8) and putting older versions under a suffix instead. But especially for netstd 2 this would be sort of awkward.

The idea was not to rewrite the whole thing.

I initially started with a separate thrift-file for that case (https://github.com/apache/thrift/pull/2993/commits/f7cda292175673fef3c00052e99040a754719208, https://github.com/apache/thrift/pull/2993/commits/4f252f4a0a272d6f751aaa5f109acb1f385f842d), but realized that the Thrift-5794 also applies to the existing sourcefiles. For that reason I came up with that "large change" version. Idea behind it was to use default compiler option in favor of specific ones. And use explicit options only where needed (like the net8/C#12 tests-folder).
I'm aware, that this solution adds more files that need to be maintained, slightly increases complexity but also gives some better test-coverage.
As both version for the test are around for review and @Jens-G prefers the "separate tests-file" version for the project, I'm fine. For that reason I made small commits to allow cherry-picking. I hope you was able to make use of it for PR #3000.

The net8 option is very deliberately placed there.

Is that the reason, which causes the "Test_Complex_DeepCopy" to fail with non net8/net6?

I occasionally think about making the last release the default (currently net8) ...

C#12 by default would break our (legacy) project and we would need to have a "legacy" option when compiling.
But even with net8 by default and other levels as option, a test will be needed, which goes back to above "separate tests-files vs. same tests for all language-levels".

The net8 option is very deliberately placed there.

Idea behind it was to use default compiler option in favor of specific ones.

Both net6 and net8 are not simply some arbitrary compiler options. These directly affect some important settings and assumptions, e.g. how to treat nullable references to name just one. You cannot simply switch those options blindly and hope all will be fine. The options should match the target environment or you will indeed "find errors" that don't exist.

Is that the reason, which causes the "Test_Complex_DeepCopy" to fail with non net8/net6?

I'd propose to compare the generated code for each option and/or looking at the code generator.

For that reason I came up with that "large change" version [...] use explicit options only where needed (like the net8/C#12 tests-folder).

I'm fine with adding tests. I'm not fine with "improving" working tests to the point where there are broken.
We encourage to contribute patches, but everybody should be aware that - like in any other FOSS project - patches will be reviewed, change-requested, modified and occasionally this involves many hours of back and forth until it gets finally accepted (or rejected). Some patches get accepted, some debated, some rejected. That's how it works. As a rule of thumb, smaller and more concise patches generally have a better chance of getting through - simply because review is easier.

[...] would need to have a "legacy" option [...]

Exactly what I meant by "awkward".

I'm aware of the principle of code-changes for open projects. There is a change-idea, that gets written down and discussed by project members.
I wrote my change-idea ("use existing test-cases for more language-levels, instead of adding another test-file") as code, that looked working to me and proposed up for discussion.  As I had the code changes ready it was easy for me to publish them via this PR and to have something to look at, that just discussing on a pure idea of how to change things. If the change does not fit the projects intention, then it is this way ...

I'd propose to compare the generated code for each option and/or looking at the code generator.

From this comment I see, that it's not surprising that the "Test_Complex_DeepCopy" will fail when not using net8. As @Jens-G is more deep in the project and code, I'm fine with this and consider this seen test-fail as "Works as designed".


General: Message SignBytes

We should switch to using the standard msg.GetSignBytes() instead of having to come up with the sign bytes in each module's IxoSignAndBroadcast() function when signing and then setting it (as one of the fields SignBytes in the message) in the DefaultTxDecoder when a message is processed by the blockchain.
Applying this change would mean that we use a standard Cosmos-SDK approach, improve security, and reduce extra code (i.e. the SignBytes field in each message and the custom code for coming up with the sign bytes).

This has been tackled in 9cc7094 and will be closed by #106

Note: in 888e2a8, GetSignBytes functions were changed to use json.Marshal instead of the codec's MarshalJSON. This had to be done because other ixo tools, such as ixo-module.

Closed by #106


Add minimum page skeleton template

What’s the smallest-possible page template to make the styleguide work? CSS include, mobile-friendly meta tags, script tags, container div?
Provide or link it at the top of the styleguide.

Something like this. https://gist.github.com/louh/9b1113c88b4fe82fb61e

Yes, something like that.

(ideally a little slimmer, but yes0

Should it be visible from http://precog.mapzen.com/mapzen/styleguide/master/ ? I also think the boilerplate and the how-to are the same thing, not different.

I really like rizzo has done this. Something we had talked about yesterday, the idea of layout boilerplates. http://rizzo.lonelyplanet.com/documentation/page-layout/core-layouts
It feels weird to embed it in a page, I think we should just link it from the how-to section and put the code in a  tag maybe?

Embedding in a page will allow us to describe it, and will implicitly limit its complexity. Let’s definitely embed it as we talked about earlier this morning.


script to restart node if not synced

Thank you for contributing to Mina! Please see CONTRIBUTING.md if you haven't
yet. In that doc, there are more details around how to start our CI.
Explain your changes here.
Explain how you tested your changes here.
Checklist:

[ ] Document code purpose, how to use it

Mention expected invariants, implicit constraints

[ ] Tests were added for the new behavior

Document test purpose, significance of failures
Test names should reflect their purpose

[ ] All tests pass (CI will check this if you didn't)
[ ] Serialized types are in stable-versioned modules
[ ] Does this close issues? List them:

Closes #0000
Closes #0000

This PR is rebase on master instead (see #8164)


Name filter edit box is unlabeled and extra unlabeled focus is provided for the filter dialog

Clarity Version: 3.1.1
WCAG 2.1 Guideline: 4.1.2: Name, role, value
Test Environment:

Test URL: https://clarity.design/documentation/datagrid/
OS: Windows 10
User Agents/Assistive Technologies: Firefox 76.0
Screen reader: NVDA 2020.1

Steps to reproduce:

Open the test URL.
Navigate to any one of the datagrids with filter options.
Press any one of the filter buttons and navigate through the filter dialog.

Expected result:
User should be able to navigate through the filter dialog with appropriate announcement while navigating through the content.
Actual result:

Unlabeled edit box is encountered in the filter popup.
Overall dialog is focused and announced as section. Note: The popup window behaves like a dialog but it's not announced as dialog to the screen reader user.

I have noticed the same.
On a voice over reader, the input field is read as "edit text blank."

The entire div does not have a role name associated with it, which can confuse the user as what the pop-up does.


Builed failed server returned nothing no headers no data

C:\Program Files (x86)\vcpkg>vcpkg install openssl
The following packages will be built and installed:
openssl[core]:x86-windows

openssl-windows[core]:x86-windows
Additional packages (*) will be modified to complete this operation.
Starting package 1/2: openssl-windows:x86-windows
Building package openssl-windows[core]:x86-windows...
-- Using cached C:/Program Files (x86)/vcpkg/downloads/openssl-1.0.2q.tar.gz
-- Using source at C:/Program Files (x86)/vcpkg/buildtrees/openssl-windows/src/openssl-1-4adeeb536f
-- Downloading http://download.qt.io/official_releases/jom/jom_1_1_3.zip...
-- Downloading http://download.qt.io/official_releases/jom/jom_1_1_3.zip... Failed. Status: 52;"Server returned nothing (no headers, no data)"
CMake Error at scripts/cmake/vcpkg_download_distfile.cmake:172 (message):
Failed to download file.
If you use a proxy, please set the HTTPS_PROXY and HTTP_PROXY environment
variables to "https://user:password@your-proxy-ip-address:port/".
Otherwise, please submit an issue at https://github.com/Microsoft/vcpkg/issues

Call Stack (most recent call first):
scripts/cmake/vcpkg_find_acquire_program.cmake:262 (vcpkg_download_distfile)
ports/openssl-windows/portfile.cmake:41 (vcpkg_find_acquire_program)
scripts/ports.cmake:73 (include)
Error: Building package openssl-windows:x86-windows failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with .\vcpkg update, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
Package: openssl-windows:x86-windows
Vcpkg version: 2019.06.21-nohash
Additionally, attach any relevant sections from the log files above.

It's working for me now. Would you try again?

Still not working. I think if send https request it will work, as I opened the link manualy but can't open with http could tell where the link is placed so I can change it to https

In scripts\cmake\vcpkg_find_acquire_program.cmake.

Thanks it worked
On Mon, Jul 1, 2019, 9:05 PM cskrisz<EMAIL_ADDRESS>wrote:

In scripts\cmake\vcpkg_find_acquire_program.cmake.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/vcpkg/issues/7113?email_source=notifications&email_token=AH5XE6JVTD5D4PKYUFJDCETP5ITKZA5CNFSM4H4SZWQKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODY6TILQ#issuecomment-507327534,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AH5XE6IV42BDM7MZTAAK5SLP5ITKZANCNFSM4H4SZWQA
.

Thanks for posting this issue. This issue has been fixed. So I am closing this issue for now.


[BUG] Password length visible in sign-in page

Describe the bug
Currently in the sign-in page, the length of the password is shown
It is not good for security reasons
Expected behavior
It should only tell invalid password
Screenshots

Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

@Gauravtb2253
I dont think this is a bug for me... try creating any other issue

@Gauravtb2253
you can start working


refactor!: move transaction error out of block payload

closes #5001

move transaction error out of block payload
increase type safety of block lifecycles

Context
since transaction error is not part of the block hash or protected by the block signature it's better to move it outside of block payload to avoid confusion. I didn't go that far in this PR, but I think it would be ok to keep this information in the state instead of inside a block. This could be explored in future work

blocked by #5140


WIP Add param used flag.

When parameter arrays are processed by a receiver, it is currently unknown
if the parameters could be processed or not.  This adds a used flag that
is set when a param is located.  The caller can check this to see what was
consumed.

[x] documentation is added or updated
[x] tests are added or updated

The use case is for parameters the receiver doesn't know about.  The caller can now know if they were used or not.  #9500 raised this.
I agree that a missing critical parameter should raise an error.

Shouldn't functions like OSSL_PARAM_get_int set this flag automatically?

Shouldn't functions like OSSL_PARAM_get_int set this flag automatically?

The locate does currently.
Should the get's do as well?  I'm happy to add such.

I've made the get calls set the used flag too.

Thinking about it, the set param calls might want to set the used flag too.  This allows the information to flow the other way and avoids problems when the returned string size is zero.

You do realise that OSSL_PARAM can never be const at this point, right?

(I.e this PR is incomplete and should probably be marked WIP)

You do realise that OSSL_PARAM can never be const at this point, right?

I thought that this assumption had died with the mutable return size change.
But yes, I did realise this.
I can see one potential use for const OSSL_PARAM arrays.  If we do need it, this suggested change cannot go in.  I'm fine with that but we'll still need a way to address the problems #9500 raised and how to create backward compatible ctrl functions (which do check for unknown parameters and return error when they are found).  I've also found zero instances in the code thus far but will check more deeply next week -- I ran out of time today for unrelated reasons.
I need to go through the sources for for() loops that strcmp param names still, but the only build failures as a result of this were test cases that initialised the OSSL_PARAM structure directly.

Argh, the get params call are passed a const OSSL_PARAM object :(  Hence the Travis failures.

The loss of constness means that there's no promise the receiver won't change anything in a OSSL_PARAM array. This worries me constantly.
Another solution would be to have a separate array of bits that the receiver would set for any used parameter, which would be at the caller's option to pass, or not. They would work like an FD_SET in a select() call. A consequence for this is that we need a param locator that returns an index rather than a pointer...

I do not like the array of bits approach, it requires exposing more publicly.  I avoided using bit fields for similar reasons even though they would simplify the structure.  None of this is speed or space critical.  Let's make it easy for the users.
If the receiver does update other fields in the OSSL_PARAM structure they can expect a crash upon a version change.  I have zero problems with this so long as the mutability assumptions are properly documented (which they are currently).  This is a cooperative arrangement between the provider and the core.
It we really do want to stop providers from changing other fields, we can make them const.  It will cost a few casts in the params.c code but I'd be quite happy to implement this.  However, I thought the idea was for the caller/owner to point to their variables and a provider changing the pointers would then be ignored.

That last paragraph makes a good point.

@levitte, which point?  That providers are cooperating or that the fields can be const.

Sorry, I meant last sentence

However, I thought the idea was for the caller/owner to point to their variables and a provider changing the pointers would then be ignored.

Okay, thanks.  I suspected that it was that one BTW.

Which is preferred:

back out the param get change or
make param get calls not accept a const argument?

I don't understand the question.  This will typically be useful in calls like EVP_MD_CTX_set_params(), so the caller can check which of the parameters it sent in where actually used, yes?  That means the OSSL_PARAM needs to be writable, i.e. signatures like this:
int EVP_MD_CTX_set_params(EVP_MD_CTX *ctx, const OSSL_PARAM params[]);

will have to change to this:
int EVP_MD_CTX_set_params(EVP_MD_CTX *ctx, OSSL_PARAM params[]);

By consequense, OSSL_PARAM_get_int() etc will have to be changed to take a non-const OSSL_PARAM as well.

That answers the question: remove the const.

That answers the question: remove the const.

There was never a question, that is the consequence of this PR, there's no way around that.

Okay, I see what you mean.
I've pushed a commit that removes the const OSSL_PARAM where necessary.
The big question now is does this adequately address the concerns in #9500 (and possible future concerns along similar lines) and is it less evil than the alternatives?

BTW, something I just remembered is that we already have a set of functions that can be used to achieve the intent of this PR; if the providers actually implement the get_param_types / set_param_types kind of calls, the returned constant OSSL_PARAM arrays can be used to check what parameters the implementation handles. In other words, instead of flagging "I used this", the provider must declare "I will use this" in advance.
I prefer that, actually. Could we explore that first? (I'm tempted to -1 here to force that exploration)

I prefer that, actually. Could we explore that first? (I'm tempted to -1 here to force that exploration)

Not quite sure I understand how this applies to individual algorithms. Setting the key len (or ivlen) for example could apply to just a small subset of the algorithms )and the ones that dont handle it can be treated generically), How does get_param_types really apply to this?

Not quite sure I understand how this applies to individual algorithms. Setting the key len (or ivlen) for example could apply to just a small subset of the algorithms )and the ones that dont handle it can be treated generically), How does get_param_types really apply to this?

Just like all other functions we're dispatching, the {get,set}_param_types functions are defined per implementation (or more generic and re-used by many implementations, but that doesn't change the principal granularity).
{get,set}_param_types are supposed to return a constant OSSL_PARAM array as a description of what the {get,set}_params functions in the same implementation can handle, right?  So for example, let's take the AES-GCM vs AES-whateverelse case that was recently hit.  You can't set the key length with AES-GCM, but you can with AES-whateverelse.  So that would mean that for AES-GCM, the cipher dispatch function OP_cipher_ctx_set_param_types (which I realise doesn't exist yet) should return this array:
{ { OSSL_CIPHER_PARAM_AEAD_TAG, OSSL_PARAM_OCTET_STRING, NULL, 0, 0 },
  { OSSL_CIPHER_PARAM_AEAD_IVLEN, OSSL_PARAM_INTEGER, NULL, sizeof(size_t), 0 },
  { OSSL_CIPHER_PARAM_AEAD_TLS1_AAD, OSSL_PARAM_OCTET_STRING, NULL, 0, 0 },
  { OSSL_CIPHER_PARAM_AEAD_TLS1_IV_FIXED, OSSL_PARAM_OCTET_STRING, NULL, 0, 0 },
  { NULL, 0, NULL, 0, 0 } }

While for AES-whateverelse, it would return this:
{ { OSSL_CIPHER_PARAM_PADDING, OSSL_PARAM_INTEGER, NULL, sizeof(int), 0 },
  { OSSL_CIPHER_PARAM_NUM, OSSL_PARAM_INTEGER, NULL, sizeof(int), 0 },
  { OSSL_CIPHER_PARAM_KEYLEN, OSSL_PARAM_INTEGER, NULL, sizeof(int), 0 },
  { NULL, 0, NULL, 0, 0 } }

That makes it entirely visible what parameters are handled where and in what function.  My idea is that any {get,set}_params dispatched function should have a matching {get,set}_param_types (or whatever name...  basically, any dispatched function 'foo' that handles an array of OSSL_PARAM should have a matching 'foo_types' dispatched function that returns a descriptor like the above) dispatched function that returns a descriptor array, and that array would be useful for anyone who wants to check that a particular parameter they want to pass to an implementation is actually handled by said implementation.  In other words, instead of asking "was this used", we can as well ask "will this be used".
Having just looked at provider-digest(7) and provider-cipher(7), I see some serious lack of {get,set}_param_types dispatched functions.  That's unfortunate, but shouldn't be too hard to add.  provider-keymgmt(7) has a few of them, but I now see that it's also a bit incomplete.  And the providers are seriously lacking in this regard (side note: I have been a bit more diligent with the MAC sstuff, see #8877)

The only downside to the _param_types functions is string comparisons are forced to see if a parameter is acceptable.  Not a big issue since OSSL_PARAM shouldn't be performance relevant.
I'm fine with trying an alternative before this :)

Another overnight thought was to split the data_type field like I've done here (unsigned short, 2 x unsigned char) even if this PR goes nowhere.  Then use the other char as a OSSL_PARAM version.  This permits unknown future changes to the structure in a forward compatible manner.
I'll note that I'm not expecting any changes and can't think why we'd need or want to but better to be prepared IMHO.
I'd suggest bit fields but I'm not sure how nicely they play with ABI compatibility.

So if a new set param id is needed for a single algorithm, would you need to add it to every single algorithm? (This woudl not be good, especially if there are potential 3rd party providers).

@levitte you won't know what combination of things you might use until you work through it. A provider that supports a wide range of things dynamically may not be able to answer anything until such time as it is actually trying to use something.
Answering what was used is useful. Answering what might be used isn't really.

So if a new set param id is needed for a single algorithm, would you need to add it to every single algorithm?

I assume we're talking implementations of the same algorithm here. Well, depends, right? Have we suddenly required that the ctx_set_params in every GCM implementation in the wild must handle the "keylen" parameter? In that perspective, is it really that bad do have another function returning a descriptor array declaring this?
@t-j-h, yes and no. We can declare what a {get,set}_params can handle at all, i.e all the keys they have any knowledge of. If a combination of parameters actually passed is bad, or any parameter known to the provider is bad in a given situation, then {get,set}_params should be able to detect that and signal an error. Right?

Basically, what this whole thing comes down to is, what parameters does a provider even look at, no matter how it's used.  The first incantation of this very PR actually wasn't so far off, with the locating functions setting the "used" flag.  That's what the keylen parameter that was mistakenly passed to the AES-GCM implementation was really all about, that there was no way to detect if that parameter is even known to that implementation.
If all parameters passed to a {get,set}_params function are known by that function (i.e. it at least looks for them), then the know that if the call is successful, the parameters were put to good use, and if the call raised an error, then we know that something was wrong, and the error reason and additional data will say the rest.  @t-j-h, doesn't this cover what you're talking about?
However, if some particular {get,set}_params doesn't have knowledge of the parameter "foo", i.e. won't even look for it, there's currently no way for the caller to know if "foo" was involved, i.e. there's uncertainty regarding the result of the call.
So I guess that it comes down to what we want to know:

does a particular {get,set}_params have any knowledge of some parameter "foo", i.e. can we trust that a successful call will have looked at this parameter, or is it just pointless to pass it on?
does a particular {get,set}_params not only have knowledge of some parameter "foo", but used its value?

Me, I'm hearing 1 much more loudly than 2, because 2 is kind of already answered by the outcome of a {get,set}_params call under the condition that I know what parameters it looks at; if successful, then I know that all parameters were good; if an error was raised, the error message should give me knowledge.

I've pushed a version with a read, a write and a lookup flag.
Is this more in line with your thinking @t-j-h ?

I use an language where is normal to send messages with property list. OpensSSL "parameter" functionality is similar.
When message is send is not clear how data is consumed. Message could send another message (nested function call), i.e. could prepare new property list based on supplied data, also it could perform property and value "translation".
When a message need data or data is not consistent it just raises error.
There is no need to ask in advance which property is required as on nested level it may depend from other properties or functionality.
With other words to check sender must have property list. And the question is why to check and the to execute as execution is enough.
Due to nested levels one property could be consumed from many levels and so on - out of scope.
In conclusion I cannot see any rationale to know when I send more then 100 X.509 certificates serialised  as OpenSSL 'parameters' which one is used in validation process.

I am somewhat un-enthusiastic about this solution. The params structure is supposed to be really simple. It is transparent and once we release 3.0 we won't be able to make changes. The more complexity we throw in there the harder that becomes.

@mattcaswell any suggestion on alternative implementations that let us know what's been used?  I'm not attached to this PR but I do think we'd benefit from a solution to the underlying issue.

@mattcaswell any suggestion on alternative implementations that let us know what's been used? I'm not attached to this PR but I do think we'd benefit from a solution to the underlying issue.

Perhaps a simple count of the number of parameters that were processed in the return value would be sufficient.

Perhaps a simple count of the number of parameters that were processed in the return value would be sufficient.

That is fine for controls which just send a single value.. Matt could you see this becoming a problem when we start passing multiple params for keys? If it processed 4 out of 5 of the params, what does that really tell us?

Would it be more acceptable to revert the structure and for params.h to subvert some high order bits in the data_type field?
Pretty much everything is using params.h and we could declare the top bits to be implementation dependent.
Just a thought?

That is fine for controls which just send a single value.. Matt could you see this becoming a problem when we start passing multiple params for keys? If it processed 4 out of 5 of the params, what does that really tell us?

I see no problem with that at all. If the caller considers some params mandatory and others to not be, then just perform two calls. One with all the mandatory params, and one with all the optional params.

Either things are opaque between the caller/provider, or they are not. This is be adding a "peek behind the veil" capability, which is wrong.  It's deliberately making an abstraction leaky.
If a caller wants a provider to do something, then how it does it should be opaque, and it should return an OK/ERROR status, and pushing a status code on the stack.

I see no problem with that at all. If the caller considers some params mandatory and others to not be, then just perform two calls. One with all the mandatory params, and one with all the optional params.

PQC algorithm barfoo takes arguments foo and bar, one is optional.  Which?
One of the points of providers is that the framework doesn't need to know.
Not that this helps here 😢

PQC algorithm barfoo takes arguments foo and bar, one is optional. Which?
One of the points of providers is that the framework doesn't need to know.

Right, the framework doesn't need to know.  But applications have to know, there is no way around it. Saying it can be done with zero knowledge of the semantics is magical thinking.

Since this seems to be unwanted, I'll close it soon if no one offers some support.

I see no problem with that at all. If the caller considers some params mandatory and others to not be, then just perform two calls. One with all the mandatory params, and one with all the optional params.

@mattcaswell  - I had a look into using counters - it looks error prone. Placing count++ into every 'if locate' block inside every get_ctx_params(), set_ctx_params(), get_params() is not ideal.
Having an array of indexes would also be horrible for the caller side.
Wouldnt it just be much simpler to use param capability flags instead - similar to how it was done in the existing legacy code?

I really like what @levitte proposed. It could be very useful for callers to know in advance what is/can be consumed by the provider. For example various scripting frameworks could adjust their behavior accordingly. I do not think the ex-post knowledge of what was used and what not is that much useful - I mean it could be somewhat useful sometimes to verify that what I passed in was really consumed, but given it complicates the simplicity of the OSSL_PARAM I do not think it is worth it.

If this were flipped around and a flag was set when the param value was changed, would it still feel dirty?
We have this capability currently (except for a zero byte octet string, the return size is set non-zero).

A thought I just had is that this is only a set_params (i.e. OSSL_PARAM_get_xxx() calls) issue, yeah?  We want to somehow know what params were actually used, yeah?  Wouldn't it be possible to do the same as we do for the other direction, simply set return_size to the size of the parameter data?

A thought I just had is that this is only a set_params (i.e. OSSL_PARAM_get_xxx() calls) issue, yeah? We want to somehow know what params were actually used, yeah? Wouldn't it be possible to do the same as we do for the other direction, simply set return_size to the size of the parameter data?

So the gets should all return an error if the param isnt found?
I think @paulidale  has suggested something similiar in his PR?

So the gets should all return an error if the param isnt found?

What?  What in what I just wrote gave you the idea I said that?

What? What in what I just wrote gave you the idea I said that?

Err I think I said it :)

We want to somehow know what params were actually used, yeah? Wouldn't it be possible to do the same as we do for the other direction, simply set return_size to the size of the parameter data?

I think that is not that much different from the pill you were having trouble swallowing :)

I think that is not that much different from the pill you were having trouble swallowing :)

Oh hush, you...  :laughing:
I think that part of that pill was how OSSL_PARAM changed an became increasingly complex.
The rest of it...  well, we do already set return_size in one direction, I find doing the same in the other direction a much easier pill to swallow, even though I'll mourn the disappearing const

Was the pill blue or red?

Heh...

Please don't re-use fields. Burn a flag byte.

I'd prefer adding a flag but adding a field to the structure seems to be causing friction.
What I could do is rename return_size to used_size (accessed_size, size or whatever) and set it both in get and set calls.

The parameter stuff is already so complicated that there are multiple/competing PR's to make it easier to create/use/maintain them. And there is friction about adding a byte? People prefer to re-use a field in hacky ways?
I hope the team reconsiders.

Closing this since it isn't sufficiently wanted.
I still think the underlying problem hasn't been well addressed.

I still think the underlying problem hasn't been well addressed.

Agreed


Anyone tested this module with the latest 9.3.2 DNN  version?

Hi, just upgraded to 9.3.2 - and when I try to update the reportsmodule it fails during installation. Seems like it cannot extract resources.zip - is this due to the breaking changes in 9.2 in regards to new assembliname on the zip lib that is used? Or have I stumbeled upon another error in DNN 9.3.2?
https://www.dnnsoftware.com/community-blog/cid/155518/dnn-920-and-sharpziplib-breaking-change
Thanks for any help!
//Audun

I just installed Reports 6.1.0 on a clean DNN 9.3.2 installation.
The installation was normal, with errors.
I installed the module on an empty page.
I didn't try to configure the module, but it did install just fine.

DNNReports should work without problems in DNN932


BUG-87001 make sure that "loginusername" column does not contain null…

… values

good point @akanto but is this an existing scenario ?

  Cause: org.postgresql.util.PSQLException: ERROR: null value in column "loginusername" violates not-null constraint
Detail: Failing row contains (2, null, null, null, 1073).%                                       ~/prj/cbd-test $ cbr


Sentence pair classification?

I’ve perused the examples, which are fantastic, but I’m curious: Would it be possible to extend this approach to sentence pair classification?

Yes, definitely, in our paper, we do evaluate on sentence pair classification using the MTEB benchmark. Unfortunately, we don't have an example file for that at the moment. Feel free to start a PR if you are interested in contributing.

Looking forward to it :)
Feel free to re-open the issue if you have any more questions


feat: support async writer (#1269)

Which issue does this PR close?

Closes #1269.
Rationale for this change
Currently, async api for arrow writer has not been supported yet. And if the underlying storage's api is async, it is difficult to use the arrow writer api, and a workaround way is to collect all the bytes in memory and then feed them to the underlying storage by the async api, which may lead to high memory consumption if the final parquet file is large.
So we need an async api for the arrow writer, allowing that the caller can integrate an async underlying storage easily, e.g object store.

What changes are included in this PR?

Implement the async arrow writer based on the sync arrow writer.
The inner buffer of the async arrow writer can be configured with an option called buffer_flush_threshold to allow the caller can control the memory usage.

Are there any user-facing changes?
Async api for Arrow writer: AsyncArrowWriter.

@tustvold PTAL

The ci is broken, I will fix them.


[BUG] AutoLogin doesn't work with microsoft

Describe the bug
If you login using microsoft, autologin doesn't relogin to a microsoft account.
Logs
No logs.
Environment

OS: Windows 11
CmlLib.Core Version: 3.3.5
.NET version: .NET Framework 4.7.2

Additional context
I don't know.

did you intend to close this?

Yes I did because I found the issue.


prepare_working_table Performance Investigation

The plpgsql function prepare_working_table copies all potential data for navigation within a region into a temporary table for further filtering. Investigate if more (or all) pre-filtering can be done to limit the number of rows processed with each navigation request.

Put additional performance enhancements into new issues for the WQP Site Context milestone.

Resolved, prepare_working_table is no longer used


Port to MSVC with CMake script

This PR aims to make it possible to build SILE on Windows. The building script is written in CMake. Dependencies are fetched and built in the building process. The PR would resolve #410 and workaround #82 (by avoiding using MinGW).
Steps towards merging:

[ ] Fix any CI build errors, especially making sure the PR doesn't break Linux build.
[ ] Merge libtexpdf from https://github.com/simoncozens/libtexpdf/pull/6 .
[ ] Change .gitmodules to point libtexpdf to master branch in https://github.com/simoncozens/libtexpdf .
[ ] Create an Azure Pipeline CI build by duplicating this one, to build upon every new PR and every new commit in master. (maybe @simoncozens need to do this?)
[ ] Replace the build badge in README.md.
[ ] Merge this PR.

Coverage remained the same at 92.392% when pulling e254447ce3ab349edbd872cb0857840d1c4689d7 on harrysummer:win32 into 4b5e3ca75a0abf94d13b86076c51b3c01ee6f470 on simoncozens:master.

Hey @harrysummer I'm really glad to see this contribution coming through. I haven't used Windows myself in over a decade now, but it will make a difference to the ecosystem and open this up to more use cases.
Can I suggest we do a bit of rebase work with this branch? I understand it's been a work in progress, but it's hard to even review and will certainly make a mess in the history if merged as is. For example there are nearly a dozen bumps to the submodule version. This will make any future work with git bisect trying to track down issues a nightmare. One submodule bump commit early on in the branch should be fine, all the rest can be made fixup commits of that one.
I'd be happy to help with this. In fact since this is a PR I can even do some of that work real quick myself if it's okay with you that I muck around in this branch.

@alerque Do you mean squash-and-merge? I think GitHub has that feature when you are to merge a PR if want a clean history. I'm also fine if you want me to do the squash rebase if that makes code review easier.

No I don't think this should all get squashed into one commit at merge time, having some granular history to follow how it came together is a good thing. I just think the history needs a bit of cleanup using rebase (which yes, can squash related commits into one, etc.). The idea isn't to flatten the whole thing, just to clean up the artifacts a bit.

OK. I think I can handle with reorganizing this PR. If you think it's good, I will put the changes into 4 commits:

Modification of the original code for Win32 compatibility.
CMakeLists.txt and libtexpdf bump
Patches of dependencies
CI build script

For libtexpdf, there will two commits:

Modificatoin of the code.
CMakeLists.txt

That would certainly work. I was thinking even less drastic than that. For example I just did a rebase on your branch and stuck it on my fork that cleans of the commit messages, squashes a couple of redundant things, etc. If you like I can push that branch in place of the one this PR is based on as a starting point.
Some further changes will probably be necessary. In particular the submodule commits might need revisiting before merging, but...

Commit clean done.

I will have a look at this soon.
One question: we have half an appveyor CI build on Windows set up already, but obviously I never got it working. Would it be easier to work with that rather than Azure Pipeline? (I know very little about either.)

I was going to mention, if this PR sticks to Azure it should also add a commit that nukes the Appveyor bits.

Would it be easier to work with that rather than Azure Pipeline? (I know very little about either.)

I never used Appveyor before but it looks to me Appveyor is queuing a long time before it starts to build. On the other hand, Azure Pipeline is way faster. I think this is currently the main benefit to use Azure Pipeline. In the future, I am positive that Azure Pipeline will get even better integration with Microsoft's GitHub.
It is just a few clicks to set all things up. I am here to help if you need anything. One thing that could possibly be missing is setting up pull request as a triggering condition. We can add that later after CI is setup.

OK, I have signed up for Azure pipeline and associated a Github trigger with this repository. What I need from you is the "azure-pipelines.yml" file which defines your pipeline (I can't view the details of your pipeline at the URL you mentioned above). You can send me that by mail or attach it here and I'll set it up on my account.

Oh, duh, I just found it in your commits. Never mind. Let me try this.

/AzurePipelines run

I've merged most of this into devel, and added the azure pipeline YAML file into master. Let's see what that does.

Great! I also updated the commit (removed my temporary build script and updated build badge) so that the Azure Pipeline CI is building on this PR too.

Looks like the devel branch build failed because cmake/fonts_conf.cmake is missing.

Clean the commits again. I think it's ready to merge after the CI build passes.

Excellent, thank you so much!

(Found this issue from the link in the README.md)
What is the status of the build on Windows?  I've tried to run it with the latest VisualStudio, which includes CMake.  Here's my output.  I'd be happy to help with this project, I just need a bit of guidance to get started...
build_output.txt


Give airbases in each Vic2 state

Give a small airbase to the capital of each Vic2 state to ensure all countries have coverage. Start with a level 2 base, but maybe increase to 3-4 after testing.
https://forum.paradoxplaza.com/forum/index.php?threads/v2-to-hoi3-converter-mod.582798/page-52#post-21108912
https://forum.paradoxplaza.com/forum/index.php?threads/v2-to-hoi3-converter-mod.582798/page-52#post-21117070
https://forum.paradoxplaza.com/forum/index.php?threads/v2-to-hoi3-converter-mod.582798/page-52#post-21119909

Level two airbases are now provided. We will see if higher-level airbases are needed.


Added missing get_config on select LossFunctionWrappers

Some LossFunctionWrapper implementations were still calling LossFunctionWrapper.get_config rather than Loss.get_config, making deserialization fail. This PR addresses these.
Note the existing test_config tests seem misleadingly named, as they don't test the config returned by get_config.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (1a480f4) 78.97% compared to head (35e9e35) 56.23%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #18765       +/-   ##
===========================================
- Coverage   78.97%   56.23%   -22.74%
===========================================
  Files         336      336
  Lines       34040    34046        +6
  Branches     6668     6668
===========================================
- Hits        26883    19147     -7736
- Misses       5580    13447     +7867
+ Partials     1577     1452      -125

Flag
Coverage Δ

keras
56.23% <100.00%> (-22.63%)
:arrow_down:

keras-jax
?

keras-numpy
56.23% <100.00%> (+<0.01%)
:arrow_up:

keras-tensorflow
?

keras-torch
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files
Coverage Δ

keras/losses/losses.py
92.47% <100.00%> (+0.14%)
:arrow_up:

... and 184 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Questions about body

I am extremely confused by body, and by extension the Request and Response objects in general:

body is type T: Serialize/Deserialize, which it apparently just returns. How is it serializing/deserializing it? Does it only use json?
Is there any way to get or set the "raw body" (i.e. just the string)?

Thanks for the help!

Okay, the docs are maybe helping me a bit:

For example, the body could be Vec, a Stream of byte chunks, or a value that has been deserialized.

So I can specify T: Vec<u8> or T: String (if I expect utf8) and get the raw data right?

The Request and Response types in this crate are generic over any body type, with no bounds requirements. So, you can have Request<String>, Request<Vec<u8>>, Request<ParsedTodo>, etc. You can use body() to get &T, and body_mut() to get &mut T.

but how do you get &T without knowing the format it is serialized in?

If you require a certain type, you can specify (the same with a generic in anything else, like Option<T>, you could require Option<String>), or if you only need certain behavior, you can specify bounds.
fn peek_body_str(req: &Request<String>) {
    println!("request body: {:?}", req.body());
}

fn body_clone<T: Clone>(req: &Request<T>) -> T {
    req.body().clone()
}

But it is assuming JSON encoding for deserialization right?

I'm not sure what you're referring to. This crate does not put any constraints on the body being able to be JSON.

Okay, I see. This crate doesn't actually know how to serialize/deserialize an http request/response at all. It is only for representing those types as rust types.
Thanks!


Updating node version to 16

👋
Github as depricated the use of node12, as explained here så this PR updates the runtime from node12 to node16.

Thanks! I will release a new version


Development documents with another CSS Framework

Is your feature request related to a problem? Please describe.

NES.css doesn't contain layout styles. This puts a burden on developers.
So I think it will be easier to use NES.css with another CSS framework. (e.g. Tailwind CSS, Bulma, Bootstrap, ...)
Describe the solution you'd like

Add development documents using another CSS framework
Example

NES.css with Tailwind css

  <button type="submit" class="nes-btn is-primary">Submit</button>

@BcRikko I'll try to document the integration of the bootstrap grid system with NES.css. Please tell me if something more is needed?

@thisisabhinay Thanks 😆
I want a small and simple sample. For example, the following cards and forms:
with Bootstrap
Card
https://getbootstrap.com/docs/4.3/components/card/

NES.css

NES.css is a NES-style (8bit-like) CSS Framework. NES.css only requires CSS and doesn't depend on any JavaScript.

    Go somewhere

Form
https://getbootstrap.com/docs/4.3/components/forms/
<form class="nes-container">

    Email address
    <input type="email" class="form-control nes-input" id="exampleInputEmail1" aria-describedby="emailHelp" placeholder="Enter email">
    We'll never share your email with anyone else.

    Password
    <input type="password" class="form-control nes-input" id="exampleInputPassword1" placeholder="Password">

    <input type="checkbox" class="form-check-input nes-checkbox">
      Check me out

  <button type="submit" class="nes-btn is-primary">Submit</button>
</form>

Could you add example to Demo page? 🤔
https://github.com/nostalgic-css/NES.css/blob/develop/docs/script.js#L524


add docs section to customize or remove settings panels

Update documentation to include details on how to customize or remove settings panels in the Wagtail CMS. This was originally discussed and requested in #7410

I'm not sure we want to recommend mutations to existing pages, while this will work it may be a bit of a monkey patch solution instead of a real supported solution.
This document page is probably not the right place either as it's a specific workaround for the user management panels and not a generic admin customisation.
Additionally, I'm not sure we are adding type hints in our documentation examples.
I'll let others on the core team add their thoughts though.
Thanks for the PR and it's worth discussing what's the best thing to do here.

Thank you for your PR, @shapiromatron
We've discussed this in the core meeting and mirror @lb-'s thoughts. And we agree that there needs to be a better way on customising the various panels.
Your solution is excellent for post on your blog, if you do have one.
Will close this for now. Thank you again for your contribution.


Resolve path when sending example file for Windows support

[X] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)

Proposed changes
Previously, when trying to import an example into the flow editor on
Windows, the load attempt would fail with an HTTP 404 error in the
browser client, with the following error being written to the Node-RED
log:

TypeError: path must be absolute or specify root to res.sendFile

This was due to the path being passed to the res.sendFile function
not being fully-qualified (for example, \Users\myuser\...\example.json).
With the changes in this commit, the path to the example file is
resolved to a fully-qualified path before being passed into the
res.sendFile call. For example, a path on Windows of
\Users\myuser\...\example.json would be transformed to
C:\\Users\\myuser\\...\example.json before being passed along to the
sendFile function. This change allows the file to be loaded and sent
properly to the browser client and for the embedded flows in the example
to be loaded in the flow editor.
Checklist

[X] I have read the contribution guidelines
[ ] For non-bugfix PRs, I have discussed this change on the mailing list/slack team.
[X] I have run grunt to verify the unit tests pass
[X] I have added suitable unit tests to cover the new/changed functionality

Coverage increased (+0.002%) to 76.232% when pulling 1e8ab36ea74840a6cc2e624b034d6c1d9f961f66 on camlow325:resolve-example-path-for-windows-support into 08fccc4e775121cb4eba2526666e010dd6e85b72 on node-red:master.

@camlow325 thanks for this. I'm slightly surprised this hasn't been reported before - although the library function is a bit clumsy and long overdue a refresh.
@Kazuki-Nakanishi please could I ask you to review this? I don't have a Windows system to verify against.

This happens only the environment that satisfied with the following conditions.

Windows environment that was described at #1281.
Node-RED without the fix of #1281 was executed before.

So only the old Node-RED user can run into this problem :)
I could reproduce this problem and confirmed that this PR solved the problem.

Thanks for testing this PR and linking to the previously filed issue.
I can confirm that if I remove the entire C:\Users\myuser\.node-red directory (the user directory that my Node-RED server was using), update to the latest Node-RED code on the master branch, and start the server again (which recreates the C:\Users\myuser\.node-red directory) that I can no longer reproduce the original problem that I was seeing. The issue appears to not be reproducible either with the USERPROFILE set to C:\Users\myuser or not set at all.
So, it may be then, that the fix on this PR would only be beneficial to those who had been upgrading with configuration files generated using an older Node-RED version. Given that, I would defer to @knolleary as to whether it would seem worthwhile to take this change or not.
Thanks again to you both for taking a look at this!


Allow setting the public_key_url via environmnet variable

/cc @theganyo

Coverage remained the same at 100.0% when pulling 67fc5e7d42862afb3be118aa80f7956813a781a7 on public_key_url_config_env_var into 9720c54b446f508d18656eb6a59b035495ac2fa9 on master.


display images in R

the following code in R should make the image visible, instead of a table of numbers.
library(jpeg)
img <- readJPEG(system.file("img","Rlogo.jpg",package="jpeg"))
img

implemented and merged


File-log plugin cannot write to stdout : Permission denied while logging request,

File log plugin cannot write to stdout : Permission denied while logging
Steps To Reproduce

Install file-log plugin
Set config.path of plugin to /dev/stdout
Make a request
Permission denied while logging request,

Additional Details & Logs

Kong version Kong Enterprise <IP_ADDRESS>
Kong Enterprise
repository: kong-docker-kong-enterprise-edition-docker.bintray.io/kong-enterprise-edition
tag: "<IP_ADDRESS>-alpine"

When file-log is installed and the file path points to /dev/stdout, any logging attempt by the plugin fails with permission denied.
[error] 24#0: *14893 [kong] handler.lua:54 [file-log] failed to open the file: Permission denied while logging request
From the home page of the plugin https://docs.konghq.com/hub/kong-inc/file-log/ :

Append request and response data in JSON format to a log file. You can also specify streams (for example, /dev/stdout and /dev/stderr), which is especially useful when running Kong in Kubernetes.

Looking in container,/dev/stdout has sym link to /proc/self/fd/1, which is owned by root thereby causing permission errors.
lrwx------    1 root     root            64 Jan 28 12:51 /proc/self/fd/1 -> /dev/pts/0

Kong by default runs as the kong or nobody user. You can change the nginx_user config to run it as root, but it is not advised in a production environment.
Alternatively, you can give the kong user access to the /dev/stdout file by using the chmod command.

Closing due to inactivity, feel free to reopen if the issue continues.

I am running Kong on Kubernetes as a docker container, and I want the logs generated by file-log to be shown in the stdout of the docker container. Currently, it is being logged onto a file and not to the container logs, as a result, my default Graylog is not able to scrape those logs easily. Any ideas on how to do this? I went through the file-log official documentation. It says You can also specify streams (for example, /dev/stdout and /dev/stderr), which is especially useful when running Kong in Kubernetes. , but the exact process is not specified. Any help will be highly appreciated. @dndx


Show semester example

Currently just assumed offering string will be of format "..../..../sp16" or something of the sort. I went ahead and made it so anywhere that previously showed a course's display name now shows its display name in addition to the semester of its offering.
Let me know if I should revert it in any of these places or have a less hacky way for me to determine the semester.

Nice!
Some tests are still failing like test_backup (see travis). This is mostly because the test expects something like cs61a but it is getting cs61a (spring 2016) instead.

Okay I'll fix those things up soon! How do I run the tests myself without having to make a pull request?

make test will run tests

I've fixed the issues mentioned (other than the tests). For some reason when I run make test I get the error: make: docker-compose: No such file or directory before running any tests.

LGTM. Thanks!


<Model>CreateManyInput can be empty if the table contains only relations and an ID field, creating GraphQL syntax errors

Prisma Schema:
model PostAuthor {
  uuid String @id @default(uuid())

  userUuid String?
  user     User?   @relation(fields: [userUuid], references: [uuid])

  agentUuid String?
  agent     Agent?  @relation(fields: [agentUuid], references: [uuid])
  Post      Post[]
}

Generated GraphQL:
input PostAuthorCreateManyInput {

}

Workaround is to make a nullable field, I guess? I'm doing this so I can have some sort of way to link different types of models on a same relationship, since Prisma does not currently support that feature. I imagine GraphQL unions get no use because of that, right?

Hey @Tenrys, thanks for reporting the issue. Nothing wrong with your model declaration and the use case for it.
While waiting for a fix, one quick workaround would be to add a temporary field (that isn't of type @id and isn't a relation field). Not super clean, but it should do the trick and allow you to run npx prisma generate without issue. Then you can remove this temporary field after a fix is released.
model PostAuthor {
    // ...
    tmp  String?
}

It's what I did, yeah! Thanks for the quick response, this project looks solid :) Just wish that Prisma itself had a little more support for some more advanced GraphQL / PostgreSQL features, but I'll try to find some workarounds and maybe ask for help if I really get stuck, if that's okay with you.

Fix released in 1.0.0-rc.4.


Add FAQ with version number related questions

A user of raiden-contracts package sees at least four different version numbers.  So I'm asked to add an explanation:  https://github.com/raiden-network/raiden-contracts/issues/584#issuecomment-465130743
[skip ci]

Thanks @pirapira

Hope this helps.


Allow extra headers with default cors headers

Currently, the default CORS Access-Control-Allow-Headers are Allow, Content-Encoding, Content-Length, Content-Type, ETag, Expires, Last-Modified, Location, Server, Vary.
It's very common to also require an Authorization header + any project might use some other headers.
We need to be able to add extra headers or simply override the cors headers.
I've tried creating a global OPTIONS expectation that overrides the default with mine but that did not work ;(
{
  httpRequest: {
    method: 'OPTIONS',
  },
  httpResponse: {
    headers: [
      { name: 'Access-Control-Allow-Origin', values: ['*'] },
      { name: 'Access-Control-Allow-Methods', values: ['DELETE, GET, HEAD, OPTIONS, POST, PUT, PATCH'] },
      { name: 'Access-Control-Allow-Headers', values: ['Allow, Content-Encoding, Content-Length, Content-Type, ETag, Expires, Last-Modified, Location, Server, Vary, Authorization'] },
      { name: 'Access-Control-Expose-Headers', values: ['Allow, Content-Encoding, Content-Length, Content-Type, ETag, Expires, Last-Modified, Location, Server, Vary, Authorization'] },
      { name: 'Access-Control-Max-Age', values: ['300'] },
      { name: 'connection', values: ['close'] },
    ]
  },
}

I have now fixed it so it is easy to override the CORS response by creating an expectation.  The fix will be available in the next release or in the current SNAPSHOT version.
In the meantime you should still be able to override the CORS request with the above expectation if you specify the following System Property -Dmockserver.enableCORSForAPI=false which will disable the default CORS support for the MockServer API.