Operator Reconcile always tried to re-create resource even though have end condition already

Type of question
Hello, i had explore Operator SDK for my study project I want to create resource like Deployment and Service when my customize Kubernetes CR had been created. but some how even though I had condition to check whether resource had been created already or not I always got duplicate loop, Operator tried to create resource again so I got some error like this.
My full code and repository is reside here: https://github.com/wdrdres3qew5ts21/coredns-integration-operator/blob/main/controllers/dns_controller.go
What did you do?

Some of logs here is omit version so number line of code may a little bit different but I always got error like resource already exists
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
	/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.11.0/pkg/internal/controller/controller.go:266
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2
	/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.11.0/pkg/internal/controller/controller.go:227
1.6500445750601559e+09	INFO	setup	DNS Controller: Vanila Log by Supakorn Working
1.650044575060368e+09	INFO	setup	DNS Controller: Escape Error from first error success
1.6500445750605018e+09	INFO	setup	DNS Controller: Before Created DaemonSet
1.6500445750813138e+09	ERROR	setup	DNS Controller: Create DaemonSet Error :(	{"error": "deployments.apps \"private-dns-dns-sample\" already exists"}
github.com/wdrdres3qew5ts21/coredns-integration-operator/controllers.(*DNSReconciler).Reconcile
	/workspace/controllers/dns_controller.go:158
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile
	/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.11.0/pkg/internal/controller/controller.go:114
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler
	/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.11.0/pkg/internal/controller/controller.go:311
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
	/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.11.0/pkg/internal/controller/controller.go:266
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2
	/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.11.0/pkg/internal/controller/controller.go:227
1.6500445750817435e+09	ERROR	controller.dns	Reconciler error	{"reconciler group": "cache.quay.io", "reconciler kind": "DNS", "name": "dns-sample", "namespace": "private-dns", "error": "deployments.apps \"private-dns-dns-sample\" already exists"}
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
	/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.11.0/pkg/internal/controller/controller.go:266
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2
	/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.11.0/pkg/internal/controller/controller.go:227

seem like logic around this err = r.Client.Get(ctx, findMe, foundService) is incorrect because even though I already have resource like Deployment or Service it still try to create again.
had try so many combination but just don't know how to fixed is it related to Operator had deploy as Cluster Scoped ?

You can try to run my Operator with this command
operator-sdk run bundle quay.io/linxianer12/coredns-integration-bundle:0.0.36

here is CR for trigger Operator Manager reconcile resource
apiVersion: cache.quay.io/v1alpha1
kind: DNS
metadata:
  name: dns-sample
  namespace: private-dns

Thank you so much for helping :)

Problem
Operator Manager always error try to create resource again even though already have condition and it cannot reconcile both of resource of Deployment and Service at the same time.
What did you expect to see?
Operator should not tried to create resource again it will cause error because resource already exist.
When Deployment or Service that created by operator had been delete it should come back again from reconcile and SetupWithManager() method

Environment
Operator type:

/language go

Kubernetes cluster type:
Openshift 4.8

$ operator-sdk version

operator-sdk version: "v1.17.0", commit: "704b02a9ba86e85f43edb1b20457859e9eedc6e6", kubernetes version: "v1.21", go version: "go1.17.6", GOOS: "darwin", GOARCH: "amd64"

$ go version (if language is Go)
go version go1.17.2 darwin/amd64

$ kubectl version
Client Version: 4.9.6
Server Version: 4.8.35
Kubernetes Version: v1.21.8+ee73ea2

Additional context

I already found solution ! It cause from err = r.Client.Get(ctx, findMe, foundService) like my assumption due to my resource like Deployment had been re-named to another that was not original CR Instance name so I cannot using instance.Name directly I need to using name that matching name of Resource had been created !
Here is example snippet it might useful for our friend around here :)


Use nodeCache to take place of treeCache.

What is the purpose of the change
use nodeCache to take place of treeCache.

Codecov Report

Merging #7466 (ca1ba21) into master (041f8bb) will decrease coverage by 0.35%.
The diff coverage is 65.85%.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 041f8bb...ca1ba21. Read the comment docs.

LGTM

java.lang.NoSuchMethodError: org.apache.curator.framework.recipes.cache.NodeCache.getListenable

duboo 2.7.10 is ok, update to 2.7.11, error : java.lang.NoSuchMethodError: org.apache.curator.framework.recipes.cache.NodeCache.getListenable()Lorg/apache/curator/framework/listen/ListenerContainer;
java.lang.IllegalStateException: Extension instance (name: registry, class: interface org.apache.dubbo.rpc.Protocol) couldn't be instantiated: null

duboo 2.7.10 is ok, update to 2.7.11, error : java.lang.NoSuchMethodError: org.apache.curator.framework.recipes.cache.NodeCache.getListenable()Lorg/apache/curator/framework/listen/ListenerContainer;
java.lang.IllegalStateException: Extension instance (name: registry, class: interface org.apache.dubbo.rpc.Protocol) couldn't be instantiated: null

Hi, it seems the dependencies conflict, have you solve it? If not , please create an issue to detail descrip it. Put the result by mvn dependency:tree

java.lang.NoSuchMethodError: org.apache.curator.framework.recipes.cache.NodeCache.getListenable

I did an analysis, please see the link below.
https://github.com/apache/dubbo/issues/7772#issuecomment-876466909

What problem does this pr solve? The pr brings some new compatibility issues. Please see https://github.com/apache/dubbo/issues/7772.

What problem does this pr solve? The pr brings some new compatibility issues. Please see #7772.

Hi, we use treeCache to watch all children of / before, If the children's number to much, it may cause out of memory.
So we change the watch way, use nodeCache to watch particular zk node.


Experimental PR: Support pushing the results of benchmarks

PR Checklist

[ ] Tests are added
[ ] Documentation, if applicable

Description
TODO

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@44c4c54). Click here to learn what that means.
Patch has no changes to coverable lines.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #27   +/-   ##
=======================================
  Coverage        ?   33.76%
=======================================
  Files           ?        4
  Lines           ?      231
  Branches        ?        0
=======================================
  Hits            ?       78
  Misses          ?      153
  Partials        ?        0

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


improve file save dialog: handle dirs #3808

this is fix for error handling. But dialog doesn't open browsing folder that user selects in input field . I need more time for improvements current functionality.

NOT READY FOR MERGE

not sure what you mean, will you add the open browsing folder function in the next day or two?

thanks.  the handling for a directory is good.
but now the dialog starts out with both top-level directories open, that's a problem.

:+1:


Add support for Tuples

Feature Description:
It would be useful to allow support for tuples as they allow better readability than using an object array.
For reference of what I'm talking about exactly:
https://learn.microsoft.com/fr-fr/dotnet/csharp/language-reference/builtin-types/value-tuples

I'd like to just append deconstruction onto this request
https://learn.microsoft.com/en-us/dotnet/csharp/fundamentals/functional/deconstruct

User defined value types don't really work in Udon at all currently. It'd just incur a massive overhead any time you attempted to use them because they'd need to fake all of the copy by value behavior and do heap allocations in the process. It's likely you'd see https://learn.microsoft.com/en-us/dotnet/api/system.tuple-2?view=net-7.0 and its other variants first.


vimrun.exe window keeps open alter pressing gx to open an URL.

Instructions: Replace the template text and remove irrelevant text (including this line)
Describe the bug
A clear and concise description of what the bug is.
(Issues related to the runtime files should be reported to their maintainer, check the file header.)
To Reproduce
Detailed steps to reproduce the behavior:

Open a file with URL in it.
Press gx on URL to open it.
vimrun.exe window keeps open and the URL doesn't open until press any key to close the vimrun.exe window.

Screenshots

Environment (please complete the following information):

Vim version gvim for windows 8.1.2006
OS: Windows 10 1903
Terminal: GUI (Use GUI if you use the GUI.)

Have you tried :set guioptions+=!?

I just tried version 8.1.2044 and :set guioptions+=! doesn't work for me.
Also I tried version 8.1.1705 which works fine whether set guioptions+=! or not.

is the netrw version different between both Vim versions?

It seems that netrw updated in Jul 16, 2019.

so I suppose this is the same as #4738

can you check some of the workarounds mentioned in the other issue?

Closing as this is the same as #4738
I checked the workarounds mentioned in the other issue and use open-brower.vim instead for now.


syslog files without a year and leap date Feb. 29 do not revise the guesstimated year

Summary
A syslog file with a log message format without a date does not revise the guesstimated year when it encounters a log message with datestamp on leap year day February 29.
To Reproduce
Use committed log file ./logs/other/tests/dtf9c-23-12x2.log.gz with a Last Modified Time of September 2018. The GZIP encoded datetime is September 2, 2022 9:45:35 PM GMT-07:00 (derived from modified time<PHONE_NUMBER>).
The GZIP encoded datetime is used to place the last log message Dec 12 12:00:00 23; datetimestamp Dec 12 12:00:00 is guesstimated to be year 2022.
During processing, log message Feb 29 02:00:00 1 is encountered. It is given incorrect year 2021.
$ ls -l ./logs/other/tests/dtf9c-23-12x2.log.gz
-rw-r--r-- 1 user user 207 Sep  2  2018 ./logs/other/tests/dtf9c-23-12x2.log.gz

$ gunzip --stdout -k ./logs/other/tests/dtf9c-23-12x2.log.gz
Jan 1 01:00:00 0
Feb 29 02:00:00 1
Mar 3 03:00:00 2
Apr 4 04:00:00 3
May 5 05:00:00 4
Jun 6 06:00:00 5
Jul 7 07:00:00 6
Aug 8 08:00:00 7
Sep 9 09:00:00 8
Oct 10 10:00:00 9
Nov 11 11:00:00 10
Dec 12 12:00:00 11
Jan 1 01:00:00 12
Feb 28 02:00:00 13
Mar 3 03:00:00 14
Apr 4 04:00:00 15
May 5 05:00:00 16
Jun 6 06:00:00 17
Jul 7 07:00:00 18
Aug 8 08:00:00 19
Sep 9 09:00:00 20
Oct 10 10:00:00 21
Nov 11 11:00:00 22
Dec 12 12:00:00 23

The result
$ ./target/release/s4 ./logs/other/tests/dtf9c-23-12x2.log.gz -u
20210101T080000.000+0000:Jan 1 01:00:00 0
20210101T080000.000+0000:Feb 29 02:00:00 1
20210303T100000.000+0000:Mar 3 03:00:00 2
20210404T110000.000+0000:Apr 4 04:00:00 3
20210505T120000.000+0000:May 5 05:00:00 4
20210606T130000.000+0000:Jun 6 06:00:00 5
20210707T140000.000+0000:Jul 7 07:00:00 6
20210808T150000.000+0000:Aug 8 08:00:00 7
20210909T160000.000+0000:Sep 9 09:00:00 8
20211010T170000.000+0000:Oct 10 10:00:00 9
20211111T180000.000+0000:Nov 11 11:00:00 10
20211212T190000.000+0000:Dec 12 12:00:00 11
20220101T080000.000+0000:Jan 1 01:00:00 12
20220228T090000.000+0000:Feb 28 02:00:00 13
20220303T100000.000+0000:Mar 3 03:00:00 14
20220404T110000.000+0000:Apr 4 04:00:00 15
20220505T120000.000+0000:May 5 05:00:00 16
20220606T130000.000+0000:Jun 6 06:00:00 17
20220707T140000.000+0000:Jul 7 07:00:00 18
20220808T150000.000+0000:Aug 8 08:00:00 19
20220909T160000.000+0000:Sep 9 09:00:00 20
20221010T170000.000+0000:Oct 10 10:00:00 21
20221111T180000.000+0000:Nov 11 11:00:00 22
20221212T190000.000+0000:Dec 12 12:00:00 23

Expected
Since the GZIP Modified Time is Sept. 2022, then the last message Dec 12 12:00:00 23 should be given year 2022 (which it currently is). However, upon encountering Feb 29 02:00:00 1 and it is given date 20210101T080000.000+0000 (Jan 1 2021).
Instead, the processing should notice that attempts to create a datetime for that log message failed. It should attempt a leap day valid year, e.g. 2000, and if that succeeds then it can confirm the date is Feb. 29. When datestamp Feb. 29 is confirmed, the processing should revise it's year guesstimate, and then update previously processed log messages.
In this case, during the backwards search for log messages in process_missing_year, it should allow for matching date Feb 29 no matter the guesstimated year.
The revised year guesstimate should result in last message Dec 12 12:00:00 23 given year 2017, and message Feb 29 02:00:00 1 given valid datetime year 2016, i.e. 20160229T080000.000+0000.
$ ./target/release/s4 ./logs/other/tests/dtf9c-23-12x2.log.gz -u
20160101T080000.000+0000:Jan 1 01:00:00 0
20160101T080000.000+0000:Feb 29 02:00:00 1
20160303T100000.000+0000:Mar 3 03:00:00 2
20160404T110000.000+0000:Apr 4 04:00:00 3
20160505T120000.000+0000:May 5 05:00:00 4
20160606T130000.000+0000:Jun 6 06:00:00 5
20160707T140000.000+0000:Jul 7 07:00:00 6
20160808T150000.000+0000:Aug 8 08:00:00 7
20160909T160000.000+0000:Sep 9 09:00:00 8
20161010T170000.000+0000:Oct 10 10:00:00 9
20161111T180000.000+0000:Nov 11 11:00:00 10
20161212T190000.000+0000:Dec 12 12:00:00 11
20170101T080000.000+0000:Jan 1 01:00:00 12
20170228T090000.000+0000:Feb 28 02:00:00 13
20170303T100000.000+0000:Mar 3 03:00:00 14
20170404T110000.000+0000:Apr 4 04:00:00 15
20170505T120000.000+0000:May 5 05:00:00 16
20170606T130000.000+0000:Jun 6 06:00:00 17
20170707T140000.000+0000:Jul 7 07:00:00 18
20170808T150000.000+0000:Aug 8 08:00:00 19
20170909T160000.000+0000:Sep 9 09:00:00 20
20171010T170000.000+0000:Oct 10 10:00:00 21
20171111T180000.000+0000:Nov 11 11:00:00 22
20171212T190000.000+0000:Dec 12 12:00:00 23

Additional context
Found while investigating #189.

I need to confirm that date Feb. 29 is possible under some circumstances, i.e. not invalid for all circumstances.


Edit Flow To Load Reference Data

As an ECMPS user (logged in), I want to update Flow To Load Reference Data so that I can add information to a test
Acceptance Criteria:
Given the user has selected Flow To Load Reference from the Test Type Group dropdown
When the user selects 'Edit' for Flow To Load Reference
Then the system displays the edit modal
And the user can edit Flow To Load Reference data
RATA Test Number (Dropdown)
Operating Level Code (Dropdown)
Average Gross Unit Load (Text)
Average Reference Method Flow (Text)
Reference Flow Load Ratio (Text)
Average Hourly Heat Input Rate (Text)
Reference Gross Heat Rate (Text)
Calculated Separate Reference Indicator (Dropdown - Blank, 1, 0)
Given the user has updated Flow To Load Reference Data
When the user chooses to save and close
Then the data is saved
And the modal closes
And the user is returned to the Landing page for Flow To Load Reference Data
And the updates are reflected in the Flow To Load Reference Data section
Warning message to pop up when a user updates data and closes the modal without saving (Cancel or clicks on X)
Warning message to read: Closing this window will discard any unsaved changes
All fields editable
Reference Invision URL:
https://projects.invisionapp.com/freehand/document/areRdzxWH?zoomToItems=Y2w2ZG45YWJsMDBkcTNiN3BocGZ4b2licg%3D%3D
Testing
Test Case: TC1129
Tester: @mosesdeeCVP

Test Passed


Fix output

Link to JIRA ticket if there is one:
New Features
Breaking Changes
Bug Fixes

Do not print output if a module isn't being deployed.

Improvements
Dependency updates
Deployment changes

atlantis plan


Is there a way to get tooltip with the value when we hover on the slider rail?

You can refer to https://github.com/NightCatSama/vue-slider-component/issues/435
https://jsfiddle.net/4h59ardL/

Hi,
And is it possible to show the tooltip only when hovering on the custom steps? And not on each point of the slider?

I implemented the tooltip on rail thank you 🙂


not support fields?

I know using {get; private set;} is better than using a field in C# culture.
but just have curious.

Hi, currently fields are not supported. I'm working on it but I can't promise when this will be released (I need to refactor a couple of things before to keep the codebase still maintainable).  The same issue has been reported as #94

Close reason: duplicated #94


Bedrock nether world to java nether world

Hi
I was wondering if you can transfer tghe nether world as well when converting a bedrockworld to java

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: c2e4afd0-2e7e-d74b-1fb4-08c367a79217
Version Independent ID: 6a04d5ff-9139-0ba9-6409-4a2368543bad
Content: Chunker - How to Clear The Nether
Content Source: creator/Documents/ChunkerTheNether.md
Service: minecraft-bedrock-edition
GitHub Login: @neonerz
Microsoft Alias: mikeam

Hi!
The nether world should convert when using Chunker to convert from Bedrock to Java, let us know if you have any problems with doing this :)

As Myles answered this question, I'm going to mark the issue as closed. Thanks!


s/unset/=/g

Allows me to run this nice plugin with
usetopt unset
in my .zshrc.

Cherry-picked as 11d17e7fea9fba8067f992b3d95e884c20a4069c. Thanks!


Crash when opening the creative inventory.

Mod Name
Combatify and Mutant Monsters
Mod Homepage
https://modrinth.com/mod/combatify https://www.curseforge.com/minecraft/mc-mods/mutant-monsters
Minecraft version
1.20.1
Describe the bug
When opening the inventory, the game crashes.
Steps to reproduce
Open the creative inventory.
Logs
https://gist.github.com/xelotex/fad9f3940fbb02697d86b7a98d593c2a
Additional context
Seems like the crash is caused by having mutant monsters and combatify installed together. If i remove mutant monsters and leave combatify installed, the crash won't happen and i can open the inventory as normal. And viceversa.
Here's the modlist:

This doesn't happen anymore. And i probably shouldn't have reported this issue here tbh


Url change

This repository has moved to: https://github.com/TwitchLib/TwitchLib
To
This repository has moved to: https://github.com/TwitchLib/
So the link goes to all the projects and not inside twitchlib directly.

Fixed, thx


The use of RSA Public key authentication method in ssh leads to Failed to fetch key

See https://bugzilla.redhat.com/show_bug.cgi?id=1824306 for details.
Description of problem:
Having two appliances, if I want to fetch the v2_key from the other appliance, having the Public key authentication method in place (I created a keypair using ssh_keygen and distributed the public key to the OTHER_APPLIANCE_IP), the command
appliance_console_cli --fetch-key=OTHER_APPLIANCE_IP

Steps to Reproduce:

ssh_keygen (generate passwordless RSA key)
ssh-copy-id OTHER_APPLIANCE_IP (do what it asks for)
appliance_console_cli --fetch-key=OTHER_APPLIANCE_IP

Actual results:
fetch encryption key
Failed to fetch key: key was 385 bytes (Expected 32)
Could not create encryption key (v2_key)

2 solutions:

We can upgrade the ssh gem to latest (e.g.: 6.1) will fix issue
there is a work around when using ssh trust:

eval `ssh-agent -s` ; ssh-add

I will put into the bz

2 works arounds provided.


hexHoledCircle

Description
This creates a new shape of a circle with a hexagonal hole in it.

Checklist

[ ] This PR has only one purpose or idea.
[ ] Tests have been added/updated to verify that the new/changed code works.

[ ] The code style follows good practices.
[ ] The commit message(s) follow good practices.

[ ] The release notes (location doc/release/0.X.rst) are up-to-date with any bug fixes or new features.
[ ] The documentation is still up-to-date in the doc folder.
[ ] The dependencies are still up-to-date in setup.py.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Ashley Thompson seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

@john-science I'm taking a look at this now.
But as a side note, I'm wondering if it would make sense to implement some functionality in the future for creating "holed" components from other component shapes generically.  So far, we have HolexHexagon, HoledRectangle, HoledSquare, and now HexHoledCircle. These basically all do the same thing under the hood.
If we could make a new shape like HoledShape that accepts baseShape, holeShape, and nHoles, we could get shapes of all varieties with holes in them with much less specific code.


JAMES-4007 Improve IMAP literal lifecycle

Avoid not clearing IMAP litteral in sonme specific cases
Avoid clearing IMAP litteral while IMAP APPEND is in progress

I'll try this in prod tomorrow before committing.


before/after Each does not run around each invocation of a test

Demonstration code: https://gist.github.com/hoangtranwork/8166d7c7d1202d3113ddb835f82f014e
If I understand correctly, if we set invocation = x (x > 0) as well as overriding the beforeEach/afterEach hook, then those hooks should run around each invocation (of the same test), but as I tested with the code above, it doesn't.
So is this a bug or do I misunderstand the feature?

probably a mistake here: https://github.com/kotlintest/kotlintest/blob/master/src/main/kotlin/io/kotlintest/TestBase.kt#L87
it should call beforeEach(), instead of afterEach()

well, and after looking at the runTest() function I can see that invocation configuration is used there, which completely inside the beforeEach/afterEach circle.
So it left the question: is this by design or a bug?

Your PR fixes that.

@sksamuel Do you release 1.3.3 with this fix? I've made the same fix in release/2.0.

Not yet, but I will.

Fixed in 1.3.3. Helmbold has made same fix in 2.0


#region and #endregion support

So I've been told that #region and #endregion are supported by ZScript not only inside comments (which don't work, by the way) but they work even outside of those.
A commit from 2016 on GZDoom's source code as a proof: https://github.com/ZDoom/gzdoom/commit/1ba526d4deacfeebc3f5a660fb45b64a20de33f3
I currently have no idea if they work like they do in other languages (they don't do anything) or they have an actual meaning on the code in between...

Should be fixed now! GH-21
Please, comment if there are any issues!


Add Attachments

This commit has Byakuren, Doremy, Futo, Ichirin, Joon and Kasen added their attachments

I swear I'll finish Nitori's attachments, but please fix Miko's Red Cape 🙏

I have FINALLY added Reimu, finished up Nitori and did everything that was on the wiki for Mokou. I should've gone to bed .-.

The remaining characters are filed under issue #103


Typeo in svgRenderer.coffee

The stroke-width needs a space after the preceding quote.
https://github.com/literallycanvas/literallycanvas/blob/cf41d8fe371874ccbb800a82194f0d3ae2f15439/src/core/svgRenderer.coffee#L90

And line 92 should close the g tag (i.e. ):
https://github.com/literallycanvas/literallycanvas/blob/cf41d8fe371874ccbb800a82194f0d3ae2f15439/src/core/svgRenderer.coffee#L92

Fixed in 0.4.11.

Looks like the typeo is still there:
stroke='#{shape.color} 'stroke-width='#{shape.strokeWidth}'
should be
stroke='#{shape.color}' stroke-width='#{shape.strokeWidth}'
Great project, by the way

Damn.

Hahaha, no worries. Its easily fixed in the compiled code.


Serial version UID

It would be nice to have an annotation to automatically create a field like
    private static final long serialVersionUID =<PHONE_NUMBER>840482032L;

for all classes which implements java.io.Serializable

This has been discussed before and deemed not worth the effort; see e.g. https://groups.google.com/forum/?hl=en#!searchin/project-lombok/@serializable/project-lombok/RQ6VQRRMY38/jli-UYPSgfgJ


Question: how is botocore redacting my plaintext when I call Encrypt?

Example log line:
2017-05-31 23:30:30,323:DEBUG:botocore.endpoint:endpoint.py:140:Making request for OperationModel(name=Encrypt) (verify_ssl=True) with params: {'body': '{"Plaintext": "Ym9vcA==", ....

My actual plaintext was just the string "boop". So how'd this value get put there instead? I am curious to see whether it is safe for me to be writing these logs to disk, or if that would expose my secret.

Ym9vcA== is simply the base64 encoded value of boop:
$ echo "Ym9vcA==" | base64 -d
boop

Ah, well, that answers that. Thanks.


0-based parameter binding not supported

Hi, line below:
https://github.com/crate/crate-pdo/blob/0.6.2/src/Crate/PDO/PDOStatement.php#L200
needs to be changed to:
$zero_based = array_key_exists(0, $input_parameters_array);
or when sending a query with first value being NULL an exception will be thrown.
Regards,
Chris

hi @l7s
thanks for reporting. you're right, the isset() check is not NULL safe.
do you want to provide a fix? otherwise we'll take care of if.

Hi, if could you please take care of it that would be great.
Regards,
Chris

hey @l7s
this issue was fixed with https://github.com/crate/crate-pdo/pull/65 and it is released in version 0.6.3

Great, closing this issue.


Azure Databricks - Managed Disk Encryption - Critical API Version Cha…

ARM API Information (Control Plane)
MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo.  If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?

[ ] new service onboarding
[ ] new API version
[ ] update existing version for new feature
[X] update existing version to fix swagger quality issue in s360
[ ] Other, please clarify

When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.

Code changes for new feature has already been deployed to public regions earlier this week (October 24, 2022). Our team believed that these changes were previously merged to the public repo but they have not been. Additionally, we already have one major customer using the feature.

When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.

October 2022

By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

[X] I commit to follow the Breaking Change Policy of "no breaking changes"
[X] I have reviewed the documentation for the workflow.
[X] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

Applicability: :warning:
If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs
Adding new properties
All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

[] Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review.  Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

Adding a new service
Adding new API(s)
Adding a new API version
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.

[X] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.

Appears that you are adding missing properties that should be documented in swagger in this api-version.
But I will still need an approval from breaking changes for this. Let me know if you ready to do that.

Approve

#Approved

ping me to merge, when you are ready.


jackett: 0.18.15 -> 0.18.95

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/Jackett/Jackett/releases.
meta.description for jackett is: "API Support for your favorite torrent trackers"
meta.homepage for jackett is: "https://github.com/Jackett/Jackett/"
meta.changelog for jackett is: ""
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

Warning: no invocation of /nix/store/w1hbb7jn2j34c5wphjg7bnii0r0sd6r4-jackett-0.18.95/bin/Jackett had a zero exit code or showed the expected version

0 of 1 passed binary check by having a zero exit code.

0 of 1 passed binary check by having the new version present in output.

found 0.18.95 with grep in /nix/store/w1hbb7jn2j34c5wphjg7bnii0r0sd6r4-jackett-0.18.95

found 0.18.95 in filename of file in /nix/store/w1hbb7jn2j34c5wphjg7bnii0r0sd6r4-jackett-0.18.95

directory tree listing: https://gist.github.com/0edda128ad7f10898c6fddccbd444f16

du listing: https://gist.github.com/143037c8bd0e43a8ac29bebd83df7f56

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
jackett

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/w1hbb7jn2j34c5wphjg7bnii0r0sd6r4-jackett-0.18.95 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A jackett https://github.com/r-ryantm/nixpkgs/archive/db6da6100e35fefac5245d9efe7366ad1724f3eb.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/w1hbb7jn2j34c5wphjg7bnii0r0sd6r4-jackett-0.18.95
ls -la /nix/store/w1hbb7jn2j34c5wphjg7bnii0r0sd6r4-jackett-0.18.95/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

jackett

Maintainer pings
cc @edwtjo @nyanloutre @purcell for testing.

Result of nixpkgs-review pr 123779 at db6da610 run on aarch64-linux 1

1 package built successfully:

jackett

1 suggestion:

warning: missing-phase-hooks
installPhase should probably contain runHook preInstall and runHook postInstall.
Near pkgs/servers/jackett/default.nix:14:3:
   |
14 |   installPhase = ''
   |   ^


Add js hello-world example

Summary
This PR adds the code from https://developers.mattermost.com/integrate/apps/quick-start-js/ to this repo for easier discovery and version control.
It also fixes a couple of issue:

Renamed the go example to hello-world for conistency
Fix AWS lambda js example manifest
Formating

Ticket Link
None

Codecov Report

Merging #174 (c72d14b) into master (cf7cece) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head c72d14b differs from pull request most recent head 6443280. Consider uploading reports for the commit 6443280 to get more accurate results

@@           Coverage Diff           @@
##           master     #174   +/-   ##
=======================================
  Coverage   20.14%   20.14%
=======================================
  Files          29       29
  Lines        1360     1360
=======================================
  Hits          274      274
  Misses       1067     1067
  Partials       19       19

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf7cece...6443280. Read the comment docs.

@mickmister I've synced the go and js example both here and in https://github.com/mattermost/mattermost-developer-documentation/pull/812. Please take a look.

@hanzei - can we merge this?

@justinegeffen Yes


Benchmark configurations that make use of Rackspace's Block Storage service do not work

Recently, there have been several changes in the OpenStack libraries, where block storage volume support has been deprecated and removed from the Nova client library. Since the current Rackspace provider implementation in PKB depends on Nova, this means it breaks all the volume operations.
Whenever a benchmark configuration that tries to use Rackspace Block Storage volumes as scratch disk will print the following error:
WARNING: Command volume-create is deprecated and will be removed after Nova 13.0.0 is released. Use python-cinderclient or openstackclient instead.
ERROR (EndpointNotFound):

To properly fix this issue, the Rackspace provider implementation has to move to the official Rackspace CLI or make use of Cinder client directly.

@cmccoy Please assign to me

Done - thanks!

Ping ... is this still and open issue not that the disk refactor is in?

@voellm Yes, this is still an issue. It's not related to the disk refactor. Benchmarks that make use of remote volumes are not working, a temporary workaround is to use an older Nova client, instead of installing latest with pip. I expect something similar to happen soon to the OpenStack provider bindings as well since we are using the python-novaclient library which has deprecated the same volume operations.
As for the Rackspace provider, we want to move it to use our official CLI instead of OpenStack's. That way we can lower the risks of similar problems in the future, with the extra bonus that the CLI client is actually more performant for both speed and footprint, it can return JSON output which will simplify our bindings, and is much easier to install than Nova CLI since the rack CLI is just a Go static binary.
I've a local branch in my laptop with a semi-working implementation that uses the new CLI, but I haven't had the time to finish it.

Closing #844 fixed this.


Upgrade to postgres 12

Fixes #8436.
This works locally, but there is no way to test the CI changes without opening a PR.

Alright, tests are now running. Let's get them passing.

We should be good on schema changes now, just one failing test in tests/unit/legacy/api/test_json.py

Now the tests on travis are failing because it can't connect to the database.

@xmunoz I wouldn't burn too much time trying to get the Travis CI config working here -- we're planning to drop it soon anyway and this might be as good a time as any.

I'll try a few more things tonight, and then I'm going off-grid for a week (which reminds me, there is a small chance I might not be able to make it to our meeting next week).

Gave up on fixing travis and reverted all of the changes to .travis.yml.

General resolved. Final resolution for dev was https://github.com/pypi/warehouse/pull/11573
Recommend closure.


Update GitHub actions

This commit updates the GitHub actions to use versions based on node 20 rather than node 16, which is deprecated.

Builds successfully, merging this in


PR: Update macOS image used in Azure

It seems Azure was not being triggered due to that.

Closing because this is not the solution.


Explicitly returning None

This PR introduces a fix to add an explicit return None to the end of procedure bodies where there's no return statement or no return type.
Before the other changes in this PR, returning None was not possible as type check wasn't able to catch it (also, there were no tests where None was being returned). After the modification, compiler complained as it was trying to movq a None value while treating it as an immediate. I added a workaround where None is simply being treated as 0; I'm not sure if this is the intended behavior, but eventually it solved the problem momentarily and I can change it to however you'd want.

cc/ @peterthiemann


redirect to the 404 page

At least people will 404 on a decent page rather than apache server 404

This is ok, we may want to say some items have moved and redirect to mxnet.io after 5 seconds.,
This is what other pages do
E.g. https://www.portal.reinvent.awsevents.com/fdjk redirects to https://www.portal.reinvent.awsevents.com/portal/newreg.ww

@vishaalkapoor I've added some info and quick links


[Feature]: Remove gogo from jaeger query service

Requirement
External users may want to call jaeger query service to retrieve their traces to do a variety of things, such as build custom trace monitoring UIs, or retrieve traces for auditing purposes. This functionality is advertised in the Jaeger docs here.
Problem
The jaeger query grpc api still depends on gogo proto, which is now deprecated (the last release was Jan 2021). This inconveniences the api user, as they must now use gogo as well, if they want to call the API.
Note that in most cases, gogo is cross compatible with vanilla protobuf. However, this is not the case with jaeger query, as jaeger uses gogo's custom types for its traceIDs. These gogo docs explain that gogo custom types are not interopable with vanilla proto in several ways.
So ultimately, the user has to use this long-deprecated gogo software, if they want to call jaeger query's grpc api. This is unfortunate.
Proposal
Remove gogo from jaeger.
Open questions
If maintainers agree that this work is needed, I would be happy to contribute. I have experience with gogo, grpc, and protobuf.

I don't agree with the statement that internal use of gogo affects the users. If you're referring to the use of gogo annotations in the .proto files, then all that's needed is to remove those annotations and use .proto to generate plain gRPC code, without any dependency on gogo. Gogo annotations only affect the auto-generated code used internally in Jaeger, but they do not affect binary proto format.
Having said that, of course it would be great if we could remove the dependency on gogo. The problem is that I do not know of any equivalent that can provide the same performance characteristics, like mapping []byte fields to two int64s (which we do for TraceID), or avoiding pointers when dealing with arrays.


Doesn't build on ZNC 1.6.3?

I'm getting these errors:
CXXFLAGS=" -DPUSHVERSION=\"v1.0.0-136-gd5908dc\" -DUSE_CURL -lcurl" LIBS=" -DUSE_CURL -lcurl" \
         znc-buildmod push.cpp
Building "push.so" for ZNC 1.6.3... In file included from /usr/include/znc/ZNCDebug.h:21:0,
                 from /usr/include/znc/defines.h:24,
                 from /usr/include/znc/Csocket.h:43,
                 from /usr/include/znc/Socket.h:21,
                 from /usr/include/znc/Client.h:21,
                 from /usr/include/znc/znc.h:21,
                 from push.cpp:16:
/usr/include/znc/ZNCString.h:85:47: error: ‘CaseSensitivity’ is not a class or namespace
  static const CaseSensitivity CaseSensitive = CaseSensitivity::CaseSensitive;
                                               ^
/usr/include/znc/ZNCString.h:86:49: error: ‘CaseSensitivity’ is not a class or namespace
  static const CaseSensitivity CaseInsensitive = CaseSensitivity::CaseInsensitive;
                                                 ^
In file included from /usr/include/znc/znc.h:21:0,
                 from push.cpp:16:
/usr/include/znc/Client.h:191:7: error: ‘shared_ptr’ in namespace ‘std’ does not name a template type
  std::shared_ptr<CAuthBase> m_spAuth;
       ^
In file included from /usr/include/znc/WebModules.h:21:0,
                 from /usr/include/znc/Modules.h:21,
                 from /usr/include/znc/znc.h:22,
                 from push.cpp:16:
/usr/include/znc/Template.h:128:23: error: ‘shared_ptr’ in namespace ‘std’ does not name a template type
  CTemplate(const std::shared_ptr<CTemplateOptions>& Options, CTemplate* pParent = NULL) : MCString(), m_spOptions(Options
                       ^
/usr/include/znc/Template.h:128:33: error: expected ‘,’ or ‘...’ before ‘<’ token
  CTemplate(const std::shared_ptr<CTemplateOptions>& Options, CTemplate* pParent = NULL) : MCString(), m_spOptions(Options
                                 ^
/usr/include/znc/Template.h:136:26: error: ‘std::shared_ptr’ has not been declared
  void AddTagHandler(std::shared_ptr<CTemplateTagHandler> spTagHandler) {
                          ^
/usr/include/znc/Template.h:136:36: error: expected ‘,’ or ‘...’ before ‘<’ token
  void AddTagHandler(std::shared_ptr<CTemplateTagHandler> spTagHandler) {
                                    ^
/usr/include/znc/Template.h:140:14: error: ‘shared_ptr’ is not a member of ‘std’
  std::vector<std::shared_ptr<CTemplateTagHandler> >& GetTagHandlers() {
              ^
/usr/include/znc/Template.h:140:14: error: ‘shared_ptr’ is not a member of ‘std’
/usr/include/znc/Template.h:140:49: error: template argument 1 is invalid
  std::vector<std::shared_ptr<CTemplateTagHandler> >& GetTagHandlers() {
                                                 ^
/usr/include/znc/Template.h:140:49: error: template argument 2 is invalid
/usr/include/znc/Template.h:140:51: error: expected unqualified-id before ‘>’ token
  std::vector<std::shared_ptr<CTemplateTagHandler> >& GetTagHandlers() {
                                                   ^
In file included from /usr/include/znc/znc.h:22:0,
                 from push.cpp:16:
push.cpp:2010:1: error: expected ‘}’ at end of input
 NETWORKMODULEDEFS(CPushMod, "Send highlights and personal messages to a push notification service")
 ^
In file included from /usr/include/znc/WebModules.h:21:0,
                 from /usr/include/znc/Modules.h:21,
                 from /usr/include/znc/znc.h:22,
                 from push.cpp:16:
/usr/include/znc/Template.h: In constructor ‘CTemplate::CTemplate()’:
/usr/include/znc/Template.h:120:28: error: class ‘CTemplate’ does not have any field named ‘m_spOptions’
  CTemplate() : MCString(), m_spOptions(new CTemplateOptions) {
                            ^
/usr/include/znc/Template.h:121:8: error: ‘Init’ was not declared in this scope
   Init();
        ^
/usr/include/znc/Template.h: In constructor ‘CTemplate::CTemplate(const CString&)’:
/usr/include/znc/Template.h:124:52: error: class ‘CTemplate’ does not have any field named ‘m_sFileName’
  CTemplate(const CString& sFileName) : MCString(), m_sFileName(sFileName), m_spOptions(new CTemplateOptions) {
                                                    ^
/usr/include/znc/Template.h:124:76: error: class ‘CTemplate’ does not have any field named ‘m_spOptions’
  CTemplate(const CString& sFileName) : MCString(), m_sFileName(sFileName), m_spOptions(new CTemplateOptions) {
                                                                            ^
/usr/include/znc/Template.h:125:8: error: ‘Init’ was not declared in this scope
   Init();
        ^
/usr/include/znc/Template.h: In constructor ‘CTemplate::CTemplate(int)’:
/usr/include/znc/Template.h:128:103: error: class ‘CTemplate’ does not have any field named ‘m_spOptions’
  CTemplate(const std::shared_ptr<CTemplateOptions>& Options, CTemplate* pParent = NULL) : MCString(), m_spOptions(Options
                                                                                ^
/usr/include/znc/Template.h:128:115: error: ‘Options’ was not declared in this scope
 emplate(const std::shared_ptr<CTemplateOptions>& Options, CTemplate* pParent = NULL) : MCString(), m_spOptions(Options) {
                                                                                ^
/usr/include/znc/Template.h:129:8: error: ‘Init’ was not declared in this scope
   Init();
        ^
/usr/include/znc/Template.h:130:3: error: ‘m_pParent’ was not declared in this scope
   m_pParent = pParent;
   ^
/usr/include/znc/Template.h:130:15: error: ‘pParent’ was not declared in this scope
   m_pParent = pParent;
               ^
/usr/include/znc/Template.h: In member function ‘void CTemplate::AddTagHandler(int)’:
/usr/include/znc/Template.h:137:3: error: ‘m_vspTagHandlers’ was not declared in this scope
   m_vspTagHandlers.push_back(spTagHandler);
   ^
/usr/include/znc/Template.h:137:30: error: ‘spTagHandler’ was not declared in this scope
   m_vspTagHandlers.push_back(spTagHandler);
                              ^
/usr/include/znc/Template.h: At global scope:
/usr/include/znc/Template.h:138:2: error: expected unqualified-id at end of input
  }
  ^
[ !! ] Error while building "push.so"
Makefile:13: recipe for target 'push.so' failed
make: *** [push.so] Error 1

I'm using the znc and znc-dev packages on Debian testing.

I can't replicate this build failure, on either Arch or Mac, after building from git using the znc-1.6.3 tag.  I don't have a Debian box to test on, but it sounds like either a problem with the ZNC packages, or something else with your local machine configuration.  Can you try building ZNC from source and see if the problem persists?

Works for me on 1.6.3 and it's been a week since this guy shared an error, without any follow up.
I will point out that make did not work for me, but znc-buildmod (or w/e it is), worked perfectly.

it's been a week since this guy shared an error, without any follow up.

Sorry, my week was pretty busy :stuck_out_tongue:

Can you try building ZNC from source and see if the problem persists?

I'll try that when I get some free time!
I guess since you can't replicate the problem, feel free to close this issue if you like.


excludScrollbar an optional property

Describe the bug
excludeScrollbar - should be an optional property in DatePickerProps
To Reproduce
https://codesandbox.io/p/sandbox/datepickerprops-92df8r?file=%2Fsrc%2FApp.tsx
I want to make a wrapper for a component. To pass all its properties I use DatePickerProps from the react-datepicker import.
But the excludeScrollbar property should be an optional property
Expected behavior
excludeScrollbar - should be an optional property in DatePickerProps

@lordenas
Would this page be helpful? (It seems to be a glitch in ts.)
https://stackoverflow.com/questions/78641187/why-is-excludscrollbar-property-required-for-react-datepicker
When reproducing it at hand, I forked codesandbox, but the type error is not occurring for some reason.
https://codesandbox.io/p/sandbox/datepickerprops-forked-vzwr86
Would bringing ts up to date improve this?

@lordenas Would this page be helpful? (It seems to be a glitch in ts.) https://stackoverflow.com/questions/78641187/why-is-excludscrollbar-property-required-for-react-datepicker
When reproducing it at hand, I forked codesandbox, but the type error is not occurring for some reason. https://codesandbox.io/p/sandbox/datepickerprops-forked-vzwr86
Would bringing ts up to date improve this?

It's strange, but I still see the error in CodeSandox


find_near_square.py

Running examples/Design/find_near_square.py is throwing me an AttributeError for length_of_side on line 132. It seems like everything is in order to me, inside of utilities.py but the error is there, nonetheless.
File ".\find_near_square.py", line 132, in main     length = dt.utilities.length_of_side(number_of_boreholes, B) AttributeError: module 'ghedt.utilities' has no attribute 'length_of_side'

Have you installed v0.1 from PyPi or did you clone the repository?

@NicholasFry I ask because the current find_near_square.py in the main branch is using functions that didn't exist in v0.1. If you have ran pip install ghedt (accessing PyPi) then you'll need utilize the examples located in the version 0.1 release.

You are moving quickly! I cloned into a new environment, and it works beautifully. Thanks.


Move location integrity tests into their own file

This repo is going to need some structure soon...

Excellent :+1:


Adding days off in Calendar no longer works. OK button stays disabled.

The OK button stays disabled whatever I choose, even if I change the values in the popup. There is no indication why.

Triage by MS
"Thank you for your feedback. We have determined that this issue belongs to Calendar extension. You need to be a Team Administrator or above to add "Days Off". If any more other questions, please go to https://github.com/Microsoft/vsts-team-calendar/issues?utm_source=vsmp&utm_medium=ms web&utm_campaign=mpdetails to continue tracking the issue. Thank you for helping us build a better Visual Studio."

We're closing old issues so we can get back to actively maintaining the extension. Feel free to reopen if this is still an issue for you.


Add manpages for podman-bootc

I have started writing man pages for podman-bootc using Podman's man pages as a template.
Still a work in progress, but opening the pull request early to attract input and comments from others.

Looks good, I would steal these scripts from RamaLama and add them to podman-bootc.
$ ls hack/xref-helpmsgs-manpages hack/man-page-checker
hack/man-page-checker  hack/xref-helpmsgs-manpages

Then add them to makefile and tests ,to make sure you man pages stay in good shape.

Then add them to makefile and tests ,to make sure you man pages stay in good shape.

Thanks for the tip. Think I'll borrow their Makefile for docs too since it looks a lot less hairy than podman's


Use a machine generated from a node for the termination loop

Fixes #
Description

Use a machine generated from a node for termination

How was this change tested?
make presubmit
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

2 of 4 (50.0%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.3%) to 76.372%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/cloudprovider/metrics/cloudprovider.go
0
2
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.3%

Covered Lines:
5582

Relevant Lines:
7309

💛  - Coveralls


"Shifted most frequent category" visualization broken

Release number or git hash: develop
Web browser version and OS: chrome

Steps to reproduce

Stratify by categorical attribute
Aggregate groups

Observed behavior

Expected behavior


Handle default branch properly

Hi,
Thank you for cargo-generate :heart:
I would like to introduce this change to make cargo-generate more friendly with repositories that don't use "master" as the default branch. I think this is particularly relevant now that GitHub also uses "main" instead of "master".
I would have like to fix it on cargo directly but there are some compatibility issues. But I don't think this is an issue for cargo-generate. This is why I'm introducing this change here.
I was personally bothered by it because I tried to make a new template but it failed because I was using the "main" branch as default branch.

Hi @cecton, thanks for the update!
Everything is ok on my side - any comment(s) @sassman or I can merge it? :)

@k0pernicus unfortunately I cannot merge it, lacking the privileges. But looks good for me.

Thanks again @cecton, and welcome as a contributor! :)

Thanks a lot! 🎉


Nuke resources of a single function

It would be very practical a command to delete resources for a single @http function.
Some times I set the wrong method and end up having to delete it all manually...

Possibly superseded by https://github.com/arc-repos/architect/issues/123 ?


Pin werkzeug version to fix python getting started issue

fixes #3610
Note that this is a hot fix, we should do some additional improvements to the python getting started in the future to avoid those kinds of issues from happening (i.e. pin the versions of all dependencies)

I cannot review (I don't think) but I can validate that pinning werkzeug<3 fixes the issue.
When I install I get 2.3.8 not 2.3.7, maybe pin to <3 to indicate that the major version increment in werkzeug introduced the breaking change.

I cannot review (I don't think) but I can validate that pinning werkzeug<3 fixes the issue.

You can always review PRs on github, and they are helpful to drive the PR, but your review will not satisfy the review requirements.

When I install I get 2.3.8 not 2.3.7, maybe pin to <3 to indicate that the major version increment in werkzeug introduced the breaking change.

I updated it to <3 thanks


Partner groups update from last week

Hello @ksigler7,Thanks again for the PR! We appreciate your contribution and look forward to                                              continued collaboration. Thanks!                                             Team SendGrid DX


Error in determining project root. Please confirm project structure is correct.

Describe the Bug with repro steps
Start new LA workspace project
Select with new LA with "custom code"
Try to view designer
What type of Logic App Is this happening in?
Standard VSCODE
Which operating system are you using?
Windows
Are you using new designer or old designer
Did you refer to the TSG before filing this issue? https://aka.ms/lauxtsg
Yes
Workflow JSON
No response
Screenshots or Videos
No response
Browser
VScode
Additional context
No response

For some reason azureLogicAppsStandard.projectSubpath is not set on project creation. You need to set it to reference the LogiApp folder. Then you can edit the workflow.

For some reason azureLogicAppsStandard.projectSubpath is not set on project creation. You need to set it to reference the LogiApp folder. Then you can edit the workflow.

Forget this one @Viktorh89 most likely is that you have not opened the workspace but just the folder. At least for me when I happen to open the folder I get the error if I open with the workspace file it works as expected.

We are hitting this same error.  It works only on the machine that created the Workspace. We have the code checked in and if another developer clones the project and try to open a workflow in the designer, it states that there is an error in determining the root. Something must be getting hardcoded to a path somewhere, but we cannot figure it out.  If anyone has a fix, please let us know.

@mikeholdorf after your post I did a test to see if I could sort it out with no success. I'm using the latest extension 4.57.7
After recreating the workspace file (it was in .gitignore) and changing the paths in solution file that was created I was able to open the designer.  When it comes to having a function in the same project The metadata files are created when I build the function. That said I'm  not able to have the environment to use the "Call a local function" action. I get "Failed to retrieve dynamic inputs", see output below.
`NodeJs Binaries: C:\Users\...username...\.azurelogicapps\dependencies\NodeJs
11:39:34 PM: No connection keys found to verify
11:39:35 PM: Running command: "C:\Users\...username...\.azurelogicapps\dependencies\FuncCoreTools\func host start --port 8002" with pid: "59168"...
Azure Functions Core Tools
Core Tools Version:       4.0.5907 Commit hash: N/A +807e89766a92b14fd07b9f0bc2bea1d8777ab209 (64-bit)
Function Runtime Version: 4.834.3.22875
FuncCoreTools Binaries: C:\Users\...username...\.azurelogicapps\dependencies\FuncCoreTools
Functions:
NetFxLanguageWorkerFunction: NetFxTrigger

XsltNetFxLanguageWorkerFunction: NetFxTrigger

For detailed output, run func with --verbose flag.
DotNetSDK Binaries: C:\Users\...username...\.azurelogicapps\dependencies\DotNetSDK
11:39:38 PM: Azure Logic Apps Standard Runtime Dependencies validation and installation completed successfully.
Failed to find: c:\Repos\logicapp-function-workspace\lafunc-ws\LogicApp\workflow-designtime\.vscode\tasks.json
[2024-09-05T21:39:38.273Z] Worker process started and initialized.
[2024-09-05T21:39:42.653Z] Host lock lease acquired by instance ID '0000000000000000000000006E30E539'.
[2024-09-05T21:40:35.879Z] Error message: correlationId='03ae11d3-3af2-40db-95c1-2adf16d073b1', operationName='ErrorResponseHandling.GetErrorResponseMessage.POST/RUNTIME/WORKFLOW/MANAGEMENT/LOCALFUNCTIONOPERATION/GETOUTPUTSCHEMA/', message='Http request failed with unhandled exception of type 'NullReferenceException' and message: 'System.NullReferenceException: Object reference not set to an instance of an object.
[2024-09-05T21:40:35.879Z]    at Microsoft.Azure.Workflows.Data.Engines.BuiltInOperationDynamicRequestEngine.GetOutput(IFlowConfigurationHolder holder, ServiceProviderDynamicInvokeInputDefinition requestDefinition)
[2024-09-05T21:40:35.879Z]    at Microsoft.Azure.Workflows.Web.Controllers.EdgeDesignerApiController.InvokeBuiltInDynamicRequest(String apiName, String operationName, ServiceProviderDynamicInvokeInputDefinition requestInputDefinition)
[2024-09-05T21:40:35.879Z]    at Microsoft.Azure.Workflows.Web.Controllers.EdgeDesignerApiController.BuiltInDynamicInvoke(String apiName, String apiOperationName, CancellationToken cancellationToken)
[2024-09-05T21:40:35.879Z]    at Microsoft.Azure.Workflows.Web.BaseFlowExtensionRouteInitializer.Invoke(HttpRequestMessage request, CancellationToken cancellationToken)
[2024-09-05T21:40:35.879Z]    at Microsoft.Azure.Workflows.Web.Handlers.FlowExtensionHttpRequestHandler.HandleRequest(HttpRequestMessage request, CancellationToken cancellationToken)
[2024-09-05T21:40:35.879Z]    at Microsoft.Azure.Workflows.Web.Handlers.FlowExtensionAuthorizationHandler.HandleRequest(HttpRequestMessage request, CancellationToken cancellationToken)
[2024-09-05T21:40:35.879Z]    at Microsoft.Azure.Workflows.Web.Handlers.FlowExtensionErrorResponseHandler.HandleRequest(HttpRequestMessage request, CancellationToken cancellationToken)'.', exception='System.NullReferenceException: Object reference not set to an instance of an object.
[2024-09-05T21:40:35.879Z]    at Microsoft.Azure.Workflows.Data.Engines.BuiltInOperationDynamicRequestEngine.GetOutput(IFlowConfigurationHolder holder, ServiceProviderDynamicInvokeInputDefinition requestDefinition)
[2024-09-05T21:40:35.879Z]    at Microsoft.Azure.Workflows.Web.Controllers.EdgeDesignerApiController.InvokeBuiltInDynamicRequest(String apiName, String operationName, ServiceProviderDynamicInvokeInputDefinition requestInputDefinition)
[2024-09-05T21:40:35.880Z]    at Microsoft.Azure.Workflows.Web.Controllers.EdgeDesignerApiController.BuiltInDynamicInvoke(String apiName, String apiOperationName, CancellationToken cancellationToken)
[2024-09-05T21:40:35.880Z]    at Microsoft.Azure.Workflows.Web.BaseFlowExtensionRouteInitializer.Invoke(HttpRequestMessage request, CancellationToken cancellationToken)
[2024-09-05T21:40:35.880Z]    at Microsoft.Azure.Workflows.Web.Handlers.FlowExtensionHttpRequestHandler.HandleRequest(HttpRequestMessage request, CancellationToken cancellationToken)
[2024-09-05T21:40:35.880Z]    at Microsoft.Azure.Workflows.Web.Handlers.FlowExtensionAuthorizationHandler.HandleRequest(HttpRequestMessage request, CancellationToken cancellationToken)
[2024-09-05T21:40:35.880Z]    at Microsoft.Azure.Workflows.Web.Handlers.FlowExtensionErrorResponseHandler.HandleRequest(HttpRequestMessage request, CancellationToken cancellationToken)', organizationId='', activityVector='IN.00', additionalProperties='{"ParentActivityId":"00-c12be268e29f7abdc806c1c39e64c748-1b2a6d482d1d6c92-00"}', extensionVersion='<IP_ADDRESS>', siteName='UNDEFINED_SITE_NAME', slotName='', activityId='03ae11d3-3af2-40db-95c1-2adf16d073b1'.
[2024-09-05T21:40:35.883Z] Incoming HTTP request ends with server failure: correlationId='03ae11d3-3af2-40db-95c1-2adf16d073b1', authorizationSource='Management', authorizationAction='', operationName='POST/API/MANAGEMENT/OPERATIONGROUPS/OPERATIONS/DYNAMICINVOKE', httpMethod='POST', hostName='localhost', targetUri='http://localhost:8002/runtime/webhooks/workflow/api/management/operationGroups/localFunctionOperation/operations/getOutputSchema/dynamicInvoke?api-version=2018-11-01', userAgent='Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Code/1.93.0 Chrome/124.0.6367.243 Electron/30.4.0 Safari/537.36', clientRequestId='', clientSessionId='', clientIpAddress='', clientApplicationId='', apiVersion='2018-11-01', contentLength='-1', serviceRequestId=':03ae11d3-3af2-40db-95c1-2adf16d073b1', durationInMilliseconds='28', httpStatusCode='500', exceptionMessage='', errorCode='', failureCause='Service', errorMessage='', referer='', commandName='', parameterSetName='', contentType='application/json; charset=utf-8', contentEncoding='', armServiceRequestId='', organizationId='', activityVector='IN', locale='en-US', additionalProperties='{"ParentActivityId":"00-c12be268e29f7abdc806c1c39e64c748-1b2a6d482d1d6c92-00"}', targetResourceProvider='', targetResourceType='', extensionVersion='<IP_ADDRESS>', siteName='UNDEFINED_SITE_NAME', slotName='', activityId='03ae11d3-3af2-40db-95c1-2adf16d073b1'.
[2024-09-05T21:40:36.051Z] Error message: correlationId='4fe13f75-6bd1-4872-9142-8ce1c2387ae4', operationName='ErrorResponseHandling.GetErrorResponseMessage.POST/RUNTIME/WORKFLOW/MANAGEMENT/LOCALFUNCTIONOPERATION/GETPARAMETERS/', message='Http request failed with unhandled exception of type 'NullReferenceException' and message: 'System.NullReferenceException: Object reference not set to an instance of an object.
[2024-09-05T21:40:36.051Z]    at Microsoft.Azure.Workflows.Data.Engines.BuiltInOperationDynamicRequestEngine.GetParametersDynamicList(IFlowConfigurationHolder holder, ServiceProviderDynamicInvokeInputDefinition requestDefinition)
[2024-09-05T21:40:36.051Z]    at Microsoft.Azure.Workflows.Web.Controllers.EdgeDesignerApiController.InvokeBuiltInDynamicRequest(String apiName, String operationName, ServiceProviderDynamicInvokeInputDefinition requestInputDefinition)
[2024-09-05T21:40:36.051Z]    at Microsoft.Azure.Workflows.Web.Controllers.EdgeDesignerApiController.BuiltInDynamicInvoke(String apiName, String apiOperationName, CancellationToken cancellationToken)
[2024-09-05T21:40:36.051Z]    at Microsoft.Azure.Workflows.Web.BaseFlowExtensionRouteInitializer.Invoke(HttpRequestMessage request, CancellationToken cancellationToken)
[2024-09-05T21:40:36.051Z]    at Microsoft.Azure.Workflows.Web.Handlers.FlowExtensionHttpRequestHandler.HandleRequest(HttpRequestMessage request, CancellationToken cancellationToken)
[2024-09-05T21:40:36.051Z]    at Microsoft.Azure.Workflows.Web.Handlers.FlowExtensionAuthorizationHandler.HandleRequest(HttpRequestMessage request, CancellationToken cancellationToken)
[2024-09-05T21:40:36.051Z]    at Microsoft.Azure.Workflows.Web.Handlers.FlowExtensionErrorResponseHandler.HandleRequest(HttpRequestMessage request, CancellationToken cancellationToken)'.', exception='System.NullReferenceException: Object reference not set to an instance of an object.
[2024-09-05T21:40:36.051Z]    at Microsoft.Azure.Workflows.Data.Engines.BuiltInOperationDynamicRequestEngine.GetParametersDynamicList(IFlowConfigurationHolder holder, ServiceProviderDynamicInvokeInputDefinition requestDefinition)
[2024-09-05T21:40:36.051Z]    at Microsoft.Azure.Workflows.Web.Controllers.EdgeDesignerApiController.InvokeBuiltInDynamicRequest(String apiName, String operationName, ServiceProviderDynamicInvokeInputDefinition requestInputDefinition)
[2024-09-05T21:40:36.051Z]    at Microsoft.Azure.Workflows.Web.Controllers.EdgeDesignerApiController.BuiltInDynamicInvoke(String apiName, String apiOperationName, CancellationToken cancellationToken)
[2024-09-05T21:40:36.051Z]    at Microsoft.Azure.Workflows.Web.BaseFlowExtensionRouteInitializer.Invoke(HttpRequestMessage request, CancellationToken cancellationToken)
[2024-09-05T21:40:36.052Z]    at Microsoft.Azure.Workflows.Web.Handlers.FlowExtensionHttpRequestHandler.HandleRequest(HttpRequestMessage request, CancellationToken cancellationToken)
[2024-09-05T21:40:36.052Z]    at Microsoft.Azure.Workflows.Web.Handlers.FlowExtensionAuthorizationHandler.HandleRequest(HttpRequestMessage request, CancellationToken cancellationToken)
[2024-09-05T21:40:36.052Z]    at Microsoft.Azure.Workflows.Web.Handlers.FlowExtensionErrorResponseHandler.HandleRequest(HttpRequestMessage request, CancellationToken cancellationToken)', organizationId='', activityVector='IN.00', additionalProperties='{"ParentActivityId":"00-098e0297f438c0b91e4e9ad3612a4c86-eb937c70405cb7d4-00"}', extensionVersion='<IP_ADDRESS>', siteName='UNDEFINED_SITE_NAME', slotName='', activityId='4fe13f75-6bd1-4872-9142-8ce1c2387ae4'.
[2024-09-05T21:40:36.052Z] Incoming HTTP request ends with server failure: correlationId='4fe13f75-6bd1-4872-9142-8ce1c2387ae4', authorizationSource='Management', authorizationAction='', operationName='POST/API/MANAGEMENT/OPERATIONGROUPS/OPERATIONS/DYNAMICINVOKE', httpMethod='POST', hostName='localhost', targetUri='http://localhost:8002/runtime/webhooks/workflow/api/management/operationGroups/localFunctionOperation/operations/getParameters/dynamicInvoke?api-version=2018-11-01', userAgent='Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Code/1.93.0 Chrome/124.0.6367.243 Electron/30.4.0 Safari/537.36', clientRequestId='', clientSessionId='', clientIpAddress='', clientApplicationId='', apiVersion='2018-11-01', contentLength='-1', serviceRequestId=':4fe13f75-6bd1-4872-9142-8ce1c2387ae4', durationInMilliseconds='2', httpStatusCode='500', exceptionMessage='', errorCode='', failureCause='Service', errorMessage='', referer='', commandName='', parameterSetName='', contentType='application/json; charset=utf-8', contentEncoding='', armServiceRequestId='', organizationId='', activityVector='IN', locale='en-US', additionalProperties='{"ParentActivityId":"00-098e0297f438c0b91e4e9ad3612a4c86-eb937c70405cb7d4-00"}', targetResourceProvider='', targetResourceType='', extensionVersion='<IP_ADDRESS>', siteName='UNDEFINED_SITE_NAME', slotName='', activityId='4fe13f75-6bd1-4872-9142-8ce1c2387ae4'.
`

Everything is working for me and I can bring up the workspace and all works fine with the Designer.  The other developers on the project are cloning the repo and when they try and bring up the Designer, it just states Error determining the Root.  So the good old saying...works on my machine. We have not been able to figure out a resolution. It looks like the workspace file has some hardcoded paths using my username and it also appears that not all of the .vscode files were created properly. Works different on a Mac vs a Windows machine, so is a big concern for multiple developer projects right now.

Agree with @mikeholdorf, to clarify on my test. On the machine where I created the Logic App it works fine in the machine where I have cloned the repo it does not.

Also experiencing this still, if i redo it manually l can reach designer, but reaching the local function seems to never work

@mikeholdorf @Viktorh89 I've been able to get it working. The problem for me was that Logic Apps is dependent on settings that are in local.settings.json and that is included in different ignore files. When I changed so local.settings.json is included in the repo it works.
  "IsEncrypted": false,
  "Values": {
    "AzureWebJobsStorage": "UseDevelopmentStorage=true",
    "WORKFLOWS_SUBSCRIPTION_ID": "",
    "FUNCTIONS_WORKER_RUNTIME": "node",
    "APP_KIND": "workflowapp",
    "AzureWebJobsFeatureFlags": "EnableMultiLanguageWorker"
  }
}```

If you want to test I have created a simple repo to be able to test.

1. Clone [repo](https://github.com/skastberg/abc02)
2. Open the workspace file `def01.code-workspace`
3. Open a terminal for **Function** project and build
4. Follow the instructions [here](https://learn.microsoft.com/en-us/azure/logic-apps/create-run-custom-code-functions#debug-your-code-and-workflow) for debug.
5. Open designer

I'm logging an issue about local.setting, there are no secrets in mine but as we're used to have them in gitignore not ideal. Agree, a bit annoying building and think it is by design. You can see in the csproj file steps to do that. I assume it is the way to keep the description files under lib current.

I was able to pull down your repo and get to the designer with no problem. We will test this with our internal projects and make sure this will work.  Thanks.

FYI #5620 added for the record.

Hi all, thank you so much for raising this issue and be proactive on the discussion of it. I would like to point out a few things

I highly suggest to not commit the local.setting.json, as you keep using Logic Apps the actions connections will store the keys/credentials
I took a look a the project structure, the reason on why just opening the folder doesn't work is because while looking for the logic apps project it doesn't look recursively across all the folders in the parent folder.
When the project is open through the workspace file both (Functions and LogicApp) folder are in the root path.
For now please keep using the workspace file, since that is the intended use and the resolution of the logic apps project is not recursive.

Is there any specific reason for not opening the project with the workspace file?

@ccastrotrejo  Ive tested this many times, it seem that in order to get this to work even when you open via workspace file (thats what we are all are doing) you need to have the local.setting there, otherwise it doesnt work

I see, yeah that makes sense. It seems that the local.settings.json file is note getting created when it detects its a logic app project. We will make the fix for it, after that opening the project with the workspace file should be enought to make the project working as expected.
As for now as a workaround please create a generic local.settings.json.


SqrtX gate support in quri-parts-openqasm

SqrtX(sx) is available in both QURI Parts and OpenQASM 3.0, so quri-parts-openqasm supports it.
stdgates.inc
https://github.com/openqasm/openqasm/blob/main/examples/stdgates.inc#L26

Could you resolve the conflict?


x/website: doc/tutorial/handle-errors: too many return values

What is the URL of the page with the issue?
https://go.dev/doc/tutorial/handle-errors
What is your user agent?

Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36
Screenshot

What did you do?
Ive been following this tutorial, and when getting to this error handling stage the code doesn't work anymore
What did you expect to see?
The tutorial code to just run without issues.
Looks like the norms have changed and it's not possible to return multiple elements but the tutorial is not up to date?
What did you see instead?
code erroring
$ go run .

# example.com/greetings
../greetings/greetings.go:12:20: too many return values
        have (string, error)
        want (string)
../greetings/greetings.go:16:21: too many return values
        have (string, nil)
        want (string)

https://go.dev/play/p/Pvqs4YTIGih
it's work fine.  what do you meaning

Unlike many projects, the Go project does not use GitHub Issues for general discussion or asking questions. GitHub Issues are used for tracking bugs and proposals only.
For questions please refer to https://github.com/golang/go/wiki/Questions


Fix ballerina lang issue 14981

Purpose
This is to fix https://github.com/ballerina-platform/ballerina-lang/issues/14981.
Fixes #
Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, releated PRs, TODO items or any other notes related to the PR.

Check List

[ ] Read the Contributing Guide
[ ] Required Balo version update
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Shouldn't we review the bal files in the PR as well?

@wggihan, should the BAL files be included in the doc review of this?

@wggihan, should the BAL files be included in the doc review of this?

Yes. Basically, we need to review under this location stdlib/jms/src/main/ballerina/jms/

Reviewed the following BAL files in the stdlib/jms/src/main/ballerina/jms/ directory.

stdlib/jms/src/main/ballerina/jms/durable_topic_subscriber.bal
stdlib/jms/src/main/ballerina/jms/queue_receiver.bal
stdlib/jms/src/main/ballerina/jms/session.bal
stdlib/jms/src/main/ballerina/jms/topic_subscriber.bal

Codecov Report

Merging #15574 into master will decrease coverage by 9.18%.
The diff coverage is n/a.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f452f57...3aa2dad. Read the comment docs.


NetInfo methods fail to resolve or reject

See https://github.com/facebook/react-native/issues/21953

This sounds a lot like the errors faced in #10 where if another request is made before a promise resolves the previous one will not be resolved or rejected.
Closing this issue in favour of that one. Please let me know by opening an issue in this repo if you are getting this error for a different reason.


WIP: data selfie

Current coverage is 67.89%

Merging #363 into master will decrease coverage by -1.51% as of 29d7dca

@@            master    #363   diff @@
======================================
  Files          110     116     +6
  Stmts         2997    3065    +68
  Branches         0       0
  Methods          0       0
======================================
+ Hit           2080    2081     +1
  Partial          0       0
- Missed         917     984    +67

Review entire Coverage Diff as of 29d7dca

Powered by Codecov. Updated on successful CI builds.

Just had one bump in user experience I commented on, otherwise :+1: I look forward to seeing this is staging!


add utils to upload file, upload/download folder

A couple points

do we want to use the rich printing/progress I copied over from data library? Essentially all upload_file is is a wrapper around boto3 client built-in upload with this progress. If we like this we could do a similar thing for download
download_folder is essentially ported over from @DeaBardhoshi and @athursland 's work in db-checkbook
should acl have default? This is what we had in data library but it seems maybe it's good to make ourselves be explicit if we're making things being pushed public rather than defaulting to it
I have a funny mish-mash of os.path stuff and pathlib.Path better now I think

Made a couple tweaks around paths and reformatted - more ready for review now. I'll add any more changes in additional commits, will likely just squash this one

download_folder is currently a tad broken, hold off on further reviews

Functions working as expected! All set from my end

Oh, one other thing. Can you add rich to requirements.txt/in?


Move filePreProcessing.ipynb functionality to a script

[ ] Create a script out of the code blocks on the notebook
[ ] Ensure it runs!

Let's use 'small' Whisper models as a baseline

Hello Ash,
I believe I solved all the dependency issues for running the script locally, however, I'm getting an error with privileges.
OSError: [WinError 1314] A required privilege is not held by the client: 'C:\Users\bmits\.cache\huggingface\hub\models--speechbrain--spkrec-ecapa-voxceleb\snapshots\5c0be3875fda05e81f3c004ed8c7c06be308de1e\hyperparams.yaml' -> 'C:\Users\bmits\.cache\torch\pyannote\speechbrain\hyperparams.yaml'.
I am unsure if I need some permissions or if the issues lie elsewhere.

Thanks for the update Benson. Hm, can you try running the script/vscode as admin? Does that work?
https://stackoverflow.com/questions/73782400/oserror-winerror-1314-when-doing-sentiment-analysis-using-flair


Add save manifest

This PR adds save method which dumps a yaml file that contains :
# object type
group:
  # relation type
  member:
    permissions:
     - path.GetUser
     - path.ListUser
    union: []

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 0.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
0

Relevant Lines:
0

💛  - Coveralls


Issue with Getting the PDF

Hey,
So I just finished a sweet new homebrew kit and I tried to get the pdf. However, when the new window opens it says that I have 0 pgs, refuses to let me save as a pdf, and causes everything to freeze. What can I do to fix this?
Additional Details
Share Link :
or
Brew code to reproduce : Click to expand
PASTE BREW CODE HERE

Looks like you forgot to provide the share link in your bug report. Can you
paste that in here for us? That will help a lot in figuring out the issue.
On Wed, Oct 4, 2017, 3:44 PM Pecclest<EMAIL_ADDRESS>wrote:

Hey,
So I just finished a sweet new homebrew kit and I tried to get the pdf.
However, when the new window opens it says that I have 0 pgs, refuses to
let me save as a pdf, and causes everything to freeze. What can I do to fix
this?
Additional Details
Share Link :
or
Brew code to reproduce :
Click to expand
PASTE BREW CODE HERE
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/stolksdorf/homebrewery/issues/508, or mute the thread
https://github.com/notifications/unsubscribe-auth/AFmzBjW8hNSY889tMgAlNQJimMG3wAwjks5so-AJgaJpZM4PuIqu
.

http://homebrewery.naturalcrit.com/share/S1m1yJyln-

I'll try again. Thanks for letting me know about the double ranger thing. I
just tried it and nothing happened. I wonder if it might be an issue with
my computer?
On Wed, Oct 4, 2017 at 4:30 PM, Sansd20<EMAIL_ADDRESS>wrote:

I have no issues on my end gettin it to print. I did noticed then when I
went to get the PDF and it did say there was zeros pages for a few seconds
before showing 22 pages.
I also notice that it looks like you have the "New Revised Ranger
Archetype - The Headhunter Conclave" section in there twice; atleast Pp
18-20 are in there twice.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/stolksdorf/homebrewery/issues/508#issuecomment-334280075,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AfBM52O_vhftArLtuhlh4xHGxqrEe3c0ks5so-rkgaJpZM4PuIqu
.

What browser are you using and is it up to date?

Chrome and I am pretty sure it's up to date.
How can I check?
On Wed, Oct 4, 2017 at 5:34 PM, Sansd20<EMAIL_ADDRESS>wrote:

What browser are you using and is it up to date?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/stolksdorf/homebrewery/issues/508#issuecomment-334296213,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AfBM56WXEI_I-VDuB0QQtCeMZsrA_HgRks5so_nRgaJpZM4PuIqu
.

Let's see... I'm able to get a PDF just fine. What browser are you using?
Have you been able to create PDFs before?
On Wed, Oct 4, 2017, 3:53 PM Pecclest<EMAIL_ADDRESS>wrote:

http://homebrewery.naturalcrit.com/share/S1m1yJyln-
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/stolksdorf/homebrewery/issues/508#issuecomment-334270373,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFmzBmXKIQ_Np2B-jTe4Z0kUpWIyThutks5so-JEgaJpZM4PuIqu
.

I've been able to create pdfs before, in fact I tried to make a pdf for
another file and I could do that fine.
On Wed, Oct 4, 2017 at 6:36 PM, Trevor Buckner<EMAIL_ADDRESS>wrote:

Let's see... I'm able to get a PDF just fine. What browser are you using?
Have you been able to create PDFs before?
On Wed, Oct 4, 2017, 3:53 PM Pecclest<EMAIL_ADDRESS>wrote:

http://homebrewery.naturalcrit.com/share/S1m1yJyln-
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<https://github.com/stolksdorf/homebrewery/issues/
508#issuecomment-334270373>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFmzBmXKIQ_Np2B-
jTe4Z0kUpWIyThutks5so-JEgaJpZM4PuIqu>
.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/stolksdorf/homebrewery/issues/508#issuecomment-334309458,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AfBM5zbHkMXkXvpjMKA41cgrDOII45SUks5spAh0gaJpZM4PuIqu
.

Don't know wheather this is connected or not but for some reason when I try
to change the text/pictures on pgs-10 t0 20  the document doesn't react
PLUS there seems to be a missing page of text between what the document
says are 9 and 10.
On Wed, Oct 4, 2017 at 6:36 PM, Trevor Buckner<EMAIL_ADDRESS>wrote:

Let's see... I'm able to get a PDF just fine. What browser are you using?
Have you been able to create PDFs before?
On Wed, Oct 4, 2017, 3:53 PM Pecclest<EMAIL_ADDRESS>wrote:

http://homebrewery.naturalcrit.com/share/S1m1yJyln-
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<https://github.com/stolksdorf/homebrewery/issues/
508#issuecomment-334270373>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFmzBmXKIQ_Np2B-
jTe4Z0kUpWIyThutks5so-JEgaJpZM4PuIqu>
.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/stolksdorf/homebrewery/issues/508#issuecomment-334309458,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AfBM5zbHkMXkXvpjMKA41cgrDOII45SUks5spAh0gaJpZM4PuIqu
.

Wherever the problem is it's located in the paladin pages! Every time I cut
and paste the paladin pages back into the doc, the print preview that shows
what you are doing to the doc freaks out!
On Wed, Oct 4, 2017 at 6:36 PM, Trevor Buckner<EMAIL_ADDRESS>wrote:

Let's see... I'm able to get a PDF just fine. What browser are you using?
Have you been able to create PDFs before?
On Wed, Oct 4, 2017, 3:53 PM Pecclest<EMAIL_ADDRESS>wrote:

http://homebrewery.naturalcrit.com/share/S1m1yJyln-
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<https://github.com/stolksdorf/homebrewery/issues/
508#issuecomment-334270373>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFmzBmXKIQ_Np2B-
jTe4Z0kUpWIyThutks5so-JEgaJpZM4PuIqu>
.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/stolksdorf/homebrewery/issues/508#issuecomment-334309458,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AfBM5zbHkMXkXvpjMKA41cgrDOII45SUks5spAh0gaJpZM4PuIqu
.

Ok, I figured it out. Apparently there was a misplaced /div tag that was
screwing everything up. It works fine now! Thanks for the Help!
Peter
On Wed, Oct 4, 2017 at 6:36 PM, Trevor Buckner<EMAIL_ADDRESS>wrote:

Let's see... I'm able to get a PDF just fine. What browser are you using?
Have you been able to create PDFs before?
On Wed, Oct 4, 2017, 3:53 PM Pecclest<EMAIL_ADDRESS>wrote:

http://homebrewery.naturalcrit.com/share/S1m1yJyln-
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<https://github.com/stolksdorf/homebrewery/issues/
508#issuecomment-334270373>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFmzBmXKIQ_Np2B-
jTe4Z0kUpWIyThutks5so-JEgaJpZM4PuIqu>
.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/stolksdorf/homebrewery/issues/508#issuecomment-334309458,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AfBM5zbHkMXkXvpjMKA41cgrDOII45SUks5spAh0gaJpZM4PuIqu
.

Duplicate of #655


Using with VS 2019/22

Required Info

Camera Model
D435

Firmware Version
<IP_ADDRESS>

Operating System & Version
Win (10)

Platform
PC

SDK Version
2.32

Language
C++

Segment
desktop app

Issue Description
I'm getting back to a realsense project after a year and I am using vs 2019 or 22 (i have only  2015 and the 2017 costs a large fee).
I see that the directions for using the SDK suggest 2017. I tried with 2019 and I'm immediately  getting a few errors  when building. Should the SDK work out of the box using VS 2019 or 22 with  cmake and SDK 2.0?
Thanks.

Hi @arothenberg  As far as I am aware, VS 2015 is still the minimum supported Visual Studio version for the RealSense SDK.  Current official documentations such as those for the C# wrapper and installing the SDK on Windows from source code state support for it.
https://github.com/IntelRealSense/librealsense/tree/master/wrappers/csharp#with-cmake-and-visual-studio
https://github.com/IntelRealSense/librealsense/blob/master/doc/installation_windows.md
If you plan to use VS2019 then the starter project in the link below that was contributed by a RealSense user may be a helpful reference for avoiding errors such as LNK2019
https://github.com/EduardoWang/visual-studio-real-sense-record-and-playback-project
I have not yet seen any cases of the SDK being used with Visual Studio 2022.

Thanks. I'll use Eduardo Wangs project and directions as a template. If I have more trouble I'll check in.
TYVM.


ci: build release with WAVM.

Signed-off-by: Piotr Sikora<EMAIL_ADDRESS>

Create an issue for the SEGV?


[es6][1.a.browser echo] Updated botbuilder-core version

Proposed Changes

Since this sample is using a version of the botbuilder-core package that doesn't exists anymore, the installation fails when running npm i.
The version found in the package.json has been updated to ^4.0.6

@VictorGrycuk @dfavretto updated PR


added <, >, <=, >= operators

When people compare objects they often use operators like == and <. However, using > results in the following error: Error: undefined method '>' for CSUUID. The same happens with <, >= and <=.
This PR implements these four operators.
Edit: I just noticed that #<=> was implemented to make CSUUIDs sortable and now I'm not sure if there is even a need for these four operators implemented in this PR?

I do not see any downside to having them all defined, right now. And yeah, I am leveraging these UUIDs heavily in the OpenTelemetry work that I am doing, and I realized yesterday that they weren't sortable/comparable at all.  Oops.  So, nice serendipitous timing there with your PR!  :)
The CI failed, but just like the other PR, it was because of permissions related to the gh-pages. The specs are all fine, so I am merging.


Java 8

Hi Team,
The latest build seems to be only working on java 8. is it intentional or by mistake.
Can i assume going forward all builds will be on java 8 only.
BTW just so you are aware. We package and make available classyshark in AndroidTamer as well as  on androidtamer debian compatible repository "https://repo.androidtamer.com/"

Yes, we are gradually moving to Java 8,  if this is a problem I can build and upload Java 7 compat

Thanks for the confirmation. Should not be a problem. Debian has java 7 default so just need to tweak my launcher scripts to ensure we are launching this via java 8. Thanks for the headsup i will update the script and will push this out for everyone.
as always thanks for the wonderful work.

Sure, you can happily change the source config here (https://github.com/google/android-classyshark/blob/master/ClassySharkWS/build.gradle) to 1.7 and rebuild (by calling "gradle fatJar" from the command line)


Missing BaseGameEntity methods CanTurn, CanJump

Installing in 1.77d2

I won't go backward for it, just delete codes that use those methods.


Fix transport_secure_sockets unit test build

Fix unit test build of transport_secure_sockets by updating the include path build configuration to use tests/unit_test/config_files as directory for locating logging_stack.h file.
A duplicate logging_stack.h file at tests/unit_test/logging_stack location has been deleted in #2669
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/bot run checks


[HOLD for payment 2021-11-04] Clicking on the empty area right to the view details opens the IOU details page - @parasharrajat

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel! https://www.upwork.com/jobs/~01e19e81afbed9cb10

Action Performed:

Navigate to a conversation
Request money to the user
Click on the empty area next to the IOU message in conversation

Expected Result:
Empty area should not be clickable. Only link in the message information should be clickable.
Actual Result:
Empty area is clickable and it's opening the IOU details page.
Workaround:
None needed.
Platform:

Where is this issue occurring?

Web
iOS
Android
Desktop App
Mobile Web

Version Number: 1.1.7-0
Reproducible in staging?: yes
Reproducible in production?: yes
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://user-images.githubusercontent.com/44479856/136849449-c7cc3e15-0489-4d7b-9b7e-1c4de66ac69c.mp4
Expensify/Expensify Issue URL:
Issue reported by: @parasharrajat
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1633845715067400
View all open jobs on GitHub

Triggered auto assignment to @laurenreidexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

https://www.upwork.com/jobs/~01e19e81afbed9cb10

@chiragsalian Let's get this rolling. Please

Issuing payment for bug report + deploy to @parasharrajat now


Provide the @id annotation from the CLI as a library feature

Category
User level API changes
Describe the feature you'd like to request
The Cedar language provides a general purpose annotation feature, allowing users to annotate policies w/ arbitrary key/value pairs, and consumers of policies can use these however they want.
The Cedar CLI uses this in a very nice way to let you assign policy IDs to policies via annotations:
@id("myid")
permit(principal, action, resource);

This is a nice feature, and we should make it easy for other consumers of the Cedar library to use, instead of needing to re-roll it themselves.
Describe the solution you'd like
Take the function from Cedar CLI that renames policies according to @id annotations, and move into the Cedar library and expose it.
Describe alternatives you've considered
The alternative is not doing this. We don't enforce any semantics over annotations, and we may not want privilege certain interpretations.
Additional context
No response
Is this something that you'd be interested in working on?

[X] 👋 I may be able to implement this feature request
[ ] ⚠ This feature might incur a breaking change

Do you think this feature merits a RFC?

I don't think so. It's not an addition to the language or change to any specs, it's just a utility functions for users.
To be clear, annotations should still have no official semantics. Users should still be able to user them any way they want, this is just providing a common use-case.

What would the API for this new feature look like?
I feel like we don't want to assign special semantics to any annotations in the core library. But I can see how it would be useful to provide some simple examples of this for users (e.g., in the cedar-examples repo).

I imagine the API would look like it does in Cedar CLI:
/// Renames policies and templates based on (@id("new_id") annotation.
/// If no such annotation exists, it keeps the current id.
fn rename_from_id_annotation(ps: PolicySet) -> PolicySet

I understand not wanting in the Cedar SDK proper, to avoid asserting special semantics for specific annotations. If  we go this route, I'd at least like it to be an easily accessible example.

Closing because we don't want to enforce semantics on annotations.


Question / feature request: bypass webhook on selected deployments

Not sure if that feature exists already and I'm not aware of it, or if it's something that could be added.
I'd like to be able to annotate my deployments in a way that makes the webhook ignore them.
My namespace is properly configured with a namespace selector and the webhook tries to inject secrets into all deployments. In my case, a few deployments do not have secrets and I'd like to bypass the webook, with something like vault.security.banzaicloud.io/skip=true.
Is that currently possible? If not, can it be added?

@maciejqantas The webhook only mutate the pods which are annotated with vault.security.banzaicloud.io/.... If you don't annotate the pod templates, the webhook won't mutate it.

Thanks @pbalogh-sa.
Just to make sure I follow - the webhook kicks in if the pod spec has environment variables whose values use the vault:path/to/secret#attribute value, correct?
if that's the case, I would still like to disable the webhook for a given pod. I have an unusual use case where I still have env vars pointing to secrets in my pod, but I do not wish to read them from vault.

@maciejqantas TThis makes sense. We will figure out how we can implement it. I think the best way would be using the objectSelector in the mutatingWebhookConfiguration, but this feature is only reachable above version 1.15 of kubernetes.

If we use the objectSelector, we will just set a proper label in the pod we don't want to mutate.
You can edit the deployed mutatingWebhookConfiguration and put the objectSelector to the webhook section in the case of version 1.15 of kubernetes. And after it, you can label your pods and the webhook won't trigger.

We will definitely implement this feature.

thanks a lot @pbalogh-sa!
is there any option for an implementation working on 1.14? I'm running k8s on EKS and 1.15 is not available there yet.

@maciejqantas You can use namespaceSelector in mutatingwebhookConfiguration but maybe it doesn't fit your current needs. There isn't a quick fix for a more sophisticated selection.

@pbalogh-sa it does not, sadly. It needs to be a deployment within an otherwise vault-enabled namespace.
I've worked around it for now. Looking forward to the target solution :)

We considered solutions in the case of k8s version below 1.14 and we didn't find a good one.  If we use annotations in pod templates, the mutatingWebhookConfiguration will send the podSpec to the webhook in this case as well, so the real skipping won't happen. The only proper way in our opinion to use namespaceSelector for skipping mutation in this case.


Enable late OME via an experimental flag

Experimental flag to test late OwnershipModelElimination in place of -enable-ossa-modules to temporarily workaround lack of caching leading to repeated recompile of stdlib with -enable-ossa-modules

@swift-ci smoke test

@swift-ci smoke test windows platform

@meg-gupta do you plan to change the two unit tests that use -enable-ossa-modules in a different PR?

@atrick Yes, I'll just create a new PR for that.