[Bug] direct set app.ext.config not working

Describe the bug
set template search pathes via
app.config.TEMPLATING_PATH_TO_TEMPLATES = xxx
# OR
app.ext.config.TEMPLATING_PATH_TO_TEMPLATES = xxx

not working, sanic just use default templates dir
exception log
Traceback (most recent call last):
  File "<frozen importlib._bootstrap>", line 991, in _find_and_load
  File "<frozen importlib._bootstrap>", line 975, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 671, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 843, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/Users/chendx/xxx/server/__init__.py", line 1, in <module>
    from .app import PigaiZiApp
  File "/Users/chendx/xxx/server/app.py", line 2, in <module>
    from .demo_handler import *
  File "/Users/chendx/xxx/server/demo_handler.py", line 8, in <module>
    @app.ext.template('demo.jinja2')
  File "/Users/chendx/anaconda3/envs/pigai/lib/python3.8/site-packages/sanic_ext/bootstrap.py", line 151, in template
    return self.templating.template(template_name, **kwargs)
  File "/Users/chendx/anaconda3/envs/pigai/lib/python3.8/site-packages/sanic_ext/extensions/templating/engine.py", line 30, in template
    template = self.environment.get_template(file_name)
  File "/Users/chendx/anaconda3/envs/pigai/lib/python3.8/site-packages/jinja2/environment.py", line 883, in get_template
    return self._load_template(name, self.make_globals(globals))
  File "/Users/chendx/anaconda3/envs/pigai/lib/python3.8/site-packages/jinja2/environment.py", line 857, in _load_template
    template = self.loader.load(self, name, globals)
  File "/Users/chendx/anaconda3/envs/pigai/lib/python3.8/site-packages/jinja2/loaders.py", line 115, in load
    source, filename, uptodate = self.get_source(environment, name)
  File "/Users/chendx/anaconda3/envs/pigai/lib/python3.8/site-packages/jinja2/loaders.py", line 197, in get_source
    raise TemplateNotFound(template)
jinja2.exceptions.TemplateNotFound: demo.jinja2

Additional context
I check the sanic_ext source code, before custom config been set, the template extend has been inited.

Do you have a snippet of where you are setting the config? It is a bit order-dependent.

I cannot recreate this.
from sanic import Request, Sanic

app = Sanic(__name__)
app.config.TEMPLATING_PATH_TO_TEMPLATES = "/tmp/custom"

@app.get("/")
@app.ext.template("index.html")
async def handler(request: Request):
    return {"seq": ["one", "two"]}

This works for me as expected.


Build issues using cmake under windows from a clone

Summary
It seems impossible to build for windows when using a clone from github using cmake.  Because the clone doesn't include the normally auto-generated files like "error.c".  Apparently they don't get autogenerated for Windows so, not being in the clone means you can't build from the clone.
System information
Version 3.1.0
Windows 10
Visual studio 2022.
Expected behavior
It should be possible to clone the project and build in windows.
Actual behavior
When you clone the repo, create a "build" folder then use cmake to build, cmake fails because it's looking for error.c version_features.c, ssl_debug_helpers.c/h in the library folder.  These files are specifically  ".gitignored" from the repo.
Steps to reproduce
1 - Clone into a folder.
2 - Create a new folder called "build" in this folder
3 - enter build them "cmake
Cmake will error saying error.c is missing.
Additional information
Maybe include the autogenerated files needed for windows in a Windows specific folder instead of the library folder (the way the ZIP does it) and have cmake copy them into the library folder each time cmake is run. Then if the build folder is deleted, the next run of cmake can just copy them into place again.  In that way, you could keep these files in the git so they could be included when cloned without keeping them in the library folder.

Release zips include those generated files, but the git repo doesn't. It was too annoying to keep them updated so we stopped committing them.
cmake -DGEN_FILES=ON should do the generation. Note that Perl and Python must be available.
I agree that it would be good if this worked out of the box. I don't remember why GEN_FILES defaults off on Windows specifically — I guess because Windows doesn't come with the necessary tools, but if the tools are needed, they're needed.

Thanks for the comment.
One other issue with the zip build environment is the supplied C files are hard linked into the build folder by cmake so, if you delete the build folder, it deletes the C files in the library folder too.   Basically deleting the build folder mean you have to re-unzip the project because the normally generated files aren't there any more.
I was thinking a soft link instead of hard would prevent this.
I'll try -DGEN_FILES here.

Why have you removed that files from the repository?
error.c
version_features.c
ssl_debug_helpers_generated.c
psa_crypto_driver_wrappers.c

GEN_FILES is disabled on Windows by default.
Perl on Windows is a rare tool.

I have to use  the development branch because the release branches can't compile on Windows UWP due to the use WIN32 specific function lstrlenW(). It is fixed on the development branch, but is not backported onto 2.28.2.


Feature request : Debounce the scrollListener

Hi,
I've passed some time trying to update the orginal react-infinite-scroller and shame on me, I didn't see your fork.
I ended making some improvements on the original script (the one your forked), but the most efficient change I did was to debounce the position checking and loadMore things. I've adapted to my needs, hope it's readable.
The idea is very simple :

in the constructor, you set a this.debounceTimeout to null
in the scrollListener you check if this.debounceTimeout is null. If yes, you set it to a setTimeout(load_more_if_needed, 250), if not you just pass your way.

As a window.addEventListener("scroll", this.scrollListener); will fire scrollListener a lot of time, and very fast, it's gonna do some calculations all the time. it's better explained there.
I don't have time and enery to make a pull request from your fork, sorry.

Please see https://github.com/CassetteRocks/react-infinite-scroller/issues/22

Agree to @danbovey , it has to be done on the top level components. One idea is to use CancelTokens (in stage-1) now.
For example, axios supports this feature, see here


Blueprints - podModulePrefix and pods

The existing blueprints section covers the differences between classic and pods apps as related to blueprints. podModulePrefix is mentioned without a definition or reference.
Since pods are still used I wanted to link podModulePrefix back to its definition.  It's defined in a section of the user guide that we have't brought over.  The question is how do we handle pods in the new guides?
Until module unification lands, pods are still viable and I think we should include something.  There's not a lot of content on pods in the old guides, so it's more than just copying the old content. There will be some rewrite.
I'd think a short section in Advanced use would be the appropriate location.  I opened the issue for discussion

Sounds good to me.


Easier Bootstrap Grid usage and basic BS4 compatibility

Reasons for making this change
I really would like to be able to use the almost stock react-jsonschema-form, but there just needs to be a way to play nice with bootstrap.
since we already lean more towards bootstrap than material, I added a custom "object" option in the schema to produce bootstrap rows inside the normal object fieldset
Checklist

[X] I'm updating documentation

[X] I've checked the rendering of the Markdown text I've added
[X] If I'm adding a new section, I've updated the Table of Content

[X] I'm adding or updating code

[X] I've added and/or updated tests
[X] I've updated docs if needed
[X] I've run npm run cs-format on my branch to conform my code to prettier coding style

[X] I'm adding a new feature

[X] I've updated the playground with an example use of the feature

I did run cs-check and everything passed on my PC, so please don't not use this PR just because of that

fwiw, I'd appreciate basic BS4 support too. Thanks for the work!

@troyconquer if you're using BS4, i've been using my fork in production without issues. at least until they implement it

Maybe it's just me, but it seems almost rude to leave all these pull requests open for so long. It's been sitting long enough that I actually don't know if my code is even relevant anymore. why not just close it if your never going to merge it?
I also may just be butthurt that my effort fell on deaf ears and got 0 response from maintainers.
anyways, I'm just gonna close it since I don't really want to put more time into fixing merge conflicts if nothing's gonna happen

Hey @SampsonCrowley, I'm deeply sorry for the silence here. Just so you know, I've left Mozilla and I won't be writing React code anymore for a little while, so this project is most likely to be actively maintained by other people at Moz, who are very busy on other fronts and have no much time to dedicate supporting use cases they don't have (upgrading to BS4 is one of them as far as I know).
Maybe @glasserc has more information about these aspects.

thanks @SampsonCrowley .
Yeah, this lib is great. Would be nice to know a secure maintenance plan.
Have a good day.

Hi! Yes, as you have no doubt inferred, the maintainership for this library is quite anemic. If there's anyone who should be maintaining it, it should be me, so I apologize for that. However, I can't really promise that things will be any different going forward. Even when @n1k0 was still on our team, this library already did everything we needed it to -- namely, to fit into kinto-admin and handle the relatively simple schemas we used it for. In other words, this library was mostly in maintenance mode for us, and we didn't envision adding massive new features or breaking new theoretical ground with it. My manager is OK with me spending some amount of time answering issues and reviewing PRs, but we have other priorities too. I try to spend a day each week catching up on rjsf emails but to be honest, Node/JS/React isn't my favorite ecosystem and I've avoided opening those emails for a few weeks now. I'd hoped that another motivated contributor would step up as a maintainer but I understand that my own lackluster participation probably doesn't encourage that. All of which to say, no, I haven't even looked at this PR, for which I'm again sorry.
I noticed that this PR is related to #91, #99, #125, #237, #287, #299, #440, #461, #546, #555, #626, and maybe others, but especially #555. There's been a recurring desire for rjsf to support different UI libraries, but what exactly "support" means hasn't ever really been very clear. It's relatively easy to modify the rjsf code to support whatever library or CSS framework a user has in mind, but coming up with a maintainable API that allows a user to plug in their own CSS framework is a bit harder, and I haven't seen any PRs that do that. Our dependency on Bootstrap right now is relatively light, and I'm hesitant to strengthen that dependency too much while there are clearly users who would rather the use of Bootstrap be completely optional. On top of that, perhaps it's just me, but I'm hesitant to move to Bootstrap 4 until it's out of beta.
I really don't like the idea of a bootstrap type, since it doesn't conform to JSON Schema. I don't think a CSS framework should or even can be defined by the definition of an ObjectField replacement -- how do you handle ArrayField s? what happens if the implementation of ObjectField changes from underneath you? The good news is that if you really do want to use this approach, you don't have to have anything merged upstream, because you can override the ObjectField implementation in your own project. I wouldn't want to merge anything along these lines unless I thought it could support any of the different CSS libraries without my having to do any work. Making something that generic would probably benefit from coordination among all the users who want this feature.
I understand your frustration with having to continually rebase onto master. To be honest, I'm surprised we've even had as many PRs merged as we have. I'm sorry your experience has been so bad and I hope your future experiences in open source are better.

A different PoW: we selected react-json-schema for our projects because

we lack manpower on our opensource projects on the frontend
react-json-schema worked for us really well and we evaluated it as probably the best lib of its kind out there
Mozilla was behind this, which we took as a bit of a guarantee that the project won't be abandoned that easily.

With bs4 move to beta and v-4-beta-2 imminent, we wan't to move on to bs4 for several reasons ASAP, so reading through this issue is somewhat disappointing. While I understand that @n1k0 and @glasserc can't do too much about it, I'm still looking at you, Mozilla. Leaving a project in a state when it cant accept PRs from guys like @SampsonCrowley is frustrating and Mozilla should know better on how to handle such situations - either shepherd the project onwards or gradually open it up to others so that they can gradually step in and do the work :(
Not to keep this post in the rant realm ... @glasserc , is there a way Mozilla can pour some energy at least temporarily to the project to at least have a BS4 branch and BS4 releases? Did you try / is it possible to have more people accept PRs (even if they are outside Mozilla)? While having BS optional would be great, could you still reconsider investing energy into a quick BS4 supporting release to at least create a stepping stone which will ensure this project's relevancy for the feature?

I guess you are misunderstanding how Mozilla works :)
All the work we do at Mozilla is open source so we don't choose to release a lib or not, we code it out in the wild, document it, add tests, make it as reusable as possible and then we maintain it for our use case until we don't need it anymore.
We are always happy to add new collab and if your company want to hire some people to add the feature you are lacking feel free to do it, it will be a great contribution. Or you can also wait until someones else takes the torch but never take the assumption that it is the creator of the project responsibility to take care of everything you need.
That's how OpenSource works. Mozilla Corporation missions is not to maintain open source projects it is mainly to develop a great browser and to do so in the open.

I saw a post from Rémy but I guess he deleted it, which is probably good because it isn't really relevant to what I want to say on the subject.
To make a long story short, I would love to have more contributors to rjsf. I think @olzraiti and @knilink would be excellent candidates for maintainers, for instance. I'm a little anxious about adding almost anyone as a maintainer to the project because Mozilla does still use rjsf (in https://github.com/Kinto/kinto-admin/) and so we have a certain investment in maintaining the status quo. On top of that, I've done a pretty bad job of "growing" random users into contributors and then into maintainers, as I said above (for which I'm sorry).
Part of the problem is that rjsf seems to have attracted a large amount of interest from React developers (which I guess means @n1k0 did something very well) but not all users share the vision we do for this library. I'm only guessing based on the kinds of issues that I see, but many users seem to believe that this library is meant to handle generating any kind of form that you might want in React. (See #641 for a random recent issue of this kind -- not to single that person out, this is representative of a whole class of issues.) rjsf really only cares about automatically generating forms from a JSON Schema, possibly with some additional UI-specific information.
Another part is that even with this stated objective, rjsf falls quite short -- there are some major JSON Schema functionalities that we never got to implement and are kind of shameful. (#52 is the one I'm thinking of at the moment.) So even if you do share our vision, there's a good chance you won't build on rjsf because we don't support the things you need.
Finally, I feel that actually changing rjsf at this point is quite challenging. I'm not sure exactly why this should be -- maybe rjsf has grown too complex, or maybe the JS ecosystem is too complicated, or maybe React is simply too difficult to write something generic in. The net effect is that some contributors show up and start a PR that has a lot of potential, but when I review it seriously, there are problems with it, and perhaps the contributor gets discouraged or distracted, but the PR never gets finished. https://github.com/mozilla-services/react-jsonschema-form/pull/417, https://github.com/mozilla-services/react-jsonschema-form/pull/682, and https://github.com/mozilla-services/react-jsonschema-form/pull/659 are good examples of this category. This is unfortunate and doesn't help grow the rjsf "community".
I would love to have ideas on how to fix all of the above, but again, I can only do so much on this project each week. And, more generally, Mozilla has limited resources too and has to prioritize its efforts to protect the free and open web.
As for supporting Bootstrap 4, upgrading a major version of Bootstrap is kind of a breaking change in this library. If we are going to make such a breaking change, I'm not sure why Bootstrap 4 should be the library we should go with. We have issues requesting support for ant, Foundation 6, and Material. Why shouldn't we go with one of those instead? It seems like this is a decision that some rjsf users want to be able to take on their own. As a result, what I really want to see is a PR that adds "pluggability" to the UI library that rjsf uses, so that other people can maintain Ant, Foundation 6, Material, Bootstrap 4, or whatever support without having to bother us, and users can choose according to their projects to use any of the above. But nobody has stepped up to write such a PR yet, and like I said, I can't really spare the time right now.
I know this doesn't really lead to an encouraging conclusion, but what I really want you, dear reader, to take away from this is that this project is a great place to get involved. I'm extremely motivated to help developers achieve maintainer-level competence and responsibility, although my time is limited. There are well-known gaps in functionality that could use your clever solutions. Tons of developers would use your code. And isn't that enough reward for anybody? 🤣

One option would be for Mozilla to keep a stable maintenance branch on rjsf project.
For example there could be version 1.x maintenance branch and new development goes to master as version 2.x, 3.x etc. Mozilla has the option to adopt version 2.x / 3.x if it is beneficial for them.

@glasserc as for BS4, Foundation, Ant and Material ... instead of trying to figure out an API, wouldn't branching/splitting the project be the easier, albeit not very elegant way to go? As for the case for BS4: While ant, Foundation and Material are great and IMO render more beautiful output, I personally always default to BS because its the defacto standard. Even without any meaningful js/css skills, I can couple BS with most libraries out there and prototype quickly something meaningful and consistent looking.

As for supporting Bootstrap 4, upgrading a major version of Bootstrap is kind of a breaking change in this library. If we are going to make such a breaking change, I'm not sure why Bootstrap 4 should be the library we should go with. We have issues requesting support for ant, Foundation 6, and Material. Why shouldn't we go with one of those instead? It seems like this is a decision that some rjsf users want to be able to take on their own. As a result, what I really want to see is a PR that adds "pluggability" to the UI library that rjsf uses, so that other people can maintain Ant, Foundation 6, Material, Bootstrap 4, or whatever support without having to bother us, and users can choose according to their projects to use any of the above. But nobody has stepped up to write such a PR yet, and like I said, I can't really spare the time right now.

I agree here, upgrading to Bootstrap would be a major breaking change (for me, for instance :). A plugin feature would be great. Fortunately, we already have that feature. After(/If?) #653 gets merged (will likely finish that PR this week), all HTML hard coded stuff can be overridden. We could either provide the themes in this library or ask people to create plugin repositories.
If we provided the themes, it could look something like this:
[src/components/Form.js]

...

    const themes = {
        bs4: {
            widgets: [
                [bs4 specific widgets],
                ...props.widgets // These overriding arrays will default to [] - you know the drill. I'm trying to make this look simple here. They are needed to make the widgets/fields/templates overridable even when we have a theme.
             ],
            fields: [
                [bs4 specific fields],
                ...props.fields
             ],
            TemplateField: [
                [bs4 specific field template],
                ...props.TemplateFIeld
             ],
            ArrayFieldTemplate: [
                [bs4 specific array field template],
                ...props.ArrayFieldTemplate
             ],
            ObjectFieldTemplate: [
                <bs4 specific object field template>,
                ...props.ObjectFieldTemplate
           ]
        },
        <other themes>: {
            ...you get the idea
        },

    }

    <Form
        {...themes[props.theme]}
    />
}

If we encouraged users to create plugin repositories, they would be very easy to write in similar style:
import Form from 'react-jsonschema-form';

    // Form with BS4 style
    <Form
        { {
            widgets: [
                [bs4 specific widgets],
                ...props.widgets
             ],
            fields: [
                [bs4 specific fields],
                ...props.fields
             ],
            TemplateField: [
                [bs4 specific field template],
                ...props.TemplateFIeld
             ],
            ArrayFieldTemplate: [
                [bs4 specific array field template],
                ...props.ArrayFieldTemplate
             ],
            ObjectFieldTemplate: [
                 <bs4 specific object field template>,
                ...props.ObjectFieldTemplate
            ]
        }
    />

Both look pretty simple to write and maintain, yes?
Having the themes in this lib repo has the benefit that they would be curated by seasoned developers who built this lib and/or are maintaining it. That's also the biggest downside, since this lib is apparently having troubles with maintenance resources. For that reason alone if I had to vote, I would vote for encouraging people to create plugin repositories.

I'm in no means an expert on css frameworks @olzraiti, but I believe that overriding classes should be enough as well.

[In order to support both Bootstrap 3 and Bootstrap 4,] One option would be for Mozilla to keep a stable maintenance branch on rjsf project.

That adds to our maintenance burden so I don't think it's likely.

as for BS4, Foundation, Ant and Material ... instead of trying to figure out an API, wouldn't branching/splitting the project be the easier, albeit not very elegant way to go?

Anyone can already do this, and I think some actually do! In #626, there's a link to someone's ant-design based repo. But of course, as our project evolves, fixes bugs, adds features etc., any fork does not necessarily update along with it.

After further consideration, I'm not sure if overriding fields/widgets/templates is a powerful method enough for a proper theming.

I agree, but so far we haven't had any contributor ambitious enough to come forward with a proposal for what they actually need.

it seems there is some confusion as to what I meant when I say BS4 support.
I did not remove BS3 support, I just also added the necessary classes for
the same level of basic layout provided already to work with BS4
On Fri, Sep 29, 2017 at 2:27 PM, Ethan Glasser-Camp <
<EMAIL_ADDRESS>wrote:

[In order to support both Bootstrap 3 and Bootstrap 4,] One option would
be for Mozilla to keep a stable maintenance branch on rjsf project.
That adds to our maintenance burden so I don't think it's likely.
as for BS4, Foundation, Ant and Material ... instead of trying to figure
out an API, wouldn't branching/splitting the project be the easier, albeit
not very elegant way to go?
Anyone can already do this, and I think some actually do! In #626
https://github.com/mozilla-services/react-jsonschema-form/issues/626,
there's a link to someone's ant-design based repo. But of course, as our
project evolves, fixes bugs, adds features etc., any fork does not
necessarily update along with it.
After further consideration, I'm not sure if overriding
fields/widgets/templates is a powerful method enough for a proper theming.
I agree, but so far we haven't had any contributor ambitious enough to
come forward with a proposal for what they actually need.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/mozilla-services/react-jsonschema-form/pull/623#issuecomment-333230624,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AVa8xhHym3IeM5M2NwMBUCVbX7IoFiDZks5snVKegaJpZM4OI1mq
.

Hey guys just wanted to say i think bootstrap 4 support sounds great. Sorry to hear that you're having some maintainer issues, but thanks everyone for pushing forwards with the discussion.


Refactor cherami-admin and cherami-cli code

Basic idea:

Create folder common under cmd/tools, and create lib.go in it to store the common flags and commands used by both cli and admin.
Delete tools/cli/lib.go and move the corresponding functions to tools/common/lib.go. Add a parameter serviceName to these common functions to differentiate cli and admin.
Cherami-cli will just use the common functions and Cherami-admin will use some admin-specific functions in tools/admin/lib.go.

Not sure whether this is the best way to do this, please leave any suggestion whichever you want.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Coverage decreased (-0.4%) to 67.945% when pulling a8246ddd8b080282d2c47f96ce0cc1e759f828c1 on refactor into 51b6724eeb26ec943f9f3e33f3c0fbbfc33fd590 on master.

@kobeyang i just committed PR #246 that will probably cause some merge conflicts for you .. (sorry about that .. :-))

Merge with Kiran's change in PR#246.


Bug Report: ModCore.hx And Main.hx problem

Why does this happends?

do you have every library updated/installed?


Android wakeup from "deep sleep"

After my application is backgrounded for a few hours, if I try to open the application I get the following warnings to the console, followed by the app not rendering at all. We have a number of plugins installed to the application but none of them ever caused us issues in a regular cordova environment. The fact that the application does not draw at all is a huge issue. In the event these errors fire, the app should at least restart itself, even if there is a bit of flicker to the user.
Could not create object "cordova.plugin" (reason: Could not find IOperationDelegate for null)
Could not listen to event "finish" (reason: The parameter 'type' in call ParamCheck.notNull() must not be null)
Could not call method "exec" (reason: The parameter 'type' in call ParamCheck.notNull() must not be null)
Could not create object "cordova.plugin" (reason: Could not find IOperationDelegate for null)
Could not listen to event "finish" (reason: The parameter 'type' in call ParamCheck.notNull() must not be null)
Could not call method "exec" (reason: The parameter 'type' in call ParamCheck.notNull() must not be null)
deviceready has not fired after 5 seconds.
Channel not fired: onCordovaInfoReady

We have no code in the tabris.app.on("resume").
Here is the list of plugins we are using for reference.
com.batch.cordova 1.5.3 "Batch"
com.oauthio.plugins.oauthio 0.2.4 "OAuth.io"
cordova-custom-config 2.0.0 "cordova-custom-config"
cordova-plugin-bluetoothle 4.0.0 "Bluetooth LE"
cordova-plugin-compat 1.0.0 "Compat"
cordova-plugin-datepicker 0.9.3 "DatePicker"
cordova-plugin-device 1.1.2 "Device"
cordova-plugin-dialogs 1.2.1 "Notification"
cordova-plugin-geolocation 2.2.1-dev "Geolocation"
cordova-plugin-globalization 1.0.3 "Globalization"
cordova-plugin-health 0.5.4 "Cordova Health"
cordova-plugin-inappbrowser 1.4.0 "InAppBrowser"
cordova-plugin-intercom 1.1.7 "Intercom"
cordova-plugin-listpicker 2.2.2 "ListPicker"
cordova-plugin-spinner-dialog 1.3.1 "SpinnerDialog"
cordova-plugin-whitelist 1.2.2 "Whitelist"
cordova-plugin-x-socialsharing 5.1.1 "SocialSharing"
cordova-plugin-x-toast 2.5.2 "Toast"

I think the app was been killed while in the background and would now be restarted by the system. The creation of the "cordova.plugin" in the first line of the log happens very early in the app startup. It is the "wiring infrastructure" to communicate with cordova plugins. Why this could not be instantiates is not entirely clear to me.
Did you find a way to reproduce the problem?

After much trial and error I have been able to reproduce it consistently. I have attached the project.

Turn your android to developer mode
Go to developer options in settings
Change background process limit to "No background processes". This expidites the error.
Add tabris android to the project
Deploy the app the phone as normal
App runs without issue
Minimize the app
Open another app
Open another app
Open the running app list (the square button in the bottom right of your phone)
Choose the test app
It should crash with the above errors

It seems to be related to the plugins "cordova-plugin-device" and "cordova-plugin-intercom", but I have not debugged any further to figure out why.
If you have any issues reproducing please let me know.
test2.zip

Its hard for me to debug, but I was able to track it down to this line in the device plugin
channel.waitForInitialization('onCordovaInfoReady');
When I remove this line, it still throws the warnings, but the application continues. I'm sure the implications  of removing this line within the plugin is damning, but it allowed me to narrow down specifically what causes the app to crash. Hope this helps

Thanks for the info. We will investigate the issue.

I was wondering if there was any update on this. It is truly a devastating issue and gap in cordova plugin functionality. Do you foresee a resolution in 1.9?

Not yet but we will look into it for the 1.9 release.

@dested We have looked into the issue with the steps above but couldn't reproduce the crash.
We added the plugin cordova-plugin-device and used the devices dev settings Don't keep activities activated. Opening the app, pressing home (app gets killed) and opening it again from the recents menu (which restarts the app) resulted in a normal start of the app.
Might the problem occur when multiple of the plugins you mentioned above are combined?

Correct, it is not the device plugin alone, it has to have the intercom plugin as well. Were you not able to reproduce it with project I attached and going through the steps? I was able to consistently reproduce it following the steps above with test2.zip project.

@dested Okay i see your point. With the added intercom plugin (1.1.7) i am seeing the following native java error:
Caused by: java.lang.NullPointerException: Attempt to invoke virtual method 'io.intercom.android.sdk.api.Api io.intercom.android.sdk.Bridge.api()' on a null object reference
  at io.intercom.android.sdk.Bridge.getApi(Bridge.java:80)
  at io.intercom.android.sdk.IntercomBridge$1.run(IntercomBridge.java:36)

I have given the following preferences:
  <preference name="EnableDeveloperConsole" value="true" />
  <preference name="intercom-app-id" value="your_app_id"/>

Is there anything else to take care of?

@dested We have tried your example and seeing the following output:

The image was taken on an Android Emulator running Android 7.0 with the latest nightly tabris android cordova platform.

I am running the test2 project on android 6.0 with https://tabrisjs.com/api/v1/downloads/latest/android and getting the errors still.
I want to reiterate that it does not happen the first time around, only after the app has been backgrounded so far that android free's its memory. When it comes back I get the following errors

I do not currently have a 7.0 emulator to test with, but it if is working for you, then the issue may be 6.0 specific.

The good (or bad news): We were able to reproduce the problem on Android 7 with the latest nightly tabris-android.

I have debugged the scenario... A little tricky to attach the debugger when the app process is just about to get restarted... Therefore we have added some more log statements in the 1.9 release to give more information in the Android logcat when exceptions are thrown.
None the less i have narrowed down the problem to the following exception:
Caused by: java.lang.NullPointerException: Attempt to invoke virtual method 'io.intercom.android.sdk.api.Api io.intercom.android.sdk.Bridge.api()' on a null object reference
    at io.intercom.android.sdk.Bridge.getApi(Bridge.java:80)
    at io.intercom.android.sdk.IntercomBridge$1.run(IntercomBridge.java:36)
    at android.app.Activity.runOnUiThread(Activity.java:5849)
    at io.intercom.android.sdk.IntercomBridge.pluginInitialize(IntercomBridge.java:33)
    at org.apache.cordova.CordovaPlugin.privateInitialize(CordovaPlugin.java:58)
    at org.apache.cordova.PluginManager.getPlugin(PluginManager.java:172)
    at org.apache.cordova.PluginManager.startupPlugins(PluginManager.java:98)
    at org.apache.cordova.PluginManager.init(PluginManager.java:87)
    at org.apache.cordova.CordovaWebViewImpl.init(CordovaWebViewImpl.java:116)
    at com.eclipsesource.tabris.android.cordova.TabrisWebView.init(TabrisWebView.java:54)
    at com.eclipsesource.tabris.android.cordova.CordovaPluginOperator.createWebView(CordovaPluginOperator.java:53)
    at com.eclipsesource.tabris.android.cordova.CordovaPluginOperator.<init>(CordovaPluginOperator.java:44)
	... 24 more

The intercom plugin forwards a call to the intercom sdk that is in an inconsistent state. The intercom plugin call is here: https://github.com/intercom/intercom-cordova/blob/master/src/android/IntercomBridge.java#L36

Very very interesting. Can you think of a reason why this would work in a regular cordova application but not a tabris app? Do you feel the bug is in the intercom implementation such that I should post an issue over there?
As a stop gap, do you know of any way I can modify the intercom bridge code to wait a tick to call that method? If so I can simply customize the plugin locally to get past this issue.
I really appreciate your support on this.

@dested I have looked into the plugin a bit but i am actually a little puzzled on where the Bridge class/object(?) that is null would come from.

With the latest nightly build you will see the exception in the android logcat. You could play around with the plugin to try to narrow down the problem or report to them. They could be interested since there sdk can be brought into a state that causes a crash.

I have opened a ticket on their side. Thank you for all the help tracking this down. Moral of the story seems to be that if an exception gets thrown by a plugin in the pluginInitialize phase it crashes tabris, you may want to consider wrapping this in a try catch and bubbling the error up to the javascript console, which would allow the plugin to fail in potentially unexpected ways, but at least the application can continue to run. It's kind of a crapshoot either way really, but it seems more graceful. Im going to go ahead a close this at this point unless they come back with anything that would be meaningful to tabris.
Thanks!

@dested We previously caught exceptions from the pluginInitialize phase and the app continued to work beyond that point as expect. But as mentioned above we now madechanges so that you can actually find the exception in the Android log (not in the dev console as we don't want to expose client specific traces there). Be aware that you app as to be build in debug mode for any output to be logged to logcat.


Server Error 500

I'm getting the following error when loading the tracks of a specific playlist.
An error occurred while communicating with Spotify's Web API.
Details: Server error...
Important: this error occurs only with this concrete show.
Steps to reproduce:
import SpotifyWebApi from "spotify-web-api-node";

async function main() {
  const client_id = ""; // add client id
  const client_secret = ""; // add client secret

  const api = new SpotifyWebApi({
    clientId: client_id,
    clientSecret: client_secret
  });
  const data = await api.clientCredentialsGrant();
  api.setAccessToken(data.body["access_token"]);

  // this line throws an error
  const result = await api.getShowEpisodes("03dvsetYGw4IKbrtRhWPcQ");
}

main().catch(console.error)

Also getting a WebApi error, since today, when communicating with the Spotify Web API. What is going on?

Yes works again for me. Error Message is super weird though.

Can be closed since this is a spotify issue IMO and not a library issue


Improvement: have the MappingTestServer respond with errors

Currently I'm testing a divolte mapping with the MappingTestServer. When I have an error in my mapping which causes a runtime error this is only displayed on stdout. The server returns a regular OK response.
An example of a runtime error: com.fasterxml.jackson.databind.JsonMappingException
This means that currently there is no way to find out whether an error occurred as a client of the MappingTestServer.
Possible solutions:

Respond with an internal server error (500) with the stackstrace
Add error and stacktrace fields to the response. This would allow test cases in which you expect a runtime error and a mapping of some fields.

The MappingTestServer subject to change in upcoming releases, so no real guarantees are provided (hence, it's not in the docs). Nonetheless, this is a small change.
@0xR would you be comfortable having a go at it yourself? In MappingTestServer.java, line 158 is where the actual mapping takes place. If you catch the exception there and modify the response accordingly, you should be good to go.


Fixes issue #6933

Fixes inability to resolve IPv6 addresses on Mac platform.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Why there will never be a _ref at the base of an object.

For whenever this is brought up again, these are the reasons why there will never be a _ref at the base of any object within this particular project.  This post contains logic that will hopefully be referred to from other issues to avoid repeating the same logic in other threads.
For example, we can return something like this:
{
  "a": {
    "_ref": "<someone else's resource id>"
  }
}

When that object is composed, we will recursively add the data from _ref to the object in a.  However, we shouldn't do this:
{
  "_ref": "<my own resource id>"
}

The meaning of the word reference is "something that refers" and I am very hesitant to give the word special meaning for our particular project.  That is, it shouldn't suddenly change from representing "that guy over there" to "who I am" because of its position in an object tree.

Reference:
a :  allusion, mention
b :  something (as a sign or indication) that refers a reader or consulter to another source of information (as a book or passage)
c :  consultation of sources of information

In a RESTful API, GET <--> PUT is supposed to be commutative in that putting something somewhere should mean that getting the exact same uri should give the exact thing you put there, and vice versa.  There are multiple places you could get the same information from, and assigning a ref into the data means you can't save to multiple places without modifying the data each time (i.e., versioning, publishing, etc.).

Having a _ref means that you are pointing somewhere else, and that anything in that ref object means that it is someone else's data.  Having a _ref at the base is implying that the entire object is someone else's data.  Unless you're trying to create an exception?

Having a _ref at the base of an object means that you can easily PUT an object with a base-level  _ref to a uri that doesn't match; we often PUT to multiple places because of publishing and versioning, and having the uri in the data means we have to edit the data each time we were to do that.  Performing a simple diff between objects becomes a multiple step process.  Having an object at a certain uri with a base _ref pointing to a different uri sounds like a debugging nightmare.

Having a ref at the base of an object means that all of the code that does recursion on our objects will have to be rewritten.  This includes how we do composition, how we create new pages, and how we publish data.  It would have to be rewriten to ignore the first level of data and then start the recursion, which considering that most of our objects are only a single level or two levels deep, would do terrible things to our performance.  For scale, that's about 60% of byline-core's codebase.

These arguments were originally posted here:  https://github.com/nymag/byline-editor/issues/89
This Issue is referenced in our routing documentation.

As an addendum, the _self exposed to composed pages will always be the URI of the thing being requested. This means a few things:

GET /pages/:id.html will expose the page's URI
GET /components/:name/instances/:id wil expose the component's URI

This is the reason why the data-uri in root elements of our layouts is the page URI when requesting a composed page and the layout component's URI when requesting the layout itself.


Running into a "too many requests error" - code 429 since move to v4 API

Hi, I do have 5 location I want to request information from. All of them require daily and real time information (but in intervals of 15 min or 60min) and one which requires realtime (every 15 min), daily (every 3hours) and hourly (every 15 min).
In HA I get a 400 and 429 error.
Details from log view:
Logger: custom_components.climacell.data_provider
Source: custom_components/climacell/data_provider.py:235
Integration: Climacell weather (documentation)
First occurred: 9:39:16 (5 occurrences)
Last logged: 9:39:17

ClimacellTimelineDataProvider._retrieve_data error status_code 400
ClimacellTimelineDataProvider._retrieve_data error status_code 429

Is there a chance to put some delay between the requests? Or whatever is required? Thank...

The issue might have come by me configuring and trying again, or it might have come as some data could not be retrieved and the component tried again.
After reading some other issues, I noticed, that some field names changed or disappeared, causing no data for any field in one request being returned. I corrected that (trial and error a bit), now I can receive all data.
It would be great, to get a list of available fields. Somehow the field naming in the component vs climacell API differs (WindSpeed vs wind_speed) at least in some fields and it is unclear to me in which I can use the Climacell name and in which I have to use a different name.
Anyway, this is great work and many thanks for your dedication and work!!!!!

I noticed, that some field names changed or disappeared.

You do realize the API completely changed right?

It would be great, to get a list of available fields.

https://docs.climacell.co/reference/data-layers-core

Yes, I do. And my question still sticks as the documented fields in the API are not (always?) aligned with the required yaml field specification.
E.g api says „WindSpeed“, integration example uses „wind_speed“.
Or can I always use the API field specification and it would also work defining „WindSpeed“ in yaml?


Add react three fiber

This PR adds react three fiber as a nusight dependency, and demonstrates its utility in a storybook.
It takes advantage of React's JSX, providing us a declarative language to describe threejs scenes.
I'm pretty convinced its superior to our current implementation is nearly every way, but the real proof will come when we rewrite the various components that use threejs (e.g. vision and localisation). I'm pretty confident it will simplify a lot, and that we should be able to maintain similar performance. See #938 for a previous attempt at porting vision.
Electing to keep this PR as minimal as possible for now.

Exciting!


UI for resume

Hey @marineb do you want me to handle the conflicts?

@HeahDude No, it's ok, I'm resolving them right now! I'll send it to you for review when it's ready!


Add new display GDEY073D46, 7 colors, 800*480 pixels

[x] Add the new class in a new branch, based on GOODISPLAY smt32 example
[x] Test it
[x] Ask for a code review
[x] Merge it in develop/master
[x] Added in Wiki https://github.com/martinberlin/cale-idf/wiki/Model-color-gdeh0154z90.h

Display URL:  https://www.good-display.com/product/442.html

Merged in master

Any idea what driver IC this uses?

Hi @tannewt
Absolutely no clue. Not mentioned anywhere in Datasheets or their webpage. You will have to ask them.
I don't really care because even if they say what model is usually does not help much, except that you get a datasheet with more detailed SPI commands. That also don't help much without a proper example.


Check command to check open modmails, people with no names, double names, open manual verifications etc.

Command to check and display open modmails, people with no names, double names, open manual verifications etc.
Possibly with links/mentions and ids.

Command to see open manual verifications already implemented


Create a function to hide/show a page loading overlay

Helpful for #91

This is no longer needed given how fast our typical page loads now.


Segmentation fault when running char_lstm tutorial in mxnet-notebooks

For bugs or installation issues, please provide the following information.
The more information you provide, the more likely people will be able to help you.
Environment info
AWS EC2 Instance
Instance type: p2.xlarge
Tried this on AWS Deep Learning AMI Ubuntu 1.5, AWS Deep Learning AMI Ubuntu 1.4 and also on a bare Ubuntu 14.04 AMI.
Package used (Python/R/Scala/Julia): Python
Or if installed from source:
MXNet commit hash (git rev-parse HEAD): 8713d257cde97a660a459aa8a50a780944cf823c (0.10.0 release)
Also tried with latest master: 92428fb7ba8003b3d8d9d098ef20c22123824c89
If you are using python package, please provide
Python version and distribution: Python 2.7.6, pip 9.0.1 from /usr/local/lib/python2.7/dist-packages (python 2.7)
Error Message:
Please paste the full error message, including stack trace.
Segmentation fault (core dumped)
When tried to debug using pdb, get the following :
Traceback (most recent call last):
  File "char_lstm.py", line 156, in <module>
    epoch_end_callback=mx.callback.do_checkpoint("obama"))
  File "/usr/local/lib/python2.7/dist-packages/mxnet-0.10.1-py2.7.egg/mxnet/module/base_module.py", line 459, in fit
    for_training=True, force_rebind=force_rebind)
  File "/usr/local/lib/python2.7/dist-packages/mxnet-0.10.1-py2.7.egg/mxnet/module/module.py", line 383, in bind
    self.data_names, self.label_names, data_shapes, label_shapes)
  File "/usr/local/lib/python2.7/dist-packages/mxnet-0.10.1-py2.7.egg/mxnet/module/base_module.py", line 69, in _parse_data_desc
    data_shapes = [x if isinstance(x, DataDesc) else DataDesc(*x) for x in data_shapes]
  File "/usr/local/lib/python2.7/dist-packages/mxnet-0.10.1-py2.7.egg/mxnet/io.py", line 46, in __new__
    ret = super(cls, DataDesc).__new__(cls, name, shape)
  File "<string>", line 10, in __new__
  File "/usr/lib/python2.7/bdb.py", line 53, in trace_dispatch
    return self.dispatch_return(frame, arg)
  File "/usr/lib/python2.7/bdb.py", line 88, in dispatch_return
    self.user_return(frame, arg)
  File "/usr/lib/python2.7/pdb.py", line 190, in user_return
    self.interaction(frame, None)
  File "/usr/lib/python2.7/pdb.py", line 209, in interaction
    self.print_stack_entry(self.stack[self.curindex])
  File "/usr/lib/python2.7/pdb.py", line 900, in print_stack_entry
    prompt_prefix)
  File "/usr/lib/python2.7/bdb.py", line 381, in format_stack_entry
    s = s + repr.repr(rv)
  File "/usr/lib/python2.7/repr.py", line 24, in repr
    return self.repr1(x, self.maxlevel)
  File "/usr/lib/python2.7/repr.py", line 34, in repr1
    s = __builtin__.repr(x)
  File "/usr/local/lib/python2.7/dist-packages/mxnet-0.10.1-py2.7.egg/mxnet/io.py", line 52, in __repr__
    return "DataDesc[%s,%s,%s,%s]" % (self.name, self.shape, self.dtype,
AttributeError: 'DataDesc' object has no attribute 'dtype'

Minimum reproducible example
if you are using your own code, please provide a short script that reproduces the error.
Steps to reproduce
or if you are running standard examples, please provide the commands you have run that lead to the error.

Clone mxnet-notebooks repo.

git clone https://github.com/dmlc/mxnet-notebooks

cd into python/tutorials directory:

cd python/tutorials

Convert char_lstm.ipynb to python script.

jupyter nbconvert char_lstm.ipynb --to python

Run the python script.

python char_lstm.py

What have you tried to solve it?

Tried to increase the number of epochs.
Tried on g2.2xlarge instance type.

try reducing the batchsize

Tried to debug with gdb. Ran the following commands:
gdb -ex r --args python char_lstm.py

Here is the stacktrace:
(gdb) bt
#0  0x00007fffdf9ffc29 in mkl_vsl_sub_kernel_l9_sBRngMCG31M1 () from /usr/local/lib/libmklml_intel.so
#1  0x00007fffdc480428 in mkl_vsl_kernel_l9_sRngUniform () from /usr/local/lib/libmklml_intel.so
#2  0x00007fffdc47f624 in mkl_vsl_kernel_l9_iRngBernoulli () from /usr/local/lib/libmklml_intel.so
#3  0x00007fffdc2309e1 in viRngBernoulli () from /usr/local/lib/libmklml_intel.so
#4  0x00007fffe9fe6a0c in mxnet::op::bernoulli_generate () at src/operator/./dropout-inl.h:51
#5  0x00007fffe9fe6a94 in mxnet::op::bernoulli_generate (n=n@entry=16384, p=0.80000001192092896, r=r@entry=0x1229410200) at src/operator/./dropout-inl.h:41
#6  0x00007fffe9fed619 in mxnet::op::DropoutOp<mshadow::gpu, float>::Forward (this=0x2711680, ctx=..., in_data=std::vector of length 1, capacity 1 = {...}, req=std::vector of length 2, capacity 2 = {...},
    out_data=..., aux_states=...) at src/operator/./dropout-inl.h:96
#7  0x00007fffe9047c76 in std::_Function_handler<void (mxnet::RunContext, mxnet::engine::CallbackOnComplete), mxnet::exec::GraphExecutor::CreateCachedSegOpr(unsigned long, unsigned long)::{lambda(mxnet::RunContext, mxnet::engine::CallbackOnComplete)#1}>::_M_invoke(std::_Any_data const&, mxnet::RunContext, mxnet::engine::CallbackOnComplete) ()
   from /usr/local/lib/python2.7/dist-packages/mxnet-0.10.0-py2.7.egg/mxnet/libmxnet.so
#8  0x00007fffe90329bc in mxnet::engine::ThreadedEngine::ExecuteOprBlock(mxnet::RunContext, mxnet::engine::OprBlock*) () from /usr/local/lib/python2.7/dist-packages/mxnet-0.10.0-py2.7.egg/mxnet/libmxnet.so
#9  0x00007fffe9035990 in std::_Function_handler<void (), mxnet::engine::ThreadedEnginePerDevice::PushToExecute(mxnet::engine::OprBlock*, bool)::{lambda()#3}::operator()() const::{lambda()#1}>::_M_invoke(std::_Any_data const&) () from /usr/local/lib/python2.7/dist-packages/mxnet-0.10.0-py2.7.egg/mxnet/libmxnet.so
#10 0x00007fffcbeb4a60 in ?? () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#11 0x00007ffff7bc4184 in start_thread (arg=0x7fffa7fff700) at pthread_create.c:312
#12 0x00007ffff78f0ffd in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:111
(gdb)

This seems to be an issue with MKLML. After rebuilding mxnet with USE_MKL2017=0 I was able to run the char_lstm tutorial.

The workaround is to modify the lines L91 and L127 in src/operator/dropout-inl.h. Here is the fix.

There is a branch available with work-around for this issue v0.10.0-support

This issue is closed due to lack of activity in the last 90 days. Feel free to ping me to reopen if this is still an active issue. Thanks!
Also, do please check out our forum (and Chinese version) for general "how-to" questions.


Main window title bar and toolbar design improvements

Fixes an issue where sheets would open from above the window's title bar rather than below it
Removes the non-standard window background color
Removes several unused toolbar items from the main window in the storyboard
Aligns the search suggestions window below the search field no matter where the containing toolbar item is placed

The latest commit walks back the centered search field present in the first commit.

Ha! The perils of leaving tabs open. Double-approved!!! 🤪


Does not work on iOS

I have problems trying to implement this plugin on IOS, all attempts I made were unsuccessful, on android works!
I tried to start this plugin without media, with video, with audio, both situations realize that it is the webview that creates the controls and not the plugin, the next and back controls are always disabled! I can't manipulate these controls created by webview? Or is there a way to replace these controls with this plugin?

You need to use the native media plugin in order for the remote controls to work correctly.
It is know that it doesn't work properly with HTML5 audio.

@ghenry22  Thanks for the answer!
My need is to play a streaming url *. .m3u8 (HLS streaming)
Do you have any suggestion ?

The solution for me was to use https://github.com/apache/cordova-plugin-media

How to use this cordova-plugin-media with cordova-music-controls? I've been trying to get music controls working with Ionic on iOS for over a year. There's something I seem to not understand :sob:

@paulovargatt @ghenry22 @tbergeron  any idea does

https://github.com/apache/cordova-plugin-media
also, support on the browser? has anyone tested?


[misc][distributed] fix pp missing layer condition

fixes https://github.com/vllm-project/vllm/pull/6406#pullrequestreview-2177216921

just curious, how can you figure it out so quickly?
I'm still setting up the correctness test of pipeline parallel.


[FEATURE] Eighth Queens Game

Description
To add Eighth Queens Game made in ReactJs.
The eight queens puzzle is the problem of placing eight chess queens on an 8×8 chessboard so that no two queens threaten each other; thus, a solution requires that no two queens share the same row, column, or diagonal. There are 92 solutions. The problem was first posed in the mid-19th century. In the modern era, it is often used as an example problem for various computer programming techniques.
Screenshots
No response
Additional information
No response

@panwar8279
Please assign this issue.

Hi @Ayushkumargit7 , I have assigned this task to you. Kindly complete within 2 days. Good luck!


list_opportunities endpoint adds query param to filter queries

The "list opportunities" endpoint does not follow the Close.io API guidelines.
Specifically: it assumes that all filters are used as queries (via the "query") parameter.  As a result it is prepending query to the URL for filters and yielding incorrect output/results.
ref:
def list_opportunities(options={})
  get(opportunity_path, query: options)
end

For example, when I try the following in console:
close = Closeio::Client.new(API_KEY)
close.list_opportunities(date_created__gte: '2016-08-01T00:54:51.337000+00:00')

I see the gem queries the following URL:
https://app.close.io/api/v1/opportunity/?query[date_created__gte]=2016-08-01T00%3A54%3A51.337000%2B00%3A00
Per the API docs:
https://developer.close.io/#opportunities
i.e.
GET /opportunity/{?lead_id, user_id, status_id, status_label, status_type, date_created__{lt|gt|lte|gte}, date_updated__{lt|gt|lte|gte}, date_won__{lt|gt|lte|gte}, value_period, query, _order_by, _group_by, _fields,lead_query}

The correct URL for filtering opportunities based on this parameter should be:
https://app.close.io/api/v1/opportunity/?date_created__gte=2016-08-01T00:54:51.337000+00:00

Fixed in 2.6.2


return pointer from to.StringMapPtr

All Tags fields actually accept *map[string]*string in Azure SDK. (ack --go Tags | grep -v '^//' | grep map)
cc: @brendandixon PTAL

@ahmetalpbalkan Could you, please, update the version as well. This change, as it alters the interface of a method, requires incrementing the minor version number. Thanks!

@brendandixon you mean major, right?

@ahmetalpbalkan Yes, sadly for such a small change.

@ahmetalpbalkan If, however, you were to add a new method alongside the old, then a minor increase. But that might be confusing...

Yeah this is definitely the major. I'll update changelog for now, however normally we should just keep accepting PRs until we decide to make a release and then update the changelog ourselves.

@ahmetalpbalkan We could, but other code pulls from master and this will introduce a change...no?

other code pulls from master

hmm, it shouldn't. Azure SDK has a copy of this package. We just need to update with godep over there.

@ahmetalpbalkan That assumes the only consumer is the Azure SDK. Likely true, but still an unproven assumption.

@brendandixon nothing we can do about breaking the master branch. :) Maybe we should add a notice to readme and suggest using tags/releases of the source instead.
This LGTM now?

@ahmetalpbalkan Lame. And, yes, I try to push tags.

Tagged v2.0.0

@ahmetalpbalkan Peachy. Though I thought we were going to collect and then tag. No worries.

@brendandixon I just tagged anyway since I changed the CHANGELOG already.


Typo in poem "little ladies more"

In the poem Portraits XII, which also appears as TWO IX (both having the first line "little ladies more"), there is a line "te terai Mimi". The second word in that line has a typo – it should be ferai. (It's near the middle of a long stanza that begins with "where has danced la".)

You're right. I've verified your correction in the original scan
https://archive.org/details/is-5-ee-cummings/page/n79/mode/2up
I will make this fix shortly and update the site.

Fixes are out. Thank you for your help.
https://cummings.ee/book/and/poem/portraits-xii/
https://cummings.ee/book/is-5/poem/two-ix/


repLoad() function

🐛 Bug
When repLoad function loads files from MiXCR (I did not check in other formats), the column "allVHitsWithScore" is alphabeticaly ordered in the immunarch object while order by MiXCR score was spected. Then, geneUsage produces a wrong output with .ambig="maj" because the majoritary is the first alphabetically.
To Reproduce
Steps to reproduce the behavior:

immdata <- repLoad("mixcrdata")
geneUsage(immdata$data, "hs.trbv", .ambig = "maj")

Expected behavior
MiXCR "allVHitsWithScore" column: TRBV6-100(175),TRBV6-500(160),TRBV6-600(160),TRBV10-300(154)
What I want: TRBV6-1
immunarch "V.name" column: TRBV10-3, TRBV6-1, TRBV6-5, TRBV6-6
What I obtain: TRBV10-3

Hello @TeresaRubio and thank you so much for signing up on GitHub to open an issue, I truly appreciate it!
I'm deeply sorry for the very late response. We've been extremely busy raising investments and hiring the team after finishing UC Berkeley startup accelerator. We are finally set up for now: we grew the team from 4 to 15 amazing professionals, and raised a large investment round from great investors. Thank you so much for your patience!
We made changes to the Immunarch code to fix the issue you described. Please update to the latest development version of the package and let us know how it works. To install the development version, execute the following code:
devtools::install_github("immunomind/immunarch", ref="dev")
Improving upon Immunarch, we will soon release our online analytics platform for fast, effortless and code-less reproduction of impactul single-cell transcriptomics and immune repertoire publications. It's designed for researchers who spend a lot of time or energy reproducing sophisticated pipelines or analysing datasets from publications. Feel free to send us a link to publications of your interest so we can reproduce them on our platform and give you an access.
We are more than happy to grant you an early access as our gratitude for you being a longstanding immunarch user.
We have a list of datasets from around 30 publications that we are going to make available for your exploration and analysis. As an example, we recently reproduced on a platform a paper focused on scRNAseq-based estimation of efficacy of CAR-T immunotherapy.
Please send links to<EMAIL_ADDRESS>The direct link to the publication datasets would be also greatly appreciated.

Thank you! Now is working correctly :)

Great to hear that, thank YOU for letting us know about it!


Cannot use object of type stdClass as array Line 100, 124 at /enlighter/class/TinyMCE.php

I have just download your plugin to experiment with my new wordpress based blog, and found the following error :
Cannot use object of type stdClass as array Line 100, 124 at /enlighter/class/TinyMCE.php
What I did ?, I just commented the code on line 100 and then on 124.
May you please check the issue and let me know your comments,

Dear esumit,
thank's for you report. i can confirm the issue - it only affects users which are using other TinyMCE plugins. to fix it, please change line 72 of  /enlighter/class/TinyMCE.php
from
$styles = json_decode($tinyMceConfigData['style_formats']);

to
$styles = json_decode($tinyMceConfigData['style_formats'], true);

the fix will be included within the next release.
best regards, Andi

Thanks Andi , appreciate your support and thanks for the awesome plugin.
'Sumit
Sent from my iPhone

On Jul 29, 2015, at 3:00 PM, Andi Dittrich<EMAIL_ADDRESS>wrote:
Dear esumit,
thank's for you report. i can confirm the issue - it only affects users which are using other TinyMCE plugins. to fix it, please change line 72 of /enlighter/class/TinyMCE.php
from
$styles = json_decode($tinyMceConfigData['style_formats']);
to
$styles = json_decode($tinyMceConfigData['style_formats'], true);
the fix will be included within the next release.
best regards, Andi
—
Reply to this email directly or view it on GitHub.

Thanks Andi, :-)
On Tue, Aug 4, 2015 at 1:53 AM, Andi Dittrich<EMAIL_ADDRESS>wrote:

Closed #12 https://github.com/AndiDittrich/WordPress.Enlighter/issues/12
.
—
Reply to this email directly or view it on GitHub
https://github.com/AndiDittrich/WordPress.Enlighter/issues/12#event-372403884
.


PDF Service Follow Up

Description: Follow up to https://github.com/FoodPrintLabs/foodprint/pull/105. Updated web link in footer of generated PDF so it is clickable and updated GET route for PDF to /app/produce/pricepage/pdf

Testing: Quickly tested in Dev

@DanielmAaron FYI :)


Update fly config

Issue

the fly.toml, etc. are out of date and should be updated for apps v2.
running fly launch doesn't work without upgrading to Phoenix 1.6.3 (details)

We should upgrade the app to 1.7, but that can happen in a different PR.
UX
Rather than providing an existing fly.toml, I've renamed the file to fly.example.toml to be used as a reference. The user should instead simply run fly launch and generate a new one (in their region, etc.).

I tested it out and it works great. Nice update! :medal_sports:


Write to single zarr store

Fixes https://github.com/mehta-lab/recOrder/issues/338.
Tested on all combinations of [Retardance + Orientation, Phase, Retardance + Orientation + Phase] and [2D, 3D]. All of the resulting zarrs can be drag-and-drop opened in napari with the recorder reader.

Just tested again on hummingbird. Thanks @ziw-liu!


Incorrect colorization for valid unquoted attributes in HTML

There is an issue with unquoted HTML attributes in VS Code where valid code will break the HTML colorization.
For instance after an unquoted id attribute, any following code will have the wrong color until VS Code comes across a quote character. This issue continues through any new elements that happen to follow the unquoted id. Other unquoted attributes also have colorization issues, but those are less severe because it just effects the attribute value (it is the same color as the attribute name rather than the attribute value color).

Text inside the cover

In the above, everything from id=cover to class=" will have incorrect colorization.
Steps to Reproduce:

Use an unquoted id or other unquoted attribute in an HTML file.

VS Code Version: 1.55.2
OS Version: macOS 11.3.1

This was do to an extension. I removed the extensions and the colorization is working correctly for unquoted attributes now.


added day to logger and a little refactored

Short Description:
Fixes:

added current day to logger

need to fix conflicts.

Ready to review!

@paledrewnem did you test?

@douglascamata  OK, I tested it and it works
@TheSavior sorry, my bad. Thanks for being watchful :)

:-1: No need for day to console. it was there before and we decided to remove it


Feature/emotion to event

This feature adds emotion to an event based on its title and content
The main function "get_emotion" returns the emotion HTML code based on the event title and content.
The title and content were given weights as we set in the global variables.
Additionally, we set the significance level that above it the emotion will appear.
Changes in models:
The event table now has a new column: emotion
this column returns a string (HTML code) and may be null.
The following emotion are:
😃 Happy - &#128515
🙁 Sad - &#128577
😠 Angry - &#128544
😱 Fear - &#128561
😮 Surprise - &#128558

Codecov Report

Merging #225 (99f30ee) into develop (4df85bc) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #225      +/-   ##
===========================================
+ Coverage    99.29%   99.32%   +0.03%
===========================================
  Files           41       42       +1
  Lines         1691     1779      +88
===========================================
+ Hits          1679     1767      +88
  Misses          12       12

Impacted Files
Coverage Δ

app/database/models.py
96.69% <100.00%> (+0.08%)
:arrow_up:

app/internal/emotion.py
100.00% <100.00%> (ø)

app/internal/event.py
100.00% <100.00%> (ø)

app/routers/event.py
97.31% <100.00%> (+0.51%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75ed3ee...67f14e6. Read the comment docs.


I can't use the carthage build, carthage version 0.29.0

/Carthage/Checkouts/SQLite.swift/Sources/SQLite/Typed/CoreFunctions.swift:654:57: error: cannot convert value of type 'Self.IndexDistance' to expected argument type 'Int'
let templates = [String](repeating: "?", count: count).joined(separator: ", ")
^~~~~
Int( )

Carthage/Checkouts/SQLite.swift/Sources/SQLite/Typed/Schema.swift:50:25: error: value of type '[Expressible?]' has no member 'compactMap'
return " ".join(clauses.compactMap { $0 }).asSQL()

Carthage/Checkouts/SQLite.swift/Sources/SQLite/Typed/Query.swift:693:69: error: missing argument for parameter #2 in call
return Update(" ".join(clauses.compactMap { $0 }).expression)
^
, <#[Binding?]#>

Carthage/Checkouts/SQLite.swift/Sources/SQLite/Typed/Query.swift:880:12: note: 'init' declared here
public init(_ template: String, _ bindings: [Binding?]) {

** ARCHIVE FAILED **

The following build commands failed:
CompileSwiftSources normal arm64 com.apple.xcode.tools.swift.compiler
CompileSwift normal arm64
(2 failures)

You need Xcode 9.3 to compile


Stuck on "Successfully hooked"

Running frida-server as sudo my device is rooted obviously.
I start keydive and then i open up a drm video and it detects it but just stays stuck on KeyDive: Successfully hooked like that
I used keydive -w -o desktop
C:\Users\ahmed\Desktop>keydive -w -o desktop
2024-12-26 04:06:54 [I] KeyDive: Version: 2.1.4
2024-12-26 04:06:54 [I] ADB: Connected to device: GT I9500 (4d0090124a6f51c9)
2024-12-26 04:06:54 [I] ADB: SDK API: 25
2024-12-26 04:06:54 [I] ADB: ABI CPU: armeabi-v7a
2024-12-26 04:06:54 [I] Core: Script loaded successfully
2024-12-26 04:06:54 [I] KeyDive: Setup completed
2024-12-26 04:06:54 [I] KeyDive: Watcher delay: 1s
2024-12-26 04:06:55 [W] Core: Library not found: libwvdrmengine.so
2024-12-26 04:06:56 [I] Core: Library: libwvdrmengine.so (/system/vendor/lib/mediadrm/libwvdrmengine.so)
2024-12-26 04:06:56 [I] KeyDive: Process: 2612 (mediadrmserver)
2024-12-26 04:06:56 [I] KeyDive: Successfully hooked

I tried to use -s like advised in a previous issue but i got this "2024-12-26 04:27:42 [E] Script: unable to intercept function at 0xb5bdf23d; please file a bug for byncer" and still stuck at "Successfully hooked"

I used keydive --auto

I used keydive --auto

Thank you using --auto and -o and -w worked for me after 2 tries appreciate it


[terra-clinical] Fix CVE

Summary

Fixed CVEs in clinical repo.
Closes #
Deployment Link

https://terra-clinical-deployed-pr-#.herokuapp.com/
Testing

Additional Details

Thank you for contributing to Terra.
@cerner/terra

Fails

:no_entry_sign:
Please include a CHANGELOG entry for each changed package this PR. Looks like a CHANGELOG is missing for:

terra-clinical-item-collection

  Generated by :no_entry_sign: dangerJS against 2fff5455d9c18394e9265904631247dc147f0ef9


Bluetooth: controller: Fix completion of rejected LLCP request

This fixes LLCP procedure completition in case when remote rejected
LLCP Slave Connection Parameter Request with LMP Error Transaction
Collision error code.
The link was disconnected after 40 seconds after receiving the
LLCP Reject Extended Indication of Connection Parameter Update
with the reason LMP Error Transaction Collision.
This patch resets the timer upon reject is received.
Relates to: #15366
Signed-off-by: Alexander Svensen<EMAIL_ADDRESS>

Is this a candidate for 1.14 backporting?

@jhedberg Thank you. I just realised that the original PR on the old controller #15366 is for 1.13-branch!...
@alexsven Please have the fix in old controller ctrl.c file too in this same PR.

@alexsven the build is failing. Also, please use the "commit" message from #15366, not git hub PR title+description. see #15821


Adding option to reduce the bit rate of bigger video files

Is your feature request related to a problem? Please describe.
I can set the compression of video, but I am not able to set the bit rate of a video which drastically reduces the file size
Describe the solution you'd like
just like compression option, it would be better if we could add a set bitrate option

@riazhazan write here if ios SDK give such an API.

@NikKovIos
I am adding Objective c code. The below code will help to do the compression. In below code you can compress video by specifying resolution and bitrate
`- (void)compressVideoWithInputVideoUrl:(NSURL ) inputVideoUrl
{
/ Create Output File Url */
NSArray *paths = NSSearchPathForDirectoriesInDomains(NSDocumentDirectory, NSUserDomainMask, YES);
NSString *documentsDirectory = [paths objectAtIndex:0];
NSFileManager *fileManager = [NSFileManager defaultManager];
NSString *finalVideoURLString = [documentsDirectory<EMAIL_ADDRESS>NSURL *outputVideoUrl = ([[NSURL URLWithString:finalVideoURLString] isFileURL] == 1)?([NSURL URLWithString:finalVideoURLString]):([NSURL fileURLWithPath:finalVideoURLString]); // Url Should be a file Url, so here we check and convert it into a file Url

SDAVAssetExportSession *compressionEncoder = [SDAVAssetExportSession.alloc initWithAsset:[AVAsset assetWithURL:inputVideoUrl]]; // provide inputVideo Url Here
compressionEncoder.outputFileType = AVFileTypeMPEG4;
compressionEncoder.outputURL = outputVideoUrl; //Provide output video Url here
compressionEncoder.videoSettings = @
{
AVVideoCodecKey: AVVideoCodecH264,
AVVideoWidthKey: @800,   //Set your resolution width here
AVVideoHeightKey: @600,  //set your resolution height here
AVVideoCompressionPropertiesKey: @
    {
    AVVideoAverageBitRateKey: @45000, // Give your bitrate here for lower size give low values
    AVVideoProfileLevelKey: AVVideoProfileLevelH264High40,
    },
};
compressionEncoder.audioSettings = @
{
AVFormatIDKey: @(kAudioFormatMPEG4AAC),
AVNumberOfChannelsKey: @2,
AVSampleRateKey: @44100,
AVEncoderBitRateKey: @128000,
};

[compressionEncoder exportAsynchronouslyWithCompletionHandler:^
 {
     if (compressionEncoder.status == AVAssetExportSessionStatusCompleted)
     {
        NSLog(@"Compression Export Completed Successfully");
     }
     else if (compressionEncoder.status == AVAssetExportSessionStatusCancelled)
     {
         NSLog(@"Compression Export Canceled");
     }
     else
     {
          NSLog(@"Compression Failed");

     }
 }];

}`

I found an implementation to copy from, but not have time to do it now.
https://github.com/VideoFlint/VIExportSession/tree/master/VIExportSession


nim: 1.6.18 -> 1.6.20, 2.0.2 -> 2.0.4

Description of changes
https://nim-lang.org/blog/2024/04/16/versions-1620-204-released.html
This sort of compiler update hasn't broken things in the past.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@ofborg eval

Something doesn't seem right on my darwin machine when I do nixpkgs-review, why does it build stdenv?

Result of nixpkgs-review pr 306493 run on aarch64-darwin 1

2 packages marked as broken and skipped:

chawan
nrpl

6 packages built:

nim (nim2)
nim1
nim_lk
promexplorer
tridactyl-native
vimPlugins.fruzzy


Plugin Refactor

The entire code base for the plugin has been refactored. It does not possess any additional core functionality over the previous version except where it restores intended functions from bug fixes.

Keep in mind the /dev/ api route in BotDetectorClient needs to be changed back to /api/ before this is used for the hub version


Update config.example.toml

Change Qbit WebUI port to Qbit WebUI port

Thanks for the fix missed that!


arch: arc: Add mpu support

add arc mpu driver
modify the corresponding kconfig and kbuild
currently only em_starterkit 2.2's em7d configuration
has mpu feature (mpu version 2)
as the minimum region size of arc mpu version 2 is 2048 bytes and
region size should be power of 2, the stack size of threads
(including main thread and idle thread) should be at least
2048 bytes and power of 2
for mpu stack guard feature, a stack guard region of 2048 bytes
is generated. This brings more memory footprint
For arc mpu version 3, the minimum region size is 32 bytes.
the codes are tested by the mpu_stack_guard_test and stackprot

Signed-off-by: Wayne Ren<EMAIL_ADDRESS>

The configure of default mpu region is done in arc_core_mpu_enable().
No permissions are given to default mpu region.
From: ruuddw<EMAIL_ADDRESS>Sent: 2017年8月15日 20:28
To: zephyrproject-rtos/zephyr<EMAIL_ADDRESS>Cc: Wayne Ren<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [zephyrproject-rtos/zephyr] arch: arc: Add mpu support (#1122)
@ruuddw commented on this pull request.

In arch/arc/core/mpu/arc_mpu.chttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_zephyrproject-2Drtos_zephyr_pull_1122-23discussion-5Fr133177288&d=DwMCaQ&c=DPL6_X_6JkXFx7AXWqB0tg&r=uIRv5OnfaYG5_34mbrNlSdByDrbpAfi15TvQ5YKDOG8&m=Cj05v7UtZG5E0UNqczlc4gW2wX4Cn05NOtPhfjgvsW8&s=AIhVgvNRNuhTNBFjbGALN3-ly0lu5ptnF5BtxFj4jA8&e=:

arc_core_mpu_disable();

 for (i = 0; i < r_index; i++) {

        _region_init(i, 0, 0);

 }

 /* Configure regions */

 for (r_index = 0; i < num_regions; i++) {

        _region_init(i,

                mpu_config.mpu_regions[r_index].base

                | AUX_MPU_RDB_VALID_MASK,

                mpu_config.mpu_regions[r_index].attr);

        r_index++;

 }

 /* Enable MPU */

I think the default region should be updated here as well (disabled, so addresses not explicitly defined in MPU no longer have the 'everything permitted' reset setting.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_zephyrproject-2Drtos_zephyr_pull_1122-23pullrequestreview-2D56326892&d=DwMCaQ&c=DPL6_X_6JkXFx7AXWqB0tg&r=uIRv5OnfaYG5_34mbrNlSdByDrbpAfi15TvQ5YKDOG8&m=Cj05v7UtZG5E0UNqczlc4gW2wX4Cn05NOtPhfjgvsW8&s=5fgrLYGqPJCuAikeXKFhpzxHrpNxm8JictLZvHmfAk8&e=, or mute the threadhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AFB9OzKM8Bmtt-2DGiDTmF97rTn5kZSvVuks5sYY7RgaJpZM4O3LoI&d=DwMCaQ&c=DPL6_X_6JkXFx7AXWqB0tg&r=uIRv5OnfaYG5_34mbrNlSdByDrbpAfi15TvQ5YKDOG8&m=Cj05v7UtZG5E0UNqczlc4gW2wX4Cn05NOtPhfjgvsW8&s=nzFIE-BeAHRdljdolanzDZvNvRn2pj4D-wUN6GKNLlY&e=.


Unit testing in the CQL Formatter

Unit tests should be added to the CQL Formatter to verify:

Formatting functionality for all language constructs (coverage testing)
Formatting functionality does not impact ELM output (formatting transparency)

The unit test should include a scaffold that would, for any input CQL, verify that the unannotated ELM output from the original CQL is the same as the unannotated ELM output from the formatted CQL.
This unit test scaffold should then be invoked on all the regression testing scripts in the CQL-to-ELM translator.

This feature is included in the 1.2.11-SNAPSHOT release.


tool: Add Hueplot

Add Hueplot color gamut/space visualizer.
The logo doesn’t meet the 500 × 300 pixel size because the logo provided by the website is only available with a resolution of 96px, so I halved the logo size to 250 × 150 pixel.

Thank you, @mvsde 🙌


HBASE-21596 Delete for a specific cell version can bring back version…

…… (#2009)
Had to resolve some conflicts while cherry picking into branch-2.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
4m  1s
branch-2 passed

+1 :green_heart:
checkstyle
1m 22s
branch-2 passed

+1 :green_heart:
spotbugs
2m 12s
branch-2 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 34s
the patch passed

+1 :green_heart:
checkstyle
1m 15s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
14m  0s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
2m 14s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 13s
The patch does not generate ASF License warnings.

37m 44s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2036/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2036

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux d2924a1bc9cd 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 5fcffae5db

Max. process+thread count
84 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2036/1/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 36s
Docker mode activated.

-0 :warning:
yetus
0m  7s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
4m 28s
branch-2 passed

+1 :green_heart:
compile
1m  5s
branch-2 passed

+1 :green_heart:
shadedjars
6m  1s
branch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 44s
hbase-server in branch-2 failed.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m  0s
the patch passed

+1 :green_heart:
compile
1m  5s
the patch passed

+1 :green_heart:
javac
1m  5s
the patch passed

+1 :green_heart:
shadedjars
6m 40s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 49s
hbase-server in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
140m 51s
hbase-server in the patch passed.

168m 24s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2036/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2036

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux dfdd04e16907 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 5fcffae5db

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2036/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2036/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2036/1/testReport/

Max. process+thread count
3643 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2036/1/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 36s
Docker mode activated.

-0 :warning:
yetus
0m  5s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
3m 48s
branch-2 passed

+1 :green_heart:
compile
0m 54s
branch-2 passed

+1 :green_heart:
shadedjars
5m  4s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 38s
branch-2 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 23s
the patch passed

+1 :green_heart:
compile
0m 54s
the patch passed

+1 :green_heart:
javac
0m 54s
the patch passed

+1 :green_heart:
shadedjars
5m  6s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 37s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
151m 25s
hbase-server in the patch passed.

174m 41s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2036/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2036

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux da9ba2d3c764 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 5fcffae5db

Default Java
1.8.0_232

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2036/1/testReport/

Max. process+thread count
3501 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2036/1/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Not sure why I missed this one...
Have you read https://issues.apache.org/jira/browse/HBASE-15968?
Thanks.

And if you are talking about filter, the semantic for readVersions is the number of versions before filtering, not the version after fitlering. If you want to limit the version after filtering, you can use readAllVersions and append a filter at last to limit the versions returned.

And if you are talking about filter, the semantic for readVersions is the number of versions before filtering, not the version after fitlering. If you want to limit the version after filtering, you can use readAllVersions and append a filter at last to limit the versions returned.

Oh, skimmed HBASE-17125. Seems we do not go to this direction. Anyway, on the solution for 'deleted versions come back', I think the final solution is HBASE-15968.
Thanks.

And if you are talking about filter, the semantic for readVersions is the number of versions before filtering, not the version after fitlering. If you want to limit the version after filtering, you can use readAllVersions and append a filter at last to limit the versions returned.

Oh, skimmed HBASE-17125. Seems we do not go to this direction. Anyway, on the solution for 'deleted versions come back', I think the final solution is HBASE-15968.
Thanks.

Thanks for pointing HBASE-15968. This has been a recurring source of confusion and complain among our customer base, having inconsistent results prior and after compaction isn't just correct. Should we make HBASE-15968 the default behaviour, and not optional?


feat(iroh-dns-server)!: eviction of stale zonestore entries

Description
Configurable eviction of stale zonestore entries.
This works by taking a snapshot of the database in regular intervals and checking if a record is possibly expired. For all possibly expired records a fire and forget message will be sent to the io write actor to check again. The actor will check the expiry again (entry could have been renewed since the last snapshot) and then deletes it if the final check confirms expiry.
Between expiry checks there is a configurable delay, so the thread is not constantly spinning checking for expiry.
We use a second thread since we don't want to block writing new entries by sifting through old entries.
Breaking Changes

struct config::Config has a new field zone_store
struct metrics::Metrics has a new field store_packets_expired

Notes & open questions
Note: there are two ways to do eviction. One is to carefully keep track of the time for each entry by having a second table that has (timestamp, key) as the key and () as the value. Then you could just evict without doing a full scan by sorting by time ascending.
The downside of course is that you need an entire new table, and you need to update this table every time you update an entry (delete (old time, id), insert (new time, id).
So I decided to just do a full scan instead for simplicity. We can change it if it becomes a problem.
Hm, maybe we should avoid the full scan after all. I can imagine the thing being a bit less responsive than usual while the scan is ongoing. Another idea would be to have an "event log" where you just store (time, id) -> () and then use that to look for eviction candidates. Don't bother cleaning up this event log on every update.
I have now implemented a second table. It is a multimap table from timestamp to id. This gets updated on every write (slight perf downside here), and can be used to scan for evictions without having to do a full scan.
There is quite a lot of code just to expose these config options. We could also omit this and just use reasonable defaults.
Change checklist

[ ] Self-review.
[ ] Documentation updates following the style guide, if relevant.
[ ] Tests if relevant.
[ ] All breaking changes documented.

Aside from the messed up git history I guess :D


[FLINK-2423] [streaming] ITCase for checkpoint notifications

See javadoc and Jira.

If no objections I will merge this in the evening.

Could you please wait until I get a chance to look at it? I will try to do so later today :)

Sure, thanks for checking it out. :+1:

In general I think it has a little more complexity than necessary coming from the actual application implemented here. I would get rid of the PrefixCounts and the specific operators for this counting application and would replace them with simple filters and maps.
I think that would serve the same purpose and would not hide the actual notification tests with a lot of unnecessary details

Thanks, fair enough. I'll give it another try soon.

Simplified the testing topology and added a bit more comments.

Indeed, the setup should ensure that we get notifications on both sides of the failure modulo failed checkpoints.

Merging...


Steps to resolve the "type vector does not exist" error

While running the schema.sql, if you encounter the "type vector does not exist" error, install the vector extension in Supabse (see the image below). That should resolve the issue.

I have got the same issue and solved it by adding the following line to the schema.sql. Let me suggest @mckaywrigley to change the code accordingly.
create extension if not exists vector with schema public;

Oh thank you, I was blocked on the same issue 😅


fix security vulnerability in axios and update dependencies

Do you want to request a feature or report a bug?
bug
What is the current behavior?

axios < 1.6.8 has various security vulnerabilities
most of the other dependencies are outdated

If the current behavior is a bug, please provide the steps to reproduce.

What is the expected behavior?
If this is a feature request, what is motivation or use case for changing the behavior?
Please mention other relevant information.

node version 10.24.1
npm version<EMAIL_ADDRESS>Operating system
bundlesize version 0.18.2
CI you are using

@falsyvalues  I disagree. #382 upgraded axios from 0.21.1 to 1.6.2 and github-build from 1.2.2 to 1.2.4.
#388 is taking care of more packages and also upgrades to newer versions. axios should be upgraded to 1.6.4 or above to include the latest security fixes (see release notes for axios 1.6.4)

@LeichtF Oh, let me correct that. Anyway its up to maintainer if he wants to be on the edge with other dependencies.


version-2.2

Pull Request
📖 Description
Add .NET 8.0-preview.2
Bring QuickGrid productization changes over to FluentDataGrid

@vnbaaij should I have a look here?
I would be able to provide a review tomorrow if you want.

Please do! Thanks.


WebXR Raw Camera Access (color)

This PR integrates Raw Camera Access API, that provides access to color image of a XR views. Along the way it introduces XrView concept which aligns with WebXR specs. It gives access to each view (single on mobile phones, and two on HMD devices), and will be extended with Depth Sensing API in the future. As current Depth Sensing API assumes a single view, so it will not work well with Quest 3's ability of providing depth maps for each view.
Test link: https://examples.playcanvas.meta.space/#/xr/ar-camera-color
Discussions: https://github.com/playcanvas/engine/issues/5780
// constants
// it comes from XRView eye property
XREYE_NONE = 'none' // monoscopic screens, e.g. mobile phones
XREYE_LEFT = 'left'
XREYE_RIGHT = 'right'

// pc.XrManager
xr.views // XrViews interface that provides an access to views and their capabilities
xr.start(camera, pc.XRTYPE_AR, pc.XRSPACE_LOCALFLOOR, {
    cameraColor: true // new option to request camera color information
});

// pc.XrViews
// this class provides an access to views, and their capabilities
views.supportedColor // true if color information is supported
views.availableColor // true if color information is available.
// This information is only available after XR session has started.
// It can be supported but not available due to lack of session features request, user permissions
// or underlying system capabilities
// Quest 3 - implements necessary features, but does not expose `camera-access` to users.
views.get(eye) // returns XrView or null based on XREYE_*
views.list // an array of XrView instances
views.size // number of views
views.on('add', (view) => { }); // event when new XrView is added
views.on('remove', (view) => { }); // event when XrView is removed

// pc.XrView
// this class represents a specific view with its data
view.eye // returns a string (constants XREYE_*). 'none' - means it is monoscopic display such as mobile phone screen
view.textureColor // returns a texture with color information. If color information is not available it will be null
view.viewport // Vec4 that represents a viewport are that this view is occupying of the screen

I confirm I have read the contributing guidelines and signed the Contributor License Agreement.

There was a comment from @mvaligursky:

To be honest, I'd strongly prefer we use some a multi-platform solution here instead of accessing WebGL directly. That means render target and drawQuadWithShader functionality. Platform stuff is inside /platform folder only as much as possible. In the future WebGPU will add support for XR and we'd want it to just work.

I've tried multiple ways:

Use RenderTargets - but it does not provide a way to create one with raw WebGLTexture, and copy method does pretty much what we do in the current implementation.
Direct WebGLTexture use - this works, and is most efficient way, but it does not provide flipY, and has a rule for "opaque texture" that WebGLTexture object should not be used outside of its RAF.
Direct WebGL functions use with blit function, that provides a way to flipY the buffer, and avoids quad a render.

Currently WebXR integration is only WebGL compatible, there are WebXR-WebGPU bindings Specs coming along, but we do not have devices that do support both APIs yet, so this is for the future PRs.

Fantastic PR @Maksims , thanks for this! I added few small comments, but overall this is great.


feat: set accessToken while initialize ChatGPTAPI

In order to avoid encountering request frequency limits, or some other account errors, we need to implement some load balancing strategy, just like manage accounts stored in Redis or MongoDB.
But if we manage tokens completely through this package, there will be at least one http request for authentication before each request.  It is difficult to build a distributed stateless restAPI service, so I put the accessToken parameter at the end and the default value is set to an empty string for compatibility.
PS: Especially in some areas where network connections are alway not that stable or the network speed is slow, it will cause higher latency and waste more time for waiting the answer from chatGPT.

Thanks @yunyu950908! 🙏