/fk directive overrides INT data type to number

This Quick SQL:
test
  foo_id int /nn /fk foo

Yields this SQL:
create table test (
    id        number generated by default on null as identity
              constraint test_id_pk primary key,
    foo_id    number
              constraint test_foo_id_fk
              references foo not null
);

Note that foo_id is a number, not an int as defined.

1.2.1


Run CI tests on Windows

We currently run CI tests on Linux and macOS. We should also run them on Windows.
https://github.com/SERG-Delft/andy/pull/236#discussion_r1269843286

@martinmladenov I can maybe work on this and fix #218 with it too

Sure, go ahead!


F1x leaves residue files

Whenever we run F1x in a container, the benchmark folder contains residue files which are seeds, outputs, etc, because these files are created in the container, the owner is root.

should be fixed by https://github.com/nus-apr/cerberus/commit/f1f55b51eb1ef21c22d508535f65c325c55fd781


Implement Python unions

Motivation and Context
Continue work on #1367.
Description
Implement support for the union shape in the Python server.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Wonder if we can leverage type narrowing here.
So we generate the following:
struct Square;

struct Circle;

// :type: typing.Union[Square, Circle]
enum Shape {
    Square(Square),
    Circle(Circle),
}

#[pyo3(name="Square")]
struct PySquare(Square);

#[pyo3(name="Circle")]
struct PyCircle(Circle);

impl ToPyObject for Shape {
    fn to_object(&self, py: Python<'_>) -> PyObject {
        match self {
            Shape::Square(s) => PySquare(s),
            Shape::Circle(c) => PyCircle(c),
        }
    }
}

impl FromPyObject<'_> for Shape {
    fn extract(obj: &PyAny) -> PyResult<Self>{
        if let Ok(s) = obj.extract::<PySquare> {
            Ok(Shape::Square(s.0))
        } else if let Ok(c) = obj.extract::<PyCircle> {
            Ok(Shape::Circle(c.0))
        } else {
            Err("invalid shape")
        }
    }
}

and users can write:
Shape = Square | Circle

def stringfy(shape: Shape) -> str:
    if isinstance(shape, Square):
        return "■"
    return "●"

I believe with Python 3.10 they can even write:
def stringfy(shape: Shape) -> str:
    match shape:
        case Square:
            return "■"
        case Circle:
            return "●"
        case _:
            raise NotReachable()

🤯

Wonder if we can leverage type narrowing here.

So we generate the following:

Unfortunately that is not enough as it will not cover nested unions like
union Something {
    member_a: AnotherUnion
    member_b: Integer
}

union AnotherUnion {
    member_a: Integer
    member_b: String
}


build: Create esm package. Closes #38

Issue #, if available:
#38
Description of changes:
Build esm package so that users can use es modules if they prefer.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

:tada: This PR is included in version 1.0.25 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.25 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Major change to support subject areas

I recently had a customer reach out who ran into an issue with snowchange, managing cross-database dependencies. He was trying to create a view in one database which was dependent upon a table in another database (which is pretty common). Previously every database was independent of each other. I have also had people ask if it were possible for multiple teams to work independently when they didn't have dependencies on each other.
So I came up with this concept of a subject area. Essentially now a change history table is created per Snowflake account (not per database) and there is an attribute for subject area. See the updated README.md for more details.

Just so I understand correctly, is the concept of subject area being addressed to reduce versioning confusion?
In other words, it would work fine without it, but it there would be a greater risk of multiple different branches all working on what they think will be, say, v1.8.1?
And if so, would the recommended convention be that you generally limit yourselves to a single branch per subject area?

No, sorry if I didn't explain it well enough. The primary purpose for this change is to support cross database dependencies (like a view in one database referencing a table in another). This came up from a Snowflake customer trying to do exactly that. The way snowchange worked it kept a single metadata table per database and only managed dependencies between objects in a single database. So the way to allow cross database dependencies, as I see it, is to have the metadata table outside the databases in its own place (hence the "METADATA" database now).
The best term I could come up with for this cross-database concept was "subject area". I thought about other terms like "project" but that is temporary and more applicable to a branch with is temporary.
I debated about removing the convention of having the database name be the second level folders and am still going back and forth. Not sure how best to support having multiple accounts in the same Snowflake account because it requires that database names have a suffix or prefix. The more I think about it now though, I don't think what I have solves the problem. Maybe it's better to remove that second level requirement and make use of a placeholder/macro concept (which most DCM tools support). Could also just depend on dbt for that.
Maybe we should setup a quick Zoom call to discuss?


[SPARK-46919][BUILD][CONNECT] Upgrade grpcio* to 1.60.0 and grpc-java to 1.61.0

What changes were proposed in this pull request?
This PR aims to upgrade grpcio* from 1.59.3 to 1.60.0 and grpc-java from 1.59.0 to 1.61.0 for Apache Spark 4.0.0.
Why are the changes needed?
grpc 1.60.0 start to support dualstack IPv4 and IPv6 backend support:

Implemented dualstack IPv4 and IPv6 backend support, as per draft gRFC A61. xDS support currently guarded by GRPC_EXPERIMENTAL_XDS_DUALSTACK_ENDPOINTS env var.

And for Python, there is a new bug fix:

[Bug Fix] Change return of grpc.aio.ServicerContext.code() from integer to grpc.StatusCode.

grpc-java 1.61.0 bring some Improvements like:

https://github.com/grpc/grpc-java/pull/3279

Note that in grpc-java 1.61.0, since the dependency scope of grpc-protobuf on grpc-protobuf-lite has been changed from compile to runtime, we need to manually configure the dependency of the connect module on grpc-protobuf-lite and explicitly exclude the dependency on protobuf-javalite because SparkConnectService uses io.grpc.protobuf.lite.ProtoLiteUtils

https://github.com/grpc/grpc-java/pull/10756/files

The relevant release notes are as follows:

https://github.com/grpc/grpc/releases/tag/v1.60.0
https://github.com/grpc/grpc-java/releases/tag/v1.60.0
https://github.com/grpc/grpc-java/releases/tag/v1.60.1
https://github.com/grpc/grpc-java/releases/tag/v1.61.0

Does this PR introduce any user-facing change?
No
How was this patch tested?
Pass GitHub Actions
Was this patch authored or co-authored using generative AI tooling?
No

1.61.0 released,  make this one to draft first

https://github.com/grpc/grpc/releases/tag/v1.61.0

The version has been unified to the 1.62 series now

Thanks @dongjoon-hyun


Formatter handling improvements

Hi @xente!
I want to thank you for your work doing this great tool!
I would appreciate a lot if you consider these proposed changes to be merged.
The main changes here are:

Added fallback to the current time in nanoseconds if the timestamp is missing or invalid in the stream's append_value() function. (This prevent a failure when the formatter does not include the 'timestamp' key)
-Reorganized the sequence of arguments in the LokiLoggerHandler constructor (useful change when loading logging configuration from files using logging.config.fileConfig())

*Possible breaking change*: The arguments labelKeys and defaultFormatter in the LokiLoggerHandler constructor were renamed as label_keys and default_formatter for consistency with the naming conventions.

Improved docstrings and comments for better readability and maintenance.

Added tests for custom formatters, empty buffer handling.

[X] All tests are green.

Please check PR #13, and if you are agree with it, this one can be cancelled.

Hi, coming back from holidays. I will check it as soon as I can.

Hi @novama,
PR #13 has been added, but I canceled it. Apologies for the delay.


Live video support

Could this allow websocket to be used to access a live stream of lets say h265 video and be eventually passed to an AVPlayer? I dont know where to ask the question.

See #116. WebSockets probably aren't the best choice for video streaming. You might use them to figure out the connection info, then use HLS for the actual streaming.

Yeah i was dubious about it but who knows... look at this
https://medium.com/@daspinola/video-stream-with-node-js-and-html5-320b3191a6b6

Streams in Node are just wrappers around regular socket connections. WebSockets != sockets. You could do this in iOS using the NSStream API to do the similar streaming, but luckily iOS has AVPlayer that can do all the heavy lifting for you.
let url = URL(string: "http://awesome.com/video.mp4")
let playerViewController = AVPlayerViewController()
playerViewController.player = AVPlayer(url: url)
self.present(playerViewController, animated: true)
playerViewController.player?.play()

may be you can check this https://github.com/tidwall/SwiftWebSocket @nicolasbigot


Moved code to seperate files to make it more readable

Instead of having all JavaScript code in the .html file, it has been moved to relevant .js files. This makes the project more manageable as it will be easier to read both the code and changes made to it from commits. No changes has been made to the actual code itself, only paths to include the new files.

Request was made from wrong branch. Branch was removed.


Not able to import modules

I'm trying to run through the demo notebook: https://colab.research.google.com/github/HazyResearch/domino/blob/main/examples/01_intro.ipynb#scrollTo=v6FoBKhOtcHm
I am not able to import from domino import embed I believe due to the directory structure of the repo.  When I clone the repo locally I am able to do from domino.domino import embed

Looks like the version on PyPI was out of date. I just updated it and confirmed that the notebook runs end to end on my side. Let me know if you're still unable to run it


Add ability to specify HTTP methods (verbs) when making a request.

Defaults to HTTP GET when not specified or when specified verb is invalid.

Coverage remained the same at 100.0% when pulling 506bb955421f381086552341611874f697dc4ef9 on jeffkayser:add-verbs into 24025ec7a589c9c8c6e0c78f843cbc60069fcc98 on OohlaLabs:master.

Hi Jeff, thanks for this, it makes sense. Requests has a request method that takes the verb as first argument.
Could you please replace with the following line and I'll merge and release on pypi:
response = requests.request(verb, "{}{}.json".format(self.ENDPOINT, target), params=params)

Coverage remained the same at 100.0% when pulling ea3679f1b7c2dca6b39a77e1a68ef74a8f7932c1 on jeffkayser:add-verbs into 24025ec7a589c9c8c6e0c78f843cbc60069fcc98 on jthi3rry:master.


change tkn image set in makefile

https://github.com/redhat-developer/mapt/issues/279

LGTM
so when we want to now push a released 8.0.0 image we can use, e.g make VERSION=8.0.0 tkn-push

Also I notice the tkn-bundle/tkn-check passed but that should not be the case, as the spec do not contain a valid image on it, it just contains the <IMAGE> field as the tkn-template is not being used there.
We have to issues there:

Ensure the template function is used somehow before they are deployed to the cluster on the check
Look for a way to dry/run or some type of test which may does not require credentials / or something we can pass empty  to test the task will be able to run.

@adrianriobo , I keep the orignal tkn yaml files and use another folder to store the templates. So tkn-bundle/tkn-check can check the validation of the tkn file. Also add make tkn-update in makefile for updating the version for tkn.


[BUG] New-PnPUPABulkImportJob: Method never returns a job id

Reporting an Issue or Missing Feature
Using the New-PnPUPABulkImportJob doesn't return the job id
Expected behavior
A job id is returned by the method
Actual behavior
No job id is returned by the method
The execution of the synchronization job did not return a job Id but seems to have started successfully. Use Get-PnPUPABulkImportStatus to check for the current status.
The execution of the synchronization job did not return a job Id but seems to have started successfully. Use Get-PnPUPABulkImportStatus to check for the current status.
The execution of the synchronization job did not return a job Id but seems to have started successfully. Use Get-PnPUPABulkImportStatus to check for the current status.
The execution of the synchronization job did not return a job Id but seems to have started successfully. Use Get-PnPUPABulkImportStatus to check for the current status.
The execution of the synchronization job did not return a job Id but seems to have started successfully. Use Get-PnPUPABulkImportStatus to check for the current status.
The execution of the synchronization job did not return a job Id but seems to have started successfully. Use Get-PnPUPABulkImportStatus to check for the current status.
The execution of the synchronization job did not return a job Id but seems to have started successfully. Use Get-PnPUPABulkImportStatus to check for the current status.
The execution of the synchronization job did not return a job Id but seems to have started successfully. Use Get-PnPUPABulkImportStatus to check for the current status.
The execution of the synchronization job did not return a job Id but seems to have started successfully. Use Get-PnPUPABulkImportStatus to check for the current status.
The execution of the synchronization job did not return a job Id but seems to have started successfully. Use Get-PnPUPABulkImportStatus to check for the current status.
Steps to reproduce behavior
Connect-PnpOnline -Url $tenantUrl -ClientId $clientId -ClientSecret $clientSecret -WarningAction Ignore
@"   {   "value": [     {       "IdName"<EMAIL_ADDRESS>      "Department": "PnP",     }, 	{       "IdName"<EMAIL_ADDRESS>      "Department": "PnP",     }       ] } "@ > profiles.json
$Items = 1..10 | ForEach-Object {     New-PnPUPABulkImportJob -Folder "Shared Documents" -Path profiles.json -IdProperty "IdName" -UserProfilePropertyMapping @{"Department"="Department"} }
What is the version of the Cmdlet module you are running?
PnP.PowerShell 1.11.0
Which operating system/environment are you running PnP PowerShell on?

[x] Windows
[ ] Linux
[ ] MacOS
[ ] Azure Cloud Shell
[ ] Azure Functions
[ ] Other : please specify

I once again tested it with version 1.9.0 and it works just fine:
New-PnPUPABulkImportJob -Folder "Shared Documents" -Path profiles.json -IdProperty "IdName" -UserProfilePropertyMapping @{"Department"="Department"}


Fixed a nav menu draw open, then closed horizontal scroll bug

Prior to bug fix, if you opened the nav menu then closed it without a
page reload, you would find a horizontal scroll on the main page with
overspill to the right hand side.

Do you have a link to a shop where we can see the issue? What browser(s) did it happen in?
Adding !important styles like this isn't ideal.

Here is a link to one site with the css fix removed, if you open the menu then open the submit then close the menu you should get a side scroll

On 6 Sep 2016, at 16:35, Carson Shold<EMAIL_ADDRESS>wrote:
Do you have a link to a shop where we can see the issue? What browser(s) did it happen in?
Adding !important styles like this isn't ideal.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/Shopify/Timber/pull/573#issuecomment-244991092, or mute the thread https://github.com/notifications/unsubscribe-auth/ABLuvnxOAMfDgV6s7ysZC3YlG6dRD2ovks5qnYhKgaJpZM4J0h7e.

https://tkastore-2.myshopify.com/pages/about-us

On 6 Sep 2016, at 21:50, Matthew Kennedy<EMAIL_ADDRESS>wrote:
Here is a link to one site with the css fix removed, if you open the menu then open the submit then close the menu you should get a side scroll

On 6 Sep 2016, at 16:35, Carson Shold<EMAIL_ADDRESS><EMAIL_ADDRESS>wrote:
Do you have a link to a shop where we can see the issue? What browser(s) did it happen in?
Adding !important styles like this isn't ideal.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/Shopify/Timber/pull/573#issuecomment-244991092, or mute the thread https://github.com/notifications/unsubscribe-auth/ABLuvnxOAMfDgV6s7ysZC3YlG6dRD2ovks5qnYhKgaJpZM4J0h7e.


Did this test on Ubuntu? I can't transfer to port 443 on my server.

I cloned this project. Try and debug to set up everthing.
But 443 port transmission doesn't work.
I use the command:
docker logs nginx
And the response is:
2017/08/21 09:26:52 [error] 7#7: *1 connect() failed (111: Connection refused) while connecting to upstream, client: xxx.xxx.xx.xx, server: xxx.xx, request: "GET / HTTP/1.1", upstream: "https://<IP_ADDRESS>:443/", host: "xxx.xx"
Is there any solution?

It seems that you are using local net work https://<IP_ADDRESS>:443/ which you probable changed the settings:
[...]
   ports:
      - <IP_ADDRESS>:443:443

You must keep it only 443:443 in order to get your external ip address, and it will work.

As of not geting any more replies... I will close this issue.


Fix handling of DH recommended private key length

While working with encoding (#13095), I stumbled on some pretty odd errors with the optional DH parameter field privateValueLength.
It turned out that we didn't pass that value when importing / exporting keys between legacy and provider implementations.
Also, it seems that we set that value arbitrarily when we shouldn't.  This is a user settable value that shouldn't be automated as far as I can tell.
It also seems that the test/evp_pkey_provided_test.c DH tests didn't reproduce the priv_len:224 appropriately
Fixes #12071

Actually 224 is appropriate according to the strength of the 2048 bit DH parameters. The key length should be 2* according to the FIPS requirements.

I think I had a related discussion with @slontis somewhere, but I cannot find it.

Actually 224 is appropriate according to the strength of the 2048 bit DH parameters. The key length should be 2* according to the FIPS requirements.

Not everyone follows FIPS, they might be subject to different jurisdictions than US or just want to be paranoid.
To me it makes sense that this value should be user settable, and only in FIPS mode you validate if this follows US requirements.
I would also be fine if, if not provided, this value is calculated according to a default, and the default being FIPS. But, this would be an optional feature in my eyes, as I don't think we supported such a default up to 1.1.1.

Also, does this same discussion apply to DSA?
And if not why not? (maybe we fixed it in DSA after the discussion I cannot find, but missed some DH corner cases?)
It could be for example that this surfaced as part of the work on test/recipes/20-test_cli_fips.t where only signatures are tested, so DSA is covered, but not DH!

@romen, DSAparams doesn't have a recommend length field, so this bit of DH is simply not relevant there.

So @t8m,are you saying that a 224 bit size private key is acceptable?

So @t8m,are you saying that a 224 bit size private key is acceptable?

Yes, for 2048 bit DH prime. I would stay with what we currently have as a default but would override if user explicitly sets the desired key length.

FIPS requirements are mentioned. What FIPS requirements are we talking about? FIPS-186 is about DSS, right? For key exchange, it seems that SP800-56A is the document to look at. I wonder if we're collectively confusing the two...

FIPS requirements are mentioned. What FIPS requirements are we talking about? FIPS-186 is about DSS, right? For key exchange, it seems that SP800-56A is the document to look at. I wonder if we're collectively confusing the two...

The private key size requirement for DH comes from https://nvlpubs.nist.gov/nistpubs/SpecialPublications/NIST.SP.800-56Ar3.pdf section <IP_ADDRESS>.1.

Ahhhhh!  I just discovered the following comment in the tests that were failing:
https://github.com/openssl/openssl/blob/a829b735b645516041b55746e013692babd8cd31/test/evp_pkey_provided_test.c#L425-L429
https://github.com/openssl/openssl/blob/a829b735b645516041b55746e013692babd8cd31/test/evp_pkey_provided_test.c#L565-L569
This is of course ok for <IP_ADDRESS>.1, but that hasn't been translated well in code, this value must be set in the fromdata calls as well, otherwise the length will get some sort of default, which is going to be either zero (unset, so internal defaults will be used)
However, it seems to me that for <IP_ADDRESS>.2, 224 is completely inappropriate (from SP800-56Ar3, underline mine):

<IP_ADDRESS>.2 Using the FIPS 186-Type FFC Parameter-size Sets
... For the key-pair generation methods in Sections <IP_ADDRESS>.3 and <IP_ADDRESS>.4, the value used for the input parameter N shall be len(q), i.e., the bit length of the domain parameter q. ...

You seem to be fixing #12071

You seem to be fixing #12071

Okie

You seem to be fixing #12071

I added a squash commit that adds a line for this in the commit message

@levitte <IP_ADDRESS>.2 applies when you use a key generated for DSA (FIPS 186-x) for DH. Or in other words if you do not use a safe prime and have the q value explicitly generated.

@levitte <IP_ADDRESS>.2 applies when you use a key generated for DSA (FIPS 186-x) for DH. Or in other words if you do not use a safe prime and have the q value explicitly generated.

Ah ok.
Either way, I've amended the test fix to specify the recommended private length in the parameters from EVP_PKEY_fromdata()

Note that we now have a value for q too in case of a safe prime, because <IP_ADDRESS>.1 requires us to have it. As far as I know, we didn't have it in 1.1.1 for either built-in groups or when loaded from a file. For a 2048 bit DH key using a safe prime, we would generate a 2048 bit number in 1.1.1 and a 2047 bit number in 3.0

And both these values are wrong because for 2048 bit safe prime 224 bit private key should be generated.

And both these values are wrong because for 2048 bit safe prime 224 bit private key should be generated.

Why? That doesn't seem to make sense to me.

Please read the thread above in regards to NIST SP800-56A requirements. There is also no security gain by having such long private key in comparison to the 224 bit one.

Please read the thread above in regards to NIST SP800-56A requirements. There is also no security gain by having such long private key in comparison to the 224 bit one.

As far as I know, this depends on it being a safe prime. rfc7919
has a minimum requirement of 225 for ffdhe2048.

Meanwhile, it would be nice if someone reviewed the current state of this PR.

Fixees -> Fixes

Fixees -> Fixes

Fixed :wink:

Did we previously support reading and writing that field for a PKCS#3 file? I guess at least one way of interpreting things is that DH_set_length() will cause it to be written to the file in PKCS#3 format, but not in X9.42 format.

Did we previously support reading and writing that field for a PKCS#3 file?

Nope.  In 1.1.1 DH_set_length() is entirely for other applications to use, we only actually use it on test/ssltest_old.c.  The pkeyopt priv_len is completely new in 3.0.

This PR has now been split.  The import/export fixes are moved to #13166, leaving the more controversial parts here.

#13166 got merged, so I rebased this.  Let's see how the CIs fare...

A question emerged when looking at this one more time: does the DH length have to be set when using safe / approved primes?  Leaving it zero simply means to apply sensible defaults, and those defaults could be made to match the requirements just as well, and if it is set by a DH_set_length() call, the key generation must check it for errors / incompatible values anyway (I suspect our checks are not sufficient).
In summary, it seems to me like the automated assignment of dh->length is misplaced, more or less everywhere, and our DH key generation may be lacking certain controls.

I expect length to be 0 as long as DH_set_length() is not called,
and that we use some kind of default in that case. Calling
DH_set_length() means the defaults are not good enough for
whatever reason.
One of the problems is that in general we don't even know if it's
a prime. But we now have a list of known safe primes, including those
that are approved for FIPS use. Note that some of the published
primes in various RFCs are not safe primes, but as far as I know,
all the ones in our list are.
I think in general, we're really like to deprecate support for DH
primes that are not a named safe prime.
For the named safe primes, we know what a reasonable value is for
the size of the generated key, and when length is to 0, we can use
that size.
For other DH paramaters that are not a named safe prime, we should
probably be more careful, and use different defaults.

@kroeckx, you have very eloquently echoed my concerns.  Thank you.

For other DH paramaters that are not a named safe prime, we should probably be more careful, and use different defaults.

This is what we currently have:
https://github.com/openssl/openssl/blob/f4bd510503071e20472032dc9d053810a1937e95/crypto/dh/dh_key.c#L273
I doubt we can do better, because this is what the PKCS#3 text says:

7.1 Private-value generation
An integer x, the private value, shall be generated privately and randomly. This integer shall satisfy 0 < x < p−1, unless the central authority specifies a private-value length l, in which case the integer shall satisfy 2l-1 ≤ x < 2l.

(note that l doesn't have an upper limit!...  so even though it would seem natural to not allow it to be bigger than the length in bits of p, that text doesn't actually say that it must)

Something is off with the way github presents the diff here. It should only be the last commit (a handful of lines), cf. https://github.com/openssl/openssl/compare/master...levitte:fix-dh-length, whereas I see 4 commits and +104/-58 lines.

Something is off with the way github presents the diff here

That's quite odd indeed.  Thanks for notifying us.
I dunno what to do about it, though.  Ideas anyone?

That's quite odd indeed. Thanks for notifying us.
I dunno what to do about it, though. Ideas anyone?

My first thought was that the github mirror had fallen behind the master repo. I've seen that happen before with the symptoms that PRs show commits from master that have already been merged. But that doesn't seem to be the case here. The commits showing here are clearly already merged, and have the same commit hashes as are shown for the main github repo mirror. Weird. Looks like a github bug of some description...

So I think the code was like this because:
when q was NULL the length was required in order to set the length of the generated private key. (I only added a precalculated q for the safe primes during 3.0).
I dont see a point in allowing a larger length
It is not allowed in fips.. (See ossl_ffc_generate_private_key() Step(2)). I was trying to pass a N value to this function by setting the length. Now that it is not set then N = qbits which is fine (but I think that is why it was propogated - to indicate the maximum length of the private key - which is what the docs describe the length field as).

So I think the code was like this because:
when q was NULL the length was required in order to set the length of the generated private key. (I only added a precalculated q for the safe primes during 3.0).

For PKCS#3, this length is related to the length of p, not of q.  And no, the length is not required, the code in dh_key.c applies appropriate defaults when it isn't set.
I haven't looked enough at our history to see in what chronological order this development came to be.

I dont see a point in allowing a larger length

Me neither, but the PKCS#3 wording allows it (it may have been an omission)

I dont see a point in allowing a larger length
It is not allowed in fips.. (See ossl_ffc_generate_private_key() Step(2)). I was trying to pass a N value to this function by setting the length. Now that it is not set then N = qbits which is fine (but I think that is why it was propagated - to indicate the maximum length of the private key - which is what the docs describe the length field as).

Yeah, and that could just as well be a default when dh->length() isn't set.  See, I can't see that SP800-56A says that N has to be stored in the DHparams structure, but it does imply that the length may be set, and that's that N will be assigned to if it is.

I think the dh_length should also be a gen_settable, settable and gettable if we are going to deprecate the low level DH functions.

It is already gen_settable and gettable.
As for settable, it depends on how we view DH_set_length()...
Is it a function of the same sort as DH_set0_pqg() et al?  Then we have EVP_PKEY_fromdata() to set input parameters when creating a keyparams EVP_PKEY.
Is it a function more like the ECDH cofactor setting function?  Then yeah, a settable is warranted.

As for settable, it depends on how we view DH_set_length()...

I view it as a function that is getting deprecated, and the effective EVP_PKEY replacement would allow you to set it at any time.

I view it as a function that is getting deprecated, and the effective EVP_PKEY replacement would allow you to set it at any time.

I'm not satisfied with that answer.  We have chosen to replace things like DH_set0_key() and DH_set0_pqg() etc with EVP_PKEY_fromdata().  So I'll ask again, is DH_set_length() the same type of function as DH_set0_pqg(), or is it a different thing (they both set key parameters)?

EVP_PKEY_fromdata() was added to load raw key..
I think this question needs to be raised in an OTC meeting in regards to setting any of the deprecated functions including things like DH_set0_pqg(). It is a design decision.
I wont hold the PR up on the question though.

IMO the DH length should be settable because this is just an indication of preference for the private key length.

EVP_PKEY_fromdata() was added to load a key from raw data..

It was actually added to construct any valid EVP_PKEY from raw data.  Basically, it's there to replace this sort of code sequence:
DH *dh = DH_new();
EVP_PKEY *pkey = EVP_PKEY_new();

DH_set0_key(dh, somenum, someothernum);
DH_set0_pqg(dh, some_p, some_q, some_g);
EVP_PKEY_assign_DH(pkey, dh);

I think this question needs to be raised in an OTC meeting in regards to setting any of the deprecated functions including things like DH_set0_pqg(). It is a design decision.

We actually had that discussion quite a while ago...  a year ago perhaps?  At that time, the choice was that we would not allow manipulation of individual key material items (which includes key parameters).  You want to re-open that question?  Feel free.  Me, I'm continuously concerned that the "design" becomes a moving target, that's not a way to reach a point of release...

I wont hold the PR up on the question though.

Thanks.

IMO the DH length should be settable because this is just an indication of preference for the private key length.

Thank you for stating an opinion on that.  That helps.

BTW, the dopic of this PR is to stop the arbitrary settings of the length, and to ensure that it's passed on an import / export between libcrypto and providers.  I think it should stay that way.
Whether we want the length to be settable individually or via EVP_PKEY_fromdata(), the work can be done in another PR.
With that said, I'd like to see a final review of this PR as it currently stands.

Ping

Ping

This pull request is ready to merge

Merged
28e1d588f14404d480cc2bd38827ecd587625643 DH: stop setting the private key length arbitrarily


Try to speed up CI

Use more optimized emulator startup settings
Use ATDs

https://android-developers.googleblog.com/2021/10/whats-new-in-scalable-automated-testing.html
https://blog.emulator.wtf/posts/2022-04-15-atd-images/

Cache emulators
Assemble the androidTest APK in the build step to save time (parallelizing, shared configuration)

Well, some parts of gradle's action don't seem to work (namely caching wrapper binaries). Will raise that separately.


armadillo: 14.0.0 -> 14.0.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/project/armadillo/versions.
meta.description for armadillo is: C++ linear algebra library
meta.homepage for armadillo is: https://arma.sourceforge.net
Updates performed

Version update

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 14.0.1 with grep in /nix/store/47sccf17hf200rpavfvi4p9lmq357f1h-armadillo-14.0.1
found 14.0.1 in filename of file in /nix/store/47sccf17hf200rpavfvi4p9lmq357f1h-armadillo-14.0.1

Rebuild report (if merged into master) (click to expand)

80 total rebuild path(s)

80 package rebuild(s)

First fifty rebuilds by attrpath

apacheHttpdPackages.mod_tile
apacheHttpdPackages_2_4.mod_tile
armadillo
cloudcompare
entwine
gdal
gmt
gplates
haskellPackages.hgdal
in-formant
mapcache
mapnik
mapproxy
mapserver
merkaartor
mysql-workbench
octavePackages.mapping
openmolcas
openorienteering-mapper
paraview
pdal
perl536Packages.Tirex
perl538Packages.Tirex
python311Packages.bsuite
python311Packages.cartopy
python311Packages.django-bootstrap4
python311Packages.django-bootstrap5
python311Packages.fiona
python311Packages.folium
python311Packages.gdal
python311Packages.geodatasets
python311Packages.geopandas
python311Packages.inequality
python311Packages.libpysal
python311Packages.mapclassify
python311Packages.momepy
python311Packages.morecantile
python311Packages.osmnx
python311Packages.plotnine
python311Packages.pygmt
python311Packages.pyogrio
python311Packages.python-mapnik
python311Packages.rasterio
python311Packages.rio-tiler
python311Packages.rioxarray
python311Packages.shimmy
python311Packages.wktutils
python311Packages.worldengine
python312Packages.bsuite

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/47sccf17hf200rpavfvi4p9lmq357f1h-armadillo-14.0.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A armadillo https://github.com/r-ryantm/nixpkgs/archive/9c3b0c73ad257e527099179a90d9f4a6f1d32f9a.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/9c3b0c73ad257e527099179a90d9f4a6f1d32f9a#armadillo

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/47sccf17hf200rpavfvi4p9lmq357f1h-armadillo-14.0.1
ls -la /nix/store/47sccf17hf200rpavfvi4p9lmq357f1h-armadillo-14.0.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

4 packages marked as broken and skipped:

python311Packages.worldengine
python311Packages.worldengine.dist
python312Packages.worldengine
python312Packages.worldengine.dist

51 packages failed to build:

apacheHttpdPackages.mod_tile
mysql-workbench
python311Packages.bsuite
python311Packages.bsuite.dist
python311Packages.cartopy
python311Packages.cartopy.dist
python311Packages.django-bootstrap4
python311Packages.django-bootstrap4.dist
python311Packages.django-bootstrap5
python311Packages.django-bootstrap5.dist
python311Packages.fiona
python311Packages.fiona.dist
python311Packages.folium
python311Packages.folium.dist
python311Packages.gdal
python311Packages.geodatasets
python311Packages.geodatasets.dist
python311Packages.geopandas
python311Packages.geopandas.dist
python311Packages.inequality
python311Packages.inequality.dist
python311Packages.libpysal
python311Packages.libpysal.dist
python311Packages.mapclassify
python311Packages.mapclassify.dist
python311Packages.momepy
python311Packages.momepy.dist
python311Packages.morecantile
python311Packages.morecantile.dist
python311Packages.osmnx
python311Packages.osmnx.dist
python311Packages.plotnine
python311Packages.plotnine.dist
python311Packages.pyogrio
python311Packages.pyogrio.dist
python311Packages.rasterio
python311Packages.rasterio.dist
python311Packages.rio-tiler
python311Packages.rio-tiler.dist
python311Packages.rioxarray
python311Packages.rioxarray.dist
python311Packages.shimmy
python311Packages.shimmy.dist
python311Packages.wktutils
python311Packages.wktutils.dist
python312Packages.folium
python312Packages.folium.dist
python312Packages.momepy
python312Packages.momepy.dist
python312Packages.osmnx
python312Packages.osmnx.dist

70 packages built:

armadillo
cloudcompare
entwine
gdal (python312Packages.gdal)
gmt
gplates
in-formant
mapcache
mapnik
mapproxy
mapproxy.dist
mapserver
merkaartor
octavePackages.mapping
openmolcas
openorienteering-mapper
paraview
pdal
perl536Packages.Tirex
perl536Packages.Tirex.devdoc
perl538Packages.Tirex
perl538Packages.Tirex.devdoc
python311Packages.pygmt
python311Packages.pygmt.dist
python311Packages.python-mapnik
python311Packages.python-mapnik.dist
python312Packages.bsuite
python312Packages.bsuite.dist
python312Packages.cartopy
python312Packages.cartopy.dist
python312Packages.django-bootstrap4
python312Packages.django-bootstrap4.dist
python312Packages.django-bootstrap5
python312Packages.django-bootstrap5.dist
python312Packages.fiona
python312Packages.fiona.dist
python312Packages.geodatasets
python312Packages.geodatasets.dist
python312Packages.geopandas
python312Packages.geopandas.dist
python312Packages.inequality
python312Packages.inequality.dist
python312Packages.libpysal
python312Packages.libpysal.dist
python312Packages.mapclassify
python312Packages.mapclassify.dist
python312Packages.morecantile
python312Packages.morecantile.dist
python312Packages.plotnine
python312Packages.plotnine.dist
python312Packages.pygmt
python312Packages.pygmt.dist
python312Packages.pyogrio
python312Packages.pyogrio.dist
python312Packages.rasterio
python312Packages.rasterio.dist
python312Packages.rio-tiler
python312Packages.rio-tiler.dist
python312Packages.rioxarray
python312Packages.rioxarray.dist
python312Packages.wktutils
python312Packages.wktutils.dist
pytrainer
pytrainer.dist
qmapshack
saga
sumo
t-rex
udig
vpv

Maintainer pings
cc @juliendehos @knedlsepp for testing.

It is indicated that 51 packages failed to build, though.

Oops, indeed. I just ran my test programs and didn't check that, sorry.


chore: update references to nuxt/nuxt

🔗 Linked issue
❓ Type of change

[ ] 📖 Documentation (updates to the documentation or readme)
[ ] 🐞 Bug fix (a non-breaking change that fixes an issue)
[ ] 👌 Enhancement (improving an existing functionality like performance)
[ ] ✨ New feature (a non-breaking change that adds functionality)
[x] 🧹 Chore (updates to the build process or auxiliary tools and libraries)
[ ] ⚠ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description
Update repo references.
📝 Checklist

[ ] I have linked an issue or discussion.
[ ] I have updated the documentation accordingly.

Thanks!


JQUERY Version

Superior job on coding this application. Jquery 1.12 is the latest and greatest for ajax.googleapis.com. Will the emulator work with the newer version?

It works..


ReferenceError: _typeof2 is not defined

In development it works fine while in production it doesn't work at all.
I tried updating versions and excluding /mapbox-gl/ and /node_modules/ in webpack.config.js

+1 Same for me. Still not able to figuring out.

Same issue (though my error says t is undefined) with create react app 4 and 5.1.1 of this library... 👎


mir_robot: 1.0.2-0 in 'kinetic/distribution.yaml' [bloom]

Increasing version of package(s) in repository mir_robot to 1.0.2-0:

upstream repository: https://github.com/dfki-ric/mir_robot.git
release repository: https://github.com/uos-gbp/mir_robot-release.git
distro file: kinetic/distribution.yaml
bloom version: 0.6.6
previous version for package: 1.0.1-0

mir_actions

No changes

mir_description

No changes

mir_driver

No changes

mir_gazebo
* mir_gazebo: Install config directory
* Contributors: Martin Günther

mir_msgs

No changes

mir_navigation

No changes

mir_robot
* Add metapackage
* Contributors: Martin Günther

retriggered travis


Find & replace

To make a simple editor feature, could you add find and replace for every code column?
Also I want to thank you for this awesome app. It's absolutely better than others.

Why is this issue closed? It's not working right now so I'm wondering ... was it fixed at some point or is it broken ever since?

@rafaelcastrocouto this issue isn't closed. It never was.

Oh ... ok sorry remy ... gonna try to fix this ... I'm tired of copy/paste into a local text editor to replace stuff.

Seens like you are just missing the dialog.css (http://codemirror.net/addon/dialog/dialog.css) ... everything else is working just fine.

hey, I just did a quick pull request while adding @rafaelcastrocouto 's code ( thx :p ) to fix the find & replace dialog troubles
see https://github.com/jsbin/jsbin/pull/3447
+


Trace text background assumed to be always dark

When looking at My Traces / edit, what is not too hard to read on a dark background:

Becomes a usability disaster on a light background:

I wonder if ditching the magenta for plain white on black would fix it for all cases.

Yeah, I never loved the pink. There are lots of ways we could make custom data nicer, but this is an easy one.


Base map style editing

Currently users can select one of existing base maps, but cannot change styles. For customized base maps easiest option would be to use mapbox tiles - which is another external service; also when user already uses mapbox for base maps and can also upload own data there, then there is question why cartodb is needed at all.
Proposal - for some base map types (e.g. vector/combined like #7181 ) support style editing / customization. It could be very basic - just a single text-based CartoCSS editor with style change preview; or later very complex like mapbox studio. Editing could be opened from base map selection view.

There has been no activity on this issue for more several months. We are closing it. If you think this still needs to be addressed please open a new issue.


Feature/1837 opp naming action

My notes to reviewer here are very rinse-and-repeat-y from the last one.
Once again, used the Action naming convention.
Once again, labels got all weird via the contrib tool, so only my changes to OPP_OpportunityNaming_Action and OPP_OpportunityNaming_TEST should be merged.
The test class is getting repetitive, and if you don't want to merge the tests as is, I would understand that. The class is just a minor wrapper around the tested code, so the test method provided is purely for coverage reasons. As more global interfaces to NPSP functionality are created, I'd love some guidance on what replication in tests is a-ok/what should be split out a little bit/where real love is needed.
Contribution Info
This external contribution was submitted by @cdcarter and Fixes #1837
Changes
Adds a global @InvocableMethod class OPP_OpportunityNaming_Action to provide a method to force opportunity renaming programmatically (via Apex, Flow, or PB).

Attempting to use my gitfu to strip the annoyances out of this PR, let's see how I do.

replaced with pr #1883


Feature request: provide way to identify objects of interest when using typed query.

Expected and Current Behavior
See http://stackoverflow.com/questions/43490430/how-to-filter-relevant-objects-with-neo4j-ogm-typed-query
Possible Solution
Extend the query method to support a result column parameter:
 Iterable query(Class objectType, String cypher, Map<String, ?> parameters, Set columnsToMap);
The return value should only contain nodes from columns specified in columnsToMap.
But I don't know if this is feasible or not ...
Your Environment

OGM Version used: 2.1.1
Neo4J Version used: 3.1.1

Seems to be possible already using QueryResult.get()...
But somehow the nodes returned via this method don't contain all dependencies fetched via optional matches. (whereas they do via query(Class objectType, String cypher, Map<String, ?> parameters).
What could be the reason for that?

Relates to #496

See also https://github.com/neo4j/neo4j-ogm/issues/465

I can only quote @frant-hartm answer from SO here.

The reason for this is that your parents also match the type you pass in the query method - the A.class.
OGM has no way to know what your actual wanted result is and hence maps all matching nodes to the result - one row may result in 2 or even more items in the result list. (Note that some people have the opposite use case and actually want that to happen).

We are not planning to broaden our API here even more. Thanks for your understanding.


Plans for Swift 6 concurrency?

Do you have plans to make Turbo iOS compliant with Swift 6 concurrency? It's difficult (maybe impossible) right now to use Turbo as a dependency in an app that is enforcing the concurrency rules.

Swift 6's strict concurrency is quite new, so we don't have specific plans to implement it yet. It's definitely something that will come up sooner rather than later, though, so it's on our radar.

If I were to submit a PR that added the concurrency support, would you consider it and merge if it met your standards?
I'm haven't looked into how much work it is, but I don't want to be on a private fork or do the work to make it a PR if it's not likely to be accepted.

Thanks for offering! Unfortunately, we're not ready to commit to implementing Swift concurrency in the near future, so we would not consider a PR that added concurrency support.


[clap-cleveraudio] New port

[x] Changes comply with the maintainer guide
[x] The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
[x] Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx
[x] The versioning scheme in vcpkg.json matches what upstream says.
[x] The license declaration in vcpkg.json matches what upstream says.
[x] The installed as the "copyright" file matches what upstream says.
[x] The source code of the component installed comes from an authoritative source.
[x] The generated "usage text" is accurate. See adding-usage for context.
[x] The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
[x] Only one version is in the new port's versions file.
[x] Only one version is added to each modified port's versions file.

Thanks for the suggestions, they should have been addressed now.
The additional option was due to earlier experiments that were solved using vcpkg helper functions instead, but I forgot to remove them afterwards.

Tested usage successfully by clap-cleveraudio:x64-windows:
clap-cleveraudio provides CMake targets:

  # this is heuristically generated, and may not be correct
  find_package(clap CONFIG REQUIRED)
  target_link_libraries(main PRIVATE clap)


GaussianMixture in scikit-learn triggers deadlocks

Describe the bug
The ``GaussianMixture'' routine triggers deadlocks, which is a know feature apparently: https://github.com/scikit-learn/scikit-learn/issues/19272
Can we find an alternative method (possibly from another package) that is not subject to this ?

This turns out to be a feature of Python. As such, I don't plan to fix it anytime soon.


Upload sample yaml files for spc-sp crd

Why is this change necessary ?
fixes: openebs/openebs#1016

How does this change address the issue ?
spc-crd.yaml - storagepoolclaim custom resouce definition
storagepool-crd.yaml - storagepool custom resouce definition
sdc-spc.yaml - sample resouce for spc
sdd-spc.yaml - sample resouce for spc

How to verify this change ?
kubectl apply -f spc-crd.yaml
kubectl apply -f storagepool-crd.yaml
kubectl apply -f sdc-crd.yaml
kubectl apply -f sdd-crd.yaml

Signed-off-by: gkGaneshR<EMAIL_ADDRESS>
What this PR does / why we need it:
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Special notes for your reviewer:

@prateekpandey14 I have made the changes. Please do review


Feature request: Search the block pattern directory

Besides the theme and plugin directories, there is now also the block pattern directory.
I would find it useful to be able to search the pattern directory for example when the Gutenberg contributors are making changes to block markup and CSS classes, since some patterns may need to be updated.

This is a great idea! @PeterBooker (hopefully this is the right person), there already should be a public API available as the block editor reads the directory, too.
There are quite a few other use cases for a search of the Block Pattern Directory for certain blocks used, or most favorite attributes :-)


Install Folder?

I'm wondering, can you use the edit saber, without actually owning the game. I'd just like to try out the editor, but whenever it starts, it just says,
"Please enter your BeatSaber install folder"
I think it's the file I'm supposed to transfer the finished songs to, but I just wanted to try posting on Beat Saver.
Any ideas on what the start screen is about here?

The directory can be anywhere on your PC.
It's just asking for the install directory of Beat Saber for convenience.
Please have someone playtest your track several times before submitting it.
You can really only know if a map is good by playing it.

Got it. But it's not like bringing up the finder window like any other save-to-file system. I need to type something. Is it a url thing or just a file name or what?

try with just manually making it with empty folders.
C:\Program Files (x86)\Steam\steamapps\common\Beat Saber\CustomSongs\

I did it! Thanks!


add language selector to UI

Right now we depend on underlying browser configuration to pick a language. We should offer a language selector (little flags?) in the UI so users can easily override their browser default.
Suggested by @ptillemans in IRC.

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/5782790-add-language-selector-to-ui?utm_campaign=plugin&utm_content=tracker%2F85909&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F85909&utm_medium=issues&utm_source=github).

+1 from @revi on #3411:

Currently gratipay (seems to) get user's language information and show that language's translation automatically, but I want to use English only (not translated one), but I cannot find any option for language on settings.

I'd either use a list with ISO language codes or a list of language names in the language itself, such as the one Wikipedia uses. Or maybe both, mixed together.

Maybe use CLDR?

It is still a problem. Since in my language it is half translated and I want to use it only in English, makes it hard to use.

+1
I hate half-translated languages and would prefer using English anyway because I fear loss of information during the translation which I could easily circumvent by just reading the original in English. There is, for example, a string that I can't properly interpret and have the strong feeling it was translated wrongly, but I can't even check that because without changing browser settings. Actually, I just did that so the problem will hopefully be going away. And yes, the translation is wrong.

And yes, the translation is wrong.

@FichteFoll Care to submit a fix? :)

Thanks for the pointer, I think I did this right: https://www.transifex.com/gratipay/gratipay/translate/#de/core/35897103

I've accepted your suggestion on Transifex and made a new release. Can you confirm whether the translation is fixed?

Confirmed. :+1:

Cool, thanks for the contribution! :-)

+1 on Twitter.


fix brokerProducer goroutine leak

Every create a of a brokerProducer spins off a goroutine for the run()
loop func, but this appeared to just be abandoned if the brokerProducer
was shutdown and would manifest as orphaned goroutine(s) with a long
select time leaking over time:
e.g.,
goroutine 6982 [select, 1868 minutes]:
github.com/Shopify/sarama.(*brokerProducer).run(0xc420c4ac00)
	/home/travis/build/org/repo/vendor/src/github.com/Shopify/sarama/async_producer.go:672 +0x258
github.com/Shopify/sarama.(*brokerProducer).(github.com/Shopify/sarama.run)-fm()
	/home/travis/build/org/repo/vendor/src/github.com/Shopify/sarama/async_producer.go:622 +0x2a
github.com/Shopify/sarama.withRecover(0xc4207aa3f0)
	/home/travis/build/org/repo/vendor/src/github.com/Shopify/sarama/utils.go:45 +0x43
created by github.com/Shopify/sarama.(*asyncProducer).newBrokerProducer
	/home/travis/build/org/repo/vendor/src/github.com/Shopify/sarama/async_producer.go:622 +0x1b8

Tidied up some chan waits that weren't checking the ok state and also
added an explicit stopchan for the run loop and a unittest to cover the
leak case.

Thanks for doing this. Looks like there's a bunch of legit failures 🤔

@bai yeah I need to analyze that Travis output because it wasn't deterministic (a rebuild had different results to the previous build). I'll update the PR as I work through them

@bai I tracked down the issue (the abandoned channel is intentionally closed to trigger abandonment). I also ended up pulling in github.com/fortytw2/leaktest  as a test-only dependency as it was better than my home-rolled NumGoroutine counting as it does things like status polling and filtering out routines it should ignore etc.


Muisje/issue143

Added functionality for handling multiple audio tracks.
Improved handling of skipping of subtitle generation.
Added class for dealing with language codes

Looks nice.  I’ll have to take a deeper look later.  Instead of extracting and saving the audio to the file system, you should be able to pass it straight to gen_subtitles and keep it in memory.  Would save file read/write times at the expense of memory usage.
I also need to figure out how to package it better.  Your current breakout of languages would require me to update the docker images (not a big deal) and launcher.py to download it.

Yeah i agree. Now extracts it to memory as bytes

Out of the gate, I get ```
File "/Users/scott/Documents/whispertest/subgen/subgen.py", line 751, in get_audio_tracks
except ffmpeg.Error as e:
^^^^^^^^^^^^
AttributeError: module 'ffmpeg' has no attribute 'Error'
ffmpeg-python doesn't raise 'Error'.

Looks great, I'll probably merge it later today with some small changes following.  I might use the opportunity to clean up the naming, kind of like you did, and expand some options.


Sandbox: Fix update to webpack 5

Problem
After updating to webpack 5, the build/test invocation introduced a few warnings.

GH-861

Solution
Follow the advice to not use style-loader and mini-css-extract-loader together.

https://github.com/webpack-contrib/mini-css-extract-plugin/issues/613#issuecomment-707653736

Does make sense that we maintain this proj in any capacity?


Added Langchain to BR migration example

Issue #, if available:
N/A
Description of changes:
Added an example to migrate from langchain to BR
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Please re do this PR following the new layout and the process for creating the required file . We request all files to have a presence on the Cookbook / Recipes Website which is fronting this github repo now. Some of the mandatory sections of the notebook need to include

Overview.
What are we demonstrating .
What use case .
What will you learn.
What is the architectural pattern and why we select this. With a diagram
What are the libraries to install
What model did we choose and why this model
Every cell needs to have a markup


Change page title according to open documentation

It would be nice if the docat page would change it's title (as in <title>) - and maybe even the favicon - according the the currently open documentation.
The title could e.g. include the project name and version - maybe also with | docat as a suffix.

fixed thanks @dinakar29 :taco:


Some APIs from the Windows SDK 10.0.16299 are missing

The Windows SDK 10.0.16299 includes some APIs which are missing from the Rust bindings. Specifically the stuff from the windows::web::ui::interop namespace. Is this intentional? I tried to use the C# generator application and it produced sources which contain missing APIs. Is there any reason to exclude them from the crate?

When you run the generator yourself and there are APIs that are not checked in, it means that they weren't there when I last ran the generator. I have now published version 0.5.1 which includes those new APIs.
In general, solving #50 would allow us to run the generator always on the machine where the library is used, so you could also choose which SDK version you want to target. I don't know if this is always the best thing to do (i.e. if someone is building winrt-rust as a dependency, it might not be the right thing to expect them to have the correct SDK installed) ... we should look into how it's handled in C++/WinRT.

Great! Thank you for the new version. This will help a lot.
And I don't think it's a good idea to run the generator application during the build process. This leads to non-deterministic outcomes, because users will have an arbitrary version of the SDK installed. Generally builds should be reproducible.

Referencing #21 concerning the question about when to run the generator.


Include usage object in openai streaming response by default

What Happened?
To get the usage object, the user has to pass streaming_options: { include_usage: true}
This can be default behaviour
What Should Have Happened?
No response
Relevant Code Snippet
No response
Your Twitter/LinkedIn
No response

tested this for all chat models of openai


fails to build on ia64

The library fails to build on ia64 systems:
../../src/pink-linux-trace-ia64.c:48:14: error: expected declaration specifiers or '...' before numeric constant
../../src/pink-linux-trace-ia64.c: In function 'pink_util_get_arg':
../../src/pink-linux-trace-ia64.c:127:2: warning: implicit declaration of function 'pink_util_arg_setup_ia64' [-Wimplicit-function-declaration]

Full build log:
https://buildd.debian.org/status/fetch.php?pkg=pinktrace&arch=ia64&ver=0.1.2-1&stamp=1330859174

Removing the PINK_NONNULL(3) line fixes the bug.


Blazor

Please update this site for Blazor Wasm dontnet 5.0

@wcpinyan Are you referring to a specific docs page?


Wrong configuration of attributes for centos. sysvinit race condition.

Hello,
Using centos 7 with install_method = 'distro' and using package mongodb-server, not mongodb-org-server. There following issues:

System user is mongodb not mongod.
Cookbook provides configuration for redhat sysvinit (not systemd). But the distro ships already with systemd services for mongo which are tried by default and service doesn't start.

Here are workarounds to make it work https://gist.github.com/anonymous/7b987146509a19a313cd.
I guess, the cookbook should provide native support for systemd or just doesn't work with the described scenario...

https://github.com/edelight/chef-mongodb/pull/409


refactor: respect Coinbase wallet optons when preloading

Problem solved
Short description of the bug fixed or feature added
Changes made

[ ] Public API changes: list the public API changes made if any
[ ] Internal API changes: explain the internal logic changes

How to test

[ ] Automated tests: link to unit test file
[ ] Manual tests: step by step instructions on how to test

Contributor NFT
Paste in your wallet address below and we will airdrop you a special NFT when your pull request is merged.
Address:

PR-Codex overview
The focus of this PR is to respect the coinbase wallet create settings when preloading the provider.
Detailed summary

Added import for CreateWalletArgs from wallet-types.js
Updated usePreloadWalletProviders to pass create settings to getCoinbaseWebProvider

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

#3364  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @joaquim-verges and the rest of your teammates on  Graphite

fixes #3350


Unable to build production website

Getting this error when building the production bundle / react snap pages:
🔥  error at /projects: Error: Page crashed!
    at Page._onTargetCrashed (/home/ryan/Personal/uwpcommunity.github.io/node_modules/puppeteer/lib/Page.js:215:24)
    at CDPSession.<anonymous> (/home/ryan/Personal/uwpcommunity.github.io/node_modules/puppeteer/lib/Page.js:123:56)
    at CDPSession.emit (events.js:321:20)
    at CDPSession._onMessage (/home/ryan/Personal/uwpcommunity.github.io/node_modules/puppeteer/lib/Connection.js:200:12)
    at Connection._onMessage (/home/ryan/Personal/uwpcommunity.github.io/node_modules/puppeteer/lib/Connection.js:112:17)
    at WebSocket.<anonymous> (/home/ryan/Personal/uwpcommunity.github.io/node_modules/puppeteer/lib/WebSocketTransport.js:44:24)
    at WebSocket.onMessage (/home/ryan/Personal/uwpcommunity.github.io/node_modules/puppeteer/node_modules/ws/lib/event-target.js:120:16)
    at WebSocket.emit (events.js:321:20)
    at Receiver.receiverOnMessage (/home/ryan/Personal/uwpcommunity.github.io/node_modules/puppeteer/node_modules/ws/lib/websocket.js:789:20)
    at Receiver.emit (events.js:321:20)

Seemed to have just been an issue on my linux install
¯_(ツ)_/¯


chore: Check links with lychee

Adds an npm script for running lychee against a locally running site.
https://github.com/lycheeverse/lychee

I worry a little bit about this being flaky when run a lot if sites block robots or similar, if this ends up going in CI/blocking a deploy that could be annoying.

I'd maybe add it to the check:all script as well

Needs a running server which I think would trigger an unexpected failure.
I wrote this script:
#!/usr/bin/env bash

# Spins up the docs site (on a non-default port) and runs lychee against it to
# check for broken links.

set -e

bundle exec jekyll serve --port 4001 > /dev/null 2>&1 &
pid=$!

attempts=0
until curl --output /dev/null --silent --head --fail http://localhost:4001; do
    attempts=$((attempts+1))
    if [ $attempts -ge 10 ]; then
        echo "max attempts exceeded"
        exit 1
    fi
    echo "waiting for server"
    sleep 1
done

lychee -v http://localhost:4001

kill $pid

Which would spin up a site on 4001 and check against that. I was going to check that in and run it in ci, but got kinda lazy with actually getting lychee installed (I'm yamled out).

I worry a little bit about this being flaky when run a lot if sites block robots or similar, if this ends up going in CI/blocking a deploy that could be annoying.

The goal is really to check links against our site & docs. It's easy enough to exclude external sites as necessary. I just wanted something that we could use to quickly check that our links are working, and give us confidence when moving/updating docs.
I plan on setting this up on glaredb.com too since we have links to docs in the blog posts, and I'd rather be proactive about updating links than not know we broke them in the first place.

should have it run more in a cron on the main site just so that broken docs links won't linger too long in the main site, but this seems reasonable,


Add support for  in SelectField

Add support for  in SelectField as described in issue #656

Please rebase this onto master, 2.3.x will not get another feature release.

Thank you for your contribution. You still have some tests failing, and some style issues.

@Giandrop are you still interested in solving the issues related to this PR?

Sorry, I completly forgot about this. I will be revisiting it during this weekend.

Thank you!


Figure out how to test plugins (on OEM side)

Currently our plugin template and plugin docs have no recommendation for how to test a plugin. We should probably figure out what to do here.

We also need a story for testing the native side of a plugin. Looking at flutter/plugins most (all?) of our first-party plugins only test the dart side of things.

Yes, definitely, I consider that part of the scope of this bug!

This seems like something that could be classified as plugin framework maintenance, so I'm leaving this in the current milestone. Please move it out of this milestone if it is not on your near-term radar. Thanks.

I'm interested in working on this issue. The Android implementation of image_picker currently has a pretty good test coverage and the tests can be found here. I've started to investigate on bringing the iOS implementation under tests as well.
@mit-mit Just to be clear, what is required to consider this issue resolved?
Is it:

modifying the plugin templates to include necessary setup and sample tests for Android and iOS implementations of the plugin
creating a "Testing plugins" article (or section in the Plugins documentation) on the flutter.io website
both
something else?

cc @mravn-google for his thoughts also
Fantastic to hear that you are looking into this! I think the ideal solution would indeed include considering templates and documentation. But I also wonder if an ideal solution would need to include a test framework capable of spanning both Flutter and native? For example, write a test that triggers an action in the Flutter UI, and then tests for a reaction in the native UI. How are you handling that type of use case (e.g. click a button in Flutter that opens the Gallery in native)?

@roughike I see you mention tests for image_picker, but they're implemented in the example app inside that project.
I think we should have unit tests that don't involve apps, but I don't know what's the official way around it. People have been manually adding compile ... flutter.jar to their plugin gradles, but that's a hack at best. If there is an alternative way of doing it I'd love to learn about it. So far there's no mention of flutter except it's either a full fledged app or a plugin example app.

But I also wonder if an ideal solution would need to include a test framework capable of spanning both Flutter and native?

More like integration or end-to-end tests? That would be awesome, but I have no idea currently how to do those.
My current idea, that has worked pretty well, has been this:

extract the heavy plugin logic into a delegate class; see ImagePickerDelegate.java
the plugin class that handles the MethodChannel registration should now be really lean. It should only determine what method we want to do and then rely on the delegate class to do the actual work; see ImagePickerPlugin.java

With this setup, we can:

test the plugin contract on the implementation side by mocking the delegate class; see ImagePickerPluginTest.java
if needed, test that the delegate class does the things we want. Relying heavily on mocking every dependency; see ImagePickerDelegateTest.java

I expect we can use a similar approach for iOS as well. Of course, this doesn't test the Dart -> MethodChannel -> native implementation end-to-end, but I feel this is still a reasonable way.

I see you mention tests for image_picker, but they're implemented in the example app inside that project.

@fmatosqg The tests test only the plugin and don't really depend on the example app. The tests can be moved from example/android to android directory, but last time I did it, I had problems with the imports regarding the MethodChannel apis; moving the tests under the example/android directory solved those problems.
So the tests actually test the image_picker plugin and nothing else, but they just live inside example/android directory because otherwise they wouldn't compile.

@roughike, your suggestion makes sense. flutter_driver may not be required for some tests. We have LiveTestWidgetsFlutterBinding that you can flutter run. flutter_driver is useful when you are testing performance, or need to script things like saving screenshots and/or call adb commands from within the test.
That said, neither LiveTestWidgetsFlutterBinding nor flutter_driver give you a way to choose between real and mock plugin implementations, so something like what you are suggesting is needed for completeness.

On a superficial reading, I see that Dart's canonical testing framework has "plugins" for running Dart unit tests 1. In a VM, and 2. In a browser. The documentation implies that their plugin approach should allow for other implementations, perhaps a Flutter/iOS/Android plugin??
I will like to be able to run Dart unit tests on-device, so that my tests can use the plugins on which my classes depend. This is currently a real omission. Currently this is not possible without rigging up my own testing framework for invocation using the flutter "driver". An alternative is to do regular testing and mock-out the plugins, but this gives me less confidence.

I agree that we should be able to unit test inside the plugin and not under the example app. For now putting manually the flutter.jar inside the gradle file look good enough for but it should be at least mention somewhere in the doc.
Here is what I put in my gradle to make test ok
dependencies {
    ...
    testImplementation files(getFlutterDependencyPath())
}

String getFlutterDependencyPath() {
    def localProperties = new Properties()
    def localPropertiesFile = rootProject.file('local.properties')
    if (localPropertiesFile.exists()) {
        localPropertiesFile.withReader('UTF-8') { reader ->
            localProperties.load(reader)
        }
    }

    def flutterRoot = localProperties.getProperty('flutter.sdk')
    if (flutterRoot == null) {
        throw new GradleException("Flutter SDK not found. Define location with flutter.sdk in the local.properties file.")
    }

    java.nio.file.Path baseEnginePath = Paths.get(flutterRoot, "bin", "cache", "artifacts", "engine")
    String targetArch = 'arm'
    if (project.hasProperty('target-platform') &&
            project.property('target-platform') == 'android-arm64') {
        targetArch = 'arm64'
    }
    return "$baseEnginePath/android-$targetArch/flutter.jar"
}

Your idea to be able to test end to end from dart to native is really good too ! Would be awesome to be able to test this (without a device)

I can add one more use case here for context.
I opened a PR in flutter/plugins/#1159 to add support for passwordless sign in in Firebase Auth.
This requires some plugin code to call native APIs, and some platform code to handle incoming dynamic links.
Perhaps moving towards a full end-to-end test would be valuable here, as the entire flow for passwordless sign in requires that:

clients can use the plugin to call into the native APIs
clients can register to receive dynamic links via an EventChannel that is created by the host app.
project-level configuration is done correctly.

Some level of testing could probably be done for points 1 and 2. However tests that cover point 1 would belong to firebase_auth, and tests that cover point 2 would belong to firebase_dynamic_links, which are two separate packages.
So how should we test for use cases that require two (or more) separate firebase packages to work correctly (plus some configuration that is external to both)?

Has there been any progress on this front @mit-mit?
I'm playing around with a Flutter Plugin (pure Android/iOS integration calling an underlying API), so no views/widgets involved.  Obviously mocking the service will only catch so much.
Having to write both Dart / Java tests is a bit overkill for my use-case, as ideally it makes more sense to do a full end-to-end testing what's been sent over the Channel and returned is handled correctly on both Dart & Native. I
I'm also having to do:
override fun onMethodCall(call: MethodCall, result: Result) {
    @Suppress("UNCHECKED_CAST") val arguments = call.arguments as Map<String, Any>

Therefore I kind of need to ensure what I'm passing to native from Dart is correctly cast, something which doing Dart / Java tests separately won't catch.

cc @csells for an update

We are currently integration testing many of the first-party flutter plugins with package:test tests that run on-device in the same isolate as the example app of the plugin being tested. You can find instructions for how to run these tests here:
https://github.com/flutter/plugins/blob/master/CONTRIBUTING.md#running-the-tests
Here are some examples:
https://github.com/flutter/plugins/blob/master/packages/cloud_firestore/example/test_driver/cloud_firestore.dart
https://github.com/flutter/plugins/blob/master/packages/cloud_functions/example/test/cloud_functions.dart
https://github.com/flutter/plugins/blob/master/packages/webview_flutter/example/test_driver/webview.dart
Documentation of plugin integration testing is currently pretty limited; I'm making some some improvements to how plugins are tested and will document that more fully once we've had a chance to try it out on some of our plugins.

Thanks Collin @collinjackson.
I got it working from those examples 👍 To be honest, that's not too different from the docs on the Flutter website currently. The only thing which it doesn't explain is:
void main() async {
  final FlutterDriver driver = await FlutterDriver.connect();
  await driver.requestData(null, timeout: const Duration(minutes: 1));
  driver.close();
}

@collinjackson
Is there any new progress in this issue? The links above are 404。

In my opinion, it would be awesome to have a complete guide/example on how to test plugin in flutter. Specifically, testing the Flutter -> Native platforms contract, and vice-versa.

This page looks relevant: https://github.com/flutter/flutter/wiki/Plugin-Tests

Complementing what @nightscape shared, there is also an official page in the docs: https://docs.flutter.dev/development/packages-and-plugins/plugins-in-tests

That's not about testing plugins themselves, it's about testing code that uses plugins when the host side of the plugin isn't present.

The plugin template now contains scaffolding/examples for:

Flutter integration tests
native unit tests in every supported language

That's the vast majority of the coverage that we are using in our 1P plugins, so I think that's sufficient for the template. (The only thing that's not covered is native integration tests, such as XCUITest and Robolectric; those are more complex and generally only needed when the plugin requires interacting directly with native UI; we may eventually document them, but aren't something we need in the template).
https://github.com/flutter/flutter/issues/96421 covers documenting this once it reaches stable; given that the remaining work is tracked there, I'm going to go ahead and close this.


Wildcard domain to custom DNS server

Can I wildcard all domains to forward to my DNS server ? I want to configure to forward all queries to my DNS server. I cannot use https://kubernetes.io/docs/tasks/administer-cluster/dns-custom-nameservers/#coredns-configmap-options because getting this error from CoreDNS pod: cannot serve dns://.:53 - it is already defined

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2f95537e-770a-739c-0175-4447a995f8b2
Version Independent ID: 6c9a1132-05af-70f1-5a2b-8dad56de9cc3
Content: Customize CoreDNS for Azure Kubernetes Service (AKS)
Content Source: articles/aks/coredns-custom.md
Service: container-service
GitHub Login: @jnoller
Microsoft Alias: jenoller

Thanks for the question! We are investigating and will update you shortly.

@MicrosoftDocs/aks-pm any idea on this?

@jnoller @jluk @palma21 any idea on this?

@jnoller @jluk @palma21 Did anyone of you got a chance to take a look at this customer's question. Please let us know. Thanks :)

@jnoller Please answer the customers query and then update the doc if needed

Any update on this issue? We are running into this issue as well.

Also stuck on this one.
myserver.server: |
  .:53 {
    forward . <my-server>
  }

Will result in the above mentioned CoreDNS pod: cannot serve dns://.:53 - it is already defined
Alternatively
myserver.override: |
    forward . <my-server>

results in plugin/forward: this plugin can only be used once per Server Block
Can someone explain how we should achieve this?

Thank you @jjindrich for the feedback.
The behavior you described is not currently available and you must explicitly list all domains. You can file a feature request here: https://github.com/Azure/AKS
cc @palma21
#please-close


Can ncnn2caffe and how to.

Despite caffe is a little bit out of date, but in many cases caffe is a good solution, anybody try to implement ncnn2caffe or ncnn2pytorch? Or provide an idea of how to implement that, thx so much! HELP!!

Hey @zhiwei-dong did you manage to get a tool which does the same? I'm trying to figure it out myself too

Hey @zhiwei-dong did you manage to get a tool which does the same? I'm trying to figure it out myself too


Ghost code snippet doesn't work with nginx code listing

Issue Summary
I want to show some nginx-code example in code snippet, but ghost will not highlight it. I am using nginx as code language.
In the editor, it looks like:

In the post page:

Without nginx language, hightlight.js uses bash language to highlight it (which is wrong).
Nginx is supported by hightlight.js: https://highlightjs.org/static/demo/. Select "config" language category and search for "Nginx config":

Steps to Reproduce

Add a comment snippet to the post and set a language nginx.

server {
    # ...
    location /ping/ {
        default_type 'application/json';
        content_by_lua '...';
    }
}

Publish this post
Nginx config will not be highlighted, but it should be

Ghost Version
5.20.0
Node.js Version
v16.18.0
How did you install Ghost?
Docker container, host system Ubuntu 20.04.5
Database type
MySQL 8
Browser & OS version
Safari 16.1, macOS 13.0 (22A380)
Relevant log / error output
No response
Code of Conduct

[X] I agree to be friendly and polite to people in this repository

Hey @Vadimkin, can you confirm what theme you're using? This seems like a theme specific issue.

The problem is that the casper theme doesn't seem to include highlight.js but its own version generated with css style files
It is mentioned here: https://github.com/TryGhost/Casper/issues/372#issuecomment-324375929
So it seems more like your specific theme problem than the Ghost Blog itself, maybe you can include hightlight.js in your theme directly by adding this in your head <link rel="stylesheet" href="//cdnjs.cloudflare.com/ajax/libs/highlight.js/11.7.0/styles/default.min.css">
and this in your footer: <script src="//cdnjs.cloudflare.com/ajax/libs/highlight.js/11.7.0/highlight.min.js"></script>

Hi @ivangil-dev
Thank you very much! I didn't realize that casper contains their own hightlight styles and scripts.
My solution:
Added to <head>:
<link rel="stylesheet" href="//cdnjs.cloudflare.com/ajax/libs/highlight.js/11.7.0/styles/default.min.css">

Site footer (nginx.min.js needs to be imported since base package doesn't contain nginx config notation):
<script src="//cdnjs.cloudflare.com/ajax/libs/highlight.js/11.7.0/highlight.min.js"></script>
<script src="//cdnjs.cloudflare.com/ajax/libs/highlight.js/11.7.0/languages/nginx.min.js"></script>

Use nginx language in the post:

How it looks in the post (casper theme):


shared stylelint-config-airbnb

To be fair, most of this comes from #23 and serves #13, but instead of having to merge with @ntwb (:+1:) each time, I wanted to create my own for faster development.
So what's new?

I mostly rewrote the package following the example of the current airbnb/javascript repository.
I also added some basic tests to the package.

Please feel free to comment or suggest improvements.

Great idea @chlorophyllkid, a quick cursory glance at everything looks 👌
I've now closed #56 🎉

Neat, looking forward to this.

I had to remove the rule 'scss/dollar-variable-pattern': '^foo' because having to start every variable with foo seems a bit odd. :wink:
If it should be part of the ruleset again, a proper regular expression should be created to fit the naming conventions.

Ok, I did a bunch of things today. Let me conclude:
I added the scss-lint file again, which I removed during the restructuring.
It took me a while to understand some of those, but in the end I added new rules to index.js, which now should hold every rule / recommendation of the current README and scss-lint. (please review) :wink:
Since I added, changed or removed some of the rules, I also reordered them in index.js.
Finally, I split the tests in different files. The first is mostly for formatting rules and the other is more specific to scss syntax.

stylelint-config-airbnb is still unavailable in the npm
after reading this issue I don't quite get where is impedemence

I'm excited about this. The tricky issue is airbnb apparently doesn't do stylelint in-house (#45), so I'm concerned that may cause friction with getting this in. They don't really have a way to maintain a shareable config if they don't use the linter.
So getting a yes/no response if airbnb is willing to officially support a stylelint config would be helpful. If the answer is no, it may be best to press forward with a separate repo. Aside: we could ask if stylelint organization would help, but the bigger picture is we need volunteers using stylelint that can help maintain it.
Doing some QA:
Was wondering the markdown lint stuff for. It's based off https://github.com/airbnb/javascript/tree/master/linters.
For reference, there is the layout of stylelint "shareable configs", which is pretty similar in spirit to what eslint offers:

https://github.com/stylelint/stylelint-config-standard
https://github.com/stylelint/stylelint-config-recommended

To try to get some more eyes on this, I'm posting an issue in stylelint/stylelint. https://github.com/stylelint/stylelint/issues/3091

So, actually, why it's still not merged?
Help needed?

Thanks for the contribution! At a glance this looks pretty good to me. @ljharb can you review this when you have a chance?

Hi! Are there any updates on the status of this?

No, still waiting for the review of @ljharb and @mikefowler :slightly_smiling_face:

...so? It's been 1.5 years. Is there even a point in waiting?

3 years later...😞

I'm going to close this now ...this is clearly never going to happen. 😄
Thank you everyone for your patience. Stay Safe! 👋


Error handler crashes with redirect

It happens because redirect exception is not handled by Bottle, because it already get an exception (404).
import bottle

@bottle.error(404)
def error_route(code):
    bottle.redirect('/')

bottle.debug(True)
bottle.run(reloader=True)

I get this exception:

HTTPResponse('HTTP Response 303',)

Traceback:

Traceback (most recent call last):
  File "/tmp/t/bottle.py", line 788, in wsgi
    out = self._cast(self._handle(environ), request, response)
  File "/tmp/t/bottle.py", line 741, in _cast
    out = self.error_handler.get(out.status, repr)(out)
  File "a.py", line 5, in error_route
    bottle.redirect('/')
  File "/tmp/t/bottle.py", line 1748, in redirect
    raise HTTPResponse("", status=code, header=dict(Location=location))
HTTPResponse: HTTP Response 303

Bump.


Add support for additional GCM fields: picture, style and summaryText

This should close #196
With support to this fields you'll be able to do notifications like this:

This is fantastic!  Much needed addition!

Thanks @sampaiodiego

Published in 3.0.2-rc.10 (not really a rc but waiting for https://github.com/raix/push/pull/203)


⚠ Samsung has degraded performance

In 8aabad0, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2432 ms

Resolved: Samsung performance has improved in 91716e2.


How to silent the SSLVerification issue

Hi,
I've cloned the repository and try to run the test suite but I get tons of SSLVerification warning which I tried to fix as mentioned in the README:
I modified buildNewMangoPayApi in TestBase(testbase.py) with my client id and password and the following line:
dk.Config.SSLVerification = certifi.where()
which point to cacert.pem file of my python distribution:
/Users/brieuc/repos/mangopay2-python-sdk/venv/lib/python3.5/site-packages/certifi/cacert.pem
But I still get the warning:
...../Users/brieuc/repos/mangopay2-python-sdk/venv/lib/python3.5/site-packages/requests/packages/urllib3/connectionpool.py:791: InsecureRequestWarning: Unverified HTTPS request is being made. Adding certificate verification is strongly advised. See: https://urllib3.readthedocs.org/en/latest/security.html
  InsecureRequestWarning)
./Users/brieuc/repos/mangopay2-python-sdk/venv/lib/python3.5/site-packages/requests/packages/urllib3/connectionpool.py:791: InsecureRequestWarning: Unverified HTTPS request is being made. Adding certificate verification is strongly advised. See: https://urllib3.readthedocs.org/en/latest/security.html
  InsecureRequestWarning)

Any idea what I'm doing wrong ?

Hi @applequist, are you still having this problem? We've tested it on Windows and Python v3.4 and weren't able to reproduce the issue. Are you using Windows too, or Linux?

Well, it's weird when trying to run the test from the clone project I still have the warnings.
When running my unit tests, I don't have the warning... most of the time... I'm new to python and still have a lot to figure out...
PS: I'm using a Mac.

Hmm, strange. Well I'll close this for now since it can't be systematically reproduced, but please do let me know if you make any headway with the issue :-)


Linting .txt file only the first linter in the list works.

Information
VIM version
VIM - Vi IMproved 8.1 (2018 May 17, compiled May 25 2018 00:50:25)
Included patches: 1-22
** OS **
Archlinux
:ALEInfo
Current Filetype:
Available Linters: []
Enabled Linters: []
Linter Variables:
Global Variables:
let g:ale_cache_executable_check_failures = v:null
let g:ale_change_sign_column_color = v:null
let g:ale_command_wrapper = v:null
let g:ale_completion_delay = v:null
let g:ale_completion_enabled = 0
let g:ale_completion_max_suggestions = v:null
let g:ale_echo_cursor = 1
let g:ale_echo_msg_error_str = 'Error'
let g:ale_echo_msg_format = '%code: %%s'
let g:ale_echo_msg_info_str = 'Info'
let g:ale_echo_msg_warning_str = 'Warning'
let g:ale_enabled = 1
let g:ale_fix_on_save = 0
let g:ale_fixers = {}
let g:ale_history_enabled = 1
let g:ale_history_log_output = 1
let g:ale_keep_list_window_open = v:null
let g:ale_lint_delay = 200
let g:ale_lint_on_enter = 1
let g:ale_lint_on_filetype_changed = 1
let g:ale_lint_on_save = 1
let g:ale_lint_on_text_changed = 'always'
let g:ale_lint_on_insert_leave = 0
let g:ale_linter_aliases = {}
let g:ale_linters = {'markdown': ['proselint'], 'html': ['tidy'], 'text': ['proselint', 'write-good', 'alex']}
let g:ale_linters_explicit = 0
let g:ale_list_window_size = v:null
let g:ale_list_vertical = v:null
let g:ale_loclist_msg_format = v:null
let g:ale_max_buffer_history_size = 20
let g:ale_max_signs = v:null
let g:ale_maximum_file_size = v:null
let g:ale_open_list = v:null
let g:ale_pattern_options = {}
let g:ale_pattern_options_enabled = 0
let g:ale_set_balloons = 1
let g:ale_set_highlights = 1
let g:ale_set_loclist = 1
let g:ale_set_quickfix = 0
let g:ale_set_signs = 1
let g:ale_sign_column_always = v:null
let g:ale_sign_error = v:null
let g:ale_sign_info = v:null
let g:ale_sign_offset = v:null
let g:ale_sign_style_error = v:null
let g:ale_sign_style_warning = v:null
let g:ale_sign_warning = v:null
let g:ale_statusline_format = v:null
let g:ale_type_map = v:null
let g:ale_use_global_executables = v:null
let g:ale_warn_about_trailing_blank_lines = 1
let g:ale_warn_about_trailing_whitespace = 1
Command History:
What went wrong
When typing only the first linter for txt kicks in. When I remove the first linter on the line the second linter work. So all the linters works fine, but not together.
Reproducing the bug
Whenever I write a file in .txt format, only the first linter kicks in. On every file.

Could you share the output of ALEInfo when you're looking at the file? The output above says no linters are enabled.

Ah sorry, it's a mix of Alex not working on live file (need to save) and the fact that sometime I can't see multiple errors on the same line. I'm playing around with the highlights to make it clearer what is going on.


Indicator for modified files within git submodule directory?

Is your feature request related to a problem? Please describe.
There's a project that I often work in that uses a git submodule to house common code. But I'm noticing that, when I make changes to files within the submodule, telescope-file-browser only shows the directory of the submodule as being modified, not the modified files within it. As this project has hundreds of files, I need a way to quickly visualize files within the submodule that have been modified. Currently, I don't see a way to achieve this with telescope-file-browser.
If this is possible and I've merely glossed over some configuration, then I'll promptly close this.
Thanks!
Describe the solution you'd like
When working in a project using a git submodule, it would be helpful to have an indication of which file in the submodule directory has changed, not just the directory itself.
Additional context
Here are some screenshots. The vim-sub-test directory shows modification, but the modified tested.ts file within the directory does not.

Thanks, I think this is actually a bug.
If you can try out the PR to fix this that'll be great (#356).

Yes, that fixed it. Thank you!

Although, now I'm in my nvim config repo and I'm seeing two "~" next to a file. Is it possible the changes in the submodule branch are causing that, or is it a different issue?

The ~~ is technically a valid status you could see.
Can you do git status --porcelain -- . in that directory? If you see something like MM lazy-lock.json (specifically two Ms), then that's actually expected behavior (git status --help has the meaning of it).
If not, it's probably a bug. Although I might need some help with reproducing that on my end so I can see wants happening.


Translate to English (bot,mail,console) NEW !

In this pull request, I only did translations in English
I modified the Persian language file because the previous translation was a machine translation.
(the previous translation was incorrect and a machine translation was used, please confirm this file)
I also added the /start section for the robot.

Please add this translation to your source code, it's the correct one, the other one for Fa-IR translation has a lot of mistakes.

Hello my friend
Thanks for your kind support
Unfortunately, in the knowledge section, the possibility of using Persian language to enter content is disabled. And for this reason, panel users who use Persian language do not have access to the content in the knowledge base section.
This problem did not exist in the previous version. And it happened after the update.
please guide me

Hello my friend Thanks for your kind support Unfortunately, in the knowledge section, the possibility of using Persian language to enter content is disabled. And for this reason, panel users who use Persian language do not have access to the content in the knowledge base section. This problem did not exist in the previous version. And it happened after the update. please guide me

Hello, dear friend, the Persian version file is in the release section, it has been tested and there is no problem.

Hello, dear friend, the Persian version file is in the release section, it has been tested and there is no problem.

Thanks again for your follow up
In the attached image, which is a screenshot of the panel, I marked it with a mark.
Let me explain more
persian language is active without any problem in the user side panel. But the problem is when using the management section of the knowledge base, and the system administrator does not have the option of selecting Persian language to send new content
Actually While the Persian language is active in the user side panel, the system administrator must also publish educational materials in the knowledge base section.
Currently, Persian language is not available to publish the content in the knowledge base section
Please note: This possibility was previously active in version 1.7 for Persian language
And now, after the update in version 1.7.2, it is disabled and Persian language is not available in the management section of the knowledge base. And as a result, users do not have access to any of the contents of the knowledge base.

Hello, dear friend, the Persian version file is in the release section, it has been tested and there is no problem.

Thanks again for your follow up In the attached image, which is a screenshot of the panel, I marked it with a mark. Let me explain more persian language is active without any problem in the user side panel. But the problem is when using the management section of the knowledge base, and the system administrator does not have the option of selecting Persian language to send new content Actually While the Persian language is active in the user side panel, the system administrator must also publish educational materials in the knowledge base section. Currently, Persian language is not available to publish the content in the knowledge base section Please note: This possibility was previously active in version 1.7 for Persian language And now, after the update in version 1.7.2, it is disabled and Persian language is not available in the management section of the knowledge base. And as a result, users do not have access to any of the contents of the knowledge base.

Because you used the wrong source!
In the original source, the changes that I sent have not been applied yet!
In my personal GitHub, in the release section, you can download the source you want and upload it to your host.
https://github.com/matador7495/v2board-english


Project Customfield page - Staff has permission to edit customfield but showing error message

Describe the bug

Staff has following permission but when staff edit any customfield value server side error message shows

API Ready

Need to send Mode = Project / ProjectCustomField to set roles correctly

https://www.berrycast.com/conversations/2f8eeb72-11d8-533e-853c-602be18ba839


Problems in creating file via explorer integration

Steps to reproduce:

Set Notepad as default app for .txt file;
Create a .txt file from explorer context menu;
Open the file and modify it;
Press save

This point instead of saving the current file, it will ask to save it as a new file

Combining this one with Issue #6, as they both find their origin in that the regular Save function is behaving as Save As.
Also found another bug when opening such files (showing the file as edited while it just has been opened without any changed made to it).
Thank you for reporting it! :)

The main problem in this issue has been fixed in commit 014d6db, the side problem has been put in a seperate issue.


Import error : dll load failed Tensorflow 2.0 version

Please go to Stack Overflow for help and support:
https://stackoverflow.com/questions/tagged/tensorflow
If you open a GitHub issue, here is our policy:

It must be a bug, a feature request, or a significant problem with the
documentation (for small docs fixes please send a PR instead).
The form below must be filled out.
It shouldn't be a TensorBoard issue. Those go
here.

Here's why we have that policy: TensorFlow developers respond to issues. We want to focus on work that benefits the whole community, e.g., fixing bugs and adding features. Support only helps individuals. GitHub also notifies thousands of people when issues are filed. We want them to see you communicating an interesting problem, rather than being redirected to Stack Overflow.

System information

Have I written custom code (as opposed to using a stock example script
provided in TensorFlow):
OS Platform and Distribution (e.g., Linux Ubuntu 16.04):
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue
happens on a mobile device:
TensorFlow installed from (source or binary):
TensorFlow version (use command below):
Python version:
Bazel version (if compiling from source):
GCC/Compiler version (if compiling from source):
CUDA/cuDNN version:
GPU model and memory:
Exact command to reproduce:

You can collect some of this information using our environment capture script:
https://github.com/tensorflow/tensorflow/tree/master/tools/tf_env_collect.sh
You can obtain the TensorFlow version with:
python -c "import tensorflow as tf; print(tf.version.GIT_VERSION, tf.version.VERSION)"

Describe the problem
Describe the problem clearly here. Be sure to convey here why it's a bug in TensorFlow or a feature request.
Source code / logs
Include any logs or source code that would be helpful to diagnose the problem. If including tracebacks, please include the full traceback. Large logs and files should be attached. Try to provide a reproducible test case that is the bare minimum necessary to generate the problem.

@Samgithub1997,
Please fill in the issue template along with the complete error log and the TensorFlow version you are using.
Also, please take a look at this similar issue and let us know if it helps. Thanks!


server/snap: support configuring snap concurrency

Different cluster may require a different value for its scale and performance.

LGTM

LGTM

PTAL

LGTM.

/run-integration-tests