Improvements to persistent query cache from testing (RW-34462)

Improvements:

[x] Prevent case in mobile app where the same query was being restored multiple times at once
[x] Don't bother trying to persist showInUnseenAfter queries (in rekindled PR)
[x] Test for case where persistence gives incorrect results (limit buffer case)
[x] Detect persistence incorrect limit buffer case and re-exec query

Also see: https://github.com/readwiseio/rekindled/pull/3391

@eliias tests are still failing on this branch even though it has your fix 🤔


New Extension: Ethereum Price Extension

Description

A new extension to track the current price of Ethereum in the Menu Bar.
Screenshots

Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed outside of the metadata folder

@pernielsentikaer yeah, definitely. I talked to @thomaspaulmann about this and my initial idea was to use Preferences, but we'd need some sort of muli-select component, as the list of currencies can can quite long - and we dont wanna expose that as a textfield. an idea he suggested was to also use sub menus. ill have a look!


Enable ceph-dashboard by default

Is your feature request related to a problem? Please describe.
Currently Ceph-dashboard is disabled by default. As it's now a key component in Ceph it should be enabled by default. The target use case for this is RHCS, but also upstream would benefit from deploying ceph-dashboard by default. It would also promote adoption of dashboard within community.
Describe the solution you'd like
Change dashboard_enabled default from False to True. Additionally, Grafana service should run in a separate node, instead of collocated with ceph-mgr and ceph-dashboard (performance impacting deployment).
Describe alternatives you've considered
N/A.
Additional context
N/A.

Downstream-only change: see https://github.com/ceph/ceph-ansible/pull/4268

This PR aims to accomplish the same request for the downstream part - https://github.com/ceph/ceph-ansible/pull/4268.

fixed by #4268


Uncaught Error: EBUSY: resource busy or locked, open 'C:\Users\felipe.caputo\Desktop\Salt Atual\Nonet\casos de uso.pdf'

[Enter steps to reproduce below:]

Create a new file with markdown syntax

Create a table in GitHub Flavored Markdown ex:
|Title1|Title2|
|:||
|Text1|Text2|

Export markdown using "markdown-pdf" package 2 to 5 times

PS.: Maybe the problem is on the package, but, since the problem occurr on Atom Core, I've opened it here.
Atom Version: 0.190.0
System: Windows 7 Professional
Thrown From: Atom Core
Stack Trace
Uncaught Error: EBUSY: resource busy or locked, open 'C:\Users\felipe.caputo\Desktop\Salt Atual\Nonet\casos de uso.pdf'
At fs.js:55

Error: EBUSY: resource busy or locked, open 'C:\Users\felipe.caputo\Desktop\Salt Atual\Nonet\casos de uso.pdf'
  at Error (native)

Commands
     -6:03.4 editor:newline (atom-text-editor.editor)
  2x -5:45.3 editor:select-to-beginning-of-word (atom-text-editor.editor)
  2x -5:44.1 core:backspace (atom-text-editor.editor)
  2x -5:24.9 editor:newline (atom-text-editor.editor)
     -3:19.1 core:delete (atom-text-editor.editor)
  6x -3:00.4 core:backspace (atom-text-editor.editor)
  2x -1:06.3 core:move-down (atom-text-editor.editor)
     -1:05.7 editor:newline (atom-text-editor.editor)
     -0:59.4 core:backspace (atom-text-editor.editor)
     -0:58.3 core:move-left (atom-text-editor.editor)
     -0:57.3 editor:move-to-end-of-screen-line (atom-text-editor.editor)
  6x -0:40.2 core:backspace (atom-text-editor.editor)
     -0:27.1 core:save (atom-text-editor.editor)
     -0:22.4 command-palette:toggle (atom-text-editor.editor)
     -0:19.4 core:confirm (atom-text-editor.editor.mini)
     -0:19.2 markdown-pdf:convert (atom-text-editor.editor)

Config
{
  "core": {
    "followSymlinks": true,
    "autoHideMenuBar": true,
    "themes": [
      "atom-dark-ui",
      "atom-dark-syntax"
    ]
  },
  "editor": {
    "invisibles": {}
  }
}

Installed Packages
# User
angularjs, v0.2.0
atom-angularjs, v0.1.2
atom-beautify, v0.24.0
atom-html-preview, v0.1.6
atom-lint, v0.20.1
autoclose-html, v0.15.0
compare-files, v0.4.1
language-pascal, v0.5.0
linter, v0.12.0
markdown-pdf, v1.3.5
read-only-indicator, v0.1.0
symbols-tree-view, v0.9.2
useful-context-menu, v0.2.1

# Dev
No dev packages

Looks like this may be a dupe of #4735.

Thanks @jugglingnutcase!


Racking My Brain - Failing To Ingest

Have read the documentation over, and over, and over... Have created new API keys on OpenAI / Pinecone. Have double, and triple checked the name space, index name, and environment are 100% correct.

** Visual Studio 2022 Developer PowerShell v17.5.3
** Copyright (c) 2022 Microsoft Corporation

PS C:\Users\Randall Cornett\Source\Repos\mayooear\gpt4-pdf-chatbot-langchain>     url: 'https://api.openai.com/v1/embeddings'

},
request: Request {
  [Symbol(realm)]: [Object],
  [Symbol(state)]: [Object],
  [Symbol(signal)]: [AbortSignal],
  [Symbol(headers)]: [HeadersList]
},
data: { error: [Object] }

},
isAxiosError: true,
toJSON: [Function: toJSON]
}
c:\Users\Randall Cornett\source\repos\mayooear\gpt4-pdf-chatbot-langchain\scripts\ingest-data.ts:49
throw new Error('Failed to ingest your data');
^
[Error: Failed to ingest your data]

Anything to help me fix this would be greatly appreciated. Spent like 6 hours last night and made like no progress.

are you using gpt-4?

Have used them both (I have GPT-4).. still no avail. It splits the documents, etc etc. Everything looks fine up until the very send when creating the vector store then bam.. Failed to ingest the data.
Have tried 3x different open AI API keys, Multiple (paid for pine cone) environments, have watched the video 100x. Updaded any sort of plugin / update that VM studio told me in terms of code. It's getting hung up on the last part. Frustrating.

Ran into same issue. Fixed it by making sure to initialize an index in Pinecone Dashboard and making sure the namespaces match the one in the dashboard. You can find the namespace under config/pinecone.ts
const PINECONE_NAME_SPACE = <make sure it is same as dashboard>

Really appreciate the response.. but I have no name space... in Pinecone.

CHATGPT says I need to ingest data into it first.. but how can I ingest if it always fails? Thank you for your help.

The latest error you sent has a status code 429 ~~ pinecone complaining about receiving too many requests. Could you try with a single doc to discard this being the issue?

Yep, using the default PSD provided with the clone just for testing sake. So only 1 pdf.

Ran into same issue. Fixed it by making sure to initialize an index in Pinecone Dashboard and making sure the namespace in pinecone.ts match the one in the dashboard (you can find it under Index Info). You can find the namespace under config/pinecone.ts
const PINECONE_NAME_SPACE = <make sure it is same as dashboard>
Edit: Initialize index and confirm its 'Ready' before running ingest script.

Managed to get an index through like the query portion and edit of Pinecones website. Here is where I'm at now.

with that  on pinecone as well...

Still failing to ingest.

Line 9 references amcbot2 instead of pinecone_index_name. Is that it?

Nope, fixed it I was re reading my post :(

I faced the same problem yesterday...try one thing: delete your pinecone project and create another one, not the index, the whole project. When creating a new one, choose another environment and create a new index.

I hit exactly the same error.

Hey @rancor13, I just fixed this same error. The error is due to the multiple OPENAI API keys in the environment.
apparently the env variable in env from the project gets overwritten by systems env variable.
So just check your Systems Environment variable in Windows and delete it or change it to the new API key.
To check, you can use the following commands
Windows:
echo %OPENAI_API_KEY%
Linux:
echo OPENAI_API_KEY
Mac:
printenv | grep OPENAI_API_KEY

I am also getting the error:
creating vector store...
error [Error: PineconeClient: Error calling upsert: Error: PineconeClient: Error calling upsertRaw: FetchError: The request failed and the interceptors did not return an alternative response]
/Users/lionardo/Documents/Sites/gpt4-pdf-chatbot-langchain/scripts/ingest-data.ts:44
    throw new Error('Failed to ingest your data');
          ^

[Error: Failed to ingest your data]

I have the Name space set and I am loading only 1 pdf.

@Lionardo mind telling me what you mean or where you place the curl command? I had the same error this morning and yesterday. All namespaces and all that labeled, pinecone index ready etc.

I am still running into this error: [Error: Failed to ingest your data]. I have triple checked all of my api keys, I have deleted and created 3 different projects and indexes on pinecone with different environments. I only have one active openai api key. I have tried to do this on both my windows pc and my Mac and I am running into the same error.

Hey @rancor13, I just fixed this same error. The error is due to the multiple OPENAI API keys in the environment. apparently the env variable in env file from the project gets overwritten by systems env variable. So just check your Systems Environment variable and delete it or change it to the correct API KEY. To check, you can use the following commands
Windows:
echo %OPENAI_API_KEY%
Linux:
echo OPENAI_API_KEY
Mac:
printenv | grep OPENAI_API_KEY

Was really excited this would work.. but nope.  When I run the windows command in terminal it just spits back the correct API key I'm supposed to be using... so that's confusing. Dang.. thought this would work..
Have  now created a whole new project with new index and new, different environment etc as suggested. Still the same exact error. Failed to ingest.. to many requests : /

I hit exactly the same error. still stuck with 429 too many requests error. tried only one pdf doc but still had the error. how did you manage to overcome this error @rancor13 ?

Haven't. Tried every suggestion listed in the thread.

Hey @rancor13, I just fixed this same error. The error is due to the multiple OPENAI API keys in the environment. apparently the env variable in env file from the project gets overwritten by systems env variable. So just check your Systems Environment variable and delete it or change it to the correct API KEY. To check, you can use the following commands
Windows:
echo %OPENAI_API_KEY%
Linux:
echo OPENAI_API_KEY
Mac:
printenv | grep OPENAI_API_KEY

Was really excited this would work.. but nope. When I run the windows command in terminal it just spits back the correct API key I'm supposed to be using... so that's confusing. Dang.. thought this would work..
Have now created a whole new project with new index and new, different environment etc as suggested. Still the same exact error. Failed to ingest.. to many requests : /

Then have you checked the error code?
The too many requests. Is it from openai or pinecone?
The solution I provided was for openai 401 error. Which means the api key is incorrect.
If you can provide the complete output of the error you get. It would help me understand and I can maybe help you from there.

Sure the cause of my error is less common than for most as I'm new to this, but I did not have langchain installed. One to try pip install langchain

same error... is it from openai or pinecone...
i have checked pinecone PINECONE_NAME_SPACE and PINECONE_INDEX_NAME

hey @rancor13 , are you using a proxy like clash?

hey @rancor13 , are you using a proxy like clash?

I meet the same error and I also sue proxy as clash ,but  it also can not work correctly

@rancor13, I encountered the same error and discovered that it was caused by my OpenAI account. Using the API requires payment for each request. In order to resolve the issue, I added a credit card to my account and now it works.

@rancor13 I came here just to say the exact same thing as @anaszil. I kept getting a 429 response no matter what, and after messing around with a separate Python library, I realized that the 429 was coming from OpenAI, and adding a payment method to my account immediately resolved the issue - I'm able to ingest data now and get responses from the chat.

If you experience a 429 error, just create a new user for chatGPT (another google account for exemple).
Generate a new API key.
Replace your old one.
Solved my problem instantly.
creating vector store... ingestion complete

Wow, thanks to all of you for going through this. Following this instantly solved my errors.

hi, i'm getting the 429 error, i have a payment card on openai
i don't know how to create the namespace though
only 1 api key shows up for openai
any thoughts on how to resolve? appreciate any help, thanks


Constraint Not Iterable

I'm not sure why this isn't working:
import gpkit as gpkit
A = gpkit.mon("A", "-", "Test Variable")
gp = gpkit.GP(A, A>=1.3)   <-------------------------------------
res_all = gp.solve(printing=False)
res = res_all['variables']
print type(res['A'])
I'm getting an error telling me the constraint is not iterable at the indicated line.  Also, I think this is actually returning 'str' and not 'float' as expected.

GP expects a list of constraints, so this will work as intended if the indicated line is changed to:
gp = gpkit.GP(A, [A>=1.3])

Ah, thanks for the heads up.
Cody
On Mon, Jan 19, 2015 at 5:06 PM, whoburg<EMAIL_ADDRESS>wrote:

GP expects a list of constraints, so this will work as intended if the
indicated line is changed to:
gp = gpkit.GP(A, [A>=1.3])
—
Reply to this email directly or view it on GitHub
https://github.com/appliedopt/gpkit/issues/114#issuecomment-70569830.

This could be changed, if it was worthwhile?
On Mon, Jan 19, 2015 at 5:12 PM, cjk12<EMAIL_ADDRESS>wrote:

Closed #114 https://github.com/appliedopt/gpkit/issues/114.
—
Reply to this email directly or view it on GitHub
https://github.com/appliedopt/gpkit/issues/114#event-221268386.

I think it's acceptable as is.
On Mon, Jan 19, 2015 at 5:53 PM, bqpd<EMAIL_ADDRESS>wrote:

This could be changed, if it was worthwhile?
On Mon, Jan 19, 2015 at 5:12 PM, cjk12<EMAIL_ADDRESS>wrote:

Closed #114 https://github.com/appliedopt/gpkit/issues/114.
—
Reply to this email directly or view it on GitHub
https://github.com/appliedopt/gpkit/issues/114#event-221268386.

—
Reply to this email directly or view it on GitHub
https://github.com/appliedopt/gpkit/issues/114#issuecomment-70575572.

Agreed, I like keeping the API as simple as possible, even if it's a little less friendly.


AB#4974

Proposed changes

Related issues

Checklist

[x] I consider the submitted work as finished
[x] I tested the code for its functionality
[ ] I wrote test cases for the relevant uses case
[ ] I added/update the relevant documentation (either on github or on notion)
[ ] Where necessary I refactored code to improve the overall quality

Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

The date filter seems to be working correctly on my local build, @r-joyce please merge.

Looks like kevin is looking at this please hold on merging.

@johnjdl @kevinh4 what's the status of this PR?


As a logged in player, I want to see which rooms have been created and how many players are inside in order to decide to join a room or create a new room.

Zusammenfügen mit 5. ??
Acceptance Criteria:

[ ] - [ ] A player can see the available rooms.
[ ] The number of players in a room and its name are updated in real-time.

Development Tasks:

[ ] Create a database schema to store information about available game rooms, including the room name, number of players, and the players' usernames.
[ ] Implement server-side code to allow users to create a new game room and store its information in the database.
[ ] Implement server-side code to allow users to join an existing game room and update the room's information in the database.
[ ] Implement server-side code to update the room information in real-time as users join or leave the room.
[ ] Implement client-side code to display the list of available game rooms and their information in real-time.
[ ] Implement error handling mechanisms to redirect users to the login page with an error message if they try to access the game rooms page without being logged in.
[ ] Implement security measures to prevent unauthorised access to game rooms and game room information, such as user authentication and access control.

Mein Vorschlag
Ich würde gerne mit #5 zusammenfügen.

Implement client-side window (from the dashboard) to create a new room, with parameters: name, maximum number of players. High, 4h.
Create a database schema to store information about available game rooms, including the room name, number of players, and the players' usernames. High, 8h.
Implement server-side input validation for room creation as well as room joining requests. Low, 2h.
Implement request system to create, modify, get information about rooms. High, 6h.
Implement client-side code to display the list of available game rooms and their information in real-time. High, 6h.
Implement client-side code to join an existing room. High, 2h.
Implement page guards to prevent joining of non-logged users. Low, 2h.
Implement redirection to lobby after successful room creation or joining. High, 2h.


The README includes a brief legal notice about developers requiring all rights to create integrations, but a missing license means that custom integrations might not have permission to modify or redistribute this Python library.

Done. Thanks for your help.


Fetch script cannot find PhantomJS installed by Yarn

If the PhantomJS binary can't be found, it must be added manually to your PATH. The binary should be placed in node_modules/phantomjs/bin.


Hello | Plugins dir

Nice work on Python editor..

I read about plugins dir (at root of github) and cannot find plugins dir to see about plugins (I need not GH?)
2)I make CudaText editor. some part in Python. maybe want to port some of Suplemon code but cannot see plugins

Thanks!

The 'plugins' or modules can be found here. https://github.com/richrd/suplemon/tree/master/suplemon/modules They're pretty basic at the moment since I haven't finalized the module API yet.
You can port anything you like as long as you follow the MIT license.

CudaText looks pretty nice :)

Maybe you know man,who can help to write Ftp plugin (for $).

Sorry, I don't have a suitable contact.


Improve app theme.

Default theme, customize theme, light/dark theme and stuff like that.

Implemented a function that change color of the message-bar.


fix(apply_shim): add nil check for opts

#175 does not check for possible nil value of opts on add_shim (that may come from :h dressing_get_config()). Add nil check
Context
#175 added apply_shim to maintain backwards compatibility, but it doesn't check if opts is nil before trying to access it. It may be nil since :h dressing_get_config() allows for a nil return value.
Description
A nil check is added
Test Plan
My config was broken after #175 since I have the following on my oil setup.
{
  -- ...
  input = {
    get_config = function(opts)
      if opts.prompt == "cmd: " then
        return {
          -- some custom options
        }
      end
    end,
  },
  -- ...
}

The function returns nil to fallback to the default config whe prompt is not cmd: . With this config, calling vim.ui.input({}, function() end) resulted in an error before this PR and works as expected after it.

Thanks for the fix!


focused_diameter question

I noticed that you have a focused_diameter function for the diffraction limited spot size. In the function, the size is not proportional to the $M^2$, but $(M^2)^2$.
This is different to what I would expect and other treatments of this. Nevertheless, I was able to dig up the equation in the referenced text and it is indeed $M^4$. Although interestingly that seems inconsistent with their own definition in their figure 12.30 which is immediately above the equation, $d_0 = M^2 d_{00}$. And also as a sanity check, consider when defined by divergence angle, $M^2$ is inversely proportional to wavelength. Then wavelengths would not cancel and you would have the situation where the focused spot size decreases as wavelength increases.
Just wondering if the equation is right or I have some confusion here.
Thank you for contributing this library and the documentation, I have found it very useful and works great so far. I shall now be able to retire my personal, much less complete beam profiling code.

Yes, you are correct.  Beam size should scale directly with M².
Released v2.0.5 to correct focused_diameter()
Thanks.  Glad to hear you find laserbeamsize useful.


Hash SMT replaces the whole message

I am adding this here too, so when i tested this with the following connector configuration:
    "transforms.HashEmail.type": "io.aiven.kafka.connect.transforms.Hash$Value",
    "transforms.HashEmail.field.name": "email",
    "transforms.HashEmail.function": "md5",
    "transforms.HashEmail.skip.missing.or.null": "true"

What i end up with is just the hashed value, it seems the whole message is replaced instead of just the email field, i end up with something like this:
"5ABCdefTu+abc123456789=="

maybe @brbrown25, before i dig into this, you already know maybe where to fix this.

@nick-zh I can take a look at this, I think I might know where it's happening. will do that this afternoon/evening.

I'll also have a look soon
This test should cover it:
https://github.com/aiven/aiven-kafka-connect-transforms/blob/master/src/test/java/io/aiven/kafka/connect/transforms/HashTest.java#L193

@ivanyu and @nick-zh I see the issue and can have a fix this evening. It is indeed hashing the entire value and setting it rather than just on the configured field

@brbrown25 thx for the quick feedback, really appreciate it :v:

pr is opened that should address this issue!

Big thanks to @brbrown25 and @ivanyu for reacting so quickly :bow:


Do we not commit package-lock.json?


Allow Power BI to access Azure SQL without enabling "Allow access to Azure Services"

As per @rohitnayakmsft's comment on #37077, Power BI service cannot access Azure SQL if "Allow access to Azure services" is not enabled. What is the alternative for that?

@Anshulsv Thank you for your query, assigning this to @rohitnayakmsft our Product PM to further evaluate the ask and share any pointers. Thank you

@Anshulsv The alternative is to add the respective Public IP address for the region(s) where  you have Power BI deployed. You could sort through this list: Azure IP Ranges and Service Tags – Public Cloud. What I am not seeing are the Power BI  specific sections of the JSON file  relevant for each region but, this would be to alternative to enabling " Allow access to Azure services".

#please-close


No quickstart_config.pbtxt

Hi guys,
I am addressing an issue running the isaac_ros_detectnet tutorial using the example bagfile. In few words, the setup_model script expect the ROS2 package to be in the src subfolder of the isaac_ros workspace.
From the docker version, the src workspace doesn't exist. Do you mind where I am wrong?
Regards,

I have cloned in the wrong docker workspace the object_detection package


Create downloadable libraries to parse and/or convert the NASA operation format

Is your feature request related to a problem? Please describe.
Currently, every USS has to write parsers for the NASA operation for their own system. The current standard is v3: https://app.swaggerhub.com/apis/utm/uss/v3#/A._Required_Endpoints/get_operations, but is moving to v4: https://app.swaggerhub.com/apis/utm/uss/v4#/A. Required Endpoints/get_operations
Describe the solution you'd like
It would be nice to have a parser to read NASA format and create objects in the language of the library (like JAVA, C++, Python, Javascript, etc.). Additionally, it would be nice to have a converter from the formats endorsed by the platform (currently NASA's operation format and GUTMA's flight declaration format).
Describe alternatives you've considered
This should NOT be a service inside a running InterUSS Platform data node, as it violates the tenet "No details about UAS operations are stored or processed on the InterUSS Platform".
Additional context
Comment on this feature request for the languages you think should be supported.
_Remember, to best support collaboration among USSs, there are two key tenets to the InterUSS Platform:

The InterUSS Platform is focused on facilitating communication amongst actively operating USSs.
No details about UAS operations are stored or processed on the InterUSS Platform.

Regardless of the new features and changes brought to the platform via the open source process, these two tenets must be enforced to ensure protection of operator and consumer privacy and ensure the competition between USSs for drone services remains intact._

nice to have a converter
Do you mean convert NASA format to slippy 'coords' csv list, as well as GridCellOperation?

This was meant to convert NASA format into a usable object in a USS's preferred language, perhaps with tools for validation, visualization, etc. Or even transforming into other standards. Above and beyond the code you can automatically create from swaggerhub/github yamls.


Error parsing LocalFile: '\android\app\src\main\AndroidManifest.xml' Please ensure that the android manifest is a valid XML document and try again.

i Got this error when trying to run "Flutter Run"
Error parsing LocalFile: 'C:\Users\Vincent\Documents\pms_application\android\app\src\main\AndroidManifest.xml' Please ensure that the android manifest is a valid XML document and try again.
Here Is my androidmanifest.xml

Any Solution pls. Im using flutter. thank you

Hi @nuestrovincent
This is an issue with your manifest.xml and not with Flutter, please make it's proper formatted and not missing quotes, open
This platform is not meant for assistance on personal code. Please see https://flutter.dev/community for resources and asking questions like this,
you may also get some help if you post it on Stack Overflow and if you need help with your code, please see https://www.reddit.com/r/flutterhelp/
Closing, as this isn't an issue with Flutter itself. If you disagree, please write in the comments and I will reopen it.
Thank you

Created a new flutter application and was prompted this error, made no changes to any code whatsoever.


ReArmature v2.1.2 Update

ReArmature v2.1.2 Update

Apparently the schema doesn't like the changes i've been doing in the PR, how strange, considering its last successful verification in the prior PR
I'm beat.


Jvenstad/package gc fix

@freva please review and merge.
It's too early to delete all packages when unregistering from internal pipeline — they may still want to run the old v3 pipeline.
It should be OK to just keep the packages until the application is deleted / moved to v4 again.

Actually, I'll merge now, since this is strictly also a fix.

But please, do approve!


[Meta] Consider having a separate repo per explainer

The current "mono repo" approach makes following explainers extremely tedious. Random email subject example from my Inbox today:
[MicrosoftEdge/MSEdgeExplainers] Is JavaScript API necessary and if so, should there be a dedicated event for it? (#380) 🤔
I know each Issue has a label, but they don't get carried over to email notifications. My flow is to mute email notification threads I am not interested in in Gmail, sometimes on GitHub. The current way MSEdgeExplainers works forces me to click through to each thread to figure out what explainer it is for, and if I want to follow it or not. I'm short before declaring email bankruptcy.
Thanks for your consideration! If it's just me, happy for others to share their (email-notification-based!) workflow. Maybe I just don't know the trick everyone else knows.

Related: https://github.com/WebKit/explainers/issues/49.

Thanks @tomayac. Great feedback. I guess I take it for granted that I'm in a perpetual state of "email bankruptcy" from GitHub and other standards-related notifications.
Switching to a repo-per-explainer is a relatively big change, and frankly one that I don't think is necessarily warranted for some explainers, for example those that may not be substantial enough to need an entire repo (before they progress to a full spec and beyond). It is something we will consider though.
In the short term, I think I can help address your specific email problem by adjusting our issue templates to include the name of the explainer in the title. (#383) In that way, all issues related to a particular explainer should have a consistent pre-pended "label" in your email, went sent via notifications. I hope this allows for a quick triage (without needing to read the body of the message) or email rules to be setup for the more meticulous email users among us.

(In fact, they'll end-up looking exactly like https://github.com/MicrosoftEdge/MSEdgeExplainers/issues/343 which you filed.)

Thanks, the short term solution works, too! Appreciated :-D Closing with actions being taken in https://github.com/MicrosoftEdge/MSEdgeExplainers/pull/383.


Pre-aggregate attestations in Aggregation pool

In this PR https://github.com/ChainSafe/lodestar/pull/2295/files we introduced an index to efficiently check which attestations have the same data root.
However checking Lighthouse Aggregation Pool https://github.com/sigp/lighthouse/blob/stable/beacon_node/beacon_chain/src/naive_aggregation_pool.rs we could just pre-aggregate attestations and keep a single attestation per data root.
This would substitute the need for the index in the first place and reduce the amount of data we have to keep around.

this looks great 👍 . My understanding is we don't even need the attestation repo with the new index by attestation data root?
We may want to do the same thing for altair SyncCommitteeSignature.


Switch to wasmparser

This switches reader from manual implementation to wasmparser in order to prepare for implementation of new features and better integration like #196.
For the simplicity of review, this changeset intentionally doesn't implement any new features yet nor changes public API, and instead preserves same functionality but with wasmparser instead of a manual reader.

Coverage increased (+0.2%) to 54.838% when pulling e98293400c4353230cde38982156f3b9bb10ae0d on RReverser:wasmparser into 85abdca55d62c3fa77bfb85a6d4089d57b139759 on gimli-rs:master.


featured articles

Oh yeah I have an instance running on repl.it can test later

Oh yeah I have an instance running on repl.it can test later

TODO
If anyone has any objections or proposed modifications to the checklist below, let me know as soon as possible otherwise I may not actually add your modification or consider your objection due to the amount of time it would waste.

[ ] separate collection for featured articles (although if you guys really really want I can maybe consider adding it directly to the entry collection)
[ ] command on discord to add featured articles
[ ] command on discord to remove featured articles
[ ] add current featured article to main page top (above search bar?)
[ ] command to change current featured article on main page

TODO
If anyone has any objections or proposed modifications to the checklist below, let me know as soon as possible otherwise I may not actually add your modification or consider your objection due to the amount of time it would waste.

[ ] separate collection for featured articles (although if you guys really really want I can maybe consider adding it directly to the entry collection)
[ ] command on discord to add featured articles
[ ] command on discord to remove featured articles
[ ] add current featured article to main page top (above search bar?)
[ ] command to change current featured article on main page

@jetstream0 no separate collection needed just add a featured parameter, and search for entries where that is true

@jetstream0 no separate collection needed just add a featured parameter, and search for entries where that is true

@jetstream0 no separate collection needed just add a featured parameter, and search for entries where that is true

seems fair

@jetstream0 no separate collection needed just add a featured parameter, and search for entries where that is true

seems fair

should be done

should be done

Will further test, but should work niw

Will further test, but should work niw

I've tested, this should now work...
I tested it here: https://repl.it/@rediar/Repldex-Featured-Articles-Test
So if there are differences in code between the pr and the repl pls let me know

I've tested, this should now work...
I tested it here: https://repl.it/@rediar/Repldex-Featured-Articles-Test
So if there are differences in code between the pr and the repl pls let me know


Update names w/o re-exposing

I recently added a few new sensors. Right after adding them in Phoscon I renamed them there. But in HomeKit they just kept the old names (TemperatureXX, HumidityXX) - ui get had the new names. The only way I found to update the name was to unexpose und re-expose them. Is it possible to do this without re-exposing (or doing it manually)?

Names of accessories and services are handled by HomeKit, and can be changed through HomeKit apps.  The accessory itself (i.c. Homebridge) has no access to these.  Only when accessory is newly exposed to HomeKit, the names as reported by the accessory are copied.

Ah ok. So I guess its better to set autoExpose to false and expose new devices when they have the correct name. Thanks!

Maybe you're right.  Unfortunately, I removed the auto-expose settings and now auto-expose new Zigbee devices.  Too many people cannot read and were complaining that they didn't see any accessories.
I think it does make sense to (re-)introduce a setting to auto-expose (new) Zigbee devices, also when using multiple Homebridge deCONZ instances for the same deCONZ gateway, to overcome the 149 accessories per HomeKit bridge limit (see Discord).

In v1.0.1.


AzureStack Fabric Admin Specification

The specification has been regenerated.
PR information

[X] The title of the PR is clear and informative.
[X] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
[X] Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
[X] If applicable, the PR references the bug/issue that it fixes.
[X] Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

[X] I have read the contribution guidelines.
[X] My spec meets the review criteria:

[X] The spec conforms to the Swagger 2.0 specification.
[X] The spec follows the guidelines described in the Swagger checklist document.
[X] Validation tools were run on swagger spec(s) and have all been fixed in this PR.

This is Azure Stack RP, correct? I am not sure if ARM needs to review this. @deathly809 - Please let me know.

Removing ARM feedback label for now. Please let me know if ARM needs to review which I dont think we need to.

@ravbhatnagar  Just for Azure Stack, Azure does not have an admin interface.

Closing the PR. @deathly809 you can create a new one and let me know.


Update stream.d.ts so Stream extends AsyncIterable

it might be a good idea to have it extend from stream.Readable too, but this is less opinionated. (node Readable implements AsyncIterable)

wdyt @rubensworks ?

re https://github.com/rdfjs/types/issues/6

The types should always follow the WebIDL definitions in the specifications. Therefore, the stream spec would be the right place to discuss this topic.
If you consider making a proposal, address the concerns regarding performance expressed by the author of a widely used RDF/JS package.

@gobengo I agree this could be useful, but as mentioned by @bergos, we should first add this to the streams spec, which requires concensus in the RDF/JS that this is the direction we want to go towards.
The performance issue raised in https://github.com/rdfjs/types/issues/6 may not be present anymore, but this would require some investigation.


Did naming system for cookies change?

I have access to Bing AI Chat but I have no _U cookie.  Did the naming system change?

It should be there, to check:

In Edge, go to https://www.bing.com/search?q=Bing+AI&showconv=1
Open devtools, go to the Application tab
Under Cookies -> bing.com, copy the value of the _U cookie

still cant find bing cookie, where is excatly

you need KievRPSSecAuth in addition to _U, separate the two key-value pairs with a semicolon, like : KievRPSSecAuth=stuff;_U=stuff

use this extension in the Edge browser on the Bing chat page. You'll be able to see _U

@lionuncle after that extension also I am only getting _UR
@richardkaplan did you find anything?

same here. only see _UR


Modernized (Java 8 style) markers examples

Our base requirement is still Java 7. So we cannot just yet take this whole patch unless we split the examples into Java 7 and Java 8. I would like to take the changes for the entry APIs though.

@garydgregory sorry, I completely missed the requirements section:

Log4j 2.4 and greater requires Java 7, versions 2.0-alpha1 to 2.3 required Java 6.

I will revert all Java 8 stuff and keep the entry API changes as you suggested.
Out of curiosity, is there any plan to ditch Java 7 support?

Done!

No real plan to upgrade to Java 8 for at least another year or so I believe. Too many people still depending on 7 as a baseline. It would be neat if there were some creative way to support multiple versions of Java similar to how Babel works for JS, though.

Fixed in Git master and tracked with https://issues.apache.org/jira/browse/LOG4J2-2029

I guess this one can be closed now!


Make DiagnosticsTracerouteConfiguration.Colos omitempty

Description
This will ensure that PerformTraceroute works without an explicit
colocation list passed to it as documented in the API docs.
Fixes #546
Has your change been tested?
The previously failing condition was introduced as a test case
Screenshots (if appropriate):
Types of changes
What sort of change does your code introduce/modify?

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

Thank you @T4cC0re! This is great and I'll be sure to pull in this fix into cf-traceroute when it's available.


doc.SetValue(...) always adds to history

Suppose doc.historySize().undo === 0.  Then after calling doc.setValue(doc.getValue()), we now have doc.historySize().undo === 1.
Is that the intended behavior?
At first, I was expecting that the undo size would not grow.  However, after thinking about it more, it might be very expenses to check if the new code is equal to the old code when the size of the code is very large.

Yes, this is the intended behavior.


Link to "Postman to test the FHIR server" in bash instructions is not working.

Describe the bug
"Postman to test the FHIR server" link is not working in bash instructions, instead, you get a 404 not found.
FHIR Version?
Stu3/R4/R5
Data provider?
CosmosDB/SQL Server
To Reproduce
Steps to reproduce the behavior:

Enter to Github repository,  Fhir-Server/docs/BashDeployment
It says: "You can use Postman to test the FHIR server."
Click to hyperlink: Postman to test the FHIR server..

Expected behavior
You should be able to see how to test FHIR server with Postman.
Actual behavior
You are getting a 404 Page not found.

@abiisnn Thanks for catching! I figured it :)


Option to enable vertical scrollbar for output of cell related to jupyter notebook support

Bug: Notebook Editor, Interactive Window, Python Editor cells
Steps to cause the bug to occur
1.install latest VS code
2.open the any notebook(ipynb file),there will be no vertical scrollbar for long outputs
Actual & Expected behavior
The below image is actual behavior means the vertical scrollbar not shown although the output is pretty long.

Your Jupyter and/or Python environment
Please provide as much info as you readily know

Jupyter server running:                       Local
Extension version:                               2019.10.41019
VS Code version:                                1.39.1
Setting python.jediEnabled:               true
Python and/or Anaconda version:     3.7.1
OS:                                                     Windows
Virtual environment:                          N/A

Developer Tools Console Output

The console output is in attached file.
temp.txt

We actually already have this option, but it doesn't seem to be working
python.dataScience.maxOutputSize

So,will we get solution in next release?

Yes. It was merged into master yesterday so our next release will have the fix for this.

Validated. Tested on windows. Long output now trimmed at the maxOutputSize setting so you can actually see the next cells. Also checked that -1 allows for infinite output size.

yup now its working on VS code insider with python extension(insider),so when we got it in stable release?

The next official release will be in November. We're trying for a point release in the next week.


Laravel 10 Support

It's conflicting with other installs, like laravel-json-api/hashids ^2

Unfortunately we cannot upgrade until tenantcloud/laravel-boolean-softdeletes upgrades to Laravel 10.

Updated @lindyhopchris.

Yep I saw the tag go through. I'm unlikely to get to this tonight, but should be able to update tomorrow evening (UK time).


Add ability to customise inverse button colours

A "quick-fix" for the inverse button styles using hardcoded blue text and hover colours, where non-GOV.UK branded services probably want this to match the $govuk-brand-colour variable.
Related to #3918. Extracted from PR #3925, which includes more significant changes covering all inverse components.
Changes

Added public variable $govuk-inverse-button-background-colour, which defaults to govuk-colour("white").
Added public variable $govuk-inverse-button-text-colour, which defaults to $govuk-brand-colour.

This is probably technically a breaking change, as the inverse button's text colour was previously govuk-colour("blue"). This will look the same if the brand colour has not been changed, but will be different if it has.

Mapped the public variables to their scoped equivalents.

@querkmachine So, based on your reasoning I reckon lets be cautious and call it a breaking change. We want teams to check that it's not going to impact their buttons, even if it's unlikely.


Improve config file generation

Currently Juju will create a config file that has a context name, username and cluster name all identical. This makes merging and managing several clusters painful.
It would help if the name of the current juju model was used to "namespace" the configuration, prefixing context, username and using it for the cluster name.
It would not change anything for single cluster users but would really help others.

@SaMnCo So for example, if my model name is my-model1, then these would be the kubeconfig values:
context: my-model1-context
username: my-model1-admin
cluster: my-model1-cluster
Is that what you want?

Yes exactly. The idea being that you can then use a tool like
load-kubeconfig to build a single file with all the clusters.
Actually for the cluster you can just use "my-model1"
Then the experience is
kubectl --context my-model1 cluster-info
Exactly like you would juju switch.
Is that possible?
On Jul 6, 2017 23:34, "Tim Van Steenburgh"<EMAIL_ADDRESS>wrote:
@SaMnCo https://github.com/samnco So for example, if my model name is
my-model1, then these would be the kubeconfig values:
context: my-model1-context
username: my-model1-admin
cluster: my-model1-cluster
Is that what you want?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/juju-solutions/bundle-canonical-kubernetes/issues/330#issuecomment-313525730,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACN4d_HYlFUGSGiQDwqdgCysvFX4YGaSks5sLVLLgaJpZM4OMnuE
.

Seems reasonable to me. JUJU_MODEL_NAME is available in charm hook contexts, so I don't see why this wouldn't be possible. @marcoceppi Are you +1 on this?

Partialy worked on this as part of the federation work. Here is the patch how to set the context based on the model name: https://github.com/juju-solutions/kubernetes/commit/6ddf81121af25225cdeca3686afd26cf5ece9aec

Bump: Now I'm back in-country I will resume work on this. Testing via cluster rebuilds is slow but necessary, expect a PR this week or next week.

Sorry for the delay with this, I was testing this back in Feb but I need to rebase it and test some more early next month.


inql: fix invalid version specifier

Description of changes
Fix build (https://hydra.nixos.org/build/218870432)

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 230752 run on x86_64-linux 1

1 package built:

inql


StorageCluster: Unbalaced distribution of OSDs by Topology spread on cluster with local PVs

the OSD pod distribution is not even for cluster with multiple nodes within a failure domain for local PVs
Steps to reproduce

Create a 9 node OCP cluster based on 3 AZs (east-us 1a,1b,1c) . 3 nodes per AZ
Attach 2 disk volumes for each node and create local PVs using LSO
Create initial OCS cluster selecting the storageClass created on the above step
Expand the storage twice

Actual result : within an AZ, single node had two OSDs, leaving one node to be unused.
Expected result : The OSDs should be equally distributed across each node within an AZ. (each node with 1 OSD)

Currently, the placement for prepare pod is zone/rack based on the OCS calculation and its not distributed equally within a failure domain . The PVs created by prepare Jobs will contain further restrictions on where the PV can be mounted. For dynamic provisioning, OSD distribution is maintained as the PVs restriction is the failure domain of prepare job zone/rack. However for local PVs , the PVs restriction is to the host, so OSD placement is dependent on the placement of prepare pod. Thus multiple topology spread needs to be set for prepare pods. Top level would be for zone/rack , the bottom level would be for host. In case of flexible scaling it would be set to host without multiple TSC.
topologySpreadConstraints:
   - maxSkew: 1
     topologyKey: failure-domain.beta.kubernetes.io/zone
     whenUnsatisfiable: ScheduleAnyway
     labelSelector:
       matchExpressions:
         - key: app
           operator: In
           values:
             - rook-ceph-osd-prepare
             - rook-ceph-osd
   - maxSkew: 1
     topologyKey: kubernetes.io/hostname
     whenUnsatisfiable: ScheduleAnyway
     labelSelector:
       matchExpressions:
         - key: app
           operator: In
           values:
             - rook-ceph-osd-prepare
             - rook-ceph-osd


[FEATURE] Add opensearch-reporting-cli-1.0.0.tgz to the release page

(I didn't know where to put this request. I'm not sure it's a feature reuqest)
The installation instructions indicate :
"npm install -g opensearch-reporting-cli-1.0.0.tgz"
But opensearch-reporting-cli-1.0.0.tgz is not available neither on opensearch.org, nor on the page of the release 1.0.0 on github.
Can you provide this artifact ?
Thank you.

Hi @51CGO,
Currently you can click on Artifacts link given in doc
Or https://artifacts.opensearch.org/reporting-cli/opensearch-reporting-cli-1.0.0.tgz


Reverts to previous default launcher

Describe the bug
After my phone has been asleep (like leaving it charging over night), it falls back to the default Pixel launcher instead of using Focus Launcher
To Reproduce
Steps to reproduce the behavior:

Leave phone plugged in overnight to charge
Unlock phone
The phone's previous default launcher is used

the first time it reverted back to my Pixel
then I set my default launcher to Beyond Launcher and it reverted back to that

A few seconds go by
An empty notification sounds (perhaps the FL is running banner?)
Click the circle/home button
Focus Launcher is used

Expected behavior
Focus Launcher is always used
Screenshots
If applicable, add screenshots to help explain your problem.
Environment (please complete the following information):

Device: Pixel 1
FL version: 1.0.6 (Sept 14 update)
OS: Android 10

Additional context
I've only see this happen a few times and it's hard to reproduce. I'll continue updating this issue as I get more info

Happened again. Updated description

Yes, Focus Launcher is default launcher.
It happened again this morning. Seems to happen whenever my phone is waking up from being asleep for awhile


Display issue - huge grey box on Commit Graph

Screen shot provided.  This is a fairly new repo with a few branches and merges.
This seems to be one of the labels, the huge size of it is pushing other elements to the right.

I've got the same problem. On Stash 3.9.2.
There are several of those grey boxes overlapping.

I've got the same issue. After a particular commit this gray box occured and disrupts the layout.
Chrome inspect element:

Parent:
(...)

Just want to report we got the same problem too, but in a bigger scale. We now see several of these boxes on top of each other.
Stash 3.5.1 + Commit Graph 1.1

Same here w/ Stash 3.10.2 and Commit Graph 1.1

I have the same issue, Stash 3.10.2 and Commit Graph 1.1. In IE11 as well as Firefox 39.0

I apologize for my delay on this. To let everyone know, i'm incredibly busy with work at the moment and am not able to contribute time to this. If my situation changes i'll update here, but if anyone has the time/determination to fix this I would be more than happy to review and merge PRs.

Same problem running Bitbucket v4.0.1 / Commit Graph v2.0

hi, i have investigated this problem and found a potential fix for it.
in jquery.commitgraph.js (line 152)
for unknown reason labels.getBBox() is returned with wrong values.
after analyzing the values for other lables it showed that only 2 parameters are changing values and that value is already known (startX)
so i just hardcoded those values like this:
textBBox.height=14;
textBBox.x=0;
textBBox.y=-7;
textBBox.x2=startX;
textBBox.y2=7;
textBBox.width=startX;
and the big grey boxes vanished. of course it may cause some other issues that the time will reveal.

Having that same issue after upgrading from stash 3.6.1 to bitbucket 4.3.0

@darkdams: Created a test plugin with your textBBox fix. The big grey boxes are away and the history looks really good. Thank you!

I was wondering whether it is possible to release this plugin on the marketplace (or somewhere else)?

You can give this a try (pre-release! not officially reviewed, yet!): https://github.com/tirolerstefan/stash-commit-graph-plugin/releases/tag/v2.1

Installed pre release 2.1, the big gray boxes are gone! But the commit graph is still shifted to the right.

i did not told that my solution is resolving fully the issue. but it's more of a work around to not have to many big grey box. it is not perfect solution and still the big grey box may come back!
got such case few days ago

a. I wrote in a different issue that adding core CPUs and RAM memory to the machine fixed the issue of the shifting.
b. When will this 2.1 be released?

Well, I'm not the maintainer, so I cannot release anything here (and I really hope I didn't offend or displease anyone with this pre-release on my own).
First I think, Chason has to find some time to review the Pull Request - maybe the whole "fix" has to be reworked...

@tirolerstefan
I wasn't refering to you in particular. I'm mnot familiar with the plugin developers.
Thanks anyway.

Hey there! Sorry for the delay, I may be able to review this PR tonight or sometime this week. Also I've seen people reporting this issue but I could never recreate it myself. Does anyone have a small repo (that you don't mind sharing) that exhibits the issue?

My customer is HP. They'll never let me send you their repo :-)
Anyhow, it is not 100 percent sure that wil the same repo, you'll be able to reproduce on your side.
At least for me it is not urgent at all. My customer lives with that bug for now. I'll keep on tracking this thread.
Thanks

I created a test repository where I experience this problem. See attached file. Sorry for renaming it, but Github didn't accept my zip archive.

Link doesn't work for me, feel free to email me the zip file. (Check my account page for email)

Duplicate of #49.

Sent email with above testrepo to you. Hope that helps.

Thanks, I appreciate it!


Crash on server start

Crash report : http://pastebin.com/QRJgbt3P

It is actually crashing in the code from the Translocator (ChickenCore) so I doubt this is a problem in RFTools. When exactly does this happen?

it's on server start or client login... now i have removed translocator and i have
java.lang.ClassCastException: net.minecraft.block.BlockAir cannot be cast to com.carpentersblocks.block.BlockCoverable

.<

i have all those errors since i updated cofh mods :/ yesterday it was https://github.com/CrazyPants/EnderIO/issues/1976

Fixed this need to backdate all cofh mods to december versions and update again with stable ones


[FEATURE] Support gpt-4o-mini model for Azure Open AI

Support gpt-4o-mini model for Azure Open AI
gpt-4o-mini is available on Azure OpenAI. But Flowise doesn't show it in the list of models.  Need to support it.

@x-du您好，请问你能成功用上Azure OpenAI API吗？我这边按照这个指导 https://docs.flowiseai.com/integrations/langchain/chat-models/azure-chatopenai-1 来操作也没有调成功，一直提示“Connection error”

@x-du您好，请问你能成功用上Azure OpenAI API吗？我这边按照这个指导 https://docs.flowiseai.com/integrations/langchain/chat-models/azure-chatopenai-1 来操作也没有调成功，一直提示“Connection error”

Yes. We can use Azure OpenAI without a problem.

@x-du Have you ever encountered a situation where the bot's response speed is initially slow, but then becomes very slow when you ask a certain question? Thank you.

@x-du Have you ever encountered a situation where the bot's response speed is initially slow, but then becomes very slow when you ask a certain question? Thank you.

Suggest you enable langsmith to see the langchain log. Very likely it is because you didn't use memory node. By default all the chat history will be added in the context.

I do know why I always got this error after I enable langsmith .

Here is my flow,


Publish on packagist?

I cannot find this package on https://packagist.org, may you publish it there? That would help for installing, maintaining it up to date, and we don't have to commit external packages in our vcs.
Thanks

Hey yea..
This is the plan.

Do some refactoring.
Setup Tests
Publish for composer
Setup for travis.

Fixed:
https://github.com/geofmureithi/f3-validate/releases/tag/1.1


Disabling privacy for testing

It would be very useful to have some mechanism to test private members without having to expose them in a library.
One option is to add a flag to allow access to private members, for instance:
'--disable_privacy'
The semantics could be either:
(a) all imports now export all names (including private names) to the imported library.
(b) only the imports of the initial script have this semantics (so tests can see internals of the libraries it imports, but the rest of the code wont have to worry about name collisions).
This requires changes in both the VM and frog. I'm arbitrarily labeling this bug with the frog area because I can't mark both.
This would be a test case that should work:
mysource.dart:
  #library("mysource");
  get _fooForTesting() => 1;
mytest.dart:
  #import("mysource.dart");
  main() => Expect.equals(1, _fooForTesting);

dart --disable_privacy mytest.dart should pass.

Mirrors can be used to bypass library privacy.

That doesn't work on Flutter, dart2js, ... and is extremely painful.

For reflectable, a programmatic privacy override mechanism would be very useful as well.

+1 for a way to turn of privacy in tests.

import 'dart:mirrors';
class Foo {
int _privateInt = 12;
}
...
var inst = reflect(new Foo());
print(inst.getField(#_privateInt).reflectee); // 12

Scratch that; doesn't work across libraries.
+1 for a way to turn off privacy :)

It was mentioned in discussions to introduce something like friend libraries which are allowed to access each others private members also as a possible replacement for part / part of. I'm not sure how this would work out for all use cases.
Anyway I also think there should be a way around this limitation.

Just "turning off" privacy is not going to work. That would make "_foo" in two different libraries suddenly conflict or override each other, so some code will just fail to work - or even compile. Private names is a way to avoid having to invent unique names as much as it's a way of restricting access.
I highly recommend not using privacy for things you want to test. Instead move them to a separate helper library where they are public, and run tests against that library. Then export only the parts you need in the real library.
That won't work for private members of public classes, but if you assume the presence of private fields or methods, then your tests are not refactoring-safe. Changing the name of a private member should be a completely invisible change. Testing the public methods should be sufficient to test that a class actually behaves as it should. If you have functionality that you want to test independently of the class API, then that functionality is likely a good choice for moving into static helper functions that can actually be tested independently.
(In other words: If you think you need access to private stuff, consider redesigning your class and library layout to not need it any more).

@jtmcdole To do it across libraries, you need to get the private symbol with respect to the library you're trying to access.
class Foo {
int _privateInt = 12;
}
...
var inst = reflect(new Foo());
var sym = MirrorSystem.getSymbol('_privateInt', inst.type.owner);
print(inst.getField(sym).reflectee); // 12

@rmacnak-google, yep, I found that out via a different method and it isn't too messy. I like the type.owner though. Just wish there was a ways to still use #_privateInt in that expression.

You can't use #_privateInt because it's the private name belonging to your library. It's a completely different name than one with similar syntax in a different library.

Related #22841

#28273 seems to be the chosen approach. Can this issue be closed?


Add links to help pages in hover

What problem did you solve?
This PR adds a hover provider that that shows links to matching help pages when hovering over names of R functions.
How can I check this pull request?
Hover over the name of a (documented) R function, wait for hover to show up and check if a link to a help page shows up.
Limitations:
On my machine the link shows up below other hovers, which can be a bit cumbersome if a large help page is shown e.g. by the languageserver.
The hover can be a bit eager, e.g. showing dplyr::n when hovering over a single n. This would be rather hard to solve properly, since the hover is unaware of any tokenization or other languageserver functions. If this is too annoying, the hover can be disabled completely using r.helpPanel.enableHoverLinks = false

@ManuelHentschel I guess we could move this feature to CodeActions so that hover from languageserver will not already appear above these help links?

Looks like the CodeActions may not be a proper place to do this as it does nothing to the source code.

@ManuelHentschel I guess we could move this feature to CodeActions so that hover from languageserver will not already appear above these help links?

I didn't manage to add the help links anywhere in the language server, since commands in markdown links only work if MarkdownString.isTrusted is set to true somehow, which I don't think is possible (and probably wouldn't be a good idea anyways)

I tried using CodeActions to do this, and it looks better I think.

That does look nice. How does the communication between languageserver and helppanel work here?
I only tried command-links in markdown, which are affected by the isTrusted problem I mentioned above.
Providing these links from within the languageserver might also allow us to only show relevant links (e.g. if the ls knows, which package the function is from, or if the currently selected work is inside a string).

It is not provided by languageserver. I just switch from HoverProvider to CodeActionProvider in vscode-R.

In this case, I'm not sure if the setting helpPanel.enableHoverLinks is useful anymore? Maybe we could rename it to helpPanel.enableCodeActions or something more obvious? Or we simply remove it until somebody really needs such a setting?


Updated dependencies: fixed chalk + chai changes

Following outdated dependencies from other libraries led here... so here's a PR to update the dependencies and fix some npm audit warnings :-)

The build system needs updating as the updated dependencies require more recent versions of node.
Specifically, chalk v4 needs at least node 10 (which is now the oldest LTS version).


Inheriting I/O from super classes

It would be awesome if I/O could be inherited from subclasses.
For example, in gneiss, we are subclassing the TreeNode object in order to draw dendrograms.  When trying to save these objects to disk, we get the following error
---------------------------------------------------------------------------
UnrecognizedFormatError                   Traceback (most recent call last)
<ipython-input-23-7da78c6c9698> in <module>()
----> 1 lme_model.tree.write('../results/tree.nwk')
      2 for y in ynames:
      3     open('../results/%s_left' % y).write(','.join(list(tree.find(y).children[0].subset())))
      4     open('../results/%s_right' % y).write(','.join(list(tree.find(y).children[1].subset())))

/Users/mortonjt/miniconda3/envs/bio/lib/python3.5/site-packages/skbio/io/registry.py in write(self, file, format, **kwargs)
    671
    672         def write(self, file, format=cls.default_write_format, **kwargs):
--> 673             return registry.write(self, into=file, format=format, **kwargs)
    674
    675         imports = registry._import_paths(write_formats)

/Users/mortonjt/miniconda3/envs/bio/lib/python3.5/site-packages/skbio/io/registry.py in write(self, obj, format, into, **kwargs)
    615             raise UnrecognizedFormatError(
    616                 "Cannot write %r into %r, no %s writer found." %
--> 617                 (format, into, obj.__class__.__name__))
    618
    619         writer(obj, into, **kwargs)

UnrecognizedFormatError: Cannot write 'newick' into '../results/tree.nwk', no UnrootedDendrogram writer found.

:+1:, technically this is a duplicate of #1402. This is going to require deep changes to the IO registry, if anyone really wants to take this on, I could be of some limited assistance in describing how everything works in there.


Don't set t_Co in gvim

Changing this setting clobbers any custom syntax highlighting prior to exporting.  This change will enable users to use gvim to export exactly what they see (assuming change_colorscheme is false).

lol googlebot.

LGTM

This PR originally made the vroom test fail.  I'm trying a new commit, which makes the vroom test pass on my local machine.


Don't expose server error messages

Checklist

[x] npm test passes
[ ] tests and/or benchmarks are included
[ ] documentation is changed or added
[x] commit message follows commit guidelines

Affected core subsystem(s)

No
Description of change

In production mode is it not safe to expose server errors

LGTM

@azard can you please new npm release?

@sm2017 already released


How to Export XLSX with Cell Formatting as Text

Hello,
i'm using Laravel 8 with the lastest version of Yajra Datatables and Buttons.
Currently I have a problem with Excel Export. All of my Numeric Columns are formatted as Numbers in Excel, so mobilenumbers starting with 4917417 replaced with 4,91787E+11.
How can I format the whole export sheet as Text, without manually set in Office Excel.
Thank you.

Just to confirm, you are using excel and not csv button? I mostly encounter this behavior when you export using CSV and then opening it on MS Excel.


PP-4564: Address priority repo lint issues

A number of lint warning were recently flagged against the selfservice
repository. This PR removes these issues, specifically high priority
concerns with checking equality (running boolean logic checks against
JavaScript strings always resulting in true)
Closes https://github.com/alphagov/pay-selfservice/pull/1040

Ah, you fixed many more alerts than just my one in #1040! In #1040, I also flagged up that some of the affected code seems to exist in at least one other repository: https://lgtm.com/projects/g/alphagov/pay-products-ui.
And — just in case — if you're looking for more inspiration: LGTM.com has analysed over 500 repos in the alphagov GitHub org. Have fun! https://lgtm.com/search?q=alphagov


error getting trades { HTTPError

Note: for support questions, please join our Discord server

I'm submitting a ...
[X ] bug report
[ ] feature request
[ ] question about the decisions made in the repository

Action taken (what you did)
run a tradebot at kraken with EUR <-> XBT

Expected result (what you hoped would happen)
buy/ sell XBT

Actual result (unexpected outcome)

2017-10-29 12:34:26 (ERROR):	error getting trades { HTTPError: Response code 522 (undefined)
at stream.catch.then.data (/home/pi/gekko/node_modules/got/index.js:182:13)
at <anonymous>
    at process._tickCallback (internal/process/next_tick.js:188:7)
  name: 'HTTPError',
  host: 'api.kraken.com',
  hostname: 'api.kraken.com',
  method: 'POST',
  path: '/0/public/Trades',
  protocol: 'https:',
  url: 'https://api.kraken.com/0/public/Trades',
  statusCode: 522,
  statusMessage: undefined,
  headers:
   { date: 'Sun, 29 Oct 2017 12:34:26 GMT',
     'content-type': 'text/html; charset=UTF-8',
     'transfer-encoding': 'chunked',
     connection: 'close',
     'set-cookie':
      [ '__cfduid=xxxxxxxxxxxx; expires=Mon, 29-Oct-18 12:34:11 GMT; path=/; domain=.kraken.com; HttpOnly' ],
     expires: 'Thu, 01 Jan 1970 00:00:01 GMT',
     'cache-control': 'no-store, no-cache, must-revalidate, post-check=0, pre-check=0',
     pragma: 'no-cache',
     'x-frame-options': 'SAMEORIGIN',
     server: 'cloudflare-nginx',
     'cf-ray': 'xxxxxxxxx-DUS' } }

https://support.cloudflare.com/hc/en-us/articles/200171906-Error-522-Connection-timed-out
Kraken's API is highly unreliable, this is a common error to receive. Try again later.


Casting to and from dbfs and arg values may be wrong

Investigate if the existing functions have the correct answers.
Possibly this might actually be correct:
// Cast Full Scale to something the X32 understands
export function fullScaleToArg(fullScale: number) {
  https://stackoverflow.com/questions/6071977/finding-antilog-in-javascript-and-solving-polynomial-equation-of-n-degree-in-jav
  return Math.exp(fullScale / 20)
}

// 1-0 to full scale db
export function argToFullScale(linear: number) {
  /**
   * https://forum.audacityteam.org/viewtopic.php?t=26266
   * The usual formula for calculating linear-to-dB is:
   *  dB = 20log(V1/V2)
   *  dB is an expression of a ratio (V1/V2) and in the case of dBFS the ratio is with reference to a Full Scale = +/- 1
   *  So V2 = 1
   *  Which gives:
   *  dB = 20.log V
   * where "V" is the linear value and "log" is "common log" (base=10).
   */
  return 20 * Math.log(linear/1)
}

The original function was producing correct values - no need to change.


Remove unused py executables

Sometimes, our windows builds fail to sign. We don't 100% know why, but one theory is the following:

On windows, all executables that we're packaging in the build must be signed
There's quite a lot of executables in the python install we package along with the app

This isn't typical of electron builders, even those of our app on other platforms

On windows, the way builds are signed appears to involve writing a keyfile to a temp dir that's reused across builds
That key file is used to sign everything

because electron-builder wants to be fast, multiple signatures are parallelized

The process of signing, in parallel via multiple processes, a whole bunch of executables using one keyfile races and sometimes causes a conflict; this hasn't been noticed and fixed because most builds don't have this many executables in them

One fix for this, or at least to decrease its likelihood, might be to remove many of the executables from the build. We don't really need any of them except for the core python, so why not.
Unfortunately the only way to test this (aside from making sure the offline analysis still works without all those executables) is by doing a build a whole bunch and seeing how frequently it fails to sign.

Example build: https://s3.amazonaws.com/opentrons-app/builds/Opentrons-v6.2.1-win-b27829-remove-unused-py-executables.exe

It still simulates locally so... good?


Wrong ColorDepth Validation Regular Expression!

Hello Support,
While implementing 3DS2 support in mangopay, we upgraded to the latest SDK and for some reason it is NOT accepting [BrowserInfo]=>[ColorDepth] => 30 as a valid value! The error response provides a regular expression which must match for [ColorDepth] value But it seems it has not all the supportive values like 30 in my development machine case.
[BrowserInfo.ColorDepth] => The field ColorDepth must match the regular expression '^(1|4|8|15|16|24|32|48)$'. ) ) )
Please check and do the needful ASAP.
Regards,
Ashok

Hello @ashok-kr
Thank for you report, we'll have a look

Hello @ashok-kr
As you can see in our 3DS2 integration guide, the allowed values for BrowserInfo.ColorDepth are 1, 4, 8, 15, 16, 24, 32, 48.
This is why we've implemented a regexp to handle this restriction

Ok, however, the value 30 is provided by browser Microsoft Edge on Apple macbook pro M1. So it is a real world value for the color depth field.. Hence, you should check the validation values again for this attribute. Otherwise, the code might fail when the end user is using the same combination of the computer system and there might be other values as well.

Thank you for the insight @ashok-kr ,
I'll have a look at it

Thank you for the insight @ashok-kr ,
I'll have a look at it

Any update on this?

Hello @ashok-kr
Just to inform you that the verification on the BrowserInfo.ColorDepth is made by the API and not at the level of the SDK.

I experience this issue today in my live site. I have sent urgent support message to Mangopay Support. Hope they solve it soon.

Hello @ashok-kr & @Dekari,
Great news : the Mangopay API has improved the BrowserInfo.ColorDepth management. The value 30 will be considered as valid. Don't hesitate to test on your side.
Have a nice day,


License/Etiquette question

I'm forking this to adapt to the Pokemon TCG - I think the card structure there is different enough to potentially have some quite interesting results. I'm not quite sure how the etiquette and licensing works for this situation, though - do I rename my fork now or only once I've actually made the changes? How do I write the license to account for the fact that the structure of the code is yours but many details will be mine? That sort of thing. I would prefer to defer to @billzorn in this situation, as the initial maker of the code.

This code is under the MIT license, so essentially you can do whatever you want with it as long as you also make your work based on it available under the same license. For the fine print, refer to the LICENSE file.
I would say, go ahead and rename your fork as soon as possible just so that your work is easier to distinguish from mine. You'll probably want to restructure the readme and so on, depending on how you change the code, but maybe leave a little note and a link back to the original code to let people know what your project is based on. Of course if it's a fork there will also be github's automatic indicators.
I'm less concerned with getting credit for my work, and more concerned with making sure that future users of the codebase will have a clear understanding of what's going on. If this work is useful to you, then that's awesome! I'm glad I could help.

Gotcha, thanks.


Can't use deployed Neuron model with error NRT:nrt_allocate_neuron_cores

Hi, I'm following the sample here to try to compile a model to Neuron and deploy on SageMaker.
Following the steps in the sample exactly, I am able to deploy the model, but it when I try to use it I get the 500 error and my CloudWatch traceback shows the following:

I only saw this error when trying to use a second model in the same instance while another one is running, but that should not be the case here.

Hi @marina-pchelina
Since NeuronCores are reserved per process, it's possible that you have an old process which is holding onto the NeuronCores but has not been properly terminated. One thing to try is to forcefully stop all running processes: https://awsdocs-neuron.readthedocs-hosted.com/en/latest/frameworks/torch/torch-neuronx/training-troubleshooting.html#neuroncore-s-not-available-requested-1-available-0

hi, thanks for getting back to me!
What I don't understand is how can neuron cores be holding on to any old process if a new inference instance is initialized each time I deploy. Anyway, I tried including some commands from the troubleshooting doc and some other I found in the top of my inference.py script like so:
import subprocess

print("Running apt-get install kmod")
print(subprocess.run(['apt-get install kmod'], stdout=subprocess.PIPE, shell=True).stdout.decode('utf-8'))
print("Running lsmod | grep neuron")
print(subprocess.run(['lsmod | grep neuron'], stdout=subprocess.PIPE, shell=True).stdout.decode('utf-8'))
print("Running ps aux | grep python")
print(subprocess.run(['ps aux | grep python'], stdout=subprocess.PIPE, shell=True).stdout.decode('utf-8'))
print("Running neuron-ls")
print(subprocess.run(['neuron-ls'], stdout=subprocess.PIPE, shell=True).stdout.decode('utf-8'))
print("Running modinfo neuron")
print(subprocess.run(['modinfo neuron'], stdout=subprocess.PIPE, shell=True).stdout.decode('utf-8'))

I can see the 2 cores are there with neuron-ls:

No significant python processes that could be using the cores, killing them all explicitly didn't help ether.

However, seems like I'm not able to use lsmod or modinfo, which I'm able to use and get output from from inside an EC2 instance (same inf2) directly. I tried installing them with apt-get install kmod but that didn't help either.

Could that possibly have something to do with image that's used in the tutorial? It's currently this one:
ecr_image = "763104351884.dkr.ecr.us-east-1.amazonaws.com/pytorch-inference-neuronx:1.13.1-neuronx-py310-sdk2.13.2-ubuntu20.04"

@marina-pchelina, we were able to reproduce the problem in the tutorial and are looking into a fix.
The root cause appears to be 2 separate misconfigurations:

The default number of workers is set to 4. In torchserve each worker is a separate process which must take control of a single NeuronCore. Since the ml.inf2.xlarge instance has only 2 NeuronCores, this is an invalid number of workers. You can observe the configuration in the beginning of the logs: Default workers per model: 4
The default number of NeuronCores per worker appears to be not configured which is causing the first process to attempt to take ownership of all NeuronCores. The Neuron runtime allows each process to take control of as many NeuronCores as it needs. The default behavior is that 1 process takes ownership of all NeuronCores on the instance. When using process-level workers, this means that each process should be configured with the environment variable NEURON_RT_NUM_CORES=1 so that it only takes ownership of a single NeuronCores for the model that it loads.  You can see this in the logs because 4 warnings are issued for each model load followed by only 3 nrt_allocate_neuron_cores errors showing that the NeuronCores have already been allocated to another process.

thanks for looking into this!
I tried to re-compile the model with --target inf2 on the off chance it might help configure the num of workers, but it still showed Default workers per model: 4 in the logs.
If it's any help, I can deploy and use models through the HuggingFace integration, the problem with that is, I want to use both cores with DataParallel, which the HuggingFace class doesn't seem to allow to do.
Let me know if there's anything I can do myself to work around that, otherwise, I'll wait for a fix.


100% CPU usage on --bail & --coverage combination

🐛 Bug Report

To Reproduce
Steps to reproduce the behavior:

run a combination of --bail and --covarage with a failing test:

"scripts": {
    "test": "jest --ci --bail --silent --coverage"
}

If there is a single failing test jest start running coverage of untested files and pretty soon eats up all the CPU, preventing any usage of the system, e.g. mouse becomes unresponsive. And it never releases to the point I have to restart the machine, at least with Win10.
Expected behavior
I don't expect my machine to hang, obviously.
Also it might make sense to bail out of the coverage on untested files in case of a bail out. BTW, is there a way to prevent --coverage in case there's a failed test and we bail out? Is there some way to configure it? If not, would that make sense as a feature? I mean, I don't really care for the coverage until I fix the failing test.

Link to repl or repo (highly encouraged)

envinfo

PS D:\git\TRI\linsi-ui> npx envinfo --preset jest
npx: installed 1 in 3.33s

  System:
    OS: Windows 10 10.0.17763
    CPU: (4) x64 Intel(R) Core(TM) i5-3470 CPU @ 3.20GHz
  Binaries:
    Node: 12.14.1 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.13.0 - C:\Program Files (x86)\Yarn\bin\yarn.CMD
    npm: 6.8.0 - C:\Program Files\nodejs\npm.CMD
  npmPackages:
    jest: ^24.8.0 => 24.8.0

It kind of happens like this:
 ...
 PASS  src/services/Library/InstrumentUpdater/CustomInstrumentUpdater.test.ts
 PASS  src/components/ProgressIndicator/ProgressIndicator.component.test.tsx
 PASS  src/services/TemplateDataConvertor/ConditionalConvertor.service.test.ts
 FAIL  src/services/Auth/Auth.service.test.ts
  ● AuthService › should remove token from storage and call login method on relogin

    expect(jest.fn())[.not].toBeCalled()

    Matcher error: received value must be a mock or spy function

    Received has type:  function
    Received has value: [Function anonymous]

      55 |     sut.relogin()
      56 |     expect(tokenServiceMock.remove).toBeCalled()
    > 57 |     expect(sut.login).toBeCalled()
         |                       ^
      58 |   })
      59 | })
      60 |

      at Object.<anonymous> (src/services/Auth/Auth.service.test.ts:57:23)

Running coverage on untested files... PASS  src/services/ScheduleConvertor/ParamsConvertors/OnceScheduleParamsConvertor.test.ts
Running coverage on untested files... PASS  src/validators/validation-functions/SameArgumentsValue.test.ts
Running coverage on untested files...

tests pass until one test fail, and then coverage on untested files follows, and that's where things get nasty very fast if you are not fast enough to hit Ctrl+C.

I think ditching the coverage if tests fail makes sense. @thymikee @jeysal thoughts? We can probably get that into Jest 25

Agree with @SimenB. I don't see a value in processing coverage for a failed test and related files (if not processed by other code). By doing so, we could also end up with a slightly faster feedback loop and less clutter to scroll through when identifying failed expectation.

It seems like it is conflating very different things, coverage to me does not even require test cases that can pass or fail, it can be done on any program execution.  This would also introduce an unintuitive half-coverage run where code is still run instrumented but no coverage output generated. Overall sounds like a lot of architectural complexity, not like "do one thing" / separation of concerns.
I think maybe it's better to fix performance of the "Collecting coverage from untested files" step instead, which has always struck me as a problem, even on passed runs in many projects.

There is no performance issue in "Collecting coverage from untested files" (or, there is, but that's totally orthogonal to the issue reported here) - the issue here is that bail is broken and doesn't stop other tests before reporting the run as complete, meaning we're still running tests on a bunch of cores, then spawn new workers to collect coverage on uncovered files thus bombing the CPU with (numberOfCores - 1) * 2 processes

Okay that's a nasty bug - rest still stands though I think it would be better to fix it than bailing out on coverage collection on failure.

Is there any plan to resolve this bug? Or maybe a known work around while there isn't a permanent solution?

any progress here? it will be almost two years from the last comment...

PR welcome 🙂

This issue is stale because it has been open for 1 year with no activity. Remove stale label or comment or this will be closed in 30 days.

Yes, it's still a problem...

I noticed my RAM was being consumed and that my test suite seemed to be stalled while everything on my system started reported as being non-responsive. I noticed that there were a ton of node processes spawned each using 500-700MB+ of RAM. After killing the test running those processes went away and I got my RAM back.

if you're asking for coverage then it shouldn't matter if a test fails

I have to disagree here - with bail some tests won't run at all on failure, so why bother to collect coverage at all?


Operation's Team SSO Logs

User Story

As an SSO Administrator
I want view the logs related to the SSO application
so that I can query the issue and carry out root-cause analysis.

Acceptance Criteria or Constraints

I'll see this or
The solution will conform to this or
Non-functional requirements

Acceptance Tests
Scenario 1: xxxxxx

GIVEN ...
WHEN ...
THEN ...

Scenario 2: xxxxxx

GIVEN ...
WHEN ...
THEN ...

Dependencies?
Team or ideally a ticket
Risks

Description
Impact
Strategy
Contingency Plan

If this does or doesn't occur by...
Then this will happen, costing $?
Mitigate, Transfer, Accept, Avoid
We will do this, if it occurs

Process Guidance
User Story
A short introductory section with the following structure:
As a: the person or role who will benefit from the feature;
I want: the feature;
so that: the benefit or value of the feature.
Acceptance Tests or also called Behaviour Driven Development Acceptance criteria
A description of each specific scenario of the narrative with the following structure:
Given: the initial context at the beginning of the scenario, in one or more clauses;
When: the event that triggers the scenario;
Then: the expected outcome, in one or more clauses.

captured under the Metrcs workshop.


Add minSelect and notRemovable props

Would be nice if we could choose the minimum number of options to select. Prettyr much just the opposite of the maxSelected prop.
Perhaps it could work together with the required prop? So if a Multiselect is required, you can choose how many options need to be selected.
It would also be nice if we could stop users from removing options (this is needed in our project) through a prop. Maybe the prop can be called removable, notRemovable, removableOptions or notRemovableOptions?

@Snailedlt I like the idea of allowing required prop to be a number to act exactly like a new minSelect prop would. I'll add that.

@janosh yeah, even better! 😁
But how about the other prop I suggested called removableOptions?

But how about the other prop I suggested called removableOptions?

Could you open a new issue for that and describe your use case in a bit more detail? That seems more niche.


pagelet_rails's executable "rails" conflicts with railties

Hi! I get this message when I do gem install pagelet_rails.
nicolas@desktop:~/PROJECTS/GITHUB_WIP$ gem install pagelet_rails
pagelet_rails's executable "rails" conflicts with railties
Overwrite the executable? [yN]

I've introduced this bug in : https://github.com/antulik/pagelet_rails/commit/724767e824d131de2f2f55814327ecd9a72f0337
This override (and break) the rails command

I've just pushed new version 0.1.8. Does it fix the problem?

After pushing the fix, i've realised that there is a better way to fix it, so redone it :)


Add challenge DF into active rewards workflow

Fixes #656
Changes proposed in this PR:

Add challenge DF into active rewards workflow

@trizin I got this up to date and ready to merge (merged main, resolved all conversations etc.) but I will wait for you to merge it.


types error  'node_modules/pptxgenjs/types/index.d.ts'

node_modules/pptxgenjs/types/index.d.ts(1037,9): error TS1122: A tuple type element list cannot be empty.
node_modules/pptxgenjs/types/index.d.ts(1060,25): error TS8020: JSDoc types can only be used inside documentation comments.
node_modules/pptxgenjs/types/index.d.ts(1299,17): error TS8020: JSDoc types can only be used inside documentation comments.
node_modules/pptxgenjs/types/index.d.ts(1385,52): error TS1122: A tuple type element list cannot be empty.

Where is this coming from, Webpack?
The library is built with TypeScript 3.3.1 and i'm not seeing any ts/tslint errors like this.

Facing the same issue i have install  "npm install pptxgenjs --save"  in my angular 6 application and added demo in once file ng build --watch giving same error
ERROR in node_modules/pptxgenjs/types/index.d.ts(1037,9): error TS1122: A tuple type element list cannot be empty.
node_modules/pptxgenjs/types/index.d.ts(1060,25): error TS8020: JSDoc types can only be used inside documentation comments.
node_modules/pptxgenjs/types/index.d.ts(1299,17): error TS8020: JSDoc types can only be used inside documentation comments.
node_modules/pptxgenjs/types/index.d.ts(1385,52): error TS1122: A tuple type element list cannot be empty.

I have a kind of similar issue here
I am using ng7 and typescript 3.2.4
ERROR in node_modules/pptxgenjs/types/index.d.ts(67,50): error TS2580: Cannot find name 'Buffer'. Do you need to install type definitions for node? Try npm i @types/node and then add node to the types field in your tsconfig.
node_modules/pptxgenjs/types/index.d.ts(73,88): error TS2580: Cannot find name 'Buffer'. Do you need to install type definitions for node? Try npm i @types/node and then add node to the types field in your tsconfig.

Thanks @Krishnakanth94
This is now fixed in the master branch.

Thank's @gitbrent .


Feature request - set update profile on publisher

Add ability to set the update profile when creating a publisher via terraform

Thanks for the request. I am hopeful to skope this shortly.

Thanks for the request. I am hopeful to skope this shortly.

hey, can we get an update please. has progress been made?

I just finished a few fixes and will be working on this next.

Added support for Upgrade profiles in the latest version v0.2.5