Conbee found but pairing not possible

I'm using a synology nas and your container in docker.
To get the nas to recognize the conbee I used this command on the host:
insmod /lib/modules/usbserial.ko
insmod /lib/modules/ftdi_sio.ko
After that the stick was found as /dev/ttyUSB0.
I started your container in priviliged mode and the the variable for the device to /dev/ttyUSB0.
Phoscon seems to recognize the stick:
Hersteller dresden elektronik
Produkt ConBee
Version 2.05.50 / 8.12.2018
Firmware 262F0500

But when I try to pair a device nothing happens.
I tried an ikea remote and an Aquara PIR.
The same devices work when I use an raspberry pi with a directly installed deconz and the same stick.
Any hints for me?

Maybe a similar problem as this one: https://github.com/marthoc/docker-deconz/issues/65
I will try to use an other port and an extension cable

It works now with an extension cable ..


Remove CS 354 (Robotics) support

This role has long been under-tested compared to the rest of the
offerings and it currently does not have any known users. The course is
offered rather infrequently and the students in the course and club
generally seem to prefer the lab machines that are provided.
This removal is intended to ensure that there is not code rotting on the
master branch. It is not intended to backport this removal to any prior
release.
This PR is being opened to provide a possible implementation of the
RFC in issue #377. It will remain in draft status until a direction is agreed
upon.
Closes #377

Go ahead and move this to Ready. I was only going to push for dropping 354 in the GUI, leaving the option to ansible-pull it directly, but nobody has spoken up for it, so let's kill it all.

I guess that is an important part of the removal. And the README doesn't really show up in grep -i -r "CS354" roles/ :man_shrugging: Hopefully we're all set now


Java Guidelines: Fit content to new Guidelines structure

Description
Per the MQ Guidelines initiative to fill gaps in the guidelines across languages, we are moving to a new common structure for the guidelines and calling out areas where there are content gaps -- i.e. one or more of the other language guidelines have guidance that is not language-specific that is not represented in this language's guidelines.
The Java guidelines have very few gaps!  In some places, they have several sections with similar content that could be grouped into a single section, and potentially have more general guidelines replaced by more specific Java guidelines.
Details
Design

[ ] Network requests and The Java API section appear to cover similar content - this could move to a Sync and Async section under Service Client Constructors (which I know will not be called constructors for Java 😊 )
[ ] Client interface and Service clients appear to cover similar content - this could move to a Service Client section in the new structure
[ ] Model Types and Model classes appear related - these could both live in the Model Types section (is it Java-specific to call it Model Classes?)
[ ] Maven and Modules appear related, but if I am substantially misunderstanding the Java ecosystem, please let me know.

Note
For the implementation, the below structure is based on .NET content.  It is intended to provide implementation details for things that aren't visible in the public API, with a TOC that largely maps to the API Design section in the Design TOC, with sections filled for areas where you already have content written.  Feel free to reach out with any questions.
New Structure
(Numbers for ease of reading here, but won't be shown in the guidelines page TOC)
Design

Introduction

Design Principles
General Guidelines
Non-HTTP Libraries

Azure SDK API Design

Service Client

Service Client Constructors

Client Configuration
Setting the Service Version
Sync and Async
Client Immutability

Service Methods

Naming
Return Types
Cancellation

Service Method Parameters

Options Parameters
Parameter Validation

Methods Returning Collections (Paging)
Methods Invoking Long Running Operations
Conditional Request Methods
Hierarchical Clients

Supporting Types

Model Types
Enumerations
Using Azure Core Types
Using Primitive Types

Exceptions (Errors)
Authentication
Namespaces
Support for Mocking

Azure SDK Libraries (Packages)

Packaging

Service-Specific Common Libraries

Versioning
Dependencies
Native Code
Doc Comments

Repository Guidelines

Documentation Style
README
Samples

Implementation

API Implementation

Service Client

Service Methods

HttpPipeline
HttpPipelinePolicy/Custom Policies

Service Method Parameters

Parameter Validation

Supporting Types
1. Serialization
2. Enumeration-like Structs

SDK Feature Implementation

Configuration
Logging
Distributed Tracing
Telemetry

Testing
Language-specific other

@sameralameer FYI


Will not panic on interface type in struct.

Fixes Latest version panics on interface{} #61

Coverage decreased (-0.5%) to 98.966% when pulling cd81a3f8caf3a6afa04049b7a76e798f0bf4ad57 on davrux:interfacefix into f23af605dff07e721ef0321469a544acfce4ce07 on fatih:master.

Thanks @davrux for the fix. Can you please add a test case? Currently all our test passed, but seems like there is no case for this. Having it would guarantee stability in the future.

Hi,
will add a test when i am back at home. I add it to the same branch.
On Jun 15, 2016 16:30, "Fatih Arslan"<EMAIL_ADDRESS>wrote:

Thanks @davrux https://github.com/davrux for the fix. Can you please
add a test case? Currently all our test passed, but seems like there is no
case for this. Having it would guarantee stability in the future.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/fatih/structs/pull/62#issuecomment-226204922, or mute
the thread
https://github.com/notifications/unsubscribe/AHneWCGhwMW0jdb_zopVb4MikuElwIscks5qMAxngaJpZM4I2Z8W
.

Coverage remained the same at 99.483% when pulling<PHONE_NUMBER>6a4ca3fd2ab006e30de100c07f80e2 on davrux:interfacefix into f23af605dff07e721ef0321469a544acfce4ce07 on fatih:master.

Coverage remained the same at 99.483% when pulling 396129a7dfeedfacbee439242509acbdd41fd28c on davrux:interfacefix into f23af605dff07e721ef0321469a544acfce4ce07 on fatih:master.

Thanks @davrux 👍


Multilingual support

I love the library you made.
I speak Korean, but the characters are broken like a question mark.
Even now, it is enough software,
If you provide multilingual support, I think more people will like it.
Thank you for making something good.
Written by your new followers.

Hi,
Can you send me a snippet code or a small project that reproduces your issue?
It's possible that you'll need to change the encoding, for example, like this:
IniFile file = new IniFile(new IniOptions() { Encoding = Encoding.Unicode });

Regards,
Mario

Thank you for your kindness.
It works nicely.
You are so cool.
you are handsome.
IniFile memoIni = new IniFile(new IniOptions() { Encoding = Encoding.UTF8 });


[YouTube] Getting playlists/library no longer works

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

[X] I understand that I will be blocked if I intentionally remove or skip any mandatory* field

Checklist

[X] I'm reporting that yt-dlp is broken on a supported site
[X] I've verified that I have updated yt-dlp to nightly or master (update instructions)
[X] I've checked that all provided URLs are playable in a browser with the same IP and same login details
[X] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[X] I've searched known issues and the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue
[ ] I've read about sharing account credentials and I'm willing to share it if required

Region
UK
Provide a description that is worded well enough to be understood
You can not longer get a list of all the playlists in your library.
It used to work with cookies and youtube.com/feed/library.
Tried /feed/playlists and that doesn't work either.
Doesn't work with latest git or latest Arch package.
Provide verbose output that clearly demonstrates the problem

[X] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[ ] If using API, add 'verbose': True to YoutubeDL params instead
[X] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output
[debug] Command-line config: ['-vU', '--flat-playlist', '-J', '--cookies-from-browser', 'firefox', 'https://www.youtube.com/feed/library']
[debug] Encodings: locale UTF-8, fs utf-8, pref UTF-8, out utf-8, error utf-8, screen utf-8
[debug] yt-dlp version<EMAIL_ADDRESS>from yt-dlp/yt-dlp [ff0779267] (source)
[debug] Lazy loading extractors is disabled
[debug] Git HEAD: 96da95250
[debug] Python 3.12.3 (CPython x86_64 64bit) - Linux-6.8.9-zen1-1-zen-x86_64-with-glibc2.39 (OpenSSL 3.3.0 9 Apr 2024, glibc 2.39)
[debug] exe versions: ffmpeg 6.1.1 (setts), ffprobe 6.1.1
[debug] Optional libraries: certifi-2024.02.02, mutagen-1.47.0, requests-2.31.0, sqlite3-3.45.3, urllib3-1.26.18
[debug] Proxy map: {}
Extracting cookies from firefox
[debug] Extracting cookies from: "/home/ethan/.mozilla/firefox/qqxaayge.default-release/cookies.sqlite"
Extracted 2624 cookies from firefox
[debug] Request Handlers: urllib, requests
[debug] Loaded 1810 extractors
[debug] Fetching release info: https://api.github.com/repos/yt-dlp/yt-dlp/releases/latest
Latest version<EMAIL_ADDRESS>from yt-dlp/yt-dlp
yt-dlp is up to date<EMAIL_ADDRESS>from yt-dlp/yt-dlp)
[youtube:tab] Extracting URL: https://www.youtube.com/feed/library
[youtube:tab] library: Downloading webpage
[download] Downloading playlist: library
[youtube:tab] Playlist library: Downloading 5 items of 5
[debug] The information of all playlist entries will be held in memory
[download] Downloading item 1 of 5
[download] Downloading item 2 of 5
[download] Downloading item 3 of 5
[download] Downloading item 4 of 5
[download] Downloading item 5 of 5
[download] Finished downloading playlist: library
{"id": "library", "title": "library", "availability": null, "channel_follower_count": null, "description": null, "tags": [], "thumbnails": [], "modified_date": null, "view_count": null, "playlist_count": 5, "channel": null, "channel_id": null, "uploader_id": null, "uploader": null, "channel_url": null, "uploader_url": null, "_type": "playlist", "entries": [{"title": "History", "_type": "url", "url": "https://www.youtube.com/feed/history", "__x_forwarded_for_ip": null}, {"title": "Playlists", "_type": "url", "url": "https://www.youtube.com/feed/playlists", "__x_forwarded_for_ip": null}, {"title": "Watch later", "_type": "url", "url": "https://www.youtube.com/playlist?list=WL", "__x_forwarded_for_ip": null}, {"title": "Liked videos", "_type": "url", "url": "https://www.youtube.com/playlist?list=LL", "__x_forwarded_for_ip": null}, {"title": "Your clips", "_type": "url", "url": "https://www.youtube.com/feed/clips", "__x_forwarded_for_ip": null}], "extractor_key": "YoutubeTab", "extractor": "youtube:tab", "webpage_url": "https://www.youtube.com/feed/library", "original_url": "https://www.youtube.com/feed/library", "webpage_url_basename": "library", "webpage_url_domain": "youtube.com", "release_year": null, "epoch":<PHONE_NUMBER>, "__files_to_move": {}, "_version": {"version": "2024.04.09", "current_git_head": "96da95250", "release_git_head": "ff07792676f404ffff6ee61b5638c9dc1a33a37a", "repository": "yt-dlp/yt-dlp"}}

The command in the provided log is working as expected as it is returning the sub-playlists correctly.

Tried /feed/playlists and that doesn't work either.

This is the real issue
❯ yt-dlp -Cv --flat https://www.youtube.com/feed/playlists
[debug] Command-line config: ['-Cv', '--flat', 'https://www.youtube.com/feed/playlists']
[debug] Portable config "D:\Programs\Source\yt-dlp\yt-dlp\yt-dlp.conf": ['--alias', '-C', '--cookies-from-browser "vivaldi"']
[debug] Encodings: locale cp1252, fs utf-8, pref cp1252, out utf-8, error utf-8, screen utf-8
[debug] yt-dlp version<EMAIL_ADDRESS>from yt-dlp/yt-dlp [ff0779267] (source)
[debug] Lazy loading extractors is disabled
[debug] Git HEAD: 5d288679b
[debug] Python 3.12.2 (CPython AMD64 64bit) - Windows-11-10.0.22000-SP0 (OpenSSL 3.0.13 30 Jan 2024)
[debug] exe versions: ffmpeg n6.0-26-g3f345ebf21-20230708 (setts), ffprobe n6.0-26-g3f345ebf21-20230708, phantomjs 2.1.1
[debug] Optional libraries: sqlite3-3.43.1
[debug] Proxy map: {}
Extracting cookies from vivaldi
[debug] Extracting cookies from: "D:\Programs\scoop\apps\vivaldi\current\User Data\Default\Network\Cookies"
[debug] Found local state file at "D:\Programs\scoop\apps\vivaldi\current\User Data\Local State"
Extracted 726 cookies from vivaldi (103 could not be decrypted)
[debug] cookie version breakdown: {'v10': 836, 'other': 0, 'unencrypted': 0}
[debug] Request Handlers: urllib
[debug] Loaded 1810 extractors
[youtube:tab] Extracting URL: https://www.youtube.com/feed/playlists
[youtube:tab] playlists: Downloading webpage
[download] Downloading playlist: playlists
[youtube:tab] Playlist playlists: Downloading 0 items
[debug] The information of all playlist entries will be held in memory
[download] Finished downloading playlist: playlists

Can I try resolving this issue? @pukkandan

Can I try resolving this issue? @pukkandan

Can I try resolving this issue? @pukkandan

Feel free to open and link a PR

I hope my issue fits here. Different playlist pages are not being analyzed correctly, and 0 results are returned. When accessing the URLs, playlists are visible. Here some URL's.
yt-dlp -Cv --flat-playlist https://www.youtube.com/@ki-cafe/playlists
yt-dlp -Cv --flat-playlist https://www.youtube.com/@EverydayAI_/playlists
./yt-dlp_linux -Cv --flat-playlist https://www.youtube.com/@ki-cafe/playlists
[debug] Command-line config: ['-Cv', '--flat-playlist', 'https://www.youtube.com/@ki-cafe/playlists']
[debug] Encodings: locale UTF-8, fs utf-8, pref UTF-8, out utf-8, error utf-8, screen utf-8
[debug] yt-dlp version<EMAIL_ADDRESS>from yt-dlp/yt-dlp (linux_exe)
[debug] Python 3.11.10 (CPython x86_64 64bit) - Linux-5.15.0-86-generic-x86_64-with (OpenSSL 3.1.7 3 Sep 2024)
[debug] exe versions: ffmpeg 4.4.2 (setts), ffprobe 4.4.2
[debug] Optional libraries: Cryptodome-3.21.0, brotli-1.1.0, certifi-2024.08.30, curl_cffi-0.7.1, mutagen-1.47.0, requests-2.32.3, secretstorage-3.3.3, sqlite3-3.44.2, urllib3-2.2.3, websockets-13.1
[debug] Proxy map: {}
[debug] Request Handlers: urllib, requests, websockets, curl_cffi
[debug] Loaded 1838 extractors
[youtube:tab] Extracting URL: https://www.youtube.com/@ki-cafe/playlists
[youtube:tab] @ki-cafe/playlists: Downloading webpage
[debug] [youtube:tab] Selected tab: 'playlists' (playlists), Requested tab: 'playlists'
[download] Downloading playlist: KI-Café - Playlists
[youtube:tab] Playlist KI-Café - Playlists: Downloading 0 items
[debug] The information of all playlist entries will be held in memory
[download] Finished downloading playlist: KI-Café - Playlists


Feature command exec

This is really a stop-gap solution until a better implementation comes along. This will only return a 200 if the command was executed, it will not return the output of the command as you might see in the console.

Looks good to me!

return the output of the command as you might see in the console

Proper way to do that is to define a custom CommandSender that directs #sendMessage(...) methods to the response body
Example

Is that something you can do @Scarsz ?

Is that something you can do @Scarsz ?

Sure

https://github.com/phybros/servertap/pull/57


Improvements for the scrip

Thanks for creating this small nice script, it saved me a lot of work.
In my fork I added some improvements:

Creation of the complete package without needing to run ros2 pkg create
Overwriting of an existing package with warning
Adding of a default RViz config so that the user does not need to manual configurate it after launch
Fixing some warnings for build and launch
Adding xacro support

Feel free to take some of these changes and add them to your script.

Thanks for using my script and making some suggestions.I will take your changes and add it to my script soon.


Adding Shanghai Astronomical Observatory

@shaoguangleo This domain does not belong to a university, nor to a college. I have to close the request without merging. Please ensure that you are familiar with this repository rules located at the bottom of this page before submitting a new request.
Please notice that free educational subscription for JetBrains tools is for students and teachers only, and is valid for using the tools for educational purpose only. If employees of this Observatory who are not students, nor teachers, need a license for JetBrains tools, they are eligible for an academic discount for the tools. They can get the discount by email to<EMAIL_ADDRESS>If you are a student of this organization, please apply with official document ("OFFICIAL DOCUMENT" tab at https://www.jetbrains.com/shop/eform/students). We highly recommend attaching a student status report from https://www.chsi.com.cn to help us verify your standing as a student.

@shaoguangleo This domain does not belong to a university, nor to a college. I have to close the request without merging. Please ensure that you are familiar with this repository rules located at the bottom of this page before submitting a new request.
Please notice that free educational subscription for JetBrains tools is for students and teachers only, and is valid for using the tools for educational purpose only. If employees of this Observatory who are not students, nor teachers, need a license for JetBrains tools, they are eligible for an academic discount for the tools. They can get the discount by email to<EMAIL_ADDRESS>If you are a student of this organization, please apply with official document ("OFFICIAL DOCUMENT" tab at https://www.jetbrains.com/shop/eform/students). We highly recommend attaching a student status report from https://www.chsi.com.cn to help us verify your standing as a student.


Fix flakiness with redisquota tests

When tests run in GKE, looks like they take more time to init and thus initial numbers we get for metrics are not accurate.
Sending a warmup traffic before calculating prior429 and prior400 in redisquota test

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: gargnupur
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: chxchx
If they are not already assigned, you can assign the PR to them by writing /assign @chxchx in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

tests/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gargnupur: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
2608a8f6352a00678d0664e3614ac03ddccb3c94
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/hold
looks like its still failing on prow.. will see what's going on

/lgtm

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: gargnupur, geeknoid
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

tests/OWNERS [geeknoid]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@geeknoid : Thanks for approving but am still testing this on prow :(
It passes locally consistently on my machine using GKE and minikube but want to make sure it is not flaky on prow..
I will remove do-not-merge/hold as soon as I think it's not flaky..

@gargnupur: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
2608a8f6352a00678d0664e3614ac03ddccb3c94
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-mixer-no_auth.sh
2608a8f6352a00678d0664e3614ac03ddccb3c94
link
/test e2e-mixer-no_auth

prow/e2e-simpleTests.sh
ab536166e8aa8be34f80ec0b48b6d1c8c33616f7
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gargnupur: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
ab536166e8aa8be34f80ec0b48b6d1c8c33616f7
link
/test e2e-simple

prow/e2e-mixer-no_auth.sh
ab536166e8aa8be34f80ec0b48b6d1c8c33616f7
link
/test e2e-mixer-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

New changes are detected. LGTM label has been removed.

@gargnupur: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth.sh
4ba638db722fde0c4d5c5d3a043778aaf82d013a
link
/test e2e-mixer-no_auth

prow/istio-unit-tests.sh
b779464cc9f676e0cdab75efe3991f1e29ce3300
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gargnupur: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth.sh
4ba638db722fde0c4d5c5d3a043778aaf82d013a
link
/test e2e-mixer-no_auth

prow/istio-unit-tests.sh
b779464cc9f676e0cdab75efe3991f1e29ce3300
link
/test istio-unit-tests

prow/e2e-simpleTests.sh
b779464cc9f676e0cdab75efe3991f1e29ce3300
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gargnupur: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth.sh
5b7b6669b971ff6f26fe5699cc2f41efc67bdb76
link
/test e2e-mixer-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gargnupur: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth.sh
5b7b6669b971ff6f26fe5699cc2f41efc67bdb76
link
/test e2e-mixer-no_auth

prow/istio-unit-tests.sh
cfee81d8f8aaa852d7e55e95c3a8fa07b62b5799
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gargnupur: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
cfee81d8f8aaa852d7e55e95c3a8fa07b62b5799
link
/test istio-unit-tests

prow/e2e-mixer-no_auth.sh
cfee81d8f8aaa852d7e55e95c3a8fa07b62b5799
link
/test e2e-mixer-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gargnupur: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth.sh
769565c7781be99e0ac6fb287d8b3c5ade5a4575
link
/test e2e-mixer-no_auth

prow/istio-unit-tests.sh
ac09926096a0d48ef07ca1bcb974a48b4a9eecb7
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gargnupur: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
ac09926096a0d48ef07ca1bcb974a48b4a9eecb7
link
/test istio-unit-tests

prow/e2e-mixer-no_auth.sh
ac09926096a0d48ef07ca1bcb974a48b4a9eecb7
link
/test e2e-mixer-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: geeknoid
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

mixer/OWNERS [geeknoid]
tests/OWNERS [geeknoid]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gargnupur: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth.sh
e4bac84d7f7f8fe648778366c2d8c225f48742c7
link
/test e2e-mixer-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gargnupur: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth.sh
547e627c8a26675dd75146457597d39cf3794cdf
link
/test e2e-mixer-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gargnupur: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gargnupur: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth.sh
0fd3834d3dcf293e0724a659376ffccb51620f9f
link
/test e2e-mixer-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: geeknoid
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

tests/OWNERS [geeknoid]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@geeknoid : It's ready for your review now :)


enabling osx build in .travis.yml

Why was this one canceled?

https://www.traviscistatus.com/incidents/k79mjcv403c4


Agent Changes: Node Agent? Ruby Agent?

Even with an HTTP server to receive data, the extension may require the agent to behave differently in the Lambda environment.  For example, we've initially talked about ensure the agents write data to APM server once, and only one, per function invocation. Also, the Node Agent's streaming APIs can do Weird Things™ between a freeze/unfreeze cycle.
Part of a Lambda MVP should include at least one language agent communicating the the extension to sending data along to APM Server successfully.

Closing this out as superseded by https://github.com/elastic/apm-aws-lambda/issues/62 -- please reopen if there's still tangible work to be done here that's not a part of #62


Take into account the requirements.txt on the project (#4508)

Pull request opened by the merge tool on behalf of #4508

Merged into branches iso5 in a20746c29ed44736201ad7a4924fe7653caf3399


Remove extra space before the question mark

There are lots of other examples of this the FAQ. Would you take care of them as well ?

Sure !


Use the Laravel Numbers helper

If you use the Numbers helper you can potentially localize the output numbers.

The presenters layer is framework ignostic

ow yeah.. sorry ;)

But the requirements are: PHP 8.3+, and Laravel 11.0+.


Push metrics to a backend in an runner agnostic way

The idea is to avoid relying on the runners to provide access to the metrics (either at the end of the pipeline or while it runs) because they don't have all the same capabilities towards metrics (e.g. spark runner configures sinks  like csv, graphite or in memory sinks using the spark engine conf). The target is to push the metrics in the common runner code so that no matter the chosen runner, a user can get his metrics out of beam.
Here is the link to the discussion thread on the dev ML<EMAIL_ADDRESS>And the design doc:
https://s.apache.org/runner_independent_metrics_extraction
Imported from Jira BEAM-3310. Original Jira may contain additional context.
Reported by: echauchot.

The following subtask(s) are associated with this issue: #18595, #18596


Fix runners-up candidacy submission check in council

same issue as: https://github.com/paritytech/substrate/pull/4429/files

Tests already existed; yet they also worked with the wrong binary search since the container to search was just one element. I reviewed all leftover of the binary_seach_xxx in that file and they only apply to members and candidates who are actually sorted by account id; This should close this whole issue.
With or without this update, in the next Kusama term change the candidate list should be cleaned. Luckily the phragmen implementation also ignores (kinda by luck; needs issue to be cleaned) dupe candidates so we should be fine.

This has a broken test @kianenigma @gavofyork

should be fixed with https://github.com/paritytech/substrate/pull/4594


rootston: force move, resize and rotate

[x] Force move/resize
[x] Force rotate
[x] Set meta key in config file
[x] Add rotation to pointer logic
[x] Rotated subsurfaces

Thanks!


ARM template for SQL serve Sync Agent - Deployment Error

Issue: ARM template for SQL Server Sync Agent fails if agent already exists, even with incremental mode deployment.
Source: https://docs.microsoft.com/en-us/azure/templates/microsoft.sql/2015-05-01-preview/servers/syncagents
Sample code:
{       "condition": "[parameters('createSyncAgent')]",       "name": "[concat(parameters('dataSyncsqlServerName'), '/',parameters('syncagentname'))]",       "type": "Microsoft.Sql/servers/syncAgents",       "dependsOn": [         "[resourceId('Microsoft.Sql/servers/databases', parameters('dataSyncsqlServerName'), parameters('metadatadbname'))]",         "[resourceId('Microsoft.Sql/servers/databases', parameters('dataSyncsqlServerName'), parameters('hubdbname'))]"       ],       "apiVersion": "2015-05-01-preview",       "properties": {         "syncDatabaseId": "[resourceId(resourceGroup().name, 'Microsoft.Sql/servers/databases',parameters('dataSyncsqlServerName'), parameters('Metadatadbname'))]"       },       "tags": "[parameters('tags')]"     }
Error Message:
At least one resource deployment operation failed. Please list deployment operations for details. Please see https://aka.ms/DeployOperations for usage details.
Details:
Conflict: {
"error": {
"code": "SyncOperation_AgentAlreadyExists",
"message": "The sync agent '***' already exists."
}
}
Task failed while creating or updating the template deployment.
Requested Outcome: If SyncAgent with given name already exists on server, do not fail deployment
Note: Contributor page on github goes "404- notfound" for syncgroups, syncagent, sync group members templates also
@tfitzmac @Mike-Ubezzi-MSFT

@avbhaskar Thanks for your comment. We are actively investigating and will get back to you shortly.

@tfitzmac Can you please look into issue and provide your inputs on this?

@stevestein Can you please provide your insights on this issue?

@avbhaskar  - thanks for the feedback.
We have an internal work item (1780954) to update the collection of data sync articles. Unfortunately, we currently don't have an estimated time of completion for this.
Thanks
#please-close

Hi Team,
Is there a resolution for this issue. We have been facing this issue in our environment where we have existing resources including azure SQL database using ARM template from azure devops. We have a requirement to enable azure SQL data sync on azure SQL database. We made the changes in the resource..json file accordingly however, it I ran the pipeline after initial deployment it gives the error that "azure SQL agent already exists" whereas it should skip this as the agent is already exists. I have been searching for the solution over the internet however no information on this issue.


custom logger has not been released

Hello,
Can you release a new version ?
I just installed the last version and the custom logger options is not available https://github.com/labithiotis/express-list-routes/pull/9 .
Thanks

Sooooooo sorry, I thought i did and I didn't get any notifications from this repo so I missed this. I have now published a new version.


Rename go build projects with real github path

We are now using wsl/ instead of distrolauncher in the package name.
Co-authored-by: Jean-Baptiste Lallement<EMAIL_ADDRESS>

Tests are passing, and this will unblock next PR


Bug in observer

Experiment finished at epoch: 102 with time: 11:36:54.624621 at 2023-11-01 03:47:11.255197
persisted model performance metric:

scalar performance:
{'acc': 0.70425045, 'precision': 0.769071, 'recall': 0.69242424, 'specificity': 0.9485995, 'f1': 0.6733403, 'auroc': 0.9361201}
oracle model performance metric:

scalar performance:
{'acc': 0.72308475, 'precision': 0.76101094, 'recall': 0.70423275, 'specificity': 0.9516947, 'f1': 0.69937694, 'auroc': 0.92619383}
[Wed Nov  1 03:47:46 2023]
Error in rule run_experiment:
    jobid: 0
    input: zoutput/benchmarks/pacs_jigen_fbopt_alone/hyperparameters.csv
    output: zoutput/benchmarks/pacs_jigen_fbopt_alone/rule_results/4.csv

RuleException:
FileExistsError in file /home/icb/daniele.scarcella/domainlab_3/domainlab/exp_protocol/benchmark.smk, line 151:
[Errno 17] File exists: 'zoutput/saved_predicts'
  File "/home/icb/daniele.scarcella/domainlab_3/domainlab/exp_protocol/benchmark.smk", line 151, in __rule_run_experiment
  File "/home/icb/daniele.scarcella/domainlab_3/domainlab/exp_protocol/run_experiment.py", line 153, in run_experiment
  File "/home/icb/daniele.scarcella/domainlab_3/domainlab/compos/exp/exp_main.py", line 89, in execute
  File "/home/icb/daniele.scarcella/domainlab_3/domainlab/algos/trainers/a_trainer.py", line 136, in post_tr
  File "/home/icb/daniele.scarcella/domainlab_3/domainlab/algos/observers/c_obvisitor_cleanup.py", line 13, in after_all
  File "/home/icb/daniele.scarcella/domainlab_3/domainlab/algos/observers/b_obvisitor.py", line 118, in after_all
  File "/home/icb/daniele.scarcella/domainlab_3/domainlab/algos/observers/b_obvisitor.py", line 153, in dump_prediction
  File "/home/icb/daniele.scarcella/miniforge3/envs/domainlab_py39/lib/python3.9/concurrent/futures/thread.py", line 58, in run
Shutting down, this might take some time.
Exiting because a job execution failed. Look above for error message

it looks like first it will check if the directory exists or not, then if not, it will create the directory,  if 153 has an error, it probably means some other process has created the directory?
      if not os.path.exists(dir4preds):¬
153                 os.mkdir(dir4preds)¬


Running paket convert-from-nuget --force yields duplicate .paket solution elements

I've been structuring quite a few legacy projects into the Project.Scaffold structure lately:

Clone my Scaffold
Add legacy projects
Run paket convert-from-nuget --force (--force required because the Scaffold project is already paket ready)
Compile fails because the Solution file now have two entries named .paket.

It is a quick manual fix, but it's a bit annoying..

Result after convertions:
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = ".paket", ".paket", "{C6453363-2956-4344-BBAE-3478594AE7AF}"
EndProject
		paket.dependencies = paket.dependencies
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = ".paket", ".paket", "{63297B98-5CED-492C-A5B7-A5B4F73CF142}"
	ProjectSection(SolutionItems) = preProject
		paket.dependencies = paket.dependencies
		paket.lock = paket.lock
	EndProjectSection
EndProject

Never mind, found that the error was in my own customizations of the scaffold, the base SLN file was damaged.

Will fix my own, and then reopen if the fix does not help


Auth0 authentication using Auth0 Rule

This authentication examples uses Auth0, and retrieves the Graphcool token as part of the Auth0 authentication process using Auth0 Rules. The Graphcool token is added as claim to the payload of the id_token received from Auth0.
This example does not require any Schema Extensions on the Graphcool side! Also, no Auth0 token exchange is needed between Auth0 and Graphcool.
Everything happens in one step, regardless of the Auth0 authentication method (Auth0 lock, auth0-react-native, Auth0.js, endpoint calls).

@kbrandwijk I haven't used Auth0 a lot, so I don't know a lot about it, but would it be possible to use this without Auth0 Lock?

@kaumac Yes, any Auth0 authentication can be used without Auth0 lock. That's completely optional. You can also use the Auth0 javascript library (https://auth0.com/docs/libraries/auth0js/v8), or call the endpoints yourself.
The only thing this PR does, is put the Graphcool token in the Auth0 token. This happens completely independent on which method you use to authorize with Auth0.

I'd prefer to see a custom mutation instead of using the Auth0 auth provider, as we're currently transitioning away from that.

Does it allow OIDC conformant clients?

@Geczy Yes, this fully supports the OIDC conformant authentication flow.

Auth0 doesn't allow saving the rule due to errors
The script has errors. Do you want to save it anyway?

Line 2: Unexpected '`'.
Line 3: Missing semicolon.
Line 3: 'projectId' is not defined.
Line 3: Expected an identifier and instead saw 'var'.
Line 9: Unexpected '`'.
Line 12: Unexpected '`'.
Line 13: Expected ')' and instead saw 'JSON'.
Line 13: 'body' is not defined.
Line 13: Expected '}' to match '{' from line 12 and instead saw ':'.
Line 14: Expected an assignment or function call and instead saw an expression.
Line 14: Missing semicolon.
Line 14: Expected '}' to match '{' from line 14 and instead saw ':'.
Line 14: Expected an assignment or function call and instead saw an expression.
Line 14: Missing semicolon.
Line 14: Expected '(end)' and instead saw '}'.
Line 14: Missing semicolon.
Line 14: Expected '}' to match '{' from line 1 and instead saw ':'.

Yes, the built-in code validator at Auth0 is a bit moody. You can save anyways.

Auth0 also complains about enabling the Password grant
Using Password or MFA grant types with public clients is not recommended.
To use the Client Credentials grant you have to set a Token Endpoint Auth Method other than "none".
See our documentation for more information.```

I'm doing this on my auth0js SPA client. I'm afraid unchecking refresh token etc will disable silent reauthentication

![image](https://user-images.githubusercontent.com/1036968/30874604-d994691a-a2be-11e7-896c-02a9c8f5eb46.png)

The rule failed for me
{
  error: "access_denied",
  errorDescription: "Cannot read property 'token' of null",
  state: "n2-pDoV0QY2nv4LFQdApcl-H8NhsbPrZ"
}

1:35:17 PM: new webtask request<PHONE_NUMBER>845.783794
1:35:18 PM: finished webtask request<PHONE_NUMBER>845.783794 with HTTP 500 in 761ms
1:35:18 PM: setting tenant quarantine
1:35:18 PM: faulting webtask container following request<PHONE_NUMBER>845.783794 failure

1:44:46 PM: new webtask request<PHONE_NUMBER>194.77670
1:44:46 PM: null
1:44:46 PM: null
1:44:46 PM: {
  "code": 500,
  "error": "Script generated an unhandled asynchronous exception.",
  "details": "TypeError: Cannot read property 'token' of null",
  "name": "TypeError",
  "message": "Cannot read property 'token' of null",
  "stack": "TypeError: Cannot read property 'token' of null\n    at Request._callback (/data/io/30d1bf1516624bf8923d265223a8501e/webtask.js:100:51)\n    at Request.self.callback (/data/sandbox/node_modules/request/request.js:186:22)\n    at emitTwo (events.js:87:13)\n    at Request.emit (events.js:172:7)\n    at Request.<anonymous> (/data/sandbox/node_modules/request/request.js:1163:10)\n    at emitOne (events.js:77:13)\n    at Request.emit (events.js:169:7)\n    at IncomingMessage.<anonymous> (/data/sandbox/node_modules/request/request.js:1085:12)\n    at IncomingMessage.g (events.js:260:16)\n    at emitNone (events.js:72:20)\n    at IncomingMessage.emit (events.js:166:7)\n    at endReadableNT (_stream_readable.js:923:12)\n    at nextTickCallbackWith2Args (node.js:511:9)\n    at process._tickDomainCallback (node.js:466:17)"
}
1:44:46 PM: Code generated an uncaught exception:  TypeError: Cannot read property 'token' of null
    at Request._callback (/data/io/30d1bf1516624bf8923d265743a8504e/webtask.js:100:51)
    at Request.self.callback (/data/sandbox/node_modules/request/request.js:186:22)
    at emitTwo (events.js:87:13)
    at Request.emit (events.js:172:7)
    at Request.<anonymous> (/data/sandbox/node_modules/request/request.js:1163:10)
    at emitOne (events.js:77:13)
    at Request.emit (events.js:169:7)
    at IncomingMessage.<anonymous> (/data/sandbox/node_modules/request/request.js:1085:12)
    at IncomingMessage.g (events.js:260:16)
    at emitNone (events.js:72:20)
    at IncomingMessage.emit (events.js:166:7)
    at endReadableNT (_stream_readable.js:923:12)
    at nextTickCallbackWith2Args (node.js:511:9)
    at process._tickDomainCallback (node.js:466:17)
1:44:46 PM: finished webtask request<PHONE_NUMBER>194.77670 with HTTP 500 in 767ms
1:44:46 PM: setting tenant quarantine
1:44:46 PM: faulting webtask container following request<PHONE_NUMBER>194.77670 failure

Oh your rule is adding the periods, and I was including the periods. So there were double periods in my PAT. Now it's working

Yeah, sorry about that. It's a bit of an ugly workaround for the max. metadata length restriction, I hope Graphcool will come up with a shorter version of a 'client secret' than the current token, it's on my wishlist...

@marktani Any plans to include this example?

This example is a must have since Graph.cool is still using legacy auth0 integration, which will be deprecated soon

I like this example, but it does not fit into the new templates concept. It probably better suits a FAQ article than this repo. I'll think about it! 🙂

@marktani I agree, do not merge. I will release a solution for this shortly. I'll leave this one open until it's ready.

I have setup the rule and still getting the same error while debugging:
"The provided idToken is invalid. Please see https://auth0.com/docs/tokens/id_token for how to obtain a valid idToken"
I'm not sure I understand how this helps Graphcool APIs use a RS256 token, which seems to be the main issue here.
Any ideas?

My bad, one more thing to do for this to work: disable the legacy Auth0 integration.

Is the rule code taking care of verifying the Auth0 token?

It doesn't have to, as it's executed internally as part of the login process. The token never leaves Auth0 before the rule executes.

Will all this work with an SPA set in Auth0?
Also, I would rather use auth0-js for my own custom login than the Auth0 Lock. Is that possible too? If so a guide on this distinction would be very welcome!
Thanks.

Authentication via Auth0 Rule is a better idea for me and I'd like to use this method instead of using the official Graphcool auth0 template because it's more simple for my code.
Also, I'd like to suggest Graphcool provide a method that uses Auth0 JWT directly, so we can make the auth process more simple.

Having similar issues as others in this thread. Is there a clear tutorial or example we can reference for implementing Auth0 integration?
I've got a React + Apollo app, using Auth0.js and seeing:
Error: GraphQL error: The provided idToken is invalid. Please see https://auth0.com/docs/tokens/id_token for how to obtain a valid idToken

I was following this tutorial: https://codeburst.io/using-auth0-with-graphcool-part-2-c44c1fef0740
Thanks for your help


CPD-1860: Rebase from upstream travis release 1.8.8

Diff with upstream master, https://github.com/travis-ci/travis.rb/compare/master...kaushik:CPD-1860

Yep, now I know what was wrong.


”Mighindoala”, ”Petiș”, ”Ștenea” are listed in the drop-down menu

Description:
When user writes ”Mighindoala”, ”Petiș”, ”Ștenea” the locations appear in the drop-down menu next to the comune and the county which is a part according to the law.
Precondition:
The website is up an running.

Step 1
Write in the search bar "Mighindoala"

Expected results
The location appears in the drop-down menu as "Sat Mighindoala, SIBIU (Șeica Mare)".

Step 2
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 3
Write in the search bar "Petiș"

Expected results
The location appears in the drop-down menu as "Sat Petiș, SIBIU (Șeica Mare)".

Step 4
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 5
Write in the search bar "Ștenea"

Expected results
The location appears in the drop-down menu as "Sat Ștenea, SIBIU (Șeica Mare)".


Different versions for playwright-java and playwright npm

On current master (and probably in latest releases), it seems like the playwright-java and npm versions don't match.
I'm asking because I've observed an issue similar to https://github.com/vitest-dev/vitest/issues/4173, only with the docker feature, not with the local feature.
Not sure whether that would be fixed by upgrading the npm version, but I guess it makes sense to keep this versions in sync whenever possible. WDYT?

We write logs under PlaywrightContainer logger to identify the potential incompatibilities between the  playwright-java and JS version inside the Docker image.
Can you please check if you anything like this:

Will use Playwright image XXX for version YYY found on classpath
Playwright version in container (XXX) is not compatible with

Generally yes, the JS version must be identical to Java version including minor version component (patch can differ), according to Playwright docs. That's the reason we print those diagnostic logs.

OK, the latter warning ("not compatible") does not occur in the logs, so versions are matching. (We currently have set log level to WARN for your packages, probably I'll change it to INFO.)
I got a bit confused by the fixed version (1.32) in package(-lock).json and noticed later on (after creating the issue) that the actually used version is configured in the docker build.

We've removed the version from package.json and added some comments to avoid confusion about the version used.
I think there is nothing else we can in this issue. Please let us know if you believe there is still some problem with our image and feel free to reopen.

Thanks for the clarifying PR and all your work on this nice project :+1:


EventSchema missing

When new Event Grid Topic is created, there is now drop down selection of Event Schema.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: aa9fcb9e-8d13-c4d1-a5d0-7eeb706c2b51
Version Independent ID: 642cbcbe-ed7d-1181-fc9a-ee3538446996
Content: Send custom events to web endpoint - Event Grid, Azure portal
Content Source: articles/event-grid/custom-event-quickstart-portal.md
Service: event-grid
GitHub Login: @spelluru
Microsoft Alias: spelluru

@JJussi Thanks for the feedback! We have assigned this issue to the content author to review and update accordingly.

https://github.com/MicrosoftDocs/azure-docs-pr/pull/71157

#in-progress

I have updated the article.
#please-close

@JJussi
Thanks for bringing this to our attention. We will now close this issue. If there are further questions regarding this matter, please tag me in a comment. I will reopen it and we will gladly continue the discussion.


[Temp] Multi region linkerd test

This is a temporary branch so I can easily test linkerd in one of my sandbox clusters.
Please ignore

This was just a temporary test that didn't work.


Forward logst to stdout instead of /dev/null

It might be a good option to have ability to forward commands output to stdout by default or define with configuration parameter

You have the option to send it to a file:
// Stdout and stderr is sent to the specified file             'output' => __DIR__ . '/data/log/jobby.log'
Is this what you want to do?

Thank you for the reply @christof-b, but this is not really what I meant
Currently if output config parameter is empty output of executing command will go to Helper::getSystemNullDevice(). My idea was to send it to "stdout" by default instead of null device or provide ability to set output as: 'output' => 'php://stdout', for example


TypeScript definitions

I've started working with humanize as part of a TypeScript application, and ended up just going ahead and creating definitions for all the exposed methods. Is this something you'd be willing to include directly in the repository and npm package? If so I'm happy to submit a PR with the changes. If not I can create and maintain a separate typings repository to host the definitions, but it's a much better user experience to have it directly in the package.
Let me know! 😄

+1

@gshackles have you move ahead with this? I've got a working typescript definition with tests I can push right now.

https://github.com/HubSpot/humanize/pull/92/files

Looks like that should take care of this, thanks! 😄  Any ETA for that making it out into a release?

@gshackles The definitions is already published to@types/humanize-plus, you can start using it right now 🎉 !
Feel free to send PR's to DT and I can 👍 the changes.
https://github.com/DefinitelyTyped/DefinitelyTyped/pull/16977
https://www.npmjs.com/package/@types/humanize-plus

Ah awesome. That said, in #92 you added the type definitions directly into this repository, so even better would be to push an updated package out that includes that definition and avoid the need for pulling in the separate definition from DT 😀

You are correct, however no one merges anything in this library, unless you have admin privileges to merge?

I opened that PR March 3rd

Doh, sorry, that's what I get for reading too quickly...I saw the closed PR but missed the fact that it wasn't actually merged. In that case, I suppose the typing will do the trick for now!

👍 Yea... if you can convince the maintainers of this library to merge or accept a Typescript definition, we can make another PR.

Hey, someone with admin privileges here—
Internally we merged this with our larger i18n library so it's a bit of a split for us to maintain both. You're more than welcome to fork and maintain & I'm happy to work with whoever wants to get things pointed there.

Whoops missed this til now. Thanks for the response, @FranDias!
If this isn't really being updated anymore then I think just leaving the separate type package seems reasonable. We don't have a real need to fork/maintain at this point, but if the need arises we can revisit.
Closing this issue out then, thanks all!


add support for go modules:

add go.mod & go.sum
change circleci to use modules
switch to golangci-lint
remove traces of dep from Makefile

@melekes can we get this merged?


Hide trailing white space warning for markdown

In the markdown syntax, it’s actually valid to have trailing spaces (it
creates a line break).
Quoting https://en.wikipedia.org/wiki/Markdown

Two spaces at the end of a line
produce a line break.

Thanks!


Feat/jp edit

I'm sorry, I accidentally created a PR on your repository.
I've asked github support to remove it, but I don't have permissions on this repository, so I'm not sure if it will be possible. Again, I'm very sorry for the inconvenience.

It's fine 😄


Amplify env add misses hostedUIProviderCreds in the team-provider.info file

Describe the bug
In my env main I have a empty hostedUIProviderCreds array in the team-provider.info file. This will not be copied if I create a new env.
This causes the error "Parameters: [hostedUIProviderCreds] must have values" after amplify push
CREATE_FAILED      authfffbadminton63e2a49c          AWS::CloudFormation::Stack Fri Aug 14 2020 17:46:16 GMT+0200 (Mitteleuropäische Sommerzeit) Parameters: [hostedUIProviderCreds] must have values
Amplify CLI Version
4.27.1
To Reproduce

create a env with the categorie auth and configuration with Social Provider (Federation)
delete the configuration with Social Provider (Federation) (Than the field hostedUIProviderCreds has an empty arry)
create a new env
amplify push cause the error Parameters: [hostedUIProviderCreds] must have values

Expected behavior
amplify env add will also copy hostedUIProviderCreds to the new env
Screenshots

Desktop (please complete the following information):

OS: Windows
Node Version: v14.8.0

Additional context
Maybe i's related to https://github.com/aws-amplify/amplify-cli/issues/3642
The workaround is to copy the field hostedUIProviderCreds manually and before the first amplify push. Otherwise cloudformation is inconsistent.

@JohannesKonings as of the latest CLI version hostedUIProviderCreds are set to empty if not configured. This should be fixed in the latest version

@JohannesKonings as of the latest CLI version hostedUIProviderCreds are set to empty if not configured. This should be fixed in the latest version


Error occurs when clicking back button in the document - "document not attached"

What happened:
When clicking the back button in the document, an error message stating "document not attached" is displayed.
What you expected to happen:
Clicking the back button should navigate to the previous page without any error message.
How to reproduce it (as minimally and precisely as possible):

Open the document.
Perform some actions within the document.
Click the back button.

Anything else we need to know?:
The error message occurs consistently whenever the back button is clicked.
Environment:

Operating system: ALL
Browser and version: ALL
CodePair version: ALL

Title
Fix issue with continuous PushPullChanges requests after detaching document
Content

What this PR does / why we need it?
This PR addresses a bug where continuous PushPullChanges requests are sent even after detaching a document, causing errors in the process. The issue occurs when navigating back triggers the document detach process.
In the yorkie-js-sdk, when editing a document, PushPullChanges requests are sent at specified intervals. However, the problem arises when detaching a document in the sdk. Despite the detach operation, the loop responsible for sending PushPullChanges requests is not terminated. As a result, the yorkie server receives requests for a detached document, leading to errors.

Once an error occurs, the loop is terminated, preventing further issues from arising.
Any background context you want to provide?
In the yorkie-js-sdk, detaching a document should ideally stop the process of sending PushPullChanges requests, ensuring that only relevant and active documents trigger these requests.
What are the relevant tickets?

Fixes #
Checklist

[ ] Added relevant tests or not required
[ ] Didn't break anything

I found a bug and want to fix it, but I couldn't because it's an issue with the yorkie-js-sdk

Related to https://github.com/yorkie-team/codepair/issues/220

@hackerwins
May I ask for your opinion?

I found a bug and want to fix it, but I couldn't because it's an issue with the yorkie-js-sdk

It looks like this will have to be resolved in the JS SDK. and we are working on  https://github.com/yorkie-team/yorkie-js-sdk/issues/856.
@jeonghye-choi @rappire
Could we work together?

I want to try to solve this problem, but bluffx is already in charge, can I work on it?

@rappire
Sorry for late check. I will assign you.

As @hackerwins mentioned, this issue should be resolved in the JS SDK.
I think it seems better to work together with @gwbaik9717 in the issue of the JS SDK (https://github.com/yorkie-team/yorkie-js-sdk/issues/856).


Plugin hooks not executed in plugin priority order

Environment

VerneMQ Version: 1.8.0
OS: docker alpine linux
VerneMQ configuration (vernemq.conf) or the changes from the default

allow_anonymous = off

plugins.vmq_diversity = on
vmq_diversity.auth_postgres.enabled = on
vmq_diversity.postgres.host = db
vmq_diversity.postgres.port = 5432
vmq_diversity.postgres.user = vernemq
vmq_diversity.postgres.password = vernemq
vmq_diversity.postgres.database = vernemq
vmq_diversity.postgres.ssl = off

plugins.vmq_webhooks = on
vmq_webhooks.webhook_reg.hook = auth_on_register
vmq_webhooks.webhook_reg.endpoint = http://jwt-auth:5000
vmq_webhooks.webhook_sub.hook = auth_on_subscribe
vmq_webhooks.webhook_sub.endpoint = http://jwt-auth:5000
vmq_webhooks.webhook_pub.hook = auth_on_publish
vmq_webhooks.webhook_pub.endpoint = http://jwt-auth:5000

plugins.vmq_diversity.priority = 10

plugins.vmq_passwd = off
plugins.vmq_acl = off
plugins.vmq_bridge = off

Cluster size/standalone: 1 node

Expected behavior
The plugin hooks should be executed in the order specified by the plugin priority.
Actual behaviour
The plugin hooks are executed out of order.
The output of vmq-admin plugin show --internal indicates that the plugin hooks are interleaved.
+------------------+----------+--------------------------+-----------------------------------------+
|      Plugin      |   Type   |         Hook(s)          |                  M:F/A                  |
+------------------+----------+--------------------------+-----------------------------------------+
|   vmq_plumtree   |applicatio|       metadata_put       |       vmq_plumtree:metadata_put/3       |
|                  |          |       metadata_get       |       vmq_plumtree:metadata_get/2       |
|                  |          |     metadata_delete      |     vmq_plumtree:metadata_delete/2      |
|                  |          |      metadata_fold       |      vmq_plumtree:metadata_fold/3       |
|                  |          |    metadata_subscribe    |    vmq_plumtree:metadata_subscribe/1    |
|                  |          |       cluster_join       |       vmq_plumtree:cluster_join/1       |
|                  |          |      cluster_leave       |      vmq_plumtree:cluster_leave/1       |
|                  |          |     cluster_members      |     vmq_plumtree:cluster_members/0      |
|                  |          |  cluster_rename_member   |  vmq_plumtree:cluster_rename_member/2   |
|                  |          |cluster_events_add_handler|vmq_plumtree:cluster_events_add_handler/2|
|                  |          |cluster_events_delete_hand|vmq_plumtree:cluster_events_delete_handle|
|                  |          |cluster_events_call_handle|vmq_plumtree:cluster_events_call_handler/|
|    vmq_config    |  module  |      change_config       |       vmq_config:change_config/1        |
| vmq_lvldb_store  |  module  |     msg_store_write      |    vmq_lvldb_store:msg_store_write/2    |
| vmq_lvldb_store  |  module  |     msg_store_delete     |   vmq_lvldb_store:msg_store_delete/2    |
| vmq_lvldb_store  |  module  |      msg_store_find      |    vmq_lvldb_store:msg_store_find/1     |
| vmq_lvldb_store  |  module  |      msg_store_read      |    vmq_lvldb_store:msg_store_read/2     |
|  vmq_diversity   |applicatio|                          |                                         |
|   vmq_webhooks   |applicatio|                          |                                         |
|vmq_diversity_plug|  module  |     auth_on_publish      | vmq_diversity_plugin:auth_on_publish/6  |
|vmq_webhooks_plugi|  module  |     auth_on_publish      |  vmq_webhooks_plugin:auth_on_publish/6  |
|vmq_diversity_plug|  module  |    auth_on_publish_m5    |vmq_diversity_plugin:auth_on_publish_m5/7|
|vmq_webhooks_plugi|  module  |     auth_on_register     | vmq_webhooks_plugin:auth_on_register/5  |
|vmq_diversity_plug|  module  |     auth_on_register     | vmq_diversity_plugin:auth_on_register/5 |
|vmq_webhooks_plugi|  module  |    auth_on_subscribe     | vmq_webhooks_plugin:auth_on_subscribe/3 |
|vmq_diversity_plug|  module  |   auth_on_register_m5    |vmq_diversity_plugin:auth_on_register_m5/|
|vmq_diversity_plug|  module  |    auth_on_subscribe     |vmq_diversity_plugin:auth_on_subscribe/3 |
|vmq_diversity_plug|  module  |   auth_on_subscribe_m5   |vmq_diversity_plugin:auth_on_subscribe_m5|
|vmq_diversity_plug|  module  |      on_client_gone      |  vmq_diversity_plugin:on_client_gone/1  |
|vmq_diversity_plug|  module  |    on_client_offline     |vmq_diversity_plugin:on_client_offline/1 |
|vmq_diversity_plug|  module  |      on_unsubscribe      |  vmq_diversity_plugin:on_unsubscribe/3  |
+------------------+----------+--------------------------+-----------------------------------------+

Steps to reproduce
Run with the plugin config above. Subscribe to a topic. The vmq_diversity auth_on_register hook is expected to be called before the vmq_webhooks auth_on_register hook.

Thanks for opening the issue - we'll look into it as soon as possible.

@dergraf, at the moment we're lazily registering the hooks as required by the scripts / hooks - I think we did it like that as we used to not have any insight in to the actual hooks used, but nowadays we have both vmq-admin script show and vmq-admin webhooks show which displays the active/configured hooks. I would therefore change the vmq_webhooks and vmq_diversity hooks to simply implement all available hooks and return sensible defaults/do nothing. Then the hook order would be exactly as the plugin order.

Hi @tobdub, I just created a PR for this (it's not yet clear if this is the final fix), would you be able to test it out? See #1307.

@larshesel Nice!
I did some quick testing and I can confirm that the fix seems to solve our problem. The plugin hooks are executed in the plugin priority order.

Thanks for testing - we just merged it and expect to release 1.9.2 with the fix in a few days!


Accessing row information in pivoted cell

What version of React-Table are you using?
latest
When pivoting a table of data by a column, it's difficult to understand from the documentation how to work with the resulting rows.
Let's say I am trying to pivot by "category", and in the resulting rows i'd like to wrap the "title" cell in a link which has the row's "id" in it.  The pivot and aggregation fields on the column don't provide you with any usable information about the rest of the row.  there is a subRow field, and a bunch of other fields, but all you can really use is row.value.  row.original or a reference to the rest of the data doesn't exist.
I'm sorry if i'm missing something, but i've spent hours on this and i just don't understand it.  It seems like it would just be easier to aggregate the information on my own, and use nested components.  Is there better or more clear documetnation on pivoting?

I think you can overwrite the getTdProps or getTrProps by injecting what you need.
like this:
getTrGroupProps: (finalState, rowInfo) => {         var index = rowInfo && rowInfo.index || 0         var getSortIndex = finalState.getSortIndex         if (getSortIndex && rowInfo) {           index = getSortIndex(rowInfo.original)         }         return {           index: index,           row: rowInfo         }       },
getTdProps: ({data, store, sorted, filtered},                    rowInfo, column) => {         return {data, store, sorted, filtered, rowInfo, column}       },
And then you can get the return value in your td or tr components

i'll give this a shot.  it just seems like you should always get row info in a cell render method.

So, here's the thing with the pivot implementation....
The "rows" that provide the summarised data are "phantom" or "ghost" rows.  They are not associated with any real "row" as that may be nested several levels below the phantom rows. You just need to detect if the subrows are present and take appropriate action (i.e. you can't really access a row or original until the leaf node is reached.

While I am not saying it is "easy" to deal with the nested structure of the pivot implementation, it is not a "bug" or "feature" request and is best discussed over on the #react-table Slack channel (badge at the top of the README in the doco) and supported with various codesandbox examples (i.e. is does not qualify as a "issue" for react-table).
So, this issue will be closed so it can continue on the Slack channel. Thanks.


Always on visible workspace (desktop)

Description of the new feature / enhancement
By press some hotkey (or choice from right click menu) set window always on visible workspace
when user go to another workspace these windows following into this workspace
Scenario when this would be used?
When using terminal window with important information\programs and its need to be displayed on all workspaces
Or for example I am using reverso translate plugin and many workspaces (desktops). Plugin running on first workspace,
when I am moving into second workspace and try translating some text, its warp me back into first workspace...
Supporting information
Fedora\Ubuntu and other Linux systems has this behaviour by default

Hello and thanks for your message. In virtual desktops, windows can be set to show on all destops. Is that what you mean and does that solve your question? If not; can you exmplain more?

Hello and thanks for your message. In virtual desktops, windows can be set to show on all destops. Is that what you mean and does that solve your question? If not; can you exmplain more?
Yes, it is what I wrote about.
Did not immediately notice this function as I got used to a different interface.
Thank you.


[SR-7080] Crash in swift_bridgeErrorToNSError when casting to NSError

Previous ID
SR-7080

Radar
rdar://problem/37904436

Original Reporter
hannesoid (JIRA User)

Type
Bug

Environment
Compiled with Swift 4.0, Xcode 9.2 with Whole Module Optimization. Crashes came from macOS 10.12.5,  macOS 10.12.6.

Additional Detail from JIRA

Votes
0

Component/s
Standard Library

Labels
Bug, RunTimeCrash

Assignee
None

Priority
Medium

md5: e111839a4fa7520459430d045d8478ca

Issue Description:
We get some crash reports that occur when we try to cast an Error to NSError.
The Error originates from a Delegate Method called by StoreKit SKReceiptRefreshRequest, so it is originally from Objective-C land. We had some cases where the failure delegate call would be come with an Error, which turned out to be nil in fact, so we already have some mitigations in place for this case.
Stacktrace
Thread 12 Crashed:
0 libswiftCore.dylib 0x000000010d74a168 _ZL28_swift_bridgeErrorToNSError_PN5swift10SwiftErrorE + 24
1 libswiftCore.dylib 0x000000010d74a3aa swift_bridgeErrorToNSError + 10
2 Purchasing 0x000000010d235814 function signature specialization <Arg[0] = Dead, Arg[1] = Owned To Guaranteed> of Purchasing.(RefreshCompletionHandler in _15032C956E2D39CFAC60B16B1135C09F).request(__ObjC.SKRequest, didFailWithError: Swift.Error) -> () (ReceiptRefresher.swift:93)
3 Purchasing 0x000000010d2353e4 @objc Purchasing.(RefreshCompletionHandler in _15032C956E2D39CFAC60B16B1135C09F).request(__ObjC.SKRequest, didFailWithError: Swift.Error) -> () (ReceiptRefresher.swift:0)
4 StoreKit 0x00007fff93a7d758 __53-[SKReceiptRefreshRequest issueRequestForIdentifier:]_block_invoke + 252
5 CoreFoundation 0x00007fff8d205b8c __invoking___ + 140
6 CoreFoundation 0x00007fff8d205a11 -[NSInvocation invoke] + 289
7 Foundation 0x00007fff8ec296af __NSXPCCONNECTION_IS_CALLING_OUT_TO_REPLY_BLOCK__ + 16
8 Foundation 0x00007fff8ec26b85 -[NSXPCConnection _decodeAndInvokeReplyBlockWithData:sequence:replyInfo:] + 790
9 Foundation 0x00007fff8eed1d27 __95-[NSXPCConnection _sendInvocation:withProxy:remoteInterface:withErrorHandler:timeout:userInfo:]_block_invoke.318 + 260
10 libxpc.dylib 0x00007fffa2bdad91 _xpc_connection_reply_callout + 44
11 libxpc.dylib 0x00007fffa2bdad1f _xpc_connection_call_reply + 35
12 libdispatch.dylib 0x00007fffa29528fc _dispatch_client_callout + 7
13 libdispatch.dylib 0x00007fffa29689a0 _dispatch_queue_serial_drain + 895
14 libdispatch.dylib 0x00007fffa295b306 _dispatch_queue_invoke + 1045
15 libdispatch.dylib 0x00007fffa2961020 _dispatch_queue_override_invoke + 368
16 libdispatch.dylib 0x00007fffa29546b5 _dispatch_root_queue_drain + 475
17 libdispatch.dylib 0x00007fffa295448c _dispatch_worker_thread3 + 98
18 libsystem_pthread.dylib 0x00007fffa2ba15a2 _pthread_wqthread + 1298
19 libsystem_pthread.dylib 0x00007fffa2ba107d start_wqthread + 12

Source Code
private final class RefreshCompletionHandler: NSObject, SKRequestDelegate {
…
    // SKRequestDelegate failure handler
    func request(_ request: SKRequest, didFailWithError error: Error) {
        let error = self.makeReceiptRefreshError(for: error as Error?) // on macOS Sierra, in production the error can be nil, eventhough API suggests nonnull
        …
    }
    // Error Wrapping
    func makeReceiptRefreshError(for skRequestError: Error?) -> PurchaseService.Error.ReceiptRefresh {
        if let error = skRequestError {
            return .storeKitRefreshError(underlying: error as NSError) // CRASH HERE
        }
        return .storeKitFailedToReturnProperError
    }
…
}

Experiencing the same with SCStreamDelegate's func stream(_ stream: SCStream, didStopWithError error: Error).

@mispellingError Do you have a small example (or even a large example) you could share?


Frontpage/home/landing/index

We need a new homepage

Working on this too in relation to #81

See #399


Extend check_vmware_rps_memory plugin to emit ballooned memory perfdata

Per GH-643, this statistic is already computed and provided by the vmware/govmomi library.

From https://vdc-download.vmware.com/vmwb-repository/dcr-public/b50dcbbf-051d-4204-a3e7-e1b618c1e384/538cf2ec-b34f-4bae-a332-3820ef9e7773/vim.ResourcePool.Summary.QuickStats.html:

Properties

NAME
TYPE
DESCRIPTION

balloonedMemory*
xsd:long
The size of the balloon driver in a virtual machine, in MB. The host will inflate the balloon driver to reclaim physical memory from a virtual machine. This is a sign that there is memory pressure on the host.

*Need not be set

Might be worth also emitting this value in the LongServiceOutput "report".


DNS: Add a factory function for ResourceRecord

`ResourceRecord`s are the core of the DNS system, and are essentially
an `enum` type when framed from a D point of view.
However, they are currently defined following the wire format,
which is less than an ideal API for the user.
As a step towards having a better API for them, a factory function needs
to be introduced, hiding the underlying details / boilerplate.

Draft as I'm testing.

Works nicely

Rebased on HEAD.


Google Auth GSSoC '24

hello admin, I can try to implement Google Authentication to the app. You can assign me this task. Discord username: the_binary_number_system. Email<EMAIL_ADDRESS>

when we run npm start in server side the server doesn't get start.

@VGandhi27 I would like to add Google Auth for this project...
can you please assign it to me?

Hi there @VGandhi27  ! I'm keen to contribute to GSSoC '24 and I'm particularly interested in issue #28 involving Google authentication. I have prior experience with Google Auth and I'm confident I can deliver high-quality work on this task. I'd appreciate it if you could assign me to this issue under GSSOC'24 label Thank you


First pass for workerapi.

[Current coverage][cc-pull] is 75.35%

Merging [#33][cc-pull] into [master][cc-base-branch] will not change coverage

@@             master        #33   diff @@
==========================================
  Files            16         16
  Lines           706        706
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits            532        532
  Misses          152        152
  Partials         22         22

Powered by Codecov. Last updated by [c656a19...dd55c3b][cc-compare]
[cc-base-branch]: https://codecov.io/gh/scootdev/scoot/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/scootdev/scoot/compare/c656a19212a02acca1dec11bbed5af1cc58be6b0...dd55c3bdac43f92f58bc8400587980452e1e1a04
[cc-pull]: https://codecov.io/gh/scootdev/scoot/pull/33?src=pr

LGTM


[Feature] Custom background color for bar chart

What problem does this feature solve?
Different color for each bar's background
What does the proposed API look like?
backgroundStyle: {
          color: (params) =>{
              if (params.name === 'USA') return 'red'
                return 'green'
          },
          borderRadius: 10,
},

@kmn988 Can you provide more context about when this is necessary?

@kmn988 Can you provide more context about when this is necessary?

I have 2 usecases for this. The first one might not be very common but when I use the option
colorBy: "data"

I want to change the background color according to the bar's color like this

For the second usecase, when I have 2 horizontal bar charts next to each other, I want to show a fixed number of 5 bars each so the distance between each bar for both graph can be the same. If the chart doesn't have enough data, I have to create fake one. When I'm using dataset option, the result will be like this

However, I've just found out that using series's and axis's data option will give me the result that I want, which is no background for item with no value

I still want to have the latter result by using dataset, which is why I request this feature so I can set the background to transparent. Hope my explanation is clear for you.

Thanks for your demo. I think it makes sense. We should provide a callback form for it.


Add array_ptr_copy

Codecov Report
Base: 75.16% // Head: 73.37% // Decreases project coverage by -1.79% :warning:

Coverage data is based on head (b7683ce) compared to base (8721c50).
Patch coverage: 2.50% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #565      +/-   ##
==========================================
- Coverage   75.16%   73.37%   -1.80%
==========================================
  Files          17       17
  Lines        5734     5742       +8
==========================================
- Hits         4310     4213      -97
- Misses       1424     1529     +105

Impacted Files
Coverage Δ

src/compiler.jl
74.76% <2.50%> (-0.90%)
:arrow_down:

src/compiler/orcv1.jl
0.00% <0.00%> (-76.93%)
:arrow_down:

src/compiler/utils.jl
57.53% <0.00%> (-38.36%)
:arrow_down:

src/compiler/validation.jl
57.68% <0.00%> (-4.39%)
:arrow_down:

src/typetree.jl
86.71% <0.00%> (-0.79%)
:arrow_down:

src/Enzyme.jl
86.04% <0.00%> (-0.05%)
:arrow_down:

src/compiler/orcv2.jl
66.32% <0.00%> (+4.42%)
:arrow_up:

src/compiler/pmap.jl
82.85% <0.00%> (+5.31%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Bug: Disable password-recovery function when localStrategy is disabled

Environment
Host

item
version

OS
Debian GNU/Linux 9 (stretch) 9.13

GROWI
4.5.12

node.js
14.18.3

npm
6.14.15

Using Docker
yes (K8s)

Using growi-docker-compose
no

(Accessing https://{GROWI_HOST}/admin helps you to fill in above versions)
Client

item
version

OS
Windows 11 Version 21H2 (Build 22000.434)

browser
Google Chrome	97.0.4692.71 (Official Build) （64 ビット） (cohort: Stable)

How to reproduce? (再現手順)

Upgrade from v4.3.x or older (or enable self-password recovery function)
Disable ID/Password auth (localStrategy)
Log out and visit login page

What happens? (症状)

Password-recovery link and API is active while ID/Password auth is not available.

What is the expected result? (期待される動作)

Password-recovery function is enabled when ID/Password auth is enabled

It is better to also disable password setting tab at user settings page.

Fixed.
Please wait v4.5.15.


Update sbt-microsites to 1.1.5

Updates com.47deg:sbt-microsites from 1.1.3 to 1.1.4.
GitHub Release Notes - Changelog - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.47deg", artifactId = "sbt-microsites" } ]

labels: sbt-plugin-update, semver-patch

@juanpedromoreno yes sbt-scoverage was my intuition as well but it doesn't work :(

ahaha nicely done @franciscodr


replace json dump comparison with specific, type-safe comparison in transaction processing tests

Motivation
fixes #2191
Changes
for tests using ApplyTransaction, changed test from checking/comparing json dumps to discrete assert.Equals checking all relevant values

@avive @noamnelke - just tagging for visibility + PR review request (I don't think I've access to add a reviewer to a PR)

good refactor - too bad it's not merged and inactive - closing it


Determine doc impact of P1855R0

Determine doc impact of P1855R0
Occasionally, a paper increases restrictions on users (either at compile-time or run-time) without requiring implementations to diagnose improper usage.
This has no implementation impact, but may have doc impact.
Determine the doc impact of this paper.

moved to quest


DoTA dataset

Can I run the DoTA dataset in your tad-IROS2019 project?@MoonBlvd

Do you have a try?

Hello, can you tell me how to run the codes on DoTA dataset?

If you have tried, can you tell me how to run the codes on DoTA dataset?


Custom product prices have double asterisk

Custom product options price information contains a double asterisk at the end.
Plugin version: 5.1.0
Expected result: single asterisk for each price information for custom product options.
!Screen Shot 2024-10-08 at 14.18.15 PM.png|width=1072,height=1724,alt="Screen Shot 2024-10-08 at 14.18.15 PM.png"!

[public] Shopware automated response: This issue is linked to the internal issue: CUS-728
[created from CUS-728, comment 501696]


[MS DI] Adds ability to resolve URL from ServiceProvider.

Code change for issue #530.

@mausch  you want to have a look as well before merging?

@mausch  you want to have a look as well before merging?

Thanks for the PR Victor!
I agree with Gidon about the importance of keeping a clean git history. I cleaned up a bit more and applied your change in 91290ea5cde65efd56881eec740297944d4481d7
Oh I also had to make a couple of exception message test assertions a bit more flexible as I was getting a slightly different exception message on my machine :man_shrugging: no big deal.

Thanks for the PR Victor!
I agree with Gidon about the importance of keeping a clean git history. I cleaned up a bit more and applied your change in 91290ea5cde65efd56881eec740297944d4481d7
Oh I also had to make a couple of exception message test assertions a bit more flexible as I was getting a slightly different exception message on my machine :man_shrugging: no big deal.


Deserialize chrome JSON trace into data structure

This way xi-mac (or any other frontend) can just send the JSON trace to xi_core for dumping to disk instead of needing to use the Rust tracing framework.

@vlovich Want to merge #498 and rebase this? You have commit access correct?

This probably isn't the cleanest implementation.  The way it works is that chrome_trace provides the mapping from Samples object to chrome trace JSON struct. If we wanted to add flame graph we'd add a flame_graph.rs that implemented that mapping.  So you don't get serialization for free automatically if you add/remove/rename stuff as the serialization/deserialization code for that specific format has to be adjusted.  However, that seems pretty reasonable since the serialization/deserialization format determines how things are serialized/deserialized and I'm not sure how you'd create a way for it to happen automagically.  I guess you could define a custom tag that indicates how structs maps to fields if it's a 1:1 mapping but even the chrome trace stuff isn't 1:1.
Did I answer your question correctly or were you asking something else?


blur events & blur behaviors

Hello,
I don't figure it out, is there any blur events on rows, cells and/or grid?
I saw there is a cellFocus event.
I took a look on AgGrid.RenderedRow.prototype.addCellFocusedListener  and the focusedCellController but I didn't found the way to do it properly.
By the way, it would be fine to remove the ag-focus-row class on gird filtering/sorting or to follow the focus on the last focused row berfore filtering/sorting. And also to remove it on grid blur, nop?
Thank you.

three was a problem where ag-row-focus was not getting changed correctly when ordering or filtering (basically if the row moved). i have just fixed this now, the ag-row-focus now stays with the right row index.

ok nice thank you.


Add support for retry count on 429 response codes

Hey! In this moment, the retry count for 429 response is set to 2. In some cases, that value doesn't help, since in between retries there are other requests made to the same domain.
I've added an option so users can configure that count. By default, it is set to 2.
Cheers!

Could also allow the original parameter take in a number, and try sniffing with parseInt

You mean changing retryOn429 from boolean to integer? Could be an option, but it is a breaking change, since who is already using that option will need to convert true to a number.

Not saying it has to be this way, but here is what I was thinking
retryOn429 = isNaN(parseInt(retryOn429)) ? (!!retryOn429 ? 2 : 0 ) : parseInt(retryOn429)

It may also require a test for this and by the way it looks like the 429 feature has no test at all...

It may also require a test for this and by the way it looks like the 429 feature has no test at all...

I've created tests for both options


Remove unnecessary quote in nginx log format

Solving - https://github.com/kubernetes/ingress/issues/482

This change is

Coverage increased (+0.02%) to 43.146% when pulling 3b55e09e23162f6d4da64a9367fb6026329a4c66 on tsupertramp:fix-nginx-log-format into fc5da496171a7916cbc5668b4a2caa9ab43e538f on kubernetes:master.

/lgtm

@tsupertramp thanks!


Incorrect time duration

Hi, I noticed that measured time is wrong compared to CLI (but it's obvious it doesn't work even without CLI).

without @multiple and with @testCase annotations 15s 63ms (but it should be ~1.6s)
with @multiple and with @testCase annotations 1m 56s 1m (in CLI ~13.1s)

Does this plugin take into account @multiple and @testCase annotations?

See #6. I can't see a way around this issue at all :(

Oh, sorry. This is unfortunately quite a big issue for me because total time is sometimes important. Should I close this issue as well or should I wait? I really hope you'll figure it out somehow... :)


rocketmq_proxy: remove well_known_names

Signed-off-by: Long Dai<EMAIL_ADDRESS>Commit Message:
Remove well_known_names in listener field, part of #7238
Additional Description:
Risk Level: Low
Testing: functional, integration
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]

update when passing CI
/wait

@daixiang0 this well_known_names.h in rocketmq_proxy is just a constant.h so it should stay or be renamed.

Hi, @lizan I have renamed it and remove const_singleton dependence. If you think after move to contrib, no need to handle weell_known_names, please comment in the issue and I will close all related PRs.

kingly ping @jmacd


Add a Gitter chat badge to README.md

zimbatm/direnv now has a Chat Room on Gitter
@zimbatm has just created a chat room. You can visit it here: https://gitter.im/zimbatm/direnv.
This pull-request adds this badge to your README.md:

If my aim is a little off, please let me know.
Happy chatting.
PS: Click here if you would prefer not to receive automatic pull-requests from Gitter in future.

Already done at the bottom of the README


Tooling: removes archived repositories

Both friboo and twintip-spring-web are archived in Github.com

:+1:

👍


Update README

The README should be updated to mention that the master branch is unstable, and that the examples shown are only for the master branch

I'll make a PR for this

Thanks, @OsamaNabih !


Implement permission system

Setup backend system for permissions

The system need to be easily maintainable and easy to administer


DisableRequestSizeLimit and RequestSizeLimit do not work

There appears to be a bug in versions 2.1.0 where the DisableRequestSizeLimit and RequestSizeLimit attributes do not work.
I have the following controller action defined.
        [HttpPost]
        [DisableRequestSizeLimit]
        //[RequestSizeLimit(1073741824)]
        public async Task<string> UploadDocumentContent(IFormFile file)

Uploading a large file to this action results in the following exception.
System.IO.InvalidDataException: Multipart body length limit 134217728 exceeded

Thanks for contacting us, @groogiam.
@Tratcher who will be the best person to look into this?

You're not hitting the request size limit, you're hitting the form size limit:
https://github.com/aspnet/HttpAbstractions/blob/87cd79d6fc54bb4abf07c1e380cd7a9498a78612/src/Microsoft.AspNetCore.Http/Features/FormOptions.cs#L76
https://github.com/aspnet/Mvc/blob/23b7d8f62a2515e2dbea436ef118fb67e759e2d9/src/Microsoft.AspNetCore.Mvc.Core/RequestFormLimitsAttribute.cs#L18

That does the trick. Thanks for pointing that out.


-h in priority

When calling a binary, some users forget how some arguments work and simply add a -h to see the help again, without removing all parameters.
job a/long/path.gz another/long/path.gz a/long/path/again.gz -h

In some libs, like argparse, this prints the complete help message, as if you used job -h. With docopt-rs, it does print the usage message, but doesn't actually care about the -h. It would print the same thing with a non-existing parameter.
Invalid arguments.

Usage:
    job ...

tl;rd it would be nice to print the whole help message with -h, even if there are other args.

Looks like this has been open for a a little bit.
Currently the behavior with -h at the end of a command is what you wanted.
Invalid arguments.

Usage:
    job ...

So should this issue be closed?


Add offline tests with sample whois responses.

I'm willing to write some unittest using sample data taken from whois.
So it's only test code and json data.
Let me know if it's fine.

I am open to that. Maybe call it test_ipwhois_offline.py

Added for v0.11.0 release


Add an arg_min function to the library

Signature is arg_min<V, C>(it: iterable<V>, fn: function(v: V): C): V
where C is some type that supports comparisons.

You may need a second function to apply to the result at the end too.
In the lcp example both functions would be projections of a tuple.
Can we write tuple projections in ddlog?

There are no higher-order types in DDlog, so you cannot pass functions as arguments.

Well, then you can just specialize it for tuples with two elements.


Allow creating API keys for non-clusters

I am willing to re-work this some if it is too hacky. But this change allowed me to create api keys for schema registries. They were failing since this provider was attempting to wait for the kafka cluster and was getting a "null reference exception".

@Mongey any update when this can be merged? It resolves #60.

@Mongey any update on when this can be merged as it resolves #60?


Update CircleCI configuration

Context

Leverage on reusable commands https://circleci.com/docs/2.0/reusing-config/#authoring-reusable-commands
Set push images as manual job
Make the nightly build now as 3 times a week

The amount of pushes was too often specially after merging documentation and smaller things, if necessary the push step is going to be manual, otherwise it'll be automatically push in a couple of days

Closed in favor of #86


Not running, file missing

First at all, thank you for your work! I am using it since years, no I want some stats for the first time, but unfortunately it is not working.
I got the following message after trying to use this script. (I removed the domain part):
The update server is installed in "update" "stats" is a subdir.
PHP Warning:  require(/update/stats/vendor/autoload.php): failed to open stream: No such file or directory in /update/stats/update.php on line 2
PHP Fatal error:  require(): Failed opening required '/update/stats/vendor/autoload.php' (include_path='.:/usr/share/php') in /update/stats/update.php on line 2

I am sorry, the problem was solved after running plesk repair fs... the plesk php composer set wrong permisssions.


Missing photos counter wrong

🐛 Bug Report
What Operating system and version is LibrePhotos running on:
unknown
What architecture is LibrePhotos running on:
x64
How is LibrePhotos installed:
Docker
Description of issue:
u/nagarrido_96 on reddit reports: I have a test instance for librephotos, and recently I deleted all photos but one (directly from the source folder). When I click "remove missing photos" the missing photos get deleted, but the counter for total photos and missing photos does not reset. Has this happened to anyone?
How can we reproduce it:

Delete images from folder
Run "Delete Missing" job
Counter does not change

Does it update eventually? I think i remember seeing this before, but after a certain amount of time it did update to match the actual number of photos.

This is fixed, I think


Add optional work_group to query

Closing this since we don't need workgroup support at this time.

Closing this since we don't need workgroup support at this time.


jss deploy:watch is not generating the bundle file

Hi,
I followed the documentation https://jss.sitecore.com/docs/techniques/mvc-integration/javascript-rendering and created Javasrcipt rendering.
As per the documentation, jss deploy:watch should generate a bundle file which is not happening.
Please guide to identify and fix the issue.
Thanks,
Priya

@PriyaShan16 Hi. Did you check files in  sitecore webroot dist/JssComponentsReactWeb?
It should generate bundles there. If you want to generate build in your project, not in sitecore instance, you can run jss build. Try to change any file and after that look into the dist/JssComponentsReactWeb. Please, notify about results

@PriyaShan16 In case if you will have same problem in latest version, please, fell
free to open issue.


Buggy when combining SW and TableView editing delegate methods

When I'm using just SWTableViewCell, everything works perfectly.
However, when combining it with native UITableViewCell delegate methods for editing functionality, such as tableView:commitEditingStyle:forRowAtIndexPath or tableView:canMoveRowAtIndexPath:, it gets glitchy sometimes.
I'm not doing anything out of the ordinary: tableView:cellForRowAtIndexPath: is setting rightUtilityButtons then the delegate, per the SW sample app. The tableView delegate methods are also pretty straight forward, they simply allow reordering, and deleting. I don't really care about deleting via the tableView delegate since I'm handling that in SW, but I need reordering and delete comes free with that when in edit mode.
It looks like adding this resolves the problem. It would be nice if this "fix" wasn't necessary.

(UITableViewCellEditingStyle)tableView:(UITableView *)tableView editingStyleForRowAtIndexPath:(NSIndexPath *)indexPath
{
return UITableViewCellEditingStyleNone;
}

Here's what I'm seeing happen:
https://www.dropbox.com/s/rw0m5469m2nelrb/SWTableViewCell.mov

@nod Have you found a solution for swipe gestures not being recognized?

A solution: You can implement -respondsToSelector: method in your controller and return NO when is asking about @selector(tableView:commitEditingStyle:forRowAtIndexPath:). Anything like this:
-(BOOL)respondsToSelector:(SEL)aSelector {
if (@selector(tableView:commitEditingStyle:forRowAtIndexPath:) == aSelector) {
return NO;
} else {
return [super respondsToSelector:aSelector];
}
}

@nod @karadza3a Have you found a solution to this?

@buttcmd sorry, I actually no longer work on that app.  I don't recall ever coming up with a good solution and ended up rewriting it to use a different lib.


Issues about notebook "3. Feature Engineering.ipynb"

After running the jupyter notebook "3. Feature Engineering.ipynb" in the update-reqs, I get two errors:
(1) in chunk [39]:
ValueError: ('Unknown transform primitive weekend. ', 'Call ft.primitives.list_primitives() to get', ' a list of available primitives') ,
I think this is because you specify transformation primitives as trans_primitives = ['weekend', 'cum_sum', 'day', 'month', 'diff', 'time_since_previous'], but 'weedend' is not a primitive, 'is_weekend' is a primitive.
(2) in chunk [42]:
'AttributeError: Cutoff time DataFrame must contain a column with either the same name as the target entity time_index or a column named "time" ',
I have check the dataframe of cutoff_time and members, they have the common columns "msno",  so I have no idea about this issue?

Both of these issues were fixed in pull request #21, but that has not yet been merged in. If you run the notebook versions in the update-reqs branch, you should be able to run without issue.
The second error is related to naming of the cutoff time dataframe columns. Newer versions of featuretools are expecting the cutoff time column to be named either "time" or to have the same name as the time index of the target entity. In the notebook version you were running the cutoff time column was named "cutoff_time" which is no longer a valid name.
You should be able to resolve these errors by using the is_weekend primitive as you discovered and renaming the cutoff time column from "cutoff_time" to "time".


*: move lock manager to server (#5381)

Cherry pick #5381 which is the prerequisite for https://github.com/tikv/tikv/pull/5518, https://github.com/tikv/tikv/pull/5680 and https://github.com/tikv/tikv/pull/5483.

/run-all-tests

LGTM

@sticnarf @MyonKeminta PTAL

Please fix the conflicts.

@sticnarf PTAL.

/run-all-tests

/merge


Deprecation of 'formatting.formatOnSave' in favor of 'editor.formatOnSave'

The custom setting python.formatting.formatOnSave used to enable formatting upon saving has been deprecated in favor of the standard VS Code setting.
If would you like to enable formatting upon saving, please enable the setting editor.formatOnSave within your user or workspace settings as follows:
"editor.formatOnSave": true

If you prefer to enable or disable this feature specifically for python, you could do so as follows:
"[python]":{
    "editor.formatOnSave":false
}

More information on these configuration settings cane be found here.

Related to https://github.com/Microsoft/vscode-python/issues/285


Implement ListGeodatabaseVersions for iOS

This should be the last sample implementation needed to bring iOS into
parity with all other platforms.

@ThadT Can you please take a look when you have some free time?

Thanks for the review! I made those changes and am now merging.


Switch back to alpine image

Checklist

[X] I have followed the Contributor Guidelines.
[ ] I have added the relevant documentation.
[X] My branch is up-to-date with the upstream master branch.

Changes proposed in this pull request
Fixes #188
Your development environment

OS: Manjaro
OS Version: 4.19
Python Version: 3.8

 Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 1

See the complete overview on Codacy


Initial files.

This is a starting point based on https://github.com/digitalbazaar/vc-status-list with renamed properties and simple updates.  Some tests pass, some fail, some probably pass because of unrelated failures are caught, some seem to fail due to invalid mock data signatures.  An incomplete list of items to address:

[x] Fix current tests.
[ ] Check tests match the vc-bitstring-status-list spec vs the vc-status-list[-2021] one.
[ ] Add more tests to cover new features and properties (ttl, statusReference, stsatusSize, statusMessage, etc).
[x] Mock encodedList data needs to be multibase formatted.
[x] Add tests to catch non-multibase encodedList.
[ ] Mock data likely needs to be re-generated to get valid new signatures.  (I'm not sure where this data came from or if a script exists to do this.)
[ ] The tests are based on VC V1 context.  In theory the context should be compatible with V2, which should likely be tested, even though the context is redundant.

If there are errors related to search and replace from vc-status-list, mass replacing of the changes is fine.  May be worth comparing the files to see what was changed.

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@8646a67). Click here to learn what that means.
The diff coverage is 97.54%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main       #1   +/-   ##
=======================================
  Coverage        ?   97.54%
=======================================
  Files           ?        2
  Lines           ?      448
  Branches        ?        0
=======================================
  Hits            ?      437
  Misses          ?       11
  Partials        ?        0

Files
Coverage Δ

lib/BitstringStatusList.js
95.45% <95.45%> (ø)

lib/index.js
97.77% <97.77%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8646a67...ff97ce3. Read the comment docs.