Invalid SigV4 configuration: invalid auth type:

What happened:
"Save and Test" seems to work but when we try to explore the data it gives errors intermittently. It does happen time to time but not consistently.

When it happens we see this error on console:

Grafana pod has errors:
[plugin.downstreamError] failed to query data: Failed to query data: rpc error: code = Unknown desc = OpenSearch data source error: Post "https://logs.xxxxxxx.net/_msearch?max_concurrent_shard_requests=5\": invalid SigV4 configuration: invalid auth type: "
Weirdly this happens intermittently and not all the time.
Full logs:
logger=context userId=10 orgId=1 uname=Yogesh.Gupta@xxxxxxx t=2023-10-19T02:11:57.87894385Z level=error msg="Internal server error" error="[plugin.downstreamError] failed to query data: Failed to query data: rpc error: code = Unknown desc = OpenSearch data source error: Post \"https://logs.XXXXXXXXX.net/_msearch?max_concurrent_shard_requests=5\": invalid SigV4 configuration: invalid auth type: " remote_addr=<IP_ADDRESS> traceID=
logger=context userId=10 orgId=1 uname=Yogesh.Gupta@xxxxxxx t=2023-10-19T02:11:57.879030752Z level=error msg="Request Completed" method=POST path=/api/ds/query status=500 remote_addr=<IP_ADDRESS> time_ms=28 duration=28.445143ms size=116 referer="https://grafana-xxxxxxxxxxxx.net/explore?left=%7B%22datasource%22%3A%22P9744FCCEAAFBD98F%22%2C%22queries%22%3A%5B%7B%22refId%22%3A%22A%22%2C%22datasource%22%3A%7B%22type%22%3A%22grafana-opensearch-datasource%22%2C%22uid%22%3A%22P9744FCCEAAFBD98F%22%7D%2C%22query%22%3A%22%40app_family%3AAPIGateway%22%2C%22queryType%22%3A%22lucene%22%2C%22alias%22%3A%22%22%2C%22metrics%22%3A%5B%7B%22type%22%3A%22count%22%2C%22id%22%3A%221%22%7D%5D%2C%22bucketAggs%22%3A%5B%7B%22type%22%3A%22date_histogram%22%2C%22id%22%3A%222%22%2C%22settings%22%3A%7B%22interval%22%3A%22auto%22%7D%2C%22field%22%3A%22%40timestamp%22%7D%5D%2C%22format%22%3A%22table%22%2C%22timeField%22%3A%22%40timestamp%22%7D%5D%2C%22range%22%3A%7B%22from%22%3A%22now-1h%22%2C%22to%22%3A%22now%22%7D%7D&orgId=1" handler=/api/ds/query

What you expected to happen:
Plugin should be able to talk to opensearch
How to reproduce it (as minimally and precisely as possible):
Have the versions listed below and try perhaps.
This is happening intermittently though.
Anything else we need to know?:
There was a similar issue with Elasticsearch and I am not sure if its related. https://github.com/grafana/grafana/issues/31099
Environment:

Grafana version: 9.5.7
OpenSearch version: 1.0.0
Plugin version: 2.13.1

HI @iamyogeshg ! Thanks for reporting this issue. I haven't been able to reproduce it yet, but does it happen in panel queries or in Explore, or both? And have you noticed it happening with any specific query types? We've done some refactoring of some of the query types recently, so I'm trying to figure out if that's related.

Hi @iwysiu I did not test with panel yet but I am facing this error in explore option which we get in data source settings.

logger=plugin.grafana-opensearch-datasource t=2023-10-23T22:28:09.613793462Z level=info msg="Creating new client" indices=v* timeField=@timestamp version=1.0.0 PPLindex=v*
logger=context userId=10 orgId=1<EMAIL_ADDRESS>t=2023-10-23T22:28:09.614956842Z level=error msg="Internal server error" error="[plugin.downstreamError] failed to query data: Failed to query data: rpc error: code = Unknown desc = OpenSearch data source error: Post \"https://logs.poc.company.net/_msearch?max_concurrent_shard_requests=5\": invalid SigV4 configuration: invalid auth type: " remote_addr=10.10.XX.XX traceID=
logger=context userId=10 orgId=1<EMAIL_ADDRESS>t=2023-10-23T22:28:09.615065819Z level=error msg="Request Completed" method=POST path=/api/ds/query status=500 remote_addr=<IP_ADDRESS> time_ms=38 duration=38.226105ms size=116 referer="https://grafana-monitoring.company.net/explore?left=%7B%22datasource%22%3A%22P9744FCCEAAFBD98F%22%2C%22queries%22%3A%5B%7B%22refId%22%3A%22A%22%2C%22datasource%22%3A%7B%22type%22%3A%22grafana-opensearch-datasource%22%2C%22uid%22%3A%22P9744FCCEAAFBD98F%22%7D%2C%22query%22%3A%22%22%2C%22queryType%22%3A%22lucene%22%2C%22alias%22%3A%22%22%2C%22metrics%22%3A%5B%7B%22type%22%3A%22count%22%2C%22id%22%3A%221%22%7D%5D%2C%22bucketAggs%22%3A%5B%7B%22type%22%3A%22date_histogram%22%2C%22id%22%3A%222%22%2C%22settings%22%3A%7B%22interval%22%3A%22auto%22%7D%2C%22field%22%3A%22%40timestamp%22%7D%5D%2C%22format%22%3A%22table%22%2C%22timeField%22%3A%22%40timestamp%22%7D%5D%2C%22range%22%3A%7B%22from%22%3A%22now-1h%22%2C%22to%22%3A%22now%22%7D%7D&orgId=1" handler=/api/ds/query

More logs from when grafana when error occurs in explore tab -> "Run Query"

@iamyogeshg I'm wondering if you can try selecting a different auth type saving and then reselecting sdk default again as your authentication provider and let us know if the issue persists after that?
I'm a bit unclear how this could have happened but it seems like you might be hitting this error message in the default case of our sigv4 code: https://github.com/grafana/grafana-aws-sdk/blob/main/pkg/sigv4/sigv4.go#L265 for when no auth type has been selected.

Closing this due inactivity, feel free to open another issue if you're still having difficulty!


"additionalItems" should not be honored if "items" is an object.

As per json-schema specification:

if "items" is not present, or its value is an object, validation of the instance always succeeds, regardless of the value of "additionalItems";

Currently (v 4.0.x), CollectionConstraint makes an extra checks for "additionalItems" if "items" is object and  fails validation

Feel free to open a PR

@SereneAnt @shmax Are either of you guys intending to address this, or should I add it to my list?

(Note that I don't consider this a high priority, so if it goes on my list, it may take me a while to get to it).

@erayd I'm off this train as for now, sorry. For sure, you'll do it better!

@erayd I wasn't planning on it, but you've been doing most of the heavy labor around here lately, so if you would like me to look at it I will.

@shmax Feel free if you're in the mood, but no pressure and no rush - this issue is IMO minor, has already been open for five months, and the OP doesn't seem to care.
If you don't feel like doing this, it's not an issue, and I'll probably catch is sometime during my implementation of strict-mode, once we have the rules thing sorted.

Unable to reproduce, closing for now. @SereneAnt feel free to reopen with additional information.
Also glancing at the Bowtie report the test case which seems to be the context you're describing passes (on the V6.0..0 version).


[package] Homebrew formula should default to "openjdk" dependency (without a version) for Java projects

Current default behaviour of JReleaser's brew packager is to add a dependency to "openjdk@VERSION".
This should be changed to "openjdk" without a version:

Most Java software does not need to be pinned to a specific JDK release, it just has a minimum requirement (e.g. 8 or 11).
Adding "openjdk" as a dependency will ensure that the latest available OpenJDK release is installed (e.g. 19.0.2 as of this writing).
Using a specific JDK version for each project may clutter the machine with several JDKs, which is especially useless if those aren't LTS versions.
In those cases where a specific JDK version must be used, one can still add a specific version dependency (or use a bundled JDK in the first place).

This is also the pattern used by most Homebrew formulae for Java software:

Most Java-based packages in Homebrew use the default Homebrew-provided openjdk package for their JDK dependency, although some packages with specific version requirements may use a versioned package such as openjdk@8.
https://docs.brew.sh/Homebrew-and-Java#executing-commands-using-a-different-jdk

Current workaround is to explicitly disable the default inclusion of openjdk dependency and add an explicit dependency, such as
    brew:
      active: always
      dependencies:
        openjdk: null
      extraProperties:
        skipJava: true

Which generates a formula like the the following one
# Generated with JReleaser 1.5.0 at 2023-02-28T09:25:30.019416+01:00
class App < Formula
  desc "Awesome App"
  homepage "https://acme.com/app"
  url "https://github.com/aalmiray/app/releases/download/v1.0.0/app-1.0.0.zip"
  version "1.0.0"
  sha256 "c3b3992bb79c69d22595260bebfa1fc8b567edc6ed43f111d6e22ed645f4378f"
  license "Apache-2.0"

  depends_on "openjdk"

  def install
    libexec.install Dir["*"]
    bin.install_symlink "#{libexec}/bin/app" => "app"
  end

  test do
    output = shell_output("#{bin}/app --version")
    assert_match "1.0.0", output
  end
end

🎉 This issue has been resolved in v1.6.0 (Release Notes)


Enable OSX

Not sure about these errors:
In file included from /Users/travis/build/xtensor-stack/xtensor-zarr/test/test_zarr.cpp:12:
In file included from /Users/travis/miniconda/envs/test/include/xtensor/xview.hpp:20:
/Users/travis/miniconda/envs/test/include/xtl/xclosure.hpp:26:20: error: no template named 'add_const_t' in namespace 'std'; did you mean 'add_const'?
    constexpr std::add_const_t<T>& as_const(T& t) noexcept
              ~~~~~^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/type_traits:1030:50: note: 'add_const' declared here
template <class _Tp> struct _LIBCPP_TEMPLATE_VIS add_const
                                                 ^

Superseded with #9

You meant #10

yes ;)


User set in the docker-compose.yml not being reflected in the devcontainer

Does this issue occur when all extensions are disabled?: Yes/No - Yes

VS Code Version:  1.72.1
OS Version: Windows 11 Home

Steps to Reproduce:

Update VS Code to the latest version
Build a container with the user set to root in the docker-compose.yml
Observe that the terminal launches with the user set to vscode

After the latest vscode update, docker containers are having issues with a set user, specifically if it was set to root. instead of using the user set in the docker-compose.yml file its using a vscode user which isn't set anywhere.

`
Add a User
user: root
`
Add this setting to a docker-compose.yml to toggle the issue


Beta - 'Random Numbers' typos in instructions

Challenge http://beta.freecodecamp.com/challenges/random-numbers has an issue. Please describe how to reproduce it, and include links to screenshots if possible.
This isn't terribly important, but I noticed a few grammar issues in the instructions for this challenge. Maybe reword it as such?

Random numbers are a very useful way to create random behaviors and games.
JavaScript has a Math.random() method that can generate a random decimal number.
Let's have a go of Math.random() now by getting myFunction to return a random number.

I'll take care of this one! Will be some good practice with the git workflow :)

Pull request submitted, #1607

@benmcmahon100 let's close this one

@Greenheart when making a pr do have a line in the commit message like this
Fix (The url of the issue)

That way once the pr is merged it will auto-close the issue (I think)

@benmcmahon100 Thanks! I'll do that in the future! :)

@Greenheart Awesome keep up the good work!


Fixes #35

Codecov Report

Merging #48 (7ed6fd8) into main (44ba91c) will not change coverage.
The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@           Coverage Diff           @@
##             main      #48   +/-   ##
=======================================
  Coverage   98.38%   98.38%
=======================================
  Files           7        7
  Lines         186      186
  Branches       53       53
=======================================
  Hits          183      183
  Misses          3        3

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


RP23 PWM Dirver only works for b pins.

I'm using the Pimorani Pico Plus 2 board (https://shop.pimoroni.com/products/pimoroni-pico-plus-2?variant=42092668289107), running Rust and Embassy.
PWM output appears to work perfectly for B pins, including the LED on PIN 25, however, A pins don't seem to have any output at all, they don't even go high if you set config::invert_a=true;
The following code works, i.e. I can see PIN13 toggle at about 3.8kHz with a scope:
    let p = init(Default::default());

    let mut c: Config = Default::default();
    c.top = 0x8000;
    c.compare_b = 0x800;
    let mut pwm: Pwm<'_> = Pwm::new_output_b(p.PWM_SLICE6, p.PIN_13, c.clone());

However, if I convert it to drive PIN 12  which is an A pin, then there is no output at all:
    let p = init(Default::default());

    let mut c: Config = Default::default();
    c.top = 0x8000;
    c.compare_a = 0x800;
    let mut pwm: Pwm<'_> = Pwm::new_output_a(p.PWM_SLICE6, p.PIN_12, c.clone());

This is true for other A pins as well, e.g. PIN 28.
I'm very new to Rust and especially Embassy and the RP2350, so I apologise in advance if I've made any stupid mistakes.
Nick
Edit: fixed typo in PIN12 example.

Some additional info, I've tried new_output_ab() as well, even then, only B pins work. For example,
    let mut c: Config = Default::default();
    c.top = 0x8000;
    c.compare_a = 0x800;
    c.compare_b = 0x800;
    let mut _pwm: Pwm<'_> = Pwm::new_output_ab(p.PWM_SLICE6, p.PIN_12, p.PIN_13, c.clone());

Results in 3.8kHz on PIN 13, but nothing on PIN12.


chore(master): release 1.1.33

:robot: I have created a release beep boop
1.1.33 (2023-04-25)
Miscellaneous

deps: update dependency vite to v4.3.2 (6252414)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/wayofdev/keywind/releases/tag/v1.1.33 :sunflower:


Exception in setUpBeforeClass

With my current configuration, SpeedTrapListener fails with an unhelpful Exception, if setUpBeforeClass throws an Exception.
SpeedTrapListener::endTest is called with $test as instance of PHPUnit_Framework_TestSuite,
which causes an E_RECOVERABLE_ERROR because SpeedTrapListener::getSlowThreshold expects PHPUnit_Framework_TestCase to be passed.
current result:
PHP Fatal error:  Uncaught exception 'RuntimeException' with message 'There should be an error triggered while test run
E_RECOVERABLE_ERROR: Argument 1 passed to JohnKary\PHPUnit\Listener\SpeedTrapListener::getSlowThreshold() must be an instance of PHPUnit_Framework_TestCase, instance of PHPUnit_Framework_TestSuite given, called in /vagrant/vendor/johnkary/phpunit-speedtrap/src/JohnKary/PHPUnit/Listener/SpeedTrapListener.php on line 128 and defined
         at 0  /vagrant/Tests/phpunit/bootstrap.php (line 64) -> getDebugAsString()
         at 1  /vagrant/vendor/johnkary/phpunit-speedtrap/src/JohnKary/PHPUnit/Listener/SpeedTrapListener.php (line 309) -> user_error_handler()
         at 2  /vagrant/vendor/johnkary/phpunit-speedtrap/src/JohnKary/PHPUnit/Listener/SpeedTrapListener.php (line 128) -> getSlowThreshold()
         at 3  /vagrant/vendor/phpunit/phpunit/src/Framework/TestResult.php (line 344) -> endTest()
         at 4  /vagrant/vendor/phpunit/phpunit/src/Framework/TestSuite.php (line 695) -> endTest()
         at 5  /vagrant/vendor/phpunit/phpunit/src/TextUI/Te in /vagrant/Tests/phpunit/bootstrap.php on line 71

expected result:
There was 1 error:

1) TestsPhpunitSpeedtrapTest
exception 'Exception' with message 'I am broken' in /vagrant/Tests/phpunit/speedtrap_test.php:11

Suggestion to fix this:
add if ( $test instanceof \PHPUnit_Framework_TestCase ) { to SpeedTrapListener::endTest
TestCase to reproduce the problem:
class TestsPhpunitSpeedtrapTest extends PHPUnit_Framework_TestCase
{
    public static function setUpBeforeClass()
    {
        throw new Exception("I am broken");
    }

    public function test()
    {
        $this->assertTrue(true);
    }
}

PHPUnit 4.4.5 by Sebastian Bergmann.

PHP 5.4.36-0+deb7u3 (cli) (built: Jan  9 2015 08:07:06)
Copyright (c) 1997-2014 The PHP Group
Zend Engine v2.4.0, Copyright (c) 1998-2014 Zend Technologies
    with XCache v2.0.0, Copyright (c) 2005-2012, by mOo
    with Xdebug v2.2.1, Copyright (c) 2002-2012, by Derick Rethans

$test in the SpeedTrapListener ::endTest method is typecasted to PHPUnit_Framework_Test, so having it look for it being an instance of PHPUnit_Framework_TestCase won't work.
Honestly, the problem here is that your setUpBeforeClass just shouldn't be throwing exceptions. Fix that and everything else works.

Well that is true, but unfortunatly, it is really hard to find the error in setUpBeforeClass (I had to debug deep into SpeedTrapListener), because the Exception message hides all needed information ( which of cause is not the fault fo SpeedTrap)
I just wonder why a PHPUnit TestSuite instance is delivered to endTest ...

Well,
in the described case, PHPUnit_Framework_TestSuite is send to SpeedTrapListener::endTest (no idea why), which  implements PHPUnit_Framework_Test but not PHPUnit_Framework_TestCase which is expected in getSlowThreshold()

I'm having the same problem with a skipped test, this is indeed a real issue.
class SlowApiTest extends PHPUnit_Framework_TestCase
{
    public static function setUpBeforeClass()
    {
        if (!getenv('SKIP_CONDITION')) {
            self::markTestSkipped('foo');
        }
    }

    // ...
}

I've pushed up a fix into #13 for this.

Thank you so much for reporting the issue and the detailed way to recreate it! This issue has been fixed in 160af2e.


Refactor smoke tests so they can run concurrently in loops on multiple memory devices

The current run_smoke.sh script requires famfs.ko to NOT be loaded at start. This refactor should:

Require famfs.ko to be loaded at start
Not unload famfs.ko (that would hose other tests, If any - and the smoke tests currently do this)
Need a separate test that loads and unloads famfs.ko...

This is largely done but needs a bit more testing

The test in run_smoke.sh that greps for famfs in /proc/mounts prevents concurrent runs on /mnt/famfs and /mnt/famfs1.


Driver failed to create swapchain if modesetting driver is being used.

Any XCB/XLIB Vulkan application would fail to create swapchain if X is launched with mode setting driver but not amdgpu's ddx driver.

AMDVLK driver would query the busid of the master fd to ensure we are rendering with the same GPU on the client side.
However, unlike amdgpu ddx driver, mode setting driver did not call drmSetInterfaceVersion to set the unique string of the master fd, which makes the busid queried from kernel is empty.
We would like to raise the question to X to see if it is a proper behave to not calling drmSetInterfaceVersion on the newly opened fd.
At the same time, please stick with the amdgpu's ddx driver in the xserver side, which is our test vehicle.

The issue has been fixed in latest code


Change typedef for MinimumFunction

Change the typedef of MinimumFunction to std::function, which allows binding hyperparameters for soft

minimum functions with std::bind

Add eigen3 as prefix for the Eigen include path to avoid compile errors

I don't have the time to review this until maybe later next week but I would not recommend using std::function for a function that you call very often because it has significant overhead due to object construction etc. and often isn't inlined.
We could instead make the minimum function a template parameter?
Not sure why you want std::bind? Usually using a lambda function is the preferred method because it is more performant.

Your point regarding the performance seems valid.
The issue when using lambda functions is that you want to capture the tuning parameters, but you can not assign a lambda to a function pointer when capturing a value (see e.g. https://stackoverflow.com/questions/28746744/passing-capturing-lambda-as-function-pointer). The only option that remains is to hardcode the tuning parameters in the lambda expression, which does not seem like a satisfying option as soon as you try to evaluate different parameters.
As an example you might want to use exponential weighting which has the signature Scalar exponentialWeighting(const std::vector<Scalar>& values, const Scalar& a, const Scalar& b). In order to be used as a MinimumFunction with the signature Scalar(const std::vector<Scalar>&) std::bind or a lamda with capturing are options to assign values to a and b in a way that does not require hardcoding them.
I'm open to a solution with templates.


'import numba' fails: SystemError: initialization of _internal failed without raising an exception

Traceback (most recent call last):
  File "/usr/ports/science/py-hiphive/x.py", line 5, in <module>
    import numba
  File "/usr/local/lib/python3.9/site-packages/numba/__init__.py", line 42, in <module>
    from numba.np.ufunc import (vectorize, guvectorize, threading_layer,
  File "/usr/local/lib/python3.9/site-packages/numba/np/ufunc/__init__.py", line 3, in <module>
    from numba.np.ufunc.decorators import Vectorize, GUVectorize, vectorize, guvectorize
  File "/usr/local/lib/python3.9/site-packages/numba/np/ufunc/decorators.py", line 3, in <module>
    from numba.np.ufunc import _internal
SystemError: initialization of _internal failed without raising an exception

I couldn't try numba-0.57.1 because of this error:

ImportError: Numba needs NumPy 1.24 or less

and we have numpy-1.25.0 in the ports tree.
numba-0.56.2
FreeBSD 13.2

@yurivict thank you for reporting this. Currently, no released version of Numba supports NumPy 1.25.

We will close this now. Next release of Numba 0.58 will support 1.25.

@esc Do you know when the next release is due?

@esc Do you know when the next release is due?

+1, waiting for the release

+1

An RC2 was published recently: https://numba.discourse.group/t/ann-numba-0-58-0rc1-and-llvmlite-0-41-0rc1/2078/4


numpy version problem

When installing requirements of waveglow, we can see this log:
ERROR: tensorflow 1.14.0 has requirement numpy<2.0,>=1.14.5, but you'll have numpy 1.13.3 which is incompatible.
numpy version in requirements.txt is too low. Is this intended?

Not necessarily. It should work with a higher version as well.


KAFKA-7858: Replace JoinGroup request/response with automated protocol

Prioritizing this migration because we have blocking feature from KIP-345 part 1: https://github.com/apache/kafka/pull/6177
Upgrade join group protocols could ease the process of adding group instance id towards JoinGroupResponse.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@cmccabe @hachikuji Could you guys give this diff a quick r? This would unblock the progress on KIP-345, thanks!

cc @vahidhashemian on this thread since the change is pretty straightforward and requires no background context.

Retest this please

Retest this please

@abbccdda: looks good, thanks!
When processing older responses, I think generation ID needs to default to -1 to match the previous behavior.  This should be changed in JoinGroupResponse.json.

Retest this please

@cmccabe @hachikuji mind taking another look?

@cmccabe Another look when you get time?

LGTM.  Thanks, @abbccdda .

Thanks! @cmccabe


Authentication Error with custom endpoint

first of all thanks for all your great node-modules :)
unfortunately i'm having troubles with a custom endpoint set within the knox-client.
the response of aws says:
<Error>SignatureDoesNotMatch<Message>The request signature we calculated does not match the signature you provided. Check your key and signing method.</Message>

var client = knox.createClient({
     key: *****
    , secret: ****
    , bucket: ****
    , endpoint: 's3-eu-west-1.amazonaws.com'
});

client.get('/').on('response', function(res){
  res.setEncoding('utf8');
  res.on('data', function(chunk){
    console.log(chunk);
  });
}).end();

is there anything wrong with my usage of knox? the accessKey & token works with no custom endpoint set.

Had the same problem, took me a while to find that endpoint in your config should in fact be bucket + '.' + endpoint , where endpoint is the endpoint given by amazon (ex: mybucket.s3-eu-west-1.amazonaws.com).


HTTP operations to remote repositories never timeout

Per GRADLE-2345, repositories that fail to respond to requests can cause Gradle to hang indefinitely during dependency resolution, due to no socket read timeout being applied.
Expected Behavior
Repository requests should time out and cause the build to fail.
Current Behavior
Gradle hangs indefinitely if a request is made, but no response is received.
Context
Builds stuck and hanging indefinitely in CI if there are temporary problems with remote repositories.
Steps to Reproduce (for bugs)
Create a build that has a repository @ localhost:8080, and any dependency. Run nc -l 8080 to accept connections, ensuring no response and run a task that will cause dependencies to resolve. Not that Gradle will hang indefinitely waiting for a response.
Your Environment
N/A

Suggest reconsidering the immediate build-failure result.  Perhaps a gradle option to set the behavior in case of failed repo would be good here.
We have significant inconvenience when I have cached all JAR's needed from a private repo, but still have to be connected to VPN in order to run build.  Perhaps there's a workaround I'm missing.  I tried offline mode and running gradle install, but failure to connect to repo still seems fatal.  Note:  in our case, the private repo is referenced in both buildscript and for project dependencies, as we have our own gradle plugin.

Is there any movement on this issue? Just ran into this due to the fact I left the office.. I would expect that I can configure a timeout and that I can choose to fail immediately or ignore the unreachability.. This makes it impossible to develop without a VPN to our site.. which I really don't need because the maven artifacts are cached locally!

This makes it impossible to develop without a VPN to our site.. which I really don't need because the maven artifacts are cached locally!

In that situation you'd use --offline.

Woah that works! Thanks! /me devs on..

I do agree with that wholeheartedly.. When I work in offline mode, sometimes I need to fetch a few deps from maven or jcenter, next to my on-premise-but-not-reachable-artifactory. Gradle will still try to connect to the unreachable repository, even if it has no business there for the current task at hand.
What I've done to hack around that is: do whatever in --offline mode, see Gradle fail with a bunch of missing (not cached by gradle) dependencies, and then add those to this little gradle build file:
apply plugin: 'java'

dependencies {
  runtime("com.somegroup:some-missing-component:4.4.6")

}

repositories { mavenCentral() }

task getDeps(type: Copy) {
  from sourceSets.main.runtimeClasspath
  into 'runtime/'
}

Then run gradle getDeps with that and back to the original build with --offline.

For us it's our CI servers that spin up clean docker workers that download
the reps with each build.  Not optimised but very repeatable.
If there is a single network glitch the whole thing hangs indefinitely.
A simple network timeout would fix it.
On Thu, 3 Aug 2017 at 6:01 pm, Rubin Simons<EMAIL_ADDRESS>wrote:

I do agree with that wholeheartedly.. When I work in offline mode,
sometimes I need to fetch a few deps from maven or jcenter, next to my
on-premise-but-not-reachable-artifactory. Gradle will still try to connect
to the unreachable repository, even if it has no business there for the
current task at hand.
What I've done to hack around that is: do whatever in --offline mode, see
Gradle fail with a bunch of missing (not cached by gradle) dependencies,
and then add those to this little gradle build file:
apply plugin: 'java'
dependencies {
runtime("com.somegroup:some-missing-component:4.4.6")
}
repositories { mavenCentral() }
task getDeps(type: Copy) {
from sourceSets.main.runtimeClasspath
into 'runtime/'
}
Then run gradle getDeps with that and back to the original build with
--offline.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/gradle/gradle/issues/868#issuecomment-319897856, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAjQ82oxm2eTbBIvq2-fGNlwdFUDH6sBks5sUX5PgaJpZM4KzJ7W
.

--
Matt Doran
CTO and Co-founder
tel: +61 3 8376 8610
web: www.papercut.com

Some points to consider:

we need to blacklist the repo and stop any other queued up requests to it
how long do we blacklist it? (e.g. build, build session ?)
do we fail resolution or try to continue with the next repo? is this configurable?
failures like these should be visible in build scans
we should open a more general epic about timeouts for any network activity

The simplest increment in my opinion would be: Fail resolution, blacklist for the duration of a build, cancel outstanding parallel requests to that repo.

Initial implementation will blacklist a timed out repository for the duration of the current build. Queued parallel requests in the build operation queue are not canceled. Further, un-queued requests are skipped.
Created an epic for further improvements: https://github.com/gradle/gradle/issues/2779

Reopened as other conditions need to be taken under consideration e.g. https://github.com/gradle/gradle/issues/2853.


fix(modal): allow element in closeText prop

This addresses #224 for one component: Modal. I decided to do this now because it started to cause some extra pain for me in SFE.

Coverage remained the same at 99.342% when pulling ca7fe50425a760f9cdf0b53e60cd2674ea14faa0 on thallada/modal-element-closetext into bd67902cfb06d9f85cedadd873c85318c4c52172 on master.

Coverage remained the same at 99.342% when pulling ca7fe50425a760f9cdf0b53e60cd2674ea14faa0 on thallada/modal-element-closetext into bd67902cfb06d9f85cedadd873c85318c4c52172 on master.

I don't know if this is the pain point you mentioned, Tyler, but this will help us internationalize the closeText from within studio-frontend, so I just want to mention that here so that someone remembers to do that once this merges.

:tada: This PR is included in version 3.0.5 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Change blob datatype to varchar when saving Oauth2Authorization to the database

Few issues were logged for JdbcOAuth2AuthorizationService as it does not work out of the box with PostgreSQL. Although customization is possible, we should change the schema from blob to varchar OR another standard SQL datatype that will work by default with PostgreSQL and most other databases

👍🏻
Kindly address this issue, have tries customizing it, but not able to get the result as expected, tried with all suggested solutions.
Changing from blob to VARCHAR would make up for most standard sql databases.

hi @jgrandja. As we'll drop blob datatype for the various code values following constructor
public JdbcOAuth2AuthorizationService(JdbcOperations jdbcOperations,
			RegisteredClientRepository registeredClientRepository, LobHandler lobHandler)

should be flagged as deprecated? (as the LobHandler is not needed anymore when persisting or fetching the data)

hi @jgrandja. Would you prefer to not use the LobHandler at all? I think we should still use it and write the values using setClobAsString and getClobAsString to read the data.  If wrapasLob is false (which is by default) it will delegate to getString and setString methods. If it's true, it will try to set a clob.
In this way, the schema can be changed to use something else than varchar if needed.

@ovidiupopa91 It doesn't look like Postgres supports CLOB? If wrapasLob is false, will it work for Postgres?
I don't mind keeping LobHandler, I just want to ensure the solution works for Postgres by default.

@jgrandja  I did check and it works by default with Postgress when token values are defined as varchar(1000) in the oauth2-authorization-schema.
The reason why I think it's a good idea to keep the LobHandler is that it will make life easier in extending the JdbcOauth2AuthozarionService if a DB that supports clob is used.
The only thing that needs to be done is to set wrapAsLob to true and it will try to insert a clob

@ovidiupopa91

the registration_access_token cannot be deserialized when calling the client configuration endpoint

Please open a new issue for this fix. Thanks for catching that!
Just a heads up that I'm on PTO Nov 19-24 (inclusive) and have a couple of priority issues to resolve this week. I'll try to review this week but it may be when I return from PTO.

495 raised to track the issue.

A small question.. You say that it should work out of the box, but when I use the jdbc client repo and authorization service, I get an exception telling that a table is not created, and I need to create that first manually.. Should I define some missing property to force the app to create the tables automatically?


MA - Data issues and wrong receiver

Problem statement
The user's file (prime-20221109145115) was received with special characters within some of the patient names. Also, they noticed several cases that were not Massachusetts residents, that should go to the proper state.
What you need to know
Email sent from user, Janice Grantner (janice.Grantner@mass.gov):

Good Afternoon,
We are receiving these reports from Report Stream to the Massachusetts Department of Public Health. The facility that is sending them in CDC Prime-Atlanta, Georgia (Dekalb).

Can you please review the size of these Prime files? We came across a file yesterday that was too big which needed to be split into multiple files. Yesterday file size was 5, 550KB (2096 messages) and we can only accept files up to 2.0MB. I have fixed and manually upload this file to our ELR Portal. (BX: this bullet point is being handled under Issue # 7343)

A max file size constraint of 2.0 MB is imposed for HL7 251 messaging. We strongly recommend that you send <=400 messages in your batch. Multiple batch files can be transmitted each day based on reporting volume. (BX: this bullet point is being handled under Issue # 7343)

Additionally, this file (prime-20221109145115) was received with special characters within some of the patient names. Can you please review this issue? Also, we noticed several cases that were not Massachusetts residents. They should not be sent to us and should go the proper state."

User's name is Janice Grantner
<EMAIL_ADDRESS>Acceptance criteria

[ ] Root cause is identified
[ ] Resolution has been identified
[ ] User has been notified of root cause/resolution

To do

[ ] Review user's file (prime-20221109145115) to investigate the data issues
[ ] Contact user with root cause/problem resolution

Currently, we route results to MA based on the Ordering Facility State or Patient State. It sounds like MA only wants results where Patient State = MA. Since the majority of states want both Ordering Facility State or Patient State I think we should confirm that with MA before editing the filtering. @BerniXiongA6 Can you reach out to MA on this?

Oh also, I downloaded the file in question. I couldn't find any messages with special characters in the patient names. Can we see if MA con provide accession numbers with examples?

Yes, I can reach out to MA on this @brick-green -- I'll update the ticket with that progress. Thanks!

BX emailed MA on Dec. 6, 2022:

Hi Janice,
Nice to meet you, I'm Berni, the Delivery Manager for ReportStream's Onboarding & Operations team (previously in this role was Adrian Brewster). Our team has looked into this matter and here's the feedback I got from our engineer in response to your questions/issues raised:
Currently, we route results to MA based on the Ordering Facility State or Patient State. If MA only wants results where Patient State = MA, we can make an edit to our filtering. Please confirm this is indeed how you'd like to proceed. (We've experienced that the majority of states want both Ordering Facility State or Patient State.)
As for the file in question, after downloading it, our engineer couldn't find any messages with special characters in the patient names. Could you provide us accession numbers with examples?
Please feel free to reply to all to this email.
Thanks,
Berni
P.S. I've also copied in our Sarah White's replacement, Brandon Canniff (ReportStream Onboarding & Operations Product Manager), and Brick Green (ReportStream Onboarding & Operations Technical Lead).

@BerniXiongA6 I don't understand this statement:
"Yes we want both of these but only if the patient state is in MA"
I don't think Janice understood what was being asked. I think MA only wants the routing to look at patient state but don't feel 100% clear on that. What do you think?

@brandonnava to reach out to MA

@brandonnava do we have any updates on this?

Followed up with Janice. She says the issue hasn't reoccured so go ahead and close


chore(git): Setup git hooks and a few useful dev commands as scripts

Including commit message valid in preparation for testing, semantic-release and future new features.

Thanks, but:

I don’t like angular-style commit messages;
I like semver and dislike what you call “exact”;
git-issues looks cool, but there’s no need to have it in this repo. If I’d want to use it, I’d install it globally;
I know how to commit stuff with Git.

I understand you’d like to dogfeed you projects, but I’m not interested.

Would you reconsider this for the future work purposes? I don't doubt that you know how to commit code, but can you guarantee never to forget to run unit tests on commit? Or that no one uses "2.." in a dependency? You have not setup ".npmrc" for example with save-exact so this will happen at some point.
Also, if you like the semantic versioning, then semantic-release works very well if your commit messages are really strictly formatted, at least the subject lines. This is not about angular-style, it is just a cool style, we can enforce something else.
I don't think this is about dog feeding my projects, I just liked man-n in principle and would like to build upon it, rather than writing my own. Of course I can just use npm docs <package> or npm home <package>, but your module could be used to show specific parts of readme really quickly. Like man-n lodash pick

Thanks for clarifying, @bahmutov! Sorry about the misunderstand about dog-feeding. That was overly presumptuous of me.
I cannot prevent someone screwing up dependencies, of course. However, the chance of that is minimal in my opinion. The pain of having to change the package.json manifest for every small bug release makes it not worth it, in my experience. (noteworthy: I’m the author of all dependencies.)
If you like man-n (first of all: cool!) I suggest to first build upon it, updates and fixes are very welcome. Most importantly, they’re way more needed than safeguarding this very small project against possible contribution mishaps (I pride myself on keen eyes; scrutinising and amending any contributions).

No worries. man
I agree with the pain of releasing small fixes - this is why setting up semantic-release (which needs formatted commit messages in my opinion) would be so helpful. I am just laying ground work for future feature submission. I really like the demo of semantic release shown here https://egghead.io/lessons/javascript-how-to-write-a-javascript-library-automating-releases-with-semantic-release - once setup it will take the decision time, package update overhead away.
I could add a feature for displaying a portion of the readme file first, and submit again,

:+1:

I wrote my own manpm https://github.com/bahmutov/manpm module for this - so no worries or code modifications

Looks like great work, @bahmutov!


Merriweather "fi" ligature renders as "i"

Looks like Google fonts updated Merriweather in January, and now all Casper-based themes look like this in Chrome, Safari, and Firefox:

Ligatures like "fi" => "i"
https://www.google.com/fonts/specimen/Merriweather
Turning off the liga feature fixes it, but not sure if this is a Merriweather issue, or outstanding tech debt in Casper styles.

I'm impressed nybblr. I just noticed this (about hour ago) on my blog but had not yet worked out a fix. It renders fine on my Windows Phone and in Microsoft Edge on my desktop. Presumably the working browsers don't support ligatures.
Also it highlights the risks of using external fonts. Imagine if somebody changed the letters around for fun and it made your text all sweary and gibberish!

I also noticed this just an hour or so ago! @nybblr you mention turning off ligais a workaround, but I could not work out how to do this. I tried disabling the font-feature-settings: 'liga' 1, 'onum' 1, 'kern' 1; CSS rules, but this doesn't appear to have any effect. I temporarily switched themes in the end.
FYI I have used the Ghost demo page as a test of this. There are a couple of examples ("specific" and "defined") under the code section the show the problem.

I just dropped some styles into my Code Injections => Blog Header:
<style>p,ul,ol,dl{
-webkit-font-feature-settings: 'liga' 0, 'onum' 1, 'kern' 1;
-moz-font-feature-settings: 'liga' 0, 'onum' 1, 'kern' 1;
-o-font-feature-settings: 'liga' 0, 'onum' 1, 'kern' 1;
}</style>

Odd, that doesn't work at all for me. Not sure why that is, but thanks very much for the help!

Great catch!

Yep - hoping that Google resolve this pronto, but if not then we'll ship an update

According to Google a fix for this will be pushed tomorrow: https://github.com/google/fonts/issues/8

The update to merriweather was made in advance of the Firefox 44 launch on Tuesday that will mean the old files will just stop working.
However, there is 1 bug with fi/fl ligatures (which will be fixed monday morning PST) and an issue with the new design being a little darker than before especially on Macs.
You can turn ligatures off with CSS to work around this until then:
-webkit-font-feature-settings: 'liga' 0, 'onum' 1, 'kern' 1;
-moz-font-feature-settings: 'liga' 0, 'onum' 1, 'kern' 1;
-o-font-feature-settings: 'liga' 0, 'onum' 1, 'kern' 1;
font-feature-settings: 'liga' 0, 'onum' 1, 'kern' 1;

Google's published the fix

The fix is now pushed all the way through the Fonts API :)


feat: stylus support

I'm submitting a...

[ ] Bug Fix
[x] Feature
[ ] Other (Refactoring, Added tests, Documentation, ...)

Checklist

[x] Commit Messages follow the Conventional Commits pattern, see current .vcmrc
[x] Tests for the changes have been added

Description
Added support for stylus preprocessor.
Tests provided.
Does this PR introduce a breaking change?

[ ] Yes
[x] No

Update PR
Added more paths for stylus resolver (node_modules, current file path)
Added tests for resolving relative urls

Looks good!
I squash the change so that it's easier to track back in Git history the change introducing the stylus feature.


Update deployment-standalone.yaml

Delete the redundant MONGODB_ENABLE_IPV6 setting

What this PR does / why we need it:
Which issue this PR fixes
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

fixes #

Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md

Hi @frankruizhi
Please note that you need to bump the patch version in the Chart.yaml whenever you modify the chart as you did. Apart from that, please note that you need to sign-off you commits in order to be able to contribute to the project.
On the other hand, could you explain why are you removing the possibility of configuring that env. variable? I don't see any duplicates in the deployment definition.


Improving the UI of sessions details

The current UI of app is pretty but I feel like red color is used a lot.

As the accent color and primary color of the app, both are shades of red so the floating action button should have a distinct background.
There is no image in the upper part here so the toolbar better be in shape.
The parts of the content can be divided by cards as the speakers could be multiple they should look more clickable. The flat layout without elevation doesn't feel like it.

It would be great if we could make the color of FABs a little contrasting from red so they are more visible as in the practice. For now I didn't change it, just wanted to know how you feel about it.
Before:

After:

@the-dagger Review this issue please. I made a pull request also.

Hey @heysadboy, thanks for the issue.
But my suggestion is to send a PR for a UI enhancement/ Feature implementation only after there has been a discussion on that issue.
Regarding this issue, I don't think that the sessionDetail needs a UI refresh because that collapsingToolbar is a placeholder and any image provided by the speaker for the event will be placed there.
We can probably make enhancements similar to these to once the app's UI looks mature enough.
Cheers.

@the-dagger I understand. Should we delete this issue? Main motive was just due to wide toolbar, which is not an issue after all. I'll look for other non UI issues. Thanks for reviewing.


microshift: Drop RH internal 'brew' requirement

microshift is officially released in RH repos, and microshift.sh already requires a subscription, so we can use yum download instead of brew download-build.
I've checked that setting MICROSHIFT_NVR works for 4.13 releases.

/cherry-pick release-4.14

Once this is merged I will work on https://github.com/openshift/release/pull/38200 one again.


IVC: Add selector columns

Before: ivc_circuit was building all /witness/ wires, but /constraints/, e.g. c_{b0,i}, were available for every block separately. This means c_{b0,i} for block 0 would not work on rows of block 1.
Now:

There are selectors for each block.
Every constraint is now working for the /whole circuit/, since it's now multiplied by selector: sel0 * c_{b0,i}.
Completeness test is added with lookups disabled.

Offtop:

I added the ID lens because I wanted to generalise circuit generator to work for two tables simultaneously. This proved to /not/ be useful. But the ID lens is useful I think so I keep it.

Next step:

Reduce stack usage. It overflows if stack is default 128KB, but fine with 2MB. Done in next PR https://github.com/o1-labs/proof-systems/pull/2247.

Starting having a look now.


Derby <IP_ADDRESS>

Tina, can you plz double check if ID mapping works for you too? Derby 10.14 is the most recent version compatible with Java 8: https://db.apache.org/derby/derby_downloads.html
It fixes for me loading the Derby file @DeniseSl22 had trouble with loading.

Are these OSGi bundles? I get OSGi errors when starting PathVisio
org.eclipse.osgi.service.pluginconversion.PluginConversionException: Could not find a META-INF/MANIFEST.MF, plugin.xml or a fragment.xml

Oh, shit... I guess not.

should I wait for this for the point release or is it fine to continue?

I had a check, and looking from DERBY-3730 I would say they are meant to be OSGI-compatible.
OK, I'll download the binary distribution. There the derby.jar certainly does have a MANIFEST:
$ jar tvf derby.jar | grep MAN
  1419 Fri Apr 06 18:10:12 CEST 2018 META-INF/MANIFEST.MF

New PR with jars from the binary distribution instead of Maven Central (should not matter; but apparently it does): https://github.com/PathVisio/pathvisio/pull/130


When using ObservableDictionary.ToNotifyCollectionChanged in WinUI 3, the application crashes

Convert ObservableDictionary to INotifyCollectionChangedSynchronizedViewList
Bind it to ListView for display
After adding an item to the dictionary, the application exits without throwing any exceptions

From SynchronizedViewList.cs line 852
↓
To NotifyCollectionChangedEventHandler.cs line 62, where the application exits.
Sample project: https://github.com/dalian-spacekey/ObservableCollections/tree/winui3_dictionary

Thank you.
For Dictionary, I have to modify the StartingIndex of the notification event.
I had corrected it for Filtered and the other events, but somehow only omitted Add for Nonfiltered!
I have released a fix in 3.0.4.


Response is not set for the agent

I tried creating intents and entities according to the instructions, the intents, entities and other related things are created but the response for the intent is not created and there are no errors. Every time I run the code, everything works fine but the response is not created

Can you please give a code example and the output received? It is hard to diagnose what is going wrong without more data. Thanks.

Kindly go through the code and result and correct me where I am wrong. Thanks in advance

Looks like the intents are created. What happens when you run a DetectIntent Request against your created intents?
The struct in that for pizzaResult is the intents response.


LTI Deep-Linking

This PR adds a new LTI tool, deeplink. Which enables users to easily add opencast content to their LMS.
This implementation was originally done by @ppettit , but when we had the LTI module rewritten to react this was no longer compatible. This fixes this by implementing this feature within the new LTI react module.
We tested this against our own LMS ( brightspace ), but behaviour might vary with other LMS'es.

We'll have a look at the style errors, we're not getting those locally for some reason ...

@kristofkeppens please ducument this LTI tool in documentation

@wsmirnow forgot about that one, fixed now.

Per discussion in the technical meeting today, we're going to close this for now.  When you're ready please feel free to refile this!

Hi @kristofkeppens, my site relies on an early version of your LTI Deeplinking OC implementation. We are upgrading and need to adapt it to the current stable OC. I'm heavily leaning on your pull to help guide the way. If my work is general enough, I will make a pull onto your feature/lti-deeplinking branch.

Hi @karendolan , if it helps I can update it to our latest version ( for opencast 11.x ).

@karendolan I've updated the branch ( https://github.com/mm-dict/opencast/tree/feature/lti-deeplinking ), should be working, if anything isn't working have a look at our https://github.com/mm-dict/opencast/tree/r/11.x-ugent branch, but this contains some other things as well.


doc: translation src/content/learn/synchronizing-with-effects.md

Closes #389
Description
Translate the src/content/learn/synchronizing-with-effects.md page.
Page URL: https://id.react.dev/learn/synchronizing-with-effects

Superseded with #655.


Implement --polyfill-node/ config.polyfill_node

This commit adds --polyfill-node as a cli argument and polyfill_node as a config field. It uses https://github.com/remorses/esbuild-plugins / https://github.com/ionic-team/rollup-plugin-node-polyfills/ for the polyfills. I also added a warning for the tradeoffs whenever this config is used. We may want better polyfills in the future, and maybe even better messaging if we can recognise popular libraries and suggest replacements.


Strange marks in tabline

Hi
I installed the plugin and I am using default settings.
However, when I open buffer I see strange marks like 'Pi', please see the picture below

Is it normal? Can I disable it?

basically when I open new file it seems like on the left is \Xi and on the right \Gamma Greek letters


Apply fixes from StyleCI

This pull request applies code style fixes from an analysis carried out by StyleCI.

For more information, click here.

Ik ben tot 27 augustus afwezig.  Stuur voor urgente zaken een sms naar 06-13075686.
Groeten,
Gerben

Codecov Report

Merging #133 into cli-exception will not change coverage.
The diff coverage is 0%.

@@              Coverage Diff               @@
##             cli-exception   #133   +/-   ##
==============================================
  Coverage                0%     0%
  Complexity              70     70
==============================================
  Files                    9      9
  Lines                  224    224
==============================================
  Misses                 224    224

Impacted Files
Coverage Δ
Complexity Δ

src/Command/Serve.php
0% <ø> (ø)
12 <0> (ø)
:arrow_down:

src/Command/Build.php
0% <ø> (ø)
4 <0> (ø)
:arrow_down:

src/Command/AbstractCommand.php
0% <0%> (ø)
22 <0> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53ba337...7678587. Read the comment docs.

Pull Request Test Coverage Report for Build 664

0 of 1 (0.0%)  changed or added relevant line in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage remained the same at 0.0%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/Command/AbstractCommand.php
0
1
0.0%

Files with Coverage Reduction
New Missed Lines
%

src/Command/Serve.php
1
0.0%

Totals

Change from base Build 662:
0.0%

Covered Lines:
0

Relevant Lines:
210

💛  - Coveralls


Pricing clarification or reference needed on document for managed nat gateway / user assigned NAT

Please add clarification in regards to pricing for Managed NAT Gateway and user assigned NAT so customers can have some values as reference.
https://azure.microsoft.com/en-us/pricing/details/virtual-network/
https://azure.microsoft.com/en-us/pricing/details/load-balancer/
https://azure.microsoft.com/en-us/pricing/details/ip-addresses/
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e3ea12e7-6e6d-cfa1-b094-2f33e2e7b64b
Version Independent ID: cd0f7701-6a0a-425c-1da2-29683db39ef9
Content: Managed NAT Gateway (preview) - Azure Kubernetes Service
Content Source: articles/aks/nat-gateway.md
Service: container-service
GitHub Login: @zr-msft
Microsoft Alias: juda

@porrascarlos802018
Thanks for your feedback! We will investigate and update as appropriate.

@porrascarlos802018
Thanks for the feedback! I have assigned the issue to content author to check and update the document as appropriate.

@zr-msft
Can you please check and add your comments on this doc update request as applicable.

@zr-msft,
There is one more doc enhancement request by the same customer, requesting clarification in the document, please review
I am linking the other duplicate issue here for your reference #85708

Thank you for your feedback. We don't document pricing in the product content. Please refer to the Pricing pages for information.
#please-close


November release highlights for TypeScript

November release notes for JavaScript.
Please suggest changes with your release notes.
If you're looking for inspiration:

Highlight guidelines: https://azure.github.io/azure-sdk/policies_releasenotes.html
September's PR: https://github.com/Azure/azure-sdk/pull/1750
October's PR: https://github.com/Azure/azure-sdk/pull/1878

We previously had beta releases for Storage Blob, File, DataLake. And now we are doing a GA release for these three and also for Queue. I am doing it correctly by putting Blob, File, Datalake under the "GA" section while Queue under the "Updates" section?

Yes! That is correct.

Also should the highlight for GA pacakges include what's already stated in the beta release?

Yes! However, we show the difference in more detail in tha changelogs, so you may consider adding more information there. An example on Identity: https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/identity/identity/CHANGELOG.md#changes-since-11

Closing on favor of: https://github.com/Azure/azure-sdk/pull/2029


Vulnerability roundup 107: envoy-1.16.4: 3 advisories [8.6]

search, files

[ ] CVE-2021-39162 CVSSv3=8.6 (nixos-21.05)
[ ] CVE-2021-39206 CVSSv3=8.6 (nixos-21.05)
[ ] CVE-2021-39204 CVSSv3=7.5 (nixos-21.05)

CVE details
CVE-2021-39162
Pomerium is an open source identity-aware access proxy. Envoy, which Pomerium is based on, can abnormally terminate if an H/2 GOAWAY and SETTINGS frame are received in the same IO event. This can lead to a DoS in the presence of untrusted upstream servers. 0.15.1 contains an upgraded envoy binary with this vulnerability patched. If only trusted upstreams are configured, there is not substantial risk of this condition being triggered.
CVE-2021-39206
Pomerium is an open source identity-aware access proxy. Envoy, which Pomerium is based on, contains two authorization related vulnerabilities CVE-2021-32777 and CVE-2021-32779. This may lead to incorrect routing or authorization policy decisions. With specially crafted requests, incorrect authorization or routing decisions may be made by Pomerium. Pomerium v0.14.8 and v0.15.1 contain an upgraded envoy binary with these vulnerabilities patched. This issue can only be triggered when using path prefix based policy. Removing any such policies should provide mitigation.
CVE-2021-39204
Pomerium is an open source identity-aware access proxy. Envoy, which Pomerium is based on, incorrectly handles resetting of HTTP/2 streams with excessive complexity. This can lead to high CPU utilization when a large number of streams are reset. This can result in a DoS condition. Pomerium versions 0.14.8 and 0.15.1 contain an upgraded envoy binary with this vulnerability patched.

Scanned versions: nixos-21.05: 3b1789322fc.
Cc @lukegb

NixOS 21.05 is EOL.


Font Request: SN Pro

Font Name
SN Pro
Link to font source
https://github.com/supernotes/sn-pro
Link to font license
https://github.com/supernotes/sn-pro/blob/main/OFL.txt
Additional context
No response

Closed in #69.


0.26.1 stops importing some packages

Describe the bug
0.25.8 works well
import { read } from 'fs-jetpack'
Turns out to be empty when doing import destructuring.
import fs from 'fs-jetpack'
Works fine.
[FAILED] __vite_ssr_import_2__.read is not a function
[FAILED] __vite_ssr_import_2__.read is not a function
[FAILED] __vite_ssr_import_2__.read is not a function

TypeError: read is not a function
Reproduction
https://stackblitz.com/edit/vitest-dev-vitest-gv9cw4
System Info
System:
    OS: macOS 13.0
    CPU: (10) arm64 Apple M1 Pro
    Memory: 333.16 MB / 16.00 GB
    Shell: 3.5.1 - /opt/homebrew/bin/fish
  Binaries:
    Node: 16.17.0 - ~/Library/Caches/fnm_multishells/25612_1671194505564/bin/node
    Yarn: 1.22.19 - ~/Library/Caches/fnm_multishells/25612_1671194505564/bin/yarn
    npm: 8.19.3 - ~/Work/linktink/node_modules/.bin/npm
  Browsers:
    Chrome: 108.0.5359.124
    Firefox: 106.0.5
    Safari: 16.1
    Safari Technology Preview: 16.4
  npmPackages:
    vitest: 0.25.8 => 0.26.1

Used Package Manager
npm
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

interopDefault: true, from https://github.com/vitest-dev/vitest/issues/2531 fixes it, but I've assumed it was fixed in 0.26.0

Same with mkdirp: sync is not a function

This is expected behaviour since 0.26.0. fs-jetpack doesn't support named exports in Node environment. (you can see this by importing import * as fs from fs-jetpack - there are no named exports). If you have a Node bundler that fixes this, you can enable interopDefault: true yourself, as described in release notes: https://github.com/vitest-dev/vitest/releases/tag/v0.26.0. The error you will see when using named export:
file:///home/projects/vitest-dev-vitest-mjaqu6/node.mjs:1
import { read } from 'fs-jetpack';
         ^^^^
SyntaxError: Named export 'read' not found. The requested module 'fs-jetpack' is a CommonJS module, which may not support all module.exports as named exports.
CommonJS modules can always be imported via the default export, for example using:

import pkg from 'fs-jetpack';
const { read } = pkg;

    at _instantiate (https://vitestdevvitestmjaqu6-vlyf.w-corp.staticblitz.com/blitz.6ebe18b1e1db1833797e3e4eb6ff802c375ee61b.js:6:986476)
    at <anonymous> (<anonymous>)

We can probably improve the default handling, if you have any suggestions. The decisions was made to drop auto interop in Node because this code will not actually work with native node.

I'm having similar issues with @reduxjs/toolkit and next-auth packages. The following imports fail:
import {createAsyncThunk} from '@reduxjs/toolkit';

// and

import CredentialsProvider from 'next-auth/providers/credentials';

Vitest fails with:
TypeError: default is not a function
 ❯ pages/api/auth/[...nextauth].page.ts:74:3
     72|  },
     73|  providers: [
     74|   CredentialsProvider({
       |   ^
     75|    credentials: {
     76|     email: {
 ❯ utils/api/middleware/authentication.ts:1:31
 ❯ utils/api/middleware/index.ts:3:31

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[1/75]⎯

 FAIL  pages/api/report/[reportId]/build/GET.test.ts [ pages/api/report/[reportId]/build/GET.test.ts ]
 FAIL  pages/api/report/[reportId]/build/index.test.ts [ pages/api/report/[reportId]/build/index.test.ts ]
TypeError: createAsyncThunk is not a function
 ❯ Module.createAPIAction [as default] utils/redux/createAPIAction.ts:17:9
     15|  modifyResponse?: (response: Record<string, unknown>, payload: Input) …
     16| ) => {
     17|  return createAsyncThunk<Return, Input, {
       |         ^
     18|   dispatch: DispatchType,
     19|   rejectedMeta: ErrorReturnType,
 ❯ store/componentsActions.ts:41:23

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[2/75]⎯

I checked and both of those packages have the appropriate exports (from what I can tell). Rolling back to vitest 0.25.8 makes the problem go away.
I'm not sure what interopDefault is. I can't find any docs for it. Is that a vite setting?

I'm not sure what interopDefault is. I can't find any docs for it. Is that a vite setting?

https://vitest.dev/config/#deps-interopdefault

I as having this issue with lodash and this import:
import { get } from 'lodash'

adding deps: {       interopDefault: true,     },
fixed it. Isn't it high time that lodash exports ESM modules @jdalton ?

I was having this issue with lodash and this import:

import { get } from 'lodash'

adding `deps: {
  interopDefault: true,

},`

fixed it. Isn't it high time that lodash exports ESM modules @jdalton ?

I think there is lodash-es module for this?

yes, lodash-es fixes it and there is no need for interopDefault: true

A bit confusing though that according to the docs interopDefault defaults to true but this doesn't seem to be the case.
In fact, configDefaults doesn't contain deps at all...

A bit confusing though that according to the docs interopDefault defaults to true but that doesn't seem to be the case.

This is error in Docs, it will be fixed.

In fact, configDefaults doesn't contain deps at all...

It cannot be on configDefaults, because default is dynamic and depends on environment.


chore: bump to 1.6.3

Updates the Deno version to 1.6.3.

Thanks @LukeChannings , apologies for not seeing this until now. (Please feel free to @ me, as otherwise github doesn't seem to notify me / I don't have it set up correctly?)
Merging and will push this and then 1.7.0.

Thanks @LukeChannings , apologies for not seeing this until now. (Please feel free to @ me, as otherwise github doesn't seem to notify me / I don't have it set up correctly?)
Merging and will push this and then 1.7.0.


Add configurable contact email near "compacted/delete" strategy field.

Add configurable contact email near compacted delete strategy field.
It should be specific email address instead of just check the legal department of your organization

Log compacted event types MUST NOT contain personally identifiable information in accordance to GDPR. If you plan to store personal user data permanently in Log compacted event types, then please get in touch with  to get a custom GDPR compliant solution built for your use case.

i would suggest<EMAIL_ADDRESS>to be the email address. If you think this email address is fine then carine can get it from tech stop.

In the end, it is just a support request, so we will use just a standard SUPPORT_URL

Done


rancher/external-dns using deactivated API for DNSimple provider

Adding a dnsimple 'stack' from the community catalog with my newly created DNSimple account, fails to deploy the stack.
The error messages is time="2017-10-18T23:29:00Z" level=fatal msg="Failed to get provider 'dnsimple': Failed to list zones: GET https://api.dnsimple.com/v1/domains: 429 Too many requests"
Researching the error leads me to this page: https://developer.dnsimple.com/v1/ which states: "DNSimple API v1 is deprecated and in maintenance-only. API v1 will be discontinued on October 1st, 2017."
I suspect new accounts are blocked from using v1 API.
Can this DNS Provider be upgraded to use version 2 of their API?
I have also tested rancher/external-dns v.0.7.6 and it fails with the same error
Steps to Reproduce:
Sign up at DNSimple
Deploy https://github.com/rancher/community-catalog/tree/master/templates/dnsimple
Watch it fail to deploy.
Results:
Fail to deploy Stack and Container

Sorry not a developer but from what I can determine in:
https://github.com/rancher/external-dns/blob/master/providers/dnsimple/dnsimple.go
line 12: api "github.com/weppos/go-dnsimple/dnsimple"
weppos/go-dnsimple/dnsimple is an unmaintained fork of 'https://github.com/dnsimple/dnsimple-go' perhaps you could use the DNS Providers library instead of the fork?

Hi there, any chance, that the creators of this service take a look at it?

This issue may be not solved, because rancher moves completly to kubernetes and rancher is something like an UI for Kubernetes.. External DNS services need to be completly rewritten to work with the kubernetes API's.

There is a Kubernetes Helm for external dns which also supports DNSimple, so the moment everything around Helm works 100% with rancher we might use the dns feature like this.

From: Benjamin<EMAIL_ADDRESS>Sent: Friday, March 9, 2018 11:20:58 AM
To: rancher/rancher
Cc: JZinkl; Comment
Subject: Re: [rancher/rancher] rancher/external-dns using deactivated API for DNSimple provider (#10167)
This issue may be not solved, because rancher moves completly to kubernetes and rancher is something like an UI for Kubernetes.. External DNS services need to be completly rewritten to work with the kubernetes API's.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/rancher/rancher/issues/10167#issuecomment-371772951, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AHLXHknkKRAXzUOY4XSETPL841r1VcHaks5tcleJgaJpZM4P-hGw.

Please let us know in a comment if you can still reproduce the issue, and we'll reopen it


[-] Increase curl timeout from 5 to 10 sec

Increase timeout to 10 sec because request takes longer than 5 seconds sometimes.
Reduce attempts count to 2 so it takes 20 seconds in the worst case

Thanks @vmsrg !


Restricted area function

One of the important functions of PX4 controlled machine is Flight restriction, we can't let vehicle flight in restricted area,it's Forbidden and unsafe.So, can we add restricted area function for PX4?

@LorenzMeier

https://pixhawk.ethz.ch/mavlink/#SAFETY_SET_ALLOWED_AREA

There's a plugin on (mavros)[] to set it: https://github.com/mavlink/mavros/blob/master/mavros/src/plugins/safety_area.cpp
But I don't think this is implemented on Firmware yet. In any case, this is geofencing related.

yes, we can add airport coordinates(to ROMFS?) to set flight restriction area.

The current geofence system could be extended to do this. How would you want to specify the forbidden area? How many zones would you need to define?

657 forbidden area(large/medium airport ,15913 bytes) i collected, and store in ROMFS,

So basically https://github.com/mavlink/mavros/pull/689 defines allowed areas, as a geofence. Probably we can consider that everything out of that area is a no-flight zone @liang-tang? Or maybe we can define a new Mavlink message to restricted flight areas - could be synced automatically to the online restricted UAV flight areas data.

I'm closing this since we have a beta airman integration as PR up now.


Replace lock in ActorCell with Dispatch.Semaphore

According to https://github.com/ReactiveCocoa/ReactiveCocoa/issues/2619, spin lock has the best performance in Swift, but it is only available in Mac and it may uses too much CPU.
The second best one is Semaphore. We can replace each ActorCell's lock with this.

I have been studying locking recently. This article is especially interesting (Mutexes and Closure Capture). You can definitely get some improvement over NSLock in some cases. The disadvantage with spin lock is that it will eat CPU if there is actually contention for the lock.
The places in which the lock is used in Theater are just during the creation/destruction of actors, so that is not typically on the hot path. A quick test does not show much change with a few different implementations of that sync method.

That article is very nice. It seems our current sync() method inside ActorCell will introduce closure capture. And I found NSLock() has the synchronize method https://github.com/apple/swift-corelibs-foundation/blob/master/Foundation/NSLock.swift#L60
So a quick fix is to the NSLock's synchronize() method instead of our own sync() method.
Regarding the lock itself, right now it is not in hot patch. But I plan to add an parallel executor, which will use the lock to protect the mailbox. Then all the message deliver and execution will use the lock. At that time, we can test the Semaphore VS NSLock.


include requirements.txt in requirements-dev.txt

I also saw that scipy was on the requirements.txt but from my point of view it should be in requirements-dev.txt no ?

LGTM


Fixes and improvements to building the Docker image

Please have a look at the individual commit messages for the details.

This change is

Merging without another review as compared to the previous approval the PR was just rebased.


can not write csv data to influxdb2.0, get a error message that data type 'float' is not supported.

The version of influxdb is influxdb_2.0.0-beta.16_linux_amd64, the version of system is CentOS Linux release 7.7.1908 (Core).
I follow the guide Write CSV data to InfluxDB from https://v2.docs.influxdata.com/v2.0/write-data/developer-tools/csv/.
The example.csv is
#datatype measurement,tag,float,dateTime:RFC3339
m,host,used_percent,time
mem,host1,64.23,2020-01-01T00:00:00Z
mem,host2,72.01,2020-01-01T00:00:00Z
mem,host1,62.61,2020-01-01T00:00:10Z
mem,host2,72.98,2020-01-01T00:00:10Z
mem,host1,63.40,2020-01-01T00:00:20Z
mem,host2,73.77,2020-01-01T00:00:20Z

The write command is
/influx write -o bbb -b ccc -f example2.csv -t hvHv0-X1wzouUe-qU-1IBInE5xU9DNJpxElnpC0GK4MxDraV5wvS_Qo9GqLinqnDGh3t-RShOALy-CdIMmNFFQ== --host http://localhost:9999
Then I got the Error.
Error: Failed to write data: line 3: column 'used_percent': data type 'float' is not supported.
See 'influx write -h' for help

Below is the example.csv.
example.csv.txt
However, if I change the data type from 'float' to 'string'. It works. I can write the data into influxdb. Why is the 'float' not supported?
./influx write -o bbb -b ccc -f example.csv -t hvHv0-X1wzouUe-qU-1IBInE5xU9DNJpxElnpC0GK4MxDraV5wvS_Qo9GqLinqnDGh3t-RShOALy-CdIMmNFFQ== --host http://localhost:9999
[dong@centos-master influxdb_2.0.0-beta.16_linux_amd64]$ cat example.csv
#datatype measurement,tag,string,dateTime:RFC3339
m,host,used_percent,time
mem,host1,64.23,2020-01-01T00:00:00Z
mem,host2,72.01,2020-01-01T00:00:00Z
mem,host1,62.61,2020-01-01T00:00:10Z
mem,host2,72.98,2020-01-01T00:00:10Z
mem,host1,63.40,2020-01-01T00:00:20Z
mem,host2,73.77,2020-01-01T00:00:20Z

@x-dongzi The example in the documentation is incorrect and needs to be updated. Sorry about that. The correct way to specify a float column is with “double”, not “float”. I’ll make sure the documentation gets updated.

@x-dongzi The example in the documentation is incorrect and needs to be updated. Sorry about that. The correct way to specify a float column is with “double”, not “float”. I’ll make sure the documentation gets updated.

Thanks. Another question. If I want to write the integer into the influxdb. Which type I should set? I tried the type 'integer', but it did not work. Do we use the type 'double' as 'float' and 'integer'?

@x-dongzi long is how you specify an integer. Annotated CSV data types are covered in the Annotated CSV documentation.


Have you ever implemented your method in efficientnet network?

Hi, thank you for your great idea. It's very interesting.
Because efficientnet get a lot of great results in Imagenet.
I just want to know have you ever implemented your idea in efficientnet before?
(Because efficientnet get a lot of great results in Imagenet.)
If you had done it before, What's the result?
Thank you again for everything you've done.

Hi @yucathy ,
Thank you for your interest. We have not performed any experiments on architectures such as EfficientNets or MobileNets because, in contrast to other models (ResNets, DenseNets etc.), they do not include pooling layers (only for vectorisation with GlobAvg which is a special case). You could possibly incorporate Softool at the first convolution by also increasing the input size (224 -> 448 for example).
One more recently introduced family of networks that SoftPool can be used with are RegNets (Radosavovic \text{et al.} 2020) which are based on ResNets. We have not experimented with them however.
Best,
Alex

Hi @alexandrosstergiou ,
It's a nice work and good news for us to try.
Thank you for your response.

Will close this due to inactivity. Feel free to open a new issue for other questions/problems.
Best,
Alex


Adjustable Units for Route Distance

When using iD to get routing directions, I'm shown the distance of the route in km.

I'd like a way to select my preferred units
I'd like my preference to be saved between sessions

Perhaps related to https://github.com/openstreetmap/iD/issues/4881

This ticket belongs in a different project. Please disregard.


DEV-1155: Rotation behavior

[fix] Fix transformer behavior

move transformer background out of ImageTransformer and stop using Portal component
rework of LStransformer and drag bounding functions to make dragging of multiple regions synchronous
remove influence of outter transformer background on transformer area size and its recalculation triggering
stop listening history by transformer 'cause it isn't necessary anymore

[fix] Prevent skewing during transformation
[fix] Fix selected area position while zooming
[fix] Fix wrong units of rotation angle in transformer bound box function
Linked issue: https://github.com/heartexlabs/label-studio/issues/1854

@Gondragos please, resolve conflicts here

merged already by https://github.com/heartexlabs/label-studio/commit/867ffaadb036682c81558b41ccc3413ddcfa60d2


Question - Feature Syntax Highlight and Autocomplete in VS Code

Hello, I am new to VS Code and BDD in JS/TS.
Do we have to use vs code extentions (and which one would you suggest), so that we see the syntax highlight and the steps autocompletion?

Hello @NikkTod! I'm using Cucumber (Gherkin) Full Support plugin and it works so far. It provides syntax highlight and autocompletion.
Hope it helps.

Hi @bacarybruno, thanks for the suggestion.
I have tried it and it highlight correctlly, but I am not able to get the autocomplete working.
I am starting to type the first letter, but it is not showing me the already available step:
Feature: Playwright site

    Scenario: Check title
        Given I open url "https://playwright.dev"
        When I click link "Get started"
        Then I see in title "Playwright"

    Scenario: Check title 2
        Given I

You are welcome!


[20.03] fontforge: 20190413 -> 20200314

Motivation for this change
I noticed that the version in stable has vulnerabilities.
https://repology.org/project/fontforge/cves?version=20190413
Not sure why it was not backported.
https://github.com/NixOS/nixpkgs/issues/88291
Things done

[X] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[X] Fits CONTRIBUTING.md.

I think this is a good idea, although I guess the generated fonts don't inherit the vulnerability. So it's only users of fontforge itself that are at risk, not users of the huge number of reverse dependencies of fontforge.
Could you target the staging-20.03 branch? fontforge rebuilds a lot.

the staging channel is 6 days behind. so it seems i have to create the branch again...

@davidak You could rebase: git rebase -i origin/staging-20.03 and then delete all the lines with commits you don't want.

Ah, yes. That works.


test_settings: Refactor to use UserProfile property_types framework.

Automated message from Dropbox CLA bot
@sarahcstringer, it looks like you've already signed the Dropbox CLA. Thanks!

This looks great, merged, thanks @sarahcstringer!


Tests for Bgra encode / decode

Add tests for Bgra encode / decode for both dds and ktx (if ktx supports bgra).

As far as my research went, KTX does not directly support BGRA. Therefore tests for it in ktx may not be possible, since it may not be possible to begin with.

As far as my research went, KTX does not directly support BGRA. Therefore tests for it in ktx may not be possible, since it may not be possible to begin with.

Ah, well that's a bummer. Might need to throw notsupportedexception if trying to encode to ktx then.

Ah, well that's a bummer. Might need to throw notsupportedexception if trying to encode to ktx then.

Seems like there is an extension by apple that defines the Bgra GlInternalFormat enum. We can use that and write GlFormat as GL_BGRA. Real BGRA support without any extension would be in ktx2, if we ever decide to support that.

Seems like there is an extension by apple that defines the Bgra GlInternalFormat enum. We can use that and write GlFormat as GL_BGRA. Real BGRA support without any extension would be in ktx2, if we ever decide to support that.


useParams type should not return optional

What version of Remix are you using?
1.11.1
Are all your remix dependencies & dev-dependencies using the same version?

[X] Yes

Steps to Reproduce
The useParams type returns a record where the values can be string | undefined instead of simply string. This is far from convenient from an end-user perspective and makes me wonder why I'm even able to do something like this:
// { accountName?: string; projectId?: string }
const { accountName, projectId } = useParams<'accountName' | 'projectId'>();

<Link to={`/${accountName as string}/${projectId as string}`} />

...when it's return type is essentially the same as useParams without any type parameters:
// Record<string, string | undefined>
const { accountName, projectId } = useParams();

<Link to={`/${accountName as string}/${projectId as string}`} />

Expected Behavior
Instead, I would expect that putting in the extra work to add the type parameter would make those fields required in the return type so I don't have to use the nullish operator (or use an as assertion as seen above) later on:
// { accountName: string; projectId: string }
const { accountName, projectId } = useParams<'accountName' | 'projectId'>();

<Link to={`/${accountName}/${projectId}`} />

Actual Behavior
The return type still marks those properties as optional. I have to manually add an assertion to satisfy TS. This makes me wonder why that type parameter even exists in the first place. Sure, it makes it so I can't access arbitrary fields on useParams but the fields that I do specify are still marked as optional (which seems like undesired behavior).

If y'all agree with this change, I'd also be more than happy to implement it myself. Doesn't seem like it would be too hard to do (it seems to me like all it would take is a small one line change here).

Remix is doing the right thing.
Consider this routes:

app/routes/news.tsx
app/routes/news/$slug.tsx

In the news.tsx file, if I use const { slug } = useParams(), slug will be undefined when I'm on "/news", and will equal "foo" if I'm on "/news/foo".
So everything returned by useParams() can be undefined when not used in the route segment when the parameter is in the path. Hence the undefined | string

@machour whats the purpose of having the type parameter then if it doesn't do anything useful?

Oh, you just have a little error.
You should do:
const { slug } = useParams<{slug: string}>();

Here, you are correctly telling useParams: your return value is an object that has a string "slug" property, and you're reading slug by destructuring that return value.

ah, awesome, i'm stupid. 🤦

@machour actually, the type definition is still incorrect.
const { slug } = useParams<{ slug: string }>();
typeof slug; // this will still be string | undefined because useParams returns Partial<ParamsOrKey>

see the implementation i linked to earlier:
/**
 * Returns an object of key/value pairs of the dynamic params from the current
 * URL that were matched by the route path.
 *
 * @see https://reactrouter.com/hooks/use-params
 */
export function useParams<
  ParamsOrKey extends string | Record<string, string | undefined> = string
>(): Readonly<
  [ParamsOrKey] extends [string] ? Params<ParamsOrKey> : Partial<ParamsOrKey>
> {
  let { matches } = React.useContext(RouteContext);
  let routeMatch = matches[matches.length - 1];
  return routeMatch ? (routeMatch.params as any) : {};
}

...that should instead be:
/**
 * Returns an object of key/value pairs of the dynamic params from the current
 * URL that were matched by the route path.
 *
 * @see https://reactrouter.com/hooks/use-params
 */
export function useParams<
  ParamsOrKey extends string | Record<string, string | undefined> = string
>(): Readonly<
  [ParamsOrKey] extends [string] ? Params<ParamsOrKey> : ParamsOrKey
> {
  let { matches } = React.useContext(RouteContext);
  let routeMatch = matches[matches.length - 1];
  return routeMatch ? (routeMatch.params as any) : {};
}

...and you should probably update the Params<T> definition and the conditional type check here to be more consistent (i.e. so that useParams<'slug'>() works to return { slug: string } as well instead of { slug?: string } as it does rn).

That PR simply split a large file into sub-files.  The last functional change to useParams typings was in https://github.com/remix-run/react-router/pull/8352 if you want to check there for historical reasoning behind this change (which unfortunately pre-dates my involvement with RR 😄)

gotcha. i think @ryanflorence put it well: https://github.com/remix-run/react-router/issues/8200#issuecomment-1023658322 🙂
that comment makes sense. perhaps we should include it in documentation so y'all don't have to deal with people like me.


ci: automatically push release candidates to staging

copilot:all

Current dependencies on/for this PR:

main

PR #3441   👈

This comment was auto-generated by Graphite.


Implement Conversion Classes

Followup to the discussion in #537
The tests pass and i don't see any performance regression yet.
@andlaus @1atabey1 This is still in draft stage, but i'd like to hear your opinion.
Open points:

scale, offset, choices and is_float exist in both Signal and BaseConversion classes. At the very least, the Signal attributes should be converted to properties, which point to the attributes of Signal.conversion
add comments where necessary
documentation update

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

144 of 153 (94.12%)  changed or added relevant lines in 12 files are covered.
4 unchanged lines in 1 file lost coverage.
 I suppose the much better encoding performance is due to "inverse choice dictionaries"? the few performance regressions in your results are quite acceptable IMO...

@andlaus rebase is done


Update README.md

Hello, I have some suggestions for your project. They touch the sound signal when it falls to immediately find out when it fell, and also when you try to hack the phone from the computer, they will be reset to factory settings so that the data does not get to the attacker.
It would be interesting to know your opinion!

Thanks, that's a great add!
I'm looking to integrate a few features in an open app for information
security, that surely adds. Thanks for your time
https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail
Libre
de virus.www.avast.com
https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail
<#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>
El jue, 8 jun 2023 a la(s) 18:10, Despait @.***)
escribió:

Hello, I have some suggestions for your project. They touch the sound
signal when it falls to immediately find out when it fell, and also when
you try to hack the phone from the computer, they will be reset to factory
settings so that the data does not get to the attacker.
It would be interesting to know your opinion!
You can view, comment on, or merge this pull request online at:
https://github.com/Gab7777777/Screen-locking-based-on-accelerometer/pull/1
Commit Summary

e78c2b2
https://github.com/Gab7777777/Screen-locking-based-on-accelerometer/pull/1/commits/e78c2b2db3eaf5a0c28fb385f77fbdca573b2d77
Update README.md

File Changes
(1 file
https://github.com/Gab7777777/Screen-locking-based-on-accelerometer/pull/1/files
)

M README.md
https://github.com/Gab7777777/Screen-locking-based-on-accelerometer/pull/1/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5
(187)

Patch Links:

https://github.com/Gab7777777/Screen-locking-based-on-accelerometer/pull/1.patch
https://github.com/Gab7777777/Screen-locking-based-on-accelerometer/pull/1.diff
—
Reply to this email directly, view it on GitHub
https://github.com/Gab7777777/Screen-locking-based-on-accelerometer/pull/1,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A4MJPDPNAILP4ODSE5XVEKDXKH2PLANCNFSM6AAAAAAY7QLPL4
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


Not able to debug/launch Go programs

go: GOPATH entry is relative; must be absolute path: "undefined".
For more details see: 'go help gopath'
exit status 2
Process exiting with code: 1
GOPATH is set in the environment correctly. This has worked for the past 2 months so something has changed today (Spet/5/2017) with an extension possibly.

VSCode Version: Code 1.15.1 (41abd21afdf7424c89319ee7cb0445cc6f376959, 2017-08-16T18:07:25.676Z)
OS Version: Windows_NT x64 10.0.15063
Extensions:

Extension
Author (truncated)
Version

html-snippets
abu
0.1.0

markdown-toc
Ala
1.5.6

Bookmarks
ale
0.16.0

go-builder-help
ans
2.1.2

code-gnu-global
aus
0.2.2

vscode-eslint
dba
1.2.11

githistory
don
0.2.3

python
don
0.7.0

gitlens
eam
4.4.3

tslint
eg2
0.17.0

code-runner
for
0.7.1

vscode-auto-open-markdown-preview
hnw
0.0.4

beautify
Hoo
1.1.1

Angular2
joh
2.7.0

Go
luk
0.6.64

start-git-bash
McC
1.2.1

cpptools
ms-
0.12.3

csharp
ms-
1.12.1

PowerShell
ms-
1.4.1

debugger-for-chrome
msj
3.2.1

vscode-docker
Pet
0.0.16

vscode-icons
rob
7.12.0

gitblame
wad
2.1.0

JavaScriptSnippets
xab
1.4.1

(2 theme extensions excluded)

Steps to Reproduce:

Reproduces without extensions: Yes/No

This issue was moved to Microsoft/vscode-go#1194


How to train the value network and the reinforcement value network?

I have run the examples of supervised policy network following the Wiki . but I don't know how to train the value network and the reinforcement value network ,in the branch :https://github.com/MaMiFreak/RocAlphaGo/tree/debug-valueI only see the reinforcement_value_trainer.py and I don't really know how to use it.thank you for your help.

i answered your question in #219
most important thing is to check out the cython-optimization branch. let me know if you run into any trouble

@MaMiFreak  OK ,I will try it. Thank you for answering my question!


Ignore .ruby-gemset in .gitignore

Support users of the rbenv-gemset plugin (or rvm).

Before submitting the PR make sure the following are checked:

[x] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
[x] Wrote good commit messages.
[ ] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[ ] Added tests.
[x] Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
[ ] Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
[ ] If this is a new cop, consider making a corresponding update to the Rails Style Guide.

I'm curious what the use case is for still using gemsets rather than Bundler?
https://www.rakeroutes.com/how-to-use-bundler-instead-of-rvm-gemsets/

@andyw8 some gems complain if you have multiple versions of the same gem installed in the same set of gems, especially when you aren't currently wanting to run the same version, even when you use bundler. Other times, apps or gems can have different behavior if they detect a gem is there, such as by requiring code from the gem and behaving differently depending on whether the require works. I've seen both of these happen frequently in the last 10 years.
Ignoring bugs and weird behavior, there are practical benefits for every day use. It makes it easier to clean up after a project and free disk space for other projects: just delete the gemset and all of its gems get uninstalled. Plus, you don't have to type bundle exec or set up aliases for that on many different systems.
Just because you can use bundler instead of gemsets (if you're lucky to not run into those issues), it doesn't mean it's better. That's why I use gemsets even with rbenv.

I think it depends on the user environment, so it could be add it to the local ~/.gitignore file instead of this repository. Thank you.


datapath: Misc NAT changes

See commit msgs.

test-me-please

test-me-please

test-me-please

Coverage increased (+0.02%) to 36.681% when pulling 02415abc01c8bd8fb87dfdccaa29b6358c655bec on pr/brb/nat-misc into 4b0460d7444df0db9c908260635d6c83aa8b9803 on master.

@borkmann Thanks for the review, I've addressed all your comments. I'm not re-triggering the tests, as only comments were changed.


Fixed a bug that caused the Hudson build failures

Recently, as part of pul request #120, the method commitJob(JobContext jobContext) in OutputCommitter was overriden in  GobblinOutputCommitter, which called cleanUpWorkingDirectory
to delete the working directory of the MR job upon completion and committing of the MR job. However, there are two versions of the method commitJob(JobContext jobContext), one using org.apache.hadoop.mapred.JobContext, and the other using org.apache.hadoop.mapreduce.JobContext. The one that was overriden is the latter, and this is the one called in Hadoop 2. The issue is that the Gobblin job needs to read the task states stored under the working directory after the Hadoop job finishes, at which point the working directory has already been deleted if run on Hadoop 2. The issue didn't show up in Hadoop 1 is because the version of that method for Hadoop 1 was not overriden.
Signed-off-by: Yinan Li<EMAIL_ADDRESS>

LGTM


title search

Any chance we could add a title search to the dis website homepage? This week we synced one of these hellish elife preprints with many versions, and there was no easy way to quickly assess whether any version had a newsletter date. I had to go back to EndNote and do a title search there to see that indeed we had put an earlier version in the newsletter.

So far so good; I will take it for a test drive on Thursday and let you know if I want any other columns.

This is working well!