compute [contenthash] after generate file

Feature request
What is the expected behavior?
The documentation says that

The [contenthash] substitution will add a unique hash based on the content of an asset. When the asset's content changes, [contenthash] will change as well.

However, the [contenthash] does not actually match the hash of the file, i.e. the result you would get if you ran md5sum or sha256sum on the file.
This StackOverflow answer explains why: the [contenthash] is computed before minification.
The feature request is to compute the [contenthash] after minification/any other post-processing steps, or at least provide an option to do so.
What is motivation or use case for adding/changing the behavior?
This would have nice properties, such as allowing proxies to validate the integrity of a file just by comparing its hash to the filename.
How should this be implemented in your opinion?
Change the point in the process where the [contenthash] is computed. I don't know anything about webpack's architecture so I have no idea how hard this is.
Are you willing to work on this yourself?
I'm not a webpack developer but if there was some guidance from an expert I could take a stab at it.

@thomasjm it is md4 of file for perf reason, why you need md5, you can change this using option

This would have nice properties, such as allowing proxies to validate the integrity of a file just by comparing its hash to the filename.

Please clarify
All work as expected.

I'm not asking to change it to md5, it was just an example. I'm aware that you can change the hash algorithm using the output.hashFunction option.
I'm asking to make the hash produced by interpolating the [contenthash] in the filename match the actual hash of the file, no matter what algorithm you use.
Actually, I just found this plugin that accomplishes what I wanted: https://www.npmjs.com/package/webpack-plugin-hash-output. Perhaps this issue can be closed since the plugin solves it. But I still think it might make sense to make this the default behavior.

@thomasjm please provide example where contenthash is not match actual hash of the file

Looks this plugins fix problem what i describe above and we already track this problem https://github.com/webpack-contrib/terser-webpack-plugin/issues/18

please provide example where contenthash is not match actual hash of the file (now we have problem with terser minification only)

It never matches the actual hash of the file. The hash is computed before the file is generated.
I also thought about changing this, but it requires some additional refactorings since plugins (like terser-webpack-plugin) affect the file content after it has been generated by webpack.
Plugin would need to stop doing this and use a different hook instead which allows to alter the file content while generation. One reason is that some files (the main chunk) depend on the hash of other files (on-demand-loaded chunks), as hashes need to be included in source code.
There is a card about this on the webpack 5 board, but I unsure if this will make it into the final version as it breaks a lot of plugins. It also has a performance impact since i. e. minimizing has to be serialized for some files.

Got it, thanks @sokra. I'm happy to close this issue and track the card you mentioned instead.
(Can you point me to it? I'm looking through https://github.com/webpack/webpack/projects/5 and having trouble finding it.)

+1 to this issue. Since we load our assets from a CDN with long-lived cache headers (roughly following the Immutable Web App pattern), we ran into an issue where customers' browsers will fail to load cached assets since it fails the sub-resource integrity check (same filename, but different expected SHA-256).
The whole immutable web app pattern relies on the assumption that assets never change - and if they do, they result in a completely new asset file. I had assumed that [contenthash] fulfills that requirement, but I guess I didn't dig deep enough. :)

Duplicate of #7787 (?).

Source map generation not affected on contenthash https://github.com/webpack/webpack/issues/9853 also

Just ran into this, and read through the various interlinked issues across this repo + plugin repos that encounter this (e.g. https://github.com/webpack/webpack/issues/7787,  https://github.com/webpack-contrib/terser-webpack-plugin/issues/18).
Regardless of whether this change makes it into webpack 5 or later, is there a recommended way to handle this in plugins today with webpack 4?
My use case is similar to terser (optimisation of assets, as late as possible in the compilation) and I notice there that a partial fix was applied which updates the hash with the version/options of terser, to ensure that the hash changes if the terser plugin options change. This makes sense, but it seems like it makes the assumption that for a given version of terser with the same options, the output contents will always be the same.
This may be applicable for terser specifically but in cases where a plugin may not be able to guarantee determinism (or worse, may assume determinism but has subtle bugs making this not the case), how do we ensure that the files ultimately output to disk by webpack have a contenthash that reflects changes made by a plugin?
Apologies if this isn't the write issue for this question, but I haven't been able to find docs/best practices around updating assets if they've changed during a step such as optimizeAssets. I'm currently considering looping over each asset in the compilation that I've modified, and manually updating the name to include the new calculated contenthash (and then deleting the old asset from compilation.assets entirely), e.g.:
assets.forEach(asset => {
    const newAssetNameBasedOnHash = loaderUtils.interpolateName(...);
    compilation.assets[newAssetNameBasedOnHash] = compilation.assets[asset];
    delete compilation.assets[asset];
});

This feels a bit odd and would also require manually replacing references to the old sourcemaps/etc. in the source with the new hashed names.
Any advice/documentation about what's best here would be greatly appreciated, especially if this isn't going to end up being included in webpack 5 due to backwards-incompatibility concerns as mentioned above.

@evilebottnawi Will this problem also be fixed in webpack@4 or only will be fixed in webpack@5 ?  I see this problem just labeled as webpack-v5  which make me curious.

@hopperhuang it will be fixed in webpack@5/webpack@6, it is not easy to fix because it is big breaking change

Fixed by https://github.com/webpack/webpack/pull/11339 using the optimization.realContentHash option, it is true in production mode by default, in development mode we recommend do not use hashs in file names, but this will still work as expected

@alexander-akait In webpack@4, how can I update [contenthash] based on actual file content.
Because I want to change compilation.assets in optimizeChunkAssets hooks, and the modification of the same file may be different each time.
Do you have any suggestion?  Thanks

No suggestion, it is new feature for webpack@5, consider to update

I am having this issue with Webpack 5, when I run the build in docker on CI server. Using RUN npm ci --include dev to install node modules - so they shouldn't be changing between builds, but regardelss I've done multiple in with in minutes and the main.[contenthash].js is changing. I'll have to see if there is a way I can confirm what parts are changing, but main parts
  mode: 'production',
  entry: path.join(process.cwd(), 'app/app.js'),
  output: {
    filename: '[name].[contenthash].js',
    // Compile into js/build.js
    path: path.resolve(process.cwd(), 'build'),
    publicPath: '/'
  },

optimization: {
    minimize: true,
    minimizer: [
      `...`,
      new CssMinimizerPlugin(),
    ],
  },
  plugins: [
    new webpack.DefinePlugin({
      'process.env.NODE_ENV': JSON.stringify('production'),
      'process.env.CODE_VERSION': JSON.stringify(process.env.CODE_VERSION),
      'typeof window': JSON.stringify('object'),
      'process.env.NODE_DEBUG':  JSON.stringify(process.env.NODE_DEBUG)
    }),
    new HtmlWebpackPlugin({
      template: 'app/index.html',
      minify: {
        removeComments: true,
        collapseWhitespace: true,
        removeRedundantAttributes: true,
        useShortDoctype: true,
        removeEmptyAttributes: true,
        removeStyleLinkTypeAttributes: true,
        keepClosingSlash: true,
        minifyJS: true,
        minifyCSS: true,
        minifyURLs: true
      },
      inject: true // Inject all files that are generated by webpack, e.g. bundle.js
    }),
    new faviconsWebpackPlugin('app/jump-logo.svg'),
    new webpack.ProvidePlugin({
      Tether: 'tether',
      Popper: ['popper.js', 'default'],
      '$': 'jquery',
      jQuery: 'jquery',
    }),
    new MiniCssExtractPlugin({
      filename: '[name].[contenthash].css',
      chunkFilename: '[id].[contenthash].css'
    })
  ],
  resolve: {
    modules: ['app', 'node_modules'],
    extensions: ['.js', '.jsx', '.react.js'],
    alias: {
      'jquery': 'jquery/dist/jquery.slim.min.js',
    }
  },
  target: 'browserslist', // Make web variables accessible to webpack, e.g. window
  stats: true // Show stats in the console
};

Not sure if any surprises in there - but I would have thought that I should be seeing reproducible builds. When I run repeatedly on same machine, I get same results and when I change a comment or whitespace in the webpack config file, and push to CI it is getting a different hash on each build.
I'm just curious, I'd love to have the main.js stay the same as it's largest file, and should be cached unless it changes.


Interactive installer should install more

The interactive installer should also assist with installing the additional items: auth_views, basic_views, basic_routes, main_views

@WadeShuler can you add more details of what you expect. We already have created a wiki page for the Artisan Commands

I kind of expect an interactive installer to be able to install everything.
I don't want the translations, but I want to install EVERYTHING else.
It doesn't look like I can do a --type=full and say without translations.
basic, enhanced, and full all add the translations.
So it seems I would have to use a --with 6 times:
php artisan adminlte:install --with=assets --with=config --with=main_views --with=auth_views --with=basic_views --with=basic_routes

Maybe add a question on the installer, like "Would you like to install additional items?". If yes, then ask them about all of the rest of the items..
Would you like to install additional items?

Would you like to install the main views?
Would you like to install the auth views?
Would you like to install the basic views?
Would you like to install the basic routes?

Maybe there is a way to install everything but the translations and I am missing it?
However, I still think the interactive installer should be able to install these additional items...

@WadeShuler thanks for the feedback, I will take this on consideration for future improvements on the artisan commands.

From version v3.12.0 you are able to execute:
php artisan adminlte:install --type=full --interactive
To be asked about the installation of all resources. However, additional resources are used only to cover some particular situations and may be rarely used. So, we've decided not to include this procedure on the basic package installation.


Problem when calculate descriptors from smiles by using csv

I have seen an issue (when calculate descriptors from smiles, an error occured. #9) with related problem; however, when I use the code mentioned in the issue:
from padelpy import from_smiles
with open('all_smi.csv', 'rt') as f:
	smi = f.readlines()

I will get error: IndexError: list index out of range. I have checked for my csv, and when I use the csv provided in that issue, it still get the same problem. How can I fix it?
My environment is Mac OS, and the python version is 3.7.3
Thanks.

Hi @sophiameerkat,
I apologize for the very late response! Could you provide the full stack trace for the error, as well as the CSV file you used?
Thanks,
Travis

@sophiameerkat,
Another user encountered an IndexError for a specific compound (https://github.com/ECRL/PaDELPy/issues/12). Does this stack trace look similar to yours?

Traceback (most recent call last):
File "C:\Users\Daniel\OneDrive\UCPH\Research\Scripts\PaDEL\PaDEL Descriptors.py", line 3, in
from_smiles('Oc7ccc5c1c7O[C@H]3[C@]6(OC)C@HC@@(C)C(C)(C)C', timeout=60, output_csv='Buprenorphine.csv')
File "C:\Users\Daniel\anaconda3\lib\site-packages\padelpy\functions.py", line 81, in from_smiles
del rows[0]['Name']
IndexError: list index out of range

I'm looking forward to hearing back from you!
Travis

I'm going to go ahead and close this issue to inactivity. If your problem persists, feel free to open it again.


deleting one bound substrand of a scaffold makes the remaining strand not a scaffold

Draw a scaffold with one substrand on helix 0 and another on helix 1. Select the 5'/3' end of the scaffold on helix 0 and delete it. The remaining portion of the strand converts to not a scaffold, but it should remain a scaffold.

Can't reproduce this. Maybe I was getting fooled by a blue-colored, non-scaffold strand.


Force at least one linear solve per nonlinear solve

This creates a modified version of the native mfem::NewtonSolver that optionally forces at least one linear solve per nonlinear solve. This is needed for downstream optimization customers to avoid the optimizer thinking it has hit a flat response of the parameter fields.

Codecov Report

Merging #869 (d7b7b2a) into develop (39d8905) will decrease coverage by 0.02%.
The diff coverage is 89.09%.

:exclamation: Current head d7b7b2a differs from pull request most recent head c859ac3. Consider uploading reports for the commit c859ac3 to get more accurate results

@@             Coverage Diff             @@
##           develop     #869      +/-   ##
===========================================
- Coverage    94.82%   94.79%   -0.03%
===========================================
  Files          152      154       +2
  Lines        10669    10723      +54
===========================================
+ Hits         10117    10165      +48
- Misses         552      558       +6

Impacted Files
Coverage Δ

src/serac/numerics/newton_solver.cpp
88.23% <88.23%> (ø)

src/serac/numerics/equation_solver.cpp
81.97% <100.00%> (ø)

src/serac/numerics/newton_solver.hpp
100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

LGTM

Talking to @samuelpmishLLNL and @kswartz92 , a better option might be to either perturb or reset the displacement field before calling to the solver. As we move to more advanced nonlinear solvers, it is likely this issue won't go away.

This PR is closed in favor of manually resetting the current displacement guess.


Question: would it be possible to add feature that allows to use it on puzzles and other game modes?

I have a question about your extension: would it be possible to change the code to get the suggested next best move inside different chess.com games such as puzzles or daily move? it is such a great tool.
also, why sometimes it has bouncing between few best moves? will it be possible to attach or supply more CPU processing or more RAM or whatever is needed to get faster results? thanks for your time replying to this.

Im sorry, but this project is suspended.


Fix Typo in hardhat.md

What changed? Why?
A comma is missing in the sample code.
Notes to reviewers
How has it been tested?
No, this is a Markdown document.

@Lee-WonJun Thanks for fixing this!


if contexts_df has only an index, decisions are not computed

if contexts_df is empty (only index), properties are not generated and decisions are not computed.
Reason : df.apply(lambda row: ...) return the dataframe if df is empty.
Solution : Add a dummy column if df is empty in order to enable the properties generation and decisions computation.

Fixed in #97


Only 100 Validators displaying on Stake Page for Classic Network

Steps to reproduce:

Change Network to Classic
Click on Stake on the left Navigation
Under Validators, only 100 active validators are displayed

Expected:
130(if 130 bonded) active validators are displayed.

This is not fixed at the time of posting, despite @luncburnaus closing the issue.

Thanks have reopened it.


[Backend] Add System Manager (Data Steward) Foundation

❗ Bump downrev before merging
Closes #2609
Closes #2607
Code Changes
Database/modeling changes

[x] Add a SystemManager many-to-many table to link users to systems
[x] Add client.systems field which is a list of system ids for persisting this information when the user is logged in
[x] Add model methods FidesUser.add_as_system_manager and FidesUser.remove_as_system_manager to add and remove users from the system <-> user many-to-many table and update the related client if applicable.

Authentication changes

[x] When creating tokens, persist a list of system ids to the token for which the user is manager.
[x] Add new verify_oauth_client_for_system_from_request_body and verify_oauth_client_for_system_from_fides_key for authorizing tokens when updating and deleting systems.  In addition to the roles and scopes checks these endpoints already have, add the ability for the user to update or delete if they are system manager of that particular system.
[x] Split system update and system delete endpoints off from the crud endpoints defined in a loop due to the new authorization.
[x] Split recently-added scopes: CLI_OBJECTS_CREATE, CLI_OBJECTS_DELETE, CLI_OBJECTS_READ and CLI_OBJECTS_UPDATE  into more granular scopes per object per endpoint so we can create roles with very specific scopes on the ctl-side.
[x] On login, update the client with the latest scopes/roles/systems if one already exists.. It is possible they've been updated but the change hasn't persisted to the client.

Data migration

[x] For users that have  CLI_OBJECTS_CREATE, CLI_OBJECTS_DELETE, CLI_OBJECTS_READ and CLI_OBJECTS_UPDATE in their pre-existing fidesuserpermission.scopes and client.scopes columns, add the new corresponding granular scopes to this list, as we're changing which scopes go on these endpoints.

Steps to Confirm

[x] Set CONFIG.security.env to prod so authentication is live on the ctl endpoints
[x] run nox -s "fides_env(dev)"
[x] Login as the root user and create a new user with minimal scopes with username "test"
[x] Bring up a python shell and remove the user's scopes, give them a viewer role, and make them a system manager of a pre-existing system

from fides.lib.db.base import FidesUser
from fides.api.ctl.sql_models import System
from fides.lib.db.session import get_db_session
from fides.core.config import CONFIG
SessionLocal = get_db_session(CONFIG)
db = SessionLocal()

u = db.query(FidesUser).filter(FidesUser.username=='test').first()
s = db.query(System).first()

u.set_as_system_manager(db, s)
u.permissions.scopes = []
u.permissions.roles = ["viewer"]
db.add(u)
db.commit()

[x] Verify we have one system and no scopes and viewer role

>>> u.permissions.roles
["viewer"]
>>> u.permissions.scopes
[]
>>> u.system_ids
['ctl_2a29bf06-7aba-47d5-8402-3c8a4f3d122e']

[x] Login as "test"
[ ] Note that you can edit the system to which you're assigned, but not the other system.
[ ] Note you can delete the system to which you're assigned but the the other system.
[ ] You should still have broader "get" scopes because of your Viewer role.

Pre-Merge Checklist

[ ] All CI Pipelines Succeeded
Documentation:

[ ] documentation complete, PR opened in fidesdocs
[ ] documentation issue created in fidesdocs

[ ] Issue Requirements are Met
[ ] Relevant Follow-Up Issues Created
[ ] Update CHANGELOG.md

Description Of Changes
Add the ability for users to be System Managers.  This is our first example of object-level permissions instead of model-level permissions. Rather than being granted permissions to all resources of this type, System Managers are granted a limited set of permissions (now: system update and system delete) to only the specific systems to which they are assigned.
This is not a "role" - it's a separate additional optional way in which users can be granted permissions.  The extra auth checks need to be intentionally added to each system-related endpoint where we want system managers to have access.

One of my tests are failing and hanging when run alongside all unit tests, but not when the its class of tests is run directly.  Looking into this -

@ThomasLaPiana do you have suggestions for bringing up nox -s "fides_env(dev)" with a security_env of prod?
This fails with:
2023-03-01 20:02:57.355 | INFO     | setup.dataset:create_dataset:32 - Upserted 1 Dataset(s)
2023-03-01 20:02:57.390 | INFO     | setup.dataset:create_dataset:52 - Created fides dataset via http://fides:8080/api/v1/connection/mongodb_connector/datasetconfig
Examples loaded successfully!
nox > Pushing example resources for Data Mapping tests... (demo_resources/*)
nox > docker exec -e ANALYTICS_OPT_OUT -e FIDES__CLI__ANALYTICS_ID -t fides-fides-1 fides push demo_resources/
Loaded config from: /fides/src/fides/data/test_env/fides.test_env.toml
Loading resource manifests from: demo_resources/
Taxonomy successfully created.
----------
Processing dataset resource(s)...
{'detail': 'Not Authorized for this action'}
nox > Command docker exec -e ANALYTICS_OPT_OUT -e FIDES__CLI__ANALYTICS_ID -t fides-fides-1 fides push demo_resources/ failed with exit code 1
nox > Session fides_env(test) failed.

@ThomasLaPiana do you have suggestions for bringing up nox -s "fides_env(dev)" with a security_env of prod? (Doesn't need to necessarily be this command, just how to run the test_env with prod)
This fails with:
2023-03-01 20:02:57.355 | INFO     | setup.dataset:create_dataset:32 - Upserted 1 Dataset(s)
2023-03-01 20:02:57.390 | INFO     | setup.dataset:create_dataset:52 - Created fides dataset via http://fides:8080/api/v1/connection/mongodb_connector/datasetconfig
Examples loaded successfully!
nox > Pushing example resources for Data Mapping tests... (demo_resources/*)
nox > docker exec -e ANALYTICS_OPT_OUT -e FIDES__CLI__ANALYTICS_ID -t fides-fides-1 fides push demo_resources/
Loaded config from: /fides/src/fides/data/test_env/fides.test_env.toml
Loading resource manifests from: demo_resources/
Taxonomy successfully created.
----------
Processing dataset resource(s)...
{'detail': 'Not Authorized for this action'}
nox > Command docker exec -e ANALYTICS_OPT_OUT -e FIDES__CLI__ANALYTICS_ID -t fides-fides-1 fides push demo_resources/ failed with exit code 1
nox > Session fides_env(test) failed.

looks like we'll need to add an additional command in there to do the login, sorry for not catching that
There are examples elsewhere in the code, and there is a LOGIN constant in constants_nox.py that has the command too

Perfect thank you @ThomasLaPiana https://github.com/ethyca/fides/pull/2714/commits/3e23946d05d4ef988d1400f9b3b76ad5ec1b7bbf

@ThomasLaPiana I'm messing with system auth here, would you mind taking a look when you have some time?

@pattisdr starting to work through this, might not finish the review until Monday though!
Was this considered critical for the 2.8.0 release?

Was this considered critical for the 2.8.0 release?

@ThomasLaPiana No it does not need to go out in this release

I just looked back through the code and was trying to add a Systems Under Management section to the fides user permissions output, but it looks like the systems field isn't included as part of that response. I think that should be included as  part of checking user permissions, and thought it was but I didn't see it in the response

Hey @ThomasLaPiana I didn't add systems to that CLI response but it is in the API response. I'll add the CLI section.  This might not have been clear, but you don't need to be a system manager to be able to delete the system if you have permissions via another route. For example, an owner has full admin and can perform any action.  Being a system manager more denotes formal responsibility for the system.

@ThomasLaPiana I've tried to add the system managers to the CLI command here https://github.com/ethyca/fides/pull/2714/commits/739d2ebe430b3685a925b3bd2bd71394616eb109

I've gone through the functional testing steps up top and it appears to have allowed me to delete both systems:

Here's the shell output from the verification commands:
In [1]: from fides.lib.db.base import FidesUser
   ...: from fides.api.ctl.sql_models import System
   ...: from fides.lib.db.session import get_db_session
   ...: from fides.core.config import CONFIG
   ...: SessionLocal = get_db_session(CONFIG)
   ...: db = SessionLocal()
   ...:
   ...: u = db.query(FidesUser).filter(FidesUser.username=='test').first()
   ...: s = db.query(System).first()
   ...:
   ...: u.set_as_system_manager(db, s)
   ...: u.permissions.scopes = []
   ...: u.permissions.roles = ["viewer"]
   ...: db.add(u)
   ...: db.commit()

In [2]: u.permissions.roles
Out[2]: ['viewer']

In [3]: u.permissions.scopes
Out[3]: []

In [4]: u.system_ids
Out[4]: ['ctl_045a09d3-6afd-4e37-a4d3-7ddb23596770']

@seanpreston are you positive that the "prod" settings are in effect? If not, there's no authentication on those endpoints at all - in which case anyone could delete the systems.

Hey @ThomasLaPiana I didn't add systems to that CLI response ~but it is in the API response~. I'll add the CLI section. This might not have been clear, but you don't need to be a system manager to be able to delete the system if you have permissions via another route. For example, an owner has full admin and can perform any action. Being a system manager more denotes formal responsibility for the system.
EDIT: Sorry I got confused here, it's not in the get permissions endpoint, it's in the new endpoints where you get system managers #2726 I'm trying to keep "roles" and "systems" separate, to distinguish between model-level and object-level permissions. I can add this to the CLI section in that PR.

That makes perfect sense, thank you for the explanation!

my instructions should have been more clear @seanpreston!

Getting this up-to-date again with main

@pattisdr thank you for that CLI update! Looks great 😄
I think we (in this case myself) should open up a follow-up PR to make fides user create more robust now that we allow people to specify roles. I had avoided adding that feature previously because having a user choose from those scopes was too complicated, but with roles it becomes much more feasible

Thanks very much for your review @seanpreston, much appreciated! I'll hold off on merging just yet as this PR adds new scopes.  I think we should make sure this goes out as the same release as the UI work that Allison/Catherine are doing.


Fix clippy warnings

Fixed small warnings that didn't allow CI check to pass successfully.

Clippy got updated and with new features while I was working on this. This needs new CI run and approval.


Implement software encoder (non NVENC) support

When the user doesn't need to transcode all the streams (conditional processing), a software encoder can be efficiently used. It also benefits A100, Nano V2, and other GPUs with limited or missing NVENC.

we may use a special predicate like encoder: nvenc | software, default nvenc to address that.

Update docs to reflect new option and parameters.


change default frontend port

To avoid conflicting with the backend (hasura) which is also 8080.

On autumn, port 8081 is used by the pipeline, so maybe we can use another port :grimacing: The docker-compose file here specifies the port as 80 for the frontend: https://github.com/ocurrent/current-bench/blob/main/docker-compose.yaml#L28
Maybe we can use another default here for local testing?

How about the following mapping?

Service
Production port
Development port

Pipeline
8081
8081

Hasura
8080
8080

Frontend
80
8082

@tatchi, If this works, could you update the PR?


"Test/Run" option not available in portal

Even though the tooltip says "Only available for HTTP triggered functions" the test/run button is still disabled even for HTTP triggered functions

We are tracking a portal update/fix to address an issue with this.
Will keep this open so we can track the deployment completion.
@ankitkumarr to confirm this is indeed the issue that is being addressed with the deployment.

@takyyon Could you help with this issue? I can still repro. The "fucntion-editor-file-selector" dropdown is empty in the case of a dotnet oop function app. When I check a node js app, the dropdown lists the files (ex: index.js) and the test/run option is enabled.

@cloudmelon

Thanks for reporting.
This is being tracked by the portal team. Closing this here as there are no actions required in this repo.


Copy a character from an account with ER DLC to an account without DLC?

Using your amazing tool I can copy the character from one account to another, but if another account doesn't have the DLC installed, the game gives me an error "The following additional components not found: Shadow of the Erdtree". Is it possible to add new functionality to fix this issue?

yeah thats an issue for me to , id like if you can add an fix ti this real quick

There is no fix for this. This would include cleaning the entire save file for anything referencing the dlc and would take months to attempt to understand the entire file to even try.
On 15 Oct 2024, at 10:05 PM, Herofille @.***> wrote:

yeah thats an issue for me to , id like if you can add an fix ti this real quick
—
Reply to this email directly, view it on GitHubhttps://github.com/BenGrn/EldenRingSaveCopier/issues/39#issuecomment-2413579489, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ANKBNR2QZ5B7TO44NWC7D7TZ3TZGJAVCNFSM6AAAAABLSICXN6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMJTGU3TSNBYHE.
You are receiving this because you are subscribed to this thread.Message ID: @.***>


Unfurl Discord links in more places

In #1446 we made the bot unfurl and message links found in reported incidents. This sends a webhook with details on the message referenced.
This is incredibly useful, especially for people on Android, where Discord links are completely broken.
I would like to request that this feature is extended to at least all staff channels, with the option to whitelist additional channels/categories if needed.
As a brief spec, the bot should look for Discord links in all messages in staff channels, for each link found the bot should send an embed similar to below.

See the linked PR for reference on how this was done. We should likely make this logic a shared util.

Could I get assigned on this, I have already started working on it, just forgot to get myself assigned here.

Is this still something we want? Discord links on Android are much improved now (for me at least).


Disable delivery date in orderview for Belgium shipments

Disable delivery date in orderview for Belgium shipments.You can't use any delivery day so don't show in the orderview. Also check the mail if this will be send to customers.
Case: 00548704

This issue has been resolved since 3.1.5


Chapter7: Feature folder update

Update packages to more up to date versions
Update dockerfiles to use python 3.8
Update docker-compose file to version 3

Python 3.6-onbuild images are deprecated.
Newer packages are working well with 3.8.
Had to explicitely install pyopenssl==19.1.0 to fix an issue with eventlet with versions of python above 3.6.


Declaration is not supported for swift

Swift version
No response
Platform
No response
Editor
No response
Description
Your language server says that it supports declaration https://github.com/swiftlang/sourcekit-lsp/blob/3b6ced848805ba9b49f0872800b69abbf673d112/Sources/SourceKitLSP/SourceKitLSPServer.swift#L1055
It is true for c language but not for swift language. In vscode for instance, the menu Go To Declaration is enable for swift file

and when you execute it, it throws an error
[Trace - 11:05:09 AM] Received response 'textDocument/declaration - (38)' in 41ms. Request failed: unsupported method (-32001).
[Error - 11:05:09 AM] Request textDocument/declaration failed.
  Message: unsupported method
  Code: -32001

The Go To Declaration should be visible only for c files, but not for swift files. To do that and if LSP client like vscode, LSP4IJ etc support dynamic capabilities, you should send a registerCapability for declaration only for c, cpp, etc
[Trace - 11:03:56 AM] Received request 'client/registerCapability - (2)'.
Params: {
    "registrations": [
        {
            "id": "165E8362-B52A-4FD5-8026-7885DA379067",
            "method": "textDocument/declaration",
            "registerOptions": {
                "documentSelector": [
                    {
                        "language": "c"
                    },
                    {
                        "language": "cpp"
                    }
                   ...
                ]
            }
        }
    ]
}

Steps to Reproduce
No response
Logging
No response

Synced to Apple’s issue tracker as rdar://140662916

Did you build the project recently? I assume that we can’t find the declaration in the index and building would update the index. The unsupported method (-32001) error code is a little misleading here.
If doing a build doesn’t fix the issue, could you run sourcekit-lsp diagnose and attach the bundle to this issue? That should give us a hint about what’s going wrong.

I have not build something. Just play with vscode-swift which have this problem with wrong declarationwprovider swift capability which shows the Go to declaration menu although it should be hidden

Could you try if building your project fixes the problem? As stated in the README.

SourceKit-LSP does not update its global index in the background or build Swift modules in the background. Thus, a lot of cross-module or global functionality is limited if the project hasn't been built recently. To update the index or rebuild the Swift modules, build your project or enable the experimental background indexing as described in Enable Experimental Background Indexing.

Could you try if building your project fixes the problem? As stated in the README.

SourceKit-LSP does not update its global index in the background or build Swift modules in the background. Thus, a lot of cross-module or global functionality is limited if the project hasn't been built recently. To update the index or rebuild the Swift modules, build your project or enable the experimental background indexing as described in Enable Experimental Background Indexing.

@ahoppen I am sorry I have no time to do that because I.dont use swift. I wanted just to test your language server inside IntelliJ with LSP4IJ https://github.com/redhat-developer/lsp4ij/blob/main/docs/user-defined-ls/sourcekit-lsp.md and I have seen this error.

OK, thanks for the feedback regardless. If you never performed a build, I am pretty sure that the failure is because of that and that enabling background indexing would fix it. Since I’m unable to act upon this issue as-is, I’m closing it. If you do get a chance to try again after performing a build or gather log output from the issue by running sourcekit-lsp diagnose after reproducing the issue, please re-open the issue with that additional information.


Npm link cause "Unable to resolve module AccessibilityInfo "

Is this a bug report?
Feels like it is a bug.
Environment

react-native -v: react-native-cli: 2.0.1 react-native: 0.46.4
node -v:v8.1.3
npm -v:5.3.0

Target Platform: *

Development Operating System: macOS 10.12.5 & Windows 10 64bit

Steps to Reproduce
There is a RN Project A and Denpendency B.
B is abstracted from A, it works properly before.
Now B has a dependency on RN.
Project A install Dependency B using npm link ../B && npm install ../B --save.
Structure as below:
|--A
|--|--node_modules
|-------|--RN
|-------|--B
|----------|--node_modules
|---------------|--RN
Run with react-native start
Expected Behavior
Everything goes fine.
Actual Behavior
Error pops up as error: bundling failed: "Unable to resolve module "AccessibilityInfo" from "/path/to/A/node_modules/react-native/Libraries/react-native/react-native-implementation.js": Module does not exist in the module map.

Duplicate of #14209

I don't know if someone told that before me but downgrading from 0.56.0 to 0.55.4 solved this issue for me. 😃

I don't think that it is a dublicate of an multiple years old issue. Because the only solution of the old issue was to downgrade version.
Downgrading is only a temporary fix, but no permanent solution.
The problem seems to be the same, it doesn't mean that reason is identacally, too.

It seems the issue has been present in all kind of operating system and react version for years. And the support is very unprofessional...

Same issue here. Did something change in the last two days?

Please submit a new issue, as this one is closed.


CHE Hacks Fiscal Sponsorship

Moved from hackedu/hack-camp#186.
/cc @jonleung

@zachlatta Are we sponsoring CHE hacks? or are they sponsoring us?
/cc @jonleung

As discussed this evening in-person with @MaxWofford and @jonleung, we don't have the bandwidth to do this and it'd be dubiously possible with our fiscal sponsorship agreement.


Test emails + Portal Creation Notifications use [Host:HostTitle] which is unable to be set in UI ( DNN Corp is default value)

Description of bug
Test emails use [Host:HostTitle] along some other email notifications.
Steps to reproduce
List the steps to reproduce the behavior:

Go to test portal email smtp configuration
Send a test mail and it does not state it is coming from any site but a host title which happens to be DNN Corp

Current result
The [Host:HostTitle] is used, and if using a host name there should be a UI place to set this possibly next to the host email in Server Settings?
Expected result
Test emails and other email notifications are sent using something that can be set.  There are other templates currently use HOST:HOSTTITLE
Screenshots
If applicable, provide screenshots to help explain your problem.

Error log
Paste the error log that is related to this issue.
Additional context
The default HostTitle is DNN Corp.   So when sending notifications out for new website hosting portals and for SMTP configuration tests they use DNN Corp instead of a setting that can be set without having to manually set it in the database.
Affected version

[ ] 10.0.0 alpha build
[x ] 9.4.2 alpha build
[ x] 9.4.1 latest supported release

Affected browser

[x ] Chrome
[ x] Firefox
[ x] Safari
[ x] Internet Explorer
[ x] Edge

@thabaum great issue and I concur 100% - this is an issue that needs a fix.  I’d recommend we surface that field and allow it to be edited in the UI.

Should also not be Dnn Corp as default, I think just Dnn would be better as it makes it seam it comes from corp which is not the case.

@valadas
the default values for HostTitle and HostURL needs to be fixed in DNN template file (/install/DotNetNuke.install.config.resources)

I changed to [Portal:PortalName] so it just used the portal name I was testing as you can see in the screenshot.
We should be able to set all of the host configurations.  I think they all need to be on their own tab under server.  Host Title, Host Email, Host Url, Host Header... anything that is related to the Host and not to a site/portal.
Also under persona bar Server would be a good place to add two tabs one for Host Settings and another for Site Groups.

I changed to [Portal:PortalName] so it just used the portal name I was testing as you can see in the screenshot.
This could be another pull request to update the language file to use the portal name that is being tested to use the host/portal SMTP settings.  Any thoughts?
I went ahead made some changes for that file thanks @sleupold maybe @valadas can take a look make adjustments if needed.  I referenced DNNDocs and DNNCommunity.org in the file to replace help and host url.  Just trying to lighten the load a little and help... not a showstopper here...

Pr merged, thanks @thabaum , would you be able to submit another one to use [Portal:PortalName], I think this solution makes sense. There is always a portal, so I think that solution makes sense to me.


WIP: hide color picker on scroll.

Fixes #17451
Currently work in progress. Not working.

Testing plan:
To add.
GIFs or screenshots:
To add.

Didn't got time, so left in between.

I think we should first focus on #14961
That will automatically solve this issue.

@Signior-X Currently I am working on #14961 so I will fix it.


feat: basic authorisation to modify groups.

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (bf9133f) to head (758435b).
Report is 2 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff            @@
##              main       #49   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           15        14    -1
  Lines         1365      1382   +17
  Branches       115       121    +6
=========================================
+ Hits          1365      1382   +17

Flag
Coverage Δ

unittests
100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


New: Add autofixer to require-meta-has-suggestions rule

If suggestions are detected, add hasSuggestions: true.

https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/169 has been merged. can you rebase the master please?
thanks!

Fixed.


Cannot unsprint when flying in creative/spectator

A bug I found in the recently released 1.6.2, so basically when sprinting while you're flying either in creative or spectator mode, and if you stop, you're still sprinting.
https://github.com/Wilyicaro/Legacy-Minecraft/assets/39068731/c195587c-ffb6-45e6-9137-7710400c465e

Fixed in version 1.6.2a, thanks for reporting.


Removed extraneous documentclass block

Part of the preamble was duplicated.

This fix looks correct to me. Thanks!


New to Sketch

I've been using Photoshop since the 1st version, but I'm SUPER new to Sketch... as in, I've purchased and downloaded it, but haven't done anything past that.
I've opened up your file, but how/where do I upload my Image, in order to get the image to populate into all of the icons?
Thanks.

Hey @rherring
So, the icons have to be added to each Artboard on the left hand side. Each Artboard coincides with a needed icon size for Xcode. As long as those are populated, you can go to File > Export... and the Sketch template will automatically generate the different sizes and file names that you'll need for Xcode.

Okay, so it can't be added to one Artboard, which then applies it to all the others at the correct size.

That's right @rherring
I'm not sure if Sketch could do that. Perhaps it could do that but the template that I've made is assuming that a logo is adjusted to each Artboard.


Segmentation fault (core dumped) on CentOS 7 on test run

Hi,
I've been attempting to use python-saml on a CentOS 7 host and have been unable to get it to work.
Here is the Docker image I've been using to troubleshoot this:
https://hub.docker.com/r/ezturner/python-saml-centos7/
Dockerfile:
https://gist.github.com/ezturner/381205b71594fd56dd9d708870dfa80d
List of dependencies:
https://gist.github.com/ezturner/29b49015af286e50c847d1b139db15f3
Output of running tests:
Step 8/8 : RUN cd python-saml && python setup.py test
 ---> Running in 6dae4f71f0b5
running test
running egg_info
writing requirements to src/python_saml.egg-info/requires.txt
writing src/python_saml.egg-info/PKG-INFO
writing top-level names to src/python_saml.egg-info/top_level.txt
writing dependency_links to src/python_saml.egg-info/dependency_links.txt
reading manifest file 'src/python_saml.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
warning: no previously-included files matching '__pycache__' found under directory '*'
warning: no previously-included files matching '*.py[co]' found under directory '*'
writing manifest file 'src/python_saml.egg-info/SOURCES.txt'
running build_ext
/bin/sh: line 1:     7 Segmentation fault      (core dumped) python setup.py test
The command '/bin/sh -c cd python-saml && python setup.py test' returned a non-zero code: 139

I'd appreciate any help that can be provided with troubleshooting this issue. Thanks!

Sorry never experienced this before.


/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3618/16/testReport/

Max. process+thread count
929 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3618/16/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 48s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+0 :ok:
jsonlint
0m  1s

jsonlint was not available.

+0 :ok:
xmllint
0m  1s

xmllint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 69 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
38m 46s

trunk passed

+1 :green_heart:
compile
0m 57s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
0m 49s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
checkstyle
0m 58s

trunk passed

+1 :green_heart:
mvnsite
0m 53s

trunk passed

+1 :green_heart:
javadoc
0m 55s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 42s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
2m  5s

trunk passed

+1 :green_heart:
shadedclient
24m 34s

branch has no errors when building and testing our client artifacts.

-0 :warning:
patch
24m 51s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 44s

the patch passed

+1 :green_heart:
compile
0m 51s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
0m 51s

the patch passed

+1 :green_heart:
compile
0m 43s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
javac
0m 43s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 46s
/results-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 122 new + 1158 unchanged - 6 fixed = 1280 total (was 1164)

+1 :green_heart:
mvnsite
0m 47s

the patch passed

+1 :green_heart:
javadoc
0m 40s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 38s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

-1 :x:
spotbugs
1m 56s
/new-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.html
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1 :green_heart:
shadedclient
24m 14s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
606m  7s
/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
hadoop-yarn-server-resourcemanager in the patch passed.

+1 :green_heart:
asflicense
0m 34s

The patch does not generate ASF License warnings.

710m 18s

Reason
Tests

SpotBugs
module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager

Dead store to pfff in org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.PercentageQueueCapacityCalculator.calculateMinimumResource(ResourceCalculationDriver, CalculationContext, String)  At PercentageQueueCapacityCalculator.java:org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.PercentageQueueCapacityCalculator.calculateMinimumResource(ResourceCalculationDriver, CalculationContext, String)  At PercentageQueueCapacityCalculator.java:[line 39]

Failed junit tests
hadoop.yarn.server.resourcemanager.scheduler.capacity.TestLeafQueue

hadoop.yarn.server.resourcemanager.scheduler.capacity.TestApplicationLimitsByPartition

hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesCapacitySchedDynamicConfig

hadoop.yarn.server.resourcemanager.TestKillApplicationWithRMHA

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3618/17/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3618

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets jsonlint xmllint

uname
Linux 964bb194f798 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 414fe8f254ae12f7db6580ae0cf5f450b82b6930

Default Java
Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3618/17/testReport/

Max. process+thread count
920 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3618/17/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 37s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  2s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+0 :ok:
jsonlint
0m  1s

jsonlint was not available.

+0 :ok:
xmllint
0m  1s

xmllint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 72 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
37m  4s

trunk passed

+1 :green_heart:
compile
0m 59s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
0m 51s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
checkstyle
1m  5s

trunk passed

+1 :green_heart:
mvnsite
0m 57s

trunk passed

+1 :green_heart:
javadoc
0m 58s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 48s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
2m  5s

trunk passed

+1 :green_heart:
shadedclient
21m 33s

branch has no errors when building and testing our client artifacts.

-0 :warning:
patch
21m 52s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 45s

the patch passed

+1 :green_heart:
compile
0m 50s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
0m 50s

the patch passed

+1 :green_heart:
compile
0m 43s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
javac
0m 43s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 50s
/results-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 126 new + 1158 unchanged - 6 fixed = 1284 total (was 1164)

+1 :green_heart:
mvnsite
0m 45s

the patch passed

+1 :green_heart:
javadoc
0m 42s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 38s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
1m 51s

the patch passed

+1 :green_heart:
shadedclient
21m 23s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
118m 23s
/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
hadoop-yarn-server-resourcemanager in the patch passed.

+1 :green_heart:
asflicense
0m 38s

The patch does not generate ASF License warnings.

216m 32s

Reason
Tests

Failed junit tests
hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacitySchedulerAutoCreatedQueuePreemption

hadoop.yarn.server.resourcemanager.scheduler.capacity.TestAbsoluteResourceConfiguration

hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacitySchedulerWeightMode

hadoop.yarn.server.resourcemanager.webapp.TestRMWebServiceAppsNodelabel

hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacitySchedulerNewQueueAutoCreation

hadoop.yarn.server.resourcemanager.scheduler.capacity.TestQueueParsing

hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesCapacitySched

hadoop.yarn.server.resourcemanager.scheduler.capacity.TestAMAllocatedToNonExclusivePartition

hadoop.yarn.server.resourcemanager.scheduler.capacity.TestNodeLabelContainerAllocation

hadoop.yarn.server.resourcemanager.TestRMRestart

hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacityScheduler

hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacitySchedulerSurgicalPreemption

hadoop.yarn.server.resourcemanager.scheduler.capacity.TestAutoCreatedQueueDeletionPolicy

hadoop.yarn.server.resourcemanager.TestApplicationMasterServiceCapacity

hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacitySchedulerNodeLabelUpdate

hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesForCSWithPartitions

hadoop.yarn.server.resourcemanager.scheduler.capacity.TestMixedQueueResourceCalculation

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3618/19/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3618

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets jsonlint xmllint

uname
Linux 3a710d202353 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 16a6351167dec072f5e8c43d0f4d2d1e5343c7d8

Default Java
Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3618/19/testReport/

Max. process+thread count
971 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3618/19/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 35s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  2s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
jsonlint
0m  0s

jsonlint was not available.

+0 :ok:
xmllint
0m  0s

xmllint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 72 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
44m 28s

trunk passed

+1 :green_heart:
compile
0m 58s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
0m 51s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
checkstyle
1m  3s

trunk passed

+1 :green_heart:
mvnsite
0m 55s

trunk passed

+1 :green_heart:
javadoc
0m 58s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 46s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
2m  0s

trunk passed

+1 :green_heart:
shadedclient
21m 19s

branch has no errors when building and testing our client artifacts.

-0 :warning:
patch
21m 38s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 46s

the patch passed

+1 :green_heart:
compile
0m 49s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
0m 49s

the patch passed

+1 :green_heart:
compile
0m 44s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
javac
0m 44s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 51s
/results-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 125 new + 1158 unchanged - 6 fixed = 1283 total (was 1164)

+1 :green_heart:
mvnsite
0m 44s

the patch passed

+1 :green_heart:
javadoc
0m 41s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 36s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
1m 48s

the patch passed

+1 :green_heart:
shadedclient
21m  5s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
602m 57s
/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
hadoop-yarn-server-resourcemanager in the patch passed.

+1 :green_heart:
asflicense
0m 37s

The patch does not generate ASF License warnings.

707m 38s

Reason
Tests

Failed junit tests
hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesCapacitySchedDynamicConfig

hadoop.yarn.server.resourcemanager.scheduler.capacity.TestApplicationLimitsByPartition

hadoop.yarn.server.resourcemanager.scheduler.capacity.TestLeafQueue

hadoop.yarn.server.resourcemanager.TestKillApplicationWithRMHA

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3618/18/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3618

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets jsonlint xmllint

uname
Linux a428a0adaf74 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 028101be0c17df9f0b320fb3be9a25784a622f6f

Default Java
Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3618/18/testReport/

Max. process+thread count
923 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3618/18/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Closing as the work was continued in a separate PR: #5783


ABC Io_ReadBlifMv for strings

ABC does not support reading/writing BLIF files from memory. This prevents us from skipping the filesystem and directly interfacing with ABC.
ABC's BLIF reading is implemented here (which corrosponds to the read_blif command).
It should be not too difficult to add a new function, e.g. Abc_FrameIoReadBlif, which reads BLIF from a file or string into the current framework instance. Abc_FrameIoWriteBlif should also be added to support writing the current network as BLIF to a file or buffer.

Yosys also does not support reading input from memory.
Currently, run_frontend is used to execute Yosys frontends such as read_verilog and read_blif -- which forces file I/O.


TAOCPP_PEGTL_KEYWORD does not compile

I'm trying to use TAOCPP_PEGTL_KEYWORD but it does not compile. I think the macro is missing something.
This is the offending code.
struct ARRAY : TAOCPP_PEGTL_KEYWORD("array") {};

I'm using version 2.0 installed via brew on macOS.
The compiler output can be found here: https://gist.github.com/agustingianni/2503c7f83c0ff9617bda0e74a51d52d5

D'oh! Yes, I missed two things: Writing a testcase for TAOCPP_PEGTL_KEYWORD and the fact that the macro uses empty intermediate values. And keyword<> is not valid, as a keyword always needs to have at least one character (unlike the empty string, which is allowed). I'll fix it in a minute...

Thank you very much!


Changes according to issue #349: Error in mpicc

We accepted all three of @hungpham2017 's changes mentioned in Issue #349.

Changes in kccsd_rhf.py and tril.py simply add stability for int operations.
Changes in in mpi_helper.py is also okay because Python3 does require relative imports to be explicit.

Changes have been merged, closing this issue. Please reopen if further issues arise.


Summary of Trends and Margins of Rural Grocery Stores Report

Look through the report document for both "Grocery Trends AGMRC report.docx" as well as "AGMRC Margins in the rural grocery store" and create a summary of the contents and the important sections. Place the notes into your OneNote notes section.


Allow code actions to add code above a C# block, no matter the directive

This is an alternative to https://github.com/dotnet/razor-tooling/pull/5752
It completely fixes https://github.com/dotnet/razor-tooling/issues/5747
It completely fixes https://github.com/dotnet/razor-tooling/issues/5675
Let me know what you think... it's probably not what you expect...

What if we built a system where it could always map edits?

Definitely an interesting idea, though difficult. Check out the AddDebuggerDisplay test, there is an whole using statement that we are throwing away from the code fix, and the edit doesn't come in neatly, it comes in across two different usings. There is also no guarantee where in the C# file it ends up - from _Imports.razor or from this file?

When Ajay tackled similar issues in the past he built a baselining system for tests where he'd copy/paste content and then have test magic do the rest

Yes, so the pain point here is twofold: Firstly I have to capture the edits, and since I was writing this code last night after 10pm I came up with a very innovative solution I should definitely patent: https://twitter.com/davidwengier/status/1461277716422881286
Secondly, the line and column numbers in the capture have to be translated to match the generated document that the test uses. I could probably do something programmatically to fix this, like adjusting the line numbers by some known amount, but column numbers get painful and so it was easier to just adjust them in place manually ¯_(ツ)_/¯
The reality is these tests give me zero confidence in our ability to apply code actions ongoing, but they do at least allow easy debugging of the code, and ensure there aren't specific regressions. Obviously the ideal is being able to say "hey roslyn, give me the new document after running this refactoring" and going from there.

Check out the AddDebuggerDisplay test, there is an whole using statement that we are throwing away from the code fix, and the edit doesn't come in neatly, it comes in across two different usings. There is also no guarantee where in the C# file it ends up - from _Imports.razor or from this file?

Super solid point, so basically it could be breaking content up across both code blocks which may be invalid in their own right. Hmmm.....

Firstly I have to capture the edits, and since I was writing this code last night after 10pm I came up with a very innovative solution I should definitely patent: https://twitter.com/davidwengier/status/1461277716422881286

lmao that's hillarious

I could probably do something programmatically to fix this, like adjusting the line numbers by some known amount, but column numbers get painful and so it was easier to just adjust them in place manually ¯_(ツ)_/¯

Totally reasonable!

Obviously the ideal is being able to say "hey roslyn, give me the new document after running this refactoring" and going from there.

+1

Gonna fix conflicts and merge this so I can work on https://github.com/dotnet/razor-tooling/pull/5770 without that PR getting huge. Feel free to comment on anything you see though @ryanbrandenburg and I'll follow up :)


M5Unified and Arduino 3.0 on Core2

Hello,
after running a few tests I realized that the M5Unified library is not compatible with Arduino 3.0 and IDF 5.1
I took the display example (https://github.com/m5stack/M5Unified/tree/master/examples/Basic/Displays), run it WITHOUT Arduino as a component and it works perfectly.
I then added Arduino and it stopped working:
Backtrace: 0x400d73f5:0x3ffb92f0 0x400e12e2:0x3ffb9360 0x40089ada:0x3ffb9380
0x400d73f5: lgfx::v1::LGFXBase::width() const at /esp/test/components/M5GFX/src/lgfx/v1/LGFXBase.hpp:311
(inlined by) setup() at /esp/test/main/test.cpp:233
0x400e12e2: loopTask(void*) at /esp/test/components/arduino/cores/esp32/main.cpp:59
0x40089ada: vPortTaskWrapper at /esp/esp-idf/components/freertos/FreeRTOS-Kernel/portable/xtensa/port.c:162
I tried to disable as many Arduino libraries as possible (SPI, Ethernet, SD, SPIFFS, OTA, WifiProv and so on) but the result is the same. Any operation on the display leads to a crash.
Does anybody have the same problem or any idea to where to start to inspect this problem?
Thank you

same as https://github.com/m5stack/M5Unified/issues/89
currently M5Unified is Arduino2 AFAICT

I wouldn't say it's the same as #89 and #90, maybe it's another issue to be put on the same line. At least the other 2 issues throw an error (and the #89 is quite easy to fix on a Core2, not sure about other devices). Mine shows absolutely nothing.
Truth be told, I was fine with the Core2 library and IDF 3.4.x. I just wanted to test the latest library with the latest IDF but I see it's a bit too early.
I'd gladly fix it, if only I could find where to start from.


Mongoid5 support

Hey, there's already a Mongoid5 beta - are you guys planning to support it?
If so, could I ask about a timeframe?

@mensfeld currently this gem is unmaintained, if you send a pull request we could merge it. Thanks

I work with @90yukke and hopefully he will do that tomorrow @ work ;)

@mensfeld perfect!!! @90yukke Thank you very much again. :+1: :smile:

Might be closed...  https://github.com/mongoid-rspec/mongoid-rspec/pull/149
But somehow 2.2.0 is requiring mongoid ~> 4.0.0 here!
Crazy, was working yeasterday! Grrrrr

Ops! We got a --pre now! Missed the readme hehe. TY!

Is it possible to release version with Mongoid 5.0.0 support ? :)

@vitalis i'm waiting for a @rodrigopinto, hope he will publish it to rubygems today.

@90yukke , @rodrigopinto thanks !!


ed25519 support?

For example now github recommends ed25519 format - https://docs.github.com/en/authentication/connecting-to-github-with-ssh/generating-a-new-ssh-key-and-adding-it-to-the-ssh-agent

+1

FYI, in practice, I've found that you can provide an ed25519 formatted key as the SSH_PRIVATE_RSA_KEY environment variable, and it will still work.


Using Albumentations with the cascade rcnn model yields "Type Error: impad() takes 1 positional argument but 2 positional arguments (and 1 keyword-only argument) were given

Thanks for your error report and we appreciate it a lot.
Checklist

I have searched related issues but cannot get the expected help.
The bug has not been fixed in the latest version.

Describe the bug
A clear and concise description of what the bug is.
Reproduction

What command or script did you run?

A placeholder for the command.

Did you make any modifications on the code or config? Did you understand what you have modified?
What dataset did you use?

Environment

Please run python mmdet/utils/collect_env.py to collect necessary environment information and paste it here.
You may add addition that may be helpful for locating the problem, such as

How you installed PyTorch [e.g., pip, conda, source]
Other environment variables that may be related (such as $PATH, $LD_LIBRARY_PATH, $PYTHONPATH, etc.)

Error traceback
If applicable, paste the error trackback here.
A placeholder for trackback.

Bug fix
If you have already identified the reason, you can provide the information here. If you are willing to create a PR to fix it, please also leave a comment here and that would be much appreciated!

How do you solve this problem？I encountered the same problem.

Same problem..waiting for solution


Use make_unique instead of reset

This is a more efficient approach

It is not more efficient; unlike make_shared there's no efficiency to be gained by involving the library in construction. However, it is nice. I think we avoided before because it's a C++17 feature.
Thanks!


univalue optimizations: move semantics, reduce temporary strings

Introducing move semantics for pushKV and push_back. In many use cases
the const& calls unnecessarily create a copy of the argument, when
objects can be moved this does not happen.

Reduce creation of temporary strings. json_escape and write now
appends to an existing string instead of creating a temporary.

Use std::to_string instead of std::ostringstream for setNumStr,
which is much faster than creating a temporary string.

In a benchmark with Bitcoin's BlockToJsonVerbose, using these move
methods where possible speeds up JSON generation by about a factor of 2.
You can see some benchmarks here: https://github.com/bitcoin/bitcoin/pull/20999

Closing the PR due to zero interest in the last 8 months.


Is there a naming error here?

Hello, I don’t have a deep understanding of the transformer structure, but I still want to ask if there is a naming error before and after. The feature of epipolar sampling was first named Q, but it was actually used as KV?

The code originally had the q and kv variable names flipped. That got fixed in this commit. Make sure you pull the latest code, since it fixes this issue and a few other small issues and has slightly better performance!


QueryCompiler breaks on netnative

Running Release mode in the UWP getting started guide results in

Property 'Count' was not found on type 'System.Collections.ArrayList'.

@rowanmiller for RC1, users will need to add this to their AppName.rd.xml file

<Type Name="System.Collections.ArrayList" Dynamic="Required All" />

Hi I am having the same issue with the .Net Native, i have this line present in the default.rd.xml

<Type Name="System.Collections.ArrayList" Dynamic="Required All" />

could you please suggest what i am missing ?

@MMalikKhan are you using RC1 or RC2 bits? Most of the issues with .NET Native have been fixed for RC2 and the workarounds explained here are no longer necessary, but we require version 1.3.1 of the Universal Windows App Development Tools which are included in Visual Studio 2015 Update 2.

@divega  based on the @natemcmaster reply here
i updated the packages to Rc-2 but i am still have issue with the same line of code.. not its compiling but the error is at run time..

I've got the same issue here, the app is compiling but fails at runtime.
UWA Development Tools version : 1.3.2
VS: 2015 Update 2
Target platform: 10586 (x86)
Microsoft.EntityFrameworkCore.Sqlite: 1.0.0-rc2-final
Microsoft.EntityFrameworkCore.Tools: 1.0.0-preview1-final
Default.rd.xml:
< Directives xmlns="http://schemas.microsoft.com/netfx/2013/01/metadata">
< Application>
< Assembly Name="Application" Dynamic="Required All" />
< Type Name="System.Collections.ArrayList" Dynamic="Required All" />

The exception occurs as soon as I'm doing .ToListAsync() on any DbSet.

Thanks @ViktorBergman. This was reported in a few places so I opened https://github.com/aspnet/EntityFramework/issues/5517 to track this.


Restrictive license

Is there any chance you might adopt a less restrictive license like MIT, BSD or APL? Current license prevents it from being used in any commercial projects which don't have open-source business model.

@extesy Could you provide more details? Note that LGPL is different from GPL and doesn't require derivative work to be open source. It is a permissive license, not restrictive

I've worked in several big companies and the conditions for using open source projects were almost always the same: if the license is MIT/BSD/Apache or comparable then I could use the library. Any *GPL license requires a long process involving corporate lawyers, business justification, paperwork, etc.
LGPL is better than GPL, that's true, but it's still in many cases inconvenient to use. Consider, for example, if I need to slightly tweak the library to accommodate our in-house implementation of thread pools which is used in all applications. With LGPL I have to make this tweak open-source. This might also mean open-sourcing our custom library too since it will be intertwined with our tweak. I think now you see the problem here.

@extesy Thanks for the additional information. I've opened a pull request (#85) to change the license to Apache.

Pull request merged.

Thank you for understanding, @fwbrasil!


[Sandbox] Ratify

Application contact emails
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>Project Summary
A verification engine on Kubernetes which enables verification of artifact security metadata and admits for deployment only those that comply with policies you create.
Project Description
Ratify is a workflow engine that coordinates the verification of different supply chain objects for an image as per a given policy. It is a verification framework that can use and coordinate any number of custom verifiers for things like signatures, SBoMs, vulnerability scan results, attestations, and so on. Ratify aggregates the results of these independent verifiers using a policy. This aggregated result can be used to make decisions in the admission controllers.
Org repo URL (provide if all repos under the org are in scope of the application)
https://github.com/deislabs (We are transferring Ratify to a new org https://github.com/ratify-project)
Project repo URL in scope of application
https://github.com/deislabs/ratify
Additional repos in scope of the application
https://github.com/deislabs/ratify-web
Website URL
https://ratify.dev/
Roadmap
https://github.com/deislabs/ratify/blob/staging/ROADMAP.md
Roadmap context
No response
Contributing Guide
https://github.com/deislabs/ratify/blob/staging/CONTRIBUTING.md
Code of Conduct (CoC)
https://github.com/deislabs/ratify/blob/staging/CODE_OF_CONDUCT.md
Adopters
https://github.com/deislabs/ratify/blob/staging/ADOPTERS.md
Contributing or Sponsoring Org
Microsoft
Maintainers file
https://github.com/deislabs/ratify/blob/staging/MAINTAINERS
IP Policy

[X] If the project is accepted, I agree the project will follow the CNCF IP Policy

Trademark and accounts

[X] If the project is accepted, I agree to donate all project trademarks and accounts to the CNCF

Why CNCF?
Ratify is an open and extensible verification framework for container images and other artifacts that can examine and use custom policies that users create to approve deployments in Kubernetes. We believe CNCF is a neutral home for Ratify because it has a flourish and active community can help the future success of Ratify through the development of third-party integrations.
Benefit to the Landscape
Ratify's mission is to safeguard the container supply chain by ratifying trustworthy and compliant container images and other software artifacts. As a open framework in CNCF security & compliance area, Ratify is designed with different interface models to allow for its integration at different stages of the containers secure supply chain. Ratify has already collaborated and integrated with some CNCF projects and provide joint solutions to CNCF ecosystem users.
Cloud Native 'Fit'
Ratify enables users to verify artifact security metadata (signatures and attestations including vulnerability reports, SBOM, provenance data, and VEX documents) prior to deployment in Kubernetes clusters and admit for deployment only those that comply with an admission policy that users create.
With Ratify, cloud-native workloads can be verifiable on deployment, eventually increase the security posture of cloud-native ecosystem users.
Cloud Native 'Integration'
Notary Project, OPA Gatekeeper, Trivy (non-CNCF), ORAS, Sigstore Cosign (OpenSSF)
Cloud Native Overlap
To our knowledge, there isn't any direct overlap with other CNCF projects today.
Similar projects
Connaisseur, Kyverno
Landscape
We will create a PR to add Ratify to the CNCF Landscape in April.
Business Product or Service to Project separation
Azure Kubernetes Service has developed a managed addon based on the Ratify project for customers. The development and roadmap of the open-source project and the managed addon have always remained entirely separate, and that will continue to be true going forward.
In addition, Venafi CodeSigning and AWS Signer have related managed services that support Ratify as a verification engine.
Project presentations
We finished a presentation in TAG Security on Apr 24. Here is the Ratify slide deck that we used for CNCF TAG Security Presentation - Ratify.pdf
Project champions
@lachie83
Additional information
No response

Here are the slides that we presented in the CNCF TAG Security review meeting on Apr 24:
CNCF TAG Security Presentation - Ratify.pdf

Looks like there's a new github org https://github.com/ratify-project/ratify (spun out from deislabs!)

Is gatekeeper a mandatory dependency or an optional one? I ask because of the comparison drawn with Connaisseur and Kyverno.
Do all 3 of the folks that seem to do the majority of the commits work for MSFT? (wasn't sure about BinBin Li), Are there upcoming members of the community who could do more? (poking at mentoring aspects!)

Looks like there's a new github org https://github.com/ratify-project/ratify (spun out from deislabs!)

@dims  Yes. Ratify has been transferred from Microsoft-owned GitHub organization to a neutral org recently. The GitHub repo can be automatically redirected to the new URL.

Is gatekeeper a mandatory dependency or an optional one? I ask because of the comparison drawn with Connaisseur and Kyverno.

Currently, Gatekeeper is a core dependency in Kubernetes admission control scenario only. Ratify does not rely on Gatekeeper in other scenarios, such as CLI mode for CI/CD and verification at container runtime (containerd, docker).

Do all 3 of the folks that seem to do the majority of the commits work for MSFT? (wasn't sure about BinBin Li), Are there upcoming members of the community who could do more? (poking at mentoring aspects!)

The majority of commits and contributors are from MSFT so far. AWS, Venafi, and Alibaba adopt Ratify as a part of their solutions so we would expect more members and contributors come from these organizations in the future. This is the motivation and reason for Ratify's donation to CNCF in order to build a vendor-neutral community.

TAG Security recommendation to TOC
Project Overview
Ecosystem Adoption
Ratify has seen engagement with open source projects including ORAS, Notary, and Sigstore. In addition, there has been adoption by vendors such as AWS Signer, Azure Kubernetes Service Image Integrity, and Venafi CodeSign Protect.
Past TOC Reviews
N/A (Sandbox)
Security Reviews
TAG Security Assessments
N/A: We recommend performing a TAG Security Self Assessment.
Security Audit
N/A
Best Practices
Metrics
Ratify achieves 8.4 in OpenSSF Scorecards, which is a great score for a project at this maturity level.
Static Analysis
Ratify has implemented conformance testing.
Sub-project Considerations
N/A
TAG Recommendation to the TOC
Ratify provides a verification framework that integrates with a number of open source projects, with opportunities to integrate with more projects in the supply chain space to provide a single tool for verification. TAG Security would recommend that the TOC move forward with accepting the project into sandbox, with a few recommendations for the project to consider as they mature and move through future CNCF levels:

Performing a TAG Security self assessment as the project moves toward incubation.
Moving vulnerability reporting to a maintainers mailing list or using the Github reporting capabilities rather than going through the Microsoft Security Response Center
Adding the OpenSSF Best Practices badge as another metric to track maturity of security posture (https://www.bestpractices.dev/en).

TAG Security recommendation to TOC
Project Overview
Ecosystem Adoption
Ratify has seen engagement with open source projects including ORAS, Notary, and Sigstore. In addition, there has been adoption by vendors such as AWS Signer, Azure Kubernetes Service Image Integrity, and Venafi CodeSign Protect.
Past TOC Reviews
N/A (Sandbox)
Security Reviews
TAG Security Assessments
N/A: We recommend performing a TAG Security Self Assessment.
Security Audit
N/A
Best Practices
Metrics
Ratify achieves 8.4 in OpenSSF Scorecards, which is a great score for a project at this maturity level.
Static Analysis
Ratify has implemented conformance testing.
Sub-project Considerations
N/A
TAG Recommendation to the TOC
Ratify provides a verification framework that integrates with a number of open source projects, with opportunities to integrate with more projects in the supply chain space to provide a single tool for verification. TAG Security would recommend that the TOC move forward with accepting the project into sandbox, with a few recommendations for the project to consider as they mature and move through future CNCF levels:

Performing a TAG Security self assessment as the project moves toward incubation.

Moving vulnerability reporting to a maintainers mailing list or using the Github reporting capabilities rather than going through the Microsoft Security Response Center

Adding the OpenSSF Best Practices badge as another metric to track maturity of security posture (https://www.bestpractices.dev/en).

Thanks for the support and recommendations from TAG security!Ratify now uses GitHub security advisory reporting process and working on the OSSF Best Practices badge.
In addition, we made some progress for Ratify supply chain security enhancements after the TAG Security review meeting.  @akashsinghal will be able to share some details.

Since Ratify's presentation to the TAG Security in May, the Ratify community has been working on addressing TAG Security's feedback on vulnerability management, versioning, and supply chain metadata for release/dev assets:

Ratify has now adopted Github's vulnerability reporting feature. Guidance is defined here
Ratify now has a clearly defined release versioning guidance here. This includes guidance on vulnerability patching on supported versions (read here). The project has since released 2 patch versions for the last supported minor release version to address severity alerts that were raised by periodic scanners the project has added + Dependabot.
Ratify community has formulated a plan to generate supply chain metadata for all assets including development and release. This effort includes SBOM, SLSA Provenance, and signatures for all release binaries, container images, and development helm charts. Read about the proposal here. Ratify has already added SBOM + Provenance attestations to all images published moving forward, as well as added SBOM generation for release binaries. All development container images/charts are now being signed using cosign + notation.

We appreciate the TAG Security's recommendations!

TAG Contributor strategy has reviewed this project and found the following:

The contributor guide is above average, containing notes on development environments and testing.  They also have a reviewing guide, and a release process.
Ratify has no written governance, yet.
The roadmap is a milestone-organized list of feature goals, and appears to have been created for the 1.2 release.
There are six maintainers,  all of whom work for Microsoft.
Ratify also has a deprecation policy, marking the first time I've seen one in a Sandbox applicant.

This review is for the TOC’s information only.  Sandbox projects are not required to have full governance or contributor documentation.

Hi @jberkus, thanks for your review comments.
Regarding the following comment:
Ratify has no written governance, yet.

This repo https://github.com/ratify-project/.github under ratify project listed more documents including https://github.com/ratify-project/.github/blob/main/GOVERNANCE.md.  Thanks.

Update per above:

Ratify has a Maintainer Council type governance comprised of Org Owners and Subproject Owners.  While not completely documented, it's a good start for a sandbox project.

Might I suggest adding links to those documents to your main README?  Like me, new contributors aren't going to look in .github for a governance doc.

Thanks @jberkus. I've submitted a PR https://github.com/ratify-project/ratify/pull/1713 to implement the changes you suggested.

/vote

/check-vote

/check-vote

The vote is passed and closed. May I know what the next step is? Should we start to transfer project trademarks and website hosting (Netlify) to CNCF?

The vote is passed and closed. May I know what the next step is? Should we start to transfer project trademarks and website hosting (Netlify) to CNCF?

The next step is that CNCF staff will open a project onboarding issue for Ratify (based on this template: https://github.com/cncf/toc/blob/main/.github/ISSUE_TEMPLATE/project-onboarding.md) - this may take a few days due to summer vacations. If you would like to start looking at the items on that list now, then you will be ready when the issue is opened. Thanks!

Welcome and congrats on getting accepted as a CNCF Sandbox project!
You can get started on your on-boarding checklist here: https://github.com/cncf/toc/issues/1412
and if you have any questions, please don't hesitate to reach out!

With https://github.com/cncf/toc/issues/1412 created we can go ahead and close this out :)
Congrats again!


chore: upgrade vm-browserify to 1.0.1

vm-browserify up until 1.0.1 depends upon unlicensed code. [0][1] This means
node-libs-browser does too. This resolves the issue by upgrading it. All
changes in between were non-breaking. [2]
[0] https://github.com/browserify/browserify/issues/1828
[1] https://github.com/component/indexof/issues/6
[2] https://github.com/browserify/vm-browserify/releases

@opichals There is no difference in dependencies between 1.0.1 and 1.1.0.

Any chance of getting this merged soon?
Thx,
J

Thanks


rubocops/patches: autocorrect some offenses

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.

[x] Have you successfully run brew typecheck with your changes locally?
[x] Have you successfully run brew tests with your changes locally?

This PR adds autocorrection for some cops dealing with patches (this was marked as a TODO).
I'm still (i) checking if anything else can be autocorrected here (ii) working on tests for the autocorrection. Note: this PR will be affected by (or) affect #10760.

Review period will end on 2021-03-05 at 07:12:38 UTC.

Review period ended.

Thanks @nandahkrishna!


[SPARK-5912] [docs] [mllib] Small fixes to ChiSqSelector docs

Fixes:

typo in Scala example
Removed comment "usually applied on sparse data" since that is debatable
small edits to text for clarity

CC: @avulanov  I noticed a typo post-hoc and ended up making a few small edits.  Do the changes look OK?

Test build #27862 has started for   PR 4732 at commit 3f3f9f4.

This patch merges cleanly.

@jkbradley Thank you! I am OK with these fixes

I just added a Java example, copied from your Scala example & modified for Java.  I've run it, and it works.

Test build #27865 has started for   PR 4732 at commit 9656a3b.

This patch merges cleanly.

Test build #27862 has finished for   PR 4732 at commit 3f3f9f4.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
  case class Params(

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27862/
Test PASSed.

Test build #27865 has finished for   PR 4732 at commit 9656a3b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27865/
Test PASSed.

LGTM. Merged into master and branch-1.3. Thanks!