Download non-video files from Udemy

Please follow the guide below

You will be asked some questions and requested to provide some information, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your issue (like that [x])
Use Preview tab to see how your issue will actually look like

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2016.04.01. If it's not read this FAQ entry and update. Issues with outdated version will be rejected.

[ x] I've verified and I assure that I'm running youtube-dl 2016.04.01

Before submitting an issue make sure you have:

[ x] At least skimmed through README and most notably FAQ and BUGS sections
[ x] Searched the bugtracker for similar issues including closed ones

What is the purpose of your issue?

[ ] Bug report (encountered problems with youtube-dl)
[ ] Site support request (request for adding support for a new site)
[ ] Feature request (request for a new functionality)
[ x] Question
[ ] Other

The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your issue

This is just a question about downloading non-video files from Udemy. On Udemy there are some lectures that are text only. I can download video files fine but when it gets to a part of "chapter" that is not a video the script quits with ERROR: Lecture xyz is not a video. Is there a workaround for this? I'm fine not actually downloading these so is there a way to say when it's not a video file skip it and continue to the next one?

This issue is already fixed and fix will be incorporated in the next version of youtube-dl. For now you enforce ignoring errors with -i.

I encountered the same problem with a video containing text-courses... When passing the -i flag it gets one step further and then fails on ERROR: 'NoneType' object has no attribute 'copy'
But if it'll get fixed on next release I can probably wait. ETA?


The AerSimulator is imported from incorrect package.

Where is the problem?
https://learn.qiskit.org/course/introduction/the-atoms-of-computation
Describe the problem
In the "Your first quantum circuit" section the package that is used to import the AerSimulator is incorrect.
Expected behavior
Instead of importing the AerSimulator from qiskit.providers.aer it should be imported from qiskit_aer. At least this is what works locally.

I'm interested in contributing to this matter and would appreciate guidance on locating the resource at https://learn.qiskit.org/course/introduction/the-atoms-of-computation.

Hi @SahilDahat I just opened a PR. Could you please review: https://github.com/Qiskit/textbook/pull/70

I am closing the issue as the pull request has been merged.


Cleanup global settings and user settings.

Use Django 1.9 template for a new settings file. Remove the deprecation warning. Support Django 1.10.

Done with #2373.


Switching between table and tree is not focusing the table/tree

Testing #150750

Open problems view with some entries in tree mode
Select a problem
Switch to table mode
Navigate using up and down arrow
🐛 Nothing happens

/verified


gpg sign pr failed

Description
Create pr then squash commit the pr

I will get 500 error page.
gitea log:
2023/03/29 16:40:49 ...dules/git/command.go:255:Run() [D] /tmp/gitea/local-repo/pull.git3269640365: /usr/bin/git -c protocol.version=2 -c credential.helper= -c filter.lfs.required= -c filter.lfs.smudge= -c filter.lfs.clean= commit --author='tosone<EMAIL_ADDRESS>--message=feat: update read config (#6)

	Co-authored-by: Tosone<EMAIL_ADDRESS>	Reviewed-on: https://git.tosone.cn/smallforest/EmailManager/pulls/6 -S095A8273BDB3304E1B7327859B64EDC2801F197B
2023/03/29 16:40:49 ...pull/merge_squash.go:41:doMergeStyleSquash() [E] git commit PR[7]smallforest/EmailManager#6[main...tosone]: exit status 128

	error: gpg failed to sign the data
	fatal: failed to write commit object

2023/03/29 16:40:49 ...ers/web/repo/pull.go:1084:MergePullRequest() [E] Merge: git commit [smallforest/EmailManager:tosone -> smallforest/EmailManager:main]: exit status 128

	error: gpg failed to sign the data
	fatal: failed to write commit object

in the gitea container I try to create a test repo and commit with gpg:

gitea conf:
[server]
APP_DATA_PATH     = /data
[repository.signing]
SIGNING_KEY = default
SIGNING_NAME = Tosone
SIGNING_EMAIL =<EMAIL_ADDRESS>MERGES = always
INITIAL_COMMIT = always
WIKI = always
CRUD_ACTIONS = always

.gitconfig
[user]
	name = Tosone
	email =<EMAIL_ADDRESS>	signingKey = 095A8273BDB3304E1B7327859B64EDC2801F197B
[commit]
	gpgsign = true
[core]
	quotePath = false
	commitGraph = true
	logAllRefUpdates = true
[receive]
	advertisePushOptions = true
	procReceiveRefs = refs/for
[gc]
	writeCommitGraph = true
	reflogExpire = 90
[fetch]
	writeCommitGraph = true
[safe]
	directory = *
[uploadpack]
	allowfilter = true
	allowAnySHA1InWant = true

env
USER_UID=1000
CHARSET=UTF-8
HOSTNAME=gitea
GNUPGHOME=/data/home/.gnupg
PWD=/
USER_GID=1000
HOME=/root
LANG=C.UTF-8
TERM=xterm
USER=git
SHLVL=1
LC_COLLATE=C
PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
GITEA_CUSTOM=/data/gitea
_=/usr/bin/env

Gitea Version
v1.19
Can you reproduce the bug on the Gitea demo site?
No
Log Gist
No response
Screenshots
No response
Git Version
No response
Operating System
No response
How are you running Gitea?
in docker container
Database
PostgreSQL

I tested squash commit with gpg sign and looks like it works well. I noticed that you used /data/home/.gnupg as GNUPGHOME in your envs. Maybe the git user doesn't have write permission for this directory (I'm not sure). Could you please change GNUPGHOME  to /data/git/.gnupg and test again?

sorry for the late. you are right, the reason is permission.
GNUPGHOME=/data/home/.gnupg
but the directory permission like this:
-rw-r--r--    1 git      git            425 Mar 29 16:40 .gitconfig
drwx------    4 root     root          4096 Mar 29 16:44 .gnupg

chown -R git:git ./.gnupg/
everything will be ok.
/data/git/.gnupg as GNUPGHOME is not necessary.


add schema name in debug logging content; add master-slave ut case for package gdb

Codecov Report
Base: 76.51% // Head: 76.56% // Increases project coverage by +0.04% :tada:

Coverage data is based on head (485cbd9) compared to base (63c3e83).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2249      +/-   ##
==========================================
+ Coverage   76.51%   76.56%   +0.04%
==========================================
  Files         582      582
  Lines       48389    48394       +5
==========================================
+ Hits        37027    37055      +28
+ Misses       9334     9315      -19
+ Partials     2028     2024       -4

Flag
Coverage Δ

go-1.15-386
76.58% <100.00%> (+0.08%)
:arrow_up:

go-1.15-amd64
76.58% <100.00%> (+0.06%)
:arrow_up:

go-1.16-386
76.58% <100.00%> (+0.05%)
:arrow_up:

go-1.16-amd64
76.57% <100.00%> (+0.03%)
:arrow_up:

go-1.17-386
76.60% <100.00%> (+0.08%)
:arrow_up:

go-1.17-amd64
76.61% <100.00%> (+0.07%)
:arrow_up:

go-1.18-386
76.53% <100.00%> (+0.08%)
:arrow_up:

go-1.18-amd64
76.51% <100.00%> (+0.08%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

database/gdb/gdb_core.go
72.24% <100.00%> (+0.30%)
:arrow_up:

os/gfsnotify/gfsnotify_watcher.go
81.51% <0.00%> (-2.53%)
:arrow_down:

os/gfsnotify/gfsnotify_watcher_loop.go
87.39% <0.00%> (+1.68%)
:arrow_up:

frame/gins/gins_database.go
57.14% <0.00%> (+2.52%)
:arrow_up:

os/gfpool/gfpool_file.go
68.57% <0.00%> (+2.85%)
:arrow_up:

database/gdb/gdb.go
67.37% <0.00%> (+3.20%)
:arrow_up:

database/gdb/gdb_core_config.go
68.06% <0.00%> (+3.36%)
:arrow_up:

database/gdb/gdb_model.go
75.00% <0.00%> (+4.87%)
:arrow_up:

frame/g/g_object.go
56.25% <0.00%> (+6.25%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Docz to work with Create React App webpack config

Situation
There is a project I work with, that is set up via Create React App with Typescript support. The choice was to use Docz to setup live documentation for components implemented in it.
Problem
Components that were working nicely in CRA, were not working in Docz. The reason was different way of handling SVG files between those two project. That was the initial reason, there might be  more differences.
Solution
To modify Gatsby's webpack config, I went with steps from here https://www.gatsbyjs.org/docs/add-custom-webpack-config. I extracted babel-loader rule config from CRA webpack and injected it in Gatbsy's config, replacing the its babel-loader rule.
Following code is specific Typescirpty. For e.g. pure JS 'tsx' could be replaced with 'jsx' or some more generic code that works with all possible cases.
// gatsby-node.js
exports.onCreateWebpackConfig = ({ actions, getConfig }) => {
    const webpackConfig = getConfig();
    copyBabelLoaderRuleFromCRAtoGatsby(webpackConfig);

    actions.replaceWebpackConfig(webpackConfig)
};

function copyBabelLoaderRuleFromCRAtoGatsby(gatsbyWebpackConfig){
    const createCRAWebpackConfig = require('../node_modules/react-scripts/config/webpack.config.js');
    const webpackConfigOfCRA = createCRAWebpackConfig('');
    const craRuleBabelLoader = webpackConfigOfCRA.module.rules.find(rule => rule.oneOf).oneOf
        .find(rule => String(rule.test).includes('tsx') && rule.loader.includes('babel-loader'));

    gatsbyWebpackConfig.module.rules = [
        ...gatsbyWebpackConfig.module.rules.filter(rule => String(rule.test) !== String(/\.tsx?$/)),
        {
            test: /\.tsx?$/,
            loader: craRuleBabelLoader.loader,
            options: craRuleBabelLoader.options
        }
    ];
}

Feature request / Feature suggestion
I'm new do Docz and to Gatsby, so it took me a heap of time to figure it out, and implement the workaround. I think it would be nice to have solution working out-of-the-box, e.g. Docz takes CRA's webpack config automatically (Storybook and Styleguidist do this). If that is not feasible, it would be nice to have some words in documentation or maybe even example with create-react-app updated.
The reason I'm posting it here, not on Gatsby repo is because it is not obvious why would anyone mix two technologies like Gatsby and CRA. I can imagine the value in it is not clear, in contrast to  mixing Docz and CRA.

Hey @chmurson,
docz should be able to work with create-react-app out of the box in JS projects and for TS projects by adding typescript: true to your doczrc.js file.
Could you share an example for what you mean by different svg files handling ?

Hey @rakannimer,
The reason is because CRA supports following way of loading svgs
import { ReactComponent as Logo} from './logo.svg';

//somewhere in render function

<Logo/>

more info: https://create-react-app.dev/docs/adding-images-fonts-and-files/#adding-svgs
The above method does not work in Docz. The reason is because CRA uses some custom babel loader that does it. One of the workarounds for this is (apart of not using the above syntax) solution posted in first post.
I've managed to replicate the issue on forked Docz repo: https://github.com/chmurson/docz. Please take a look at the modified example: https://github.com/chmurson/docz/tree/master/examples/create-react-app-ts. The Alert components renders in CRA but does not in Docz.

FYI for those who end up here, this can be fixed by installing gatsby-plugin-svgr and adding to the gatsby-config.js like so plugins: ['gatsby-plugin-svgr']. After doing that you should be able to do import { ReactComponent } from 'some.svg';

FYI for those who end up here, this can be fixed by installing gatsby-plugin-svgr and adding to the gatsby-config.js like so plugins: ['gatsby-plugin-svgr']. After doing that you should be able to do import { ReactComponent } from 'some.svg';

It looks like gatsby-plugin-svgr doesn't process .mdx files by default,  so i open a PR
before the PR merged, you can copy the gatsby-plugin-svgr source code, and follow gatsby: developing-a-local-plugin-that-is-outside-your-project

FYI for those who end up here, this can be fixed by installing gatsby-plugin-svgr and adding to the gatsby-config.js like so plugins: ['gatsby-plugin-svgr']. After doing that you should be able to do import { ReactComponent } from 'some.svg';

It looks like gatsby-plugin-svgr doesn't process .mdx files by default,  so i open a PR
before the PR merged, you can copy the gatsby-plugin-svgr source code, and follow gatsby: developing-a-local-plugin-that-is-outside-your-project


Add other shapes and non-WE stuff

Extra stuff thats not strictly WE, but useful anyways

[ ] Spheres/balls
[ ] Pyramids/prisms (basically /draw command shapes)
[ ] In-game help menu
[ ] Maybe some of Firigion's shapes and stuff?

im thinking that this should be in the brush tool functionality

man, you need to have a spray-paint for sure

maybe even with cool visual effect!


Move render-store recipe to the Performance category

Nice and now we don't need to remove that category.


[ Link ] : Self Hosting Link

Merging w/ https://github.com/DamianSwanAAJHS2/sillylittle.selfhost/pull/1


Trivial print out change

An error message now contains a command that we can copy-paste directly to powershell
vcpkg update   =>      .\vcpkg update
Adding two slashes to escape the output

Hi @o-mdr, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

Before

After

@o-mdr  If vcpkg is in PATH environment(like me), I think the ".\vcpkg" would fail.

At least it would be consistent with all the examples on the readme and /doc/EXAMPLES.md
Otherwise, some commands are prefixed with \. and others not.

Thanks for this.
@sdcb While we definitely think adding vcpkg to your path is the best experience, our official new user documentation instructs users to run vcpkg directly from the repository. For those users, I've personally seen how common it is to forget to add .\. Once you've added us to your path, I think it's safe to assume you know to drop the .\ as appropriate ;).


Ability to report only certain components of a metric

For example, in GraphiteReporter, a Timer reports max, mean, min, stddev, etc.  It would be nice if you could enable/disabled each of these.
I've started this as a bitmask implementation, but I'm realized that won't be able to cover any custom components that someone might add.  Maybe Timer should have some kind of getReportableComponents() that returns an enum.  That way if someone subclasses an existing Metric class like Timer, they can also subclass the enum.  Thoughts?

This has become an extremely common request, and I've reopened #178 to track it. This is now on the roadmap for v4 as the proper way to do it will introduce breaking changes.

Sorry, I didn't notice that when I searched the existing issues.

No apology necessary!


Add game option for Artifacts

We need to add a game option to enable Artifacts, and we need to update the code to respond to this selection.

kahlia already made the digging respond to the game option.
The big thing left here are to make the artifact piles disappear (both from the UI and the database) when they are not in play.


Strict ownership scheme and new change notifications

Currently same model and collection can be assigned to attributes of many models.
It will work fine, however it may cause problems when saving and restoring them to/from JSON. We have some detection mechanics for that, firing warnings on serialization. First - its too late, second - it's confusing.
We need to distinguish references from aggregation in very strict and clear way:

When simple aggregation is used - only one "owner" will be allowed. Attempt to assign it to another model attribute must result in error or warning (you have to deep clone an object for that).
Nested changes will be detected for aggregated objects only. It will allow us to remove backbone events from the change detection core, making it very efficient.

It's very dangerous change, so all consequences must be carefully analysed in advance. Compromise solution might be to allow marking some objects as non-serializable, thus suppressing the warnings. It won't allow us to do item (2), though.

So.

Model.from() and Collection.subsetOf() can be used to define generic references, which are excluded from serialization (.has.toJSON( false )). Other semantic should be exactly the same as for normal subsetOf and from.
Generate "non-seralizable" warning on the moment of attribute/collection element assignment.

Seems to be the best solution so far. Implement it first, think about change event optimizations later.

Don't forget to handle attributes assignments.
When one aggregated attr is being assigned to another, it might be deep cloned automatically instead of the warning. It's safe default behavior, and it's semantically correct.

Fixed in develop.


Documentation and View Layout Design are done

Basic set up for .gitignore is done as well. For now, keep the config directory as no-ignored. We will see how it would affect, but don't think it will make things quite complicated for this project.
Please check it out: the marking scheme and current status for stage 1 - https://github.com/wono/SoundBox/blob/wono/DEV_NOTE.txt
Cheers,
Wonho
Wonho Lim<EMAIL_ADDRESS>

Please pull from the master before you create a pull request - this merge can't be automatically performed. Contact me on skype if you need me for something.


Python3x vs Python3xFull # package name change in 2016 vs standardized semantic - adopt to standard python semantic

Describe the bug
The python package in nixpkgs which is most equivalent to the original Python[38] https://www.python.org/ should be called via pkgs.python[38]
Adapt the standardized way of naming/semantic with Python in nixpkgs.
The current Naming/Semantic of Python in nixpkgs is against the usual/standardized way of calling Python

this is a root cause of confusion and leads to unexpected behaviour and errors

Like in the discussion in 2016 the minimal python should NOT be called python because that leads to confusion and mishandling
Additional context
see as well an issue example where pkgs.python38 does not know about the pkgs cuts that have been placed on it in nixpkgs.
-> that seems easy to workaround (like installing nixpkgs tkinter) if the environment is very small and without further tooling from nixos/nixpkgs ecosystem but can high complexity in an advanced environment within other tools of the nix ecosystem like mach-nix - as to say it makes debugging way more complex if the interpreter does not know about "packages installed" with are not installed
To Reproduce
In NixOs/nixpkgs
pkgs = import (fetchTarball https://github.com/nixos/nixpkgs/archive/nixos-20.09.tar.gz) {}  # "rev": "502845c3e31ef3de0e424f3fcb09217df2ce6df6"
pkgs.python38.buildInputs
# [ "bzip2-<IP_ADDRESS>.1" "expat-2.2.8" "gdbm-1.18.1" "libffi-3.3" "ncurses-6.2" "openssl-1.1.1i" "readline-6.3p08" "sqlite-3.33.0" "xz-5.2.5" "zlib-1.2.11" ]

pkgs = import (fetchTarball https://github.com/nixos/nixpkgs/archive/nixos-20.09.tar.gz) {}
pkgs.python38Full.buildInputs
# [ "bluez-5.55" "bzip2-<IP_ADDRESS>.1" "expat-2.2.8" "gdbm-1.18.1" "libX11-1.6.12" "libffi-3.3" "ncurses-6.2" "openssl-1.1.1i" "readline-6.3p08" "sqlite-3.33.0" "tcl-8.6.9" "tk-8.6.9" "xorgproto-2019.1" "xz-5.2.5" "zlib-1.2.11" ]

e.g. tkinter is not contained in pkgs.python38 (but it is an essential part the original Python[38] https://www.python.org/)
-> the naming as pkgs.python[38] is misleading because it is build to NOT represent the original Python[38]

but pkgs.python[38]Full tries to represent the original Python[38] -> that's why this package should be called pkgs.python[38] in nixpkgs
the shortened packages version of python should be called minimal because that was one of the main reasons for the change in 2016

the technology standard could be seen as well at docker

there you have the original Python[38] called python:3.8
and besides that there are manipulated/shortened Python variants (e.g. due to reasons of size) - those get a suffix like -slim e.g. python:3.8-slim

docker run --rm -it python:3.8       python -c "import tkinter; print(tkinter.__name__) "
vs:
docker run --rm -it python:3.8-slim  python -c "import tkinter; print(tkinter.__name__) "
Expected behavior
If a developer uses NixOS/nix/nixpkgs he/she expects to get a derivative (most adequate to) the original Python[38] when calling pkgs.python[38] (not the minimal version of python)
I know that the size then will be a big bigger, but thats shouldn't be any issue for keeping the general naming convention - e.g. the pkgs.python[38] can be renamed to pkgs.python[38]-slim
Notify maintainers
@fridh
Maintainer information:
# a list of nixos modules affected by the problem
module:
- python38
- python38Full

This issue has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/python3x-vs-python3xfull-package-name-change-in-2016-vs-standardized-semantic-adopt-to-standard-python-semantic/10896/1

This issue has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/python3x-vs-python3xfull-package-name-change-in-2016-vs-standardized-semantic-adopt-to-standard-python-semantic/10896/1

closing for the same reasons as mentioned in https://github.com/NixOS/nixpkgs/issues/108840#issuecomment-759107333 - there's no consensus, and we should keep these discussions in the Discourse Thread

closing for the same reasons as mentioned in https://github.com/NixOS/nixpkgs/issues/108840#issuecomment-759107333 - there's no consensus, and we should keep these discussions in the Discourse Thread


fleetctl: Give DEBUG print if need wait for launch when start unit

When start unit, if [X-Fleet] give peer by "MachineOf=", the
fleetctl cannot know the exact reason. Only fleetd check the peer.
But still we can give a DEBUG print to inform launch is happing.
It's not the problem that the peer is not existing. After the
peer is running, the fleetctl will go on to the end. So just
add a debug print if --debug=true is given to fleetctl.
Fixes #1146

LGTM, thanks @wuqixuan


[decopmiler] create output folder

Pull Request Test Coverage Report for Build 546392304

0 of 1 (0.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.002%) to 67.843%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

decompiler/main.cpp
0
1
0.0%

Totals

Change from base Build 546323095:
-0.002%

Covered Lines:
27933

Relevant Lines:
41173

💛  - Coveralls


com.theartofdev.edmodo.cropper.CropImageActivity was not found in the project or the libraries

app/src/main/AndroidManifest.xml#L185
Missing registered class: Class referenced in the manifest, com.theartofdev.edmodo.cropper.CropImageActivity, was not found in the project or the libraries

fixed I believe. thx @VaiTon


⚠ ClamAV has degraded performance

In 414e187, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 86 ms

Resolved: ClamAV performance has improved in 05d6f6e.


Push Notifications: Generate local notifications based on /sync result.

tfheen has been investigating fixing the privacy leaking problems that we currently have on iOS by needlessly passing the msg bodies of all push notifications to Apple. would it be possible to look into generating notifications as Local Notifications based on the result of the /sync triggered by the APNS push, rather than displaying the actual APNS push?

See also https://github.com/matrix-org/synapse/issues/1540. This is quite a major security issue.

Looked into this a bit, because I did not think it's possible, but my knowledge was outdated, and it is indeed possible. http://stackoverflow.com/questions/11861117/can-push-notifications-be-used-to-run-code-without-notifying-user

With release of iOS 7 this is finally possible using Remote/Silent notifications. They work same as Push notifications but instead of alerting the user immediately they can fire up background fetch mode and upload/download new content.
Here is simple tutorial: http://www.objc.io/issue-5/multitasking.html


feat: support ESM bundle

This PR generally follows https://gist.github.com/sindresorhus/a39789f98801d908bbc7ff3ecc99d99c that it provides a wrapper for ESM instead of compiling TypeScript twice for different module targets in order to avoid dual package hazard.

After a second thought, don't think the benefit is worth the complexity. Will be replaced by https://github.com/luin/ioredis/pull/1521


Fullscreen Dialogs/AlertDialogs show isDismissable & variant icons in bottom right corner

🐛 Bug Report
Inside a <DialogTrigger type="fullscreen">, a Dialog with isDismissable or an AlertDialog with any variant that adds an icon to the header is rendered with the close "X" button or the icon in the bottom right corner.
🤔 Expected Behavior
The close button and these icons should be hidden with CSS or not rendered. Maybe a JS warning can let users know these patterns aren't supported.
😯 Current Behavior
The button/icon renders in the bottom right corner of the dialog.

💁 Possible Solution
See "expected behavior".

🔦 Context
I have a dialog that has large, complex content which is also has dismissible. AlertDialog seemed like the right component to use but I found that it doesn't support different sizes to support this large content.

💻 Code Sample
<DialogTrigger type="fullscreen">
    <ActionButton>Press me</ActionButton>
    <AlertDialog variant="warning" title="Warning" primaryActionLabel="Confirm">
        Test
    </AlertDialog>
</DialogTrigger>

🌍 Your Environment

Software
Version(s)

react-spectrum
v3

Browser
Chrome v84

Operating System
Mac OSX 10.14.6

🧢 Your Company/Team
Adobe Experience Platform

I think you need to use a Dialog here, not an AlertDialog. AlertDialog does not have a fullscreen variant. Also fullscreen dialogs don't support isDismissible. You need to put a button group in the dialog with a button to close it.

Thanks @devongovett, I'm now using a Dialog instead. I raised this issue just to let you know that some weird CSS appears that we could prevent.

I guess we might be able to target the icons to hide them. We should probably add to the docs that these cases are not supported too.

Putting that in the docs would have been most helpful for me, I was looking for exactly that.


Release

100% code coverage
100% javadoc
100% package-info.java
0.0% garbage

moved to javaslang-parser


Please add png icon

Can you add icon in PNG format for use in desktop file? Now stlink menu entry has blank icon and it is not good.
It should be 512x512 picture.

Feel free to submit a PR, I only run OS X desktop.

And it has no any icon on OS X?

Its just an CLI application, no GUI

I've added PR #708 to make the first step. I don't know CMake, so there is work needed.


GitHub Workflows security hardening

This PR adds explicit permissions section to workflows. This is a security best practice because by default workflows run with extended set of permissions (except from on: pull_request from external forks). By specifying any permission explicitly all others are set to none. By using the principle of least privilege the damage a compromised workflow can do (because of an injection or compromised third party tool or action) is restricted.
It is recommended to have most strict permissions on the top level and grant write permissions on job level case by case.

Docs Build status updates of commit c1b3f29:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.github/workflows/stale.yml
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

@SyntaxC4
Can you review the proposed changes? IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

I've added @MikeRayMSFT to investigate.

Any updates?

@sashashura - thanks for the submission. I'm closing the pull request for now.
I'm pulling the changes over to the private repo first. We'll review and verify, and then the changes will propagate back to the public site. Thanks . #please-close


gc: make tool to debug active references for a piece of content

It may be hard to tell why certain resources are still held when interacting ctr. Make a tool that lists references for a given piece of content.

@stevvooe @dmcgowan is this still a necessity?

@Akaame yes

@stevvooe @mikebrow I see from the content flow documentation that containerd.io/gc.ref.content labels are placed on content to hold references to other pieces of content. For this case, would other resources like snapshots and leases have to be checked for these reference labels as well?


Feedback for: engine/admin/formatting.md

File: engine/admin/formatting.md, CC: @mstanleyjones
Just to let you know that the example for the join template function doesn't work:
$> docker ps --format '{{join .Names " or "}}'
Template parsing error: template: :1:7: executing "" at <.Names>: wrong type for value; expected []string; got string

For information:
 docker version
Client:
 Version:      1.13.1
 API version:  1.26
 Go version:   go1.7.5
 Git commit:   092cba3
 Built:        Wed Feb  8 06:50:14 2017
 OS/Arch:      linux/amd64

Server:
 Version:      1.13.1
 API version:  1.26 (minimum version 1.12)
 Go version:   go1.7.5
 Git commit:   092cba3
 Built:        Wed Feb  8 06:50:14 2017
 OS/Arch:      linux/amd64
 Experimental: false

@vieux @vdemeester any ideas?

Hum, this won't work on ps (and any ls command I think) for now. Almost any field of those command (Names,Labels, …) return a string (and do their own join behind the scene). I think the example should be done on inspect commands only for now.
But I think we need to fix that in the engine 👼 too.

Okay no problem, it's just the the documentation page explicitly uses docker ps for the example, this is why.
I perfectly understand that it's just easy to switch command an try in inspect. But I know for a fact (hanging on IRC #docker) that Go templates are a mystic creature for a lot of people, so they avoid it like the pleague. I think if they find good, nice example on this doc page, it might help spread the love.
But if the first example that they come across doesn't event work, I'm afraid they go "damn ,if even the docker devs can't get it right, I'm staying away from this magic" :)
Anyway, thanks for the answers in the short delays, as usual, congrats guys!

@nschoe yep, completely agreeing with you. We should update this example.

I've looked into this, this is not actually not easy to find an actual value from the inspection that returns a list of string ^^
Most often, this returns a maps with key:value. So.... I'll let you guys handle this :D

Claimed.

Shouldn't this work for other docker commands like images?
C:\> docker image ls --format "{{join .Repository ':' }}"
Template parsing error: template: :1:7: executing "" at <.Repository>: wrong type for value; expected []string; got string


[PROTOCOL-419] [L08] Naming hinders code understanding and readability

It is:

Renamed names of the functions and contracts for better readability

Keep the naming of supplyToDebt and inverse the ratio for the calculation.
Rename all interfaces to be prefixed with I (ex: IBaseProxy.sol) instead of the postfix Interface (ex: BaseProxyInterface.sol)

Done dawg

Keep the naming of supplyToDebt and inverse the ratio for the calculation.
Rename all interfaces to be prefixed with I (ex: IBaseProxy.sol) instead of the postfix Interface (ex: BaseProxyInterface.sol)

Done dawg


Phony.plausible? returns true for non-plausible German number

Important fact: Phony only works with international phone numbers. It needs the country code to be able to identify the number's country and rules.
What I did
For any number other than German, when adding two country codes to the number, the Phony.plausible? check returns true
*
What happened
For number `"+49+491505632832", Phony.plausible? returns true
*
What I expected to happen and why
I would expect to return false, like it does for other country codes
*

@ademdinarevic Hi! Thanks for the issue – would you want to try improving this? I think it succeeds/fails because of the length. It should probably check if the number is in a general good state and perhaps raise in a case like this, so the user of the gem can fix their code.


chore: add font licenses

This PR adds LICENSE files for the fonts we leverage, as well as a NOTICE file in the project root to explain the the licenses

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Binary exponentiation in Java

Description
Binary exponentiation (also known as exponentiation by squaring) is a trick which allows to calculate an using only O(logn) multiplications (instead of O(n) multiplications required by the naive approach).
Domain
Competitive Programming
Type of Contribution
Documentation
Code of Conduct

[X] I follow Contributing Guidelines & Code of conduct of this project.

/aasign

Please assign this issue to me.

/assign

/assign

Please add hacktoberfest accepted label too on this PR


When registering new task, also provide problem matcher

Hi,
I need enhanced options to handle my compilation errors and the current ProblemMatcher json definition doesn't give me the options I need.
I thought the best way is when defining a new Task to also have the option to register a new ProblemMatcher with it, or maybe even have the option to register ProblemMatcher.
I also commented on the post #57015 but I thought this request deserves a separate post.
Also, will you receive a pull request regarding adding such feature?
BTW, my use case is both operating in a Windows system with a Linux build server and having a build system which only gives the file name in the error path.

I am not sure what you requesting. Supporting registering a problem matcher in code will not provide more power since it will still be limited to regular expressions.
I think what you are asking for is that a task can intercept the task output and write its own matcher. Is this correct ?

I am still don't understand what you are requesting. Can you provide me with an example?

Sure, currently when I receive compilation error, it looks like this:
random_file.c:84:18: error: \x used with no following hex digits
In the build server random_file.c is under /home/admin/demo_project/internal_folder/random_file.c
I'm executing a build command from a Windows machine which executes the command on my Linux build system.
Also random_file.c location for vscode is C:\projects\demo_project\internal_folder\random_file.c
So I have here 2 issues:

The build system only outputs the file name and not the complete file path
And even if I overcame the first issues, vscode still expects to receive the Windows file path and not the Linux path

To tackle this issues, if I can have a custom uriProvider/problem matcher where I can do my own file finding logic, I'll be able to locate the file.

But how would that work using regular expression. You want to execute code. Right?

Yep, I want to execute code during the file finding stage.

I will mark as a dup of https://github.com/Microsoft/vscode/issues/11663 since this ask for solving the same problem.

It's indeed similar.
For the sake of completion below is an output example I need to handle:
gmake[3]: Entering directory /home/admin/modules/ide/proxyis/is/util'
[Thu Sep 13 15:35:28 IDT 2018] Start doing VANILLA variation...
gcc   -DDEBUG -g  -fpic -DDYNAMIC_COMP -Wall -Wno-parentheses -Wno-unreachable-code -Wno-write-strings -Wno-comment -Wno-sign-compare -Wno-unknown-pragmas -Wno-unused -Wno-deprecated-declarations -Wno-misleading-indentation -Wno-trigraphs -Wno-switch -Wno-format -Werror -pipe -march=i686 -Dlinux50 -DARCH_STR='"linux50"'  -fdiagnostics-show-option -I/home/admin/modules/ide/proxyis/include -fno-strict-aliasing -fno-common -fno-omit-frame-pointer -Dlinux -DUNIXOS=1  -c -Wdeclaration-after-statement -Wno-implicit-function-declaration -Wno-pointer-sign -o linux50/debug.dynamic/classify.o classify.c
classify.c: In function 'destroy_info':
classify.c:129:2: error: expected expression before 'if'
if (((clsf_node_t *)clsf)->mime)
^~
classify.c:129:2: error: 'return' with a value, in function returning void [-Werror]
classify.c:124:1: note: declared here
destroy_info(void *clsf)
^~~~~~~~~~~~
cc1: all warnings being treated as errors
gmake[5]: *** [linux50/debug.dynamic/classify.o] Error 1`
As you can see the issue is in classify.c.
It's Linux path is /home/admin/modules/ide/proxyis/is/util/classify.c - this is where it's compiled
In the error line I only get classify.c
And the path vscode know is: C:\modules\ide\proxyis\is\util\classify.c


[@azure/service-bus] Websocket connection failed with react native polyfills

Package Name: @azure/service-bus
Package Version: 7.7.1
Operating system:
[ ] nodejs

version:

[ ] browser

name/version:

[x] react-native

name/version: 0.70.1

[x] typescript

version: 4.8.3

Is the bug related to documentation in

[x] README.md
[ ] source code documentation
[ ] SDK API docs on https://docs.microsoft.com

Describe the bug
I'm trying to run the service-bus client on a react native client. As suggested by the @azure/service-bus readme, I installed polyfills for the node core modules. I tried two ways:

manually resolving used packages to polyfills

//babel.config.js
module.exports = {
  presets: ['module:metro-react-native-babel-preset'],
  plugins: [
    [
      'module-resolver',
      {
        alias: {
          crypto: 'crypto-browserify',
          process: 'process/browser',
          os: 'os-browserify/browser',
          dns: '@i2labs/dns',
          stream: 'stream-browserify',
          buffer: 'buffer',
          path: 'path-browserify',
        },
      },
    ],
  ],
};
}

Shimming with rn-nodeify

rn-nodeify --install process,path,os,stream,buffer,crypto,net,tls,assert --hack

Both attempts result in the following WebSocket error:
ServiceBusError: Websocket connection failed.
    at construct (native)
    at Wrapper (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=...:23518:64)
    at construct (native)
    at _createSuperInternal (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=...:188184:406)
    at call (native)
    at MessagingError (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=...:188733:27)
    at construct (native)
    at _createSuperInternal (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=...:112719:406)
    at call (native)
    at ServiceBusError (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=...:116955:29)
    at translateServiceBusError (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=...:116997:33)
    at ?anon_0_ (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=...:122197:59)
    at throw (native)
    at asyncGeneratorStep (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=...:24748:26)
    at _throw (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=...:24774:29)
    at tryCallOne (/Users/distiller/react-native/sdks/hermes/build_iphonesimulator/lib/InternalBytecode/InternalBytecode.js:53:16)
    at anonymous (/Users/distiller/react-native/sdks/hermes/build_iphonesimulator/lib/InternalBytecode/InternalBytecode.js:139:27)
    at apply (native)
    at anonymous (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=...:31334:26)
    at _callTimer (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=...:31234:17)
    at _callReactNativeMicrotasksPass (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=...:31269:17)
    at callReactNativeMicrotasks (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=...:31477:44)
    at __callReactNativeMicrotasks (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=...:2869:46)
    at anonymous (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=...:2647:45)
    at __guard (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=...:2852:15)
    at flushedQueue (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=...:2646:21)
    at callFunctionReturnFlushedQueue (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=...:2628:33)

React Native does bring Websocket natively, so I was assuming to have similar, if not the same environment as in browsers, thus using browser polyfills. I'm a little clueless at this point though.
Thanks for any help.

By the way: The list of used core modules to polyfill in the readme is not correct because the package seems to use more core modules, i.e. crypto, dns, stream. Might add those to the readme.

Label prediction was below confidence level 0.6 for Model:ServiceLabels: 'Service Bus:0.46679074,Azure.Core:0.23571692,Storage:0.0883106'

@proohit Thank you very much for investigating and reporting the issue!  React-Native is not officially supported yet by our SDK.  We have https://github.com/Azure/azure-sdk-for-js/issues/5771 adding the support.  Currently a couple packages are working fine in the Android emulator after adding polyfills.  The messaging SDKs (service-bus/event-hubs) are in my plan to look into next.  Previously a known blocker is our underlying dependency rhea's react-native support.

@jeremymeng Thank you for your efforts, that sounds promising!
When the readme says to support browsers, what exactly is missing in react native? JavaScript Core has a lot of functionality + babel polyfills to align to web standards, including fetch and WebSockets over TCP. As far as I understand, the service-bus client doesn't use any specific web APIs, thus it should work on react native as well.
I can't tell for sure but the polyfills I included should not be using any specific web APIs as well. Plus that's the whole idea behind rn-nodeify, even if it may be outdated today. At least it gets to the point where a connection via WebSockets is attempted.

When the readme says to support browsers, what exactly is missing in react native?

I don't know the exact gap until I try it first. I haven't tested our service bus package on react-native.  One example of issues we hit previously was that fetch api on react-native doesn't support stream.
You are right that service-bus client doesn't use any specific web APIs other than the websocket support.  We pass some websocket options to the underlying library (rhea) and don't really manage the connection ourselves.  Our library does allow overriding the websocket implementation via options:
https://github.com/Azure/azure-sdk-for-js/blob/074b7d557f81d22fc89abaf271e7b59c18416a0e/sdk/core/core-amqp/src/ConnectionContextBase.ts#L203
We have a sample showing how to use the ws module's websocket implementation in order to set the proxy agent.  Maybe worth a try to see if ws works in react-native?  I will check it out too.

Sounds good. Though I would suggest something like https://github.com/heineiuo/isomorphic-ws, because it supports NodeJs and browsers (via global.Websocket), so in theory should work in RN too. I don't know if global.Websocket is defined in react-native, but that fix should be as easy as global.Websocket = Websocket.
If the override in rhea works and the APIs match, that should work.

@proohit I just tried using "ws" in react-native. Unfortunately, react-native packager seemed to prefer the browser version and gave me this error.
I looked at isomorphic-ws but it looks just a wrapper around "ws" and browser WebSocket and it doesn't support constructor options, which we allow users to pass in.

Yes they don't wrap browser WebSocket, but instead suggest to evaluate by OR https://github.com/websockets/ws/issues/714#issuecomment-226181823 . So to speak default to a global WebSocket, if available.

@proohit I found something during my investigation: react-native's WebSocket.binaryType by default is undefined, which is blocking rhea from behaving properly when running in browser.  I will create an expo sample project where I got service-bus to send messages on Android Emulator. If you want, you can try and see whether this solves the connection issue you were seeing:
class WebSocketWrapper {
  constructor(...args) {
    const instance = new globalThis.WebSocket(...args);
    instance.binaryType = "blob";
    return instance;
  }
}

// then pass it via options

  const sbClient = new ServiceBusClient(connectionString, {
    webSocketOptions: {
      webSocket: WebSocketWrapper,
    },
  });

This worked! Got some incompatibilities with react-native-tcp and react-native-udp, but those are not related to this issue. After fixing all those, communication to service-bus was successful. Though, I would wish for a cleaner solution, without polyfilling almost all of node modules and being dependent on many (also outdated) dependencies.

@proohit glad to hear that you got it running!  Curious did you test on real hardware too, or just emulator?
Yes, some nodejs modules are not really used when running in browsers.  However, since in previous versions, they are all required by the commonjs version, react-native packager or bundler would report error if they are not found during build time.   We just merged a PR to allow importing asynchronously #23524.  With this, we may be able to reduce the number of polyfills needed.

I tested it on the simulators, but it only worked on iOS due to some old bridge libraries on android. As I said this has nothing to do with azure sdk, but it would be great not to be dependent on polyfills as much. Your PR looks promising and I'm eager to find out which polyfills you want to include! Have you got some examples for the mappings?

Amazing! Looking forward!

@proohit it's possible to reduce the polyfills required to five packages

buffer
path-browserify
process
os-browserfify
react-native-get-random-values

so the steps to add them are:

yarn add  buffer os-browserify path-browserify process react-native-get-random-values
Modify metro.config.js

module.exports = {
  resolver: {
    extraNodeModules: {
      buffer: require.resolve('buffer/'),
      path: require.resolve('path-browserify'),
      process: require.resolve('process/browser.js'),
      os: require.resolve('os-browserify/browser.js'),
    },
  },
  // ...
}

App.tsx before importing Azure Service Bus SDK

global.Buffer = require('buffer').Buffer;
global.process = require('process');

import 'react-native-get-random-values';

I am closing this issue as the sample runs fine.  Please let us know if you have further questions.


Chapter 7 - Section "Create the client" - Interface implementation mismatch Nullable vs. Not nullable

In the API definition the Categories API si defined as
public async Task<List<Category>> GetCategoriesAsync()
NOTICE: Result not nullable
But in the implementation in this WebBlazorWeb.Client is implemented
public async Task<List<Category>?> GetCategoriesAsync()
NOTICE: Result nullable

It should be non nullable, a good practice is to never return null when returning a collection.
Is this in the book as well, or only in the source code?

For the moment, only in the code.
But is confusing, because in the book is declared as not nullable public async Task<List<Category>> GetCategoriesAsync()but later you process null returning values Items = (await _api.GetCategoriesAsync()) ?? new();


EntityBean instances are leaked from pool on certain exceptions

Proposed fix for https://issues.jboss.org/browse/WFLY-4569 (entity beans not returning to the pool on certain exceptions).
This pull requests contains the fix itself and set of integration tests to validate its logic.

Can one of the admins verify this patch?

this is ok to test

Linux with security manager Build 1296 is now running using a merge of f3eadd96d84dabc0a8b9c6c866ccfd5fe52720fd

Windows Build 1448 is now running using a merge of f3eadd96d84dabc0a8b9c6c866ccfd5fe52720fd

Linux Build 6368 is now running using a merge of f3eadd96d84dabc0a8b9c6c866ccfd5fe52720fd

Linux with security manager Build 1296 outcome was SUCCESS using a merge of f3eadd96d84dabc0a8b9c6c866ccfd5fe52720fd
Summary: Tests passed: 826, ignored: 358 Build time: 0:05:58

Linux Build 6368 outcome was SUCCESS using a merge of f3eadd96d84dabc0a8b9c6c866ccfd5fe52720fd
Summary: Tests passed: 2868, ignored: 414, muted: 1 Build time: 0:46:54

Windows Build 1448 outcome was SUCCESS using a merge of f3eadd96d84dabc0a8b9c6c866ccfd5fe52720fd
Summary: Tests passed: 2869, ignored: 414 Build time: 0:49:14

We require that all contributions be made under the terms of the MIT License, http://www.opensource.org/licenses/mit-license.php. Do you agree to the these terms?

Looks OK to me.

We require that all contributions be made under the terms of the MIT License, http://www.opensource.org/licenses/mit-license.php. Do you agree to the these terms?

Yes, sure, I’m agree with these terms.
I’ve just used the same template for new files as other existing WildFly files - I do understand, that contributions to the codebase may require MIT-style license in order to be used in releasing of EAP or other products as well.
Thanks,
Alexey

Great, thanks.


Improve behavior of BIO_s_mem when NOCLOSE is set

BIO_s_mem instances have a propensity to leak.  This was returned from a recent valgrind run in an application I was working on:
==1007580== at 0x483C815: malloc (vg_replace_malloc.c:431)
==1007580== by 0x2C2689: CRYPTO_zalloc (in /home/vien/microedge-c/test)
==1007580== by 0x295A17: BUF_MEM_new (in /home/vien/microedge-c/test)
==1007580== by 0x295A78: BUF_MEM_new_ex (in /home/vien/microedge-c/test)
==1007580== by 0x28CACE: mem_new (in /home/vien/microedge-c/test)
==1007580== by 0x285EA8: BIO_new_ex (in /home/vien/microedge-c/test)
==1007580== by 0x231894: convert_pubkey_ECC (tpm2_driver.c:221)
==1007580== by 0x232B73: create_ephemeral_key (tpm2_driver.c:641)
==1007580== by 0x232E1F: tpm_gen_keypair (tpm2_driver.c:695)
==1007580== by 0x22D60A: gen_keypair (se_driver_api.c:275)
==1007580== by 0x21FF35: generate_keypair (dhkey.c:142)
==1007580== by 0x24D4C8: __test_dhkey (dhkey_test.c:55)
The problem is described in detail in the changelogs, but the executive summary is that:
a) When BIO_NOCLOSE is set on the BIO, if the user hasn't retrieved the BUF_MEM structure via BIO_get_mem_ptr or BIO_set_mem_ptr, it will leak
b) It is counter-intuitive that a call to BIO_get_mem_data doesn't assign ownership of the data pointer to the caller, leading, as when BIO_NOCLOSE is set, the application also must call BIO_[get|set]_mem_ptr to prevent a BUF_MEM leak, or worse, encounter a double free in the event that the pointer returned from BIO_get_mem_data is considered by the application to be orphaned when BIO_CLOSE is set.
This patch series is an attempt to reconcile those problem and create a more intuitive user experience
Checklist

[x] documentation is added or updated
[x] tests are added or updated

The need CLA tag is because the email address used here doesn't match the one on your ICLA.  Your ICLA used a gmail address and this appears to use a corporate one.

Ah, crap, sorry about that, had my gitconfig setup for my old job.  Let me
reopen the pr with a fixed history.  Thanks for the heads up!
On Thu, Aug 10, 2023, 6:09 PM Pauli @.***> wrote:

The need CLA tag is because the email address used here doesn't match the
one on your ICLA. Your ICLA used a gmail address and this appears to use a
corporate one.
—
Reply to this email directly, view it on GitHub
https://github.com/openssl/openssl/pull/21717#issuecomment-1673981138,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAH4FXR3I7B2BQPLYOXUT5DXUVLYVANCNFSM6AAAAAA3MB756E
.
You are receiving this because you authored the thread.Message ID:
@.***>

You don't need to close this.  The author can be changed: https://www.git-tower.com/learn/git/faq/change-author-name-email

@paulidale oh yes, of course I'm going to do that.  I had just assumed the bot checkers would have me close and reopen, I'll force push a filtered branch shortly


Add directory to support installing in a different directory than 'package-name'

Closes #230
TODOs

[ ] Write tests for it: no test fails when I introduce these changes, I need to write tests where the directory key is something completely different to the package name
[ ] Migrations in registry: how to add them ? I need to add a column to the packages table.

Hi @poliorcetics, this looks like it will mess up the import system a lot to me; have you considered the implications of this change?
My main question here is what is the benefit of decoupling the protobuf import path with the buffrs package name? And if there is a benefit, isn't the scenario solvable by refactoring the underlying protos/adapting the build system?

Hi @mara-schulke. I have been looking into buffrs and it really looks very promising. However, I'm also suffering from the fact that the package statements don't allow dashes, while buffrs Proto.toml files require them.
As pointed out many times by others, this forces one to:

name a package in Proto.toml as e.g. name = api-examples-hub
name the same package in the .proto file as package api_examples_hub
import that package as import "api-examples-hub/foo.proto"
refer to its types as api_examples_hub.Type

From your comments, it seems that this is actually a feature in your setup. Maybe I misunderstand how you are using buffrs in your organization. My suspicion is that you aren't using hierarchical names. Is that the case? If not, why this restriction? Simply allowing . in the Proto.toml name would solve the problem, right?

Hi @dgehriger, yes I agree with the beauty of hierarchical package definitions! The problem with the proposed solution (as much as id like to implement it) is that it silently introduces ambiguity in which packages control which namespace in the generated code.
Ie. imagine that we have two packages org.foo and org.foo.bar - if the buffrs package name partially overlap and correspond directly to their protobuf package declaration this introduces unclarity on which buffrs package now owns defining org.foo.bar.Type because it could be defined in the org.foo package (as a subpackage) or in org.foo.bar toplevel.
So what I'm trying to point out is: If you introduce hierarchy into package names and allow the owned namespaces of buffrs packages to overlap, you can cause very nasty incompatibilities between packages that won't compile anymore: Imagine both of the example packages declaring the same org.foo.bar.Type – if you install both buffrs packages and try to compile them all it will brick.
The easy solution we went here (instead of doing rather complex analysis of package contents to verify they don't declare any subpackages or overlapping types) is to bind the buffrs package name to its very own protobuf package scope. This is pretty much inspired from rust fwiw.
I'm pretty sure that there is a design that does both? But we haven't had the time to implement this properly so far and there would be a unclear ROI of this feature as it is mostly cosmetics (for Helsing) - for companies trying to port over existing hierarchical apis this does look different. I'm happy for any PRs on this!

Edit: If you are only talking about the directory that buffrs installs its files into yes that is infact right. The reason we have not implemented this change is that there have been plans on enforcing the alignment of the protobuf package names with the buffrs one.
Currently this is only a lint (see buffrs lint) and not something that prevents you from publishing but I would very much advise against starting with this for the aforementioned reasons.
So it's best to align protobuf package name and buffrs package name for disambiguating types and preventing compilation errors - further allowing the buffrs package name to diverge from the protobuf package name in the current way things are implement would only worsen the problem.
So recapping the above:

I'm happy for this to change IF there are strict rules for the contents of a package
All considerations were taken to ensure this is not yielding a more painful user experience (ie. not being able to define subpackages can get pretty annoying in big projects)

@mara-schulke Thank you very much for your detailed answer. I went ahead and implemented a possible solution (opt-in) in github.com/helsing-ai/buffrs/pull/251. Let me know what you think!

@mara-schulke : I totally get your point about the ambiguity arising from using nested packages. My ultimate goal is to be able to us buf for linting. I'll update this thread later today with my proposed repository layout to make that work.


Torquebox 3.1.1 download link redirect to 404

Following link http://torquebox.org/release/org/torquebox/torquebox-dist/3.1.1/torquebox-dist-3.1.1-bin.zip will redirect you to not existing page (404).

For now I've taken the CDN out of the loop which has downloads working again. Now to figure out what's up with the CDN.

Closing this since downloads have been working for a few weeks.


DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-archive-test-target/pull/923 is merged into live branch.
Auto archive content to https://github.com/opstest2/docs-archive-test-target.git

Docs Build status updates of commit 6594c7a:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error-GitBranchDeletedOrForcePushed] Cannot sync git repo to specified commit because branch Release_Archive_master_2021-06-25-04-03-03 has been deleted or has been force pushed

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Preprocessor directives in regent

Is there anyway we can use preprocessor directives in regent?
In C we use something like "#ifdef macro_name", can we do something like this in regent?

The top level of a Regent program is Lua. You can do something like:
if macro_name then
  task asdf() ... end
else
  task asdf() ... end
end

Or even:
function make_asdf_task(some_param, some_other_param)
  local task asdf() ... end
  return asdf
end
local asdf1 = make_asdf_task(a, b)
local asdf2 = make_asdf_task(c, d)

You can see the section "Metaprogramming" in the Regent reference for more details. http://regent-lang.org/reference/

Okay sir. Thank you.


Failing with HA 2023.8

I use the HA container and I just updated from 2023.7 to 2023.8 and noticed that this integration is no longer working.
In 2023.8 I see that Python 3.10 has been removed; now HA uses Python 3.11
I see an error log No module named 'hijri_converter' and notice that this module has also been deprecated in favour of hijridate.
I'm not super familiar with python or I'd help out
Logger: homeassistant.setup
Source: deps/lib/python3.11/site-packages/holidays/utils.py:20
First occurred: 6:25:04 PM (1 occurrences)
Last logged: 6:25:04 PM

Setup failed for custom integration ontario_energy_board: Unable to import component: No module named 'hijri_converter'
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/setup.py", line 215, in _async_setup_component
    component = integration.get_component()
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/loader.py", line 813, in get_component
    ComponentProtocol, importlib.import_module(self.pkg_path)
                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/importlib/__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "<frozen importlib._bootstrap>", line 1204, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1176, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1147, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 690, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 940, in exec_module
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "/config/custom_components/ontario_energy_board/__init__.py", line 8, in <module>
    from .coordinator import OntarioEnergyBoardDataUpdateCoordinator
  File "/config/custom_components/ontario_energy_board/coordinator.py", line 8, in <module>
    import holidays
  File "/config/deps/lib/python3.11/site-packages/holidays/__init__.py", line 13, in <module>
    from holidays.countries import *
  File "/config/deps/lib/python3.11/site-packages/holidays/countries/__init__.py", line 18, in <module>
    from .azerbaijan import Azerbaijan, AZ, AZE
  File "/config/deps/lib/python3.11/site-packages/holidays/countries/azerbaijan.py", line 18, in <module>
    from holidays.utils import islamic_to_gre
  File "/config/deps/lib/python3.11/site-packages/holidays/utils.py", line 20, in <module>
    from hijri_converter import convert
ModuleNotFoundError: No module named 'hijri_converter'

Are you running the latest version (0.3.5, as of today)?

That is correct, I have version 0.3.5. I verified that I have the changes from cecc226 but I'm still seeing that log message and the integration is failing to load.

Can you try again with release v0.3.6? I added the hijri_converter package to the dependencies list.

Verified. I redeployed the 2023.8 HA container with v0.3.6 and it works thank you.
FYI: I had to redeploy HA 2023.8 to test this as I've since upgraded to HA 2023.10 and v0.3.5 started working 🤷 (I meant to update the issue about that sorry). So maybe it was just an incompatibility between the 2023.8 container and v0.3.5 but not an issue with later container versions. Again 🤷, either way 2023.8 and v0.3.6 work 👍


[BUG] Producer for nodejs client for confluent kafka not sending events to KOP

Describe the bug
Producer code for nodejs (node-rdkafka) is not able to send events to KOP
The nodejs client does not call KafkaCommandDecoder.channelRead method to send events.
I am using following code for Producer
const path = require('path');
const kafka = require('node-rdkafka');

var listener = "localhost:9092";
var topic = "persistent://tenant1/testnm/topic1";

    const producer = new kafka.Producer({
        'bootstrap.servers': listener
      });

    producer
      .on('ready', () => {

        for (let idx = 0; idx < 30; ++idx) {
            const key = 'my_key';
            const value = Buffer.from(JSON.stringify({ count: idx }));

            console.log(`Producing record ${key}\t${value}`);

            producer.produce(topic, -1, value, key);
          }

          producer.disconnect();

      })
      .on('event.error', (err) => {
        console.warn('event.error', err);
        reject(err);
      });

    producer.connect();

The nodejs client does not call KafkaCommandDecoder.channelRead method to send events.

How do you come to this conclusion?
It would be helpful to upload your broker's debug logs.


fix: 带总/小计的交叉表复制报错

👀 PR includes
🐛 Bugfix

[x] Solve the issue and close #0

🔧 Chore

[x] Test case

📝 Description
带总/小计的交叉表

点选总/小计单元格，cmd+c 报错
点选总/小计所在的行列，cmd+c 报错 或数据复制不全

🖼 Screenshot

Before
After

🔗 Related issue link

🔍 Self Check before Merge

[ ] Add or update relevant Docs.
[ ] Add or update relevant Demos.
[ ] Add or update relevant TypeScript definitions.

:tada: This PR is included in version @antv/s2-v1.17.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


eval issue

Thank you for your outstanding work! I'd like to ask, do you strictly adhere to the evaluation process of shine-mapping when assessing the results of the code? In other words, do you use eval/evaluator.py in shine-mapping to quantitatively estimate the reconstruction results in the paper?

Hi,
As we mentioned that we did not use the crop_intersection.py before.
For the left setting, we do the same evaluation process of shine-mapping.

thank you！


JSONFileLoader: dedent unnecessary code inside context manager

Apologies in advance for the fact that I can't explain exactly why this change should be merged. It comes about because we were seeing intermittent OSError: [Errno 9] Bad file descriptor errors being raised by botocore in our CI suite under Python 3, which runs tests in parallel using multiprocessing:
   File "<censored>", line 71, in mock_s3
     s3 = botocore.session.get_session().create_client('s3')
   File "/usr/local/lib/python3.6/site-packages/botocore/session.py", line 828, in create_client
     endpoint_resolver = self._get_internal_component('endpoint_resolver')
   File "/usr/local/lib/python3.6/site-packages/botocore/session.py", line 695, in _get_internal_component
     return self._internal_components.get_component(name)
   File "/usr/local/lib/python3.6/site-packages/botocore/session.py", line 903, in get_component
     self._components[name] = factory()
   File "/usr/local/lib/python3.6/site-packages/botocore/session.py", line 155, in create_default_resolver
     endpoints = loader.load_data('endpoints')
   File "/usr/local/lib/python3.6/site-packages/botocore/loaders.py", line 132, in _wrapper
     data = func(self, *args, **kwargs)
   File "/usr/local/lib/python3.6/site-packages/botocore/loaders.py", line 420, in load_data
     found = self.file_loader.load_file(possible_path)
   File "/usr/local/lib/python3.6/site-packages/botocore/loaders.py", line 175, in load_file
     return json.loads(payload, object_pairs_hook=OrderedDict)
 OSError: [Errno 9] Bad file descriptor

I tried for days to pin this down, and eventually just tried the change I've made in this PR, so that the file descriptor is not left open for as long. Amazingly, that fixed the issue and we haven't seen another error of this type since.
The code is equivalent, so this has no effect on the correctness of the load_file method. I'm hoping this is an acceptable change so that we don't need to monkeypatch botocore anymore! And if anyone has an idea as to what could possibly be causing this, I would be extremely grateful 😄.

Codecov Report

Merging #1971 into develop will decrease coverage by 0.08%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #1971      +/-   ##
===========================================
- Coverage    92.73%   92.64%   -0.09%
===========================================
  Files           53       53
  Lines        10293    10172     -121
===========================================
- Hits          9545     9424     -121
  Misses         748      748

Impacted Files
Coverage Δ

botocore/loaders.py
99.24% <100%> (-0.04%)
:arrow_down:

botocore/model.py
97.82% <0%> (-0.25%)
:arrow_down:

botocore/docs/bcdoc/restdoc.py
96.26% <0%> (-0.17%)
:arrow_down:

botocore/validate.py
98.74% <0%> (-0.07%)
:arrow_down:

botocore/compat.py
96.36% <0%> (-0.05%)
:arrow_down:

botocore/docs/bcdoc/style.py
95.45% <0%> (-0.04%)
:arrow_down:

botocore/paginate.py
97.8% <0%> (-0.03%)
:arrow_down:

botocore/signers.py
98.08% <0%> (-0.03%)
:arrow_down:

botocore/awsrequest.py
97.54% <0%> (-0.03%)
:arrow_down:

... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa0c243...00e9567. Read the comment docs.


reported the reproduced result for PL (AVOD) without LiDAR supervision.

As far as I know, LiDAR supervision is mainly used to generate ground truth depth maps.
So, if PSMNet does not use LiDAR supervision, how to modify it?
Can you tell me more detail about it?
I would be very grateful to you！

If you mean the reproduced result for PL (AVOD) is our paper, what we mean is that we do not use LiDAR points in the KITTI Object Dataset to train the PSMNet, but inference directly with the PSMNet trained on the KITTI Stereo Dataset.

你的意思是，直接用的PSMNet在KITTI 立体数据集上训练好的模型进行depth map预测吗

对

非常感谢您的回答！！！


Benefits over Twig and Blade?

It would be helpful if the README explained why anyone would want to use this over well established projects like Twig and Blade.

@nbpalomino  By "twig > razor" do you mean that twig is better than razor?
What is php razor missing?

@leek One reason for would be if php razor and asp.net were identical that I could modernize my frontend by using razor and have synergies for colleagues already familiar with it and later could switch from php to c#


Has anyone successfully trained on COCO?

Hello, thank you for sharing this code.
I used the code with no changes and when I saw the visualization of the generated boxes are not really good.

Has anyone successfully trained on COCO?

Hello. Which coco annotations did you use?

2017 Train/Val annotations [241MB]
2017 Stuff Train/Val annotations [1.1GB]
2017 Panoptic Train/Val annotations [821MB]

Hello @yuexihang
I used stuff_annotations_trainval2017.zip [1.1GB]
Thanks for the reply:)

Hello @sbkim052
The annotation stuff_annotations_trainval2017.zip [1.1GB] has only 92 kinds of categoris.
But the paper said they use the dataset with 171 annotations.
I don't find a annotation with 171 annotations.

Hi, according to the fifth page of this paper, it seems that the authors used the Panoptic version of COCO

Hi, according to the fifth page of this paper, it seems that the authors used the Panoptic version of COCO

Hello,I use the panoptic version of coco,I modified part of the code in dataset.py to adapt to the corresponding version，the result is not right.


feat(script/check_md_links.py): make python2/3 compatible

@Kha, I needed to make some change to run the code with python2. I've checked that it works with both of Python-2.7.11 and Python-3.5.1. Could you check that it looks OK? If so, I'll merge this commit to the blessed repo.
Related link: http://python3porting.com/noconv.html#import-errors

Ah, I didn't check for that. You'll probably want to add a from __future__ import print_function, otherwise the output will be mangled.

@kha, I added it. I also put copyright form.

I also put copyright form.

You made a (copy-paste) error with the name in the copyright form.

@fpvandoorn, oh I made a mistake :-(
I just fixed it. Thanks for the notice!


Fail fast if the snapshot can't be read

As discussed here:
https://groups.google.com/forum/#!topic/axonframework/9JvWCyqXCc0
rebuilding the snapshot can be a denial-of-service-attack ;-) since we have hundred thousand events for an aggregate.
It seems to me that it would be better to fail fast and throw an exception, since rereading all events wouldn't help in some cases. What we noticed is that e.g. the snapshot can't be read because of a dead database connection or because the transaction has already been rolled back.
So throwing an exception and maybe retrying the command would be a valid way. Or am I missing something?

I am not too fond of changing the behavior on this one. Other implementations may (and do) rely on this behavior. However, I do see value in failing properly.
One way to deal with this in a backwards compatible way, is to extract the error handling part into a separate (protected) method. The default implementation does the same as currently being done, but does allow changes by overriding the method.

If I'm able to change the default behaviour by overriding it, it would be fine for me, too.

I have created a commit in the branch for 3.3 that extracted this behavior into a protected method. This allows you to override this method an change the behavior.
See ecf0ebfefafe2c1fa910d3acff1541ce8f258e01
Closing this issue, but feel free to comment in case this doesn't (fully) resolve the issue.

Hi @abuijze: Do you already know the release in which this commit will be contained?

@dhermanns you should be expecting 3.3 very soon. We're currently closing the last couple of open tickets prior to our release. Stay tuned!

Hi Steven - sounds great!


setup OSSF Scorecard workflow

Please ensure your pull request adheres to the following guidelines:

[ ] For first time contributors, read Submitting a pull request
[ ] All code is covered by unit and/or runtime tests where feasible.
[ ] All commits contain a well written commit description including a title,
description and a Fixes: #XXX line if the commit addresses a particular
GitHub issue.
[ ] If your commit description contains a Fixes: <commit-id> tag, then
please add the commit author[s] as reviewer[s] to this issue.
[ ] All commits are signed off. See the section Developer’s Certificate of Origin
[ ] Provide a title or release-note blurb suitable for the release notes.
[ ] Are you a user of Cilium? Please add yourself to the Users doc
[ ] Thanks for contributing!

setup OSSF Scorecard

Hi @mmorel-35 👋
You might want to check out some of the discussion in https://github.com/cilium/cilium/pull/29933


Memory leak in Tensorflow Graph on CPU

I have a Face Detector that I'm trying to use for inference in Golang via official Tensorflow bindings. However, I faced a stepwise memory leak that causes the killing of an application due to OOM.
Screenshot with the leak:

Heap samples from pprof does not show anything interesting in Go code. It looks like the leak on C++ backend side:
go tool pprof http://localhost:8200/debug/pprof/heap
Fetching profile over HTTP from http://localhost:8200/debug/pprof/heap
Saved profile in /pprof.facedetector.alloc_objects.alloc_space.inuse_objects.inuse_space.073.pb.gz
File: facedetector
Build ID: c4dba901e690718468bdd4fa7d1a631daca9e65a
Type: inuse_space
Time: Jan 22, 2020 at 11:44pm (MSK)
Entering interactive mode (type "help" for commands, "o" for options)
(pprof)
(pprof) top20
Showing nodes accounting for 1861.64kB, 100% of 1861.64kB total
      flat  flat%   sum%        cum   cum%
  930.82kB 50.00% 50.00%   930.82kB 50.00%  bytes.makeSlice
  930.82kB 50.00%   100%   930.82kB 50.00%  main.(*FaceDetector).FindFaces
         0     0%   100%   930.82kB 50.00%  bytes.(*Buffer).Grow
         0     0%   100%   930.82kB 50.00%  bytes.(*Buffer).grow
         0     0%   100%   930.82kB 50.00%  io/ioutil.ReadFile
         0     0%   100%   930.82kB 50.00%  io/ioutil.readAll
         0     0%   100%  1861.64kB   100%  main.main
         0     0%   100%  1861.64kB   100%  runtime.main

Code to reproduce the issue
This code just reading an image from a file system in a for-loop and feed it to the model.
package main

import (
	"io/ioutil"
	"log"
	tf "github.com/tensorflow/tensorflow/tensorflow/go"
	"net/http"
	_ "net/http/pprof"
)

type FaceDetector struct {
	session         *tf.Session
	graph           *tf.Graph

	inputOp  tf.Output
	bboxesOp tf.Output
	scoresOp tf.Output
}

func NewFaceDetector(frozenGraphPath string) (*FaceDetector, error) {
	fd := &FaceDetector{}
	model, err := ioutil.ReadFile(frozenGraphPath)
	if err != nil {
		return nil, err
	}

	fd.graph = tf.NewGraph()
	if err := fd.graph.Import(model, ""); err != nil {
		return nil, err
	}

	fd.session, err = tf.NewSession(fd.graph, nil)
	if err != nil {
		return nil, err
	}

	fd.inputOp = fd.graph.Operation("input_image").Output(0)
	fd.bboxesOp = fd.graph.Operation("bboxes").Output(0)
	fd.scoresOp = fd.graph.Operation("scores_1/GatherV2").Output(0)

	return fd, nil
}

func (fd *FaceDetector) Close() error {
	if err := fd.session.Close(); err != nil {
		return err
	}
	return nil
}

func (fd *FaceDetector) FindFaces(image []byte) ([]float32, [][]int32, error) {
	imageTensor, err := tf.NewTensor(string(image))
	if err != nil {
		return nil, nil, err
	}

	output, err := fd.session.Run(
		map[tf.Output]*tf.Tensor{
			fd.inputOp: imageTensor,
		},
		[]tf.Output{
			fd.bboxesOp,
			fd.scoresOp,
		},
		nil)

	if err != nil {
		return nil, nil, err
	}

	bboxes := output[0].Value().([][]int32)
	scores := output[1].Value().([]float32)

	return scores, bboxes, nil
}

func main() {
	log.SetFlags(log.LstdFlags | log.Lshortfile | log.Lmicroseconds)

	go func() {
		log.Println(http.ListenAndServe("<IP_ADDRESS>:8200", nil))
	}()

	fd, err := NewFaceDetector("OptimizedGraph.pb")

	if err != nil {
		panic(err)
	}

	defer fd.Close()

	for {
		img, err := ioutil.ReadFile("photo.jpg")

		if err != nil {
			log.Println("Fail to read image:", err)
		}

		scores, boxes, err := fd.FindFaces(img)

		if err != nil {
			log.Println("Fail to infer:", err)
		}

		log.Println(scores, boxes)
	}
}

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): Yes.
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Ubuntu-based Docker images
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device: Not tested
TensorFlow installed from (source or binary): Binary/Pre-compiled (https://storage.googleapis.com/tensorflow/libtensorflow/libtensorflow-cpu-linux-x86_64-1.15.0.tar.gz)
TensorFlow version (use command below): 1.15.0
Python version: -
Bazel version (if compiling from source): -
GCC/Compiler version (if compiling from source): -
CUDA/cuDNN version: -
GPU model and memory: -
Golang version: 1.13

photo.jpg: https://user-images.githubusercontent.com/2982775/72982648-96393b80-3df0-11ea-807f-c4979b4c3af2.jpg
TF Graph: graph.zip

I have the same issue, but I use tf.LoadSavedModel, tried assign model to nil, defer session.close(), golang garbage collection, none of them works, go proof shows the same result, loadsavedmodel did not release memory.
in my case, i had to choose one of hundreds model file and load it to inference, I know there's a mechanism stop my session.close or model release due to I'm sending request frequently
is there anything i can do? I choose golang and try prevent from python memory leak nightmare, now I put myself into another one, sight

Hello everyone !
Since we switch our prediction platform to Tensorflow we are also experienced a memory leak.
After finding that out, we used go tool pprof in order to found where leaks where happening but it was useless. Impossible to find the leak using pprof. In fact, pprof's inuse_space sum output was completely different from top's. Everything seemed to be fine on pprof but top was showing a constant rise in memory usage.
We tried to figured out if our code could be the issue and it is not. No leak at all without any call to TF and still nothing of a memory leak shown by pprof.
We tried to abstract as much as possible and finished with this piece of code.
package main

import (
	"fmt"
	tf "github.com/tensorflow/tensorflow/tensorflow/go"
	"runtime"
	"time"
)

func printStats(mem runtime.MemStats) {

	runtime.ReadMemStats(&mem)

	fmt.Println("mem.Alloc:", mem.Alloc)

	fmt.Println("mem.TotalAlloc:", mem.TotalAlloc)

	fmt.Println("mem.HeapAlloc:", mem.HeapAlloc)

	fmt.Println("mem.NumGC:", mem.NumGC)

	fmt.Println("-----")

}

func loadModel(modelPath string, tags []string) {
	model, err := tf.LoadSavedModel(modelPath, tags, nil)
	if err != nil {
		fmt.Println("error OPENING model")
		return
	}
	err = model.Session.Close()
	if err != nil {
		fmt.Println("error CLOSING model")
		return
	}
}

func main() {
	var mem runtime.MemStats

	printStats(mem)
	tags := []string{"serve"}
	for i := 0; i < 300; i++ {
		loadModel("./path_to_model/", tags)
		fmt.Println("loading model: => ", i)
		printStats(mem)
	}
	fmt.Println("done")
	printStats(mem)
	fmt.Println("call to garbage collector1")
	runtime.GC()
	printStats(mem)
	fmt.Println("sleeping 10 minutes")
	time.Sleep(time.Minute * 10)
	fmt.Println("complete done")
}

We are basically loading a model 300 times, closing them right after and then calling the Garbage Collector at the end of the process to force the memory pointed by useless pointers to be freed. However, whether it be with TF 1.15.2 or 2.0.1 we are experiencing something weird. The models are, as weird as it is, being freed some time to times. I let you run this program several times and see what top says on the process's memory.
We are expecting it to decrease as soon as the GC is called. On both 1.15.2 & 2.0.1, sometimes it decreases, sometimes it does not and we think it is linked with some useless pointers still used by TF somewhere, preventing the GC to free them. Note that with our recents tests we can point that this issue seems to happens more often with TF 2.0.1 than with 1.15.2.
In our case and with our model, the program start at around 100-200Mo, reach 1.5Go at the end of the 300 models loading and then when the GC is called, the inuse memory shown by top drops back to 150Mo or sometimes doesn't and stays at 1.5Go.
All of this lead us to believe that the issue is from the C++ code OR from the CGo bindings of Tensorflow. We couldn't figured out anything else. An investigation would be appreciated 🚀

+1

Execute the following code, a memory leak will occur
for i := 0; i < 100; i++ {
	tf.LoadSavedModel("/model/fm_model_v1", []string{"serve"}, nil)
	time.sleep(10 * time.Second)
}
![Image 2020-03-10 22-39-17](https://user-images.githubusercontent.com/20059289/76324906-a1551600-6321-11ea-8265-bd32e72efc7d.png)

@integritybravery yes...basically this is what I did, still no answer yet

any update on this ?

I have the same issue; pprof did not detected any heap memory leak;
any update on this?

same issue ; need help

I meet a similar issue on inference pb files, hope for help.

I have narrow it down to NewTensor also creating memory leak.
It seems the golang garbage collector does not clear the whole unused Tensor.

It seems that tensorflow has no limit on cpu utilization by default，memory usage will increase until OOM if you don't add limit. Try add  tf_config = tf.ConfigProto(inter_op_parallelism_threads=1,intra_op_parallelism_threads=1))  sess=tf.Session(config=tf_config) and it works for me.

I think am observing the same. @jerklee I tried your approach of setting the configproto in my golang implementation but that has no effect. I see a constant memory increase whenever a new model file gets loaded. I also tried dereferencing the session and graph pointers so that the runtime finalizers kick in and release the memory but there's been no effect doing that. I'd like to know how the allocated memory from the previous model load can be unallocated safely to stop OOM

Hi There,
We are checking to see if you still need help on this, as you are using an older version of tensorflow which is officially considered end of life . We recommend that you upgrade to the latest 2.x version and let us know if the issue still persists in newer versions. Please open a new issue for any help you need against 2.x, and we will get you the right help.
This issue will be closed automatically 7 days from now. If you still need help with this issue, please provide us with more information.

Did someone solved this problem?
So sad, this memory still bothered me.....


Add note to README: Sublimelinter-contrib-standard

There is now a Sublimelinter-contrib-standard package available via Package Control to get standard linting in Sublime Text! Woo!
This change simply adds a line to the README to let users know.

Awesome, thanks!!

Retweet: https://twitter.com/feross/status/562361868879011840


Add rav1e to package managers

Not directly related to the codebase, but it would be very useful to have rav1e available in the most used package managers. These for example:

[ ] APT (Debian / Ubuntu)
[x] Homebrew (macOS)
[ ] Chocolatey (Windows)

Maybe at least publish pre-built executables for various linuxes to Github releases?

Maybe at least publish pre-built executables for various linuxes to Github releases?

Having one for the latest Ubuntu LTS would be nice as it's pretty common

It it can be just a fully static musl build, like this:
https://vi-server.org/pub/rav1e_af9d4ab
SHA256 (rav1e_af9d4ab) = 73c6f959ee38324608648a3e09b9cf6e04b02a2c359ddea84e20dc22f1e464fd

https://vi-server.org/pub/rav1e_af9d4ab

Works fine even on FreeBSD via linuxulator. Tested in a clean jail without any Linux userland bits installed.

@jbeich does the packaging status badge get updated automatically?

@EwoutH, yes, Repology badges are dynamic. Not sure how frequent repository scans are: probably, every few hours. Try checking out badges for packages e.g., cbindgen.

Btw, is it possible to build rav1e from the git repo on Debian without
downloading extra code from the Internet?  Software builds downloading
random code from the Internet rub me the wrong way in addition to
failing the 'desert island' test for free software, from
<URL: https://people.debian.org/~bap/dfsg-faq.html >:
The Desert Island test.
Imagine a castaway on a desert island with a solar-powered
computer. This would make it impossible to fulfill any requirement to
make changes publicly available or to send patches to some particular
place. This holds even if such requirements are only upon request, as
the castaway might be able to receive messages but be unable to send
them. To be free, software must be modifiable by this unfortunate
castaway, who must also be able to legally share modifications with
friends on the island.
In practice it require the complete source to be available from Debian.
--
Happy hacking
Petter Reinholdtsen

[Ximin Luo]

Debian Rust packaging is already done with a cargo wrapper tool that
avoids network access, see
https://salsa.debian.org/rust-team/debcargo-conf/ - rav1e can submit a
PR for itself and any of its dependencies not already in Debian.

Aha.  Perhaps you can help make build rules for a rav1e Debian package?
Or at least update <URL: https://bugs.debian.org/920842 > with details
on how to do it?  I know nothing about rust myself.
--
Happy hacking
Petter Reinholdtsen

As a first ting wouldn't it be good to have it on crates.io (the offical rust package repo) so anyone can use cargo install rav1e? All listed package managers are restricted to a specific OS, while cargo is not.

I'm already taking care of aom and dav1d for Fedora, I'll take care of rav1e as well when there is a point release.

@eclipseo Hi,
As we have a 0.1 release of rav1e, will it be possible for you to take care of rav1e too?

The following dependencies need to be packaged before rav1e for Debian:
dpkg-checkbuilddeps: error: Unmet build dependencies:
librust-arbitrary-0.2+default-dev
librust-arg-enum-proc-macro-0.3+default-dev
librust-arrayvec-0.5+default-dev
librust-better-panic-0.2+default-dev
librust-bitstream-io-0.8+default-dev
librust-err-derive-0.2+default-dev (>= 0.2.1-~~)
librust-interpolate-name-0.2+default-dev (>= 0.2.2-~~)
librust-ivf-0.1+default-dev
librust-nasm-rs-0.1+default-dev
librust-noop-proc-macro-0.1+default-dev
librust-paste-0.1+default-dev
librust-pretty-env-logger-0.3+default-dev
librust-scan-fmt-0.2+default-dev (>= 0.2.3-~~)
librust-signal-hook-0.1+default-dev (>= 0.1.9-~~)
librust-simd-helpers-0.1+default-dev
librust-vergen-3+default-dev
librust-y4m-0.4+default-dev

Line-breaks added for readability.

We are waiting on https://github.com/Homebrew/homebrew-core/pull/46975 so that we can include the dev artifacts in the formula. This will enable the bottle to be used for building against the C-ABI.

I've packaged rav1e for openSUSE which is on the way to openSUSE Tumbleweed.
Fedora is next on my list.

Are there any plans to package Debian dependencies? I tried using avifenc in Debian recently, but it has no decoder:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=976349

Are there any plans to package Debian dependencies? I tried using avifenc in Debian recently, but it has no decoder:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=976349

[shmerl]

Are there any plans to package Debian dependencies?

I suggest bringing this up with the Debian Multimedia team,
<URL: https://wiki.debian.org/DebianMultimedia >.
--
Happy hacking
Petter Reinholdtsen

[shmerl]

Are there any plans to package Debian dependencies?

I suggest bringing this up with the Debian Multimedia team,
<URL: https://wiki.debian.org/DebianMultimedia >.
--
Happy hacking
Petter Reinholdtsen

I'm currently in the process of packaging rav1e for Debian. The current blockers for me are at least the dependency on vergen version 3 instead of version 6.

We are using a custom one, a patch to update to the latest is welcome though.

The custom vergen version does not seem to be included in the rav1e version from crates.io, though. In any case, the use of vergen seems in the package build seems to be counter productive anyway. Even if I locally patch it to use version 6, it then fails because we are not building from a git repository.

Also the current vergen is 7.

there is some overlap with built, maybe we could drop one.

We might, let see if the output matches.

rav1e is now available in Debian: https://tracker.debian.org/pkg/rust-rav1e


SSL: unable to get local issuer certificate

It seams Godot can't get the local certificates to verify a host.

I'm using Manjaro Linux 64bit

similar to #1626
Cause: unable to get local issuer certificate
CERT STR: /C=US/O=DigiCert Inc/CN=DigiCert SHA2 Secure Server CA
VALID: 0
CONNECTION RESULT: -1
SSL! TURNED ON!

did you set a file with certificates?

I thought OpenSSL would use my System-Path.
Where can I specify a file? - I didn't find anything in the Wiki.

no.. some platforms such as Windows, iOS, Android, etc don't give you
access to system wide certificates..
also many times you want to use a self signed cert or trim to a list of
trusted CAs when you do domain validation.
if you are in linux, you can find the standard certificates files at:
/etc/ssl/certs/ca-certificates.crt
in PEM format
just copy this to your project, add it to the export filters (*.crt) and
add the file in project settings
On Wed, Apr 8, 2015 at 2:34 AM, MrJustreborn<EMAIL_ADDRESS>wrote:

I thought OpenSSL would use my System-Path.
Where can I specify a file? - I didn't find anything in the Wiki.
—
Reply to this email directly or view it on GitHub
https://github.com/okamstudio/godot/issues/1630#issuecomment-90806830.

will try to remember make a tutorial about this, so please don't close the
issue if it works for you
On Wed, Apr 8, 2015 at 9:24 AM, Juan Linietsky<EMAIL_ADDRESS>wrote:

no.. some platforms such as Windows, iOS, Android, etc don't give you
access to system wide certificates..
also many times you want to use a self signed cert or trim to a list of
trusted CAs when you do domain validation.
if you are in linux, you can find the standard certificates files at:
/etc/ssl/certs/ca-certificates.crt
in PEM format
just copy this to your project, add it to the export filters (*.crt) and
add the file in project settings
On Wed, Apr 8, 2015 at 2:34 AM, MrJustreborn<EMAIL_ADDRESS>wrote:

I thought OpenSSL would use my System-Path.
Where can I specify a file? - I didn't find anything in the Wiki.
—
Reply to this email directly or view it on GitHub
https://github.com/okamstudio/godot/issues/1630#issuecomment-90806830.

I totaly overseen the certification setting in the project settings, now it works!

Just in case for anyone searchig, I added an SSL tutorial
https://github.com/okamstudio/godot/wiki/tutorial_ssl


Working with very large strings

Hello. Thank you for your project. I have one question, I hope for Your help.
I have two very large arrays of numbers (integers, from 0 to 100), I want to find out how similar these two arrays are. I thought I could translate these lists to string list, and then use Your string similarity metric. However, the size of arrays is very large (about 16,000 elements), and there is not enough memory.
Perhaps there is a way to calculate this metric approximately in order to use less memory, or maybe somehow reduce the array?
Thank you very much for any help

Hello
Have you tried computing the similarity directly with the integers arrays? Like this:
print(damerauLevenshtein(arr1, arr2))

Maybe you get a good result. Also, what are you trying to achieve by comparing the arrays?

I didn't notice that Your code also works with arrays of integers, thank you:)
I do research some functions over finite fields. After certain transformations I get an array, for example [3,3,3,3,...,179,179,179,...,12,12,12,12,12,...] over GF(256). It consists of a series of identical elements, the series may meet several times and their length may be different. And for each function, the array will be its different and contain a different length (because I also consider subfields, other finite fields, and bounded functions).
I have a hypothesis that is to find the "similarity" of function classes. I'm not sure that I can explain the essence of building classes correctly and briefly, but in General, it all comes down to this: if you need fewer transformations to reduce one array to another, then the classes are more "similar".
But functions can have a very large degree, and therefore arrays are very long. They can be compressed very much if you replace the series with a single element, but their length is still important.
And if I run Your code on such large arrays, I get an error.

Most likely, there is not enough memory on computer
On smaller arrays(on the order of 10000) Your code works perfectly (I didn't expect this speed). I suppose it is possible to construct a cost matrix where the cost will depend on the length of the series, but I am not sure that the algorithm can be modified like this.
Will be happy to receive any information from You :)
Sorry for my English:)

What python version are you using? Is it 32 or 64 bit? Maybe your OS is limiting how much memory python processes can use? I've tried it on two arrays of 20k elements each and I had no memory problem (Python 3.8 64 bit).
I suggest you to look into cosine similarity and tf-idf(term-frequency inverse-document-frequency), You will consider your arrays as "documents" and their elements as "words". You construct the documents matrix and then compute cosine similarity on them. It's a simple and fast algorithm and I think it can be useful in your case. Here are some links from google:
https://towardsdatascience.com/tf-idf-for-document-ranking-from-scratch-in-python-on-real-world-dataset-796d339a4089
https://janav.wordpress.com/2013/10/27/tf-idf-and-cosine-similarity/
https://courses.cs.washington.edu/courses/cse573/12sp/lectures/17-ir.pdf
Let me know how this works and if I can further help you.

Thank you very much. An interesting option, I will try it.
Yes, indeed I only have 8 GB of memory, so there is an overflow, and the system kills the process.
Thank you very much for your help.

No problem, let me know if it works and close this issue when you can. Thx.

Thank you, this really works on my data, but it's not exactly what I need. I still decided to use your code with the Levenshtein method, I just had to use a more powerful computer:)


v2.0.1 - ship list

Major Updates:

The Dropdown have been reworked to simplify the menu alignment CSS by moving the logic into the JS to reduce the convoluted (and sometimes incorrect) appearance rules.  The divider now uses the .dropdown-divider class instead of the outdated .divider.

CSS

#163: Layout-Grid: Add gutter padding to .col-*-auto
#164: Widget-Tooltip/Popover- Convert max-widths to calculated rem
#166: Reboot: Add 'system-ui' to font stack
#169: Widget-Dropdown: Rework alignment, add additional variables
#170: Move _custom.scss down in load order so base settings and mixins can be used

JS

#168 - Player: rename unplayedStatus to playedStatus for clarity

Accessibility
Docs

#162: Fix some bad links
#165: Fix spelling of 'responsive'

Build

Changing this to be the v3.0.0 tracking branch since so many other items are being overhauled.

Closing to move on to a new ship list issue #207.