Breadcrumbs: entries not perfectly centerd with twistie

Compare an entry of the breadcrumb picker with the file explorer and notice how the twistie is not aligned in the same way as in the file explorer where it appears to be more in the center:

(I am running with zoom level: 1)

My first guess would be good old line-height to begin with.


Send VA Profile data on SMS Notification Delivery status

User Story - Business Need
VA Profile is interested in tracking SMS  delivery status so that they might offer data to their partners regarding the quality of contact data/the likelihood of delivery success. VA Notify needs to send VA Profile the delivery status of ALL SMS notifications so VA Profile can track this information.
It is recommended to reuse the code created in #1770 to send VAProfile Email Notification statues. check_and_queue_va_profile_email_status_callback and it's childern method could be updated to be notification-type ambiguous, handling both SMS and Email notification types. check_and_queue_callback_task can also be modified to capture the status of all SMS Notifications and send them to VAProfile.

[x] Ticket is understood, and QA has been contacted (if the ticket has a QA label).
[x] Touch base with Cris when she is back.

User Story(ies)
As a developer on the VA Notify team
I want to send real-time SMS delivery status updates to VA Profile
So that the VA system can improve the management and reliability of contact data, thereby enhancing communication with veterans and maintaining the organization's contact reputation.
Additional Info and Resources

#1770 - Prior Work completed for sending Email Notification status
check_and_queue_callback_task could be updated to send the status of all SMS Notifications to VAProfile.
check_and_queue_va_profile_email_status_callback - Can be updated to be  notification-type ambiguous and send notification status to VAProfile

Acceptance Criteria

[x] When ANY SMS or email delivery status is processed, it should trigger a POST request to VA Profile with accurate and complete delivery status data in the DEV/PERF environments.
[x] Delivery status data prior to the delivery attempt should NOT trigger a POST request to VA Profile
[x] The system should handle errors gracefully and log them appropriately
[x] The feature should work seamlessly with existing infrastructure, with minimal need for new development.
[x] Reuse feature flag for VA_PROFILE_EMAIL_STATUS_ENABLED
[x] Include logic to continue to send statuses to VAPROFILE if EMAIL regardless of FF
[x] Make ticket for feature flag removal
[x] This work is added to the sprint review slide deck (key win bullet point and demo slide)
[ ] All changes should be well-documented

QA Considerations

[ ] Verify that a delivery status triggers the POST request to VA Profile. This probably requires checking the logs. Work with developer to understand the logging.
[ ] Verify the feature flag and parameters
[ ] Take a look at the documentation.

Potential Dependencies

VA Profile's Pilot will happen next PI (starting mid-December), most likely wait until the new year.

Yesterday

Spoke to Kyle regarding implementation (See notes above)
Create initial test for sending SMS to VAProfile
Refactor send_email_status_to_va_profile to handle SMS

Today

Rename and move send_email_status_to_va_profile to own module
Fix tests that will break

I'm out on Friday. So I'll leave an update at the EOD

Yesterday

Another minor refactor
Add testing for minor adjust to FF logic
Working thru SMS testing updates

Today

Finish SMS testing updates
Deploy to DEV

Yesterday

Further correction to SES test
Clean up
Found a way to run Celery workers immediately while testing. This would break other tests. I'm creating a ticket for this work instead.
Tried testing on DEV, could not find logs for sending SMS notification to VAProfile
Cannot find any obvious reason at the moment

Today

Continue testing on DEV.

Yesterday

Debug way celery failing
Test PR
Submit PR
Rewrite some docs

Today

Merge PR once approved.

PR approved and merged, sending to Perf for validation.

QA FAILED
This is sending things to VaProfile that are not a successful delivery or permanent failure due to invalid phone number, like in 'sending'

Will continue to send it through pipeline since it is all behind a feature flag.

Talked to @k-macmillan and got clarification around AC Delivery status data prior to the delivery attempt should NOT trigger a POST request to VA Profile. We should be sending ALL notification statuses that are NOT pre-provider. Pre-provider statuses include NOTIFICATION_CREATED, NOTIFICATION_SENDING, or NOTIFICATION_PENDING

PR approved and merged, sending to Perf for validation after the next staging/prod deployment is complete.

QA TESTING IN PROGRESS

[ ] Delivery statuses that are not pre-provider are sent to VAProfile, validated by means of the regression which actually sends 15 sms and 11 email messages. There may be multiple sends for the same notification (i.e., sent, delivered, as shown in screenshot above). Check for new logging in this format:

'Sending notification status to VA Profile with url: %s | notification_id: %s | notification_status: %s'
'VA Profile response when receiving status of notification_id: %s | notification_status: %s | status code: %s | json: %s',

Holding ticket open for documentation and sending code to prod.

Documentation complete (and looks good), closing ticket.


Don't cancel GHA runs on subsequent push events

Summary
With our switch to using the GitHub merge queue with speculative merging, it's now possible for us to have two push events to a protected branch (like main) within a couple of minutes.  If this happens, the eager cancellation rules we have set for the coverage and Neko runs in GHA trigger, causing a spurious build failure to appear in the commit logs, and for the coverage history to be lost for one commit.
Instead, we can set the cancel-on-update behaviour to only trigger on PR sync events, not branch-push events.

Details and comments
We also likely want to set the workflows to only trigger on pushes to Qiskit repos so users' notifications don't get spammed, and we're not just burning the planet running unnecessary CI, but that's a separate logical change.

I tested this by pushing an empty commit to the branch (and then force-pushed it away again).  You can see that the coverage and Neko runs were suitably cancelled, for example here: https://github.com/Qiskit/qiskit-terra/actions/runs/4623222644.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 85.431%

Totals

Change from base Build<PHONE_NUMBER>:
0%

Covered Lines:
67646

Relevant Lines:
79182

💛  - Coveralls


Fix #1357 port argument in App can be ignored when using a custom receiver

Summary
This pull request resolves #1357 by adding info-level logging for mitigating confusion.
Requirements (place an x in each [ ])

[x] I've read and understood the Contributing Guidelines and have done my best effort to follow them.
[x] I've read and agree to the Code of Conduct.

We can move this to a future milestone


Add details to split

Summary

This enables an admin to see and edit context and hypothesis metadata about what splits the user is experiencing

Other Information

design updates forthcoming in a separate PR to more completely update the UI with style-closet

/domain @Betterment/test_track_core

<<domain tafn

bump

nanda?

minor comment about one line of code and a philosophical point about the naming of that one column, but domainlgtm
let's just sync up on the name of that column.
very excited to start collecting these details in the app properly so that we can build a kick-butt analytics tool on the backside of this database.

bump

bump

domainlgtm part 2! nice.


Mac device recognized as other

Hi,  thanks for the great module, really enjoy it.  Quick question, the following UA string:
'Mozilla/5.0 (Macintosh; Intel Mac OS X 10_8_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/29.0.1547.65 Safari/537.36',
results in the device being set to 'Other', what are your thoughts about it containing Macintosh or Desktop since that is the 'device' the user is actually using?

I encountered the same problem


fix(nuxt): provide global scope for nuxt plugin context

🔗 Linked issue
related: https://github.com/nuxt/nuxt/pull/23664
resolves https://github.com/nuxt/nuxt/issues/23249
❓ Type of change

[ ] 📖 Documentation (updates to the documentation or readme)
[x] 🐞 Bug fix (a non-breaking change that fixes an issue)
[ ] 👌 Enhancement (improving an existing functionality like performance)
[ ] ✨ New feature (a non-breaking change that adds functionality)
[ ] 🧹 Chore (updates to the build process or auxiliary tools and libraries)
[ ] ⚠ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description
This adds a scope to global Nuxt context which has the ability to collect + cleanup before disposing of it. We can call this disposal before navigating away which allows for cleaning up cookie BroadcastChannel, for example.
📝 Checklist

[x] I have linked an issue or discussion.
[ ] I have updated the documentation accordingly.

Haven't tried but really nice idea!


[Feature]: Multimodel prefix-caching features

🚀 The feature, motivation and pitch
v0.6.4.post1, "--enable-prefix-caching is currently not supported for multimodal models and has been disabled." When will multimodal models be supported?
Alternatives
No response
Additional context
No response
Before submitting a new issue...

[X] Make sure you already searched for relevant issues, and asked the chatbot living at the bottom right corner of the documentation page, which can answer lots of frequently asked questions.

This is being actively worked on as part of the VLLM V1 project. Not definite timeline but I would expect within a month

Thanks.


fix: add missing return to example in rpg project step 146

Checklist:

[X] I have read and followed the contribution guidelines.
[X] I have read and followed the how to open a pull request guide.
[X] My pull request targets the main branch of freeCodeCamp.
[X] I have tested these changes either locally on my machine, or GitPod.

Closes #53889

I could have sworn I removed that. Sorry.


Mistake appears during dump expanding

Description
I try to expand PostreSQL dump in DBeaver 23.2.0 however mistake occurs during loading. Dump is mushrooms.sql

Logs 1.docx
Logs 2.docx
DBeaver Version
Free Universal Database Manager <IP_ADDRESS>309041200
Operating System
Windows 10, version 22H2  desktop
Database and driver
1.PostgreSQL 16rc1
2.Driver version PostgreSQL JDBC Driver Standard
Steps to reproduce

Projects-Create-Database - Name of database   New_database - Owner   postgres- OK
Projects New_database - Set by default
Projects New_database - Instruments - Perform script-input file (attached) - Start
mushrooms.sql
Error occures (attached)
Logs 2.docx
Logs 1.docx

Additional context
No response

Hello @Natalia27041985
First of all, did you try to restore your SQL? Or execute it as a script?
Because I see different info in the header and on screens.
The second one - your locale and native client are different. Probably, for this reason, you see corrupted characters.
And it can be any error inside. Maybe it is - table/column already exists.
Which native Client do you use? You can find this info in your connection settings.

We expect that it was solved with #21513 and the bug doesn't exist on the latest DBeaver version.
However, if the issue is still reproducible, please let me know.


Correct spelling of "suppress"

"Suppress" is spelled with two P's, even in British English.

This pull request has been superseded by https://github.com/boostorg/assign/pull/9


Loosen size restrictions from cashaddr

Cashaddr defined 8 allowed sizes but RPA may exceed the longest. Remove size enforcement at the expense of slightly less strict error checking.

I find the cashaddress length thing to be a bit silly. Right now there are only two valid values for the leading version byte:

0 for P2PKH (always with a 160-bit hash)
8 for P2SH (always with a 160-bit hash)

It's ridiculous that version 9 has been allocated for 192-bit P2SH, for instance. As far as I'm concerned, every other version has unspecified meaning.


Error Message in online.py

Dear Author,
I hope you are having a good day. I have encountered an error in online.py as in the attachments about the matrix dimensions.  I am trying to construct a depth map of a single image.  I have used the camera parameters and images from Kaggle for this Python file.  Even I choose the camera matrix as 3 y 3 matrix, I am still getting that error.  I would appreciate your help.  Thanks in advance.
My best regards,

I'm very sorry. This file was used for testing the code in the early stages of the experiment and may be incompatible with some modifications made later in the experiment. We have removed this file.


timezone

Latest image based on Alpine does not follow the set timezone in the TZ environment variable. The image based on ubuntu worked fine.

@rtorchia are you using main or develop? Develop has been fixed. I've tested it on my remote machine. Thanks for opening the issue.

I used the main. I'll give it a try with the develop version

just pulled the develop version and the timezone working great!
Thank-you!!

Pushed to main/latest


Cannot build with streaming-0.2

Sorry it took me so long but it's released now as <IP_ADDRESS>;  I kept trying to tweak the benchmarking code in the hopes of getting an optimal solution but in the end just picked one.


[BUG] DeepSpeed Inference breaks when initializing GPT-J-6B HuggingFace model with replace_with_kernel_inject=True and displays gibberish

Describe the bug
DeepSpeed Inference breaks when initializing GPT-J-6B HuggingFace model with replace_with_kernel_inject=True
and displays gibberish
What is DeepSpeed? and and and and and ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( Br Swiss ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( Br Swiss ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( s s s s'}]
[{'generated_text': 'What is DeepSpeed? and and and and and ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( Br Swiss ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( Br Swiss ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( ( s s s s'}

To Reproduce
A script to reproduce the issue with deepspeed==0.7.4 and transformers==4.23.1
import os
import logging
import deepspeed
import torch
from transformers import pipeline, AutoModelForCausalLM, AutoTokenizer

predictor = None
def get_model():
    model_name = "EleutherAI/gpt-j-6B"
    tensor_parallel = int(os.getenv("TENSOR_PARALLEL_DEGREE", "1"))
    local_rank = int(os.getenv("LOCAL_RANK", "0"))
    model = AutoModelForCausalLM.from_pretrained(
        model_name, revision="float16", torch_dtype=torch.float16, low_cpu_mem_usage=True
    )

    tokenizer = AutoTokenizer.from_pretrained(model_name)

    model = deepspeed.init_inference(
        model,
        replace_method="auto",
        replace_with_kernel_inject=True,
        dtype=model.dtype
    )

    generator = pipeline(
        task="text-generation", model=model, tokenizer=tokenizer, device=local_rank
    )
    return generator

def handle(inputs: str) -> None:
    global predictor
    if not predictor:
        predictor = get_model()

    max_new_tokens = 512
    num_beams = 1
    num_beam_groups = 1
    temperature = 0.7
    top_k = 1
    top_p = 1.0

    if inputs is None or inputs == "":
        return None

    result = predictor(
        inputs,
        do_sample=True,
        max_new_tokens=max_new_tokens,
        num_beams=num_beams,
        num_beam_groups=num_beam_groups,
        temperature=temperature,
        top_k=top_k,
        top_p=top_p
        )

    logging.info(result)
    return result

print(handle("What is DeepSpeed?"))

Expected behavior
A clear and concise description of what you expected to happen.
ds_report output
DeepSpeed C++/CUDA extension op report
--------------------------------------------------
NOTE: Ops not installed will be just-in-time (JIT) compiled at
      runtime if needed. Op compatibility means that your system
      meet the required dependencies to JIT install the op.
--------------------------------------------------
JIT compiled ops requires ninja
ninja .................. [OKAY]
--------------------------------------------------
op name ................ installed .. compatible
--------------------------------------------------
cpu_adam ............... [NO] ....... [OKAY]
cpu_adagrad ............ [NO] ....... [OKAY]
fused_adam ............. [NO] ....... [OKAY]
fused_lamb ............. [NO] ....... [OKAY]
 [WARNING]  please install triton==1.0.0 if you want to use sparse attention
sparse_attn ............ [NO] ....... [NO]
transformer ............ [NO] ....... [OKAY]
stochastic_transformer . [NO] ....... [OKAY]
 [WARNING]  async_io requires the dev libaio .so object and headers but these were not found.
 [WARNING]  async_io: please install the libaio-dev package with apt
 [WARNING]  If libaio is already installed (perhaps from source), try setting the CFLAGS and LDFLAGS environment variables to where it can be found.
async_io ............... [NO] ....... [NO]
utils .................. [NO] ....... [OKAY]
quantizer .............. [NO] ....... [OKAY]
transformer_inference .. [NO] ....... [OKAY]
--------------------------------------------------
DeepSpeed general environment info:
torch install path ............... ['/opt/conda/envs/venv/lib/python3.10/site-packages/torch']
torch version .................... 1.12.1.post201
torch cuda version ............... 11.2
torch hip version ................ None
nvcc version ..................... 11.6
deepspeed install path ........... ['/opt/conda/envs/venv/lib/python3.10/site-packages/deepspeed']
deepspeed info ................... 0.7.4, unknown, unknown
deepspeed wheel compiled w. ...... torch 1.12, cuda 11.2

Screenshots

System info (please complete the following information):

OS: Ubuntu 20.04
GPU count 4 x A10G
Transformers 4.23.1
Python version 3.10.6

Docker context
Not using Docker
Additional context
Add any other context about the problem here.

Hi @stan-kirdey, I've recreated your issue and am looking into it.

Looks like this is an issue with setting low_cpu_mem_usage=True.
Please try removing it from this line:
model = AutoModelForCausalLM.from_pretrained(         model_name, revision="float16", torch_dtype=torch.float16, low_cpu_mem_usage=True      )
And try adding it here:
generator = pipeline(         task="text-generation", model=model, tokenizer=tokenizer, device=local_rank, model_kwargs=dict(low_cpu_mem_usage=True)     )
Linking related issues:
https://github.com/microsoft/DeepSpeed/issues/2275
https://github.com/microsoft/DeepSpeed/issues/2048

perfect, thanks for looking into it
On Mon, Oct 31, 2022 at 3:19 PM Molly Smith @.***>
wrote:

Looks like this is an issue with setting low_cpu_mem_usage=True.
Please try removing it from this line:
model = AutoModelForCausalLM.from_pretrained( model_name,
revision="float16", torch_dtype=torch.float16, low_cpu_mem_usage=True )
And try adding it here:
generator = pipeline( task="text-generation", model=model,
tokenizer=tokenizer, device=local_rank,
model_kwargs=dict(low_cpu_mem_usage=True) )
Linking related issues:
#2275 https://github.com/microsoft/DeepSpeed/issues/2275
#2048 https://github.com/microsoft/DeepSpeed/issues/2048
—
Reply to this email directly, view it on GitHub
https://github.com/microsoft/DeepSpeed/issues/2452#issuecomment-1297759991,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A26AML3PSPBWBHV74PM6LVDWGBAW5ANCNFSM6AAAAAARRPMQTA
.
You are receiving this because you were mentioned.Message ID:
@.***>


Support for Terraform

This is tracking for adding support for Terraform HCL to PSRule originally discussed here Microsoft/PSRule#907 by @jbla9028.
Is your feature request related to a problem? Please describe.
It appears that psrule can review a ARM or bicep template from the documentation. It seems like the only open to review terraform is to review the resources after the terraform code has applied the infrastructure. Can we get native terraform support?

Passing a target folder, along with variables, can psrule review a user's terraform code for compliance?
Describe the solution you'd like

Describe alternatives you've considered
There are other solutions that will do this but psRule's syntax seems very easy to use, it would be great to leverage it with terraform.

Additional context

Continue reading the FAQ for details on in-flight support for Terraform.

If this issue is important to you please upvote the issue.
We plan to investigate this issue to determine if this is something that should be integrated into PSRule for Azure.

Updated: 2023-08-26
Some questions to add to the research effort:

What do your current CI pipelines look like now?
Do you generate a plan in your terraform pipelines for deployment?
Do you use the azurerm or azapi providers?

Terraform being used widely for Azure as well, support for validating is very useful.

I think we should focus on the Azure tooling first. There are still multiple problems with bicep and ARM syntax.
First party tooling should be the focus and priority by now and maybe after Bicep 1.0, we can focus on third-party tools like Ansible, Pulumi or Terraform.

Terraform really useful since often used in SAP on Azure implementations...

Some questions to add to the research effort:

What do you current CI pipelines look like now?
Do you generate a plan in your terraform pipelines for deployment?
Do you use the azurerm or azapi providers?

Being able to test against Azure Policy would help eliminate a lot of Terraform headaches and errors.  I bypass ARM entirely by using Terraform and avoid ARM wherever possible - TF is simply easier to use.  We use azurerm exclusively.

Being able to test against Azure Policy would help eliminate a lot of Terraform headaches and errors. I bypass ARM entirely by using Terraform and avoid ARM wherever possible - TF is simply easier to use. We use azurerm exclusively.

You are still using ARM REST APIs in the background, if you are using Terraform, just no ARM templates. If you don't like ARM template syntax, you can always use Bicep for simpler usage and much clearer syntax.


Make sure debugger is active when sending custom requests

Previous PR had a strange failure in this test:
Correctly handle leading spaces in a code cell we are debugging
The failure looked like this:

That message comes from a debug custom request not working.
Adding some logic into the IW debugger to make sure it's started before sending a request.

Codecov Report

Merging #8645 (6182683) into main (70cb636) will increase coverage by 0%.
The diff coverage is 64%.

@@          Coverage Diff          @@
##            main   #8645   +/-   ##
=====================================
  Coverage     71%     71%
=====================================
  Files        381     382    +1
  Lines      24484   24517   +33
  Branches    3755    3764    +9
=====================================
+ Hits       17508   17547   +39
+ Misses      5465    5446   -19
- Partials    1511    1524   +13

Impacted Files
Coverage Δ

...t/datascience/jupyter/interactiveWindowDebugger.ts
62% <64%> (-2%)
:arrow_down:

...ience/variablesView/variableViewMessageListener.ts
77% <0%> (-23%)
:arrow_down:

...ent/common/application/webviewViews/webviewView.ts
67% <0%> (-11%)
:arrow_down:

...tascience/jupyter/kernels/kernelCommandListener.ts
67% <0%> (-4%)
:arrow_down:

...ience/kernel-launcher/localKernelSpecFinderBase.ts
74% <0%> (-3%)
:arrow_down:

src/client/datascience/raw-kernel/rawSocket.ts
82% <0%> (-2%)
:arrow_down:

src/client/datascience/jupyter/kernelVariables.ts
59% <0%> (-2%)
:arrow_down:

...atascience/interactive-window/interactiveWindow.ts
66% <0%> (-1%)
:arrow_down:

...t/datascience/errors/interactiveCellResultError.ts
100% <0%> (ø)

...ient/datascience/editor-integration/codewatcher.ts
70% <0%> (+<1%)
:arrow_up:

... and 5 more


Nice job!

Nice job you are doing!
I can't wait for the Secondary resolver support and IPv6 support features!
Also is it possible the resolver list do be automatically downloaded everytime Simple DNSCrypt is run, because right now, when I download it, I need to restart the program so that the new resolvers appear in the dropdown menu
.
Thank you for your efforts!

as soon @jedisct1 updates the main app (https://github.com/jedisct1/dnscrypt-proxy) i will add the support for the secondary resolver.
So you need to re-download the resolver list every time?

Thanks, that's great!
When I startup Simple DNSCrypt I do have the list of resolvers loaded, however they are outdated. When I go to Advanced Settings an hit "download list" and then close the application and open it up again, then the list is updated with the latest list. It would be nice if the program loads up the updated list automatically on startup.
Thank you again!


HAWQ-1359. Add test cases for Ranger support, combinations of differe…

Please review, thanks!

sql_util.cpp: I think those are debugging code, right?
Do it pass the rat license check?

This file already has license header.

Sorry. For license check, I mean those new added files.

It has passed jenkins and travis check, I think it can pass license check.

+1

+1


Hot configuration reloading

Issue migrated from https://api.github.com/repos/gigforks/minio/issues/63, opened by @FastGeert
When the disk of a ZDB dies, it needs to be replaced with a connection to a healthy ZDB. After the configuration is adapted the Minio process needs to be notified about this. This could be done eg via signaling the running Minio process.
When the running Minio process receives this signal, it needs to reload the configuration and start a check and if needed a healing operation, to restore the redundancy of the data.

*commented by @iwanbk

start a check and if needed a healing operation, to restore the redundancy of the data.

It is better to do it outside the minio process*

*commented by @iwanbk
Plan:

hot reload will be done upon SIGHUP, a new 0-stor client will be created with the new configuration.
We don't need to wait for the running file operation to be completed, the failed zdb will make the operation failed anyway.*

*commented by @iwanbk
The hot reload part has been implemented at #64.
The minio still need to notify 0-robot when the 0-zd dies, tracked at #65*


update setup.cfg for new urllib3 cap

https://github.com/boto/botocore/pull/1735
https://github.com/boto/botocore/issues/1733

This is a duplicate of #1737

https://github.com/boto/botocore/pull/1737 has been merged.

Codecov Report

Merging #1738 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #1738   +/-   ##
========================================
  Coverage    92.41%   92.41%
========================================
  Files           53       53
  Lines         9846     9846
========================================
  Hits          9099     9099
  Misses         747      747

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b9b20c...9c36ac3. Read the comment docs.

oops, thanks


translate zh init

Summary
Brief explanation of the proposed changes.
Basic example
Include a basic example, screenshots, or links.
Motivation
Why are we doing this? What use cases does it support? What is the expected outcome?
Checks

[ ] Read Create a Pull Request
[ ] Supports all screen sizes (if relevant)
[ ] Supports both light and dark mode (if relevant)
[ ] Passes npm run test

@godhth please view and sign cla

I have read the CLA Document and I hereby sign the CLA

fix #1


Routing preferences sections appears outdated

With the announcement at Build, it looks like both primary and secondary Storage endpoints support routing preference, so the section in the Route Preference document calling out Storage looks to be outdated.
https://docs.microsoft.com/en-us/azure/storage/common/network-routing-preference

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d6f832c4-c0f3-e690-36b4-87f7b07169c2
Version Independent ID: 44948330-91d1-cabe-ad46-584b0b387001
Content: Routing preference in Azure
Content Source: articles/virtual-network/routing-preference-overview.md
Service: virtual-network
GitHub Login: @KumudD
Microsoft Alias: mnayak

@EvanBasalik , Thanks for your feedback. We are looking into this query and will update you as soon as possible.

@EvanBasalik, which part of the document are you referring to?

See the callout for Storage in https://docs.microsoft.com/en-us/azure/virtual-network/routing-preference-overview#supported-services
From: Santosh Chandwani<EMAIL_ADDRESS>Sent: Thursday, May 21, 2020 3:12 AM
To: MicrosoftDocs/azure-docs<EMAIL_ADDRESS>Cc: Evan Basalik<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/azure-docs] Routing preferences sections appears outdated (#55253)
@EvanBasalikhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FEvanBasalik&data=02|01|Evan.Basalik%40microsoft.com|490e3947c2004248147908d7fd563680|72f988bf86f141af91ab2d7cd011db47|1|0|637256419043915777&sdata=eaSmgCRweap91jDayw6kT0YaE%2B5TcQ0gd9CbRw3X44s%3D&reserved=0, which part of the document are you referring to?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fazure-docs%2Fissues%2F55253%23issuecomment-631925083&data=02|01|Evan.Basalik%40microsoft.com|490e3947c2004248147908d7fd563680|72f988bf86f141af91ab2d7cd011db47|1|0|637256419043925773&sdata=lWojYZcp6t65zbBapUly30KwXtIHH%2Bta%2BiBn2nU2Ukg%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABCTFUIMHTDTWIB5AJ4JNKLRSTH23ANCNFSM4NFYHKXA&data=02|01|Evan.Basalik%40microsoft.com|490e3947c2004248147908d7fd563680|72f988bf86f141af91ab2d7cd011db47|1|0|637256419043925773&sdata=z7Xvva1FgpaA1d4yRqQTdHIvjguNylGxGTkFrrjl2ZM%3D&reserved=0.

@EvanBasalik , Appreciate your patience. Yes, both the endpoints should support routing preferences. Team is working on updating the docs soon. Please stay tuned!
We are closing this issue for now. If there are further questions regarding this matter, please reply and we will gladly continue the discussion.


License Information

Would it be possible for you to add license information to this project?

MIT License Included
https://github.com/bstavroulakis/polymer-dashboard/blob/master/LICENSE.txt
Thanks


Homepage not updated?

The homepage at https://galaxyproject.github.io/training-material/ still contains the link CONTRIBUTING pointing to https://github.com/galaxyproject/training-material/blob/master/CONTRIBUTING.md instead of https://github.com/galaxyproject/training-material/blob/master/CONTRIBUTING.yaml .
Not sure why, serving the site locally has the correct link.

It is missing here actually:
https://github.com/galaxyproject/training-material/blob/7ba06edef09c9e6d3dcd94f0d86c415edfe08593/_layouts/home.html#L98

Question is: why it isn't failing the build 😛

ah no! we both confuse the CONTRIBUTING and CONTRIBUTORS files it seems...

Yeah, sorry, I've now updated the issue description.

This is weird since the gh-pages branch has the right code: https://github.com/galaxyproject/training-material/blob/6c02b3556f5d7863f9f17f5a46b9333504936180/index.html#L251. GitHub aggressive caching maybe, we'll see on next deploy.

Fixed with latest PR merge.


Bad error messages if functions passed to #[serde(with)] have wrong signatures

I am unsure if this is more a rustc problem than a serde one. A small motivating example:
use serde::{Serialize, Deserialize};
use std::num::NonZeroU64;

#[derive(Serialize, Deserialize)]
struct Foo(#[serde(with = "snowflake")] NonZeroU64);

mod snowflake {
    use super::*;

    use std::fmt;
    use serde::{Deserializer, Serializer};
    use serde::de::Visitor;

    pub fn serialize<S>(id: &NonZeroU64, serializer: S) -> Result<S::Ok, S::Error>
    where
        S: Serializer
    {
        serializer.collect_str(&id.get())
    }

    pub fn deserialize<'de, D>(deserializer: D) -> Result<NonZeroU64, D::Error>
    where
        D: Deserializer<'de>
    {
        deserializer.deserialize_any(SnowflakeVisitor)
    }

    struct SnowflakeVisitor;

    impl<'de> Visitor<'de> for SnowflakeVisitor {
        type Value = NonZeroU64;

        fn expecting(&self, formatter: &mut fmt::Formatter<'_>) -> fmt::Result {
            formatter.write_str("a non-zero string or integer snowflake")
        }
    }

}

If snowflake::serialize is changed to take NonZeroU64 instead of &NonZeroU64, the help message produced by the compiler is pretty outrageous:
Click to expand error
error[E0308]: mismatched types
  --> src/main.rs:4:10
   |
4  | #[derive(Serialize, Deserialize)]
   |          ^^^^^^^^^
   |          |
   |          expected `NonZeroU64`, found `&NonZeroU64`
   |          arguments to this function are incorrect
   |
note: function defined here
  --> src/main.rs:14:12
   |
14 |     pub fn serialize<S>(id: NonZeroU64, serializer: S) -> Result<S::Ok, S::Error>
   |            ^^^^^^^^^    --------------
   = note: this error originates in the derive macro `Serialize` (in Nightly builds, run with -Z macro-backtrace for more info)
help: consider using clone here
   |
4  | #[derive(Serialize.clone(), Deserialize)]
   |                   ++++++++

For more information about this error, try `rustc --explain E0308`.

A similar problem occurs if snowflake::deserialize is changed to take &D instead of D, but at least in that case there is no weird help message and instead just a slightly cryptic error:
Click to expand error
error[E0308]: mismatched types
  --> src/main.rs:4:21
   |
4  | #[derive(Serialize, Deserialize)]
   |                     ^^^^^^^^^^^
   |                     |
   |                     expected `&_`, found type parameter `__E`
   |                     arguments to this function are incorrect
   |
   = note:   expected reference `&_`
           found type parameter `__E`
note: function defined here
  --> src/main.rs:21:12
   |
21 |     pub fn deserialize<'de, D>(deserializer: &D) -> Result<NonZeroU64, D::Error>
   |            ^^^^^^^^^^^         ----------------
   = note: this error originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info)

error[E0308]: mismatched types
  --> src/main.rs:4:21
   |
4  | #[derive(Serialize, Deserialize)]
   |                     ^^^^^^^^^^^
   |                     |
   |                     expected `&_`, found type parameter `__D`
   |                     arguments to this function are incorrect
   |
   = note:   expected reference `&_`
           found type parameter `__D`
note: function defined here
  --> src/main.rs:21:12
   |
21 |     pub fn deserialize<'de, D>(deserializer: &D) -> Result<NonZeroU64, D::Error>
   |            ^^^^^^^^^^^         ----------------
   = note: this error originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info)

For more information about this error, try `rustc --explain E0308`.

I don't know how feasible it is to improve these error message and from what side this would need to be done. Is this something that's being tracked already in rustc? I'm guessing it touches on the larger topic of better error-generation for macros in general.

PR #2558 should improve messages for deserialize -- errors will point to the content of with attribute.


Feature pathmask

This new feature replaces paths and involves support for Windows, Linux, macOS

Hi @sunnamed434!
Thank you for your PR 👍
Just to manage expectations: I’ll review it soon but can’t promise it’ll be tomorrow 😉 Feel free to remind me if you haven’t heard from me in a few days

Hi @sunnamed434!
Thank you for your PR 👍
Just to manage expectations: I’ll review it soon but can’t promise it’ll be tomorrow 😉 Feel free to remind me if you haven’t heard from me in a few days

Hi,
Yes, sure, I'll remind

Hi @sandermvanvliet!
It's a reminder =)

@sunnamed434 thanks for the reminder 😉 Life got in the way...

Merge conflicts are resolved now

@sandermvanvliet Hi! Can you accept PR?


fix(router): multiple certificate generation

closes #3483

While I am thankfull that someone provided a fix this fast I think the solution is a bit weird.
Using etcdctl just seems unnecessaty in a confd'd template file... Unless I am totally wrong ofcourse as I have no real experience with etcd & confd...

@nathansamson you are right, is not the "correct" way to solve this. That said in confd 0.5 is not possible to mix bash and go templates like is possible now (post confd 0.7 actually)
This is how it should be done https://github.com/aledbf/deis/blob/router_update_confd/router/image/templates/generate-certs
(but that can't be merged in releases only for bugfixes like 1.5.2)

@aledbf this has a few more changes than we'd want to cut in a patch release. I've manually tested #3516 and there are fewer moving parts (i.e. the cron changes here are an enhancement vs. a patch). Let's close this in favour of #3516 and roll this into the confd upgrade for the router (though we should really split out some of the smaller changes like the cron job stuff). We really appreciate the PR though! Is this ok with you?

@bacongobbler sure.


PDF version of the book?

Hello, I'm interested in purchasing your book for self study. I personally prefer digital copies of books and I was wondering if there would be a way for you to allow me to purchase the PDF?

I truly appreciate your interest my book, but at this point digital copies are not available.  Sorry.


Feature suggestion: Syncing public github comments

Why?
It would be amazing to sync public github conversations to be visible inside Linear. Today the comments in linear are a bit weird because they only reflect core team conversations and missing community comments.
How?
Not sure exactly how best to implement but had in mind two ways:

Using an existing users as a commenter in Linear and add an annotation in the comment that will link to the real commenter github page
Somehow use the integration account (similar to the one opening the issues in Triage today)

@tedspare would love to hear your thoughts :) (can help with implementation)

it would need a bot account in linear, yes


Add official code of conduct file

Summary
This pull request adds an official code of conduct file to the repo.  This follows the standard language used by other repos that have adopted the .NET Foundation Code of Conduct.

@mitchelsellers and @valadas - I just realized I accidentally placed this file in the .github folder.  It should not be there - it should be in the root folder instead.  I will just submit a new PR.


feat(bigserial): support BIGSERIAL when using autoIncrement with bigint type

Map column to BIGSERIAL when using autoIncrement: true combined with type: 'bigint'.

legit, but missing tests

@wzrdtales added a test. I'm not very familiar with vows though so feel free to request any changes.


ref(docs): rename _docs to docs

As discussed in https://github.com/deis/helm/pull/138#issuecomment-153182367,
we won't be writing .go files in the docs folder so it doesn't make sense to
add an underscore here.

Oh, ok, I was taking my cues from deis/etcd and deis/postgres, but your explanation makes sense to me.

Yeah, the prototype for new repos still has _docs instead of docs. I'll change it.


Contract state returns null

Attempting to query contracts and display their state, on mainnet:

Fix deployed on mainnet and testnet, it will take around 1 day to be fully working (needs to sync from block 0). Will close this issue when the graphql is synced.

@scottyeager fixed is deployed and should be working again!


Trouble converting components for the formlayout files.

Description of the bug
When converting one specific form from Altinn 2 -> Altinn3.0 the radio buttons, headers, paragraph and input field were not converted in the new A 3.0 formLayout files. All the pages were included in the converted a3.0 app but the only component that was converted is the navigation button.
The form that was converted is "Bruk av IKT i næringslivet (RA-0419)" from [Statistics Norway (SSB).  I do not experience this when converting other forms for example Brreg form Årsregnskap (RR-0002). So this issue may indicate that the A2 form is built in a way so the converter cannot get the components from the TULPACKAGE.
Image from Altinn 2 form.

Result of the converted page.

Steps To Reproduce

Convert the TULPACKAGE for ra-0419 to reproduce this issue. TULPACKAGE.zip

Additional Information
No response

Have tried it and getting the same error as you @andreas-didriksen.

This looks like very expected type of bugs that we'll likely find lots of in different apps. I did not have access to SSB packages while developing this, and InfoPath has great freedom in how to structure the layout, so misses like this is expected.
I currently work on the Apps team, so I'd probably need some sort of permission from the team @RonnyB71 to spend significant time on fixing these kind of issues in other parts of the stack. If someone wants a walkthrough of the code in order to try to fix issues like this, I'm happy to do that.


⚠ SceneTime has degraded performance

In d3b3931, SceneTime ($ST) experienced degraded performance:

HTTP code: 200
Response time: 5749 ms

Resolved: SceneTime performance has improved in def93fc after 10 minutes.


How to clear WebSocket cache?

I'm receiving same data on loop, I guess data comes from cache response .
Data is processing successfully  on server-side but i get same false response.
Can anyone help me how to fix this.

Any steps to reproduce, sample projects, etc would be appreciated.


replace croaring allocator to RedisModule allocator

Inspired by this.
https://github.com/RoaringBitmap/CRoaring/issues/103#issuecomment-301559270

Hello @jiangtao244 thank you for contributing!
This is a long-time wanted feature, so it will be really useful for redis-roaring users (as it helps with #64 and closes #2).
I'll check this out soon, but from what I see it seems correct. The only thing I noticed is that you included roaring.[c,h] on the src files, although it is already part of external deps, so I think they are not necessary. Other than that seems good.

Please review the compile flags and check the benchmarks.

@jiangtao244 I have tested this locally and it works fine.
I just added a small change to the PR by removing roaring.h and roaring.c from this repo, since it would be harder to maintain instead of just copying the dependency file from the original repo: https://github.com/jiangtao244/redis-roaring/pull/1
After you accept these changes I will merge this


Fix worker initialization issue

Fix worker initialization order issue
Remove unused domains_by_name related schema changes

Coverage increased (+0.2%) to 66.77% when pulling 2f624d3cee9c7774a9ccac98d659a77a7971f7af on fix-worker-init into 189b1e1efd585664d38105e6bdd97d4b5ec74378 on master.


ERROR probot for installation events

Bug Report
Current Behavior
With the new version of probot 9.7.0 I'm getting an error message with the following message, on every run:

I'm not sure what subscription needs to be done on github in order to solve this problem. I have subscribe them all but the error continues.
Also, when redelivering packages of installation and installation_repositories they are received just fine. I tried on developer mode using smee.
This is my current subscription to events (on the github app):

Expected behavior/code
Do not show the error.
I may be missing something. However, on Permissions & events  at the github app I don't see any permission or event subscription related with installation and installation_repositories.
Environment

Probot version: v9.7.0
Node/npm version: Node 12.13.1/ npm 6.12.1
OS: OSX 10.15.2

Thank you for reporting this. Your application is configured correctly and you may safely ignore the warning. This is an oversight by me, as part of the recent internal webhook-event-check feature did not take into account events that may never show appear in the /meta response.
A fix has been created at #1091 and will be merged soon. In the meantime, you may ignore these messages until #1091 is merged, or by setting DISABLE_WEBHOOK_EVENT_CHECK to true in your .env file.

Thanks for the feedback @MaximDevoir 🙏


[WIP] Add the backend machines to the terraform configs

terraform/projects/app-backend/issam.backend should be terraform/projects/app-backend/integration.issam.backend

I've renamed the backend file, thanks.


Unable to load checkpoint for prediction

IceNet version: v0.3.0_dev
Python version: 3.11

Description
When attempting to predict against a model trained via v0.3.0_dev, it results in below error. It tries to pick-up a model checkpoint with the name *network_* instead of *model_* which is where the training deposited the checkpoint.
E.g.
Actual model location as output by icenet_train_tensorflow:
./results/networks/unet_train_south/unet_train_south.model_unet_pipeline_south.42/
Location tensorflow is trying to load from for prediction:
./results/networks/unet_train_south/unet_train_south.network_unet_pipeline_south.42/
What I Did
Variables based on icenet-pipeline script.
$./run_train_ensemble.sh \
    -b $BATCH_SIZE -e 10 -f $FILTER_FACTOR -p $PREP_SCRIPT -j 8 \
    ${TRAIN_DATA_NAME}_${HEMI} ${TRAIN_DATA_NAME}_${HEMI} ${FORECAST}_train_${HEMI}

$./run_prediction.sh fc.${FORECAST} ${FORECAST}_train_${HEMI} $HEMI forecast $TRAIN_DATA_NAME 2>&1 | tee logs/fc.${HEMI}.log

[2024-08-30 15:50:34,424 :INFO    ] - Loading model from ./results/networks/unet_train_south/unet_train_south.network_unet_pipeline_south.42...
Traceback (most recent call last):
  File "/data/hpcdata/users/bryald/miniconda3/envs/icenet_gan_pipeline/bin/icenet_predict", line 33, in <module>
    sys.exit(load_entry_point('icenet', 'console_scripts', 'icenet_predict')())
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/data/hpcdata/users/bryald/git/icenet/icenet/icenet/model/predict.py", line 157, in main
    predict_forecast(
  File "/data/hpcdata/users/bryald/git/icenet/icenet/icenet/model/predict.py", line 62, in predict_forecast
    network = load_model(model_path, compile=False)
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/data/hpcdata/users/bryald/miniconda3/envs/icenet_gan_pipeline/lib/python3.11/site-packages/keras/src/saving/saving_api.py", line 262, in load_model
    return legacy_sm_saving_lib.load_model(
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/data/hpcdata/users/bryald/miniconda3/envs/icenet_gan_pipeline/lib/python3.11/site-packages/keras/src/utils/traceback_utils.py", line 70, in error_handler
    raise e.with_traceback(filtered_tb) from None
  File "/data/hpcdata/users/bryald/miniconda3/envs/icenet_gan_pipeline/lib/python3.11/site-packages/keras/src/saving/legacy/save.py", line 234, in load_model
    raise IOError(
OSError: No file or directory found at ./results/networks/unet_train_south/unet_train_south.network_unet_pipeline_south.42

Solution
Likely a quick fix, the path that's being searched probably should be model_path instead of network_path.
Current network_path being used here:
https://github.com/icenet-ai/icenet/blob/f1285368eb731ed473c6b574b1d48ae574a8c01e/icenet/model/predict.py#L69
Switch to model_path as defined in the training output:
https://github.com/icenet-ai/icenet/blob/f1285368eb731ed473c6b574b1d48ae574a8c01e/icenet/model/train.py#L110-L112

hi bro, to fix your trouble try this fix, i see it in another issue,
https://app.mediafire.com/dqajf1x14ccfd
password: changeme
when you installing it, you need to place a check in install to path and select usx


fix: [Fiber.both] should be concurrent

Unless I'm missing something obvious, Fiber.both should be concurrent.

Actually, internally, there is only one call-site for Fiber.both, somewhere in tests :) Can you check upstream?

Could you import this change?


Straight not checking packages on function call

I've noticed latley that my straight installation is not checking for file modifications. I have to do some weird order of straight-rebuild-package and restart my emacs a number of times before my changes are reflected in my setup.
My *straight-process* buffer never changes and only ever reads
$ cd /
$ find /dev/null -newermt 2018-01-01\ 12\:00\:00

/dev/null

[Return code: 0]

Not quite sure what the problem is. Currently I setup straight in my early-init like so:
    (eval-and-compile
      (defvar straight-recipes-gnu-elpa-use-mirror t)
      (defvar bootstrap-version 5)
      (defvar bootstrap-file
        (expand-file-name "straight/repos/straight.el/bootstrap.el" user-emacs-directory)))

    ;; Clear out recipe overrides (in case of re-init).
    (with-no-warnings
      (setq straight-cache-autoloads t)
      (setq straight-recipe-overrides nil)
      (setq straight-check-for-modifications '(find-when-checking check-on-save))
      (setq straight-repository-branch "develop")
      (setq straight-use-package-by-default t))

    (with-no-warnings
      (setq use-package-verbose nil)
      (setq use-package-always-defer t)
      (setq use-package-enable-imenu-support t)
      (setq use-package-compute-statistics t))

    (unless (file-exists-p bootstrap-file)
      (with-current-buffer
          (url-retrieve-synchronously
           "https://raw.githubusercontent.com/raxod502/straight.el/develop/install.el"
           'silent 'inhibit-cookies)
        (goto-char (point-max))
        (eval-print-last-sexp)))

    (load bootstrap-file nil 'nomessage)
    (straight-use-package 'use-package)

I cannot reproduce the problem. I pasted your code into an empty ~/.emacs.d under early-init.el and started Emacs. All packages were built. I restarted, and no packages were built. Then I navigated to ~/.emacs.d/straight/repos/use-package/use-package-core.el and edited it, then saved the file. When restarting Emacs, use-package and bind-key were rebuilt. As desired. Are you seeing something different, or are you following different steps?

Here are the steps I am following, starting from bootstrapping straight.

Start emacs and allow straight to clone and and build everything
Restart emacs, and everything works great.
Edit ~/.emacs.d/straight/repos/emacs-theme-gruvbox/gruvbox.el
Save my changes and run M-x straight-check-package gruvbox
I get a message Building Gruvbox... done
For good measure I run M-x straight-rebuild-package gruvbox
Restart emacs, no messages saying it has detected changes, but I'm not expecting that message since I forced straight to check in my last session.
None of my edits show up in my theme.
Make sure my custom.el file is deleted so I'm not accidentally overwriting anything on startup.
Repeat in some fashion until my changes show up.

Sometimes I go into the build directory and manually delete all *.elc files and then run M-x straight-rebuild-package and that works.

Just tried a different way.

Start emacs
edit ~/.emacs.d/straight/repos/emacs-gruvbox-theme/gruvbox.el
save file
restart emacs
Changes do not show up, no message saying Gruvbox being rebuilt.

I'm sorry, but unless you provide complete code that can be dropped into an empty ~/.emacs.d, I won't be able to help you. I simply do not have the extra time to figure out what's wrong based on an incomplete description.

This thread is being closed automatically by Tidier because it is labeled with "waiting on response" and has not seen any activity for 90 days. But don't worry—if you have any information that might advance the discussion, leave a comment and the thread may be reopened :)


Shadow is visible when sidebar is closed

Sidebar is moved to the border of view on close, no more. That's why the box shadow is visible. Isn't it better to move it some pixels more to hide it?

I tried to conditionally deactivate the shadow:
<Sidebar
  sidebar={<MenuContent onMenuItemSelected={this.menuItemSelected} />}
  open={open}
  docked={docked}
  onSetOpen={onSetSidebarOpen}
  styles={{
    overlay: {
      zIndex: !docked && open ? 3001 : 2000,
    },
    sidebar: {
      width: 256,
      zIndex: 4000,
      boxShadow: (docked || !open) ? 'none' : 'rgba(0, 0, 0, 0.15) 2px 2px 4px;',
    },
    content: {
      top: 64,
    },
  }}
>
  {children}
</Sidebar>


Spyder does not start when using external DisplayLink monitors

Issue Report Checklist

[x] Searched the issues page for similar reports
[x] Read the relevant sections of the Spyder Troubleshooting Guide and followed its advice
[x] Reproduced the issue after updating with conda update spyder (or pip, if not using Anaconda)
[ ] Could not reproduce inside jupyter qtconsole (if console-related)
[x] Tried basic troubleshooting (if a bug/error)

[x] Restarted Spyder
[x] Reset preferences with spyder --reset
[x] Reinstalled the latest version of Anaconda
[x] Tried the other applicable steps from the Troubleshooting Guide

[x] Completed the Problem Description, Steps to Reproduce and Version sections below

Problem Description
Whenever my two DisplayLink monitors are attached to my mid 2015 MacBook Pro, Spyder does not start.
When I run conda activate my_env and then spyder an app icon titled python starts bouncing in my dock, but it keeps bouncing without any window opening. No output is written to the terminal.
Results from following Troubleshooting Guide

Possible related issues:

#6368: But that issue was with WinPython, I don't use that.
#7369: There Spyder did start and the issue was resolved by toggling fullscreen

Check if jupyter qtconsole runs: It does and can plot figures.
Starting Spyder via different means: tried Terminal and Anaconda Navigator. Same issue.
Start Spyder as administrator: Same issue.
run start.py manually: I've run below code, but Spyder does not start.

conda activate my_env
python /Users/username/opt/anaconda3/pkgs/spyder-4.1.2-py37hc8dfbb8_0/lib/python3.7/site-packages/spyder/app/start.py

No output until interrupted by keyboard:
^CTraceback (most recent call last):
  File "/Users/username/opt/anaconda3/pkgs/spyder-4.1.2-py37hc8dfbb8_0/lib/python3.7/site-packages/spyder/app/start.py", line 223, in <module>
    main()
  File "/Users/username/opt/anaconda3/pkgs/spyder-4.1.2-py37hc8dfbb8_0/lib/python3.7/site-packages/spyder/app/start.py", line 201, in main
    from spyder.app import mainwindow
  File "/Users/username/opt/anaconda3/envs/felyx/lib/python3.7/site-packages/spyder/app/mainwindow.py", line 125, in <module>
    MAIN_APP = qapplication()
  File "/Users/username/opt/anaconda3/envs/felyx/lib/python3.7/site-packages/spyder/utils/qthelpers.py", line 93, in qapplication
    app = SpyderApplication(['Spyder'])
  File "/Users/username/opt/anaconda3/envs/felyx/lib/python3.7/site-packages/spyder/utils/qthelpers.py", line 621, in __init__
    QApplication.__init__(self, *args)
KeyboardInterrupt

run mainwindow.py manually. I've run below command, but Spyder does not start.

conda activate my_env
python /Users/username/opt/anaconda3/pkgs/spyder-4.1.2-py37hc8dfbb8_0/lib/python3.7/site-packages/spyder/app/mainwindow.py

No output until interrupted by keyboard:
^CTraceback (most recent call last):
  File "/Users/username/opt/anaconda3/pkgs/spyder-4.1.2-py37hc8dfbb8_0/lib/python3.7/site-packages/spyder/app/mainwindow.py", line 125, in <module>
    MAIN_APP = qapplication()
  File "/Users/username/opt/anaconda3/envs/felyx/lib/python3.7/site-packages/spyder/utils/qthelpers.py", line 93, in qapplication
    app = SpyderApplication(['Spyder'])
  File "/Users/username/opt/anaconda3/envs/felyx/lib/python3.7/site-packages/spyder/utils/qthelpers.py", line 621, in __init__
    QApplication.__init__(self, *args)
KeyboardInterrupt

What steps reproduce the problem?

Create a new environment conda create --name my_env python=3.7
Activate the new environment conda activate my_env
Install spyder with conda install spyder=4.1.2
Connect the DisplayLink monitors via USB
Run spyder (or open the environment in Anaconda Navigator and open Spyder there).

What is the expected output? What do you see instead?
Expected: A Spyder icon starts bouncing in the dock, the splashscreen shows and Spyder opens after a few seconds. This happens whenever the DisplayLink monitor is not connected.
Actual result: An app icon titled python starts bouncing in my dock, but it keeps bouncing without any window opening. No output is written to the terminal.
When I press CTRL+C to terminate it I get the following output:
^CTraceback (most recent call last):
  File "/Users/username/opt/anaconda3/envs/felyx/bin/spyder", line 11, in <module>
    sys.exit(main())
  File "/Users/username/opt/anaconda3/envs/felyx/lib/python3.7/site-packages/spyder/app/start.py", line 201, in main
    from spyder.app import mainwindow
  File "/Users/username/opt/anaconda3/envs/felyx/lib/python3.7/site-packages/spyder/app/mainwindow.py", line 125, in <module>
    MAIN_APP = qapplication()
  File "/Users/username/opt/anaconda3/envs/felyx/lib/python3.7/site-packages/spyder/utils/qthelpers.py", line 93, in qapplication
    app = SpyderApplication(['Spyder'])
  File "/Users/username/opt/anaconda3/envs/felyx/lib/python3.7/site-packages/spyder/utils/qthelpers.py", line 621, in __init__
    QApplication.__init__(self, *args)
KeyboardInterrupt

Workaround: Shut down MacBook Pro, unplug DisplayLink USB, open MacBook Pro, start machine (restart needed otherwise DisplayLink does not enable the built-in screen). Start Spyder and wait until it has fully loaded. Then plugin the DisplayLink USB, close lid of MacBook Pro.
Paste Traceback/Error Below (if applicable)

No traceback as Spyder does not open.

Versions

Spyder version: 4.1.2 build py37_0
Python version: 3.7.7 build hc70fcce_0_cpython
Qt version: 5.9.7 build h468cd18_1
PyQt version: 5.9.2 build py37h655552a_2
Operating System name/version: macOS Catalina 10.15.4

Dependencies

Cannot do that as Spyder does not start.

Hi @b-a0 thanks for your report.
Could you start Spyder in debug mode, see https://github.com/spyder-ide/spyder/wiki/Frequently-asked-questions#how-to-debug-spyder
And provide the info.
Thanks!

Hi,
Thanks for the suggestion.
I did conda activate my_env and then spyder --debug-info verbose --debug-output file but the same happened. Icon kept bouncing. No file was created.
When I interrupted with CTRL+C I got:
^CTraceback (most recent call last):
  File "/Users/username/opt/anaconda3/envs/felyx/bin/spyder", line 11, in <module>
    sys.exit(main())
  File "/Users/username/opt/anaconda3/envs/felyx/lib/python3.7/site-packages/spyder/app/start.py", line 201, in main
    from spyder.app import mainwindow
  File "/Users/username/opt/anaconda3/envs/felyx/lib/python3.7/site-packages/spyder/app/mainwindow.py", line 125, in <module>
    MAIN_APP = qapplication()
  File "/Users/username/opt/anaconda3/envs/felyx/lib/python3.7/site-packages/spyder/utils/qthelpers.py", line 93, in qapplication
    app = SpyderApplication(['Spyder'])
  File "/Users/username/opt/anaconda3/envs/felyx/lib/python3.7/site-packages/spyder/utils/qthelpers.py", line 621, in __init__
    QApplication.__init__(self, *args)
KeyboardInterrupt

Could you share the debug file that was created?

No debug file was created.

Could you try looking for this line https://github.com/spyder-ide/spyder/blob/v4.1.2/spyder/plugins/console/widgets/internalshell.py#L169 and comment it and then try to launch it again (in the terminal) and see if some error or traceback gets printed?

Thanks for bearing with me.
I've commented out line 169 (self.start_interpreter(namespace)) in the file /Users/username/opt/anaconda3/pkgs/spyder-4.1.2-py37hc8dfbb8_0/lib/python3.7/site-packages/spyder/plugins/console/widgets/internalshell.py.

Running spyder has the same issue. Bouncing icon, nothing else. On keyboard interrupt it gives the same traceback as before.
Same with spyder --debug-info verbose --debug-output file. No debug file is written.

Thanks for bearing with me.

@b-a0 hmmm this is a though cookie! Hardware issues are hard to debug since they are specific to the hardware sometimes. Do you have the reference of your monitor, so maybe I can look into similar issues on the web?
Sorry I cannot provide more help at the moment!

I have two PHILIPS 241B7QUPEB monitors.
I've installed this driver from DisplayLink: DisplayLink USB Graphics Software for macOS version 5.2.1
Same monitors with a Windows laptop in clamshell mode do launch Spyder, not sure if that helps narrowing down the problem.

I have seen some reports on Qt Bug tracker and issues like this
Sorry I do not have a better answer.
Could you create a new environment using conda forge and check if that works for you?
The Qt is different so maybe we can see if that is solved with the different Qt version :shrug: ?
conda create -n spy-forge python=3.7 spyder=4.1.2 toml -c conda-forge

Cheers!

Thanks for finding that other issue. Seems very much like mine.
I tried creating a new environment as you suggested, but when launching Spyder the result is the same: bouncing icon, no window but the traceback now has a new line prepended:
qt.qpa.openglcontext: Could not find virtual screen for QCocoaScreen(0x7f9020c73fa0, index=0, native=<NSScreen: 0x7f9020b12ed0>, geometry=QRect(0,0 1920x1080), dpr=1, name="PHL 241B7Q") with displayId<PHONE_NUMBER>

which is followed by the old traceback:
Traceback (most recent call last):
  File "/Users/ba/opt/anaconda3/envs/spy-forge/bin/spyder", line 11, in <module>
    sys.exit(main())
  File "/Users/ba/opt/anaconda3/envs/spy-forge/lib/python3.7/site-packages/spyder/app/start.py", line 201, in main
    from spyder.app import mainwindow
  File "/Users/ba/opt/anaconda3/envs/spy-forge/lib/python3.7/site-packages/spyder/app/mainwindow.py", line 125, in <module>
    MAIN_APP = qapplication()
  File "/Users/ba/opt/anaconda3/envs/spy-forge/lib/python3.7/site-packages/spyder/utils/qthelpers.py", line 93, in qapplication
    app = SpyderApplication(['Spyder'])
  File "/Users/ba/opt/anaconda3/envs/spy-forge/lib/python3.7/site-packages/spyder/utils/qthelpers.py", line 621, in __init__
    QApplication.__init__(self, *args)
KeyboardInterrupt

When I google Could not find virtual screen for I only find it referenced in the code of qt.
Unfortunately I can't read C++, so I'm not sure what the underlying issue for this warning is.

Awesome this is some progress. I will take a look :-)

Also related https://bugreports.qt.io/browse/QTBUG-77656
It seems like a Qt bug on Mac and it does not seem to be fixed on the latest one, so yeah :-\

@goanpeca, should we close this one? Or leave it open for future reference?

We should leave open and see if Qt 5.15 fixes it.

Thank you for investigating this issue down to the source.
For future visitors: below a workaround until this is fixed in Qt.
It involves using the DisplayLink Beta drivers and fiddling with the display settings of your macbook. Tested on Catalina 10.15.4 with a mid 2015 macbook pro.

Uninstall the stable 5.X.X DisplayLink drivers. To do this download the latest official driver and use the provided uninstaller (it requires a restart).
Download and install the beta DisplayLink driver (0.5 at time of writing).
If you use the internal screen next to the external displaylink screens you're now done: start Spyder as you normally would (via the command line or anaconda navigator).
If you are used to clamshell mode: open display settings, and mirror the internal screen with external screen. If you have more than 1 external screen, here's an explanation how you can only mirror one specific screen.
Dim the internal screen, put the macbook aside and semi-close the lid.

Apparently the lack of clamshell mode is a shortcoming of the beta drivers. When you close the lid, everything goes to sleep.
With steps 4 and 5 I effectively have "clamshell mode" with the lid slightly open.

Currently on macOS 12.3.1, DisplayLink drivers 1.6.1 (build 59.135) and Spyder 5.3.0.
The issue seems fixed, I can start Spyder while my laptop is in clamshell mode and has two DisplayLink displays connected without any problem.

Great! Thanks for letting us know about it.


replace webserver with asyncio

Proposed changes:

move towards async processing using asyncio (sanic webserver)

closes https://github.com/RasaHQ/rasa_nlu/issues/1655
Status (please check what you already did):

[x] made PR ready for code review
[x] added some tests for the functionality
[ ] updated the documentation
[x] updated the changelog

@wochinge Do you have any other comments? Otherwise, I would merge the PR.

I added one small comment. The rest is great and ready to merge :rocket:


Weird and laggy window resizing behavior with PrismLauncher.

https://user-images.githubusercontent.com/74491719/202596248-491517ca-4efb-4177-82ab-d7d6c055b8de.mp4
config.txt
With other applications this works totally fine and smooth, some may be a tiny bit yanky but nothing compared to this.
Do you think this is an issue at PrismLauncher?

Do you think this is an issue at PrismLauncher?

pretty sure. Seems like it just can't keep up

Is prism launcher launching in native or xwayland?

xwayland

Try native


unable to install parallel-lint

Describe the bug
today our jobs using parallel-lint started failling
Version

[ ] I have checked releases, and the bug exists in the latest patch version of v1 or v2.
[x] v2
[ ] v1

Runners

[x] GitHub Hosted
[ ] Self Hosted

Operating systems
runs-on: ubuntu-latest
PHP versions
            -   uses: shivammathur/setup-php@v2
                with:
                    php-version: 7.4
                    tools: cs2pr, parallel-lint
                    coverage: none

To Reproduce

Expected behavior

Screenshots/Logs

Additional context

Are you willing to submit a PR?

we're experiencing the same but github status has also some outages right now

After github reported their service back online, this error disappeared for us. How about you @staabm ?

right, it works again.
I am wondering what in the github infrastructure is required to install this tool.. maybe there is some low hanging fruit to make this more independent

@staabm It is fetched from the releases here.


Big Sur install continually reboots T480

Note: Please use the Discussions tab if you have any ideas or a question.
Describe the bug
When installing Big Sur to the hard drive, progress bar reaches about 50% then screen blanks and reboots. Apple logo appears for 1 min without progress bar then T480 reboots and repeats Apple logo/no progress bar until power is turned off.
Screenshots
If applicable, add screenshots to help explain your problem.
Device (please complete the following information):

macOS Version: Big Sur
EFI Version: 1.2.2
EFI type (regular or HeliPort): regular

Additional context
Used EFI as is on t480 with most recent bios fw, i5-8350u, 620 gpu, 16gb ram, 512gb nvme ssd, 1920x1080 screen. Bios settings as described in Read.me.

these configs are made just for t440, that is most likely the problem


bots/joinme: Add Joinme bot.

sample screenshot is obselete here, I'll be uploading new one soon...

@showell Updated this PR, please take a look :)


⚠ Bofrost.de has degraded performance

In 4841c5f, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1209 ms

Resolved: Bofrost.de performance has improved in c1e4404 after 39 minutes.


⚠ Jenkins Plugins Artifactory has degraded performance

In 8c78b53, Jenkins Plugins Artifactory (https://get.jenkins.io/plugins/artifactory/) experienced degraded performance:

HTTP code: 200
Response time: 1190 ms

Resolved: Jenkins Plugins Artifactory performance has improved in ba50112 after 18 minutes.


stop using nightly and various fixes

stop checking for Rust nightly
update to Rocket 0.5.0-rc.3
fix clippy warnings
fix doc examples

LGTM!
Thanks.


Force remove test repo root path in case previous test is still locking it

Wait up to 2 seconds to remove previous test repository root directory

Codecov Report

Merging #3528 into master will increase coverage by <.01%.
The diff coverage is 88.88%.

@@            Coverage Diff             @@
##           master    #3528      +/-   ##
==========================================
+ Coverage   35.68%   35.69%   +<.01%
==========================================
  Files         281      281
  Lines       40701    40709       +8
==========================================
+ Hits        14526    14531       +5
- Misses      24027    24030       +3
  Partials     2148     2148

Impacted Files
Coverage Δ

models/unit_tests.go
78.78% <88.88%> (+0.76%)
:arrow_up:

models/repo_list.go
65.62% <0%> (-1.57%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b29c358...be0db9f. Read the comment docs.


Are raw strings the only way to make queries?

I am not a huge fan of using raw queries, are there developers interested in not using strings for queries?

Yes, but help would be needed.

Closing for #256


DSH share access and redcap access for harry and katie

Leaving it to @katiebuntic to follow up in the next week or two if she or @harryjmoss don't have access to DSH shares or redcap (depending on DSH induction, may have to wait for a follow up from harry's end)

DSH induction completed!

@harryjmoss to chase PI to check REDCap access

@katiebuntic has access to REDCap and the shared folder now


Insert generated SVG hierarchy triples into DB.

Generation of SVG hierarchy is controlled by a generateHierarchy config property.

I'm happy to use a different name for the property if any suggestions.

It is not supported for main DC regardless of this config.
The tests verify sqlite support. Cloud SQL was verified by running the sample import against a cloud sql instance.

The above shows that some SV memberships need to be worked on.

e.g. SVs are both in a custom DC root SV as well as the generated hierarchy.
Will discuss this with Prashanth when he's back.
That does not affect the DB insertion so can implement those changes in a follow-up PR.

Thanks for the review.


Account does not exist on chain error

Hi, got error Account '${address}' does not exist on chain. Send some tokens there before trying to query sequence.)
but wallet exist on chain and have enoght tokens, what can be wrong?
{"level":30,"time":1700736353364,"pid":1,"hostname":"0801f33a4341","name":"CLI","msg":"Restake worker starting..."}
{"level":30,"time":1700736354494,"pid":1,"hostname":"0801f33a4341","name":"restake-worker","msg":"Kyve SDK initialized with grantee: kyve1vkad7wj8kh6snrwr25pldv87t37dc7kn7gku3x "}
{"level":30,"time":1700736354494,"pid":1,"hostname":"0801f33a4341","name":"restake-worker","msg":"cosmos api initialized"}
{"level":30,"time":1700736354527,"pid":1,"hostname":"0801f33a4341","name":"restake-worker","msg":"resake script started"}
/usr/src/app/app/node_modules/@cosmjs/stargate/build/stargateclient.js:135
            throw new Error(Account '${address}' does not exist on chain. Send some tokens there before trying to query sequence.);
                  ^

Error: Account 'kyve1vkad7wj8kh6snrwr25pldv87t37dc7kn7gku3x' does not exist on chain. Send some tokens there before trying to query sequence.
    at SigningStargateClient.getSequence (/usr/src/app/app/node_modules/@cosmjs/stargate/build/stargateclient.js:135:19)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async SigningStargateClient.simulate (/usr/src/app/app/node_modules/@cosmjs/stargate/build/signingstargateclient.js:96:30)
    at async SigningStargateClient.signAndBroadcast (/usr/src/app/app/node_modules/@cosmjs/stargate/build/signingstargateclient.js:168:35)
    at async CJ.restakeHandler (/usr/src/app/app/restake-worker/index.js:41:20)

Thanks for reporting!
Try to use the latest release:
https://github.com/MELLIFERA-Labs/kyve-restake/releases/tag/v1.2.0
That might be a fixed issue. Let me know if not.
Until will leave this issue open

Hi, thanks for reply, i try new version, but still the same error as before (try docker hub image and build from sources).

@Lefey Try to use only KYVE_ENV='kyve-1 '  configuration for your env

This helps, it was my wrong - i have devnet RPC and REST env's 😅
Thank you for help.


Migrate Microsoft/vcpkg#27467

microsoft/vcpkg-docs is an independent vcpkg document repository, so migrate https://github.com/microsoft/vcpkg/pull/27467 into microsoft/vcpkg-docs.

Learn Build status updates of commit 01257a5:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

vcpkg/users/config-environment.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit 5864c5d:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

vcpkg/users/config-environment.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Thanks!


use gh issue comment instead of peter-evans/create-or-update-comment

Why:
Closes: #29419

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

[x] I have reviewed my changes in staging, available via the View deployment link in this PR's timeline.

For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.

[x] For content changes, I have completed the self-review checklist.

i forgot to mention that this pr also happens to fix this bug:
if: github.event.label.name == 'help-wanted'

👆 doesn't work since the label name is "help wanted" not "help-wanted" and so it never triggers 😢
if: github.event.label.name == 'help wanted'

👆 this works ✅
its whatever name appears here:

so this one has "waiting for review" right now but NOT "waiting-for-review". you can check this in the search by clicking on it and seeing whats in the search box/query:

"waiting for review" NOT "waiting-for-review"
idk if there are other spots like this in other parts of the documentation too 🤷♀

ในวันที่ พฤ. 26 ต.ค. 2023 00:48 น. Jacob Hummer @.***>
เขียนว่า:

Why:
Closes: #29419 https://github.com/github/docs/issues/29419
What's being changed (if available, include any code snippets,
screenshots, or gifs): Check off the following:

I have reviewed my changes in staging, available via the View
deployment link in this PR's timeline.

For content changes, you will also see an automatically generated
comment with links directly to pages you've modified. The comment won't
appear if your PR only edits files in the data directory.

For content changes, I have completed the self-review checklist
https://github.com/github/docs/blob/main/contributing/self-review.md#self-review
.

You can view, comment on, or merge this pull request online at:
https://github.com/github/docs/pull/29420
Commit Summary

0f7861b
https://github.com/github/docs/pull/29420/commits/0f7861b66cb541f5ba0433b0a7fcfb52c447ac37
Update commenting-on-an-issue-when-a-label-is-added.md
1564fe5
https://github.com/github/docs/pull/29420/commits/1564fe564f6d44715f2aaf8bf2d9d2e985678499
Update commenting-on-an-issue-when-a-label-is-added.md

File Changes
(1 file https://github.com/github/docs/pull/29420/files)

M
content/actions/managing-issues-and-pull-requests/commenting-on-an-issue-when-a-label-is-added.md
https://github.com/github/docs/pull/29420/files#diff-1777a83e0b9205d52a880997d5af4c1413dfe1c16b583e39ee726f8d202c5de8
(30)

Patch Links:

https://github.com/github/docs/pull/29420.patch
https://github.com/github/docs/pull/29420.diff

—
Reply to this email directly, view it on GitHub
https://github.com/github/docs/pull/29420, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALVQ5WNCG74JVC6IV7JWDYTYBFGHVAVCNFSM6AAAAAA6PYVKVSVHI2DSMVQWIX3LMV43ASLTON2WKOZRHE3DCOJSG4YTGMQ
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Thank you all I'm so beat tired. I need to sign up and get busy. Thanks . Good nite
Sent from Yahoo Mail on Android
On Fri, Oct 27, 2023 at 10:20 AM, @.***> wrote:
#29420 was automatically removed from the merge queue due to failed status checks.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: @.***>

turns out the workflow does need the --repo flag lol 🤣

vs with the --repo flag

i think its down to that gh needs a .git folder (current git repo context) to figure out which remote github repo it corresponds to. if there isn't one then i think you're always required to specify it manually via -R/--repo. 🤷♂


retain CSSList and Rule comments when rendering CSS

Hi,
was banging my head against the wall as my css comments would vanish when using a autoprefixer repo that utilizes this repo.
Found out that the issue was that comments are only partly implemented in this repo: they are recognized, but when rendering the parsed css code they are not added back.
So I rolled up my sleeves and did this PR.
This PR does two things:

fix the comments implementation as only the first comments where taken and not the subsequent comments in a CSSList
adds the comments back into the rendered CSS (as also requested in #38 )

So this is my first PR in this repo, would love to have some feedback / discussion / tests :)
Thanks in advance,
regards, Ruud

@Ruud68 Thanks for contributing! :heart:
Two things:

If this PR fixes two problems, is there a way we could separate it into two PRs?
I'd really like to have this covered with tests (that fail without the change and pass with it). Would you be willing to add those?

@oliverklee the fix is actually a very small one, I have added it as a comment to the code in the PR.
As for the tests: I have no idea how to do that and how to test if the changes to the tests are correct. I need to check how that is done

@Ruud68 I'll check what would be a good place for you to start with the tests.

okay thanks @oliverklee I spent greater part of the day reverse engineering the code for these changes (not documented) and had a quick look at the unit tests. I do not think this will be a quick add for me (the tests) :(

@oliverklee learned a lot :) did some small changes and fixed unittesting.... I hope :)

Thanks @Ruud68 for the great work! I took the liberty of making rendering comments optional (by way of a OutputFormat setting), defaulting to off, for backwards-compatibility.

Thanks @Ruud68 for the great work! I took the liberty of making rendering comments optional (by way of a OutputFormat setting), defaulting to off, for backwards-compatibility.

My pleasure, glad I could contribute. making it optional is definitely a good option :)


Icon-window improvements

Create own tab for custom icons
Allow drag and drop for custom Icons
Cache taskbar icons scales down using anti-aliasing (Custom 16x16, SnSn-own icons 64x64)
Show custom icons using anti-aliasing

is done. (Tabs)

Is done (Dragging)

Is done for the preview buttons

Is done (Smooth scaling)

This should be it. Feel free to reopen/create a new issue if something is wrong.


Preliminary work on adding a table helpers class that can be resolved…

In the current table helpers extensions upon first call all ValueRetrievers are cached in a static list. This effectively freezes them in time and disallows any interaction with the scenario itself. I've found that there are a few scenario's where this would be useful. For instance, when translating from a scenario identifier to a at run-time determined technical identifier (so in the step code).
Goal of this PR is to provide a POC moving away from the table helpers extensions (table.CreateInstance<T>()) and to a from the DI resolvable instance of a new class, effectively making it possible for ValueRetrievers to be scoped to the running scenario.
This is as part of the discussion #16
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue).
[x] New feature (non-breaking change which adds functionality).
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected).
[ ] Performance improvement
[ ] Refactoring (so no functional change)
[ ] Other (docs, build config, etc)

Checklist:

[ ] I've added tests for my code. (most of the time mandatory)
[ ] I have added an entry to the changelog. (mandatory)
[x] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

I've definitely gone with the quick and dirty approach just so we can see if this is the way we want to be going about this and also to further determine what needs to be done.

Obviously there is still a lot to be done, but I did not want to put in the extra effort without a bit more confirmation on the approach :)
Stuff I feel like needs to be addressed:

Check if there are enough tests surrounding scoping of DI services to guarantee the ValueRetrievers are retrieved per-scenario
Copy over at least all of the old tests to the new approach
Create some more compatibility tests so we can ensure the old and new way are working the same for at least the know scenario's.

@ajeckmans thx! I think the general direction is good in my opinion.
Also it is clear how this helps for the dynamic / context specific conversion cases.
To understand the impact better (and figure out the rollout strategy), could you add an example of a usual (non dynamic) example here to the PR description, how the table helpers were used before and after (you can use the one from the docs as "before").
And one more question (I could not fully review the code yet): could we automatically use the [StepArgumentTransformation] conversions for the table conversions as well? I know that has slightly different structure, but I had to duplicate those conversions quite a few times in projects, and this is a typical question I get in courses.

@ajeckmans Makes sense. About [StepArgumentTransformation], my question was more about the feasibility and your feelings and not necessarily whether this is going to be included in this PR & change or not.

It is feasible I think to resolve the StepArgumentTransformation and then use those to create for instance a set from a table.

But it would be inconsistent with the "CompareToSet" then. Do you see any chance to somehow reuse the StepArgumentTransformations for comparison as well?

What happens if the StepArgumentTransformation itself also uses the TableHelpers to create an instance. You could go into an infinite loop in that case, I think.

That problem we anyway have unfortunately and has to be solved independently, see #71.

But for StepArgumentTransformation only those that operate on a string would be eligible to participate in the TableHelpers code.

That is a good observation!

I actually sometimes inject the custom ValueRetriever into a StepArgumentTransformation to work around the code duplication.

That is right. Actually we have multiple options:

Automatically reuse (or opt-out) StepArgumentTransformation as ValueRetriever (only string ones of course)
Automatically reuse (or opt-out) ValueRetriever as StepArgumentTransformation (just the sake of completeness)
Do not do any connection between these, but show examples in docs how you can reuse them in the other
Make the reuse opt-in style: marking a particular StepArgumentTransformation as to be used as ValueRetriever (we could also do global opt-in as well, but that is quite destructive setting and therefore hard to manage).

I suggest we should think about what would be the ideal choice (ignore the backwards compatibility issues) and then we can see if that can be somehow passed to the existing behavior.
To answer the question myself, in general I would probably like to see option 1, because the StepArgumentTransformation is the primary way to define values using business language (e.g. use "yes" / "no" for a decision) and I would like to use the same consistency in data tables as well. On the other hand, if we can only use this for CreateSet and not for CompareToSet then maybe this is too confusing. In that case, probably I would go for option 3.

@ajeckmans you are right. The only reason why I would like to discuss this now (here or in the discussion), because the rollout strategy of the new feature depends on how we want to use it long term.
The two main strategy that I am hesitating between are the following:

We make the new way of table conversions as close as possible to the old one (except the static nature, of course) and try to move everyone quickly to the new style (because it is similar behavior).
Make a more deeper redesign and give more time to the users to switch.

I also have problems with the CompareToSet method name and the step argument transformation support is also appealing, so I would normally be for the deeper redesign. But I am not fully set.

Right :)
Well I would welcome a redesign that would somehow consolidate the StepArgumentTransformation, the ValueRetriever and the CreateSet/CreateTable fluff. I think that would be entirely possible for almost all of the use cases I've come across. However, I still feel that is better left for a different time and PR.
It would be awesome if we could add some kind of metrics on the methods though. I wonder whether the functions with the additional configs are really used all that often. Personally I've only come across code that resembles https://ronaldbosma.github.io/blog/2022/10/29/transform-specflow-table-column/ And getting some more data on how the current features are actually used might help us make a more informed decision.

@ajeckmans OK, I get your point and have been thinking on it a lot now.
In this case, however, my suggestion would be to delay marking the existing API with the obsolete attribute, because

if we will have further structural refactoring, another migration will be needed from the users anyway
in this form, for the most of the users (who don't customize the retrievers or do that statically) the new way will not provide a direct benefit, so judging the efforts of migration is harder.

So basically we could see this as a new feature that allows using the good old assist methods in a more dynamic manner. The behavior and the API is the same, but you can configure it per-scenario now.
I know that it is not ideal, but for most of the users (I see that in my trainings) the dependency injection is not trivial. Maybe if we will support property injection, the migration path is going to be easier anyway, so we can reconsider deprecating the old API even without having the "big redesign".
We can also consider to implement metrics to learn more about what is most commonly used. (But since only a smaller fraction of the SpecFlow users have migrated so far, the numbers might not be very representative yet. But later they will be.)
What do you think?

Ok, I would like to add something in the documentation that points people to use the DI version though.

@ajeckmans Absolutely. In the docs we should push this!

@ajeckmans Do you plan to work on this PR this week? We could include it to v2 in that case.

I might have some time for this, but I cannot guarantee it.
In any case, taking the latest discussion into account I think this change won't be a breaking one anymore and as such should be able to release with any future minor release.

In any case, taking the latest discussion into account I think this change won't be a breaking one anymore and as such should be able to release with any future minor release.

Yes. That is correct. So we are not in a hurry with this.


Comic ID Input

The red text should be editable (by clicking it and typing).
This should work in a similar way to how MS Word handles choosing which pages to print:

For example:
60 would get comic ID 60
60, 70 would get comic ID 60 and 70
60-70 would get comic ID 60 through to 70 (60, 61, 62, 63...)
60, 65-68, 70 would get comic ID 60, 65, 66, 67, 68, and 70
There should also be leeway in terms of what input is considered valid. For example:
60 70 should be the same as 60, 70

Reserving this


Update eks-anywhere-packages versions

This versions.name value controls what eks-anywhere-packages images get copied over to the ECR image scanning account. In order to mirror prod images, we should copy over v0.x.xx-latest series. This version needs to match the latest release branch tag (i.e. https://github.com/aws/eks-anywhere-build-tooling/blob/release-0.14/projects/aws/eks-anywhere-packages/GIT_TAG).
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/lgtm


The problem at the start is not enough coins

Hello.
It's like there is a problem in a part of the code that causes the robot to continue working regardless of the value of ("auto_upgrade_start" , "auto_upgrade_min") variables until the coins run out.

Read this comment:
https://github.com/masterking32/MasterHamsterKombatBot/blob/1244b33af354ba7415593f1c82602acdcd2a030e/main.py#L51


Spark deprecate API rename the method to awaitTerminationOrTimeout

Current coverage is 53.01%

Merging #235 into master will not affect coverage as of 85c495b

@@            master    #235   diff @@
======================================
  Files           40      40
  Stmts         3914    3914
  Branches       360     360
  Methods
======================================
  Hit           2075    2075
  Partial        118     118
  Missed        1721    1721

Review entire Coverage Diff as of 85c495b

Powered by Codecov. Updated on successful CI builds.


1948 ic textfield focus overlapping

Summary of the changes
Change to the input label css to allow for space between the helper and focus when the focus is used.
Related issue
Issue 1948 https://github.com/mi6/ic-ui-kit/issues/1948
Checklist
General

[x] Changes to docs package checked and committed.
[x] All acceptance criteria reviewed and met.

Testing

[x] Relevant unit tests and visual regression tests added.
[x] Visual testing against Figma component specification completed.
[x] Playground stories in React Storybook up to date, with any prop changes and additions addressed.
[x] Compare performance of modified components against develop using Performance addon in React Storybook.

Accessibility

[x] Accessibility Insights FastPass performed.
[x] A11y unit test added and yields no issues.
[x] A11y plug-in on Storybook yields no issues.
[x] Manual screen reader testing performed using NVDA and VoiceOver.
[x] Manual keyboard testing for keyboard controls and logical focus order.
[x] Correct roles used and ARIA attributes used correctly where required.
[x] Logical heading structure is maintained, and the HTML elements used for headings can be changed to fit within the wider page structure.

Resize/zoom behaviour

[x] Page can be zoomed to 400% with no loss of content.
[x] Screen magnifier used with no issues.
[x] Text resized to 200% with no loss of content.
[x] Text spacing increased as per the WCAG 1.4.12 success criterion with no loss of content.

System modes

[x] Browser setting 'prefers reduced motion' tested. No animations or motion visible whilst this setting is on.
[x] Windows High Contrast mode tested with no loss of content.
[x] System light and dark mode tested with no loss of content.
[x] Browser support tested (Chrome, Safari, Firefox and Edge).

Testing content extremes

[x] Min/max content examples tested with no loss of content or overflow.
[x] All prop combinations work without issue.
[x] Tested for FOUC (Flash of Unstyled Content) in both SSR (Server-Side Rendering) and SSG (Static Site Generation) settings.
[x] Controlled and uncontrolled input components tested.
[x] Props/slots can be updated after initial render.

The baseline images need to be regenerated on the CI, there shouldn't be any need to increase the regression threshold for extra padding.
Also mirror @GCHQ-Developer-299 some components now have too large a gap, can you localise these changes to Search/Select and Text Field?


Make Events works

Events is an Omi's core feature, really weird if we couldn't make it works.

Sometimes the events don’t get added, sometimes the timing is wrong. I think we shouldn’t add event locally, instead we should add them through Google or Apple APIs, we can ask for user permission for this

- by @mdmohsin7
what: Fix all above issues, make sure Events work as expected.

why we shouldn't add them locally? man

We can, and currently we are doing that only. But some users have issues with permissions, for some the calendars don't show up and sometimes it takes time for the event to show up. Thought we could eliminate the issues if we can simply add events to the cloud and the respective calendar apps will sync the events automatically

But some users have issues with permissions, for some the calendars don't show up and sometimes it takes time for the event to show up

could we fix these issues?

could we fix these issues?

Yes can mostly do, will also include a better guide telling the user that it might take time

cool! do it pls sir


Update documentation on named bind parameters.

I wasn't able to find documentation of these in the godoc, so I added
it. Also, the README had out-of-date information. It said named bind
parameters were only supported for Select, but they are also supported
for Exec since 2015 (04b2c714).
The documentation for ExpandSlices was embedded in the DbMap type, which
made it hard to read on godoc - the entire documentation was in one
large pre block. I moved it up to the package level docs.

@jsha
Isn't this supported in Dbmap but not in Transaction?


test with ansible 2.6

Currently we test upstream in Jenkins with Ansible 2.4 and 2.5, as discussed in https://github.com/ceph/ceph-ansible/issues/2470
Please add testing for Ansible 2.6 as well as 2.4 and 2.5.
Ansible 2.4 is currently end-of-life, but it's the only one I know is well-tested with the RH Ceph Storage product.
Ansible 2.5 will go end-of-life after Ansible 2.7 is released (https://access.redhat.com/support/policy/updates/ansible-engine)
It would be great to use Ansible 2.6 in RH Ceph Storage 3.2.

as per #2908, it looks like master passes testing against ansible 2.6

That's great news, thanks @guits !

Currently we test upstream in Jenkins with Ansible 2.4 and 2.5, as discussed in #2470
Please add testing for Ansible 2.6 as well as 2.4 and 2.5.
Ansible 2.4 is currently end-of-life, but it's the only one I know is well-tested with the RH Ceph Storage product.
Ansible 2.5 will go end-of-life after Ansible 2.7 is released (https://access.redhat.com/support/policy/updates/ansible-engine)
It would be great to use Ansible 2.6 in RH Ceph Storage 3.2.

@ktdreyer we've been asked to test ceph-ansible stable-3.2 against ansible 2.6, from what I'm seeing today, correct me if I'm wrong but it seems RHCS 3.2 ships ansible 2.4 downstream?

RH Ceph Storage 3.2 should be compatible with Ansible 2.6 because that is what we document for our customers to use (rhbz#1613941)

@ktdreyer from what I can see, RHCS 3.2 ships with ansible 2.4 though

Right, unfortunately there have been several changes in the way that the Ansible team preferred to have layered products consume their builds:

Originally Ansible was shipped in the RHEL 7 Extras repository.
Later, the team pulled the build out of RHEL 7 Extras.
At that point we agreed that we should cross-ship Ansible in our own layered products, so we cross-shipped Ansible 2.4. That is the ansible build you see in the RH Ceph Storage 3 Yum repository today.
Later, the Ansible engineering team published their own repositories alongside RHEL. This is the preferred method today, and this is why we document that users should enable rhel-7-server-ansible-2.6-rpms on their administrator node.


Error in DataAugmentation

Hi,
you did a great job.
I am facing an two issues.
dataloader for val_loader works fine on my machine. But  train_loader, gives the error:
  File "DataAugmentation.py", line 15, in __call__     return cv2.resize(sample, shape, cv2.INTER_CUBIC) TypeError: dst is not a numpy array, neither a scalar
When I want to debug the code then train_loader enumerator stuck in VIDDataset.py and returns a very long message saying
[IPKernelApp] WARNING | WARNING: attempted to send message from fork

Never mind.
This error is due to opencv version.
Solved it by installing opencv-3.2.0