Add new 1.1-preview version for IoT Central

MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Add new 1.1-preview for IoT Central with following changes:

New organization API, support from Device, Jobs, API Tokens, Users, Device Group
New File Upload API
Fully DTDL v2 Adoption to align with 1.0

Changelog
Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?

[ ] new service onboarding
[x] new API version
[ ] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[ ] Other, please clarify

When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
If it's an update to existing version,  please select SDKs of specific language and CLIs that require refresh after swagger is published.

[ ] SDK of .NET (need service team to ensure code readiness)
[ ] SDK of Python
[ ] SDK of Java
[ ] SDK of Js
[ ] SDK of Go
[ ] PowerShell
[ ] CLI
[ ] Terraform
[ ] No, no need to refresh for updates in this PR

Contribution checklist:

[ ] I commit to follow the Breaking Change Policy of "no breaking changes"
[ ] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

[ ] Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

Adding new API(s)
Adding a new API version
[ ] Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
Adding a new service

[ ] Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

[ ] Removing API(s) in stable version
[ ] Removing properties in stable version
[ ] Removing API version(s) in stable version
[ ] Updating API in stable or public preview version with Breaking Change Validation errors
[ ] Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.

@jhendrixMSFT , our PR is ready for review, would you please take a look? Thanks!


removing duplicate link to writing daml menu

Let's give this a go @garyverhaegen-da I'm nervous about it but let's see what happens maybe.

ok, I don't understand the failure message

The secret to reading error messages is learning (through experience mostly) which parts you can ignore and which part (usually a tiny one) is actually useful. In this case the useful part of the error message is:
writing-daml.rst:document isn't included in any toctree

which makes sense to me given that this PR removes the only reference to writing-daml.


Add message url

Initial checklist

[x] I read the support docs
[x] I read the contributing guide
[x] I agree to follow the code of conduct
[x] I searched issues and couldn’t find anything (or linked relevant results below)
[x] If applicable, I’ve added docs and tests

Description of changes
This will be rendered by editors.

Codecov Report

Merging #9 (97d8ccc) into main (8bb886a) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main        #9   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            1         1
  Lines          115       117    +2
=========================================
+ Hits           115       117    +2

Impacted Files
Coverage Δ

index.js
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bb886a...97d8ccc. Read the comment docs.

Released!


large datasets break the graph view

the problem seems to be related to the large amount of total streams, even though only a small subset is shown (and is quantized to fewer data points)

that sounds ugly. can you check the javascript heap? is this in browser or in nw?

https://github.com/bnoordhuis/node-heapdump

and then there is this nugget o wisdom:
"Providers should not hang on to or even have references to scopes. Angular avoids regenerating scopes wherever possible but there are always times when Angular has to create the scopes from scratch. When this happens the provider's reference will be stale and will leak.Providers should not hang on to or even have references to scopes. Angular avoids regenerating scopes wherever possible but there are always times when Angular has to create the scopes from scratch. When this happens the provider's reference will be stale and will leak."
https://github.com/michaelwinser/node-webkit-angular

maybe this helps?
http://nexts.github.io/Clusterize.js/
(Although their demo ALWAYS crashes my mobile firefox...)

i'll check but the error currently seems to come from a rather trivial problem that is related to how the api endpoints work and also a bug in the loader on the page (loads too many streams that are not shown, stack size exceeded, no frame count reduction on the server... the lot!)

I think it would be a better strategy to generate those graphs once on the server (svg?) and then just show them on the page instead of trying to generate them there over and over again.
Currently it is so broken that people can not really use the site because it's impossible to get an overview of which channels are there …


Hover card text selection improvements

Feature request
Improve text selection usability/accessibility in the Hover Card:

When selecting text in the Hover Card, don't allow the selection to spill out of the Hover Card bounds.
Don't close Hover Card on mouse out if there's an active text selection; require an additional pointer down instead.

Examples in other libraries
VS Code hover card

Hey @vladmoroz and to anyone else who may be working on this.
It's quite simple to implement a lock when there is an active text selection, but disallowing the selection to spill out is difficult.

Using e.preventDefault() on any event other than 'selectstart' does not prevent the text from being highlighted (as such, removing the selection through the Selection API looks wacky because it appears then disappears)
The mouse location is not included with the 'selectstart' event object and even if its was, the event only fired when the selection starts
I got desperate so I tried adding an element similar to the one described by ::backdrop. I don't know why, but if you start highlighting in the hover card and slide your mouse outside the card... you can highlight text which is hidden beneath another element: https://codesandbox.io/s/gallant-cloud-xlkn57?file=/App.js

I looked into VS Code's hover cards, but it didn't help much.


PMID:29632066

increased histone H3-K4 trimethylation at subtelomeric heterochromatin during vegetative growth
increased histone H4-K16 acetylation at subtelomeric heterochromatin during vegetative growth
decreased histone H4-K20 dimethylation at subtelomeric heterochromatin during vegetative growth

increased histone H3-K4 trimethylation at subtelomeric heterochromatin during vegetative growth FYPO:0006751
increased histone H4-K16 acetylation at subtelomeric heterochromatin during vegetative growth FYPO:0006752
decreased histone H4-K20 dimethylation at subtelomeric heterochromatin during vegetative growth FYPO:0006753
edit file: 2dace453f9873877f85d41b8d6655197dbf97d81
release:<PHONE_NUMBER>838e46ccf3b36375ce3311604803ab


A request please

Can you please create a video ( a tutorial)  describing how a layman like me can implement it ?  The reason I am asking is - I tried to follow the doc but I was not sure , I was understanding why I was doing, what I was doing.
I hope you will take this into consideration.
Thanks a lot for everything.

Thanks for idea. but unfortunately I do not have any plan on it now. but I'll consider improve the docs


Fix wording in error raised when validating options

Fix wording in error raised when using a simulator, pec_mitigation is enabled but a coupling map has not been provided.

Summary
Details and comments
Fixes #

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 83.681%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
6210

Relevant Lines:
7421

💛  - Coveralls


Added correct merge object for Line

The Line facade was incorrectly attempting to merge an Account object instead of a Line object.

Thanks! Please release to packagist soon

On 1/08/2017, at 2:58 PM, Hao Lu<EMAIL_ADDRESS>wrote:
Merged #53.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.


ZDF-HbbTV Videos are shown with dimensions 0px x 0px

HybridTvViewer : 0.5.0
Browser: Firefox 58.0.2 (64-bit)
OS: Lubuntu (64bit) 16.04
When I try to watch a video of the ZDF mediathek http://hbbtv.zdf.de/zdfm3/index.php, I can hear the audio but I see no video.
Checking the page information shows the dimensions 0px x 0px.
When I open the video link in another tab the dimensions are NaNpx x NaNpx and I can see the video.
Please see attached screen shot!
Thanks,
Thomas

Forgot to mention after a minute I get an error message, that the video could not be shown.

I have the same issue with all Pro7 & affiliate mediatheken. The video runs invisibly in a 0x0 pixel object.


[Feature Request] Migrate Update by query, delete by query, reindex to use PiT instead of scroll

Is your feature request related to a problem? Please describe
Today, update by query, delete by query and reindex uses scroll API for searching.
Describe the solution you'd like
We should move these APIs to using Point in Time  instead of scroll. It is now the preferred pagination for OpenSearch.
Related component
Search
Describe alternatives you've considered
No response
Additional context
No response

[Triage - attendees 1 2 3 4 5]
@shwetathareja Thanks for creating this issue, this would be a good improvement.  Note; I've tagged this as breaking since functionality between scroll and PIT based systems might be different.  We should evaluate these scenarios before considering backporting.


vector: 0.20.0 -> 0.20.1

Description of changes
minor update nothing worthy of note, just a couple of bug fixes https://vector.dev/releases/0.20.1/
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

I'm going to merge this as I don't think there will be huge interest on it.
as usual, happy to take care of any feedback later should there be any.


Mock server example does not work with shutdown

When using serve_with_incoming_shutdown the mock example client fails to connect.

I have also experienced this issue with serve_with_shutdown as well.


Fix window resize

Default config.ini should be used to reproduce.

https://github.com/onovytskyi/MorningCoffeeEngine/commit/04b6b35d41e520e35606a4e319507fdc04e44d4a


Update the README to create a network bridge for GCE deployment

Signed-off-by: Wayne Zhang<EMAIL_ADDRESS>The current README is outdated.  Updated it to use container network bridge

I just went through the GCE deployment (with the existing instructions) and it worked. Is the old way deprecated or expected not to work?

It really depends on which version of GCE your were using.  Mine is Ubunto 16.4.  It doesn't work.
I guess the --link flag is deprecated.  You have to create a network bridge.


could someone help me

npm install
npm WARN deprecated<EMAIL_ADDRESS>this library is no longer supported
npm WARN deprecated<EMAIL_ADDRESS>Use your platform's native atob() and btoa() methods instead
npm WARN deprecated<EMAIL_ADDRESS>Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
npm WARN deprecated<EMAIL_ADDRESS>request has been deprecated, see https://github.com/request/request/issues/3142
npm WARN deprecated<EMAIL_ADDRESS>Use your platform's native DOMException instead
npm WARN deprecated<EMAIL_ADDRESS>Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.
npm WARN deprecated<EMAIL_ADDRESS>Critical security vulnerability fixed in v0.21.1. For more information, see https://github.com/axios/axios/pull/3410
npm WARN deprecated<EMAIL_ADDRESS>Package no longer supported.  [Canvacord] Rebuilding forcefully as --force was supplied!
npm ERR! [Canvacord] Downloading assets...
npm ERR! [Canvacord] Successfully downloaded metadata!
npm ERR! [Canvacord] Downloading images...
npm ERR! [Canvacord] Successfully downloaded BOTBADGE.png
npm ERR! [Canvacord] Successfully downloaded AFFECT.png
npm ERR! [Canvacord] Successfully downloaded BEAUTIFUL.png
npm ERR! [Canvacord] Successfully downloaded TRASH.png
npm ERR! [Canvacord] Successfully downloaded BATSLAP.png
npm ERR! [Canvacord] Successfully downloaded SNOWFLAKE.png
npm ERR! [Canvacord] Successfully downloaded DISCORD.png
npm ERR! [Canvacord] Successfully downloaded GAY.png
npm ERR! [Canvacord] Successfully downloaded CLYDE.png
npm ERR! [Canvacord] Successfully downloaded IDLE.png
npm ERR! [Canvacord] Successfully downloaded CHANGEMYMIND.png
npm ERR! [Canvacord] Successfully downloaded YOUTUBE.png
npm ERR! [Canvacord] Successfully downloaded OHNO.png
npm ERR! [Canvacord] Successfully downloaded DELETE.png
npm ERR! [Canvacord] Successfully downloaded IMPOSTERWITH.png
npm ERR! [Canvacord] Successfully downloaded WASTED.png
npm ERR! [Canvacord] Successfully downloaded RIP.png
npm ERR! [Canvacord] Successfully downloaded JAIL.png
npm ERR! [Canvacord] Successfully downloaded DND.png
npm ERR! [Canvacord] Successfully downloaded CAPTCHA.png
npm ERR! [Canvacord] Successfully downloaded JOKEOVERHEAD.png
npm ERR! [Canvacord] Successfully downloaded TRIGGERED.png
npm ERR! [Canvacord] Successfully downloaded KISS.png
npm ERR! [Canvacord] Successfully downloaded TOBECONTINUED.png
npm ERR! [Canvacord] Successfully downloaded SHIT.png
npm ERR! [Canvacord] Successfully downloaded KO.png
npm ERR! [Canvacord] Successfully downloaded HITLER.png
npm ERR! [Canvacord] Successfully downloaded PUNCH.png
npm ERR! [Canvacord] Successfully downloaded KICK.png
npm ERR! [Canvacord] Successfully downloaded DISTRACTED.png
npm ERR! [Canvacord] Successfully downloaded PHUB.png
npm ERR! [Canvacord] Successfully downloaded SPANK.png
npm ERR! C:\Users\sixpa\Desktop\ALL-IN-ONE-Discord-Bot--main\node_modules\canvacord\node_modules\node-fetch\lib\index.js:1491
npm ERR!                        reject(new FetchError(request to ${request.url} failed, reason: ${err.message}, 'system', err));
npm ERR!                               ^
npm ERR! FetchError: request to https://raw.githubusercontent.com/DevAndromeda/canvacord/assets/data/images/ONLINE.png failed, reason: connect ETIMEDOUT <IP_ADDRESS>:443
npm ERR!     at ClientRequest. (C:\Users\sixpa\Desktop\ALL-IN-ONE-Discord-Bot--main\node_modules\canvacord\node_modules\node-fetch\lib\index.js:1491:11)
npm ERR!     at ClientRequest.emit (node:events:517:28)
npm ERR!     at TLSSocket.socketErrorListener (node:_http_client:501:9)
npm ERR!     at TLSSocket.emit (node:events:517:28)
npm ERR!     at emitErrorNT (node:internal/streams/destroy:151:8)
npm ERR!     at emitErrorCloseNT (node:internal/streams/destroy:116:3)
npm ERR!     at process.processTicksAndRejections (node:internal/process/task_queues:82:21) {
npm ERR!   type: 'system',
npm ERR!   errno: 'ETIMEDOUT',
npm ERR!   code: 'ETIMEDOUT'
npm ERR! }
npm ERR!
npm ERR! Node.js v18.19.1

remove node_modules folder and install packages with node v18.x + use pnpm


Doesn't seem to work with spectacle-scripts

spectacle-scripts seems to be the new way of starting a Spectacle presentation now. This theme doesn't seem to work, I just get the following error related to progress.bar:

Hmm my initial assessment was wrong. Seems to be an issue with progress bar styles. If I disable the progress bar in my presentation (<Deck ... theme={theme} progress="none">), everything seems to work.

Well, now I just feel silly. There aren't any progress styles included, therefore they're undefined as the error shows above. I'll probably submit a PR to add. Sorry about the bad issue report!

Closing this, since it's resolved and there will be some styles when #9 is merged.


Board Reports: Markup language showing in search results

For some search results, what looks like markup language is showing up in the subject. Could you please look into this? Below are two examples.

It appears this was resolved ... I tried the same searches above and returned a clean list of results. @reginafcompton , can you confirm?

Yes @shrayshray - achieved by not indexing the full_text field (i.e., the field with the RTF and HTML)


Fix bundle signing (properly) & other build/CI improvements

This fixes the CI and my Cmake skills

I just noticed that sandboxing + the CLI options for input files don't work well together. I'll search a bit to see whether there is a proper way of solving this, but that's a bug related to this pull request at the moment I suppose.

@jelmervdl they can still use stdin/stdout. We can  write this in the limitation and if anyone wants files, they can do it through translatelocally-bin?

I've added a hint to the output when an error occurs that could have been caused by the sandbox. I've also mentioned it in the readme.
I didn't document how to compile on macOS yet in README because I couldn't easily figure out how to install Intel MKL? Has it been renamed or something? It should probably also note that if you want to make a version that can be shared, you should use Qt's own distribution, and not homebrew. You still need homebrew to get libarchive though 🤔

On MacOs we don't use MKL. We use apple accelerate framework by default when we detect MacOS, as it is installed practically everywhere.


Mutation of the containers during iteration is not handled as per the spec

Please refer to https://htmlpreview.github.io/?https://raw.githubusercontent.com/ballerina-platform/ballerina-spec/v2019R3/lang/spec.html#built-in_abstract_object_types under Iterator.

Mutation of the container during iteration is handled as follows. At any point during the execution of a program, a container has a set of valid keys; these are keys for which the container has a member; a key has type int for lists and type string for maps. A call to next() must panic if the set of valid keys is not the same as the set of valid keys when the iterator was created, with the following exception: it is allowed to remove a key if the member for that key has already been returned by next(). The value that a container associates with a particular key may change during the iteration; next() must return the value associated with the key at the point when next() is called.

Spec has been changed in https://github.com/ballerina-platform/ballerina-spec/issues/485 to the following:

Mutation of a structured value during iteration is handled as follows. A call to next() must panic if there has been any mutation to the structured value since the iterator was created other than the following:

removing a member of the structured value that a preceding call to the iterator has already returned;
changing the member associated with an existing key.

In the latter case, next() must return the value associated with the key at the point when next() is called.

This formulation is intended work with tables as well as mappings and arrays.


Hi, When will clone be supported?

let tlsStream = connector.connect("www.google.com", tcpStream).await?
tlsStream.clone()??

rustls::ClientSession cannot be cloned, likely because doing so makes it insecure.  You might use 0-RTT tricks to open a second stream cheaply, not sure.

Dup of #18. Please use the discord chat or similar for inquiries.


Connect taking too long

After scanning some devices and calling the connect method, it takes more than 1 minute sometimes, and sometimes it never connects. Also, something that could be related, the state stream doesn't look correct: it's either "connected" or "disconnected". I'm never able to see the "connecting" or "disconnecting" state, which makes it harder to know if there is a connection establishment in progress, or something happened and it will not connect.
Sample repository: https://github.com/HugoSart/flutter_blue_hangs

Same situation for me.
Sometimes it connects in 5 secs and sometimes it connects in more than 5 attempts.
this is my connect method
  Future<void> connectTimeout(ScanResult result) async {
    await result.device
        .connect(autoConnect: true)
        .timeout(Duration(seconds: 5), onTimeout: () {
      log('${result.device.name} connecting timeout');
      result.device.disconnect();
        }).then((data) async {
          //TODO no lo puedo hacer acá porque se repite mucho
      await for (BluetoothDeviceState r in result.device.state) {
        log('${result.device.name} state: ${r}');
        if (r == BluetoothDeviceState.connected) {
          checkConnectedImei(result.device);
        }
      }

    }).catchError((e) {
      log(' ${result.device.name}  connected state: ${result.device.state} $e');
    }).whenComplete(()  {});
  }

In some cases, you can solve it just by setting [autoConnect: false]. I don't know why it works, but it works pretty well.
https://github.com/pauldemarco/flutter_blue/issues/106#issuecomment-467697537

In some cases, you can solve it just by setting [autoConnect: false]. I don't know why it works, but it works pretty well.
#106 (comment)

Setting autoConnect to false when the Platform was Android resolved my issue for a specific BLE device that would connect with iOS but not Android


[Accessibility]A11y_VSCode_VSCodeSetUpWizard_Screenreader: NVDA is not reading the "Next" and "Cancel" buttons as buttons.

Environment Details:
VSCode Version : 1.24.0
OS Version: Win10
OS Version : HighSierra10.13.5
Additional Details:
ScreenReader: NVDA
NVDA Version: NVDA2018.2
Repro Steps:
1)Launch VS Code while NVDA is ON.
2)Launch Visual Studio code desktop application.
3)With the help of Tab just observe the NVDA Readings.
Actual:
NVDA is not reading the "Next" and "Cancel" as buttons.
Expected:
NVDA should read the appropriate role for all the controls on the screen.
Recommendations:
Refer below link which is repository of bug fixes code snippets:
[https://microsoft.sharepoint.com/teams/msenable/mas/pages/browse-fixes.aspx
](url)
User Impact:
User will not come to know that there are buttons present on the screen.
Attachment for Reference:
[Accessibility]A11y_VSCode_VSCodeSetUpWizard_Screenreader.pptx
Does this issue occur when all extensions are disabled?: Yes

@AccessibilityTestingTeam-TCS This needs to go into https://github.com/jrsoftware/issrc

This issue not reproducing in new version VScode 1.24.1.


Unregister null?

It is just a cosmetic isssue.
In case I try to unregister an app already uninstalled it cannot get the "display name" and show a message with the title "Unregister null?".
In these cases I think it is better to display the internal name "com...." instead of null.

Should be fixed as of ef9e9b0. by the way: this should not happen very often because microG will now automatically unregister from push notifications once an app is uninstalled (this is the same behavior the original implementation has)

I know but it happens when you update from an old version the have it already :)


catkin_make fail

/opt/ros/melodic/include/class_loader/meta_object.hpp: In instantiation of ‘B* class_loader::impl::MetaObject<C, B>::create() const [with C = local_3d_planner::Local3DPlannerROS; B = nav_core::BaseLocalPlanner]’:
/home/klek/catkin_ws/src/indires_navigation/local_3d_planner/src/local_3d_planner_ros.cpp:284:2:   required from here
/opt/ros/melodic/include/class_loader/meta_object.hpp:196:12: error: invalid new-expression of abstract class type ‘local_3d_planner::Local3DPlannerROS’
return new C;
^~~~~
In file included from /home/klek/catkin_ws/src/indires_navigation/local_3d_planner/src/local_3d_planner_ros.cpp:9:0:
/home/klek/catkin_ws/src/indires_navigation/local_3d_planner/include/local_3d_planner/local_3d_planner_ros.h:47:9: note:   because the following virtual functions are pure within ‘local_3d_planner::Local3DPlannerROS’:
class Local3DPlannerROS : public nav_core::BaseLocalPlanner {
^~~~~~~~~~~~~~~~~
In file included from /home/klek/catkin_ws/src/indires_navigation/local_3d_planner/include/local_3d_planner/local_3d_planner_ros.h:32:0,
from /home/klek/catkin_ws/src/indires_navigation/local_3d_planner/src/local_3d_planner_ros.cpp:9:
/opt/ros/melodic/include/nav_core/base_local_planner.h:78:20: note: 	virtual void nav_core::BaseLocalPlanner::initialize(std::cxx11::string, tf2_ros::Buffer*, costmap_2d::Costmap2DROS*)
virtual void initialize(std::string name, tf2_ros::Buffer* tf, costmap_2d::Costmap2DROS* costmap_ros) = 0;
^~~~~~~~~~
indires_navigation/local_3d_planner/CMakeFiles/local_3d_planner_ros.dir/build.make:86: recipe for target 'indires_navigation/local_3d_planner/CMakeFiles/local_3d_planner_ros.dir/src/local_3d_planner_ros.cpp.o' failed
make[2]: *** [indires_navigation/local_3d_planner/CMakeFiles/local_3d_planner_ros.dir/src/local_3d_planner_ros.cpp.o] Error 1
CMakeFiles/Makefile2:8931: recipe for target 'indires_navigation/local_3d_planner/CMakeFiles/local_3d_planner_ros.dir/all' failed
make[1]: *** [indires_navigation/local_3d_planner/CMakeFiles/local_3d_planner_ros.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
/home/klek/catkin_ws/src/indires_navigation/adapted_move_base/src/move_base.cpp: In constructor ‘move_base::MoveBase::MoveBase(tf::TransformListener*)’:
/home/klek/catkin_ws/src/indires_navigation/adapted_move_base/src/move_base.cpp:150:87: error: no matching function for call to ‘nav_core::BaseLocalPlanner::initialize(std::cxx11::string, tf::TransformListener*&, costmap_2d::Costmap2DROS*&)’
tc->initialize(blp_loader.getName(local_planner), tf, controller_costmap_ros);
^
In file included from /home/klek/catkin_ws/src/indires_navigation/adapted_move_base/include/adapted_move_base/move_base.h:56:0,
from /home/klek/catkin_ws/src/indires_navigation/adapted_move_base/src/move_base.cpp:44:
/opt/ros/melodic/include/nav_core/base_local_planner.h:78:20: note: candidate: virtual void nav_core::BaseLocalPlanner::initialize(std::cxx11::string, tf2_ros::Buffer*, costmap_2d::Costmap2DROS*)
virtual void initialize(std::string name, tf2_ros::Buffer* tf, costmap_2d::Costmap2DROS* costmap_ros) = 0;
^~~~~~~~~~
/opt/ros/melodic/include/nav_core/base_local_planner.h:78:20: note:   no known conversion for argument 2 from ‘tf::TransformListener*’ to ‘tf2_ros::Buffer*’
/home/klek/catkin_ws/src/indires_navigation/adapted_move_base/src/move_base.cpp: In member function ‘void move_base::MoveBase::reconfigureCB(move_base::MoveBaseConfig&, uint32_t)’:
/home/klek/catkin_ws/src/indires_navigation/adapted_move_base/src/move_base.cpp:276:101: error: no matching function for call to ‘nav_core::BaseLocalPlanner::initialize(std::cxx11::string, tf::TransformListener*&, costmap_2d::Costmap2DROS*&)’
tc->initialize(blp_loader.getName(config.base_local_planner), tf, controller_costmap_ros);
^
In file included from /home/klek/catkin_ws/src/indires_navigation/adapted_move_base/include/adapted_move_base/move_base.h:56:0,
from /home/klek/catkin_ws/src/indires_navigation/adapted_move_base/src/move_base.cpp:44:
/opt/ros/melodic/include/nav_core/base_local_planner.h:78:20: note: candidate: virtual void nav_core::BaseLocalPlanner::initialize(std::cxx11::string, tf2_ros::Buffer*, costmap_2d::Costmap2DROS*)
virtual void initialize(std::string name, tf2_ros::Buffer* tf, costmap_2d::Costmap2DROS* costmap_ros) = 0;
^~~~~~~~~~
/opt/ros/melodic/include/nav_core/base_local_planner.h:78:20: note:   no known conversion for argument 2 from ‘tf::TransformListener*’ to ‘tf2_ros::Buffer*’
/home/klek/catkin_ws/src/indires_navigation/adapted_move_base/src/move_base.cpp: In member function ‘bool move_base::MoveBase::loadRecoveryBehaviors(ros::NodeHandle)’:
/home/klek/catkin_ws/src/indires_navigation/adapted_move_base/src/move_base.cpp:1178:110: error: no matching function for call to ‘nav_core::RecoveryBehavior::initialize(XmlRpc::XmlRpcValue&, tf::TransformListener*&, costmap_2d::Costmap2DROS*&, costmap_2d::Costmap2DROS*&)’
behavior->initialize(behavior_list[i]["name"], tf, planner_costmap_ros, controller_costmap_ros_);
^
In file included from /home/klek/catkin_ws/src/indires_navigation/adapted_move_base/include/adapted_move_base/move_base.h:58:0,
from /home/klek/catkin_ws/src/indires_navigation/adapted_move_base/src/move_base.cpp:44:
/opt/ros/melodic/include/nav_core/recovery_behavior.h:56:20: note: candidate: virtual void nav_core::RecoveryBehavior::initialize(std::cxx11::string, tf2_ros::Buffer*, costmap_2d::Costmap2DROS*, costmap_2d::Costmap2DROS*)
virtual void initialize(std::string name, tf2_ros::Buffer* tf, costmap_2d::Costmap2DROS* global_costmap, costmap_2d::Costmap2DROS* local_costmap) = 0;
^~~~~~~~~~
/opt/ros/melodic/include/nav_core/recovery_behavior.h:56:20: note:   no known conversion for argument 2 from ‘tf::TransformListener*’ to ‘tf2_ros::Buffer*’
/home/klek/catkin_ws/src/indires_navigation/adapted_move_base/src/move_base.cpp: In member function ‘void move_base::MoveBase::loadDefaultRecoveryBehaviors()’:
/home/klek/catkin_ws/src/indires_navigation/adapted_move_base/src/move_base.cpp:1214:102: error: no matching function for call to ‘nav_core::RecoveryBehavior::initialize(const char [19], tf::TransformListener*&, costmap_2d::Costmap2DROS*&, costmap_2d::Costmap2DROS*&)’
cons_clear->initialize("conservative_reset", tf, planner_costmap_ros, controller_costmap_ros_);
^
In file included from /home/klek/catkin_ws/src/indires_navigation/adapted_move_base/include/adapted_move_base/move_base.h:58:0,
from /home/klek/catkin_ws/src/indires_navigation/adapted_move_base/src/move_base.cpp:44:
/opt/ros/melodic/include/nav_core/recovery_behavior.h:56:20: note: candidate: virtual void nav_core::RecoveryBehavior::initialize(std::cxx11::string, tf2_ros::Buffer*, costmap_2d::Costmap2DROS*, costmap_2d::Costmap2DROS*)
virtual void initialize(std::string name, tf2_ros::Buffer* tf, costmap_2d::Costmap2DROS* global_costmap, costmap_2d::Costmap2DROS* local_costmap) = 0;
^~~~~~~~~~
/opt/ros/melodic/include/nav_core/recovery_behavior.h:56:20: note:   no known conversion for argument 2 from ‘tf::TransformListener*’ to ‘tf2_ros::Buffer*’
/home/klek/catkin_ws/src/indires_navigation/adapted_move_base/src/move_base.cpp:1221:97: error: no matching function for call to ‘nav_core::RecoveryBehavior::initialize(const char [16], tf::TransformListener*&, costmap_2d::Costmap2DROS*&, costmap_2d::Costmap2DROS*&)’
rotate->initialize("rotate_recovery", tf, planner_costmap_ros, controller_costmap_ros_);
^
In file included from /home/klek/catkin_ws/src/indires_navigation/adapted_move_base/include/adapted_move_base/move_base.h:58:0,
from /home/klek/catkin_ws/src/indires_navigation/adapted_move_base/src/move_base.cpp:44:
/opt/ros/melodic/include/nav_core/recovery_behavior.h:56:20: note: candidate: virtual void nav_core::RecoveryBehavior::initialize(std::cxx11::string, tf2_ros::Buffer*, costmap_2d::Costmap2DROS*, costmap_2d::Costmap2DROS*)
virtual void initialize(std::string name, tf2_ros::Buffer* tf, costmap_2d::Costmap2DROS* global_costmap, costmap_2d::Costmap2DROS* local_costmap) = 0;
^~~~~~~~~~
/opt/ros/melodic/include/nav_core/recovery_behavior.h:56:20: note:   no known conversion for argument 2 from ‘tf::TransformListener*’ to ‘tf2_ros::Buffer*’
/home/klek/catkin_ws/src/indires_navigation/adapted_move_base/src/move_base.cpp:1228:99: error: no matching function for call to ‘nav_core::RecoveryBehavior::initialize(const char [17], tf::TransformListener*&, costmap_2d::Costmap2DROS*&, costmap_2d::Costmap2DROS*&)’
ags_clear->initialize("aggressive_reset", tf, planner_costmap_ros, controller_costmap_ros_);
^
In file included from /home/klek/catkin_ws/src/indires_navigation/adapted_move_base/include/adapted_move_base/move_base.h:58:0,
from /home/klek/catkin_ws/src/indires_navigation/adapted_move_base/src/move_base.cpp:44:
/opt/ros/melodic/include/nav_core/recovery_behavior.h:56:20: note: candidate: virtual void nav_core::RecoveryBehavior::initialize(std::__cxx11::string, tf2_ros::Buffer*, costmap_2d::Costmap2DROS*, costmap_2d::Costmap2DROS*)
virtual void initialize(std::string name, tf2_ros::Buffer* tf, costmap_2d::Costmap2DROS* global_costmap, costmap_2d::Costmap2DROS* local_costmap) = 0;
^~~~~~~~~~
/opt/ros/melodic/include/nav_core/recovery_behavior.h:56:20: note:   no known conversion for argument 2 from ‘tf::TransformListener*’ to ‘tf2_ros::Buffer*’
indires_navigation/adapted_move_base/CMakeFiles/adapted_move_base.dir/build.make:62: recipe for target 'indires_navigation/adapted_move_base/CMakeFiles/adapted_move_base.dir/src/move_base.cpp.o' failed
make[2]: *** [indires_navigation/adapted_move_base/CMakeFiles/adapted_move_base.dir/src/move_base.cpp.o] Error 1
CMakeFiles/Makefile2:9845: recipe for target 'indires_navigation/adapted_move_base/CMakeFiles/adapted_move_base.dir/all' failed
Unable to catkin_make and I'm not clear on classes

Hi Klek,
The package has been tested under ROS Kinectic.
It seems that the BaseLocalPlugin of ROS Melodic is using tf2 while I am
using tf.  That's the problem.
You should uninstall the nav_core package of ROS melodic and download and
install the nave_core package used in the Kinetic distribution.
Best regards,
Noé
El mié., 15 abr. 2020 a las 9:52, klek17<EMAIL_ADDRESS>escribió:

/opt/ros/melodic/include/class_loader/meta_object.hpp: In instantiation of
‘B* class_loader::impl::MetaObject<C, B>::create() const [with C =
local_3d_planner::Local3DPlannerROS; B = nav_core::BaseLocalPlanner]’:
/home/klek/catkin_ws/src/indires_navigation/local_3d_planner/src/local_3d_planner_ros.cpp:284:2:
required from here
/opt/ros/melodic/include/class_loader/meta_object.hpp:196:12: error:
invalid new-expression of abstract class type
‘local_3d_planner::Local3DPlannerROS’
return new C;
^~~~~
In file included from
/home/klek/catkin_ws/src/indires_navigation/local_3d_planner/src/local_3d_planner_ros.cpp:9:0:
/home/klek/catkin_ws/src/indires_navigation/local_3d_planner/include/local_3d_planner/local_3d_planner_ros.h:47:9:
note: because the following virtual functions are pure within
‘local_3d_planner::Local3DPlannerROS’:
class Local3DPlannerROS : public nav_core::BaseLocalPlanner {
^~~~~~~~~~~~~~~~~
In file included from
/home/klek/catkin_ws/src/indires_navigation/local_3d_planner/include/local_3d_planner/local_3d_planner_ros.h:32:0,
from
/home/klek/catkin_ws/src/indires_navigation/local_3d_planner/src/local_3d_planner_ros.cpp:9:
/opt/ros/melodic/include/nav_core/base_local_planner.h:78:20: note:
virtual void nav_core::BaseLocalPlanner::initialize(std::
cxx11::string, tf2_ros::Buffer, costmap_2d::Costmap2DROS*) virtual void
initialize(std::string name, tf2_ros::Buffer* tf, costmap_2d::Costmap2DROS*
costmap_ros) = 0; ^~~~~~~~~~
indires_navigation/local_3d_planner/CMakeFiles/local_3d_planner_ros.dir/build.make:86:
recipe for target
'indires_navigation/local_3d_planner/CMakeFiles/local_3d_planner_ros.dir/src/local_3d_planner_ros.cpp.o'
failed make[2]: ***
[indires_navigation/local_3d_planner/CMakeFiles/local_3d_planner_ros.dir/src/local_3d_planner_ros.cpp.o]
Error 1 CMakeFiles/Makefile2:8931: recipe for target
'indires_navigation/local_3d_planner/CMakeFiles/local_3d_planner_ros.dir/all'
failed make[1]: ***
[indires_navigation/local_3d_planner/CMakeFiles/local_3d_planner_ros.dir/all]
Error 2 make[1]: *** Waiting for unfinished jobs....
/home/klek/catkin_ws/src/indires_navigation/adapted_move_base/src/move_base.cpp:
In constructor ‘move_base::MoveBase::MoveBase(tf::TransformListener*)’:
/home/klek/catkin_ws/src/indires_navigation/adapted_move_base/src/move_base.cpp:150:87:
error: no matching function for call to
‘nav_core::BaseLocalPlanner::initialize(std::cxx11::string,
tf::TransformListener*&, costmap_2d::Costmap2DROS*&)’
tc->initialize(blp_loader.getName(local_planner), tf,
controller_costmap_ros*);
^
In file included from
/home/klek/catkin_ws/src/indires_navigation/adapted_move_base/include/adapted_move_base/move_base.h:56:0,
from
/home/klek/catkin_ws/src/indires_navigation/adapted_move_base/src/move_base.cpp:44:
/opt/ros/melodic/include/nav_core/base_local_planner.h:78:20: note:
candidate: virtual void nav_core::BaseLocalPlanner::initialize(std::
cxx11::string, tf2_ros::Buffer, costmap_2d::Costmap2DROS*) virtual void
initialize(std::string name, tf2_ros::Buffer* tf, costmap_2d::Costmap2DROS*
costmap_ros) = 0; ^~~~~~~~~~
/opt/ros/melodic/include/nav_core/base_local_planner.h:78:20: note: no
known conversion for argument 2 from ‘tf::TransformListener*’ to
‘tf2_ros::Buffer*’
/home/klek/catkin_ws/src/indires_navigation/adapted_move_base/src/move_base.cpp:
In member function ‘void
move_base::MoveBase::reconfigureCB(move_base::MoveBaseConfig&, uint32_t)’:
/home/klek/catkin_ws/src/indires_navigation/adapted_move_base/src/move_base.cpp:276:101:
error: no matching function for call to
‘nav_core::BaseLocalPlanner::initialize(std::cxx11::string,
tf::TransformListener*&, costmap_2d::Costmap2DROS*&)’
tc->initialize(blp_loader.getName(config.base_local_planner), tf,
controller_costmap_ros*);
^
In file included from
/home/klek/catkin_ws/src/indires_navigation/adapted_move_base/include/adapted_move_base/move_base.h:56:0,
from
/home/klek/catkin_ws/src/indires_navigation/adapted_move_base/src/move_base.cpp:44:
/opt/ros/melodic/include/nav_core/base_local_planner.h:78:20: note:
candidate: virtual void nav_core::BaseLocalPlanner::initialize(std::
cxx11::string, tf2_ros::Buffer, costmap_2d::Costmap2DROS*) virtual void
initialize(std::string name, tf2_ros::Buffer* tf, costmap_2d::Costmap2DROS*
costmap_ros) = 0; ^~~~~~~~~~
/opt/ros/melodic/include/nav_core/base_local_planner.h:78:20: note: no
known conversion for argument 2 from ‘tf::TransformListener*’ to
‘tf2_ros::Buffer*’
/home/klek/catkin_ws/src/indires_navigation/adapted_move_base/src/move_base.cpp:
In member function ‘bool
move_base::MoveBase::loadRecoveryBehaviors(ros::NodeHandle)’:
/home/klek/catkin_ws/src/indires_navigation/adapted_move_base/src/move_base.cpp:1178:110:
error: no matching function for call to
‘nav_core::RecoveryBehavior::initialize(XmlRpc::XmlRpcValue&,
tf::TransformListener*&, costmap_2d::Costmap2DROS*&,
costmap_2d::Costmap2DROS*&)’ behavior->initialize(behavior_list[i]["name"],
tf, planner_costmap_ros*, controller_costmap_ros_);
^
In file included from
/home/klek/catkin_ws/src/indires_navigation/adapted_move_base/include/adapted_move_base/move_base.h:58:0,
from
/home/klek/catkin_ws/src/indires_navigation/adapted_move_base/src/move_base.cpp:44:
/opt/ros/melodic/include/nav_core/recovery_behavior.h:56:20: note:
candidate: virtual void nav_core::RecoveryBehavior::initialize(std::
cxx11::string, tf2_ros::Buffer, costmap_2d::Costmap2DROS*,
costmap_2d::Costmap2DROS*) virtual void initialize(std::string name,
tf2_ros::Buffer* tf, costmap_2d::Costmap2DROS* global_costmap,
costmap_2d::Costmap2DROS* local_costmap) = 0; ^~~~~~~~~~
/opt/ros/melodic/include/nav_core/recovery_behavior.h:56:20: note: no known
conversion for argument 2 from ‘tf::TransformListener*’ to
‘tf2_ros::Buffer*’
/home/klek/catkin_ws/src/indires_navigation/adapted_move_base/src/move_base.cpp:
In member function ‘void
move_base::MoveBase::loadDefaultRecoveryBehaviors()’:
/home/klek/catkin_ws/src/indires_navigation/adapted_move_base/src/move_base.cpp:1214:102:
error: no matching function for call to
‘nav_core::RecoveryBehavior::initialize(const char [19],
tf::TransformListener*&, costmap_2d::Costmap2DROS*&,
costmap_2d::Costmap2DROS*&)’ cons_clear->initialize("conservative_reset",
tf, planner_costmap_ros*, controller_costmap_ros_);
^
In file included from
/home/klek/catkin_ws/src/indires_navigation/adapted_move_base/include/adapted_move_base/move_base.h:58:0,
from
/home/klek/catkin_ws/src/indires_navigation/adapted_move_base/src/move_base.cpp:44:
/opt/ros/melodic/include/nav_core/recovery_behavior.h:56:20: note:
candidate: virtual void nav_core::RecoveryBehavior::initialize(std::
cxx11::string, tf2_ros::Buffer, costmap_2d::Costmap2DROS*,
costmap_2d::Costmap2DROS*) virtual void initialize(std::string name,
tf2_ros::Buffer* tf, costmap_2d::Costmap2DROS* global_costmap,
costmap_2d::Costmap2DROS* local_costmap) = 0; ^~~~~~~~~~
/opt/ros/melodic/include/nav_core/recovery_behavior.h:56:20: note: no known
conversion for argument 2 from ‘tf::TransformListener*’ to
‘tf2_ros::Buffer*’
/home/klek/catkin_ws/src/indires_navigation/adapted_move_base/src/move_base.cpp:1221:97:
error: no matching function for call to
‘nav_core::RecoveryBehavior::initialize(const char [16],
tf::TransformListener*&, costmap_2d::Costmap2DROS*&,
costmap_2d::Costmap2DROS*&)’ rotate->initialize("rotate_recovery", tf,
planner_costmap_ros*, controller_costmap_ros_);
^
In file included from
/home/klek/catkin_ws/src/indires_navigation/adapted_move_base/include/adapted_move_base/move_base.h:58:0,
from
/home/klek/catkin_ws/src/indires_navigation/adapted_move_base/src/move_base.cpp:44:
/opt/ros/melodic/include/nav_core/recovery_behavior.h:56:20: note:
candidate: virtual void nav_core::RecoveryBehavior::initialize(std::
cxx11::string, tf2_ros::Buffer, costmap_2d::Costmap2DROS*,
costmap_2d::Costmap2DROS*) virtual void initialize(std::string name,
tf2_ros::Buffer* tf, costmap_2d::Costmap2DROS* global_costmap,
costmap_2d::Costmap2DROS* local_costmap) = 0; ^~~~~~~~~~
/opt/ros/melodic/include/nav_core/recovery_behavior.h:56:20: note: no known
conversion for argument 2 from ‘tf::TransformListener*’ to
‘tf2_ros::Buffer*’
/home/klek/catkin_ws/src/indires_navigation/adapted_move_base/src/move_base.cpp:1228:99:
error: no matching function for call to
‘nav_core::RecoveryBehavior::initialize(const char [17],
tf::TransformListener*&, costmap_2d::Costmap2DROS*&,
costmap_2d::Costmap2DROS*&)’ ags_clear->initialize("aggressive_reset", tf,
planner_costmap_ros*, controller_costmap_ros_);
^
In file included from
/home/klek/catkin_ws/src/indires_navigation/adapted_move_base/include/adapted_move_base/move_base.h:58:0,
from
/home/klek/catkin_ws/src/indires_navigation/adapted_move_base/src/move_base.cpp:44:
/opt/ros/melodic/include/nav_core/recovery_behavior.h:56:20: note:
candidate: virtual void
nav_core::RecoveryBehavior::initialize(std::__cxx11::string,
tf2_ros::Buffer*, costmap_2d::Costmap2DROS*, costmap_2d::Costmap2DROS*)
virtual void initialize(std::string name, tf2_ros::Buffer* tf,
costmap_2d::Costmap2DROS* global_costmap, costmap_2d::Costmap2DROS*
local_costmap) = 0;
^~~~~~~~~~
/opt/ros/melodic/include/nav_core/recovery_behavior.h:56:20: note: no
known conversion for argument 2 from ‘tf::TransformListener*’ to
‘tf2_ros::Buffer*’
indires_navigation/adapted_move_base/CMakeFiles/adapted_move_base.dir/build.make:62:
recipe for target
'indires_navigation/adapted_move_base/CMakeFiles/adapted_move_base.dir/src/move_base.cpp.o'
failed
make[2]: ***
[indires_navigation/adapted_move_base/CMakeFiles/adapted_move_base.dir/src/move_base.cpp.o]
Error 1
CMakeFiles/Makefile2:9845: recipe for target
'indires_navigation/adapted_move_base/CMakeFiles/adapted_move_base.dir/all'
failed
Unable to catkin_make and I'm not clear on classes
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/noeperez/indires_navigation/issues/4, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADUK36G4LUZ3NFYNL6DHKA3RMVRUTANCNFSM4MILHTDQ
.

--
NOE PEREZ HIGUERAS
Postdoctoral Researcher - RoboticsLab
Dept. Ingenieria de Sist. y Automatica
Universidad Carlos III de Madrid
c/ Butarque, 15 28911 Leganes, Madrid
España - SPAIN

I still encountered an error after doing so
In file included from /opt/ros/melodic/include/class_loader/class_loader_core.hpp:47:0,
from /opt/ros/melodic/include/class_loader/class_loader.hpp:46,
from /opt/ros/melodic/include/class_loader/multi_library_class_loader.hpp:42,
from /opt/ros/melodic/include/pluginlib/./class_loader.hpp:38,
from /opt/ros/melodic/include/pluginlib/class_loader.h:35,
from /home/klek/catkin_ws/src/indires_navigation/costmap_2d/include/costmap_2d/costmap_2d_ros.h:49,
from /home/klek/catkin_ws/src/indires_navigation/local_3d_planner/include/local_3d_planner/local_3d_planner_ros.h:12,
from /home/klek/catkin_ws/src/indires_navigation/local_3d_planner/src/local_3d_planner_ros.cpp:9:
/opt/ros/melodic/include/class_loader/meta_object.hpp: In instantiation of ‘B* class_loader::impl::MetaObject<C, B>::create() const [with C = local_3d_planner::Local3DPlannerROS; B = nav_core::BaseLocalPlanner]’:
/home/klek/catkin_ws/src/indires_navigation/local_3d_planner/src/local_3d_planner_ros.cpp:284:2:   required from here
/opt/ros/melodic/include/class_loader/meta_object.hpp:196:12: error: invalid new-expression of abstract class type ‘local_3d_planner::Local3DPlannerROS’
return new C;
^~~~~
In file included from /home/klek/catkin_ws/src/indires_navigation/local_3d_planner/src/local_3d_planner_ros.cpp:9:0:
/home/klek/catkin_ws/src/indires_navigation/local_3d_planner/include/local_3d_planner/local_3d_planner_ros.h:47:9: note:   because the following virtual functions are pure within ‘local_3d_planner::Local3DPlannerROS’:
class Local3DPlannerROS : public nav_core::BaseLocalPlanner {
^~~~~~~~~~~~~~~~~
In file included from /home/klek/catkin_ws/src/indires_navigation/local_3d_planner/include/local_3d_planner/local_3d_planner_ros.h:32:0,
from /home/klek/catkin_ws/src/indires_navigation/local_3d_planner/src/local_3d_planner_ros.cpp:9:
/opt/ros/melodic/include/nav_core/base_local_planner.h:78:20: note: 	virtual void nav_core::BaseLocalPlanner::initialize(std::__cxx11::string, tf2_ros::Buffer*, costmap_2d::Costmap2DROS*)
virtual void initialize(std::string name, tf2_ros::Buffer* tf, costmap_2d::Costmap2DROS* costmap_ros) = 0;
^~~~~~~~~~
In file included from /home/klek/catkin_ws/src/indires_navigation/navigation_features_3d/include/navigation_features_3d/nav_features3d.h:62:0,
from /home/klek/catkin_ws/src/indires_navigation/rrt_planners/include/rrt_planners/ros/ValidityChecker3D.h:36,
from /home/klek/catkin_ws/src/indires_navigation/rrt_planners/include/rrt_planners/ros/RRT_ros_wrapper.h:66,
from /home/klek/catkin_ws/src/indires_navigation/global_rrt_planner/include/global_rrt_planner/global_rrt_planner_ros.h:15,
from /home/klek/catkin_ws/src/indires_navigation/global_rrt_planner/src/global_rrt_planner_ros.cpp:3:
/usr/include/pcl-1.8/pcl/sample_consensus/model_types.h: In function ‘void __static_initialization_and_destruction_0(int, int)’:
/usr/include/pcl-1.8/pcl/sample_consensus/model_types.h:99:3: warning: ‘pcl::SAC_SAMPLE_SIZE’ is deprecated: This map is deprecated and is kept only to prevent breaking existing user code. Starting from PCL 1.8.0 model sample size is a protected member of the SampleConsensusModel class [-Wdeprecated-declarations]
SAC_SAMPLE_SIZE (sample_size_pairs, sample_size_pairs + sizeof (sample_size_pairs) / sizeof (SampleSizeModel));
^~~~~~~~~~~~~~~
/usr/include/pcl-1.8/pcl/sample_consensus/model_types.h:99:3: note: declared here
indires_navigation/local_3d_planner/CMakeFiles/local_3d_planner_ros.dir/build.make:86: recipe for target 'indires_navigation/local_3d_planner/CMakeFiles/local_3d_planner_ros.dir/src/local_3d_planner_ros.cpp.o' failed

Hi Klek,
it seems you did not remove the melodic package nav_core properly.
You are getting:
/opt/ros/melodic/include/nav_core/base_local_planner.h:78:20: note: virtual
void nav_core::BaseLocalPlanner::initialize(std::__cxx11::string,
tf2_ros::Buffer*, costmap_2d::Costmap2DROS*)
virtual void initialize(std::string name, tf2_ros::Buffer tf*,
costmap_2d::Costmap2DROS* costmap_ros) = 0;
While the heading of the method initialize in base_local_planner.h of the
nav_core package for Kinetic is:
virtual void initialize(std::string name, tf::TransformListener tf*,
costmap_2d::Costmap2DROS* costmap_ros) = 0;
You are still waiting to receive a tf2 buffer which is different from the
tf::TransformListener used in Kinetic.
Best regards,
Noé
El jue., 16 abr. 2020 a las 11:19, klek17<EMAIL_ADDRESS>escribió:

I still encountered an error after doing so
In file included from
/opt/ros/melodic/include/class_loader/class_loader_core.hpp:47:0,
from /opt/ros/melodic/include/class_loader/class_loader.hpp:46,
from
/opt/ros/melodic/include/class_loader/multi_library_class_loader.hpp:42,
from /opt/ros/melodic/include/pluginlib/./class_loader.hpp:38,
from /opt/ros/melodic/include/pluginlib/class_loader.h:35,
from
/home/klek/catkin_ws/src/indires_navigation/costmap_2d/include/costmap_2d/costmap_2d_ros.h:49,
from
/home/klek/catkin_ws/src/indires_navigation/local_3d_planner/include/local_3d_planner/local_3d_planner_ros.h:12,
from
/home/klek/catkin_ws/src/indires_navigation/local_3d_planner/src/local_3d_planner_ros.cpp:9:
/opt/ros/melodic/include/class_loader/meta_object.hpp: In instantiation of
‘B* class_loader::impl::MetaObject<C, B>::create() const [with C =
local_3d_planner::Local3DPlannerROS; B = nav_core::BaseLocalPlanner]’:
/home/klek/catkin_ws/src/indires_navigation/local_3d_planner/src/local_3d_planner_ros.cpp:284:2:
required from here
/opt/ros/melodic/include/class_loader/meta_object.hpp:196:12: error:
invalid new-expression of abstract class type
‘local_3d_planner::Local3DPlannerROS’
return new C;
^~~~~
In file included from
/home/klek/catkin_ws/src/indires_navigation/local_3d_planner/src/local_3d_planner_ros.cpp:9:0:
/home/klek/catkin_ws/src/indires_navigation/local_3d_planner/include/local_3d_planner/local_3d_planner_ros.h:47:9:
note: because the following virtual functions are pure within
‘local_3d_planner::Local3DPlannerROS’:
class Local3DPlannerROS : public nav_core::BaseLocalPlanner {
^~~~~~~~~~~~~~~~~
In file included from
/home/klek/catkin_ws/src/indires_navigation/local_3d_planner/include/local_3d_planner/local_3d_planner_ros.h:32:0,
from
/home/klek/catkin_ws/src/indires_navigation/local_3d_planner/src/local_3d_planner_ros.cpp:9:
/opt/ros/melodic/include/nav_core/base_local_planner.h:78:20: note:
virtual void nav_core::BaseLocalPlanner::initialize(std::__cxx11::string,
tf2_ros::Buffer*, costmap_2d::Costmap2DROS*)
virtual void initialize(std::string name, tf2_ros::Buffer* tf,
costmap_2d::Costmap2DROS* costmap_ros) = 0;
^~~~~~~~~~
In file included from
/home/klek/catkin_ws/src/indires_navigation/navigation_features_3d/include/navigation_features_3d/nav_features3d.h:62:0,
from
/home/klek/catkin_ws/src/indires_navigation/rrt_planners/include/rrt_planners/ros/ValidityChecker3D.h:36,
from
/home/klek/catkin_ws/src/indires_navigation/rrt_planners/include/rrt_planners/ros/RRT_ros_wrapper.h:66,
from
/home/klek/catkin_ws/src/indires_navigation/global_rrt_planner/include/global_rrt_planner/global_rrt_planner_ros.h:15,
from
/home/klek/catkin_ws/src/indires_navigation/global_rrt_planner/src/global_rrt_planner_ros.cpp:3:
/usr/include/pcl-1.8/pcl/sample_consensus/model_types.h: In function ‘void
__static_initialization_and_destruction_0(int, int)’:
/usr/include/pcl-1.8/pcl/sample_consensus/model_types.h:99:3: warning:
‘pcl::SAC_SAMPLE_SIZE’ is deprecated: This map is deprecated and is kept
only to prevent breaking existing user code. Starting from PCL 1.8.0 model
sample size is a protected member of the SampleConsensusModel class
[-Wdeprecated-declarations]
SAC_SAMPLE_SIZE (sample_size_pairs, sample_size_pairs + sizeof
(sample_size_pairs) / sizeof (SampleSizeModel));
^~~~~~~~~~~~~~~
/usr/include/pcl-1.8/pcl/sample_consensus/model_types.h:99:3: note:
declared here
indires_navigation/local_3d_planner/CMakeFiles/local_3d_planner_ros.dir/build.make:86:
recipe for target
'indires_navigation/local_3d_planner/CMakeFiles/local_3d_planner_ros.dir/src/local_3d_planner_ros.cpp.o'
failed
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/noeperez/indires_navigation/issues/4#issuecomment-614524749,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADUK36ANVIRAU7JSFZDROSLRM3EQRANCNFSM4MILHTDQ
.

--
NOE PEREZ HIGUERAS
Postdoctoral Researcher - RoboticsLab
Dept. Ingenieria de Sist. y Automatica
Universidad Carlos III de Madrid
c/ Butarque, 15 28911 Leganes, Madrid
España - SPAIN


Number of cached files to keep by default : need external opinions

So I'm doing #166 (scene-caching), and to summarize there is a functionality that clean the cache (the partial movies already generated) if there is more than X partial movie files.
The question was, how much this value should be initialized ?
Some people (@Aathish04 ) suggested to infinity. @Tony031218 suggested 70-100 (read his message https://github.com/ManimCommunity/manim/pull/166#discussion_r463542377)
I personally suggest .. 10-15, as I think that generally people put no more than 10-15 wait and play calls per scene, as a lot of people render their movies in several scenes.
So I'm calling on your experience, how much play/wait calls are usually in your code ?

There are many situations:

If you are to make a simple demo, it may only need 10~20 animations.
If you are to make a part of a video, it may take 60~150 animations.
If you are using a for loop to perform frame-by-frame operations (such as the most common frame-by-frame rotation), you need at least 360 animations, usually around 1000.
If a scene contains a small number of multiple objects made using a for loop to perform operations in sequence, usually need 100~250 animations.

So I said that setting the default value to 70~100 is normal and not very much at all.
In my opinion, the cache should not be forced to be too small. The purpose of using the cache is to avoid repeated rendering when necessary, and the reserved video number may cause the cache to lose its meaning.
In addition, even if hundreds of cached videos are reserved, the space occupied is not very large. The partial video files generated by manim are generally between 20KB and 200KB. If each partial video is calculated as 100KB (in fact, it will be more less, generally around 50KB), even if 200 videos are reserved, it only needs 20MB of space. For the cache, this is not a big number (and you also have --flush_cache to flush the cache, so it will not cause confusion)

And I asked briefly in the @manim-kindergarten's QQ group (most of these people are very experienced in using manim to make videos), and the results are these:

(I suggest posting a poll on discord to get a wider range of opinions. If you do, can you send a link here)

@Tony031218 You convinced me. If someone else wants to express their opinion, feel free :D

By the way, the source code of the first picture I sent in #166 (comment) is here, and you can see the log and download the rendered result video in the Artifacts of this action , and the video is in English :)

Very nice. Both the video and the action are very cool!

So I'm calling on your experience, how much play/wait calls are usually in your code ?

In my longest scenes, the number of animations approaches 150-200.
But usually, it's around 30-50 animations per scene.

Ok, then considering the space occupied by these files and the numbers you just told, I will set the default value to 100.
If you have any objection feel free to tell them directly in #166
Thank you again @Aathish04 @Tony031218 !
Closing this.


Enhancement:Customize the CONTRIBUTING file for the issues.yml workflow

          Will customize the CONTRIBUTING file for the issues.yml workflow

Thanks! 🚀 @takanome-dev
Originally posted by @prjctimg in https://github.com/prjctimg/huetiful/issues/85#issuecomment-1806460474
Creating a CONTRIBUTING file to help people interested in the project get started on contributing to our efforts would greatly benefit this project.
Any suggestions are greatly appreciated!

A couple of guides that I found interesting:

https://docs.opensauced.pizza/contributing/introduction-to-contributing/
https://github.com/EddieHubCommunity/BioDrop/blob/main/CONTRIBUTING.md
https://github.com/takanome-dev/blog-with-astro-golang/blob/main/CONTRIBUTING.md
we can the following link for beginners -> https://opensource.guide/how-to-contribute/ (awesome guide)

A couple of guides that I found interesting:

https://docs.opensauced.pizza/contributing/introduction-to-contributing/
https://github.com/EddieHubCommunity/BioDrop/blob/main/CONTRIBUTING.md
https://github.com/takanome-dev/blog-with-astro-golang/blob/main/CONTRIBUTING.md
we can the following link for beginners -> https://opensource.guide/how-to-contribute/ (awesome guide)

Awesome! Checking them out right now and will create a draft CONTRIBUTING.md

A couple of guides that I found interesting:

https://docs.opensauced.pizza/contributing/introduction-to-contributing/
https://github.com/EddieHubCommunity/BioDrop/blob/main/CONTRIBUTING.md
https://github.com/takanome-dev/blog-with-astro-golang/blob/main/CONTRIBUTING.md
we can the following link for beginners -> https://opensource.guide/how-to-contribute/ (awesome guide)

Awesome! Checking them out right now and will create a draft CONTRIBUTING.md

Rewrote the CONTRIBUTING file and added comprehensive steps and guidelines to help new contributors get started.
Will probably include the coding conventions in the futy


Set DTLS cert issuer/subject

@k0nserv it doesn't look like libWebRTC does. https://webrtc.googlesource.com/src/+/1568f1b1330f94494197696fe235094e6293b258/rtc_base/openssl_certificate.cc#58


Create nodes with “testing” roles

We need nodes with "testing" roles in that they are capable of autonomously:

Sending files to be cached by other peers.
Retrieving files from peers at random time intervals.
Logging and displaying stats from these actions.

The nodes should be capable of running multiple test scenarios.
eg. nodes send File A 99% of the time to emulate the coverage of a "popular"/ oft requested file. They send File B 1% of time and then gather stats that compare coverage and retrieval performance for A and B.
eg. nodes have a library of files in order of increasing size. They collect stats on pushing / retrieval times relative to file size.

can probably use this setup verbatim to push test node logs to an InfluxDB database.
behaviour for Myel node would then be: if user passed a metrics.config file to Myel node then instantiate metrics objects and log to InfluxDB.
we can use build/k8s to deploy an InfluxDB container + new DockerFile for test nodes with metrics.config file.
final step would be to create bash scripts that make the test nodes execute regular sequences of action that are logged to InfluxDB.


Feature Request : Context menu new functionality for open folders

Would be nice to have on the context menu for folders have this 2 buttons

Open folder on vscode
Open folder on wsl (This is related with the extension of Remote - WSL) -> Im submitting this on this issue, but i will relate this with the main extension repo microsoft/vscode-remote-release#6730

This would simplify alot the fact of clicking on file > Open Folder, after that showing the files on the file explorer (Not always on the right folder).
So we transform a four/five steps task into 2 step task :)

Closing as https://github.com/microsoft/vscode-remote-release/issues/6730 did not receive enough upvotes


repo needs license and citation instructions

Add the MIT license (see my HoneyComb repo for an example of how that looks).
Edit the README to say so.
Add below that a requirement to cite Ness et al and Ho et al (in prep).
Get me to sign off on all this before closing issue.

@davidwhogg , added. Let me know if it looks okay.

signing off


Add self-signed chain

Add self-signed chain methods to ensure that CI passes.  Currently the self-signed chain simply returns nil; this could be enhanced later but works for now.

@zuazo it looks like only Travis is running CI... any suggestions on how to run the integration tests using Circle?  I've run the modified ones on my machine (which pass), but running them all is a PITA.  Thanks!

I have enabled CircleCI builds on forked PRs. I didn't know it is disabled by default.
Anyway, Travis CI seem to be failing due to this issue:
https://github.com/sickill/rainbow/issues/48
After this is fixed, I'm going to try to run Circle CI on your branch locally.

Merged! Thank you @andrewjamesbrown! :smiley:

Released in 2.1.0.


[Feature]: The click pop ups on both sides of the viewer cannot be closed outside the pop-up window on mobile devices

Is the feature relevant to the Firefox PDF Viewer?
Yes
Feature description
I am currently working on a mobile website project that uses a PDF viewer. However, during actual development and testing, I found that users cannot click on positions outside the pop-up window to close the function windows on the left and right sides. For example, when clicking on the 'sidebarToggleButton' button, the 'sidebarContainer' window pops up. After sliding and clicking on the page they want to view, they habitually want to click on the screen outside the pop-up window to close it, but there is no response after clicking. You need to click the sidebar toggle button again to close it.
So, I hope the PDF viewer can support the operation of closing the pop-up window by clicking on the area outside the pop-up window.
Other PDF viewers
No response

First of all, please note that the default viewer is developed for desktop applications (more specifically Firefox) and note also that Firefox for Android uses its own (simpler) UI.
Secondly, the sidebar is as its name suggests not a "popup" since it actually moves the document vertically when opened. Hence it seems completely wrong to treat it like a "popup", and the sidebar also supports being resized which would be much more difficult to do without accidentally closing it if what you're suggesting is implemented.
Since the current implementation is on purpose, and also inline with how sidebars usually work, closing as WONTFIX.


Browser uniformity

The svg circuit animations were previously only executed in chrome. In Safari and Firefox, the circuit svg lines rendered on screen load and then the nodes eased-in afterwards. Now in all three browsers the svg circuit lines will be drawn after page load and ease-in to mimic the animation seen in chrome.

Awesome, thank you!


Compressed video seems to be corrupted.

I am using an Async Task:
VideoCompressAsyncTask compressAsyncTask = new VideoCompressAsyncTask(getApplicationContext(), imageWithTextMessage, videoThumbnail);
                    compressAsyncTask.execute("true", mUriVideo.toString()), getApplicationContext().getExternalFilesDir(Environment.DIRECTORY_MOVIES).getPath());

class VideoCompressAsyncTask extends AsyncTask<String, String, String> {

        Context mContext;
        Message mMessage;
        Bitmap mThumbnailBitmap;

        public VideoCompressAsyncTask(Context context, Message message, Bitmap thumbnailBitmap) {
            mContext = context;
            mMessage = message;
            mThumbnailBitmap = thumbnailBitmap;
        }

        @Override
        protected void onPreExecute() {
            super.onPreExecute();
            mLoadingView.setVisibility(View.VISIBLE);
        }

        @Override
        protected String doInBackground(String... paths) {
            String filePath = null;
            try {

                //This bellow is just a temporary solution to test that method call works
                boolean b = Boolean.parseBoolean(paths[0]);
                if (b) {
                    filePath = SiliCompressor.with(mContext).compressVideo(paths[1], paths[2],1280,
                            720,
                            1500000);
                } else {
                    Uri videoContentUri = Uri.parse(paths[1]);
                    // Example using the bitrate and video size parameters
                    /*filePath = SiliCompressor.with(mContext).compressVideo(
                            videoContentUri,
                            paths[2],
                            1280,
                            720,
                            1500000);*/
                    filePath = SiliCompressor.with(mContext).compressVideo(
                            videoContentUri,
                            paths[2]);
                }

            } catch (URISyntaxException e) {
                e.printStackTrace();
            } catch (Exception e) {
                e.printStackTrace();
            }
            return filePath;

        }
     @Override
        protected void onPostExecute(String compressedFilePath) {
            super.onPostExecute(compressedFilePath);
            mViewModel.sendVideoMessage(mMessage, Uri.parse(compressedFilePath), FileHelper.getInstance().compressBitmap(mThumbnailBitmap, 60), mCurrentGroupId);
        }
    }

The compressed video seems to be corrupted. It appears as a normal mp4 file, but when I click on it the device gives me a notice: "Failed to play video. An unknown error has occured.".
The original video that corresponds to mVideoUri works just fine on the device.
Does it have have to do with the orignal video's audio/video codec?
Can anyone help me please?
PS: I am using this library as the app's camera.
https://github.com/natario1/CameraView
implementation 'com.otaliastudios:cameraview:2.6.4'

I would really love if anyone shares if he encountered this issue.

Just wait until compression is finished and than open the video file compressed. You can see that compression file mp4 on device even if compression hasn't finished yet. That's why you see : "Failed to play video. An unknown error has occured.".

Just wait until compression is finished and than open the video file compressed. You can see that compression file mp4 on device even if compression hasn't finished yet. That's why you see : "Failed to play video. An unknown error has occured.".

I think @charlieaboumoussa is correctly using the URI in onPostExecute i.e. when the background task is completed.
I am facing this issue but with a different video.

@maria-chris So I cannot do anything with the compressedUri until the file is compressed, or else the compression would be interrupted. Is that what you mean?

@ankitbatra11 So it seems you have the same issue. How did you solve this? Thank you

I am using my own  fork of this which also provides a progress listener.

Hello @ankitbatra11
I have added implementation 'com.github.ankitbatra11:VideoCompressor:1.0.3'
I have the following error:
Unable to resolve dependency for ':app@debug/compileClasspath': Could not resolve com.github.ankitbatra11:VideoCompressor:1.0.3
Any suggestions?

Hello @ankitbatra11
I have added implementation 'com.github.ankitbatra11:VideoCompressor:1.0.3'
I have the following error:
Unable to resolve dependency for ':app@debug/compileClasspath': Could not resolve com.github.ankitbatra11:VideoCompressor:1.0.3
Any suggestions?

You must jitpack as one of the repo in your android project.
allprojects {
    repositories {
        google()
        jcenter()
        maven {
            url "https://www.jitpack.io"
        }
    }
}

@ankitbatra11 Hello. It is still showing the same error. It is a hassle to implement compression on android. What to do?

@Tourenathan-G5organisation if you could help, it would be great! thank you

@ankitbatra11 Hello. It is still showing the same error. It is a hassle to implement compression on android. What to do?

Can you paste your root build.gradle file?


Revert "Upgrade JUnit 4.13 to 4.13.1 to fix security vulnerability"

Reverts Alluxio/alluxio#12361

alluxio-bot, merge this please.


Update Skeleton Instructions for Development Guide Project Setup

🗣 Description
This PR will update the Documentation Guide Project Setup markdown files instructions to create new skeleton repositories or skeletonize existing repositories.
💭 Motivation and context
These updates are required for uniformity of the cisagov skeleton updates to create and update repositories and to advise on the latest skeletonize tools used.
✅ Pre-approval checklist

[x] This PR has an informative and human-readable title.
[x] Changes are limited to a single goal - eschew scope creep!
[x] All relevant type-of-change labels have been added.
[x] I have read the CONTRIBUTING document.
[x] These code changes follow cisagov code standards.
[x] All relevant repo and/or project documentation has been updated
to reflect the changes in this PR.
[x] All new and existing tests pass.

✅ Pre-merge checklist

[ ] Revert dependencies to default branches.
[ ] Finalize version.

✅ Post-merge checklist

[ ] Create a release.

Let's get @mcdonnnj's review before merging.


In Windows-2022, A app compiled by MinGW g++ fails.

Description
Related: #5459 #6627
I ran the simple workflow below. the step that run hello fails in cmd.
on:
  workflow_dispatch:

jobs:
  fix:
    runs-on: windows-latest
    steps:
        shell: pwsh
        run: |
          '
          #include <cstdio>
          #include <vector>
          using namespace std;
          int main(int, char* argv[]) {
              vector<int> a(4);
              printf("%d\n", a.size());
              return 0;
          }
          ' > hello.cpp
      - name: Compile
        run: g++ -o hello hello.cpp
      - run: hello
        shell: cmd
        name: Run hello on cmd
        id: hello

It seems C:/Program Files/Git/mingw64/bin/lib*.dll hidden by C:\Strawberry\c\bin\lib*.dll.
Adding C:/Program Files/Git/mingw64/bin/ to beginning of $PATH, it works fine.
      - name: Fix
        shell: bash
        run: |
          mkdir bin
          cp C:/Program\ Files/Git/mingw64/bin/lib*.dll bin/
          echo "$GITHUB_WORKSPACE/bin" >> $GITHUB_PATH

I create a action which add mingw to beginning of $PATH.
https://github.com/kzrnm/fix-mingw
But I hope any solution that works by default because this behavior is not obvious.
Platforms affected

[ ] Azure DevOps
[X] GitHub Actions - Standard Runners
[ ] GitHub Actions - Larger Runners

Runner images affected

[ ] Ubuntu 18.04
[ ] Ubuntu 20.04
[ ] Ubuntu 22.04
[ ] macOS 11
[ ] macOS 12
[ ] Windows Server 2019
[X] Windows Server 2022

Image version and build link
Version: 20221204.3 or older
Is it regression?
no
Expected behavior
a executable file hello exit 0.
Actual behavior
a executable file hello exit -1073741511.
Repro steps
I wrote in the description section.

Hi @kzrnm we will take a look.

Hi @kzrnm, we will change path, but not now, because we have deployment freeze next week and also this changes requires announcement, so I suppose we will do it next quarter. Feel free to reach us again, if you have some questions.
Thanks


Add server-side rendering example with next.js

Wow, thanks a lot! Are you planning to add next.js typescript example as well?

@yakovlevyuri Hiya, I wasn't planning on adding that currently as this is just a minimal example for server-side rendering. But it'd be nice to contribute these examples to the next.js repository instead :heart:


interactive use cmd

This PR adds interactivity to use similar to install
In demo'ing with @kylebaron noticed just doing qvm use panic'd given how it was naively passing the 0th index of the args without a length check so also fixes that bug.
The new behavior looks like:
qvm use
? Which version do you want to use?  [Use arrows to move, type to filter]
> v0.9.636
  v0.9.629 - **active**
  v0.9.587
  v0.9.583
  v0.9.565
  v0.9.563
  v0.9.562
  v0.9.561
  v0.9.559
  v0.9.550

@kylebaron - updated as v0.0.4 as of now
Give that a try:
wget https://github.com/dpastoor/qvm/releases/download/v0.0.4/qvm_Linux_x86_64.tar.gz -O /tmp/qvm.tar.gz
tar xzf /tmp/qvm.tar.gz qvm
mv qvm ~/bin/qvm
chmod +x ~/bin/qvm

https://user-images.githubusercontent.com/3196313/176960783-a8bfe77c-55fd-4f0f-aad3-6357343fcc3d.mov


Remove circular dependency involving htsget-test and htsget-search

Issue
The htsget-test crate has a circular dev dependency with htsget-search. This is resolved in cargo using feature flags to conditionally compile the code so that there is no circular dependency. Specifically, htsget-search depends on the cors-tests feature flag, but not the server-tests feature flag. We should consider remove this circular dependency entirely.
Motivation
The circular dependency causes problems when deploying the crates, as cargo publish cannot easily resolve the circular dependency. See #153. It also might increase the understandability of the code, because the conditional compilation may not be easy to reason about.
Implementation
The htsget-test crate can be split up into mutliple crates that contain only the required code to avoid a circular dependency. For example, htsget-test and htsget-test-server.

@mmalenic Instead of separating htsget-test into different crates, would it make sense to contain the minimum logic possible on the different crates so that they are self-contained and independent w.r.t testing?

Yes, that's probably the better approach. htsget-test does use some structs from htsget-search: https://github.com/umccr/htsget-rs/blob/0f64f48b9381de29309cfb6c398969b178d7187f/htsget-test/src/server_tests.rs#L14-L17 I'll see how easy it would be to remove these.


added directed/undirected to taxonomy for querying

to make the dumping to JSON-LD easier...

I thought we decided to merge Affect and Causal?
Remember that MITRE said that for them Affect is Causal when they don't know the polarity. Since polarity is captured in the states of entities, for us they would be similar.

Did we? We can also keep them separate and merge for use case... kind of
trying to keep things domain independent... or we can call them casual with
just a lower confidence score...
On Mon, Feb 12, 2018 at 6:34 PM Mihai Surdeanu<EMAIL_ADDRESS>wrote:

I thought we decided to merge Affect and Causal?
Remember that MITRE said that for them Affect is Causal when they don't
know the polarity. Since polarity is captured in the states of entities,
for us they would be similar.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/clulab/eidos/pull/77#issuecomment-365122012, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AFIniY0OqMXoHBOy6SOlnrW0wRmWJ3eZks5tUOaJgaJpZM4SC608
.

Ok…
But if we accept MITRE’s definition, which I like, it really doesn’t make sense to separate...

On Feb 12, 2018, at 6:55 PM, bsharpataz<EMAIL_ADDRESS>wrote:
Did we? We can also keep them separate and merge for use case... kind of
trying to keep things domain independent... or we can call them casual with
just a lower confidence score...
On Mon, Feb 12, 2018 at 6:34 PM Mihai Surdeanu<EMAIL_ADDRESS>wrote:

I thought we decided to merge Affect and Causal?
Remember that MITRE said that for them Affect is Causal when they don't
know the polarity. Since polarity is captured in the states of entities,
for us they would be similar.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/clulab/eidos/pull/77#issuecomment-365122012, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AFIniY0OqMXoHBOy6SOlnrW0wRmWJ3eZks5tUOaJgaJpZM4SC608
.

—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub, or mute the thread.


added subject docs on allowing all users

This change is

@liggitt, @jaredbhatti I created a new PR based on release-1.5.

Can you rebase this change against the master branch instead of the release-1.5 branch?

@jaredbhatti I rebased on master.

@jsloyer This PR needs to target master--not release-1.5. Release-1.5 has been merged and is effectively defunct.

@devin-donnelly I opened a new PR #2029 to replace this one.


Use github token instead of bot accounts

This should be one credential less to manage.

Well done adding the labels, etc.!


sst_importer: add import mode timeout

UCP #7223
What problem does this PR solve?
Issue Number: close #7223
Problem Summary: Currently, if Lightning or BR crashes, the TiKV nodes will be left in the import mode until the user manually switch them back into the normal mode.
What is changed and how it works?
What's Changed: In ImportModeSwitcher, a background future is added to put TiKV back into normal mode after the timeout.
Related changes
Check List
Tests

Unit test

Side effects

A new configuration for import mode timeout is added.

Release note

PTAL @kennytm


[video_player] Video disappears on pause in safari

What package does this bug report belong to?
video_player
What target platforms are you seeing this bug on?

Yes
Dependency versions
Used dart pad
Steps to reproduce
If you press the run button in safari, the video disappears.
Expected results
The video would stay up (like in every other browser)
Actual results
The video disappears.
Code sample
Code sample
import "package:flutter/material.dart";
import "package:video_player/video_player.dart";
void main() => runApp(const VideoApp());
/// Stateful widget to fetch and then display video content.
class VideoApp extends StatefulWidget {
  const VideoApp({super.key});
  @override
  _VideoAppState createState() => _VideoAppState();
}
class _VideoAppState extends State<VideoApp> {
  late VideoPlayerController _controller;
  @override
  void initState() {
    super.initState();
    _controller = VideoPlayerController.networkUrl(Uri.parse(
        "http://commondatastorage.googleapis.com/gtv-videos-bucket/sample/BigBuckBunny.mp4",),)
      ..initialize().then((_) {
        // Ensure the first frame is shown after the video is initialized, even before the play button has been pressed.
        setState(() {});
      });
  }
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: "Video Demo",
      home: Scaffold(
        body: Center(
          child: _controller.value.isInitialized
              ? AspectRatio(
                  aspectRatio: _controller.value.aspectRatio,
                  child: VideoPlayer(_controller),
                )
              : Container(),
        ),
        floatingActionButton: FloatingActionButton(
          onPressed: () {
            setState(() {
              _controller.value.isPlaying
                  ? _controller.pause()
                  : _controller.play();
            });
          },
          child: Icon(
            _controller.value.isPlaying ? Icons.pause : Icons.play_arrow,
          ),
        ),
      ),
    );
  }
  @override
  void dispose() {
    _controller.dispose();
    super.dispose();
  }
}

Screenshots or Videos

Screenshots / Video demonstration
https://github.com/flutter/flutter/assets/145144088/d74e4ee4-af83-4cdb-93fe-3ed0857d9941

Logs
Flutter Doctor output

You can see this on dart pad

Hi @camfrandsen, are you only seeing this issue when you run the code sample in dart-pad? If you run the code sample locally and open the site in safari, do you see the same issue?
Do you get any errors in your console?
What version of Safari are you using?

Yeah, I see it notepad as well as when running normal. There is nothing in the logs... I can pause and start several times without getting anything in the logs.
I do get a warning sometimes: "WebGL: non-portable extension enabled: WEBGL_polygon_mode", but no errors.
This is on safari 17.4.1. Chrome works great on the same machine

Hi @camfrandsen, does this happen everytime you pause the video? I ran the code sample you provided in safari but when I pause it, it doesn't disappear. See the recording below. What renderer are you using? And would you happen to be using open core legacy patcher?
https://github.com/flutter/flutter/assets/88313112/283a4a34-652a-4781-9fec-7e5ccaf3b0ab

Sorry I have not responded yet. I have a second project that does not show the same issue in safari and am trying to find the different. I will let you know what I find.

Alright, sorry that took so long, but I found some more information.
Using the exact same code as in the description in the dart pad, it always reproduces the issue for me. This is on Version 17.4.1 (196<IP_ADDRESS>.14).
The only way that I know how to run the code in a dev build for safari is to run flutter run -d chrome then copying the url and pointing safari to it. (If there is a better way, I would love to learn it). I then open a few tabs more tabs in safari pointing to the same url. At least one of them will show the issue. It seems like I rarely see the bug on the first tab, but I do always see it.
The interesting thing to me about this is that dart pad, I see it every time, but with a dev build, it requires several tabs running at the same time to always see it.
A couple of notes, that second project that I thought was working, it actually wasn't, but since it was the first tab that I opened, I didn't really see it fail.
Also, I am just using the default renderer, so CanvasKit (I haven't tried safari in a mobile browser, just in a desktop browser.
Note: This is on safari from a mac-mini. Are you running with Safari from a mobile device?

Hi @camfrandsen, I test on Safari on my m1-mac. Can you try running the app with flutter run -d web-server? It doesn't launch chrome and you can copy the url into any browser of your choice.
Do you experience this issue in release mode as well?

@danagbemava-nc Great idea! I just tried using flutter run -d web-server, and it still reproduced the issue.
Something else that may be the difference, is I have disabled the cache in the dev tools. If you disable the cache and reload it, then do you see it?
And yeah, we see it very consistently in release, without the cache disabled. But disabling the cache in debug makes it easier to reproduce.

@camfrandsen I couldn't reproduce this issue on my Safari Version 17.1 (196<IP_ADDRESS>.7); I disabled cache as well.
When you see the issue, does the sound still play or not? Can you inspect web element to see if video still stays there? It's worth trying to test with a pure web that contains video element (without using package) to isolate the issue.

It is very interesting to me that some machines with safari see the issue, and some don't... We have only tried it on 4 computers at this point, and have seen it on each one. Having said, I believe this to be a safari issue. As I can reproduce the issue with the follow html code:
<!DOCTYPE html>

<video width="400" controls>
  <source src="http://commondatastorage.googleapis.com/gtv-videos-bucket/sample/BigBuckBunny.mp4" type="video/mp4">

  Your browser does not support HTML video.
</video>

Video courtesy of
Big Buck Bunny.

https://github.com/flutter/flutter/assets/145144088/28d9e866-2f81-4f7a-959c-db97ee94015b
Thank you for all of your help trying to track this down! I really appreciate it! I will let you close the issue so that way you can mark it however you would like.
Thank you again!

Great, glad we could you trace the root of the issue.
Closing this as it appears to be a general Safari issue rather than an issue with flutter itself.
Thank you


[Bug]: When resolving a 7, choosing a move that targets and then canceling and selecting the other card leaves you still targeting.

Bug Summary
We fail to clear out the targeting state when you cancel the decision to make a play that targets from the top of the deck
Detailed Description
When you play a 7 you get to pick one of the top two cards of the deck to play. Then you can click a card, and you'll be presented with the options of how to play it. If you pick a jack, or the one-off effect of a 9 or two, you'll be presented with another UI for choosing which card to target.
That UI doesn't properly go away if you cancel the decision to play that 9/jack/2, and then click another card. To fix this we should create a test case in e2e/specs/in-game/sevens.spec.js and then examine the function that cancels targeting to ensure it properly resets its state
Current Behavior
No response
Expected Behavior
No response
Steps to Reproduce

Opponent should have a point card out
There should be a 9, 2, or jack on top of the deck
Play a 7
Click a 2, 9, or jack off the top of the deck and choose to play its targeting effect (one-off or royal)
Click 'Cancel'
Click the other card on the top of the deck
Expected behavior is that you will see the options to play your move as normal, but instead currently you'll see the targeting overlay

I'll be working on this one

@TommySchmid verified that this is no longer reproducible. Closing until further notice


Node amqp connection manager

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[FLINK-27256][runtime] Log the root exception in closing the task man…

…ager connection

What is the purpose of the change
Log the root exception in closing the task manager connection for ease of debugging.
Brief change log
Log the root exception in closing the task manager connection.
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? no
If yes, how is the feature documented? (not applicable

@flinkbot run azure


Add custom % padding for some cards

Not relevant anymore since we're going to use the round images from the game.


Refactor node-uuid to uuid

Looks like node-uuid was renamed to uuid a while back and the node-uuid was left to stagnate. This should be a straight forward refactor. Make sure their have not been significant changes to the api.
Happy Coding!

I'll work on this.


Add pre-installs for deployment factories

This RIP proposes a set of known deployment factories that should be pre-installed on every rollup to make it easier to deploy contracts in a trustless, deterministic way. In the best case this also allows for same address deployments of the same contracts across multiple chains.

Hey @rmeissner I have assigned the next available number, please update to RIP-7740

any consideration to adding multicall to this list?


release v1.0.2

With the exception of ticket #277 , which is moving statements to 1.0.3, 1.0.2 tickets have been closed off.
There is quite a few small changes and a new statement template in 1.0.2, the changes are all tracked in the 1.0.2 version_changes document, which I will pull out for release notes.
I am happy to do the required merges and push 1.0.2 to master next week as discussed (minus the target setting statements).
The caveat from my end is work in 1.0.2 (as far as I know) hasnot been through any testing process on the Jisc side, thrown at a LDH etc. I think statements such as the mobile app content viewed still haven't been tested since they were added in 1.0.1.
For the 1.0.1 release Jisc asked us to release and hotfix based on Jisc feedback, Gareth gave the impression that the approach was to be the same.
If there is a nod to this approach, a release of 1.0.2 will take place on 11th of Dec

Yes this all sounds fine.
I have already tested load to the LDH of the e-content recipe without issue.

released here: https://github.com/jiscdev/xapi/releases/tag/1.0.2
This has been merged in master and the 1.0.2 dev branch will be deleted


Remove cmdex, add command

remove go-utils/cmdex
replace with go-utils/command
change NewCommand syntax to New

Thank you for the PR @radimvaculik !
It will be released soon! 🎉🚀


Bootstrap 4 Beta

Sup dwgs,
Wouldnt it be nice to add bootstrap 4 beta support?
Inline works pretty well at the moment but not popout with popper.js
Cheers

just as another reference: #950

@Talv I've used your js and css, but for some reason I can't enter anything in the input box. messed around with the css and can't figure out what's going on. it's like it's disabled or something.

Nevermind- it's on my end. I'm loading the inline editor in a modal form, and for some reason that's making it act goofy. When i load your js in a normal page, it works fine in bootstrap 4. Thanks, btw, for getting this working with BS4!

 Thanks! Works like a champ.

@Talv I spoke too soon, it seems. It technically "works", but for some reason, when I click on an editable element, it jumps to the top of the page, meaning I have to scroll down to get back to the editable field. I'm assuming this is an easy fix involving preventDefault(), but I haven't looked at it closely yet.

@Talv I spoke too soon, it seems. It technically "works", but for some reason, when I click on an editable element, it jumps to the top of the page, meaning I have to scroll down to get back to the editable field. I'm assuming this is an easy fix involving preventDefault(), but I haven't looked at it closely yet.

@sburkett did you solve it?

@qvarting
Also experiencing this. Anyone figured a workaround yet?

@sburkett It does not look like preventDefault() issue since I use a simple span as editable, and still get this behavior. Might be mistaken though - I mostly do backend :)

Ok, this is probably due to fact the the input field is being focused upon before it's positioned, forcing browser to scroll as close as possible to it's position. Commenting out line 2932 in bootstrap4-editable/js/bootstrap-editable.js fixes the scrolling but, obviously, prevents field from being focused on appearing, which is less than desirable. The underlying cause for this behavior change is probably bootstrap using another positioning lib for popovers.
I'll try to come with some less invasive fixes since this PR seems to be the only way to use X-Editable with popover in Bootstrap 4 environment.

@rustemas do you have a solution for select (dropdown) as well?

@rustemas do you have a solution for select (dropdown) as well?

I was testing with the same solution as for the text boxes (timeout for focus), and strange enough it seems that just adding the "activate" function (without further actions in that function) solved it for me.
So in line 3216 between the "renderList" and "value2htmlFinal" functions add this:
        }, //end renderList Function
        activate: function() {
          //do nothing
        },
        value2htmlFinal: function(value, element) {

This worked for me, no jumping to top for me anymore!

@wouter41 thanks alot! seems to work.
Cheers! 🍼 🍺

Hi guys,
I wanna know if you faced a similar issue I saw or not. Using Bootstrap version 4 of this library (thanks to @Talv), whenever I click on any field, it shows a popup correctly. But if I hit "Esc" key instead of clicking on X icon, X-editable will be corrupted (you will no longer be able to edit anything).
Did you see any similar issue? Any suggestion?

Any time line for official release with bootstrap 4 support?

Can you guys tell me where to correct the alignment of the popup container? I always have a container to the right of the value being edited, and I need to move it down.

If some body will have problems with popover positioning just add this:
$('.editableFieldClass').on('shown', function () {
    $('.popover.show.editable-container').popover('update');
});

Where .editableFieldClass is class of your editable field.

Bootstrap 4 is worked for me. Check https://github.com/vitalets/x-editable/issues/1189#issue-2472436889


why are matrix values being changed here?

Hi, I noticed that in run_content_network.lua, these two lines have been used:
    output[output:gt(1)]=1
    output[output:lt(-1)]=-1

I was wondering what is the reason behind this?

That's just to clip the output values to between [-1, 1] for when the images are saved to a file. Otherwise the save to file will scale according to min and max values of output, which will result in incorrect color scaling of the image.

That's just to clip the output values to between [-1, 1] for when the images are saved to a file. Otherwise the save to file will scale according to min and max values of output, which will result in incorrect color scaling of the image.

Exactly


[TWAP BOT] The TWAP bot on ETH again took 5 minutes to execute. Why so long?

https://etherscan.io/address/0xb17a38d6ac57cd7238189c9c234ac193102943bc#tokentxns TWAP bot took 5 minutes to execute.
That is way too long and we saw this before. Why are we executing so long?

same as https://github.com/VolumeFi/paloma/issues/1501


use without maven

I am using wro4j at runtime only and am looking for a solution to toggle between my combined file in production and importing individual css/js in development for debugging.  This project looks like it comes close to what I need.  Am I able to use it without having first merged the files using Maven?  Trying to figure out if I need to create a separate taglib for my needs.

I think you should be able to do it using plain wro4j.

Thanks, you can turn off minification, but I could not find a way to break it out into separate files.  I created my own tag that seems to be working out.

good :) I can't close this issue because I'm not part of this project (anymore ;) ), can you do it ?


Use ClientOptions#properties option

The option ClientOptions#properties was completely disregarded previously. However, it is now taken into account:
createClient({
    ...,
    properties: {
        $os: "...",
        $browser: "...",
        $device: "..."
    }
});

*Did not format the entire source folder since that would be irrelevant to this PR.

@chroventer Can u give me a use case for this? When would you need this? TBH I don't think this belongs in the client options.

@chroventer Can u give me a use case for this? When would you need this? TBH I don't think this belongs in the client options.

We can have a nested option in the ClientOptions named "websocketOptions".


Server Testkit

Added a Testkit for the implementations of the server. The idea is to create a Mock Client in order to test several BSP features.
As of right now I am testing how it works against my bsp implementation in bazel.
I also plan to add tests against the HappyMockServer.

@jastice The only await now is at the boundary of the test, let me know what you think 😄 !

Thank you for the PR, LGTM! 👍


Cannot see command handlers are used

Look into test coverage

Look into how others have handled it.

This article provides a possible solution: https://thirty25.com/posts/2020/09/external-annotations

What specifically am I supposed to test for this issue?


puller logs wrong message make user confused

[2022/08/30 14:32:54.840 +08:00] [WARN] [ddl_puller.go:357] ["ddl puller resolved ts has not advanced"] [namespace=default] [changefeed=blackhole-test_ddl_puller] [duration=2562047h47m16.854775807s] [resolvedTs=435640275400130814]
[2022/08/30 14:32:54.920 +08:00] [WARN] [ddl_puller.go:357] ["ddl puller resolved ts has not advanced"] [namespace=default] [changefeed=mysql-test_ddl_puller] [duration=2562047h47m16.854775807s] [resolvedTs=435634842599948608]
[2022/08/30 14:33:24.840 +08:00] [WARN] [ddl_puller.go:357] ["ddl puller resolved ts has not advanced"] [namespace=default] [changefeed=blackhole-test_ddl_puller] [duration=2562047h47m16.854775807s] [resolvedTs=435640275400130814]
[2022/08/30 14:33:24.920 +08:00] [WARN] [ddl_puller.go:357] ["ddl puller resolved ts has not advanced"] [namespace=default] [changefeed=mysql-test_ddl_puller] [duration=2562047h47m16.854775807s] [resolvedTs=435634842599948608]

ddl puller resolved ts has not advanced  may cause by another reason, it is better to open another issue to record this problem.