Use "canonical" Jest configuration

Following #310

".(ts|tsx)": "<rootDir>/node_modules/ts-jest/preprocessor.js"
should be "^.+\\.tsx?$" see 1, 2, 3
"testRegex": "(/__tests__/.*|\\.(test|spec))\\.(ts|tsx|js)$"
should be "(/__tests__/.*|(\\.|/)(test|spec))\\.(jsx?|tsx?)$" see 1, 2

Is "^.+\\.tsx?$" that different from ".(ts|tsx)"? I can't explain it but it changes the coverage results for the simple and simple-async tests:

With ".(ts|tsx)":

With "^.+\\.tsx?$":

And I believe the results with "^.+\\.tsx?$" are the correct ones.
As for root package.json, I've changed "testRegex": "/__tests__/.*\\.(spec)\\.(ts|js)$"  to "tests/__tests__/.*\\.spec\\.ts$".
The path is now hardcoded to be sure to only match files tests/__tests__/*.spec.ts and not the others that end with .test.ts (differentiate test categories with .spec.ts vs .test.ts is dangerous IMHO).

I'm a little worried about the coverage changing.
Are you saying the new regex only matches files in tests folders? I think we should lean on the original jest regex which iirc matches all files in tests and everything called eg .spec.ts and .test.ts

Are you saying the new regex only matches files in tests folders? I think we should lean on the original jest regex which iirc matches all files in tests and everything called eg .spec.ts and .test.ts

I actually prefer the change. It sort of standardizes how we structure our tests.

I'm a little worried about the coverage changing.

Talking about "^.+\\.tsx?$" vs ".(ts|tsx)" with simple and simple-async tests?
Please clone my repo and play with it. I've changed coverageReporters so that it generates the HTML report.
I'm very interesting by knowing why the coverage results change.

Are you saying the new regex only matches files in tests folders?

Talking about "testRegex": "tests/__tests__/.*\\.spec\\.ts$" from root package.json? Yes, see https://regex101.com/r/lEHjwz/2

I actually prefer the change. It sort of standardizes how we structure our tests

Instead of differentiating tests based on a small part of their filenames (spec.ts vs test.ts), I suggest to create 2 separated directories: makes things clear about having 2 types of tests.

@morajabi

I'm OK with separating two kinds of tests in two folders

This will be for another PR

I have strong opinions on some of this. I'll get back to it after the weekend

In regards to the regex I think as stated previously:

I think we should lean on the original jest regex which iirc matches all files in tests and everything called eg .spec.ts and .test.ts
While other conventions might make more sense, I'd hate for someone to convert their js to typescript and then go 'Oh my god why don't half my tests run' - I think it should basically be a carbon-copy of the default config from jest.
Does that make sense?

I don't have time to take a look at the coverage atm, but it's really fkn weird. Maybe there's a some version mixup going on? It makes no sense to me that the coverage would change.

While other conventions might make more sense, I'd hate for someone to convert their js to typescript and then go 'Oh my god why don't half my tests run' - I think it should basically be a carbon-copy of the default config from jest.

The regex used in the documentation seems to be a copy of that from Jest. It's only in the tests for this repo that the regex is specific to this repo. That's what I was alluding to when I said it sort of standardizes how we structure our tests

I don't have time to take a look at the coverage atm, but it's really fkn weird. Maybe there's a some version mixup going on? It makes no sense to me that the coverage would change.

The coverage bit confounded me a bit too but then seeing that I didn't entirely understand how it exactly worked in the first place (which lines it ignored, etc), this version doesn't look that different. So I'm kinda ok with it. I'll let @tkrotoff chime in on this.

I actually thought the jest regex matched both files in tests and .test and .spec everywhere. If they're the same, I'm fine with it.

I actually thought the jest regex matched both files in tests and .test and .spec everywhere

The original regex in our (ts-jests's) package.json did that. But because we only have tests in one place and with a uniform naming convention, this change doesn't have any negative effects. It does restrict how we structure our tests going forward though - the tests will need to be in the specified directory and be named *.spec.*.


Handle environment variables in providers

Make sure they can handle plain values and value_from specifications

Oops, missed this was already implemented


Security Vulnerability in react-scripts 5.0.0 - CVE-2021-43138

CVE-2021-43138
Update async to "async": "^3.2.3",

Is there a recommended fix for this please, as even upgrading to the latest react-scripts produces this 'high severity' vulnerability which is causing our pipeline to fail the build. Is it going to be prudent to simply 'allow' this through somehow?

The issue was been fixed with Jake 10.8.5, released 8 hours ago. Running npm upgrade should update the transitive dependency on async to a patched version.


Review fetch stream and multi-fetch stream error handling

Reviewed and improved the error handling of fetch streams and multi-fetch streams:

fetch streams are no longer closed silently when an error occurs
multi-fetch streams expose the underlying FetchStreamError to consumers

Closed via #4027 and #4092.


提交sealos部署模板

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Other... Please describe:

What is the current behavior?

Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

README 中暂时不添加关于部署方式的链接内容🙏


HDFS-16011. Support ViewFs nested mount

2987

 Quality gate: Failed
5 Issues

 5 Code issues

Details

 Quality gate: Failed
5 Issues

 5 Code issues

Details


Weird scrolling in tmux

Since I upgraded to tmux 2.3 and gnome 3.22.1 powerline is acting weird.

It appears to be caused by an Unicode width change: powerline/powerline#1658


implement the abc abstractmethod

cf. https://docs.python.org/2/library/abc.html#abc.abstractmethod

I'm not sure it's a definite killer advantage to use this abstractmethod mechanism, but it doesn't break anything and this PR adds the test I was too lazy to write, so...
LGTM


Down replaced cluster members

Make sure a previous cluster member is marked as .down before replacing it
Motivation:

Resolve #866

Modifications:

When processing a MemberChange that replaces an existing node, mark the node as .down if it hasn't been already
Add an integration test for #866 (confirmed failure before this change.

Result:

Resolves #866

Also have a down-replaced-cluster-members-0.x in my fork against the release/0.x branch

Whoa that's a nasty compiler crash there... Thank you for looking into this I will have a look!
CI is weird since it is 5.6 maybe we should actually use 5.5 on this branch... Will think about it.

Change looks good to me! I'll reproduce and play around a bit more tomorrow -- can you submit the PR to 0.x and let's leave main be for the time being? I'll forward port the patch later then 👍

Minor typo in the integration test :)
16:29:43 /code/IntegrationTests/tests_04_cluster/test_02_ungraceful_shutdown_recovery.sh: line 31: thrid_logs: unbound variable

Hmmm the integration test is not aggressive enough perhaps since it does not reproduce the issue but I think the fix looks
right...

Good catch, was making a few silly assumptions in the integ test. Think the typo you caught might've been contributing to why I was getting it to fail initially ;)
Updated the test. Should fail deterministically without the fix.

Great, reproduced the failure and confirmed the fix -- looking good, thank you a lot @budde !
I'll cut a release for this as well :)


Updating the Preparing Keycloak guide

Scripted configuration uses the auth in the server url http://localhost:8081/auth due to which it fails with
Logging into http://keycloak.minikubeIp.nip.io/auth as user admin of realm master null [RESTEASY003210: Could not find resource for full path: http://keycloak.<IP_ADDRESS>.nip.io/auth/realms/master/protocol/openid-connect/token]
Making the server url more realistic as it uses  http://keycloak.minikubeIp.nip.io instead of localhost
Specifying KEYCLOAK_HOME is never mentioned in the guide

Hi @kami619,
Could you help with what should be the expected Server URL be updated to look more realistic, as the guide says " By default, tests expect Keycloak to run on [http://localhost:8080/auth" based on configuration here.


element :lang is compressed to element:lang which has different meaning

For example I have in the original CSS:
.en :lang(in)

(means: elements that has lang="in" as children of any element that has class="en")
After compression, it becomes:
.en:lang(in)

(without the space, which means elements that has both class="en" and lang="in")
This breaks sites like http://www.bibleforandroid.com, specifically
http://www.bibleforandroid.com/css/umum.css

I'm having trouble reproducing this on my machine.  What version of pagespeed are you using?  I'm seeing the last few rules in the above css minified as follows:
.in :lang(en) {display:none}.in>.navbar>.container>.navbar-collapse>.translator>.indb{color:#03a9f4!important}.en>.navbar>.container>.navbar-collapse>.translator>.engb{color:#03a9f4!important}.in>.navbar>.container>.navbar-header>.translator2>.indb{color:#03a9f4!important}.en>.navbar>.container>.navbar-header>.translator2>.engb{color:#03a9f4!important}.en :lang(in) {display:none}.translator{float:right}.translator-button{margin-top:12px;font-size:14px;color:#888;background:none;border:none}.translator-button:hover{color:#03a9f4}@media (min-width:767px){.translator2{display:none}}
So the spaces are being preserved.

I noticed this when using Chrome Compression Proxy (Data saver in chrome mobile).
When I look up at the page about that, it says it uses pagespeed, so I guess it's the same as this.
The response header contains Via: 1.1 Chrome-Compression-Proxy

Can you enter this as a Chrome bug?  It's best to track the bug in Chrome since that's how you reproduced it.  Please reference the chromium bug number in this bug, and vice versa.
https://code.google.com/p/chromium/issues/entry?
template=Defect%20on%20Mac%20OS&comment=Chrome+Version+++++++%3A+43.0.2357.124%0AOS+Version%3A+OS+X+10.10.3%0AURLs+%28if+applicable%29+%3A%0AOther+browsers+tested%3A%0A++Add+OK+or+FAIL+after+other+browsers+where+you+have+tested+this+issue%3A%0A+++++Safari+5%3A%0A++Firefox+4.x%3A%0A+++++IE+7%2F8%2F9%3A%0A%0AWhat+steps+will+reproduce+the+problem%3F%0A1.%0A2.%0A3.%0A%0AWhat+is+the+expected+result%3F%0A%0A%0AWhat+happens+instead+of+that%3F%0A%0A%0APlease+provide+any+additional+information+below.+Attach+a+screenshot+if%0Apossible.%0A%0AUserAgentString%3A+Mozilla%2F5.0+%28Macintosh%3B+Intel+Mac+OS+X+10_10_3%29+AppleWebKit%2F537.36+%28KHTML%2C+like+Gecko%29+Chrome%2F43.0.2357.124+Safari%2F537.36%0A%0A

Filed at
https://code.google.com/p/chromium/issues/detail?id=502880

I'm going to close this issue: I verified that http://www.bibleforandroid.com/css/umum.css does not have that minification bug in mod_pagespeed, and we are looking at how to fix it in the Data Reduction Proxy; follow along the Chrome bug for that.


Failed to create cache file when trying to run ruff

I'm using pyenv and had created a new virtual for Python 3.12.0. I installed ruff using pip the regular way (pip install ruff) in a new project folder, but I got an error when trying to run anything:
$ ruff check .
ruff failed
  Cause: Failed to create cache file '/home/golgor/Code/phoenix-test-bench/.ruff_cache/0.1.12/1189904080403456301'
  Cause: No such file or directory (os error 2)

I am running zsh on Fedora Linux, but I also tried in bash, both in VS Code and system terminal. I only installed ruff and tried to run it immediately so no configurations or anything.
I did some tests and noticed that it seems to only be the latest release.
$ pip install ruff==0.1.10
$ ruff --version
ruff 0.1.10
$ ruff check .
pbt/hardware/nina.py:222:33: E711 Comparison to `None` should be `cond is None`
pbt/hardware/rs485_interface.py:123:12: E721 Do not compare types, use `isinstance()`
Found 2 errors.
No fixes available (1 hidden fix can be enabled with the `--unsafe-fixes` option).

$ pip install ruff==0.1.11
$ ruff --version
ruff 0.1.11
$ ruff check .
pbt/hardware/nina.py:222:33: E711 Comparison to `None` should be `cond is None`
pbt/hardware/rs485_interface.py:123:12: E721 Do not compare types, use `isinstance()`
Found 2 errors.
No fixes available (1 hidden fix can be enabled with the `--unsafe-fixes` option).

$ pip install ruff==0.1.12
$ ruff --version
ruff 0.1.12
$ ruff check .
ruff failed
  Cause: Failed to create cache file '/home/golgor/Code/phoenix-test-bench/.ruff_cache/0.1.12/1189904080403456301'
  Cause: No such file or directory (os error 2)

I tried to run it with the --isolation option, and then it worked fine and after this the regular command works fine as well. Not sure if this is a bug or just some wierd environment issue for me. Unfortunately I can't reproduce it anymore, maybe someone else has had a similar issue?

Same problem here, my GitHub Action runs started failing since yesterday... I can provide the log archive if needed, error is pretty much the same though:
ruff failed
  Cause: Failed to create cache file '/home/runner/work/genai/genai/.ruff_cache/0.1.12/12636055692318189605'
  Cause: No such file or directory (os error 2)
Error: Process completed with exit code 2.

I believe this is a duplicate of #9489

Should be fixed now via v0.1.13 -- please let me know if not!


Request ID into history and searchable

User Story
Request ID shows in history of proposals and is searchable

T-shirt size: SML

User Story
"As an approver of role access, I would like to see a unique identifier on all proposals so that I can search and find the exact proposal I need in the case where someone needs to track down details on it."

Description
We show a proposal ID in the 'your requests' table... let's make it useful by adding it to the Approved/Expired/Rejected pages on the Approver UI. Add another column.  Since each of these pages has a search bar, we should be able to search by this value and find the desired proposal.  This should be included in the broad search so that I won't have to do multiple searches if I don't recall the dispensation of a particular proposal.

Acceptance Criteria/Tests
Verify that reqID shows in the desired tables, Demonstrate search capabilities

migrated to new tmobile/sawtooth-next-directory repo


Create Validator

Does project LCIA method match EPDs?
Is EPDs internalized?
Is all paths/references valid?

Classification validation - is all classification category needed present in the project schema?

Validate that the peoject only contains the specified subtypes of EPDs

Hi, about validator, valitron maybe is a good choice.

Hi, about validator, valitron maybe is a good choice.

Thanks @tu6ge, it looks like a good option!

Thanks , this is should be "option".


RoadMap for Spring Sync

Would like to know road map for Spring Sync, The concept is good and use cases are large with emergence of Client side MVC frames.
But seem like project is not active as it should be. Would like to know should I plan to use Spring Sync in one of the project.

project seems to be dead.

As noted on the README, it's in incubation and under evaluation.

this info is about 1 year ago..and no chechin since 2 years.. defacto dead..


s/edgeDNSServer/edgeDNSServers/g

As described in the Issue #154 this adds the ability to fall-back to another edge dns server from the list. These are passed to the operator as env variable EDGE_DNS_SERVERS (was singular before) and the value is a comma-separted list of ips/hostnames followed optionally with port number. example: <IP_ADDRESS>:11, <IP_ADDRESS>,hostname (spaces between entries are supported).
Then function Dig in dns.go has been modified to work with this list (variadic function) and also Exchange function in the same file was tweaked to support it.
This change doesn't break the backward compatibility, because both EDGE_DNS_{SERVER,PORT} still works, but user is notified in the operator logs that these two were deprecated.
Some old tests needed to be modified in order to pass and I've added also these new tests:
(in controllers/depresolver/depresolver_test.go)

TestResolveConfigWithEmptyEdgeDNSServersKey
TestResolveConfigWithMalformedEdgeDNSServersKey
TestResolveConfigWithTwoEdgeDnsServers
TestResolveConfigWithMultipleEdgeDnsServers1
TestResolveConfigWithMultipleEdgeDnsServers2
TestResolveConfigWithMultipleEdgeDnsServersMalformed1
TestResolveConfigWithMultipleEdgeDnsServersMalformed2
TestResolveConfigWithInvalidEdgeDnsServersValue

(in controllers/gslb_controller_test.go)

TestReturnsExternalRecordsUsingFailoverStrategyAndFallbackDNSserver

(in controllers/internal/utils/dns_test.go)

TestOneValidEdgeDNSInTheList
TestNoValidEdgeDNSInTheList
TestEmptyEdgeDNSInTheList
TestMultipleValidEdgeDNSInTheList
TestEmptyDNSList
TestValidDigFQDNWithDot

Thanks for the early exposure, I've converted it to Draft

@jkremser, I don't see all checks including linter, testrun, terratest etc. Could you make PR from feature branch?

@kuritka that's kinda of weird - workflows should be executed for all PRs even from the remote forks aren't they?

@ytsarev , I think @jkremser must allow actions in his fork, where workflows are running

@ytsarev , I think @jkremser must allow actions in his fork, where workflows are running

I've enabled the actions on my fork, let me try to close and open the pr

@kuritka
Enabling the gh actions on my fork is not related to the fact that the actions are not run against the pull request from a different fork. This should be fixed on our (k8gb-io/k8gb) repo. I will create another PR for this.

@jkremser, please  squash commits into one , align PR message with squashed commit.
thx

@jkremser, please squash commits into one , align PR message with squashed commit.

why? iirc, github should do that automatically during the merge, including the messages. Isn't it easier to review couple of independent commits in the PR rather than 1 big blob? I can do that, but I am really interested why anybody would want to do it.

@jkremser, please squash commits into one , align PR message with squashed commit.

why? iirc, github should do that automatically during the merge, including the messages. Isn't it easier to review couple of independent commits in the PR rather than 1 big blob? I can do that, but I am really interested why anybody would want to do it.

so we can easily track the changes. One PR, one commit. Besides, when I do a local review, I have to diff in individual commits although I need to see all changes at once.
The same goes for description, which is not part of commit message, but exists only on github.

One PR, one commit

but that's exactly what git hub does, when you hit that squash and merge button... check some commits on k8s upstream for instance: https://github.com/kubernetes/kubernetes/pull/104923 & https://github.com/kubernetes/kubernetes/pull/104925 , etc.
I mean I can do that, but is this really some kind of policy how to contribute to k8gb? If yes, I am asking about the reasoning behind it and if it makes any sense, because if there is a contribution from a community are you also going to ask them to squash everything even though, it's not kind of standard and github can do that for you, including the messages part.. It just merges all the commit messages into a list and put it to the squashed commit. As for the description in the PR, there is a correspondence going from the commit to PR link so why having it twice, I like things "DRY"

@jkremser , is PR name s/edgeDNSServer/edgeDNSServers/g relevant ?

👍

@jkremser one last thing, could you please highlight the places in code where we actually increasing reliability with the multiple edgedns servers? https://github.com/k8gb-io/k8gb/pull/605/files#diff-b93d6284f641cd9c665d0167b418250059f2ac5438acf1fe775001c13973a368R295 here and https://github.com/k8gb-io/k8gb/pull/605/files#diff-b93d6284f641cd9c665d0167b418250059f2ac5438acf1fe775001c13973a368R313 here? anywhere else?

@jkremser one last thing, could you please highlight the places in code where we actually increasing reliability with the multiple edgedns servers? https://github.com/k8gb-io/k8gb/pull/605/files#diff-b93d6284f641cd9c665d0167b418250059f2ac5438acf1fe775001c13973a368R295 here and https://github.com/k8gb-io/k8gb/pull/605/files#diff-b93d6284f641cd9c665d0167b418250059f2ac5438acf1fe775001c13973a368R313 here? anywhere else?

also utils.Exchange(..) called here but that's part of the dnsQuery function so impl detail
utils.Dig's signature now uses the list as well. Dig is being called from tests, but also from:

gslb.go:104
gslb.go:140

and that should be it


Any plan for Chinese version doc content?

Is there any plan for Chinese version of doc site content? I'd like to contribute.

great idea, @Xunzhuo can you share what needs to be done here
@wilsonwu are you interested in picking this up ?

Thanks! But I think for now it is not the best time for it, APIs / features are not stable yet. I suggest working on it after GA.
cc @envoyproxy/gateway-maintainers WDYT?

Thanks! But I think for now it is not the best time for it, APIs / features are not stable yet. I suggest working on it after GA.
cc @envoyproxy/gateway-maintainers WDYT?

Great, please let me know if anytime we can start.

I had the privilege of reading the documentation of Envoy Gateway, and I must say it is exceptionally well-written. I am thoroughly impressed by the quality of the content and I am also interested in participating in the translation work.😄

thanks @DomineCore, contributions are always welcome. like @Xunzhuo suggests, we would like to work on that after EG going GA.

because of https://github.com/envoyproxy/gateway/issues/2979, it would be great let's focus on that first.


fix(app): Add delete icon notification for deleting credentials

https://user-images.githubusercontent.com/7862595/230235174-61f96be1-6544-4cc1-936f-d344a3102d12.mov
Signed-off-by: Talwinder kaur<EMAIL_ADDRESS>

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@f484b22). Click here to learn what that means.
 Consider uploading reports for the commit 2ffe06c to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #384   +/-   ##
=======================================
  Coverage        ?   90.12%
=======================================
  Files           ?       73
  Lines           ?     2612
  Branches        ?        0
=======================================
  Hits            ?     2354
  Misses          ?      181
  Partials        ?       77

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


[Enhancement] reduce pipeline engine driver poller thread cpu usage

Enhancement
In my product cluster, When query hive external table, some split has slow io, but cpu is never lower than 100%.
I use perf top and flame graph find out is the pipeline_driver_poller thread.
in pr use _mm_pause and sched_yield instead of sleep
_mm_pause usually use for busy wait spinning, but in this loop is check drivers status and can't save power.
I change back to use sleep get lower cpu usage, I think use sleep is better.

Thanks for feedback.
The busy polling mechanism is good at reduce latency, but with the cost of CPU cycles. Since there's only on thread working on the polling, in most cases it would not be the bottleneck.
But as you say, for some slow-io workloads, the cpu cost would be significant.
We plan to optimize it into an event-driven style. Specifically, an IO-Scheduler is responsible for the io task, and the driver execution is driven by the IO event. In this pattern, there's no need for a poller, so we don't need to worry about the cpu cost any more.

@mofeiatwork Thanks for reply.
Look forward to the event-driven feature, may I ask whats the schedule of this. We plan use container cluster and current mechanism may have a major waste of cpu.


Question about Interfaces

Thank you very much for this great library.
I've got a question about Interfaces and validation
To play nice with relay it seems easier to follow the "node / viewer" pattern.
So for example a single entry point for all characters ( the node query ) could be implemented like this
return [
            'name' => 'Query',
            'fields' => [
                'character' => [
                    'type' => $characterInterface,
                    'args' => [
                        'id' => [
                            'name' => 'id',
                            'description' => 'global id of the character',
                            'type' => Type::nonNull(Type::string())
                        ]
                    ],
                    'resolve' => function ($root, $args) {
                        return //.. get character by global id
                    }
                ]
                //...
            ]
        ];

Then we rely on the resolveType function of our character interface to return a droid or a human type.
So far so good!
But if I want to add a field that only exists for droids let say "modelNumber" I run into a validation problem, DocumentValidator fails as it only checks the fields of the interface, and not the fields of my resolved type.  Is this a bug ?

Given your description, it sounds like you do not use type-casting in GraphQL query. So for example you have CharacterInterface and specific Droid and Human types.
Then your query should look this way:
{
  character {
    name
    someOtherInterfaceField

    ... on Droid {
      modelNumber
    }

    ... on Human {
      dateOfBirth
    }
  }
}

But to say for sure I need to see your query, because DocumentValidator runs against GraphQL query document, so query is important here to debug.
Also I do use this library with Relay and haven't seen such issues, so it shouldn't be a bug.

Thanks you are quite right, I needed to read this some more.
Thanks again for a great library.


Update workflows

See https://github.com/senzing-garage/go-grpcing/issues/58

Pull requests:

https://github.com/senzing-garage/serve-grpc/pull/292


fix: move /etc/ to /usr/etc/

Fixes #428
Follow up of PR #434
This moves the current /etc/ folders to their corresponding /usr/etc folder.

All builds are failing on installing tailscale. The repository file is here usr/etc/yum.repos.d/tailscale.repo. But not is not found after moving it to the new location.
I expect the same will happen for code on the bluefin-dx with repo file located dx/usr/etc/yum.repos.d/vscode.repo

All builds are failing on installing tailscale. The repository file is here usr/etc/yum.repos.d/tailscale.repo. But not is not found after moving it to the new location.

Ah! I see! I'm sorry, I misunderstood the cause of this error when I saw all the out of sync changes on the other PR.

As we don't want to copy back stuff from /usr/etc does this mean we need to leave an etc folder exist for things like repo files? And then leave a COPY etc /etc in the Containerfile? Or is there another option.

So, yeah, basically I completely missed the relevance of the tailscale.repo  and vscode.repo files.  I'm sorry, I think I introduced confusion here.
After rereading all the discussions, I think the simplest solution, minimal changes to accomplish the goal is as follows:

Update the PR to restore  usr/etc/repos.d to etc/repos.d and dx/usr/etc/repos.d to dx/etc/repos.d as those never made it into the final image anyway, given the Containerfile was already deleting tailscale.repo and vscode.repo .
Leave all other moved files in usr/etc as they DO end up in the image
This will require restoring the Containerfile lines

COPY etc /etc

and
COPY dx/etc /etc

But it's probably clearer for the intent if they are more specific like:
COPY etc/yum.repos.d /etc/yum.repos.d

and
COPY dx/etc/yum.repos.d /etc/yum.repos.d

I hope this is clearer now. And again, sorry for causing confusion.

Adding a summary of the discord chat @bobslept and I shared.

bobslept: Same problem pops up with enabling a service that is not found on the new location.

I remembered we already have this problem solved for a service we install in config where we systemd presets.
This solution requires adding 2 new files...  probably one per service whose .service file is added via usr/etc/systemd in this repo.
And the services which would need this are fprintd.service (for framework) and  dconf-update.service (for bluefin)


Forgot to stage that file in the previous PR: https://github.com/dust…

Description
Adding a file I forgot to commit on the previous PR.
It's only removing unused variables.
PMRW @flvndvd as you have all context.

Risk

Deploy Plan

Risk

Deploy Plan

PMRW @flvndvd since you have all the context.


chore: release 1.2.21

:robot: I have created a release *beep* *boop*
1.2.21 (2021-09-21)
Bug Fixes

stapel: changes in directories of import.include/excludePaths not triggered import (f9043c3)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/werf/werf/releases/tag/v1.2.21 :sunflower:


Feature request: Add comments for articles.

Article comments would be a nice addition.

I don't think so, I don't want someone to make an improvement in comments.
The idea is, if you think you can improve on an article, don't comment on it but edit it.
If you think something is wrong in an article, don't point it out in the comments. Edit it.

It would be helpful if users have queries on the article or a tutorial is not working for them.


Add position to Entities

See how can we save the global position of Entities.

[x] Review the Entities class on FAtiMA-Server
[x] Align the data between both modules
[x] Review the beliefs generated
[x] Update the agent to use this information

Done


Summer Celliera build

This build improves S!Celliera's personal DPS as well as her team buffs output over the current build by focusing on using her S2 and Patia shared skill as often as possible:
- Dragon: Gaibhne & Creidhne
- Print 1: Valiant Crown
- Print 2: Proper Maintenence
- Skill 3: Patia
- Skill 4: S!Luca
- Coabilities: S!Estelle, Renee, H!Sarisse
- ACL:
`dragon.act('c3 s end')
`s2
`s3
`s4,fsc
`s1,fsc
`fs, x=2

DPS (current DPS // old DPS):
-      0 Team DPS: 25825 // 24942
- 15,000 Team DPS: 34040 // 29856
- 30,000 Team DPS: 42255 // 34769

dc3805fdba21c37c3c9295fd0d8343aec331975b


plug.vim not autoloading in ~/.config/nvim/autoload

I'm not sure if I'm placing this in the right directory, as the installation instructions assume vim but neovim recently switched to having the config files in ~/.config/nvim/ so I assumed that ~/.config/nvim/autoload would be the analogous place to put plug.vim. Alas, it doesn't seem so.

What is correct location? I have a same issue.

My mistake was simply not closing the quotes around the plug path. The line currently looks like:
call plug#begin('~/.config/nvim/plugged')

@Arelav Hmmm, maybe we'll have to rethink front page documentation now that neovim and windows there. I thought it was fairly clear you'd have to change the begin call.

@starcraftman The issue was when ~/.config/nvim/autoload/plug.vim is simlink to ~/.config/nvim/plugged/plug.vim
If i install plug.vim directly into autoload - it's work (In other case i haven't Plug option). But i not really happy, because i can't auto update plug with plug.

@Arelav I'd advise against that symlinking setup. Vim-plug works best from autoload, we provide PlugUpgrade to do an upgrade. One of the advantages of separate upgrade system is regardless how we might break an installer method (say nvim or python) the upgrade always works.
If you really must upgrade and update at once you can use a command alias to something like PlugUpdate | PlugUpgrade or if scripting you can use vim +PlugUpdate +PlugUpgrade +qa.

My solution is to symlink .config/nvim/ to ~/.vim/  and include a symlink within the same directory from init.vim to vimrc

Thanx

Thanx


⚠ Samsung has degraded performance

In 0dcbb9a, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2135 ms

Resolved: Samsung performance has improved in e3c657b.


[CIVP-11787] ENH ContainerFuture class to track container scripts

Add a ContainerFuture object which knows how to query container scripts, how to cancel container scripts, and how to retry container scripts. The civis.ml.ModelFuture can be a subclass of the ContainerFuture; models are a specialized container script.
This functionality (especially retries) adds more tooling for running concurrent jobs on the Civis Platform, and is a setup for executor classes coming in the next PR.

This is cool.  I like the abstraction CivisFuture -> ContainerFuture -> ModelFuture.  There is a lot more code that is going to move here, is the idea to keep ContainerFuture in futures.py and then add a module (like parallel) for the rest of that code?

I was planning to put the executor code in civis.futures; that seems the most appropriate namespace for it. I wasn't sure what the best place would be for the joblib-backend code. Suggestions welcome.

I was planning to put the executor code in civis.futures

That is a good plan.  I'm worried that it might get a little unwieldily to put everything in single file; we could always create a futures module with files beneath it and import what we need with futures.__init__.  But let's hold off on that for now.


reducing nbclean dependencies

In a circleCI with their python:3.7 image I ended up with ipython v7 and an old version of prompt_toolkit. I haven't yet tracked down what is causing the conflict, limiting myself to ipython 6 seems to do the trick for now.
This made me look at the dependencies that were being installed. Which made me wonder: does nbclean need to depend on numpy and tqdm and nbgrader?
TL;DR: can we work on reducing the dependencies of nbclean to a very small number of libraries that are very actively maintained?

I'm all for it - the heaviest dependency is definitely nbgrader, which has the logic for replacing text etc (and is the reason nbclean uses traitlets syntax which I'm not a huge fan of TBH). I do agree this could probably be reduced and would make the package more lightweight/maintainable

Let's see if we can extract/make our own version of the text replacement.

PRs are welcome ;-)


Travis: -> new architecture; - short mode; + race detector

If sudo is not needed, Travis will run the builds in a faster containerized architecture.
Removed "-short", added "-race". Wall time loss seems reasonable.

There seems to be a test in client_test.go that depends on a wall time race.


[Event Request] Codeunit 7380 "Phys. Invt. Count.-Management"  – OnBeforeCalcInvtQtyOnHand

[Event Request] Codeunit 7380 "Phys. Invt. Count.-Management"  – OnBeforeCalcInvtQtyOnHand
Could we please have a Supplement (var ItemJournalLine) in publisher OnBeforeCalcInvtQtyOnHand in Codeunit 7380 "Phys. Invt. Count.-Management"?
    // >>>>>>>>
    [IntegrationEvent(false, false)]
    local procedure OnBeforeCalcInvtQtyOnHand(DocNo: Code[20]; PostingDate: Date; ZeroQty: Boolean; var TempPhysInvtItemSelection: Record "Phys. Invt. Item Selection" temporary; var ItemJournalLine: Record "Item Journal Line"; var IsHandled: Boolean)
    begin
    end;
    // <<<<<<<<

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


Update opsworks.py

Adding the AutoScaling prop to Opsworks Instance - http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-opsworks-instance.html

This was already added in #255. Thanks though for submitting it.


Building with a different configuration removes the analysis data

Description of the bug:
When we first sync the project everything is highlighted and resolved correctly. Once we build using run/debug/test configuration all the data is lost and we would have to resync. If we keep on building using the same configuration the sync data is kept but if we switch say from run to debug we would have to resync!
Which category does this issue belong to?
No response
What's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.
1- Create a Bazel Go project.
2- Sync
3- bazel run ...
4- Sync
5- bazel debug ...
6- Sync
Which Intellij IDE are you using? Please provide the specific version.
Goland 2024.13688.19
What programming languages and tools are you using? Please provide specific versions.

Latest build from master branch
Have you found anything relevant by searching the web?
No
Any other information, logs, or outputs that you want to share?
No response

We mitigated this problem by passing the --remote_download_all flag although we think that it would impact caching and overall build time. What do you think?


Xcode Cloud SPM Error

Target 'VCoreMacrosImplementation' must be enabled before it can be used.

Hey. VComponents uses Swift macros, so they have to be enabled each time a new version is checked out.
I can't comment on XCode cloud, as I don't use it. But, this issue is not tied to VComponents in particular. There seem to be resolutions, though. Check out the following threads.
https://stackoverflow.com/q/77267883/11627169
https://forums.developer.apple.com/forums/thread/739347

Hey. VComponents uses Swift macros, so they have to be enabled each time a new version is checked out.
I can't comment on XCode cloud, as I don't use it. But, this issue is not tied to VComponents in particular. There seem to be resolutions, though. Check out the following threads.
https://stackoverflow.com/q/77267883/11627169 https://forums.developer.apple.com/forums/thread/739347

Thanks


[Suggestion] Add a "View Output" button in the notification after creating a resource group

OS: Windows 10
Build Version: 20200728.1
Repro Steps:

Create a resource group in VS Code.
Check the notification.

Actual:
There is no "View Output" button in the notification.

Suggestion:
Add a "View Output" button in the notification.

We only direct users to the output window when there's additional helpful info that doesn't fit well in a notification. For this scenario, a notification tells you all you need to know


Remove Adam PhD student profile

Removing my profile from graduate students. Can move to another section of website if you'd like, or leave off. Let me know!

Adam, we could instead add you to 'Alumni' group if you'd like that -- you could then edit the .md file with whatever info you want, and change within that:
"""
user_groups:

Alumni
"""
Let me know, otherwise I'm happy to merge this pull request

Thanks, have changed tag to alumni. Let me know if any changes needed before merge.


Editor losses focus with dropdown

When you have a button in the toolbar with a dropdown (for example to add a link) the editor loses focus meaning that the selection is lost and certain commands won't work.
See http://dev.madreloca.com/editortest.html and try to add a link to see the issue.

@SMLDuarte thanks for posting about this. I'll take a look at it tonight and see if I can figure out what is causing the issue for you. I'm able to replicate it on your site but not on anything else.

@SMLDuarte I was able to replicate this on one of our example files. I'd say that this is a regression because it was only introduced in the last merge or two that we've done.

@RandomlyKnighted I just noticed that the version of the editor that I'm using, and the one that it's available on Microsoft Nuget (I'm using this in an ASP.NET MVC project), is a fork maintained by someone else, so I'm not sure how up to date it is.
I tried using your latest release but It made the editor stop working (when you start typing it automatically adds a  tag to the editor and every key press ads a  inside the blockquote instead of the text that is being typed).

@SMLDuarte can you provide a link to the Nuget package you were using?
That's strange. I haven't ran into that problem.

Sorry for the delay.
Here is the link to the Nuget package:
https://www.nuget.org/packages/Bootstrap.Wysiwyg
And this is the github fork of the package:
https://github.com/drc-devs/bootstrap-wysiwyg

That repo looks like a modified version of the 1.0.3-beta release.

Ok, so I just did some testing to determine at what point the hyperlink button was broken. Below are my results:

Version
Test Results

1.0.4
Regressed

1.0.3-rc
OK

1.0.3-beta
OK

1.0.2
OK

So I did a file comparison between versions 1.0.4 and 1.0.3-rc. You can find that comparison here
Really the only thing that was changed between the two version was that underscoreThrottle was updated and then called each time for the execCommand function. This was done to fix the issue mentioned in #58.
I should mention that during my tests I also tested the effects on this issue and the problem mentioned in #58 with the underscoreThrottle function removed. After removing the function I found that both issues worked like they should. The main reason for having this function is to prevent users from clicking the button too much. I can see the use of this function in a form scenario say on a form submit button but for a WYSIWYG editor I'm not quite sure that it's worth keeping.
However, I'd like to get @steveathon's opinion before we remove the function from the project.


2 display images inline in hipchat

#2 This diff displays attachments as <img> tags in Hipchat if they have a content type of image.

Closing without merging (as that would make the test redundant for anyone else ;-))


Latest update 2.2.1 preventing Homebridge from starting

I upgraded to 2.2.1 a few days ago and when I reboot Homebridge I am getting the below errors. If I remove my configured accessory (streaming stick) and restart, the error goes away. If I add the accessory and restart, issue returns.
[8/7/2023, 8:38:35 AM] Homebridge v1.6.1 (HAP v0.11.1) (Homebridge) is running on port 51360.
[8/7/2023, 8:38:35 AM] Bedroom Fire TV XXX is running on port 41279.
[8/7/2023, 8:38:35 AM] Please add [Bedroom Fire TV XXX] manually in Home app. Setup Code: XXX
[8/7/2023, 8:38:35 AM] TypeError: The argument 'file' cannot be empty. Received ''
    at new NodeError (node:internal/errors:405:5)
    at normalizeSpawnArguments (node:child_process:549:11)
    at spawn (node:child_process:750:13)
    at execFile (node:child_process:348:17)
    at tryCatcher (/var/lib/homebridge/node_modules/homebridge-adb/node_modules/bluebird/js/release/util.js:16:23)
    at ret (eval at makeNodePromisifiedEval (/var/lib/homebridge/node_modules/homebridge-adb/node_modules/bluebird/js/release/promisify.js:184:12), <anonymous>:13:39)
    at Connection._exec (/var/lib/homebridge/node_modules/homebridge-adb/node_modules/@devicefarmer/adbkit/src/adb/connection.ts:104:16)
    at Connection.startServer (/var/lib/homebridge/node_modules/homebridge-adb/node_modules/@devicefarmer/adbkit/src/adb/connection.ts:93:17)
    at /var/lib/homebridge/node_modules/homebridge-adb/node_modules/@devicefarmer/adbkit/src/adb/connection.ts:45:23
    at tryCatcher (/var/lib/homebridge/node_modules/homebridge-adb/node_modules/bluebird/js/release/util.js:16:23)
    at Promise._settlePromiseFromHandler (/var/lib/homebridge/node_modules/homebridge-adb/node_modules/bluebird/js/release/promise.js:547:31)
    at Promise._settlePromise (/var/lib/homebridge/node_modules/homebridge-adb/node_modules/bluebird/js/release/promise.js:604:18)
    at Promise._settlePromise0 (/var/lib/homebridge/node_modules/homebridge-adb/node_modules/bluebird/js/release/promise.js:649:10)
    at Promise._settlePromises (/var/lib/homebridge/node_modules/homebridge-adb/node_modules/bluebird/js/release/promise.js:725:18)
    at _drainQueueStep (/var/lib/homebridge/node_modules/homebridge-adb/node_modules/bluebird/js/release/async.js:93:12)
    at _drainQueue (/var/lib/homebridge/node_modules/homebridge-adb/node_modules/bluebird/js/release/async.js:86:9)

Thank you for the report, it looks like the new stack is causing some error. In the meantime please use previous working version while I'm working the bug fix.

Just curious on a possible fix in a 2.2.3?
2.2.2 prevents Homebridge from starting on my setup as well.

FYI - I'm still seeing issues on v2.2.5. Had to disable the plugin to prevent Homebridge from restarting every few minutes.

FYI - I'm still seeing issues on v2.2.5. Had to disable the plugin to prevent Homebridge from restarting every few minutes.

What’s the error output right now?

[9/25/2023, 1:06:18 PM] Error: write EPIPE
    at afterWriteDispatched (node:internal/stream_base_commons:160:15)
    at writeGeneric (node:internal/stream_base_commons:151:3)
    at Socket._writeGeneric (node:net:962:11)
    at Socket._write (node:net:974:8)
    at writeOrBuffer (node:internal/streams/writable:392:12)
    at _write (node:internal/streams/writable:333:10)
    at Socket.Writable.write (node:internal/streams/writable:337:10)
    at /var/lib/homebridge/node_modules/homebridge-adb/node_modules/nodejs-adb-wrapper/index.js:230:36
    at new Promise (<anonymous>)
    at _connect (/var/lib/homebridge/node_modules/homebridge-adb/node_modules/nodejs-adb-wrapper/index.js:180:20)

any news on this?


Middle button panning

Thank you for creating and maintaining this extremely useful plugin.
Pretty much an extension of #22. Is there a particular reason to limit the panning behavior as left-button based opposed to middle-button as in Pcbnew?
I think it would make sense to support both: left-button for touch screen devices, and middle-button for those still using their mouse. With muscle memory I find myself trying to use the middle-button to pan as I would in Pcbnew and Eeshema.
Mozilla docs for MouseEvent.button show that it's as simple as allowing 0 and 2 to pass.

Is there a particular reason to limit the panning behavior as left-button based opposed to middle-button as in Pcbnew?

No reason other than the pcbnew behavior being the non-standard one and most people having muscle memory to pan using left mouse. But it doesn't hurt to duplicate the function with middle button.


docs(README): add about operation checks and guarantees

Description

Add information about operation checks and guarantees.

Related Issue

Motivation and Context

We test only on Windows. I would like to state it clearly.
How Has This Been Tested?

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

I fixed it.


can`t org-export-html

hi @abougouffa
after my test  minemacs can`t org export html
i have create a simple file  test.org  then  press   SPC m e h h

i have read FAQ and add code in config.el
(with-eval-after-load 'org
  (setq org-export-in-background nil))

(with-eval-after-load 'org
  ;; You can also set it to your own custom init.el, just do not forget to
  ;; provide `me-org-export-async-init' in it.
  (setq org-export-async-init-file nil))

still not work
Looks a bit complicated from my beginner's perspective, maybe it needs to be simplified

I've just tested it with the README.org file of this repository, in my machine the export runs OK (with org-html-export-to-html or org-html-export-as-html).
After adding this to your config.el, can you tell me what error Emacs is signaling?
(with-eval-after-load 'org
  (setq org-export-in-background nil
        ;; You can also set it to your own custom init.el, just do not forget to
        ;; provide `me-org-export-async-init' in it.
        org-export-async-init-file nil))

My son is sick, so may have to take the test again later
When I test it, I will updating this issues

hi @abougouffa  i have test it again
try to export README.org
work well
but it take 10s   is this normal？

It depends on the machine and the file, but for an export to HTML it should be quite fast.

ok I will continue to pay attention to this


NEW: abstract base class for views

added abstract base class SliceRecordABC, for recording the history of operations to be applied to some underlying data. Modified SeqView to inherit from SliceRecordABC

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

82 of 82 (100.0%)  changed or added relevant lines in 1 file are covered.
4 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.009%) to 91.906%

Files with Coverage Reduction
New Missed Lines
%

src/cogent3/core/alignment.py
1
93.76%

src/cogent3/maths/scipy_optimize.py
3
84.92%

Totals

Change from base Build<PHONE_NUMBER>:
-0.009%

Covered Lines:
30262

Relevant Lines:
32927

💛  - Coveralls

fyi codacy is yelling at def __getitem__(self, segment: Union[int, slice], kwargs: dict): for having two params


SHA256 mismatch on iperf

brew config output
HOMEBREW_VERSION: 3.2.10-64-gfd46a17
ORIGIN: https://github.com/Homebrew/brew
HEAD: fd46a173fef7a60bd7da5032f2fcde3c0ea0d1c2
Last commit: 12 hours ago
Core tap ORIGIN: https://github.com/Homebrew/homebrew-core
Core tap HEAD: ecfae5eb54cb62ab920f7b65df2b4472d2cf3237
Core tap last commit: 36 minutes ago
Core tap branch: master
HOMEBREW_PREFIX: /usr/local
HOMEBREW_CASK_OPTS: []
HOMEBREW_GITHUB_API_TOKEN: set
HOMEBREW_MAKE_JOBS: 4
Homebrew Ruby: 2.6.3 => /usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.6.3_2/bin/ruby
CPU: quad-core 64-bit kabylake
Clang: 11.0.0 build 1100
Git: 2.20.1 => /usr/local/bin/git
Curl: 7.54.0 => /usr/bin/curl
macOS: 10.14.6-x86_64
CLT: <IP_ADDRESS>.1.1562985497
Xcode: 11.3.1

brew doctor output
Please note that these warnings are just used to help the Homebrew maintainers
with debugging if you file an issue. If everything you use Homebrew for is
working fine: please don't worry or file an issue; just ignore this. Thanks!

Warning: A newer Command Line Tools release is available.
Update them from Software Update in System Preferences or run:
  softwareupdate --all --install --force

If that doesn't show you any updates, run:
  sudo rm -rf /Library/Developer/CommandLineTools
  sudo xcode-select --install

Alternatively, manually download them from:
  https://developer.apple.com/download/more/.
You should download the Command Line Tools for Xcode 11.3.1.

[X] I ran brew update and am still able to reproduce my issue.
[X] I have resolved all warnings from brew doctor and that did not fix my problem.

What were you trying to do (and why)?
I tried to install iperf in an OS for which a bottle is not available.
To discard the computer as the issue, I tried on another (the one the output above is from) that has an OS version supported by Homebrew,  from source as to forgo the available bottle.
What happened (include all command output)?
Run brew install --build-from-source iperf and got this:
==> Downloading https://downloads.sourceforge.net/project/iperf2/iperf-2.1.4.tar.gz
==> Downloading from https://nav.dl.sourceforge.net/project/iperf2/iperf-2.1.4.tar.gz
######################################################################## 100.0%
Error: iperf: SHA256 mismatch
Expected: f07a0f343c60f6d07f18fa22d3501f8ca8fcb64d20b96e6a74739af444f66d5c
  Actual: 062b392e87b8e227aca74fef0a99b04fe0382d4518957041b508a56885b4d4f9
    File: /Users/jorge/Library/Caches/Homebrew/downloads/d6e949bfd068a948eaadf3bb0b4ea3e9ea61a9197c6352f417a0fc6ace2159da--iperf-2.1.4.tar.gz
To retry an incomplete download, remove the file above.

What did you expect to happen?
iperf should install.
I have no idea wether the iperf repo got hacked.
Step-by-step reproduction instructions (by running brew commands)
1. Run `brew install --build-from-source iperf`
2. Upon getting the error above, Run `rm ~/Library/Caches/Homebrew/downloads/d6e949bfd068a948eaadf3bb0b4ea3e9ea61a9197c6352f417a0fc6ace2159da--iperf-2.1.4.tar.gz`
3. Run `brew cleanup -s && brew update`
4. Run again `brew install --build-from-source iperf`

I have merged the checksum update PR, and it should be good to close now.


Free SELinux labels when the labels are not being used

Currently when lots of containers are created as disabled, each
container will leak and MCS Label.  Eventually the system will run out
of labels and go into an infinate loop looking for labels.
Signed-off-by: Daniel J Walsh<EMAIL_ADDRESS>
- What I did
- How I did it
- How to verify it
- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@jwhonce PTAL.  Any concerns changing the vendored runc like this?  I thought you had run into an issue doing this once versus projectatomic/runc....

LGTM

Any concerns changing the vendored runc like this? I thought you had run into an issue doing this once versus projectatomic/runc....

We're doing it for quite some time already so...


Comet and AD error

I've configured All Debrid to work with Comet, but I'm getting the following error on any links "Empty Result format configuration" and it gives no details of the link. I've tried creating a new API and reinstalling Comet but still getting that? The links do work however?

Could have been installing an old version. I reinstalled again from the Stremio addons site and seems to be fine now.

As above


Check that array has daily frequency

Using infer_freq from pandas.
Does not support non-standard calendars. I suggest we add that to the list of xarray improvements to develop.

Pull Request Test Coverage Report for Build 115

12 of 15 (80.0%)  changed or added relevant lines in 2 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+2.2%) to 58.642%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

xclim/checks.py
10
13
76.92%

Files with Coverage Reduction
New Missed Lines
%

xclim/checks.py
1
69.84%

Totals

Change from base Build 113:
2.2%

Covered Lines:
190

Relevant Lines:
324

💛  - Coveralls

@huard can this branch be closed or are you still working on it?

Can be closed, we'll complete later.
On Tue, Oct 2, 2018 at 1:00 PM Trevor James Smith<EMAIL_ADDRESS>wrote:

@huard https://github.com/huard can this branch be closed or are you
still working on it?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Ouranosinc/xclim/pull/46#issuecomment-426351027, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAE9Q7DK3QTtdzJGLGBIioRIZumafnyPks5ug5twgaJpZM4XDFzM
.


No Module Service

I was able to deploy the function successfully to AWS, but when I test it in AWS, it throws an error saying the module service doesn't exist.

Or at least throw an error saying there's a mismatch :P


Hide publications

How to hide with api, user publications and stories?

Could you elaborate on what 'hiding' does. This term isn't really used.
There's the deletion of media (posts, stories) and the archiving of them.

When i dont want to watch stories of user, i can tap on story of this user and click hide publications

This isn't yet supported. You can open a PR and add it.

@Nerixyz  means muting someones stories. How about hiding your stories from a person through API ?

@Nerixyz  means muting someones stories. How about hiding your stories from a person through API ?


SCP wrapper doesn't check for the "BASTION_CONF_FILE" env var

Hi,
I just saw that scpwrapper.py doesn't check the presence of the bastion vars via a config file that path would be overridden by that BASTION_CONF_FILE like sshwrapper.py does. That means the SCP wrapper doesn't support that way of configuring the wrapper.
The code ranges to copy are line 18, and line 42 to line 50 from sshwrapper.py

Also, the use of BASTION_CONF_FILE is not mentioned here

Thank you for this report. It's now fixed.


Add rolling deployments of Auto Scaling groups

CloudFormation provides the UpdatePolicy Attribute to specify how AWS CloudFormation handles rolling updates for a particular resource, see Announcing New AWS CloudFormation Deployment Enhancements:

[...] These update policies describe how instances in the Auto Scaling group are replaced or modified as part of a stack update operation. Update policies give you control over the number of instances that can be modified concurrently, the number of instances that should remain in service, and the wait time between instances to be updated. With rolling deployments, you reduce downtime when updating your application.

:information_source: That's likely a low priority long term improvement to be added once Auto Scaling is running smoothly otherwise, but might be useful earlier in the context of semi-automatically scaling the Elasticsearch nodes eventually.

Closed as Won't Fix due to project being retired to the CityIndex Attic.


Expose Idea pretty-printing functions (showEX/showANSI)

If you use hlint as a library the main entry point is hlint function. However, you're in trouble if you want to react to the resulting Ideas somehow. In our use-case, we want to only print the hints for lines touched in the current working git diff.
So far we've been parsing the --json output and filtering that against some ranges. Trying to use the library, means that either:

hlint prints everything (we don't want this)
hlint prints nothing with --quiet but you have to pretty out the resulting hints

If you just use show, it uses the show = showEx id instance which means all the colouring is lost. I suppose showANSI or even showEX functions would be nice to have so that not much of code has to be copy-pasted.

Thanks for the diff - I'll reply to it here. I think exposing showANSI is fine, modulo two concerns:

It doesn't have the word Idea in its name, and it doesn't show any type of thing as ANSI. I renamed it showIdeaANSI.
The current version is in IO so it can read the hscolour preferences file. While I'm OK with HLint doing that, I don't want to expose an API where it queries the existence of a weird file no one expects. I wrote an alternative that uses default preferences.

Does that still answer all your requests?

It doesn't have the word Idea in its name, and it doesn't show any type of thing as ANSI. I renamed it showIdeaANSI.

Cool. Personally I think a better solution would be to make the module with Idea exposed (maybe marked with .Internal) and then we don't have to worry about naming. Users can import qualified if they'd like. This would also help with the following discussion:

The current version is in IO so it can read the hscolour preferences file. While I'm OK with HLint doing that, I don't want to expose an API where it queries the existence of a weird file no one expects. I wrote an alternative that uses default preferences.

The reason why I wanted showEx initially but then just showANSI was so I could do whatever HLint binary does: after all, that was my goal except I also wanted it to filter a few of the ideas out. Now that only hsColourConsolePure variant is used puts us back to where we were: we can't render in same way that hlint would do. We can't recover the behaviour either because showEx is still private.
So the situation is better (and indeed for us where we don't have .hscolour file: it works) but in attempt to not expose some API, it became impossible to mimic the binary.
So ideally either:

expose showEx from the Idea module: this allows to re-implement either variant of showANSI

or

expose both showANSI and showIdeaANSI perhaps after some renaming. showANSI is currently hlint internal so rename shouldn't matter.

Having said that, these are only minor complaints because showIdeaANSI happens to work for us. It's a shame that a lot of the code is outright inaccessible behind private modules however. showANSI was one example, some other was code that processed SrcLocs into line numbers and so on. Non-polished API would probably have been much better than no API at all.
Feel free to do nothing about this issue though I'd love if more parts of the code were exposed even if they don't seem like perfect API.

I realise there is a Haskell movement to expose the internals with .Internal. I don't like it, and find it encourages bad practices, broken abstractions and means that people working around your API which means you lack the feedback to fix your API. While others may choose to follow this approach, I don't. If there are specific things you would find useful to be in the API, let me know - usually I'm happy to expose things.
What do you want to do that mimics the HLint binary so precisely? If you really want to be just like HLint, why not just use HLint? But if you've got freedom to be different, I'd take it - if I was writing HLint today I don't think I'd rely on hscolour at all - printing out source code with syntax highlighting isn't what most other linters and compilers do. I doubt any HLint users know about .hscolour files, where to put them, or what their syntax is. I suspect when people do get involved in these files, its to be upset that suddenly a random file appears and HLint breaks. I wish I'd reserved color for the semantically meaningful parts of the message - like the word error/warning/suggestion, just like GHC and Rust do.

find it encourages bad practices, broken abstractions and means that people working around your API which means you lack the feedback to fix your API

I agree in principal. In practice though, I think the opposite just encourages copy+pasting of code from inside the library which is probably even worse.

What do you want to do that mimics the HLint binary so precisely? If you really want to be just like HLint, why not just use HLint?

I want to do exactly what hlint does down to how it renders the output except that I want to filter out which hints it shows. In our codebase we only show hints for lines of code that were touched in the current branch to avoid the hundreds unfixed lints in rest of codebase. To do this, I have to filter out some of the Ideas and I can't do that with the binary (unless I parse stdout) so I need to use the library. When I tried to use the library, I stopped being able to get the same looking output as I got with binary.

I doubt any HLint users know about .hscolour files,

Neither did I.

printing out source code with syntax highlighting isn't what most other linters and compilers do

FWIW I like it. It's your tool though so you can do whatever you want with it of course, I'm not trying to put pressure on any features.

Cool - filtering out unchanged lines does seem like a valid application for writing your own "a lot like HLint but not quite" program. I wouldn't say there are many, but that is one!
I don't want to expose the colour preference thing, because I don't really think its a very good. I've just pushed a change so that we always use the showIdeaANSI function internally in HLint, which means you can mirror HLint.
For a long time I've wanted to rewrite the HLint binary using only the HLint API, since that seems the right thing to do. Unfortunately, I've never had time. HLint was a program that became an API later, so it has a weird history.


Suggestion for improvement

Add the ability to use Tabs (Nav Pills) in a modal window.
I use xCrud, there is a very simple but at the same time functionality of simple field separation.
Real example:
https://xcrud.net/demos/index.php?page=tabs&theme=bootstrap4
You can also implement something like:
->set_fields('customer_name, customer_lastname, etc', phrase(‘My profile’));
->set_fields('num_orders, total, etc', phrase(‘My orders’));
->set_fields('customer_address, customer_credid, etc', phrase(‘Billing info’));

I think it's a very good idea.
Improve multi language support
To add 1 blog post in 6 languages, you need to make 6 different posts with the same link. I think this is a very wrong decision.
I will give an example of the optimal implementation of multi-language support based on a blog:

add 2 tables blogs__translation and blogs__categories_translation

add rows to the blogs_translation table
trans_id
trans_title
trans_excerpt
trans_content
trans_lang
trans_post_id

add rows to blogs__categories_translation table
trans_id
trans_title
trans_descriptions
trans_lang
trans_cat_id

In the main site settings, the administrator specifies the main language of the system, for example, English.

Remove language dropdown when adding a post. Instead, get an array of available languages (/administrative/translations) excluding the main language of the site and display them on the screen.

Example

For more comfortable adding/editing, you can put translations in Tabs (from the first suggestion for improvement), it will be convenient if there are many languages :-)
When saving a post, save the translation fields directly to the blogs_translation database.
Example when saving a blog entry

| trans_id | trans_title | trans_excerpt | trans_content | trans_lang | trans_post_id |
|    1     |   En-tête   |     Entrée    |     Texte     |     FR     |     120       |
|    2     |   Judul     |    Ringkasan  |     Konten    |     ID     |     120       |
|    3     |   Titolo    |    Estratto   |   Contenuto   |     IT     |     120       |
|    4     |   En-tête   |     Entrée    |     Texte     |     FR     |     125       |

Example when saving blog category
| trans_id | trans_title | trans_descriptions |  trans_lang | trans_cat_id |
|    1     |   En-tête   |        Entrée      |     FR      |      5       |
|    2     |    Titolo   |      Descrizione   |     IT      |      5       |
|    3     |    Judul    |      Keterangan    |     ID      |      5       |

When a user opens a site for the first time, give it the default system language. If the user changes the language, just before displaying the content, pass it through a function, for example, get_translate('blogs', 'title', $current_lang), if there is no required translation, then show the text in the original language.

This solution is very simple. You need to use this approach to multi-language support everywhere (pages, blogs, testimonials ....). Thanks to this, it will be more convenient to edit the record in one place and there is no need to add a bunch of records, which will eventually lead to confusion with a large number of records.
Do not upload unused scripts to the frontend
You can separate the loading of scripts that are used in the backend and frontend parts of the site. There are too many scripts and styles loaded in the front end that are not actually used by the average visitor.

They can be divided. There is one download for the backend, and another download for the frontend (for example, only bootstrap, jquery and other styles and scripts that are actually used for the frontend)
It's the same with translations. The translation of all strings from json files (including the backend) is loaded into the frontend. Maybe when translating text in /administrative/translations/translate, it is worth making marks where the translation will be used (for example, backend, frontend or backend/frontend). And when generating JS, give the desired translation for the frontend or backend.
Also, as I understand it, js and css are created dynamically every time the page is updated. It may be worthwhile to physically save the files to a folder so as not to load the server.
Thanks to such little things, you can very well increase the speed of Aksara.
Groups and privileges
Add the ability to choose to show dashboard and sidebar widgets. For example, I allow my editor to add blog entries in the group, but he actually does not have a menu that is initially there (CMS-> Blogs-> Posts). In this case, you must manually create a menu for the group.
It would be great if all the menus that come by default in Aksara, you could choose which group they can be shown (and not just the super administrator).
The same applies to widgets on the main dashboard. For example, so that you can separately give privileges to a group, which, for example, will have access to the visit statistics widget (or Most used browser, Application information etc)
In general, these are my suggestions for improvement. I would also like to use the standard Codeigniter style coding.
Thanks

Very great, Jane. I hope I can implements it 😄
I still waiting for contributor to do PR to this repository.
These are the notes I summarized:

Ability to add the form tabs (grouped form);
Improve the multilanguage support: I avoid to make the database table for the translation needs in order to make it simple. I've noted down for future  changes about this case. I would make the post or category are stored in one table and mark the post type with flag e.g: blog, page, announcement etc. Since we have complex form for the post, the tabs (point 1) might be great to handle the translation than showing the fields of available language in same form;
About unused script in unmandatory pages: I know it's kinda overkill to load unused script under the page that's not require it, but back to the mission: I let users to do  something they need in every page they build without concern about the "core" support. So the script related to the form, validation, AJAX and event trigger function are loaded by default. The goal is both frontend and backend can using same script and same translation.
Group privileges (menu & widget visibility), that's kinda cool. I'll do research if it can be implemented.
Coding standard, if you could contribute to making the changes, let's make it standard. Since I use the notepad++ to write the code, there's no hint about the standard mistake.

Thank you for your suggestion and let's make it better and better.


Add a non-positive semiring

@dorchard I've added in an "OOZ" semiring that has two elements, with 1 + 1 = 0 (useful for studying non-positivity).
Note: I haven't added definitions for e.g., symGradeLess, as you shouldn't be able to do this comparison (no ordering). Are there any cases this could fall through?

Cool!


change reference for git diff last commit to unmodified instead of co…

…mmit
it makes more sense to reference the last commit as unmodified insted of commit in this case.
Sorry, I didn't see it earlier.

But if we go this way we can optimize our way back to 3 levels. Why do we need the 4 levels again then?

Because git reset --hard <hash> needs two different levels of commited changes.

Will things become simpler if we don't mention git reset --hard <hash>? It's anyway a pretty dangerous command.

I was honestly pretty surprised on monday that you had included it without telling that you should never ever use this command unless you are absolutely sure what you are doing and that it is what you want to do ;-).
In principle you could go back to the three level system when leaving out git reset --hard.

It's just to avoid confusion during time travel ;-)

You would go back to the future SCNR ;-)

I need to think about it a bit but be sure that your PR won't get forgotten. I just need to meditate over it in a quiet moment that I currently don't have.

Thanks and sorry for late follow-up!


What is the size of ShapeNet55 here?

I am downloading the dataset ShapeNet55 from the link in ULIP readme file.
But one hour passes the dataset is still downloading. And I found that there is already over 150 GB now!
Can anyone tell me the total size of this dataset? If it is too big for my disk I will have to stop the downloading earlier.

Oh, I found the answer:
[140.9 GiB/  1.1 TiB]  12% Done  38.5 MiB/s ETA 07:15:35
It is over 1 TiB ! It is too big for my workstation. I stopped the downloading.

Hi @Jingnan-Jia , if it helps, you can refer to here https://github.com/salesforce/ULIP/issues/7#issue-1618575476.
the current version contains some more types of images, maybe you can try to use regex for RGB images and depth maps only when downloading, and I will try to upload a new version that only contains images of RGB and depth maps, which should reduce some storage.

@Jingnan-Jia , I've uploaded a "only_rgb_depth_images" folder, which is around 420GB, it contains all the images I used for the pre-training, which is much smaller than the previous full image folder.


Enum.FromInteger not working on enum variables

Describe the bug
Enum.FromInteger is not available for enum variables.
To Reproduce
Working:
MyEnumVar := Enum::"My Enum Object Name".FromInteger(5);
Not working:
MyEnumVar := MyEnumVar.FromInteger(5);
Compiler error message:

Member 'FromInteger(Integer)' cannot be accessed with an instance reference; qualify it with 'EnumType' insteadAL(AL0311)

Expected behavior
MyEnum := MyEnumVar.FromInteger(5); should be accepted. It is even used as an example in the documentation:
https://docs.microsoft.com/en-us/dynamics365/business-central/dev-itpro/developer/methods-auto/enum/enum-frominteger-method#example
Versions:

AL Language: 5.0.288712

Hi @NKarolak, can you provide a small project reproducing the issue? Is this not working at compile time, when publishing or at runtime?
I could not reproduce it on the extension version you mentioned.

For reference, this looks similar to #5811

You have reproduced the "working" example, but omitted the "not working" example.
Just add the following line to your project, and the compiler will raise an error that it does not recognize FromInteger:
MyEnumVar := MyEnumVar.FromInteger(0);

FromInteger is a static method on the enum type, not a member method. The non-working case is by design.

Fix the docs then? Or make (appropriate) static methods available on instances, as they are in many other languages.

I'll transfer it to the doc repository. In many languages, static methods are not available on instances. We have chosen this model and we do not plan to change it.

This should have been closed when it was fixed in the docs repo, as it is still by design but the docs should have been clarified.


attributes check for values that can be replaced

As Jaromir indicated, maybe not all common-content attrs need to be reported as errors.
However, for the first test run, I'd flag everything to see all the data so that we can fine tune the list of attrs to be subject of this test.
Thanks!


Query failing with "negative substring length not allowed"

If limit: 1 then it fails, if some greater number then it executes OK.
In this example even limit: 2 executes OK.
# Matches all spends from AnyHedge v0.11 contract template
# https://gitlab.com/GeneralProtocols/anyhedge/contracts/-/blob/development/contracts/v0.11/bytecode.asm
query {
  input(
    limit: 1
    offset: 0
    where: {
      transaction: {
        block_inclusions: {
          block: {
            height: { _gte: 780000, _lt: 780100 }
            accepted_by: { node: { name: { _eq: "bchn-mainnet" } } }
          }
        }
      }
      _or: [
        { unlocking_bytecode_pattern: { _eq: "40104010514d" } }
        { unlocking_bytecode_pattern: { _eq: "4141004d" } }
      ]
      redeem_bytecode_pattern: {
        _regex: "04040[2-4]0[2-4]0[2-8]0[2-8]21(17|19|23)(17|19|23)(00|51)21215c79009c637b695c7a7cad5b7a7cad6d6d6d6d6d51675c7a519dc3519d5f7a5f795779bb5d7a5d79577abb5c79587f77547f75817600a0695c79587f77547f75818c9d5c7a547f75815b799f695b795c7f77817600a0695979a35879a45c7a547f7581765c7aa2695b7aa2785a7a8b5b7aa5919b690276587a537a96a47c577a527994a4c4529d00cc7b9d00cd557a8851cc9d51cd547a8777777768"
      }
    }
  ) {
    transaction {
      block_inclusions {
        block {
          height
          timestamp
        }
      }
      inputs {
        outpoint_transaction_hash
        outpoint_index
        outpoint {
          value_satoshis
          transaction {
            block_inclusions {
              block {
                height
                timestamp
              }
            }
          }
        }
      }
    }
  }
}

Thanks for opening an issue! On the demo instance, that returns:
{
  "errors": [
    {
      "extensions": {
        "code": "data-exception",
        "path": "$"
      },
      "message": "negative substring length not allowed"
    }
  ]
}

That's an error coming back from Postgres. To figure it out, we'd need to run the query in the Hasura console and use the analyze button to get the actual Postgres query being run, then figure out where the error is actually happening.
I'd guess it's because you're filtering by redeem_bytecode_pattern, which is itself a computed property. So if the other conditions take your limit 1 query down to 0, it's running that function on nothing, and somewhere inside there it "works" until a substring function is called with a negative integer.
I'd guess redeem_bytecode_pattern just needs to return early before doing the invalid operation. I can't prioritize figuring this out myself, but I'd be happy to take a PR!

Thing is, other conditions don't limit it to 0. For example if you change to limit: 2 then it returns a proper result.
If you change the block height range to something that hasn't been mined yet, then you get a proper empty array as result, with both limit: 1 and limit: 2.

Also, this one which selects only 1 block trips with the same error. Change _gte and _lt heights +1 and it returns empty array proper.
# Matches all spends from AnyHedge v0.11 contract template
# https://gitlab.com/GeneralProtocols/anyhedge/contracts/-/blob/development/contracts/v0.11/bytecode.asm
query {
  input(
    #limit: 10
    #offset: 0
    where: {
      transaction: {
        block_inclusions: {
          block: {
            height: { _gte: 781888, _lt: 781889 }
            accepted_by: { node: { name: { _eq: "bchn-mainnet" } } }
          }
        }
      }
      _or: [
        { unlocking_bytecode_pattern: { _eq: "40104010514d" } }
        { unlocking_bytecode_pattern: { _eq: "4141004d" } }
      ]
      redeem_bytecode_pattern: {
        _regex: "04040[2-4]0[2-4]0[2-8]0[2-8]21(17|19|23)(17|19|23)(00|51)21215c79009c637b695c7a7cad5b7a7cad6d6d6d6d6d51675c7a519dc3519d5f7a5f795779bb5d7a5d79577abb5c79587f77547f75817600a0695c79587f77547f75818c9d5c7a547f75815b799f695b795c7f77817600a0695979a35879a45c7a547f7581765c7aa2695b7aa2785a7a8b5b7aa5919b690276587a537a96a47c577a527994a4c4529d00cc7b9d00cd557a8851cc9d51cd547a8777777768"
      }
    }
  ) {
    transaction {
      block_inclusions {
        block {
          height
          timestamp
        }
      }
      inputs {
        outpoint_transaction_hash
        outpoint_index
        outpoint {
          value_satoshis
          locking_bytecode
          locking_bytecode_pattern
          transaction {
            block_inclusions {
              block {
                height
                timestamp
              }
            }
          }
        }
        unlocking_bytecode
        unlocking_bytecode_pattern
        redeem_bytecode_pattern
      }
    }
  }
}

Replacing regex with like fails on some blocks, too:
Query
{
  "query": "# Matches all spends from AnyHedge v0.11 contract template\n# https://gitlab.com/GeneralProtocols/anyhedge/contracts/-/blob/development/contracts/v0.11/bytecode.asm\nquery {\n  input(\n    #limit: 0\n    #offset: 0\n    where: {\n      transaction: {\n        block_inclusions: {\n          block: {\n            height: { _gte: 785576, _lt: 785577 }\n            accepted_by: { node: { name: { _like: \"%mainnet\" } } }\n          }\n        }\n      }\n      _or: [\n        { unlocking_bytecode_pattern: { _eq: \"40104010514d\" } }\n        { unlocking_bytecode_pattern: { _eq: \"4141004d\" } }\n      ]\n      redeem_bytecode_pattern: {\n        #_regex: \"04040[2-4]0[2-4]0[2-8]0[2-8]21(17|19|23)(17|19|23)(00|51)21215c79009c637b695c7a7cad5b7a7cad6d6d6d6d6d51675c7a519dc3519d5f7a5f795779bb5d7a5d79577abb5c79587f77547f75817600a0695c79587f77547f75818c9d5c7a547f75815b799f695b795c7f77817600a0695979a35879a45c7a547f7581765c7aa2695b7aa2785a7a8b5b7aa5919b690276587a537a96a47c577a527994a4c4529d00cc7b9d00cd557a8851cc9d51cd547a8777777768\"\n    _like: \"%21215c79009c637b695c7a7cad5b7a7cad6d6d6d6d6d51675c7a519dc3519d5f7a5f795779bb5d7a5d79577abb5c79587f77547f75817600a0695c79587f77547f75818c9d5c7a547f75815b799f695b795c7f77817600a0695979a35879a45c7a547f7581765c7aa2695b7aa2785a7a8b5b7aa5919b690276587a537a96a47c577a527994a4c4529d00cc7b9d00cd557a8851cc9d51cd547a8777777768\"\n      }\n    }\n  ) {\n    transaction {\n      block_inclusions {\n        block {\n          height\n          timestamp\n        }\n      }\n      inputs {\n        outpoint_transaction_hash\n        outpoint_index\n        outpoint {\n          value_satoshis\n          locking_bytecode\n          locking_bytecode_pattern\n          transaction {\n            block_inclusions {\n              block {\n                height\n                timestamp\n              }\n            }\n          }\n        }\n        unlocking_bytecode\n        unlocking_bytecode_pattern\n        redeem_bytecode_pattern\n      }\n    }\n  }\n}\n"
}

Result
{
  "errors": [
    {
      "extensions": {
        "code": "data-exception",
        "path": "$"
      },
      "message": "negative substring length not allowed"
    }
  ]
}


Tests failing on armhf

Hello!
The tests fail on armhf. This was discovered by the Debian CI. See the logs

I'm sorry but the link now 404s. Hopefully another armhf user will report an example.


Support template tags in a separate column

I've developed a type of syntactic sugar that results in cleaner looking templates. On the "Nutshell" example it looks like this:
{% extends "base.html" %}
{% block title %}Members{% endblock %}
{% block content %}

{{ user.username }}
            {% for user in users %}{% endfor %}

{% endblock %}

The {% for %} and {% endfor %} could be called "right-side template tags". These template tags are processed as follows:

A right-side template tag that starts with "end" such as "endfor" is placed after the line on the left side
All other right-side template tags are placed before the line on the left side.
After removing the right-side tag, the remaining line is rtrim()-ed to remove right-side white-space.

By applying these three rules, the original "Nutshell" example is restored.
In my experience, the cleanup achieved by this syntax can be massive. By moving all {% for %} and {% if %} statements to a separate column, the remaining text on the left side looks more like a normal document and less like a piece of source-code. I can show you some examples if you are interested, just let me know.
Of course, for backward compatibility this syntactic sugar would have to be put behind a feature flag.

Not a fan of this at all tbh... it feels really weird to me.

I agree that it's weird. I just happens to work really well (in my opinion). Most radical ideas look weird at first :-).


PRs for updating dependencies not opened

It seems the CI - Check dependencies workflow does not open any actual PRs when updates in dependencies are detected.
For examples of this, see the runs:

https://github.com/EMMC-ASBL/oteapi-core/actions/runs/6585581473
https://github.com/EMMC-ASBL/oteapi-core/actions/runs/6585598076

This is fixed by SINTEF/ci-cd#197. So update to the new, upcoming release of SINTEF/ci-cd, and also use the new branch_name_extension input (from SINTEF/ci-cd#201) to ensure the opened PRs from the CI - Check dependencies workflow come from differently named branches.


Fix autopopulated value of facet when settings the value for another (#5541)

@sneridagh checked locally everything is fine and working as expected :)


8 digit hex codes

This is a fix for #416

Updated the toState helper function to convert the color to a hex8 string
Updated all the components to render the 8 digit hex strings and also the alpha input boxes.
Update the test cases and jest snapshots

Any chance of merging this?

Not sure. Need a collaborator to merge this.
@casesandberg

@casesandberg @atfzl anyone?

ping ping

@dvj1988 any chance you'd be willing to publish your fork to NPM?

@dvj1988 any chance you'd be willing to publish your fork to NPM?

I would prefer to be a maintainer of this repository.
I wouldn't mind publishing my fork as well. What do you think @casesandberg ?
Let's wait for a response before doing so.

Is this working with Chrome picker?

yeah. any updates to this?

Hello?


Deflake TestRunCustomRootfs by workaround

Attempt to fix https://github.com/containerd/nerdctl/issues/2327 by workaround
The failure is because the nerdctl can not pull all the layers,
and the ctr can do it.

Thanks, but I don't think that is a good idea to add a dependency to ctr . IMHO we have to investigate why nerdctl do not attempt to fetch correctly layers inside the ci

Thanks @fahedouch
After investigating the issue, the root cause is here:
https://github.com/containerd/containerd/blob/main/pkg/unpack/unpacker.go#L300C14-L300C14
The layer is skipped because the snapshot can be found.
But I have no idea how to fix it :-)

Thanks @fahedouch
After investigating the issue, the root cause is here: https://github.com/containerd/containerd/blob/main/pkg/unpack/unpacker.go#L300C14-L300C14 The layer is skipped because the snapshot can be found.
But I have no idea how to fix it now :-)

So it is no longer a cli issue.

A workaround has been put in place in #3179 that seems to address the issue on the CI.
As for the underlying issue, 2 cents is on the fact we do not ensure the image is extracted (will look into that lead later).

@AkihiroSuda I guess this can be closed?

@AkihiroSuda I guess this can be closed?

Sure


Release chart for autosetup

Updated the helm chart version

Please familiarize yourself with conventinal commits and follow them for future commits. This will also help you in case of an Eclipse committer election.


Improve DiagnosticEngine's handling of ValueDecl arguments

This PR improves the DiagnosticEngine's handling of Decl * diagnostic arguments:

Any Decl, not just ValueDecl, can now be used. This is mainly meant for decls like OperatorDecl which have a name but aren’t ValueDecls, but it works for all Decls.
If the decl is an accessor, the diagnostic engine will automatically describe it using a phrase like getter for 'someProperty’; if it’s an extension, the diagnostic engine will describe it using a phrase like extension of ’SomeType’.
If the %kind modifier is used, the diagnostic engine will prefix the name with the decl's descriptive kind; this lets you eliminate pairs of arguments.
If the %base modifier is used, only the base name will be printed.
If the %kindbase modifier is used, the effects of the previous two modifiers are combined.
If the %kindonly modifier is used, only the kind will be inserted. This is useful when the kind and name aren’t paired together in the usual way.

I believe these changes will simplify a lot of diagnostic code that currently special-cases accessors, passes DescriptiveDeclKind/ValueDecl argument pairs that need to be kept matched up, and looks up declaration names by hand. Adopting Decl more broadly may also open up opportunities for future improvements to diagnostics, like turning decl names into links in clients that would support it.
I've tried to keep this PR close to NFC, but I've kept a few obvious wins where this change handled accessors better or made kinds more specific.
I’ve also removed some diagnostics that are unused and replaced some warn_ variants of diagnostics with more modern features like limitBehavior or warnUntilSwiftVersion.

@swift-ci please test

@swift-ci smoke test and merge

@swift-ci smoke test and merge

Just used this, awesome improvement @beccadax 😍!


TS-5080: log when remap.config is successfully reloaded

[approve ci]

FreeBSD build failed! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1358/ for details.

Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/1250/ for details.

[approve ci]

FreeBSD build failed! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1370/ for details.

Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/1263/ for details.

Seems FreeBSD / clang is finicky on one of the strings.

@zwoop I believe I fixed the error on BSD.

FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1388/ for details.

Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/1282/ for details.

FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1389/ for details.

Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/1283/ for details.


Let refresh_token be a default scope

If you do not pass the refresh_token scope, the refresh token is not provided upon authenticating with Salesforce. This seems like a reasonable default scope as the refresh token is necessary to use this client provider once the expiration period has passed. Please consider. Thanks!

It's most flexible not requiring this. Retracting this... if the use case needs it the developer can add it.

I agree with your decision. Scopes can be included on the fly when generating the authorization URL:
                $authUrl = $provider->getAuthorizationUrl([
                    'scope' => $scopes
                ]);


Fix bug when migrating a private repository

Fix #7644

Codecov Report

Merging #7917 into master will decrease coverage by <.01%.
The diff coverage is 22.22%.

@@            Coverage Diff             @@
##           master    #7917      +/-   ##
==========================================
- Coverage   41.43%   41.42%   -0.01%
==========================================
  Files         478      478
  Lines       63943    63951       +8
==========================================
+ Hits        26492    26493       +1
- Misses      34000    34007       +7
  Partials     3451     3451

Impacted Files
Coverage Δ

modules/migrations/gitea.go
8.74% <22.22%> (+0.08%)
:arrow_up:

models/unit.go
62.16% <0%> (-5.41%)
:arrow_down:

modules/log/event.go
65.64% <0%> (+1.02%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08c6319...f62139c. Read the comment docs.


CH12 KHide Compile Issue, mainly template

My Env is:
VS2019 + WINSDK/WDK:10.0.19041.0
First, there are some compile issues with template parameters. The compiler complaints too few arguments. So, I try to fix some.
In KTL project:
In BasicString.h:L330, I add a default value for the Tag.

template<PoolType Pool, ULONG Tag = 0>
using WString = BasicString<wchar_t, Pool, Tag>;

and in L9.

template<typename T, PoolType Pool, ULONG Tag = 0>
class BasicString {
static_assert(sizeof(T) == sizeof(wchar_t) || sizeof(T) == sizeof(char));

The same for Vector.h:L7

template<typename T, PoolType Pool, ULONG Tag = 0>
class Vector {
public:
struct Iterator {

After fixing these two errors, the compiler still throws an error about new operator. It is in KHide, DriverEntry. So I add a default value for Tag in the template operator new in KTL::Memory.h.

extern "C" NTSTATUS DriverEntry(PDRIVER_OBJECT DriverObject, PUNICODE_STRING RegistryPath) {
g_State = new (PoolType::NonPaged) FilterState;

Memory.h:L13

void* __cdecl operator new(size_t size, PoolType pool, ULONG tag = 0);
void* __cdecl operator new[](size_t size, PoolType pool, ULONG tag = 0);

Again, the compiler issue goes to MiniFilter.cpp:L215. Inside the for-loop, auto name& is a const FilterState, and the conversion is not suitable, I think.

for (auto& name : g_State->Files) {
//
// look for a backslash so we can remove the final component
//
auto bs = wcsrchr(name, L'\');
if (bs == nullptr)
continue;
UNICODE_STRING copy;
copy.Buffer = name.Data()

I add a const version of GetUnicodeString in BasicString.h, and make some change, according Meyers Scott Effective C++.

UNICODE_STRING& GetUnicodeString(UNICODE_STRING& uc) {
/*
static_assert(sizeof(T) == sizeof(wchar_t));
uc.Length = uc.MaximumLength = USHORT(Length() * sizeof(wchar_t));
uc.Buffer = m_Data;
return uc;
*/
return static_cast<const BasicString&>(*this)(uc);
}
UNICODE_STRING& GetUnicodeString(UNICODE_STRING& uc) const {
//return GetUnicodeString(uc);
static_assert(sizeof(T) == sizeof(wchar_t));
uc.Length = uc.MaximumLength = USHORT(Length() * sizeof(wchar_t));
uc.Buffer = m_Data;
return uc;
}

And in the above for-loop:

UNICODE_STRING copy;
//copy.Buffer = name.Data()
name.GetUnicodeString(copy);

The last point is my WINDDK is lower than that of your book, and there is no _FILE_INFORMATION_DEFINITION struct. So I use macro define to check the WDK_NTDDI_VERSION. But I do not know from which version does this struct begin to exist.
 But I have not tested this driver, not sure if it still has some issues.

Thanks for the report.
I have made some modifications to the KTL, and it may have broken some projects. I will revisit that and fix what is needed.

Hmm... I am maybe going the wrong direction.
I should not add a default value for the template parameter in KTL. Instead, I should modify the KHide code...

Nothing with KTL. Just add a tag for Vector, WString and overloaded operator new in ch12


I think CKAN is referencing an incorrect download link for DSSHU for KSP v1.8

Deep Space Surface Habitat Unit Pack for KSP v1.8 is located at this website...
https://forum.kerbalspaceprogram.com/index.php?/topic/168962-18-deep-space-surface-habitat-unit-pack/
...and this is their download link...
https://spacedock.info/mod/1622/Deep Space Surface Habitat Unit Pack
CKAN is currently listing the wrong website and appears to be linked to the wrong download site. When I download via CKAN, I get 4 extra CFG file, one of which is for TweakScale and causes a fatal error between TweakScale and DSSHU.

I checked and the download link is correct. The problem is the mod is using a TweakScale CFG that is wrong. The mod's website though is out of date and the link I provided is their new website.
Sorry, didn't wish to confuse anyone.

CKAN is referencing SpaceDock #1622:
https://github.com/KSP-CKAN/NetKAN/blob/master/NetKAN/DeepSpaceSurfaceHabitatUnitPack.netkan
The reason the "wrong" website (old Add-on Development thread) is linked is because it is set in SpaceDock as homepage.

Oh you've been a bit faster ;)

Yeah, it was my bad, not a CKAN problem. I figured it out though. Thanks for responding though! Y'all are fairly fast with responses I've found.


Add 'greater_than' and 'within' to FileSizeValidator

ref #18
Adding gerater_than and within (in) validation to FileSizeValidator because is is useful.

Failed specs are fixed in #20 😑


ImportError: cannot import name 'reduce_op'

when i run the code
python main.py --mode distill_basic --dataset MNIST --arch LeNet
i got this
`Traceback (most recent call last):
File "F:\dataset_dis\dataset-distillation-master\utils\distributed.py", line 5, in
from torch.distributed import ReduceOp
ImportError: cannot import name 'ReduceOp'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "main.py", line 11, in
from base_options import options
File "F:\dataset_dis\dataset-distillation-master\base_options.py", line 6, in
import utils
File "F:\dataset_dis\dataset-distillation-master\utils_init_.py", line 3, in
from . import distributed
File "F:\dataset_dis\dataset-distillation-master\utils\distributed.py", line 7, in
from torch.distributed import reduce_op
ImportError: cannot import name 'reduce_op'`
is this because of the version of pytorch or something else?

Yes this is because of your pytorch version. Make sure that you have 1.0.0 or later.

Yes this is because of your pytorch version. Make sure that you have 1.0.0 or later.

oh, i am so sorry that i see you reply now, thanks for you help, it works.

i am using torch 1.0.0 but this issue still occurs. Any clue on the problem? Thanks.

@xjwangsjtu Fixed in https://github.com/SsnL/dataset-distillation/commit/ef46862bed45cb332389efbaa010cea4c84d7ccc