not compiling on freebsd 13.2

$ ruby -v
ruby 3.1.4p223 (2023-03-30 revision 957bb7cb81) [amd64-freebsd13]

$ uname -r
13.2-RELEASE-p10

$ freebsd-version
13.2-RELEASE-p10

$ cat /home/starve/.gem/ruby/3.1/extensions/amd64-freebsd-13/3.1/selma-0.2.2/gem_make.out
current directory: /home/starve/.gem/ruby/3.1/gems/selma-0.2.2/ext/selma
/usr/local/bin/ruby31 extconf.rb
checking for cc... yes
checking for c++... yes
checking for ar... yes

current directory: /home/starve/.gem/ruby/3.1/gems/selma-0.2.2/ext/selma
make DESTDIR\= sitearchdir\=./.gem.20240223-33233-c7upga sitelibdir\=./.gem.20240223-33233-c7upga clean
make: "/usr/home/starve/.gem/ruby/3.1/gems/selma-0.2.2/ext/selma/Makefile" line 8: Invalid line type
make: "/usr/home/starve/.gem/ruby/3.1/gems/selma-0.2.2/ext/selma/Makefile" line 10: Invalid line type
make: "/usr/home/starve/.gem/ruby/3.1/gems/selma-0.2.2/ext/selma/Makefile" line 20: Invalid line type
make: "/usr/home/starve/.gem/ruby/3.1/gems/selma-0.2.2/ext/selma/Makefile" line 22: Invalid line type
make: "/usr/home/starve/.gem/ruby/3.1/gems/selma-0.2.2/ext/selma/Makefile" line 24: Invalid line type
make: "/usr/home/starve/.gem/ruby/3.1/gems/selma-0.2.2/ext/selma/Makefile" line 31: Invalid line type
make: "/usr/home/starve/.gem/ruby/3.1/gems/selma-0.2.2/ext/selma/Makefile" line 32: warning: duplicate script for target "ifneq" ignored
make: "Makefile" line 9: warning: using previous script for "ifneq" defined here
make: "/usr/home/starve/.gem/ruby/3.1/gems/selma-0.2.2/ext/selma/Makefile" line 33: Invalid line type
make: "/usr/home/starve/.gem/ruby/3.1/gems/selma-0.2.2/ext/selma/Makefile" line 35: Invalid line type
make: "/usr/home/starve/.gem/ruby/3.1/gems/selma-0.2.2/ext/selma/Makefile" line 265: Invalid line type
make: "/usr/home/starve/.gem/ruby/3.1/gems/selma-0.2.2/ext/selma/Makefile" line 266: warning: duplicate script for target "ifneq" ignored
make: "Makefile" line 9: warning: using previous script for "ifneq" defined here
make: "/usr/home/starve/.gem/ruby/3.1/gems/selma-0.2.2/ext/selma/Makefile" line 266: warning: duplicate script for target "(,)" ignored
make: "Makefile" line 32: warning: using previous script for "(,)" defined here
make: "/usr/home/starve/.gem/ruby/3.1/gems/selma-0.2.2/ext/selma/Makefile" line 267: Invalid line type
make: "/usr/home/starve/.gem/ruby/3.1/gems/selma-0.2.2/ext/selma/Makefile" line 513: Invalid line type
make: "/usr/home/starve/.gem/ruby/3.1/gems/selma-0.2.2/ext/selma/Makefile" line 518: Invalid line type
make: "/usr/home/starve/.gem/ruby/3.1/gems/selma-0.2.2/ext/selma/Makefile" line 520: Invalid line type
make: "/usr/home/starve/.gem/ruby/3.1/gems/selma-0.2.2/ext/selma/Makefile" line 524: Invalid line type
make: "/usr/home/starve/.gem/ruby/3.1/gems/selma-0.2.2/ext/selma/Makefile" line 526: Invalid line type
make: "/usr/home/starve/.gem/ruby/3.1/gems/selma-0.2.2/ext/selma/Makefile" line 528: Invalid line type
make: "/usr/home/starve/.gem/ruby/3.1/gems/selma-0.2.2/ext/selma/Makefile" line 547: Invalid line type
make: Fatal errors encountered -- cannot continue
make: stopped in /usr/home/starve/.gem/ruby/3.1/gems/selma-0.2.2/ext/selma

current directory: /home/starve/.gem/ruby/3.1/gems/selma-0.2.2/ext/selma
make DESTDIR\= sitearchdir\=./.gem.20240223-33233-c7upga sitelibdir\=./.gem.20240223-33233-c7upga
make: "/usr/home/starve/.gem/ruby/3.1/gems/selma-0.2.2/ext/selma/Makefile" line 8: Invalid line type
make: "/usr/home/starve/.gem/ruby/3.1/gems/selma-0.2.2/ext/selma/Makefile" line 10: Invalid line type
make: "/usr/home/starve/.gem/ruby/3.1/gems/selma-0.2.2/ext/selma/Makefile" line 20: Invalid line type
make: "/usr/home/starve/.gem/ruby/3.1/gems/selma-0.2.2/ext/selma/Makefile" line 22: Invalid line type
make: "/usr/home/starve/.gem/ruby/3.1/gems/selma-0.2.2/ext/selma/Makefile" line 24: Invalid line type
make: "/usr/home/starve/.gem/ruby/3.1/gems/selma-0.2.2/ext/selma/Makefile" line 31: Invalid line type
make: "/usr/home/starve/.gem/ruby/3.1/gems/selma-0.2.2/ext/selma/Makefile" line 32: warning: duplicate script for target "ifneq" ignored
make: "Makefile" line 9: warning: using previous script for "ifneq" defined here
make: "/usr/home/starve/.gem/ruby/3.1/gems/selma-0.2.2/ext/selma/Makefile" line 33: Invalid line type
make: "/usr/home/starve/.gem/ruby/3.1/gems/selma-0.2.2/ext/selma/Makefile" line 35: Invalid line type
make: "/usr/home/starve/.gem/ruby/3.1/gems/selma-0.2.2/ext/selma/Makefile" line 265: Invalid line type
make: "/usr/home/starve/.gem/ruby/3.1/gems/selma-0.2.2/ext/selma/Makefile" line 266: warning: duplicate script for target "ifneq" ignored
make: "Makefile" line 9: warning: using previous script for "ifneq" defined here
make: "/usr/home/starve/.gem/ruby/3.1/gems/selma-0.2.2/ext/selma/Makefile" line 266: warning: duplicate script for target "(,)" ignored
make: "Makefile" line 32: warning: using previous script for "(,)" defined here
make: "/usr/home/starve/.gem/ruby/3.1/gems/selma-0.2.2/ext/selma/Makefile" line 267: Invalid line type
make: "/usr/home/starve/.gem/ruby/3.1/gems/selma-0.2.2/ext/selma/Makefile" line 513: Invalid line type
make: "/usr/home/starve/.gem/ruby/3.1/gems/selma-0.2.2/ext/selma/Makefile" line 518: Invalid line type
make: "/usr/home/starve/.gem/ruby/3.1/gems/selma-0.2.2/ext/selma/Makefile" line 520: Invalid line type
make: "/usr/home/starve/.gem/ruby/3.1/gems/selma-0.2.2/ext/selma/Makefile" line 524: Invalid line type
make: "/usr/home/starve/.gem/ruby/3.1/gems/selma-0.2.2/ext/selma/Makefile" line 526: Invalid line type
make: "/usr/home/starve/.gem/ruby/3.1/gems/selma-0.2.2/ext/selma/Makefile" line 528: Invalid line type
make: "/usr/home/starve/.gem/ruby/3.1/gems/selma-0.2.2/ext/selma/Makefile" line 547: Invalid line type
make: Fatal errors encountered -- cannot continue
make: stopped in /usr/home/starve/.gem/ruby/3.1/gems/selma-0.2.2/ext/selma

make failed, exit code 1

Ah, I don't believe I've tried getting this working on amd64, only arm64.
I wouldn't be opposed to supporting this, of course—but my work life is pretty hectic right now, so I will have to check again in mid/late March.

Unfortunately, it is not that simple. 😮💨
First, could you check to see if you can compile lol_html, which is the Rust crate which powers this gem? If you can't—that's actually good news, it means that the problem lies in that project and can probably easily be tweaked to support the new chipset.
If you can build lol-html, then the problem lies in the toolchain here. That Makefile is automatically generated, so any modifications you make will be erased on the next rake compile. But, if you can change the Makefile to get it working, and can share the diff, I can figure out a way to update the build system to support that patch.

thanks for the details. in the end, simply using gnu make instead of bsd make did the trick:
MAKE=$(which gmake) gem install selma

i also installed the latest rust compiler with
curl -sSf https://sh.rustup.rs | sh

as your commonmarker gem complained that rust 1.74 is not enough.
so, what's the exact difference here between make and gmake?


mweb - Compose - Tapping emoji picker, keypad pops up on emoji box page

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: <IP_ADDRESS>
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4279600
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:

Go to https://staging.new.expensify.com/
Tap on a report
Tap emoji picker from compose box

Expected Result:
When user taps emoji picker, keypad must not pop up on emoji box page
Actual Result:
When user taps emoji picker, keypad pops up on emoji box page
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[x] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/93399543/08e0145a-937a-4cd8-acf1-3261f8d64e2e
View all open jobs on GitHub

We think that this bug might be related to #vip-vsb
CC @quinthar

Reproduced in staging and can't reproduce in production
https://github.com/Expensify/App/assets/87341702/896e1ff4-53d3-42e5-84ae-fd0af89f4c44

Sorry, got distracted with other issues. I think the keyboard appears immediately because the "Search" field gets automatically focused. I don't see that auto-focus in production.

This might not be worth being a blocker, but yes ideally we'd stay consistent with other platforms and not show the keyboard.

Could be a red herring but this PR from the checklist modified the EmojiPicker https://github.com/Expensify/App/pull/34581

Could be a red herring but this PR from the checklist modified the EmojiPicker https://github.com/Expensify/App/pull/34581

I noticed this PR, but it doesn't appear to be in staging yet, or at least the comment of deployment to staging is missing

Seems like I'm wrong and the https://github.com/Expensify/App/pull/34581 is already merged in version v1.4.36-0 unless I'm looking at the wrong things

tested a revert of the PR https://github.com/Expensify/App/pull/35737 and it does fix the deploy blocker

Hm yeah there was supposed to be a comment in the PR saying that it was deployed to staging, looks like a bug :(
I checked the 1.4.36-0 tag locally and the code from that PR is definitely on it, so yes it's deployed to staging at the moment.

Thanks @francoisl for the help, and yess, the missing comment mislead me, I won't trust that anymore :P

Sounds good, feel free to send the PR my way and we can CP it.

Sounds good, feel free to send the PR my way and we can CP it.

In case they prefer to do some easy/quick fix rather than reverting, I was going to wait till Monday since we are not deploying today anyways. What do you think?

Good idea, at least we'll have the revert as an option on Monday if it's still blocking the deploy.

Working on a fix

Demoting this from a deploy blocker, I see a fix has been raised but I dont think we have to CP

PR merged, but per @mountiny's comment I'm not going to request CP. Sorry we missed this in the previous PR, and thanks @aldo-expensify for giving @TMisiukiewicz some time to fix this, good call 👍🏼

No payment required here as it was a regression fix!

@jjcoffee - another one to accept, thanks!
https://www.upwork.com/jobs/~01ad9a549f2e03c9fe

@alexpensify Ah sorry, I think no payment is due on this one as it was just a minor regression fix!

@jjcoffee thanks for flagging, let me review and I'll reply tomorrow with an update.

Ok, I've closed the job in Upwork but still left positive feedback. Thanks again for your help and flagging the payment breakdown here.


not working?

var Crawler = require("simplecrawler").Crawler;
var myCrawler = new Crawler("http://www.google.com","/",80,300);
myCrawler.on("fetchcomplete",function(queueItem, responseBuffer, response) {
console.log("I just received %s (%d bytes)",queueItem.url,responseBuffer.length);
console.log("It was a resource of type %s",response.headers['content-type']);
});
myCrawler.start();
I'm missing something?

@cgiffard Could you explain why removing http:// makes crawling work? I spent a long time trying to get the crawler to work in advanced mode (simple mode Crawler.crawl("http://example.com") worked fine) and nothing worked until I came across your comment to remove the http://.
Also, all your examples in the documentation included http://.

@durz Good point — documentation issue. I'll make a point of cleaning it up. :)


Manual trigger of the cleanup cronjob

Admin users should be able to trigger the clean up cronjob manually without having to wait for it to run. This should be done by either a button in the UI or a Django manage.py command.

I should be a button.
You can run the corn job with the Django command ie: python manage.py crontab run job_hash

True, although I think it may still be worth adding in a management command for it. Having to go in and find the job hash to trigger the command isn't as simple as just telling people to run docker-compose exec web python manage.py cleanup-expired or something like that.
A GUI button does also make sense though. Toying with the idea of having some admin page with all the application specific settings - could be a nice home for a cleanup button too.


PYMM-04: Rebrand the notebook

This PR adds the Redea logo icon and Redea Institute of data science

It's all great and ready for merging


Docs: Inline CommandArgument required/optional style in template parameter docs

Found myself looking this up every time I wrote a new command, so it might as well be part of what my IDE shows me while writing.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: ArveSystad sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

@ArveSystad You will need to sign the CLA as well.

@ArveSystad You will need to sign the CLA as well.

Yea, I know. Keep getting errors from that signing app since yesterday evening: MongoTopologyClosedError: Topology is closed. I'll try again a little later.

I've raised an issue over at https://github.com/dotnet-foundation/projects/issues/236.
Hopefully it should be resolved soon. I will go ahead and merge your change anyway since its a small change.

Merged! Thank you for your contribution. Much appreciated! 👍


Fix Torque to use Node instead of Slots

Overview
The command in torque is currently looking at the number of tasks (vcpus).
We recently updated slurm to look at number of nodes instead of jobs in queue. This
follows suit and updates torque.
Slurm fix: https://github.com/awslabs/cfncluster-cookbook/pull/99
Previously we totaled the task or TSK column which is vcpu's specified by the customer when they submit a job. For example --nodes=1:ppn=4 results in 4 under TSK column and 1 under nodes NDS column. By looking at the NDS column we can make intelligent scaling decisions.
See qstat man page for info on displayed columns: https://linux.die.net/man/1/qstat-torque
Testing
I submitted 3 jobs with --nodes=2 and 3 with --nodes=2:ppn=4. This resulted in different totals for the NDS and TSK columns. I show the output below of the old command and the updated command:
[ec2-user@ip-172-31-52-55 ~]$ qstat -i -t

ip-172-31-52-55.ec2.internal:
                                                                                Req'd       Req'd       Elap
Job ID                  Username    Queue    Jobname          SessID  NDS   TSK   Memory      Time    S   Time
----------------------- ----------- -------- ---------------- ------ ----- ------ --------- --------- - ---------
10.ip-172-31-52-55.ec2  ec2-user    batch    run.sh              --      2      2       --   01:00:00 Q       --
11.ip-172-31-52-55.ec2  ec2-user    batch    run.sh              --      2      2       --   01:00:00 Q       --
12.ip-172-31-52-55.ec2  ec2-user    batch    run.sh              --      2      2       --   01:00:00 Q       --
13.ip-172-31-52-55.ec2  ec2-user    batch    run.sh              --      2      8       --   01:00:00 Q       --
14.ip-172-31-52-55.ec2  ec2-user    batch    run.sh              --      2      8       --   01:00:00 Q       --
15.ip-172-31-52-55.ec2  ec2-user    batch    run.sh              --      2      8       --   01:00:00 Q       --
[ec2-user@ip-172-31-52-55 ~]$ qstat -i -t | tail -n+6 | awk '{total = total + $6}END{print total}'
12
[ec2-user@ip-172-31-52-55 ~]$ qstat -i -t | tail -n+6 | awk '{total = total + $7}END{print total}'
30

This PR is contingent on https://github.com/awslabs/cfncluster/pull/357 and a forthcoming PR that translates SGE vcpu's to nodes.
@dougalb


Only allow requests originating from Cloudflare

Description
This PR implements an IP filtering system to block any request that doesn't originate from a Cloudflare IP. The feature can be disabled when developing by setting ENVIRONMENT to dev in the .env file.
Disclaimer: I'm not a nodejs dev at all, and this is my first contact with nestjs, be indulgent please 😅. This solution feels a bit overkill compared to the goal, but from what I understood from the nestjs documentation this seems to be the way to go. If you have any idea of how I could make this feature simpler, please leave a comment, I'll be happy to make changes.
Motivation
To fully benefit from Coudflare's protection we need to ensure all the requests we handle have been proxied through them.
Testing Guidelines
Locally:

in the .env file, set the ENVIRONMENT variable to anything else than dev
make a request to the API
you should get a 403 error

Release Checklist

[ ] This code has unit tests
[x] I have a plan to verify that these changes are working as expected after deploy
[x] I have a plan for how to revert, rollback, or disable these changes if things are not working as expected

Security Checklist
This PR creates, modifies, or deletes:

[x] API routes: API routes, parameters, or user authorization
[ ] Authentication: Authentication mechanism
[ ] Credentials: Server side credentials, or secrets in configuration / source code
[ ] Cryptography: Encryption, hashing, certificates, signatures, random numbers, etc.
[ ] User data: personal information handling, logs, error messages, etc.

Additional Notes
closes #198

Closing this since we've removed the API from the project.


Cannot import to IntelliJ 14

I cannot import the sample/simple project to the fresh IntelliJ14CE.
Screenshot: https://www.dropbox.com/s/knhfidvnwfdebtp/Screen Shot 2015-01-17 at 00.37.44.png?dl=0
Log: https://www.dropbox.com/s/qrqg7qmvh4tbyi9/idea.log?dl=0
Is there any ideas?

Please move sample/simple dir to out of gradle-android-scala-plugin dir. IntellijJ's gradle importer reads gradle-android-scala-plugin/gradle/*.properties mistakenly.

I've moved. Import finished without errors, but there is no sources in project.
https://www.dropbox.com/s/jpkdv9e02ghbz36/Screen Shot 2015-01-17 at 18.34.41.png?dl=0
Any ideas?

In my IntelliJ 14.0.2 CE on Windows8 64bit, the import works fine as long as Android Studio. I think it's a problem particular to IntelliJ in OSX even if the problem exists deleting .idea/ , .gradle/ build/, *.iml, *.ipr

I think this is same issue to https://github.com/saturday06/gradle-android-scala-plugin/issues/50 already closed. If the issue exists yet, please reopen.


RangeError: Value undefined out of range for undefined options property undefined

JSDoc debug output

.npm-global/lib64/node_modules/jsdoc/lib/jsdoc/util/doop.js:9
        set.add(item);

RangeError: Value undefined out of range for undefined options property undefined.

Expected behavior
Attempting to apply JSDoc recursively to all files within a directory
Current behavior
Originally got "FATAL ERROR: CALL_AND_RETRY_LAST Allocation failed - JavaScript heap out of memory" but after allocating more memory I would instead get the RangeError shown above. If I allocate 4gb of memory I get the FATAL ERROR but if I do more I get the RangeError.
Your environment

Software
Version

JSDoc
3.6.7

Node.js
v16.13.0

npm
8.1.0

Operating system
Gentoo 2.8

Is it possible that there's some symbolic link to itself, and this is getting into an infinite loop?

I checked and there aren't any instances of symbolic links in the directory.

Can you please post the command line you used and something about the file structure? Like depth, or number of files?

"node --max_old_space_size=8192 /home/eric/.npm-global/bin/jsdoc --verbose -r ." was the command used.
There are 593 files with a depth of 5.

Hi, are you able to find any solution for this yet?


Way to customize breakpoint color.

Hi,
Often, breakpoints and errors colors collide (same shade of red) and I am not sure at the first glance which is which.
Is there a way to make breakpoints, say, orange to immediately differentiate them?
Thanks

Sorry, wrong repo


My Profile Enhancement

Describe the feature
I want to enhance My Profile Section
Please Assign this task to me.
Describe the solution you'd like
In My Profile I want to give numbering to FAQ and their ans should be in drop down box. I for Profile of user to make it more interactive I want to give profile photo and want to make it more interactive like this
Describe alternatives you've considered

Add ScreenShots

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

Please assign this task to me I will work on this issue.


Telegraf troubleshooting docs

This PR adds a Troubleshooting section to the Telegraf docs.
The scope of this sections is to provide some basic troubleshooting tips about how to capture Telegraf's output and test inputs-outputs.
Staging:
http://docs.staging.influxdata.com:31005/telegraf/v1.0/administration/troubleshooting/
@rkuchan let me know if you have any suggestions in the layout, I don't know if it blends in well with the rest of the docs. Any incorrect wording/phrasing maybe ? Do the steps seem clear?
@sparrc anything else you'd like to add  ? Any issues context-wise ?
@beckettsean

made some minor wording changes, but otherwise looks great! Sorely needed, thanks!


white screen - ERR_CONTENT_DECODING_FAILED

Hello Guys,
For some days I can't run app at all. I think it's since last OS update. I tried to remove cache, logout, reinstall app with full cache removal. Nothing works. After logout I can login one more time and stuck at the same point.
3static.xx.fbcdn.net/rsrc.php/v3/yQ/r/SRUnOLoVCV0.js?_nc_x=UuTtC8_6uSG:1 Failed to load resource: net::ERR_CONTENT_DECODING_FAILED RfBV37Aoeh_.js?_nc_x=UuTtC8_6uSG:51 ErrorUtils caught an error: "JS::call("WebStorageMonster", "schedule", ...) did not fire because it has mi...". Subsequent errors won't be logged; see https://fburl.com/debugjs.
OS: 10.14.6
App_version: 3.4.6

fix itself after few days :) thx

Sorry for the late response - was going to check this out on the weekend. Glad to see it came right!


HUD is outside of sweetspot

HP Reverb G2. UI is never in focus. Maybe add an option to scale the head tracking impact on the UI movement so that the corners of the HUD can be viewed

The HUD is indeed not perfect right now. I'll try to find a solution for this but the main problem is the crosshair being part of that HUD. I'll see what I can do.

Ahhhh. True. I'm not really sure what a good solution would be. I'll ponder it in the shower.

Good news! The crosshair has been separated from the rest of the HUD since the anniversary update. I also noticed that I already fixed the top part of the HUD but the update broke it.

The HUD still appears to be bound to the crosshair position. Are there plans to change this behaviour?

It is indeed bound to it. I lowered the top part so its more visible but is it still too hard to see? I wish I could test with more headsets but I thought it would look fine since the G2 has pretty much the same FOV as my Rift S. Can you elaborate on whats still hard to see?

I getcha. I was under the impression that it was unbound following the anniversary update.The issue I have is that the hud is always in my peripheral vision, which makes it difficult to read. Hard to get a good understanding of your pickups, cooldowns etc.My ideal outcome would be if it could be untethered from the cross hair, so that I can view the hud in the center of my vision, but I understand if that's not possible.On 5/04/2021 8:01 pm, DrBibop @.***> wrote:
It is indeed bound to it. I lowered the top part so its more visible but is it still too hard to see? I wish I could test with more headsets but I thought it would look fine since the G2 has pretty much the same FOV as my Rift S. Can you elaborate on whats still hard to see?
—You are receiving this because you authored the thread.Reply to this email directly, view it on GitHub, or unsubscribe.

Its possible for sure but I'm not too convinced this is the best way to fix the problem. If an enemy is hidden behind the HUD while youre trying to aim with your head, it's just in the way. I guess I can simply make it optional for those that prefer it that way. Thanks for your input.

Ok so turns out it would be a lot harder than I thought to make the HUD static with the crosshair following the camera. I'm not too much of a fan of this solution anyway. As an alternative, would you like an option to change the width and height of the HUD?

Added HUD settings. Gonna close this issue if everything is ok on your side.


manager/engine: Add EventWatch in engine gRPC

The manager can be notified about status changes sooner than the normal 5 seconds query interval.
We still need to set the default query interval to 5 seconds because we need the progress update.

This might be more than event watch. We can use GRPC to replace the binary call totally for the communication between engine and manager. Needs to be careful on upgrade though.

Some comments to consider when implementing the resource monitoring #2441 as part of a controller.


Auto indentation doesn't work when hitting enter in a class method

Have this code:
class A():
    def __init__(self):
        # comment <-- Hit enter here

Have this setting:
    "editor.autoIndent": "none",

Expected:
It indents to the comment level.
Actual:
It goes to the zero position.
Related:
https://github.com/microsoft/pylance-release/issues/4763

This code does work:
class A():
    def __init__(self):
        # comment <-- Hit enter here
        print('bar')

Don't know why this doesn't repro for me

Don't know why this doesn't repro for me

Do you have editor.autoIndent set to none?

Sorry it might actually need more code:
test_list: list[int] = [1, 2, 3]

test_list.append("d")  # pyright: ignore[reportGeneralTypeIssues]

for i in test_list:
    print(i)

import pathlib
from abc import ABC, abstractmethod

class Parent(ABC):
    @abstractmethod
    def __init__(self, path: pathlib.Path):
        pass

class Child(Parent):
    def __init__(self, path: pathlib.Path):
        super().__init__(path)
        # Foo
        # bar

class A():
    def __init__(self):
        # comment <-- Hit enter here

if (test_list.__len__):
    # comment here

def foo():
    # comment here

    print('hello')

I was wrong -- restarting isn't necessary. I was also having trouble just now reproing with Rich's original code snippet, but can repro with the new one.

no worries, the new one repros for me too : )

This issue has been fixed in prerelease version 2023.11.102, which we've just released. You can find the changelog here: CHANGELOG.md


java-linear-search-8.java

Please add your profile and rename the file to java-linear-search-4.

Are you using GitHub web editor?

Yes
On Tue, 2 Oct 2018, 10:50 pm Ayan Banerjee<EMAIL_ADDRESS>wrote:

Are you using GitHub web editor?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ayan-b/Linear-Search/pull/78#issuecomment-426358192,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AVTrOwCKqMNGs_cVfpv3p-OedQPz8WZJks5ug6BWgaJpZM4XEdTa
.


Can't bundle install sorbet

Pretty new to the Ruby ecosystem, so apologies if I'm missing something trivial.
I started following the Adopting Sorbet page and tried setting up my Gemfile as follows:
source 'https://rubygems.org'
gem 'sinatra'

gem 'sorbet', :group => :development
gem 'sorbet-runtime'

I run bundle install and get the following error:
Fetching gem metadata from https://rubygems.org/..........
Resolving dependencies...
Could not find sorbet-static-0.4.4387-universal-darwin-14 in any of the sources

OS is mac, 10.14.4.
Output of rbenv local:
2.6.3

https://buildkite.com/sorbet/sorbet/builds/3973#472ebcad-323c-41cf-a9b7-e2840db48786
RubyGems 502'd when we were publishing
Try using 0.4.4386

specifically:
source 'https://rubygems.org'
gem 'sinatra'

gem 'sorbet', '0.4.4386', :group => :development
gem 'sorbet-runtime', '0.4.4386'

that fixed it. thanks for the specific instruction! helps me a lot as a newcomer c:

I also ran into this just now on Travis CI, because I did not specify a specific version. It seems like a lot of linux releases are missing on rubygems: https://rubygems.org/gems/sorbet-static/versions.


When opening a channel sometimes duplicate appears in the list

Description
Duplicate entries appear in the list when user open a channel

Expected Behavior
Only one channel item must be added
Actual Behavior
Multiple items sometimes appear

Closed via #1521


Internal error in futures select macro

error: internal error in futures select macro: @ parse_list cases (  ) tokens (
file => panic ! ( "file should never complete" ) , next_open => match
next_open {
( Some ( server_end ) , new_open_requests_rx ) => {
open_requests_rx = new_open_requests_rx ; file . add_request_stream (
flags , server_end . into_stream (  ) . unwrap (  ) ) . expect (
"add_request_stream() failed" ) ; } ( None , _ ) => panic ! (
"open_requests stream closed while the directory still running" ) } , ) labels
(
case1 case2 case3 case4 case5 case6 case7 case8 case9 case10 case11 case12
case13 case14 case15 case16 case17 case18 case19 case20 case21 case22 case23
case24 case25 case26 case27 case28 case29 case30 case31 )
    --> /usr/local/google/home/cramertj/src/fuchsia/garnet/public/rust/fuchsia-vfs/fuchsia-vfs-pseudo-fs/src/file.rs:1754:21
     |
1754 | /                     select! {
1755 | |                         file => panic!("file should never complete"),
1756 | |                         next_open => match next_open {
1757 | |                             (Some(server_end), new_open_requests_rx) => {
...    |
1768 | |                         },
1769 | |                     };

internal error in futures select macro: @ parse_list cases (
__FUTURE mlme_event = case1 => {
match mlme_event {
    Some(Ok(MlmeEvent::StatsQueryResp { resp })) =>
    handle_stats_resp(&mut stats_sender, resp)?,
    Some(Ok(other)) => station.lock().unwrap().on_mlme_event(other),
    Some(Err(ref e)) if is_peer_closed(e) => return Ok(()),
    None => return Ok(()),
    Some(Err(e)) => bail!("Error reading an event from MLME channel: {}" , e),
}
} , __FUTURE mlme_req = case2 => {
match mlme_req {
    Some(req) =>
    match forward_mlme_request(req, &proxy) {
        Ok(()) => { }
        Err(ref e) if is_peer_closed(e) => return Ok(()),
        Err(e) =>
        bail!("Error forwarding a request from SME to MLME: {}" , e),
    },
    None =>
    bail!("Stream of requests from SME to MLME has ended unexpectedly"),
}
} , __FUTURE timeout = case3 => {
match timeout {
    Some(timed_event) => station.lock().unwrap().on_timeout(timed_event),
    None => bail!("SME timer stream has ended unexpectedly"),
}
} , ) tokens ( stats_fut => stats_fut ? . into_any (  ) , ) labels (
case4 case5 case6 case7 case8 case9 case10 case11 case12 case13 case14 case15
case16 case17 case18 case19 case20 case21 case22 case23 case24 case25 case26
case27 case28 case29 case30 case31 )

Pardon me if you're aware of this already, but does select! even support the no-binding syntax?
select! {
    file => panic!("file should never complete"),
    next_open => match next_open { ... },
};

The docs only show that for complete and default cases. Instead the docs do show an empty-binding one, so the code should be
select! {
    _ = file => panic!("file should never complete"),
    _ = next_open => match next_open { ... },
};

In any case, the error message is bad, and if this was your intent behind this issue then I currently have nothing to propose.

No, it does not support that syntax, but it should give a better error message (not just an internal error)

Thanks for clarification. And I think the issue title could sound like "Better error message for unsupported syntax in select!" to be more clear what it is about.

Yup, thanks!


[docs] Add more examples to sui client

Description
Adds a few more examples to sui client.
Test plan
How did you test the new or updated feature?

Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

[ ] Protocol:
[ ] Nodes (Validators and Full nodes):
[ ] Indexer:
[ ] JSON-RPC:
[ ] GraphQL:
[ ] CLI:
[ ] Rust SDK:

Thanks @ronny-mysten and @amnn! I implemented all the suggestions and hopefully this will clarify the differences and show examples on how to use these commands.


signoutRedirect does not work if called in less than 30 seconds after log in

I'm using oidc-client in combination with identityserver.
UserManager.signoutRedirect does not always redirect to identityserver. It redirects only if called after 30 seconds after login.

Ensure that you have node, npm and angular cli 1.5+ installed.
Open console. Go to Publishers.Sts directory. Execute dotnet run.
Open console. Go to Publishers.Angular2 directory. Execute npm install. Execute ng serve.
Open browser (chrome). Go to http://localhost:4200
Execute scenarios described on the home page:

Successful scenario
  Click Login
  See login page of identity server
  Enter credentials to authenticate and return to application
  Wait for 30+ seconds after 2nd page reload
  Click users'name and logout
  See logout page of identity server

Unsuccessful scenario
  Click Login
  See login page of identity server
  Enter credentials to authenticate and return to application
  Wait for 25 seconds after 2nd page reload
  Click users'name and logout
  See that nothing happens
  To repeat, remove cookies, sessionStorage and refresh a page

Most of authentication logic resided in AuthService: Publishers.Angular2\src\app\auth\services\auth.service.ts
Test project attached.
Publishers2.zip

@brockallen I think this is an issue worth investigating as I am also seeing a similar behaviour.
I have some scenario  where I 'force' logout shortly after user logs in and somehow application endsup redirecting to "https://authority.example.com/null".

are you able to reproduce this in our samples? I can't do anything if I can't identify/repro the issue.

Thanks for posting this question. The problem I'm having with "signoutRedirect()" when the project has multiple NavBar pages that contain "Sign-Out" links for the user to click. The Default page that allows users to SignIn and SignOut did not have any issues with the "signoutRedirect()". However, when the user is authenticated and redirected to an admin dashboard page that has the 2nd NavBar page with the option for the user to SignOut - calling the "signoutRedirect()" from the auth.service.ts will not redirect to IdentityServer's logout page.
I'm not sure if I'm doing this correctly but I did the following:

Set revokeAccessTokenOnSignout: true, and prompt = 'login'
In the logout(), I included calls to these functions:
revokeAccessToken(), removeUser() and then signoutRedirect()


Change the file owner after the run.

Allow specifying the user to chown. To be honest, I developed this after the chown fix from Dustin Spicuzza.
I have a script like this:
#!/usr/bin/env bash

DOCKER_IMAGE="cdrx/pyinstaller-windows:python2"

docker run -it \
    --rm \
    -v $(readlink -f $(dirname $(readlink -f "$0"))/..):/src \
    --link nexus \
    -e PYPI_URL="http://nexus:8081/repository/pypi-local/pyp" \
    -e PYPI_INDEX_URL="http://nexus:8081/repository/pypi-local/simple" \
    -e PYINSTALLER_CHOWN="$(id -u):$(id -g)" \
    $DOCKER_IMAGE

This actually keeps the user that runs the program.

As a side note, I tried for two days, to create another user pyuser, that would run the wine installation, and the python installation as a regular user, and the plan was to sed the uid:gid straight in the /etc/passwd to the current user, chown the pyuser $HOME, then run the pyinstaller, to have true running of the pyinstaller as the given user.
Unfortunately this is virtually impossible.
If I run it as a regular user, msi will run in the user folder by default, not C:\ (?!) and install Python into Z:\users\pyuser\drive_c\python27. If I just link the .wine folder from the root, and try to execute as sudo, wine complains it's not the same user. Etc. etc. etc.
Quite the roller coaster.

Yes, its a pain :)
Is the difference between this, and the code that Dustin Spicuzza contributed, that you want your files to be owned by the user that ran the command rather than the user that owns the source files?

@bmustiata
I found a solution. You can change the files owner after the run like this:
docker run --rm \
			-v `pwd`:/src/:rw \
    		cdrx/pyinstaller-windows \
			"pyinstaller --clean -y --dist ./dist/windows --workpath /tmp *.spec && chown -R --reference=. *"


Upgrade JavaScript dependencies

Note that the first commit drops our transpilation for pre-ES2019 browsers, because several of our dependencies have done so. We’ve already been blocking IE 11 since 3.0 (#14662), so according to browserslist, this affects Android browser 4.4.3-4.4.4, Baidu 7.12, KaiOS 2.5, and Opera Mini, in the unlikely event that anything worked on those browsers before.
(After the third commit, we actually produce ES2018 code due to an extreme anomaly in the StatCounter statistics for Edge 18 in the US from 2022-02-09 to 2022-02-18. I don’t expect that to continue, though.)
There is an alternative where we configure Webpack to transpile those dependencies with Babel. But that would be less efficient, so this is what I’m proposing first.

lgtm aside from the question about the loose detail for Firefox.

When we’re no longer transpiling for…of loops, the performance difference that inspired loose: true is moot.

Ahh, OK, that makes sense, merged, thanks @andersk!


pkg-auto: Add package automation scripts

This adds some scripts I have been using for over a year to deal with the weekly package updates.
It comes with a README.md which describes a workflow similar to my own.
The sync_packages.sh and update_packages.sh scripts are currently not used anywhere. The idea behind them was to use them for Github Action, but that will come as a follow-up PR.

Dropped some lines from README and added a paragraph about security fixes at the end of the Processing the updates (the manual part) part.


Define the artistic aspect of the objects

The artistic aspect of the collectables was defined in our game presentation.


better support for assertion libraries

Mocha could have a simple way to plug in assertion counting, assertion libraries could then reset the counter on beginning of each test.
Default number of assertions could be guessed from simply searching "assert" or some other word provided by assertion library from within the string of the test content.

It's an interesting idea, but I think it imposes too rigid of a structure on the way someone writes their tests. For example, I might write a test that makes 0 use of assertions, but throws an exception given some behavior.
Furthermore, assertion functions can be mapped to non-standard names. var foo = require('assert'); It would be difficult to enforce anything other than simple cases (looking for expect, assert and should) without a heavy implementation (parsing AST, etc).

I would like this behavior, but perhaps not this implementation.
something like
describe('foo', function() {
  it('does stuff', function() {
    this.assertions(4);
    expect(foo).to.be(bar);
    expect(foo).to.be(bar);
    expect(foo).to.be(bar);
    expect(foo).to.be(bar);
  });
});

this is similar to nodeunit's implementation

but I suppose the rub here is detecting assertions is difficult

right, it's all coming back to me now.  we discussed this in another ticket somewhere.  if we want this behavior, we need to write adapters for assertion libraries.  the assertion library would need to be "registered":
mocha.use(require('chai'));

if we're going to do that, we need to make it so people can write more adapters.
I don't see this as necessarily bad, as it'd give us the potential for more functionality around assertion libraries--but we can't expect assertion libraries to implement anything for us.

anyway, this needs more thought.  #1457

If we introduced a new API for registering assertion libs, we could cover some of the more popular libraries with adapters, and expose a generic adapter or adapter interface for others to work with.

Would there be other benefits to registering the assertion lib aside from assertion counting? Seems like a lot for only 1 feature. But if there's a few others, then it's prob worth the work.

@danielstjules depends how full-featured the assertion library is!  but agreed, this would be a lot for just one feature.

Another benefit from registering the assertion lib would be the ability to make sure that the test doesn't get marked as passing when there are outstanding promises, as that indicates a missing return of a promise. At least this would be a great help for the unexpected library, which uses promises internally to orchestrate asynchronous tests, and probably also chai-as-promised.

To enable guessing default number of assertions could be option given on the assertion library.
In my test files it's not very nice to write this.assertions(n) at the beginning of each test, when all of the tests has exactly same number of assertions as simply searching "assert" from within a test function string.

anyway, this needs more thought. #1457

Indeed it does. Per #2044, I think this specific proposal is one we can close out. Having a plugin API such as in #1457 would be the right way to provide users the means to do this themselves.


Workaround for Holley DZ541

There is an issue in the firmware of recently in germany deployed smart meters. the provider will not update the meters and with the current sml implementation it won't speak correct sml.
To be able to use @Apollon77 s iobroker.smartmeter i have added a workaround (like i had in libsml for volkszaehler). @Apollon77 already had a short review and is fine with the changes.
Here is the PR for the your project, feel free to discuss or review.
Background:
https://github.com/volkszaehler/libsml/issues/75
https://github.com/Apollon77/ioBroker.smartmeter/issues/34

To be honest I do not like that fact that manufactorer deliver such bad firmware quality to customers ... but we can not do anything agsinst that and these devices are out the in the wild, not updatable and will not be replace by the energy companies :-(
So I do not really see any chance other then integrating this. In my eyes it is specific enough to not have "false positive risk". I support the PR!

@dspautz What's your opinion? I would wait 1-2 days if you have a veto or such and then merge the PR and publish a new version ...

Can we do a merge?

Will do tonight

I now prepare to update all deps and so ... we will see how this ends :-)


Fixed text for block of code

Fixed font-size + font family for block of code
@raulraja could you review this PR please?

LGTM!


Remove education-num from the kNN notebook with only numerical data

I think that we should remove the column education-num from the dataset adult-census-num since this is encoding a categorical variable. It would avoid some confusion since we might already introduce that education is a categorical variable in the first notebook.

For simplicity, I am very tempted to remove education-num in all the notebooks after the Exploratory Data Analysis one. Basically we say education has the same information as education-num so let's remove the latter in the rest of the following notebooks.
Maybe have an extra notebook (so that I can easily skip it for the one-day starter course :stuck_out_tongue_winking_eye:) with this kind of subtleties:

nominal vs categorical
numerical that actually are encoding of categorical variables like education-num
keeping both education-num and education since the order may had some additional information on top of the categories

For simplicity, I am very tempted to remove education-num in all the notebooks after the Exploratory Data Analysis one. Basically we say education has the same information as education-num so let's remove the latter in the rest of the following notebooks.
Maybe have an extra notebook (so that I can easily skip it for the one-day starter course :stuck_out_tongue_winking_eye:) with this kind of subtleties:

nominal vs categorical
numerical that actually are encoding of categorical variables like education-num
keeping both education-num and education since the order may had some additional information on top of the categories


Remove leftover strings

These break the F-Droid build.

Awesome! I was going to get to it myself, but glad someone else did. Thanks.

You'll have to push another tag (version) to be picked up by F-Droid though.

No problem, thanks for the reminder.


ENH: add action fetch-busco-db

Add the action fetch-busco-db, which downloads a busco database from the internet. This PR replaces half of #143 which is too outdated to merge. The other half is replaced by #TODO.
### Blocked by...
- [ ] depends on qiime2/q2-types#312

❌  Tests in the CI should fail until the above is merged ☝🏼
Run it locally

Checkout the PR branch.

Assuming 1) you already have a local copy of q2-moshpit installed in editable mode in your activated virtual environment and 2) the working directory is q2-moshpit; run the following.

PR=162
git fetch origin pull/${PR}/head:pr-${PR}
git checkout pr-${PR}

Because this action depends on an unmerged feature of q2-types you will have to do the same with that repo, i.e. check out the relevant PR branch (assuming you have a local copy of q2-types installed in editable mode in your activated virtual environment).

cd somewhere/q2-types
PR=312
git fetch origin pull/${PR}/head:pr-${PR}
git checkout pr-${PR}

Test it out!

cd <download here>
qiime moshpit fetch-busco-db --p-virus False --p-prok True --p-euk False --o-busco-db busco_prok_db.qza --verbose

@ChristosMatzoros don't review this yet. We decided to include the code of the dependent PR already in this PR things might look quite different in a bit.

Hey @ChristosMatzoros, thank you for the nice review. I committed your suggestions and answered your comments above. Let me know if you think there is anything else I should add!

Hey @Sann5 , everything looks good from my end! You can merge once the tests pass.

@misialq same here 🙃

Uh oh, let's resolve those conflicts first @Sann5 😆

@misialq done :)

Hey @Sann5, have you tested the evaluate-busco action without providing it a pre-downloaded DB? It fails for me with an error:
Traceback (most recent call last):
  File "/Users/mziemski/miniconda3/envs/qiime2-shotgun-2024.5/lib/python3.9/site-packages/q2cli/commands.py", line 520, in __call__
    results = self._execute_action(
  File "/Users/mziemski/miniconda3/envs/qiime2-shotgun-2024.5/lib/python3.9/site-packages/q2cli/commands.py", line 586, in _execute_action
    results = action(**arguments)
  File "<decorator-gen-726>", line 2, in evaluate_busco
  File "/Users/mziemski/miniconda3/envs/qiime2-shotgun-2024.5/lib/python3.9/site-packages/qiime2/sdk/action.py", line 334, in bound_callable
    output_types = self.signature.solve_output(**collated_inputs)
  File "/Users/mziemski/miniconda3/envs/qiime2-shotgun-2024.5/lib/python3.9/site-packages/qiime2/core/type/signature.py", line 595, in solve_output
    solved = meta.match(input_types, inputs, outputs)
  File "/Users/mziemski/miniconda3/envs/qiime2-shotgun-2024.5/lib/python3.9/site-packages/qiime2/core/type/meta.py", line 287, in match
    raise ValueError("No solution for inputs: %r, check the signature "
ValueError: No solution for inputs: (ReferenceDB[BuscoDB % Properties('virus', 'prokaryota', 'eukaryota')]¹'²'³'⁴ | ReferenceDB[BuscoDB % Properties('prokaryota', 'eukaryota')]⁵'⁶'⁷ | ReferenceDB[BuscoDB % Properties('virus', 'eukaryota')]⁸'⁹ | ReferenceDB[BuscoDB % Properties('virus', 'prokaryota')]¹⁰'¹¹ | ReferenceDB[BuscoDB % Properties('prokaryota')]¹²'¹³ | ReferenceDB[BuscoDB % Properties('eukaryota')]¹⁴'¹⁵ | ReferenceDB[BuscoDB % Properties('virus')]¹⁶, Bool % Choices(False), Bool % Choices(False), Bool % Choices(False)), check the signature to see valid combinations.

Plugin error from moshpit:

  No solution for inputs: (ReferenceDB[BuscoDB % Properties('virus', 'prokaryota', 'eukaryota')]¹'²'³'⁴ | ReferenceDB[BuscoDB % Properties('prokaryota', 'eukaryota')]⁵'⁶'⁷ | ReferenceDB[BuscoDB % Properties('virus', 'eukaryota')]⁸'⁹ | ReferenceDB[BuscoDB % Properties('virus', 'prokaryota')]¹⁰'¹¹ | ReferenceDB[BuscoDB % Properties('prokaryota')]¹²'¹³ | ReferenceDB[BuscoDB % Properties('eukaryota')]¹⁴'¹⁵ | ReferenceDB[BuscoDB % Properties('virus')]¹⁶, Bool % Choices(False), Bool % Choices(False), Bool % Choices(False)), check the signature to see valid combinations.

See above for debug info.

Also, I alway need to pass all three p-flags, even if I don't want the other databases to be downloaded? Wouldn't there be some other way to make this work so that we don't need to always specify everything but only the ones that we actually want to download? For example, by using a single param with three choice values where you could indicate either of those or all? (not sure this is possible, just an idea...)

Note on the CI: I made a little update to the workflow - when you add [stable] or[prod] to the commit message, the CI will try to use the latest prod tag instead of the dev - this should help with the non-existent channel issues.

Also, I alway need to pass all three p-flags, even if I don't want the other databases to be downloaded? Wouldn't there be some other way to make this work so that we don't need to always specify everything but only the ones that we actually want to download? For example, by using a single param with three choice values where you could indicate either of those or all? (not sure this is possible, just an idea...)

@misialq I now made all parameters False by default and this allows the user to only set the flags to true of the groups for which they want to download the database.

Hey @Sann5, have you tested the evaluate-busco action without providing it a pre-downloaded DB? It fails for me with an error:
Traceback (most recent call last):
  File "/Users/mziemski/miniconda3/envs/qiime2-shotgun-2024.5/lib/python3.9/site-packages/q2cli/commands.py", line 520, in __call__
    results = self._execute_action(
  File "/Users/mziemski/miniconda3/envs/qiime2-shotgun-2024.5/lib/python3.9/site-packages/q2cli/commands.py", line 586, in _execute_action
    results = action(**arguments)
  File "<decorator-gen-726>", line 2, in evaluate_busco
  File "/Users/mziemski/miniconda3/envs/qiime2-shotgun-2024.5/lib/python3.9/site-packages/qiime2/sdk/action.py", line 334, in bound_callable
    output_types = self.signature.solve_output(**collated_inputs)
  File "/Users/mziemski/miniconda3/envs/qiime2-shotgun-2024.5/lib/python3.9/site-packages/qiime2/core/type/signature.py", line 595, in solve_output
    solved = meta.match(input_types, inputs, outputs)
  File "/Users/mziemski/miniconda3/envs/qiime2-shotgun-2024.5/lib/python3.9/site-packages/qiime2/core/type/meta.py", line 287, in match
    raise ValueError("No solution for inputs: %r, check the signature "
ValueError: No solution for inputs: (ReferenceDB[BuscoDB % Properties('virus', 'prokaryota', 'eukaryota')]¹'²'³'⁴ | ReferenceDB[BuscoDB % Properties('prokaryota', 'eukaryota')]⁵'⁶'⁷ | ReferenceDB[BuscoDB % Properties('virus', 'eukaryota')]⁸'⁹ | ReferenceDB[BuscoDB % Properties('virus', 'prokaryota')]¹⁰'¹¹ | ReferenceDB[BuscoDB % Properties('prokaryota')]¹²'¹³ | ReferenceDB[BuscoDB % Properties('eukaryota')]¹⁴'¹⁵ | ReferenceDB[BuscoDB % Properties('virus')]¹⁶, Bool % Choices(False), Bool % Choices(False), Bool % Choices(False)), check the signature to see valid combinations.

Plugin error from moshpit:

  No solution for inputs: (ReferenceDB[BuscoDB % Properties('virus', 'prokaryota', 'eukaryota')]¹'²'³'⁴ | ReferenceDB[BuscoDB % Properties('prokaryota', 'eukaryota')]⁵'⁶'⁷ | ReferenceDB[BuscoDB % Properties('virus', 'eukaryota')]⁸'⁹ | ReferenceDB[BuscoDB % Properties('virus', 'prokaryota')]¹⁰'¹¹ | ReferenceDB[BuscoDB % Properties('prokaryota')]¹²'¹³ | ReferenceDB[BuscoDB % Properties('eukaryota')]¹⁴'¹⁵ | ReferenceDB[BuscoDB % Properties('virus')]¹⁶, Bool % Choices(False), Bool % Choices(False), Bool % Choices(False)), check the signature to see valid combinations.

See above for debug info.

Puff... it seems that even thou busco_db is optional when left unspecified the TypeMap errors out because there is no option where the busco_db=None in the TypeMap. Unfortunately as we found out before TypeMaps cannot include none elements. It seems to me that the only option is to make the busco_db a mandatory input.

@misialq this one need a manual squash-merge since the CI is still failing :)

/q2ci

@misialq It does not look like the QIIME 2 CI is being triggered.

It doesn't get triggered because I migrated the CI to our new one, which means the Q2 CI only runs when you request it - see my last comment above ;)

/q2ci

Hey @misialq, just ran a new round of prepares (since we have to patch 2024.5) and ran into this failure in moshpit: https://github.com/qiime2/distributions/actions/runs/9574415150/job/26433191625#step:9:403
I'm not exactly sure what caused these failures (test_evaluate_busco_action for both TestBUSCOFeatureData and TestBUSCOSampleData) but it seems likely to be related to the updates that were made here and here. I can still kick off patch release builds for tiny and amplicon before this needs to be fixed, but wondering if there's anything that stands out to you as being the culprit?

/q2ci

Mmmm, good catch @lizgehret, thanks! My guess is that there are some DB files missing among the test files - @Sann5 can you please check?

@misialq in deed I think there were some test files missing (e.g. I did not include them in the setup.py). Should I open a PR for this?

Please do, thanks!


Messaging around key storage

I think we should evaluate our messaging around key storage and encourage users away from questionable practises such as storing long term private keys in secrets / on disc and alike. We should instead start to pivot towards recommending folks use Keyless or a KMS, HSM etc.
Looking at the github blog yesterday, the first example outlined storing a private key (with no passphrase) in a SECRET. In many ways sigstore was started to address this sort of situation, and keyless was / is the killer feature to address the hazards with key management and the risks of key compromise of long term keys.
No fingers being pointed here, we are still a young project in the greater scheme of things,  but as keyless starts to make its first steps out of experimental, I recommend we amend documentation to carry warnings about the possible risks of storing private keys in such manner and when we can, encourage & educate developers / users onto a different and perhaps safer path.
cc @dlorenc @mattmoor @bobcallaway @dekkagaijin et al

A somewhat orthogonal, but similar thing we have been discussing (on/off for a while) is allowing folks to sign tags (vs requiring digests).
I believe at a minimum using tags should carry a warning, but eventually we may even want to require an additional flag to support them.

Something else to keep in mind is that even when fulcio/rekor come out of EXPERIMENTAL, we still don't have a great story for using them with private repos and artifacts. We'll need to be very clear on that messaging too - we don't want surprises for people using our tooling to then find out what data has been "leaked" into the logs.


Commands in refactored Git do not work at all in Sublime Text 2

Every single command (and even just switching tabs) prints this to the console and appears to do nothing:
Traceback (most recent call last):
  File "./sublime_plugin.py", line 362, in run_
  File "./git/statusbar.py", line 22, in run
  File "./git/__init__.py", line 258, in run_command
TypeError: __init__() keywords must be strings

This seems to be because git/__init__.py imports unicode_literals and then proceeds to do kwargs['blah'] = blah; CommandThread(blah, **kwargs) using string literals, which are now Unicode literals.
I’m still using ST2 because I’m still using Mac OS X 10.6. I could elaborate further, but that’s beyond the point. :)

Hm, I don't see this when using ST2 myself, so I suspect it's something specific to the older version of OS X.

I've speculatively added b007580 to see if it'll help. Shouldn't hurt, anyway.

That does seem to have done the trick, thanks. The values (as opposed to the keys) probably don’t need to be cast to str though, do they? Upon checking, it seems Python 2.7 allows Unicode keys in kwargs but 2.6 doesn’t; maybe that’s it.


When trying to build with snowpack this error is thrown

[21:51:17] [snowpack] Build Result Error: There was a problem with a file build result.
[21:51:17] [snowpack] Parse error @:13:78
[21:51:17] [snowpack] Error: Parse error @:13:78
at parse (/home/pyc/ttwww/node_modules/es-module-lexer/dist/lexer.cjs:1:402)
Is there any help to it?

If snowpack is using this project, one thing that would help the error message is to pass the second argument as the file name where they are calling into es-module-lexer. Then the @ in the above message would be the filename causing the parse issue, allowing seeing what character is failing the parse. It may well be JSX or TypeScript syntax causing it though. I'd suggest posting an issue on the relevant repo directly for more information.

Thanks for your reply. I'm pretty new to this so I don't know where exactly that second argument should be passed.
is that somewhere around here?
$ grep es-module-lexer * -R
node_modules/snowpack/lib/esm/scan-imports.js:import { init as initESModuleLexer, parse } from 'es-module-lexer';
node_modules/snowpack/lib/esm/rewrite-imports.js:const { parse } = require('es-module-lexer');
node_modules/snowpack/lib/esm/lexer-util.js: * Adopted from https://github.com/guybedford/es-module-lexer
node_modules/snowpack/lib/esm/scan-imports.d.ts:import { ImportSpecifier } from 'es-module-lexer';
node_modules/snowpack/lib/cjs/scan-imports.js:const es_module_lexer_1 = require("es-module-lexer");
node_modules/snowpack/lib/cjs/rewrite-imports.js:const { parse } = require('es-module-lexer');
node_modules/snowpack/lib/cjs/lexer-util.js: * Adopted from https://github.com/guybedford/es-module-lexer
node_modules/snowpack/lib/cjs/scan-imports.d.ts:import { ImportSpecifier } from 'es-module-lexer';

@trancephorm yes it's the second argument to that parse function that is imported.

I'll be honest: I don't have a clue what to do. :) But it doesn't matter, thanks anyways.


bug: echo numa variável q acabou de dar unset tá dando leak (detalhes na descrição)

==============================================================
Hello World !
/home/coder/Documents/Projects/Minishell-42sp $ export TESTE1=batata
/home/coder/Documents/Projects/Minishell-42sp $ echo $TESTE1
batata
/home/coder/Documents/Projects/Minishell-42sp $ unset TESTE1
/home/coder/Documents/Projects/Minishell-42sp $ echo $TESTE1

==============================================================
Hello World !
/home/coder/Documents/Projects/Minishell-42sp $ export TESTE1=batata
/home/coder/Documents/Projects/Minishell-42sp $ echo $TESTE1
batata
/home/coder/Documents/Projects/Minishell-42sp $ unset TESTE1
/home/coder/Documents/Projects/Minishell-42sp $ echo $TESTE1
==13561== Invalid read of size 1
==13561==    at 0x10FF3A: ft_strncmp (in /home/coder/Documents/Projects/Minishell-42sp/minishell)
==13561==    by 0x109808: builtin_echo (builtin_echo.c:22)
==13561==    by 0x10A3B6: execute_built_in (executor.c:54)
==13561==    by 0x10A49C: execute_command (executor.c:72)
==13561==    by 0x10C4D5: fork_and_execute_cmd (utils_executor_2.c:30)
==13561==    by 0x10A69E: execute_pipeline (executor.c:128)
==13561==    by 0x10B968: repl (minishell.c:43)
==13561==    by 0x10B9F9: main (minishell.c:61)
==13561==  Address 0x0 is not stack'd, malloc'd or (recently) free'd
==13561==
==13561==
==13561== Process terminating with default action of signal 11 (SIGSEGV): dumping core
==13561==  Access not within mapped region at address 0x0
==13561==    at 0x10FF3A: ft_strncmp (in /home/coder/Documents/Projects/Minishell-42sp/minishell)
==13561==    by 0x109808: builtin_echo (builtin_echo.c:22)
==13561==    by 0x10A3B6: execute_built_in (executor.c:54)
==13561==    by 0x10A49C: execute_command (executor.c:72)
==13561==    by 0x10C4D5: fork_and_execute_cmd (utils_executor_2.c:30)
==13561==    by 0x10A69E: execute_pipeline (executor.c:128)
==13561==    by 0x10B968: repl (minishell.c:43)
==13561==    by 0x10B9F9: main (minishell.c:61)
==13561==  If you believe this happened as a result of a stack
==13561==  overflow in your program's main thread (unlikely but
==13561==  possible), you can try to increase the size of the
==13561==  main thread stack using the --main-stacksize= flag.
==13561==  The main thread stack size used in this run was 8388608.
/home/coder/Documents/Projects/Minishell-42sp $ exit
exit


how do i get a data from robomongo in meteor

@sushant55252  It is not connected with repo itself. @Urigo please close that issue.


Updating deps

Updating the dependencies

Current coverage is 92.94%

Merging #42 into master will not affect coverage as of a1ff2ac

@@            master     #42   diff @@
======================================
  Files            1       1
  Stmts          170     170
  Branches         0       0
  Methods          0       0
======================================
  Hit            158     158
  Partial          0       0
  Missed          12      12

Review entire Coverage Diff as of a1ff2ac

Uncovered Suggestions

+3.53% via ...c/angular-spotify.js#488...493
+2.35% via ...c/angular-spotify.js#71...74
+1.17% via ...c/angular-spotify.js#481...482

Powered by Codecov. Updated on successful CI builds.

Coverage remained the same at 92.941% when pulling a1ff2ac65263ebe52e70f89a541d8b400f4da5c9 on updates into 78795484b1aac342a38078b1f53576a3a77d8da8 on master.


Use Substrate

client-gradle-plugin still uses the outdated Omega library instead of Substrate and is not on par with client-maven-plugin.

Fixed by https://github.com/gluonhq/client-gradle-plugin/pull/61


HTTP Error 500.30 - ANCM In-Process Start Failure

IIS: 8.5
Dotnet core 3.0

I try removing the explicit specification of InProcess as the hosting model, replacing
InProcess with Microsoft.AspNetCore.App
But app show "HTTP Error 500.30 - ANCM In-Process Start Failure"
Please help me fix.

Do you have the .NET Core Hosting Bundle installed?
You can run directly the website in command prompt to see if there are any error message


Refactor modals to use a common Modal component

Means that all modals now have a close button in the top right

/override "Red Hat Konflux / integration-tests-with-rosa / lightspeed-console"


[CXF-9024] Increase unit test coverage on org.apache.cxf.binding

@jgoodyear I am closing this one, we have pretty good coverage at the moment already


Context menu false positives while scrolling (and ability to disable it)

Here is an example of context menu appearing when I'm just trying to stop scrolling feed. On mobile this menu often appears when I don't want to.
Maybe show it only on post timestamp hold (instead of whole post area). Or add timeouts to prevent it from showing it immediately after scrolling? Or add a setting to disable it 🤔
For me it just feels wrong 😭
I'm using dev.phanpy and Google Chrome on Android 14
https://github.com/cheeaun/phanpy/assets/1143226/9abf0930-f34a-473f-8307-65587fae33cb

Adding context: should have been fixed by https://github.com/cheeaun/phanpy/pull/165 but somehow still happening on your mobile.

@cheeaun it still happening
can we prevent context menu opening if click happened faster than 500-1000 ms after "scroll end" event

@cheeaun
Problem solved on system level

https://support.google.com/accessibility/android/answer/6006989?hl=en
To adjust the touch and hold delay:

Open your device's Settings app .
Tap Accessibility and then Touch & hold delay.
Select Short, Medium, or Long.

@cheeaun
A different problem appeared after I have changed "hold delay" to "long".
Menu appears early without vibration feedback and disappears if you stop holding.
If you hold longer - vibration feedback happens and menu reappears
https://github.com/cheeaun/phanpy/assets/1143226/c1abbc5c-039d-4163-b703-b7c1d4d480d3

@Alex0007 I think "Short" is actually the default (I also see it on my Pixel 3). I don't think this should affect the bug much and if it does, I'd have no idea what's happening as there's no touch-hold/longpress event in JS at all, so it's likely conflicting with what the browser/OS is doing, with no way for JS to control 😅 Duration for touch-hold/longpress is also hardcoded in JS, so it's not able to respect the OS Hold Delay setting.
Anyway, I've reduced cancelOnMovement to 2 pixels, maybe you can change hold delay back to "Short" and try again 🙏
Thanks a lot for keep trying this! 🙇♂

@cheeaun
oncontextmenu
If you set big threshold – you will notice that there are two events triggering context menu:
contextmenu: respects system hold "delay setting", it has vibration feedback
touchstart: this one is coming from useLongPress hook and uses threshold value from code. It doesn't have vibration feedback.
In my opinion contextmenu event should be preferable

Two events while i was doing single long press:

@Alex0007 thanks!! Didn't know contextmenu actually works on Chrome Android 😱 (it doesn't work on Mobile Safari, so I assumed other mobile browsers followed its path). I'll do further testing, maybe need to first feature-detect contextmenu support as it's way more reliable than the hacky "longpress" event.

It feels much better without useLongpress, thanks @cheeaun!
Also it seems like this issue was also because of useLongpress


Modpack on 1.7.10 crashes

Please use the search functionality before reporting an issue. Also take a look at the closed issues!
Issue description:
I wanted to add Mekanism to the 1.7.10 modpack "Realm of Mianite", so I did and when I launch my client, forges loads since like 24% and then the client crashes. In the logs, it says that the SolarEvaporationController.class is not found...
I really need to add mekanism on the 1.7.10 version and I can't...
Forge: ForgeMultipart-1.7.10-<IP_ADDRESS>5-universal.jar
Mekanism: Mekanism-1.7.10-<IP_ADDRESS>1
Crash-Report:
https://pastebin.com/Le7bEbex

up ?

1.7.10 is no longer supported, move to newer version.

1.7.10 is no longer supported, move to newer version.

Ofc and that may be the reason why i can run the regular MC with the same version of mekanism, I'm asking help to fix my issue, I'm not asking some guys who say "give up"...
Thank you anyway for your answer but that's not this kind of answer that I want...

Fine, since Mekanism as is working fine, you will have to figured out on yourself the problem, start taking mods out and see when it stops. Or try to replicate the pack on yourselft, then you can copy configs or custom scripts if there are any

Fine, since Mekanism as is working fine, you will have to figured out on yourself the problem, start taking mods out and see when it stops. Or try to replicate the pack on yourselft, then you can copy configs or custom scripts if there are any

Thanks a lot, i'll try it and tell you if it worked ^^

Duplicate of #3483


Cannot find service fabric reg key windows 2019

Description
fails at tools.tests.ps1 script, cannot find service fabric reg key

Platforms affected

[X] Azure DevOps
[ ] GitHub Actions - Standard Runners
[ ] GitHub Actions - Larger Runners

Runner images affected

[ ] Ubuntu 18.04
[ ] Ubuntu 20.04
[ ] Ubuntu 22.04
[ ] macOS 11
[ ] macOS 12
[X] Windows Server 2019
[ ] Windows Server 2022

Image version and build link

Is it regression?
No
Expected behavior
proceed to build image
Actual behavior
fails at image undeployable, so not installing configure-antivirus.ps1 script per discussion from https://github.com/actions/runner-images/discussions/6251
but fails with the above message.
fails at tools.tests.ps1 script, cannot find service fabric reg key
Repro steps

remove configure-antivirus.ps1 from the windows2019 json file.
run the build.
will fail with above.

Hi @vamshisiram , we will take a look.

Can confirm, having the same problem on builds of Windows 2019 as well as 2022.

I know the PR is not merged/approved yet, but i tried making those changes from the PR to the repo i cloned to my PC and it still fails, with the message below :

hoping that the PR once reviewed and merged will help clear this issue.
Tagging @igorboskovic3 @Alexey-Ayupov  for visibility into this new error i saw with the code from the PR above.

Should be all set now, please sync your main again.

windows 2022 failed as well with same message...

i will sync the main again and try, hoping some other changes were made to the repo other than what was in the PR by @Alexey-Ayupov . Because manually making those changes did not work.

Can confirm, having the same problem on builds of Windows 2019 as well as 2022.

@angaar96 If you run into the above issue with setting execution policy like me, i fixed it by modifying the "Install-ServiceFabricSDK.ps1" script lines 14 and 15 to the following:

I wanted to share this with you, as you were having the same issue as me.


Dc/8546 semantic models in graph selection

resolves #8546

adds SemanticModelSelectionMethod to allow for dbt ls -s "semantic_model:*"
adds ability to dbt ls --resource-type semantic_model

as of 9/7
SemanticModelSelectionMethod works
❯ dbt ls -s +semantic_model:number
15:10:25  Running with dbt=1.7.0-b2
15:10:25  Registered adapter: snowflake=1.7.0-b1
15:10:25  Found 5 models, 1 analysis, 1 source, 0 exposures, 0 metrics, 514 macros, 0 groups, 1 semantic model
davebt.numbers # model
semantic_model:davebt.number # semantic model

dbt ls does not include semantic models
dbt ls --resource-type semantic_model yields no nodes

Problem

Checklist

[x] I have read the contributing guide and understand what's expected of me
[x] I have run this code in development and it appears to resolve the stated issue
[x] This PR includes tests, or tests are not required/relevant for this PR
[x] This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

TODO: finish ability to dbt ls --resource-type semantic_model

Found it:
https://github.com/dbt-labs/dbt-core/blob/b39eeb328c9a245f21b54fb48f2761ad03d4d6ad/core/dbt/graph/cli.py#L24
Should be:
DEFAULT_INCLUDES: List[str] = ["fqn:*", "source:*", "exposure:*", "metric:*", "semantic_model:*"]

Then semantic models will be included when --select is not passed.
It does feel like there's a real opportunity for refactoring here. It feels odd that sources/exposures/semantic_models/metrics are "pointer" node types, as opposed to the "logical" node types (models/seeds/snapshots/tests/analyses), and only those are included by the fqn:* selection.
But I think that's all out of scope for something we want to backport to v1.6!

Thanks for the solid start @dave-connors-3 !!
@MichelleArk is going to take this one over the finish line, so we can get it merged & backported for the next v1.6.x patch

Opened a new issue in dbt-labs/docs.getdbt.com: https://github.com/dbt-labs/docs.getdbt.com/issues/4133

Opened a new issue in dbt-labs/docs.getdbt.com: https://github.com/dbt-labs/docs.getdbt.com/issues/4134


Misalignment between IR Y16 and Y8 images

Required Info

Camera Model
D435

Firmware Version
<IP_ADDRESS>

Operating System & Version
Ubuntu 16.04

Kernel Version (Linux Only)

Platform
PC

SDK Version
v2.10.1

Issue Description
When capturing the Y16 and Y8 IR images in realsense-viewer I observed that these two images are not the same. They seems to have a small shift and scale change (see below). What are the transformations applied to the Y8 IR image?

And here is the diff between the above two images:

Any update as to what this shift/scaling is? There seems to be an even bigger shift between Y8 and Y16 1920x1080 IR images of the second IR camera.
This does not happen when comparing Y16 and Y8 images of lower resolutions.

Hi @JasonChang13
No, its not the same issue. The one youre refering to was also opened by me, but it only had to do with bayer artifacts. There was no shifting or scaling involved when debayering.

[Realsense Customer Engineering Team Comment]
hi @panjekm,
the Y16 image is unrectified image and Y8 image is rectified image, so they do different.

Can you double check this?
When I look at both raw IR Y16 fullHD images they seem to be rectified already. The IR Y8 1280x720 images then seem to be just zoomed in.
What transformations do you do between IR Y16 fullHD and IR Y8 1280x720 images? Also, when do you undistort them?

Rectification is done by the ASIC and introduces a homography transformation from Y16 to Y8 view.
It does not affect the distortion model of the frame, just reprojecting them into a shared virtual plane.

[Realsense Customer Engineering Team Comment]
Is this still an issue?  If not, ticket will be closed in 5 days.

I am also interested to calibrate the cameras myself.

Is there a way to receive the unrectified (i.e. raw) IR images? Is a simple change to Y16 in the SDK enough to receive "high quality" unrectified IR images? Is there any post-processing needed?
What parameters (i.e. shift and zoom) does the ASIC (for D415/D435) use for rectification?
Thanks!

Its still unclear how exactly you do calibration. Im using openCV rectification function on IR1 and IR2 Y16 images I cant seem to get to the same resulting Y8 image. There is this shift/zoom difference between my rectified Y16 image and your rectified Y8 image.

@agrunnet
Thanks a lot! Is it also possible to change the format with ros? I changed the format from Y8...
_format[INFRA1] = RS2_FORMAT_Y8;   // libRS type
_image_format[INFRA1] = CV_8UC1;    // CVBridge type
_encoding[INFRA1] = sensor_msgs::image_encodings::TYPE_8UC1; // ROS message type
_unit_step_size[INFRA1] = sizeof(uint8_t); // sensor_msgs::ImagePtr row step size
_stream_name[INFRA1] = "infra1";
_depth_aligned_encoding[INFRA1] = sensor_msgs::image_encodings::TYPE_16UC1;

...to Y16...
_format[INFRA1] = RS2_FORMAT_Y16;   // libRS type
_image_format[INFRA1] = CV_16UC1;    // CVBridge type
_encoding[INFRA1] = sensor_msgs::image_encodings::TYPE_16UC1; // ROS message type
_unit_step_size[INFRA1] = sizeof(uint16_t); // sensor_msgs::ImagePtr row step size
_stream_name[INFRA1] = "infra1";
_depth_aligned_encoding[INFRA1] = sensor_msgs::image_encodings::TYPE_16UC1;

However, the format Y16 doesn't seem to be supported. Any idea what I did wrong?
Thanks!

[Realsense Customer Engineering Team Comment]
hi @panjekm,
i think you are comparing our Y8 and your Y8 image after rectified from our Y16 image, right?
maybe you can share how you do rectification and we can check if any difference.
also i think Y16 support only 1280x800, so suggest you to try again with this resolution.

I think we can close this. Hopefully the differences between Y8 and Y16 were sufficiently illuminated. As for ROS, @cartokk feel free to open a separate issue if you need this. At the moment it is not supported I believe, just because we don't see any application for Y16 frames in a robot (with them being non-rectified and all)


First Task Instructions unclear

For the "Create setHiddenFields Function" the instructions are:
Our application uses the answer hidden input to store the answer to the game. Our setHiddenFields method should not use any parameters, but needs to set the awnser hidden input to a randomly generated number between 0 and 9999.

This doesn't specifically say anything about what a student is supposed to do for this step.  I recommend something like this:
Create a function named `setHiddenFields` that sets the `answer` variable equal to a randomly generated number between 0 and 9999.

Also, Hint 1 can be cleaned up too.
Math.round() can be used to randomly generate a number between 0 and 1 (up to 18 decimal points) and Math.floor(input), Math.ceiling(input), or Math.round(input) can be used to then round that number either up or down.

Not sure what the point of Hint 2 is here - we don't have to call getElementById in this task, right?

Also in Hint 1 - says "Math.round() can be used to randomly generate...", it's actually Math.random(), right?

I've updated the details on task 1 in both the .com and readme.md for clarity.


Update README.md

Fixed grammatical errors in the README.md
PR Description 📜
Please include summary related to the issue you have fixed and describe your PR in brief over here by specifying the issue number on which you were working below
Fixes # <your_issue_number>

Mark the task you have completed ✅

[x] I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
[x] I have performed a self-review of my own code or work.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[ ] I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
[ ] I have added screenshot for website preview in assets/images
[ ] I have added entries for my game in main README.md
[ ] I have added README.md in my folder
[ ] I have added working video of the game in README.md (optional)
[ ] I have specified the respective issue number for which I have requested the new game.

Add your screenshots(Optional) 📸

Thank you soo much for contributing to our repository 💗

@Manice18 as per our guideline you have to create issue and then you can start working upon that  !!
We value your contribution but you have to make sure you  follow proper guideline 😃
Raise an issue for the same then you mention respective issue number in PR so it is easy for use to track !!
We will look into it once you do that !
Thank you 💗


Add 2-qubit gate decomp based on randomly filling the Weyl chamber to contrib

Current (experimental) version of 2 qubit gate compiler. Given a single base gate A, the compiler tabulates many products of the form A k A  and A k A k A, where k are randomly generated 1-local unitaries. After many samples (and assuming an appropriate gate A), this fills up the Weyl chamber with a set of unitaries such that any target unitary U_t is epsilon close to a tabulated unitary.

@Strilanc : Any changes outstanding before the PR can be approved?

Automerge cancelled: A required status check is not present.
Missing statuses: ['cla/google']

Awesome, thanks a ton for doing this! As soon as we get #2445 resolved, I'll try running the QV stuff with this decomposition algorithm. I think it's going to give us some good improvements :)


How to solve dicomParser.explicitElementToString: cannot convert implicit element to string?

In the Example of displaying a DICOM P10 from the local file system I can load the dicom file.
But in my one, I get the below error:

Here is my code: the error happens in 17 line

Can anyone help me to figure out this?
Thanks so much!

Since the file you're trying to convert is in implicit VR transfer syntax, dicomParser doesn't know the types of any of its elements. You can make a callback that returns the VR given a tag and pass it to dicomParser.parseDicom in the vrCallback property of the options object (see the README for details). The VRs for all known tags are available here.

Hi @yagni, Thanks so much for your help!
However, I still feel a little bit confused about how to implement vrCallback in dicomParser.parseDicom. Does that mean after we add the callback function, we can get a normal dataset that can be used in dicomParser.explicitDataSetToJS(dataSet)?
Below are some of my ideas:
var dicomFileAsBuffer = new Uint8Array(arrayBuffer as ArrayBuffer);
const dataSet = dicomParser.parseDicom(dicomFileAsBuffer, {
      vrCallback(tag) {
// x00280011 is diocm image width
        if (tag=="x00280011"){
          return {'tag': '(0028,0011)', 'vr': 'US', 'vm': '1', 'name': 'Columns'}
          }
      },
    });
tags = dicomParser.explicitDataSetToJS(dataSet);
   console.log(tags["x00280011"]);

But when I run the code like this, I still get the same error.
Could you give an example of how to figure out this issue?

You're almost there, but you want to return just the vr ('US' in your example) from the callback. Also, because there are so many tags, I'd recommend something like the following to use the dictionary I mentioned above--that way you don't have to add every tag you use to the callback (they're already there). Assuming you've pasted that TAG_DICT somewhere:
var dicomFileAsBuffer = new Uint8Array(arrayBuffer as ArrayBuffer);
const dataSet = dicomParser.parseDicom(dicomFileAsBuffer, {
      vrCallback(tag) {
        const formatted = `(${tag.substr(1, 4)},${tag.substr(5,9)})`;
        return !!TAG_DICT[formatted] ? TAG_DICT[formatted].vr : undefined;
      },
    });
let tags = dicomParser.explicitDataSetToJS(dataSet);
console.log(tags["x00280011"]);

Hi @yagni,
I followed your advice and copied TAG_DICT file in my project.
then I did the same code as you provide above, but we still get the same issue. Because in the dataset there is still some elements that miss vr attribute.
yes, we can get almost vrs via TAG_DICT[formatted].vr,

But the result (I console.log(dataset)) is the same as if I had not used the vrCallback option. That means the vrs we haven't returned to the dataset. here are both datasets I logged:

without using  vrCallback(tag):

using  vrCallback(tag):

I guess if I correctly returned the vrs, it must be shown in the dataset and with vr attribute in each element, right?
Do you know what's wrong here?

here is my code:

import { TAG_DICT } from "../lib/dicom_pharser_dictionary";

var dicomFileAsBuffer = new Uint8Array(arrayBuffer as ArrayBuffer);
const dataSet1 = dicomParser.parseDicom(dicomFileAsBuffer);
console.log(dataSet1);

const dataSet = dicomParser.parseDicom(dicomFileAsBuffer, {
      vrCallback(tag) {
        const formatted = `(${tag.substring(1, 5)},${tag.substring(5, 9)})`;

        // console.log(!!TAG_DICT[formatted] ? TAG_DICT[formatted].vr : undefined);

        return !!TAG_DICT[formatted] ? TAG_DICT[formatted].vr : undefined;
      },
    });
let tags = dicomParser.explicitDataSetToJS(dataSet);
console.log(tags["x00280011"]);

And here is the Dicom file I used.
Thanks so much!

@LinkunGao After digging in the code, it looks like I only ever hooked up the VR callback to sequence parsing, not every implicit element. I'll get a PR through in the next week or so to fix this.

@LinkunGao Please try with the latest release--this should work much better. The explicitDataSetToJs and explicitDataSetToJson examples have been updated with code similar to what we talked about. I also realized the tag needed to be upper cased:
const formatted = `(${tag.substr(1, 4).toUpperCase()},${tag.substr(5,9).toUpperCase()})`;


checking mounted before calling setState

Hello. I noticed that once the parent widget containing your Crop widget is disposed of, there's an error that is thrown because you are trying to set a state on a disposed context. I at this moment checked on the mounted conditions before calling setState

@shadiG Thank you for making this pull request. After thinking about this error, I decided to check only right after .then() is called rather than checking before all the setState. I'm glad if you check my pull request https://github.com/chooyan-eng/crop_your_image/pull/126.


Change to NetCDF library behavior specifying read with strides

Reported by ansley b manke on 14 Aug 2012 21:39 UTC
For some OPeNDAP urls, a request with striding which worked with NetCDF versions previous to NetCDF4.2, fails when using NetCDF 4.2
The API for reading data with strides is to specify index values: start, count, and stride.  When start+(stride*count) is larger than the highest index on the time axis, previously we were returned data at the start of each of those intervals. Now it seems to want to have two complete strided timesteps.
So if the data is say, daily data with 365 days, we could ask for sst[L=288:352:30] and get back data in mid-October, mid-November and mid-December. With NetCDF 4.2, it seems that the request works only if there is 30 days on the time axis AFTER the last requested timestep.
I've reported this to Unidata and they're working on it.
Migrated-From: http://dunkel.pmel.noaa.gov/trac/ferret/ticket/1957

Comment by ansley.b.manke on 11 Dec 2012 18:54 UTC
An example is this.  The data is monthly:
yes? use "http://data1.gfdl.noaa.gov:8380/thredds3/dodsC/dc_CM2.1_R1_Cntr-ITFblock_monthly_ocean_tripolar_01010101-02001231"

yes? sh grid so
    GRID GGU6
 name       axis              # pts   start                end
 LON       LONGITUDE          360mr   0.5E                 0.5W
 LAT       LATITUDE           200 i   81.5S                89.5N
 DEPTH     DEPTH (m)           50 i-  5                    5316.4
 TIME      TIME              1200 i   16-JAN-0101 12:00    16-DEC-0200 12:00
 normal    E
 normal    F

yes?  list so[            VARIABLE : Salinity (1e-3)
             DATA SET : GFDL CM2.1, Closed ITF Experiment
             FILENAME : dc_CM2.1_R1_Cntr-ITFblock_monthly_ocean_tripolar_01010101-02001231
             FILEPATH : http://data1.gfdl.noaa.gov:8380/thredds3/dodsC/
             SUBSET   : 101 points (TIME)
             CALENDAR : NOLEAP
             LONGITUDE: 60.5W
             LATITUDE : 29.5N
             DEPTH (m): 5
                          60.5W
                         300
 16-AUG-0192 12 / 1100:  37.08
 16-SEP-0192 00 / 1101:  37.14
 16-OCT-0192 12 / 1102:  37.13
 16-NOV-0192 00 / 1103:  37.07
 16-DEC-0192 12 / 1104:  36.99
 16-JAN-0193 12 / 1105:  36.90
 15-FEB-0193 00 / 1106:  36.80
...
 16-JUL-0200 12 / 1195:  36.96
 16-AUG-0200 12 / 1196:  37.05
 16-SEP-0200 00 / 1197:  37.08
 16-OCT-0200 12 / 1198:  37.04
 16-NOV-0200 00 / 1199:  36.94
 16-DEC-0200 12 / 1200:  36.90

If we want every August value, we'd like to be able to say this - and the library would sort out where to end the request, returning data from August 0192 through August 200. The netcdf4.1 library did let us do this.
yes?  list so[i=300,j=140,k=1,L=1100:1200:12](i=300,j=140,k=1,L=1100:1200]
)

but,

yes?  list so[error, unexpected WORD_STRING, expecting WORD_WORD
context: Error { code = 3; message = "Invalid Parameter Exception: DArrayDimension.setProjection: Bad Projection Request: stop >= size"^;};
 **netCDF error
             NetCDF: Malformed or inaccessible DAP DATADDS (OPeNDAP/netCDF Error code -73)
             Data set: http://data1.gfdl.noaa.gov:8380/thredds3/dodsC/dc_CM2.1_R1_Cntr-ITFblock_monthly_ocean_tripolar_01010101-02001231

Some requests return data, but the last point which should be valid data, is returned as zero:

es? list so[i=300,j=140,k=1,L=1100:1190:24](i=300,j=140,k=1,L=1100:1200:12]
syntax)
             VARIABLE : Salinity (1e-3)
                        regrid: on T
             DATA SET : GFDL CM2.1, Closed ITF Experiment
             FILENAME : dc_CM2.1_R1_Cntr-ITFblock_monthly_ocean_tripolar_01010101-02001231
             FILEPATH : http://data1.gfdl.noaa.gov:8380/thredds3/dodsC/
             SUBSET   : 4 points (TIME)
             CALENDAR : NOLEAP
             LONGITUDE: 60.5W
             LATITUDE : 29.5N
             DEPTH (m): 5
                 60.5W
                300
 AUG-0192 / 1:  37.08
 AUG-0194 / 2:  36.88
 AUG-0196 / 3:  36.84
 AUG-0198 / 4:   0.00

Comment by steven.c.hankin on 11 Dec 2012 19:06 UTC
This trac ticket is 4 months old.  At the time of the ticket the problem had been reported to Unidata.  Haven't they released a net netCDF library since that time?  Have we heard back from them?

Comment by ansley.b.manke on 11 Dec 2012 20:44 UTC
The last release from Unidata was August 3. In Sept, in an exchange with Dennis he said he has a fix for this. I've prodded him a couple times, and just wrote him again.

Comment by ansley.b.manke on 18 Dec 2012 21:52 UTC
Unidata does have a fix for this in their code base. I verified it using their daily snapshot releases.  Dennis Heimbigner says,
... we are going thru the process of releasing netcdf 4.3, but it may be a couple of weeks. but it may be a couple of weeks. We are teaching our newest team member (Ward Fisher) how to do it and he will, of course, make some errors along the way.
Nice to hear they're getting some more people on board.


Kafka service

An example kafka service added to services. It simply produces values in groupby or timeseries statistics response to a specified topic in a kafka cluster. Documentation updated.

LGTM


Track how many times a post has been viewed

View count will only be incremented when viewing a thread, this includes thread dialogs.

document how views are arrived at:

replies
upvotes
etc


{Compute} az vm update -g myResourceGroup -n myVmName --license-type SLES: Rename SLES_STANDARD license type to SLES

Description

This renames the SLES_STANDARD license type to SLES. There is no longer multiple SLES tiers and this serves to reduce confusion around choosing the right tier. This license type 'SLES_STANDARD` is not currently used yet as the AHB feature for BYOS is not live yet.
Testing Guide

az vm update -g myResourceGroup -n myVmName --license-type SLES
History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change
[Component Name 2] az command b: Add some customer-facing feature

This checklist is used to make sure that common guidelines for a pull request are followed.

[x] The PR title and description has followed the guideline in Submitting Pull Requests.

[x] I adhere to the Command Guidelines.

[x] I adhere to the Error Handling Guidelines.

@mathapli @simratsatia

Compute

I think this is a breaking change, so I have modified the PR title.
@zhoxing-ms,
Please take a look.

Let us wait on this one for now
@jamesongithub we will need all changes in backend teams before we allow it here. Will take end of month.

Sure, will let you coordinate. This was just in preparation.


How to Save State Information

This is a great component Scott. Thank-you for the time you've put into it.
When you have a chance would you be able to go into more detail on how to save the state of the drag and drop.
For instance, let's say you have a project table in dataverse that has many related tasks in a tasks table. When the project is selected in the powerapp the related tasks would show up in the master drop zone of the Kaban board. After you drag and drop / reorder the relates tasks how is that state saved back so that when a user selects the project  the related tasks have the previous drag and drop state?
I will have a look at your other videos in case you addressed this anywhere else.
Thanks again for your time on this stuff it's great!

Hi @365ging - thanks for giving the component a spin!
I show how to save state in this video - https://youtu.be/wkHvjusgLEE


Conductor credentials don't work for me

Hi ! Up full stack:
docker-compose -f full-stack.yml up
Tried to sign in local conductor with credentials from README:
login<EMAIL_ADDRESS>password: admin
But it's not work

Hi @Anton-Bondar,
The default username for Conduktor-platform when using the full-stack.yml config is Username<EMAIL_ADDRESS>Password:admin .  You can verify the config at https://github.com/conduktor/kafka-stack-docker-compose/blob/master/full-stack.yml#L148


bodoni

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 51b70bab-10dd-ec81-d2f3-87c7a7a353c6
Version Independent ID: 7ff686b5-5975-0f6c-fc59-586f65b947f9
Content: Bodoni MT font family - Typography
Content Source: typographydocs/font-list/bodoni-mt.md
Product: typography
GitHub Login: @alib-ms
Microsoft Alias: alib

No actionable feedback, therefore, closing.


WIP: SCSI persistent reservation and pr-helper daemon

What this PR does / why we need it:
This PR adds the deployment of the qemu-pr-helper daemon inside the virt-handler pod. The pr-helper socket must be mounted by virt-handler if the VM requests the SCSI persistent reservation.
VMI example:
    devices:
      disks:
      - name: mypvcdisk
        lun:
          reservations: true

I created a new pkg called daemons if eventually in the future we want to support other privileged daemons. Libvirt supports various kinds of daemons that can be started externally, like virtiofsd, qemu-pr-helper, dbus (here to have an overview). Some daemons are already used in KubeVirt like virtiofs. However, in the case of the pr-helper daemon, it requires executing privileged operations and cannot be deployed directly inside the virt-launcher pod. The pr-helper can serve multiple VMs and the communication with the unprivileged guest occur through the pr-helper socket.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #8115
Special notes for your reviewer:
This is still work-in-progress. Missing pieces:

adding feature gate
possibly integrate the targetcli in the vm-killer image. Currently, I'm using an external image
update the VM fedora containerdisk to include the sg3 utils
finish to implement the functional tests to test the persistent reservation with the sg3 utils. The steps are described here

Release note:

Add support for SCSI persistent reservation

@qinqon I tried to bump the kubevirtci version with hack/bump-kubevirtci.sh however the fedora-test-tooling doesn't contain the sg3 utils added by https://github.com/kubevirt/kubevirtci/pull/842. Have you already built a kubevirtci with that change? Or how do I understand what is the right image to use? thanks!

@qinqon I tried to bump the kubevirtci version with hack/bump-kubevirtci.sh however the fedora-test-tooling doesn't contain the sg3 utils added by kubevirt/kubevirtci#842. Have you already built a kubevirtci with that change? Or how do I understand what is the right image to use? thanks!

We don't have automatization for the fedora-test-tooling so the image has to be build and pushed manually.

@qinqon I tried to bump the kubevirtci version with hack/bump-kubevirtci.sh however the fedora-test-tooling doesn't contain the sg3 utils added by kubevirt/kubevirtci#842. Have you already built a kubevirtci with that change? Or how do I understand what is the right image to use? thanks!

We don't have automatization for the fedora-test-tooling so the image has to be build and pushed manually.

Ok thanks, whom can I ask to build and push the updated image?

@qinqon I tried to bump the kubevirtci version with hack/bump-kubevirtci.sh however the fedora-test-tooling doesn't contain the sg3 utils added by kubevirt/kubevirtci#842. Have you already built a kubevirtci with that change? Or how do I understand what is the right image to use? thanks!

We don't have automatization for the fedora-test-tooling so the image has to be build and pushed manually.

Ok thanks, whom can I ask to build and push the updated image?

The #kubvirtci channel at coreos slack

I'm trying to add the targetcli to the testimage base
diff --git a/hack/rpm-deps.sh b/hack/rpm-deps.sh
index 0182f78be..2b998eec8 100755
--- a/hack/rpm-deps.sh
+++ b/hack/rpm-deps.sh
@@ -54,6 +54,10 @@ testimage_base="
   util-linux
   which
   tar
+  targetcli
+  python3-pyudev
+  systemd-devel
+  systemd-libs
 "

However, targetcli cannot find the udev libs even if it is installed in the container.
bash-4.4# targetcli
Traceback (most recent call last):
  File "/usr/bin/targetcli", line 24, in <module>
    from targetcli import UIRoot
  File "/usr/lib/python3.6/site-packages/targetcli/__init__.py", line 18, in <module>
    from .ui_root import UIRoot
  File "/usr/lib/python3.6/site-packages/targetcli/ui_root.py", line 30, in <module>
    from rtslib_fb import RTSRoot
  File "/usr/lib/python3.6/site-packages/rtslib_fb/__init__.py", line 24, in <module>
    from .root import RTSRoot
  File "/usr/lib/python3.6/site-packages/rtslib_fb/root.py", line 28, in <module>
    from .node import CFSNode
  File "/usr/lib/python3.6/site-packages/rtslib_fb/node.py", line 23, in <module>
    from .utils import fread, fwrite, RTSLibError, RTSLibNotInCFS
  File "/usr/lib/python3.6/site-packages/rtslib_fb/utils.py", line 32, in <module>
    _CONTEXT = pyudev.Context()
  File "/usr/lib/python3.6/site-packages/pyudev/core.py", line 64, in __init__
    self._libudev = load_ctypes_library('udev', SIGNATURES, ERROR_CHECKERS)
  File "/usr/lib/python3.6/site-packages/pyudev/_ctypeslib/utils.py", line 56, in load_ctypes_library
    raise ImportError('No library named %s' % name)
ImportError: No library named udev
Exception ignored in: <bound method Context.__del__ of <pyudev.core.Context object at 0x7f7c77424f28>>
Traceback (most recent call last):
  File "/usr/lib/python3.6/site-packages/pyudev/core.py", line 68, in __del__
    self._libudev.udev_unref(self)
AttributeError: 'Context' object has no attribute '_libudev'

Using dockerfiles, it works, so there should be some conflicts how the image is built with bazel.
Any bazel exports that can point me to the right direction :). Maybe @rmohr have you already got a similar issue with running python scripts in an image built with bazel

/remove-lifecycle stale
This PR is still the reference for one of the possible scsi persistent reservation implmentation

Closing this PR in favor of https://github.com/kubevirt/kubevirt/pull/9177