Cmdlets take too long for execution

Hi Vadims,
I'm using cmdlet get-ca and it seems to take several minutes to finish execution. It takes around 20-25 minutes.
I checked this cmdlet and I realized it is using this class/method to get CA object "[PKI.CertificateServices.CertificateAuthority]::EnumEnterpriseCAs".
I tried two different Enterprise CAs with same hardware and OS (ws2012R2), and one of them is finishing in just 1 second but the other one seems to get stucked.
Do you know if it takes into account CA database size, crl size, remote registry, or any other component from CA that could be the reason? configuration between CAs are similar (ocsp, aia/cdp extensions,...).
I really appreciate you help.
Thanks.

I am having the same problem. On one server the Get-CertificationAuthority takes about 8 seconds to complete, on another it is taking 50+ minutes.
This has started within the past 2 months based on the last time I worked against the server. What protocols are used to do the connections?

That is exactly what I needed. I am sure it is an issue on the server (probably a patch that didn't get installed properly), now I where to dig deeper. Thanks!

When running Connect-CertificationAuthority -ComputerName server.fqdn -Verbose -ErrorAction "Stop" while logged onto the server locally:
PS>TerminatingError(New-Object): "Exception calling ".ctor" with "1" argument(s): "CCertConfig::GetField: The parameter is incorrect. 0x80070057 (WIN32: 87 ERROR_INVALID_PARAMETER)""

TerminatingError(New-Object): "Exception calling ".ctor" with "1" argument(s): "CCertConfig::GetField: The parameter is incorrect. 0x80070057 (WIN32: 87 ERROR_INVALID_PARAMETER)""
TerminatingError(): "Error connecting to server.fqdn"
TerminatingError(): "Error connecting to server.fqdn"

Any idea what is happening?

Does the command succeed when you call it without -ErrorAction parameter?
Also, post stacktrace after exception:
$error[0].Exception.InnerException.StackTrace

TerminatingError(New-Object): "Exception calling ".ctor" with "1" argument(s): "CCertConfig::GetField: The parameter is incorrect. 0x80070057 (WIN32: 87 ERROR_INVALID_PARAMETER)""

TerminatingError(New-Object): "Exception calling ".ctor" with "1" argument(s): "CCertConfig::GetField: The parameter is incorrect. 0x80070057 (WIN32: 87 ERROR_INVALID_PARAMETER)""
at CERTCLILib.CCertConfigClass.GetField(String strFieldName)
at PKI.CertificateServices.CertificateAuthority.get_ds()
at PKI.CertificateServices.CertificateAuthority.initialize()
TerminatingError(): "Error connecting to server.fqdn"

First of all: it seems that you are not using the most recent version of PSPKI module.  Based on your stack trace, I can say that you are using version which is at least 2yrs old. Generally, I support only last two versions. I would suggest to get the latest version from PS gallery on offline zip package. All information can be found on main page.
Anyway, this error proves that you have some broken or corrupt CA registration entries in Active Directory. Can you review contents of the following DS container:
CN=Enrollment Services, CN=Public Key Services, CN=Services, {ConfigurationNamingContext}

I have 3.2.5 on my server, 3.3.0 is available, but I cannot install it on my server till the issue is gone due to infrastructure controls.
Interestingly the command completes without error when I run it from another machine. Still takes 45 minutes, but it completes without error.

What about DS entries I asked earlier?
p.s. I'm afraid, but there is no chance that you will get fix without upgrading to the most recent module version.

Closing as non-constructive. I asked several times about DS objects and get no response. Once you can proceed with this issue, just reply to this thread.

Yes, I am able to enumerate the item
distinguishedName  : CN=ADICA v2,CN=Enrollment Services,CN=Public Key
Services,CN=Services,CN=Configuration,DC=,DC=,DC=com
name               : ADICA v2
objectClass        : pKIEnrollmentService

Holiday weekend here in the States, sorry for the slow reply.

I don't think having 3.3.0 on the server will change the issue.
I am using pspki for remote management from an automation server, and that server does have 3.3.0 with the 45+ minute Connect-CertificationAuthority run time.
I was trying to run it locally to see if it exhibited the same problem to rule out network issues. Since the problem exists on one of two servers, using both in 3.2.5 and 3.3.0, I don't believe it to be an issue with pspki but something on the server.
We did a delegation on our CAs and in Active Directory for a PKI admin group early this year, but haven't have a problem with any of the scripts till now. The last time I used pspki against the server was in June, and there were no issues then. I have another script using certreq against the CA that has no issues.
The Certificate authority mmc is fine, no problems there.

What type is the CA you are trying to connect to? Standalone, Enterprise?

Enterprise CA. The standalone has no problems.

I assume that you have only single Enterprise CA in your AD forest? If so, then can you confirm that your CA entry in CN=Enrollment Services DS container has dnsHostName attribute and its value is not null or empty and points to the right server name?

Correct, one integrated Certificate Authority, dNSHostName is present and correct. DNS is correct.

Ok, can you execute the following commands on a computer where the command throws exception:
$CertConfig = new-object -com certificateauthority.config
Write-Host "Count: " $CertConfig.Reset(0)
while ($CertConfig.Next() -ge 0) {
    $flags = $CertConfig.GetField("flags")
    $server = $CertConfig.GetField("server")
    Write-Host "Flags: $flags, server: $server"
}

And post the output.

Count:  1
Flags: 13, server: server.fqdn

Then the stack trace you provided in https://github.com/Crypt32/PSPKI/issues/46#issuecomment-417522164 is not correct.

Not sure what that indicates as it is the error that was returned.

Then there is missing something. You must run this PowerShell code in exact scenario when module throws error: same machine and same user account.

The only difference is this was executed from a scheduled task instead of interactive:
Count:  1
Flags: 12, server: server.fqdn

Make sure that "enable highest priveleges" checkbox is enabled in scheduled task.

Ok, I have an update.
I installed 3.3.0 on the server and am running the task as system. Concurrently I am running the commands remotely using a CA administrative account.
The Connect-CertificationAuthority completed without error, but it still takes >45 minutes to complete.
Now, when I get to the following command I get a large number of errors:
Get-IssuedRequest -CA $caADICA -Filter "CertificateTemplate -eq $template" -properties upn, certificatetemplate, DistinguishedName
Exception calling "Add" with "2" argument(s): "An item with the same key has already been added."
At C:\Program Files\WindowsPowerShell\Modules\PSPKI\<IP_ADDRESS>\Server\Get-RequestRow.ps1:121 char:13
+             $Row.Properties.Add($colName, $colVal)
+             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (:) [], MethodInvocationException
    + FullyQualifiedErrorId : ArgumentException
Exception calling "Add" with "2" argument(s): "An item with the same key has
already been added."
At C:\Program
Files\WindowsPowerShell\Modules\PSPKI\<IP_ADDRESS>\Server\Get-RequestRow.ps1:121
char:13
+             $Row.Properties.Add($colName, $colVal)
+             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (:) [], MethodInvocationException
    + FullyQualifiedErrorId : ArgumentException

The call does return the records once the errors complete. This happened on both the server as system and using my CA administrative account when running remote.

Both as a task and when running interactively. Remote or local does not change the issue.

If Connect-CertificationAuthority now executes without exceptions, you will have to profile method chain call to determine which code line (or lines) hangs. You will have to download sources, compile them and perform code profiling/debugging. There is nothing I can suggest, because I can't repro this issue.

Ok, engaging MS. I'll let you know what is found.

Hello Vadims
I had similar issues as Jay-Armstrong when using Connect-CertificationAuthority.
The problem I have is, one of the CAs at the customer is used only for webenrollment (lets call it WebCA) and not exposed to the intranet. The third party WebRA is located in the same DMZ like network as the "WebCA" and uses RPC to connect.
The WebRA can be reached from the Intrant.
The WebCA can't be reached.
The WebRA is configured as normal Enrollment CA with all it's data in Active Directory. It can therefore be discovered using CertificateAuthority.Config com object.
From how I understand your code, Connect-CertificationAuthority is doing the following:

calling PKI.CertificateServices.CertificateAuthority.
1.1 Verify if the server is online within PKI.CertificateServices.CertificateAuthority, using RegistryOnline = CryptoRegistry.Ping(computerName);
1.1.1 Tries to open the registry RegistryKey key = RegistryKey.OpenRemoteBaseKey(RegistryHive.LocalMachine, computerName);.
-> Opening the registry over the network takes quite some time. Especially if it fails due to some network / firewall issues.
1.2 Even if the remote registry fails, testing if the CA is online IsAccessible = Ping(computerName);
1.3 Try to find server in AD lookInDs(computerName);
1.3.1 Verify if client reaches any DC ActiveDirectory.Ping()
<IP_ADDRESS> By getting its current domain Domain.GetCurrentDomain().Name
1.3.2 When a host name is used, it is changed by adding current domain name
-> This is a objectionable assumption and only valid in single domain forest! In a multidomain forest it cannot be assumed that the current logged on account returns the same domain name as the CA is using.
-> If the account used to administer / access the CA, the current domain is the child domain but the the CA might be located in the root domain.
-> Better option is search AD configuration context for enrollment server or global catalog for server name or use DNS to resolve hostname
1.3.3 Loop thru each FQDN found in _certConfig.
1.3.4 Building CA configuration information
Now it gets a bit complicated, but depending on previous tests, you search again AD or get infos directly from CA.

Without a server name this process happens against each CA defined in AD.
Using servername parameter it retrieves a single server but does the same process.
The problem is, the process requires multiple connections against each server, even before knowing if the server does exist in AD or the name can be resolved.
This leads to slow performance.
Based on above description (and I'm not saying that my quick analysis is correct), I think the PSPKI module assumes / require the following to work correct:

The current user has at least auditor rights in order to retrieve the CA certificate (Using CertAdmin interface instead of CertificateAuthority.Request)
The current logged on user is in the same domain as the CA (appending current domain dns name to host name in lookInDs Method of CertificateAuthority object)
The current logged on user has local admin rights to the CA (trying to access remote registry)
It is running in a single domain forest (using current domain, LDAP and serverless bindings)

I think there are some quick fixes to improve the performance and some changes that requires some design changes.
I would be happy to support you if you are interested.
Kind regards
Patrick

First of all, thanks for joining to discussion, because it helps in code review and issue detection!

-> Opening the registry over the network takes quite some time. Especially if it fails due to some network / firewall issues.

yes, it is correct. You may expect delays (not very big) when remote registry or RPC/DCOM is not available for any reason. The only reliable way to check them is to attempt to connect and look for response. If response fails (timeout, or whatever other reason), I mark this access interface as unavailable.

-> This is a objectionable assumption and only valid in single domain forest! In a multidomain forest it cannot be assumed that the current logged on account returns the same domain name as the CA is using.
-> If the account used to administer / access the CA, the current domain is the child domain but the the CA might be located in the root domain.
-> Better option is search AD configuration context for enrollment server or global catalog for server name or use DNS to resolve hostname
1.3.3 Loop thr
u each FQDN found in _certConfig.
1.3.4 Building CA configuration information
Now it gets a bit complicated, but depending on previous tests, you search again AD or get infos directly from CA.

I can't agree with this part. If you take a look at this line: https://github.com/Crypt32/pkix.net/blob/5b0217f1b32897b21ce831ce2ca22c1a7cf912c4/PKI/CertificateServices/CertificateAuthority.cs#L162
I'm appending current domain name only when input name doesn't include dot character. Name without dots is short or NetBIOS name. So when short/NetBIOS name is specified in parameters, we expect to find it in the current domain. In fact, it is what DNS client does in domain environment by deault:

So, I think it is ok to use current domain when no explicit domain (in FQDN form) is specified. When name is specified in FQDN form, I use provided name to perform host search. Eventually, I will end up in right domain.

Without a server name this process happens against each CA defined in AD.

can you clarify what do you mean? There is no constructor that would accept null or empty server name. Connect-CertificationAuthority defaults to local computer when server name is not specified. Another story is with Get-CertificationAuthority, which performs these steps for each CA found in Active Directory. It is what everyone would expect, since this cmdlet returns CAs registered in Active Directory.

The problem is, the process requires multiple connections against each server, even before knowing if the server does exist in AD or the name can be resolved.

This behavior was designed this way to support Standalone CAs which are not registered in AD as enrollment service. As the result, I have to attempt to connect to specified host even if it is not registered in AD.
I'm not sure if there is a way to reduce the amount of connections I'm doing right now. Anyway, in lab I keep decommissioned CA record in AD and combined delays from all connections barely exceed 1-2 minutes. It is acceptable delay unless there are better ways to determine if specified host exist, is CA and can be connected to.

I think there are some quick fixes to improve the performance and some changes that requires some design changes.

I'm open to any good ideas.

Hello Vadmis
Thank you for taking time to provide feedback on my comments.

[Patrick] -> Opening the registry over the network takes quite some time. Especially if it fails due to some network / firewall issues.
[Vadims] yes, it is correct. You may expect delays (not very big) when remote registry or RPC/DCOM is not available for any reason. The only reliable way to check them is to attempt to connect and look for response. If response fails (timeout, or whatever other reason), I mark this access interface as unavailable.

True, and you return this information in your PKI.CertificateServices.CertificateAuthority object.
But you explicitly state in your script (running on offline, non domain joined CA or computer) "Non-domain environments are not supported." We could therefore consider that CAs in scope must be registered in AD, one way or another, even if not registered as Enrollment CA. Therefore if a server does not exist in AD, (has a computer object in AD and, in case it is really a CA, has an PKI-Enrollment-Service object registered in AD)  you don't even have to try to test if registry is online or if CA is accessible.
Trying to reach a specific CA, short delays are not an issue. Looping through all CA are.
So why not considering changing the order of events?

First query AD for enrollment server
Then test the interfaces

I can't agree with this part. If you take a look at this line: https://github.com/Crypt32/pkix.net/blob/5b0217f1b32897b21ce831ce2ca22c1a7cf912c4/PKI/CertificateServices/CertificateAuthority.cs#L162

So when short/NetBIOS name is specified in parameters, we expect to find it in the current domain. In fact, it is what DNS client does in domain environment by deault

This is not the same, you compare apple with pies.
DNS client is adding machines connection specific suffix and is also using devolution. In case you are in a child domain, the following happens:
Netbios name to resolve: CA1
Primary Suffix: CHILD1.ROOT.COM

try lookup CA1.CHILD1.ROOT.COM
if failed
try lookup CA1.ROOT.COM
So you get the name of CA1 even if your client is member of the child domain.
If you are using a connection specific suffix, DNS resolver even tries that.
You may use nslookup interactively and use "set db2" to get all the lookups when trying to resolve a hostname
https://searchwindowsserver.techtarget.com/tip/How-DNS-devolution-works-in-Windows-Server-2008-R2

But what you are doing is adding the current user domain suffix by using 'directoryservices.activedirectory.domain.getcurrentdomain'.
https://docs.microsoft.com/en-us/dotnet/api/system.directoryservices.activedirectory.domain.getcurrentdomain
Therefore, if the CA admin/operator is member of the child domain, using hostname will never return a CA.

Without a server name this process happens against each CA defined in AD.

OK, what I mean is exactly what you describe. Using Get-CertificationAuthority without parameter lists all CAs found in AD. So if AD contains lots of dead entries, it takes quite some time to return. An option would be to add a new parameter "-NoIsOnlineCheck". You could then still return all information stored in AD like the CA certificates. You may not get CRLs as you need to get the CDP stored in a certificate (ie CAExchangeCert) or from the CA itself as you already do (if it is online....)
I attached some LDAP logs. So certutil config only returns CA registered as enrollment server.
But you are right, to test an interface you need to connect to it. And only because one interface is down (not accessable), doesn't mean the other interface is down as well.
Testing_Get-CertificationAuthority.txt
BTW: what makes RPC horrible slow is when port 135 is accessible but the RPC interface itself is not. This happens often when using bad FW configurations. But that is not your problem.
I also attached my version of Get-CertificationAuthority based on an older PSPKI implementation that did not use the DLLs.
Get-CertificationAuthority.ps1.txt

Let me clarify some points.

We have two cmdlets, Get-CertificationAuthority and Connect-CertificationAuthority.
Get-CertificationAuthority is supported only in Active Directory and retrieves only Enterprise CAs registered in AD as enrollment servers.
2.1. Enterprise CA lookup starts with ICertConfig where I retrieve server's FQDN. There is no issue with short names, because they are not used.
2.2. Get-CertificationAuthority returns an array of CAs.
Connect-CertificationAuthority is intended to connect explicitly specified CA, whether it is Enterprise or Standalone CA.
3.1. When calling lookInDs, we check if server name is provided in NetBIOS of FQDN form.
3.2. If it is NetBIOS name, we append current domain name to it in order to get FQDN, then pass this name to ICertConfig. It is important to understand that ICertConfig may not return any matching records (for Standalone CAs), so I will have to deal with host name provided in parameters.
3.3. Connect-CertificationAuthority returns only single CA instance.

From what I understand, you suggest to not append current domain name, leave NetBIOS as is and let DNS client to perform host lookup. Is it correct? Ok, I can do it. However, ICertConfig may return multiple servers with same host name in different domains. What should I return in this case? Which CA?

Therefore, if the CA admin/operator is member of the child domain, using hostname will never return a CA.

I got your point. Yes, my intention was to add machine domain suffix to perform lookup, regardless of logged user's domain.

So if AD contains lots of dead entries, it takes quite some time to return. An option would be to add a new parameter "-NoIsOnlineCheck"

I don't think if it is a good idea. Basically, if you have lots of dead CAs, you need to perform AD cleanup from deads. They have no value by sitting in AD. Another thing is that when connecting to CAs I retrieve a lot of useful information, including service state.

Hello Vadims
Thank you for clarification. So far I used only Get-CertificationAuthority and assumed but never checked Connect-CertificationAuthority would be an alias.
Suggesting using DNS as one option for name resolution was a bad option. Your point.
directoryservices.activedirectory.domain.getcurrentdomain is only available in AD. Instead of appending current users domain do a quick onelevel search in configuration context for PKI-Enrollment-Service object. This contains the dNSHostName property your looking for.
To connect a domain joined standalone CA we can still query global catalog for server name (CN) and retrieve the dnsHostName property. But the search has to use GC to get the computer within the forest. If the Standalone CA is not domain joined, well, it may or may not be in the same DNS realm than the user trying to connect. In fact,Connect-CertificationAuthority does not support credentials, connecting an unjoined standalone CA will only work locally.
Best regards
Patrick

Thread wasn't updated for a long time.


feat(#30): dataset.py, train.py with torch and transformers

ref #30

PR-Codex overview
This PR introduces model training functionality using transformers and torch. It also refactors the code to include a Dataset class for formulating data.
Detailed summary

Added transformers and torch to requirements.txt
Refactored Input to Dataset in objects/cli.py
Implemented Dataset class for formulating data
Added model training functionality in model/train.py
Included a CustomDataset class for dataset preparation in model training
Updated and added test cases for Dataset in tests/test_dataset.py

The following files were skipped due to too many changes: tests/data.csv, tests/input.csv

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@rultor merge

@rultor merge

@h1alexbel OK, I'll try to merge now. You can check the progress of the merge here

@rultor merge

@h1alexbel Done! FYI, the full log is here (took me 13min)


Handle Deprecated Operation Types

https://github.com/MinaProtocol/mina/pull/15907/files#diff-74481279bb056609148ee774a64cb4a6fae9ee0cd9a74345cef99eb3f760909b

https://github.com/MinaFoundation/MinaMesh/pull/75 should close it.


DS-2218: Unable to use command "update-handle-prefix"

https://jira.duraspace.org/browse/DS-2218
Use the command "bin/dspace update-handle-prefix  " ends with the "ORA-00911: invalid character". The problem is the extra semicolon in sql command.
I made changes in formatting SQL.

Hmm, original code was for 4.x version:-(

The latest commit repairing update of metadata table. First prevent to update handle to NULL value, and then ensures the updating only data set corresponding to the original handle, not completely full metadata handle values.
Mergeable to dspace-4_x branch only (backport)! For master/dspace-5_x see #929.

Wrong target branch, rebased on dspace-4_x in #930.


Paths MAY contain fragments

This PR is based on discussion in https://github.com/OAI/OpenAPI-Specification/issues/1635
Paths MAY contain fragments as defined in RFC3986. Paths with different fragments are considered different.
This feature can be used to further divide resources under same endpoint.

This doesn't seem to address @darrelmiller's comment about how a server is supposed to understand this.  One thing paths are for is server-side routing, and servers don't see fragments and therefore would be unable to distinguish your two examples.

@handrews I think Specification Extensions can be used to solve this.

@link89 I don't see how.  The problem is that the fragment doesn't get sent to the server.  I mean, I guess if the point is to completely ignore the OAS spec on the server and only use it for documentation, then I suppose this is useful, but it definitely seems odd.  And makes it even more annoying that query params can't be managed in the path, although that's not your/this PR's problem.

I have elaborated on my concerns in the issue.  I do not think this topic is ready for a PR.

@link89 Can we close? I think the use-case is real, though, and it deserves a more engineered solution.


How do I update?

Running it on a synology which is GUI based. Little unclear on how to update my container

I never used a synology GUI but generally you just want to replace the image and keep volumes.

Personally, I would use the CLI to start/stop/restart. The GUI for Docker doesn't use the same terminology as the docker CLI, so it's not 100% clear to me what is going on.
Looking at it, use actions. "Stop" appears to be the same as "docker stop" which will NOT pull a new image when its changed. I tried "Clear" and it does NOT delete the saves/config/mods/etc., so it appears that "Clear" is the same as "docker rm".
So I would try "Stop" followed by "Clear" followed by "start", assuming you've set up the container to use "Latest".
Synology is making containers harder, not easier. Use the CLI.


Sample Dev-Radar integrated with GitHub

Q
A

Bug fix?
no

New feature?
no

New sample?
yes

Related issues?
fixes #X, partially #Y, mentioned in #Z

What's in this Pull Request?
Application that obtains the user's location and from the github login register in a sharepoint list.
Please refer to the readme for more information.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: SharePointAcademy sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

thx @SharePointAcademy, appreciated.

Thanks Vesa!


Codicons are not vertically centered

@misolori assigning first to you and feel free to assign back to me.

Debug two sessions such that the Debug Session is shown in the CallStack view
Hover over a session -> notice how the debug actions are not vertically centered

Easy way to debug two sessions:
Have the following test.js file:
console.log('hello');

Have the following launch.json and run both configurations:
{
    "version": "0.2.0",
    "configurations": [
        {
            "type": "node",
            "request": "launch",
            "name": "Launch Program",
            "program": "${workspaceFolder}/test.js"
        },
        {
            "type": "node",
            "request": "launch",
            "name": "Launch Program2",
            "program": "${workspaceFolder}/test.js"
        }
    ]
}

I made a recent a change (https://github.com/microsoft/vscode/commit/ee04d73ca9a83f422925738ca743e221b741623b) that removed the vertical alignment on codicons and used an alternate method via flexbox. However this caused some codicons in list views to be off-centered. I've updated it so that all codicons now use the same method.
Verification steps: verify that codicons are vertically centered in:

Debug viewlet w/ multiple debug sessions (see original post)

SCM actions

Custom views like Timeline and NPM Scripts

Looks good now, adding verified label. Thanks


bug/CE-551-Reduce spacing between lines and fix the error message behaviour

Description
This addresses the issue of inconsistent space between the elements in Assessment view mode. Also when errors appear, now the fields remain in line with the field label and the fields below are pushed down to make space for the error message.
Fixes # CE-551
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[x] Verify that vertical spacing in the Assessment section is consistent with other sections ( ex: Equipment)
[x] Check if the fields and labels are aligned correctly when validation error occurs

Checklist

[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

Further comments

Thanks for the PR!
Any successful deployments (not always required) will be available below.
Backend available
Frontend available
Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

@dmitri-korin-bcps I think the vertical spacing isn't quite right (at least on my monitor)

Also while talking to Dragos he found one more small thing which I added to the ticket,  the placeholder text "Select Date" should be "Select date"


update portfolio page

BUY SOV v1.2.2.zip
update the current "my wallet" section to the new design in this file

@pietro-maximoff absolutely killed it!
just got a msg from yago, asking to put RBTC at the top and SOV underneath.
also to please remove CSOV

added here #754


Is it possible to scroll by grabbing the scrollbar

It would be nice if it fully functions like a GUI scrollbar. Would it be possible to implement it? Similarly to minimap.vim

Sorry. No such plan. I've never used mouse control in vim. PR is welcome.

Sorry. No such plan. I've never used mouse control in vim. PR is welcome.

I'm not very experienced with git and nvim plugins. But I guess that for it to be possible it would have to be opened in a different buffer, like in a vertical split. Similar to the minimap

I'm not very experienced with git and nvim plugins. But I guess that for it to be possible it would have to be opened in a different buffer, like in a vertical split. Similar to the minimap

@ndavidpsi  scrollview is the same thing as this plugin but the scrollbar is transparent and dragable with mouse.


Must explicitly state ip_address for instance_profile_credentials even though it has a default value

Is your feature request related to a problem? Please describe.
I am trying to setup the logging operator output CRD to use the instance profile credentials to store logs to S3. From the README, I see that the instance_profile_credentials.ip_address has a default value of <IP_ADDRESS>. I would expect the following the output config to use the instance_profile_credentials IP since I don't specify other credential types
$ kubectl -n logging apply -f - <<"EOF"
apiVersion: logging.banzaicloud.io/v1beta1
kind: Output
metadata:
  name: s3-output
  namespace: logging
spec:
  s3:
    s3_bucket: my-s3-bucket
    s3_region: us-east-1
    path: logs/${tag}/%Y/%m/%d/
    buffer:
      timekey: 10m
      timekey_wait: 30s
      timekey_use_utc: true
EOF

But I see this in the operator logs which seems to imply I must provide the IP address explicitly for it to work?
{"level":"error","ts":1575326763.5315049,"logger":"controller-runtime.controller","msg":"Reconciler error","controller":"logging","request":"/default-logging-simple","error":"failed to create model: failed to create configured output s3-output: One of AssumeRole
Credentials or SharedCredentials or InstanceProfileCredentials must be configured","errorVerbose":"One of AssumeRoleCredentials or SharedCredentials or InstanceProfileCredentials must be configured\nfailed to create configured output s3-output
...

Describe the solution you'd like
Possible have a seaparte config value like instance_profile_credentials.enabled and use that to determine whether to use instance_profile_credentials.

@nitinmohan87 you have to specify the field with at least an empty map if all the attributes are optional like this:
spec:
  s3:
    instance_profile_credentials: {}

let us know, whether that worked for you or not!

@pepov That worked. I should have thought of that before creating the issue. Thanks!

@nitinmohan87 no problem, glad I could help!


Suppress peer dependency warnings for react-virtualized

In a package.json file, to customize dependency resolution, depending on the package manager:

npm :arrow_right: overrides
Yarn :arrow_right: resolutions

None of the above fields impact peer dependencies of consumed packages, since these don't impact dependency graph but only trigger warnings (log messages) when they are not met.

Codecov Report

Merging #98 (d96ecdb) into main (5eb4b35) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #98   +/-   ##
=======================================
  Coverage   18.06%   18.06%
=======================================
  Files          35       35
  Lines        1290     1290
  Branches      336      336
=======================================
  Hits          233      233
  Misses       1057     1057

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5eb4b35...d96ecdb. Read the comment docs.

/lgtm


[video_player]add option to set extractor flag for Android

Description
Some MP4/FMP4 files contain edit lists that rewrite the media timeline by skipping, moving or repeating lists of samples. ExoPlayer has partial support for applying edit lists.ExoPlayer add flat to skip using edit lists. You can get more detail from here.
This PR add AndroidVideoPlayerOptions to add addition optional player setting for android platform.
Setting AndroidVideoPlayerOptions.mp4ExtractorSkipEditLists to true to fix the issue: part of the media is unexpectedly missing or repeated.

I update dependency of video_player_platform_interface video_player_web to path temporarily.
flutter test fail for can't find VideoPlayerApiTest

Related Issues
flutter/flutter#64438
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
[x] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See [Contributor Guide]).
[ ] All existing and new tests are passing.
[x] I updated/added relevant documentation (doc comments with ///).
[ ] The analyzer (flutter analyze) does not report any problems on my PR.
[x] I read and followed the [Flutter Style Guide].
[x] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
[x] I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy].
[x] I updated CHANGELOG.md to add a description of the change.
[x] I signed the [CLA].
[x] I am willing to follow-up on review comments in a timely manner.

flutter analyze Logs
```
flutter analyze
Analyzing video_player...
error • Classes can only extend other classes • video_player/test/video_player_test.dart:612:39 • extends_non_class
error • The method 'VideoPlayerApiTestSetup' isn't defined for the type 'FakeVideoPlayerPlatform' • video_player/test/video_player_test.dart:614:5 • undefined_method
info • The method doesn't override an inherited method • video_player/test/video_player_test.dart:626:18 • override_on_non_overriding_member
info • The method doesn't override an inherited method • video_player/test/video_player_test.dart:637:8 • override_on_non_overriding_member
info • The method doesn't override an inherited method • video_player/test/video_player_test.dart:642:8 • override_on_non_overriding_member
info • The method doesn't override an inherited method • video_player/test/video_player_test.dart:648:8 • override_on_non_overriding_member
info • The method doesn't override an inherited method • video_player/test/video_player_test.dart:653:8 • override_on_non_overriding_member
info • The method doesn't override an inherited method • video_player/test/video_player_test.dart:658:19 • override_on_non_overriding_member
info • The method doesn't override an inherited method • video_player/test/video_player_test.dart:666:8 • override_on_non_overriding_member
info • The method doesn't override an inherited method • video_player/test/video_player_test.dart:672:8 • override_on_non_overriding_member
info • The method doesn't override an inherited method • video_player/test/video_player_test.dart:677:8 • override_on_non_overriding_member
error • Classes and mixins can only implement other classes and mixins • video_player_platform_interface/test/method_channel_video_player_test.dart:15:29 • implements_non_class
info • The method doesn't override an inherited method • video_player_platform_interface/test/method_channel_video_player_test.dart:24:18 • override_on_non_overriding_member
info • The method doesn't override an inherited method • video_player_platform_interface/test/method_channel_video_player_test.dart:31:8 • override_on_non_overriding_member
info • The method doesn't override an inherited method • video_player_platform_interface/test/method_channel_video_player_test.dart:37:8 • override_on_non_overriding_member
info • The method doesn't override an inherited method • video_player_platform_interface/test/method_channel_video_player_test.dart:42:8 • override_on_non_overriding_member
info • The method doesn't override an inherited method • video_player_platform_interface/test/method_channel_video_player_test.dart:48:8 • override_on_non_overriding_member
info • The method doesn't override an inherited method • video_player_platform_interface/test/method_channel_video_player_test.dart:54:19 • override_on_non_overriding_member
info • The method doesn't override an inherited method • video_player_platform_interface/test/method_channel_video_player_test.dart:61:8 • override_on_non_overriding_member
info • The method doesn't override an inherited method • video_player_platform_interface/test/method_channel_video_player_test.dart:67:8 • override_on_non_overriding_member
info • The method doesn't override an inherited method • video_player_platform_interface/test/method_channel_video_player_test.dart:73:8 • override_on_non_overriding_member
error • The function 'VideoPlayerApiTestSetup' isn't defined • video_player_platform_interface/test/method_channel_video_player_test.dart:112:7 • undefined_function
22 issues found. (ran in 5.6s)
<details>
## Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

- [ ] Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
- [x] No, this is *not* a breaking change.

<!-- Links -->
[issue database]: https://github.com/flutter/flutter/issues
[Contributor Guide]: https://github.com/flutter/plugins/blob/master/CONTRIBUTING.md
[Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[pub versioning philosophy]: https://www.dartlang.org/tools/pub/versioning
[CLA]: https://cla.developers.google.com/

Thanks for the contribution! I'm closing this PR because the code has moved quite a bit since this was posted originally, and there's probably major conflicts right now. I understand this is a requested issue here: https://github.com/flutter/flutter/issues/64438, just in case anybody else wants to freshen this up and bring it up to speed. For now, I'm closing this to tidy up our PR backlog. Thanks!

Thanks for the contribution! I'm closing this PR because the code has moved quite a bit since this was posted originally, and there's probably major conflicts right now. I understand this is a requested issue here: https://github.com/flutter/flutter/issues/64438, just in case anybody else wants to freshen this up and bring it up to speed. For now, I'm closing this to tidy up our PR backlog. Thanks!


AdmissionChecks should be configurable per flavor

What would you like to be added:
Allow AdmissionChecks to be required for a Workload if it gets assigned a specific flavor.
Why is this needed:
The user might want to only issue a ProvisioningRequest if targeting a specific flavor, or might want different engines.
Completion requirements:
This enhancement requires the following artifacts:

[x] Design doc
[x] API change
[x] Docs update

The artifacts should be linked in subsequent comments.

+1

/assign @PBundyra
/remove-lifecycle stale


Safe compress/delete in multi process environment

Consider case when application is running on Kubernetes. Number of pods may vary
With output file prefix equal to pod id, pod output files will not collide.
However, it is possible that 2 pods start a compression or deletion at the same time and they may modify the same files.
I think some kind of locks is required.
File API has a locking, but I heard behavior is OS specific. I'm also afraid that File API lock may not work in cloud volume world. Do you agree?
Other option is use file like /.lock as a semaphore. Can you share a best practice how to synchronize Java processes over semaphore file?

The easiest way to avoid collision is to set:

async-profiler.continuous.output-dir.continuous
async-profiler.continuous.output-dir.archive

To different paths. The path can contain pod id ant that solves the problem I believe.
Any locks on filesystem are hard to manage. You need to find a solution for "node that held the lock was killed" and so on. If you really need a functionality to save files to same directory from multiple JVMs then I believe this is better solution:
The library is aware of files that are generated:
        return String.format(
                "jfr,event=%s%s,file=%s/%s-%s.jfr",
                event,
                additionalParameters,
                notManageableProperties.getContinuousOutputDir(),
                event,
                date
        );

We can add in memory (concurrent) collection that will store files generated by single JVM. On that basis we can compress/delete/move to archive.

The easiest way to avoid collision is to set (output dirs) to different paths. The path can contain pod id ant that solves the problem I believe.

It is wrong idea to have directory per (temporal by nature) pod. There will be plenty of directories, hard to manage, hard to select by time.
When node is deleted, nobody will care to clean its output files, because its directory will not be assigned to any live pod.

You need to find a solution for "node that held the lock was killed" and so on.

That should not be so hard, lock may have a time limit. I bet this problem is already solved, but I could find a solution.
Anyway, for now I think best option is left compression and deletion unsafe. In worst case some profiler output files will be broken - acceptable.


Add appropriate cases to follow :: syntax

This looks good, but I'm confused by a couple of the others. I see for example you have LOWER_I but I don't know how you could get into that situation?

This looks good, but I'm confused by a couple of the others. I see for example you have LOWER_I but I don't know how you could get into that situation?

You're right, removed all of the extra ones. Unsure why the ubuntu builds are failing. Will look into them later today


Scrollbar is ugly when first start/open

When I open atom, and yes, it automatically open the last file I edited. But the problem is scroll bar is ugly (like standard scrollbar in google chrome). I must change to another tab and back to change the scrollbar.
I'm using ubuntu 14.04 (64bit) using atom 1.3.0-beta0 when i saw this error.

This looks like a duplicate of https://github.com/atom/atom/issues/9189


actions: cache rust builds

Hopefully this will add some much-needed performance improvements to our CI times!

Hmm strange. It cuts the CI times by about 50%. But there seem to be random bugs on macOS, and also I had an issue the first time where some jobs randomly failed in the post-run cache job (I think because too much got uploaded to new cache all at the same time).
So I don't really know whether the speedup, while nice, is worth the additional complexity...

I don't think we need to merge this ASAP. Optimistically, one of us will find the workaround eventually.

I don't think we need to merge this ASAP. Optimistically, one of us will find the workaround eventually.

Even though we can't yet enable for macOS, I think there's value in merging this now. Github actions seems to have a limit to the number of jobs running across all PRs in parallel, so when several PRs are pushed close together it can take some time for all the CI to run.
If we cache the windows and linux jobs, we'll get through all of these jobs faster, so we get feedback on CI faster.

Looks like you can workaround the macOS cache issue by using gnu-tar, see https://github.com/PyO3/maturin/pull/493


🚧Update github solution folders and items

I have done the items below . . .

[X] I have updated the title by replacing the '<title>' section.

Description
Add all of the various files and folders in the .gihub folder to the solution as solution folders and item references.  This is to make it easy to see and open the various folders and files in the solution.   This applies to both Visual Studio and Rider.
Currently is this:

Should be like this:

Acceptance Criteria
This issue is finished when:

[ ] Various folders and files in the .github folder added as solution items

ToDo Items

[ ] Draft pull request created and linked to this issue
[X] Priority label added to issue (low priority, medium priority, or high priority)
[X] Issue linked to the proper project
[X] Issue linked to proper milestone
[X] ~Unit tests have been written and/or adjusted for code additions or changes~
[X] ~All unit tests pass~

Issue Dependencies
No response
Related Work
No response

Can I hop on this? Against tomorrow?

Yes, go ahead.  When you create the pull request, this project is in the same situation currently as Velaptor.
Create the branch off of the release/v1.0.0 branch and the PR should merge it back into release/v1.0.0.
Thanks!!

Just to clarify. I need to create a SolutionItems folder and copy the content of  .github into it? If that is correct, can you explain this?

This is to make it easy to see and open the various folders and files in the solution. This applies to both Visual Studio and Rider.

I am trying to learn while making the little contribution that I can. I appreciate the links to the resources that you always reference in your messages. Thank you.

I apologize if you already know what the difference is between a solution folder in Visual Studio or JetBrains Rider and an actual folder on disk, but just in case you do not, I will explain it.
A solution folder is nothing but a virtual folder (not on disk), that is used by both IDEs to further organize things in your solution or project.  A file that is added to a solution folder is nothing but a pointer / reference to a real file on disk, and that pointer / reference is saved in the .sln file.
If you create a solution folder in any C# project using these IDEs, you will notice the GIT changes in your git client.
Basically I want to give the user/developer to easily open the files in the IDE, but they cannot do that unless they open it in some other editor OR just manually open it in the same IDE that they are in.  This is merely a convenience that we are introducing here.
If you want to see an example that is already setup, pull down the Velaptor project, checkout the v1.0.0-preview.3 branch, and open it in either IDE and you will see what I am going for.  Just copy what Velaptor has going on and your good to go.
I hope this clears things up!!  Let me know if you have anything else.


npm run production would not run as production mode, keeps running on development mode

Laravel Mix Version: 1.7.2 (npm list --depth=0)
Node Version (node -v): 8.2.1
NPM Version (npm -v): 5.3.0
OS: lsb_release -a

Description:
Hi fellows,
Recently I just found to run "npm run production" would not make my site with production mode. It was working fine but all of sudden, (maybe last Dec), it runs always as development mode.
For example,
I changed my .env file to "production" as below:
APP_ENV=production
APP_KEY=xxxx
APP_DEBUG=true
APP_LOG_LEVEL=debug
APP_URL=https://xxx.com

then
I run the command as npm run prod, instead of I am running always "npm run dev"
My package json file as below:
{
  "private": true,
  "dependencies": {
    "axios": "^0.15.3",
    "bootstrap": "^3.0.0",
    "bootstrap-sass": "^3.3.7",
    "casperjs": "^1.1.4",
    "chart.js": "^2.7.1",
    "cross-env": "^3.2.3",
    "emoji-mart-vue": "^1.0.4",
    "fullcalendar": "^3.7.0",
    "jquery": "^2.1.4",
    "js-cookie": "^2.2.0",
    "laravel-echo": "^1.3.2",
    "laravel-mix": "^1.7.2",
    "lodash": "^4.17.4",
    "moment": "^2.19.3",
    "promise": "^7.1.1",
    "pusher-js": "^4.2.1",
    "sweetalert": "^1.1.3",
    "underscore": "^1.8.3",
    "urijs": "^1.19.0",
    "vue": "^2.5.9",
    "vue-beautify": "^1.1.3",
    "vue-resource": "^1.3.4",
    "vue-sortable": "^0.1.3",
    "vue-template-compiler": "^2.5.9",
    "vue-touch": "^2.0.0-beta.4",
    "vuedraggable": "^2.15.0",
    "vueify": "^9.4.1",
    "vuetify": "^0.17.4",
    "vuex": "^2.5.0",
    "webpack": "^3.10.0",
    "webpack-dev-server": "^2.9.7"
  },
  "scripts": {
    "dev": "npm run development",
    "development": "cross-env NODE_ENV=development node_modules/webpack/bin/webpack.js --progress --hide-modules --config=node_modules/laravel-mix/setup/webpack.config.js",
    "watch": "cross-env NODE_ENV=development node_modules/webpack/bin/webpack.js --watch --progress --hide-modules --config=node_modules/laravel-mix/setup/webpack.config.js",
    "watch-poll": "npm run watch -- --watch-poll",
    "hot": "cross-env NODE_ENV=development node_modules/webpack-dev-server/bin/webpack-dev-server.js --progress --inline --hot --config=node_modules/laravel-mix/setup/webpack.config.js",
    "prod": "npm run production",
    "production": "cross-env NODE_ENV=production node_modules/webpack/bin/webpack.js --progress --hide-modules --config=node_modules/laravel-mix/setup/webpack.config.js"
  },
  "devDependencies": {
    "babel-preset-stage-2": "^6.24.1",
    "less": "^2.7.3",
    "less-loader": "^4.0.4",
    "vue-loader": "^13.5.0"
  }
}

and of course my "app.js" file is minified as production mode.
but, my chrome browser (I cleaned all caches manytimes and tried) shows always as follwing:
"You are running Vue in development mode.
Make sure to turn on production mode when deploying for production.
See more tips at https://vuejs.org/guide/deployment.html"
Did anyone has the same problem like me?
Steps To Reproduce:
I tried many times with new servers, new package.json, install all nodes as whole new, clean node modules's caches, non of them working.
Here is my index file that will render a site:
<!DOCTYPE html>

    <meta charset="utf-8">
    <meta http-equiv="X-UA-Compatible" content="IE=edge">
    <meta name="viewport" content="width=device-width, initial-scale=1.0">
    <title></title>

    <link href='https://fonts.googleapis.com/css?family=Open+Sans:300,400,600' rel='stylesheet' type='text/css'>

    <link href="/css/sweetalert.css" rel="stylesheet">
    <link href="/css/jquery.datetimepicker.min.css" rel="stylesheet">
    @if(app('env') == 'production')
    <link href="{{ mix('css/app.css') }}" rel="stylesheet">
    @else
    <link href="/css/app.css" rel="stylesheet">
    @endif
    <link href='https://fonts.googleapis.com/css?family=Roboto:300,400,500,700|Material+Icons' rel="stylesheet">
    <link<EMAIL_ADDRESS>rel="stylesheet">

    @yield('scripts', '')

    <meta name="csrf-token" content="{{ csrf_token() }}">

    @php $days = 0 @endphp
    @if ( Auth::check() && Auth::user()->email_verified == 0)
    @php $days = round((strtotime("+30 days", strtotime(Auth::user()->created_at)) - time()) / 86400) @endphp

            @if ($days > 0)

                       You are required to confirm your email. You have {{ $days }} days remaining.
                       <button class="btn btn-primary confirm">confirm</button>

            @else

                        Your trial account has been expired, please verify an email

            @endif

    @endif
    @if ($days > 0)

    @else

    @endif

        @if (Auth::check())
            @include('spark::nav.user')
        @else
            @include('spark::nav.guest')
        @endif

        @yield('content')

        @if (Auth::check())
            @include('spark::modals.notifications')
            @include('spark::modals.support')
            @include('spark::modals.session-expired')
        @endif

please note I am using laravel Spark 4.0+
And I tried to also change my laravel.mix.js file as below:
let mix = require('laravel-mix');
let path = require('path');

mix.less('resources/assets/less/app.less', 'public/css')
  .copy('node_modules/sweetalert/dist/sweetalert.min.js', 'public/js/sweetalert.min.js')
  .copy('node_modules/sweetalert/dist/sweetalert.css', 'public/css/sweetalert.css')
  .js('resources/assets/js/app.js', 'public/js')
  .webpackConfig({
        resolve: {
            modules: [
                path.resolve(__dirname, 'vendor/laravel/spark/resources/assets/js'),
                'node_modules',
            ],
            alias: {
                'vue$': 'vue/dist/vue.js'
               //  'vue$': 'vue/dist/vue.esm.js'
            },
        },

  });

Hope if anyone can give some idea to solve this problem.
Thanks in advance.

@vesper8 where did you make that change? I don't see that line in webpack.mix.js

@vesper8 , @haxoman where did you make the change ? I am having the same issue and I browse through webpack.mix.js, I don't know where to add the code. Thank you!

Anyone searching, i found the file in node_modules/laravel-mix/src/builder/WebpackConfig.js.

                      l,


Cannot debug any function locally, in VS Code

Repro steps:

Action: azureFunctions.pickProcess
Error type: Error
Error Message: Failed to detect running Functions host within "60" seconds. You may want to adjust the "azureFunctions.pickProcessTimeout" setting.
Version: 0.9.1
OS: win32

@amang2205 can you give us some more info on how you reproduced this error?
For example:

Was this a new project? What triggers have you created?
Do you have the azure functions runtime installed? What version?
Does this always happen for you, or only occasionally?

Same here with C# runtime, in vscode on macos 10.13.5.
1-  yes, brand new with a blob trigger. the blob trigger works but never attach to the main method
2- yes
➜  ~ brew install azure-functions-core-tools
==> Installing azure-functions-core-tools from azure/functions
==> Downloading https://functionscdn.azureedge.net/public/2.0.1-beta.31/Azure.Functions.Cli.osx-x<IP_ADDRESS>-beta.31.zip

3- always, can't attach

This is likely due to the same issue reported in version 2.0.1-beta.30 and 2.0.1-beta.31 of the functions cli here: https://github.com/Azure/azure-functions-core-tools/issues/557
You can downgrade to version 2.0.1-beta.29 as a workaround, otherwise check out that issue for workarounds on the current version

Actually I'm struggling to repro the problem on a Mac with v2.0.1-beta.31. @Jonathan34 can you copy the logs from when you F5? The stuff in the 'Terminal' window?

> Executing task: func host start <

                  %%%%%%
                 %%%%%%
            @   %%%%%%    @
          @@   %%%%%%      @@
       @@@    %%%%%%%%%%%    @@@
     @@      %%%%%%%%%%        @@
       @@         %%%%       @@
         @@      %%%       @@
           @@    %%      @@
                %%
                %

Skipping 'AzureWebJobsDashboard' from local settings as it's already defined in current environment variables.
Hosting environment: Production
Content root path: /Users/*edited*/bin/Debug/netstandard2.0
Now listening on: http://<IP_ADDRESS>:7071
Application started. Press Ctrl+C to shut down.
[7/6/18 9:15:44 PM] Reading host configuration file '/Users/*edited*/bin/Debug/netstandard2.0/host.json'
[7/6/18 9:15:44 PM] Host configuration file read:
[7/6/18 9:15:44 PM] {}
[7/6/18 9:15:44 PM] Starting Host (HostId=*edited*-1707488282, InstanceId=b1f71be7-7bfa-431d-b25a-7f67b6c3883a, Version=2.0.11888.0, ProcessId=33843, AppDomainId=1, Debug=False, ConsecutiveErrors=0, StartupCount=1, FunctionsExtensionVersion=)
[7/6/18 9:15:45 PM] 'FUNCTIONS_WORKER_RUNTIME' is specified, only 'dotnet' will be enabled
[7/6/18 9:15:45 PM] Generating 1 job function(s)
[7/6/18 9:15:49 PM] Found the following functions:
[7/6/18 9:15:49 PM] *edited*.Run
[7/6/18 9:15:49 PM]
[7/6/18 9:15:49 PM] Host initialized (4242ms)
Listening on http://<IP_ADDRESS>:7071/
Hit CTRL-C to exit...
[7/6/18 9:15:49 PM] Host lock lease acquired by instance ID '000000000000000000000000E2CF709B'.
[7/6/18 9:15:49 PM] Host started (5035ms)
[7/6/18 9:15:49 PM] Job host started
[7/6/18 9:16:23 PM] Executing *edited*

Then the program executes the function for every blob in the blob storage folder.
Hope it helps...

In fact, it's not that for why I opened up this issue in the first place.
This happens on a brand new and clean installation of VS Code and the tools.
I start by clicking the Folder icon in the Azure FUnctions extension in order to create a new project. I select the beta runtime. Next, I add a new C#, HTTPTrigger function. When I click F5, I get:
> Executing task: dotnet clean <

'C:\Program' is not recognized as an internal or external command,
operable program or batch file.

Finally, after 60 seconds, I get a notification saying:
Failed to detect running Functions host within "60" seconds. You may want to adjust the "azureFunctions.pickProcessTimeout" setting.

Additionally, I also get the unresolved dependencies notification. If I restore the unresolved dependencies, I get a warning saying that
Some projects have trouble loading. PLease review the output for more details.

The output says
Starting OmniSharp server at 7/7/2018, 9:00:19 AM
    Target: c:\Users\amang\Desktop\test

OmniSharp server started
    Path: C:\Users\amang\.vscode\extensions\ms-vscode.csharp-1.15.2\.omnisharp\1.30.1\OmniSharp.exe
    PID: 12868

[info]: OmniSharp.Stdio.Host
        Starting OmniSharp on Windows 6.2.9200.0 (x64)
[info]: OmniSharp.MSBuild.Discovery.MSBuildLocator
        Located 2 MSBuild instance(s)
            1: Visual Studio Enterprise 2017 15.7.27703.2035 - "C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\MSBuild\15.0\Bin"
            2: StandAlone 15.0 - "C:\Users\amang\.vscode\extensions\ms-vscode.csharp-1.15.2\.omnisharp\1.30.1\msbuild\15.0\Bin"
[info]: OmniSharp.MSBuild.Discovery.MSBuildLocator
        Registered MSBuild instance: Visual Studio Enterprise 2017 15.7.27703.2035 - "C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\MSBuild\15.0\Bin"
[info]: OmniSharp.Cake.CakeProjectSystem
        Detecting Cake files in 'c:\Users\amang\Desktop\test'.
[info]: OmniSharp.Cake.CakeProjectSystem
        Could not find any Cake files
[info]: OmniSharp.DotNet.DotNetProjectSystem
        Initializing in c:\Users\amang\Desktop\test
[info]: OmniSharp.DotNet.DotNetProjectSystem
        Auto package restore: False
[info]: OmniSharp.DotNet.DotNetProjectSystem
        Update workspace context
[info]: OmniSharp.DotNet.DotNetProjectSystem
        Resolving projects references
[info]: OmniSharp.MSBuild.ProjectSystem
        No solution files found in 'c:\Users\amang\Desktop\test'
[info]: OmniSharp.MSBuild.ProjectManager
        Queue project update for 'c:\Users\amang\Desktop\test\test.csproj'
[info]: OmniSharp.Script.ScriptProjectSystem
        Detecting CSX files in 'c:\Users\amang\Desktop\test'.
[info]: OmniSharp.Script.ScriptProjectSystem
        Could not find any CSX files
[info]: OmniSharp.Stdio.Host
        Invoking Workspace Options Provider: OmniSharp.Roslyn.CSharp.Services.CSharpWorkspaceOptionsProvider
[info]: OmniSharp.Stdio.Host
        Configuration finished.
[info]: OmniSharp.Stdio.Host
        Omnisharp server running using Stdio at location 'c:\Users\amang\Desktop\test' on host 3248.
[info]: OmniSharp.MSBuild.ProjectManager
        Loading project: c:\Users\amang\Desktop\test\test.csproj
[info]: OmniSharp.MSBuild.ProjectManager
        Adding project 'c:\Users\amang\Desktop\test\test.csproj'
[info]: OmniSharp.MSBuild.ProjectManager
        Update project: test
[info]: OmniSharp.MSBuild.ProjectManager
        Queue project update for 'c:\Users\amang\Desktop\test\test.csproj'
[info]: OmniSharp.MSBuild.ProjectManager
        Queue project update for 'c:\Users\amang\Desktop\test\test.csproj'
[info]: OmniSharp.MSBuild.ProjectManager
        Queue project update for 'c:\Users\amang\Desktop\test\test.csproj'
[info]: OmniSharp.MSBuild.ProjectManager
        Queue project update for 'c:\Users\amang\Desktop\test\test.csproj'
[info]: OmniSharp.MSBuild.ProjectManager
        Loading project: c:\Users\amang\Desktop\test\test.csproj
[warn]: OmniSharp.MSBuild.ProjectLoader
        Package 'Microsoft.AspNet.WebApi.Client 5.2.2' was restored using '.NETFramework,Version=v4.6.1' instead of the project target framework '.NETStandard,Version=v2.0'. This package may not be fully compatible with your project.
c:\Users\amang\Desktop\test\test.csproj
c:\Users\amang\Desktop\test\test.csproj(0,0): Error: Package 'Microsoft.AspNet.WebApi.Client 5.2.2' was restored using '.NETFramework,Version=v4.6.1' instead of the project target framework '.NETStandard,Version=v2.0'. This package may not be fully compatible with your project.

[info]: OmniSharp.MSBuild.ProjectManager
        Update project: test

This clearly states the problem, which is that it restores the Microsoft.AspNet.WebApi.Client 5.2.2 to .NETFramework rather than .NETStandard. Hence, the program won't work.
IMHO, the restoration process messes up the entire program and this is a brand new, template based code.

Note: the version 29 is not available via brew.... needs to be installed manually.

@amang2205 the problem you noted about "Microsoft.AspNet.WebApi.Client 5.2.2" is a known issue, but shouldn't be a blocker. I can successfully debug even with that warning. Just to be sure, though, you can update the version of "Microsoft.NET.Sdk.Functions" to "1.0.14" in your csproj file and that warning should go away after you restore packages.
I'm guessing 'C:\Program' is not recognized as an internal or external command, operable program or batch file. is your main problem. If it can't even do a "dotnet clean" and "dotnet build", then it's not going to be able to debug. Can you try manually running "dotnet clean" and "dotnet build" from the command prompt in your project's folder?
@Jonathan34 My log looks exactly like yours and it's working. Can you try a clean project with just an HttpTrigger instead of a BlobTrigger? Does that work for you?

Actually, I'd guess the problem is
Package 'Microsoft.AspNet.WebApi.Client 5.2.2' was restored using '.NETFramework,Version=v4.6.1' instead of the project target framework '.NETStandard,Version=v2.0'. This package may not be fully compatible with your project.
c:\Users\amang\Desktop\test\test.csproj
c:\Users\amang\Desktop\test\test.csproj(0,0): Error: Package 'Microsoft.AspNet.WebApi.Client 5.2.2' was restored using '.NETFramework,Version=v4.6.1' instead of the project target framework '.NETStandard,Version=v2.0'. This package may not be fully compatible with your project.

@EricJizbaMSFT tried a new http trigger and blob trigger with default settings. same result. (yes i triggered the http call and got Hello, asd)
I noticed:
 Error: Package 'Microsoft.AspNet.WebApi.Client 5.2.2' was restored using '.NETFramework,Version=v4.6.1' instead of the project target framework '.NETStandard,Version=v2.0'. This package may not be fully compatible with your project.

then a popup:
Failed to detect running Functions host within "60" seconds. You may want to adjust the "azureFunctions.pickProcessTimeout" setting.

i am using vscode Version 1.26.0-insider (1.26.0-insider 2018-07-10T05:05:14.117Z)

Okay this may be my last idea. You can follow these steps to manually attach to the functions host:

Create a new C# project
Add an HttpTrigger
Manually edit your '.csproj' file so that "Microsoft.NET.Sdk.Functions" is version "1.0.14"
Wait for a prompt to restore your nuget packages and hit 'restore'
Manually edit your .vscode\launch.json file from ${command:azureFunctions.pickProcess} to ${command:pickProcess}
Open up the command palette (view -> Command Palette on a mac)
Select 'Tasks: Run Task'
Select 'Run Functions Host'
Once the terminal finishes cleaning and building, start debugging
Because you changed your launch.json, you will have to manually select the process. Search for func and select that process

If that works - we probably have a bug in our extension somewhere. If that still doesn't work, that means the bug is probably in the functions cli or there's some configuration problem on your machine.

Hi,
I had the same issue but after following up the instructions from @EricJizbaMSFT I noticed that the step 8. was failing with a 'no such file or directory' error.
Then I remembered that I had changed the project to use netcoreapp2.1 instead of netstandard2.0 (default) and I verified that the task in the tasks.json file was executing a directory change to ${workspacefolder}/bin/debug/netstandard2.0, which does not exist in my case.
After changing the directory to the correct one, all went well and I can debug :).
At the end my tasks.json looked like this (removed the parts that are not relevant for simplicity):
{
"label": "Run Functions Host",
"identifier": "runFunctionsHost",
"type": "shell",
"dependsOn": "build",
"options": {
"cwd": "${workspaceFolder}/bin/Debug/netcoreapp2.1"
},
"command": "func host start",
"isBackground": true,
"presentation": {
"reveal": "always"
},
"problemMatcher": []
}
Hope this helps others with the similar issue.

@EricJizbaMSFT painful but works.

@Jonathan34 when you manually pick the process, does it look like this:

And if you run ps from the command line, does it have the same thing listed?
  PID TTY           TIME CMD
.
.
.
23523 ttys004    0:02.99 func host start

Our extension is trying to find the 'func' process automatically and I'm wondering if yours is different for some reason.

Hey all - sorry for the delay, but I've completely refactored this and I'm hoping to get your help testing if you have time (and if you never got this working for yourself).
Please install the following vsix leveraging the "Install from VSIX" command in VS Code's command palette:

VSIX:
https://azcode.blob.core.windows.net/vscode-azurefunctions/ej/proc/1627/vscode-azurefunctions-0.10.1-alpha.vsix
Otherwise just follow your normal debugging routine for C# projects and let me know if it works.


Imports incompatible with TypeScript

I am using this library with Firebase functions written in TypeScript. Since I upgraded to version 0.5.0 I am getting the following error from tslint:

node_modules/@google-cloud/error-reporting/node_modules/@google-cloud/common/build/src/service-object.d.ts:18:8 - error TS1192: Module '"/home/lpellegr/X/functions/node_modules/@types/request/index"' has no default export.
18 import r from 'request';
~
node_modules/@google-cloud/error-reporting/node_modules/@google-cloud/common/build/src/service.d.ts:17:8 - error TS1192: Module '"/home/lpellegr/X/functions/node_modules/@types/request/index"' has no default export.
17 import r from 'request';
~
node_modules/@google-cloud/error-reporting/node_modules/@google-cloud/common/build/src/util.d.ts:20:8 - error TS1192: Module '"/home/lpellegr/X/functions/node_modules/@types/duplexify/index"' has no default export.
20 import duplexify from 'duplexify';
~~~~~~~~~
node_modules/@google-cloud/error-reporting/node_modules/@google-cloud/common/build/src/util.d.ts:23:8 - error TS1192: Module '"/home/lpellegr/X/functions/node_modules/@types/request/index"' has no default export.
23 import r from 'request';

There were no issues with version 0.4.0. TypeScript 2.9.2 is used.

@lpellegr thanks for the report. I think this problem is due to one of our dependencies (@google-cloud/common) using the new allowSyntheticImports feature in TypeScript which leaks through to the users 😰.
I think this has already been fixed upstream, and picking up a new release of the library will fix the problem.
I believe this will go away a new release of @google-cloud/logging is done and we pick that up here.

Blocked on https://github.com/googleapis/nodejs-logging/pull/149.

Fix over in #158.
I was confusing this issue with another one in @google-cloud/logging-winston. This did not depend on googleapis/nodejs-logging#149.

@lpellegr 0.5.1 has been release which should no longer have this issue. Please give this a shot and re-open or comment here if you're still running into issues.


How can I get outerHtml

@html seems to give me innerHtml, how to get the outerHtml?

Currently not supported. See https://github.com/matthewmueller/x-ray/pull/328.


Columns with same name (on different tables) are messing up the results

If we have two columns with the same name in the same query the result is overridden. In this query I also found another bug: the COUNT and the GROUP_CONCAT does not show results if they don't have an alias.
SELECT s.name,
       t.name,
       count(tg.id),
       group_concat(tg.taggable_id
                    ORDER BY tg.taggable_id ASC separator ', ')
FROM taggings tg,
     tags t,
     questions q,
     subgroups s
WHERE t.id = tg.tag_id
  AND tg.taggable_id = q.id
  AND tg.taggable_type = 'Question'
  AND q.year >= 2009
  AND s.id = q.subgroup_id
GROUP BY s.name,
         t.id

Result:

Should be:

Adding an alias to all columns fixes it.

I've implemented a solution for this in the PostgreSQL query runner, but never generalized it for the other query runners.
Which one are you using?

@arikfr  I'm using mysql. Should I implement the solution for mysql or try to generalize it?

I missed your comment about the issue with count/group_concat when I first read this issue. The problem isn't with count/group_concat themselves, but with the dot in the resulting column names. I fixed this in #577.

Great! Thank you @arikfr


compute test definition

MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Contribution checklist:

[ ] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

[ ] Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.

adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

[ ] If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

/azp run automation - sdk

Can one of the admins verify this patch?

hi @zikalino what's this used for?

close since too old PR.
CC to @msyyc  @00Kai0 in case the configured scenario is needed

Hi, @zikalino. The PR has be closed for a long time and it's related branch still exist. If no further used for over 14 days, I will delete this related branch. Please tell me if you still need this branch.

Hi, @zikalino. The PR has be closed for a long time and it's related branch still exist. Please tell me if you still need this branch or i will delete it in 14 days.

Hi, @zikalino. The PR has be closed for a long time and it's related branch still exist. Please tell me if you still need this branch or i will delete it in 14 days.

Hi, @zikalino. The PR has be closed for a long time and it's related branch still exist. Please tell me if you still need this branch or i will delete it in 14 days.


General: Allow hiding password form

Checklist
General

[ ] I tested all changes and their related features with all corresponding user types on a test server.
[ ] This is a small issue that I tested locally and was confirmed by another developer on a test server.
[ ] Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
[ ] I chose a title conforming to the naming conventions for pull requests.

Server

[ ] I followed the coding and design guidelines.
[ ] I added multiple integration tests (Spring) related to the features (with a high test coverage).
[ ] I added @PreAuthorize and checked the course groups for all new REST Calls (security).
[ ] I implemented the changes with a good performance and prevented too many database calls.
[ ] I documented the Java code using JavaDoc style.

Client

[ ] I followed the coding and design guidelines and ensured that the layout is responsive.
[ ] Following the theming guidelines, I specified colors only in the theming variable files and checked that the changes look consistent in both the light and the dark theme.
[ ] I added multiple integration tests (Jest) related to the features (with a high test coverage), while following the test guidelines.
[ ] I added authorities to all new routes and checked the course groups for displaying navigation elements (links, buttons).
[ ] I documented the TypeScript code using JSDoc style.
[ ] I added multiple screenshots/screencasts of my UI changes.
[ ] I translated all newly inserted strings into English and German.

Changes affecting Programming Exercises

[ ] I tested all changes and their related features with all corresponding user types on Test Server 1 (Atlassian Suite).
[ ] I tested all changes and their related features with all corresponding user types on Test Server 2 (Jenkins and Gitlab).

Motivation and Context

We at KIT aim to completely disable password login and rely only on SAML2. Having a password login causes confusion since Artemis credentials do not match SAML2 credentials.
Description
Add a new entry in the /info endpoint called disable-password-login which disables the login form in the client.
Steps for Testing

Prerequisites:
none

Toggle the info.disable-password-login configuration option.
Attempt to log in using SAML2 and password.

Review Progress

Code Review

[ ] Review 1
[ ] Review 2

Manual Tests

[ ] Test 1
[ ] Test 2

Test Coverage

Class/File
Branch
Line

Screenshots

Current design:
Password login enabled:

Password login disabled:

Something like this is also nice :)
https://artemis.cs.hm.edu/

I'll work on the UI over the weekend.

I've created a new PR #5291 since I couldn't push to your repository. Hope that is okay.

Ill have a look at the new PR tomorrow :)


Output of changes

It would be nice after adding something to output a list of all changes to the console like git diff

I think this would be feature creep. We could instead document that you should make a git commit before running an adder on your existing project both for safety and so you can see what it does by comparing the changes to before the adder(s) ran (which also lets you see if / how it malfunctioned if your project is different from what svelte-add expects).
I think the command is git log --patch and / or you can use your IDE to look.


[Feedback] Release / Usage 1.9.0

Hi, all. I'm glad everyone is enjoying the component as much as I do developing it. I was wondering if I was overzealous in this release. I did a major update to the props in turn allowing more flexibly and I was wonder if this eases implementation or causes more of a headache and if it should be simplified in the future.  Let me know what you think. Thanks.

I just only discovered this plug-in today so I have no experience with the previous properties.  For me the current properties are clear and easy to use.
I do have a remark about the 'ref' attribute.  In your example it's a string but the new preferred way is to use a callback as such:
ref={(alert) => this._alert = alert}
And I was also wondering if in your current implementation it would be possible to simulate that beautiful IOS transition effect.  Their effect is like pulling a drawer and then turning it.  That would make it perfect ;-)

Oh that's interesting: ref={(alert) => this._alert = alert} what's the back story on this? Oh like some spring end transition to give it a little bounce? Thanks for the feedback.

I think the main reason is that they no longer want to have 'refs' as a React reserved property.  And in my short experience with React Native, I noticed that 'this.refs' often resulted in 'undefined' while defining my own callback method did not have this issue.


drivers: grio: Pull ups and disabling interrupts.

The initial RPi Pico GPIO driver has a couple small issues that need correcting. This was originally identified by @protobits

Configuring of pulls needs to set both pull flags at once.
Need the ability to also disable interrupts for a given pin.

Tested on Adafruit KB2040 and Adafruit QT Py RP2040.

@petejohanson thanks for the update. The PR looks good, however there is still pending comment from @gmarull. I'll wait with my approval until it is addressed.

@mnkp Indeed. Updated based on the suggestions, re-ran the test again on my pico, still passed as expected.


Terraform can't find an existing VPC and subnets

Tectonic Version
tectonic_1.7.9
Environment
AWS
Expected Behavior
terraform succeeds planning
Actual Behavior
It couldn't find the existing VPC or subnets that I already created and verified exist.
Error refreshing state: 4 error(s) occurred:

* module.vpc.data.aws_subnet.external_worker: 3 error(s) occurred:

* module.vpc.data.aws_subnet.external_worker[0]: data.aws_subnet.external_worker.0: InvalidSubnetID.NotFound: The subnet ID 'subnet-36eba17e' does not exist
	status code: 400, request id: 13de40ba-4bad-49e4-86a2-74a2d4f3dc63
* module.vpc.data.aws_subnet.external_worker[1]: data.aws_subnet.external_worker.1: InvalidSubnetID.NotFound: The subnet ID 'subnet-36ad8750' does not exist
	status code: 400, request id: 983bee15-9539-4bcc-909c-2d5ab6668649
* module.vpc.data.aws_subnet.external_worker[2]: data.aws_subnet.external_worker.2: InvalidSubnetID.NotFound: The subnet ID 'subnet-49d33113' does not exist
	status code: 400, request id: 8ba6fb20-1a43-4b71-83be-aa132364f4b4
* data.aws_route53_zone.tectonic_ext: 1 error(s) occurred:

* data.aws_route53_zone.tectonic_ext: data.aws_route53_zone.tectonic_ext: Either name or zone_id must be set
* module.vpc.data.aws_vpc.cluster_vpc: 1 error(s) occurred:

* module.vpc.data.aws_vpc.cluster_vpc: data.aws_vpc.cluster_vpc: InvalidVpcID.NotFound: The vpc ID 'vpc-bed41fdb' does not exist
	status code: 400, request id: d08d1b4d-75e5-4ceb-ad8e-5da453b7a266
* module.vpc.data.aws_subnet.external_master: 3 error(s) occurred:

* module.vpc.data.aws_subnet.external_master[0]: data.aws_subnet.external_master.0: InvalidSubnetID.NotFound: The subnet ID 'subnet-abd49ee3' does not exist
	status code: 400, request id: e7cf9103-cbfc-4611-b946-0e08e4b29e7a
* module.vpc.data.aws_subnet.external_master[1]: data.aws_subnet.external_master.1: InvalidSubnetID.NotFound: The subnet ID 'subnet-91eea4d9' does not exist
	status code: 400, request id: 0be26fdc-3c89-49f0-a4ea-fda8342d4333
* module.vpc.data.aws_subnet.external_master[2]: data.aws_subnet.external_master.2: InvalidSubnetID.NotFound: The subnet ID 'subnet-dbcd2f81' does not exist
	status code: 400, request id: ea655313-12e1-4d98-870a-431ed6496cc9

Reproduction Steps

Following the instructions on https://coreos.com/tectonic/docs/latest/install/aws/aws-terraform.html
Set AWS_ACCESS_KEY_ID and AWS_SECRET_ACCESS_KEY environment variables (I used admin credentials for my AWS account)

Other Information
Relevant lines in terraform.tfvars.
tectonic_aws_external_master_subnet_ids = ["subnet-abd49ee3", "subnet-91eea4d9", "subnet-dbcd2f81"]
tectonic_aws_external_vpc_id = "vpc-bed41fdb"
tectonic_aws_external_worker_subnet_ids = ["subnet-36eba17e", "subnet-36ad8750", "subnet-49d33113"]

I didn't try to use temporary credentials or create a role account for the tectonic installer. I wonder if that caused a permissions problem?

My vars had eu-west-1 set, copied from the example.

I googled for the same problem, found this and realised I had made same error. Thanks! :)


Translation to Microsoft Defender?

Hi
I don't know since when but right now the Microsoft Defender (or KQL) option does not appear in the “target” field.
Is it a bug or this language is no longer supported?
Thank you.

Hi, with our latest code refactoring we had some problems while having KQL backend installed alongside the other backends. As we have finished the refactor, I will try to troubleshoot the problem and re-enable it as soon as possible. Sorry for the inconvenience of removing it.

Hi.
Sorry, I just saw the status of this issue. Completed, what does it mean? Because except my mistake, “Defender”(Kusto) is not available yet.
Thanks, best regards.

Hi @osnolanarf, the code was adjusted and we just recently noticed that we seem to have a problem with the deployment. We are investigating it atm. As soon as this is fixed the Kusto Backend will be finally available. I will ping you here again

Its works! :)


How to change the rating like “sick” to “sick-pixel” midsong in lua?

What is your question?
look

setProperty('ratingsData[0].image', 'what ever the file name is') --change "Sick" image

and even the other rating data, i just copy and change it around a bit

setProperty('ratingsData[0].image', 'what ever the file name is') --change "Sick" image

That's pretty cool, but then how do you change the combo numbers to match?

thats what im asking, lol

That's pretty cool, but then how do you change the combo numbers to match?


run the performance step in a separate job, on a self-hosted runner

Problem
The puppeteer performance test were executed on GithubActions along with all the rest of the jobs. A few months ago something changed, and the test results became incredibly unreliable, seemingly the test runner loosing CPU allocation during the test run.
Solution
Move the puppeteer test (and only the puppeteer test) to a Linode dedicated CPU instance.
This PR is already showing performance tests that are executed on the Linode instance.
I picked the cheapest dedicated CPU instance, 2 cores, $30 / month + $5 for backup
Details

created a new linode instance github-actions-1 https://cloud.linode.com/linodes/32420665
I have no idea who can see this, I think Malte and Balazs are the ones who are in the Utopia Linode origanization
this instance runs the github action runner as a systemd process

Notes

The node has manually installed nix and the github actions runner. There's no setup script or Dockerfile to instantly recreate it
I did manage to make a "Backup Snapshot" of the moment it all started working. that should be a stopgap for now
We should run this for a couple of days and observe reliabilty
If it is unreliable, consider other options and possibly a solution which lets us make easy to reproduce setups (Docker or nixos or otherwise)

I have no idea who can see this
I'll invite everyone once we're happy we'll stick with this

The Discord integration is failing here because it seems the Linode instance is missing jq:
jq: command not found
That log line is at the end of the Build Discord Message step of the workflow, which is used for building the JSON embeds before sending the message.

oh I missed this comment. I'll fix this, thanks!

@Rheeseyb I fixed the jq command a few weeks ago! I think this is ready to merge, the server was running for weeks now


Allow wrapping custom checkbox and radio inside label

The custom checkbox and radio classes require the use of the labels' for attribute:
https://www.gethalfmoon.com/docs/checkbox/

The id="..." attribute of the input and the for="..." attribute of the label should have the same value.

Is it possible to support the following syntax?:
<label>
	<input type="checkbox" name="checkbox" value="value">
	Text
</label>

The advantage being that this avoids accidental duplicate id's, i.e.: if you copy paste the form, you have to rename the checkboxes when using label for, otherwise the label clicks will toggle the wrong checkboxes

I like the syntax that you proposed, but is the lack of IDs on checkboxes a good idea? Seems like it could lead to accessibility issues. I know the docs don't have things like aria-labelledby at this moment, but I intend to add them in the near future hopefully, so even if only for accessibility issues, you would still need an ID on a checkbox.

I couldn't figure the purpose of id for accessibility where there already exists name, but upon reading about this accessibility tutorial on label for, it seems it does indeed help. Funnily though before reading that, this was the workaround I implemented in my code 😄
<input
	type=checkbox
	bind:checked={todo.done}
	id={`u0MVRY4-${i}`}
>

(I generated a random base64 string and prepended the id with it so that I don't accidentally give same id's even while trying to avoid that). I didn't know about the accessibility implications of course 🙂 . Now it's head-scratcher though: do I choose accessibility or maintainability? 😄
I'm not very knowledgable about the details, but if I understand correctly, aria-labelledby can be used with implicit labelling to achieve the same accessibility?

I am no accessibility expert (trying to get better though), but from what I understand, aria-labelledby is used to establish a relationship between an element and its label.
May I ask though, wouldn't you be better off using semantic IDs for your checkboxes? For example, a remember password checkbox could have a remember-password-checkbox ID. Do you have a lot of checkboxes on your page that it becomes difficult to give them all semantic IDs?

I don't have any complicated projects right now, I'm just speculating. I can see it being a problem especially when using different components. Two different components could easily have a checkbox with similar functionality, but their id's are not scoped so they can easily clash.
Although now that I think, the id would be needed in vanilla js for app logic anyway so I can see this being a non-issue normally. But I guess this struck me as a problem because I'm thinking with component-based app mentality where with svelte I use bindings which are scoped inside each component instead of id's which are not scoped and hence can clash


[BugFix] Ensure query port can be configured in init-password job

Description
A scenario that requires modifying the container listening query port:

The source cluster is deployed on virtual machines, while the target cluster is deployed on k8s. External access to the internal IP of k8s is not possible, but pods within k8s can access external IPs.
The migration tool is deployed outside of k8s. The StarRocks cluster on k8s is exposed through /etc/host (frontend domain name, node IP of k8s) + NodePort.
In the cross-cluster migration tool, use the port obtained from Show Frontend for recording in Frontend. At the same time, use this port to access the target cluster (instead of configuring target_fe_query_port).
The target cluster pulls data from the source cluster.

Checklist
For helm chart, please complete the following checklist:

[x] make sure you have updated the values.yaml
file of starrocks chart.
[x] In scripts directory, run bash create-parent-chart-values.sh to update the values.yaml file of the parent
chart( kube-starrocks chart).

Tested three scenarios:

Configuration does not include the query port setting.

Configuration includes the query port setting.

The query port setting in the configuration is commented out.
All three scenarios meet expectations.


feat!: convert cover_image from str to Asset.

What type of pull request is this?

[ ] Non-breaking code change
[x] Breaking code change
[x] Documentation change/addition
[ ] Tests change

Description
The cover_image is currently handled as a string of its image hash. Since this attribute in the Discord Developers documentation shares the same CDN endpoint as the icon attribute, I've made the following changes.
I've marked this as a breaking change as this completely handles the way you have to read from the cover_image attribute. There's no suiting __repr__ to give only one thing and now returns a class instead. Please change to non-breaking if I made the wrong judgment!
Changes

Changed the typing of cover_image from str to Asset.
Edited the _process_dict classmethod to create the appropriate URL from the hash and path.

Checklist

[x] I've formatted my code with Black
[x] I've ensured my code works on Python 3.10.x
[x] I've tested my code

Please target to naff branch.


Go Build is failing while trying build

Hi
I am getting following error while I am doing go build

go build
prometheus-zookeeper_exporter
./main.go:11:2: imported and not used: prometheus-zookeeper_exporter/vendor/github.com/prometheus/client_golang/prometheus/promhttp"
./main.go:69:28: undefined: prometheus.Handler

Could you please look suggest me changes I am just making binary out of your main.go file using Jenkins ?

Hi @vkkothawale,
In the code in master there isn't an import of promhttp, so you cannot be building directly from the source. Are you working from a fork?

Hi @carlpett
I have fixed that issue by adding promhttp.Handler() instead of  prometheus.Handler() in your source code that worked fine can you please provide me json file file for the zookeeper exporter dashboard for grafana I have check your source code but did not find any json if you can provide that it will great.
Thanks

Hi,
I'm afraid I do not have any readymade Grafana dashboards. If you make one, please consider contributing it here in a PR!


fix possibilty that AfterGroups method is invoked before all tests

Fixes #2754
When AfterGroups method has multiple groups defined then situation was possible that it is invoked not after all tests for all its groups but after the last test of any group
Did you remember to?

[x] Add test case(s)
[x] Update CHANGES.txt
[x] Auto applied styling via ./gradlew autostyleApply

We encourage pull requests that:

Add new features to TestNG (or)
Fix bugs in TestNG

If your pull request involves fixing SonarQube issues then we would suggest that you please discuss this with the
TestNG-dev before you spend time working on it.
Note: For more information on contribution guidelines  please make sure you refer our Contributing section for detailed set of steps.

@juherr can you please help take a quick look ?


ErrorRecord.InvocationInfo.Statement property doesn't report full statement for command syntax / invalid-argument errors

Prerequisites

[X] Write a descriptive title.
[X] Make sure you are able to repro it on the latest released version
[X] Search the existing issues.
[X] Refer to the FAQ.
[X] Refer to Differences between Windows PowerShell 5.1 and PowerShell.

Steps to reproduce
The new-in-7.4 ErrorRecord.InvocationInfo.Statement property is designed to report the whole statement that triggered the error (possibly spanning multiple lines).
This doesn't work when the error was triggered by a command syntax error or by a parameter having been passed an invalid argument (in other words: the problem seems related to the parameter binder reporting the error):
try {
  Get-Item -NoSuchParameter -LiteralPath .
}
catch {
  '[' + $_.InvocationInfo.Statement + ']'
}

Expected behavior
[Get-Item -NoSuchParameter -LiteralPath .]

Actual behavior
[-NoSuchParameter]

That is, only the offending parameter is reported.
This applies both to unrecognized parameters and known parameters having been given no argument.
If a known parameter is given an invalid argument, only that argument is reported.
Error details
No response
Environment data
PowerShell 7.4.0-rc.1

Visuals
No response

This is the PR that added this property https://github.com/PowerShell/PowerShell/pull/19027


incorrect position of the selected area in firefox

Hi! I have a problem with brush library in the firefox browser. I’m using a chart on modal window. When I select an area by mouse,  area is displacing on it. But area selecting works good in google chrome.

If I displace modal window to top-left part of browser, area selecting works good

I suppose, that I must promt d3.event.selection about position of modal window, but i don’t know how
I’m using version 4.13 of d3.js

maybe try to change the target of the brush? We can't really help you here, please use stack overflow for this type of question

Did you solved this issue @fandriyaninkov


Wildcard support in iam.workloadIdentityUser mapping with repository

TL;DR
When we map the repo with service account for impersonation as below -
member="principalSet://iam.googleapis.com/${WORKLOAD_IDENTITY_POOL_ID}/attribute.repository/${REPO}"

It require us to add every new repo manually to add that as valid repo, can we use some wildcard with the repo name so that every repo that starts with some predefined text is authenticated by default and we don't need to add that manually?
something like this -
member="principalSet://iam.googleapis.com/${WORKLOAD_IDENTITY_POOL_ID}/attribute.repository/dummy-repo*"

and all the repos starting with title "dummy-repo" should be a part of allowed repos for authentication.
and this feature should also be available in Terraform module (google_service_account_iam_member).
Detailed design
No response
Additional information
No response

Hi @prakashkgsuk
Thank you for opening an issue. You can directly map on any of the GitHub-published claims.
If you want to do more complex things, you can use an attribute condition to control admission to the pool:
--attribute-condition="assertion.repo.startsWith('dummy-repo')"

Then you would grant the entire pool permission to impersonate (or further restrict with mapping permissions.
Does that make sense?

Hey there - I'm going to close this out due to inactivity. If this issue is still occurring or you have new information to provide, please comment and a maintainer will re-open. Thank you!