ContextMenu: +property ClickedElement

It would be nice to have in ContextMenu a property ClickedElement.
It extends the possibilities in ContextMenu.ContextMenuOpening handlers, for example.
The solution I'd like
class ContextMenu
private static void ControlContextRequested(object? sender, ContextRequestedEventArgs e)
{
  if (sender is Control control  && control.ContextMenu is ContextMenu contextMenu  && !e.Handled)
  {
    contextMenu.ClickedElement = e.Source as Control;

    if (!contextMenu.CancelOpening())
    {
     var requestedByPointer = e.TryGetPosition(null, out _);
     contextMenu.Open(control, e.Source as Control ?? control, requestedByPointer);
     e.Handled = true;
    }
  }
}

private static void ControlContextRequested(object? sender, ContextRequestedEventArgs e)
{
if (sender is Control control && control.ContextMenu is ContextMenu contextMenu && !e.Handled)
{
contextMenu.ClickedElement = e.Source as Control;
if (!contextMenu.CancelOpening())
{
var requestedByPointer = e.TryGetPosition(null, out _);
contextMenu.Open(control, e.Source as Control ?? control, requestedByPointer);
e.Handled = true;
}
}
}

Why do you need ClickedElement, if you can get control from args.Source?

I'm generating ContextMenu items in ContextMenu.ContextMenuOpening handler.
public event CancelEventHandler? ContextMenuOpening;
It's not a RoutedEvent, there is not args.Source

Control.ContextRequested event by itself is routed, and you can get source there. And open MenuFlyout (or ContextMenu) from there. In other words, you can have this ControlContextRequested handled implementation in your code with some additional logic.
Personally, I would consider ContextMenu as deprecated control, but we still keep it as it's widely used.

Using Control.ContextRequested event is not too bad idea, but i think it is better for Controls like ContextMenu or MenuFlyout than for UserControls itself.
So, it would be nice for me to have ClickedElement in ContextMenu and in MenuFlyout.
For example in Telerik WPF RadContextMenu we have a method:
T GetClickedElement() where T : FrameworkElement


Minor adjustments to jazzy to format parameters properly

Minor adjustments to some jazzy comments to format parameters properly where they weren't displaying.

Codecov Report

Merging #30 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #30   +/-   ##
=======================================
  Coverage   53.12%   53.12%
=======================================
  Files           9        9
  Lines         800      800
=======================================
  Hits          425      425
  Misses        375      375

Flag
Coverage Δ

#SwiftyRequest
53.12% <ø> (ø)
:arrow_up:

Impacted Files
Coverage Δ

Sources/SwiftyRequest/HTTPMethod.swift
0% <ø> (ø)
:arrow_up:

Sources/SwiftyRequest/JSONWrapper.swift
27.27% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82d49d1...b03bd54. Read the comment docs.


Year 0 fine fuel biomass

Add dead structural leaf material as a function of dead wood map

Added new functionality and created new installer 0.9.4.
See: https://github.com/LANDIS-II-Foundation/Extension-NECN-Hydro-Succession/commit/f546312a859d3c2301cd4817647f9ca5ba815ef7


no Bower

After a fresh installation, (everything goes fine) accessing the url cause this error :
[Thu Apr 27 12:06:36.506386 2017] [:error] [pid 16947] [client <IP_ADDRESS>:33158] An Error occurred while handling another error:\nexception 'yii\\base\\InvalidParamException' with message 'The file or directory to be published does not exist: /home/mockup/public_html/vendor/bower/jquery/dist' in /home/mockup/pu.....
I have no bower folder in vendor... so something goes wrong during installation.

I rename bower-assets to bower and it seems to work now...

I am glad to hear that you manage to run it.
This seems to be related to Composer assets plugin settings (in some versions the default bower directory seems to be named bower-assets or sth like that). To ensure that the bower will be installed in the correct vendor folder I've added a .bowerrc with predefined direcotry path - https://github.com/ganigeorgiev/presentator/commit/55131822bbb2babe164e85de6635b8aa13a0168b.
To test it -  delete the vendor directory and run again composer install. Let me know if you still encounter the issue.


undefined && require('mockjs') will pack mockjs

Bug report

What is the current behavior?
undefined && require('mockjs') will pack mockjs
If the current behavior is a bug, please provide the steps to reproduce.
step0: mkdir webpack-demo && cd webpack-demo
step1: npm init -y
step2: npm i webpack webpack-cli mockjs -D
step3: mkdir src && cd src && touch index.js
step4: type undefined && require('mockjs')
step5: cd ..
step6: npx webpack

What is the expected behavior?
"mockjs" will not be packaged

Other relevant information:
webpack version:  5.7.0
Node.js version: 12.16.1
Operating System: macOS Catalina
Additional tools:

Try to use null or false

Try to use null or false

use 'null' or 'false' not be packaged, pls tell me why use 'undefined' will be packaged

@xiecz123 because evaluator doesn't support undefined, it is feature

@evilebottnawi Thank you for your answer

@evilebottnawi Thank you for your answer

Let's keep open, I think we should improve this

FWIW I have some code that relies on this type of behavior with a dynamic import to ensure a few modules that produces separate files as side effects (e.g. MiniCSSExtract stylesheets) are built, but aren't actually imported or run in production builds since there I need only the compiled CSS and don't need the JS hookups that also facilitate hot reloading.
I can imagine I'm not the only one using this quirk to facilitate such a scenario, so if the behavior here is changed, keep in mind to have another way to realize the same pattern, please.

bump

Still valid, will be great to support undefined

@sokra should we support undefined also?

Yes, because it will be false, one note - in IE you can override undefined on any variable, but I feel it like a bug, we can add note about this  to docs

Yep, sounds good to add


Pallet Contracts is outdated and cannot upload contract

This is either an issue with a Polkadotjs Apps frontend or a compatibility issue with our version of pallet_contracts and cargo-contract

I believe we should remove pallet_contracts from the runtime until we have the right compatibility ready.
cc. @zycon91 @therealcherry

I believe we should remove pallet_contracts from the runtime until we have the correct compatibility ready.
cc. @zycon91 @therealcherry

Sounds like a plan.

Assigned to you @zycon91


remove break statement from FilterFree

In FilterFree, once the free transaction limit has been reached, yield break is called, preventing further iteration on the the list of transactions. Hence, blocks become limited to contain only the number of transactions that were returned before that point, instead of iterating all the way to MaxTransactionsPerBlock. This change removes that statement so that any additional transactions with fees attached may be processed as the foreach statement continues.

Eagle eyes! I am happy to see such improvements today, really.

@vncoelho Now we just need wakka akka 😄

Hey,  @Edgegasm.
I am happy about how everything happened today.
Different contributions and @erikzhang, as always, being very careful, open and fast when it is needed.
The Akka refactoring is also something impressive. It will be great when it goes live.
I am sure that learning those concepts took @erikzhang months, plus his experience and expertise.


Treesitter highlights get cleaned

Description
Many treesitter highlights get cleaned when colorscheme nightfox
Behavior
Expected behavior
Correct treesitter highlight(have run NightfoxCompile)
Screenshots
This is what happened to nightfox

When I try hi TSFunction, nvim gives message TSFunction xxx cleared, this happens also to TSKeyword.
Another theme support treesitter.

Configuration
require('nightfox').setup({
    options = {
      dim_inactive = false,
      styles = {
        comments = 'italic',
        functions = 'italic',
        keywords = 'bold,italic',
      },
      inverse = {
        match_paren = true,
        visual = true,
        search = false,
      },
      transparent = false,
    },
  })

Reproduce
This issue happened when I update nightfox to a recent version.
Additional info / context
nvim: 0.7 stable macOS arm64 installed via homebrew

I am unable to reproduce your issue. Is there a minimal_init.lua that will reproduce your issue? This is the current one I have to reproduce.

minimal_init.lua
-- `minimal_init.lua` used for reproducible configuration
-- Open with `nvim --clean -u minimal_init.lua`

local is_windows = vim.fn.has("win32") == 1
local function join(...)
  local sep = is_windows and "\\" or "/"
  return table.concat({ ... }, sep)
end

local root_tmp = is_windows and os.getenv("TEMP") or "/tmp"
local site_path = join(root_tmp, "nvim", "site")
local pack_path = join(site_path, "pack")
local install_path = join(pack_path, "packer", "start", "packer.nvim")
local compile_path = join(install_path, "plugin", "packer_compiled.lua")
vim.opt.packpath = site_path

local function load_plugins()
  local packer = require("packer")
  local use = packer.use
  packer.reset()
  packer.init({ compile_path = compile_path, package_root = pack_path })

  use("wbthomason/packer.nvim")
  use("edeneast/nightfox.nvim")
  use("nvim-treesitter/nvim-treesitter")
  -- ADD PLUGINS THAT ARE _NECESSARY_ FOR REPRODUCING THE ISSUE

  packer.install()
end

_G.load_config = function()
  -- ADD INIT.LUA SETTINGS THAT ARE _NECESSARY_ FOR REPRODUCING THE ISSUE

  require("nvim-treesitter.configs").setup({
    ensure_installed = { "lua" },
    highlight = {
      enable = true,
    },
  })

  require("nightfox").setup({
    options = {
      dim_inactive = false,
      styles = {
        comments = "italic",
        functions = "italic",
        keywords = "bold,italic",
      },
      inverse = {
        match_paren = true,
        visual = true,
        search = false,
      },
      transparent = false,
    },
  })

  vim.cmd("colorscheme nightfox")
end

if vim.fn.isdirectory(install_path) == 0 then
  vim.fn.system({ "git", "clone", "--depth=1", "https://github.com/wbthomason/packer.nvim", install_path })
end
load_plugins()
vim.cmd([[autocmd User PackerComplete ++once echo "Ready!" | lua load_config()]])

Thanks for the reply!
I tried the minimal_config and find that this bug only exists when I have another colorscheme(colorscheme <other_theme> in config) and then switch back to nightfox(colorscheme nightfox in cmdline).(NightfoxClean and NightfoxCompile are made sure before that)
But it works fine when explicitly call colorscheme nightfox in config. By doing so switching themes won't cause the bug.

I tried to add another colorscheme like catppuccin and set that as the colorscheme in the minimal_init config. Then switch to nightfox but still cannot reproduce.

Well, I think this is relative to my config. It's hard to reproduce as I use lua function to config a plugin like this.
-- in a file
use({"theme_A", config = conf.theme_A})
use({"theme_B", config = conf.theme_B})

-- in another file that stores configs
local M = {}
function M.theme_A() ... end
function M.theme_B() ... end
return M

I installed rose-pine theme and nightfox theme. And I call vim.cmd('colorscheme rose-pine') in rose-pine's config function.

This might be interesting to you. The way I manage my themes is with a cache file ($HOME/.cache/nvim/theme.txt). On startup I try and load this file if it exists and set the colorscheme if it exists. The relavant section of my config theme.lua. Since you are also using and settings your configuration in the config section of packer you need to make sure that the packer_compiled file is evaluated before trying to set your colorscheme. You can see how I do this in my main.lua. I have an interesting way of structuring my config you might find it similar to what you are doing.

Thanks for the idea!

@EdenEast Apologies for hijacking closed issue but didn't feel like such simple question justifies new one.
If I run compile command or call api, once cache file gets created, is it automatically loaded next time nvim starts? If so, am I suppose to not call setup() function again? I am trying to figure out some oddity/get autocompile on bufwrite event of file with setup() working.

The compile functionality is a way to speed up startup time so that you don't have to keep re-computing all of nightfox's inner tables. The compile file is   the result of nightfox's current settings defined into all the set highlight calls. Calling the setup function only adds to nightfox's internal overrides table. Only when applied with the colorscheme command will nightfox resolve the overrides and call all of the set highlights.
In the main function that applies the highlight groups it first checks if the precompiled file exists. If it does exist it will execute that file, instead of iterating though all the palettes, specs, and groups + overrides. This speeds up nightfox significantly.
When you are making changes to your configuration you should remove this compiled file with NightfoxClean so that nightfox will apply the palette, specs, groups and all the overrides.
TLDR: You should still define your setup function in your config. Execute NightfoxCompile once you are happy with your changes to get a speed increase. If you want to apply new changes make sure the compiled file is cleared so that the setup changes will be applied.
Hope this helped to understand how the compiled file works.

Thank you very much, it makes sense and describe what one would expect from such caching system.
Please convert to new issue if you think it's warranted.
I got:

nightfox.setup {
  groups = {
    all = {
      TelescopeBorder = { fg = 'bg0', bg = 'bg0' },
    },
  },
}

vim.api.nvim_cmd({
  cmd = 'colorscheme',
  args = { 'nightfox' },
}, {})

After saving file containing that setup call (which is require()d from my init.lua), exiting nvim, opening it again, running: clean and compile commands I get:
❯ grep TelescopeBorder nightfox/nightfox_compiled.lua
vim.api.nvim_set_hl(0, "TelescopeBorder", { link = "" })

Am I doing something wrong?

I am not able to reproduce your issue. Is there a minimal_init with reproduction steps. Are you on the latest?

Thanks for looking into it. Will try to come up with reproducible steps and open new issue if I manage.


AFFL_AccRecordType_TDTM not behaving as described in EDA Class Data Dictionary

Note: FOR INTERNAL USE ONLY. For support questions, please use the EDA Chatter group in The Power of Us Hub.
For feature requests, please use the Ideas tab in The Power of Us Hub.

Do you want to request a feature or report a bug?
Bug

What is the current behavior?
Currently, the AFFL_AccRecordType_TDTM class is described in the EDA Data Dictionary as:
When you change the record type of an Account, and it is a Primary Affiliation for a Contact, this class updates the Primary Affiliation to match the new record type. For example, if you change the Account's record type from Academic Program to Sports Organization, this class updates the Contact's Primary Sports Organization field. The class also creates a new Affiliation record for the Account designated as Primary. The previous Affiliation record remains, but Primary is deselected.

The class is not creating a new Affiliation record when the related Account type is changed. It is updating the existing Primary Affiliation record to reflect the new Account Type.

What is the expected behavior?
I'm expecting when a user changes the record type of an account, and it is listed as a Primary Affiliation for a Contact, the class creates a new Primary Affiliation record related to the Contact to reflect the new Primary Account Type and updates the existing record to have Primary deselected.

What is the motivation / use case for changing the behavior?
It's not working as currently described in the Data Dictionary.

Acceptance Criteria

Given: An Account is listed as a Primary Affiliation for a Contact
When: I change the Account Record Type on the Account Record
Then: A new Affiliation record for the related Account and Contact for the Account designated as Primary and the previous Affiliation record remains and is updated with Primary being deselected.

How to Recreate:
Demo Video
Setup:
Create Account Record: Name = Northeast Volleyball; Account Record Type = Sports Org.
Create Contact: Name = Suzie Student

Create a Primary Affiliation: Organization = Northeast Volleyball; Contact = Suzie Student; Primary = Checked
Verify that Primary Affiliation record is created and listed in Contact's related list and is marked as primary.
Update Account "Northeast Volleyball" to Business Organization Record Type.
View Contact "Suzie Student" Affiliations.
a. Verify that only one Affiliation record is present and it's updated to Account Record Type "Business Organization" and that the record is still marked as "Primary"
b. Verify that no new Affiliation record is created.

**lurch: add

**lurch: add

Tracking W-042844

A documentation update to EDA Apex Class Descriptions in August 2020 resolved this issue.


Nx set-sha's breaks on windows CI runs [Module not found]

Hi,
Nx set sha's action works on ubuntu and linux CI runs but will fail on windows.
I've created a minimal reproduction here: https://github.com/ryanbas21/nx-min-repro/runs/4551218496?check_suite_focus=true
This is the exact error I get in my CI runs.
I copy and pasted the DTE workflow file from the docs essentially.

Thank you for reporting the issue @ryanbas21.
We will look into it as soon as possible.

The issue should be fixed now in version v2.1.3 with https://github.com/nrwl/nx-set-shas/pull/12


Add optional close/shutdown message to AsyncWriteStream

Summary
This proposal adds an optional Receiver<()> field to AsyncWriteStream. When signalled, this gracefully closes the underlying AsyncWrite.
Context
This emerged from trying to implement wasi-blobstore.  I was passing the read end of a stream to a back-end provider, and the write end to the guest.  I was using wasmtime_wasi to store the write end in a resource table as a HostOutputStream because I didn't want to write a stream host interface myself!
The API specifies that the guest calls a "finish" method (on a separate outgoing-value resource) to indicate that it has finished writing to the stream.  However, because I was using AsyncWriteStream and wasmtime_wasi::HostOutputStream, my host didn't have access to the underlying AsyncWrite's shutdown function to EOF the stream.  So the reader at the back end would continue waiting for input.
My first plan was to add a shutdown function to AsyncWriteStream, but I couldn't downcast HostOutputStream to AsyncWriteStream, so that didn't work.  So what I ended up with was:

Have AsyncWriteStream accept the receiver end of a sync channel.
Have AsyncWriteStream run a background task which waited on the receiver.  When it received a message, it would enqueue a shutdown of the underlying AsyncWrite.
Have the manager of the outbound connection (in wasi-blobstore, an outgoing-value resource) hold the sender end of the channel.
When the guest called outgoing-value::finish, send a message via the sender.

This seemed to work, although it's not been extensively tested.
As an interface, it's awkward, because for most operations you interact with AsyncWriteStream/HostOutputStream via methods, but for this one special case you interact with it via a sync channel.  However, I don't see a way round that without adding a shutdown or close method to the WASI output-stream resource.  It's possible that WASI intends that shutdown be done by dropping the output-stream resource, but in my testing this seemed to result in an abort rather than an EOF.
So after talking to @alexcrichton I'm putting this up for discussion and in the hope that WASI folks can come up with a better solution.  Please let me know if folks need clarifications around the problem I was trying to solve or the constraints that led me in this direction!

The prior art for shutdown is in the wasi-sockets implementation here: https://github.com/bytecodealliance/wasmtime/blob/main/crates/wasi/src/tcp.rs#L641
Rather than shutdown be a method on a stream, its a method on the parent of the stream, in this case the tcp-socket https://github.com/WebAssembly/wasi-sockets/blob/main/wit/tcp.wit#L361-L385.
Can you restructure your blobstore interfaces to work in that manner, and then follow the architecture of wasmtime-wasi's  sockets in your implementation?

Thanks for the pointers @pchickey.  I'll try to implement that pattern.


fix(console): auth response interceptor, new assets, async route guard, pipe modules cleanup, disable custom idp editation for orgs, refresh list on idp creation

Closes #791

relates to #756

:tada: This PR is included in version 0.88.6 :tada:
The release is available on:

GitHub release
v0.88.6

Your semantic-release bot :package::rocket:


Gaps with multiple layers?

On some lines there are gaps or the renderer renders too much of the next tile, I don't know how to describe this:

(first line in the log and under the player)
I initialize the console like this:
    let font = "terminal8x8.png".to_string();
    let context = BTermBuilder::simple80x50()
        .with_font(font.clone(), 8u32, 8u32)
        .with_sparse_console(80, 50, font.clone())
        .with_sparse_console_no_bg(80, 50, font)
        .with_title("vortex")
        .build()?;

Any idea how this happened?
On a side note, I don't know exactly what I'm doing there with no_bg, I just needed two console layers and this looked like it worked.
Edit:
It looks fine when I don't scale it, but when I resize the window to some resolutions, it shows these artifacts on some lines.

I see the lines; that's an issue I periodically fight with, caused by the font scaling. Is this on the github version?

If you mean the github version of that game (vortex_rs), yes. It is reproducible there.

If you have time, would you mind trying pointing vortex at the current Github version? I believe that recent scaling work should have fixed the issue, but this would be a great chance to make sure.
bracket-lib = { git= "https://github.com/amethyst/bracket-lib.git" }

that gives me this:
error[E0425]: cannot find value `BUFFER_AGE_EXT` in module `ffi::egl`
   --> C:\Users\Admin\.cargo\registry\src\github.com-1ecc6299db9ec823\glutin-0.29.0\src\api\egl\mod.rs:584:27
    |
584 |                 ffi::egl::BUFFER_AGE_EXT as i32,
    |                           ^^^^^^^^^^^^^^ not found in `ffi::egl`

Do I need to use nightly or so?

You shouldn't, but that's good to know. I recently upped the glutin version, and it's working here. Maybe try a rustup update to make sure you have the latest toolchian? What platform/OS are you using? That's definitely one I need to hunt down.

Windows 10, I recently downloaded rust, so I should be fairly up to date. 🤷♂

I just checked out your repo. I see that you're using specs, so I updated Cargo.toml to:
[package]
name = "vortex"
version = "0.1.0"
edition = "2021"

# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html

[dependencies]
bracket-lib = { git= "https://github.com/amethyst/bracket-lib.git", features = [ "specs" ] }
specs = "0.18.0"
specs-derive = "0.4.1"
num = "0.4.0"

I don't see gaps - the scaling code seems to work:

Very odd that you got an FFI error. That's the "glutin" library looking for some C code in your OpenGL support. Maybe there's a driver issue? I don't have a wide range of systems to test on (I'm on a Win11 PC and it works).
I did just find a couple of other bugs trying to see if Vulkan/DX12 would work - so I'll chug away on those. Thanks!

And there it is in DirectX12:

[dependencies]
bracket-lib = { git= "https://github.com/amethyst/bracket-lib.git", default-features = false, features = [ "specs", "webgpu" ] }

(In case that works better than OpenGL for your drivers)

Yes, adding specs to features worked, but I guess it should still compile without it.^^ Thank you!
This probably will make it into the next version, but in the meantime I pinned my project to the current revision, so it won't break by accident. :)
[dependencies.bracket-lib]
git = "https://github.com/amethyst/bracket-lib.git"
rev = "10f2b9d3c237125e6a456dae0f291a4b6f18a5dc"
features = ["specs"]


Undo/Redo Issues

Undo/Redo is currently buggy. Do

Fix nullability issues
Try to identify and fix additional crashes as they happen.

Alternatively implement the following:

A command stack to record / rewind / replay user input.
A snapshot stack that records snapshots every now and then.
Both (for better performance)
A control that visualizes the undo/redo history

Note: logging and stack traces might be required to identify the issues.

I think it would be much better to fully remove undo/redo. It's a hurried implementation and is very hard to maintain and fix. It would be much simpler and easier to simply use the serialization/serialization routines instead of working with the current in-memory mechanism. Trying to fix and maintain the current implementation would be a nightmare. Better get rid of it even if it's not available for a while.

We might want to evaluate Undo/Redo frameworks.

Undo
ReactiveHistory

I had a look. I don't think these will be helpful. These solve the easy problem, which is solved in Math Editor i.e. the part that calls undo/redo. The troubled part is the actual code that applies the changes. It was not done very cleanly. If the bugs could be fixed, it will work though. But the code is hard to understand.


add https scheme check on urls

additional security
https://stackoverflow.com/questions/42662604/verifying-the-certificate-given-in-sns-message-signingcerturl

@jkan2


Bulk selection for patch level and risk of breaking changes

Use Case
As a user I would like to select all gems
based on the level of risk it takes to update them.
For example:
If I only want to update gems which will not break.
In this case a keymap to select all of them would be very helpful.

Interesting idea! Do you have a suggested key mapping for this? Right now our key mappings look like:

j/k/n/p vi and emacs up/down
a/r select all and reverse select (see #16)

Perhaps this?

shift-p select [P]atches
shift-i select m[I]nor
shift-j select ma[J]or
shift-s select [S]ecurity

Hey @mattbrictson
I do not have an idea what could be the mapping here. Your suggestion sound valid to me.

@sirwolfgang I agree; I think there are two slightly different features being discussed.
Right now, update-interactive resolves the Gemfile by trying to find the latest upgradeable version for each gem, and then displays those in a table for you to pick and choose. We can offer shortcuts to choose a subset of these updates based on risk. I think this is the feature originally requested in the issue.
A different approach would be to limit the Gemfile resolution algorithm itself, to only allow certain updates, similar to running bundle update --patch.
For example, consider your lock file currently has rack 2.2.7. To limit risk, you might want to update to rack 2.2.9 (the latest in the 2.x series) before going all the way to the latest, which is rack 3.1.7. Right now bundle-update will only give you the 3.1.7 option.
Because of the complexity of Bundler's dependency resolution algorithm, bundle-interactive can't know that both the 2.2.9 and the 3.1.7 options exist without having to re-resolve the Gemfile. So I think this is an option that needs to be provided up front, like bundle update-interactive --patch. I'll open a separate issue to capture this as a feature request.

@mattbrictson How about:

keystroke†
purpose

option-p
select patch-level updates

option-m
select minor updates

option-shift-m
select MAJOR updates

option-s
select security updates

† option would be alt on PC keyboards

@brandondrew I don't have a strong preference on the key bindings; your suggestions seem reasonable to me. Although, I am not sure how easy/reliable it is to detect whether a keyboard uses "alt" or "option". To show a good help message, it would be nice to display the key binding appropriate to the user's keyboard.
BTW, I currently don't have plans to implement this enhancement. I would be happy to accept a PR, though.

The simplest method would be to use the user's OS:
macOS: ⌥ Option
Linux:   Alt
Windows: Alt
Although a Mac user with a Logitech keyboard (for example) might actually have "alt" on the key (or both "alt" and "option"), the OS itself will refer to the key as "option" or with the symbol "⌥".   Some older Apple keyboards had both "option" and "alt", presumably to make it easier for switchers from Windows—since that was a huge market in the early days of Mac OS X.
A Linux user might occasionally be using Apple hardware, but again their OS will generally refer to the key as "alt", so I think it's not a problem to make assumptions based on the OS.
It might be possible to get access to the actual keyboard information in Ruby—I don't know—but it seems like potentially a lot of extra work for a very small pay off.  A dubious payoff, in fact, since (for example) a Mac user with a Dell keyboard probably still thinks of the key as "option" even if the keyboard says "alt".  Simply using the OS to decide what to call the key is easiest and also gives the user consistent UX.


A problem when escaping backslash in a string

When escaping backslash in a string, it thinks that I'm escaping the ending (") and treats the rest of the code as a part of the string.

Just a tip – looks like you aren’t using true colour (set termguicolors) in Vim. If you can, I would strongly recommend it, because I find it looks much nicer with :)


Issue with Template Wall Collision module

Describe the bug
Issue with CollateAuras.js when running the module with the Template Wall Collision module. This has been raised with the Template Wall Collision module as well. Issue #6
To Reproduce
Steps to reproduce the behavior:

Install Active Auras, Template Wall Collision, and dependencies.
See error in Dev Console

Expected behavior
No errors
Environment:

OS: Windows 10
Browser Chrome/Edge
Foundry Version V9.242
Module Version 0.4.02
All Modules Disabled: Yes

Additional context
Error in Dev Console:
aura.js:176
 Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'id')
    at Function.UpdateToken (aura.js:176:36)
    at Function.UpdateAllTokens (aura.js:111:25)
    at Function.MainAura (aura.js:42:27)
    at CollateAuras (collateAuras.js:65:21)
UpdateToken	@	aura.js:176
UpdateAllTokens	@	aura.js:111
MainAura	@	aura.js:42
CollateAuras	@	collateAuras.js:65
await in CollateAuras (async)
(anonymous)	@	AAhooks.js:22
_call	@	foundry.js:294
callAll	@	foundry.js:253
setupGame	@	foundry.js:5547

I dont see how anything here relates to the Wall Collision module?
It either means it cannot find the correct token to measure against, or the source of the aura

I don't know the cause, but if I turn off the Wall Collision module I do not get the error.


Error starting timeout

I am getting this error maybe is connected to #403?
The log when this error is happening: https://pastebin.com/qwGYmnFu
Anyway this error block the opening of the various buffers with the informations.

After upgrading vdebug , I have the same error showing up during debug... when an ajax takes some times (difficult to measure that)

Could you create simple steps to reproduce? I have tried to reproduce but not yet encountered this socket.timeout issue

@Mte90 I don't think the timeout is related to the empty stacktrace

when I tested I changed the code to get more seconds, as I can remember the error was still there.

It is difficult to make steps to reproduce. But for me I can reproduce each time I have a process on backend that takes more than 30s to process. eg. series of ajax calls (short ones) are perfectly fine. Then one request needs to wait for a backend task to finish like an upload to some server, big file, upload times is more than 30s. then the error message appear on vim.
I have tested two versions of vim: (on ubuntu)
version: 2:8.1.2269-1ubuntu5
and version: 2:8.2.1767-0york0~20.04
same result

Something I did which endup losing the connection.
Put a breakpoint at a first line method.
next is sleep(30);
then another breakpoint next line.
When running. Vim breaks at the first breakpoint. Then when pressing F5 then display a connection closed after around 10s.

So Error starting Vdebug: <class 'socket.timeout'> appears when performing an xhr call.
Otherwise the message is Connection to the debugger has been closed.
But both occur if the "task" takes more than 4s. until 4s everything is fine. 5s then errors shows up.

@dave2309 thanks, I'll look into it further

I may have found something

@dave2309 the client should not set the timeout there, I overlooked that

Thanks for the additional input, this helped finding the issue

nm
I use vdebug quite intensively. I would have love to PR but I don't have enough knowledge of vdebug internal to propose yet.
Glad I could help


refactor(sensor): inherit EqMixin and remove eq in intrinsic classes

CameraMatrix
DistortionCoefficients
CameraIntrinsics

Pull Request Test Coverage Report for Build 840900522

4 of 4 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.07%) to 79.898%

Totals

Change from base Build 838917844:
-0.07%

Covered Lines:
4245

Relevant Lines:
5313

💛  - Coveralls


ctlv3: ensure synced member list before printing env vars on member add

In cases of multiple endpoints, it's possible member add would get a its
member list from a member that has not yet recognized the membership
update. Instead, confirm that the member list response is from the
member that acked the member add or from a member that has synced
with the cluster following the member add.
Fixes #7498

This is kind of a hack. Member{Add,Update,Delete}Response should probably include the member list for the cluster so the commands are atomic.

I am OK with this hack to solve the immediate problem. Returning the entire list for modification also seems OK.

lgtm. shall we backport?

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@18a813a). Click here to learn what that means.
The diff coverage is 50%.

@@            Coverage Diff            @@
##             master    #7499   +/-   ##
=========================================
  Coverage          ?   70.09%
=========================================
  Files             ?      320
  Lines             ?    26184
  Branches          ?        0
=========================================
  Hits              ?    18354
  Misses            ?     6376
  Partials          ?     1454

Impacted Files
Coverage Δ

etcdctl/ctlv3/command/member_command.go
74.1% <50%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18a813a...3e86779. Read the comment docs.


Improved floating point for layout constraint and added functional test. (#594)

Fixes #594

@khandpur Made changes.


Theme prompt_command function not executed when including system bashrc

If a user wants to keep including their system /etc/bashrc in order to for example utilize the system installed bash completions, then they are not able to overwrite the system PROMPT_COMMAND function using the standard prompt_command function name in the themes. This is because the great majority of the bash-it themes use exactly prompt_command as the name of their prompt command function whereas the /etc/bashrc (in the case of Fedora) sets a similar __vte_prompt_command function name. This causes this case statement to always satisfy the *$1* case and never execute the custom theme's prompt_command function because the wildcards match prompt_command as a substring of the system's __vte_prompt_command function.
A few possible ways to fix this come to mind immediately:

Every theme would need to use a different name other than prompt_command as their function name to make sure the wildcard does not match their function name as a substring. Seems too late for this.
Somehow change the case statement to check that the caller's argument $1 is matched exactly and not a wildcard match for the substring existing in the PROMPT_COMMAND variable.
Perhaps unset the PROMPT_COMMAND variable the first time safe_append_prompt_command is called.

Interesting catch! To fix this, I suggest rewriting the case statement that you linked to (https://github.com/Bash-it/bash-it/blob/2b4298c00ea882026134c1d8f5da93d52fbaf6ae/themes/base.theme.bash#L468) to use an if statement with a real regular expression, checking that there's a full match on the name (e.g. \bprompt_command\b) to avoid the situation you describe.
I guess we'd need one if that checks for the empty case, one for a full match, and else for prepending the parameter to the PROMPT_COMMAND variable.
That's closest to what your second suggestion looks like.
Please feel free to provide a PR for this.

Closing as this is now working (see #888).


Compatibility with 0.10 extmark sign

After https://github.com/neovim/neovim/pull/26193 , the internal implementation of the diagnostic signs changed to the new extmark-based sign, sign_getdefine will no longer work for diagnostic signs.
I see the call of sign_getdefine is implemented by vimscript, which I am not familiar with. Refer to https://github.com/nvim-neo-tree/neo-tree.nvim/pull/1265/files .

Thanks for letting me know @ofseed. I updated the code in b67dcc178ba4cac1858512e5ce2bd90e16e74c43. Does that fix the issue for you?

Yes, thanks a lot.


Docs cleanup

Summary of changes:

[x] Update references to the training website to point to the learning platform
[x] Add helpdesk site as the prefered form of contact
[x] Remove characters that break translation
[x] Add new deafrica_tools modules to the documentation
[x] Add xarray CSS fixes from Kirill
[x] Point to correct Geoportal URL
[x] Add language switcher in header
[x] Move "Direct access" from data specs section to platforms, with the other access methods

Still in progress

[ ] Copy over Sandbox user guide from training site, and add links to helpdesk KB/FAQ
[ ] Copy over Explorer user guide from training site
[ ] Change data specs to link to docs "Web services for GIS" rather than training site tutorial
[ ] Tidy up sandbox contents page
[ ] Tidy up home page images

General note (I can do this too at some later point but don't want to forget) - the docs Contact & Help page needs a little more info including links to the Helpdesk ticket system / knowledge base article


Add r5r and related paper

This PR moves the mention of R5 to the GTFS Analysis Tools section, and adds links to the r5r wrapper package and a recent academic paper with performance benchmarks for these analysis tools.

Thanks @ansoncfit!


HHH-11161 - Prevent initialization of extra lazy collections

https://hibernate.atlassian.net/browse/HHH-11161

Applied upstream. Thanks.


Random failure in Core-API-Tests-ocis-storage-6

This pipeline was red: https://drone.owncloud.com/owncloud/ocis/884/27/7
Reason:
\| new         \| ",,,.txt"      \|
--
2144 | HTTP status code was not 201 or 204 while trying to upload file '/welcome.txt' for user 'Alice'
2145 | Failed asserting that an array contains 401.

A restarted version of the same code had the same pipeline green: https://drone.owncloud.com/owncloud/ocis/888/27/7
Needs investigation.

@kulmann ran the related tests numerous time locally still, no fails

@kulmann ran the related tests numerous time locally still, no fails


Sonos responsiveness improvements + enhancements

Description:

Event based notification directly from the speakers.
Async state updates.
Optimizations to minimize chattyness with speakers.
Preloading/caching of album art for next song.
Extracting "Information" or "Now" data for radio streams (show as the secondary text in the UI).
Disable previous/next track actions for first/last item in a playlist/queue.
Event based volume/mute changes from speaker, so that volume_level and is_volume_muted don't need to do network IO.
More robust method of detecting when a radio stream is being played.
Detecting title for next item in playlist/queue (this is currently not exposed, will require changes to media_player and UI).

This code applies a patch to SoCo automatically and works around another SoCo issue, I have submitted a couple of PR's to SoCo (the code will work without them):

https://github.com/SoCo/SoCo/pull/437
https://github.com/SoCo/SoCo/pull/438

Checklist:
If the code communicates with devices, web services, or third-party tools:

[x] Local tests with tox run successfully. Your PR cannot be merged unless tests pass

@pvizeli Thanks for the review. Some points:

The image cache is there to reduce the latency between selecting the next track in a playlist (pressing the next button) and the album art appearing. During my experimentation I found that most of the latency was being spent on the request from HA to the speaker. This becomes more extreme if you have several instances of the same album art being display (e.g. when grouping speakers, or running multiple UI's). I can however remove this from this PR and make another one later so that we can discuss that separately. Would that be acceptable or do we want input from others on this as well?

Regarding the asyncio stuff, most of the updating is being done based on the data in the events from SoCo (the event handler is a coroutine), and my plan was to increase that further, so that the entity could be fully driven (asynchronously) by the events. In the meantime it might make sense to replace the SoCo wrapping async methods with one or two methods that do all of the work at once, would that be acceptable?

The SoCo PR's have been accepted and merged, I'm not sure about the release schedule there. Not sure what the policy is in these things, Realize that we don't want to implement device specific code in HA, but one could argue that most of the code in sonos.py is device specific. Is it not acceptable to have workarounds for problems in device specific code? Or do we always want to wait for fixes to trickle out?

😍 . Thanks so much for this, it looks great.
As for the requirements and the SoCo release scheduled etc. you can just point to a specific Git commit in the requirements line. For example, here's the GTFS sensor requirements:
REQUIREMENTS = ["https://github.com/robbiet480/pygtfs/archive/"
                "00546724e4bbcb3053110d844ca44e2246267dd8.zip#"
                "pygtfs==0.1.3"]

Even your own fork of SoCo is acceptable. The only rule is it must be a specific commit, not a branch.
I also really don't like the patching. Would rather see you make the chance on your fork and point requirements to that. As @pvizeli said, the mocking is also a no go since it is device specific code.
Looking forward to seeing this in 0.32!

This looks great, this will improve the reliability of a few of my automations massively.

Hi,
Made some changes:

Removed SoCo patching and updated dependency to point to my SoCo commit. I asked them about a new release, but since they just released it will not be immediate.
Fixed the file permission changes.
Now we only fetch speaker_info if we don't already have it. We were fetching it for every call to async_update before, but were not getting the latest info anyway (SoCo caches it). Now we fetch it and force SoCo to go over the network initially. This basically means that we will not detect any changes to the speaker name (which is unchanged behavior).
I confirmed, that when receiving events from the speaker we only ever make one "async wrapped" call to SoCo (_async_get_media_info in line 480), all other data is pulled from the event. The update method is still being polled by HA, and I think we should keep it that way for now, it is useful if the event subscriptions from the speaker break down (which to be fair, I have not seen happening).

Also, I did not remove the image caching since @balloob seems to like it, I could pull it out and put that into a separate PR later if you wish.

@bjarniivarsson my view is that it's a positive change unless we have problems.

I have no idea why the checks are failing, does not seem related to my changes.

@bjarniivarsson test looks fine, could you re-run script/gen_requirements_all.py to see if it yields any changes?
Also the coverage has decreased by .1%, this can't be merged until that's resolved.

@lwis @bjarniivarsson Coverage decreasing by -0.1% is within tolerance levels. Coveralls is a bit hit or miss sometimes like in this situation.

@lwis @pvizeli Implemented async loading of album art with a very simple (no new dependencies) caching solution. I had some problems deciding where to get the aiohttp.ClientSession to use for the loading and ended up putting it on the HomeAssistand (hass) object. The documentation encourages that application use a single global ClientSession instance for all communication. I could put it somewhere else (even create a new one every time, but then we loose the keep-alive functionality).

Someone beat me to the global ClientSession :)

@lwis thanks for approving :) I wanted to keep it simple for now, I'll have a look at alternatives and if I see something good, I'll make another PR for that.

Tests are failing due to flakiness. Other than that, looks good to merge if everyone is cool. Looks good to me!

So, want to chime in here, I'm a bit late, I know that a lot of work has already been done. However, I don't think that it has any benefit to use any async stuff if the underlying lib is not async. In that case we will run everything in the executor and by not migrating anything, Home Assistant will run the whole update sequence in the executor - probably faster overall.

A lot of this PR is usable and good though.

Optimizations to minimize chattyness with speakers.

Preloading/caching of album art for next song.
Extracting "Information" or "Now" data for radio streams (show as the secondary text in the UI).
Disable previous/next track actions for first/last item in a playlist/queue.
Event based volume/mute changes from speaker, so that volume_level and is_volume_muted don't need to do network IO.
More robust method of detecting when a radio stream is being played.
Detecting title for next item in playlist/queue (this is currently not exposed, will require changes to media_player and UI).

Thanks again for looking at this PR. If the async stuff is prevent this from being accepted, I'll go ahead and pull that out, probably should not have done that along with all the functionality improvements. Let me know if I should do it :)

It is a greate PR anyway. Thanks for you hard work I like to use on my sonos 👍

@balloob @robbiet480 Removed the async stuff, and again there are unrelated (to me) tests failing :(

Tests are failing due to unrelated flaky tests, this is good to merge.

I think this is it, one glitchy test failing.

So happy that I get to be the one to hit merge on this 😺

This PR introduced some serious test slowness for Sonos. It's printed at the end of every test run on CI.

Absolutely @balloob, I'll have a look, should have some free time over the weekend.


Add Angular 8 support (close #478)

Additional notable changes:

Enable lazy loading by default
Migrate services to use providedIn
Add @ionic-native/keyboard package for Cordova target
Disable AOT for serve task, to speed up rebuilds

Waiting for this release

I'm getting a compilation error with angular 8.0.2 that I don't think was occurring in 8.0.0.
ERROR in ./src/app/core/http/http.service.ts 30:12-27 "export 'HttpInterceptor' was not found in '@angular/common/http'
Might want to check that this PR is using 8.0.2 and is compiling successfully.

This one migration has been particularly awful, and it's not even enabling Ivy or new lazy-loading system (tried it, didn't work 🤣).
Hopefully this will me mergeable soon🤞

Finally! 🎉 🍾 🎊 😃
Seems that CI flakyness (#480) with Ionic 4 also solved itself with the upgrade 😎


Feature Request: USB Audio Output

I recommend a output feature (USB Audio device or serial). This would allow integrating this into upstream (4g, wifi, ...) observation networks easily without the need of adding those features on the AudioMoth.

Reference Example for ESM32:
https://www.silabs.com/community/mcu/32-bit/knowledge-base.entry.html/2016/04/04/usb_audio_examplesf-k9Zz

See https://www.openacousticdevices.info/usb-microphone.

Done. See the AudioMoth USB Microphone firmware.


switch to relocate able binaries

requires a new bootloader to relocate the binary

I will merge this PR because it is required to avoid a bug in the nightly compiler and to support relocatable binaries. Tests with uhyve failed because hermitcore/uhyve#32 is not merged.


Ractive @state RFC

With @evs-chris' work on #2250 which introduced the @ractive keyword, it did most of the heavy lifting to open the door to a state mechanism that works in along side with ractive data.
how it works

Because having to use the prefix<EMAIL_ADDRESS>would litter the template with extraneous noise, at parse-time, refs that use the format {{@foo}} are treated as aliases for state on the ractive instance, except for the the reserved keywords keypath|rootpath|index|key|ractive|global:
new Ractive({
    el: 'main',
    template: `{{@foo}} {{@upper(bar)}}`,
    data: { bar: 'bar' },
    foo: 'foo',
    upper ( str ) { return str.toUpperCase(); }
});

The double @@ is an alias for @ractive.root, with the intent being global "app" state. For example, if you add a user property to the root instance, you can access {{@@user}} anywhere.
new Ractive({
    el: 'main',
    template: `<child/>`,
    data: { content },
    user,
    components: {
        child: Ractive.extend({ template: `{{@@user}}` })
    }
});

The api also supports @foo, so you can use it in computations or anywhere else you would access keypaths.
ractive.get( '@foo' );
ractive.set( '@bar', 'barzy' );

State behaves differently than data in the following ways:

State is always bound to the ractive instance and not the context stack, which makes sense as it refers to a property of the ractive instance.

As a corollary to 1., there is no lookup of state up the context stack or up the component stack. It's always on the instance.

Given those rules, when passing state between components:

State can be passed into components and become data:
<child bar='{{@foo}}'/>

In this case, it is mapped like normal component data and bar will update as @foo updates in the parent and vice-versa.

State can be set in components (from either parent state or parent data):
<child @bar='{{@foo}}' @qux='{{bizz}}'/>

However, when setting state on a component it is copied and not mapped. Object references would of course point to the same object, but would not be updated if changed to another instance in one and not the other. So passing state works as a starting point for the state on the component much more like a traditional js function parameter.

concerns

@state exists on the instance, so it is possible to munge the ractive api, so perhaps these should be disallowed at parse time.
Also, there are internally used property names like ractive.viewmodel that probably need to get changed to ractive._viewmodel or added to the disallow list.
While this is all optional, and based on use cases people have shared, perhaps it is more confusion than help.

misc
An additional level of state that could be added would be using a property prefixed with @ on an existing data model. This would allow it to be associated with that data model keypath without actually writing it to that data. So it would look like: {{ someObject.@foo }}, {{ this.@selected }}, etc.

Interesting! Here are my random thoughts thus far:
I like the shortcut syntax, and as far as comprehension goes, there is pretty good precedent from handlebars and ruby. My only immediate concern is that computations are referenced as @whatever.foo(), and I've been looking at extending a few outstanding computation issues by allowing set and update with those keypaths. Of course, there's no reason we couldn't also swap the computation prefix to # or some other illegal reference sigil. I'm thinking that setting/updating derived computation keys should probably be explicit too, though, e.g. ractive.set('@my.expr().foo', 'yep', { computed: true }) if that PR makes it. I'm not sure though.
I think this could also open an avenue to resolve some of the confusion around method events as a breaking change. The existing method events could be swapped to the @ state syntax e.g. <button on-click="@someMethod(event, etc)">Yep</button>. That would allow events to use regular refs to look up the event handler fn from data. That would be consistent with what I've seen about what most seem to infer about how method events work. It still doesn't handle the proxy event shortcut of on-click="foo:{{bar}}" vs on-click="fire('foo', bar)", but I think another sigil shortcut would help e.g. on-click="#foo(bar)" where an expression is parsed between the # and the first un-matched ( to replace the on-click="{{ foo ? 'bar' : 'baz' }}:{{bippy}},{{boppy}}" syntax with on-click="#{{ foo ? 'bar' : 'baz'}}(bippy, boppy)" or perhaps on-click="#(foo ? 'bar' : 'baz')(bippy, boppy)". Anyways, if you made it this far, that segue was mostly looking toward syntactical and conceptual unification and consistency.
As far as the bits of state that a Ractive instance holds, perhaps it would be best to move them into a _private object that swings off the instance. Object.keys is showing 27 properties on the first instance that was handy, all but about 5 of which should probably not be exposed.
I also like the idea of state paths external to the data that live in a sort of shadow data tree. I don't have much use for them personally, but it seems like it would solve some issues for a fair number of others.

From a zero-internal-knowledge-of-internals point of view:

So it's somewhat like this https://github.com/ractivejs/ractive/issues/2183

Can they be set from the parent (i.e.: <foo @somewhere="here">)?

Multiple instances? Are they shared or are they cloned for each instance?

Nested data?

Does that mean I can pass anything other than keypath|rootpath|index|key|ractive|global? Can I reference configuration (i.e.: {{@data}}, {{@isolated}})?

If so, can they be modified on runtime? Read only?

Is there some weird side effect when I deal with nested data?

It may confuse the method syntax (<foo on-click="someMethod()" /> vs <foo on-click="{{ @someMethod() }}" />) like this https://github.com/ractivejs/ractive/issues/2176.

They look almost the same until one realizes one needs {{ }} and it's actually a value.

It's like a getter-only computed prop, I like it.

Can I return a function from it? What happens to the function? Does it get assigned to the event?

In what context are the methods executed in?

At what phase in the lifecycle are the methods executed and in what order?

I'm :+1: , just a few clarifications that may need documentation.

holy shit, how did I miss this one?! @martypdx I really like this proposal a lot. also, you totally blew my mind with the @ractive.root thing. appears I'm gonna need to go back and change some ugly code now that I used to hack around that, thanks :)
some thoughts:

I really appreciate the way that this PR changes the way I fundamentally see the interactions between components. mentally, it clears a lot of things up for me. I did not realise this was even possible.

I dislike the inconsistency of @ being a shortcut for @ractive except for the cases where it's keypath|rootpath|index|key|ractive|global - that's annoying, but I totally can live with it ;/

holding state like this would make it easy to turn the root component into a state machine which simplifies things like logged in/out. (eg. add a function to allow for transition between defined states - logged('in'))

assuming this gets in, I think explaining this differentiation between state and data in the docs will be a clear guideline for new users to correctly build ractive apps and not mix state and data in the data (like I did), which would naturally clear up the docs quite a bit. :+1:

and, a question: if I understand you correctly, we can read/modify the state of the root component, but not its data, right?

can we get others to weigh in on this PR? personally, I'm quite fond of it. I REALLY like the idea of separating data and state like this

i guess i'll chime in with a description of the 3 phases i go through when using state in ractive.
the beginning: man it would be awesome if i could store state outside of data, that way i can do xhr stuff with data and not worry about it being littered with extraneous state properties.
the middle: i can't do the above so i guess i'll just segregate data into something like
data: { state: { ... }, realData: { ... } }
the end: crap, i actually need state information on nested objects within data, e.g. while each-ing over an array of items. well i could try to store the state in an equivalent structure but outside of data... nah too much of a hassle, i'll just jam the state into data.
so, the misc part at the end of the original comment is actually what interests me the most. and if you stick with the @ symbol, then it kind of makes sense because they're not "real" properties, they're something managed by the ractive instance like @index, @keypath, etc just with the bonus ability to write to them.


Add @Expensify to React Native Partner list

Summary:

Adding @Expensify to the React Native Partner list
Changelog:

[Internal] - Adding @Expensify to the React Native Partner list
Test Plan:

N/A - Just documentation update

Hi @AndrewGable, 👋
Congratulations 🎉 on your "First Pull Request" to React Native! 🥳
Thank you, 🙏 for taking the time to contribute to this project and share your ideas.
Someone from the team will review your PR and get back to you as soon as possible with feedback if any. 😊 Post review, and if all tests are passing, your PR will be imported to internal FB phabricator and should be merged if it also passes all internal tests. 🥳

P.S.: In the meantime, you should go through below checklist: (click to expand)

Make sure you have signed the CLA 📃🙂,
There are no typos 😄,
All tests 🧪 are passing. i.e. The CI checks should be green 🟢, and
You have added necessary tests for your code, if it's a refactor or a new functionality. 🧪

Contributing Guidelines | React Native Website | Framework discussions, proposals and RFCs

@AndrewGable makes absolute sense, Expensify is such an important partner in the React Native community!


Merging Develop into Master

By submitting this pull request, I confirm the following:
Please fill in any appropriate checkboxes, e.g: [X]

[X]   I have read and understood the contributors guide, as well as this entire template.
[X]   I have made only one major change in my proposed changes.
[X]   I have commented my proposed changes within the code.
[X]   I have tested my proposed changes, and have included unit tests where possible.
[X]   I am willing to help maintain this change if there are issues with it later.
[X]   I give this submission freely and claim no ownership.

What does this PR aim to accomplish?:
A detailed description, screenshots (if necessary), as well as links to any relevant GitHub issues
README updates and merging Travis/Codecov files.
How does this PR accomplish the above?:
A detailed description (such as a changelog) and screenshots (if necessary) of the implemented fix
Me editing things.
What documentation changes (if any) are needed to support this PR?:
A detailed list of any necessary changes
None.

You must follow the template instructions. Failure to do so will result in your pull request being closed.
Please respect that UMU is developed by volunteers, IE: me, who can only reply in their spare time.

Codecov Report

Merging #20 into master will increase coverage by 11.37%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master      #20       +/-   ##
===========================================
+ Coverage   57.13%   68.49%   +11.37%
===========================================
  Files           1        1
  Lines         660      660
===========================================
+ Hits          377      452       +75
+ Misses        283      208       -75

Impacted Files
Coverage Δ

Travis/travis_usmu.sh
68.49% <0%> (+11.37%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f2adb6...f204e9c. Read the comment docs.


[Bug] Remove the state mandatory in the tax rates configuration

Is your feature request related to a problem? Please describe.
When a country has states (country_states have records for the country), then the field "State" in the tax rates form become a dropdown box and is mandatory. Normaly, the tax rate is only country dependant.

Describe the solution you'd like
This field must be optional
Describe alternatives you've considered
No response
Additional context
No response

Hi, by removing the highlighted code in the ../taxes/rates/edit.blade.php file as following (the complete path is on the picture), the job is done.

Kind Regards

Checked and found the State Mandatory is removed in Tax Rates ->  https://prnt.sc/JAfkJjmPIbkS

@ashishkumar-webkul It's perfect :+1:

@helgvor-stoll
Thank You So Much for the contribution towards Bagisto, we really appreciate it. Looking ahead for more work.


feat(stats): replication latency stats

This PR is to add replication module related latency details to istgtcontrol -q iostats command.
.Replicas[*].ReadReqTime gives the time taken to send read IO request to replica in replication module.
Similarly, .Replicas[*].WriteReqTime is related to write IO request.
.Replicas[*].ReadRespTime gives the time taken to receive read IO response sent to replica in replication module. Similarly, Replicas[*].WriteRespTime is related to write IO request.
This also changes the clock_id from CLOCK_MONOTONIC to CLOCK_MONOTONIC_RAW, and uses CLOCK_MONOTONIC_COARSE in timer related functions.
Fixes an issue with replication_test regarding the scenario when mgmt opcode (for ex, STATUS opcode) is received when partial data IO is read.
istgtcontrol -q REPLICA output is also changed to use same API for iostats and replica options. Change is .volumeStatus.replicaStatus[*].status to .volumeStatus.replicaStatus[*].Mode. This need changes in litmus repo as well. This needs change in maya repo also.

resolved the review comments


unix/fs: Fix copyfile() when using FICLONE fails -- bugfix only

Fixes uv_fs_copyfile() in cases where a yet unknown error occurs when copy-on-write is requested by setting UV_FS_COPYFILE_FICLONE. The original approach tried to catch some of the errors raised by the ioctl() call, assuming that sendfile() would then also fail. This is not necessarily true, some (older) variants of ioctl() also raise EINVAL (some maybe EBADF), but sendfile() works just fine (#2483).
This change reverses the logic, falling back to sendfile() in any case when ioctl() returns an error, i.e. trying harder to successfully copy the file.
Fixes #2483 and related downstream bugs, most notably jupyterlab/jupyterlab#6969 and probably yarnpkg/yarn#7440, yarnpkg/yarn#7152 as well.
Supersedes #2514

I'll close this out because it seems like we're going to go with your other PR (https://github.com/libuv/libuv/pull/2514) instead. Thanks!


Add Defer os.Remove before starting runtime proxy server

Signed-off-by: Cheimu<EMAIL_ADDRESS>Ⅰ. Describe what this PR does
Try to unlink runtime proxy endpoint socket file when starting runtime proxy
Ⅱ. Does this pull request fix one issue?

fies #246
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews

/cc @ZYecho @honpey

/cc @jasonliu747

/approve


Bump framework version range

$subject
Related issue:

https://github.com/wso2/product-is/issues/19717

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/7984934482

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/7984934482
Status: failure


New trial build for esm1.6 using generic tracers and iceberg freshwater fluxes in cice4

:rocket: The latest prerelease access-esm1p6/pr27-4 at fa3a855ee802a431cf635c73459ca524f2d7b406 is here: https://github.com/ACCESS-NRI/ACCESS-ESM1.6/pull/27#issuecomment-2547328346 :rocket:

!redeploy

Seems to me like pr27-4 is equivalent to pr27-5: https://github.com/ACCESS-NRI/ACCESS-ESM1.6/actions/runs/12365231802/job/34509896472#step:9:669


fix(bootstrap): move to production only in bootstrap

wait that's not complete I believe

Ok it's good I only thought we needed to send back the state in the resolve of bootstrap but its not needed. merging!


brain dump

please proof read.

e.g. the tagging explanation seems a bit bumpy to me and I was struggeling to include a statement along the lines "not to be confused with flavour tagging at atlas/cms, where it often refers to determination if a jet contained a b-quark or not"
I did not (yet) check if the links work

It might make sense to rebase this on master ...

@pseyfert, any updates?

In the end I just made the changes/fixes myself.


Android Basics: display-list-cards, typo

URL of codelab
https://developer.android.com/codelabs/basic-android-kotlin-training-display-list-cards?continue=https%3A%2F%2Fdeveloper.android.com%2Fcourses%2Fpathways%2Fandroid-basics-kotlin-unit-2-pathway-3%3Fhl%3Den%23codelab-https%3A%2F%2Fdeveloper.android.com%2Fcodelabs%2Fbasic-android-kotlin-training-display-list-cards&hl=en#2
In which task and step of the codelab can this issue be found?
Change the app theme colors > Add color resources > Step 1.
Describe the problem
Typo. It says "Open colors.xml (res > color > colors.xml)."
Should say "Open colors.xml (res > values > colors.xml)."
Additional information

@skatingtamara
Thank you for reaching out to us. The issue is fixed and the correct path will be published soon:


Relax the smoothing / filtering of individual speeds

It appears that the APEX Pro and VERTIX have fairly agressive smoothing being performed on the individual speed readings.
This is especially noticable in the 2s results which can often be 0.5 knots or even over a knot slower than other comparable devices.
It is not clear whether this is a specific mode of the Sony Kalman filter or some kind of smoothing / filtering within the COROS code but similar artefacts have been observed in Garmin Fenix 6 tracks (same Sony chip).
However, in a sport where competitors are trying to maximise their speeds, reporting slower than the benchmark devices is not ideal.

I have stumbled across the user's manual for the Sony CXD5603GF GNSS chip which I believe is in the APEX Pro and VERTIX:
https://github.com/Xinyuan-LilyGO/LilyGO-T-Motion/blob/master/datasheet/CXD5603GF_UsersManual_E_013_TianQin.pdf
It may be related to the GNSS positioning algorithm for the special use case (swinging the receiver by the hand).
This enabled by default (see @GUSE command) and should not be activitated for speedsurfing or windsurf activities.


actions.acknowledge_problem() persistent flag

Hi,
is this project still maintained?
would it be possible to add persisten flag in actions.acknowledge_problem()
the parameter is available in API for acknowledge-problem:

persistent
Boolean
Optional. When the comment is of type Acknowledgement and this is set to true, the comment will remain after the acknowledgement recovers or expires. Defaults to false.

Hi, i will take a look into this.

I am slightly confused - the persistent flag is not part of "add_comment" but only of "acknowledge-problem".
I will try to add an additional parameter for "optional" arguments.

Hi,
yes because a comment is always persistent...the sence behind is ..if the service switch back to OK an acknowledgement comment will disapear by default...to avoid this the persistent flag can be used

corrected title you are fully right acknowledge_problem should have persistent flag
sorry

The method actually has a parameter for the persistent-flag:
https://github.com/joni1993/icinga2apic/blob/master/icinga2apic/actions.py#L264

oh sorry you are fully right...just tested it again and its working...probably update DOKU


Add standardised enumeration for Country letter code

In order to prevent total chaos, select one standardized country letter code and implement it.

Ideally there should be an information button or similar for the PM or person, who prepares the offer, which standard is being followed here. E.g. display a list or offer a link with further information on the standard, etc.

After some research, i suggest we go for the simplest solution in international mailing: full name, and in caps when on a letter. Done

#297

 Add country enum to create affiliation use case


Daily Reports Chart only shows data from production

Since all other data on the page changes to show data from the currently selected environment, it would make sense for the Daily Reports Chart to also show data from the selected environment. Currently it only shows data from production, or so it seems. We currently have no nodes running against the production environment on our dev puppet 4 server, so there is no data in the chart even when our dev environment is selected and node data shows up everywhere else.

Correction: the Daily Reports Chart shows the data from whatever environment is configured as the default for puppetboard. I still think when switching environments in the interface, it should update the chart with the data from the selected environment.

What tab are you referring to for daily reports, Overview?

I have attached a screenshot with the area I'm referring to circled. This screenshot shows our "dev" environment, which is the default environment in the puppetboard configuration, and shows the correct numbers for changed/unchanged/failed. In the second screenshot I have attached, I selected the "production" environment which only has 1 host currently. The bar charts still show the numbers for the "dev" environment when instead it should be showing the numbers for "production"

I doubled checked, a change was submitted to fix this: 3b817e0a5ed3e1029a61b55e5c9197d6cb25f30c
This change has not made a pypi release yet.  What version are you on?
I just tested with Safari and the latest head release, and it's working as expected, here's logs from my HTTP server, showing that the ENV is being added to the URL requested to daily charts.
Default ENV:
<IP_ADDRESS> - - [21/Jun/2017:02:27:02 +0000] "GET /daily_reports_chart.json HTTP/1.1" 200 870 "http://puppetboard.internal.terzo.org/" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_5) AppleWebKit/603.2.4 (KHTML, like Gecko) Version/10.1.1 Safari/603.2.4"

Using "*/ALL" ENV
<IP_ADDRESS> - - [21/Jun/2017:02:27:11 +0000] "GET /%2A/daily_reports_chart.json HTTP/1.1" 200 870 "http://puppetboard.internal.terzo.org/%2A/" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_5) AppleWebKit/603.2.4 (KHTML, like Gecko) Version/10.1.1 Safari/603.2.4"

If you are on the latest version out of github, can you post http logs showing the GET for dailychart.  Also what browser you are using, this may not be cross functional?

We're running the last release version (0.2.2). It looks like that commit was committed after I filed this report (but was never attached to this report).

I'm looking through the issue and thought I'd ping this one.
Seems @ardichoke is saying that a commit made after he filed this fixed the issue?
I'm testing on my setup and I don't see the issue so I'm assuming it's fixed. Can this be closed?

Yup, it's fixed just not in a release yet.  The fixed caused #394

Fixed in 0.3.0


Feature Request - Implement Drift Detection

It would be really helpful if we have drift detection functionality like aws CloudFormation and terraform, so far, we don't have that in place for bicep and ARM Template.
REF - https://www.hashicorp.com/blog/terraform-cloud-adds-drift-detection-for-infrastructure-management

@azcloudfarmer For me the idea would be:

Some kind of comparison/diff on the difference between the resources in the stack as they were deployed, and their current state in Azure.
That is, you can see what changes have been made since the stack was deployed.
Some ability to either report, monitor and alert on changes.
A feature for automatic remediation or re-deployment of the stack when drift is detected

Of course if you have DenySettingsMode set to DenyWriteAndDelete this shouldn't be necessary, but in the other cases it may be very useful.

I just want to call out that 'what if' has a pretty major bug with nested bicep templates https://github.com/Azure/arm-template-whatif/issues/157#issuecomment-1044997859
As such I am not sure if I'd recommend that as a viable alternative at the moment.

As @JFolberth says, -whatif's usefulness is somewhat dubious at the moment as well thanks to its issues with modules and 'existing' resources.
@azcloudfarmer Additionally (sorry): -whatif and drift detection fill two different roles.

whatif is for checking your deployment BEFORE going ahead and deploying.
Drift detection is for detecting unwanted changes AFTER a deployment

Correct me if I'm wrong, but it looks like stacks don't keep a record or 'state' of resource properties.  They just have a record of the resource ID and its management status.
  "resources": [
    {
      "denyStatus": "none",
      "id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/demoRg/providers/Microsoft.Network/virtualNetworks/vnetzu6pnx54hqubm",
      "resourceGroup": "demoRg",
      "status": "managed"
    },
    {
      "denyStatus": "none",
      "id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/demoRg/providers/Microsoft.Storage/storageAccounts/storezu6pnx54hqubm",
      "resourceGroup": "demoRg",
      "status": "managed"
    }
  ]

As-is, it looks like drift detection would be difficult as there's no 'desired' state recorded to compare to.

May be some integration can be done by using resource configuration changes https://learn.microsoft.com/en-us/azure/governance/resource-graph/how-to/get-resource-changes?tabs=azure-cli.

I agree that drift-detection is a nice feature to have, but ultimately if you care about drift (and want to avoid it) you should really just lock the resources from being deleted or modified. This is something you can't do with Terraform or AWS CloudFormation, so the ability to completely lock the resources in the stack trumps drift detection in one way.
What would be the benefit of not locking the stack but instead having drift detection and some auto-remediation feature?

I see it as useful when certain ARM resources don't support deployment stacks correctly so have to be excluded from locking (IP Groups is a painful one that I've come across recently)

Feature is available in Terraform , now pulumi link
Been able to understand drift is a very useful feature

Regarding Terraform/Pulumi: I suppose the reason they support drift-detection is because they have no way of enforcing a lock on the resources? I still think locking the resources in your deployment stacks trumps drift detection. Of course this requires that all resources are supported and that you have control over your RBAC-setup so that there are no unauthorized removal of the locks.

As noted by @JFolberth, we most likely need to resolve the what-if short-circuiting issue before we can make meaningful progress on this one. We also would need to decide if we can depend on what-if results to do the analysis or if we need to store this information somewhere in the Stacks RP as @D-Bissell notes. In theory we would be able to use the what-if API if we could solve the noise issue.
@mattias-fjellstrom - you are making a good point that if you use Deny Assignments, then you can actually stop drift from happening which is the most ideal outcome, but this requires operating in a stricter RBAC environment which may not be viable/easy to change.
Drift Detection is definitely something we're interested in pursuing, but a few things need to fall in place first to make the experience worthwhile.

Resource locks and policy controls serve as great methods to prevent and control Azure control plain actions. Where teams still require "click-ops" to perform BAU tasks and do not have all aspects of the platform maintained and managed with IAC, these tools intend to prevent configuration drift and impede support teams' ability to deliver.  Sometimes the reasons to bypass the controls are to prevent larger platform incidents or changes where manual implementation is the quicker solution.  Either way, the intended benefits of implementing these capabilities alone are normally lost, to give way to fix or implement a required change.
Being able to report on the change and then correct or amend the current platform state would make lifecycle management in platforms where "click-ops" is still a required part of platform management much simpler to manage and remediate.


[WIP] oschma_errors

@pierrealixt Please have a look at this PR. Some different errors may occur, if possible please share the images of those errors.
Thanks.

@pierrealixt Oschma errors have been properly implemented and overpass data is now being retrieved and properly display in the graph widgets.

LGTM


Johtaylo/cloudadapter proactive

This adds proactive support to CloudAdapter.
One of the overloads of ContinueConversation doesn't provide an audience (actually the overloads that do were added for skills) in this case the audience is determined by the cloud environments settings. This is added to the turn context so for consistency this change also provides that value along with creating an appropriate credentials object.
As such this is a significant step towards Skills working with the CloudAdapter. Though there a number of other significant moving parts to Skills that would have to be implemented in a cloud agnostic manner before we have the whole Skills scenario running.

rebased over @carlosscastro fix to connector lifetime. (I think in modern C# we can drop some of the braces on the usings - next time someone is in this code perhaps.)


big space between menu bar and drop-down menu

As shown in the included screenshot, a space is appearing between the menu bar and the drop-down menus. This only occurs at some times and not others, and I cannot tell what is different between those times. This occurs regardless of the chosen UI theme. This occurs in both atom 1.2.1 and 1.2.4.

What OS and Atom version are you using? Do you have any packages installed? Are you using full screen mode?

OS: Linux (Debian stretch, using deb from your releases)
Atom: as said above, it happens with 1.2.1 and 1.2.4. I'm now using 1.2.4.
Packages: yes, but it also happens with atom --safe
Full-screen mode: it was not in full-screen mode. When I tried going to full-screen mode, the spaces disappeared, and when I went back to normal mode, the spaces were still gone!

Trying to go through and cleanup some older issues - it's been a while since this report and Atom is currently at release version 1.14.4.  A quick search didn't turn up any other similar reports either.
I'll go ahead and close the issue for now but if you're still seeing an error with the latest release version of Atom, please feel free to open a new issue and fill out the issue template @skittleys :v:


Wrong width of text columns when "Execute script"

Description
The column width differs when executing a script or executing a query.
Use dvdrental database with query:
select *
from country

https://github.com/user-attachments/assets/03fb5a50-5833-457a-9aa8-ab43829b1bf7
DBeaver Version
Enterprise Edition 24.2.2-202409192322
Operating System
Windows 10
Database and driver
PostgreSQL 16
PostgreSQL JDBC Driver 42.7.4
Steps to reproduce
No response
Additional context
No response

thanks for the report


Unable to start blockchain

When I try to open the app I am getting 'uable to start blockchain'
I have no other options to try other than close the app. I am running 2.1.15
Do I need to delete the app and reinstall with my seed words

Unable to start blockchain

I cannot get around the Security the Way I did with the first install.

Hi @eagleel,
2.1.17 is out, worth to check with this version.
Are you using Windows or Mac or Linux?
Have you checked for enough space as blockchain already required 13 GB....

Hi Darkwinde
Thanks for replying
Yeah I tried that.....  does exactly the same thing, doesn't open at all just the same message.
I am using Mac with 233GB spare
I have received some things to try from tech  but cannot even get to those files.

Hi @eagleel,
I am a Windows or Linuy kiddi, so my ability to help will be limited...but lets try 😄
Would it possible to share the app and binary log? How-To: https://github.com/DeFiCh/app/wiki/How-to-submit-issues-for-DeFi-app
Do you know, if the installation directory requires certain rights to write, e.g. special user rights etc.?
Did you try to add a node manually? DeFi app console command: addnode "<IP_ADDRESS>:8555" add

Hi Darkwinde, The app does not even go past just trying to start. I have no access to the console. It never opens just after a few mins it says unable to start blockchain. 😔

Hi @eagleel,
ok hmmm then I am out, and @izzycsy can may help to find the log location.
As an example for Windows they are located:

%appdata%\Roaming\defi-app\logs\main.log
%appdata%\Roaming\DeFi Blockchain\debug.log

Hi Everbody, I just have the same trouble. App v. 2.1.7 doesn't start at all
Some ideas anybody?

Thanks a lot Darkwinde for trying to help👍.
Miraculously after trying restarts of 2.1.15 app and the 2.1.17 app all of sudden the 2.1.15 started to load and has shown everything as it should.
But when I try to update it comes with an error and tells me to download from the website. So I guess this means I need to start from scratch if I want the new 2.1.17?

HI eagleel, there did you get the 2.1.15 app? I would try it also

Hi Mihalis, 2.1.15 is the app I have been running. It all of a sudden decided to work. But I cannot upgrade to 2.1.17.
I am starting to realise I probably do not know enough yet to be using DeFiChain. I will end up losing my money to float around the universe for eternity😂

Hi @eagleel , are you running 2 DeFi apps on 1 device?
Hi @Mihalis1312 , I do not recommend installing older version for your safety and security, our team is constantly working on improving the app and solving its issues. We regularly do releases, so if you are not in a big hurry I would suggest staying on the latest version and wait for a fix. Thank you for your understanding. May I know if you're facing the same issue — unable to start blockchain?

Hi, thanks for following up, no I only have the 2.1.17 and it will not even install due to the security.
I simply cannot get around it as of now. Just keeps telling me to contact the developers.
Tony

On 15 Feb 2021, at 12.34, Bella<EMAIL_ADDRESS>wrote:

Hi @eagleel , are you running 2 DeFi apps on 1 device?
Hi @Mihalis1312 , I do not recommend installing older version for your safety and security, our team is constantly working on improving the app and solving its issues. We regularly do releases, so if you are not in a big hurry I would suggest staying on the latest version and wait for a fix. Thank you for your understanding. May I know if you're facing the same issue — unable to start blockchain?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

Hi @eagleel , can you send a screenshot of the security prompt?

I have completly deleted the app and trying to install a new version. But I get this message and cannot see how to get around it. Just don't get the option in system preferences to get around the security.

Hi @eagleel , as discussed on Reddit, this issue is resolved for now, I suggest that you check your Mac firewall settings etc, maybe it has to do with that that's preventing you from allowing to use the app. Thank you, I wish you the best.

I have the same problem when I start the App on upgrading to 2.30
Im on Windows


Custom operators

Hi,
I am reviewing various rules engine for my project. One of the requirements that we have is to be able to write our own geographical operators. For example, I want our customers to be able to define something like : "$city in_state OR" ... so if $city => "Portland" .. this should return true and false for cities that don't exist in OR state. There are internal services we can use to determine geographical locations. My question is - how easy would it be to extend EasyRules to support use cases like these? ... this is one example, but there are many others like this we would like to support.
Thank you for your time.

Hi - ping to bump this up.

how easy would it be to extend EasyRules to support use cases like these?

rules in easy rules are expected to be written in Java. If you want to support another language or syntax, it is as easy as implementing the Rule interface to support the syntax (MVELRule is one example).


Temporal fix for registration package

Quick fix until final solution:
https://github.com/ubernostrum/django-registration/pull/127#issuecomment-363067198

Coverage increased (+0.01%) to 97.481% when pulling 58b482b78c9e7d37ef84f203b4482d1a236d47f7 on Temporal-fix-registration-package into 3cc54a9fa999a39cd7bec784ca193a87880f0138 on master.


PE test fails, pandas ValueError: could not convert string to float: '100/1'

Despite some pain along the way, I have got the Galaxy wrapper far enough along to run the tests via planemo test kodoja_search.xml locally and on TravisCI.
e.g. https://travis-ci.org/peterjc/kodoja_galaxy/jobs/339418928
This worked for the single end test, but the paired end tests fail:
|  Traceback (most recent call last):
|  File "/home/travis/miniconda3/envs/__kodoja_unver/bin/kodoja_search.py", line 120, in <module>
|  args.data_format, kraken_file1, args.host_subset, kraken_file2)
|  File "/home/travis/miniconda3/envs/__kodoja_unver/bin/diagnostic_modules.py", line 263, in seq_reanalysis
|  kraken_fullTable['Seq_ID'] = kraken_fullTable['Seq_ID'].astype(float)
|  File "/home/travis/miniconda3/envs/__kodoja_unver/lib/python3.5/site-packages/pandas/util/_decorators.py", line 118, in wrapper
|  return func(*args, **kwargs)
|  File "/home/travis/miniconda3/envs/__kodoja_unver/lib/python3.5/site-packages/pandas/core/generic.py", line 4004, in astype
|  **kwargs)
|  File "/home/travis/miniconda3/envs/__kodoja_unver/lib/python3.5/site-packages/pandas/core/internals.py", line 3462, in astype
|  return self.apply('astype', dtype=dtype, **kwargs)
|  File "/home/travis/miniconda3/envs/__kodoja_unver/lib/python3.5/site-packages/pandas/core/internals.py", line 3329, in apply
|  applied = getattr(b, f)(**kwargs)
|  File "/home/travis/miniconda3/envs/__kodoja_unver/lib/python3.5/site-packages/pandas/core/internals.py", line 544, in astype
|  **kwargs)
|  File "/home/travis/miniconda3/envs/__kodoja_unver/lib/python3.5/site-packages/pandas/core/internals.py", line 625, in _astype
|  values = astype_nansafe(values.ravel(), dtype, copy=True)
|  File "/home/travis/miniconda3/envs/__kodoja_unver/lib/python3.5/site-packages/pandas/core/dtypes/cast.py", line 703, in astype_nansafe
|  return arr.astype(dtype)
|  ValueError: could not convert string to float: '100/1'

Frustratingly being based on the current kodoja test cases, this example works outside of Galaxy/planemo. My hunches are a subtle Python 2 vs 3 issue, or a differences in the pandas version?
Any thoughts?

I can get this to fail now outside of Galaxy/Planemo, not sure what has changed.
Using the trivial patch on #5 which adds more logging to the test script, but otherwise the master branch (updates since v0.0.2) gives the following with my self-compiled Python 3.5,
$ test/test_script.sh
Which version of Python do we have?
Python 3.5.0
Do we have ncbi-genome-download?
0.2.5
Do we have kraken?
Kraken version 1.0
Copyright 2013-2015, Derrick Wood<EMAIL_ADDRESS>Do we have kaiju?
Kaiju 1.5.0
Do we have trimmomatic?
0.36
Do we have fastqc?
FastQC v0.11.6
Do we have numpy?
1.12.1
Do we have pandas?
0.19.2
Do we have biopython?
1.71.dev0
Beginning tests...
...
==============================================================
Testing kodoja_search.py with paired end FASTQ
==============================================================
TrimmomaticPE: Started with arguments:
 -threads 2 test/PE_test/renamed_file_1.fastq test/PE_test/renamed_file_2.fastq test/PE_test/trimmed_read1 test/PE_test/PE_trimmed_data_1U test/PE_test/trimmed_read2 test/PE_test/PE_trimmed_data_2U LEADING:20 TRAILING:20 MINLEN:50
Quality encoding detected as phred33
Input Read Pairs: 100 Both Surviving: 94 (94.00%) Forward Only Surviving: 3 (3.00%) Reverse Only Surviving: 2 (2.00%) Dropped: 1 (1.00%)
TrimmomaticPE: Completed successfully
Started analysis of trimmed_read1
Analysis complete for trimmed_read1
Started analysis of trimmed_read2
Analysis complete for trimmed_read2
94 sequences (0.02 Mbp) processed in 0.046s (122.8 Kseq/m, 24.87 Mbp/m).
  94 sequences classified (100.00%)
  0 sequences unclassified (0.00%)
Traceback (most recent call last):
  File "diagnosticTool_scripts/kodoja_search.py", line 120, in <module>
    args.data_format, kraken_file1, kraken_file2)
  File "/mnt/shared/users/xxx/repositories/kodoja/diagnosticTool_scripts/diagnostic_modules.py", line 263, in seq_reanalysis
    kraken_fullTable['Seq_ID'] = kraken_fullTable['Seq_ID'].astype(float)
  File "/home/xxx/lib/python3.5/site-packages/pandas/core/generic.py", line 3054, in astype
    raise_on_error=raise_on_error, **kwargs)
  File "/home/xxx/lib/python3.5/site-packages/pandas/core/internals.py", line 3189, in astype
    return self.apply('astype', dtype=dtype, **kwargs)
  File "/home/xxx/lib/python3.5/site-packages/pandas/core/internals.py", line 3056, in apply
    applied = getattr(b, f)(**kwargs)
  File "/home/xxx/lib/python3.5/site-packages/pandas/core/internals.py", line 461, in astype
    values=values, **kwargs)
  File "/home/xxx/lib/python3.5/site-packages/pandas/core/internals.py", line 504, in _astype
    values = _astype_nansafe(values.ravel(), dtype, copy=True)
  File "/home/xxx/lib/python3.5/site-packages/pandas/types/cast.py", line 537, in _astype_nansafe
    return arr.astype(dtype)
ValueError: could not convert string to float: '100/1'

Using v0.0.2 with the logging patches seems to give the same, so the recent changes are unrelated.
Using the master with the logging patches and the conda Python 3.6 gives the same:
$ PATH=/mnt/shared/scratch/synology/xxx/apps/conda/bin/:/bin:/usr/bin:/usr/local/sbin:/usr/sbin test/test_script.sh
Which version of Python do we have?
Python 3.6.3
Do we have ncbi-genome-download?
0.2.5
Do we have kraken?
Kraken version 1.0
Copyright 2013-2015, Derrick Wood<EMAIL_ADDRESS>Do we have kaiju?
Kaiju 1.5.0
Do we have trimmomatic?
0.36
Do we have fastqc?
FastQC v0.11.6
Do we have numpy?
1.14.0
Do we have pandas?
0.22.0
Do we have biopython?
1.70
Beginning tests...
...
==============================================================
Testing kodoja_search.py with paired end FASTQ
==============================================================
TrimmomaticPE: Started with arguments:
 -threads 2 test/PE_test/renamed_file_1.fastq test/PE_test/renamed_file_2.fastq test/PE_test/trimmed_read1 test/PE_test/PE_trimmed_data_1U test/PE_test/trimmed_read2 test/PE_test/PE_trimmed_data_2U LEADING:20 TRAILING:20 MINLEN:50
Quality encoding detected as phred33
Input Read Pairs: 100 Both Surviving: 94 (94.00%) Forward Only Surviving: 3 (3.00%) Reverse Only Surviving: 2 (2.00%) Dropped: 1 (1.00%)
TrimmomaticPE: Completed successfully
Started analysis of trimmed_read1
Analysis complete for trimmed_read1
Started analysis of trimmed_read2
Analysis complete for trimmed_read2
94 sequences (0.02 Mbp) processed in 0.041s (138.6 Kseq/m, 28.06 Mbp/m).
  94 sequences classified (100.00%)
  0 sequences unclassified (0.00%)
Traceback (most recent call last):
  File "diagnosticTool_scripts/kodoja_search.py", line 120, in <module>
    args.data_format, kraken_file1, kraken_file2)
  File "/mnt/shared/users/xxx/repositories/kodoja/diagnosticTool_scripts/diagnostic_modules.py", line 263, in seq_reanalysis
    kraken_fullTable['Seq_ID'] = kraken_fullTable['Seq_ID'].astype(float)
  File "/mnt/shared/scratch/synology/xxx/apps/conda/lib/python3.6/site-packages/pandas/util/_decorators.py", line 118, in wrapper
    return func(*args, **kwargs)
  File "/mnt/shared/scratch/synology/xxx/apps/conda/lib/python3.6/site-packages/pandas/core/generic.py", line 4004, in astype
    **kwargs)
  File "/mnt/shared/scratch/synology/xxx/apps/conda/lib/python3.6/site-packages/pandas/core/internals.py", line 3462, in astype
    return self.apply('astype', dtype=dtype, **kwargs)
  File "/mnt/shared/scratch/synology/xxx/apps/conda/lib/python3.6/site-packages/pandas/core/internals.py", line 3329, in apply
    applied = getattr(b, f)(**kwargs)
  File "/mnt/shared/scratch/synology/xxx/apps/conda/lib/python3.6/site-packages/pandas/core/internals.py", line 544, in astype
    **kwargs)
  File "/mnt/shared/scratch/synology/xxx/apps/conda/lib/python3.6/site-packages/pandas/core/internals.py", line 625, in _astype
    values = astype_nansafe(values.ravel(), dtype, copy=True)
  File "/mnt/shared/scratch/synology/xxx/apps/conda/lib/python3.6/site-packages/pandas/core/dtypes/cast.py", line 703, in astype_nansafe
    return arr.astype(dtype)
ValueError: could not convert string to float: '100/1'

I'm a little confused right now, as I thought this was working locally at the end of last week.

I've started tracing the code, at it looks like the N paired input reads would have been renamed to 1/1 ... N/1 and 1/2 ... N/2 at this point, and that therefore the /1 or /2 suffix ought to be present - but it will of course break if turning this directly into the plain integer N by casting.

OK, going back to the TravisCI results, v0.0.2 passed, under both Python 2.7 and 3.6:
https://travis-ci.org/abaizan/kodoja/builds/331761817
Focusing on that working Python 2.7 build,
$ conda install trimmomatic=0.36
$ conda install kraken=1.0
$ conda install fastqc=0.11.5
$ conda install kaiju=1.5.0
$ pip install numpy pandas biopython ncbi-genome-download
Collecting numpy
  Downloading numpy-1.14.0-cp27-cp27mu-manylinux1_x86_64.whl (16.9MB)
    100% |████████████████████████████████| 16.9MB 65kB/s
Collecting pandas
  Downloading pandas-0.22.0-cp27-cp27mu-manylinux1_x86_64.whl (24.3MB)
    100% |████████████████████████████████| 24.3MB 47kB/s
Collecting biopython
  Downloading biopython-1.70-cp27-cp27mu-manylinux1_x86_64.whl (2.2MB)
    100% |████████████████████████████████| 2.2MB 499kB/s
Collecting ncbi-genome-download
  Downloading ncbi_genome_download-0.2.5-py2.py3-none-any.whl
...

Locally I also had trimmomatic=0.36 and ncbi-genome-download 0.2.5.
Locally I had fastqc=0.11.6, so I downgraded. Still broken.
Locally I had numpy 1.11.0, so I upgraded to 1.14.0. Still broken.
Locally I had biopython 1.71.dev0 (a pre-release), so I downgraded to 1.70. Still broken.
Locally I had pandas 0.18.0, so I upgraded to 0.22.0. Still broken.
That seems to rule out a version change in the main dependencies. I remain puzzled.


PR to get 'preview' branch to match master

Hi Rich - I want to make changes on several pages of the VIMC website, so thought I should set this up on the 'preview' branch, not 'master'. Looking at Mark's instructions (https://github.com/vimc/vimc.github.io/blob/master/README.md - 'Previewing changes' section), I believe the first step is to do a PR to compare the two branches, and then get the preview branch updated. Is that correct?

I'm not very familiar with the system in place, but yes that seems like it would work. You'll need to resolve the conflicts here before we can merge it

Thanks, Rich!
How do I resolve the conflict exactly? I tried reading up on how to do this but am confused.
https://github.com/vimc/vimc.github.io/pull/21/conflicts
Best,
Kim
From: Rich FitzJohn @.>
Sent: 01 November 2022 10:56
To: vimc/vimc.github.io @.>
Cc: Woodruff, Kim H @.>; Author @.>
Subject: Re: [vimc/vimc.github.io] PR to get 'preview' branch to match master (PR #21)
I'm not very familiar with the system in place, but yes that seems like it would work. You'll need to resolve the conflicts here before we can merge it
—
Reply to this email directly, view it on GitHubhttps://github.com/vimc/vimc.github.io/pull/21#issuecomment-1298350571, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AGVTMRYSPJ3HKA57HXYSSXLWGDZKRANCNFSM6AAAAAART5KM2Y.
You are receiving this because you authored the thread.Message ID<EMAIL_ADDRESS>

you can do it via github - click the "Resolve conflicts" button and follow the instructions - they look pretty trivial here - there's a <br> tag on one branch and content on the other. If you can't work it out let me know and I'll sort it


[bug] Multiple nodes with a duplicate UUID

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
My 3 control planes are displayed in Omni as a single machine because they all have the same UUID. After looking up the UUID it seems, that this is a common UUID that is shared by a lot of machines: 03000200-0400-0500-0006-000700080009
All 3 machines are same exact model: Beelink EQ12

It seems the machines listed in Omni are based on the assumption that the UUID is unique, which it is not for a lot of USFF computers (Beelink, Veeam).
Expected Behavior
All 3 control planes should be displayed/listed as separate machines in Omni.
Steps To Reproduce

Use nodes that share the same UUID
Use an Omni installation image on said nodes
Omni lists only one machine

What browsers are you seeing the problem on?
No response
Anything else?

I fixed the issue by changing the UUID of all 3 machines as described in this Beelink forum post: https://forum.bee-link.com/forum.php?mod=viewthread&tid=86568