Add links to http://ksonnet.heptio.com/

From @jhermann on July 3, 2017 9:6
Link your org's and project's "Website" settings to http://ksonnet.heptio.com/ to make things more discoverable.
Copied from original issue: ksonnet/kubecfg#49

From @anguslees on August 31, 2017 1:17
.. except ksonnet.heptio.com is (a) a heptio-specific site, and (b) doesn't mention kubecfg.
Assigning to @hausdorff to sort out the heptio side of things, and what we want to do with ksonnet websites generally (eg ksonnet-lib also doesn't mention kubecfg, and I removed ksonnet-lib from kubecfg's examples some time ago because ksonnet-lib didn't work at the time).


[bug]

Describe the bug
Triggering an rh-dialog component to "open" via a keyboard, the focus doesn't correctly transition from the trigger button to the open dialog.  The focus remains on the trigger.
Which Component?
rh-dialog
Steps to reproduce

Go to https://ux.redhat.com/elements/dialog/demo/
Using your keybaord, tab to the first "open" button
Hit "Enter"
Verify that the focus has remained on the "open"button

Expected behaviour
The focus should move the the dialog element when the trigger is clicked and focus moved back to the trigger button when the dialog is closed
Screenshots

Element HTML
No response
Operating System (OS)
macOS
Browser
Chrome
More browser information
No response
Additional Info
No response

I have a fix from rhpt-elements that I can put into a PR.

we should just use <dialog> internally https://caniuse.com/dialog

@bennypowers - Switching to dialog internally was going to be the follow up https://github.com/RedHat-UX/red-hat-design-system/issues/1242

<dialog> provides browser-built-in focus trap. should we spend time implementing that in javascript now then immediately turn around and delete that code?

@adamjohnson can you look into this for Clefairy?

Seems like this may now be something that could be fixed in #1242


Going to empty stack for tag that was removed

Rancher Version: master 11/16
Steps to Reproduce:

Create a stack and give it a tag (tag1)
Go to Stacks menu and select tag1
Edit the stack and remove the tag and save

Results: Still in "tag1" stack even though it actually gone now.

Expected:  Should go back to user stack

Version - v1.2.0-pre4-rc8
Verified fixed


calling sitk function with int argument does not work with Python 3

@jcfr When using Python 3.5, resampling as implemented in imageoperations.py#L187 does not work.
sitk.ResampleImageFilter accepts uint32_t arguments. In Python 2.7 this works fine with passing np.int. However, in Python 3 this is not working anymore.
Example:
rif = sitk.ResampleImageFilter()
rif.SetSize(np.array([1, 2, 3], dtype='int'))

TypeError: in method 'ResampleImageFilter_SetSize', argument 2 of type 'std::vector< uint32_t,std::allocator< uint32_t > > const &'

Which numpy type whould result in uint32_t for both python 2 and 3? With np.uint32 I get the same error.
Converting the array to python int with arr = [int(x) for x in arr] resolves the issue but is ugly...

@haarburger, thanks for the heads up! This conversion was giving us trouble before (and fixed it by casting to 'int', but apparently doesn't work for python 3). We'll look into it to make it python 3 compatible. If you find a solution in the meantime, we'd welcome your contribution.

np.array([1, 2, 3], dtype='int').tolist() does the trick. I'll create a PR shortly.

rif = sitk.ResampleImageFilter()
rif.SetSize(np.array([1, 2, 3], dtype='int'))
TypeError: in method 'ResampleImageFilter_SetSize', argument 2 of type 'std::vector< uint32_t,std::allocator< uint32_t > > const &'

np.array([1, 2, 3], dtype='int').tolist() does the trick. I'll create a PR shortly.

@blowekamp Would it make sense to improve the wrapping layer to directly understand numpy array as parameter ?

The swig wrapping layer does under stand numpy array.  It does not implicitly convert numpy signed integer types to unsigned array types.

On Feb 17, 2017, at 5:40 PM, Jean-Christophe Fillion-Robin<EMAIL_ADDRESS>wrote:
rif = sitk.ResampleImageFilter()
rif.SetSize(np.array([1, 2, 3], dtype='int'))
TypeError: in method 'ResampleImageFilter_SetSize', argument 2 of type 'std::vector< uint32_t,std::allocator< uint32_t > > const &'
np.array([1, 2, 3], dtype='int').tolist() does the trick. I'll create a PR shortly.
@blowekamp Would it make sense to improve the wrapping layer to directly understand numpy array as parameter ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@blowekamp Actually, np.array([1, 2, 3], dtype='uint32') was the first thing I tried, but it doesn't work.

@haarburger, did you also try 'uint'?

Yes, doesn't work either.

I will have to look into the further. Can you please create a SimpleITK Issue, and include the SimpleITK version, OS, Python Distribute, etc.. where the problem has occurred?
Have you checked if SimpleITK 1.0rc1 has the same issue?

@blowekamp the problem also occurs with 1.0rc1. I created a SimpleITK issue.

Addressed in #205


Sitemap.xml Generation Error in nuxt-seo v2.0.0-rc.18

Describe the bug
In version 2.0.0-rc.18 of nuxt-seo, the sitemap.xml is generated incorrectly. This issue can be consistently reproduced in the production environment.
The generated URLs have the following incorrect format, and the content is empty:
/sitemap/en.xml
/sitemap/zh-CN.xml
/sitemap/zh-TW.xml
In version 2.0.0-rc.16, the generated URLs were in the correct format:
/en-sitemap.xml
/zh-CN-sitemap.xml
/zh-TW-sitemap.xml
Reproduction
No response
System / Nuxt Info
No response

Yes, the release notes this as a slightly breaking change, see https://github.com/nuxt-modules/sitemap/pull/320.
So the new path is correct, if they're empty can you provide a minimal reproduction as this sounds like a bug

Seems like there was a bug in the latest robots module, if you clear your lock file and update your dependencies it should fix the empty issue.


Add onZoomIntervalChange

Adding a onZoomIntervalChange would allow us to do some calculations inside renderEventContent.
For my case, I'm rendering a multi-event type event where each of the event types has to take X % of the total event's height. In order for me to calculate that, I need the current interval height - if I want to have pinch to zoom enabled.
I guess it could be added here? https://github.com/howljs/react-native-calendar-kit/blob/da8c653e55ce33d3c41e7190b1342632cb69adaf/src/hooks/usePinchGesture.tsx#L55

I can do my calculations without it, sorry about that.

I can do my calculations without it, sorry about that.

How did you do ? I also need to calculate the event height to place some cursors on the event based on the timeIntervalHeight


Cannot added wallet from extension directly

Wallet from Ledger can't be added from the extension directly as the USB device can't be used from the extension.
Can we have a page running directly with chrome-extension://? Or redirect the user to the webapp first?

@calvinkei Hey team! Can you please add your planning poker estimates with ZenHub

@kwunyeung i cannot reproduce this. adding ledger wallet works on the extension for me. which browser are you using?

@calvinkei oh yeah! Just tested and it worked but it's not showing as added via usb device.

@kwunyeung yes i found a minor bug. the ledger icon will show after refreshing. this will be fixed in the next release

Awesome!


Write a small script to compile single HTML files from those with linked CSS/JS

Is your feature request related to a problem? Please describe.
One of our deliverables is a single web form.
Describe the solution you'd like
We can probably write a short Go script to find and replace <link> and <script> tags with their corresponding file contents.
Describe alternatives you've considered
There may be a package that does this. Webpack might do the same thing but is very bulky and we do not currently use Node in our stack. It may make sense if we gain significant Javascript files but for now I would prefer to avoid adding it.
Additional context
These guys do something similar with Python and beautiful soup: https://stackoverflow.com/questions/44646481/merging-js-css-html-into-single-html

Superseded by #49.


Made README.md easier to read

Fixed spelling mistakes, clarified some sentences and improved grammar. If there is any problems, let me know!

Tks for your help, I still have a long way to go on the path of writing. 🐶

Not a problem, thanks for making this awesome plugin 😀


Method for accessing FlutterPluginRegistry

Use case
When developing a plugin, or writing other native code, it is sometimes necessary to access the native implementation of another plugin. A good example of this is webview_flutter, which has WebViewFlutterAndroidExternalApi (Android) and FWFWebViewFlutterWKWebViewExternalAPI (iOS) classed for accessing the platform WebViews associated with a given handle. Both use either the FlutterPluginRegistry or the FlutterEngine, neither of which are easily accessible from a Plugin.
Proposal
In my mind, the simplest solution that will have the smallest impact is to add properties onto the objects that are already passed to plugins during initialization.
iOS - Add a method to FlutterPluginRegistrar to allow upward access to the FlutterPluginRegistry
Android - Add a method to FlutterPlugin.FlutterPluginBinding to access the FlutterEngine

@bparrishMines Is there already a way to do this that I missed (in which case we just need a docs update)? Or is the current approach to require it to be wired up at the app level rather than the plugin level?

We do need to track this feature because the way to access these classes in a plugin are not obvious and my solutions below are currently workarounds that are protected by tests.
For iOS, the FlutterAppDelegate is an implementation of FlutterPluginRegistry and can be accessed through the application delegate
@import webview_flutter_wkwebview;

@interface MyPlugin ()
@property(weak) FlutterAppDelegate *appDelegate;
@end

@implementation MyPlugin
+ (void)registerWithRegistrar:(NSObject<FlutterPluginRegistrar> *)registrar {
  FLTGoogleMobileAdsPlugin *instance = [[FLTGoogleMobileAdsPlugin alloc] init];
  // Adds plugin to listen for `application:didFinishLaunchingWithOptions:` below
  [registrar addApplicationDelegate:instance];
}

- (void)getWebView:(NSNumber *)webViewIdentifier {
  WKWebView *webView = (WKWebView *) [FWFWebViewFlutterWKWebViewExternalAPI
        webViewForIdentifier:webViewIdentifier.longValue
          withPluginRegistry:self.appDelegate];
}

- (BOOL)application:(UIApplication *)application
   didFinishLaunchingWithOptions:(NSDictionary *)launchOptions {
  self.appDelegate = (FlutterAppDelegate *) application.delegate;
}
@end

For Android you can access FlutterEngine through FlutterPluginBinding. However I would note that FlutterPluginBinding.getFlutterEngine() is currently deprecated. We don't currently have a plan to remove it, but we may at some point. An alternative solution to access other plugins will be provided before that happens though.
void getWebView(long webViewIdentifier) {
 final FlutterPluginBinding binding = /*get saved binding*/;
 final WebView webView = WebViewFlutterAndroidExternalApi.getWebView(
     binding.getFlutterEngine(), webViewIdentifier);
}

These are exactly the workarounds I'm using at the moment. On the iOS side, the issue that made me raise this is trying to use the plugin registry in an "add to app" scenario, where we can't assume The AppDelegate is a FlutterAppDeleage.

I don't think we probably want to go as far as exposing the whole registry or engine to every plugin, since the registrar is intended to be a limited interface. Making breaking changes to an interface becomes much harder once plugins are using it.
Instead we could plumb through the specific call to get the published value from another plugin.

We're faced with a similar scenario to @fuzzybinary, in that we need a reference to the FlutterPluginRegistry from an "add to app" scenario, in our case using the google_mobile_ads package. I certainly may be missing something, but I don't see a way to proceed with that as is stands. I would be very happy to be proven wrong, of course :D

We already do this on iOS using valuePublished utility method.   But on Android, FlutterPluginRegistry has now been marked as deprecated.   It does contain a method named valuePublishedByPlugin which is exactly what we need.

Is there a recommended workaround for Android?
By any chance, is Flutter planning to deprecate valuePublished we have on iOS platform?

We already do this on iOS using valuePublished utility method. But on Android, FlutterPluginRegistry has now been marked as deprecated. It does contain a method named valuePublishedByPlugin which is exactly what we need.

Is there a recommended workaround for Android?
By any chance, is Flutter planning to deprecate valuePublished we have on iOS platform?

Whats unclear to me is:

How do I get access to FlutterPluginRegistry instance on Android
Is there a recommended workaround to access another plugin instance for Android

In my case, I want to delegate processing of an intent from MainActivity to a plugin, which already implements handling for this intent.


Fix verify webhook

fixes #79

Codecov Report

Merging #80 into master will increase coverage by 0.03%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master      #80      +/-   ##
==========================================
+ Coverage   32.64%   32.67%   +0.03%
==========================================
  Files          12       12
  Lines        6270     6270
==========================================
+ Hits         2047     2049       +2
+ Misses       3844     3842       -2
  Partials      379      379

Impacted Files
Coverage Δ

client.go
60.78% <0.00%> (ø)

stream_chat_easyjson.go
29.34% <0.00%> (+0.03%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b317f1d...3ee58c6. Read the comment docs.


Harden Tangle to Malicious Peers

If a peer is malicious they should only be able to cause a bad experience for themselves. Tangle should be audited to find any potential ways a malicious peer could intentionally desync another peer. In scenarios with only one other peer this is likely impossible to do perfectly, but in rooms with 2+ peers it's should be possible to verify and reach consensus. In some cases a peer could be designated as a source of authority that all peers should defer to, like when running an authoritative server.

Would you consider a simple majority consensus logic based on something light (e.g. some hash)?

Potentially misunderstanding the suggestions here, but it could also seat quite well with the solution to https://github.com/kettle11/tangle/issues/7 and a simple majority based on the content hashes of the deltas (which may require comparing a list of hashes if multiple changes are being synced)?

Yeah, hashing is likely the solution to detect and resync peers who have desynced.
The issue I want to prevent is a malicious peer sending bogus messages (or omitting messages) to just one peer in an effort to sabotage them.
Hash consensus could be used by peer A to detect that it's desynced (and likely something like that should exist anyways) but it will still give peer A a degraded experience, or at least give peer A increased latency. Is there a better way?

Another issue is when joining a room how can a peer know it's being sent the correct data? Likely a peer should receive a hash of the room state from a few peers and the full room state from one peer and then verify the hash itself when it receives the room state.


Allow both $ and directory$ for random yamls.

If either the diretory contains a magic $ file, or if the directory name
ends with $, then the random selection of a yaml file will occur.
Signed-off-by: Warren Usui<EMAIL_ADDRESS>

This change implements the 'choose a random yaml file' behavior both for magic $ files and for directory names that end with $.   The following is an example of the directory$ behavior.
foo is a directory containing distro definitions -- yaml files that define os_type and os_version. The files in foo are:
%
ubuntu.yaml
centos.yaml
rhel.yaml
A suite that links distros to foo will run a test for ubuntu, centos, and rhel.
A suite that links distros$ to foo will run a test, randomly selecting from ubuntu, centos and rhel.
This would allow a suite of n combinations of tests to run roughly n/3 tests on each distro when distro$ is used as the name of the symbolic link. When distro is the name of the symbolic link 3*n tests will be run (once for each yaml file).

I was trying to remove a commit from wip-wusui2 and that pull request ended up getting closed by me.  So I cloned the latest teuthology and put those changes on this one.

test me please

While I was working with the previous pull request for this, it somehow closed (I put in a test for jenkins to run and tried to back it out and I am not sure what happened).   I have since placed the changes in another branch.
Right now one of the unittests for the directory$ changes that I added is failing.  I don't know why.  I ran the tests manually, and it seemed to work there.
Zack:  Is this a reasonable way of running the tests manually?
python

from test_build_matrix import TestBuildMatrix
x=TestBuildMatrix()
x.setup()
x.test_random_dollar_sign_with_convolve()

test this please

https://jenkins.ceph.com/job/teuthology-pull-requests/1168/consoleFull#842358957c212b007-e891-4176-9ee7-2f60eca393b7
After looking at this, it appears that the problem is unrelated to my changes.  I am going to run again with my full version, git squash, and look into this further.

I'm confused about these failures as well; I can't reproduce locally. I'm going to rerun them here.

test this please

test me please

test this please

@wusui @zmc at what point we either merge it with failing test or give up ?

test me please

@wusui test failures: https://paste.fedoraproject.org/paste/mns~VzOgRgfi0~L-KxPKyw

test me please

I tried rebasing but my local copy got all weird.  I think that this is ready for review.

@wusui this looks good! Do you need help rebasing?

I may need help rebasing.  I tried, and got a 'no branch, rebasing wip-wusui-23208' entry.  After I continued, I ended up with an entry in the git log that said: "Merge branch 'wip-wusui-23208' of http://github.com/ceph/teuthology into wip-wusui-2320" but git diff showed did not do anything.

Note: In addition to rebasing I am also trying to squash a bunch of commits.

@wusui I just rebased and pushed for you. I want to let you squash, so if you local clone is busted, maybe try from a new one?

Okay.  I'll try squashing with a new clone.

I squashed and the last test passed.

@wusui this isn't actually squashed

Okay.  I think that it is squashed now.


Great to see the first imp of AlignTTS in github!

Hi, Great job, I'm also interesting in AlignTTS, did u trained a such model successfully? Or even already got generated wave samples? :)

Thanks for trying to cheer us up, but we can not still succeed to train the AlignTTS.
We are having a hard time training the MDN because of the numerical issue, which is caused from computing the probability of the melspectrogram in the 80-d gaussian distribution :(


validation: fix nosetest in gyb for Python 3

The file-like object's write method in Python 3 returns the number of
bytes that are written.  This was not previously checked and is not
particularly interesting.  Simply blackhole the bytes written, repairing
the test on Python 3.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

CC: @drexin @tachoknight @tbkka

@swift-ci please test


Cache problems with sbt 0.13.7

I'm trying to run dependency-dot on my project Mellite. If I change project/build.properties from 0.13.6 to 0.13.7, I get the following error:
[success] Total time: 1 s, completed Dec 6, 2014 12:31:47 AM
[info] Updating {file:/home/hhrutz/Documents/devel/Mellite/}mellite-core...
[info] Updating {file:/home/hhrutz/Documents/devel/Mellite/}mellite-core...
[info] Resolving com.github.scopt#scopt_2.11;3.2.0 ...
[info] Done updating.
[info] Resolving com.github.scopt#scopt_2.11;3.2.0 ...
[info] Updating {file:/home/hhrutz/Documents/devel/Mellite/}mellite-views...
[info] Updating {file:/home/hhrutz/Documents/devel/Mellite/}mellite-views...
[info] Done updating.
[info] Resolving de.sciss#numbers_2.11;0.1.1 ...
[info] Wrote dependency graph to '/home/hhrutz/Documents/devel/Mellite/core/target/dependencies-compile.dot'
[info] Resolving de.sciss#weblaf-ui;1.28 ...
[info] Done updating.
[info] Resolving de.sciss#weblaf-ui;1.28 ...
[info] Done updating.
[info] Updating {file:/home/hhrutz/Documents/devel/Mellite/}mellite...
[info] Resolving de.sciss#weblaf-ui;1.28 ...
[info] Done updating.
[info] Wrote dependency graph to '/home/hhrutz/Documents/devel/Mellite/target/dependencies-compile.dot'
java.io.FileNotFoundException: /home/hhrutz/Documents/devel/Mellite/views/target/resolution-cache/reports/de.sciss-mellite-views_2.11-compile.xml (No such file or directory)
	at java.io.FileInputStream.open(Native Method)
	at java.io.FileInputStream.<init>(FileInputStream.java:146)
	at scala.io.Source$.fromFile(Source.scala:90)
	at scala.io.Source$.fromFile(Source.scala:75)
	at scala.io.Source$.fromFile(Source.scala:53)
	at net.virtualvoid.sbt.graph.IvyGraphMLDependencies$.buildDoc(IvyGraphMLDependencies.scala:224)
	at net.virtualvoid.sbt.graph.IvyGraphMLDependencies$.graph(IvyGraphMLDependencies.scala:70)
	at net.virtualvoid.sbt.graph.Plugin$$anonfun$ivyReportForConfig$2.apply(Plugin.scala:89)
	at net.virtualvoid.sbt.graph.Plugin$$anonfun$ivyReportForConfig$2.apply(Plugin.scala:89)
	at scala.Function1$$anonfun$andThen$1.apply(Function1.scala:55)
	at scala.Function1$$anonfun$compose$1.apply(Function1.scala:47)
	at sbt.$tilde$greater$$anonfun$$u2219$1.apply(TypeFunctions.scala:40)
	at sbt.std.Transform$$anon$4.work(System.scala:63)
	at sbt.Execute$$anonfun$submit$1$$anonfun$apply$1.apply(Execute.scala:226)
	at sbt.Execute$$anonfun$submit$1$$anonfun$apply$1.apply(Execute.scala:226)
	at sbt.ErrorHandling$.wideConvert(ErrorHandling.scala:17)
	at sbt.Execute.work(Execute.scala:235)
	at sbt.Execute$$anonfun$submit$1.apply(Execute.scala:226)
	at sbt.Execute$$anonfun$submit$1.apply(Execute.scala:226)
	at sbt.ConcurrentRestrictions$$anon$4$$anonfun$1.apply(ConcurrentRestrictions.scala:159)
	at sbt.CompletionService$$anon$2.call(CompletionService.scala:28)
	at java.util.concurrent.FutureTask.run(FutureTask.java:262)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
	at java.util.concurrent.FutureTask.run(FutureTask.java:262)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
	at java.lang.Thread.run(Thread.java:745)
[error] (mellite-views/compile:moduleGraph) java.io.FileNotFoundException: /home/hhrutz/Documents/devel/Mellite/views/target/resolution-cache/reports/de.sciss-mellite-views_2.11-compile.xml (No such file or directory)
[error] Total time: 9 s, completed Dec 6, 2014 12:31:57 AM

I don't know if this is a bug of sbt or sbt-dependency-graph. Given that 0.13.7 claims to have improved caching, my guess is the former, but perhaps you can take a look at this issue.

+1

This seems to happen non-deterministically and only when aggregating from the root project. Can you confirm this?
I guess what happens is that the aggregation runs the report concurrently for all aggregated projects. The report always forces a dependency resolution. If one of the projects depends on another then another dependency resolution may be transitively triggered so that while the report is trying to access the result of the first run, the concurrent run deletes or rewrites the xml file at the same time.
A workaround would be not to aggregate the dependency reports for now. In the future, the real solution would be not to depend on the xml files at all but directly work on the ivy/sbt dependency data structures.

I didn't realise it was non-deterministic because every time I ran it, it failed.
FYI: I was consistently getting this error on a non-aggregate module in my project. On your advice I just ran it a few times in the root modules and then switched to a (non-aggregate) sub-module and it worked. Thanks for the advice :)

I spoke too soon, it seems about 8 of my 13 modules still refuse to work at all.

Ok, I only checked the example from @Sciss which seemed to be non-deterministic.
@japgolly Do you have an example project I can try?

I believe this should do it. ↓
https://github.com/japgolly/sbt/tree/skeleton

Hmm... for me it seems to be non-deterministic when running in the root aggregate but worked for all the submodules I randomly tried. Can you post a console log which I can try to reproduce?

Really? Hmmm, sorry, I'll take another look and report back to you with
something replicateable.

I have a project where I'm seeing non-deterministic spurious failures of this type, i.e. the failure is the same, but it's usually a different set of projects that fail from run to run.
(Unfortunately I'm not at liberty to share the code. Is there some way I could provide "anonymized" logs or something which would be useful in debugging this?)

I'm closing this as a duplicate of #39. I guess a lot of the uncertainty of the whether and why this happens is because of the non-determinism which e.g. may have changed between some sbt version.


Added VS Code GUI (it has a source control feature)

Changes
Added a VS Code to the GUI list, in guis.yml and 2 images in the guis folder. Also the image is just from their website https://code.visualstudio.com/docs/sourcecontrol/overview#_3way-merge-editor

Context
VS Code is very popular, and i noticed it wasn't on here.

thanks for the contribution @gusborg88
even though VS code has a source control feature, it's not a git GUI tool. nowadays all (rich) code editors have a source control feature, even though it's not their primary goal. other tools listed here are built to help in source control. if we relaxed the "definition", then we would add all code editors here

Damn ok


Mark as unread sometimes doesn't work

More info? Otherwise imma put it on the backlog

My branch


refcator,chore(egen) : refcatored code according to template guidelines

This PR includes
1.changed variable REGION to LOCATION
2.added code to remove locally generated files in cleanup
3.removed UUID code and os module
4.performed linter test
5.followed template guidelines
REQUIRED: Fill out the below checklists or remove if irrelevant

If you are opening a PR for Official Notebooks under the notebooks/official folder, follow this mandatory checklist:

[x] Use the notebook template as a starting point.
[x] Follow the style and grammar rules outlined in the above notebook template.
[x] Verify the notebook runs successfully in Colab since the automated tests cannot guarantee this even when it passes.
[x] Passes all the required automated checks. You can locally test for formatting and linting with these instructions.
[ ] You have consulted with a tech writer to see if tech writer review is necessary. If so, the notebook has been reviewed by a tech writer, and they have approved it.
[ ] This notebook has been added to the CODEOWNERS file under the Official Notebooks section, pointing to the author or the author's team.
[x] The Jupyter notebook cleans up any artifacts it has created (datasets, ML models, endpoints, etc) so as not to eat up unnecessary resources.

/gcbrun


Allow mrgeo-emr.py to support additional yarn-site, mapred-site and spark-defaults changes

The mrgeo-emr.py script has a section for configuration settings for the cluster for yarn-site, mapred-site and spark-defaults settings supported by EMR. Occasionally, users might need to include additional settings in them, and rather than forcing them to modify the mrgeo-em.py script (which they would have to do today), allow the JSON config passed to mrgeo-emr.py to include these settings.

Closed in 49e14276a0c14ce6e8f13d9fc2997a7f46337fa9


UI/UX Design: Warning text (i.e. text that are nudging clinical decision guideline to users) looks visually similar with other fields

Is your feature request related to a problem? Please describe.
Warning text (i.e. text that are nudging clinical decision guideline to users) looks visually similar with other fields.
Describe the solution you'd like
Warning text should be visually eye-catching (i.e. colored “red” or “green”) so user can notice this warning more attentively
Additional context

Would you like to work on the issue?
@jingtang10 @f-odhiambo @SebaMutuku @MargaretNjenga

this is possible with style customization built into the sdc library: please see https://google.github.io/android-fhir/use/SDCL/Customize-how-a-Questionnaire-is-displayed/#localize-questionnaires
@santosh-pingle can you please try to create an example and perhaps we can even add it to the catalog app?
thanks

this new section @santosh-pingle added provides detailed example of how to do this: https://google.github.io/android-fhir/use/SDCL/Customize-how-a-Questionnaire-is-displayed/#custom-style-per-question-item


Cleanup duplicate logic for acquiring Organization ID

There is a lot of duplicate logic for acquiring the organization ID from passed in OrgParams. There are two main situations that "business logic" for commands has to deal with this:
Has an embedded OrganizationsApi:
This case is relatively simple, and can cleanup the logic with a method along the lines of:
func (o OrgParams) GetOrgID(ctx context.Context, api api.OrganizationsApi, defaultOrg string) (string, error) {
    ...
}

where defaultOrg is intended to be passed in from the ActiveConfig, unless special logic demands it be different.
Does not have an embedded OrganizationsApi:
My first thought for this was having an interface like:
type <T> OrgHolder interface {
    Org(string) T
    OrgID(string) T
}

func (o OrgParams) <T> GetOrgID(defaultOrg string) T {
    ...
}

since other embedded api's that allow search by OrgName or OrgID will have these two API methods. However clearly we cannot do this, since Go currently lacks generics. This case is more difficult to solve, and will need some thought/discussion.

Closed by https://github.com/influxdata/influx-cli/pull/272


Laboratory work #2, Andrew Zapekin - 23FPL1

You've made some progress, but it's still progress! I wish you good luck in further work!


Possibility to use custom status

Hey, very nice package. However, if this flow does not work with your process, you need to hack it.
What do you think about adding a possibility to add a custom status?
E.g.
$post->setStatus('custom');

Post::all()->withStatus('custom');

Maybe the user can set those status and decide if they should be queried in strict mode or not.
You could even use magic methods to build markCustom methods.
What do you think?

Good idea ! Actually, the differents status are hard coded, maybe need a little refactoring.
Why not a markAs with a parameter ? Personally I prefer it, I don't like magic :wink:, and like idea completion.

Hi @lukasoppermann, this is a very good idea.
The quickest way I can think of, is to use the config file to define the available statuses instead of the Status model.
What do you have in mind about magic methods?

@hootlex I think $post->markNotForChildren() (status = not_for_children), like the markPending method ( See call magic method ).

@stephane-monnot @hootlex exactly. But I would be fine with a markAs() method. It was a suggestion in case you wanted those methods.
Changing the status to be defined in a config file would make sense to me. This would even open it up to be stored in a database, retrieved and set as config variables, so it would make it very flexible!
I am just thinking that sometimes you need to create a business flow, e.g.
new Post() -> draft -> waiting for review ->  needs changes -> waiting for review -> ready for publication -> published / queued
Just as an example.

Maybe status are better in database, because:

we could use relationships with others tables
if one day I want to remove a status, I will get an error if at least one post has been marked with this status (needed in foreign key constraint).

Hmm, maybe optionally? I am just thinking if you just have a published/unpublished case a database for just to status would be a bit of an overkill, would it not?

Yes, I agree, that's a bit overkill. As a first step, we should use config files.

Maybe we could require a "default" status or something so if the status that a model had is missing, it will be reset/interpreted as the default status? This could solve the problem you where describing correct?

Good idea !
@hootlex, what do you think ?

@lukasoppermann @stephane-monnot I prefer to use config file to define the statuses. They can be defined within an array, which will contain an 'ID' and a 'name'.
+1 for the default status fallback.


x/tools/cmd/gopls: goimport and gofmt do not execute on save

What version of Go are you using (go version)?
1.12.5
Does this issue reproduce with the latest release?
yes
What operating system and processor architecture are you using (go env)?
Linu
What did you do?
<!--
Checked to use language server and updated settings.json with:
"go.useLanguageServer": true,
"[go]": {
    "editor.codeActionsOnSaveTimeout": 3000,
    "editor.snippetSuggestions": "none",
    "editor.formatOnSave": true,
    "editor.codeActionsOnSave": {
        "source.organizeImports": true
    }
},
"gopls": {
    "usePlaceholders": true // add parameter placeholders when completing a function
},
"files.eol": "\n",
"workbench.colorTheme": "Default High Contrast", // formatting only supports LF line endings,

"go.languageServerFlags": [
    "-rpc.trace", // for more detailed debug logging
    "serve",
    "--debug=localhost:6060", // to investigate memory usage, see profiles
],

### What did you expect to see?
I expected goimports and gofmt to work on save. The work externally when run from the command line.

### What did you see instead?
Imports are not update.
Ctl-Shif-I formats the code, but not on save.

I'm using the Go plugin with VSCode.

What else can I supply to help?

Have you configured your settings according to https://github.com/golang/go/wiki/gopls? In particular,
"[go]": {
    "editor.formatOnSave": true,
    "editor.codeActionsOnSave": {
        "source.organizeImports": true
    }
},

This is the contents of my settings.json
{
"editor.minimap.enabled": false,
"go.autocompleteUnimportedPackages": true,
"go.gocodeAutoBuild": true,
"files.autoSave": "afterDelay",
"[go]": {
"editor.snippetSuggestions": "none",
"editor.formatOnSave": true,
"editor.codeActionsOnSave": {
"source.organizeImports": true
}
},
"gopls": {
"usePlaceholders": true // add parameter placeholders when
completing a function
},
"files.eol": "\n", // formatting only supports LF line endings
}
On Sun, Jul 14, 2019 at 2:47 PM Rebecca Stambler<EMAIL_ADDRESS>wrote:

Have you configured your settings according to
https://github.com/golang/go/wiki/gopls? In particular,
"[go]": {
"editor.formatOnSave": true,
"editor.codeActionsOnSave": {
"source.organizeImports": true
}
},
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/golang/go/issues/33089?email_source=notifications&email_token=AACHUD43U7LUI4LFVN4FNDTP7NYCRA5CNFSM4ICRKP4KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZ4LBQI#issuecomment-511226049,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AACHUDYYEMTS6VZRBV2DYI3P7NYCRANCNFSM4ICRKP4A
.

--
Bob Hancock

Do the other features work for you? Does formatting work if you right-click and "Format Document"? Can you share a gopls log? See https://github.com/golang/go/wiki/gopls#troubleshooting.

I changed settings.json to start the server with debug data.
{
"editor.minimap.enabled": false,
"go.autocompleteUnimportedPackages": true,
"go.gocodeAutoBuild": true,
"files.autoSave": "afterDelay",
"[go]": {
"editor.snippetSuggestions": "none",
"editor.formatOnSave": true,
"editor.codeActionsOnSave": {
"source.organizeImports": true
}
},
"gopls": {
"usePlaceholders": true // add parameter placeholders when
completing a function
},
"files.eol": "\n",
"go.useLanguageServer": true, // formatting only supports LF line
endings
"go.languageServerFlags": [
"-rpc.trace", // for more detailed debug logging
"serve",
"--debug=localhost:6060", // to investigate memory usage, see
profiles
],
}

Restarted vscode.
Right click - Reformat document and the formatting works.

[Trace - 6:06:34 PM] Received response 'textDocument/codeAction - (15)' in
0ms.
Params: [{"title":"Organize
Imports","kind":"source.organizeImports","edit":{"changes":{"file:///home/rwh/go/src/goxmeans/km_test.go":[]}}}]
[Trace - 6:06:34 PM] Sending notification 'textDocument/codeAction' in 28ms.
Params:
{"textDocument":{"uri":"file:///home/rwh/go/src/goxmeans/km_test.go"},"range":{"start":{"line":8,"character":10},"end":{"line":8,"character":10}},"context":{"diagnostics":[]}}
[Trace - 6:06:36 PM] Received response 'textDocument/formatting - (16)' in
0ms.
Params: []
[Trace - 6:06:36 PM] Sending notification 'textDocument/formatting' in 31ms.
Params:
{"textDocument":{"uri":"file:///home/rwh/go/src/goxmeans/km_test.go"},"options":{"tabSize":4,"insertSpaces":false}}
On Sun, Jul 14, 2019 at 5:35 PM Rebecca Stambler<EMAIL_ADDRESS>wrote:

Do the other features work for you? Does formatting work if you
right-click and "Format Document"? Can you share a gopls log? See
https://github.com/golang/go/wiki/gopls#troubleshooting.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/golang/go/issues/33089?email_source=notifications&email_token=AACHUD3UQBYFKDI7DDGG6BTP7OL2DA5CNFSM4ICRKP4KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZ4NX5I#issuecomment-511237109,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AACHUD3HKPOGVHGRKAMYK5DP7OL2DANCNFSM4ICRKP4A
.

--
Bob Hancock

Can you share a log from when you save and expect goimports to work? Note that you can set
"[go]": {
  "editor.codeActionsOnSaveTimeout": 3000
}

to increase the timeout for goimports, which may solve your problem.

I add the entry to settings.json.
I deleted "fmt" from my import statements.
Saved the fiel.
The import was not inserted.

[Trace - 6:21:06 PM] Received response 'textDocument/codeAction - (9)' in
0ms.
Params: [{"title":"Organize
Imports","kind":"source.organizeImports","edit":{"changes":{"file:///home/rwh/go/src/goxmeans/km_test.go":[{"range":{"start":{"line":4,"character":0},"end":{"line":4,"character":0}},"newText":"\t"fmt"\n"}]}}}]
[Trace - 6:21:06 PM] Sending notification 'textDocument/codeAction' in 28ms.
Params:
{"textDocument":{"uri":"file:///home/rwh/go/src/goxmeans/km_test.go"},"range":{"start":{"line":5,"character":4},"end":{"line":5,"character":4}},"context":{"diagnostics":[]}}
On Sun, Jul 14, 2019 at 6:17 PM Rebecca Stambler<EMAIL_ADDRESS>wrote:

Can you share a log from when you save and expect goimports to work? Note
that you can set
"[go]": {
"editor.codeActionsOnSaveTimeout": 3000
}
to increase the timeout for goimports, which may solve your problem.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/golang/go/issues/33089?email_source=notifications&email_token=AACHUD37NBGIWI6A3MKA6X3P7OQXZA5CNFSM4ICRKP4KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZ4ONBA#issuecomment-511239812,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AACHUD6ZQNCYYBI64FPID5LP7OQXZANCNFSM4ICRKP4A
.

--
Bob Hancock

Based on these log messages, it seems like the response coming from gopls is correct. See the "newText" field of the response, which adds "fmt". This doesn't seem to be a gopls issue, but rather something to do with VSCode. It may be worth opening an issue with https://github.com/microsoft/vscode-go  or https://github.com/microsoft/vscode-languageserver-node.

Thanks for the insight and rapid replies. I'll open an appropriate but at
one of the two VSCode site.
On Sun, Jul 14, 2019 at 7:01 PM Rebecca Stambler<EMAIL_ADDRESS>wrote:

Based on these log messages, it seems like the response coming from gopls
is correct. See the "newText" field of the response, which adds "fmt".
This doesn't seem to be a gopls issue, but rather something to do with
VSCode. It may be worth opening an issue with
https://github.com/microsoft/vscode-go or
https://github.com/microsoft/vscode-languageserver-node.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/golang/go/issues/33089?email_source=notifications&email_token=AACHUD5FEDNCJQ55IVCKYVDP7OV3RA5CNFSM4ICRKP4KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZ4PABA#issuecomment-511242244,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AACHUD57Y35KSYUNDLLGGSDP7OV3RANCNFSM4ICRKP4A
.

--
Bob Hancock


Ghost cell exchanges

Originally reported by: Donna Calhoun (Bitbucket: donnaaboise, GitHub: donnaaboise)

Need to make ghost cell exchanges more flexible, i.e. the user should be able to easily swap their ghost cel exchange method easily.
This is needed to allow for different data organization between clawpack 4.6 and 5.0 (location of field variables in data arrays).

Bitbucket: https://bitbucket.org/donnaaboise/forestclaw/issue/39

This was also fixed a while ago.   (maybe an issue with BitBucket migration?)


Put spectrum loading in background for annotation metadraw

spectra in raw files can be addressed individually, so maybe we don't even have to load the whole thing for the viewer to work. just load the active spectrum.
Also, we could background the loading and let folks get started on what is loaded.
The waiting is the hardest part.
Maybe update the loading bar with a %completion based on spectrum number?
Probably should only load spectra with some sort of identification and not load all the spectra

we don't have dynamic scan loading for mzML so that would only be possible for .raw files (which would be nice)
% loading - needs to be an mzLib change. The mzLib file loading doesn't report any progress.
At one point we did allow plotting of scans even without a PSM (you could view the unannotated spectrum). Might be kind of nice to retain this feature

this was fixed at some point but i forget the PR number


Allow setting  argument from pytest.ini

Repost from my code comment
<directories> option which can be in cmdline cant be set from pytest.ini as the cmdline arguments which don't start with -- dont get overloaded from ini.
There should be a way to do that.

Closing for the reasons explained in the comment's response.


Using dynamic reference to communicator

Hi,
I'd like to store a communicator as dynamic reference, e.g.
let comm = &dyn Communicator;

This is so that users can provide any communicator that implements the Communicator trait without having to introduce a generic for it.
My problem is with using it. If I have a SystemCommunicator I can easily access communication methods (e.g. all_reduce_into).
But it is not possible if I only have a reference to a  Communicator trait object.
Is there a way to use communication routines through a generic Communicator trait object? Or do I always require a concrete communicator? In the latter case how can we write code that supports different types of communicators?

This part wasn't my design. I haven't thought about this carefully, but surely need this capability to write higher level libraries. Can you make a test and propose an implementation?

Currently going trough the source code. Goal is to access all_reduce_into from a &dyn Communicator trait object.
all_reduce_into is defined in the CommunicatorCollectives trait. This trait derives from Communicator and is implemented for any Communicator type. So ideally we would just cast
(&dyn Communicator as &dyn CollectiveCommunicator).all_reduce_into(...)

However, this does not work because CollectiveCommunicator has template methods and cannot be cast into a trait object.
What seems to work is to implement CollectiveCommunicator for dyn Communicator that is to add in collective.rs the line
imp CollectiveCommunicator for dyn Communicator.
We would have to do this for all derived traits from Communicator in order for users to be able to use Communicator as trait object. I don't know if there are any other boundary effects from doing this. But this might be a solution.

Looked more into the above. An issue is the process_at_rank method in the Communicator trait. It requires Self to be sized therefore cannot be called on the trait object.

Surely that can be resolved with a little indirection at most.

Agree. We would need to implement some stuff for dyn Communicator if we want it to have the same functionality as the direct communicator types. For example the process_at_rank method returns a new Process struct that does nothing else than storing a reference to the communicator + the rank information given to process_at_rank.
The actual point to point communication is then implemented as a trait that only needs the rank information and the as_raw method from the communicator. I suspect the same with others.
So yes. With a bit of writing we could probably make everything work for a dyn Communicator object. Would this be desirable? It requires a bit of special code just for dyn Communicator but allows users to pass communicators everywhere simply as trait objects.

So I think process_at_rank is just to avoid if statements in certain code paths. Maybe it should hold an &'a dyn Communicator instead of &'a C where C: 'a + Communicator? Would that be a localized change?

So yes. With a bit of writing we could probably make everything work for a dyn Communicator object. Would this be desirable? It requires a bit of special code just for dyn Communicator but allows users to pass communicators everywhere simply as trait objects.

This is definitely desirable. I am trying to write a higher level library and it is very annoying that I cannot support UserCommunicators easily. Why exactly are those two different types anyway? I never worked extensively with MPI in other languages, but if I understand it correctly, all communicators are the same type in standard MPI. Why make this awkward distinction that breaks all design patterns?
Wouldn't it be better to have either one trait that is common to all communicators (like Communicator but one that actually exposes all functions that are present in communicators) or even unify the entire thing into one enum (like MPI usually does)?

I don't like this organization either. I think type-system expression of InterCommunicator is useful because it behaves differently (the caller almost always needs to know whether they're working with an intra- or inter-comm). I think the User versus System distinction could be removed from the type system or converted to an enum. This was not my design and I don't have time to change it myself, but I'd be happy to review a PR.

I may have time to look into this, but I don't understand the distinction of [System/User]Communicator and [System/User]CommunicatorHandle. Both structs contain the same information in each case, and both support construction from raw ffi handles, but I cannot really see what else the -Handle structs do.
The CommunicatorHandle trait is empty, and I can't find traits that are implemented for the handle structs aside from those that handle conversion to ffi handles. They are also absent from the docsrs documentation, despite being public.

If you can simplify while keeping the examples working, I'm all for it.

So I think process_at_rank is just to avoid if statements in certain code paths. Maybe it should hold an &'a dyn Communicator instead of &'a C where C: 'a + Communicator? Would that be a localized change?

No, because the trait AsCommunicator is defined as
pub trait AsCommunicator {
    type Out: Communicator;

    fn as_communicator(&self) -> &Self::Out;
}

Setting Out to dyn Communicator doesn't work because that isn't sized.
Also this doesn't solve the issue, because converting a &self reference to a &'a dyn Communicator still requires it to be sized.

I have come up with a solution to the problem of the Process not being Sized. The Process currently looks like this:
#[derive(Copy, Clone)]
pub struct Process<'a, C>
where
    C: 'a + Communicator,
{
    comm: &'a C,
    rank: Rank,
}

We can change this to remove the type parameter (assuming #155 gets merged):
#[derive(Clone)]
pub struct Process<'a> {
    comm: &'a CommunicatorHandle,
    rank: Rank,
}

This then creates a new problem because Process implements AsCommunicator to turn back into the communicator it was derived from. This is for example used to compare process instances. We obviously cannot create a Communicator instance from a reference (that would leave dangling references if the original communicator was dropped).
But we can instead implement Communicator for Process. This is not a problem because Process is bound to the original communicator by its lifetime, so it can never be dangling. This also hides away the CommunicatorHandle properly, and it is a relatively localized change (ignoring the removal of the type parameter).
This has the unfortunate side-effect that we now need a way to get a handle from a Communicator, so we can create the process:
fn by_rank(c: &'a (impl Communicator + ?Sized), r: Rank) -> Option<Self> {
    if r != unsafe { ffi::RSMPI_PROC_NULL } {
        Some(Process {
            comm: c.get_handle(),
            rank: r,
        })
    } else {
        None
    }
}

This necessitates that every Communicator implements a crate-public function get_handle. I currently enforce this by changing trait Communicator to be derived from a sealed trait (hidden in a crate-public module). This way I need not expose the handle to public API and can still access it from every Communicator. I unfortunatelly cannot provide a blanket implementation for this function, since the handles are part of the implementing types.
These changes allow functions like process_at_rank to be called on trait-objects.
The same approach works for struct AnyProcess.
Then there are functions in Communicator left that have type parameters. Many of those (particularly those that use Group) can be changed locally to use trait-objects instead. I am fairly certain this doesn't break anything.
The only functions left are get_attr, which cannot use a trait-object because it uses an associated type on its type-parameter, and all methods that use Buffer objects. It may be possible using trait-objects for those (though this seems iffy to me), but I haven't looked into that yet. Any ideas for those last methods? (using dyn Communicator still works without those methods by the way, you just cannot call methods that have the Self: Sized type boundary).
My experimental implementation of this can be found here. It is branched from #155.


Getting dotted line border around current slide

I am seeing a dotted line border around the current slide when scrolling through. Any way to shut this off?

No JSFiddle - closing

No brains...

That did it for me:
.slick-slide {
  outline: none;
}

Wow.. That was awesome! See how easy this is @mcashley.  Ashely, you should take a lesson from Marvin on being helpful.
Thanks again Marvin!

Thanks @marvinosswald :grin:
@chassq could you direct support queries to the appropriate channels in future, please. Also; You were asked to provide a fiddle when opening the issue. You just missed/ignored it :+1:
@mcashley is trying to help close non-issues; and when there (was) over 400 of them (mostly support / questions / not-bugs), it becomes difficult to repeatedly explain something that is clearly stated in the contributing guidelines, so please forgive him, maybe don't insult/attack him, and hop on Gitter if you have any future queries. :smile:  I notice all your Github contributions are support questions in bug-tracking software, so I'll assume nobody ever told you the difference between bug-tracking and support. I also note that Github is terrible at distiguishing the difference, too. So you have the benefit of the doubt. :wink:
Best, Simon.

If its too hard to reply "send us a js fiddle" vs. "No JS Fiddle - Closing" then maybe you should consider not building on or participating in the product. Just a thought. Also, nothing in my statement was an attack. Just pointing out how bad that kind of interaction is.  If you need more samples of how to do this properly then look at what @marcellscarlett sent. You should learn closing an issue does not solve an issue. Your canned reply in this situation should be "Send us a js fiddle". Really, how hard is that...

@chassq I'm am absolutely certain there was no offense intended.
Please consider that we have to prioritize our time--we're all doing this for free--and can't individually address every issue. It's more likely that we make efforts to give individual attention to issues, when the issue's submitter has made an effort.
In future, I recommend searching through old issues to see if there was a solution--this one has a healthy amount of predecessors--and consulting the contribution guidelines.

@leggomuhgreggo Thanks for the nice reply. In the future, I recommend remembering that anyone who makes the effort to download the product, use it and ask for assistiance is making a contribution.

To add on to that I fully appreciate your efforts but remember you guys are not the only busy ones in the world. The folks who use the products (and some of us also do work for free) have to download, read, assess, find samples and implement. When a question is raised any product dev team should look at that as contribution and not just support. We have taking our time to essentially test your product just by the act of using it. By the way, I did look through the repository prior to asking but found nothing at the time. If there are predecessors please point them out.

@chassq  Here are previous issues addressing your question. I can appreciate that sometimes it's difficult to find the right terminology when searching.
We have contribution guidelines for the sake of everyone's busy schedules, and they help avoid unnecessary dramas. Obviously, there's no obligation to use this resource, and, since it's free, there's no entitlement to support.
We all like helping people out here, which is why we spend our time doing it, but it's definitely better when communications are kept professional, without name calling and the like. I appreciate that the intent was to address a perceived issue with the library, and I hope we can continue forward, respectfully, with that shared purpose.
Just so there's no unpleasant surprises in future, we close issues without test cases to demo the issue, and we also close support requests. It's not meant to be personal; just a practical necessity. Even so more often than not, someone will take the time to answer a question, even when closed.

Well I had accepted what @leggomuhgreggo had last written. He was polite and laid out his reasoning well. I may not agree but I respected what he had to say. Now this abuse.. You are sad Ken.. Plenty of other sliders to choose from... I hope your parents were nice to you...

   And if you'd like to take it any further than that, come see me. In person. You entitled loudmouth.

:+1: +1 :fire:
:popcorn:


Custom AnimatedVectorDrawable not working

Hi there. I read your wonderful blog post (thank you!) and tried making a custom animated vector drawable. However, it doesn't seem to work. I used the IconAnimator in Roman Nurik's Asset Studio to make it. I've been debugging it the entire morning and I was hoping you may know what is wrong. I created a small sample project to demonstrate how my icon is not working, whereas your play/pause/stop icon is working just fine, with seemingly equivalent code.

Well I figured it out. Turns out the order in the Animator Selector xml file matters. The vector without state="true" should be last. Not sure why that matters though.


how to start?

Follow the doc, however, i don't know how to start the athenax.

I must need yarn and hdfs?
Does it have standalong model just like Spark?

I think the detail doc is necessary for the open source project.
Thank you!

Agree with hongxiuzhe, more detailed docs please. It would make it a lot easy for others to adopt it.

@hanjb I have the same question as @hongxiuzhe. I could try it out myself but would like to know could I directly replace hdfs:// with s3://

@hongxiuzhe @hanjb are you following this document: http://athenax.readthedocs.io/en/latest/getting_started/ ?
Following the doc you will start a service which provides REST APIs to create / modify / submit Flink SQL applications.
To answer some of your questions:

Yes you need to install YARN.
It does not have a standalone model yet; Are you referring to something like a SQL command line tool, for example like beeline to Hive?

What should be in the catalog.impl. Can you provide some reference of it.

How to configure parameter catalog.impl？Can someone give an example? Thank you


npm module updates

I raised this PR because I was getting lots of npm audit warnings.  After this there are none.

removes dependency on npm as it was not being used, and it's bad
practice to rely on npm as a dependency
does not update express-validator as there is a breaking change that
requires considerable refactoring
fixes incorrect license assignment in package.json

Thanks @blgm!


Fix warning introduced in iterator suite

Signed-off-by: Alessandro Bellina<EMAIL_ADDRESS>Removes new warning introduced by https://github.com/NVIDIA/spark-rapids/pull/994 in the tests:
[WARNING] /home/abellina/work/rapids-plugin-4-spark/tests/src/test/scala/com/nvidia/spark/rapids/shuffle/RapidsShuffleIteratorSuite.scala:121: This catches all Throwables. If this is really intended, use `case _ : Throwable` to clear this warning.
[WARNING]         case _ =>

build


Adds README and Linting to repo

Resolves https://github.com/microsoftgraph/msgraph-sdk-typescript/issues/14
Resolves https://github.com/microsoftgraph/msgraph-sdk-typescript/issues/10
Resolves https://github.com/microsoftgraph/msgraph-sdk-typescript/issues/13

Let's try to merge this by tomorrow. The README.me will be important for our Community Preview!


Unable to send tapbacks in sms chats.

I am unable to send tapbacks in sms chats.

Tapbacks are only avaliable for imessage chats.

You are able to do it with the messages app on Mac and iPhone.

While yes, you can technically "send a tapback", it just sends as a regular text message to recipients which is why we haven't included this functionality. There isn't really a purpose of tapback functionality for SMS chats because it only shows as a tapback on the message for you


Add unit test for all subcommand

@nao1215
I don't know why the CI passed, but this commit b515c5a seems to fail on local testing.
Both on macOS and Linux (Docker: golang:1.18 & golang:latest).
$ sw_vers
ProductName:    macOS
ProductVersion: 12.5
BuildVersion:   21G72

$ go version
go version go1.19.1 darwin/amd64

$ git status
On branch main
Your branch is up to date with 'origin/main'.

nothing to commit, working tree clean

$ git show
commit b515c5abdf5385ee3ad23ceabe44d1aa50bc6347 (HEAD -> main, upstream/main, upstream/HEAD, origin/main, origin/HEAD)
Merge: d25b452 514386f
Author: CHIKAMATSU Naohiro<EMAIL_ADDRESS>Date:   Sat Sep 17 16:00:07 2022 +0900

    Merge pull request #42 from nao1215/add-unit-tests-for-subcmd

    Add unit test for all subcommand

Logs
$ go test ./...
?       github.com/nao1215/gup  [no test files]

gup:WARN : can't get 'test'package path information. old go version binary
--- FAIL: Test_export (0.02s)
    --- FAIL: Test_export/can_not_make_.config_directory (0.00s)
        export_test.go:196: value is mismatch (-want +got):
              []string{
                strings.Join({
                        "gup:ERROR: can not make config directory: mkdir /.config: ",
            -           "permission denied",
            +           "read-only file system",
                }, ""),
                "",
              }
gup:ERROR: /.config/gup/gup.conf is not found
gup:ERROR: can not parse command line argument: flag accessed but not defined: dry-run
gup:ERROR: testdata/empty_conf/.config/gup/gup.conf is not found
gup:ERROR: testdata/can_not_read_conf/.config/gup/gup.conf is not found
gup:ERROR: no such file or directory: testdata/delete/posixer.exe
gup:CHECK: remove testdata/delete/posixer? [Y/n] gup:INFO : removed testdata/delete/posixer
gup:CHECK: remove testdata/delete/posixer? [Y/n] gup:INFO : cancel removal testdata/delete/posixer
gup command update binaries installed by 'go install'.
If you update all binaries, just run '$ gup update'

Usage:
  gup [command]

Available Commands:
  check       Check the latest version of the binary installed by 'go install'
  export      Export the binary names under $GOPATH/bin and their path info. to gup.conf.
  help        Help about any command
  import      Install command according to gup.conf.
  list        List up command name with package path and version under $GOPATH/bin or $GOBIN
  remove      Remove the binary under $GOPATH/bin or $GOBIN
  update      Update binaries installed by 'go install'
  version     Show gup command version information

Flags:
  -h, --help   help for gup

Use "gup [command] --help" for more information about a command.
Error: unknown flag: --no-exist-option
Usage:
  gup [command]

Available Commands:
  check       Check the latest version of the binary installed by 'go install'
  export      Export the binary names under $GOPATH/bin and their path info. to gup.conf.
  help        Help about any command
  import      Install command according to gup.conf.
  list        List up command name with package path and version under $GOPATH/bin or $GOBIN
  remove      Remove the binary under $GOPATH/bin or $GOBIN
  update      Update binaries installed by 'go install'
  version     Show gup command version information

Flags:
  -h, --help   help for gup

Use "gup [command] --help" for more information about a command.

gup:ERROR: unknown flag: --no-exist-option

gup:INFO : removed testdata/delete/posixer
gup:INFO : Export /Users/admin/.config/gup/gup.conf
gup:INFO : create bash-completion file: testdata/.bash_completion
gup:INFO : create fish-completion file: testdata/.config/fish/completions/gup.fish
gup:INFO : create zsh-completion file: testdata/.zsh/completion/_gup
gup:ERROR: testdata/.config/gup/gup.conf is not found
--- FAIL: TestExecute_Update (0.00s)
    root_test.go:476: rename /Users/admin/go/bin /Users/admin/go/bin.backup: file exists
--- FAIL: TestExecute_Update_DryRun (0.00s)
    root_test.go:569: rename /Users/admin/go/bin /Users/admin/go/bin.backup: file exists
gup:WARN : not found 'test4' package in $GOPATH/bin or $GOBIN
FAIL
FAIL    github.com/nao1215/gup/cmd      1.001s
?       github.com/nao1215/gup/internal/assets  [no test files]
?       github.com/nao1215/gup/internal/cmdinfo [no test files]
?       github.com/nao1215/gup/internal/completion      [no test files]
?       github.com/nao1215/gup/internal/config  [no test files]
?       github.com/nao1215/gup/internal/file    [no test files]
?       github.com/nao1215/gup/internal/goutil  [no test files]
?       github.com/nao1215/gup/internal/notify  [no test files]
ok      github.com/nao1215/gup/internal/print   (cached)
ok      github.com/nao1215/gup/internal/slice   (cached)
FAIL

To reproduce
If you have Docker installed, here's the Dockerfile to reproduce.

Logs
$ docker build -t test:local .
[+] Building 17.1s (6/6) FINISHED
 => [internal] load build definition from Dockerfile                                                                                0.0s
 => => transferring dockerfile: 37B                                                                                0.0s
 => [internal] load .dockerignore                                                                                0.0s
 => => transferring context: 2B                                                                                0.0s
 => [internal] load metadata for docker.io/library/golang:1.18                                                                                0.0s
 => [1/3] FROM docker.io/library/golang:1.18                                                                                0.0s
 => CACHED [2/3] WORKDIR /go/src                                                                                0.0s
 => ERROR [3/3] RUN     git clone https://github.com/nao1215/gup.git &&     cd gup &&     go mod download &&     go test ./...                                                           17.0s
------
 > [3/3] RUN     git clone https://github.com/nao1215/gup.git &&     cd gup &&     go mod download &&     go test ./...:
#6 0.233 Cloning into 'gup'...
#6 13.94 ?      github.com/nao1215/gup  [no test files]
#6 16.77
#6 16.77 gup:WARN : can't get 'test'package path information. old go version binary
#6 16.77 --- FAIL: Test_export (0.03s)
#6 16.77     --- FAIL: Test_export/can_not_make_.config_directory (0.00s)
#6 16.77         export_test.go:196: value is mismatch (-want +got):
#6 16.77               []string{
#6 16.77               	strings.Join({
#6 16.77               		"gup:ERROR: ",
#6 16.77             - 		"can not make config directory: mkdir /.config: permission denied",
#6 16.77             + 		"no package information",
#6 16.77               	}, ""),
#6 16.77               	"",
#6 16.77               }
#6 16.77 gup:ERROR: /.config/gup/gup.conf is not found
#6 16.77 gup:ERROR: can not parse command line argument: flag accessed but not defined: dry-run
#6 16.77 gup:ERROR: testdata/empty_conf/.config/gup/gup.conf is not found
#6 16.77 gup:ERROR: testdata/can_not_read_conf/.config/gup/gup.conf is not found
#6 16.77 gup:ERROR: no such file or directory: testdata/delete/posixer.exe
#6 16.77 gup:CHECK: remove testdata/delete/posixer? [Y/n] gup:INFO : removed testdata/delete/posixer
#6 16.77 gup:CHECK: remove testdata/delete/posixer? [Y/n] gup:INFO : cancel removal testdata/delete/posixer
#6 16.77 gup:INFO : create bash-completion file: /root/.bash_completion
#6 16.77 gup:INFO : create fish-completion file: /root/.config/fish/completions/gup.fish
#6 16.77 gup:INFO : create zsh-completion file: /root/.zsh/completion/_gup
#6 16.77 gup command update binaries installed by 'go install'.
#6 16.77 If you update all binaries, just run '$ gup update'
#6 16.77
#6 16.77 Usage:
#6 16.77   gup [command]
#6 16.77
#6 16.77 Available Commands:
#6 16.77   check       Check the latest version of the binary installed by 'go install'
#6 16.77   export      Export the binary names under $GOPATH/bin and their path info. to gup.conf.
#6 16.77   help        Help about any command
#6 16.77   import      Install command according to gup.conf.
#6 16.77   list        List up command name with package path and version under $GOPATH/bin or $GOBIN
#6 16.77   remove      Remove the binary under $GOPATH/bin or $GOBIN
#6 16.77   update      Update binaries installed by 'go install'
#6 16.77   version     Show gup command version information
#6 16.77
#6 16.77 Flags:
#6 16.77   -h, --help   help for gup
#6 16.77
#6 16.77 Use "gup [command] --help" for more information about a command.
#6 16.77 gup:INFO : append bash-completion: /root/.bash_completion
#6 16.77 Error: unknown flag: --no-exist-option
#6 16.77 Usage:
#6 16.77   gup [command]
#6 16.77
#6 16.77 Available Commands:
#6 16.77   check       Check the latest version of the binary installed by 'go install'
#6 16.77   export      Export the binary names under $GOPATH/bin and their path info. to gup.conf.
#6 16.77   help        Help about any command
#6 16.77   import      Install command according to gup.conf.
#6 16.77   list        List up command name with package path and version under $GOPATH/bin or $GOBIN
#6 16.77   remove      Remove the binary under $GOPATH/bin or $GOBIN
#6 16.77   update      Update binaries installed by 'go install'
#6 16.77   version     Show gup command version information
#6 16.77
#6 16.77 Flags:
#6 16.77   -h, --help   help for gup
#6 16.77
#6 16.77 Use "gup [command] --help" for more information about a command.
#6 16.77
#6 16.77 gup:ERROR: unknown flag: --no-exist-option
#6 16.77
#6 16.77 gup:INFO : append bash-completion: /root/.bash_completion
#6 16.77 gup:INFO : append bash-completion: /root/.bash_completion
#6 16.77 gup:INFO : removed testdata/delete/posixer
#6 16.77 gup:INFO : append bash-completion: /root/.bash_completion
#6 16.77 gup:INFO : Export /root/.config/gup/gup.conf
#6 16.77 gup:INFO : create bash-completion file: testdata/.bash_completion
#6 16.77 gup:INFO : create fish-completion file: testdata/.config/fish/completions/gup.fish
#6 16.77 gup:INFO : create zsh-completion file: testdata/.zsh/completion/_gup
#6 16.77 gup:ERROR: testdata/.config/gup/gup.conf is not found
#6 16.77 --- FAIL: TestExecute_Update (0.00s)
#6 16.77     root_test.go:476: rename /go/bin /go/bin.backup: invalid cross-device link
#6 16.77 --- FAIL: TestExecute_Update_DryRun (0.00s)
#6 16.77     root_test.go:569: rename /go/bin /go/bin.backup: invalid cross-device link
#6 16.77 gup:WARN : not found 'test4' package in $GOPATH/bin or $GOBIN
#6 16.77 FAIL
#6 16.77 FAIL	github.com/nao1215/gup/cmd	1.908s
#6 16.77 ?   	github.com/nao1215/gup/internal/assets	[no test files]
#6 16.77 ?   	github.com/nao1215/gup/internal/cmdinfo	[no test files]
#6 16.77 ?   	github.com/nao1215/gup/internal/completion	[no test files]
#6 16.77 ?   	github.com/nao1215/gup/internal/config	[no test files]
#6 16.77 ?   	github.com/nao1215/gup/internal/file	[no test files]
#6 16.77 ?   	github.com/nao1215/gup/internal/goutil	[no test files]
#6 16.77 ?   	github.com/nao1215/gup/internal/notify	[no test files]
#6 16.77 ok  	github.com/nao1215/gup/internal/print	0.011s
#6 16.77 ok  	github.com/nao1215/gup/internal/slice	0.008s
#6 16.77 FAIL
------
executor failed running [/bin/sh -c git clone https://github.com/nao1215/gup.git &&     cd gup &&     go mod download &&     go test ./...]: exit code: 1

I haven't looked into it in depth, but I have a feeling it is related to this line.
https://github.com/nao1215/gup/blob/b515c5abdf5385ee3ad23ceabe44d1aa50bc6347/cmd/export_test.go#L161
It seems to set the HOME dir to the root. Isn't it safer to set to the temp directory from t.TempDir()?

@KEINOS
This error occurs because the error message for read permission is different between macOS and Linux. Error messages returned by the code in the layer close to the system call are different between macOS and Linux.
       export_test.go:196: value is mismatch (-want +got):
              []string{
                strings.Join({
                        "gup:ERROR: can not make config directory: mkdir /.config: ",
            -           "permission denied",
            +           "read-only file system",
                }, ""),
                "",

However, reproducing the error using Docker may present a different problem. I'm pretty sure the test code is wrong.

@KEINOS
Please see #43 .
I don't have a Mac, so the bug may not be fixed. If so, I will revert #43 .
（The error that occurs in Docker should not be fixed. This is different problem）

@nao1215
As you said, sadly #43 9e3fc5e did not fix the error on macOS. 😭
This happens while implementing tests. I understand.

Error messages returned by the code in the layer close to the system call are different between macOS and Linux.

I agree. That happens between Windows and macOS too. Many times 😄
My usual work-around for this, to capture error messages during test, is to wrap the error. I use "github.com/pkg/errors" to wrap the error in the function before returning it.
E.g.:
func doSomething(pathDir string) error {
-   return os.MkdirAll(pathDir, 0775)
+   if err := os.MkdirAll(pathDir, 0775); err != nil {
+     errors.Wrap(err, "failed to make directory")
+   }
    // do the thing
}

Like so, the test needs to check only the "failed to make directory" message. You don't need to think about the OS dependent messages.
Another useful package that I found while using cobra is github.com/zenizh/go-capturer (formally known as github.com/kami-zh/go-capturer). It allows you to capture STDOUT and STDERR very simple.

Simple example
Doc: Goで標準出力をキャプチャするパッケージを書いた @ Qiita

Solving these problems one by one should raise gup's profile and demonstrate that it is a reliable software. Let's fix them! 💪


使用docker-compose 无法解析 db host

logs
2019/08/06 10:27:25 [error] 48#48: *11 [lua] mysql_db.lua:30: query(): failed to connect: failed to connect: orange-database could not be resolved (3: Host not found): nil nil, client: <IP_ADDRESS>, server: , request: "POST /monitor/enable HTTP/1.1", host: "<IP_ADDRESS>:8889", referrer: "http://<IP_ADDRESS>:8889/monitor"
2019/08/06 10:27:25 [error] 48#48: *11 [lua] mysql_store.lua:91: update_enable(): MySQLStore:update error:nil, client: <IP_ADDRESS>, server: , request: "POST /monitor/enable HTTP/1.1", host: "<IP_ADDRESS>:8889", referrer: "http://<IP_ADDRESS>:8889/monitor"
2019/08/06 10:27:27 [info] 49#49: *12 client closed connection while waiting for request, client: <IP_ADDRESS>, server: <IP_ADDRESS>:9999

进入容器能都ping telnet 也是ok的 容器的mysql 也是可以访问的

兄弟，你这个问题解决了没有？


fix: allow compilation on MUSL libc

On MUSL libc, the sockaddr_in6 struct is not the same as on glibc, unfortunately, the inner structure of the struct isn't mandated by POSIX 😓
Edit: But there is a "public interface", that works on both glibc and musl, thanks to @r00tifant for knowing that
I needed this for https://github.com/Totto16/oopetris_lobby/commit/6de856d53bc22a825a5991fa0085e8b04df5c5e9 and https://github.com/OpenBrickProtocolFoundation/lobby/pull/5 so that docker image can be built,
NOTE: after this is merged 🙏🏼  simulator needs to be updated as well, as this is a sub depedendency there and thats the main reason for updating this.

I added the desired changes and created a new PR (see here). I will close this one. Thanks for you help! <3


Documenting installation

Depends on #329 and #331
Fix #324, fix #325, fix #326, fix #327, fix #328, fix #333
Add bigger documentation on how to install from sources and use the node with docker-compose.

Codecov Report

Merging #332 (e64d0e4) into main (1464082) will decrease coverage by 0.5%.
The diff coverage is n/a.

:exclamation: Current head e64d0e4 differs from pull request most recent head 09c25a1. Consider uploading reports for the commit 09c25a1 to get more accurate results

@@           Coverage Diff           @@
##            main    #332     +/-   ##
=======================================
- Coverage   15.2%   14.7%   -0.5%
=======================================
  Files         27      27
  Lines       6645    6858    +213
=======================================
  Hits        1007    1007
- Misses      5638    5851    +213

Impacted Files
Coverage Δ

src/rpc/request.rs
15.9% <0.0%> (-0.3%)
:arrow_down:

src/swapd/runtime.rs
0.0% <0.0%> (ø)

src/walletd/runtime.rs
0.0% <0.0%> (ø)

src/farcasterd/runtime.rs
0.0% <0.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1464082...09c25a1. Read the comment docs.


Fix positioning of context menu

it placed not right beneath the mouse pointer.

Can't reproduce, probably fixed through #421

Issue occurs when starting from landingpage, then switching to graph view.

@myrho can we close this?


QmlTask: Allow constructing from other awaitable types

Parts of this code are still very "creative", so let me know if it can be done more properly :)

CI Issues:

Qt installation on macOS seems broken
There is a parse error in a QtConcurrent header with Qt 5.15.2 and gcc >= 11

Awesome, thank you very much!


The tooltip shows underneath another component

I've used the @devexpress/dx-react-scheduler for the calendar and tried to show the tooltip on each schedule. But the tooltip is shown underneath  (see the below screenshot). Do you know how to fix this issue?

Thanks & regards,
Huy

@huy1912 did you fix it already? It's also happening to me

@Sir-hennihau, still haven't got the issue yet. Will share if I found the workaround for it.

@huy1912 I had to fix z-index property on the div that my tooltip was hidden below. i removed it's z-index property.
if you want to keep using z-indexes keep that in mind:
Note: z-index only works on positioned elements (position: absolute, position: relative, position: fixed, or position: sticky) and flex items (elements that are direct children of display:flex elements).

@huy1912
I also had this issue, however I figured out that I was using the component incorrectly.
you haven't provided your code so I don't know if you're having the same issue, but this is what fixed it for me.
do this:
    <>
      <BiInfoSquare
      size={22}
      // place the text you want to display in the 'data-tip'
      data-tip={text}
      // make sure 'data-for' is the same as the react tip 'id'
      data-for={key}
      />
      <ReactTooltip id={key} place="top" type="dark" effect="solid" />
    </>

don't do this:
    <>
      <BiInfoSquare
      size={22}
      data-tip
      // make sure 'data-for' is the same as the react tip 'id'
      data-for={key}
      />
      <ReactTooltip id={key} place="top" type="dark" effect="solid">
       {text}
      </ReactTooltip>
    </>

Hope this helps

@huy1912
I also had this issue, however I figured out that I was using the component incorrectly.
you haven't provided your code so I don't know if you're having the same issue, but this is what fixed it for me.
do this:
    <>
      <BiInfoSquare
      size={22}
      // place the text you want to display in the 'data-tip'
      data-tip={text}
      // make sure 'data-for' is the same as the react tip 'id'
      data-for={key}
      />
      <ReactTooltip id={key} place="top" type="dark" effect="solid" />
    </>

don't do this:
    <>
      <BiInfoSquare
      size={22}
      data-tip
      // make sure 'data-for' is the same as the react tip 'id'
      data-for={key}
      />
      <ReactTooltip id={key} place="top" type="dark" effect="solid">
       {text}
      </ReactTooltip>
    </>

Hope this helps

Thanks @ ShawnCockburn, I've tried with your solution. The issue still hasn't been resolved. Not sure due to some other reason.

@huy1912 I had to fix z-index property on the div that my tooltip was hidden below. i removed it's z-index property.
if you want to keep using z-indexes keep that in mind:
Note: z-index only works on positioned elements (position: absolute, position: relative, position: fixed, or position: sticky) and flex items (elements that are direct children of display:flex elements).

Thanks @Sir-hennihau, I've checked the calendar item whose position is absolute but it doesn't have any z-index.
Even though I forced the tooltip's z-index to 999. The issue is still the same.

any update? i got the same issue, i tried to change z-index of react-tooltip to 999999 !important but it doesn't work

data-tip

This is the solution, example on an icon:
<FaRegUser                         data-tip="Account"                         data-for={"account"}                       />
Then before the last DIV on the page add:
     <ReactTooltip id={"account"} place="top" type="dark" effect="solid" />

You'll probably need to render the tooltips LAST and as siblings to the relevant components. This seemed to solve the issue for me...

I faced the same issue and this solution works perfectly :) Thank you

This fixes for me:
<Tooltip anchorSelect={#element} style={{ zIndex: 99 }}>


[MWPW-153727] Remove extra border radius from table highlight

Removes an unnecessary border radius from the first content column of a highlight table when it lacks highlight text.

Before
After

Resolves: MWPW-153727
Test URLs:

Before: https://table-review--milo--overmyheadandbody.hlx.page/drafts/ramuntea/table-tiger-team-mwpw-152305?martech-off&georouting=off
After: https://table-extra-radius--milo--overmyheadandbody.hlx.page/drafts/ramuntea/table-tiger-team-mwpw-152305?martech-off&georouting=off

Hi @narcis-radu! They started failing after a previous commit to this feature branch and the committer was already out, so they couldn't be addressed. I've already opened https://jira.corp.adobe.com/browse/MWPW-153609 to ensure we look into unit tests before opening a PR to stage.


[P2P Activation] [CRITICAL] Web - "Pay with Expensify" button is prompting the user to choose bank account or debit card, when they already have an existing bank account linked to their account.

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: <IP_ADDRESS>
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @kevinksullivan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1697481375175609
Action Performed:

User A: login, navigate to Settings > Wallet
User A: add personal bank account
User B: login, select Request money
User B: enter User A as the person you're requesting from
User A: Navigate to IOU from User B
User A: select Pay with Expensify

Expected Result:
User A should go straight to Additional details step, rather than prompting the user to choose a bank account or debit card if they already have a connected payment method
Actual Result:
User A is prompted to choose between bank account and debit card, even though they have a bank account added. Then, if they choose bank account, they're asked to add a new one.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/93399543/f51248b7-08e5-434a-b55f-3da424e081d5

MacOS: Desktop

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01f0f7b78b540bf02c
Upwork Job ID:<PHONE_NUMBER>148497920
Last Price Increase: 2023-10-16

Note: I am also seeing this issue when I try to make a payment while having an upgraded wallet and a bank account.

btw @kevinksullivan this issue is not ready for contributors, isn't it?

The Help Wanted label was actually removed so I guess not.
In any case, I have been unable to reproduce the issue on the latest main branch.

I tested on main as well. Adding a PBA and then trying to pay via the wallet opens the KYC flow as expected:
https://github.com/Expensify/App/assets/12268372/761e721d-8344-4a72-a641-2eadd7b35437

We use PaymentUtils.hasExpensifyPaymentMethod to check if there's already a valid bank account. As far as I can see, the isDefault prop in the Onyx bankAccountList data is available so hasExpensifyPaymentMethod should work as expected. Doing some more testing.

Tested on desktop:
https://github.com/Expensify/App/assets/12268372/383fb8a3-9192-469a-80b0-24e4518c91c6
And android as well:
https://github.com/Expensify/App/assets/12268372/656edd6e-f2b6-4f9f-9b3e-f6e7a43e9b44
Seems to work as expected. Going to try on staging.

Same on staging, I was redirected to the KYC flow as expected (it's the last step because I started the KYC flow before):
https://github.com/Expensify/App/assets/12268372/e65021bb-d151-4129-b4cf-b75ea63baef5

Okay, I believe the isDefault is the correct property we should rely on here as per the backend code: https://github.com/Expensify/Web-Expensify/blob/40ccd2bbbfe54418d84343ced75616b8e64047b4/lib/BankAccountAPI.php#L1956

isDefault refers to whether the bank account is linked to the wallet.
defaultCredit refers to whether the bank account is the default deposit account for the user.

I think we can get the fix for this included in https://github.com/Expensify/App/issues/29320#issuecomment-1766477292

This one should be fixed by these FE and BE PRs:

https://github.com/Expensify/App/pull/29915
https://github.com/Expensify/Web-Expensify/pull/39205

I think we are good to close for. We can reopen if this is still an issue.


New package: SearchLightPostgreSQL v0.1.0

Registering package: SearchLightPostgreSQL
Repository: https://github.com/GenieFramework/SearchLightPostgreSQL.jl
Created by: @essenciary
Version: v0.1.0
Commit: 9eff6502baeab7d5bfcc335e8583387e8497f046
Reviewed by: @essenciary
Reference: https://github.com/GenieFramework/SearchLightPostgreSQL.jl/commit/9eff6502baeab7d5bfcc335e8583387e8497f046#commitcomment-37226598

Block please, will address the comments

[noblock]
Can I merge this? I think the name is fine.

[noblock]
Bump @essenciary Do you want me to merge this PR or close it?

[noblock]
Bump @essenciary
Can I merge this PR? Let me know.
I will leave this PR open for two more weeks. If you haven’t responded by then, I’ll close this PR - you can make a new registration if you want.

@DilumAluthge Thanks, yes please, merge! The name seems fine to me and I certainly don't wanna change to ...PostgreSql :-/


open-reaction-database.org is unreachable

Getting a DNS_PROBE_FINISHED_NXDOMAIN error when trying to access open-reaction-database.org. Seems to be a new problem today, and I'm getting the error on Chrome and Firefox.
@skearnes, @miori-nd - I think this will need some of your attention if it doesn't self-correct overnight.

Still seems to be down

Looks like the server is still up, but there's a certificate or DNS issue. I'll also add monitoring to get earlier notification of future failures.

This is entirely my fault; I misread the pulumi configuration and accidentally deleted the alias record that routed traffic to the load balancer when I was adding support for the www subdomain.

Verified fixed.


solokey for LUKS encryption

I am trying to use its challenge response method for unlocking a LUKS-encrypted drive (encrypt complete / partition except /boot partition).
I tried to create custom hook(in Arch Linux) for solokey, challenge-response will be performed during booting sequence.
The solokey tool is a python package, I tried to include the python & solo in custom hook on initrd image(using mkinitcpio) but facing issues related to python.
Since yubikey (ykchalresp) tool is a simple binary, its straightforward to include ykchalresp in initrd image(https://github.com/agherzan/yubikey-full-disk-encryption/blob/master/src/install/ykfde). But solokey is only available as python package, facing difficulty including python&solo in initrd image for Arch Linux.
https://github.com/saravanan30erd/solokey-full-disk-encryption/blob/master/skfde-install
Is it any other tool(simple binary same as ykchalresp)  for solokey?

I have no LUKS experience, but I know that https://github.com/shimunn/fido2luks exists.

@nickray thanks, I used this tool to create hook for initrd in Arch linux.
https://github.com/saravanan30erd/solokey-full-disk-encryption/blob/master/hooks/skfde
Looks like solokey is not detected in initrd stage, getting No such device or address (os error 6)

issue related to the tool, not about the device. closing the issue

FYI: http://0pointer.net/blog/unlocking-luks2-volumes-with-tpm2-fido2-pkcs11-security-hardware-on-systemd-248.html

FYI: http://0pointer.net/blog/unlocking-luks2-volumes-with-tpm2-fido2-pkcs11-security-hardware-on-systemd-248.html


The results of first stage1 on imagenet are not same as paper.

This is an urgent question.
Hi, I measure your checkponit on imagenet. The rFID achieved 4.87, but the rFID of paper is 1.55.
I also reproduce in the settings of paper and on your repo code, the results is 4.88.
So i want know why, maybe the paper results are wrong? or your code has something wrong? or my code of measuring fid is wrong (it is from rq-vae official repo.)?
Can you give me some suggestion?

@thuanz123 hi, can you answer this question? I really want to know the reason. Thank you.

Hi this is an unofficial implementation so there may be a lot of thing that are different from the official one which can cause a different in FID score. Also different FID implement can give you different results and since they didn't public their code so I cannot give you a clear anwser for this, sorry

I got it, thank you.
From: "Thuan H. @.>
Date: Sun, Jul 30, 2023, 17:56
Subject: [External] Re: [thuanz123/enhancing-transformers] The results of
first stage1 on imagenet are not same as paper. (Issue #18)
To: "thuanz123/enhancing-transformers"<
@.>
Cc: @.>, "Author"<
@.>
Hi this is an unofficial implementation so there may be a lot of thing that
are different from the official one which can cause a different in FID
score. Also different FID implement can give you different results and
since they didn't public their code so I cannot give you a clear anwser for
this, sorry
—
Reply to this email directly, view it on GitHub
https://github.com/thuanz123/enhancing-transformers/issues/18#issuecomment-1657095644,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A7ZMO7CPZSA3QSODUV3OBL3XSYVTDANCNFSM6AAAAAA2Z725AE
.
You are receiving this because you authored the thread.Message ID:
@.***>

Hi, what is your imagenet version? imagenet-1k, imagenet-21k, imagenet-full
or openimage?
Thank you.
From: @.>
Date: Sun, Jul 30, 2023, 17:57
Subject: Re: [External] Re: [thuanz123/enhancing-transformers] The results
of first stage1 on imagenet are not same as paper. (Issue #18)
To: "thuanz123/enhancing-transformers"<
@.>
I got it, thank you.
From: "Thuan H. @.>
Date: Sun, Jul 30, 2023, 17:56
Subject: [External] Re: [thuanz123/enhancing-transformers] The results of
first stage1 on imagenet are not same as paper. (Issue #18)
To: "thuanz123/enhancing-transformers"<
@.>
Cc: @.>, "Author"<
@.>
Hi this is an unofficial implementation so there may be a lot of thing that
are different from the official one which can cause a different in FID
score. Also different FID implement can give you different results and
since they didn't public their code so I cannot give you a clear anwser for
this, sorry
—
Reply to this email directly, view it on GitHub
https://github.com/thuanz123/enhancing-transformers/issues/18#issuecomment-1657095644,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A7ZMO7CPZSA3QSODUV3OBL3XSYVTDANCNFSM6AAAAAA2Z725AE
.
You are receiving this because you authored the thread.Message ID:
@.***>


Update VAT number reference

WHMCS 7.7 will be integrating VAT into its core. This means we will need to adjust where we get the tax number from. We would also have to adjust the ledger logic to ensure the right ledger is selected.
Ref: https://requests.whmcs.com/topic/tax-vat-numbers-need-to-be-an-integral-part-of-whmcs-including-contacts#comment-13020

WHMCS 7.7 beta has been released today. We'll start testing in a few weeks from now.
Changes affect:
https://github.com/sensson/whmcs-moneybird/blob/master/lib/Models/Client.php#L17
https://github.com/sensson/whmcs-moneybird/blob/master/lib/Models/Invoice.php#L64

This is in version 0.0.2.


Error: Failed to parse dictionary key

Hi @Hopding
Got another pdf load error for you.  It's not a really useful pdf, but I thought you might want to look at it.  I'm on v0.6.1-rc2.  Thanks!
Error: Failed to parse dictionary key
    at error (pdf-lib.js:8569)
    at parseDict (pdf-lib.js:46630)
    at parseDictOrStream (pdf-lib.js:46908)
    at parseIndirectObj (pdf-lib.js:46947)
    at parseBodySection (pdf-lib.js:47174)
    at parseDocument (pdf-lib.js:47226)
    at PDFParser.parse (pdf-lib.js:47257)
    at Function.PDFDocumentFactory.load (pdf-lib.js:47379)

giraffe.pdf

Hello @kevinswartz.
Thanks for sharing this PDF. I took a look at it, and it is definitely corrupted. It's not a subtle corruption either. Among other things, a big chunk of bytes that should be present for one of the embedded image streams is totally gone.
Do you happen to know how this PDF was generated? I'm wondering if it was generated in a corrupted state, or if it was a transmission error that caused the corruption.
Of course, it looks like most PDF viewers are able to open the document despite the corruption. I'll have to think about the best way for pdf-lib to handle this. Ideally, it would be able to fix the corrupted section. But this would require some nontrivial changes to the parsing logic. So I don't expect to work on this in the near-term.
As I understand it, this isn't causing any production issues for you. So I won't prioritize working on this. Please let me know if I misunderstood what you were saying.

@kevinswartz After investigating the other 3 issues you filed (#69, #70, and #73), it appears that you're dealing with an impressive number of corrupted/invalid PDFs. I mentioned that this PDF (the giraffe one) didn't seem to be a production issue, so I wouldn't prioritize work on this. But I assume the other 3 PDFs are causing production issues for you? Please let me know if this is the case, so I can prioritize work on this over other pdf-lib enhancements if necessary.

Hi @Hopding ,
You're right, this, and issue #69 are non-production problems.  I'm just about to email you the pdf for #70 .  This pdf and the one in #69 were generated in Adobe Acrobat Pro for windows.  #73 is a little different and I put a note in there about it.

Hello again @kevinswartz.
I implemented a fix for #70. I plan to work on #73 next.
Is there a particular set of steps you took to generate the PDFs from #68 and #69? I've generated a few PDFs in Adobe Acrobat Pro for Mac, and have been unable to reproduce either of these issues.

Hi @Hopding,
When I generated pdfs for #68 and #69 I was kind of just hacking around.  I saw the error with embedded pdfs in #70 and was just doing more testing with them.  It was all using Adobe Acrobat on windows, and FWIW it didn't seem to happen every time.  Sorry, I know that's probably not very helpful.

No worries. Thanks for the info.
I'm going to close this issue for now since it isn't causing any production issues, and the error seems to be caused by a corrupted document.


Release v7.13.0

Time for a nice big fat update to pull in all the latest great contributions and update the grammars.
I aim to merge and deploy this early next week.

[x] Deployed to GitHub.com
[x] Grammars deployed to Syntax highlighting service - highlighting won't be 💯 up-to-date until this happens
[x] Deployed to Lightshow

All done and now live on GitHub.com and Lightshow!! 🎉


Bump to 1.1.0

Update to deno 1.1.0 and std 0.57.0

Great! Thank you!
Hopefully this will work on lambda 🤞

I'm currently trying with it.

Note: It'll take a 15min to publish (I don't think I have github actions caching working).
https://github.com/hayd/deno-docker/runs/766362560?check_suite_focus=true

Yeah I know, that's why I started the build locally while waiting for the PR to be merged.


Reaction role

Fetched the code from @SimplyJpk's PR and re-created the PR since his repo has been deleted.
Remake of https://github.com/Sirush/UDHBot/pull/103
Closes https://github.com/Sirush/UDHBot/issues/62

Once #8 is merged into this, this'll be safe to merge. Will require some additional setup once live with commands.


module not registered

Hi,
I get this error : Error: download failed: download failed: HTTP 400: dns.providers.gandi is not a registered Caddy module package path (id=b29b0943-02dd-49ca-80e0-0ac66e020fa7)
It seems that it is the same as https://github.com/caddy-dns/acmeproxy/issues/2
Could you check ?
Thanks in advance.

It is already claimed since a long time, I don't know why you got this error

Oh, it seems the OP has tried to download dns.providers.gandi but not github.com/caddy-dns/gandi. That should solve it.