[Chats] Search works incorrect

Environment: Android 10, Samsung A7.
Reproducible: always.
Build found: v1.0.456.
Preconditions
Log into the 'Car' app, some messages have been created and one with text 'hi everyone'.
Steps to reproduce

Go to 'Chats' screen
Click on 'Search' icon
Type 'hi e'

Actual result
The system searches letter 'e' in all parts of the word
Expected result
The system should search letter 'e' at the beginning of the word
User Story #46
Labels to be added
"Bug" ("bug"), Priority ("pri: medium ")
https://user-images.githubusercontent.com/91271776/144884278-fef4a5ed-ba5e-4e35-9386-31eda2856c76.mp4

Verified


flip in few items

Describe the bug

When I  add item to ObservableCollection<> that is the source of FlipView,it can only changes in the front items.
Steps to reproduce the bug

Steps to reproduce the behavior:

ususa step of using Flipview,it is ok
i used x:load in the datatemplate of item,it work exceptly(not sure)

Expected behavior

Actual behavior

only change in a few items (the front of list)
Screenshots

Version Info

[ ] Xaml Controls Gallery - Downloaded from Store

If so, which version? (1.2.x -- Found on the Settings page of the app.)

[ ] WinUI 3 Controls Gallery - Downloaded from Store

If so, which version? (1.3.x -- Found on the Settings page of the app.)

[x] App built locally from source

winui2,not 3

Additional context

Windows version:

[ ] Insider Build (xxxxx)
[x] May 2021 Update (19043)
[ ] October 2020 Update (19042)
[ ] May 2020 Update (19041)
[ ] November 2019 Update (18363)
[ ] May 2019 Update (18362)
[ ] October 2018 Update (17763)
[ ] April 2018 Update (17134)
[ ] Fall Creators Update (16299)
[ ] Creators Update (15063)
[ ] Anniversary Update (14393)

Device form factor:

[x] Desktop
[ ] Mobile
[ ] Xbox
[ ] Surface Hub
[ ] IoT

Is this is an issue with the FlipView samples or rather an issue with the FlipView control? In the later case, the WinUI repo would be more suitable for that kind of feedback.

@DJDQfff I am closing this for now. Feel free to reopen this if it is a XAML Controls Gallery issue or to open an issue on the WinUI repo as @chingucoding suggested if this is an issue with the FlipView control.


Community

Added Tableau web Data connector for covid-19 quintessential data API.
Verison: 1.0.0

Coverage remained the same at 98.913% when pulling 3dd70b52cf041a688112133df1661ba2d235d939 on PraphulSamavedam:patch-2 into 7469f8533c7bf6a36f68be830acbb119cf403b2a on tableau:master.

Hi @PraphulSamavedam - Thank you for submitting your WDC but the URL submitted points directly to the API. The URL needs to redirect end users to your WDC


fix(child, children): Determine actual target by key

TypeScript seems to leave descriptor undefined, so using they key to determine what to actually get the metadata for. Using typeof instead of checking for existence because empty strings ('') are coerced to false, though that SHOULD never happen.

Thanks for the contribution!


#835 (dzitilesource guessing of tilesUrl ) breaks Rails routing.

After updating to OSD 2.2.1, images / tiles fail to load. Some effort was put into Rails modifications
to get around this with no luck. Reverting #835 to the previous version of OSD fixes the problem.
Works:
options.tilesUrl = url.replace(/([^\/]+)\.(dzi|xml|js)(\?.*|$)/, '$1_files/');

Fails:
options.tilesUrl = url.replace(                     /([^\/]+?)(\.(dzi|xml|js))?\/?(\?.*)?$/, '$1_files/');

Reference:
fixed dzitilesource guessing of tilesUrl #835

Looks like we need to refine that regex further! What's the URL that you're starting with? Any thoughts about how to update the regex so it supports your case as well as the case from #835?
I'm a little confused by the fact that your successful URL doesn't include _files in it... how does that work?

@dephora Looks like there's a potential fix in #1074… Can you give it a try and verify that it addresses your issue?

@iangilman Great, thanks. I will check this out in a few days. Apologies for not looking into it sooner, it was put on my todo list but got buried.

Cool... yes, I'm still curious to know the answers to those questions. It almost seems like your URL structure is beyond what should be expected from a DZI; interesting that the old regex supported it.

@dephora Have you had a chance to check out #1074?

@iangilman Yeah, just did, it works perfectly. Sorry again for the delay!

@dephora Wonderful, thank you!


Snippet improvements

Improve snippet template authoring experience by supporting snippet syntax (new file extension?). Currently get red squiggles on placeholders e.g. '${1:availabilitySet}'
Move test input file to the same directory as snippet template to simplify contribution steps. Currently lives in ./src/Bicep.LangServer.IntegrationTests/Completions/SnippetTemplates
Do not require diagnostics.json for tests

Improve snippet template authoring experience by supporting snippet syntax (new file extension?). Currently get red squiggles on placeholders e.g. '${1:availabilitySet}'

I like this idea. We could tweak the parser and the semantic model to support the placeholder syntax. A different file extension would make it easy for us to turn on that capability just for snippet files.

Move test input file to the same directory as snippet template to simplify contribution steps. Currently lives in ./src/Bicep.LangServer.IntegrationTests/Completions/SnippetTemplates

I like the idea of keeping them together, but we shouldn't package files into the VSIX that aren't needed for it to function. One option would be to copy the snippet files from the shared place into the VSIX during build.

Do not require diagnostics.json for tests

Yeah, it does feel redundant for sure.


Some comments in C header files are not C-style

To be able to compile my Vulkan project with GCC flag -std=c90, all comments in the vulkan header files must conform to using C-style comments.  Comments that
// look like this
will not compile.  However, if they
/* look like this */
it will compile perfectly.  My use case is probably rare, but compiling with clean C90 makes me feel warm inside.

@grim210, outside of the loader, we don't have a bunch of these files.  Can you enumerate the ones that are giving you trouble?  Our coding standards enforce //-style comments universally, except in copyright notices or file headers and currently make no exceptions for the older C standards.

Some of the files aren't owned by us, the come from Khronos.  The others, as @mark-lunarg points out, is based on our coding standard.
Looking at the top-level CMakeLists.txt file, -std=c99 should be automatically set.  Are you not using CMake?

As I mentioned in the PR, I'm closing this issue for now, at least until the main Vulkan working group updates their header files.


Scrolling will be immediately cancelled when scrolling is triggered by keyDown events

I understand that by default, keyDown events will cancel scrolls, and that that behavior is cancellable by setting ignoreCancelEvents to true.
However, a bug we're running into right now is that when scrolling is triggered by a React keyDown handler, the scrolling is immediately cancelled. This is errorneous behavior; the scroll cancellation should only be able to kick in after the scroll event is triggered. In other words, there is no way to synchronously trigger scrolls from a keyDown event handler without using ignoreCancelEvents.
The reason why the scroll immediately gets cancelled is that the event listeners on document are added after the element tree is mounted to the DOM, i.e. after ReactDOM.render is called.
https://github.com/fisshy/react-scroll/blob/886a792b10e4c72731c3652c5922583e165b4798/modules/mixins/passive-event-listeners.js#L19
When document event listeners are added after ReactDOM.render is called, then those event listeners will fire after react's document event listeners fire.
(Demonstration of document.addEventListener behavior after ReactDOM render)
So what happens is

a key is pressed
React handles the keyDown event
ReactScroll.scroller.scrollTo is called, initializing the scrolling animation
ReactScroll handles the keyDown event, and cancels the scroll

I think a proper implementation of scroll cancelling would bind the event listeners on document only once,  during module initialization. This ensures that its event handlers on document are bound before ReactDOM's. This solution would also solve the memory leak mentioned in this issue: #268.
A workaround is to set ignoreCancelEvents to true.

So, removing events after scroll would also work right?

I haven't published any new version, but this one works for me.
check out the latest commit.
https://github.com/fisshy/react-scroll/commit/eda9f2b9dac503b6741fcbf0619a12c5f74517c1
npm run examples

Tried it out the new keyDown example, still partially broken. If you keyDown with a particular cadence, then only every other scroll will work. The others will be cancelled.
I believe the crux of the issue is that we're registering event handlers on document after ReactDOM.render is called. We should register a "mother" event handler on document once during module initialization time, and then on each call to animateTopScroll, we should register (and subsequently deregister) child event handlers onto that "mother" event handler. This way we can ensure that the cancellation will occur strictly before render is finished.

Interesting. How would the "mother event" tell the scroller to stop scroll?
I'm not sure if "key down" after a "key down" is broken because it's part of the cancellation events.
Another approach could be to specify what cancel events you want, ignoring keydown would solve it.

I realized the __cancel variable is a top level variable anyways.
https://github.com/fisshy/react-scroll/blob/eda9f2b9dac503b6741fcbf0619a12c5f74517c1/modules/mixins/animate-scroll.js#L46
So the "mother" event handler doesn't need to be as complicated as I imagined it would need to me. Something like:
let __cancel = false;
document.addEventListener('keydown', () => {
  __cancel = true;
});

So instead of registering event listeners every call to animateTopScroll, we only register one event handler once, in the beginning when the module is loaded.

Ah, so we can keep the events also. No need to add/remove all the time.
Feel free to make a PR or I could solve it later tonight :)

@fisshy lemme give it a go :)


Add UI event support for Brain class

Now that we have a UI event system, we can start work on implementing it in places where we want extra interop between figures. This PR tackles the Brain object.
UI Events implemented:

[x] TimeChange (scroll through time, playback)
[x] ColormapRange (when you adjust the colormap with the sliders and buttons)
[x] VectexSelect (when you click on a source point)
[ ] CameraMove (when you move the camera) (difficult to implement, likely YAGNI)

The idea is to completely replace the Brain.callbacks dictionary,  mne/viz/_brain/callback.py, and mne.viz._brain/_LInkViewer with the UI events system.
Along the way, two bugs are fixed:

Glitching behavior when using the mouse to scroll backwards through time when using time interpolation. There was an incorrect int(time) conversion where it should have remained a float.
The sliders didn't work on data with only very small numbers. For example, the plain MNE source estimate has values around 1E-10 and the sliders would effectively have a range of [0, 0]. This PR adds a scaling factor for the sliders to make them useful in these cases.

The event-handing codepath for updating something about the plot goes as follows:

Public method (e.g. Brain.set_time) publishes a UI event (TimeChange)
GUI element has a QT or matplotlib callback that publishes a UI event (TimeChange), possibly by calling the public method, but could also  publish the UI event directly if the public function has too much overhead.
Brain subscribes to its own UI events and calls a private function when receiving it (Brain._on_time_change)
Prive function (Brain._on_time_change) updates the plot and GUI elements to match the new value.

I could use some help with the failing test. It concerns a QT window not being cleaned up properly, but this is only the case when using the PySide6 backend. I have trouble replicating this on my machine, even with a fresh PySide6 environment. Anyone got any tips for me?

Based on https://github.com/mne-tools/mne-python/actions/runs/5938727942/job/16103807944?pr=11891 for example I'm guessing you have the wrong pytest fixture(s) in use for your new test, but I'll take a look...

What's this error about?
mne/tests/test_import_nesting.py:223: in test_import_nesting_hierarchy
    raise AssertionError(f"{n} nesting error{_pl(n)}:\n" + "\n".join(all_errors))
E   AssertionError: 4 nesting errors:
E   Line 186:  ("mne/viz/ui_events.py", "    from . import Brain", "non-explicit relative import"),
E   Line 81:   ("mne/viz/_brain/_brain.py", "from .. import ui_events", "non-explicit relative import"),
E   Line 8:    ("mne/viz/_brain/_linkviewer.py", "from .. import ui_events", "non-explicit relative import"),
E   Line 14:   ("mne/viz/backends/_abstract.py", "from .. import ui_events", "non-explicit relative import"),

These are new checks to help reduce the likelihood of a circular import error, see for example:
https://github.com/mne-tools/mne-python/blob/9627f43bb2c03233827046bc06acdab0968d6610/mne/tests/test_import_nesting.py#L17-L21
But your errors come mostly from the form of the imports in general rather than our top-level scheme:

E   Line 186:  ("mne/viz/ui_events.py", "    from . import Brain", "non-explicit relative import"),

This one is legitimate. This should be:
from ._brain import Brain

And should arguably be nested since you later import ui_events stuff inside Brain, risking a circular import problem between the two viz submodules. (We only have a defined import hierarchy for top-level modules, but it makes sense to me that ui_events should nest any imports from elsewhere else in viz except probably utils.)

E   Line 81:   ("mne/viz/_brain/_brain.py", "from .. import ui_events", "non-explicit relative import"),

This one is arguably something that we should allow, but it's hard to disambiguate the submodule import from a non-explicit import. Can you use from ..ui_events import ... instead? If it's a pain then I can add an exception to the checker.

The docs fail because the cleanup of the figures from the event system is not happening properly. This is probably because of close_event not firing in non-interactive settings (related to https://github.com/matplotlib/matplotlib/issues/18609?).

So this:
cell: <cell at 0x7f0884149e40: Brain object at 0x7f08c54914e0> (<mne.viz._brain._brain.Brain object at 0x7f08c54914e0>)

is a vague reference to the __closure__ of some function, typically ones like this:
https://github.com/mne-tools/mne-python/blob/5ef4f01ae5980f63e2bc2d0133e7977a3cea2d7a/mne/viz/_brain/_brain.py#L942-L953
The __closure__ of update_single_lut_value will include self because self.update_lut is called within the function. Then you wrap that in partial, and set it as a callback, it creates a reference cycle that the Python garbage collector is not smart enough to resolve (maybe due to the use of Qt somehow, not sure). That's why you see stuff like this in Brain already:
https://github.com/mne-tools/mne-python/blob/9627f43bb2c03233827046bc06acdab0968d6610/mne/viz/_brain/_brain.py#L1005-L1012
The weakself = weakref.ref(self) before the function def creates a WeakRef object, which won't increase self's reference counter. Then in the def line where we do:
def thing(..., weakself=weakself)

we create a new function whose kwarg value is this weakref. Hence in its __closure__ it doesn't need the self object at all, just the WeakRef instance, breaking the reference cycle. Then inside we try to instantiate self = weakself() and if it's dead we short-circuit exit. And it's safe to use thing as a callback because it is decoupled from self from a reference-counting / cycle standpoint.
I'll continue sorting this out and push a commit shortly...

... we create a new function whose kwarg value is this weakref ...

is there any way to hide this complexity from the developer (like with a decorator or something)? Seems like it will come up repeatedly over time, is hard enough to understand/debug that lots of comments are needed, and it would be nice to do those gymnastics and write those comments in exactly one place. (I can try to do it, if you confirm that it might actually work --- my gut instinct is that it won't work but I don't  understand this stuff as well as you do)

is there any way to hide this complexity from the developer (like with a decorator or something)?

Pushing a commit first to hopefully fix the errors here. I'll look into a decorator next, it might be possible...

 Thanks for the explanation.

CameraMove (when you move the camera) (difficult to implement, likely YAGNI)

Actually I think for comparing views of two conditions it's entirely possible someone would want to sync a single view to both brains. This is the default behavior of vedo plotting for example and I've used it before. But given we have multiple view support I think we can wait until someone is motivated, especially since you have to choose which view(s) to link in a multi-view scenario. (Maybe this is what you mean by it being difficult!)
Good to go from your end @wmvanvliet ? If so I'll try it out in the example and review etc.

For the linking of camera's, here are my thoughts about it:
While it is certainly something you may want to do in certain cases, it is also something you may not want to do. Calling link(brain1, brain2) will link all UI events, including the camera. Excluding the camera is in the current version of link a pain, because you would need to specify a custom set of UI events to link. Perhaps the function signature should be changed to link(fig1, fig2, include_events=None, exclude_events=None). So one could do link(brain1, brain2, exclude_events="camera_move").
There's a performance consideration. The straightforward implementation of CameraMove is to call show_view(...). However, that function is slightly expensive due to some matrix transformations being performed. Camera movement might stutter if we implement it like this. The current _LinkViewer class solves this cleverly by assigning the same Camera object to both figures, making it super efficient. However, I don't see how that could be implemented through UI events. Perhaps a good solution is to have the CameraMove event take a pyvista Camera object as parameter and the implementation just copies over the parameters to the camera in the new figure. That would likely be efficient enough, but it breaks the semantics of UI events a little, in which I try to maintain high-level semantics, rather than such a low-level, implementation-specific object. WDYT?

However, that function is slightly expensive due to some matrix transformations being performed.

I'm surprised by this. I'd expect most to be 4x4 and very fast to compute or combine, and VTK should do a lot of it in c++ or in the GPU. Can you give an example bit if code that shows the slowdown? But in the end even if it's a bit slow during interactive rotation it's perhaps not necessarily a deal breaker.

This is ready for review now!

I haven’t benchmarked show_view yet, I’ll give it a try. But it feels inefficient seeing how many events camera movement will spawn

I've looked into building a CameraMove event. In principle doable and it does seem performant. Sorry for ever doubting it :)
However, I've run into a problem: if I get the camera parameters from brain.get_view() and assign them back into the proper parameters of brain.show_view(), the camera angle has changed. Same for going one level deeper with brain._renderer.get_camera() and brain._renderer.set_camera(). It seems that whatever the set_camera() is doing is not lining up with what get_camera() returns.

So for this PR, I'm going to leave it alone I think.

Works beautifully @wmvanvliet, in it goes!


can't decompress data; zlib not available make

Received the following:
ast 10 log lines:
  File "/private/var/folders/pp/8cx2m9p92hjdk1cmg6z49znw0000gn/T/python-build.20190525111851.13029/Python-3.7.2/Lib/ensurepip/__main__.py", line 5, in <module>
    sys.exit(ensurepip._main())
  File "/private/var/folders/pp/8cx2m9p92hjdk1cmg6z49znw0000gn/T/python-build.20190525111851.13029/Python-3.7.2/Lib/ensurepip/__init__.py", line 204, in _main
    default_pip=args.default_pip,
  File "/private/var/folders/pp/8cx2m9p92hjdk1cmg6z49znw0000gn/T/python-build.20190525111851.13029/Python-3.7.2/Lib/ensurepip/__init__.py", line 117, in _bootstrap
    return _run_pip(args + [p[0] for p in _PROJECTS], additional_paths)
  File "/private/var/folders/pp/8cx2m9p92hjdk1cmg6z49znw0000gn/T/python-build.20190525111851.13029/Python-3.7.2/Lib/ensurepip/__init__.py", line 27, in _run_pip
    import pip._internal
zipimport.ZipImportError: can't decompress data; zlib not available
make: *** [install] Error 1
 !  ~ 

I do have zlib installed via MacPorts. A bit rusty on how to make this visible. Also, can it be detected automatically?

For Macports:
set -xg LDFLAGS '-L /opt/local/lib'
set -xg CPPFLAGS '-I /opt/local/include'
set -xg PKG_CONFIG /opt/local/lib/pkgconfig

Hi!
asdf-python is simply a wrapper around python-build so the issue should most likely be open there.
I am happy to add something to the README if it helps though.
I will close for now, please comment if you think this should be re-opened.
Thanks!

@danhper It don't use Python so often, so had to google around. I guess the issue (with building) will already be familiar to regular Python users.
This ticket should be index now, will appear in search results for others who need guidance.


Update key-vault-certs.md

CLI example Typos
2 locations, added a period for $secretid -> $secret.id

@S-AA-RON : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@greg-lindsay
Can you review this PR?
IMPORTANT: When this content is ready to merge, you must add #sign-off in a comment or the approval may get overlooked.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

confirmed existing script works as is


Request: Add FPS & TPS graphs from Alt + F3 debug menu

If possible, different versions that don't contain the text (e.g. "30/60 FPS", "X ms min/avg/max") with scaling as an option.

Interesting idea. I could use the icon system to add this. To make it look good I'm take a bit of work from the profile author (scaling, theming)

Added in v4 betas (still on discord server rn, but first mr/cf release is very soon)

To be more specific, rn it's just shows the graphs in general, it's not an icon, and can't be customized unless you have another mod customizing it.
So after v4 is out, I'll probably re-title the issue instead of closing it

Done


Add publishing warning when CYA and confirmation pages are not in a form

Trello

good stuff. thanks for putting in the acceptance tests.
can we add a more descriptive PR message please and just a screen grab of what it looks like

i think we can dry up the views a little bit. a single variable that holds the warning message and then just checking if it is present? before showing the warning div. chat about it tomorrow


Allow authorship comments

This is a proposal to allow Drake programmers who would like to do so to sign their significant contributions, so that their names appear in the source code and Doxygen. Note that there is already a Drake Credits page and of course git remembers everything, so this is entirely optional and not usually needed.
Comments on this proposal are welcome, and sign-on from other platform reviewers is required.

This change is

This seems broadly reasonable to me.  I can't say I really approve of the spirit of it, but if it is customary in the community of our major potential contributors then it will gain us contributors and the material benefits will firmly outweigh my stodgy qualms.

I do hope it ends up being used sparingly, and that platform reviewers are not obliged to become arbiters of Significant Authorship -- I've been down that road as a Wikipedia editor and it is not pleasant.  But if that happens I trust we will reconsider the policy.

Reviewed 1 of 1 files at r1.
Review status: all discussions resolved, LGTM missing from assignee sammy-tri, LGTM missing from assignee jwnimmer-tri, LGTM missing from assignee soonho-tri, LGTM missing from assignee seancurtis-tri, LGTM missing from assignee ericcousineau-tri, LGTM missing from assignee russtedrake, platform LGTM from [ggould-tri]

cppguide.html, line 5286 at r1 (raw file):

and you should definitely add yourself to that list. In
addition, git maintains a history of all code modifications,
and git blame can be used to find out who did

FYI, git annotate is an equivalent, more polite phrasing of that command.

cppguide.html, line 5293 at r1 (raw file):

a major co-author, you can sign your beautiful creation
with a Doxygen-formatted comment. Then your name
will appear in the

FYI trailing whitespace (here and on about a dozen random lines in the next two paragraphs).

Comments from Reviewable

What happens to authorship if others edit the component (possibly in significant ways) in the future?

Generally the original author would remain and additional authors would add themselves, possibly adding a per-author clarification, like "provided the original implementation" to the first author's name, or deleting the first author after a complete rewrite.

I would rather receive their contributions and hold my nose at the author tag, than not have their contributions at all.

Although that might be an issue, I don't actually know of anyone refusing to contribute unless they can sign. My motivation is less tangible -- to let people express their pride by signing their work. Not everyone wants to do that but some people do (according my statistically insignificant surveying) so I want to see if we can allow them that avenue of expression.

I personally would also appreciate the ease of looking to see whom I should
query about a piece of functionality without having to use git blame.

Evan Drumwright
Senior Research Scientist
http://positronicslab.github.io
Toyota Research Institute
Palo Alto, CA
On Tue, Jul 10, 2018 at 8:54 AM Michael Sherman<EMAIL_ADDRESS>wrote:

I would rather receive their contributions and hold my nose at the author
tag, than not have their contributions at all.
Although that might be an issue, I don't actually know of anyone
refusing to contribute unless they can sign. My motivation is less tangible
-- to let people express their pride by signing their work. Not everyone
wants to do that but some people do (according my statistically
insignificant surveying) so I want to see if we can allow them that avenue
of expression.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/RobotLocomotion/styleguide/pull/11#issuecomment-403874090,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACHwz6N2jweBEGN3B4ajT7ENmVBgsXNQks5uFM5OgaJpZM4VIwvr
.

--
Confidential or protected information may be contained in this email
and/or attachment. Unless otherwise marked, all TRI email communications
are considered "PROTECTED" and should not be shared or distributed. Thank
you.

I personally view "@author" as about ownership- who has taken
responsibility for this piece of code?

Evan Drumwright
Senior Research Scientist
http://positronicslab.github.io
Toyota Research Institute
Palo Alto, CA
On Tue, Jul 10, 2018 at 9:19 AM Jeremy Nimmer<EMAIL_ADDRESS>wrote:

@jwnimmer-tri commented on this pull request.
Absolutely true. We should be clear that this proposal (and the @author
tag) is about pride / credit, not about where to direct questions. The
qualified / best people to respond to questions about some code is much
wider than @author, and sometimes will not even include the named author.
(It might not even be in the git annotate output -- in some cases, the
feature reviewer who proposed a change would be the best one to ask.)
Reviewable
https://reviewable.io/reviews/robotlocomotion/styleguide/11#-:-LH3yC8lC5usC-OFjXES:b-t0nm2g
status: 1 unresolved discussion, LGTM missing from assignee seancurtis-tri,
LGTM missing from assignee ericcousineau-tri, LGTM missing from assignee
russtedrake, platform LGTM from [ggould-tri, jwnimmer-tri, sammy-tri,
soonho-tri]
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/RobotLocomotion/styleguide/pull/11#pullrequestreview-135903481,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACHwzwy8yf2bD2dZ_MHSYKb7lyrg6ESpks5uFNP0gaJpZM4VIwvr
.

--
Confidential or protected information may be contained in this email
and/or attachment. Unless otherwise marked, all TRI email communications
are considered "PROTECTED" and should not be shared or distributed. Thank
you.

If we want to add an OWNERS file to our tree (and, e.g., tie it into feature review) that's fine by me too, but that's not what @author is.

(I see now that GitHub has their own CODEOWNERS file, that would be another option to publish ownership.)

@author kills two birds (ownership and taking pride in one's work) with one
stone, imo.

Evan Drumwright
Senior Research Scientist
http://positronicslab.github.io
Toyota Research Institute
Palo Alto, CA
On Tue, Jul 10, 2018 at 9:46 AM Jeremy Nimmer<EMAIL_ADDRESS>wrote:

(I see now that GitHub has their own CODEOWNERS
https://help.github.com/articles/about-codeowners/ file, that would be
another option to publish ownership.)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/RobotLocomotion/styleguide/pull/11#issuecomment-403890528,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACHwz2ISOMMCs4rmasvlfvPhYcJ40uxdks5uFNp6gaJpZM4VIwvr
.

--
Confidential or protected information may be contained in this email
and/or attachment. Unless otherwise marked, all TRI email communications
are considered "PROTECTED" and should not be shared or distributed. Thank
you.

I don't think @author kills any birds. It sends stones flying, but the birds are sitting in the tree, mocking us.  :)
If we want @author to have SWE utility, it becomes something that must be reviewed and asserted correct. And if it becomes owner, it supplants the role of providing credit. After all, if I leave TRI, do I lose the credit I once received for the work I did just because someone else assumes my responsibilities?
Like many voices, I wouldn't apply my name as an author in files. I'm content with being in the contributor list. If I saw an @author in drake, I would ignore it. It would be a soft warm fuzzy for someone but I would not consider it to be an actionable piece of information. And I think it should be clearly documented as such.
I do like the idea of ownership and documenting that so other developers have an additional resource in determining who they should contact. I like it happening in one centralized place so that one only has to look once -- even though that is, by no means, a silver bullet.
Conclusion: I don't think that @author can provide any meaningful development information and should not be hijacked to attempt to do so. But I won't fight against allowing people who value seeing their name in the code do so. But the meaning of an @author tag needs to be clearly delineated.

I'll have to side with the reservations; can I ask who concretely expressed interest in adding @author to the files?
Is there someone in particular, for a particular reason?
If it's a good one that can't be satisfied easily by some other mechanism, then I'm all for it; however, if there's another way, such as more explicit acknowledgements or accolades or whatever, then I'd prefer that rather than adding a new convention and review item.
Perhaps we can also expand on the existing Sphinx documentation so that people can more explicitly state their contributions, explicit ownership, etc.

As an aside, there would be a fair case to be made that -- while the platform review team should review this PR with an eye toward us being able to enforce the rule -- the review of the policy proposal itself should be open to all drake developers, not platform reviewers.

can I ask who concretely expressed interest in adding @author to the files?

No one asked or complained -- I had this idea thinking about how to support career growth for early-career Drake programmer/researchers. I expect that some academic and early-career contributors will want to sign their work as a way to build reputation, and I'm proposing that we allow that.  Asking around, there are current (paid) Drake contributors who do want to add their names, but they weren't boycotting before. Alternatives would be to disallow that altogether, or defer a decision until it comes up.

For something that is rare and/or not immediately needed, I'd also prefer if this PR could be as short as possible.  Maybe one paragraph of rationale, and then 1-2 codeblock examples that show the proper syntax.  (GSG tends to give rules by example, rather than by prose, and I do like that as a philosophy.)

My half cent on the subject. I see that pretty much that many people added to this discussions from a variety of angles so I won't add much to this. I value in all of the points here raised and I'll :lgtm: this proposal since I believe we should at least give people the option to sign their work if they wanted to.

Looks like this when formatted:

Here is what the authorship section looks like now:

The Authorship section looks like this now:


Yarn requires version to install dependencies

Fixes #28
Yarn requires version property to install dependencies

@askvortsov1 review it


Publishing to pub?

Are you interested in publishing this to pub.dartlang.org? I'd like to use the client in another project and it's just easier if this package has been published. I'm happy to help with releases.

All set. It's published here: https://pub.dartlang.org/packages/socketcluster_client


Notification delivery priority

The notifications delivered by Alarmo are not considered high priority on my phone. I often only see them when I unlock my phone.
For notifications in my own automations and scripts, I use:
service: notify.mobile_app_geoff_s_s21 data:   data:     ttl: 0     priority: high     push:       sound:         name: default         critical: 1         volume: 1   message: "Alarm triggered by {{ state_attr((state_attr('alarm_control_panel.alarmo','open_sensors') | list)[0],'friendly_name') }}"   title: Home Assistent
Which seems to gaurentee immediate delivery.
Whilst I can add the above code to the scrips called by Alarmo, it would be nice if Alarmo could deliver the messages with higher priority natively.

+1

It is already possible to create a notification from Alarmo with extra service data parameters by switching to YAML mode in the editor.
As you can read here, it is device (iOS, Android etc.) dependent how the service data must be formatted.
Since there is no generic format, I don't see a possibility to add native support for this (unless I ask the user to specify their device type in the form, but I don't see this very elegant).

Hi NielsI apologise. I hadn't seen the YAML button. I'll use that.Thank youGet Outlook for Android


_cut_sequence issue

Hi,
I was testing the cut sequence length in the recipe but ran into the following issue:
starting training
Traceback (most recent call last):
File "nabu/scripts/prepare_train.py", line 365, in
main(FLAGS.expdir, FLAGS.recipe, FLAGS.mode, FLAGS.computing)
File "nabu/scripts/prepare_train.py", line 90, in main
expdir=expdir)
File "/home/zichengr/Nabu_simple/nabu/scripts/train.py", line 85, in train
tr.train(testing)
File "/home/zichengr/Nabu_simple/nabu/neuralnetworks/trainers/trainer.py", line 603, in train
outputs = self._create_graph()
File "/home/zichengr/Nabu_simple/nabu/neuralnetworks/trainers/trainer.py", line 126, in _create_graph
outputs['local_steps']) = self._data(chief_ps)
File "/home/zichengr/Nabu_simple/nabu/neuralnetworks/trainers/trainer.py", line 376, in _data
max_length)
File "/home/zichengr/Nabu_simple/nabu/neuralnetworks/trainers/trainer.py", line 923, in _cut_sequence
numcuts = tf.to_int32(tf.ceil(tf.shape(sequence)[1]/cut_length))
File "/home/zichengr/anaconda3/envs/py27/lib/python2.7/site-packages/tensorflow/python/ops/gen_math_ops.py", line 1582, in ceil
"Ceil", x=x, name=name)
File "/home/zichengr/anaconda3/envs/py27/lib/python2.7/site-packages/tensorflow/python/framework/op_def_library.py", line 609, in _apply_op_helper
param_name=input_name)
File "/home/zichengr/anaconda3/envs/py27/lib/python2.7/site-packages/tensorflow/python/framework/op_def_library.py", line 60, in _SatisfiesTypeConstraint
", ".join(dtypes.as_dtype(x).name for x in allowed_list)))
TypeError: Value passed to parameter 'x' has DataType int32 not in list of allowed values: bfloat16, float16, float32, float64
Has it occurred to anyone?
Thanks

That functionality is quite untested, so I can imagine if it is not perfect. For what do you need it? I will be taking a new look at the code in the coming days and I will probably trim it down and try to make it simpler

Hi Vincent,
I just wanted to get a better understanding of your code. So I just tried different settings from the recipe. I actually fixed the issue raised from _cut_sequence function and now it worked fine for me.
Thanks

Just wanted you to know: there was a bug in the validation that caused the validation performance to average over all steps instead of replacing the performance wit the new validation performance. This gave the impression that the model converged very slowly. It has been fixed now and TIMIT training only takes a couple of hours now

Thanks for letting me know, Vincent!


Fix outbound transparent HTTP/2 and DNS issues

Fixes issues with propagating the outbound transparent flag.  Would like @SolidWallOfCode to review. This fix removes the ability to override outbound transparent on a per transaction basis, but I fail to see how that would have ever been useful.
Also adds a check to avoid exercising the DNS lookup if outbound transparent is enabled.
This closes #8587

Will create a new PR based on @SolidWallOfCode's comments.


Update index.md

Make my game

Why:
Closes:

What's being changed (if available, include any codepets, screenshots, or gifs):

Check off the following:

[x] I have reviewed my changes in staging, available via the View deployment link in this PR's timeline.

For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.

[x] For content changes, I have completed the self-review checklist.

Good website

G

This is your best website -caiden


ModuleNotFound:Util

When trying to compile, this is a constant error. Any ideas?

Hi @howtotalktogirlsatparties,
You need to be in the root folder of the GitHub repo to be able to import it, try this and retry the compile.

This actually solved the problem @Montana, thanks!


Research and Design for Notification

Describe the task
Current Design: https://www.figma.com/file/PzOY8RyQnVXnjZJdSv2AqQ/Wireframing_Figma?node-id=2765%3A3314
The CIF users want to alert other user groups on certain action items in their process. We need to design visual components and workflows for such Notification system. There are 3 aspects to consider:

In-App vs Email
Amendment-Specific vs Project-Level (or even Program-Level)
User Management (Ops Team / Tech Team / Director / Proponent)

Acceptance Criteria

[x] Investigate user needs and expectations from the CIF team
[x] Create static mock-ups for further discussion/validation
[x] Create interactive prototypes to visualize the envisioned workflows
[x] Validate and finalize design with CIF and the devs
[x] Write up associated user story tickets with design/prototype links for dev refinement and implementation

Additional context

Add any other context about the task here.
Or here

Hi @LindsayMacfarlane - This ticket can be closed with #982 created with link to the updated design included.

Thank you so much @nanyangpro! I really appreciate the simplicity of this first iteration.


Feature: remove idle connections from pool

Currently connections in the connection pools (spool and dpool) inside a mux will live forever.
It would be nice if we had an option, such as ConnIdleDuration or a better naming, to clean connections that are idle for a long time to reduce memory usage.

I am interested in working on this issue.

@rueian
Does need option to min size of connection pool? making a new connection is expensive. If all connections is closed, can be harmful to latency sensitive apps. current pool only support cap size.

@rueian Does need option to min size of connection pool? making a new connection is expensive. If all connections is closed, can be harmful to latency sensitive apps. current pool only support cap size.

Yes, there should be an option for that.


fix: set default host to undefined

Fixes #3347

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 3 (0.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 21.401%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

bin/www.ts
0
1
0.0%

app.ts
0
2
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
3683

Relevant Lines:
18320

💛  - Coveralls


Use ReplicationFailedException instead of OpensearchException in Repl…

…icationTarget
Signed-off-by: Ayush Kataria<EMAIL_ADDRESS>Description
Uses a narrower ReplicationFailedException instead of OpensearchException in ReplicationTarget and ReplicationListener
Issues Resolved
[List any issues this PR will resolve]

#4291

Check List

[ ] New functionality includes testing.

[ ] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[x] Commits are signed per the DCO using --signoff
[x] Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #4725 (c9bfc98) into main (9f415eb) will increase coverage by 0.17%.
The diff coverage is 92.30%.

:exclamation: Current head c9bfc98 differs from pull request most recent head c3e49c0. Consider uploading reports for the commit c3e49c0 to get more accurate results

@@             Coverage Diff              @@
##               main    #4725      +/-   ##
============================================
+ Coverage     70.59%   70.77%   +0.17%
- Complexity    57514    57599      +85
============================================
  Files          4660     4660
  Lines        276466   276473       +7
  Branches      40285    40285
============================================
+ Hits         195170   195660     +490
+ Misses        65060    64479     -581
- Partials      16236    16334      +98

Impacted Files
Coverage Δ

...arch/indices/recovery/RecoveryFailedException.java
100.00% <ø> (ø)

.../opensearch/indices/recovery/RecoveryListener.java
100.00% <ø> (ø)

...rg/opensearch/indices/recovery/RecoveryTarget.java
74.19% <ø> (+1.29%)
:arrow_up:

...ices/replication/common/ReplicationCollection.java
74.07% <0.00%> (-3.71%)
:arrow_down:

...org/opensearch/index/shard/IndexShardTestCase.java
93.95% <ø> (ø)

.../indices/replication/SegmentReplicationTarget.java
91.17% <100.00%> (-0.09%)
:arrow_down:

...s/replication/SegmentReplicationTargetService.java
62.85% <100.00%> (+0.72%)
:arrow_up:

...replication/common/ReplicationFailedException.java
100.00% <100.00%> (+87.50%)
:arrow_up:

.../indices/replication/common/ReplicationTarget.java
80.00% <100.00%> (ø)

...cluster/coordination/PendingClusterStateStats.java
20.00% <0.00%> (-48.00%)
:arrow_down:

... and 499 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


getBoundingBox latitude off?

I was computing the midpoint of my image from the getBoundingBox() and noticed the latitude was always a bit north of my actual image. This may be only specific to my images, but it seems that this is what caused it:
the getOrigin() function gets me the top left (north-west) coordinate of the image.  The line
var y2 = y1 + resolution[1] * this.getHeight();
would then always be north of the already north-most coordinate. This is what worked for me: changing the + sign in that code snippet to a negative sign
var y2 = y1 - resolution[1] * this.getHeight();
This is would mean that y2 is now the southern border of the image. This code is from the getBoundingBox() function

Hi @matthesrieke and @bsuwal!
Thank you for submitting this issue!
Could you please provide an example image where this happens?


No notification on arch linux

I have installed pb-for-desktop on my arch linux (manjaro edition Linux ******* 4.4.41-1-MANJARO #1 SMP PREEMPT Mon Jan 9 09:33:22 UTC 2017 x86_64 GNU/Linux, Desktop: Gnome 3.22.2 )
It all seems great and stable except one major issue. I am unable to receive notification at all. I tried sending a test mirror notification from my device multiple times but have not received a single lib-notify event from your app.

@gpreet1992 Thanks for the report. Can you please re-test the issue with the additional pacman and/or AppImage package formats in 2e0a2b2ae433371c32fd565b12cda517048c2c6b ?

It's also not working for me on macOS Sierra.

@andrebeat Thanks for the report - can you please be a bit more specific? What should have been the result, and what happened? Does ist only apply to mirrored notifications, the clipboard, or subscriptions (like ifttt)?

@sidneys Sorry for providing no information. I only use SMS notifications and mirrored notifications and I don't seem to receive any of those. For example, if I send the pushbullet test notification (in the mobile app) it isn't shown. Sending SMS is working and the SMS view is properly updated.

@andrebeat No problem - but could not reproduce the mirroring error yet.
Can you provide your specs (OS, platform etc.) and application version used?

I was using version 3.3.1 but I also tested previous versions and had the same problem. I now tested the latest version (3.4.0) and the problem still exists. I'm using macOS Sierra 10.12.3. I also have a Pushbullet pro subscription (I'm not sure that's relevant). My mobile phone is running Android 7.0 with the latest version of Pushbullet (although I have no problem receiving notifications when using the Firefox extension for example).
Another thing I noticed is that I get notifications for "direct pushes", i.e. when I receive a message directly through Pushbullet. And they're always replayed whenever I start PB-for-desktop. So it seems that only notification mirroring and SMS notifications are not working.

@andrebeat
SMS and Mirroring were just tested with an Nougat 7.1 Emulated Devices, and both features worked well, including incoming and outgoing SMS.
However, it required logging into the Android app again using the current Pushbullet account and then activating the SMS Sync and Mirroring options inside the app and also granting the app all required permissions, thus completing the configuration once. Did you try this this approach?
Also, why not join the Dev Chat?

My issue was related to end-to-end encryption. @gpreet1992 Are you using end-to-end encryption? If that's the case try disabling it to see if it solves your problem.

@andrebeat  @gpreet1992
E2E arriving in 7c941bc3849b3e0ce3099f8396cfd2eab515d7df.


Saved projects don't show up in the "Projects" tab in playground

Hi,
saving my project from the NativeScript Playground won't actually preserve the work (even though I am logged in), and the "Projects" tab persists empty.
Thanks for help!

@gagata, could you provide some more details. How are you saving the project? If you use the :cloud: button in the playground, are you getting an unique url in the browser containing the id parameter? If not, are there any javascript errors logged in the console?
Please note that if you use the Ctrl+S or the Preview button it will not persist your changes during page reloads in the browser.


matchExistingElement returning all products in for commerce product

Something is wrong with the elementCriteria for commerce products you've set up - if a Product doesn't exist, it is returning all of the products instead of an empty set, so it keeps just updating the first product. I can't run this feed more than once. It works the first time since there are no products anyway, but after that it just tries to update the same product over and over again even though they all have different SKUs.
The function matchExistingElement in Commerce_ProductFeedMeElementType.php is returning ALL of the products, even though there's no match in sku. This might actually be the problem i was having in #204 - I'm not quite sure about that since I've found this new problem.

This should be fixed in the latest master, and thanks also for the PR.
Additionally, I've removed all variant attributes from being able to be set as a unique identifier - this includes the variant Title. While this would be nice, the Variant Element itself doesn't support this as a criteria, so it simply won't work. If you tried to match against a variant's title, it'd return all variants, which is certainly not what we want.
Please let me know if you continue to have issues!


RadzenEmailValidator can validate invalid email

Describe the bug
RadzenEmailValidator can validate invalid email.  Example page(https://blazor.radzen.com/emailvalidator) validates<EMAIL_ADDRESS>as a valid email. System.Net.Mail.MailAddress.TryParse() (and different google validators) doesn't validate it correctly.
To Reproduce
Steps to reproduce the behavior:
Visit https://blazor.radzen.com/emailvalidator and enter invalid email.
Expected behavior
Entered email should be invalid
Screenshots

Desktop (please complete the following information):
Used google chrome - 108.0.5359.125 (current version in time of creating this issue).

RadzenEmailValidator uses the EmailAddressAttribute provided by .NET. It seems that attribute thinks this address is valid.


Deprecate dependencyAnalysis.dependencies for structure

Resolves #891. Open to suggestions on the name, this felt the most semantically similar

Is this really necessary? Would it also fix the issue if we used @DslMarker? Or is that even possible given that it's Gradle that generates the DSL at runtime from its public types?

I think it is necessary, and don't think DslMarker would help as this is a resolution order in groovy afaik


There is no scroll to top issue

Give a brief about the bug ✍
I would like to work on this issue, pls assign me this
What is the expected behavior? 🤔
assign the issue
Provide step by step information reproduce the bug 📄
will be adding the scroll to top functionality
Select program in which you are contributing
GSSoC24
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINE of this project.

Hey @anshulsoni4! 🙂
It seems like you are not following proper guidelines !! 👀
Read documentation properly !!🙏
If you have any queries reach out to us on Discord🕹 .

Hey @anshulsoni4 !
Thank you for raising an issue 💗
You can self assign the issue by commenting /assign in comment 😀
Make sure you follow CODE OF CONDUCT and CONTRIBUTING GUIDELINES 🚀
Don’t Forget to ⭐ our GameZone🎮
Make sure you join our Discord🕹

Hey @anshulsoni4 ! Thank you so much for your raising the issue💗
It’s all yours, you can come anytime again and make some contributions! 🚀
Alone, we can do little, but together we can do so much! 😇

/assign

@kunjgit hey, can you mention the level also (label)


liquibase ignores @Transient annotation

Environment
Liquibase Version: 3.4.2
Liquibase Integration & Version: spring boot, J2EE
Liquibase Extension(s) & Version:
Database Vendor & Version: postgres 12, H2
Operating System Type & Version: Windows 10
Description
As described in https://docs.oracle.com/javase/7/docs/api/java/beans/Transient.html with @Transient annotation a field in a bean should be ignored in JPA.
I used that annotation on a getter because I need to ignore it in database persistence and also because calculation is not immediate.
Even with @Transient annotation the getter is invoked by org.skife.jdbi.v2.sqlobject.Binder#bind while it should not be invoked.
Steps To Reproduce

Annotate a getter with @Transient annotation (java.beans.Transient)

Actual Behavior
The getter is invoked when it should be ignored
Expected/Desired Behavior
The getter should be ignored
Additional info

The string serialization of java.beans.PropertyDescriptor is java.beans.PropertyDescriptor[name=compoundExtension; values={transient=true}; propertyType=class java.lang.String; readMethod=public java.lang.String com.ekr.pim.data.dto.FileDto.getCompoundExtension()]
The table field of java.beans.PropertyDescriptor contains a key named transient that contains the value
Invoking getValue("transient") you could get a Boolean field that tells if it is transient or if you get null, @Transient annotation is not defined for that field and should be treated as @Transient false.

Hello @qwertyscar, sorry for the late response.
At the moment, liquibase only manages persistence or entity relations with the liquibase-hibernate extension. It seems like you're not using this extension, which means that it's not likely that it's liquibase that is causing this issue.
Would you be able to provide a stack trace in order for us to verify this?
Thank you
Tatiana

Hello @qwertyscar, sorry for the late response. At the moment, liquibase only manages persistence or entity relations with the liquibase-hibernate extension. It seems like you're not using this extension, which means that it's not likely that it's liquibase that is causing this issue. Would you be able to provide a stack trace in order for us to verify this? Thank you Tatiana

At the moment I can't provide the stack trace because I'm not in the project and is developed by the enterprise, I don't remember exactly how it happened.
Sorry for not being helpful.


Building SDL2_Mixer on macos for arm64

So far I managed to build SDL2 into a framework into a universal build for x86_64 and arm64 like this
git clone https://github.com/libsdl-org/SDL
cd SDL
xcodebuild -project "Xcode/SDL/SDL.xcodeproj" -scheme "Framework" build -configuration Release ARCHS="arm64 x86_64" ONLY_ACTIVE_ARCH=NO CONFIGURATION_BUILD_DIR="${HOME}/Library/Frameworks"

Now I tried the following command to build the SDL_Mixer framework
git clone https://github.com/libsdl-org/SDL_mixer
cd SDL_mixer
xcodebuild -project "Xcode/SDL_mixer.xcodeproj" -scheme "Framework" build -configuration Release ARCHS="arm64 x86_64" ONLY_ACTIVE_ARCH=NO -CONFIGURATION_BUILD_DIR="${HOME}/Library/Frameworks"

But I get the following error
Undefined symbols for architecture arm64:
  "_FLAC__stream_decoder_delete", referenced from:
      _FLAC_CreateFromRW in music_flac.o
      _FLAC_Delete in music_flac.o
  "_FLAC__stream_decoder_finish", referenced from:
      _FLAC_CreateFromRW in music_flac.o
      _FLAC_Delete in music_flac.o
  "_FLAC__stream_decoder_flush", referenced from:
      _FLAC_Seek in music_flac.o
      _FLAC_GetSome in music_flac.o
  "_FLAC__stream_decoder_get_state", referenced from:
      _FLAC_Seek in music_flac.o
      _FLAC_GetSome in music_flac.o
  "_FLAC__stream_decoder_get_total_samples", referenced from:
      _FLAC_CreateFromRW in music_flac.o
  "_FLAC__stream_decoder_init_stream", referenced from:
      _FLAC_CreateFromRW in music_flac.o
  "_FLAC__stream_decoder_new", referenced from:
      _FLAC_Load in music_flac.o
      _FLAC_CreateFromRW in music_flac.o
  "_FLAC__stream_decoder_process_single", referenced from:
      _FLAC_GetSome in music_flac.o
  "_FLAC__stream_decoder_process_until_end_of_metadata", referenced from:
      _FLAC_CreateFromRW in music_flac.o
  "_FLAC__stream_decoder_seek_absolute", referenced from:
      _FLAC_Seek in music_flac.o
      _FLAC_GetSome in music_flac.o
  "_FLAC__stream_decoder_set_metadata_respond", referenced from:
      _FLAC_CreateFromRW in music_flac.o
  "_ModPlug_GetLength", referenced from:
      _MODPLUG_Duration in music_modplug.o
  "_ModPlug_GetName", referenced from:
      _MODPLUG_CreateFromRW in music_modplug.o
  "_ModPlug_GetSettings", referenced from:
      _MODPLUG_Open in music_modplug.o
  "_ModPlug_Load", referenced from:
      _MODPLUG_CreateFromRW in music_modplug.o
      _MODPLUG_Load in music_modplug.o
  "_ModPlug_Read", referenced from:
      _MODPLUG_GetSome in music_modplug.o
  "_ModPlug_Seek", referenced from:
      _MODPLUG_Play in music_modplug.o
      _MODPLUG_Seek in music_modplug.o
      _MODPLUG_GetSome in music_modplug.o
  "_ModPlug_SeekOrder", referenced from:
      _MODPLUG_Jump in music_modplug.o
  "_ModPlug_SetMasterVolume", referenced from:
      _MODPLUG_SetVolume in music_modplug.o
  "_ModPlug_SetSettings", referenced from:
      _MODPLUG_Open in music_modplug.o
  "_ModPlug_Unload", referenced from:
      _MODPLUG_Delete in music_modplug.o
  "_mpg123_close", referenced from:
      _MPG123_Delete in music_mpg123.o
  "_mpg123_delete", referenced from:
      _MPG123_Delete in music_mpg123.o
  "_mpg123_exit", referenced from:
      _MPG123_Close in music_mpg123.o
  "_mpg123_format", referenced from:
      _MPG123_CreateFromRW in music_mpg123.o
  "_mpg123_format_none", referenced from:
      _MPG123_CreateFromRW in music_mpg123.o
  "_mpg123_getformat", referenced from:
      _MPG123_CreateFromRW in music_mpg123.o
      _MPG123_GetSome in music_mpg123.o
  "_mpg123_init", referenced from:
      _MPG123_Load in music_mpg123.o
      _MPG123_Open in music_mpg123.o
  "_mpg123_length", referenced from:
      _MPG123_CreateFromRW in music_mpg123.o
  "_mpg123_new", referenced from:
      _MPG123_CreateFromRW in music_mpg123.o
  "_mpg123_open_handle", referenced from:
      _MPG123_CreateFromRW in music_mpg123.o
  "_mpg123_plain_strerror", referenced from:
      _mpg_err in music_mpg123.o
  "_mpg123_rates", referenced from:
      _MPG123_CreateFromRW in music_mpg123.o
  "_mpg123_read", referenced from:
      _MPG123_GetSome in music_mpg123.o
  "_mpg123_replace_reader_handle", referenced from:
      _MPG123_CreateFromRW in music_mpg123.o
  "_mpg123_seek", referenced from:
      _MPG123_Seek in music_mpg123.o
  "_mpg123_strerror", referenced from:
      _mpg_err in music_mpg123.o
  "_mpg123_tell", referenced from:
      _MPG123_Tell in music_mpg123.o
  "_op_free", referenced from:
      _OPUS_Delete in music_opus.o
  "_op_head", referenced from:
      _OPUS_UpdateSection in music_opus.o
  "_op_open_callbacks", referenced from:
      _OPUS_Load in music_opus.o
      _OPUS_CreateFromRW in music_opus.o
  "_op_pcm_seek", referenced from:
      _OPUS_Seek in music_opus.o
      _OPUS_GetSome in music_opus.o
  "_op_pcm_tell", referenced from:
      _OPUS_Tell in music_opus.o
      _OPUS_GetSome in music_opus.o
  "_op_pcm_total", referenced from:
      _OPUS_CreateFromRW in music_opus.o
  "_op_read", referenced from:
      _OPUS_GetSome in music_opus.o
  "_op_seekable", referenced from:
      _OPUS_CreateFromRW in music_opus.o
  "_op_tags", referenced from:
      _OPUS_CreateFromRW in music_opus.o
  "_ov_clear", referenced from:
      _OGG_Delete in music_ogg.o
  "_ov_comment", referenced from:
      _OGG_CreateFromRW in music_ogg.o
  "_ov_info", referenced from:
      _OGG_UpdateSection in music_ogg.o
  "_ov_open_callbacks", referenced from:
      _OGG_Load in music_ogg.o
      _OGG_CreateFromRW in music_ogg.o
  "_ov_pcm_seek", referenced from:
      _OGG_GetSome in music_ogg.o
  "_ov_pcm_tell", referenced from:
      _OGG_GetSome in music_ogg.o
  "_ov_pcm_total", referenced from:
      _OGG_CreateFromRW in music_ogg.o
  "_ov_read", referenced from:
      _OGG_GetSome in music_ogg.o
  "_ov_time_seek", referenced from:
      _OGG_Seek in music_ogg.o
  "_ov_time_tell", referenced from:
      _OGG_Tell in music_ogg.o
  "_ov_time_total", referenced from:
      _OGG_Duration in music_ogg.o
ld: symbol(s) not found for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

** BUILD FAILED **

The following build commands failed:
	Ld /Users/miguel/Library/Developer/Xcode/DerivedData/SDL_mixer-fimvrwbkzwocgmdyzzckfghvaedj/Build/Intermediates.noindex/SDL_mixer.build/Release/Framework.build/Objects-normal/arm64/Binary/SDL2_mixer normal arm64
(1 failure)

How I can fix this issue?

@ellipticaldoor Have you built FLAC/Opus/mpg123/etc. as arm64 frameworks as well? SDL_mixer needs to link dynamically to those in order to support all its decoder formats, and "missing symbols" here indicates that the linker can't find arm64 versions of those frameworks. All the dependency library source code is in the external/ folder of the SDL_mixer source so you don't need to track it down yourself.

This has also been asked on #291.

Latest git version has added arm64 builds to all music decoder frameworks.
Please test.

No response since 1.5 months - Closing as fixed


feat: create InputSelect component

Checklist before requesting a review

[x] Working on iOS
[x] Working on Android
[x] Integration tests added
[x] Visual regressions screenshots are up to date
[ ] Design validated

Thanks for sharing @kimak ! ☺
My feedback:

[ ] Can we please use a 16 x 16 chevron?
[ ] Is it possible to transition into the Focus state once the Default input is tapped. Currently we just trigger the alert with no indication that the InputSelect is in the Focus state.
[ ] Can we please align the caption across all components in the sandbox? Just for consistency? 😇 I believe we use “Description” elsewhere but here we use “error”.

Thanks for sharing @kimak ! ☺ My feedback:

[x]  Can we please use a 16 x 16 chevron?

good catch! Done ✅

[ ]  Is it possible to transition into the Focus state once the Default input is tapped. Currently we just trigger the alert with no indication that the InputSelect is in the Focus state.

Actually, this state will be handled by the parent component to avoid 2 sources of truth.
Then I agree need of focus, it will be done in a later component.

[x]  Can we please align the caption across all components in the sandbox? Just for consistency? 😇 I believe we use “Description” elsewhere but here we use “error”.

🕵 done ^^
Screenshots are up to date so you can review them. Or use generated QR Code

Thanks for sharing @kimak ! ☺ My feedback:

[x]   Can we please use a 16 x 16 chevron?

good catch! Done ✅

[ ]   Is it possible to transition into the Focus state once the Default input is tapped. Currently we just trigger the alert with no indication that the InputSelect is in the Focus state.

Actually, this state will be handled by the parent component to avoid 2 sources of truth. Then I agree need of focus, it will be done in a later component.

[x]   Can we please align the caption across all components in the sandbox? Just for consistency? 😇 I believe we use “Description” elsewhere but here we use “error”.

🕵 done ^^
Screenshots are up to date so you can review them. Or use generated QR Code

@ianrobertlambert I will merge this MR. let me know if you have any feedback regarding my changes

Thanks @kimak !! 👌


Docs feedback - Pull request templates

[Enter feedback here]
Not sure if this is the correct space as it's probably more of a feature request than a docs feedback.
Anyway it would be great to have Branch specific pull request templates but from named branches not to them. The example on this page shows different templates for merging into different branches (template1 for merging to master and template2 for merging to dev). my use case would be merging into master from branches called Bug/##NAME## and feature/##NAME##
I would like to have a different template based on whether the user is merging a bugfix or a new feature as we have different checks based on the type of change.
If this is possible then can the documentation be updated to show this and if not can it be looked at as a potential new feature.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a297d54f-48b3-1b68-e828-15d1559d9b2d
Version Independent ID: fd9dcb35-72f9-f5a9-e0c0-75c3e59ba8d9
Content: Improve pull request descriptions with pull request templates - Azure Repos
Content Source: docs/repos/git/pull-request-templates.md
Product: devops
Technology: devops-code-git
GitHub Login: @vijayma
Microsoft Alias: vijayma

Thanks for the suggestion! The product teams aren’t always watching this repository, so to make sure it gets in front of them for triage, please submit your idea here.


108 auth headers

Fixes #108
Creator

[x] Build relevant tests if any apply
[x] Ensure there are no new warnings
[x] Upload an animated GIF showcasing the solution (if it applies)
[x] Set a relevant reviewer

Reviewer

[ ] Run test and make sure all tests pass
[ ] Review function and form on iOS
[ ] Review function and form on Android
[ ] Review function and form on Web
[ ] Review new test logic

I didn't get a chance to build mocks, hope to get to it tomorrow but this should be working now

@Lepozepo should we wait to merge this until after the Heighliner pr is merged, or can I actually test this fully now?

@conrad-vanl there's no way to test against their server but I was seeing requests being sent out as expected. I think we should wait.

@conrad-vanl this is ready for review, requires 107a on Heighliner to work

Can't seem to get this to work. I pointed the app at the alpha api - https://alpha-api.newspring.cc/graphql which I deployed a bit ago (using this branch https://github.com/NewSpring/Heighliner/pull/343).
Actually, looks like an issue on Heighliner:

@conrad-vanl yeah, I think rock alpha's sendEmail doesn't work because the emails aren't configured there (so it fails at that step). I can patch Heighliner to ignore sendEmail errors (the emails it does send are weird anyway since they weren't working in the original app)

@conrad-vanl are you sure your user isn't already created? I'll add a check for that with a better error

Still having trouble testing this. I try to login - I get no errors - but nothing seems to happen in the UI. Is that expected?
In the heighliner server log - if I use the wrong password -I I see "User not authorized" being logged. So I know I'm using the correct password now. Just nothing happens in app.

After login is successful you should see an authToken in local storage and subsequent requests with the authorization header. I didn’t build any side effects on the UI so redirects and those kinds of things aren’t in this PR

Should any of the forms pre-populate with my info when I navigate back to the tab? I thought I saw some withUser HOCs being used, which made me think they should.

Nope, they’re very bare


ImportError: cannot import name 'PILLOW_VERSION'

I have pulled the image created a container, but got "ImportError: cannot import name 'PILLOW_VERSION' " error when started trainnig a model. I have also cloned the repository and built the image, but the same issue.
I am using Docker version 19.03.5
NVIDIA-SMI 435.21 with GTX 1070 graphic card.
Below is the entire error trace back:
Traceback (most recent call last):
File "/opt/conda/bin/retinanet", line 11, in
load_entry_point('retinanet', 'console_scripts', 'retinanet')()
File "/opt/conda/lib/python3.6/site-packages/pkg_resources/init.py", line 489, in load_entry_point
return get_distribution(dist).load_entry_point(group, name)
File "/opt/conda/lib/python3.6/site-packages/pkg_resources/init.py", line 2843, in load_entry_point
return ep.load()
File "/opt/conda/lib/python3.6/site-packages/pkg_resources/init.py", line 2434, in load
return self.resolve()
File "/opt/conda/lib/python3.6/site-packages/pkg_resources/init.py", line 2440, in resolve
module = import(self.module_name, fromlist=['name'], level=0)
File "/workspace/retinanet/retinanet/main.py", line 10, in
from retinanet import infer, train, utils
File "/workspace/retinanet/retinanet/infer.py", line 13, in
from .model import Model
File "/workspace/retinanet/retinanet/model.py", line 7, in
from . import backbones as backbones_mod
File "/workspace/retinanet/retinanet/backbones/init.py", line 3, in
from .resnet import *
File "/workspace/retinanet/retinanet/backbones/resnet.py", line 1, in
import torchvision
File "/opt/conda/lib/python3.6/site-packages/torchvision/init.py", line 2, in
from torchvision import datasets
File "/opt/conda/lib/python3.6/site-packages/torchvision/datasets/init.py", line 9, in
from .fakedata import FakeData
File "/opt/conda/lib/python3.6/site-packages/torchvision/datasets/fakedata.py", line 3, in
from .. import transforms
File "/opt/conda/lib/python3.6/site-packages/torchvision/transforms/init.py", line 1, in
from .transforms import *
File "/opt/conda/lib/python3.6/site-packages/torchvision/transforms/transforms.py", line 17, in
from . import functional as F
File "/opt/conda/lib/python3.6/site-packages/torchvision/transforms/functional.py", line 5, in
from PIL import Image, ImageOps, ImageEnhance, PILLOW_VERSION
ImportError: cannot import name 'PILLOW_VERSION'

What is your Pytorch container version?

What is your Pytorch container version?

print(torch.version)
1.2.0a0+afb7a16

Sorry I should have said the Nvidia docker container version, not the pytorch version.
What container did you pull using docker pull command?

Sorry I should have said the Nvidia docker container version, not the pytorch version.
What container did you pull using docker pull command?
I pulled 19.09 version from the readme file " docker run --gpus all --rm --ipc=host -it nvcr.io/nvidia/pytorch:19.09-py3"

This command just initializes the container.
Are you inside the container before doing pip install? You can confirm this if you see
root@<some-random-string>:/workspace#

Did you do docker pull nvcr.io/nvidia/pytorch:19.09-py3 before docker run?

This command just initializes the container.
Are you inside the container before doing pip install? You can confirm this if you see
root@<some-random-string>:/workspace#

Did you do docker pull nvcr.io/nvidia/pytorch:19.09-py3 before docker run?

Yes, I am inside the container!

In that case can you try downgrading pillow pip install pillow==6.2.1?

In Pillow 7.0.0:

PILLOW_VERSION has been removed. Use __version__ instead.

https://pillow.readthedocs.io/en/stable/deprecations.html#pillow-version-constant
This has been fixed in torchvision (https://github.com/pytorch/vision/pull/1501) and a new release is due out early next week (https://github.com/pytorch/vision/issues/1712).
Until the new torchvision release is out, the workaround is either to use the master version of torchvision (eg. pip install -U git+https://github.com/pytorch/vision), or Pillow<7 (eg. pip install "pillow<7").

Please do not install torchvision over git.
For now use pip install pillow==6.2.2

Please do not install torchvision over git.
For now use pip install pillow==6.2.2

In Pillow 7.0.0:

PILLOW_VERSION has been removed. Use __version__ instead.

https://pillow.readthedocs.io/en/stable/deprecations.html#pillow-version-constant
This has been fixed in torchvision (pytorch/vision#1501) and a new release is due out early next week (pytorch/vision#1712).
Until the new torchvision release is out, the workaround is ~either to use the master version of torchvision (eg. pip install -U git+https://github.com/pytorch/vision), or~ to use Pillow<7 (eg. pip install "pillow<7").

Yes, that was the problem. Thanks!

Please do not install torchvision over git.
For now use pip install pillow==6.2.2
Closing this now.

Pillow 6.2.2 works fine.
Just inside the container downgrading Pillow:
pip uninstall pillow
pip install pillow=6.2.2
Thanks for your help!

7c4c7c0 removes pillow==6.2.2 as torchvision is updated to 0.6.0a0


[BUG] index it can't refresh automatically for my created

Describe the bug
The parameter of index:"refresh_interval" is to set the default value, the index of the auditlog document count will be refreshed automatically.
But the index that I created is not refreshed automatically, I need to refresh the index manually.
Screenshots
1.Before refresh index manually

After 1mins

3.After refresh index manually

Expected behavior
I expected  I created the index can refresh automatically like auditlog.
Host/Environment (please complete the following information):

OS: CentOS Linux release 7.9.
Version Opensearch 1.3.3

Please help me this solution ! thanks so much.
Cindy

@cindy850322 According to the documents:
https://www.elastic.co/guide/en/elasticsearch/reference/7.10/indices-refresh.html#refresh-api-desc
https://www.elastic.co/guide/en/elasticsearch/reference/7.10/index-modules.html#dynamic-index-settings
OpenSearch periodically refreshes indices every second, but only on indices that have received one search request or more in the last 30 seconds (which is the default value of the setting index.search.idle.after).
Even if refresh operation is not executed due to no search request, new searches that hit an idle shard where a refresh is pending will wait for the next background refresh (within the default 1s).
(This behavior aims to automatically optimize bulk indexing in the default case when no searches are performed.)
Could you have a try to verify refresh operation can be done automatically if there is a recent search request on the index?

I did a simple test to verify the refresh mechanism I mentioned above, and it shown that the fresh function is acting properly.
I will close the issue for now, and please re-open it if you have further question.
1 start an OpenSearch cluster
2 run the script to ingest data to an index continuously
for i in {1110..19000};
do echo $i;
t=`date -u +"%Y-%m-%dT%T.%3N"`;
echo $t;
sleep 1 ;
curl -XPOST http://localhost:9200/test-index/_doc/$i -H 'Content-Type: application/json' -d'{"date":"'$t'" ,  "v":"'$i'"}';
done

3 run "cat indices" API to see the current status of document count and storage size
$ curl "http://localhost:9200/_cat/indices?v&pretty"
health status index      uuid                   pri rep docs.count docs.deleted store.size pri.store.size
yellow open   test-index 8cX3HfwEQtGCQWxZxzUZfA   1   1          1            0      4.1kb          4.1kb

4 wait a minute and re-run "cat indices" API, there was no change in any column.
5 run a search request to the index
curl -XGET http://localhost:9200/test-index/_search?pretty \
-H 'Content-Type: application/json' -d '
{
    "query": {
        "match_all": {}
    }
}
';

6 re-run "cat indices" API
# [23:51:29]
$ curl "http://localhost:9200/_cat/indices?v&pretty"
health status index      uuid                   pri rep docs.count docs.deleted store.size pri.store.size
yellow open   test-index 8cX3HfwEQtGCQWxZxzUZfA   1   1        448            0      4.1kb          4.1kb

# [23:51:31]
$ curl "http://localhost:9200/_cat/indices?v&pretty"
health status index      uuid                   pri rep docs.count docs.deleted store.size pri.store.size
yellow open   test-index 8cX3HfwEQtGCQWxZxzUZfA   1   1        449            0      4.1kb          4.1kb

# [23:51:32]
$ curl "http://localhost:9200/_cat/indices?v&pretty"
health status index      uuid                   pri rep docs.count docs.deleted store.size pri.store.size
yellow open   test-index 8cX3HfwEQtGCQWxZxzUZfA   1   1        460            0     44.8kb         44.8kb

# [23:51:44]
$ curl "http://localhost:9200/_cat/indices?v&pretty"
health status index      uuid                   pri rep docs.count docs.deleted store.size pri.store.size
yellow open   test-index 8cX3HfwEQtGCQWxZxzUZfA   1   1        463            0     44.8kb         44.8kb

# [23:51:47]
$ curl "http://localhost:9200/_cat/indices?v&pretty"
health status index      uuid                   pri rep docs.count docs.deleted store.size pri.store.size
yellow open   test-index 8cX3HfwEQtGCQWxZxzUZfA   1   1        465            0     44.8kb         44.8kb

# [23:52:13]
$ curl "http://localhost:9200/_cat/indices?v&pretty"
health status index      uuid                   pri rep docs.count docs.deleted store.size pri.store.size
yellow open   test-index 8cX3HfwEQtGCQWxZxzUZfA   1   1        475            0       35kb           35kb

7 It shows that refresh operation will automatically run for an index only when there was a recent search request to the index.


Add polyfill for String.prototype.endsWith

This is an ES6 feature not supported by all browsers

Why? Chrome supported ( latest version )
And MDN respond your question
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/endsWith

Some users found issues using Safari below v9.

Where would the polyfill be placed within the repository?


WebGL Render Warning if cacheAsBitmap is true

If cacheAsBitmap is set to true on a container that is empty or has only invisible children, Chrome (v56) and Firefox (v49) log a WebGL warning.
Warning Chrome:
[.Offscreen-For-WebGL-0000005524CBB4F0] GL ERROR :GL_INVALID_FRAMEBUFFER_OPERATION : glClear: framebuffer incomplete
[.Offscreen-For-WebGL-0000005524CBB4F0] RENDER WARNING: texture bound to texture unit 0 is not renderable. It maybe non-power-of-2 and have incompatible texture filtering.

Warning Firefox:
Error: WebGL: clear: Incomplete framebuffer: Status 0x8cd6: COLOR_ATTACHMENT0 has no width or height.
Error: WebGL: drawElements: Active texture 0 for target 0x0de1 is 'incomplete', and will be rendered as RGBA(0,0,0,1), as per the GLES 2.0.24 $3.8.2: The dimensions of `level_base` are not all positive.

Example: https://codepen.io/anon/pen/PWrXOB
Actual use-case: I have a container with n sprite elements. Depending on the state of the application I want to show 0 to n of the elements (by setting visible to true/false). After updating which sprites are visible, the container can be cached. If all elements are set to invisible the warnings appear.
My suggestion would be to extend the condition in
DisplayObject.prototype._renderCachedWebGL (and maybe in DisplayObject.prototype._renderCachedCanvas to be consistent) to include a check for width and height of the element.
if (!this.visible || this.worldAlpha <= 0 || !this.renderable)
{
  return;
}

to
if (!this.visible || this.worldAlpha <= 0 || !this.renderable || this.width === 0 || this.height === 0)
{
  return;
}

I can create a Pull request if you like the solution but I wanted to discuss it first as I am not sure if it's the only/best place for a fix.

better not use "width" and "height" , they are properties

Is it better to use the bounds Object in DisplayObject.prototype._initCachedDisplayObject?
If the renderTexture is only created when bounds.width > 0 && bounds.height > 0, the cached sprite uses Texture.EMPTY as a fallback which doesn't trigger the warnings.

I'm not sure that bounds won't be changed later. Its better to add flag to cached object that renderTexture is empty, or may be reference Texture.EMPTY instead, and then check it in rendering method

Maybe I understand something wrong, but aren't the bounds used to generate the texture?
https://github.com/pixijs/pixi.js/blob/dev/src/extras/cacheAsBitmap.js#L186
If either width or height are zero, the texture should be empty. So by checking width and height first, it is possible to step over lines 178 to 205 and create the sprite without texture (which will automatically use Texture.Empty https://github.com/pixijs/pixi.js/blob/dev/src/core/sprites/Sprite.js#L103)

Referencing my previously closed #3418 issue - it's just reared it's head again, and having read this, I can confirm that the relevant container has zero children at the time. I'd turned off cacheAsBitmap previously and this must have been what resulted in a resolution.

@ivanpopelyshev I was looking at the cacheAsBitmap implementation, and it seems bit heavy - would simply rendering to a texture do the trick? Cobbled something that sees to work, although, you need access the gl

@neutrino84 is does rendering into the texture and it works. what's the problem?

Sorry for the spam, I didn't know all commits would be referenced.
Maybe some code makes it clearer what I think would be a good solution. Please ignore the first two commits.

Also see this problem on Intel HD graphics card. So it is hardware related, but let`s be fair, IntelHD is world most popular built-in chip.

Hey @jsfi, if you think you have a solution for this can you put in a PR that references this issue?
Thanks!

Whats the current update on this? I'm still getting this same bug, even on that codepen. I'm in a dilemma right now where I have to choose between setting cacheAsBitmap = false (with lower performance) or cacheAsBitmap = true (with these warnings)


Top 5 countries

Can you add a category Top 10 countries of cases and death?

sure will do, nice one

💃
version 0.3.5 https://github.com/iobroker-community-adapters/ioBroker.coronavirus-statistics/commit/8d165d38a1ad65b70b884dd48a9e678ac7f190bd


Update es translations (patch provided)

Saw there are a few translations missing from es.coffee. Please find a patch with all text fully translated, would really appreciate if you could update :)
add-es-translations.patch.txt

Is this still an issue?

from what i can tell -- yes. if you apply the patch the spanish translations will be complete ;)

can you send a pull request please?

#168


In the lecture "A Problem that Stumped Milton Friedman", the code need to be sophisticated

When I tried to simulate the model with the following initial distribution, these are very similar distributions,  I got the unexpected results.

In this simulation, the cutoff values are
α = 0.48241206030150763
β = 0.5226130653266331
However, from the model, we must have α > β. We should check whether α is larger than β, or not.

@AnjuJoon would you mind to look at this, and consult with @shizejin if you're not sure?

@jstac yeah sure, I will look into that

@shizejin If you have time would you mind to review this and give me your opinion?

@jstac Sure, here is what I think and I made a PR to solve this.
@Yuya-Furusawa Thank you very much for pointing out this problem.
α and β can be equal, which is the case under the parameterization you gave. Intuitively speaking, when f0 and f1 are too similar and hard to be distinguished from each other, the gains from taking draws would be too small that we will just choose f0 or f1 by priori.
The current code fails to find out this equality. The mathematical definition of α and β is

while the code is not consistent with the math, and consequently the computation result is incorrect.

I've made a PR #435 to solve this problem, and the result seems correct.

@shizejin Thank you, I got it. I appreciate your great work.


DAPHNE Channel Map Update

See Manuel's talk from the May '24 CM

Never mind -- this should have no effect on the offline readout


git: 2.19.2 -> 2.20.1

https://raw.githubusercontent.com/git/git/master/Documentation/RelNotes/2.20.1.txt
https://raw.githubusercontent.com/git/git/master/Documentation/RelNotes/2.20.0.txt
Motivation for this change
Commits can (should?) be squashed, but wanted to show the path taken
and be sure to draw attention to the git-sh-i18n bits.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

I made an upgrade to an older version (2.20.0, #51806), encountered 2 test errors,

t0205-gettext-poison.sh
t5801-remote-helpers.sh

@dtzWill 	did all the tests pass on your machine?

Yep, they pass for borg too it appears?

helpers: see adjusted patch
gettext-poison: see commits re:git-sh-i18n: it seems to work if we leave it alone, including updating patch to apply-- I'm unclear what this was ever intended to accomplish so perhaps there are use cases impacted by this not caught by git's tests (perhaps NixOS-specific?).

From git-archaeology, this is the cause of the gettext patch being added: https://github.com/NixOS/nixpkgs/issues/13047.

Hmm, can't reproduce? But not sure I understand the problem -- the example git commands are all referencing invalid upstreams/revisions, yes?
Anyone want to weigh in, or is this good to go?

One fix that I have thought of is to modify the gettext patch so that it points to '${gettext}' when not in test environment, but leave the script to search from $PATH when it is in test environment.

2.21.0 is out, updating to it is just the normal version/hash bump on top of this.

This pull request has been mentioned on Nix community. There might be relevant details there:
https://discourse.nixos.org/t/nixos-19-03-feature-freeze/1950/37

https://github.com/dtzWill/nixpkgs/commit/94d5f77bcda4498ffb8aa29d1d295b69242efd4f for example.

cc: @zimbatm for the gettext patch.

Looks like someone tackled the i18n patch properly, closing in favor of that PR: https://github.com/NixOS/nixpkgs/pull/56376 .

Looks like someone tackled the i18n patch properly, closing in favor of that PR: https://github.com/NixOS/nixpkgs/pull/56376 .


Slim 3: Overriding default response class using DI container

I have a class that extends the \Slim\Http\Response class and would like to use that with my slim app.  I thought I could do that using the DI container but when I inspect the class of the response, it's still just \Slim\Http\Response and not my custom class (called ApiResponse).
Example:
$app = new App();
$container = $app->getContainer();
$response = $container->get('response');
var_dump(get_class($container->get('response'))); // doesnt return my custom class
The App class constructor:
public function __construct(\Slim\Container $container = null) {
if (!isset($container)) {
  $container = new \Slim\Container(array(
    'response' => new ApiResponse()
  ));
}
parent::__construct($container);

}
I'm not sure if this is a bug or I'm just not using the DI container correctly.....

This works for me:
class ApiRequest extends Slim\Http\Request
{
}

$app = new Slim\App([
    'request' => function ($c) {
        return ApiRequest::createFromEnvironment($c['environment']);
    }
]);

$app->get('/', function ($request, $response, $args) {
    echo get_class($request); // ->  ApiRequest
    return $response;
});

$app->run();

The extended App also is fine for me:
use Slim\App;
use Slim\Container;
use Slim\Http\Request;

require 'vendor/autoload.php';

class ApiRequest extends Request
{
}

class MyApp extends App
{
    public function __construct($container = [])
    {
        $container = new Container([
            'request' => function ($c) {
                return ApiRequest::createFromEnvironment($c['environment']);
            }
        ]);

        parent::__construct($container);
    }
}

$app = new MyApp();

$app->get('/', function ($request, $response, $args) {
    echo get_class($request); // ->  ApiRequest
    return $response;
});

$app->run();

@jwyuen you are missing a closure for your new Response class.
if (!isset($container)) {
  $container = new \Slim\Container(array(
    'response' => new ApiResponse()
  ));
}
parent::__construct($container);

should be
if (!isset($container)) {
  $container = new \Slim\Container(array(
    'response' => function () {
        return new ApiResponse();
    }
  ));
}

parent::__construct($container);

Hmm I've tried all of the suggestions and the class is still not getting overridden.  I'm using Slim 3.0.0-beta2 fwiw

Nevermind, it works on the latest dev commit on the 3.x-dev branch.... (commit a1427aaea68bf490be8481921ec4a07cf2279949)


WIP: 386 cleanup line breaks asciidoc

Conformance is ok.

Conventions are ok.

Cleanup complete - except that it looks like the figure captions may be broken in

appi.adoc
appj.adoc
ch07.adoc
ch08.adoc


[defect] the generated client constructors break AZC0007

Codegen Generate client constructors which break AZC0007
Error:

The endpoint/url is defined as a constant, so, endpoint is not a parametrized one. In this case, the codegen generate the correct constructors, but the analyzer reported the fake error. We will update analyzer which is tracked in issue https://github.com/Azure/autorest.csharp/issues/3706.
close this one.


Add support for pipeline stages on all AXI channels

Add support for num_b_pipe_stages, num_ar_pipe_stages, num_r_pipe_stages.  Previously only supported num_aw_pipe_stages and num_w_pipe_stages.  This has been tested with 4 different BFM configurations with a self-checking testbench and AXI-Lite Slave block, to verify that each channel is using the configured num_xx_pipe_stages.

Hi,
This sounds like a great improvement, but we just need to get some time to get the right person here to have a look at it. Most probably next week.

Espen

Updated patch-1 to UVVM 2020-06-23, tested with my internal AXI4 master & slave.  Still fails axilite_simple_tb.vhd, which appears to be an AMBA AXI Protocol Specification violation in axilite_slave.vhd and/or axilite_slave_model.vhd.


[Bug]: Updating PyYAML, requests, psutil packages to latest version required

Contact Details
No response
📦 Package Version
0.3.12
🎞 Framework Version
No response
🔎 Describe the Bug
Because crawl4ai (0.3.3) depends on PyYAML (6.0.2)
and agentops (0.3.12) depends on PyYAML (6.0.1), crawl4ai (0.3.3) is incompatible with agentops (0.3.12).
And because no versions of agentops match >0.3.12, crawl4ai (0.3.3) is incompatible with agentops (>=0.3.12).
So, because praisonai depends on both agentops (>=0.3.12) and crawl4ai (==0.3.3), version solving failed.
Because crawl4ai (0.3.3) depends on requests (2.32.3)
and agentops (0.3.12) depends on requests (2.31.0), crawl4ai (0.3.3) is incompatible with agentops (0.3.12).
And because no versions of agentops match >0.3.12, crawl4ai (0.3.3) is incompatible with agentops (>=0.3.12).
So, because praisonai depends on both agentops (>=0.3.12) and crawl4ai (==0.3.3), version solving failed.
Because crawl4ai (0.3.3) depends on psutil (6.0.0)
and agentops (0.3.12) depends on psutil (5.9.8), crawl4ai (0.3.3) is incompatible with agentops (0.3.12).
And because no versions of agentops match >0.3.12, crawl4ai (0.3.3) is incompatible with agentops (>=0.3.12).
So, because praisonai depends on both agentops (>=0.3.12) and crawl4ai (==0.3.3), version solving failed.
🤝 Contribution

[ ] Yes, I'd be happy to submit a pull request with these changes.
[ ] I need some guidance on how to contribute.
[X] I'd prefer the AgentOps team to handle this update.

@MervinPraison Just raised a PR for this @MervinPraison #434 -- We'll have it in the next release


Feature request: support convert python object to tensor automatical, and can back to object in py_func or other mechod.

I want to use python object as tensor in Tensorflow and can convert it back to object when useing tf.py_func method,  to  support using other python package.

Have you considered pickling? It should be possible to do this today. I am of course curious to learn more about how tf.py_func has been beneficial to your use case. I will also note that it is a feature that ought to be used judiciously. I'm going to close this one out, but if my suggestion doesn't offer solutions, let me know and I'll re-open.

@jart Now I use cPickle to do this, I want to embed FST in to tensorflow for beam search decoding.


System.InvalidOperationException: 'An exception occurred while reading a database value. The expected type was 'System.TimeSpan' but the actual value was of type 'System.DateTime'.'

The following Linq query generates the titled exception.
from d in ds
select (d.ExpiryDate.Value - currentDate).Days

ds is a DbSet.
d.ExpiryDate is type of DateTime?.
currentDate is type of DateTime.
If we use (d.ExpiryDate.Value.Subtract(currentDate)).Days, then we don't get the exception.
Please refer to the Steps to reproduce for complete source code.
Not sure, whether this is related to https://github.com/aspnet/EntityFrameworkCore/issues/13025
Exception message:
System.InvalidOperationException: 'An exception occurred while reading a database value. The expected type was 'System.TimeSpan' but the actual value was of type 'System.DateTime'.'

Stack trace:
   at Microsoft.EntityFrameworkCore.Metadata.Internal.EntityMaterializerSource.ThrowReadValueException[TValue](Exception exception, Object value, IPropertyBase property)
   at Microsoft.EntityFrameworkCore.Storage.Internal.TypedRelationalValueBufferFactory.Create(DbDataReader dataReader)
   at Microsoft.EntityFrameworkCore.Query.Internal.QueryingEnumerable`1.Enumerator.BufferlessMoveNext(DbContext _, Boolean buffer)
   at Microsoft.EntityFrameworkCore.Storage.Internal.NoopExecutionStrategy.Execute[TState,TResult](TState state, Func`3 operation, Func`3 verifySucceeded)
   at Microsoft.EntityFrameworkCore.Query.Internal.QueryingEnumerable`1.Enumerator.MoveNext()
   at Microsoft.EntityFrameworkCore.Query.Internal.LinqOperatorProvider.ExceptionInterceptor`1.EnumeratorExceptionInterceptor.MoveNext()
   at System.Collections.Generic.List`1..ctor(IEnumerable`1 collection)
   at System.Linq.Enumerable.ToList[TSource](IEnumerable`1 source)
   at TestHostForCastException.Program.Main(String[] args) in C:\EFCoreTestBed\Program.cs:line 24

Inner Exception 1:
InvalidCastException: Unable to cast object of type 'System.DateTime' to type 'System.String'.

Steps to reproduce
Repro included at https://github.com/avinash-phaniraj-readify/EFCoreTestBed/tree/CastErrorInProjectionWithDateTime
Further technical details
EF Core version: 2.1
Database Provider: EntityFrameworkCore.SqlServerCompact35
Operating system: Windows 10.0.17134
IDE: Visual Studio 2017 15.8.0

@smitpatel to communicate to @ErikEJ

@ErikEJ - You need to do something similar to https://github.com/aspnet/EntityFrameworkCore/pull/11110 for SqlCE

Interesting - my last comment on the original issue was an unanswered question: SQL CE fyi?

@ErikEJ - Sorry. Missed it. In future, I will be extra careful to tag you whenever something changes in SqlServer since it is very similar to SqlCe.

@smitpatel Can you please also add this to the provider-changes log.

@ajcvickers - Are we adding 2.1 provider changes?

@smitpatel Anything post <IP_ADDRESS> RTM. But I take you point--I didn't realize we shipped this before RTM.

Thank you.

Thanks for the heads up @smitpatel  - I should have paid better attention.

I will be extra careful to tag you whenever something changes in SqlServer since it is very similar to SqlCe.

Yes, somehow SQL CE at the core must share some code with SQL Server..
An updated 3.5 package with the has just been released to NuGet: https://www.nuget.org/packages/EntityFrameworkCore.SqlServerCompact35/<IP_ADDRESS>

Closing here, as the required change was in the Compact provider.


feat(request): support to persisted queries encoded variables

Description

Some support for persisted queries out of the box like trying to decode the variables by default

Screenshot

Checklist

[x] Displays correctly with both dark and light mode (see useTheme.ts)
[x] Unit/Integration tests added

Thanks for the improvement and general housekeeping @gtkatakura PR looks good.


chore(ci): remove tauri env variables

Remove tauri env variables from the build-app action, so it doesn't fail when from a fork

Doesn't work


[Pulse for Mac] Not saving layout's selection

Pulse for Mac is not saving the state selection of the horizontal or vertical layout after closing and reopening the app.
When the app opens again, it's always displaying the vertical layout.

Fixed (a couple of patches ago).


about progress percent value

sometimes the progress percent value is very long , I think we could use something like decimalCount param to make the percent decimal more controllable .

Or modify it when you display it :) the library should give you the most accurate value it can, then you can do what is necessary to display it.


[Bug] [jimple2cpg] Branches can cause incorrect CFGs, leading to methods such as reachableBy failing

Summary
With jimple2cpg, branches can cause incorrect edges in the control flow graph. This in turn can cause data flow methods such as reachableBy to break.
Example
Example.java:
public class Example {
    public static void main(String[] args) {
        String example = System.getenv("EXAMPLE");

        if (example == null) {
            return;
        }

        String exampleUpper = example.toUpperCase();
        System.out.println(exampleUpper);
    }
}

Compiling:
javac Example.java

Processing with Joern:
joern> importCode("Example.class")
joern> cpg.call.name("println").reachableBy(cpg.call.name("getenv")).l
val res0: List[io.shiftleft.codepropertygraph.generated.nodes.Call] = List()

Clearly there is a path from getenv -> println, but Joern does not pick up on it.
Cause
Looking at the control flow graph. we begin to see the problem:

ReachingDefFlowGraph uses Method.reversePostOrder:
/** List of CFG nodes in reverse post order
    */
  def reversePostOrder: Iterator[CfgNode] = {
    def expand(x: CfgNode) = { x.cfgNext.iterator }
    NodeOrdering.reverseNodeList(NodeOrdering.postOrderNumbering(method, expand).toList).iterator
  }

To determine which nodes to process. The (toUpperCase,l1.toUpperCase()) node is being skipped because of this, causing reachableBy to break.
Cause of Cause
So why is the control flow graph incorrect?
In Jimple, this is a unit:
l2 = virtualinvoke l1.<java.lang.String: java.lang.String toUpperCase()>();

Which jumple2cpg converts to the following AST:

In AstForMethodsCreator, this code links the root of this AST with the root of the if statement AST:
      // Join all targets with CFG edges - this seems to work from what is seen on DotFiles
      bodyStatementsInfo.targets.foreach { case (asts, unit) =>
        asts.headOption match {
          case Some(value) =>
            diffGraph.addEdge(value.root.get, bodyStatementsInfo.unitToAsts(unit).last.root.get, EdgeTypes.CFG)
          case None =>
        }
      }

The problem arises when the AST is converted into a CFG, which creates a graph like:

So now the link created from the if statement skips out all but the assignment.

Interesting, we recently did a fix for something similar in try-catch-finally blocks. Will eventually get around to this

Hi,I also get the problem. The latest joern seem not be repaired.