Improve documentation about Kubernetes objects & managing them

~Reorganize Working with Kubernetes Objects section [preview]~

~move Understanding Kubernetes Objects to be section overview~
~other tidying~
~Signpost readers to more pages about Kubernetes objects~ Now part of PR #42117

Improve docs relating to patching [preview] and SSA [preview]

This will need tech review by someone familiar with how Kubernetes implements the PATCH HTTP verb. I wasn't able to follow the existing documentation well enough to be confident that this revised text is accurate.
/language en
/wg api-expression

Helps with #31252

/lgtm

I've also asked WG API Expression for a tech review.

Needs some work
/lgtm cancel

How's this looking now?

@sftim, Do you need to add a redirect for, content/en/docs/concepts/overview/working-with-objects/kubernetes-objects.md?

Should the "What is Kubernetes" section list before "Objects in Kubernetes" in Overview?
https://deploy-preview-31261--kubernetes-io-main-staging.netlify.app/docs/concepts/overview/
To review:
https://deploy-preview-31261--kubernetes-io-main-staging.netlify.app/docs/reference/using-api/server-side-apply/
Content moved to index page (with section links)
https://deploy-preview-31261--kubernetes-io-main-staging.netlify.app/docs/concepts/overview/working-with-objects/

Ping for review
/wg api-expression

👋 @sftim . What do you think about moving forward with these changes?

Edits since informal LGTM are minor. I also rebased against main.

I've paused this to focus on getting an even older PR (30817) merged in.

If I split this into multiple PRs, I could also look at addressing https://github.com/kubernetes/website/issues/30576

Hey @sftim , I know you're swamped and are working on getting #30817 ready. Are there any updates on this? Whenever you have some free cycles, please could you rebase?

I had another go at this. It looks OK to me; I haven't looked thoroughly (sorry).

@tengqm requested that moving the overview page up one level happened in its own PR.
We've done that in a few places, I can make another change for that. I have not done this yet, so that feedback stands.

I'm going to unhold this because https://github.com/kubernetes/website/pull/39576 has merged separately.

/hold cancel

I'd like another review on this. My guess is that the overall change is net beneficial enough to swing the balance in favor of a merge.
There may be a nit or two remaining.

@jimangel if I could call in a favor, you did previously review and LGTM this change. Another look would be welcome.

I'll try to give it another look too, thanks for working on this @sftim!

/lgtm

Changes since last reviews:

fixed typos etc
added a new section about choosing which approach for updating existing objects
added an entry for the client-side apply annotation, and linked to it

/lgtm 🚀

Thanks!

Also see https://github.com/kubernetes/website/issues/42524

Applying lgtm from Jim's comment
/lgtm

The changes in the is PR look good and is an improvement
Thank you for addressing comments and questions
/label refactor
/approve


Any pre-built binaries for Linux (x86_64) with CUDA enabled for downloading?

As far as I understand, this has no CUDA support:
/bin/bash -c "$(curl -fsSL https://exaloop.io/install.sh)"

I tried to build the source by myself, but got many cmake errors, and thought it'll be great if there's pre-built binaries for linux+x86_64 now. Thanks!

Duplicate of #193.


Preinstall dotnet workloads

Tool name
dotnet workload
Tool license
MIT
Add or update?

[X] Add
[ ] Update

Desired version
The one that matches the installed dotnet sdk
Approximate size
No response
Brief description of tool
If you want to target specific platforms (or frameworks i.e. MAUI) in .NET, you often need to install additional workloads using the dotnet workload tool. This can be quite time consuming though, so it would be great if each platform could have their workloads pre-installed.
More details about workloads can also be found here
URL for tool's homepage
No response
Provide a basic test case to validate the tool's functionality.
No response
Platforms where you need the tool

[ ] Azure DevOps
[X] GitHub Actions

Runner images where you need the tool

[ ] Ubuntu 20.04
[ ] Ubuntu 22.04
[ ] Ubuntu 24.04
[ ] macOS 12
[ ] macOS 13
[ ] macOS 13 Arm64
[ ] macOS 14
[ ] macOS 14 Arm64
[X] Windows Server 2019
[X] Windows Server 2022

Can this tool be installed during the build?
The base dotnet sdk is already installed, and the workloads can be installed by using either dotnet workload install or dotnet workload restore
Tool installation time in runtime
Depending on the workload 2 to 10 minutes. The MAUI workload is probably the worst.
Are you willing to submit a PR?
No response

hi @rick-micpoint , Thank you for bringing this issue to our attention. We will look into this issue and will update you on this issue after investigating.

Thanks. I only marked the Windows images because that's where I currently need the workloads, but it obviously could be useful for the other platforms as well.

Hi, @rick-micpoint . We will track this requirement of pre-install workloads by the number of requests received .
we will validate all requests to incorporate them in future releases.thanks .


error while making from source

[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 49.754 s
[INFO] Finished at: 2016-10-28T02:33:26+05:30
[INFO] Final Memory: 25M/184M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.codehaus.mojo:wagon-maven-plugin:1.0:merge-maven-repos (install-repo) on project google-m2repository: Error during performing repository copy: Unable to create a Wagon instance for file://${env.ANDROID_HOME}//extras/google/m2repository: Repository path \\extras\google\m2repository does not exist, and cannot be created. -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn <goals> -rf :google-m2repository

@Jatinbalodhi96 Can you provide the commit id are you trying to build and the command are you using?

@Jatinbalodhi96 Do you have the extras installed? extras/google/m2repository

i'm using mvn install and i don't have extras/google/m2repository.
Do i need to install extras/google/m2repository seprately?

@Jatinbalodhi96 It depends, if you are going to use that, yes.
Try install the specific version you are going to use
For Android 7 for example:
mvn install -P 7.0

tried to install with mvn install -P 7.0
[INFO] Scanning for projects...
[WARNING] The POM for com.google.firebase:firebase-messaging:aar:9.4.0 is missing, no dependency information available
[WARNING] The POM for com.android.support:support-v4:aar:23.2.1 is missing, no dependency information available
[WARNING] The POM for com.android.support.test:runner:aar:0.5 is missing, no dependency information available
[WARNING] The POM for com.android.support.test:rules:aar:0.5 is missing, no dependency information available
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Build Order:
[INFO]
[INFO] AeroGear Android Push Parent
[INFO] AeroGear Android Push Library
[INFO] AeroGear Android Push Test
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] Building AeroGear Android Push Parent 4.0.3-SNAPSHOT
[INFO] ------------------------------------------------------------------------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] AeroGear Android Push Parent ....................... FAILURE [  1.305 s]
[INFO] AeroGear Android Push Library ...................... SKIPPED
[INFO] AeroGear Android Push Test ......................... SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 16.852 s
[INFO] Finished at: 2016-10-28T02:54:37+05:30
[INFO] Final Memory: 15M/179M
[INFO] ------------------------------------------------------------------------
[WARNING] The requested profile "7.0" could not be activated because it does not exist.
[ERROR] Failed to execute goal on project aerogear-android-push-parent: Could not resolve dependencies for project org.jboss.aerogear:aerogear-android-push-parent:pom:4.0.3-SNAPSHOT: Failed to collect dependencies at android:android:jar:[5.0_r1,): No versions available for android:android:jar:[5.0_r1,) within specified range -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/DependencyResolutionException

@Jatinbalodhi96 So, what are you trying to install? This is not a AeroGear project. This is a maven-android-sdk-deployer.
For a pure coincidence I'm from the AeroGear project
So, close this one here and open a new one there.

sry i gave u wrong output in last comment, but i've updated it now

@Jatinbalodhi96 Are you sure you have a env ANDROID_HOME?

Thanks @danielpassos and yes i was missing Android_HOME.
but i was setting it up to work with AeroGear and yeah i know you're from Aerogear project and i need ur help setting it up..

@Jatinbalodhi96 so, it's time to close this one and ask for a help there, on GH or in the ML.


Hell Revealed 1 was just re-added to the rebuild branch. This requires testing from the crack team of mapset testers.
Please add a note to the ticket if you are testing this and please report back on the following:
Any texture issues (missing or incorrect textures etc)
Thing issues (incorrect decorations. monsters etc)
Show stopping bugs
Any other issues

This should be tested within the week before other mapsets are added.
Please note that the HUB map is currently being rebuilt and is not available right now, use changemap HR1_01 to start the mapset

Hell Revealed 1 is completable and I haven't found any glaring texture issues.


fix range filter crashing page

Fixes an issue where loading a corpus with a range filter would completely freeze the page.

Thanks for the suggestion - I changed it so the template uses the filter.data behaviorsubject directly, which has nice property names (and also simplifies the component).


Add QUAY_USERNAME and  QUAY_PASSWORD repository secrets

Goal: Add the repository secrets QUAY_USERNAME and QUAY_PASSWORD so that the release action can properly log in to quay.io and push images.
Acceptance Criteria:

Add repository secrets QUAY_USERNAME and QUAY_PASSWORD
Successful run of the release GH Action

@awgreene or @jmrodri I think one you will have to do this as I don't have the necessary repo permissions to add secrets. I also am not sure which account we would need to use for this.

This is now completed. The repository secrets have been added and the release action was successfully able to log into quay.
Successful login can be seen in this action re-run: https://github.com/operator-framework/oria-operator/actions/runs/3268290341/jobs/5388743687
Now we just need to sort out the tagging for goreleaser to run properly


Remove 'admin channel' limitation

Moving to slash commands means it no longer makes sense to have a specific channel as the only place to issue Snorlax commands. And in any case I've not been a fan of putting this limitation in from the beginning!

Admin channel will remain.


[5.5] Add "strict" option for numeric validation rule

The numeric validates successful for values like NAN and INF. Although these are valid numeric values by specification, i think it's more intuitive when the validator fails for these values.
This PR adds an optional "strict" option to the numeric rule.
Validator::make(['value' => 'numeric:strict']);

This is a breaking change.

This would be really nice to have. 👍
Note that as Dylan noted this should go to the master branch just because it changes the method signature. You can change the base branch yourself by editing the pull request. 😄

Ok, did not think about that, but you are right.
I will need to open a new PR for that.

You need to rebase your branch to avoid that extra commits.

How does the name "strict" make sense at all? The INF and NAN are valid numeric values in php, how can any definition of "stricter comparison" point away from the existing language rules?
var_dump(is_numeric(INF)); // true
var_dump(is_numeric(NAN)); // true

The described functionality validates that the value is a real number, not any kind of numerical/comparison strictness.

this seems to have a lot more changes than what you described.

Fork the master branch and apply your changes straight there.


Refactor: Class rename

Renaming a class (or moving the file in the explorer view) should rename all references in the current project. And when dependency management is implemented, class references in all projects should be renamed.

Sounds like Christmas is coming early this year

Don't celebrate too early, that's just to have it in the backlog :-)


[BUG]Login button doesn't work with Route53 A record pointing to cloudfront distribution

Describe the bug
With actual front end URL everything works but with URL which I registered in route53, it launches the page, and when I click on login button nothing happens.
Cognito is integrated with Azure AD and works well with default frontend URL but not with "route53 simplied record"

registered cloudfront frontend URL in route53
ensure there alternate domain name updated in Cloudfront distribution pointing to domain name

To Reproduce
Browse the DNS via browser example https://friendlyname.com, it brings the login button but when I click on it, nothing happens
Screenshots

@Yukinobu-Mine
Yes I created a A record with Alias pointing to cloud front.
Also added Alternate domain name (CNAME) - optional pointing to URL I want to resolve but none is working.
Please note that I have integrated cognito with Azure AD, and authentication and authorisation works fine when it comes to default URL provided by CDK BUT when I register Cloud front to Route53 to a simplified name, that launches but LOGIN button doesn't work
and when I inspect the browser I get error below
index-5e8eddf3.js:165 Uncaught (in promise) InvalidOriginException: redirect is coming from a different origin. The oauth flow needs to be initiated from the same origin
at https://<my_simplified_URL>/assets/index-5e8eddf3.js:165:42368

@apheera Could you please provide the following information?

Allowed callback URLs setting of your Cognito user pool client. (in AWS console, Cognito -> User pools -> AuthUserPoolXXXX -> App integration tab -> App client list -> AuthUserPoolClientXXXX -> Hosted UI)
identityProviders setting in your cdk.json. (not including secretName)

yes allowed callback is already set to custom domain with the default one which was created by codebase
Identity provider settings below
"identityProviders": [
{
"service": "oidc",
"serviceName": "AWS-Bedrock-OpenID",
"secretName": "bedrock"
}
],

Resolved it - I've added the possibility of customizing this in the cdk.json, could you add it in this project aswell? (I have a lot of customizations that I can't push)


fix: vue2.7 SFC compiler.parse error for v7

see: #765

could you rebase and force-push the branch - it seems like CI got stuck :/

Rebase and force-push was finished.
After using this solution for 2 weeks, i found this doesn't align with the errors we see in IDEs(especially in volar) or from vue-tsc.

I'm dropping support for Vue.js - there is no clean API in TypeScript to support it and I don't have time to maintain it as current workaround is hacky and buggy :/


UnicodeDecodeError: 'utf-8' codec can't decode byte 0xf1 in position 933: invalid continuation byte

having this problem right now. any solutions?

i maybe found a loop hole or a reason. test using another wordlist. rockyou is "UTF-8 text" but other wordlists are "ASCII text" and those will work.
but this dont fix the fact it cant read files that are "UTF-8 text", some people want/have to use the rockyou wordlist and cant do it right now


DataVolume feature gate is not enabled even thought the config map is created

Is this a BUG REPORT or FEATURE REQUEST?:
/kind bug
What happened:
While I was trying to create a VirtualMachine with DataVolume enabled, I always get this error:
The  "" is invalid: spec.template.spec.volumes[0]: DataVolume feature gate is not enabled
Even though the configmap for enabling the DataVolume Feature Gate is actually created.
What you expected to happen:
I expect the VM to be created with DataVolumes enabled.
How to reproduce it (as minimally and precisely as possible):
Create the VM from the yaml file as explained in the VM or VMI specifications section.
Environment:

Kubernetes version:

Client Version: version.Info{Major:"1", Minor:"11", GitVersion:"v1.11.2", GitCommit:"bb9ffb1654d4a729bb4cec18ff088eacc153c239", GitTreeState:"clean", BuildDate:"2018-08-08T16:31:10Z", GoVersion:"go1.10.3", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"14", GitVersion:"v1.14.1", GitCommit:"b7394102d6ef778017f2ca4046abbaa23b88c290", GitTreeState:"clean", BuildDate:"2019-04-08T17:02:58Z", GoVersion:"go1.12.1", Compiler:"gc", Platform:"linux/amd64"}

VM or VMI specifications:

apiVersion: v1
kind: ConfigMap
metadata:
  name: kubevirt-config
  namespace: kubevirt
  labels:
    kubevirt.io: ""
data:
  feature-gates: "DataVolumes"
---
apiVersion: kubevirt.io/v1alpha3
kind: VirtualMachine
metadata:
  labels:
    kubevirt.io/vm: vm-alpine-datavolume
  name: vm-alpine-datavolume
  namespace: kubevirt
spec:
  running: false
  template:
    metadata:
      labels:
        kubevirt.io/vm: vm-alpine-datavolume
    spec:
      domain:
        devices:
          disks:
          - disk:
              bus: virtio
            name: datavolumedisk1
        resources:
          requests:
            memory: 64M
      volumes:
      - dataVolume:
          name: alpine-dv
        name: datavolumedisk1
  dataVolumeTemplates:
  - metadata:
      name: alpine-dv
    spec:
      pvc:
        accessModes:
        - ReadWriteOnce
        resources:
          requests:
            storage: 2Gi
      source:
        http:
          url: http://cdi-http-import-server.kubevirt/images/alpine.iso

OS (e.g. from /etc/os-release):
Ubuntu-18.04 LTS

Kernel (e.g. uname -a):
Linux Ubuntu-1804-bionic-64-minimal 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

So the main problem here is, the newly created configmap that configure the VM to enable the DataVolume is not picked up by the virt-api, thus restarting the virt-api will be sufficient. Once the pods are deleted the operator will create new one and the VM should be created successfully.


Modernise video recording

switch to 640x480@10 by default
switch to extpipe + x264 => .mp4 by default
only keep single (center) image per recording
update e-mail script to pickup .mp4 and rm event-start log file

Lovely improvements. All make sense.
Thanks a lot @dnwe !


Added funding to package.json

Current dependencies on/for this PR:

main

PR #229   👈

This comment was auto-generated by Graphite.


Cannot connect to multiple tenants

🐛 Summary
We have ran this on our test tenant, and then against a dev environment.
When we get the report from the dev environment it is listing users and settings from the test setup.
Even after a reboot, and deleting the scuba folder and running again from a new location.
To reproduce
Steps to reproduce the behavior:

Run Scuba against tenant 1
Run Scuba against tenant 2
Review reports and you will see details from tenant 1 in tenant 2.

Expected behavior
Would have expected a sign in to occur for each tenant. - which seemed to occur
This reports data from tenant 1 only.
Tenant 2 is then requested a powershell app to setup, and then reports data from tenant 2 only.
See issues for getting the initial domain.
Any helpful log output or screenshots

We are seeing this bug too, with the same process. Tested on our own tenancy and it worked perfectly. Tested on a client tenancy after this and go the same error.
The solution for us was to run:
Disconnect-MgGraph
in powershell prior to running .\RunSCuBA.ps1 to disconnect the Graph connector and re-prompt for Consent.

Thanks for the feedback. We're investigating better authentication handling, especially for users with multiple tenants, for future releases.
I'd recommend running Disconnect-MgGraph and then opening a new PowerShell window if you want to run against a different tenant.

We are seeing this bug too, with the same process. Tested on our own tenancy and it worked perfectly. Tested on a client tenancy after this and go the same error.
The solution for us was to run: Disconnect-MgGraph in powershell prior to running .\RunSCuBA.ps1 to disconnect the Graph connector and re-prompt for Consent.

Yep, that worked for me. Many thanks.

Closed in #24. The Disconnect-SCuBATenant and -DisconnectOnExit should improve this use case. Use either to fully disconnect your current session from any existing tenants.
We are exploring how to improve multi-tenant handling going forward, too. There are some limitations in the different MS modules.


Not listening on 10.0.19041.1202 win10-x86

Works on win10-x64 21H2, termsrv.dll version is 10.0.19041.1202
But Not listening on win10-x86 21H2, termsrv.dll version is 10.0.19041.1202 too
termsrv_from_win10home_21H2_x86.zip
.

Not listening on win10-x86

https://github.com/sebaxakerhtc/rdpwrap.ini/commit/2e49090699f2e3461eb56ef576688bf7dd24d399
The offsets was added
https://github.com/stascorp/rdpwrap/issues/1509

It works well, thanks !


Implement np.intersect1d

This is an implementation of np.intersect1d from #70  (and #2078 )

I think Jake and I were reviewing at the same time! His suggestion sounds good; maybe you can make another PR to incorporate it?

Sure, I'll add it and link to this PR

Correct, the semantics of numpy's intersect1d are incompatible with JAX transformations like jit.
#3614 tracks the effort to add size hints to functions that share this issue – many are done but intersect1d is not (it's been a while, but I recall one reason I didn't tackle it is that it wasn't clear to me what a natural fill value should be in the case that size is larger than the true intersection).
Many of these kinds of features are implemented on an as-needed basis. If this is important to your use-case, you might chime-in on that issue with ideas of what kind of shape-hint behavior would be useful to you.


Thumbnail random code

Issue Type: Bug
When I open a document, I notice that the Chinese string in the thumbnail is displayed incorrectly, it looks like '��',I think it's a bug
VS Code version: Code 1.51.1 (e5a624b788d92b8d34d1392e4c4d9789406efe8f, 2020-11-10T23:34:32.027Z)
OS version: Windows_NT x64 10.0.17134

I believe the "thumbnail" refers to the minimap (screenshot taken with "editor.minimap.scale": 3, the minimap doesn't zoom with window.zoomLevel or workbench.action.zoomIn)

Looks like it's by design in #82265 because drawing every character can be expensive.
However, in worst case, a non-English text file can have nothing but question marks and it's very noticeable. @alexdima @Tyriar


EhStorCertMgr

I installed WDK, SDK, ADK, visualstudio on Windows 10 1809 and 1903 and could not find any files named EhStorCertMgr*..
I then downloaded the appliance and mounted it - still no sign of EhStorCertMgr.* files anywhere.
Can you please just make these files available for download, perhaps even on GitHub in this project?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9205186b-f671-0ac6-d0a3-2c630d9a1525
Version Independent ID: def78a86-e830-cb69-f15c-0d939bb78e13
Content: Enhanced Storage Certificate Management Tool - Windows drivers
Content Source: windows-driver-docs-pr/devtest/enhanced-storage-certificate-management-tool.md
Product: windows-hardware
Technology: windows-devices
GitHub Login: @EliotSeattle
Microsoft Alias: eliotgra

Duplicate of Issue #1691


Team photos too large in second row

https://cz.pycon.org/2019/about/team/

The second row is always bigger. If you refresh, you get different people, but still bigger.

Actually:

Adding more less/people won't help, because it changes as I resize the window:

Yes, but the highest count of photos in one line is six so the best count is 12 IMHO. Will see how it'll behave when I fill it.


Fix native balances

Closing, because fix version in https://github.com/pontem-network/pontem/pull/132


Modifying the permission message.

Many people does't know that they have to login as a superuser to view the mongo admin interface , People get confused when they read the message(You do not have permissions to access this content).
This commit has an updated message. Please provide the right message if this is not correct.

I guess this means we need to update the Django version in our Travis build.

@garrypolley
Sorry, I didn't get you because I am not familiar with Travis CI. I couldn't see a job for django 1.7=> versions, assume that is the reason for the failure of all checks (I might be wrong).
I got stuck here and don't know what to do next.

Opening and closing seems to have done the trick for this to run against the updated travis ci settings.


Always disregard ~/.ssh/config; only use specified identity file

This change is from debugging a setup issue with lima 0.4.0 by @mook-as.
It was no longer required with 0.5.0, but it shouldn't hurt, and might be useful to avoid other conflicts.

(Maybe we should have a documentation about that ~/.ssh/config is discarded)


Exclude Tags for variables.

Question
We have 2 terraform projects that are nearly identical. (One is for Team A in us-east-1 and one is for team B in us-west-2). The issue we are running into is that the projects are so similar that we tend to copy code from one and paste it in the other. When we do we sometimes accidentally bring over an incorrect variable value (or variable name). Since I know that Team A's terraform config should never have the text "Team B" or "us-west-2" I thought I might be able to rig something up with terraform compliance. This is what I have so far:
Example terraform file for team a:
module "team-a-core" {
  source               = "../modules/core"
  project_config       = local.project_config
}

module "team-b-apps" {
   source = "../modules/ecs-service"
   app_config  = var.app_config
   project_config = var.project_config

   region                          = "us-west-2"
   fargate_cluster_id              = module.team-a-core.fargate_cluster_id
   loadbalancer_arn                = module.team-a-core.loadbalancer_arn
}

variable "aws_regions" {
  default = {
    "us-east-1" = {
      "region" = "us-east-1",
      "desc" = "US East (N. Virginia)"
    },
    "us-west-2" = {
      "region" = "us-west-2",
      "desc" = "US West (Oregon)"
    },
    # all of the regions are listed here
}

Lets say I made some changes for team b and then I copy / pasted into the file for team a. As you can see above I have now accidentally called the module "team-b-apps" which is incorrect.  Another mistake is that the region now reads us-west-2.
I have a scenario file that reads like the following:
@exclude_variable.aws_regions
Scenario: Nothing should be named team-b
  Given I have variables defined
  Then its value must not match the ".*(us\-west\-2).*" regex

When I run this in the debugger it looks like the variables are all loosing there initial name:
variable property in
{
	'default': {
		'us-east-1': {
			'account_id':<PHONE_NUMBER>21,
			'desc': 'US East (N. Virginia)',
			'region': 'us-east-1'
		},
		'us-west-2': {
			'account_id':<PHONE_NUMBER>94,
			'desc': 'US West (Oregon)',
			'region': 'us-west-2'
		}
	}
}
variable matches with .*(us\-west\-2).* case insensitive regex. It is set to us-west-2.

You can see that the exclude tag does not appear to be excluding this variable. Another question is how can a search the terraform paths? I want to ensure that "module.team-b-apps" does not actually contain the text "team b".
Overall I'm really enjoying using terraform compliance. Thanks in advance for your help.

@wesley-staples
in regard Another question is how can a search the terraform paths? I want to ensure that "module.team-b-apps" does not actually contain the text "team b".
I use referenced and I use it to flag on the RESOURCES that the module creates since with REFERENCED you can pull the address  which holds the module path.
This is one of the few queries that touched metadata outside the actual values block of the resource. With the addition of the create/action metadata to allow for filtering based on create update no-op it opens the door to parse in more metadata.
Let me know if that helps, we are currently running our deploy with alot of out of the box thinking until hopefully these gents get some bandwidth to dig further into the json.
Given I have aws_s3_bucket defined
Then it must have "module.moduletester." referenced

              "address": "module.moduletester.aws_s3_bucket.main",
              "mode": "managed",
              "type": "aws_s3_bucket",
              "name": "main",
              "provider_name": "registry.terraform.io/hashicorp/aws",
              "schema_version": 0,
              "values": {
                "acl": "private",
                "bucket": "module-bucket-tester",
                "bucket_prefix": null,
                "cors_rule": [],
                "force_destroy": false,
                "grant": [],
                "lifecycle_rule": [],
                "logging": [],
                "object_lock_configuration": [],
                "policy": "",
                ***REDACTED FOR BREVITY

I am using a bunch of negative tests to quantify module use until we can hopefully get the additional metadata parsed like in my request here below.
456
essentially getting more metadata into the

You can also use address property for your specific case where you can access to terraform internal resource reference/address (like module.team-b-apps).
Apart from those, I see 2 problems on your approach. Of course, its hard to see anything just by reading this issue, hence you might already address these or these could be non applicable for you as well for any other reason.

IMHO, if you are going to use identical two terraform code, it should not be copied unless they have to live in two different repositories. Utilising different backend.conf, -backend-conf parameter or workspaces with a Makefile could possibly provide you to run the same code for both team with different configurations (like resource counts, sizes, parameters, provider regions, etc.) in an easier way. You might already considered this and discarded this idea due to a reson that I don't know, hence just saying :)

Checking address of a terraform resource does not mean much from a security perspective. Since a Team A creating a module ;

  module "team-a-apps" {
    source = "/path/to/module/related/with/some/other-team"
  }

could still create a problem depending on your code structure. Hence, instead of focusing on How teams construct their modules ?, IMHO, we should focus on What kind of resources a specific Team can/can not create or similar scenarios where we are focusing on the end-product instead of bi-products. Modules are just bi-products for terraform.


chore(api/io-engine,csi): migrate from api repo

typo in the commit title migrade -> migrate

typo in the commit title migrade -> migrate

good catch, fixed on both PR and commit


incorrect/incomplete minification

In some cases the analysis minifies a selector in the wrong way. Unfortunately, because this is for internal code, I cannot post the full HTML on GitHub. If you want it though, I am happy to send it to you privately.
Hopefully I can describe the issue enough to make it reproducible. Take an HTML form that calls some javascript:
<form action="#" onsubmit="return validate(this);">
    <input type="url" id="url" class="custom-search-input" onkeyup="check(this);" placeholder="https://en.wikipedia.org/wiki/Minification_(programming)">
    <textarea name="message" id="message" class="custom-search-textarea" placeholder="Add a message here"></textarea>
    <button class="custom-search-botton" id="button" type="submit">do it</button>
</form>

The problem now occurs for id url and message. Assume I have this as my JS:
function check(input) {
    ...
    let url = document.getElementById("url");
    ...
}

then url gets minified. However:
function validate(form) {
   next_step(form.url.value, form.message.value);
}

the use of url and message here will not be detected. As a result message does not get minified, while url gets minified but the above code line would not be updated.
edit: sorry, I hit submit too early. Updated to finish the explanation.
edit 2: a further minification could be to also rename JavaScript functions.

Thank you so much @kimbauters for taking the time to lodge such a detailed issue report. Much appreciated.
Right now, due to the limitations of the regex-based implementation, it's difficult to discern between an actual ID property and an object property. Will have a think about this and see how far it could be pushed. Though I suspect it'll eventually need to be done with a AST implementation down the line.
I was going to suggest maybe doing form.elements["url"].value, but embarrassingly I've missed that and that needs to be added (triaged it into #38). I guess form.querySelector("#url").value for the time being perhaps as a stop-gap solution, unfortunately it's not as elegant as how you have it right now.

No problem at all. It is definitely something that can be worked around. This particular bug just caught me a bit by surprise as it was otherwise working well.
I'm fully aware of the challenge here though. You basically have to juggle 4 languages at the same time, each with their own dialects, so it is by no means an easy feat!

Oh and you've correctly observed that it would not minify the url ID in your markup until it was used in your scripts as well. I've mulled over this and it's probably better to always minify IDs regardless (tracking in #39).


Add support for MS excel format using Apache POI

Add reader and writer for MS Excel format using Apache POI

Hi,

Hi,
There is no due date, it depends on the progress. There is a branch named easybatch-msexcel where I am experimenting with Apache POI. See example here.
Here is the current status of the branch:

[x] MsExcelRecord
[x] MsExcelRecordReader
[x] MsExcelRecordMapper
[ ] MsExcelRecordMarshaller
[ ] MsExcelRecordWriter

You can already try it by importing the 4.1.0-SNAPSHOT version in your project.
The current reader supports only xls format, you are welcome to add support for xlsx from your implementation.
BTW, are you using the latest version 4.0? If not, I strongly recommend you to upgrade, this is the best release so far! Would love to hear your thought on this new version :-)
Regards
Mahmoud

Hi Mahmoud,
Yes we are using version 4.0 and we love it :)... As for xlsx support, our requirement is to be able to read both format by replacing one line in your MsExcelRecordReader.java
HSSFWorkbook workbook = new HSSFWorkbook(new FileInputStream(file));
with
Workbook workbook = WorkbookFactory.create(new FileInputStream(file));
Thanks for the great work. This framework is rock!
Regards,
Sothavirak

Thank you for this kind feedback! I'm glad you like it :-)
I was thinking about making the MsExcel format as a second parameter to the MsExcelRecordReader:
File tweets = new File("tweets.xls");
Job job = JobBuilder.aNewJob()
      .reader(new MsExcelRecordReader(tweets , MsExcelFormat.XLS)) // or MsExcelFormat.XLSX
      .build();

Or may be other names for the constants, but the idea is to make the format configurable at construction time to support both versions.
The work is in progress, keep tuned. You are welcome to contribute if you want!
Kind regards
Mahmoud

Hi Sothavirak,
It took some time, but it is finally here :smile:  I've added support for MsExcel XLSX support in the master branch and will be released soon. Here are the main components:

MsExcelRecord: record having apache POI Row as payload
MsExcelRecordReader: iteratively read MsExcelRecords from a xlsx file (streaming will be added later on)
MsExcelRecordMapper: map rows to POJOs
MsExcelRecordMarshaller: marshal POJOs to rows
MsExcelRecordWriter: write rows to a sheet in a xlsx file

I've decided to support only the new format (xlsx) but not the legacy one (xls).
It would be great if you can try it with version 4.1.0-SNAPSHOT and give me your feedback. An example can be found here.
Kind regards
Mahmoud

I'm preparing to release v4.1 including this feature.
If you have any issue, please file a bug.


Docker-Compose

Hello, you said you were unfamiliar with docker compose so I rewrote the run command in compose. If you'd like you can include this in the same section as the docker run command.
name: copyParty
services:
    ac:
        stdin_open: true
        tty: true
        user: "1000"
        ports:
            - 3923:3923
        volumes:
            - /mnt/nas:/w
            - $PWD/cfgdir:/cfg
        image: copyparty/ac

Indention is a key in YAML, so it is better to use the code formatting here and format it correctly.
Here is my docker-compose.yml (part of it):
version: '3.9'

services:
   ## Watchtower upgrades services automatically (optional)
   watchtower:
     image: containrrr/watchtower:latest
     container_name: watchtower
     restart: unless-stopped
     ## Uncomment next line and add the same line to the service definition, which you'd like to be auto-updated by Watchtower ONLY.
     ## In this way you'll tell Watchtower to update ONLY that service, while now it will update all of them.
     # profiles: ["update"]
     environment:
       WATCHTOWER_CLEANUP: ${WATCHTOWER_CLEANUP}
       WATCHTOWER_POLL_INTERVAL: ${WATCHTOWER_POLL_INTERVAL} #in sec, checks for updates every 24 hours
       WATCHTOWER_TIMEOUT: ${WATCHTOWER_TIMEOUT}
     volumes:
       - "/var/run/docker.sock:/var/run/docker.sock"
       - "/home/user/.docker/config.json:/config.json:ro" # optional, for authentication if you have a Docker Hub account
       - "/etc/localtime:/etc/localtime:ro"      # use timezone from host
       - "/etc/timezone:/etc/timezone:ro"        # use timezone from host

   ## Copyparty is a web-based file manager allowing you to manage your media and upload files from any device (optional)
   copyparty:
     image: copyparty/iv:latest
     container_name: copyparty
     restart: unless-stopped
     user: "1001:1001"
     stop_grace_period: 10s
     ports:
       - "8800:8086"
     ## Security options for some restricted systems
     security_opt:
       - seccomp:unconfined
       - apparmor:unconfined
     devices:
       ## Uncomment next devices mappings if they are available in your host system
       ## Intel QSV
       - "/dev/dri:/dev/dri"
       ## Nvidia CUDA
       # - "/dev/nvidia0:/dev/nvidia0"
       # - "/dev/nvidiactl:/dev/nvidiactl"
       # - "/dev/nvidia-modeset:/dev/nvidia-modeset"
       # - "/dev/nvidia-nvswitchctl:/dev/nvidia-nvswitchctl"
       # - "/dev/nvidia-uvm:/dev/nvidia-uvm"
       # - "/dev/nvidia-uvm-tools:/dev/nvidia-uvm-tools"
       ## Video4Linux Video Encode Device (h264_v4l2m2m)
       # - "/dev/video11:/dev/video11"
     volumes:
       ## Make sure copyparty can read/write to the mounted volume
       ## Mount local folder as a repository:
       - "${HOST_MEDIA_ROOT}:/media"
       ## Load your own custom configuration file
       - "${HOST_LOCATION}/copyparty:/cfg"
       - "/etc/localtime:/etc/localtime:ro"      # use timezone from host
       - "/etc/timezone:/etc/timezone:ro"        # use timezone from host
     healthcheck:
       test: ["CMD-SHELL", "wget --spider --quiet --no-check-certificate https://localhost:8086/ || exit 1"]
       interval: 1m
       timeout: 2s
       retries: 5
       start_period: 30s

Thanks! I'll use that to start an examples section somewhere, will have to think about where to put it though :>
Just to explain the stuff Konstantin mentioned; github uses markdown for comment formatting, so the trick is to add a line with three backticks (```) before and after the yaml text. But it kept the spaces in the edit history, so no problem :+1:


[SPARK-43337][UI][3.3] Asc/desc arrow icons for sorting column does not get displayed in the table column

What changes were proposed in this pull request? Remove css !important tag for asc/desc arrow icons in jquery.dataTables.1.10.25.min.css
Why are the changes needed?
Upgrading to DataTables 1.10.25 broke asc/desc arrow icons for sorting column. The sorting icon is not displayed when the column is clicked to sort by asc/desc. This is because the new DataTables 1.10.25's jquery.dataTables.1.10.25.min.css file added !important rule preventing the override set in webui-dataTables.css
Does this PR introduce any user-facing change? No.
How was this patch tested?
Manual test.

Merged to 3.3


download and install issues

I was trying to install it from the market place, but I couldn't get to the organization ("We did not find an organization for which you are an owner or a member.")
I was trying to install it with VSIXInstaller but didn't work either ("VSIXInstaller.NoApplicableSKUsException: This extension is not installable on any currently installed products.")
Is this extension still available on the market?

I was able to install it on my VSTS org. I used Visual Studio Code, downloaded extension from https://github.com/johnwalley/vsts-publish-html-artifact then used https://docs.microsoft.com/en-us/vsts/extend/develop/add-dashboard-widget?view=vsts to build the vsix and was able to publish it and use it privately.

You may have to rename key "publisher" to "johnwalleyy", in vss-extension.json while creating the publisher in VSTS

Thank you very much
I will try to do that

But I am not able get it publishing html in the latest version of vsts.
On Thu, Aug 9, 2018, 1:08 AM Elis<EMAIL_ADDRESS>wrote:

Thank you very much
I will try to do that
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/johnwalley/vsts-publish-html-artifact/issues/8#issuecomment-411638202,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AoRHN3PVnwejfG32haUU2_bXbjYievRSks5uO8O1gaJpZM4VRGDG
.


Support old (and new) bpf_map_def layout

Addresses #10
Please note, while this passes tests I haven't had a chance to actually try it with an older/new map definitions. If someone has an old program lying around, please test it before merging.
It also breaks the id and pinning fields, replacing them with the members found here.

bpf_map_def is not the same as the args passed to BPF_MAP_CREATE.
There are two versions out in the wild, one used by libbpf: https://github.com/libbpf/libbpf/blob/12eb2666d9e97d03a10347edb12112b3f638b989/src/libbpf.h#L400 and one used by iproute2: https://github.com/eworm-de/iproute2/blob/1fdea280517b9951e43bc4544210024d0346b27e/include/bpf_elf.h#L32
id and pinning are required to load programs originally written to be loaded with tc and friends from iproute2.

bpf_map_def is not the same as the args passed to BPF_MAP_CREATE.

Whoops, I misunderstood how the values were being passed around. It's using the correct struct now.

Oh also please make sure to cargo fmt your changes


Add more examples to integration tests

Describe changes
This PR adds most of our remaining examples to the integration test suite.
During this process I encountered many issues in the examples (especially when running with a containerized orchestrator) which were also fixed.
Pre-requisites
Please ensure you have done the following:

[x] I have read the CONTRIBUTING.md document.
[ ] If my change requires a change to docs, I have updated the documentation accordingly.
[ ] If I have added an integration, I have updated the integrations table and the corresponding website section.
[x] I have added tests to cover my changes.

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[x] Other (add details above)

The evidently example is still failing on docker, but unrelated to your changes. I fixed it in #1348 .


Issue with bounding sensitivity

Hi,
I do want to address the problem of RDP calculation is the code. As I went through the paper Renyi Differential Privacy of the Sampled Gaussian Mechanism, the calculations are for l2-sensitivity of 1.
In the code, there is a parameter defined as --sigma or noise_multiplier which will be multiplied by the self.max_grad_norm and will be used to calculate RDP. The self.max_grad_norm limits the sensitivity of the function. However, the self.max_grad_norm parameter plays no part in the calculation of RDP. It is inconsistent with the definitions of the main paper.
Assume we increase the self.max_grad_norm value to a large number. Should we still get the same e-RDP guaranty?
Also the $\sigma$ of the additive noise is self.noise_multiplier * self.max_grad_norm according to this part of the code but it equals to self.noise_multiplier for calculation of the RDP as implemented here.
I think we should change the lines of this part, to the following:
     def get_renyi_divergence(self):         rdp = torch.tensor(             tf_privacy.compute_rdp(                 self.sample_rate, self.noise_multiplier * self.max_grad_norm, 1, self.alphas             )         )         return rdp

Amirsina,
These are valid questions, and I'm glad to answer them.
Think about the additive Gaussian noise mechanism for computing the sum of reals. In its basic formulation we consider x_i from the range [0..1], compute their sum, and add noise sampled from N(0, sigma^2). It satisfies (alpha, alpha / 2*sigma^2)-RDP.
What if the numbers are coming from the range [0..B]? The analogue of the strategy employed in pytorch-dp is to add noise sampled from N(0, (B * sigma)^2). Crucially, the mechanism satisfies the same RDP guarantee. In other words, the privacy analysis is not dependent on B.
This is the reason why we refer to sigma as the noise multiplier and not the noise std.
Factoring the additive noise into the clipping-dependent part and the privacy-budgeting part makes sense to us because they play different roles and meet in code only once in the noise sampling parameter ("N(0, (B * sigma)^2)"). Does it address your concern?
--Ilya

Thank you for your explanation. I understand your explanation and I agree. However, as I explained for the noise the sigma that is added is self.noise_multiplier * self.max_grad_norm which is aligned with your explanations. In the paper Renyi Differential Privacy of the Sampled Gaussian Mechanism the sigma is still there and the sensitivity assumption is 1 as you mentioned.
So you are mentioning in RDP calculation, we should NOT use B * sigma as the noise sampling parameter and we should use sigma which defined as noise multiplier?

So you are mentioning in RDP calculation, we should NOT use B * sigma as the noise sampling parameter and we should use sigma which defined as noise multiplier?

That's right.

My take from your explanation is that when self.max_grad_norm is higher than one, it suffices to add noise with std of self.noise_multiplier * self.max_grad_norm and calculate RDP with self.noise_multiplier as the previous state.

Agreed. Closing the issue.


Increase max GridView size for ctrl + scroll

Is your feature request related to a problem? Please describe.
In the current master branch, the max GridView size achievable by ctrl + scroll is 220. It would be really appreciated if that max could be increased without modifying the default GridView layout sizes in the master branch ie. leaving the large, medium and small defaults as 220, 160 and 100 as set in #2479
Describe the solution you'd like
Increase the max GridView size achievable by ctrl + scroll. Windows Explorer's "Extra large icons" are approximately 270x275, so somewhere around there should be good, but it may be worth setting the max around 320 just to give users a little extra flexibility.
Additional context
Max GridView of 220 (as in master)

Proposed Max GridView of 320 (only achievable by ctrl + scroll or ctrl + + ie. not a default in the layout options flyout)

If you're happy with this proposal, can you assign me to it?

@Dylan-Osborne I believe this is already implemented.

@yaichenbaum Running the current master I can't get past GridView size 220, here's what I mean

If I'm correct the offending line is https://github.com/files-community/Files/blob/7b5aa84e92a03183b325431c8b684f153cba923b/Files/View Models/SettingsViewModel.cs#L651 as it's checked if the new value is smaller than Constants.Browser.GridViewBrowser.GridViewSizeLarge which is set to 220, this effectively limits the max size to 220.

@Dylan-Osborne I see it now, if you want to work on adding an option for 260, go ahead. I wouldn't add a menu option for this, instead, it can be accessed using ctrl + +.

This issue should be resolved with #2561.


Correct spelling mistake in README

TODOs:

[ ] Commits have meaningful description, they are relatively small.
[ ] PR have meaningful description.
[ ] Fixed or added new code.
[ ] Covered changes with tests (should be close to 100% coverage for new code).
[ ] Code is well-documented (public functions have @doc blocks).
[ ] If environment variables were added, .env and annon.infra is changed correspondingly.

If you submit new feature:

[ ] Describe a use-case for this feature.
[ ] Documentation in README.md and apiary.apib is updated to match latest changes.

Hello, @Kjir! This is your first Pull Request that will be reviewed by Ebert, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information.

Thank you 👍


Converting file to csv stream is adding new line

I am trying to convert the xlsx file to csv stream and when i listen on data and print the chuck i'm seeing a new empty line which is not present in the file
var xlsx = require('xlsx')
const wb = xlsx.readFile('testData.xlsx')
const ws = wb.Sheets[wb.SheetNames[0]];
const stream = xlsx.stream.to_csv(ws)
stream.on('data', chunk => {
    console.log(chunk)
    console.log(chunk.toString())
    console.log(chunk.toString().length)
})

the testData.xlsx file contains the following data
a,b,c
1,2,3

When i run the above mentioned code i'm getting the following output
<Buffer ef bb bf>

1
<Buffer 61 2c 62 2c 63 0a>
a,b,c

6
<Buffer 31 2c 32 2c 33 0a>
1,2,3

6

in which we can see a new line.
Can someone help me understand why xlsx is adding that new line and how to read the correct data from the file?

The newline characters are written when the individual rows are written.  As a result, it currently writes a newline character at the end.
If you would like to change that, https://github.com/SheetJS/sheetjs/blob/master/bits/97_node.js#L27 should keep track of whether the first line was written:  It would look like:
		var BOM = false;
+		var wrote_first_line = false;
// ...
-					stream.push(row + RS);
+					stream.push(wrote_first_line ? RS + row : row);
+					wrote_first_line = true;
					break;

I would like to work on this. Apart from above mentioned code changes, there has to be additional code to remove the newlines as well I believe? Guidance in this regard would be helpful as this is my first open source contribution

Fixed in a32b30414b3a1da61ba6d6b847a473f54481815a . CSV export (both stream and normal) omits trailing record separator


Issue with your RSS feed

Hi Kitty! I noticed an issue with your RSS feed: the HTML tags in your articles are not correctly encoded and are badly displayed. I noticed you simply replace < and > by < and >. It means the tags that are supposed to be displayed in your article (e.g; <aside>) cannot be distinguished from "real" tags by the aggregators. For instance, your article “Accessible footnotes and a bit of React” is really hard to read and can even break the layout of aggregators. Here’s how it looks for me:

I suggest you to not replace < and >, but to render the RSS description tag with a CDATA section:
<description><![CDATA[{{ post.templateContent | replace: 'href="/', 'href="https://kittygiraudel.com/' | replace: 'src="/', 'src="https://kittygiraudel.com/' }}]]></description>

More information here: https://www.rssboard.org/rss-profile#element-channel-item-description
I think it should be enough :)

Hello! Thank you so much for reporting it. I’ve just issued a build with your fix: https://github.com/KittyGiraudel/site/commit/8c120227094aa36c05ed962f08752c8e2c44e555. Do you mind checking that it’s fixed please? :)

A lot better!
For some reasons, the indentation of tags is incorrect in your feed (only one space), but I also just noticed that I have an issue in my own aggregator theme (which explains the small margin of the first line).

Aww, I’m so glad it’s fixed. I didn’t know about this solution, thank you so much. 💖

Glad I could help!


[RWLocks] Add ObjectArg::SharedObject::mutable

This PR does the following:

Updates sui API by adding mutable: bool to the SharedObject.

The move integration enforces that if client pass immutable shared object arg, it translates to immutable reference on the move call. It is an error to pass immutable shared arg as mutable arg to move, but not the vise versa - user can specify SharedObject::mutable=true but then pass it as immutable & reference to move call - this is to make sure existing clients do not break if they don't set SharedObject::mutable field.

This PR focuses on API change and does not yet update scheduling - under the hood immutable SharedObject still acquire a mutable lock - change for that coming in next PR.
Compatibility note:

For JSON-RPC SharedObject::mutable has serde_default set to true - if client does not specify SharedObject::mutable they will get mutable reference by default (which is current behaviour)

might be good to get @tnowacki looped in on this change

Core change seems minimum so LGTM.
The primary challenge would be on SDK side I guess. For example, how would cli figure out whether to add mutable or not.

I think for now we keep this question open - we will enforce that people set this flag on Clock object and perhaps epoch system object so that they can't cause contention
After that, we probably offer a lower gas price as incentive to set the flag and hopefully some way to auto detect it in SDK

Yes, I think adding this to SDK is not critically urgent (existing clients won't break) but we want this sooner rather then later because we will enforce mutable: false on some system objects such as Clock object (so we want users to be able to craft such transactions in SDK)


Edge to edge display on Android

Details

Fixed Issues

$ GH_LINK
PROPOSAL: GH_LINK_ISSUE(COMMENT)
Tests

[ ] Verify that no errors appear in the JS console

Offline tests

QA Steps

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[ ] I linked the correct issue in the ### Fixed Issues section above
[ ] I wrote clear testing steps that cover the changes made in this PR

[ ] I added steps for local testing in the Tests section
[ ] I added steps for the expected offline behavior in the Offline steps section
[ ] I added steps for Staging and/or Production testing in the QA steps section
[ ] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[ ] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[ ] I included screenshots or videos for tests on all platforms
[ ] I ran the tests on all platforms & verified they passed on:

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

[ ] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[ ] I followed proper code patterns (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[ ] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I followed the guidelines as stated in the Review Guidelines
[ ] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] I verified that if a function's arguments changed that all usages have also been updated correctly
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

I made some good progress on this. There is just one behaviour I wanted to confirm here before moving forward. Except for most recent android versions, the navigation bar is rendered as an actual bar and doesn't look good when transparent and some content is underneath.
For example here is on API 23, which doesn't look good

but looks fine on API 33 with gesture navigation

What I suggest is to display a view over navigation on API < 29 and leverage enforceNavigationBarContrast for API >= 29. This way the system will draw an overlay for navigation bar and nothing for gesture navigation.
I think this is a good compromise which avoids having to think about whether there is a navigation bar or navigation gestures. It looks best with navigation gestures which is what I assume most new phones have / will have.
Android API 23
https://user-images.githubusercontent.com/2677334/225137994-305c1394-0a40-4c76-aa6f-7e538dccfa8d.mov
Android API 31
https://user-images.githubusercontent.com/2677334/225138435-853044da-1fb0-4f2d-b5ad-1df7dc662a83.mov
Android API 33
https://user-images.githubusercontent.com/2677334/225139326-c3c5cd63-09c1-49fb-9a5b-ccc059c09616.mov
Issues
Modal does not display over navigation bar on recent android versions, this will need to be fixed in RN core.

For some reason API 23 works fine and it should look like this

@Julesssss This is actually the next step after we merge https://github.com/Expensify/App/pull/15778 so we can have both transparent status bar and navigation bar. I will address your feedback once https://github.com/Expensify/App/pull/15778 is merged.

Hey @janicduplessis, just found this comment. Should we move forward with this PR again now?

@Julesssss Yes I think we could work on this again. If I remember correctly the only issue I found was with react-native modal component which doesn’t properly cover the screen when using edge to edge display, it would require a patch in react native to fix.

Let's still hold this until we upgrade RN to 0.72.x in #18507

Can we revisit this PR now?

Yes, I can try fixing the modal issue upstream so we can eventually move forward with this. I think it is kind of a blocker still since we use a lot of modal components and it causes it to have a gap at the bottom the size of the navbar.

Hey @janicduplessis, I'd love to pick this up again and help you get it merged at some point. But do you mind if I close this PR in the meantime?

Cool


ticket #1396: disallow duplicated page paths

Hi @iphilgood,
this PR disallows duplicated page paths.
Thank you very much,
Alex

@alexanderadam just have a look at my comments, otherwise good work :raised_hands:


Flaky test: EventLoopTest.testRepeatedTaskThatIsCancelledAfterRunningAtLeastTwiceNotifies

Expected behavior
It should pass every time.
Actual behavior
It failed 3 out of the last 21 times I ran it in the last week in an Android x86_64 emulator on macOS 11 for my daily Android CI that runs on github actions. That CI cross-compiles the 5.5.3 and latest 5.6 and trunk snapshots of the stdlib and corelibs for Android x86_64 from Ubuntu 20.04, cross-compiles NIO and its tests against that Android SDK, then runs the tests serially in the official Android emulator, which runs at close to native speed on macOS 11 x86_64. This test has been flaky for a long time, just reporting it now.
Two of this week's failures were with a trunk SDK, the other with 5.5.3, so it doesn't depend on the Swift version, all the same error:
swift-nio/Tests/NIOPosixTests/EventLoopTest.swift:772:
error: EventLoopTest.testRepeatedTaskThatIsCancelledAfterRunningAtLeastTwiceNotifies :
XCTAssertEqual failed: ("timedOut") is not equal to ("completed") -

I cannot reproduce on Android AArch64 running on my phone, implying this is either specific to Android x86_64 or resource constraints in the emulator, more likely the latter.
Steps to reproduce

Follow the instructions for my Android SDKs, building and testing for Android x86_64 instead.

An easier way may be to try to reproduce on a small linux x86_64 VPS.
SwiftNIO version/commit hash
latest trunk commit on every day the CI ran, currently d489d9f
System & version information
Building on Ubuntu 20.04 x86_64 and running on Android x86_64 at API 24
@gwynne, you added this test three years back, maybe you know what to do.

The expectation that is awaited on line 772 has an extremely tight deadline:
https://github.com/apple/swift-nio/blob/d489d9f38f9bea8da3252d42632b18244b137a14/Tests/NIOPosixTests/EventLoopTest.swift#L769-L772
We expect two runs, with 10ms in between, to occur. We wait 0.05s (50ms) for that to happen before we time out. It's totally possible for a machine that is running with limited resources to fail to meet this target. The fact that you're not successfully reproducing this elsewhere suggests that a useful first step may be to just double the amount of time we're willing to wait to 100ms and see if that resolves the issue.

I'll patch the test on my Android CI as you suggest, and report back next week with the results.

Shiny, I really appreciate that! :pray:

I think you can go ahead and merge your fix: I've now run the NIO tests 23 times on the Android CI with it, buttaface/swift-android-sdk@1c5f71b, without this test flaking once (should have run more but an unrelated trunk stdlib bug caused problems running the NIO tests against the trunk toolchain, until I pulled in the upstream patches to my CI).


better diagnostics for networking errors

motivation: improved user experience
change: override the default description of nserror (in registry client only) and produce a more user friendly diagnostics

@swift-ci smoke test

@swift-ci smoke test

@swift-ci smoke test windows

@swift-ci test windows

windows failure unrelated - @compnerd aware

CC: @etcwilde


Error when running

Traceback (most recent call last):
File "C:\M-Tech\projects\mtech\lib\site-packages\PIL\Image.py", line 3231, in open
fp.seek(0)
AttributeError: 'numpy.ndarray' object has no attribute 'seek'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "C:\M-Tech\projects\ESRGAN\deblur.py", line 6, in
result = depixelate.apply(original_image, 7, 600)
File "C:\M-Tech\projects\mtech\lib\site-packages\depixelate.py", line 10, in apply
pil_image = Image.open(image).convert('RGBA')
File "C:\M-Tech\projects\mtech\lib\site-packages\PIL\Image.py", line 3233, in open
fp = io.BytesIO(fp.read())
AttributeError: 'numpy.ndarray' object has no attribute 'read'. Did you mean: 'real'?

Hey man! Thanks for your time and sorry for the huge delay!
A fix was commited to the branch created for that issue. It would be amazing if you could take a time to test it and check if it's resolved in your case.

Thank you for the update (and the package) - I can confirm that this solved the issue at least for me.


What to cite for this algorithm

Thank you very much for the effort put into QSM.jl! I am the developer of QSMxT (an automated pipeline for processing QSM across large BIDS datasets from DICOMs, including segmentation, etc) and have started to integrate QSM.jl on a development branch as an option (in addition to NeXtQSM and TGV-QSM).
I was wondering how QSM.jl should best be cited, as QSMxT generates a list of references depending on the algorithms used.

Ah, I found that this is already documented in the function comments. :grin:


[JS] Topic: Events in JavaScript

Description 📜
Created a document on Events in JavaScript
Fixes #2319

Type of change 📝

[x] Documentation (Content Creation in the form of codes or tutorials)

Domain of Contribution 📊

[x] JavaScript

Checklist ✅

[x] I follow Contributing Guidelines & Code of conduct of this project.
[x] I have performed a self-review of my own code or work.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[x] I'm GWOC'21 contributor

Screenshots / Gif (Optional) 📸

@paramsiddharth @s4-2 @Creatoon @dakshsethi please review this PR

@dakshsethi Write a generalized example, and show, who is event listener, who is event handler and what's the event, also briefly describe event listener and handler

@sushovanb02
Write a generalized example, and show, who is event listener, who is event handler and what's the event, also briefly describe event listener and handler

ok

Add all events with their links.

@dakshsethi done, now you may check

@paramsiddharth all reviews done i guess you can merge this now


Update docs to  suggest buying PVC cards directly from Brainstorm ID

They haven't been available on Amazon for awhile. It looks like you can only buy packs of 50 too.

You wouldn't have a good link for Europe?


treewide: use new cargo fetcher

Already done. We should run nixpkgs-review to check if some package have different Cargo.lock when building and in nixpkgs, like veloren.
I have writen a script to update it automatically.
Now It can solve:

cargoLock = {
  lockFile = xxx;
  outputhahes = {xxx};
};

cargoLock.lockFile = xxx;
cargoLock.outputHashes = {xxx};

Script: https://github.com/Bot-wxt1221/cargo-rename
Usage:
Compile with gcc. Make sure fetch-cargo.py is in the same path. Exec with a xx/pkgs/by-name/xx/xx/package.nix
cc https://github.com/NixOS/nixpkgs/issues/327063
https://github.com/NixOS/nixpkgs/pull/349360
Step to reduce:

Generate a file list with cargoLock:

rg "cargoLock" --files-with-matches > filewithcargoLock

cat filewithcargoLock | rev | cut -d / -f 2|rev > packagename

run update-all

useFetchCargoVendor

[ ] Squash all commit

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage

[ ] Tested basic functionality of all binary files (usually in ./result/bin/)

25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@ofborg build libconfig  hocon xdg-desktop-portal-cosmic

Unfortunately more concurrent jobs will just seen as a bot spam by GitHub and other servers, so the requests will error out (403).
This was the motivation behind https://github.com/NixOS/nixpkgs/pull/356539/commits/9fd5a8d09d881c23f056d4573ca8be8675b1b303 as Ofborg wasn't able to fetch the git dependencies properly hitting 403.

@JohnRTitor I don't mean we should allow it run at 100 or similar thread. But I find that if we allow it retry for 10 times, even though I run 100 thread, I doesn't meet error.

if we set max-retries time to 10

CC @TomaSajt, could this fix the issues encountered in https://github.com/NixOS/nixpkgs/pull/356385#issuecomment-2483488407?

I wouldn't be against a retry system, but I don't think we should up the thread numbers by much.
Speed was not really a concern for me, since you're only going to build the FOD once or twice in normal circumstances.

Looks like the current script can't handle cases where upstream doesn't have the lockfile. This means that we can't just blindly assume that having outputHashes present means that it can be migrated.

@Tomahna We can run nixpkgs-review to check what package can't be built and remove them.

@Tomahna We can run nixpkgs-review to check what package can't be built and remove them.

Probably pinged the wrong person.
Also, these would probably result in eval errors.
If you look at the nixpkgs-vet CI jobs you can see which packages fail.

@TomaSajt Actually still 140 package are planned to move. So I'll do it after it.

FYI qsv is already being updated to the new fetcher in https://github.com/NixOS/nixpkgs/pull/356504 - no need for 0027ca3 (#356862).

Now I have searched "./Cargo.lock" and remove their commit.

@Atemu That should be done later because now it is easier to drop one commit if it is invalid.

Nice, this saves roughly 20% of the repository!
>>> (841569 / 4075843) * 100
20.647728580320685

@JohnRTitor The problem you mentioned can be solved if we allow it retris for 10 times.

@Atemu That should be done later because now it is easier to drop one commit if it is invalid.

Yep, we can just squash merge this PR.

The path should be different now. But not really bad, I'm running nixpkgs-review.

Could you seperate into https://github.com/NixOS/nixpkgs/pull/356862/commits/6905f1e1fc691de7ca768fb601c2d36941475369 another PR?
This way we can just squash merge this PR, without having you squash the commits yourself.
Or you can just squash all commits except that one and force push.

To be honest, I'm also more in favor of multiple smaller PRs. We're not rushing anywhere.
It would also be much easier to review.

About nixfmt:
I can split the nixfmt commit into one.
About reduce:
I have opened my script. Anyone can reduce it.
About split into smaller PRs:
It won't make the work more easier. We still need to recompile every package by hand or by nixpkgs-review in smaller PR.

@Bot-wxt1221 Maybe you can do a pull request chain? I.e just branch off every after X commits and make a new pull request depending on the previous one? That hopefully is an acceptable management overhead for both sides. Maybe 20 packages per pull request could work.

Will split into multi PR. I will open an issue to track it.

https://github.com/NixOS/nixpkgs/issues/357257


Add code splitting at routes

See https://gist.github.com/gaearon/fbd581089255cd529e62
It would be nice to code-split the routes, so not all routes get included in the bundle.js file and only get loaded conditionally.
The question is if we can do that automatically without any further user intervention.

Note: If you submit a PR, do it against the v3.0.0 branch please!

Maybe one of the official webpack examples is nicer to use from a user perspective? https://github.com/webpack/webpack/tree/master/examples

Done in the v3.0.0 branch!


How do I download just the webm's from a playlist?

[x] I'm asking a question
[x] I've looked through the README and FAQ for similar questions
[x] I've searched the bugtracker for similar questions including closed ones

Question
How do I download just the webm's from a playlist? vlc plays webm's just fine and I am using too much download bandwith.

Hi. Your question is a bit unclear. Here is my guess, let me know if that is correct:

You are using Youtube
You have a playlist (https://www.youtube.com/playlist?list=...)
You want to download only the audio ..
.. of all the videos in the playlist

if that's the case, first you should check what formats are available on those videos. For that:youtub-dl -F https://your-url-here`
It will list all format available for each video. Then, select the one that fits you (I would guess 251, that is webm audio only or correct quality), and input youtube-dl -f 251 https://your-url-here. Note the lowercase f, compared to the uppercase from before.
Obviously, replace 251 by any other number that matches your wish, from the list that was outputed by the first command.
Hope that helps. LMK if I misunderstood your question.

I want to download a playlist in the background (it is quite large), and
only in a format which doesn't have to be recombined.  I think vlc plays
webm's just fine. So -F (assuming it works) would prompt me on every video.
On Thu, Jul 23, 2020 at 5:49 AM Olivier Cloux<EMAIL_ADDRESS>wrote:

Hi. Your question is a bit unclear. Here is my guess, let me know if that
is correct:

You are using Youtube
You have a playlist (https://www.youtube.com/playlist?list=...)
You want to download only the audio ..
.. of all the videos in the playlist

if that's the case, first you should check what formats are available on
those videos. For that:youtub-dl -F https://your-url-here`
It will list all format available for each video. Then, select the one
that fits you (I would guess 251, that is webm audio only or correct
quality), and input youtube-dl -f 251 https://your-url-here. Note the
lowercase f, compared to the uppercase from before.
Obviously, replace 251 by any other number that matches your wish, from
the list that was outputed by the first command.
Hope that helps. LMK if I misunderstood your question.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ytdl-org/youtube-dl/issues/26088#issuecomment-662917010,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AL73FMYZMO7L4QVWIBEZHYDR5ABTFANCNFSM4PFITGSQ
.

read https://github.com/ytdl-org/youtube-dl#format-selection.

So -f 'best[ext=webm]' ??


Update dependency?

@babel/plugin-syntax-dynamic-import
Are there plans to use the package on the newer babel namespace?

That's for babel 7, which isn't fully released yet; when it is, we'll become compatible with it.


Can I take parameters after the url?

qrCode, _ := qr.Encode('http://www.aa.com?a=123', qr.M, qr.Auto)
Scan the QR code and open it with a browser. The request address becomes https://www.aa.com/?a=123

qrCode, _ := qr.Encode('http://www.aa.com?a=123', qr.M, qr.Auto)
Scan the QR code and open it with a browser. The request address becomes https://www.aa.com/?a=123

qrCode, _ := qr.Encode('http://www.aa.com?a=123', qr.M, qr.Auto)
Scan the QR code and open it with a browser. The request address becomes https://www.aa.com/?a=123
Why is the question mark preceded by a slash and http becomes https?
I look forward to hearing from you.

Hi,
the barcode lib does not any kind of string processing. so the text is correctly encoded. I guess the reader does some post-processing since your text is not a valid url.
Kind regards.

Here is why:
$ curl -I http://www.aa.com?a=123
HTTP/1.1 301 Moved Permanently
Server: AkamaiGHost
Content-Length: 0
Location: https://www.aa.com/?a=123
Date: Mon, 19 Nov 2018 19:34:59 GMT
Connection: keep-alive
Set-Cookie: aka_cr_code=US-; path=/; secure
X-Frame-Options: SAMEORIGIN
Set-Cookie: akavpau_www_aafullsite=1542656399~id=0451c2a4a5f8cc33e5dd3da2eab0746a; Path=/


Add mergeStyles plugin

This PR adds the mergeStyles plugin that merges <style> elements into one,
preserving media queries by the <style> media attribute.
You can already try this feature branch by installing it using this npm command:
npm install github:strarsis/svgo#mergeStyles-plugin
The plugin would also be enabled by default in this PR as it can help with compression by subsequent plugins.

@strarsis can you rebase this and adapt it to the recent code changes?

Still something wrong with the branch. I create a new one.

@XhmikosR: New PR branch: https://github.com/svg/svgo/pull/1381

You can always do git rebase -i and resolve any conflicts in the future instead of making a new branch/PR :)


Runtime status not showing when in component editor

Top left corner, where it usually says 'connected' etc is just blank.
When going to edit a graph it shows up again.
Tested on git master, on commit 87d150e3b5e

Still happens in 0.15.0

It does show when opening a component from a graph:

So how is that different from opening a component using the sidebar?


fix(deps) fixed bcrypt lua module compilation

Building latest docker container has an error when trying to compile bcrypt Lua
bcrypt 2.1-6 depends on lua >= 5.1 (5.1-1 provided by VM)
Warning: variable CFLAGS was not passed in build_variables
gcc -I/usr/local/openresty/luajit/include/luajit-2.1 -DOPENSSL_cleanse=explicit_bzero -Icompat/include -Wall -Wno-pointer-sign -O2 -fPIC -DNDEBUG -O0 -c -o compat/safebfuns.o compat/safebfuns.c
gcc -I/usr/local/openresty/luajit/include/luajit-2.1 -DOPENSSL_cleanse=explicit_bzero -Icompat/include -Wall -Wno-pointer-sign -O2 -fPIC -DNDEBUG   -c -o compat/bcrypt/bcrypt.o compat/bcrypt/bcrypt.c
compat/bcrypt/bcrypt.c: In function 'bcrypt_hashpass':
compat/bcrypt/bcrypt.c:185:37: warning: 'snprintf' output may be truncated before the last format character [-Wformat-truncation=]
  185 |  snprintf(encrypted, 8, "$2%c$%2.2u$", minor, logr);
      |                                     ^
compat/bcrypt/bcrypt.c:185:2: note: 'snprintf' output between 8 and 9 bytes into a destination of size 8
  185 |  snprintf(encrypted, 8, "$2%c$%2.2u$", minor, logr);
      |  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
gcc -I/usr/local/openresty/luajit/include/luajit-2.1 -DOPENSSL_cleanse=explicit_bzero -Icompat/include -Wall -Wno-pointer-sign -O2 -fPIC -DNDEBUG   -c -o compat/bcrypt/blowfish.o compat/bcrypt/blowfish.c
gcc -I/usr/local/openresty/luajit/include/luajit-2.1 -DOPENSSL_cleanse=explicit_bzero -Icompat/include -Wall -Wno-pointer-sign -O2 -fPIC -DNDEBUG   -c -o compat/arc4random/arc4random.o compat/arc4random/arc4random.c
gcc -I/usr/local/openresty/luajit/include/luajit-2.1 -DOPENSSL_cleanse=explicit_bzero -Icompat/include -Wall -Wno-pointer-sign -O2 -fPIC -DNDEBUG   -c -o compat/sha/sha512.o compat/sha/sha512.c
gcc -I/usr/local/openresty/luajit/include/luajit-2.1 -DOPENSSL_cleanse=explicit_bzero -Icompat/include -Wall -Wno-pointer-sign -O2 -fPIC -DNDEBUG   -c -o compat/getentropy/getentropy_linux.o compat/getentropy/getentropy_linux.c
compat/getentropy/getentropy_linux.c:52:10: fatal error: linux/types.h: No such file or directory
   52 | #include <linux/types.h>
      |          ^~~~~~~~~~~~~~~
compilation terminated.
make: *** [<builtin>: compat/getentropy/getentropy_linux.o] Error 1

Error: Failed installing dependency: https://luarocks.org/bcrypt-2.1-6.src.rock - Build error: Failed building.
Kong version: Kong Enterprise <IP_ADDRESS>-dev

After the fix

bcrypt 2.1-6 depends on lua >= 5.1 (5.1-1 provided by VM)
Warning: variable CFLAGS was not passed in build_variables
gcc -I/usr/local/openresty/luajit/include/luajit-2.1 -DOPENSSL_cleanse=explicit_bzero -Icompat/include -Wall -Wno-pointer-sign -O2 -fPIC -DNDEBUG -O0 -c -o compat/safebfuns.o compat/safebfuns.c
gcc -I/usr/local/openresty/luajit/include/luajit-2.1 -DOPENSSL_cleanse=explicit_bzero -Icompat/include -Wall -Wno-pointer-sign -O2 -fPIC -DNDEBUG   -c -o compat/bcrypt/bcrypt.o compat/bcrypt/bcrypt.c
compat/bcrypt/bcrypt.c: In function 'bcrypt_hashpass':
compat/bcrypt/bcrypt.c:185:37: warning: 'snprintf' output may be truncated before the last format character [-Wformat-truncation=]
  185 |  snprintf(encrypted, 8, "$2%c$%2.2u$", minor, logr);
      |                                     ^
compat/bcrypt/bcrypt.c:185:2: note: 'snprintf' output between 8 and 9 bytes into a destination of size 8
  185 |  snprintf(encrypted, 8, "$2%c$%2.2u$", minor, logr);
      |  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
gcc -I/usr/local/openresty/luajit/include/luajit-2.1 -DOPENSSL_cleanse=explicit_bzero -Icompat/include -Wall -Wno-pointer-sign -O2 -fPIC -DNDEBUG   -c -o compat/bcrypt/blowfish.o compat/bcrypt/blowfish.c
gcc -I/usr/local/openresty/luajit/include/luajit-2.1 -DOPENSSL_cleanse=explicit_bzero -Icompat/include -Wall -Wno-pointer-sign -O2 -fPIC -DNDEBUG   -c -o compat/arc4random/arc4random.o compat/arc4random/arc4random.c
gcc -I/usr/local/openresty/luajit/include/luajit-2.1 -DOPENSSL_cleanse=explicit_bzero -Icompat/include -Wall -Wno-pointer-sign -O2 -fPIC -DNDEBUG   -c -o compat/sha/sha512.o compat/sha/sha512.c
gcc -I/usr/local/openresty/luajit/include/luajit-2.1 -DOPENSSL_cleanse=explicit_bzero -Icompat/include -Wall -Wno-pointer-sign -O2 -fPIC -DNDEBUG   -c -o compat/getentropy/getentropy_linux.o compat/getentropy/getentropy_linux.c
gcc -I/usr/local/openresty/luajit/include/luajit-2.1 -DOPENSSL_cleanse=explicit_bzero -Icompat/include -Wall -Wno-pointer-sign -O2 -fPIC -DNDEBUG   -c -o src/main.o src/main.c
src/main.c:24: warning: "luaL_newlib" redefined
   24 |  #define luaL_newlib( L, l ) ( lua_newtable( L ), luaL_register( L, NULL, l ) )
      |
In file included from src/main.c:21:
/usr/local/openresty/luajit/include/luajit-2.1/lauxlib.h:125: note: this is the location of the previous definition
  125 | #define luaL_newlib(L, l) (luaL_newlibtable(L, l), luaL_setfuncs(L, l, 0))
      |
gcc -o bcrypt.so compat/safebfuns.o compat/bcrypt/bcrypt.o compat/bcrypt/blowfish.o compat/arc4random/arc4random.o compat/sha/sha512.o compat/getentropy/getentropy_linux.o src/main.o -shared -lrt
bcrypt 2.1-6 is now installed in /usr/local (license: ISC)

kong 2.6.0-0 depends on lpeg_patterns 0.5 (0.5-0 installed)
kong 2.6.0-0 depends on http 0.3 (not installed)
Installing https://luarocks.org/http-0.3-0.src.rock

http 0.3-0 depends on lua >= 5.1 (5.1-1 provided by VM)
http 0.3-0 depends on compat53 >= 0.3 (0.8-1 installed)
http 0.3-0 depends on bit32 (<IP_ADDRESS>-1 installed)
http 0.3-0 depends on cqueues >= 20161214 (20200726.51-0 installed)
http 0.3-0 depends on luaossl >= 20161208 (20200709-0 installed)
http 0.3-0 depends on basexx >= 0.2.0 (0.4.1-1 installed)
http 0.3-0 depends on lpeg (1.0.2-1 installed)
http 0.3-0 depends on lpeg_patterns >= 0.5 (0.5-0 installed)
http 0.3-0 depends on binaryheap >= 0.3 (0.4-1 installed)
http 0.3-0 depends on fifo (0.2-0 installed)
http 0.3-0 is now installed in /usr/local (license: MIT)

Checking stability of dependencies in the absence of
http 0.4-0...

Removing http 0.4-0...
Removal successful.
kong 2.6.0-0 depends on lua-resty-worker-events 1.0.0 (1.0.0-1 installed)
kong 2.6.0-0 depends on lua-resty-healthcheck 1.4.2 (1.4.2-1 installed)
kong 2.6.0-0 depends on lua-resty-cookie 0.1.0 (0.1.0-1 installed)
kong 2.6.0-0 depends on lua-resty-mlcache 2.5.0 (2.5.0-1 installed)
kong 2.6.0-0 depends on lua-messagepack 0.5.2 (0.5.2-1 installed)
kong 2.6.0-0 depends on lua-resty-openssl 0.8.1 (not installed)
Installing https://luarocks.org/lua-resty-openssl-0.8.1-1.src.rock

lua-resty-openssl 0.8.1-1 is now installed in /usr/local (license: BSD)

Checking stability of dependencies in the absence of
lua-resty-openssl 0.7.4-1...

Removing lua-resty-openssl 0.7.4-1...
Removal successful.
kong 2.6.0-0 depends on lua-resty-counter 0.2.1 (0.2.1-1 installed)
kong 2.6.0-0 depends on lua-resty-template 1.9 (not installed)
Installing https://luarocks.org/lua-resty-template-1.9-1.src.rock

lua-resty-template 1.9-1 depends on lua >= 5.1 (5.1-1 provided by VM)
lua-resty-template 1.9-1 is now installed in /usr/local (license: BSD)

kong 2.6.0-0 depends on lua-resty-passwdqc 1.1 (not installed)
Installing https://luarocks.org/lua-resty-passwdqc-1.1-1.src.rock

lua-resty-passwdqc 1.1-1 depends on lua >= 5.1 (5.1-1 provided by VM)
lua-resty-passwdqc 1.1-1 is now installed in /usr/local (license: BSD)

kong 2.6.0-0 depends on lua-resty-ipmatcher 0.6.1 (0.6.1-0 installed)
kong 2.6.0-0 depends on lua-resty-acme 0.7.2 (not installed)
Installing https://luarocks.org/lua-resty-acme-0.7.2-1.src.rock

lua-resty-acme 0.7.2-1 depends on lua-resty-http >= 0.15-0 (0.16.1-0 installed)
lua-resty-acme 0.7.2-1 depends on lua-resty-lrucache >= 0.09-2 (0.09-2 installed)
lua-resty-acme 0.7.2-1 depends on lua-resty-openssl >= 0.7.0 (0.8.1-1 installed)
lua-resty-acme 0.7.2-1 is now installed in /usr/local (license: BSD)

Checking stability of dependencies in the absence of
lua-resty-acme 0.7.1-1...

Removing lua-resty-acme 0.7.1-1...
Removal successful.
kong 2.6.0-0 depends on lua-resty-session 3.8 (3.8-1 installed)
kong 2.6.0-0 depends on kong-plugin-azure-functions ~> 1.0 (1.0.1-1 installed)
kong 2.6.0-0 depends on kong-plugin-zipkin ~> 1.4 (1.4.1-1 installed)
kong 2.6.0-0 depends on kong-plugin-request-transformer ~> 1.3 (1.3.2-0 installed)
Stopping after installing dependencies for kong 2.6.0-0

Kong version: Kong Enterprise <IP_ADDRESS>-dev

Building latest docker container has an error when trying to compile bcrypt Lua

@segabond what version would that be? How can I reproduce?

@segabond ping

since we're now at Pongo 2, closing this.


Add lowercase versions of $NETWORK and $USER

This lets people at least work around #13, I'm not sure I'd go so far as to say it fixes it.

Seems legit


Dispose on settle

Codecov Report

Merging #7 (b2eb41d) into main (56630c9) will decrease coverage by 3.36%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main       #7      +/-   ##
==========================================
- Coverage   85.71%   82.35%   -3.37%
==========================================
  Files           2        2
  Lines          14       17       +3
==========================================
+ Hits           12       14       +2
- Misses          2        3       +1

Impacted Files
Coverage Δ

lib/LruCache.js
80.00% <66.66%> (-3.34%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56630c9...b2eb41d. Read the comment docs.


Great article

If possible, please upload applied settings ,with screenshots.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 89a6189e-5f83-9a61-3700-aca7c8f0e874
Version Independent ID: 31baf625-0f4e-71ab-7f8f-356d29365bad
Content: Step 5 - Security and Compliance Considerations
Content Source: microsoft-365/enterprise/step-5-security-and-compliance.md
Service: o365-solutions
GitHub Login: @JGruszczyk
Microsoft Alias: jogruszc

Hi - what applied settings are you referring to that you would like to see screen shots of? Thanks!

yes sir,  screenshots please, so that I can get some ideas , to apply or modify the settings.
Thanks for reply sir


add a mode to list images for mirroring?

right now all images are given ❌ or ✅  based only on if they're on a non-deprected host or else a non-kubernetes-project host.
for registry.k8s.io we could use a tool to print a list of images the user should mirror, it seems like we have most of the infrastructure here already.
is this something that makes sense, or something we should do elsewhere?
we'd probably also want an option like -q / --quiet to just print one mirror-worthy image per line, deduped, with no other formatting for piping to scripts, vs a fancy mode for human viewing

Done!
/close


Preemptible instances issues (6.0.0.rc.0)

We use preemtible instances in GKE and sometimes the voyager haproxy is not correctly changing the desired pod.

When this happens, can you check the following things:

Is the backend service updated but HAProxy config is not updated?
Can you check the logs for Voyager operator to see if it received update events for the backend service?
Does this take around 10 mins to update when there is a delay?

yes, backend is updated, Haproxy not
will check
no, it is not updated never.

What is the version of your Kubernetes cluster ? Can you please show the output of kubectl version ?

Closing, since no response. Please reopen if  you have more info.


Soft-DTW Barycenter init parameter isn't documented

See the docs.

Good call. I just inspected the source-code to figure out what it is used for (note that I don't even know what a Barycenter is, so this is just a guess).
    if init is None:
        if check_equal_size(X_):
            barycenter = euclidean_barycenter(X_, weights)
        else:
            resampled_X = TimeSeriesResampler(sz=X_.shape[1]).fit_transform(X_)
            barycenter = euclidean_barycenter(resampled_X, weights)
    else:
        barycenter = init

So I guess the init-parameter is used when you already pre-computed this guy called Barycenter, else, it will calculate it for you.

Thanks for the report. Should be fixed now.

Thanks @rtavenar!
@GillesVandewiele, you're correct. A barycenter is just a average (aka mean, center) of a time-series sample. The use of barycenter in this package most likely stems from one of the more tractable averaging algorithms that uses the DTW measure, DBA (DTW Barycenter Averaging).


.Net: Update sk version in notebook samples

Description

Thanks @N-E-W-T-O-N for the updates.  A new dotnet preview was released hours after you created this PR.  Could you please update your changes to use the new release?
See: https://github.com/microsoft/semantic-kernel/releases/tag/dotnet-0.20.230821.4-preview

Thanks @N-E-W-T-O-N for the updates. A new dotnet preview was released hours after you created this PR. Could you please update your changes to use the new release?
See: https://github.com/microsoft/semantic-kernel/releases/tag/dotnet-0.20.230821.4-preview

similarly for python, our latest release is now 0.3.9

See PR #2620 for dotnet notebook sk version update.
Python notebooks not yet updated.


Fails to read this image

The reader fails to read this image. I'm certain the parameters are correct.
let decoded = jsQR.decodeQRFromImage(qrCode, this.metrics.width, this.metrics.height);

No error is thrown. Only the decoded variable returns empty string.

It's expected to read: BAgAXA==Hhwpy/63yP6bwt1xKDRSAQRpokbYNTsVUX7EZ++mscvjLf0MawexNDY5CKlvcwf/DJosqOpakMLKgxzbEbw/E3wkSK9/

Hey @iShafayet - Thanks for the report. This is pretty cut and dry code - it should definitely decode. I've created a test case for this in #35. My hope is that #31 will fix, and if not one of the rewrites down the line will fix for sure.
(For context we're currently refactoring the code to fix some bugs like this).
I'll close this out when the test passes.