Support for crams and singular inputs

Supports being passed in just one file
Supports cram files
Asserts a reference genome is provided if running on a cram
Will index bam inputs, but not bams that have been provided an index, nor crams, which don't need to be indexed

On one hand I'm proud of the fact my complicated logic is functional on local devices, and want to keep this branch up should I ever need to create complicated WDLs that rely on previous tasks that may or may not have run. WDL's lack of else statements and inability in determining if different if statements are mutually exclusive, combined with its check against duplicated outputs, lead to a very interesting programming exercise that require that I think out of the box and learn a lot more nifty tricks.
On the other hand it does not work on Terra and is an affront to creation, so I'm going to close this PR.


small grammar fix (you -> your) in README

"GitHub for storing you YARA rules" becomes "GitHub for storing your YARA rules"

@googlebot I signed it!


Update softprops/action-gh-release to Node20 version when released

<EMAIL_ADDRESS>(the latest version) is using node16, which has been deprecated in GH Actions
The source repo of this action has been updated but a new version hasn't been published yet

Note, there is a workaround for using an unreleased version of the GH Action, but I'd rather wait for an official release since GH is still supporting node16 actions for now

should be fixed by 45110615a868d33578bd07c111dc8cb78e092750, validating on next release


fix UnexpectedToken handling exception

I don't know if this is the correct solution but it fixes the case described below
👇🏽
with a grammar like:
display_decimals: "DECIMALS"i WS INT
start: display_decimals
%import common (INT, WS)

and a script like
script = """
      bla
"""

It raises
*** AttributeError: 'lark_cython.lark_cython.LexerThread' object has no attribute '_Token'

This PR handle the right exception when the token is wrong rather than raising an Attribute error.

Hi @erezsh sorry, but I was wondering if there's any chance I can get a code review here?

Ok it seems that you have covered this on the latest PR you've merged. Should I delete this or we can keep at least the test?

Sorry that I didn't attend to this earlier.
If you think the test is still valuable, I don't mind adding it. But I don't like testing for specific errors strings, since they can change for a variety of good reasons.

I will close it then


There is no license and contribution file.

Description
License and contribution files do not exist. The links in the README direct to a 404 error page.

Link to Reproduction (or Detailed Explanation)
Go to the README footer and check the links in the contribution and license section.
Steps to Reproduce

Go to the README footer
Go to the links provided in the contribution and license section

Ark UI Version
1
Framework

[ ] React
[ ] Solid
[ ] Vue

Browser
No response
Additional Information
No response

@cosmoart
Thanks


Version in Firmware Field?

A minor enhancement request to update the Indigo Firmware field in the UI from the UniFi Version state for UniFi devices..
Thanks for the ongoing updates. :)

Sounds reasonable.

Any idea how to set that field?  I can't find any reference to it.

Nevermind, I found it.  In next release.


Unit Test: SQLiteHandler

Zero testing for this key script, need to add meaningful unit tests:

I got this


Repair run target

The target depended on build which was removed in
b4d471ed4a8b28a048fcf62eb79eeffe0d1e9ba8 to compile the binary.
Now the run target requires on quick which builds the binary as well.
Also, I removed the redundant cding into cmd/rwtxt because the path can
be passed to go build.
Note that quick should be renamed to rwtxt because this is the file the
target produces.  But, this change is outside the scope of this PR.

Okay great, thanks!

Okay great, thanks!


Tracking issue for self-hosted support

Ah, I was so excited to be able to escape the horrific Jira UI, but alas I see this project doesn't support self-hosted instances. 😢
Not sure what the API differences are but maybe I can lend a hand.
How about a tracking issue?

Hi @cedws, thank you for opening the tracking issue.
First thing we need to do is to figure out which of the current features already works in the local installation. I think some of the features should just work with little to no modifications. Once we have the list of possible issues we need to fix, we can visit them one by one.
To start with this first step, we need to make the jira init command work. However, this step can be bypassed by writing the config file manually ($HOME/.jira/.config.yml by default, we can provide a custom path with XDG_CONFIG_HOME env).
board:
  id: <board id, eg: 1>
  name: Board # default board
  type: scrum
epic:
  field: customfield_10011 # custom field name for the epic
issue: # issue types, these info can be fetched from this endpoint https://developer.atlassian.com/cloud/jira/platform/rest/v3/api-group-issues/#api-rest-api-3-issue-createmeta-get
  types:
  - id: "10002"
    name: Task
    subtask: false
  - id: "10003"
    name: Sub-task
    subtask: true
  - id: "10001"
    name: Story
    subtask: false
  - id: "10004"
    name: Bug
    subtask: false
  - id: "10000"
    name: Epic
    subtask: false
login<EMAIL_ADDRESS># login email
project: PRJ # project key
server: https://example.company.com # server host

It would be great if someone can help with this part.

I did some tests locally in Jira Software v8.17.1. This PR will allow us to generate config for both Cloud and Local installations.
I realized that v8.17.1 doesn't support Jira API v3. Features that depend on v1/v2 version of the API seem to be working fine. If the same data is available in v2 and v3 versions, we can adjust the codebase to use v2 instead of v3 to make some commands work. But for features that require mandatory v3, it may not be available fully.

Closing in favor of #138


Fix action forks

Pull Request Title
Description
Prevent actions from running on forks.
Type of Change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings

Related Issue(s)
This PR addresses issue #232

Nice catch @metcalfc 👍


Together not returning logprobs for llama-65b and llama-2-70b

Together suggested setting details: true as a workaround, but even with this flag, Together only returns logprobs with the value of 0.

It turns out that Together is returning the logprobs, but the response JSON schema is changed for some reason, which causes HELM to not be able to parse the response.
togethercomputer/llama-2-70b (i.e. the changed JSON schema):
  response: {
    result_type: 'language-model-inference',
    choices: [
      {
        finish_reason: 'length',
        index: 0,
        logprobs: {
          token_logprobs: [
            -0.6357421875,
            -0.0012521743774414062,
            -0.03607177734375,
            -0.0880126953125,
            -0.013671875
          ],
          tokens: [ '▁w', 'olf', '<0x0A>', '<0x0A>', 'Pass' ],
          top_logprobs: [
            { '▁w': -0.6357421875 },
            { olf: -0.0012521743774414062 },
            { '<0x0A>': -0.03607177734375 },
            { '<0x0A>': -0.0880126953125 },
            { Pass: -0.013671875 }
          ]
        },
        text: 'wolf'
      }
    ],
    request_time: 0.7430341243743896,
    request_datetime:<PHONE_NUMBER>
  }

togethercomputer/llama-2-7b (i.e. what HELM expects):
  response: {
    choices: [
      {
        finish_reason: 'stop_sequence',
        text: 'south east\n',
        token_logprobs: [ -1.0234375, -0.47021484, -0.09625244 ],
        tokens: [ ' south', ' east', '\n' ]
      }
    ],
    request_time: 5.549241542816162,
    request_datetime:<PHONE_NUMBER>
  }

In general, we're not able to compute calibration for most models, since many model providers are no longer giving us logprobs through their APIs.


[QUERY] PartionOwnership contention of EventHub may have correlation of loadBalancingUpdateInterval and partitionOwnershipExpirationInterval parameters

Query/Question
Does the possibility of partition contention has correlation of loadBalancingUpdateInterval and partitionOwnershipExpirationInterval value ?
Sometimes requestedPartitionOwnerships claim the duplicate ownership to specific partition and this cause 412 stauts code.
c.a.m.e.PartitionBasedLoadBalancer Starting next iteration of load balancer
c.a.m.e.PartitionBasedLoadBalancer Number of ownership records 2, number of partitions 2
c.a.m.e.PartitionBasedLoadBalancer Number of active ownership records 0
c.a.m.e.PartitionBasedLoadBalancer Attempting to claim ownership of partition 1
c.p.i.n.p.a.e.s.CacheableCheckpointStore claimOwnership called. requestedPartitionOwnerships:[{partitionId:1,ownerId:be7e7eb3-add0-44df-8638-28f4e4f17ee5,eTag:0x8D8E393D4DD22AE}{partitionId:0,ownerId:be7e7eb3-add0-44df-8638-28f4e4f17ee5,eTag:0x8D8E393D4DC5F2D}{partitionId:1,ownerId:be7e7eb3-add0-44df-8638-28f4e4f17ee5,eTag:0x8D8E393D4DD22AE}]
c.a.m.e.PartitionBasedLoadBalancer Load balancing completed successfully
c.a.m.e.PartitionBasedLoadBalancer Successfully claimed ownership of partition 0
c.a.m.e.PartitionBasedLoadBalancer Successfully claimed ownership of partition 1
c.a.m.e.c.blob.BlobCheckpointStore Couldn't claim ownership of partition 1
com.azure.storage.blob.models.BlobStorageException: Status code 412, "?<?xml version="1.0" encoding="utf-8"?><Error>ConditionNotMet<Message>The condition specified using HTTP conditional header(s) is not met.
Time:2021-03-10T07:13:14.5423939Z</Message></Error>"

We estimate this behavior means that the partition ownership contention happen and it may be happen loadBalancingUpdateInterval and partitionOwnershipExpirationInterval reached same time.
Furthermore I would like to confirm whether we can reduce the possibility of contention event if we tune the partitionOwnershipExpirationInterval and loadBalancingUpdateInterval .
Why is this not a Bug or a feature Request?
I see the LoadBalancing Strategy document and LoadBalancing Strategy minimize the contention but may not be able to avoid it. So this is not a bug I guess.
https://docs.microsoft.com/en-us/java/api/com.azure.messaging.eventhubs.loadbalancingstrategy?view=azure-java-stable#fields
Setup (please complete the following information if applicable):

OS: Windows 10
Version of the Library used: azure-messaging-eventhubs:5.5.0, azure-messaging-eventhubs-checkpointstore-blob:1.5.0

@alzimmermsft  Could you please triage this query?

@conniey, @srnagar could you take a look?

@kekatahi When there are multiple instances of EventProcessorClients running, there's always bound to be contention when the instances are starting up or re-balancing. The contention can be minimized by using the LoadBalancingStrategy.BALANCED strategy.
loadBalancingUpdateInterval also plays a role. If the duration is small, attempts to load balance are made more frequently.
So, when 2 instances try to claim ownership of the same partition, only one of them succeeds and the other gets the 412 error status code and this is expected.
Hope this answers your question.

@srnagar Thank you for checking.
Do you mean If the loadBalancingUpdateInterval is small, the contention frequently happen ?
(Since the re-balance happen more frequently and it seems to increase the contention I guess)

loadBalancingUpdateInterval also plays a role. If the duration is small, attempts to load balance are made more frequently.

@srnagar  If you have any insights, please let me know.

Do you mean If the loadBalancingUpdateInterval is small, the contention frequently happen?
The contention may or may not happen, but having a smaller interval will result in frequent attempts at load balancing and can potentially cause contention.

Load balancing happens periodically even when the partitions are completely balanced but there is no contention in a balanced state. Contention can occur when an instance of the processor is starting up or when an instance has gone down until the balanced state is reached.

@srnagar Thank you!


Text Inputs - Specific Cases

It seems that TEXT INPUTS used as filters only work under the right conditions. The DATA name must be a single name, and all of the values must be lowercase without any spaces.
Unfortunately attribute selectors are case sensitive, so the search input is converted to lowercase before querying the DOM. This makes the searching much more robust from the user's perpective, but requires that your classes or attribute values are well prepared. Ideally, lowercased and stripped of special characters. This shouldn't be an issue if you are outputting these values in your markup dynamically server side.
This is not part of MixItUp but part of the demo implementation: https://github.com/patrickkunka/mixitup/blob/v3/demos/filtering-by-text-input/index.html#L72
Worth nothing that a case-insensitive attribute selector has been recently added to the DOM selectors spec, but is not widely implemented yet outside of Chrome, so this is still the most robust way to implement such functionality.


Implement Ali OSS storage driver

Ali OSS storage http://www.aliyun.com/product/oss/ is another key value blob storage similar as AMZ s3. However, OSS rest api is a little different from AMZ s3 and till now there's no offical golang sdk.
I'd like to implement such docker storage driver
However, would you give me some suggestion? Is it better to put the low leve OSS rest api code together with the driver? Or shall I  introduce as Godep and keep in a separate repository?

Hi @topikachu
Have a look here: #514

Hi, @dmp42
I haven't seen any new activities of #514 and I'm not sure if the author is going to continue this PR.
Will docker accept that one or need a new one?

@topikachu Put together a proposal (in the description of this ticket) for how you will implement and how long you will be able to maintain it. We generally only accept drivers that will be actively maintained for at least a year.

@topikachu
We will continue maintain the OSS driver in Pull Request #514. and we have already used it in several internal projects in Aliyun of Alibaba inc. It is pretty solid now. Is there any feature you are requesting for which cannot be supported by that PR?
Thanks and your comments and suggestions are appreciated.

@denverdino Please compare with #514 with the comments in #443 and #493 for information on the storage driver concerns. The overview in #443 was extremely helpful in getting it merged. Since we don't have any access to these storage systems, we need to ensure that the build integrated with our CI system and there is a maintainer available to debug problems.
Hope that helps in moving this along!

@stevvooe Thanks for your information and I will apply the account for you.

PR #514 was merged, so I'm closing this ticket.


Invalid Docker Compose Healthcheck

The docker-compose.yaml defines a fairly reasonable health check based on the SpringBoot management endpoint, running on port 7979. The MANAGEMENT_PORT environment variable is also set to 7979, which application.properties uses to control the management port used by the server.
The docker-compose.yaml also defines SPRING_PROFILES_ACTIVE=dev making the server use application-dev.properties, which hardcodes the management port to 8000. It's not clear to me why the dev profile should force a particular management port, but there were clearly many attempts to make that the case in the early days.
As a result, when running via the default docker-compose configuration, the health check can never succeed and so the server is always marked "unhealthy".
I'm very tempted to "fix" this by dropping all reference to the management port from the dev profile... if anybody can explain why this is a bad idea then please do so!
(Obviously, another "fix" option is to remove reference to health checks from the docker-compose configuration. This seems like a backwards step to me, but am open to persuasion.)

I think it is fine to have management port 7979 in all cases. @tkrop do you know are there any specific reason why dev management port is 8080?

You can set MANAGEMENT_SERVER_PORT to override the property set in application-dev.properties.


Pkg restructuring

This PR contains the entire pkg restructuring.

ROS and library are separated.
Added a script to run in the docker
Create a basic slam_vdb structure with a separate library and ROS node

slam_vdb
slam_vdb_ros

New CMake structure for slam_vdb and slam_vdb_ros
Added Changelog
Updated README
Updated .gitignore

slam_vdb_ros/CMakeLists.txt line 19 at r1 (raw file):
Previously, mlsdpk (Phone Thiha Kyaw) wrote…
we should be able to use Config mode instead of doing this.

Done.

slam_vdb_ros/CMakeLists.txt line 29 at r1 (raw file):
Previously, mlsdpk (Phone Thiha Kyaw) wrote…
can remove one PUBLIC here

Done.


Obj-C Starscream.WSError. error 1 (AuthRequestBuilder not being called)

I had been using libPusher for iOS pusher handling, but my team and I are recently migrating some of that code over to tvOS, which means we've had to adopt this library instead.
We use a custom auth endpoint, supplied with a header token for channel authorization, and I've been trying to set it up. Either because of my misunderstanding of the configuration flow or something else, I've continually run into connection errors when attempting subscriptions (private channels). I'm also unable to get logs or breakpoints at the requestForSocketID:(NSString *)socketId channelName:(NSString *)channelName; protocol implementation from AuthRequestBuilderProtocol.
I've created a pusher manager class as a singleton with a strong reference to the Pusher client object as well as assigned the singleton as the client's connection delegate. I've created a custom AuthRequestBuilder as the docs suggested but am unable to diagnose the connection issue.
// PusherManager.m
#import "PusherManager.h"
#import "PusherAuthRequestBuilder.h"

@interface PusherManager ()
@end

@implementation PusherManager

+(id)sharedInstance {
    static PusherManager *sharedInstance = nil;
    static dispatch_once_t onceToken;
    dispatch_once(&onceToken, ^{
        sharedInstance = [[self alloc] init];
        NSString *cluster = @"CLUSTER";
        NSString *pusherKey = @"SECRET";
        OCAuthMethod *authRequestBuilder =
            [[OCAuthMethod alloc] initWithAuthRequestBuilder:[[PusherAuthRequestBuilder alloc] init]];
        OCPusherHost *host = [[OCPusherHost alloc] initWithHost:cluster];
        PusherClientOptions *options =
            [[PusherClientOptions alloc] initWithOcAuthMethod:authRequestBuilder
                                                autoReconnect:YES
                                                       ocHost:host
                                                         port:nil
                                                       useTLS:YES
                                              activityTimeout:nil];
        sharedInstance.client = [[Pusher alloc] initWithAppKey:pusherKey options:options];
        sharedInstance.client.connection.delegate = sharedInstance;
        [sharedInstance.client connect];
    });
    return sharedInstance;
}

- (void)debugLogWithMessage:(NSString *)message {
    NSLog(@"%@ WITH CONNECTION STATE %ld", message, self.client.connection.connectionState);
    // [PUSHER DEBUG] Waiting 1.0 seconds before attempting to reconnect (attempt 2) WITH CONNECTION STATE 4
}

// PusherAuthRequestBuilder.m
#import "PusherAuthRequestBuilder.h"
@implementation PusherAuthRequestBuilder
-(NSURLRequest*)requestForSocketID:(NSString *)socketID channelName:(NSString *)channelName {
    NSString *authUrl = @"MY AUTH URL";
    NSURLRequest *request = [[NSURLRequest alloc] initWithURL:[[NSURL alloc] initWithString:authUrl]];
    NSMutableURLRequest *mutableRequest = [[NSMutableURLRequest alloc] initWithURL:[[NSURL alloc] initWithString:authUrl]];
    NSString *dataString = [NSString stringWithFormat:@"socket_id=%@channel_name=%@", socketID, channelName];
    NSData *data = [dataString dataUsingEncoding:NSUTF8StringEncoding];
    mutableRequest.HTTPBody = data;
    mutableRequest.HTTPMethod = @"POST";
    NSString *token = @"MYTOKEN"
    [mutableRequest addValue:[NSString stringWithFormat:@"Bearer %@", token] forHTTPHeaderField:@"Authorization"];
    request = [mutableRequest copy];

    return request;
}
@end

Expected behavior
Connection occurs or passes through requestForSocketId protocol. If that fails allow more robust logging from debugLogWithMessage PusherDelegate method.
Any help would greatly be appreciated. Thank you.

@Mootook Have you confirmed if the client property of your PusherManager.sharedInstance is non-nil at the point where the private channel subscription is attempted? I can't obviously see how it wouldn't be being retained from your code listing, but I'm asking as another user (albeit writing Swift) had a similar issue (i.e. where the requestForSocketId method wasn't being called).
This turned out to be because their Pusher instance had become deallocated, see: https://github.com/pusher/pusher-websocket-swift/issues/274#issuecomment-664191375

@danielrbrowne, The client property is not becoming nil. I've done a similar setup with it being a singleton class with other libraries.
Also, I am getting ocassional logs from debugLogWithMessage:(NSString*)message about the client's connection state after the any subscription flow is run to initialize the singleton. Assuming this is from the reconnect attempt [PUSHER DEBUG] Waiting 64.0 seconds before attempting to reconnect (attempt 9) WITH CONNECTION STATE 4
I did see the example/issue you posted, and just for testing sake I did setup a minified flow on a view controller, but I got the same outcome.

@Mootook I was wondering if you're still seeing this issue in the latest v9.1.1 release? (There's been several improvements over the v8.0.0 release to reconnection logic and error-reporting, as well as the Starscream WebSocket client library dependency being removed).

@Mootook I was wondering if you're still seeing this issue in the latest v9.1.1 release? (There's been several improvements over the v8.0.0 release to reconnection logic and error-reporting, as well as the Starscream WebSocket client library dependency being removed).

@danielrbrowne Hello, sorry but I no longer have the project or means to test this at this time.

@danielrbrowne Hello, sorry but I no longer have the project or means to test this at this time.

Ok thanks for the feedback. Given all the recent changes (which are likely to have made this issue redundant) I'll close the issue for now. Feel free to reopen it if this changes.

Ok thanks for the feedback. Given all the recent changes (which are likely to have made this issue redundant) I'll close the issue for now. Feel free to reopen it if this changes.


Avoid jumps when showing/hiding PR comments

On a pull request, when comments are toggled with i, Github scrolls back to the top of the page, making it difficult to keep on reviewing.
You can try it in this pull request: https://github.com/sindresorhus/refined-github/pull/2087/files

Scroll to a comment
Press i

Currently, I click and hold the scroll bar to avoid the jump but as the page height changes, this is not always ideal.

If anyone comes up with a possible fix, the suggested feature name could be:
fix-toggle-pr-comments-scroll-bug
Related issue: https://github.com/sindresorhus/refined-github/issues/2398
Bug also discussed in https://github.com/sindresorhus/refined-github/pull/2087

Please also send this bug report to GitHub<EMAIL_ADDRESS>

I just tried it and it looks like it was fixed.

It looks like the old bug (as described) has been fixed, but (ugh) in only Firefox, the "visual scroll" position isn't preserved — i.e. when items disappear, the page shortens so you'll end up at the bottom of the page.
In other words: https://stackoverflow.com/questions/18461567/maintain-scrolltop-while-inserting-new-sections-above-the-current-viewed-element
Chrome recently fixed this so users don't see content jumping around when off-screen elements are changed, but Firefox apparently not.
Leaving open in case anyone knows how to fix that.

Closing due to inactivity. Tough bug best resolved by GitHub anyway, if they haven’t already


[New azd-template] Conference AI Assistant: RAG with Azure SQL DB and OpenAI

I've created a RAG sample that is fully AZD compliant:
https://github.com/Azure-Samples/azure-sql-db-session-recommender-v2

PR: https://github.com/Azure/awesome-azd/pull/328


Add three-dot icon for access to Google exposure checks (closes #891)

This PR corrects the FAQ entries:
https://www.coronawarn.app/en/faq/#exposure_check and
My exposure log shows checks for less than 14 days
https://www.coronawarn.app/de/faq/#exposure_check
In den Begegnungsüberprüfungen sind die Aufzeichnungen von weniger als 14 Tagen gespeichert
to resolve the issue described in https://github.com/corona-warn-app/cwa-website/issues/891.
Google changed the UI and has pushed the exposure checks one level deeper, so that it is now necessary to tap the three-dot overflow menu in order to access exposure checks. The three-dot overflow menu is referred to in the FAQ as "three-dot icon" for better general understanding.
Changes in this PR
changes are marked up in yellow.
EN version

DE version

@MikeMcC399 Many thanks.


FastForward not working at all in Chrome

Domain
https://nude-leaks24.com/
Link
https://nude-leaks24.com/s?cK5l;NSFW
Version
0.2279-Mv3
What browsers are you seeing the problem on?
Chrome
What OS are you seeing the problem on?
Windows
Anything else?
These folllowing domains don't work either:
locconnect.com
linkvertise.com
locconn.com

the firefox mv3 version instantly sent me to a pastelink.net which I believe is the target

Duplicate of #963.


1.1.0 breaks preserveScrollPosition

I have a controller which sets toe preserveScrollPosition to true. If I install version 1.1.0 of this add-on and enter that route, the page scrolls to the top.
If I downgrade to 1.0.2, then the scroll position stays at the position where it has been previously.
It looks like this is related to how ember +3.6 is being handled differently since version 1.1.0
https://github.com/dollarshaveclub/ember-router-scroll/blob/24799d770e200a605e001dd79cec4169e353afb1/addon/index.js#L63
in get(transition, 'handler.controller.preserveScrollPosition') handler is undefined, therefore we are not able to retrieve preserveScrollPosition from the controller

From debugging it looks like we are able to get the information we need for ember +3.6 in this way:
preserveScrollPosition = transition.intent.router.currentRouteInfos.some((routeInfo) => get(routeInfo, 'route.controller.preserveScrollPosition'));

Even though this seems to fix the issue, I am a little unsure if this really only uses public apis. For instance I failed to find the intent property on the Transition object within the documentation.


Feature: Allow SelectedTo to contain full row value

It would be nice if the array of selected items could contain more than just the ID

@Jigsaw5279 That would be risky for memory management.
It is designed to help you keep track of the selected row(s) across the whole data set, so that you can decided to do whatever you want later (using those ids). So, it was a design choice for me to keep only the id that it would not cost too much in term of memory usage.
On one hand, if you are only interested in the selected row of the current page, the data should already be in the memory and you can access them via tableData prop.
On the other hand, if the selected rows are across multiple pages and when you decided to do something with them, I think those ids should be sent to be processed on the server side.
Personally, I believe that the client side should only work with the presentation/interaction with end user. Any other business logic should be handled on the server side. :)

Yea, I kniw about the risks of memory leakage.. But I've made a component that'll display a dropdown of actions. And I wanted to make it aware of the data that is about to be transformed.
For example, I've got a table of aacounts, wich are either enabled or disabled. It makes no sense to activate the "Activate" option, if there are only active acccounts selected.
I did so using a callback that is passed the array of currently selected Items. But so far, the only thing I can do is see if the size is > 0 cause all it contains are IDs.
Maybe it would be nice to have an event that fires when the selection changes to give you all the items needed?

@Jigsaw5279 Hmm, I don't quite see the picture. But does this one helps?

I might get it to work that way, at least I hope so


Better and easier new dataset adaptation

Currently when adapting a new dataset with hypogenic, one needs to implement

New data processor class
New Prompt class
New Task class
Which is not easy to use. Ideally, we should make this process automated and new users can add their dataset just by preprocessing their data to a specific format, write their prompts, and run a script.

Done in the latest release.


React and react dom JS files offline

name: React and react dom JS files offline
about: Readme paragraph about how to run react and react dom js files offline
Summary
Readme paragraph about how to run react and react dom js files offline
Motivation
Improves the ability to develop the code for someone who has bad internet or no internet at all as every change the page needs to be rendered and for react.min.js and react-dom.min.js to be re-downloaded from the official CDN. This is just a guide describing how to solve this manually.
Describe alternatives you've considered
N/A
Additional context
Original links:
    <script crossorigin<EMAIL_ADDRESS>    <script crossorigin<EMAIL_ADDRESS>

Closing as unnecessary


Pub deploy fails if out/ is in .gitignore

This issue was originally filed by @butlermatt

What steps will reproduce the problem?

Create a web_ui project.
Use git to keep local working repository. Add out/ to ignore files since it's automatically generated
Use pub deploy

What is the expected output? What do you see instead?
Expect that pub deploy will also deploy files in the out/ directory per non-git related projects.
Instead pub deploy uses git to look for files. Because 'out' is added to .gitignore these files are never found and thus not generated.
What version of the product are you using? On what operating system?
Ubuntu Linux 64-bit
Dart Editor: 0.5.11_r23200
Dart SDK 0.5.11_r23200
Please provide any additional information below.
Because pub uses git ls-files it does not find any entry points in the out/ directory.
I ignore the 'out' directory since it's all autogenerated code and I don't need that in my repository as they are not my working files.

This issue has been moved to dart-lang/pub#565.


Adds UUID type to PostgresDialect

Codecov Report

Merging #96 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master     #96      +/-   ##
=========================================
+ Coverage   92.39%   92.4%   +<.01%
=========================================
  Files         129     129
  Lines        2013    2015       +2
  Branches      116     120       +4
=========================================
+ Hits         1860    1862       +2
  Misses        153     153

Impacted Files
Coverage Δ

sql/src/main/scala/hydra/sql/PostgresDialect.scala
94.33% <100%> (+0.22%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31eaa77...e47ce9e. Read the comment docs.


fix: Lowecase registry and update IMAGE_REGISTRY arg

I'll approve with my limited (non-knowing) understanding of Rust code.
I trust this code.


Mystory

Retry of the pull

@LuxioCrimson if you do not make the requested changes by today at 17:00 I think I will move to another student and come back to you later, sorry. That means you will have to redo the merge anew.

I'm sorry, I need to progress with this. You will have another opportunity later.

Hi @LuxioCrimson
You can attempt to fix the requested changes at any time now.

Closing this as changes will never be made.


STUD-220: Add some backend album support

This is a fairly extensive change that introduces the concept of a "release". A release can be a single, ep, album, or compilation.
In this first iteration of the code, we are still assuming everything is a "single" so no front-end changes need to be made.
We're just moving some things up to the release level that used to be held in the songs table.
It's not really possible to test everything until this code gets deployed to the garage environment. Then we'll have to do extensive testing to make sure we haven't broken anything.
Having this change on the server code should allow us to manually distribute one of our albums from the sample sale to the new system.

@saif-software-developer I'm going to wait to merge this until your PR goes in. Otherwise, you'll have a nasty refactor. I'd rather I have to do a small refactor instead of you on this one.


How do I reuse a map in multiple map divs?

I'm aware that the plugin throws a singleton map. But what I want to do is use the same map for two different views in my ionic project. I want to clear the map when the user switches between the views to make it appear like a new map. I tried using : var map = plugin.google.maps.Map.getMap( ) and map.setDiv('map_canvas1') and map.setDiv('map_canvas2') but was unable to achieve the functionality. Is it something that's possible ? Any help would be appreciated.

Please check this demo-code
https://github.com/mapsplugin/cordova-plugin-googlemaps/issues/432

Thank you @Hirbod. Just wanted to let you know that I was facing the problem because ionic uses angular  ja which doesnot refresh the page on tabs switch. This means that the controller which has the code to load the map did not execute everytime on switching the page. I created buttons like the one on #432 and it works now. Thank you again!

Hi, I understand. Had some of this persistent swtiching problems also on OnsenUI. But I'm sure that Ionic has some events (tabChanged or similar) like OnsenUI has. I'm also listening to this events to reattach my map (which I hide for memory-reasons when not visible)


AMQ-6298: Fixed Spring Import-Package wildcard

The org.springframework wildcard is above the Spring-DM org.springframework.osgi import, causing incorrect OSGi metadata.
https://issues.apache.org/jira/browse/AMQ-6298

Thanks for the PR it has been merged. Do you mind closing this?


Component type

I have a typing error after the last update inside component:
Argument of type '{ is: "th" | "td"; role: string; align: string | null; }' is not assignable to parameter of type '{ is: "th" | "td"; } & ("th" | "td")'.ts(2345)

My is component is a string:
const el = computed(() => props.header ? 'th' : 'td');

<component
    :is="el"
    role="cell"
    :class="$style.tableCell"
    :align="cellAlign"
    :style="cellStyle"
>

I know I can use render function, but this code works and didn't have any typing errors in the past.

v0.25.8 supported <component :is> type-checking, but unhandled pass string value to :is.
Will fix in next version, thanks to report! You can downgrade to v0.25.7 for now.

Fixed in 0.25.9. And recommend you update this code to get correct type-checking with <component>.
const el = computed(() => props.header ? 'th' as const : 'td' as const);


Jerky scrolling with large items

As I scroll up or down, when a large item is above the viewport, it messes up scrolling jerking the position up or down. I've tried increasing "extraItems" dramatically but it does not seem to add extra buffer space above the viewport, only below.
Here is a screen capture showing scrolling slowly down with the scroller getting stuck in a loop as it jerks upwards when the large item leaves the visible area:
https://www.screencast.com/t/J1bWfHXRsm

I'll look at it as soon as I can.
Your observation about extraItems is correct, it only add items below the viewport (as scrolling up without knowing the items height was not originally supported)

Thanks for all your work. This component has been a big help so far.

Can you try the new beta version<EMAIL_ADDRESS>Extra items now work backwards.
I also removed the scroll diff compensation, so it will roll up pretty quickly if items didn't render before. I suggest you to change the defaultHeight to match your items height as close as possible

I initially used scroll diffing (add to scrollTop the difference between the measured height and the defaultHeight), just like svelte-virtual-list, but it did not work.
Tried debugging for a few hours and I think this is due to the Vue component lifecycle, which is not the same as the DOM, so I just gave up


Finish VM Task to error state when EMS paused

When ExtManagementSystem is paused, it's not possible to perform VM operations)
For example Power on/off operations created Task (MiqTask) in status 'Queued' and never finished it after resuming provider.
Now it switches task to Finished:Error
Fixes BZ https://bugzilla.redhat.com/show_bug.cgi?id=1740285

@miq-bot add-label bug
@miq-bot add-label ivanchuk/yes

@agrare please :eyes:


Add flag to disable the output of the mdapi convert

Is your feature request related to a problem? Please describe.
Similarly to the sfdx force:source:deploy, add an option to reduce the output of the conversion. In my case, it takes more that 10 seconds to output all the converted elements
What are you trying to do
Reduce output of the conversion result
Describe the solution you'd like
By default dont output and have and option like the --verbose option in sfdx force:source:push to print this results
Describe alternatives you've considered
Maybe the opposite, have a --no-verbose option
Additional context

1m 27s printing whole output
1m 14s just redirecting stdout to /dev/null

@mnunezdm - you could also use the --json flag and it won't output to the console.

The new project:convert:source command just provides a success message, not all the details


Edited README.aodc

Pull Request Test Coverage Report for Build 117

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 92.811%

Totals

Change from base Build 116:
0.0%

Covered Lines:
1433

Relevant Lines:
1544

💛  - Coveralls


Couldn't find paper trail generator

Hey guys -
Using Rails 4.1, Ruby 2.1.4
I've entered gem 'paper_trail', '~> 3.0.6' into my Gemfile
I've bundled successfully, but when I bundle exec rails generate paper_trail:install I get:
Could not find generator paper_trail:install.
Seems like a very minute problem - am I missing something here?

Did you run bundle install first? And make sure the gem is not in a group on the Gemfile..

I've ran bundle install, and it's not in a group on the Gemfile. When I run bundle show, it does list the gem

Is it listed as a generator option when you run just bundle exec rails g?

It's not listed
On Wed, Jan 7, 2015 at 3:15 PM, Ben Atkins<EMAIL_ADDRESS>wrote:

Is it listed as a generator option when you run just bundle exec rails g?
—
Reply to this email directly or view it on GitHub
https://github.com/airblade/paper_trail/issues/459#issuecomment-69110107
.

Hmmmm, I just tried with a fresh app of Rails 4.1.8 and it seemed to work for me so I'm not sure what the issue could be...

Strange. I've used Papertrail on other projects and this is the first time
I've had an issue with the generator
On Wed, Jan 7, 2015 at 3:19 PM, Ben Atkins<EMAIL_ADDRESS>wrote:

Hmmmm, I just tried with a fresh app of Rails 4.1.8 and it seemed to work
for me so I'm not sure what the issue could be...
—
Reply to this email directly or view it on GitHub
https://github.com/airblade/paper_trail/issues/459#issuecomment-69110548
.

Are generators from other gems showing up in that list?

Yes, other gem generators are showing up
On Jan 8, 2015 7:48 AM, "Ben Atkins"<EMAIL_ADDRESS>wrote:

Are generators from other gems showing up in that list?
—
Reply to this email directly or view it on GitHub
https://github.com/airblade/paper_trail/issues/459#issuecomment-69198122
.

Were you ever able to sort out what was going on here? Perhaps try upgrading Rails?

No I've been unable to figure it out..I decided to table it for now to do
something else.
On Wed, Jan 14, 2015 at 4:51 PM, Ben Atkins<EMAIL_ADDRESS>wrote:

Were you ever able to sort out what was going on here? Perhaps try
upgrading Rails?
—
Reply to this email directly or view it on GitHub
https://github.com/airblade/paper_trail/issues/459#issuecomment-70022287
.

You can always just copy the migration contents into a blank migration file if you really can't get it to work.
Sent from my iPhone

On Jan 14, 2015, at 8:05 PM, pkuruppu<EMAIL_ADDRESS>wrote:
No I've been unable to figure it out..I decided to table it for now to do
something else.
On Wed, Jan 14, 2015 at 4:51 PM, Ben Atkins<EMAIL_ADDRESS>wrote:

Were you ever able to sort out what was going on here? Perhaps try
upgrading Rails?
—
Reply to this email directly or view it on GitHub
https://github.com/airblade/paper_trail/issues/459#issuecomment-70022287
.

—
Reply to this email directly or view it on GitHub.

This is happening for me too :(

If someone can provide a failing dummy app I can debug it more easily. I was unable to reproduce this, which makes it difficult to determine a cause.

For me it worked when sourcing the gem from Github master. It didn't work when using the rubygems version suggested in the readme.

@chrise86 - What version were you sourcing prior to sourcing from Github master?

is this a dup of #494?

I was experiencing the same issue in an app, after I switched to another version or ruby (using rvm) it magically appeared.
One curious thing was that, on the same environment I was having the problems, I was able to create a new rails app and the generator appeared.
This is the app in question in which I was experiencing the problems is this:
https://github.com/merlos/panatrans-api/tree/features/auditable
This is the last commit (before I solved the problem)
(https://github.com/merlos/panatrans-api/commit/95a62582bd5fffe7a6264a2a33f83cc18d36c020)
I guess that it may be related with any "base" gem or something like that. These are the steps I followed:
# generator not working

$ ruby --version
ruby 2.1.1p76 (2014-02-24 revision 45161) [x86_64-darwin13.0]
$ rails --version
Rails 4.1.6

# Change to another ruby version

$ rvm ruby-2.1.2    # I had it already installed

$ ruby --version
$ ruby 2.1.2p95 (2014-05-08 revision 45877) [x86_64-darwin13.0]
$ rails --version
Could not find execjs-2.4.0 in any of the sources
Run `bundle install` to install missing gems.

# So, I had to udpate rails gems

$ bundle install
Fetching gem metadata from https://rubygems.org/.........
Using rake 10.4.2
Using i18n 0.7.0
Using json 1.8.2
Using minitest 5.5.1
Using thread_safe 0.3.4
Using tzinfo 1.2.2
Using activesupport 4.1.6
Using builder 3.2.2
Using erubis 2.7.0
Using actionview 4.1.6
Using rack 1.5.2
Using rack-test 0.6.3
Using actionpack 4.1.6
Using mime-types 2.4.3
Using mail 2.6.3
Using actionmailer 4.1.6
Using activemodel 4.1.6
Using arel <IP_ADDRESS>40414130214
Using activerecord 4.1.6
Using acts_as_list 0.6.0
Using coffee-script-source 1.9.1
Installing execjs 2.4.0
Using coffee-script 2.3.0
Using thor 0.19.1
Using railties 4.1.6
Using coffee-rails 4.0.1
Installing git <IP_ADDRESS>
Using haversine 0.3.0
Using hike 1.2.3
Using multi_json 1.10.1
Using jbuilder 2.2.8
Using jquery-rails 3.1.2
Using mini_portile 0.6.2
Using nokogiri <IP_ADDRESS>
Installing paper_trail 4.0.0.beta2
Using pg 0.17.1
Using bundler 1.6.3
Using tilt 1.4.1
Using sprockets 2.12.3
Using sprockets-rails 2.2.4
Using rails 4.1.6
Using rails_serve_static_assets 0.0.2
Using rails_stdout_logging 0.0.3
Using rails_12factor 0.0.2
Using rdoc 4.2.0
Using sass 3.2.19
Using sass-rails 4.0.5
Using sdoc 0.4.1
Using spring 1.3.2
Using sqlite3 1.3.10
Using turbolinks 2.5.3
Installing uglifier 2.7.1
Your bundle is complete!
Use `bundle show [gemname]` to see where a bundled gem is installed.

# NOW IT APPEARS ! :-?

$ rails g
Usage: rails generate GENERATOR [args] [options]

General options:
  -h, [--help]     # Print generator's options and usage
  -p, [--pretend]  # Run but do not make any changes
  -f, [--force]    # Overwrite files that already exist
  -s, [--skip]     # Skip files that already exist
  -q, [--quiet]    # Suppress status output

Please choose a generator below.

Rails:
  assets
  controller
  generator
  helper
  integration_test
  jbuilder
  mailer
  migration
  model
  resource
  scaffold
  scaffold_controller
  task

Coffee:
  coffee:assets

Jquery:
  jquery:install

Js:
  js:assets

PaperTrail:
  paper_trail:install

TestUnit:
  test_unit:generator
  test_unit:plugin

Thanks!
Juan.

@merlos - Thanks for the detailed report. Just wanted to clarify though, what do you think is the culprit here then? Ruby 2.1.x?

I was unable to reproduce this.  I tried:
mkdir pt_issue_459 && cd pt_issue_459
echo "2.1.1" > .ruby_version
cat > Gemfile <<EOF
source 'https://rubygems.org'
gem "rails", "4.1.6"
gem "paper_trail", git: "git@github.com:airblade/paper_trail.git"
EOF
bundle
bundle exec rails new . --skip-gemfile --skip-spring
bundle exec rails g | grep paper_trail # paper_trail:install

Just guessing, but this may be a case of a poorly configured rvm or perhaps failing to use bundle exec.
@pkuruppu @merlos can you try the above and let us know what happens?

@jaredbeck It worked for me (I had to use https://github.com/airblade/paper_trail.git instead of git@github.com:airblade/paper_trail.git, something regarding permissions... ).
As I told in my previous comment, even before I solved the issue by setting a different ruby version I was able to create a new app with ruby 2.1.1 and the paper_trail generator appeared. It seemed to be a weird issue that affected only in the app I was working on. BTW I tried with/without bundle exec several times.
@batter My guess based on ignorance: some uncommon incompatibility with a particular version of a gem that was in my app.

Ok I'm tentatively ready to close this, just because I really don't have the faintest idea what could/would cause this and I don't know that there's anything we can do to "fix" it.  @jaredbeck - good point that, when in doubt, you should always run the commands with bundle exec just in case (even though rvm makes it possible to avoid it).

+1 to close it.

Just a note to this, I was having this problem on Ruby 2.1.6, changed to Ruby 2.0.0 and all works fine now.

Coming back to this I've been able to fix it for myself:
The problem was that after I bundled and ran the generator it returned the following message:

Could not find generator paper_trail:install.

After running 'gem list paper_trail' I saw it returned 2 versions.

paper_trail (4.0.0.rc1, 2.7.2)

Then I went to my Gemfile and set the version I wanted to use:

gem 'paper_trail', '4.0.0.rc1'

And it worked! ('bundle exec rails generator paper_trail:install')

create  db/migrate/20150602090759_create_versions.rb

Hope it helps anyone.

had the same issue after switching ruby version.  tried uninstalling and re-installing paper_trail gem a couple of times and finally got it to work.

Just to prove there are a million + 1 ways to mess things up, I experienced this same error.
The realized I'd added papertrail instead of ````paper_trail``` to my Gemfile.

In my case an error was nice enough to offer explanation how to fix itself - comment out: source 'https://rubygems.org' in Gemfile. Never had this error before. Thank you for the gem!

@lawso017 😆

Just to point out that I had the same issue using ruby-2.3.1. After I switched to ruby-2.2.4 everything worked as expected! :)
I thought it might be of help to somebody experiencing this.

For anyone wandering here from search engines, looks like this is an issue specifically with RVM only. On my linux dev machine, this worked as expected, however on my RVM using Ruby 2.3.1 I faced same issue as OP. You may just want to copy the migration file and commit it.

I have this issue as well in ruby 2.5.1 and rails 5.2

Had same issue with Ruby 2.5.0 and Rails 5.2.
Resolved issue with:
spring stop
Afterwards generate worked without problems. Hopes this would help to someone.

Had same issue with Ruby 2.5.0 and Rails 5.2.
Resolved issue with:
spring stop
Afterwards generate worked without problems. Hopes this would help to someone.

Thank you!


Improve loading screen

When loading TomoMaster, the displayed page is not really pleasant and looks like something is bugged out more than a loading screen

Implementation pull request


New package: VOCALOMAKETS.YuzukiYukariRei version 1.1.0

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[x] Have you validated your manifest locally with winget validate --manifest <path>?

[x] Does your manifest conform to the 1.5 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

Pending Manual Validation.

Automatic Validation ended with:

Exception during executable launch operation System.AggregateException: One or more errors occurred. (An error occurred trying to start process 'C:\Windows\Installer{DE759EC1-EB64-4EE5-AF1F-BC97FD39283C}_853F67D554F05449430E7E.exe' with working directory 'D:\TOOLS'. The specified executable is not a valid application for this OS platform.)  ---> System.ComponentModel.Win32Exception (216): An error occurred trying to start process 'C:\Windows\Installer{DE759EC1-EB64-4EE5-AF1F-BC97FD39283C}_853F67D554F05449430E7E.exe' with working directory 'D:\TOOLS'. The specified executable is not a valid application for this OS platform.    --- End of inner exception stack trace ---    at System.Threading.Tasks.Task.ThrowIfExceptional(Boolean includeTaskCanceledExceptions)

https://github.com/microsoft/winget-pkgs/pull/129891#issuecomment-1852578139

@wingetbot waivers Add Validation-Executable-Error


tracking issues for unstable configuration options

Similar to how the rust project has github tracking issues for all of its unstable options for interested parties to subscribe to, would it be possible for to have a similar way to subscribe and track updates to all the "stable: no" rust fmt configuration options listed in https://github.com/rust-lang-nursery/rustfmt/blob/master/Configurations.md?
This is of special interested to me because I depend on only on nightly to run cargo +nightly fmt but use stable for everything else. I'd be interested in have a way to be looped into the day I no longer have to do that.

just checking in on this issue. Without a better way to know what the progress is on stabling a specific config options is a very frustrating experience to be locked into +nightly in ci for stable focused projects

i'll try to create some tracking issues

https://github.com/rust-lang/rustfmt/commit/412dcc70a2fa8edc042b83af762c3741b54c61a0 I pushed by mistake to master, but there is an updated configuration file where tracking issue are mentioned for each of the options.

@scampi thats great!
Minor feedback on that.
It would be even better to have a hyper link on those and to have the issue not be part of the title. The reason being is because those are hyper links on github
so changing the titles breaks existing likes. i.e  https://github.com/rust-lang/rustfmt/blob/master/Configurations.md#fn_args_density is now https://github.com/rust-lang/rustfmt/blob/master/Configurations.md#fn_args_density-tracking-issue-3375 ect
Should I hope another issue for that would would be be a quick change for you?

when I said hyper link above, i meant a hyper link to the gh issue. I can construct that by hand but even better would just be the ability to click a link

@softprops very good point, i'll fix that


Bookie startup fails with JDK11 based docker image and default values.yaml JVM settings

Describe the bug
starting bookie fails with this error when a JDK11 based docker image is used (apache/pulsar master branch)
Unrecognized VM option 'PrintGCTimeStamps'
Error: Could not create the Java Virtual Machine.

and
Unrecognized VM option 'PrintGCApplicationStoppedTime'
Error: Could not create the Java Virtual Machine.

and
Unrecognized VM option 'PrintHeapAtGC'
Error: Could not create the Java Virtual Machine.

and
Unrecognized VM option 'G1LogLevel=finest'
Error: Could not create the Java Virtual Machine.

and
[0.002s][warning][gc] -Xloggc is deprecated. Will use -Xlog:gc:/pulsar/logs/bookie-gc.log instead.
[0.006s][warning][gc] -XX:+PrintGCDetails is deprecated. Will use -Xlog:gc* instead.

A clear and concise description of what the bug is.
To Reproduce

build docker images from apache/pulsar master branch
publish to some docker repository
reference the images in a custom values.yaml
deploy pulsar helm chart

Expected behavior
Pulsar helm chart should work with JDK11 base images.

Fixed


Highlight the last row of the summary in color

Color cells on the last row on summary and on tabs in 'Green, Accent 6, Lighter 80%'

Implemented in v0.8+


Scrolling the frozen columns does not scroll the non-frozen columns

There are two parts to this issue:

Mousewheel events on the frozen columns do not scroll either the non-frozen or frozen columns.  This can be tested in the frozen columns example.
Scrolling the frozen columns does not scroll the non-frozen columns.  The only way to scroll the frozen columns by themselves is to click within the frozen column and drag the mouse below or above the canvas.  Doing so scrolls the frozen columns without scrolling the non-frozen columns.  This can also be tested in the frozen columns example.

Should be fixed in https://github.com/JLynch7/SlickGrid/commit/2f430d68b6eb6233ba1b4c68ab1e2d240ca54889
Please test and let me know

I assume this is resolved

Sorry, yes it has been fixed. Thanks.


--cors-allow-origins flag has no effect

Describe the bug
Starting a server with --cors-allow-origins "*" does not send any CORS headers.
To Reproduce
docker run --rm -it -p '8888:8888' -v `pwd`:/web joseluisq/static-web-server:2.6 --cors-allow-origins "*" -p 8888 -d /web
serve any json, or log text file.
Expected behavior
CORS headers are present.
Logs/Screenshots
$ curl -I http://localhost:8888/73f944bde7bb0b9093e5f1fb9d01ad1f.json
HTTP/1.1 200 OK
content-length: 548
content-type: application/json
accept-ranges: bytes
last-modified: Mon, 28 Feb 2022 14:19:29 GMT
cache-control: public, max-age=3600
date: Mon, 28 Feb 2022 14:20:45 GMT

Environment and Specs

static-web-server: 2.5, 2.6
OS: docker image
Docker: 20.10.12
Client: curl, but doesn't matter

Yeah, headers are not properly assigned. So a fix will come soon.

Please have a look at https://github.com/joseluisq/static-web-server/pull/87#issuecomment-1057467997 for more details.

$ curl -I http://localhost:8888/73f944bde7bb0b9093e5f1fb9d01ad1f.json
HTTP/1.1 200 OK
content-length: 548
content-type: application/json
accept-ranges: bytes
last-modified: Mon, 28 Feb 2022 14:19:29 GMT
cache-control: public, max-age=3600
date: Mon, 28 Feb 2022 14:20:45 GMT

BTW in your example you have to provide the Origin header in order to try to get access the resource in a cross-origin manner.

For testing please use the latest development Docker images either joseluisq/static-web-server:devel-alpine or joseluisq/static-web-server:devel

Fixed on v2.7.0


[TC-DGTHREAD-3.1]  - Verification steps does not include Read Request message dictionary details

Hi All,
With respect to [TC-DGTHREAD-3.1]  - Verification steps does not include Read Request message details
As shown in test plan
./chip-tool threadnetworkdiagnostics read channel 54 0
Verify "channel response" on the TH(All-cluster-app) Log:
D: 499352 [EM]Handling via exchange: 37813r, Delegate: 0x200070ec
D: 499358 [IM]Received Read request
D: 499362 [DMG]IM RH moving to [GeneratingReports]
D: 499367 [DMG]Building Reports for ReadHandler with LastReportGeneration = 0 DirtyGeneration = 0
D: 499375 [DMG]RE:Run Cluster 35, Attribute 0 is dirty
D: 499381 [DMG]Reading attribute: Cluster=0x0000_0035 Endpoint=0 AttributeId=0x0000_0000 (expanded=0)
exchanr
D: 499492 [EM]Found matching exchange: 37813r, Delegate: (nil)
D: 499498 [EM]Rxd Ack; Removing MessageCounter:30700790 from Retrans Table on exchange 37813r
D: 499506 [EM]Removed CHIP MessageCounter:30700790 from RetransTable on exchange 37813r
Our logs include details of Received Read request details
./chip-tool threadnetworkdiagnostics read channel 1 0
[1660850820.549481][1351:1351] CHIP:IM: Received Read request
[1660850820.549604][1351:1351] CHIP:DMG: ReadRequestMessage =
[1660850820.549649][1351:1351] CHIP:DMG: {
[1660850820.549690][1351:1351] CHIP:DMG:         AttributePathIBs =
[1660850820.549735][1351:1351] CHIP:DMG:         [
[1660850820.549776][1351:1351] CHIP:DMG:                 AttributePathIB =
[1660850820.549823][1351:1351] CHIP:DMG:                 {
[1660850820.549871][1351:1351] CHIP:DMG:                         Endpoint = 0x0,
[1660850820.549970][1351:1351] CHIP:DMG:                         Cluster = 0x35,
[1660850820.550028][1351:1351] CHIP:DMG:                         Attribute = 0x0000_0000,
[1660850820.550075][1351:1351] CHIP:DMG:                 }
[1660850820.550123][1351:1351] CHIP:DMG:
[1660850820.550171][1351:1351] CHIP:DMG:         ],
[1660850820.550216][1351:1351] CHIP:DMG:
[1660850820.550260][1351:1351] CHIP:DMG:         isFabricFiltered = true,
[1660850820.550302][1351:1351] CHIP:DMG:         InteractionModelRevision = 1
[1660850820.550340][1351:1351] CHIP:DMG: },
[1660850820.550453][1351:1351] CHIP:DMG: IM RH moving to [GeneratingReports]
[1660850820.550582][1351:1351] CHIP:DMG: Building Reports for ReadHandler with LastReportGeneration = 0 DirtyGeneration = 0
[1660850820.550657][1351:1351] CHIP:DMG: RE:Run Cluster 35, Attribute 0 is dirty
[1660850820.550697][1351:1351] CHIP:DMG: Reading attribute: Cluster=0x0000_0035 Endpoint=0 AttributeId=0x0000_0000 (expanded=0)
[1660850820.550743][1351:1351] CHIP:DMG: AccessControl: checking f=1 a=c s=0x000000000001B669 t= c=0x0000_0035 e=0 p=v
[1660850820.550795][1351:1351] CHIP:DMG: AccessControl: allowed
Can we upload the details for log validation
Please confirm
Proposed Solution
<suggested fix, suggested enhancement>

This does not look like an SDK issue.  Please file in https://github.com/CHIP-Specifications/chip-test-plans/issues/new/choose or https://github.com/CHIP-Specifications/chip-test-scripts/issues/new/choose as appropriate.


trendsValue(sum) is not working

Hi Alexander, thanks for your fantastic project again.
Describe the bug
It is possible to use trendsValue(sum) function in Grafana zabbix datasource but it is not working.
(ALL SCREENS ARE LAST 7D)

count is also not working

Others options like avg, min or max are working.

Software versions

Grafana
Zabbix
Grafana-Zabbix Plugin

6.7.2
4.4.7
3.11.0

Hi! Got it. At least sum is working with Direct DB Connection, but I can make it working with API as well by returning value_avg * num value.


disarray~: uses t_int as integer-type

the iswitch_count() function uses t_int in a way that suggests it is meant to represent a numeric integer type. Pd does not have a "native" integer type (unlike Max).
t_int is actually reserved for the pointer array in the DSP-graph, it should not used as a generic type.
(and the iswitch_count() function is not used anyhow, so it should probably be just removed entirely)

Good point.


JavaScript ChatterBot

Do you plan on expanding chatterbot to any other languages like JavaScript? It seems like it wouldn't be that difficult since python and JavaScript share a somewhat similar syntax. Would be nice to see this type of bot on node.js, most of the JS bots I've seen so far aren't intelligent bots.

Hi @liberaltech, I currently don't have any plans to recreate ChatterBot in JavaScript. I would not be opposed to helping out with a JavaScript fork of the project if anyone ever decides to create one, but for the time being most of my efforts are placed on developing and expanding the current codebase.

As a side note, I've seen several examples of ChatterBot being used in web APIs which can easily be called from Node applications. I realize this isn't the same, but it could be a way to quickly get ChatterBot's functionality present in a JavaScript app.


[move-only] Emit a "checker did not understand" error if copy propagation fails for some reason.

We already emit a "checker did not understand" error if our pattern matching at the beginning failed. This just tightens the logic even more by including another potential error condition.
NOTE: This was caught by the SILVerifier check that copy_value in canonical SIL can not take a move only type as an argument. Its better to catch this with a nice earlier diagnostic though.

@swift-ci test


fix: make node to global resource

Signed-off-by: lixd<EMAIL_ADDRESS>
What type of PR is this?

/kind feature
What this PR does / why we need it:
make node to global resource
Which issue(s) this PR fixes:

Fixes #
Special notes for reviewers:
1. add view-users role projectRole template whic missed before.
2. projects/{project}/nodes api return all node
3. create cluster、add node to cluster api don't check node's project
4. remove join node to project api
5. project controller update

Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc.:

Codecov Report

Merging #418 (f64afe5) into master (094db95) will increase coverage by 0.06%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #418      +/-   ##
==========================================
+ Coverage   12.04%   12.10%   +0.06%
==========================================
  Files         106      106
  Lines       17191    17102      -89
==========================================
  Hits         2071     2071
+ Misses      14872    14783      -89
  Partials      248      248

Impacted Files
Coverage Δ

pkg/apis/core/v1/handler.go
0.37% <0.00%> (+<0.01%)
:arrow_up:

pkg/apis/core/v1/registry.go
0.00% <ø> (ø)

/assign @x893675

/lgtm
/approve


truncated buffer and freeze fixes

Fixes for #22 in addition to a problem where keys would be truncated and give an invalid response when the agent is being forwarded.

Thank you very much @1Dragoon, this is an excellent addition and fix. Merging this and will author a new release soon.


where TypeError

In the following code:
const one = {
  a: 'foo',
  b: { c: 'bar' }
};

const two = {
  a: 'foo',
  b: 'bar'
};

const three = {
  a: 'foo'
};

const func = where({
  a: equals('foo'),
  b: propEq('c', 'bar')
});

expect(func(one)).toEqual(true);           // true
expect(func(two)).toEqual(false);          // false
expect(func(three)).toEqual(false);       // TypeError: Cannot read property 'c' of undefined

From the docs the type error should be false here or am I getting the wrong end of the stick with the where function?

interesting. i think the issue is with propEq really: propEq('c', 1, undefined); //=> TypeError
This seems like good behavior. Where in the docs does it say the third example would be supported?

The docs say "Each predicate is applied to the value of the corresponding property of the test object". I understood this to mean that so long the function can take the value it should evaluate to a Boolean. This would expand to propEq('c', 'bar')({ c: 'bar' });.
I'll probably take a look at this tonight and try to get it working.

So where should probably handle an undefined property before passing it in when the key is lookup up.

I don't think this conclusion follows. I'd rather that the function throw than swallow the error.

A possible use case would be if we have an array such as:
var arr = [
  {
    type: 'a',
    parent: {
      type: 'b',
      also: 'c'
    }
    }
  },
  {
    type: 'a',
  }
]

Then calling something like:
filter(where({ type: equals('a'), parent: propEq('type', 'b') }))(arr) - this would throw a type error whereas it would be better to (at least in cases when data format can't be assured) to just return false from the where.
I think there's a case for having that sort of function, even if it isn't necessarily where. Wrapping it in a tryCatch only to return false is just messy imo.

Note you can use pathEq: https://goo.gl/ty1lJe
Maybe best to normalize your data before though?
I believe the difference between prop and path have come up in the past, current behavior does feel wrong.


Incomplete style element removes test results from page until completed

Challenge http://www.freecodecamp.org/challenges/waypoint-use-css-selectors-to-style-elements has an issue. Please describe how to reproduce it, and include links to screen shots if possible.
See screenshot, should be explanatory.
Thought it was a neat bug in all truth.

This is expected behavior. Prevents the tests from crashing the browser.
Happy Coding!


ExportCommand: Documentation and System Test

Update UserGuide.adoc for export command.

Add system test for export command.

Coverage remained the same at 92.408% when pulling 4bc4ea3df88c829753b4a82dc7dc5cd111ee301b on HanYaodong:fix-export-test-docs into 200d1d8df191df7f2a7fdb3c75a2f5255e24295f on CS2103AUG2017-F11-B4:master.


Re-revert "Fix operator spacing."

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.
[x] Have you successfully run brew tests with your changes locally?

This time without the problematic lines in https://github.com/Homebrew/brew/pull/2713.

If you've verified head installation works 👍


Structured Search Pipeline

Querying requirements across RAG fall not only onto unstructured data that has been embedded and added to an vector database. It also falls onto structured data sources where semantic search doesn't really make sense.
Goal: Provide a pipeline interface that connects to a structured data source and generates queries in real-time based on queries.
Implementation:

Psuedo Pipeline without an embed or sink connector, just a data source.
Data source connector is configured and an initial pull from the database is done to examine the fields available and their types.
Search generates a query using an LLM based on the fields available in the database.
The Pipeline can be used as part of a PipelineCollection and supported by smart_route in order for model to decide when to use it.

Alternative implementation:

In order to reduce the latency associated with having to do 2-3 back to back LLM calls to generated query and validate it, what if the query generation was done pre-emptively and cached in to a vector database.
Using an LLM, we would try to predict the top sets of queries that one might expect from the database and its permutations. (This might limit the complexity of the queries, but might answer for 80% of use cases)
At search we would run a similarity search of the incoming query against the description of the "cached" queries. We then can run top query against the database.

@ddematheu Haven't yet fully understood this, but the alternatives sound similar to internals of this project - aidb. Can you please give an example to elaborate this.
As far as I understood, we have some structured data sources. Now we want to map a natural language query to an appropriate SQL query(or any structured query) using an LLM.

The thought process was given a database, to generate a set of common queries for it (based on schema) using an LLM. Fron there take the queries amd the descriptions for them and embed them (embed the description). Then at runtine when someone searches, we take he search and compare against the embeddings and use the stored query to query the database (or pass into a database for fine tuning based on the search)
It is a bit more similar to this https://github.com/vanna-ai/vanna.

@ddematheu Okay, so I understood it like this and tried it on t5-small-text-2-sql model:
input_prompt = "tables:\n CREATE TABLE engineers (id: VARCHAR, name: TEXT, age: INT); \n query for: Group by the age column"
print("Generted SQL:")
generate_sql(input_prompt=input_prompt)

Output:
Generted SQL:
'SELECT name, age FROM engineers GROUP BY age'

So we would create pairs and embed the description,
{'query': 'SELECT name, age FROM engineers GROUP BY age', 'description': 'Group by the age column'}

Is this what you meant?


pre-commit integration

I added a .pre-commit-config.yaml file (https://pre-commit.com/), and with it :

pyupgrade
autoflake
isort
black
django-upgrade
flake8

I've split the different hooks application into different commits, in order to better gauge the impact of each linter/formatter.
On top of this (using pre-commit locally), the idea is to plug https://pre-commit.ci/ as well.
Let me know what you think!

👍


Web: Button disabled(false) doesn't enable the button

Button(attrs = {
  disabled(false)
}) {
  Text("Enabled button")
}

Results into <button disabled="false">Enabled button</button>, but should be <button>Enabled button</button>.
The content of disabled tag is always ignored, only its presence is checked.
Workaround
Button(attrs = {
  if(buttonDisabledCondition) {
    disabled()
  }
}) {
  Text("Enabled button")
}

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.


Reading non-existent documents while debugging is very slow

Trying to read a document from Cosmos DB that doesn't exist is very slow when executing in the Visual Studio debugger. In fact, it is so slow that the project I'm working on can have startup times of several minutes when I debug which severly impacts my productivity.
I believe that the cause of the issue is that trying to read a document that doesn't exist will throw an DocumentClientException with status HttpStatusCode.NotFound. In itself that shouldn't be a problem but it seems that SDK will catch and rethrow this exception through many layers of abstractions and this cripples the performance when debugging in Visual Studio. At least, that is my best guess.
To give some perspective why I have this issue: I'm building an actor based system where the state of the actors are backed by Cosmos DB. The performance guarantees of Cosmos DB works really well in this scenario. When the system starts it receives data from an external API and builds an actor model of several hundred actors. Receiving this data takes a few seconds but the actors have to try to read previous state from Cosmos DB and then update and save the new state back to Cosmos DB before the system is ready.
In production the startup speed of the system is fast. However, when debugging using an empty Cosmos DB database starting the service becomes extremely slow because all the initial reads will fail.
To demonstrate the issue I have created a small test program that simulates an actor based system where each actor will try to read state and then upsert new state. On first pass the read will fail while on second pass the documents already exists and the read doesn't fail. The test uses the emulator and reports the time taken to read and upsert the documents. The test application uses Microsoft.Azure.DocumentDB.Core 1.9.1 and processes 500 documents.
The Visual Studio debugger has an Enable Just My Code setting and turning this setting off (which is a legitimate thing to do) will lower the debugging performance from really bad to disastrous. One effect of turning this setting off is that every time an exception is rethrown it is logged to the output window and you can see how each failed read produces vastly more output. You can configure the output window to not show exceptions but unfortunately this only improves performance slightly.
This issue is about the performance of using the SDK in Visual Studio debugger. It is not about the performance of Cosmos DB. Thus all my "benchmarks" are executed using a debug build on my pretty beefy i7-6700K desktop computer. IntelliTrace was turned off for all tests. The throughput of the document collection is set to the maximum value of 10000 to ensure that throttling doesn't interfere with the benchmark.

Debugger
Just My Code
1st pass
2nd pass

N
N/A
1s / 2s
1s / 2s

Y
Y
22s / 3s
1s / 2s

Y
N
5m 16s / 3s
1s / 2s

The two durations listed in the 1st pass and 2nd pass columns are the times to read and upsert the documents.
The first line in the table is when doing the benchmark outside the debugger (it is still a debug build that executes). The performance is the same for both passes and is fine.
The second line in the table is doing the benchmark inside the debugger with Enable Just My Code turned on. The performance of the first pass is already really bad going from 1s to 22s for reading 500 non-existent documents.
The third line is the Enable Just My Code turned off and now it takes more then five minutes to read 500 non-existent documents! This is less than 100 documents per minute.
While the "production" performance of the SDK is very important I think you also should consider the debug performance. Developer time is a limited resource and I find that I'm wasting minutes that accumulate to hours and days over time waiting for the SDK to report that a document wasn't found while debugging.
If you want to reproduce my findings I have created a GitHub gist with my test application.

I'm assigning this to @kirankumarkolli to provide any further context.
This will be resolved when we release the next major version of the .NET SDK which completely overhauls the exception pipeline and realizes some massive perf improvements because of it.
I'll leave this open until that version is released. @kirankumarkolli can then close it.


include public key in known_hosts entry

fixes #8950

@lkillgore -- Madhuri approved before I completely changed tack here, so I don't want to complete this without you taking another quick look.


python312Packages.cyclonedx-python-lib: 7.6.2 -> 8.0.0

Diff: https://github.com/CycloneDX/cyclonedx-python-lib/compare/refs/tags/v7.6.2...v8.0.0
Changelog: https://github.com/CycloneDX/cyclonedx-python-lib/releases/tag/v8.0.0

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 349381 run on x86_64-linux 1

6 packages failed to build:

checkov
checkov.dist
cyclonedx-python
cyclonedx-python.dist
pip-audit
pip-audit.dist

4 packages built:

python311Packages.cyclonedx-python-lib
python311Packages.cyclonedx-python-lib.dist
python312Packages.cyclonedx-python-lib
python312Packages.cyclonedx-python-lib.dist

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 349381

x86_64-linux

:x: 4 packages failed to build:

checkov
checkov.dist
pip-audit
pip-audit.dist

:white_check_mark: 6 packages built:

cyclonedx-python
cyclonedx-python.dist
python311Packages.cyclonedx-python-lib
python311Packages.cyclonedx-python-lib.dist
python312Packages.cyclonedx-python-lib
python312Packages.cyclonedx-python-lib.dist


Fix #98: Some files won't open.

In the last commit, the regex that describes the version property was broken. Spurious backslash characters were introduced, and the optional whitespace before the colon character (which is permitted by the JSON spec) was removed.
Also:

Even though ErrorListService as a whole is not unit testable (I filed #100), I extracted a small static method that I could test. This is the Sprout Method (59) pattern from Feathers, "Working Effectively With Legacy Code".

Adding the unit tests revealed another bug: the extension would not have opened a SARIF file that was fewer than 200 characters long.

@rtaket is added to the review. #Closed

@cfaucon is added to the review. #Closed

@harleenkohli is added to the review. #Closed

@jeffersonking is added to the review. #Closed


[Frontends] Add operators to support BERT

It came up that BERT might be convenient for testing BYOC. This PR adds a few ops needed to support it.

Hello @jwfromm!
Errors related to lint and tflight have already been fixed in this PR#38. Maybe it makes sense to first merge #38, then to rebase for this PR?


Family question

Hi, i like your toolbox. But i miss, or missed, a family option to use with a bunch of images. By declaring them as family, i can scroll between every image without clicking again. It would be great!

No, sorry, this is out of the scope of Lity, sorry. See eg. #97, #11, #82, #89


do not propagate events through portal

Closes #1810
✅ Pull Request Checklist:

[x] Included link to corresponding React Spectrum GitHub Issue.
[x] Added/updated unit tests and storybook for this change (for new code or code which already has tests).
[ ] Filled out test instructions.
[ ] Updated documentation (if it already exists for this component).
[ ] Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:
Adobe/Quarry

I wasn't sure if the other events (that I didn't modify) were being triggered in my manual tests. Didn't want to just add the check for every event if it wasn't triggering at all, but I can add to others if needed?

Agreed, there are a lot of different interaction paths, however, I think we need to really carefully address all of them. That means doing things like testing the screen reader in FF on windows or whatever else we can think of. Possibly talk to @devongovett  about the weirder ones and look through his blog post to track them down as well.


Usage of "sub" in the JWT Token documentation https://fastapi.tiangolo.com/tutorial/security/oauth2-jwt/

From what I've gathered the "sub" or "subject" field in the JWT token(https://tools.ietf.org/html/rfc7519#section-4.1) payload should be locally or globally unique. The documentation uses the username from the form data in the payload.
Is this a good practice? In a few examples I've found others using a unique id instead like 19898981.

That code is purely for demo purposes, not intended to be used in a production system

That code is purely for demo purposes, not intended to be used in a production system

Yep definitely understand. My question is more around how it should work in a production system? AFAIK the spec just says sub should be locally unique in the current context or globally unique. I suppose a username is unique but the username ID in some database is the most unique way to represent that. just curious what the thoughts are of the fastapi devs :)

I mean, that is correct - it should be a unique identifier for the user, whether that be their username or user id

Thanks for the help @Mause! 🍰
And thanks for coming back to close the issue @cmflynn ☕

Sorry for the long delay! 🙈  I wanted to personally address each issue/PR and they piled up through time, but now I'm checking each one in order.


NTR reduced protein localization to nucleus during mitosis PMID:10523629

standard def
reduced protein localization to nucleus during mitosis

decreased protein localization to nucleus during mitosis FYPO:0005672
edit file: 19ebdbdb0e2cae0d1b90961a57115efd15b9bdf4
release: 3a2745c6a0a452731fd890b1799aca8fb4b94a41


Upgrade afj

This PR is equivalent to https://github.com/hyperledger/aries-framework-javascript-ext/pull/222 from the upstream. Most of the comments from there apply equally here. Note I would try to avoid changing too much as the upstream PR is not yet approved and we will likely want to fix this up in line with that.

btw these tests are really flakey and that issue has been raised i nthe upstream


possibly missed notification with IORING_OP_MSG_RING

I am using liburing-2.2 on kernel 5.19 and I see that a msg that I send from ring A does not wake up the ring B.
Probably, it's a bug in my code but I want to double-check whether there were known issues with this opcode.
I use the following code to send a message:
// In the context of thread A
sqe = io_uring_get_sqe(ring_a_);
io_uring_prep_msg_ring(sqe, ring_b_.ring_fd, 0, kIgnoreIndex);
io_uring_submit(ring_a_);

and the thread B that is blocked on io_uring_wait_cqes(&ring_b_, cqe_ptr, 1, NULL, NULL); does not resume.

5.19 stable is long dead, so can't do much there. Can you try if it works in 6.1-stable? Or newer, but 6.1-stable would be the oldest stable that supports MSG_RING.

I will check but are you saying it's possible the problem is in 5.19?

Hi Jens, I've checked version 6.1.22 as well, and the problem consistently reproduces there on arm64 architecture.
I've checked on 5.19 on x86 but it does not reproduce there.
I can build an arm64 container that demonstrates the problem.  @axboe

Do you have just a simple reproducer I can run? That'd be preferable to something more complicated.

Simple reproducer - yes, but it's not a unit test 🤷🏼
Steps (reproduces 100% of c6g.2xlarge, kernel 6.1.22-060122-generic installed on ubuntu 22.04.1 (do not think it matters).
Architecture - aarch64.
To reproduce

docker  pull romange/echo_server:bug
Server side:

docker  run --network=host romange/echo_server:bug  --logtostderr --proactor_threads=2  --vmodule=uring_proactor=2 --logbuflevel=-1 --http_port=-1

two io-rings are created (PRO[0], PRO[1]) and both of them eventually block on wait_for_cqe with ring_fd 5,6. Threads ids 7,8.

Client side (on the same instance):

docker  run  echo_server:bug --connect <IP_ADDRESS> -n 150 --proactor_threads=1 -c 1

sends a few requests to the server. For me 150 was enough. It's a single connection so only PRO[0] handled all of them in my case.
4. Final step: press ctrl-c in the server shell. It sends SIGINT to the process. PRO[0] wakes up and sends a
MSG to target ring 6 (PRO[1]). It never wakes up:
accept_server.cc:25] Exiting on signal Interrupt
uring_proactor.cc:618] WakeRing target_fd: 6 source_fd: 5

(to unblock: killall -9 echo_server kills the server).
expected behavior
just omit step (3), and you should see something like this:
7 accept_server.cc:25] Exiting on signal Interrupt
7 uring_proactor.cc:618] WakeRing target_fd: 6 source_fd: 5   # PRO[0] tries to wake up PRO[1]
7 uring_proactor.cc:565] PRO[0] wait_for_cqe 50 ring_fd: 5    # Goes to sleep for now
8 uring_proactor.cc:581] PRO[1] Woke up after wait_for_cqe, ring_fd: 6   # PRO[1] was woken up!

If you want an access to the server please tell me.

Maybe you can put some more details in here on what the pattern looks like, how rings are created, etc. I greatly prefer writing a test case that reproduces it rather than deal with docker, as it can then also be used as a regression test case after the fact.

Also, what is kIgnoreIndex? And you're not getting an error on any of the send MSG_RING ops, meaning they weren't delivered?

kIgnoreIndex is my internal user_data constant that says there is no completion callback to run upon receiving a CQE.
I try to use MSG_RING to wake the ring from waiting on I/O. my baseline is using eventfd for that.
I wish I could introduce a test case but I do not understand myself why this happens . I am sorry you wasted your time with docker, I actually suggested docker in order to save your time building the binary :(
will access to a cloud VM with a source code (it's public repo anyway) and the compiled binary help you? I can DM you to send me a public ssh key and then instruct you how to access it. No need to use docker in this case but you will need to handle ubuntu :) Maybe if you look at it there, you will understand how to reproduce it.

Sure, vm access would help. But why can't I just compile and run it locally? Does it depends on bits that are not available otherwise?

Sure, I prepared branch https://github.com/romange/helio/tree/WakeBug
you need the following dependencies (debian/ubuntu):
apt install -y cmake libunwind-dev zip libfl-dev bison ninja-build autoconf-archive  libboost-fiber-dev libtool
then:
1.  git checkout WakeBug
2. ./blaze.sh
3. cd build-dbg && ninja echo_server

Then to reproduce:

Server shell
./echo_server  --logtostderr --proactor_threads=2  --vmodule=uring_proactor=2 --logbuflevel=-1 --http_port=-1
Client shell:
./echo_server --connect <IP_ADDRESS> -n 150 --proactor_threads=1 -c 1
should connect and send 150 network pings.
Server shell: ctrl-c. process is stuck.
PRO1 thread does not reach this line: https://github.com/romange/helio/blob/WakeBug/util/fibers/uring_proactor.cc#L587
which is right after the syscall to wait for a CQE.

I gave it a quick spin. Here's what I get:
Client side:
axboe@m1max-kvm ~/g/W/build-dbg (WakeBug)> ./echo_server --connect <IP_ADDRESS> -n 150 --proactor_threads=1 -c 1
Total time 19 ms, num reqs: 150 qps: 7894
Overall latency (usec)
Count: 150 Average: 128.2800  StdDev: 103.24
Min: 65.0000  Median: 75.0746  Max: 356.0000
------------------------------------------------------
[      60,      70 ) 41  27.333%  27.333% #####
[      70,      80 ) 66  44.000%  71.333% #########
[      80,      90 ) 5   3.333%  74.667% #
[      90,     100 ) 1   0.667%  75.333%
[     100,     120 ) 1   0.667%  76.000%
[     120,     140 ) 2   1.333%  77.333%
[     180,     200 ) 1   0.667%  78.000%
[     200,     250 ) 2   1.333%  79.333%
[     300,     350 ) 30  20.000%  99.333% ####
[     350,     400 ) 1   0.667% 100.000%

Server side:
axboe@m1max-kvm ~/g/W/build-dbg (WakeBug) [SIGKILL]> ./echo_server --logtostderr --proactor_threads=2 --vmodule=uring_proactor=2 --logbuflevel=-1 --http_port=-1
I20230410 20:22:59.094120 15141 init.cc:58] ./echo_server running in debug mode.
I20230410 20:22:59.094633 15142 uring_proactor.cc:111] Create uring of size 256
I20230410 20:22:59.094895 15142 uring_proactor.cc:138] msgring supported!
I20230410 20:22:59.094715 15143 uring_proactor.cc:111] Create uring of size 256
I20230410 20:22:59.094931 15142 uring_proactor.cc:162] IORing with 256 entries, allocated 25920 bytes, cq_entries is 512
I20230410 20:22:59.095067 15142 uring_proactor.cc:475] Tasks runs 2/0
I20230410 20:22:59.095072 15143 uring_proactor.cc:138] msgring supported!
I20230410 20:22:59.095088 15142 uring_proactor.cc:571] PRO[0] wait_for_cqe 16 ring_fd: 5
I20230410 20:22:59.095206 15143 uring_proactor.cc:475] Tasks runs 2/0
I20230410 20:22:59.095217 15141 proactor_pool.cc:73] Running 2 io threads
I20230410 20:22:59.095227 15143 uring_proactor.cc:571] PRO[1] wait_for_cqe 16 ring_fd: 6
I20230410 20:22:59.095482 15143 uring_proactor.cc:587] PRO[1] Woke up after wait_for_cqe, ring_fd: 6
[...]
I20230410 20:23:05.663743 15142 uring_proactor.cc:571] PRO[0] wait_for_cqe 1020 ring_fd: 5
I20230410 20:23:05.663897 15142 uring_proactor.cc:587] PRO[0] Woke up after wait_for_cqe, ring_fd: 5
I20230410 20:23:05.663954 15142 uring_proactor.cc:520] Switching to HandleRequests
I20230410 20:23:05.664160 15142 uring_proactor.cc:520] Switching to HandleRequests
I20230410 20:23:05.664229 15142 uring_proactor.cc:520] Switching to HandleRequests
[...]
I20230410 20:23:05.682819 15142 uring_proactor.cc:520] Switching to HandleRequests
I20230410 20:23:05.683106 15142 uring_proactor.cc:571] PRO[0] wait_for_cqe 1220 ring_fd: 5

and it just sits there. If I check the stack trace, it's waiting on a futex:
[<0>] futex_wait_queue+0x5c/0x98
[<0>] futex_wait+0xa4/0x158
[<0>] do_futex+0x90/0x130
[<0>] __arm64_sys_futex+0xd4/0x160
[<0>] invoke_syscall.constprop.0+0x70/0xb8
[<0>] do_el0_svc+0x98/0xf8
[<0>] el0_svc+0x7c/0xa4
[<0>] el0t_64_sync_handler+0xa8/0x134
[<0>] el0t_64_sync+0x168/0x16c

and checking the ring status, it has nothing pending that isn't reaped:
axboe@m1max-kvm ~> cat /proc/15141/fdinfo/5
pos:	0
flags:	02000002
mnt_id:	14
ino:	29364
SqMask:	0xff
SqHead:	304
SqTail:	304
CachedSqHead:	304
CqMask:	0x1ff
CqHead:	304
CqTail:	304
CachedCqTail:	304
SQEs:	0
CQEs:	0
SqThread:	-1
SqThreadCpu:	-1
UserFiles:	0
UserBufs:	0
PollList:
  op=6, task_works=0
CqOverflowList:

but it does have a poll request pending still.
OK, ran it a few more times and it seems to not finish on the client side. Still nothing pending the ring, however. I'll poke a bit.

Is this futex inside io_uring_enter syscall?
Because this is where i expect it to be.
How do you print the stack trace of a running process?

It's not, it's separate from io_uring. But I think I see what your issue is, hang on.

You've got a badly formed IORING_OP_MSG_RING submitted. This is what I mentioned earlier, did you ever see any errors from those? And you do, because it gets -EINVAL and hence isn't delivered. A few recommendations:

Check the for errors in your CQEs
For IORING_OP_MSG_RING, I'd set IOSQE_CQE_SKIP_SUCCESS in the sqe->flags as you really should not need to waste time on reaping and checking a CQE for a case that is successful.

This makes it work for me. Probably not the right fix, but I'll leave that to you.
diff --git a/util/uring/submit_entry.h b/util/uring/submit_entry.h
index e4707a3088e9..936abc126dea 100644
--- a/util/uring/submit_entry.h
+++ b/util/uring/submit_entry.h
@@ -182,6 +182,7 @@ class SubmitEntry {
   }

   void PrepMsgRing(int fd, unsigned int len, uint64_t data) {
+    memset(sqe_, 0, sizeof(*sqe_));
     PrepFd(IORING_OP_MSG_RING, fd);
     sqe_->len = len;
     sqe_->off = data;

Thanks Jens, will follow up on this!
Roman
On Tue, Apr 11, 2023, 05:44 Jens Axboe @.***> wrote:

You've got a badly formed IORING_OP_MSG_RING submitted. This is what I
mentioned earlier, did you ever see any errors from those? And you do,
because it gets -EINVAL and hence isn't delivered. A few recommendations:

Check the for errors in your CQEs
For IORING_OP_MSG_RING, I'd set IOSQE_CQE_SKIP_SUCCESS in the
sqe->flags as you really should not need to waste time on reaping and
checking a CQE for a case that is successful.

This makes it work for me. Probably not the right fix, but I'll leave that
to you.
diff --git a/util/uring/submit_entry.h b/util/uring/submit_entry.h
index e4707a3088e9..936abc126dea 100644
--- a/util/uring/submit_entry.h
+++ b/util/uring/submit_entry.h
@@ -182,6 +182,7 @@ class SubmitEntry {
}
void PrepMsgRing(int fd, unsigned int len, uint64_t data) {

memset(sqe_, 0, sizeof(*sqe_));
PrepFd(IORING_OP_MSG_RING, fd);
sqe_->len = len;
sqe_->off = data;

—
Reply to this email directly, view it on GitHub
https://github.com/axboe/liburing/issues/839#issuecomment-1502611870,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA4BFCCTJC3OMBUVP4GPDKTXATAP3ANCNFSM6AAAAAAWT5BKQA
.
You are receiving this because you authored the thread.Message ID:
@.***>


Chunks with multiple passes are not supported

I know this is related to this issue #6 but i cant understand that issue very well so i posted this error again here. What im trying to do is to decompress an lz4 file. I already tested the lz4 sample file with lz4 decompressor so the file is not the problem. Here is my code to decompress:
 using (Stream infs = File.Open(inputFilePath, FileMode.Open))
 using (LZ4Stream lz4Stream = new LZ4Stream(infs, LZ4StreamMode.Decompress))
 using (Stream outfs = File.Open(outputFilePath, FileMode.Create))
 {
    lz4Stream.CopyTo(outfs, 1024 * 1024);
 }

The exception occurs at the CopyTo function. What i've been missing?
Thanks.

I guess this is the answer:
https://github.com/MiloszKrajewski/lz4net/blob/master/doc/compatibility.md


HBoxContainer and VBoxContainer make the last node too big (with "Expand" size flag)

Godot version: 3.2.stable
OS/device including version: Windows 10
Issue description: HBoxContainer and VBoxContainer make the last node too big
Steps to reproduce:

Add a VBoxContainer (it also happens with HBoxContainer but I'm going to describe it for V for the sake of simplicity.)

Set the VBoxContainer's size to (50, 1000)

Add a ColorRect node as a child (it can be almost any control node, the ColorRect just helps to see it better)

Go on the ColorRect's size flags and check "Expand" on Vertical

Duplicate the ColorRect until there are 60 of them. (It seems the more you add, the more noticeable it becomes, but let's stick to 60 for now). You will notice the last node is much bigger than its siblings, even though they should all be the same size since they all have the "Expand" flag.

Observation: if you drag the VBoxContainer's bottom handle, as it goes up and gets smaller it seems to only update all the node's sizes once the lowest node shrinks to the same size as all the others, the it squishes all the nodes back and makes the lowest one too big again and repeats.
(Animated GIF)

Minimal reproduction project:
vboxcontainer_bug.zip

Hmm, this is likely due to the fact the container has to split it's available size on all its children, while always using integers numbers. So there is always space left if the division is not perfect, which is apparently given to the last child.
I guess the solution might be to spread this space evenly over all expanding children.

@groud But why is it using integers in the first place? What you suggest is equal to using floating point numbers to begin with, but divided into two steps. What is the inherent limitation?

The size of control nodes uses Integers.This kind of make sense in a world of pixels.
We could find a way to have float values for Control's position and size, but I am not sure we can ensure they are going to render properly with such changes. We don't want Controls to look blurry.

One way to set lengths while keeping error even would be to keep a tally of total length, something like the following:
For each block (go from one end to the other in order):

set  length = (container length) * index / (number of control nodes in it) – (length tally)
add length to the length tally

OK, I actually kinda depend on this working correctly in my game, so I've been taking a look at the relevant code.
I think the cause is line 123 of scene/gui/box_container.cpp:
int final_pixel_size = stretch_avail * c->get_stretch_ratio() / stretch_ratio_total;

Let's say stretch_avail is 599 and there's 60 ColorRects equally expanded, ignoring separation for simplicity's sake. final_pixel_size would be floor(599 / 60) = 9, but 59 * 9 = 531. If my calculations are right, that leaves 68 pixels for the last ColorRect! That's also why adding more ColorRects exacerbates the problem: the "error multiplier" is greater.
If nobody else is working on a better implementation, I will try to make it so the size calculations use floats all the way until the final rendering step, then round to the nearest integer.

OK, I actually kinda depend on this working correctly in my game, so I've been taking a look at the relevant code.
I think the cause is line 123 of scene/gui/box_container.cpp:
int final_pixel_size = stretch_avail * c->get_stretch_ratio() / stretch_ratio_total;

Let's say stretch_avail is 599 and there's 60 ColorRects equally expanded, ignoring separation for simplicity's sake. final_pixel_size would be floor(599 / 60) = 9, but 59 * 9 = 531. If my calculations are right, that leaves 68 pixels for the last ColorRect! That's also why adding more ColorRects exacerbates the problem: the "error multiplier" is greater.
If nobody else is working on a better implementation, I will try to make it so the size calculations use floats all the way until the final rendering step, then round to the nearest integer. But one side effect of this is that the ColorRects and the separation between them may differ in size plus-or-minus 1 pixel. So there will be a noticeable loss of "pixel perfection" if the ColorRects/separation is only a few pixels in size. I don't know if this can be avoided but I think it's preferable to what we have now.

I feel like that's the best solution we can get and I don't think anyone else is working on this, considering you're the first person to reply in the past 4 months and I'm not familiar with changing Godot's source code. If you could make that pull request, I would be very grateful!