Learning rate scheduler is working incorrect

While training SRGAN model, learning rate scheduler is used in train.py with parameters step_size=epochs // 2 and gamma=0.1.
From this I suppose schedulerD.step() and schedulerG.step() to be called at each epoch.
However, they are called at each training step which means that learning rate is quickly becoming zero after a few training steps.
The SRGAN does not seem to train.
But when I put schedulerD.step() and schedulerG.step() after the epoch end, it started showing nice results.

Yeah, I found it. I will fix it.


Update project to Xcode 8 and convert to Swift 3

Includes changing AnyObject to Any, updated UnsafeMutablePointer syntax, changes to named parameters in blocks, and any other changes caught by the syntax converter.
All tests pass.
Not sure if travis build will pass given that it expects Xcode 7.3

Thanks for this @amorde.
Could you update https://github.com/kylef/JSONSchema.swift/blob/master/.swift-version to be 3.0 and the Xcode version in .travis.yml (https://github.com/kylef/JSONSchema.swift/blob/master/.travis.yml#L2) to xcode8. Then the CI should pass and this will be good to go.

Hi @kylef, thanks for the quick response! I update the Xcode version before seeing your comment, so I've updated the swift version in another commit. I can squash these if you'd like

Build failed with the following error:
 xcodebuild: error: Failed to build project JSONSchema with scheme JSONSchema.
	Reason: A build only device cannot be used to run this target.

Not really sure how to fix that :/

@amorde I can take over with that. I will tweak the CI steps.
Thanks for your pull request @amorde, I'll try and get to this tomorrow and get a release supporting Swift 3.0 out.

👍 Awesome, thanks for your support!

@kylef Hi again, I went ahead and pushed changed which should fix the build issue and also bumped the version number since I haven't heard anything in a while regarding this


Type definitions for cjs files

I encountered a problem with importing your packages in main process of my project that is based on electron-react-boilerplate. I couldn't do anything with webpack configs, so I tried importing index.cjs of each package. The problem is that there is no type definitions for these files, which is stopping me from doing anything with them.

The index.cjs's definition is exactly the same with the index.js which is using the index.d.ts.
Does the normal import work for you? The webpack should pick main in package if it doesn't have the ability to compile ESM's module .

Thanks for response!
Sadly, normal import doesn't work either.

I place dependencies in dependencies field of root package.json.

I suspected that the problem is coming from main process webpack config because there is only a prod config, but no dev config, so I can't use your main process webpack config. I didn't change anything in any of the webpack configs, so I don't really think electron-react-boilerplate supports esm packages out of the box. Maybe changing something in webpack configs will do the trick?
I also tried to add a babel plugin to transform those imports/exports but had no luck.

I just clone the electron-react-boilerplate and add the @xmcl/core in dependency and use it in the main.dev.ts. Everything looks fine for me. (Notice that I did not add any extra plugin).
You can just import them by the package name, not the file name.

I found what's causing the issue. Apparently, you can import @xmcl/* packages in main.dev.ts, but you can't import them in any other file (I tried splitting main.dev.ts, and that was causing the problem).
It's really strange and I don't really understand why it works like that. I also found several issues (here
s one of them) on electron-react-boilerplate repo about splitting main.dev.ts, so I'm not alone with this problem.
The only question I have is: if there's really a problem with splitting main.dev.ts file, why does it come up like this? What does SyntaxError: Cannot use import statement outside a module have to do with it?

I found what's causing the issue. Apparently, you can import @xmcl/* packages in main.dev.ts, but you can't import them in any other file (I tried splitting main.dev.ts, and that was causing the problem).
It's really strange and I don't really understand why it works like that. I also found several issues (here s one of them) on electron-react-boilerplate repo about splitting main.dev.ts, so I'm not alone with this problem.
The only question I have is: if there's really a problem with splitting main.dev.ts file, why does it come up like this? What does SyntaxError: Cannot use import statement outside a module have to do with it?

I'm not quite sure if I understand the splitting the main.dev.ts file correctly. Do you mean something like
(main.dev.ts)
// something else
import './myOtherFile';
// something else in main

(myOtherFile.ts)
import { launch } from '@xmcl/core'
// other code here

This works fine to me.

Yeah, that's exactly what I'm trying to achieve. But still, I have the same issue. I tried removing it from externals & moving it to devDependencies:

And I still get the same error... T-T

I fixed it. The issue was with the way I imported it.


fix header embedder request to openai-compatible api

when using LM studio I was getting an error for missing 'input' field I fixed it by adding the header in the code

Thank you! Fixed in https://github.com/pfrankov/obsidian-local-gpt/releases/tag/1.14.4


Handle synonyms

The property and graph databases are using CHEBI instead of PUBCHEM.COMPOUND.   The ontology version will only undertstand chebi since there's no ontology in pubchem.
The simple approach to solving most of this is just to rebuild the property and graph databases using the new robokop graph.  This should also allow us to remove some temporary code fixing the names of edges.
Longer term, I think we should either have equivalent_identifiers from upstream, or we should get them from the normalizer.  And then, we should use them to find the identifiers we want. This will insulate us a little bit from changes to prefix ordering in the biolink model, and allow us to do ontology reasoning even if the preferred id is non-ontological.

https://github.com/ranking-agent/strider/issues/164

Check to see if this is still an issue.


Configure clippy to use the same settings as during CI

And fix the 2 warnings seen with pedantic enabled.

LGTM


[TestAppUWP] Add support for chat channels

Add support for data channels in TestAppUWP in the form of "chat channels" transferring UTF-8 text messages. This restores parity with the old pre-multitrack version of TestAppUWP.

PR mentions "channels" but there's only one channel at the moment, right?

I think there's no "add channel" button, but otherwise the rest should work. Can fix later.


DCES-67: LocalApp Authentication Config and local CLI for Demo

…cess too
What
Link to story
Describe what you did and why.
Checklist
Before you ask people to review this PR:

[ ] Tests should be passing: ./gradlew test
[ ] Github should not be reporting conflicts; you should have recently run git rebase main.
[ ] Avoid mixing whitespace changes with code changes in the same commit. These make diffs harder to read and conflicts more likely.
[ ] You should have looked at the diff against main and ensured that nothing unexpected is included in your changes.
[ ] You should have checked that the commit messages say why the change was made.

Can you also look at the sonar issues, there's coverage and some basic smells.

Can you also fill out the description for the PR?

Will add test coverage in a following merge request


Minema does something weird when changing the resolution

I have changed the resolution in Minema to 4k in the config Files with Forge

I have allocated FFMpeg in the config Files with FIrge

I have changed my minecraft to fullscreen (Otherwise it would say an Error)

I have started the recording with F4

Minecraft showed me a small box with my Minecraft World, but the other things like my keystrokes and Hotbar Slots were Tiny

Normal Recording works

Increased FPS Workes

Increased 4x Screenshots with OptiFine works

I have a GTX 750 Ti like it was made with the demo Video

I have  more Mods: McLib, Aperture (I was intending to make 4K Vidos for me any my friends), OreLib Support Library, Dynamic Surroundings, Fancy Block Particles, LabyMod, Mo' Bends, Sound Physics, Dynamic  Surroundings: HUDs, OptiFine

Every Mod Works and  they only make the Sound or the Graphics Better, so it would be nice to keep them

This Photo is not recorded in 4K but in Full HD (I have 2 1440x900 Monitors in use)

This happens due to some Optifine option like fast render or Antialiasing in shaders options. You need to disable those.
If it still happens, try enabling Fix fast render and antialiasing option in Minema’s Capturing mod options.

Thanks! It worked now. I had Antialising on 4x...


Consumer group ignores AutoCommit flag when it exits

Versions
Please specify real version numbers or git SHAs, not just "Latest" since that changes fairly regularly.

Sarama
Kafka
Go

1.27.2
2.7.0
1.14

Problem Description
When consumer's AutoCommit flag is disabled by configuration and you mark offset during the process with session.MarkMessage(msg, "") it doesn't commit the offset as expected. However when you terminate the consumer (or rebalancing is triggered) it commits the offset ignoring the AutoCommit flag.
This is likely related to this PR: https://github.com/Shopify/sarama/pull/1699
This PR removes the check:
// flushToBroker is ignored if auto-commit offsets is disabled
func (om *offsetManager) flushToBroker() {
	if !om.conf.Consumer.Offsets.AutoCommit.Enable {
		return
	}
        ...

I test using Sarama 1.26.4 where that check is in place and it works as expected, but 1.27.2 commits the offset on Close() which is likely a bug.

Fixed by https://github.com/Shopify/sarama/pull/1846


Multiple Container

is this possible to create multiple container like in this example
https://developers.google.com/tag-manager/devguide?hl=en#multiple-containers
i tried multiple(2) initialize
but i got warning  'Multiple installations of Google Tag Manager detected ' from google tag assistant legacy (chrome extension)

Wondering the same thing - @dsc-jerome-dc  - did you manage to resolve this?
We're making a move to GTM360 and temporarily need to have two GTM containers running in our app - but we're triggering two pageload events when initializing the two containers - apart from the warning above. Any directions we could take? Thanks.

@dsc-jerome-dc where you able to find a solution to this?

Any idea how to add multiple containers?


ci: updating spec urls to match new Information Architecture in website

title: "updating spec urls to match new Information Architecture changes via https://github.com/asyncapi/website/pull/601"
301 updates due to GSoD IA changes

Related issue(s):
https://github.com/asyncapi/website/pull/601/

Wouldn't it break existing links pointing to the old URL? If so, please let's add redirects from the old URL to the new one.

@fmvilas that work is in PR 601 which is mentioned here 😜

@fmvilas that work is in PR 601 which is mentioned here 😜

@fmvilas
Let's say new release is 2.5. After changes from @alequetzalli, we get below
/docs/reference/specification/latest /docs/reference/specification/v2.5.0 302!
It is performed as "addition", not "override", it is added on top of the list
@alequetzalli so this PR is good, but you need more updates in PR on website.
this 👇🏼
# SPEC-REDIRECTION:START
/docs/specifications/2.4.0 /docs/specifications/v2.4.0 302!
/docs/specifications/2.3.0 /docs/specifications/v2.3.0 302!
/docs/specifications/2.2.0 /docs/specifications/v2.2.0 302!
/docs/specifications/2.1.0 /docs/specifications/v2.1.0 302!
/docs/specifications/2.0.0 /docs/specifications/v2.0.0 302! # The path was changed. We want to keep links pointing to the old path working.
# SPEC-REDIRECTION:END

must be 👇🏼
# SPEC-REDIRECTION:START
/docs/specifications/2.4.0 /docs/reference/specification/v2.4.0 302!
/docs/specifications/2.3.0 /docs/reference/specification/v2.3.0 302!
/docs/specifications/2.2.0 /docs/reference/specification/v2.2.0 302!
/docs/specifications/2.1.0 /docs/reference/specification/v2.1.0 302!
/docs/specifications/2.0.0 /docs/reference/specification/v2.0.0 302!
/docs/specifications/v2.4.0 /docs/reference/specification/v2.4.0 302!
/docs/specifications/v2.3.0 /docs/reference/specification/v2.3.0 302!
/docs/specifications/v2.2.0 /docs/reference/specification/v2.2.0 302!
/docs/specifications/v2.1.0 /docs/reference/specification/v2.1.0 302!
/docs/specifications/v2.0.0 /docs/reference/specification/v2.0.0 302!
# SPEC-REDIRECTION:END

so in future releases, after 2.5 it looks like👇🏼
# SPEC-REDIRECTION:START
/docs/reference/specification/2.5.0 /docs/reference/specification/v2.5.0 302!
/docs/specifications/2.4.0 /docs/reference/specification/v2.4.0 302!
/docs/specifications/2.3.0 /docs/reference/specification/v2.3.0 302!
/docs/specifications/2.2.0 /docs/reference/specification/v2.2.0 302!
/docs/specifications/2.1.0 /docs/reference/specification/v2.1.0 302!
/docs/specifications/2.0.0 /docs/reference/specification/v2.0.0 302!
/docs/specifications/v2.4.0 /docs/reference/specification/v2.4.0 302!
/docs/specifications/v2.3.0 /docs/reference/specification/v2.3.0 302!
/docs/specifications/v2.2.0 /docs/reference/specification/v2.2.0 302!
/docs/specifications/v2.1.0 /docs/reference/specification/v2.1.0 302!
/docs/specifications/v2.0.0 /docs/reference/specification/v2.0.0 302!
# SPEC-REDIRECTION:END

I hope this makes sense 😅

We need also update .github/scripts/remove-toc.js and .github/workflows/update-spec.yaml files.

We need also update .github/scripts/remove-toc.js and .github/workflows/update-spec.yaml files.

@magicmatatjahu Why do I need to update the toc file in this?
The toc changes you are working on have nothing to do with this PR. TOC updates are not IA related.

@fmvilas that work is in PR 601 which is mentioned here 😜

@fmvilas
Let's say new release is 2.5. After changes from @alequetzalli, we get below
/docs/reference/specification/latest /docs/reference/specification/v2.5.0 302!
It is performed as "addition", not "override", it is added on top of the list
@alequetzalli so this PR is good, but you need more updates in PR on website.
this 👇🏼

# SPEC-REDIRECTION:START

/docs/specifications/2.4.0 /docs/specifications/v2.4.0 302!

/docs/specifications/2.3.0 /docs/specifications/v2.3.0 302!

/docs/specifications/2.2.0 /docs/specifications/v2.2.0 302!

/docs/specifications/2.1.0 /docs/specifications/v2.1.0 302!

/docs/specifications/2.0.0 /docs/specifications/v2.0.0 302! # The path was changed. We want to keep links pointing to the old path working.

# SPEC-REDIRECTION:END

must be 👇🏼

# SPEC-REDIRECTION:START

/docs/specifications/2.4.0 /docs/reference/specification/v2.4.0 302!

/docs/specifications/2.3.0 /docs/reference/specification/v2.3.0 302!

/docs/specifications/2.2.0 /docs/reference/specification/v2.2.0 302!

/docs/specifications/2.1.0 /docs/reference/specification/v2.1.0 302!

/docs/specifications/2.0.0 /docs/reference/specification/v2.0.0 302!

/docs/specifications/v2.4.0 /docs/reference/specification/v2.4.0 302!

/docs/specifications/v2.3.0 /docs/reference/specification/v2.3.0 302!

/docs/specifications/v2.2.0 /docs/reference/specification/v2.2.0 302!

/docs/specifications/v2.1.0 /docs/reference/specification/v2.1.0 302!

/docs/specifications/v2.0.0 /docs/reference/specification/v2.0.0 302!

# SPEC-REDIRECTION:END

so in future releases, after 2.5 it looks like👇🏼

# SPEC-REDIRECTION:START

/docs/reference/specification/2.5.0 /docs/reference/specification/v2.5.0 302!

/docs/specifications/2.4.0 /docs/reference/specification/v2.4.0 302!

/docs/specifications/2.3.0 /docs/reference/specification/v2.3.0 302!

/docs/specifications/2.2.0 /docs/reference/specification/v2.2.0 302!

/docs/specifications/2.1.0 /docs/reference/specification/v2.1.0 302!

/docs/specifications/2.0.0 /docs/reference/specification/v2.0.0 302!

/docs/specifications/v2.4.0 /docs/reference/specification/v2.4.0 302!

/docs/specifications/v2.3.0 /docs/reference/specification/v2.3.0 302!

/docs/specifications/v2.2.0 /docs/reference/specification/v2.2.0 302!

/docs/specifications/v2.1.0 /docs/reference/specification/v2.1.0 302!

/docs/specifications/v2.0.0 /docs/reference/specification/v2.0.0 302!

# SPEC-REDIRECTION:END

I hope this makes sense 😅

Great feedback, thank you @derberg! I will reach out if I get confused

@alequetzalli because that script removes TOC from spec files, so you need also update that script as well .github/workflows/update-spec.yaml. We have two workflows:

when we release new version of spec
when we update existing one

and it and it we need to remove TOC, but from markdown. Please check these files and you will see that there are also docs/specifications mentions :)
https://github.com/asyncapi/spec/blob/master/.github/scripts/remove-toc.js#L12
https://github.com/asyncapi/spec/blob/master/.github/workflows/update-spec.yaml#L44

@magicmatatjahu Ah! I think I follow you now... Thanks for the detailed specifics and I'll let you know if I need more help

@derberg thanks! I have a question, because @derberg you added a comment about redirects (here https://github.com/asyncapi/spec/pull/801#issuecomment-1151029124) and I wonder if we need to change the script to produce 2 redirects for each spec, for docs/specifications/... and docs/reference/specification/.... What do you think?

Should be merged after asyncapi/website#601

We'll have you merge them right @derberg? I assumed it made the most sense for you to be the maintainer to merge both when ready.

/rtm

Forget about the last comment saying it was released in version 2.5.0-next-major-spec.1. I made a mistake and it created this version but it should actually be 3.0.0-next-major-spec.1. There's a notice in the release. Apologies for the noise.

Recent comments about the release from the bot were added by mistake. More details in https://github.com/asyncapi/spec/issues/899


Fix Bugs

Get everything ready to turn in
Bugs:
Anything can be entered into the sign in and register fields
Get time from pirate weather

Input entered in the text fields for login and register screen is not retained upon activity restart (e.g. screen rotation)


Availabile delete target output data when use cloud storage

When I use the change the target path to the cloud storage, I can't delete the labeled data in the s3.
If I delete the output data, the label-studio would show the error message. Otherwise, the delete icon also be hidden on web UI.
I found that if the target output data path was set to cloud storage , the 'can_delete_tasks': self.can_delete_tasks set to false.
By the way, the cloud storage delete command is not implemented.

@bruce32118 we resolved that the deletion of completions for storages has very complex logic with a lot of unwanted side effects for users. Therefore it's bad by security reasons: user could delete his important data from storage unexpectedly.

@makseq There some error in using cloud storage. If I delete the target file in the s3 by AWS console.

Is it a bug?

As I mentioned before - we don't support deletion for the target storage.

@makseq Thanks for your response.

But we will develop more features for storage in the next releases.


Undefined fieldWeight throws an error during complexity anlaysis

If the fieldWeight is undefined during complexity analysis then an unhandled error is thrown. These errors should be handled in development environments to provide clarity on why the fieldWeight is undefined. Production environments should attempt to default to a logical complexity value.

Reassess this after updates to code base in PR #66

After the refactor in #66, this occurs if an invalid parentName is provided  when obtaining a resolvedTypeName in the fieldNode function. Temporarily fixing this in work on #44 by throwing an error if the parentName doesn't exist on typeWeights either due to capitalization or an invalid query (the latter case should be caught during schema validation).
We'll need to decide on how to handle this in a production environment.


Removes pending changes

@doomspork what gives with this error? it was the problem I had locally FYI and I ended up switching distros to be able to work on it.


MM-37775 - New run permissions

Summary

Moving to a permissions model where the decision steps are:

Are you an admin? If so, you can see that run info.
Can you view the playbook the run is based on? (either the original playbook is public to the team and you're a team member, or the playbook is private and you're a member of the playbook) If so, you can view the run.
Are you a guest? If so, you can see that run info only if you a channel member.

Ticket Link

https://mattermost.atlassian.net/browse/MM-37775

Checklist

[ ] Telemetry updated
[ ] Gated by experimental feature flag
[x] Unit tests updated

I've assigned myself https://mattermost.atlassian.net/browse/MM-38136 for next week so that I can work on the threaded replies.

@lieut-data I think this is ready to go now -- #719 verifies the different combinations work as expected.
We'll need to make announcements on community explaining the new permissions scheme to everyone (hide your sensitive playbook names, checklists, and retros by making the playbook private). Maybe @justinegeffen should work on that, or is it okay if I do it?

@cpoile, please do take the lead on drafting and disseminating that information, but feel free to rely on @justinegeffen as needed!

Happy for you to do it, @cpoile! And of course always happy to lend an editorial eye. :)

@stephenvanhemmen This is an example notification. (Just a test for the checklists notification feature)


Map|ShouldMap - set value to default(T) of given T source property

Hello,
I've seen some weird behavior when using the shouldMap option of the Map method. The wiki page regarding this feature explains that if the condition is not met, the destination property is set to null or default value. But the default value seems to be the one of the property's source type.
For instance, given the following classes:
public class Dest {
  public DateTimeOffset? Start {get;set;}
}

public class Src {
  public DateTimeOffset Start {get;set;}
  public bool HasStart {get;set;}
}

and the given configuration
/*...*/
  NewConfig<Src, Dest>().Map(dest => dest.Start, src => src.Start, src => src.HasStart);
/*...*/

Adapting Src to Dest with HasStart = false will give use the following result: Dest.Start = 0 (because 0 is the default value for a DateTimeOffset which is the type given in the mapping).
One of the solution I found to prevent this issue in my code is to cast the given type of the src to the destination type :
NewConfig<Src, Dest>().Map(dest => dest.Start, src => src.Start as DateTimeOffset?, src => src.HasStart);
but this does not feel very natural.
To conclude, I am not sure if the issue comes from the code or the documentation. As explained, there is a easy fix for the time being, but maybe the wiki page could be updated accordingly or the code (depending of what feel more suitable)

You can also use IgnoreIf to test condition and not map, Map setting will map to default value of source type if condition is not met. You can help update Wiki if it is confusing.
I will keep this issue open, and will try to fix if I have time. I agree that it is not natural.

You can also use IgnoreIf to test condition and not map, Map setting will map to default value of source type if condition is not met. You can help update Wiki if it is confusing.
I will keep this issue open, and will try to fix if I have time. I agree that it is not natural.


Cutscenes issues

Translator window (in no replace mod) doesn't pop up in cutscenes.

Replicas that appear without a window (such as in this screenshot) are not translated

About the 1st topic: It is in my TODO list. It is being reworked in the new Dalamud API branch and hopefully it will be fixed.
About the 2nd topic: There are some in-game texts like that from the screenshot that are untranslatable because they are images instead of real text lol. (Thanks S.E.)  Unless we come up with a way to index those lines and translate those texts independently and attach a translation window to them, unfortunately they will remain like that. If someone can help with this topic it will be greatly appreciated <3

Unless we come up with a way to index those lines and translate those texts independently and attach a translation window to them, unfortunately they will remain like that. If someone can help with this topic it will be greatly appreciated <3

Tataru Helper already found how to index.

Unless we come up with a way to index those lines and translate those texts independently and attach a translation window to them, unfortunately they will remain like that. If someone can help with this topic it will be greatly appreciated <3

Tataru Helper already found how to index. Probably these replicas are duplicated in the event chat.

Yes. They rely on the chat event which I chose not to for this plugin.
Still there are some cutscene texts that do not get posted to chat. Also, I'm not copying their code unless they give me permission to. My aim with this project is not having to rely on an independent program to do the job. Their program requires you to run the game in Borderless Windowed (which can impact performance) and Dalamud does not. But if I (or a helping hand) come up with a solution that complies with Dalamud i'll implement it of course.

Implemented in v3.7.x


Remove warnings on 1.8-dev

There's one other warning on master that would require bumping Elixir version requirement:
warning: Inspect.Algebra.surround_many/5 is deprecated. Use Inspect.Algebra.container_doc/6 instead
Found at 3 locations:
  lib/ecto/changeset.ex:2552
  lib/ecto/query/inspect.ex:16
  lib/ecto/query/inspect.ex:30

:heart: :green_heart: :blue_heart: :yellow_heart: :purple_heart:

We can survive with the surround_many one for a bit. :)

Yup that's what I've figured!


I'd like to join this project's community

Your public repo
https://github.com/techxorcist/gov4git-identity-public.git
Your public branch
main

This was opened by Gov4Git when I installed the app and added this repo following my approved PR (thanks @GlenWeyl).

Approved.

 Follow up
On Tuesday, 30-Jul-24 17:49:15 UTC by Gov4Git dev
@techxorcist was added to the community.


ci: Added a release pipeline with changeset

Included:

Added a release pipeline with changeset

What's next?

Adding a USAGE documentation

Full disclosure, there seems to have a weird issue with first version when using changeset.
On every push to master, the action
1- Checks if the version specified in the package.json exists on npm
2- If it does not exists, it publishes it.
3- Check if there is a changeset file available
4- if there is a changeset file detected, it creates a pr with version update.
This works great for every version except the initial version. When merging this Pr, it will
1- Check if the version specified in the package.json exists on npm --> Nope, version 0.0.0 does not exist
2- publish to npm version 0.0.0
3- Check if there is a changeset file available -> Yup!
4- new pr is created to change version 0.0.0 to version 0.0.1


While edit fields click on done, keep open edit field (should be closed)

Please, assign this to me :)
Would like to fix that

on hover still edit icon is visible, need to fix that as well.

@abhir9 Can I work on this issue? Or is there any other feature you would assign me for? Open and excited to contribute to loginRadius

Got you @abhir9 , gonna fix that today


Creating a new empty project theme breaks Godot's editor (eg. color assignment)

Godot version: 3.1.1 (stable/official)
OS/device including version: Linux (Manjaro)
Issue description: In some circumstances, creating an incomplete theme and assigning it as the project theme, and then restarting the editor, causes the actual Godot editor to break; for example, you can't see anything you type when setting a color:

Steps to reproduce:
I was not able to reproduce this issue entirely by following these steps, but here goes:

Create a new project
Create a 2D scene, add a progress bar, specify a new theme object on it, and save the theme
Go back to project settings, and assign that theme as the project theme (under Theme)
Edit the theme, and pick "create new empty theme"
Restart the editor
Add a ColorRect and try to assign the color

This didn't reproduce the problem, but when I copied these contents over my global theme file (from a project where this does break), the problem reproduced. I didn't create/edit this file by hand, it was made by some combination of creation in the editor (I think creating a new theme, or creating a theme from the current Godot editor theme):
[gd_resource type="Theme" load_steps=3 format=2]

[sub_resource type="StyleBoxFlat" id=1]
bg_color = Color( 0.2, 0.2, 0.2, 1 )

[sub_resource type="StyleBoxFlat" id=2]
bg_color = Color( 0.752941, 0, 0, 1 )

[resource]
ProgressBar/colors/font_color = Color( 0.941176, 0.941176, 0.941176, 1 )
ProgressBar/colors/font_color_shadow = Color( 0, 0, 0, 1 )
ProgressBar/fonts/font = null
ProgressBar/styles/bg = SubResource( 1 )
ProgressBar/styles/fg = SubResource( 2 )

Minimal reproduction project:
ThemeBreaks.zip

Seems fixed in 3.2.3


Question: getting "Error: ENDED authentication_failed doesn't contain protocol(NUMBER)" when performing backend search

After searching for a word in the backend, logged in as admin, I get the error:
"Error: ENDED authentication_failed doesn't contain protocol(NUMBER)"
I am using docker and two containers - one for archivebox, other for sonic backend search. I have used the sample docker-compose file from https://github.com/ArchiveBox/ArchiveBox/blob/master/docker-compose.yml having changed "SEARCH_BACKEND_PASSWORD" to my custom password.
In sonic configuration file I have changed "auth_password" to that same custom password, and inet to "<IP_ADDRESS>:1491".
Can someone help me debug this? Thank you.

Thanks for reporting @bmscmoreira we'll take a look. @jdcaballerov do you have any ideas?

Thanks for reporting @bmscmoreira we'll take a look. @jdcaballerov do you have any ideas?

@bmscmoreira Are you setting the env var SEARCH_BACKEND_PASDWORD to pass the new password to the ArchiveBox container?

@bmscmoreira Are you setting the env var SEARCH_BACKEND_PASDWORD to pass the new password to the ArchiveBox container?

Thank you @pirate and @jdcaballerov for your quick help. I was indeed missing the SEARCH_BACKEND_PASSWORD env variable in the archivebox service in my yml file.
May I suggest you add that line to line 26 here? - https://github.com/ArchiveBox/ArchiveBox/blob/master/docker-compose.yml
Thanks!

Thank you @pirate and @jdcaballerov for your quick help. I was indeed missing the SEARCH_BACKEND_PASSWORD env variable in the archivebox service in my yml file.
May I suggest you add that line to line 26 here? - https://github.com/ArchiveBox/ArchiveBox/blob/master/docker-compose.yml
Thanks!

@bmscmoreira great!, yes I think it's useful to have it there so it's explicit.

@bmscmoreira great!, yes I think it's useful to have it there so it's explicit.


The mod does not want to work with the Curios API

Incorrect operation with the Curios API mod starts and works well, but if you use additional slots of the Curios API mod (1), the game crashes immediately. I tried it on several versions (2), but nothing has changed.

crash-2024-01-19_23.16.13-client.txt

oops, I never accounted for there being more slots in the inventory when I wrote the code that's causing the crash. Easy fix.

Fixed in 20.1-0.4-v2 & 20.2-0.10-v2


Improve text scale support on TextBox and NavigationView buttons

Some TexBlock with glyphs don't properly ignore the system text accessibility setting and, for the NavigationView button, can scale beyond the control limits.
Description

Disable IsTextScaleFactorEnabled on the NavigationViewPaneSearchButtonStyle, ported back from WinUI 3.
https://github.com/microsoft/microsoft-ui-xaml/blob/2a60e27c591846556fa9ec4d8f305afdf0f96dc1/controls/dev/NavigationView/NavigationView_themeresources.xaml#L343

Disable IsTextScaleFactorEnabled on the RevealButtonstyle for the PasswordBox control.

Disable IsTextScaleFactorEnabled on the DeleteButtonStyle for the TextBox/NumberBox/PasswordBox/AutoSuggestBox controls

Motivation and Context
Provide better accessibility text size support.
How Has This Been Tested?
Created a test app WinUI 2 with and without the changes.
Screenshots (if appropriate):

Before
After

@microsoft-github-policy-service agree


Adds support for the Wallets India (wallet_IN) payment method and browserInfo for Netbanking India (onlinebanking_IN) payment method

Summary

Adds support for the Wallets India (wallet_IN) payment method and browserInfo for Netbanking India (onlinebanking_IN) payment method
Tested scenarios

Fixed issue: COWEB-1066

Excellente idée.


Make most statistics that may not exists Option<T>

Removed all statistics that may not be computed.


🙏 How to redirect/rewrite by different user agent ?

How to redirect/rewrite by different user agent?  for mobile devices and pc devices

We don't support rewrite/redirect by user agent at this time


Feathers.authenticate gives window undefined (server-rendered)

Expected behavior
feathersClient.authenticate({ strategy: 'jwt', accessToken }) should authenticate the user, the accessToken is a valid token which I'm taking from the "req" object (server rendered).
Actual behavior
ReferenceError: window is not defined
    at Object.setItem (src/client/helpers/ssr-storage.js:13:4)
    at Passport.setJWT (/current/CURRENT/PROJECT/node_modules/feathers-authentication-client/lib/passport.js:282:33)
    at process._tickDomainCallback (internal/process/next_tick.js:135:7)

I receive a window is not defined error, but I am rendering server-side (NuxtJs / Vue)
Module versions (especially the part that's not working):
"feathers": "^2.1.1",
"feathers-authentication": "^1.2.6",
"feathers-authentication-hooks": "^0.1.4",
"feathers-authentication-jwt": "^0.3.1",
"feathers-authentication-local": "^0.4.3",

@jarnojellesma I don't think feathers-authentication-client uses window, at all.  This might be happening because you're passing a storage option that does use window.

up, how fix it?

@andysay if you're going to build a server side rendered app, you have two options to fix this:

Don't use window anywhere in your code.
Shim window and window.localStorage on the server.

  return feathersClient.authenticate({ strategy: 'jwt', accessToken })
      .then((response) => {

        return feathersClient.passport.verifyJWT(response.accessToken);
      })
      .then(payload => (
         feathersClient.service('users').get(payload.id)
      ))
      .then(user => {
        feathersClient.set('user', user);
       console.log('User', feathersClient.get('user'));
      });

its Example like doc , but if i refresh webpage ReferenceError: window is not defined
but i not use window anywhere

@andysay Do you have a stack trace for the error?  Next step is to find the line of code causing the error.
Also, the window.localStorage would be in the feathers client setup, usually, if that were the problem.

@marshallswain i found               token = window.localStorage.getItem(cookieName);
what to replace this ?

@andysay where did you find that?

@marshallswain in client side

@andysay If you want my help, you'll need to provide more information.  Otherwise, you'll just have to figure it out.


Windows support?

Hi,
I was trying to run pymzn on my windows machine and it got stuck on a Linux command. This is the traceback:
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "C:\Users\jver\AppData\Local\Programs\Python\Python35\lib\site-packages\pymzn\_mzn\_minizinc.py", line 161, in minizinc stdlib_dir=stdlib_dir)
  File "C:\Users\jver\AppData\Local\Programs\Python\Python35\lib\site-packages\pymzn\_mzn\_minizinc.py", line 295, in mzn2fzn run(args)
  File "C:\Users\jver\AppData\Local\Programs\Python\Python35\lib\site-packages\pymzn\bin.py", line 105, in run preexec_fn=os.setsid) as process:
AttributeError: module 'os' has no attribute 'setsid'

+1 to @jgjverheij's question. I have also got stuck at the same point

+1
really hope this awesome package would work in windows!

Latest release seems to work fine on Windows.


new hook: check-model-has-tags

Describe the feature you'd like
Currently we have check-model-tags hook which fails if the model has any additional tags that are not specified in the hook.
It would be a good idea to check if the model contains specific tags in the provided list, that is, if the model has tags: ['intermediate', 'product', 'sales'], and in the hook we just list ['intermediate'], then it should succeed. In other words - we check if the model has particular tag.
Perhaps this could be another hook named check-model-has-tags which would be very similar to the current implementation of check-model-tags, except we check if valid_tags is subset of model_tags and not the other way around.

@BAntonellini if this makes sense, I could try and implement this.


chore: use expect(..) instead of assert(..)

Issue #240
Description of changes
Used expect instead of assert for all unit tests
Checklist

[N/A] Created unit tests in tests/unit and/or in Rust for my feature if needed
[X] Ran make fix to format JS and apply Clippy auto fixes
[X] Made sure my code didn't add any additional warnings: make check
[N/A] Updated documentation if needed (API.md/README.md/Other)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Fantastic! Can we now remove deps on assert and update docs? Readme references assert module

Definitely, but with all the changes I think it would be better to do it in a second PR. What do you think ?


Turning off ABC checkbox gives lower case, not title case

ok, I think the best situation as mostly as suggested in the previous post.
Checkbox on, all fields are capitalized.
Checkbox off, the first character is capitalized, all other characters are left alone. This way names like MacDonald can be entered as printed without interference.
Fixed in 1.0.7


lncfg: normal TCP resolution for the all-interfaces IP

Use normal TCP resolution for the all-interfaces IP (<IP_ADDRESS>) instead
of using the Tor resolver.
Fixes #6339

Ok, so I dug into #6378 and realized we had a regression on the btcd side. That's been fixed by this btcd commit: 074266215c26f8c4731330abb515f92b905f8dfa. Can you also update the go.mod in this PR to point to that? Easy command to do it:
go get -v github.com/btcsuite/btcd@074266215c26f8c4731330abb515f92b905f8dfa
go mod tidy

I've made an issue on the btcd side to track the update to allow IPv6 response parsing for the Tor SOCKS resolution.

added the go.mod update @Roasbeef  👍


Revamp parallel testing scripts

A little cleanup of the CI scripts and a better way to disable problematic specs from parallel execution directly from the scripts.

Can one of the admins verify this patch?

CR please, @gfiorav

Much better! 📦 when tests pass


Unexpected quoting of cell values that contain leading or trailing spaces

What OS?

Mac

Description
When working with a file that has cells with leading or trailing spaces, quotes are always added to those cells, ignoring the values of the related settings:
"csv-edit.newColumnQuoteInformationIsQuoted": false,
"csv-edit.quoteAllFields": false,
"csv-edit.quoteEmptyOrNullFields": "false",
"csv-edit.retainQuoteInformation": true,

Expected behavior
When loading, modifying, and saving a file with the above settings, existing cell values that have extra spaces should not be automatically quoted.
Steps to reproduce
I've only tried this with pipe "|" delimiters, but the following example should demonstrate the issue...

Create a file (e.g. "test.csv" with the following contents:

foo     |   bar  |biz
baz     |boz| buz

Make a minor change to one of the cells and save:

Quotes are introduced into the original file:

"foo     "|"   bar  "|bizb
"baz     "|boz|" buz "

Per the rules described here, I assumed that the row starting with foo would be used to determine quotes, and none of the cells in that row have quotes.
It's possible that this is correct behavior, or that the settings to get the behavior I want are different than what I'm using.
The desired behavior would be very useful when working with files that have aligned columns.
Workaround
I found a workaround with the Rainbow CSV extension; if I "shrink" values, then use Edit CSV, and then re-align columns, I can get the end result I wanted, but the extra steps are a bit tedious.

The Retain Quote Information Rules settings work as expected but is not related to this.
This comes from papaparse, which handles the parsing of CSV files itself.
It always adds quotes when necessary (necessary in the sense of papaparse). This is also the reason why |boz and bizb are not put in quotes.
Quotes are added if the field itself contains the delimiter or quotes and begins or ends with a space.
The part starts or ends with a space is a decision made by papaparse to make the csv file more deterministic.
Some csv parsers might ignore the spaces between the text and the delimiter, so the spaces would be lost.
By inserting quotes, all parsers are forced to take the spaces into account.
Just to be sure, do you expect the spaces to be ignored when the file is opened, or should only the quotes be removed?

@janisdd - thanks for the response!
Ideally, if the cell doesn't have spaces to begin with, if I make a change to that cell, I'd like the changed file to also not have spaces
So in the example above, I'd simply end up with:
foo     |   bar  |bizb
baz     |boz| buz

(no quotes are added to any of the cells, and the cell that I modified also does not have quotes, because it didn't in the first place)
Here's another example; suppose I have this initial input:
foo     |"   bar|  "|bizb
baz     |boz| buz

In this example, bar must be quoted because it has a pipe character in it. So, if I edit that cell, and remove the pipe, I should end up with:
foo     |"   bar  "|bizb
baz     |boz| buz

In this example, the plugin respected that the cell had quotes to begin with, so it included those when it wrote back out.
Now that I know that the settings are working as-expected, this issue is more like a feature request than a bug. It also sounds like the dependency on papaparse might prevent this capability.

When the content is written back to the file, the quotes are probably not necessary if there are only spaces. I'm not sure why papaparse does this, but I maintain my own copy of papaparse for this plugin. I can take a look at the code and see if I can find anything there.
The other problem concerns the course information when reading the file. Currently, the course information is only stored per column (first cell in each column). This is to reduce memory usage (and was somewhat easier to implement).
But using more memory is probably ok if it implements the function.
The only question would be how to set the quote information for newly created fields. Probably not quoting would be best. (Or change the option newColumnQuoteInformationIsQuoted to newCellQuoteInformationIsQuoted and set it to false).
Ultimately, saving the initial quote for each field is probably inevitable as the user expects it.
However, changing all this is a lot of work and will take some time, and I'll have to see if the first problem can be solved.

Just a quick update: I found an issue at papaparse that raises an interesting question in this context.
If you have
a,b,c

you expect a, b, c
If you have
a, b, c

you expect a,  b,  c (with space)
but if you have
a, b, "c"

what should one expect to happen? The quotes clearly indicate that c should have no leading space.
However, what should be done with the space after the , and before the "?

Here are my thoughts:
Basically, having an "aligned" version of a CSV seems like a common use case, and it makes sense for a tool to do this by introducing leading and trailing spaces.
When a user puts a explicit quotes into the cell, it should indicate that the entire cell is "verbatim", i.e. everything in there, including leading spaces, trailing spaces, and instances of the separator, are to be treated as part of the cell value.
With papaparse, it is assumed that leading/trailing whitespace should always be quoted; this happens at this part in that source code. FWIW, this is in the [main branch]( as well, and is pretty old, looking at the blame
IMHO, the assumption that PapaParse makes is somewhat debatable. I would expect that a parse->unparse that makes no changes should yield no changes to the input file, but papaparse doesn't support that.
Since you're maintaining a copy of papaparse, probably the simplest way to get this behavior is to have an option that just flat-out disables the quoting, so that whatever you put in, you get out (minus edits, of course).
I took a crack at this; I'll post a PR. It will likely need some changes, as I've not worked with vscode plugins before.

I agree that parsing->unparsing should cause no changes. If the user does not make any changes, this is easy. However, the user can change the structure of the table (e.g. delete rows/cols, insert rows/cols, sorting). Every edit has to be tracked and synced with the quote information.
When parsing, quotes must be respected. If unparsing disables quoting (disableAutomaticQuoting), the result will definitely be different from the input (if the input had quotes).
Also, in some cases having quotes in the output is inevitable (the other conditions in the if):

cell value contains "
cell value contains the delimiter
cell value contains a new line

This may not be the case with the original entry, but the user can make changes to the cell values.
Thanks for the PR, but I think I'll try to track each cell individually.
BTW, my copy of papaparse is maintained in https://github.com/janisdd/PapaParse in the branch fix609_main (in case I need to use it somewhere else).
I already added some options to disable leading and trailing spaces here: https://github.com/janisdd/PapaParse/commit/cbaa3e59b6aa112377959da9300e7cf762ffb096#diff-fbb8d0b19dc4586fadd80f52a7b49415d2d41a5fdccaeaa728f7fca51cfbbb29R595
The latest version can already output information about the input file, which cells have been quoted.
Only the hard part with the tracking of structural changes to the table is still missing (in this extension).
Anyway, when this is completed, the leading and trailing spaces in the input file still become spaces in the cell values, just the quotes in the output are missing. This is what the csv rfc says and what I (and probably others) would expect from the csv parser.

okay! I'll close the PR, and try out the plugin when the change is available. Thank you!

Initial tests look good... However, I discovered some major problems with handsontable (index handling). Fixing this problem could potentially affect every function of handsontable. It happens whenever the visually displayed rows (visual indexes) and the actual rows (physical indexes) are different, e.g. after sorting or moving rows/columns in combination with adding/deleting rows/col.
This means that the problem also affects the quote information, as we must track all changes (indices).
It is also the reason why some features don't work as expected, e.g. https://github.com/janisdd/vscode-edit-csv/issues/131
The long-term goal would be to fix the core index issue, but this requires reviewing and testing every handsontable function that uses indexes (almost all of them).
I'm a bit hesitant to release this as it can mess up quote information in some circumstances (described above)...
However, for most use cases it will work fine. Perhaps the previous behaviour that the first cell in the column determines whether a cell is quoted can be kept and the option to track each cell individually can be enabled manually (with a note that there are some issues).

I have also added the options forceQuoteLeadingWhitespace and forceQuoteTrailingWhitespace which can be used to force quotes in cells with leading or trailing spaces.


Binary buffering?

Hi, I love your library so far, great work!
I currently plan on utilizing it in a new project I am working on, but to really get it's full potential I'd love to be able to buffer my circular json as binary data (so I can reconstruct it piece-meal on the client, but still use it while it is being buffered).
Is there a way I can accomplish this in conjunction with your library? From what I can tell so far, CircularJSON.stringify-ing my json before buffering it doesnt actually give me any advantages so far (other than the capability to even transmit the data in the first place ;] ) : I have to wait for the whole buffer to finish on the client before being able to use the data. I also can't target the more "relevant" data.
Do you have any suggestions?

you need a way to buffer JSON in the first place, then I'd say it's quite straight forward because all revival operations are made when the object is already known.
// plain Array
[o1, o2, o1, o3, o2]
// after CircularJSON
[o1,o2,~0,o3,~1]

while deserializing indexes (or keys) like ~0 or ~1 will always have a previously unserialized object as reference.
TL;DR this should work out of the box but only if you have a mechanism to stream JSON and parse it as stream


BPM loaded incorrectly - e.g. 1.2815E+16

Version:
Beat Saber v0.11.1
Song Loader 4.2
How to reproduce:

Download Waiting for love - Avicii
Play the song
All notes skip you or run into you at the very beginning

Possible cause:
BPM is set to a float
"_beatsPerMinute":128.14999389648438,

The value seems to be off by the factor 10^14 while the digits are the same as in the json file.

This has been fixed with this commit https://github.com/xyonico/BeatSaberSongLoader/commit/7af0d1f4419defb5f3fa13d8baea349b99c084c0
The problem was I wasn't stating a specific culture when converting the text to number, so for some system languages a decimal is separated with commas instead of periods.
I'll close this issue when the release is out.

This is been fixed with this release:
https://github.com/xyonico/BeatSaberSongLoader/releases/tag/v4.2.2

Thank you 👍
I know that problem from my .NET projects :/
PS: Sorry for the duplicate issue 🙈


Sometimes app crashes with "The render was aborted by the server without a reason" (Unable to enqueue)

I don't know why it happens. I can't isolate it to reproduce this error. It just happens sometimes. I put the log:
Error: The render was aborted by the server without a reason.
    at abort (/Users/emgp/Projects/example_app/clients/browser/node_modules/.pnpm/react-dom@19.0.0-rc-fb9a90fa48-20240614_react@19.0.0-rc-fb9a90fa48-20240614/node_modules/react-dom/cjs/react-dom-server.edge.development.js:7074:17)
    at Object.cancel (/Users/emgp/Projects/example_app/clients/browser/node_modules/.pnpm/react-dom@19.0.0-rc-fb9a90fa48-20240614_react@19.0.0-rc-fb9a90fa48-20240614/node_modules/react-dom/cjs/react-dom-server.edge.development.js:8620:21)
    at readableByteStreamControllerCancelSteps (node:internal/webstreams/readablestream:3022:37)
    at [kCancel] (node:internal/webstreams/readablestream:1166:12)
    at ensureIsPromise (node:internal/webstreams/util:192:19)
    at readableStreamCancel (node:internal/webstreams/readablestream:1887:5)
    at node:internal/webstreams/readablestream:1439:15
    at complete (node:internal/webstreams/readablestream:1323:9)
    at shutdownWithAnAction (node:internal/webstreams/readablestream:1319:5)
    at node:internal/webstreams/readablestream:1438:14
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
node:internal/webstreams/transformstream:488
    throw new ERR_INVALID_STATE.TypeError('Unable to enqueue');
    ^

TypeError: Invalid state: Unable to enqueue
    at new NodeError (node:internal/errors:405:5)
    at transformStreamDefaultControllerEnqueue (node:internal/webstreams/transformstream:488:11)
    at TransformStreamDefaultController.enqueue (node:internal/webstreams/transformstream:301:5)
    at Timeout._onTimeout (file:///Users/emgp/Projects/example_app/clients/browser/node_modules/.pnpm/waku@0.21.0-alpha.2_react-dom@19.0.0-rc-fb9a90fa48-20240614_react-server-dom-webpack@19.0.0-r_loaivdwzpiimz52uywzu27muau/node_modules/waku/dist/lib/renderers/html-renderer.js:109:32)
    at listOnTimeout (node:internal/timers:569:17)
    at process.processTimers (node:internal/timers:512:7) {
  code: 'ERR_INVALID_STATE'
}

@emilgpa Which version are you using?
@himself65 Is it related something we fixed (or not?) recently?

@dai-shi I forgot to mention it: version 0.21.0-alpha.2

Hm, it might be something different from what I imagined. (AFAIR, @himself65 found a way to reproduce a similar error.)

Should be fixed in https://github.com/dai-shi/waku/commit/d315ceb5540f23e97997a3dbe7139a921a5739f9

I think because react will hold a stream to be locked when it throws an error and cause upstream hono cannot process correctly.

Should be fixed in d315ceb

That's included in 0.21.0-alpha.2. 🤔

let me check

Error: The render was aborted by the server without a reason.

I saw it when developing something. It happens when I restarted the server?

npm run examples:dev:12_css reproduces it 100%.
It's triggered by [vite] page reload @stylex-dev.css, which is also an issue.

I'm not sure if this exists in the new version.
Please open a new issue with reproduction steps.


fix: MergeProps is not inferring the types correctly

This pr tries to fix partially the issue related of mergeProps return type issue with generics types. #982
There are some issues still not resolved and I would like your advice / opinion to continue
I think the Override type has something missing but I didn't manage to get a definitive fix😢, currently with the extra inference the returned object mostly return the correct type, but fails when using Omit
Playground
https://playground.solidjs.com/?hash=-238626028&version=1.4.1

A lot of the issues seem to be caused by it now excluding non-objects (which should be only null and undefined; I forgot to change that). If we try to compromise and ignore those instead, we get somewhat closer to what we want: https://tsplay.dev/w2aMbW
However I'd consider reverting as well.

I think the issue now is that you are always merging T and U they are not object. This will cause a conflict imho.
With a conditional all issues seems resolved https://tsplay.dev/mAyMvm

In that case it can be simplified further, since extends object will already distribute the generics as desired: https://tsplay.dev/WKqMpN
However test1.prop is still not "a" | "b", currently it passes because "a" was assigned to it so typescript narrows it down to "a".

so the problem now is Omit which is not distributing the types correctly?
https://tsplay.dev/WJqMVm

I think it looks good. I think the tests have to pass though, so maybe ts-expect-error the todos, and comment out or remove the test for non-object types since it's not applicable anymore.
Some observations:

Even without using object and instead just distributing with any, it seems to work identically: https://tsplay.dev/N9EM3N
never instead of U & T is what seems to affect mutability: https://tsplay.dev/mMM2Zm, though as far as I can tell using U & T doesn't seem to cause any unwanted behaviour either. Considering the else branch seems to be unioned with the rest of the type, I find it weird that never seems to affect the type somehow.

Which "non-object" test types do you mean?
Anyway, I'm thinking about this possible case which is currently failing.
I don't know if I understand mergeProps correctly, but shouldn't the type be "number" now instead of { a: 1 } & number?
const m4 = mergeProps(
  { a: 1 },
  1,
);
type M4 = typeof m4;
// this fails either with number or number & { a: number }
type TestM4 = Assert<IsExact<M4, number>>;

The test was written as mergeProps would ignore all non-object types. Currently it ignores only nullable types. The test should probably pass with number & { a: number } but it passing is probably not that important since it's unlikely that a number would be a props object. Regardless it looks like using any instead of object in Override solves this, though I'm not sure why exactly.
Ideally it should also treat nullable props as if all the properties were optional e.g. mergeProps({a: 1} as {a: number} | null) -> {a?: number}, but trying to do so seems to break generics.

If mergeProps ignore all non object types, shouldn't be something like this?
https://tsplay.dev/WoGpLW
even if I couldn't manage all cases with this signature

It should only ignore null and undefined. Other than that the way it interacts with non-object types is not really important.

Currently it doesn't skip

It should only skip null and undefined as described above. Other than that the way it interacts with non-object types is not really important, though the implementation will not exclude them e.g. mergeProps(1) includes all number methods.

Currently this test is always failing
const m4 = mergeProps({ a: 1 }, 1, null, undefined, () => 1, "", 3, { a: 1 });
type M4 = typeof m4;
type TestM4 = Assert<IsExact<M4, { a: number }>>;

m4 is never if we pass a null, undefined, or an object | null type, is it correct?

It should always fail with the current changes. The test should not test for anything but null, undefined and unions of those two with objects. However I doubt it is possible to make it pass while not breaking generics which has a higher priority than correctly typing nullables.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 89.091%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1235

Relevant Lines:
1318

💛  - Coveralls

Thank you


[BUG] Username field too short

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
Username field is restricted to 20 chars. Not enough for some users, for example when using a proxy gate with long user:host names:

Expected Behavior
Longer username field restriction for new monitored hosts.
Steps To Reproduce

docker compose
default config
add new monitored host
username field restricted to 20 chars

Environment
HertzBeat version(s): v1.5.0

Debug logs
No response
Anything else?
No response

I can fix it.


Remove Heim as a dependency (it looks to be abandoned)

I ran into transitive version dependencies created by heim (conflicts with once_cell when attempting to use autocxx in a downstream crate), so I removed it by relying on a build script and Cargo environment variables.
I haven't tested this on other platforms yet though, so until CI is up and running, we may want to hold off?

I am facing a similar problem when I developed the Rust library for mlc-llm and tried publishing a crate to crates.io so that developers could view the library docs.
Since the Heim project is not maintained anymore, I am facing this issue:
error: failed to prepare local package for uploading

failed to select a version for the requirement platforms = "^0.2.0"
candidate versions found which didn't match: 3.2.0, 3.1.2, 3.1.1, ...
location searched: crates.io index
required by package heim-host v0.0.11
... which satisfies dependency heim-host = "^0.0.11" of package heim v0.0.11
... which satisfies dependency heim = "^0.0.11" of package tvm-build v0.1.0
... which satisfies dependency tvm-build = "^0.1" of package tvm-sys v0.1.1-alpha
... which satisfies dependency tvm-sys = "^0.1.1-alpha" of package tvm-rt v0.1.0-alpha
... which satisfies dependency tvm-rt = "^0.1.0-alpha" of package mlc-llm v0.1.0 (/home/yuchen/mlc-llm/rust)
perhaps a crate was updated and forgotten to be re-vendored?

The 0.x versions of the platforms crate has all been yanked, but tvm-build still depends on it because of Heim is a dependency, so it's better to remove Heim as a dependency.
I think this PR should work, an alternative is using the sysinfo crate.
@jroesch, do you mind reviewing this PR and publishing a new version to the crates.io?

@binarybana @YuchenJin, is this PR ready to merge? I have a fix on top of it for building on aarch64 Darwin. Seems like the target is hardcoded to arm64-apple-darwin

@NicholasLYang, I also want this PR to be merged and a new version to be published to crates.io, but I don't have permission of this repo.

@binarybana @YuchenJin, is this PR ready to merge? I have a fix on top of it for building on aarch64 Darwin. Seems like the target is hardcoded to arm64-apple-darwin

Gotcha. Do we know who does? Or is it possible to fork the repository?

Gotcha. Do we know who does? Or is it possible to fork the repository?

I think @jroesch has the permission. Since Apache TVM rust crate has this crate as a dependency (https://github.com/apache/tvm/blob/main/rust/tvm-sys/Cargo.toml#L88), it would be good to move this repo to Apache imo.

Agreed. To be frank I was a little surprised to find this outside of the main tvm repository

@jroesch @tkonolige any chance to get this merged?


how do I override the .dev

Sorry if this is the wrong place to ask, but I'm using landrush succesfully for my local environment. I currently want to move into production, using a different provider.
As I am new to salt and provisioning (and landrush) I am trying to understand how to override hostnames properly.. consider my setup:
Vagrant.configure("2") do |config|
  config.vm.define :salt do |node|
    node.vm.hostname = "salt.vagrant.dev"
  end
  config.vm.define :webserver01 do |node|
    node.vm.hostname = "webserver01.vagrant.dev"
  end
end

Should I create a different Vagrant file for production? There cant be two Vagrantfiles in one directory right.. Should I use some sort of overriding technique? I have tried w/o success..

Closing this for now, TLD can be set with config.landrush.tld.
@perthvader please reopen if you're still experiencing problems with changing the TLD.


getToolTip throwing an error (e.w.globals.dom.baseEl is null)

This is not quite a bug report, because it's apparently already been fixed:
https://github.com/apexcharts/apexcharts.js/blob/21650391887f8e3da037b7c9d5c258b7730846c5/src/modules/tooltip/Tooltip.js#L42
But when I create a folder, go into it and type yarn add apexcharts, I see this code in node_modules/apexcharts/src/modules/tooltip/Tooltip.js:
  getElTooltip(ctx) {
    if (!ctx) ctx = this
    return ctx.w.globals.dom.baseEl.querySelector('.apexcharts-tooltip')
  }

And just to be sure, I checked the dist/apexcharts.common.js file, and sure enough, it's the same:
{key:"getElTooltip",value:function(t){return t||(t=this),t.w.globals.dom.baseEl.querySelector(".apexcharts-tooltip")}}

And the version is 3.32.1, which appears to be the latest. What's going on?

The fix is not released yet, so please wait for the next patch release.


Missing inner instructions

Hey Guys,
It appears there is an issue, and we are missing inner instructions within the transaction topic. Would you please check it out.
Sample signature : iS5igBEcPhspmMjkGcW3y8dGLkAMapFDqCA7JroKP5Cw6d8ctRvLAoQ3GVukLsPozFg8LxgepzhVhQgZhU3XQ1N
    "inner_instructions": [
        {
            "index": 2,
            "instructions": [
                {
                    "accounts": [
                        2
                    ],
                    "program_id_index": 0,
                    "data": ""
                }
            ]
        },

Hey @fanatid
For all messages we are receiving in transaction topic inner instruction is missing.
iS5igBEcPhspmMjkGcW3y8dGLkAMapFDqCA7JroKP5Cw6d8ctRvLAoQ3GVukLsPozFg8LxgepzhVhQgZhU3XQ1N was an example.

@mohsen-vybenetwork I checked the code again and did not find any problems, do you want to try geyser gRPC + gRPC -> kafka tool? https://github.com/rpcpool/yellowstone-grpc#kafka


The master and detail don't swap in UWP, as described by this document

This says that on UWP the master and detail are swapped. However, that doesn't appear to be the case anymore. Instead on UWP, when the MasterBehavior is Popover, the master slides over to the right on top of the detail content similar to Android, or uses a static split layout with Split settings.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ec31ee56-e3b9-a70a-a4ef-80fdf58e7249
Version Independent ID: 766b5774-50bf-f43f-800d-48b5c6c66509
Content: Xamarin.Forms Master-Detail Page - Xamarin
Content Source: docs/xamarin-forms/app-fundamentals/navigation/master-detail-page.md
Product: xamarin
GitHub Login: @davidbritch
Microsoft Alias: dabritch

Hi @JeroMiya
Thanks for pointing this out. The doc was originally written to describe the behavior on UWP phones. I've updated it in a PR that will go out later.


Removed Gradient Blocks

Fixes #19
Removed the gradients entirely. Please refer to the screenshot below for more context:

@ashryanbeats I made the changes that you asked for, please look at the video below for more context:

https://user-images.githubusercontent.com/42115530/111731450-82c11d80-8899-11eb-86fd-fc73f001b5f4.mov

Let's update this to reflect the latest changes made to the starter (mainly functional React & not using # for private fields): https://github.com/AdobeDocs/uxp-photoshop-plugin-samples/tree/main/ui-react-starter
Otherwise, this looks great.

Hey @kerrishotts, thanks for the review. I have updated the components as per your comment, please have a look and let me know if any other changes are needed.


[Discussion] Packaging ZPUI for Debian (Raspbian)

Another method to easily deploy ZPUI would be packaging it for Debian. It'd also allow easily distributing stable versions of ZPUI, as well as upgrades with proper dependency management process. However, it's nto as straightforward - current ZPUI install process involves installing packages both from Raspbian repositories and from PyPi. There's a StackOverflow question about this, with answers that explain the problems and possible solutions very well.

May not be related, but regarding the process to make Raspbian Custom images, NoobsConfig seem appropriate to help building images.

Thank you, will open an issue at https://github.com/ZeroPhone/Discussion-and-Research and link this there!

Issue opened


Index Manager Update API

Hi,
Really loving the new features and up-to date dependencies over FOSElastica.
I'm wondering if there is or could be an easy way to insert, update and delete documents. For example, if we were to borrow from the easy API used in FOSHttpCacheBundle for cache invalidates and refresh
http://foshttpcachebundle.readthedocs.io/en/latest/features/invalidation.html#cache-manager
Ours could be for example
$indexManager = $container->get('fazlandelastica.index_manager');
$index = $indexManager->getIndex('app');
$type = $index->getType('users');
// Update a user id
$type->updateId('1');
// Bulk Update user ids
$type->bulkUpdateIds('1,2,3,4,5');
// Or if we already have the objects to avoid re-querying
// Update a user object
$type->updateObject($user);
// Bulk Update user objects
$type->bulkUpdateObjects($users);
Or does this functionality already exist? I went through the docs and code but couldn't find such a method.

You can use the object persister services (ex $container->get('fazland_elastica.object_persister.type.name')) calling replaceOne or replaceMany methods passing an object or an array of objects.
Probably we should document this better

Thanks @alekitto
Will look into this as soon as I'm back to my dev machine
Quick question though, will this service pass objects directly to Elastica or will it inherit the model_to_elastica transformers?

It uses the object transformer


P256 implementation

I'm not a cryptographer, so I will need some guidance here on what to do, but it works as far as I've tested.
Any suggestions how or where I should put tests and further documentation?

MSRV is going to be an issue here, the last version of p256 to support 1.41 is 0.4.1. We can make the p256 crate feature have a different MSRV or increase the MSRV for the new version?

MSRV is going to be an issue here, the last version of p256 to support 1.41 is 0.4.1. We can make the p256 crate feature have a different MSRV or increase the MSRV for the new version?

Let's increase the MSRV for the new version.

Except getting it to actually work and moving some things into sub-modules, I will do a couple of things in follow up PRs:

increase MSRV
merge GroupWithMapToCurve and Group
potentially separate AKE and OPRF, which will need a separate discussion too

This is ready to be merged, follow-up PRs are in the works.


Export-PSgraph is throwing errors when there is no source

This simple example is throwing errors on a resolve-path
graph g {
    edge -From Dad -to Alex,Charis
} | Export-PSGraph -ShowGraph

Resolve-Path : Cannot bind argument to parameter 'Path' because it is an empty string.
At C:\Users\kevma\Documents\WindowsPowerShell\Modules\psgraph\<IP_ADDRESS>\public\Export-PSGraph.ps1:102 char:44

        $fileList = Resolve-Path -Path $Source -ea 0

This was a side effect of refactoring code for the PSScriptAnalyzer.


'dnx web' doesn't execute in VSCode 1.0.0 on OpenSuSe Leap 42.1

VSCode Version: 1.0.0
OS Version: OpenSuSe Leap 42.1

Problem: dnx web command doesn't execute, so I need to execute it manually via bash
Steps to Reproduce:

Install ASP.Net 5 as described here - http://docs.asp.net/en/latest/getting-started/installing-on-linux.html
Create project as described here - https://azure.microsoft.com/en-us/documentation/articles/web-sites-create-web-app-using-vscode/
Open it in VSCode
View->Command Palette->dnx Run Command->dnx web

This issue was moved to OmniSharp/omnisharp-server#215


Want to add tree content

Select the Day of Content
Day 24
What information is missing?
Tree content is missing.

@subhadipbhowmik please assign me this issue .

@subhadipbhowmik  please assign me this issue .


Bug: Endpoint /episodes doesn't return total for page 1

I am having some strange behavior from the API. When I pass the page=1 it doesn't return the total.
Request URL:https://api.feedcast.io/episodes?page=1&per_page=30
Request Method:GET
Status Code:200  (from disk cache)
Remote Address:<IP_ADDRESS>:443
Referrer Policy:no-referrer-when-downgrade
Response Headers
access-control-allow-origin:*
access-control-expose-headers:total
cache-control:max-age=300, public
cf-ray:38c64c73e9f226b4-FRA
content-encoding:gzip
content-type:application/json
date:Thu, 10 Aug 2017 22:12:47 GMT
etag:W/"2b8bed4dd8afddd7ccb69ec17656afd3"
server:cloudflare-nginx
status:200
via:1.1 vegur
x-request-id:b8e255ff-28ca-40da-8a71-0869ba311937
x-runtime:0.022315

And passing a page to it:
Request URL:https://api.feedcast.io/episodes?page=2&per_page=30
Request Method:GET
Status Code:200  (from disk cache)
Remote Address:<IP_ADDRESS>:443
Referrer Policy:no-referrer-when-downgrade
Response Headers
access-control-allow-origin:*
access-control-expose-headers:total
cache-control:max-age=300, public
cf-ray:38c64ea5886026b4-FRA
content-encoding:gzip
content-type:application/json
date:Thu, 10 Aug 2017 22:14:17 GMT
etag:W/"55a845059d5108911ccb744467511178"
link:<http://api.feedcast.io/episodes?page=1&per_page=30>; rel="first", <http://api.feedcast.io/episodes?page=1&per_page=30>; rel="prev", <http://api.feedcast.io/episodes?page=519&per_page=30>; rel="last", <http://api.feedcast.io/episodes?page=3&per_page=30>; rel="next"
per-page:30
server:cloudflare-nginx
status:304
total:15557
via:1.1 vegur
x-request-id:f8b7e227-9e17-4053-938f-4426a4e393f9
x-runtime:0.256476

@cristianoliveira is that only for this endpoint or for all the endpoints with pagination?

Apparently is just this endpoint the channels/ is working properly

that's crazy, I will check tomorrow.

My guess would be something related to cache, cause it happens intermittently. I can show you tomorrow what is the bug.

i'm having the same problem :/


Improve use of correlation ID

Context
The correlation ID is used to allow a dApp to send several operations when use is signing only one request.
Today, this behaviour is hidden from the user point of view, and it is also quite risky in term of security because the dApp can send any operations without the explicit user approval.
There is to aspect to focus on:

transparency regarding what the user accept when signing
security: implement restrictive rules that defines what the  dApp is allowed to do with the correlation ID

Tasks

Inform the user that he is accepting a batch of operations
implement different rules to restrict the allowance scope
When new rules are implemented in backend, make the according evolution in frontend

Idea of rules

restrict the total number of operation allowed
restrict the type of operation allowed
for callSC, restrict the SC(s) that can be called
identify the dApp and check that batched operations are sent from the same origin

@gregLibert @peterjah @Thykof
With Pierre we propose the following way for 'upload website' feature:

User can't sign multiple operations at once. He must sign the following by himself each time:

Deploy website storer SC (Execute SC?)
Call DNS contract to register domain name (Call SC)
(on this step we verify if the domain name is taken. coins are taken from the user on step 2 even if we get an error.)
Upload chunks (Call SC?). In case of multiple chunks, at this step we can batch operations, as it makes sense to as user to sign all chunks at once. But user must be aware of it.

Follow up tasks would include:

[ ] Allow user to enable signing operations without password in Settings. This way we improve the UX for quite some.
[ ] Allow user to enable signing without password, when a dApp first calls the Wallet for signature.

We need to decide on the approach so share thoughs :)

What do you mean by sign ? Does this means that the user need to type in his password 3 times to deploy a website ?

If we stay like this yes. If we add the ability for user to choose to sign without providing a password (for specific or all dApps) we remove the need to type passwords.
That'd be the 1st follow-up task.

This is an industry standard. Users are given possibility to choose whether to enter passwords each time or not.

I think that the 1st task on this subject is more about informing the user that a batch of transactions is being signed.
Then we could go two directions:

avoid having to type again the password for a given duration, but the opeartion still need to be validated
frame the eligible transactions to be part of the batch by limiting them (for instance, for a specific smart contract...)

Wdyt @peterjah and @longgamma-massa

From the UX point of you it means things don't change for users functionally, but he must see more information.
@LucasF243 here we need that Scenario 1 described in Figma

We designed 3 flows.
This is the flow to implement for "Keeping batch operations (user signs once), showing info about operations and fees to user.
Designs: https://www.figma.com/file/LSaOibVDFb1reF6FePVn5l/Massastation?type=design&node-id=6218-7432&mode=design&t=gqcVBZAT1OyIwo0u-0
Error implemented for showing 'domain name taken' error before signing: https://www.figma.com/file/LSaOibVDFb1reF6FePVn5l/Massastation?type=design&node-id=6208-39156&mode=design&t=gqcVBZAT1OyIwo0u-0


can you publish a Releases version here?

Goole Play is not available in our country, can you publish a Releases version here?
I want to download from here

Hi @mygoodhelium 👋🏼 I think we should be able to make that happen. @ChewingGlass Thoughts?

@abhay Thoughts?

I'm migrating to GrapheneOS because I don't want to use google play anymore. Can you please release the helium-wallet to https://f-droid.org as well. I  know this will break notifications due to missing google services but that's an acceptable tradeoff for me. Thanks in advance.


End of string anchor

Introduction
This PR implements the first pass of an End of String anchor.

(aa)$

Linked Issues
#3
Dependencies
Test

[x] Tested Locally
[x] Documented

Review

[x] Ready for review
[x] Ready to merge

Deployment

Be Advised no Admin or team will ever DM you or share you any link so you can only chat Here on Live Chat with Anchor Agent  On LIVE SUPPORT LIVE CHAT


fix: width of screens

:tada: This PR is included in version 3.4.9 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Pick and Omit

This could be a nice addition to objects. There are cases when we need to take only a part of the object.
cosnt TestObject = v.object({
    id: v.string(),
    someValue: v.string().asserts(...)
});

const input = TestObject.pick(['someValue']);

What are your thoughts on this?

I've been thinking about this. One caveat that comes to mind that .pick and .omit should not probably keep the .check checks, as e.g. omitting a key could break .checks that assume that the key exist in the type. What do you think?

Yup after pick/omit check should be removed

Published v0.0.17 that contains v.object(...).pick("a", "b") and v.object(...).omit("a", "b") 🙂 Thanks for the suggestion!


Add write_slice_size() and resize_out_vec() to the AIDL generator to improve compatibility.

Implemented and it will apply to the next release.


[Bug Report]: Networking API growing old

Describe the bug
Have some pipelines brezking due to old API versions.

To reproduce
Rerun any networking pipeline or any of the ones that use networking.
Code snippet
N/A

Relevant log output

Closing as its duplicate of other issues


more docs on how to mock test for a page

Right now the docs has a quite limitation and there is no guidance on integrating with a full Nuxt app which contains pages with may api calls, not just plugin or components let alone ts module import.
It would be much appreciated if you can expand the docs on for a more specific cases or may be some examples on this repo or say a fiddle, codepen, codesandbox ?

Related #95


404s still evaluate Layout

The current homepage has links to unexisting script files, all these 404s are currently converted by the Diagnostics module into custom views with a 404 status.
Maybe that's the correct thing to do, and maybe there should be a custom Layout that would not render any content like the menus, or maybe it should be cache aggressively.

Yes, when a script file exists it is served as a static file and orchard doesn't see the request. If it doesn't exist orchard computes it as a normal request and finally serves the NotFound view.
Note: I can see in the debugger that ExpandViewLocations() is called for each of them.
I first thought that somewhere we have to filter these requests (just return a 404), but we can have some controllers specifically used to implement some static files requests.
Because it's related somewhere to view rendering, i'll search on this.

FYI, the fact that a custom NotFound file is done is on purpose, I made a module for that, we just need to optimize it by serving the custom page only if it was handled by the MVC handler.

Just for infos because i began to get something working with the following. I didn't find a way by checking if it has been handled or not by the MVC handler. When a static file doesn't exists, it seems that it is just not served by the StaticFiles midleware, then orchard middlewares execute ...
...
using Microsoft.AspNetCore.Diagnostics;
using Microsoft.AspNetCore.StaticFiles;
...

        // c.f. https://docs.asp.net/en/latest/fundamentals/error-handling.html#id3
        app.UseStatusCodePagesWithReExecute("/Error", "?status={0}");

        app.Use((context, next) =>
        {
            // this can be declared as a private variable at the class level
            var contentTypeProvider = new FileExtensionContentTypeProvider();

            string contentType;
            if (contentTypeProvider.TryGetContentType(context.Request.Path, out contentType))
            {
                var statusCodePagesFeature = context.Features.Get<IStatusCodePagesFeature>();
                if (statusCodePagesFeature != null)
                {
                    statusCodePagesFeature.Enabled = false;
                }
            }

            return next();
        });

We might also need to change the AdminMenuFilter not to render anything when the status code is not 2xx. Not sure we should care for now, but keep track of it.


[BUG] cargo make test fails out of the box

Signed-off-by: Andriy Redko<EMAIL_ADDRESS>Description

there cert tests were failing because client and server used different CA (fixed)running 8 tests
test full_certificate_ca_chain_validation ... ok
test full_certificate_ca_validation ... ok
test certificate_certificate_ca_validation ... ok
test none_certificate_validation ... ok
test default_certificate_validation ... ok
test fail_certificate_certificate_validation ... ok
test full_certificate_validation ... ok
test certificate_certificate_validation ... ok

test result: ok. 8 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 1.09s

the Dockerfile is not necessary because the security plugin could be disabled using DISABLE_SECURITY_PLUGIN (fixed)

Issues Resolved
Closes https://github.com/opensearch-project/opensearch-rs/issues/45
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Awesome! Let's run this as part of CI? #112

Codecov Report

Merging #117 (b614808) into main (215aa45) will increase coverage by 39.60%.
The diff coverage is n/a.

:exclamation: Current head b614808 differs from pull request most recent head 93a8d57. Consider uploading reports for the commit 93a8d57 to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##            main     #117       +/-   ##
==========================================
+ Coverage   7.17%   46.77%   +39.60%
==========================================
  Files         59       60        +1
  Lines      28967    29066       +99
==========================================
+ Hits        2077    13595    +11518
+ Misses     26890    15471    -11419

Flag
Coverage Δ

integration
42.12% <ø> (?)

unit
7.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

yaml_test_runner/tests/common/client.rs
87.87% <0.00%> (ø)

opensearch/src/http/request.rs
85.71% <0.00%> (+2.25%)
:arrow_up:

...enerator/src/generator/code_gen/url/url_builder.rs
88.93% <0.00%> (+3.98%)
:arrow_up:

opensearch/src/http/transport.rs
60.54% <0.00%> (+5.44%)
:arrow_up:

opensearch/src/client.rs
14.91% <0.00%> (+6.29%)
:arrow_up:

opensearch/src/params.rs
76.15% <0.00%> (+8.60%)
:arrow_up:

opensearch/src/http/response.rs
80.32% <0.00%> (+9.50%)
:arrow_up:

opensearch/src/root/mod.rs
36.66% <0.00%> (+35.68%)
:arrow_up:

opensearch/src/nodes.rs
36.41% <0.00%> (+36.41%)
:arrow_up:

opensearch/src/cluster.rs
42.50% <0.00%> (+42.50%)
:arrow_up:

... and 21 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Minor semantic mismatch: the test use SECURE_INTEGRATION=true|false but plugin setting is reversed DISABLE_SECURITY_PLUGIN = not SECURE_INTEGRATION :D

Minor semantic mismatch: the test use SECURE_INTEGRATION=true|false but plugin setting is reversed DISABLE_SECURITY_PLUGIN = not SECURE_INTEGRATION :D

Things like DISABLE_SECURITY_PLUGIN are called negative-booleans ;)

Minor semantic mismatch: the test use SECURE_INTEGRATION=true|false but plugin setting is reversed DISABLE_SECURITY_PLUGIN = not SECURE_INTEGRATION :D

Things like DISABLE_SECURITY_PLUGIN are called negative-booleans ;)

Haha yeah 👍

The issue in #45 was somewhat different and was fixed by excluding tests that required a host. We also have #35 and some other similar/related issues - let's see which ones this fixes.

Apologies @dblock , the GA/CI seems to be not liking the certs as volumes, reverting this part to reusing the custom docker file :(

So without this change I can run cargo make test without problems because we added the _integration feature and that's not on by default.
I believe this will fix cargo test --features _integration. We should also then re-add it to cargo make test as part of this PR.

cargo test --features _integration

Correct, we should not need --features _integration after that

cargo test --features _integration

Correct, we should not need --features _integration after that

We may still need it if we want cargo test without arguments to still work (default to unit tests, no docker).

Thanks for fixing these. I merged, but maybe we/you want to add a CI that runs this?

We may still need it if we want cargo test without arguments to still work (default to unit tests, no docker).

Picking this one up right away, I know how to make it work

Thanks for fixing these. I merged, but maybe we/you want to add a CI that runs this?

Thanks @dblock , yes, on it :)


Cannot read property 'port' of null

This happens sometimes when running proxy.close():
/Users/joaomilho/p/klarna-app/services/shopping/node_modules/hoxy/lib/proxy.js:396
            port: addr.port,
                      ^

TypeError: Cannot read property 'port' of null
    at Server.<anonymous> (/Users/joaomilho/p/klarna-app/services/shopping/node_modules/hoxy/lib/proxy.js:396:23)
    at emitTwo (events.js:106:13)
    at Server.emit (events.js:194:7)
    at parserOnIncoming (_http_server.js:563:12)
    at HTTPParser.parserOnHeadersComplete (_http_common.js:99:23)

On mac, node v 7.10.1.

Hi,
I'm also having the same problem. This problem happens for me when Hoxy is receiving requests and tries to shut down at the same time. Unfortunately I can't find a way to tell Hoxy, to stop listening on incoming network calls.
Any help would be much appreciated, thanks!


[Documentation] API Section

Add the following APIs:

https://github.com/SAP/xsk/issues/397
https://github.com/SAP/xsk/issues/398
https://github.com/SAP/xsk/issues/396
https://github.com/SAP/xsk/issues/399
https://github.com/SAP/xsk/issues/400
https://github.com/SAP/xsk/issues/401
https://github.com/SAP/xsk/issues/402
https://github.com/SAP/xsk/issues/403
https://github.com/SAP/xsk/issues/404
https://github.com/SAP/xsk/issues/405
https://github.com/SAP/xsk/issues/406
https://github.com/SAP/xsk/issues/407

Related to: https://github.com/SAP/xsk/issues/375


Add sentry on errors.

Fixes #7
After this lands, we have a bit of paperwork to do. We need to create 2 Sentry projects. (We already have https://sentry.prod.mozaws.net/operations/rs-uptake-health-dev/ but I don't like that name any more) and we need to ask Ops to set SENTRY_DSN on ALL Lambda configs.

IF and WHEN we move to something other than AWS Lambda we might want to look at https://docs.sentry.io/platforms/python/serverless/ or just removing any integrations and leaving it as default as possible if it's just going to run, as a cron job, in a simple Docker container.

See https://github.com/mozilla-services/remote-settings-lambdas/issues/265


aggregate_temporal - Add time-series aggregates, e.g. seasonal

In climatology, time-series aggregates in multiple ways are of high interest.

Example: create climatology from a time-series: let’s say we have time-series data of 10 years (2000-2010). We would like to retrieve the mean of each month of this time series → resulting into a data set of 12 months

Example: Seasonal aggregates: common seasons are “DJF”, “MAM”, “JJA”, “SON”. For tropical countries, wet and dry season is often differentiated.  A user might be interested in the mean of the specific season, for one year or even in the general mean of a longer time series.

Thanks for porting this over from our discussion. Here's also my ported response:
We need to check whether the filters allow to achieve the examples. For examples, we don't have date/time operations on the back-end yet and expect that the clients generate intervals for aggregate_temporal (or use multiple filter_temporal). If aggregate_temporal works well with client libraries, we may just extend filter_temporal to also passing more then one interval. That's probably a way that would work to solve (1).
For (2) we nay need specific processes depending on how these seasons are defined. I assume the normal date/time libraries are not covering this. Once we have the ERA5 data for GEE we could probably just sit together and define these processes.

Yes, these rolling aggregations are common in quite a few domains including oceanography.
However, I was wondering if it is a good idea to define all sorts of possible processes in the backend since it would be a never-ending list. Anyway, isn't the UDF service a better option since it is specifically designed for custom requirements of the user such as the operations @jwagemann mentioned? For example, both these operations could be done using the UDF service (definitely in my R UDFs) in its current state (leaving aside the scalability bit).

However, I was wondering if it is a good idea to define all sorts of possible processes in the backend

Of course not and the back-ends can still choose which they'd like to add. But if a process is "common in quite a few domains" it feels reasonable if it can't be achieved easily with other processes. As I don't know the meaning behind “DJF”, “MAM”, “JJA”, “SON” yet, I can't really judge what's the best way to go, but I already wrote in my first comment that it may also be possible with aggregate_temporal and we need to check what's the best way out.
I personally don't see the UDF service as a better option here as it's quite a common task and shouldn't require UDFs. UDFs for me are more a tool to process highly specialized things, e.g. using bfast or so.

A colleague of mine just requested support for this specific use case. I believe allowing multiple time intervals as temporal extent would already get us a long way.
Translations from domain specific indicators to the actual intervals is something that can be done on the client side in a lot of cases.

I believe allowing multiple time intervals as temporal extent would already get us a long way.

@jdries  aggregate_temporal already supports multiple time intervals. What is missing?

Translations from domain specific indicators to the actual intervals is something that can be done on the client side in a lot of cases.

Yes, but would that be something that (1) needs to be implemented in our client libraries or (2) is already available as external library? How do we ensure that you can do things in all clients? It should never happen that you can run something on R but not on Python and vice-versa.

I also thought of using aggregate_temporal, but it would mean that we would still load too much data first, only to discard part of it in aggregate_temporal. So having the exact intervals available in filter_temporal would be an optimization.
The conversion of the domain specific intervals is something that would not be part of the core client libraries. In most cases people just write the translation logic themselves.

Oh, you are speaking about filter_temporal. That wasn't clear and would probably need its own issue. Anyway, load time optimization based on filter_temporal is back-end specific for VITO, I think. If you want to have multiple temporal intervals in filter_temporal, we'd also have it in load_collection. But then: Why not also allow multiple spatial extents? And would that make load_collection too complicated?

See #145 for a related PR.

I think this is solved with aggregate_temporal_period.


Plotting residuals (seemingly) incompatible with non-int bins

Describe the bug
When using hawc_hal with the 2D bins, if one wants to plot the binned count residuals one get an error
  File "minimal_crab.py", line 71, in <module>
    fig = hawc.display_spectrum()
  File "/data/disk01/home/cbrisboi/hawc_software/miniconda3/envs/hal_prod/lib/python3.7/site-packages/hawc_hal/HAL.py", line 410, in display_spectrum
    return self._plot_spectrum(net_counts, yerr, model_only, residuals, residuals_err)
  File "/data/disk01/home/cbrisboi/hawc_software/miniconda3/envs/hal_prod/lib/python3.7/site-packages/hawc_hal/HAL.py", line 415, in _plot_spectrum
    planes = np.array(self._active_planes, dtype=int)
ValueError: invalid literal for int() with base 10: '1c'

To Reproduce
Here is a minimal example produced from the Markarian example in the README.
from hawc_hal import HAL, HealpixConeROI
import matplotlib.pyplot as plt
from threeML import *

# Define the ROI
ra_crab, dec_crab = 83.63, 22.01
data_radius = 3.0
model_radius = 8.0

roi = HealpixConeROI(data_radius=data_radius,
                     model_radius=model_radius,
                     ra=ra_crab,
                     dec=dec_crab)

# Instance the plugin

response ="/data/scratch/userspace/kmalone/sweets-for-systematics/stages/bobs-ednas-thresh0p2/detRes-GP-allDecs.root"
maptree ="/data/scratch/userspace/kmalone/datasets/energy/maps/combined/dataset-ch103-ch603/rejiggered-files/maptree-ch103-ch603.root"

hawc = HAL("HAWC",
           maptree,
           response,
           roi)

# Use from bin 1 to bin 9
hawc.set_active_measurements(bin_list=['1c', '1d', '1e', '2c', '2d', '2e', '3c', '3d', '3e', '3f', \
                                      '4c', '4d', '4e', '4f', '4g', '5d', '5e', '5f', '5g', '5h', \
                                      '6d', '6e', '6f', '6g', '6h', '7f', '7g', '7h', '7i', '8f', \
                                      '8g', '8h', '8i', '8j', '9g', '9h', '9i', '9j', '9k', '9l'])

# Define model as usual
spectrum = Log_parabola()
source = PointSource("crab", ra=ra_crab, dec=dec_crab, spectral_shape=spectrum)

spectrum.piv = 1 * u.TeV
spectrum.piv.fix = True

spectrum.K = 1e-14 / (u.TeV * u.cm ** 2 * u.s)  # norm (in 1/(keV cm2 s))
spectrum.K.bounds = (1e-25, 1e-19)  # without units energies are in keV

spectrum.beta = 0  # log parabolic beta
spectrum.beta.bounds = (-4., 2.)

spectrum.alpha = -2.5  # log parabolic alpha (index)
spectrum.alpha.bounds = (-4., 2.)

model = Model(source)

data = DataList(hawc)

jl = JointLikelihood(model, data, verbose=False)
jl.set_minimizer("minuit")
param_df, like_df = jl.fit()

# See the model in counts space and the residuals
fig = hawc.display_spectrum()
# Save it to file
fig.savefig("hal_crab_residuals.png")

Expected behavior
I expect a plot to be output, and saved.
A clear and concise description of what you expected to happen.
Log files
[WARNING ] The GSL library or the pygsl wrapper cannot be loaded. Models that depend on it will not be available.
[WARNING ] The ebltable package is not available. Models that depend on it will not be available
[INFO    ] Starting 3ML!

WARNING RuntimeWarning: numpy.ndarray size changed, may indicate binary incompatibility. Expected 16 from C header, got 88 from PyObject

[WARNING ] The cthreeML package is not installed. You will not be able to use plugins which require the C/C++ interface (currently HAWC)
[WARNING ] Could not import plugin HAWCLike.py. Do you have the relative instrument software installed and configured?
[WARNING ] Could not import plugin FermiLATLike.py. Do you have the relative instrument software installed and configured?

WARNING DeprecationWarning: `np.object` is a deprecated alias for the builtin `object`. To silence this warning, use `object` by itself. Doing this will not modify any behavior and is safe.
Deprecated in NumPy 1.20; for more details and guidance: https://numpy.org/devdocs/release/1.20.0-notes.html#deprecations

[INFO    ] Creating singleton for /data/scratch/userspace/kmalone/sweets-for-systematics/stages/bobs-ednas-thresh0p2/detRes-GP-allDecs.root

WARNING DeprecationWarning: `np.object` is a deprecated alias for the builtin `object`. To silence this warning, use `object` by itself. Doing this will not modify any behavior and is safe.
Deprecated in NumPy 1.20; for more details and guidance: https://numpy.org/devdocs/release/1.20.0-notes.html#deprecations

[WARNING ] We have set the min_value of crab.spectrum.main.Log_parabola.K to 1e-99 because there was a postive transform
[INFO    ] set the minimizer to minuit
[INFO    ] set the minimizer to MINUIT
[WARNING ] The current value of the parameter K (1.0) was above the new maximum 1e-19.
Best fit values:

                                                         result  \
parameter
crab.spectrum.main.Log_parabola.K      (3.76 +/- 0.07) x 10^-20
crab.spectrum.main.Log_parabola.alpha          -2.363 +/- 0.028
crab.spectrum.main.Log_parabola.beta    (1.08 +/- 0.09) x 10^-1

                                                  unit
parameter
crab.spectrum.main.Log_parabola.K      1 / (cm2 keV s)
crab.spectrum.main.Log_parabola.alpha
crab.spectrum.main.Log_parabola.beta

Correlation matrix:

 col0  col1  col2
----- ----- -----
 1.00 -0.72 -0.48
-0.72  1.00  0.92
-0.48  0.92  1.00

Values of -log(likelihood) at the minimum:

       -log(likelihood)
HAWC       66270.311832
total      66270.311832

Values of statistical measures:

     statistical measures
AIC<PHONE_NUMBER>14
BIC<PHONE_NUMBER>09
Traceback (most recent call last):
  File "minimal_crab.py", line 67, in <module>
    fig = hawc.display_spectrum()
  File "/data/disk01/home/cbrisboi/hawc_software/miniconda3/envs/hal_prod/lib/python3.7/site-packages/hawc_hal/HAL.py", line 410, in display_spectrum
    return self._plot_spectrum(net_counts, yerr, model_only, residuals, residuals_err)
  File "/data/disk01/home/cbrisboi/hawc_software/miniconda3/envs/hal_prod/lib/python3.7/site-packages/hawc_hal/HAL.py", line 415, in _plot_spectrum
    planes = np.array(self._active_planes, dtype=int)
ValueError: invalid literal for int() with base 10: '1c'

Desktop (please complete the following information):
(not a desktop, but its the machine I'm running on)

OS: CentOS 7
Version  7.6.1810

Additional context
I should have some time to investigate this next week.

Hm, I see. The tests only run on fHit maps. Do we have any maps/IRFs with 2D binning that are publicly available? Then we could add this to the unit tests.
In any case, try just removing the dtype=int. I think that current versions of matplotlib should be able to handle alphanumeric data points.

Fixed in #64


Experiment 6

[ ] Remove the builded file from Git.
[ ] Add a script to automate all the process.
[ ] Investigate if it works well on the following platforms:

[ ] Windows
[ ] Linux
[ ] macOS

I don't need of this experiment anymore, so I'm closing the issue.


Improve devcon.md formatting

According to style guide1, this is the right thing to do. Although, not sure about those span-id — they seem to be pretty much unused is these repositories. And the "Related topics" at the end probably needs to be reformatted as a list too.

Thanks @ratijas, appreciate the PR.