Make the code SQL Server CLR "SAFE" compatible

Currently, version 1.1 of LINQBridge is rejected as not being SAFE when
attempting to deploy LinqBridge.dll or any assembly containing the
compiled code. This is due to two lambda expressions at lines 87 and 111
of OrderedEnumerable.cs.

Convert these lambda expressions to regular methods to enable deploying
LINQBridge-enabled assemblies to SQL Server 2005/2008.

Original issue reported on code.google.com by allon.guralnek on 29 Jan 2010 at 7:28

Blocking: #12

Fixed in r235.

Original comment by allon.guralnek on 31 Jan 2010 at 11:19

Changed state: Fixed

Original comment by azizatif on 16 Nov 2010 at 10:11

Added labels: Milestone-Release1.2


disable/enable checkbox in the Tasks list

I want to enable/disable tasks when testing effects of each task.
Currently, I need to remove a task when I don't want it run in the simulation.
I just want to disable some of the tasks instead of removing them.

The enable/disable does not need to be stored in the model files, but the model files in the run must contain only enabled tasks.


bug(picker) - overriding $picker-ios-button-text-color no longer works

Ionic version:
[ ] 1.x
[x] 2.x
I'm submitting a ...
[x] bug report
[ ] feature request
[ ] support request
Current behavior:
Currently, when I attempt to override $picker-ios-button-text-color it has no effect.
Expected behavior:
The text color would successfully change
Other information:
Here is a link to the line causing the issue.
https://github.com/driftyco/ionic/blob/master/src/components/picker/picker.scss#L126
Ionic info:
Ionic Framework Version: 2.0.0-rc.3
Ionic CLI Version: 2.1.4
Ionic App Lib Version: 2.1.2
Ionic App Scripts Version: 0.0.46
ios-deploy version: 1.9.0
ios-sim version: 5.0.9
OS: Mac OS X El Capitan
Node Version: v6.9.1
Xcode version: Xcode 8.1 Build version 8B62

Thanks for the issue! This will be fixed in the rc.4 release and I released a nightly version if you'd like to try it out sooner:
npm install --save ionic-angular@nightly

let me know if you find any issues. :)


DROOLS-914 - introduce revapi maven plugin to check backward compatib…

…ility

+1

Merged into master and 6.3.x. Thanks @rsynek!


./src/index.js overrides entry points specified in config

Bug report

What is the current behavior?
If ./src/index.js is present, no other entry points are processed.
If the current behavior is a bug, please provide the steps to reproduce.
Use the following webpack.config.js:
module.exports = {
    mode: 'development',
    output: {
        filename: '[name].js'
    },
    entry: {
        asdf: './src/asdf.js'
    }
}

Make two (potentially empty) files, ./src/index.js, and ./src/asdf.js. Run npx webpack, and observe that only one entry point is processed, named main, and including only ./src/index.js.
Alternatively, run npm i and npx webpack after cloning this repo.

What is the expected behavior?
If entry is present in the config, only the entry points specified there are processed. In the case above, there should be one processed entry point, named asdf, and including only ./src/asdf.js

Other relevant information:
webpack version: 5.0.0-beta24
Node.js version: 14.2.0
Operating System: Ubuntu 20.04

This seems to be a bug in CLI, I've added a test for it here - https://github.com/webpack/webpack-cli/pull/1718
Should be fine in next release, /cc @evilebottnawi


Team 1 Reviews Team 4's HA

Hi Team4!
According to Dr. Smith's md file, it seems like we (team 1) will be reviewing your Hazard Analysis. Do you mind changing your label to reflect our team# please?
Thank you.

@JonHaiMcMaster

Thanks for letting us know about that!


Ruff removes required imports when saving

Hey there,
I've noticed some strange behavior when saving code, as some of the import statements get removed even though they are referenced in the actual code.
I am using Sublime Text 4180 + LSP-ruff v2.03, and this is my ruff.toml:
unfixable = ["F401"]

[lint.isort]
split-on-trailing-comma = false

[format]
skip-magic-trailing-comma = true

As a concrete example, if we take the code from here:
https://gist.githubusercontent.com/N8python/2431ab577d1de60e46180fa43a743c61/raw/453e677891eeb229ec4f05033ab6e0a4a8957aa3/MORE.py
and paste it into a new file and then save, everything above the "# Copyright © 2023-2024 Apple Inc." gets dropped after saving. Some of those imports are required.
I then press undo twice, and the imports get magically added back, but the code is still linted. This behavior of having to press undo to fix things is unexpected. Moreover, pressing undo does not take the code back to the original pasted code (which is counter-intuitive).
There is something funny going on here :) I hope this makes sense. Thanks!

Playground link for the same: https://play.ruff.rs/f6c9ed84-96a5-473b-94e6-10bc2b4e0b94
Can you specify the project structure? Like, where is the Python file and where's the Ruff config file (ruff.toml) ?


[Performance] Slow response and timeouts when published to Southeast Australia

Bot Info

Bot handle: livebot_dev
App ID: 331e99c1-42d3-49bc-ba05-316c38ca5332
SDK Platform: .NET
SDK Version: <IP_ADDRESS>
Active Channels: WebChat, Direct Line, Teams, Skype
Deployment Environment: Azure App Service

Issue Description
We have a bot environment with the messaging endpoint in Southeast Australia and LUIS in Southeast Asia, but are getting worse latency and a lot of timeouts from an Australian Web Chat than when everything was published in the West US. We where expecting an improvement in latency, but this is not the case.
The only explanation we can think of is that the Bot Framework is not available in Australia so all messages go to the US first, then the messaging endpoint in Aus and then LUIS in Asia.
Questions

In which regions is the bot framework currently available?
How can we improve the performance in Australia and other regions?

We deployed the same bot messaging endpoint and LUIS model to East US2 and the performance is great from a web chat in the east US, confirming that the Bot Framework is the bottleneck in Australia.

Not sure if the same with East AU data center.  This is the remote dependency tree for one Post activity.

In average response takes 8-9 secs which is a lot. Dapper + SQL takes less than 25ms to process and save logs and conversations.

Can you please let us know if the issue still persists?

please open a new issue if the issue persists


Can't establish dialer connection: can not build dialer to %s - ENHANCE_YOUR_CALM

Rancher versions:
rancher/server or rancher/rancher:  rancher/rancher:v2.0.8
rancher/agent or rancher/rancher-agent: rancher/rancher-agent:v2.0.8
Docker version: (docker version,docker info preferred)
Client:
Version:      17.03.1-ce
API version:  1.27
Go version:   go1.7.5
Git commit:   c6d412e
Built:        Mon Mar 27 17:05:44 2017
OS/Arch:      linux/amd64
Server:
Version:      17.03.1-ce
API version:  1.27 (minimum version 1.12)
Go version:   go1.7.5
Git commit:   c6d412e
Built:        Mon Mar 27 17:05:44 2017
OS/Arch:      linux/amd64
Experimental: false
Operating system and kernel: (cat /etc/os-release, uname -r preferred)
uname -r
3.10.0-862.el7.x86_64
Type/provider of hosts: (VirtualBox/Bare-metal/AWS/GCE/DO)
VSphere VMs
Setup details: (single node rancher vs. HA rancher, internal DB vs. external DB)
3 Node Cluster, 3 node HA Rancher Cluster, internal DB
Environment Template: (Cattle/Kubernetes/Swarm/Mesos)
Kubernetes
Steps to Reproduce:
Upgrade  2.0.7 to 2.0.8 with command
kubectl --kubeconfig=kube_config_rancher-cluster.yml set image deployment/cattle cattle-server=rancher/rancher:v2.0.8 -n cattle-system
Results:
One of 3 node cluster is unmanaged GUI say's

This cluster is currently Provisioning; areas that interact directly with it will not be available until the API is ready.
Cluster must have at least one etcd plane host; exit status 1, Error from server (ServiceUnavailable): the server is currently unable to handle the request

Logs on Rancher/Rancher
(kubectl --kubeconfig kube_config_rancher-cluster.yml logs -f cattle-6c5f6fb874-p7drn -n cattle-system)
2018/08/31 02:22:25 [INFO] Provisioning cluster [c-gk29g]
2018/08/31 02:22:25 [INFO] Updating cluster [c-gk29g]
2018/08/31 02:22:25 [INFO] cluster [c-gk29g] provisioning: Building Kubernetes cluster
2018/08/31 02:22:25 [INFO] cluster [c-gk29g] provisioning: [dialer] Setup tunnel for host [<IP_ADDRESS>]
2018/08/31 02:22:25 [ERROR] cluster [c-gk29g] provisioning: Failed to set up SSH tunneling for host [<IP_ADDRESS>]: Can't establish dialer connection: can not build dialer to c-gk29g:m-e2b6919d4bb2
2018/08/31 02:22:25 [INFO] cluster [c-gk29g] provisioning: [dialer] Setup tunnel for host [<IP_ADDRESS>]
2018/08/31 02:22:25 [ERROR] cluster [c-gk29g] provisioning: Failed to set up SSH tunneling for host [<IP_ADDRESS>]: Can't establish dialer connection: can not build dialer to c-gk29g:m-ffbf71b5866e
2018/08/31 02:22:25 [INFO] cluster [c-gk29g] provisioning: [dialer] Setup tunnel for host [<IP_ADDRESS>]
2018/08/31 02:22:25 [ERROR] cluster [c-gk29g] provisioning: Failed to set up SSH tunneling for host [<IP_ADDRESS>]: Can't establish dialer connection: can not build dialer to c-gk29g:m-d27e60d64993
2018/08/31 02:22:25 [ERROR] cluster [c-gk29g] provisioning: Removing host [<IP_ADDRESS>] from node lists
2018/08/31 02:22:25 [ERROR] cluster [c-gk29g] provisioning: Removing host [<IP_ADDRESS>] from node lists
2018/08/31 02:22:25 [ERROR] cluster [c-gk29g] provisioning: Removing host [<IP_ADDRESS>] from node lists

Logs on rancher/agent
(docker logs -f 2550d3ab3f2b)
INFO: Arguments: --server https://vlg-cicdt-rch.xxx.xxx --token REDACTED --ca-checksum 3fbeb223dc1a17a5a22d833be67c5d00e75c53a098acbb81e9f3c624f62ad571 --etcd --controlplane --worker
INFO: Environment: CATTLE_ADDRESS=<IP_ADDRESS> CATTLE_INTERNAL_ADDRESS= CATTLE_NODE_NAME=vlg-ranch-n1s CATTLE_ROLE=,etcd,worker,controlplane CATTLE_SERVER=https://vlg-cicdt-rch.xxx.xxx CATTLE_TOKEN=REDACTED
INFO: Using resolv.conf: search xxx.xxx options rotate timeout:1 attempts:1 nameserver <IP_ADDRESS> nameserver <IP_ADDRESS> nameserver <IP_ADDRESS>
INFO: https://vlg-cicdt-rch.xxx.xxx/ping is accessible
INFO: Value from https://vlg-cicdt-rch.xxx.xxx/v3/settings/cacerts is an x509 certificate
time="2018-08-31T02:09:24Z" level=info msg="Rancher agent version v2.0.8 is starting"
time="2018-08-31T02:09:24Z" level=info msg="Option etcd=true"
time="2018-08-31T02:09:24Z" level=info msg="Option controlPlane=true"
time="2018-08-31T02:09:24Z" level=info msg="Option worker=true"
time="2018-08-31T02:09:24Z" level=info msg="Option requestedHostname=vlg-ranch-n1s"
time="2018-08-31T02:09:24Z" level=info msg="Option customConfig=map[address:<IP_ADDRESS> internalAddress: roles:[etcd worker controlplane] label:map[]]"
time="2018-08-31T02:09:24Z" level=info msg="Listening on /tmp/log.sock"
time="2018-08-31T02:09:24Z" level=info msg="Connecting to wss://vlg-cicdt-rch.xxx.xxx/v3/connect/register with token hndzlhww58vhqlxzltgmskkdrc6mn4ddflwwpmftvr4v4qpbxvdg88"
time="2018-08-31T02:09:24Z" level=info msg="Connecting to proxy" url="wss://vlg-cicdt-rch.xxx.xxx/v3/connect/register"
time="2018-08-31T02:09:24Z" level=info msg="Error while getting agent config: Get https://vlg-cicdt-rch.xxx.xxx/v3/connect/config: http2: server sent GOAWAY and closed the connection; LastStreamID=1, ErrCode=ENHANCE_YOUR_CALM, debug=\"\""
time="2018-08-31T02:09:29Z" level=info msg="Error while getting agent config: Get https://vlg-cicdt-rch.xxx.xxx/v3/connect/config: http2: server sent GOAWAY and closed the connection; LastStreamID=1, ErrCode=ENHANCE_YOUR_CALM, debug=\"\""
time="2018-08-31T02:09:34Z" level=info msg="Error while getting agent config: Get https://vlg-cicdt-rch.xxx.xxx/v3/connect/config: http2: server sent GOAWAY and closed the connection; LastStreamID=1, ErrCode=ENHANCE_YOUR_CALM, debug=\"\""
time="2018-08-31T02:09:39Z" level=info msg="Error while getting agent config: Get https://vlg-cicdt-rch.xxx.xxx/v3/connect/config: http2: server sent GOAWAY and closed the connection; LastStreamID=1, ErrCode=ENHANCE_YOUR_CALM, debug=\"\""

We've moved over to ugprading via helm charts as of v2.1, if you still have upgrade issues, please open a new issue.


fix readme view bug

As title. caused by #2525, see https://try.gitea.io/morli/test_fork/src/tralala/tralala.md

Codecov Report

Merging #2566 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2566   +/-   ##
=======================================
  Coverage   27.32%   27.32%
=======================================
  Files          86       86
  Lines       17135    17135
=======================================
  Hits         4682     4682
  Misses      11775    11775
  Partials      678      678

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1eedd98...8dba862. Read the comment docs.

LGTM

Um... PR wasn't checked out sucessfully.
LGTM


Pre-release tag for v10+ for next version of provider

It would be great to get a pre release tag for the next version of the provider so that the new resources can be tested out.
Even better would be having the latest commit to master tagged as an edge release so the latest commit to master is always available for download as a tagged release,

I went ahead and released 0.11.0. If there are any problems let us know.


Screenshot issue

What versions are you running?

$ go list -m github.com/chromedp/chromedp - github.com/chromedp/chromedp v0.5.3
$ google-chrome --version - Google Chrome 80.0.3987.132
$ go version - go version go1.13.8 darwin/amd64

What did you do? Include clear steps.
I followed the example for screenshot in examples folder for taking a screenshot of specific element.
What did you expect to see?
I expected to see a fully image of the element.
What did you see instead?
Sometimes the screenshot is cut off - like I saw the few lines of pixels but the rest was blanked.
And sometimes I see only a blank image.
this is the code:
// TakeScreenShot - screenshot
func TakeScreenShot() {
	// create context
	ctx, cancel := chromedp.NewContext(context.Background())
	defer cancel()

	// capture screenshot of an element
	var buf []byte
	if err := chromedp.Run(ctx, elementScreenshot(`https://www.ynet.co.il/home/0,7340,L-8,00.html`, `[data-vr-zone='Strip 2']`, &buf)); err != nil {
		log.Fatal(err)
	}
	if err := ioutil.WriteFile("elementScreenshot.png", buf, 0644); err != nil {
		log.Fatal(err)
	}
}

// elementScreenshot takes a screenshot of a specific element.
func elementScreenshot(urlstr, sel string, res *[]byte) chromedp.Tasks {
	return chromedp.Tasks{
		chromedp.Navigate(urlstr),
		chromedp.WaitVisible(sel, chromedp.ByQuery),
		chromedp.Screenshot(sel, res, chromedp.NodeVisible, chromedp.ByQuery),
	}
}

This is what I get:

What am I doing wrong?
Note: You can not see the image because it is white...

update:
if I invoked the new context like that it works:
...
...
...
allocCtx, cancel := chromedp.NewExecAllocator(context.Background())
	defer cancel()

ctx, cancel := chromedp.NewContext(context.Background())
	defer cancel()
...
...
...

any idea why?

Same issue for me. In headless mode Screenshot method doesn't work.


#376: Support the defaultFetchSize in config.xml

For detail, refer to #376 .
Please review this pull request.

@emacarron
Thanks for merging!
I want to backport to 3.2.x line.
How do you think ?

I do not think it is needed unless you need it for you.


login failing

When I try to login with my Github account here ...
http://modules.zendframework.com/user/loing
I'm getting redirected to this url ...
http://modules.zendframework.com/?error=redirect_uri_mismatch&error_description=The+redirect_uri+MUST+match+the+registered+callback+URL+for+this+application.&error_uri=https%3A%2F%2Fdeveloper.github.com%2Fv3%2Foauth%2F%23redirect-uri-mismatch
Seems like there's a problem with the github login. Just wanted to add my first module to the list.

duplicate #300 #296

Sorry, didn't see the duplicate ...
But I'd suggest to leave this one opened on the first page. Is Ocramius already aware of it?
Someone working on a solution?

thanks for your report.
yes @GeeH is working on this as this fix needs server access

I can't login too.

And I put module in site already.

please spam https://twitter.com/GeeH as he is currently working to fix this :trollface:

Seems like there's no bug in the application, but in the Github api. Why not use normal - on site - authentication? I can't see any advantages on using Github authentication.
Instead one could make the application user associatable to Github user. This way users would still be able to login, even if the Github api will strike again.

Where I see normal authtentication?
2015-02-08 2:05 GMT-02:00 Ibrahim Süzük<EMAIL_ADDRESS>
Seems like there's no bug in the application, but in the Github api. Why
not use normal - on site - authentication? I can't see any advantages on
using Github authentication.
Instead one could make the application user associatable to Github user.
This way users would still be able to login, even if the Github api will
strike again.
—
Reply to this email directly or view it on GitHub
https://github.com/zendframework/modules.zendframework.com/issues/370#issuecomment-73396052
.

as i said this needs more access to the application that only @GeeH can provide. i don't see any advantages to use a normal login as the only use-case to register a module is to add a module from github - so please be more specific what advantage u see when using a normal login. maybe in the future when more user features are available this comes in handy, no?

@IgorDePaula the normale authentication is from Github.. In this moment this site support only github site and move it from another adapter isn't a priority.
I don't believe that the problem is in Github Api :+1: In this moment @GeeH is engaged SunShinePHP!! :)
I hope that it could work about it as soon as possible but change all auth method for me is not necessary

@ins0 Yes, the use-case is only adding github repositories, but with an on-site authentication one could also add new repos, even if the github authentication doesn't work currently, or not?
To my mind it's better to stay independent from a second application (github), as long as it's possible, but it's only my humble opinion.

I’ll need some help here. We should schedule a hangout to nail this down where I can screenshare.
On 8 February 2015 at 08:57:11, Ibrahim Süzük<EMAIL_ADDRESS>wrote:
@ins0 Yes, the use-case is only adding github repositories, but with an on-site authentication one could also add new repos, even if the github authentication doesn't work currently, or not?
To my mind it's better to stay independent from a second application (github), as long as it's possible, but it's only my humble opinion.
—
Reply to this email directly or view it on GitHub.

@isisis i agree it is just that the current process adding modules requires a linked github account - we are currently fixing many stuff that has accumulated over the time this repo was not really maintained - refactoring all classes and adding abstraction layers where switching to a normal signup don't require to recode all processes. so as @gianarb says this is currently not necessary - but yeah in the future we should replace the "only github login".
@GeeH
ping me tomorrow in irc :+1:

@GeeH help offered, how can I help you to fix this issue?

I don't understand why commits are being send to the repository, but no one fixes the authentication.
Did no one succeed fixing it or is the hosted project not being maintained anymore?
@basz offered help and I would help too, if I knew what's the current situation.

I'll poke @GeeH tomorrow, and eventually ask for SSH data if he can't check it. Right now we're pretty much drowning in work :-\

The reason is because it takes time. Time I don’t have at the moment. I’m working two jobs and this week I’m spending some time with my family that is long overdue.
I hope this is OK with you.
On 16 February 2015 at 01:10:33, Ibrahim Süzük<EMAIL_ADDRESS>wrote:
I don't understand why commits are being send to the repository, but no one fixes the authentication.
Did no one succeed fixing it or is the hosted project not being maintained anymore?
@basz offered help and I would help too, if I knew what's the current situation.
—
Reply to this email directly or view it on GitHub.

@GeeH sure it is! Thanks for letting us notice. As @Ocramius said it would be nice if we can share the ssh login with marco as well so if one is busy we still can deploy on the production server. :smiley:

@Ocramius knows how to get access if he can run with it then great. Otherwise I will look this evening.
On 16 February 2015 at 09:12:19, Marco Rieger<EMAIL_ADDRESS>wrote:
@GeeH sure it is! Thanks for letting us notice. As @Ocramius said it would be nice if we can share the ssh login with marco as well so if one is busy we still can deploy on the production server.
—
Reply to this email directly or view it on GitHub.

@GeeH :+1:

The time is a shared problem but maybe we are here to help you to manage this project in the best way :+1:

As a point of note, the site is hosted on Roave server, and only Roave employees (or trusted third parties) can have access. If you wish to get access to the server with SSH please email<EMAIL_ADDRESS>making your case. Alternatively we can host somewhere else if anyone is willing to pay and Zend are happy with the arrangement.
G
On 16 February 2015 at 09:14:13, Marco Rieger<EMAIL_ADDRESS>wrote:
@GeeH
—
Reply to this email directly or view it on GitHub.

@GeeH can you share with me google analytics data of the site?
gianarb92[at]gmail[dot]com
Thanks

I don’t have access to that sadly, chase up @Hounddog.
On 16 February 2015 at 11:31:48, Gianluca Arbezzano<EMAIL_ADDRESS>wrote:
@GeeH can you share with me google analytics data of the site?
gianarb92[at]gmail[dot]com
Thanks
—
Reply to this email directly or view it on GitHub.

Thanks! :)

Well, this bug really is an annoyance!

As far as I can tell, this only needs a small change in the administrative panel of GitHub, see this screenshot from my application:

I was able to reproduce the error by providing an Authorization Callback URL pointing to a different location. I assume it should be http://modules.zendframework.com. Maybe it's not?
Someone with admin privileges, e.g., an owner, should be able to fix this, I believe.
/cc @ezimuel @weierophinney.

Unsure if this is related, but when you navigate to https://modules.zendframework.com, you'll see this:

@andreas, I don't understand you, please can you explain again?
2015-02-19 10:47 GMT-02:00 Andreas Möller<EMAIL_ADDRESS>
Unsure if this is related, but when you navigate to
https://modules.zendframework.com, you'll see this:
[image: screen shot 2015-02-19 at 13 41 21]
https://cloud.githubusercontent.com/assets/605483/6266757/d3294582-b83d-11e4-9bf1-a6a135541c75.png
—
Reply to this email directly or view it on GitHub
https://github.com/zendframework/modules.zendframework.com/issues/370#issuecomment-75046330
.

@IgorDePaula
The point I'm making is that it might not even be necessary to SSH into the server to fix this issue, but instead might only need a glance / small change rather into the  GitHub Application Settings for this application! :wink:

@localheinz bet that's the solution to the login problem! ping @GeeH
The https:// going to zend paackages issue is an apache/nigx configuration problem

Ah, ok, I understand you now, thank you
2015-02-19 10:55 GMT-02:00 Andreas Möller<EMAIL_ADDRESS>
@IgorDePaula https://github.com/IgorDePaula
The point I'm making is that it might not even be necessary to SSH into
the server to fix this issue, but instead might only need a glance / small
change rather into the GitHub Application Settings
https://github.com/settings/applications for this application! [image:
:wink:]
—
Reply to this email directly or view it on GitHub
https://github.com/zendframework/modules.zendframework.com/issues/370#issuecomment-75047299
.

Closing this in favour of #296, as it's a duplicate - if you don't mind!


feat(ansible): add rolePublic and timeout options

这个 PR 实现什么功能/修复什么问题:

是否需要 backport 到之前的 release 分支:

release/3.5

/area ansible
/cc @yousong @zexi

Codecov Report

Merging #11150 (bad342f) into release/3.6 (b9d30c0) will increase coverage by 0.14%.
The diff coverage is 5.46%.

@@               Coverage Diff               @@
##           release/3.6   #11150      +/-   ##
===============================================
+ Coverage         5.86%    6.01%   +0.14%
===============================================
  Files              828      847      +19
  Lines           129133   132227    +3094
===============================================
+ Hits              7577     7948     +371
- Misses          120876   123572    +2696
- Partials           680      707      +27

Flag
Coverage Δ

aFlag
6.01% <5.46%> (+0.14%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/apigateway/handler/auth.go
0.00% <0.00%> (ø)

pkg/apigateway/handler/auth_totp.go
0.00% <0.00%> (ø)

pkg/apigateway/handler/idp.go
1.84% <0.00%> (ø)

pkg/apigateway/handler/misc.go
0.00% <0.00%> (ø)

pkg/apigateway/handler/resource.go
0.00% <0.00%> (ø)

pkg/apis/const.go
0.00% <0.00%> (ø)

pkg/apis/input.go
0.00% <ø> (ø)

pkg/apis/list.go
0.00% <ø> (ø)

pkg/appsrv/appsrv.go
48.67% <0.00%> (-0.56%)
:arrow_down:

pkg/baremetal/cronjobs.go
0.00% <0.00%> (ø)

... and 253 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b48632...bad342f. Read the comment docs.


Render Markdown in option docs for flakes and longDescription

Closes https://github.com/NixOS/nixos-search/issues/535, closes https://github.com/NixOS/nixos-search/issues/525
To do:

[x] We're currently creating a new temporary file containing the xref lua filter for each Pandoc invocation. This is bad. I think it would generally be nicer to package the files we need (pandoc filters, flake_info.nix) alongside flake-info: we could set a DATADIR variable in the Nix build that is detected at compile time and, if unset, defaults to CARGO_MANIFEST_DIR so that cargo run still finds the files.
[x] The pandoc crate does not let us define precisely the flavour of Markdown we want (Commonmark with a few extensions) because it does not expose all of Pandoc's formats and extensions (notably commonmark_x and +fenced_divs). For now I've set the format to markdown, which is hopefully a superset, but if finer control is needed we will have to ~invoke pandoc directly~ or fork the crate. At least manpage references seem to render fine. Ping @jtojnar @pennae
[x] There seems to be a regression with nix-security. EDIT: this is a bug exposed by making FlakeEntry tagged: we don't support multiple licenses in flake packages, so previously flake packages with a list of licenses were parsed as apps instead.

Ah, markdown requires a blank line before lists whereas commonmark doesn't. That settles it, let's switch to commonmark.

I've added Markdown rendering for longDescription.
As a reminder/note to self, XSS sanitisation is done by Elm.

@ysndr ping

(or @garbas)

Looks good, and brings in some welcome cleanup
Thank you @ncfavier
Is there a way to see the result in the preview?

Is there a way to see the result in the preview?

You can look at tmux or geomyidae.

Ah, I shouldn't have merged so soon. The nixpkgs-unstable import is currently broken (but a fix is underway), so that channel will be rolled back a bit until the next update.
Also it seems like the flake import is hitting GitHub API rate limits.


Missing App Store icon (1024pt)

This works great but it looks like (possibly due to iTunes/XCode updates) it misses generating the 1024pt App Store icon. It appears to be blank in Images.xcassets and iTunesConnect refuses to publish to TestFlight because of the lack of an icon. Maybe it was never this toolkit's intention to generate that specific icon but I think it would be good to do so.

Hi @tmaly1980 ,
Thanks for reporting this. Indeed this is new in XCode 9, and #122 already took care of it, thanks to @Minishlink but was not published.
We have automatic publishing setup but we need to follow certain commit messages convention. I added a few info info in #124 and also added an update trigger in the PR.

This is something I need for a project too. When will it be released?

Sorry, the PR had been squashed so the automatic publishing did not work haha.
It is now published as 2.4.0.
@tmaly1980 I'm closing then, but please reopen if your issue isn't fixed! :)


Folder restructuring and typescript+testing for worker

Moved all React stuff to //web and all worker things to //worker. Each have their own testsuite that gets run by GitHub Actions.

@ry The 'Request review from ' button is not appearing for me on this repo. I don't quite know why. Is that a setting you have to enable?

Review coming shortly - sorry for the delay. I need to try this out locally.

Review coming shortly - sorry for the delay. I need to try this out locally.

No problem - take your time. Just seems strange that that button is not appearing... might have to email GitHub support.

Getting this warning for the web:
Compiled with warnings.

./node_modules/typescript/lib/typescript.js
Critical dependency: the request of a dependency is an expression

I'll split this into multiple PRs as requested.


Query in the path affect the execution of the life cycle

Version
v2.4.3
Reproduction link
https://codesandbox.io/s/z3rj536wxm
Steps to reproduce
When the sub-route changes, if there is a query in the path, then the parent route is data, asyncData will execute, but it will not be created and mounted.
If there is no query in the path, data, asyncData will not execute.
What is expected ?
When data, asyncData is executed, created and mounted is executed together.
What is actually happening?
''

This bug report is available on Nuxt community (#c8703)

Could you please improve your issue description? I'm not sure what the actual problem is as the expectation / actual result isn't clear to me.
Please provide steps (for the codesandbox) like:

Go to route XYZ
See ABC in the console
Expected result: UVW in the console

https://z3rj536wxm.sse.codesandbox.io/news/intro?query=123
The page mounted is initially true
2.
click the 'go detail' button
Mounted as false
Created  function not executed

When the sub-route changes，parent router data、asyncdata not executed

That's indeed a bug! 👍

@manniL Expectation: Sub-route changes the life cycle of the parent route without any updates 🙏

I'll add that I see this bug even if there isn't any query in the path. I have an app that has routes /settings/people, /settings/people/create, and /settings/people/_id. They all use the same components, with differences in state determining what gets rendered. If I'm on /settings/people and navigate to one of the sub-routes via router.push, with no query on any of those paths, 'mounted' in the shared main component does not fire (possibly other lifecycle events too, but that's the only one I use in these pages).
In the interim, I ended up changing the two sub-routes to /settings/person/create and /settings/person/_id to work around this issue.

I just tried with Nuxt v2.8.1 on https://codesandbox.io/s/z3rj536wxm and I cannot reproduce the issue.
Closing now, please re-open if it's still reproductible.


Remove getFirstOldDom (-42 B)

Move the implementation of getOldFirstDom into diffChildren and only invoke it when necessary.
See comments inside of the PR for a discussion about this implementation.

Coverage remained the same at 100.0% when pulling 19717be222131c5a626f4a47d120c18dc63f8068 on improve-fragments-childDom-golf into c08ee16833bdcc4be7ca20497ea04307f22de0e0 on master.


Using redux inside nested components?

Are you able to use @connect descriptor inside react-router children components? For example, try moving your InfoBar into the the Home view. I cannot get that scenario to work server-side. The dispatch doesn't make it through the router and if I go around the router the actions yield a 'document is not defined' error.

I'm not entirely sure what you mean by "the dispatch doesn't make it through the router", but I have placed a @connected component inside the SignUp route with no problem. You can even change it to be the full <InfoBar/> and it works on both the client and the server.
Can you maybe reword your description or provide more of the error log, e.g. exception and stack trace?


⚠ Integration (redirect) has degraded performance

In 6ad00c7, Integration (redirect) (https://integration.ageg.ca/) experienced degraded performance:

HTTP code: 200
Response time: 2196 ms

Resolved: Integration (redirect) performance has improved in b7f3fa1.


Add support for Web Identity providers for IAM credentials

Add support for Web Identity providers for IAM credentials to the default provider chain. This feature is especially important to support the new projected token based IAM role support for EKS (Kubernetes) service accounts.
More infos here:

https://docs.aws.amazon.com/eks/latest/userguide/iam-roles-for-service-accounts.html
https://docs.aws.amazon.com/eks/latest/userguide/iam-roles-for-service-accounts-minimum-sdk.html

The official AWS SDKs already have gained support for that new feature in the following releases and it would be great if rusoto will add support soon:

Java — 1.11.623
Java (Version 2) — 2.7.36
Go — 1.23.13
Python (Boto3) — 1.9.220
Python (botocore) — 1.12.200
AWS CLI — 1.16.232
Node — 2.521.0
Ruby — 2.11.345
C++ — 1.7.174
.NET — 3.3.580.0
PHP — 3.110.7

Maybe I am wrong, but I guess we first need to fix https://github.com/rusoto/rusoto/issues/1478, then we might need to consider moving the following methods from rusoto_sts to rusoto_credentials in order to avoid circular dependencies:

assume_role_with_web_identity
assume_role_with_saml

Those methods are special because:

They do not need to be signed with credentials (see AWS documentation for more details)
They are used to obtain AWS credentials with non AWS credentials (OAuth or OpenID Connect bearer tokens resp. SAML assertions).

Note, for this issue only assume_role_with_web_identity is relevant. Nevertheless, assume_role_with_saml has the same characteristics.

Fixed in https://github.com/rusoto/rusoto/pull/1500 , thanks @alex-berger !

This issue is still not resolved, PR #1500 just provides the foundation and I am still working on adding support for "IAM roles for service accounts".
I intend to first add a corresponding credential provider to the STS service. Once this is in place we have to decide how we can add that provider to the default provider chain without introducing cyclic dependencies.

Gotcha. Reopening until this is fixed. 😄

Stupid question - is there an example of how to use this new credentials provider when using IRSA? I couldn't get it to work properly until now in my deployment

Stupid question - is there an example of how to use this new credentials provider when using IRSA? I couldn't get it to work properly until now in my deployment

This worked for me:
fn get_k8s_clients(opts: &super::Opts) -> Result<AwsClients> {
    let credentials_provider = WebIdentityProvider::from_k8s_env();
    let dynamo = DynamoDbClient::new_with(
        request::HttpClient::new()?,
        credentials_provider.clone(),
        opts.aws_region.clone(),
    );
    let s3 = S3Client::new_with(
        request::HttpClient::new()?,
        credentials_provider,
        opts.aws_region.clone(),
    );
    Ok(AwsClients { dynamo, s3 })
}```

@asthasr thanks!


Super solution for everything!

Do you think this is a valid approach?

SonarQube analysis reported 1 issue
Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

 AncientFungus:LGEPR: Cppcheck cannot find all the include files (use --check-config for details)


⚠ GitLab Server has degraded performance

In 7d79b1f, GitLab Server (https://gitlab01.its-telekom.eu) experienced degraded performance:

HTTP code: 200
Response time: 6384 ms

Resolved: GitLab Server performance has improved in 58fbdb6.


DDP include_num_input_tokens_seen fine-tuning hangs (nccl)

https://github.com/huggingface/transformers/issues/28791
Upgrade transformers to version 4.40 or higher.


Exception handling is not handled when exception occures .net core

Application will continue to run
application will not freeze all threads because of a socket timeout.
Actual behaviour :
2021-10-10 03:33:11.2630|ERROR|JustEat.StatsD.SocketTransport|System.Net.Sockets.SocketException (111): Connection refused
at void JustEat.StatsD.SocketTransport.Send(in ArraySegment metric)
at void JustEat.StatsD.IStatsDTransportExtensions.Send(IStatsDTransport transport, string metric)
at void Microsoft.Poly.Infrastructure.StatsDFloatingPointPublisher.PublishInternal(string bucket, double value, char metricType) in C:/source/src/Infrastructure/Framework/StatsDFloatingPointPublisher.cs:line 60
we are using aks version 1.21.1 with dotnet core 3.1 with this nugget. 4.1
we found the pod freezes when we reach the exception above .
is there any retry logic ,if this issue occurs, so we will not be stuck on this phase.
the only way currently  is to restart the pod ,which we want to avoid.
this happens randomly.
please let me know if you need more details.

This sounds like a networking/access issue in your application, say a firewall or network ACL.
We've never seen an issue like this before, and we use this library significantly at large scale.
Have you tried using the OnError property on the StatsDConfiguration (see the readme for an example) to swallow the error in this scenario?

Thanks , Any idea why it stops all other running thread/tasks inside the container ?
the container is actually stuck ,after this error and no activity , and we do use the onerror methode.
is there any retry logic in place ?

I'm afraid not - maybe all the requests lead to a blocked thread/task, eventually exhausting the thread pool?
No, there is no retry logic.

Closing due to inactivity and lack of evidence this is an issue with the library itself.


[TEST] Running CI pipeline with distroless static image

Commit Message: N/A
Additional Description: testing static distroless (PR for removal)
Risk Level: N/A
Testing: N/A
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A

Error message:
2021-05-02T22:05:32.6163218Z tls-inspector_1          | standard_init_linux.go:219: exec user process caused: no such file or directory

Explanation:

This error occurred because the built binary (/whatwg/wattsi/bin in the question) depends on the system having glibc installed. Presumably, when running, something is looking for the system's glibc, but Alpine Linux does not have glibc available. (Instead, it uses musl-libc, which is more minimal, but less popular.)

https://stackoverflow.com/questions/61990871/standard-init-linux-go211-exec-user-process-caused-no-such-file-or-directory
Seems Envoy is not linking libc into binary. Closing PR


docs(style): fix display of nested

Coming from https://github.com/twbs/bootstrap/pull/34223
The result can be seen here: https://deploy-preview-693--boosted.netlify.app/docs/5.0/content/reboot/ and there: https://deploy-preview-693--boosted.netlify.app/docs/5.0/migration/

No need for a PR here, you'll get it back for free when syncing with Bootstrap 👌

OK so I'm closing it! I thought the process was to also create a PR for Boosted before getting it back from Boostrap 😊

You can for a bugfix you'd want to deliver before Bootstrap, but the only moment where that could happen is right after a Bootstrap release and juste before Boostés equivalent release 🙂


Use latest modules

CI is failing on go 1.12, so I will close this issue and merge this commit into #267 where I have already bumped the build to run on go 1.13/1.14


Upload code for segmentor head

Hi,
Could you please upload code for the segmentor head? i dont see them in the codebase, while the paper clearly showed segmentation performance.
Thanks,
Michael

Same problem!

Same issue here- has this been fixed?  Many thanks!

same issue. do you fix that? thx a lot

Has this problem been solved now

same issue. do you fix that? thx a lot

Has this problem been solved now


Is there a way to decrypt to a file or stream?

Hey,
I wonder if I'm overlooking a way to decrypt to a file or a stream instead of into an in-memory object.  Is there one?
Thanks,
Hans

By reading the source code, I could come up with this function which serves my purpose:
(defn decrypt-pgp [input-file]
  {:pre [(re-find #"\.(pgp|gpg)$" input-file)]}
  (pgp-msg/reduce-messages (io/file input-file)
                           (fn [acc {:keys [data] :as message}]
                             (with-open [reader (io/reader data)]
                               (io/copy reader
                                        (io/file (clojure.string/replace input-file #"\.(pgp|gpg)$" ""))))
                             (conj acc (dissoc message :data)))
                           []
                           :decryptor (fn [id]
                                        (pgp/unlock-key (keyring/get-secret-key keyring id) ""))))

Looks like you figured it out! The reduce-messages function was added recently and is the right way to handle a message as a stream, rather than being fully loaded into memory. :+1:


Quandl security protocol upgrade

Expected Behavior
Quandl recently notified API users about an upcoming security protocol upgrade to TLS 1.2 and we should keep the LEAN client up to date.
This is the email Quandl sent to users:

Actual Behavior
NET 4.5.2 (version used by LEAN) does not enable TLS 1.2 by default.
Potential Solution
Add a static constructor to the Quandl class:
    static Quandl()
    {
        ServicePointManager.SecurityProtocol |= SecurityProtocolType.Tls12;
    }

Checklist

[x] I have completely filled out this template
[x] I have confirmed that this issue exists on the current master branch
[x] I have confirmed that this is not a duplicate issue by searching issues

Closed by https://github.com/QuantConnect/Lean/commit/5a80c29663177887c2c98882bda1a54af03d948a


[DOP-11677] - add workflow for dev release to test.pypi

Change Summary

Related issue number

Checklist

[ ] Commit message and PR title is comprehensive
[ ] Keep the change as small as possible
[ ] Unit and integration tests for the changes exist
[ ] Tests pass on CI and coverage does not decrease
[ ] Documentation reflects the changes where applicable
[ ] docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
(see CONTRIBUTING.rst for details.)
[ ] My PR is ready to review.

Еще нужно утащить из onETL патч для отображения логотипа на PyPI:
https://github.com/MobileTeleSystems/onetl/blob/8627a849ab7a5bb53aac5bfbd166b031d0f8b013/.github/workflows/dev-release.yml#L45-L47
https://test.pypi.org/project/data-horizon/


Fixed PHP 8.4 deprecations

Fixes #184

@erusev Is this repo still being maintained?

Were you able to run the tests?

I did on PHP 8.4RC1 on my local machine, and they all passed.  It's a backward-compatible change and that just makes the nullable parameters explicitly nullable.

I've pushed an update to fix some of those issues, but likely more are needed.  For example, we should probably add PHP 8.4 to CI and allow it to fail (it will until things like Psalm and PHP-CS-Fixer natively support PHP 8.4 without having to use things like PHP_CS_FIXER_IGNORE_ENV=1 to work around their lack of support).

Do you know why we have 3 branches?

What's each branch for?

I'm not sure.  It looked like 2.0.x was more up to date than master (eg it had GitHub Actions instead of TravisCI, it separated code into the src directory), which is why I rebased off it for this pull request.

Hm, ok, but if we're making a release for these changes, shouldn't it be a 0.8.x release?

What's v2 for, then? Its most recent release was a few years after 0.8.x.

It's probably a version of the extensions that was designed to work with Parsedown 2.0. It's something @aidantwoods was working on but it might be abandoned.
I'm also not sure why 0.8 is a separate branch from master.
There's a discussion about the same thing in Parsedown at https://github.com/erusev/parsedown/pull/881.

@aidantwoods can I merge 0.8 into master and delete it?

It's been a while, but I think parsedown 1.8.x (and extra 0.8) had some risk of breaking extensions due to internal changes to escaping HTML. I think I put these out as prereleases because I wasn't sure what the BC promise should be for not breaking extensions (given they hook into a protected API surface rather than a public one).

Do you think it still makes sense to have that branch? The latest release, 0.8.1 is almost 5 years old now.

If we're happy releasing 1.8 as stable I think there's no need to keep the separate branches around

@davidbyoung Can you create a PR that fixes PHP 8.4 deprecations in 0.8.x branch and also adds a GitHub workflow for testing similar to the one in the 2.0.x branch?
You can also use the GitHub workflow at https://github.com/erusev/parsedown as reference.

Closing in favor of #186.  @erusev There was only a single deprecation I had to fix, plus I had to pull in some minor changes from master to get the tests to work.  I don't have permission to actually try running the GitHub Actions CI, so you'll need to approve that workflow when you get a minute.  Finally, I didn't re-add all the tools that were in v2 of Parsedown Extra (eg Psalm) as that felt out of scope for this particular fix.

Merged.
Should we also make a release? Let's say 0.8.2.

Merged.
Should we also make a release? Let's say 0.8.2.

Yep, sounds good.

@erusev Can you tag 0.8.2?

Tagging it as a patch (0.8.2) is probably not right because it now points to a newer version of Parsedown version, and this feels like a breaking change.
We should resolve https://github.com/erusev/parsedown/pull/881 first, and then make a release here.
Does this make sense?


Decoration for symbolic link not showing up in this case

Steps to Reproduce:

create a folder with a couple of files and one symbolic link (ln -s <existing file> <symlink name>)
open this folder in VSCode
notice how the symlink correctly gets the arrow decoration for sym link
click on the link to open it
reload window

=> 🐛 the decoration does not appear anymore. it seems that as soon as an editor is opened matching the symlink, the decoration is not resolved?
Somehow does not reproduce in current insiders, so I wonder what changed here and if it could possibly be my change from yesterday, but I do not understand the correlation.

If it does not reproduce in current insiders I will look at it as fixed :)
For more details we could put a breakpoint here
And check what is the state that the ExplorerItem is in when we are asked to provide decorations.

@isidorn maybe I was not clear, this fails running out of sources and our insiders is not up to date.

Looked into this and it is a timing issue.
If you open the file in an editor it will try to get the decoration provided before the Explorer has a chance to resolve it (because the tab area is rendered before the explorer area).
Thinking about a solution...


Add --ignore-gooey option to README

Hi!
Not a bug so much as an oversight in the readme perhaps?
I spent quite a long time agonising about how to make a CLI interface and a GUI option play nicely together. I knew there had to be an elegant solution somewhere (such as switching between framework/non-framework python.
I noticed in the STDOUT while the program ran however, that it spits out a verbose version of the full call to python which highlighted the --ignore-gooey option which suffices for this perfectly - but there is no mention of this in the README, or any docs I could find.
Could I suggest/request this be highlighted somewhere (and perhaps a more full guide with it if there are other things to consider when using --ignore-gooey that I'm not aware of).
Otherwise, love the package!
Joe

In Windows I was able to use sys.stdout.isatty().

import sys
def prompt_for_one_of(prompt_text, *args):
    if sys.stdout.isatty():
        while True:
            print(prompt_text)
            for i,s in enumerate(args): print(f'{i+1}. {s}')
            i=input()
            try:
                return args[int(i)-1]
            except:
                pass

    else:
        import PySimpleGUI as sg
        window=sg.Window(Path(__file__).stem,
                         [ [sg.Text(prompt_text)],
                           [sg.Button(t) for t in args] ])
        event, values = window.Read()
        window.Close()
        return event

2. I also have this, so if you run my app with no parameters you get the GUI, but if you run in with any parameters you can the CLI version; so this is backwards compatible with the tool before gooey

if len(sys.argv)>=2:
    if not '--ignore-gooey' in sys.argv:
        sys.argv.append('--ignore-gooey')

Hey @jrjhealey,
Yeah, --ignore-gooey was originally intended as an internal implementation detail. However, people have independently discovered it several times over trying to accomplish exactly what you're after. So, maybe it is time to actually document it ^_^
I've been slowly updating README and docs/ on the release branch. I've updated your issue title and will make sure it goes into the next release!
Out of curiosity, are there any other pieces of Gooey you feel are under documented?
Thanks!

That’d be perfect thanks Chris!
I’ve barely dipped my toe in the water, but the only other things I’ve noticeably struggled with whilst using Gooey so far have been (just off the top of my head, and I realise these aren’t necessarily undocumented aspects per se):

I think some of the widget choices are still undocumented? Or at least, what widget choices all the normal argparse actions will map to. I know the docs say that by-and-large, sensible widgets will be chosen for each action, it might be good to have a full mapping for this.

More documentation for the customisation of the GUI window might be useful, in my testing, I wasn’t able to get several of the colour options to take effect, only the header would ever change colour. Perhaps this is a bug, or perhaps there’s more to it than I’ve realised/the documentation lets on?

The last thing is packaging for MacOS which I still haven’t cracked yet, but I realise this is an active issue in other threads, so is probably more than a documentation issue.

I also have this, so if you run my app with no parameters you get the GUI, but if you run in with any parameters you can the CLI version; so this is backwards compatible with the tool before gooey
    if len(sys.argv)>=2:
        if not '--ignore-gooey' in sys.argv:
            sys.argv.append('--ignore-gooey')

This is exactly what I needed (only start Gooey if the script is started without argument, otherwise operate as CLI). It is very simple and straightforward, however there is a caveat that took me some time to understand:
⚠ you need to place the code before the @Gooey() decorator.
So for example, you can do like this like this:
import sys
from gooey import Gooey, GooeyParser
# other imports...

# this needs to be *before* the @Gooey decorator!
# (this code allows to only use Gooey when no arguments are passed to the script)
if len(sys.argv) >= 2:
    if not '--ignore-gooey' in sys.argv:
        sys.argv.append('--ignore-gooey')

@Gooey(options=...)
def main():
    parser = ....
    # rest of your code

if __name__ == '__main__':
    main()

Initially I tried putting it in the if __name__ == '__main__' section, but that won't work.
if __name__ == '__main__':
    # this does NOT work, it is executed too late
    if len(sys.argv) >= 2:
        if not '--ignore-gooey' in sys.argv:
            sys.argv.append('--ignore-gooey')
    main()

@ jrjhealey  regarding your point on OSX packaging, would you mind giving the new packaging docs a whirl?

Will give it a try ASAP :)
Just FYI, I'm getting 404s on both of the links to the template .spec files at the moment (but this could be me as I'm currently on a crap internet connection).

@jrjhealey if you get 404 it means your Internet connection is fine. That means the server didn't find the resources. Not your fault.

@zertrin your solution is brilliant and is exactly what we were looking for regarding a recent project we are working on.  I’m wondering if there is an even more elegant way to somehow add a Boolean option into the decorator to toggle Gooey UI on or off depending on arbitrary logic determined in the code.  For example listen for -ui in sys.argv and have that be the trigger to enable Gooey.  I haven’t looked at the source code yet, but it seems this should be possible.
I do also think the use case to fallback to ui or give the user a choice is definitely something that should be fully implemented and in the docs too. Our use case for example was a distributable app for on demand usage (GUI) that we might also want to use for cron jobs (CLI).

@zertrin @eladeyal-intel Your solution for no arguments == GUI, arguments == CLI just helped me immensely.
Can this be an option in the Gooey decorator?

One of the issues with the above solution is that if you are using just the CLI, then you are still doing import gooey, which can take a measurable amount of time, and is unnecessary.
Instead, you can do this, which avoids the import if not needed:

# Normal main function without Gooey decorator.
def main():
    # etc.

if not sys.stdout.isatty():
    # If we are not attached to a terminal, use Gooey
    from gooey import Gooey
    main = Gooey(main)

    # or:
    # main = Gooey(options=...)(main)

# otherwise, simply don't import or use Gooey at all

if __name__ == '__main__':
    main()

In main = Gooey(main) we are just using the longhand way of using a decorator.

It'd be nice if Gooey moved away from --ignore-gooey (but still eft it in) and just did this by default, configurable by the an argument to the decorator.

  The readme still gives no indication of how to run both cli and gui versions, which is a basic requirement for such programs.
Worst of all, the key and completely counterintuitive info that --ignore-gooey must be placed in sys.argv BEFORE the @Gooey decorator (why?) is still buried in zertrin's comment in the middle of this obscure hidden page.
Do the developers even run command line programs??  It seems they don't care at all about preserving & documenting basic functionality that's been standard behavior since the 1970s.
Overall nice project, great work.  It's like you built a fabulous luxury car... and then forgot to install a gas tank.

For anyone interested, I came across this same issue and have shared my solution as a wrapper to Gooey.
skeenp/gooeywrapper based on my own experiences and information in this thread.
I needed a reusable wrapper for the platform for a stack of GUIs across a number of projects. The wrapper handles using argparse when in CLI mode, Gooey when in GUI mode and also detects if running in CLI mode in the interactive window of the GUI.
The main thing this does that adds to the information in this thread is to address the different options add_arguments supports between argparse and Gooey. For example, argparse raises an error if it gets passed 'widget'. This has meant that it was difficult to reuse the code.

@skeenp Man, I can't thank you enough. I do have one question, how is one to use the @Gooey declarator using your wrapper?


Failed assertion: line 110 pos 12: '_positions.isNotEmpty'

Steps to Reproduce

...
...
...

Logs

This issue needs more content in order to be actionable.


Big refactor of launching process

The new launcher exe will start the game directly in its own address space. No illegal calls will be made in DllMain of Northstar.dll. Fixes Windows 7 access violation issues.

Includes optional launcher.dll proxy (need to rename old launcher.dll to launcher.org.dll). This allows the game to be launched through Origin's DRM (original Titanfall2.exe) and completely avoid the "file corruption" error. Good backup solution if someone keeps getting that error and cannot get rid of it.
The above is not yet recommended as a default installation option, probably, because of no super-straightforward way of toggling between vanilla game and Northstar, and more complicated installation. A file like run_northstar.txt with content of either 0 or 1 is one idea on how to handle it. Currently both launch methods will launch the original game if passed the -vanilla parameter.

Both loading method can be used at once and they will not interfere with each other negatively.
TODO: Currently support for ns_startup_args.txt and ns_startup_args_dedi.txt was removed.
My easiest recommendation is to restore its support in Northstar.dll itself, hook CommandLineA() inside of InitialiseNorthstar() (before official LauncherMain is called), since LauncherMain does use this function to initialize the CommandLine() wrapper (it ignores the LauncherMain function parameters completely).

Also included a little refactor of masterserver communication by setting client options in one place and allowing to disable HTTPS verification with -msinsecure option for local debugging of the communication (@BobTheBob9 fix that 500 backend error I'm getting smh my head)

Is there a way you can do this without replacing DLLs? Maybe by loading both from a separate process? I'm hoping to implement an option to load tf2 from a separate dir so I can have it mounted read-only in the container so it can run without side-effects or race conditions.

Is there a way you can do this without replacing DLLs? Maybe by loading both from a separate process?

Sadly as far as I thought, not really. Though today after sleep I think that maybe a proxy of some launcher.dll's or Titanfall2.exe's dependency could work, maybe... In theory this hook dll doesn't do anything with launcher.dll itself, so it could work.

I'm hoping to implement an option to load tf2 from a separate dir so I can have it mounted read-only in the container so it can run without side-effects or race conditions.

Maybe CoW or symlinks could help, I'm just wondering how much such feature could screw things up without that xd
But, launcher.dll proxy is only needed for client where Origin throws up, I assume container is for dedi, so it's not needed there, you can just use the new launcher exe without replacing that DLL

FYI I fucked something up in the last commit and it doesn't copy any mod files into runtime/compiled at all besides scripts.rson. Otherwise previously it worked pretty nicely

But yeah, after last commit it's borked and I need to take a break now, so pushed it out, idk how to debug the no copying of files

Two ideas:

I could just do the opposite method and symlink files from the volume into the container (this is probably what I'll do, since I'm making a custom entrypoint anyways).
It may be possible to patch wine to handle the redirections... I'll be looking into this more later.

I call ready to merge


chore: simplify tracing of known type and required in nested rules

After #177 and #178.
E.g. in allOf/oneOf, we just rely on the checks in parent rule, but only for type/required checks.
In the following schema, the nested allOf will just check for { required: ['yyy'] }:
{
  type: 'object',
  required: ['xxx','zzz'],
  allOf: [{
    type: 'object',
    required: ['xxx', 'yyy']
  }]
}

Properties/items can't be inherited as they affect evaluation checks, which should be isolated from the parent.
The new if (definitelyType(...typearr)) return null line which replaced manual check in history is now able to catch more cases, which can be seen in generated code diffs, when we got type information from a ref (compare after #178 is landed, or just review d997a64024298510d279ca39b850da30064beb93).
This also will make #176 (nested discriminators) stop complaining with just a single type: 'object' check on the top level.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (add7790) 99.54% compared to head (d997a64) 99.54%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files

Files
Coverage Δ

src/compile.js
99.29% <100.00%> (-0.01%)
:arrow_down:

@ChALkeR do we need to rebase + uncomment this test? https://github.com/ExodusMovement/schemasafe/pull/177/files#diff-6208744208cefe72d8f280336376b2302056b2d145203d67bd97c35f86ac9846R18

@mvayngrib Done!

This will still need a formal rebase after #177 and #178 land.

This apparently now needs a rebase and re-reviews.

Rebased

This apparently now needs a rebase and re-reviews.

@ChALkeR maybe we want to disable that requirement?


[PE-D][Tester D] Functionality Bug 1: Unable to add contact with valid email

The app indicates a formatting error with the email when adding the client contact as per the first screenshot.
But the email is valid as per the requirements/restrictions specified.
Screenshot 1:

I believe the app cannot add the contact due to another error meaning the error message displayed does not match the actual error. This is because I was able to successfully add another contact using the exact same email as per the second screenshot. I was testing the "Add client" feature but changing the order of parameters supplied so that could be the cause of the actual error.
Screenshot 2:

Labels: type.FunctionalityBug severity.Low
original: sam-theman88/ped#2

d/ is not a parameter for add -c, therefore it is read together with the rest of the email and the entire string is treated as the email.


Manage all Tuya devices with node-red

For the development of TuyaDAEMON I have collected a series of information that I believe may be of general interest.

Most Tuya-branded devices are controllable using the  tuya-smart-device node. All you need is the deviceID,  the localKey, and knowing the DPs and behavior of the device.

Some devices CANNOT be controlled locally with "tuya-smart-device" because they do not have a stable WiFi connection (typically battery-operated WiFi sensors). In these cases, you can use Tuya 'OpenAPI' via REST with node-red. Requires Tuya credentials and deviceID. Available as TuyaDAEMON extension and also as node-red library.

OpenAPI can be used only in polling. It is not possible to use it for asynchronous events generated by devices (e.g. alarms). One solution is the HW/SW trigger mechanism (designed for TuyaDAEMON), which allows bidirectional communications between SmarlLife Automation and node-red. Available as TuyaDAEMON extension and also in lite version.

Many WiFi products without the Tuya logo are built by various manufacturers (Ikea, Philips, Siemens...) with their own APP, but were developed using Tuya. Some of these products CAN be managed with SmartLife. Unfortunately, this needs to be verified on a case-by-case basis (Tuya communication).

Even some ZigBee devices produced without Tuya compatibility can be associated with a ZigBee-Tuya hub (e.g. thermometers for Xiaomi's HomeKit APP).

A) how to find deviceID, and localKey:
1. deviceID only: in SmartLife, Device Info
2. use Tuya IoT Development Platform for Tuya credentials
3. use tuyapi_cli wizard
4. use OpenAPI: 'Query Device Details' (preferred)
B) How to Find DPs.
The simplest solution is to use the 'Send Properties' API (see here)
C) The study of the behavior and quirks of a device is greatly aided by the Log (max 7 days) present in 'Tuya Development Platform' (see here)
Caveat: Tuya OpenAPI and Automation are not very stable. Tuya occasionally changes the structure of Tuya Cloud; the latest change (June 20, 2023) made it necessary to update all Automation due to a change in the name of a condition. A change of deviceID also invalidates the Automation.
I hope this information helps someone

Thanks @msillano for the information


Change tests like "network changes emitted correctly", "network changes not emitted in started state" and "calls correct starts when network changes" in thaliMobileTest

The logic we use to talk to the coordination server doesn't seem to handle the case where we turn off and then turn wifi back on. The reconnection logic doesn't figure out that wifi is back. So we have to fix that before we can run these tests.

We need to work around ENETUNREACH error. Our coordination client wants not to receive this error.

https://gist.github.com/vasilevskayaem/a551cec8ee4771ca44e7e1622d3c9a50


odb: protecting dbModule::makeUniqueDbModule()::name_id_map with a lock

Protects the static variable name_id_map from the dbModule::makeUniqueDbModule method with a lock (issue https://github.com/The-OpenROAD-Project/OpenROAD/issues/5981)

This does not seem like an acceptable solution. If you have multiple odb's won't calls to makeUniqueDbModule interfere with each other?

Interfer in the sense that the numbering will depend on the order of the calls.  It won't be a thread safety issue but it could cause some non-determinism in the names.

I think the easiest thing to do is move name_id_map to be a non-persistent member of dbBlock.  No lock is then needed and the extra memory will disappear on close.

Implemented as @maliberty suggested in the PR #6300.


Please update dependency figwheel-sidecar

Please update 49 line  in re-frame-template/src/leiningen/new/re_frame/project.clj
[figwheel-sidecar "0.5.16"] -> [figwheel-sidecar "0.5.18"]
because of the issue https://github.com/clojure-emacs/cider/issues/2571
thanks.

Hi, I found updating for this issue.
Now, I can use cider!
thanks a lot.


[Deployment, databases, and servers tasks] Update dependencies on "AzureRMDeploy-common" package to fix high vulnerability issues

Required Information
Entering this information will route you directly to the right team and expedite traction.
Question, Bug, or Feature?
Type: Bug
Enter Task Name:

AzureAppServiceSettingsV1
AzureFunctionAppContainerV1
AzureFunctionAppV1
AzureWebAppContainerV1
AzureWebAppV1

Issue Description
These tasks have dependency on "azure-pipelines-tasks-azurermdeploycommon" that has critical vulnerability in "typed-rest-client > underscore".

Please update this dependency to latest version.
This vulnerability was fixed in PR.
Error logs
To get error log for each task run npm audit

Hi, @nadesu could you please take a look?

PR has been merged.


Android build out of memory

flutter build apk --release

Anyone running into issue with building release version for android No problem on iOS, but android running out of memory when trying to build. Not really sure of the caused.
/Users/phongkien/.gradle/caches/modules-2/files-2.1/androidx.annotation/annotation-jvm/1.6.0/a7257339a052df0f91433cf9651231bbb802b502/annotation-jvm-1.6.0.jar!/META-INF/annotation.kotlin_module: Module was compiled with an incompatible version of Kotlin. The binary version of its metadata is 1.8.0, expected version is 1.5.1.
e: /Users/phongkien/.gradle/caches/transforms-3/61b020a42ce3388a980549dd2a9d211b/transformed/jetified-annotation-experimental-1.3.0/jars/classes.jar!/META-INF/annotation-experimental_release.kotlin_module: Module was compiled with an incompatible version of Kotlin. The binary version of its metadata is 1.7.1, expected version is 1.5.1.
e: /Users/phongkien/.gradle/caches/modules-2/files-2.1/org.jetbrains.kotlin/kotlin-stdlib/1.8.21/43d50ab85bc7587adfe3dda3dbe579e5f8d51265/kotlin-stdlib-1.8.21.jar!/META-INF/kotlin-stdlib-jdk7.kotlin_module: Module was compiled with an incompatible version of Kotlin. The binary version of its metadata is 1.8.0, expected version is 1.5.1.
e: /Users/phongkien/.gradle/caches/modules-2/files-2.1/org.jetbrains.kotlin/kotlin-stdlib/1.8.21/43d50ab85bc7587adfe3dda3dbe579e5f8d51265/kotlin-stdlib-1.8.21.jar!/META-INF/kotlin-stdlib.kotlin_module: Module was compiled with an incompatible version of Kotlin. The binary version of its metadata is 1.8.0, expected version is 1.5.1.
e: /Users/phongkien/.gradle/caches/modules-2/files-2.1/org.jetbrains.kotlin/kotlin-stdlib/1.8.21/43d50ab85bc7587adfe3dda3dbe579e5f8d51265/kotlin-stdlib-1.8.21.jar!/META-INF/kotlin-stdlib-jdk8.kotlin_module: Module was compiled with an incompatible version of Kotlin. The binary version of its metadata is 1.8.0, expected version is 1.5.1.
e: /Users/phongkien/.gradle/caches/modules-2/files-2.1/org.jetbrains.kotlin/kotlin-stdlib-common/1.8.21/d749cd5ae25da36d06e5028785038e24f9d37976/kotlin-stdlib-common-1.8.21.jar!/META-INF/kotlin-stdlib-common.kotlin_module: Module was compiled with an incompatible version of Kotlin. The binary version of its metadata is 1.8.0, expected version is 1.5.1.
ERROR:R8: java.lang.OutOfMemoryError: Java heap space

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':app:minifyReleaseWithR8'.
> com.android.tools.r8.CompilationFailedException: Compilation failed to complete

What is the value of the following variable in your gradle.properties?: org.gradle.jvmargs
You can set it to  org.gradle.jvmargs=-Xmx2G or org.gradle.jvmargs=-Xmx4G or an exact value like org.gradle.jvmargs=-Xmx2048m

issue with latest gradle conflicts.


define hasParticipant, hasBiospecimen, hasStudy, hasDatafile in model (post March)

Currently the specific mappings for hasParticipant, hasBiospecimen, hasStudy, and hasDatafile are only found in schematic_json_transformer.py and not in the model itself, but this is confusing to external users (e.g. Eric from FHIR team)
How these are defined in YAML, e.g.:

hasStudy:
definition_uri: include:hasStudy
description: Link to a Study
title: Has Study
range: Study

How they are defined in transformer:

"hasParticipant": "participantExternalId",
"hasBiospecimen": "sampleExternalId",
"hasStudy": "studyCode",
"hasDatafile": "fileExternalId"

this might change in future if transformer/schematic changes, so might not be relevant

This is indeed a symptom of LinkML and schematic being out of sync.
Those properties are in the model, but we define the mapping between them in the transformer because if schematic gets an object in the range (e.g. Participant hasStudy Study) then it puts all the Study attributes in the manifest for Participant even though the only desired  one is StudyCode.
Schematic is working on a fix for this so it is only temporary. I Think we should keep this ticket alive until that happens so we can be reminded to remove it when the fix is  implemented in schematic.

closing issues related to {schematic}


[Question] Any magic in visual grounding?

Question
I find LLaVA can not only output text, but also output the coordinates using the prompt like:
Please output the coordinate position of the person in the picture.

I'm wander is there any training tricks for coordinates for LLaVA?
Or:

Just take the coordinates as plain text?
Take the output of Grounding DINO?

It is a magical thing in my knowledge that the model can learn the relationship between coordinate values and offset through plain text (the larger the value, the closer it is to the lower right corner of the image).
Thanks in advance!

Well in the paper they actually trained it with bounding box.. I guess this is kinda the outcome of this.

Well in the paper they actually trained it with bounding box.. I guess this is kinda the outcome of this.

I don't think they trained with bbox coordinates, in the original work, they just introduced coordinates to prompt GPT-4 for spatial relationship understanding.

Well in the paper they actually trained it with bounding box.. I guess this is kinda the outcome of this.

I don't think they trained with bbox coordinates, in the original work, they just introduced coordinates to prompt GPT-4 for spatial relationship understanding.

That's what I meant, but I guess you're correct, they did not provide the model with those coordinates, rethinking this, that's actually an interesting outcome

Well in the paper they actually trained it with bounding box.. I guess this is kinda the outcome of this.

I don't think they trained with bbox coordinates, in the original work, they just introduced coordinates to prompt GPT-4 for spatial relationship understanding.

That's what I meant, but I guess you're correct, they did not provide the model with those coordinates, rethinking this, that's actually an interesting outcome

I re-read the report of LLaVA-plus, the LLaVA-plus seems be an agent, which output a specific json ( command ) to run the grounding models like Grounding DINO. Then integrate the output of DINO into prompt and re-generate the text for user.
If I have any misunderstandings, please point them out.

what a interesting finding, after check their dataset, i didnt find even 1 data about grounding.

what a interesting finding, after check their dataset, i didnt find even 1 data about grounding.

@Linziyang1999 @FHL1998 @parap1uie-s
Well, in LLaVA-v1.5, they do use data about grounding and refering, you could check the data they constructed using VG and RefCOCO.

what a interesting finding, after check their dataset, i didnt find even 1 data about grounding.

@Linziyang1999 @FHL1998 @parap1uie-s Well, in LLaVA-v1.5, they do use data about grounding and refering, you could check the data they constructed using VG and RefCOCO.

I mean grounding specific coordination

What do you mean by grounding specific coordination? Is the image below shows about grounding specific coordination?

What do you mean by grounding specific coordination? Is the image below shows about grounding specific coordination?

I didn't see this in dataset mix665k and blip_laion558k, could you tell how can I find the dataset. Is it the dataset used in training llava-llama-preview ? TAT

What do you mean by grounding specific coordination? Is the image below shows about grounding specific coordination?

I didn't see this in dataset mix665k and blip_laion558k, could you tell how can I find the dataset. Is it the dataset used in training llava-llama-preview ? TAT

@Linziyang1999 But it is in the mix665k . You could search the key words ' bounding box coordinate ' in the value of conversations.

What do you mean by grounding specific coordination? Is the image below shows about grounding specific coordination?

I didn't see this in dataset mix665k and blip_laion558k, could you tell how can I find the dataset. Is it the dataset used in training llava-llama-preview ? TAT

@Linziyang1999 But it is in the mix665k . You could search the key words ' bounding box coordinate ' in the value of conversations.

Thank you!


adding intitial glog implementation file

This should start the initial work to implement Google logging.  It will need some work but the basic file is there just from reading the glog documents, this should be easy to finish out from here.

Oh, I assume we will need to add the library to CMakeLists when we start actually using the library on the project

Yes, it will need to get added to CMakeLists. See the issue I created.


order encoders & autoadd pydantic, msgspec encoders

Changes:

order encoders, prepend by default
add encoders for pydantic, msgspec when importable
bump to python 3.9

@devkral nop. Lilya won't have Pydantic and Msgspec as defaults. That is for Esmerald. Lilya is bare minimum. Also can you remove the python 3.8 dependencies, please? I think the mypy was updated and that's why is failing the ci

thx


remove oneWordAvailable

remove retired method from API
update tests
change link on package.son

looking good, thanks man!

I also bumped the version and re-published the package to npm :smile_cat:


feat: Admin screen-Account configuration

To maintain a more cohesive structure make sure your files are js as the rest of them

Changed .jsx files to .js as requested

in both AdminProfile.js and AdminProfileUpdate there is this import: import '../../styles/styles.css'
I think you should change it to '../styles/styles.css' because it gave me run error otherwise.
The screens look nice but in profile Update, the user should have to repeat the password when updating a new one. Also, in the future the container should be centered, but its okay for now.

Changed as requested


Panic during apex deploy

panic: runtime error: invalid memory address or nil pointer dereference
[signal 0xb code=0x1 addr=0x0 pc=0x139e99]

goroutine 9 [running]:
panic(0x67b240, 0xc8200120f0)
	/usr/local/go/src/runtime/panic.go:464 +0x3e6
github.com/apex/apex/function.(*Function).configChanged(0xc820081080, 0xc82048a2f0, 0x0)
	/Users/tj/dev/src/github.com/apex/apex/function/function.go:660 +0x409
github.com/apex/apex/function.(*Function).Deploy(0xc820081080, 0x0, 0x0)
	/Users/tj/dev/src/github.com/apex/apex/function/function.go:195 +0x2b6
github.com/apex/apex/project.(*Project).Deploy.func1.1(0xc820064d80, 0xc820081080, 0xc820064de0)
	/Users/tj/dev/src/github.com/apex/apex/project/project.go:181 +0x71
created by github.com/apex/apex/project.(*Project).Deploy.func1
	/Users/tj/dev/src/github.com/apex/apex/project/project.go:187 +0xd0

I saw this too.  Worked around it by temporarily downgrading to v0.7.0.

Thanks for reporting. It's related to how we handle VPC configuration.

wtf weirdddd that's the thing I couldn't reproduce..

yeah, for me I don't think it is related to VPC. I can only reproduce it on one of my projects

I think for me it is happening after upgrading from apex v0.5.1 to v0.7.1, I had functions deployed with older version, and they are throwing the exception. New function deployments seem to be working fine


Fix german spelling error

1. Why is this change necessary?
https://www.duden.de/rechtschreibung/erhalten#block-duden-tiles-5
2. What does this change do, exactly?
It fixes a german spelling error in Setup Wizard and performance/main.ini
3. Describe each step to reproduce the issue or behaviour.
Global String search for "erhälst"
4. Please link to the relevant issues (if any).

5. Which documentation changes (if any) need to be made because of this PR?

6. Checklist

[ ] I have written tests and verified that they fail without my change
[x] I have squashed any insignificant commits
[ ] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/SW-20348
Please use this issue to track the state of your pull request.

Hi @tomm1996,
thank you for the PR. It is merged now.

Yes, but I have to say we cherry picked this for 5.3 version. Thank you for your contribution


Implement better locations for "edit this page"

It is currently in the right sidebar (above "on this page") which doesn't work too well for things like landing pages of a website.

Let's do both, with former being configurable via "top_of_article_links": ["view", "edit"].

The missing piece here is top_of_article_links, since I like the location of where the icons are now.

How is it possible to configure this? The docs only say "Todo" unfortunately: https://pradyunsg.me/lutra/customisation/edit-view-buttons/


take into account binary values

In this version of javascript, comparing a binary value written with 0b does not work. Indeed, the value should first be transformed from binary to decimal

i think a better way to fix this is to stop using binary values in the eep spec...


DRILL-7253: Read Hive struct w/o nulls

Jira - DRILL-7253.

Hi @vvysotskyi, I've addressed your comments. Could you please check again ?

+1, please squash the commits.


extra_template_vars() sending wrong view_name for index

See https://github.com/simonw/museums/issues/20#issuecomment-609103663 - at some point between 286ed286b68793532c2a38436a08343b45cfbc91 and current master (e0e7a0facfc935a835cd73c720bc46661462f0b1 today) a bug was introduced where the extra_template_vars(request, view_name) plugin hook started being passed None instead of index for the view_name parameter on the site index page.

I think I'll use git bisect run for this one, mainly to practice using it. https://git-scm.com/docs/git-bisect#_bisect_run

Once I fix this bug I should update https://github.com/simonw/museums to deploy using the latest Datasette release as opposed to being anchored to 286ed28.

In order to use git bisect run I need to write a standalone script that can tell if the bug is present or not.
I'm going to use something I can execute with pytest, based loosely on this code:
https://github.com/simonw/datasette/blob/7656fd64d8b6a32ebc34d89c1b8711cc5ea240f7/tests/test_plugins.py#L205-L227

OK, here's the test harness. Three files:
check_view_name.py
import asyncio
from datasette.app import Datasette
import httpx

async def run_check():
    ds = Datasette([], template_dir="templates", plugins_dir="plugins",)
    async with httpx.AsyncClient(app=ds.app()) as client:
        response = await client.get("http://localhost/")
        assert 200 == response.status_code
        assert b"view_name:index" == response.content, response.content

if __name__ == "__main__":
    loop = asyncio.get_event_loop()
    loop.run_until_complete(run_check())

templates/index.html
view_name:{{ view_name }}

plugins/extra_vars.py
from datasette import hookimpl

@hookimpl
def extra_template_vars(view_name):
    return {"view_name": view_name}

python check_view_name.py against 286ed28 exits cleanly.
python check_view_name.py against current master (e0e7a0fa) fails:
$ python check_view_name.py
Traceback (most recent call last):
  File "check_view_name.py", line 16, in <module>
    loop.run_until_complete(run_check())
  File "/usr/local/Cellar/python/3.7.5/Frameworks/Python.framework/Versions/3.7/lib/python3.7/asyncio/base_events.py", line 579, in run_until_complete
    return future.result()
  File "check_view_name.py", line 11, in run_check
    assert b"view_name:index" == response.content, response.content
AssertionError: b'view_name:None'

You start git bisect by giving it a known bad commit and a known good one:
git bisect start master 286ed28

Then you tell it to start running your script:
git bisect run python ../datasette-issue-716/check_view_name.py

Here's what I got:
(datasette) ~/Dropbox/Development/datasette $ git bisect start master 286ed28
Bisecting: 30 revisions left to test after this (roughly 5 steps)
[dc80e779a2e708b2685fc641df99e6aae9ad6f97] Handle scope path if it is a string
(datasette) ~/Dropbox/Development/datasette $ git bisect run python ../datasette-issue-716/check_view_name.py
running python ../datasette-issue-716/check_view_name.py
Traceback (most recent call last):
...
Bisecting: 15 revisions left to test after this (roughly 4 steps)
[7c6a9c35299f251f9abfb03fd8e85143e4361709] Better tests for prepare_connection() plugin hook, refs #678
running python ../datasette-issue-716/check_view_name.py
Traceback (most recent call last):
...
Bisecting: 7 revisions left to test after this (roughly 3 steps)
[0091dfe3e5a3db94af8881038d3f1b8312bb857d] More reliable tie-break ordering for facet results
running python ../datasette-issue-716/check_view_name.py
Traceback (most recent call last):
...
Bisecting: 3 revisions left to test after this (roughly 2 steps)
[ce12244037b60ba0202c814871218c1dab38d729] Release notes for 0.35
running python ../datasette-issue-716/check_view_name.py
Traceback (most recent call last):
...
Bisecting: 0 revisions left to test after this (roughly 1 step)
[4d7dae9eb75e5430c3ee3c369bb5cd9ba0a148bc] Added a bunch more plugins to the Ecosystem page
running python ../datasette-issue-716/check_view_name.py
Traceback (most recent call last):
...
70b915fb4bc214f9d064179f87671f8a378aa127 is the first bad commit
commit 70b915fb4bc214f9d064179f87671f8a378aa127
Author: Simon Willison<EMAIL_ADDRESS>Date:   Tue Feb 4 12:26:17 2020 -0800

    Datasette.render_template() method, closes #577

    Pull request #664.

:040000 040000 def9e31252e056845609de36c66d4320dd0c47f8 da19b7f8c26d50a4c05e5a7f05220b968429725c M	datasette
bisect run success

So 70b915fb4bc214f9d064179f87671f8a378aa127 introduced the bug!

Found it. Prior to that change I passed view_name to the callbacks like this:
https://github.com/simonw/datasette/blob/286ed286b68793532c2a38436a08343b45cfbc91/datasette/views/base.py#L114-L132
I switched over to doing this:
https://github.com/simonw/datasette/blob/07e208cc6d9e901b87552c1be2854c220b3f9b6d/datasette/views/base.py#L95-L97
But forgot to pass in the optional view_name= argument to that rende_template() method:
https://github.com/simonw/datasette/blob/2aaad72789c427875426673c1a43e67c86fc970e/datasette/app.py#L554-L556
Next step: write a failing test, then fix it.

The test ended up being a bit fiddly - here it is:
https://github.com/simonw/datasette/blob/09253817dea3c131553494f9b2eb9c03f94ae761/tests/test_plugins.py#L266-L317
In writing this I realized that the name on the QueryView class wasn't being used, because that class is currently just used for its .data() method:
https://github.com/simonw/datasette/blob/09253817dea3c131553494f9b2eb9c03f94ae761/datasette/views/database.py#L27-L31
https://github.com/simonw/datasette/blob/07e208cc6d9e901b87552c1be2854c220b3f9b6d/datasette/views/table.py#L224-L227
So I removed the name = "query" line since it was misleading.


Mustang library without included dependencies

Is it possible to offer the Mustang library without the included dependencies in the repository. The dependencies should be defined in the included pom.xml.
I am using the library in my environment and there are problems with jaxb. The integration of the library is done with Gradle. In case of version conflicts it resolves gradle. Currently this doesn't work, because all dependencies have been packed into Mustang.jar.

Feel free to let me know how this could be done, I don't have any idea, I can only say that I manually deploy the unshadowed copy e.g. to http://www.mustangproject.org/deploy/original-mustang-1.6.0.jar

Hello,
could you please offer version 1.7.6 for download at http://www.mustangproject.org/deploy/original-mustang-1.7.6.jar


Jars turn into potions when banked

Rarely a "Jar" item spawns in the game, containing a menacing yellow liquid
Putting this jar into the bank turns it into a normal potion. It should probably stay as a jar.
Probably related to alchemist flasks reverting to standard flasks.

More of an issue now that in the beta, alchemist flasks are obviously different but they too still turn into normal flasks.

Also we need to look into allowing other items

@tehkab Can we rename this? or should I create a separate issue?


Add ADOPTERS file

Signed-off-by: davidmirror-ops<EMAIL_ADDRESS>What this PR does / why we need it: This PR will add an ADOPTERS file to showcase Octant adopters
Which issue(s) this PR fixes

Fixes #

Special notes for your reviewer:
Release note:
release-note

Latest commit is a revised and condensed version of the ADOPTERS file text. If it's approved, it will be used as the baseline to start adding content to it.


fix(shim): better error message for missing go bin

@tknickman fyi, I think this broke integration tests. We can catch these once we get https://github.com/vercel/turbo/pull/3442 merged! The log lines in the integration tests don't match any more


Cannot update challenge data

I've set chalenge using overpass query that selects objects missing specific tag.
It keeps leading to edit objects that are fixed externally.
There should be an option to refresh challenge data so that those fixed externally are not offered for editing.

Thanks for reporting @pedjas.  I'm having trouble following if this is a feature request or a bug?  If it's a bug, can you provide steps to reproduce?  Thank you!

It is more a feature request.

@pedjas you can do this using the "Rebuild Tasks" button in your Challenge admin screen. See also https://learn.maproulette.org/documentation/rebuilding-challenge-tasks/#content


Add /get_attestations monitoring to metadata-crawler

/get_attestations being available is required for the 8-digit code feature to work. Some AS operators may mistakenly block this endpoint behind a firewall. Add a rule to check this in the metadata-crawler to monitor for 404's going forward.

Just investigate this for now

@eelanagaraj do you know if this is still relevant?

@alecps it could be nice but not necessarily worth the effort at this point IMO. We would see validators failing with low attestation completion rates. For new validators, this is documented as a route that needs to be publicly exposed. I'll close it for now and we can always reopen if this becomes an issue in the future.


[WIP-Local] Catering to all possible routes for Post Request

Signed-off-by: deepanshuagarwal<EMAIL_ADDRESS>Description
Please explain the changes you've made
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:

[ ] Code compiles correctly
[ ] Created/updated tests
[ ] Extended the documentation

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@36763ea). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master       #1   +/-   ##
=========================================
  Coverage          ?   78.90%
  Complexity        ?     1006
=========================================
  Files             ?       87
  Lines             ?     3110
  Branches          ?      358
=========================================
  Hits              ?     2454
  Misses            ?      483
  Partials          ?      173

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36763ea...2c143d4. Read the comment docs.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@36763ea). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master       #1   +/-   ##
=========================================
  Coverage          ?   78.90%
  Complexity        ?     1006
=========================================
  Files             ?       87
  Lines             ?     3110
  Branches          ?      358
=========================================
  Hits              ?     2454
  Misses            ?      483
  Partials          ?      173

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36763ea...2c143d4. Read the comment docs.

Seems I have messed up in order to put sign-off line to a previous commit

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@b7e41a0). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master       #1   +/-   ##
=========================================
  Coverage          ?   78.96%
  Complexity        ?     1007
=========================================
  Files             ?       86
  Lines             ?     3109
  Branches          ?      358
=========================================
  Hits              ?     2455
  Misses            ?      481
  Partials          ?      173

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7e41a0...76f49eb. Read the comment docs.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@b7e41a0). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master       #1   +/-   ##
=========================================
  Coverage          ?   77.98%
  Complexity        ?     1105
=========================================
  Files             ?       97
  Lines             ?     3407
  Branches          ?      394
=========================================
  Hits              ?     2657
  Misses            ?      550
  Partials          ?      200

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7e41a0...cee4dd2. Read the comment docs.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@b7e41a0). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master       #1   +/-   ##
=========================================
  Coverage          ?   77.98%
  Complexity        ?     1105
=========================================
  Files             ?       97
  Lines             ?     3407
  Branches          ?      394
=========================================
  Hits              ?     2657
  Misses            ?      550
  Partials          ?      200

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7e41a0...cee4dd2. Read the comment docs.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@b7e41a0). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master       #1   +/-   ##
=========================================
  Coverage          ?   78.10%
  Complexity        ?     1106
=========================================
  Files             ?       97
  Lines             ?     3407
  Branches          ?      394
=========================================
  Hits              ?     2661
  Misses            ?      547
  Partials          ?      199

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7e41a0...cee4dd2. Read the comment docs.


Fix typo keg-only to key-only

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.
[ ] Have you successfully run brew style with your changes locally?
[ ] Have you successfully run brew tests with your changes locally?

I notice a possible typo in the documentation.

That's not a typo.

Sorry. Just figure it out.


Add option on takeover function in Browser extension for current website.

Add option on takeover function in Browser extension for current website.
For example, Enable or disable takeover.
because someone may not use AB download manager to download, or some websites prohibit using download tools to download.

Just like IDM, the downloader is disabled when you press Delete


Update README.md

Fixed some grammar mistakes and the "latest" mistake in the first paragraph

Good job. Could you please change the pull request target into the dev (i.e dev - patch-1)

Alright, you did it a bit wrong that made it in the main branch, but it's okay, I'll fix it later then.

It's actually a bit interesting what I have done here because I somehow forgot about the "latest" mistake. However I just fixed it.
Excuse me also for merging into the wrong branch. What should I do next then?

It's actually a bit interesting what I have done here because I somehow forgot to fix the "latest" mistake. However I just fixed it. Excuse me also for merging into the wrong branch. What should I do next then?

Thanks for fixing it, I'll merge and fix the conflicts in the dev and main branches later.


Account APIs Throwing Internal Server Error

changed request and response params and their types along with minor service logics for create and update account apis


Inconsistency in heartbeat value in workflow wait for order

In the building the workflow part 1b, wait for order section (https://workshop.serverlesscoffee.com/1b-workflow/6-waitfororder.html) in instructions/content/1b-workflow/6-WaitForOrder/_index.en.md the workshop mention using a heartbeat timeout to 300 but the screenshot mention 900 (https://workshop.serverlesscoffee.com/images/se-mod1-wait4c.png).

Value should be correct now. Please reopen if you still encounter this issue