query/search support?

Hey, team. Really appreciate you guys work on this project.
Without it I can't migrate my existing Rails app into a SPA base on nodeJS.
Now I face a situation that I need to access query/search in the route object.
For example, I have an endpoint http://www.example.com/?foo=bar. Owing to the different query foo=bar or baz=quz I have to set different state into my template. Is it possible we have the parsed query as a default params in context object just like params?
Right now I use this library for parsing in client side, and access with req.query in server side. But I think it maybe cool if we pre-parsed it.
I can come with a PR if you buy this one.
thanks

import Router from 'universal-router'
import queryString from 'query-string'

const router = new UniversalRouter({
  path: '/user/:username',
  action(context) {
    console.log(context.path)   // => '/user/jhon'
    console.log(context.params) // => { username: 'jhon' }
    console.log(context.query)  // => { query: 'and', hash: '' }
    console.log(context.hash)   // => '#example'
    return /* ... */
  }
})

// location = 'http://example.com/user/jhon?query=and&hash#example'
router.resolve({
  path: location.pathname,
  query: queryString.parse(location.search), // <=== pass query params here
  hash: location.hash
}).then(render)

Demo: https://jsfiddle.net/frenzzy/g7ymd7ho/

@frenzzy Thanks for the demo.


Add static option

Fixes #17

@sgrif bump

another bump?

As in "what does this PR do"? :thinking:

As in "what does this PR do"?

As in something user can find and read. So mostly adding the relevant environment variables at least to the crates readme.

I don't know if the PR author can read these messages 😅 if no response is given I can open another PR using their changes + documentation.

Closed as this was implemented as part of #40


Upload no works!!!

I am no longer able to upload files, have there been any updates that can influence this?
my filemanager version 1.8
my php version 5.6
my laravel version 5.4

Please comment here if the problem still occurs in the latest version.


Supply predictable API access token

tfc_web needs access to an API access token, but to make secret management practical this needs to be the same on each TFC server. This token also needs to be associated with a 'service' user so it doesn't get invalidated if a normal user account is deleted.

Closed by 95b0dd6a


carpe_1.0.0_x64-setup.exe give me empty window on windows 11

🐛 Bug
After install carpe_1.0.0_x64-setup.exe on my windows 11 64 bit I get empty windows
carpe.log contains only :
19:10:40 [WARN] Carpe starting
I had version 0.5 installed previously

carpe_1.0.0_x64-setup.exe version 21/01/2024
Windows 11 Professionel

I specify that I had disconnected my antivirus for the installation to be sure not to have a detection problem

@philobbe try latest canary, this issue is resolved.
https://github.com/0LNetworkCommunity/carpe/releases/tag/v1.0.0-17-canary

hi, same problem with regular 1.0.0 and 1.0.17 canary
Firewall down
Antivirus down
Both app autorized in firewall

same problem!

@imashowman https://github.com/0LNetworkCommunity/carpe/releases/tag/v1.0.0-17-canary try canary please and report back

@imashowman https://github.com/0LNetworkCommunity/carpe/releases/tag/v1.0.0-17-canary try canary please and report back

same issue...

@imashowman alright, I will test few fixes in the evening.
so its latest Win 11 with all official updates right?

@imashowman alright, I will test few fixes in the evening.
so its latest Win 11 with all official updates right?

yes

@imashowman alright, I will test few fixes in the evening.
so its latest Win 11 with all official updates right?

yes

@imashowman alright, I will test few fixes in the evening.
so its latest Win 11 with all official updates right?

same issue in 2 pcs, carpe 0.5 was running before i uninstalled

This is clean install win11, I'm not sure whats different with the machines You are running on

dont know.. i only have this on carpe.log

      This is clean install win11, I'm not sure whats different with the machines You are running on

Hmm, yeal I'll try to see if I can figure out the bug for the windows build

I got the same issue, canary version does not work either.

Windows 11 pro 23h2 (Windows Feature Experience Pack 1000.22681.1000.0) installed 2 months ago, tried windows compatibility mode for the executable, does not work
Webview2 already installed on my machine, tried to repair installation, does not work
Antivirus: Bitdefender Antivirus Plus, tried to make exception on the executable, does not work
Tried computer restart after all of that, not working either

I have the same issue : white screen after installing Carpe.
Here are my tests :

MicrosoftEdgeWebview2Setup.exe was installed before and I could not reinstall it, Edge message said "Installation failed. Microsoft Edge Webview2 Runtime is already installed on the system."
I tried installation with my VPN on Switzerland, then Singapore, then Montreal Canada, then Miami USA. Each time reinstalling.
Then (still with VPN in USA) I uninstalled Capre entirely with Windows unistallation tools and I installed it again with version carpe_1.0.0_x64-setup.exe
Then I uninstalled again and I installed again version carpe_1.0.0_x64_en-US.msi
...I had the white screen at Carpe opening during each of my tests.
In this white screen I have only 2 items in the menu : Carpe (only one choice : Exit) and Edit (4 choices : Cut Copy Paste SelectAll)
Many thanks in advance for your help :-)

This topic might help devs: https://github.com/MicrosoftEdge/WebView2Feedback/issues/3191
Last message states the following:
We experience this issue as well. For us, we noticed it was happening whenever we were showing a MessageBox while the WebView2 was initializing. If we suppress the message box, it seems to start. Otherwise we get the blank view. If we kill and restart the web view, it starts working.

Some updates: a french user in Discord found out that changing the default locale to English fixed the blank display issue. Could you try to set the locale to English?

Changing local to English (United States) works !
Step to quick fix until steps to fix the problem while awaiting a possible patch :

Go to parameters
"Heure et langue" / "Time and language" (or something like this)
"Langue et région" / "Language and area" (or something like this)
On : "Langues préférées" / "Preferred language" -> click on : "Ajouter une langue" / "Add language"
Select English (United States) -> "Suivant" / "Next" -> tick all optional language features -> install
Wait until the pack is installed
Back to "Heure et langue" / "Time and language" - "Langue et région" / "Language and area" -> on "Langue d'affichage de Windows" / "Windows display language" -> select English (United States)
Log out
Open again CARPE and voilà !

!! Keyboard is now in qwerty so you can quickly change your keyboard language by hitting alt + shift or in the bottom right-hand corner of the task bar, change the language by clicking on "ENG" and change to "FRA" (or your language if different from FRA) !!
!! Your default language
e may now be English when you start your PC. Don't panic, go back to Settings -> "Time and language" - "Language and area" drag your language above English in the section just below "Preferred languages" and change "Windows display language" back to French (or your language). Reboot !!

I love the engagement. We will scramble asap to fix this :)

Some updates: a french user in Discord found out that changing the default locale to English fixed the blank display issue. Could you try to set the locale to English?

French locale here too. Switched to English/US locale and it's working like a charm.

Alright guys, we've located the issue and written a function to override the i18n pack, causing the white screen and hanging parts of the wallet. Can you guys please download the latest version here:
https://github.com/0LNetworkCommunity/carpe/releases/tag/v1.0.0-18-canary
Import your wallet, update the playlist and restart the app. I've stress tested the wallet in windows 11 and we have had good feedback from windows 10 as well as Mac OS users. If I hear nothing further I will assume we're good and close your ticket =)

Closing as issue is pin pointed


Windows move when ShowTitleBar="False"  and SimpleDialog is open

please disable main window draq while SimpleDialog is open it's suppose to be a modal dialog i am not ?

@jcadiba it's now possible to set IsWindowDraggable (latest alpha version)

Thanks guys ! I'll try it.


fix: added pnpm format:fix in pre-commit hook

As suggested in this comment, pnpm format:fix has been added to husky pre-commit hook to avoid running it manually.

Linked CONTRIBUTING.md in README.md and added fork as first step instead of clone

@aarontravass yes that's a good idea

done

wait why do we need 16.12+? what tool require it?

wait why do we need 16.12+? what tool require it?

isn't it better to move to a newer version of node? security + performance?

wait why do we need 16.12+? what tool require it?

isn't it better to move to a newer version of node? security + performance?

the "engine" field doesn't move your tools to a newer version, it requires you to use a newer version. The project  runs with no issue on 12.4+ so I'm not sure why an update is needed

wait why do we need 16.12+? what tool require it?

isn't it better to move to a newer version of node? security + performance?

the "engine" field doesn't move your tools to a newer version, it requires you to use a newer version. The project runs with no issue on 12.4+ so I'm not sure why an update is needed

reverted the versions in package.json

wait why do we need 16.12+? what tool require it?

isn't it better to move to a newer version of node? security + performance?

the "engine" field doesn't move your tools to a newer version, it requires you to use a newer version. The project runs with no issue on 12.4+ so I'm not sure why an update is needed

reverted the versions in package.json

@aarontravass there's a merge conflict

@aarontravass there's a merge conflict

oops, i missed it. just merged it


The CGME seems to be "crashing" the music with intro and loop components after the restart

If you load the music with intro and loop components and then restart the mission, this music will disappear. Video and log are below.
LogOutput.log
Video (expires after 3 months or after a download)

Thank you for the report, I'll take a look


Grammar fixes for better readability.

I found a few grammar errors in the copy activity schema and type mapping documentation and figured I'd add some fixes.

@jasonmerino thanks for contributing to the doc! Looks good to me.
#sign-off


Update from team repo

Codecov Report

Merging #65 (c08523f) into master (9e8d57a) will increase coverage by 1.53%.
The diff coverage is 75.00%.

@@             Coverage Diff              @@
##             master      #65      +/-   ##
============================================
+ Coverage     69.41%   70.94%   +1.53%
- Complexity     1554     1587      +33
============================================
  Files           236      236
  Lines          5284     5287       +3
  Branches        710      710
============================================
+ Hits           3668     3751      +83
+ Misses         1305     1224      -81
- Partials        311      312       +1

Impacted Files
Coverage Δ
Complexity Δ

src/main/java/seedu/address/MainApp.java
0.00% <0.00%> (ø)
0.00 <0.00> (ø)

...main/java/seedu/address/commons/core/Messages.java
0.00% <ø> (ø)
0.00 <0.00> (ø)

...c/main/java/seedu/address/logic/ParserManager.java
47.61% <0.00%> (+47.61%)
5.00 <0.00> (+5.00)

...nds/gradetrackercommands/AddAssignmentCommand.java
94.44% <100.00%> (+0.15%)
12.00 <0.00> (ø)

...commands/gradetrackercommands/AddGradeCommand.java
100.00% <100.00%> (ø)
11.00 <0.00> (ø)

.../gradetrackercommands/DeleteAssignmentCommand.java
96.96% <100.00%> (+0.09%)
12.00 <0.00> (ø)

...rc/main/java/seedu/address/model/ModelManager.java
65.68% <0.00%> (+0.73%)
63.00% <0.00%> (+1.00%)

...main/java/seedu/address/model/contact/Contact.java
80.00% <0.00%> (+2.00%)
22.00% <0.00%> (+1.00%)

...ain/java/seedu/address/storage/StorageManager.java
82.14% <0.00%> (+12.50%)
22.00% <0.00%> (+3.00%)

...va/seedu/address/logic/parser/SchedulerParser.java
14.28% <0.00%> (+14.28%)
2.00% <0.00%> (+2.00%)

... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac9f9fe...c08523f. Read the comment docs.


[connext_dynamic] finish support for wait_for_service

Currently local changes to publishers and subscriptions are reflected in Connext dynamic, but not local changes to service clients and service servers, and so rmw_service_server_is_available() is still disabled for Connext dynamic (but not for Connext static):
https://github.com/ros2/rmw_connext/blob/8ad74fb18647fb39a7866c70984411b1b1dbb2d8/rmw_connext_dynamic_cpp/src/functions.cpp#L2333-L2335
This can be considered follow on work from: https://github.com/ros2/rmw_connext/issues/168

Tests that are disabled because of this: https://github.com/ros2/rcl/commit/596c0ec9faaa81cb4ba9dc064c27ba340412c023#diff-e4167ceebe2946426e927f55e4392af4R65

Closing, since with Foxy now being End-of-Life, this repository is no longer used.


fix: fix broken link to add correct base url

Fix broken link after refactor, add base url.

:tada: This PR is included in version 2.15.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


style[FX-3169]: Update feature page style

Ticket
This PR updates the feature page with the latest style from Figma
DESKTOP
Before:
https://user-images.githubusercontent.com/15792853/135229739-f98738b2-b37f-40ec-91de-a8700814ae00.mov
After:
https://user-images.githubusercontent.com/15792853/135231104-d51ccf2d-d7b4-4453-b000-615d81911722.mov
MOBILE
Before:
https://user-images.githubusercontent.com/15792853/135231215-3e820b04-9612-4e76-9627-48736eaad6c5.mov
After:
https://user-images.githubusercontent.com/15792853/135231234-d4c97d98-970c-4510-bf3e-37e7768e740d.mov

Would also Q/A with a few other features. They sometimes vary dramatically.

Would also Q/A with a few other features. They sometimes vary dramatically.

Thanks a lot for the review @dzucconi , sorry about missing v3 variants and using the v2, I'm aware now 🙂
Regarding the QA, Jonathan did one big yesterday with other features before I opened it to QA, this blue text on hover for example he asked to implement it. In any case after the CR we'll pass again through QA because we don't have designs for all pages, and one specific FeatureSet type we are not using, Artist, so we can't implement one of the Design's idea 😞

this blue text on hover for example he asked to implement it

We're just going to do that globally for the Text component, unless there winds up being any weird side-effects to such a sweeping change.

We're just going to do that globally for the Text component, unless there winds up being any weird side-effects to such a sweeping change.

Humm so will default on Palette, how de we do in this case when a sibling has hovered and the Text color should change?

Humm so will default on Palette, how de we do in this case when a sibling has hovered and the Text color should change?

Ah it's probably the case that what I'm saying isn't really relevant for your use case. It's hard to tell from the code/screenshots. So just do whatever you think is best. So long as the only thing that's triggering a hover is a valid anchor tag hit area, you're good.

@araujobarret - when this is ready for final review, be sure to use the assignee field to assign to someone; that person has ultimate authority over approving / merging the PR. Check out these docs for a bit more info.


Add eliot logging for ssh commands run by _sshconfig.py

make it possible to debug failures by exposing all of the ssh commands we run and their output and exit status

We are moving our development planning to JIRA. This issue is now being tracked at https://clusterhq.atlassian.net/browse/FLOC-192. You are welcome to file additional issues in GitHub if that's easier for you.


Kubernetes dashboard is not accessible from web portal

Caused by incorrect K8S_DASHBOARD_URI

https://github.com/Microsoft/pai/blob/pai-0.10.y/src/webportal/config/webportal.py#L62


Cannot build tensorflow from source, Ubuntu 16.04

uname
Linux olympus 4.15.0-36-generic #39~16.04.1-Ubuntu SMP Tue Sep 25 08:59:23 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
CUDA 10
Trying to run ./configure to build tensorflow for cuda 10 but it doesn't work. bazel is complaining about many things..
The function 'set' has been removed in favor of 'depset', please use the latter. You can temporarily refer to the old 'set' constructor from unexecuted code by using --incompatible_disallow_uncalled_set_constructor=false
ERROR: error loading package '': Extension 'closure/filegroup_external.bzl' has errors
What are the exact steps to build successfully from source for linux?

I apologize, but I am having a hard time understanding what the problem is, where the problem is, and what version it affects. Please resubmit and pay attention to the [issue template] (https://github.com/tensorflow/tensorflow/issues/new/choose). Please provide all the information it asks. Thank you.


Fix Python lint

Fixes beam_PreCommit_PythonLint_Cron
R: @nehsyc
R: @pabloem
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

oops sorry about the trouble, and thanks for the fix! I'll merge as soon as tests pass


dune-project is missing

I'm trying to install the latest version of Clap pinned to git master: opam pin add --dev-repo clap.
Currently, this is not possible, because dune-project file is missing and explicitly added to .gitignore.
So I get the following error:
<><> Synchronising pinned packages ><><><><><><><><><><><><><><><><><><><><><><>
[clap.0.1.0] no changes from git+https://github.com/rbardou/clap.git

The following actions will be performed:
  ∗ install clap 0.1.0*
[clap.0.1.0] synchronised from git+https://github.com/rbardou/clap.git

<><> Processing actions <><><><><><><><><><><><><><><><><><><><><><><><><><><><>
[ERROR] The compilation of clap failed at "C:\\OCaml64\\home\\jbz\\.opam\\4.11.1+mingw64c\\bin\\dune.exe subst".

#=== ERROR while compiling clap.0.1.0 =========================================#
# context     2.0.7 | win32/x86_64 | ocaml-variants.4.11.1+mingw64c | pinned(git+https://github.com/rbardou/clap.git#064ca69f)
# path        ~/.opam/4.11.1+mingw64c/.opam-switch/build/clap.0.1.0
# command     C:\OCaml64\home\jbz\.opam\4.11.1+mingw64c\bin\dune.exe subst
# exit-code   1
# env-file    ~/.opam/log/clap-10764-e7966f.env
# output-file ~/.opam/log/clap-10764-e7966f.out
### output ###
# Error: dune-project: No such file or directory

<><> Error report <><><><><><><><><><><><><><><><><><><><><><><><><><><><><><><>
┌─ The following actions failed
│ λ build clap 0.1.0
└─
╶─ No changes have been performed

Could you please add a dune-project file to git?
It would be enough to have something simple like:
(lang dune 2.9)
(name clap)

The problem with tagged 0.0.1 version is that it doesn't work on Windows when running from Powershell or cmd.exe. This is related with handling TERM variable here:
Uncaught exception:

  Not_found

Raised by primitive operation at Ppx_bench_lib__Benchmark_accumulator.add_environment_var in file "runtime-lib/benchmark_accumulator.ml", line 84, characters 8-38
Called from Ppx_bench_lib__Benchmark_accumulator.force_drop in file "runtime-lib/benchmark_accumulator.ml", line 104, characters 14-43
Called from Ppx_inline_test_lib__Runtime.Action.force_drop in file "runtime-lib/runtime.ml", line 109, characters 16-51
Called from Ppx_inline_test_lib__Runtime.am_running_inline_test in file "runtime-lib/runtime.ml", line 321, characters 8-63
Called from Ppx_inline_test_lib__Runtime.am_running_inline_test in file "runtime-lib/runtime.ml", line 324, characters 10-51
Called from Ppx_module_timer_runtime.get_am_recording_environment_variable in file "runtime/ppx_module_timer_runtime.ml", line 10, characters 8-57
Called from Core_kernel__Import.am_running_test in file "src/import.ml", line 96, characters 12-47
Called from Clap.help in file "src/clap.ml", line 524, characters 41-58
Called from Dune__exe__Iec_checker in file "src/bin/iec_checker.ml", line 176, characters 4-16

But it works well on the current master.
Therefore, another solution could be to tag the current master as 0.0.2 and publish it to opam.

Thanks for the report!
I have added dune-project to the repository, and I have released a new version. It should be available to install with Opam soon: https://github.com/ocaml/opam-repository/pull/20969

Thank you! It seems that everything works now.


Update data-science-and-machine-learning.md

Fixing the link. cc: @rastala

@j-martens : Thanks for your contribution! The author, @MikeWasson, has been notified to review your proposed change.

Hi @j-martens - I've manually tested this and the link still isn't working (although this really should be submitted to the private repo so that validation would have caught it).  I think the reason it's not working is because it's a relative link cross-repo... but I'm not sure.
Can you submit this to the private repo architecture-center-pr instead? That way we can using validation and staging to assess this?
Thanks.

HI @Jak-MS - I didn't have permissions to the repo so i went the public route.

Hi @j-martens - oh, i see. Sorry, I thought you'd have permissions.
I can merge the PR and you or @MikeWasson can check to see if it's working after it goes live. (sometimes relative links work in the live articles even they don't in the GitHub view). If it still doesn't work, I'd recommend that @MikeWasson change it in the private repo.
Thanks.


Provide stacktraces in hover events (with a click event to copy to clipboard) for unknown command errors.

I'd like to see something like what Sponge has (SpongePowered/SpongeAPI@04f11fb) to show stacktraces on hover for platforms where we have access to rich text -- it makes it a little nicer to see what's going on when unhandled errors happen. Thoughts?

Added to the default CommandExecutionException handler for minecraft-extras (which uses adventure) in https://github.com/Incendo/cloud/commit/7c1dff17819c3f3fb4f164f529c6700dbc994886
Leaving this issue open in case we want to also do something similar for platforms like bungee and fabric where we have access to a rich text API that isn't adventure.

Leaving this issue open in case we want to also do something similar for platforms like bungee and fabric where we have access to a rich text API that isn't adventure.

Closing this one now as it has been open for a year and a half without further attention. Feel free to re-open or open a new issue for a specific platform if this is still relevant.


Create controller routes for the Script model

Applied a feature to only allow the deletion of non-purchased scripts. This will prevent writers from deleting their posted scripts after being purchased by an agent.
The change can be found in PR #26 commit fee378682330dc39a3900448a83e04c3ae5846b6

Include the author and assignedTo user's information instead of only just their ID when returning the script data

Added author and assignedTo information in PR #50


Coordinates not deep copy

What happened?
The coordinates are not copied if you perform deepcopy for xarray.
This issue was fixed before. I don't see it, for example, in xarray 2022.12.0, but in the latest version the issue is there again.
import xarray as xr

xarr1 = xr.DataArray(
    np.zeros([2]),
    coords=dict(x=[0.0, 1.0]), # important to use 'float' here! with 'int' it is working fine
    dims=("x")
)
print(xarr1.x.data[0]) # 0.0

xarr2 = xarr1.copy(deep=True)
xarr2.x.data[0] = 45
print(xarr1.x.data[0]) # gives 45

Interesting, that if your coordinates are int, then the issue is gone
What did you expect to happen?
import xarray as xr

xarr1 = xr.DataArray(
    np.zeros([2]),
    coords=dict(x=[0.0, 1.0]), # important to use 'float' here! with 'int' it is working fine
    dims=("x")
)
print(xarr1.x.data[0]) # 0.0

xarr2 = xarr1.copy(deep=True)
xarr2.x.data[0] = 45
print(xarr1.x.data[0]) # I expect it to be 0.0

Minimal Complete Verifiable Example
import xarray as xr

xarr1 = xr.DataArray(
    np.zeros([2]),
    coords=dict(x=[0.0, 1.0]), # important to use 'float' here! with 'int' it is working fine
    dims=("x")
)
print(xarr1.x.data[0]) # 0.0

xarr2 = xarr1.copy(deep=True)
xarr2.x.data[0] = 45
print(xarr1.x.data[0]) # gives 45

MVCE confirmation

[X] Minimal example — the example is as focused as reasonably possible to demonstrate the underlying issue in xarray.
[X] Complete example — the example is self-contained, including all data and the text of any traceback.
[X] Verifiable example — the example copy & pastes into an IPython prompt or Binder notebook, returning the result.
[X] New issue — a search of GitHub Issues suggests this is not a duplicate.

Relevant log output
No response
Anything else we need to know?
No response
Environment

xarray 2023.1.0
python 3.8.10

It seems that in copy IndexVariables are treated special and are explicitly excluded from copying.
@benbovy what was the reasoning behind this choice?

I think that the reverting change in IndexVariable came after refactoring copy in Xarray introduced some performance regression (https://github.com/pydata/xarray/pull/7209#issuecomment-1305593478).
I didn't see #1463 (https://github.com/pydata/xarray/issues/1463#issuecomment-340454702), though. It feels weird to me that we can mutate an IndexVariable via its data property, considering that the underlying index is immutable. IIUC xarr2.x.data[0] = 45 replaces the full index with a new one? I'm not sure if it is a good idea to allow this. For a pandas index that's probably OK (it is reasonably cheap to rebuild a new index) but for a custom index that is expensive to build (e.g., kd-tree) I don't think this behavior is desirable.

I didn't see #1463 (#1463 (comment)), though. It feels weird to me that we can mutate an IndexVariable via its data property, considering that the underlying index is immutable. IIUC xarr2.x.data[0] = 45 replaces the full index with a new one? I'm not sure if it is a good idea to allow this. For a pandas index that's probably OK (it is reasonably cheap to rebuild a new index) but for a custom index that is expensive to build (e.g., kd-tree) I don't think this behavior is desirable.

should we then raise an error if someone tries to replace values in an index?

Yes I think we should, but I might have missed the rationale behind allowing it if this is intentional.

Yes I think we should, but I might have missed the rationale behind allowing it if this is intentional.
EDIT: perhaps better to issue a warning first to avoid some breaking change. We could also try to fix it (make a deep copy) at the same time as deprecating it, but that might be tricky without again introducing performance regressions.

I would assume that deepcopy are completely going to copy the object, so if I change internal parts (like coordinates here), 1st object shall not change. It definitely affects the performance, but otherwise deepcopy is not deep anymore

There are two issues:

whether we should continue allowing IndexVariable data be updated in place via .data property. IMO we should really deprecate it, especially that now it is possible to have custom, possibly expensive index structures built from one or more coordinates.

whether deep=True should deep copy the Xarray index objects. I don't have strong opinion on this. There is a similar discussion on the pandas side: https://github.com/pandas-dev/pandas/issues/19862. I wonder if we reverted the change here because some high-level operation(s) in Xarray was by default deep copying the indexes? I don't think we would want such behavior unless the user explicitly sets deep=True somewhere?

whether we should continue allowing IndexVariable data be updated in place via .data property. IMO we should really deprecate it

I agree. We don't allow it on .values anyway for this reason.
Now I see we already did this in https://github.com/pydata/xarray/pull/3862/files So I guess that got lost in the indexes refactor.

whether deep=True should deep copy the Xarray index objects

I would expect deep=True to deep-copy absolutely everything. That said if the Index objects are immutable then it doesn't matter?
On that pandas thread I see:

discovered that even if the id of the index was different on the copy, modifying the cp.index.to_numpy() values was corrupting the original.

Seems like we should all be setting the numpy data to be read-only with array.flags.WRITEABLE = False

Hi, I am hitting the similar issue, and curious if there any plan for this issue. I think when deep=True, reasonable expectation is everything is going to be deep copied, regardless of coordinate or data variable. This seems like a long standing issue (e.g., https://groups.google.com/g/xarray/c/ksMI8TmRPaA?pli=1).

If there are difficulties or ambiguities here, would it be reasonable to switch to deep-copying everything for the moment?
If we can figure out optimizations on things that are definitely immutable, then great, but in the meantime any objections to defaulting to the slower-but-always-correct thing?

I don't hear anyone clamoring to retain skipping indexes from deep copy. Would anyone like to do a PR to include them in deep copy, and we'll plan to merge that unless anyone comes up with a thought-through objection?


Screenshots or Gifs

Hi @marcin212! This looks cool :)
Mind adding a screenshot or a gif of the UI? I would love to see how it looks without having to install a windows vm :) Thanks!

Thank you @marcin212 :) I like where this is going!


mitm feature

Holpful feature of mitm like google/martian.

This feature is not the purpose of this program, but it may be supported in the future.


Update modelAsString to true for Frondoor APIs 2020-01-01 and 2020-05-01

Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Contribution checklist:

[x] I have reviewed the documentation for the workflow.
[x] Validation tools were run on swagger spec(s) and have all been fixed in this PR.
[x] The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

[ ] Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

[ ] If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

/azp run automation - sdk

This PR changes the modelAsString property for the PrviateEndpointStatus field to true. This field is not currently being used in either APIs, so it wouldn't break either.

Can one of the admins verify this patch?


Home Assistant 2023.5.2, unable to connect

Unable to connect starting with HA Version 2023.5.2. Right after the most recent update, I've noticed that the Roomba entities are no longer available, and the integration isn't running. "Retrying setup" There are several errors in the logs, related to this.
Roomba i7+
Product Software: 22.52.5
Product Software Updated: March 31 2023
----------------------------------------ERROR---------------------------------------------
Logger: roombapy.remote_client
Source: /usr/local/lib/python3.10/site-packages/roombapy/remote_client.py:77
First occurred: May 8, 2023 at 2:06:40 PM (1172 occurrences)
Last logged: 4:04:07 PM
Unable to connect to 10.xx.xx.xx7
---------------------------------------ERROR---------------------------------------------------
Logger: roombapy.remote_client
Source: /usr/local/lib/python3.10/site-packages/roombapy/remote_client.py:72
First occurred: May 8, 2023 at 2:06:28 PM (3518 occurrences)
Last logged: 4:04:07 PM
Can't connect to 10.xx.xx.xx7, error: timed out
Can't connect to 10.xx.xx.xx7, error: [Errno 111] Connection refused
Can't connect to 10.xx.xx.xx7, error: [Errno 113] Host is unreachable
--------------------------------------WARNING----------------------------------------------------
Logger: roombapy.roomba
Source: /usr/local/lib/python3.10/site-packages/roombapy/roomba.py:166
First occurred: May 8, 2023 at 2:26:44 PM (2 occurrences)
Last logged: May 8, 2023 at 2:26:44 PM
Unexpectedly disconnected from Roomba <IP_ADDRESS>, code UNKNOWN_ERROR
------------------------------------------WARNING-----------------------------------------------
Logger: roombapy.remote_client
Source: /usr/local/lib/python3.10/site-packages/roombapy/remote_client.py:135
First occurred: May 8, 2023 at 2:26:44 PM (2 occurrences)
Last logged: May 8, 2023 at 2:26:44 PM
Unknown disconnection error: ID=16.Kindly use https://github.com/pschmitt/roombapy/issues/new
Any help appreciated.
Home Assistant 2023.5.2
Supervisor 2023.04.1
Operating System 10.1
Frontend 20230503.2 - latest

Duplicate of #130

No, it's not. In this case, the integration does not work.

I dismiss duplicate issues.


[Discussion] Remove Intellij IDEA specific files from project

I think it will be better to:

remove ".idea" folder and ".iml"-file
update .gitignore file
update CONTRIBUTING.md

For Maven projects is completely unnecessary. Code style configuration (and other IDEA-specific files) could be placed in the some new folder like "misc" or "misc/IDEA".

problem is with keeping the files the formatter will be used automatically since it is project default. If we'll have this seperated the developer has to set the formatter on it's own.
This can be somehow dangerous since we don't have an automated checkstyle configuration (before this is possible we need all violations to be fixed) to see if the PR matches our formatting criterias.
I have seen an intelliJ maven plugin but this one is outdated but maybe you have some other ideas?

Just to share my experience:
In all my projects I use maven-checkstyle-plugin without any IDE formatters, so I can check my code and code of other people on CI server (instead of manual code review). Automatic analysis tools looks better in this case.

I want to add some other thoughts about this task. In the current situation files .idea/codeStyleSettings.xml and .idea/misc.xml are tracked by Git and Intellij Idea:
Idea IDE usually wins the war and changes this files in someway. After that Git finds the untracked changes and there is a problem: we have a dirty working branch (unstaged changes), so we have to do something like in the command-line:

git checkout .idea/codeStyleSettings.xml and git checkout .idea/misc.xml
or just git checkout .idea

As result, it is uncomfortable to work with Git branches in the terminal.

Currently, we're following the guidelines from the JetBrains docs.
It's true that IntelliJ sometimes alters some of the files checked in, which is annoying. But I think  .idea/codeStyleSettings.xml is not one of them, unless you make changes to the code style settings yourself.
Using a tool (Maven plugin?) to generate a project config could be a solution. I know such a plugin exists for Gradle, but I don't know about Maven.

In my environment .idea/codeStyleSettings.xml and .idea/misc.xml are changed each time when I work with ews-java-api. I think it could happens, because we have different versions of Intellij IDEA, and IDE converts some parameters (or add some new defaults).
Btw, Maven team also uses codestyles for Intellij Idea as separate configuration: http://maven.apache.org/developers/committer-environment.html
Download maven-idea-codestyle.xml and copy it to ~/.IntelliJIDEA/config/codestyles then restart IDEA. On Windows, try C:\Documents and Settings\<username>\.IntelliJIDEA\config\codestyles

After this, restart IDEA and open the settings to select the new code style.

maybe these changes occur because you dont just open the project on intelliJ? If you create or import a project this might happen.

I've just cloned git repo again and done a clean test: "File -> Open -> ... -> ews-java-api -> pom.xml" That's all.
Results:
New lines in .idea/codeStyleSettings.xml:
        <codeStyleSettings language="Groovy">
          <option name="KEEP_CONTROL_STATEMENT_IN_ONE_LINE" value="false" />
          <option name="PARENT_SETTINGS_INSTALLED" value="true" />
        </codeStyleSettings>
        <codeStyleSettings language="JavaScript">
          <option name="WRAP_COMMENTS" value="true" />
          <option name="PARENT_SETTINGS_INSTALLED" value="true" />
        </codeStyleSettings>
        <codeStyleSettings language="TypeScript">
          <option name="WRAP_COMMENTS" value="true" />
          <option name="PARENT_SETTINGS_INSTALLED" value="true" />
        </codeStyleSettings>

New line in .idea/misc.xml:
<component name="IdProvider" IDEtalkID="49369D9F2811625BADF7D0C400625C75" />

I guess we'll have to look at a decent solution using a build tool plugin which can generate the project config...

Is this a guess or do you have something in mind?

I though about it and I think we could just add the .idea folder and ews-java-api.iml to the .gitignore file. This will keep the files where they are, but updates to the files will be ignored by git. If we ever need to update these files again, they can still be added to the git index using git add -f <filename>.

Please increase priority of this ticket, it is really uncomfortable to work on project.

I thought about it and I think we could just add the .idea folder and ews-java-api.iml to the .gitignore file. This will keep the files where they are, but updates to the files will be ignored by git. If we ever need to update these files again, they can still be added to the git index using git add -f <filename>.

Turns out this won't work. If files have been added already, git keeps tracking changes in it, even if they are in the .gitignore file.

Turns out this won't work. If files have been added already, git keeps tracking changes to it, even if the file is in the .gitignore file.

Yes, I've just faced with it here https://github.com/OfficeDev/ews-java-api/issues/283

+1 for removing

+1 - please remove IDE specific files.
Here's a canonical gitignore for Jetbrains which ignores anything under .idea/
https://github.com/github/gitignore/blob/master/Global/JetBrains.gitignore

.gitignore file could be also generated using gitignore.io to prevent a lot of unnecessary files generated by Eclipse, Windows, OS X, Netbeans, IDEA, etc..

using .idea/* in gitignore works best for me

I had this issue and manages to resolve using the method described here


#42 Discover and load dependencies via composer only after having discovered all source symbols

Fixes #42
Fixes #47 (done it since I was touching composer.json anyway)

Also needs a rebase :tumbler_glass:

@asgrim rebased/fixed/etc - if you merge this I'll try focusing on bells and whistles this evening, to make this nice and shiny for :ship:


[Fix] OCLKind/PTXKind inconsistency in code gen

Description
This PR provides a patch that refactors the OCLKind and PTXKind to be resolved from the JavaKind. This includes a new method for each backend. This refactoring fixes the inconsistency between the two backends (OpenCL, PTX) regarding the LocalArrayNode, as mentioned in issue #89.
As it is shown in the under-review files, the refactored code of this patch fixes the generated GPU kernel that is required for the testVirtualDeviceKernel unit-test to use an array name f_2 instead of ul_2 (line 29) for the float local array.
Backend/s tested

[x] OpenCL
[x] PTX

OS tested

[x] Linux
[x] OSx
[x] Windows

Did you check on FPGAs?
If possible, check your changes on FPGAs.

[ ] Yes
[x] No

How to test the new patch?

The patch has been tested for both backends (OpenCL, PTX) and the benchmarks, as follows:

$ make jdk-11-plus
$ make tests
$ tornado-benchmarks.py --jmh --medium

You can run the following unit-test (but replace the paths, this unit-test assesses the change of the local array name)

$ tornado -ea -Dtornado.unittests.verbose=True -Xmx6g -Dtornado.recover.bailout=False  -Dtornado.device.desc=/home/thanos/repositories/tornado-stratika/bin/sdk/examples/virtual-device-GPU.json -Dtornado.print.kernel=True -Dtornado.virtual.device=True -Dtornado.print.kernel.dir=/home/thanos/repositories/tornado-stratika/bin/sdk/virtualKernelOut.out -m  tornado.unittests/uk.ac.manchester.tornado.unittests.tools.TornadoTestRunner  uk.ac.manchester.tornado.unittests.virtual.TestVirtualDeviceKernel#testVirtualDeviceKernelGPU

Thank you @stratika , LGTM.


Update wrangler and k8s.io dependencies

Update wrangler for newer CRD generation
Latest wrangler generates version apiextensions.k8s.io/v1 CRDs which are
compatible with kubernetes 1.22. Required minor adjustments in the
codegen package.

Remove unused CRD manifest

Update k8s.io dependencies to latest
crypto and protobuf dependencies are removed from go.mod as
they are included indirectly in the newer k8s.io modules.

https://github.com/rancher/rancher/issues/33621

Marking as draft since I think we don't want to accidentally put this in 2.6.0.


RuntimeError: Unknown child node [x:fileVersion] for element [workbook]

Betriebe_20160823.xlsx
With IRB (Ruby 2.3.1) I cannot parse this file.
irb(main):001:0> require 'rubyXL'
=> true
irb(main):002:0> workbook= RubyXL::Parser.parse 'Betriebe_20160823.xlsx'
RuntimeError: Unknown child node [x:fileVersion] for element [workbook]
from /home/niklaus/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/rubyXL-3.3.21/lib/rubyXL/objects/ooxml_object.rb:155:in block in parse'         from /home/niklaus/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/nokogiri-1.6.8/lib/nokogiri/xml/node_set.rb:187:inblock in each'
from /home/niklaus/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/nokogiri-1.6.8/lib/nokogiri/xml/node_set.rb:186:in upto'         from /home/niklaus/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/nokogiri-1.6.8/lib/nokogiri/xml/node_set.rb:186:ineach'
from /home/niklaus/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/rubyXL-3.3.21/lib/rubyXL/objects/ooxml_object.rb:144:in parse'         from /home/niklaus/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/rubyXL-3.3.21/lib/rubyXL/objects/ooxml_object.rb:440:inblock in parse_file'
from /home/niklaus/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/rubyzip-1.2.0/lib/zip/entry.rb:495:in get_input_stream'         from /home/niklaus/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/rubyXL-3.3.21/lib/rubyXL/objects/ooxml_object.rb:440:inparse_file'
from /home/niklaus/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/rubyXL-3.3.21/lib/rubyXL/objects/relationships.rb:91:in block in load_related_files'         from /home/niklaus/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/rubyXL-3.3.21/lib/rubyXL/objects/relationships.rb:76:ineach'
from /home/niklaus/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/rubyXL-3.3.21/lib/rubyXL/objects/relationships.rb:76:in load_related_files'         from /home/niklaus/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/rubyXL-3.3.21/lib/rubyXL/objects/relationships.rb:179:inload_relationships'
from /home/niklaus/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/rubyXL-3.3.21/lib/rubyXL/objects/root.rb:66:in parse_zip_file'         from /home/niklaus/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/rubyXL-3.3.21/lib/rubyXL/parser.rb:8:inblock in parse'
from /home/niklaus/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/rubyzip-1.2.0/lib/zip/file.rb:102:in open'         from /home/niklaus/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/rubyXL-3.3.21/lib/rubyXL/parser.rb:7:inparse'
from (irb):2
from /home/niklaus/.rbenv/versions/2.3.1/bin/irb:11:in `'

Hi Niklaus
I have the same problem here. Have you found a solution to this problem?
btw: wir kennen uns von früher (mindclue)...
Andy

@arohr do you have a sample file that exhibits this behavior?

@weshatheleopard Yes: Aggregates.xlsx

@arohr: the 3rd party software was generating the file that isn't exactly up to spec (but not terribly out of spec either). Update the gem and try again.


Move DiagrammedAssertions to diagrams.Diagrams for future modularization

This still needs work in the build for Scala.js and native. Closing.


Converting the Sharp/Node Duplex to web standard ReadableStream

Question about an existing feature
What are you trying to achieve?
I'm trying to convert a Sharp object as returned by sharp("...").webp() to a web standard ReadableStream<Uint8Array> for compatibility with Deno.serve() / new Response(body)
When you searched for similar issues, what did you find that might be related?
I have searched a lot, e.g. in the "issues" tab on this repo, but couldn't find any truly related issue. (Aside from #4013 maybe)
I managed to make it work with:

new ReadableStream: new ReadableStream({ start(controller) { sharpObject.on("data", chunk => controller.enqueue(chunk) } }) - but it's slightly slower than the classic sharpObject.pipe(res) you'd use with http.createServer or express
Readable.toWeb(sharpObject) - appears to pipe some image data, but the served image appears to be broken/blank and it's significantly slower (~3x) on a 20MB input file than .pipe(res) or the previous new ReadableStream option
(Note: toWeb was added in Node v17 and is still marked as experimental)
createReadableStreamFromReadable from @remix-run/node works but is ~3x as slow as .pipe(res). They also use their own new ReadableStream. This function can be used with import { createReadableStreamFromReadable } from "@remix-run/node" even when not using the Remix framework.

Somewhat related: Stackoverflow posts about the difference between web standard ReadableStream and Node Readable

https://stackoverflow.com/a/66629140/9948553
https://stackoverflow.com/q/37614649/9948553

Please provide a minimal, standalone code sample, without other dependencies, that demonstrates this question
const sharpObject = sharp("img.png").webp();
const readableStream: ReadableStream<Uint8Array> = sharpObject;
/**
 * TypeScript will already warn here that
 * ` 'Sharp' is missing the following properties from type 'ReadableStream<Uint8Array>' `,
 * which at runtime holds true as the `readableStream` variable doesn't work
 * with e.g. `new Response(readableStream)` in Deno
 */

Please provide sample image(s) that help explain this question
independent of image file

Readable.toWeb(sharpObject) - appears to pipe some image data, but the served image appears to be broken/blank

Use of toWeb is probably what I'd suggest people try first when converting. Are you able to provide a minimal code sample that allows someone else to reproduce the problem you ran into?

@lovell
This first example works both when run with Deno and with Node and has equal performance on average in my test case:
import http from "node:http";
import sharp from "sharp";

http
	.createServer((_req, res) => {
		const sharpObject = sharp("img.png").webp();
		sharpObject.pipe(res);
	})
	.listen(8000);

This second example only works in Deno and is about 1% slower on average when converting a large, 20MB file, only 1 request at a time, i did not test multiple concurrent requests yet. More importantly, the response appears to be incomplete. Chromium will log GET http://localhost:8000/ net::ERR_INCOMPLETE_CHUNKED_ENCODING 200 (OK) in the console and the bottom ~15% of the image appear as gray and Postman reports ~800KB response size vs. the 1MB response of the first example.
import sharp from "npm:sharp";
import { Readable } from "node:stream";

Deno.serve(() => {
	const sharpObject = sharp("img.png").webp();
	return new Response(Readable.toWeb(sharpObject) as ReadableStream);
});

This looks a bit like the problem reported at https://github.com/denoland/deno/issues/24606
If performance is of concern and memory is not a limiting factor, perhaps experiment with Buffers rather than Streams to avoid many small memory allocations.

I found that Deno issue too, but i'm not using Fresh or http2 (intentionally).
As for Buffers, i'm not aware that they can be streamed. If i use sharpObject.toBuffer(), then the code will wait for the conversion to finish, keeping all data in memory for the moment (if i understood correctly).

Bun is working with the following code
import sharp from "sharp"
import { Readable } from "node:stream"
import { Buffer } from "node:buffer"

Bun.serve({
  fetch: async (req) => {
    const svg = await req.text()
    const sharpObject = sharp(Buffer.from(svg)).webp()
    return new Response(Readable.toWeb(sharpObject) as ReadableStream, {
      headers: {
        'Content-Type': 'image/webp',
      },
    })
  },
})

But it getting this error message for each request, not sure why it happens
error: Premature close
 code: "ERR_STREAM_PREMATURE_CLOSE"

      at new NodeError (node:stream:244:20)
      at node:stream:714:47
      at emit (node:events:48:48)
      at emit (node:events:48:48)
      at endReadableNT (node:stream:2207:27)
      ```


apps/wall-api: Client web socket unexpectedly closes during Load Testing

Steps to reproduce:

Have WallFront + WallAPI up and running
Open WallFront in a browser
Run $ k6 run loadtests/wall-api.js
The websocket in your browser should close with error code 1005 after <5 messages received.

The web front end should be able to handle the load of hundred or thousand of messages. Visual effect is not important, we want to do load testing.

Fixed in 2.0.0


Vulkan: Background sky is still partially visible with transparent background enabled

Godot version
4.0.beta2
System information
Fedora 36, Vulkan Forward Plus, AMD Radeon RX 6900 XT, KDE + KWin
Issue description
Note: This might be a KWin bug (or design decision), but I'm filing it here just in case.
One possible cause is that KDE uses premultiplied alpha, while Godot doesn't. The background sky is not black, so even if it's fully transparent, its color is added instead of mixed.

This is what I see on the window (compositing is enabled). I can partially see the background sky:

Same window, but overlaid on a pure black background:

If I use KDE's screenshot tool to take a screenshot of the window, I get this:

The image outputted by MovieWriter (i.e. what Godot "sees") looks like this:

Steps to reproduce

Run the attached project with movie maker mode enabled (click the "movie reel" icon in the top-right corner before running the project).
Compare what you see on the window and the PNG images generated in the output/ folder.

Minimal reproduction project
test_movie_maker_png_transparent.zip

I've noticed that there is a bit of code to clear alpha in OpenGL every frame when per-pixel transparency is enabled, but not in Vulkan:
https://github.com/godotengine/godot/blob/2a04b18d37de6c6e621db5a9dfd1cd0da5ccb015/platform/linuxbsd/x11/gl_manager_x11.cpp#L311-L319
cc @bruvzg


Responsiveness for Mobile Phones

@harikesh409 The design is responsive for tablet screen or above devices but not for the mobile phone devices or smaller screens . Please assign me this issue so that I can work on UI of the smaller devices .
issue :

There are already many issues related to the footer responsiveness. #95 #65


Add icon to indicate a paper is open access

It would be great to add this icon. However, as a workaround in the meantime I simply add "Open Access" as a custom link, and then link to the paper.
url_custom = [{name = "Open Access", url = "http://example.org"}]
Here's a cropped screenshot of what this looks like:

Actually, Academic already includes Academicons, which includes this exact icon. It should be easy to use it for such purpose.
(HTML tag:  or  for a square background)

Since many leading academics make their papers freely accessible irrespective of whether or not the publication is open access, perhaps it would be better to assume the PDF link is freely available for the reader to view (unless there is a closed access or dollar icon?).


x/build: add check to trybot to catch src/go.mod and src/vendor divergence

We should make it so that trybots catch and report when the src/go.mod and src/vendor directories are not in sync, to prevent them from going out of sync without anyone noticing.
See #36851 for more context.
/cc @golang/osp-team

@bcmills I think this issue is the same as issue #36907 (which was created slightly later), and can be considered resolved via CL 217218. Do you agree?

Oh, I misread, this is about divergence between go.mod and vendor. That issue was about divergence between two different go.mods.

That said, the test in CL 217218 seems to check for this issue too, does it not?

Correct. The new test only checks that vendor/modules.txt is consistent with go.mod: it does not verify that the actual vendored source code is unchanged.

@bcmills I have some questions about this, since you have more context and might be able to answer more easily.
Do you think this can be implemented by adding a test that does go mod vendor in the two modules and does the equivalent of git diff? Does go mod vendor need internet beyond accessing the module mirror? Do you know of any precedent for doing the "equivalent of git diff" in tests in the standard library? Final question, would it be sufficient to do this check on one or two configurations (e.g., linux/amd64), or can you think of a reason to do it on more/all builder types?

I've confirmed there isn't an existing test (on master) that catches this issue by making a trivial edit in src/cmd/vendor and running src/all.bash; it reported "ALL TESTS PASSED".

Do you think this can be implemented by adding a test that does go mod vendor in the two modules and does the equivalent of git diff?

Yes.

Does go mod vendor need internet beyond accessing the module mirror?

It should need only the module mirror.

Do you know of any precedent for doing the "equivalent of git diff" in tests in the standard library?

There are a few tests that check that generated source files are clean (such as cmd/go.TestDocsUpToDate), but to my knowledge none that rely on git (or on being able to write to GOROOT).
Another approach might be to set up an overlay of the std module in a temporary directory and run go mod vendor within that overlay, then diff the resulting trees (using diff -r or an equivalent Go function, perhaps implemented in terms of filepath.Walk).
The misc/reboot test illustrates how to make an overlay of GOROOT/src in order to test commands that mutate GOROOT. (Unfortunately, due to the fact that the misc repo does not have a fully-qualified import path in GOPATH mode, that part of the repo contains many duplicate copies of the file overlaydir_test.go that constructs the actual overlay.)

Final question, would it be sufficient to do this check on one or two configurations (e.g., linux/amd64), or can you think of a reason to do it on more/all builder types?

go mod vendor is intended to be platform-independent, so running the test on one or two configurations should suffice.

Thanks for answering @bcmills. Based on those answers, I think we want a normal test that is skipped in -short test mode (so it only runs on longtest builders or when executed locally manually).
As long as it's possible to implement a reasonably fast/efficient test without needing to rely on git, I don't see a reason for the test to be implemented out of tree; that would make it difficult to reproduce the result of builders locally, and it would contribute negatively to #39054. The cmd/internal/moddeps, misc/reboot, and test/winbatch.go tests may be good sources of inspiration. (To avoid needing git, a temporary directory can be used to compute the expected result, and check the tree against that.)
So, I'll retitle this to be less about x/build and builders and more about investigating adding a test in the main repo. Once a test is added, it will be automatically executed by longtest builders (and via SlowBots). (If it turns out to be infeasible to add as a normal test in-tree, we can reconsider.)

Managing backports can become much more expensive if skew is introduced in a new major Go release. We've been lucky that go.mod and vendor skew hasn't made it into any major Go release so far (although it did happen on tip, e.g., #36851), but I think it's important we have an automated measure so we can be confident it can't happen due to human error.
I'm going to make this a release-blocker for Go 1.16: we should either resolve this issue by adding a test, or if there isn't enough time, we must manually verify that there is no skew introduced in Go 1.16 release candidates and the final release.
CC @golang/release.


Scan QR Doesn't Work on iOS Safari Installed as PWA

Hi there,
Just getting to try out Mutiny today for the first time. Love it!
I'm running into an issue scanning QR codes with Mutiny wallet when installed as PWA on iOS. The camera never initializes, and am unable to scan a QR code. Specifically on iOS 16.5.1 on iPhone 12 Pro.
I've attached a short video demoing this here: https://github.com/MutinyWallet/mutiny-web/assets/3018359/ddff7c6e-cc5d-4b5e-a639-84bd5f21a284
It looks like Mutiny is using the qr-scanner package maintained by Nimiq (a non-BItcoin "crypto" company). I was looking into their issues and there do seem to be various iOS-specific issues on there, nothing that describes this issue perfectly. Perhaps there are more reliable/widely used QR scanning packages out there?  If you're open to using a different package I'd be happy to try and PR it.

yes we have #174 documenting this. seems like an ios issue and less of a library issue.

FWIW, we use html5-qrcode in our web wallet as part of the Galoy stack. Works fine on iOS as PWA, I use it nearly every day personally.
https://github.com/mebjas/html5-qrcode

FWIW, we use html5-qrcode in our web wallet as part of the Galoy stack. Works fine on iOS as PWA, I use it nearly every day personally.
https://github.com/mebjas/html5-qrcode

Looks like they have the same problem: https://github.com/mebjas/html5-qrcode/issues/713

FWIW, we use html5-qrcode in our web wallet as part of the Galoy stack. Works fine on iOS as PWA, I use it nearly every day personally.
https://github.com/mebjas/html5-qrcode

Looks like they have the same problem: mebjas/html5-qrcode#713

Very interesting indeed. As I mentioned, I use that package in my daily life buying things with lightning. Haven't experienced it. Perhaps it's some very weird iOS thing.


Make AnonymousObserver public and LightweightObservableBase internal

Fixed issues
Fixes #10062

You can test this PR using the following package version. 11.0.999-cibuild0029174-beta. (feed url: https://pkgs.dev.azure.com/AvaloniaUI/AvaloniaUI/_packaging/avalonia-all/nuget/v3/index.json) [PRBUILDID]


Do Not Merge - Dependency cull

WIP

Culling some of the dependencies
Fixing some typos
Added keys to generated <li>
reviewed dependencies with nsp (https://www.npmjs.com/package/nsp) for security breaches -- no updates available at this time

To do:

review devDependencies vs dependencies -- I think some dependencies should be moved between them
pass tests on circleci

Don't worry about circle. This is a WIP and the test coverage is laughable.

This is failing on circle because of some docker parameters 🙈, but I just stripped the karma test out of this branch and it compiles with webpack locally -- I think it's good to go for now.
cc @lucasvo


Does not work with HTML Imports

I was playing with CSS Element Queries and Web Components and the scope of a stylesheet pulled into a document with an HTML import aren't on the main document. So when I use HTML Import to import my stylesheet, ElementQueries.js is unaware of the stylesheet.
http://www.html5rocks.com/en/tutorials/webcomponents/imports/#usingcontent
https://github.com/marcj/css-element-queries/blob/812e3bba36d5da3c955825925877dd2efa0679ff/src/ElementQueries.js#L385-L393

@dannyfritz Do you have a work around?

I can't remember what the conclusion I came to was at the time, but I had decided it would not work. Something about the HTML Import context making it hard to break out of.

Seems most browser vendors have concluded HTML Imports is not the future. Will close this out as web components now are going a different direction.


reduce number of comments in project.Makefile

@turbomam please mark as in progress or add details & provide the specific comments you're expecting to be eliminated.


Make hadoop delta ingestion retries easier

Hadoop delta ingestion retrying is problematic because it's not idempotent. It's possible for the job to push segments and insert them into the metadata store, but then fail after that for some reason (maybe some hardware died at an inopportune time). Currently, users desiring to retry delta ingestion tasks need to deal with this outside of Druid - possibly by checking the metadata store before retrying.
It would be good for Druid to help with automating this or some other method of doing retries.

user can see the segments information before/after the task using the http endpoint /datasources/{dataSourceName}/segments and make the decision on retrying or not based on that ? they might have to wait for druid.manager.segments.pollDuration after the task finishes (with success/failure).

@himanshug that seems a bit brittle, as the coordinator could be down / slow (for a while our coordinators actually took longer than druid.manager.segments.pollDuration to poll the metadata store, due to poor tuning…)
I think this feature will be hard to use unless we can make it idempotent.
Maybe we can make it idempotent by rather than having people provide "intervals", instead they provide specific segments. They could potentially get these from checking for the currently active segments.

@gianm hmm... so the flow would be like..

user sends overlord request to get list of DataSegments for desired interval
then sends the hadoopIndexTask and puts the above list in the task json
then even if user retries same task it would stay idempotent ?

also, I think user will have to provide interval as well so that we can do the VersionedIntervalTimeline stuff to create WindowedDataSegment, I don't think user can take the pain of doing all that.

@gianm implementing that idea is trivial, see https://github.com/druid-io/druid/pull/2109 . let me know if that sounds OK.

@himanshug sorry for taking so long to reply, this approach in #2109 does sound good to me though.
Is there an existing endpoint on the overlord/coordinator that gets the list of segments from the metadata store for an interval? Or do we need to add that?

@gianm there is SegmentsListUsed task action that returns list of used segments. overlord accepts POST /druid/indexer/v1/action so user can do it. However, should I wrap it inside a Task, it appears that task action is druid internal communication medium. so, i think, we should create a brand new endpoint then?

@himanshug I think a new endpoint makes sense if it doesn't already exist (I don't see one) as yeah, the task actions are meant to be internal.


Hybrid Mobile App Support

Does this plugin support Hybrid Mobile Apps i.e Apps build using such as Cordova and etc ?

See the compatibility section of the readme. I think there's a known issue with autoFormat in a particular version of the Android WebView. I don't think it's tested on iOS - please let me know what you find!


New languages

Added spanish and improved catalan

I realized I used an old version of the "translation template". I have fixed that and I have updated Spanish to the current version.
If I need to do something else in order to merge this, please don't hesitate to tell me.


Gen State M unlink does not remove process callbacks from Identifying dictionaries

GenStateM process state is removed from registrar, but not the process itself
function

Resubmit using the appropriate template


Adapt corert to Volatile moving to shared

Depends on https://github.com/dotnet/coreclr/pull/22523

Cherry-picked into https://github.com/dotnet/corert/pull/6997


[$500] [HOLD for payment 2023-09-06] [Custom Status] Display status emojis in the LHN (including the user's own status)

Part of the Custom Status project
Main issue: https://github.com/Expensify/App/issues/16350
Doc: https://docs.google.com/document/d/1uPS24aoRWE45piaTvr0XvrgV1lK3lSjieG3sD5ZPfQg/edit#bookmark=id.dm0yu67h9vq8
Project: https://github.com/orgs/Expensify/projects/59/views/1
Display status emojis in the LHN
This issue focuses on showing user status in the LHN in 2 places:

The user's own status show appear in the top right of the LHN near the profile picture. When pressed, this will bring the user to the custom status page. When hovering this emoji on web/desktop, a tooltip will be shown with the emoji and the status text

Other user's statuses will be shown next to their name in the LHN chat list

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01c5ffc19f1b06509d
Upwork Job ID:<PHONE_NUMBER>553931776
Last Price Increase: 2023-09-11

No update here, but work has started on the base PR!

Base PR is in review!

Hey @burczu this hadn't been marked as external when you reviewed the PR. If you want to apply as the C+ we will get it paid out ASAP!

Hey @stitesExpensify! I'm from Callstack, so payments via UpWork for my C+ work does not apply. But thanks ;)

Oh 🤦 Thanks!


scale = 700

https://github.com/Rock-100/MonoDet/blob/ff3da335fde8642de02aabe8fe55987258fc557d/projects/MonoRCNN/lib/dis_head.py#L98
这里有什么依据吗？ 感谢感谢

1/h may be very small, so the network cannot predict it well. Multiplying 1/h with 700 can make the training more stable. In my experiments, multiplying 1/h with 400, 500, 600, or 700 all work well.


Avoid double timestamps when running under systemd/journalctl

Oct 14 03:02:14 <IP_ADDRESS> cilium-agent[21557]: time="2017-10-14T03:02:14+02:00" level=info msg="Waiting for consul client to be ready..."

This duplicates #1023

Dup of #1023


Enhancement - Make the pdf Searchable

Hi there, I am wondering if you will be supporting a Search Function in up coming releases?
I think that this would be Immensely useful!
Thank you

Yeah, I think that was great, and I just want to say thank you for the great work on this library. It really nice

Hi, thanks for pointing it, i will work on it as soon as i can, but if you wish you can still do a PR with this enhancement :)

If the PDF was searchable that would be FANTASTIC!!
I'm just about to release an app where that would be useful, and I'd love
to test it for you and implement it if you get it done.
On Mon, Aug 31, 2020 at 1:54 PM Arnaud Delubac<EMAIL_ADDRESS>wrote:

Hi, thanks for pointing it, i will work on it as soon as i can, but if you
wish you can still do a PR with this enhancement :)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/arnaudelub/flutter_fullpdfview/issues/9#issuecomment-683932994,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABU3WN4TJ4EG2Q6A4YNWLLTSDPPUVANCNFSM4OX4GJBA
.

Hi there, I'm wondering if there has been any movement on this enhancement?
I'm not savvy enough for a PR, but I could pass you some code for the iOS
side that might be helpful.
I'm mostly interested in the Android side now.
Thanks!
On Tue, Sep 1, 2020 at 11:05 AM JJ Buchholz<EMAIL_ADDRESS>wrote:

If the PDF was searchable that would be FANTASTIC!!
I'm just about to release an app where that would be useful, and I'd love
to test it for you and implement it if you get it done.
On Mon, Aug 31, 2020 at 1:54 PM Arnaud Delubac<EMAIL_ADDRESS>wrote:

Hi, thanks for pointing it, i will work on it as soon as i can, but if
you wish you can still do a PR with this enhancement :)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/arnaudelub/flutter_fullpdfview/issues/9#issuecomment-683932994,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABU3WN4TJ4EG2Q6A4YNWLLTSDPPUVANCNFSM4OX4GJBA
.

well, adding a search Engine is not an easy task, it's surely a nice enhancement but it may take some times


Added hover animations in Home Page for better UX

Before

After

Also improved animation in Hacktoberfest Button
Before
No Hover Animation
After

Before
No Animation
After

icon animation in learn build grow cards looks bad, remove them.

Removed Icon Animations


Button Speed Dial Icons corrupted with pango text provider

Description of the Bug
When switching the text provider to pango, icons for the MDFloatingActionButtonSpeedDial are not showing correctly.
ScreenShot of the KitchenSink demo app attached along with Kivy Logs to show the Text Provider switched to Pango.
Only modification done in the KitchenSink main.py is adding the following line at the top of the file to force Text Provider to pango.
os.environ['KIVY_TEXT'] = 'pango'
Screenshots

Versions

OS: MacOS 10.14.6
Python: 3.8.5
Kivy: 2.0.0rc4
KivyMD: 0.104.2.dev0

@azzadeen os.environ ['KIVY_TEXT'] = 'pango' - what for?

To support RTL languages and fonts.

The same issue goes for the chips with icons.

@azzadeen I cannot confirm this because everything is displayed well on the Mac. You may not have installed additional libraries for pango to work.

@HeaTTheatR I have the following with each dependencies installed correctly using home-brew:
pango: 1.46.2
cairo: 1.16.0_3
fontconfig: 2.13.1
fribidi: 1.0.10
glib: 2.66.2
harfbuzz: 2.7.2
The test was redone after upgrading pango to v 1.48.0 with the same results!
I stared to think it could be a limitation from kivy side but you mentioned it displayed well on Mac for you. Any idea what could be missing libraries I should be installing?
FYI: kivy Pango Text Provider

Tested with Raspbian buster with raspberry pi 4. Same results found on Mac for both Speed Dial and chips with icons. Icon images corrupted for both.

The issue is deprecated due to the new API of the KivyMD library 2.0.0 version


Add Chat with setup specialist to the accounting page.

Explanation of Change

Fixed Issues

$ https://github.com/Expensify/App/issues/51487
PROPOSAL: https://github.com/Expensify/App/issues/51487#issuecomment-2446168063
Tests

Create a new workspace
Enable Accounting
Go to the Accounting page
Verify that: Chat with setup specialist to the accounting page is displayed

[x] Verify that no errors appear in the JS console

Offline tests

same as above
QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."
same as above

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/user-attachments/assets/c50848f6-cc97-4dd1-8782-cc264f33942c

Android: mWeb Chrome

https://github.com/user-attachments/assets/8fe93f65-dfdb-4b9a-b788-3c00c6afe436

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

https://github.com/user-attachments/assets/dca6e496-e8e1-4903-9c53-b52bb6c6ac6d

MacOS: Desktop

https://github.com/user-attachments/assets/a637dd58-e3b7-4780-bdc3-2db9f6c0c4ae

I asked for translation into Spanish here

@dukenv0307 i updated, please check again

@dukenv0307 how is the review going?

Yeah, it looks a bit off. Here's some more detailed specs to help you out:

Also, the text color on this bit should be text-supporting like seen below:

That looks good to me 👍

I'll update soon

@dukenv0307 @techievivek i updated to call API GetAssignedSupportData but it didn't have data

@nkdengineer I think that's expected since you don't have a guide/account manger/partner manager assigned to you. Did you try creating a workspace and see if you get assigned to a guide?

@nkdengineer I think that's expected since you don't have a guide/account manger/partner manager assigned to you. Did you try creating a workspace and see if you get assigned to a guide?

https://github.com/user-attachments/assets/3b25ad03-3791-497a-a9b4-597a3c39dd08
@techievivek @dukenv0307 I tried creating a new workspace and still haven't received data. Am I missing something?

@nkdengineer Can you try with a new email that is not alias email format(include +), we don't assign guides to account with alias email.

thanks @techievivek, It looks like we have data now

@nkdengineer You will be updating the PR to check for the assigned guide before showing the chat with setup specialist link, right? Just double checking to see if you understand my comment that I posted earlier.

@techievivek @dukenv0307  Sorry, I’m not entirely clear. Do you mean that we will only show the text below if account.guideDetails exists?

Yeah, we only want to show the link when account.guideDetails.email entry is non-empty.

@nkdengineer Do you need any more clarifications here? Feel free to DM me on Slack if you have any questions, thanks.

Thanks @techievivek. I'm clear now. I'll give an update soon

@dukenv0307 @techievivek I updated code changes and test steps. Please check again

email and calendarLink should be fine for now, rest are for internal purposes.

@dukenv0307 i updated

@dukenv0307 Can you please do a final review here? Thanks.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Looking great on staging!


$page and collection variables not available in x-style components

Neither $page nor collection variables are passed by default to x-components. You need to explicitly pass them, as in:
<x-footer :page="$page" :categories="$categories" />

Otherwise, you get an error like:
Call to a member function featuredCategories() on null (View: C:\Users\...\source\_components\footer.blade.php)

This is inconsistent with how these variables are available by default in include-style components. For example, if I include the same component this way:
@include('_components.footer')

I don't need to pass $page and $categories for it to work. I am using Jigsaw v1.3.27.

Hey @amadeann—this is one of the key differences between Blade includes and components: includes automatically inherit the parent scope, and components do not. Laravel ≤ 6.x @component directives also work this way.
If you need the partial you're including to inherit the entire parent scope automatically, you should keep using @include.

@bakerkretzmar
I see $page and collection variables as something equivalent to variables globally included in views via View Composers. If you do this in a service provider in Laravel:
View::composer('*', function ($view) {
    $view->with('foo', "This will be displayed");
});

You have access to $foo inside x-style components. I think it would make a lot of sense to include them automatically in Jigsaw as well.

@amadeann actually yeah, we tend to agree with you. We're gonna look into making this change or something similar.
Eventually I think we'd like to split $page out into two variables, $page and something like $site or $app, where $app is truly global and available in components as you've described, and $page behaves how it does now, as if it was passed from a controller, and is not global.

@bakerkretzmar Any plans on implementing it?
Tried to use View::share in the bootstrap but that does not work at all. Switched to full framework to save a lot of time.


CYC-38 CYC-39 CYC-45 Add Authentication scaffolding

Description
closes #36
closes #33
This installs Laravel/Breeze, which subsequently adds AlpineJS and Tailwind. Additionally creates an Auth Namespace with controllers, view presenters, and tests.
note: i realize this adds another JS framework that we dont intent to use in the long run, but we can refactor the Authentication views to be ReactJS components later
How to use
This adds a number of routes that are immediately visit-able upon running yarn install && yarn dev

Run php artisan migrate to create your required database tables

if you get an error its likely that you are missing the MySQL php module, run sudo apt install php7.4-mysql
Another possibility is that you haven't created your database, get a mysql client like Datagrip, connect to the DB and create the schema manually if it doesn't exist

Visit /register and create an account
If you aren't logged in automatically visit /login and sign in with your created account
Observe the dashboard you are brought to
Alternatively: run php artisan test to ensure that all tests are passing

@m-triassi please do yarn add jest, it should fix the conflict


update: add sep in list open params

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature
Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build
/area plugin-sdk

/area tests

What this PR does / why we need it:
Follow-up :point_right: https://github.com/falcosecurity/libs/pull/319
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

update: add `Separator` in `sdk.OpenParam`

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: leogr
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jasondellaluce, leogr
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [jasondellaluce,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


HTTP Redirects

I am unable to use http to check for a 301 http code. It looks like the test is following the redirect. Perhaps an option to not follow redirects?

Agree, this would be a good enhancement.

@aelsabbahy I added reveresed boolean option no-follow-redirects in order not to break comptibility woth the previous versions. If you think that it is better to have follow-redirects then I can reverse and rebase.
Please comment and review.


Fix Latency Heatmap source to actually be a heatmap

Nice dashboard! Here is a small fix.

cc @AndrewFarley maybe ? :)

Sorry just saw this.  Cheers!


Transaction info: payment proof code isn't fully displayed

On transaction info screen payment proof code isn't fully displayed and scroll overlaps the code

Checked


Feature: pass error into activity finalizer

What was changed
If an error happens when executing an activity it will be convenient to know it within a finalizer.
Why?
For example, we collect logs and metrics and want to flush or send them only if the activity failed. Currently, within a finalizer there is no way to detect whether it was a success execution or failure.
Checklist

How was this tested:
With unit tests.

Any docs updates needed?
Need to make a small update here with registerActivityFinalizer() example and provide a snippet with a closure that accepts an exception:

$worker->registerActivityFinalizer(
    function (Throwable $error = null) {
        if ($error !== null) {
            $this->logger->flush();
        }

        $this->kernel->showtdown();
    }
);

https://docs.temporal.io/application-development/foundations?lang=php#register-types

Thanks!


Add case for when a ehb / ehp may be negative

Re: https://github.com/wise-old-man/wise-old-man/issues/1393
Changes:

Added a case for when EHP may be negative and removed the hardcoded + unless the value is positive.
Added a case for when EHB may be negative and removed the hardcoded + unless the value is positive.

Outcome:

When a number is added which is negative, there is no + sign suffixed.

Below is the screenshot of the user which was identified in the issue.

Beautiful, thank you very much


Suggestions on SQL REMOVE syntax and multiple-item support

A suggestion: It's possible to remove a single item from a list using:
UPDATE Account REMOVE addresses = addresses[1]
Add support to allow removing a range of items at once:
UPDATE Account REMOVE addresses = addresses[1,4]
Although, I suggest that this syntax be changed anyway, to this:
UPDATE Account REMOVE addresses[1]
UPDATE Account REMOVE addresses[1,4]
And add support for negative values, meaning "from the end". So to remove the last item from the list:
UPDATE Account REMOVE addresses[-1]

Hi @Eric24
Thank you very much, we will take these suggestions into consideration. In the meantime, you can try the following (v 3.0 and following):
UPDATE Account SET addresses = addresses[0] || addresses[4 .. addresses.size()]

I hope it helps
Thanks
Luigi

I'll try that on 3.0, but wouldn't address.size() be one more than the last item index?
I've also tried various approaches to removing the "last" item in a list under 2.2.x (including .size(), eval(), and others), but nothing has worked. Any idea on how to remove the last item under 2.2.x without knowing in advance what it's index is?
By the way, the main reason we have not upgraded to 3.x yet is because of the orientjs driver. As soon as it's out of beta for 3.x, we'll move to 3.x.


ERROR: no function clause matching in GenServer.whereis/1

Followed the exact instructions as they were given, the configuration seems to be working but the application returns an error whenever the task runs.
Environment
elixir: Erlang/OTP 21 and Elixir 1.6.6 (compiled with OTP 19)
quantum: 2.3.0
debug/info when application is launched:
[info] Running MyappWeb.Endpoint with Cowboy using http://<IP_ADDRESS>:4004
[info] [swarm on nonode@nohost] [tracker:cluster_wait] joining cluster..
[info] [swarm on nonode@nohost] [tracker:cluster_wait] no connected nodes, proceeding without sync
[debug] [swarm on nonode@nohost] [tracker:handle_call] registering #PID<0.669.0> as :"Elixir.Myapp.Libraries.Scheduler.ClusterTaskSupervisorRegistry.Group.#Reference<0.590121076.4105961474.145928>", with metadata %{}
[debug] [swarm on nonode@nohost] [tracker:handle_call] add_meta {Myapp.Libraries.Scheduler.ClusterTaskSupervisorRegistry.Group, true} to #PID<0.669.0>
[debug]<EMAIL_ADDRESS>Loading Initial Jobs from Config
[debug]<EMAIL_ADDRESS>Unknown last execution time, using now
[debug]<EMAIL_ADDRESS>Adding job :phoenix_job
[debug]<EMAIL_ADDRESS>Continuing Execution Broadcasting at -576460701918 (2018-08-13T10:14:00)
[debug]<EMAIL_ADDRESS>Scheduling job for execution :phoenix_job
[debug]<EMAIL_ADDRESS>Continuing Execution Broadcasting at -576460641918 (2018-08-13T10:15:00)
[debug]<EMAIL_ADDRESS>Task for job :phoenix_job started on node [:nonode@nohost]

The error shortly after the above responses:
 started from Myapp.Scheduler.ExecutorSupervisor terminating
** (FunctionClauseError) no function clause matching in GenServer.whereis/1
    (elixir) lib/gen_server.ex:1007: GenServer.whereis({Myapp.Scheduler.Task.Supervisor, [:nonode@nohost]})
    (elixir) lib/gen_server.ex:824: GenServer.call/3
    (elixir) lib/task/supervisor.ex:363: Task.Supervisor.async/6
    (quantum) lib/quantum/executor.ex:139: Quantum.Executor.run/4
    (elixir) lib/enum.ex:737: Enum."-each/2-lists^foreach/1-0-"/2
    (elixir) lib/enum.ex:737: Enum.each/2
    (quantum) lib/quantum/executor.ex:73: Quantum.Executor.execute/5
    (elixir) lib/task/supervised.ex:88: Task.Supervised.do_apply/2
    (stdlib) proc_lib.erl:249: :proc_lib.init_p_do_apply/3
Function: #Function<9.113246364/0 in Quantum.Executor.start_link/2>
    Args: []

Can you suggest a solution?

Duplicate of #356, will be released with #359


Redirection from rename channel and rename material notification issue

When a new channel and a material is renamed, I receive a notification, but I am unable to be redirected from that notification to the renamed channel and material.

The issue has been resolved for materials. The issue with channel has been resolved in #1120  Please pull the latest changes.


Multiple Network requests issued

Lets say user is viewing the repositories for the search "Android", and the scrolled to about 200 items in the result.
In other words, 200 items are now loaded into the RecyclerView's Adapter. The Last Page index at this stage will be 4 (for 50 items requested per page from the network - NETWORK_PAGE_SIZE) and Page 5 is awaiting to be retrieved.
The User now rotates the device to Landscape orientation.
Now the user scrolls to the end. At this stage, network request will be triggered but it will start requesting from page 1, until the page to be shown is requested. In the stated example, it will poll from page index 1 to page index 5, instead of just the page index 5.

This also happens when the user kills the app and relaunches the app to view the query results for a previously searched query. This applies for both the code samples (with or without the paging library).
Is this intended to work like this or is this a bug?

Codelab changed meanwhile. Feel free to create a new issue or reopen this one if the issue still exists.


Implement locations for individual sessions

Idea: Click on session opens a map view, where each location of that sessions is shown with points and maybe connected with lines.

Open the map directive directly in the same view

wontfix


ENH:Combine two similar function

Combine 'checkPosition()'functionn and 'checkPosition2()'function into 'checkPosition()'.
resolve: #52

굿굿입니다^^ merge합시당~~

좋아용 머지해요~~

merge go


data: Add first draft of food_explorer dataset

This PR adds/upgrades several data pipelines:
Meadow

FAOSTAT_QCL (upgrade): data://meadow/faostat/2021-03-18/faostat_qcl
FAOSTAT_FBS (upgrade): data://meadow/faostat/2021-04-09/faostat_fbs
FAOSTAT_FBSH (upgrade): data://meadow/faostat/2017-12-11/faostat_fbsh

Garden

FAOSTAT_QCL new: data://garden/faostat/2021-03-18/faostat_qcl
FOOD_EXPLORER new: data://garden/explorers/2021/food_explorer

The current version of the Food Explorer dataset only contains data from QCL dataset. The next iteration should add data from other sources (FBS/FBSH).
I am saving the Food Explorer dataset under namespace explorers, happy to adjust.
cc. @MarcelGerber

Lovely! Thanks for your feedback. I have updated the current notebook with a bit more of explanations. I hope this helps 😄
@larsyencken


Convert StatFilter to an Autocomplete component

Clicking "New Stat" pops up a huge list that is not sorted in any obvious order, which is cumbersome to navigate

In addition, this component is a bit laggy probably due to the sheer number of stats in the dropdown. This causes some funky double clicking/adding of stats to happen
https://streamable.com/3ew6na


add dividers to all table listings

Issue #1138 :
https://github.com/bcgov/met-public/issues/1138
-Add dividers to all listing tables
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the met-public license (Apache 2.0).

Codecov Report

Merging #1234 (5298228) into main (ffd520e) will increase coverage by 0.34%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##             main    #1234      +/-   ##
==========================================
+ Coverage   73.19%   73.54%   +0.34%
==========================================
  Files         281      273       -8
  Lines        7947     7740     -207
  Branches      563      563
==========================================
- Hits         5817     5692     -125
+ Misses       2050     1968      -82
  Partials       80       80

Flag
Coverage Δ

metweb
67.81% <75.00%> (-0.03%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

.../components/comments/admin/reviewListing/index.tsx
81.33% <ø> (ø)

...et-web/src/components/engagement/listing/index.tsx
85.39% <ø> (ø)

met-web/src/components/feedback/listing.tsx
90.24% <ø> (ø)

met-web/src/components/survey/listing/index.tsx
87.83% <ø> (ø)

...s/userManagement/listing/UserManagementListing.tsx
95.65% <ø> (ø)

met-web/src/components/common/Table/index.tsx
79.68% <66.66%> (-1.57%)
:arrow_down:

...ment/form/EngagementFormTabs/TeamMemberListing.tsx
100.00% <100.00%> (ø)

met-api/src/met_api/models/widget.py
84.09% <0.00%> (-0.36%)
:arrow_down:

met-api/src/met_api/models/__init__.py
100.00% <0.00%> (ø)

... and 12 more


docs: Fix docs for python (box/box-codegen#540)

Pull Request Test Coverage Report for Build<PHONE_NUMBER>0
Details

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 92.239%

Totals

Change from base Build<PHONE_NUMBER>9:
0.02%

Covered Lines:
10162

Relevant Lines:
11017

💛  - Coveralls


[Bug] Astgen failed to parse vue in some cases

Describe the bug

Thanks for the report. Fix is in.


Registration Page

As user, wants to register them with a form. The form will have some mandatory fields and optional fields too.
Form will have following fields,
Email address*,
Name*,
password*,

 Create a form for user registration.


RetroDECK update

Minor update for new controlfolder location

Still Issues with platform.py  so will try again!


ecma6.json

This PR provides a first version of ecma6.json.
This def must be improved to support iterator (see TODO_ITERATOR).
I think too that TypedArray_ctor, Map_ctor, Set_ctor should be created and used too.
In other words this PR desribes the whole ES6 defined at https://developer.mozilla.org//en-US/docs/Web/JavaScript/New_in_JavaScript/ECMAScript_6_support_in_Mozilla
This def must be improved to manage iterator and some !effect.

Looks great. But shouldn't the Promise properties live under Promise.prototype?

Looks great. But shouldn't the Promise properties live under Promise.prototype?

As I said you, it's not perfect and I think it should be improved, but it's a first step. I think we could improve it step by step. What do you think?
More I tell me if tern could customize acorn with 6 version when ecma6.json is loaded.

I think it is safe to simply add support for ES6 syntax by default -- it is almost entirely backwards-compatible anyway. Acorn parses ES6 now, but before we turn that on in Tern we'll have to add support for new syntax constructs.

So should the Promise properties be moved to prototype, or is there a reason they are directly on the constructor?

So should the Promise properties be moved to prototype, or is there a reason they are directly on the constructor?

To be honnest with you, I don't know -( I have generated that from https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Promise

I've merged this as de4efe7df844ea357f08.


Bluetooth control only mode?

hello,
would it be possible to add functionality to control projectors with bluetooth only like the remote does? this would be useful if you do not wish to add wifi to the android tv os but still wish to control projector functions like i do.
thanks for reading

Once the projector turned on, it communicates with the remote through paired bluetooth mode, which is different from BLE advertisement to power on the projector. It may be possible to simulate the whole pairing process, but currently I don't have any clues to digging into it.