Insight and Renown autotrigger

A person might not want to trigger insight if they have a low reserve value and a full hand. A person might not want to auto trigger renown if playing against edmure tully.

Thanks for your feedback!
While these are valid situations, they are also quite niche. You would be clicking through a lot of extra prompts in all your games just to allow for less than a handful of specific situations. Btw, unless you feel you're at risk of getting decked, I like drawing insight over my reserve since it allows me to filter my hand, though opinions may vary. The situation with Edmure is easily solvable over the chat and using the /power x command. Still, the discussion is ongoing about the trade-off between playability and manual control.

While I agree with what you are saying about most situations being niche,
it does change the game and give an added advantage to the person drawing.
If they have a 3 reserve from a choke deck and 6 cards in hand and they
announce that they won't be taking insight before they draw... well then
they have an advantage of knowing what their next card is, which is
absolutely massive. A simple prompt would solve this. I've been in this
situation many times with Daenerys and Renly.
On Thu, Mar 2, 2017 at 6:21 PM, DukeTax<EMAIL_ADDRESS>wrote:

Thanks for your feedback!
While these are valid situations, they are also quite niche. You would be
clicking through a lot of extra prompts in all your games just to allow for
less than a handful of specific situations. Btw, unless you feel you're at
risk of getting decked, I like drawing insight over my reserve since it
allows me to filter my hand, though opinions may vary. The situation with
Edmure is easily solvable over the chat and using the /power x command.
Still, the discussion is ongoing about the trade-off between playability
and manual control.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/cryogen/throneteki/issues/526#issuecomment-283846291,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AY7djKfc53cXTXDA9x5wg7WkcCN5kPvLks5rh3kwgaJpZM4MQ6Yc
.

I think we both need to address this need and avoid an extra prompt which will be useless in 99% of cases. So, to note down here what I've suggested in the chat, here's a UI proposal that could address at the same time both tose needs.

we add a per-player UI element in the form of a checkbox, that might be called "auto trigger keywords", or something like that
the checkbox is ticked by default for both players
as long as the checkbox is ticked, all keywords that do not need further choices by the player (renown, insight, pillage, etc.) trigger automatically without any prompt
as long as the checkbox is not checked, the corresponding player is always asked whether they want to activate a specific keyword or not

This will allow to have a sane default (which is what most people will want most of the time), as well as a non-annoying way out for those rare situations where you want to act differently.
Possible improvements over the idea might be:

make the initial value of the checkbox a user-configurable option, so that players that always want to be asked can have that
make the checkbox keyword-specific, i.e., one for pillage, one for renown, etc.

That sounds like a wonderful idea.
On Tue, Mar 7, 2017 at 4:40 AM, Stefano Zacchiroli<EMAIL_ADDRESS>
wrote:

I think we both need to address this need and avoid an extra prompt
which will be useless in 99% of cases. So, to note down here what I've
suggested in the chat, here's a UI proposal that could address at the same
time both tose needs.

we add a per-player UI element in the form of a checkbox, that might
be called "auto trigger keywords", or something like that
the checkbox is ticked by default for both players
as long as the checkbox is ticked, all keywords that do not need
further choices by the player (renown, insight, pillage, etc.) trigger
automatically without any prompt
as long as the checkbox is not checked, the corresponding player
is always asked whether they want to activate a specific keyword or not

This will allow to have a sane default (which is what most people will
want most of the time), as well as a non-annoying way out for those rare
situations where you want to act differently.
Possible improvements over the idea might be:

make the initial value of the checkbox a user-configurable option,
so that players that always want to be asked can have that
make the checkbox keyword-specific, i.e., one for pillage, one for
renown, etc.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/cryogen/throneteki/issues/526#issuecomment-284710719,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AY7djFA4LXWeayCW9z6lCwTAmKte_GYfks5rjVA4gaJpZM4MQ6Yc
.


[sil-ownership] Reify the lifetime constraint of a use from a bool in to UseLifetimeConstraint.

[sil-ownership] Reify the lifetime constraint of a use from a bool in to UseLifetimeConstraint.
This is the first in a series of commits that cleans up the SILOwnershipVerifier
based off of discussions/feedback with other people who are now using it. The
next step is to split the checker from the declarative computation of what I
call the UseOwnershipRequirement.
rdar://33358110

@swift-ci smoke test and merge

NOTE Andy and I are still discussing the name of the type/its cases. But at least this commit gets us one incremental step closer to more clarity by eliminating the use of bools for this purpose.

Lets try this again.

@swift-ci smoke test and merge

@swift-ci smoke test and merge

@swift-ci smoke test and merge

LLDB failed here. From what I understand, LLDB is going to be disabled for PR testing purposes.

@swift-ci smoke test linux platform

@swift-ci smoke test linux platform

Ah actually I need to wait for #11340.

Well since I have to wait, I am going to put the other commit here as well.

@swift-ci smoke test and merge

@swift-ci smoke test and merge

@swift-ci clean smoke test linux platform

@swift-ci clean test linux platform

@swift-ci clean test linux platform

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - ec44f55372dd447f49b8f03d8e5ee4b86bb806f2
Test requested by - @gottesmm

Now that PR is working again... lets try this again!

@swift-ci clean test linux platform


How to get the created system variables struct definition data

i will notify here after implementation. if you have implementation code already please fork and create PR.

hi @BertXin
reading complete struct definition is not available.
but you can get symbolic value as return value for system variable
sample code 👉 https://github.com/chaitu-ycr/py_canoe/blob/main/tests/test_py_canoe.py#L145-L146


Provide estimate of percentage complete

Migrated from https://code.google.com/p/alfresco-bulk-filesystem-import/issues/detail?id=142
Once the scanning phase is consolidated (which will be necessary as part of issue #2), it will be possible to provide an approximate estimate of percentage completed, in terms of number of importable items imported vs those yet to be imported.

This is now provided in the logs.  The status page has yet to be updated however.

Provided in status page, as part of fixes for issue #31.


Change SHA256 algorithm to work on FIPS-compliant machines.

#5103

:up: :date:
This new approach should still enable users to override the crypto algorithm (as long as its fips compliant).

:shipit:

:up: :date:

:shipit:

:shipit:


fix(ElementEvents): ElementEvents.defaultListenerOptions allows to set default options when subscribing to events

ElementEvents.subscribe will set capture to true be default if not explicitely passed in argument. This is not the standard behavior of the native addEventListener() and confuses developers. This new options let you define the default behavior.
Fixes issue #657

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Sebastien Roch seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Mix combining to different directory

I'm trying to simply combine a few css files to a single css file like below:
   .combine([         'resources/assets/css/app-stage.css',         'resources/assets/css/custom.css'     ], 'public/css/app-full.css')
Running npn run dev returns an error indicating that there is no file or directory 'public/css/app-full.css'.  Obviously the two files are physically located in the 'resources/assets/css' directory.  I have tried changing 'public...' to '../public' with no luck.  Worked fine for me with gulp.

Duplicate: #271

That's it -- as a workaround I'll just create the appropriate directories in public.  Normally, everything in my public directory is populated with a script.

@gstoa also you can use another trick - copy an empty file to destination directory before combine, it will create all directories.
It work for me:```
//First i copy dummy file to codemirror directory that not exists
.copy('public/empty.txt', 'public/js/vendor/codemirror/empty.txt')
//Then I use combine and it works,because directories are already created
.combine([
'node_modules/codemirror/lib/codemirror.js',
'node_modules/codemirror/mode/xml/xml.js',
'node_modules/codemirror/mode/javascript/javascript.js',
'node_modules/codemirror/mode/css/css.js',
'node_modules/codemirror/mode/php/php.js',
'node_modules/codemirror/mode/htmlmixed/htmlmixed.js',
'node_modules/codemirror/addon/search/search.js',
'node_modules/codemirror/addon/search/searchcursor.js',
'node_modules/codemirror/addon/dialog/dialog.js',
'node_modules/codemirror/addon/selection/active-line.js',
'node_modules/codemirror/addon/display/fullscreen.js',
], 'public/js/vendor/codemirror/editor.js')


encoding/: Adopt serde style encoding

Adopt encoding style similar to serde. EncodeXXX for a type that can be
encoded (see serde's Serialize) and XXXEncoder for a supported encoding i.e.
text and protobuf (see serde's Serializer).

Compatible with Rust's additive features. Enabling the protobuf feature does
not change type signatures.
EncodeMetric is trait object safe, and thus Registry can use dynamic dispatch.
Implement a single encoding trait EncodeMetric per metric type instead of
one implementation per metric AND per encoding format.
Leverage std::fmt::Write instead of std::io::Write. The OpenMetrics text
format has to be unicode compliant. The OpenMetrics Protobuf format requires
labels to be valid strings.

Builds on top of https://github.com/prometheus/client_rust/pull/100.
Status: It compiles. Still a couple of rough edges. Tests don't yet compile.

I had a closer look at this and I found the the decomposition of the functions on MetricEncoder a bit confusing to understand. What do you think about an approach where we provide more concrete functions on MetricEncoder like https://github.com/prometheus/client_rust/commit/120cfb0e97e3f7853a4ac8cdd1f8e4418e533f65?
I think this could drastically simplify, how often we need to dispatch and e.g. also solves the issue that the protobuf encoding does not know about suffixes. On the flip side, this will decrease the flexibility a bit because users cannot make arbitrary suffixes anymore. This feature is a bit of an illusion anyway because it only works with the text encoding.

I had a closer look at this and I found the the decomposition of the functions on MetricEncoder a bit confusing to understand. What do you think about an approach where we provide more concrete functions on MetricEncoder like 120cfb0?

Thanks for looking into this!
I think that makes sense. Would you agree with me suggesting that we can do this as a follow up @thomaseizinger? I would like this pull request to make the architectural change only. Breaking individual methods can happen in a one-by-one case later on, ideally in a deprecate-then-remove style in case users already depend on it.

I suggested it because I think it would really simplify the implementation and thus ease the review of this PR.
I get the desire to keep the PR small. Unfortunately, we have to add a lot of code to retain some of the interfaces. I think this PR could be smaller if we just break those.

I had a closer look at this and I found the the decomposition of the functions on MetricEncoder a bit confusing to understand. What do you think about an approach where we provide more concrete functions on MetricEncoder like 120cfb0?

Gave this more thought and tested it out. See https://github.com/prometheus/client_rust/pull/105/commits/e030f76aad4e8b29b1398eac77a9fa3fbc954ff1. As you predicted, this simplifies things a lot.
As always, thanks @thomaseizinger for the great suggestion.
There are still a couple of TODOs, but I see light at the end of the tunnel.

I had a closer look at this and I found the the decomposition of the functions on MetricEncoder a bit confusing to understand. What do you think about an approach where we provide more concrete functions on MetricEncoder like 120cfb0?

Gave this more thought and tested it out. See e030f76. As you predicted, this simplifies things a lot.

That is great to hear! I think we can do even better though. Let me know what you think of https://github.com/thomaseizinger/client_rust/commit/d2ad9df2deb99191f3b67d2022e7f75c05b9c48d.

I had a closer look at this and I found the the decomposition of the functions on MetricEncoder a bit confusing to understand. What do you think about an approach where we provide more concrete functions on MetricEncoder like 120cfb0?

Gave this more thought and tested it out. See e030f76. As you predicted, this simplifies things a lot.

That is great to hear! I think we can do even better though. Let me know what you think of thomaseizinger@d2ad9df.

Wonderful simplification. Thanks for proposing a patch. Only issue I see is that it makes certain invalid states possible at compile time. See https://github.com/thomaseizinger/client_rust/commit/d2ad9df2deb99191f3b67d2022e7f75c05b9c48d#r90329584.

I sent a PR here: https://github.com/mxinden/client_rust/pull/1

Is there a reason this is adopting a serde style rather than directly using Serde (https://github.com/prometheus/client_rust/issues/97)? The motivation behind that would be that serde already has a large ecosystem behind it, with plenty of helpers to construct Serialize implementations like #[flatten], etc

Not every type that implements Serialize is a valid metric.
Maybe we could use serde internally but even that is tricky because protobuf doesn't map cleanly to serde so I am struggling to see the benefit!
How do you expect the ecosystem support of serde to benefit this prometheus client implementation?

That makes sense, thanks for the explanation. My main interest was from more advanced derive support; in particular I want #[serde(flatten)] for now, but possibly other customizations in the future. While these could be solved by alternative mechanisms, it seemed nice to just piggy-back on Serde

Each Prometheus metric encoding would map to a unique Serde data format, all distinct from e.g. raw Protobufs or whatever. Only a well-defined set of encodings (data formats) would be acceptable representations of metrics. One couldn't derive an arbitrary data format for a type and expect it to work. (If this was already understood, apologies!)

That makes sense, thanks for the explanation. My main interest was from more advanced derive support; in particular I want #[serde(flatten)] for now, but possibly other customizations in the future. While these could be solved by alternative mechanisms, it seemed nice to just piggy-back on Serde

Can you please explain further what you are trying to achieve? Like, post the type you are trying to write (with serde annotations) and the corresponding prometheus text encoding that you are expecting.

Okay, thanks for sharing this. It makes sense that we support something like this but we can't do it via serde, simply because there is no way of how we can possible map all types that are Serialize to a valid prometheus text encoding.
With the features introduced in this PR, it will be possible to implement a #[labels(flatten)] attribute in the custom derive. Until then, you can workaround it by making a constructor that accepts Common and flattens out the fields manually. That is only a few more LoC and provides roughly the same convenience upon constructing the label set.

In real world we have about 10 metrics with 15 common labels so it ends up being a bit of duplication. Anyhow, I don't want to derail this PR. Thanks for the help and explaination, I'll open an issue to track adding a flatten attribute.

With the features introduced in this PR, it will be possible to implement a #[labels(flatten)] attribute in the custom derive.

That would be my preference as well.
@howardjohn let's discuss how to proceed once you created the issue.

I will merge here. I tested this in conjunction with #82 on https://github.com/mxinden/kademlia-exporter/. While #82 still needs some work, this is ready to go. I suggest we cut an alpha in between to allow folks to test this patch and the new protobuf encoding from @ackintosh.

I opened https://github.com/prometheus/client_rust/issues/117 to discuss further. Thanks everyone. I may be able to submit a PR myself if I can find time + figure it out


V2 dev cmorizer docu

First draft of a CMORizer description. Open to comments and suggestions.  :)

@hb326 I have just committed some changes addressing sphinx syntax issue (links, etc.).
Will start reviewing the content asap.

I made a first round of comments. We should read it again once they are addressed.

Can you resolve the merge conflict?

I think it is due to renaming from .inc to .rst. It should be renamed back once ready for merging.

I have renamed the file again to "observations.inc", so hopefully the merging should work now.


Using allow after valid is not working

Describe the bug
If you add the allow operator after using the valid it will only pick the valid.
example:
export const ciaoSchema = Joi.string().valid('Ciao').allow(null).meta({className: 'Data'})
will output:
type Data = 'Ciao'
instead of:
type Data = 'Ciao' | null

Describe the bug If you add the allow operator after using the valid it will only pick the valid.
example:
export const ciaoSchema = Joi.string().valid('Ciao').allow(null).meta({className: 'Data'})
will output:
type Data = 'Ciao'
instead of:
type Data = 'Ciao' | null

I know That I can add the null on the valid, but when you have a reusable type it's not always possible to do so.


fix: update sveltekit Request type

Closes https://github.com/quirrel-dev/quirrel/issues/1128

Coverage: 82.134%. Remained the same when pulling 5772e9b8e6baeeaf1deed6c227ca9e171435f641 on sveltekit-headers into ab7f583ca3fb026ab32700bd696c0b62842dd90f on main.


Detection

Detected from Google Chrome

Yes that's quite normal, unless you try to make it undetected from Googles antivirus. There's also other methods such as zipping the file with a password and using that.


"No parser could be inferred" error when i try to commit

In my public directory I have an image file called logosquare.png.
When I try to do a git commit I get the following error:
Preparing lint-staged...
❯ Running tasks for staged files...
  ❯ package.json — 2 files
    ❯ * — 2 files
      ✖ prettier --plugin-search-dir=. --write [FAILED]
↓ Skipped because of errors from tasks. [SKIPPED]
✔ Reverting to original state because of errors...
✔ Cleaning up temporary files...

✖ prettier --plugin-search-dir=. --write:
[error] No parser could be inferred for file: public/logosquare.png
src/content/blog/submitter-formdata.md 217ms
husky - pre-commit hook exited with code 1 (error)

Also it's not well documented how to add images for a blog post.

I am still getting this error

The error is triggered by Prettier that is following these rules:
https://github.com/satnaing/astro-paper/blob/08151881ccfdc447e65a0a4d28c3ce2bbb5e8e09/.prettierignore#L1-L13
Prettier is triggered upon commit by a pre-commit hook:
https://github.com/satnaing/astro-paper/blob/08151881ccfdc447e65a0a4d28c3ce2bbb5e8e09/.husky/pre-commit#L1-L4
A simple way to get rid of that, preserving the hook, is adding *.png to your .prettierignore.

Hello,
First of all, sorry for being late to resolve this issue. I've been busy for some time and couldn't focus on my open-source projects for a while.
In AstroPaper, lint-staged is triggered whenever we try to commit. Lint-staged is then configured to format (with prettier) the staged files. The error occurs because lint-staged is trying to format the staged logosquare.png which is obviously not a file to get formatted.
To resolve this issue, we can try a few ways
1) Disable lint-staged for a while when committing
We can disable lint-staged for a while by commenting out npx lint-staged inside .husky/pre-commit file. This is the easiest workaround for this kind of issue_ though this is not the real solution.
#!/usr/bin/env sh
. "$(dirname -- "$0")/_/husky.sh"

# npx lint-staged

2) Ignore public directory in prettier
We can ignore the entire public directory, where the new logosquare.png exists, in prettier. By doing so, this issue is resolves although other files like toggle-theme.js and other codes won't be formatted in the future. So, this approach is also not recommended.
3) Update lint-staged config in package.json file (Recommended)
We can format everything except images like png, jpg, webp etc in lint-staged config inside package.json. This should solve the similar problems like this in the future, and thus, this method is recommended.
Before
  "lint-staged": {
    "*": [
      "prettier --plugin-search-dir=. --write"
    ]
  }

After
  "lint-staged": {
    "!(*.{png,jpg,jpeg,webp})": [
      "prettier --plugin-search-dir=. --write"
    ]
  }

Hope this helps you in some way. I'll try to make a PR for this issue too. If you still have some problems, plz let me know. Thanks.


Scroll in circles with no recipes

If u turn on scroll in circles and have no recipes in ur book, u can do this by showing craftable only after u scroll ur game will crash if notenoughcrashes is installed after u log back into ur world all entities will be invisible
https://user-images.githubusercontent.com/92951072/138347380-89dacf51-ff9c-40ee-950e-3b4ce4ac00bf.mp4

Let me know if you have any more troubles after this patch comes out


Remove TrialModel.where_study_id.

This is a follow-up PR of #631.
This PR removes optuna.storages.rdb.models.TrialModel.where study_id. This is partly because the functionality of TrialModel.where_study_id is duplicated with TrialModel.where_study and partly because it is only used in test code.
Currently, some models in optuna.storages.rdb.models have where_study, but the others have where_study_id. I think it is helpful for developers if all the models have the same method.

There's also where_trial and where_trial_id which can be aligned as well (in some followup)?


Issue with k8s.io/docs/reference/command-line-tools-reference/kubelet-authentication-authorization/

This is a Bug Report

Problem:
Incorrect documentation for "Kubelet authentication" -- enabling apiserver client authN to kubelet.
Proposed Solution:
APIserver-kubelet-client.crt MUST contain "O=system:masters" as mentioned here - https://github.com/kubernetes/kubernetes/issues/63128#issuecomment-431277727.
Also the apiserver-kubelet-client.crt does NOT require any certificate extensions for clientAuth.
Page to Update:
The kubelet Authentication section here -
https://kubernetes.io/docs/reference/command-line-tools-reference/kubelet-authentication-authorization/#kubelet-authentication

1.15

/sig auth
/sig node
/language en

/remove-lifecycle stale


performance ?

------------------------------------------------------------
Client connecting to <IP_ADDRESS>, TCP port 5001
TCP window size: 16.0 KByte (default)
------------------------------------------------------------
[  1] local <IP_ADDRESS> port 52176 connected with <IP_ADDRESS> port 5001 (icwnd/mss/irtt=5/536/785)
[ ID] Interval       Transfer     Bandwidth
[  1] 0.0000-20.0570 sec   414 MBytes   173 Mbits/sec

heres a release build
see https://github.com/xjasonlyu/tun2socks

Please check ipstack with its examples or create some tests to measure or reproduce bugs.

  The performance issue with sending data is not difficult to fix; however, I do not have plans for it at this time. Nevertheless, pull requests are highly welcomed. As a clue, the memory allocation and management on the TCB can be improved.
https://github.com/narrowlink/ipstack/blob/main/src/stream/tcb.rs#L43-L44

Hi @SajjadPourali . I check the file tcp.rs with ChatGPT, it tells me some tips. I hope this tips is helpful.
This Rust code is an implementation of the TCP protocol,
and it appears to be complete and well-structured.
However, there are some potential issues and areas for improvement:

Handling of TCP window size: In the poll_write method,
if the size of the send window is less than half of the average send window,
or if the send buffer is full, the write operation is blocked.
This could lead to performance issues, as write operations could be unnecessarily blocked.
A possible improvement is to use a more complex algorithm
to dynamically adjust the window size to adapt to changes in network conditions.

Termination of TCP connections: In the poll_read and poll_write methods,
if a packet with the RST flag is received, or if a timeout occurs,
the TCP connection is immediately terminated and all unsent data is discarded.
This could lead to data loss.
A possible improvement is to attempt to retransmit unacknowledged packets before terminating the connection.

Establishment of TCP connections: In the new method,
if the SYN flag of the received TCP packet is not true,
a packet with the RST and ACK flags is sent and an error is returned.
However, according to RFC 793, if the SYN flag of the received packet is not true,
the packet should be ignored, not a packet with the RST flag sent.

Closure of TCP connections: In the poll_shutdown method,
if the shutdown state is None,
it is set to Pending and the poll_read method is called to read and discard all remaining data.
However, this could lead to data loss.
A possible improvement is to attempt to read and process all remaining data before closing the connection.

Here is my testing.

-----------------------------------------------------------
Server listening on 5201
-----------------------------------------------------------

Please look this discuss  https://github.com/narrowlink/ipstack/discussions/43 @SajjadPourali


Dynamically choose the appropriate library for experimental filesystem

Choose based on the compiler and standard library
Signed-off-by: Emerson Knapp<EMAIL_ADDRESS>Related to ros2/ros2#664

Full CI with all of the libcxx PRs together + a clang+libcxx on Linux run

Linux
Linux-aarch64
macOS
Windows
Linux Clang+libcxx

@nuclearsandwich can we run this one solo? it should be independently correct of the other related PRs

Linux
Linux-aarch64
macOS
Windows

The linux clang+libcxx build is blocked by https://github.com/ros2/ci/pull/260 since the mixin branch can't make use of the cached docker image.

I am not able to reproduce these errors, tried on linux and osx with the repos gist from the CI run - and I don't have access to the buildfarm to explore further - any ideas?

The previous CI issue was likely related to misusing colcon package selection for the test phase. Instead of trying to get fancy, I just enumerated packages downstream of pluginlib locally and targetd those:

Linux
Linux-aarch64
macOS
Windows

I'd like to wait to merge this until we can test that it works with other libcxx changes.

Tested in https://github.com/ros2/poco_vendor/pull/24#issuecomment-475004541. The tests are failing due to undiagnosed issues in class_loader which will be addressed in followup.


What is the project roadmap

Hi everyone, (@vinayakkulkarni )
I thank you for forking the original project and try to maintain it.
While trying to use it, I found that a lot of features from mapbox-gl are missing, reactivity is quite lacking. and some core concept seems to me a bit strange.
I'm willing to work on the lib, but I need to know if the following roadmap is acceptable to you, or if I'll have to fork the lib another time (that would be sad)

Make every options in mapbox-gl a prop in v-mapbox (some are missing, I did some PR about that), and remove unnecessary default (mapbox-gl handle default values at is level).
Make every props reactive (lots of watchers are missing).
Simplify API ( eg: MglGeojsonLayer wait for layerId prop which is not consistent with mapbox layer API, where id is a property of layer object)
refactor events to be closer to mapbox-gl genuine trigger and payload
Support mapbox-gl from V1 until V2 (pre v1 support is a possibility) & maplibre

Of course if this fork is a company project, I will understand.
But there are lots of very good intents here, that need to be pushed a bit farther to be really useful to the community.

@elmatou I'm here too to work on this. I think the original project was a great start. I just found this repo, and I'm glad to see people maintaining it. I have had to use the mapbox api more than the vue-mapbox api in the past few weeks.
For me, the first thing would be to add all of the mapbox-gl props. There are so many important ones missing (geolocate, dragEnd, and much more).
More watchers would be great, and hooks into the style.
Is this a fork for a company?

Hi @Maker-Mark,
I haven't got a response from geospoc/v-mapbox maintainer yet.
If I get no response I'm willing to fork the repo :

It would be a community driven project (I currently need to switch from leaflet for an aerial navigation soft).
I intent to stick to mapbox/maplibre API, no fancy features.

Hey @elmatou & @Maker-Mark,
I plan to maintain this project (along with some of my co–workers here at @geospoc) and upgrade it to Vue 3 (with TS) as well as keep a Vue 2.x version (with TS). Currently been really packed with personal stuff (COVID related) and work (deliveries)
I do welcome community inputs & have merged few PRs already which I believe were add–ons to the project.
I'll be creating a project boards for v2.x & v3.x of this project where v-mapbox v2.x is for supporting Vue 2.x + TS & v-mapbox v3.x will be based on Vue 3.x + TS

@vinayakkulkarni Nice, I'd love to help to maintain this repo. I'll keep an eye out for the projects. Please @ me to get me involved on a ticket. Here to help!

@vinayakkulkarni & @Maker-Mark
I'm gonna PR some stuff, as soon as we validate a roadmap,
In the mean time, I'm gonna work on missing props or feature from the official API.
 I'd prioritize documentation and implementation of the remaining methods on the wrapper. We don't have some core functionality like @geolocate and @ondragend wrapped and documented.


audiobooks: redundant affordance for previous/next audio track (same UI control as EPUB text books with spine items)

The bottom-right previous / next arrow buttons are bound to the same commands as the audio-centric button cluster rendered by the navigator.
Follow-up to PR https://github.com/readium/readium-desktop/pull/938

this was fixed recently.


NiftyNet should be able to connect to an XNAT instance to fetch data

As discussed with @atbenmurray, rather than alway working from images "dumped" in a folder, it would be great for NiftyNet to support training from data stored on an XNAT server. This will pose a number of questions related to authentication and IO bottlenecks which in the long run would need to be solved.
As a side note, I am referring to an old issue on cmiclab, #205 which had some interesting comments on IO efficiency when working with 2D images.

This is essentially a duplicate of #183.

This is actually not really a duplicate. #183 is about one-off downloading through a command-line whereas #184 is a tighter integration at the API level.


NOOS-867/add-uv-python-package-manager-on-circleci-image

Description
Add the uv python package manager to the CircleCI docker image.

JIRA Reference: NOOS-867

@zyassine For a second pair of 👁 !


Http1.1: Retain keep alive for response headers and connection keep-alive for request headers

Rely on keep-alive timeout settings from upstream server.
If upstream emits keep-alive while using http1.1, its being removed by envoy.
Hence, retain
keep-alive: timeout=x in response header..
This will help reduce load on envoy cpu as ssl connections can be reused vs creating new connections for each calls.
If  http protocol for gw<->sidecar is  h2 in case of mesh, this will not take effect even if runtime guard is true.
upstream issue https://github.com/envoyproxy/envoy/issues/17613

Fix existing UTs
Also add unit test to retain keep alive for http1.1 response header + connection keep alive in request header
Part of tests with java apps using tomcat, it relies on connection: keep-alive request header. Hence, retain the same as well for http1.1 for upstream to add keep-alive back in response header
Enable this via knob using runtime guard retain_keepalive_header_http11=true. Setting it to false will revert to current behavior

Tests with nodejs server
curl --http1.1 -kv https://foo-nodejs.com:443 | grep -i keep-al
Xxxx
* Mark bundle as not supporting multiuse
< HTTP/1.1 200 OK
Xxx
< keep-alive: timeout=5

Tests with java/tomcat as it needs connection:kee-alive
curl --http1.1 -kv https://foo-java.com:443 -H "Connection: keep-alive" | grep -i keep-al
< HTTP/1.1 404 Not Found
xxxx
< keep-alive: timeout=20

cc ptal @alyssawilk

Also cc @envoyproxy/runtime-guard-changes and @phlax @lizan PTAL/ping

Summary:
ref https://github.com/envoyproxy/envoy/pull/30621#discussion_r1441141319 ; trying request_header_to_add and response_header_to_add doesnt work because clear_hop_by_hop PR https://github.com/envoyproxy/envoy/pull/17110 removes it anyways. So ask is to make this thing work, can I amend the clear_hop_by_hop logic to not discard keep-alive if its present in response_header_to_add (just for http1.1) cc @mattklein123

ref https://github.com/envoyproxy/envoy/pull/30621#discussion_r1441141319 ; trying request_header_to_add and response_header_to_add doesnt work because clear_hop_by_hop PR https://github.com/envoyproxy/envoy/pull/17110 removes it anyways. So ask is to make this thing work, can I amend the clear_hop_by_hop logic to not discard keep-alive if its present in response_header_to_add (just for http1.1) cc @mattklein123

Yes I believe we agreed that if the connection headers are explicitly added in response_headers_to_add we will not remove them in the various functions that clean them. @alyssawilk is this correct?

Can we pick up this pr?

Can we pick up this pr?


isinstance seems to be too strict

Shouldn't this just check for numeric types? How does it check against pytensor? Is it supposed to with with pytensor?
https://github.com/wd60622/conjugate/blob/18e777335f228aeb565c41a405b0aad803eb510a/conjugate/distributions.py#L110

Seems like a good suggestion
I can make the change. I just learned about runtime_checkable with Protocol so it would work with that
https://stackoverflow.com/questions/59461689/how-can-you-test-that-a-python-typing-protocol-is-a-subclass-of-another-protocol

What is the issue to rely on dynamic typing system and remove the check at all?

What is the issue to rely on dynamic typing system and remove the check at all?

Totally, fair enough. Can go with that

The isinstance is removed


New Message go-to button does not take to the new message where the new line marker is.

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Go to the app
Go to previous chats with long conversations.
Mark Unread a message that is at the top
notice the new line marker and the New Message go-to Button appear.
click the New Message go-to button.
Notice that clicking the New Message go-to button takes you to the last message, not to the start of the new message.

Expected Result:
Clicking the New Message go-to button should take you to the start of the new message.
Actual Result:
Clicking the New Message go-to button takes you to the last message.
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.31-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/43996225/011125d2-ee3b-4ee2-ad34-adca400376aa
https://github.com/Expensify/App/assets/43996225/498d426c-b76c-4db7-80e2-e19ed0103162
Expensify/Expensify Issue URL:
Issue reported by: @daveSeife
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686595634657789
View all open jobs on GitHub

I don't think this is a bug given that we don't support bi-directional scrolling in the app, though @chiragsalian do you want to confirm my opinion on this one? I think we're touching on a long-standing feature improvement that we hope to get to before end of year.

Reached out to Chirag via DM.

Sort of, more technically the issue here is that we don't currently support comment linking so any solution here would not be a perfect solution.
This is because if onyx does not have the index and we attempt to scroll to specific index then it can break functionality and do nothing. I think we should close out this issue and then revisit this once we have implemented comment linking because at that point we should be able to scroll to a specific comment even if its not in onyx.

Cool, thanks for the gut check! I agree, closing this one out.


Expand .wallets else statement

The else statement currently links out to https://ergoplatform.org/en/get-erg/#Wallets
We can provide more information to the end user by naming and linking out to the actual wallets similar to what we do for .cex command.
Acceptance criteria

When calling the .wallets command with no modifiers...
** Section for team wallets with links to each
** Section for other wallets with links to each
** Keep the https://ergoplatform.org/en/get-erg/#Wallets links for users to learn more

https://github.com/Eeysirhc/sigmabot/commit/04729b3393323a02012e9ea1b83b3b9845357c74


It is possible to turn on and off lights with for example bat file

I want to turn on and off my strip with script file, then i would use key bindings program and use shortcuts to turn on or off my led.
Sorry for my English

It is not, but I'm considering adding a command-line interface so that this will be possible in the future. Please refer to #137 for the status on the implementation.

ok thanks. I'll be waiting :D


Themed component sass

Could you please one or more components to this sample with own sass files where we can use themed colors like:
color: theme-color-level("warn", 3)

color: theme-color("primary")

So that will be applied on theme switch as well.
Thanks

thanks for the suggestion, I'll look into it over the weekend

Looks like theme-color and theme-color-level were removed in bootstrap 5, along with some other functions: https://getbootstrap.com/docs/5.0/migration/#sass
However, all bootstrap themes also define some css variables that you can use in a component like so:
something.component.sass
.warning-border:
  border: 1px solid var(--bs-warning)

I've added a PR with a small example: #3
Let me know if that helps you.

Thank you.
Looks like the css var is only way to do that.
Although it is not supported by older browsers.


WIP: Fix 212

fixes #212
check if zsync is in the path and fallback to wget within zsync_get and list_csv

I've filed a PR against your branch - great work, I really like it!

Thanks!


[Bug] Broken Combination: Non-SGD Optimizer, tf.Variable(), and Estimator Framework

The following combination is broken when simultaneously used:

Optimizer other than SGD
Estimator framework
using tf.Variable rather than tf.get_variable
The bug might be more specific, since I am basing this directly off of the full setup found in the official resnet example in models/

I have made a 3-line modification to the official resnet example illustrate problem:
https://github.com/tensorflow/models/compare/master...liuyipei:BUG_NonSGDOptimizer_Variable_Estimator
System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow):
I can illustrate the bug with minimal change to an official example.

OS Platform and Distribution (e.g., Linux Ubuntu 16.04):
centos-release-7-4.1708.el7.centos.x86_64

TensorFlow installed from (source or binary):
Binary

TensorFlow version (use command below):
v1.10.0-0-g656e7a2b34 1.10.0

Python version:
3.4.5

CUDA/cuDNN version:
CUDA 9, cuDNN 7

Bazel version:
N/A

Mobile device:
N/A

GPU model and memory:
Nvidia GTX1080

Exact command to reproduce:

cd models/official/resnet
git remote add liuyipei git@github.com:liuyipei/models.git
git fetch liuyipei
git checkout liuyipei/BUG_NonSGDOptimizer_Variable_Estimator
python cifar10_download_and_extract.py
python cifar10_main.py

Describe the problem
Describe the problem clearly here. Be sure to convey here why it's a bug in TensorFlow or a feature request.
I changed 3 lines inside an officially supported model to illustrate my point.
https://github.com/tensorflow/models/blob/master/official/resnet/cifar10_main.py
I added a z variable. If I use tf.Variable directly, an error happens at training time.
      z = tf.Variable(0, dtype=tf.float32, trainable=True, name='tf_Variable_direct') # this fails at optimization time
      # z=tf.get_variable("tf_get_variable", [], dtype=tf.float32) #this works!
      inputs = tf.identity(inputs+z, 'final_reduce_mean')

The error is:
  File "/home/yiliu/gpuenv/lib/python3.4/site-packages/tensorflow/python/training/momentum.py", line 98, in _apply_dense
    use_nesterov=self._use_nesterov).op
  File "/home/yiliu/gpuenv/lib/python3.4/site-packages/tensorflow/python/training/gen_training_ops.py", line 634, in apply_momentum
    name=name)
  File "/home/yiliu/gpuenv/lib/python3.4/site-packages/tensorflow/python/framework/op_def_library.py", line 641, in _apply_op_helper
    "(e.g.: a tf.Variable)") % (op_type_name, input_name))
TypeError: 'ApplyMomentum' Op requires that input 'accum' be a mutable tensor (e.g.: a tf.Variable)

I have the following additional anecdotal information:

The bug does not manifest when GradientDescentOptimizer is used, presumably because it doesn't involve momentum updates.
The bug does not manifest itself when I declare the variable using tf.get_variable
I did some more digging (work not shown), but it seems to have something to do with the dtype of the object created directly by tf.Variable having dtype float32_ref after coming through optimizer.compute_gradients(loss * loss_scale) inside resnet_run_loop.py. This is unlike the other variables, which have float32 in that context. Maybe there is some kind of confusion in type checking.

Thank you for your post. We noticed you have not filled out the following field in the issue template. Could you update them if they are relevant in your case, or leave them as N/A? Thanks.
Bazel version
Mobile device

Updated as instructed @tensorflowbutler

@mrry does this count as a "framework puzzle"? Please feel free to reassign.

No, I think it's something to do with how the variable scopes are set up in that model's implementation. Assigning to @robieta, since he added that code in fbb27cf31f09c3b4b10c1e237fd283f06db301d2 (although this issue should probably move to the models repository).

Nagging Assignee @robieta: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @robieta: It has been 29 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @robieta: It has been 44 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @robieta: It has been 59 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @robieta: It has been 74 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @robieta: It has been 91 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @robieta: It has been 105 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.


Dedicated server crash: "Attempted to load class net/minecraft/client/resources/model/BakedModel for invalid dist DEDICATED_SERVER"

Starting a dedicated server with the mod installed causes it to crash during startup.
To reproduce:

Create a Forge 1.18.2 server.
Install Architect's Palette.
Start server.
Server crashes.

Versions:

Minecraft 1.18.2
Forge 40.2.0
Architect's Palette 1.3.0

Crash log: https://gist.github.com/unilock/d57b4610447e77675e5fd715f346bbc9

Ty for the speedy report. I neglected to check if the server still ran because this mod just adds blocks. New build will go out relatively soon.

The update is now released


githb action returns incorrect exit code

Noticed it here https://github.com/sequgen/sequgen/runs/2182605029?check_suite_focus=true
Apparently, the github action is looking at main branch'es README.rst, because it was deleted on the feature branch and yet it says
 It seems you have not yet added the fair-software.eu badge to your README.rst. You can do so by pasting the following snippet:

See this comment


Thank you

Thank you for such good thing, sometimes it really missing feature to tell somebody thank you :heart:

It would have been even better, if this plugin's feature came integrated with composer. So we only need to run command composer thanks if we want to.

@cpxPratik "just" needs someone to actually do it :)


HDDS-7419. Integrate the GetKeyInfo API to OFS

What changes were proposed in this pull request?
Problem
The target of this task is to deprecate the LookupFile interface and use GetKeyInfo for the OFS use case.
The gap between OFS and object storage use cases (like S3) is that due to a file system nature, OFS has to answer the file read requests from its client. A file read input is a file path and OFS needs to be able to decide if the given path is a valid file. To be specific, if the given path is not a file (but a directory), OFS should return an error. Reading empty files is a valid use case.
// throws IOException if the given path is not a file.
FileSystem.open(path)

The lookupKey API returns the same content for an empty file and directory.
Today, this is solved in Ozone by the separated lookupFile API, detecting if the given key is a directory and throwing an error on server-side.
throw new OMException(ResultCodes.NOT_A_FILE);

GetKeyInfo replaces lookupKey and inherits the same limit.
Solution
To make GetKeyInfo available for OFS, we can simply add to its response a field indicating if the key represents a directory or a file so that OFS client code can make the assertion.
https://issues.apaceorg/jira/browse/HDDS-7419
How was this patch tested?
OFS integration test.

qq: Will it work as expected if a new client connects to an old OM? I suspect this scenario wouldn't work but want to double check with you.
Thanks

Thanks for the review, @jojochuang.
So, when new clients connect to old OM, they will call the existing lookupFile API. There's a test for that in the xcompat acceptance I believe.


Update appsource-offer-publishing-guide.md

AppSource supports paid "Get it now" offers, so I have edited the documentation to reflect this change.

@MarlEva : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@ellacroi - Could you review the proposed update? Thanks.

#sign-off


Docs should recommend creating a new GCP project?

AFAICT a GCP project can only have one Oauth consent form. If another app is configured to use Oauth in a user's sole GCP project, it means Harvester would need to share that same form. This appears to be possible (i.e. you can add multiple Redirect URIs and Authorized domains), but I believe they would need to share the same user verification screen and related metadata about user policy, etc.
Might be a good idea to instruct users to create a new GCP project specifically for Harvester.

Yes this is a great point. The new version of the docs recommend creating a new project so I'm going to close this:
https://harvester.readthedocs.io/en/latest/google_credentials/#google-cloud-platform-project


Unable to install on Gray Log 3.3.8

I am unable to install the Content Pack. I can upload the json file but when I click install the content pack, i get the following error message. Tested it agains 3.3.4 and 3.3.8
Error
Installing content pack failed with status: Error: cannot POST http://X.X.X.X:9000/api/system/content_packs/35378385-0f54-4f0c-b594-db9e4b6a66f3/0/installations (500). Could not install Content Pack with ID: 35378385-0f54-4f0c-b594-db9e4b6a66f3
Any Clue what am I doing wrong here?

The Log file shows the following error message:
java.lang.IllegalArgumentException: Unsupported content pack version: 0


Add draft meta

draft meta variable should be "a mirror" of published variable: draft: true is equal of published: false.

Fixed by #233.


⚠ Secret Website 2 has degraded performance

In 9d7a05a, Secret Website 2 ($SECRET_WEBSITE_2) experienced degraded performance:

HTTP code: 200
Response time: 5268 ms

Resolved: Secret Website 2 performance has improved in ab4062e.


Workaround for a typo on the word ‘inconvenience’

Replaces #960
It's kind of a chicken and egg problem between source code and Crowdin…
I will reexport and upload to Crowdin later.

I added a quick guide here: https://github.com/ViennaRSS/vienna-rss/wiki/Updating-localizations.
Only commit the en.xliff and any Base.lproj/*.strings here. Crowdin will update the database automatically. Once the new strings are translated at Crowdin, it will send a PR with the new XLIFF files. Then we run the script to generate new *.strings files.
To fix the translation-key mismatch, you can make the changes to the localized strings, generate new XLIFF files and upload those to Crowdin yourself.


Shell not working

I built the latest master and ran using Uno. Trying to run the Shell prints this error on the command line (with no other errors in the logs):
[shell.Shell] ERROR: Path must not end with / character
Sounds like an error coming from ZooKeeper or an external library because I couldn't find that string in the Accumulo code base.

@milleruntime, check the accumulo-client.properties file in uno/install/accumulo-2.0.0/conf.  I ran into the same issue recently as well. I think It's related to the recent commit removing the use of deprecated ClientConfiguration (#412). I think if you set the username/password/instancename values in that config file things will work. They did for me. I believe Uno needs to be updated to fill in those values now that the recent update has been pushed.

The shell works if you pass all information in via the command line or use accumulo-client.properties. However, maybe this is a bug in that something is missing and a better error message should be printed.
The reason this error is occurring for you is that the shell used to get Accumulo instance information (ie. instance name & zookeepers) from the accumulo-site.xml which is bad practice.  This info now needs to be passed in on command line or set in accumulo-client.properties.  If update Uno, it will set up this file.  See commit below:
https://github.com/astralway/uno/commit/8fbe10a9cd9e12f5eca67ee09cfad62aef141eb5

Good call.  I didn't have latest Uno updates.  Closing.


CHEBI:17801, add synonym

Hello ChEBI Team,
it could be useful to add 'parapyruvate' as a synonym of CHEBI:17801 4-hydroxy-4-methyl-2-oxoglutaric acid
please see  https://pubs.acs.org/doi/10.1021/acsomega.0c00877
and  this recent publication
https://pubmed.ncbi.nlm.nih.gov/38343944/
Thank you very much,
Anne

In ChEBI, there is a clear distinction between pyruvic acid and pyruvate hence i have added the above synonym to the deprotonated entry (CHEBI:58276).


Search goes back to previous search string

Description
When I want to search for the next occurence of my last search it sometimes falls back to searching the previous input.
Steps to Reproduce

Open search with Cmd+F (or probably Ctrl+F for Windows)
Type "text1" and press Enter a few times to circle through the occurences
Exit search (ESC)
Double click on some other text, e.g. "text2"
Open search (contains "text2" now) and again press enter a few times to go to different occurences of "text2"
Exit search (ESC)
Open search -> "text1" is in search although my last search was for "text2" and the editor jumps to the next occurence of "text1" which might be wherever in the file

Expected behavior: Search input shows "text2" and editor should not jump anywhere
Actual behavior: Search input shows "text1" and the editor immediately jumps to the next occurence of "text1"
The editor obviously treats search differently depending on whether I filled the input by typing or by selecting text - I find that highly confusing.
Versions
Release 1.11 Build 1.11.0-17524 (release 86b5e2d4e)
macOS Sierra 10.12.3

This seems to not be an issue on my build...

@Badestrand Do you have extension installed? If yes can you try reloading Brackets without extensions using Debug->Reload without Extensions and check if you are seeing the issue.

@nethip Yes, I had tested it without extensions (and just to be sure tested it again right now).

#13955 seems to address the same issue.
I also updated the description -- to be super precise, there is an additional step between 6 and 7

It is really an issue, I tried it myself in MacOs, Windows and Linux and was definitely an issue and i solve it, because it was only populating the searchBar only with typed strings

@nethip can you check my pull request please?


Unable to select entity editor in outliner window

Steps to reproduce:

Create two entity editor content windows
Click the drop down menu in the outliner window

https://user-images.githubusercontent.com/2737650/214177312-b41000d5-97a2-4d70-ac6e-519b1a0f5c01.mp4

The problem is that clicking content windows causes them to become active. And a lot of content windows have handlers set to focus treeviews when the content window becomes active.

Seems like this is only an issue on mac because I can't reproduce it on linux


Is there a way to speed dotnet ?

HI,
I am using piston for Python, Java and dotnet. I noticed that in piston v3 the dotnet runtime is much mush slower.
for example running a simple Console.WriteLine takes above 6 seconds' while in python and java it takes less than  half a second...
is there a way to speed it up?

is this the public api or your own local install? a quick test of c# shows an avg execution time of about 850ms, much lower than the reported 6 seconds. you'll have to explain your environment more.

Thanks for the fast reply, here is what I found:

The differences being that using the aliases cs/csharp instead of dotnet  largely affects the time of the request


new 'summary' CLI command

The goal would be to add a new command capable of outputting a summary from a JSON file. The summary would contain the same information as in the interface (excluding maintainers).
It would also include warnings statistics and an option to show the list of warnings (filterable by kind).

hi @fraxken
In which format this summary could be? (pdf, jpg ?)

I'd say it should be in the terminal.

Ok a first version of the summary command has been merged in master. Any feedbacks are welcome.
All that's missing now is the warnings.

Ok a first version of the summary command has been merged in master. Any feedbacks are welcome.
All that's missing now is the warnings.


BIO TIME labels should not be in norms

The BIO labels generated by the time norm code should be stored in the .entities field of Sentence, not .norms. The latter is used by CoreNLP to store values of entities, e.g., "400" for the entity "four hundred", so it has different semantics, which is needed by Migration events. The TIME BIO labels should be merged with the CoreNLP labels in the .entities field.

@BeckySharp: what do you think?

Here's an example of this issue:

I agree -- until a more elegant solution, we should use Entities, since Norm will be used for things.  To note:

This likely applies to LOCATION too (@vikas95 @bethard )
If we use the entities field, we can either commandeer it or share it

if we commandeer it, we need to be careful about priority
if we share, we need to be clever...

It should be easy to switch from .norms to .entities. Who uses this info? A quick scan of usages suggests that it's only used in serialization and the webapp (and in the latter, only to display as a table). If I knew who was using it, I could make a better guess as to whether we should commandeer or share.
[Also, I need #604 merged before making any changes to geonorm, but that's failing (like most eidos commits now) because of some issue with ChunkingFeatureFactory?]

I do now: we use to understand the actual number of people who migrated. As you know, CoreNLP converts letter numbers, e.g., "four hundred", into the actual number, "400", which is stored in .norms. I use that value to count displaced people.

I meant, who uses the B-Time or LOC tags that timenorm and geonorm produce. Not who uses the .norms field.

I think he meant who uses "entities" -- it is temporarily used in the
GazetteerEntityFinder, but as long as that runs first, it should be fine
AND you can overwrite anything that the GazetteerEF added (it is only
needed internally).
this is where we call the GazetteerEF:
https://github.com/clulab/eidos/blob/e766dee9ee64686dcd6484cf5cdeab66c140c4e7/src/main/scala/org/clulab/wm/eidos/EidosSystem.scala#L230
On Wed, Jun 12, 2019 at 10:09 AM Mihai Surdeanu<EMAIL_ADDRESS>wrote:

I do now: we use to understand the actual number of people who migrated.
As you know, CoreNLP converts letter numbers, e.g., "four hundred", into
the actual number, "400", which is stored in .norms. I use that value to
count displaced people.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/clulab/eidos/issues/605?email_source=notifications&email_token=ABJCPCKTLD3MFTHJE4ZX6CLP2EUDRA5CNFSM4HXKSMY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXREDKA#issuecomment-501367208,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABJCPCKI4W7IIN5MH7UGQKDP2EUDRANCNFSM4HXKSMYQ
.

Another option, if no one is using the B-Time and LOC tags currently produced by timenorm and geonorm is to not add those at all. Given that EidosDocument already stores TimEx and GeoPhraseID objects separately, maybe there's no need to insert anything into either .norms or .entities?

Yeah, if nobody uses them, then don't add them. I agree.

Ok. I'll create a pull request that removes both of those entries from .norms once someone fixes the issue with ChunkingFeatureFactory and #604 is merged.

What ChunkingFeatureFactory issue? @kwalcock: do you know about this?

All our builds are currently being marked as failing, and they stop right after ChunkingFeatureFactory: https://travis-ci.org/clulab/eidos/builds. Perhaps this is just a configuration issue, and the builds shouldn't be running on Travis at all. But all our commits and pull requests are failing according to to GitHub because of this issue.

This is the first time I've encountered ChunkingFeatureFactory.
Not having the BIO-Time tags sounds good to me because there is an issue with them adequately reflecting the complicated, overlapping time expressions that are found.  See issue #588 and PR #579

Please ignore the Travis output.  If Jenkins passes, that's good.  If Jenkins doesn't even run, then the branch needs some updating.  Travis integration will probably be removed very soon.  Thanks.

Ok, great. Then I will address this after #604 is merged.

the labels produced by the neural models are used to make Location and Time mentions, I am not sure if they're used at one point in the creation of the Time and Geonorm objects...

Could you point out where they are used to make Location and Time mentions? I couldn't find that, but I did find where they are used to attach times and locations to entities:

org/clulab/wm/eidos/english/grammars/temporalAttachment.yml
org/clulab/wm/eidos/english/grammars/geoLocationAttachment.yml
For those cases, is there a reason we use a token-level search, rather than looking for the Location and Time mentions? This is probably my naiveté in how Eidos code and the grammars interact with each other.

now we are going to be doing just that, but in a newer branch. It wasn't done previously and wasn't an issue until we needed to have mentions for time and location (for the migration events).  but now we do so we will be...
now, mentions will be made here:
https://github.com/clulab/eidos/blob/migration_schema-zupon/src/main/resources/org/clulab/wm/eidos/english/grammars/context.yml
and referenced in

org/clulab/wm/eidos/english/grammars/temporalAttachment.yml
org/clulab/wm/eidos/english/grammars/geoLocationAttachment.yml

(i.e., https://github.com/clulab/eidos/blob/e902f6cd5b1a65036106de88c604428712736344/src/main/resources/org/clulab/wm/eidos/english/grammars/geoLocationAttachment.yml#L10 )

but we still need a token match to make the mentions, or else they can be made outside of the main extraction process and used to initialize the state.  That's fine too, but then the neural guys would have to make Mentions.

If you can tell me how to make an appropriate Mention object, I can do it in the appropriate places instead of adding to .norms:
https://github.com/clulab/eidos/blob/geonorm-tensorflow/src/main/scala/org/clulab/wm/eidos/document/EidosDocument.scala#L164
https://github.com/clulab/eidos/blob/geonorm-tensorflow/src/main/scala/org/clulab/wm/eidos/document/EidosDocument.scala#L190

@BeckySharp ?

I dont know if this is the way to go... is there a reason you opted to not
use the entities?
If you need to make mentions, I can think about a nice way to do it, but
it’ll take a little thought
On Wed, Jun 12, 2019 at 6:14 PM Mihai Surdeanu<EMAIL_ADDRESS>wrote:

@BeckySharp https://github.com/BeckySharp ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/clulab/eidos/issues/605?email_source=notifications&email_token=ABJCPCOFRCB5BQ2BWEDV6KDP2GNNHA5CNFSM4HXKSMY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXSHGFA#issuecomment-501510932,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABJCPCOSELKJFQ3EORECNMDP2GNNHANCNFSM4HXKSMYQ
.

If you're asking why we used .norms instead of .entities, I'm pretty sure it's because someone at the WM meeting suggested .norms to us and not .entities. There's certainly no principled reason.
But either of these seem like a hack: we already have the information needed to create an appropriate Mention, but we're decomposing that into token-level tags instead of using it directly. I don't know enough about Odin to understand what's easy or hard in the framework, but at least conceptually it seems odd to start from a mention-like object, and convert it into token-level objects, just so that it can be reconstructed into a mention object.

Ok, I’ll think about it and try to figure out a clean way to make them, but
using the entities field would prob work just fine
On Wed, Jun 12, 2019 at 8:17 PM Steven Bethard<EMAIL_ADDRESS>wrote:

If you're asking why we used .norms instead of .entities, I'm pretty sure
it's because someone at the WM meeting suggested .norms to us and not
.entities. There's certainly no principled reason.
But either of these seem like a hack: we already have the information
needed to create an appropriate Mention, but we're decomposing that into
token-level tags instead of using it directly. I don't know enough about
Odin to understand what's easy or hard in the framework, but at least
conceptually it seems odd to start from a mention-like object, and convert
it into token-level objects, just so that it can be reconstructed into a
mention object.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/clulab/eidos/issues/605?email_source=notifications&email_token=ABJCPCOPHJTE2F74HJDO4ALP2G33DA5CNFSM4HXKSMY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXSMPQQ#issuecomment-501532610,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABJCPCLWVHMDEQHNYER7WDLP2G33DANCNFSM4HXKSMYQ
.

Hey -- I can't think of a clean way to make them without tagging the sentence twice.  Basically, entities are made with entity finders or in the primary grammars.  The neural model is run on the document at a different time.  IDK if the timenorm (and geonorm) structures already stored in EidosDocument are sufficient to create a mention, if they are (or could be), this is how you'd make a TextBoundMention:
https://github.com/clulab/processors/blob/5c61f03d08bfe7ccc956089301341d1afeca613e/odin/src/main/scala/org/clulab/odin/Mention.scala#L195
The label would be "Time" or "Location"
The foundBy would be something informative like "TimeNormEF" or something...
and then you'd do the mention-making with a custom EntityFinder (extends Finder), here are 2 examples:

GazetteerEntityFinder
RuleBasedEntityFinder

alternatively you can just use the entities field and make sure you don't get overwritten.

Yes, we already have all the information needed to create a mention at the time that we're currently injecting the information into .norms. So a custom Finder that creates TextBoundMentions instead sounds like the right thing to do. If I'm reading the interface right, we would just take the current parseGeoNorm code, put it in a Finder, generate the new TextBoundMentions  and add them to the State using the .updated method. Does that seem about right?

Almost -- I'm hoping you can do it in 2 steps because currently we run the sentences through the NN as a step in the annotate method of EidosSystem (called here).  Then, all the elected entity finders are called here, with an api that takes a Document (which can be an EidosDocument btw) and returns a Seq[Mention].  the "adding to the state" is done in the same step for all entity finders, here.
So, if you can use the extra content of the already-annotated EidosDocument to make the mentions, we won't have to change the APIs (if that makes sense), unless I'm missing something obvious and easier.

Thanks for the pointers. I'll give this a try once the geonorm-tensorflow branch is merged.

👍 let me know if you need anything!

I'm getting to that merge very soon.

No rush. I'm working on several other things too.

I'm working on this now. Where is the piece of grammar that links locations to entities tested?
I've removed the "LOC" entries from .norms in my current work-in-progress, but this doesn't cause TestDoc3 Paragraph 4 to fail like I thought it would.

indirectly, where you think, e.g., places like here
If you are already adding mentions with an entity finder then I would expect anything to fail, perhaps to duplicate (or maybe not)

Thanks. I managed to get the test to fail as I believe it should with no "LOC" in .norms. What do I need to replace [norm="LOC"] [norm="LOC"]* with if I want to match a "Location" TextBoundMention instead?

Thanks.  I was looking to see how it could still pass without a LOC, but it sounds like there may have been a LOC still there.

I take back my "managed to get the test to fail" comment. TestDoc3 Paragraph 4 is still passing on my machine despite deleting the .norms stuff and not having made any changes to the grammar. If @BeckySharp or @kwalcock could take a look at that commit on the geonorm-finder branch and help me understand why that test isn't failing, I'd be grateful.

Yes, and thanks for the branch.  It may well be that something was overlooked.

Thanks. I managed to get the test to fail as I believe it should with no "LOC" in .norms. What do I need to replace [norm="LOC"] [norm="LOC"]* with if I want to match a "Location" TextBoundMention instead?

If you're replacing it in a trigger field -- I think you'd replace trigger = .... with trigger: Location
If it's in a surface pattern, you'd replace it with @Location
Let know if that doesn't work

Just now it is looking like there is an attachment on the mention foundBy = "org.clulab.wm.eidos.context.GeoNormFinder++gazetteer++simple-np++quantification2++Increase_adjective_rule_1"

And useTimeNorm and useGeoNorm are both on, despite one having been removed from eidos.conf.  The one comes from
def useGeoNorm = ieSystem.loadableAttributes.entityFinders.collect{ case f: GeoNormFinder => f }.nonEmpty

So is the question, why is GeoNormFinder finding what is tested for?  I'm not sure about that.

It looks like useGeoNorm is in both GraphTester and in TestUtils as well as EidosSystem and some configuration files.  The value might not have the expected value.

I did check that by printing it out in the test file, and useGeoNorm was true (which it would need to be for the tests to fall). Is it printing false for you?

My theory is that it might be passing for you because useGeoNorm is off and it is skipping the test.  Are you observing that variable in NodeSpec.matchAttachments (GraphSpec.scala line 271)?

I was printing out tester.useGeoNorm here:
https://github.com/clulab/eidos/blob/master/src/test/scala/org/clulab/wm/eidos/text/english/eval6/TestDoc3.scala#L129

The way I got it to fail was to turn off the geonorm entityFinder in englishTest.conf: entityFinders = ["gazetteer", "rulebased"] completely.  This will unfortunately also turn off the tests for geonorm.  Then I hard-wired useGeoNorm to true in EidosSystem.scala, GraphTeste.scala, and TestUtils.scala where we've got some duplicated code.  In your branch it looked like the geonorm entityFinder was active and the tests for geonorm were being performed and passing.

My understanding is that the tests should also fail when the GeoNormFinder is included and useGeoNorm is true, because my branch has not corrected the grammar at all. So I'm looking to make it fail not when the GeoNormFinder is removed, but when the GeoNormFinder is included.

OK.  The GeoLoc("Greater Equatoria") is being found, though.  If it eventually doesn't get found, either because of uncorrected grammar or disabling the GeoNormFinder, then then test does seem to fail.  I had to use the latter method.  That doesn't help you much, though.  The test is not somehow stuck on passing only.

Does it pass if you comment out this rule:
https://github.com/clulab/eidos/blob/8c6354d612ed21a7c48f6f57bb19ffb4d821b701/src/main/resources/org/clulab/wm/eidos/english/grammars/geoLocationAttachment.yml#L5
?
On Fri, Jun 21, 2019 at 12:16 PM Keith Alcock<EMAIL_ADDRESS>wrote:

OK. The GeoLoc("Greater Equatoria") is being found, though. If it
eventually doesn't get found, either because of uncorrected grammar or
disabling the GeoNormFinder, then then test does seem to fail. I had to use
the latter method. That doesn't help you much, though. The test is not
somehow stuck on passing only.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/clulab/eidos/issues/605?email_source=notifications&email_token=ABJCPCO6IOM23ULQQEDNYEDP3USG7A5CNFSM4HXKSMY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYJLJMQ#issuecomment-504542386,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABJCPCJZOYT37NFKHUWGKOLP3USG7ANCNFSM4HXKSMYQ
.

I commented out import: org/clulab/wm/eidos/english/grammars/geoLocationAttachment.yml etc. in master.yml. The tests still pass. Is there anywhere else in the code that could be attaching Location mentions to Entity mentions?

if you look at the foundBy field of the Location mentions themselves,
what does it say?
On Fri, Jun 21, 2019 at 1:47 PM Steven Bethard<EMAIL_ADDRESS>wrote:

I commented out import:
org/clulab/wm/eidos/english/grammars/geoLocationAttachment.yml etc. in
master.yml. The tests still pass. Is there anywhere else in the code that
could be attaching Location mentions to Entity mentions?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/clulab/eidos/issues/605?email_source=notifications&email_token=ABJCPCJUPF37QFQZNKUXDT3P3U443A5CNFSM4HXKSMY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYJRPHI#issuecomment-504567709,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABJCPCMXMFLGP66GUQ4GXQTP3U443ANCNFSM4HXKSMYQ
.

As per Keith's comment, you can see the new Finder is filling foundBy with org.clulab.wm.eidos.context.GeoNormFinder. But the issue is not finding the Location mentions; I'm creating those, so I know how they're appearing. What I don't know is how they're getting attached to the causal events.

@BeckySharp and I met and discussed the issue. Because all of our tests are for cases where the Location is within the text of the (expanded) entities, and because Eidos has special code to automatically copy attachments from other mentions within an entity mention, no additional grammar rules are needed to attach the locations to the entities. That is, once we change from modifying .norms to creating actual Location mentions with a Finder, there is no need for any grammar rules.
(For now at least; if we want to attach Locations that are not within the entities, we will need to add grammar rules for that. But I think we should not add any rules until we see some actual language where Locations are not within the entities but still need to be attached.)

Reopening this issue, since the TIME labels are still in norms. I've started work on converting timenorm to a Finder like I did for geonorm, and I've linked the branch with those changes to this issue.
I don't know how to update the rules to deal with mentions instead of norms. For example, here's a failure that I'd like to correct, where the Time is being found, but not attached, but even after looking through the Odin manual, I have no idea how to fix the rule in temporalAttachment.yml.
[info] TestDoc3 Paragraph 9
[info] - should have correct edges 1
[info] - should have correct edges 2
[info] - should have correct edges 3
[info] - should have correct edges 4
[info] - should have correct edges 5 *** FAILED ***
[info]   List("Could not find EdgeSpec [Rainfall|+QUANT(moderate to heavy)+TIME(coming weeks)]->(Causal)->[rainfall deficits|+DEC(deficits)+DEC(erase)]", "Mentions:
[info]   0: Rainfall Quantification(moderate to heavy,None)
...
[info]   12: coming weeks Time(coming weeks)

Also, I see some places where the test is failing, but the test output makes it seem like everything is attached correctly. What am I missing?
[info] TestDoc2:
[info] TestDoc2 Paragraph 1
[info] TestDoc2 Paragraph 2
[info] - should have correct singleton node 3
[info] - should have correct singleton node 4 *** FAILED ***
[info]   List("Could not find NodeSpec [level of food insecurity this year|+QUANT(unprecedented)+TIME(this year)]", "Mentions:
...
[info]   7: this year Time(this year)
[info]   8: level of food insecurity this year Quantification(unprecedented,None), Time(this year)

I'll check out the second one.

It looks to me like the problem is that useTimeNorm is false.  In EidosSystem I think it needs
  def useTimeNorm: Boolean = loadableAttributes.entityFinders.collectFirst{ case f: TimeNormFinder => f }.isDefined

When we recently started turning these on and off we didn't not make it flexible enough to do both.  If it is off, the TimEx("this year") should be removed.  I should program it so that it is automatically ignored.

Of course! I forgot to delete LoadableAttributes.timenorm. Yes, deleting that and changing useTimeNorm as you indicated fixes the tests that do not need grammar-based attachments.
@BeckySharp: Any examples you can point me at for how to write a grammar rule that connects a Time Eidos Mention to an Entity Eidos Mention in whatever way it needs to be connected?


MM-10040: Fix ALT+UP/ALT+DOWN channel switch

Summary
Fix ALT+UP/ALT+DOWN channel switch
Ticket Link
MM-10040
Checklist

[x] Ran make check-style to check for style errors (required for all pull requests)
[x] Ran make test to ensure unit and component tests passed

If this is for 4.9, then this needs to change base branch to release-4.9.

You are right.

Done


install ucsc chainnet on main

TODO: Please replace this header with a description of your pull request.
Installation sequence for tool-installers

[ ] Test using @galaxybot test this
[ ] Inspect CI output for expected changes
[ ] Deploy using @galaxybot deploy this if test install was successful
[ ] Merge this PR

@galaxybot deploy this

this does not seem to be installed on Main :/


Not compiling with use_modular_headers! flag in PodFile

Undefined symbols for architecture arm64:
"OBJC_CLASS$_FLEXManager", referenced from:
objc-class-ref in MyViewController.o
ld: symbol(s) not found for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
Cocoapods 1.5.3
Not using use_frameworks! flag according to the new convention.

you can add debug
#ifdef DEBUG
#import <FLEX.h>
#endif

you can add debug
#ifdef DEBUG
#import <FLEX.h>
#endif

you can add debug fix the problem.
#ifdef DEBUG
#import <FLEX.h>
#endif
#ifdef DEBUG
[[FLEXManager sharedManager] showExplorer];
#endif

Can you provide and upload a simple repro case?

Steps to reproduce:

Remove the use_frameworks! flag from Podfile
pod install
Build your project

You will see an exception in the linking step.

Thank you! I will look into this

I believe this is no longer an issue as of some more recent versions of FLEX, but please let me know if the issue persists.


Delete all user group members if user is deleted

Alternative Fix for issue 2398
TDD , test first

dicussed yesterday

@torsten-sap @tack-sap any thoughts from SAP side to fix issue https://github.com/cloudfoundry/uaa/issues/2368 with this PR or the other one? this here would be without disruption


Connection reset by peer on get requests

In making a request to a third party resource, https://www.henryscheinvet.com, I am getting the following traceback:
import requests; requests.get('http://www.henryscheinvet.com')

Traceback (most recent call last):
 (......traceback.....)
  File "/Users/python3.4/site-packages/requests/adapters.py", line 415, in send
    raise ConnectionError(err, request=request)
requests.exceptions.ConnectionError: ('Connection aborted.', ConnectionResetError(54, 'Connection reset by peer'))

For reference, I am on python 3.4.3, using requests 2.7.0, and running on Mac 10.9. What is very strange about this issue in particular is that the same call works if i run 'curl -i https://www.henryscheinvet.com' or if I access the URL using a browser. I believe it has something to do with the SSL handshake

Yeah, connection reset by peer means the remote peer doesn't like the TLS handshake much. It's difficult to know without tcpdumping what the problem is here. I don't see the problem on my end though: do you have PyOpenSSL installed?

It was an issue with the SSL certificate on their site, which has since been resolved. Thanks!


UI enhancements for the Cluster Server Details page

The new page Cluster Server Details will be released soon and I create this ticket for further trivial enhancements for a better user experience.

Now:


docs: circuits, glossary, intro

Description
Minor improvements and cleanup in circuits, glossary, and what is semaphore.
Related Issue

Other information

@cedoor Please review and merge if approved.


Tesla Authentication Changed (January 2021) - Does TWCManager Support?

Hi. I'm about to embark on setting up TWCManager. I have an unrelated Node-Red flow that interogates the Tesla API. I see that Tesla has recently (late January 2021), changed the authentication routine that broke a couple of Node-Red modules.
https://tesla-api.timdorr.com/api-basics/authentication
Will TWCManager be updated to manage the new authentication routine? I assume with a broken authenication routine, the ability to start and stop charging will be lost in TWCManager? Will charge rate control still be available?

I just got bitten by this and had the car draw 16kW during what would have been peak time, if I was on a time-of-use plan.
These are the relevant commits in TeslaJS that fixed it for NodeRed:
https://github.com/mseminatore/TeslaJS/commit/e95e896e21132d8921b8d2e435099227d1562310
https://github.com/mseminatore/TeslaJS/commit/e8ff2d51f63bd73f7892487cdc20c93fe79f5fe9
https://github.com/mseminatore/TeslaJS/commit/027795fe4040309330e052094e57183e0e5ed568
For now, I'm working around it in Node-Red, which already controls a few other things for me, like disabling sentry mode if the car is in the garage, and the maximum charge level (less for daily charge, more if I'm not home)

There is also this fork of TWCManager that has incorporated the new authentication (excluding Multi-Factor Auth) -
https://github.com/ngardiner/TWCManager
https://github.com/ngardiner/TWCManager/issues/157


Clarify that a Qualifying Audit is needed.

The current language suggests that a Qualified Audit is needed. According to
ISAE 3000 and the WebTrust International Reporting under ISAE3000, the term
Qualified has a different meaning within the context of Audits. This commit
clarifies that a Qualifying Audit is needed, according to the requirements
stated in https://aka.ms/auditreqs.

#label:"awaiting-product-team-response"

PMs approved change. Taking to private repo to resolve merge conflict.


Package updates but never moves past 3.4.2

When running an update in the Foundry web interface, VTTInlineWebviewer always updates but never actually moves from 3.4.2 to 3.4.3. I don't know if it's a module problem or a Foundry problem, but this is the only module that this happens with so I lean towards it being the module.
Foundry 10 build 291 (latest) on a RHEL 9.1 server.
Screenshot: https://i.imgur.com/KydIdio.png

Can confirm. Same experience here (Running felddy's Docker instance on a Debian system) in both Foundry 10 and 11. Uninstalling the module and then reinstalling resulted in a reported InlineWebViewer 3.4.2 being installed (Which updates to 3.4.2 every time I check for updates, same as before.)
I'm wondering if the installed version is actually 3.4.3 and it's just reporting its version number wrong, resulting in it being re-downloaded every time an update check is made?

I think it is caused because in module.json file the  'download' field links to 3.4.2 release file, instead of 3.4.3. So it is 3.4.2 what is always installed.


[Bug]: Shopify CLI error - Themes and wdm

Please confirm that you have:

[X] Searched existing issues to see if your issue is a duplicate. (If you’ve found a duplicate issue, feel free to add additional information in a comment on it.)
[X] Reproduced the issue in the latest CLI version.

In which of these areas are you experiencing a problem?
Theme
Expected behavior
To load up my local theme in the CLI
Actual behavior
Console error and an unusable CLI
Stack trace
$ shopify theme dev --store STORENAME.myshopify.com
┏━━ Viewing theme… ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
┃ * Syncing theme #136600682722 on STORENAME.myshopify.com
┃                                                                           100%
┃
┃ Serving .
┃
┃ Please open this URL in your browser:
┃ http://<IP_ADDRESS>:9292
┃
┃ Customize this theme in the Theme Editor, and use 'theme pull' to get the changes:
┃ https://STORENAME.myshopify.com/admin/themes/136600682722/editor
┃
┃ Share this theme preview:
┃ https://STORENAME.myshopify.com/?preview_theme_id=136600682722
┃
┃ (Use Ctrl-C to stop)
┗━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ (2.94s) ━━━
[Note] You cannot use gems with Shopify CLI.
[LoadError] cannot load such file -- wdm
       They are disabled.
       Please don't modify the CLI locally.
       If you would like to contribute to the CLI project, please refer to
       https://github.com/Shopify/shopify-cli/blob/main/.github/CONTRIBUTING.md

  Please add the following to your Gemfile to avoid polling for changes:
    gem 'wdm', '>= 0.1.0' if Gem.win_platform?

Reproduction steps

$ shopify theme dev --store STORENAME.myshopify.com
enter
stress

Operating System
Windows 11
Shopify CLI version (check your project's package.json if you're not sure)
3.23.0
Shell
bash
Node version (run node -v if you're not sure)
v16.15.0
What language and version are you using in your application?
Liquid

Hi @AaronGabriel147 -- thanks for flagging. Have you tried to uninstall the wdm gem and then try?

Hi @AaronGabriel147 -- thanks for flagging. Have you tried to uninstall the wdm gem and then try?

@shauns
Ok I just removed wdm and I get the same exact error stating that I still have wdm.
I entered this command:  "gem uninstall wdm"

UPDATE, I just spend another 8 hours working on this bug... I ended up reformatting my PC and now everything works. Shopify CLI has been a nightmare, slow and buggy dev environment.

Hello i am experiencing the same issue, here is everything that happens with --verbose on. I have uninstalled wdm, deleted some files in appdata/local and appdata/roaming, which persisted after uninstall, before installing again, but the error is still there.

I have been working on this for a week. Nobody seems to know. Consider reformatting your PC. That was the only thing that worked for me. I may have to buy a Mac because of Shopify CLI. I still get the same error after the reformat, but everything seems to work now (before all worked except for my local shopping cart, which is crucial to test before and after every commit). Well, hotload is hit or miss.

A quick update -- this is something being actively looked into. We'll have an update as soon as one is available. I'm sorry that this has been disruptive for you.


An initial go at Python Support

This attempts to solve GH-49. It adds python support via behave
only. This is still a WIP. The tests pass but after building with
changes in language-server and vscode, functionality in real world
applications is severely diminished. Go To Definition and Autocomplete
are currently missing.

🤔 What's changed?
There is python support via the behave library
⚡ What's your motivation?
Fixes #49
🏷 What kind of change is this?

:zap: New feature (non-breaking change which adds new behaviour)

♻ Anything particular you want feedback on?

The tests currently pass.  Functionality in an editor (testing with vscode) is however extremely broken, providing no go to definition or autocomplete.
📋 Checklist:

[x] I agree to respect and uphold the Cucumber Community Code of Conduct
[x] I've changed the behaviour of the code

[x] I have added/updated tests to cover my changes.

[ ] My change requires a change to the documentation.

[ ] I have updated the documentation accordingly.

[x] Users should know about my change

[x] I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

As discussed - here is how Cucumber Expressions for Java decides whether an expression string should be interpreted as CukeExp or RegExp: https://github.com/cucumber/cucumber-expressions/blob/main/java/src/main/java/io/cucumber/cucumberexpressions/ExpressionFactory.java

Hi @mrkaiser , I will reach out to you on the cucumber Slack... ping blaise if you have a chance because I didn't find you in the Slack channel.


[Windows] Replace misleading mingw version in software report

Description
There is a line in software report currently that states for mingw version, but in fact it represents version of gcc instead of mingw. This sometimes causes confusion and misunderstanding. This PR replaces line mentioned with some more specific.
Related issue:
Check list

[ ] Related issue / work item is attached
[ ] Tests are written (if applicable)
[ ] Documentation is updated (if applicable)
[x] Changes are tested and related VM images are successfully generated

/azp run windows2019,windows2022


Do not set cookie policy "SameSite=None" for known incompatible clients

If an incompatible clients is detected via the user agent the policy "SameSite=None" is not set. See the documentation found here: https://www.chromium.org/updates/same-site/incompatible-clients
This small library is used for the detection of unsupported user agents: https://github.com/thedocs-io/cookie-same-site-none
I'm willing to port the functionality of this library into a cas internal utility class if we don't want to add the dependency.

Thank you very much for the patch.
As I understand, most of the incompatibilities go back to very old versions of Chrome, Safari or other types of embedded browsers. None of these are things we'd want to support, or maintain. If you are affected by this case, it would be best to either upgrade clients, or keep the patch as a custom change.
Thank you!


Write report and handin

Todos for writing report:

[ ] Add results and discriptions
[ ] Read papers about grokking
[ ] Give an explanation of grokking

Todos for handin

[ ] Add more information in README
[ ] Finish template.jsonc
[ ] Rerun all configurations to make sure they are reproduceable and not broken
[ ] Make sure there's no TODO, FIXME and commented code

Related papers:
https://proceedings.neurips.cc/paper_files/paper/2022/file/dfc310e81992d2e4cedc09ac47eff13e-Paper-Conference.pdf

吴磊大作 https://arxiv.org/pdf/2407.12332


Top view of lifetime select component is hidden by message area

Description
some part of lifetime select component is hidden by message area
Screenshots

Additional information
No response

Hi,
You can assign this to me, I am working on it.

Hi. Thank you. What browser are you using as this goes upwards and not downwards.
Assigned it to you.

I have checked on chrome and edge, if enough is there it opens at bottom else top


[libjxl] Fix Pkgconfig files are totally broken on x64-windows-static triplet

Fixes https://github.com/microsoft/vcpkg/issues/33390
Fix the inconsistency between the name of the link library and the name of the compiled library in the PC file under static compilation

[X] Changes comply with the maintainer guide
[ ] SHA512s are updated for each updated download
[ ] The "supports" clause reflects platforms that may be fixed by this new version
[ ] Any fixed CI baseline entries are removed from that file.
[ ] Any patches that are no longer applied are deleted from the port's directory.
[X] The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
[X] Only one version is added to each modified port's versions file.

Usage test pass with following triplets:
x64-windows
x64-windows-static

Does this PR remove the -static suffix? If no, I propose to do so. Use case: in a client app I do find_library(jxl) and it fails with the x64-windows-static triplet as libjxl adds that -static suffix to the libraries. I don't really know why people keep renaming their libs in static mode, it's a totally annoying mess :confused: :confused:

Does this PR remove the -static suffix? If no, I propose to do so. Use case: in a client app I do find_library(jxl) and it fails with the x64-windows-static triplet as libjxl adds that -static suffix to the libraries. I don't really know why people keep renaming their libs in static mode, it's a totally annoying mess 😕 😕

This patch fixes the problem that the static library cannot be found when using PC files because the generated library name is inconsistent with the name called in the PC file. If called using the find_package method, it works fine.

If called using the find_package method, it works fine.

How exactly do you use find_package in a client app to find libjxl? What vcpkg triplet do you use?

@jimwang118 How exactly do you use find_package in a client app to find libjxl? What vcpkg triplet do you use?

You can call this lib using the following method.
set(PKG_CONFIG_EXECUTABLE "${VCPKG_INSTALLED_DIR}/x64-windows/tools/pkgconf/pkgconf.exe")
find_package(PkgConfig REQUIRED)
pkg_check_modules(libjxl REQUIRED IMPORTED_TARGET libjxl)
target_link_libraries(main PRIVATE PkgConfig::libjxl)

Oh, I see. It's pkg_check_modules, not find_package. I hoped you found a mysterious way to use it without pkg-config 🙂

Please also change the vcpkg.json file.


Put quotes around variables where necessary.

Part 5 of #2463
To make the changes easier to review and to spot any potential mistakes (since ShellCheck sometimes has false positives), I am releasing these changes incrementally.
I intentionally ignore variables that are meant to be arguments or lists because when enclosing them in quotes, things break. They are false positives and we need an inline comment to suppress the warning.

This change is

@remyabel can you rebase when you get a chance?

Should that be "${BINDIR}/check-include-guards.gawk" in case BINDIR ends with a space?

It seems to me that it doesn't matter.
Something can be said for just quoting the unknown part, and something can be said for simply quoting the whole thing.  I guess just being consistent is the best path.

I implemented your suggestions and now one of the tests is failing:
./table_admin_snippets check-consistency project-20171-1366 in-19042-32397 sample-table-for-admin-1620
TokenFor-projects/project-20171-1366/instances/in-19042-32397/tables/sample-table-for-admin-1620
Standard C++ exception raised: CheckConsistency(name=projects/project-20171-1366/instances/in-19042-32397/tables/sample-table-for-admin-1620) token "\nTokenFor-projects/project-20171-1366/instances/in-19042-32397/tables/sample-table-for-admin-1620" not valid

Either I made a typo somewhere or we've exposed a bug. For some reason the token has a newline in it.

For now I've trimmed the newline. I (or someone else) can figure out why the generated token has a newline in it later. PTAL.

@remyabel when you have a chance, please rebase and remove the conflicts.

Sigh. We hit a edge case. According to StackOverflow, set -u doesn't like empty arrays on older versions of Bash. Unless there's any objections, I'll add the workaround "${cmake_extra_flags[@]+"${cmake_extra_flags[@]}"}" with a comment explaining what it means.

Ugh... @devbww ?

Ugh ... yes, but I'm happy with the workaround.
Alternatively, can we use bash 4.4?

Alternatively, can we use bash 4.4?

I would prefer if we did not. Upgrading stuff on the supported distributions to get the code to compile feels like cheating.  And the users may want to run the tests on their preferred platform.

Codecov Report

Merging #2476 into master will decrease coverage by <.01%.
The diff coverage is 94.28%.

@@            Coverage Diff            @@
##           master   #2476      +/-   ##
=========================================
- Coverage   93.01%     93%   -0.01%
=========================================
  Files         314     314
  Lines       19992   20027      +35
=========================================
+ Hits        18595   18627      +32
- Misses       1397    1400       +3

Impacted Files
Coverage Δ

google/cloud/bigtable/instance_admin.h
100% <ø> (ø)
:arrow_up:

google/cloud/bigtable/instance_admin.cc
97.29% <100%> (+0.11%)
:arrow_up:

...bigtable/examples/instance_admin_async_snippets.cc
84.65% <89.47%> (+0.53%)
:arrow_up:

...storage/benchmarks/storage_throughput_benchmark.cc
82.85% <0%> (-0.36%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0de9566...77be033. Read the comment docs.

Re: upgrading bash... fwiw, bash 4.4 was released in early in 2016 (https://ftp.gnu.org/gnu/bash/), so it's pretty old. bash 5.0 is current. What version of bash are our tests running with, and where are they picking it up?

Re: upgrading bash... fwiw, bash 4.4 was released in early in 2016 (https://ftp.gnu.org/gnu/bash/), so it's pretty old.

In the "Real World":tm: 2016 is not "pretty old", it is "we are just starting to look at it".
CentOS 7 which is supported by GCE, was released in 2014, it goes EOL in 2020 (if we are lucky).  Ubuntu:16.04 was released in 2016, it goes EOL in 2024.
The timescales to support enterprise are loooong.

bash 5.0 is current. What version of bash are our tests running with, and where are they picking it up?

We compile and run the tests on a lot of distros, and the the builds pick up bash from whatever comes with the distro. So the short answer is "it depends", but a sample:

Distro
Bash Version

Centos:7
4.2.46

openSUSE:Leap
4.4.23

Ubuntu:14.04
4.3.11

Ubuntu:16.04
4.3.48

BTW, you can just use commands like this to figure out what comes with the OS:
docker run centos:7 /bin/bash --version

CentOS 7 which is supported by GCE, was released in 2014, it goes EOL in 2020 (if we are lucky).

It's actually CentOS 6 that goes EOL in 2020. CentOS 7 (what we're targetting) will go EOL in 2024. The rest of your explanation is still valid, of course.

Re: upgrading bash... fwiw, bash 4.4 was released in early in 2016 (https://ftp.gnu.org/gnu/bash/), so it's pretty old.

These older versions of bash will receive security/maintenance patches and the like which a custom-install of Bash would not receive.

Ok, I'm sold on not upgrading bash. Thanks

@remyabel thanks for these fixes.


Add BD_Omega as code in useful_functions

Since many users will be interested in calculating band depths, it would be nice to include this as a function that can be imported rather than just in the documentation.

Indeed, I've added the BD_omega function in omega_data so it can be called with od.BD_omega with commit 32f5e911b7b5a149c9a2fbfaf6906050e4a58c43, also deployed with version 3.0.5.
And the documentation has been updated accordingly with 6cffa4c9debc5bfcedc3c26839dd2eecb5106598.