TagBot trigger issue

This issue is used to trigger TagBot; feel free to unsubscribe.
If you haven't already, you should update your TagBot.yml to include issue comment triggers.
Please see this post on Discourse for instructions and more details.
If you'd like for me to do this for you, comment TagBot fix on this issue.
I'll open a PR within a few hours, please be patient!

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/27618

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/27618

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/27803

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/27803

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/27963

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/27963

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/28615

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/28615

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/29189

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/30859

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/31106

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/32055

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/32057

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/32065

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/32250

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/32710

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/32769

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/46645

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/68446

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/70068

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/71155

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/71472

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.


kvrocks docker can use environment variables define config

fix https://github.com/apache/incubator-kvrocks/discussions/848

I think, if we want to support command line options for configurations, we need to implement it in a more direct way, rather than sed, which is more like a workaround.

I think, if we want to support command line options for configurations, we need to implement it in a more direct way, rather than sed, which is more like a workaround.

I agree with this, but I'm not familiar with C code and don't know how to modify it.
Generally speaking, if you not using docker, there is no need to configure in this way.
I created my own version of docker usertax/kvrocks for easy to use now

Hi. I find Macos does't support realpath. I have submitted a patch to you. And I feel that two run(run.sh and _run.sh) are a little strange. Can these two run be combined into one?@usrtax

@tanruixiang I suggest we focus on the design decision before jump into implementation details.
@PragmaTwice @git-hulk @ShooterIT @usrtax a quick idea on passing override from environment variable is taking a namespace said kvrocks. and when start the server, read from the env vars and overwrite xxx with kvrocks.xxx.
Anyway, I hope this initiative goes through a design instead of rushing into patches.

Closed in favor of a discussion on the Discussions forum or<EMAIL_ADDRESS>mailing list first. Make it clear that we don't rush into patches.


Make the table on browser pretty.

Right now the table looks a bit off.
Need to make it look good.
Template can be found here.

I will take this issue.


Create an InMemoryWallet for test purposes

I once started a browser wallet that I think we could base this of. Not sure if libsodium-wrappers is performant, as for tests it's nice to have something that is faaaaast.
https://github.com/TimoGlastra/aries-framework-javascript/blob/feature/browser/packages/browser/src/BrowserWallet.ts

That looks amazing, but regarding your concerns about performance, maybe it could be useful in the mid-term (once we fix the ref-napi issue) to use Askar for tests, as it allows to use in-memory storage and provides natively all crypto we need.

Yes if we're able to solve the perf issues I'm all for using Askar

Done done done


docker-in-docker: support noble

An Ubuntu 24.04 ("noble") dev container image has been released: https://github.com/devcontainers/images/issues/1016#issuecomment-2103207443
However, the docker-in-docker dev container feature does not currently recognize noble as a valid distribution:
https://github.com/devcontainers/features/blob/d8e9d335952d0b8d488cc3445ad076003bc3c22c/src/docker-in-docker/install.sh#L21-L22
Resulting in a failure when the feature's install.sh script is run:
https://github.com/devcontainers/features/blob/d8e9d335952d0b8d488cc3445ad076003bc3c22c/src/docker-in-docker/install.sh#L194-L207

https://github.com/devcontainers/features/pull/969 made a PR to fix this, comment contains by own build of the feature you can use as a temporary workaround.


Some perf Improvements in Broker

avoid unnecessary call to MultipleSpecificSegmentSpec.getIntervals()
profiling shows it took upto 6-12% of cpu time in JodaUtils.condenseIntervals

Avoid Wrapping with mergeSequence in retryQueryRunner

LGTM


Safe to use in production ?

Will playing flutter videos through this package violate any Apples policies or terms, in production apps?

Been using it on our app on production for almost a year now, no issues so far

@keithcwk Thank you !


When we send a request to the api manager[1.10.0 and 2.1.0] with an invalid character % the system generates an exception which is displaying an internal implementation

Description:
When we send a request to the api manager[1.10.0 and 2.1.0] with an invalid character % the system generates an exception which is displaying an internal implementation
Suggested Labels:
api manager
Affected Product Version:
1.10.0 and 2.1.0 and
OS, DB, other environment details and versions:
Steps to reproduce:
1.start api manager 1.10.0
2.deploy the calculator api
3.subscribe to the api
4.run the request as
curl -k -X GET "https://<IP_ADDRESS>:8243/calc/1.0/multiply?x=20&y=2%" -H "accept: application/json" -H "Authorization: Bearer    63722d7eb5f6f75d4526da80478a13b1" -H "Accept: application/json" -v
Due to the % symbol ex:x=20&y=2% the system generates a message URLDecoder: Incomplete trailing escape (%) pattern
Related Issues:

fixed with https://github.com/wso2/wso2-synapse/pull/1177/


RABSW-945: Client Mount Daemon might strand volume group

Ensure LVM volume is deactivated in the case the volume is already unmounted
Refactors + renames verifyLVMDevice to accept an activation or deactivation parameter - configureLVMDevice.

Signed-off-by: Nate Roiger<EMAIL_ADDRESS>

Using this code, I had a gfs2 FS mounted on my compute.  Workflow was in pre_run.  I went directly to teardown.  The following appeared in the nnf-node-manager  log:
2022-07-11T15:29:21.262-0500	INFO	controllers.NnfNodeStorage	Deleting storage pool	{"NnfNodeStorage": "rabbit-dev-01/default-gfs126-0-gfs2-0", "Id": "default-gfs126-0-gfs2-0-0"}
time="2022-07-11T15:29:21-05:00" level=warning msg="Object SHdefault-gfs126-0-gfs2-0-0:default-gfs126-0-gfs2-0-0 failed update to state 4" error="Error 500: Internal Server Error, Cause: File share 'default-gfs126-0-gfs2-0-0' failed delete, Internal Error: Error Running Command 'lvremove --yes /dev/default-gfs126-0-gfs2-0-0_vg/default-gfs126-0-gfs2-0-0_lv', StdErr:   LV locked by other host: default-gfs126-0-gfs2-0-0_vg/default-gfs126-0-gfs2-0-0_lv\n"
time="2022-07-11T15:29:21-05:00" level=error msg="Failed to delete file share default-gfs126-0-gfs2-0-0" error="Error 500: Internal Server Error, Cause: File share 'default-gfs126-0-gfs2-0-0' failed delete, Internal Error: Error Running Command 'lvremove --yes /dev/default-gfs126-0-gfs2-0-0_vg/default-gfs126-0-gfs2-0-0_lv', StdErr:   LV locked by other host: default-gfs126-0-gfs2-0-0_vg/default-gfs126-0-gfs2-0-0_lv\n"

The filesystem is unmounted, and the LV/VG are no longer visible on the compute.  The /dev/nvme* entries are cleaned up.
But the rabbit is not happy.


How to custom contextMenu and handle click on context menu item events

Please guild me how to custom context menu as handsontable js library. Thanks.

Hi @CongLeVN
we do not have a lot of React demos yet but I have a vanilla demo at http://jsfiddle.net/vyjm0Lcc/
I hope that I will help.
Surely a context menu example is one of those that we can add later to the wrapper's demo list.

@AMBudnik is the demo corrupted?

It looks like I've sent the wrong example. Here is a custom context menu http://jsfiddle.net/rdu2bq2z/

Documentation was updated in #104


Delete --bind-port flag

Small rework of the config package that deleted --bind-port
NOTE: Port and Host options that are used to create a new
controller-runtime manager instance are used for the webhook server.
see https://github.com/kubernetes-sigs/controller-runtime/blob/master/pkg/manager/manager.go#L211-L216
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

/approve

/approve.
LGTM, I will let Jay take a look as well before merging.

Just opened #29 which will help parsing --webhook-server-addr

/lgtm


Fix toString method of LogStash::Timestamp

For some reason using the LogStash::Timestamp directly in this plug-in results in a NoMethodError.
This might be related to JRuby and the usage of iso8601, see https://www.google.com/search?q=jruby iso8601 NoMethodError&rct=j.
This issue might be resolved if the we use the to_iso8601 function of (https://github.com/elastic/logstash/blob/bb30cc773bcf34d63d634dbfcf2803278a5140b3/logstash-core-event/lib/logstash/timestamp.rb).
:message=>"Failed to flush outgoing items", :outgoing_count=>1, :exception=>"NoMethodError", :backtrace=>["/opt/logstash/vendor/bundle/jruby/1.9/gems/logstash-output-jdbc-0.2.3/lib/logstash/outputs/jdbc.rb:255:in `add_statement_event_params'", "org/jruby/RubyArray.java:1613:in `each'", "org/jruby/RubyEnumerable.java:974:in `each_with_index'", "/opt/logstash/vendor/bundle/jruby/1.9/gems/logstash-output-jdbc-0.2.3/lib/logstash/outputs/jdbc.rb:251:in `add_statement_event_params'", "/opt/logstash/vendor/bundle/jruby/1.9/gems/logstash-output-jdbc-0.2.3/lib/logstash/outputs/jdbc.rb:203:in `safe_flush'", "org/jruby/RubyArray.java:1613:in `each'", "/opt/logstash/vendor/bundle/jruby/1.9/gems/logstash-output-jdbc-0.2.3/lib/logstash/outputs/jdbc.rb:200:in `safe_flush'", "/opt/logstash/vendor/bundle/jruby/1.9/gems/logstash-output-jdbc-0.2.3/lib/logstash/outputs/jdbc.rb:120:in `flush'", "/opt/logstash/vendor/bundle/jruby/1.9/gems/stud-0.0.22/lib/stud/buffer.rb:219:in `buffer_flush'", "org/jruby/RubyHash.java:1342:in `each'", "/opt/logstash/vendor/bundle/jruby/1.9/gems/stud-0.0.22/lib/stud/buffer.rb:216:in `buffer_flush'", "/opt/logstash/vendor/bundle/jruby/1.9/gems/stud-0.0.22/lib/stud/buffer.rb:159:in `buffer_receive'", "/opt/logstash/vendor/bundle/jruby/1.9/gems/logstash-output-jdbc-0.2.3/lib/logstash/outputs/jdbc.rb:113:in `receive'", "/opt/logstash/vendor/bundle/jruby/1.9/gems/logstash-core-2.3.0-java/lib/logstash/outputs/base.rb:83:in `multi_receive'", "org/jruby/RubyArray.java:1613:in `each'", "/opt/logstash/vendor/bundle/jruby/1.9/gems/logstash-core-2.3.0-java/lib/logstash/outputs/base.rb:83:in `multi_receive'", "/opt/logstash/vendor/bundle/jruby/1.9/gems/logstash-core-2.3.0-java/lib/logstash/output_delegator.rb:130:in `worker_multi_receive'", "/opt/logstash/vendor/bundle/jruby/1.9/gems/logstash-core-2.3.0-java/lib/logstash/output_delegator.rb:114:in `multi_receive'", "/opt/logstash/vendor/bundle/jruby/1.9/gems/logstash-core-2.3.0-java/lib/logstash/pipeline.rb:305:in `output_batch'", "org/jruby/RubyHash.java:1342:in `each'", "/opt/logstash/vendor/bundle/jruby/1.9/gems/logstash-core-2.3.0-java/lib/logstash/pipeline.rb:305:in `output_batch'", "/opt/logstash/vendor/bundle/jruby/1.9/gems/logstash-core-2.3.0-java/lib/logstash/pipeline.rb:236:in `worker_loop'", "/opt/logstash/vendor/bundle/jruby/1.9/gems/logstash-core-2.3.0-java/lib/logstash/pipeline.rb:205:in `start_workers'"], :level=>:warn}

Thank you once again @hordijk <3
I swear this was functional in a previous version of logstash, but what with all the repos moving around I can't seem to easily when/if this changed :shrug: Either way, thank you. I'll publish an updated gem shortly!


UofT DSI - Python Assignment 1

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

adding anagram function

What did you learn from the changes you have made?

previously written this code

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

reducing time complexity sort, using hash table instead

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

n/a

How were these changes tested?

test cases of different strings

A reference to a related issue in your repository (if applicable)
Checklist

[x] I can confirm that my changes are working as intended

you did a great job here!
Please go ahead and close this pull request now. Thanks!


Fix degenerate voxels

When voxels are removed, some neighbors may be left in a state where they won't generate a well-formed "polygon spike". They could also be removed, or they could be subdivided.

On second thought, I don't think degenerate voxels are a problem - since we just mark voxel corners as either inside or outside the surface, it shouldn't be possible for adjacent edges to "disagree" on how they construct polygons.


[s3] EndpointARN helper method for BucketName top level input members.

I think this will be resolved by endpoints 2.0. Adding the retriage tag to confirm later.


Need Dark Mode for this Theme:

Toggle Button will do

Can I work on this?

Yes Nishant

@sanjay-kv I have already made that. How can I raise the PR for it.

@thevijayshankersharma are you talking about dark mode?

@nishant0708
I need more changes in the website, like im planning to make it public to everyone and get additional points when they add their profile.
before that im looking it to make more UI friendly and add more features.
I will also raise issue when i find something interesting. can you also look for the same in simillar website and raise an issue, once we both like can add contributions.

@thevijayshankersharma are you talking about dark mode?

Yes

hey @sanjay-kv for sure .

@nishant0708 hows the background scroll function going on

hey @sanjay-kv  actually Code and every thing is working fine we are just facing issue to make it work with allcontributors bot

Like js function is working fine
But this Action bot while taking ss is giving this Error

so @dinxsh is Looking into it and trying to fix this error .

sure. thanks for letting me know.

hey @sanjay-kv sir one more things the points of this repo is not getting count on the leaderboard


HTML Escape go test output

Fixes: https://github.com/joefitzgerald/go-plus/issues/493

Have a look here: https://github.com/joefitzgerald/tester-go/blob/master/lib/test-panel-manager.js#L46
tester-go already uses a library that converts ansi escape codes into html. Luckily this tool also supports html/xml escaping. https://github.com/rburns/ansi-to-html#options
Please try/use this instead!

@lloiser I've updated this to use ansi-to-html module with escapeXML option. Thanks for your advice!


docs: add reference hardware documentation

Description
The Autoware documentation has been updated with a new page titled "Reference HW " which includes information on various hardware components. This pull request aims to incorporate these additions into the documentation. The added content covers AD computers, LiDARs, RADARs, CAMERAs, thermal CAMERAs, IMU, AHRS & GNSS/INS sensors, vehicle drive-by-wire suppliers, vehicle platform suppliers, remote drive solutions, and a full drivers list. This PR enhances the documentation by providing valuable information about these hardware options for Autoware users.

Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The Reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Can you also share the original HW document link in the PR description?


[BUG] Symlink handling

Describe the bug
In some datasets in the FS38 project, the catalog returns multiple entries for the same files because there are symlinks used within the file structure.
e.g.
lrwxrwxrwx 1 fo3_esgfpub 80 Sep  3  2020 /g/data/fs38/publications/CMIP6/CMIP/CSIRO-ARCCSS/ACCESS-CM2/historical/r1i1p1f1/SImon/sifb/gn/v20200817/sifb_SImon_ACCESS-CM2_historical_r1i1p1f1_gn_185001-201412.nc -> ../files/d20200817/sifb_SImon_ACCESS-CM2_historical_r1i1p1f1_gn_185001-201412.nc*
To Reproduce
cat = catalog.search(model="ACCESS-CM2", name="cmip6_fs38")

cat["cmip6_fs38"].search(
    realm="seaIce",
    frequency="mon",
    member_id="r1i1p1f1",
    experiment_id="historical",
    source_id="ACCESS-CM2",
    variable_id="sifb"
).df.path

which returns:
0    /g/data/fs38/publications/CMIP6/CMIP/CSIRO-ARCCSS/ACCESS-CM2/historical/r1i1p1f1/SImon/sifb/gn/files/d20200817/sifb_SImon_ACCESS-CM2_historical_r1i1p1f1_gn_185001-201412.nc
1          /g/data/fs38/publications/CMIP6/CMIP/CSIRO-ARCCSS/ACCESS-CM2/historical/r1i1p1f1/SImon/sifb/gn/v20200817/sifb_SImon_ACCESS-CM2_historical_r1i1p1f1_gn_185001-201412.nc
Name: path, dtype: object

And prevents the data being loaded using to_dask() because one entry in the catalogue is just a symlink to the other file.
Additional context
A workaround is to add an extra filter term, to only catch one of the entries. e.g:
path=".*gn/files.*"

Thanks @anton-seaice. We don't actually build this (or any of the other CMIP) datastores. Instead, we just include these as built by NCI. The fact that there are both symlinks and hardlinks is a (somewhat annoying) feature of the NCI CMIP datastores. Fortunately there is a column in these datastores that indicates whether the file is a hard or symlink, so the workaround is to include that in your filter:
cat["cmip6_fs38"].search(
    realm="seaIce",
    frequency="mon",
    member_id="r1i1p1f1",
    experiment_id="historical",
    source_id="ACCESS-CM2",
    variable_id="sifb",
    file_type="f"
).df.path

Ah right - I guess you've already talked to them / someone at NCI about changing it?

Yeah - I don't think that's an option


Update libwebp to v1.3.2

libwebp v1.3.2 security fix for lossless decoder (chromium: #1479274, CVE-2023-4863)

Thanks!


Would this be better with a more explicit run?

From reading some of the documentation piping things inside Bats can be error prone as it handles pipefail and set -e on its own.
https://github.com/groupon/ansible-silo/blob/178b85eae6eca27fb7a3849632b30d87b0a3f7a6/tests/functional#L604
Would this be better as something like the below, possibly with assertions around the content and exit code?
run bash -c "true | ansible --version"

Thanks for this issue! I think piping only is a problem inside a run. But if I recall correctly the reason why it is not in a run is because it was not working when I tried... Your proposed solution makes perfect sense, thanks! I'll get a PR ready for this.

For reference, this issue describes the problem and solution: https://github.com/sstephenson/bats/issues/10


codeowners: add changeset prefix for techdocs

@backstage/techdocs-core Use a techdocs- prefix for your changesets if you want to avoid needing a review from @backstage/maintainers  :grin:

Aha, okay! :)

Aha, okay! :)


Add fd protection in mesa3d library

fd created needs protection to avoid being closed by other threads
fixed double close issue in iris_screen_destroy() function.
Tracked-On: OAM-102221
Signed-off-by: Basanagouda Koppad<EMAIL_ADDRESS>

If the changes come from internal, can you help add "INTERNAL: " to commit title? If it comes from upstream mesa, then plz add "UPSTREAM: " to title.

If the changes come from internal, can you help add "INTERNAL: " to commit title? If it comes from upstream mesa, then plz add "UPSTREAM: " to title.

Done, Changes done to include INTERNAL: to commit title.


fix release job name

PR Context

Added

Changes

Deprecated

Removed

Fixed

Security

integrated into https://github.com/robert-koch-institut/mex-template/pull/18


redirect Image Optimization

I have been moving the content to web.dev from:  https://developers.google.com/web/fundamentals/performance/optimizing-content-efficiency/image-optimization
https://github.com/GoogleChrome/web.dev/pull/3269
This PR:

deletes the article and related images

deletes the translations

adds a redirect to the new content on web.dev

marks the page as external in the toc

[ ] This has been reviewed and approved by (NAME)

[ ] I have run npm test locally and all tests pass.

[ ] I have added the appropriate type-something label.

[ ] I've staged the site and manually verified that my content displays correctly.

CC: @petele

Whoops!
There were 20 warnings that will prevent this PR from being merged. Please take a look, and either fix, or provide a justification for why they can't be fixed.
WARNINGS
src/content/ar/fundamentals/performance/optimizing-content-efficiency/image-optimization.md - Unable to read file, was it deleted?
src/content/de/fundamentals/performance/optimizing-content-efficiency/image-optimization.md - Unable to read file, was it deleted?
src/content/en/fundamentals/performance/optimizing-content-efficiency/image-optimization.md - Unable to read file, was it deleted?
src/content/es/fundamentals/performance/optimizing-content-efficiency/image-optimization.md - Unable to read file, was it deleted?
src/content/fr/fundamentals/performance/optimizing-content-efficiency/image-optimization.md - Unable to read file, was it deleted?
src/content/id/fundamentals/performance/optimizing-content-efficiency/image-optimization.md - Unable to read file, was it deleted?
src/content/it/fundamentals/performance/optimizing-content-efficiency/image-optimization.md - Unable to read file, was it deleted?
src/content/ja/fundamentals/performance/optimizing-content-efficiency/image-optimization.md - Unable to read file, was it deleted?
src/content/ko/fundamentals/performance/optimizing-content-efficiency/image-optimization.md - Unable to read file, was it deleted?
src/content/nl/fundamentals/performance/optimizing-content-efficiency/image-optimization.md - Unable to read file, was it deleted?
src/content/pl/fundamentals/performance/optimizing-content-efficiency/image-optimization.md - Unable to read file, was it deleted?
src/content/pt-br/fundamentals/performance/optimizing-content-efficiency/image-optimization.md - Unable to read file, was it deleted?
src/content/ru/fundamentals/performance/optimizing-content-efficiency/image-optimization.md - Unable to read file, was it deleted?
src/content/tr/fundamentals/performance/optimizing-content-efficiency/image-optimization.md - Unable to read file, was it deleted?
src/content/zh-cn/fundamentals/performance/optimizing-content-efficiency/image-optimization.md - Unable to read file, was it deleted?
src/content/zh-tw/fundamentals/performance/optimizing-content-efficiency/image-optimization.md - Unable to read file, was it deleted?
src/content/en/fundamentals/performance/optimizing-content-efficiency/images/css-vs-device-pixels.png - Unable to read file stats: ENOENT: no such file or directory, stat 'src/content/en/fundamentals/performance/optimizing-content-efficiency/images/css-vs-device-pixels.png'
src/content/en/fundamentals/performance/optimizing-content-efficiency/images/raster-zoom.png - Unable to read file stats: ENOENT: no such file or directory, stat 'src/content/en/fundamentals/performance/optimizing-content-efficiency/images/raster-zoom.png'
src/content/en/fundamentals/performance/optimizing-content-efficiency/images/resized-image.png - Unable to read file stats: ENOENT: no such file or directory, stat 'src/content/en/fundamentals/performance/optimizing-content-efficiency/images/resized-image.png'
src/content/en/fundamentals/performance/optimizing-content-efficiency/images/vector-zoom.png - Unable to read file stats: ENOENT: no such file or directory, stat 'src/content/en/fundamentals/performance/optimizing-content-efficiency/images/vector-zoom.png'


WIP: Move to preconfigured Resin-SDK

Much like https://github.com/resin-io/resin-config-json/pull/4, this PR is failing, because master on the repo is (after rerunning the build) failing. Note that only appveyor visibly fails, because Travis ignores the error output and just sees zero tests, but both are broken.
Looks like some of our image metadata has changed, but I don't have enough context to know whether the values this is seeing are correct or not.
I have had to update this to the new device registration API to get to these errors, and I've also documented and tweaked the test setup, since it was a little opaque.

@jviotti can you please check why the tests are failing?
To repeat: it's unrelated to this PR, they're failing on the current master.

Looks like a device slug change from the API that affected us, but I'll investigate further as well.

Done, see https://github.com/resin-io/resin-device-init/pull/19. This was also caused by some minor changes to the device types. Adapting the tests to the new changes made everything work again.

Rebased onto the new changes, and the tests pass now and I think this is ready to go. Can somebody approve this? I'll merge once that's done.


TFM Package: Update to TFM pacakage URL

TFM package for LPC55S69 got first relase.
Signed-off-by: Karl Zhang<EMAIL_ADDRESS>

https://github.com/RT-Thread-packages/trusted-firmware-m/releases/tag/v1.0-beta


Adding container, PartFactory, and Guzzle service

Awesome, looks good. Since this is quite a large change I've created the v4 branch and merged this pull request into it. I'll add you as a contributor.


Pod tolerations number layout bug

Pod tolerations number is sticked to the start of the line, causing text overflow.

Presented only in https://github.com/lensapp/lens/pull/5642

Seems like this one is still here


Standalone mode doesn't work ?

Hello,
Are you sure the standalone installation works well ?
I followed your instructions and installed it in my custom wsl distribution. When I launch wsl-vpnkit, I still have the network's problems.
Ty

Same here. If I follow the instructions it says
shell````
wsl-gvproxy.exe not found at /wsl-vpnkit/wsl-gvproxy.exe
I moved it to that location still does not seem to work

@kohlerm You need to push wsl-gvproxy.exe to /wsl-vpnkit/wsl-gvproxy.exe at root of the windows user.
I did that : mv wsl-gvproxy.exe "$WINHOME/wsl-vpnkit/wsl-gvproxy.exe" ($WINHOME = /mnc/c/users/myuser/)

@adpeyre Thanks for the hint, but I still cannot get it to work.
I get
 sudo ./wsl-vpnkit
wslpath:
starting wsl-vpnkit
cleaning up iptables...
# Warning: iptables-legacy tables present, use iptables-legacy to see them
# Warning: iptables-legacy tables present, use iptables-legacy to see them
# Warning: iptables-legacy tables present, use iptables-legacy to see them
# Warning: iptables-legacy tables present, use iptables-legacy to see them
iptables cleanup done
restoring WSL 2 ip route...
RTNETLINK answers: File exists
RTNETLINK answers: File exists
restored WSL 2 ip route
starting gvproxy at /wsl-vpnkit/wsl-gvproxy.exe...
started gvproxy
waiting for dhcp...
INFO[0000] waiting for packets...
Internet Systems Consortium DHCP Client 4.4.1
Copyright 2004-2018 Internet Systems Consortium.
All rights reserved.
For info, please visit https://www.isc.org/software/dhcp/

Listening on LPF/eth1/5a:94:ef:e4:0c:ee
Sending on   LPF/eth1/5a:94:ef:e4:0c:ee
Sending on   Socket/fallback
DHCPDISCOVER on eth1 to <IP_ADDRESS> port 67 interval 3 (xid=0xebcf7321)
DHCPDISCOVER on eth1 to <IP_ADDRESS> port 67 interval 4 (xid=0xebcf7321)
DHCPDISCOVER on eth1 to <IP_ADDRESS> port 67 interval 11 (xid=0xebcf7321)
DHCPDISCOVER on eth1 to <IP_ADDRESS> port 67 interval 12 (xid=0xebcf7321)
DHCPDISCOVER on eth1 to <IP_ADDRESS> port 67 interval 12 (xid=0xebcf7321)
DHCPDISCOVER on eth1 to <IP_ADDRESS> port 67 interval 20 (xid=0xebcf7321)
time="2023-01-18T14:47:59+01:00" level=info msg="new connection from remote to 41360"
DHCPOFFER of <IP_ADDRESS> from <IP_ADDRESS>
DHCPREQUEST for <IP_ADDRESS> on eth1 to <IP_ADDRESS> port 67 (xid=0x2173cfeb)
DHCPACK of <IP_ADDRESS> from <IP_ADDRESS> (xid=0xebcf7321)
bound to <IP_ADDRESS> -- renewal in 1750 seconds.

But no connection to the internet...
Did you get it working?
I am on Ubuntu 22.04.01.

Ok. Finally got it working (cleanup not working properly).
See https://github.com/sakai135/wsl-vpnkit/compare/main...kohlerm:wsl-vpnkit:main
Problems were:

CMDSHELL would not be set correctly, not sure why. Hardcoded it to the typical location
WSL2_VM_IP would not have the correct value, because the output of ifconfig was slightly differen.
replaced iptables by iptables-legacy (not sure that is absolutely needed)
added  ip route flush 0/0  ip route add default via $VPNKIT_GATEWAY_IP dev eth1

to run (would not have the correct default route otherwise.

Yeah I had to install these packages:
uuid-runtime net-tools isc-dhcp-client udhcpc dnsutils
Did not know about "route del default" Thx!

Anyone knows how to trigger WSL regenerating the /etc/resolv.conf file (which points to /wsl/resolv.conf) ?
I still got an incorrect entry for the name server after shutting down the script.
wsl --shutdown  is a workaround, but not ideal.

Thanks for the info. I've pinned this issue, so it'll be a little bit more prominent for people that have similar issues.
I'll see about updating the readme and/or script so it works with the current default Ubuntu distro.

With a Fedora / EL9 OS I used the following setup script with the assumption that systemd has already been enabled and configured.
#!/bin/bash

# Ensure Required Packages
dnf install -q -y --allowerasing coreutils gawk net-tools bash dhcp-client bind-utils

# Set PATH
PATH="$PATH:/mnt/c/WINDOWS/system32:/mnt/c/WINDOWS/System32/WindowsPowerShell/v1.0"

# Stop Service
systemctl stop wsl-vpnkit.service &>/dev/null || true

# Set Release
get_latest_release() {
	curl --silent "https://api.github.com/repos/$1/releases/latest" \
		| grep '"tag_name":' \
		| sed -E 's/.*"([^"]+)".*/\1/'
}
VERSION="$(get_latest_release sakai135/wsl-vpnkit)"

# Create Temp Directory
temp="$(mktemp -d)"
cd "$temp" || exit 22

# download wsl-vpnkit
wget https://github.com/sakai135/wsl-vpnkit/releases/download/$VERSION/wsl-vpnkit.tar.gz
tar --strip-components=1 -xf wsl-vpnkit.tar.gz app/wsl-vpnkit files/wsl-gvproxy.exe files/wsl-vm

# place Windows exe
USERPROFILE=$(wslpath "$(powershell.exe -c 'Write-Host -NoNewline $env:USERPROFILE')")
mkdir -p "$USERPROFILE/wsl-vpnkit"
#/bin/cp -f wsl-gvproxy.exe "$USERPROFILE/wsl-vpnkit/wsl-gvproxy.exe"

# place bin scripts
/bin/cp -f wsl-vm /usr/local/sbin/wsl-vm
/bin/cp -f wsl-vpnkit /usr/local/sbin/wsl-vpnkit
chmod 750 /usr/local/sbin/wsl-vm
chmod 750 /usr/local/sbin/wsl-vpnkit
chown root:root /usr/local/sbin/wsl-vm
chown root:root /usr/local/sbin/wsl-vpnkit

# Create SystemD Service File
cat <<-EOF > /etc/systemd/system/wsl-vpnkit.service
[Unit]
Description=WSL VPNKit To Bypass Cisco Anyconnect

[Service]
Type=simple
Environment=PATH=/root/.local/bin:/root/bin:/usr/local/sbin:/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/bin:/mnt/c/WINDOWS/system32:/mnt/c/WINDOWS/System32/WindowsPowerShell/v1.0:$USERPROFILE/wsl-vpnkit
ExecStart=/usr/local/sbin/wsl-vpnkit

[Install]
WantedBy=default.target
EOF

# Set Config File If Missing
config="$USERPROFILE/wsl-vpnkit/wsl-vpnkit.conf"
if [ ! -f "$config" ]; then
	cat <<-EOF > "$config"
		# Virtual interface name
		TAP_NAME=eth1

		# Network configuration
		VPNKIT_SUBNET=<IP_ADDRESS>/24
		VPNKIT_GATEWAY_IP=<IP_ADDRESS>
		VPNKIT_HOST_IP=<IP_ADDRESS>
		VPNKIT_LOWEST_IP=<IP_ADDRESS>
		DNS_IP=<IP_ADDRESS>

		# Debug logging for gvisor-tap-vsock
		VPNKIT_DEBUG=false

		# Connectivity test endpoints
		CHECK_DNS=<IP_ADDRESS>
		CHECK_HOST=google.com
	EOF
fi

# Start VPN Kit
systemctl daemon-reload
#systemctl enable --now wsl-vpnkit.service

# Cleanup
cd "$HOME"
rm -rf "$temp"

Only thing I haven't gotten working is automatic shutdown of WSL when no shells are logged in (Default behavior).  The wsl-vpnkit service has to be stopped before the automatic shutdown behavior will work again.  It's suppose to ignore systemd services but that doesn't seem to be the case here.

Do you know a workaround to get it running the standalone script on the latest Ubuntu? Installing the packages mentioned above does not work. It hangs on ip: RTNETLINK answers: File exists

Do you know a workaround to get it running the standalone script on the latest Ubuntu? Installing the packages mentioned above does not work. It hangs on ip: RTNETLINK answers: File exists

I'm having the exact same issue on Ubuntu-22.04.


[Gherkin parser (JS)] Narrative support before Background steps

Hello!
Thanks for that work, what you do. It's awesome. I like this tool.
My Environment

Version used: 4.1.3
Operating System and version: Windows 10/7 x64, Jenkins
Work with: CucumberJS 2.2.0+

Summary
I have a problem. I would like to write feature files which contain the narrative description of the feature.
I can do this when I don't use Background step. But when I use Background I get parse error message,
Context & Motivation
For documentation, I would like to see the requirement of my system which is tested.
Current Behavior
Feature: Example Product - Add an item

  Narrative:

  Meta:
   @review

  Background:
    Given the system login page is open
    And logged in user testUser_2

The Gherkin parser says:
[Unhandled rejection CompositeParserException: Parser errors:
(8:3): expected: #TagLine, #ScenarioLine, #ScenarioOutlineLine, #Comment, #Empty, got 'Background:'
(9:5): expected: #TagLine, #ScenarioLine, #ScenarioOutlineLine, #Comment, #Empty, got 'Given the system login page is open'
(10:5): expected: #TagLine, #ScenarioLine, #ScenarioOutlineLine, #Comment, #Empty, got 'And logged in user testUser_2'

The same feature file with commented Narrative and Meta section can start the running with CucumberJS.
Another file which has Narrative and Meta section and doesn't have Background step can start the running with CucumberJS.
Expected Behavior
A feature file with Narrative, Meta and Background steps section can compile and run with CucumberJS.

The Narrative: and Meta: lines are not recognised by Cucumber as keywords, so they just become part of the Feature’s description.
Then, the @review line is recognised as a tag. According to the Gherkin grammar, th next keyword following a tag must be Feature, Scenario, Scenario Outline or Examples. You cannot have a tag before a Background.

Thanks for the clarifying.


[Dropdown] The width of inputs that are inside of a dropdown’s .menu should never be overridden

Resolves #5085.

I'll check out


feat: Add GPT Video Analysis-In-A-Box template

Your template repository
Place your template repository link here: https://github.com/Azure-Samples/gpt-video-analysis-in-a-box

[ ] Added an entry to https://github.com/Azure/awesome-azd/blob/main/website/src/data/users.tsx that includes:

[x] Template title - A short title that reflects the local application stack that someone could use to get their application on Azure (e.g. "Containerized React Web App with Java API and MongoDB")

[x] Description - 1-2 sentence description of the architecture (e.g. Azure services) or solution that is defined by the template.

[x] Architecture Diagram or Application Screenshot - The image should include all services and their connections (example). You should add the image to the website/src/data/images/.

[x] Link to Author's GitHub or other relevant website - Used for attribution

[x] Author's Name -  Name to credit on the gallery card

[x] Link to template source - Link to the template GitHub repo

[x] Tags - Specify tags to represent the template. If you don't see a relevant tag for your template? Feel free to add one!
Required tags:

[x] Tag your template as Micrsoft-authored ("msft") or Community-authored ("community")
[x] Tag the IaC provider ("bicep" or "terraform")
[x] At least 1 tag for programming language used
[x] At least 1 tag for Azure services integrated
[x] Add the "new" tag for any newly authored templates

[x] In the PR comment, if you can also add a link to the PR where you made your repo azd compatible this will allow us to provide feedback on your template and speed up the review process.

@kristenwomack Here is the PR we discussed

@hemarina, @codebytes  We have finished this template test, and we filed one issue. Please review.

https://github.com/Azure-Samples/gpt-video-analysis-in-a-box/issues/2

@hemarina, @codebytes We have finished this template test, and we filed one issue. Please review.

doc: Modify the correct project path. Azure-Samples/gpt-video-analysis-in-a-box#2

We've merged a pr and closed the issue. Thank you for the validation!


Fix problems with GCC optimization and cMake

Changelog
I noticed that GCCs tree-loop-distribute-patterns optimization can lead to infinite loops and stack overflows. This was tested with banshee simulations.
Further, the custom memcpy and memset implementation in software/runtime/string.c is sometimes swapped out with the GCC built-in function. However, this tends to lead to cause some bytes not to be copied if the number of bytes is at multiple of 4.
Finally, when using cMake with GCC, the configuration steps can fail because install/riscv-gcc/riscv32-unknown-elf/lib/riscv.ld is missing.
Fixed

After building GCC, copy riscv.ld required for cMake to install folder
Disable GCC tree-loop-distribute-patterns optimizations causing stack overflows
Disable problematic GCC memset and memcpy built-in functions

Checklist

[ ] Automated tests pass
[x] Changelog updated
[x] Code style guideline is observed

The flags you added are not recognized by LLVM. Did you mean to add them to the GCC-specific flags?


runtime/metrics: use explicit histogram boundaries (API fix)

This issue refers the current implementation that includes post go1.16beta1 fixes:
go version devel +95ce805d14 Thu Dec 31 02:24:55 2020 +0000 linux/amd64
Proposal: #37112
API Audit: #43407
I've found that using implicit -inf/+inf boundaries with the runtime/metrics.Float64Histogram API is a bit awkward (compared to using explicit boundaries). Implicit boundaries:

Require extra logic for the caller since the start/end boundaries need to be interpreted differently
The first bucket (-inf) is usually nonsensical/wasted and ignored (negative allocation size, negative duration).

I think it would be much better making the boundaries explicit:

Much simpler for API callers to interpret since there is only a single rule and no need to synthesize bucket ranges
Metrics can choose the boundaries that make the most sense (math.Inf(-1) is a valid floating point number). Eg, it is impossible to allocate -10 bytes - using [1, 9) or [0, 9) for the first bucket makes more sense.

In practice, the total number of float64s could be the same since the first bucket can usually be dropped. Eg:
Assuming the following counts / buckets:

[0, 10): 1
[10, 20): 2
[20, +inf): 3

Current implicit encoding:

Counts: 0, 1, 2, 3
Buckets: 0, 10, 20

Proposed explicit encoding:

Counts: 1, 2, 3
Buckets: 0, 10, 20, +inf

Even if there is a reason to keep the unused -inf bucket, making the boundaries explicit provides more future flexibility and makes it easier for callers.
For comparison, the current API is documented as:
// count[0] is the weight of the range (-inf, bucket[0])
// count[n] is the weight of the range [bucket[n], bucket[n+1]), for 0 < n < N-1
// count[N-1] is the weight of the range [bucket[N-1], inf)

Note: this is actually incorrect, it should be [bucket[n-1], bucket[n]), for 0 < n < N-1.
The explicit boundary API would be:
// count[n] is the weight of the range [bucket[n], bucket[n+1]), for 0 <= n < N

Simplifying the documentation crudely indicates using explicit boundaries provides a cleaner API.
Cc @mknyszek
Sorry about the report late in the cycle, but I think this would be a much better API for the future and it's a simple fix now.

Thank you so much for taking such a close look at this!
I think I agree with having totally explicit bucket boundaries. Reasoning about indicies is more straightforward for the user this way. I suspect I did this at first to ensure all histograms were sufficiently general, but you're right that some things just really don't make sense (e.g. negative bytes).
I do think there is a reason to keep -inf for time-based histograms (unfortunately negative durations can and do arise in practice even in places you might not expect, as I found recently... time is hard) but as you say that can just be explicit.
CC @prattmic @aclements

Thank you so much for taking such a close look at this!
I think I agree with having totally explicit bucket boundaries. Reasoning about indicies is more straightforward for the user this way. I suspect I did this at first to ensure all histograms were sufficiently general, but you're right that some things just really don't make sense (e.g. negative bytes).
I do think there is a reason to keep -inf for time-based histograms (unfortunately negative durations can and do arise in practice even in places you might not expect, as I found recently... time is hard) but as you say that can just be explicit.
CC @prattmic @aclements

Making all the boundaries explicit also seems pretty reasonable to me. And I certainly like how it simplifies the documentation, especially since I remember spending a decent amount of time staring that those exact sentences and deciding they were right!

Making all the boundaries explicit also seems pretty reasonable to me. And I certainly like how it simplifies the documentation, especially since I remember spending a decent amount of time staring that those exact sentences and deciding they were right!

I played with this suggestion a bit by writing some sample code to print out a histogram using three different APIs:

The existing API at HEAD.
The API proposed above by @mpx.
An API where Buckets provides a complete [lower, upper) pair for each bucket (Buckets [][2]float64).

See the code https://gist.github.com/prattmic/c635fe88225fb0995078fa3444456ce6.
IMO, (2) and (3) simply the code quite nicely and I think I'd prefer writing to that simpler API. Before writing any code, I thought (3) might be even nicer, but in practice it doesn't seem to be any improvement over (2).

I played with this suggestion a bit by writing some sample code to print out a histogram using three different APIs:

The existing API at HEAD.
The API proposed above by @mpx.
An API where Buckets provides a complete [lower, upper) pair for each bucket (Buckets [][2]float64).

See the code https://gist.github.com/prattmic/c635fe88225fb0995078fa3444456ce6.
IMO, (2) and (3) simply the code quite nicely and I think I'd prefer writing to that simpler API. Before writing any code, I thought (3) might be even nicer, but in practice it doesn't seem to be any improvement over (2).

OK, I think we're going to do this. I'm writing up a CL for this today.

OK, I think we're going to do this. I'm writing up a CL for this today.


Confusion about ElasticDistortion

Hi, Xiaoyang.
I have one question about the data augmentation ElasticDistortion.
Recently I find that after ElasticDistortion, the coords are changed and then used as feat keys in some configs. But in the code of PointGroup and some other code base (like SoftGroup), they usually identify xyz and xyz_middle to classify coords, and use xyz for voxelization and use xyz_middle as part of feats.
But in Pointcept, it seems merge these two as one.

Yes, in my opinion, the partial target of data augmentation is to simulate data that is not collected in the dataset. So coord used for both positional information and feature representation should be aligned. I didn't ablate the differences and just decided to unify them when I initially designed the framework of Pointcept.

Okay, got that. Thanks for your prompt reply.


The specified key does not exist - but it does

I am getting the following response (and a number of other users are seeing the same issue on the Indigo Domotics forum.
content-encoding: br
content-type: text/html
date: Sat, 22 Apr 2023 15:47:08 GMT
etag: W/"5f3cc4105afcad5b5e05f15c15aeaeb2"
last-modified: Wed, 19 Apr 2023 12:30:30 GMT
server: AmazonS3
vary: Accept-Encoding
via: 1.1 dfd34e1e01b522d0fbbf77a5352081ce.cloudfront.net (CloudFront)
x-amz-cf-id: m8_K_h3UqVswyKFlK0hhLveFWZhy-GEW4khFp71JS7RfXXXXXXXXXXX==
x-amz-cf-pop: ATL58-P4
x-amz-error-code: NoSuchKey
x-amz-error-detail-key: forecast/CCcJDyXCTJaSBzcmq5bC47oJuaor1kuXXXXXXXXXXX/1000
x-amz-error-message: The specified key does not exist.
x-cache: Error from cloudfront
with a freshly generated API key, two of us are in the UK if that is a difference.

I tried creating a key on my end and it worked without issues. It takes some time for the API key to activate so have you tried since the initial signup to see if it's started working? If it still isn't working then reach out to the developer at api@alexanderrey,ca and he can help troubleshoot the issue.

The reply from Clone of Ghosts is 100% here- for key related issues, best best is to e-mail me an we can go from there.
I'm going to close this issue for now since there hasn't been any activity on it, but feel free to create a new one or re-open if anything else comes up!


fix laggy about page

fixing the stutter in the about page

While setting up the project locally
Got this error while installing requirements.txt
No matching distribution found for pycryptodome==3.9.8_

Am not able to set it up locally

I have solved this problem, do check conversations in project channel.

I have solved this problem, do check conversations in project channel.

Couldn't find Angy channel link

U r in gssoc right?

U r in gssoc right?

Yes ok understood discord


This prompt appears when you run the program under windows. How to solve it?

Minima @ 22/04/2022 15:51:44 [5.2 MB] : ****************************************

Minima @ 22/04/2022 15:51:44 [5.9 MB] : *  __  __  ____  _  _  ____  __  __    _
_    *
Minima @ 22/04/2022 15:51:44 [5.9 MB] : * (  /  )(_  )( ( )( )(  /  )  /
\   *
Minima @ 22/04/2022 15:51:44 [5.9 MB] : *  )    (  )(  )  (  )(  )    (  /(
)\  *
Minima @ 22/04/2022 15:51:44 [5.9 MB] : * (//_)()()_)()(//_)()
() *
Minima @ 22/04/2022 15:51:44 [5.9 MB] : *
*
Minima @ 22/04/2022 15:51:44 [5.9 MB] : ****************************************

Minima @ 22/04/2022 15:51:44 [5.9 MB] : Welcome to Minima v0.100.32 - for assist
ance type help. Then press enter.
Minima @ 22/04/2022 15:51:46 [30.4 MB] : Load Object file does not exist : C:\Us
ers\Administrator.minima\databases\userprefs.db
Minima @ 22/04/2022 15:51:46 [30.4 MB] : Load Object file does not exist : C:\Us
ers\Administrator.minima\databases\cascade.db
Minima @ 22/04/2022 15:51:46 [30.4 MB] : Load Object file does not exist : C:\Us
ers\Administrator.minima\databases\chaintree.db
Minima @ 22/04/2022 15:51:46 [30.4 MB] : Load Object file does not exist : C:\Us
ers\Administrator.minima\databases\p2p.db
Minima @ 22/04/2022 15:51:46 [9.3 MB] : RPC Server started on port : 9002
Minima @ 22/04/2022 15:51:46 [15.4 MB] : [+] P2P Version: 1.0
Minima @ 22/04/2022 15:51:46 [15.4 MB] : [+] Doing discovery connection with def
ault node: /<IP_ADDRESS>:9001
Minima @ 22/04/2022 15:51:49 [45.5 MB] : [+] Connected to the blockchain Initial
Block Download received. size:2.0 MB blocks:1029
Minima @ 22/04/2022 15:51:56 [68.5 MB] : [-] WARNING : No Known peers ( -clean +
delay )
Minima @ 22/04/2022 15:51:56 [68.5 MB] : [+] Doing discovery connection with def
ault node: /<IP_ADDRESS>:9001
Minima @ 22/04/2022 15:51:58 [69.2 MB] : [+] Connected to the blockchain Initial
Block Download received. size:5 bytes blocks:0
Minima @ 22/04/2022 15:52:09 [70.3 MB] : [-] WARNING : Failed to set my ip. Secr
ets do not match - could be a delay. MySecret: 0x91FBDC2C28F6A1039C8B3691 Receiv
ed secret: 0xBB9B4D4377D534CC3AD7AF91
Minima @ 22/04/2022 15:52:09 [70.3 MB] : [+] Setting My IP: <IP_ADDRESS>
Minima @ 22/04/2022 15:52:09 [71.5 MB] : [+] Connected to the blockchain Initial
Block Download received. size:1.2 KB blocks:1
Minima @ 22/04/2022 15:52:21 [72.9 MB] : [+] Connected to the blockchain Initial
Block Download received. size:5 bytes blocks:0
Minima @ 22/04/2022 15:52:32 [74.1 MB] : [+] Connected to the blockchain Initial
Block Download received. size:5 bytes blocks:0
Minima @ 22/04/2022 15:52:45 [85.5 MB] : [+] Connected to the blockchain Initial
Block Download received. size:5 bytes blocks:0
Minima @ 22/04/2022 15:52:58 [31.5 MB] : No Archive blocks found to match New Us
er..
Minima @ 22/04/2022 15:53:03 [32.4 MB] : [+] Connected to the blockchain Initial
Block Download received. size:5 bytes blocks:0
Minima @ 22/04/2022 15:53:08 [35.5 MB] : [-] Too many outgoing connections, disc
onnecting

Too many outgoing connections, disconnecting me too


Reset only history (not stubs)

I have run into a few times where I want to only reset the execute count and not "un-load" the stubs.
For example: a model where API calls are made on create and update.
To test the update calls, I first create test records (e.g. FactoryBot). But since creation also triggers the API, my execute count is inflated before my test (in this case both create and update rely on POST, so I can't filter them out).
Using this WebMock::RequestRegistry.instance.reset! works (with maybe no unintended consequences?), but it might be nice to have a WebMock.reset_history! or WebMock.reset_count! so it feels a bit more intentionally available.
I'd offer a PR, but I'm a hobbyist and only understand about half of what I see.

@chiperific WebMock::RequestRegistry.instance.reset! is the right way to do it.
Not sure what would be the best name to add to the API. reset_executed_requests, reset_request_history?

I'd vote for WebMock.reset_executed_requests since that relates more directly to the error message.
E.g: expect(WebMock).to have_requested(:post, /url_regex/).twice
Msg: The request POST /url_regex/ was expected to execute 2 times but it executed 4 times
Sorry I can't be helpful with a PR. I have a tendency to create two new problems for each one I solve.

@chiperific You're welcome to submit a PR. No worries, I'll review it before merging :)

Hey friends, I hate to say this, but this isn't working for me from RubyGems.
I've confirmed I'm on 3.4.2 (from RubyGems) and have made sure by manually gem uninstall webmock and reinstalling. My Gemfile.lock says 3.4.2, but when I run gem open webmock, the api.rb file doesn't include the new def (nor does the Readme).
If I source it in my Gemfile like this, it does work:
gem 'webmock', git: 'https://github.com/bblimke/webmock.git', branch: 'master'
Seems like a RubyGems issue?

Hi! No this is not a RubyGems issue, 3.4.2 does not include this additional API call.
When a new release will be published you will be able to use it without getting the master branch. :)

So I'm reading this backward?
https://github.com/bblimke/webmock/compare/v3.4.2...master

Yes this is exactly what it means :)
If you notice here it says  4 commits to master since this tag.
When the new version is published you will see the last commit to be something like this one https://github.com/bblimke/webmock/commit/b6c5b43644b209a45b3d71e17b230dcc1fc5d056 and will be visible here.


Not working on Sentry 7.7.4

Just updated my Sentry install and the Slack plugin now fails with There was an internal error with the Plugin.
Not sure where to find logs but if you point me to the right location I'll grab them for you.

+1
I was wondering why it didn't appear.. I don't get any error message or so. Also there was nothing in the gunicorn error log.

Have just upgraded to Sentry 8 and get this too :(

Got it working again by commenting out the lines with username in plugin.py

This was fixed with 0.5.0.

Hi, I'm using Sentry 8.4.0dev0 with Slack Plugin 0.5.5 and I had the same problem.


Widget issues on Craft 5?

Hi,
I'm trying to add widget in dashboard, and when trying to save widget I get "Couldn't save widget" error message, and then Dashboard breaks and can't be opened. Error is this:

Craft 5.5.2
Local DDEV env
Thanks

The issue happens only when one particular Section is selected, when All (*) is selected, then it works


fix: apply automated fix because of deprecations

Signed-off-by: Harikrishnan Balagopal<EMAIL_ADDRESS>

Does this fix #31?


Prepend namespace method

Purpose or Intent
For pluggable provider changes we need to be able to set the
additional namespace to search when looking for instances and
methods. If we detect a vendor we set the additional namespace
to search. This is done in a builtin method as part of parse_provider_category
Links

https://github.com/ManageIQ/manageiq/pull/9917
https://github.com/ManageIQ/manageiq/pull/9468

Steps for Testing/QA

When testing pluggable providers we should be able to locate methods and instances from vendor namespaces. e.g.
/ManageIQ_Provider/Amazon/Cloud/VM/Provisioning/StateMachines/Methods/check_provisioned
in favor of
/ ManageIQ/Cloud/VM/Provisioning/StateMachines/Methods/check_provisioned

Here Amazon is the namespace that was prepended to the search, it allows us to  keep the base relationships to be the same.

@gmcculloug @tinaafitz @billfitzgerald0120 @Fryguy
Please review

Closed in favor of https://github.com/ManageIQ/manageiq/pull/10093


WIP: EBI-ENA test

Sorry @ElDeveloper, should have used WIP as I'm still working on this and will take a few commits to make this work.

Codecov Report

Merging #2516 into dev will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #2516   +/-   ##
=======================================
  Coverage   94.48%   94.48%
=======================================
  Files         160      160
  Lines       19442    19442
=======================================
  Hits        18369    18369
  Misses       1073     1073

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7462867...e2c049c. Read the comment docs.

is it still WIP? some check are failing

Yup, it's the configuration of the environmental variable, not the code per se. So code reviews will be appreciated while we figure out the error. Thanks!


No way to provide 'exec form' to buildah config --entrypoint

The Dockerfile ENTRYPOINT parameter provides two 'forms' of operation, that behave slightly differently. These forms are summarised in the Docker documentation here:
https://docs.docker.com/engine/reference/builder/#entrypoint
If an array is used for ENTRYPOINT, the command is interpreted as exec form
If a string is used for ENTRYPOINT, the command is interpreted as shell form
Unfortunately, the shell form doesn't take parameters in that are passed to the container.
The problem is, buildah config --entrypoint can only take a string parameter, so you can't currently configure a container with buildah config to use the exec (array) preferred form.
The differences in the behaviour can be seen in the following Dockerfile examples:
If ENTRYPOINT is declared as an array:
FROM centos
ADD showparams.sh /
ENTRYPOINT [ "/showparams.sh" ]

Results in:
            "Entrypoint": [
                "/showparams.sh"
            ],

If ENTRYPOINT is declared as a string:
FROM centos
ADD showparams.sh /
ENTRYPOINT /showparams.sh

Results in:
            "Entrypoint": [
                "/bin/sh",
                "-c",
                "/showparams.sh"
            ],

Talking with @pixdrift via IRC:
tsweeney> any reason to not just do it the Docker style?
<tsweeney> [ "/showparams.sh", "myinputdata" ]
<tsweeney> as a for instance.
<pixdrift> complex to parse on command line?
<pixdrift> although possibly not..
<pixdrift> maybe if it was hard quoted?
<pixdrift> --entrypoint '[ "/showparams.sh", "myinputdata" ]'
<tsweeney> yeah, something like that with doc.
<pixdrift> although.. you could check if the first character is '[' and parse accordingly
<tsweeney> yep, that too.

@rhatdan and/or @nalind WDYT?

Tom can you see if you can get this to work.

@pixdrift Now that we have the PR Merged can we close this issue?

Yep.


Feature Req.: multi-server main channel

Feature request:
Can we have it keep track of both server id and channel id in the db, so that we can set up a main channel per server.

Great idea!

Works like a charm. Thanks


Added new icons for the emote wheel

About the PR

Added new icons for the emote wheel
Why / Balance

Differentiate the actions at a glance, and add clarity
Fixes #27467
Technical details

Added new icons under Textures/Interface/Emotes, modified yaml files to reference them
Media

[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

:cl: Allen

add: Added new icons for the emote wheel

Finished the last of my cleanup, barring any feedback requiring changes, this is good to review

new icons probably need some kind of attribution data?

I added an attributions.yml to the emotes folder

Looks so weird


Updated Danish localization

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: LTank sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Coverage decreased (-1.4%) to 53.673% when pulling caee0a499fcc5841ecd57eaa423114923fc751ba on LTank:add-simon-lfr into d47947f25ec7de5b0cb3820030f652aa68974677 on Microsoft:master.

Please add an entry to CHANGELOG.md. Thanks for your contribution!


io: Add a README and declare MSRV to be 1.56.1

Copy the crate docs from lib.rs to create a minimal README file.
Include a section declaring the current MSRV to be 1.56.1

Re the docs, I pure cut'n'pasted these from lib.rs without thinking too much about it. I can put in more effort, thanks for the review.

Ah, OK, I didn't notice lib.rs has the same doc

Force push now changes the crate level rustdoc and copies the new content to README.md. Please re-review.

Used 'so' as suggested. No other changes.


Gebruikers en profile pagina mobile responsiveness

The schedule assignments for a user are cut off on mobile, which I think might be because of the sidebar (the profile looks fine on the user account page). There's also leftover commented code in UserElement.tsx.

Isn't used on mobile, only profile page which is responsive.


environment variables no longer added to main.js with application build

Command
build
Is this a regression?

[X] Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was
No response
Description
After upgrading to angular 18 and the new build system, the output main.js file no longer contains environment variables.
My environment.prod.ts file looks like this:
export const environment = {
production: true,
aadClientId: '{#Config:Op.Front.MyApp:AzureAd:ClientId#}',
// more variables here
}
and the deployment pipeline in azure would search in main.xxx.js to replace placeholders with appropriate values based on environment (dev, staging, prod)
however with the new angular build system, the generated main file ( for example browser/main-Y276RYOS.js')  no longer contains the placeholder.
Why is that ? Is there a way to keep the old behavior ? Otherwise my deployment pipeline in azure just doesn't work anymore and I'm not sure how to refactor this ..
Minimal Reproduction
steps are described above in description
Exception or Error
No response
Your Environment
Angular CLI: 18.0.4
Node: 20.11.1
Package Manager: npm 10.2.4
OS: win32 x64

Angular: 18.0.3
... animations, cdk, common, compiler, compiler-cli, core, forms
... localize, platform-browser, platform-browser-dynamic, router

Package                         Version
---------------------------------------------------------
@angular-devkit/architect       0.1800.4
@angular-devkit/build-angular   18.0.4
@angular-devkit/core            18.0.4
@angular-devkit/schematics      18.0.4
@angular/cli                    18.0.4
@schematics/angular             18.0.4
ng-packagr                      18.0.0
rxjs                            7.8.1
typescript                      5.4.5
zone.js                         0.14.2

Anything else relevant?
No response

Hi @graphicsxp, file replacements still work the same way. Could you please share your angular.json file?

Hello.  Sure, here it is
angular.json
I have not changed anything about fileReplacements. As you can see only parts related to new builder were changed automatically during upgrade.

This should work. Can you setup a minimal repro please?
You can read here why this is needed. A good way to make a minimal repro is to create a new app via ng new repro-app and adding the minimum possible code to show the problem. Then you can push this repository to github and link it here.

I can try but that's not easy. Did you see my angular.json ?  It's an angular workspace made of several app/libraries.....
Before that, could you at least tell me where the content of environment.prod.ts is going after build run ?  Used to be in main.xxx.js but what about now with the new build ?

Before that, could you at least tell me where the content of environment.prod.ts is going after build run ? Used to be in main.xxx.js but what about now with the new build ?

It depends on the usage, if it is used in multiple chunks, it can be located in a shared bundle (chunk-xxxx.js)

It depends on the usage, if it is used in multiple chunks, it can be located in a shared bundle (chunk-xxxx.js)
right. with webpack the content of the environment file was always in main.xxx.js.  So I'll have to find out in which file it is and adapt my azure pipeline to replace tokens in that file instead. I had a quick look last night but I didn't see it in other files, I will loook again.

@alan-agius4 , you were right !  I found my environment placeholders in one of the chunk file. I'll update my pipeline accordingly.
Thanks a lot !


Update readme.md

Remove extra function call

The docs are correct, pending publishing of the upcoming stable version

Merged another PR for this 🙏


Atlas update

Added dorms to Atlas, edited the entirety of Epi on Saltern, made various fixes to both.
:cl:

add: Added booze-o-mat to Atlas
add: Added dorms to Atlas
add: Moved chapel on Saltern to be in Epistemics
changed: Redid the interior of Science to be more Epistemics-y and to have a more decorated feel
remove: Old Saltern chapel has a very different feel

No need for a change log for every small detail, just add "Fixed saltern/atlas bugs"
Seperate Saltern and Atlas' into different PRs

Otherwise everything else lgtm


Optimize SPIRV shader compilation time

While working on Dishonored 2 stalls I spent some time optimizing the SPIRV shader compilation and ended up with this. It's not solving anything with the game stalls (which are because of new pipeline compilation during gameplay), but I could measure the game initial loading time going from ~10s to ~6s.
Feel free to take it or reject, I'd completely understand if that's not a super high priority as shader compilation is slow anyway and only supposed to happen during loading times.

I haven't really had the time to take a closer look at this yet, but users report that it also helps Warframe a bit. Not high priority by any means, but interesting regardless.

Sure, in any case loading times are also constrained by wine heap performance, which is currently really bad. I have some wip patches to improve that but it's completely experimental (and quite unrelated).

I'll report that it breaks Star Citizen (crashing on the universe sandbox loading screen) with no log or anything useful to debug the problem attached 🐸
I guess I could give vk validation layer a shot.

I'll report that it breaks Star Citizen (crashing on the universe sandbox loading screen) with no log or anything useful to debug the problem attached 🐸
I guess I could give vk validation layer a shot.

Does it crash with the fix?

Just updated with the typo corrected.

I removed a remaining ID allocation and the shaders are now generated identically as far as I can tell. I feel surprising that it would fix the SC crash though.

@Tk-Glitch could you please retest it after the last changes?

Just tested. The crash is still there on SC when that PR is applied even after the recent changes.
On another note, GCC10 fails to compile DXVK with this PR:
[71/266] Compiling C++ object 'src/spirv/e922df6<EMAIL_ADDRESS>FAILED: src/spirv/e922df6<EMAIL_ADDRESS>ccache x86_64-w64-mingw32-g++ -Isrc/spirv/e922df6@@spirv@sta -Isrc/spirv -I../../../dxvk-master/src/spirv -I../../../dxvk-master/include -fdiagnostics-color=always -pipe -Wall -Winvalid-pch -Wnon-virtual-dtor -std=c++17 -O3 -DNOMINMAX -MD -MQ 'src/spirv/e922df6<EMAIL_ADDRESS>-MF 'src/spirv/e922df6<EMAIL_ADDRESS>-o 'src/spirv/e922df6<EMAIL_ADDRESS>-c ../../../dxvk-master/src/spirv/spirv_module.cpp
../../../dxvk-master/src/spirv/spirv_module.cpp: In member function ‘uint32_t dxvk::SpirvModule::defIntType(uint32_t, uint32_t)’:
../../../dxvk-master/src/spirv/spirv_module.cpp:699:11: error: narrowing conversion of ‘-64’ from ‘int’ to ‘unsigned int’ [-Wnarrowing]
  699 |     case -64:
      |           ^~
../../../dxvk-master/src/spirv/spirv_module.cpp:702:11: error: narrowing conversion of ‘-32’ from ‘int’ to ‘unsigned int’ [-Wnarrowing]
  702 |     case -32:
      |           ^~
../../../dxvk-master/src/spirv/spirv_module.cpp:705:11: error: narrowing conversion of ‘-16’ from ‘int’ to ‘unsigned int’ [-Wnarrowing]
  705 |     case -16:
      |           ^~
../../../dxvk-master/src/spirv/spirv_module.cpp:708:11: error: narrowing conversion of ‘-8’ from ‘int’ to ‘unsigned int’ [-Wnarrowing]
  708 |     case -8:
      |           ^
[84/266] Compiling C++ object 'src/dxvk/1752c3e<EMAIL_ADDRESS>ninja: build stopped: subcommand failed.

While GCC9.3.1 will output the following warning:
[147/266] Compiling C++ object 'src/dxvk/1752c3e<EMAIL_ADDRESS>In file included from ../../../dxvk-master/src/dxvk/dxvk_shader.h:10,
                 from ../../../dxvk-master/src/dxvk/dxvk_shader.cpp:1:
../../../dxvk-master/src/dxvk/../spirv/spirv_writer.h: In instantiation of ‘void dxvk::SpirvWriter<SpirvBuffer>::erase(size_t) [with SpirvBuffer = dxvk::SpirvCodeBuffer; size_t = long long unsigned int]’:
../../../dxvk-master/src/dxvk/dxvk_shader.cpp:354:17:   required from here
../../../dxvk-master/src/dxvk/../spirv/spirv_writer.h:183:17: warning: comparison of integer expressions of different signedness: ‘size_t’ {aka ‘long long unsigned int’} and ‘int’ [-Wsign-compare]
  183 |       if (m_ptr == -1)
      |           ~~~~~~^~~~~
[261/266] Linking target src/d3d10/d3d10core.dll

Crashes Dark Souls 3 on Windows.
[0x0]   ntdll!NtWaitForMultipleObjects + 0x14
[0x1]   KERNELBASE!WaitForMultipleObjectsEx + 0x107
[0x2]   KERNELBASE!WaitForMultipleObjects + 0xe
[0x3]   kernel32!WerpReportFaultInternal + 0x51b
[0x4]   kernel32!WerpReportFault + 0xac
[0x5]   KERNELBASE!UnhandledExceptionFilter + 0x3b8
[0x6]   ntdll!RtlUserThreadStart$filt$0 + 0xa2
[0x7]   ntdll!_C_specific_handler + 0x96
[0x8]   ntdll!RtlpExecuteHandlerForException + 0xf
[0x9]   ntdll!RtlDispatchException + 0x219
[0xa]   ntdll!KiUserExceptionDispatch + 0x2e
[0xb]   amdvlk64!vk_icdGetInstanceProcAddrSG + 0xfb00
[0xc]   amdvlk64!vk_icdGetInstanceProcAddrSG + 0xcebb
[0xd]   amdvlk64!vk_icdGetInstanceProcAddrSG + 0x5333
[0xe]   amdvlk64!vk_icdGetInstanceProcAddrSG + 0x6b4f
[0xf]   amdvlk64!vk_icdNegotiateLoaderICDInterfaceVersion + 0x615bf
[0x10]   amdvlk64!vk_icdNegotiateLoaderICDInterfaceVersion + 0x4a603
[0x11]   amdvlk64!vk_icdNegotiateLoaderICDInterfaceVersion + 0x50bfd
[0x12]   amdvlk64!vk_icdNegotiateLoaderICDInterfaceVersion + 0x146cc
[0x13]   VkLayer_steam_fossilize64 + 0x2b4e8
[0x14]   d3d11!createPipeline + 0xe21
[0x15]   d3d11!createInstance + 0x39
[0x16]   d3d11!compilePipeline + 0x68
[0x17]   d3d11!compilePipelines + 0x339
[0x18]   d3d11!workerFunc + 0x3cd
[0x19]   d3d11!threadProc + 0x1f
[0x1a]   kernel32!BaseThreadInitThunk + 0x14
[0x1b]   ntdll!RtlUserThreadStart + 0x21

in dxvk_graphics.cpp in line 405:
    if (m_vkd->vkCreateGraphicsPipelines(m_vkd->device(),
          m_pipeMgr->m_cache->handle(), 1, &info, nullptr, &pipeline) != VK_SUCCESS) {

Thanks, I can probably try Dark Souls 3. Does it crash early? Only on Windows?

It crashes immediately after start. You probably need my dxvk-cache file. I only tested on Windows.

I can reproduce the crash, I'll have a look thanks.

I was a bit greedy and tried to put too much in the SpirvWriter commit. I've rewritten that and split the commit and it now works fine with Dark Souls III.

That also fixed the SC issue 🎉

I've been building DXVK with this PR included for over a month now and so far no issue has occurred in any application (If issues occurred, I of course also checked without this PR.). Though I must admit that I haven't yet perceived a substantial improvement in real world shader compile times either, but that might be just my subjective impression.

I have also been building and using dxvk with this PR for over a months and have not run into any issues related to the PR.

I tried this PR on top of master, seems to work just fine.

Thought I'd give an update. I've had this PR as part of my local DXVK build since I left my previous comment, so about 1.5 months now. I haven't experienced any problems, and Squad does start up faster than with an unpatched build.

I'm just refreshing this, rebasing the branch and addressing the comment above. It now uses bit::cast instead of direct memcpy, and the additional DxvkShader constructor is less verbose, passing a const SpirvModule& and building flags directly from it instead.

https://github.com/doitsujin/dxvk/issues/1913
This PR became borkened by mentioned commit :crying_cat_face:

https://github.com/doitsujin/dxvk/issues/1913
This PR became borkened by mentioned commit :crying_cat_face:

Rebased. It would be nice though, if the PR is considered useful as it seems, to have it merged. I'm happy to make changes too, just tell me.

Rebased. It would be nice though, if the PR is considered useful as it seems, to have it merged. I'm happy to make changes too, just tell me.

I've been using dxvk with this newer rebased version of this PR for a while now. So far no issues at all, and it does seems to load a bit faster. It would be cool if this would get merged.

@JustinSpedding
I have had some strange issues (crashing, not able to create D3D adapter) when using this patchset and compiling on Ubuntu. If i add -march=native i do not seem to have issues with it tho, but this is not the case when compiling using arch in a docker image... then again, if i use -march=native in docker with the arch image, it seems to produce borked binaries.
Not to go too much into details about this, my point being that it MAY cause strange issues with some distro's.
This could be AVX related, as debian/ubuntu uses some distro spesific AVX patches that arch might not use - https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=939559
I have only had these issues when using this particular patchset, so it may be "unsafe" in that regard, and i have not studied steam-docker-ubuntu-custom-mingw stuff enough to figure out if that could end up to be a problem there if it gets upstreamed. As i said, compiling this in a arch docker-image does seem to work just fine, but afaik steam uses a custom debian image (correct me if i am totally off here tho).

What is the status on this MR? I found it quite useful, but now it has merge conflicts with the master branch. idk if anyone cares to rebase it or figure out the potential non-debian distro issue that SveSop mentioned earlier.

Is this PR still applicable to DXVK 2.x? Currently using DXVK to play Overwatch 2 and I'd like not having to wait as long every time I start the game.

Rebased the changes, as I think it might still be relevant. For instance, Overwatch 2 shader compilation is faster and stutters a lot less with these changes.
The main improvement comes from the reduced number of allocations, although this is now also mitigated with Low Fragmentation Heap being upstream in Wine.

I needed to add #include <optional> in src/spirv/spirv_module.h to get it to compile on my machine, but otherwise, it works.

I also looked at the GitHub checks, #include <optional> should fix it.

I've tried to revisit this now that GPL caching is in RADV and SPIR-V translation would be the only uncacheable thing in the pipeline. Insights below are from OW2 which happens to be a easy test case, with lots of shaders (78K) loaded on startup.
The defType and defConst changes are definitely the most impactful ones (at around 30%) — they're called all the time and linear search complexity is getting out of control. For the design, I wonder if always using a hash map would be better:

Pro: The linear search code path can be removed
Pro: No need to separately declare specialized cache for each type
Con: Searching might be annoying (C++20 has heterogeneous lookup which helps with this)
Con: Maybe higher constant overhead

I've also looked into compression: it's less impactful than the type / const changes, as only around 7% of time is spent there. I've played with https://github.com/lemire/streamvbyte which I think is well suited for SPIR-V because:

Control bytes are stored in a separate stream, and each word can be allocated 8/16/24/32 bits. VarInt has the problem of being 7/14/21/28/35 and not matching certain usage patterns well. Compression ratio seems to be higher (53% -> 50%)
It has a SIMD implementation and it's really fast to encode and decode.

SVB brings the compression overhead down to 3%, so maybe it's worth pursuiting, with the compression ratio improvement also considered.

any updates on this?

Looks like this has merge conflicts now. I've been using it for a while with good results, but do not have enough experience with the dxvk codebase to rebase it on top of the recent changes.


Unable to pass two source-folder in github action yml file

when adding two folders in source-folder (https://github.com/tosandip/ci-configuration-examples/actions/runs/5980283253/workflow#L35) , it converts into this
addpath(genpath('code samplecode'));
which is incorrect leading to the error I see in the matlab runner: https://github.com/tosandip/ci-configuration-examples/actions/runs/5980283253/job/16226096632#step:4:579

You need to use a colon-separated or semicolon-separated list to specify multiple folders.
Try:
      - name: Run all tests
        uses: matlab-actions/run-tests@v1
        with:
          source-folder: code; samplecode

That worked. Thank you.


Create a JS framework starter sample

We already have a ui-react-starter sample that shows developers how to get start building plugin UI with React.
We'd like to have a similar starter for other frameworks, for example:

Angular
~Vue~ (covered by #26)
Svelte
etc

This issue can broken out by framework so different contributors are welcome to work on a sample for their chosen framework. We recommend that you consider taking up creating the equivalent sample for XD as well.

Hey @ashryanbeats, would like to work on the Vue Starter sample. Please assign it to me, thanks.

Awesome @PragatiVerma18! I made you a new issue in #26. :)

Hey @ErinFinnegan  and @kerrishotts, I'm currently exploring a ton with integrating Svelte/UXP. Is it okay if I grab an issue for a Svelte starter sample?

Absolutely, @jake-pauls ! Go for it!

Hi @ErinFinnegan! I noticed the current Vue sample is a bit different from a typical Vue starter sample. Would it be okay if I created a new issue to update that?

I don't know if you need to create an entirely new issue... you could just do some PRs... but you can create an issue if you think that's more convenient.


mf.update_from_chk() does nothing to a mean-field object

Hi, it seems that mf.update_from_chk() does nothing to a mean-field object. The calculation doesn't start from the final result of the input chkfile, which can be seen from the scf cycle energies.
Below is an example using a molecular system.
Here's a comparison between restarting a calculation from chkfile with setting mf.init_guess, using mf.from_chk() and using mf.update_from_chk():
The code that starts from a default initial guess:
from pyscf import gto, dft

cell = gto.M(
    atom = '''H     0.      0.      0.
              F     0.  0.  1.72''',
    basis = 'ccpvdz',
    verbose = 4,
)

mf = dft.KS(cell).density_fit()
mf.chkfile='mol_dz.hdf5'
mf.kernel()

grep cycle of the output:
diis_start_cycle = 1
SCF max_cycles = 50
cycle= 1 E= -99.4315635429608  delta_E= 0.0712  |g|= 0.84  |ddm|= 0.758
cycle= 2 E= -98.352461368606  delta_E= 1.08  |g|= 2.12  |ddm|= 1.89
cycle= 3 E= -99.5969416697485  delta_E= -1.24  |g|= 0.332  |ddm|= 1.65
cycle= 4 E= -99.627040210629  delta_E= -0.0301  |g|= 0.164  |ddm|= 0.231
cycle= 5 E= -99.6198222028654  delta_E= 0.00722  |g|= 0.206  |ddm|= 0.106
cycle= 6 E= -99.6248190568322  delta_E= -0.005  |g|= 0.157  |ddm|= 0.0387
cycle= 7 E= -99.6313806899915  delta_E= -0.00656  |g|= 0.0035  |ddm|= 0.116
cycle= 8 E= -99.631383383932  delta_E= -2.69e-06  |g|= 0.00166  |ddm|= 0.0038
cycle= 9 E= -99.6313841461299  delta_E= -7.62e-07  |g|= 0.000193  |ddm|= 0.00137
cycle= 10 E= -99.6313841565318  delta_E= -1.04e-08  |g|= 5.28e-07  |ddm|= 0.000142
cycle= 11 E= -99.631384156532  delta_E= -2.13e-13  |g|= 1.16e-08  |ddm|= 4.89e-07
Extra cycle  E= -99.631384156532  delta_E= 7.11e-14  |g|= 5.74e-08  |ddm|= 4.56e-08

Restart by setting mf.init_guess:
from pyscf import gto, dft

cell = gto.M(
    atom = '''H     0.      0.      0.
              F     0.  0.  1.72''',
    basis = 'ccpvdz',
    verbose = 4,
)

mf = dft.KS(cell).density_fit()
mf.chkfile='mol_dz.hdf5'
mf.init_guess = 'chkfile'
mf.kernel()

grep cycle of the output:
diis_start_cycle = 1
SCF max_cycles = 50
cycle= 1 E= -99.6313841565266  delta_E= -9.95e-14  |g|= 2.89e-07  |ddm|= 2.29e-07
Extra cycle  E= -99.6313841565262  delta_E= 3.98e-13  |g|= 1.46e-06  |ddm|= 1.16e-06

Restart using mf.from_chk():
from pyscf import gto, dft

cell = gto.M(
    atom = '''H     0.      0.      0.
              F     0.  0.  1.72''',
    basis = 'ccpvdz',
    verbose = 4,
)

mf = dft.KS(cell).density_fit()
dm = mf.from_chk("mol_dz.hdf5")
mf.kernel(dm)

grep cycle of the output:
diis_start_cycle = 1
SCF max_cycles = 50
cycle= 1 E= -99.6313841565267  delta_E= -1.28e-13  |g|= 2.89e-07  |ddm|= 2.29e-07
Extra cycle  E= -99.6313841565262  delta_E= 4.26e-13  |g|= 1.46e-06  |ddm|= 1.16e-06

Restart using mf.update_from_chk():
from pyscf import gto, dft

cell = gto.M(
    atom = '''H     0.      0.      0.
              F     0.  0.  1.72''',
    basis = 'ccpvdz',
    verbose = 4,
)

mf = dft.KS(cell).density_fit()
mf.update_from_chk("mol_dz.hdf5")
mf.kernel()

grep cycle of the output:
diis_start_cycle = 1
SCF max_cycles = 50
cycle= 1 E= -99.4315635429608  delta_E= 0.0712  |g|= 0.84  |ddm|= 0.758
cycle= 2 E= -98.3524613686059  delta_E= 1.08  |g|= 2.12  |ddm|= 1.89
cycle= 3 E= -99.5969416697484  delta_E= -1.24  |g|= 0.332  |ddm|= 1.65
cycle= 4 E= -99.6270402106289  delta_E= -0.0301  |g|= 0.164  |ddm|= 0.231
cycle= 5 E= -99.6198222028654  delta_E= 0.00722  |g|= 0.206  |ddm|= 0.106
cycle= 6 E= -99.6248190568322  delta_E= -0.005  |g|= 0.157  |ddm|= 0.0387
cycle= 7 E= -99.6313806899915  delta_E= -0.00656  |g|= 0.0035  |ddm|= 0.116
cycle= 8 E= -99.6313833839319  delta_E= -2.69e-06  |g|= 0.00166  |ddm|= 0.0038
cycle= 9 E= -99.6313841461299  delta_E= -7.62e-07  |g|= 0.000193  |ddm|= 0.00137
cycle= 10 E= -99.631384156532  delta_E= -1.04e-08  |g|= 5.28e-07  |ddm|= 0.000142
cycle= 11 E= -99.631384156532  delta_E= 1.42e-14  |g|= 1.16e-08  |ddm|= 4.89e-07
Extra cycle  E= -99.631384156532  delta_E=    0  |g|= 5.74e-08  |ddm|= 4.56e-08

In other words, mf.update_from_chk() is the only method that fails to restart the calculation from the chkfile, and it's obviously using the default initial guess, juding from its identical output to that of the original calculation.
According to pyscf documentation, it should 'Read attributes from the chkfile then replace the attributes of current object.'. But it seems it's not working as expected?

According to pyscf documentation, it should 'Read attributes from the chkfile then replace the attributes of current object.'. But it seems it's not working as expected?

Because the density matrix is not an attribute of the mean-field object (while the mo_coeff and mo_occ is).
So you need to pass the dm to kernel
from pyscf import gto, dft

cell = gto.M(
    atom = '''H     0.      0.      0.
              F     0.  0.  1.72''',
    basis = 'ccpvdz',
    verbose = 4,
)

mf = dft.KS(cell).density_fit()
mf.update_from_chk("mol_dz.hdf5")
dm = mf.make_rdm1()
mf.kernel(dm)

Here, make_rdm1 will use the updated mo_coeff and mo_occ to produce the required dm.

Thank you @hebrewsnabla , it works.
However, when I try to use this dm as the initial guess for a calculation with a larger basis set (tz instead of dz) as shown in the following code
from pyscf import gto, dft

cell = gto.M(
    atom = '''H     0.      0.      0.
              F     0.  0.  1.72''',
    basis = 'ccpvtz',
    verbose = 4,
)

mf = dft.KS(cell).density_fit()
mf.update_from_chk("mol_dz.hdf5")
dm = mf.make_rdm1()
mf.kernel(dm)

I get the following error
Traceback (most recent call last):
  File "/Users/chow/research/test/update_from_chk_example/mol_tz_update_dz.py", line 13, in <module>
    mf.kernel(dm)
  File "/Users/chow/git clone/pyscf/pyscf/lib/misc.py", line 638, in aliased_fn
    return getattr(self, fname)(*args, **kwargs)
  File "/Users/chow/git clone/pyscf/pyscf/scf/hf.py", line 1669, in scf
    kernel(self, self.conv_tol, self.conv_tol_grad,
  File "/Users/chow/git clone/pyscf/pyscf/scf/hf.py", line 128, in kernel
    vhf = mf.get_veff(mol, dm)
  File "/Users/chow/git clone/pyscf/pyscf/dft/rks.py", line 69, in get_veff
    ks.initialize_grids(mol, dm)
  File "/Users/chow/git clone/pyscf/pyscf/dft/rks.py", line 489, in initialize_grids
    self.grids = prune_small_rho_grids_(self, self.mol, dm,
  File "/Users/chow/git clone/pyscf/pyscf/dft/rks.py", line 252, in prune_small_rho_grids_
    rho = ks._numint.get_rho(mol, dm, grids, ks.max_memory)
  File "/Users/chow/git clone/pyscf/pyscf/dft/numint.py", line 2487, in get_rho
    for ao, mask, weight, coords \
  File "/Users/chow/git clone/pyscf/pyscf/dft/numint.py", line 2529, in block_loop
    ao = self.eval_ao(mol, coords, deriv=deriv, non0tab=non0, out=buf)
  File "/Users/chow/git clone/pyscf/pyscf/dft/numint.py", line 2499, in eval_ao
    return eval_ao(mol, coords, deriv, shls_slice, non0tab, out, verbose)
  File "/Users/chow/git clone/pyscf/pyscf/dft/numint.py", line 111, in eval_ao
    return mol.eval_gto(feval, coords, comp, shls_slice, non0tab, out=out)
  File "/Users/chow/git clone/pyscf/pyscf/gto/eval_gto.py", line 113, in eval_gto
    ao = numpy.ndarray((comp,nao,ngrids), buffer=out)
TypeError: buffer is too small for requested array

I tried to do the same thing (projecting to a larger basis set) with another method mf.from_chk(), but that doesn't work for periodic systems, as I mentioned in another issue #1317 . Would you have any suggestion for achieving this?

So, as you observed, from_chk() works but update_from_chk() doesn't, for the small-to-larger-basis restart? That's reasonable, because update_from_chk() only updates the attributes but does not perform the projection, while from_chk() performs the projection (so does init_guess by chkfile).
Currently I have no idea on the periodic issue.

PBC SCF calculations are similar to molecular SCF. from_chk returns a projected density matrix while update_from_chk simply overwrites the scf object