Parse nil value Xcode 10

I'm using OM 3.3 and Xcode 10. I found issue during parsing nil value
ImmutableMappable.swift
public func value<T>(_ key: String, nested: Bool? = nil, delimiter: String = ".", file: StaticString = #file, function: StaticString = #function, line: UInt = #line) throws -> T {
		let currentValue = self.currentValue(for: key, nested: nested, delimiter: delimiter)
		guard let value = currentValue as? T else {
			throw MapError(key: key, currentValue: currentValue, reason: "Cannot cast to '\(T.self)'", file: file, function: function, line: line)
		}
		return value
	}

This method returns value event if currentValue = nil, but should throw an error.
public func value<T>(_ value: Any?) throws -> T {
    let currentValue = value
    guard let value = currentValue as? T else {
        throw MachError(.aborted)
    }
    return value
}

class X {
    var a: Int!
}
let xObj = X()
do {
    xObj.a = try value(nil)
} catch {
    print("error \(error)")
}

You can try this code in playground, you will see that it will not go inside catch block. Replace var a: Int! to var a: Int = 0 and now it will go to catch.

This is probably a Swift issue.
If we change the value() function to:
public func value<T>(_ value: Any?) throws -> T {
    print(T.self as? Optional<Int>.Type)
    guard let value: T = value as? T else {
        throw MachError(.aborted)
    }
    return value
}

in the debugger we will see this:
Optional(Swift.Optional<Swift.Int>)

Which means that the cast succeed.
But if we change the function to:
public func value<T>(_ value: Any?) throws -> T {
    print(T.self as? Int.Type)
    guard let value: T = value as? T else {
        throw MachError(.aborted)
    }
    return value
}

in the debugger we will see nil.
So, the T type is not Int but Int? (since IUO are Optionals in swift 4.1+)
Probably the "optionality" of a Type is inside the actual type (T in this case) in swift 4.2
But this behaviour defeats the purpose of guard let statement.
This is interesting.


Trying to get in touch regarding a security issue

Hey there!
I'd like to report a security issue but cannot find contact instructions on your repository.
If not a hassle, might you kindly add a SECURITY.md file with an email, or another contact method? GitHub recommends this best practice to ensure security issues are responsibly disclosed, and it would serve as a simple instruction for security researchers in the future.
Thank you for your consideration, and I look forward to hearing from you!
(cc @huntr-helper)

@JamieSlome how could we get in touch. I'm interested to know the issue for our projects.

@holblin is the issue fixed in your fork?

I tried to contact them to have details. Except for asking meeting, I didn't receive any details of a security issue.
It might be fixed due to the changes I have done on regex and I think it might be something related to that. I don't see how this could be used or leveraged for attacks except maybe DOS but a lot of the consumers of the package (if not all) would not be impacted.


ValueError: You are trying to load a weight file containing 3 layers into a model with 1 layers.

I train a model with the following code:
base_model = VGG19(...)
..............
model.fit_generator(...., callbacks=[ModelCheckpoint(filepath=checkpoint_file, save_best_only=True,
                    save_weights_only=True)]....)

however, when I load the weights with the following code:
from keras.utils.training_utils import multi_gpu_model
model = load_vgg19(...)
model = multi_gpu_model(model, gpus=3)
model.load_weights(checkpoint_file)
model.fit_generator(...........)

I got the error:   ValueError: You are trying to load a weight file containing 3 layers into a model with 1 layers and followed by AttributeError: 'NoneType' object has no attribute 'TF_DeleteStatus'. Is this a bug?

This probably has something to do with multi_gpu_model copying your model onto multiple gpus. do a model.summary() after multi_gpu_model and you will see that you can't see the layers directly.
Could you try loading the weights before multi_gpu_model? It might work that way.
from keras.utils.training_utils import multi_gpu_model
model = load_vgg19(...)
model.load_weights(checkpoint_file) # DO THIS FIRST
model = multi_gpu_model(model, gpus=3) # split amongst multiple gpus
model.fit_generator(...........) # enjoy!

@jamesben6688 I encountered the same problem with you. After reading the source code of function multi_gpu_model and running parallel_model.summary(), I found that the original single gpu model structure is nested in the 'sequential_1' layer of parallel_model. And this 'sequential_1' layer is actually a keras.models.Sequential object(i.e. a sequential model), which means you can see the inside structure by running:
layer = parallel_model.get_layer('sequential_1') layer.summary()

I encountered the same problem. Thank to @akshaychawla 's comment, I figured it's caused by multi_gpu_model. The saved model was trained on two GPUs, then I tried to load the weights into the a model on a single GPU. This gave me the error. A simple solution is to make sure your new model use the same number of GPUs by calling multi_gpu_model.

As suggested by partivadas adding input shape fixed it for me.
Before:
tf.keras.layers.Flatten()
After:
tf.keras.layers.Flatten(input_shape=(28, 28))

Closing this issue since its resolved. Feel free to reopen if the problem still persists. Thanks!


[Question] Item price lista

how do you get the item price list

What i mean is how did you do it and how did yo store it in the J SON because i am unaware of how you did it and i would like to have a crack at it

Jesus Christ, I will block you. ITS IN THE CODE, READ
On Mon, Feb 20, 2017 at 10:34 PM Monphito<EMAIL_ADDRESS>wrote:

What i mean is how did you do it and how did yo store it in the J SON
because i am unaware of how you did it and i would like to have a crack at
it
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Arze1/CSGO-Overpay-Bot/issues/24#issuecomment-281236331,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ASwnzHLUFpOBQWJ7xw38-VP8vCh6x2Muks5reltRgaJpZM4MG1qX
.


docs(book): add missing links of integrations pages

Thank you very much. I realize you have been burdened with finding many of mistakes. I will try and be more conscientious. (This is one of the reasons I try and make things automated...)

I wasn't looking for mistakes, I just happened to find them, so don't mind me!


Update yard-doctest helpers, RELEASING.md, and CONTRIBUTING.md

This PR stubs service factory methods and Core methods to raise errors if invoked. The purpose is to detect leaks in the doctest mocks that invoke actual backend resources.

@swcloud @hxiong388 I made an attempt to document the doctest testing for future contributors. Any feedback/ideas?


Add API for enhancing uniform variable feeding

[ ] Uniform - Array member
Currently we have no way to set an individual member of an uniform array like illustrated below in pure WebGL.

// in JavaScript at init time
var someVec2Element0Loc = gl.getUniformLocation(someProgram, "u_someVec2[0]");
var someVec2Element1Loc = gl.getUniformLocation(someProgram, "u_someVec2[1]");
var someVec2Element2Loc = gl.getUniformLocation(someProgram, "u_someVec2[2]");
// at render time
gl.uniform2fv(someVec2Element0Loc, [1, 2]); // set element 0
gl.uniform2fv(someVec2Element1Loc, [3, 4]); // set element 1
gl.uniform2fv(someVec2Element2Loc, [5, 6]); // set element 2
It would be cool if we add such support at both Engine level and ShaderMaterial level.

[x] Uniform - int
It seems that we do not have an API for setting an integer uniform variable. In Engine class, we have setIntArray, setIntArray2, setIntArray3 and setIntArray4 but we do not have simple setInt. It is the same case in ShaderMaterial.

For point 1:

you can already call engine.setArray2(someVec2Element0Loc, [1, 2]);
Updating a part of an array in the ShaderMaterial does not make sense because the material will overwrite all values on every bind. But you can still use engine to update it manually without relying on the ShaderMaterial (do not call material.setArray and instead do everything with the engine)
Point 2 is done


Dataset reading issue

Please describe your the issue in as much detail as possible. We can discuss it further afterward.

@leilaMozaffari8 Whenever you have time, could you provide an explanation of current situation of dataset reading? It doesn't need to be ready.


Image - reusing the command to start the animation causes a crash error

I am using "mIRC v7.67" + "DCX dll v3.1-git469" in system "Windows 8.1 x64".
After creating a control "Image", in which automatically an animated image in the "GIF" format is launched, if used once or re-enter the command "/xdid -F $dname 1 +a 1", then an crash error occurs after which the work of the mIRC client shutdown.
Would like to see a fix for this problem. Thanks.

Here is a test piece of script to reproduce this the problem. To run the script click on "F5" or enter the command "/image_test":
alias F5 { image_test }
alias image_test {
  if ($dialog(image_test)) .dialog -x image_test | else { .dialog -m image_test image_test }
}
dialog image_test {
  title "Image test"
  icon $mircexe,0
  option pixels
  size -1 -1 450 300
}
on *:DIALOG:image_test:init:0:{
  .dcx Mark $dname image_test_work
  .xdialog -b $dname +ty
  .xdialog -g $dname +b $rgb(20,20,27)
  .xdialog -c $dname 1 image 30 25 390 250 notheme
  .xdid -x $dname 1 +b
  .xdid -S $dname 1 1
  .xdid -C $dname 1 +b $rgb(40,40,47)
  var %image_path image\gif\file1.gif
  if ($exists(%image_path)) .xdid -i $dname 1 +abh %image_path
  .xdid -F $dname 1 +a 1
}
alias image_test_work {}

Fixed.


pull request for e2e test at 01/10/2017 17:26:12

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Define Setup and TearDown callbacks as TEST greatest_<>_cb(void *udata);

I would like to make better use of Setup and TearDown for suites but in order to do I must be able to return a test result from them.
Take this example code which represents one of my test suites. In this test application my test suites are split up by functionality of a device. This is a paradigm I commonly use to organize tests.
TEST TestSetup()
{
    S16BIT s16Result;

    SKIP_TRUE(sInput.sFunc.sApi.IsValid); //Test if there is API support
    SKIP_TRUE(sInput.sFunc.sApi.u8DevNum == sInput.sDut.u8DevNum); // Test the DUT will be the device tested by this suite

    s16Result = My_Open_Dev(sInput.sFunc.sApi.u8DevNum);
    ASSERT_EQm("Failed to open API device", ERR_SUCCESS, s16Result);

    PASS();
}

/* This function will run after every test in this suite */
static void TearDown_CB(void* data)
{
    S16BIT s16Result;

    s16Result = My_Close_Dev(sInput.sFunc.sApi.u8DevNum);
    //ASSERT_EQm("Failed to close API device", s16Result == ERR_SUCCESS ? ERR_SUCCESS : ERR_DEV_NOT_INIT, s16Result);

    //PASS();
}

TEST ApiSelfTestResult()
{
    S16BIT s16Result;
    U32BIT u32TestResults;
    U8BIT u8DevNum = sInput.sFunc.sApi.u8DevNum;

    CHECK_CALL(TestSetup());
    s16Result = My_ApiSelfTest(u8DevNum, &u32TestResults);

    ASSERT_ENUM_EQ(ERR_SUCCESS, s16Result, Error2Str);
    ASSERT_EQ_FMTm("ApiSelfTest test results do not equal 0", 0, u32TestResults, "%X");

    PASS();
}

SUITE(apioperations_func_suite)
{
    SET_TEARDOWN(TearDown_CB, NULL);

    RUN_TEST(ApiStatusRead_ReadStatus);
}

In the setup I would like to check that the DUT has the necessary features that the suite will be testing. In the setup I would also like to call some functions to get the DUT into a common know state which will be used for every test in the suite. These function calls may fail as any other and I want to test them. The reason to use a setup function is because the steps that need to be performed are common to every test and need to be run at the start of each test in the suite. However by using a setup I am no longer able to skip a test or assert. There is a work around which is not too painful. A function can be define that does everything I would do in setup but its return type would be TEST. At the very beginning of each test CHECK_CALL can be used. This workaround can be see in the code above.
In the TearDown I would like to perform some clean up and check that things ended in a known condition. So once again I need to be able to assert. Additionally it is required that the TearDown is always run. I have not found a suitable workaround for TearDown. The technique I used for the Setup won't work for the teardown because a test is exited immediately on failure so a CHECK_CALL to a teardown function as the last line of a test is not valid. In my case it was more important to clean things so I chose to use the teardown callback and not make any additional asserts.

A function can be define that does everything I would do in setup but its return type would be TEST. At the very beginning of each test CHECK_CALL can be used. This workaround can be see in the code above.

I wouldn't consider that a workaround -- it's one of the reasons why I added CHECK_CALL in the first place. I should be more explicit about that in the README: "if your setup hook should be able to fail/skip the test, then use CHECK_CALL(setup(data)); in the body of the test instead".
teardown is a more complicated matter, though. I prefer to check that things are in a known condition during setup, at least in the general case, and do little to nothing in teardown itself. Making teardown able to fail an otherwise passing test would be an interface change (so it would have to wait until the next major version); while adding a function that can only be called from inside a teardown hook, which causes the most recently run test to fail, it seems kind of hacky.
Based on my understanding of your situation (testing with an external, stateful device -- I've been there), I suggest using a function at the start of test cases (via CHECK_CALL) which closes a previous connection, if any, and then does your SKIP_TRUE and then open calls. In cases where the test has otherwise passed, but would fail in teardown because it can't close the connection, I'd suggest putting a checked close at the end of your tests.
Also, while it doesn't directly address your issue, you may find using SHUFFLE_TESTS helpful for tracking down issues caused by incomplete test setup/teardown cleanup or unanticipated coupling between tests.


How to create components by code for example in for loop?

Question
I'm trying to create a Menu component similar to nested_list example. I successfully create them, so creating menus looks good and compiler guaranties, that <Menu> contains only <MenuItem> elements:
html!{
  <Menu>
    <MenuItem>{"item 1"}</MenuItem>
    <MenuItem>{"item 2"}</MenuItem>
    <MenuItem>{"item 3"}</MenuItem>
    //<div /> -- not compiled which is good!
  </Menu>
}

Now I want to compose that Menu component with TreeTable component and add menu that can manipulate visibility of columns. So I need to populate menu based on columns text.
html!{
  <Menu>
    {for self.columns.iter().map(|column| ???)}
  </Menu>
}

That is not compiled, because {for ...} returns Html (aka VNode), and not the MenuItem component. So is there any way to create MenuItem by code like that?

You're looking for the html_nested! macro which works exactly like the html! macro but returns the actual component type instead of Html.
use yew::macros::html_nested;

html! {
  <Menu>
    { for self.columns.iter().map(|column| html_nested! { <MenuItem>{ column }</MenuItem> }) }
  </Menu>
}

Thanks for that macro! I wonder why it's not documented? When this work for single element, unfortunally, this not work for for loops. So this works
html! {
  <Menu>
    { html_nested! { <MenuItem></MenuItem> }
  </Menu>
}

but this not
html! {
  <Menu>
    { for self.columns.iter().map(|column| html_nested! { <MenuItem>{ column }</MenuItem> }) }
  </Menu>
}

and this
html! {
  <Menu>
    {html_nested!{ for self.columns.iter().map(|column| html_nested! { <MenuItem>{ column }</MenuItem> }) }}
  </Menu>
}

I think this has come up before. I'll create an issue calling for it to be documented if there isn't already one.

We already have an issue! https://github.com/yewstack/yew/issues/1428

@Mingun ah, you're right, using for implicitly converts the items to Html too.
This should work:
let items: Vec<MenuItem> = self
    .columns
    .iter()
    .map(|column| html_nested! { <MenuItem>{ column }</MenuItem> })
    .collect();
html! {
  <Menu>
    { items }
  </Menu>
}

@siku2 , thank! With small change thats work. Type should be Vec<VChild<MenuItem>>:
let items: Vec<VChild<MenuItem>> = self
    .columns
    .iter()
    .map(|column| html_nested! { <MenuItem>{ column }</MenuItem> })
    .collect();
html! {
  <Menu>
    { items }
  </Menu>
}

oh right, forget to wrap it in VChild.
FYI, the fact that it wasn't working with { for ... } is a bug, I opened an issue for this here: #1527.

Ok, so I think that this issue can be closed, because there is already a task for documentation, and now also a bug. Thanks for you help!


Skip config.ini step in Docker instructions

Fix #124 (and make Docker instructions more coherent with non-Docker instructions).

Why not just running the setup executable?

Any specific reason, @dsakuma @gwmoura?

I think it is possible. But the setup run some commands that are not necessary in Docker. I will try to write a configuration that works both in Docker and non-Docker environment.

Thank you for that. IMHO this is discussion (basically ansent here) is what
is missing (not only in this repo, but in Jarbas too).
I'm a newbie in Docker, so I'll be that annoying person who shares a
concern with no clue about how to fix it: the important thing is to avoid
duplicating code/settings and, at the same time, alow users to get started
using the "normal" (local?) installation process or Docker.
What I mean is that if we set envvars at Dockerfile/docker-compose.yml they
either will be missing in the non-Docker instalation, or would be
duplicated in a INI file. (Again: I'm a noob in Docker and these claims
probably are nonsense. I was just exemplifying my concern here.)
Anyway, from your suggestion we have to inspect how the module that loads
the INI works, am I getting it right? Maybe I can help with that ; )
On Fri, 9 Dec 2016 at 13:11 Fabio Rehm<EMAIL_ADDRESS>wrote:

@fgrehm commented on this pull request.
In docker/Dockerfile
https://github.com/datasciencebr/serenata-de-amor/pull/127:

USER jovyan
COPY requirements.txt ./
COPY conda_requirements.txt ./
+COPY config.ini.example ./config.ini
Hum... have you guys discussed about just setting them up as ENVs on the
Dockerfile? (obviously, don't add any secret key there 😅) That way,
people just willing to try things out would be a git clone ... &&
docker-compose up -d from getting the env up and running while allowing
env vars to be overwritten by adding some entries under the environment
config of docker-compose.yml or just editing the config.ini.
But I believe we'll need to change the code that makes use of those
settings to prioritize env vars and fallback to the config file right?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/datasciencebr/serenata-de-amor/pull/127, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AEg3893IesoAOCOa8TyZo8fVVEUz93z8ks5rGW-pgaJpZM4Kv9c_
.

Anyway, from your suggestion we have to inspect how the module that loads
the INI works, am I getting it right? Maybe I can help with that ; )

My suggestion would be to have some sort of abstraction that is able to read configs from env vars and fallback to reading from the ini file. Another idea would be to drop the ini support and just go with using only env vars everywhere.
Last but not least, we could have a custom ENTRYPOINT that sets things up (ex: copy the .ini file to the right place) before running a given command specified either on the Dockerfile itself or provided by docker run / docker-compose.yml

My suggestion would be to have some sort of abstraction that is able to read configs from env vars and fallback to reading from the ini file. Another idea would be to drop the ini support and just go with using only env vars everywhere.

I guess python-decouple can handle that — what do you think about it. There are more robust solutions, such as dynaconf too.


Remove or redo quickstart.md, EditorSession state

the substance/doc/quickstart.md example is pretty broken.
It doesn't import EditorSession, it erroneously call cfg.import(SuperscriptPackage)  when SuperscriptPackage is already packaged into ProseEditorPackage, it uses configurator in place of cfg
const cfg = new Configurator()
...
let doc = configurator.createArticle(fixture)
  let editorSession = new EditorSession(doc, {
    configurator: configurator
  })

and even when you fix all of that the result is kind of a mess.
Also, it appears to me that EditorSession is only present on the current dev branch obtainable by using  "substance": "substance/substance#develop" in the package.json, and then building the project. If I just use npm install --save substance I get the older branch with documentSession instead.

I noticed all this (and more) too. Looks like they're in the middle of some huge refactoring. I do like the way they've structured everything.. very extensible. Most of the recent commits are tidying things up a lot, but I suspect they're going to change a lot more.
Yesterday I had to figure out how to configure webpack to do the postcss stuff they do with their bundler. Finally figured that out.. how have to figure out how to rework their reset.css because it mucks around too much with my css.

Hey,
You can find stable beta 5 in master branch.
On Fri, Dec 2, 2016, 00:29 Roland Quast<EMAIL_ADDRESS>wrote:

I noticed all this (and more) too. Looks like they're in the middle of
some huge refactoring. I do like the way they've structured everything..
very extensible. Most of the recent commits are tidying things up a lot,
but I suspect they're going to change a lot more.
Yesterday I had to figure out how to configure webpack to do the postcss
stuff they do with their bundler. Finally figured that out.. how have to
figure out how to rework their reset.css because it mucks around too much
with my css.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/substance/substance/issues/900#issuecomment-264285651,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AALG-gijD5IocJCPlCoDr5vzbpeE6-n4ks5rDy4egaJpZM4LBVf1
.

@Integral yup. I think the thing is that the examples use the develop branch (and it's changing frequently).
https://github.com/substance/examples/blob/develop/package.json#L6
Not a big issue for now while things are changing so much though the betas I think.

Hey! You are right, lots of things are moving at the moment. If you want to use the lib it's best to stick with the releases and upgrade the code once a new release is out. The reason why we have develop as the default branch is that we ensure PR's are always based on the latest code. We can merge them faster into the unstable branch as opposed to master which actually is the same as the release version. Will add a comment to the README.

Done. Closing this issue now. Thanks for the feedback!

Just a note in case anyone else has a problem with the reset.css. I had to remove the box sizing reset to get things to look normal with my uikit css.
*, *:after, *:before {
  -webkit-box-sizing:border-box;
     -moz-box-sizing:border-box;
          box-sizing:border-box;
}

(remove that).


Update main readme

Update to the main readme with a short description, updated install instructions and a best practices badge.
Replaces #232.

Closes #231


Minor bug fixes, upgrade to version v1.0.1

Description
Minor bug fixes, made bar chart width for memory dynamic and made single channel of struct type to send data over channels
Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)

Checklist:

[x] I have read the contribution guidelines and followed it as far as possible.
[x] I have performed a self-review of my own code (if applicable)
[x] I have commented my code, particularly in hard-to-understand areas (if applicable)
[x] I have run go fmt on my code (reference)
[x] I have made corresponding changes to the documentation (if applicable)
[x] My changes generate no new warnings
[x] Any dependent and pending changes have been merged and published

@MadhavJivrajani deleted export.go


Enable standard kubernetes-sigs upstream triage and staleness process

Description
What problem are you trying to solve?
We'd like to adopt the standard upstream triage process in kubernetes-sigs/karpenter. Ideally, we can orchestrate the following flow when an issue gets created:

An issue is created with a kind/* label. needs-triage is automatically added by k8s-ci-bot to the issue and won't be removed until the command /triage accepted is added to the issue.
An issue with /triage accepted indicates that a maintainer has seen the issue/feature/etc. and accepts that the issue should be given further consideration by the maintainer team. This is meant to sieve out issues that are not true bugs or need more information to classify them further.
We can get rid of the StaleBot CI job in favor of the k8s-ci-bot lifecycle/stale, lifecycle/rotten process that gets rid of triaged issues after 90d + 30d for stale -> rotten -> closed.

From looking over how kubernetes-sigs/kustomize does this, it looks like they enable this process through here in kubernetes/test-infra; however, it would be good to get more insight into how we could manage this process more similar to upstream from those who are more familiar with the upstream machinery.
More details around issue triaging guidelines can be found here: https://www.kubernetes.dev/docs/guide/issue-triage/

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

cc: @sftim @jackfrancis who might have more insight.

/sig contributor-experience testing

SIG Testing are the folks who can provide advice on GitHub automation, even if it's for issues.

/remove-lifecycle stale

would be good to have issues start with "kind/needs-triage" then we either

accept: take immediate action next couple of weeks
reject: not planned, never planned
defer: accept its something the team will tackle, but not right away

Also making better use of lifecycle frozen would be great as well.
I also wonder if having a small meeting once a month to comb through the lifecycle stale issues, prioritize them and build the community roadmap out would be useful. I have a clear picture of the azure roadmap, im sure the aws maintainers have a clear idea of their roadmap, but the community roadmap for core is not as clear.
Working group tells us immediate plans, but we could do better than that :)


Missing dependencies in xenial

Apologies I'm not aware of the background for this PR (https://github.com/ros2/poco_vendor/pull/18) - on xenial, libpoco-dev does not pull in PCRE or zlib.
As someone who builds ROS2 from source in CI on xenial and bionic, and depends on catkin_pkg/rosdep to resolve dependencies, I wonder: is there any harm in keeping those build_depends in poco_vendor, given that xenial is nominally a supported platform?

Apologies I'm not aware of the background for this PR (#18) - on xenial, libpoco-dev does not pull in PCRE or zlib.

No apology needed and thanks for asking for context. #18 was discussed offline today and I forgot to update the PR thread with the key points from that discussion. TWe decided to depend just on libpoco-dev since that's what the binary release on bionic will need and to add the poco build dependencies for Xenial to the Linux development environment setup guide.

Right, and that's understood. So my question is: is there any harm with leaving the dependencies from #18 in, while xenial is a supported platform?
For reference, my CI flow is essentially this:
rosinstall_generator ... # grab a subset of ROS2 packages from rosdistro
vcs import ...
rosdep install --ignore-src  # installl dependencies
colcon build #

Now, this works for ROS1 and ROS2, barring the following exceptions:

a few inconsistencies in libopensplice keys, that I've been meaning to PR
poco_vendor

I see that the linux dev setup guide has a lot of manual dependency installation going on, but I've coming from ROS1, I've typically dependenc on rosdep to pull in dependencies as declared in package.xml. This works particularly well if you're not building everything, but a subset of packages in the distro.
Is this unsupported?

So my question is: is there any harm with leaving the dependencies from #18 in, while xenial is a supported platform?

I don't think there is any harm as the libraries are pulled in by libpoco-dev anyway so it will just pull some additional development files but nothing big. So I think it's fine to add the dependencies back for xenial

I see that the linux dev setup guide has a lot of manual dependency installation going on, but coming from ROS1, I've typically depended on rosdep to pull in dependencies as declared in package.xml. This works particularly well if you're not building everything, but a subset of packages in the distro.
Is this unsupported?

This is not currently supported as several packages either don't have package.xml (third party dependencies) or use unresolved keys (DDS packages not released upstream).
This could be used for a subset of packages but there will be several cases where it won't work/ be optimal:

packages not necessary will be installed (e.g. all opencv will be installed when only few packages from it are necessary)
dependencies needed from pip will still need to be installed manually
dependencies  for packages that don't have a package.xml (e.g. Fast-RTPS) still need to be installed by hand

Understood, thanks for the consideration

For packages that have a package.xml patched in (fastrtps/fastcdr), I've been pulling down the bloomed release branch rather than the upstream source branch.
Haven't noticed the issue with opencv, but wouldn't the solution be to reduce the scope of the dependencies declared in the appropriate package.xml's?
Pip dependencies - I don't currently run tests on upstream (OSRF) ROS2 packages, so that's why I probably haven't hit this. Would it be possible to package these up as debs on packages.ros2.org? I recall a similar approach being done for certain dependencies in ROS1
DDS packages not released upstream - I draw libopensplice67 from packages.ros2.org, although some rosdep-hacking has been necessary due to inconsistent keys (There's a mix of opensplice and libopensplice64 rosdeps in the wild) and connext..

For packages that have a package.xml patched in (fastrtps/fastcdr), I've been pulling down the bloomed release branch rather than the upstream source branch.

:+1: that's a good workaround

Haven't noticed the issue with opencv, but wouldn't the solution be to reduce the scope of the dependencies declared in the appropriate package.xml's?

This is actually a common issue in ROS1 as well in both rosdep and package.xml.

On the rosdep side: now that (since Melodic) we target the upstream version of OpenCV, we should create keys for each opencv package so that people could exec_depend only on the ones needed by the package.
On the package.xml side, developers tend to use the same keys for build and exec depends. Most packages need the dev version only for building and could use just the libraries (without the dev files) as runtime dependencies. This is something we haven't addressed in ROS2 packages so far as multiple use the same practice.

Pip dependencies - I don't currently run tests on upstream (OSRF) ROS2 packages, so that's why I probably haven't hit this. Certainly just build/package works without them. Would it be possible to package these up as debs on packages.ros2.org? I recall a similar approach being done for certain dependencies in ROS1

We try to do this in ROS1 only when the package doesnt exist at all upstream and is really needed. For packages where a (n older) version exists upstream, this is discouraged as this will impact the rest of the users system in unexpected ways

DDS packages not released upstream - I draw libopensplice67 from packages.ros2.org,

Yes this is currently the only place where these debs are available. This is why we didnt add then to the rosdep database (as they are not available in any upstream repo and not on packages.ros.org). It is unclear to me how / where these keys should live at the moment.

although some rosdep-hacking has been necessary due to inconsistent keys (There's a mix of opensplice and libopensplice64 rosdeps in the wild) and connext.

Yes this is in progress of being homogenized. We originally didnt have debs for connext so just ignored the keys. Now that we have a deb we'll homogenize the names for the upcoming Bouncy release.
Same thing for opensplice as we now use opensplice 6.7

How do you manage dependency installation on the ros2 buildfarm, given these shortcomings? As ros2/rosdistro grows, do you see the rosdep install workflow becoming supported/first-class in the future?

We used to ship only Fast-RTPS so these (opensplice / connext) dependencies were not used.
The other ones were fixed using the package.xml injected in the release repos.

As ros2/rosdistro grows, do you see the rosdep install workflow becoming supported/first-class in the future?

Yes I believe this will become a supported use case in the future (at least for Linux). There are details to figure out before reaching that point:

How the handling of group dependencies will work in rosdep
ROS 2 platforms that don't have rosdep installers ATM (e.g. Windows)

Thanks for the patch and the super detailed response. Looking forward to Bouncy, and I'll keep following this thread.

Thanks fr trying it out and giving feedback!
This thread was closed automatically by the PR as the original issue was addressed.
When the topic of using rosdep as supported workflow comes up in another high level issue, we should make sure to link to this.

@paulbovbel Bouncy Linux source instructions have been updated to use rosdep: the work for the other wiki pages is ticketed at https://github.com/ros2/ros2/issues/536.
Some of the uncovered cases listed above have not been addressed in rosdep itself but we kept some manual installation steps to make sure they are satisfied.


open URL does not work even though firewall is disabled

ADD ISSUE DESCRIPTION HERE
Version: 1.85.1
Commit: 0ee08df0cf4527e40edc9aa28f4b5bd38bbff2b2
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36 Edg/<IP_ADDRESS>
Embedder: codespaces

I am writing a code in html file and when I tried to open the URL I got an error message;
'<IP_ADDRESS> refused to connect - check proxy and firewall'.
Until few days ago opening a URL was perfectly fine but since I got the message I disabled all firewalls in the PC and proxy off and retried by in vein.  How can I restore the URL opening functionality?

We closed this issue because it is a question about using VS Code rather than an issue or feature request. Please search for help on StackOverflow, where the community has already answered thousands of similar questions. You may find their guide on asking a new question helpful if your question has not already been asked. See also our issue reporting guidelines.
Happy Coding!


test(cli): set up mocks, disable exit process for tests

Closes #211
In this PR, I extract and configure mock setup for the CLI package:

unnecessary global setup is removed from both CLI integration and unit tests
fs and fs/promises used in almost all unit tests.
console.log is now mocked for all unit tests.
bundleRequire used by command objects is also extracted.
portal-client, while used by two command objects, is also extracted as it could be reused.
I also reset mocks and memfs volume before each test.

Additionally, for better debugging, I disabled exitProcess in yargsCli which closes #243

I wonder if we can now add better testing on errors as we should be able to see them...
@BioPhoton Presumably, even more so when I change console.log messages that belong to console.error in #277 .


Ability to cancel payments/invoces

Hi. Some payment gateways cannot cancel old payments / invoces themselves, but have the ability to manually cancel payments.
Need to provide methods in the omnipay interface so that the application can send requests to the gateway to cancel the payment.
It is necessary that the buyer could not pay the expired / overdue / not up-to-date invoice.

Oh, this is alredy exists and named as void.
Then need to add to the description of the method that it is suitable for payment/invoice cancellation, to improve the user-friendly of the library.
 * @method \Omnipay\Common\Message\RequestInterface void(array $options = array())              (Optional method)
 *         Generally can only be called up to 24 hours after submitting a transaction


Use var and defork

let -> var
deforking

I've set the engine to 6, so the let -> var isn't needed

that might not be true locally (apparently 😄 ). so i guess better stick to var etc


Getting "module Timex.DateTime is not available" error after upgraded Timex to version 3.0.3

[error] Task #PID<0.1262.0> started from Quantum terminating
** (UndefinedFunctionError) function Timex.DateTime.from/1 is undefined (module Timex.DateTime is not available)
    Timex.DateTime.from({{2016, 7, 16}, {5, 48, 0}})
    (quantum) lib/quantum/executor.ex:18: Quantum.Executor.convert_to_timezone/2
    (quantum) lib/quantum/executor.ex:84: Quantum.Executor.execute/2
    (elixir) lib/task/supervised.ex:94: Task.Supervised.do_apply/2
    (elixir) lib/task/supervised.ex:45: Task.Supervised.reply/5
    (stdlib) proc_lib.erl:240: :proc_lib.init_p_do_apply/3
Function: &Quantum.Executor.execute/2

Thanks for reporting! We need to upgrade quantum to Elixir >= 1.3 and use the new date/time types. Then, we would release a 2.0 version of quantum, indicating that this version bump breaks backwards compatibility (i.e. pre-elixir-1.3 support). Any pull requests in that directions are welcome.

Fixed by #111


Correct Windows SBOM artifact filename

Fixes https://github.com/adoptium/temurin-build/issues/3464
Ensure SBOM artifact filename is correct on Windows builds.

I'd probably have just gone with this to squash them both and skip the if clause to make the code simpler, but I'm ok with it as-is too if you'd rather not change it.
sbomTargetName="${sbomTargetName//\.zip/}"
sbomTargetName="${sbomTargetName//\.tar\.gz/}"

Yeah, I did think of doing that to start with, but thought better to be more precise, i'll go with what I have, thanks


Add HAProxy

Since HAProxy published EoL dates as quarters, I am not sure how to handle that so I left it as is. I incleded versions up to oldest supported version. For not-supported versions, I used the last release date as EoL date. If this is merged without any change, #661 can be closed.

release tags are missing so it couldnt compile

Please add these values for each corresponding release information for each x.y series as release: date
@ztzxt
2016/11/25 : 1.7.0
2017/11/26 : 1.8.0
2018/12/19 : 1.9.0
2019/06/16 : 2.0.0
2019/11/25 : 2.1.0
2020/07/07 : 2.2.0
2020/11/05 : 2.3.0
2021/05/14 : 2.4.0
2021/11/23 : 2.5.0

I have added needed dates for you @ztzxt

Reaching out to upstream to see if we can improve the "tracking EoL by quarter situation". Since we're being conservative here, we're clearly making some errors (1.7 is marked as EoL here, but not on the upstream for eg).
But this should be a good first cut.
Thanks a lot @ztzxt @usta!


Bug: No way to style <video> element inside <mux-video>

Which Mux Elements/Packages has a bug?

mux-video

Which browser(s) are you using?

Chrome

Which operating system(s) are you using?
Mac
How are you using Mux Elements?
<script async src="https://unpkg.com/@mux-elements/mux-video"></script>.
Describe the bug
I want to style the<video> element inside of the <mux-video> element. In particular, I'd like to add object-fit: cover.

The current behavior
As far as I can tell, there is no way to style this element.
The expected behavior
I want to be able to style it. A simple solution would be to put a part="video" attribute on the <video> element. That way one could style it as described in https://developer.mozilla.org/en-US/docs/Web/CSS/::part. I've tested this out by adding the part attribute in Chrome Devtools and it works.

thanks for the feedback @balexand! this seems like a good solution, we'll discuss and come back to you.
Related to https://github.com/muxinc/media-chrome/discussions/206

I'm new to CSS Shadow Parts but I think we'll need exportparts too if we want to style when nested inside a mux-player element?

https://github.com/muxinc/elements/pull/384#issuecomment-1245337163

It should be available in mux-video. However, we have some concerns about exposing it from mux-player. Started discussion to that point in #380.


skfem.visuals.matplotlib.draw doesn't support a color keyword.

skfem.visuals.matplotlib.draw(mesh, color='w', ax=plt.gca())

would be extremely helpful for overlaying the mesh on something where black lines don't provide sufficient contrast.

What happens if you do edgecolors='k'? I think it was broken at some point.

edgecolors='w' doesn't change the color or raise an exception.  (In fact, invalid kwargs never raise an exception when passed to draw.)

This looks like the culprit:
https://github.com/kinnala/scikit-fem/blob/fbd2558b9a20c635159737954c81a42687144486/skfem/visuals/matplotlib.py#L39-L40
edgecolors is hardcoded, ignoring the kwargs.

I mean edgecolor; that'll be an issue too, once passing on the kwargs, possibly enhanced by defaults like {"edgecolor": "k"} is arranged for.

Sorry I meant this one in plot: https://github.com/kinnala/scikit-fem/blob/fbd2558b9a20c635159737954c81a42687144486/skfem/visuals/matplotlib.py#L193
Does it have any effect?

Sorry I meant this one in plot:
https://github.com/kinnala/scikit-fem/blob/fbd2558b9a20c635159737954c81a42687144486/skfem/visuals/matplotlib.py#L193
Does it have any effect?

This is not a good idea it seems. It will interfere with nrefs and also shading.

This looks like the culprit:
https://github.com/kinnala/scikit-fem/blob/fbd2558b9a20c635159737954c81a42687144486/skfem/visuals/matplotlib.py#L39-L40
edgecolors is hardcoded, ignoring the kwargs.

Reading edgecolor from kwargs will fix this, right?


add Sobol Sensitivity method

Hello @mikkokotila! Thanks for opening this PR.


Changes the Google API deps to google.golang.org

I found out that the source cannot be compiled with googleapi dependency from github. So I changed it to google.golang.org and it works and tests are passed.

Thank you for the contribution. Could you sign the CLA as instructed in identity-toolkit-go-client/CONTRIBUTORS first before we can accept your changes?

Hi @mcduan, I have signed the CLA on behalf of myself as individual.
Thank You,
Didiet


PR Suggestion

Just a suggestion to https://github.com/transcom/mymove/pull/11190, there just wasn't an easy way to make the suggestion in the right place directly on that PR

Warnings

:warning:
Please add the JIRA issue key to the PR title (e.g. MB-123)

  Generated by :no_entry_sign: dangerJS against bf687b62f6b4ef0b0c2dfaf965dfa5653568f79e

Test coverage on client failed.
Last run: Fri 11 Aug 2023 02:15:12 PM UTC
Refer to this report to see coverage details for the client app.
Documentation for test coverage can be found at this link.

Whether we start the feature flags docker container (detached?) simultaneously or not is something else to consider, for convenience

Feedback on https://github.com/transcom/mymove/pull/11190 has been to go another way with this, so I'll close 😄


Data corruption when recording byte array column statistics

Discovered while implementing https://github.com/parquet-go/parquet-go/pull/52
parquet-cli showed that for one of the sample columns containing ["Solo", "Skywalker", "Skywalker"] the min and max values recorded were ("Skywalker", "Skywalker"), not ("Skywalker", "Solo") as they should have been.
I spent a bit more time investigating this. The problem comes from these lines in (*writerColumn).recordPageStats (writer.go:1560):
if existingMaxValue.isNull() || c.columnType.Compare(maxValue, existingMaxValue) > 0 {
    c.columnChunk.MetaData.Statistics.MaxValue = maxValue.Bytes()
}

For byte-array-backed Values, Bytes() returns an unsafe cast of the value ptr to a byte-slice. In this case, the ptr points into the values slice of the columnBuffer's page, and that slice gets saved directly into the statistics. It seems like after we finish flushing this page, the page's values slice gets reused - as the next page is written, it overwrites the MaxValue stored in the statistics. In this particular case, the stored MaxValue was "Solo" (&values[0], 4) but "Skywalker" is the first value of the next data page, which gets written to &values[0]. When we update the statistics for this page, we compare "Skywalker" (&values[0], 9) against "Skyw" (&values[0], 4), find it's larger, and updates it. In general, though, this could behave even more erratically.
Fundamentally, it seems like the solution is that the stored value needs to be copied into a slice backed by a new array, not left pointing to the one inside the page. The question is: how should we do it?
Option 1: Change the implementation of (Value).Bytes() to always copy the bytes into a new array. This makes the API less dangerous and may prevent other bugs like this, but it will negatively impact performance anywhere Bytes() is called and creating a copy is not dangerous. It's hard to assess how big a deal this is from either perspective. Bytes() is currently only called in (*writerColumn).makePageStatistics and (*writerColumn).recordPageStats. We have to add the copy in recordPageStats, but makePageStatistics seems to work as-is (I think this is because this value isn't held past the page flush in this case.) However, because Value is exported outside the package, the level of safety and performance impact is probably overwhelmed by the effects on usage outside the package, which are hard to know. I worry a little bit that from outside the package it's nearly impossible to tell when the value returned by Bytes is safe or when it needs to be copied, unless for some reason all values exposed outside the module are safe.
Option 2: We could do the copy inside (*writerColumn).recordPageStats. This has the smallest impact on the system, affecting only the one site where we know there's a problem. However, it leaves us and others open to similar bugs in the future. ~It also imposes a small performance/complexity hit on recordPageStats, though in practice this probably won't matter much.~ EDIT: I realized that using (Value).AppendBytes actually works better than (Value).Bytes in all cases, and requires the fewest unnecessary allocations.
Option 3: Implement a new method (Value).SafeBytes() (name TBD) that always copies the data into a new slice, and let the caller decide on the behavior. IMO this probably pollutes the API more than it provides useful options, but I include it for completeness.

A little bit more investigation shows this is probably regressed with this PR: https://github.com/segmentio/parquet-go/pull/508. Prior to this, (Value).Bytes() always copied into a new array. However, this PR changed it to return the underlying bytes directly to improve performance. I couldn't find any reference to the specific benchmark that justified it, but my guess is the person who made that commit (and others processing lots of data as raw values?) would object to functionally reverting that change, so maybe we ought to just fix it inside recordPageStats?
I wonder, though, what are the guarantees about the stability of values that bubble up outside of the reader? Are Values returned by ReadRows guaranteed to remain valid once they're returned? Are they valid until the next call? Can they become corrupted even before they're returned if, say, a read crosses a page boundary? If the second, this should probably be documented. If the third, this should be fixed.

I opened a PR to fix this issue, using a version of Option 2. I modified recordPageStats to use (Value).AppendBytes, which seems like the best way to do the copy we need without doing extraneous copies and mallocs. https://github.com/parquet-go/parquet-go/pull/54

I wonder, though, what are the guarantees about the stability of values that bubble up outside of the reader?
Are Values returned by ReadRows guaranteed to remain valid once they're returned?
Are they valid until the next call?

The expectations are documented on the parquet.RowReader interface https://pkg.go.dev/github.com/parquet-go/parquet-go#RowReader

Can they become corrupted even before they're returned if, say, a read crosses a page boundary?

They cannot become corrupted at page boundaries, parquet-go is implemented to gracefully handle those conditions. Technically, what we do is leverage the fact that ReadRows or ReadValues are allowed to return fewer items than the size of the slice they receive as argument, even when no errors occurred (same semantic as io.Reader). When we reach the end of a page, we early return to the caller so the internal buffers contain the values from only one page, and they can be reused when reading the following page.

PR is merged, so I'm closing this.


rarray not working

First of all, thanks for the amazing library.
I'm trying to use rarray but it doesn't seem to work:
let mut stmt = conn.prepare_cached("SELECT * FROM mytable WHERE seq IN rarray(?)")?;

But I get this error:
SqliteFailure(Error { code: Unknown, extended_code: 1 }, Some("no such table: rarray"))

I have this in my Cargo.toml which I believe is the only requirement to make it work
[dependencies.rusqlite]
version = "0.21"
features = ["bundled", "vtab", "array" ]

Is there anything else I need to enable to get support for rarray working?

Without a complete example, my guess is that you are missing a load_module.

Thanks @gwenn, that was one of the issues, the other one being that the array must be wrapped in an Rc to get the ToSql impl.
It works now!


openconnect doesn't set default route

Issue description
It seems that openconnect doesn't set default route through tun0.
Steps to reproduce
Start openconnect with the following options:
openconnect --authgroup=MyGroup --user=auser https://server.local
route
Technical details

System: (NixOS: nixos-version, Ubuntu/Fedora: lsb_release -a, ...)

16.03.1271.546618c (Emu)

Nix version: (run nix-env --version)

nix-env (Nix) 1.11.2

Nixpkgs version: (run nix-instantiate --eval '<nixpkgs>' -A lib.nixpkgsVersion)

nix-instantiate --eval openconnect -A lib.nixpkgsVersion
error: getting status of ‘/root/openconnect’: No such file or directory

@rqcy I have this problem. What was your fix?

@rqcy I have this problem. What was your fix?

Hmm, I hove no access to that computer at the moment and I don't
remember any more.  Just guessing... perhaps some dependency was missing
or I have used vpnc instead.  Good luck!


Photo information not readed

Hi Folker,
your libary looks great but I have a problem with the photo. The attached file is a standard outlook contact file saved as *.vcf. Any idea how to solve this problem?
Max Anderer Mustermann sen.zip

Hi Dennis,
thank you very much for posting this issue. I have published an update to Nuget, that should solve your problem.
I would recommend that you save your data in a newer vCard format (vCard 3.0 or 4.0). vCard 2.1 seems to me to be more of a poorly thought out recommendation than a real standard. Line folding in vCard 2.1 is made according to RFC 822: Lines are wrapped on places of linear whitespace and the whitespace at the beginning of a line is not removed.
Thats a problem with Base64 encoded data (like photos) because there is no linear whitespace in it. I think the vCard 2.1 recommendation to add an empty line after Base64 encoded data should parsers enable to unfold the Base64 data.
Outlook takes another way: It adds a space char at the beginning of every folded line of Base64 encoded data. How I mentioned above, this is not standard - nevertheless the library is now able to read this.
I would like to invite you to support this project: I have attached the content of your "Max Anderer Mustermann.vcf" file like it it's written by the library in vCard 2.1 and I am very interested to know, whether Outlook is able to parse the photo the way the library exports it (without space chars).
TestV2.1.vcf.zip
Please post another issue, if Outlook cannot read this.

The issue is fixed with the latest update.


Fix code scanning alert - remote attackers can cause denial of service via attacker controlled input to wheel cli

Tracking issue for:

[ ] https://github.com/obervinov/pyinstabot-downloader/security/code-scanning/17

Fixed in v2.1.0


Difference between static website and blob container integration with CDN

@Boosten commented on Mon May 04 2020
There are two options to make your blob container accessible via a CDN:

Mapping the blob container url to your CDN: https://docs.microsoft.com/nl-nl/azure/cdn/cdn-create-a-storage-account-with-cdn.

Example configuration of a CDN endpoint:

Origin type: Storage
Origin hostname: NAME.blob.core.windows.net
Origin host header: NAME.blob.core.windows.net
Origin path: /www (your blob container name)

Mapping the $web blob container "static website" url to your CDN:  https://docs.microsoft.com/nl-nl/azure/storage/blobs/static-website-content-delivery-network
In this scenario you need to enable the "static website" option on your storage account.

Example configuration of a CDN endpoint:

Origin type: Custom Origin
Origin hostname: NAME.z6.web.core.windows.net (my static website public url)
Origin host header: NAME.z6.blob.core.windows.net ((my static website public url)
Origin path: (empty)

In the end, both are doing the same: mapping a blob container to a CDN endpoint. But option 2 seems redundant because we do not necessarily need the static website endpoint.
I'm I missing something here :-)?

Documentdetails
⚠ Dit gedeelte niet bewerken. Het is vereist om problemen te koppelen tussen docs.microsoft.com en GitHub.

ID: 8772b2a5-6b28-9d91-5fd4-e125d85126c6
Version Independent ID: 0a58807a-e274-7833-7845-bed7ebaaf1bc
Content: Een statische website integreren met Azure CDN-Azure Storage
Content Source: articles/storage/blobs/static-website-content-delivery-network.md
Service: storage
Sub-service: blobs
GitHub Login: @normesta
Microsoft Alias: normesta

@srvbpigh commented on Mon May 04 2020
Hello, @Boosten
Thank you for your feedback.
We are actively reviewing your comments and will get back to you soon.
Kind regards,
Microsoft DOCS International Team

@CeciAc  Thanks for your question. We are checking on this and will respond to you soon.

@CeciAc Apologies for delay in responding here!
I'd recommend posting your question in https://social.msdn.microsoft.com/forums/azure/en-US/home?forum=windowsazuredata since it's not directly related to the documentation. We'll follow up there. We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


Introduce ZodTransformError type, to allow for transforms that fail

This PR introduces a new Error type, ZodTransformError, which accepts an array of issues in it's constructor.
Closes https://github.com/colinhacks/zod/issues/1390
When thrown inside a transform, this error class will be caught by Zod, and the issues it contains treated a fatal and added to the parse result.
The rational for this PR is to allow for transforms that may fail, such as the following example.
import { ZodTransformError } from "zod";

const user = z.string().transform(async (id) => {
  try {
    const user = await getUserById(id);
    return user;
  } catch (e) {
    throw new ZodTransformError([{
      code: "custom",
      message: "User not found",
    }]);
  }
});

Thanks for this PR! This same scenario can now be addressed with ctx.addIssue inside the .transform() method:
const user = z.string().transform(async (id, ctx) => {
  try {
    await "asdf";
    throw new Error();
  } catch (e) {
    ctx.addIssue({
      code: z.ZodIssueCode.custom,
      message: "User not found :(",
    });
  }
});

Closing for now, let me know if the new solution doesn't cover your use cases.


Users are needlessly spooked by ominous cryptic line in job logs:

Failed with 6 inputs with exception e = java.lang.NoSuchMethodException: azkaban.jobtype.HadoopShell.<init>(java.lang.String, azkaban.utils.Props, azkaban.utils.Props, azkaban.utils.Props, org.apache.log4j.Logger)
It is benign but misleading and is sometimes blamed if job fails elsewhere. I don't think we need that line in the logs if it is fully expected.
Also, minor cosmetic refactoring to avoid nested try{} and to eliminate duplicate catch(){}.

Pull Request Test Coverage Report for Build 6289

8 of 13 (61.54%)  changed or added relevant lines in 1 file are covered.
3 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.004%) to 44.832%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

azkaban-common/src/main/java/azkaban/jobtype/JobTypeManager.java
8
13
61.54%

Files with Coverage Reduction
New Missed Lines
%

azkaban-exec-server/src/main/java/azkaban/execapp/jmx/JmxJobMBeanManager.java
1
72.73%

azkaban-common/src/main/java/azkaban/jobExecutor/AbstractProcessJob.java
2
52.58%

Totals

Change from base Build 6284:
-0.004%

Covered Lines:
17408

Relevant Lines:
38829

💛  - Coveralls

You did it so much better :D

Why thank you! Glad you like it. Thanks for the quick review!


intellisense disappears after closing VS when there is an incomplete statement in editor

create new console project
npm install async
type code in editor

var async = require('async')
async.all

F12 on 'all', and go to definition. (takes you to right place in async.js)
save, close, and reopen project
F12 on 'all' - doesn't work... instead pops up this dialog:

---------------------------
Node.js Tools for Visual Studio
---------------------------
Cannot go to definition "async.all"
---------------------------
OK
---------------------------
And intellisense is completely borked until you delete the .dat file and reload the project.

This issue doesn't seem to occur if the statement is complete
We fixed it earlier, but looks like it's back :( https://nodejstools.codeplex.com/workitem/1706
more discussion: https://nodejstools.codeplex.com/workitem/1963

Incomplete code only breaks built-in node module intellisense.  User loaded modules still have the intellisense.  So codeplex #1963 is indeed not fixed.  The current bug was fixed.

I cannot reproduce this bug using the latest build. Both the intellisense and navigation to definition works fine when I reopen the project.
Env:
VS 2015 RTM
NTVS build 20150831

Did you try reproducing this issue?
https://nodejstools.codeplex.com/workitem/1963
It turns out they were actually separate.

@mousetraps I can repro that one. Looking into it.

I found out that the problem might be the Scope.EnumerateTowardsGlobal line at https://github.com/Microsoft/nodejstools/blob/master/Nodejs/Product/Analysis/Analysis/Analyzer/ExpressionEvaluator.cs#L68
returns correct type the first time; but returns empty object type after reopening the project. Though the function is a abstract function, and I don't know anything about the analysis engine, so can you share some thoughts on this?


Expose a project's identity path from DomainObjectContext

This is necessary to uniquely identity a domain object context, if that domain object context is a project.
Reviewing cheatsheet
Fixes #29893
Before merging the PR, comments starting with

❌ ❓must be fixed
🤔 💅 should be fixed
💭 may be fixed
🎉 celebrate happy things

LGTM ✅


[Help] Missing columnGroups after export

Hi @bosskmk ~
After export  to csv,xls,pdf missing columnGroups.

@bosskmk Thanks again for build this package.
Have plan to fix this?

@bosskmk
Is relative below issue?
https://github.com/flutter/flutter/issues/21594

@yingming25
A column group must be applied to the export.
It is still undeveloped.
I will work on an update someday.

Thank you :)


TEX-PWR schedule doesn't work

Because we do not process reverse connections by default
The list of current valid connections can be selected from https://www.bcferries.com/routes-fares/schedules
document.querySelectorAll('a[href^="/routes-fares/schedules/seasonal/"]')
total: 137
routes coordinates can be taken from map on the same page
the map queries additional data by region
https://www.bcferries.com/routes-fares/schedules/schedule-routemap?routeRegions=SUNSHINE_COAST
which returns HTML - see attached prettified
sunshine_coast.html.zip
The routes map data (xml) are only one-way.

#79


Fix negative sleep time error

It's not clear to me in what circumstances this occurs, but on my machine at least in certain circumstances the test script errors with a traceback that indicates a negative sleep time was given.  This PR should fix that by just skipping the sleep call if this happens.

Thanks for the patch, but unfortunately this issue has also been fixed before in #401 which is on the dev branch. I'm sorry i haven't released that build yet, but many thanks for getting involved in the project!

Oh, hah, in fact I was using the dev branch, but I didn't get around to submitting this PR for a few weeks after I installed it.  So really my bad for not submitting this when I first encountered it!  Thanks, @boltgolt


Made more clear what has to be executed to add the extension pg_trgm …

…to the postgress database.
Thank you for taking the time to contribute back to GitLab!
Please open a merge request on GitLab.com, we look forward to reviewing your contribution! You can log into GitLab.com using your GitHub account.

Just noticed, that the better example found its way into the updated 8.17 docu


Monitoring

All direct processes of core0/coreX can report stats output in format
20::<key string>:<value float>|OP[|tags]

Where OP can be one of

A for average aggregation
D for diff aggregation

Implemented a build in monitor functionality in core0, and is scheduled by toml configuration. if not scheduled no monitoring is done

Current coverage is 13.47% (diff: 1.58%)

No coverage report found for 0.11.0 at 380b902.

Powered by Codecov. Last update 380b902...b45ef62


Filterable properties for the filter parameter

Text string properties that accept wildcard characters require the -like operator (for example, "Property -like '*abc'"):
Depends where environment is based the object:
-In cloud-based environments, you can't use a wildcard as the first character. For example, 'Sales*' is allowed, but '*Sales' isn't allowed.
 For example, 'Sales*' or 'Sales' are allowed, but 'Sales' isn't allowed.
Could we check add to the document?

Detalhes do Documento
⚠ Não edite esta secção. É necessário para a ligação de problemas docs.microsoft.com ➟ GitHub.

ID: 9ce35226-b40b-3c9f-a37f-585b84aa129e
Version Independent ID: ac9953e2-769a-c115-b1c6-e6f6fc940db2
Content: Filterable properties for the Filter parameter
Content Source: exchange/docs-conceptual/exchange-server/recipient-filters/filter-properties.md
Service: exchange-powershell
Product: exchange-server-itpro
GitHub Login: @chrisda
Microsoft Alias: chrisda

@officedocsbot assign @yogkumgit

Hi @BlasMS, thank you for your feedback.
I have tried and I saw the same behavior in the cloud and on-premises, with -Filter and -RecipientPreviewFilter. You can use wildcard as the first and last character, not in the middle.

@dariomws306  Thank you very much for the contribution and updating the documentation with PR. @BlasMS Hope this update is helpful for you. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.

Hi @dariomws306 In the middle returns nothing.
@yogkumgit @dariomws306  Thanks ;)


Fix add to calendar button

@meols This is fixed, can you take a quick look?

Thanks @padms - tested and approved :thumbsup:


Dev cr kraalfar

first batch of comments

Many thanks for the code review.
The suggested refactorings are so nice, and they are improving the code quality. Also, the argument parser package looks so nice, and I will try to change related parts accordingly and add a commit in this branch.
In the changes, I think I have seen only one logical change, which was related to the clustering part. Initially, the code generates kmeans.labels_ random colors, but it has been changed to 2. It is true that the number of clusters is two in the code but to generate a good graph this number should be configured accordingly.

Now I got your point. The problem is the unique function. I should make a parameter for the number of clusters.


updated dmtcp major versions

The default dmtcp should really be updated to a more recent version, as it is now a major version behind (and more). I'm a nix newbie, but I needed to use this soon so it seemed like a good chance to test out nix-build. So there are a few possible issues:

My new --replace commands may or may not be working correctly. Without these, a python expression trying to access $USER  (e.g. os.environ['USER']) fails; it seems like USER is not being set correctly in the build environment. I attempted to hardcode it to the first build user for now (I guess this would work if it is possible to disable parallel builds). However, I have not checked that this works correctly because specifying nix-build -A -K dmtcp does not seem to leave the directory around, even though it now fails much later in the check phase.

Five out of forty checks will still fail if doCheck = true. I haven't investigated these yet, but dmtcp seems to work well enough in general. I will try to investigate these more. Part of the problem could be I'm running in virtualbox for the moment.

I believe you tested that the package works. I pushed a squash of this with some fixes of mine (and tested it builds).


Feature Request: Add a machine identifier like serial number to the JSON sent with the webhook

It is often valuable when using a SEIM like Splunk to report on what device the privilege elevation occurred on.  Adding some unique device identifier like Serial Number to the JSON values sent with the web hook would complete the picture.
Maybe ideally this value could come from  the  configuration profile so Apple variables like %SerialNumber% (https://support.apple.com/en-au/guide/profile-manager/mdm53kqu8903/mac)or Jamf variables like $COMPUTERNAME(https://learn.jamf.com/en-US/bundle/jamf-pro-documentation-current/page/Computer_Configuration_Profiles.html)  could be used.
Thanks for your consideration.

@everetteallen Please check the request from issue #138. I think this is what you are looking for.


Godot 4.0: "Repeat" option missing for importing textures

Godot version
4.0-dev (20210811)
System information
Windows 10, Vulkan, RTX2080
Issue description
Using the test build Godot_v4.0-dev.20210811_win64
When importing an image as a Texture2D the import option "Repeat" seems to be missing in 4.0
See screenshot.
Left -> Godot 3.3.2
Right -> Godot 4.0

Steps to reproduce
Choose an image.
Open the import window.
Search for "Repeat" options.
Minimal reproduction project
No response

It's now a property of CanvasItem

You need this option outside of Canvas items. What about shaders and uvs that go beyond the range of 0-1?
I don't think it is a good idea to put this option on a node...
This change would would break custom shaders

You need this option outside of Canvas items. What about shaders and uvs that go beyond the range of 0-1?
I don't think it is a good idea to put this option on a node...
This change would would break custom shaders
And what about 3D Games? They need this option too

Have you found a work around?

For shaders there is a hint for that, e.g. uniform sampler2D tex : filter_linear;.


Tests Failing

I'ved pulled @manodeep 's lhvt branch onto my fork and attempted to run the tests (make tests).  However these are failing on OzStar.  Full output below
./src/tests/test_sage.sh
ThisTask = 0 working on 29585 forests
0%.........10%.........20%.........30%.........40%.........50%.........60%.........70%.........80%.........90%.........100% done. Time taken =  7.692 secs

reading parameter file:

                   FileNameGalaxies      model
                          OutputDir src/auxdata/trees/mini-millennium/
                          FirstFile          0
                           LastFile          7
                         NumOutputs          8
                           TreeName  trees_063
                           TreeType lhalo_binary
                      SimulationDir src/auxdata/trees/mini-millennium/
                   FileWithSnapList src/auxdata/trees/mini-millennium/mini-millennium.a_list
                     LastSnapShotNr         63
                              Omega       0.25
                        OmegaLambda       0.75
                         BaryonFrac       0.17
                           Hubble_h       0.73
                           PartMass  0.0860657
                     SFprescription          0
                        AGNrecipeOn          2
                  SupernovaRecipeOn          1
                     ReionizationOn          1
                  DiskInstabilityOn          1
                      SfrEfficiency       0.05
           FeedbackReheatingEpsilon        3.0
         FeedbackEjectionEfficiency        0.3
              ReIncorporationFactor       0.15
                RadioModeEfficiency       0.08
               QuasarModeEfficiency      0.005
                BlackHoleGrowthRate      0.015
                  ThreshMajorMerger        0.3
             ThresholdSatDisruption        1.0
                              Yield      0.025
                    RecycleFraction       0.43
                     FracZleaveDisk        0.0
                    Reionization_z0        8.0
                    Reionization_zr        7.0
                           EnergySN     1.0e51
                              EtaSN     5.0e-3
                   UnitLength_in_cm 3.08568e+24
                      UnitMass_in_g  1.989e+43
           UnitVelocity_in_cm_per_s     100000

8 snapshots selected for output: 63 37 32 27 23 20 18 16
found 64 defined times in snaplist
cooling functions read

new high mark = 10.6172 MB
Files model_z0.000_0 and output/model_z0.000_0 differ
^M  0%|          | 0/29585 [00:00<?, ?it/s]Printing values that were different side-by side

#######################################
# index          ColdGas1          ColdGas2
2 0.03079371526837349 0.030793720856308937
8 0.10719473659992218 0.10719471424818039
10 0.4891951084136963 0.4891950786113739
13 0.1318044364452362 0.131804421544075
18 0.030337709933519363 0.030337713658809662
19 0.06340668350458145 0.06340667605400085
24 0.40057387948036194 0.4005739390850067
31 0.05011911690235138 0.05011912062764168
38 0.06778661906719208 0.06778662651777267
45 0.20168861746788025 0.20168854296207428
------ Found 10 mis-matched values out of a total of 46 ------
#######################################

Running sagediff on files model_z0.000_0 and output/model_z0.000_0
Traceback (most recent call last):
  File "/home/jseiler/sage/src/tests/sagediff.py", line 316, in <module>
    compare_catalogs(g1, g2)
  File "/home/jseiler/sage/src/tests/sagediff.py", line 287, in compare_catalogs
    raise ValueError(msg)
ValueError: Field = `ColdGas` not the same between the two catalogs

Files model_z1.386_0 and output/model_z1.386_0 differ
^M  0%|          | 0/29585 [00:00<?, ?it/s]Printing values that were different side-by side

#######################################
# index          ColdGas1          ColdGas2
2 0.06440313160419464 0.06440312415361404
18 0.016214733943343163 0.01621473766863346
19 0.2062813639640808 0.20628128945827484
22 0.11758784204721451 0.1175878494977951
24 0.10477963089942932 0.10477960854768753
26 0.005159142427146435 0.0051591224037110806
29 0.20634214580059052 0.20634213089942932
31 0.010598157532513142 0.010598153807222843
38 0.0997815728187561 0.0997815653681755
43 0.329973429441452 0.32997339963912964
45 0.049664177000522614 0.04966416954994202
47 1.293544054031372 1.2935445308685303
52 0.6823491454124451 0.6823490858078003
59 0.0549587644636631 0.0549587607383728
62 0.4025420546531677 0.4025421142578125
63 0.06747764348983765 0.06747763603925705
65 0.5376327037811279 0.5376326441764832
67 0.03371166065335274 0.033711664378643036
74 0.03700629994273186 0.03700629621744156
76 0.02874016761779785 0.028740162029862404
77 0.25596538186073303 0.25596535205841064
78 0.30131295323371887 0.30131298303604126
81 0.062302783131599426 0.06230279058218002
84 0.09790722280740738 0.09790721535682678
86 0.1150791272521019 0.1150791198015213
91 0.454077810049057 0.4540778398513794
104 0.36678293347358704 0.36678290367126465
112 0.1713608354330063 0.17136088013648987
113 0.03802800178527832 0.038027990609407425
116 0.055066827684640884 0.055066850036382675
------ Found 30 mis-matched values out of a total of 120 ------
#######################################

Running sagediff on files model_z1.386_0 and output/model_z1.386_0
Traceback (most recent call last):
  File "/home/jseiler/sage/src/tests/sagediff.py", line 316, in <module>
    compare_catalogs(g1, g2)
  File "/home/jseiler/sage/src/tests/sagediff.py", line 287, in compare_catalogs
    raise ValueError(msg)
ValueError: Field = `ColdGas` not the same between the two catalogs

Files model_z2.070_0 and output/model_z2.070_0 differ
^M  0%|          | 0/29585 [00:00<?, ?it/s]Printing values that were different side-by side

#######################################
# index          ColdGas1          ColdGas2
4 0.10012167692184448 0.10012166947126389
5 0.17956306040287018 0.17956304550170898
14 0.1814412772655487 0.1814412921667099
19 0.10795741528272629 0.1079573929309845
23 0.05267014726996422 0.052670132368803024
24 0.10052889585494995 0.10052890330553055
29 0.10155042260885239 0.10155044496059418
34 0.0936553031206131 0.0936552882194519
35 0.13702218234539032 0.13702213764190674
40 0.27994218468666077 0.2799421548843384
42 0.1257070153951645 0.12570703029632568
45 0.21986795961856842 0.21986794471740723
46 0.21127009391784668 0.21127007901668549
49 0.03307007998228073 0.03307008370757103
58 0.09471292048692703 0.09471301734447479
64 0.3655787706375122 0.3655788004398346
89 0.30177292227745056 0.3017730116844177
91 2.5843617916107178 2.584362268447876
92 0.11560511589050293 0.11560510098934174
112 0.7066176533699036 0.706617534160614
128 0.01904754526913166 0.01904754340648651
------ Found 21 mis-matched values out of a total of 141 ------
#######################################

Running sagediff on files model_z2.070_0 and output/model_z2.070_0
Traceback (most recent call last):
  File "/home/jseiler/sage/src/tests/sagediff.py", line 316, in <module>
    compare_catalogs(g1, g2)
  File "/home/jseiler/sage/src/tests/sagediff.py", line 287, in compare_catalogs
    raise ValueError(msg)
ValueError: Field = `ColdGas` not the same between the two catalogs

Files model_z3.060_0 and output/model_z3.060_0 differ
^M  0%|          | 0/29585 [00:00<?, ?it/s]Printing values that were different side-by side

#######################################
# index          ColdGas1          ColdGas2
0 0.10282189399003983 0.10282188653945923
16 0.17570903897285461 0.17570897936820984
25 0.03968523442745209 0.03968522697687149
33 0.10532503575086594 0.10532506555318832
34 0.015587928704917431 0.015587916597723961
50 0.059916313737630844 0.05991632491350174
56 0.3566439151763916 0.356643944978714
61 0.05238834023475647 0.05238833650946617
69 0.15412479639053345 0.15412475168704987
71 0.21308356523513794 0.21308355033397675
82 0.04202853888273239 0.0420285239815712
86 0.3846573233604431 0.38465726375579834
97 0.01338415127247572 0.013384141959249973
99 0.5366290211677551 0.5366293787956238
103 1.4320476055145264 1.4320472478866577
104 0.12565842270851135 0.12565843760967255
124 0.2268814891576767 0.2268815040588379
126 0.24694764614105225 0.24694761633872986
135 0.07963654398918152 0.07963653653860092
143 0.0715259537100792 0.07152596116065979
------ Found 20 mis-matched values out of a total of 152 ------
#######################################

Running sagediff on files model_z3.060_0 and output/model_z3.060_0
Traceback (most recent call last):
  File "/home/jseiler/sage/src/tests/sagediff.py", line 316, in <module>
    compare_catalogs(g1, g2)
  File "/home/jseiler/sage/src/tests/sagediff.py", line 287, in compare_catalogs
    raise ValueError(msg)
ValueError: Field = `ColdGas` not the same between the two catalogs

Files model_z4.179_0 and output/model_z4.179_0 differ
^M  0%|          | 0/29585 [00:00<?, ?it/s]Printing values that were different side-by side

#######################################
# index          ColdGas1          ColdGas2
10 0.03595941141247749 0.035959407687187195
12 0.09086333215236664 0.09086331725120544
23 0.8930768966674805 0.8930768370628357
24 0.09699739515781403 0.09699740260839462
26 0.010787975043058395 0.010787980630993843
27 0.16554458439350128 0.1655445694923401
28 0.31473806500434875 0.31473803520202637
30 0.1449042409658432 0.144904226064682
42 0.0006608754047192633 0.000660857418552041
44 0.09592878818511963 0.09592879563570023
56 0.0506255067884922 0.0506255105137825
57 0.09087858349084854 0.09087859094142914
70 0.017988745123147964 0.017988743260502815
82 0.033230800181627274 0.03323080763220787
86 0.06195696443319321 0.061956971883773804
97 0.19590531289577484 0.19590529799461365
113 0.07757273316383362 0.07757274061441422
124 0.21031905710697174 0.21031907200813293
128 0.05980440601706505 0.059804413467645645
------ Found 19 mis-matched values out of a total of 133 ------
#######################################

Running sagediff on files model_z4.179_0 and output/model_z4.179_0
Traceback (most recent call last):
  File "/home/jseiler/sage/src/tests/sagediff.py", line 316, in <module>
    compare_catalogs(g1, g2)
  File "/home/jseiler/sage/src/tests/sagediff.py", line 287, in compare_catalogs
    raise ValueError(msg)
ValueError: Field = `ColdGas` not the same between the two catalogs

Files model_z5.289_0 and output/model_z5.289_0 differ
^M  0%|          | 0/29585 [00:00<?, ?it/s]Printing values that were different side-by side

#######################################
# index          ColdGas1          ColdGas2
29 0.15380528569221497 0.15380530059337616
39 0.7193774580955505 0.719377338886261
40 0.19265297055244446 0.19265298545360565
52 0.10731159895658493 0.10731159150600433
56 0.014976243488490582 0.014976240694522858
76 0.08028580993413925 0.08028581738471985
79 0.07267117500305176 0.07267118245363235
81 0.1044536679983139 0.1044536754488945
------ Found 8 mis-matched values out of a total of 103 ------
#######################################

Running sagediff on files model_z5.289_0 and output/model_z5.289_0
Traceback (most recent call last):
  File "/home/jseiler/sage/src/tests/sagediff.py", line 316, in <module>
    compare_catalogs(g1, g2)
  File "/home/jseiler/sage/src/tests/sagediff.py", line 287, in compare_catalogs
    raise ValueError(msg)
ValueError: Field = `ColdGas` not the same between the two catalogs

Files model_z6.197_0 and output/model_z6.197_0 differ
^M  0%|          | 0/29585 [00:00<?, ?it/s]Printing values that were different side-by side

#######################################
# index          ColdGas1          ColdGas2
0 0.10509827733039856 0.10509825497865677
17 0.5338785648345947 0.53387850522995
41 0.07294141501188278 0.07294142246246338
46 0.10395526885986328 0.10395527631044388
49 0.1340751349925995 0.1340751200914383
------ Found 5 mis-matched values out of a total of 66 ------
#######################################

Running sagediff on files model_z6.197_0 and output/model_z6.197_0
Traceback (most recent call last):
  File "/home/jseiler/sage/src/tests/sagediff.py", line 316, in <module>
    compare_catalogs(g1, g2)
  File "/home/jseiler/sage/src/tests/sagediff.py", line 287, in compare_catalogs
    raise ValueError(msg)
ValueError: Field = `ColdGas` not the same between the two catalogs

Files model_z7.272_0 and output/model_z7.272_0 differ
^M  0%|          | 0/29585 [00:00<?, ?it/s]Printing values that were different side-by side

#######################################
# index          ColdGas1          ColdGas2
4 0.4234035015106201 0.4234035313129425
15 0.3376022279262543 0.33760225772857666
------ Found 2 mis-matched values out of a total of 32 ------
#######################################

Running sagediff on files model_z7.272_0 and output/model_z7.272_0
Traceback (most recent call last):
  File "/home/jseiler/sage/src/tests/sagediff.py", line 316, in <module>
    compare_catalogs(g1, g2)
  File "/home/jseiler/sage/src/tests/sagediff.py", line 287, in compare_catalogs
    raise ValueError(msg)
ValueError: Field = `ColdGas` not the same between the two catalogs

Passed: 0. Bitwise identical: 0
Failed: 8
make: *** [tests] Error 8
~

The differences are very very minor...

Yup - the tests were failing on ozstar. And the tests were passing on my laptop (I think). This is partially the block I have towards going back and restarting development :'(

The biggest difference I saw is on the order of ~5e-7.  Is this enough for us to be worrying over...?

That's the issue - if I can show that those differences are numerical (fused-multiply-adds or something like that), then we can safely ignore these differences. But without that, simply numerically increasing the tolerance might hide future bugs.

Easiest way would be to backtrack through the commits and see where the bug crept in.

 The two z=6 files still produce two incorrect values (passing currently)

However the tests still fail on this commit.  I think this may hint that the "correct" data files may have gotten changed at some point.

Do the tests pass on your laptop?

There's also non-zero chance that I moved everything into lfs_sage

None of the files are bitwise identical however they all pass the sagediff test.
Also, we may wish to move away from lfs somehow (as I explained here)

Yup - lfs was definitely not the way forward

Maybe we host it similar to how we have the Mini-Mill trees? You can use your OzStar connections to get that done ;)


Updated COTS_priority column to use GBRMPA 2024-2025 data

Replaced the older CoCoNet COTS_priority data with updated data from GBRMPA for 2024/25 year.

Please detail the data used and the source of data in readme.
If the data attribution and license info can't be found in the source data file, let me know.

I added some details, but yeah I couldn't see any license information in the data or email from 5/8

I added some details, but yeah I couldn't see any license information in the data or email from 5/8

Just had a quick look. It's in the first tab "Creative Commons License": the data is provided under CC BY-NC 4.0, something like:
"CoTS data provided by GBRMPA under CC BY-NC 4.0 (http://creativecommons.org/licenses/by-nc/4.0)"

I added some details, but yeah I couldn't see any license information in the data or email from 5/8

Just had a quick look. It's in the first tab "Creative Commons License": the data is provided under CC BY-NC 4.0, something like:
"CoTS data provided by GBRMPA under CC BY-NC 4.0 (http://creativecommons.org/licenses/by-nc/4.0)"

Sorry I don't see where that is, but good to know thank you. I've put that into the README now

Sorry I don't see where that is, but good to know thank you. I've put that into the README now

Are you looking in the provided Excel spreadsheet?

Are you looking in the provided Excel spreadsheet or something else?

Yes, TargetReefs_202425.csv ? I only see a single sheet in there since it's a csv file. Maybe I am missing an attachment, hopefully i didn't add the wrong data in

Oh sorry, thought you were adding data from the recent Excel spreadsheet (CSVs are not excel files).


Alarm creation

Hi! Thanks for all the work you've done documenting this api. I'm wondering, do you know if a route is provided to create alarms on the device?

Hm at the time (~2018), there wasn't any way to create new alarms in the app, only get and delete. Has that changed now?

Hm at the time (~2018), there wasn't any way to create new alarms in the app, only get and delete. Has that changed now?

Where would I look in the app to find the alarm menu?


Using Available User Profile Information in Discussions

Description
MA-2762
We were getting user profile information in GET API calls for discussions. So we are using that available user profile information for PATCH and POST API calls.

Codecov Report

Merging #923 into master will decrease coverage by 0.02%.
The diff coverage is 8.88%.

@@            Coverage Diff             @@
##           master     #923      +/-   ##
==========================================
- Coverage   44.86%   44.84%   -0.03%
==========================================
  Files         384      384
  Lines       24775    24792      +17
==========================================
+ Hits        11115    11117       +2
- Misses      13660    13675      +15

Impacted Files
Coverage Δ

Source/OEXRouter+Swift.swift
17% <0%> (ø)
:arrow_up:

Source/DiscussionResponsesViewController.swift
1.16% <0%> (-0.03%)
:arrow_down:

Source/DiscussionAPI.swift
17.79% <21.42%> (+0.48%)
:arrow_up:

Source/PostsViewController.swift
56.73% <25%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74c5347...17a8c73. Read the comment docs.

@salman2013  Ready for review.

Observation: When we go in particular discussion from "All posts" and try to vote by pressing the '+' icon the profile image disappear and the default image appears. This happens with all the responses except the first one.

@salman2013 Ready for another review.


fix(board view): Fix routing in app runtime

fix(board view): Fix routing in app runtime

@nimishamukherjee snapshot fabric8-ui is deployed and available for testing at https://fabric8-ui-fabric8-ui-pr-1940-fabric8-planner.int.rdu2c.fabric8.io

Closing this as PR #1945 fixes the same issue.


Multiple defined rippleColor attr when compile 'com.android.support:design

Error:(2) Attribute "rippleColor" has already been defined
the error above occured when i compile 'com.android.support:design:23.1.0' and 'com.github.navasmdc:MaterialDesign:1.5@aar' in the same project.so i clone your code and change 'rippleColor' to 'rippleColor_design' to resolve this error.i think i should remind your,bro.
thanks for your contribute

same +1

Same here! +1

same!!!

upupup

same, any solutions to this yet?

@Zapnologica clone code and change 'rippleColor' to 'rippleColor_design'(or other name you want) to resolve this error

but if I want to use the latest version?

Why does author not make this change and release a new version?

haha,I just give up,used AppCompatV7 instead.

+1

+1

+1

+1

It's helpful
http://stackoverflow.com/a/33510760/513413

+1

+1

While I think this will continue to be an open issue for a long time, if you need material design for pre-lollipop and you don't want to change the rippleColor by modifying this lib yourself I found another great library which is: https://github.com/rey5137/material .

+1

the same +1

+1, author dont support the library?

Same problem!

same problem!


Use bundle exec when running middleman commands

I can’t really speak to why…but I’ve been told this is best practice.
The server won’t run for me without doing this.

I've run into this too. Since we have now locked the version numbers, this makes a lot of sense (so it doesn't try to use your system Middleman if it's more recent) :+1:

:zap: QUICK!
Thanks!


Add a couple new tests

Codecov Report

Merging #111 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #111   +/-   ##
=======================================
  Coverage   97.21%   97.21%
=======================================
  Files           6        6
  Lines         287      287
  Branches       33       33
=======================================
  Hits          279      279
  Misses          8        8

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be48851...571506b. Read the comment docs.


OAK-10327 Embedded dependencies should have "provided" scope

Otherwise they are transitively inherited by depending Maven modules

Is the test failure related to this change really?
Error:  Tests run: 4, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 2.781 s <<< FAILURE! - in org.apache.jackrabbit.oak.segment.spi.persistence.split.SplitPersistenceTest
Error:  testBinaryReferencesAreNotNull(org.apache.jackrabbit.oak.segment.spi.persistence.split.SplitPersistenceTest)  Time elapsed: 0.103 s  <<< ERROR!
org.apache.jackrabbit.oak.segment.file.InvalidFileStoreVersionException: Using oak-segment-tar, but oak-segment should be used
...

Is the test failure related to this change really?

Unlikely. I've seen similar failure as well every now and the. E.g. https://issues.apache.org/jira/browse/OAK-10293

Indeed, Jenkins fails with another non-related failure :-)

If there is no further concern I will merge end of this week.


build: remove marked-terminal

We're not using it and it was showing a missing peerDep for marked.

Note: I will want to use it (or something similar) at some point when implementing the CLI. For now it's not useful though so removing it.


docs: add user survey rfc

closes #2685
Checklist

[x] The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
[x] Links to related issues (if applicable)
[ ] Tests for the changes have been added/updated (if applicable)
[ ] Docs related to the changes have been added/updated (if applicable)

Rendered version: https://github.com/MelindaCardenas/datahub/blob/patch-1/docs/rfc/active/2775-user-survey.md

Closing as this RFC is technically outdated. Feel free to re-open and petition for inclusion if you believe that the RFC is in good shape to add into the repo.
/cc @jjoyce0510


PowerRun have to be better

Provide a description of the new feature / enhancement
When doing search ,it is weaker than simply pressing win+s. Why on earth is it happening? Please at lease enable it to open the control panel.

@Brutt-design|
What do you mean by it is weaker than simply pressing win+s? It does not find some options that win+s search does, correct? If yes, can you give few examples? FYI, I can open Control Panel from PT Run.

Sorry for my bewildering description and thank you for replying my request. After received your e-mail, I tried to find some more specific examples. What’s more, I guess I have realised where the problem lays. Actually, I am a Chinese, so when I type something relate to the system in Chinese, the PT Run will not show those options. However, later I tried these words again in English, it works great. I guess it must have something to do with the language support.
发送自 Windows 10 版邮件应用
发件人: Mykhailo Pylyp
发送时间: 2021年4月26日 19:33
收件人: microsoft/PowerToys
抄送: Brutt-design; Mention
主题: Re: [microsoft/PowerToys] PowerRun have to be better (#10946)
@Brutt-design|
What do you mean by it is weaker than simply pressing win+s? It does not find some options that win+s search does, correct? If yes, can you give few examples? FYI, I can open Control Panel from PT Run.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

@Brutt-design
It seems as your system language is English. Is it correct? It is expected that you have to use your system language to search with the Windows Search plugin.

Well，that’s the most strange part, actually, my system language is Chinese. Moreover, both Chinese and English works well when I am using ‘win+s’. I really love the simplicity of PT Run , please correct this issue.
发送自 Windows 10 版邮件应用
发件人: Mykhailo Pylyp
发送时间: 2021年4月26日 21:28
收件人: microsoft/PowerToys
抄送: Brutt-design; Mention
主题: Re: [microsoft/PowerToys] PowerRun have to be better (#10946)
@Brutt-design
It seems as your system language is English. Is it correct? It is expected that you have to use your system language to search with the Windows Search plugin.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

@Brutt-design
Can you give more examples of apps that can not be found using the Chinese language?
Our Program plugin is not localization-friendly. It does not work with system applications(like Control Panel) with localizable names.

@enricogior
What should be a priority here?

File Explorer 文件资源管理器，Control Panel 控制面板，Disk Cleanup 磁盘清理，Paint 画图，Windows Defender Firewall with Advanced Security 高级安全 Windows Defender 防火墙，Services 服务…… 几乎所有的系统应用及功能都有这个问题。Almost everything related to OS has this problem. 我也和楼主一样，很喜欢PT Run这个功能。麻烦开发者看到这个之后能修复一下。谢谢了！I also like PT Run very much. Please fix it. THANKS!

包括锁屏，关机等功能也都没有汉化。Functions like "Lock" and "Shutdown" haven't supported Chinese yet, either.

This sounds like a duplicate of the bug where some app names aren't translated.
/dup of

包括锁屏，关机等功能也都没有汉化。Functions like "Lock" and "Shutdown" haven't supported Chinese yet, either.

Duplicate of

是的，所以有的时候会比较头疼。不过，在发现原因之后，我基本常用的涉及系统的英文名称已经都比较熟悉了，暂时应该没什么问题。就是不知道有没有可以让它进一步本地化的项目。
发送自 Windows 10 版邮件应用
发件人: Heiko
发送时间: 2021年5月3日 5:25
收件人: microsoft/PowerToys
抄送: Brutt-design; Mention
主题: Re: [microsoft/PowerToys] PowerRun have to be better (#10946)
包括锁屏，关机等功能也都没有汉化。Functions like "Lock" and "Shutdown" haven't supported Chinese yet, either.
Duplicate of
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

是的，有一点点尴尬。Well, that’s why the lack of localisation make the daily use of this amazing tool become a little bit awkward for Chinese users.
发送自 Windows 10 版邮件应用
发件人: 万里雪飘
发送时间: 2021年4月29日 19:27
收件人: microsoft/PowerToys
抄送: Brutt-design; Mention
主题: Re: [microsoft/PowerToys] PowerRun have to be better (#10946)
包括锁屏，关机等功能也都没有汉化。Functions like "Lock" and "Shutdown" haven't supported Chinese yet, either.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

@xuangeyouneihan , @mykhailopylyp , @Brutt-design
Can we close this issue. For both mentioned problems we have individual and better described issues.

我觉得阔以/I think we can

@crutkas
We can close this a duplicate. See my comments before.


Invalid or corrupt jarfile

Hi thanks for publishing this repo.
When I run the jarfile, I got an error saying "Invalid or corrupt jarfile"

well it's a 6 year old jar so anything is possible. maybe try re-compiling with newer tools?


Decide if the graph should be printed on_model or print_model

on_model:

User can silence the stable model but still get the graph

print_model:

Needed if you only want graphs for optimal models

clingraph shouldn't need to call clingo and the callback methods to produce a graph.
If used as a library #15 is should probably return a graphviz object, graphviz text data or a file location with the rendered image.
As input it should probably accept either a clorm factbase, a collection of strings, or a collection of files (or any mixture of those).
In this way we could also use it for systems like clingo-dl or clingcon or any other systems developed in the future. It would also be possible to render models already stored in a database or file.

I agree with all this @MaxOstrowski ! We will restructure the project to allow all of this functionalities. When the input is a collection of files you mean the current behaviour were we call clingo with all the files? And if so, then we would still need to think of how to answer the question for this issue

I (personally) would only allow a collection of files that represent facts. This is exactly hat clorm excepts as input.
So no choice rules or integrity constraints, but simple, deterministic rules and include statements.