Suggestion about auto merging / assigning and etc

Hay there! :)
I'm thinking that it would be good if we can customize options a bit more. For some weeks i'm wanting both 1) Renovate to open PRs even if build pass and 2) want to assign me, so it will be shown in the notifications (as like someone mentioned me, not just notification because i'm watching the repository). But here's the problem: i don't care if build pass and don't want noise.
So, fix for this case would be to open PRs , but assign me only if the build fail, so i will go and look what's happening.
Currently, i'm using branch-push only because don't care about passing builds, but i want to see the PRs and so others to be able to see that PRs, not just some commits by some bot. I want users to see that other bots (such as codecov comments) and services (such as travis and nodesecurity) pass. Actually, this review process is available in the commit history with green tick, but you should click that tick and it's not so obvious and no so easy to see what passed and etc.

Please confirm if I'm understanding:

You want PRs for everything
You want to automerge any that pass
You want to assign PRs to yourself only if they fail?

You want PRs for everything

Yes, as like with pr option.

Right now our functionality is "only assign PRs if automerge is disabled". I guess you want "only assign PRa if automerge is disabled or tests fail"?

Right now our functionality is "only assign PRs if automerge is disabled"

That's definitely not true. I had automerge enabled and automerType: pr and it was assigning me :P I'll try to find that prs
I want to automerge prs, but assign me only if tests fail.

like
{
  "automerge": true,
  "automergeType": "pr",
  "assign": ["charlike"]
}

Hm, okey, my fault, it didn't assign me. :) But yea, you get what i want?

I'm fine with updating existing logic to assign PRs if tests fail. The only thing is that if you unassigned yourself then it will probably reassign you each time. GitHub doesn't expose the history of assign/unassign so we can't tell.

if you unassigned yourself then it will probably reassign you each time

Do you mean in each commit of that pr? If so, i don't think it would be a problem, because you are working on that to fix that pr, so you are there anyway.


[NSX] Add more unit tests

Description
This PR adds more unit tests for NSX integration

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)
[ ] build/CI

Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale

[ ] Major
[ ] Minor

Bug Severity

[ ] BLOCKER
[ ] Critical
[ ] Major
[ ] Minor
[ ] Trivial

Screenshots (if appropriate):
How Has This Been Tested?

How did you try to break this feature and the system with this change?

@blueorangutan package

@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: ✖ el7 ✖ el8 ✖ el9 ✖ debian ✖ suse15. SL-JID 8179

@blueorangutan package

@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Merging based on packaging results (even though not reported on Github)


api for collector first commit - [closed]

In GitLab by @luotian-github on Aug 1, 2017, 04:55
Merges sc -> dev
api for collector first commit

In GitLab by @wknet123 on Nov 13, 2019, 09:51
closed


Accept fill color in SvgUri

From the issue name, I believe it is a duplicate of https://github.com/software-mansion/react-native-svg/issues/1317 so I close it to keep the discussion in one place. Feel free to comment here if something is wrong and we can always reopen it then.


Updates for breaking changes to branch protection API

Per https://developer.github.com/changes/2016-06-27-protected-branches-api-update/, breaking changes were made to the protected branches API during the preview period.
This PR gets started implementing the new routes. Specifically:

Removes Branch.Protection, no longer returned by the API
Removes EditBranch function, protection is now modified using separate API routes
Adds GetBranchProtection function
Adds UpdateBranchProtection function
Adds RemoveBranchProtection function

omitempty is intentionally left off fields in ProtectionRequest because passing nil (JSON null) has semantic meaning (described in https://developer.github.com/v3/repos/branches/#update-branch-protection)
Like the issues API, we separate some request structures from response structures because on the request, users and teams are specified as strings of logins or slugs, respectively, but in responses, full representations are returned.
Feedback and suggestions welcomed :heart:

@shurcooL This is ready for another look, I think. Cheers.

Thank you, @alindeman for your contribution, and @shurcooL for your code reviews!
LGTM.
Merging.

Included in https://github.com/google/go-github/commit/3b96b535044d9bdb869b91c7f7d6807f327c12f2


Unable to convert gltf to glb

I am trying to convert a gltf-model to glb with the latest Node version (17.9.0). I get the error below when running this command line in directory containing the gltf-model:
gltf-pipeline -i sphere.gltf -o sphere.glb
Error     at new RuntimeError (C:\Users\flisa\AppData\Roaming\npm\node_modules\gltf-      pipeline\node_modules\cesium\Build\CesiumUnminified\Cesium.js:7121:13)     at fileURLToPath (C:\Users\flisa\AppData\Roaming\npm\node_modules\gltf-pipeline\lib\FileUrl.js:38:11)     at readFile (C:\Users\flisa\AppData\Roaming\npm\node_modules\gltf-pipeline\lib\readResources.js:148:24)     at readResource (C:\Users\flisa\AppData\Roaming\npm\node_modules\gltf-pipeline\lib\readResources.js:114:10)     at readImage (C:\Users\flisa\AppData\Roaming\npm\node_modules\gltf-pipeline\lib\readResources.js:73:10)     at C:\Users\flisa\AppData\Roaming\npm\node_modules\gltf-pipeline\lib\readResources.js:55:31     at Function.ForEach.object (C:\Users\flisa\AppData\Roaming\npm\node_modules\gltf-pipeline\lib\ForEach.js:44:21)     at Function.ForEach.topLevel (C:\Users\flisa\AppData\Roaming\npm\node_modules\gltf-pipeline\lib\ForEach.js:63:18)     at Function.ForEach.image (C:\Users\flisa\AppData\Roaming\npm\node_modules\gltf-pipeline\lib\ForEach.js:202:18)     at C:\Users\flisa\AppData\Roaming\npm\node_modules\gltf-pipeline\lib\readResources.js:54:15     at tryCatcher (C:\Users\flisa\AppData\Roaming\npm\node_modules\gltf-pipeline\node_modules\bluebird\js\release\util.js:16:23)     at Promise._settlePromiseFromHandler (C:\Users\flisa\AppData\Roaming\npm\node_modules\gltf-pipeline\node_modules\bluebird\js\release\promise.js:547:31)     at Promise._settlePromise (C:\Users\flisa\AppData\Roaming\npm\node_modules\gltf-pipeline\node_modules\bluebird\js\release\promise.js:604:18)     at Promise._settlePromise0 (C:\Users\flisa\AppData\Roaming\npm\node_modules\gltf-pipeline\node_modules\bluebird\js\release\promise.js:649:10)     at Promise._settlePromises (C:\Users\flisa\AppData\Roaming\npm\node_modules\gltf-pipeline\node_modules\bluebird\js\release\promise.js:729:18)     at Promise._fulfill (C:\Users\flisa\AppData\Roaming\npm\node_modules\gltf-pipeline\node_modules\bluebird\js\release\promise.js:673:18) {   message: 'Expected path.protocol to start with file:' }
There is no problem to open and view model in a 3D-displayer.
I am also using latest React version in this project.
Any suggestions?

It seems like it's unable to load a uri in your gltf. Based on the trace it's hitting this error:
  if (path.protocol !== "file:") {
    throw new RuntimeError("Expected path.protocol to start with file:");
  }

Does this give any ideas? Could you post your gltf?

Thanks for the reply!
That sounds about right, I'll check with my colleague who made the model.
But if you have the time, it would be great if you could check as well
Sphere_gltf.zip
!

Thanks for posting the glTF. The problem is here:
"images": [{"uri": "C:\\Users\\46767\\Desktop\\web3d\\Textur.png"}],

Try using a relative path instead.

Great!
Now it works perfectly, thanks!


<EMAIL_ADDRESS>decompress error

PS C:\WINDOWS\system32> scoop install sushi/tencent-meeting
Installing 'tencent-meeting' (<IP_ADDRESS>6) [64bit]
Loading TencentMeeting_0300000000_<IP_ADDRESS>6.publish.exe from cache
Checking hash of TencentMeeting_0300000000_<IP_ADDRESS>6.publish.exe ... ok.
Extracting dl.7z ... done.
Running installer script...
Out-File : Could not find a part of the path 'D:\Scoop\apps\tencent-meeting\<IP_ADDRESS>6$5\7zip.log'.
At D:\Scoop\apps\scoop\current\lib\core.ps1:432 char:9

    Out-File -FilePath $LogPath -Encoding ASCII -Append -InputObj ...

    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

CategoryInfo          : OpenError: (:) [Out-File], DirectoryNotFoundException
FullyQualifiedErrorId : FileOpenFailure,Microsoft.PowerShell.Commands.OutFileCommand

ERROR Exit code was 2!
Failed to extract files from D:\Scoop\apps\tencent-meeting\<IP_ADDRESS>6$5\weMeet.*.zip.
Log file:
D:\Scoop\apps\tencent-meeting\<IP_ADDRESS>6$5\7zip.log


Identifiers validation failed for dataset HISA - Herbário de Ilha Solteira

Identifier validation failed for the dataset HISA - Herbário de Ilha Solteira:

Crawler attempt: 123
Publishing organization: Universidade Estadual Paulista
Publishing country: BRAZIL
Installation: speciesLink Network / INCT-HVFF IPT
Number of occurrences indexed for this dataset at the time of the issue: 11086
Cause: GBIF ID problems exceed 50% threshold: 100% duplicates; 11086 total records; 11086 absent records
Pipelines execution steps: http://api.gbif.org/v1/pipelines/history/execution/4171846/step

New IDs sample:

Old IDs sample:

BRA:UNESP-IS:HISA:10943
BRA:UNESP-IS:HISA:10944
BRA:UNESP-IS:HISA:10945
BRA:UNESP-IS:HISA:10946
BRA:UNESP-IS:HISA:10947
BRA:UNESP-IS:HISA:10948
BRA:UNESP-IS:HISA:10949
BRA:UNESP-IS:HISA:10950
BRA:UNESP-IS:HISA:10951
BRA:UNESP-IS:HISA:10952

Publisher email
Hello,
I am contacting you from the GBIF Secretariat about a dataset published by the HISA - Herbário de Ilha Solteira : https://doi.org/10.15468/mphhy4.
We noticed that the occurrenceIDs were changed. We have temporarily paused the ingestions of this dataset.
As you might already know, when an occurrence record has a new occurrenceID for a given dataset, our system considers it to be a new occurrence.
This means that it will be given a new gbifid and a new occurrence URL (like this one: https://www.gbif.org/occurrence/1252968762) and the old gbifid and URL will be deprecated.
In this case, this means that the occurrence URLs would be deprecated when ingesting the newest versions of these datasets.
We would like to check with you if those changes were intentional. Do you know if this is the case?
Please let us know, thanks! We are happy to resume the dataset ingestion.
Note that some users rely on those occurrence URLs and gbifids (like https://bionomia.net for example). In an attempt to improve
the stability of the occurrence URLs and gbifids, we have implemented a warning system to detect these type of changes in datasets (see this news item).
If the data publisher can provide us with a list of old and new occurrenceIDs per record, we can avoid the identifier and URL changes. Could that be an option?
Please let us know if you have any question. Thanks!
All the best,

You can skip/fix identifier validation using the registry UI.

Identifier validation still  failing for the dataset HISA - Herbário de Ilha Solteira:

Crawler attempt: 125
Publishing organization: Universidade Estadual Paulista
Publishing country: BRAZIL
Installation: speciesLink Network / INCT-HVFF IPT
Number of occurrences indexed for this dataset at the time of the issue: 11086
Cause: GBIF ID problems exceed 50% threshold: 100% duplicates; 11086 total records; 11086 absent records
Pipelines execution steps: http://api.gbif.org/v1/pipelines/history/execution/4212130/step

New IDs sample:

Old IDs sample:

BRA:UNESP-IS:HISA:10943
BRA:UNESP-IS:HISA:10944
BRA:UNESP-IS:HISA:10945
BRA:UNESP-IS:HISA:10946
BRA:UNESP-IS:HISA:10947
BRA:UNESP-IS:HISA:10948
BRA:UNESP-IS:HISA:10949
BRA:UNESP-IS:HISA:10950
BRA:UNESP-IS:HISA:10951
BRA:UNESP-IS:HISA:10952

Publisher email
Hello,
I am contacting you from the GBIF Secretariat about a dataset published by the HISA - Herbário de Ilha Solteira : https://doi.org/10.15468/mphhy4.
We noticed that the occurrenceIDs were changed. We have temporarily paused the ingestions of this dataset.
As you might already know, when an occurrence record has a new occurrenceID for a given dataset, our system considers it to be a new occurrence.
This means that it will be given a new gbifid and a new occurrence URL (like this one: https://www.gbif.org/occurrence/1252968762) and the old gbifid and URL will be deprecated.
In this case, this means that the occurrence URLs would be deprecated when ingesting the newest versions of these datasets.
We would like to check with you if those changes were intentional. Do you know if this is the case?
Please let us know, thanks! We are happy to resume the dataset ingestion.
Note that some users rely on those occurrence URLs and gbifids (like https://bionomia.net for example). In an attempt to improve
the stability of the occurrence URLs and gbifids, we have implemented a warning system to detect these type of changes in datasets (see this news item).
If the data publisher can provide us with a list of old and new occurrenceIDs per record, we can avoid the identifier and URL changes. Could that be an option?
Please let us know if you have any question. Thanks!
All the best,

You can skip/fix identifier validation using the registry UI.


[BugFix] Fix iceberg mv refresh NPE

Fixes #issue
Fix NPE

What type of PR is this:

[ ] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[ ] I have checked the version labels which the pr will be auto-backported to the target branch

[ ] 3.1
[ ] 3.0
[ ] 2.5
[ ] 2.4

[FE PR Coverage Check]
:heart_eyes: pass : 1 / 1 (100.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/catalog/Column.java
1
1
100.00%
[]

@Mergifyio backport branch-3.1


Addition of pixelPairStep

For internal consumption.
For PR to CMSSW, we could use directly: https://github.com/trackreco/cmssw/tree/mkFitPixelPairStep
together with https://github.com/mmasciov/RecoTracker-MkFit/tree/mkFitPixelPairStep
This PR is related to trackreco/mkFit#320
Note: in this PR, I'm also commenting out the sanity check on seed hits, to be able to run with latest mkFit (including pixel seed merging)

I'm also commenting out the sanity check on seed hits, to be able to run with latest mkFit (including pixel seed merging)

That basically means that the downstream will see a random seed associated for each track (and an exception if the mkFit's cand.label() exceeds the number of seeds in CMSSW's seed container). It could be acceptable for near term to allow development to proceed. @slava77, what do you think?

@makortel and @slava77: I am OK with keeping the sanity check, but if we keep it and make a distribution with the current mkFit to be used within CMSSW, then it will crash after N events (when pixel seed merging takes place). If we wish to keep the check, we should probably solve the source of the crash (in the seed merging procedure), or the code will not really be usable.

In my opinion the seed issue should be addressed properly (whatever that is) before making a new release for CMS.

I have reverted the change in MkFitOutputConverter (i.e., restored the sanity check) in branch trackreco/cmssw/mkFitPixelPairStep, for eventual PR to CMSSW.
Can restore it here too, while the issue is properly addressed.

That basically means that the downstream will see a random seed associated for each track (and an exception if the mkFit's cand.label() exceeds the number of seeds in CMSSW's seed container). It could be acceptable for near term to allow development to proceed. @slava77, what do you think?

as I mentioned earlier on skype, I did not quite follow the implications.
I thought that after merging several seeds we simply get a "randomly" selected label of one of the contributing original seeds. If that's the case, then it should be just fine to use this label to set the output TrackCandidate seed and seedRef using the original seed with such label. However, if the point is that the output TrackCandidate will have a nonsense seed/seedRef, then it's bad.

To what does the cand.label() point to when seeds are merged? Is it something in the original seed container, or something in the container of merged seeds (if such exists)? In case if the former, disabling the sanity check would be ok (although maybe make it configurable?), I have been assuming the latter.

We used to create a container of clean seeds, after seed cleaning, which is a subset of the original seed collection (from CMSSW).
The only difference after trackreco/mkFit#321 is that [we now add hits from overlapping seeds to seeds in the same collection] (https://github.com/trackreco/mkFit/pull/321/files#diff-bbf7f7daabbb2c72e01c99bc493c8384d96badb4f375a3b1e71502ddf4bd8f83R282). The label/index of the seed should not be affected (@osschar).

On a further thought, if the cand.label() is guaranteed to point to an index in one of the merged seeds in the original seed container, I think the "sanity check" could actually be removed as it is not that useful anymore (even without merging).

Do you prefer to leave it as is (commented out) for history, or removed completely for cleaning purposes?
If the latter, I'll just remove it.

I'd prefer to remove it completely (history stays in git anyway). If there would be any motivation to keep the implementation, I'd make it configurable.

As per latest commit, the sanity check has been removed (I don't see a reason to keep it as configurable at this stage).

Looks good now, thanks. Could you then squash the commits into two, one for removing the sanity check, and second for adding the pixelPairStep? That would keep the history cleaner and help for any future rebase of the CMSSW_11_2_0_mkFit_X and PR(s) towards CMSSW (although you already have a branch for the latter).

Commits have been squashed as suggested (@makortel).

Thanks!


Google Console button

There is instruction on codelab "In the upper left-hand part of the lab page, click the Open Google Console button". I didn't find it.

I am not sure what you mean. If you are attempting the codelab through Google Codelabs/Qwiklabs, you should have been able to locate the "Open Google Console" button, considering you have started the lab first.
Do let me know if anything else is required. If I solved your question, please close this issue


Logging Feature request

many time i'm change my machine. i was thinking my all setting saved with my account. just because that's usefull. if in case some one change its machine. and he want work urgently and he did not have his own machine. he's working with another machine. if he had there account with vscode. then he simply login and work.
logging feautre save our time. we don't need install any extansion. if we priously installed

If "Logging" word means "log in and sync settings/extensions" then that feature is already in development. See #87479

/duplicate


Documentation

I tried to drop you a line using the 'Contact' section from here: http://zebobo5.github.io/Vlc.DotNet, but unfortunately all I'm getting is a 405 error.
I'm likely to come into a little free time shortly and might be interested in putting together some documentation/examples to help ease the learning curve for the new library a little. Do you have any high level requirements/preferred formats for documentation?

I've did the documentation for the previous version. You can see that here: https://rexgrammer.github.io/Vlc.DotNet-Deprecated/doc/index.html
It's made with [Sandcastle Help File Builder] (https://shfb.codeplex.com/). It features a MSDN-style documentation style that's readable and easily maintainable. The main thing that should be done is commenting the code and adding XML comments, which SHFB will automatically convert into a class reference documentation library. You can comment the code, add xml comments submit a PR, then generate the class reference and submit a PR to the gh-pages branch with it added.
The next thing in order is to create wiki articles about using the library. For starters one 'quickstart' style article about using the library in WinForms and one for WPF would be really good.

I've used SandCastle on my own projects before, so that shouldn't present
too much of a problem.
I'm fluent in WPF, but it's been a long time since I did much in
WinForms. I'll maybe see about putting together an introductory walkthrough
for WPF first, then look into converting that to WinForms. I'll mail over
anything I put together for discussion and you can let me know if it's what
you're looking for.
Cheers
Dale
On 30 Mar 2015 18:21, "Matija Čupić"<EMAIL_ADDRESS>wrote:

I've did the documentation for the previous version. You can see that
here: https://rexgrammer.github.io/Vlc.DotNet-Deprecated/doc/index.html
It's made with Sandcastle Help File Builder https://shfb.codeplex.com/.
It features a MSDN-style documentation style that's readable and easily
maintainable. The main thing that should be done is commenting the code and
adding XML comments, which SHFB will automatically convert into a class
reference documentation library. You can comment the code, add xml comments
submit a PR, then generate the class reference and submit a PR to the
gh-pages branch with it added.
The next thing in order is to create wiki articles about using the
library. For starters one 'quickstart' style article about using the
library in WinForms and one for WPF would be really good.
—
Reply to this email directly or view it on GitHub
https://github.com/ZeBobo5/Vlc.DotNet/issues/37#issuecomment-87758650.

Yes Documentation - tutorials are really needed for new comers.
Please spend some time on it.

Closing this old issue to clean up the "issues" page. A "Getting started" wiki page has now been written. Feel free to create a new  issue if more doc is needed


optimize: improve route demo

What type of PR is this?
optimize
What this PR does / why we need it (English/Chinese):
en: improve route demo
zh: 完善了route的演示

lint need to fix

I'm trying to fix it。

ci check

LGTM


Some requirements

Hi, NATMI is very easy to use. here I have some requirements:

Can the NATMI team remove the intermediate file， because the output directory is very large and most of which are intermediate files? Most users don't care about the intermediate file.
Can the NATMI team provided other Organism L-R pairs? Because the ID transfer step is like a black box, it will be useful to directly provide other organisms (like  mouse, taxid:10090) L-R pairs,

Thanks!

Hi, thank you for your suggestions! We will add more organism L-R pair databases and allow the user to control if the intermediate files will be generated.


Feature Request: separate RequestAdapter for each Request

Use case:
Working with REST service whose Authorization process is based on asymmetric singing&encryption. Different endpoint may require or not require request signatures (HMAC or similar), meaning that each request should be signed using 1 or more private keys, or should not be signed at all.
As I understand in Alamofire 4.0 there are two ways it can be implemented:

Create several RequestAdapter instances (depending on how much private keys and private key combinations you have) which leads to creating several SessionManager instances with underlying NSURLSession.
Use the fact that creation of URLRequest is synchronous (is it?) and set appropriate RequestAdapter instance before creating request and clean this value after.

None of these approaches seems elegant to me, maybe we should allow to pass requestAdapter as parameter to all request methods in SessionManager?

Can you clarify your use case? Signing certain requests vs. others is a pretty straightforward use case that can be handled using an adapter or a router, so what's your issue? Unless the signing depending on keys returned by previous requests it seems like a router would be an ideal way to handle this.

Signing certain requests vs. others is a pretty straightforward use case that can be handled using an adapter or a router

Can you please explain how to implement such behavior using RequestAdapter? (and Router too)

Up?

My basic question is why can't accomplish what you need with Alamofire's current capabilities. Can you please explain your use case in more detail?

@jshier I need to sign different requests differently. Requests should be signed using different keys or sometimes should not be signed at all - that's the use case

Which can be easily done using the request router pattern outlined in our documentation. If that doesn't work for you, please explain why in as much detail as possible.

@jshier I can't understand how you suppose to do this easily using request router pattern, also documentation states that Router pattern can be used for Authorization, but doesn't include any examples for this case.
I ended with this workaround to allow passing different RequestAdapters for different requests (I really don't like this approach, but that's the best I can do at this moment)
struct AlamofireRequestRouter: URLRequestConvertible {
    private let url: URLConvertible
    private let method: HTTPMethod
    private let parameters: Parameters?
    private let encoding: ParameterEncoding
    private let headers: HTTPHeaders?
    private let adapter: RequestAdapter?

    init(
        _ url: URLConvertible,
        method: HTTPMethod = .get,
        parameters: Parameters? = nil,
        encoding: ParameterEncoding = URLEncoding.default,
        headers: HTTPHeaders? = nil,
        adapter: RequestAdapter? = nil)
    {
        self.url = url
        self.method = method
        self.parameters = parameters
        self.encoding = encoding
        self.headers = headers
        self.adapter = adapter
    }

    func asURLRequest() throws -> URLRequest {
        let originalRequest = try URLRequest(url: self.url, method: self.method, headers: self.headers)
        let encodedURLRequest = try encoding.encode(originalRequest, with: parameters)
        let adaptedURLRequest = try self.adapter?.adapt(encodedURLRequest) ?? encodedURLRequest
        return adaptedURLRequest
    }
}

You still haven't outlined in any detail what it is you're trying to do here. I'm not sure why you insist on using a request adapter for this, but if you follow the router example in the README it should be pretty clear. Just add an additional parameter based on the route and use it to sign your requests. Since you haven't outlined what signing your requests looks like I can't really help you any further until you do.

@jshier The point is that signing url request logic should be separated from logic that creates requests. Code, that performs requests signatures, should not depend on the way you create your requests and vice versa, that's why I think RequestAdapter is the best way to accomplish my goal as it only takes fully prepared URLRequest and doesn't care about who/when/where created it

Hi @SanjoDeundiak,
My apologies for just catching up on this thread now. Your initial assessment is correct in that you would need to use multiple session managers with multiple adapters to easily accomplish this. This is exactly what we do in a large networking library we've built at the company I work at. In ours you create a separate session manager and adapter / retrier for each authentication system you use. It also gives you the ability to customize each session manager based on the needs of that authentication system. Works great!
I'm curious as to why you feel this isn't elegant? At some point, you have to make a decision as to what type of authentication you're going to use for your request. IMO, that should be made way before actually making that request in a big networking library. You don't want to have to make that decision when you're actually calling your request, you'd much rather do it when you define the request and how you actually call it as @jshier mentioned either in your Router pattern (not preferred here), or by assigning the request to be made on a specific session manager whose adapter handles the authentication (preferred).
Another option would be to use a single session manager and adapter, then inspect the request to decide which type of authentication to apply to it, but this seems like a much worse alternative to me. Generally you should only need to call at max a handful of different authentication schemes so using a session manager and adapter / retrier per authentication scheme works out fairly well.
As for attaching an adapter to a request, I've been thinking through this quite a bit and while I do believe it would be possible, it seems messy. Why would I want to define my authentication scheme for each request when I could define it at the session manager level? As I mentioned before, most apps don't use that many authentication schemes, so why add more complexity to creating a request? On top of this, it seems problematic to allow session managers (potentially multiple session managers) to be hopping all over the place calling into adapters and retriers in an inconsistent way. By attaching them to a single adapter / retrier, you certainly limit your scope for testing purposes.
With that said, it's probably possible though to switch the adapter / retrier pattern over to being a per-request type of design, but I don't see the merit there over attaching them to the session manager. Separating your auth per session manager has many other advantages that IMO outweigh the flexibility of attaching them to the request.
Hopefully that helps clarify things here. I'm going to go ahead and close this issue out, but feel free to continue the conversation.
Cheers. 🍻


segfault on invalid input

while testing some new features of my chess gui, one of which was buggy, the following commands were sent to patricia4:
position fen 1Nb3k1/5ppp/2n2n2/Pp2p3/4P3/2N1bP2/1PP2rPP/1K1R1B1R w - b6 0 20 moves b8c6 c8d7 c6e5 b5b4 c3d5 f6d5 e4d5 d7a4 d5d6 a4c2 b1a2 b4b3 a2a3 c2d1 d6d7 e3c5 a3a4 f2d2 f1d3 c5e7 a5a6 d1e2 d3e2 d2b2 a6a7 b2a2 a4b5 a2a7 b5b6 a7d7 e5d7 e7a3 f3f4 g7g5 f4g5 h7h6 g5h6 b3b2 e2d3 a3b4 g2g4 b4d2 g4g5 d2c1 h1g1 b2b1q g5g6
isready
readyok
go depth 4

and the engine crashed. crash is reproducible with this input.

What behavior would you want to see happen? I thought that the GUI is responsible for sanitizing positions and ensuring that the engines don't get fed illegal positions (Stockfish will straight up crash if you feed it invalid inputs as well).

i wasn't aware of that stockfish does that too. figured you might be interested in fixing this from a security PoV. if invalid input is detected an info line could be printed. but if you're aware of the issue and OK with it, that's fine too, so feel free to close this.

This is a fun thread to read: https://github.com/official-stockfish/Stockfish/pull/4558
Ideally I would fix it eventually, but it's not very high on my list of priorities right now. Thank you for pointing it out, however!


OpenMemories AppStore - Error Downloading App

Currently getting an error of "Error downloading app" when trying to install v1.0.0 from the OpenMemories AppStore.
Other apps download okay.

I've now installed via IE in Windows.


Label syntax for missing values

Lets say I have 10 charts.  1 chart has a label stage: pre and another has the label stage: post
When I do
helmfile -l stage=pre sync  I get the expected 1 chart from pre and the same for post.
When I do
helmfile -l stage!=pre,stage!=post sync I would expect to get the other 8 charts, but I get 0 charts as the charts without the label are not selectable.
When I do
helmfile -l stage!='' sync I would expect to also get the other 8 charts, but I get an error.
2018/04/07 16:45:35 Malformed label: stage!=. Expected label in form k=v or k!=v

@sstarcher Good point! Your expectation sounds very valid. It would also follow the same semantics as kubectl, which is good.

This seems to be working fine in master.


Error by podman version? How to use latest in action 🤔
https://github.com/containers/crun/issues/1308

https://github.com/containers/podman/issues/15169

https://noobient.com/2023/11/15/fixing-ubuntu-containers-failing-to-start-with-systemd/


Little request

Description of the feature, modification, idea or suggestion
Please add a check for child processes and if there are none, remove the "Terminate Tree" and "Suspend Tree" options from the context menu ;)
Proposed implementation details (optional)
No response

You can already see if a process has child process, click on the 'Name' column header to or three times.

@Biswa96 topicstarter haven't said that it is impossible to see whether process has children or not. He asked about hiding unneeded/not working menu items automatically.


Add the redirected link to the message displayed on the docs site

Added: https://github.com/mchristofides/pg_docs_bot/pull/8


Update README for loader.js changes in SDK 3.13

Modified README to use relative require paths, and added a note about SDK 3.13

Can we get a heading for that instead of a note? Like "SDK 3.13 Changes"
Also would be useful to have the error message that gets thrown to also be included in there somewhere so if someone searched for the problem they will get the answer.


Support more hash functions to generate the public key in the eddsa-poseidon package

Is your feature request related to a problem? Please describe.
This implementation of EdDSA is mostly based on the circomlibjs library, which uses BLAKE1-512 to derive the public key from the private key, probably because performance is more important in this context than security. RFC 8032 suggests using SHA-512 (presumably SHA3-512 nowadays), and BLAKE1 is starting to get out of date. It might make sense to offer devs more solutions.
Describe the solution you'd like
The package may use conditional exports and offer several versions of the same implementation using different hash functions. The default export could be the one with the best hash function in terms of security and performance (with more emphasis on performance), probably BLAKE2.
Devs may import EdDSAPoseidon in the following way:
import { EdDSAPoseidon } from "@zk-kit/eddsa-poseidon" // Default, BLAKE2

import { EdDSAPoseidon } from "@zk-kit/eddsa-poseidon/blake-1" // BLAKE1

import { EdDSAPoseidon } from "@zk-kit/eddsa-poseidon/sha-3" // SHA3

Describe alternatives you've considered
The functions and class exported from the package may take an additional parameter to define the hash function to be used. The default one could be the best one in terms of security and performance (with more emphasis on performance), probably BLAKE2.
The parameter could be part of an options object, where other parameters could be added in the future.
Additional context

SHA
BLAKE
RCF 8032 - Key Generation
BLAKE1 vs SHA3
BLAKE1 vs BLAKE2
BLAKE2 JavaScript implementation
SHA3 JavaScript implementation

Hey! I'm Hannah, a dev currently studying the core program with the PSE team. I would be interested in picking this up!
My approach:

I would choose one new algorithm to start, probably Blake2.
I would implement this algorithm via the spec and set it as the default.
I would add the additional ability to configure/ choose an alternative algorithm (at this point, to revert to Blake1)
Then, in subsequent PRs, I would add the additional algorithms.

If you would be happy for me to go ahead, it would be great if you could let me know if you know of any implementations of the above algorithms that could be used, or whether it would be required to research/implement this too

Hey @hannahredler, great! I'll assign this task to you :)
I think a good blake2 implementation could be: https://github.com/dcposch/blakejs.
sha3: https://github.com/emn178/js-sha3.
Conditional exports should be the right way to go.


range documentation update

moved examples from comments to unittests
marked verify unittests as doc unittests and deleted duplication

LGTM, thanks!

Auto-merge toggled on

thank you


Issue Gssoc logo image change for both light and dark mode

Issue:223 #223 Resolved : Changed the logo for both light and Dark mode

Image for light mode

Image for dark mode

It was under GSSOC'23 . Thank you very much for merging my PR and guiding me .

@Hardikaz My bad. Thanks for reminding me.


[Mention The Feature]: Enhance css of term and condition

Is your feature request related to a problem? Please describe.

i can improve its styling in more better way
Describe the solution you'd like.
No response
Describe alternatives you've considered.
No response
Additional context.
No response
Show us the magic with screenshots
No response
Checklist

[X] I have checked the Existing Issues
[X] I have read the Contributing Guidelines
[X] I want to work on this issue. (optional)

@Sawan-Kushwah firstly please make the required changes that i have asked you in the Pull Request.
And i didn't merged that Pull Request yet.

and for now we don't require any improvements in this page.
so i am closing this issue.
please understand.


health checker reporting wrong status of kubelet and docker

Using the latest version of node problem detector v0.8.12 on centos hosts and getting the following errors in node problem detector pod logs. Kubelet and docker are running fine on worker nodes.
I0923 12:03:33.000348       1 plugin.go:280] Start logs from plugin {Type:permanent Condition:KubeletUnhealthy Reason:KubeletUnhealthy Path:/home/kubernetes/bin/health-checker Args:[--component=kubelet --enable-repair=true --cooldown-time=1m --loopback-time=0 --health-check-timeout=10s] TimeoutString:0xc0008c8560 Timeout:3m0s}
 I0923 12:03:32.899702     731 health_checker.go:172] command /bin/systemctl show kubelet --property=InactiveExitTimestamp failed: exit status 1, []
I0923 12:03:32.899833     731 health_checker.go:86] error in getting uptime for kubelet: exit status 1
I0923 12:03:33.000451       1 plugin.go:281] End logs from plugin {Type:permanent Condition:KubeletUnhealthy Reason:KubeletUnhealthy Path:/home/kubernetes/bin/health-checker Args:[--component=kubelet --enable-repair=true --cooldown-time=1m --loopback-time=0 --health-check-timeout=10s] TimeoutString:0xc0008c8560 Timeout:3m0s}
I0923 12:03:33.000413       1 plugin.go:280] Start logs from plugin {Type:permanent Condition:ContainerRuntimeUnhealthy Reason:DockerUnhealthy Path:/home/kubernetes/bin/health-checker Args:[--component=docker --enable-repair=true --cooldown-time=2m --health-check-timeout=60s] TimeoutString:0xc0008c8490 Timeout:3m0s}
 I0923 12:03:31.000008     732 health_checker.go:172] command docker ps failed: exec: "docker": executable file not found in $PATH, []
I0923 12:03:32.499561     732 health_checker.go:172] command /bin/systemctl show docker --property=InactiveExitTimestamp failed: exit status 1, []
I0923 12:03:32.499647     732 health_checker.go:86] error in getting uptime for docker: exit status 1
I0923 12:03:33.000528       1 plugin.go:281] End logs from plugin {Type:permanent Condition:ContainerRuntimeUnhealthy Reason:DockerUnhealthy Path:/home/kubernetes/bin/health-checker Args:[--component=docker --enable-repair=true --cooldown-time=2m --health-check-timeout=60s] TimeoutString:0xc0008c8490 Timeout:3m0s}
I0923 12:03:42.300129       1 plugin.go:280] Start logs from plugin {Type:permanent Condition:KubeletUnhealthy Reason:KubeletUnhealthy Path:/home/kubernetes/bin/health-checker Args:[--component=kubelet --enable-repair=true --cooldown-time=1m --loopback-time=0 --health-check-timeout=10s] TimeoutString:0xc0008c8560 Timeout:3m0s}
 I0923 12:03:41.999805     747 health_checker.go:172] command /bin/systemctl show kubelet --property=InactiveExitTimestamp failed: exit status 1, []
I0923 12:03:41.999978     747 health_checker.go:86] error in getting uptime for kubelet: exit status 1
I0923 12:03:42.499410       1 plugin.go:281] End logs from plugin {Type:permanent Condition:KubeletUnhealthy Reason:KubeletUnhealthy Path:/home/kubernetes/bin/health-checker Args:[--component=kubelet --enable-repair=true --cooldown-time=1m --loopback-time=0 --health-check-timeout=10s] TimeoutString:0xc0008c8560 Timeout:3m0s}
I0923 12:03:43.099878       1 plugin.go:280] Start logs from plugin {Type:permanent Condition:ContainerRuntimeUnhealthy Reason:DockerUnhealthy Path:/home/kubernetes/bin/health-checker Args:[--component=docker --enable-repair=true --cooldown-time=2m --health-check-timeout=60s] TimeoutString:0xc0008c8490 Timeout:3m0s}
 I0923 12:03:40.999669     748 health_checker.go:172] command docker ps failed: exec: "docker": executable file not found in $PATH, []
I0923 12:03:42.599728     748 health_checker.go:172] command /bin/systemctl show docker --property=InactiveExitTimestamp failed: exit status 1, []
I0923 12:03:42.599818     748 health_checker.go:86] error in getting uptime for docker: exit status 1
I0923 12:03:43.099981       1 plugin.go:281] End logs from plugin {Type:permanent Condition:ContainerRuntimeUnhealthy Reason:DockerUnhealthy Path:/home/kubernetes/bin/health-checker Args:[--component=docker --enable-repair=true --cooldown-time=2m --health-check-timeout=60s] TimeoutString:0xc0008c8490 Timeout:3m0s}
I0923 12:03:52.999718       1 plugin.go:280] Start logs from plugin {Type:permanent Condition:ContainerRuntimeUnhealthy Reason:DockerUnhealthy Path:/home/kubernetes/bin/health-checker Args:[--component=docker --enable-repair=true --cooldown-time=2m --health-check-timeout=60s] TimeoutString:0xc0008c8490 Timeout:3m0s}
 I0923 12:03:50.800119     766 health_checker.go:172] command docker ps failed: exec: "docker": executable file not found in $PATH, []
I0923 12:03:52.499664     766 health_checker.go:172] command /bin/systemctl show docker --property=InactiveExitTimestamp failed: exit status 1, []
I0923 12:03:52.499756     766 health_checker.go:86] error in getting uptime for docker: exit status 1
I0923 12:03:52.999817       1 plugin.go:281] End logs from plugin {Type:permanent Condition:ContainerRuntimeUnhealthy Reason:DockerUnhealthy Path:/home/kubernetes/bin/health-checker Args:[--component=docker --enable-repair=true --cooldown-time=2m --health-check-timeout=60s] TimeoutString:0xc0008c8490 Timeout:3m0s}
I0923 12:03:53.399529       1 plugin.go:280] Start logs from plugin {Type:permanent Condition:KubeletUnhealthy Reason:KubeletUnhealthy Path:/home/kubernetes/bin/health-checker Args:[--component=kubelet --enable-repair=true --cooldown-time=1m --loopback-time=0 --health-check-timeout=10s] TimeoutString:0xc0008c8560 Timeout:3m0s}
 I0923 12:03:52.899518     765 health_checker.go:172] command /bin/systemctl show kubelet --property=InactiveExitTimestamp failed: exit status 1, []
I0923 12:03:52.899690     765 health_checker.go:86] error in getting uptime for kubelet: exit status 1
I0923 12:03:53.399632       1 plugin.go:281] End logs from plugin {Type:permanent Condition:KubeletUnhealthy Reason:KubeletUnhealthy Path:/home/kubernetes/bin/health-checker Args:[--component=kubelet --enable-repair=true --cooldown-time=1m --loopback-time=0 --health-check-timeout=10s] TimeoutString:0xc0008c8560 Timeout:3m0s}
I0923 12:04:03.799271       1 plugin.go:280] Start logs from plugin {Type:permanent Condition:ContainerRuntimeUnhealthy Reason:DockerUnhealthy Path:/home/kubernetes/bin/health-checker Args:[--component=docker --enable-repair=true --cooldown-time=2m --health-check-timeout=60s] TimeoutString:0xc0008c8490 Timeout:3m0s}
 I0923 12:04:01.399269     783 health_checker.go:172] command docker ps failed: exec: "docker": executable file not found in $PATH, []

/Reopen

/reopen


L.marker displayed incorrect after wheelzoom

https://user-images.githubusercontent.com/1823148/115925343-462ca700-a481-11eb-8d4d-37f1a67d4c0d.mp4
I am running into an issue where all L.marker (with .bindTooltip) suddenly displayed at the wrong position.
That behaviour only gets fixed by zooming in/out again.

After some more testing, I can share using smoothWheelZoom: 'center', doesn't reproduce the issue.


Create time evolution with just doppler averaging function

Doppler averaging:

Allow for Doppler profile of atomic beam by assuming a Gaussian distribution centred on the resonance with doppler shift delta = 0
Use this in the time evolution without the averaging from the Gaussian laser beam profile (TEM_00)


[1201] Implement save on confirm - diversity forms

Context
https://trello.com/c/cd0aQMUx/1201-l-implement-save-on-confirm-diversity-information
Changes proposed in this pull request

Removed all the diversity services that were responsible for updating records and moved that behaviour into diveristy forms.
Updated all the diversity forms to support the common stash and save! interface
Introduced a new object DiversityForm that the confirm page can use to to display the data from various diversity form stores and save it to the database

Guidance to review
Draft trianee

Play around with the diversity forms. Make sure it works as before. Data will continue to be saved to DB immediately.

Non-draft trainee

Visit a non-draft trainee and click through to change 'Diversity information', 'Ethnicity' and 'Disability'
Check that validations are still working
Make a change, click continue
Click cancel and you'll see the original information
Repeat, but confirm your change
See that the change is now saved permanenty

 [L] Implement save on confirm - diversity information

@jhenderson Nice job so far, this was a bit of a beast. I've left a few comments but noticed two UX quirks.
The undo/cancel link is missing:

Also, if you have not provided any disabilities but then change to provided and select one, when you go to the confirm page the text "Not provided" is still shown, see clip below:

All good


Add "No Results" Feedback to Search if nothing returned

Just want to provide some feedback (in the list view) that the search was done & no results were returned (right now it is a little unclear):

Verified - thanks for adding


slightly flexable leg connections

Move sam's leg inputs to his triggers. Maybe play around with the idea of different depths of pull having different forces? Would need to have a system of detecting different depths of trigger pull with as little of a pause as possible. I'm thinking when you detect no change (or very little change) execute.
Hold down to charge as well then release. Wiggilly legs.
Holding trigger down could bring leg up, then releasing could stamp foot down. Gives good visual feedback & falling over before stamp would make aiming easier

Moved input to legs, still some questions around legs moving / reacting better. Double joint so leg moves behind body? Bit of a bounce.

task described in comment completed in PR #43 . Might require a little tweaking, but don't need a ticket for that.


Doesn't seem to work in VS2013

I downloaded the files, loaded CommentsPlus-v11.sln and then compiled in VS2015 Community and built the vsix (I wanted to remove the italics). This vsix installs and works fine in VS2015. However my daily box runs VS2013 and it doesn't work in there. It installs fine, but the additional Comments items don't show up in Fonts & Colors settings, and nothing happens.
Any idea what might be wrong?

There are a couple of issues I've run into.:
I just updated the solution to support VS 2017 RC which was quite a pain. If that is the source version you used, it actually needs to be built with 2017. Otherwise be sure to get an earlier version of the source.
If you do get the earlier version you need to build it with VS2013 and the 2013 VS SDK. Otherwise it won't work on 2013.
BUT if you just want to disable italics, you could just download the latest published VSIX and change settings in the registry:
HKCU\Software\CommentsPlus
 - DWORD value EnableTags
 - DWORD value EnableItalics


Bluetooth: audio: csip: Provide the service context of CSIS instance

Is your enhancement proposal related to a problem? Please describe.
Currently, the CSIP API does not provide the context of the CSIS instance that can be included by other service.
As there might be multiple instances of CSIS on the server, each instance shall be included by other service.
The remote GATT Database might look like:
Coordinated Set Identification Service (1st instance)
Coordinated Set Identification Service (2nd instance)
Common Audio Service (includes 2nd CSIS)
Battery Service (includes 1st CSIS)
Meaning that the device is in 2 sets: Audio Set and Battery Set.
The struct bt_csip_set_coordinator_cb.discover callback provides information about CSIS instances found:
typedef void (*bt_csip_set_coordinator_discover_cb)(
	struct bt_conn *conn,
	const struct bt_csip_set_coordinator_set_member *member,
	int err, size_t set_count);

where:
struct bt_csip_set_coordinator_set_info {
	uint8_t set_sirk[BT_CSIP_SET_SIRK_SIZE];
	uint8_t set_size;
	uint8_t rank;
	bool lockable;
};

struct bt_csip_set_coordinator_csis_inst {
	struct bt_csip_set_coordinator_set_info info;
	void *svc_inst;
};

struct bt_csip_set_coordinator_set_member {
	struct bt_csip_set_coordinator_csis_inst insts[BT_CSIP_SET_COORDINATOR_MAX_CSIS_INSTANCES];
};

As shown, there is no service context given, thus the information about insts found is unusable e.g. in the context of audio operations because one does not know which inst to refer.
Describe the solution you'd like
I was thinking of changing
int bt_csip_set_coordinator_discover(struct bt_conn *conn);

to
int bt_csip_set_coordinator_discover(struct bt_conn *conn, const struct bt_uuid *uuid);

so that the discover callback would return the CSIS instance that is used in the context of service with uuid, but as there might be multiple instances of the service with given uuid maybe additional service_handle parameter is needed.
I think that there is no point of discovering all of the instances as implementation might be interested in some specific CSIS only that can be used in the context on some service only.

Closing due to lack of response and that I don't think this is necessary.


[GraphSDK] create a new API endpoint to be able to generate X25519 keys

Why
When doing integrations with Saas client it became obvious that they only have access to Sr25519 keys and can not generate any X25519 keys which we use for the graph. All alternative JVM libraries that generate x25519 are heavy weight and not that great so it makes sense to provide this functionality as an api in GraphSdk to allow generating new x25519 keys without adding a new library.
What

[x] Add a new api endpoint generate_keypair(key_type: GraphKeyType) to graph sdk which does not require state. Please follow the same pattern as deserialize_dsnp_keys endpoint which does not have &self as a param.
[x] Add JNI, FFI, Node bridges
[x] Add integration test in Rust/Java/FFI/Node

Notes

It seems like that wallet currently does not support x25519 and we have to communicate with wallet teams to add the support for those type of keys
Ensure that keys being generated are unique and use randomness provided by OS or device. One option to just use StackKeyPair::gen() from dryoc library which is using the same implementation as lib-sodium

Question:
Do we need api for ffi? c/c++ can use libsodium

I think we should have it so that all the apis are uniform across all languages


Work on transferring LD4P2 indices to LD4P3 server

Also document/upload scripts used

Follow up with @gdelisle week of December 14th

Done


Add application model detection package

https://github.com/aspnet/AzureIntegration/issues/109
Also: https://github.com/aspnet/Universe/pull/645

@pakrym is this ready?
cc @glennc

Yes, this is ready for review.

@glennc please take a look when you can.

/cc @dariagrigoriu

/cc @dariagrigoriu @davidebbo

So what's the idea here? Possible options:

we copy the relevant source code into the Kudu code base

you make a nuget and we reference that

feels cleaner, and arguably the semantic of the package is somewhat general purpose and not App Service specific.

@davidebbo I am good with us shipping the package to MyGet. Are you good with taking it from there?

@glennc sure, as long as it's a public myget that we can reference from our public Kudu sources that should be fine.

cc @Eilon.  I think creating a new feed for this package would be good so that if we end up wiping our dev feeds, we wouldn't accidentally delete it.

@muratg so why not just put it on NuGet? Is not like there is a very high bar for hosting packages there...

Can we put it on NuGet.org as unlisted?

(As in, would that work for you, @davidebbo ?)

I think that would add some pain points in term of taking a reference to it in VS, and getting it updated after you push new one.

@davidebbo ah sure thing, we can make it be a listed package, but if so, I think we need to clean up a few things first (@pakrym see my 2 comments I just added).

Re nuget.org vs myget -- I can't recall if we have any other "unsupported" package on nuget right now. I.e. if we push this to nuget, we'll need to decide whether or not it is "supported" for 3rd party customers. who may take a dependency on it.

You could make it a forever prerelease (like 0.9.x), giving you semver freedom to break it anytime you want.


Have semantic_validation() for tx essence/payload without unlocks

Description
Have semantic_validation() for tx essence/payload with the unlocks optional. And make it available to the bindings.
Motivation
Currently semantic_validation() accepts the signed transaction, but it would also make sense to have an option to validate the tx before signing, so one doesn't have to resign if something is wrong.
Are you planning to do it yourself in a pull request?
No.

We can't change that on develop though?

Why not? We can keep the existing one and add a new method?

Closed by https://github.com/iotaledger/iota-sdk/pull/1572


How to change layer to B.SilkS ?

i use KiBuzzard but output To F.SilkS ,
How to change layer to B.SilkS ?

When the footprint label is selected use the 'flip' command ('F' key, or context menu) to move it from F.Silk to B.Silk.


feat: Removed obsolete code. Fixes godot-escoria/escoria-issues#99

I haven't tested that yet, because develop is currently unstable. So I might check this again after #497
But I don't see, why this shouldn't work as the code was bogus basically. 😄

LGTM.


Avoid unnecessary computation of magnitude variance in Portilla-Simoncelli model

I realized that PortillaSimoncelli._compute_cross_correlation was always computing the variance itself (for normalizing the covariance to a cross-correlation), but that this was unnecessary because, in two of the three calls, it was computing the variance of each magnitude band, which had already been computed (while computing the auto-correlation of those magnitude bands). This refactor then allows us to make use of that fact, only computing the variance as necessary.
In this model, the above change does not change the total forward time by a noticeable amount. It will, however, help the pooled Portilla-Simoncelli model.
Additionally, I swapped the final two dimensions of the magnitude bands' auto-correlations, changing their shape from (batch, channel, spatial_corr_width, spatial_corr_width, n_scales, n_orientations) to (batch, channel, spatial_corr_width, spatial_corr_width, n_orientations, n_scales). This makes their shape more consistent with the other stats, which always have n_scales as the final dimension. As a result, it makes the representation plot a bit easier to interpret.
The first change above does mean that the metamer output is slightly, but not perceptually, different from before, so needed to update the contents of the test files. While doing so, I realized that the GPU and CPU synthesis outputs are now identical. I doubt that's related to these changes, but unsure when that happened.
Finally, also added -n auto to our pytest configuration in pyproject.toml, so that pytest will take advantage of parallelization by default (this won't affect the CI, which had manually added that arg).

A question: because of the dimension swap, I had to update the tests for Portilla-Simoncelli as well. For the matlab tests, this makes sense: the statistics will be ordered differently in the two, so the test should include swapping the matlab representation's dimensions as appropriate.
For the regression tests against earlier versions of plenoptic, that feels a little odder to me. You can see these changes in test_ps_torch_output and test_portilla_simoncelli_scales. My inclination is that I should just update the test files themselves; not regenerate them, but just make those manual changes, which will keep the test code a bit cleaner. I haven't done that right now, because it means that this PR will block any open ones (because they'll then fail the Portilla-Simoncelli tests), but I think it does make sense.

Ah actually, looking back at those test files, I think I would need to regenerate them; making sure I rearranged them correctly would be difficult. I think that's fine, as the fact that the tests are passing now, with the old test files but the rearranging in the test functions, means that the rearranging would be the only changes.

Yes, that makes sense. I'll go ahead and update those files and then merge this

I updated the test files, as discussed, and also added some helper functions in tests/utils.py, in case I need to do so again.


Is the scale of the compat parameters important?

If I multiply all compat parameters with the same factor, does it change anything in the result?

Numerical experiments showed me that yes, multiplying all the compat params by the same factor changes the result.


Open request component

Summary of Changes
Adds an Open Request Metadata component that triggers the opening/closing of the request component.
Tests
Need to add tests for the component after implementation is approved
Documentation
N/A
CheckList
Make sure you have checked all steps below to ensure a timely review.

[ ] PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"

In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

[ ] PR includes a summary of changes, including screenshots of any UI changes.
[ ] PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
[ ] In case of new functionality, my PR adds documentation that describes how to use it.

All the public python functions and the classes in the PR contain docstrings that explain what it does

[ ] PR passes all tests documented in the developer guide
[ ] I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message"

Codecov Report

Merging #254 into request-notifs will increase coverage by 3.53%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##           request-notifs   #254      +/-   ##
================================================
+ Coverage           69.46%    73%   +3.53%
================================================
  Files                 132     26     -106
  Lines                3354   1089    -2265
  Branches              369     90     -279
================================================
- Hits                 2330    795    -1535
+ Misses                989    267     -722
+ Partials               35     27       -8

Impacted Files
Coverage Δ

amundsen_application/api/mail/v0.py
72.85% <0%> (-13.69%)
:arrow_down:

...ication/static/js/components/common/Tabs/index.tsx

...ndsen_application/static/js/ducks/search/api/v0.ts

...ication/static/js/components/common/Flag/index.tsx

...ts/common/ResourceListItem/TableListItem/index.tsx

...sen_application/static/js/ducks/allTags/reducer.ts

...tatic/js/components/common/ScrollTracker/index.tsx

...pplication/static/js/ducks/popularTables/api/v0.ts

...static/js/components/common/ResourceList/index.tsx

...tic/js/components/common/ResourceList/constants.ts

... and 97 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b24dda9...b98443b. Read the comment docs.

@ttannis should be good for review again, lmk if implementation looks good so I can write tests.

@ttannis should be good for review again, lmk if implementation looks good so I can write tests.

Looks good.

@ttannis good to look over again with tests, also changed the naming to what you had suggested, definitely makes sense 😄


Consumer Version Selector fallbackBranch Is Ignored

The fallbackBranch option on consumer version selectors is ignored, even though it's a valid property.
If you run:
pact_verifier_cli \
    -b "https://pactbroker.example.org" \
    --consumer-version-selectors '{"branch":"feat/foo","fallbackBranch":"main"}' \
    -n "My API" \
    -l debug

then the verifier submits the following:
[DEBUG] (1) pact_verifier::pact_broker: Sending JSON to https://pactbroker.example.org/pacts/provider/My%20API/for-verification
using POST: {"providerVersionTags":[],"includePendingStatus":false,"consumerVersionSelectors":[{"branch":"feat/foo"}]}

This then retrieves no pacts if the consumers aren't using the same branch name, and so the provider test fails:
Failures:

1) Failed to load pact - Could not load pacts from the pact broker 'https://pactbroker.example.org'
- NotFound("No pacts were found for this provider")

This does need to be fixed, but I recommend not using the fallback branch option, and I regret creating it. The reason is that it allows you to make backwards incompatible changes with the master branch. If you use two selectors, branch=master and branch={feature_branch}, the feature branch selector will just select nothing if there is no matching branch, and you'll still get master. If you're on master, then the pacts are deduplicated anyway, so there's no negative side effect.
If you use the fallback option, then you're either verifying the feature pact OR the master pact, and this can allow you to introduce changes that are not backwards compatible with master.


compiling error on windows: class "__half" has no member "x"

I am trying to compile cutorch on Windows using Visual Studio 2015 and CUDA 9.1, and I am struggling with the error class "__half" has no member "x", as following.
1>j:\cpp-torch\cutorch\lib\thc\THCTensorTypeUtils.cuh(141): error : class "__half" has no member "x"
1>j:\cpp-torch\cutorch\lib\thc\THCTensorTypeUtils.cuh(141): error : class "__half" has no member "x"
1>j:\cpp-torch\cutorch\lib\thc\THCTensorTypeUtils.cuh(145): error : class "__half" has no member "x"
1>j:\cpp-torch\cutorch\lib\thc\THCTensorTypeUtils.cuh(145): error : class "__half" has no member "x"
1>j:\cpp-torch\cutorch\lib\thc\THCNumerics.cuh(114): error : class "__half" has no member "x"
1>j:\cpp-torch\cutorch\lib\thc\THCNumerics.cuh(115): error : class "__half" has no member "x"
I look at the definition of __half structure, and the x variable doesn't actually exist. The older CUDA version also doesn't work as well.
Anybody has any clue for this error?

@JrManit did you manage to solve the problem? I'm having the same issues with Ubunt 16.04 LTS,CUDA 9.1, gcc 6.3.0. The following error messages were shown:
[ 30%] Building NVCC (Device) object src/ATen/CMakeFiles/ATen.dir/__/THC/generated/ATen_generated_THCTensorMathReduceDouble.cu.o
[ 30%] Building NVCC (Device) object src/ATen/CMakeFiles/ATen.dir/__/THC/generated/ATen_generated_THCTensorMaskedDouble.cu.o
[ 31%] Building NVCC (Device) object src/ATen/CMakeFiles/ATen.dir/__/THC/ATen_generated_THCHalf.cu.o
[ 31%] Building NVCC (Device) object src/ATen/CMakeFiles/ATen.dir/__/THCUNN/ATen_generated_AbsCriterion.cu.o
[ 31%] Building NVCC (Device) object src/ATen/CMakeFiles/ATen.dir/__/THCUNN/ATen_generated_Abs.cu.o
[ 31%] Building NVCC (Device) object src/ATen/CMakeFiles/ATen.dir/__/THCUNN/ATen_generated_BatchNormalization.cu.o
/home/anaconda3/include/THC/THCTensorTypeUtils.cuh(171): error: class "__half" has no member "x"
/home/anaconda3/include/THC/THCTensorTypeUtils.cuh(171): error: class "__half" has no member "x"
/home/anaconda3/include/THC/THCTensorTypeUtils.cuh(175): error: class "__half" has no member "x"
/home/anaconda3/include/THC/THCTensorTypeUtils.cuh(175): error: class "__half" has no member "x"
4 errors detected in the compilation of "/tmp/tmpxft_00011fa2_00000000-11_Abs.compute_61.cpp1.ii". CMake Error at ATen_generated_Abs.cu.o.cmake:267 (message): Error generating file /home/Downloads/pytorch/torch/lib/build/aten/src/ATen/CMakeFiles/ATen.dir/__/THCUNN/./ATen_generated_Abs.cu.o`

Probably the same issue as #797

I am having this error too, did anybody solve it yet?
@nagadomi I posted this error into issue #797 as well but it seems to be something different since the proposed solutions do not work for me. Maybe anybody else has found a fix for this in the meantime?


Quick Sort in Dart

💥 Proposal
Implemention of Quick Sort in Dart
Have you read the Contributing Guidelines on Pull Requests?
Yes

/assign


Bump token dashboard prod deployment to 1.3.2

Good to merge once we've confirmed the deployment.

… How about you push this commit to that branch 😅


Chore: upgrade coveralls to ^3.0.1

This should fix the security warning GitHub is giving about https://nvd.nist.gov/vuln/detail/CVE-2018-3728, because it no longer involves a dependency on hoek.

Coverage remained the same at 99.258% when pulling 1f34567ae8b5c5b73594ec95d7a77de19daf63e1 on upgrade-coveralls into 8667e34a3ecf377d119d1dab4376c8be71fd95bf on master.


Visual Studio 2015 Update 2

Hi,
When I installed update 2 my jQuery snippets no longer work. I see the jQuery snippets in the manager and can see just the jQuery folder in the IntelliSense but when I choose it, nothing is in it. I've attempted a re-install with no success. My activity log shows this error when I try typing after the jQuery folder is selected in IntelliSense:
System.NullReferenceException: Object reference not set to an instance of an object.
   at Microsoft.VisualStudio.Editor.Implementation.Snippets.SnippetPicker.OnTypedChar(Char typedChar, Boolean provisionalText)
   at Microsoft.VisualStudio.Editor.Implementation.Snippets.SnippetPicker.Exec(Guid& pguidCmdGroup, UInt32 nCmdID, UInt32 nCmdexecopt, IntPtr pvaIn, IntPtr pvaOut)
   at Microsoft.VisualStudio.Editor.Implementation.VsKeyboardFilter.SendCommand(Guid cmdGroup, UInt32 cmdID, Object inParam)
   at Microsoft.VisualStudio.Editor.Implementation.VsKeyboardFilter.TextInput(TextCompositionEventArgs args)
   at Microsoft.VisualStudio.Text.Editor.Implementation.KeyProcessorDispatcher.<>c.<DispatchTextInputEvents>b__6_0(KeyProcessor p, TextCompositionEventArgs args)
   at Microsoft.VisualStudio.Text.Editor.Implementation.KeyProcessorDispatcher.<>c__DisplayClass10_1`1.<Dispatch>b__0()
   at Microsoft.VisualStudio.Text.Utilities.GuardedOperations.CallExtensionPoint(Object errorSource, Action call)

I have not installed update 2 yet myself. I will try to do that soon to see if I can reproduce. It is not immediately apparent to me what the issues is at the moment. Let me know if you find a solution in the meantime.

I've moved to update 2 and did not have any issues regarding the extension.

Closing this since I cannot reproduce.


Issue with Blog Posts loop

Hi,
I'm trying to add Blog posts list into my index.html (of my theme) where the following code (copied from the basic theme) for blog list is in a sub-page (inc/blogs.html) which is pulled into index.html in a div. However it doesn't seem to populate anything. The only time blog list works is when it is selected as the Homepage in the Settings page.  The latest posts list works fine, only the blog posts does not.  Can you see what could be the issue?
{loop: $blog.posts}

    {if: $value.cover_photo}

    {/if}

{$value.title} Management

{$value.content}

    {$lang.blog.readmore}

{/loop}

Thanks.

It appears that the variable $.blog.posts is only available on the blog.html page. Not even on the post.html page.
Am I right?


chore(main): release base 0.0.25

:robot: I have created a release beep boop
0.0.25 (2024-10-19)
Bug Fixes

🐛 release to special branch (#147) (9924a82)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

base-v0.0.25
:sunflower:


Bump iglu-scala-core to 1.0.0

Closing in favor of https://github.com/snowplow/iglu-scala-client/issues/134


Changed font for the tooltip in the meshery settings component

Notes for Reviewers

This PR partially fixes #12739

Added Qanelas soft for tooltip in MesherySettings component.
Before

After

Signed commits

[x] Yes, I signed my commits.

Use Sistent.

Closing PR as the approach needs to change.


BSD compatible source & bad interface enumeration

OpenBSD has a downstream patch :
--- src/libnet_link_bpf.c.orig  Wed Jan 28 20:45:00 2004
+++ src/libnet_link_bpf.c       Thu Dec  5 19:25:50 2013
@@ -28,7 +28,6 @@
  */

 #include <sys/param.h>  /* optionally get BSD define */
-#include <sys/timeb.h>
 #include <sys/file.h>
 #include <sys/ioctl.h>

@@ -43,6 +42,7 @@
 #include <sys/sysctl.h>
 #include <net/route.h>
 #include <net/if_dl.h>
+#include <net/if_types.h>
 #include "../include/gnuc.h"
 #include "../include/bpf.h"

@@ -308,9 +308,13 @@ libnet_get_hwaddr(libnet_t *l)
     for (next = buf ; next < end ; next += ifm->ifm_msglen)
     {
         ifm = (struct if_msghdr *)next;
+        if (ifm->ifm_version != RTM_VERSION)
+            continue;
         if (ifm->ifm_type == RTM_IFINFO)
         {
             sdl = (struct sockaddr_dl *)(ifm + 1);
+            if (sdl->sdl_type != IFT_ETHER)
+                continue;
             if (strncmp(&sdl->sdl_data[0], l->device, sdl->sdl_nlen) == 0)
             {
                 if (!(ea = malloc(sizeof(struct libnet_ether_addr))))

Moreover if you have a bunch of interface , if you ifconfig down one of them the libnet will fail to find a compatible interface.
I guess that just like non ethernet interface were not ignored , down interface are not handled well either
this is true on : <IP_ADDRESS> , i did not find any path/or issue mentioning that, but i m not very good at github digging.
I will try to upgrade the basic source of the package here and see if the down interface problem still exists, i hope you can accept patches so i  will not have downstream patch here.

yes, we accept patches

Hello Sam, you can check my fork i did some work on libnet/src/libnet_if_addr.c , this fixes my issues.
The current code completely breaks when iterating a down interface .
The previous patch remove any sprintf reference in the code .
I Need a someone to cross test this on Linux especially, i m running test on various OpenBSD.
Do you have unit test script ? any remarks to get this approved ?

Your fork builds just fine on my Linux box.
Can you submit a pull request?

Thank you sgeto !
I will need to remove the debug printf before merging back.
( and read how to merge the fork back )

:+1
On Wed, May 8, 2019, 4:10 AM dohnuts<EMAIL_ADDRESS>wrote:

Thank you sgeto !
I will need to remove the debug printf before merging back.
( and read how to merge the fork back )
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/sam-github/libnet/issues/79#issuecomment-490309174,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AB7U4UISSJR7MAF5KKLPNNDPUISAFANCNFSM4HIPZH6A
.

#81 is up

Merged to master, with some minor fuzz to commit message. Thank you @dohnuts for taking the time to both report and fix this, and also to everyone involved in the audit! :smiley::+1:


Github actions for more connectivity!

We can implement github workflows for the following things:

Auto comment on issue Closed and Opened
Auto comment on PR mergs
Auto comment on PR raises

Using this workflows makes you'r repo more interactive ! @Rakshit-gen
i'm expecting a level3 with gssoc-ext and hacktoberfest-accepted label

It's a level 2 issue, I'll award you that


Weighted Graph Edge Index Matrix

Hi,
I have a graph where I don't have access to the location proximity and distance between nodes. I first assumed it is an unweighted graph and created an edge index matrix with 0's and 1's, but I want to train my GNN models on weighted graphs. To begin with I will change my edge index matrix manually to have values between 0 and 1. Later I want to design a method to that learns these edge weights. I appreciate if you have any suggestions on GNN training with weighted graphs and you can lead me to an example script/paper. Thanks a lot.

In case you want to operate on a fully-connected graph where you want to learn the probability of an edge, it might be best to use/modify the dense GNN operators provided in PyG. Nonetheless, you can still learn/incorporate edge weights using the edge_index format. While you cannot backpropgate through edge_index, you can store an additional attribute edge_weight and use it in conjunction with edge_index for message passing. There are some ops that can make use addtional edge weights, e.g., GraphConv or GCNConv.


Single File Per ParquetExec, AvroExec, etc...

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
Part of #2079
Following on from #2292 and #2291 it should be possible to pull the multi-file handling out of each individual file operator, and delegate it to the physical plan. As described in #2079 this will greatly simplify the implementations, whilst also hiding fewer details from the physical plan.
Describe the solution you'd like
Currently a FileScanConfig would result ListingTable::scan generating a physical plan that looks something like
ParquetExec

I propose instead generating something like
UnionExec
  ProjectionExec: ... // Partition 1
    SchemaAdapterExec
        ParquetExec: ... // Partition 1 File 1
    SchemaAdapterExec
        ParquetExec: ... // Partition 1 File 2
  ProjectionExec: ... // Partition 2
    SchemaAdapterExec
        ParquetExec: ... // Partition 2 File 1
    SchemaAdapterExec
        ParquetExec: ... // Partition 2 File 2
    SchemaAdapterExec
        ParquetExec: ... // Partition 2 File 3

Whilst this is more complex, it results in less complexity in the file format operators, and should hopefully lead to less bugs due to things like #2170 or #2000
Describe alternatives you've considered
We could not do this
FYI @thinkharderdev @matthewmturner

Do you mean PartitionedFile for File?
pub struct PartitionedFile {
    /// Path for the file (e.g. URL, filesystem path, etc)
    pub file_meta: FileMeta,
    /// Values of partition columns to be appended to each row
    pub partition_values: Vec<ScalarValue>,
    /// An optional file range for a more fine-grained parallel execution
    pub range: Option<FileRange>,
}

I'm okay with the change, but regarding we directly translating Spark physical plan into DataFusion physical plan, is this possible we do this Original ParquetExec -> UnionExec(SchemaAdapterExec(New ParquetExec)) in ParquetExec's try_new method or somewhere related place in the physical plan?

Do you mean PartitionedFile for File, but removing the partition_values field?

Yes, although removing the partition_values is likely follow up work

in ParquetExec's try_new method or somewhere related place in the physical plan?

I would rather keep the translation logic out of the file format specific operators, but having a free function that can be called by ListingTable and potentially other things, such as your Spark translation layer, seems perfectly sensible to me. I just care about reducing the amount of smarts in the individual file format specific operators :smile:

having a free function that can be called by ListingTable and potentially other things, such as your Spark translation layer, seems perfectly sensible to me

Sounds great!

This sounds like a great idea. The serial file processing in ParquetExec is currently a pretty nasty bottleneck for queries over large numbers of parquet files.


Feat/new field

Add some interesting new field

will close these now and create new example breaking change pr's later


Comment here to be added as a collaborator

Comment below - you can say anything
We will all be using this repository today. Even though it's public right now, you will not be able to make changes until you're given the correct permissions. We've automated this process via the GitHub API and some fancy chatops. Once you comment, we will add you as a collaborator.
You'll also start to receive a lot of emails. (:exclamation:) You can slow these down immediately by clicking the 'Unwatch' button and selecting either the 'Not watching' or 'Ignoring' option.

First! @ppremk

welcome GitHub

Hallo

meh meh meh

Hi 👋 !

👋

Hello everyone

Heyo!

thank you Prem !

🙌


Lombok won't make project compile with the new gradle 3.2.0

Sup guys. Something is wrong with the new gradle 3.2.0.
As posted on Stackoverflow from this guy https://stackoverflow.com/questions/52606514/android-gradle-plugin-update-from-3-1-4-to-3-2-0-cause-taskexecutionexception
something unknown is generating the error stated on the post.
I've then created a new test project, removed the dependencies one by one and stripped everything until i've figured out that the things causing the issue is lombok.
Here is the stripped module level gradle file:

android {
    compileSdkVersion 28
    buildToolsVersion "28.0.3"
    defaultConfig {
        applicationId "com.test"
        minSdkVersion 17
        targetSdkVersion 28
        versionCode 1
        versionName "1"
        testInstrumentationRunner "android.support.test.runner.AndroidJUnitRunner"
        multiDexEnabled true
        javaCompileOptions {
            annotationProcessorOptions {
                includeCompileClasspath true
            }
        }
    }
    buildTypes {
        release {
            minifyEnabled false
            proguardFiles getDefaultProguardFile('proguard-android.txt'), 'proguard-rules.pro'
        }
    }
    dexOptions {
        preDexLibraries = false
        javaMaxHeapSize "2g"
        jumboMode true
    }
    compileOptions {
        sourceCompatibility JavaVersion.VERSION_1_8
        targetCompatibility JavaVersion.VERSION_1_8
    }
    lintOptions {
        checkReleaseBuilds false
        abortOnError false
    }
}

repositories{
    mavenCentral()
    maven {
        url 'https://jitpack.io'
    }
    maven { url 'http://dl.bintray.com/amulyakhare/maven' }
    maven { url 'https://maven.fabric.io/public' }
    flatDir {
        dirs 'libs'
    }
}

dependencies {
    implementation fileTree(include: ['*.jar'], dir: 'libs')
    androidTestImplementation('com.android.support.test.espresso:espresso-core:2.2.2', {
        exclude group: 'com.android.support', module: 'support-annotations'
    })
    //noinspection GradleCompatible
    implementation 'com.android.support:appcompat-v7:28.0.0'

    compileOnly 'org.projectlombok:lombok:1.18.2'
    annotationProcessor 'org.projectlombok:lombok:1.18.2'
    testImplementation 'junit:junit:4.12'
}

// So, if I leave compileOnly 'org.projectlombok:lombok:1.18.2' the following error occurs in compilation time:

org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':app:transformClassesWithDexBuilderForDebug'.
	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeActions(ExecuteActionsTaskExecuter.java:103)
	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:73)
	at org.gradle.api.internal.tasks.execution.OutputDirectoryCreatingTaskExecuter.execute(OutputDirectoryCreatingTaskExecuter.java:51)
	at org.gradle.api.internal.tasks.execution.SkipUpToDateTaskExecuter.execute(SkipUpToDateTaskExecuter.java:59)
	at org.gradle.api.internal.tasks.execution.ResolveTaskOutputCachingStateExecuter.execute(ResolveTaskOutputCachingStateExecuter.java:54)
	at org.gradle.api.internal.tasks.execution.ValidatingTaskExecuter.execute(ValidatingTaskExecuter.java:59)
	at org.gradle.api.internal.tasks.execution.SkipEmptySourceFilesTaskExecuter.execute(SkipEmptySourceFilesTaskExecuter.java:101)
	at org.gradle.api.internal.tasks.execution.FinalizeInputFilePropertiesTaskExecuter.execute(FinalizeInputFilePropertiesTaskExecuter.java:44)
	at org.gradle.api.internal.tasks.execution.CleanupStaleOutputsExecuter.execute(CleanupStaleOutputsExecuter.java:91)
	at org.gradle.api.internal.tasks.execution.ResolveTaskArtifactStateTaskExecuter.execute(ResolveTaskArtifactStateTaskExecuter.java:62)
	at org.gradle.api.internal.tasks.execution.SkipTaskWithNoActionsExecuter.execute(SkipTaskWithNoActionsExecuter.java:59)
	at org.gradle.api.internal.tasks.execution.SkipOnlyIfTaskExecuter.execute(SkipOnlyIfTaskExecuter.java:54)
	at org.gradle.api.internal.tasks.execution.ExecuteAtMostOnceTaskExecuter.execute(ExecuteAtMostOnceTaskExecuter.java:43)
	at org.gradle.api.internal.tasks.execution.CatchExceptionTaskExecuter.execute(CatchExceptionTaskExecuter.java:34)
	at org.gradle.execution.taskgraph.DefaultTaskGraphExecuter$EventFiringTaskWorker$1.run(DefaultTaskGraphExecuter.java:256)
	at org.gradle.internal.progress.DefaultBuildOperationExecutor$RunnableBuildOperationWorker.execute(DefaultBuildOperationExecutor.java:336)
	at org.gradle.internal.progress.DefaultBuildOperationExecutor$RunnableBuildOperationWorker.execute(DefaultBuildOperationExecutor.java:328)
	at org.gradle.internal.progress.DefaultBuildOperationExecutor.execute(DefaultBuildOperationExecutor.java:199)
	at org.gradle.internal.progress.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:110)
	at org.gradle.execution.taskgraph.DefaultTaskGraphExecuter$EventFiringTaskWorker.execute(DefaultTaskGraphExecuter.java:249)
	at org.gradle.execution.taskgraph.DefaultTaskGraphExecuter$EventFiringTaskWorker.execute(DefaultTaskGraphExecuter.java:238)
	at org.gradle.execution.taskgraph.DefaultTaskPlanExecutor$TaskExecutorWorker.processTask(DefaultTaskPlanExecutor.java:123)
	at org.gradle.execution.taskgraph.DefaultTaskPlanExecutor$TaskExecutorWorker.access$200(DefaultTaskPlanExecutor.java:79)
	at org.gradle.execution.taskgraph.DefaultTaskPlanExecutor$TaskExecutorWorker$1.execute(DefaultTaskPlanExecutor.java:104)
	at org.gradle.execution.taskgraph.DefaultTaskPlanExecutor$TaskExecutorWorker$1.execute(DefaultTaskPlanExecutor.java:98)
	at org.gradle.execution.taskgraph.DefaultTaskExecutionPlan.execute(DefaultTaskExecutionPlan.java:663)
	at org.gradle.execution.taskgraph.DefaultTaskExecutionPlan.executeWithTask(DefaultTaskExecutionPlan.java:597)
	at org.gradle.execution.taskgraph.DefaultTaskPlanExecutor$TaskExecutorWorker.run(DefaultTaskPlanExecutor.java:98)
	at org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:63)
	at org.gradle.internal.concurrent.ManagedExecutorImpl$1.run(ManagedExecutorImpl.java:46)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
	at org.gradle.internal.concurrent.ThreadFactoryImpl$ManagedThreadRunnable.run(ThreadFactoryImpl.java:55)
	at java.lang.Thread.run(Thread.java:745)
Caused by: java.lang.RuntimeException: com.android.build.api.transform.TransformException: java.lang.RuntimeException: java.lang.RuntimeException
	at com.android.builder.profile.Recorder$Block.handleException(Recorder.java:55)
	at com.android.builder.profile.ThreadRecorder.record(ThreadRecorder.java:104)
	at com.android.build.gradle.internal.pipeline.TransformTask.transform(TransformTask.java:230)
	at sun.reflect.GeneratedMethodAccessor655.invoke(Unknown Source)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.gradle.internal.reflect.JavaMethod.invoke(JavaMethod.java:73)
	at org.gradle.api.internal.project.taskfactory.IncrementalTaskAction.doExecute(IncrementalTaskAction.java:50)
	at org.gradle.api.internal.project.taskfactory.StandardTaskAction.execute(StandardTaskAction.java:39)
	at org.gradle.api.internal.project.taskfactory.StandardTaskAction.execute(StandardTaskAction.java:26)
	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter$1.run(ExecuteActionsTaskExecuter.java:124)
	at org.gradle.internal.progress.DefaultBuildOperationExecutor$RunnableBuildOperationWorker.execute(DefaultBuildOperationExecutor.java:336)
	at org.gradle.internal.progress.DefaultBuildOperationExecutor$RunnableBuildOperationWorker.execute(DefaultBuildOperationExecutor.java:328)
	at org.gradle.internal.progress.DefaultBuildOperationExecutor.execute(DefaultBuildOperationExecutor.java:199)
	at org.gradle.internal.progress.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:110)
	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeAction(ExecuteActionsTaskExecuter.java:113)
	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeActions(ExecuteActionsTaskExecuter.java:95)
	... 33 more
Caused by: com.android.build.api.transform.TransformException: java.lang.RuntimeException: java.lang.RuntimeException
	at com.android.build.gradle.internal.transforms.DexArchiveBuilderTransform.transform(DexArchiveBuilderTransform.java:427)
	at com.android.build.gradle.internal.pipeline.TransformTask$2.call(TransformTask.java:239)
	at com.android.build.gradle.internal.pipeline.TransformTask$2.call(TransformTask.java:235)
	at com.android.builder.profile.ThreadRecorder.record(ThreadRecorder.java:102)
	... 48 more
Caused by: java.lang.RuntimeException: java.lang.RuntimeException
	at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
	at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
	at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
	at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
	at java.util.concurrent.ForkJoinTask.getThrowableException(ForkJoinTask.java:593)
	at java.util.concurrent.ForkJoinTask.reportException(ForkJoinTask.java:677)
	at java.util.concurrent.ForkJoinTask.join(ForkJoinTask.java:720)
	at com.android.ide.common.internal.WaitableExecutor.waitForTasksWithQuickFail(WaitableExecutor.java:146)
	at com.android.build.gradle.internal.transforms.DesugarIncrementalTransformHelper.getInitalGraphData(DesugarIncrementalTransformHelper.java:162)
	at com.android.build.gradle.internal.transforms.DesugarIncrementalTransformHelper.makeDesugaringGraph(DesugarIncrementalTransformHelper.java:130)
	at com.google.common.base.Suppliers$NonSerializableMemoizingSupplier.get(Suppliers.java:160)
	at com.android.build.gradle.internal.transforms.DesugarIncrementalTransformHelper.getDependenciesPaths(DesugarIncrementalTransformHelper.java:231)
	at com.android.build.gradle.internal.transforms.DexArchiveBuilderTransform.getD8DesugaringCacheInfo(DexArchiveBuilderTransform.java:461)
	at com.android.build.gradle.internal.transforms.DexArchiveBuilderTransform.transform(DexArchiveBuilderTransform.java:375)
	... 51 more
Caused by: java.lang.RuntimeException
	at org.objectweb.asm.ClassVisitor.visitModule(ClassVisitor.java:148)
	at org.objectweb.asm.ClassReader.readModule(ClassReader.java:731)
	at org.objectweb.asm.ClassReader.accept(ClassReader.java:632)
	at org.objectweb.asm.ClassReader.accept(ClassReader.java:500)
	at com.android.builder.desugaring.DesugaringClassAnalyzer.analyze(DesugaringClassAnalyzer.java:144)
	at com.android.builder.desugaring.DesugaringClassAnalyzer.analyzeJar(DesugaringClassAnalyzer.java:92)
	at com.android.builder.desugaring.DesugaringClassAnalyzer.analyze(DesugaringClassAnalyzer.java:63)
	at com.android.build.gradle.internal.transforms.DesugarIncrementalTransformHelper.lambda$getInitalGraphData$4(DesugarIncrementalTransformHelper.java:150)
	at java.util.concurrent.ForkJoinTask$AdaptedCallable.exec(ForkJoinTask.java:1424)
	at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:289)
	at java.util.concurrent.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1056)
	at java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1692)
	at java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:157)

If I remove it, everything runs fine.
Thanks 👍

Hi,
Same problem here...
Thanks,

"with the new gradle 3.2.0"
Latest Gradle version is 4.10.2. Maybe your are refering to the Android gradle plugin?

Yes, that's it. Android gradle plugin is now 3.2.0, with Gradle 4.6.
https://developer.android.com/studio/releases/gradle-plugin
The problem came with the gradle plugnin 3.2.0, version before is OK.

I just discovered this was the issue after lots of frustrating guesswork on what was causing problems!!
Key takeaways:

This issue is present on all versions of Lombok starting with 1.16.22.
The failure with the Android Gradle Plugin is caused by a change in the default settings in 3.2.0.  If you look at the "Behavior Changes" list for 3.2.0 at the link @castrogne posted, you will see:  "Desugaring with D8 is now enabled by default." You can actually get the same issue to occur on Android Gradle Plugin version 3.1.0 if you go into your gradle.properties and enter the property: android.enableD8.desugaring=true.

The current proper solution (recommended): downgrade to Lombok 1.16.18. It works flawlessly.
The hacky gross solution (not recommended): If you really don't want to downgrade Lombok for whatever reason, you can keep your Android Gradle Plugin at version 3.2.0 and put this in your gradle.properties: android.enableD8.desugaring=false. This is not recommended, as even Google will warn you that setting this to false is experimental and unsupported.
I hope this helps any poor bastard like me who did not get a detailed build error output...the failure was extremely vague and did not make any mention of Lombok being the root of the issue. I had to manually go through each commit in my history to figure out where things broke. Come to think of it, my Instant Run in Android Studio was being wonky after I updated Lombok back then (though it wasn't causing a full on build failure like it was after the D8 desugaring got enabled).

Currently facing the same problem and recognized only with Java 8 enabled the problem occurs.
Removing the Java 8 compileOptions "fixes" the problem for me.
    compileOptions {         sourceCompatibility JavaVersion.VERSION_1_8         targetCompatibility JavaVersion.VERSION_1_8     }

Thanks, i'll have a try next monday, to downgrade lombok to 1.16.18.
But do you think next version of gradle will still be not compatible with gradle plugin for ever? We will be stuck to that version...

@Boehrsi Yes, the reason for that is because desugaring is the process of "back porting" Java 8 code to allow it to work more fluently with other libraries/utilities. If you did not use any Java 8 language features in your app to begin with, then then there would be no desugaring necessary.

@castrogne I think you meant to write "do you think the next versions of the Android Gradle Plugin will not be compatible with the latest Lombok versions forever" - and to answer that, I think yes, this behavior will remain an issue for the foreseeable future.
I don't know for sure, but my guess is that all versions of Lombok greater than 1.16.18 must be using some Java 8 language features that are not supported as described at the documentation here.
As you can see, it says

Android Studio provides built-in support for using certain Java 8 language features and third-party libraries that use them.
...
Android Studio does not support all Java 8 language features, but more are being added in future releases of the IDE.

It's possible that new versions of Lombok are using unsupported features and thus failing to compile properly.

@samarthd Yes you've well understood what i wanted to say. So we're stuck with lombok 1.16.18...  You was realy clear, thanks for your explanations.

Is there some minimal example somewhere? Then one could try to track the problem down to a specific commit. That could help finding a workaround.
However, it could still turn out that this simply cannot be fixed in lombok, but only by the Android tool chain.

Well, it worked! Thanks!
The 2 solutions you spoke about :
1- The current proper solution (recommended):  lombok V1.16.18 :
When I changed lombok version, the @AllArgConstructor didn't worked anymore. And for any reason, I couldn't either use @RequiredArgsConstructor(suppressConstructorProperties = true) . The reason was method suppressConstructorProperties not found... After that problem, I also had "error: cannot find symbol class Generated"... So to solve all that, I had to do :

lombok version to <IP_ADDRESS>
add a "lombok.config" file in project root, with the line "lombok.anyConstructor.suppressConstructorProperties = true"
add in my build.gradle
"compileOnly 'javax.annotation:jsr250-api:1.0'"

2- The hacky gross solution (not recommended), use gradle.properties
Let all versions up to date (my lombok version was 1.18.2, gradle 4.6, gradle plugin 3.2.0) and add the following line to your gradle.properties :
android.enableD8.desugaring=false
When syncing, you get the wargning "The option setting 'android.enableD8.desugaring=false' is experimental and unsupported. The current default is 'true'". But anyway, all build OK after that.
Finaly,
I don't know the future of that "desugaring false" option. But for now, it seems to have no impact for me... I think I will stay in that not recommanded way, and keep all my libs in up to date version. I'll just keep trace to that point in case of future change!
Thanks all!
Castrogne

I think sticking to an old Lombok version should not be the solution.
After a bit of research, it looks to me that desugaring works with Lombok, but only the new integrated desugaring does not. The option android.enableD8.desugaring=false does not switch desugaring off, it just execute it as a separate step. So it more and more looks to me like a problem of the android tool chain.

OK, I think too and that's why i just use desugaring=false for now, and i'll try to remove it for next versions.
Thanks,

Hi guys,
I'm currently testing the solution with "desugaring=false". I could only test compile last sunday, not running. And the fact is that if I do some "clean" then "run" (without build before), the error is still there... If i do some "clean", then "build", then "run", it works.
So I agree, seems to be Android Studio Build sequence that causes the trouble... I keep working like that for now, and let you know if I have more troubles.
Regards,

Lombok does not use java8 features.

I've updated https://issuetracker.google.com/117374690 with information why this is happening, but pasting here as well for visibility.
This is indeed an issue with the Android Gradle plugin, and it has been fixed in 3.3.0-alpha01, as part of fixing the https://issuetracker.google.com/74428304. Soon, first 3.3 beta should be released, so if possible, please update to that version.
In more details, this issue occurs because Opcodes.ASM5 is used to initialize the ClassVisitor used to read module-info.class, which exists in e.g. Lombok 1.18.2. This results in RuntimeException, as Opcodes.ASM6 should be used instead. It happens both with android.enableD8.desugaring=true|false. To reproduce, run a clean build, add a print statement to the method body, and try to build again.

Yep, that explains why 1.16.20 was the first to fail: a9c1d3d

Will be fixed in the Android Gradle Plugin 3.3.0.

this is closed.Has it be fixed? i test it with latest 3.3.0 RC2 and Lombok 1.18.4, still failed

@softboy99 As stated above, this has been or will be fixed elsewhere. The Android/Gradle guys claim, it has been fixed, so you may want to report back to them.


Fixed: show correct song in Hooked experiments

Close #1405.

You might want to (also) merge this to main instead of develop as this currently does not work on production


Bug Report:

uh so i typed lime test windows and this random message idrk anything abt coding so if someone could helpw ith this LOL

fixed


[newsmake] Move to a different command parser.

Issue Description

I would like to see if I could move to a different command parer.

Done.

Done.


Raspberry Pi 4 Debian GNU/Linux 11 Fails to Install With no Error

Environmental Info:
K3s Version: latest - fails on install

Node(s) CPU architecture, OS, and Version:
Raspberry pi 4 - Linux raspberrypi-worker1 6.1.21-v8+ #1642 SMP PREEMPT Mon Apr  3 17:24:16 BST 2023 aarch64 GNU/Linux (bullseye)
Master node (install working) -
Raspberry pi 3 - Linux raspberrypi-master 6.1.21-v8+ #1642 SMP PREEMPT Mon Apr  3 17:24:16 BST 2023 aarch64 GNU/Linux (bullseye)

Cluster Configuration:
1 master, 1 worker

Describe the bug:
From the same network, running curl -sfL https://get.k3s.io | sh -  works fine on the master node (rpi3), but on the worker node it does nothing::
[INFO]  Finding release for channel stable
curl: (28) Failed to connect to github.com port 443: Connection timed out
[INFO]  Using v1.27.7+k3s1 as release
[INFO]  Downloading hash https://github.com/k3s-io/k3s/releases/download/v1.27.7+k3s1/sha256sum-arm64.txt
pi@raspberrypi-worker1:~ $

Steps To Reproduce:
From a raspberry pi 4 running bullseye, attempt to run the k3s install command curl -sfL https://get.k3s.io | sh -
Expected behavior:
The expected behavior would be for the curl to download the proper files and start the service like it does on the pi3

Actual behavior:
The system hangs for a long time, then ends with no error message or response

Additional context / logs:
I did attempt to curl and install other programs on this pi and they installed fine, leading me to think this is an issue with k3s specifically

curl: (28) Failed to connect to github.com port 443: Connection timed out

I'm not sure what you mean by "with no error", that's your error right there. Make sure you can use curl or wget to download content from GitHub.

As I already mentioned in the additional context, I can curl out to other github repos fine. I used curl -fsSL https://github.com/rbenv/rbenv-installer/raw/main/bin/rbenv-installer | bash as a test earlier, and that ones still works now.
The command you provided results in no message, just the verbose content ending with * Connection #0 to host github.com left intact

It sounds like the connectivity on that node is flakey then - I'm not sure what else would cause curl to work when you run it manually, but not when run from the install script.
You can run curl -sfL https://get.k3s.io | sh -x - if you want to see what curl commands it's running and try to figure out why it is sometimes not working.