dart: not found (line number 8 in one of distributor's file)    main.dart  snapshot not found

You wrote a comment after line 8, but i don't understand it. Should i manually copy all dart sdk into your folder? Could you help with your installation manual, is it complete manual?
I installed Studio 64 on Win and Ubuntu, wrote more than 7k lines of dart code. Build my proj. for Win, Android, Mac and Linux.
But ... now i don't know what should i do with this error
Could you send .bashrc and folder from your computer? Please, could you send all the folder from you computer? Or give please non-misleading answer?

It cannot run from your file !!!
But can run from command from your file!!!

release

This is not an issue with flutter_distributor but an issue with the PATH setup on your local machine.
Please refer to a guide on how to properly set up your PATH.
For working with Flutter, the directory containing the flutter executable needs to be in your $PATH. For working with global flutter libraries such as flutter_distributor, the global pub directory needs to be in your $PATH too.


wrong taged v1.7.0

seems that commit b9fab04adbfd92783206a08364c8fea077f1ed39 has wrongly tagged as v1.7.0
the commit is few days ago....
I can't tell if there was older v1.7.0 that was removed due to this

Seemed that that fixed. closing


Add tts function and tests for it. - 2

[Auto generated]
Number: [#2]

pyhelper-utils(fyutn)[PR 2]: Closing issue for PR: Add tts function and tests for it..
PR was closed.


Test improvements; add server.CloseConnection method

A small part of #37. On @glynternet 's suggestion, I'm turning that big PR into a series of smaller PRs that are easier to review and merge.

See https://github.com/hypebeast/go-osc/pull/39/commits/52238bdd594cf3e2a6ef1bd3eaf2b26a16b3ae06 for a summary of the test improvements.

Pretty much LGTM.
Just a couple of simplifications.

Also, btw, disclaimer, I have absolutely not control when it comes to this repository.
I'm just trying to lift a little support/maintenance burden.

Thanks for your feedback and for helping to move things along more smoothly! I've changed a few things based on your feedback and fixed the CI failure, which appears to be from an interesting recent addition to go vet on the master branch version of Go.


Windows Batch File: Problems with directory with white spaces

When OtrosLogViewer is zipped to a directory with white spaces, starting the log viewer fails.
Line 54 in batch file has to be changed to
start "OtrosLogViewer" /B %LOCAL_JAVA% %LOG_PROPERTIES% %MEMORY%  -DsingleInstance.startPort= -DOLV_HOME="%OLV_HOME%" -DCURRENT_DIR="%CURRENT_DIR%" -jar "%OLV_HOME%"\lib\OtrosStarter.jar %* 1>%OUT_FILE% 2>%ERR_FILE%

Cool :) Worked like charm, after implementing the above fix... kindly make the change in main source,

Bug is resolved with 0097b9eeabfeca0f5131aa2f74012787150086f4


Restrict HotRocketsEmissivePatch to 0.90

This mod is actually hard to find info about, but the curseforge info on it says it's for 0.90, and since there's no mention of it anywhere else I'm confident saying we can lock it to that version.
Closes #761

Seems @Felger was the one who sent in the PR to bump it to ksp_version_min rather than ksp_version in #569 so I guess we might be able to get some clarity from him? :)

Currently it just throws an error if you're on KSP 1.0.4 and tick the box to install it, so maybe merge this now and if there's a reason to make it available for 1.0.X then we can fix the metadata so that it doesn't cause issues?

Hmmm, I don't recall that, but I did do some testing with hotrockets and its associated packs prior to deciding against a hotrockets expansion and just repurposing my work on RealPlume into its own standalone mod.  That's probably when I made the change.  If it doesn't work in 1.0.x, then yeah, bump it down to 0.90.


Imports are sorted in wrong order on save

Using prettier --write "**/*.{ts,tsx,json}" works fine and all imports are sorted properly, but on save a different order is applied.

Seems to be an issue with the project


kitties tutorial: fix sp_io import

importing sp_io::hashing::blake2_128 needs to happend inside frame_support.
all the template files were importing outside, which generates
error[E0433]: failed to resolve: use of undeclared crate or module `sp_io`
  --> pallets/kitties/src/lib.rs:12:9
   |
12 |     use sp_io::hashing::blake2_128;
   |         ^^^^^ use of undeclared crate or module `sp_io`

@bernardoaraujor - can this be propagated to main-md? @sacha-l please review :)

Thanks for looking into this. sp_io is not a crate in frame_support - I may be missing something but this wouldn't compile as is.
The fix here is to tell users that they need to go and change the Cargo.toml file to specify that sp_io will be required in the pallet's [dependencies] (in pallets/pallet/Cargo.toml for example):
[dependencies]
codec = { package = "parity-scale-codec", version = "3.0.0", default-features = false, features = [
	"derive",
] }
scale-info = { version = "2.0.1", default-features = false, features = ["derive"] }
frame-support = { default-features = false, version = "4.0.0-dev", git = "https://github.com/paritytech/substrate.git", branch = "polkadot-v0.9.23"}
frame-system = { default-features = false, version = "4.0.0-dev", git = "https://github.com/paritytech/substrate.git", branch = "polkadot-v0.9.23" }
frame-benchmarking = { default-features = false, version = "4.0.0-dev", git = "https://github.com/paritytech/substrate.git", branch = "polkadot-v0.9.23", optional = true }
sp-io = { default-features = false, version = "6.0.0", git = "https://github.com/paritytech/substrate.git", branch = "polkadot-v0.9.23" }
sp-runtime = { default-features = false, version = "6.0.0", git = "https://github.com/paritytech/substrate.git", branch = "polkadot-v0.9.23" }
pallet-randomness-collective-flip = { default-features = false, version = "4.0.0-dev", git = 'https://github.com/paritytech/substrate.git', branch = "polkadot-v0.9.23" }
pallet-balances = { default-features = false, version = "4.0.0-dev", git = 'https://github.com/paritytech/substrate.git', branch = "polkadot-v0.9.23" }

A node template out of the box usually has sp_io in [dev-dependencies] so all users need to do is move it out of there and into [dependencies]. Step 2 of this section stipulates this. Perhaps it's not clear enough and we can be more explicit about "why and what" this is about.

indeed, my PR is going in a wrong direction. I was actually just missing the step 2.
doing these changes does get the code to compile, most likely because sp_io is re-exported by frame_support.
regardless, that's not the proper way to do it.
I'll just send another PR clarifying [dependencies] vs [dev-dependencies].
sorry for the noise.

@NukeManDan @sacha-l is kitties not included in main-md?
I can't seem to find it.


Allow private and public Amazon ECR tools to be registered

For #4331. This is only the webservice PR for the ticket. Will also have a PR for the UI once this is merged.
This allows private and public Amazon ECR tools to be manually registered. Harvesting checksums for Amazon ECR tools is split out to another ticket #4409.
Amazon ECR is the only registry that we have that is not a private only registry, but has custom docker paths for its private repositories. I changed the descriptions of these fields in the Registry class to reflect this idea that having a custom docker path does not necessarily mean that it's a private only registry.
Changed how we were splitting the paths because Amazon ECR (and GitHub Container Registry) allows repository names with slashes, thus the indices for the path components are not all necessarily deterministic anymore.
The existence of slashes in repository names also made it possible for tools to have the same tool paths without necessarily have the same repository and tool name, so had to do an additional check in the DB when looking for duplicate tool paths.

Example of two tools with the same tool path public.ecr.aws/x5g7o3i3/appropriate/curl:

Existing tool has registry = public.ecr.aws, namespace = x5g7o3i3, name = appropriate/curl, toolname = NULL
New tool has registry = public.ecr.aws, namespace = x5g7o3i3, name = appropriate, toolname = curl

I added a lot of tests because I was worried my changes to splitting the path components might have affected searching for workflow paths. Might add some more tests if I think of any edge cases.

Did you happen to come across a reason why AWS decided to allow slashes in repository names? It seems unwise at first glance.

They wanted to allow people to use namespaces to group similar repositories. From this doc:

Repository names can support namespaces, which you can use to group similar repositories. For example, if there are several teams using the same registry, Team A can use the team-a namespace, and Team B can use the team-b namespace. By doing this, each team has their own image called web-app with each image prefaced with the team namespace. This configuration allows these images on each team to be used simultaneously without interference. Team A's image is team-a/web-app, and Team B's image is team-b/web-app.

I was curious so I tested it to see how many slashes they allow and I was able to create public.ecr.aws/n3r3k9w6/test/test/test/test/test/test ... I didn't test any further so I don't know what the actual max is. Realistically, people probably aren't creating repos with this many slashes

They wanted to allow people to use namespaces to group similar repositories. From this doc:

Hmmm. Thing is, it was already <registry>/<namespace>/<repo>, this just gives them  <registry>/<namespace:<optional nested namespaces>>/<repo> Kinda wish they used a different character, but alas.


docs: updates for new react-query course

Change removes convert kit for email capture and migrates it to Bytes. Copy updates to promote the new React Query Course are included.

closing as of https://github.com/tannerlinsley/react-query/pull/3414#issuecomment-1073122432


Configure error policy for disks on IO errors

What this PR does / why we need it:
This PR enables users to change the behavior of the VM when it encounters an IO error. Currently, the default and only behavior is to pause the VM.
Other possible options are report, ignore, enospace (see libvirt documentation).
Example:
    spec:
      domain:
        devices:
          disks:
          - disk:
              bus: virtio
            name: containerdisk
            errorPolicy: "report"
          - lun:
              bus: scsi
            name: scsi-disk
            errorPolicy: "report"

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Release note:

Add field errorPolicy for disks

I still need to fix the unit test, I changed where the error_policy is set and now it is missing for the test that don't call the function Convert_v1_VirtualMachineInstance_To_api_Domain

/unlgtm
Missed the mistake in the functional tests
13:13:50: tests/storage/storage.go:215:57: undefined: v1.ErrorPolicyReport

/lgtm cancel
Missed the mistake in the functional tests
13:13:50: tests/storage/storage.go:215:57: undefined: v1.ErrorPolicyReport

/retest-required


Monkey patch of glob.glob breaks root_dir kwarg

MWE:
Python 3.10.12 (main, Nov 20 2023, 15:14:05) [GCC 11.4.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import glob
>>> glob.glob("*steam*", root_dir="/tmp/")
['steam_chrome_shmem_uid1000_spid18613', 'steamHMDDCa', 'steam']
>>> import sh
>>> sh.__version__
'2.0.6'
>>> glob.glob("*steam*", root_dir="/tmp/")
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
TypeError: glob() got an unexpected keyword argument 'root_dir'
>>>

From what I can tell looking at the source, the library simply forwards all kwargs but I don't know enough to trace it.
Encountered in python 3.10.5 and 3.10.12.

The "you seem to forward kwargs" seems to be talking about develop which I saw here on github. When I edit the file locally, it doesn't do that. So maybe this is already fixed in develop but not yet released.

Yep fixed in 2e60b9032e12a105edaefba58059990f5d9e18df thanks to @Pistahh please release a new version. 😅

Dupe of #708 I guess.

Thanks for bringing this to my attention. Version 2.0.7 is released with the glob fix


Add DoubleNegativeExpression rule

Fixes #7035

Messages

:book:
Thanks for adding a new rule to detekt :heart:

:white_check_mark:
We detekted that you added tests, to your rule, that's awesome!

:white_check_mark:

We detekted that you updated the default-detekt-config.yml file, that's awesome!

  Generated by :no_entry_sign: dangerJS against 65b7e46a898c3fa1cf981aa9df568ab82854e2af


Validate dependencies licenses

Closes #449
This PR adds Makefile tasks to validate go-mod and npm dependency licenses to ensure they are compatible with the project's license (Apache-2.0).
I used go-licenses for validating go-mod dependencies, and diligent for validating npm dependencies.
Currently, I have only added the tasks to the Makefile, but I haven't added them to the GitHub Actions workflow file(s). Which workflow should I bind it to?
Ideally I would've liked to use diligent for both go-mod and npm dependencies, as it claims to be able to do so, but unfortunately I couldn't get it to work with go-mod.
Since I couldn't use a single tool for both go-mod and npm, I could've used a different tool for validating npm dependencies, however I couldn't find another one than diligent that allowed specifying the license type (eg. permissive). diligent also has the advantage of being a Go module.
Also, I had to update base-64 to 1.0.0 because it had the license information in the wrong place, which was causing diligent to detect it as license: none (see mathiasbynens/base64#24).
Also, note that there is an issue with diligent that prevents it from working with NPM scoped packages (eg. @primer/octicons-react). I have created an issue for this (senseyeio/diligent/issues/77). As a workaround, I have configured diligent to ignore scoped packages.
Note that go-licenses ignores Go modules without any license (or modules that it fails to detect a license for), whereas diligent will fail validation if it cannot find an NPM package or a license for an NPM package (which is why the workaround above to ignore scoped packages is required).
Example make check-licenses-go-mod output (this is considered passing despite all the warnings):
/home/daniel-shuy/.asdf/installs/golang/1.15.3/packages/bin/go-licenses check ./cmd/lakefs
E1019 00:27:15.115029   31731 library.go:108] Failed to find license for github.com/josharian/intern: no file/directory matching regexp "^(LICEN(S|C)E|COPYING|README|NOTICE)(\\..+)?$" found for<EMAIL_ADDRESS>E1019 00:27:20.032481   31731 library.go:108] Failed to find license for github.com/vbauerster/mpb/v5: no file/directory matching regexp "^(LICEN(S|C)E|COPYING|README|NOTICE)(\\..+)?$" found for<EMAIL_ADDRESS>E1019 00:27:20.048400   31731 library.go:108] Failed to find license for github.com/vbauerster/mpb/v5/cwriter: no file/directory matching regexp "^(LICEN(S|C)E|COPYING|README|NOTICE)(\\..+)?$" found for<EMAIL_ADDRESS>E1019 00:27:20.059830   31731 library.go:108] Failed to find license for github.com/vbauerster/mpb/v5/decor: no file/directory matching regexp "^(LICEN(S|C)E|COPYING|README|NOTICE)(\\..+)?$" found for<EMAIL_ADDRESS>E1019 00:27:20.078421   31731 library.go:108] Failed to find license for github.com/vbauerster/mpb/v5/internal: no file/directory matching regexp "^(LICEN(S|C)E|COPYING|README|NOTICE)(\\..+)?$" found for<EMAIL_ADDRESS>E1019 00:27:20.686697   31731 library.go:108] Failed to find license for github.com/cznic/mathutil: no file/directory matching regexp "^(LICEN(S|C)E|COPYING|README|NOTICE)(\\..+)?$" found for<EMAIL_ADDRESS>/home/daniel-shuy/.asdf/installs/golang/1.15.3/packages/bin/go-licenses check ./cmd/lakectl
E1019 00:27:33.077803   32116 library.go:108] Failed to find license for github.com/josharian/intern: no file/directory matching regexp "^(LICEN(S|C)E|COPYING|README|NOTICE)(\\..+)?$" found for<EMAIL_ADDRESS>E1019 00:27:40.884138   32116 library.go:108] Failed to find license for github.com/vbauerster/mpb/v5: no file/directory matching regexp "^(LICEN(S|C)E|COPYING|README|NOTICE)(\\..+)?$" found for<EMAIL_ADDRESS>E1019 00:27:40.898762   32116 library.go:108] Failed to find license for github.com/vbauerster/mpb/v5/cwriter: no file/directory matching regexp "^(LICEN(S|C)E|COPYING|README|NOTICE)(\\..+)?$" found for<EMAIL_ADDRESS>E1019 00:27:40.910413   32116 library.go:108] Failed to find license for github.com/vbauerster/mpb/v5/decor: no file/directory matching regexp "^(LICEN(S|C)E|COPYING|README|NOTICE)(\\..+)?$" found for<EMAIL_ADDRESS>E1019 00:27:40.925479   32116 library.go:108] Failed to find license for github.com/vbauerster/mpb/v5/internal: no file/directory matching regexp "^(LICEN(S|C)E|COPYING|README|NOTICE)(\\..+)?$" found for<EMAIL_ADDRESS>E1019 00:27:41.558124   32116 library.go:108] Failed to find license for github.com/cznic/mathutil: no file/directory matching regexp "^(LICEN(S|C)E|COPYING|README|NOTICE)(\\..+)?$" found for<EMAIL_ADDRESS>
Example check-licenses-npm output:
# The -i arg is a workaround to ignore NPM scoped packages until https://github.com/senseyeio/diligent/issues/77 is fixed
/home/daniel-shuy/.asdf/installs/golang/1.15.3/packages/bin/diligent check -w permissive -i ^@[^/]+?/[^/]+ webui
acorn                      MIT License
base-64                    MIT License
bootstrap                  MIT License
bootswatch                 MIT License
http-proxy-middleware      MIT License
moment                     MIT License
react                      MIT License
react-bootstrap            MIT License
react-bootstrap-typeahead  MIT License
react-dom                  MIT License
react-redux                MIT License
react-router-dom           MIT License
react-scripts              MIT License
redux                      MIT License
redux-thunk                MIT License

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Codecov Report

Merging #836 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #836   +/-   ##
=======================================
  Coverage   42.89%   42.89%
=======================================
  Files         135      135
  Lines       10574    10574
=======================================
  Hits         4536     4536
  Misses       5448     5448
  Partials      590      590

Impacted Files
Coverage Δ

catalog/cataloger_commit.go
78.78% <0.00%> (-3.04%)
:arrow_down:

catalog/cataloger_create_repository.go
65.38% <0.00%> (ø)

catalog/cataloger_create_branch.go
88.67% <0.00%> (+3.77%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d56db9e...de80b2a. Read the comment docs.

Thanks!


Adding SE-0095 version 2 proposal

@lattner @DougGregor

Thanks for the quick turnaround!

@lattner Just wanted to check if this proposal still needs to be scheduled. It would be nice to have it in for Swift 3.


ch: raise coverage score

What does this PR do?

Raise coverage score
test untested functions and codes

Description of Task to be completed?

Raise coverage score

How should this be manually tested?
Any background context you want to provide?
Screenshots (if appropriate)
Questions:

LGTM


"GetCompleteTodos" Method is missing.

On Update the code in Program.cs to use this DTO model
 GetCompleteTodos  Method is missing

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: ab408035-6313-a183-9940-32de00e0e977
Version Independent ID: ab408035-6313-a183-9940-32de00e0e977
Content: Tutorial: Create a minimal web API with ASP.NET Core
Content Source: aspnetcore/tutorials/min-web-api.md
Product: aspnet-core
Technology: aspnetcore-tutorials
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

That's left to the reader.


Discrepancy in lib/puppet_x/elastic/hash.rb library file between kibana and elasticsearch modules

Bug Report

Module version: 5.2.0
Puppet version: 3.8.7
OS and version: Ubuntu 14.04.5 LTS
elasticsearch (5.4.3) and kibana (5.2.0) modules present

Bug description
While relatively minor (a bit annoying for us), a discrepancy has been noted in the lib/puppet_x/elastic/hash.rb content between the kibana and elasticsearch Puppet modules.  Depending on which Puppet environment is used, one or the other is used to update the agent.  The issue is being opened here since a rubocop:disable line is missing in the kibana library file.
Expected behavior:
No changes between Puppet agent runs using different environments referencing with same code
Observed behavior:
# rubocop:disable Metrics/AbcSize line is added/removed, depending on which module is considered first/last.
File differences:
# diff modules/vendor/elasticsearch/lib/puppet_x/elastic/hash.rb modules/vendor/kibana/lib/puppet_x/elastic/hash.rb
10d9
<       # rubocop:disable Metrics/AbcSize

Example:

Environment abc

# puppet agent -t --environment env1
Info: Retrieving pluginfacts
Info: Retrieving plugin
Notice: /File[/var/lib/puppet/lib/puppet_x/elastic/hash.rb]/content:
--- /var/lib/puppet/lib/puppet_x/elastic/hash.rb        2018-03-09 10:02:56.107748541 +0000
+++ /tmp/puppet-file20180309-30590-vg0syb       2018-03-09 10:05:48.260058045 +0000
@@ -7,7 +7,6 @@
       # Upon extension, modify the hash appropriately to render
       # sorted yaml dependent upon whichever way is supported for
       # this version of Puppet/Ruby's yaml implementation.
-      # rubocop:disable Metrics/AbcSize
       # rubocop:disable Metrics/PerceivedComplexity
       def self.extended(base)
         if RUBY_VERSION >= '1.9'

Notice: /File[/var/lib/puppet/lib/puppet_x/elastic/hash.rb]/content: content changed '{md5}5482a43a74b80467b5078cab48aa3cf7' to '{md5}10dc543476cf0efdacae56694403f705'
Info: Loading facts
Info: Caching catalog for adm-dev-test01.local
Info: Applying configuration version '1520589951'
Notice: Finished catalog run in 4.64 seconds

Environment xyz

# puppet agent -t --environment env2
Info: Retrieving pluginfacts
Notice: /File[/var/lib/puppet/facts.d]/mode: mode changed '0755' to '0775'
Info: Retrieving plugin
Notice: /File[/var/lib/puppet/lib/puppet_x/elastic/hash.rb]/content:
--- /var/lib/puppet/lib/puppet_x/elastic/hash.rb        2018-03-09 10:05:48.416069199 +0000
+++ /tmp/puppet-file20180309-31219-1y9m6eg      2018-03-09 10:10:59.882337244 +0000
@@ -7,6 +7,7 @@
       # Upon extension, modify the hash appropriately to render
       # sorted yaml dependent upon whichever way is supported for
       # this version of Puppet/Ruby's yaml implementation.
+      # rubocop:disable Metrics/AbcSize
       # rubocop:disable Metrics/PerceivedComplexity
       def self.extended(base)
         if RUBY_VERSION >= '1.9'

Notice: /File[/var/lib/puppet/lib/puppet_x/elastic/hash.rb]/content: content changed '{md5}10dc543476cf0efdacae56694403f705' to '{md5}5482a43a74b80467b5078cab48aa3cf7'
Info: Loading facts
Info: Caching catalog for adm-dev-test01.local
Info: Applying configuration version '1520590263'
Notice: Finished catalog run in 5.33 seconds

Thanks for the report @asmajlovic, this definitely shouldn't be happening. I'm refactoring much of the test/linting setup for the Elasticsearch and Kibana modules to ensure we syntax check against Ruby 1.9 syntax for elastic/puppet-elasticsearch#922, so I'm in the middle of working on these sorts of changes and should be able to resolve them.


#45 Fix different typos, add missing links, normalize header-size aso.

Typos:

(v) Add missing '.'

(v) Add missing ' ' before/after '->'

(v) Replace ' </kbd>' with '</kbd>' (no leading ' ')

(v) Add missing '', 11 to the XY '11'.

(v) Replace sentence "Then add the controller and the FXML and and the css files." with "Then add the controller, the FXML and the css files."

Attention to the link adresses (they are different in every sentence))

(v) Normalize Header size: Main-Header(Main-Menu)=h2, Sub-Header(Sub-Menu)=h3, Sub-Sub-Header(without Menu entry)=h4

Additional

(v) 'Note' have no 'alert alert-warning' box (install-javafx.html)
(v) Remove not needed 'anchor' tag. Normalize header-size to h4 (modular.html)

IDEs to 'Homepage' page.

Eclipse = https://www.eclipse.org/
NetBeans = https://netbeans.org/
IntelliJ = https://www.jetbrains.com/idea/

Tools like Maven, Gradle to 'Homepage'.

Gradle = https://gradle.org/
Maven = https://maven.apache.org/
Maven Central = https://search.maven.org/

No feedback - won't contribute - close request.


animal and plant view

What does this PR do?
Where should the reviewer start?
Related ticket link/s:
Before and After UI Screenshot (optional):

@achidaah Pa resolve lang conflicts thanks.


Unclosed Statement in {{ content_for_header }} causing errors with start and watch commands

Problem
When running slate-tools start or slate-tools watch, a large unformatted block of code appears at the top of the site above the rest of the page. In the console there is an error Uncaught SyntaxError: missing ) after argument list.
Replication steps

Run slate-tools start or slate-tools watch
Once files are uploaded you will see the error at the top of the screen
This does not appear to happen on slate-tools deploy

More Information
From what I can tell this issue is coming from the {{ content_for_header }} code in the theme.liquid file. Everything in here is being injected from Shopify and does not appear to be editable.

I am having the same issue. Currently, I have @shopify/slate-tools: 1.0.0-beta.15, going to update to beta.19 now add see if that helps.

Updating to beta.19 looks like it resolved the issue on my end. Thanks @jaredkc.

I was seeing this as well in 1.0.0-beta.15 and I found a temp solution here.
Add this code in<EMAIL_ADDRESS>within the bsConfig function
snippetOptions: {
        rule: {
            match: /<head[^>]*>/i,
            fn: function(snippet, match) {
                return match + snippet;
            }
        }
    }


Fix broken links caught by nightly htmltest run

This change is

Hi @jseldess, confirming that GitHub URLs are now exempt from the nightly checks: https://app.netlify.com/sites/cockroachdb-docs/deploys/60ca759c69e1d000da7d3f7f
115 errors in 3205 documents


pre-train with ELECTRA rather than BERT

Is the code used for pre-training the ESM2 model available?  Just for interest, I want to see if I can modify it so that the ELECTRA method is used for pre-training, rather than BERT.  (ELECTRA is faster and more efficient at learning)
https://arxiv.org/abs/2003.10555
https://github.com/Joseph-Vineland/ProteinELECTRA
Maybe if you have to pre-train more in the future, or if you are going to pre-train ESM2 again, you can use the ELECTRA pre-training method.

Thanks for the suggestion! We have definitely considered ELECTRA and other pre-training objectives in the past, but don't think we have actually trained any ELECTRA models yet.
We'll update this repo with any new versions of ESM, MLM objective or otherwise!

Thank you.  Just for curiousity, is the code used for pre-training the ESM2 model available?  I would like to have a look if possible.

We haven't open sourced it but it should be straightforward to do it using vanilla fairseq and the config information in our model checkpoints


fix(core): feature flag typing

The results I got from posthog.getFeatureFlags() were not matching the typing. The typing indicated that the return type should be { [key: string]: string | boolean }, but I only ever got string[].
So I checked what the API is actually returning:

And indeed the API was returning an array of strings. So I changed the type with this PR.
Also see this.

Hey Mo, did you try creating multivariate feature flags?

Sorry, I mean the main PostHog app, not this library

For the request you're sending in the main screenshot, can I see the request body as well please?
(feel free to hide the api key)

(hard for me to reproduce for RN because I don't have expo/ios setup with me right now. But, we use the same codebase for posthog-node, which works fine)

Huh weird, I get the right stuff when I curl the above^.
Question: Are you using your project API key or a personal API key for the token?

I see the problem - it has to do with your proxy which doesn't pass the v parameter on to posthog.
For you to test & confirm:

If you put app.posthog.com in place of REPLACE_ME, it should work.
If you put your domain proxy I think it doesn't work

I see. Then indeed the v=2 parameter isn't being forwarded.


propagate first empty file if all input files are empty

GitHub Issue: 153
Description
If all input files are empty pass the first empty file to the following stitching procedures:

Theoretically, one empty file does not require stitching but the following steps might include additional modifications, like adding attributes, history details etc
Passing file to normal stitching procedures ensures that the file is treated identically to normal scan

Local test steps
Performed requests with one empty granule using NO2 V03 collection in local Harmony environment.
Overview of integration done

Before the PR fix
After the PR fix

PR Acceptance Checklist

[ ] Unit tests added/updated and passing.
[x] Integration testing
[x] CHANGELOG.md updated
[ ] Documentation updated (if needed).

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 9.26%.  Consider uploading reports for the commit 09123a8 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           develop    #180      +/-   ##
==========================================
+ Coverage     9.21%   9.26%   +0.04%
==========================================
  Files           11      11
  Lines          640     637       -3
==========================================
  Hits            59      59
+ Misses         581     578       -3

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Allow function for Field validateOn

Would it be possible to allow the Field's validateOn to take a function, which is passed the fieldValue? May make sense to pass the modelValue as well for some other use case.
My reason for wanting this ability: I basically want error messages to appear on blur, but to disappear on change. Thus, my field currently looks like
<Field validateOn={ !valid && (touched || submitFailed) ? 'change' : 'blur' }>
...
</Field>

Since I'm depending on these values from the formReducer, I'm forced to pass in the form state through my own container. It would be nice to avoid having to have this extra container.

Yeah sure, I'll mark it as an enhancement.

I basically want error messages to appear on blur, but to disappear on change.

You can do this with the <Errors /> component like so:
<Errors model="..." show={{ focus: true, touched: true, submitFailed: true }} ... />

Cool, thanks for the tip.

Actually, yeah, because of the event sequencing logic, it's preferred to just have it validate on a certain event, such as "change" or "blur", and show the errors conditionally like I've demonstrated.


Syntax error in FluidDissipation.mo tests

Reported by dietmarw on 15 Apr 2010 15:27 UTC
Running MapleSim's MoParser on ModelicaTest gives a syntax error like:
syntax error on line 132 of ./ModelicaTest/FluidDissipation.mo: expected identifier but received `,`

on constructs like:
for i in 1:n loop
  (,,,Nu_1[i],) =
   Modelica.Fluid.Dissipation.HeatTransfer.Channel.kc_evenGapLaminar(
             m_flow_IN_con_1[i], m_flow_IN_var_1[i]);
end for;

Migrated-From: https://trac.modelica.org/Modelica/ticket/357

Comment by otter on 22 Jul 2010 16:47 UTC
According to my understanding, this is correct Modelica (since the functions have been introduced). In the Modelica 3.2 specification it is stated:
12.4.3 Output Formal Parameters of Functions
...
It is possible to omit left hand side component references and/or truncate the left hand side list in order to discard outputs from a function call
...
(ev , , vl) = eigen(A)
Probably, one should improve this description in the specification.
This is not a big issue: If tools cannot easily be fixed to support this feature, it is probably possible to rewrite the few cases in ModelicaTest by adding dummy arguments.

Modified by dietmarw on 22 Jul 2010 17:49 UTC

Comment by dietmarw on 22 Jul 2010 17:50 UTC
The ticket was not fixed as such but it was decided that it won't be fixed.


Open source bench test (Part 2)

What changed?
Open source bench test (Part 2). Also added Passed as default search attributes.
Plan:

[x] Basic runnable skeleton code
[x] Open source the rest of bench tests
[ ] CLI for configuring env, zone etc. for bench tests
[ ] README for running bench tests.

Why?
Open source bench test (Part 2)

How did you test it?
Tested locally

Potential risks
N/A

Coverage decreased (-0.03%) to 64.543% when pulling 0569e088c26655561c4db108bc30f5134633b15f on yycptt:open-source-bench into 4b548e27123a65be08e251747674e5332ace2307 on uber:master.


Added BatchedTicketRegistryCleaner which supports cleaning of a JpaTicketRegistry in batches to prevent OOM situations

http://jasig.275507.n4.nabble.com/JpaTicketRegistry-A-Sinking-Ship-td4256973.html

Closing PR for now.


Align Left FloatingActionsMenu

I want to align left FloatingActionsMenu and i've been added layout_alignParentLeft to this but still menus on right of screen.
please help me.
sorry for my english:)

solution:
fork repository and add it to your project dependency.
edit ultimate_recycler_view_layout.xml and custom_recycler_view_layout.xml files and replace layout_alignParentRith with layout_alignParentLeft

yep u got it. @ayhansalami


fix issue with prefix in nested orderable

changed following:
change only first prefix when multiple prefix are present in same name when orderable and blocks are nested.

Do the tests still pass? yes
For Python changes: no changes
For new features: No new feature

Fixes #7587

Hey @lb- , thanks for merging the pr. This was our first time contributing to this repo. We were also working on test. We will be looking forward to contribute more.
The name of @anirudhvs is Anirudh V S. Could you consider adding his name to contributors if it is possible to accommodate the change. Thank you once again.


Listen for a non-zero exit code from the go-search-replace process

Listens for a non-zero exit code and throws loudly if one is received.

This PR was started by: git wf pr

Thanks for taking a look @elazzabi. I'm missing an uncaught throw somewhere here and that's what's causing the test to fail.
I think if we wanted to handle different types of exits in the golang library we could.  I'm not sure if we can get more specific unless we do that.  We could check for different signals, like a SIGINT or other, but I'm not sure if we'll get huge value out of it as the process is spawned.

Thanks for taking a look @elazzabi. I'm missing an uncaught throw somewhere here and that's what's causing the test to fail.
I think if we wanted to handle different types of exits in the golang library we could.  I'm not sure if we can get more specific unless we do that.  We could check for different signals, like a SIGINT or other, but I'm not sure if we'll get huge value out of it as the process is spawned.

Ah @markowsiak yeah good call. Let's leave it as it is now 👍

Ah @markowsiak yeah good call. Let's leave it as it is now 👍

@markowsiak I see the bot has generated the appropriate changelog and tag, but it's still not showing in npm. Should we manually deploy it?

@markowsiak I see the bot has generated the appropriate changelog and tag, but it's still not showing in npm. Should we manually deploy it?

Yes I think we should.  I'm going to take a look at why that stopped working

Yes I think we should.  I'm going to take a look at why that stopped working


bug

Microsoft PowerToys version
0.80.1
Installation method
Microsoft Store
Running as admin
None
Area(s) with issue?
PowerToys Run
Steps to reproduce
2024-07-18.txt
✔ Expected Behavior
请给我一个回复
❌ Actual Behavior
黑屏
Other Software
No response

/dup https://github.com/microsoft/PowerToys/issues/31226


Resign - Set CFBundleVersionNumber

Resign has already an option to set the version number. The problem is that the CFBundleVersion and the CFBundleShortVersion are set to the same number. An enhancement would be the every version could be set independently.

Hi @iphil. I believe this functionality was implemented as part of https://github.com/fastlane/fastlane/pull/4362. 👍


Sage

Created project structure
Setup linting
Setup transpiling
Setup Dependency injection
Setup Continuous integration
Setup Logging
Setup configuration management

Kindly review project structure and setup for possible modifications.


Path as Subtitle in TreeMap

I do want to display the path in the Subtitle/title above the TreeMap depending on the depth.
Currently it only shows the level iam in.
I already tried to overwrite the default click method but i need to return "true" as i need the TreeMap to drill down and that overwrites my title.
I just found out that i could code my method into he libraqry but i dont like that.
Is there a possibility to get the option to not overwrite the title via default "onclick", or to make the subtitle showing the path like "L1/L2/L3".
Many Thanks

I'm wondering if there is a workaround for this. I'd like to implement a subtitle with drill down features like this as well.
Thanks!


Streamflow DA fixes: break network at gages and allow assimilation at waterbody outlets

This pull request proposes two improvements to streamflow DA. First, changes are made to properly construct reaches between gages. For streamflow DA, gage nodes should always be the terminal nodes in a reach. This way, the assimilated data can be routed downstream to the adjacent node. As describe in issue #528, the existing reach construction process failed to construct reaches around immediately adjacent gage nodes. Second, changes are made to allow data assimilation from gages co-located with waterbody outlet segments.
Additions

New splitting functions nhd_network.split_at_gages_waterbodies_and_junctions,  nhd_network.split_at_gages_and_junctions, that force breaks at gages,  waterbody inlets/outlets, & junctions and gages & junctions, respectively . These splitting functions are used by dfs_decomposition to identify where one reach ends and another begins.
Re-indexing the usgs_df and lastobs_df, such that link ids are replaced with lake ids for gages located at waterbody outlets. This re-indexing associated a gage and it's data with an waterbody reach.

Changes

The parameter break_network_at_gages is no longer necessary in the yaml configuration file. Instead, if the user turns on streamflow data assimilation (i.e. streamflow_nudging == True), then reaches are automatically broken at gage nodes.
Subnetwork reach creation that occurs in compute.py for by-subnetwork-jit and by-subnetwork-jit-clustered parallel options was not acknowledging gage break points. I have updated the code in compute.py to fix this.

Testing
I have isolated to small simulations to demonstrate both the problem and solution:

reach out privately for paths

The simulations launched by these configuration files are for small domains, 500 timesteps, with streamflow DA turned ON. Outputs are written to "chanobs" files, which only store routed flow results at gage nodes.
To understand the initial problem do the following:

Checkout out the current t-route master
Copy the yaml configuration files from my directory to a directory of your own.
Edit the 'chanobs_output_directory:` parameter in the configuration file so that the chanobs file is written to a destination in your file space.
Run the simulations (e.g. python -m nwm_routing -f kinnickinnic.yaml)
Use a Jupyter notebook to plot flow results at segment 12164326 in the Kinnickinnic domain, 21478146 in the Cypress Creek domain, and 9513994 in the Spruce Run domain. You should observe that data assimilation does NOT occur at these segments, even though they are gage nodes and data assimilation should happen.
Checkout the development branch I am PR-ing from, here. No need to recompile because all changes are in Python.
Delete the chanobs files created by the previous simulation (e.g. rm /my/directory/where/kinnickinnic).
Re-run the simulations.
Re-plot the results and you should see that DA is happening as expected.

Screenshots
Kinnickinnic domain, segment 12164326 before the proposed fix - no DA happening:

Kinnickinnic domain, segment 12164326 after the proposed fix - DA happening as expected:

Spruce Run domain, segment 9513994 before the proposed fix - no DA happening:

Spruce Run domain, segment 9513994 after the proposed fix - DA happening as expected:

Checklist

[x] PR has an informative and human-readable title
[x] Changes are limited to a single goal (no scope creep)
[x] Code can be automatically merged (no conflicts)
[x] Code follows project standards (link if applicable)
[x] Passes all existing automated tests
[x] Any change in functionality is tested
[x] New functions are documented (with a description, list of inputs, and expected output)
[x] Placeholder code is flagged / future todos are captured in comments
[x] Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
[x] Reviewers requested with the Reviewers tool :arrow_right:

Regional Testing
To see if the solutions proposed here are working at scale, I constructed a 28-hour streamflow DA simulation of the Ohio River basin. The basin contains 748 gages.
As part of the test, I printed out two pieces of data. First, I save simulated (hopefully assimilated) flows at gage nodes with a CHANOBS file. Second, I saved interpolated observations from the usgs_df object in a file that is structurally equivalent as the CHANOBS file, but contains gage observations and not simulations.
For each gage in the network I checked that each high-quality observation (i.e. QA/QC score of 100%) was indeed assimilated into the t-route simulation by comparing the two outputs. This test passed by showing that 0/748 gages reported high-quality observations that were not assimilated.


Is there any way to reduce the first jit compile time

Can we store the compile code or weights directly and load it later. That may solve the boring first jit compile.

Yes we can use the compilation cache, c.f. this Kaggle notebook: https://www.kaggle.com/code/sgandhi99/whisper-jax-tpu


#managementButton?

In demo/files/js/demoshop/demoshop.js there are several mentions of img#managementButton. This button appears nowhere else, let alone in the templates.
Is this file necessary at all?

The demoshop script takes care of the search box and image resizing / error handling. The mentioned button is obsolet.
With 09b6ad7 the demo templates have been cleaned up now.


Add support flash driver for STM32F7x SoC

This patch add support flash driver for STM32F7x SoC. So the boards of STM32F7x SoC can use the flash_stm32 interface. Test on stm32f769i_disco

Codecov Report

Merging #9758 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #9758   +/-   ##
=======================================
  Coverage   52.24%   52.24%
=======================================
  Files         212      212
  Lines       25950    25950
  Branches     5593     5593
=======================================
  Hits        13557    13557
  Misses      10159    10159
  Partials     2234     2234

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3298905...c627dfd. Read the comment docs.

I have also been working on flash support for STM32F7 during the week-end, and was about to submit it. My branch is available there: https://github.com/aurel32/zephyr/tree/stm32f7-flash . That way I know exactly what to look for, so I will review your changes.

Modify the code and test it time after time. It can run on the stm32f769i_disco board, now. The tested code path is samples / drivers / flash_shell.

recheck

My suggestion: For stm32f7x 1Mbytes devices, we can use a sector number map to the devices sector number. Example, use sector8 map to the devices sector12 (first sector on the bank2).

@jinyongiot , any update?

Closing as replaced by #12083


GUI broken?

I don't know if this is an issue on my side but since the interface changed I have parts of the GUI cut off by the window. As well as some text values being cut off weirdly. I am running python 3.8.10 on KDE neon 5.25. I tried to look in to the code but I didn't find anything looking out of place, also I am not familiar with tk enough to know. Any ideas what I could try to fix this? Changing the window size does nothing...

I'm not all that good in tkinter myself.
Can you try to add in interface/__init__.py the geometry such that it looks like:
# Make the window
self.root = Tk()
self.root.geometry("1570x770")
# Make the title that will appear in the top left
self.root.wm_title("Raspberry PI PICO PIO Emulation")

For me, that displays the whole window and it allows resizing.
That probably doesn't solve the misalignment in the frame with "Clock=0" on top. That frame is built in the file interface/_mid_frame.py. It calls various UI elements in interface/_interface_item.py. In that file, in the class "Interface_Item" a width parameter is set. I suspect that it goes wrong with the width somehow. You can try to set the widths in calls such as
super().__init__(frame, display_name, row, col, 40)
in class Var_List and  class Var_List_IRQ. Try changing the number 40.

I tried that on my own already but it doesn't help, even if I set a higher window size like 1800x800 the added space is just filled with white (same as when I try to resize). Changing values in  super().__init__(frame, display_name, row, col, 40) did do something so I will have to investigate that further and try to find optimal values for me. (But tbh viewing the FIFOs is more important to be atm, the small snippets shown for the names of the variables are currecntly sufficient for me to guess what it is). Below is what a higher window size looks like.

I'm not sure what the cause is. I'm using:
Linux Mint 20.3 Cinnamon
python 3.8.10
tkinter 8.6.10
Could there be an issue with the fonts that are used? I noticed that in  _mid_frame.py I use a specific font. Maybe just after self.root = Tk() you can set a default font by self.root.option_add("*Font", "aerial 10"). That doesn't help with the misalignment, but maybe it does help with the missing information.

Yeah this is very weird since I am using the exact same python and tk version, the for setting didn't do anything unfortunately. I guess I'll try to look in to it later and maybe submit a PR if I manage to get down to the origin of this.

no reactions in a year -> close


Grails 3.3.x upgrade

All tests converted to new Trait based tests
Wrappers for fields-plugin removed. They cause too much trouble

Merged into 2.1.0-SNAPSHOT


BlueskyRun load is called twice

When accessing an entry in the catalog, BlueskyRun._load() is called twice.

A minimal example to reproduce:
# generate_data.py
import tempfile
from suitcase.msgpack import Serializer
from bluesky import RunEngine
from bluesky.plans import count

RE = RunEngine()

directory = tempfile.TemporaryDirectory().name
with Serializer(directory) as serializer:
    RE(count([]), serializer)

from databroker._drivers.msgpack import BlueskyMsgpackCatalog
catalog = BlueskyMsgpackCatalog(f'{directory}/*.msgpack')

ipython -i generate_data.py

With prints added to BlueskyRun.__init__ and BlueskyRun._load.
In [1]: catalog[-1]
BlueskyRun.__init__
BlueskyRun._load
Out[1]: BlueskyRun.__init__
BlueskyRun._load

Run Catalog
  uid='4c3665e5-d63f-4728-9fd2-b741363a5951'
  exit_status='success'
  2020-01-14 06:39:35.295 -- 2020-01-14 06:39:35.297
  Streams:

It looks like _load is being called once per __init__ (good) but that __init__ is being called twice (bad).

I started to look at this in https://github.com/bluesky/databroker/pull/494 back in November. On that branch, we get the expected number of prints. But it may introduce different problems!
In [1]: catalog[-1]
BlueskyRun.__init__
BlueskyRun._load
Out[1]:
Run Catalog
  uid='e4c41729-8a74-46c1-abf0-a7a7d0b65e96'
  exit_status='success'
  2020-01-14 06:51:49.890 -- 2020-01-14 06:51:49.891
  Streams:


Hardsuit rebalance

About the PR
A ton of hardsuits (clown, Engi) were pretty unbalanced for their value, so I changed some values. (the deathsquad changes are just so that it makes sense, cause that beefy of a suit should have at least a tiny speed nerf). And for softsuits i made the NRSA suit better speed wise than the paramed suit because it is rarer and the station starts with paramed suits. No helmet changes. Fixes some issues from #25754
Why / Balance
Fix unbalances in speed compared to value, also change some values here and there. A lot of these changes are here for balance with how the game currently plays, because, for example, most engineers play with their hardsuits on almost all the time since their job calls for it, and they have an unneccesarily nerfed speed, making it feel sluggish to play, and imo Space Station shouldn't feel sluggish. Look for #25754 for more reasons why.
Technical details
Just value changes
Media

[ ] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

:cl: Hmeister

tweak: Certain hardsuits are now faster or slower and have stat changes, like the engineer hardsuit.
tweak: Certain softsuits are now slightly nerfed to be slower, namely the Clown hardsuit and Paramed hardsuit

deathsquad suit is designed to be OP

a fair amount of those don't make sense or seem bad, for example the elite hardsuit one

The PR could use justification for these changes and could use a comprehensive table of changed values, and overall values of the changed suits.

Oh boy let's see what this guy considers "balanced" Here's all stat changes so you don't have to sift through the files yourself
Engineering Hardsuit
Spationaut Hardsuit
Mining Hardsuit
Brigmedic Hardsuit (the role that was removed for being too strong or something)
Captain's Armored Spacesuit (the emergencies only suit just so captain isn't left without EVA)
Syndicate Elite Hardsuit (y'know, the mobility over protection suit with a specialization in heat/rad protection)

blunt resist from 40% to 55%
slash resist from 40% to 55%
piercing resist from 40% to 55%
heat resist from 80% to 60%

Syndicate Commander Hardsuit
Cybersun Juggernaut Suit
Wizard Hardsuit
Pirate Captain Hardsuit
Deathsquad Hardsuit (the suit with a comment on it that literally says "best armor in the game")
CBURN Exosuit
Clown Hardsuit
Prisonder Eva Suit
NTSRA Voidsuit
Paramedic Voidsuit

Il change some stats around then, thanks for making this

Hardsuits running out of power and requiring infrequent recharges could be one of those downsides.

I don't see how this could ever lead to emergent gameplay for hardsuits, especially for the likes of people like Nukies who nearly require them.
No one should be wearing space proofing the entire round (minus special cases, like nukies, ninja, etc), but I don't see them offering that many benefits to warrant a power system.

So for most things a huge buff? That's gonna be a nay from me.
Below is my POV on the topic:
Hardsuits are a specialized equipment. Use the right tool for the job.
You are generally not supposed to wear it the whole round.
If you are walking in a hardsuit the whole shift - the situation is either: a) the specific situation that calls for it has been going on the whole shift (i.e. armoring up against likely combat, or the station is full of holes), b) you are working in space the whole shift or part of your job is to anticipate and react to spacing, c) you are roleplaying a greedy/paranoid/doomsayer/etc. character d) purely powergaming reasons e) this one intentionally left blank because I surely forgotten about that one case
Point a) covers all antag suits, and the case of nukies declaring war. Point b) is the reason salvage, engineering and paramedics are given a lot of leeway when wearing hardsuits in a lot of situations that don't directly call for it. While c) and d) are self-explanatory.
On a final note I want to make it clear that I'm not against hardsuits being a way to make humans better humans™ (a.k.a. if you wear it you are straight-up better), but from gameplay POV this needs a downside. Hardsuits running out of power and requiring infrequent recharges could be one of those downsides. If that was ever implemented buffing hardsuit movespeed would totally have my approval. Until then - with the only downside being move speed penalty - the drawback should be considerable enough to offset the benefits.
tl;dr: IMO hardsuit balance should be such that people ought to not want to wear one unless the situation forces them to (think EVA - you'd only wear it when you have to).

Are you dolboeb my friend?
 At least try playing for real as nukies playing with such stats, Your skill issue is so high so you consider Power gaming as a real reason to change suits. Why you didnt think about giving a regular syndicate EVA suit(not nukies) a bullet protection?

No one should be wearing space proofing the entire round (minus special cases, like nukies, ninja, etc), but I don't see them offering that many benefits to warrant a power system.

After spacepen removal they're basically a necessity if you want to combat anyone properly (and competently) utilizing space (ninja, nukies, bloodred tot, space dragon, etc. funnily enough this is the majority of the antags we have)
Imo it would be a 10x better solution to make them utilize an additional mechanic (charge in this example) rather than keep them balanced entirely around slowdowns and resistances, blood-red/ninja/etc. suits could probably just not have a charge mechanic.

the ninja suit is quite literally the only suit in the game with a charge mechanic at the moment.

Not the kind of charge I imply, the ninja suit uses charge for abilities rather than functionality.
By "charge" I mean the hardsuit has to be recharged to stay "functional", so lights, sight, oxygen, move speed, etc. are all affected by charge.

the ninja suit is quite literally the only suit in the game with a charge mechanic at the moment.

Not the kind of charge I imply, the ninja suit uses charge for abilities rather than functionality. By "charge" I mean the hardsuit has to be recharged to stay "functional", so lights, sight, oxygen, move speed, etc. are all affected by charge.

The slowdown is not that bad in comparison to relying on charge.
You don't even need a hardsuit to give yourself oxygen.
Lights you can just use your PDA or some other flashlight
Hardsuits do not need to be that complex.
If anything they should have no slowdown in zero g, unless that already exists.

I would prefer my engi hardsuit (which should have engi abilities to begin with) being penalised for running out of charge as opposed to chronic 30% speed debuff
I think there was an issue opened up for hardsuits to have charges and abilities
PR should probably be split up as opposed to changing a whole bunch of suits as once

The slowdown is not that bad in comparison to relying on charge.

Yes, it absolutely is. Slowdowns are a permanent burden on you as soon as you get a hardsuit, especially now with the slowdown being applied on-carry as well as on-wear,
most crew hardsuits are a 30% or 40% move speed reduction which makes them completely useless in almost all combat scenarios to the degree where despite my earlier point
(hardsuits are required to combat a competent space-utilizing antag) you shouldn't use a hardsuit because it makes you almost, if not more, as vulnerable than being in space without a hardsuit unless you have an overwhelming advantage to couple with it.
Charge on the other hand, still achieves what slowdowns intend to do (prevent people from wearing hardsuits 24/7) while keeping them viable enough in combat to still be situational and good solution to the problem of space-utilizing opponents.
Combat viability may seem strange, the consensus on hardsuits is that they shouldn't be strong in combat unless it's a "combat" suit which are few and typically locked to antags (blood-red), but hardsuits really shouldn't be a weaker option than no armor at all, which it currently is because of the slowdowns, which as are as well-known, the most important variable in combat.

You don't even need a hardsuit to give yourself oxygen. Lights you can just use your PDA or some other flashlight

Provided de-buffs from lack of charge were given as examples to get my point across, a hardsuit should lose its utilities and most of its functionality if it's not charged.

If engineers need to repair a portion of the station for awhile, but have to stop because they need to recharge their hardsuit, it becomes a chore. Dealing with the slowdown is a lot less worse.

Not really, even long and excessive repairs (syndicate bomb hole repair) do not take very long and are more bottlenecked by materials than anything else, one engineer with several stacks of steel sheets can fix the hole in a couple of minutes provided they're competent.
So why am I saying this? I raise you this: where do engineers get materials typically?
In engineering, from the material stockpile, or they march to cargo and ask for materials there, both departments would have suit chargers as both departments (engi-atmos, cargo-salvage) get hardsuits and interact with space, so when you need to restock you can also recharge, it's not a chore because it's done in couple with restocking.

If anything they should have no slowdown in zero g, unless that already exists.

It would be appreciated, because right now (unless it got patched) a juggernaut suit in space without any damage is already moving so slowly that you mispredict and can't move at all.
Also, this discourages obnoxious space camping as K-Dynamic pointed out, which is a win in my book.

Yeah a lot of these values are questionable at best, and no reasoning for them.
Deathsquad hardsuit you are never coming across or obtaining unless it's an admeme round. They are meant to be OP and impossible to kill.
Elite nukie hardsuit should not be touched. It's specialized for heat resistance while sacrificing blunt damage categories for a reason.
Why is the brigmedic, CBURN, wizard, and pirate hardsuit getting buffed when they basically have no place in the gameplay loop.
Clown hardsuit buff, why..? I believe people wanted it nerfed, actually. Could be wrong
Just doesnt make sense. You should've probably asked around if people felt like hardsuits needed adjusting first instead of adding your own arbitrary changes.

Does anyone else agree with the PR in principle but feel it's got too many changes?
I should clarify; engi hardsuit move penalty should be reduced from 30% since it currently hampers any space work (most other hardsuits are not as slow). This is separate to the charging idea, which would be a novel way of balancing it but out of scope.

Also, this discourages obnoxious space camping as K-Dynamic pointed out, which is a win in my book.

The suit charging idea is just a way to balance hardsuits in general but not currently coded.

What I'm getting from this is that on carry slowdowns should be removed and zero gravity slowdown shouldn't exist, with or without jetpack.

It takes a hand slot. It really doesn't matter how long it takes to put on. You're still vulnerable to slipping or disarming, and still losing a hand slot.
You're not getting any hardsuit benefits unless you're wearing it so that logic doesn't make any sense.

It takes a hand slot. It really doesn't matter how long it takes to put on. You're still vulnerable to slipping or disarming, and still losing a hand slot.

As someone who used to carry hardsuits in my hand all the time, risk of it being disarmed or slipping with it was low enough that I was comfortable with it
However, the reason I felt compelled to do it to begin with was because of the 30% penalty on engi suits, so it made responding to breaches across the station painfully slow - and I would've done the same across other roles

You're not getting any hardsuit benefits unless you're wearing it so that logic doesn't make any sense.

I believe they're trying to point out you can equip and unequip hardsuits instantly for the situation and were able to run across the station with it in your hand, nullifying their move speed penalty
This wouldn't work in space but you could basically sprint whole hallways and immediately dress up at the airlock - apparently they didn't like this(?)

You're still vulnerable to slipping or disarming

That's cheesed the same way due to no equip time - you are in full control of disabling that vulnerability on a whim in 0.033 seconds by simply wearing the hardsuit.
A cautious player will wear the hardsuit whenever there is another character in view, and take it off whenever nobody is around. Purposely and actively avoiding two game mechanics that are used for balancing.
Granted, there are going to be cases where this will actually have the desired effect (a person actually dropping the hardsuit as a result of them slipping while carrying it in hand) and it's a good thing since that's how it's intended to be, but it's way too easy to avoid it to consider it any significant balancing point.
Once again, to me, this is an argument to add equip times. Drop on slip is an intended game mechanic (players make a decision whether to carry something in hand and risk dropping it versus putting it somewhere else and deal with other disadvantages). Ability to mitigate that instantly at no cost is IMO cheesing your way around a game mechanic.
I mean, we're kinda getting offtopic here. But just consider why carry slowdown was added. It wasn't added without a reason. That reason still stands (nothing changed on this matter), so it's still reasonable to keep the carry slowdown a.k.a. it's unreasonable to remove it.

yeah, you could in theory use your reflexes to instantly put the item on when you realise you’re being disarmed but it really isn’t that simple
This seems to me like a theoretical issue and not one that’s actually seen in practice - I’ve never felt the need to do this, nor have I seen anyone rapidly equip an item to avoid losing it when they’re slipped or disarmed.
Carrying a hardsuit around all the time is impractical no matter how you spin it. It’s one disarm or slip away from being stolen and that’s always a threat.

That's cheesed the same way due to no equip time - you are in full control of disabling that vulnerability on a whim in 0.033 seconds by simply wearing the hardsuit.

You won't be able to predict this unless you become so paranoid that anyone approaching you is trying to steal from you.

I think the overall outcome of this discussion is that Hardsuits need an overall overhaul to how they work to be fun/fair to use, rather than simple stat changes. (i would try but im no coder). Im gonna keep this open for now for any further discussion if need be, but im closing this PR on Monday GMT (someone remind me if i don't).

I think the overall outcome of this discussion is that Hardsuits need an overall overhaul to how they work to be fun/fair to use, rather than simple stat changes. (i would try but im no coder). Im gonna keep this open for now for any further discussion if need be, but im closing this PR on Monday GMT (someone remind me if i don't).

Maybe but a stat buff would be good for the short-term while waiting for any overhauls
I personally think you should split up the pr anyways since there's a lot of suits being touched

Try closing it now and opening a discord thread, easier to discuss there.

Done https://discord.com/channels/310555209753690112/1216041779355193344

Im happy to re-open this incase people decide this buff can work for short-term


Allow new kind of type in introspection

It should be possible to create a new kind of type without having the error Unknown kind of type: MyCustomType when introspecting the schema (see https://github.com/webonyx/graphql-php/blob/master/src/Type/Introspection.php#L419).
For example, we have this type in API Platform: https://github.com/api-platform/core/blob/master/src/GraphQl/Type/Definition/InputUnionType.php
And we can't introspect the schema because of the use of this new type.
We should at least be able to extend easily the related parts (not the case since it's inside an anonymous function).

No it's the issue, since it's throwing an exception, GraphiQL doesn't work.
The other solution would be to implement this type in graphql-php directly, even if it's not in the spec yet.
I think there's really a need for this, there's even a pending RFC here: https://github.com/facebook/graphql/pull/395 (see also https://github.com/graphql/graphql-js/issues/207).

I do agree that input union is a useful thing and I miss them myself. But I don't agree that we should allow non-spec-compliant custom type kinds in the base library.
The way to go for this kind of change is to support the RFC you posted previously and have it included in the spec eventually.


Create section in buddy list for users from narrow.

Fixes #21285.

Screenshots:
DMs

stream with some users subscribed:

stream with all users subscribed (no separation)

I've tested it on an organization with 1000 users and it looked okay to me.
To test large organizations, you might need to add this to stop the contact list to shrinking to not have anyone in it:
function maybe_shrink_list(user_ids, user_filter_text) {
    return user_ids;

Other things to note:

I tried splitting up the commits to aid with reviewing, but I'm still not sure how easily readable/reviewable the code is, so if anyone has feedback on that I'd love to hear it!
Custom copy for headings (e.g. naming what the narrow is) is something we decided to leave for a followup after this PR is merged.
Showing how many users are in each section is something I'm wary of -- in large organizations, we fetch more users to fill the list as you scroll through it. So I left that out of this initial PR as well, since we don't currently show that information anyways.

Thanks for all the work on this @evykassirer!
I didn't look at the CSS at all and the prev/next rewrite logic needs a more careful pass once you've considered the comments above; it's the kind of thing that can easily have bugs. But the structure seems generally reasonable and the above comments should help you clean this up considerably.
Planning to square the temp commits including the test changes is very reasonable.

Did some of a pass, now off to dinner and will finish later :)

@timabbott I've now addressed all your comments.
One thing I haven't done yet is add more unit tests to bring test coverage back up to 100%.
--
@alya Can you take a look and see how it feels?
One thing to note is I made it so that the section headers go away if only one section is visible. I think we should definitely do this if all users are in the Other Users section (since having only one section and calling it "other" is odd).
I'm open to keeping the Narrow Users header when there are no other users, if folks prefer that.
If we decide to have just one header sometimes, I'd like some input on what header to show for narrows like Recent Conversations and Starred Conversations, where there aren't really recipients for the narrow. Since they're technically being put in the Other Users bucket, we could decide to just never show Other Users as a single header, but be okay showing Narrow Users as a single header.
Let me know what you think, or if you have clarifying questions -- it's a bit hard/confusing for me to describe this ^^'

Most recent push involves adding new tests to bring test coverage to 100%. I want to do some tidying of them and set up some shared code.

Is that a typo for squash

Yes. Not sure about whether it's useful to keep them unsquashed; I'll look at that in my next review. I think the next step for this is for @alya to do a full product review of it.

Nice, this is feeling pretty good! A few thoughts on UX details and labels:

I think we should use a different label than "In selected conversation". One concern I have is that with @-topic mentions and the options for automatically following topics, the notion of being a conversation participant is becoming more prominent, and "In selected conversation" sounds like it might refer to that. (So people who actually participated in the topic, vs. all the stream subscribers.") We could try something like "In this stream"  for streams / "In this conversation" for DMs?

The issue said "Subscribers" for both contexts, which I'm not sure how I feel about at this point, but @timabbott still likes it. So that's also an option.

While playing with it, it felt confusing that the "In this conversation" section label goes away in (a) streams where everyone in the organization is subscribed, and (b) if you filter names. It makes it seem like maybe the feature to show who's in the conversation doesn't exist in some contexts.

I think the simplest and most consistent solution is to just always show both section labels, even if one of the sections is empty. Not showing any labels seems fine when there are no users matching the current filter at all.

@timabbott suggested putting the collapse/uncollapse icon on the right rather than the left, to make it possible to left-align the names (which is also how it's shown in the issue). Can we try that?

I wrote some more about #2 above

Thanks! I'm still seeing the headings disappear when filtering, whereas I think we want to keep them around:

Oh, we should show the whole list of users in the "All DMs" view:

This is what I see in a stream where the current user (aaron) is the only subscriber. I would expect to have the two sections as usual:

Oh sorry I had some old search-specific code that was messing some stuff up with the recent change. I think removing it fixed all three of those issues -- how's it look now?

I'm still seeing a lack of headers when only a user under "Others" matches the current filter.

"No matching users." feels odd to me when the filter is not being used. Maybe something like "None" would work better?

I'm still seeing a lack of headers when only a user under "Others" matches the current filter.

Ohhhh I see what's going on. Okay hopefully this fixes it. Sorry for the back and forth!

I think I prefer "None" to not having anything there at all. Do you have a preference either way?

I think I prefer "None" to not having anything there at all. I like the consistency of both headers visually having the arrow and something beneath them.

Happy to try that; seems easy enough to iterate on it when we test on CZO and get feedback from more folks.

The headings seem to stick around like we want them to now!

One design quirk is that "No matching users" has much greater contrast in dark theme than light theme. To me, it feels too contrasty in dark theme, and maybe not contrasty enough in light theme. But maybe we don't need to worry about it given that a right sidebar redesign is coming soon.

After the "None" change, I guess @timabbott should take another look to decide on next steps.

That push fixes a bug found in a puppeteer test, still need to update the empty list placeholder.

Updated to use the None placeholder outside of search :) Ready for @timabbott now!

I've addressed and/or replied to all comments :)

I need to do a followup to properly combine this work with #26196

I need to do a followup to properly combine this work with #26196

I've done this. Though there's a circular import being reported now and I'm not sure the best way to resolve it (activity_ui <> pm_list)

It's feeling good to me in manual testing! @timabbott do you want to take a look?

repeating comment from above:

There's a circular import being reported now and I'm not sure the best way to resolve it (activity_ui <> pm_list)

This seems to introduce a lot of import cycles, which will need to be fixed before we can merge it. But for now it's just a linter error.

This seems to introduce a lot of import cycles, which will need to be fixed before we can merge it. But for now it's just a linter error.

See my notes above about this. I think it's all coming from one import cycle? Or at least the error was originally for just two files. I'm not sure what the best way to fix it is and would love some guidance.

Updating the chat.zulip.org deployment.

most recent push fixes some failing unit tests

I extracted a couple prep commits as the series ending with https://github.com/zulip/zulip/pull/27402. I think https://github.com/zulip/zulip/pull/26717#discussion_r1373965942 would also be easy to merge as a prep commit after the rename proposed there.

most recent push:

rebase from main
rename to buddy-list-users-matching-view
fixed most of the import cycles, except that there's still one for views_util > activity_ui > inbox_ui > views_util

remaining work
Adding the "X inactive user" thing at the bottom of the lists

I started a conversation in #frontend about ways to get those numbers without bots.
I'd love some design direction from @terpimost on this, and tagged him in #design to ask for thoughts.
Maybe we want the numbers to link to something?

The spacing in the user list is too cramped, so I'll look into that.

Most recent pushes fix codecov issues

most recent push:

Includes an attempt to fix the circular import issue. I put it in its own commit because I'm not really sure if it makes sense to put the code where I did, but also I think it needs to be moved high up the call stack to not cause circular imports. Let me know if that looks okay!
Adds a commit to show the "inactive user" message. There's still some design conversation happening about this on CZO

This push is just fixing some test failures :)

I feel like I'm doing a bit of whackamole 😅 fixed code coverage, now should have passing node tests and passing test coverage. Hoping this one passes CI 🤞

Opened https://github.com/zulip/zulip/pull/27457 for a couple prep commits.

Updates:

renamed a bunch of variables as discussed above
I realized I wasn't updating the buddy list in a few places I needed to, so I added a bunch of function calls in the hashchange module. I don't really like this though, and would love ideas on other ways to update the sidebar

I realized the inactive numbers were showing up during search, so I added a line of code to remove that.

restating the remaining things:

the "X inactive user" thing at the bottom of the lists needs design input, asked about that on CZO
the last commit of this PR has some code I don't really like (but idk where else to put it to avoid circular imports) and I'm looking for input

I updated the inactive user message commit to:

Show the number of total users beside the section headings
Include links to views to see subscribed users / all users, as discussed on CZO

Most recent updates, from conversation on CZO:

remove the inactive user message
drop the periods on the links to the user views
indent the links
hide the links when no users, still show it if we're showing all the relevant users for the list
I renamed matching_view_container_selector to matching_view_list_selector` because there's a container around the list that's called "container" and that was confusing

Cool! I think we should count yourself in the DM conversation participants total. This looks odd:

Perhaps this is known, but it seems like live-update does not work when a user is added to a stream, though it does work when they are removed.

This is an edge case, but when a stream has no users, I think it should say "None." (just like the "Others" section). Currently, I see this instead:

I don't know what the conditions for this are, but I'm seeing the "View all subscribers" link pointing to the wrong stream (the URL in the bottom left is from hovering over that link):

Thanks for catching these Alya!

Added self to the count of PM participants
Fixed the link pointing to the wrong stream
Made the empty list situation work the same for subscribed users as other users

It seems like live-update does not work when a user is added to a stream, though it does work when they are removed.

I noticed it didn't work when a user is added to a stream, sorry for not pointing it out explicitly and asking about it. I've been trying to keep the PR smaller since it's already quite unwieldy, and was thinking this could be a follow up task, but especially with small lists of subscribers I can see an argument for including live-update right away. Do you have a preference here?

Thanks!

I noticed it didn't work when a user is added to a stream, sorry for not pointing it out explicitly and asking about it. I've been trying to keep the PR smaller since it's already quite unwieldy, and was thinking this could be a follow up task, but especially with small lists of subscribers I can see an argument for including live-update right away. Do you have a preference here?

I'll let @timabbott answer this one.

I did a pass of the CSS here. Looks good minus a couple of things I pointed out.
As a side note, I spent some time just walking through the DOM, inspecting the right sidebar and its styles. There's lots that can be tightened and cleaned up there, but all outside of this PR.

This push has these changes:

I squashed some of the temp commits together, since I wasn't sure if that was helping with review and wanted to simplify.
The number of users in the headings shortens when there are >1k users, and the exact number of users is always visible in a tooltip
Clicking the toggle no longer closes the compose box
"No active users" is shown instead of "None" when there are inactive users but none visible
Did some refactoring to share code between various header/empty-message/etc functions
Fixed circular imports in a different way, calling the update functions from a better places, fixing issues where the sidebar wasn't always updating during narrowing actions (still separating it as the last commit in this PR for easier review)

Let's show a "View all users" link when there are no sections (e.g., Inbox), and not all users are visible in the sidebar.

I think in that situation, we can also change the tooltip on the USERS heaading to give the exact number of users. The magnifying glass will still have the "Search people" tooltip.

Let's change the tooltip on the "Others" section to "N other users". After playing with it, I think it'll be more clear.

We also need to handle plurals properly (including internationalization -- mentioning that just in case):

Updates:

Removed quadratic thing that Anders pointed out
Show a "View all users" link when there are no sections (e.g., Inbox), and not all users are visible in the sidebar.
Changed the tooltip on the "Others" section to "N other users"
Handle plurals properly

Remaining:

Change the tooltip on the USERS heading to give the exact number of users (probably keeping that there all the time)
I realize I still haven't addressed the issue of updating the buddy list when someone is subscribed or unsubscribed. I'm wondering if we can keep this as a followup though.

(and remaining things from before)

Merging #27637, which is a prep PR for this one (and then integrating that into this PR)
Anders had some feedback about the triangle on CZO that's still under discussion.
The tests in this PR are currently failing. I think I've been spending too much time on cleaning up tests as I go, with the product back-and-forth that's going on, so I want to focus on getting the product pieces addressed before worrying about fixing unit tests or code coverage for now.

Updates:

Tooltip on the USERS heading now gives the exact number of users (it always shows this, and the search icon has been left unchanged)
The buddy list is rerendered when someone is subscribed or unsubscribed.

Remaining:

Merging #27637, which is a prep PR for this one
Figuring out what we want with the triangle
Fixing failing tests once everything else feels finalized (or close enough)

Pushing to resolve conflicts. @alya let me know if there's anything left on the product-side for this before I fix up the unit tests!
Locally one thing I'm noticing is a lag in showing the "No active users" message, and I'll look into it in a bit.

How does the rounding function work? We might want to play with it (e.g., I think I'd prefer 1.5K to 1K for 1509 users), but that should definitely be a separate follow-up.

This tooltip (in a large window) looks cut off:

OK, this one might be controversial, so let's see how the discussion here shakes out.

Could we add the name of the stream to the tooltip as well, for clarity? I think "17 subscribers in # stream" (with the correct privacy icon) should work. (Note that we just did something similar in https://github.com/zulip/zulip/pull/27666 .)

I've made a bunch of technical updates to make it easier for Tim to review. I've also opened a prep PR.
Remaining and unaddressed questions:

Addressing Alya's most recent design/product feedback
starting this conversation in #frontend
Unit tests

I'll maintain the TODO list in the description of the PR from now on.

Redeploying this on chat.zulip.org.

Just updated the unit tests and coverage! I removed buddy_list.js coverage in a commit in the middle of this PR, and did a lot of tweaking to update unit tests. Hopefully this PR is close to ready now :)

I addressed Karl's comments and rebased to resolve merge conflicts.
@timabbott, Karl said on CZO that "once the merge conflicts have been resolved, the next step is more CZO burn-in"

Test-deploying on chat.zulip.org for further testing.

Posted one comment on the new 3 fixup commits; otherwise they lgtm and should be fine to squash in.

I'll squash the commits in once we've resolved that last comment thread

squashed one of the recent three commits into the main commit
squashed the other two together, still temporarily at the end of the PR, now with variables to store collapsed state
current investigating this bug that's probably related to this PR

Error is addressed now in the last commit. Ready for review before a final squash and merge!

Addressed some comments locally. Will address more later, and push once everything's addressed.

Pushing what I have so far. Remaining issues I know of:
[ ] get_formatted_sub_count number formatting -- I asked some followups on CZO
[ ] profiling before and after buddy list: Calculate render data once per view. -- I need to look a bit into how to do this properly, but plan to do that soon
[ ] squashing commits -- I'm biasing to not squashing right away because it maybe helps you see what I've changed in such a huge PR, and it's harder to unsquash than to squash, but once you clarify what you want squashed I can do that

Just the profiling piece left, but feeling a bit too tired today for learning a new thing. I'll probably get to it some time this weekend.

Looks like you've got a puppeteer failure as well.

I tried using some profiling tools but wasn't able to see a notable change. I might be using them wrong though, so I'll try to get someone to pair with me on it later this week

OK rebased this, did the squash, and another review pass -- looks great, marked to merge once CI passes.

Ah oops. We could also revert the sidebar typescript change, merge this, merge #29022, and then convert sidebar after that.
I'm pretty open to any path going forward -- do you have a preference?

Reverting is probably more annoying than this approach, I think:

Another option would be to just put the code you're adding to sidebar_ui.js into a buddy_list.initialize method.

So I don't think we should consider that option. Probably we can just merge via https://github.com/zulip/zulip/pull/29022.

Merged via https://github.com/zulip/zulip/pull/29022.


Can't get read and write reqs counters

I am using aerospike-collectd v1.0.3 plugin with Aerospike Server Community Edition v<IP_ADDRESS> (Linux Debian Jessie)
The plugin works well for some counters like aerospike-service.gauge-client_connections and some other counters.
But I cannot retrieve the read and write counters for a while: I do not get any value for aerospike-service.operations-stat_write_reqs and aerospike-service.operations-stat_read_reqs.
These counters used to work a few months ago with an Aerospike v3.8 server but it does not work anymore since an Aerospike server upgrade (I think).
Is it supposed to work on Aerospike <IP_ADDRESS>? Or did I miss something?

Hi Koleo,
There has been an overhaul of metric names in Aerospike 3.9. You can find out the changes on this page.
With regards to the stat_read/write_reqs metrics, those have been deprecated in 3.9.
The metrics have been broken up based on namespace, and you will find them under each namespace.
eg: instances.aerospike...client_read/write_*

You're right, thank you for this information.


Accessing and storing encodings

Hi all,
Is it possible to access and store the encodings after processing the images?

Encoding is just an numpy.ndarray.
So save as data = encoding.tobytes()
Load as `encoding = numpy.frombuffer(data, , dtype=numpy.float64)


chore: update smithy4s-compliance-tests, ... from 0.17.19 to 0.18.2

About this PR
📦 Updates

com.disneystreaming.smithy4s:smithy4s-compliance-tests
com.disneystreaming.smithy4s:smithy4s-core
com.disneystreaming.smithy4s:smithy4s-json
com.disneystreaming.smithy4s:smithy4s-sbt-codegen

from 0.17.19 to 0.18.2
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.disneystreaming.smithy4s" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "com.disneystreaming.smithy4s" }
}]

labels: library-update, early-semver-major, semver-spec-minor, version-scheme:early-semver, commit-count:1

Superseded by #217.

Superseded by #240.


westeros-wpe-image: extra user is not required

EXTRA_USERS_PARAMS is not required for westeros

lgtm. @andrey-konovalov  could you review?

Thanks Siva,
next time please don't forget to add your "Signed-off-by:"

Ok, Thanks Andrey.


why the mAP is not  good(28.6%)?

Is the model  not well trained, or is it the reason for code?

@HHaikuo  ho do you calculate mAP?


Potential bugs in LocationService

Issue 1
https://github.com/tripleblindmarket/private-kit/blob/develop/app/services/LocationService.js#L100
Why is it starting another BackgroundGeolocation instance if instanceCount > 1? Why would you want multiple instances?
Issue 2
The following callbacks are duplicated in LocationService:

BackgroundGeolocation.on('stop' ...
BackgroundGeolocation.on('stationary' ...

Issue 3
Backfill logic isn't documented and doesn't seem to make sense. Why is the prior point being duplicated over and over? I think this is the cause of this issue: #360

We can work on Fixing this issue..

I think all dealt with in #389


Update pulumi/pulumi to v3.65.1

This addresses an issue with the filestate backend in v3.65.0
Fixes #437

@rquitales, this preps for a 1.11.5 release. I'm going to be out the rest of the week. If this looks good to you, please merge and cut the release. Thanks!

@justinvp thanks for initializing this. Will take over the release once CI passes.


Add Series.to_json and Series.to_csv

Codecov Report

Merging #358 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #358      +/-   ##
==========================================
- Coverage    94.4%   94.37%   -0.03%
==========================================
  Files          36       36
  Lines        3646     3646
==========================================
- Hits         3442     3441       -1
- Misses        204      205       +1

Impacted Files
Coverage Δ

databricks/koalas/missing/series.py
100% <ø> (ø)
:arrow_up:

databricks/koalas/frame.py
95.39% <ø> (-0.07%)
:arrow_down:

databricks/koalas/generic.py
95.69% <100%> (+0.51%)
:arrow_up:

databricks/koalas/__init__.py
88.88% <0%> (-3.71%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cffb28...d332bf1. Read the comment docs.

All tests apssed

Thanks for review @garawalid


MongoDB operator

From @TamalSaha on April 17, 2017 12:26
https://blog.kublr.com/how-to-run-a-mongodb-replica-set-on-kubernetes-petset-or-statefulset-542377f714db
Copied from original issue: k8sdb/kubedb#11

This issue was moved to kubedb/project#78


[CI] dump linkcheck errors to comments

Description
dump linkcheck errors to comments
Checklist
Essentials

[x] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
[x] Changes are complete (i.e. I finished coding on this PR)

Changes

[x] dump linkcheck errors to comments

Found link check problems in job PR-827/2:
(line   19) broken    https://www.salesforce.com/products/einstein/ai-research/the-wikitext-dependency-language-modeling-dataset/ - 404 Client Error: Not Found for url: https://www.salesforce.com/products/einstein/ai-research/the-wikitext-dependency-language-modeling-dataset/
(line    5) broken    https://www.salesforce.com/products/einstein/ai-research/the-wikitext-dependency-language-modeling-dataset/ - 404 Client Error: Not Found for url: https://www.salesforce.com/products/einstein/ai-research/the-wikitext-dependency-language-modeling-dataset/
(line    5) broken    https://www.salesforce.com/products/einstein/ai-research/the-wikitext-dependency-language-modeling-dataset/ - 404 Client Error: Not Found for url: https://www.salesforce.com/products/einstein/ai-research/the-wikitext-dependency-language-modeling-dataset/
(line   21) broken    https://www.salesforce.com/products/einstein/ai-research/the-wikitext-dependency-language-modeling-dataset/ - 404 Client Error: Not Found for url: https://www.salesforce.com/products/einstein/ai-research/the-wikitext-dependency-language-modeling-dataset/
(line  442) broken    https://www.aclweb.org/anthology/P02-1040.pdf)[1 - 404 Client Error: Not Found for url: https://www.aclweb.org/anthology/P02-1040.pdf)%5B1
(line   92) broken    https://nlp.stanford.edu/pubs/glove.pdf)[2 - 404 Client Error: NOT FOUND for url: https://nlp.stanford.edu/pubs/glove.pdf)%5B2
(line  208) broken    https://www.bioinf.jku.at/publications/older/2604.pdf)[3 - 404 Client Error: Not Found for url: https://www.bioinf.jku.at/publications/older/2604.pdf)%5B3

Job PR-827/2 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-827/2/index.html

The mli-CI system is upgraded again.


When adding a post the username is not being retrieved

Dont add posts or the app will not display that post

this shit fixed itself


Fixed/Logs-Box-UI

##Description
This PR Fixes the UI for "Logs" Box . I changed the UI for better user experience and also changes the border for "Logs" box. which ultimately updates the UI for smooth experience.
Fixes #47
##Screenshots:
-Blue

-Green

-Purple

-Red

Please review it.


hfst-ospell segfaults on empty description element in zhfst index file when built with TinyXML

Steps to reproduce:

build a recent version of hfst-ospell (svn HEAD is fine), with zhfst support and using TinyXML2 as the xml parser, install
build libvoikko with hfst support, install
edit the file $GTHOME/langs/GTLANG/tools/spellcheckers/fstbased/hfst/index.xml so that the description element is empty.
build the zhfst file
run voikkospell using that zhfst file

Expected result: voikkospell should function normally.
Actual result: voikkospell throws a segmentation fault:
:::gdb
602 else if (strcmp(info->Name(), "description") == 0)
(gdb)

Breakpoint 1, 0x00007fff86c11c00 in strlen ()
(gdb)
Single stepping until exit from function strlen,
which has no line number information.

Program received signal EXC_BAD_ACCESS, Could not access memory.
Reason: KERN_INVALID_ADDRESS at address: 0x0000000000000000
0x00007fff86c11c00 in strlen ()
(gdb)
```~

This happens around line 602 in the function ZHfstOspellerXmlMetadata::parse_info in ZHfstOspellerXmlMetadata.cc, or in the function ZHfstOspellerXmlMetadata::parse_description in the same file.

Running hfst-ospell through libvoikko is necessary, since hfst-ospell itself doesn't parse the metadata (and has no means of displaying the metadata). It would be good to add a simple option to print metadata in the zhfst file, just to be able to verify the integrity of both hfst-ospell and the zhfst file.

Reported by: snomos

Probably should be closed unless someone wants to implement more advanced recovery from this exceptional situation.


HH survey added

Changes
HH questionnaire added
How to test
See https://github.com/ONSdigital/sdx-compose/pull/7
Who can test
Anyone but @jjeane

👍


JWT implemented for logout and getDetails

I've tested it thoroughly. Please do test again.
Steps for testing:

Using the signup endpoint, create a user.
Login using the same details at the logout endpoint and copy the response to notepad.
Access logout or details enpoints as shown below
GET http://localhost:8080/api/account/:userID/details
Paste user_id in ":userID"
Add a header as shown below
Authorization: "Bearer < paste token here >"

Notes: Frontend DEV
The token and user_id returned from the signin response should be stored in localStorage on signin and other calls should be made as mentioned above.
PS:
Squash and merge.

Don't PULL, but please check. There are further improvements.

Ani, over here aren't we still sending the username, password and other details to the server through the signup endpoint? So it would be still be caught by a listener. While the token is generated during the response, how is this model better than the previous one? We are using the userID as a path parameter, but how is that helping as such?

VK, you can't have a listener if you have https on your API endpoints
instead of http. I'm working on that.
On Sun, Jun 24, 2018 at 11:14 PM adityavinodk<EMAIL_ADDRESS>wrote:

Ani, over here aren't we still sending the username, password and other
details to the server through the signup endpoint? So it would be still be
caught by a listener. While the token is generated during the response, how
is this model better than the previous one? We are using the userID as a
path parameter, but how is that helping as such?
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/aniketnk/alcoding-data-analysis/pull/21#issuecomment-399774076,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AQ9bd8_dNp8vbO-FnD2fpE32E_Nh0uJoks5t_9AXgaJpZM4U08HW
.

--

Where are you guys typing this? I can only see it in my email inbox.
On Sun, Jun 24, 2018, 11:45 PM Parth Shah<EMAIL_ADDRESS>wrote:

VK, you can't have a listener if you have https on your API endpoints
instead of http. I'm working on that.
On Sun, Jun 24, 2018 at 11:14 PM adityavinodk<EMAIL_ADDRESS>wrote:

Ani, over here aren't we still sending the username, password and other
details to the server through the signup endpoint? So it would be still
be
caught by a listener. While the token is generated during the response,
how
is this model better than the previous one? We are using the userID as a
path parameter, but how is that helping as such?
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<
https://github.com/aniketnk/alcoding-data-analysis/pull/21#issuecomment-399774076
,
or mute the thread
<
https://github.com/notifications/unsubscribe-auth/AQ9bd8_dNp8vbO-FnD2fpE32E_Nh0uJoks5t_9AXgaJpZM4U08HW
.

--
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/aniketnk/alcoding-data-analysis/pull/21#issuecomment-399776114,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AgdSVbSITePozoGIcveQtBPwFHoLnqXZks5t_9c9gaJpZM4U08HW
.

--
Regards,
Aniket Kaulavkar.