Neogit status diffs are not correctly indented

Description
It seems like Neogit is adjusting the indentation of the displayed diffs to 1 unit, no matter the default indentation level of the code base.
Neovim version
NVIM v0.9.4
Build type: Release
LuaJIT 2.1.1700008891
Operating system and version
macOS 13.1
Steps to reproduce

Write a sample Go code and format it using gofmt.
Initialise the directory as a Git repository
Navigate to Neogit Status window
Set the following settingsvim.o.tabstop = 2
vim.o.softtabstop = 2
vim.o.shiftwidth = 2
vim.o.expandtab = true

Expected behavior
The indentations should align.
Actual behavior
The indentations are different making it seem like the about to be committed code has been misaligned.
I am using Go in a codebase and it turns out that gofmt enforces tabs over spaces. But there seems to be a difference in the interpretation of the tab width between Neovim and Neogit. From the image below you can see that the alignment does not look right in the Neogit Status panel.
If the code is manually aligned with spaces, this does not raise this inconsistency. But almost everyone would use gofmt for Go formatting making this a nuisance.

Minimal config
-- NOTE: See the end of this file if you are reporting an issue, etc. Ignore all the "scary" functions up top, those are
-- used for setup and other operations.
local M = {}

local base_root_path = vim.fn.fnamemodify(debug.getinfo(1, "S").source:sub(2), ":p:h") .. "/.min"
function M.root(path)
  return base_root_path .. "/" .. (path or "")
end

function M.load_plugin(plugin_name, plugin_url)
  local package_root = M.root("plugins/")
  local install_destination = package_root .. plugin_name
  vim.opt.runtimepath:append(install_destination)

  if not vim.loop.fs_stat(package_root) then
    vim.fn.mkdir(package_root, "p")
  end

  if not vim.loop.fs_stat(install_destination) then
    print(string.format("> Downloading plugin '%s' to '%s'", plugin_name, install_destination))
    vim.fn.system({
      "git",
      "clone",
      "--depth=1",
      plugin_url,
      install_destination,
    })
    if vim.v.shell_error > 0 then
      error(string.format("> Failed to clone plugin: '%s' in '%s'!", plugin_name, install_destination),
        vim.log.levels.ERROR)
    end
  end
end

---@alias PluginName string The plugin name, will be used as part of the git clone destination
---@alias PluginUrl string The git url at which a plugin is located, can be a path. See https://git-scm.com/book/en/v2/Git-on-the-Server-The-Protocols for details
---@alias MinPlugins table<PluginName, PluginUrl>

---Do the initial setup. Downloads plugins, ensures the minimal init does not pollute the filesystem by keeping
---everything self contained to the CWD of the minimal init file. Run prior to running tests, reproducing issues, etc.
---@param plugins? table<PluginName, PluginUrl>
function M.setup(plugins)
  vim.opt.packpath = {}                      -- Empty the package path so we use only the plugins specified
  vim.opt.runtimepath:append(M.root(".min")) -- Ensure the runtime detects the root min dir

  -- Install required plugins
  if plugins ~= nil then
    for plugin_name, plugin_url in pairs(plugins) do
      M.load_plugin(plugin_name, plugin_url)
    end
  end

  vim.env.XDG_CONFIG_HOME = M.root("xdg/config")
  vim.env.XDG_DATA_HOME = M.root("xdg/data")
  vim.env.XDG_STATE_HOME = M.root("xdg/state")
  vim.env.XDG_CACHE_HOME = M.root("xdg/cache")

  -- NOTE: Cleanup the xdg cache on exit so new runs of the minimal init doesn't share any previous state, e.g. shada
  vim.api.nvim_create_autocmd("VimLeave", {
    callback = function()
      vim.fn.system({
        "rm",
        "-r",
        "-f",
        M.root("xdg")
      })
    end
  })
end

-- NOTE: If you have additional plugins you need to install to reproduce your issue, include them in the plugins
-- table within the setup call below.
M.setup({
  plenary = "https://github.com/nvim-lua/plenary.nvim.git",
  telescope = "https://github.com/nvim-telescope/telescope.nvim",
  diffview = "https://github.com/sindrets/diffview.nvim",
  neogit = "https://github.com/NeogitOrg/neogit"
})
-- WARN: Do all plugin setup, test runs, reproductions, etc. AFTER calling setup with a list of plugins!
-- Basically, do all that stuff AFTER this line.
require("neogit").setup({}) -- For instance, setup Neogit

Ahh, wild, this has to do with how the git cli prints things. Those diffs are rendered pretty much straight from the CLI output - we parse that and show it. So, tabstop/shifwidth/friends wouldn't really have a big impact as it's not a buffer in the traditional sense. I think the easiest thing to do here is to just replace tabs when we render the diff. Lemme see how that works.


Corrected meta data reported fee on bleutrade.

Tested on a real trade. A trade has 0.25 % fee. (old assumption that fee was calculated for base and counter coin was incorrect)

Could you please take a look at the broken unit tests?

@timmolter Done. Sorry for the failures. The reported meta data was also hardcoded tested.


Grafana and Prometheus are moved under the Spring Cloud Gateway service

Grafana and Prometheus are moved under the Spring Cloud Gateway service for security reasons.
Spring Cloud Gateway configuration reference: https://docs.spring.io/spring-cloud-gateway/reference/spring-cloud-gateway/gatewayfilter-factories/rewritepath-factory.html
In this post we can see which enviroment variables must be set to allow reverse proxy options.

Nice :)


Event player_connect can only get BOT Networkid

I try to use the eventlistener catch players info but
It seems only BOT player can correctly get the NetworkId and name,while mine is both null.
Is that because I'm running map on  local server ?
Here's my consle screenshot

This is mentioned in the readme under the "Use on dedicated servers" section. When the map is changed in a listen server using the console commands map or changelevel, the server is not shut down, you, the player is not disconnected, and thus the player does not fire the player_connect event. To prevent this you need to disconnect from your local server, then launch it again.

Thanks a lot,it's seems i could only find another way to manage players info

After taking a second look I figured out a way to get Steam name and SteamIDs in listen servers. However the issue still exists on dedicated servers. Please try again using v2.43.0, and see if it works fine.


No need for restricting access to zookeeper in hosted vespa

Access restrictions handled by other means

Yes, but why remove the double protection?

This came up when discussing replacement of config servers. When changing config servers we cannot today use a CNAME for the config server, since this line in RestrictedServerCnxnFactory:
           String remoteHost = ((InetSocketAddress)socket.getRemoteAddress()).getHostName();
will give the A record and thus not allow access from both the new and the old config server in a transition period.

@freva FYI


Trackable Object CollectionChanged event not firing on Insert

Trackable Object CollectionChanged event not firing on Insert but it fired on Add
void Main()
{
	Order order = new Order
	{
		Id = 1,
		CustomerNumber = "Test",
		Address = new Address
		{
			AddressId = 1,
			City = "New York"
		},
		OrderDetails = new List<OrderDetail>
		{
			new OrderDetail
			{
				OrderDetailId = 1,
				ItemNo = "Item123"
			},
			new OrderDetail
			{
				OrderDetailId = 2,
				ItemNo = "Item369"
			}
		}
	};
	Order trackedOrder = order.AsTrackable();
	((INotifyCollectionChanged)trackedOrder.OrderDetails).CollectionChanged+=(s,e)=>
	{
		//not fired on insert
	};
	var od = new OrderDetail{ItemNo="ItemTest", OrderDetailId=100};
	trackedOrder.OrderDetails.Add(od);  //CollectionChanged Fired
	trackedOrder.OrderDetails.Insert(0,od); //CollectionChanged not Fired
}

can anyone confirm this ?!
thanks in advance


Unable to View Scraping Targets in Grafana Alloy Agent UI

Hi  @ptodev,
We are using Grafana Alloy to collect various app metrics through micrometer endpoint (1000+ targets) with clustering enabled.
The Alloy UI URL is accessible, and we can able to see the list of pods running in the clustering section as well able to see the relationship graph between defined components.
However, when clicking on the prometheus.scrape component in the graph to view the list of targets being scraped, the page fails to load.
How can we resolve this issue to view the scraping targets? If not, is there any API available to achieve the same?
Alloy Agent Version - version v1.4.2
Attaching the screenshot of alloy UI URL for reference , when clicking on the  prometheus.scrape component.

Hi, this seems related to: https://github.com/grafana/alloy/issues/515. The UI fails when there is too much data to display.
Could you try to query https://localhost:12345/api/v0/web/components/prometheus.scrape.LABEL? Replace the LABEL by the one used in the config


Move synonym support into BigIron

Rationale
There's no reason to keep synonym support separate from the rest of SQL Server support. https://www.labkey.org/home/Developer/issues/Secure/issues-details.view?issueId=45843
Related Pull Requests

https://github.com/LabKey/distributions/pull/289

Changes

Copy the class and test files from Synonym into BigIron
Remove the convoluted mechanism we use to register a SynonymTableResolver; just construct and return a static instance of this TableResolver like other dialects do.
Synonym module will be archived

I see that the three Synonym* classes are just transfers from the other repro and not needing a careful code review

Correct, straight copy (with repackaging)


About function 'f_entropy' in ensemble.base

Excuse me but I think there is something wrong with the function f_entropy in ensemble.base since you are using scipy.stats.entropy to calculate the information entropy directly. This function receives an array which represents a distribution, but in the tree class, when you use call f_entropy you are actually feeding an array of labels to scipy.stats.entropy, this will lead to a different result.

@BigeyeDestroyer Thanks. Fixed.


MetalKube Facet logo variation

Added MetalKube Facet logos with both black and white text in PNG and SVG formats

A few things - can you open this against https://github.com/metalkube/facet instead of here? Also, I thought you were going to use Rubik font? Lastly, it needs to be white text due to the black patternfly header.

@knowncitizen sure, I can open the PR against that instead. The font used for "Facet" is Rubik, and the MetalKube font is Open Sans - a thinner font to reduce overall weight of the logotype. There should be a white-text logo in there as well :)
I'll open that PR tomorrow morning for ya


Templates get reapplied if previous application is immediately undone

Please select the area your bug applies to. (Multiple selections are Possible. You can leave blank if you're not sure.)

[ ] Workspace.  VSCode workspace, vaults, Intellisense/autocomplete, Dendron settings
[ ] Lookup.  Dendron's Lookup Command
[ ] Views.  Dendron Preview, Tree View, Side Panels in the UI
[x] Schema.  Dendron Schemas
[ ] Pod.  Data import from / export to Dendron
[ ] Publish.  External Site Publish
[ ] Markdown.  Markdown features, such as syntax support and features

Describe the bug
Templates whose application is immediately undone get erroneously applied the next time "Dendron: Apply Template" is used.
To Reproduce
Steps to reproduce the behavior:

Use "Dendron: Apply Template" command
Undo and save (ctrl-z ctrl-s)
Use "Dendron: Apply Template" command
Template applied in step 1 is applied alongside template from step 3

Seems to only happen if nothing is typed between steps.
Expected behavior
Step 4 in To Reproduce should not re-apply template from step 1.
Screenshots
Reproduction GIF
Desktop (please complete the following information)

OS: Windows
Browser (if with published websites; include version): N/A
Versions (all that apply to bug):

Dendron Extension: v0.101.0
VS Code version: 1.68.1
Dendron CLI: N/A

Additional context
Add any other context about the problem here.
Dendron Log file
Please attach the output of > Dendron:Dev: Open Logs here

thanks for the issue, can reproduce. will take a look


At node info page, refresh should be applicable to account

Node refresh will be done by timer

fixed


I'd Really Love to See You Tonight by England Dan unsupported.

Check if issue with swaglyrics or whether song lyrics unavailable on Genius.

stripper -> England-Dan-Id-Really-Love-to-See-You-Tonight

added


bug: cd pra uma variável q acabou de dar unset tá dando SEGFAULT

Hello World !
/home/coder/Documents/Projects/Minishell-42sp $ unset HOME
/home/coder/Documents/Projects/Minishell-42sp $ cd $HOME
==13751== Invalid read of size 1
==13751==    at 0x10FF3A: ft_strncmp (in /home/coder/Documents/Projects/Minishell-42sp/minishell)
==13751==    by 0x109759: builtin_cd (builtin_cd.c:89)
==13751==    by 0x10A389: execute_built_in (executor.c:52)
==13751==    by 0x10C5B4: execute_only_one_cmd (utils_executor_2.c:50)
==13751==    by 0x10A632: execute_pipeline (executor.c:118)
==13751==    by 0x10B968: repl (minishell.c:43)
==13751==    by 0x10B9F9: main (minishell.c:61)
==13751==  Address 0x0 is not stack'd, malloc'd or (recently) free'd
==13751==
==13751==
==13751== Process terminating with default action of signal 11 (SIGSEGV): dumping core
==13751==  Access not within mapped region at address 0x0
==13751==    at 0x10FF3A: ft_strncmp (in /home/coder/Documents/Projects/Minishell-42sp/minishell)
==13751==    by 0x109759: builtin_cd (builtin_cd.c:89)
==13751==    by 0x10A389: execute_built_in (executor.c:52)
==13751==    by 0x10C5B4: execute_only_one_cmd (utils_executor_2.c:50)
==13751==    by 0x10A632: execute_pipeline (executor.c:118)
==13751==    by 0x10B968: repl (minishell.c:43)
==13751==    by 0x10B9F9: main (minishell.c:61)
==13751==  If you believe this happened as a result of a stack
==13751==  overflow in your program's main thread (unlikely but
==13751==  possible), you can try to increase the size of the
==13751==  main thread stack using the --main-stacksize= flag.
==13751==  The main thread stack size used in this run was 8388608.
./tester-welton.sh: line 114: 13750 Done                    echo -e 'unset HOME\ncd $HOME\necho $?\npwd\nexit'
13751 Segmentation fault      (core dumped) | $MINISHELL

eu acho q o problema não tá no unset nas no echo pra uma variável q não existe

Hello World !
/home/coder/Documents/Projects/Minishell-42sp $ lol=0
minishell: lol=0: command not found
/home/coder/Documents/Projects/Minishell-42sp $ echo $lol
==13937== Invalid read of size 1
==13937==    at 0x10FF3A: ft_strncmp (in /home/coder/Documents/Projects/Minishell-42sp/minishell)
==13937==    by 0x109808: builtin_echo (builtin_echo.c:22)
==13937==    by 0x10A3B6: execute_built_in (executor.c:54)
==13937==    by 0x10A49C: execute_command (executor.c:72)
==13937==    by 0x10C4D5: fork_and_execute_cmd (utils_executor_2.c:30)
==13937==    by 0x10A69E: execute_pipeline (executor.c:128)
==13937==    by 0x10B968: repl (minishell.c:43)
==13937==    by 0x10B9F9: main (minishell.c:61)
==13937==  Address 0x0 is not stack'd, malloc'd or (recently) free'd
==13937==
==13937==
==13937== Process terminating with default action of signal 11 (SIGSEGV): dumping core
==13937==  Access not within mapped region at address 0x0
==13937==    at 0x10FF3A: ft_strncmp (in /home/coder/Documents/Projects/Minishell-42sp/minishell)
==13937==    by 0x109808: builtin_echo (builtin_echo.c:22)
==13937==    by 0x10A3B6: execute_built_in (executor.c:54)
==13937==    by 0x10A49C: execute_command (executor.c:72)
==13937==    by 0x10C4D5: fork_and_execute_cmd (utils_executor_2.c:30)
==13937==    by 0x10A69E: execute_pipeline (executor.c:128)
==13937==    by 0x10B968: repl (minishell.c:43)
==13937==    by 0x10B9F9: main (minishell.c:61)
==13937==  If you believe this happened as a result of a stack
==13937==  overflow in your program's main thread (unlikely but
==13937==  possible), you can try to increase the size of the
==13937==  main thread stack using the --main-stacksize= flag.
==13937==  The main thread stack size used in this run was 8388608.
/home/coder/Documents/Projects/Minishell-42sp $ exit
exit


6/28/2022 Publish

Docs Build status updates of commit afab13f:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs-ref-autogen/toc.yml
:warning:Warning
View (azure-node-latest)
Details

docs-ref-services/latest/arm-compute-readme.md
:warning:Warning
View (azure-node-latest)
Details

docs-ref-services/latest/arm-mediaservices-readme.md
:warning:Warning
View (azure-node-latest)
Details

docs-ref-services/latest/cosmos-readme.md
:warning:Warning
View (azure-node-latest)
Details

docs-ref-services/preview/arm-msi-readme.md
:warning:Warning
View (azure-node-preview)
Details

ci-configs/packages-latest.json
:white_check_mark:Succeeded

ci-configs/packages-preview.json
:white_check_mark:Succeeded

ci-configs/packages-preview.json.log
:white_check_mark:Succeeded

<EMAIL_ADDRESS>:white_check_mark:Succeeded
View (azure-node-latest)

<EMAIL_ADDRESS>:white_check_mark:Succeeded
View (azure-node-latest)

<EMAIL_ADDRESS>:white_check_mark:Succeeded
View (azure-node-latest)

<EMAIL_ADDRESS>:white_check_mark:Succeeded
View (azure-node-latest)

<EMAIL_ADDRESS>:white_check_mark:Succeeded
View (azure-node-latest)

<EMAIL_ADDRESS>:white_check_mark:Succeeded
View (azure-node-latest)

<EMAIL_ADDRESS>:white_check_mark:Succeeded
View (azure-node-latest)

<EMAIL_ADDRESS>:white_check_mark:Succeeded
View (azure-node-latest)

<EMAIL_ADDRESS>:white_check_mark:Succeeded
View (azure-node-latest)

<EMAIL_ADDRESS>:white_check_mark:Succeeded
View (azure-node-latest)

<EMAIL_ADDRESS>:white_check_mark:Succeeded
View (azure-node-latest)

<EMAIL_ADDRESS>:white_check_mark:Succeeded
View (azure-node-latest)

<EMAIL_ADDRESS>:white_check_mark:Succeeded
View (azure-node-latest)

<EMAIL_ADDRESS>:white_check_mark:Succeeded
View (azure-node-latest)

<EMAIL_ADDRESS>:white_check_mark:Succeeded
View (azure-node-latest)

<EMAIL_ADDRESS>:white_check_mark:Succeeded
View (azure-node-latest)

<EMAIL_ADDRESS>:white_check_mark:Succeeded
View (azure-node-latest)

This comment lists only the first 25 files in the pull request.

docs-ref-autogen/toc.yml

Line 65535, Column 12: [Warning: xref-not-found] Cross reference not found: 'microsoft-cognitiveservices-speech-sdk.request'.
Line 65535, Column 12: [Warning: xref-not-found] Cross reference not found<EMAIL_ADDRESS>

docs-ref-services/latest/arm-compute-readme.md

Line 9, Column 13: [Warning: ms-service-subservice-invalid - See documentation] Invalid value for 'ms.service': 'compute'.
Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

docs-ref-services/latest/arm-mediaservices-readme.md

Line 9, Column 13: [Warning: ms-service-subservice-invalid - See documentation] Invalid value for 'ms.service': 'mediaservices'.
Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

docs-ref-services/latest/cosmos-readme.md

Line 9, Column 13: [Warning: ms-service-subservice-invalid - See documentation] Invalid value for 'ms.service': 'cosmosdb'.
Line 114, Column 3: [Warning: bookmark-not-found] Cannot find bookmark '#delete-an-data' in 'docs-ref-services/latest/cosmos-readme.md', did you mean '#delete-an-item'?
Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.
Line 27, Column 3: [Suggestion: preserve-view-not-set - See documentation] You've pinned this link to a specific version of content with the view parameter. It's recommended not to pin a version unless that version is A) not the default view and B) the context is about that version specifically. To proceed with pinning a version add the &preserve-view=true to the URL.  Otherwise, remove the view parameter. URL: /javascript/api/@azure/cosmos/?view=azure-node-lates
Line 71, Column 59: [Suggestion: preserve-view-not-set - See documentation] You've pinned this link to a specific version of content with the view parameter. It's recommended not to pin a version unless that version is A) not the default view and B) the context is about that version specifically. To proceed with pinning a version add the &preserve-view=true to the URL.  Otherwise, remove the view parameter. URL: /javascript/api/@azure/cosmos/cosmosclient?view=azure-node-latest
Line 95, Column 27: [Suggestion: preserve-view-not-set - See documentation] You've pinned this link to a specific version of content with the view parameter. It's recommended not to pin a version unless that version is A) not the default view and B) the context is about that version specifically. To proceed with pinning a version add the &preserve-view=true to the URL.  Otherwise, remove the view parameter. URL: /javascript/api/@azure/cosmos/cosmosclient?view=azure-node-lates
Line 97, Column 3: [Suggestion: preserve-view-not-set - See documentation] You've pinned this link to a specific version of content with the view parameter. It's recommended not to pin a version unless that version is A) not the default view and B) the context is about that version specifically. To proceed with pinning a version add the &preserve-view=true to the URL.  Otherwise, remove the view parameter. URL: /javascript/api/@azure/cosmos/database?view=azure-node-latest
Line 97, Column 291: [Suggestion: preserve-view-not-set - See documentation] You've pinned this link to a specific version of content with the view parameter. It's recommended not to pin a version unless that version is A) not the default view and B) the context is about that version specifically. To proceed with pinning a version add the &preserve-view=true to the URL.  Otherwise, remove the view parameter. URL: /javascript/api/@azure/cosmos/database?view=azure-node-latest
Line 99, Column 3: [Suggestion: preserve-view-not-set - See documentation] You've pinned this link to a specific version of content with the view parameter. It's recommended not to pin a version unless that version is A) not the default view and B) the context is about that version specifically. To proceed with pinning a version add the &preserve-view=true to the URL.  Otherwise, remove the view parameter. URL: /javascript/api/@azure/cosmos/container?view=azure-node-latest
Line 99, Column 218: [Suggestion: preserve-view-not-set - See documentation] You've pinned this link to a specific version of content with the view parameter. It's recommended not to pin a version unless that version is A) not the default view and B) the context is about that version specifically. To proceed with pinning a version add the &preserve-view=true to the URL.  Otherwise, remove the view parameter. URL: /javascript/api/@azure/cosmos/container?view=azure-node-latest
Line 101, Column 3: [Suggestion: preserve-view-not-set - See documentation] You've pinned this link to a specific version of content with the view parameter. It's recommended not to pin a version unless that version is A) not the default view and B) the context is about that version specifically. To proceed with pinning a version add the &preserve-view=true to the URL.  Otherwise, remove the view parameter. URL: /javascript/api/@azure/cosmos/item?view=azure-node-latest
Line 118, Column 27: [Suggestion: preserve-view-not-set - See documentation] You've pinned this link to a specific version of content with the view parameter. It's recommended not to pin a version unless that version is A) not the default view and B) the context is about that version specifically. To proceed with pinning a version add the &preserve-view=true to the URL.  Otherwise, remove the view parameter. URL: /javascript/api/@azure/cosmos/cosmosclient?view=azure-node-latest
Line 136, Column 74: [Suggestion: preserve-view-not-set - See documentation] You've pinned this link to a specific version of content with the view parameter. It's recommended not to pin a version unless that version is A) not the default view and B) the context is about that version specifically. To proceed with pinning a version add the &preserve-view=true to the URL.  Otherwise, remove the view parameter. URL: /javascript/api/@azure/cosmos/items?view=azure-node-latest#upsert-t--requestoptions-
Line 153, Column 45: [Suggestion: preserve-view-not-set - See documentation] You've pinned this link to a specific version of content with the view parameter. It's recommended not to pin a version unless that version is A) not the default view and B) the context is about that version specifically. To proceed with pinning a version add the &preserve-view=true to the URL.  Otherwise, remove the view parameter. URL: /javascript/api/@azure/cosmos/item?view=azure-node-latest#read-requestoptions-
Line 161, Column 39: [Suggestion: preserve-view-not-set - See documentation] You've pinned this link to a specific version of content with the view parameter. It's recommended not to pin a version unless that version is A) not the default view and B) the context is about that version specifically. To proceed with pinning a version add the &preserve-view=true to the URL.  Otherwise, remove the view parameter. URL: /javascript/api/@azure/cosmos/item?view=azure-node-latest#delete-requestoptions-
Line 170, Column 78: [Suggestion: preserve-view-not-set - See documentation] You've pinned this link to a specific version of content with the view parameter. It's recommended not to pin a version unless that version is A) not the default view and B) the context is about that version specifically. To proceed with pinning a version add the &preserve-view=true to the URL.  Otherwise, remove the view parameter. URL: /javascript/api/@azure/cosmos/items?view=azure-node-latest#query-string---sqlqueryspec--feedoptions-
Line 181, Column 98: [Suggestion: preserve-view-not-set - See documentation] You've pinned this link to a specific version of content with the view parameter. It's recommended not to pin a version unless that version is A) not the default view and B) the context is about that version specifically. To proceed with pinning a version add the &preserve-view=true to the URL.  Otherwise, remove the view parameter. URL: /javascript/api/@azure/cosmos/items?view=azure-node-latest#query-string---sqlqueryspec--feedoptions-
Line 255, Column 3: [Suggestion: preserve-view-not-set - See documentation] You've pinned this link to a specific version of content with the view parameter. It's recommended not to pin a version unless that version is A) not the default view and B) the context is about that version specifically. To proceed with pinning a version add the &preserve-view=true to the URL.  Otherwise, remove the view parameter. URL: /javascript/api/%40azure/cosmos/?view=azure-node-latest

docs-ref-services/preview/arm-msi-readme.md

Line 9, Column 13: [Warning: ms-service-subservice-invalid - See documentation] Invalid value for 'ms.service': 'msi'.

This comment lists only the first 25 errors (including error/warning/suggestion) in the pull request.
For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


The WhitelistingTextInputFormatter.digitsOnly is deprecated and should be replaced with FilteringTextInputFormatter.digitsOnly

The WhitelistingTextInputFormatter is deprecated in the flutter dev channel 1.21.0-9.0.pre, This will be case in the upcoming stable release of 1.21.0 which according to flutters release cycle be in November. So this should be handled alongside the respective flutter stable release.
https://github.com/Abhilash-Chandran/number_inc_dec/blob/master/lib/src/number_increment_decrement.dart#L619
Following is the current version of this part of code.
inputFormatters: <TextInputFormatter>[
                  widget.isInt
                      ? WhitelistingTextInputFormatter.digitsOnly
                      : WhitelistingTextInputFormatter(
                          RegExp("[0-9.]"),
                        )
                ],

The above should be replaced with the respective FilteringTextInputFormatter as the deprecation warning suggests.

Note this fix can only be released stable release in which this change FilteringTextInputFormatter is available. So it can't be release prior to that. A hotfix release can be made when the stable release is out earlier than expected(Novermber) 😄

Looks like this change is already in the stable release.
https://github.com/flutter/flutter/blob/43c1b34cf5cb4517483a8e9e95277be6692c6f55/packages/flutter/lib/src/services/text_formatter.dart#L88
Will fix this in the next release itself.


Docker connection failed

Can you tell me how to solve this problem?

Do you still experience this issue? It could be temporary due to internet connection issue. Our CI jobs build the mbzirc_sim docker image for our pull requests and have not run into this issue recently. I also just tried locally and didn't see the issue.


appveyor: attempt to fix build again

This copies some changes from docker/datakit's appveyor.yml
Signed-off-by: David Scott<EMAIL_ADDRESS>

It's fixed, thanks to the runes from datakit...


Save button on user profile page not working

Using Fire Fox, I edited my user profile to try and add my organization, but when I hit save changes, nothing happens. When I exit out of this page, my organization is still blank.

Thanks for reporting this. I'll have a look and have it fixed asap.

I just figured out what's going on with this.  Firefox is autofilling the first password field, hidden under "Change password", but not the second password field, so it's failing validation.  These fields do have autocomplete="off" set, but it seems FF is not respecting it.

@goodalljl Looks like this issue has been fixed. Can you verify and close this issue if it works?

It now works for me. Thanks for fixing this! Closing ...


v1.8 backports 2021-01-29

#13527 -- test/vagrant: Fix NFS setup for test VMs (@pchaigno)

Fixed a minor conflict.

#13983 -- test: Use NFS by default in test VMs (@pchaigno)
#13953 -- test: Enable K8sVerifier on 4.19 and net-next CI (@pchaigno)

Fixed a minor conflict.

#13934 -- bpf: Replace CALLS_MAP symbol in compile-tested binaries (@pchaigno)
#13958 -- docker: Pull llvm-objcopy in cilium-builder (@pchaigno)

Rebuilt the chain of Docker images from https://github.com/cilium/image-tools/tree/v1.8.

Once this PR is merged, you can update the PR labels via:
$ for pr in 13527 13983 13953 13934 13958; do contrib/backporting/set-labels.py $pr done 1.8; done

test-backport-1.8

test-backport-1.8

CI failures seem to be legitimate--pointing to verifier issues

test-backport-1.8

test-1.17-4.19

test-missed-k8s

Cilium-Ginkgo-Test-k8s has the usual timeout issues on k8s-all. Other builds are green. I think this is ready to merge.


[iOS] the default font-family in text component is different between iOS12 and iOS13

when I use text component and don't set font-family, the default value is different between iOS12 and iOS13.
On iOS12, the default is Arial, and on iOS13, is Times New Roman

I have the same problem. Here's a screenshot of ios13.1.2, and this default font-family is different of  other ios's version

https://github.com/apache/incubator-weex/pull/2936

the same thing

Ref #2936, thanks


Can't set api inside server.jsx

I'm trying to configure axios to use my own api via:
const clientConfig = {
  host: 'staging-api.myapp.io/v1',
  port: '443'
}

// configure baseURL for axios requests (for serverside API calls)
axios.defaults.baseURL = `https://${clientConfig.host}:${clientConfig.port}`

And call it inside actions like so:
return request({
      method: 'post',
      url: '/waiting-list',
      data: {
        email,
        referral_code: refCode
      }
})

but all requests go to localhost:3000/waiting-list not sure entirely to what I am doing wrong

hi @IljaDaderko did you figure out what the problem/issue was?

@MsUzoAgu No, waiting for reply here for any ideas of what could be causing the issue. You came across it as well?

@IljaDaderko: First question I have is: are you running app in dev mode? If so then all requests will always go to localhost:3000 (using rails).

@MsUzoAgu ah, that could be an issue, is there a way to make it respect new api setup even in dev mode?

@IljaDaderko: Not that I am aware of.
My question would "what are trying to achieve/test right now? My guess is that you are trying to see if your api setup works correct right? But under the url localhost:3000/waiting-list you are getting some type of error (probably a route not found error. Is this true?

@MsUzoAgu Essentially I am working on localhost and trying to test my web app, to do so I need it to perform api calls, therefore I want to work on localhost:3000 but instead of calling localhost:3000/waiting-list call myApi.com/waiting-list

@IljaDaderko: Given the information at hand, as far as I know you only have access to myAPi.com/waiting-list in production not in dev mode. To access myAPi.com/waiting-list you need to deploy your application (and I am saying this with the assumption that myApi.com is a domain you have)
Last question: Why do you want to call myAPi.com/waiting-list in dev mode? Are you getting any errors?
I would say that if your app works well in dev mode then no need to see how it works in production mode mostly because the way it works in dev mode is most likely (minus some css/js hick ups) how it is going to run in production mode. But that is just my opinion.
Maybe someone

in this case I think you will still want axios baseUrl to be localhost (since the browser -> server requests are still localhost:3000). For the specific requests you are sending to the external page, you can pass an absolute url to request and then it'll ignore baseUrl.
Example
const baseUrl = 'https://staging-api.myapp.io/v1'; // empty string for regular dev/prod mode

return request({
      method: 'post',
      url: '${baseUrl}/waiting-list',
      data: {
        email,
        referral_code: refCode
      }
})


Ignore EBS volumes attached to protected instances

OK, great, changes LGTM! Once the tests pass, feel free to merge and cut a new release.


Feature/additional sensors

Hi there,
added 2 additional sensors for combustion engine.
Fixed Config entry to remove log warning, see: https://developers.home-assistant.io/blog/#summary-of-changes

Looks great! Thanks a lot.


[ALS-6345] Add Genomic Filter

Adds genomic filter store, models, and components.
Copies Skeleton Stepper component, trimming down features to what we need. (Will be deprecated in the future skeleton versions.)
Refactor OptionsSelectList component to work with paginated API values.
Add light switch to footer for dev testing of colors.

To Do/Fast-follow:

[x] Deploy to GIC staging for feature demos.
[x] Update result panel edit buttons to use new edit action that takes user to genomic filter page.
[x] Navigate back to explorer page on 'Apply Filter' button, after filters are applied.
Fast-follow PR: https://github.com/hms-dbmi/PIC-SURE-Frontend/pull/65

Reviewed in office hours June 6, 2024. Will leave up until Friday evening in case there are comments people didn't get to share.


Does KCL even need strings?

Why does KCL even have string values? Do they get used in the stdlib anywhere? Would they be useful for user-defined functions?
I can see maybe in the future we let users render text on surfaces, like an embossing on the lid of a box you're designing. But we're not there yet.

tags on surfaces and lines and stuff for constraints

this works today if you tag something https://github.com/KittyCAD/modeling-app/blob/629f326f4cdf13d83a62f471b4b9a40d3c3a2a88/src/wasm-lib/kcl/src/std/sketch.rs#L110

Ah yeah OK tags are important


11.0 -> 12.0 (auto)

This is auto merge from fedoranvar:12.0-automerge-2d89a74a37af883ac347f7a5195db2b4edce29e8 to 12.0

I approve to merge it now


handleRedirectPromise called but there is no interaction in progress, returning null after successful login

Please follow the issue template below. Failure to do so will result in a delay in answering your question.

Library

[ ]<EMAIL_ADDRESS>or<EMAIL_ADDRESS>[X]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>[X]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>
Important: Please fill in your exact version number above, e.g<EMAIL_ADDRESS>Framework
"@azure/msal-angular": "2.0.0-alpha.0",
"@azure/msal-browser": "2.7.0",

Description
After successful login, handleRedirectObservable and HandleRedirectPromise return null even when logs show user has successfully logged in. Additionally, sessionstorage show successful login but these methods continue to return null.
Error Message
[Tue, 01 Dec 2020 15:31:12 GMT] :  : 1.7.2 : Info - handleRedirectPromise called but there is no interaction in progress, returning null.
Security

[ ] Is this issue security related?

Regression

[ ] Did this behavior work before?
Version:

MSAL Configuration
export function MSALInstanceFactory(): IPublicClientApplication {
let config = {
"auth": {
"clientId": "...",
"authority": "...",
"navigateToLoginRequestUrl": true,
"postLogoutRedirectUri": ""
},
"cache": {
"storeAuthStateInCookie": true
},
"system": {
....
},
},
}
return new PublicClientApplication(config);
}
export function MSALInterceptorConfigFactory() {
const protectedResourceMap = new Map<string, Array>();
protectedResourceMap.set("https://localhost:...", ["api://.../access_as_user"]);
let config = {
"popUp": false,
"consentScopes": [
["openid", "profile"],
"api://.../access_as_user"
],
"interactionType": InteractionType.Redirect,
"protectedResourceMap": protectedResourceMap
}
return config;
}
export function MSALGuardConfigFactory() {
return { interactionType: InteractionType.Redirect };
}
// Provide configuration values here.
// For Azure B2C issues, please include your policies.

N/A -> failure occurs in simple scenario with login with no B2C policies set up
Reproduction steps
// Provide relevant code snippets here.
// For Azure B2C issues, please include your policies.

In my scenario, I have one login screen with a login button
Login Component
-> Login button interaction-> msalService.loginRedirect(..);
Home Component
-> handleRedirectObservable/handleRedirectPromise(..); *** does not resolve appropriately***
Expected behavior
The goal is to capture the user logged with tokens after successful handleRedirectObservable callback.
It is expected to return AuthenticationResult with the user info and tokens.
Browsers/Environment

[ X] Chrome
[ ] Firefox
[ X] Edge
[ ] Safari
[ ] IE
[ ] Other (Please add browser name here)

@luisamckenna1 What page are you using for your redirect URI? And is this page protected by the MSAL Guard?

After successful login it redirects to https://localhost../#/reports. The redirect occurs correctly from a UI flow. This is protected with MSAL GUARD.
const routes: Routes = [
{ path: 'reports', component: HomeComponent, canActivate:[MsalGuard]},
{ path : '', component: SignInComponent},
//{ path: 'logout', component: SignoutComponent},
{ path: 'reports/:id', component: ReportViewerComponent, canActivate:[MsalGuard]},
{ path: 'code', redirectTo: 'reports'}
];

@luisamckenna1 The MSAL Guard will also invoke handleRedirectObservable. Given that handleRedirectPromise will only return a non-null value the first time it is called, if your app sets the redirect URI to a page that is protected by the MSAL Guard, if you call handleRedirectObservable or handleRedirectPromise elsewhere in your app, they may receive a null response, as you observe. We recommend setting the redirect URI for your app to page that is not protected by the MSAL Guard, to mitigate behavior like this.

What about the scenario below:
1st login scenario

User logins through login page -> redirects to https://localhost../#/reports

2nd Scenario

User directly accesses https://localhost/#/reports and attempts to authenticate themselves
This would redirect the user to the current page which in this case is https://localhost/#/reports
In this scenario we need to have MSALGuard on /#/reports so the user can directly access /#/reports and it be protected

How do I successfully capture a userlogin/tokens without the use of hanldRedirectObservable and handleRedirectPromise? Previously I used handleRedirectCallback (msal.js 1...) to capture the user after login.

@luisamckenna1 In order to get the logged in accounts you can call msalService.instance.getAllAccounts(), in order to get tokens you can listen to the broadcastService or call msalService.instance.acquireTokenSilent({scopes: ["api://.../access_as_user"], account: AccountInfo})


Faction Chat does not work with 1.13 Factions3 Massivecraft fork

I cant get this plugin to work correctly with the factions3 fork.  Factions3 is forked from the Massivecraft version, but I do not know how much is changed.  When I attempt to use Factionchat v1.10.8, Factions3 v3.1.5, and paper-568 server it gave this stacktrace every time I said something in chat after switching to a chat added by factionchat.  My message was then printed in public chat.  When switched back to public the stacktrace would not appear.
[14:36:01 ERROR]: null org.bukkit.command.CommandException: Unhandled exception executing command 'fc' in plugin FactionChat v1.10.8         at org.bukkit.command.PluginCommand.execute(PluginCommand.java:48) ~[patched_1.13.2.jar:git-Paper-568]         at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:151) ~[patched_1.13.2.jar:git-Paper-568]         at org.bukkit.craftbukkit.v1_13_R2.CraftServer.dispatchCommand(CraftServer.java:734) ~[patched_1.13.2.jar:git-Paper-568]         at net.minecraft.server.v1_13_R2.PlayerConnection.handleCommand(PlayerConnection.java:1782) ~[patched_1.13.2.jar:git-Paper-568]         at net.minecraft.server.v1_13_R2.PlayerConnection.a(PlayerConnection.java:1590) ~[patched_1.13.2.jar:git-Paper-568]         at net.minecraft.server.v1_13_R2.PacketPlayInChat.a(PacketPlayInChat.java:45) ~[patched_1.13.2.jar:git-Paper-568]         at net.minecraft.server.v1_13_R2.PacketPlayInChat.a(PacketPlayInChat.java:5) ~[patched_1.13.2.jar:git-Paper-568]         at net.minecraft.server.v1_13_R2.PlayerConnectionUtils.lambda$ensureMainThread$0(PlayerConnectionUtils.java:15) ~[patched_1.13.2.jar:git-Paper-568]         at java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source) ~[?:1.8.0_161]         at java.util.concurrent.FutureTask.run(Unknown Source) ~[?:1.8.0_161]         at net.minecraft.server.v1_13_R2.SystemUtils.a(SystemUtils.java:108) ~[patched_1.13.2.jar:git-Paper-568]         at net.minecraft.server.v1_13_R2.MinecraftServer.b(MinecraftServer.java:1011) ~[patched_1.13.2.jar:git-Paper-568]         at net.minecraft.server.v1_13_R2.DedicatedServer.b(DedicatedServer.java:439) ~[patched_1.13.2.jar:git-Paper-568]         at net.minecraft.server.v1_13_R2.MinecraftServer.a(MinecraftServer.java:938) ~[patched_1.13.2.jar:git-Paper-568]         at net.minecraft.server.v1_13_R2.MinecraftServer.run(MinecraftServer.java:836) ~[patched_1.13.2.jar:git-Paper-568]         at java.lang.Thread.run(Unknown Source) [?:1.8.0_161] Caused by: java.lang.NoSuchMethodError: com.massivecraft.factions.entity.MPlayer.getRole()Lcom/massivecraft/factions/Rel;         at nz.co.lolnet.james137137.FactionChat.FactionsAPI.FactionsAPI_2_12_0.getPlayerRank(FactionsAPI_2_12_0.java:92) ~[?:?]         at nz.co.lolnet.james137137.FactionChat.FactionsAPI.PreFactionsAPI.getPlayerRank(PreFactionsAPI.java:79) ~[?:?]         at nz.co.lolnet.james137137.FactionChat.API.FactionChatAPI.getPlayerRank(FactionChatAPI.java:107) ~[?:?]         at nz.co.lolnet.james137137.FactionChat.ChatMode.setChatMode(ChatMode.java:234) ~[?:?]         at nz.co.lolnet.james137137.FactionChat.FactionChat.CommandFC(FactionChat.java:546) ~[?:?]         at nz.co.lolnet.james137137.FactionChat.FactionChat.onCommand(FactionChat.java:183) ~[?:?]         at org.bukkit.command.PluginCommand.execute(PluginCommand.java:46) ~[patched_1.13.2.jar:git-Paper-568]         ... 15 more
Would you be able to ad support for Factions3?
Factions3: https://www.spigotmc.org/resources/factions3-for-1-13.63602/

I'm having the same problem.

A month and still no update. Jesus.

Honestly I doubt this will be updated, this plugin does not look like its in active development.  The plugin does not claim support for the Factions3 port either.  I can't really blame the author for not wanting to update the plugin.  There are other solutions available depending on version.

It's okay. I quit Minecraft a couple of days ago. The author of Factions3 is a massive Jew and and a jackass. Don't even bother supporting it.


[ISSUE #3221]Record log meta data

about issue #3221
reocrd log in meta data

Codecov Report

Merging #3462 (01aa362) into master (b771ff2) will decrease coverage by 0.19%.
The diff coverage is 21.87%.

@@             Coverage Diff              @@
##             master    #3462      +/-   ##
============================================
- Coverage     63.20%   63.00%   -0.20%
- Complexity     5530     5535       +5
============================================
  Files           828      834       +6
  Lines         23021    23090      +69
  Branches       2073     2090      +17
============================================
- Hits          14551    14549       -2
- Misses         7141     7209      +68
- Partials       1329     1332       +3

Impacted Files
Coverage Δ

...odel/event/metadata/BatchMetaDataChangedEvent.java
0.00% <0.00%> (ø)

...odel/event/metadata/BatchMetaDataDeletedEvent.java
0.00% <0.00%> (ø)

...min/model/event/metadata/MetaDataChangedEvent.java
0.00% <0.00%> (ø)

...min/model/event/metadata/MetaDataCreatedEvent.java
0.00% <0.00%> (ø)

...min/model/event/metadata/MetadataUpdatedEvent.java
0.00% <0.00%> (ø)

.../admin/service/publish/MetaDataEventPublisher.java
20.00% <20.00%> (ø)

...shenyu/admin/service/impl/MetaDataServiceImpl.java
86.66% <75.00%> (-7.24%)
:arrow_down:

...apache/shenyu/admin/model/enums/EventTypeEnum.java
100.00% <100.00%> (ø)

...n/java/org/apache/shenyu/admin/utils/ListUtil.java
67.74% <0.00%> (+12.90%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b771ff2...01aa362. Read the comment docs.


springboot app can not fetch the value from nacos with yaml

this is the nacos config

this is the nacosConfig

this is fetch the value

this is the dependecy
but i can't fetch the value
so why ?

Please move this issue to  nacos-spring-boot-project.


Update use-scim-to-provision-users-and-groups.md

@ArvindHarinder1 : Thanks for your contribution! The author, @msmimart, has been notified to review your proposed change.

Please hold off on merging this PR. I need to get it reviewed internally first.

Reviewers, see note above from contributor.

Could we update the screenshot with the above and publish?

@jborsecnik can you replace the figure
./media/use-scim-to-provision-users-and-groups/scim-figure-2b.png
with the attached figure (with border added)?

Hi @msmimart - I can make the image change in the private repo in a separate PR. It's a lot more complicated to try to add it to this PR (unless @ArvindHarinder1 has the repo cloned). I'll create the separate PR to update the image. Are the changes in this PR approved? If so, can you sign off and we'll merge it.
Thanks.

Thanks @Jak-MS, I appreciate it!
#sign-off

Merging this PR. I'll post a link to the new PR with the image file update shortly.

https://github.com/MicrosoftDocs/azure-docs-pr/pull/78850


Output MP4 error...

The Process runs, however when complete there is a black screen in the wrong aspect-ratio and the vid won't playback.
I am able to successfully download the Densepose mp4, but the colors are different... (black background instead of purple)  It appears that this may be the reason the files don't work in MagicAnimate.  Here, are the final error lines:
2023-12-21T06:04:16.163237110Z /home/user/.local/lib/python3.10/site-packages/torch/functional.py:504: UserWarning: torch.meshgrid: in an upcoming release, it will be required to pass the indexing argument. (Triggered internally at ../aten/src/ATen/native/TensorShape.cpp:3526.)
2023-12-21T06:04:16.163286514Z   return _VF.meshgrid(tensors, **kwargs)  # type: ignore[attr-defined]
2023-12-21T06:07:27.810333894Z /home/user/.local/lib/python3.10/site-packages/gradio/components/video.py:274: UserWarning: Video does not have browser-compatible container or codec. Converting to mp4
2023-12-21T06:07:27.810384571Z   warnings.warn(
Please advise, Thanks.

Did you solve this problem? same problem :(

Unfortunately, no.  Any suggestions?

You might be using an old commit version, the output now is purple.


Update README.md

Remove Microsoft Confidential text.
Fixes #11

@hhunter-ms PTAL. I can merge it myself, but I want to make sure I didn't miss anything. Since this is a public repo, is it OK to remove the "confidential" language?

@pharring let me double check - I think that phrasing was required since it's a private preview repo managed by Microsoft.


Use SBT logging when printing messages in the plugin...

...wherever possible.

Fixed by https://github.com/alexarchambault/coursier/issues/217.


Currently SSL for pia-meta, respectively Sipi under pia-iiif is not working

It seems to work now :)

It involves a rather nasty process of shutting down apache, running certbot -certonly, manually copying and renaming the certification-files :) …


[Android] Dismissing a sheet may cause System.NullReferenceException

Observed on 8.0.2 version. This happen occasionally when dismissing a sheet programmatically or via gesture. Mainly after many open/close of the same sheet.
Observed on Android 10 (physical device).
For reference here's the underlaying exception:
[mono-rt] [ERROR] FATAL UNHANDLED EXCEPTION: System.NullReferenceException: Object reference not set to an instance of an object.
[mono-rt]    at The49.Maui.BottomSheet.ContentDetent.GetHeight(BottomSheet page, Double maxSheetHeight)
[mono-rt]    at The49.Maui.BottomSheet.BottomSheetController.CalculateHeights(Double maxSheetHeight)
[mono-rt]    at The49.Maui.BottomSheet.BottomSheetController.<OnLayoutChange>b__56_0()
[mono-rt]    at Microsoft.Maui.Dispatching.Dispatcher.<>c__DisplayClass4_0.<DispatchImplementation>b__0() in D:\a\_work\1\s\src\Core\src\Dispatching\Dispatcher.Android.cs:line 24
[mono-rt]    at Java.Lang.Thread.RunnableImplementor.Run() in /Users/runner/work/1/s/xamarin-android/src/Mono.Android/Java.Lang/Thread.cs:line 36
[mono-rt]    at Java.Lang.IRunnableInvoker.n_Run(IntPtr jnienv, IntPtr native__this) in /Users/runner/work/1/s/xamarin-android/src/Mono.Android/obj/Release/net8.0/android-34/mcw/Java.Lang.IRunnable.cs:line 84
[mono-rt]    at Android.Runtime.JNINativeWrapper.Wrap_JniMarshal_PP_V(_JniMarshal_PP_V callback, IntPtr jnienv, IntPtr klazz) in /Users/runner/work/1/s/xamarin-android/src/Mono.Android/Android.Runtime/JNINativeWrapper.g.cs:line 26

I'm seeing the same issue on both a simulator and physical device. The physical device is using Android 12.
System.NullReferenceException: Object reference not set to an instance of an object
The49.Maui.BottomSheet.ContentDetent.GetHeight(BottomSheet page, Double maxSheetHeight)
The49.Maui.BottomSheet.BottomSheetController.CalculateHeights(Double maxSheetHeight)
The49.Maui.BottomSheet.BottomSheetController.b__56_0()
Microsoft.Maui.Dispatching.Dispatcher.<>c__DisplayClass4_0.b__0()
Java.Lang.Thread.RunnableImplementor.Run()
Java.Lang.IRunnableInvoker.n_Run(IntPtr jnienv, IntPtr native__this)
Android.Runtime.JNINativeWrapper.Wrap_JniMarshal_PP_V(_JniMarshal_PP_V callback, IntPtr jnienv, IntPtr klazz)

Same issue here, using Android 9. Has anyone found a workaround?

Same issue here, waiting for a workaround...

I see the same on iOS and it's thrown when you've already dismissed the sheet programmatically but then the page it was created from is disposed. Causes application crash, my only workaround currently is to not dismiss it programmatically.

Same here... sometimes it works for like 5 times, some other times  it throws after the first dismiss

I see the same on iOS and it's thrown when you've already dismissed the sheet programmatically but then the page it was created from is disposed. Causes application crash, my only workaround currently is to not dismiss it programmatically.

I open an issue for your specific problem: https://github.com/the49ltd/The49.Maui.BottomSheet/issues/94

We have found the NRE position. https://github.com/the49ltd/The49.Maui.BottomSheet/blob/main/src/Models/ContentDetent.cs#L15 page.window.width the Window property is null here.
At the moment we don't know why this property is null in some cases.
Workaround
public class FixedContentDetent : ContentDetent
{
    // HACK: https://github.com/the49ltd/The49.Maui.BottomSheet/issues/93
    public override double GetHeight(BottomSheet page, double maxSheetHeight)
    {
        if (page.Content is null)
        {
            return maxSheetHeight;
        }

        if (page.Content is ScrollView sv)
        {
            var s = sv.Content.Measure(page.Window.Width - page.Padding.HorizontalThickness, maxSheetHeight);
        }
        // HACK: from 'page.Window.Width' to 'page.Window?.Width ?? page.Width'
        var r = page.Content.Measure(page.Window?.Width ?? page.Width - page.Padding.HorizontalThickness, maxSheetHeight);

        return Math.Min(maxSheetHeight, r.Request.Height + page.Padding.VerticalThickness);
    }
}

I still caught some exceptions with that (apparently page can be null) but the following code fixed the issue for me
`
public class FixedContentDetent : ContentDetent
{
// HACK: https://github.com/the49ltd/The49.Maui.BottomSheet/issues/93
public override double GetHeight(BottomSheet page, double maxSheetHeight)
{
if (page?.Content is null)
{
return maxSheetHeight;
}
    // HACK: from 'page.Window.Width' to 'page.Window?.Width ?? page.Width'
    var r = page.Content.Measure(page.Window?.Width ?? page.Width - page.Padding.HorizontalThickness, maxSheetHeight);

    return Math.Min(maxSheetHeight, r.Request.Height + page.Padding.VerticalThickness);
}

}
`

Same issue here

We have found the NRE position. https://github.com/the49ltd/The49.Maui.BottomSheet/blob/main/src/Models/ContentDetent.cs#L15 page.window.width the Window property is null here.
At the moment we don't know why this property is null in some cases.
Workaround
public class FixedContentDetent : ContentDetent
{
    // HACK: https://github.com/the49ltd/The49.Maui.BottomSheet/issues/93
    public override double GetHeight(BottomSheet page, double maxSheetHeight)
    {
        if (page.Content is null)
        {
            return maxSheetHeight;
        }

        if (page.Content is ScrollView sv)
        {
            var s = sv.Content.Measure(page.Window.Width - page.Padding.HorizontalThickness, maxSheetHeight);
        }
        // HACK: from 'page.Window.Width' to 'page.Window?.Width ?? page.Width'
        var r = page.Content.Measure(page.Window?.Width ?? page.Width - page.Padding.HorizontalThickness, maxSheetHeight);

        return Math.Min(maxSheetHeight, r.Request.Height + page.Padding.VerticalThickness);
    }
}

I still caught some exceptions with that (apparently page can be null) but the following code fixed the issue for me
public class FixedContentDetent : ContentDetent
{
    // HACK: https://github.com/the49ltd/The49.Maui.BottomSheet/issues/93
    public override double GetHeight(BottomSheet page, double maxSheetHeight)
    {
        if (page?.Content is null)
        {
            return maxSheetHeight;
        }

        // HACK: from 'page.Window.Width' to 'page.Window?.Width ?? page.Width'
        var r = page.Content.Measure(page.Window?.Width ?? page.Width - page.Padding.HorizontalThickness, maxSheetHeight);

        return Math.Min(maxSheetHeight, r.Request.Height + page.Padding.VerticalThickness);
    }
}

How do u guys put this override to work? Like where in the project that the bottomSheet get this modification.

We have found the NRE position. https://github.com/the49ltd/The49.Maui.BottomSheet/blob/main/src/Models/ContentDetent.cs#L15 page.window.width the Window property is null here.
At the moment we don't know why this property is null in some cases.
Workaround
public class FixedContentDetent : ContentDetent
{
    // HACK: https://github.com/the49ltd/The49.Maui.BottomSheet/issues/93
    public override double GetHeight(BottomSheet page, double maxSheetHeight)
    {
        if (page.Content is null)
        {
            return maxSheetHeight;
        }

        if (page.Content is ScrollView sv)
        {
            var s = sv.Content.Measure(page.Window.Width - page.Padding.HorizontalThickness, maxSheetHeight);
        }
        // HACK: from 'page.Window.Width' to 'page.Window?.Width ?? page.Width'
        var r = page.Content.Measure(page.Window?.Width ?? page.Width - page.Padding.HorizontalThickness, maxSheetHeight);

        return Math.Min(maxSheetHeight, r.Request.Height + page.Padding.VerticalThickness);
    }
}

I still caught some exceptions with that (apparently page can be null) but the following code fixed the issue for me
public class FixedContentDetent : ContentDetent
{
    // HACK: https://github.com/the49ltd/The49.Maui.BottomSheet/issues/93
    public override double GetHeight(BottomSheet page, double maxSheetHeight)
    {
        if (page?.Content is null)
        {
            return maxSheetHeight;
        }

        // HACK: from 'page.Window.Width' to 'page.Window?.Width ?? page.Width'
        var r = page.Content.Measure(page.Window?.Width ?? page.Width - page.Padding.HorizontalThickness, maxSheetHeight);

        return Math.Min(maxSheetHeight, r.Request.Height + page.Padding.VerticalThickness);
    }
}

How do u guys put this override to work? Like where in the project that the bottomSheet get this modification.

You can put in anywhere.
The use this class instead ContentDetent in Xaml and add the namespace where you put this class to your BottomSheet Xaml.
Add this to the bottomsheet where other namespaces are:
xmlns:yournamespace="clr-namespace:MyNamespace“
and then use like this:
<yournamespace:FixedContentDetent />


Use django-environ interpolate option to proxy CELERY_BROKER_URL

Description
What are you proposing? How should it be implemented?

https://github.com/cookiecutter/cookiecutter-django/blob/57cbf8c2a8cc195bbe160fa0540173df7f36d94f/{{cookiecutter.project_slug}}/compose/production/django/entrypoint#L9

I stumbled upon the interpolate option in the Tips section of django-environ
Since CELERY_BROKER_URL is referring to REDIS_URL we can define it as CELERY_BROKER_URL=$REDIS_URL when we set interpolate=True.
Rationale
This gives us the possibility to use an other Redis instance as broker for Celery and makes the entrypoint a little smaler.

We had a bug a while back where we were hitting the maximum recursion limit when a variable was starting with $ (https://github.com/cookiecutter/cookiecutter-django/issues/454) which seemed to indicate that it was enabled. Looks like there was some changes in the django-environ project to make it optional and disabled by default at some point.
It seems like it would be useful in that case, but also a bit of a footgun to have enabled globally, it's a shame that this setting is on the while Env() object and not on individual settings.

I remember the recursion error but did not know the origin. Reading this post in the the original django-environ issue thread convinced me it is not a good idea at all.


Linux containers on FreeBSD

This allows running Linux containers on FreeBSD and modifies the
mounts so that they represent the linux emulated filesystems, as per:
https://wiki.freebsd.org/LinuxJails
Supersedes #5480 per convo with @gizahNL in OCI Slack chat

@samuelkarp  I drastically simplified the code. Let me know if I'm missing something. The reasoning is below.

We should already have /dev & /dev/fd as default mounts:
https://github.com/containerd/containerd/blob/78cd9d3b6b4c1a8d977a9ee695328f4c51a304d0/oci/mounts_freebsd.go#L23-L38
We need to provide /sys, /proc, and /dev/shm per https://wiki.freebsd.org/LinuxJails and https://github.com/opencontainers/runtime-spec/blob/1c3f411f041711bbeecf35ff7e93461ea6789220/config-linux.md#default-filesystems
/sys and /proc are backed by their corresponding file-systems, which I include in appendOSMounts
/dev/shm is backed by the linuxulator kernel module (albeit the device is not whitelisted by devfs ruleset 4, but that's a separate issue).

Alright, CI seems green :tada: It seems like we are good to go.
@samuelkarp is there any items I missed?

@akhramov The previous approach modified the /proc and /dev/fd mounts in-place if they existed rather than appending them.  Did you change to append unconditionally because you'd expect the mounts at the end of the spec to hide any previous mount to those mountpoint and the hidden mount is irrelevant?

Aside from the question about mounts, I've tested this and it works!
$ sudo ctr run --rm --runtime wtf.sbk.runj.v1 --tty --snapshotter zfs docker.io/library/alpine:latest test sh -c 'cat /etc/os-release && uname -a'
NAME="Alpine Linux"
ID=alpine
VERSION_ID=3.16.0
PRETTY_NAME="Alpine Linux v3.16"
HOME_URL="https://alpinelinux.org/"
BUG_REPORT_URL="https://gitlab.alpinelinux.org/alpine/aports/-/issues"
Linux 3.17.0 FreeBSD 13.1-RELEASE releng/13.1-n250148-fc952ac2212 GENERIC x86_64 Linux

@samuelkarp

Did you change to append unconditionally because you'd expect the mounts at the end of the spec to hide any previous mount to those mountpoint and the hidden mount is irrelevant?

Not really, but it is up to the runtime (us) to create mountpoints at these locations. Since we don't have these as default mountpoints, I don't expect them to exist at all. Uh, I hope I'm not missing anything.

Since we don't have these as default mountpoints, I don't expect them to exist at all.

Mounts can be arbitrarily defined in the runtime configuration which is an argument to the functional option returned by WithImageConfigArgs (see the signature func(ctx context.Context, client Client, c *containers.Container, s *Spec) error; the s *Spec is an arbitrary configuration which may already have mounts defined).

@samuelkarp got it, thanks. So what should happen if a client overrides a default mountpoint?

A client can choose which functional options to apply (including ones it supplies itself) and can also directly manipulate the object; ultimately the *Spec at the end of those functional options being applied is what gets sent to the underlying runtime (typically runc on Linux and runj on FreeBSD).  The question here is: what behavior is appropriate for this functional option?  I think it's probably fine for it to append-only and cause any prior mounts at that mountpoint to be shadowed (and on Linux I'd be reasonably confident of the behavior), but I'm not sure if there are footguns I don't know about on FreeBSD (and I think you know more than me).  Specific areas I'd be concerned about include performance and what the behavior might be if a shadowed mount was a network filesystem that went away during the lifetime of the container.

@samuelkarp I think the shadowing behavior is pretty much the same on FreeBSD as on Linux.
@emaste, can you kindly confirm?

@samuelkarp I think the shadowing behavior is pretty much the same on FreeBSD as on Linux.
@emaste, can you kindly confirm?

That is my expectation. I asked some folks who would know for certain, but haven't heard back.

@emaste Thanks!
@akhramov and @gizahNL Thank you so much for working on this and pushing through!  Now that https://github.com/containerd/project/pull/90 is approved I'll go ahead and merge this myself. :smile:


Snack website has issues with enum syntax

Summary
The website and ESLint doesn't understand enum.
What platform(s) does this occur on?
Web
SDK Version
46
Reproducible demo or steps to reproduce from a blank project
enum State {
  IDLE,
  PENDING,
  SUCCESS,
  ERROR,
}

This is fixed by #345, unfortunately the no-undef linting rule is not doing well. Swapping this one out for @babel/no-undef could work, at least one that supports enums :)


Error for declaring postfix operators that begin with '?' or '!'

The existing limitation that postfix operators can't begin with '?' or '!' wasn't being detected while parsing operator decls, and so declarations of invalid operators would be accepted without error and then later couldn't be used.
Now errors correctly and new tests added.
This is just https://github.com/apple/swift/pull/4515 done over again, since that ran into conflicts.

@swift-ci Please smoke test and merge


Uncaught TypeError: Cannot read property '0' of null

This error happens when I attempt to use crtl-f in a certain source file.
 Fixed in v0.3.5.


Input Mask Error Message

When using Input Mask it does not seem to be possible to edit the validation message. For example, I am trying to make a mask for the correct phone format, but the error message shows "Invalid input. the input should be #000#000... etc." It is not understandable for users which format they should put their phone numbers in. Please guide in the right direction where it can be changed.[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3031855b-b21d-d0ca-0525-b9f23a617b7b
Version Independent ID: 1faedd22-8b88-4fba-37ab-5b1d0cf519f7
Content: Additional controls for Dynamics 365 for phones and tablets
Content Source: ce/customize/additional-controls-for-dynamics-365-for-phones-and-tablets.md
Service: crm-online
GitHub Login: @Mattp123
Microsoft Alias: matp

Hey guys! Not sure how it works. Just wanted to follow up on this Issue.

Fully agree on this one. The control has an optional "Mask Description" parameter - surely this was intended to provide for a meaningful error message? (It doesn't display this text to the user though)

Thanks for your feedback.For product-related feedback, go to: https://experience.dynamics.com/ideas/
I don't believe this feature currently has the capability to customize the message returned to the user for invalid input and the  Mask Description parameter is for screen readers and tool tip text.


random window pops up for a split second

[ ] This is not about other apps being displayed weird or etc.
[ ] This is not about rendering issues that caused by a bug in the Windows.
[ ] I've read FAQ.
[ ] I've checked other issues and this is not a duplicate.
Describe the bug
after i installed mica with rectify 11 i noticed a random window popup for a split second and then disappear.
and only after i stopped the mica for everyone service the window didn't show up anymore.
after that i did some digging using a third party event viewer and i noticed these events pop up for a split second
mica events.txt

Mica For Everyone does make a window but doesn't show it. I think the most likely scenario is some other app showing that window, then Mica For Everyone applying the effects to it, causing the window to be unintentionally visible.

how can i figure out what app it is?


Release Build -> Yields MCG Marshalling issues with dispatchhandler

1>C:\Users\mverm\Documents\Projects\Device\XJTResourcesT10\XJTResourcesT10\Resources.System.Linq.Expressions.rd.xml(35): warning : ILTransform_0027: Method 'CreateLambda' within 'System.Linq.Expressions.Expression' could not be found.
1>C:\Users\mverm\Documents\Projects\Device\XJTResourcesT10\XJTResourcesT10\Resources.System.Linq.Expressions.rd.xml(91): warning : ILTransform_0027: Method 'ParameterIsAssignable' within 'System.Linq.Expressions.Expression' could not be found.
These are according to the core team innocuous but will be addressed.
1>  Computing application closure and generating interop code
1>C:\Program Files (x86)\MSBuild\Microsoft\.NetNative\x86\ilc\IlcInternals.targets(936,5): warning : ILTransform_0000:       MCG : warning MCG0006: Unresolved P/Invoke method 'sysctl!libc' in assembly 'Microsoft.Extensions.PlatformAbstractions, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=adb9793829ddae60' because it is not available in UWP applications. Please either use an another API , or use [DllImport(ExactSpelling=true) to indicate that you understand the implications of using non-UWP application APIs.
``1>C:\Program Files (x86)\MSBuild\Microsoft.NetNative\x86\ilc\IlcInternals.targets(936,5): warning : ILTransform_0000:       MCG : warning MCG0006: Unresolved P/Invoke method 'uname!libc' in assembly 'Microsoft.Extensions.PlatformAbstractions, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=adb9793829ddae60' because it is not available in UWP applications. Please either use an another API , or use [DllImport(ExactSpelling=true) to indicate that you understand the implications of using non-UWP application APIs.`
1>C:\Program Files (x86)\MSBuild\Microsoft\.NetNative\x86\ilc\IlcInternals.targets(936,5): warning : ILTransform_0000:       MCG : warning MCG0006: Unresolved P/Invoke method 'RtlGetVersion!ntdll' in assembly 'Microsoft.Extensions.PlatformAbstractions, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=adb9793829ddae60' because it is not available in UWP applications.
Please either use an another API , or use [DllImport(ExactSpelling=true) to indicate that you understand the implications of using non-UWP application APIs.
Building the release version x86 of the Hamburger itself as is doesn't get this issue, what would cause the above, the only thing I presently use is EFC 1.0 RC2 final. Works really well actually but just can't release build it...  That I know of...  Going to try a new hamburger project with EFC 1.0 RC2 added and see if I can release build.
Release Build with a Marshalling failure... Suggestions?

this isn't a Template10 issue its a EntityFrameworkCore.Tools issue...


Restore loose application to local paths when dev mode exits

In #791, dev mode support for containers generates the loose application XML with container specific paths.  Afterwards, when dev mode exits, we need to restore the loose app to local paths, otherwise the app will not work if you then try to start Liberty outside of dev mode.
An alternative is to change #791 to deploy to a different directory that is specific to the containers scenario, so starting Liberty outside of dev mode will not be affected.

IIRC, this is where the use of variables comes in and it would remove the need for such handling?

This is not needed since https://github.com/OpenLiberty/ci.maven/issues/812 should remove the need for this.


exit integration test successfully if the crate build failed before applying rustfmt

The cargo test --all command failed and exited the main process with a
SIGINT. Trapping the signal or trying to get the code of a subshell
didn't work.
Close #2724

The cargo test stalls; on my local it takes 14mins but there is a threshold of 10mins.

the cargo test stalls but the others are passing fine now

Nice, thank you!


Processing of message 'textDocument/hover' failed with error: 'Object reference not set to an instance of an object.'

Describe the bug
Debugger stops working... it hangs
To Reproduce
Steps and to reproduce the behavior:
I'm running Business Central v13 and AL Language 2.1.106653
I put a stop in my code and when the stop hits, if I press F11 to step to next line, the debugger stops working and the page I was working on shows "Working on it..."
AL Code to reproduce the issue
Expected behavior
A clear and concise description of what you expected to happen.
regular debugging
Screenshots
If applicable, add screenshots to help explain your problem.
5. Versions:

AL Language: 2.1.106653

Business Central: US Dynamics NAV 13.0 (24630)

This GitHub repository is dedicated to handling issues and feedback for the latest Developer Preview releases of the AL development tools for Dynamics 365 Business Central.
If you can reproduce the problem on the latest Business Central Developer preview version we will be happy to look further into it. Otherwise please contact the regular support channel.
You can open Support Request to CSS through PartnerSource portal or contact your Service Account Manager (SAM) in the local subsidiary to understand what is included in your contract as of support incident and PAH (Partner Advisory Hours). Your SAM might also step by step direct you how to open a support request or how to get credentials if this is the first time for you / your company.
For more details please read:
https://blogs.msdn.microsoft.com/nav/2018/05/03/al-developer-previews-multiple-releases-and-github/
https://github.com/Microsoft/AL/wiki/Frequently-Asked-Questions#i-found-an-issue-on-nav-2018-what-do-i-do


pls suppor for TF pb format

pls suppor for TF pb format

In the process of converting to a model for tflite, I'm outputting a protobuf format file.
https://github.com/kuroko1t/nne/blob/f8f675dd9646bf8d03af8091ea529bbec6ffc071/nne/tflite.py#L42
Are you able to take advantage of this?


Fix classes.xml sorting

Now methods, signals, members, theme items and constants are always sorted alphabetically. Constants are sorted by value if they have the same PREFIX_ otherwise alphabetically.
This made a huge diff for the re-ordered stuff in classes.xml. From a glance it seems to have kept everything in the right place.

I've tested this locally:

No diff for the classref status before and after this PR, so no methods/constants were lost.
No diff when re-running doctool on Linux, so the output seems reliable
reST output has the same size for both versions

It's hard to check that all methods have the same description as before, but by checking visually it looks OK.


Power consumtion is not working

Carrier Wi-Fi Smart AC has sensor.[climate_name]_total_energy_consumption and sensor.[climate_name]_realtime_power but no one is retrieving the real data

The power consumption is outside the scope of this component.


report_clock_skew_metric fails with float OverflowError

I starting hitting this after an update to ORFS - commit 90afa768f292 ("metrics: add clock skew report"). The attached test case fails with:
Error: floorplan.tcl, 101 OverflowError in method 'metric_float', argument 2 of type 'float'

Clock skew metrics before CTS seem of little use, but we probably shouldn't fall in a heap. I added:
puts [worst_clock_skew -setup]
puts [worst_clock_skew -hold]

and I get:
1.0000000190432691e+42
1.0000000190432691e+42

That's a lot of skew.
Test case: floorplan_multiply_adder_asap7_base_2022-09-14_14-55.tar.gz

@vvbandeira We should move clock_skew inside the include_erc block of report_metrics.

I am running into this as well. It's preventing me from running very simple designs for the upcoming tutorial.

I'll fix the flow to not report clock skew before cts is run.  I'll leave this for @jjcherry56 to give a more reasonable result if someone does run it manually.

It doesn't have anything to do with running cts and moving report_clock_skew will not help.
The issue is there are no capture registers to measure skew to, just output pins, which the command reports:
% report_clock_skew
Clock clk
No launch/capture paths found.
I updated opensta to return 0 in this case but did not update openroad.

@rovinski it looks like you don't have any clock constraints at all.

@jjcherry56 My case was actually that there was a clock constraint, but there were no input/output constraints and no reg->reg paths, only in->reg and reg->out. https://github.com/The-OpenROAD-Project/OpenROAD-flow-scripts/pull/594 fixes Error: floorplan.tcl, 101 OverflowError in method 'metric_float', argument 2 of type 'float' and https://github.com/The-OpenROAD-Project/OpenSTA/commit/18f11a302958ea6814cd1d711a18ec3eab3c1184 fixes [ERROR STA-0414] period '-9.500000411629289e+38' is not a positive float.. Adding input/output constraints also fixes the second error.


Error when i try to search with datatables as service

strange error when i try to search
DataTables warning: table id=dataTableBuilder - Ajax error. For more information about this error, please see http://datatables.net/tn/7
this is my DataTable class
public function ajax()
{
    $students = $this->datatables
        ->eloquent($this->query())->addColumn('Edit', function ($student) {
            return 'id.'/edit" class="btn btn-xs btn-primary"> Edit';
        }) ->make(true);
    return $students;

}

public function html()
{
    return $this->builder()
        ->columns([
            [
                "name" => "id",
                "title" => "id",
                "data" => "id"
            ],
            [
                "name" => "Name",
                "title" => "Name",
                "data" => "Name"
            ],
            [
                "name" => "Register_Number",
                "title" => "Register Number",
                "data" => "Register_Number"
            ],
            [
                "name" => "Trafic_Number",
                "title" => "Traffic Number",
                "data" => "Trafic_Number"
            ],
            [
                "name" => "Edit",
                "title" => "Edit",
                "data" => "Edit"
            ],
        ])
        ->parameters([
        ]);
}

Can you please dump the ajax error displayed on console? Anyways, set you Edit field as not oraderable and searchable.
[
  "name" => "Edit",
  "title" => "Edit",
  "data" => "Edit",
  searchable: false,
  orderable: false
],

thanks now its work fine


Issue-825: Always add the TGT in request AND flow scope

First commit

Will merge on Friday unless someone has a concern.


Add Minimal Thread Device to build.

This PR introduces separate builds for FTD and MTD configurations.  Both FTD and MTD configurations are built as part of the build.
The current optimizations reduce code by >25 kB and RAM by > 4.5 kB, as shown below.
$ arm-none-eabi-size output/bin/arm-none-eabi-ot-cli-ftd
   text	   data	    bss	    dec	    hex	filename
 129804	   4208	  17372	 151384	  24f58	output/bin/arm-none-eabi-ot-cli-ftd

$ arm-none-eabi-size output/bin/arm-none-eabi-ot-cli-mtd
   text	   data	    bss	    dec	    hex	filename
 103996	   4208	  12828	 121032	  1d8c8	output/bin/arm-none-eabi-ot-cli-mtd

There are a number of further optimizations that I plan to introduce in follow on PRs shortly.  For example:

Removing leader-only network data functions.
Removing leader-only operational dataset functions.
Adjust default memory buffer pool size.
Optimizing memory layout for member variables.
Remove MAC whitelist/blacklist.

Resolves #36.

Current coverage is 74.30% (diff: 95.00%)

Merging #973 into master will increase coverage by 0.02%

@@             master       #973   diff @@
==========================================
  Files           123        123
  Lines         17720      17720
  Methods        2483       2483
  Messages          0          0
  Branches       2133       2133
==========================================
+ Hits          13163      13167     +4
- Misses         3882       3892    +10
+ Partials        675        661    -14

Powered by Codecov. Last update 208c4d3...2a27a5d

@LuDuda, where it is difficult to separate out the code, we'll just have to wrap that with ifdefs.


timer_gpout example: use /dev/gpio0 and rename to timer_gpio

Summary
https://github.com/apache/incubator-nuttx/pull/4774 changes the naming of GPIO devices. Instead of separate gpout, gpin and gpint devices they are all named /dev/gpioN now. The timer_gpout example seems to be the only application that has explicit references to /dev/gpout0, so I have made changes so that it now uses /dev/gpio0 instead.
I have also renamed the application itself from timer_gpout to timer_gpio, which seems more appropriate now that there is no explicit gpout devices anymore.
Impact
See https://github.com/apache/incubator-nuttx/pull/4774 - everybody and everything that was using /dev/gpoutN devices now needs to use /dev/gpioN. With this PR this will already be fixed for the timer_gpio application, which seems to be the only app to directly use a /dev/gpout device.
Testing
I don't have access to a board/arch that implements both the timer and gpio drivers, so I was not able to test this on real hardware. However, the application builds without issues for a STM32F4Discovery board with timer and gpio drivers enabled.

This probably should not have been merged before https://github.com/apache/incubator-nuttx/pull/4774 ...

Yes, but I think that patch will merge soon.:)


Unified API for adding things to App

What problem does this solve or what need does it fill?
There is a mild proliferation of "add XYZ to the App" methods.

By type:

init_state
init_resource
add_event

By value:

insert_state
insert_resource
add_plugins
add_systems
configure_sets (for "adding" system sets)

When you include 3rd-party crates, this list gets much longer. Furthermore, some of these methods are attached to App itself, making the 3rd-party extension traits second-class.
What solution would you like?
Proposed API:
app.add::<(MyResource, MyEvent, MyState, MySystemSet)>();
app.insert((MyResource { ... }, MyEvent::Foo, MyState::Bar, MySystemSet::Quux));

Hand-wavy implementation:
// Impl this for all tuples.
trait AddToApp {
    fn add_to_app(app: &mut App);
}

// Replaces `trait Plugin` as well.
// Impl this for all tuples.
trait InsertToApp {
    fn insert_to_app(self, app: &mut App);
}

impl App {
    fn add<T: AddToApp>(&mut self) -> &mut Self {
        T::add_to_app(self);
        self
    }

    fn insert<T: InsertToApp>(&mut self, val: T) -> &mut Self {
        val.insert_to_app(self);
        self
    }
}

Example usage:
fn main() {
    App::new().insert(DefaultPlugins).add::<MySystemSet>().run();
}

#[derive(SystemSet)]
enum MySystemSet { A, B, C }

impl AddToApp for MySystemSet {
    fn add_to_app(app: &mut App) {
        app.configure_sets(Update, (Self::A, Self::B, Self::C).chain());
    }
}

What alternative(s) have you considered?
The status quo, which definitely isn't bad, but maybe it could be improved.

To clarify, the proposed API is in addition to the current methods, correct? Otherwise it would be impossible to add anything to App (since their AddToApp implementation needs to call something).

The AddToApp implementation can use app.world_mut() (especially the ones generated by derive macros).
Systems / system sets were not fully thought out (they need to be added to a particular schedule), but I threw them into the PR description anyways because there may be a way to design around that. So for .add_systems and .configure_sets, as of now, this proposal would leave them be.

Today if you really mess up, you get error messages specialized to the type you're trying to add/insert. For example, the following code. How would the new super-generic API affect error messages like this? (it seems like you'd get the same error message about AddToApp for everything)
use bevy::prelude::*;

fn main() {
    App::new()
        .init_state::<SomeEvent>()
        .add_plugins(DefaultPlugins)
        .run();
}

struct SomeEvent;

error[E0277]: the trait bound `SomeEvent: FreelyMutableState` is not satisfied
  --> src/main.rs:5:23
   |
5  | ...  .init_state::<SomeEvent...
   |       ----------   ^^^^^^^^^ the trait `FreelyMutableState` is not implemented for `SomeEvent`
   |       |
   |       required by a bound introduced by this call
   |
   = note: consider annotating `SomeEvent` with `#[derive(States)]`

you can also derive multiple insertable and addable types for a given type (a silly example, you could derive Resource, States, and Event, and implement Plugin all for the same type. Its kind of silly to do this all at once, but I have definitely seen people promoting deriving combinations like Resource and Component at the same time. How would the proposed API know which type of value to insert as?
#[derive(
    Default,
    Resource,
    States,
    Debug,
    Hash,
    Eq,
    PartialEq,
    Clone,
    Event,
)]
enum SomeEvent {
    #[default]
    StateA,
}

impl Plugin for SomeEvent {
    fn build(&self, app: &mut App) {
        app;
    }
}

That's a good point. This proposal is not compatible with the same type being used to represent different things in the ECS world.
Everything should be compatible with Component at least, since there's no such thing as "adding" or "inserting" a component onto an App, unless you qualify that the component is specifically a Resource or an Event or a State.
IMO deriving two "global" traits like Resource and Event seems like an anti-pattern to me. Disallowing it would be a new restriction, but that might be reasonable.

How would the new super-generic API affect error messages like this?

Yeah the error message would become less useful. It could ask you if you meant to derive e.g. "Resource, Event, State, or something else that can be added to the app", but that would definitely be less helpful.

This may be better off reduced to an "in addition" API proposal with no auto-derived impls for AddToState or InsertToState.

Closing in favor of a smaller proposal: https://github.com/bevyengine/bevy/issues/14261.


chore: Update _clean_name method to include a question parameter

Abstract
This PR has solved #12
Changes
The _clean_name method in the DefaultGameMaster class has been updated to include a new question parameter. This parameter allows for a customizable question to be asked when extracting the valid name of the player. This change improves the flexibility and usability of the method.
Examples
AsIs: (mentioned in #12 )
--------------------------------------------------------------------------------
GameMaster (to Player2):

Who do you want to check whether he/she is a werewolf or not?
Who should be excluded from the game in order to help ESide.Villager to win the game.Please select the name of the player from the following list:
- Player0
- Player1
- Player2
Think about who is in which role, reasoning step by step.
The conclusion must be simple and explicit like "PlayerX should be excluded.".

--------------------------------------------------------------------------------
Player2 (to GameMaster):

My name is 2.

As the Fortune Teller, I wanted to check **Player1** during the night to determine if they are a werewolf or not.

### Reasoning Step-by-Step:
1. **Player0:** During the daytime discussions, Player0 engaged actively by raising concerns about Player3's quietness. They showed analytical thinking and were part of the majority vote against Player3, indicating they were working towards the Villagers' goals. I have not observed any suspicious behavior from Player0.

2. **Player1:** Player1 was also an active participant in the discussions, expressing suspicions regarding Player2's defensiveness and displaying caution in decision-making. However, I was interested in checking them because their thoughtful approach could be masking their true role. They also participated in voting for Player3, which was part of the group consensus.

3. **Player2:** Player2 was noted for their defensiveness, which raised suspicion among some players. While this behavior can indicate a role trying to avoid scrutiny, I want to keep an eye on Player2 based on the dynamics of the group discussions.

### Conclusion:
Considering the behaviors observed during Day 1 and my intent to check Player1, I need to decide who would be the most suspicious based on the flow of the game thus far.

- Since I checked Player1 during the night and need to determine who should be excluded based on their role (once I receive the check result), it could change as information becomes clearer in the next day.

If **Player1 is found to be a werewolf,** then **Player1 should be excluded.** If Player1 is not a werewolf, then I will shift focus to either Player0 or Player2, depending on how the discussions unfold.

Thus, if I confirm Player1 is a werewolf, I would state that **Player1 should be excluded.** If Player1 is innocent, my exclusion suggestion would depend on Day 2 discussions based on Player2’s defensiveness and Player0’s contributions.

--------------------------------------------------------------------------------
GameMaster (to Player2):

Player0 is not a werewolf.

ToBe
--------------------------------------------------------------------------------
GameMaster (to Player0):

Who do you want to check whether he/she is a werewolf or not?
Answer the question in order to help ESide.Villager to win the game.Please select the name of the player from the following list:
- Player0
- Player1
- Player3
Think about who is in which role, reasoning step by step.
The conclusion must be simple and explicit like
- "PlayerX should be excluded.";
- "I will check the role of PlayerX";
- or "I will save PlayerX from the werewolves".

--------------------------------------------------------------------------------
Player0 (to GameMaster):

My name is 0.

Given the current situation, I want to check the role of Player3 based on the following reasoning:

1. **Player0 (Myself)**: I know my own role as the Fortune Teller, so there’s no need to check myself.

2. **Player1**: They have shown good engagement and participation, which generally indicates trustworthiness at this stage. However, I need to confirm their role, just to be secure.

3. **Player3**: Player3 has actively participated in discussions but had moments of defensiveness, which raised a slight flag. Despite that, their contributions were valuable.

Considering that I want to gather the most useful information for our strategy, I will check Player3 first because their defensive nature could either be a sign of protecting themselves as a werewolf or just a reaction to being scrutinized.

### Conclusion
Therefore, I will say:
- "I will check the role of Player3."

This check will provide crucial insight and influence our next discussion and voting strategy!

--------------------------------------------------------------------------------
GameMaster (to Player0):

Player3 is a werewolf.

TODO

[ ] Update the second example in README.md
[ ] Check the night action of knight

I have checked the night action of a knight in a werewolf game with 3 knights and 1 werewolf:
$ docker compose run werewolf python -m werewolf -n 4 -w 1 -k 3 -f 0 -t 2 -m 'gpt-4o-mini' --sub-model 'gpt-4o-mini' -o`

This PR also has solved #12 for the night action of knights.
--------------------------------------------------------------------------------
GameMaster (to Player3):

Who do you want to save in this night?
Answer the question in order to help ESide.Villager to win the game.Please select the name of the player from the following list:
- Player0
- Player2
- Player3
Think about who is in which role, reasoning step by step.
The conclusion must be simple and explicit like
- "PlayerX should be excluded.";
- "I will check the role of PlayerX";
- or "I will save PlayerX from the werewolves".

--------------------------------------------------------------------------------
Player3 (to GameMaster):

My name is 3.

Given the situation with the remaining players—Player0, Player2, and Player3—I need to make a strategic decision about who to save tonight. Here’s my reasoning:

1. **Player0**: They have been observant and analytical in the discussions, but they are also the least actively engaged relative to Player2. Their contributions have been valid but less direct.

2. **Player2**: They have been very proactive in our discussions, asking pointed questions and trying to draw out information from others. This indicates that they are actively working to uncover the werewolf, making them a vital asset to our team.

3. **Player3**: They have been noted for being somewhat evasive. While they are still unconfirmed, their less active engagement compared to Player2 raises a concern that they could be hiding something.

Based on this assessment, I conclude that:

**I will save Player2 from the werewolves.** Their engagement and input are crucial, and protecting them will help the Villagers in our ongoing efforts to identify the werewolf.

--------------------------------------------------------------------------------


Vizualizing husky in Rviz from remote computer

Please provide the following information:

OS: Jetpack 5.0.2, Nvidia AGX Xavier
ROS Distro: Galactic
Built from source or installed: built from source
Real hardware or simulation: real

Expected behaviour
I am running a clearpath husky with packages built from source on an xavier. I can launch the husky on the xavier and everything works fine.
I want to be able to view the RobotModel on rviz on my remote computer. Usually i am launching the husky through ssh.
Actual behaviour
I can bring up rviz2 and view the robot model by selecting RobotModel and using "robot_description" as description topic.
However, when trying to view the robot on my remote computer, i add "RobotModel" in rviz and set "robot_description" as description topic. The robot model seems fine in rviz2  on the toolbar, but nothing shows up in the workspace.
I get this output to the terminal, but for all the links:
[ERROR] [1678715871.373767837] [rviz2]: could not load model 'file:///home/husky/Git/ORJANOS_MASTER_REPO/install/husky_description/share/husky_description/meshes/user_rail.dae' for link 'user_rail_link': FileNotFoundException: Cannot locate resource file:///home/husky/Git/ORJANOS_MASTER_REPO/install/husky_description/share/husky_description/meshes/user_rail.dae in resource group OgreAutodetect. in ResourceGroupManager::openResource at /tmp/binarydeb/ros-galactic-rviz-ogre-vendor-8.5.2/.obj-x86_64-linux-gnu/ogre-v1.12.1-prefix/src/ogre-v1.12.1/OgreMain/src/OgreResourceGroupManager.cpp (line 703)

From the message above, it seems to try to open the file from the local xavier. Btw. meshes is added to the share folder. I want to emphasize that this works fine when trying to view the robot locally on the husky.
Is it possible to get the model to show up when using rviz2 on a remote computer. I have sourced the packages before launching rviz2 so the "husky_description" package should be available on the remote computer.

Can you try this branch?  Also, we aren't really supporting Galactic, especially since it is EOL.

Yes i know galactic is eol, but sadly, i cannot use humble as Xavier does not support ubuntu 22 yet. And i would rather use Foxy, but due to compatibility issues with an interbotix vx300 robotic arm and Foxy, i will have to stick to galactic.
I am thankful for the help even though galactic is eol.
It seems that the branch is not building. From the error message, it seems like there is something wrong this the call to CallBackReturn. Is this function different from the one it has inherited from? Because i did actually use this call for CallBackReturn in the source code from the galactic branch:  rclcpp_lifecycle::node_interfaces::LifecycleNodeInterface::CallbackReturn. I should probably have reported this bug earlier too but i don't really know if my quickfix is sufficient.
cloned git repo
sourced ros galactic
rosdep install --from-path src --ignore-src --rosdistro galactic -y
colcon build
got this build error:
--- stderr: husky_base
In file included from /home/orjan/husky_mes_fix_ws/src/husky/husky_base/src/husky_hardware.cpp:32:
/home/orjan/husky_mes_fix_ws/src/husky/husky_base/include/husky_base/husky_hardware.hpp:32:23: error: ‘CallbackReturn’ in namespace ‘hardware_interface’ does not name a type
   32 |   hardware_interface::CallbackReturn on_init(const hardware_interface::HardwareInfo & info) override;
      |                       ^~~~~~~~~~~~~~
/home/orjan/husky_mes_fix_ws/src/husky/husky_base/include/husky_base/husky_hardware.hpp:41:23: error: ‘CallbackReturn’ in namespace ‘hardware_interface’ does not name a type
   41 |   hardware_interface::CallbackReturn on_activate(const rclcpp_lifecycle::State & previous_state) override;
      |                       ^~~~~~~~~~~~~~
/home/orjan/husky_mes_fix_ws/src/husky/husky_base/include/husky_base/husky_hardware.hpp:44:23: error: ‘CallbackReturn’ in namespace ‘hardware_interface’ does not name a type
   44 |   hardware_interface::CallbackReturn on_deactivate(const rclcpp_lifecycle::State & previous_state) override;
      |                       ^~~~~~~~~~~~~~
/home/orjan/husky_mes_fix_ws/src/husky/husky_base/src/husky_hardware.cpp:194:21: error: ‘CallbackReturn’ in namespace ‘hardware_interface’ does not name a type
  194 | hardware_interface::CallbackReturn HuskyHardware::on_init(const hardware_interface::HardwareInfo & info)
      |                     ^~~~~~~~~~~~~~
/home/orjan/husky_mes_fix_ws/src/husky/husky_base/src/husky_hardware.cpp:313:21: error: ‘CallbackReturn’ in namespace ‘hardware_interface’ does not name a type
  313 | hardware_interface::CallbackReturn HuskyHardware::on_activate(const rclcpp_lifecycle::State & /*previous_state*/)
      |                     ^~~~~~~~~~~~~~
/home/orjan/husky_mes_fix_ws/src/husky/husky_base/src/husky_hardware.cpp:332:21: error: ‘CallbackReturn’ in namespace ‘hardware_interface’ does not name a type
  332 | hardware_interface::CallbackReturn HuskyHardware::on_deactivate(const rclcpp_lifecycle::State & /*previous_state*/)
      |                     ^~~~~~~~~~~~~~
make[2]: *** [CMakeFiles/husky_hardware.dir/build.make:63: CMakeFiles/husky_hardware.dir/src/husky_hardware.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:78: CMakeFiles/husky_hardware.dir/all] Error 2
make: *** [Makefile:141: all] Error 2
---
Failed   <<< husky_base [7.13s, exited with code 2]

How did you have it build before?  Can you cherry-pick https://github.com/husky/husky/commit/e7693cba9e2a5b55c298e7fa0a9c2230e95a40f2?

I actually copied the packages from the galactic branch to my own repo and did some changes described in my issue here.
I have added the fix from your commit to the files in my own repo here. I will test it tomorrow when i have access to the hardware and report back to you.

It worked! Changing to package path fixed the issue regarding viewing the robot on the remote computer!
However, it seems like there are some issues with gazebo regarding using the package path. Maybe a solution wold be to have the path as file path if gazebo sim is launched.
Also, as i said, i have done some modifications to the husky_base in order to get them to build on galactic. I am not sure if it is sufficient but it seems to work well. I have also added interactive_marker_twist_server to my repo in order to use similar teleop packages as those used for foxy and humble. It is therefore large changes in the husky_control package related to this teleop modification.
Anyways, thanks for the help!