what's the meaning of "identified 2036 incorrect configurations"

In the Contributions part in this article, you said "We applied LGDFuzzer to a real-world flight control program
and identified 2, 036 incorrect configurations causing unstable flight states. We also verified 106 incorrect configurations on real-world drones and confirmed that these incorrect configurations cause trajectory deviations or drone crashes". In the EVALUATION part, you tested 20 configuration parameters, but what's the meaning of 2063 configuration errors and 106 incorrect configurations on real-world drones. I would appreciate it if you could answer this question.

We said that we are testing 20 parameters rather than 20 configuration. These 20 parameters can make up different configurations. Like Configuration1 {A=1, B=1, C=1} and Configuration2 {A=1,B=2,C=3}.
Sender: @.***>
In the Contributions part in this article, you said "We applied LGDFuzzer to a real-world flight control program
and identified 2, 036 incorrect configurations causing unstable flight states. We also verified 106 incorrect configurations on real-world drones and confirmed that these incorrect configurations cause trajectory deviations or drone crashes". In the EVALUATION part, you tested 20 configuration parameters, but what's the meaning of 2063 configuration errors and 106 incorrect configurations on real-world drones. I would appreciate it if you could answer this question.
—
Reply to this email directly, view it on GitHubhttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FBlackJocker1995%2Fuavga%2Fissues%2F2&data=05|01||b02aad92729a4b57aa6a08da21fa9239|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637859657341993369|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=mP82zFuLAe7g641cJzhgj6o%2BbpXjO3It55b%2FcrpXorg%3D&reserved=0, or unsubscribehttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FADRXMHYZC7VTDAHK7EMZBZLVF2MSDANCNFSM5TYSUALA&data=05|01||b02aad92729a4b57aa6a08da21fa9239|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637859657341993369|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=Nl7xW3wgTVJ4jjgV8OxqKFAHTmGTQYHn01OOdiVj7Ao%3D&reserved=0.
You are receiving this because you are subscribed to this thread.Message ID: @.***>

We said that we are testing 20 parameters rather than 20 configuration. These 20 parameters can make up different configurations. Like Configuration1 {A=1, B=1, C=1} and Configuration2 {A=1,B=2,C=3}. Sender: @.> In the Contributions part in this article, you said "We applied LGDFuzzer to a real-world flight control program and identified 2, 036 incorrect configurations causing unstable flight states. We also verified 106 incorrect configurations on real-world drones and confirmed that these incorrect configurations cause trajectory deviations or drone crashes". In the EVALUATION part, you tested 20 configuration parameters, but what's the meaning of 2063 configuration errors and 106 incorrect configurations on real-world drones. I would appreciate it if you could answer this question. — Reply to this email directly, view it on GitHubhttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FBlackJocker1995%2Fuavga%2Fissues%2F2&data=05|01||b02aad92729a4b57aa6a08da21fa9239|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637859657341993369|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=mP82zFuLAe7g641cJzhgj6o%2BbpXjO3It55b%2FcrpXorg%3D&reserved=0, or unsubscribehttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FADRXMHYZC7VTDAHK7EMZBZLVF2MSDANCNFSM5TYSUALA&data=05|01||b02aad92729a4b57aa6a08da21fa9239|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637859657341993369|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=Nl7xW3wgTVJ4jjgV8OxqKFAHTmGTQYHn01OOdiVj7Ao%3D&reserved=0. You are receiving this because you are subscribed to this thread.Message ID: @.>

Did these different configurations are randomly make?

If you want to understand how a configuration creates, you can explore the  Searching Process in section 3.4 Learning-Guided Mutation Searcher

If you want to understand how a configuration creates, you can explore the Searching Process in section 3.4 Learning-Guided Mutation Searcher

Thank you very much for your reply, section 3.4 is indeed a difficult part to understand, I will continue to read this part.


Fix memory leak during reach set computation

There is a memory leak caused by the usage of shared_ptr in the child and parent list of ReachNode.
Replace usage of shared_ptr in the vectors by weak_ptr to avoid circular ownership.
All reach nodes are now correctly deconstructed after the containing ReachSet is out of scope.

Hi,
thank you very much for your contribution. I merged your changes manually to run them through our internal CI pipeline first. Thus, I will close this PR now.


Add example script for converting tiff stack from a mounted google drive to zarr

This script assumes that the google drive folder has been locally synced.
The input (google drive) and output folders are read from environment variables.
This script currently errors with:
ValueError: axes don't match array

We suspect this has somehow to do with the chunking.

Sorry, accidentally opened the PR on the upstream instead of the fork. Closing...


User root option

give the user the ability to set if the account has root access to determine which options will work or not

Did you finish this while playing with the root ssh? @ecthros

Did you finish this while playing with the root ssh? @ecthros

No - I don't want to require the user to have ssh and it feels dangerous to set it up for them - it'd be very obvious to anyone looking through the ssh config files. Lemme know what you think

No - I don't want to require the user to have ssh and it feels dangerous to set it up for them - it'd be very obvious to anyone looking through the ssh config files. Lemme know what you think

How do you mean? I think this issue was originally for users to be able to set whether they want their SSH commands to run as root or not


Automatically add event description when scheduling a command

Description
This code will use the command description as event description. This could be useful when listing all scheduled commands.
Before
$schedule->command(Command::class)
    ->description((new Command())->getDescription())
    ->daily();

After
$schedule->command(Command::class)
    ->daily();

The code above will output the same result when running php artisan schedule:list.

Thanks for contributing to Laravel! ❤


Feature request more 64x32 options

Hi.
I am very new to esp32 boards. I've been using matrix 64x32 and 64x64 boards for a year or so with raspberry pi pico.  I found your project and wow it's so simple to plug, install and play. Downside to clockwise atm is it only has one (Tetris) 64x32 option. Can anyone please add to the 64x32 library please please please. A simple clock, and/or clock & date possibly with a brightness slider and colour picker.
If not I completely understand and thanks anyhow 😊.
Side note, my 64x64 matrix panel doesn't have a D pin, just labeled GND, so I can't get it to work. I followed the pin out and I get the image but,(if split in 4 top to bottom) the top and 3rd only showing the image.
I just have the esp32, jumper wires and the matrix, nothing else and I can't buy other hardware for a while as I've spent way too much already. TMI, but in case it was going to be suggested.
Thanks!!!!

Hi, here is a few boards. There are 34 chips, let me know which ones you'd need.

SM5166 is a miltiplexor of the standard "three_to_eight" type, the Sm16208 is a LED driver.
As a conclusion, this is a normal panel, that should work fine with the library.

But yet it doesn't for some reason. I hand wired it with jumper wires one at a time, I also used the 16 wire ribbon the panel came with. Is it possible it's the esp32?

Fully appreciate your attempt. I'll upload a photo of what the panel looks like after I wire it up again and install a clock.

I got the 64x64 working. My jumper wires and ribbon that came with the panel seemed to be the culprit. I found some jumpers I bought a while back, opened the package, wired both up and bingo! Very sorry to trouble you all with what apparently was a non-issue. But I'm still looking for projects for the 64x32 that are plug and play like the Tetris clock.

Hey guys! @Steph1116 I think your problem is not far to be solved. I have been working in a clockface where you can draw the clock the way you want just using this editor https://editor.clockwise.page/
For a while it will work for 64x64 because this value is hardcoded in the firmware, but is something easy to change here
Please, if you want, try to setup the dev environment (you will have to recompile the project) and I can give you some support

Hey @jnthas Thanks for replying. My problem with that is I'm far from understanding all of that. At the moment I understand plug and play. I'm learning as I go, but I'm far from throwing in anything close to looking like a clock for quite some time.  My end goal is to have a clock that is white during the day and red at night (10pm-6am). It would be date (Sept 26 '23) and time (12-hour) and maybe a third row for weather, conditions and temp. But as mentioned, I'm far from creating something like that myself. I truly truly appreciate all the hard work everyone puts into these project, and i wish one day I could contribute to it. Thanks!!!

Oh, and with the clocks that are currently on clockwise, and the Tetris clock, do they have the option to turn off the led on the esp32 itself?

Ok @Steph1116, no problem! Keep visiting us because I think it's something possible to do it and maybe someone can help with this. There is no parameter to turnoff the builtin led for now.

Thanks! Do you take care of both the 64x64 and 64x32 projects?

Nope. @witnessmenow that developed the Tetris clock

Awesome, I'll contact him. Do you know how to turn off the onboard LED's on the esp32 through clockwise?


FR: Notify on the colorscheme that was selected

It would be nice to show a simple message with the color scheme that Colorbox selected 🙂
Of course this could be disabled in the config with some property, but IMO it should be enabled by default. Of course, we can use colorscheme but given it will give it an extra touch to the plugin.
require("colorbox").setup {
    notify = true,
}

hi @marcelarie ,
I add a hook function 'post_hook' to allow user to execute lua function after a policy is triggered and a colorscheme is applied.
You can use that to do the notification.
Please refer to docs: https://github.com/linrongbin16/colorbox.nvim?tab=readme-ov-file#hook

Thanks!


Is the pretrained model 20000.tar is trained on DTU dataset or the BlendedMVS dataset?

Thanks for your nice work!
Is the pre-trained model 20000.tar is trained on the DTU dataset or the BlendedMVS dataset? I directly use the pre-trained model 20000.tar and the sh/tnt.sh script and the fusion.py only get an F-score 55.97 on Tanks and Temples, is there any hyper-parameters that need to change?

Hi, are you using the provided preprocessed TnT test set with provided sfm result instead of the one from colmap?

Thanks for your reply. I use the preprocessed TnT test set which is downloaded from the repo of YoYo000/MVSNet. Besides, I want to confirm that is the pre-trained model 20000.tar is trained on the DTU dataset or the BlendedMVS dataset?

it's trained on BlendedMVS

OK, thanks very much! Is there any methods to obtain the results shown on the leaderboard of TnT by the fusion script?

We are working on a better re-implementation of the fusion code. We will release it soon.

OK, thanks!


Jhonatan/test/pr

Fixes #
Description

Specific Changes

Testing

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.4%) to 84.124%

Totals

Change from base Build<PHONE_NUMBER>:
-0.4%

Covered Lines:
20332

Relevant Lines:
22880

💛  - Coveralls


Vue 3 + Vite compatibility

Hey there 👋
We are migrating our Vue 2 + Vue CLI application to a Vue 3 + Vite application.
We are struggling with adapting Plotly to this new system.
Does someone have a way to make Plotly Vue 3 + Vite compatible?
Thanks

Have you solved the problem?

Have you solved the problem?

try https://github.com/VanOord/vue3-plotly


Bumping down minimum java support from 8 to 7

Description
As a follow up of #12955 , changing the source and target version of Maven compiler plugin to 1.7
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.

[x] Changes are complete (i.e. I finished coding on this PR)
[x] All changes have test coverage:

@nswamy @andrewfayres @lanking520

@piyushghai Thanks for the contribution!
@mxnet-label-bot [pr-awaiting-merge]


Visualizer/NodeJS doesn't enforce required "text" property on TextBlock

Reported by

Teams is finding these issues to be a big problem, cards work fine in App Studio but not on Mobile due to these differences

Platform
What platform is your issue or question related to? (Delete other platforms).

JavaScript
Visualizer

Author or host
Author
Version of SDK
1.1
Issue
On TextBlock, the text property is required. Thus, parsing should fail if it's not included.
However, the Visualizer displays the payload without any errors or warnings. When I use this payload in Timeline (which uses UWP renderer), the payload fails since the text property is missing.
Here's the repro payload. Notice the first text block doesn't have a text property.
{
  "type": "AdaptiveCard",
  "backgroundImage": "https://picsum.photos/600/250?image=1076",
  "body": [
    {
      "type": "TextBlock",
      "height": "stretch"
    },
    {
      "type": "TextBlock",
      "size": "Large",
      "text": "Angela Chin"
    },
    {
      "type": "TextBlock",
      "spacing": "Small",
      "text": "Video call ᛫ 1 m 40 s"
    }
  ],
  "$schema": "http://adaptivecards.io/schemas/adaptive-card.json",
  "version": "1.0"
}

JS renderer is behaving as Adaptive was originally designed - a TextBlock with an empty text property (e.g. "text": "") is valid and causes the TextBlock to simply be dropped. Omitting the text property has the same result. I don't think this is a bug nor that it should be "fixed".

We  need to talk about what "required in the schema" means really.. And that should be documented and then enforced

Closing as part of the bigger required property consistent issue #3154


The example does not work in the latest vs 2022

I get the following error
Uncaught TypeError: Failed to resolve module specifier "jquery". Relative references must start with either "/", "./", or "../".

@SouminiTvmap -- Soumini, thank you for your feedback.  This repo is solely for documentation issues, and this is implementation-related.  Please consider these resources:

Ask a question or find an answer on the Microsoft Q&A page for Visual Studio.
Check the Visual Studio MSDN Forum.
Stack Overflow
Reddit

I am closing this issue now.  You are welcome to @ mention me for any followup.  We hope to hear from you again.


test: expanded storage integration tests

Fixes #N/A
Description
This PR expands upon the existing storage integration tests in light of https://github.com/kubernetes-sigs/karpenter/pull/783.
How was this change tested?
make e2etest
Does this change impact docs?

[ ] Yes, PR includes docs updates
[ ] Yes, issue opened: #
[x] No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 82.489%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
4918

Relevant Lines:
5962

💛  - Coveralls


[Feature] TraitDefinition should tell if it will restart the workload pod

Is your feature request related to a problem? Please describe.
Now when we deploy/upgrade an Application, only change some fields of trait , we don't know whether the underlying pod will restart or not, we should let the TraitDefinition tell.
Describe the solution you'd like

Describe alternatives you've considered

Additional context

I think this is more like a description field at the beginning. So we probably could add a field like this:
TraitDefinition:
  spec:
    podDisruptive: false | true

In the future, we can have more complex policy to indicate whether we allow such traits to apply during production runtime.

Yes, I think a flag is enough, for extensibility, what about a string type for this flag?
TraitDefinition:
  spec:
    podDisruptive: yes | no | unknown

By default, it's unknown.

add field into traitdefinition
display in cli
add docs

\cc @yangsoon


Update WATCH area from debugger

I have the following problem:
There is data in the WATCH area. This is updated on every debug step.
So far, so good.
How is it possible to update this programmatically.
In my case the user has the possibility to change data in a memory dump in a WebView.
When he does so the WATCH area is not updated because it is not informed to do so.
Is there any possibility to update the WATCH area initiated by the extension?
Is there a message I can send via the debug adapter protocol to do so?

@maziac thanks for providing feedback. As @connor4312 has mentioned an invalidated event should hopefully just work.
Also make sure to send to send the areas = ['variables'] as part of your invalidated event.
Here's how we handle that in vscode https://github.com/microsoft/vscode/blob/fc5f18691dcfd22952c4c2d7cdfb2ae5102535eb/src/vs/workbench/contrib/debug/browser/debugSession.ts#L1021
If this still does not work, it would be great if you create a fork of mock-debug that reproduces this problem, so I can simply clone your fork of mock-debug and investgiate more on my machine.
Thanks!

@maziac thanks for providing feedback. As @connor4312 has mentioned an invalidated event should hopefully just work.
Also make sure to send to send the areas = ['variables'] as part of your invalidated event.
Here's how we handle that in vscode https://github.com/microsoft/vscode/blob/fc5f18691dcfd22952c4c2d7cdfb2ae5102535eb/src/vs/workbench/contrib/debug/browser/debugSession.ts#L1021
If this still does not work, it would be great if you create a fork of mock-debug that reproduces this problem, so I can simply clone your fork of mock-debug and investgiate more on my machine.
Thanks!

Yes, ['variables'] seems to do the trick.
Do you have some explanation for it?
I would guess that invalidate without an info would update 'all'. Why does it work if I narrow the request?
And why do I have to use 'variables' and not 'watch'?
From the docs: "If this property is missing, empty, or if values are not understand the client should assume a single value 'all'"
I tried also a value of 'all' and that does not work either.
What other areas do exist? The documentation does not mention them.

Yes, ['variables'] seems to do the trick.
Do you have some explanation for it?
I would guess that invalidate without an info would update 'all'. Why does it work if I narrow the request?
And why do I have to use 'variables' and not 'watch'?
From the docs: "If this property is missing, empty, or if values are not understand the client should assume a single value 'all'"
I tried also a value of 'all' and that does not work either.
What other areas do exist? The documentation does not mention them.

Yeah, the code here is the reason https://github.com/microsoft/vscode/blob/f434f853aafc3f768bc5d34cff0305576cf61e96/src/vs/workbench/contrib/debug/browser/debugSession.ts#L1022
I can change it to also handle the 'watch' as the area. Thus assigning to January

Yeah, the code here is the reason https://github.com/microsoft/vscode/blob/f434f853aafc3f768bc5d34cff0305576cf61e96/src/vs/workbench/contrib/debug/browser/debugSession.ts#L1022
I can change it to also handle the 'watch' as the area. Thus assigning to January

I have pushed a change that now you can aslo send  watch as part of the areas.
The reason why we handle it like that is that if the area is not specified that means a "hard refresh" and we will refatch the threads. I would guess that for your debug adapter refatching threads changes some ids and thus it is no longer possible to expand some watch values.
However I would not be happy making more changis in this area since Java debugger depends on this behavior, thus closing this for now, and I suggest that you simply send the areas array.

I have pushed a change that now you can aslo send  watch as part of the areas.
The reason why we handle it like that is that if the area is not specified that means a "hard refresh" and we will refatch the threads. I would guess that for your debug adapter refatching threads changes some ids and thus it is no longer possible to expand some watch values.
However I would not be happy making more changis in this area since Java debugger depends on this behavior, thus closing this for now, and I suggest that you simply send the areas array.


[gdal] Delete useless pdbs in lib directory

Fixes #25422.

So the PDBs in the release dir have everything needed to also debug the libs in the debug dir, despite different definitions of some types? Anyways, these changes are obsolete with the switch to CMake.

They are needed. It's just that there are two pairs of them: one pair is in bin and lib and the other is in debug/bin and debug/lib. PDB's that are actually used are in bin and debug/bin. In previous version of the port only one duplicate was removed.

No, pdbs are only installed in lib, vcpkg_copy_pdbs will copy them into bin but will not delete them in lib.


Second display is blank in 2.0.0beta1

General troubleshooting tips
Before logging an issue please check that:

[ ] You have the latest version installed (There may be a beta version that fixes your issue), see here for the latest releases and bug fixes: https://github.com/JohnCoates/Aerial/releases
[ ] Your issue isn't already mentioned in our issues. You may find a workaround there or a similar request already made.
[ ] Your problem isn't mentioned in the troubleshooting page.

If none of this fixes your issue, tell us about the problem you are experiencing or the feature you'd like to request.
Required information
In order to help us sort your issue, we ask that you provide the following information:

[ ] Mac model: 2018 MBP 13 (Intel Iris Plus Graphics 655)
[ ] macOS version: 10.15.6
[ ] Monitor setup: 2 x LG Ultrafine 4k (TB3).  Lid closed on laptop.  2 active displays.

If appropriate, please enable Debug mode and Log to disk in Advanced tab and replicate your bug, then attach the AerialLog.txt file (You can access this file through the Advanced tab).
Description of issue / Feature request
Congrats on getting to 2.0 - the UI looks nice !
Just installed 2.0.0beta1.  Was on 1.9.2 (?) before, both displays working as expected (I run with all displays, independent).  In 2.0.0beta1 - my secondary display stays black.  I have tried toggling the display setting as well to no avail.  Rebooted as well.  Will attach the AerialLog.txt file once I submit.  Thanks.

AerialLog.txt

Hi @vom513
Looks like I broke that specific mode 🙈 I just checked here and replicated your issue, I'll track it down tomorrow, sorry about that. All the other modes work fine, which is even more weird, but I suggest you switch to one of those in the meantime. Thanks for the report !

Oh wow - thanks for the super quick reply !  No worries at all, glad you were able to confirm/replicate it at least.

FYI I found the bug, it was the same bug that caused the sidebar to not be expanded at startup in beta 1 !
I'll put up a beta 2 tonight with that fix amongst others.

@vom513 took a bit longer than I thought but build is here with the fix : https://github.com/JohnCoates/Aerial/releases/tag/v2.0.0beta2

Yep - looks good now.  Thanks much !


ResponseClass

Hey, I was hoping you could help figure out this issue.
So far I have been able to get everything setup except the output class. Here is my SOAP Response:

and here are a couple of the response classes I've tried:

 @JSoapClass(namespace = "http://XXX.com/")
 public class Person {

 @JSoapAttribute(name = "First")
 private String first;

 @JSoapAttribute(name = "Last")
 private String last;

 @JSoapAttribute(name = "ConfigProfileId")
 private String profileId;

 @Override
 public String toString() {
     return "\n\nAgentName: " + first + " " + last +
             "\nCRMProfile ID: " + profileId;
 }

}

@JSoapClass(namespace = "http://XXX.com/")
 public class Person extends SOAPDeserializable {

 @JSoapResField(name = "Person")
 private Person person;

 @Override
 public String toString() {
     return person.toString();
 }

 public class Person extends SOAPDeserializable {

     @JSoapResField(name = "PersonName")
     private PersonName personName;

     @JSoapResField(name = "PeopleConfigProfile")
     private PeopleConfigProfile peopleConfigProfile;

     @Override
     public String toString() {

         return "\n\nAgentName: " + personName.first + " " + personName.last +
             "\nCRMProfile ID: " + peopleConfigProfile.profileId;
     }

     public class PersonName extends SOAPDeserializable{

         @JSoapAttribute(name = "First")
         public String first;

         @JSoapAttribute(name = "Last")
         public String last;
     }

     public class PeopleConfigProfile extends SOAPDeserializable{

         @JSoapAttribute(name = "ConfigProfileId")
         public String profileId;
     }
 }

}

I've tried alot of different variations but haven't been able to build an output class yet. In your .Readme and example, you don't discuss how to extract attributes from an xml tag, like extracting First and Last from . The only output I am getting is a System.out saying "there." and the Callback success/failure won't trigger. Also, in your Readme your response class extends SOAPDeserializable but in your example class, WeatherReturn does not. Also, you made some changes/updates for a version 1.0.1 and 1.0.2 but your Readme gradle compile statement says 1.0.0. Which version should I be using?
Thanks for your time.

I did a little more digging and found something interesting. In SoapManager.get, there is a line:
Object o = envelope1.getResponse();
According to my debugger, o was an instance of SoapPrimitive but failed all of your Object Primitive checks, so get() simply returned null and never called callback.onSuccess or callback.onError. My temporary solution was to make my outputClass null and then use the Java XMLPullParser library to parse out the values I needed. If you want to work/collaborate on this issue some more, let me know. After all of the digging I did, I am more than intrigued by this project.

Hi there!
Thanks for the feedback. Later today or this weekend I'll address this issue :)
João

Sorry about that, You're correct in thinking that it is a typo. I was able to pass null as the output class and use the Java XMLPullParser class parse out the relevant data I needed, but I am still curious about    how to design a proper output class.


Improve SNI package architecture and targets file design

I am pulling my hair out trying to figure out why SNI.x64.dll isn't getting copied to my output directory on build.
i believe the issue has something to do with x86 vs x64 wow process virtualization, but I don't know how to prove it. Our TeamCity account runs as a MSA Group Principal DOMAINNAME\msaTeamCity$ and that users package cache is C:\Users\msaTeamCity$\.nuget\packages\microsoft.data.sqlclient.sni\5.2.0\
When I use msbuild binlogging, I see CopySNIFiles silently fails

After CopySNIFiles runs, can anything blow it away?
Why would this work on the same machine as a different user?
Would using the new dotnet 8 artifacts path solve this problem?

I think this is probably the root cause of a litter of issues people have, although I suspect there is even more that can be cleaned up here. Such discussion is probably best saved for a WhatsApp or Discord voice call.

I have tried directly referencing Microsoft.Data.SqlClient and separately Microsoft.Data.SqlClient.SNI and neither one gets copied.
CopySNIFiles doesn't get run when running under a MSA Group account. I don't understand why, although I also really doubt i would have written the SNI.targets file this way.

The issue seems to be that, when running on the build server, OutDir has a different value which includes the TargetFramework.
We have a csproj with:
<Project Sdk="Microsoft.NET.Sdk">
  <PropertyGroup>
    <TargetFramework>net48</TargetFramework>
    <AppendTargetFrameworkToOutputPath>false<AppendTargetFrameworkToOutputPath>
    <AppendRuntimeIdentifierToOutputPath>false</AppendRuntimeIdentifierToOutputPath>
  </PropertyGroup>

  <ItemGroup>
    <PackageReference Include="Microsoft.Data.SqlClient" Version="5.2.2" />
  </ItemGroup>
</Project>

This results in OutDir evaluating to bin\Release\net48 but ONLY due to SNI targets getting evaluated at restore time, which apparently somehow ignores the above AppendX prperties.

The issue seems to be that, when running on the build server, OutDir has a different value, which includes the TargetFramework.
We have a csproj with:
<Project Sdk="Microsoft.NET.Sdk">
  <PropertyGroup>
    <TargetFramework>net48</TargetFramework>
    <AppendTargetFrameworkToOutputPath>false<AppendTargetFrameworkToOutputPath>
    <AppendRuntimeIdentifierToOutputPath>false</AppendRuntimeIdentifierToOutputPath>
  </PropertyGroup>

  <ItemGroup>
    <PackageReference Include="Microsoft.Data.SqlClient" Version="5.2.2" />
  </ItemGroup>
</Project>

This results in OutDir evaluating to bin\Release\net48 but ONLY due to SNI targets getting evaluated at restore time, which apparently somehow ignores the above AppendX properties.

@ErikEJ Why doesn't Microsoft.Data.SqlClient.SNI package things the way Microsoft recommends as best practice? https://learn.microsoft.com/en-us/nuget/create-packages/supporting-multiple-target-frameworks
In comparing what your team is doing to what Grpc.Core does , they seem to be exactly following the best practices.
I actually can't find where Microsoft.Data.SqlClient.SNI.targets is defined in this repository, so I can't even submit a PR to rewrite the thing to follow best practices.

@jzabroski
I tested your csproj in a standalone project and I don't face any issues, and SNI files are being copied in output folder alongside other binaries as expected. You must note the 'buildTransitive' folder is where the files will be copied from in this case.

[Please open the child Task in your screenshot, you should find this IMO]
Using buildTransitive folder is the recommended way for Native dependencies (ref: Native files in .NET packages) and targets file is definitely loaded otherwise the target 'CopySNIFiles' wouldn't be running in your env.

The issue seems to be that, when running on the build server, OutDir has a different value, which includes the TargetFramework.

Why is this the case in your build server? Are you modifying it manually?

See also https://github.com/dotnet/msbuild/issues/10973

To support all systems, I think there are a couple of basic scenarios.
I don't believe SNI supports Linux or Mac OSX, so there would be no folders for those.
The only issue I am not confident that would be resolved by the rewrite is the IIS shadow copy issue. I personally don't actually understand that issue, although I may have to deal with it next but doubt it as I use Octopus Deploy for IIS deployments and they have written robust logic to stop App Pools that Visual Studio right-click deploy does not do.
I am currently trying to figure out a workaround that will allow the MSA Group Principal to copy these files. Otherwise, I have to revert 120+ files related to moving from System.Data.SqlClient and stay on that for as long as it takes to resolve this issue. That is not ideal as EntityFramework 6.5.1 seems incompatible with System.Data.SqlClient (lazy loading is now broken, and @ErikEJ  suggested I upgrade to Microsoft.Data.SqlClient).

You can include these DLLs directly in your csproj as the targets file in Grpc.Core is doing fyi, have you tried with that?

I basically tried that already. The following did not work running as a MSA Group Principal but did work locally.
<Project Sdk="Microsoft.NET.Sdk">
  <!-- ReSharper disable UnknownProperty -->
  <PropertyGroup>
    <AssemblyTitle>Weiss.Panda.TaskRunner</AssemblyTitle>
    <TargetFramework>net48</TargetFramework>
    <OutputType>Exe</OutputType>
    <AppendTargetFrameworkToOutputPath>false</AppendTargetFrameworkToOutputPath>
    <AppendRuntimeIdentifierToOutputPath>false</AppendRuntimeIdentifierToOutputPath>
    <AutoGenerateBindingRedirects>true</AutoGenerateBindingRedirects>
    <GenerateBindingRedirectsOutputType>true</GenerateBindingRedirectsOutputType>
    <CopySNIFiles>false</CopySNIFiles> <!-- THIS IS WHERE I DISABLE the SNI.targets BEHAVIOR -->
  </PropertyGroup>

  <ItemGroup>
    <PackageReference Include="Microsoft.Data.SqlClient.SNI" Version="5.2.0" GeneratePathProperty="true" />
  </ItemGroup>

  <Target Name="SNITest" AfterTargets="CopySNIFiles">
    <Message Text="Files: @(SNIFiles)" />
    <Message Text="DLL Files: @(SNIDllFiles)" />
  </Target>

  <ItemGroup>
    <None Include="$(PkgMicrosoft_Data_SqlClient_SNI)\buildTransitive\net462\*"
          Exclude="$(PkgMicrosoft_Data_SqlClient_SNI)\buildTransitive\net462\*.targets"
          CopyToOutputDirectory="PreserveNewest"
          Pack="true"
          PackagePath="" />
  </ItemGroup>
</Project>

This produces the following trace in binlog:

I still don't understand what exactly are you doing with the MSA Group Principal (I'm not familiar with what its used for), is it a build or publish step that is not working?

An MSA Group Principal is just a special account that has no password. You simply tell your Active Directory Domain Controller that a specific Machine SID is associated with a particular account, and that account is a principal on that Machine SID. Once they become linked, you no longer need a password to login. From a cybersecurity policy perspective, this is preferred to running as NT AUTHORITY\System as it can have less trust.
We've actually been running Team City this way for about 5 years, and this is the first time I have encountered this weird issue.  To say I am curious as to what the root cause is, is an understatement.

No, we don't as we use DevOps workflows designed to spin up environment on demand.
It seems more like an MsBuild issue to me when working with MSA accounts than ours. I hope you get the right support from them.

I can confirm that adding a PowerShell script to copy the files to some random directory on the same drive has the same behavior as your targets, so I don't actually think the failure is because of how you coded the targets.
I think there may be some subtle difference between the PE Headers in your P/Invoke dll and Grpc.Core's P/Invoke dll.  I am not an expert in PE Headers though, and not sure how filesystem virtualization uses PE Headers if at all as a "magic string" in the header of the file, similar to how Nepomuk-KDE works in userland on Linux but in kernelspace on Windows.
$dest = "d:\logs\TeamCity"
$source = Join-Path $env:USERPROFILE -ChildPath ".nuget" | Join-Path -ChildPath "packages" | Join-Path -ChildPath "microsoft.data.sqlclient.sni" | Join-Path -ChildPath "5.2.0"
Write-Host $source
if (Test-Path $source) {
  # Copy all files from the source directory to the destination directory
  $copyErrors = $null
  Copy-Item -Path "$source\*" -Destination $dest -Recurse -Force -Verbose -ErrorVariable +copyErrors
  Write-Host "Files have been copied from '$source' to '$dest'."
  Write-Host "Errors: $copyErrors"
}

Outputs:
15:14:41  PowerShell Executable: C:\Windows\System32\WindowsPowerShell\v1.0\powershell.exe
15:14:41   Working directory: D:\BuildAgent\work\77094892e16807fb
15:14:41   Command: C:\Windows\System32\WindowsPowerShell\v1.0\powershell.exe
15:14:41   PowerShell arguments: -NoProfile, -NonInteractive, -ExecutionPolicy, ByPass, -File, D:\BuildAgent\temp\buildTmp\powershell10788514782847466008.ps1
15:14:41   C:\Users\msaTeamCity$\.nuget\packages\microsoft.data.sqlclient.sni\5.2.0
15:14:41   VERBOSE: Performing the operation "Copy Directory" on target "Item:
15:14:41   C:\Users\msaTeamCity$\.nuget\packages\microsoft.data.sqlclient.sni\5.2.0\build Destination: D:\logs\TeamCity\build".
15:14:41   VERBOSE: Performing the operation "Create Directory" on target "Destination: D:\logs\TeamCity\build".
15:14:41   VERBOSE: Performing the operation "Copy Directory" on target "Item:
15:14:41   C:\Users\msaTeamCity$\.nuget\packages\microsoft.data.sqlclient.sni\5.2.0\build\net462 Destination:
15:14:41   D:\logs\TeamCity\build\net462".
15:14:41   VERBOSE: Performing the operation "Create Directory" on target "Destination: D:\logs\TeamCity\build\net462".
15:14:41   VERBOSE: Performing the operation "Copy File" on target "Item:
15:14:41   C:\Users\msaTeamCity$\.nuget\packages\microsoft.data.sqlclient.sni\5.2.0\build\net462\Microsoft.Data.SqlClient.SNI.arm6
15:14:41   4.dll Destination: D:\logs\TeamCity\build\net462\Microsoft.Data.SqlClient.SNI.arm64.dll".
15:14:41   VERBOSE: Performing the operation "Copy File" on target "Item:
15:14:41   C:\Users\msaTeamCity$\.nuget\packages\microsoft.data.sqlclient.sni\5.2.0\build\net462\Microsoft.Data.SqlClient.SNI.arm6
15:14:41   4.pdb Destination: D:\logs\TeamCity\build\net462\Microsoft.Data.SqlClient.SNI.arm64.pdb".
15:14:41   VERBOSE: Performing the operation "Copy File" on target "Item:
15:14:41   C:\Users\msaTeamCity$\.nuget\packages\microsoft.data.sqlclient.sni\5.2.0\build\net462\Microsoft.Data.SqlClient.SNI.targ
15:14:41   ets Destination: D:\logs\TeamCity\build\net462\Microsoft.Data.SqlClient.SNI.targets".
15:14:41   VERBOSE: Performing the operation "Copy File" on target "Item:
15:14:41   C:\Users\msaTeamCity$\.nuget\packages\microsoft.data.sqlclient.sni\5.2.0\build\net462\Microsoft.Data.SqlClient.SNI.x64.
15:14:41   dll Destination: D:\logs\TeamCity\build\net462\Microsoft.Data.SqlClient.SNI.x64.dll".
15:14:41   VERBOSE: Performing the operation "Copy File" on target "Item:
15:14:41   C:\Users\msaTeamCity$\.nuget\packages\microsoft.data.sqlclient.sni\5.2.0\build\net462\Microsoft.Data.SqlClient.SNI.x64.
15:14:41   pdb Destination: D:\logs\TeamCity\build\net462\Microsoft.Data.SqlClient.SNI.x64.pdb".
15:14:41   VERBOSE: Performing the operation "Copy File" on target "Item:
15:14:41   C:\Users\msaTeamCity$\.nuget\packages\microsoft.data.sqlclient.sni\5.2.0\build\net462\Microsoft.Data.SqlClient.SNI.x86.
15:14:41   dll Destination: D:\logs\TeamCity\build\net462\Microsoft.Data.SqlClient.SNI.x86.dll".
15:14:41   VERBOSE: Performing the operation "Copy File" on target "Item:
15:14:41   C:\Users\msaTeamCity$\.nuget\packages\microsoft.data.sqlclient.sni\5.2.0\build\net462\Microsoft.Data.SqlClient.SNI.x86.
15:14:41   pdb Destination: D:\logs\TeamCity\build\net462\Microsoft.Data.SqlClient.SNI.x86.pdb".
15:14:41   VERBOSE: Performing the operation "Copy Directory" on target "Item:
15:14:41   C:\Users\msaTeamCity$\.nuget\packages\microsoft.data.sqlclient.sni\5.2.0\buildTransitive Destination:
15:14:41   D:\logs\TeamCity\buildTransitive".
15:14:41   VERBOSE: Performing the operation "Create Directory" on target "Destination: D:\logs\TeamCity\buildTransitive".
15:14:41   VERBOSE: Performing the operation "Copy Directory" on target "Item:
15:14:41   C:\Users\msaTeamCity$\.nuget\packages\microsoft.data.sqlclient.sni\5.2.0\buildTransitive\net462 Destination:
15:14:41   D:\logs\TeamCity\buildTransitive\net462".
15:14:41   VERBOSE: Performing the operation "Create Directory" on target "Destination: D:\logs\TeamCity\buildTransitive\net462".
15:14:41   VERBOSE: Performing the operation "Copy File" on target "Item:
15:14:41   C:\Users\msaTeamCity$\.nuget\packages\microsoft.data.sqlclient.sni\5.2.0\buildTransitive\net462\Microsoft.Data.SqlClien
15:14:41   t.SNI.arm64.dll Destination: D:\logs\TeamCity\buildTransitive\net462\Microsoft.Data.SqlClient.SNI.arm64.dll".
15:14:41   VERBOSE: Performing the operation "Copy File" on target "Item:
15:14:41   C:\Users\msaTeamCity$\.nuget\packages\microsoft.data.sqlclient.sni\5.2.0\buildTransitive\net462\Microsoft.Data.SqlClien
15:14:41   t.SNI.arm64.pdb Destination: D:\logs\TeamCity\buildTransitive\net462\Microsoft.Data.SqlClient.SNI.arm64.pdb".
15:14:41   VERBOSE: Performing the operation "Copy File" on target "Item:
15:14:41   C:\Users\msaTeamCity$\.nuget\packages\microsoft.data.sqlclient.sni\5.2.0\buildTransitive\net462\Microsoft.Data.SqlClien
15:14:41   t.SNI.targets Destination: D:\logs\TeamCity\buildTransitive\net462\Microsoft.Data.SqlClient.SNI.targets".
15:14:41   VERBOSE: Performing the operation "Copy File" on target "Item:
15:14:41   C:\Users\msaTeamCity$\.nuget\packages\microsoft.data.sqlclient.sni\5.2.0\buildTransitive\net462\Microsoft.Data.SqlClien
15:14:41   t.SNI.x64.dll Destination: D:\logs\TeamCity\buildTransitive\net462\Microsoft.Data.SqlClient.SNI.x64.dll".
15:14:41   VERBOSE: Performing the operation "Copy File" on target "Item:
15:14:41   C:\Users\msaTeamCity$\.nuget\packages\microsoft.data.sqlclient.sni\5.2.0\buildTransitive\net462\Microsoft.Data.SqlClien
15:14:41   t.SNI.x64.pdb Destination: D:\logs\TeamCity\buildTransitive\net462\Microsoft.Data.SqlClient.SNI.x64.pdb".
15:14:41   VERBOSE: Performing the operation "Copy File" on target "Item:
15:14:41   C:\Users\msaTeamCity$\.nuget\packages\microsoft.data.sqlclient.sni\5.2.0\buildTransitive\net462\Microsoft.Data.SqlClien
15:14:41   t.SNI.x86.dll Destination: D:\logs\TeamCity\buildTransitive\net462\Microsoft.Data.SqlClient.SNI.x86.dll".
15:14:41   VERBOSE: Performing the operation "Copy File" on target "Item:
15:14:41   C:\Users\msaTeamCity$\.nuget\packages\microsoft.data.sqlclient.sni\5.2.0\buildTransitive\net462\Microsoft.Data.SqlClien
15:14:41   t.SNI.x86.pdb Destination: D:\logs\TeamCity\buildTransitive\net462\Microsoft.Data.SqlClient.SNI.x86.pdb".
15:14:41   VERBOSE: Performing the operation "Copy File" on target "Item:
15:14:41   C:\Users\msaTeamCity$\.nuget\packages\microsoft.data.sqlclient.sni\5.2.0\.nupkg.metadata Destination:
15:14:41   D:\logs\TeamCity\.nupkg.metadata".
15:14:41   VERBOSE: Performing the operation "Copy File" on target "Item:
15:14:41   C:\Users\msaTeamCity$\.nuget\packages\microsoft.data.sqlclient.sni\5.2.0\.signature.p7s Destination:
15:14:41   D:\logs\TeamCity\.signature.p7s".
15:14:41   VERBOSE: Performing the operation "Copy File" on target "Item:
15:14:41   C:\Users\msaTeamCity$\.nuget\packages\microsoft.data.sqlclient.sni\5.2.0\dotnet.png Destination:
15:14:41   D:\logs\TeamCity\dotnet.png".
15:14:41   VERBOSE: Performing the operation "Copy File" on target "Item:
15:14:41   C:\Users\msaTeamCity$\.nuget\packages\microsoft.data.sqlclient.sni\5.2.0\LICENSE.txt Destination:
15:14:41   D:\logs\TeamCity\LICENSE.txt".
15:14:41   VERBOSE: Performing the operation "Copy File" on target "Item:
15:14:41   C:\Users\msaTeamCity$\.nuget\packages\microsoft.data.sqlclient.sni\5.2.0\microsoft.data.sqlclient.sni.5.2.0.nupkg
15:14:41   Destination: D:\logs\TeamCity\microsoft.data.sqlclient.sni.5.2.0.nupkg".
15:14:41   VERBOSE: Performing the operation "Copy File" on target "Item:
15:14:41   C:\Users\msaTeamCity$\.nuget\packages\microsoft.data.sqlclient.sni\5.2.0\microsoft.data.sqlclient.sni.5.2.0.nupkg.sha51
15:14:41   2 Destination: D:\logs\TeamCity\microsoft.data.sqlclient.sni.5.2.0.nupkg.sha512".
15:14:41   VERBOSE: Performing the operation "Copy File" on target "Item:
15:14:41   C:\Users\msaTeamCity$\.nuget\packages\microsoft.data.sqlclient.sni\5.2.0\microsoft.data.sqlclient.sni.nuspec
15:14:41   Destination: D:\logs\TeamCity\microsoft.data.sqlclient.sni.nuspec".
15:14:41   Files have been copied from 'C:\Users\msaTeamCity$\.nuget\packages\microsoft.data.sqlclient.sni\5.2.0' to 'd:\logs\TeamCity'.
15:14:41   Errors:
15:14:41   Process exited with code 0

Why doesn't Microsoft.Data.SqlClient.SNI package things the way Microsoft recommends as best practice? https://learn.microsoft.com/en-us/nuget/create-packages/supporting-multiple-target-frameworks and https://learn.microsoft.com/en-us/nuget/create-packages/native-files-in-net-packages#native-assets
In comparing what your team is doing to what Grpc.Core does , they seem to be exactly following the best practices, and I don't run into any issues using their library.
I actually can't find where Microsoft.Data.SqlClient.SNI.targets is defined in this repository, so I can't even submit a PR to rewrite the thing to follow best practices.

MDS does package the recommended way when targeting .NET. The problem is you are targeting .NET Framework, which doesn't support all the new, simple packaging stuff. https://learn.microsoft.com/en-us/nuget/create-packages/native-files-in-net-packages#projects-targeting-net-framework
If you want to try improving the targets file, it's in the NuGet package: https://www.nuget.org/packages/Microsoft.Data.SqlClient.SNI/ Open the nupkg file with 7-Zip (or rename the file to .zip) and look in the buildTransitive\net462 folder. All you need to rebuild the package is a complete nuspec file. You can use this:
<?xml version="1.0" encoding="utf-8"?>
<package xmlns="http://schemas.microsoft.com/packaging/2013/05/nuspec.xsd">
  <metadata minClientVersion="2.12">
    <id>Microsoft.Data.SqlClient.SNI</id>
    <version>6.0.0-preview1.24226.4</version>
    <title>Microsoft.Data.SqlClient.SNI</title>
    <authors>Microsoft</authors>
    <requireLicenseAcceptance>true</requireLicenseAcceptance>
    <license type="file">LICENSE.txt</license>
    <projectUrl>https://aka.ms/sqlclientproject</projectUrl>
    <icon>dotnet.png</icon>
    <description>
      Internal implementation package not meant for direct consumption. Please do not reference directly.

When using NuGet 3.x this package requires at least version 3.4.</description>
    <releaseNotes>https://go.microsoft.com/fwlink/?linkid=2090501</releaseNotes>
    <copyright>© Microsoft Corporation. All rights reserved.</copyright>
    <dependencies>
      <group targetFramework="net462" />
    </dependencies>
  </metadata>
  <files>
    <file src="LICENSE.txt" target="" />
    <file src="dotnet.png" target="" />

    <file src="build\net462\Microsoft.Data.SqlClient.SNI.dll" target="build\net462\Microsoft.Data.SqlClient.SNI.x86.dll" />
    <file src="build\net462\Microsoft.Data.SqlClient.SNI.dll" target="build\net462\Microsoft.Data.SqlClient.SNI.x64.dll" />
    <file src="build\net462\Microsoft.Data.SqlClient.SNI.dll" target="build\net462\Microsoft.Data.SqlClient.SNI.arm64.dll" />
    <file src="build\net462\Microsoft.Data.SqlClient.SNI.pdb" target="build\net462\Microsoft.Data.SqlClient.SNI.x86.pdb" />
    <file src="build\net462\Microsoft.Data.SqlClient.SNI.pdb" target="build\net462\Microsoft.Data.SqlClient.SNI.x64.pdb" />
    <file src="build\net462\Microsoft.Data.SqlClient.SNI.pdb" target="build\net462\Microsoft.Data.SqlClient.SNI.arm64.pdb" />
    <file src="build\net462\Microsoft.Data.SqlClient.SNI.targets" target="build\net462" />

    <file src="buildTransitive\net462\Microsoft.Data.SqlClient.SNI.dll" target="buildTransitive\net462\Microsoft.Data.SqlClient.SNI.x86.dll" />
    <file src="buildTransitive\net462\Microsoft.Data.SqlClient.SNI.dll" target="buildTransitive\net462\Microsoft.Data.SqlClient.SNI.x64.dll" />
    <file src="buildTransitive\net462\Microsoft.Data.SqlClient.SNI.dll" target="buildTransitive\net462\Microsoft.Data.SqlClient.SNI.arm64.dll" />
    <file src="buildTransitive\net462\Microsoft.Data.SqlClient.SNI.pdb" target="buildTransitive\net462\Microsoft.Data.SqlClient.SNI.x86.pdb" />
    <file src="buildTransitive\net462\Microsoft.Data.SqlClient.SNI.pdb" target="buildTransitive\net462\Microsoft.Data.SqlClient.SNI.x64.pdb" />
    <file src="buildTransitive\net462\Microsoft.Data.SqlClient.SNI.pdb" target="buildTransitive\net462\Microsoft.Data.SqlClient.SNI.arm64.pdb" />
    <file src="buildTransitive\net462\Microsoft.Data.SqlClient.SNI.targets" target="buildTransitive\net462" />

  </files>
</package>

Just unzip the nupkg, adjust any paths in the nuspec file (I think it will work for you as-is) and run nuget pack Microsoft.Data.SqlClient.SNI.nuspec.

Does setting the MSBuild property ContentSNIFiles to true (i.e. with the MSBuild command line /p:ContentSNIFiles=true) as suggested here make any difference in your results?

@HamsterExAstris Basically yes see https://github.com/dotnet/SqlClient/issues/2998#issuecomment-2472302672 which is a variation... and you can see, in the msbuild binlog, that it picks up the file and says it is copied.
I should figure this out next week.
I'm going to explore the possibility there is a bug in msbuild Copy target next. I believe the number of cores my desktop has is different than the AWS m6.2xlarge we are using as a build server, so it's possible the bug is appearing when a certain number of threads copy data. I really doubt it but I have to rule that out next.

I'm going to try this

$dest = "d:\logs\TeamCity"
$source = Join-Path $env:USERPROFILE -ChildPath ".nuget" | Join-Path -ChildPath "packages" | Join-Path -ChildPath "microsoft.data.sqlclient.sni" | Join-Path -ChildPath "5.2.0"
Write-Host $source
if (Test-Path $source) {
  # Copy all files from the source directory to the destination directory
  $copyErrors = $null
  Copy-Item -Path "$source\*" -Destination $dest -Recurse -Force -Verbose -ErrorVariable +copyErrors
  Write-Host "Files have been copied from '$source' to '$dest'."
  Write-Host "Errors: $copyErrors"
}

with this https://github.com/dotnet/SqlClient/issues/2998#issuecomment-2472302672
https://github.com/dotnet/SqlClient/issues/2998#issuecomment-2477351065
This will take MSBuild Copy target out of the picture and replace it with a
<Target Name="AfterBuild">
    <PropertyGroup>
      <PSScript> paste ps script here
      </PSScript>
    </PropertyGroup>
    <Exec Command="powershell.exe -command "$(PSScript)"" />
  </Target>

This allows me to test a linear array of assumptions about the root cause.

As a follow-up here, I believe the root cause here is that the way Microsoft.Data.SqlClient.SNI is packaged is incompatible with a clean checkout on a build due to how IncrementalClean target works in C:\Program Files\dotnet\sdk\8.0.400\Microsoft.Common.CurrentVersion.targets - it thinks these copied files are from a previous build, so it deletes them.  I have not gotten to the exact reason why it thinks that, but part of the problem is that these files are not included in obj/Release/<YourProjectName>.FileListAbsolute.txt

@David-Engel @cheenamalhotra Would it be possible to add a <FileWrites Include="@(SNIDllFiles)" /> to force these items to be tracked by the build as dependencies. It appears FileWrites is what drives FileListAbsolute.txt, and therefore should fix issues with IncrementalClean. I think if this is the issue, it would address a lot of issues this repo has received over the years.

Would it be possible to add a <FileWrites Include="@(SNIDllFiles)" /> to force these items to be tracked by the build as dependencies. It appears FileWrites is what drives FileListAbsolute.txt, and therefore should fix issues with IncrementalClean. I think if this is the issue, it would address a lot of issues this repo has received over the years.

The easiest way to play with changes to the .targets file is to simply edit the one in your NuGet cache. Example: %USERPROFILE%\.nuget\packages\microsoft.data.sqlclient.sni\6.0.0-preview1.24226.4\buildTransitive\net462\Microsoft.Data.SqlClient.SNI.targets
(You would need to clean project-level package caches for that to propagate.)
Or if you are just working with a single test app, the one cached with that:
%USERPROFILE%\Source\repos\ConsoleAppNetFx\packages\Microsoft.Data.SqlClient.SNI.5.2.0\buildTransitive\net462\Microsoft.Data.SqlClient.SNI.targets
Once you have something that fixes your situation, share the targets file here for others to test.

Did some reading tonight to see if there is an elegant path forward.
One possible thing I will try this week is explicit nuspec assembky <references> https://learn.microsoft.com/en-us/nuget/reference/nuspec#explicit-assembly-references
I'm also going to thoroughly understand why Grpc.Core doesn't give me these issues.
I do appreciate all your help, David and Cheena. Hopefully whatever I come up with makes your team job easier. However, not having the packaging in version control makes it harder to understand each incremental change as there is no audit trail on the issues that effectuate changes.


Crash on second flowgraph plugin call

Using the attached plugin to test out the flowgraph API, it causes binary ninja to segfault the second time I use the plugin (right click an MLIL var and select "Graph backward slice").
I've reproduced on multiple binaries and on builds 1.1.1500-dev and 1.1.1470.
graph_slice.txt

Thanks for the report -- can you confirm whether this only happens in python3?
We believe it's a garbage collection / object lifetime issue for callbacks.
In the meantime, when a flowgraph object is created, you need to keep a reference to the callbacks in a global list to keep it from being collected and triggering the crash.

I encountered this while testing it with python 2.7, but just reproduced it under python 3.

Try moving the FlowGraph object's declaration to the global scope and see if it still happens. I believe there's a garbage collection issue with FlowGraph objects currently

We've actually separately confirmed this, it doesn't seem to be a problem with the callbacks going out of scope.

I can't seem to reproduce this issue any longer, it seems like it was fixed. Can you try to reproduce and confirm?

Oh one of the API's changed so you'll need to change this bit of code
        defining_instructions = [
            function.get_ssa_var_definition(new_var).instr_index for
            new_var in instruction_to_visit.vars_read
            if function.get_ssa_var_definition(new_var) is not None
        ]

Not adding the .instr_index

Scratch that, we do have a repro now :P

The underlying issue is that nodes that are not part of the graph were able to be added as edges without any validation, which caused a crash during layout.
The plugin given here accidentally triggers this case by creating a dict object as a default value in a parameter list. This leads to a common bug in Python code where all calls to the function share the same dict object and thus have unexpected values present.
Fixed in build 1630. An exception is now generated if an invalid edge is added.


On Apple Silicon Machines, it is not working natively.

I don't want to install rosetta 2 for it to work since rosetta 2 causes many swap memory issues
Product and Version [Visual Studio Code 1.60]:
OS Version[macOS Big Sur 11.5.2]:

Closing as a duplicate of #4060.


Live Search

Describe the feature you'd like
I would love to have Live Search implemented for the search box at the top of Bookstack.
Describe the benefits this would bring to existing BookStack users
This would save users a little time when searching for documents.
Can the goal of this request already be achieved via other means?
Right now, you would have to enter your search term, press return, wait for the page to load then click on a result.
With live search you could start typing a keyword and results would immediately show up saving a few seconds per search.
Have you searched for an existing open/closed issue?

[X] I have searched for existing issues and none cover my fundemental request

How long have you been using BookStack?
1 to 5 years
Additional context
No response

@ssddanbrown Ahh predictive search... I looked through the issues for "Live Search" but didn't see it... apparently Predictive Search is the correct term. haha.
Just throwing the request out there as its one of the very few things that bug me more than once a day lol
Thanks!

Okay, thanks for confirming, will therefore close this off.


Implement tooltips for shader uniform in the inspector.

Initially, the implementation was done by modifying shader_language.cpp,look at.
https://github.com/magian1127/godot/commit/49fe127a0a3d92a73af6a387d63a4a0a71c30a8a
However, some issues were discovered, so it was decided to switch to using regular expressions and modify shader.cpp to achieve the desired outcome.
Using /** */ on top of uniform will do the trick.
/**tip
tip2*/
uniform float test1= 2.0;

一开始是修改 shader_language.cpp 来实现的, 代码看这里.
https://github.com/magian1127/godot/commit/49fe127a0a3d92a73af6a387d63a4a0a71c30a8a
但是发现有些问题, 还是改用正则表达式, 以及修改 shader.cpp 来实现.
在 uniform 上面使用 /** */ 就可以实现.

Production edit: This closes https://github.com/godotengine/godot-proposals/issues/7846.

It has now been changed to /** for matching.
Other methods would make multi-line comments, code, and regex all become complicated.

done

Thanks!


Antlr tool works for "abb" grammar, but fails with "cpp" grammar with "implicit definition" warnings.

This one is a little baffling. Attached are the .g4's for the abb grammar and the cpp grammar. Both are split grammars. abb-cpp.zip
The first grammar "abb" builds and tests just fine. I've included the .g4's and a trimmed down build.sh that only invokes the tool.
The second grammar is "cpp". The build.sh first generates the lexer recognizer and the .tokens file. It then calls the Antlr Tool for the CPP14Parser.g4 file. However, this time, the tool outputs some unusual errors:
ken@DESKTOP-DL44R7B:~/grammars-v4/cpp/Generated-Antlr4ng$ bash build.sh
warning(125): CPP14Parser.g4:79:6: implicit definition of token LeftBracket in parser
warning(125): CPP14Parser.g4:79:33: implicit definition of token RightBracket in parser
warning(125): CPP14Parser.g4:6:11: implicit definition of token Dynamic_cast in parser
warning(125): CPP14Parser.g4:6:42: implicit definition of token Static_cast in parser
warning(125): CPP14Parser.g4:6:72: implicit definition of token Reinterpret_cast in parser
warning(125): CPP14Parser.g4:6:107: implicit definition of token Const_cast in parser
warning(125): CPP14Parser.g4:12:60: implicit definition of token Dot in parser
warning(125): CPP14Parser.g4:163:6: implicit definition of token Not in parser
warning(125): CPP14Parser.g4:198:6: implicit definition of token Noexcept in parser
warning(125): CPP14Parser.g4:240:21: implicit definition of token Caret in parser
warning(125): CPP14Parser.g4:303:69: implicit definition of token Default in parser
warning(125): CPP14Parser.g4:401:6: implicit definition of token Static_assert in parser
warning(125): CPP14Parser.g4:436:6: implicit definition of token Explicit in parser
warning(125): CPP14Parser.g4:465:6: implicit definition of token Short in parser
warning(125): CPP14Parser.g4:483:6: implicit definition of token Int in parser
warning(125): CPP14Parser.g4:485:6: implicit definition of token Float in parser
warning(125): CPP14Parser.g4:532:20: implicit definition of token Struct in parser
warning(125): CPP14Parser.g4:648:23: implicit definition of token Const in parser

This works fine with the old antlr tool. In addition, the symbols, like LeftBracket, exist in the lexer .tokens file. The tool didn't say it couldn't find the tokenVocab, so I don't know.

Probably the tokens are not found for the Cpp grammar. Need to check this out...


Line numbers overlap JSON body

Insomnia Version: v6.6.2
Operating System: MacOS High Sierra 10.13.2

Details

Turn off body text wrapping
Scroll long body horizontally, so that line numbers start to overlap it
Observe:

Proposal
Would be nice to have some 80% opaque background under line numbers, so that they're distinct.

Hmm, I have seen this happen a long time (years) ago. I can't seem to reproduce this bug though now.
The expected behavior is that line numbers always appear beside the main content. The fact that they are overlapping in your screenshot should never happen.
Does it still do this for you after a fresh app launch?

Sorry, forgot to mention that you need to have not only text wrapping disabled, but also a long line to scroll vertically so that line numbers start to overlap with main content.

The transparency seems to be added intentionally. L74 in packages/insomnia-app/app/ui/css/editor/general.less
  .CodeMirror,
  .cm-s-seti.CodeMirror, // Hack because seti theme is dumb
  .CodeMirror-gutters,
  .CodeMirror-scrollbar-filler,
  .CodeMirror-gutter-filler {
    // Let the background behind show through
    background-color: transparent !important;
    border: 0;
  }

If we remove gutters class from the list, the issue is resolved. Should I create a PR with this change?

I'd rather make background-color the same as background behind it, but with 80% transparency.

The background color is stored in a CSS var --color-bg. Is there any straightforward way to change it's transparency?


organic carbon for AfSIS1

AfSIS1 database has SOC measured as total carbon after acidification and this is reported in a column called "acidified carbon" which is the last column in this dataset (https://github.com/zecojls/SoilSpec4GG_GoogleColab/blob/main/data/AFSIS_ICRAFwetchem.csv).
ICRAF's method for organic carbon is described here: https://worldagroforestry.org/sites/default/files/Total organic carbon and nitrogen_221111.pdf

I also think the same issue is in the Central Africa SSL - they measured TC but almost all of the samples are highly acidic so TC = TOC. For CASSL, we can be conservative and say TC = TOC only where pH was measured and pH < 7.0.


Cannot import component

Hi, I tried to run this package but got and error. I installed with pip install streamlit-auth0-component
The code is
from auth0_component import login_button
import streamlit as st
user_info = login_button(XXX, domain=XXX)
st.write(user_info)

The error
2022-10-12 14:58:48.291 Uncaught app exception
Traceback (most recent call last):
  File "/home/.venv/lib/python3.8/site-packages/streamlit/runtime/scriptrunner/script_runner.py", line 562, in _run_script
    exec(code, module.__dict__)
  File "/home/auth0_app.py", line 1, in <module>
    from auth0_component import login_button
  File "/home/.venv/lib/python3.8/site-packages/auth0_component/__init__.py", line 16, in <module>
    _login_button = components.declare_component("login_button", path=build_dir)
  File "/home/.venv/lib/python3.8/site-packages/streamlit/components/v1/components.py", line 300, in declare_component
    ComponentRegistry.instance().register_component(component)
  File "/home/.venv/lib/python3.8/site-packages/streamlit/components/v1/components.py", line 340, in register_component
    raise StreamlitAPIException(f"No such component directory: '{abspath}'")
streamlit.errors.StreamlitAPIException: No such component directory: '/home/.venv/lib/python3.8/site-packages/auth0_component/frontend/dist'

+1

@conradbez :sweat:

Should we fork this project and work on it independently?
Has a lot of potential, but currently broken.

I wasn't broken in previous releases, I think it @conradbez can fix it very easily :sweat_smile:

Hey peeps, sorry don't come here all to often but will try to fix issues as I become aware. I've updated to include the dist folder try version pip install treamlit-auth0-component==0.1.4 and let me know if it still doesn't work :)

It works! Thanks!!


Remove the crc machine directory before removing the VM

Right now removeCRCVM() function return as soon as it sees there
is no crc domain which might give false positive for cleanup scenario
consider following.

crc start
sudo virsh --connect qemu:///system destroy crc
sudo virsh --connect qemu:///system undefine crc
crc delete
Do you want to delete the OpenShift cluster? [y/N]: y
(crc) Failed to fetch machine
ERRO Failed to fetch machine 'crc'
crc cleanup --log-level debug
[...]
DEBU Running 'virsh --connect qemu:///system domstate crc'
DEBU Command failed: exit status 1
DEBU stdout:
DEBU stderr: error: failed to get domain 'crc'
INFO Removing /etc/NetworkManager/dnsmasq.d/crc.conf file
ls ~/.crc/machines/crc/
config.json  crc  id_rsa  id_rsa.pub  kubeconfig

Above you can see we just check about crc domain status and return
and step not reached to delete the machine dir.

/lgtm


android/app module's project buildDir not correct after subprojects block merged

If there is a plugin project name's lexicographical order before 'app', the prject ':app' buildDir is not set correctly.
It seems this happened after this PR merged https://github.com/flutter/flutter/pull/77942
Step to produce:
flutter create -t plugin --platforms android,ios aaa
cd example
flutter build apk

There is an unexpected build folder under android/app.

flutter doctor -v
[✓] Flutter (Channel unknown, 2.6.0-12.0.pre.135, on macOS 11.6 20G165 darwin-x64, locale zh-Hans-CN)
    • Flutter version 2.6.0-12.0.pre.135 at /Users/fenglang/codes/source/flutter
    • Upstream repository unknown
    • Framework revision 3074c9e04b (28 hours ago), 2021-09-28 22:08:04 -0700
    • Engine revision bccb3a57eb
    • Dart version 2.15.0 (build 2.15.0-156.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/fenglang/Library/Android/sdk
    • Platform android-31, build-tools 31.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7281165)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 13.0)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2020.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7281165)

[✓] VS Code (version 1.60.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.26.0

[!] Proxy Configuration
    • HTTP_PROXY is set
    ! NO_PROXY is not set

[✓] Connected device (1 available)
    • Chrome (web) • chrome • web-javascript • Google Chrome 94.0.4606.61

! Doctor found issues in 1 category.

It works fine when I change it back to two subprojects  block
rootProject.buildDir = '../build'
subprojects {
    project.buildDir = "${rootProject.buildDir}/${project.name}"
}
subprojects {
    project.evaluationDependsOn(':app')
}

Hi @littleGnAl
I can reproduce the behavior on the latest master, however as you mentioned this was changed after https://github.com/flutter/flutter/pull/77942 merged,
I tried flutter commit before this PR was merged, yet I see the same result
tahatesser@Tahas-MacBook-Pro app % pwd
/Users/tahatesser/StudioProjects/aaa/example/android/app
tahatesser@Tahas-MacBook-Pro app % ls
build		build.gradle	src
tahatesser@Tahas-MacBook-Pro app %

@TahaTesser I think you should delete the aaa project first, then re-run the scripts, as it's a "new flutter version"

Hi @littleGnAl
Thanks, yes, when recreating the project the issue doesn't reproduce with older commits.

previous version
stable
master

✅
❗
❗

Check flutter doctor -v outputs for each channel below

flutter doctor -v
[✓] Flutter (Channel unknown, 2.1.0-13.0.pre.19, on macOS 12.0 21A5534d darwin-x64, locale en-GB)
    • Flutter version 2.1.0-13.0.pre.19 at /Users/tahatesser/Code/flutter
    • Framework revision 8bbaedde10 (7 months ago), 2021-03-10 10:05:03 -0800
    • Engine revision 785ac320e4
    • Dart version 2.13.0 (build 2.13.0-116.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
    • Android SDK at /Users/tahatesser/Code/SDK
    • Platform android-30, build-tools 29.0.2
    • ANDROID_HOME = /Users/tahatesser/Code/SDK
    • Java binary at: /Users/tahatesser/Code/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment Temurin-11.0.12+7 (build 11.0.12+7)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 13.0, Build version 13A233
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[!] Android Studio (version 2020.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    ✗ Unable to find bundled Java version.
    • Try updating or re-installing Android Studio.

[✓] VS Code (version 1.60.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.26.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-x64     • macOS 12.0 21A5534d darwin-x64
    • Chrome (web)    • chrome • web-javascript • Google Chrome 94.0.4606.61

! Doctor found issues in 1 category.

[✓] Flutter (Channel stable, 2.5.2, on macOS 12.0 21A5534d darwin-x64, locale en-GB)
    • Flutter version 2.5.2 at /Users/tahatesser/Code/flutter_stable
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 3595343e20 (11 hours ago), 2021-09-30 12:58:18 -0700
    • Engine revision 6ac856380f
    • Dart version 2.14.3

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
    • Android SDK at /Users/tahatesser/Code/SDK
    • Platform android-30, build-tools 29.0.2
    • ANDROID_HOME = /Users/tahatesser/Code/SDK
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7281165)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 13.0, Build version 13A233
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2020.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7281165)

[✓] VS Code (version 1.60.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.26.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-x64     • macOS 12.0 21A5534d darwin-x64
    • Chrome (web)    • chrome • web-javascript • Google Chrome 94.0.4606.61

• No issues found!

[✓] Flutter (Channel master, 2.6.0-12.0.pre.150, on macOS 12.0 21A5534d darwin-x64, locale en-GB)
    • Flutter version 2.6.0-12.0.pre.150 at /Users/tahatesser/Code/flutter_master
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 367531447c (31 hours ago), 2021-09-29 20:03:04 -0400
    • Engine revision 9224a17d1c
    • Dart version 2.15.0 (build 2.15.0-162.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
    • Android SDK at /Users/tahatesser/Code/SDK
    • Platform android-30, build-tools 29.0.2
    • ANDROID_HOME = /Users/tahatesser/Code/SDK
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7281165)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 13.0)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2020.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7281165)

[✓] VS Code (version 1.60.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.26.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-x64     • macOS 12.0 21A5534d darwin-x64
    • Chrome (web)    • chrome • web-javascript • Google Chrome 94.0.4606.61

• No issues found!

✅: No Issue ❗: Issue reproduced


OpenCV Python with Gstreamer Backend

Hi,
From this page,
https://discuss.bluerobotics.com/t/opencv-python-with-gstreamer-backend/8842
I saw you compiler the opencv-python with gstreamer backend,
I want to study gstreamer just like you, so I need this wheel, could you send me one?

I want to study gstreamer just like you, so I need this wheel, could you send me one?

OpenCV is a C++ library that needs to be compiled, which means it’s not possible to provide a single wheel that works for everybody because the compilation has to run on the particular hardware and operating system you’re using.
More generally, for gstreamer support to work requires a valid install of gstreamer to be on your computer that OpenCV can link to while it’s building. That’s also not possible to include in a simple wheel.
If you want to use gstreamer with OpenCV you’ll most likely need to do the compilation yourself. You should be able to achieve that by following the steps I provided in the forum post you linked to. As I mentioned there, conveniently the OpenCV-python library does most of the compilation setup for you, so compiling is much simpler to do than it would otherwise normally be.


Tabnine doesn't work with insider builds of vscode

It doesnt work with latest vscode insider.. It does work with regular vscode
gz#10824

Hi @jeffrgh can you add more details about your setup? + attach some video/screenshots

Version 1.64.0 insiders

Nvm works now...
Must have been a version issue...


add floating bar & bullet demos to data-viz pages

Any idea what's happening to the text for all the demos?

Any idea what's happening to the text for all the demos?

what? I'm not seeing that...
chrome

& firefox

do you have some sort of automatic translation happening? @tw15egan

@theiliad @jeanservaas Maybe for the Network diagram, Alluvial, and Heatmap we should change the tag to WIP Thoughts?

Those could be a different color than Design only tag

@theiliad I just clicked on the preview link 🤷🏻

@theiliad I just clicked on the preview link 🤷🏻

are any other charts having this issue? do the sandbox or storybook links under the chart also display the same issue for you?
I'm not sure how I can debug this, I also don't see how every label in there can change unless something else is happening on your browser...

@theiliad I just clicked on the preview link 🤷🏻

my latest screenshots are also off of the preview link

@theiliad That's how the text is rendering for all the Data Viz demos, could just be something with my browser. If no one else is seeing it nothing to debug, just thought it was super strange! 😄

@theiliad That's how the text is rendering for all the Data Viz demos (storybook and codesandboxes are fine), could just be something with my browser. If no one else is seeing it nothing to debug, just thought it was super strange! 😄

yeah I would imagine either you have some kind of extension or translator that's automatically trying to do stuff, or maybe some virus/malware...?
Could be something that I'm missing in the library but honestly can't think of anything...

this is super weird

haha I know! I'm guessing it's Vercel doing something weird. Just disregard it, no one else seems to be seeing it. The charts and everything else render great 👍🏻

@theiliad The Pie and Donut have some odd text in the legend. Can’t this content be something like “Dataset 1, Dataset 2, etc.?

![Uploading Screen Shot 2021-04-29 at 1.03.08 PM.png…]()

@theiliad The Pie and Donut have some odd text in the legend. Can’t this content be something like “Dataset 1, Dataset 2, etc.?

Yes this is what I was mentioning, we created these demos years ago and they haven't been re-orged really...
It'd be outside of this PR but we should really look at all of that


mtls: Specify proper mtls key.

Changelog: None
Signed-off-by: Drew Moseley<EMAIL_ADDRESS>External Contributor Checklist

🚨 Please review the guidelines for contributing to this repository.

[ ] Make sure that all commits are signed with git --signoff. Also note that the signoff author must match the author of the commit.

Description
Please describe your pull request.
Thank you!

ping @drewmoseley; can we merge?


MySQL integer pk overflow vector

yii\db\mysql\QueryBuilder
public $typeMap = [
    Schema::TYPE_PK => 'int(11) NOT NULL AUTO_INCREMENT PRIMARY KEY',
    Schema::TYPE_UPK => 'int(11) UNSIGNED NOT NULL AUTO_INCREMENT PRIMARY KEY',
];

Max value of int column is 4,294,967,295 (unsigned) (http://dev.mysql.com/doc/refman/5.7/en/integer-types.html).
That's only 10 digits, so the type map should be changed to int(10).

https://github.com/yiisoft/yii2/pull/12072#issuecomment-237392712

@cebe
mysql> CREATE TABLE `m1197_testing`.`inttest` ( `a1` INT NOT NULL , `a2` INT UNSIGNED NOT NULL ) ENGINE = InnoDB;
Query OK, 0 rows affected (0,04 sec)

mysql> DESCRIBE inttest;
+-------+------------------+------+-----+---------+-------+
| Field | Type             | Null | Key | Default | Extra |
+-------+------------------+------+-----+---------+-------+
| a1    | int(11)          | NO   |     | NULL    |       |
| a2    | int(10) unsigned | NO   |     | NULL    |       |
+-------+------------------+------+-----+---------+-------+
2 rows in set (0,01 sec)

MySQL 5.6

@rob006 thanks for checking! fixed.

that's actually a breaking change.

reverted the change: 144d78e
I'm setting this to 2.1 now but I am unsure if we should change anything as it is a subtle break that has no real value imo.

that's actually a breaking change.

Why?

see https://github.com/yiisoft/yii2/commit/85d89e489311e20c626bcb90129c0c86978fcee4#commitcomment-18556122

@cebe Did you test this? I have no problems with creating FK between INT(10) UNSIGNED and INT(11) UNSIGNED.

according to @samdark it fails. Which MySQL version are you using?

Tested on MySQL 5.6.

Hmm... seems I was wrong and it's indeed possible. Singned/unsigned should match but MySQL is OK w/ referencing int(10) PK from int(11) FK.

Sorry for confusion.

Hmm... seems I was wrong and it's indeed possible. Singned/unsigned should match but MySQL is OK w/ referencing int(10) PK from int(11) FK.

That's because the display width does not limit the range of values that can be stored in the field: http://dev.mysql.com/doc/refman/5.7/en/numeric-type-attributes.html
So it's effectively the same type. The display width is only metadata that tells the mysql client to pad it with spaces so that numbers display nicely under each other.
On the other hand, unsigned changes the type, it can no longer store values larger than 2^31-1, so if you had a signed int referencing an unsigned int, it would be possible to have ids that you cannot store in the foreign key.

Yes, I'm aware of the fact. Just remember that some incompatibilities were not tolerated and was sure it was display width as well.


chore(deps): update dependency flask to 2.2.2

This PR contains the following updates:

Package
Update
Change

Flask (changelog)
minor
==2.0.2 -> ==2.2.2

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

@balena-ci I self-certify!

Renovate Ignore Notification
As this PR has been closed unmerged, Renovate will now ignore this update (==2.2.2). You will still receive a PR once a newer version is released, so if you wish to permanently ignore this dependency, please add it to the ignoreDeps array of your renovate config.
If this PR was closed by mistake or you changed your mind, you can simply rename this PR and you will soon get a fresh replacement PR opened.


Always load translations

Docs pages only load sim strings which breaks translations of snippets. Simplify logic. FIx for https://github.com/Microsoft/pxt-ev3/issues/765

We should talk about bundle support in the api.


Saturating conversion to primitives

I would like to request a way to convert a bigint into a smaller primitive, saturating at MAX_VALUE or MIN_VALUE if needed.

This seems like an unusual thing to want -- can you describe the use case where a saturating conversion would be helpful?
You can do this manually, if a little cumbersome, something like:
let small_int = bigint.to_i32().unwrap_or_else(|| {
    if bigint.sign() == Sign::Plus { i32::MAX } else { i32::MIN }
});

Sorry, I was mistaken when I created this issue. I'm looking for a masking conversion where you discard the high bits.


File upload show progress

Done:

show upload progress while uploading (single) file
on error show dialog. Close button is link that reloads the current page (and tab)
fix weird behaviour when uploading file bigger than 2G (the file size limit): server receives file three times, while at the client level this is not visible. Even worse, the client reports an empty response. Investigation revealed that the server does send a response, but the client doesn't read it because it is still uploading its body. Fixed by fully reading the request body, to io.Discard if needed. Only if the upload file size is small enough, the client will likely have uploaded everything when it received the response. Typical for streaming servers where the uploaded file is not a temporary file? cf. https://stackoverflow.com/questions/43777433/go-http-maxbytesreader-resetting-connection

TODO:

@mietcls current error when file upload exceeds the limit is somewhat "vague". "file upload failed"
make "disabled" state more visible. This has been implemented in the style (see https://biblio-backend-ugent-prototype-git-master-ugent-library.vercel.app/styleguide/c-file-upload.html), but cannot be used yet. @nics ?

@nicolasfranck upload progress part replaced by 006910f99a27f14b070b9a3f32ba730202bbf4a7

@nicolasfranck did you see the question above?

@nics of course, but it is a bit messy now to overlook what changed and how to re-fix the merge conflict


Event type mismatch using addEventListener and onerror

When using the addEventListener/removeEventListener methods to listen for error events, the event parameter is expected to be of type ErrorEvent. See https://github.com/pladaria/reconnecting-websocket/blob/master/events.ts#L37
export interface WebSocketEventListenerMap {
    close: (event: CloseEvent) => void | {handleEvent: (event: CloseEvent) => void};
    error: (event: ErrorEvent) => void | {handleEvent: (event: ErrorEvent) => void};
    message: (event: MessageEvent) => void | {handleEvent: (event: MessageEvent) => void};
    open: (event: Event) => void | {handleEvent: (event: Event) => void};
}

However, when using the .onerror property the event is expected to be of type Event. See https://github.com/pladaria/reconnecting-websocket/blob/master/reconnecting-websocket.ts#L194
public onerror?: (event: Event) => void = undefined;

Thanks for reporting, next version will fix it


Active Markets, user position 24 hour change

open markets
Market row: sum user's position percentage change in 24 hour period.
Math:
calculate total value per existing user's positions.
If user's position is less than 24 hours old use the positions totalCost as old totalValue.
If user's position is 24 hours or more old use market trade history to get the outcome's last price 24 hours ago to calculate total value.
position percentage change = (Current totalValue - Old totalValue) / Current totalValue * 100

initial work done...math updates being worked - closing


deps!: Remove fast-text-encoding as a dependency

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

[ ] Make sure to open an issue as a bug/issue before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
[ ] Ensure the tests and linter pass
[ ] Code coverage does not decrease (if any source code was changed)
[ ] Appropriate docs were updated (if necessary)

Fixes #1546  🦕

Most modern browsers now support this natively. The browsers that do not are generally 6 or more years old.

Most modern browsers now support this natively. The browsers that do not are generally 6 or more years old.

Agreed.


Unexpected number of leaves by computing get_leaves()

model = Model(MODEL_ID, api=BigML(username=USERNAME, api_key=BB_KEY))
leaves = get_leaves(model)
print(len(leaves))

Output: 428 leaves

428 leaves are obviously incorrect, as shown in the model figure below.
The error is probably comes from this line https://github.com/bigmlcom/python/blob/a372c5c0265d587b4ebb047a2257a8b5b27478bc/bigml/generators/model.py#L152

Hi @DylanWangWQF.
This was indeed a mistake that has been fixed in #404. Thanks for the heads up!


Updated permission check for Azure rbac

Updated rbac permissions check as per https://learn.microsoft.com/en-us/azure/role-based-access-control/role-assignments-steps#privileged-administrator-role.

LGTM


feat: update events for credential SNS

TODO: filter by field updates that actually affect credentials.
TIS21-4150

I give up on the indentation code smells 😂 . This is with the intellij code-formatting. If I manually adjust them to what sonar wants, it seems to change its mind and prefer them the way they were!

I give up on the indentation code smells 😂 . This is with the intellij code-formatting. If I manually adjust them to what sonar wants, it seems to change its mind and prefer them the way they were!

Have you imported the Google formatter?
https://github.com/google/styleguide/blob/gh-pages/intellij-java-google-style.xml

I give up on the indentation code smells 😂 . This is with the intellij code-formatting. If I manually adjust them to what sonar wants, it seems to change its mind and prefer them the way they were!

Have you imported the Google formatter? https://github.com/google/styleguide/blob/gh-pages/intellij-java-google-style.xml

Ah cool, I have now. (It fixes the alignment of line-broken parameters in a function, but makes no difference to this specific issue) 👍


ModuleNotFoundError: No module named 'examples.fastspeech2'

I am trying to reproduce fastspech2 tarining but when i  do this in colab it points to ModuleNotFoundError in training part
but prerpocessing part was succeeded
!CUDA_VISIBLE_DEVICES=0 python /content/TensorflowTTS/examples/fastspeech2/train_fastspeech2.py
--train-dir /content/dump/train/
--dev-dir /content/dump/valid/
--outdir /content/TensorflowTTS/examples/fastspeech2/exp/train.fastspeech2.v1/
--config /content/TensorflowTTS/examples/fastspeech2/conf/fastspeech2.v1.yaml
--use-norm 1
--f0-stat /content/TensorflowTTS/dump/stats_f0.npy
--energy-stat /content/TensorflowTTS/dump/stats_energy.npy
--mixed_precision 1
--resume ""
Traceback (most recent call last):
File "/content/TensorflowTTS/examples/fastspeech2/train_fastspeech2.py", line 21, in
from examples.fastspeech2.fastspeech2_dataset import CharactorDurationF0EnergyMelDataset
ModuleNotFoundError: No module named 'examples.fastspeech2'

@MokkeMeguru can you check and help ?

@MODAK27
Google Colab has a module (or it's the folder?) conveniently named examples that make it conflict with this repo. To fix it, in my training notebooks I always run a piece of code that renames the examples folder into ttsexamples and replaces examples. with ttsexamples. in all the code recursively right after cloning the repo.
Talking about notebooks, an example training one would be nice.

@ZDisket sorry it didn't help, even though colab has examples inbuilt, it will always first look on to path provided at first by user to look on to modules. I am sharing my colab ,could you please look onto it. it's editable

I fixed the bug. python 3.6 even requires the__init__.py module to treat directories containing files as packages.

Add init.py inisde examples folder  with "#" inside it(to rep. null and search in it's subdirectories)
Add init.py inside examples/fastspeech2 folder with "from examples_tts.fastspeech2.fastspeech2_dataset import CharactorDurationF0EnergyMelDataset" in it
Add init.py inside examples/fastspeech folder with "from examples_tts.fastspeech.fastspeech_dataset import CharactorDurationMelDataset" in it

I update the code of fastspeech2.
@MODAK27 init.py is not needed in our settings.
You can do our example in python 3.6. after my pull request (#98) is merged.
git clone https://github.com/TensorSpeech/TensorflowTTS TTTS
cd TTTS
docker-compose build
docker-compose up -d
docker-compose exec tensorflowtts /bin/bash
python --version
# 3.6.9
python examples/fastspeech2/train_fastspeech2.py

@ZDisket
I don't know colab well. It is th colab-dependencies problem.

And also, we can easily remove the example folder from colab environment with the below code.
import examples
!rm -r {'/'.join(examples.__file__.split('/')[:-1])}
import os
!git clone https://github.com/TensorSpeech/TensorflowTTS TTTS
os.chdir("TTTS")
!pip install  .

and then
!python examples/fastspeech/train_fastspeech.py

@MODAK27  Here is what you want, isn't it?

And also, we can easily remove the example folder from colab environment with the below code.
import examples
!rm -r {'/'.join(examples.__file__.split('/')[:-1])}
import os
!git clone https://github.com/TensorSpeech/TensorflowTTS TTTS
os.chdir("TTTS")
!pip install  .

and then
!python examples/fastspeech/train_fastspeech.py

@MODAK27 Here is what you want, isn't it?

yeah thanx sir for looking into the prob. I solved it. Sir one more help is req, to extract durations for alignment in Fastspeech2 , do we need to train tacotron2 model to get checkpoints/model-65000.h5

@MODAK27 you need train tacotron2 to extract duration on ur own dataset. If you train ljspeech, you can use our pretrained.


Error deploying loghouse to GKE

 helm install -n loghouse loghouse/loghouse
Error: validation failed: unable to recognize "": no matches for kind "CronJob" in version "batch/v2alpha1"

I have the same problem :(

Please provide your client and cluster information as well api versions (kubectl api-versions | grep batch)

ApiVersions was updated for all resources in #137, "batch/v1beta1" is used for CronJob now.
There are more improvements, please update to v0.3.0.


VB.Net version?

Hi,
Is there a VB.Net version of this somehwere?
Thanks in advance.

Unfortunately, we do not have a VB.NET version of this sample at this time. We'll consider it as we prioritize samples in the future.


webpack out file question

Error

shell
cordova run browser -- --live-reload

About Code
config/webpack.common.js
...
    module: {
      rules: [
        {
          test: /\.ts$/,
          loader: "ts-loader"
        },
        {
          test: /\.js$/,
          exclude: /node_modules(\/|\\)(?!(framework7|framework7-vue|template7|dom7)(\/|\\)).*/,
          use: {
            loader: "babel-loader",
            options: {
              presets: [["env", {
                targets:{
                  "chrome": "78"
                }
              }]],
              plugins: ["transform-object-rest-spread"]
            }
          }
        }
...

tsconfig.json
{
  "compilerOptions": {
    "allowSyntheticDefaultImports": true,
    "declaration": false,
    "emitDecoratorMetadata": true,
    "experimentalDecorators": true,
    "lib": ["dom", "es2017"],
    "module": "es2015",
    "moduleResolution": "node",
    "sourceMap": true,
    "target": "esnext",
    "typeRoots": ["node_modules/@types"]
  },
  "include": ["src/**/*.ts"],
  "exclude": ["node_modules"],
  "compileOnSave": false,
  "downlevelIteration":true
}

User.ts
export class User {}

@leozale could you please just check this link first ->
https://alexjover.com/blog/integrate-typescript-in-your-vue-project/

Hi @khudia hope you are having a good day, I just did some tests with your comments, and everything seems to work perfectly now, could you please try it again with the new 2.4.3 Version


Documentation layout broken on configuration page

Documentation layout is broken on :
https://registry.terraform.io/providers/observIQ/bindplane/latest/docs/resources/bindplane_configuration

Thanks for reporting :+1:


OCF tweet for 10+ financial contributors did not go out

This collective  reached 10+ financial contributors around 2022-11-29, yet it does not appear on https://twitter.com/o_c_foundation. We need to investigate why.

Maybe related to https://github.com/opencollective/opencollective/issues/5719?


New modal to add custom WMS basemap

Implement the WMS basemap category:

Some doubts and questions:

[ ] How/where should error feedback be displayed?

Layer failed to be saved for whatever reason (required prerequisite step before basemap is changed)

[ ] In the old modal there's a back button, shouldn't there be one for this one too? If so, where?
[ ] Search is not a must-have feature, so postpone it to solve it separately, this amount of changes are already rather big for this one
[ ] As seen in screenshot about, the error box has limited space so linked to docs page regarding the limited projections (needs to be updated), do you have another proposal on how to solve it?
[ ] I started looking into the WMTS-issues as reported in #3694, but it turned out to not be so trivial to fix, I suggest we postpone/solve this separately.. (remove the WTMS labels in the templates for now)

Frontend tests were OK :+1: (details)

@saleiva see list of doubts/questions in the description, what do you think?

Frontend tests were OK :+1: (details)

1 - Standard error that we have. The one that is fullscreen.
2 - Yep, in the same place we have in the privacy window for example.
3 - Cannot we reuse what pablo did for the users?
4 - I like what you did.
5 - ok.

Frontend tests were OK :+1: (details)

@saleiva Thx for the replies, fixed the issues and updated description w/ changes.
Regarding point 3/search, yeah, possibly we can but I'm not sure if it's implemented with the idea of being completely generic. I need to check the solution w/ @alonsogarciapablo and possibly extract it from the privacy view in that case. Regardless, reusing existing code or not, it's something that can be done in isolation why I proposed to postpone it.

@xavijam can you do the code review now that the changes are done?

Good to go!


python37Packages.mautrix: 0.5.8 -> 0.7.14

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python37Packages.mautrix is: "A Python 3 asyncio Matrix framework."
meta.homepage for python37Packages.mautrix is: "https://github.com/tulir/mautrix-python"
meta.changelog for python37Packages.mautrix is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS

Warning: a test defined in passthru.tests did not pass

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 0.7.14 with grep in /nix/store/0b7mmjcsamx5yrcp32ml75kbl0bq07ri-python3.7-mautrix-0.7.14

directory tree listing: https://gist.github.com/a32d1c4ac54a98bb895a52eb3087654e

du listing: https://gist.github.com/0ec1da21a8fb566ee6047a3b7472c52b

Rebuild report (if merged into master) (click to expand)

19 total rebuild path(s)

5 package rebuild(s)

5 x86_64-linux rebuild(s)
5 i686-linux rebuild(s)
4 x86_64-darwin rebuild(s)
5 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
mautrix-telegram
python37Packages.mautrix
python37Packages.mautrix-appservice
python38Packages.mautrix
python38Packages.mautrix-appservice

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/0b7mmjcsamx5yrcp32ml75kbl0bq07ri-python3.7-mautrix-0.7.14 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python37Packages.mautrix https://github.com/r-ryantm/nixpkgs/archive/d6c9815118e22c3ea346f2170c3c7bd6ec6a4fc6.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/0b7mmjcsamx5yrcp32ml75kbl0bq07ri-python3.7-mautrix-0.7.14
ls -la /nix/store/0b7mmjcsamx5yrcp32ml75kbl0bq07ri-python3.7-mautrix-0.7.14/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
nixpkgs-review encountered an error. Please check the logs at https://r.ryantm.com/log/ for more information.

Maintainer pings
cc @nyanloutre @ma27 for testing.

Still not compatible with latest stable release of mautrix-telegram.


Revert "Use same debug signing certificate for all builds"

This reverts commit 564722592e2ef0e1a80fe2375ce5f4cff4393dd7.
Task/Issue URL: https://app.asana.com/0/488551667048375/1207193416701280/f
Description
Steps to test this PR
Feature 1

[ ]
[ ]

UI changes

Before
After

!(Upload before screenshot)
(Upload after screenshot)

#4483  👈
develop

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @CDRussell and the rest of your teammates on  Graphite


Use lodash.assign over Object.assign

What Changed & Why
Use lodash's version of assign over Object.assign.
While this can be polyfilled as mentioned in #40, there's precedent for use of lodash's assign already in the project (in index.js).
Given this is a pretty simple change and doesn't introduce any extra dependencies, I think it's worth doing this to avoid the polyfill requirement in older browsers.

👍