Feature Request: Show secondary navigation links

https://ghost.org/changelog/secondary-navigation/ documents secondary links.
I tried this on https://www.markhansen.co.nz/ with Alto theme and don't see them anywhere.

Hey there! Secondary navigation support has just been added in https://github.com/TryGhost/Alto/commit/d0a23ac9f7b49695efa2cf87a51c09e0a67b4fe5. If there's a secondary navigation, the footer logo will be replaced with the navigation.

Thanks. Do I have to wait for a release / version bump to see this
reflected in ghost pro? It’s still showing version 1.0.0
On Mon, 6 Sep 2021 at 14:39, Sodbileg Gansukh @.***>
wrote:

Closed #37 https://github.com/TryGhost/Alto/issues/37.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/TryGhost/Alto/issues/37#event-5258606759, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAZYOI3JD6EZZBYBDBSEOTUARAZ7ANCNFSM5DOOYGWQ
.

You can simply re-install the theme from the Marketplace which will override the existing one :)

Thank you; I can confirm your fix works (and looks great!) have a good one
On Wed, 8 Sept 2021 at 15:18, Sodbileg Gansukh @.***>
wrote:

You can simply re-install the theme from the Marketplace which will
override the existing one :)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/TryGhost/Alto/issues/37#issuecomment-914925288, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAZYONVBSN5ACXDTAAR2VLUA3WZ7ANCNFSM5DOOYGWQ
.


Abstract out name delimiter

Codecov Report

Merging #29 into master will increase coverage by 0.07%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##           master      #29      +/-   ##
==========================================
+ Coverage   80.07%   80.15%   +0.07%
==========================================
  Files           7        7
  Lines         261      262       +1
==========================================
+ Hits          209      210       +1
  Misses         52       52

Impacted Files
Coverage Δ

ssds/__init__.py
80.24% <75.00%> (+0.24%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed698e4...2549459. Read the comment docs.


Players seeing GM tooltips for locked quest icon

Module Version: v0.7.3
Describe the bug
When a player hovers their cursor over the locked (or unlocked) icon next to a reward, it will display the tooltip "Reward is locked. Click to unlock." (or the reverse if the quest is unlocked). These are the same tooltips displayed to the GM (which is good, they should be displayed there), but they are not correct or relevant for the player.
To Reproduce
Steps to reproduce the behavior:

Go to Quest Log, as a player
Click on an existing quest with rewards
Hover over the locked or unlocked icon to the right of a reward
Observe the tooltip, matching that seen by the GM

Expected behavior
I would expect either no tooltip to be shown to the player, or for a more relevant tooltip to be shown. Possibly just "Reward is locked." / "Reward is unlocked.", maybe with additional information on what that means added to the end.
Browser:
Chrome Version 91.0.4472.114
Foundry Version:
0.8.8
Game System:
DnD5e 1.3.6

Relevant snippet of code: https://github.com/League-of-Foundry-Developers/foundryvtt-forien-quest-log/blob/5478d0ef5f884a63b406e4e0e0ce6e59af153a27/templates/partials/quest-preview/details.html#L199-L203

Good idea.. There is a canEdit field which can be used to pick two different tooltips from the template itself. It might make more sense in creating the tooltip in Enrich.quest that prepares the tooltip to be displayed in advance of rendering the template.

Shipped in 0.7.4 which is not available.


[BUG] mount is ignored when used in modules

Information

Version: >=5.5x
Packages: di

I use modules to avoid duplicating common components. It works well when we speak about middleware, filters, and pipes. However, controllers are just ignored. See example below:
@Controller('/')
export class HealthController {
  @Get()
  @Get('/health')
  @Returns(204)
  public health(): void {
    // noop
  }
}

@Module({
  mount: {
    '/api/v1/': [HealthController]
  }
})
export class HealthModule {
  // ...
}

@Configuration({
  // ...
  mount: {
    '/api/v1/': [ /* other controllers */ ]
  },
  imports: [HealthModule]
})
export class Service {

}

I have tried to add controllers on the $beforeInit hook, it also has no effect.
@Module({
  deps: [Configuration]
})
export class HealthModule {
 constructor(private readonly configuration: Configuration) {}

  public $beforeInit(): void {
    const endpoint = '/api/v1/';

    this.configuration.mount[endpoint] = (
      this.configuration.mount[endpoint] ?? []
    ).concat(HealthController);
  }
}

It seems it somehow connected with importProviders. That method resolves all providers concurrently, while imports must be initialized before building the module itself according to docs.

Because it's $beforeInit ^^ (or $onInit).
But it's better to resolve the problem around the mount properties/

For me it's works with the latest version (6.x): https://github.com/tsedio/tsed-example-modules

@Romakita Hmm... It seems I missed something) I guess we can close this issue

You've mentioned the v5 ^^. My example is on v6. So your issue is on v5?

Thanks) Everything works on v6


Featuring:

1. Created MIT License
1. Added a react environment and edited file structure

Updated test branch with master branch files


JUnit Reporter for Doctest

I currently use catch2 with --reporter=junit. Here is some junit sample output:
<testsuite failures="1" tests="3" time="1.5" timestamp="2020-05-21T22:46:42Z">
    <testcase classname="foo1" name="ASuccessfulTest" time="0.1"/>
    <testcase classname="foo2" name="AnotherSuccessfulTest" time="0.6"/>
    <testcase classname="foo3" name="AFailingTest" time="0.8">
        <failure message="A not equal to B" type="CHECK"> details about failure </failure>
    </testcase>
</testsuite>

As I wanted to move things over to doctest I noticed there was no junit reporter available. So I wrote a first version, which works for my purposes. But I am happy to receive some additional feedback, and possibly submit a PR.
struct JUnitReporter : public IReporter
{
    XmlWriter  xml;
    std::mutex mutex;

    struct JUnitTestCaseData
    {
        static std::string getCurrentTimestamp() {
            // Beware, this is not reentrant because of backward compatibility issues
            // Also, UTC only, again because of backward compatibility (%z is C++11)
            time_t rawtime;
            std::time(&rawtime);
            auto const timeStampSize = sizeof("2017-01-16T17:06:45Z");

            #ifdef _MSC_VER
                std::tm timeInfo = {};
                gmtime_s(&timeInfo, &rawtime);
            #else
                std::tm* timeInfo;
                timeInfo = std::gmtime(&rawtime);
            #endif

            char timeStamp[timeStampSize];
            const char* const fmt = "%Y-%m-%dT%H:%M:%SZ";

            #ifdef _MSC_VER
                std::strftime(timeStamp, timeStampSize, fmt, &timeInfo);
            #else
                std::strftime(timeStamp, timeStampSize, fmt, timeInfo);
            #endif
            return std::string(timeStamp);
        }

        struct JUnitTestMessage
        {
            JUnitTestMessage(const std::string& message, const std::string& type, const std::string& details)
                : message(message), type(type), details(details) { }

            JUnitTestMessage(const std::string& message, const std::string& details)
                : message(message), type(), details(details) { }

            std::string message, type, details;
        };

        struct JUnitTestCase
        {
            JUnitTestCase(const std::string& classname, const std::string& name)
                : classname(classname), name(name), time(0), failures() { }

            std::string classname, name;
            double time;
            std::vector<JUnitTestMessage> failures, errors;
        };

        void add(const std::string& classname, const std::string& name)
        {
            testcases.emplace_back(classname, name);
        }

        void addTime(const double& time)
        {
            testcases.back().time = time;
            totalSeconds += time;
        }

        void addFailure(const std::string& message, const std::string& type, const std::string& details)
        {
            testcases.back().failures.emplace_back(message, type, details);
            ++totalFailures;
        }

        void addError(const std::string& message, const std::string& details)
        {
            testcases.back().errors.emplace_back(message, details);
            ++totalErrors;
        }

        std::vector<JUnitTestCase> testcases;
        double totalSeconds = 0;
        int totalErrors = 0, totalFailures = 0;
    };

    JUnitTestCaseData testCaseData;

    // caching pointers/references to objects of these types - safe to do
    const ContextOptions& opt;
    const TestCaseData*   tc = nullptr;

    JUnitReporter(const ContextOptions& co)
            : xml(*co.cout)
            , opt(co) {}

    unsigned line(unsigned l) const { return opt.no_line_numbers ? 0 : l; }

    void test_case_start_impl(const TestCaseData& in) {
        testCaseData.add(skipPathFromFilename(in.m_file.c_str()), in.m_name);

        bool open_ts_tag = false;
        if(tc != nullptr) { // we have already opened a test suite
            if(std::strcmp(tc->m_test_suite, in.m_test_suite) != 0) {
                xml.endElement();
                open_ts_tag = true;
            }
        }
        else {
            open_ts_tag = true; // first test case ==> first test suite
        }
    }

    // =========================================================================================
    // WHAT FOLLOWS ARE OVERRIDES OF THE VIRTUAL METHODS OF THE REPORTER INTERFACE
    // =========================================================================================

    void report_query(const QueryData& in) override {
        test_run_start();
        if(opt.list_reporters) {
            for(auto& curr : getListeners())
                xml.scopedElement("Listener")
                        .writeAttribute("priority", curr.first.first)
                        .writeAttribute("name", curr.first.second);
            for(auto& curr : getReporters())
                xml.scopedElement("Reporter")
                        .writeAttribute("priority", curr.first.first)
                        .writeAttribute("name", curr.first.second);
        } else if(opt.count || opt.list_test_cases) {
            for(unsigned i = 0; i < in.num_data; ++i) {
                xml.scopedElement("TestCase").writeAttribute("name", in.data[i]->m_name)
                    .writeAttribute("testsuite", in.data[i]->m_test_suite)
                    .writeAttribute("filename", skipPathFromFilename(in.data[i]->m_file.c_str()))
                    .writeAttribute("line", line(in.data[i]->m_line));
            }
            xml.scopedElement("OverallResultsTestCases")
                    .writeAttribute("unskipped", in.run_stats->numTestCasesPassingFilters);
        } else if(opt.list_test_suites) {
            for(unsigned i = 0; i < in.num_data; ++i)
                xml.scopedElement("TestSuite").writeAttribute("name", in.data[i]->m_test_suite);
            xml.scopedElement("OverallResultsTestCases")
                    .writeAttribute("unskipped", in.run_stats->numTestCasesPassingFilters);
            xml.scopedElement("OverallResultsTestSuites")
                    .writeAttribute("unskipped", in.run_stats->numTestSuitesPassingFilters);
        }
        xml.endElement();
    }

    void test_run_start() override { }

    void test_run_end(const TestRunStats& p) override {
        std::string binary_name = skipPathFromFilename(opt.binary_name.c_str());
        xml.startElement("testsuites");
        xml.startElement("testsuite").writeAttribute("name", binary_name)
                .writeAttribute("errors", testCaseData.totalErrors)
                .writeAttribute("failures", testCaseData.totalFailures)
                .writeAttribute("tests", p.numAsserts)
                .writeAttribute("time", testCaseData.totalSeconds)
                .writeAttribute("doctest_version", DOCTEST_VERSION_STR)
                .writeAttribute("timestamp", JUnitTestCaseData::getCurrentTimestamp());

        for (const auto& testCase : testCaseData.testcases)
        {
            xml.startElement("testcase")
                .writeAttribute("classname", testCase.classname)
                .writeAttribute("name", testCase.name)
                .writeAttribute("time", testCase.time);

            for (const auto& failure : testCase.failures)
            {
                xml.startElement("failure")
                    .writeAttribute("message", failure.message)
                    .writeAttribute("type", failure.type)
                    .writeText(failure.details);
                xml.endElement();
            }

            for (const auto& error : testCase.errors)
            {
                xml.startElement("error")
                    .writeAttribute("message", error.message)
                    .writeText(error.details);
                xml.endElement();
            }

            xml.endElement();
        }
    }

    void test_case_start(const TestCaseData& in) override {
        test_case_start_impl(in);
    }

    void test_case_reenter(const TestCaseData&) override { }

    void test_case_end(const CurrentTestCaseStats& st) override {
        testCaseData.addTime(st.seconds);
    }

    void test_case_exception(const TestCaseException& e) override {
        std::lock_guard<std::mutex> lock(mutex);
        testCaseData.addError("exception", e.error_string.c_str());
    }

    void subcase_start(const SubcaseSignature& in) override {
        std::lock_guard<std::mutex> lock(mutex);
        testCaseData.add(skipPathFromFilename(in.m_file), in.m_name.c_str());
    }

    void subcase_end() override { }

    void log_assert(const AssertData& rb) override {
        if(!rb.m_failed && !opt.success)
            return;

        std::lock_guard<std::mutex> lock(mutex);

        std::ostringstream os;
        os << skipPathFromFilename(rb.m_file) << "(" << rb.m_line << "): Expression " << rb.m_expr << " became " << rb.m_decomp.c_str();
        testCaseData.addFailure(rb.m_decomp.c_str(), assertString(rb.m_at), os.str());
    }

    void log_message(const MessageData&) override { }

    void test_case_skipped(const TestCaseData&) override { }
};

DOCTEST_REGISTER_REPORTER("junit", 0, JUnitReporter);

Thanks! This has been requested quite a bit (and elsewhere)! I'll look into it.

Good Work! I have given this a a quick spin, and:

It compiles ok and works as advertised
The .xml file is correctly recognised and parsed by GitLab - shows up as a junit test in CI jobs

I guess that's just one datapoint though - anyone tried Jenkins or other CI servers to parse the output?

I have found one slight problem.
If I run with the success option, (i.e. testmain -s --reporters=junit,  Then the reporter reports all failures and successes as failures, for example with the factorial example:
<?xml version="1.0" encoding="UTF-8"?>
<testsuites>
  <testsuite name="prod/doctest/test" errors="0" failures="5" tests="5" time="0.000197" doctest_version="2.3.8" timestamp="2020-05-24T17:14:02Z">
    <testcase classname="prod/doctest/example.cpp" name="testing the factorial function" time="0.000197">
      <failure message="0 == 1" type="CHECK">
        prod/doctest/example.cpp(7): Expression factorial(0) == 1 became 0 == 1
      </failure>
      <failure message="1 == 1" type="CHECK">
        prod/doctest/example.cpp(8): Expression factorial(1) == 1 became 1 == 1
      </failure>
      <failure message="2 == 2" type="CHECK">
        prod/doctest/example.cpp(9): Expression factorial(2) == 2 became 2 == 2
      </failure>
      <failure message="6 == 6" type="CHECK">
        prod/doctest/example.cpp(10): Expression factorial(3) == 6 became 6 == 6
      </failure>
      <failure message="3628800 == 3628800" type="CHECK">
        prod/doctest/example.cpp(11): Expression factorial(10) == 3628800 became 3628800 == 3628800
      </failure>
    </testcase>
  </testsuite>
</testsuites>

Great work. As I'm pressed for time and couldn't write my own implementation, this worked great as a proof of concept, as my place of work is trying out Doctest with Azure Pipelines.
I have a few notes though. And sorry that I can't be more helpful atm with respect to providing solutions.

For me it didn't compile out of the box, had to remove ".c_str()" two places.
And it was missing the end tags for testsuite and testsuites.

I totally agree with onqtam, I think that it would be best/easiest to get as close as possible to the Catch2/ant JUnit format - it seems to be working great with Azure Pipelines. With respect to achieving this I have the following pointers.

Nested SUBCASES could be handled differently. Right now each visit to a SUBCASE results in a TESTCASE entry in the JUnit file. I.e. if you have a test structure like this

TEST_CASE("1")
+-- SUBCASE("1.1")
   +-- SUBCASE("1.1.1")
   +-- SUBCASE("1.1.2")

It would result in an output like this (Ignoring all attributes except for names):
<testsuites>
  <testsuite name="<name of the executable>">
    <testcase name="1"/>
    <testcase name="1.1"/>
    <testcase name="1.1.1"/>
    <testcase name="1.1"/>
    <testcase name="1.1.2"/>
  </testsuite>
</testsuites>

Meaning that even though there are only 2 tests (1.1.1 and 1.1.2), it will appear as if there are 5. Where as the output from Catch2 would look like this (my choice of names makes it look more confusing then it is)
<testsuites>
  <testsuite name="<name of the executable>">
    <testcase name="1/1.1/1.1.1"/>
    <testcase name="1/1.1/1.1.2"/>
  </testsuite>
</testsuites>

The times appears to be off. The time that is used that of the TEST_CASE (in doctest terminology), but it is assigned to the last SUBCASE within that TEST_CASE, where all other entries are assigned a time of zero. Continuing with the example from above it would look like

<testsuites>
 <testsuite name="<name of the executable>">
<!-- This should have had a time of 42 -->
   <testcase name="1" time="0"/>
<!-- And the rest a value of zero or better yet their actual execution time -->
   <testcase name="1.1" time="0"/>
   <testcase name="1.1.1" time="0"/>
   <testcase name="1.1" time="0"/>
   <testcase name="1.1.2" time="42"/>
 </testsuite>
</testsuites>

In my opinion (which would also be necessary if the Catch2 format is used) it would be nicer with the execution time of each SUBCASE.

Lastly I would like to draw attention to Catch2s way of reporting failures. Below is an example of the text in the body of a failure.

FAILED:
CHECK( some_string != "PONG" )
with expansion:
"PING" != "PONG"
at path/to/file/TEST.cpp:20

What I like most about this is that it is not just a single (very long) line, but they have used line breaks to make it more readable.
I hope these comments help!
I will see if I can get time to help with a solution in the near future, although I unfortunately doubt it...

@ARCRL those are some greag pointers - thanks! I'll try to incorporate all this into an initial version of the reporter in some weekend of June and will notify everyone here.

Glad I could help. :) And sorry it wasn't fully finished.

Just pushed a finished version of it in the dev branch - will release doctest 2.4.0 probably tomorrow - once the CI passes!
@ARCRL thanks again for all the tips - I addressed all your comments!


[SPARK-41221][SQL] Add the error class INVALID_FORMAT

What changes were proposed in this pull request?
In the PR, I propose to move out the error sub-classes related to number format issues from DATATYPE_MISMATCH to their own error class INVALID_FORMAT. Also, the PR deletes the error class INVALID_LIKE_PATTERN, and moves their sub-classes to INVALID_FORMAT.
Why are the changes needed?
To improve usability of Spark SQL and to don't confuse users by error class names related to values but to to its types.
Does this PR introduce any user-facing change?
Yes, the PR changes some user-facing errors.
How was this patch tested?
By running the affected test suites:
$ PYSPARK_PYTHON=python3 build/sbt "sql/testOnly org.apache.spark.sql.SQLQueryTestSuite"
$ build/sbt "core/testOnly *SparkThrowableSuite"
$ build/sbt "test:testOnly *StringExpressionsSuite"

Merging to master. Thank you, @srielau @cloud-fan @LuciferYang for review.


refactor service to make it embeddable

Rework the juttle-service module so that instead of exporting a class, it exports a simple closure with methods to both run/stop the service itself as well as adding the routes and setting up logging.
This will enable the juttle-engine to more easily embed the service without needing to repeat as much code.

@juttle/developers

There are still some references to juttled in test/juttle-service.spec.js. I'm ok with fixing that in a separate PR but if you're feeling tidy you could clean that up here as well.

lgtm! You can decide either way on the juttled cleanups.


Function overload accept union type.

TypeScript Version:  2.8.3

Search Terms: Function overload generic union type
Not sure if this is a bug or a question, so I also asked on Stack Overflow. Feel free to close if it isn't a bug.
Code
type A = { type: "a", x: number }
type B = { type: "b", x: number, y: number }

type Z = A | B

function f(z: A): { x: number, y: undefined }
function f(z: B): {x: number, y: number}
function f(z: Z) {
	if (z.type === "a") {
		return {x: z.x, y: undefined}
	} else {
		return {x: z.x, y: z.y}
	}
}

// This works
const a = f({ type: "a", x: 1 })
const b = f({ type: "b", x: 1, y: 1 })

// Why doesn't this work?
function g(z: Z) {
	const x = f(z)
}

// This also doesn't work.
function h<T extends Z>(z: T) {
	const x = f(z)
}

Expected behavior:
Given that I've included the union type in the definition, I would expect the function to be able to accept the union type.
Actual behavior:
Doesn't work
Playground Link:
Playground

Duplicate of https://github.com/Microsoft/TypeScript/issues/14107

Thanks!


Implement data URL support in fetch

As part of the effort to make our fetch impl more spec compliant and align with other runtimes... provides an implementation of data: URL support in fetch. The implementation here is based on the fetch spec algorithm https://fetch.spec.whatwg.org/#data-urls ... tho it is a bit more forgiving of invalid base64 inputs than the spec, which should be ok but we can tighten it up later if necessary.
We might want to put this behind an experimental flag for a bit. Open to opinions.
(~670 of new lines of code added of the +838 - 6 are tests)

Needs a few small tweaks still to deal with test breaks.

This is ready for an initial review but I'm likely to tweak it a bit more before landing.

Why is this the case?

Largely because our existing base64 implementation in kj is more forgiving and not sure it's worth the effort to make it stricter for this one case. If we need to we can introduce a compat flag and add a stricter implementation


[WIP] Don't require selinux utils and require k3s_selinux

If you are installing k3s on a selinux enforcing system then we
required that you also install k3s_selinux RPM to put in the proper
policy.

This PR requires the SELinux support to be merged and also the k3s_selinux RPM to be readily available (currently at https://github.com/ibuildthecloud/k3s-selinux/)

Merging as k3s-selinux rpm available at https://github.com/rancher/k3s-selinux/releases/download/v0.1/k3s-selinux-0.1-1.el7.noarch.rpm and the rancher repo, with docs to be update with more info.


Integrated Terminal does not work

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: latest insiders build
OS Version: WSL 2 Ubuntu 20.04

Steps to Reproduce:

Open vscode
Open terminal

Expected Output: terminal opens
Ouput Recieved: terminal opens but blank, takes no input neither gives any output

Maybe a duplicate of #133442


Swedish translation

Hi, I'd like to help translate the project to swedish, since it's my native tongue.

...and by opening this issue I would like someone to add Swedish(sv-SE) to the crowdin page.
:)

Sorry, it got lost in the translation :). https://crowdin.com/translate/excalidraw/10/en-sv
How do you say "Swedish" in Swedish for the language picker?

"Svenska"
Thanks, will begin translating :)

Should be live soon :)

Awesome! 👍

If you notice something is wrong.. you can always update it in Crowdin and we'll get the changes automatically!


fix(edit/workload): add weight to tabs

Fixed tab order to prevent tab order from changing when switching languages
https://github.com/rancher/rancher/issues/34802

If there is a default alphabetical sort order on tabs this problem would also exist elsewhere. Need to decide if this should be disabled by default or an order applied in other tab components

The target of this PR also needs to be master (for 2.6.x releases)


Make a couple improvements about results output and add missing profile

This PR does the following:

A couple improvements/changes aligned with the latest gnbsim image that uses zap logger instead of logrus
Add missing profile (profile8) to the configuration files that are missing it (Profile is disabled by default) and the purpose of adding it is for the users to be aware of the existence of this profile

@llpeterson @mbilal92, please your help reviewing this PR. Thanks!


Add table properties for athena create csv

Is your idea related to a problem? Please describe.
I am trying to automate my athena table creation for multiple environments. CSV are loaded into s3 unedited. When I create the table with the UI it detects a header row. With this package it doesnt.
Describe the solution you'd like
Add TBLPROPERTIES like skip.header.line.count"="1 to create_csv_table

Hi @kylepierce, thank you for reach out.
Could you paste here the code snippet where you are trying do create it?

I dont see it in the boto3 docs so maybe its not supported at the moment.
Ideally it would be a dict that can accept other table properties. (last line)
wr.catalog.create_csv_table(     database='lake',     table='table',     path='path',     columns_types=data,     compression='gzip',     description='My own table!',     parameters={'source': 'postgresql'},     table_properties={'skip.header.line.count': "1"} )

data refrences a dict
{     "name": "varchar(100)",	     "clicks": "bigint",	     "sum": "double" }

@kylepierce!
I've already added the skip_header_line_count as a new argument to our development branch. Do you mind to test it?
The ideia is release it in the next version 1.7.0 this week.
pip install git+https://github.com/awslabs/aws-data-wrangler.git@dev

P.S. For details see the related commit.
P.P.S. For the documentation related to the development branch see.
P.P.P.S By now it only support the LazySimpleSerDe (And not the OpenCSVSerDe), so quoted values will work.

Wow thanks! Works as a test.

Looking at your P.P.P.S is there any way to specify which SerDe I want to use or because it is a csv I am locked into "LazySimpleSerDe"?
I have a table that has every value quoted. I see that one of the parameters is "areColumnsQuoted" and that marked false as default.
Maybe I am trying to use this package too much and should look at just using DDL creation directly.

Released in 1.7.0!

@kylepierce about the OpenCSVSerDe support, if you still want it, could you please open a separated issue for that?

Hi @kylepierce !
It is totally off-topic, but we are stating a "Who uses AWS Data Wrangler?" section. So feel free to add yourself if you want 😄 .


Other HyperX headset support?

How difficult would it be to implement support for other headsets, and if not difficult, what is required from owners of other HyperX headsets? (I personally own a wireless Cloud 2)

Since I don't have access to Cloud 2 it would be hard for me to add support, but if you have the knowledge you can always capture the bytes sent/received on the official hyperx application on windows.

I would love to do whatever is necessary to get support, if there's perhaps a short guide on how to do this? (I'm assuming the data is similar to the cloud flight, so only a slight change is necessary).

I would help contribute too I have the ID's for the Cloud 2 Wireless from Linux

Sure

The tool mentioned here doesn't seem to select the correct interface (on windows). I managed to get some code working in Python for supporting HyperX Cloud II wireless although I am faced with the following issue, after writing to the device I get a reply from the headset (status, as a list) of which I can get the necessary information. However after that the device is unresponsive unless I open up NGenuity again. I don't know why it only replies to my first buffer only. I have attached some screenshots and any help is appreciated

Hey, could you share your code regarding that and especially how you found out the HardwareID which you specified there?

With this tool, could you run:
./hidapitester --vidpid 0951:1718 --open --read-input-forever

and capture all the events? i.e. Do an action and capture the corresponding output. Actions beeing:
* Mute

* UnMute

* VolumeUp

* VolumeDown

* PowerOn

* PowerOff

I've attached a file of all recordings for each action for the HyperX Cloud II Wireless. Let me know if there's any other info I can provide. I'll leave the byte sniffer running to see if it will catch a battery percent report.
HID-OUTPUT-HYPERX-CLOUDII-WIRELESS.txt

I would help contribute too I have the ID's for the Cloud 2 Wireless from Linux  I tried changing the ID's on the cloud_flights files but I think that is not as easy.

My Cloud II has a different ID:
Bus 001 Device 002: ID 03f0:018b HP, Inc HyperX Cloud II Wireless

I would help contribute too I have the ID's for the Cloud 2 Wireless from Linux  I tried changing the ID's on the cloud_flights files but I think that is not as easy.

My Cloud II has a different ID: Bus 001 Device 002: ID 03f0:018b HP, Inc HyperX Cloud II Wireless

HP acquired HyperX in 2021. Your headset must be manufactured after that acquisition date, ours would be before. There shouldn't be anything different other than the vendor ID/product ID. However, I would test the hidapitester mentioned above to make sure the byte readings are the same at the txt I submitted.

I would help contribute too I have the ID's for the Cloud 2 Wireless from Linux  I tried changing the ID's on the cloud_flights files but I think that is not as easy.

My Cloud II has a different ID: Bus 001 Device 002: ID 03f0:018b HP, Inc HyperX Cloud II Wireless

HP acquired HyperX in 2021. Your headset must be manufactured after that acquisition date, ours would be before. There shouldn't be anything different other than the vendor ID/product ID. However, I would test the hidapitester mentioned above to make sure the byte readings are the same at the txt I submitted.

I will get my ID's and upload them here

I would help contribute too I have the ID's for the Cloud 2 Wireless from Linux  I tried changing the ID's on the cloud_flights files but I think that is not as easy.

My Cloud II has a different ID: Bus 001 Device 002: ID 03f0:018b HP, Inc HyperX Cloud II Wireless

HP acquired HyperX in 2021. Your headset must be manufactured after that acquisition date, ours would be before. There shouldn't be anything different other than the vendor ID/product ID. However, I would test the hidapitester mentioned above to make sure the byte readings are the same at the txt I submitted.

I didn't think it'd change anything, just mentioning it for compatibility with both versions.

Using Wireshark, I was able to identify the specific packet required to be sent to the headset to obtain the battery level. Additionally, I learned how to properly interpret the response, which differs from that of the HyperX Cloud Flight.
Packet to get battery level:
[0x06, 0xff, 0xbb, 0x02, 0x0, 0x0, 0x0, 0x0]
The response has a length of eight and the last byte is the battery level.
Using this information I have implemented my own system tray application https://github.com/LennardKittner/HyperXCloudIIWireless.


Next step, the search bar

I will have to work on the search bar to make it functional and allow the user to search for a movie in the TMDB database. This will not necessarily be very complicated since the main logic of the application is now constituted.

It is now added and it allows to search TV series by name, directly on the movie database


Color Type Expression Fixes

Added some fixes to the color type to be up to date with the Spec-

Made color() Pascal case - Color()
Gave Color() an optional second argument for alpha
rgb, hsl, rgba, and hsla requie all their arguments.

And updated the tests to reflect these changes.

:+1:


Nested projects with multiple .eslintrcs and ESLint installations

I work on a project where the backend (Node.js) and frontend (Angular) are using entirely separate ESLint installations and configs:
Backend
https://github.com/bkimminich/juice-shop/blob/master/.eslintrc.js with
    "eslint": "^7.16.0",
    "eslint-config-standard": "^16.0.2",
    "eslint-plugin-import": "^2.22.1",
    "eslint-plugin-node": "^11.1.0",
    "eslint-plugin-promise": "^4.2.1",

installed in ./node_modules
Frontend
https://github.com/bkimminich/juice-shop/blob/master/frontend/.eslintrc.js with
    "eslint": "^7.16.0",
    "eslint-config-prettier": "7.1.0",
    "eslint-config-standard-with-typescript": "^19.0.1",
    "eslint-plugin-import": "^2.22.1",
    "eslint-plugin-jsdoc": "^30.7.9",
    "eslint-plugin-node": "^11.1.0",
    "eslint-plugin-promise": "^4.2.1",
    "eslint-plugin-standard": "^4.1.0",

installed in ./frontend/node_modules
✔ Command Line
Works fine as both eslint calls happen from the respective folder, so the right installation and config is pulled.
✔ IntelliJ IDEA
Works fine with their respective ESLint plugin as it searches for configs/installations bottom up and finds the frontend installation first when checking a file in that folder. (User impression, not technically verified - but it works,,, 😄)
❌ GitHub Codespaces
Seems to always use the root folder installation and config, so only backend file linting works as it should. Frontend files throw an error when trying to lint:
[Info  - 10:15:31 AM] ESLint server is starting
[Info  - 10:15:31 AM] ESLint server running in node v12.18.3
[Info  - 10:15:31 AM] ESLint server is running.
[Info  - 10:15:50 AM] ESLint library loaded from: /home/codespace/workspace/juice-shop/node_modules/eslint/lib/api.js
[Info  - 10:16:17 AM] Error while loading rule '@typescript-eslint/dot-notation': You have used a rule which requires parserServices to be generated. You must therefore provide a value for the "parserOptions.project" property for @typescript-eslint/parser. Occurred while linting /home/codespace/workspace/juice-shop/frontend/src/app/about/about.component.ts

Seems that setting "eslint.workingDirectories": [{ "mode": "auto" }] was all I needed... 🤦

Seems that setting "eslint.workingDirectories": [{ "mode": "auto" }] was all I needed... 🤦


Add support form multiple ranges

The S3 protocol allows for requesting multiple byte ranges as part of GetObject requests.

Multiple ranges are not supported on AWS S3


⚠ Bofrost.de has degraded performance

In 8aec32f, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1682 ms

Resolved: Bofrost.de performance has improved in 659992c after 6 minutes.


Snakemake won't run more than 2 concurrent jobs even though jobs are "runnable" and there's resource availability

Describe the Bug
Snakemake workflows with N>2 available nodes limit job execution to only 2 concurrent jobs.
Steps to Reproduce

Create a snakemake workflow that requires multiple "parallelizable" jobs
Monitor the logs.

You'll notice that while Snakemake is aware of the existence of the cores, and knows to flag those as "ear marked" for execution (batch status RUNNABLE) it will only ever run 2 concurrent jobs. For convenience, I've created this sample project to reproduce the problem.
Relevant Logs
The sample project above produces this log file. If you scroll down you'll notice (visually) there's only ever 2 logStreamName entries even though all jobs are independent except for the last one.
Expected Behavior
I would expect for more than 2 jobs to run concurrently.
Actual Behavior
Only two jobs are run concurrently.
Screenshots
Additional Context
The project's manifest file and yaml should be both configured to run more than 2 concurrent jobs.
Operating System: macOS 12.3.1
AGC Version: 1.4.0
Was AGC setup with a custom bucket: no
Was AGC setup with a custom VPC: no

I was able to reproduce this problem using spot instances too.

This issue was sorted out by submitting a request to increase the vCPU limit on my account. The process is fairly straightforward except it took a few days for the changes to reflect.


Add option to disable color output

At the moment, the functionality of himalaya does not really suit me and I am writing some scripts for experimentation. However, in the scripts I have to clear the colors in order for himalaya to get the correct input data. It would be great to add an option that removes colors from the result

https://github.com/BurntSushi/termcolor#automatic-color-selection
Solved my problem
NO_COLOR=1 himalaya list

Yes indeed, there is a section about it in the wiki https://github.com/soywod/himalaya/wiki/Tips:disable-colors.


Two small improvements

Hi Seth,
I fell on small troubles that lead me to write these two changes.
Cheers,
Patrick

@monnerat Thanks for the improvements!


Setup container scanning on-push

Setup container scanning on-push with Snyk

GitHub Actions that I'll use:

https://github.com/snyk/actions/tree/master/docker
https://github.com/snyk/actions/tree/master/golang

This will be incorporated in master/nightly build.

This is setup to scan Dockerfile during PRs:

Maintainers can view the report in Snyk, unfortunately we cannot make it public.

/cc @idvoretskyi

/cc @idvoretskyi

@tomkerkhove I think this is alread done, am I right?

@tomkerkhove I think this is alread done, am I right?

Yes, through their integration but checking with CNCF to get more insights and apparently GH Actions is the best way to go!

Yes, through their integration but checking with CNCF to get more insights and apparently GH Actions is the best way to go!

@tomkerkhove what is the issue with the Snyk app/integration?

Nothing, but I thought you wanted to use GitHub Actions instead of it because of our open Snyk Pro ticket?


Add build instructions to readme

Spruce up readme with build and test instructions for the project.

Thanks!


Bar/column etc not supported for non-number facets?

No data is being shown, and you get a highcharts error nr 14. I think it means xAxis requires using categories for non-number values..

Ah wait, after examining the code I start to understand I need to use the xAxisCategoriesMLConstraint * instead * of xAxisMLConstraint. I thought the first could only be used in addition to the latter..

After further experimenting (see http://github-search.demo.marklogic.com for the result), I noticed using x categories constraint makes it work better, but not perfect either. And there seems to be no support for y categories either, which is important to make proper use of bubble charts (on both non-numeric x and y values)..


Add trailing return type

Checklist

[x] This problem exists even with the setting "C_Cpp.enhancedColorization": "Disabled"
[x] This bug exists for C
[x] This bug exists for C++
[ ] This bug exists for Objective-C
[ ] This bug exists for Objective-C++

The code with a problem is:
Deleter &
get_deleter() noexcept
{
    return m_deleter;
}

const Deleter &
get_deleter() const noexcept
{
    return m_deleter;
}

auto
get_deleter() noexcept -> Deleter &
{
    return m_deleter;
}

auto
get_deleter() const noexcept -> const Deleter &
{
    return m_deleter;
}

It looks like:
** screenshot + theme name preferable **

It should look like:
"const" and "noexcept"  show different colors based on return type. It appears that trailing returns are not highlighting properly

As shown here, "const" and "noexcept" are not the same color, and "Deleter" changes color as well

This is due to a lack of support for trailing return types.
@jeff-hykin
Additionally, keywords should be avoided inside the member access.

Hmmm I thought we had a previous issue about trailing return types but I can't find it.
Sadly @rianquinn , as Matter123 said, we haven't worked on trailing return types yet so all highlighting for them (if any) is accidental. Current highlighting is probably from pointer access e.g.this->member_var

additionally (just fyi) having auto on the line-before and the { on the line after would make it nearly impossible for the parser to know get_deleter() was a function-definition and not a function call, which would change how the trailing return type was parsed even once we do have support.

A trailing return type is the only valid syntax that looks like that in the function head.

Previous discussion https://github.com/jeff-hykin/cpp-textmate-grammar/issues/371

Care needs to be taken about user-defined template deduction guides.
template<class C>
A(C b) -> typename C::type

Though I am not sure that there actually is a difference un how syntax highlighting would be performed.

Related on VS Code: VS Code syntax highlighting issue when explicitly specifying return type for C++ lambda function


F1 on Ubuntu does not open help

Description of the problem or steps to reproduce
F1 opens the Terminal help, not the micro help
Specifications
You can use micro -version to get the commit hash.
Version: 1.3.4-1
Commit hash: ac29e30
Compiled on September 29, 2017
OS: Ubuntu 16.04
Terminal: regular terminal that comes with Ubuntu

Suggestion: show "CtrlG" as default suggestion to get help, instead of "F1"

It seems like in gnome terminal, the terminal doesn't send the F1 key event.

may be F1 is already bound to gnome-terminal help :) I don't use it anymore but AFAIK F10 is bound to gnome-terminal menu? so it doesn't work to turn off midnight commander. This feature was customizable in gnome-terminal settings.

so basically not usable on Ubuntu then? (since without help I cannot even figure out the key bindings)

turn it off
https://askubuntu.com/questions/58147/how-do-i-disable-the-help-f1-key
or press Ctrl+G instead of F1

F1 has been disabled as a default keybinding in one of the latest commits. You can always rebind it but you should use CtrlG to open the help.


Updated links about jwt critical vulnerability

It's a minor improvement: but the reported url for "Critical vulnerabilities in JSON Web Token libraries" is changed

Too bad that auth0 did not implement redirects for their old URLs...


Fix json_annotation and generator tests

Increase json_annotation version to ^4.7.0.
Regenerate metrics.g.dart

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+4.1%) to 92.558%

Totals

Change from base Build<PHONE_NUMBER>:
4.1%

Covered Lines:
398

Relevant Lines:
430

💛  - Coveralls


DateExtensionsTests.swift fixed. currentYear - 1 is 2017 since today.

I fixed issue in DateExtensionsTests.swift.
There're hardcoded values for date.add() method. I updated to actual values - 2017 (year-1), 2018 (current year)
Checklist

[x] I checked the Contributing Guidelines before creating this request.
[x] New extensions are written in Swift 4.
[x] New extensions support iOS 8.0+ / tvOS 9.0+ / macOS 10.10+ / watchOS 2.0+.
[x] I have added tests for new extensions, and they passed.
[x] All extensions have a clear comments explaining their functionality, all parameters and return type in English.
[x] All extensions are declared as public.

          1 Message

:book:
Thank you for submitting a pull request to SwifterSwift. The team will review your submission as soon as possible.

  Generated by :no_entry_sign: Danger


Arabic translation of oauth2server.php

@XZzYassin Could you update your PR in accordance of the master branch. I've made refactor.


replaced map api with an image link

it would be better to have an image link instead of map api for easy scrolling

well done


Error cloning public git repository referenced in requirements.txt

Details

Project URL: https://github.com/chuck1/ws_sheets_server/tree/dev
Build URL (if applicable): https://readthedocs.org/projects/ws-sheets-server/builds/5586161/

Expected Result
When RTD gets to
-e git+git@github.com:chuck1/ws_storage.git@7b8960e628922d2336f1beda6407e447d9fc92d6#egg=ws_storage

in requirements.txt, it should clone the repo and install from source. The requirements file was created automatically by pip3 freeze.
Actual Result
RTD fails to clone the repo. This is a public repository and it does indeed exist.
Obtaining ws_storage from git+git@github.com:chuck1/ws_storage.git@7b8960e628922d2336f1beda6407e447d9fc92d6#egg=ws_storage (from -r /home/docs/checkouts/readthedocs.org/user_builds/ws-sheets-server/checkouts/dev/requirements.txt (line 13))
  Cloning git@github.com:chuck1/ws_storage.git (to 7b8960e628922d2336f1beda6407e447d9fc92d6) to /home/docs/checkouts/readthedocs.org/user_builds/ws-sheets-server/envs/dev/src/ws-storage
ssh: connect to host github.com port 22: Connection timed out
fatal: Could not read from remote repository.

Hi @chuck1! It seems the problem was already solved. Looked like the repositories permission were wrong for some reason.
I'm closing this issue. Please, feel free to reopen if you consider. Thanks


Stylise buttons

Is there any way of adding icons or making a more stylized menu ? Something like the bottom sheets on android https://www.google.com/design/spec/components/bottom-sheets.html?utm_campaign=android_launch_supportlibrary23.2_022216&utm_source=anddev&utm_medium=blog

You can make your own picker with react-native components. We expose two function that was meant for this purpose.
https://github.com/marcshilling/react-native-image-picker#directly-launching-the-camera-or-image-library

What he said ^
Closing.


Connecting to mysql container

I am trying to get my lambda connecting to my mysql container with docker-compose from my lambda with sam-local.  Typically, I am able to access the database with the name of the mysql service, ie: mysql, but I get an error saying it's not found.
lambda_1           | 2019-06-26T12:55:40.591Z	52fdfc07-2182-154f-163f-5f0f9a621d72	INFO	{ Error: getaddrinfo ENOTFOUND    at GetAddrInfoReqWrap.onlookup [as oncomplete] (dns.js:56:26)
lambda_1           |     --------------------
lambda_1           |     at Protocol._enqueue (/var/task/node_modules/mysql/lib/protocol/Protocol.js:144:48)
lambda_1           |     at Protocol.handshake (/var/task/node_modules/mysql/lib/protocol/Protocol.js:51:23)
lambda_1           |     at PoolConnection.connect (/var/task/node_modules/mysql/lib/Connection.js:119:18)
lambda_1           |     at Pool.getConnection (/var/task/node_modules/mysql/lib/Pool.js:48:16)
lambda_1           |     at /var/task/node_modules/typeorm/driver/mysql/MysqlDriver.js:764:18
lambda_1           |     at new Promise (<anonymous>)
lambda_1           |     at MysqlDriver.createPool (/var/task/node_modules/typeorm/driver/mysql/MysqlDriver.js:761:16)
lambda_1           |     at MysqlDriver.<anonymous> (/var/task/node_modules/typeorm/driver/mysql/MysqlDriver.js:274:51)
lambda_1           |     at step (/var/task/node_modules/tslib/tslib.js:133:27)
lambda_1           |     at Object.next (/var/task/node_modules/tslib/tslib.js:114:57)
lambda_1           |   errno: 'ENOTFOUND',
lambda_1           |   code: 'ENOTFOUND',
lambda_1           |   syscall: 'getaddrinfo',
lambda_1           |   hostname: 'mysql',
lambda_1           |   host: 'mysql',
lambda_1           |   port: '3306',
lambda_1           |   fatal: true }

Below is my docker-compose file.
version: '3.6'
services:
  lambda_yarn_app:
    image: lambci/lambda:build-nodejs10.x
    volumes:
      - ../:/var/task

  lambda:
    build:
      context: .
      dockerfile: Dockerfile.sam
      args:
        PORT: '3001'
        SAM_CMD: start-lambda
    # we depend on the mysql backend
    depends_on:
      - mysql
    environment:
      - TYPEORM_HOST=mysql
      - TYPEORM_PORT=3306
      - AWS_ACCESS_KEY_ID
      - AWS_SECRET_ACCESS_KEY
    command: ["$PWD"]
    ports:
      - "3001:3001"
    volumes:
      - ../:/app
      - /var/run/docker.sock:/var/run/docker.sock

  api:
    build:
      context: .
      dockerfile: Dockerfile.sam
      args:
        PORT: '3000'
        SAM_CMD: start-api
    # we depend on the mysql backend
    depends_on:
      - mysql
    command: ["$PWD"]
    ports:
      - "3000:3000"
    volumes:
      - ../:/app
      - /var/run/docker.sock:/var/run/docker.sock

  mysql:
    # just using the base image
    image: mysql:5.6
    container_name: mysql
    # map the container port 3306 back to port 3333 on our host
    ports:
      - "3333:3306"
    environment:
      MYSQL_ROOT_PASSWORD: root
      MYSQL_USER: theusername
      MYSQL_PASSWORD: thepw
      MYSQL_DATABASE: subscription
    # the *.sql files in this dir will be run when the volume is first created
    volumes:
      - ./data:/docker-entrypoint-initdb.d

I found an example here: https://github.com/JontyC/SAM-Docker-MySQL/blob/master/docker-compose.yml, but it's using an outdated version of docker-compose.

I figured out the issue.  If my understanding is correct, SAM local starts another container inside the container for the lambda to run in.  This does not explicitly have access to the network, so it needs to be defined.
By defining the network in my docker-compose.yml file, my lambda was able to access my mysql container via host mysql.
networks:
  default:
    external:
      name: sam_default

@jeremymcjunkin I'm glad you figured out the issue! Your understanding is correct, the SAM container starts another container. From Running AWS SAM in a Docker Container:

This is the key to running SAM in a Dockerized environment, as SAM itself will spawn a Docker container. The mounted and bound Docker socket effectively allows the SAM container to spawn alongside the parent container as a sibling instead of a child.

FWIW I am not sure that the networks directive is required- I have had success adding a postgres container to the example docker-compose.yaml and connecting to this database via index.ts without the networks directive.


Script attachment on a scene node does not register as dirty (in need of saving)

Operating system or device:
windows7 64-bit
Godot 2.0 stable
Issue description (what happened, and what was expected):
open an existing scene with unscripted root node
use the create script wizard to add script to the node
[get distracted by a phone call, bladder or other AFK event]
close the scene
The problem here is Godot does not register the creation of a script on a node as an action that 'dirties' the scene (meaning it needs saving).  Worse if the scene is then closed (but the script generated was modified and saved) it becomes impossible to reattach the orphaned script because the create script wizard sees the file already exists,
Steps to reproduce:
create new scene
add a root node (I used a Node2D)
save the scene
use script wizard to create script for the node
edit script content then save the script (not the scene) in the script editor
[at this point the scene is still "dirty" as it has an unsaved script relationship that will be lost if the scene is closed at this point.  however Godot editor is not aware of this and thus not indicating it to the user with a * nor warning the user when the scene (or godot editor) is subsequently closed. if the designer gets interrupted AFK while the scene is in this state there is a good probability the scene will be closed and the unsaved script relationship lost.  Furthermore it will become impossible to reattach the scene when the user reloads the scene (and finds it no longer links the script) since the wizard complains that the file already exists.]
Link to minimal example project (optional but very welcome):
The reproduction is simple enough I doubt a project is needed.

PS: I was using the external file mode of the create script wizard, rather than the built-in mode.

@gau-veldt ~ As a workaround, if you scroll down in the inspector, you will see the script property to which you can assign the previously created script (via "Load").

Good catch, I'll have to remember that workaround.

This is still true on Godot 2.1.5, and Godot 3.0.6
If you don't save the scene after creating a script, it doesn't register as changed, so if you close the scene without saving it will not open a popup to save changes, and reopening it you will have a null script reference on the root node.

Fixed in 3.1

Closing as fixed then. If it is still a problem in 3.0 or 2.x, the fix might potentially be cherry-picked.


New sdk version

Codecov Report

Merging #5 (22b63ce) into main (bba9c0d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main       #5   +/-   ##
=======================================
  Coverage   86.41%   86.41%
=======================================
  Files           2        2
  Lines          81       81
  Branches       15       15
=======================================
  Hits           70       70
  Misses         11       11

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bba9c0d...22b63ce. Read the comment docs.


Broken weak object scope

Hello, I use next register-resolve scheme
register(Protocol.self) { _ in
    ProtocolImpl()
}.inObjectScope(.weak)
resolve(Protocol.self)
when I migrate to Xcode 10 and Swift 4.2 this register-resolve start produce new object instance every object resolve
when I try next scheme
register(ProtocolImpl.self) { _ in
    ProtocolImpl()
}.inObjectScope(.weak)
resolve(ProtocolImpl.self)
object instance has become singleton how I expected.
please say me, I made a mistake or this is bug?

I'm experiencing the same issue.
Once upgraded to xCode 10.0, with Swift 4.2 and Legacy Build System as the workspace settings, I can see that each resolve made, I'm getting a new instance, even though I'm holding a strong reference of it.

What version of Swinject are you using? This looks like an issue that should have been fixed by 2.5.0.

I'm using version 2.4.1..
I'll update it and see if it helps...

Closing due to inactivity


false positives

Describe the bug
A clear and concise description of what the bug is.
I have been getting some false positives with ghauri of payloads that in theory shouldn't give any false positive.
For example I got the following alert from ghauri while using --confirm:
Parameter: ref (GET)
    Type: error-based
    Title: MySQL >= 5.5 AND error-based - WHERE, HAVING, ORDER BY or GROUP BY clause (BIGINT UNSIGNED)
    Payload: jdgm_referral_location=all_products&ref=google.com AND (SELECT(!x-~0)FROM(SELECT CONCAT_WS(0x28,0x496e6a65637465647e,0x72306f746833783439,0x7e454e44)x)y)-- wXyW&utm_campaign=google-review-site&utm_medium=referral&utm_source=google

If I am not wrong the payload AND (SELECT(!x-~0)FROM(SELECT CONCAT_WS(0x28,0x496e6a65637465647e,0x72306f746833783439,0x7e454e44)x)y)-- wXyW should be trying to inject:
Inject~(r0oth3x49(~END, but I am not seeing that string or anything similar in the response. Of course all the following flags don't return any info:
  -b, --banner        Retrieve DBMS banner
  --current-user      Retrieve DBMS current user
  --current-db        Retrieve DBMS current database
  --hostname          Retrieve DBMS server hostname
  --dbs               Enumerate DBMS databases
  --tables            Enumerate DBMS database tables
  --columns           Enumerate DBMS database table columns

So I have to validate manually but I don't see why ghauri would alert if as a valid confirmed sqli (i got quite of lot of false positives like this one).

I might need a target to test otherwise I cannot help fix this as I never faced such issue. You can email on my mail<EMAIL_ADDRESS>


Feature/eslint

Closes #1466
Changes

Add ESLint to project dev dependencies
Add Airbnb base rules
Add Meteor lint rules
Add Babel lint rules
Ignore third party libraries in our sourcecode

@brylie, how can I test it?

@brylie, did next:

Installed https://github.com/AtomLinter/linter-eslint
meteor npm install
meteor npm run lint

Getting:
30009 problems (27804 errors, 2205 warnings)

@nnn jep. We have a lot of lint. I was able to get the number of errors down to around 5,000 by ignoring third party libraries:

5059 problems (4654 errors, 405 warnings)

Calling eslint --fix . reduces the number of issue by half:

2427 problems (2148 errors, 279 warnings)

Tested. Works as expected! I would only suggest to add one rule: since we used to add spaces before function parenthesis, this helps :
package.json
"rules": {
      "space-before-function-paren": ["error", { "anonymous": "always", "named": "always" }]
    }

Source

@nnn and/or @frenchbread will this be merged today, or is more work needed?

Looks good to me. Unless you are still committing here, I'll merge this.

Cool. I don't have any more edits.


ASCII art output

Howdy Danilo,
in check-in 1461ef99b9e757c9 on www.androwish.org I've added a method to produce ASCII art from the image's bytearray. Just for fun. If you find it useful, I'd be glad if you take it over.
BR,
Christian

Thank you for your effort.

It is done to merge code, so I close this.


bug: Neoconf loads lspconfig for health check

Did you check docs and existing issues?

[X] I have read all the neoconf.nvim docs
[X] I have searched the existing issues of neoconf.nvim
[X] I have searched the existing issues of plugins related to this issue

Neovim version (nvim -v)
0.9.0
Operating system/version
Windows 11
Describe the bug
When neoconf is loaded it internally loads "lspconfig" to check if any servers are already active.
https://github.com/folke/neoconf.nvim/blob/bbf98ce53481e6e8d6507de5a6f18d3264fb0df7/lua/neoconf/health.lua#L66-L75
This is fine if the only thing using neoconf are plugins that are also dependencies of lspconfig but when an external dependency (especially one that is loaded earlier than lspconfig) is ran it will cause neoconf to load lspconfig before it returns (which in this configuration loads a lsp server).
Steps To Reproduce

have something earlier than lspconfig depend on neoconf
run neovim and get

Setup require("neoconf").setup() should be run BEFORE setting up any lsp server with lspconfig

Expected Behavior
Neoconf doesn't load lspconfig which creates the server but instead has some way of initializing without fetching the server count or solve it some other way that I haven't thought of
Repro
-- DO NOT change the paths and don't remove the colorscheme
local root = vim.fn.fnamemodify("./.repro", ":p")

-- set stdpaths to use .repro
for _, name in ipairs({ "config", "data", "state", "cache" }) do
  vim.env[("XDG_%s_HOME"):format(name:upper())] = root .. "/" .. name
end

-- bootstrap lazy
local lazypath = root .. "/plugins/lazy.nvim"
if not vim.loop.fs_stat(lazypath) then
  vim.fn.system({ "git", "clone", "--filter=blob:none", "https://github.com/folke/lazy.nvim.git", lazypath, })
end
vim.opt.runtimepath:prepend(lazypath)

-- install plugins
local plugins = {
  "folke/tokyonight.nvim",
  	{
		'glepnir/dashboard-nvim',
		event = 'VimEnter',
		opts = function() return require 'neoconf'.get("plugins.dashboard", {}) end
	},
    {
		'neovim/nvim-lspconfig',
		config = function()
			local lspconfig = require 'lspconfig'
            lspconfig.lua_ls.setup {}
		end,
		event = "BufAdd",
		dependencies =
		{
			"folke/neoconf.nvim"
        }
    }
}
require("lazy").setup(plugins, {
  root = root .. "/plugins",
  defaults = {lazy = true}
})

vim.cmd.colorscheme("tokyonight")
-- add anything else here

A few possible solutions

Just not use neoconf to overwrite the options (my current temporary fix)
Don't initialize lspconfig in the config step (makes the code less clean)

oh I see you added stalebot, I will have to verify that this is still happening but this is still a relevant issue

That has been fixed at some point

Awesome. Thank you so much <3


Finance dashboard

A financial dashboard to upskill your financial knowledge,get latest news,check real time crypto prices all in one platform.
Tech stack- HTML,CSS ,JS

@ansharora28 are you working on this issue? If so, please create a PR and link the issue to it. If not, please let us know so that we can assign someone else willing to work on it.

Hi, I would not be able to work on this due to some commitments. You may assign it to someone else.Thanks!

Hi, I would not be able to work on this due to some commitments. You may assign it to someone else.Thanks!

Okay then I'm closing the issue!


Update Readme with correct link for Classroom

There's also issue with count of images available, updated same.

This PR should be merged to provide correct links


Edit button in demo pages doesn't work even with gulp serve in Safari10

Description
Edit button in demo pages' properties container doesn't work with polymer serve(which could be ok since a limited number of people will serve it up that way).
It does work when you gulp serve in Chrome and FF, but not in Safari10.
Filing this issue to keep track of it until we figure out if our dev team will fix or Vaadin team.

I think this has been fixed now.


Issue in Unit testing framework when a sequence with call mediator wrapped in an API

Description:

Create an API as below.

<?xml version="1.0" encoding="UTF-8"?>
<api context="/healthcare" name="HealthcareAPI" xmlns="http://ws.apache.org/ns/synapse">
    <resource methods="POST" uri-template="/categories/{category}/reserve">
        <inSequence>
            <property expression="json-eval($.hospital)" name="hospital" scope="default" type="STRING"/>
            <log level="custom">
                <property expression="fn:concat('Routing to ', get-property('Hospital'))" name="message"/>
            </log>
            <datamapper config="gov:datamapper/NewConfig.dmc" inputSchema="gov:datamapper/NewConfig_inputSchema.json" inputType="JSON" outputSchema="gov:datamapper/NewConfig_outputSchema.json" outputType="JSON" xsltStyleSheet="gov:datamapper/NewConfig_xsltStyleSheet.xml"/>
            <sequence key="GrandOakSeq"/>
            <call>
                <endpoint key="GrandOakEP"/>
            </call>
            <log level="full">
                <property name="response " value="response"/>
            </log>
            <respond/>
        </inSequence>
        <outSequence/>
        <faultSequence/>
    </resource>
</api>

Note: please find the attached workplace having supportive artifacts.

Run a test pointing to the API.

It will fail at the call mediator.

[2019-10-02 12:38:14,866]  WARN {API_LOGGER.HealthcareAPI} - Executing fault handler due to exception encountered
[2019-10-02 12:38:14,867]  WARN {API_LOGGER.HealthcareAPI} - ERROR_CODE : 0 ERROR_MESSAGE : Continuation Stack Empty! Cannot proceed with the call

newWorkPlace.zip

similar issue in https://github.com/wso2/devstudio-tooling-ei/issues/699

Hi @sajithaliyanage can I ask if this issue is fixed since it is closed?

Hi @rapax87, we have moved this issue to the https://github.com/wso2/devstudio-tooling-ei/issues/699.


feat: add Event card and perks card

Your checklist for this pull request
🚨Please review the guidelines for contributing to this repository.

[ ] Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your default branch!
[ ] Make sure you are making a pull request against the default branch (left side). Also you should start your branch off default branch.
[ ] Check the commit's or even all commits' message styles matches our requested structure.
[ ] Check your code additions will fail neither code linting checks nor unit test.
[ ] I have added necessary documentation (if appropriate)

Description
Added Events Card and Perks card
❤Thank you!
Post merge checklist

[ ] Follow steps from the guidelines for contributing to this repository.
[ ] If you are a new contributor, ping in the thread and one of the maintainers will add you to all-contributors list.

@ORKO06

resolve the conflicts
fix the event card spacing issues and border radius, the know more button is in black color, change it to the appropriate colour


RandomPause & CompleteTutorial & UpdateLiveInventory Not Defined Error

In config.json.example there is RandomPause task but if I add that task to my config file bot doesn't start. It throws error: "No worker named RandomPause defined"
My config file: http://pastebin.com/ccCGSQKz
Traceback (most recent call last):
  File "pokecli.py", line 570, in <module>
    main()
  File "pokecli.py", line 91, in main
    tree = TreeConfigBuilder(bot, config.raw_tasks).build()
  File "C:\Users\oralu\Desktop\pokebot\PokemonGo-Bot\pokemongo_bot\tree_config_builder.py", line 54, in build
    worker = self._get_worker_by_name(task_type)
  File "C:\Users\oralu\Desktop\pokebot\PokemonGo-Bot\pokemongo_bot\tree_config_builder.py", line 21, in _get_worker_by_name
    raise ConfigException('No worker named {} defined'.format(name))
pokemongo_bot.tree_config_builder.ConfigException: No worker named RandomPause defined
2016-08-22 04:03:01,782 [sentry.errors] [ERROR] Sentry responded with an error: 'ascii' codec can't decode byte 0x9c in position 1: ordinal not in range(128) (url: https://app.getsentry.com/api/90254/store/)
Traceback (most recent call last):
  File "C:\Users\oralu\Desktop\pokebot\PokemonGo-Bot\lib\site-packages\raven\transport\threaded.py", line 174, in send_sync
    super(ThreadedHTTPTransport, self).send(data, headers)
  File "C:\Users\oralu\Desktop\pokebot\PokemonGo-Bot\lib\site-packages\raven\transport\http.py", line 47, in send
    ca_certs=self.ca_certs,
  File "C:\Users\oralu\Desktop\pokebot\PokemonGo-Bot\lib\site-packages\raven\utils\http.py", line 66, in urlopen
    return opener.open(url, data, timeout)
  File "C:\Users\oralu\Desktop\pokebot\PokemonGo-Bot\lib\site-packages\future\backports\urllib\request.py", line 494, in open
    response = self._open(req, data)
  File "C:\Users\oralu\Desktop\pokebot\PokemonGo-Bot\lib\site-packages\future\backports\urllib\request.py", line 512, in _open
    '_open', req)
  File "C:\Users\oralu\Desktop\pokebot\PokemonGo-Bot\lib\site-packages\future\backports\urllib\request.py", line 466, in _call_chain
    result = func(*args)
  File "C:\Users\oralu\Desktop\pokebot\PokemonGo-Bot\lib\site-packages\raven\utils\http.py", line 46, in https_open
    return self.do_open(ValidHTTPSConnection, req)
  File "C:\Users\oralu\Desktop\pokebot\PokemonGo-Bot\lib\site-packages\future\backports\urllib\request.py", line 1284, in do_open
    h.request(req.get_method(), req.selector, req.data, headers)
  File "C:\Python27\Lib\httplib.py", line 1057, in request
    self._send_request(method, url, body, headers)
  File "C:\Python27\Lib\httplib.py", line 1097, in _send_request
    self.endheaders(body)
  File "C:\Python27\Lib\httplib.py", line 1053, in endheaders
    self._send_output(message_body)
  File "C:\Python27\Lib\httplib.py", line 895, in _send_output
    msg += message_body
UnicodeDecodeError: 'ascii' codec can't decode byte 0x9c in position 1: ordinal not in range(128)
2016-08-22 04:03:01,848 [sentry.errors.uncaught] [ERROR] [u'ConfigException: No worker named RandomPause defined', u'  File "pokecli.py", line 570, in <module>', u'  File "pokecli.py", line 91, in main', u'  File "C:\\Users\\oralu\\Desktop\\pokebot\\PokemonGo-Bot\\pokemongo_bot\\tree_config_builder.py", line 54, in build', u'  File "C:\\Users\\oralu\\Desktop\\pokebot\\PokemonGo-Bot\\pokemongo_bot\\tree_config_builder.py", line 21, in _get_worker_by_name']

 Something went wrong and the bot needed to be restarted. Please investigate the cause.

If I delete RandomPause task from my config then Complete Tutorial throws the same error, no worker found. And UpdateLiveInventory....

Please use issue template as intended so we can determine the actual cause


Junit xml report file format to be imported in CI tools

In order to publish & display test results on CI tools dashboard , need to have reports in Junit xml format to be importable.

How are we currently publishing/integrating test results over CI dashboards?

added in #153


How to associate xml files with desktop app?

When I want to edit graph with this app, I hope to click demo.xml file rather than lanuch app first and then open demo.xml file.
the following maybe a solution but not available now:
chrome.exe  --profile-directory=Default --app-id=pebppomjfocnoigkeepgbmcifnnlndla demo.xml

By any chance, is there any plan to switch to an extension specific to draw.io, such as .drawio?

Yes. As a workaround you can click on the filename and change it to *.drawio (or any other custom extension).

I was suggesting the possibility for draw.io to produce by default a .drawio file instead of a .xml file when saving a figure :)

The original issue for this thread still exists on OSX. Regardless of the extension, once an association is made in OSX, double clicking the file brings the draw.io desktop app to the foreground but doesn't load the file.

Almost 2 years now since this ticket was opened.
I see if you search by most commented, this issue is number 1: https://github.com/jgraph/drawio/issues?q=is%3Aissue+is%3Aopen+sort%3Acomments-desc
It would be great if you guys could prioritize a fix.

Duplicate of https://github.com/jgraph/drawio-desktop/issues/11


constant column

This change is

Codecov Report
Attention: Patch coverage is 58.46154% with 27 lines in your changes missing coverage. Please review.

Project coverage is 91.68%. Comparing base (cdf66f3) to head (de5ec45).
Report is 1 commits behind head on dev.

Files with missing lines
Patch %
Lines

...rover/src/constraint_framework/constant_columns.rs
0.00%
13 Missing and 1 partial :warning:

crates/prover/src/core/pcs/utils.rs
29.41%
10 Missing and 2 partials :warning:

...rates/prover/src/constraint_framework/component.rs
97.05%
0 Missing and 1 partial :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #848      +/-   ##
==========================================
- Coverage   91.86%   91.68%   -0.18%
==========================================
  Files          89       89
  Lines       12080    12149      +69
  Branches    12080    12149      +69
==========================================
+ Hits        11097    11139      +42
- Misses        876      899      +23
- Partials      107      111       +4

Flag
Coverage Δ

91.68% <58.46%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Document: BTV Plattform (VOD Admin (Deployment))

fredrik says he wrote something but i cant find it

the docs is lost we need to start over


Docs/getting started updates

from PR review in -Connected

@msimecek should we get this merged?

We should :)


JaydenDev.Catalyst3 version 3.2.2

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?

[x] Does your manifest conform to the 1.2 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

@microsoft-github-policy-service agree [company="JaydenDev"]

@microsoft-github-policy-service agree

@ItzLevvie the changes that you have suggested have been applied.


Create individual issues for default dashboards for Facebook Ads data

Migrated from GitLab: https://gitlab.com/meltano/meltano/-/issues/1534
Originally created by @dmor on 2020-01-07 17:59:20

When a user connects Facebook Ads as a data source, we should provide a few pre-made dashboards that address the most common questions a user has when reviewing their analytics in their Facebook Ads account:

Ad spend over time
Click through rates over time
Conversion rate rates over time

Each of these dashboards can start out as an aggregate of the entire account, but should be filterable by ad, keyword, and campaign.

View 11 previous comments from the original issue on GitLab


Invalid UI layout when updating access control on a resource

When inspecting a resource and clicking on "Change ownership" in the access control panel, the following layout is displayed:

The three selectors should be on the same line.

@thesobercoder when creating a resource you can just disable access control, which is the equivalent of the public ownership status.


outlier detection: expose consecutive 5xx API

Signed-off-by: Jose Nino<EMAIL_ADDRESS>

Does setting this to 0 disable outlier detection?

Does setting this to 0 disable outlier detection?

@goaway it does not.

closing for now as we might need to change the outlier detector mode used in Envoy Mobile.


training time about the xmem

Hello, I want to ask the training time of the XMem. especially XMem-s03.pth and XMem-s3.pth.
I just training the datasets on the DAVIS & Youtube datasets (setting:3). The config is:
batchsize 4, GPUs: 4 iterations: 200000, finetune: 20000. It is about 1.5 -2 days.
I have printed the training time of all parts:
Time taken for encode_key: 0.006
Time taken for encode_value: 0.029
Time taken for forward_others: 0.190
Time taken for loss_backward: 0.566
I want to ask why the loss_backward is so slow.
Thanks

I haven't assessed the running time for individual components so I am not sure.

Thanks, I wanna know the total training time of your config and project.

Cannot recall now but the logs are here: https://github.com/hkchengrex/XMem/issues/71


Update_index.md

Updates in index.md: Tested configuration, WSL, Note for Ubuntu users

Incorporated texts directly. except for the following

Note for Ubuntu users
Important: Avoid Using "apt get install docker".
If Docker installation was done using the command "apt get install docker", many issues could be encountered when
running the tutorials later on.

Could you add a comment here to  elaborate Why apt get install docker is such a bad idea and how docker should be installed correctly?
I'm assuming that this is the correct method, but when telling people things it is always better to say what to do directly rather than what not to do

Completed - warning added manually to docker-ubuntu.md


Fix link to bundle with zone-peer-dep

This change is

Codecov Report

Merging #162 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master    #162   +/-   ##
======================================
  Coverage    95.9%   95.9%
======================================
  Files          30      30
  Lines         855     855
  Branches      148     148
======================================
  Hits          820     820
  Misses         35      35

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecb66c7...b113ad5. Read the comment docs.

@googlebot I signed it!


use local paths and remove trailing spaces

reason: only including tau.h fails

There's a reason why the <tau/...> syntax exists. If you prefer using the "..." approach, you'll need to make a small change in the include paths in CMakeLists.txt. I'm happy to merge the spacing changes, but not going to  atm with the include path changes

There's a reason why the <tau/...> syntax exists.

So you want users of tau to either use CMake or -Ltau ?
The Ltau option is not explained in the README.

Primarily CMake. Tau is really meant to be used alongside a CMake-built project. Haven't explored the -LTau option like you mentioned since I primarily use CMake. But, I guess it's worth exploring as well.

Pardon, it was Itau to include headers:
-I <dir>                Add directory to the end of the list of include search paths


Next week's episodes are downloading

i ran horrible downloader and it downloaded episode 10 of fire force and 11 of dr.stone(which air next week
of course they didn't download in my torrent client but i'm not sure if it's going to work next week

This is very weird, please paste here your config.

i'm sorry but which file are you talking about?

When you run the CLI for the first time, it generates a config file inside of ~/.config/horrible-downloader/conf.ini (linux) or C:\Users\USER\.config\horrible-downloader\conf.ini (windows).
please paste the file here.

i'm so sorry for deserting this thread my internet didn't work for 2 days :(
i managed to fix it by manually changing the episode to start downloading from
don't know how the problem occured but it never happened again


How to read incoming data from SPI MOSI Lane? (not MISO)

I am working on a specific epd which requires to read data from the MOSI line after sending a command but switching the CS pin between each byte. It's unclear to me if this is even achievable with the SPI Bus implementation. If so some guidance would be appreciated.
Some relevant parts from the documentation:

Here it also states that a CS pulse is necessary between each read.

I thought something like this would be working:
    pub fn read_otp(&mut self, buffer: &mut [u8]) -> Result<(), E> {
        self.bus.lock(|bus| {
            let mut bus = bus.borrow_mut();

            self.cs.set_low().ok();
            // Command mode
            self.dc.set_low().ok();

            // Send read command
            bus.write(&[0xA2])?;

            self.dc.set_high().ok(); // Data mode

            // Read data
            for byte in buffer.iter_mut() {
                self.cs.set_high().ok();
                self.cs.set_low().ok();

                // Send dummy byte and read the result
                let mut read_buf = [0u8];
                bus.transfer(&mut read_buf, &[0x00])?;
                *byte = read_buf[0];
            }

            self.cs.set_high().ok();
            Ok(())
        })
    }

but then i found out that the transfer also wants to read on the MISO line.

This looks like a non-standard variation of SPI.
While it may (or may not) be supported by the SPI hardware of your microcontroller, it's not something supported by the abstraction layer provided by embedded-hal.


support for dbfs and scala 2.12, also version updated

added support for dbfs

Why hasn't this been merged?


created tests for user controller

Hey @nmarulo , i have created tests for the UserController. Please consider this PR (issue #33) under hacktoberfest


add extended timer information of rcl/rclcpp for jazzy release note.

Related PRs,

https://github.com/ros2/rclcpp/pull/2343
https://github.com/ros2/rcl/pull/1113

CC: @jmachowinski

@clalancette @ahcorde @marcoag can you take a look at this?


RTP MIDI

It would be very interesting to add RTP MIDI capability to this project for MIDI output over WiFi using the Raspberry Pi Pico W

@tizi24 My original intent for midi2usbhost was to "Make a Raspberry Pi Pico a USB Host to bridge modern USB MIDI to old school MIDI IN and MIDI OUT." The idea of this project is to make a simple plug and play device.
If you just want to make a USB MIDI device wireless, I already have a Pico W project, ble-midi2usbhost, that provides a relatively low latency wireless connection between a USB MIDI device and a MIDI Bluetooth client in the central role.
All this said, I am interested in an abstract sense in RTP MIDI. Please explain your final application in detail so I may understand why adding RTP MIDI capability to this project is very interesting to you. I probably won't add it to this project, but I might create a new one if you make a good case.


Wrong message type was mentioned in the text

(so simple I wish the commit message rules don't apply)

please replace the first line of the commit message with Documentation: refer to LeaseKeepAliveRequest for lease refresh so this passes CI and this should be good to merge. Thanks!

Ping @akauppi.

Sorry, on vacation now until August


Link up the whole doc build

Ideal situation:
At the top level, once dependencies are installed:
mvn  doc
od
make doc
This generates a directory containing sphinx from the manual documentation and the avro schemas in a form that can be copied the the website or uploaded to readthedocs.org.  A clean target reset everything.

The top-level POM should fetch avro-tools.jar.

Done using Maven (mvn package).


Use of mapfile introduces bash4 dependency making local runs difficult on macOS

!/bin/bash on macOS is still 3.2.x and doesn't include mapfile command.  This prevents bk local run on macOS with version 2.1 of this plugin.

hey @pda any thoughts on this issue? we've gotten really hung up on this issue. Even when you follow kkolk's awesome advice and use his fork with the changes there are issues with all sorts of local deps once you change the shell. Do you see a future where mapfile is eliminated or where some solution for installing a newer version of bash will work? Thanks for your help!

Maybe we can use https://github.com/dosentmatter/bash-mapfile-shim

There are some great suggestions on https://github.com/koalaman/shellcheck/wiki/SC2207 on how to avoid mapfile, my preference would be to just ditch mapfile usage. It's replaceable in my experience.

Hah, I just realised it was me that switched this to mapfile based on shellcheck advice:
https://github.com/buildkite-plugins/ecr-buildkite-plugin/commit/da2472ff784ab6ed427f9827d79bb10ac11c0060
But yep, I'll open a PR switching this, and the other instance, back to bash 3.x compatible code.


Get jdk tag for openj9 from openjdk-tag.gmk file

Signed-off-by: andrew-m-leonard<EMAIL_ADDRESS>

This PR resolves https://github.com/AdoptOpenJDK/openjdk-build/issues/1087
The current get tag logic in build.sh finds the latest tag in the whole "repo", not in the context of the branch. For openj9 since we build a branch and not straight from the tag, we now store the tagged level in the closed/openjdk-tag.gmk file.

Test build: https://ci.adoptopenjdk.net/view/work in progress/job/andrew-test-jdk8u-windows-x64-openj9/2/console


LASTORDNO does not Build

All work done on PUB400.COM.  PC was not used except for PuTTY.
Cloned project to IFS: /home/LENNONS/bob-recursive-example
export lib1=LENNONSB
cd /home/LENNONS/bob-recursive-example
makei build
Objects:             4 failed 112 succeed 116 total
 > Failed objects:    CHS.MODULE CHS.PGM DEU.MODULE DEU.PGM
Build Completed!

The 4 that failed were the last 4, which are address by a yet to installed fix relating to CCSID issues (https://github.com/IBM/ibmi-bob/issues/224)
However. the LASTORDNO data area is not created, nor can I find and reference to it in joblog.json or output.log.
I though I'd build just it, so I made a minor change to comment in LASTORDNO.DTAATA (using VS Code) and saved it.
export lib1=LENNONSB
cd /home/LENNONS/bob-recursive-example
makei b -d  QDTASRC
> /QOpenSys/pkgs/bin/make -k BUILDVARSMKPATH="/tmp/tmpvmowl5_k" -k BOB="/QOpenSys/pkgs/lib/bob" -f "/QOpenSys/pkgs/lib/bob/src/mk/Makefile" dir_QDTASRC

Objects:             0 failed 0 succeed 0 total
Build Completed!

So I apparently still can't create the LASTORDNO data area.

Works now with bob 2.4.25.


Add endpoint model and endpoints property to node

The library is missing the endpoints property in the node model. This adds support.
This came from a discussion with @marcelveldt about an issue I am having with my thermostat where some of the values live on a different endpoint from the primary value. The plan is to enhance get_zwave_value (https://github.com/home-assistant/core/blob/dev/homeassistant/components/zwave_js/entity.py#L117) to optionally search additional endpoints if the value can't be found on the primary value's endpoint.

We should represent the data as modeled by Z-Wave JS. So if it duplicates the node id we should also do that.


Some elements are hidden below while area.

I'm using backdrop and some elements are hiding below the white line. I have changed some css for z-index.
.tour-backdrop {
 z-index: 1000;
}

.tour-step-backdrop {
 z-index: 1001;
}

.tour-step-background {
 z-index: 1000;
}
.popover[class*="tour-"] {
 z-index: 1000;
}

It's working for buttons but still there are some hidden elements.
Please provide me a solution.

I have the same problem!


feat: beta

feat: frises with preset period

feat: frises with preset period small changes

feat: info modal wip

feat: frise infobulle ready

feat: preset date for stats tab too

fix: infobutton size

fix: code smell

feat: filter button wip, button comp with icon

feat: filter button ready, separate clearly frise concern

clean: Button2.js

feat: déclencheurs filter ready, with infobulle

clean: small changes

:tada: This PR is included in version 1.37.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


damage reduced distributions for muncie are odd

EAD and AAEQ damage reduced distributions sit strangely below zero. Theoretically, this makes sense, but intuitively, seems odd. Investigate. Mean AAEQ damage reduced is negative - that is wrong.
EAD

AAEQ

I believe that this is related to #789

This issue was resolved with #789


[stable/airflow]  variable invalid

Describe the bug
A clear and concise description of what the bug is.
Version of Helm and Kubernetes:
Which chart:
airflow-7.1.0
What happened:
variable invalid
What you expected to happen:
variable have value
How to reproduce it (as minimally and precisely as possible):
values.yaml
scheduler:
  variables: |
    { "environment": "dev" }

Anything else we need to know:

@superbeer You probably need to configure a fernet key, please use airflow.fernetKey or airflow.extraEnv.

@gsemet, this is why I am not sure about including a default fernet key value, while it may reduce security as users don't change it, at least their deployment will work correctly.

I think it is a good idea not to force people to do boring stuff when they just want to try airflow. A default unsecured key is ok for me


remove --parser flag from prettier fixer

Prettier will infer the parser based on the file name https://github.com/prettier/prettier/issues/3190#issuecomment-342532165, so no need for the parser flag.
And since prettier now supports Markdown & GraphQL this list will just grow & needs to be maintained manually which is not good thing.

This will take some consideration. Some other users added the --parser flag because it wasn't working otherwise. The --parser flag won't be added for unknown filetypes, so it shouldn't be a huge issue.

Maybe that was an issue was an old version or something, I'll leave this to you to decide.

I removed the --parser argument. If it's somehow needed for something, someone can create a pull request and explain why.


Fix errors when a language was not registered

Hello @bebraw,
I'm using your library with remark-react. I found an issue when I try to convert a markdown with a block of code that uses a non-registered language:
Uncaught Error: Unknown language: `css` is not registered
    at coreHighlight (http://localhost:3000/static/js/bundle.js:31629:11)
    at High.highlight (http://localhost:3000/static/js/bundle.js:31566:20)
    at Lowlight (http://localhost:3000/static/js/bundle.js:50982:11)
    at http://localhost:3000/static/js/bundle.js:41554:16

I believe that this is a pretty common use case because I don't know all the languages the user will use. Also, if the user doesn't specify the language, the block is rendered without trying to guess it. Now, the component always returns a Lowlight component so, highlight.js can try to guess the language.
What do you think?

That seems smart.
I'm not using the package actively anymore anywhere. Would you like to take over it? I don't mind handling the transition and setting up the rights.
If that's too much, I can also merge and cut a release. 👍

Thanks for your fast response @bebraw!

I'm not using the package actively anymore anywhere.

Did you find an alternative to it or just finished the project that required this lib?

Would you like to take over it? I don't mind handling the transition and setting up the rights.

The library is pretty simple so I believe that I don't need any other change :). For me, it's enough if you can merge and publish a new version.
In the future, if I need to add more changes and improvements to it, I don't mind to take over it and continue your work.
Thanks!

Did you find an alternative to it or just finished the project that required this lib?

I ended up using entirely different solution (Catalog) that eliminated the whole problem for me (no remark in the project anymore).

The library is pretty simple so I believe that I don't need any other change :). For me, it's enough if you can merge and publish a new version.
In the future, if I need to add more changes and improvements to it, I don't mind to take over it and continue your work.

Ok, cool thanks.

Thank you for your comments and the release :)


Provision of a new API for daikin cloud Onecta

Hello,
Just to inform you that Daikin has finally released its API for Onecta. I just had access to their developer panel
See attached documentation : https://developer.cloud.daikineurope.com/spec/b0dffcaa-7b51-428a-bdff-a7c8a64195c0/70b10aca-1b4c-470b-907d-56879784ea9c
Sincerely
Thibaut

@Apollon77 do you have the intention to update this library to be able to use the new API? Or would this be deprecated?

Yes, seems I need to update, so need to find time next weeks or such :-) You could also try to do it and provide a PR

@Apollon77 I was already looking into a lightweight version based on what you have here. I was in doubt about the PR because I don't know how you looked at the following:

I would remove the proxy because I don't think it can be used anymore. To retrieve the authentication token you can't use a localhost url for the redirect so I think (no expert in this) it can't be MITM'ed.
I would ask the users for an access/refresh token to start with, so they will need to create an App (client id/secret) and retrieve the tokens themselves. The library can then use the refresh token to keep getting new tokens.
Deprecate Node 16 and bellow
As far as I can see the API is kept the same so all set and get data related stuff can be kept the same

Hi,

yes the proxy is most likely "dead", same for the "scripted http auto login flow". so all this should be removed
Then we need a way to authenticate "one time" and return the tokens. Here in fact the complexity comes in. We need to start a local webserver for this process because we need a target for the "OAuth end redirect or users need to copy stuff from URLs or network tabs around which is semi good. This all could also be triggered again with executing a script which outputs the details like in the beginning times. And yes each user creates his own Client-ID and secret for that. I think it is all relatively straight forward and parts of the proxy code (that basically do the same) can be reused for start and end.
Rest should work - as you said - as before. I just heared that some data might be no longer included, but did not validated so far.
AND a big difference is that there are rate limits now ... so you only have a limited number of calls per day, so it might be thought here and maybe about reducing updates in night hours or such.

Then we need a way to authenticate "one time" and return the tokens. Here in fact the complexity comes in. We need to start a local webserver for this process because we need a target for the "OAuth end redirect

Here the problem is, I think, that the redirect url to start the OIDC flow can not be a localhost url. So starting a webserver wouldn't be enough. Or am I missing something?
I guess if we tell to first edit /etc/hosts as well and let them direct a specific domain to the local webserver it could maybe work.

@Apollon77 this is the "main" change I had in mind: https://github.com/Apollon77/daikin-controller-cloud/pull/138

Localhost should work because in fact it is your browser that does the redirect. So ideally it is a local IP or local hostname rather then "localhost/<IP_ADDRESS>" but in theory also <IP_ADDRESS> would work if it is the same machine where the browser runs on. Will look into.
Re your PR: I would keep the Openid logic like https://github.com/Apollon77/daikin-controller-cloud/pull/138/files#diff-e727e4bdf3657fd1d798edcd6b099d6e092f8573cba266154583a746bba0f346L55-L76 for a new onetime-auth-script... in fact you just use the users clientid/secret and urls from them

Localhost should work because in fact it is your browser that does the redirect. So ideally it is a local IP or local hostname rather then "localhost/<IP_ADDRESS>" but in theory also <IP_ADDRESS> would work if it is the same machine where the browser runs on. Will look into.

I might be misinterpreting the way you see it but even if the browser makes the redirect, the authorisation flow will fail because the redirect_uri must be whitelisted via the ONECTA Api platform. And it does not except localhost values.

Never mind, had another look at the proxy and I see you also intercept the daikinunified:// uri there, so I guess it's possible to intercept any domain.

@Apollon77 : Any idea, how the new rate limit will affect existing scripts?
What exactly are the script operations that count to that new 200 requests/day limit? Is a call of setState regarding a datapoint of a Daikin Cloud instance already "consuming" one request for example?

@JeroenVdb ohj they really try to validate the domainname you enter? What about an ip?

@fichtenmoped82 reading in any way. But in general should be all actions too. And the rest is hard to answer without knowing the current scripts but in fact to have a bit reserve.
In fact 24h/200 is one action every 7.2min. So with some
Actions reserves one read every 15 mins should allow that. If you define a night timeframe where you read less often you can optimize other timeframes.

@JeroenVdb ohj they really try to validate the domainname you enter? What about an ip?

Tried both ip and localhost variants. All are blocked. They also explicitly mention in the docs that they block it.
I think it’s possible via a small web server + change the hosts file on your computer. But then again it’s probably easier (or both hard) to ask the users to navigate to the authorization page and do some curl commands.

Tried both ip and localhost variants. All are blocked. They also explicitly mention in the docs that they block it.

Did you just try <IP_ADDRESS> or also the local network IP of your machine?

The other alternative I thought about is to add a special webservice hoested e.g. by me which is publicly available and allows to fix these local issues ... i need to check

There is a working way for Home Assistant with a custom integration which uses the new API
https://github.com/jwillemsen/daikin_onecta
Maybe this is helpful to check how they implemented also the OAUTH redirect.

Thx, thats known, in fact it is just "time" and not the "how" :-)

How can i install the latest version to test it?

You can try npm tag @next or the latest 2.0.0-alpha.X ... This is still work in progress but we are relatively far. But Documentation is not done yet. Will all come next days.

The example script shows the new API, so use this

v2.0.0 released


Every time I turn on the server, it crashes

Spark link
https://spark.lucko.me/O8UX4cIQ9c
Stack trace
https://paste.gg/p/anonymous/0628884134384925a326b01d8e3bfc28

Actions to reproduce (if known)
No response
Purpur version
[17:23:55 INFO]: CMI: <IP_ADDRESS> BungeeCord MySQL-> <IP_ADDRESS>
[17:23:55 INFO]: CMILib: <IP_ADDRESS>
[17:23:55 INFO]: Server: Purpur 1.20.1-R0.1-SNAPSHOT
[17:23:55 INFO]: CMI economy: POVOLENO Vault: 1.7.3-b131(CMIEInjector) CMI Chat: ZAKAZÁNO
[17:23:55 INFO]: Modules -> 44 enabled 15 disabled: spawnerProximity, mirror, tablist, armorEffects, moneyCheque, skin, noTarget, elytraBoost, paintingEditor, playerChatTag, flightCharge, disabledEnchants, chatBubble, spawnerCharge, namePlates
Agreements

[X] I am running the latest version of Purpur available from https://purpurmc.org/downloads.
[X] I have searched for and ensured there isn't already an open issue regarding this.
[ ] I ticked all the boxes without actually reading them
[X] My version of Minecraft is supported by Purpur.

Other
Hello, I have been using Purpur for a very long time and I am very satisfied. However, I am experiencing one problem when turning on the server.
Every time I turn on the server, the server shuts itself down, it writes th
e message "DO NOT REPORT THIS TO PURPUR - THIS IS NOT A BUG OR A CRASH" etc.. see attached link.
However, as soon as it shuts down, it comes back up again and then everything is fine. It's always just the first power up. It's been doing this since 1.19.4, I've already updated probably every plugin and switched to 1.20, but I still have the same problem.
Thank you
2023-09-06-5.log

DO NOT REPORT THIS TO PURPUR - THIS IS NOT A BUG OR A CRASH
It could be a problem with your server plugin
Or have you tried testing with upstream paper/pufferfish?
See if you get the same result

What they said ^

I tried the new version of Purpur#2054 and the latest Paper#174.
Unfortunately the crash still persists with Purpur and with Paper the server started immediately on the first boot

Could you also test it with the latest version of Pufferfish?

I put the latest build of Pufferfish and so far no problem. Looks like the problem has been solved by this, thank you. I'll probably stick with this one

That was not my intention. I asked you to test on Paper and Pufferfish to verify that it is actually a Purpur issue.
Are you able to replicate this with a clean test Purpur server that has no plugins installed? It's difficult to find a way to replicate your issue since there's so many variables that could be at play here. I need steps on how to reproduce the problem as well.

That is the problem, I tried a clean server where I put ALL the plugins I have on this server where I am solving the problem. Unfortunately, the error didn't occur there. That's why it's also hard to determine what's actually causing the problem. I don't know why that is, but I know pufferfish doesn't have a problem with it. The server has been running for over 3 years and I have had this problem since 1.19.4, I was just hoping that 1.20.1, would solve this problem.