Restic Not Able to Grab S3 Config

Output of restic version
0.9.4
How did you run restic exactly?
I am running restic through a backup system called bivac, but essentially it just runs the restic container with given args.
cmd: restic snapshots --no-cache -r s3:s3.amazonaws.com/xxx/monitoring/data-prometheus-consul-server-0
I expect this command to work, however I am getting the error:
Fatal: create repository at s3:s3.amazonaws.com/xxx/monitoring/data-prometheus-consul-server-0 failed: client.BucketExists: Head https://xxx.s3.dualstack.us-east-1.amazonaws.com/: 301 response missing Location header

I've traced down the issue to it trying to find the region specific bucket however that shouldn't be the case. When I run this locally (not in kubernetes) this works fine, however around 7 hours ago (when most of your docker images were updated) this stopped working in my cluster.
What backend/server/service did you use to store the repository?
S3
Expected behavior
To be able to see the repository in S3
Actual behavior
Not able to get to the repository
Steps to reproduce the behavior
Do you have any idea what may have caused this?
I have a feeling this correlates to the mass update of the docker images in docker hub. We never experienced this issue before.
Do you have an idea how to solve the issue?
For now I'll rollback the version and hope this fixes the issue, but it seems like the region selected is the default in AWS which would lead me to believe it has something to do with an aws region setting.

Hey, thanks for the report! Unfortunately this is an odd error condition and the message is very misleading: The cause is that the credentials you're using for accessing S3 do not have the GetBucketLocation permission. It has come up in the forum and here: https://github.com/restic/restic/issues/2129#issuecomment-462450686
Can you please verify that that the credentials have the required permission and try again? Thanks!

@fd0 currently experiencing the same issue but with a user having S3 full permissions so it seems to be something else

@fd0 forget about my previous comment
Will not work: region specific endpoints directly
Will work: non specific endpoint with correct bucket name (my fault)

@sascha-andres Is there something we should change in restic or the documentation? Or can this issue be closed?

Closing this in favor of #2250.

Errhh, I mean #2264.

Hello, just trying those scripts to backup some files to AWS S3 and got this error:
[[Internet]] Repository string could not be parsed.
But the same string were used to create the respository and it worked, but when I tried to run the scheduled task in the windows task scheduler I'm geeting this error. Do you have any ideas on how to make it working??
By the way, the string that I'm using is: "s3:s3.amazonaws.com/xxx.xxx.xxx/BackupTest
Thank you so much!!!

FWIW - and apologies if this was pointed out elsewhere - I learned that virtual-host-style URIs are also needed for AWS s3 "access points" (private endpoints), which only support that style:

You can only address access points using virtual-host-style URLs.

These access points are really nice because a VM inside AWS private network (VPC) can send data to/from them without transiting a NAT gateway, i.e. much lower transfer charges.


Options after arguments are ignored

Consider the following example, which is one of the README examples that has been slightly modified:
package main

import (
	"fmt"
	"os"

	"github.com/urfave/cli"
)

func main() {
	app := cli.NewApp()

	app.Flags = []cli.Flag{
		cli.StringFlag{
			Name:  "lang",
			Value: "english",
			Usage: "language for the greeting",
		},
	}

	app.Action = func(c *cli.Context) error {
		fmt.Println(c.String("lang"))
		return nil
	}

	app.Run(os.Args)
}

And the following invocations:
$ ./cli-test --lang spanish
spanish

$ ./cli-test foo --lang spanish
english

In the second invocation, the lang option is ignored.
This may have been by design, but it makes the library unable to handle wget-like invocations of e.g. wget http://foo.bar/index.html -o file.html where the options act like operators on the argument(s).

Hi @noffle!
Unfortunately this is a limitation of the standard library flag library which cli uses for flag parsing under the hood. I'd love to be able to address this, but it will require either substantial flag preprocessing or just replacing flag parsing with our own implementation (more likely).
Since this is also captured by https://github.com/urfave/cli/issues/427, I'm going to close this and direct you there for further conversation and updates, but thank you for bringing this up!

Thanks @jszwedko for directing me to #427!


Created Chat copilot but don' know how to get to it

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Go to 'https://github.com/microsoft/chat-copilot/blob/main/scripts/deploy/README.md#azure-portal'
Click on 'Deploy to Azure'
Wait for the deployment to be done
See the resource group items

Expected behavior
The URL of the static web site https://yellow-rock-07923991e.3.azurestaticapps.net should show the UI.
instead it shows "waiting for your content"
Screenshots
If applicable, add screenshots to help explain your problem.

Platform

OS: Windows,
IDE: None
Language: None

Did I miss something? Something else I need to do?

Can you confirm that you've deployed the static potion of the app:
https://github.com/microsoft/chat-copilot/tree/main/scripts/deploy#deploy-frontend-webapp

The explanation does not include it.
This is so confusing.

Agree.  We are working to improve the documentation.   Were you able to access the static content after following these steps?

Yes Thank you


您好，请问此库可以自行添加自己想用的数据集以供使用吗

Issue description
谢谢

Hi there 👋,
Thank you so much for your attention to TSDB and PyPOTS! You can follow me on GitHub to receive the latest news of TSDB and PyPOTS. If you find TSDB helpful to your work, please star⭐ this repository. Your star is your recognition, which can help more people notice PyPOTS and grow PyPOTS community. It matters and is definitely a kind of contribution to the community.
I have received your message and will respond ASAP. Thank you for your patience! 😃
Best,
Wenjie


TF-TRT failed to convert the key of the savedModel model signature_def inputs

Click to expand!
Issue Type
Bug
Source
binary
Tensorflow Version
tf2.4.1
Custom Code
Yes
OS Platform and Distribution
Ubutun18.04
Mobile device
No response
Python version
3.6
Bazel version
No response
GCC/Compiler version
No response
CUDA/cuDNN version
No response
GPU model and memory
No response
Current Behaviour?
A bug happened

When using tf-trt for model conversion in savedModel format, the model produced by trt changes the input key value of signature_def. The original key value contains uppercase and lowercase names. After trt-tf is output, it becomes all lowercase, and the model cannot be run.

use command： saved_model_cli show

before：

MetaGraphDef with tag-set: 'serve' contains the following SignatureDefs:
signature_def['__saved_model_init_op']:
  The given SavedModel SignatureDef contains the following input(s):
  The given SavedModel SignatureDef contains the following output(s):
    outputs['__saved_model_init_op'] tensor_info:
        dtype: DT_INVALID
        shape: unknown_rank
        name: NoOp
  Method name is:
signature_def['serving_default']:
  The given SavedModel SignatureDef contains the following input(s):
    inputs['answerWilsonScore'] tensor_info:
        dtype: DT_FLOAT
        shape: (-1, 1)
        name: serving_default_answerWilsonScore:0

after tf-trt：

MetaGraphDef with tag-set: 'serve' contains the following SignatureDefs:
signature_def['__saved_model_init_op']:
  The given SavedModel SignatureDef contains the following input(s):
  The given SavedModel SignatureDef contains the following output(s):
    outputs['__saved_model_init_op'] tensor_info:
        dtype: DT_INVALID
        shape: unknown_rank
        name: NoOp
  Method name is:
signature_def['serving_default']:
  The given SavedModel SignatureDef contains the following input(s):
    inputs['answerwilsonscore'] tensor_info:
        dtype: DT_FLOAT
        shape: (-1, 1)
        name: serving_default_answerwilsonscore:0

Standalone code to reproduce the issue
https://docs.nvidia.com/deeplearning/frameworks/tf-trt-user-guide/index.html#worflow-with-savedmodel

from tensorflow.python.compiler.tensorrt import trt_convert as trt
converter = trt.TrtGraphConverterV2(input_saved_model_dir=input_saved_model_dir)
converter.convert()
converter.save(output_saved_model_dir)

Relevant log output
No response

Hi @lixiaolx,
Tensorflow version 2.4 not actively supported. Hence, kindly update to the latest stable version 2.9 and let us know if you are facing the same issue. Thank you!

Hi @lixiaolx, Tensorflow version 2.4 not actively supported. Hence, kindly update to the latest stable version 2.9 and let us know if you are facing the same issue. Thank you!

I tried tf2.9.1 and found that there is still the same problem, the input [key] in the model converted by tf-trt is all lowercase. please help me solve it, Thank you！

Hi @tilakrayal , We found that the _arg_keywords returned here ( https://github.com/tensorflow/tensorflow/blob/v2.9.1/tensorflow/python/framework/convert_to_constants.py#L1076 ) when TF-TRT convert is different from the original model The same is not case sensitive, is there any way to solve this? Hope that helps to resolve the issue

Hi,
Thank you for opening this issue. Since this issue has been open for a long time, the code/debug information for this issue may not be relevant with the current state of the code base.
The Tensorflow team is constantly improving the framework by fixing bugs and adding new features. We suggest you try the latest TensorFlow version with the latest compatible hardware configuration which could potentially resolve the issue. If you are still facing the issue, please create a new GitHub issue with your latest findings, with all the debugging information which could help us investigate.
Please follow the release notes to stay up to date with the latest developments which are happening in the Tensorflow space.


fixes-client-side-exception

Description
Fixes #292 .
This pull request addresses the client-side exception occurring in the feed page by transitioning it from client-side rendering to server-side rendering (SSR). The exception is triggered when attempting to fetch data within the feed page, as reaching the GitHub rate limit restricts further requests.
To mitigate this issue, we've implemented SSR for the feed page. Data is fetched from the github.server-action file using octokit.js. This approach allows us to authenticate requests using a personal token and overcome the rate limit imposed by the GitHub REST API, which restricts to 5000 requests per hour when using GitHub personal token.
In the SSR implementation, data is initially fetched with a per_.page limit of 1000. Subsequently, it's revalidated every 10 minutes by Next.js, ensuring the feed page remains up-to-date while adhering to GitHub's rate limit policy.
Type of change
Enhancement: Transitioning from client-side to server-side rendering for the feed page.
Fetching data using octokit.js in Feed page.

@dgparmar14 repeating again kindly link the related issue using closing keywords https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword

@rithviknishad Rithvik can you please review it?

@rithviknishad Can you please merge and close the issue


Losslessly compress PNG files.

Before: 244 KB (250.693 bytes)
After:  177 KB (181.893 bytes)

What's the compiled release APK size difference?

That I don't know. This is the second patch of this nature BTW  https://github.com/forkhubs/android/commit/6fe37338ceea34900fad852b7f3aad1f65e35527

@hzsweers While building the apk aapt will compress the png's too

Not sure if it will achieve the same compression though, being that I used
zopfli too.
On Apr 20, 2015 12:25 PM, "Lars Grefer"<EMAIL_ADDRESS>wrote:

@hzsweers https://github.com/hzsweers While building the apk aapt will
compress the png's too
—
Reply to this email directly or view it on GitHub
https://github.com/forkhubs/android/pull/750#issuecomment-94405066.

Let alone I run hundreds of passes with pngout etc. So this should be
better.
On Apr 20, 2015 12:28 PM<EMAIL_ADDRESS>wrote:

Not sure if it will achieve the same compression though, being that I used
zopfli too.
On Apr 20, 2015 12:25 PM, "Lars Grefer"<EMAIL_ADDRESS>wrote:

@hzsweers https://github.com/hzsweers While building the apk aapt will
compress the png's too
—
Reply to this email directly or view it on GitHub
https://github.com/forkhubs/android/pull/750#issuecomment-94405066.

It's done. Worst case there's no change in the final APK and the images are a optimized in the repo.


Nameserver inside the container

I propose to setup a local full resolving nameserver inside the container in order not to rely only on the server of the host.
Background:
I tried using a whitelist for my postfix configurations (https://www.dnswl.org/), but unfortunately my namerservers are already blocked for quering the whitelist (too many lookups i suppose).
Pretty much the same problem as in here

Well, that would defeat the purpose of a mail server. I suggest you create your own compose file and add the dns as a service.

I do agree with @manthis. Note that this can be added in the Wiki to help other users to do it.

@manthis why should this defeat the purpose of a mailserver? Could you clarify your comment a bit?

@diiigle Maybe "defeat" is not appropriate. I mean a DNS server is clearly not in the scope of an email server. So it has no reason to be integrated into the mail server container whose only purpose is to receive/send emails. It's better if it is integrated as a service in a docker compose file.

@manthis okay, that sounds reasonable to me. I'll do my best and try the docker compose approach.
I'll keep you updated.

Awesome. Thanks @diiigle

Closed due to inactivity. Reopen if needed.


[BugFix] Fix broker kerberos ticket timeout bug when there are broker load continuously

What type of PR is this：

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：

Fixes #16127
Problem Summary(Required) ：

The current broker has two types of kerberos token, one is the global, one unique to each HDFS client, access to HDFS will use each client unique token, and access to other components (such as kms) use the global. HDFS client unique token is not automatically refreshed, but HDFS client in the broker has an expiration time, if more than 5min is not used, the HDFS client will be destroyed. If there is a request the next time, a new client will be created, the kerberos login will be executed again, this is actually an indirect refresh token. But if there are access continuously, HDFS client will never be rebuilt, then the token will not be refreshed, it will time out after 1 day.
To fix this bug, destroy the client before token is expired.
Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto backported to target branch

[x] 2.5
[x] 2.4
[x] 2.3
[x] 2.2

run starrocks_admit_test

LGTM

run starrocks_admit_test

@Mergifyio backport branch-2.5

@Mergifyio backport branch-2.4

@Mergifyio backport branch-2.3

@Mergifyio backport branch-2.2


Support RC6

After update of Angular to RC6 I get following error:
myModule:24 Error: SyntaxError: Unexpected token <
-> After registration ImageCropperComponent in @NgModule.
Fyi I got this error in internal modules -> when used import rxjs:
import  "rxjs";
New import command fixed this:
import  "rxjs/Rx";
Is this module migrated-supported for NG2 RC6 yet?
THANKS.

checked with NG2-RC6 - working with filllowing in system.js config file:
"ng2-img-cropper" :           {
main: 'index.js',
defaultExtension: 'js'
}


Highlight (with html mark element) only the text at the start when FILTER_STARTSWITH is used.

With javascript I create an Awesomplete object with filter starts-with:
{filter: Awesomplete.FILTER_STARTSWITH, maxItems: 10, minChars: 1}
Suppose I have an item 'Sports & Automotive' and the end-user searches for 's', both the first 's' and second 's' will be highlighted, suggesting to the end-user that the search-result is based on all items that contain text with an 's'.
ACTUAL:
The produced DOM is:

Sports & Automotive

DESIRED:
Is there a way to get only this DOM when FILTER_STARTSWITH is used?

Sports & Automotive

WORKAROUND:
There is a workaround, but it is based on hiding the standard behavior with CSS instead of correcting the DOM.

Surround the input-tags that use the start-with filter with
Add this style in the HTML header:

Given that the highlighted matches do not correctly reflect the filter, I'd consider this a bug.

I solved it by providing a custom item function, like below.
var createChild = function(html) {
return $.create("li", {
innerHTML: html,
"aria-selected": "false"
});
};
var itemStartsWith = function (text, input) {
var html = input.trim() === '' ? text : text.replace(
RegExp("^" + $.regExpEscape(input.trim()), "i"),
"$&");
return createChild(html);
};
In general you could say that the regular expression used in the filter, should also be used in the item function.
The item function could be composed of two parts:  the mark-text code and the create-child function.


Image Padding

-Added margin to Title logo on all scenes
-Repositioned Menu button on play scene to match other scenes

Created a test branch to check functionality.

Everything tested perfectly locally. Attempting merge.


Request new module: cp-filenet

Related user story
#817
https://zenhub.ibm.com/workspaces/industry-cloud-squad-5e58388dbb582d1c596ab4ea/issues/gsi-labs/industry-cloud-planning/817
Type of module
gitops
If requesting a terraform module, what is the target cloud platform?
ibm
What is the purpose of the module?
This will install FileNet components using CP4BA operator
(https://github.com/cloud-native-toolkit/terraform-gitops-cp4ba-operator)
What is the category of the module?
cluster, iam, network, database, integration, dev-tool, sre, infrastructure, util

/displayName FileNet


add myself as maintainer and some small updates

Could somebody merge this please?  Thank you.

Thank you!


[BUG 1.12.2] NullPointerException dumpOutputToInventory(TileMultiblockMachine.java:196)

AdvRocketry: 2.0.0.-257 (no unstable builds available)
LibVulpes: 0.4.2.-88
MC: 1.12.2

[x] This occur without other mods installed

Crash report (debug.log)
Description
ANY recipe of Chemical Reactor that has itemStack in output crashing game.

Build Chemical Reactor
Put Bone + Nitrogen in input hatches (default recipe)
Wait before recipe complete
Crash

Can confirm, I'm having the same issue using AdvancedRocketry-1.12.2-2.0.0-13

Can also confirm, AdvancedRocketry-1.12.2-2.0.0-13

Can also confirm, it happens also with other recipes of the Chemical Reactor.
AdvancedRocketry-1.12.2-2.0.0-13
LibVulpes-1.12.2-0.4.2-25-universal


Retry image loading on OOM

Do another image loading trying after OutOfMemory exception.

Please make memory cache clearing after OOM or an app will be dead anyway.


Set Error.cause in assertIsErrorInstance() by hand if it is not implemented by the host environment

This is the backport of fc83496a090d6f10d78361e6736d5d40a9c2faae.

dup with #1841


Does not work with TypeScript

I'm running into an issue where the decorators are not compatible with the way that property decorators work in TypeScript.
If you check out the decorators documentation, there's a relevant bit here:

A Property Descriptor is not provided as an argument to a property decorator due to how property decorators are initialized in TypeScript.

Originally, I modified the validation decorator to ignore desc if it did not exist, but this forces the property to become immutable because there's no way to set desc.writable. Not sure if there's a good solution here, but I figured it was worth keeping track of since the @ember-decorators libraries are a very useful when working with TypeScript.

Hey! So this is definitely a known issue, based on the limitations in Typescript. It's actually part of the reason why this is not part of the "core" decorators (the other part being that there's going to be a lot of overlap with @argument and actual @args, and glimmer components, etc, so while it's super helpful for modern components unsure how it fits into the overall Ember story yet 😅)
We should keep this issue open to track it, and update as soon as TS updates their transforms to add support. Thanks for opening it!

Any updates on TS support? Thanks!

Yes actually, based on the recent class constructor update RFC this library will no longer be needed at all for runtime. Once that RFC is implemented (my main focus right now) the behavior that @argument provides will be the default behavior in native classes, without decorators 😄
This library will be updated to be 100% validation decorators only, which will be removed entirely in production builds. The validations provided here are really a weak subset of the validations provided by Typescript, so this library will not attempt to support TS directly. The decorators may still work, but long term what we really want is to get type checking working directly in Glimmer templates. If we can get that, then you'll be able to use standard TS types to know whether an argument exists, whether it is required, what it's types are, etc.
Going to close this issue for now, thanks for reminding me!

Awesome!

hi @pzuraq,
sorry, i didn't understand :(
we can use @ember-decoratores/argument now with typescript or not ?
the only feature that i need is to check if an argument has been passed or not(i don't need the type checking), for example:
export default class MyLink extends Component {
  @argument
  @required
  href: string;
}

the my-link.hbs:
{{ yield }}

the template.hbs:
// throw an error(forget to pass the `href` argument)
<MyLink>About</MyLink>

thanks

Hey @flashios09, you cannot use @argument with typescript, and it will never be supported. Instead, we want to integrate Typescript's type checker so that it can read templates, and do type checking through them.
So for instance, if you have the component:
export default class MyLink extends Component {
  href: string;
}

and you attempt to use it like so:
{{yield}}

Typescript should throw an error because the argument is not used at all, so it is undefined. For optional arguments, you would have to specify undefined as a union type:
export default class MyLink extends Component {
  href: string | undefined;
}

hi @pzuraq ,
thanks for your reply

the only feature that i need is to check if an argument has been passed or not(i don't need the type checking)
for me the decorators make the code more readable and that's why i love them, for example when i use the @className, @action decorator, i don't even have to add a doc:

// import ... from ...
export default class MyLinkComponent extends Component {
  // this is a class name
  @className
  loading;

  // this is another class name
  @className
  loading;

  // this is a computed property
  @computed
  get isActive { ... }

 // this is an action
 @action
 clicked { ... }
 // ...

}

the only missing part is the @argument decorator, when i said:
// throw an error(forget to pass the `href` argument)
<MyLink>About</MyLink>

i mean when i forget to pass the href argument from the component invocation(the route template file or a parent component) not in the component template file, i will have an error in the console !
having an argument decorator, it makes the code more readable(for me):
export default class MyLinkComponent extends Component {
  // this is a component property, it can be anything
  href = null;

  // this is an argument and it's required
  // so if i forget to pass it from the component invocation
  // i will have an error in the console
  @argument
  @required
  href;
}


[zkSend] Open source contract

Open sourcing the smart contract used on zkSend.
The tests are commented out because they can only run on this PR:
https://github.com/MystenLabs/sui/pull/15420
When this PR is merged, we'll be able to allow all tests to run.

@dariorussi
Code was here: https://github.com/MystenLabs/zksend/pull/36
It's open source here as this is a public repo, and the license seems correct to me!


Ensure Subscriber.onSubscribe() is invoked before other methods

Motivation:
Commit 4f0cee147101db3911b36c6c1a8525be69199cfe introduced a regression
where Subscriber.onSubscribe() can be invoked after onComplete().
Modifications:

Reschedule the notification when onSubscribe() is not invoked yet.

Result:

Correct event order

AppVeyor build completed successfully but it seems like build status notification is not working at the moment.

Thank you for reviewing!


METRON-1212 The bundle system and maven plugin

This PR contains the Bundle system and Maven Plugin.
The bundle system and the plugin are adapted from the Apache Nifi project.
bundles-maven-plugin
The bundles-maven-plugin is an adapted version of the jar dependency plugin whose function is to bundle a jar of jars based on the dependencies for a project.  It also creates metadata attributes.
A project's jar, and it's non-provided dependency jars are place in a /lib entry in the bundle, with the bundle itself being in jar format.
bundles-lib
The bundles-lib contains the functionality required to:

discover bundles
inspect bundles for exposed extension types
load the bundles
create special class loaders for bundles
deliver instances of extension types for use

NAR exposed the bundles through many classes.  I have created the BundleSystem interface to expose a more usable, simplified api for our use cases.
From the original PR for METRON-777:
Metron Bundle Plugin

adaptation of the nifi plugin
more configurable wrt file extension/dependency and metadata naming
bundle-lib
adaptation of nifi-nar-utils to be used outside of the nifi project
rudimentary extensibility to allow configuration and injection of service types and other things that were hard coded to nifi
refactored from File based to VFS based
rebranding to Bundle from Nar ( although the lib and the plugin allow that to be configured now )
added capability to the properties class to write to stream, adapted to uri from paths
added integration tests for hdfs
changed to be ClassIndex based instead of ServiceLoader. Service loader is slower, and Casey's ClassIndex work is great. This also removes the NAR's required manual maintenance of the service file.
refactored to use VFS to load the bundle/nar into the classloader AND to use VFS to load the dependency jars -> VFS as a composite filesystem. Thus going from NAR's 'working directory', exploded NARS to just loading the bundle/nar.

Previous Review
Please see @mattf_apache's review
changes from that review
I have changed the InitContext operations to have explicit builders, and made it so that creating a context can be done separately from initialization.  Two contexts can then be 'merged'.  This is to allow for the addition of new bundles after initialization.
In preparing this PR I have:

made checkstyle fixes
fixed several types
added a requested set of tests loading and executing simple interface/implementation from bundle beyond what is already in the bundle-lib tests

Testing

This review is code review and test code review and running only
Test Project can be examined as a simple example of how to create bundles.

For all changes:

[x] Is there a JIRA ticket associated with this PR? If not one needs to be created at Metron Jira.
[x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
[x] Has your PR been rebased against the latest commit within the target branch (typically master)?
[x] Have you ensured that the full suite of tests and checks have been executed in the root metron \
[x] Have you written or updated unit tests and or integration tests to verify your changes?

For documentation related changes:

[x] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book?

@bbende
this is going in as a separate PR now.  I am not sure if you are interest or not, but I figure I'll give you a heads up.

FlatFile tests are failing with timeouts, kicking

@ottobackwards Are we have intermittent test failures again?

On that day the Flat File test failed.  Since it worked after open/close I wrote it off to a load / timing issue.
https://travis-ci.org/apache/metron/builds/280393026

From a quick check of other PR travis failures, it looks like my build was the only one to have that problem ( which as an expected 1000 got 908 issue )

This review is code review and test code review and running only

I have just started into this, but seems like I can create a bundle using the Maven plugin with this PR, right?

yes you can

Testing the bundle plugin
I have created a sample project that can be examined for testing the plugin:
test-bundles-plugin

@nickwallen are you still looking at this?

No, I need to get back to this.  Are you?  Don't let me stop your own review.

@nickwallen: I have just started into this, but seems like I can create a bundle using the Maven plugin with this PR, right?
@ottobackwards: yes you can

This was more of a leading question.  Can we add this step to the test plan?  Can you point to the directions on creating a bungle?
Is there anything else that should be part of the test plan?

@nickwallen I am doing some functional testing, but I'm not comfortable enough with it to give a full +1 on my own.  When I'm done I will report back.

Sounds good @JonZeolla thanks

Test Project can be examined as a simple example of how to create bundles.

@ottobackwards Maybe I'm being really stupid, but I don't understand how the test-bundles-plugin shows me how to create bundles.
Wouldn't I use the code in this PR to create something like the test-bundles-plugin?  Does that make sense?
What command do I run to create a bundle?  How do I validate that the bundle created is valid?

Thanks for looking at this again Nick, let me try to answer your questions.
TL;DR
I'm sorry for my confusion with your original statement.  I had in mind this part of @mattf-horton 's email on these pull requests:

The first PR will be just the “bundle” mechanism and the maven plugin.
Both are adaptations from the Apache NiFi project, and have already been
reviewed as part of PR# 530. Review is acknowledged to be purely
theoretical, and testing is based on the junit tests and integration
tests.

I thought an example project to look at would answer your question, not that you actually wanted to do it, or have instructions to do it.  Especial since you didn't say "the readme should have better instructions for creating a project that uses the plugin".
While creating bundles by hand is not in the initial use case, if you feel it is important I'll write a readme.

As with the NiFi version of the maven plugin, the 100% use case in practice ( and for initial dev in metron ) is to have bundles create as part of the archetype project generation.  When I 'adapted' the maven plugin, which consisted of adding the ability to rename the extension of the product and change the metadata prefixes, I did not make changes to the documentation of the plugin beyond documenting my changes.  I also did not attempt to add maven test harness support for the plugin, as it was not present in the original project.  Thus, the create by hand scenario for our version is as lacking as the create by hand scenario is in the origin nifi project.  I tried to avoid changing the plugin as much as possible, as it is already in use in NiFi.
As we had discussed in the threads and the meetings, this initial PR would contain the plugin and the bundle, and the practical testing would be limited.  I created and added reference to the test project because it is a simple example of a project that utilizes the plugin to create a bundle.  I did this as opposed to writing out a step by step guide to how to create a multi module maven project, as I mistakenly thought this would be helpful given the context of the review.
@mattf-horton, would it be possible for you to help us with a comment as to your approach when you reviewed this functionality?  It might help if you could summarize your feelings as well.  The context is different, as the review within 777 could not be a +1 for the PR since this was only part of the total, but since you are the only one to have had reviewed this, your views are pretty important.

@nickwallen If is OK with you, i'll make it a separate file to the README.md

I will extend the readme

@nickwallen hopefully the Readme changes help.

@ottobackwards  says:

would it be possible for you to help us with a comment as to your approach when you reviewed this functionality? It might help if you could summarize your feelings as well

{with music}
Oh spelunking we shall go, spelunking we shall go... :-)
{with music}
While reviewing the original incarnation of this, I tried to focus on the part most other Metron community members wouldn't be familiar with, the NiFi Bundle implementation, which I have some (small) experience with due to past work with NiFi.  The review I did was an eyeball line-by-line code review.  Of course actually running the code is also necessary, and at the time @mmiklavc  was focusing on that side of things.
Knowing that (a) the NiFi feature works in NiFi, and (b) Otto's intent was to change it as little as possible while porting it into Metron, I took an approach to reviewing it that focused on the changes.  Specifically, as best I remember, I applied the following logic:

I pulled a copy of the version of NiFi that Otto used as a base
I pulled a copy of Otto's dev branch (submitted in PR#530)
I observed relationships between directory paths of corresponding files (code organization relationships) in the two code sets, including filename changes (which were mostly pattern-based)
I applied "diff -w" to corresponding file pairs
I reviewed THAT as the code deltas of interest, the way we would code review a simple PR based on master
I also reviewed in detail the small number of newly created files, and missing/deleted files, compared to the related NiFi sources
I mapped my questions and remarks back to the submitted code in Otto's PR#530, and made the usual comments in that PR
We interacted and followed up as usual.

After many days and some untold number of comments, responses, and changes, I felt I understood and agreed with the state of the code, and gave it a +1 here: https://github.com/apache/metron/pull/530#issuecomment-322970038 ,
contingent on the practical trials being completed.
Now, we've changed gears a bit.  Faced with the difficulty of trying to review the offering all at once, whether in a PR or in a "feature branch" (turned out that wasn't much help after all), @ottobackwards and I proposed, and you'all accepted, the idea of breaking it up into five or so chunks.  This was specified in my email to<EMAIL_ADDRESS>25 Sep 2017, Subject: Re: feature branch bumps (see http://mail-archives.apache.org/mod_mbox/metron-dev/201709.mbox/browser , Thread view, page 2, about 3/4 way down the page).
It was specifically called out that for the first chunk, consisting of just the “bundle” mechanism and the maven plugin,

"Review is acknowledged to be purely theoretical, and testing is based on the junit tests and integration tests.  We’ll add a simple integration test with a synthetic test jar containing a trivial
Class, unrelated to parsers, invoked in a test case via reflection (hence needing no glue
code).  After passing that level of review and testing, it would be committed, with an understanding that additional revisions might be required as the result of subsequent PR comments.

So on the one hand, we agreed to a fairly light-weight review process, since by the nature of a piece-wise submission, the first part can't be tested on parsers.  I encourage you to stick with that resolve.
On the other hand, the simple integration test suggested does call for being able to see a "hello-world" Stellar command loaded and run from a bundle, which actually would be kinda exciting.
@ottobackwards , can your test bundle be turned into a Stellar function, loaded, and invoked (by reflection so you don't need to worry about registration)?  That would look more like an integration test than that bundle hanging out by itself.

@ottobackwards  hopefully the Readme changes help.

The Getting Started information that you added to the README is outstanding!

@mattf-horton I have added some more documentation, and I think the bundles-testing project provides a simple, integrated example.  @nickwallen and I talked it over, and he is going to try that.

I checkout your PR and then attempt to do an install and the build fails.
$ mvn clean install
[INFO] Scanning for projects...
Downloading: https://repo.maven.apache.org/maven2/org/apache/metron/bundles-maven-plugin/0.4.2/bundles-maven-plugin-0.4.2.pom
[WARNING] The POM for org.apache.metron:bundles-maven-plugin:jar:0.4.2 is missing, no dependency information available
Downloading: https://repo.maven.apache.org/maven2/org/apache/metron/bundles-maven-plugin/0.4.2/bundles-maven-plugin-0.4.2.jar
[ERROR] [ERROR] Some problems were encountered while processing the POMs:
[ERROR] Unresolveable build extension: Plugin org.apache.metron:bundles-maven-plugin:0.4.2 or one of its dependencies could not be resolved: Could not find artifact org.apache.metron:bundles-maven-plugin:jar:0.4.2 in central (https://repo.maven.apache.org/maven2) @
 @
[ERROR] The build could not read 1 project -> [Help 1]
[ERROR]
[ERROR]   The project org.apache.metron:bundles-testing:0.4.2 (/Users/nallen/tmp/metron-pr774/bundles-testing/pom.xml) has 1 error
[ERROR]     Unresolveable build extension: Plugin org.apache.metron:bundles-maven-plugin:0.4.2 or one of its dependencies could not be resolved: Could not find artifact org.apache.metron:bundles-maven-plugin:jar:0.4.2 in central (https://repo.maven.apache.org/maven2) -> [Help 2]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/ProjectBuildingException
[ERROR] [Help 2] http://cwiki.apache.org/confluence/display/MAVEN/PluginManagerException

I noticed that you changed the .travis build instructions so that you have to manually go into the bundles-maven-plugin project and install that first.
$ git diff origin/master -- .travis.yml
diff --git a/.travis.yml b/.travis.yml
index f5edfb27..8023830a 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -33,6 +33,7 @@ before_install:
   - npm config set prefix $HOME/.npm-prefix --global

 install:
+  - cd bundles-maven-plugin && mvn -q install && cd ..
   - time mvn -q -T 2C -DskipTests clean install

 script:

Ideally we need to be able to just build Metron by running an install from the root directory.  Is there no way around this?  What troubles did you run into that caused you to have to do this?

I'm sorry nick, the instruction for 'how to build metron' from the top level readme didn't get pulled over when I did the reconstruction.
The plugin is not in any repo for maven to install from.  I don't know how to get it installed since we don't publish it.  I will check my list history, but I think we (not you necessarily) talked about doing it this way until we figured out if we were going to publish the plugin.

Bringing over this from #530,
https://github.com/apache/nifi/commit/d90cf846b9dcd49acdeac7bb5fcd13ee80dcdba6#diff-83e1afb34470ca47809f82aa1caf2138
is the commit in nifi for the nat-utils to diff.

@nickwallen I have added a usage document in the last commit.  Is this what you are looking for?

I have refactored to have a top level metron-bundles directory, with the bundles lib and bundles testing under there.

I have created a new feature branch feature/METRON-1211-extensions-parsers-gradual to track this.
and have rebased this PR on to that.
I have also updated confluence and jira : https://cwiki.apache.org/confluence/display/METRON/Metron+Extension+System+and+Parser+Extensions

Feature Branch still makes sense
now that we are splitting it up it will work better
I don't want to have to worry about regression for short periods

Will email list

The new Trusty image breaks my build. I need to figure out why exactly, so I'll be trying a few things.


[Question] How to detect form changes after binding initial form values using [submission]

Hello,
Is there a way to detect form changes after binding initial form values using [submission]. something like below:
<formio (change)="onChange($event)" (ready)="formReady($event)" [form]="form" [options]="options"                 [submission]="initialData"></formio>
with this setup, change event is getting triggered when binding the initial value itself. so am not able to detect the new form changes after form binding.
@travist, any help or direction is really appreciated. Thank you.

did something like this using lodash,
onchange(event: any){ const isChanged = !_.isEqual(event.data, actualDataWhenBinding); }


refactor(app): add tiprack setup prompt to robot calibration check flow

overview
Prompt user to load the required tipracks into the correct slots of the deck before proceeding to
check the robot's calibration
Closes #5033

changelog

Add corresponding view for 'loadLabware' step of robot calibration check
Add temporary api state machine stub, to allow continued FE iteration, before backend settles.

risk assessment
low; behind a feature flag

Closing in favor of forthcoming PR without stubbed API side state machine and with tip pickup flow.


Change In CiteKey Format is not Reflected In Export

Debug log ID
CKYXHMEP-euc/6.7.140-7
What happened?
I have changed the citekey format to auth.lower in setting as an example, but when I export (both to file and quick copy) the citekey format remains the default auth.lower + shorttitle(3,3) + year.
I am running flathub Zotero 7.0.0-beta.53+969031a37 (64-bit) with a fresh installation of better-bibtex.
Example Behavior and Expected Behavior
For example, if I want to export
May, J. P. (1999). A concise course in algebraic topology. University of Chicago Press.

I still get
@book{mayConciseCourseAlgebraic1999,
  title = {A Concise Course in Algebraic Topology},
  author = {May, J. Peter},
  year = {1999},
  series = {Chicago Lectures in Mathematics},
  publisher = {{University of Chicago Press}},
  address = {{Chicago}},
  isbn = {978-0-226-51182-5 978-0-226-51183-2},
  lccn = {QA612 .M387 1999},
  keywords = {Algebraic topology}
}

I am expecting the export to be
@book{may,
  title = {A Concise Course in Algebraic Topology},
  author = {May, J. Peter},
  year = {1999},
  series = {Chicago Lectures in Mathematics},
  publisher = {{University of Chicago Press}},
  address = {{Chicago}},
  isbn = {978-0-226-51182-5 978-0-226-51183-2},
  lccn = {QA612 .M387 1999},
  keywords = {Algebraic topology}
}

An aside: This is just an example (it would be pretty unreadable to have just the author as citation key). I actually want the citation key to be auth.lower + '_' + shorttitle(3,3) + '_' + year.

Did you edit the item after changing the formula, or right-clicked it and refreshed the citation key? Just updating the formula does not change existing citekeys. Only a change to the item, or a forced refresh, applies the new formula.

Oh! That is a bit unintuitive, but it works now. Thanks!

Oh! That is a bit unintuitive, but it works now. Thanks!

If it did change whenever the formula changes the citation keys would continuously change while you are typing the formula; if you want to enter
auth.lower + '_' + shorttitle(3,3) + '_' + year

auth would first be valid, and all keys would change, then auth.lower would become valid, and all keys would change, then auth.lower + '_' would become valid, etc.

Maybe a better UX is to add a highlighted "refresh all citation key" button underneath the citation key formula when the system detects that the citation key formula is changed?

What would turn the button back off again? If you manually refresh items, or edit them, the formula would already have been applied. I'd have to keep track of what items (or keys) hadn't changed since last edit to the formula. ISTM it would get convoluted fast, and then the button status would be one more unintuitive aspect of the BBT UI.


Error in fetching reports from VmRay without tags

Hello,
I have on my VmRay platform reports with and without tags and I'd like to have both as feeds on MISP. When I set the tag value in the "config.toml" file I received the below error:

Is there is a way we can set the tag value to be true without generating the above error?

I'm really sorry the the late response, but the error should be fixed now.


Nokogiri::XML::XPathContext.register_namespaces fails on UTF-16 file

When trying to use any xpath related methods on UTF-16 file this happens:
>ruby test.rb
C:/ruby/Ruby200/lib/ruby/gems/2.0.0/gems/nokogiri-<IP_ADDRESS>-x86-mingw32/lib/nokogiri/xml/xpath_context.rb:9:in `gsub': incompatible encoding regexp match (US-ASCII regexp with UTF-16 string) (Encoding::CompatibilityError)
        from C:/ruby/Ruby200/lib/ruby/gems/2.0.0/gems/nokogiri-<IP_ADDRESS>-x86-mingw32/lib/nokogiri/xml/xpath_context.rb:9:in `block in register_namespaces'
        from C:/ruby/Ruby200/lib/ruby/gems/2.0.0/gems/nokogiri-<IP_ADDRESS>-x86-mingw32/lib/nokogiri/xml/xpath_context.rb:8:in `each'
        from C:/ruby/Ruby200/lib/ruby/gems/2.0.0/gems/nokogiri-<IP_ADDRESS>-x86-mingw32/lib/nokogiri/xml/xpath_context.rb:8:in `register_namespaces'
        from C:/ruby/Ruby200/lib/ruby/gems/2.0.0/gems/nokogiri-<IP_ADDRESS>-x86-mingw32/lib/nokogiri/xml/searchable.rb:158:in `block in xpath'
        from C:/ruby/Ruby200/lib/ruby/gems/2.0.0/gems/nokogiri-<IP_ADDRESS>-x86-mingw32/lib/nokogiri/xml/searchable.rb:156:in `map'
        from C:/ruby/Ruby200/lib/ruby/gems/2.0.0/gems/nokogiri-<IP_ADDRESS>-x86-mingw32/lib/nokogiri/xml/searchable.rb:156:in `xpath'
        from C:/ruby/Ruby200/lib/ruby/gems/2.0.0/gems/nokogiri-<IP_ADDRESS>-x86-mingw32/lib/nokogiri/xml/searchable.rb:186:in `at_xpath'
        from test.rb:6:in `block in <main>'
        from test.rb:4:in `open'
        from test.rb:4:in `<main>'

test.rb:
require 'nokogiri'

File.open('test.xml', 'rb') do |file|
  doc = Nokogiri::XML(file)
  p doc.at_xpath('/some/xpath')
end

test.xml (encoded in UTF-16LE with BOM):
<?xml version='1.0' encoding='UTF-16'?>
<some_tag xmlns='http://some.url.example.com'>
</some_tag>

Tested with the same result on two different setups:
Windows box config:
>wmic os get Caption, CSDVersion, OSArchitecture /value
Caption=Microsoft Windows 7 Professional
CSDVersion=Service Pack 1
OSArchitecture=64-bit

>ruby -v
ruby 2.0.0p481 (2014-05-08) [i386-mingw32]

>gem list --local | findstr nokogiri
nokogiri (<IP_ADDRESS> x86-mingw32)

Linux box config:
$ cat /etc/system-release
Fedora release 22 (Twenty Two)

$ uname -a
Linux aXe1-nb 4.0.6-300.fc22.x86_64 #1 SMP Tue Jun 23 13:58:53 UTC 2015 x86_64 x86_64 x86_64 GNU/Linux

$ ruby -v
ruby 2.2.2p95 (2015-04-13 revision 50295) [x86_64-linux]

$ gem list --local | grep nokogiri
nokogiri (<IP_ADDRESS>)

Thanks for reporting. This may be a dup of the issue that was brought up in #735, and so perhaps we want to resurrect that PR at this point.
Will take a look. If you could try applying #735 locally and let us know if that addresses your issue, that would be interesting information to know.

Retested every XML file in that .xlsx ( #735 ): same error on both platforms for all files.

Can't reproduce. Notes from #735 indicate that this is likely due to an issue with older Rubies and not with Nokogiri. Closing.


Unable to Scan Luca QR Code

Avoid duplicates

[x] Bug is not mentioned in the FAQ
[x] Bug affects both Android and iOS, for specific issues / questions that apply only to one operating system, please raise them in the respective repositories:

Android repository
iOS repository

[x] Bug is not already reported in another issue

Technical details

Device name: iPhone 12
iOS/Android version: iOS 14.6
App version: 2.4.2

Describe the bug

Several times in the past it has been reported that it will be possible to use the luca generated QR code to check-in to a location. Until now I'm not able to use this feature.
Steps to reproduce the issue
Try to check-in to a location with a luca generated QR code.

Expected behaviour
Luca generated QR Codes must be compatible.

Possible Fix

Additional context

Hello @BoBiene
What @Ein-Tim says is correct. Luca QR codes currently cannot be scanned by the CWA due to security requirements (see https://github.com/corona-warn-app/cwa-server/pull/1362#issuecomment-861228455)

Because of the security requirements of this merged QR-Codes are still discussions ongoing. The security requirements are necessary to prevent deanonymization of the CWA users.

We will close your issue in favor of https://github.com/corona-warn-app/cwa-documentation/issues/590

Corona-Warn-App Open Source Team

@BoBiene FYI https://www.coronawarn.app/de/faq/#check_in_luca


Rails integration with react-boilerplate

How can i integrate new rails application with this boilerplate do i need any third party lib for achieve this,or any suggestion

See #679


Launching apps on nixos

I am trying to create keybindings for my web browser, text editor etc.
I set the following in my config file
(defalias web (cmd-button "${pkgs.bash}/bin/bash ${pkgs.brave}/bin/brave"))
(defalias ed (cmd-button "${pkgs.bash}/bin/bash ${pkgs.sublime4}/bin/subl"))
(defalias prn (cmd-button "echo ${pkgs.brave}/bin/brave >> /tmp/brave.txt"))

Brave or Sublime doesn't launch but the echo command does work.
systemctl status kmonad-internal shows the following when I try to launch brave
Feb 07 19:23:43 nixos kmonad-internal-start[31277]: mkdir: cannot create directory ‘/var/empty/.local’: Operation not permitted
Feb 07 19:23:43 nixos kmonad-internal-start[31278]: touch: cannot touch '/var/empty/.local/share/applications/mimeapps.list': No such file or directory
Feb 07 19:23:43 nixos kmonad-internal-start[31280]: chrome_crashpad_handler: --database is required
Feb 07 19:23:43 nixos kmonad-internal-start[31280]: Try 'chrome_crashpad_handler --help' for more information.
Feb 07 19:23:43 nixos kmonad-internal-start[31280]: [31281:31281:0207/192343.711545:ERROR:socket.cc(120)] recvmsg: Connection reset by peer (104)
Feb 07 19:23:43 nixos kmonad-internal-start[31280]: /nix/store/bcijns5f6iq8y8v153dzyascgj9f9fjl-brave-1.47.186/bin/.brave-wrapped: line 48: 31281 Trace/breakpoint trap   (core dumped) "$HER>

On the other hand nothing happens when I try to launch sublime.
This problem only happens when kmonad starts with the systemd service created by the nixos module. If I start kmonad on command line with kmonad config.kbd then programs launch properly. I assume the problem occurs due to the way nixos isolates packages but I am not sure.

I am not familiar with nix so i wont be able help much beyond this point, but if you start kmonad from the commmand line as root do you get the same error? if thats the case you could try prefixing the command with sudo -u <your user>,

Nope, it works fine from command line even as root. I tried adding sudo -u username anyway and it still gives the same error. So, I don't think the problem is related to that.

This issue might be a duplicate for this https://github.com/kmonad/kmonad/issues/668. if you restart kmonad systemd service, works?
Actually, as soon I boot my system (Ubuntu), I restart the kmonad.service just to fix this, a workaround not very practical since sometimes I forgot to do that, but still it's a thing.


Improve BCP-47 matching in name table

Currently name table thinks "fa-IR" cannot be encoded in Windows names, because the table only has a "fa" entry.  How should this be resolved?  Keep dropping last item in the langcode while there's no match?

Unicode defines an algorithm to minimize BCP47 language identifiers, with supporting data in CLDR. For example, this will transform all of fa-IR, fa-Arab and fa-Arab-IR to fa. The algorithm preserves some subtags; for example, fa-Arab-AF gets mapped to fa-AF because Iran (and not Afghanistan) is assumed to be the default region for the Farsi language.
ICU has implemented this algorithm, so we could call ICU. Alternatively, we could write a pure Python implementation somewhere in fonttools.misc. I think we should do the latter, because the algorithm isn’t all that complicated, and ICU would add a rather hefty dependency to fonttools.
I wouldn’t recommend blindly stripping language tags until we find a match in the old-style enums. The very point of BCP47 is to go beyond limited enums, and the reason for adding ltag to TrueType (respectively name format 1 to OpenType) was to support arbitrary BCP47 tags.

I agree a fontTools.bcp47 would be nice.

Here’s two independent Python implementations. They both seem a bit heavy to me, but I’m putting the links here for reference.

https://github.com/OnroerendErfgoed/language-tags
https://github.com/LuminosoInsight/langcodes/

I see that varLib's fvar builder is not using that addMultilingualNames method yet, and only adds English names (via addNames method). For the time being, couldn't we just use the hard-coded mappings we already have, or do must we wait for full support for BCP-47 tags normalization?

Agree, I think the current function is OK for now. It can always be improved later.

The addMultilingualNames method adds Macintosh (platform 1) nameIDs only when it can't find a match for a given BCP-47 tag among Windows (platform 3) language ids.
The addNames method currently used by default adds both Mac and Windows (English) nameIDs.
If we un-comment that line and use the former instead of the latter, that means we would no longer add both sets of nameIDs for fvar axes names, but only one set (most often, the Windows ones).
Would that be ok? @robmck-ms reported an issue with OSX requiring platformID=1 names for variable fonts: https://github.com/fonttools/fonttools/issues/683
Is it only the postScriptNameID which OSX require as single-byte encoding, or also  axisNameID and subfamilyNameID?
https://github.com/fonttools/fonttools/issues/756

Uhm, why not try and see what works?

The addMultilingualNames method adds Macintosh (platform 1) nameIDs only when it can't find a match for a given BCP-47 tag among Windows (platform 3) language ids.

In the context of #683 I think addMultilingualNames should just always add platform 1 versions. Or make it optional via a flag in the method signature. I don't understand what sense it makes to only add them if a windows version can't be made.
As it stands, addName by default adds both platform 1 and platform 3 versions, but addMultilingualNames only adds platform 3 (in the usual case), which appears inconsistent.

I can make a PR.

thanks!


Upgrade CRDs to apiextensions.k8s.io/v1

K8s 1.16 promoted CustomResourceDefinition from v1beta1 to v1
See the 3rd changelog bullet point for details as well as the blog post overview.
Kong should upgrade the CRDs to v1 to take advantage of these new features. I'm not sure what the support policy is for these charts since it would require k8s 1.16. Perhaps you can use helm's Capabilities.Has if older k8s versions should continue to be supported?

@hbagdi any thoughts from the controller end? Should our CRDs require anything beyond a bump to the API version used?
On the Helm front, this may be difficult. Although the capabilities info is fine for this purpose, Helm 3 CRDs aren't templated, and I don't think there's any good way to handle the version split without templating. https://helm.sh/docs/chart_best_practices/custom_resource_definitions/#some-caveats-and-explanations effectively states that handling this is an open question to be answered later.

The controller should be fine. We can quickly test if required.
We will need to make some changes to CRD to make them structured.
Regarding, lack of support from Helm, can we open a Github issue on helm/helm please?
A lot of charts will run into this and having some consensus around the solution will go a long way for the entire community.

Revisiting this since it will come up again in the Kong chart 1.6 release. Helm behavior remains unchanged, but we'll instruct users that they need to upgrade manually in UPGRADE.md.
Handling this in Helm is an open, heavily-debated question: https://github.com/helm/helm/issues/5871
Our other option absent any changes to manage the CRDs via a subchart. This adds more overhead, but allows upgrading CRDs and managing them in an independent release if desired. As the CRD chart would not require any settings, it should avoid the more cumbersome aspects of using subcharts. It further works around scenarios where the Kong operators may not have permissions to manage CRDs, one of the major sticking points for the upstream Helm proposal.

Handled in 2.4.


Merge dev branch

Merge Bitcoin PR back-ports bringing enhanced security and fixes.

Merging Furious' Pull Request to merge Maintenance Dev Branch to Master Branch


Creating blacklist import rules

Creating a new generic blacklist rule and removing the older
specific ones. This will need configuration integration when
we have some.
The new test is immune to import aliasing but not shadowing

Looks good @callidus thanks!


Add more tests/examples

Luke:

[ ] Clustering (use a shell script instead of inline command)
[x] Invoking the lambda using aws lambda invoke (may require env vars for credentials, etc.)
[x] curl for managing external SaaS (GitHub labels?)

Laura:

[x] Provisioner in examples repo
[ ] Ansible? (Or Chef, etc.)
[x] kubectl command?

Ian:

[ ] Templating?  (Assets/archives)

The remote Ansible example has been breaking in my builds due to either an error with GCP or an error with Ansible itself. There's a very simple local command example I've pushed up, but I'd like to see the remote one working before we call it a real example.

Closing this out - as we now have a good collection of examples here.  More are always welcome though!


[SPARK-24920][Core] Allow sharing Netty's memory pool allocators

What changes were proposed in this pull request?
Introducing shared polled ByteBuf allocators.
This feature can be enabled via the "spark.network.sharedByteBufAllocators.enabled" configuration.
When it is on then only two pooled ByteBuf allocators are created:

one for transport servers where caching is allowed and
one for transport clients where caching is disabled

This way the cache allowance remains as before.
Both shareable pools are created with numCores parameter set to 0 (which defaults to the available processors) as conf.serverThreads() and conf.clientThreads() are module dependant and the lazy creation of this allocators would lead to unpredicted behaviour.
When "spark.network.sharedByteBufAllocators" is false then a new allocator is created for every transport client and server separately as was before this PR.
How was this patch tested?
Existing unit tests.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Test build #99927 has started for PR 23278 at commit f73bc8f.

add to whitelist

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/5934/
Test PASSed.

Test build #99928 has started for PR 23278 at commit f73bc8f.

Test build #99928 has finished for PR 23278 at commit f73bc8f.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99928/
Test PASSed.

Test build #99927 has finished for PR 23278 at commit f73bc8f.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99927/
Test PASSed.

Merged build finished. Test PASSed.

Test build #99938 has started for PR 23278 at commit ae8fa8e.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/5943/
Test PASSed.

Test build #99938 has finished for PR 23278 at commit ae8fa8e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99938/
Test PASSed.

LGTM, will leave it here a bit to see if anyone else comments.

java.io.IOException: Failed to send RPC<PHONE_NUMBER>399199898 to slave2.sf.fullink.tech/<IP_ADDRESS>:37470: io.netty.handler.codec.EncoderException: java.lang.OutOfMemoryError: Java heap space
at org.apache.spark.network.client.TransportClient.lambda$sendRpc$2(TransportClient.java:237)
at io.netty.util.concurrent.DefaultPromise.notifyListener0(DefaultPromise.java:507)
at io.netty.util.concurrent.DefaultPromise.notifyListenersNow(DefaultPromise.java:481)
at io.netty.util.concurrent.DefaultPromise.notifyListeners(DefaultPromise.java:420)
at io.netty.util.concurrent.DefaultPromise.tryFailure(DefaultPromise.java:122)
at io.netty.util.internal.PromiseNotificationUtil.tryFailure(PromiseNotificationUtil.java:64)
at io.netty.channel.AbstractChannelHandlerContext.notifyOutboundHandlerException(AbstractChannelHandlerContext.java:837)
at io.netty.channel.AbstractChannelHandlerContext.invokeWrite0(AbstractChannelHandlerContext.java:740)
at io.netty.channel.AbstractChannelHandlerContext.invokeWrite(AbstractChannelHandlerContext.java:730)
at io.netty.channel.AbstractChannelHandlerContext.write(AbstractChannelHandlerContext.java:816)
at io.netty.channel.AbstractChannelHandlerContext.write(AbstractChannelHandlerContext.java:723)
at io.netty.handler.timeout.IdleStateHandler.write(IdleStateHandler.java:302)
at io.netty.channel.AbstractChannelHandlerContext.invokeWrite0(AbstractChannelHandlerContext.java:738)
at io.netty.channel.AbstractChannelHandlerContext.invokeWrite(AbstractChannelHandlerContext.java:730)
at io.netty.channel.AbstractChannelHandlerContext.access$1900(AbstractChannelHandlerContext.java:38)
at io.netty.channel.AbstractChannelHandlerContext$AbstractWriteTask.write(AbstractChannelHandlerContext.java:1081)
at io.netty.channel.AbstractChannelHandlerContext$WriteAndFlushTask.write(AbstractChannelHandlerContext.java:1128)
at io.netty.channel.AbstractChannelHandlerContext$AbstractWriteTask.run(AbstractChannelHandlerContext.java:1070)
at io.netty.util.concurrent.AbstractEventExecutor.safeExecute(AbstractEventExecutor.java:163)
at io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:403)
at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:463)
at io.netty.util.concurrent.SingleThreadEventExecutor$5.run(SingleThreadEventExecutor.java:858)
at io.netty.util.concurrent.DefaultThreadFactory$DefaultRunnableDecorator.run(DefaultThreadFactory.java:138)
at java.lang.Thread.run(Thread.java:748)
Caused by: io.netty.handler.codec.EncoderException: java.lang.OutOfMemoryError: Java heap space
at io.netty.handler.codec.MessageToMessageEncoder.write(MessageToMessageEncoder.java:106)
at io.netty.channel.AbstractChannelHandlerContext.invokeWrite0(AbstractChannelHandlerContext.java:738)
... 16 more
Caused by: java.lang.OutOfMemoryError: Java heap space
at io.netty.util.internal.PlatformDependent.allocateUninitializedArray(PlatformDependent.java:200)
at io.netty.buffer.PoolArena$HeapArena.newByteArray(PoolArena.java:676)
at io.netty.buffer.PoolArena$HeapArena.newChunk(PoolArena.java:686)
at io.netty.buffer.PoolArena.allocateNormal(PoolArena.java:244)
at io.netty.buffer.PoolArena.allocate(PoolArena.java:214)
at io.netty.buffer.PoolArena.allocate(PoolArena.java:146)
at io.netty.buffer.PooledByteBufAllocator.newHeapBuffer(PooledByteBufAllocator.java:307)
at io.netty.buffer.AbstractByteBufAllocator.heapBuffer(AbstractByteBufAllocator.java:166)
at io.netty.buffer.AbstractByteBufAllocator.heapBuffer(AbstractByteBufAllocator.java:157)
at org.apache.spark.network.protocol.MessageEncoder.encode(MessageEncoder.java:82)
at org.apache.spark.network.protocol.MessageEncoder.encode(MessageEncoder.java:33)
at io.netty.handler.codec.MessageToMessageEncoder.write(MessageToMessageEncoder.java:88)
... 17 more

How to solve this problem

java.io.IOException: Failed to send RPC<PHONE_NUMBER>399199898 to slave2.sf.fullink.tech/<IP_ADDRESS>:37470: io.netty.handler.codec.EncoderException: java.lang.OutOfMemoryError: Java heap space
at org.apache.spark.network.client.TransportClient.lambda$sendRpc$2(TransportClient.java:237)
at io.netty.util.concurrent.DefaultPromise.notifyListener0(DefaultPromise.java:507)
at io.netty.util.concurrent.DefaultPromise.notifyListenersNow(DefaultPromise.java:481)
at io.netty.util.concurrent.DefaultPromise.notifyListeners(DefaultPromise.java:420)
at io.netty.util.concurrent.DefaultPromise.tryFailure(DefaultPromise.java:122)
at io.netty.util.internal.PromiseNotificationUtil.tryFailure(PromiseNotificationUtil.java:64)
at io.netty.channel.AbstractChannelHandlerContext.notifyOutboundHandlerException(AbstractChannelHandlerContext.java:837)
at io.netty.channel.AbstractChannelHandlerContext.invokeWrite0(AbstractChannelHandlerContext.java:740)
at io.netty.channel.AbstractChannelHandlerContext.invokeWrite(AbstractChannelHandlerContext.java:730)
at io.netty.channel.AbstractChannelHandlerContext.write(AbstractChannelHandlerContext.java:816)
at io.netty.channel.AbstractChannelHandlerContext.write(AbstractChannelHandlerContext.java:723)
at io.netty.handler.timeout.IdleStateHandler.write(IdleStateHandler.java:302)
at io.netty.channel.AbstractChannelHandlerContext.invokeWrite0(AbstractChannelHandlerContext.java:738)
at io.netty.channel.AbstractChannelHandlerContext.invokeWrite(AbstractChannelHandlerContext.java:730)
at io.netty.channel.AbstractChannelHandlerContext.access$1900(AbstractChannelHandlerContext.java:38)
at io.netty.channel.AbstractChannelHandlerContext$AbstractWriteTask.write(AbstractChannelHandlerContext.java:1081)
at io.netty.channel.AbstractChannelHandlerContext$WriteAndFlushTask.write(AbstractChannelHandlerContext.java:1128)
at io.netty.channel.AbstractChannelHandlerContext$AbstractWriteTask.run(AbstractChannelHandlerContext.java:1070)
at io.netty.util.concurrent.AbstractEventExecutor.safeExecute(AbstractEventExecutor.java:163)
at io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:403)
at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:463)
at io.netty.util.concurrent.SingleThreadEventExecutor$5.run(SingleThreadEventExecutor.java:858)
at io.netty.util.concurrent.DefaultThreadFactory$DefaultRunnableDecorator.run(DefaultThreadFactory.java:138)
at java.lang.Thread.run(Thread.java:748)
Caused by: io.netty.handler.codec.EncoderException: java.lang.OutOfMemoryError: Java heap space
at io.netty.handler.codec.MessageToMessageEncoder.write(MessageToMessageEncoder.java:106)
at io.netty.channel.AbstractChannelHandlerContext.invokeWrite0(AbstractChannelHandlerContext.java:738)
... 16 more
Caused by: java.lang.OutOfMemoryError: Java heap space
at io.netty.util.internal.PlatformDependent.allocateUninitializedArray(PlatformDependent.java:200)
at io.netty.buffer.PoolArena$HeapArena.newByteArray(PoolArena.java:676)
at io.netty.buffer.PoolArena$HeapArena.newChunk(PoolArena.java:686)
at io.netty.buffer.PoolArena.allocateNormal(PoolArena.java:244)
at io.netty.buffer.PoolArena.allocate(PoolArena.java:214)
at io.netty.buffer.PoolArena.allocate(PoolArena.java:146)
at io.netty.buffer.PooledByteBufAllocator.newHeapBuffer(PooledByteBufAllocator.java:307)
at io.netty.buffer.AbstractByteBufAllocator.heapBuffer(AbstractByteBufAllocator.java:166)
at io.netty.buffer.AbstractByteBufAllocator.heapBuffer(AbstractByteBufAllocator.java:157)
at org.apache.spark.network.protocol.MessageEncoder.encode(MessageEncoder.java:82)
at org.apache.spark.network.protocol.MessageEncoder.encode(MessageEncoder.java:33)
at io.netty.handler.codec.MessageToMessageEncoder.write(MessageToMessageEncoder.java:88)
... 17 more

@duhanmin Could you help me giving some context regarding the attached stack trace?

Test build #100157 has started for PR 23278 at commit 3ac8983.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/6138/
Test PASSed.

Test build #100157 has finished for PR 23278 at commit 3ac8983.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/100157/
Test PASSed.

Test build #100641 has started for PR 23278 at commit 2f328e8.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/6558/
Test PASSed.

Test build #100641 has finished for PR 23278 at commit 2f328e8.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/100641/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/6571/
Test PASSed.

Test build #100659 has started for PR 23278 at commit dd671ec.

Test build #100763 has started for PR 23278 at commit fcee568.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/6657/
Test PASSed.

Merged build finished. Test PASSed.

Test build #100763 has finished for PR 23278 at commit fcee568.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/100763/
Test FAILed.

jenkins retest this please

Test build #100780 has started for PR 23278 at commit fcee568.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/6674/
Test PASSed.

Test build #100780 has finished for PR 23278 at commit fcee568.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/100780/
Test PASSed.

Test build #100814 has started for PR 23278 at commit d0d9486.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/6707/
Test PASSed.


StudyPrefetcher

Will StudyPrefetcher be available in v2.0?
Or there is another place to monitor downloading progress, performs some actions based on it and
define downloading strategy?
Thanks

I believe it's something we eventually intend to add, but it's not near the top of our lists. Feel free to suggest an implementation an spearhead the development with a PR 🙌

I don't really recall why we disabled it actually. I know we had issues with the study loading monitor thrashing redux too often (it probably shouldn't be using redux), but that is an independent component.
I know that we planned to revisit this as some point because it's a bit confusing how the prefetcher should work since extensions can register their own viewports components now.
https://github.com/OHIF/Viewers/blob/7c4ee734fab23940d74e96dbe79c08dec25e8798/platform/viewer/src/connectedComponents/Viewer.js#L285
https://github.com/OHIF/Viewers/blob/0064a4b1cd6b1b30e339e39bf92292ad1917fb35/platform/viewer/src/components/StudyPrefetcher.js
https://github.com/OHIF/Viewers/blob/0064a4b1cd6b1b30e339e39bf92292ad1917fb35/platform/core/src/classes/StudyPrefetcher.js

👞 💨 🤖
We're nearing a good place to begin scoping this.

Can you "point to how it was implemented in OHIF v1, and provide some guidance on how it should probably be implemented in v2.", please?

Any updates on this or more guidance available on this?
I will be working with a couple other developers to make some customisation of this viewer in the near future to better suit our needs. And this is also a highly wanted feature for us so if we are able to make some time this could be a good issue to have a closer look at.

The logic for StudyPrefetcher lives at:
<repo-root>/platform/core/src/classes/StudyPrefetcher.js
We expose that functionality in a React Component at:
<repo-root>/platform/viewer/src/component/StudyPrefetcher.js
It needs to:

Start when a viewing route is loaded
Stop when the viewing route is destroyed

The class handles:

Listening for when the cornerstone image cache is full

This allows it to stop prefetching when the LRU (least recently used) cache starts to purge

It's constructor takes an array of studies to prefetch
It's prefetchDisplaySets works with cornerstone-tools's requestPoolManager to orchestrate prefetching

The hang-up appears to be in getDisplaySetsToPrefetch. We need to find the study's display sets so we can prefetch them, but the code to do this is commented out.
Our app's data needs to be cleaned up, but for the time being, that info is retrieved in the <ViewerRetrieveStudyData> component. We prop drill quite a bit and pass those studies down. We also update an instance of the the studyMetadataManager that can be accessed by doing something like this:
import { utils } from '@ohif/core';

const { studyMetadataManager } = utils;
const studies = studyMetadataManager.all();

Long term, I'd like to make the study info we make reactive very thin, and keep the bulk of it's immutable information somewhere that won't trigger re-renders or unnecessary comparisons.

Just to know @Stormert did you succeded make something on the study prefetcher ?

@salimkanoun unfortunatly not, we ran in to some other issues with our image sets being too large 600-700MB when just letting them load regularly and trying to generate the MPR view causing browser lock ups and crashes so we had to put this project on ice for the time beeing. I have not been able to keep up with the updates here though some things might have changed since then.

This is a feature that I am in real need of for a project that I'm currently working on for eye care. we have OCT outputs with 127 and 256 frames (ultrasound b-scans). Currently it is painfully slow to browse these stacks, as it only starts loading each frame when you scroll to it.
I'm prepared to offer a bounty if somebody is willing to do the development. Please either reply here if you're interested or email me directly toby.bisco @ toukanlabs.com and let me know how much you would charge and how long it would take.
Thanks

@biskyt Actually RadicalImaging do some sponsored features to be integrated in OHIF.
Maybe @swederik will give you some details if they are available to do so.

@salimkanoun - Thanks for the quick response. We have been speaking with RadicalImaging, but so far they have not been able to find anybody. So I thought it worth posting here too to widen the search.
We're definitely happy to pay for the time.
To give a better idea of the issue, I've created the below video.
https://user-images.githubusercontent.com/8448094/110938172-610ce700-832b-11eb-9f6a-96b51fdb43f5.mp4
This shows the OHIF viewer vs the Osimis viewer. In the OHIF viewer, the user gets locked out of making any interactions while frames are loaded. There is also no indication of which frames are/not loaded. And as the frames are not being pre-fetched, this makes for a very painful user interaction when trying to load the full stack!
In the Osimis viewer, it is clear to see the loading progress, and no interactions are blocked if you scroll to a frame that is not loaded.
Other than this, the OHIF viewer is streets ahead of any other viewer I've come across.
We also have a few other small feature requests (which again we're happy to pay for), if we can find somebody willing to do the work.
I should note that the product we're trying to use the viewer in is a fully open source medical record, primarily for the NHS in the UK. We just don't have any developers in-house that are skilled in React, otherwise we'd be happy to contribute directly.

I see,
Actually i would be probably able to do it, or supervise a student to do it but i'm also missing bandwith....
Maybe next year we hope to be able to do some contribution to OHIF, but not this year

#3363 created for v3


Make email name quoting more complete

This PR tries to address the shortcomings pointed out in https://github.com/gitgitgadget/gitgitgadget/pull/98#issuecomment-506617659.

Do you have a test to check the "Don't quote if already quoted" logic?

Now I do ;-)

Do you have a test to check the "Don't quote if already quoted" logic?

Now I do ;-)


Next.js integration to the React code

Committed code in - https://github.com/ScottishCovidResponse/rampvis-ui/commit/384abed28f9075d99700a51df996c10496972066


Failed to activate the node-resolver package

I just installed "node-resolver" into "ATOM" and and on activation it threw an error... :cry:
Atom Version: 1.4.1
System: Mac OS X 10.11.3
Thrown From: node-resolver package, v1.0.1
Stack Trace
Failed to activate the node-resolver package
At Cannot read property 'command' of undefined

TypeError: Cannot read property 'command' of undefined
    at Object.exports.activate (/Users/mathijsvanvelde/.atom/packages/node-resolver/index.js:12:21)
    at Package.module.exports.Package.activateNow (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:183:20)
    at /Applications/Atom.app/Contents/Resources/app.asar/src/package.js:156:32
    at Package.module.exports.Package.measure (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:92:15)
    at /Applications/Atom.app/Contents/Resources/app.asar/src/package.js:149:26
    at Package.module.exports.Package.activate (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:146:34)
    at PackageManager.module.exports.PackageManager.activatePackage (/Applications/Atom.app/Contents/Resources/app.asar/src/package-manager.js:524:21)
    at /Applications/Atom.app/Contents/Resources/app.asar/node_modules/settings-view/lib/package-manager.js:444:29
    at exit (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/settings-view/lib/package-manager.js:73:16)
    at triggerExitCallback (/Applications/Atom.app/Contents/Resources/app.asar/src/buffered-process.js:213:47)
    at ChildProcess.<anonymous> (/Applications/Atom.app/Contents/Resources/app.asar/src/buffered-process.js:235:18)
    at emitTwo (events.js:87:13)
    at ChildProcess.emit (events.js:172:7)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:200:12)

Commands
  2x -3:54.4.0 application:add-project-folder (ol.tree-view.full-menu.list-tree.has-collapsable-children.focusable-panel)
     -2:11.3.0 core:backspace (atom-text-editor#editor.invisibles.space.editor.mini.is-focused)
     -0:21.8.0 core:confirm (atom-text-editor.editor.mini.is-focused)

Config
{
  "core": {
    "themes": [
      "atom-material-ui",
      "atom-dark-syntax"
    ]
  }
}

Installed Packages
# User
atom-material-ui, v0.8.0
build-make, v0.7.0
coffee-navigator, v0.0.18
node-resolver, v1.0.1

# Dev
No dev packages

+1

+1
seeing this also in Atom editor v1.4.1 and Mac OS X 10.11.3 El Capitan.

Failed to activate the node-resolver package
Cannot read property 'command' of undefined
Hide Stack Trace
TypeError: Cannot read property 'command' of undefined
    at Object.exports.activate (/Users/yuetsu/.atom/packages/node-resolver/index.js:12:21)
    at Package.module.exports.Package.activateNow (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:183:20)
    at /Applications/Atom.app/Contents/Resources/app.asar/src/package.js:156:32
    at Package.module.exports.Package.measure (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:92:15)
    at /Applications/Atom.app/Contents/Resources/app.asar/src/package.js:149:26
    at Package.module.exports.Package.activate (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:146:34)
    at PackageManager.module.exports.PackageManager.activatePackage (/Applications/Atom.app/Contents/Resources/app.asar/src/package-manager.js:524:21)
    at /Applications/Atom.app/Contents/Resources/app.asar/node_modules/settings-view/lib/package-manager.js:444:29
    at exit (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/settings-view/lib/package-manager.js:73:16)
    at triggerExitCallback (/Applications/Atom.app/Contents/Resources/app.asar/src/buffered-process.js:213:47)
    at /Applications/Atom.app/Contents/Resources/app.asar/src/buffered-process.js:220:18
    at Socket.<anonymous> (/Applications/Atom.app/Contents/Resources/app.asar/src/buffered-process.js:98:18)
    at emitOne (events.js:82:20)
    at Socket.emit (events.js:169:7)
    at Pipe._onclose (net.js:469:12)
The error was thrown from the node-resolver package. You can help by creating an issue. Please explain what actions triggered this error.

best,
—  faddah
 portland, oregon, u.s.a.

+1
Reproduced on Linux Mint 17.2, atom 1.4.3.

Looks like this is the root of the issue:
https://discuss.atom.io/t/replacement-for-atom-workspaceview-command/13636

+1

+1

+1

+1

+1

+1

@MathijsvVelde @leothelocust @faddah @invernizzie @VijayKumarMidde
too lazy to open a PR... but here is the fixed index.js file.. works on Mac Atom 1.7.2
var isRequire = require('is-require')('require')
var core      = require('resolve/lib/core.json')
var position  = require('file-position')
var eval      = require('static-eval')
var esprima   = require('esprima')
var resolve   = require('resolve')
var clone     = require('clone')
var path      = require('path')
var astw      = require('astw')

exports.activate = function() {
  atom.commands.add('atom-workspace','node-resolver:open-selected-dependencies', function() {
    var editor = atom.workspace.getActiveTextEditor()
    var ranges = editor.getSelectedBufferRanges().slice()
    var buffer = editor.getBuffer()
    var fpn = editor.getPath()
    var src = buffer.getText()
    var ast = esprima.parse(src, {
      loc: true
    })

    var lookup = position(src)
    var dir = path.dirname(fpn)
    var env = {}

    env.__dirname  = dir
    env.__filename = fpn

    astw(ast)(function(node) {
      if (!isRequire(node)) return
      if (!node.arguments) return
      if (!node.arguments.length) return

      var dst = node.evalled = node.evalled || eval(node.arguments[0], env)
      if (!dst) return
      if (core.indexOf(dst) !== -1) return

      var included = false

      for (var i = 0; i < ranges.length; i++) {
        var loc = clone(node.loc)

        loc.start.line--
        loc.end.line--

        var a = getIndex(lookup, ranges[i])
        var b = getIndex(lookup, loc)

        if (included = overlap(a, b)) break
      }

      if (!included) return

      resolve(dst, {
        basedir: dir
      }, function(err, result) {
        if (err) throw err
        return atom.workspace.open(result)
      })
    })
  })
}

function overlap(a, b) {
  if (a.end >= b.start && a.start <= b.start) return true
  if (b.end >= a.start && b.start <= a.start) return true
  if (a.start <= b.start && a.end >= b.end) return true
  if (b.start <= a.start && b.end >= a.end) return true
}

function getIndex(lookup, range, off) {
  off = off || 0

  return {
    start: lookup((range.start.row || range.start.line) + off, range.start.column)
    , end: lookup((range.end.row || range.end.line) + off, range.end.column)
  }
}

Same problem for me:
Atom Version: 1.8.0
System: Ubuntu 15.04
Thrown From: node-resolver package, v1.0.1
Stack Trace
Failed to activate the node-resolver package
At Cannot read property 'command' of undefined

TypeError: Cannot read property 'command' of undefined
    at Object.exports.activate (/home/sergio/.atom/packages/node-resolver/index.js:12:21)
    at Package.module.exports.Package.activateNow (/usr/share/atom/resources/app.asar/src/package.js:183:20)
    at /usr/share/atom/resources/app.asar/src/package.js:156:32
    at Package.module.exports.Package.measure (/usr/share/atom/resources/app.asar/src/package.js:92:15)
    at /usr/share/atom/resources/app.asar/src/package.js:149:26
    at Package.module.exports.Package.activate (/usr/share/atom/resources/app.asar/src/package.js:146:34)
    at PackageManager.module.exports.PackageManager.activatePackage (/usr/share/atom/resources/app.asar/src/package-manager.js:538:21)
    at /usr/share/atom/resources/app.asar/src/package-manager.js:519:29
    at Config.module.exports.Config.transactAsync (/usr/share/atom/resources/app.asar/src/config.js:337:18)
    at PackageManager.module.exports.PackageManager.activatePackages (/usr/share/atom/resources/app.asar/src/package-manager.js:514:19)
    at PackageManager.module.exports.PackageManager.activate (/usr/share/atom/resources/app.asar/src/package-manager.js:497:46)
    at /usr/share/atom/resources/app.asar/src/atom-environment.js:754:28

Commands

Config
{
  "core": {
    "projectHome": "/home/sergio/dev/Mettzer"
  }
}

Installed Packages
# User
atom-react-native-autocomplete, v0.0.27
color-picker, v2.2.1
css-comb, v2.4.3
javascript-snippets, v1.2.1
jshint, v1.8.5
language-javascript-jsx, v0.3.7
linter, v1.11.14
linter-csslint, v1.3.2
merge-conflicts, v1.4.4
node-debugger, v1.7.0
node-resolver, v1.0.1
react, v0.15.0
react-es6-snippets, v0.3.0
react-snippets, v0.4.2
terminal-plus, v0.14.5

# Dev
No dev packages

Same issue:
Atom Version: 1.10.2
Electron Version: 0.37.8
System: Mac OS X 10.11.6
Thrown From: node-resolver package, v1.0.1
Stack Trace
Failed to activate the node-resolver package
At Cannot read property 'command' of undefined

TypeError: Cannot read property 'command' of undefined
    at Object.exports.activate (/Users/hannah/.atom/packages/node-resolver/index.js:12:21)
    at Package.module.exports.Package.activateNow (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:183:20)
    at /Applications/Atom.app/Contents/Resources/app.asar/src/package.js:156:32
    at Package.module.exports.Package.measure (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:92:15)
    at /Applications/Atom.app/Contents/Resources/app.asar/src/package.js:149:26
    at Package.module.exports.Package.activate (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:146:34)
    at PackageManager.module.exports.PackageManager.activatePackage (/Applications/Atom.app/Contents/Resources/app.asar/src/package-manager.js:538:21)
    at /Applications/Atom.app/Contents/Resources/app.asar/src/package-manager.js:519:29
    at Config.module.exports.Config.transactAsync (/Applications/Atom.app/Contents/Resources/app.asar/src/config.js:337:18)
    at PackageManager.module.exports.PackageManager.activatePackages (/Applications/Atom.app/Contents/Resources/app.asar/src/package-manager.js:514:19)
    at PackageManager.module.exports.PackageManager.activate (/Applications/Atom.app/Contents/Resources/app.asar/src/package-manager.js:497:46)
    at /Applications/Atom.app/Contents/Resources/app.asar/src/atom-environment.js:765:28

Commands

Config
{
  "core": {
    "automaticallyUpdate": false,
    "disabledPackages": [
      "language-sass",
      "language-ruby",
      "language-ruby-on-rails",
      "language-python",
      "language-php",
      "language-perl",
      "language-less",
      "language-c",
      "language-clojure",
      "language-coffee-script",
      "language-csharp",
      "language-go",
      "language-java",
      "language-objective-c",
      "language-toml"
    ],
    "themes": [
      "one-dark-ui",
      "solarized-light-syntax"
    ]
  }
}

Installed Packages
# User
atom-handlebars, v1.3.0 (inactive)
atom-ternjs, v0.15.0 (inactive)
autocomplete-modules, v1.6.3 (inactive)
autocomplete-paths, v1.0.2 (inactive)
docblockr, v0.8.5 (inactive)
editorconfig, v1.4.1 (inactive)
git-blame, v0.4.11 (inactive)
git-plus, v5.17.1 (inactive)
git-projects, v1.17.0 (inactive)
highlight-selected, v0.11.2 (inactive)
maybs-quit, v1.3.0 (inactive)
node-resolver, v1.0.1 (inactive)
pigments, v0.35.1 (inactive)
solarized-seti-ui, v0.8.6 (inactive)
todo-show, v1.7.0 (inactive)
atom-dark-syntax, v0.27.0 (inactive)
atom-dark-ui, v0.52.0 (inactive)
atom-light-syntax, v0.28.0 (inactive)
atom-light-ui, v0.44.0 (inactive)
base16-tomorrow-dark-theme, v1.1.0 (inactive)
base16-tomorrow-light-theme, v1.1.1 (inactive)
one-dark-ui, v1.5.0 (inactive)
one-light-ui, v1.5.0 (inactive)
one-dark-syntax, v1.3.0 (inactive)
one-light-syntax, v1.3.0 (inactive)
solarized-dark-syntax, v1.0.2 (inactive)
solarized-light-syntax, v1.0.2 (inactive)
about, v1.5.3 (inactive)
archive-view, v0.61.1 (inactive)
autocomplete-atom-api, v0.10.0 (inactive)
autocomplete-css, v0.11.2 (inactive)
autocomplete-html, v0.7.2 (inactive)
autocomplete-plus, v2.31.1 (inactive)
autocomplete-snippets, v1.11.0 (inactive)
autoflow, v0.27.0 (inactive)
autosave, v0.23.1 (inactive)
background-tips, v0.26.1 (inactive)
bookmarks, v0.41.0 (inactive)
bracket-matcher, v0.82.1 (inactive)
command-palette, v0.38.0 (inactive)
deprecation-cop, v0.54.1 (inactive)
dev-live-reload, v0.47.0 (inactive)
encoding-selector, v0.22.0 (inactive)
exception-reporting, v0.39.0 (inactive)
find-and-replace, v0.201.0 (inactive)
fuzzy-finder, v1.3.0 (inactive)
git-diff, v1.1.0 (inactive)
go-to-line, v0.31.0 (inactive)
grammar-selector, v0.48.1 (inactive)
image-view, v0.58.2 (inactive)
incompatible-packages, v0.26.1 (inactive)
keybinding-resolver, v0.35.0 (inactive)
line-ending-selector, v0.5.0 (inactive)
link, v0.31.1 (inactive)
markdown-preview, v0.158.0 (inactive)
metrics, v0.53.1 (inactive)
notifications, v0.65.0 (inactive)
open-on-github, v1.2.0 (inactive)
package-generator, v1.0.0 (inactive)
settings-view, v0.242.2 (inactive)
snippets, v1.0.2 (inactive)
spell-check, v0.67.1 (inactive)
status-bar, v1.4.1 (inactive)
styleguide, v0.47.0 (inactive)
symbols-view, v0.113.0 (inactive)
tabs, v0.100.2 (inactive)
timecop, v0.33.2 (inactive)
tree-view, v0.208.2 (inactive)
update-package-dependencies, v0.10.0 (inactive)
welcome, v0.34.0 (inactive)
whitespace, v0.33.0 (inactive)
wrap-guide, v0.38.1 (inactive)
language-c, v0.52.1 (inactive)
language-clojure, v0.21.0 (inactive)
language-coffee-script, v0.47.2 (inactive)
language-csharp, v0.12.1 (inactive)
language-css, v0.37.1 (inactive)
language-gfm, v0.88.0 (inactive)
language-git, v0.15.0 (inactive)
language-go, v0.42.1 (inactive)
language-html, v0.45.1 (inactive)
language-hyperlink, v0.16.0 (inactive)
language-java, v0.23.0 (inactive)
language-javascript, v0.119.0 (inactive)
language-json, v0.18.2 (inactive)
language-less, v0.29.5 (inactive)
language-make, v0.22.2 (inactive)
language-mustache, v0.13.0 (inactive)
language-objective-c, v0.15.1 (inactive)
language-perl, v0.35.0 (inactive)
language-php, v0.37.2 (inactive)
language-property-list, v0.8.0 (inactive)
language-python, v0.45.0 (inactive)
language-ruby, v0.69.0 (inactive)
language-ruby-on-rails, v0.25.0 (inactive)
language-sass, v0.56.0 (inactive)
language-shellscript, v0.22.4 (inactive)
language-source, v0.9.0 (inactive)
language-sql, v0.23.0 (inactive)
language-text, v0.7.1 (inactive)
language-todo, v0.28.0 (inactive)
language-toml, v0.18.0 (inactive)
language-xml, v0.34.9 (inactive)
language-yaml, v0.26.0 (inactive)

# Dev
No dev packages

+2

this could be fixed with PR #16


Parvatijay2901/update signup_and_login_botton_color

Added isAllFieldsFilled property and a checkAllFieldsFilled function to the SignupState and LoginState classes to make sure the app can check if all the required fields are completed.
Further, added a section to check if isAllFieldsFilled and isValid are true => have the login button / signup button as "blue"/primary color, else, by default it is grey.
Issue #90

MultiBlocListene reference: https://github.com/felangel/bloc/issues/3155


reverse ip how to give ipV4 argument? POST and DELETE

Salut
https://eu.api.ovh.com/console/#/ip/{ip}/reverse#POST
./ovh-eu ip <IP_ADDRESS> reverse post --ipReverse <IP_ADDRESS> --reverse pilote.opensource-expert.com

returns
usage: POST /ip/<IP_ADDRESS>/reverse [-h] --ipReverse IPREVERSE --reverse
                                        REVERSE
POST /ip/<IP_ADDRESS>/reverse: error: argument --ipReverse: invalid loads value: '<IP_ADDRESS>'

but on console:
POST /1.0/ip/<IP_ADDRESS>/reverse HTTP/1.1
    Host:        eu.api.ovh.com
    Accept:        application/json
    Content-Type:        application/json;charset=utf-8
    X-Ovh-Application:         xxxxxxxxxxxxxxxxxxx
    X-Ovh-Consumer:        xxxxxxxxxxxxxxxxxxxxxxxxx
    X-Ovh-Signature:        $xxxxxxxxxxxxxxxxxxxx
    X-Ovh-Timestamp:<PHONE_NUMBER>
    {
      "ipReverse": "<IP_ADDRESS>",
      "reverse": "pilote.opensource-expert.com"
    }

it seems to be a type string… on schema it is
"dataType": "ip",

also what about delete?
./ovh-eu ip <IP_ADDRESS> reverse delete
[ipReverse] Given data (delete) is not valid for type ip

isn't working neither.
-h give a strange GET
./ovh-eu ip <IP_ADDRESS> reverse delete -h
usage: GET /ip/<IP_ADDRESS>/reverse/delete [-h]

optional arguments:
  -h, --help  show this help message and exit

works on console.

Hi,
Can you retry with the code from branch https://github.com/yadutaf/ovh-cli/tree/jt-arguments ? This is work in progress code but it should help with this bug.

I got:
./ovh-eu ip <IP_ADDRESS> reverse post --ipReverse <IP_ADDRESS> --reverse grep.opensource-expert.com
Traceback (most recent call last):
  File "./ovh-eu", line 194, in <module>
    verb, method, arguments = parser.parse('', args)
  File "/home/sylvain/code/ovh/ovh-cli/ovhcli/parser.py", line 195, in parse
    return parser.parse(base_url, args)
  File "/home/sylvain/code/ovh/ovh-cli/ovhcli/parser.py", line 209, in parse
    return parser.parse(base_url, args)
  File "/home/sylvain/code/ovh/ovh-cli/ovhcli/parser.py", line 195, in parse
    return parser.parse(base_url, args)
  File "/home/sylvain/code/ovh/ovh-cli/ovhcli/parser.py", line 201, in parse
    args = self.parse_action_params(verb, args, base_url)
  File "/home/sylvain/code/ovh/ovh-cli/ovhcli/parser.py", line 308, in parse_action_params
    param.get('description', ''),
  File "/home/sylvain/code/ovh/ovh-cli/ovhcli/parser.py", line 238, in _register_parser_command
    description = description.replace('%', '%%') # Encode description to fix some help printing
AttributeError: 'NoneType' object has no attribute 'replace'

branch:
git branch
  master
* origin/jt-arguments

my script works fine: (forward need to be set before, was done with ovh-cli OK)
./ovh_reverse.py <IP_ADDRESS> grep.opensource-expert.com
{
    "ipReverse": "<IP_ADDRESS>",
    "reverse": "grep.opensource-expert.com."
}

./ovh_reverse.py
#!/usr/bin/env python
# -*- encoding: utf-8 -*-

'''
First, install the latest release of Python wrapper: $ pip install ovh
Usage: ovh_reverse IP FQDN
'''

import os
import sys
import json
import ovh

ip = sys.argv[1]
fqdn = sys.argv[2]

# Instanciate an OVH Client. use your ovh.conf
client = ovh.Client()

result = client.post('/ip/%s/reverse/' % ip,
                    ipReverse=ip,
                    reverse=fqdn)

print json.dumps(result, indent=4) # Pretty print

I pushed my code here to test with public cloud:
https://github.com/opensource-expert/ovh-tools

Should be better now.

Fine, it works!
Steps:
first have an public cloud instance with an OVH IP, and set forward DNS, it fails correctly if not.
./cloud.sh set_forward_dns <IP_ADDRESS> grep.opensource-expert.com
null
Success

which calls approximately:
record=$(./ovh-eu --format json domain zone $domain record \
    --subDomain $subdomain \
    | jq -r '.[0]')
./ovh-eu --format json domain zone $domain record $record put --target $ip --ttl 60
./ovh-eu domain zone $domain refresh post

And finally:
./ovh-eu ip <IP_ADDRESS> reverse post --ipReverse <IP_ADDRESS> --reverse grep.opensource-expert.com
----------  ---------------------------
Ip reverse  <IP_ADDRESS>
Reverse     grep.opensource-expert.com.
----------  ---------------------------

Note:  ovhcli/schema.py depends of fixed local path and ./ohv-eu seems to must be called in its orginal folder.
 Thanks for testing. If this issue is solved for you, I'll let you close it :)
Regarding the hard-coded path, I'm aware of it . This is clearly not the right path to go to distribute the CLI. There is PR #10 about it. Maybe you already saw it.


Implements and tests passing blocks for requests on ResourceProxy.all

Allows request headers to be modified on ResourceProxy.all:
gh.issues().all do |req|
  req.headers["Accept"] = "fancyheader"
end

Seems legit :shipit:

merged and gem released


Git ignore src directory

The main benefit is an extremely lightweight npm package
Fixes #76

@steelbrain commented on the issue.


Elemental adept rules

I am going to be the teacher's pet here and ruin fun for everyone including myself. Unless the change is intended (and I wish it was like this in 5e), the Elemental adept feat should be turning 1s into 2s and not rerolling 1s.

Intentional. Feat is horrible otherwise.


Minor cleanup

bueno :+1:

Pull Request Test Coverage Report for Build 104

13 of 13 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 94.194%

Totals

Change from base Build 103:
0.0%

Covered Lines:
438

Relevant Lines:
465

💛  - Coveralls