Example dota2 require error

I am trying to run the example files, and it returns this error on the line where it tries to require the dota2 module.
Cannot read property 'k_EMsgGCClientWelcome' of undefined
    at Object.<anonymous> (dota2\index.js:163:39)
    at Module._compile (module.js:409:26)
    at Object.Module._extensions..js (module.js:416:10)
    at Module.load (module.js:343:32)
    at Function.Module._load (module.js:300:12)
    at Module.require (module.js:353:17)
    at require (internal/module.js:12:17)
    at Object.<anonymous> (dota2\examples\example2.js:8:10)
    at Module._compile (module.js:409:26)
    at Object.Module._extensions..js (module.js:416:10)

I also get this when trying to run the test file. What I have in the config file does not seem to affect the output of the test or the example.
Steam
    #connect
      √ should connect to Steam (393ms)
    #login
{ eresult: 5,
  eresult_extended: 5,
  client_supplied_steamid: '76561197960265728',
  count_loginfailures_to_migrate: 0,
  count_disconnects_to_migrate: 0 }
      1) should login to Steam

  Dota2
    2) "before all" hook

  1 passing (11s)
  2 failing

  1) Steam #login should login to Steam:
     Uncaught Error: Disconnected
      at SteamClient._disconnected (steam\lib\steam_client.js:186:24)
      at TCP._onclose (net.js:477:12)

  2) Dota2 "before all" hook:
     Error: timeout of 10000ms exceeded. Ensure the done() callback is being called in this test.
      at null.<anonymous> (mocha\lib\runnable.js:226:19)

JavaScript is not my forte, could somebody shed some light on this for me please?

Which example did you run? Did you make a config file? Not enough info to help you.

From the test file it seems you get an eresult: 5. If you check out handlers\helper.js, you'll see this: k_EResultInvalidPassword : 5, // password/ticket is invalid. So imma hazard a guess and say you've made a typo in your password.

test.js is the one that users shouldn't run... as it's for coverage testing. Simply running it will give the error 5, as no one should know its password, except travis.
We need more info on why the first script he run didn't work, as we literally have no idea what he did.

You can run test.js locally if you want though, it suffices to set the STEAM_USERNAME and  STEAM_PASSWORD environment variables. I do it all the time when I'm making new pulls. However I agree that it's pretty much useless if you want to actually see an example of how to use the library. I might rearrange the README at one point to put those two paragraphs at the end at the top.

@chardzard if you're running example2.js, make sure that the reference to node-dota2 is correct. In the version on the master and dev branches it references require('./') instead of require('../') (artifact of when the file was located at the root of the repo. I've made pull #297 to fix this.

I get the same error when running both example files. @Crazy-Duck I did change that, and I still get the error shown. It points me to an error in index.js that I'm not sure what it means. I am attempting to write a chat bot that will monitor a chat to send invites a private chat lobby.
I just read in the README about running the test file, so I was trying it out. Good to know I don't need to touch it. I thought that was what was used to determine if everything was setup correctly.

@chardzard can you list the exact steps you've taken when you're trying to set up the example files? The correct way to set things up to execute the example files is

install latest version of node js (either 4.4.7 or 6.2.2)
clone the repo
navigate to the repository root
npm install steam (not sure if this is still necessary, but it can't hurt)
npm install
create a config.js file in the examples directory. You can see some example contents in config.js.example
run either node examples/example.js or node/examples/example.js

If you want to start using the library in an existing project, just do an npm install --save dota2. From then on you can require the library in your project.

if steam is listed in package.json, then npm install will install it.
On Thu, Jun 30, 2016 at 11:21 PM, Crazy-Duck<EMAIL_ADDRESS>wrote:

@chardzard https://github.com/chardzard can you list the exact steps
you've taken when you're trying to set up the example files? The correct
way to set things up to execute the example files is

install latest version of node js (either 4.4.7 or 6.2.2)
clone the repo
navigate to the repository root
npm install steam (not sure if this is still necessary, but it
can't hurt)
npm install
create a config.js file in the examples directory. You can see some
example contents in config.js.example
run either node examples/example.js or node/examples/example.js

If you want to start using the library in an existing project, just do an npm
install --save dota2. From then on you can require the library in your
project.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/RJacksonm1/node-dota2/issues/296#issuecomment-229863477,
or mute the thread
https://github.com/notifications/unsubscribe/AC_UONUrzMuD9fPMRtov3Dn-I3wtx8t9ks5qRLHzgaJpZM4I_Oca
.

There used to be an issue which required you to install steam separately as well. If this is no longer applicable, I'll remove that part from the README :)

Once upon a time, it was a peerDependency instead of a dependency:
https://github.com/RJacksonm1/node-dota2/commit/d9d5f956a52fa7dce842a414d667dac2a4d1c2d8#diff-b9cfc7f2cdf78a7f4b91a753d10865a2R9

Alright, I'll remove that from the README then next time I'm doing a pull

Stale issue, reopen if still relevant


The leaderboard is missing in https://paperswithcode.com/sota/qqp-on-qqp

Still there yet...

Still there yet...

Still there yet...


Unwanted file called "undefined" in the dowloaded files directory

Hi, Firstly, thank you for the amount of effort you spent to make jswget.
I want to download files with the possibility to resume interrupted downloads. Here is my code:
`
var dlPath = "E:/fic/";
var tabUrl = [];
tabUrl.push("http://localhost/images/Suneohair_-_Warutsu_Full_song.mp4");
for(var i in tabUrl){
var fileUrl = tabUrl[i];
var fileName = path.basename(fileUrl);
var dlPathUri = path.join(dlPath, fileName);
jswget({
	url: fileUrl,
	downloadas: fileName,
	downloadpath: dlPath,
	downloadmode: true,   //this mode creates automatically a file called "undefined"
	method: "GET",
	onsend: function(req, opt){
		console.log("Start");
	},
	onsuccess: function (resp, req, res){
		console.log("Done");
		},
	pipestream: fs.createWriteStream(dlPathUri, {flags: "w"})

	});

}`
The problem is that, the script creates a file called "undefined" in the downloaded files directory. That file seems to be some sort of accumulation of all downloaded files content. So if i download a file with 200ko, the undefined file will have at least 200ko. I don't know why it's there but i think it's for keeping file download progress. Please tell me if i'm wrong. Am'i doing something wrong or it's normal and i should delete it manually after each download. Thank you and please forgive my bad english.

I found the problem: the issue originates from  line 143, where you initialize configs.downloadas:
here is what is present in the version of jswget i got from Npm:
	configs.downloadas = (configs.downloadas===undefined)? ( (configs.downloadmode)? configs.path.split("/")[configs.path.split("/").length - 1]:configs.downloadas ):undefined;
So if i set downloadas to a file name for exemple, it is assigned undefined value with the line above. So when the file is created with createWriteStream at line 413. A file named "undefined" is created. And all downloaded files' content are appended to it.
Now i see that you corrected the mistake in Github, maybe you should update the version served by Npm also. Thanks


Operator CI installing old bats version

The operator CI lists bats as a test dependency (see install_test_deps.yml), which causes bats to be installed via apt. Unfortunately apt tracks an old version of bats, which does not match the one used in the kata CI and does not support the SEV tests. The kata CI uses a .ci/install_bats.sh script to install bats from upstream. Maybe we should do this in the operator CI as well?
cc @wainersm @ryansavino

@fitzthum what feature do you need that the old bats doesn't provide?

what feature do you need that the old bats doesn't provide?

setup_file and teardown_file, which allow you to execute code before any of the tests in a file have run and after all the tests in a file have run. We use this to setup and teardown the KBS among other things. This feature narrowly missed being in release 1.2.0. Focal only has 1.1.0.


Undefined is not an object (evaluating '_react2.PropTypes.number')

When I am running my app I am after adding circular slider getting this error

You have to add PropTypes library and import then into the files. React recently put prop-types into its own package.

Can you explain what you mean by this @JohnCoronel, I'm also getting this error and not really sure where to go from here.

@danstans see https://github.com/bartgryszko/react-native-circular-slider/pull/21. You can either edit the src files and update the imports or just fork.

still not solved

I fixed it by getting the package using yarn add prop-types --dev
and then editing the src files CircularSlider.js and ClockFace.js
to use import PropTypes from 'prop-types';  instead of the React imported PropTypes because they deprecated it in the newer releases. Hope this helps and I will make a PR to merge this in.
Thanks
Afshawn

Same issue. Any solution?

can this slider be used while developing app using expo? if yes then how? because I'm facing this error:
https://github.com/bartgryszko/react-native-circular-slider/issues/46


Change padding around expandable rows.

Fix #1424
Expandable rows in tables should have the same padding as expandable rows in data lists. Currently in tables, we use the columns from the above row to determine spacing around content, but this is not robust enough for products to use.
Fix: expandable rows by default have no padding i.e. if you want to include something that has its own padding / the nested table in compound expansion / or when there is no required padding.
using .pf-c-table__expandable-row-content as the child of .pf-c-table__expandable-row will apply the necessary spacing.

Deploy preview for pf-next ready!
Built with commit 8888775f2eb909bacf323c743e3834e85c549a83
https://deploy-preview-1447--pf-next.netlify.com

Do you think it's worth adding a default padding or margin to the expandable row that accounts for the expanded left border-width?

Can you update the other expandable example that isn't expanded? I wonder if that example should be expanded and not include the expandable content wrapping element?

Thanks @mcoker !! Agree with your last two comments so made those updates


Add a .editorconfig

I noticed some of the files had weird quirks:

white spaces at the end of lines
missing newline at the end of files

editorconfig is a unified config format for editors to stop fighting over tiny details like that. This configuration is pretty conservative:

4 spaces because that's mostly the default for rust
spaces instead of tabs because editors still can't agree on how wide a tab is
insert a final newline because some editors will do it anyway
remove trailing white spaces because these serve no purpose anyway

It applies to all text files in the repository, which should bring a bit more consistency overall (these settings also don't conflict with rustfmt)

I think I would prefer rustfmt to be the "one true way" to format code. Adding more things to the mix just complicates the system and makes it harder to reason about. What we really need is rustfmt checks to be enabled in CI so we're always clean.

Good point, superseded by #201


Missing var declaration in function nodeLinkFn

Minor fix possibly needed for the nodeLinkFn function of Angular v1.4.8. It appears that the "i" variable is not declared in this function, and thus is actually the same as declared in the applyDirectivesToNode function closure (ref. the "for" statement at line 7961). In other words, the "i" variable at line 8312 of the "Prelinking" code, and line 8333 of the "Postlinking code in nodeLinkFn, is the same variable as line 7961.
It doesn't seem to be a problem, as they are reset to new values in nodeLinkFn, but with so much going on in the applyDirectivesToNode function, it does raise the possibility that someday it might come back to haunt.

Thanks for reporting this!


chore: auto add pull requests to project board

Closes: #XXX
What is the purpose of the change
This change introduces a GitHub action to automatically add pull requests to the project board.
There was no existing library available that worked well with "Projects beta" so I created jobs with going graphql queries to GitHub API.
Successful run: https://github.com/osmosis-labs/osmosis/runs/6345603614?check_suite_focus=true
Testing and Verifying
(Please pick one of the following options)
This change is a trivial rework/code cleanup without any test coverage.
Queries can be tested in GitHub Graphql Explorer: https://docs.github.com/en/graphql/overview/explorer
Documentation and Release Note

Does this pull request introduce a new feature or user-facing behavior changes? no
Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md?  no
How is the feature or change documented? not applicable

Codecov Report

Merging #1454 (85c023e) into main (f56fbe5) will decrease coverage by 0.42%.
The diff coverage is 16.39%.

@@            Coverage Diff             @@
##             main    #1454      +/-   ##
==========================================
- Coverage   19.82%   19.40%   -0.43%
==========================================
  Files         202      229      +27
  Lines       27685    31452    +3767
==========================================
+ Hits         5489     6102     +613
- Misses      21175    24237    +3062
- Partials     1021     1113      +92

Impacted Files
Coverage Δ

x/epochs/client/cli/query.go
0.00% <ø> (ø)

x/gamm/client/cli/query.go
36.74% <0.00%> (-0.36%)
:arrow_down:

x/gamm/pool-models/stableswap/msgs.go
0.00% <0.00%> (ø)

x/gamm/pool-models/stableswap/pool.go
0.00% <0.00%> (ø)

x/gamm/pool-models/stableswap/stableswap_pool.go
0.00% <0.00%> (ø)

.../gamm/pool-models/stableswap/stableswap_pool.pb.go
0.58% <0.00%> (-0.09%)
:arrow_down:

x/gamm/types/pool.go
0.00% <ø> (ø)

x/incentives/client/cli/query.go
0.00% <ø> (ø)

x/incentives/keeper/distribute.go
61.00% <0.00%> (ø)

x/incentives/keeper/hooks.go
50.00% <0.00%> (ø)

... and 52 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fd7e7e...85c023e. Read the comment docs.

Once reviewed, it goes back into "In progress" status: https://github.com/orgs/osmosis-labs/projects/1/workflows/267854
Once merged, it gets closed and moves to the "Done" status

Technically, we could add another status like "Approved". However, issues and pull requests share the same statuses so it wouldn't make sense for issues.
I don't think not having an "Approved" status is a big problem for our team. Seems that all PR authors have been keeping track of their PRs and merge them, once approved.

Yeah we definitely don't need a separate workflow to track "Approved"! Thanks for the explanation!

@p0mvn seems like some PRs trigger this ci run, some don't, (ex. https://github.com/osmosis-labs/osmosis/pull/1457 has this ci running, https://github.com/osmosis-labs/osmosis/pull/1456 wasn't) on what circumstances do they run?


Create public-health-and-safety.md

This metric is ready for release :tada:
cc @joshsimmons

I'm gonna go ahead and merge this so we can go forward with adding these to the DEI Badging Application :+1:


add: Period to range

Change period automatically to range if you call setRange( )

I think this make sense, because default period is day and if you set a range, the period only can have the parameter range.

Hey, why did you delete your branch?

Because it was a mistake, you can make all period variants with range.


Project Setup

Find external API task #20
Choose assets task #19
Set up the project with Webpack and Jest- group task #18
Add header - group task #17
Add footer - group task #16

STATUS: APPROVED 🟢
Hi @jellywiz
Your project is complete!  There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉
To Highlight 🎉

No linter errors. :heavy_check_mark:
GitHub flow is followed. :heavy_check_mark:
Professional README file. :heavy_check_mark:
PR has a good title and summary. ✔
Project is well setup. :heavy_check_mark:

Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.


[Bug] App Crash: NullPointerException

Device: SM-S906E (samsung - g0q), SDK: 33 (13), App: 2.4.2 (97)
java.lang.NullPointerException
	at cd.l.w(SourceFile:1)
	at eb.a.u(SourceFile:1)
	at ac.b2.q(SourceFile:54)
	at ac.a.u(SourceFile:23)
	at eb.a.u(SourceFile:1)
	at fc.v.q(SourceFile:1)
	at ac.a.u(SourceFile:23)
	at eb.a.u(SourceFile:1)
	at ac.f0.run(SourceFile:1)
	at a9.j.run(SourceFile:277)
	at gc.i.run(SourceFile:1)
	at gc.a.run(SourceFile:94)
	Suppressed: fc.h: [s1{Cancelling}@6b4e9f1, Dispatchers.Main.immediate]

How to reproduce?

i hope that i fixed


xSPWorkManagement

I can only hope we don't have the user profile sync conn files in this one, despite most commits been somehow related to it

too much included in the PR, will start again


Multiple taskbar buttons for multi windows

Is your feature request related to a problem? Please describe.
When I open multiple windows (floating windows) in DBeaver, they share one button in the taskbar. When I click on that button, it will show any DBeaver window randomly. I can't select which window to show.
Describe the solution you'd like
Make each floating window to have a separate button in the taskbar, so they are selectable.
I'm using Windows 10.

Please clarify which button are you talking about

It's the button in the windows taskbar, as shown in the screenshot.

What is floating window? If you're talking about modal windows inside the application, then I'm not sure we can do it. The modal window always has parent, so when you open the parent window, you should see the modal one.
DBeaver is based on Eclipse platform. And Eclipse has the same behavior with modal windows on Windows 10.

I don't know modal window. But here is what I want. As you can see I have two windows opened in two monitors. But there are only one button(icon) in the taskbar. Any way to make each window a unique button?

Have you tried opening new window with this button?

If I use it, I have more than one windows in the taskbar

Oh I didn't know that. Thank you! It works. But one more problem. I can't drag tabs between the two windows. Any way to do that?

I think there is no way to drag-n-drop tabs between different windows


Static shortcurt shows toast "App isn't installed."

I have tested the application on an emulator with API 25. When I press the static shortcut "Add a new website", a toast is shown by the System : "App isn't installed."

How to solve this problem ？

This is described in here: https://github.com/googlesamples/android-AppShortcuts/issues/2
"the solution would be to replace the android:targetPackage with the applicationId from build.gradle and android:targetClass should have the full package name with the class name that is different from applicationId"

thank you

@TheHighriser  Still not working!


For pr

I use your code and try to make a firebase storage  version.
but I think the original source get too heavy.
so I make a src/storage/BotStorage.ts form DynamoBotStorage.ts
and I make a  src/storage/FirebaseBotStorage.ts  extends BotStorage
and write firebase getDataFunction and saveDataFunction in  src/storage/FirebaseBotStorage.ts
and this can work well.
and I think this constructer  well be more easy to maintain and use in other database.
how do think?

I think you should publish your own npm package for now. I would like to keep the code as consistent as possible. I will review the Firebase api and maybe create a separate adapter later.


Update from r1050 to r1051

Add VBITS info to output.
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

If there is an update to this pull request do I create a new pull request or make changes to this one?
See my edits here: https://github.com/NixOS/nixpkgs/pull/318125/commits/e71dd6a296cad2830769057b893c64122a41e6a9

You may force-push the update, or stack bump commits. Generally we prefer the first one

I helped you rebase and also updated it to the latest revision :)

@JohnAZoidberg 1a12a2d879cf694ee487c8ce76317a50b0203e1a doesn't follow the nixpkgs commit message schema. It is okay to make mistakes, but please be more mindful going forward :)

Ah sorry, because j just amended the original commit, I didn't notice the beginning part was wrong


Extension issue

Issue Type: Bug
Extension Name: vscode-pull-request-github
Extension Version: 0.32.0
OS Version: Windows_NT x64 10.0.19042
VS Code version: 1.62.1

:warning: We have written the needed data into your clipboard. Please paste! :warning:

{
	"messages": [
		{
			"type": 2,
			"message": "`remoteHub/pullRequest` is not a valid menu identifier",
			"extensionId": {
				"value": "GitHub.vscode-pull-request-github",
				"_lower": "github.vscode-pull-request-github"
			},
			"extensionPointId": "menus"
		}
	],
	"activationTimes": {
		"codeLoadingTime": 354,
		"activateCallTime": 1,
		"activateResolvedTime": 4983,
		"activationReason": {
			"startup": true,
			"extensionId": {
				"value": "GitHub.vscode-pull-request-github",
				"_lower": "github.vscode-pull-request-github"
			},
			"activationEvent": "*"
		}
	},
	"runtimeErrors": [],
	"runningLocation": 1
}


How do I use createSubscription?

Hi, thanks for making this!
There are zero examples or docs other than the readme, and after quite a bit of fiddling around I still can't get subscription updates to display in real-time.
Now this might also be an issue with my backend or my understanding of subscriptions (or both), but I'd like to make sure I'm not doing something wrong here.
Here's my demo component, to render it I'm using a Provider with a properly set-up Client (using subscriptions-transport-ws and this adapter for absinthe).
I'd expect result.data to have a meaningful value eventually, but it's always undefined.
const vodsSub = `
  subscription VodAdded {
    vodAdded {
      id
      title
    }
  }
`;

const VodsList: Component = () => {
    function handleSubscription(vods = [], response: any) {
        console.log(response)
        return [response.newVods, ...vods];
    };

    const [result, _executeSubscription] = createSubscription({query: vodsSub}, handleSubscription)
    // What do I do with executeSubscription?
    return (
        <Show when={result.data} fallback={
Loading...
}>

                {result
                    .data
                    ?.map(({ title, id }: any) => (
{title}: {id}
))}

        </Show>
    )
}

The names for the gql stuff should be correct, since GraphiQL auto-completes them, which means at least the server knows about the subscription, what a vod is etc.
Sorry if this isn't the most informative issue description, I can add more info if it's needed.
EDIT: I found an alternative solution for connecting my backend to my frontend and now I can subscribe to mutations from GraphiQL just fine, everything works as expected.
The only thing I'm struggling with ATM is doing the same from solid-urql so any help with that would be appreciated.
EDIT 2: after some more digging around I found out that absinthe might have its own addon for GraphiQL that handles subscriptions so the previous edit is possibly incorrect.
Final edit (I hope): after close examination of phoenix and absinthe's log output I think that the browser<->server communication works for the subscription (I can see a subscription being registered on the elixir side with the parameters I gave it on the solid side).
So yeah, a quick subscription example with solid-urql would be great.
Sorry for the wall of text, it's been a learning journey for me :)

ping

Sadly I don't think I had completed subscription support 100% yet.
And I don't know when I'll get a chance to work on this as I'm preparing to fligh back to Aus, but I  am more than happy to accept PR's if anyone wants to take a shot. I think I started work on it but never finished completely with the subscriptions.

@trusktr Sounds like you are not going to finish this port ... is that correct ?

Did a PR #4 for the most basic use case


[Package scanner] package flagged as investigate

This package was flagged as investigate in the package scanner:
https://community.chocolatey.org/packages/axtraxng/<IP_ADDRESS>
I don't understand why. It includes one embedded archive, and no downloaded files (and no urls in the install script).
So, it is under the 200mb limit, and I don't understand how one embedded file could mean an incorrect number of files was scanned.

This is just an assumption on my part,
but the failure could be because of the multiple calls to the Install- helpers.
Most likely, it ended up with a number of found binary files that did not match the expected number of files specified in the install script.
Since there are six calls to one of the Install- helpers, it expected to have 6 binary files to verify, but it did not (because 2 of those calls are hidden behind a package parameter).
However, these are all just my assumption and I can not say anything with a 100% certainty.

What @AdmiringWorm said is the most likely reason.


Do not receive correct or exact Geo Point on long press with MapEventsReceiver implementation.

Please note: issues related to or caused by osmbonuspack will be closed with a
suggestion to open an issue at https://github.com/MKergall/osmbonuspack
(feel free to delete whatever doesn't apply)
Issue Type
[ ] Question
[ ] Bug
[ ] Improvement
[ ] Build system related
[ ] Performance
[ ] Documentation
Description and/or steps/code to reproduce the problem
Environment
If it's a bug, version(s) of android this affects:
All
Version of osmdroid the issue relates to:
6.1.2

going to need some more context on this...


fix: QBO - Tag status does not change when 'Members must tag all expenses' is updated offline.

Details

Fixed Issues
$ https://github.com/Expensify/App/issues/43754
PROPOSAL: https://github.com/Expensify/App/issues/43754#issuecomment-2168222966
Tests

Workspace is connected to QBO.

Go offline.
Go to workspace settings > Tags.
Click Settings.
Toggle on "Members must tag all expenses".
Close the RHP.
Verify that "Classes" and "Customers/Projects" are labelled with "Required" when "Members must tag all expenses" is enabled and vice versa.

[x] Verify that no errors appear in the JS console

Offline tests

Workspace is connected to QBO.

Go offline.
Go to workspace settings > Tags.
Click Settings.
Toggle on "Members must tag all expenses".
Close the RHP.
Verify that "Classes" and "Customers/Projects" are labelled with "Required" when "Members must tag all expenses" is enabled and vice versa.

QA Steps

Workspace is connected to QBO.

Go offline.
Go to workspace settings > Tags.
Click Settings.
Toggle on "Members must tag all expenses".
Close the RHP.
Verify that "Classes" and "Customers/Projects" are labelled with "Required" when "Members must tag all expenses" is enabled and vice versa.

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
https://github.com/Expensify/App/assets/85894871/84c050a9-b0a1-41d2-828e-c8b437c3fb5c

Android: mWeb Chrome
https://github.com/Expensify/App/assets/85894871/39794752-e379-4755-9561-0e427501511e

iOS: Native
https://github.com/Expensify/App/assets/85894871/d52646ad-02b9-4abd-b54d-ae4380cda219

iOS: mWeb Safari
https://github.com/Expensify/App/assets/85894871/6cf07d00-1931-436b-87d3-cd2a7be70a12

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/85894871/a55ad1c6-9613-48df-b8f6-6ff5523ac42e

MacOS: Desktop
https://github.com/Expensify/App/assets/85894871/207a65d0-6506-4dd8-9a23-4afd957a2f78

@Ollyws whats is your ETA for this PR review? do you think you can get this done today?

@Ollyws how is this looking

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.7-3 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Cherry-picked to staging by https://github.com/thienlnam in version: 9.0.7-4 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.7-8 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/mountiny in version: 9.0.8-6 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


islocal() method of Application is missing in Contract

Laravel Version: 5.8
PHP Version: 7.2
Database Driver & Version: mysql 5.7

Description:
Hello,
there is a isLocal() method in the Application class,
but there is no such method in the Application contract.
The use of the islocal() method is advised in the documentation,
for loading dev providers, and i think it the interface should declare it,
if it's meant to be publicly used.
thanks.

Hey there,
Not all methods of the application instance are available on the contract because they'd provide little use to implementations outside the framework itself. In any case this like a feature request or an improvement. It's best to post these at the laravel/ideas repository to get support for your idea. After that you may send a PR to the framework. Please only use this issue tracker to report bugs and issues with the framework.
Thanks!

It's a bad practice to use a method if it's not part of the contract,
it means that instances are not swappable anymore.

Actually, I believe that the real culprit here is the application contract since it provides no value at all. A framework in general should not be swappable by a framework created contract. In any case this is something that's best discussed in the laravel/ideas repo.

Plus the method isn't used anywhere in the framework. Any additional methods used should be added to your implementation. IMO, a contract should cover what is needed for an implementation to work out-of-the-box. It shouldn't cover every possible method that could ever be used.
However, like Dries mentioned, the Application contract doesn't make much sense anyway.


Convert all remaining Universal APIs to net/http and remove UniversalFastHTTPAdapter

This is a follow-up from #6461 which completes the conversion of all Universal APIs to net/http, allowing us to remove one of the adapters (UniversalFastHTTPAdapter) entirely

This impact workflow APIs and the Query State API, which were already Universal APIs but were still using the UniversalFastHTTPAdapter.
Additionally, this PR deletes the utils/fasthttpadaptor package, which was already unused.
There are no feature changes, just hundreds of lines of code deleted.

/test-sdk-all

/ok-to-test

/ok-to-test

/test-sdk-all


Convert ReinforcedWallVisualizer to ECS

part of #8995

Now it builds.
Will look at GenericVisualizerSystem and see how/if I can reasonably apply it to this and more of these
small refactors.

Reading the docs+source and trying to wrap my head around yaml-AppearanceChangeEvent-AppearanceData-components-enums and the sprite layers and states system.

Figured it out (mostly).
Appears to work in game.
I'll start doing this to other Visualizers where I can.
Should be ready to merge unless I messed up!


Introduce support of cockpit build

DomF: Introduce support of cockpit build
aos-rcar-gen3.yaml
-Add support the dedicated config files for update manager of domf.
The variable AOS_DOMF_UM_CONFIG is intriduced to change the configuration file.
By default, value is 'aos_updatemanager.cfg', but if parameter SUPPORT_COCKPIT is yes,
the variable is changed to aos_cockpit_updatemanager.cfg to satisfy the requirements of
the product meta-xt-prod-cockpit-rcar.
-Parameter SUPPORT_COCKPIT, allows enable build for cockpit.
Default parameter is 'no'. If parameters is yes, the value of AOS_DOMF_UM_CONFIG is
changed at 'aos_cockpit_updatemanager.cfg'
-Parameter ENABLE_SSH_UPDATE allows to add sshmodule for update via ssh protocol.
Default value is 'no'.
aos-updatemanager_git
-Support of AOS_DOMF_UM_CONFIG.
-Add cockpit name in the etc/hosts
doc/cockpit_boardconfig.json
-aos_updatemanager configuration file to support cockpit. Use this file
to configure the cloud.
Signed-off-by: Ihor Usyk<EMAIL_ADDRESS>

Outdated


Hardcoded strings

Several strings are hardcoded and cannot be translated, e.g. https://github.com/92lleo/WhatsappWebToGo/blob/master/app/src/main/java/io/kuenzler/whatsappwebtogo/WebviewActivity.java#L654

thanks for the hint, will include those in the next release


feat(anvil): add eth_getBlocksByArray

Motivation

Adds RPC method as mentioned in #2405.
Solution

registers eth_getBlocksByArray request in anvil/core/src/eth/mod.rs
adds lenient_block_number_array to parse block number array in anvil/core/src/eth/serde_helpers.rs.
adds blocks_by_array that fetches full blocks serially atm.

TODO

[ ] Look into fetching the blocks in parallel. Tried to follow rust docs, still confused how it can be done in a Promise.all kind of fashion.
[ ] Include logs if needed

I'd prefer we let this happen via Batch RPC, unless there's strong motivation to include it natively?

This PR trivially batches getBlockByNumber RPC, which I agree does not make sense to have a separate method for it since one can batch requests. But just to highlight that @sambacha was proposing something more complex than this PR's changes https://github.com/foundry-rs/foundry/issues/2405#issuecomment-1191452483. Does that add value to general users if implemented @sambacha? Otherwise, I'm happy to close this PR.

Dont listen to me listen to @gakonst
Thanks for the effort, whatever is less onerous wrt maintenance as its identical in results is good with me

thank you sirs


Show one collapsible at a time

First of all thank you so much to all the maintainers and contributors for such an awesome package.
I wanted to ask if there is any way to show one collapsible at a time?

@haresh6x check this issue - https://github.com/roginfarrer/react-collapsed/issues/87


Middleware on route doesn't work.

Hi I am using following code below:
$api->group(['middleware' => 'api.auth'],function ($api){
        $api->get('users','LaterPosts\Api\Controllers\UserController@getUser');
    });

and when I see list for api:routes I see below
https://infinit.io/_/Z9rU83y
Although middleware works when added using constructor in controller.

Fixed. Thanks for the report.

@jasonlewis After updating the package. Now I get following below:
"call_user_func_array() expects parameter 1 to be a valid callback, class 'Dingo\Api\Auth\Auth' does not have a method 'handle'"

See #903.


Exception handler in MVC hits injection/context trouble

In general, the problem is that the handler doesn't find @Context-injected objects: JAX-RS attempts to inject them, but it fails during resolution. They are also oddly unavailable when using the Krazo-provided @Inject mechanism.

It's possible that this comes from PostMatchingRequestFIlter maybe not running - which could in turn be from its @Controller-ness not being picked up due to classpath scanning in OSGi.

Hmm, that's not quite it - though that does indeed seem like it's not being called (as a similarly-configured filter isn't), it's not due to that classpath scan: it looks for @Path, not @Controller.


Events parser

Coverage decreased (-9.91%) to 75.0% when pulling e0109e2525446a4f046e618d4d0c39547a535c2f on events-parser into cf18d18e159fb8b38f176974b173bc343aedbe71 on master.

Coverage remained the same at 84.91% when pulling 8ca6360bb4d0c60bed83e820da882801481f7b31 on events-parser into cf18d18e159fb8b38f176974b173bc343aedbe71 on master.


External Documentation

Should host external documentation, perhaps using the readthedocs style.
AC:

Reformat docstrings / ensure they exist

In the meantime, we can make a docs directory with markdown files explaining each aspect of the package in depth.


Bezier-rs: Add Euclidean parameterization to Bezier::evaluate

Add enum to determine whether evaluate will use parametric or euclidean interpretation of the passed parameter
Implement euclidean logic for evaluate
Add toggle for switching between the two in the UI
Update styling of the UI

I understand that for subpaths, it would make sense that we'd want to differentiate between parametric t vs eucliean t, but I'm not sure what the use case for having a euclidean t for bezier curves would be. Not sure what the best solution would be, but I thought that the bezier library would use only parametric t and the subpath library would do extra calculations to accomodate parametric t and euclidean t.

I understand that for subpaths, it would make sense that we'd want to differentiate between parametric t vs eucliean t, but I'm not sure what the use case for having a euclidean t for bezier curves would be.

@Androxium I could be mistaken, but I remember discussing with @Keavon who mentioned that he felt that this would be useful. Regardless, I don't think its a bad idea for the library to exhibit consistency between the interfaces.

I might need to wait until Tuesday or Wednesday to finish reviewing this.


Store settings and last rain trigger data in EEPROM so it remains over reboots

When the D1 Mini looses power and reboots, it reverts back to the default settings. The settings should be saved in the EEPROM, along with the last rain data data.

Only ESP32 does not have EEPROM support, so this can only be enabled for ESP8266


Document -j used

The time results differ significantly based on the amount of cores. It’d be good to document the number of cores used, or split cpu and wallclock times.

Yes, I want to capture that along with system specs. I just haven't taken the time to collect that information in python yet
(I also consider it a bug in the Rust ecosystem that I reached for Python :) )

btw you can look at the raw run results which includes user/system which gives a sense of things.


Apply DeMorgan's rule to not filters

I noticed that while the unary ! operator worked correctly in sbt, the
toString looked wrong because NotPathFilter toString was defined as:
override def toString: String = !filter
When the filter was an || filter, this turned into something like
!DirectoryFilter || HiddenFileFilter
which was confusing because it actually represented
!(DirectoryFilter || HiddenFileFilter)
When I thought about it, I realized it would be nicer to just apply
DeMorgan's rules in the NotFilter. The filter then becomes:
!DirectoryFilter && !HiddenFileFilter
which I think is easier to read anyway.

To validate this pull request against other sbt modules, please visit this link.


Bump version to 1.4.0

Description
Test
e2e tests and manually performed with 1.4.0-rc1 and the new functionalities of yet unreleased verify-image-signatures.
Additional Information
Tradeoff

Potential improvement

charts are released and passed e2e tests, moving to release kwctl

tagged 1.4.0 in main.


Add LICENSE-* files to subcrates

Changed

Add LICENSE-* files to renderdoc-sys subcrate.
Update copyright year in LICENSE-MIT files.

Closes #121.

The CI errors should be safe to ignore. Let's see if we can switch over to GitHub Actions for CI sometime down the road.


Allow keybinding configuration

Hey, really nice tool you have here.
I run openbox w/ arch linux, and the Alt modifier is reserved for resizing and moving windows for me, so voxie never gets that input.
For anyone who encounters this same issue, I made a patch here that remaps it to the Meta modifier key.
https://gist.github.com/josefnpat/25c12b9391533fcab0fd
What would be awesome is some way to configure the keybindings!
Thanks, and have a nice day!

Right, I didn't consider that at all!
I would happily accept a pull request for a keybinding config system, but it's not something I have time for right now, sorry :(

I totally understand :)
I would supply a pull request, but I do not really know enough Qt to do it justice.
Thanks for responding!


can_apply_benefit return wrong data when use apply offer for product child

Issue Summary
When there are product discountable true and variant discountable false in cart in the same time, discount is calculated for variant which is incorrect.
Steps to Reproduce

Product A (discountable=true)
Variant B (discountable=false)
Set an offer X with range that included Product A and Variant B

Issue
When Product A and Variant B are in the same cart, discount from offer X is calculated for both lines which is incorrect.
Relevant code
oscar/app/offer/abstract_models.py

def can_apply_benefit(self, line):
        """
        Determines whether the benefit can be applied to a given basket line
        """

Found in version
c49a21979

Original report: https://github.com/django-oscar/django-oscar/issues/4070


Request to update formulations.

I find the following formulation in Security Administrator role description a bit misleading: "Users with this role have all of the read-only permissions of the Security reader role, plus the ability to manage configuration for security-related services: Azure Active Directory Identity Protection, Azure Information Protection, Privileged Identity Management"
The word 'manage' makes one think that Security Administrator role allows full management of PIM. But below you see the following: "All permissions of the Security Reader role; Cannot manage Azure AD role memberships or settings."
And Security Reader does not provide ability to manage PIM, just read the policies.
Could you please update the description of Security Administrator role so that it does not give impression that this role provides ability to fully manage PIM policies?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0767aac4-fcd9-eaac-2c30-8f17d8eadd92
Version Independent ID: a380a828-03f9-e037-3a62-e4165fda7cb6
Content: Assigning administrator roles in Azure Active Directory
Content Source: articles/active-directory/users-groups-roles/directory-assign-admin-roles.md
Service: active-directory
GitHub Login: @curtand
Microsoft Alias: curtand

Thanks for your feedback! We will investigate and update as appropriate.

@MarileeTurscak-MSFT
This is mine, Marilee.
@curtand

@MarileeTurscak-MSFT
Thanks! Should be able to fix this fast.

Hi @IgorRogDevPro
In the first sentence you cite above, beginning "Users with this role have all of the read-only permissions of the Security reader role, plus the ability to manage configuration for...", I removed PIM. The rest seems correct. I'll update when this is published, and close.
@MarileeTurscak-MSFT

Hello,
Thanks for a prompt reaction!
Regards,

Igor Rog
DevOps | Dev-Pro.net
Phone: +1<PHONE_NUMBER>
Mobile: +380 (50) 777-5810
Skype: dev-pro.igor.rog
On Thu, Sep 6, 2018 at 9:48 PM Curtis Love<EMAIL_ADDRESS>wrote:

Hi @IgorRogDevPro https://github.com/IgorRogDevPro
In the first sentence you cite above, beginning "Users with this role have
all of the read-only permissions of the Security reader role, plus the
ability to manage configuration for...", I removed PIM. The rest seems
correct. I'll update when this is published, and close.
@MarileeTurscak-MSFT https://github.com/MarileeTurscak-MSFT
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/azure-docs/issues/14455#issuecomment-419201903,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AdBgYsMe4cOXNPzRktYFAu6tNRMk-pf4ks5uYW4KgaJpZM4WYhtK
.

@IgorRogDevPro We will now close this issue. If there are further questions regarding this matter, please reply to @femsulu and we will gladly continue the discussion.


Hack around undefined use after free

This has been flaky lately.

Still not working. I don't think this is a valid test.

Coverage remained the same at 99.323% when pulling e4b5daf5250edc774556a464f1e418329bc75d66 on thetic:use-after-free into c02ec75af97a536e34dd47fd7453abbcb095213a on cpputest:master.

#1725


Integration tests are failing on master branch

Integration tests are failing because of missing binary in the test image.
CLI tests are also failing for some reason.
Here is an excerpt of the build travis build https://travis-ci.org/appcelerator/amp/builds/181707477 :
ok  	github.com/appcelerator/amp/tests/integration/data/influx	0.015s
ok  	github.com/appcelerator/amp/tests/integration/data/storage/etcd	1.137s
# github.com/appcelerator/amp/vendor/github.com/docker/docker/pkg/term
exec: "gcc": executable file not found in $PATH
# github.com/appcelerator/amp/vendor/github.com/docker/docker/vendor/github.com/opencontainers/runc/libcontainer/system
exec: "gcc": executable file not found in $PATH
FAIL	github.com/appcelerator/amp/tests/integration/rpc [build failed]
make: *** [test-integration-host] Error 2
Makefile:200: recipe for target 'test-integration-host' failed
--- FAIL: TestCmds (10.45s)
	cli_test.go:65: -----------------------------------------------------------------------------------------
	cli_test.go:67: Running spec: samples/logs.yml
	cli_test.go:67: Running spec: samples/service.yml
	cli_test.go:67: Running spec: samples/stack.yml
	cli_test.go:67: Running spec: samples/stats.yml
	cli_test.go:120: Running: amp service create appcelerator/pinger --name pingerABHmUnLUtm -p www:55915:3000
	cli_test.go:120: Running: docker service ls
	cli_test.go:120: Running: curl localhost:55915/ping
	cli_test.go:133: Mismatched expected output:   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
		                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0curl: (7) Failed to connect to localhost port 55915: Connection refused
		 : Error: exit status 7
	cli_test.go:120: Running: amp stack up stack1yZouCyQgUP -f ../../api/rpc/stack/test_samples/sample-01.yml
	cli_test.go:120: Running: amp logs
	cli_test.go:120: Running: amp stats --container
	cli_test.go:120: Running: amp stack ls
	cli_test.go:120: Running: amp stack stop stack1yZouCyQgUP
	cli_test.go:120: Running: amp logs -m
	cli_test.go:120: Running: amp stats --cpu
	cli_test.go:133: Mismatched expected output: Error during: amp stats, reason: rpc error: code = 13 desc = transport is closing
		 : Error: exit status 1
	cli_test.go:154: Mismatched expected output: Error during: amp stats, reason: rpc error: code = 13 desc = transport is closing
		 : Error: exit status 1
	cli_test.go:155:
	cli_test.go:120: Running: amp logs -n 10
	cli_test.go:120: Running: amp stack ls
	cli_test.go:133: Mismatched expected output: Error during: amp ls, reason: rpc error: code = 13 desc = transport is closing
		 : Error: exit status 1
	cli_test.go:154: Mismatched expected output: Error during: amp ls, reason: rpc error: code = 13 desc = transport is closing
		 : Error: exit status 1
	cli_test.go:155:
	cli_test.go:120: Running: curl localhost:55915/ping
	context.go:22: Deadline exceeded: amp stats
	context.go:22: Deadline exceeded: amp stack ls
	context.go:22: Deadline exceeded: amp logs
	context.go:22: Deadline exceeded: amp service rm
	cli_test.go:120: Running: amp service rm pingerABHmUnLUtm
	cli_test.go:120: Running: docker service ls
	cli_test.go:120: Running: amp logs --stack stack1
	cli_test.go:71: -----------------------------------------------------------------------------------------
	cli_test.go:72: Finished!
FAIL
FAIL	github.com/appcelerator/amp/tests/cli	10.453s
make: *** [test-cli] Error 1
The command "make test" exited with 2.
Done. Your build exited with 1.

After running make test on the master, I get the following return. The cli tests consistently pass and they very rarely fail. I can replicate the issue you are having.
ok      github.com/appcelerator/amp/tests/integration/data/influx       0.009s
ok      github.com/appcelerator/amp/tests/integration/data/storage/etcd 1.295s
# github.com/appcelerator/amp/vendor/github.com/docker/docker/pkg/term
exec: "gcc": executable file not found in $PATH
# github.com/appcelerator/amp/vendor/github.com/docker/docker/vendor/github.com/opencontainers/runc/libcontainer/system
exec: "gcc": executable file not found in $PATH
FAIL    github.com/appcelerator/amp/tests/integration/rpc [build failed]
Makefile:200: recipe for target 'test-integration-host' failed
make: *** [test-integration-host] Error 2
ok      github.com/appcelerator/amp/tests/cli   7.594s

After adding the changes from PR #525, make testwill pass.
ok      github.com/appcelerator/amp/tests/integration/data/influx       0.016s
ok      github.com/appcelerator/amp/tests/integration/data/storage/etcd 1.286s
ok      github.com/appcelerator/amp/tests/integration/rpc       37.214s
ok      github.com/appcelerator/amp/tests/cli   6.309s

As suggested in your message, I will work on making the cli_test.go logs less chatty and make any errors that occur easier to identify and diagnose, along with making the command timeouts more forgiving.

@JosephGJ you're right, the PR #525 fixes the gcc issue. However, when I was working on this PR, the CLI tests kept failing on travis.
This is mostly a travis CI issue as CLI tests are working most of the time locally.
If you look at the fix-integration-tests branch build history on travis here: https://travis-ci.org/appcelerator/amp/branches, you will see that tests never passed despite several attempts.
In the end, I closed this PR, do you want me to reopen it so that you can work on it or do you want to work on your own PR ?
Just let me know

Betrand, you can reopen the PR and I'll work on the Cli changes that I've mentioned above on said PR.
I rebuilt the travis build and it passed, however, I think this rpc error: code = 13 desc = transport is closing error is worth looking into.
The cli tests can be somewhat random as described because of the commands that are being tested are unstable, and being able to identify this is primary purpose of these tests.

Ok, thanks!
You're right, maybe there's a real issue lurking, it would be great to be able to reproduce the issue in a deterministic way in order to fix it.

The error you've been experiencing bertrand has persisted even with the minor changes. You can see this referenced in #529.
I think the issue is that amplifier is crashing during the execution of make test. Taking a look at the amplifier logs may show us the source of the problem.


feat(api-client): add the button to API client

Integration isn't wired up in the client but should be trivial. Also need to decide when to show it

There's some rebase shennanigans going on here so I will make a new PR with hans' changes

closing in favour of https://github.com/scalar/scalar/pull/3653


suggestion/feature request: Redstone signal strength needs to be displayed.

In WTHIT redstone signal strength is displayed on the block info display. This feature needs to be added before it can really start to replace WTHIT.
Otherwise fantastic mod. Keep up the great work.

well this mod is not intended to replace anything, but I'll try :)

Hah sorry, projected some of my thoughts about it onto the request.
Thanks for the consideration though!


Status call not working // devId 22 char long?

hey i grabbed the devid over bluestacks and the recommended eufy app version.
The weird thing is, that the devId has a total length of 22 instead of 20.
I also tried it with the given devId and localKey but the response of the tool was:

I have the same issue, my device id is 20 chars long though.

I have the same issue with a 20 char device id, however 3 or 4 attempts it works.


do not zoom if marker was dragged

The current behaviour is pretty annoying and so I disabled this, in this PR.
(not sure if this is the proper way to do this or if we should have the zoom parameter e.g. in SetPoint)
Related to #177

Cool, thanks! This fixed #163, right? Makes drawing markers a lot more enjoyable for sure :)
Putting the zoom parameter into SetPoint makes sense to me. The only thing I was wondering is if the QueryStoreState and the RoutingArgs are the right place for the zoom parameter, because it is only related to our UI code and not the routing request. I mean I can see how it works this way and maybe it's not too important, but it seems a bit odd, so I was wondering if there was another way to do this?

The only thing I was wondering is if the QueryStoreState and the RoutingArgs are the right place for the zoom parameter

I had the same thought, but then I didn't have another idea quickly. Since we all don't feel good about this we could think of a better way to do this, or at least remember it for the next UI related property and do it then.

Ok, good idea. I added a todo comment here: e95f88eb45b2846fed3e24dfd734e19fce2bd666
The zoom property is like a parameter that describes the UI parameter, but then it is also only 'valid' for a specific request: When dragging the marker it is set to false for the next request, but when we type two cities in the query boxes directly it should be true for the next request...


[Bug]:  Table's variant relaxed and normal

Describe the bug
The variant relaxed and normal make no difference.

They are no different, regarding about the padding in the table cell.
Definition of "variant"
variant: A relaxed variant of the table with more vertical padding for the cells
Provide Code
No response
To Reproduce
https://deploy-preview-27--abgov-ui-component-docs.netlify.app/components/table
Sandbox, when changing the variant property, makes no difference.
Relevant console log output
No response
What browsers are you seeing the problem on?
No response
Additional context
No response

@vanessatran-ddi it looks like we can get both normal and relaxed table variants to display in storybook. Does that mean that this could be sandbox issue?

The CSS selectors for relaxed rows (and a sticky header) don't work because the goa-table element doesn't get a relaxed or sticky class.
https://github.com/GovAlta/ui-components/blob/b69048853d5bc2b6f1e8bc96eece8759e1a08636/libs/web-components/src/assets/css/components.css#L83-L90
It looks like the wrapper div in the element's shadow DOM that get these classes 👀.

I'm not sure how best to approach it. I'll need to spend more time researching how to style a slotted element in this situation. 🤔

:tada: This issue has been resolved in version 1.17.0-alpha.44 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This issue has been resolved in version 4.17.0-alpha.23 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This issue has been resolved in version 1.20.5 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This issue has been resolved in version 4.20.4 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This issue has been resolved in version 3.0.0-alpha.4 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This issue has been resolved in version 3.0.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[Question]: [Panasonic ID] Notification of Panasonic ID login

The problem
I started receiving emails as below
do any of you receive such as well? can that be because of the hass integration?
======
[Panasonic ID] Notification of Panasonic ID login
Thank you very much for using a Panasonic ID.
You have logged in to your Panasonic ID.
This email is sent to you when you have logged in to your Panasonic ID so that you can use Panasonic services safely.
If you do not know why you have received this email and have not logged in to your Panasonic ID, a third party may have performed an unauthorized login. Please change your password as soon as possible.

Panasonic ID customer support
    https://accountglb.digital.panasonic.com/

What version of Home Assistant Core are you running?
latest
What type of installation are you running?
Home Assistant OS
What version of the integration are you running?
latest
Device description
not relevant
Is the integration loading?
Yes
Is the adapter able to connect to the Aquarea Smart Cloud with a stable internet connection?
Yes
Are you able to perform the action you're trying to with the Aquarea Smart Cloud Site/App?
Yes
Area of the issue
No response
Anything in the logs?
No response
Additional information
No response

Plus one on that one! Had to set up an email rule to move all emails to a separate folder. Several emails per minute. :D

it's related to this one:
https://github.com/cjaliaga/home-assistant-aquarea/issues/121
I also got this mail spam :)

thx, yes just saw the other ticket created and I can confirm that for me the hass integration stopped working as well
so we can close the ticket I created as duplicate
BR,
Sławek

same problem, probably 2 step verification

Same problem here, since this morning. Restarting the HA shows the Aquarea Smart Cloud authentication has expired.  Going in and reentering the password shows an error "Unexpected Error"

Same problem here! I had to disable all Aquarea entries in Settings/Integrations/Auquarea Smart Cloud to stop the email flood into my mailbox.

is this the end of the application?

Same here - flood of emails and broken integration:(

Same issue :(

Log show:
`Unexpected exception
Traceback (most recent call last):
File "/config/custom_components/aquarea/config_flow.py", line 144, in _validate_input
await self._api.login()
File "/usr/local/lib/python3.12/site-packages/aioaquarea/core.py", line 274, in login
await self.__login_production()
File "/usr/local/lib/python3.12/site-packages/aioaquarea/core.py", line 334, in __login_production
csrf = response.cookies.get("_csrf").value
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'value'`

Same problem

+1

I have the same issue +1

It started to works again seams like they reverted changes they made

Works again

yep, I confirm it's working now. Let's see for how long they have reverted the changes :)

resolving as issue is gone for now


Improve and generalize promise error handling.

There's no real strategy how to handle errors in a promise chain. Sometimes it throws, sometimes it returns an error object, sometimes it just swallows the error and never return.
If an error happens it should be displayed at the error console. It should be consistently handled in a catch block at the end of a then chain.

An important task but since v0.4.0 all things are working synchronously. No promises, no need for refactoring.


TypeError: init() got an unexpected keyword argument 'enable_segmentation'

I am not able to enable the segmentation for the pose model. Following is my init code:

def init(self, static_image_mode=False, model_complexity=2, smooth_landmarks=True,
min_detection_confidence=0.5, min_tracking_confidence=0.5,enable_segmentation = True):
    self.static_image_mode = static_image_mode
    self.model_complexity = model_complexity
    self.smooth_landmarks = smooth_landmarks
    self.min_detection_confidence = min_detection_confidence
    self.min_tracking_confidence = min_tracking_confidence
    self.enable_segmentation = enable_segmentation
    self.mpDraw = mp.solutions.drawing_utils
    self.mpPose = mp.solutions.pose

    self.pose = self.mpPose.Pose(static_image_mode=self.static_image_mode, model_complexity=self.model_complexity,
                                  smooth_landmarks=self.smooth_landmarks,
                                  min_detection_confidence=self.min_detection_confidence,
                                  min_tracking_confidence=self.min_tracking_confidence,
                                  enable_segmentation=self.enable_segmentation,
                                )

I am getting this error : TypeError: init() got an unexpected keyword argument 'enable_segmentation'
Please suggest what to do to enable segmentation.

I simply had to update the mediapipe library. No further assistance is needed on this. Thank you.


find enough data for research question

The group was planning to look at Hays County first. There was a major change point in Hays around 2002. That's when the law changed to provide more resources for appointed attorneys. There was a research question about whether the change in funding improved outcomes.
There's not a lot of historical data before 5 or 10 years ago. There are only a few data points before 2014 or 2015.

Is this being tackled outside this forum? Should I close this to clear the Issue log?

Yep, this can be closed, issue turned out to be on the job scheduler side.


Add <parallel> tags around build components

There are two commits here, one I accidentally made files with CRLF and fixed it in the next commit. Read d11f280 and 1ec42e0 for review, not 0a1c747.
This should improve build times by making components build in parallel where available. Additionally, I formatted the Build Status in a nice table.

The build does not fail anymore, thanks to #743.

Note: This requires #741 to be merged first for a clean merge.

Now #749 is merged, this will need to be modified. The parallel tags are done in #749 because I was modifying the same lines. So just change this to deal with the build status list and the other change (removing -Dmyenv in a few places)

I'll cherry-pick these commits later, I have to finish up some course work today among other things.

I'm actually going to just close this and create a PR for the README update. The other changes are not necessary.


Add markdown.pandoc support.

Just a small edge case, I would be glad if you added it.

Thank you!


Show FOA members separately on the list

Maybe add an option to show or not.

My idea is to show a FOA like this:

Nice and clean.  As usual!

Maybe add an option to show or not.

I agree, checking if it's a FOA would have a performance impact.
A method could be to use openMCDF to check if a stream named "Master" is present.

With commit bc17d0a55abc0c19e834c124073ec152d6bbe4e4 I have added initial support for FOA properties, at the moment only Master properties are handled.
I haven't checked if the test has an impact on the file list update and on the Task Edit properties


Remove elements not needed for your pull

Not everyone has all these tools. The settings portion should have a way to hide elements.

This took a lot of time, but it's now done with v42


Is this active?

I never got the chance to update it to 1.16. Hopefully when 1.17 comes around I can

I do have an incomplete port to 1.16 on my pc I think. It runs but does not work properly

Any update?


[WIP] [SPARK-12177] [STREAMING] Update KafkaDStreams to new Kafka 0.9 Consu…

…mer API

Can one of the admins verify this patch?

+1

Nikita, since we are still working on this, could you please mark this PR as [WIP] in the title so no one gets confused? Thanks!

Hi @nikit-os, I have made a bunch of more changes in my personal branch at https://github.com/markgrover/spark/tree/kafka09-integration and some WIP changes for the python implementation at https://github.com/markgrover/spark/tree/kafka09-integration-python.
For now, I want to drive forward the Java/Scala and get feedback from the community. To make that easier, I would love to file a separate pull request that will be based off your original PR (i.e. this pull request). My desire is not take credit away from you, in fact, I will keep the history in tact, and explicitly mention that you have contributed a good chunk of this work but I don't want the logistical overhead of having to issue you a pull request to your branch, every time I want to update this pull request.
Would it be ok if I create a new pull request, that's a super set of, and supersedes this pull request?

Hi, @markgrover!
Yes, I am not against new PR and closing this. Thank you!

Thanks @nikit-os https://github.com/apache/spark/pull/10953 now supersedes this.


Bootstrap template for in-lesson slides

We should find or build a template for pages that will be used as a part of lessons.  They should have a solid color, relatively neutral, and be very simple.  The purpose is not to "wow" but to be a canvas for the content.  It should look amazing in a browser, iPhone, and iPad.

Ben deployed a functional template.


V1.9.1

Linter check found the following problems:
The following problems have been found:
WARNING: /tmp/abs_612apkwvkx/clone/recipe/meta.yaml:40: missing_description: The recipe is missing a description
ERROR: /tmp/abs_612apkwvkx/clone/recipe/meta.yaml:40: missing_dev_url: The recipe is missing a dev_url
Errors were found


Add browser name to report file for multiple run

The name of the report file for multiple runs is always report.xml. CI/CD Environments like Jenkins need unique names to recording test results

How to fix this hound issue? -.-

Just use ESLint :)
But no problems, I can fix it myself. Thanks


Refactor load/save checkpoint

Add support for the following calls:
save_checkpoint(model) -> stores the model. 'arch' and 'dataset' are optional.
load_checkpoint(file_path) -> create the model. Return dict instead of fixed-size tuple. extra values included.
load_checkpoint(file_path, model=create_model(...)) -> behaves like before. returns a dict.
load_checkpoint(file_path, 'cpu') -> load model to cpu
I tested this specific commit very lightly. passes pytest with Python3.6.
The 2nd commit in the PR only looks scary, but it only adds try-except.

closing due to staleness.


TypeDoc should only show what is actually exposed

Inner-workings (non exposed functions) of the library aren't relevant to the docs, since users can't even use them

:tada: This issue has been resolved in version 1.1.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Memory upscale doesn't happen when it should

User (and I) consistently get OOM when doing pgvector CREATE INDEX ... USING ivfflat on 15GB table. OOM logs show that compute wasn't upscaled to max CU. Example (here max cu is 4, i.e. 16GB, but OOM happened at 9GB):
https://neonprod.grafana.net/goto/EAgSWo3Vg?orgId=1
endpoint:
https://console.neon.tech/admin/endpoints/ep-sweet-feather-898825
a bit more context:
https://neondb.slack.com/archives/C03TN5G758R/p1690319779712199?thread_ts=1690313755.185089&cid=C03TN5G758R
I have access to user db and can pass it to someone to repro.

The OOM logs are interesting. I've duplicated them here with Grafana's timestamps for posterity:

OOM logs
2023-07-27T18:19:22Z	[ 3126.745348] postgres invoked oom-killer: gfp_mask=0x400dc0(GFP_KERNEL_ACCOUNT|__GFP_ZERO), order=0, oom_score_adj=0
2023-07-27T18:19:22Z	[ 3126.746571] CPU: 0 PID: 392 Comm: postgres Not tainted 5.15.80 #1
2023-07-27T18:19:22Z	[ 3126.747243] Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS rel-1.16.0-0-gd239552ce722-prebuilt.qemu.org 04/01/2014
2023-07-27T18:19:22Z	[ 3126.748482] Call Trace:
2023-07-27T18:19:22Z	[ 3126.748758]  <TASK>
2023-07-27T18:19:22Z	[ 3126.748993]  0xffffffff993700cb
2023-07-27T18:19:22Z	[ 3126.749350]  0xffffffff993700f0
2023-07-27T18:19:22Z	[ 3126.749675]  0xffffffff99365bc8
2023-07-27T18:19:22Z	[ 3126.750009]  0xffffffff99365e05
2023-07-27T18:19:22Z	[ 3126.750346]  0xffffffff98c482e0
2023-07-27T18:19:22Z	[ 3126.750708]  0xffffffff98c9eb16
2023-07-27T18:19:22Z	[ 3126.751060]  0xffffffff98c9f0b8
2023-07-27T18:19:22Z	[ 3126.751439]  0xffffffff98cb73b8
2023-07-27T18:19:22Z	[ 3126.751785]  0xffffffff98abc044
2023-07-27T18:19:22Z	[ 3126.752138]  0xffffffff98c7c466
2023-07-27T18:19:22Z	[ 3126.752486]  0xffffffff98c7fa96
2023-07-27T18:19:22Z	[ 3126.752835]  0xffffffff98c7fd56
2023-07-27T18:19:22Z	[ 3126.753181]  0xffffffff9938b300
2023-07-27T18:19:22Z	[ 3126.753553]  0xffffffff99400b64
2023-07-27T18:19:22Z	[ 3126.753892] RIP: 0033:0x00007f2fdb3780a3
2023-07-27T18:19:22Z	[ 3126.754311] Code: 2a 4c 8d 42 10 48 29 e8 48 8d 3d f8 ba 14 00 48 83 ce 04 48 89 4b 60 48 39 fb 48 0f 45 ee 48 83 c8 01 48 83 cd 01 48 89 6a 08 <48> 89 41 08 48 83 c4 48 4c 89 c0 5b 5d 41 5c 41 5d 41 5e 41 5f c3
2023-07-27T18:19:22Z	[ 3126.756339] RSP: 002b:00007ffe0f5b0be0 EFLAGS: 00010206
2023-07-27T18:19:22Z	[ 3126.756916] RAX:<PHONE_NUMBER>020121 RBX: 00007f2fdb4c3b80 RCX: 000055cc9c68dee0
2023-07-27T18:19:22Z	[ 3126.757695] RDX: 000055cc9c5a5aa0 RSI:<PHONE_NUMBER>0e8444 RDI: 00007f2fdb4c3b80
2023-07-27T18:19:22Z	[ 3126.758451] RBP:<PHONE_NUMBER>0e8441 R08: 000055cc9c5a5ab0 R09: 00007f2fdb4c3be0
2023-07-27T18:19:22Z	[ 3126.759203] R10:<PHONE_NUMBER>0e8460 R11: 000055cc9c5c6000 R12:<PHONE_NUMBER>020560
2023-07-27T18:19:22Z	[ 3126.759961] R13: fffffffffffff000 R14: 000055cc9c5a5aa0 R15:<PHONE_NUMBER>0e8460
2023-07-27T18:19:22Z	[ 3126.760789]  </TASK>
2023-07-27T18:19:22Z	[ 3126.761043] Mem-Info:
2023-07-27T18:19:22Z	[ 3126.761314] active_anon:1353893 inactive_anon:420828 isolated_anon:0
2023-07-27T18:19:22Z	[ 3126.761314]  active_file:12840 inactive_file:476776 isolated_file:6
2023-07-27T18:19:22Z	[ 3126.761314]  unevictable:0 dirty:44589 writeback:0
2023-07-27T18:19:22Z	[ 3126.761314]  slab_reclaimable:26310 slab_unreclaimable:2665
2023-07-27T18:19:22Z	[ 3126.761314]  mapped:60517 shmem:1401164 pagetables:1823 bounce:0
2023-07-27T18:19:22Z	[ 3126.761314]  kernel_misc_reclaimable:0
2023-07-27T18:19:22Z	[ 3126.761314]  free:3273 free_pcp:233 free_cma:0
2023-07-27T18:19:22Z	[ 3126.765267] Node 0 active_anon:5415572kB inactive_anon:1683312kB active_file:51360kB inactive_file:1907104kB unevictable:0kB isolated(anon):0kB isolated(file):24kB mapped:242068kB dirty:178356kB writeback:0kB shmem:5604656kB writeback_tmp:0kB kernel_stack:1920kB pagetables:7292kB all_unreclaimable? yes
2023-07-27T18:19:22Z	[ 3126.768087] Node 0 DMA32 free:3544kB min:3812kB low:4756kB high:5700kB reserved_highatomic:10240KB active_anon:361692kB inactive_anon:316812kB active_file:100kB inactive_file:84kB unevictable:0kB writepending:0kB present:1048032kB managed:944612kB mlocked:0kB bounce:0kB free_pcp:596kB local_pcp:128kB free_cma:0kB
2023-07-27T18:19:22Z	[ 3126.771065] lowmem_reserve[]: 0 0 8192
2023-07-27T18:19:22Z	[ 3126.771479] Node 0 Movable free:9548kB min:3484kB low:11872kB high:20260kB reserved_highatomic:0KB active_anon:5053880kB inactive_anon:1366500kB active_file:51328kB inactive_file:1906884kB unevictable:0kB writepending:178452kB present:8388608kB managed:8388608kB mlocked:0kB bounce:0kB free_pcp:336kB local_pcp:152kB free_cma:0kB
2023-07-27T18:19:22Z	[ 3126.774601] lowmem_reserve[]: 0 0 0
2023-07-27T18:19:22Z	[ 3126.774978] Node 0 DMA32: 390*4kB (UMH) 144*8kB (UMH) 42*16kB (UMH) 3*32kB (H) 1*64kB (H) 0*128kB 0*256kB 0*512kB 0*1024kB 0*2048kB 0*4096kB = 3544kB
2023-07-27T18:19:22Z	[ 3126.776451] Node 0 Movable: 1*4kB (M) 1*8kB (M) 0*16kB 0*32kB 1*64kB (M) 0*128kB 1*256kB (M) 0*512kB 1*1024kB (M) 0*2048kB 2*4096kB (M) = 9548kB
2023-07-27T18:19:22Z	[ 3126.777867] Node 0 hugepages_total=0 hugepages_free=0 hugepages_surp=0 hugepages_size=1048576kB
2023-07-27T18:19:22Z	[ 3126.778812] Node 0 hugepages_total=0 hugepages_free=0 hugepages_surp=0 hugepages_size=2048kB
2023-07-27T18:19:22Z	[ 3126.779720] 1890763 total pagecache pages
2023-07-27T18:19:22Z	[ 3126.780210] 0 pages in swap cache
2023-07-27T18:19:22Z	[ 3126.780702] Swap cache stats: add 0, delete 0, find 0/0
2023-07-27T18:19:22Z	[ 3126.781304] Free swap  = 0kB
2023-07-27T18:19:22Z	[ 3126.781627] Total swap = 0kB
2023-07-27T18:19:22Z	[ 3126.781930] 2359160 pages RAM
2023-07-27T18:19:22Z	[ 3126.782254] 0 pages HighMem/MovableOnly
2023-07-27T18:19:22Z	[ 3126.782667] 25855 pages reserved
2023-07-27T18:19:22Z	[ 3126.783013] Tasks state (memory values in pages):
2023-07-27T18:19:22Z	[ 3126.783512] [  pid  ]   uid  tgid total_vm      rss pgtables_bytes swapents oom_score_adj name
2023-07-27T18:19:22Z	[ 3126.784476] [    118]     0   118      319        8    40960        0             0 udhcpc
2023-07-27T18:19:22Z	[ 3126.785379] [    119]     0   119     1210      161    45056        0             0 udevd
2023-07-27T18:19:22Z	[ 3126.786234] [    121]     0   121      209       19    40960        0             0 acpid
2023-07-27T18:19:22Z	[ 3126.787092] [    123]     0   123    27604     4251   221184        0             0 vector
2023-07-27T18:19:22Z	[ 3126.787965] [    125]     0   125      321        8    40960        0             0 vmstart
2023-07-27T18:19:22Z	[ 3126.788901] [    127]     0   127     1550      113    53248        0             0 su
2023-07-27T18:19:22Z	[ 3126.789755] [    131]     0   131     1550      113    53248        0             0 su
2023-07-27T18:19:22Z	[ 3126.790592] [    134]     0   134     1550      113    53248        0             0 su
2023-07-27T18:19:22Z	[ 3126.791439] [    137]     0   137     1040      436    40960        0             0 bash
2023-07-27T18:19:22Z	[ 3126.792322] [    148]  1000   148      321        1    45056        0             0 sh
2023-07-27T18:19:22Z	[ 3126.793185] [    149]  1000   149   121954     1132   131072        0             0 compute_ctl
2023-07-27T18:19:22Z	[ 3126.794108] [    150] 65534   150      620       17    45056        0             0 sh
2023-07-27T18:19:22Z	[ 3126.794982] [    151]   101   151      620       16    49152        0             0 sh
2023-07-27T18:19:22Z	[ 3126.795823] [    152] 65534   152      620       17    45056        0             0 sh
2023-07-27T18:19:22Z	[ 3126.796701] [    153] 65534   153      496       78    28672        0             0 pgbouncer
2023-07-27T18:19:22Z	[ 3126.797629] [    154] 65534   154   179954      328    98304        0             0 postgres_export
2023-07-27T18:19:22Z	[ 3126.798587] [    155]   101   155   186538     3915   167936        0             0 vm-informant
2023-07-27T18:19:22Z	[ 3126.799516] [    377]  1000   377    69130    18905   262144        0             0 postgres
2023-07-27T18:19:22Z	[ 3126.800447] [    379]  1000   379    69250     2417   212992        0             0 postgres
2023-07-27T18:19:22Z	[ 3126.801353] [    380]  1000   380    69230    36209   450560        0             0 postgres
2023-07-27T18:19:22Z	[ 3126.802235] [    382]  1000   382    69171     2575   151552        0             0 postgres
2023-07-27T18:19:22Z	[ 3126.803167] [    383]  1000   383    69785     3188   274432        0             0 postgres
2023-07-27T18:19:22Z	[ 3126.804075] [    384]  1000   384    70028     4503   258048        0             0 postgres
2023-07-27T18:19:22Z	[ 3126.805187] [    385]  1000   385    69731     2306   237568        0             0 postgres
2023-07-27T18:19:22Z	[ 3126.806116] [    386]  1000   386    69744     2380   159744        0             0 postgres
2023-07-27T18:19:22Z	[ 3126.807002] [    387]  1000   387    69227     1176   139264        0             0 postgres
2023-07-27T18:19:22Z	[ 3126.807883] [    388]  1000   388    69730     2151   184320        0             0 postgres
2023-07-27T18:19:22Z	[ 3126.808958] [    391]  1000   391    70213     5816   225280        0             0 postgres
2023-07-27T18:19:22Z	[ 3126.809872] [    392]  1000   392    70384     5303   212992        0             0 postgres
2023-07-27T18:19:22Z	[ 3126.810775] [    396]   101   396   186672     4836   176128        0             0 vm-informant
2023-07-27T18:19:22Z	[ 3126.811709] [    437]  1000   437   432420   403523  3399680        0             0 postgres
2023-07-27T18:19:22Z	[ 3126.812765] [   1138]  1000  1138    70404     5369   245760        0             0 postgres
2023-07-27T18:19:22Z	[ 3126.813707] oom-kill:constraint=CONSTRAINT_NONE,nodemask=(null),cpuset=/,mems_allowed=0,global_oom,task_memcg=/,task=postgres,pid=437,uid=1000
2023-07-27T18:19:22Z	[ 3126.815092] Out of memory: Killed process 437 (postgres) total-vm:1729680kB, anon-rss:1452148kB, file-rss:8700kB, shmem-rss:153244kB, UID:1000 pgtables:3320kB oom_score_adj:0

Things that jump out:

Total RAM was 2359160 pages - about 8.99 GiB
Total rss was 511383 pages - about 1.95 GiB
Total pagecache was 1890763 pages - about 7.21 GiB

I'm not sure I'm reading that correctly, especially given 1.95 + 7.21 > 8.99, but broadly pagecache is very high. (I think that matches @knizhnik's analysis here?)
Some other information:
Memory usage, according to the metrics that the autoscaler-agent was receiving looked consistent:

So: Even though the memory was behaving in roughly the same way each time (and the VM did scale up from 8 → 9 GiB RAM [agent request at 18:19:01]), presumably we just crossed some threshold? The pattern of "gradual increase then drop-off to the baseline" occurred every 3.5 minutes, and peak memory (that we observed) was trending slightly higher each time. That said, this would mean that the VM's memory usage sharply increased at the end of the spike and we never observed it, which... may be true? I'm not sure.

I think this issue was due to OOM issues that have since been fixed (iirc, with neondatabase/neon#5333). In light of that, closing this — we can reopen if it persists.


Will impermanence work with systemd-homed?

I'm not sure, but it will probably depend on whether home-manager will support it.

I'm not sure, but it will probably depend on whether home-manager will support it.


Build work again on travis

Changed to build with docker. Specs still need to be fixed, but it is correctly building on intended architectures.
I've removed old unsupported ones.

I'll try merging this into what I've got for #124

The merge didn't work out correctly. I'll make you a collaborator on my repo in case it is convenient for you to have greater access.
https://travis-ci.org/dwmarshall/ark/builds/107702998
is the merge of #124 and #125

@dwmarshall its in an intended state.
here is the summary of the problems that still need some work to be done:
CentOS 6 see build:

No such file or directory - /bin/tar

Debian 7 see build:

STDERR: configure: error: cannot find install-sh, install.sh, or shtool in config "."/config

Ubuntu 12.04 see build:

STDERR: /bin/bash: /usr/local/test_autogen-1/config/missing: No such file or directory

Ubuntu 14.04 see build:

STDERR: configure: error: cannot find install-sh, install.sh, or shtool in config "."/config

So basically we must make sure tar is present for centos (maybe another recipe to the run_list), and fix autogen, for debian/ubuntu

Thank you for the clarification! I'm hoping to have the remaining work done tonight.

BTW, the trick for centos is to merge #61 and to add bzip2 for the list of packages for centos

closing in favor of #126, which contains these commits


[2982] [2983] Add not applicable school checkbox to Lead/Employing school UI

Context
https://trello.com/c/7SB3gYhc/2982-not-applicable-school-employing-school-ui
https://trello.com/c/1Ku7oNpv/2983-not-applicable-school-lead-school-ui
Changes proposed in this pull request

Added checkbox for not applicable lead/employing schools
Refactored the lead and employing schools forms; pushed more logic into the base class
Updated the school view components to handle not applicable schools

Guidance to review

Find school direct (salaried) draft trainee
Click on "Lead and employing schools"
Click change under "Lead school"
Click "Continue" (leave the search field blank)
The error message should be the same as before
Search for a school
Click on the expandable link "Trainee is not at a state school or lead school is not listed"
Check the box and click continue
The error mesage should now be different indicating only one option can be chosen
Clear the search field and click continue
The confirmation page should now display "Not applicable" for lead school

Repeat above steps for employing school and do the same for non-draft trainees.

 Not applicable school Lead School UI


Refactor Track Volunteers controller and template

Refactor the controller (/eventsList/<eventID>/track_volunteers) to simplify the data controller gets and the template needs.

 Refactor Track Volunteers controller and template #944

Request for more Info/Update: Couldn't locate route /eventsList/<eventID>/track_volunteers either this has already been refactored or it no longer exists. Please provide more information or update the issue if there have been changes.


rename digital twin to pnp

As titled, rename string (reviewd by ChrisG). The files names are left as is. Will get to them if needed in the future.
The nav is also flattened, as PnP become simply one of the nav item.

I think the renaming of the Files/Components from Digital Twin to Plug and Play should definitely come sooner rather than later. It will have much confusion with route parts and strings saying Plug and Play and the file/component names saying Digital Twin. Can we add a backlog item for making that change as a distinct PR?

Sure. Created a task to keep track of the file renames


Remove cloud providers page

Remove https://k8s.io/docs/concepts/cluster-administration/cloud-providers/
The content guide for the website requires omitting this kind of content; instead, cloud providers can each provide their own documentation on how to make their system work with Kubernetes.
Relevant to https://github.com/kubernetes/website/issues/20232
/kind cleanup

Hello @sftim .
Should the site link to cloud provider documentation
that resides within Kubernetes repositories. A couple of examples:
https://github.com/kubernetes/cloud-provider-aws#readme
https://github.com/kubernetes-sigs/cloud-provider-azure#readme
Should the docs list these resources in a reference section or not at all?

Should the site link to cloud provider documentation that resides within Kubernetes repositories.

Possibly. I think adding that would be a separate PR, and I think I'd put those links in a different place.
For example: somewhere in the reference section, add links to all in-project cloud provider repos, listed alphabetically.
I'd put that in the reference section because it is a list that a reader might refer to.
AIUI Kubernetes puts little weight on whether a cloud provider's code is in-project or not; for example, if you make an entirely closed-source cloud controller manager, you can still add that to a Kubernetes cluster and there's no licensing or other concern about doing that.
@kubernetes/sig-cloud-provider-pr-reviews any thoughts here?

Instead of dropping these info abruptly, I'd suggest we

add a reference page for cloud providers, with a warning for 3rd party contents;
in the said reference page, provide at little information as possible for each provider;
remove the provider specific info/reference in all concepts or tasks, where appropriate;
add a redirect entry pointing users to the reference page.

Instead of dropping these info abruptly, I'd suggest we
* add a reference page for cloud providers, with a warning for 3rd party contents;

* in the said reference page, provide at little information as possible for each provider;

* remove the provider specific info/reference in all concepts or tasks, where appropriate;

* add a redirect entry pointing users to the reference page.

This makes sense 👍 . Some of the page content should be dropped, though.

I hold a contrary opinion to @tengqm's.
Per the 3rd party content KEP and the warning period that content would be removed once 1.19 is released, we are under no obligation at this point, as a SIG, to keep this content. If the SMEs involved (@kubernetes/sig-cloud-provider-pr-reviews) wanted to adjust this content to fit in with the KEP guidelines, they had ample time to do it. If they would like to do so now, or have us work with them to do so now, we are still under no obligation to hold up this PR from merging to give them further time to organize an approach.
Secondly: we as a SIG cannot continue to debate this topic every time a PR opens up related to it. At some point, we need to put our foot down, or we will continue to waste time debating a decision we've already agreed on. If we continue to
As such:

I am going to mark this PR as lgtm because, from a purely functional perspective, it is in fact, ready to merge. @sftim took the time & the effort to do this change thoroughly, removing not just the page but links to it.
I am going to cc @jimangel @zacharysarah and @irvifa, and allow them to either /approve or otherwise digest the discussion in this PR as they see fit as SIG Docs Chairs.

/lgtm

Hi @celestehorgan .
So that I understand how to interpret the guidelines,
can you provide reasoning why the docs should not contain links to:
https://github.com/kubernetes/cloud-provider-aws#readme
https://github.com/kubernetes-sigs/cloud-provider-azure#readme
The information seems to be located within the Kubernetes family?

Thanks, folks, for providing robust feedback. To address some specific points:
@tengqm

add a reference page for cloud providers, with a warning for 3rd party contents

Who maintains this content?

in the said reference page, provide at little information as possible for each provider

This would require someone, presumably SIG Docs, to track and update URLs for cloud providers, while also devoting review cycles to stakeholders at cloud providers who argue that (for example) their competitor got twenty-five words to describe their service, so why are you rejecting my twenty-four-word vendor pitch, etc.

remove the provider specific info/reference in all concepts or tasks, where appropriate

I think this PR is an excellent step in that direction.

add a redirect entry pointing users to the reference page

Again, who maintains this content?
All of these suggestions amount to undoing the KEP for third-party content. On that basis, I recommend we decline to act on any of these suggestions.
@kbhawkey

can you provide reasoning why the docs should not contain links to:
...
The information seems to be located within the Kubernetes family?

Because that specific information is in-project, it qualifies for inclusion in the docs--preferably by linking wherever possible in order to avoid duplicate content. However, qualification doesn't mean it's automatically approved everywhere and in all contexts. This PR does a sensible job of removing content and suggesting, per @sftim: "I'd put those links in a different place."
Also, as @celestehorgan points out, SIGs had the entirety of the 1.19 cycle, the longest yet, to express an active opinion for how and where this content resides. In the absence of input, our own content policy (extensively vetted and adopted by the community) makes the best sense to apply.
@sftim
This looks great, thanks for opening the PR. 👍
/approve
Your comment would make a solid good-first-issue:

Possibly. I think adding that would be a separate PR, and I think I'd put those links in a different place.
For example: somewhere in the reference section, add links to all in-project cloud provider repos, listed alphabetically.
I'd put that in the reference section because it is a list that a reader might refer to.

Everyone

Secondly: we as a SIG cannot continue to debate this topic every time a PR opens up related to it. At some point, we need to put our foot down, or we will continue to waste time debating a decision we've already agreed on.

Giant plus one: the KEP is done.
Going forward, I recommend:

Reviewers and approvers review content according to the Kubernetes content guide
Reviewers, approvers, and contributors decline to respond to reviews that fall out of alignment with the content guide

I'll add this recommendation to the next weekly meeting to publicize it more widely.

Overall, the deleted page appears to be (generally) unclear and outdated. I agree that a page entitled cloud providers is likely to cause problems.
Let's take a look at a quote from the page.

AWS
This section describes all the possible configurations which can
be used when running Kubernetes on Amazon Web Services.

I truly don't think such a thing is possible.

re: @zacharysarah
Who maintains this content?

Even as someon whose literally job is "open source techincal writer" for AWS- I would not want to maintain this page. I would not want to be accused of abusing it.

re: @celestehorgan
If the SMEs involved (@kubernetes/sig-cloud-provider-pr-reviews) wanted to adjust this content to fit in with the KEP guidelines, they had ample time to do it. If they would like to do so now, or have us work with them to do so now, we are still under no obligation to hold up this PR from merging to give them further time to organize an approach.

I think Celese is correct to highlight that the burden is on cloud providers to create content that both helps users understand the reality of running k8s in the cloud and fits within the KEP guidelines
I see the path forward as not thorough maintaining a cloud providers page, but instead providing useful information on the relevant docs pages.
For example, the ingress controler doc page may call out that ingress controllers are commonly provided by cloud platforms.
https://kubernetes.io/docs/concepts/services-networking/ingress-controllers/#additional-controllers
thanks, geoffrey


Control default cache duration via the config file

Add duration to config
Add getCacheDuration method to resolve duration

Thanks!


fix LogicalPlanDeepCopier copy scan conjuncts in wrong way

intro by PR #34894
This PR attempts to address the issue of losing conjuncts when performing a deep copy of the outer structure. However, the timing of copying the conjuncts is incorrect, resulting in the inability to map slots within the conjuncts to the output of the outer structure.
Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall

run buildall


Source selection tooltips don't work anymore.

Their localization can not be found, causing [maps] or [wikipedia] to be displayed instead.

031e820a0e fixes it partially but still fails due to race conditions.