USB4SAP

When submitting a connector, please make sure that you follow the requirements below, otherwise your PR might be rejected. We want to make you have a well-built connector, a smooth certification experience, and your users are happy :)
If this is your first time submitting to GitHub and you need some help, please sign up for this session.

[x] I attest that the connector doesn't exist on the Power Platform today. I've verified by checking the pull requests in GitHub and by searching for the connector on the platform or in the documentation.
[x] I attest that the connector works and I verified by deploying and testing all the operations.
[x] I attest that I have added detailed descriptions for all operations and parameters in the swagger file.
[x] I attest that I have added response schemas to my actions, unless the response schema is dynamic.
[x] I validated the swagger file, apiDefinition.swagger.json, by running paconn validate command.
[x] If this is a certified connector, I confirm that apiProperties.json has a valid brand color and doesn't use an invalid brand color, #007ee5 or #ffffff. If this is an independent publisher connector, I confirm that I am not submitting a connector icon.

If you are an Independent Publisher, you must also attest to the following to ensure a smooth publishing process:

[ ] I have named this PR after the pattern of "Connector Name (Independent Publisher)" ex: HubSpot Marketing (Independent Publisher)
[ ] Within this PR markdown file, I have pasted screenshots that show: 3 unique operations (actions/triggers) working within a Flow. This can be in one flow or part of multiple flows. For each one of those flows, I have pasted in screenshots of the Flow succeeding.
[ ] Within this PR markdown file, I have pasted in a screenshot from the Test operations section within the Custom Connector UI.
[ ] If the connector uses OAuth, I have provided detailed steps on how to create an app in the readme.md.

Thanks Egor. We will action these comments and revert when ready.
++ Mridul.
Thanks a ton,
Anupam Jaiswal
M<EMAIL_ADDRESS>| T: +1.2145199601
https://www.ecoservity.com/
[AIorK4y9ORf3HVxkZJze1bmxXE-tgEq0B1jlBM2DYsZ4KMhn4bvxGhDTKpomrSI4gK1nxJQFuaCpR5E]
From: v-EgorKozhadei @.>
Date: Tuesday, September 20, 2022 at 14:40
To: microsoft/PowerPlatformConnectors @.>
Cc: Anupam Jaiswal @.>, Mention @.>
Subject: Re: [microsoft/PowerPlatformConnectors] USB4SAP (PR #1971)
@v-EgorKozhadei commented on this pull request.
Hello @ecsadmhttps://github.com/ecsadm,
Please check comments after the review.
Let us know if you have any questions or need help.

In certified-connectors/USB4SAP/Readme.mdhttps://github.com/microsoft/PowerPlatformConnectors/pull/1971#discussion_r975672079:

@@ -0,0 +1 @@

+# USB4SAP
USB4SAP is one single API for any SAP data source to be consumed as a REST or RFC enabled API
Publisher: Ecoservity
Prerequisites
User must have backend agent installed on the SAP system as described in the Deployment instructions below
User must enter a valid SAP user ID & password.
For REST based access, a NetWeaver Gateway or equivalent REST API provider should be connected to backend SAP system.
Follow this guide for prerequisites.
Supported Operations
This query supports GET operation from SAP backend to provision data from tables, views, reports, queries, ALV, CDS, or any other data container.
Obtaining Credentials
This API uses Basic Authentication
Known Issues and Limitations
->REST API supports data limits as specified under REST API protocols
->Large datasets extraction may result in time outs as configured in the REST API systems. In such cases, we recommend using the batch extraction method as supported by the solution
Deployment Instructions
-> Follow this link for the installation of ODDI for SAP.
@ecsadmhttps://github.com/ecsadm please make sure that the formatting is correct. File contents are in one single line right now. You can refer to the templatehttps://github.com/microsoft/PowerPlatformConnectors/blob/dev/templates/certified-connectors/readme.md?plain=1 to see an example of formatting.

In certified-connectors/USB4SAP/apiProperties.jsonhttps://github.com/microsoft/PowerPlatformConnectors/pull/1971#discussion_r975677181:

                   "tabIndex": 2

               },

               "description": "The access for this API",

               "displayName": "Basic",

               "tooltip": "Basic authentication used, No key is needed"

           }

       }

   },

   "iconBrandColor": "#cddd36",

   "capabilities": [

       "Provisioning live data from SAP",

       "Provisioning batch data from SAP"

   ],

   "publisher": "Ecoservity",

   "stackOwner": "Ecoservity"

@ecsadmhttps://github.com/ecsadm please make sure that formatting and indentation are correct in apiProperties and apiDefinitions files.

In certified-connectors/USB4SAP/apidefinition.swagger.jsonhttps://github.com/microsoft/PowerPlatformConnectors/pull/1971#discussion_r975678533:

@@ -0,0 +1,70 @@

+{

"swagger": "2.0",

"info": {

"title": "USB4SAP",

"version": "1.0",

"description": "Universal Synch Bridge for SAP: One API for all SAP integration, analytics and UI needs. Simplify modern analytics, apps and automations. Provision SAP data, insights and automation On-demand.",

@ecsadmhttps://github.com/ecsadm the word API is not allowed in the description. Please remove it. More information about the description can be found herehttps://docs.microsoft.com/en-us/connectors/custom-connectors/certification-submission#write-a-description-for-your-connector.

In certified-connectors/USB4SAP/apidefinition.swagger.jsonhttps://github.com/microsoft/PowerPlatformConnectors/pull/1971#discussion_r975678948:

@@ -0,0 +1,70 @@

+{

"swagger": "2.0",

"info": {

"title": "USB4SAP",

"version": "1.0",

"description": "Universal Synch Bridge for SAP: One API for all SAP integration, analytics and UI needs. Simplify modern analytics, apps and automations. Provision SAP data, insights and automation On-demand.",

"contact":{

 "name": "Ecoservity",

 "url" : "https://www.ecoservity.com/#contact",

 "email"<EMAIL_ADDRESS>

@ecsadmhttps://github.com/ecsadm please make sure that formatting and indentation are correct.

In certified-connectors/USB4SAP/apidefinition.swagger.jsonhttps://github.com/microsoft/PowerPlatformConnectors/pull/1971#discussion_r975679265:

@@ -0,0 +1,70 @@

+{
@ecsadmhttps://github.com/ecsadm please rename the file to apiDefinition.swagger.json

In certified-connectors/USB4SAP/apidefinition.swagger.jsonhttps://github.com/microsoft/PowerPlatformConnectors/pull/1971#discussion_r975740589:

@@ -0,0 +1,70 @@

+{

"swagger": "2.0",

"info": {

"title": "USB4SAP",

"version": "1.0",

"description": "Universal Synch Bridge for SAP: One API for all SAP integration, analytics and UI needs. Simplify modern analytics, apps and automations. Provision SAP data, insights and automation On-demand.",

"contact":{

 "name": "Ecoservity",

 "url" : "https://www.ecoservity.com/#contact",

 "email"<EMAIL_ADDRESS>

}

},

"host" : "http://<IP_ADDRESS>:8000",

@ecsadmhttps://github.com/ecsadm the host must be a valid URI for production environment. Test or staging environments are not allowed.

In certified-connectors/USB4SAP/apidefinition.swagger.jsonhttps://github.com/microsoft/PowerPlatformConnectors/pull/1971#discussion_r975741282:

     {

       "name": "$format",

       "in": "query",

       "required": false,

       "type": "string",

       "x-example": "json"

     }

   ],

   "responses": {

     "200": {

       "description" : "OK",

       "schema" : {

         "$ref" : "#definitions/Message/"

       }

     },

@ecsadmhttps://github.com/ecsadm please make sure that the formatting and indentation are correct in the file.

In certified-connectors/USB4SAP/apidefinition.swagger.jsonhttps://github.com/microsoft/PowerPlatformConnectors/pull/1971#discussion_r975744600:

       "type": "string",

       "x-example": "ObjectName eq 'T001W' and ObjectType eq 'T' and Delimiter eq '|' and ImportGeneric eq 'ALVV-MG' and DataDest eq '0:0|' "

     },

     {

       "name": "$format",

       "in": "query",

       "required": false,

       "type": "string",

       "x-example": "json"

     }

   ],

   "responses": {

     "200": {

       "description" : "OK",

       "schema" : {

         "$ref" : "#definitions/Message/"

@ecsadmhttps://github.com/ecsadm you haven't defined Message to reference it. Please refer to coding standardshttps://learn.microsoft.com/en-us/connectors/custom-connectors/coding-standards#definitions-and-parameters if you want to use references or define a schema here. For more examples you can also see connector sampleshttps://learn.microsoft.com/en-us/connectors/custom-connectors/samples.

In certified-connectors/USB4SAP/apidefinition.swagger.jsonhttps://github.com/microsoft/PowerPlatformConnectors/pull/1971#discussion_r975747211:

"title": "USB4SAP",

"version": "1.0",

"description": "Universal Synch Bridge for SAP: One API for all SAP integration, analytics and UI needs. Simplify modern analytics, apps and automations. Provision SAP data, insights and automation On-demand.",

"contact":{

 "name": "Ecoservity",

 "url" : "https://www.ecoservity.com/#contact",

 "email"<EMAIL_ADDRESS>

}

},

"host" : "http://<IP_ADDRESS>:8000",

"paths": {

"/sap/opu/odata/ECOS/OBJ2CLOUD_V2_SRV/ET_DatasetSet": {

 "GET": {

   "summary": "GET call to extract metadata & data from SAP data objects",

@ecsadmhttps://github.com/ecsadm & sign is not allowed here, one of the checks is failing because of it. Please replace it by and.
Please see English strings recommendationshttps://docs.microsoft.com/en-us/connectors/custom-connectors/certification-submission#create-quality-english-language-strings or connector string guidancehttps://docs.microsoft.com/en-us/connectors/custom-connectors/connector-string-guidance#connector-info for more information about strings.

In certified-connectors/USB4SAP/apidefinition.swagger.jsonhttps://github.com/microsoft/PowerPlatformConnectors/pull/1971#discussion_r975748442:

     }

   ,

   "500" : {

       "description" : "Application Error"

     }

   ,

     "default": {

       "description": "Swagger generated by Ecoservity"

     }

 }

}

},

"definitions": {}

+}
@ecsadmhttps://github.com/ecsadm x-ms-connector-metadata property is missing, please add it. You can refer to the templatehttps://github.com/microsoft/PowerPlatformConnectors/blob/dev/templates/certified-connectors/apiDefinition.swagger.json or connector sampleshttps://learn.microsoft.com/en-us/connectors/custom-connectors/samples for more information.
—
Reply to this email directly, view it on GitHubhttps://github.com/microsoft/PowerPlatformConnectors/pull/1971#pullrequestreview-1114270777, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A2Q3FZF3BQNMK3WWPVOWCZ3V7IHLZANCNFSM6AAAAAAQOSBR6Q.
You are receiving this because you were mentioned.Message ID: @.***>

Hello Egor, team,
The following edits have been made & committed on GitHub repository now.
Kindly confirm that this is completed now.
Thanks a ton,
Anupam Jaiswal
M<EMAIL_ADDRESS>| T: +1.2145199601
https://www.ecoservity.com/
[AIorK4y9ORf3HVxkZJze1bmxXE-tgEq0B1jlBM2DYsZ4KMhn4bvxGhDTKpomrSI4gK1nxJQFuaCpR5E]
From: Anupam Jaiswal @.>
Date: Tuesday, September 20, 2022 at 14:47
To: microsoft/PowerPlatformConnectors @.>, microsoft/PowerPlatformConnectors @.>
Cc: Mention @.>, Mridul Gupta @.***>
Subject: Re: [microsoft/PowerPlatformConnectors] USB4SAP (PR #1971)
Thanks Egor. We will action these comments and revert when ready.
++ Mridul.
Thanks a ton,
Anupam Jaiswal
M<EMAIL_ADDRESS>| T: +1.2145199601
https://www.ecoservity.com/
[AIorK4y9ORf3HVxkZJze1bmxXE-tgEq0B1jlBM2DYsZ4KMhn4bvxGhDTKpomrSI4gK1nxJQFuaCpR5E]
From: v-EgorKozhadei @.>
Date: Tuesday, September 20, 2022 at 14:40
To: microsoft/PowerPlatformConnectors @.>
Cc: Anupam Jaiswal @.>, Mention @.>
Subject: Re: [microsoft/PowerPlatformConnectors] USB4SAP (PR #1971)
@v-EgorKozhadei commented on this pull request.
Hello @ecsadmhttps://github.com/ecsadm,
Please check comments after the review.
Let us know if you have any questions or need help.

In certified-connectors/USB4SAP/Readme.mdhttps://github.com/microsoft/PowerPlatformConnectors/pull/1971#discussion_r975672079:

@@ -0,0 +1 @@

+# USB4SAP
USB4SAP is one single API for any SAP data source to be consumed as a REST or RFC enabled API
Publisher: Ecoservity
Prerequisites
User must have backend agent installed on the SAP system as described in the Deployment instructions below
User must enter a valid SAP user ID & password.
For REST based access, a NetWeaver Gateway or equivalent REST API provider should be connected to backend SAP system.
Follow this guide for prerequisites.
Supported Operations
This query supports GET operation from SAP backend to provision data from tables, views, reports, queries, ALV, CDS, or any other data container.
Obtaining Credentials
This API uses Basic Authentication
Known Issues and Limitations
->REST API supports data limits as specified under REST API protocols
->Large datasets extraction may result in time outs as configured in the REST API systems. In such cases, we recommend using the batch extraction method as supported by the solution
Deployment Instructions
-> Follow this link for the installation of ODDI for SAP.
@ecsadmhttps://github.com/ecsadm please make sure that the formatting is correct. File contents are in one single line right now. You can refer to the templatehttps://github.com/microsoft/PowerPlatformConnectors/blob/dev/templates/certified-connectors/readme.md?plain=1 to see an example of formatting.

In certified-connectors/USB4SAP/apiProperties.jsonhttps://github.com/microsoft/PowerPlatformConnectors/pull/1971#discussion_r975677181:

                   "tabIndex": 2

               },

               "description": "The access for this API",

               "displayName": "Basic",

               "tooltip": "Basic authentication used, No key is needed"

           }

       }

   },

   "iconBrandColor": "#cddd36",

   "capabilities": [

       "Provisioning live data from SAP",

       "Provisioning batch data from SAP"

   ],

   "publisher": "Ecoservity",

   "stackOwner": "Ecoservity"

@ecsadmhttps://github.com/ecsadm please make sure that formatting and indentation are correct in apiProperties and apiDefinitions files.

In certified-connectors/USB4SAP/apidefinition.swagger.jsonhttps://github.com/microsoft/PowerPlatformConnectors/pull/1971#discussion_r975678533:

@@ -0,0 +1,70 @@

+{

"swagger": "2.0",

"info": {

"title": "USB4SAP",

"version": "1.0",

"description": "Universal Synch Bridge for SAP: One API for all SAP integration, analytics and UI needs. Simplify modern analytics, apps and automations. Provision SAP data, insights and automation On-demand.",

@ecsadmhttps://github.com/ecsadm the word API is not allowed in the description. Please remove it. More information about the description can be found herehttps://docs.microsoft.com/en-us/connectors/custom-connectors/certification-submission#write-a-description-for-your-connector.

In certified-connectors/USB4SAP/apidefinition.swagger.jsonhttps://github.com/microsoft/PowerPlatformConnectors/pull/1971#discussion_r975678948:

@@ -0,0 +1,70 @@

+{

"swagger": "2.0",

"info": {

"title": "USB4SAP",

"version": "1.0",

"description": "Universal Synch Bridge for SAP: One API for all SAP integration, analytics and UI needs. Simplify modern analytics, apps and automations. Provision SAP data, insights and automation On-demand.",

"contact":{

 "name": "Ecoservity",

 "url" : "https://www.ecoservity.com/#contact",

 "email"<EMAIL_ADDRESS>

@ecsadmhttps://github.com/ecsadm please make sure that formatting and indentation are correct.

In certified-connectors/USB4SAP/apidefinition.swagger.jsonhttps://github.com/microsoft/PowerPlatformConnectors/pull/1971#discussion_r975679265:

@@ -0,0 +1,70 @@

+{
@ecsadmhttps://github.com/ecsadm please rename the file to apiDefinition.swagger.json

In certified-connectors/USB4SAP/apidefinition.swagger.jsonhttps://github.com/microsoft/PowerPlatformConnectors/pull/1971#discussion_r975740589:

@@ -0,0 +1,70 @@

+{

"swagger": "2.0",

"info": {

"title": "USB4SAP",

"version": "1.0",

"description": "Universal Synch Bridge for SAP: One API for all SAP integration, analytics and UI needs. Simplify modern analytics, apps and automations. Provision SAP data, insights and automation On-demand.",

"contact":{

 "name": "Ecoservity",

 "url" : "https://www.ecoservity.com/#contact",

 "email"<EMAIL_ADDRESS>

}

},

"host" : "http://<IP_ADDRESS>:8000",

@ecsadmhttps://github.com/ecsadm the host must be a valid URI for production environment. Test or staging environments are not allowed.

In certified-connectors/USB4SAP/apidefinition.swagger.jsonhttps://github.com/microsoft/PowerPlatformConnectors/pull/1971#discussion_r975741282:

     {

       "name": "$format",

       "in": "query",

       "required": false,

       "type": "string",

       "x-example": "json"

     }

   ],

   "responses": {

     "200": {

       "description" : "OK",

       "schema" : {

         "$ref" : "#definitions/Message/"

       }

     },

@ecsadmhttps://github.com/ecsadm please make sure that the formatting and indentation are correct in the file.

In certified-connectors/USB4SAP/apidefinition.swagger.jsonhttps://github.com/microsoft/PowerPlatformConnectors/pull/1971#discussion_r975744600:

       "type": "string",

       "x-example": "ObjectName eq 'T001W' and ObjectType eq 'T' and Delimiter eq '|' and ImportGeneric eq 'ALVV-MG' and DataDest eq '0:0|' "

     },

     {

       "name": "$format",

       "in": "query",

       "required": false,

       "type": "string",

       "x-example": "json"

     }

   ],

   "responses": {

     "200": {

       "description" : "OK",

       "schema" : {

         "$ref" : "#definitions/Message/"

@ecsadmhttps://github.com/ecsadm you haven't defined Message to reference it. Please refer to coding standardshttps://learn.microsoft.com/en-us/connectors/custom-connectors/coding-standards#definitions-and-parameters if you want to use references or define a schema here. For more examples you can also see connector sampleshttps://learn.microsoft.com/en-us/connectors/custom-connectors/samples.

In certified-connectors/USB4SAP/apidefinition.swagger.jsonhttps://github.com/microsoft/PowerPlatformConnectors/pull/1971#discussion_r975747211:

"title": "USB4SAP",

"version": "1.0",

"description": "Universal Synch Bridge for SAP: One API for all SAP integration, analytics and UI needs. Simplify modern analytics, apps and automations. Provision SAP data, insights and automation On-demand.",

"contact":{

 "name": "Ecoservity",

 "url" : "https://www.ecoservity.com/#contact",

 "email"<EMAIL_ADDRESS>

}

},

"host" : "http://<IP_ADDRESS>:8000",

"paths": {

"/sap/opu/odata/ECOS/OBJ2CLOUD_V2_SRV/ET_DatasetSet": {

 "GET": {

   "summary": "GET call to extract metadata & data from SAP data objects",

@ecsadmhttps://github.com/ecsadm & sign is not allowed here, one of the checks is failing because of it. Please replace it by and.
Please see English strings recommendationshttps://docs.microsoft.com/en-us/connectors/custom-connectors/certification-submission#create-quality-english-language-strings or connector string guidancehttps://docs.microsoft.com/en-us/connectors/custom-connectors/connector-string-guidance#connector-info for more information about strings.

In certified-connectors/USB4SAP/apidefinition.swagger.jsonhttps://github.com/microsoft/PowerPlatformConnectors/pull/1971#discussion_r975748442:

     }

   ,

   "500" : {

       "description" : "Application Error"

     }

   ,

     "default": {

       "description": "Swagger generated by Ecoservity"

     }

 }

}

},

"definitions": {}

+}
@ecsadmhttps://github.com/ecsadm x-ms-connector-metadata property is missing, please add it. You can refer to the templatehttps://github.com/microsoft/PowerPlatformConnectors/blob/dev/templates/certified-connectors/apiDefinition.swagger.json or connector sampleshttps://learn.microsoft.com/en-us/connectors/custom-connectors/samples for more information.
—
Reply to this email directly, view it on GitHubhttps://github.com/microsoft/PowerPlatformConnectors/pull/1971#pullrequestreview-1114270777, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A2Q3FZF3BQNMK3WWPVOWCZ3V7IHLZANCNFSM6AAAAAAQOSBR6Q.
You are receiving this because you were mentioned.Message ID: @.***>

Hello @ecsadm,
Thank you for your message!
Unfortunately, I can't see the latest changes in the Pull Request.
Please make sure that you have committed and pushed the latest changes to your branch. The Pull Request will be updated automatically.
Please let us know if you have any questions or need any help.

Hey Egor,
I am not able to push the changes to the branch. I tried following the steps from the recorded session but it is rejecting the request. I am sharing the screenshot with you. Please let me know if we can connect over a 30 mins on Monday and complete the request.
Thanks,
Mridul Gupta
From: Anupam Jaiswal @.>
Date: Tuesday, 27 September 2022 at 4:15 PM
To: microsoft/PowerPlatformConnectors @.>, microsoft/PowerPlatformConnectors @.>
Cc: Mention @.>, Mridul Gupta @.***>
Subject: Re: [microsoft/PowerPlatformConnectors] USB4SAP (PR #1971)
Sure Egor, let me confirm with Mridul & revert soon.
Thanks a ton,
Anupam Jaiswal
M<EMAIL_ADDRESS>| T: +1.2145199601
https://www.ecoservity.com/
[AIorK4y9ORf3HVxkZJze1bmxXE-tgEq0B1jlBM2DYsZ4KMhn4bvxGhDTKpomrSI4gK1nxJQFuaCpR5E]
From: v-EgorKozhadei @.>
Date: Tuesday, September 27, 2022 at 09:52
To: microsoft/PowerPlatformConnectors @.>
Cc: Anupam Jaiswal @.>, Mention @.>
Subject: Re: [microsoft/PowerPlatformConnectors] USB4SAP (PR #1971)
Hello @ecsadmhttps://github.com/ecsadm,
Thank you for your message!
Unfortunately, I can't see the latest changes in the Pull Request.
Please make sure that you have committed and pushed the latest changes to your branch. The Pull Request will be updated automatically.
Please let us know if you have any questions or need any help.
—
Reply to this email directly, view it on GitHubhttps://github.com/microsoft/PowerPlatformConnectors/pull/1971#issuecomment-1259625691, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A2Q3FZGGQZ5JA5JDWSSWW7TWAMC3NANCNFSM6AAAAAAQOSBR6Q.
You are receiving this because you were mentioned.Message ID: @.***>

Hello @ecsadm,
I hope you are doing well.
I am sorry to hear that you are having issues with updating your connector artifacts.
May I ask you please to try following the steps below.

Navigate to your forked repository "PowerPlatformConnectors"
Run these commands:

git checkout -b ecsadm-dev dev
git pull https://github.com/ecsadm/PowerPlatformConnectors.git dev
git checkout dev
git merge --no-ff ecsadm-dev
git push origin dev

I hope this helps.
I look forward to hearing from you.
Thank you so much.

++mridul
Thanks a ton,
Anupam Jaiswal
M<EMAIL_ADDRESS>| T: +1.2145199601
https://www.ecoservity.com/
[AIorK4y9ORf3HVxkZJze1bmxXE-tgEq0B1jlBM2DYsZ4KMhn4bvxGhDTKpomrSI4gK1nxJQFuaCpR5E]
From: Amjed Ayoub @.>
Date: Friday, October 7, 2022 at 00:38
To: microsoft/PowerPlatformConnectors @.>
Cc: Anupam Jaiswal @.>, Mention @.>
Subject: Re: [microsoft/PowerPlatformConnectors] USB4SAP (PR #1971)
Hello @ecsadmhttps://github.com/ecsadm,
I hope you are doing well.
I am sorry to hear that you are having issues with updating your connector artifacts.
May I ask you please to try following the steps below.

Navigate to your forked repository "PowerPlatformConnectors"
Run these commands:

git checkout -b ecsadm-dev dev
git pull https://github.com/ecsadm/PowerPlatformConnectors.git dev
git checkout dev
git merge --no-ff ecsadm-dev
git push origin dev
I hope this helps.
I look forward to hearing from you.
Thank you so much.
—
Reply to this email directly, view it on GitHubhttps://github.com/microsoft/PowerPlatformConnectors/pull/1971#issuecomment-1271132096, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A2Q3FZDKVG2ILA3DFNXJG7LWB6ZLZANCNFSM6AAAAAAQOSBR6Q.
You are receiving this because you were mentioned.Message ID: @.***>

Thx Amjed,
We were able to update the code & here is the screenshot.
Kindly confirm that the final changes are reviewed, if there are any questions please indicate & we will get into a call to complete this step.
@.***
Thanks a ton,
Anupam Jaiswal
M<EMAIL_ADDRESS>| T: +1.2145199601
https://www.ecoservity.com/
[AIorK4y9ORf3HVxkZJze1bmxXE-tgEq0B1jlBM2DYsZ4KMhn4bvxGhDTKpomrSI4gK1nxJQFuaCpR5E]
From: Anupam Jaiswal @.>
Date: Friday, October 7, 2022 at 17:25
To: microsoft/PowerPlatformConnectors @.>, microsoft/PowerPlatformConnectors @.>
Cc: Mention @.>, Mridul Gupta @.***>
Subject: Re: [microsoft/PowerPlatformConnectors] USB4SAP (PR #1971)
++mridul
Thanks a ton,
Anupam Jaiswal
M<EMAIL_ADDRESS>| T: +1.2145199601
https://www.ecoservity.com/
[AIorK4y9ORf3HVxkZJze1bmxXE-tgEq0B1jlBM2DYsZ4KMhn4bvxGhDTKpomrSI4gK1nxJQFuaCpR5E]
From: Amjed Ayoub @.>
Date: Friday, October 7, 2022 at 00:38
To: microsoft/PowerPlatformConnectors @.>
Cc: Anupam Jaiswal @.>, Mention @.>
Subject: Re: [microsoft/PowerPlatformConnectors] USB4SAP (PR #1971)
Hello @ecsadmhttps://github.com/ecsadm,
I hope you are doing well.
I am sorry to hear that you are having issues with updating your connector artifacts.
May I ask you please to try following the steps below.

Navigate to your forked repository "PowerPlatformConnectors"
Run these commands:

git checkout -b ecsadm-dev dev
git pull https://github.com/ecsadm/PowerPlatformConnectors.git dev
git checkout dev
git merge --no-ff ecsadm-dev
git push origin dev
I hope this helps.
I look forward to hearing from you.
Thank you so much.
—
Reply to this email directly, view it on GitHubhttps://github.com/microsoft/PowerPlatformConnectors/pull/1971#issuecomment-1271132096, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A2Q3FZDKVG2ILA3DFNXJG7LWB6ZLZANCNFSM6AAAAAAQOSBR6Q.
You are receiving this because you were mentioned.Message ID: @.***>

Sure Egor, let me confirm with Mridul & revert soon.
Thanks a ton,
Anupam Jaiswal
M<EMAIL_ADDRESS>| T: +1.2145199601
https://www.ecoservity.com/
[AIorK4y9ORf3HVxkZJze1bmxXE-tgEq0B1jlBM2DYsZ4KMhn4bvxGhDTKpomrSI4gK1nxJQFuaCpR5E]
From: v-EgorKozhadei @.>
Date: Tuesday, September 27, 2022 at 09:52
To: microsoft/PowerPlatformConnectors @.>
Cc: Anupam Jaiswal @.>, Mention @.>
Subject: Re: [microsoft/PowerPlatformConnectors] USB4SAP (PR #1971)
Hello @ecsadmhttps://github.com/ecsadm,
Thank you for your message!
Unfortunately, I can't see the latest changes in the Pull Request.
Please make sure that you have committed and pushed the latest changes to your branch. The Pull Request will be updated automatically.
Please let us know if you have any questions or need any help.
—
Reply to this email directly, view it on GitHubhttps://github.com/microsoft/PowerPlatformConnectors/pull/1971#issuecomment-1259625691, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A2Q3FZGGQZ5JA5JDWSSWW7TWAMC3NANCNFSM6AAAAAAQOSBR6Q.
You are receiving this because you were mentioned.Message ID: @.***>

Hi everyone,
We tried to push our updated files to the branch but the files got corrupted and as also highlighted by Egor, we can see “\” in all the three files.
I am attaching the final version of our files and request you to please push the changes to the branch on our behalf or get on a quick call to guide us to resolve this. We aim to complete this process as early as possible.
Please let me know if we can connect sometime today i.e. on 13th October to close this.
Thanks,
Mridul Gupta
Ecoservity
From: Anupam Jaiswal @.>
Date: Tuesday, 11 October 2022 at 2:32 PM
To:
Cc: Mridul Gupta @.>
Subject: Re: [microsoft/PowerPlatformConnectors] USB4SAP (PR #1971)
Lets discuss it today
Thanks a ton,
Anupam Jaiswal
M<EMAIL_ADDRESS>| T: +1.2145199601
https://www.ecoservity.com/
[AIorK4y9ORf3HVxkZJze1bmxXE-tgEq0B1jlBM2DYsZ4KMhn4bvxGhDTKpomrSI4gK1nxJQFuaCpR5E]
From: Amjed Ayoub @.>
Date: Monday, October 10, 2022 at 12:48
To: microsoft/PowerPlatformConnectors @.>
Cc: Anupam Jaiswal @.>, Mention @.>
Subject: Re: [microsoft/PowerPlatformConnectors] USB4SAP (PR #1971)
@Amjed-Ayoub requested changes on this pull request.

In certified-connectors/USB4SAP/Readme.mdhttps://github.com/microsoft/PowerPlatformConnectors/pull/1971#discussion_r991521411:

@@ -0,0 +1,53 @@

+# Title
+\
Hi @ecsadmhttps://github.com/ecsadm,
Thank you so much for working hard on this.
May I ask you please to remove all "" from the readme file.

In certified-connectors/USB4SAP/apidefinition.swagger.jsonhttps://github.com/microsoft/PowerPlatformConnectors/pull/1971#discussion_r991522761:

@@ -0,0 +1,286 @@

+{\rtf1\ansi\ansicpg1252\cocoartf2639
+\cocoatextscaling0\cocoaplatform0{\fonttbl\f0\fswiss\fcharset0 Helvetica;}
+{\colortbl;\red255\green255\blue255;}
+{*\expandedcolortbl;;}
+\paperw11900\paperh16840\margl1440\margr1440\vieww20480\viewh12800\viewkind1
+\pard\tx720\tx1440\tx2160\tx2880\tx3600\tx4320\tx5040\tx5760\tx6480\tx7200\tx7920\tx8640\pardirnatural\partightenfactor0

+\f0\fs24 \cf0 { \
Please remove all the above lines and all "" for your files

In certified-connectors/USB4SAP/apidefinition.swagger.jsonhttps://github.com/microsoft/PowerPlatformConnectors/pull/1971#discussion_r991523013:

+\

   \{ \

+\

       "propertyName": "Categories", \

+\

       "propertyValue": "B2B Analytics" \

+\

   \} \

+\

] \

+\
+} \
+\

{ \

+\

"swagger": "2.0", \

It looks like you copied the swagger file twice :-)

In certified-connectors/USB4SAP/apiProperties.jsonhttps://github.com/microsoft/PowerPlatformConnectors/pull/1971#discussion_r991523991:

@@ -0,0 +1,58 @@

+{\rtf1\ansi\ansicpg1252\cocoartf2639
+\cocoatextscaling0\cocoaplatform0{\fonttbl\f0\fswiss\fcharset0 Helvetica;}
+{\colortbl;\red255\green255\blue255;}
+{*\expandedcolortbl;;}
+\paperw11900\paperh16840\margl1440\margr1440\vieww12200\viewh14380\viewkind1
+\pard\tx720\tx1440\tx2160\tx2880\tx3600\tx4320\tx5040\tx5760\tx6480\tx7200\tx7920\tx8640\pardirnatural\partightenfactor0

+\f0\fs24 \cf0 {\
Please remove all the above lines and all "" for your files
—
Reply to this email directly, view it on GitHubhttps://github.com/microsoft/PowerPlatformConnectors/pull/1971#pullrequestreview-1136358962, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A2Q3FZDWLO66OYBCKWCYF2LWCRJHHANCNFSM6AAAAAAQOSBR6Q.
You are receiving this because you were mentioned.Message ID: @.***>

Hi @@.***>,
Thank you so much for reaching out.
Yes definitely we can meet and help you with this request.
Please see our availability below.
Thursday October 13th at 9 am or at 3 pm PST.
Please let me know what time works for you.
Thank you so much again.
Best regards,
Amjed Ayoub.
From: Mridul Gupta @.>
Sent: Wednesday, October 12, 2022 5:22 PM
To: Amjed Ayoub (TEKsystems, Inc.) @.>; microsoft/PowerPlatformConnectors @.>
Cc: Anupam Jaiswal @.>
Subject: [EXTERNAL] Re: [microsoft/PowerPlatformConnectors] USB4SAP (PR #1971)
Hi everyone,
We tried to push our updated files to the branch but the files got corrupted and as also highlighted by Egor, we can see "" in all the three files.
I am attaching the final version of our files and request you to please push the changes to the branch on our behalf or get on a quick call to guide us to resolve this. We aim to complete this process as early as possible.
Please let me know if we can connect sometime today i.e. on 13th October to close this.
Thanks,
Mridul Gupta
Ecoservity
From: Anupam Jaiswal @.>
Date: Tuesday, 11 October 2022 at 2:32 PM
To:
Cc: Mridul Gupta @.>
Subject: Re: [microsoft/PowerPlatformConnectors] USB4SAP (PR #1971)
Lets discuss it today
Thanks a ton,
Anupam Jaiswal
M<EMAIL_ADDRESS>| T: +1.2145199601
https://www.ecoservity.com/https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.ecoservity.com%2F&data=05|01|v-amjedayoub%40microsoft.com|e60c3e6312194301c76308daacb0f6de|72f988bf86f141af91ab2d7cd011db47|1|0|638012174699395879|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=VVCUBmqulgQrgk78csQdNO3zad%2F%2BM1W8ZVzgC8eKBuA%3D&reserved=0
[AIorK4y9ORf3HVxkZJze1bmxXE-tgEq0B1jlBM2DYsZ4KMhn4bvxGhDTKpomrSI4gK1nxJQFuaCpR5E]
From: Amjed Ayoub @.>
Date: Monday, October 10, 2022 at 12:48
To: microsoft/PowerPlatformConnectors @.>
Cc: Anupam Jaiswal @.>, Mention @.>
Subject: Re: [microsoft/PowerPlatformConnectors] USB4SAP (PR #1971)
@Amjed-Ayoub requested changes on this pull request.

In certified-connectors/USB4SAP/Readme.mdhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FPowerPlatformConnectors%2Fpull%2F1971%23discussion_r991521411&data=05|01|v-amjedayoub%40microsoft.com|e60c3e6312194301c76308daacb0f6de|72f988bf86f141af91ab2d7cd011db47|1|0|638012174699395879|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=UNOCrAj4Z5cspwW3css24t42zolc03%2BlFd6pGiyuZDA%3D&reserved=0:

@@ -0,0 +1,53 @@

+# Title
+\
Hi @ecsadmhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fecsadm&data=05|01|v-amjedayoub%40microsoft.com|e60c3e6312194301c76308daacb0f6de|72f988bf86f141af91ab2d7cd011db47|1|0|638012174699395879|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=h8QqF3HUiHO7RSOD15lXjxmLVgqyf2bzrJyRsqn%2Fux8%3D&reserved=0,
Thank you so much for working hard on this.
May I ask you please to remove all "" from the readme file.

In certified-connectors/USB4SAP/apidefinition.swagger.jsonhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FPowerPlatformConnectors%2Fpull%2F1971%23discussion_r991522761&data=05|01|v-amjedayoub%40microsoft.com|e60c3e6312194301c76308daacb0f6de|72f988bf86f141af91ab2d7cd011db47|1|0|638012174699395879|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=%2FN8DpDLULY2iGHFb1KmnxpcWbbVe5ZOh7QTgoxbVWdA%3D&reserved=0:

@@ -0,0 +1,286 @@

+{\rtf1\ansi\ansicpg1252\cocoartf2639
+\cocoatextscaling0\cocoaplatform0{\fonttbl\f0\fswiss\fcharset0 Helvetica;}
+{\colortbl;\red255\green255\blue255;}
+{*\expandedcolortbl;;}
+\paperw11900\paperh16840\margl1440\margr1440\vieww20480\viewh12800\viewkind1
+\pard\tx720\tx1440\tx2160\tx2880\tx3600\tx4320\tx5040\tx5760\tx6480\tx7200\tx7920\tx8640\pardirnatural\partightenfactor0

+\f0\fs24 \cf0 { \
Please remove all the above lines and all "" for your files

In certified-connectors/USB4SAP/apidefinition.swagger.jsonhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FPowerPlatformConnectors%2Fpull%2F1971%23discussion_r991523013&data=05|01|v-amjedayoub%40microsoft.com|e60c3e6312194301c76308daacb0f6de|72f988bf86f141af91ab2d7cd011db47|1|0|638012174699395879|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=BzHUxaoTLgud41kOgov7MetVQ0NaCTk8HJXbXbBuh0k%3D&reserved=0:

+\

   \{ \

+\

       "propertyName": "Categories", \

+\

       "propertyValue": "B2B Analytics" \

+\

   \} \

+\

] \

+\
+} \
+\

{ \

+\

"swagger": "2.0", \

It looks like you copied the swagger file twice :-)

In certified-connectors/USB4SAP/apiProperties.jsonhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FPowerPlatformConnectors%2Fpull%2F1971%23discussion_r991523991&data=05|01|v-amjedayoub%40microsoft.com|e60c3e6312194301c76308daacb0f6de|72f988bf86f141af91ab2d7cd011db47|1|0|638012174699395879|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=MXDUkirAid34StU0%2F1Lognsh3TKwrLTKOcVMeurAKzQ%3D&reserved=0:

@@ -0,0 +1,58 @@

+{\rtf1\ansi\ansicpg1252\cocoartf2639
+\cocoatextscaling0\cocoaplatform0{\fonttbl\f0\fswiss\fcharset0 Helvetica;}
+{\colortbl;\red255\green255\blue255;}
+{*\expandedcolortbl;;}
+\paperw11900\paperh16840\margl1440\margr1440\vieww12200\viewh14380\viewkind1
+\pard\tx720\tx1440\tx2160\tx2880\tx3600\tx4320\tx5040\tx5760\tx6480\tx7200\tx7920\tx8640\pardirnatural\partightenfactor0

+\f0\fs24 \cf0 {\
Please remove all the above lines and all "" for your files

Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FPowerPlatformConnectors%2Fpull%2F1971%23pullrequestreview-1136358962&data=05|01|v-amjedayoub%40microsoft.com|e60c3e6312194301c76308daacb0f6de|72f988bf86f141af91ab2d7cd011db47|1|0|638012174699395879|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=2ChScxaVljlf1LVQqzYRdOGPlvqoVBjNjTqU04TJTMs%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FA2Q3FZDWLO66OYBCKWCYF2LWCRJHHANCNFSM6AAAAAAQOSBR6Q&data=05|01|v-amjedayoub%40microsoft.com|e60c3e6312194301c76308daacb0f6de|72f988bf86f141af91ab2d7cd011db47|1|0|638012174699395879|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=jNdcyD%2FoLcX%2BXqc%2FzLOFdQFSpHPYEqb2tljwB3MrpIM%3D&reserved=0.
You are receiving this because you were mentioned.Message ID: @.***>

Hi, setting up this call as requested. Please extend the invite to anyone else who can help us complete this last step successfully.
Anupam

Microsoft Teams meeting
Join on your computer, mobile app or room device
Click here to join the meetinghttps://teams.microsoft.com/l/meetup-join/19%3Ameeting_MmU5M2NjNWYtYWE0Yi00NzUzLTkwN2EtMjRhMzc5NDY0NTJi%40thread.v2/0?context={"Tid"%3A"403d0a69-ae6c-459e-a989-d89a3141d440"%2C"Oid"%3A"c85d0d10-aa08-4cab-9552-322d567cc0c8"}
Meeting ID: 221 840 749 192
Passcode: FUsNXt
Download Teamshttps://www.microsoft.com/en-us/microsoft-teams/download-app | Join on the webhttps://www.microsoft.com/microsoft-teams/join-a-meeting
Or call in (audio only)
+1<PHONE_NUMBER>,,490335861#tel:+18722428851,,490335861#   United States, Chicago
Phone Conference ID: 490 335 861#
Find a local numberhttps://dialin.teams.microsoft.com/cbda6fa9-d11b-42ea-ae2e-c59979c7a4a7?id=490335861 | Reset PINhttps://dialin.teams.microsoft.com/usp/pstnconferencing
Learn Morehttps://aka.ms/JoinTeamsMeeting | Meeting @.***&messageId=0&language=en-US>

Hi @ecsadm, I hope you are doing well.
I am trying to schedule a quick call with you, may I ask you please to check your inbox.
Thank you so much.

Hello Amjed,
I setup the call & we are already in it.
Can you join the Teams now?
Click here to join the meetinghttps://teams.microsoft.com/l/meetup-join/19%3Ameeting_MmU5M2NjNWYtYWE0Yi00NzUzLTkwN2EtMjRhMzc5NDY0NTJi%40thread.v2/0?context={"Tid"%3A"403d0a69-ae6c-459e-a989-d89a3141d440"%2C"Oid"%3A"c85d0d10-aa08-4cab-9552-322d567cc0c8"}
Thanks a ton,
Anupam Jaiswal
M<EMAIL_ADDRESS>| T: +1.2145199601
https://www.ecoservity.com/
[AIorK4y9ORf3HVxkZJze1bmxXE-tgEq0B1jlBM2DYsZ4KMhn4bvxGhDTKpomrSI4gK1nxJQFuaCpR5E]
From: Amjed Ayoub @.>
Date: Thursday, October 13, 2022 at 11:01
To: microsoft/PowerPlatformConnectors @.>
Cc: Anupam Jaiswal @.>, Mention @.>
Subject: Re: [microsoft/PowerPlatformConnectors] USB4SAP (PR #1971)
Hi @ecsadmhttps://github.com/ecsadm, I hope you are doing well.
I am trying to schedule a quick call with you, may I ask you please to check your inbox.
Thank you so much.
—
Reply to this email directly, view it on GitHubhttps://github.com/microsoft/PowerPlatformConnectors/pull/1971#issuecomment-1277842850, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A2Q3FZEXMGGZM2B2E5UKU4TWDAW6DANCNFSM6AAAAAAQOSBR6Q.
You are receiving this because you were mentioned.Message ID: @.***>

@ecsadm thank you so much for the fix. May I ask you please to sign our CLA. Thank you so much

Thx Amjed,
I am trying to sign the CLA but it is not activated on Github? Screenshot below, please guide how to sign the CLA.
@.***
Thanks a ton,
Anupam Jaiswal
M<EMAIL_ADDRESS>| T: +1.2145199601
https://www.ecoservity.com/
[AIorK4y9ORf3HVxkZJze1bmxXE-tgEq0B1jlBM2DYsZ4KMhn4bvxGhDTKpomrSI4gK1nxJQFuaCpR5E]
From: Amjed Ayoub @.>
Date: Thursday, October 13, 2022 at 12:01
To: microsoft/PowerPlatformConnectors @.>
Cc: Anupam Jaiswal @.>, Mention @.>
Subject: Re: [microsoft/PowerPlatformConnectors] USB4SAP (PR #1971)
@ecsadmhttps://github.com/ecsadm thank you so much for the fix. May I ask you please to sign our CLA. Thank you so much
—
Reply to this email directly, view it on GitHubhttps://github.com/microsoft/PowerPlatformConnectors/pull/1971#issuecomment-1277917692, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A2Q3FZF4FWJ4SA7PGHEC2YDWDA56NANCNFSM6AAAAAAQOSBR6Q.
You are receiving this because you were mentioned.Message ID: @.***>

@bot agree


Add signencrypt non-streaming interface

Expose SealSingle and OpenSingle (open to better names). This seems like a good fit for chat headers because it's less moving parts than the streamers.
It has 2 warts:

If you use both streaming and non-streaming with the same keys then using sequential nonces is a bad idea because they are likely to be the same. I think this is true even if you change the signaturePrefix.
The ciphertext is the same for streaming and non-streaming (with the 'same' nonce) for messages that are too short to get chunked. This is potentially confusing.

Nope, we're going to use SealWhole instead which does chunking. Because it's already there and doesn't have these nonce gotchas.


Expand discussion of user defined exceptions

The problem
The https://docs.perl6.org/language/exceptions only touches on user defined exception classes in a single example and not in the text.
There are several things that are worth documenting about user defined exceptions not least why the X:: is somewhat special and consequently naming is worth consideration,  See e.g. https://github.com/rakudo/rakudo/issues/3011
Suggestions
Create a new section for "User Defined Exceptions" which describes why you might want to define your own exception and how you might go about creating it.
There should be some discussion of naming and specifically regarding the X::: namespace and why you may want to either avoid it or use some means to avoid name collisions.

Thanks! I don't know if that applies to CX too :-)


Union status codes and other response improvements

This PR will:

Allow a property decorated with @statusCode to specify a union of values.

Allow multiple properties decorated with @statusCode in a response - values will be unioned.

Allow @statusCode to be specified in the parent model of a response.

Validate the value(s) of @statusCode - diagnostics issued for any invalid values

Must be numeric or string literal
Must be in the range 100 <= x < 600 or [1-5]XX or default

Issue diagnostics for duplicate response (status code) (not silently drop)

Use explicit status code for empty response (not force to 204)

Allow contentType header to specify a union of values.

Allow contentType to be specified in the parent model of a response

Validate contentType - diagnostics issued for any invalid values

Must be string literal or union of string literals

Generate body as empty schema if specified on @body decorated property

Do not generate schema if no @body decorated property and all props response metadata

Set response description derived from status code when no @doc on return type

@timotheeguerin Thank you for your comments. I think have answered or addressed all of them


Cargo 0.72.0 was yanked from crates.io, breaking the patch that was just tagged as 2.0.1.

This issue, https://github.com/esp-rs/espflash/pull/445, was used to patch cargo-espflash to require cargo 0.72.0. Version 0.72.0 of cargo has since been yanked, breaking builds of espflash/cargo-espflash in tag v2.0.1.
I was able to successfully execute cargo install --path . after reverting 0.72.0 to 0.71.0 in cargo-espflash/Cargo.toml and did not encounter the error that originally led to the patch being submitted.

You can still install using the --locked flag for the time being, as well.

A new version of cargo, 0.72.1, has been published.


Add support for new Qualifications API

It would be great if we can add support for Qualifications API.
https://docs.voucherify.io/reference/check-eligibility

Hello @akshitkrnagpal please check newest version of SDK - 2.7.0 where support for Qualifications API has been added:
https://github.com/voucherifyio/voucherify-js-sdk/blob/main/packages/sdk/CHANGELOG.md#270


Tracks stuck in "Processing"

I have 6 tracks that have been stuck in "PROCESSING" for 4 days.
Is there a problem, or can I expect more than 4 days to elapse?

The servers that process uploaded sequences have been overloaded for weeks. @martijnv-telenav said they recently added more servers so it should hopefully start catching up. If my sequences are any indication, it is currently processing uploads from late November. Some I uploaded on November 23rd are processed but ones from November 29th and all more recent uploads are still stuck in processing.

Thank you for the information.
I will close th issue, and eagerly await for my traces to be processed.


Document service binding parameters

Addresses https://github.com/spring-cloud/spring-cloud-deployer-cloudfoundry/issues/261
Note - I was not able to build the docs locally (same issue on master), so possibly needs some format tweaking.

LGTM, merging into 1.7.x

Cherry-pick and merged into 1.7.x as ac35183

Documentation applied to SCDF 2.x (single server) as https://github.com/spring-cloud/spring-cloud-dataflow/commit/cc353cde81670f1498668f49f38783f43404b1b8


Copying and pasting/replacing fx chain with video-fx blur fails

copying and pasting fx chain with video fx gaussian blur or the low quality blur fail to syntax error in the blur effect code

leads to

in the fx code (when trying to save with ctrl-s in the target item
The code is somehow altered on the was which leads to syntax error. The first thing you see is that the blur fx is not working anymore in the target item

Fixing, thanks! Line with unbalanced quotes are being discarded. In the case of those blur presets it's colorspace=='RGBA' ? " and ",flag.

Great - thanks for the quick response!


Nick: Watch ecorprealestate.com

Nick requests the watch of the watch_keyword ecorprealestate\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

Approved by Jeff Schaller in Charcoal HQ


shim executor: clean state dir if newProcess() failed

process state dir was not removed when newProcess() failed
Some defer func(){if err != nil } statements was not effective due to scopes of err. Such statements is hard to maintain. Probably they should be replaced with better code in the future.

Signed-off-by: Akihiro Suda<EMAIL_ADDRESS>

LGTM


Switching AAD when having an on-premise agent

When switching Azure AD's, does anything have to be done with for an on-premise agent?
Obviously we have an on-premise agent and, I think, it connects with a PAT. Because these need to be refreshed, this would imply that the PAT for the agent needs to be refreshed as well.
Could you please clear this up for me?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 98f0caaf-2697-c506-339b-2dea64233e48
Version Independent ID: 7cd2ea02-2079-85d0-09e0-a90af59937d9
Content: Switch to another Azure Active Directory - Azure DevOps Services
Content Source: docs/organizations/accounts/change-azure-ad-connection.md
Product: devops
Technology: devops-accounts
GitHub Login: @chcomley
Microsoft Alias: chcomley

Hi @twildeman, Thanks for reaching out. A user with appropriate permissions uses their PAT to register an agent with the service. This is a one-time operation and the PAT used to register the agent is no longer used or needed afterward. Further communication between the agent and the service happens through internal tokens and shouldn't depend on changing the Azure AD in the service. In other words, the identity and tokens are managed completely within Azure DevOps, so switching Azure ADs should have no effect. I'm closing this issue, however if you have any further questions please @mention me. Have a great day!


HDFS-15959 : add support for digest authentication in ZKDelegationTokenSecretManager

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 38s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
34m 14s

trunk passed

+1 :green_heart:
compile
20m 57s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
18m  1s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
checkstyle
1m  6s

trunk passed

+1 :green_heart:
mvnsite
1m 32s

trunk passed

+1 :green_heart:
javadoc
1m  4s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 36s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
spotbugs
2m 22s

trunk passed

+1 :green_heart:
shadedclient
15m 29s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 53s

the patch passed

+1 :green_heart:
compile
20m  7s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

-1 :x:
javac
20m  7s
/results-compile-javac-root-jdkUbuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04.txt
root-jdkUbuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 generated 1 new + 1932 unchanged - 0 fixed = 1933 total (was 1932)

+1 :green_heart:
compile
18m  7s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

-1 :x:
javac
18m  7s
/results-compile-javac-root-jdkPrivateBuild-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08.txt
root-jdkPrivateBuild-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08 with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08 generated 1 new + 1827 unchanged - 0 fixed = 1828 total (was 1827)

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m  5s
/results-checkstyle-hadoop-common-project_hadoop-common.txt
hadoop-common-project/hadoop-common: The patch generated 9 new + 12 unchanged - 0 fixed = 21 total (was 12)

+1 :green_heart:
mvnsite
1m 30s

the patch passed

+1 :green_heart:
javadoc
1m  2s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 40s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
spotbugs
2m 29s

the patch passed

+1 :green_heart:
shadedclient
15m 43s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
17m 32s

hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 57s

The patch does not generate ASF License warnings.

178m 33s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2888/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2888

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 573308fecc1a 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / d168f21904c5fe846483a1ed73f25bb1064e5246

Default Java
Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2888/1/testReport/

Max. process+thread count
1378 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2888/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.


Default new talks to "seminar"

Reorder talk types to put most common first
Move setting of form defaults from view to controller

Closes #112.

👌 perfevt

Lol or perfect


Allow setting log level for mindev ruletype test

Summary
I was debugging a ruletype change and found it handy to have the engine
debug logs dumped onto the console.
This patch adds a new parameter --log-level that defaults to error
and lets you set the log level for the evaluation of the engine.
Change Type

[ ] Bug fix (resolves an issue without affecting existing features)
[x] Feature (adds new functionality without breaking changes)
[ ] Breaking change (may impact existing functionalities or require documentation updates)
[ ] Documentation (updates or additions to documentation)
[ ] Refactoring or test improvements (no bug fixes or new functionality)

Testing
AUTH_TOKEN=topsecret REGO_ENABLE_PRINT=true go run cmd/dev/main.go ruletype test --profile /Users/jakub/devel/playground/codeql-python.yaml --rule-type /Users/jakub/devel/minder-rules-and-profiles/rule-types/github/codeql_enabled.yaml --entity /Users/jakub/devel/playground/repository.yaml --log-level=debug

Review Checklist:

[x] Reviewed my own code for quality and clarity.
[ ] Added comments to complex or tricky code sections.
[ ] Updated any affected documentation.
[ ] Included tests that validate the fix or feature.
[ ] Checked that related changes are merged.

coverage: 48.193% (+0.01%) from 48.181%
when pulling 1aab9fc070915a3b5d97a555af848dce36a5e0c9 on jhrozek:mindev_logger
into c77ed4482e59b9317433c73b91b87054f003feec on stacklok:main.


Express App Fails to package [create-react-app]

Similar problem to https://github.com/zeit/pkg/issues/158 but I'm using Jade for my application.
$ node --version
v7.10.1

$ pkg --version
4.2.2

Main difference from #158 is here
app
  .set('views', path.join(__dirname, 'views'))
  .set('view engine', 'jade')

Error message:
Error: Failed to lookup view "error" in views directory

Can you tell me where your app.js/index.js is located? And where is your 'views' directory located?
In #158 my folder structure was "app/app.js" and "views/partials" so I had to use '..' in path.join().
Have you set your views directory in the package.json file as an asset?

I've been using the default create-react-app folder structure, without any nested folders for any of the source code.

So is your views folder on the same level as your "src" folder? And you don't have partials or layouts right?

Yes

Okay., try to change your
app.set('views', path.join(__dirname, 'views'))
to this:
app.set('views', path.join(__dirname, '..', 'views'))
and don't forget to set views/**/* to you "pkg" area in package.json:
"pkg": { "scripts": [], "assets": ["views/**/*"] }

Okay I got it. Apparently I have to pass my package.json as a config

I'm having the same issue.
Apparently I have to pass my package.json as a config
What do you mean by this?

Usage
npm install -g pkg
After installing it, run pkg --help without arguments to see list of options.
The entrypoint of your project is a mandatory CLI argument. It may be:
Path to entry file. Suppose it is /path/app.js, then packaged app will work the same way as node /path/app.js
Path to package.json. Pkg will follow bin property of the specified package.json and use it as entry file.
Path to directory. Pkg will look for package.json in the specified directory. See above.


official site breaks down

What is the current behavior?
My browser: Google Chrome v93.0.4577.82

same

^

same

+1

For now you change the ts-loader version to "ts-loader": "8.3.0" in package.json to make it work.

Still down

Still down

same

same

+1

alive ?

ahooks may be another choice.

https://github.com/streamich/react-use/issues/1974


How to enable non-native pinch-to-zoom on mobile in viewer.html?

I am trying to use the PDF viewer in an <iframe> like this:
<meta name="viewport" content="width=device-width, initial-scale=1.0">
...
<iframe src="pdfjs-3.5.141-dist/web/viewer.html?file=%2F<?= $filename ?>" frameborder="0" style="height: 100%; width:100%;"></iframe>

However, when zooming in on iOS, it uses the native zoom from Safari/WebKit/UIkit, meaning the toolbar may disappear and the text gets blurry.
Is there a way to use the recently introduced pinch-to-zoom functionality on mobile devices in viewer.html? The merge #15886  mentioned in #2582 appears to be related, but I could not figure out how to use or enable it. Thanks.

Assuming that you're talking about the default viewer, i.e. https://github.com/mozilla/pdf.js#online-demo, then pinch-to-zoom should be enabled and working by default.[1]
Hence this is likely Safari being "helpful" and overriding our custom pinch-implementation, however please keep in mind that Firefox is the primary development target for this library.

[1] WFM, using a Windows 11 laptop with a touch-screen in both Mozilla Firefox and Google Chrome. Additionally it also works fine with Firefox for Android (on a phone).

The problem is the iframe which appears to prevent the pinch gesture from being passed on to the embedded document. Loading viewer.html directly without iframe solves this issue.
I wanted to avoid modifying the default viewer (favicon and title) by embedding it, but it looks like I will have to do so after all.

The problem is the iframe which appears to prevent the pinch gesture from being passed on to the embedded document. Loading viewer.html directly without iframe solves this issue.
I wanted to avoid modifying the default viewer (favicon and title) by embedding it, but it looks like I will have to do so after all.

@3rd3,
Have you considered disabling the zoom of the page that contains the iframe? something like:
<meta name="viewport" content="width=device-width, user-scalable=no" />


Docs on website use low contrast navigation

The docs website is very nice and I'm sure a lot of effort went into this.
One thing that should be improved is the low contrast navigation on the left - this is quite illegible making the site much harder to use.
In this screenshot, note how the main doc text on right is easily readable while the text in navigation is not:

Some reasons why low-contrast text is a problem for usability as well as accessibility:   https://www.nngroup.com/articles/low-contrast/

Good point! Would you be up for a PR to fix this?

I'm not a web developer so won't be doing a PR, but a simple adjustment of this light grey to darker grey may be enough.

Fixed by @agseijas in #1094.


sql/postgres: support operator class writing

How timely, I was just searching for this and ended up here. Really appreciate the great work of you guys.

@a8m
can we use this feature from ent side now?


RCTCxxModule incorrectly flagged as not exported module by RCTVerifyAllModulesExported

Is this a bug report?
Yes
Have you read the Bugs section of the Contributing to React Native Guide?
Yes
Environment

react-native -v: 0.45.1 / cli 2.0.1
node -v: v7.9.0
npm -v: 5.0.3
yarn --version (if you use Yarn): 0.24.6

Then, specify:

Target Platform: iOS
Development Operating System: macOS Sierra
Build tools: any supported Xcode version, any supported iOS version

Steps to Reproduce

Execute react-native init testproject
Open the Xcode project and hit run

Expected Behavior
No warnings should be logged to the Xcode console since we have the default setup.
Actual Behavior
In the Xcode log there is a warning about the RCTCxxModule not being exported:
2017-07-03 11:09:47.963 [warn][tid:main][RCTBridge.m:114] Class RCTCxxModule was not exported. Did you forget to use RCT_EXPORT_MODULE()?
2017-07-03 11:09:47.963285+0200 testproject[467:119661] Class RCTCxxModule was not exported. Did you forget to use RCT_EXPORT_MODULE()?

Reproducible Demo
Any newly created React-Native project using the CxxBridge has this issue.
Possible solution
The RCTVerifyAllModulesExported function uses the objc_copyClassList which also reports the RCTCxxModule. This triggers the warning that this module is not exported, but since the RCTCxxModule is merely a base class that can be used by real module implementation this is a false positive.
A possible solution would be to make an exception in RCTVerifyAllModulesExported for the RCTCxxModule so it will not be checked and the warning will not be produced.
Note: The warning will disappear when you create a module that subclasses RCTCxxModule since there is a check in place for that scenario. As long as there is no subclass yet this warning will pop up.

I stucked at this issue now. Any solution?

This issue described a warning logged to the Xcode console. It's annoying and a bit confusing, but you can just ignore it. It's not a compile error or other workflow blocking issue.
@TheRemjx01 maybe you can explain how you are "stuck" at this issue?

My App Freeze then
2017-09-04 14:30:55.610 [info][tid:main][RCTCxxBridge.mm:188] Initializing <RCTCxxBridge: 0x6000001b88e0> (parent: <RCTBridge: 0x6000000ab160>, executor: (null))
2017-09-04 14:30:55.644 [warn][tid:main][RCTBridge.m:114] Class RCTCxxModule was not exported. Did you forget to use RCT_EXPORT_MODULE()?
2017-09-04 14:30:55.669 [info][tid:main][RCTRootView.m:301] Running application ExampleProject ({
initialProps =     {
};
rootTag = 1;
})
2017-09-04 14:30:57.471 ExampleProject[10735:97004] -[NSTaggedPointerString unsignedIntValue]: unrecognized selector sent to instance 0xa303938303930327
2017-09-04 14:30:57.474 ExampleProject[10735:97004] *** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '-[NSTaggedPointerString unsignedIntValue]: unrecognized selector sent to instance 0xa303938303930327'
*** First throw call stack:
(
0   CoreFoundation                      0x000000010a193d4b __exceptionPreprocess + 171
1   libobjc.A.dylib                     0x000000010901721e objc_exception_throw + 48
2   CoreFoundation                      0x000000010a203f04 -[NSObject(NSObject) doesNotRecognizeSelector:] + 132
3   CoreFoundation                      0x000000010a119005 forwarding + 1013
4   CoreFoundation                      0x000000010a118b88 _CF_forwarding_prep_0 + 120
5   ExampleProject                      0x000000010841bd54 -[RCTMultipartStreamReader emitProgress:contentLength:final:callback:] + 244
6   ExampleProject                      0x000000010841c54a -[RCTMultipartStreamReader readAllPartsWithCompletionCallback:progressCallback:] + 1610
7   ExampleProject                      0x000000010846b8bc -[RCTMultipartDataTask URLSession:streamTask:didBecomeInputStream:outputStream:] + 444
8   CFNetwork                           0x0000000109bd4352 __88-[NSURLSession delegate_streamTask:didBecomeInputStream:outputStream:completionHandler:]_block_invoke + 51
9   Foundation                          0x0000000108b199ad NSBLOCKOPERATION_IS_CALLING_OUT_TO_A_BLOCK + 7
10  Foundation                          0x0000000108b1968f -[NSBlockOperation main] + 101
11  Foundation                          0x0000000108b17d8c -[__NSOperationInternal _start:] + 672
12  Foundation                          0x0000000108b13ccf __NSOQSchedule_f + 201
13  libdispatch.dylib                   0x000000010de0a0cd _dispatch_client_callout + 8
14  libdispatch.dylib                   0x000000010dde7e17 _dispatch_queue_serial_drain + 236
15  libdispatch.dylib                   0x000000010dde8b4b _dispatch_queue_invoke + 1073
16  libdispatch.dylib                   0x000000010ddeb385 _dispatch_root_queue_drain + 720
17  libdispatch.dylib                   0x000000010ddeb059 _dispatch_worker_thread3 + 123
18  libsystem_pthread.dylib             0x000000010e1b9712 _pthread_wqthread + 1299
19  libsystem_pthread.dylib             0x000000010e1b91ed start_wqthread + 13
)
libc++abi.dylib: terminating with uncaught exception of type NSException

Looks like an unrelated issue with NSTaggedPointerString to me. The warning you get above it is harmless, you probably have another issue.

@TheRemjx01 You probably have something like:
NSNumber *aString = dictionary[@"key"];
[aString unsignedIntValue];

Basically, you are assigning a value with type id as an NSNumber, and using NSNumber APIs, when in fact, it's an NSString object, which doesn't support NSNumber selectors.

@Mazyod Thanks for your reply.
Actually, I haven't do anything, just create app with react-native-cli then run on xCode and got those errors.
However, I have changed from react-native-cli to CRNA. Everything work fine

+1

same  issue

Same issue

+1 Same issue.
Oct  8 20:45:27  Frills[11429] <Error>: CGContextSaveGState: invalid context 0x0. If you want to see the backtrace, please set CG_CONTEXT_SHOW_BACKTRACE environmental variable.
Oct  8 20:45:27  Frills[11429] <Error>: CGContextTranslateCTM: invalid context 0x0. If you want to see the backtrace, please set CG_CONTEXT_SHOW_BACKTRACE environmental variable.
Oct  8 20:45:27  Frills[11429] <Error>: CGContextRestoreGState: invalid context 0x0. If you want to see the backtrace, please set CG_CONTEXT_SHOW_BACKTRACE environmental variable.
2017-10-08 15:15:27.943 [info][tid:main][RCTCxxBridge.mm:187] Initializing <RCTCxxBridge: 0x7fb99d4c65e0> (parent: <RCTBridge: 0x7fb99d75f610>, executor: (null))
2017-10-08 15:15:27.954 [warn][tid:main][RCTBridge.m:114] Class RCTCxxModule was not exported. Did you forget to use RCT_EXPORT_MODULE()?
2017-10-08 20:45:28.050 Frills[11429] <Warning> [Firebase/Analytics][I-ACS005000] The AdSupport Framework is not currently linked. Some features will not function properly. Learn more at http://goo.gl/9vSsPb
2017-10-08 20:45:28.064 Frills[11429] <Notice> [Firebase/Analytics][I-ACS023007] Firebase Analytics v.4000000 started
2017-10-08 20:45:28.067 Frills[11429] <Notice> [Firebase/Analytics][I-ACS023008] To enable debug logging set the following application argument: -FIRAnalyticsDebugEnabled (see http://goo.gl/RfcP7r)
2017-10-08 20:45:28.121 Frills[11429] <Notice> [Firebase/Analytics][I-ACS003007] Successfully created Firebase Analytics App Delegate Proxy automatically. To disable the proxy, set the flag FirebaseAppDelegateProxyEnabled to NO in the Info.plist
2017-10-08 20:45:29.278 Frills[11429] <Notice> [Firebase/Messaging][I-FCM001000] FIRMessaging Remote Notifications proxy enabled, will swizzle remote notification receiver handlers. Add "FirebaseAppDelegateProxyEnabled" to your Info.plist and set it to NO
2017-10-08 15:15:31.255 [warn][tid:main][RCTEventEmitter.m:54] Sending `FCMTokenRefreshed` with no listeners registered.
2017-10-08 20:45:34.081 Frills[11429] <Warning> [Firebase/Analytics][I-ACS032003] iAd framework is not linked. Search Ad Attribution Reporter is disabled.
2017-10-08 20:45:34.084 Frills[11429] <Notice> [Firebase/Analytics][I-ACS023012] Firebase Analytics enabled

I'm getting the same issue, just everythings fails to export.
2017-10-11 20:21:02.159 [info][tid:main][RCTCxxBridge.mm:187] Initializing <RCTCxxBridge: 0x6040007b4c80> (parent: <RCTBridge: 0x6040000b45e0>, executor: (null))
2017-10-11 20:21:02.232 [warn][tid:main][RCTBridge.m:121] Class RCTCxxModule was not exported. Did you forget to use RCT_EXPORT_MODULE()?
2017-10-11 20:21:02.247 [warn][tid:main][RCTBridge.m:121] Class RNVectorIconsManager was not exported. Did you forget to use RCT_EXPORT_MODULE()?
2017-10-11 20:21:02.247 [warn][tid:main][RCTBridge.m:121] Class RCTWebSocketExecutor was not exported. Did you forget to use RCT_EXPORT_MODULE()?
2017-10-11 20:21:02.247 [warn][tid:main][RCTBridge.m:121] Class RCTVibration was not exported. Did you forget to use RCT_EXPORT_MODULE()?
2017-10-11 20:21:02.247 [warn][tid:main][RCTBridge.m:121] Class RCTUIManager was not exported. Did you forget to use RCT_EXPORT_MODULE()?
2017-10-11 20:21:02.247 [warn][tid:main][RCTBridge.m:121] Class RCTTiming was not exported. Did you forget to use RCT_EXPORT_MODULE()?
2017-10-11 20:21:02.248 [warn][tid:main][RCTBridge.m:121] Class RCTSourceCode was not exported. Did you forget to use RCT_EXPORT_MODULE()?
2017-10-11 20:21:02.248 [warn][tid:main][RCTBridge.m:121] Class RCTSettingsManager was not exported. Did you forget to use RCT_EXPORT_MODULE()?
2017-10-11 20:21:02.248 [warn][tid:main][RCTBridge.m:121] Class RCTRedBox was not exported. Did you forget to use RCT_EXPORT_MODULE()?
2017-10-11 20:21:02.248 [warn][tid:main][RCTBridge.m:121] Class RCTPlatform was not exported. Did you forget to use RCT_EXPORT_MODULE()?
2017-10-11 20:21:02.248 [warn][tid:main][RCTBridge.m:121] Class RCTPhotoLibraryImageLoader was not exported. Did you forget to use RCT_EXPORT_MODULE()?
2017-10-11 20:21:02.248 [warn][tid:main][RCTBridge.m:121] Class RCTPerfMonitor was not exported. Did you forget to use RCT_EXPORT_MODULE()?
2017-10-11 20:21:02.248 [warn][tid:main][RCTBridge.m:121] Class RCTLocalAssetImageLoader was not exported. Did you forget to use RCT_EXPORT_MODULE()?
2017-10-11 20:21:02.249 [warn][tid:main][RCTBridge.m:121] Class RCTJSCSamplingProfiler was not exported. Did you forget to use RCT_EXPORT_MODULE()?
2017-10-11 20:21:02.249 [warn][tid:main][RCTBridge.m:121] Class RCTJSCExecutor was not exported. Did you forget to use RCT_EXPORT_MODULE()?
2017-10-11 20:21:02.249 [warn][tid:main][RCTBridge.m:121] Class RCTImageStoreManager was not exported. Did you forget to use RCT_EXPORT_MODULE()?
2017-10-11 20:21:02.249 [warn][tid:main][RCTBridge.m:121] Class RCTImagePickerManager was not exported. Did you forget to use RCT_EXPORT_MODULE()?
2017-10-11 20:21:02.249 [warn][tid:main][RCTBridge.m:121] Class RCTImageLoader was not exported. Did you forget to use RCT_EXPORT_MODULE()?
2017-10-11 20:21:02.249 [warn][tid:main][RCTBridge.m:121] Class RCTImageEditingManager was not exported. Did you forget to use RCT_EXPORT_MODULE()?
2017-10-11 20:21:02.249 [warn][tid:main][RCTBridge.m:121] Class RCTI18nManager was not exported. Did you forget to use RCT_EXPORT_MODULE()?
2017-10-11 20:21:02.249 [warn][tid:main][RCTBridge.m:121] Class RCTHTTPRequestHandler was not exported. Did you forget to use RCT_EXPORT_MODULE()?
2017-10-11 20:21:02.250 [warn][tid:main][RCTBridge.m:121] Class RCTGIFImageDecoder was not exported. Did you forget to use RCT_EXPORT_MODULE()?
2017-10-11 20:21:02.250 [warn][tid:main][RCTBridge.m:121] Class RCTFileRequestHandler was not exported. Did you forget to use RCT_EXPORT_MODULE()?
2017-10-11 20:21:02.250 [warn][tid:main][RCTBridge.m:121] Class RCTExceptionsManager was not exported. Did you forget to use RCT_EXPORT_MODULE()?
2017-10-11 20:21:02.250 [warn][tid:main][RCTBridge.m:121] Class RCTEventDispatcher was not exported. Did you forget to use RCT_EXPORT_MODULE()?
2017-10-11 20:21:02.250 [warn][tid:main][RCTBridge.m:121] Class RCTDevSettings was not exported. Did you forget to use RCT_EXPORT_MODULE()?
2017-10-11 20:21:02.250 [warn][tid:main][RCTBridge.m:121] Class RCTDevMenu was not exported. Did you forget to use RCT_EXPORT_MODULE()?
2017-10-11 20:21:02.251 [warn][tid:main][RCTBridge.m:121] Class RCTDevLoadingView was not exported. Did you forget to use RCT_EXPORT_MODULE()?
2017-10-11 20:21:02.251 [warn][tid:main][RCTBridge.m:121] Class RCTDeviceInfo was not exported. Did you forget to use RCT_EXPORT_MODULE()?
2017-10-11 20:21:02.251 [warn][tid:main][RCTBridge.m:121] Class RCTDataRequestHandler was not exported. Did you forget to use RCT_EXPORT_MODULE()?
2017-10-11 20:21:02.251 [warn][tid:main][RCTBridge.m:121] Class RCTClipboard was not exported. Did you forget to use RCT_EXPORT_MODULE()?
2017-10-11 20:21:02.251 [warn][tid:main][RCTBridge.m:121] Class RCTCameraRollManager was not exported. Did you forget to use RCT_EXPORT_MODULE()?
2017-10-11 20:21:02.251 [warn][tid:main][RCTBridge.m:121] Class RCTBlobManager was not exported. Did you forget to use RCT_EXPORT_MODULE()?
2017-10-11 20:21:02.251 [warn][tid:main][RCTBridge.m:121] Class RCTAsyncLocalStorage was not exported. Did you forget to use RCT_EXPORT_MODULE()?
2017-10-11 20:21:02.251 [warn][tid:main][RCTBridge.m:121] Class RCTAssetsLibraryRequestHandler was not exported. Did you forget to use RCT_EXPORT_MODULE()?
2017-10-11 20:21:02.252 [warn][tid:main][RCTBridge.m:121] Class RCTEventEmitter was not exported. Did you forget to use RCT_EXPORT_MODULE()?
2017-10-11 20:21:02.252 [warn][tid:main][RCTBridge.m:121] Class RCTWebSocketModule was not exported. Did you forget to use RCT_EXPORT_MODULE()?
2017-10-11 20:21:02.252 [warn][tid:main][RCTBridge.m:121] Class RCTTVNavigationEventEmitter was not exported. Did you forget to use RCT_EXPORT_MODULE()?
2017-10-11 20:21:02.252 [warn][tid:main][RCTBridge.m:121] Class RCTStatusBarManager was not exported. Did you forget to use RCT_EXPORT_MODULE()?
2017-10-11 20:21:02.252 [warn][tid:main][RCTBridge.m:121] Class RCTPushNotificationManager was not exported. Did you forget to use RCT_EXPORT_MODULE()?
2017-10-11 20:21:02.252 [warn][tid:main][RCTBridge.m:121] Class RCTNetworking was not exported. Did you forget to use RCT_EXPORT_MODULE()?
2017-10-11 20:21:02.252 [warn][tid:main][RCTBridge.m:121] Class RCTNetInfo was not exported. Did you forget to use RCT_EXPORT_MODULE()?
2017-10-11 20:21:02.252 [warn][tid:main][RCTBridge.m:121] Class RCTLocationObserver was not exported. Did you forget to use RCT_EXPORT_MODULE()?
2017-10-11 20:21:02.252 [warn][tid:main][RCTBridge.m:121] Class RCTLinkingManager was not exported. Did you forget to use RCT_EXPORT_MODULE()?
2017-10-11 20:21:02.252 [warn][tid:main][RCTBridge.m:121] Class RCTKeyboardObserver was not exported. Did you forget to use RCT_EXPORT_MODULE()?
2017-10-11 20:21:02.253 [warn][tid:main][RCTBridge.m:121] Class RCTAppState was not exported. Did you forget to use RCT_EXPORT_MODULE()?
2017-10-11 20:21:02.253 [warn][tid:main][RCTBridge.m:121] Class RCTAlertManager was not exported. Did you forget to use RCT_EXPORT_MODULE()?
2017-10-11 20:21:02.253 [warn][tid:main][RCTBridge.m:121] Class RCTActionSheetManager was not exported. Did you forget to use RCT_EXPORT_MODULE()?
2017-10-11 20:21:02.253 [warn][tid:main][RCTBridge.m:121] Class RCTAccessibilityManager was not exported. Did you forget to use RCT_EXPORT_MODULE()?
2017-10-11 20:21:02.253 [warn][tid:main][RCTBridge.m:121] Class RCTViewManager was not exported. Did you forget to use RCT_EXPORT_MODULE()?
2017-10-11 20:21:02.253 [warn][tid:main][RCTBridge.m:121] Class RCTWebViewManager was not exported. Did you forget to use RCT_EXPORT_MODULE()?
2017-10-11 20:21:02.254 [warn][tid:main][RCTBridge.m:121] Class RCTTextViewManager was not exported. Did you forget to use RCT_EXPORT_MODULE()?
2017-10-11 20:21:02.254 [warn][tid:main][RCTBridge.m:121] Class RCTTextManager was not exported. Did you forget to use RCT_EXPORT_MODULE()?
2017-10-11 20:21:02.254 [warn][tid:main][RCTBridge.m:121] Class RCTTextFieldManager was not exported. Did you forget to use RCT_EXPORT_MODULE()?
2017-10-11 20:21:02.254 [warn][tid:main][RCTBridge.m:121] Class RCTTabBarManager was not exported. Did you forget to use RCT_EXPORT_MODULE()?
2017-10-11 20:21:02.254 [warn][tid:main][RCTBridge.m:121] Class RCTTabBarItemManager was not exported. Did you forget to use RCT_EXPORT_MODULE()?
2017-10-11 20:21:02.254 [warn][tid:main][RCTBridge.m:121] Class RCTSwitchManager was not exported. Did you forget to use RCT_EXPORT_MODULE()?
2017-10-11 20:21:02.255 [warn][tid:main][RCTBridge.m:121] Class RCTSliderManager was not exported. Did you forget to use RCT_EXPORT_MODULE()?
2017-10-11 20:21:02.255 [warn][tid:main][RCTBridge.m:121] Class RCTSegmentedControlManager was not exported. Did you forget to use RCT_EXPORT_MODULE()?
2017-10-11 20:21:02.255 [warn][tid:main][RCTBridge.m:121] Class RCTScrollViewManager was not exported. Did you forget to use RCT_EXPORT_MODULE()?
2017-10-11 20:21:02.255 [warn][tid:main][RCTBridge.m:121] Class RCTScrollContentViewManager was not exported. Did you forget to use RCT_EXPORT_MODULE()?
2017-10-11 20:21:02.255 [warn][tid:main][RCTBridge.m:121] Class RCTRefreshControlManager was not exported. Did you forget to use RCT_EXPORT_MODULE()?
2017-10-11 20:21:02.255 [warn][tid:main][RCTBridge.m:121] Class RCTRawTextManager was not exported. Did you forget to use RCT_EXPORT_MODULE()?
2017-10-11 20:21:02.255 [warn][tid:main][RCTBridge.m:121] Class RCTProgressViewManager was not exported. Did you forget to use RCT_EXPORT_MODULE()?
2017-10-11 20:21:02.255 [warn][tid:main][RCTBridge.m:121] Class RCTPickerManager was not exported. Did you forget to use RCT_EXPORT_MODULE()?
2017-10-11 20:21:02.255 [warn][tid:main][RCTBridge.m:121] Class RCTNavItemManager was not exported. Did you forget to use RCT_EXPORT_MODULE()?
2017-10-11 20:21:02.256 [warn][tid:main][RCTBridge.m:121] Class RCTNavigatorManager was not exported. Did you forget to use RCT_EXPORT_MODULE()?
2017-10-11 20:21:02.256 [warn][tid:main][RCTBridge.m:121] Class RCTModalHostViewManager was not exported. Did you forget to use RCT_EXPORT_MODULE()?
2017-10-11 20:21:02.256 [warn][tid:main][RCTBridge.m:121] Class RCTMaskedViewManager was not exported. Did you forget to use RCT_EXPORT_MODULE()?
2017-10-11 20:21:02.256 [warn][tid:main][RCTBridge.m:121] Class RCTImageViewManager was not exported. Did you forget to use RCT_EXPORT_MODULE()?
2017-10-11 20:21:02.256 [warn][tid:main][RCTBridge.m:121] Class RCTDatePickerManager was not exported. Did you forget to use RCT_EXPORT_MODULE()?
2017-10-11 20:21:02.256 [warn][tid:main][RCTBridge.m:121] Class RCTActivityIndicatorViewManager was not exported. Did you forget to use RCT_EXPORT_MODULE()?
2017-10-11 20:21:02.256 [warn][tid:main][RCTBridge.m:121] Class ARTSurfaceViewManager was not exported. Did you forget to use RCT_EXPORT_MODULE()?
2017-10-11 20:21:02.263 [warn][tid:main][RCTBridge.m:121] Class ARTNodeManager was not exported. Did you forget to use RCT_EXPORT_MODULE()?
2017-10-11 20:21:02.263 [warn][tid:main][RCTBridge.m:121] Class ARTRenderableManager was not exported. Did you forget to use RCT_EXPORT_MODULE()?
2017-10-11 20:21:02.264 [warn][tid:main][RCTBridge.m:121] Class ARTTextManager was not exported. Did you forget to use RCT_EXPORT_MODULE()?
2017-10-11 20:21:02.264 [warn][tid:main][RCTBridge.m:121] Class ARTShapeManager was not exported. Did you forget to use RCT_EXPORT_MODULE()?
2017-10-11 20:21:02.264 [warn][tid:main][RCTBridge.m:121] Class ARTGroupManager was not exported. Did you forget to use RCT_EXPORT_MODULE()?

Anyone find a solution to this?

Trying to setup an Xcode build bot and I'm getting this same issue. Any update to this?

Any solutions ?

Now it's already a month ago, so not really sure how I fixed it. But I think it was by adding React to the Target Dependencies.
In xcode > Build Phases > Target Dependencies > + > React > React

same to me

I think you should add the following
#ifdef DEBUG   //  jsCodeLocation = [NSURL URLWithString:@"http://localhost:8081/index.ios.bundle?platform=ios&dev=true"];   jsCodeLocation = [[RCTBundleURLProvider sharedSettings] jsBundleURLForBundleRoot:@"index" fallbackResource:nil]; #else   jsCodeLocation = [[NSBundle mainBundle] URLForResource:@"main" withExtension:@"jsbundle"]; #endif

That npm v5.x.x sometimes removes packages while installing another one (very annoying bug, probably because we use npm i --save module, and npm v5 doesn't need --save flag).
Also the error "Native module cannot be null." happened to me the moment i changed the Bundle Identifier, i tried to clean build, clean DeriveData dir, npm start -- --reset-cache. I checked all modules where linked correctly.

Here is a log
2017-12-25 13:32:59.538 [info][tid:main][RCTCxxBridge.mm:213] Initializing <RCTCxxBridge: 0x1c01d4370> (parent: <RCTBridge: 0x1c00df250>, executor: (null))
2017-12-25 13:32:59.548914+0100 LalaFeed[7050:2893263] Initializing <RCTCxxBridge: 0x1c01d4370> (parent: <RCTBridge: 0x1c00df250>, executor: (null))
2017-12-25 13:32:59.609 [warn][tid:main][RCTBridge.m:121] Class RCTCxxModule was not exported. Did you forget to use RCT_EXPORT_MODULE()?
2017-12-25 13:32:59.609564+0100 LalaFeed[7050:2893263] Class RCTCxxModule was not exported. Did you forget to use RCT_EXPORT_MODULE()?
2017-12-25 13:32:59.696 [info][tid:main][RCTRootView.m:301] Running application LalaFeed ({
    initialProps =     {
    };
    rootTag = 1;
})
2017-12-25 13:32:59.696488+0100 LalaFeed[7050:2893263] Running application LalaFeed ({
    initialProps =     {
    };
    rootTag = 1;
})
2017-12-25 13:33:21.341 [error][tid:com.facebook.react.JavaScript] Native module cannot be null.
2017-12-25 13:33:21.341105+0100 LalaFeed[7050:2893386] Native module cannot be null.
2017-12-25 13:33:21.346 [fatal][tid:com.facebook.react.ExceptionsManagerQueue] Unhandled JS Exception: Native module cannot be null.
2017-12-25 13:33:21.346559+0100 LalaFeed[7050:2893391] Unhandled JS Exception: Native module cannot be null.
2017-12-25 13:33:21.359 [error][tid:com.facebook.react.JavaScript] Module AppRegistry is not a registered callable module (calling runApplication)
2017-12-25 13:33:21.359333+0100 LalaFeed[7050:2893386] Module AppRegistry is not a registered callable module (calling runApplication)
2017-12-25 13:33:21.370461+0100 LalaFeed[7050:2893374] [] nw_connection_get_connected_socket 4 Connection has no connected handler
2017-12-25 13:33:21.370481+0100 LalaFeed[7050:2893374] TCP Conn 0x1c016fd80 Failed : error 0:61 [61]
2017-12-25 13:33:21.373 [fatal][tid:com.facebook.react.ExceptionsManagerQueue] Unhandled JS Exception: Module AppRegistry is not a registered callable module (calling runApplication)
2017-12-25 13:33:21.373466+0100 LalaFeed[7050:2893391] Unhandled JS Exception: Module AppRegistry is not a registered callable module (calling runApplication)

@warrenronsiek  thanks, can you add a screenshot of info.plist opened in the info plist editor? I'm new on Max and I'm not able to understand where to insert these lines

@realaboo, your info.plist should work. Seems like something else is going wrong.

+1 same issue

Looks related to #18201.

Adding -ObjC under Build Settings > Other Linker Flags solved this for me.
My issue was that the app crashed on start with error message:
Class RCTCxxModule was not exported. Did you forget to use RCT_EXPORT_MODULE()?

issue is still there, this just suddenly pops up after so many days development. Sadly the issue is closed on both of Github link where they are saying its duplicate.

@hramos Hi, yup it came suddenly. particularly appeared after installing react-native-keychain although I'm refactoring a lot of logic in auth and on init of application, so sometimes it comes, sometimes it doesn't show. so, I have no idea how and what is causing this to appear. maybe bcz I am exporting async functions in action creator? ... I have no idea!

In that case, please open a new issue. As far as we are aware, this is fixed in master, so it would be useful to get a brand new report with your specifics.

Adding -ObjC under Build Settings > Other Linker Flags solved this for me.
My issue was that the app crashed on start with error message:
Class RCTCxxModule was not exported. Did you forget to use RCT_EXPORT_MODULE()?


[plugin] Allow usage of the X-Forwarded-For header in the ip-restriction plugin

When behind a proxy the ip-restriction plugin will act upon the ip address of the proxy, instead of the original client, passed in the X-Forwarded-For header.
Requires an option to be added to the schema to (dis)allow this.

It would be useful if this can be done for the rate limiting plugin as well, in case it falls back to IP as the identifier for rate limiting.

@Tieske I have tried to replicate, unsuccessfully. Can you take a look at the test? #2019

I'm pretty sure this is handled with #2236 / #2202.

@Tieske is this relevant anymore as the we have merged the above?

let's close this.


build(ui): Remove some default environment variables

Having default values for environment variables like API url makes debugging
Docker image a little tedious. Remove API URL and Keycloak related environment
variable defaults so they will always have to be given.
Signed-off-by: Mikko Murto<EMAIL_ADDRESS>

Waiting for #805 to be merged.


Add File Storage Documentation to README

Is your feature request related to a problem? Please describe.
It can be challenging for new contributors to understand the project’s file structure and know where to find specific functionality or assets. This can lead to frustration and confusion when trying to contribute or debug.
Describe the solution you'd like
I would like to add a "File Structure" section in the README that outlines the primary folders and files, along with a brief description of each. This will help new contributors and team members understand the organization and purpose of different files in the project.
Describe alternatives you've considered
N/A
Additional context
Adding this section will make the project easier to navigate, especially for beginners.
Please assign me this under gssoc-ext, hactoberfest-accepted ans respective level

hey , nice idea , but honestly our readme is so full right now , we dont need this , thanks !


Please triage CompileTimeErrors on co19/LanguageFeatures/Constructor-tear-offs tests

As of today, there are 16 CompileTimeError and 10 MissingCompileTimeError on co19/LanguageFeatures/Constructor-tear-offs tests in cfe-strong-linux configuration (16 CompileTimeError and 2 MissingCompileTimeError on dartk-strong-linux-release-x64).
Repro:
tools/test.py -n cfe-strong-linux co19/LanguageFeatures/Constructor-tear-offs

Those could be mistakes in the tests or bugs in CFE. Potentially they could also hide problems in the back-ends which we won't discover until CompileTimeErrors are fixed.
/cc @johnniwinther @eernstg

cc @stefantsov

Commit f9a65636e55e8d7fe295662da08d4cc29580b131 was a co19 roll where approximately 65 co19 commits were carried over (that is: lots of changes happened), and https://github.com/dart-lang/co19/issues/1138 was created in order to triage and handle the failures (we had about 107 test failures when that issue was created). So the work is ongoing.
I'm currently looking at those 26 cases.

Created dart-lang/co19#1145 .. dart-lang/co19#1157 about tests with issues. Created #46887 .. #46891 about issues in tools revealed by the new tests. Created dart-lang/language#1802 about a specification clarification issue.


Separate TCP implementation from the host bindings

Part of #7705 was moving the implementation of TCP (and UDP) out of the host bindings and into their own types. This PR starts this process (only for TCP) by doing a simple lift and shift of the code from the host bindings into the TcpSocket type. This should make next steps easier as the border between host bindings and implementation become much clearer with this change.
In the future, we may choose to make TcpSocket a trait object allowing users to swap in their own implementations, but that's left for a future change.
You may notice that some of TcpSocket's methods return io::Result while most return SocketResult. It would be nice to move TcpSocket over completely to io::Result so that the implementation is completely free of any host bindings. However, there are some unclear/missing mappings between io::Error and ErrorCode. For example, when the socket is in an invalid state, we currently return ErrorCode::InvalidState. However, there is no io::Error or Errno that maps 1 to 1 to this ErrorCode. We'll need to figure out exactly how we want to do this mapping, but I'm leaving that for a future PR.

Certainly! You can see more of what I'm going for in #7705 (for example here).
While I think there will be a large overlap with the bindgen generated trait, there's going to be enough difference that trying to make it fit directly will be difficult (and will only grow more difficult over time). I tried to keep this PR as simple as possible which meant a pretty 1 to 1 lift and shift which admittedly makes it a bit hard to see where the difference between the concrete implementation and the bindgen generated trait is. However, I can imagine that some state management will move back into the host module and the concrete implementation will change before we (potentially) move towards making this a trait.
That all being said, I personally find the code as it is now easier to read since the actual networking code is separate from the boiler plate of resource management, and I'd argue even if no other abstraction were to take place, this would be a worthwhile refactor.

Yeah I would agree with you that in isolation I see no issue with this PR, I'm mostly curious about looking ahead and seeing where it's going. Adding a trait, for example, gets us back to where wasi-common was originally. That style of design has pros and cons: for example it's easier to slot in a custom thing but it's harder to understand as there's yet-another-layer of traits. The wasmtime-wasi crate is already pretty gnarly in terms of trying to understand it given its size so I'd be wary to insert more layers of indirection. (an example of this is that tracing through a wasip1 function call can be pretty daunting today)
Personally I'm an advocate for pushing this complexity into bindgen whenever we can. For example if the complexity here is high enough to warrant a new layer of traits we could try to push the resource management into wit-bindgen instead. That's what we've done with trappable-errors for example (and with).
Again though I'm happy to land this as-is if you'd prefer to defer the trait question into the future, but if it's a guarantee that the trait is coming then it might be worth trying to bottom this out before landing.

This change moves things around enough that I'm a bit worried about merge conflicts if we let it sit for too long. Considering its useful in isolation, I'd personally advocate for landing it now, and being able to discuss the future evolution outside of a PR.

@rylev You introduced a TODO in this PR:
pub fn set_keep_alive_count(&self, value: u32) -> SocketResult<()> {
    // TODO(rylev): do we need to check and clamp the value?
    let view = &*self.as_std_view()?;
    Ok(network::util::set_tcp_keepcnt(view, value)?)
}

The implementation of network::util::set_tcp_keepcnt already clamps it:
const MIN_CNT: u32 = 1;
// Cap it at Linux' maximum, which appears to have the lowest limit across our supported platforms.
const MAX_CNT: u32 = i8::MAX as u32;

sockopt::set_tcp_keepcnt(sockfd, value.clamp(MIN_CNT, MAX_CNT))

Does this resolve your question?

Hmmm it does indeed, I wonder why I didn't see the clamping in the util function...

Ok, no worries. I'll remove it.


Always call _can_handle() before _parse_property()

Some custom inspectors, like array inspector or TileSet inspector, used instantiate_property_editor(), which had a different path for handling properties that did not use can_handle(). This PR adds a proper check and also prevents passing null as object for the method (as it can lead to crash when checking class).
Fixes #71236

Needs a rebase.

Thanks!


Organize functions under spinalcordtoolbox/ folder

to address this comment:

zougloub on Apr 10 Member
Could mtsat be in a folder that may contain other "similar" tools?
from x.something import something to import a module is not the prettiest.
jcohenadad on Apr 10 Member
Agreed, however I believe this requires group discussion. Opened an issue here

compute_mtsat now lives in spinalcordtoolbox.qmri.mt. So, I believe the core concern here has been addressed.


Formatting ignored across single line wrap

I'm copying and pasting from readme files containing lines hardwrapped for terminal display. I have disabled "GFM newlines" as remarked in #249:

# → Settings → Extensions → Markdown Extra → ☐ GFM newlines

The problem is formatting is no longer recognized across the single-line-wrapping:

I would expect this result instead:

Should be fixed in the v5 (https://stackedit.io/app). Please open a new ticket if it's not.


Image gallery is missing a "More" link in "The Outsiders part 1"

Type

✨ Feature
🐛 Bug
🚑 Health report

Requirements

[ ] User research
[ ] Content requirements from Content Team
[ ] New component(s) built
[ ] New visual design
[ ] Event tracking in GA/Mixpanel

(damnit, GitHub created the issue before I was done)


pnpm monorepo using pinceau/volar type prompts seem to be missing On its own, it's fine

The repository address is https://github.com/SGAMERyu/Luff-UI

Personal configuration problem


DBZ-8184 Enable snapshot failure retries during Oracle tests

https://issues.redhat.com/browse/DBZ-8184

/packit test --labels oracle

Test failure on Oracle 21 XStream addressed in https://github.com/debezium/debezium/pull/5819

The Oracle 23 failures are fixed in #5821


template without links

model and template
template model and spec
Context
In this pr we are introduce the first part of organisation details we don't have data yet for Special educational needs and disabilities and additional details.
Our goal is to have the result looking the closest to the demo app
Changes proposed in this pull request
We created a component, we created a page and test related to the page.
Guidance to review
Check demo app and compare it to the screenshoot or local
Link to Trello card

Things to check

[ ] If the code removes any existing feature flags, a data migration has also been added to delete the entry from the database
[ ] This code does not rely on migrations in the same Pull Request
[ ] If this code includes a migration adding or changing columns, it also backfills existing records for consistency
[ ] If this code adds a column to the DB, decide whether it needs to be in analytics yml file or analytics blocklist
[ ] API release notes have been updated if necessary
[ ] If it adds a significant user-facing change, is it documented in the CHANGELOG?
[ ] Required environment variables have been updated or added to the Azure KeyVault

Screenshots

Good work. I'm a bit confused on the user flow we need here. Maybe you didn't pull the latest version of main. But I expected to have a organisations#show controller and route here so we can redirect the user to the organisations details from here if he has multiple organisations or from here if he has only one organisation.
Happy to jump on a call for more detail.

This has been changed to schools#index now for the claims domain


fix target binary directory for Android

When I try to use the locally published Android library in mavenLocal in a new Android project, it's giving error that it cannot find libcalculatorffi.so. After investigation about the Gradle plugin, it seems currently the generated Kotlin bindings for Android does not include binary artifact in the calculator-android-0.1.0.aar file due to the wrong settings for target directory in UniFfiAndroidPlugin.kt.
calculator-android uses the same Gradle plugin settings as the bdk-android for Android bindings, but in bdkffi the target directory was generated in the parent folder of bdk-android, unlike calculator-android which generates the target directory in calculator-ffi directory.
This PR is to fix this issue.

Are you building something cool you'd like to share with us?

As an iOS engineer, I'm a big fan of Rust and currently I'm exploring what we can build with Rust for iOS and Android for common cases like sharing logic in rust code for app network request and database access.
It seems uniFFI is really cool but I'm struggling to find working examples except the official ones. Thank you so much for creating this template, I'm happy to contribute to make this template more useful for anyone who is interested in uniFFI.

Also, have you seen this repo and website full of examples?

Yes, the examples are really cool and very useful as a guidebook in addition to the official guideline. For me, other than the current existing examples, I'm also interested to see more complex topics like how to do error handling and asynchronous request.


error: unexpected argument ‘–max-input-tokens’ found

System Info
Version: ghcr.io/huggingface/text-generation-inference:1.4
If I add --max-input-tokens 14000 to the docker arguments, it gives this error:
error: unexpected argument ‘–max-input-tokens’ found
When the container is starting, it reports out various arguments that it is using (including defaults), one of these is the prohibitively low default value max_input_length: 1024 .
Information

[X] Docker
[ ] The CLI directly

Tasks

[X] An officially supported command
[ ] My own modifications

Reproduction
docker run --gpus all \
    --shm-size 1g \
    -e HUGGING_FACE_HUB_TOKEN=$token \
    -p $myport:80 \
    -v $volume:/data ghcr.io/huggingface/text-generation-inference:1.4 \
    --model-id $model \
    --max-total-tokens 18000 \
    --max-input-tokens 14000

Expected behavior
It should run without errors, since various other CLI commands appear to work fine as docker arguments.

Using --max-input-length instead. It seems that the newer --max-input-tokens did not yet exist in ghcr.io/huggingface/text-generation-inference:1.4


Bugfix/#182 optimize and solve the client registration repository bean issue for oauth2.0

PS: this branch was created from the #152.
Based on this, #152 needs to be merged first
closes #182

Tests issue solved

Follow-up issue coatrack#183 created for the ResourceServerTokenServices


Rename AbandonResponse

Per the rfc4511, there's no defined response to an AbandonRequest.
The existence of such an object is misleading.

👋
On February 22, 2023, we released version 3 of this library. As a result, we are closing this issue/pull request.
Please see issue #839 for more information, including how to proceed if you feel this closure is in error.