/usr/bin/python3: No module named tern error in vagrant running in windows 10 Personal computer

No module named tern
The documentation is insufficient
I used vagrant up with tern project in my local drive
To Reproduce
Steps to reproduce the behavior:

I followed the vagrant procedure as mentioned in the https://github.com/vmware/tern/blob/master/README.md#getting-started-with-vagrant
when I run the "python -m tern -l report -i debian:buster -f output.txt" command
Python command doesn't exist came
So I altered the command to python3 in step 2 and ran "python3 -m tern -l report -i debian:buster -f output.txt" command
threw below error

Error in terminal
/usr/bin/python3: No module named tern

Expected behavior
I was expecting the BOM report
Environment you are running Tern on
Enter all that apply

Operating System is Windows 10
Vagrant file https://github.com/vmware/tern/blob/master/vagrant/Vagrantfile
Python version (3.6 or higher)- 3.6.8

Hi @dineshr93, thanks for filing this issue.
Please try to cd into the tern directory on the vagrant VM  before you run the command in question. You are correct that you will likely need to use python3 for the command and this should be updated in the documentation.
When I replicate the steps you mentioned and cd into the tern directory on the created VM, Tern runs without issue. If I run the command outside of the tern directory I can see the same error message as you are seeing. Here's what I did:
<Install VirtualBox>
<Install Vagrant>
$ git clone https://github.com/vmware/tern.git
$ cd tern/vagrant
$ vagrant up
$ vagrant ssh
$ cd tern
$ python3 -m tern -l report -i debian:buster -f output.txt
2019-06-28 20:05:42,842 - DEBUG - __main__ - Starting...
2019-06-28 20:05:42,842 - DEBUG - report - Setting up...
2019-06-28 20:05:43,861 - DEBUG - container - Checking if image "debian:buster" is available on disk...
2019-06-28 20:05:44,945 - DEBUG - container - Image "debian:buster" found
2019-06-28 20:05:48,963 - DEBUG - rootfs - Running command: sudo /home/vagrant/tern/tern/tools/fs_hash.sh /home/vagrant/tern/temp/0f28619fe69181d3af529d56692f1362b7a7c8a6bf8dc9ab0d6d4f9ef9b0004d/contents
2019-06-28 20:05:56,334 - DEBUG - rootfs - Running command: sudo mount -o bind temp/0f28619fe69181d3af529d56692f1362b7a7c8a6bf8dc9ab0d6d4f9ef9b0004d/contents temp/mergedir
2019-06-28 20:05:56,342 - DEBUG - common - Loaded from cache: layer "06fbb6a15a"
2019-06-28 20:05:56,345 - DEBUG - rootfs - Running command: sudo umount -rl temp/mergedir
2019-06-28 20:05:56,391 - DEBUG - report - Creating a detailed report of components in image...
2019-06-28 20:05:56,400 - DEBUG - rootfs - Running command: sudo rm -rf temp/0f28619fe69181d3af529d56692f1362b7a7c8a6bf8dc9ab0d6d4f9ef9b0004d/contents
2019-06-28 20:05:56,496 - DEBUG - report - Teardown...
2019-06-28 20:05:57,240 - DEBUG - rootfs - Running command: sudo rm -rf temp/mergedir
2019-06-28 20:05:57,248 - DEBUG - rootfs - Running command: sudo rm -rf temp/workdir
2019-06-28 20:05:57,271 - DEBUG - __main__ - Report completed.
2019-06-28 20:05:57,271 - DEBUG - __main__ - Finished

If I try to run the command outside of the tern directory I see:
[vagrant@ubuntu-bionic:~$ pwd
/home/vagrant
vagrant@ubuntu-bionic:~$ python3 -m tern -l report -i debian:buster -f output.txt
/usr/bin/python3: No module named tern.__main__; 'tern' is a package and cannot be directly executed

Can you give this a try and let me if it helps?


UAR-329: Implement continue with saved filing page journey

JIRA link
https://companieshouse.atlassian.net/browse/UAR-329
Change description
Add continue with saved filing page to update Journey
Work checklist

[ ] Tests added where applicable
[ ] UI changes meet accessibility criteria

Merge instructions
We are committed to keeping commit history clean, consistent and linear.  A BREAKING CHANGE can be part of commits of any type,
types other than fix: and feat: are allowed, for example build:, chore:, ci:, docs:, style:, refactor:, perf:, test:, and others,
footers other than BREAKING CHANGE: <description> may be provided.

Should this page just be a normal part of the journey (when update save & resume flag is on)? I don't see why it needs to be a follow on from authentication - you could already be authenticated when you go to the update-an-overseas-entity landing page.

Do we need a change to the web app env config to set the landing page to be this new page? Only if save& resume is enabled? Our landing controller should then re-direct to it (no code change needed unless we re-direct there based on the feature flag)? If you go to "/update-an-overseas-entity"?


Generic Get API call function and code generator for simple Get-* functions

This is not yet a PR, just a proposal to discuss.
When correcting the Get-* methods I saw there is a pattern in most Get-* methods. This is my first attempt at extracting it and reusing it for Get-NSResponderPolicy. What do you think ?

That makes sense to me. I'm all for having it reuse as much common code as possible.

I added a simple code generator that generates Get-* functions that use the generic API call. The only thing that changes from one Get to another is the name, type, labels and the list of filter parameters so it works OK.
As this is quite tedious work, so I would like to gather a bit of feedback before moving forward. What do you think about the current state ? Get-NSCSAction and Get-NSCSPolicy are completed.

Sorry I didn't respond sooner. I think these are fantastic!

Well thx ;-) I will continue with the ones I currently need for my project and then cleanup the PR.

Sound good.

I think this should do for now. It is ready for merge if you are OK with it.
I rebased everything on current master and squashed a couple commits. I have tried all cmdlets at least once, most are currently in use in scripts I run on a regular basis in my lab. So it is as tested as I can make it for now. One of my next steps will be to create system tests, but this is still cooking.


Update setting for 0/editorial-team-prep label

@lwasser brought to our attention that the 0/editorial-team-prep label is currently not automatically added. It is removed here:
https://github.com/ropensci-org/buffy/blob/044d630b554a7963aa2a1d8febe9422edd5643bd/config/settings-production.yml#L103-L110
But never automatically added. We can easily automatically add on initial submission if a pre-sub enquiry can be identified. The question we'd have to resolve would be what to do with initial full submissions? Should we add this label straight away? There is currently no other viable point at which we could automatically do this. Thoughts @noamross @maelle @lwasser?

yes, we current start with a 1/editor-checks but have been thinking about adding a 0/editorial-team-prep type label for new submissions that haven't been "Assigned" yet!
as such i agree with @noamross above
This is what a new submission. looks like for us. but really it should be a 0/editorial-team-prep or  0/review-triage type of label prior to checks as that is it's current state.


Add crazyegg script to app headers

This PR adds crazzyegg script to app header to allow User Research team to get navigation info from user base.
I decided to do an independent PR with this tasks to avoid couple it with #563 where this script was already added, that way it will land sooner into master branch.

It doesn't break, so I guess it's OK =D


[Updated] Module Readmes - Workout a testable solution for the description of array and object parameters

Description
As most of the usage for object and array parameters are difficult to map out how to use, we should make it mandatory that these are in the readme files. Examples of what goes into an array, and what properties to use on a object parameter. Of course this only applies to the params we do not cover with child modules.
A suggestion would be to add a placeholder block such as below for all parameters of type array and object, excluding where we have a subfolder (child module) for it:
### Parameter Usage: `<ParameterName>`

```bicep

```

We should probably have an issue per resource type / provider

Started the implementation in branch users/alsehr/1096_paramUsage.
It has however the issue that existing examples that are not in the parameter files may be overwritten & that comments are not translated into the generated example.
For example:

Further, fetching usage examples for child modules requires further engineering as it requires a dynamic drill down into the top-level module's parameter file.

Duplicate of #1246 ?

@MrMCake will investigate further

Placeholder are not helping and manually written examples may be outdated. The team decides to have a preferably automated way to have working examples per complex parameter (or array parameter).

I'd strongly suggest to remove manually implemented parameter usage examples which are already used in deployment examples from the readme files until a good solution is found to automate them.
Not all parameter objects/arrays can be validated and for them the manually updated parameter usage snippets are for now good to be kept. Instead, the ones already used by deployment examples should be removed.
The reason is we may easily end up having two different snippets for the same parameter object/array: one in the parameter usage section (manually implemented once and usually never updated) and one in deployment examples (automatically retrieved and aligned with deployment validation tests).
An example is what we currently have for KeyVault networkAcls, which is quite error prone. From parameter usage:
networkAcls: {
    bypass: 'AzureServices'
    defaultAction: 'Deny'
    virtualNetworkRules: [
        {
            subnetId: '/subscriptions/<<subscriptionId>>/resourceGroups/validation-rg/providers/Microsoft.Network/virtualNetworks/sxx-az-vnet-x-001/subnets/sxx-az-subnet-x-001'
        }
    ]
    ipRules: []
}

From deployment examples:
networkAcls: {
      bypass: 'AzureServices'
      defaultAction: 'Deny'
      ipRules: []
      virtualNetworkRules: [
        {
          action: 'Allow'
          id: '<id>'
        }
      ]
    }

What showed in deployment examples should be the primary reference, as that gets continuously tested through module valitdation pipelines.

This will potentially go away with the future introduction of the user-defined types. cc: @eriqua
I'd suggest to not invest work into this issue until the feature is implemented as it may render it redundant.

Closing in favor of the work for user-defined types.


Upload test coverage to codecov.

What this PR changes/adds
Upload IdentityHub test coverage to codecov.
Report can be seen here: https://codecov.io/gh/agera-edc/IdentityHub/tree/feature%2F250%2F250-codecov
Why it does that
To have codecov report to see the test coverage in PRs.
Linked Issue(s)
https://github.com/agera-edc/MinimumViableDataspace/issues/250
Checklist

[x] added appropriate tests?
[x] performed checkstyle check locally?
[x] added/updated copyright headers?
[x] documented public classes/methods?
[x] added/updated relevant documentation?
[x] added relevant details to the changelog? (skip with label no-changelog)
[x] formatted title correctly? (take a look at the CONTRIBUTING and styleguide for details)

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@0e22ee7). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #25   +/-   ##
=======================================
  Coverage        ?   90.80%
  Complexity      ?       71
=======================================
  Files           ?       21
  Lines           ?      359
  Branches        ?       15
=======================================
  Hits            ?      326
  Misses          ?       28
  Partials        ?        5

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


implement way better matrix support

needs testing and probably can crash

after testing the latest commit, most things seem to work WITH exceptions:

replying to messages bridged by bolt-matrix isn't working, for whatever reason
profile pictures on matrix don't work
handling groups of messages needs to be supported in core for attachment support (same for telegram)
embeds aren't bridged, find a way to do this

so, now, replies work better but the quote is still included alongside the reply
getting a prop user on matrix (and having them join rooms, get usernames, and have profile pictures) is broken and needs to be figured out (lots of vague errors thrown around)
embeds and multiple messages are stuff to figure out, multiple messages will come first


Fix loading protobufs in dependents

Coverage increased (+0.08%) to 95.284% when pulling 6df3f47e84b9d74485ca612d60ef2493ec50134b on mcollina:master into 8970e228ffdfad3d07bffc04ed3b38de317d240b on marcopiraccini:master.


UI/UX Enhancement Needed for Consistent and User-Friendly Experience

The current UI/UX of the Canvas Editor website could be improved for a smoother and more intuitive user experience. Some elements, such as spacing, font consistency, and color harmony, require attention to enhance the usability and visual appeal of the interface.
Proposed Improvements:
Consistent Spacing and Alignment: Adjust padding and margins across different sections to create a balanced layout.
Color Harmony: Align colors across elements for a cohesive look that’s easy on the eyes.
Improved Font Styling: Use a consistent font size and style to enhance readability and establish a clear visual hierarchy.
Additional Observations: In the attached video, certain transitions and animations seem abrupt, affecting the flow and user engagement.
Benefits:
Enhanced Visual Appeal: A polished interface creates a positive first impression and encourages engagement.
Improved Accessibility: Consistent fonts, colors, and layout make the website more accessible and enjoyable to use.
https://github.com/user-attachments/assets/88d588a0-8e72-4a27-8e91-e1f29a421a93

@vishanurag please assign me this issue

similar issue is already assigned. refer https://github.com/vishanurag/Canvas-Editor/issues/1005


first download of uncached .hex takes 1 minute

When the client tries to download an uncached .hex image, the call to the compile service may take a minute. Progress window needed.

Won't fix for now. If we hear from customers then we will address this.


Invalid lines in the DSL are shown

Example:
import owlkettle

viewable App:
  counter: int

method view(app: AppState): Widget =
  result = gui:
    Window:
      title = "Counter"
      default_size = (200, 60)
      border_width = 12
      # case "test"
      # of "hello": discard
      # elif 1 == 2: discard

      Box(orient = OrientX, spacing = 6):
        Label(text = $app.counter)
        Button:
          echo "test"
          text = "+"
          style = {ButtonSuggested}
          proc clicked() =
            app.counter += 1

brew(gui(App()))

Before PR
/home/me/.nimble/pkgs/owlkettle-1.0.0/owlkettle/guidsl.nim(144, 16) Error: nnkStrLit is not a valid gui tree.
After PR
/tmp/owlkettle/test.nim(19, 16) Error: nnkStrLit is not a valid gui tree.

Thank you for contributing! I actually did not know that this overload for the error procedure existed. So this is quite useful.


How to pass complex object as parameter

The following code throws Converting object to an encodable object failed: Instance of 'InvocationMessage'
_hubConnection.invoke("Broadcast", args: [request, broadMessage]);

I already implemented toJson() as per instruction
use objects that implements toJson() since that method is used by the dart:convert package to serialize an object. here https://pub.dartlang.org/packages/signalr_client
class NotificationRequest {
  int connectionType;
  String command;
  int userId;
  String userName;
  String uuid;

  NotificationRequest(
      {this.command,
      this.connectionType,
      this.userId,
      this.userName,
      this.uuid});

  Map<String, dynamic> toJson() => {
        'connectionType': connectionType,
        'command': command,
        'userId': userId,
        'userName': userName,
        'uuid': uuid
      };
}

class BroadCastMessage {
  String message;
  BroadCastMessage({this.message});
  Map<String, dynamic> toJson() => {'message': message};
}

This should be fixed within the new version 0.1.5.
Thank you for reporting the bug!
There is a test for this.


ci(e2e): notify slack of k8s cluster left running

When e2e test run fails, k8s cluster built for the test is left running
to allow investigation. This adds sending notification to team's slack
about that cluster.
ref: CAS-570

bors merge

bors merge

bors retry

bors retry

bors merge

bors merge

Due to bors misbehaving or something bors isn't merging this. I'll re-create a new PR  to see if that helps.


Help on the ERROR "We could not retrieve your import configuration or it has been corrupted. "

After i updated the password by clicking the URL displayed on the CloudFrontDistribution stack, i received the error "We could not retrieve your import configuration or it has been corrupted. " Not sure if there is anything missing here. Thanks

What does it say in the the network tab of dev tools? Are there any errors in the browser console?

@svozza here is the screenshot:

Hmm, something weird going on with the graphql endpoint. Can you go to the logs for the SettingsFunction lambda function and see if there are any errors in there?

@svozza May I know where can i locate the logs for the SettingsFunction lambda function? is it still under CloudFormation?

If you find that function in the Lambda console (just type 'Settings' into the search bar and it will appear) you'll be able to reach the logs from the Monitoring tab.

@svozza i did that before and i did not find it. Here is all what i have:

It looks like there was a problem with the install, you're missing most of the lambdas. Can you check in the CloudFormation console and see if there are errors there?  There should be around 20 stacks related to Perspective.

@svozza Thanks. You are right. In total i have 25 stacks and 14 of them are perspective related. Among these 14, there are 2 stacks marked with CREATE_FAILED status: aws-perspective-833543886316-us-east-1-DiscoveryImport-109SHKA1S32L8(NESTED) and aws-perspective-833543886316-us-east-1
Is the nested one causing the failure of the main template one?

My guess is that you already have Config enabled in this region and the error is that it is trying to create a delivery channel that already exists. If you click into the Config Aggregator stack you'll see the error in there. If that is the problem, then the solution is to delete the current stack and reinstall but to set the AlreadyHaveConfigSetup parameter to Yes.

Oops, accidentally closed the issue.

@svozza when you say "delete the current stack", are you referring to delete the stack of "aws-perspective-833543886316-us-east-1" ? and reinstall everything with setting the AlreadyHaveConfigSetup parameter to Yes. https://docs.aws.amazon.com/solutions/latest/aws-perspective/automated-deployment.html#step-1.-launch-the-stack?
Do i need to delete the stack "digital-architecture-diagrams-from-perspective" before reinstall? Thanks

Follow the steps here to completely uninstall the solution: https://docs.aws.amazon.com/solutions/latest/aws-perspective/appendix-f-uninstall-the-solution.html. Then reinstall with that option changed.

@svozza  Yes, after delete both stacks and reinstall with setting the AlreadyHaveConfigSetup parameter to Yes, the page is loading now. Thank you so much for the help~

No problem, glad we got it sorted!


Timestamp timezone and exceptions

Resolve #123.
In addition, we remove the exception handling since it is taken care of in the benchmark.

Codecov Report

Merging #125 into master will increase coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #125      +/-   ##
==========================================
+ Coverage   35.68%   35.70%   +0.01%
==========================================
  Files          24       24
  Lines        1788     1787       -1
==========================================
  Hits          638      638
+ Misses       1150     1149       -1

Impacted Files
Coverage Δ

orion/primitives/azure_anomaly_detector.py
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 797e95d...bcf1159. Read the comment docs.


Fix plugin application order (#15664)

Fixes #15664
Contributor Checklist

[x] Review Contribution Guidelines
[x] Make sure that all commits are signed off to indicate that you agree to the terms of Developer Certificate of Origin.
[x] Make sure all contributed code can be distributed under the terms of the Apache License 2.0, e.g. the code was written by yourself or the original code is licensed under a license compatible to Apache License 2.0.
[x] Check "Allow edit from maintainers" option in pull request so that additional changes can be pushed by Gradle team
[x] Provide integration tests (under <subproject>/src/integTest) to verify changes from a user perspective
n/a Provide unit tests (under <subproject>/src/test) to verify logic
n/a Update User Guide, DSL Reference, and Javadoc for public-facing changes
[x] Ensure that tests pass sanity check: ./gradlew sanityCheck
[x] Ensure that tests pass locally: ./gradlew <changed-subproject>:quickTest

Gradle Core Team Checklist

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation
[ ] Recognize contributor in release notes

@bot-gradle test this

OK, I've already triggered ReadyForMerge build for you.

@bot-gradle test this

OK, I've already triggered ReadyForMerge build for you.

@bot-gradle test QF

OK, I've already triggered QuickFeedback build for you.

@bot-gradle test this

OK, I've already triggered ReadyForMerge build for you.

I can sure add such a note, but I guess not in the release notes, but in the upgrade guide, right? (see the confusion I meant in Slack? :-) )
Do you maybe an idea about the failing test?
I indeed can reproduce the failure here. If I run that failing test, I get the same error after 3 hours:
Condition failed with Exception:

validatePlugins()
|
java.lang.IllegalStateException: The following plugins were validated but you didn't explicitly check the validation outcome: [org.asciidoctor.gradle.jvm.AsciidoctorJPlugin]
	at org.gradle.smoketests.WithPluginValidation$AllPluginsValidation.performValidation(WithPluginValidation.groovy:122)
	at org.gradle.smoketests.GradleBuildExternalPluginsValidationSmokeTest.validatePlugins(GradleBuildExternalPluginsValidationSmokeTest.groovy:82)
	at org.gradle.smoketests.GradleBuildExternalPluginsValidationSmokeTest.performs static validation of plugins used by the Gradle build(GradleBuildExternalPluginsValidationSmokeTest.groovy:73)

	at org.gradle.smoketests.GradleBuildExternalPluginsValidationSmokeTest.performs static validation of plugins used by the Gradle build(GradleBuildExternalPluginsValidationSmokeTest.groovy:73)
Caused by: java.lang.IllegalStateException: The following plugins were validated but you didn't explicitly check the validation outcome: [org.asciidoctor.gradle.jvm.AsciidoctorJPlugin]
	at org.gradle.smoketests.WithPluginValidation$AllPluginsValidation.performValidation(WithPluginValidation.groovy:122)
	at org.gradle.smoketests.GradleBuildExternalPluginsValidationSmokeTest.validatePlugins(GradleBuildExternalPluginsValidationSmokeTest.groovy:82)
	... 1 more

Yes in the upgrade guide 😉
I am not sure I fully understand the failure. Adding that plugin into the ones validated on current main branch does not fail the test. So I suggest you just add it next to the other asciidoc entries.

Do you mean to the list of ids in the passingPlugins closure? (I'm not sure what that test is actually doing, so I'm not sure how to properly fix it or if I understood correctly what you mean)

In case I did get you correctly, a new push is there, also including the breaking section

@bot-gradle test and merge

OK, I've already triggered a build for you.

@Vampire Thank you for the contribution!

@big-guy I was looking for a mention of this in the release notes: https://gradle.org/releases/, but it's not showing there. Is it because of the 7.3-RC1 milestone?

There is an indirection: because this impacts anyone upgrading across the 7.2 / 7.3 boundary, it is documented in upgrade notes which is linked from release notes.

@ljacomet but the issue/PR is not mentioned in the list of fixes, is it intentionally excluded?


Logger 2.3 refactor

Bump Minimum Ruby to 2.3
Use Ruby 2.3 logger implementation (Much better)
Rubocop / refactoring done according to new min ruby version

Ping @tgaff / @ineverov - Bout time we had a new feature and a chunky change to this gem. So here it is.
Note this forces the minimum ruby up 1 point again. I'll make additional changes in other PR's to tweak docs / travis versions accordingly.

Re-review @ineverov now I've fixed everything up. CI is green and made review points


Docs: Create a developer landing page for Aspects / Analytics

Currently https://openedx.org/community/documentation/ has a missing link to the Insights API. We should:

Create a top level "developer" Aspects page with links to appropriate other pages in this epic and the data models
Create an anaytics top level page in docs.openedx.org with links to:

Tracking log documentation / event list
Aspects / aspects developer docs

Request an update to the openedx.org link above to link out to the high level pages above

Does this still applies or the other documentation is enough?

Looks like this has been changed in the meantime, so it should be fine.


first-line-h1 insufficient replacement for first-heading-h1

There is times that the first line is not desired as a header (e.g. a TOC) but that we want to ensure the first header (which follows TOC) is in fact H1. This does not appear possible with first-line-h1

Agreed. I'm not sure the behavior you describe is entirely in keeping with the intent of MD041/first-line-heading, anyway.
However, it could be a reasonable thing for MD001/heading-increment to enforce, assuming it got a new parameter starting_level which would be set to 1 in your case.
https://github.com/DavidAnson/markdownlint/blob/main/doc/md001.md

@DavidAnson starting_level option on MD001/heading-increment would certainly work!


⚠ Bofrost.lu has degraded performance

In 0657985, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1824 ms

Resolved: Bofrost.lu performance has improved in 2bd63af after 30 minutes.


New HTML cleanup in post contents is too extreme

I noticed that certain posts containing img tags don't display the expected image, when seen from an up-to-date server, running the git version.
Then I checked, and I saw that the "content" field in the JSON itself was being "sanitized". It's not a matter of webUI display, the received JSON itself is different, for any client.
The culprit seems to be this commit: https://github.com/e14n/pump.io/commit/49dcced750edd7570503dd5ed9387a41b85bdb77
The relevant line has this comment:
// using defaults
// { allowedTags: ['b', 'i', 'em', 'strong', 'a'], allowedAttributes: { a: ['href']}}
So this could probably be easily configured to allow style and img tags without compromising security.
As it is now, users of up-to-date git servers are not seeing posts with img tags in them, which is quite common to have in the Pump network.
Also, less serious but still annoying, the fact that the style tags are removed makes most of the styling produced by the Dianara client invalid. Dianara uses Qt's richtext engine, which means that most of the visual stuff depends on style tags. Even b is turned into a style someParams.
P.S.- BTW, I've now checked that this alterations happen also with outgoing stuff, so posting with an img tag is not possible either. Those will be silently dropped from people's posts.
P.S.2.- Even if the post doesn't use those 'forbidden' tags, the 'sanitation' seems to add extra p tags between lines which were separated by br, or something like that. However it's done, it seems to result in posts with more spaces between lines. It's not very nice.

I'd say it's critical to fix this before 1.0

Whoa whoa whoa. It's stripping the content of messages coming from other servers? This is totally wrong.
Post content should be left unmodified. Sanitization is a client (in this case Web UI) matter

@oshepherd AFAIK that's the intended behavior. The reason it's done is for anti-XSS - the intention isn't to screw around with anyone's content.
/cc @evanp

@jankusanagi related issue: we can't allow arbitrary CSS.
http://stackoverflow.com/questions/3607894/cross-site-scripting-in-css-stylesheets

I merged this because now master is at least less broken than it used to be, but that being said, we still need feedback from @evanp. Reopening.

Yes. Sanitising the HTML that is displayed is fine and correct.
Modifying the data sent over the wire is wrong. The JSON and embedded
content of an object sent over the wire should be unchanged.
Sanitising content before display is a client problem, not a server
problem. Note that the web UI and clients render raw content from remote,
untrusted servers. You cannot perform this sanitising server side.
On 2 Jun 2016 2:38 a.m., "Alex Jordan"<EMAIL_ADDRESS>wrote:
@oshepherd https://github.com/oshepherd AFAIK that's the intended
behavior. The reason it's done is for anti-XSS - the intention isn't to
screw around with anyone's content.
/cc @evanp https://github.com/evanp
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/e14n/pump.io/issues/1169#issuecomment-223173464, or mute
the thread
https://github.com/notifications/unsubscribe/AAhH3ALaSvI1vteyzKSgnAWz-SpJvsNGks5qHjP5gaJpZM4IpJ95
.

Relevant spec sections:
http://activitystrea.ms/specs/json/1.0/#republisher
http://activitystrea.ms/specs/json/1.0/#security
Honestly, I'm not quite sure if we're violating spec or not.
In any case, I sent an email to Evan. It's his call to make, not mine.

It seems pretty clear to me from:
When a Re-publisher transmits an object, the Re-publisher MUST maintain the
full integrity of theobject, including any extension properties, and retain
the original id value
That modifying an object is prohibited.
Regardless, as said, the web UI accesses data from remote servers hence
must be capable of local sanitisation of objects
On 2 Jun 2016 9:53 p.m., "Alex Jordan"<EMAIL_ADDRESS>wrote:
Relevant spec sections:
http://activitystrea.ms/specs/json/1.0/#republisher
http://activitystrea.ms/specs/json/1.0/#security
Honestly, I'm not quite sure if we're violating spec or not.
In any case, I sent an email to Evan. It's his call to make, not mine.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/e14n/pump.io/issues/1169#issuecomment-223418901, or mute
the thread
https://github.com/notifications/unsubscribe/AAhH3IhH6VQwzpKO9V7O31GeiYKW1xHRks5qH0LIgaJpZM4IpJ95
.

This was discussed in the last meeting and we're going to continue to sanitize incoming objects, even though it's a violation of spec.
@oshepherd I'll look into the web UI too, and make sure it handles this properly.

FYI the plan for this is at cure53/DOMPurify#176
CSS will be retained and there will be very little to no impact on "good" objects.

Fixed in master.


Needs to solve shrinkage of profile photos

After chosing all pairing technologies a shrinkage occurs on profile images and the delete button is sliding to left.

A little movement is fine (it was intentionally designed that way by @kevcomedia to allow the image to be responsive), but I think a minimum scale size that is still reasonable is a good idea.

I should have added min-width and min-height.

@kevcomedia yeah, leaving the low hanging fruit for newbies is my thinking too :)

fixed it :)


significance of unitrange returning row vector vs. column vector

I have an UnderdeterminedProblem I'm trying to solve with BLUEs, and I think I have all the arguments with the exact same dimensions/domains/ranges as a previous problem that I could solve with no errors. However, now, I'm throwing a "matrices not dimensionally conformable for addition" error at line 320 in the BLUEs.jl, which is
    Cyy = up.E*Cxy + up.Cnn

The only difference I can find between my arguments for the problems is that, in the new problem, unitrange(Cnn) returns a row vector instead of a column vector, as it does in the problem I could solve successfully. The row vector is equal to the transpose of the column vector however. Is there any significance to this? The show() of the two Cnn matrices has values + units as I would expect.
I also could be totally barking up the wrong tree here.

sounds like an error in the code.  unitdomain and unitrange should have been designed to be regular (column) vectors. Is this a standard case? If not, please show how to produce a "bad" Cnn.

 I was thinking maybe it would be nice to have, perhaps somewhere in BLUEs, a generic guideline to what the unitdomain and unitrange of each argument to a Problem should be, because this is the second time I've burned up over an hour fighting with the units (or maybe I should just write a guide for myself!)

Okay this all makes sense! I wasn't actually calling size on the unitdims, just going off the REPL-show, which is probably a good lesson to not take that at face value.
That makes sense about the Cnn, for some reason I have an older script where Cnn is not in that form (has all units on the range, but it still works... Need to look more into what's going on there), which was not helping my confusion this morning. Do you think that there should be a warning or error if you try to provide a Cnn that does not have unitrange .== unitdomain .^-1, or is that too constraining?
The unitless matrix times Unitful matrix is just coming from trying to multiply the SVD U, $\Sigma$ into the problem (has to multiply y, and Cnn) - I had just assumed if I did that multiplication, the units would work out fine, but that was evidently not case.

Great idea to include a warning!  There is already a Boolean operator that will help for this purpose:
https://ggebbie.github.io/UnitfulLinearAlgebra.jl/dev/#UnitfulLinearAlgebra.unit_symmetric-Tuple{UnitfulLinearAlgebra.AbstractUnitfulType}
Are you using the function svd with a UnitfulMatrix or the dimensional singular value decomposition dsvd?   Here is the documentation for dsvd. It's not the same as the SVD but it is more relevant for matrices with units.
https://ggebbie.github.io/UnitfulLinearAlgebra.jl/dev/#UnitfulLinearAlgebra.dsvd-Tuple{AbstractUnitfulVecOrMat{T, 2} where T, AbstractUnitfulVecOrMat{T, 2} where T, AbstractUnitfulVecOrMat{T, 2} where T}
https://ggebbie.github.io/UnitfulLinearAlgebra.jl/dev/#UnitfulLinearAlgebra.DSVD
You could use identity matrices for the numerical part of the norm matrices that go into dsvd.

I'm doing the SVD on a water mass composition matrix, so it is unitless, and I'm just doing LinearAlgebra.SVD on a regular matrix. Would that be your recommendation for a problem with a lot of Unitful matrices elsewhere, or do you think I should do the ULA.SVD on a Unitful matrix with no units?

Neither. My (surprising) recommendation is to use the Dimensional Singular Value Decomposition (UnitfulLinearAlgebra.dsvd).
Some background points:

With a dimensionless matrix, the SVD exists. There is nothing wrong with using the SVD.

If I understand your case correctly, you have a dimensionless matrix but the unit domain and unit range have dimensions. In other words, your original matrix accepts uniform vectors (with units) in multiplication. Both the unit domain and range are uniform with the same units, which gives you a dimensionless matrix. A dimensionless matrix is also a uniform matrix, where there is uniformly "no units" everywhere in the matrix. For a uniform matrix, you have the option of taking the SVD or the Dimensional Singular Value Decomposition.

The SVD and the DSVD are different when the unit domain and unit range have dimensions. The difference is in how the units are distributed amongst the three components of the decomposition.

Taking the SVD, you will get U, Lambda, and V are all dimensionless.
Taking the DSVD, you will get a uniform U with units equal to the reciprocal of the unit domain, Lambda is dimensionless, and V has units equal to the unit domain.
Why Dimensional SVD here?   In this particular problem, I believe you are using the right singular vectors (V) has a basis set. Using the DSVD, the right singular vectors will naturally have the units of the input of the matrix of interest. Therefore, a quantity like V*u, where u is a control vector that you are solving for, will allow you to have a dimensionless u. All of the necessary units are taken care of by V.
Why try to solve for a u that is dimensionless?  Optimization routines typically work best when they are solving for a normalized variable, like a series of independent and identically distributed variables. When variables have units, this normalization step must account for the units as well. After normalization, all units are removed.
There are downsides to this approach as well. Extra arguments have to be passed to the dsvd routine relative to svd. Here is one way to do a simple dsvd.
using Unitful, UnitfulLinearAlgebra, LinearAlgebra
urange = [u"K",u"K"]
udomain = [u"K",u"K",u"K"]
A = UnitfulMatrix(randn(length(urange),length(udomain)),urange,udomain)
Pr = UnitfulMatrix(I(length(urange)),urange.^-1,urange)
Pd = UnitfulMatrix(I(length(udomain)),udomain.^-1,udomain)
U,Λ,V = dsvd(A,Pr,Pd)


Fix argument mutation in fit_lc and mcmc_lc

I ran into a bug where the fitting functions would modify the bounds argument before copying it. For example:
import sncosmo

model = sncosmo.Model('salt2')
data = sncosmo.load_example_data()
bounds = {'z':(0.3, 0.7)}
result, fitted_model = sncosmo.fit_lc(
    data, model,
    ['z', 't0', 'x0', 'x1', 'c'],
    bounds=bounds)

print(bounds)
> {'z': (0.3, 0.7), 't0': (54995.0, 55180.0)}

This PR makes minor changes in fit_lc and mcmc_lc where instead of using
if bounds is None:
    bounds={}

the bounds are copied as
bounds = copy.deepcopy(bounds) if bounds else {}

It also adds a few tests to validate the above change.

My attention was focused elsewhere last week but it's back now. I'll simplify the test and switch to pytest sometime this week.

No problem. I haven't yet found the time to do a release!

Turns out the original fork for this PR was deleted. See PR #260 instead.


Disable browser cache of page tree

Short description

Disable browser cache of page tree
Proposed changes

Set HTTP header Cache-Control: no-store, must-revalidate

Resolved issues

Fixes: #1179

Let's deploy to see if this works with mod_wsgi.


Corrected Turkish context menu texts' encoding errors.

Corrected Turkish context menu texts' encoding errors. For example, Windows Gezgini ba�lam men�s�ne "%1 �le A�" eylemini ekle changed to Windows Gezgini dizin bağlam menüsüne "%1 İle Aç" eylemini ekle.

@microsoft-github-policy-service agree [company="@ravlico"]

@microsoft-github-policy-service agree company="ravlico"

Opened an issue. #167706

@microsoft-github-policy-service agree company="ravlico"

The source of our loc files is https://github.com/microsoft/vscode-loc, please submit your PR there


blueman: hicolor_icon_theme dependency

Motivation for this change
blueman conflicts with other packages that use hicolor_icon_theme
Things done

[x] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] OS X
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Thanks!


To disable WebAudio solely.

Build with "-Ddisable_web_audio" will reduce size by 0.3M.
Details of patch:
(1) The macro 'DISABLE_WEB_AUDIO' will disable the WebAudio related
code in 'content' folder.
(2) Set the building flag 'use_openmax_dl_fft' to 0 will disable the
WebAudio related code for Android in blink eventrually, leveraging
the macro 'ENABLE_WEB_AUDIO'.

@d0ngjun @halton
This patch is the xwalk's part to disable web audio.

@d0ngjun @halton
This patch is the xwalk's part to disable web audio.

@d0ngjun

LGTM


Change  buttonBarView colors after viewDidLoad

Hello, I've been using this library successfully for quite sometime.
I usually setup by buttonBarView by calling this code before viewDidLoad()
        settings.style.buttonBarItemBackgroundColor = DynamicColor.dynamicBackgroundColor2.themeColor
        settings.style.selectedBarBackgroundColor = DynamicColor.selectedMenuColor.themeColor
        settings.style.buttonBarItemTitleColor = DynamicColor.unselectedMenuColor.themeColor
        settings.style.buttonBarItemFont = .boldSystemFont(ofSize: 14)
        settings.style.selectedBarHeight = 2.0
        settings.style.buttonBarMinimumLineSpacing = 0
        settings.style.buttonBarItemsShouldFillAvailableWidth = true
        settings.style.buttonBarLeftContentInset = 0
        settings.style.buttonBarRightContentInset = 0

        changeCurrentIndexProgressive = { (oldCell: ButtonBarViewCell?, newCell: ButtonBarViewCell?, progressPercentage: CGFloat, changeCurrentIndex: Bool, animated: Bool) -> Void in
            guard changeCurrentIndex == true else { return }
            oldCell?.label.textColor = DynamicColor.unselectedMenuColor.themeColor
            newCell?.label.textColor = DynamicColor.selectedMenuColor.themeColor
        }
        buttonBarView.contentOffset = CGPoint(x: 0, y: 0)

This code works great. Howver, in my app, users can choose whether they want dark mode or light mode in the app settings.
So, is it possible to change buttonBarView's colors after viewDidLoad? Or am I forced to re-instantiate  the entire viewController?

Looks like the only way to achieve this was to naturally re-call viewDidLoad by re-instantiate the vc.
Ex; the vc was a child viewcontroller, so I did this
myVC.removeFromParent()
myVC = storyboard?.instantiateViewController(identifier: "MyVC") as? MyVC
addChild(myVC)

Looks like the only way to achieve this was to naturally re-call viewDidLoad by re-instantiate the vc.
Ex; the vc was a child viewcontroller, so I did this
myVC.removeFromParent()
myVC = storyboard?.instantiateViewController(identifier: "MyVC") as? MyVC
addChild(myVC)


Modal dialog makes IE freeze

Dialog Polyfill Version:
dialog-polyfill-0.4.6
What browser(s) is this bug affecting:
IE version 11.0.9600.18537
What OS (and version) are you using?
Window 7 Enterprise SP1
What are the steps to reproduce the bug? Can you create a plunker/codepen/jsfiddle which reproduces it?

Open the demo page: https://demo.agektmr.com/dialog/
Click on the "Open modal dialog" button
IE11 freezes
Only way to terminate IE is to kill it in task manager

What is the expected behavior?
It should emulate a modal dialog
What is the actual behavior?
IE11 freezes
Any other information you believe would be useful?
dialog-polyfill-0.4.5, works as expected.

I can confirm this bug.

This is also happening for us. But with version 0.4.5 and IE 11.576.14393.0. This wasn't a problem with earlier versions of IE11. Check it out at: https://heymath.com

I am experiencing the same problem here on 0.4.6, reverting to the version i used previously (0.4.3) resolves the issue.

We've reverted to 0.4.5 to fix the issue.

Apologies, I've fixed this on 0.4.7. This was a bug to do with tab focusing.

Thanks for the quick fix :)


Settings key not working

couple of reports about this; check older versions also

So far unable to reproduce this, but the issue may be partly due to the button size

Changed underlying view from ImageView to ImageButton
Separated the button from other elements
Adjusted key width


[otbn] Introduce a prefetch stage to enable register file blanking

We are considering implementing blanking in OTBN. This is where certain control and data paths are zeroed out when they are not in use to prevent data leakage. The register file would be the primary target for blanking, unless a particular register read port is actually required its address will be blanked off as well as the corresponding data output. This ensure that when instructions that don't read from a register are executed we're not generating a power signature from unused register reads.
The current OTBN single-stage design is an issue here, as the register address bits come straight from the instruction, and the enable used for blanking would be calculated from those instruction bits. This can result in glitching where in particular cycle the register file address may change and then get zeroed some time later, generating the power signature we seek to avoid.
The fix is to have a pre-decode the cycle before that calculates the blanking enables and the read address which is flopped. The register file inputs are then taking from those flops.
To do this in OTBN instructions would need to be fetched one cycle earlier (or we halve the speed of OTBN). We could introduce a 'prefetch' stage which would stay one instruction ahead of the OTBN core, it'd be loop aware so only for branches would it fetch an instruction that's not required.
The prefetch stage would provide OTBN with a flopped instruction and predecoded register control each cycle and the PC of the next instruction it intended to fetch. If the PC of the next instruction doesn't match with the instruction OTBN wants the register file will be blanked the following cycle and the PC actually required fetched. This will give a one cycle bubble. It should only occur around taken branches.
It wouldn't be strictly necessary for the prefetch stage to calculate a PC separately from OTBN core. We should be able to produce a design where the prefetch stage always has a correct PC other than for branches. However as OTBN has so far been designed as a single stage, leaving its PC logic untouched, with the prefetch seen as a new block bolted onto the side (to OTBN it would look much like the current imem, it just had extra pre-decode outputs) would be less distruptive plus provide some extra hardening against fault injection at a minimal cost.
Another option would be to use the clock negative edge with predecoded inputs flopped on the negative edge, then used by logic that's flopped on the positive edge. However OTBN has some large paths so this is likely to cause timing issues. Some brief experimentation would be worth-while e.g. seeing if OTBN core would clock at 250 MHz (double current frequency plus some head room).

The prefetch stage will be implemented, implementation issue is here: https://github.com/lowRISC/opentitan/issues/8994


build: removing alwayslink

Fixes https://github.com/envoyproxy/envoy-mobile/issues/175

Ok CI is happy, PTAL :-)


Updated help text for 2fa in two_factor.rb

Edited the CLI help text for the twofactor command and moved the first comment directly before the definition of the TwoFactor class to resolve the issue that the main help text for the twofactor command was missing:
stack           #  manage the stack for an app
status          #  check status of heroku platform
twofactor       #
update          #  update the heroku client
version         #  display version

I did not test this fix so please double check that everything is ok before you merge it.

thanks! This seems wrong still though (although nothing that you changed)
☸ ~/s/g/h/heroku heroku help twofactor
Usage: heroku 2fa

 Display whether two-factor authentication is enabled or not

Additional commands, type "heroku help COMMAND" for more details:

  2fa:disable                  #  Disable two-factor authentication for your account
  2fa:generate-recovery-codes  #  Generates and replaces recovery codes

Should we change the help text from 2fa to twofactor?

Also, I think we should stick with just auth instead of authentication since now it's our longest message
☸ ~/s/g/h/heroku heroku help
Usage: heroku COMMAND [--app APP] [command-specific-options]

Primary help topics, type "heroku help TOPIC" for more details:

  addons    #  manage addon resources
  apps      #  manage apps (create, destroy)
  auth      #  authentication (login, logout)
  config    #  manage app config vars
  domains   #  manage custom domains
  logs      #  display logs for an app
  ps        #  manage dynos (dynos, workers)
  releases  #  manage app releases
  run       #  run one-off commands (console, rake)
  sharing   #  manage collaborators on an app

Additional topics:

  certs        #  manage ssl endpoints for an app
  commands     #  list all commands
  drains       #  display drains for an app
  features     #  manage optional features
  fork         #  clone an existing app
  git          #  manage git for apps
  help         #  list commands and display help
  keys         #  manage authentication keys
  labs         #  manage optional features
  maintenance  #  manage maintenance mode for an app
  members      #  manage membership in organization accounts
  orgs         #  manage organization accounts
  pg           #  manage heroku-postgresql databases
  pgbackups    #  manage backups of heroku postgresql databases
  plugins      #  manage plugins to the heroku gem
  regions      #  list available regions
  stack        #  manage the stack for an app
  status       #  check status of heroku platform
  twofactor    #  manage two-factor authentication settings for your account
  update       #  update the heroku client
  version      #  display version

in fact, I sort of think it should just be manage two-factor settings. It's clear that it has to do with authentication and for your account is obvious.

"Two-factor" is an adjective that qualifies "authentication", the noun. I strongly feel that the term we use should be "two-factor authentication" or "two-factor auth". If we just say two-factor by itself, then we are using two-factor as a noun which, in my opinion, is not correct.
However, at the end of the day, what matters is that there's useful help text for people to read. It's not like we're localizing this and have to worry about being consistent for a translation memory database. Do whatever you think is best.
I'm OK with the rest of your suggestions.

could we make it manage two-factor authentication settings?

yes

:sparkles:
Thank you!

:+1: - thanks for spotting that this was missing @mbren


⚠ 29-Nov Govee AWS Issue

There seems to be an issue with regards to the AWS connection the plugin makes.
Example logs:
Generally and when restarting
[29/11/2022, 18:22:52] [Govee] [Device] [AWS-D] close event.
[29/11/2022, 18:22:52] [Govee] [Device] [AWS] close event.

When controlling a device
[29/11/2022, 18:22:52] [Govee] [Device] not using AWS connection as not connected to AWS
[29/11/2022, 18:22:52] [Govee] [Device]  could not be updated as no connection method available at...

I believe this is a Govee connection issue as this has started with no changes to the plugin. However I am also aware the Govee app is still working. So will monitor this for now.

Indeed I am seeing this same issue. As of now, my Govee tower fans have ceased to respond to commands via voice command/homekit (although showing as though they are functional and executing commands properly in homekit.) Many of the other devices are extremely slow to respond. (with logs indicating "slow to respond.")
I updated from 7.1.9 to 7.2 thinking it may be a plugin issue before seeing this thread. No change obviously.

Can confirm, I did some testing reverting to older versions of the plugin as well and still have the same issue.

I too am seeing the same connection errors.
I can turn the device on and off but my scenes aren’t working anymore

I too am seeing the same connection errors.
I can turn the device on and off but my scenes aren’t working anymore

Are you also seeing a MASSIVE slowdown in the response time between command and action on devices? My scenes don't work but the slowdown is what is really making me want to flip tables.
@bwp91 any insights on what Govee/AWS may have buggered up here?

Yes.  The response time has increased significantly.

I have the same issue. I tried to use the API key and it works:
https://github.com/bwp91/homebridge-govee/wiki/Configuration#obtaining-your-api-key

I have the same issue. I updated API, and the lights seem to work a bit better, but still get the same error in the logs.

I tried going full LAN/API by deleting email/pw from config but the only thing different was the language of the error codes I got in the logs (back to the ol "The write handler for the characteristic 'On' on the accessory 'Main Hallway 4' didn't respond at all!. Please check that you properly call the callback!""
Other than that, lights seem to be just as slow and fans/humidifier/purifier all have ceased to respond at all. I can see the power state change in the logs, but the device doesn't turn on/off at all.

Just checked logs this morning and basically this is all I get
[30/11/2022, 12:51:30] [Govee] [AWS] close event. [30/11/2022, 12:51:31] [Govee] [DreamView T1 Pro] [AWS-D] reconnect event. [30/11/2022, 12:51:32] [Govee] [DreamView T1 Pro] [AWS-D] close event. [30/11/2022, 12:51:34] [Govee] [AWS] reconnect event. [30/11/2022, 12:51:34] [Govee] [AWS] close event. [30/11/2022, 12:51:36] [Govee] [DreamView T1 Pro] [AWS-D] reconnect event. [30/11/2022, 12:51:36] [Govee] [DreamView T1 Pro] [AWS-D] close event. [30/11/2022, 12:51:42] [Govee] [AWS] reconnect event. [30/11/2022, 12:51:43] [Govee] [AWS] close event. [30/11/2022, 12:51:44] [Govee] [DreamView T1 Pro] [AWS-D] reconnect event. [30/11/2022, 12:51:44] [Govee] [DreamView T1 Pro] [AWS-D] close event.

Just opened my first Govvee product this morning, installed the plugin, and ran into same issue. (I thought it might have been related to not having a 23-digit Govee Device ID, but couldn't find that ID either way.)
Same AWS results in my logs as others posted here.

Just opened my first Govvee product this morning, installed the plugin, and ran into same issue. (I thought it might have been related to not having a 23-digit Govee Device ID, but couldn't find that ID either way.)
Same AWS results in my logs as others posted here.

For what it is worth, if all else fails in getting device ID, I have found using the Eve app (discovered when setting up scenes/modes for this plugin) also has the individual device ID's listed when you go into the device in the app.
And yeah, same AWS results as others.
This may be a silly question but has anyone here contacted Govee or seen anything from them regarding this? I can imagine with all the folks using Homebridge/HOOBS to integrate Govee this must be irking quire a few folks out there.

For what it is worth, if all else fails in getting device ID, I have found using the Eve app (discovered when setting up scenes/modes for this plugin) also has the individual device ID's listed when you go into the device in the app.

Also I just noticed the ID is in the hb plugin settings under 'My Devices'

For what it is worth, I tried calling Govee. As usual, I got the "all our customer service people are busy but please leave a voicemail" so I did.
I also posted up on their community forums to see if others are having the same issue and perhaps get someone from Govee to respond.
https://www.govee.com/posts/117105

For what it is worth, I tried calling Govee. As usual, I got the "all our customer service people are busy but please leave a voicemail" so I did.
I also posted up on their community forums to see if others are having the same issue and perhaps get someone from Govee to respond.
https://www.govee.com/posts/117105

Sooooooooo in my thread on the Govee community forum Govee actually responded.
"Hey there, I've checked with the tech team. The Govee API works properly and we do not offer any API for AWS."
@bwp91  any thoughts?

Next thing you know they’ll be telling us to clear our cookies or try another browser.

hope you can fix it :-)

Can anyone try the new beta?

The Govee API works properly and we do not offer any API for AWS

Govee are correct. Their public documented connection methods are their API and LAN mode. And the API has not stopped working. This is why API supported lights are still working albeit much slower.
Govee does not document their AWS and BLE connection methods and so they have no reason to help with situations like this ticket.
It’s logical for them, that they would want users to use their app rather than via a plugin like this.

api limit of 1000 being reached in a matter of minutes. Then it doesn't work any more.
[12/1/2022, 8:52:55 AM] [Govee] Govee API quota limits reached, will try again in 10 minutes...
[12/1/2022, 8:52:55 AM] [Govee] Unfortunately the plugin will not work until fully initialised.

New beta version working much better for me 👍🏻

The beta has restored AWS control!

All hail the beta!
Scenes are working :-)

updated to 7.3 and while the AWS error codes are gone, I now get this in the logs on reboot of the bridge:

How can I install the beta ?
Which command ?

@tommyMX you can update to 7.3.0 now
@CadLiara just realised there is an issue with hoobs - looking into this now

updated to 7.3 and while the AWS error codes are gone, I now get this in the logs on reboot of the bridge: 12/1/2022, 7:13:43 AMGVEEGoveeWARNING[HTTP] could not use existing access token as does not exist, this is normally not an issue. 12/1/2022, 7:13:43 AMGVEEGovee[HTTP] login successful. 12/1/2022, 7:13:44 AMGVEEGoveeWARNING[HTTP] disabling client as ENOENT: no such file or directory, open '/var/lib/hoobs/gvee/persist/govee.pfx'. 12/1/2022, 7:13:44 AMGVEEGoveeWARNING[AWS] disabling client as requires HTTP client.
Functionally, the response times remain about the same as before. Any thoughts Ben? Do I need to request a new API token?

@CadLiara can you go into the hoobs terminal and type this command:
sudo mkdir /var/lib/hoobs/gvee/persist

and then restart?

Done.
That fixed the responsiveness issue and the appliances are back online.
I am getting the logs flooded with "AWS event" and a TON of "new scene code" messages for every device.
12/1/2022, 8:04:43 AMGVEEGovee[AWS] message event [{"proType":2,"sku":"H6062","device":"F3:74:7C:81:85:A1:AA:DB","softVersion":"1.02.03","wifiSoftVersion":"1.02.09","cmd":"status","type":0,"transaction":"v_1669910682286000","pactType":1,"pactCode":2,"state":{"onOff":1,"brightness":100,"colorTemInKelvin":0,"color":{"r":255,"g":204,"b":204},"mode":21,"result":1},"op":{"command":["qgUVAQAAAAAAAAAAAAAAAAAAALs=","qqUBZP/MzGT/zMxk/8zMZP/MzA4=","qqUCZP/MzGT/zMxk/8zMZP/MzA0=","qqUDZP/MzGT/zMxk/8zMZP/MzAw=","qqUEZP/MzGT/zMxk/8zMZP/MzAs=","qqUFZP/MzGT/zMxk/8zMZP/MzAo=","qhEAHg8PAAAAAAAAAAAAAAAAAKU=","qhL/ZAAAgAoAAAAAAAAAAAAAAKk=","qiP/AAAAgAAAAIAAAACAAAAAgHY=","qkEAORMAAAAAAAAAAAAAAAAAAME="]}}].
12/1/2022, 8:04:43 AMGVEEGovee[Glide] [AWS] receiving update {"source":"AWS","onOff":1,"brightness":100,"colorTemInKelvin":0,"color":{"r":255,"g":204,"b":204},"mode":21,"result":1,"commands":["qgUVAQAAAAAAAAAAAAAAAAAAALs=","qqUBZP/MzGT/zMxk/8zMZP/MzA4=","qqUCZP/MzGT/zMxk/8zMZP/MzA0=","qqUDZP/MzGT/zMxk/8zMZP/MzAw=","qqUEZP/MzGT/zMxk/8zMZP/MzAs=","qqUFZP/MzGT/zMxk/8zMZP/MzAo=","qhEAHg8PAAAAAAAAAAAAAAAAAKU=","qhL/ZAAAgAoAAAAAAAAAAAAAAKk=","qiP/AAAAgAAAAIAAAACAAAAAgHY=","qkEAORMAAAAAAAAAAAAAAAAAAME="]}.
12/1/2022, 8:04:43 AMGVEEGoveeWARNING[Glide] new scene code: [qgUVAQAAAAAAAAAAAAAAAAAAALs=] [aa051501000000000000000000000000000000bb].
12/1/2022, 8:04:43 AMGVEEGoveeWARNING[Glide] new scene code: [qqUBZP/MzGT/zMxk/8zMZP/MzA4=] [aaa50164ffcccc64ffcccc64ffcccc64ffcccc0e].
12/1/2022, 8:04:43 AMGVEEGoveeWARNING[Glide] new scene code: [qqUCZP/MzGT/zMxk/8zMZP/MzA0=] [aaa50264ffcccc64ffcccc64ffcccc64ffcccc0d].
12/1/2022, 8:04:43 AMGVEEGoveeWARNING[Glide] new scene code: [qqUDZP/MzGT/zMxk/8zMZP/MzAw=] [aaa50364ffcccc64ffcccc64ffcccc64ffcccc0c].
12/1/2022, 8:04:43 AMGVEEGoveeWARNING[Glide] new scene code: [qqUEZP/MzGT/zMxk/8zMZP/MzAs=] [aaa50464ffcccc64ffcccc64ffcccc64ffcccc0b].
12/1/2022, 8:04:43 AMGVEEGoveeWARNING[Glide] new scene code: [qqUFZP/MzGT/zMxk/8zMZP/MzAo=] [aaa50564ffcccc64ffcccc64ffcccc64ffcccc0a].
12/1/2022, 8:04:43 AMGVEEGoveeWARNING[Glide] new scene code: [qhEAHg8PAAAAAAAAAAAAAAAAAKU=] [aa11001e0f0f00000000000000000000000000a5].
12/1/2022, 8:04:43 AMGVEEGoveeWARNING[Glide] new scene code: [qhL/ZAAAgAoAAAAAAAAAAAAAAKk=] [aa12ff640000800a0000000000000000000000a9].
12/1/2022, 8:04:43 AMGVEEGoveeWARNING[Glide] new scene code: [qiP/AAAAgAAAAIAAAACAAAAAgHY=] [aa23ff0000008000000080000000800000008076].
12/1/2022, 8:04:43 AMGVEEGoveeWARNING[Glide] new scene code: [qkEAORMAAAAAAAAAAAAAAAAAAME=] [aa410039130000000000000000000000000000c1].
And the video/game mode AWS based scene codes I set up through Eve don't work.
But yeah, pretty huge improvement overall. Thank you Ben :)

No, this is normal. These codes help me with implementing new devices and features.
Can you post one of the video mode or game mode codes that you have configured?

I am getting this error for my 5083 on the new 7.3.0 update:
[12/1/2022, 8:06:20 AM] [Govee] [ Lights Mantle] not using AWS connection as this.awsClient.updateDevice is not a function at default.sendDeviceUpdate (file:///var/lib/homebridge/node_modules/homebridge-govee/lib/platform.js:1785:30).
[12/1/2022, 8:06:20 AM] [Govee] [Lights Mantle] could not be updated as no connection method available at file:///var/lib/homebridge/node_modules/homebridge-govee/lib/platform.js:1829:13.

Sure thing.
Video mode codes for:
G1 Pro H604A
MwUAAEcDAC4AAAAAAAAAAAAAAFw=||ptReal||
Dreamview T1 H6199
MwUAAAAyADIAAAAAAAAAAAAAADY=,qgUBAAAAAAAAAAAAAAAAAAAAAK4=||ptReal||
Happy to assemble other codes for other modes/devices for you if that helps

@lakeshow20  can you show logs that appear when restarting the plugin?

Same Issue for me as well. Below are the logs after the plugin restart.
[12/1/2022, 9:36:24 AM] [Govee] [AWS] client enabled.
[12/1/2022, 9:36:24 AM] [Govee] [HTTP] disabling client as Command failed: openssl pkcs12 -in "/var/lib/homebridge/persist/govee.pfx" -nodes -passin pass:a4121899
Error outputting keys and certificates
4057ADDC537F0000:error:0308010C:digital envelope routines:inner_evp_generic_fetch:unsupported:../crypto/evp/evp_fetch.c:349:Global default library context, Algorithm (RC2-40-CBC : 0), Properties ()
Error outputting keys and certificates.
[12/1/2022, 9:36:24 AM] [Govee] [AWS] disabling client as requires HTTP client.
[12/1/2022, 9:36:26 AM] [Govee] [HTTP] sync failed as this.httpClient.getDevices is not a function at default.goveeHTTPSync (file:///var/lib/homebridge/node_modules/homebridge-govee/lib/platform.js:1201:45).
[12/1/2022, 9:36:26 AM] [Govee] ***** Disabling plugin. *****
[12/1/2022, 9:36:26 AM] [Govee] ***** this.awsClient.connect is not a function at default.pluginSetup (file:///var/lib/homebridge/node_modules/homebridge-govee/lib/platform.js:712:30). *****
Log While trying to turn on/off the device:
[12/1/2022, 9:31:16 AM] [Govee] [Smart Space Heater 3] current state [on].
[12/1/2022, 9:31:19 AM] [Govee] [Smart Space Heater 3] not using AWS connection as this.awsClient.updateDevice is not a function at default.sendDeviceUpdate (file:///var/lib/homebridge/node_modules/homebridge-govee/lib/platform.js:1785:30).
[12/1/2022, 9:31:21 AM] [Govee] [Smart Space Heater 3] current state [off].
[12/1/2022, 9:31:28 AM] [Govee] [Smart Space Heater 3] not using AWS connection as this.awsClient.updateDevice is not a function at default.sendDeviceUpdate (file:///var/lib/homebridge/node_modules/homebridge-govee/lib/platform.js:1785:30).
[12/1/2022, 9:31:28 AM] [Govee] [Smart Space Heater 3] current light [on].
[12/1/2022, 9:31:29 AM] [Govee] [Smart Space Heater 3] not using AWS connection as this.awsClient.updateDevice is not a function at default.sendDeviceUpdate (file:///var/lib/homebridge/node_modules/homebridge-govee/lib/platform.js:1785:30).

@lakeshow20 or @DebasishBahinipati
it would be helpful for me to login to one of your accounts from my homebridge to see what is going on.
if you'd be happy for me to do this, we can message on discord
https://discord.gg/cMGhNtZ3tW

@lakeshow20 or @DebasishBahinipati it would be helpful for me to login to one of your accounts from my homebridge to see what is going on. if you'd be happy for me to do this, we can message on discord
https://discord.gg/cMGhNtZ3tW

I have provided the details in discord.

@lakeshow20 which platform are you running homebridge on?

Sorry for the delay in a response. I can provide access to my homebridge when I am back on my network. I have home bridge on an Unbuntu Linux machine.

Beta seems to be working for me

I am using 7.3.2.
But get some other errors. I am using Homebridge in a Synology docker.
[12/1/2022, 9:50:19 PM] [Govee] [HTTP] could not use existing access token as does not exist, this is normally not an issue.
[12/1/2022, 9:50:21 PM] [Govee] [HTTP] disabling client as OpenSSL issue - follow instructions at https://devdojo.com/howtoubuntu/how-to-install-openssl-on-ubuntu.
[12/1/2022, 9:50:21 PM] [Govee] [AWS] disabling client as requires HTTP client.
[12/1/2022, 9:50:22 PM] [Govee] [BLE] disabling client as EAFNOSUPPORT, Address family not supported by protocol at default.pluginSetup (file:///homebridge/node_modules/homebridge-govee/lib/platform.js:498:26).
Thank you

7.3.2 no issues.  Trying 7.3.3.

@tommyMX
can u update to the beta version? 7.3.3-beta.0
https://github.com/bwp91/homebridge-govee/wiki/Beta-Version

Looks good what I can see in the log:
12/1/2022, 10:16:52 PM] [Govee] [Wand 2] [API] receiving update {"online":true,"powerState":"on","brightness":1,"color":{"r":255,"b":37,"g":206},"source":"API"}.
[12/1/2022, 10:16:53 PM] [Govee] [AWS] message event [{"proType":2,"sku":"H6061","device":"F3:DF:C9:39:32:33:30:31","softVersion":"1.03.03","wifiSoftVersion":"1.02.11","wifiHardVersion":"1.00.10","cmd":"status","type":0,"transaction":"v_1669929412011000","pactType":1,"pactCode":3,"state":{"onOff":0,"brightness":1,"colorTemInKelvin":0,"color":{"r":255,"g":206,"b":37},"mode":21,"result":1},"op":{"command":["qgUVAAAAAAAAAAAAAAAAAAAAALo=","qqUBZP/OJQH/wzFk/7g9Af+tSXY=","qqUCZP+iVQH/lmEB/4ttZP+AeRI=","qqUDAf91hWT/aZIAAAAAAAAAAGI=","qhEAHg8PAAAAAAAAAAAAAAAAAKU=","qhL/ZAAAgAoAAAAAAAAAAAAAAKk=","qiP/AAAAgAAAAIAAAACAAAAAgHY="]}}].
[12/1/2022, 10:16:53 PM] [Govee] [Wand 1] [AWS] receiving update {"source":"AWS","onOff":0,"brightness":1,"colorTemInKelvin":0,"color":{"r":255,"g":206,"b":37},"mode":21,"result":1,"commands":["qgUVAAAAAAAAAAAAAAAAAAAAALo=","qqUBZP/OJQH/wzFk/7g9Af+tSXY=","qqUCZP+iVQH/lmEB/4ttZP+AeRI=","qqUDAf91hWT/aZIAAAAAAAAAAGI=","qhEAHg8PAAAAAAAAAAAAAAAAAKU=","qhL/ZAAAgAoAAAAAAAAAAAAAAKk=","qiP/AAAAgAAAAIAAAACAAAAAgHY="]}.
[12/1/2022, 10:16:53 PM] [Govee] [Wand 1] current brightness [0%].
[12/1/2022, 10:16:53 PM] [Govee] [Wand 1] new scene code: [qgUVAAAAAAAAAAAAAAAAAAAAALo=] [aa051500000000000000000000000000000000ba].
[12/1/2022, 10:16:53 PM] [Govee] [Wand 1] new scene code: [qqUBZP/OJQH/wzFk/7g9Af+tSXY=] [aaa50164ffce2501ffc33164ffb83d01ffad4976].
[12/1/2022, 10:16:53 PM] [Govee] [Wand 1] new scene code: [qqUCZP+iVQH/lmEB/4ttZP+AeRI=] [aaa50264ffa25501ff966101ff8b6d64ff807912].
[12/1/2022, 10:16:53 PM] [Govee] [Wand 1] new scene code: [qqUDAf91hWT/aZIAAAAAAAAAAGI=] [aaa50301ff758564ff6992000000000000000062].
[12/1/2022, 10:16:53 PM] [Govee] [Wand 1] new scene code: [qhEAHg8PAAAAAAAAAAAAAAAAAKU=] [aa11001e0f0f00000000000000000000000000a5].
[12/1/2022, 10:16:53 PM] [Govee] [Wand 1] new scene code: [qhL/ZAAAgAoAAAAAAAAAAAAAAKk=] [aa12ff640000800a0000000000000000000000a9].
[12/1/2022, 10:16:53 PM] [Govee] [Wand 1] new scene code: [qiP/AAAAgAAAAIAAAACAAAAAgHY=] [aa23ff0000008000000080000000800000008076].
Where can I disable the BLE thing? because I have no BT :-)

@tommyMX
can u update to the beta version? 7.3.3-beta.0
https://github.com/bwp91/homebridge-govee/wiki/Beta-Version

So where can I see the scenes in HB?

I can't see them :-(
Will I need BT? I haven't on my Synology .

@tommyMX
happy to message on discord,
https://discord.gg/cMGhNtZ3tW

Sorry guys have had to change how scene codes work in the config!
Happy to help convert any old scene codes to new ones if needed 👍🏻

Sorry guys have had to change how scene codes work in the config!
Happy to help convert any old scene codes to new ones if needed 👍🏻

Is there an easy way to convert existing codes?

For existing AWS codes, they are base64 strings that need to be converted to hex. You can use a site like this to convert:
https://cryptii.com/pipes/base64-to-hex
For existing BLE codes, there isn't an easy available way, I can provide a new version of these if you have any.

Thank you! And thanks for fixing it so quickly.

My hat off to you again Ben. Kudos on being seeing this unfold from the jump and being so on top of responses and cranking out updates to solve the issues as they pop up.
Just updated my scenes and they all work like a charm again.
Btw, what was the underlying issue that created this entire AWS debacle?

Best get in contact with govee support for an official answer 😆
They seemed to close a method of subscribing to devices via AWS, maybe it was an old method of authentication.
Being careful what I say. But the new method the plugin uses seems to work well and get things back to almost how they were before.
What a week! 😅


compose: Disable reply button if posting in stream not allowed.

Disables "Message X" and "Start new conversation" button in compose closed UI when a user is not allowed to send messages in a stream.
Fixes #28410.

Screenshots and screen captures:
Screenshots

Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[x] Explains differences from previous plans (e.g., issue description).
[x] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[x] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[x] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[x] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[x] Corner cases, error conditions, and easily imagined bugs.

@roanster007 can you review this?

@zulipbot add "buddy review"

@Vector73 the tooltip is having too much delay unlike that of the compose send button. Could something be done about that?

The delay is the same as what was used previously when direct messages were disabled. The simplest way I can fix this is by replacing EXTRA_LONG_HOVER_DELAY with LONG_HOVER_DELAY for tooltips on these buttons. But this will affect the tooltips which are shown when these buttons are not disabled. What do you think?

We don't want to reduce the delay when the buttons are enabled. How is this handled on the button that @roanster007 mentioned?

@Vector73 posted some comments. This may not be related to the issue, but shouldn't the keyboard shortcuts also be disabled when the stream post policy is disabled (Currently I am able to open the compose box using keyboard shortcuts).

This may not be related to the issue, but shouldn't the keyboard shortcuts also be disabled when the stream post policy is disabled? Currently I am able to open the compose box using keyboard shortcuts.

Yeah, that makes sense. @alya what do you think?

How is this handled on the button that @roanster007 mentioned?

The tooltip when the button is disabled uses EXTRA_LONG_HOVER_DELAY.

@roanster007 this is ready for another review.

@zulipbot remove "buddy review"

@zulipbot add "mentor review"

Thanks, @Vector73 !
Thinking about this more, I think it'll actually be better if we:

Disable the reply button, as was done on this PR.
Rather than disabling the "Start new conversation" button, have it open the compose box with the channel picker open, as we do when you don't have a channel selected.

Could you please update the PR for that? I'll edit the issue as well.

Rather than disabling the "Start new conversation" button, have it open the compose box with the channel picker open, as we do when you don't have a channel selected.

OK, updated the PR to make that change.

@zulipbot remove "mentor review"

@zulipbot add "maintainer review"

Sorry for the delay here! @amanagr are you up for reviewing this next?

If you use the browser back button to go to a stream where you cannot post, this implementation is gets bugged since the selected stream id for the compose box is not updated.
To reproduce:

Navigate to a stream where the logged in user cannot post.
Navigate to a different stream
Click the browser back button
Try to compose a message with the already selected stream.

Also, I don't like the amount of if conditions and changes this introduces in a single commit. Can we split the changes which change different parts of the UI?

Hey @Vector73 ,could I take up this from here?

Hello @Vector73,
Could you please share your email address so that I can include you as a co-author?
Thanks!

This implementation is bugged if you don't select a stream from the compose stream select dropdown.
Also, I don't like the amount of if conditions and changes this introduces in a single commit. Can we split the changes which change different parts of the UI?

Hello @amanagr ,
I have addressed this bug in my PR #32223 .Could you please take a look at it?
Thanks!

Closing in favor of #32223, which completed this effort.  Thanks @Vector73!


[Enhancement] Turn on table name restrictions

What type of PR is this：

[ ] BugFix
[ ] Feature
[x] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：

Fixes #14893
Problem Summary(Required) ：

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[x] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto backported to target branch

[x] 2.5
[x] 2.4
[ ] 2.3
[ ] 2.2

[FE PR Coverage Check]
:disappointed: fail : 1 / 2 (50.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/common/FeNameFormat.java
1
2
50.00%
[82]

run starrocks_admit_test

run starrocks_admit_test

@Mergifyio backport branch-2.5 branch-2.4


Project.getRepo is deprecated.

Use ::getRepositories instead
Project.getRepo (C:\Users\User\AppData\Local\atom\app-0.196.0\resources\app.asar\src\project.js:579:12)
Object.<anonymous> (C:\Users\User\.atom\packages\git-control\lib\git.coffee:15:17)
Object.<anonymous> (C:\Users\User\.atom\packages\git-control\lib\git.coffee:289:4)
Module._compile (module.js:452:26)

Duplicate of #64 . This bug has been fixed, just wait for the next release :)

:+1:
New release is probably going to come next week, until then this warning will pop up.


Send section problem

If a section is very complicated, it's size will overflow the buffer. Clients recieved the broken tiles data and throw an exception, it causes the section can't be shown correctly.
This bug only exists in modified server, vanilla server works well.
Expand the buffer can solve it as I tried.

This happens in a vanilla OTAPI server, or a TSAPI/OTAPI/Mintaka mix?
On Fri, Oct 19, 2018 at 22:49 Axeel<EMAIL_ADDRESS>wrote:

If a section is very complicated, it's size will overflow the buffer.
Clients recieved the broken tiles data and throw an exception, it causes
the section can't be shown correctly.
This bug only exists in modified server, vanilla server works well.
Expand the buffer can solve it as I tried.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/DeathCradle/Open-Terraria-API/issues/14, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AAggp4Z40ZDaTFeVUtxPjsUI2dQd79ihks5umrlKgaJpZM4Xxvmd
.

--
Lucas Nicodemus
http://keybase.io/xn

This happens in a vanilla OTAPI server, or a TSAPI/OTAPI/Mintaka mix?
On Fri, Oct 19, 2018 at 22:49 Axeel @.***> wrote: If a section is very complicated, it's size will overflow the buffer. Clients recieved the broken tiles data and throw an exception, it causes the section can't be shown correctly. This bug only exists in modified server, vanilla server works well. Expand the buffer can solve it as I tried. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#14>, or mute the thread https://github.com/notifications/unsubscribe-auth/AAggp4Z40ZDaTFeVUtxPjsUI2dQd79ihks5umrlKgaJpZM4Xxvmd .
-- Lucas Nicodemus http://keybase.io/xn

happens in both

it's easy to write a patch to fix it, but idk the appropriate size

If you have a WIP patch just send a PR and yolo it, someone else can step
in and tune it.
Lucas Nicodemus
http://keybase.io/xn
On Fri, Oct 19, 2018 at 11:04 PM Axeel<EMAIL_ADDRESS>wrote:

it's easy to write a patch to fix it, but idk the appropriate size
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/DeathCradle/Open-Terraria-API/issues/14#issuecomment-431552759,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAggp9usel5jJh64iFlwDFceKZLFhrgYks5umrzkgaJpZM4Xxvmd
.

Technical difficulties commenting on the PR, so this is what I was trying to say:
@AxeelAnder Basically if it's not a problem in vanilla and it can be replicated using stock OTAPI then it should be an OTAPI fix rather than TShock. However that fix is probably best suited for TShock, and if the guys are happy for that go nuts.
I had a quick look and I don't think that buffer is actually required with a bit more modification work, e.g. directly write the data from within NetMessage.CompressTileBlock by passing down the BinaryWriter from NetMessage.SendData; or similarly by redirecting the CompressTileBlock call in SendData to a OTAPI version so it can be done via C# instead of patching.
Though as fun as this sounds I don't have the time to do this so your fix should work fine via TShocks' config.


Added support for UIButton background images.

Added a new category called PINRemoteBackgroundImageCategory to add support for UIButtons to download and set background images using PINRemoteImage. In order to set a background image on a view, the view must adhere to PINRemoteBackgroundImageCategory.
Added a launch image to the demo project to add support for running the sample app in the iPhone 6/6+ simulator in full screen.
Added a new PINButtonCell class to the demo project to demonstrate the ability to download background images.
Added a switch to the main PINViewController class to allow switching from using PINImageCells and the new PINButtonCells

@mad102190 Instead of copying the implementations in PINRemoteImageCategoryManager.m, could you instead have all the existing methods take another parameter like an enum that indicates image type? For example you could have an enum that is PINViewTypeNormal, PINViewTypeBackground? What do you think?

Wouldn't this break existing implementations of the methods though? I initially thought of this, but after looking at similar libraries (i.e. SDWebImage), I figured it might be best to have specific methods for each image type.

@mad102190 I'm suggesting building it in a way that doesn't break existing implementations :)
Specifically adding all new category methods like you have, but instead of adding all new methods on PINRemoteImageCategoryManager, using the same implementation but adding an enum parameter which specifies the type?

Oh ok I see what you mean now. Sure, that works. I'll take a look shortly and update the PR.

@mad102190 I'm going to close this for now, if you decide to update it please reply and I can reopen.


[Event Request] Codeunit 7302 "WMS Management" - OnCheckWhseJnlLineOnBeforeCheckSourceJrnl

Hi team,
In Codeunit 7302 "WMS Management" procedure CheckWhseJnlLine, we would like to run some additional code when checking SourceJnl, for that an event with handler before performing the check would be a good solution:

[IntegrationEvent(false, false)]
local procedure OnCheckWhseJnlLineOnBeforeCheckSourceJrnl(var WhseJnlLine: Record "Warehouse Journal Line"; var Bin: Record Bin; SourceJnl: Option " ",ItemJnl,OutputJnl,ConsumpJnl,WhseJnl; var BinContent: Record "Bin Content"; Location: Record Location; DecreaseQtyBase: Decimal; var IsHandled: Boolean)

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


[WIP] - Fix #91

Hi @ciungulete !
Is this still WIP, as the title says?

Solves https://github.com/mollie/laravel-cashier-mollie/issues/91


ValueError: The passed save_path is not a valid checkpoint

Hi,
when I use your model for test_lanenet.py, it works fine, but when I try it with evaluate_lanenet_on_tusimple.py, the following error occurs:
ValueError: The passed save_path is not a valid checkpoint: ./model/tusimple_lanenet_vgg/tusimple_lanenet.ckpt
what's the problem here? Thank you.

@sam0983 Check your kept file path:)

thank you


Sheet modal : Swipe to close and swipe to step

Clear and concise description of the problem
The basic sheet modal works great, but lacks basic functionality like swipe / pull back to close and swipe to expand.
Framework7 supports it, but i can not use framework7 just for this feature as it comes up with much more.
Suggested solution
Sheet modal what supports swipe to close and expand
Alternative
No response
Additional context
No response
Validations

[X] Follow our Code of Conduct
[X] Read the docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

Would you like to open a PR for this feature?

[ ] I'm willing to open a PR

please this is very important

A very important feature.


Fix #71 by toggling the start button and showing a warning for invali…

…d input
https://user-images.githubusercontent.com/1664407/218427282-29e56454-0e7e-406d-9541-189eb49dd678.mp4

This is an alternative to #74 that constantly updates the button state and warning text upon every keypress, not just when you click the start button. Any thoughts?
Putting the warning next to the button felt a bit more clear to me than a new paragraph, but not really sure where it belongs

Taking a look now...

Looking at the video you posted Dustin and trying what's currently on atip.uk, I approve of this, seems like a good solution.

Much sveltier!
My only comment would be should we just drop the warning text and have the button disabled until someone picks a valid option from the list?
But that's just a personal UX take.

Nice adjective: svelty!

Nice adjective: svelty!

Interpreting closure of #74 as being in favor of this, so merging

Oops, wifi here is weird and didn't pick up new messages, but let me submit?

My only comment would be should we just drop the warning text and have the button disabled until someone picks a valid option from the list?

Agreed... it's clear enough that the button is disabled. Done in e7f70ba37007cd5fb14e2526b0f90eb2618036f8


Multiple static file packages

I'd like to produce two (or more) different statik fs's in different import paths. Due to relying on init() and no public API from the package, it's impossible to use both filesystems at the same time; concurrent access is also impossible as fs.Register is package-scoped.
I'd propose modifying the API:
fs.New would take zipDatas ...string and fallback on whatever was put in fs.Register (backwards compatible),
The generated filesystem package could add Data() string for this purpose in addition to keeping init() behaviour.

@titpetric here is a fork'd version with the fix.. https://github.com/goware/statik as well as a new -a flag to pass pkg-level variable name to reference the asset. And fs.New() which accept the zipdata string

This request would change this project from a very minimalist solution to a more general one, but less lightweight.
If you need something less minimalist, just fork the project to build something else.

Well, in fact, you can already do that with the existing code. The trick is to call fs.New() before another package registers data again. To achieve that, fs.New() has to be called at init time (in an init function or in a package-scoped variable declaration).
Example:
package pkg1

import (
    "github.com/rakyll/statik/fs"
    _ "pkg1/statik"
)

var FS = fs.New()

package pkg2

import (
    "github.com/rakyll/statik/fs"
    _ "pkg2/statik"
)

var FS = fs.New()

You can now use both pkg1.FS and pkg2.FS.
Note: this is garanteed to work because the Go language specification garantees that "Package initialization—variable initialization and the invocation of init functions—happens in a single goroutine, sequentially, one package at a time."

@pkieltyka thanks, i like that you moved away from init(). Going to migrate to your fork, eventually :)
Closing this issue as I don't think my PR is a good way forward. Moving away from init() will be a breaking change either way, and it's not up to me.

@pkieltyka p.s. would be nice if you'd generate statik.go and not static.go by default ;)

Hi! I just hit the same problem. I have two directories in two package and I was very surprise to discover that they are on the same Filesystem. I love the minimalism of statik but this was really unexpected.


ZRS for StorageV1

ZRS is also available for StorageV1 (missing in the table)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 06288d35-3c83-c29d-95d8-a56823d910a3
Version Independent ID: 002fb5f5-5e4a-a95a-4564-2c399bcb5e06
Content: Azure storage account overview
Content Source: articles/storage/common/storage-account-overview.md
Service: storage
GitHub Login: @tamram
Microsoft Alias: tamram

@evialle - Thanks for your feedback. We're encouraging customers to move to general-purpose v2 accounts. Because customers cannot create a v1 ZRS storage account from the portal, we've chosen to omit ZRS support in v1 accounts from the table.
#please-close

I think that it would be fair in that case to report this possibility and tell that you discourage this use case, in the documentation, instead of a wrong information.

@evialle - We consider ZRS Classic to be a different offering. ZRS Classic is documented only here.
The table you are referring to lists only ZRS (not ZRS Classic). ZRS is not supported for v1 accounts. We have decided not to add ZRS Classic to the table.
#please-close


nightly-20240130 nexmark-q5-many-windows perf degradation

Describe the bug

https://buildkite.com/risingwave-test/nexmark-benchmark/builds/2944#018d5b1a-81cd-4004-b5c1-21cf9024a263
https://grafana.test.risingwave-cloud.xyz/d/liz0yRCZz1/log-search-dashboard?orgId=1&var-data_source=Logging: test-useast1-eks-a&from=1706652288000&to=1706654091000&var-namespace=nexmark-bs-0-14-daily-20240130
Error message/log
No response
To Reproduce
No response
Expected behavior
No response
How did you deploy RisingWave?
No response
The version of RisingWave
nightly-20240130
Additional context
nightly-20240130

a0574b7466f5f4a28f8bcbcb660b2060a922094a feat(test): add ObjectStore trait simulator support (#14545)
1083266bd9c9924651e0cb6787f0f9094d3f0fcb fix: fix assertion of creation tracker for sink into table (#14845)
11b02eb0adfb2f1a07143f549e80d96d2f1a4237 feat: convert custom parallelism to auto/fixed in recovery loop in meta (#14871)
8cfc7f1f92a6f2b387af9116b7620d8475ebfb91 refactor: extract some common functions for join (#14868)
63e548538b9def0a36f48e4bc7fdb9b58caf067e feat(stream): support row count for arrangement backfill (#14836)
1e2605405fab48815aac4856be5d9a4f64824471 doc: Update README.md (#14867)
4358a4ec92c61b3b3ac013651ca3f490c02f0ff3 feat(expr): allow partial option arguments in functions (#14738)
1ecfe4ce3297bcca5f8eb7e1a52e34be5d3d9b2e chore: remove the unused mem_table_spill_threshold opt (#14839)
f4bae4b5d7369f85a0dd8fd04d48ab6a5e1c9c89 chore(deps): Bump strum_macros from 0.25.3 to 0.26.1 (#14851)
9417409957dbdc047cc758b6652ae5134a68a9b4 revert: feat(stream): make Project expr evaluation concurrent (#14558) (#14855)
aeeb347dda5bc8b84d8025d4ce09a10fa2b6a455 fix: fix compact task overlap check (#14856)
d694af0851991a32ba052e1e112b6d57ef67d0b0 feat(ci): add concurrency control for integration test (#14837)
43b6eefcd15803a9b02bac24d3c3758266d0e3eb feat(case-when): constant lookup optimization for constant form case-when expression (#14586)
8919044c0baf3c588796ba33cdc48c2333f3cc40 fix(optimizer): fix temporal join shuffle (#14848)
b471a9bd2d3da552055b7f449e8f13f6dd701e55 feat(sql-backend): support drop source/view/streaming jobs ddls in sql-backend (#14690)

The throughput increased because of 0cd9ff11f0ac5eb10f06a1c2dde2b806334c261c https://github.com/risingwavelabs/risingwave/pull/14558
now drops because of<PHONE_NUMBER>dbdc047cc758b6652ae5134a68a9b4 https://github.com/risingwavelabs/risingwave/pull/14855
14588 vs 14855, what a coincidence

Interesting, but I can't explain this phenomenon. IMO this PR should only have an effect on UDF :)

Interesting +1, Worth investigating the cause, I think

Any update? The perf never came back to the original level http://metabase.risingwave-cloud.xyz/question/1304-nexmark-q5-many-windows-blackhole-medium-1cn-avg-source-output-rows-per-second-rows-s-history-thtb-266?start_date=2024-01-22

@TennyZhuang Any updates?

CREATE SINK nexmark_q5_many_windows
AS
SELECT
    AuctionBids.auction, AuctionBids.num
FROM (
    SELECT
        bid.auction,
        count(*) AS num,
        window_start AS starttime
    FROM
        HOP(bid, date_time, INTERVAL '5' SECOND, INTERVAL '5' MINUTE)
    GROUP BY
        bid.auction,
        window_start
) AS AuctionBids
JOIN (
	SELECT
        max(CountBids.num) AS maxn,
        CountBids.starttime_c
	FROM (
		SELECT
            count(*) AS num,
            window_start AS starttime_c
		FROM
            HOP(bid, date_time, INTERVAL '5' SECOND, INTERVAL '5' MINUTE)
        GROUP BY
            bid.auction,
            window_start
		) AS CountBids
	GROUP BY
        CountBids.starttime_c
	) AS MaxBids
ON
    AuctionBids.starttime = MaxBids.starttime_c AND
    AuctionBids.num >= MaxBids.maxn
WITH ( connector = 'blackhole', type = 'append-only', force_append_only = 'true');

Plan:
 StreamSink { type: append-only, columns: [auction, num, window_start(hidden), window_start#1(hidden)] }
 └─StreamProject { exprs: [$expr1, count, window_start, window_start] }
   └─StreamFilter { predicate: (count >= max(count)) }
     └─StreamHashJoin { type: Inner, predicate: window_start = window_start }
       ├─StreamExchange { dist: HashShard(window_start) }
       │ └─StreamShare { id: 7 }
       │   └─StreamHashAgg [append_only] { group_key: [$expr1, window_start], aggs: [count] }
       │     └─StreamExchange { dist: HashShard($expr1, window_start) }
       │       └─StreamHopWindow { time_col: $expr2, slide: 00:00:05, size: 00:05:00, output: [$expr1, window_start, _row_id] }
       │         └─StreamProject { exprs: [Field(bid, 0:Int32) as $expr1, Field(bid, 5:Int32) as $expr2, _row_id] }
       │           └─StreamFilter { predicate: IsNotNull(Field(bid, 5:Int32)) AND (event_type = 2:Int32) }
       │             └─StreamRowIdGen { row_id_index: 4 }
       │               └─StreamSource { source: nexmark, columns: [event_type, person, auction, bid, _row_id] }
       └─StreamProject { exprs: [window_start, max(count)] }
         └─StreamHashAgg { group_key: [window_start], aggs: [max(count), count] }
           └─StreamExchange { dist: HashShard(window_start) }
             └─StreamShare { id: 7 }
               └─StreamHashAgg [append_only] { group_key: [$expr1, window_start], aggs: [count] }
                 └─StreamExchange { dist: HashShard($expr1, window_start) }
                   └─StreamHopWindow { time_col: $expr2, slide: 00:00:05, size: 00:05:00, output: [$expr1, window_start, _row_id] }
                     └─StreamProject { exprs: [Field(bid, 0:Int32) as $expr1, Field(bid, 5:Int32) as $expr2, _row_id] }
                       └─StreamFilter { predicate: IsNotNull(Field(bid, 5:Int32)) AND (event_type = 2:Int32) }
                         └─StreamRowIdGen { row_id_index: 4 }
                           └─StreamSource { source: nexmark, columns: [event_type, person, auction, bid, _row_id] }

It's indeed caused by https://github.com/risingwavelabs/risingwave/pull/14558, but the reason is unknown. Will continue to investigate.
profile results.zip

It's indeed caused by #14558, but the reason is unknown. Will continue to investigate.

No results.
Let's close the issue as the problem was already solved.


Deterministic Type Hierarchy

I don't love how we special-case (in this PR and in existing code) that Deterministic, a concrete type, sometimes also refers to DeterministicSingleTimeSeries, a different concrete type. I don't know about the typical user, but this definitely confused me before it was explained to me. We would have to think about how to resolve this without breaking existing code. For now we'll keep it as-is but at some point restore the behavior that you can pass abstract types to get_time_series; when that is done, there is a change that can be reverted in PSY. See https://github.com/NREL-Sienna/InfrastructureSystems.jl/pull/349#discussion_r1581220010. Broken out of https://github.com/NREL-Sienna/InfrastructureSystems.jl/issues/356.

We've resolved to not make any backwards-incompatible changes due to this right now, but for the next major version, here is my proposal:

Currently we have this type hierarchy:
AbstractDeterministic
  |- Deterministic  # this one is a "real" forecast
  |- DeterministicSingleTimeSeries    # this one is a "fake" forecast

and these behaviors:

AbstractDeterministic doesn't ever get referred to by the user
When the user says Deterministic, it means the Deterministic time series of that name, if there is none then the DeterministicSingleTimeSeries of that name, if there is none then error

I propose to make the following renames:
AbstractDeterministic RENAME TO Deterministic
  |- Deterministic RENAME TO DeterministicTrueForecast    # or something else, not wedded to this
  |- DeterministicSingleTimeSeries NO RENAME

and have the following behaviors:

When the user wants to refer to something that behaves like a deterministic forecast regardless of whether the underlying data is really forecast data or not, they say Deterministic, which is now an abstract type. Queries on Deterministic return the DeterministicTrueForecast or DeterministicSingleTimeSeries with that name if there is only one, error if there are both, in which case the user has to specify a subtype to clear up the ambiguity.

In fact, this works for all abstract types, e.g., queries on Forecast return the Forecast with that name no matter its concrete type if there is only one, error if there are multiple

If we want to minimize required user code changes at the expense of abuse of notation, create an alias of the DeterministicTrueForecast constructor called Deterministic. I would prefer my proposal without this, but I think my proposal with this is still better than the status quo

This proposal ends the abuse of the type hierarchy and the hard-coding that requires. The cost in change to the user interface is either practically zero, if the constructor alias is created, or small if it is not. The benefit is in more elegant and maintainable code and an intuitive connection between the type hierarchy and the time series query matching spec.


Quality Assurance: Fix inconsistent spacing in drop-down menu.

Changed the format from list to table.
Added some styles in zulip.css and added nav-bar-table and
nav-table classes to the table. Fixes #3010

Automated message from Dropbox CLA bot
@mahim97, it looks like you've already signed the Dropbox CLA. Thanks!

@brockwhittaker can you review this one?

@mahim97 one issue to test for is click handlers -- do all of the menu options work if you click on the icon part of the row?

Also, you'll want to rebase your changes onto current master so that CI runs properly (you opened this PR at a moment when CI was busted).

@timabbott Yes, all the menu options work if the icon is clicked. I have rebased it onto current master.

I squashed the changes and merged them, thanks @mahim97!!


System.InvalidOperationException: Failed to create entry for file

Opening Python file with extension not beein *.py
Visual Studio 2017 (15.4.3)
[Window Title]
devenv.exe
[Main Instruction]
An unexpected error occurred
[Expanded Information]
Build: 3.0.17310.2

System.InvalidOperationException: Failed to create entry for file
   at Microsoft.PythonTools.Intellisense.VsProjectAnalyzer.<AnalyzeFileAsync>d__82.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.PythonTools.Intellisense.IntellisenseController.<ConnectSubjectBufferAsync>d__22.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.PythonTools.Infrastructure.VSTaskExtensions.<HandleAllExceptions>d__5.MoveNext()

Thanks for the report! I recently fixed this in our main branch, so it'll be coming soon (15.6 Preview 1 - sorry, I can't give you a date for it).