WT disappears after 3 days!?

Windows Terminal version
WindowsTerminalPreview: 1.17.2301.23004
Windows build number
10.0.19045.2728 (2009, 22H2)
Other Software
Using TCC shell as a testing platform.
Steps to reproduce
Start WT and wait 3 days.
Expected Behavior
It continues to run.
Actual Behavior
It unceremomiously terminates with no local dump file.
In Fall 2022, I started to notice WT not running when I expected it to be running.  This happened several times during fall and winter and always seemed to happen after about 3 days.  Once, I witnessed WT disappearing while I was playing solitaire!  So finally I did a test.
With a TCC batch file running outside WT, I logged the start time of WT (from WMI) and I used MsgWaitForMultipleObjectsEx on a HANDLE to the WT process (and a wait_cancel_event HANDLE). Not having cancelled the wait, I logged the time (current local system time) when WT terminated.  Here's the log file.
WindowsTerminal.exe (PID 10460) started:    2023-03-26 03:00:51
WindowsTerminal.exe (PID 10460) terminated: 2023-03-29 03:00:54
Notes:  I'm pretty sure you can't blame the shell because in those 3 days, what shells were running in WT changed several times, and none were running for the whole 3 days.  And you can't blame me because I was in dreamland when the test ended.  As I said before, there was no local dump file (local dumps are enabled).
I'd be happy to test further but I can't think of any good tests.  I'm pretty confident the same test will produce the same result.

Hi @vefatica. Could you please capture an ETL trace of this occurring?

I don't see anything downloadable there.  Please give precise downloading instructions.
I didn't mention earlier ... in my test, WT was (and is almost always) running elevated.   I'll bet the actual time was exactly 3 days.  I know where the extra 3 seconds came from (my own time-sync/clock-skew service).

Click on "Terminal.wprp file from this repository"
Click on the download button:

(This may look different depending on pace of GH feature rollout)

If you mean this,

"Terminal.wprp" not clickable.

...

CLICK THIS

It is the universally accepted icon for "download".

Apparently I'm not seeing what you're seeing.

What on earth?!
Okay, for now, uh... click on "Raw", and use Ctrl+S
I think I'm going crazy! :)

That just downloads Terminal.wprp.txt with the XML in it.

Then rename it! You're the one who thought injecting a remote thread into Explorer to set environment variables was a good plan - I know you can handle a little XML file with the wrong extension! 😁

I know epsilon about XML and obviously even less about exactly what's supposed to happen here.  Rename it what?  And then what?

OK.  I think I have this figured out.  Will this (below) work?
Wait until the expected disappearance of WT is imminent That's now somewhat less than 3 days.
wpr -start v:\Terminal.wprp!Terminal.Verbose
After WT has disappeared ...
wpr -stop terminal-trace.etl
zip the ETL file and post/send it.

That'll work for us! Thanks, and sorry about the download confusion.

And I apologize for being slow to figure it out.  At first I thought I would be downloading the WPR tool.  Then I found it here already and figured out that I only needed the XML.
I'm also new to PerfView, just learned of it yesterday.  Should I be able to view a trace, made as described above, with PerfView?  I have symbols (maintained by WinDbg).

Right on schedule, WT disappeared 3 days after it was started.  Here's a bit of a transcript.  The zipped ETL file is attached but, to be honest, it doesn't look very interesting.  I started the trace about 10 minutes before the disappearance.  In the last three days my w32tmsvc added 2.5 seconds to the system clock, explaining, I reckon, the difference between 3 days and the observation below.
v:\> wpr -start v:\Terminal.wprp!Terminal.Verbose

v:\> set pid=%@wmi[.,"select processid from Win32_Process where Caption='windowsterminal.exe'"] & echo Start: %<EMAIL_ADDRESS>"select CreationDate from Win32_Process where ProcessId=%pid"],T] & wait /p %pid & echo Stop:  %_date %_t9
Start: 2023-03-29 11:42:42.788
Stop:  2023-04-01 11:42:45.373

v:\> wpr -stop terminal-trace.etl

v:\> zip disappear.zip terminal-trace.etl
<= V:\terminal-trace.etl

disappear.zip

Solved!  "Stop the task if it runs longer than 3 days" is a default setting of Task Scheduler which I never paid much attention to.  I typically start WT via an AutoHotKey script executing u:\schtasksw.exe /run /tn wtelevated.  Schtasksw.exe is a GUI version of schtasks.exe (made with editbin.exe) and the "wtelevated" task is on-demand with highest privileges.  Starting WT in this way avoids the UAC prompt.  Sorry about the false alarm.
I'm still curious.  Did terminal-trace.etl work as expected? ... have anything in it about what WT was doing?

Well, that's wild, but a good new thing to learn about!
The .etl did work perfectly fine. From what's in there, it looks like the Terminal was doing... nothing. Not processing any data, not opening new tabs or anything, just hanging out. There was a few events for the regularly scheduled "let's make sure we persist all the window positions" thread, but really nothing else interesting. Nothing in there would indicate a crash, but that's cause it didn't, so neato!
Thanks for following up!

Using PerfView, could I have learned from the .ETL file what you learned (however little there was to learn)?  Do you use PerfView or a different tool?
It's comforting to know that when Task Scheduler says "3 days" it means 3 days!  :-)

Probably, but I haven't ever learned to use that lmao. I use an internal tool just dumps the tracelogging events, which is what I was looking for. PerfView would probably have quite a bit more info than even that.


Handling case-insensitive keywords

As pointed out in #157, some languages (e.g. SQL and FORTRAN) have case-insensitive keywords. That is, in SQL, sElecT and SELECT are equivalent. Currently, supporting this in Ohm requires a separate rule for each letter -- e.g., select = s e l e c t. This is awkward an inefficient.
It would be nice to have a better solution -- either a built-in rule for case-insensitive terminals (e.g. caseInsensitive<"select">), or else some kind of escape hatch that would enable custom matching to be implemented as a JavaScript function for cases like this.

Escape hatch please!
Sent from planet Earth

On Sep 26, 2016, at 9:52 PM, Patrick Dubroy<EMAIL_ADDRESS>wrote:
As pointed out in #157, some languages (e.g. SQL and FORTRAN) have case-insensitive keywords. That is, in SQL, sElecT and SELECT are equivalent. Currently, supporting this in Ohm requires a separate rule for each letter -- e.g., select = s e l e c t. This is awkward an inefficient.
It would be nice to have a better solution -- either a built-in rule for case-insensitive terminals (e.g. caseInsensitive<"select">), or else some kind of escape hatch that would enable custom matching to be implemented as a JavaScript function for cases like this.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

I vote for the caseInsensitive<> solution because:

it will keep the grammar platform-independent (unlike an escape hatch), and
its meaning is obvious (unlike adding a special syntax for case-insensitive terminals).

I know, but I keep hoping. We will find more and more cases that need new syntaxes or an escape hatch.

On Sep 27, 2016, at 9:39 AM, Alessandro Warth<EMAIL_ADDRESS>wrote:
I vote for the caseInsensitive<> solution because:
it will keep the grammar platform-independent (unlike an escape hatch), and
its meaning is obvious (unlike adding a special syntax for case-insensitive terminals).
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/cdglabs/ohm/issues/162#issuecomment-249922404, or mute the thread https://github.com/notifications/unsubscribe-auth/AAQ5yjQvKe9I2BlpatGXjkG9Cm5P1Bsiks5quUbBgaJpZM4KHQVr.


test-branch/execute-job/quoted-authorization/8d79486f-dd1c-4d8a-94b3-759cb64d223b

PR for testing 27a100dfa48250cb4846ceb9cc64b15b6d4782a6

/canonical/self-hosted-runners/run-workflows 27a100dfa48250cb4846ceb9cc64b15b6d4782a6


Icons Detached

Describe the bug
As you can in the image provided, the icons gets detached from its position. I don't know how it's happenwd because I have been using this ICON folder plugin since 5 days and this just happened suddenly.
Screenshots

You can simply adjust the margin in the settings.


Updated Highlight.js to 9.18.1

@ryanrolds, LGTM.
Before merging: what's the context here? Is the change linked to some specific issue or discussion? Asking so that I can update those accordingly once this is merged.
Thanks!

I was adding YAML blocks to some slides and found the styling poor. This updated version has improved the YAML styling a bit.


Fixed broken link

The file linked to has since been renamed...

Please open a PR in https://github.com/LekoArts/gatsby-themes


chore: add podAnnotaions to varnish pods and fix yq

Added podAnnotations, with tests; required for some Kubernetes features (Linkerd)
Fixed yq for v4 here

@cin thanks for the update, I have moved this PR to your fork hope you don't mind, are you going to maintain this fork for the time being ?

@robgordon89 your change has been released. https://github.com/cin/varnish-operator/releases/tag/0.37.0

nice thanks 👍


py2puml fails where python -m py2puml succeeds

I have examples files that are stored according to this hierarchy
test
   __init__.py
   test.py

I struggled to run the .exe as I would get either ModuleNotFoundError: No module named 'test.test' or an empty file depending on the arguments provided:
 py2puml.exe test\test test
@startuml test
!pragma useIntermediatePackages false

footer Generated by //py2puml//
@enduml

it turned out that py2puml.exe test test doesn't work as expected but python -m py2puml test test does.
Would it be possible for you to have a look at it?
edit: I am on windows Windows 10 Enterprise v22H2 with python 3.11.6

hi @elrandira
Thank you for reporting the issue that I was able to reproduce. Fun fact: the bug occurs because of:

the order of the paths that Python uses to resolve the module resolution (PYTHON_PATH or sys.path)
the order is not the same depending on how you execute py2puml!
the name of the root folder you used: test

In the python - m py2puml test test case, the current working directory is first and used to resolve test.test (corresponding to test/test.py) and it works.
In the py2puml test test case, the current working directory is last and the python interpreter finds a test subfolder in the folder storing the python standard library and attempts to resolve test.test there; which fails.
The fix is simple, I should be able to publish a 0.9.1 version this weekend.
Should you have chosen another name than test, you might not have stumbled on the issue :smiley: thanks again for reporting it.

hello @elrandira
I fixed the issue you identified. Would you take a couple of minutes to review pull request #82 to validate the fix, please :pray: ?
It is just a small fix with a non-regression test. Then I will release the new version.

sure, I can give it a try.

So now both python -m py2puml test test & py2puml.exe test test give me correct Puml
strangely, py2puml.exe test\test test and python -m py2puml test\test test work but generate an empty Puml
while py2puml.exe test test.test and python -m py2puml test test.test will give me the

ModuleNotFoundError: No module named 'test.test.test'; 'test.test' is not a package

:pray: @elrandira for your review.
Glad to hear that the fix works.
The last 2 examples fail for logical reasons:

py2puml.exe test\test test and python -m py2puml test\test test work but generate an empty Puml

test\test is not an existing folder, so py2puml finds nothing in it; hence the empty plantuml content

py2puml.exe test test.test and python -m py2puml test test.test will give me the
ModuleNotFoundError: No module named 'test.test.test'; 'test.test' is not a package

You are asking py2puml to inspect the test/ directory (which exists :+1: ), handle it as the test.test package when resolving modules. When handling the test.py file in it, python tries to import it as the test.test.test module; thus expecting a test/test/test.py file in the current working directory (which does not exist).
In py2puml call, the 2 arguments (the folders path and the packages path) must be consistent (1.) together, (2) and regarding the current working directory. The world of CLI tools was new to me when I started writing py2puml and my understanding of the import mechanism in Python was shallow and I made those arguments mandatory in the CLI, whereas the packages path could be inferred from the folders path. A future merge request would allow to make the the packages path argument optional (or obsolete).
If you are satisfied with the MR, could you approve it by clicking the green Review changes button in the https://github.com/lucsorel/py2puml/pull/82/files page, please:


New SDK Tutorial for FF

We are adding a new SDK tutorial for FF to help a couple customers leverage our new method for refreshing browsers brought to the foreground. I also updated the other tutorials to have some SEO keywords. I need to create another PR to add the tile box for this tutorial and a prior one yet but I can't find where that is located so submitting this to get the content out there so we can use it today.
Harness Developer Pull Request
Thanks for helping us make the Developer Hub better. The PR will be looked at
by the maintainers.
What Type of PR is This?

[ ] Issue
[x ] Feature
[ ] Maintenance/Chore

If tied to an Issue, list the Issue(s) here:

Issue(s)

House Keeping
Some items to keep track of. Screen shots of changes are optional but would help the maintainers review quicker.

[ x] Tested Locally
[ x] Optional Screen Shoot.

@StrawberryPad I'm open to any feedback - thank you for reviewing.

Reminder if you are able to add the Tutorial Card @HarnessTheChaos on https://developer.harness.io/tutorials/feature-flags.

https://harness.atlassian.net/wiki/spaces/PD/pages/21254144997/Harness+HDH+Contributors+Guide+-+Technical+Internal#Adding-Tutorials
Add Card Here: https://github.com/harness/developer-hub/blob/main/src/components/LandingPage/data/featureFlagsData.tsx

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

@HarnessTheChaos - silly question, but who are you :-D

@StrawberryPad that is Matt S e.g @HarnessTheChaos.
@HarnessTheChaos when you go through the comments, can you commit them as a batch?

I'll submit this and also add another missing tutorial that doesn't have a tile.

@StrawberryPad here's the PR for the two tile cards associated with this tutorial and a tutorial from the other week. https://github.com/harness/developer-hub/pull/2608

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app


Resolve conflict with upstream and bump deps

Hi! Thank you for your excellent work on this! I resolved conflicts with the upstream repo and bumped the version of the aws-sdk dependencies so this feature can be merged into upstream.

@alessandrod Hi! Would you mind taking a look at this? I didn't change any code. I only bumped dependencies and resolved git conflicts.

@alessandrod, can you review/merge this PR?


Change the default value of MaxRunnerPods

Make the MaxRunnerPods field optional. And add a unit test.
If simply want to use meows, users need not specify the MaxRunnerPods.
However, in the current implementation, when the Replicas is set to 2 or more, the MaxRunnerPods must also be specified.
It is cumbersome.
Signed-off-by: Masayuki Ishii<EMAIL_ADDRESS>

@zoetrope @kmdkuk
I updated PR text and docs.


extended kinetic Monte Carlo

with example for heterogeneous SIR dynamics

Codecov Report

Merging #37 into master will decrease coverage by 2.77%.
The diff coverage is 22.22%.

@@            Coverage Diff             @@
##           master      #37      +/-   ##
==========================================
- Coverage   59.22%   56.45%   -2.78%
==========================================
  Files           8        8
  Lines         233      248      +15
==========================================
+ Hits          138      140       +2
- Misses         95      108      +13

Impacted Files
Coverage Δ

src/kinetic_monte_carlo.jl
18.05% <22.22%> (-1.25%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 982e747...ab6353e. Read the comment docs.


('Feature', ... , 'has a value outside the dataset.') caused by type mismatch

[problem]
Value errors for out of interval values are thrown when data are of different type
[illustrative example]
...
        data_ranges = df.describe().loc[["min", "max"]].to_dict()
        data_ranges = {
            x: [y, z] # integer values
            for x, y, z in zip(
                df.columns, df.min(), df.max()
            )
        }
...
        d = dice_ml.Data(
            features=data_ranges,
            continuous_features=continuous,
            outcome_name=outcome,
        )
        exp = dice_ml.Dice(d, model, method="random")
        counterfactuals = exp.generate_counterfactuals(query_df, total_CFs=4, desired_class="opposite")

The following error is produced when the values of the intervals are int, and the query values are some precision of float
('Feature', ... , 'has a value outside the dataset.')

However, the feature value can be within the range of the interval and still throw this error.
After casting the feature ranges to the same type as their query values, this error goes away.
[proposed fix]
Intervals should not be required to have the same type as the query values
interval: list[int] =  [1, 10]

should accept value,
value: np.float16 = 3.5

as within the range of the interval.

@dylan-kelahealth, The error looks to me correctly raised. Your model would have been trained on integer features so not sure how it would interpret non-integer values if dice-ml decides to generate floating point values. Correct me if you think that is not accurate.

@gaugup If this is a correctly raised error, then the error message might benefit from revision (e.g. type checking). Several other issues have posted about the same error message. This is also not clarified in the documentation.
This was confusing because "value outside the dataset" implies outside the defined range. The range contains the query value unless the range is specified as integers only, which it is not.

Thanks for clarifying. I think we should raise a better error message in this case to ask user to align types.
Could you provide the exact notebook code that reproduces this error?
Thanks!


React50

In the description you have ReactDOMSever instead of ReactDOMServer

You're right thanks for finding that! I've just fixed it.


be able to enable and disable cdn

when working with cartodb.js createVis method the viz.json for custom installation should include no_cdn: true option for all cartodb and torque layers.
An option to enable and disable cdn needs to be added

now that is controlled by the layergroup call so not needed


isSpinnerTextSelected wrong result

From<EMAIL_ADDRESS>on March 08, 2011 01:41:26
What steps will reproduce the problem? 1.  What do you see instead? expected:
2. true
3. true
instead:
2. false
3. true What version of the product are you using? On what operating system? 2.2 Please provide any additional information below. In Checker.java the function
public boolean isSpinnerTextSelected(int spinnerIndex, String text)
the line:
TextView textView = (TextView) spinner.getChildAt(0);
Why the zero value?
Why not like this:
TextView textView = (TextView) spinner.getChildAt(spinner.getSelectedItemPosition()); ?
Original issue: http://code.google.com/p/robotium/issues/detail?id=81

From<EMAIL_ADDRESS>on March 08, 2011 02:36:56
Thanks for this. It will be fixed in the next version.
Status: Accepted
Owner: renasreda

From<EMAIL_ADDRESS>on April 21, 2011 10:47:11
This has been corrected in Robotium 2.3.
Status: Verified

From<EMAIL_ADDRESS>on April 25, 2011 14:22:48
spinner.getChildAt(0) was working fine for me in Robotium 2.2. I've just switched today and I'm getting a NullPointerException since the spinner object has always one child (the currently selected one).
As far as I know, getChildAt() depends on the Views.. and not on the index/position of the total items (children != items).. right?

From<EMAIL_ADDRESS>on April 25, 2011 22:01:58
You get a NullPointerException exception everytime you try to use it?
Status: New

From<EMAIL_ADDRESS>on April 26, 2011 07:29:19
Everytime the selectedItemPosition is != 0. So for example if in the spinner I have 3 items and I have this code, I would get the NullPointerException
.. GROUP_SPINNER_INDEX = 0;
.. MOVE_DOWN_ONE_ITEM = 1;
solo.isSpinnerTextSelected(GROUP_SPINNER_INDEX, "Item position 0"); // No error
solo.pressSpinnerItem(GROUP_SPINNER_INDEX, MOVE_DOWN_ONE_ITEM);
solo.isSpinnerTextSelected(GROUP_SPINNER_INDEX, "Item postion 1"); // NullPointerException

From<EMAIL_ADDRESS>on April 27, 2011 00:01:01
Thanks for reporting this. It will be fixed in the next release. I would recommend you to use 2.2 instead. The differences between the two are minor.
Status: Accepted

From<EMAIL_ADDRESS>on July 13, 2011 10:30:29
This has been corrected in Robotium 2.4.
Status: Verified


MicrosoftTeams PSmodule 2.0

I've updatet the MS teams module to 2.0 but when I try to import-module it it throws and error:
`Import-Module : Could not load file or assembly 'netstandard, Version=<IP_ADDRESS>, Culture=neutral,
PublicKeyToken=cc7b13ffcd2ddd51' or one of its dependencies. The system cannot find the file specified.
At C:\Program Files\WindowsPowerShell\Modules\microsoftteams\2.0.0\net472\Microsoft.Teams.ConfigAPI.Cmdlets.psm1:3
char:11

$null = Import-Module -Name (Join-Path $PSScriptRoot './bin/Microso ...

      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

CategoryInfo          : NotSpecified: (:) [Import-Module], FileNotFoundException
FullyQualifiedErrorId : System.IO.FileNotFoundException,Microsoft.PowerShell.Commands.ImportModuleCommand

Unable to find type [Microsoft.Teams.ConfigAPI.Cmdlets.Generated.Module].
At C:\Program Files\WindowsPowerShell\Modules\microsoftteams\2.0.0\net472\Microsoft.Teams.ConfigAPI.Cmdlets.psm1:6
char:15

... $instance = [Microsoft.Teams.ConfigAPI.Cmdlets.Generated.Module]::Ins ...

Get-ScriptCmdlet : The term 'Get-ScriptCmdlet' is not recognized as the name of a cmdlet, function, script file, or
operable program. Check the spelling of the name, or if a path was included, verify that the path is correct and try
again.
At C:\Program Files\WindowsPowerShell\Modules\microsoftteams\2.0.0\net472\Microsoft.Teams.ConfigAPI.Cmdlets.psm1:42
char:20

$cmdletNames = Get-ScriptCmdlet -ScriptFolder $exportsPath

               ~~~~~~~~~~~~~~~~

CategoryInfo          : ObjectNotFound: (Get-ScriptCmdlet:String) [], CommandNotFoundException
FullyQualifiedErrorId : CommandNotFoundException

You cannot call a method on a null-valued expression.
At C:\Program Files\WindowsPowerShell\Modules\microsoftteams\2.0.0\net472\Microsoft.Teams.ConfigAPI.Cmdlets.psm1:47
char:3

$instance.Init();

+ CategoryInfo          : InvalidOperation: (:) [], RuntimeException
+ FullyQualifiedErrorId : InvokeMethodOnNull

You cannot call a method on a null-valued expression.
At C:\Program Files\WindowsPowerShell\Modules\microsoftteams\2.0.0\net472\Microsoft.Teams.ConfigAPI.Cmdlets.psm1:48
char:3

Export-ModuleMember -Function $instance.FunctionsToExport.Split("," ...

+ CategoryInfo          : InvalidOperation: (:) [], RuntimeException
+ FullyQualifiedErrorId : InvokeMethodOnNull

`

It looks like it just something missing on the path.
Now even installing the previous version I got the same errors.

Additional debug. I could load without errors if I ran from the directory where microsoftteams was installed.
But when using the modules like connect-microsoftteams it generates errors

problem solved!

I had      .net v4.7.2053.0   (officially called 4.7)
installed .net v4.7.3062.0 (officially called 4.7.2) and it all works now


I write response body but response is empty when withStatus(401)

Slim3,
Here is my code:
        $response = $response->withHeader('Content-type', 'application/json');
        $response->getBody()->write(json_encode(['error' => 'Unauthorized']));
        $response = $response->withStatus(401);
        return $response;

But the response is:
Header:
content-length → 0
content-type → text/html; charset=UTF-8
date → Wed, 23 Dec 2015 02:45:46 GMT
server → nginx
status → 401

Body is empty
Why the response body is empty ?
Why the content-type is text/html not application/json?
Thanks.

Sorry, It's my error.
Because I used the tuupola/slim-basic-auth, but I incorrect use of it.
https://github.com/tuupola/slim-basic-auth#setting-response-body-when-authentication-fails
I'm sorry for my issue.


CF::Number - Assignment operators with an invalid CF::Number object

Invalid CF::Number objects should be treated as zero.

Be careful on divisions - Maybe throw an exception.

And use math_errhandling.

Fixed in af81b213c69570fe4093b5d807285c9eb35e87f9.


Introduce a new tag, Tag_RISCV_x3_reg_usage to record how gp/x3 begin …

…used.
This tag is designed to prevent the linker from merging objects that use gp for different purposes. Additionally, it can also serve to help users identify the usage within the executable.

@luismarques applied, thanks :)

Changes:

Rename gp into x3 to prevent misleading, e.g. using gp as shadow stack pointer seems weird.
Update merge rule: explicitly allow merge 0 with 1 and 2 only.

Thank you for making GP more useful when many folks don't think think re-purposing GP is an "ABI break" on their platforms.
I still hold the opinion from https://github.com/riscv-non-isa/riscv-elf-psabi-doc/pull/371#issuecomment-1489593011 that a tag in the attribute section is not going to be super useful, more so if we emit it by default for -mrelax.
It will waste some relocatable object file sizes, and if we make SHT_RISCV_ATTRIBUTE allocable, some bytes in the linked image.
Right now I don't have a strong opinion whether software shadow stack based on GP should emit a tag by default.
If a user does that and enables --relax-gp (current default in GNU ld), they will get an error.
For ld.lld which doesn't enable global pointer relaxation by default, this is going to be more like busy work.
(There are many linker option combinations that produce broken output. We simply cannot diagnose every invalid case.)

Why would -mrelax generate the attribute tag when -mrelax doesn't generate explicit uses of gp?  The gp references are not, with the exception of the single point where gp is initialized, generated until link time so the attribute tag shouldn't be created until then either.

To ask a slightly higher level question - are we sure we want to go down the route of picking out every potential ABI option and specifying it in attributes (which seems to be the route this and the atomics PR seems to be going down). I can believe it's better this way, but it would be reassuring to know if people spent time considering an alternative that e.g. just specified the platform ABI targeted by a given ELF (potentially with an ABI version).

To ask a slightly higher level question - are we sure we want to go down the route of picking out every potential ABI option and specifying it in attributes (which seems to be the route this and the atomics PR seems to be going down). I can believe it's better this way, but it would be reassuring to know if people spent time considering an alternative that e.g. just specified the platform ABI targeted by a given ELF (potentially with an ABI version).

That's kind of a broader issue, though: coupling together features into a set requires getting consensus on what those sets should be and there's just no mechanism for doing that in RISC-V land.  It's essentially the same problem that's lead to an explosion of extensions, just more visible because it's ABI and we're all used to ABI proliferation being a mess.
  We can just punt to the distros to group features into sets and then go deprecate everything else in a few years when it's sufficiently broken.

This issue could break into two separate parts IMO: bare-metal and UNIX-like platforms (Linux, *BSD, Android...)
For bare-metal: The answer is yes; we are going to identify potential ABI options and add attributes to let users configure what they want; that's is the scope of EABI; this part will drive by IAR folks, and I believe this is not the issue we concern here, so I would not spend too much word here :)
For UNIX-like platforms: I would like to minimalize this IF possible; however, as you mentioned, we already have atomic and this PR:

atomic is unavoidable due to some...historical mistakes.
For x3/gp, I would say that's a historical mistake too; we didn't reserve a platform register at the beginning, and the x3/gp is the best candidate for changing. Anyway, the full story described in https://github.com/riscv-non-isa/riscv-elf-psabi-doc/pull/371, so I won't repeat again here :)

Do we have more ABI options for UNIX-like platforms? It's hard to guarantee to say no more, but this will be carefully considered when introducing new ABI options.
But could we prevent those EABI options from being applied on UNIX-like platforms? It's hard to stop people from doing so; from the psABI aspect, we can add NOTE to mention this is EABI, and not recommended applied on UNIX-like platforms.

but it would be reassuring to know if people spent time considering an alternative that e.g. just specified the platform ABI targeted by a given ELF (potentially with an ABI version).

That would be useful; we could create a separated issue to track that

@asb @MaskRay did you mind give explicitly LGTM if it's OK from the LLVM land. we are OK with that in GNU land, and then I'll gonna prepare PoC for this :)

Changes:
-Rebase and squash patches

binutils PoC: https://github.com/kito-cheng/riscv-binutils-gdb/commit/d13849c84696f533f3e48fb1c5b147e0e01e2f59

ping @asb @MaskRay, this will be merged if no objection this week.

That's kind of a broader issue, though: coupling together features into a set requires getting consensus on what those sets should be and there's just no mechanism for doing that in RISC-V land. It's essentially the same problem that's lead to an explosion of extensions, just more visible becaus

This is exactly my concern. In another thread (I don't recall which) I mentioned that compilers cannot determine whether inline assembly uses x3 and in what way.
I am sorry that I haven't replied earlier. I think I am ok if psABI adds Tag_RISCV_x3_reg_usage, as long as if compilers don't emit Tag_RISCV_x3_reg_usage, as that just doesn't seem useful...
If folks loving gp wants to an opt-in option to emit Tag_RISCV_x3_reg_usage, I think I'm fine as well, as a compromise...

That's kind of a broader issue, though: coupling together features into a set requires getting consensus on what those sets should be and there's just no mechanism for doing that in RISC-V land. It's essentially the same problem that's lead to an explosion of extensions, just more visible becaus

This is exactly my concern. In another thread (I don't recall which) I mentioned that compilers cannot determine whether inline assembly uses x3 and in what way.

We can't really expect compilers to be able to tell if inline assembly violates any ABI constraint.  It's inline assembly anything goes.

I am sorry that I haven't replied earlier. I think I am ok if psABI adds Tag_RISCV_x3_reg_usage, as long as if compilers don't emit Tag_RISCV_x3_reg_usage, as that just doesn't seem useful... and purely unneeded code size for many systems.
If folks loving gp wants to an opt-in option to emit Tag_RISCV_x3_reg_usage, I think I'm fine as well, as a compromise...

This is exactly my concern. In another thread (I don't recall which) I mentioned that compilers cannot determine whether inline assembly uses x3 and in what way.

We can't really expect compilers to be able to tell if inline assembly violates any ABI constraint. It's inline assembly anything goes.

Yeah, I think user could write any ABI violation code as they want, so I don't really concern about that - user should handle those inline asm very carefully since most compiler didn't really know what inline asm write - we all rely on the info what user give.
And my thought on that tag other than the binutils patch, the binutils patch is just basic tag parsing and merge rule, which not cover all thing we should do:

Linker should NOT perform gp relaxation if any input object file contain Tag_RISCV_x3_reg_usage other than 0 (unknown or unset) and 1 (gp relax).
Linker should set Tag_RISCV_x3_reg_usage to 1 if gp relaxation has perform.
If -mno-gp-relax is given (assembler or compiler), then Tag_RISCV_x3_reg_usage should explicitly set to 0 for the final output.
Compiler should emit Tag_RISCV_x3_reg_usage as 2 if it use as shadow stack.

If folks loving gp

You mean folks who are using the ABI as specified?  We all know you dislike the ABI, but you should characterize your position a bit more forthrightly.

ping @asb @MaskRay, this will be merged if no objection this week.

Now I'm back from vacation, just noting for the record I've got no objection to this flag (and sorry for missing the earlier ping!).

You mean folks who are using the ABI as specified? We all know you dislike the ABI, but you should characterize your position a bit more forthrightly.

I am forthright that I don't think global pointer relaxation provides sufficient valuable.
I am forthright that I don't get why marking object files with Tag_RISCV_x3_reg_usage is useful, and my arguments have been provided above.
I do worry that Clang produced relocatable object files will be annotated as Tag_RISCV_x3_reg_usage and lld will somehow need to parse it. I think this is busy work. If the toolchain will not be patched to add Tag_RISCV_x3_reg_usage in the default mode, I am happy to take a compromise and not object to this tag in the ABI.

@MaskRay I feel there's two things mixed in your comment, one concern for Tag_RISCV_x3_reg_usage and one concern for ELF attribute, so let us break it down into two parts to discuss.
Let me describe the ELF attribute first. I think we have discussed this in different PRs/issues, and I know you are not really convinced that we need that.
There are many different containers in ELF format which can carry information like e_flags, properties, ELF attributes, and many different .note.* sections.
And we pick ELF attributes at beginning due to following reason:

It’s implemented in existing toolchain
It’s allow store string and arbitrary length of integer (by ULEB128 format)

However I know it’s come with some drawback like:

It is not easy to do random access, it must parse from the beginning.
NO existing parser implementation within dynamic linker (like glibc)

So we may consider introducing ELF properties to make dynamic linker easier to read, however I think we could keep using ELF attributes, and define some guidelines to clarify how to decide what information/tag should add to attribute or property.
The guideline in my mind is:

The tag should go property if it must read the information at dynamic linking time, otherwise use ELF attribute.
If the information is only used by static linker and other static time tools like disassembler - then use ELF attribute.

Back to Tag_RISCV_x3_reg_usage, that info mostly used by the static linker to determine the GP relaxation should be performed or not, does it introduce lot of complexity of the linker implementation, I expect that won’t be terrible high cost, we already have RVC flag to determine if the compressed instruction can be used within linker relaxation.
The first use case I expect is (soft) shadow stack, compiler will emit Tag_RISCV_x3_reg_usage when they begin use x3 as shadows stack pointer, then it will suppress linker to perform GP relaxation even -mno-gp-relax is not given.
Without that tag, users must be careful to make sure -mno-gp-relax is given when (soft) shadow stack enabled - otherwise the program might cause random bugs due to gp relaxation, but that could be prevented at the beginning if we have the tag.
For inline asm and hand craft assembly files…I tend to ignore those cases since I believe no matter what mechanism is  used, users could play tricks to violate or ignore that.

@MaskRay I feel there's two things mixed in your comment, one concern for Tag_RISCV_x3_reg_usage and one concern for ELF attribute, so let us break it down into two parts to discuss.

My two concerns are:

whether Tag_RISCV_x3_reg_usage is useful
in what cases users will bear the (small) overhead of Tag_RISCV_x3_reg_usage

I do agree that if we ever need an ABI marker, build attributes is the best choice. Actually, no other alternative is ever close to be competitive.
I am more concerned with the second point.
What relocatable object files are going to have Tag_RISCV_x3_reg_usage?
I re-read the comments and think my
commenting "OK, if -mno-gp-relax is introduced, value 1 will now be distinguishable with others."
was mistaken.

Linker should NOT perform gp relaxation if any input object file contain Tag_RISCV_x3_reg_usage other than 0 (unknown or unset) and 1 (gp relax).

OK, a bit of busy work in the linker to me, but I think this is acceptable.

Linker should set Tag_RISCV_x3_reg_usage to 1 if gp relaxation has perform.

I hope that in the absence of build attributes, the linker doesn't need to set Tag_RISCV_x3_reg_usage.

If -mno-gp-relax is given (assembler or compiler), then Tag_RISCV_x3_reg_usage should explicitly set to 0 for the final output.

0 is compatible with global pointer relaxation, then what does the 0 value do?
In the default mode (whether -mrelax or -mno-relax, but there is no -m[no-]gp-relax), is there a Tag_RISCV_x3_reg_usage attribute?

Compiler should emit Tag_RISCV_x3_reg_usage as 2 if it use as shadow stack.

This is small overhead, but I think it's fine.


Add generate mailable command.

Could you add a test for this please ? :)

Sure thing.

It looks like Travis wasn't able to make the Module on set-up. Should I not try to use the same Module name as another test?

Thank you! 😄

This PR has broken everything o_o

That's helpful. Can you explain what is broken? I've tested it and there were no problems creating a new Mailable.


Black strips on top and bottom in video, while using "executablePath" of newest version of chrome (84).

Trying to get 4k output, just added executablePath but in the output video it's showing the black border at the top and bottom of the video, check this screenshot below.

Using Node v12.18.0, and<EMAIL_ADDRESS>also I noticed this bar not sure if this is the problem

Here's the modified code, else everything is same.
const puppeteer = require("puppeteer-core");
let width = 3840;
let height = 2160;
let options = {
    headless: false,
    executablePath:
        "C:\\Program Files (x86)\\Google\\Chrome\\Application\\Chrome.exe",
    args: [
        "--enable-usermedia-screen-capturing",
        "--allow-http-screen-capture",
        "--auto-select-desktop-capture-source=puppetcam",
        "--load-extension=" + __dirname,
        "--disable-extensions-except=" + __dirname,
        "--disable-infobars",
        `--window-size=${width},${height}`,
    ],
};

I believed I resolved this by adding —kiosk to my args

Okay, will try.
Thanks, James!


Allow null for nullable constructor arguments

Codecov Report

Merging #8 (2fdf92a) into main (edace82) will not change coverage.
The diff coverage is 100.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.
@@             Coverage Diff             @@
##                main        #8   +/-   ##
===========================================
  Coverage     100.00%   100.00%
- Complexity        23        27    +4
===========================================
  Files              3         4    +1
  Lines             62        70    +8
===========================================
+ Hits              62        70    +8

Files Changed
Coverage Δ

src/Container.php
100.00% <100.00%> (ø)

src/NotFoundException.php
100.00% <100.00%> (ø)


All expected  not present in  when using .map()

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Steps to reproduce 🕹
Please visit this stackoverflow post: link-to-post
Current behavior 😯
What I am creating?

I am creating a horizontally scrollable tab component for selecting date of a month
I am using the MUI library

Problem

The dates before 14th Sun is not showing in the site. (as shown in the image below)
The first tab should be the 1st day of the month. Instead it is 14th Sun

Component Code
import { useContext, useState } from 'react';
import * as React from 'react';
import { styled } from '@mui/system';
import Tabs from '@mui/base/Tabs';
import TabsList from '@mui/base/TabsList';
import TabPanel from '@mui/base/TabPanel';
import { buttonClasses } from '@mui/base/Button';
import Tab, { tabClasses } from '@mui/base/Tab';
import { Box, Typography } from '@mui/material';
import getDatesInMonth from '@/utils/getDatesInMonth';
import { dateContext } from '@/pages/mob';

export default function DayScrollView() {
  const [activeDate, setActiveDate] = useContext(dateContext)
  const [dates, setDates] = useState(getDatesInMonth(activeDate))
  return (
    <Box sx={
      {
        overflowX: 'scroll',
        scrollbarWidth: 'none',
        '-ms-overflow-style': 'none',
        '&::-webkit-scrollbar': {
          display: 'none',
        },
      }
    }>
      <Tabs defaultValue={0}>
        <StyledTabsList>
          {dates.map((date, index) => {
            console.log(date)
            return (
              <StyledTab key={index} value={index} onClick={() => setActiveDate(date)}>
                <Typography variant='subtitle1'>{date.toLocaleString('default', { weekday: 'short' })}</Typography>
                <Typography variant='h5'>{date.getDate()}</Typography>
              </StyledTab>
            )
          })}
        </StyledTabsList>
      </Tabs>
      <Box mr={10} sx={{ width: 20 }} />
    </Box>
  );
}

const StyledTab = styled(Tab)`
.... some css styles
`;

const StyledTabPanel = styled(TabPanel)(
  ({ theme }) => `
  width: 100%;
  ... more styles
  `,
);

const StyledTabsList = styled(TabsList)(
  ({ theme }) => `
  padding-right: 1rem;
  ...more styles
`,
);

getDatesInMonth()
function getDatesInMonth(date) {
    const year = date.getFullYear();
    const month = date.getMonth();
    const numDays = new Date(year, month + 1, 0).getDate();
    const dates = [];
    for (let i = 1; i <= numDays; i++) {
        dates.push(new Date(year, month, i));
    }
    return dates;
}

If any more information needed, write in the comments.
Expected behavior 🤔
The first tab should be the 1st day of the month and 2nd tab should be 2nd day of the month, and go on like this
Context 🔦
I am using the mui-base tab components.
There i am using .map() to create the tabs based on data.
But there are some abnormalities that I cannot understand. Please the StackOverflow post
Your environment 🌎

npx @mui/envinfo
  System:
    OS: Windows 10 10.0.22621
  Binaries:
    Node: 16.13.2 - C:\Program Files\nodejs\node.EXE
    Yarn: Not Found
    npm: 9.6.5 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Chrome: Not Found
    Edge: Spartan (44.22621.1555.0), Chromium (112.0.1722.68)
  npmPackages:
    @emotion/react: ^11.10.8 => 11.10.8
    @emotion/styled: ^11.10.8 => 11.10.8
    @mui/base: ^5.0.0-alpha.127 => 5.0.0-alpha.127
    @mui/core-downloads-tracker:  5.12.2
    @mui/icons-material: ^5.11.16 => 5.11.16
    @mui/joy: ^5.0.0-alpha.77 => 5.0.0-alpha.77
    @mui/material: ^5.12.2 => 5.12.2
    @mui/private-theming:  5.12.0
    @mui/styled-engine:  5.12.0
    @mui/system:  5.12.1
    @mui/types:  7.2.4
    @mui/utils:  5.12.0
    @mui/x-date-pickers: ^6.3.0 => 6.3.0
    @types/react:  17.0.58
    react: 18.2.0 => 18.2.0
    react-dom: 18.2.0 => 18.2.0
    typescript:  5.0.4

Browsers used: chrome and brave

@DB-db-dron At a glance, it looks to be more of a CSS problem rather than a problem with the Tabs

In the browser console, all the dates are logged in ascending order, from 1st to 31st.

I think you confirmed here that all the Tabs are actually rendered


rework takeover alert state handling

This simplifies handling of persisted state within the takeover tool, with the initial goal of eliminating spontaneous diffs in the fixture file when running tests locally. Notes:

Adds a new module to handle test mode specifically, which reads the fixture and does not write anything.
Moves JSON encoding/decoding steps into the caller, so they're not repeated in each module.
Removes some hedging around failure cases, since the only caller already does a hard match against a successful return value, meaning we already crash/log if something goes wrong.

Let's go with ! names, since that communicates the behavior without the added complexity of parsing out error cases.


Fix: Feedback should be sent through the backend to avoid CORS issues

Co-authored by OpenDevin
(still WIP)
Fixes: https://github.com/OpenDevin/OpenDevin/issues/2032

Hi @amanape , I think this is ready, it'd be great if you could take a look!

Good question! We're planning on creating a public repository of OpenDevin conversation histories, but we want to let users decide whether to share privately or publicly, so I'm preparing for that. I'll do that in a follow-up PR.


Functions e2e test harness should test CLI output

We want to test expected error messages and non-structured results.

One complication here is testing on different OS's if the output contains paths. One pragmatic option is to only test the output on select platforms.

Yes, for m2 milestone, we should target select platforms (Linux and OSX).

As part of this, please audit the error messages to ensure they're clear and actionable and conform to go/kpt-errors-style-guide. Many of the error message I'm seeing have poor UX.

Added a comment https://github.com/GoogleContainerTools/kpt/issues/1783#issuecomment-825199107 listing the error messages that can be improved


New optional input: frozen-environments-file

If given, this file should contain a list like
- staging
- prod

and all track and promote commands will ignore blocks whose names exactly match one of these entries. (You can still promote from one of these environments, just not to it.)

I did this as a file rather than as an inline list so that it's easy to pass the same file to multiple workflows that use this action.


Update instructions.md

Replace the comma with a colon to make the list readable.

Thanks for the taking the time to improve the instructions, @0zAND1z.
The practice exercises in this track use the data in the problem-specifications repository for the descriptions, metadata, and test cases.
The exercise was out of date, and I've submitted a PR to bring it into sync with the upstream specification.
This PR will be closed when https://github.com/exercism/cpp/pull/550 is merged.


Architecture and scoping for born digital

Link to feature: https://wellcomecollection.productboard.com/feature-board/planning/features/10445435


Update iOSDevelopment.md

I'm not sure this is correct. You should use the ./scripts/package.sh which will do the signing. This is detailed under Packaging


Register ModelMetadataHolder::print()

The documentation at https://docs.metatensor.org/latest/atomistic/reference/models/metadata.html
says there is a ModelMetadata.print() method, but it doesn't work at the moment because it's not registered
Contributor (creator of pull-request) checklist

[x] Tests updated (for new features and bugfixes)?
[ ] Documentation updated (for new features)?
[ ] Issue referenced (for PRs that solve an issue)?

Reviewer checklist

[ ] CHANGELOG updated with public API or any other important changes?

📚 Download documentation preview for this pull-request

IDK, works locally


Special tokens to pre-trained BART model

❓ Questions and Help

What is your question?
Is it possibile to add special tokens to the pre-trained BART model? My text has <s> as sequence separator for sentences. I would like that the encoder will handle it as a whole token, otherwise the model will break it in codes and learn like <s or s> etc.

What I did was take their dict.txt and see entries from encoder.json which has count 0 ,take any such entry and replace it with the special token
Also add a line that if token in  it should not do bpe split
https://github.com/pytorch/fairseq/blob/master/fairseq/data/encoders/gpt2_bpe_utils.py#L66
class Encoder:

    def __init__(self, encoder, bpe_merges, errors='replace'):
        self.encoder = encoder
        self.decoder = {v:k for k,v in self.encoder.items()}
        self.errors = errors # how to handle errors in decoding
        self.byte_encoder = bytes_to_unicode()
        self.byte_decoder = {v:k for k, v in self.byte_encoder.items()}
        self.bpe_ranks = dict(zip(bpe_merges, range(len(bpe_merges))))
        self.cache = {}

        try:
            import regex as re
            self.re = re
        except ImportError:
            raise ImportError('Please install regex with: pip install regex')

        # Should haved added re.IGNORECASE so BPE merges can happen for capitalized versions of contractions
        self.pat = self.re.compile(r"""'s|'t|'re|'ve|'m|<A0>|<EOT>| <EOT>|<V>|<A1>|<A2>| <A0>|<P>| <P>|<A1>| <A1>| <A2>| <V>| </s>|</s>|'ll|'d| ?\p{L}+| ?\p{N}+| ?[^\s\p{L}\p{N}]+|\s+(?!\S)|\s+""")

    def bpe(self, token):
        if token in ['<A0>','<A1>','<A2>','<V>','</s>','<P>','<EOT>','\u0120<A0>','\u0120<A1>','\u0120<A2>','\u0120<V>','\u0120</s>','\u0120<P>','\u0120<EOT>']:
            #print("inside bpe",token)
            return token

What I did was take their dict.txt and see entries from encoder.json which has count 0 ,take any such entry and replace it with the special token . Also, add a line that if token in it should not do bpe split

Please, guide me to build encoder.json for other language.


win: fix possible memory leak

There is some possible to memory leak, in this change we should add release for process_title_lock in CRITICAL_SECTION
Ref: https://github.com/libuv/libuv/issues/3191

Hmm interesting, imo I think we still should free that and go to uv_fatal_error to confirm that already been freed, wdyt?
But if that is already handled by OS, I think this change is also not relevant again (?)


Bluetooth gyro data

Is there any way to coax the controller into sending gyro/accelerometer data and map it?

Honestly I'm not sure - I have only tested the controller in USB mode (to be honest this API is a bit cobbled together at the moment).  You can try using the data debugger (make a new scene and attach DataDumpTest.cs to the camera) to figure out how the bits are laid out / how they differ between USB and bluetooth.

For anyone else interested: I've learned is that ds4 saves energy on bluetooth by default – gyro/trackpad functionality is turned off. But there is a signal you can send to the controller, that enables them. How to do that is beyond me. Im a bit surprised that there's still no driver/utility that can take it work, considering that its the best gamepad controller out there imo. I do think some windows drivers enable that functionality on BT, but i've found nothing on osx.


webcam.swf's allowDomain * detected as potential vulnerability

A security scan reported that webcam.swf contains a wildcard in the allowDomain method, which is considered insecure.
Impact
Very relaxed cross-domain permissions may enable attacker to perform spoofing and data theft attacks.
Solution
The recommendation is to use more restrictive wildcards to grant cross-domain permissions only to domains and sub domains that are really trusted. For more details on Security.allowDomain plese see the help document by Adobe: http://help.adobe.com/en_US/FlashPlatform/reference/actionscript/3/flash/system/Security.html

I'm not sure whether the right solution is to offer a configuration setting somewhere that the SWF can load, or whether webcam.swf should simply be removed (after all, Flash is unmaintained and thus is not considered safe in general anymore), but I wanted to make sure you are aware of the potential issue.

Any updates on this? I've found the same thing as well when scanning vulnerability.


Easter egg

Once the Easter egg is activated, if you try to press the test button again, the audio of the Easter egg will restart indefinitely

This behavior was intentional, it's not an issue.
Thanks for your report.


update alicloud terraform provider to 1.149.0

How to categorize this PR?

/area quality
/kind enhancement
With the new version of terraform-provider-alicloud, I locally successfully validated the following scenarios:

reconciliation of existing Infrastructure
deletion of existing Infrastructure
creation and deletion of new Infrastructure (single zone, new vpc)
creation and deletion of new Infrastructure (multiple zones, new vpc)
creation and deletion of new Infrastructure (single zone, existing vpc)
creation and deletion of new Infrastructure (multiple zone, existing vpc)

Release note:

The following terraform provider plugin is updated:
- aliyun/terraform-provider-alicloud: 1.124.2 -> 1.149.0

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thank you @molecule-z for your contribution. Before I can start building your PR, a member of the organization must set the required label(s) {'reviewed/ok-to-test'}. Once started, you can check the build status in the PR checks section below.

/reviewed ok-to-test

@rfranzke , would you please help review and approve this PR.
I've done the validation above on gardener ac-dev environment.


[WFLY-17117] Upgrade Jakarta Mail to 2.1.1.jbossorg-1

Jira issue: https://issues.redhat.com/browse/WFLY-17117

Thanks @yersan


derive Clone for GridRowIter/GridColIter

close https://github.com/becheran/grid/issues/39

I also find this a great idea if it is possible! Would be very useful.


Use react-overlays directly?

:wave: hey there. So I noticed that ya'll are essentially inline forking react-overlays, I think it's great we have two big react ui frameworks using some of the same base code! Is there a reason though for the fork? I understand that needs vary, but it seems like both our teams would really benefit from using the same code base. For one we'd get some help upstream and not miss out on bug fixes you've found, and hopefully ya'll own a lot less code here.
Thoughts?
cc @taion

@jquense You are right, react-overlays has been an immense help with #9613! I haven't done the effort of keeping track of the diffs. From what I can remember:

react-overlays is pretty solid.
Limiting the number of dependencies.
Fixing the SSR support of the Portal.
Adding an extra .mui-fixed logic in the modal manager.
Changing the Modal API around the transition handling.
Having the control of the components so we could quickly do changes, like when the LegacyPortal code will be dropped to save bundle size.
People started contributed changes on top of it, like #10328.
Removing < IE11 support to save bundle size.
Removing the propTypes in production.

I think a lot of those seem generic yeah? It'd be awesome to get some of those benefits upstream ;) :P
On a serious note though, I realize you need to keep you users and use-cases in mind (heck we are doing the same thing with react-bootstrap), and that can be tough unless you own code. I can't speak for everyone else (mainly @taion) but I'd be happy to make you a contributor/owner  on react-overlays if that'd help consolidate some of the effort here (and give you confidence that changes could be made quickly). Having a few different stakeholders there might a bit more challenging than owning it all, but I think the benefits there would more than out weigh the costs!
Happy to chat through any specific concerns as well

Hey man, you are welcome to take the code and not contribute anything back but you need to at least meet the basic legal requirements for using the code. I don't see proper attribution on the code you've copy and pasted over here and iterated on.

Hey Jason. I can add a Notice file if you would like too like Apache is doing.
I thought that linking react-overlay in the documentation was enough: https://material-ui.com/utils/modals/.

https://clearfounder.com/originality-is-overrated-the-case-for-copying-business-ideas/


Branch made for CI testing purposes

Sorry, didn't realise this would make the PR in yours instead of in mine.


[Validator]Impossible angle

This validator should be implemented, because there are many cases that are of this type.

See also : https://github.com/osmlab/osmlint/issues/73
cc. @maning @planemad

This was previously called "kinks" by keepright.

@aaronlidman  do you see is necessary add this kind of algorithm  in osmlint, or can we continue using keepright?

Yeah let's do it in osmlint.

This validator was added in osmlint https://github.com/osmlab/osmlint/tree/master/validators/impossibleAngle


Answering multi-hop queries

Dear @skapoe
Here is your function answer_multi_hop_query() :)
Please move your implementation under this function :) and please write few tests as such
from dicee.executer import Execute
from dicee.config import Namespace
import os
from dicee.knowledge_graph_embeddings import KGE

args = Namespace()
args.path_dataset_folder = 'KGs/UMLS'
args.scoring_technique = 'KvsAll'
args.eval_model = 'train_val_test'
# Training
result=Execute(args).start()
assert os.path.isdir(result['path_experiment_folder'])
pre_trained_kge = KGE(path=result['path_experiment_folder'])
# Not quite sure whether the output of this function should be scores to all entities or
assert "particular entity" in pre_trained_kge.answer_multi_hop_query(...,k=10)

Obviously these few lines of code are only a guideline. I am quite sure you can do better than this :)

To generate queries, please implement a class that can be called as
from dicee import QueryGenerator
# (1) This class can either take an instance of KG or input arguments
q=QueryGenerator(...)
# (2) We should be able to generate and save queries along with respective answers
q.save_queries(..)
# (3) We should be generate particular queries of particular type and answer them in a loop
for i in q.get_queries(type="up"):
      pre_trained_kge.answer_multi_hop_query(...,k=10)

@skapoe please adress the todos in https://github.com/dice-group/dice-embeddings/blob/ncqd/testamhq.py
We are almost there :)


[IRGen] Ignore marker protocols while deciding polymorphic convention

Strip marker protocols from protocol compositions because
they don't exist at runtime and so cannot affect the convention.
This also makes sure that ABI stays the same even after some
parameters start using & <marker protocol> in their types.
Resolves: rdar://131764614

@swift-ci please test

We cannot land this until we find a way to preserve the ABI for existing functions/methods that adopted & Sendable or any other marker protocol in their declarations.


Inconsistency in tf.nn.top_k when using sorted=False and tf.float32 tensor and GPU placement

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): No.
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Ubuntu 16.04.
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device: NA.
TensorFlow installed from (source or binary): Binary.
TensorFlow version (use command below): 'v1.10.1-0-g4dcfddc5d1', '1.10.1'
Python version: Python 3.6.5 :: Anaconda, Inc.
Bazel version (if compiling from source): NA
GCC/Compiler version (if compiling from source): NA
CUDA/cuDNN version: CUDAToolkit 9.0, CuDNN 7.1.4
GPU model and memory: NVIDIA Quadro P4000, 8GB (driver version 396.37)
Exact command to reproduce: See source code below.

Describe the problem
The indices and values returned by top_k(sorted=False) seem to be shuffled with respect to each other when tf.float32 tensors are used, but not when tf.int32 tensors are used. I understand that we can not expect the values to be returned in ascending/descending order since we've set sorted=False, but shouldn't the values and indices at least be consistently ordered with respect to each other? Hope this makes sense. See my minimum working example below.
Edit: This seems to be a GPU-only problem.
Source code / logs
import tensorflow as tf
import numpy as np
tf.set_random_seed(21)

def demo_bug(np_dtype, tf_dtype):
    np_arr = np.array([3, 2, 8, 1], np_dtype)
    arr = tf.convert_to_tensor(np_arr, tf_dtype)
    top_k = tf.nn.top_k(arr, k=3, sorted=False)

    with tf.Session() as sess:
        vals, inds = sess.run(top_k)

    print('dtype:   ', tf_dtype.__repr__())
    print('arr:     ', np_arr)
    print('inds:    ', inds)
    print('tf_vals: ', vals)
    print('np_vals: ', np_arr[inds])

demo_bug(np.int32, tf.int32)
demo_bug(np.float32, tf.float32)

>> dtype:    tf.int32
>> arr:      [3 2 8 1]
>> inds:     [2 0 1]
>> tf_vals:  [8 3 2]
>> np_vals:  [8 3 2]

>> dtype:    tf.float32
>> arr:      [3. 2. 8. 1.]
>> inds:     [2 0 1]
>> tf_vals:  [2. 3. 8.]
>> np_vals:  [8. 3. 2.]

@jhultman Hi, I've executed your code and I get the values and indices in a consistent order. Please find the result below.
('dtype:   ', 'tf.int32')
('arr:     ', array([3, 2, 8, 1], dtype=int32))
('inds:    ', array([1, 0, 2], dtype=int32))
('tf_vals: ', array([2, 3, 8], dtype=int32))
('np_vals: ', array([2, 3, 8], dtype=int32))
('dtype:   ', 'tf.float32')
('arr:     ', array([3., 2., 8., 1.], dtype=float32))
('inds:    ', array([1, 0, 2], dtype=int32))
('tf_vals: ', array([2., 3., 8.], dtype=float32))
('np_vals: ', array([2., 3., 8.], dtype=float32))

I just tried it again in a different virtualenv installed from source (not pip package) with tf.version == 1.9.0 and I was able to reproduce the bug. My colleague was not able to reproduce the bug despite being on 16.04 with tf v1.10.1 latest pip package.
I tried again with a different test case and same problem:
dtype:    tf.float32
arr:      [3. 2. 8. 6.]
inds:     [2 3 0]
tf_vals:  [3. 6. 8.]
np_vals:  [8. 6. 3.]

@jhultman Okay. The issue is with tensorflow v 1.9. I recommend to use tensorflow v 1.10 for this op.

Sorry, I think maybe you misunderstood. I am able to reproduce the bug in both v 1.9.0 and v 1.10.1.

I tried with different device placements and it seems like a GPU-only bug for tf.float32 tensors. Maybe someone else can try with GPU placement and see if they can reproduce the bug. See my updated dummy example below.
`import tensorflow as tf
import numpy as np
import itertools
tf.set_random_seed(21)
def demo_bug(np_dtype, tf_dtype, device):
with tf.device(device):
np_arr = np.array([3, 2, 8, 1], np_dtype)
arr = tf.convert_to_tensor(np_arr, tf_dtype)
top_vals, top_inds = tf.nn.top_k(arr, k=3, sorted=False)
with tf.Session() as sess:
    vals, inds = sess.run((top_vals, top_inds))

print('device:     ', device)
print('dtype:      ', tf_dtype.__repr__())
print('arr:        ', np_arr)
print('inds:       ', inds)
print('tf_vals:    ', vals)
print('np_vals:    ', np_arr[inds], end='\n\n')

int_dtypes = (np.int32, tf.int32)
float_dtypes = (np.float32, tf.float32)
demo_bug(*int_dtypes, '/cpu')
demo_bug(*float_dtypes, '/cpu')
demo_bug(*int_dtypes, '/gpu')
demo_bug(*float_dtypes, '/gpu')

device:      /cpu
dtype:       tf.int32
arr:         [3 2 8 1]
inds:        [1 0 2]
tf_vals:     [2 3 8]
np_vals:     [2 3 8]

device:      /cpu
dtype:       tf.float32
arr:         [3. 2. 8. 1.]
inds:        [1 0 2]
tf_vals:     [2. 3. 8.]
np_vals:     [2. 3. 8.]

device:      /gpu
dtype:       tf.int32
arr:         [3 2 8 1]
inds:        [2 0 1]
tf_vals:     [8 3 2]
np_vals:     [8 3 2]

device:      /gpu
dtype:       tf.float32
arr:         [3. 2. 8. 1.]
inds:        [2 0 1]
tf_vals:     [2. 3. 8.]
np_vals:     [8. 3. 2.]
`

Anybody interested in this?

This looks like a bug in the gpu implementation of top_k. @chsigg could you take a look at this?

Nagging Assignees @martinwicke, @chsigg: It has been 29 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Thanks for reporting this. It is caused by constant folding. TF folds partial output of TopK on GPU with dtype float.
I am sending out a fix to change constant folding to either fold all the outputs of an op or not fold any outputs at all.


Added functionality to pass theme from config (override)

Description

Added functionality to pass theme object to override ThemeProvider style
Passing theme object  as playwright config

Thank you for the PR, will merge it soon after review.

Thank you  @ccpu !

You are very welcome, published under version 4.8.0.


feature: add an alias for the technology preview of the new web3.js

Summary
By no means a complete solution, this PR is the start of adding support for the Technology Preview version of @solana/web3.js.
Here, we import the tp version of the library and alias it to web3tp.
More on the new web3.js, here: https://www.youtube.com/watch?v=JUJtAPhES5g
Test Plan

Create a wallet and airdrop some SOL to it.

Create a client like so:
import "@solana/webcrypto-ed25519-polyfill";

// Client
const rpc = web3tp.createSolanaRpc({
  transport: web3tp.createDefaultRpcTransport({
    url: "https://api.devnet.solana.com",
  }),
});

const keyPair = await web3tp.generateKeyPair();
console.log(keyPair);

console.log("My address:", pg.wallet.publicKey.toString());
const { value: balance } = await rpc
  .getBalance(pg.wallet.publicKey.toBase58())
  .send();
console.log(`My balance: ${Number(balance) / web3.LAMPORTS_PER_SOL} SOL`);

Observe output
Running client...
  client.ts:
    { privateKey:
   { algorithm: { name: 'Ed25519' },
     extractable: false,
     type: 'private',
     usages: [ 'sign' ] },
  publicKey:
   { algorithm: { name: 'Ed25519' },
     extractable: true,
     type: 'public',
     usages: [ 'verify' ] } }
    My address: 9kShTNxtemuHJzsXBmSPpS4o8vSdPAgBf9uEdAadm9j6
    My balance: 0.01 SOL

Judging by the image(web3tp.generateKeyPair()), do some types not work as expected?

This thing definitely does not work with TypeScript 4.x. I'm trying to upgrade TypeScript in the playground right now (and thereby vscode to the ts5.2 tag) but I don't really understand how this thing works.

This thing definitely does not work with TypeScript 4.x. I'm trying to upgrade TypeScript in the playground right now (and thereby vscode to the ts5.2 tag) but I don't really understand how this thing works.

I think this particular issue is caused by types being exported from dependencies but currently, playground only imports the package itself and not its transitive dependencies. For example, if we were to declare the @solana/keys package as a global package, web3tp.generateKeyPair() would exist.
Declaring the packages in supported-packages.json is a massive abstraction to declare the types and most of it is handled by us. Declaration related code is in here but this probably won't be straight forward to update so it's probably best if I take care of the types later and save you some time.
There was some issue with the build when I last updated the monaco-editor(https://github.com/solana-playground/solana-playground/commit/dd804c586bfc3fda02a8390f420172e76e39fcd6) and typescript(https://github.com/solana-playground/solana-playground/commit/78156b85d3bddefe39e5dc4566c4ed857a248bc9) dependencies. I wasn't sure what caused the issue(likely craco) so I downgraded to the latest working version, maybe it works now?

Wow, I'm really glad you know how all this fits together so that I don't have to go figure it all out :)
Let me know if there's anything more I can do on this PR!

Thanks, the PR looks great but is the @solana/web3.js-tp the only package we want to expose?
I think we'd want the transitive types working before this PR otherwise it will be very difficult for people use it.

Yeah, for sure difficult.
Sorry, I'm just dumb – I can't parse whether “it's probably best if I take care of the types later and save you some time” means:

Steve should fix the types.
Let's land this now and I'll fix the types later.
I'll fix the types, push them to this branch, and we'll land the whole enchilada at once.

Sorry I wasn't clear, I meant that I'll fix the types(landing the whole enchilada at once option) but I can only start after I finish what I'm currently working on because I'm not sure how long it will take to fix the types.
Of course, you can also fix it if you're feeling extra adventurous.

I didn't want to make you wait so I added transitive deps in https://github.com/solana-playground/solana-playground/commit/e41c1b279dff0f950f6bc3b2437e928d9c42133c (ended up being easier than I thought)

Pretty nice that playnet still works with the new lib(url: "http://playnet")
There are still some type issues but this solved the majority of them.

Type imports from package names with file paths e.g. @solana/rpc-transport/dist/types/json-rpc-types now works(https://github.com/solana-playground/solana-playground/commit/1eb7f236b7bb96ee8b1cee9b0c0ec3c89132a5eb). RPC methods also work after this change:

Problems

Types for the RPC method parameters exist but the first overload for many of the types are typed as ...args: unknown[] and the remaining are correct. In the image above, all 24 overloads are correct for getBlock but not for getBalance
Types for SubtleCrypto such as CryptoKeyPair are missing
After typing rpc. there is ~1s delay before suggestions show up, I thought this could be happening only in playground so I tried the same code in VSCode locally and noticed a similar delay when dealing with the RPC methods

After typing rpc. there is ~1s delay before suggestions show up…

1 second? That's pretty awesome. It used to be 14. In all seriousness, though, presumably it's slower here than with an LSP because typechecking is happening on the client side here, right? I'm hoping that we can hold the dam back until TypeScript resolves https://github.com/microsoft/TypeScript/issues/14107

…but not for getBalance

Oh, weird. In my editor (TypeScript 5.2.2) it looks like this.

Is this a TypeScript version problem? It's 4.x that's running in playground, right? Seems like that interface has been in the DOM types for quite a while.

1 second? That's pretty awesome. It used to be 14. In all seriousness, though, presumably it's slower here than with an LSP because typechecking is happening on the client side here, right?

14 -> 1 sounds great to hear 😅  and yes, it's happening on the client side and it's a bit slower because it's running in a browser but the type resolution is usually fast enough that you wouldn't notice the difference.

I'm hoping that we can hold the dam back until TypeScript resolves microsoft/TypeScript#14107

Looks like it's going to get resolved anytime now 👍

Oh, weird. In my editor (TypeScript 5.2.2) it looks like this.

Yeah, this seems to be a playground specific problem, haven't debugged yet.

Is this a TypeScript version problem? It's 4.x that's running in playground, right? Seems like that interface has been in the DOM types for quite a while.

DOM adds a lot of unnecessary types for playground usage so it's not enabled currently but we can easily add the types we need. Are there any other types we need from DOM besides the crypto types?

Are there any other types we need from DOM besides the crypto types?

I removed "DOM" from all the tsconfigs and ran the typechecker to get an idea of what else. Got errors for AbortSignal, AbortController, CryptoKey, CryptoKeyPair, SubtleCrypto, DOMException, AbortSignalEventMap, EcKeyGenParams, RsaHashedKeyGenParams, CloseEvent, WebSocket, MessageEvent, KeyUsage, JsonWebKey, and BufferSource, but many of those probably don't make it to the external API so ¯\_(°ペ)_/¯

I removed "DOM" from all the tsconfigs and ran the typechecker to get an idea of what else. Got errors for...

Thanks, I've added a lighter version of DOM types and it seems to work great now.

Only the incorrect rpc method types issue remains. It's interesting that getBlock works even though it seems to be the most complicated one with 24 overloads — any idea why that could the case? This works as expected:

but other methods have (...args: unknown[]): PendingRpcRequest<unknown> type as an extra overload:

overload types also work:

but it's just that the first overload is incorrect which makes the return types unknown too.
I've tested it with different TypeScript and monaco-editor versions too but it made no difference.


Remove left & right curve

Hello,
I'm not familiar with d3-shape.
Can you please help me how to remove the curve of left and right of bottom bar? Just keep the curve for center.

hi @whatoken ,
Refer this code:
<CurvedBottomBar.Navigator
  ...
   borderTopLeftRight ={false}
>


Upgrade to clang 5

There are some weird indexing bugs with Chrome, so upgrading is going to take some investigation. All of the index tests pass, though.

Note, some distros have upgraded to ncurses 6 and they may not be able to find libtinfo.so.5.
ldd build/clang+llvm-4.0.0-x86_64-linux-gnu-ubuntu-14.04/bin/clang  => libtinfo.so.5


Profiling

Hi,
How can I profile my app ? When I launch my app in profiling mode with Pycharm only the "server" get profiled so i can only see weird function call and not a single one from my code.

eSW-Dashboard5.pstat.zip

nobody :( ?

Hi, I've never used Pycharm, but I can confirm is that your app runs in a different process, so you'll need support for multiprocessing profiling (not sure if Pycharm and the version you're using support this). You may find it under the name "AppProcess" as that's the name the process is initialised with.


CEQ-8951 manage jasypt to avoid dependency convergence errors between Camel and CXF

This is a temporary workaround that can be removed once we are on Quarkus CXF 3.8.4
There is no need to port this to upstream.

@ppalaga I took the liberty of incorporating this change in https://github.com/jboss-fuse/camel-quarkus/pull/342. Hope that's ok with you.

@ppalaga I took the liberty of incorporating this change in #342. Hope that's ok with you.

Thanks and sorry about that. It went away from my attention due to PTO.

Implemented in https://github.com/jboss-fuse/camel-quarkus/pull/342.


Adapt TensorFlowTestCase.setUp() to new reset_default_graph() semantics

Avoid calling reset_default_graph() directly to prevent exceptions in
cases where test methods error out from within nested graph contexts,
which can leave _default_graph_stack non-empty in certain Python
versions.
This should address the test failures (tensorflow/python:session_test and tensorflow/contrib/session_bundle:exporter_test) introduced by #11158 in certain Python versions (e.g., Mac Python 3.5).
cc @Thenerdstation

This should address the test failures (tensorflow/python:session_test and tensorflow/contrib/session_bundle:exporter_test) introduced by #11158 in certain Python versions (e.g., Mac Python 3.5).
cc @Thenerdstation

Thank you for figuring this out! I wonder why it was Mac only.
Can we call reset default graph after resetting the stack?

@drpngx This is not only "mac-only". This seems to be "mac + python 3.5 only", because python 2.7 and 3.6 don't cause those tests to fail on mac.
Calling reset_default_graph() after calling reset() on the stack seems redundant?

Yeah I was just thinking that 😋
On Jul 6, 2017 8:40 PM, "Shanqing Cai"<EMAIL_ADDRESS>wrote:

@drpngx https://github.com/drpngx This is not only "mac-only". This
seems to be "mac + python 3.5 only", because python 2.7 and 3.6 don't cause
those tests to fail on mac.
Calling reset_default_graph() after calling reset() on the stack seems
redundant?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tensorflow/tensorflow/pull/11340#issuecomment-313579109,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AT_Sbd1tJK1gtqRt6FcH5dira-COYj4Sks5sLajGgaJpZM4OQci2
.

@drpngx Actually on second thought, I think calling reset_default_graph() after reset() is a good idea. reset_default_graph() may do extra things in the future. Calling it gets rid of the need to track those future changes here. I made some further revision to add that and to make the comments clearer.

Merging to fix nightlies.

@mrry We can continue investigating whether there is a bug in the stack finally blocks.

Ack, merging was the right way to go... I've looked in the implementation of contextlib.py for Python 3.5 and 3.6. While there are some small diffs, I can't see anything that looked relevant. My hunch is that there's something special about RuntimeError (since it gets used internally in the contextlib implementation), but I didn't find a smoking gun.


Duration bugged

Since youtube api v2 is not supported anymore. Send duration of video with post request.

in history

Closed by #21, probably should fix all the 3:03 songs.


Map style

Consider using a Mapbox Light style with dark building extrusions (ideally highlighting a building by name)
Call out the number of events clustered in one location with a symbol if >1 event
Use comment/document symbol from IBM design guide as marker
Distinct markers for music and films in a similar style as ^^

nice new doc-icon


Example App Views Memory Leak?

Hi @ekazaev
I hope you are well.
Having built my app's chat vc off the example app, I was checking if the chat vc was being deallocated after popping it. The result was yes, chat vc is always deallocated, but I realised some of the chat views remain in memory, cause the memory to always increase when opening the same chat. I have a few pics below from memory graph debugger.
I know it's not a big deal, but can you shed a light on it? Thanks.
I took the screenshot below after entering and dismissing chat view 3 times, which has 4 messages.

@ElrB Hi
Thank you for the issue.
It technically should not. But example app I mostly use for the experiments, so some memory issues may slip away from me. Ill have a look.

Closing due to inactivity.


Failed to open app from background.

I am using alarm_manager_plus to launch my application from the background. Any other applications starts freely except for the one from which it is launched.

Fixed in latest version


RHBPMS-4557: NPE when searching nonexistent task using the method Use…

…rTaskServicesClient.findTaskById

Do we really need full integration test for this? Integration tests are quite time consuming, so we should try to create unit tests for simple fixes like this. WDYT?

I think it is suitable for this case. There is also checked that endpoint will correctly process not existing task and return proper response and client will handle the response accordingly.

agreed that it does make sense to have this as integration test. Actually I think that cause we have this as integration test we got these failures captured that are not handled same for JMS, @jesuino would you mind taking a look?

jenkins retest this

After a little bit of research I have found that in JMS there is no exception thrown on the server side so the response is marked as SUCCESS since null is returned. On the client side, since it is a SUCCESS, it is simply returned. To have the same behaviour I would suggest to throw an exception like with UserTaskServiceBase so it is handled as a failure for both REST and JMS.
So what do you think?
Marian

After a discussion with @psiroky we agreed that I will create a new PR for this with the same handling as in the case of client's getTaskInstance method (handled via exceptions).

I noticed that it would require changes on JMS side and how it deals with exceptions so I was supposed to talk to you about it, but I see @MarianMacik took over this issue, thanks, Marin!

replaced (and already merged) by https://github.com/droolsjbpm/droolsjbpm-integration/pull/797


Delete unused tasks and pipeline definitions and update README

Description

Removed duplicates and fixed README.
README will be polished further after the Git Fetch pipeline is merged.
Unified structure of  directories in pipelines/tekton. Now there are templates directories for secret templates and example-pipelineruns for example pipeline runs.
Refactored variable names in shell tests to better reflect reality.

How Has This Been Tested?
PR check.
Merge criteria:

[x] The commits are squashed in a cohesive manner and have meaningful messages.
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has manually tested the changes and verified that the changes work

/retest

/lgtm

(For the records) After an offline discussion with @MarianMacik, we will re-visit the Readme contents/location after git-fetch-pipeline is merged in.

/lgtm

/approve

/approver (just because because @biswassri is not)

/approve (just because because @biswassri is not)


feat: add @prismicio/client's ClientConfig to CreateClientConfig

Types of changes

[ ] Chore (a non-breaking change which is related to package maintenance)
[ ] Bug fix (a non-breaking change which fixes an issue)
[x] New feature (a non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Description
This PR adds @prismicio/client's ClientConfig type to @prismicio/next's CreateClientConfig type.
This lets developers accept client-specific configuration alongside enableAutoPreviews() configuration without manual typing.
CreateClientConfig is provided solely as a convenience type and is not used within @prismicio/next.
Before:
// prismicio.ts

import * as prismic from "@prismicio/client";
import * as prismicNext from "@prismicio/client";

export const createClient = ({
  previewData,
  req,
  ...config
}: prismicNext.CreateClientConfig &
  prismic.ClientConfig = {}): prismic.Client => {
  const client = prismic.createClient("qwerty", config);

  prismicNext.enableAutoPreviews({ client, previewData, req });

  return client;
};

After (note the removal of prismic.ClientConfig):
// prismicio.ts

import * as prismic from "@prismicio/client";
import * as prismicNext from "@prismicio/client";

export const createClient = ({
  previewData,
  req,
  ...config
}: prismicNext.CreateClientConfig = {}): prismic.Client => {
  const client = prismic.createClient("qwerty", config);

  prismicNext.enableAutoPreviews({ client, previewData, req });

  return client;
};

Checklist:

[ ] My change requires an update to the official documentation.
[x] All TSDoc comments are up-to-date and new ones have been added where necessary.
[x] All new and existing tests are passing.

Codecov Report

Merging #37 (dde7401) into main (80e876f) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main       #37   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           11        11
  Lines          665       665
  Branches        33        33
=========================================
  Hits           665       665

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


HSEARCH-4790 Add compatibility with OpenSearch 2.5.0

https://hibernate.atlassian.net/browse/HSEARCH-4790

Going to merge this one as the failed test looks to be the same one that fails in the main build.


Upgrade Ingress-nginx to newer version

Chart to upgrade
upstream/ingress-nginx - https://github.com/kubernetes/ingress-nginx/blob/main/charts/ingress-nginx/Chart.yaml
Reason for upgrade

[ ] Security patching
[ ] Upgrade to allow new features
[X] Upgrade to prevent future issues
[ ] Upgrade to maintain a supported version
[ ] Other - Write the reason below

Additional context
No response
Acceptance criteria

I checked the migration of the new chart version:

[ ] The upgrade does not require migration steps
[ ] The upgrade requires migration steps

I tested the functionality of the new chart version:

[ ] The upgrade does not change current functionality
[ ] The upgrade changes current functionality

Upgrade to at least v1.11.2 to fix vulnerability CVE-2024-7646

Upgrade to at least v1.11.2 to fix vulnerability CVE-2024-7646

v1.10.4 also has the fix.


Azure SDK sup report ready not working

When I go to https://msit.powerbi.com/groups/3e17dcb0-4257-4a30-b843-77f47f1d4121/reports/c30a45b0-ae9b-4b19-9a33-b8ecfe8e5e3c/ReportSectionda56afa07b9b086510e1 I get this and no way to update the report:

@ladonnaq who is the person responsable for this?
The Data plane SDK release app is using this link for:

@ladonnaq who is the person responsable for this? The Data plane SDK release app is using this link for: <img alt="image" width="1281" src="https://private-user-images.githubusercontent.com/9868623/271687895-36520c7f-081b-4b5f-be3b-16a6503fd198.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDQ3NDc3OTEsIm5iZiI6MTcwNDc0NzQ5MSwicGF0aCI6Ii85ODY4NjIzLzI3MTY4Nzg5NS0zNjUyMGM3Zi0wODFiLTRiNWYtYmUzYi0xNmE2NTAzZmQxOTgucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDEwOCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDAxMDhUMjA1ODExWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9Y2JiOWM0ZDVmMzMwYzJkZjc5YTc3NzQyNDNjMzhiZWJiMGE1MDMxMjBmNWViNWZhZmE3MTUzM2VjNmU3NDIyYSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.tuamvtJ17ykL-2AhRFHubHyPUgPJQYZUP7TDMC67ey0"

@maririos I do not know who owns the report.  If you have not identified the owner yet, I will ask around and find out who owns it.

@ladonnaq  Should we just remove this line from our apps then if no one knows? it means it is not useful for our team....

I am going to remove this from the apps as it is useless as is.

I am going to remove this from the apps as it is useless as is.

Sounds good.  Can we go ahead and close this issue?

Sounds good. Can we go ahead and close this issue?

I will close when it is deployed to PROD

[heart]         LaDonna Quinn reacted to your message:

From: Mariana Rios Flores @.>
Sent: Monday, March 25, 2024 5:23:36 PM
To: Azure/azure-sdk-tools @.>
Cc: Comment @.***>
Subject: Re: [Azure/azure-sdk-tools] Azure SDK sup report ready not working (Issue #7035)
Sounds good. Can we go ahead and close this issue?
I will close when it is deployed to PROD
—
Reply to this email directly, view it on GitHubhttps://github.com/Azure/azure-sdk-tools/issues/7035#issuecomment-2018520630 or unsubscribehttps://github.com/notifications/unsubscribe-auth/AQEFYOV6D6JI2TJQPWVR76DY2BMRTBFKMF2HI4TJMJ2XIZLTSWBKK5TBNR2WLJDUOJ2WLJDOMFWWLO3UNBZGKYLEL5YGC4TUNFRWS4DBNZ2F6YLDORUXM2LUPGBKK5TBNR2WLJDUOJ2WLJDOMFWWLLTXMF2GG2C7MFRXI2LWNF2HTAVFOZQWY5LFUVUXG43VMWSG4YLNMWVXI2DSMVQWIX3UPFYGLAVFOZQWY5LFVIZDGNJUGA3TINBSGOSG4YLNMWUWQYLTL5WGCYTFNSBKK5TBNR2WLKRUGI4DKMBUGU2DOMNENZQW2ZNJNBQXGX3MMFRGK3FMON2WE2TFMN2F65DZOBS2YSLTON2WKQ3PNVWWK3TUUZ2G64DJMNZZJAVEOR4XAZNKOJSXA33TNF2G64TZUV3GC3DVMWUTCNZQGU4TEMJYG2BKI5DZOBS2K2LTON2WLJLWMFWHKZNKGE4TCOJXGE4TONBXQKSHI6LQMWSWYYLCMVWKK5TBNR2WLKRSGM2TIMBXGQ2DEM4CUR2HS4DFUVWGCYTFNSSXMYLMOVS2UNBSHA2TANBVGQ3TDJ3UOJUWOZ3FOKTGG4TFMF2GK.
You are receiving this email because you commented on the thread.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.


[WIP] #148: Added CODE128 options

Implemented options discussed in #148
Please, do not merge.
@lindell thoughts?

I will take a look at this when I come home from work today :) But seems good :)

During working on this pr, I found a bug in auto detection of type (A/B/C). There are several cases when it starts from wrong type. I think it should be fixed first. I'll try to fix it.

LGTM 🙂 Merge if you feel ready

@lindell should I merge it?

Go for it :)


background at login

At login, background is still white
cleared all the caches possible. chrome latest version

thanks !

Hi! Updated it to rgb(55, 55, 55). Hope that change not broke another styles.


Document Panel: Story poster displayed with wrong aspect ratio

Bug Description

Story portrait posters are at least 640x853 and maintain a 4:3 aspect ratio.
Yet, in the document panel we display the story poster image in 9:16 aspect ratio, which means the image is stretched.
Expected Behaviour

The story poster image is displayed with 4:3 aspect ratio
The <img> has width and height attributes

Steps to Reproduce

Add story poster image
Inspect thumbnail in dev tools
See image is stretched

Screenshots

Additional Context

Plugin Version: 1.8.0
WordPress Version: 5.8
Operating System: macOS
Browser: Chrome

Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance Criteria

Implementation Brief

Verified in QA


🔲 Carousel inside another carousel

Is there a way with React Slick to have Carousel inside Carousel ?
import Slider from "react-slick";

<Slider
    {...settings}
>

            <Slider
                {...settings}
            >
                ...
            </Slider>

</Slider>

I tried this kind of code but it completely messed up both carousels.
I don't need to have swipe, dots or arrow, carousel are fully controlled using slickGoTo.
Thank for your help

I don't think we can support this usecase


[Bug]: API key in forecast not working

Is there an existing issue for this?

[X] I have searched the existing issues

Describe the bug
The API key in forecast page is not working and is giving an error
current API key : https://visual-crossing-weather.p.rapidapi.com/forecast
Expected behavior
showing humidity, temperature and heat index correctly
Add ScreenShots

On which device are you experiencing this bug?
Windows
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC'24 contributor
[X] I have starred the repository

hi @mishradev1  just enable it in the below file
https://github.com/manikumarreddyu/AgroTech-AI/blob/main/frontend/src/context/StateContextProvider.jsx
just uncomment line no 27..beacuse veryone is thinking like it is a bug

hey @mishradev1 thanks you so much for showing interest in AgroTech AI..looking for more contributions from your side.


unwind/remove/retire all #if SILVERLIGHT references

Do you want to request a feature or report a bug?
bug/possible dead code
What is the current behavior?
Investigate why SILVERLIGHT is still defined in our netstandard branch and 🔥 all references/remove dead code where need be.

We don't support this platform anymore.
What is the motivation / use case for changing the behavior?
RIP
Which versions of ReactiveUI, and which platform / OS are affected by this issue? Did this work in previous versions of ReativeUI? Please also test with the latest stable and snapshot (http://docs.reactiveui.net/en/contributing/snapshot/index.html) versions.
Found on the develop branch

You say "investigate why SILVERLIGHT is still defined" - I'm not convinced it is? Think it should be burnable without much trouble (probably should have done it with the main changes around netstandard, but didn't want to bloat that!)

This is a duplicate of #1365 I think, not sure which is worth keeping around though, and #1425 should fix both anyways :)

Closing out as duplicate


WIP - Chore/webpack v5

Codecov Report

Merging #209 (4f6b583) into develop (8d2409b) will decrease coverage by 0.05%.
The diff coverage is 85.71%.

@@             Coverage Diff             @@
##           develop     #209      +/-   ##
===========================================
- Coverage    86.08%   86.03%   -0.06%
===========================================
  Files          477      477
  Lines         6130     6107      -23
  Branches       580      580
===========================================
- Hits          5277     5254      -23
  Misses         785      785
  Partials        68       68

Impacted Files
Coverage Δ

src/modules/datePicker/index.ts
100.00% <ø> (ø)

src/modules/filter/index.ts
100.00% <ø> (ø)

src/modules/queries/index.ts
100.00% <ø> (ø)

src/modules/textEditor/index.ts
100.00% <ø> (ø)

src/modules/theme/index.ts
100.00% <ø> (ø)

src/modules/timezone/index.tsx
100.00% <ø> (ø)

src/modules/widgets/index.ts
100.00% <ø> (ø)

...mponents/DashboardListOrder/DashboardListOrder.tsx
93.93% <75.00%> (ø)

src/components/ChartWidget/ChartWidget.tsx
97.01% <100.00%> (ø)

src/components/FilterWidget/FilterWidget.tsx
81.25% <100.00%> (ø)

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d2409b...4f6b583. Read the comment docs.


timeline labels

From<EMAIL_ADDRESS>on February 02, 2012 22:45:34
If someone want to change labels on the bottom of the timing diagram 1 2 3 ...
we can provide the way of overwriting the timeline labels from config section:
{
"signal" : [ ... ],
"config" : { "timeline" : ['1','2','3','100','A'] }
} https://groups.google.com/forum/?fromgroups#!topic/wavedrom/KlqxDiVoBMo
Original issue: http://code.google.com/p/wavedrom/issues/detail?id=40

Was implemented using foot.tock property:
{signal: [
  {name:'clk',         wave: 'p....' },
  {name:'Data',        wave: 'x345x', data: 'a b c' },
  {name:'Request',     wave: '01..0' }
],
 foot:{
   tock:'1 2 3 100 A'
 }
}

The previous JSON string prints a "zero" 0 at the end of the tocks. Is this a bug?

don't know if it's a bug but it seems like adding a space at the end of the string fixed that trailing zero for me, i.e., tock:'1 2 3 100 A ' rather than tock:'1 2 3 100 A'


[1.13] Instruct users to manually clean stale routing rules after downgrade

Downgrade from 1.13 to 1.12 (EOL) requires manual cleanups, this PR adds the upgrade and downgrade notes in Documentation.
This PR also makes sure the manual cleanups are only run for minor downgrade in ci-ipsec-upgrade.

/test-backport-1.13

/test-backport-1.13

/test-1.17-4.19

/test-1.17-4.19


[WIP] Enhancement/case escalation modal

Adds the ability to modify incident details before a case is escalated via a dedicated dialog.
@mvilanova this is still a bit rough; e.g. I'm not yet happy with how much space the incident resources take up in the dialog. I also was cognizant of not modifying your original flow/functionality, so all of these changes are additive, and there is likely room for some refactoring.

I'll run the code locally and circle back with feedback.


Fix #3089 issue

internationalisation added on about page

@wetneb  if i pass links as parameter it is not displayed as links its just displayed as normal text  . we have a fix for this in react but i am not sure how to do this in jquery and json ,html ,
i am looking for it .
i just found one approach to due it to break it as i did ,
can you please guide me to any reference or anything as such to find this solution.

Another comment: please use an informative title for your pull request, and add the "Fix #3089" in the description (body text) of the pull request instead, so that GitHub can properly link the pull request to the issue.