noAssert in MessagePrototype.set() doesn't work for an undefined field.

I'd like to set a field value which isn't defined in a proto file. To avoid throwing the error, I tried to use the 'noAssert' parameter. But, it still throws error because the following code doesn't check if the field exists.
https://github.com/dcodeIO/ProtoBuf.js/blob/master/dist/ProtoBuf.js#L2535
var field = T._fieldsByName[keyOrObj];
if (!noAssert) {
    if (!field)
        throw Error(this+"#"+keyOrObj+" is not a field: undefined");
    if (!(field instanceof ProtoBuf.Reflect.Message.Field))
        throw Error(this+"#"+keyOrObj+" is not a field: "+field.toString(true));
    this[field.name] = (value = field.verifyValue(value)); // May throw
} else {
    this[field.name] = value;                 <=== here
}
if (field.oneof) {
    ...
}

Is it intended or just a bug? What about changing it to the following code?
} else {
    if (field) {
        this[field.name] = value;
    } else {
        this[keyOrObj] = value;
    }
}
if (field && field.oneof) {
    ...
}

The noAssert parameter is meant to speed things up a bit in case that an operation is already known to succeed. With Message#set, this is if you are sure that the field exists and that the value is correct for its type, which saves you a relatively expensive call to Reflect.Message.Field#verifyValue.
I have now hardened this a bit to not throw in most cases (not sure if this is a good idea though), but you should just assign a property to the message as with normal JS if it is not a field, as Message#set, by contract, is meant to be used to set values for fields only.
Message#add for example will still throw if you are trying to add a value to a non-repeated field respectively custom property which is not an array.


Complex boolean logic for strings

Hi
Currently you can assess a string using the smart formatter and decide it's usage like so;
{Keywords: {}|}
I was wondering if in the future more complex logic could be used so something like the below could be used;
{Keywords && Location: some example test|}
Currently I have a boolean return from a property which does this assessment for me so my format is still neat but I would love to get this all inline.
Love the library btw, it's really helped cut down my codebase.
Thanks!

With #43, it will be somewhat easier to manage this using nested scopes.  For example, you could do something like:
{Keywords:{Location: {Keywords} {Location}| (nothing) }| (nothing)}


[terra-content-container] Adding UX recommendation for header and footer attribute

Summary

Adding the recommendation for header and footer attribute in terra-content-container

Closes #
Testing

Additional Details

Thank you for contributing to Terra.
@cerner/terra

Was UX recommendation was to set header to h3 always OR any heading level  with h3 and lesser than h3 ??

Was UX recommendation was to set header to h3 always OR any heading level with h3 and lesser than h3 ??

Before the changes, it was h2, after verification with UX i was changed to h3


cephfs.admin.New is missing Shutdown

it looks like RadosCommander is a regular rados connection, which should be shutdown i think,
but when you use the convenience function admin.New, it doesnt expose the RadosCommander, so you cant shut it down

Excellent point, thank you for reporting this issue.
Looking at the other admin sub-packages: rbd/admin, common/admin/nfs, common/admin/manager - we did not add a New function that sets up the rados connection internally. We only provided NewFromConn functions.
That leads me to think that our best course of action is to deprecate and eventually remove the (cephfs admin) admin.New function.  That may be slightly less convenient but it simplifies the approach and makes cephfs/admin more like the other admin packages.
Regardless of how we attempt to resolve this issue I suggest using NewFromConn in the meantime, thanks!


TimeoutError: Navigation timeout of 30000 ms exceeded

Getting this error when trying to run the script:

Same


Added "CanAssignBedToPlayer" and "CanUnlockCodeLock" hooks.

Step 1: Describe the changes
I've added two new hooks, CanAssignBedToPlayer and CanUnlockCodeLock. The first allows you prevent players from giving bags to friends. The other allows you to prevent a user from interacting with a code lock, regardless of the code entered.
These changes are to assist with a group size limited server in which we are trying to limit beds in a radius and code lock access without allowing code entry and afterwards preventing door access. It's a better experience overall.
Step 2: Review the checklist

[X] Ensure that the changes compile and match the formatting conventions and standards used

Step 3: Documentation
I will submit the documentation update pull request in a comment after submission.

https://github.com/OxideMod/Docs/pull/58

Fun stuff. Immediately after trying a code lock, it automatically attempts to open the door. So combining the CanUseLock to also be on code entry makes it call the event twice per code entry operation.
Do these really need to be combined?

Any update on this? Would love to post the group size limiter to Oxide for next wipe.

@Mughisi I tried the OnTryUnlock method you mentioned.
As nice as preventing the dialog was, the OnTryUnlock method does not get called when guest codes are entered. I will need to use the method as-defined here.

Both hooks were included in commit https://github.com/OxideMod/Oxide/commit/c24c99dec64881e01956fc52d461d0436889c72b as CanAssignBed and OnCodeEntered


[question] Is NetLink a hard-dependency?

I am not able to build OpenR on FreeBSD because NetLink is a Linux kernel protocol.
Is dependency on NetLink hard, or it is possible to disable it?
Thanks,
Yuri

Hi Yuri,
Netlink is a hard dependency now. It's integrated with LinkMonitor module.
There is a project netlink-freebsd to build netlink on FreeBSD. Not sure if can help. https://github.com/luigirizzo/netlink-freebsd
Best Regards,
Summer

Thank you.


How to install

Is this extension available on the vscode marketplace (I can't find it!)?
Otherwise do I need to manually create a package from this repo?
Perhaps add an "Installation" section to the documentation to address this?

Apologies, I found it: https://marketplace.visualstudio.com/items?itemName=HoangKimLai.ipython
Still could be useful to add to README?

I have created a PR with a small change to the README:
https://github.com/hoangKnLai/vscode-ipython/pull/61

I have created a PR with a small change to the README: #61

Thanks! Will merge when I get a chance.


Enable authentication for collectors registering with the collectorist

#530 should be in place first to avoid leaking credentials.

This is done, thanks @ctron


Added: http request context handling

see: https://github.com/pivotal-cf/brokerapi/issues/29
#132019309

Alternative impl:
https://github.com/pivotal-cf/brokerapi/pull/31

Thanks for this! We prefer this implementation to #31 as it follows the pattern defined in the standard library, specifically:
Do not store Contexts inside a struct type; instead, pass a Context explicitly to each function that needs it. The Context should be the first parameter, typically named ctx:
After discussing this with our PM, we are happy to have a breaking change to our ServiceBroker interface to support Contexts, and support go 1.7 as a minimum going forward.  Therefore we do not need the backwards compatibility you've added to this PR.
In summary:

Change context.Context to the first parameter on the ServiceBroker interface functions
Remove the support for backwards compatibility, and explicitly support context on the ServiceBroker interface.

Cheers,
Alex & @Samze

Great, I'll make the changes today.

Thank you @lwoydziak for the making the changes. We think we should add the HTTP request context to LastOperation as well, unless you can think of a reason not to?

@Samze Good point, after further conversation around here, it makes sense to have them on all calls as we are not sure what the implementation will end up doing. - Uploaded a patch to reflect that.

Thank you @lwoydziak


Search from initial page causes error

Buggy behavior:

Start up initial page
Enter name
Press enter to submit
Nothing happens. Expected: Taken to search loading
Click submit with mouse
Error test 23456 Expected: Taken to search loading

Afterwards it works fine.

Edit:
After 6. clicking doesn't work but enter does.


nuclear RNA

Hi,
I am trying the tool for the quantification of nuclear RNA, after my recent tweets with Lior Patcher.
Every commands in the Velocity tutorial seems to work, but I want only the quantification by gene taking into account reads in introns and exons, so I am really don't want the outputs in the velocity tutorial.
I imagine that something like this is the solution after doing correct and sort:
bustools count -o counts -g t2g.txt -e matrix.ec -t transcripts.txt --genecounts output.sort.bus

but I want to make sure that t2g.txt is the correct. I noticed the annotation for introns is TRANSCRIPT.N-I meanwhile the exons is TRANSCRIPT.N. If the t2g.txt file is lie this:
ENST00000456328.1       ENSG00000223972 DDX11L1
ENST00000450305.2       ENSG00000223972 DDX11L1
ENST00000488147.3       ENSG00000227232 WASH7P

It would recognized introns and exons, or I need to add the intron annotation to the file?
Thanks!

The cDNA_introns.t2g.txt file provided in the tutorial does have both intons and exons in the same txt file. You can take a look at the beginning and end of the file by doing:
$wget https://github.com/BUStools/getting_started/releases/download/velocity_tutorial/cDNA_introns.t2g.txt.gz

$ gunzip cDNA_introns.t2g.txt.gz

$ head cDNA_introns.t2g.txt
ENST00000456328.1       ENSG00000223972 DDX11L1
ENST00000450305.2       ENSG00000223972 DDX11L1
ENST00000488147.3       ENSG00000227232 WASH7P
ENST00000619216.4       ENSG00000278267 MIR6859-1
ENST00000473358.5       ENSG00000243485 MIR1302-2HG
ENST00000469289.6       ENSG00000243485 MIR1302-2HG
ENST00000607096.7       ENSG00000284332 MIR1302-2
ENST00000417324.8       ENSG00000237613 FAM138A
ENST00000461467.9       ENSG00000237613 FAM138A
ENST00000606857.10      ENSG00000268020 OR4G4P

$ tail cDNA_introns.t2g.txt
ENST00000463325.1056070-I       ENSG00000184319 RPL23AP82
ENST00000463325.1056071-I       ENSG00000184319 RPL23AP82
ENST00000494075.1056072-I       ENSG00000184319 RPL23AP82
ENST00000494075.1056073-I       ENSG00000184319 RPL23AP82
ENST00000494075.1056074-I       ENSG00000184319 RPL23AP82
ENST00000423888.1056075-I       ENSG00000184319 RPL23AP82
ENST00000423888.1056076-I       ENSG00000184319 RPL23AP82
ENST00000423888.1056077-I       ENSG00000184319 RPL23AP82
ENST00000480246.1056078-I       ENSG00000184319 RPL23AP82
ENST00000480246.1056079-I       ENSG00000184319 RPL23AP82

Thanks, so this command should be ok?:
bustools count -o genes/ --genecounts -g cDNA_introns.t2g.txt -e matrix.ec -t transcripts.txt output.correct.sort.bus

Yes.
Just so you know, there is small issue right now in that bustools will not create the subfolder if you give it a multi folder output (e.g. if you want the output on ./sample2/genecounts) so you need to make sure the folder exist in that case. If you'd like to do that, this is how I'd make sure the folder gets created prior to running the command:
mkdir -p ./sample2/genecounts

bustools count \
--output  ./sample2/genecounts/genes \
--genecounts \
--genemap /references/homo_sapiens-ensembl-96/transcripts_to_genes.txt \
--ecmap ./sample2/matrix.ec \
--txnames  ./sample2/transcripts.txt \
./sample2/output.corrected.sorted.bus

Thank you!
Sadly I am having a segmentation fault (with the conda and source code compiled by myself) only for that command, this is the debug output, I don't know if that helps.
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib64/libthread_db.so.1".

Program received signal SIGSEGV, Segmentation fault.
0x000000000043f9e0 in std::vector<int, std::allocator<int> >::begin (this=0x2aabd9af73f8) at /usr/include/c++/4.8.2/bits/stl_vector.h:548
548           { return const_iterator(this->_M_impl._M_start); }
(gdb) bt
#0  0x000000000043f9e0 in std::vector<int, std::allocator<int> >::begin (this=0x2aabd9af73f8) at /usr/include/c++/4.8.2/bits/stl_vector.h:548
#1  0x000000000045cb53 in intersect_genes_of_ecs (ecs=std::vector of length 1, capacity 100 = {...}, ec2genes=std::vector of length 12317869, capacity 16777216 = {...},
    glist=std::vector of length 0, capacity 100) at /home/lpantano/om2-pilm/conda3/envs/bustools/share/bustools/src/Common.cpp:174
#2  0x0000000000450ddb in __lambda1::operator() (__closure=0x7fffffffbdb0, v=std::vector of length 6345915, capacity 6400000 = {...})
    at /home/lpantano/om2-pilm/conda3/envs/bustools/share/bustools/src/bustools_count.cpp:177
#3  0x0000000000451a87 in bustools_count (opt=...) at /home/lpantano/om2-pilm/conda3/envs/bustools/share/bustools/src/bustools_count.cpp:241
#4  0x000000000043dd35 in main (argc=12, argv=0x7fffffffd868) at /home/lpantano/om2-pilm/conda3/envs/bustools/share/bustools/src/bustools_main.cpp:1072

The output folder has an empty MTX file.
the other count commands work, so is not this step specifically.
I will try the test data to make sure is not my sample, but I really want to have this working with my data, let me know if I can give you any more information.
If it is the cpp library version, can you tell me the one you have that is working so I can try to compile versus that particular version?
thanks!

Please make sure that all of the files you're giving bustools exist (that
the path is correct) and that the bus file is not empty.
If the issue persists please try again with test data.
Every time we've seen seg faults its because either we were giving it empty
files, or paths to files that didn't exist.
On Tue, Jul 23, 2019, 10:35 Lorena Pantano<EMAIL_ADDRESS>wrote:

Thank you!
Sadly I am having a segmentation fault (with the conda and source code
compiled by myself) only for that command, this is the debug output, I
don't know if that helps.
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib64/libthread_db.so.1".
Program received signal SIGSEGV, Segmentation fault.
0x000000000043f9e0 in std::vector<int, std::allocator >::begin (this=0x2aabd9af73f8) at /usr/include/c++/4.8.2/bits/stl_vector.h:548
548           { return const_iterator(this->_M_impl._M_start); }
(gdb) bt
#0  0x000000000043f9e0 in std::vector<int, std::allocator >::begin (this=0x2aabd9af73f8) at /usr/include/c++/4.8.2/bits/stl_vector.h:548
#1  0x000000000045cb53 in intersect_genes_of_ecs (ecs=std::vector of length 1, capacity 100 = {...}, ec2genes=std::vector of length 12317869, capacity 16777216 = {...},
glist=std::vector of length 0, capacity 100) at /home/lpantano/om2-pilm/conda3/envs/bustools/share/bustools/src/Common.cpp:174
#2  0x0000000000450ddb in __lambda1::operator() (__closure=0x7fffffffbdb0, v=std::vector of length 6345915, capacity 6400000 = {...})
at /home/lpantano/om2-pilm/conda3/envs/bustools/share/bustools/src/bustools_count.cpp:177
#3  0x0000000000451a87 in bustools_count (opt=...) at /home/lpantano/om2-pilm/conda3/envs/bustools/share/bustools/src/bustools_count.cpp:241
#4  0x000000000043dd35 in main (argc=12, argv=0x7fffffffd868) at /home/lpantano/om2-pilm/conda3/envs/bustools/share/bustools/src/bustools_main.cpp:1072
The output folder has an empty MTX file.
the other count commands work, so is not this step specifically.
I will try the test data to make sure is not my sample, but I really want
to have this working with my data, let me know if I can give you any more
information.
If it is the cpp library version, can you tell me the one you have that is
working so I can try to compile versus that particular version?
thanks!
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/BUStools/bustools/issues/11?email_source=notifications&email_token=AC7MY4FFG6TOVIQZLZMFIHLQA46MFA5CNFSM4IFLDGN2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2T33AQ#issuecomment-514309506,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AC7MY4DY2GYRRHUCAWFHV73QA46MFANCNFSM4IFLDGNQ
.

Thank you.
files exist and they are not empty:
4.7G    matrix.ec
1.5G    output.correct.sort.bus
30M     transcripts.txt
58M  cDNA_introns.t2g.txt

output folder exists. this is the command I used:
bustools count -o genes/genes --genecounts -g cDNA_introns.t2g.txt -e matrix.ec -t transcripts.txt output.correct.sort.bus
it takes a while to give the error, like 20 min or so. There is an empty file at genes/genes.mtx.
I tried the with the example data: bus_output_06 and the same error appeared.   I used only a pair of files when aligning to speed up computation:
06/10X_17_029_MissingLibrary_1_HL73JBCXY/bamtofastq_S1_L002_R1_001.fastq.gz 06/10X_17_029_MissingLibrary_1_HL
73JBCXY/bamtofastq_S1_L002_R2_001.fastq.gz

I tried in a different cluster machines, and the same seg.fault appeared:
Program received signal SIGSEGV, Segmentation fault.
0x000055555557682b in intersect_genes_of_ecs(std::vector<int, std::allocator<int> > const&, std::vector<std::vector<int, std::allocator<int> >, std::allocator<std::vector<int, std::allocator<int> > > > const&, std::vector<int, std::allocator<int> >&) ()

I know it is a difficult error to catch up, I am happy to help in any way possible.
cheers

If you can provide all files and the bustools binary you are using we will
try to reproduce it and identify a fix
On Wed, 24 Jul 2019 at 08:25, Lorena Pantano<EMAIL_ADDRESS>wrote:

Thank you.
files exist and they are not empty:
4.7G    matrix.ec
1.5G    output.correct.sort.bus
30M     transcripts.txt
58M  cDNA_introns.t2g.txt
output folder exists. this is the command I used:
bustools count -o genes/genes --genecounts -g cDNA_introns.t2g.txt -e
matrix.ec -t transcripts.txt output.correct.sort.bus
it takes a while to give the error, like 20 min or so. There is an empty
file at genes/genes.mtx.
I tried the with the example data: bus_output_06 and the same error
appeared. I used only a pair of files when aligning to speed up computation:
06/10X_17_029_MissingLibrary_1_HL73JBCXY/bamtofastq_S1_L002_R1_001.fastq.gz 06/10X_17_029_MissingLibrary_1_HL
73JBCXY/bamtofastq_S1_L002_R2_001.fastq.gz
I tried in a different cluster machines, and the same seg.fault appeared:
Program received signal SIGSEGV, Segmentation fault.
0x000055555557682b in intersect_genes_of_ecs(std::vector<int, std::allocator > const&, std::vector<std::vector<int, std::allocator >, std::allocator<std::vector<int, std::allocator > > > const&, std::vector<int, std::allocator >&) ()
I know it is a difficult error to catch up, I am happy to help in any way
possible.
cheers
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/BUStools/bustools/issues/11?email_source=notifications&email_token=AC7MY4BJM7TATBH7JEQLIUTQBBX5XA5CNFSM4IFLDGN2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2WWHRI#issuecomment-514679749,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AC7MY4AWYB3XD3GP4QWLITDQBBX5XANCNFSM4IFLDGNQ
.

Thank you! Here are the files:
wget https://lpantano-debug.s3.amazonaws.com/bustools/bustools
wget https://lpantano-debug.s3.amazonaws.com/bustools/cDNA_introns.t2g.txt
wget https://lpantano-debug.s3.amazonaws.com/bustools/matrix.ec
wget https://lpantano-debug.s3.amazonaws.com/bustools/output.correct.sort.bus
wget https://lpantano-debug.s3.amazonaws.com/bustools/transcripts.txt

I installed bustools with conda.
thanks so much

How did you generate this bus file? I converted the 2.6GB bus file you provided into text to inspect it and it expanded to 205GB.
Each entry that should correspond to a UMI has a length of 2573 charachters, and it repeats every 32 characters. I have attached the first 5 lines of the file for you to understand.
If you can provide the detailed steps you used to generate this file we can look further into the issue.
nuclear_rna_first_5_lines.txt

This is for the the velocity tutorial, I just took on of the samples:

kallisto bus -i cDNA_introns.idx -o bus_output_06/ -x 10xv2 -t 4
06/10X_17_029_MissingLibrary_1_HL73JBCXY/bamtofastq_S1_L002_R1_001.fastq.gz
06/10X_17_029_MissingLibrary_1_HL73JBCXY/bamtofastq_S1_L002_R2_001.fastq.gz

bustools correct -w ../../10xv2_whitelist.txt -p output.bus | bustools sort
-o output.correct.sort.bus -t 4 -

Is this the information you need? I just followed the steps in the tutorial.
Thanks for helping with this.
On July 26, 2019 at 1:10:45 AM, Eduardo Beltrame<EMAIL_ADDRESS>wrote:
How did you generate this bus file? I converted the 2.6GB bus file you
provided into text to inspect it and it expanded to 205GB.
Each entry that should correspond to a UMI has a length of 2573
charachters, and it repeats every 32 characters. I have attached the first
5 lines of the file for you to understand.
If you can provide the detailed steps you used to generate this file we can
look further into the issue.
nuclear_rna_first_5_lines.txt
https://github.com/BUStools/bustools/files/3434254/nuclear_rna_first_5_lines.txt
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/BUStools/bustools/issues/11?email_source=notifications&email_token=AAML6HHNZUSIGRUK2DXKBALQBKBNLA5CNFSM4IFLDGN2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD23QNCI#issuecomment-515311241,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAML6HAZCKJOS4D5TBC546TQBKBNLANCNFSM4IFLDGNQ
.

The fastq files were done by:

bamtofastq --reads-per-fastq=500000000 10X_17_029.bam ./06

Can I convert the BUS file to text? I have my sample as well and I could
see if that happens with my sample as well. Or I can give it to your.
Thanks
On July 26, 2019 at 9:00:29 AM, Lorena Pantano<EMAIL_ADDRESS>wrote:
This is for the the velocity tutorial, I just took on of the samples:

kallisto bus -i cDNA_introns.idx -o bus_output_06/ -x 10xv2 -t 4
06/10X_17_029_MissingLibrary_1_HL73JBCXY/bamtofastq_S1_L002_R1_001.fastq.gz
06/10X_17_029_MissingLibrary_1_HL73JBCXY/bamtofastq_S1_L002_R2_001.fastq.gz

bustools correct -w ../../10xv2_whitelist.txt -p output.bus | bustools sort
-o output.correct.sort.bus -t 4 -

Is this the information you need? I just followed the steps in the tutorial.
Thanks for helping with this.
On July 26, 2019 at 1:10:45 AM, Eduardo Beltrame<EMAIL_ADDRESS>wrote:
How did you generate this bus file? I converted the 2.6GB bus file you
provided into text to inspect it and it expanded to 205GB.
Each entry that should correspond to a UMI has a length of 2573
charachters, and it repeats every 32 characters. I have attached the first
5 lines of the file for you to understand.
If you can provide the detailed steps you used to generate this file we can
look further into the issue.
nuclear_rna_first_5_lines.txt
https://github.com/BUStools/bustools/files/3434254/nuclear_rna_first_5_lines.txt
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/BUStools/bustools/issues/11?email_source=notifications&email_token=AAML6HHNZUSIGRUK2DXKBALQBKBNLA5CNFSM4IFLDGN2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD23QNCI#issuecomment-515311241,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAML6HAZCKJOS4D5TBC546TQBKBNLANCNFSM4IFLDGNQ
.

Yes you can convert it to text by doing bustools text -o bus_output_filename.txt bus_input_file.bus
On Fri, 26 Jul 2019 at 06:07, Lorena Pantano<EMAIL_ADDRESS>wrote:

The fastq files were done by:

bamtofastq --reads-per-fastq=500000000 10X_17_029.bam ./06

Can I convert the BUS file to text? I have my sample as well and I could
see if that happens with my sample as well. Or I can give it to your.
Thanks
On July 26, 2019 at 9:00:29 AM, Lorena Pantano<EMAIL_ADDRESS>wrote:
This is for the the velocity tutorial, I just took on of the samples:

kallisto bus -i cDNA_introns.idx -o bus_output_06/ -x 10xv2 -t 4
06/10X_17_029_MissingLibrary_1_HL73JBCXY/bamtofastq_S1_L002_R1_001.fastq.gz
06/10X_17_029_MissingLibrary_1_HL73JBCXY/bamtofastq_S1_L002_R2_001.fastq.gz

bustools correct -w ../../10xv2_whitelist.txt -p output.bus | bustools sort
-o output.correct.sort.bus -t 4 -

Is this the information you need? I just followed the steps in the
tutorial.
Thanks for helping with this.
On July 26, 2019 at 1:10:45 AM, Eduardo Beltrame<EMAIL_ADDRESS>)
wrote:
How did you generate this bus file? I converted the 2.6GB bus file you
provided into text to inspect it and it expanded to 205GB.
Each entry that should correspond to a UMI has a length of 2573
charachters, and it repeats every 32 characters. I have attached the first
5 lines of the file for you to understand.
If you can provide the detailed steps you used to generate this file we can
look further into the issue.
nuclear_rna_first_5_lines.txt
<
https://github.com/BUStools/bustools/files/3434254/nuclear_rna_first_5_lines.txt

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<
https://github.com/BUStools/bustools/issues/11?email_source=notifications&email_token=AAML6HHNZUSIGRUK2DXKBALQBKBNLA5CNFSM4IFLDGN2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD23QNCI#issuecomment-515311241

,
or mute the thread
<
https://github.com/notifications/unsubscribe-auth/AAML6HAZCKJOS4D5TBC546TQBKBNLANCNFSM4IFLDGNQ

.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/BUStools/bustools/issues/11?email_source=notifications&email_token=AC7MY4GLJ364NNXCRVAZGV3QBLZH7A5CNFSM4IFLDGN2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD24QZHQ#issuecomment-515443870,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AC7MY4FGUUXK7SSKSJUVNUTQBLZH7ANCNFSM4IFLDGNQ
.

yes, the bus file from my sample looks the same than that. Used the same command I posted before to produce the bus file, with kallisto.

Ok, can you confirm that the fastq files you generated using
bamtofastq  look correct? If you can paste here the output of head it
would be good.
If the fastqs look correct then it might have been an issue with the files
given to kallisto, if you can also post the commands you use to call
kallisto bus and the files used that might solve the mystery
On Fri, 26 Jul 2019 at 10:57, Lorena Pantano<EMAIL_ADDRESS>wrote:

yes, the bus file from my sample looks the same than that. Used the same
command I posted before to produce the bus file, with kallisto.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/BUStools/bustools/issues/11?email_source=notifications&email_token=AC7MY4F7TQT46GJOG52FOSTQBM3H7A5CNFSM4IFLDGN2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD25JQGI#issuecomment-515545113,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AC7MY4CBIETH6LOXRGEKXA3QBM3H7ANCNFSM4IFLDGNQ
.

Sure.
These are the commands to create the bus file from the bam files:
bamtofastq --reads-per-fastq=500000000 10X_17_029.bam ./06

kallisto bus -i cDNA_introns.idx -o bus_output_06/ -x 10xv2 -t 4 06/10X_17_029_MissingLibrary_1_HL73JBCXY/bamtofastq_S1_L002_R1_001.fastq.gz 06/10X_17_029_MissingLibrary_1_HL73JBCXY/bamtofastq_S1_L002_R2_001.fastq.gz

bustools correct -w ../../10xv2_whitelist.txt -p output.bus | bustools sort -o output.correct.sort.bus -t 4 -

The other sample I have  is not generated with bamtofastq, they were generated with cellranger mkfasta and the bus file is the same.
R1:
@D00456:228:HL73JBCXY:2:1111:15821:53600 1:N:0:0
CTAGCCCTAACCCTAACCCTAACCCT
+
.GAGA<GGGGAGGGGGGGGAAA.A<G
@D00456:228:HL73JBCXY:2:1213:6403:92501 1:N:0:0
AACCCTAACCCTAACCCTAACCCTAA
+
GGGGAGGGGGAGGAGGGGGG..AGAG
@D00456:228:HL73JBCXY:2:2106:9266:5974 1:N:0:0
ACGTCAAAGCAGCCTCCACAATGTGG

R2:
@D00456:228:HL73JBCXY:2:1111:15821:53600 3:N:0:0
GGGTTAGGGTTAGGGTTAGGGTTAGGGTTAGGGCTAGGGTTAGGGTTAGGGTTAGGGTTAGGGTTAGGGTTGGGGATAGGGTTCGGTCTAGGGATAGG
+
AGGAAA..GG.<<.G<A.G<G..<G<G<GAGG..<AGAG<..<<A..<<GG.<<GGA<..<<<..<...<..<<.<<AA...<...<.<...<<....
@D00456:228:HL73JBCXY:2:1213:6403:92501 3:N:0:0
GGTTAGGGTTAGGGTTAGGGGTTAGGGTTAGGGTTAGGGTTAGGGTTAGGGTTAGGGTTAGGGTTAGGAGTAGGGATGGGGAGCGGGGAGGGGAGAGG
+
GA<G.AAA<GGGAG<AAGGGI<..<GGGGGAAAG..<.<.<.<AGAG.GGG.<.GAG..G<<<...<<....<<......<.<.<.......<..<..
@D00456:228:HL73JBCXY:2:2106:9266:5974 3:N:0:0
GCTAAGAGACAGCAAATACACATGAACAGAAAGAAGAGGTCAAAGAAAAGGCTGACGGCAAGTTAACGAAAAGAAAAATGGTGAATGATACCCGGTGC

In a last note, the velocity tutorial works if I use bustools capture and bustools count to get the two type of matrices. This is only happening when I want just to do bustools count with the matrix.ec file firectly since I want to quantify all reads into  genes. (https://www.kallistobus.tools/velocity_tutorial.html)
thanks!

Thanks, this all looks good. One last question - are you by any chance
running this on a 32 bit machine?
On Fri, Jul 26, 2019, 13:16 Lorena Pantano<EMAIL_ADDRESS>wrote:

Sure.
These are the commands to create the bus file from the bam files:
bamtofastq --reads-per-fastq=500000000 10X_17_029.bam ./06
kallisto bus -i cDNA_introns.idx -o bus_output_06/ -x 10xv2 -t 4 06/10X_17_029_MissingLibrary_1_HL73JBCXY/bamtofastq_S1_L002_R1_001.fastq.gz 06/10X_17_029_MissingLibrary_1_HL73JBCXY/bamtofastq_S1_L002_R2_001.fastq.gz
bustools correct -w ../../10xv2_whitelist.txt -p output.bus | bustools sort -o output.correct.sort.bus -t 4 -
The other sample I have is not generated with bamtofastq, they were
generated with cellranger mkfasta and the bus file is the same.
R1:
@D00456:228:HL73JBCXY:2:1111:15821:53600 1:N:0:0
CTAGCCCTAACCCTAACCCTAACCCT
+
.GAGA<GGGGAGGGGGGGGAAA.A<G
@D00456:228:HL73JBCXY:2:1213:6403:92501 1:N:0:0
AACCCTAACCCTAACCCTAACCCTAA
+
GGGGAGGGGGAGGAGGGGGG..AGAG
@D00456:228:HL73JBCXY:2:2106:9266:5974 1:N:0:0
ACGTCAAAGCAGCCTCCACAATGTGG
R2:
@D00456:228:HL73JBCXY:2:1111:15821:53600 3:N:0:0
GGGTTAGGGTTAGGGTTAGGGTTAGGGTTAGGGCTAGGGTTAGGGTTAGGGTTAGGGTTAGGGTTAGGGTTGGGGATAGGGTTCGGTCTAGGGATAGG
+
AGGAAA..GG.<<.G<A.G<G..<G<G<GAGG..<AGAG<..<<A..<<GG.<<GGA<..<<<..<...<..<<.<<AA...<...<.<...<<....
@D00456:228:HL73JBCXY:2:1213:6403:92501 3:N:0:0
GGTTAGGGTTAGGGTTAGGGGTTAGGGTTAGGGTTAGGGTTAGGGTTAGGGTTAGGGTTAGGGTTAGGAGTAGGGATGGGGAGCGGGGAGGGGAGAGG
+
GA<G.AAA<GGGAG<AAGGGI<..<GGGGGAAAG..<.<.<.<AGAG.GGG.<.GAG..G<<<...<<....<<......<.<.<.......<..<..
@D00456:228:HL73JBCXY:2:2106:9266:5974 3:N:0:0
GCTAAGAGACAGCAAATACACATGAACAGAAAGAAGAGGTCAAAGAAAAGGCTGACGGCAAGTTAACGAAAAGAAAAATGGTGAATGATACCCGGTGC
In a last note, the velocity tutorial works if I use bustools capture and bustools
count to get the two type of matrices. This is only happening when I want
just to do bustools count with the matrix.ec file firectly since I want
to quantify all reads into genes. (
https://www.kallistobus.tools/velocity_tutorial.html)
thanks!
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/BUStools/bustools/issues/11?email_source=notifications&email_token=AC7MY4BGCD4VK3OFTQIRICLQBNLRDA5CNFSM4IFLDGN2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD25TMEY#issuecomment-515585555,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AC7MY4EK3CRRD5ULBB7ELXDQBNLRDANCNFSM4IFLDGNQ
.

thank you for confirming.
nope, 64 linux machines.
thanks!

Ok we're very puzzled as to how the bus file with the 2573 characters in the UMI have been made, and ran out of ideas.
Can you subsample 100k reads from R1 and R2 so that we can try to reproduce the problematic bus file? seqtk is an easy way to subsample them: https://github.com/lh3/seqtk

Thanks. I’ll do that on Monday.
I checked the BUS file from kallisto and looks like this:
CTGTTTACATACGCTA        TAATAAGGAA      1746067 1
CTTAACTAGCTCTCGG        ATCGTCCTGG      1746067 1
CTTTGCGAGCGATGAC        TCCAGGGTGA      1746067 1
CTTTGCGGTACTCGCG        TTAAATCGTG      1746067 1
CTTTGCGGTGTTCGAT        CCCGCACGGT      1746067 1
CTTTGCGGTGTTCGAT        CCCGCACGGT      1746067 1
GAAGCAGAGGCTCATT        TGTTTTGCAC      1746067 1
GAAGCAGAGGCTCATT        GTCTTTGATG      1746067 1
GAATGAACATGCTAGT        AAATGAACAA      1746067 1
GACAGAGCAATCGAAA        CACGGATGTC      1746067 1
But after bustools correct and sort it looks like this (it seems the
problem is the correct | sort step):
AAAAAAAAAAAAAAAA
AAAACAAAAACCAAAAAAAAAAAAAAAAAAAAAAAACAAAAACCAAAAAAAAAAAAAAAAAAAAAAAACAAAAACCAAAAAAAAAAAAAAAAAAAAAAAACAAAAACCAAAAAAAAAAAAAAAAAAAAAAAACAAAAACCAAAAAAAAAAAAAAAAAAAAAAAACAAAAACCAAAAAAAA
AAAAAAAAAAAAAAAACAAAAACCAAAAAAAAAAAAAAAAAAAAAAAACAAAAACCAAAAAAAAAAAAAAAAAAAAAAAACAAAAACCAAAAAAAAAAAAAAAAAAAAAAAACAAAAACCAAAAAAAAAAAAAAAAAAAAAAAACAAAAACCAAAAAAAAAAAAAAAAAAAAAAAACAAAAACCAAAAAAAAAAAAAAAAAAAA
AAAACAAAAACCAAAAAAAAAAAAAAAAAAAAAAAACAAAAACCAAAAAAAAAAAAAAAAAAAAAAAACAAAAACCAAAAAAAAAAAAAAAAAAAAAAAACAAAAACCAAAAAAAAAAAAAAAAAAAAAAAACAAAAACCAAAAAAAAAAAAAAAAAAAAAAAACAAAAACCAAAAAAAAAAAAAAAAAAAAAAAACAAAAACC
AAAAAAAAAAAAAAAAAAAAAAAACAAAAACCAAAAAAAAAAAAAAAAAAAAAAAACAAAAACCAAAAAAAAAAAAAAAAAAAAAAAACAAAAACCAAAAAAAAAAAAAAAAAAAAAAAACAAAAACCAAAAAAAAAAAAAAAAAAAAAAAACAAAAACCAAAAAAAAAAAAAAAAAAAAAAAACAAAAACCAAAAAAAAAAAA
AAAAAAAAAAAACAAAAACCAAAAAAAAAAAAAAAAAAAAAAAACAAAAACCAAAAAAAAAAAAAAAAAAAAAAAACAAAAACCAAAAAAAAAAAAAAAAAAAAAAAACAAAAACCAAAAAAAAAAAAAAAAAAAAAAAACAAAAACCAAAAAAAAAAAAAAAAAAAAAAAACAAAAACCAAAAAAAAAAAAAAAAAAAAAAAA
CAAAAACCAAAAAAAAAAAAAAAAAAAAAAAACAAAAACCAAAAAAAAAAAAAAAAAAAAAAAACAAAAACCAAAAAAAAAAAAAAAAAAAAAAAACAAAAACCAAAAAAAAAAAAAAAAAAAAAAAACAAAAACCAAAAAAAAAAAAAAAAAAAAAAAACAAAAACCAAAAAAAAAAAAAAAAAAAAAAAACAAAAACCAAAA
AAAAAAAAAAAAAAAAAAAACAAAAACCAAAAAAAAAAAAAAAAAAAAAAAACAAAAACCAAAAAAAAAAAAAAAAAAAAAAAACAAAAACCAAAAAAAAAAAAAAAAAAAAAAAACAAAAACCAAAAAAAAAAAAAAAAAAAAAAAACAAAAACCAAAAAAAAAAAAAAAAAAAAAAAACAAAAACCAAAAAAAAAAAAAAAA
AAAAAAAACAAAAACCAAAAAAAAAAAAAAAAAAAAAAAACAAAAACCAAAAAAAAAAAAAAAAAAAAAAAACAAAAACCAAAAAAAAAAAAAAAAAAAAAAAACAAAAACCAAAAAAAAAAAAAAAAAAAAAAAACAAAAACCAAAAAAAAAAAAAAAAAAAAAAAACAAAAACCAAAAAAAAAAAAAAAAAAAAAAAACAAA
AACCAAAAAAAAAAAAAAAAAAAAAAAACAAAAACCAAAAAAAAAAAAAAAAAAAAAAAACAAAAACCAAAAAAAAAAAAAAAAAAAAAAAACAAAAACCAAAAAAAAAAAAAAAAAAAAAAAACAAAAACCAAAAAAAAAAAAAAAAAAAAAAAACAAAAACCAAAAAAAAAAAAAAAAAAAAAAAACAAAAACCAAAAAAAA
AAAAAAAAAAAAAAAACAAAAACCAAAAAAAAAAAAAAAAAAAAAAAACAAAAACCAAAAAAAAAAAAAAAAAAAAAAAACAAAAACCAAAAAAAAAAAAAAAAAAAAAAAACAAAAACCAAAAAAAAAAAAAAAAAAAAAAAACAAAAACCAAAAAAAAAAAAAAAAAAAAAAAACAAAAACCAAAAAAAAAAAAAAAAAAAA
AAAACAAAAACCAAAAAAAAAAAAAAAAAAAAAAAACAAAAACCAAAAAAAAAAAAAAAAAAAAAAAACAAAAACCAAAAAAAAAAAAAAAAAAAAAAAACAAAAACCAAAAAAAAAAAAAAAAAAAAAAAACAAAAACCAAAAAAAAAAAAAAAAAAAAAAAACAAAAACCAAAAAAAAAAAAAAAAAAAAAAAACAAAAACC
AAAAAAAAAAAAAAAAAAAAAAAACAAAAACCAAAAAAAAAAAAAAAAAAAAAAAACAAAAACCAAAAAAAAAAAAAAAAAAAAAAAACAAAAACCAAAAAAAAAAAAAAAAAAAAAAAACAAAAACCAAAAAAAAAAAAAAAAAAAAAAAACAAAAACCAAAAAAAAAAAAAAAAAAAAAAAACAAAAACCAAAAAAAAAAAA
AAAAAAAAAAAACAAAAACCAAAAAAAAAAAAAAAAAAAAAAAACAAAAACCAAAAAAAAAAAAAAAAAAAAAAAACAAAAACCAAAAAAAAAAAAAAAAAAAAAAAACAAAAACCAAAAAAAAAAAAAAAAAAAAAAAACAAAAACCA
0<PHONE_NUMBER>

Hi,
I uploaded the BUS file before sorting and correction that it seems right. Do you still want the FASTQ files?
https://lpantano-debug.s3.amazonaws.com/bustools/output.bus
As I posted last week, the weird bus appears after the correct command.
Thanks!


Do not flag vouched profiles as akismet spam.

Remove Abuse Reports for vouched profiles.

Coverage decreased (-0.09%) to 89.594% when pulling 9b97a87fd6ba877137ad9c5fe37d928d2fafb837 on akatsoulas:akismet-vouched into e49cfe94f07a7f365a1d4edf1272f2260245fc65 on mozilla:master.


Other light types

Hi guys,
me and my dev. team would love to have additional types of light
For example cylinder light or area light would be nice to have.
Is there any plans to implement that?
best,
Flo

Feature and improvement proposals for the Godot Engine are now being discussed and reviewed in a dedicated Godot Improvement Proposals (GIP) (godotengine/godot-proposals) issue tracker. The GIP tracker has a detailed issue template designed so that proposals include all the relevant information to start a productive discussion and help the community assess the validity of the proposal for the engine.
The main (godotengine/godot) tracker is now solely dedicated to bug reports and Pull Requests, enabling contributors to have a better focus on bug fixing work. Therefore, we are now closing all older feature proposals on the main issue tracker.
If you are interested in this feature proposal, please open a new proposal on the GIP tracker following the given issue template (after checking that it doesn't exist already). Be sure to reference this closed issue if it includes any relevant discussion (which you are also encouraged to summarize in the new proposal). Thanks in advance!


Write NXroot attributes

Fixes #163.
This allows the Template to now accept NXroot level NXobjects. I have made a test with /@default.
Note: This makes the undocmuented warning test do nothing.

We should also add the standard NXroot attributes here:

[ ] file_time
[ ] file_name
[ ] file_update_time
[ ] NeXus_version (related to #162, so we should maybe add it there)
[ ] HDF_version
[ ] HDF5_Version
[ ] XML_version
[ ] h5py_version
~[X] creator~ (We actually have something in entry for NXmpes - maybe we leave this out as this is not pynxtools specific?)
~[X] creator_version~

[x]  file_time
[x]  file_name
[x]  file_update_time
[x]  HDF5_Version
[x]  h5py_version

I'll add NeXus_version once you're stable with #162

[ ]  NeXus_version (related to Add versioning for nexus_definitions #162, so we should maybe add it there)

These don't work for us. The first is the hdf4 version. And we don't write any XML here.

[ ]  HDF_version
[ ]  XML_version

This works fine for me, however I get undocumented field warnings when I execute this on my example files:
❯ dataconverter --reader mpes --nxdl NXmpes --input-file MoTe2.h5 --input-file config_file.json --output MoTe2.mpes.nxs --undocumented
Using mpes reader to convert the given files:
• MoTe2.h5
• config_file.json
The path, /@NX_class, is being written but has no documentation.
The path, /@file_name, is being written but has no documentation.
The path, /@file_time, is being written but has no documentation.
The path, /@file_update_time, is being written but has no documentation.
The path, /@NeXus_version, is being written but has no documentation.
The path, /@HDF5_version, is being written but has no documentation.
The path, /@h5py_version, is being written but has no documentation.
The output file generated: MoTe2.mpes.nxs

Interestingly, I don't get an undocumented warning for @partial if I add it to NXroot...

This works fine for me, however I get undocumented field warnings when I execute this on my example files:
❯ dataconverter --reader mpes --nxdl NXmpes --input-file MoTe2.h5 --input-file config_file.json --output MoTe2.mpes.nxs --undocumented
Using mpes reader to convert the given files:
• MoTe2.h5
• config_file.json
The path, /@NX_class, is being written but has no documentation.
The path, /@file_name, is being written but has no documentation.
The path, /@file_time, is being written but has no documentation.
The path, /@file_update_time, is being written but has no documentation.
The path, /@NeXus_version, is being written but has no documentation.
The path, /@HDF5_version, is being written but has no documentation.
The path, /@h5py_version, is being written but has no documentation.
The output file generated: MoTe2.mpes.nxs

Interestingly, I don't get an undocumented warning for @partial if I add it to NXroot...

The NXroot objects are not added during Template generation. This means when I add them, they get added to the undocumented part of the Template. I don't want to re-run them and figure out their validity. It's too expensive. Here, we know that the code is producing them correctly anyways. So I just skip over those checks.


Azure Storage Explorer crashing when tried to expand blob container list under a storage account.

Preflight Checklist

[X] I have installed the latest version of Storage Explorer.
[X] I have checked existing resources, including the troubleshooting guide and the release notes.
[X] I have searched for similar issues.

Storage Explorer Version
1.29.2
Regression From
No response
Architecture
x64
Storage Explorer Build Number
No response
Platform
macOS
OS Version
macOS High Sierra
Bug Description
Azure Storage Explorer is crashing when tried to expand the blob container tree for a given storage account entry.
Tried reset, re-install etc, but issue persists.
Steps to Reproduce

Launch Storage Explorer
Sign in with Azure
Browser login is successful and subscription details are updated
Select the subscription -> Storage Account -> Blob Containers
A loader appears for a brief time, and then application crashes

Actual Experience

Launch Storage Explorer
Sign in with Azure
Browser login is successful and subscription details are updated
Select the subscription -> Storage Account -> Blob Containers
A loader appears for a brief time, and then application crashes

Expected Experience

Launch Storage Explorer
Sign in with Azure
Browser login is successful and subscription details are updated
Select the subscription -> Storage Account -> Blob Containers
Blob containers under the storage account is listed and user is able to select one blob container and list blobs.

Additional Context
No response

We haven't been developing and testing against High Sierra for a long time since it stops receiving any update since 2020. If possible, I highly recommend you to upgrade the OS.

Thanks @JasonYeMSFT for the quick response.
I understand that High Sierra is pretty old, but some business apps I have is restricting me to update. I will definitely try to update the OS and check if that works.
Meanwhile, this is the crash message I see in logs:
Symbol not found: _objc_opt_class Referenced from: /private/var/folders/*/Microsoft Azure Storage<EMAIL_ADDRESS>(which was built for Mac OS X 10.15) Expected in: /usr/lib/libobjc.A.dylib

I see. It's a native module that has been upgraded to newer system APIs. It's actually for some non-critical features. We can consider making it optional so it won't block the rest of the application.

I created two private builds that attempt to catch the dependency errors. The feature depending on the module won't work but at least the application shouldn't crash. Other than that, they are identical to what we shipped in 1.30.0. I don't have a High Sierra machine to test it. You can try it and let us know if it works. If the workaround works, we'll check in it for all our future releases.
mac arm64
mac x64

Thank you for your support.
I tried the x64 version of the private build, and unfortunately, the crash remains. Error log below:
Symbol not found: _objc_opt_class

Referenced from: /Applications/Microsoft Azure Storage<EMAIL_ADDRESS>(which was built for Mac OS X 10.15)

Expected in: /usr/lib/libobjc.A.dylib

I did more investigation and found that at some point the default compiler config has changed to target 10.15 as the minimum macOS version. I saw people saying they successfully forced targeting a lower version of macOS and things are still working. I did the same thing and get the following two builds. It would be great if you still have time to try it out and help see if it mitigates the problem.
mac arm64
mac x64

Thanks. I installed the x64 build for downgraded macOS version. But, this time I get a different error when I try to view the contents under a storage container. It doesn't list Blob container type, and at that time it also shows a message "ERR_IPC_CHANNEL_CLOSED - Channel closed".

The new error is a Node error. I just found this "Prebuilt binaries for macOS now require macOS 10.15 or later" in the NodeJS v18 change log. https://github.com/nodejs/node/blob/main/doc/changelogs/CHANGELOG_V18.md
Our 1.30.0 uses Electron 24 which bundles NodeJS 18 https://www.electronjs.org/blog/electron-24-0. I am afraid there is no way we can fix this problem in our future releases since Node out of our control. Our latest release without using an Electron bundling Node 18 is 1.28.x. You may install an older version of Storage Explorer and it probably would work. We have all prior releases available here https://github.com/microsoft/AzureStorageExplorer/releases

Thanks again for your inputs. I tried the 1.27.2 version (December 2022), and it works fine.
I appreciate your help on this.


Fix no-shadow eslint warning & remove var

Fixes no-shadow warning for local-cli/link/ios/getGroup.js  and remove var declaration keyword.
react-native/local-cli/link/ios/getGroup.js
  13:23  warning  'group' is already declared in the upper scope  no-shadow

Test Plan:

[x] Check npm run flow
[x] Check npm run flow-check-ios
[x] Check npm run flow-check-android
[x] Check npm run lint

Changelog:
[GENERAL] [ENHANCEMENT] [eslint] - Fix eslint no-shadow warning

@turnrye
Thanks for reply to me. I understand that, so I close this PR and take a issue #22100


Checking if there is a collider when calling SoftBody::remove_collision_exception_with

fixes #46651

Thanks!

Cherry-picked for 3.2.4.


Add bin folder to linting

Hello all!
Sorry for being inactive the last few months.
bin folder was not being included with the eslint . command (I think because files aren't .js)

@alopezsanchez thanks for catching this, and welcome back :)


Fix yamllint fatal errors.

Add a more useful error when the requested yamllint config file doesn't exist.

Codecov Report

Merging #215 into master will increase coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #215      +/-   ##
==========================================
+ Coverage   89.62%   89.64%   +0.02%
==========================================
  Files          41       41
  Lines        2275     2280       +5
==========================================
+ Hits         2039     2044       +5
  Misses        236      236

Impacted Files
Coverage Δ

lintreview/tools/yamllint.py
96.77% <100%> (+0.62%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24b7cdf...3b3a991. Read the comment docs.


HTML

HTML
User Story
As a bootcamp student
I want the prework notes to be structured on a webpage
so that I can easily find and read information
Acceptance Criteria
GIVEN a prework study guide website
WHEN I visit the website in my browser
THEN I see four boxes titled Html, CSS, Git And JavaScript with associated notes listed

HTML code is added


change "cash out" to another term

cash out meaning (source) -> to convert (noncash assets) to cash. How to use cash out in a sentence.
You can find it in BBcashoutWallet.sh and 99lightningMenu.sh
Another term because Im open to suggestions to rewrite those files:

withdrawal (source) -> removal from a place of deposit or investment
other

I think "Withdraw All Funds" is the the basic idea of this feature. Would that work as a replacement?

ACK
In c-lightning the command is literally:
lightning-cli withdraw [address] all

This was alrteady fixed in previous releaes. Closing issue.


Add 'Import' 'Export' Buttons to the UI

As an ECMPS user, I want 'Import a MP' and 'Export MP' buttons on the individual configurations tab so that I know where to look for the functionality once it is implemented
Acceptance Criteria
Given I am an ECMPS user
When I select and checkout a Configuration (Active MP's)
Then I see Export and Import a MP buttons on the individual Configurations tab
Notes:

Hide the Export and Import buttons when the MP is not checked out
Import/Export buttons won't show up for Inactive/Retired MP's

Test Case: TC603

Test Passed


Linear programming solver

Suggestion
Recently I've been trying to model a mid-game SeaBlock factory in Factory Planner. With too many circular dependencies between the recipes, both traditional and matrix solvers were basically broken. What I am wondering is whether it would be possible to overcome these problems by using a linear programming optimization algorithm, like Simplex method.
The overall logic would be as follows:

Introduce variables $x_i \ge 0$ for each recipe that denote the number of buildings executing each recipe.
Calculate $y_j$ — the number of items of each type produced per unit of time. These are expressed as linear functions of $x_i$: $y = Ax$.
Define the constraints $y_j \ge p_j$ for the ultimate products that the user would like to produce and $y_j \ge 0$ for all other intermediate products.
Calculate the required energy $e = Ex$, which is also a linear function of $x_i$.
Minimize $e$ (possibly in combination with some other values), subject to constraints on $x_i$ and $y_j$.

This looks like a typical linear programming problem, which could be solved by any method of solving linear programming problems. The advantages of this compared to just solving a system of linear equations is that this way we are able to correctly handle several different recipes producing the same products as well as any other cases which result in linear dependencies in the system.
As an additional benefit, it is possible to give user a choice which byproducts they want to allow. Just change some of the constraints on $y_j$ from inequalities $y_j \ge 0$ to $y_j = 0$.
It looks like there's at least one usable implementation of Simplex algorithm in Lua here: https://github.com/geoffleyland/luasimplex.

Hello, sorry for not getting back to your well thought-out post earlier. I'm pretty out of my depth when it comes to this topic, but I will try and wade into the topic when I tackle a solver rewrite that is upcoming one of these days. I'll keep this suggestion in mind!

After I wrote this proposal, I had a look at a couple of other tools and it looks like Helmod and https://factoriolab.github.io/ are already doing this.


Cant speak again after closing phone

Describe the bug
I can speak with my friends before we talk on phone. After we close the phone we cant talk anymore. We can use radio or phone again. But cant hear each other normally.
To Reproduce
Steps to reproduce the behavior:
Start call with phone.
Talk in phone.
Close phone.
Server Info:
Server Version: 5049
Client Version: Canary
Client Build: b2372
Server Settings:
setr voice_useNativeAudio true
setr voice_useSendingRangeOnly true
setr voice_defaultCycle "H"
setr voice_defaultVolume 0.4
setr voice_enableRadioAnim 1
setr voice_syncData 1
setr voice_enableSubmix 1
setr voice_enableUi 1
setr voice_defaultRadio "CAPITAL"

Additional context
Im using addPlayerToCall(callId) function to start call and removePlayerFromCall function to end it. I tried setRadioChannel(0) also. But none of them are working. If i try to restart pma-voice or phone its not event fixing. We have to relog to the game.
I also tried Client build 2060, 2189 but same.

I can't replicate this. Can you provide some of the code you use to create/delete calls?

Sure.
My server (Im triggering a client event for both players to set them in same call with id) ;
id = custom call identifier,
transmitter_src and receiver_src = players server id's
            TriggerClientEvent('auraPhone_setCallInfo', tonumber(transmitter_src), id, true)
            TriggerClientEvent('auraPhone_setCallInfo', tonumber(receiver_src), id, true)

My client :
RegisterNetEvent('auraPhone_setCallInfo')
AddEventHandler('auraPhone_setCallInfo', function(callId, callActive)
  if (callActive) then
    exports["pma-voice"]:setCallChannel(tonumber(callId))
  else
    exports["pma-voice"]:removePlayerFromCall()
  end
end)

I hope this is enough. I think I sent the necessary parts. If u need more i can send more.

I tried many things to solve it. None of them worked. Except - if i use vsync command its fixing. Idk why

I can't replicate this, my only guess is something is using one of these natives


Cannot add Apple private key to Social Signin settings

Preflight checklist

[X] I could not find a solution in the existing issues, docs, nor discussions.
[X] I agree to follow this project's Code of Conduct.
[X] I have read and am following this repository's Contribution Guidelines.
[X] This issue affects my Ory Network project.
[X] I have joined the Ory Community Slack.
[X] I am signed up to the Ory Security Patch Newsletter.

Describe the bug
Cannot add Apple private key to project social sign in settings.
The console reports failed to decode PEM block containing private key when adding the private key. Tried using base64 as well, however, it results in the same error.
Reproducing the bug

Add Apple private Key to social sign in settings
Receive error

Relevant log output
No response
Relevant configuration
No response
Version
latest
On which operating system are you observing this issue?
Ory Network
In which environment are you deploying?
Ory Network
Additional Context
See this slack thread https://ory-community.slack.com/archives/C02MR4DEEGH/p1666079900320609

does this work via CLI?

Is this still an issue @Benehiko ?

@aeneasr I can confirm this is still happening, I was about to post the same issue. If you copy paste the value from the downloaded Apple private key into the field on the Ory Network website, the spacing is parsed in a weird way. It looks like the following when getting the info with ory get identity-config --format yaml (notice the spaces instead of new lines):
- apple_private_key: -----BEGIN PRIVATE KEY------ MIGTXXXXXXX XXXXXX XXXXXX -----END PRIVATE KEY------

I tried adding the newline characters manually (\n), but it seems they get escaped:
- apple_private_key: -----BEGIN PRIVATE KEY------\\nMIGTXXXXXXX\\nXXXXXX\\nXXXXXX\\n-----END PRIVATE KEY------

The only way I could get this to work was to add the multiline private key on a YAML file and then ory update identity-config --file config.yaml:
- apple_private_key: |
  -----BEGIN PRIVATE KEY------
  MIGTXXXXXXX
  XXXXXX
  XXXXXX
  -----END PRIVATE KEY------

Maybe the fix is to have this field as a textbox instead of a regular text input?

Thanks, I'll add it to our bug squash week!


Self-signed Certificates

https://github.com/SalesforceCommerceCloud/sfcc-ci/blob/1199c9d1ca67ba2f27d2517b7ec4647bd1667594/lib/webdav.js#L37
Shouldn't this be configurable in the command line interface not just via dw.json
I noticed there is a --selfsigned option but it is ignored.
My understanding is that we should be generating the client certificate and signing it with the key provided by Salesforce rather than using the master certificate provided by SFCC even if it is for CI/CD.
https://documentation.b2c.commercecloud.salesforce.com/DOC1/topic/com.demandware.dochelp/content/b2c_commerce/topics/site_development/b2c_creating_and_using_certificates_for_code_deployment.html

Hi, thanks for raising this. I don't see a reason, why it should only be supported via dw.json. It should be supported via global flag --selfsigned. Do you mind submitting a PR for this?


Reflection rabbit hole

Type of change

Refactoring

Description
Code cleanup around the use of reflection when preparing log dirs
Additional Context
I felt there was a lot of boilerplate code prepareLogDirsForKraftKafka39Plus which obscured what as actually being done. I thought it was possible to simplify things a bit by extracting a method but things got a bit more complicated.
So I'm not convinced this makes things easier to read or not and even if it does is it worth the extra code? I thought it was easier to have that discussion on an additional PR than as comments on the original. I'm happy to drop and delete this if thats the consensus.
Checklist
Please go through this checklist and make sure all applicable tasks have been done

[ ] Write tests
[ ] Make sure all tests pass
[ ] Update documentation
[ ] Reference relevant issue(s) and close them after merging
[ ] Update CHANGELOG.md

Argh this isn't the branch I wanted to merge into.


Node embedding different for same node

in this tutorial :https://stellargraph.readthedocs.io/en/stable/demos/link-prediction/hinsage-link-prediction.html
If I get node embeddings by following something like :
embedding_model = Model(inputs=x_inp, outputs=x_out)
val = edges_with_ratings[edges_with_ratings.user_id=='u_196']
edgelist_val = list(val[["user_id", "movie_id"]].itertuples(index=False))
all_gen = generator.flow(edgelist_val, val['rating'])
emb = embedding_model.predict(all_gen,use_multiprocessing=True, workers=num_workers)

Now u_196 is a node and its connected with many movies. But iF i check embedding for every (user,movie) pair embedding for u_196 is not exactly same. Thats make downstream task impossible as I do not know what embedding to use
emb[0][0]
array([ 0.3213869 ,  0.25611138, -0.38079998, -0.00746157, -0.23814394,
        0.18461747,  0.2918616 ,  0.32481527, -0.30230615,  0.19585507,
        0.1981392 , -0.03057511,  0.22576441, -0.13359581,  0.04727396,
       -0.03564964, -0.08600467,  0.20336007, -0.03230249, -0.00419254,
        0.15747397, -0.06983346, -0.10123836, -0.03116873,  0.15447927,
        0.05499875,  0.06863956, -0.1226499 , -0.05789576, -0.06835074,
        0.13002032,  0.00476053], dtype=float32)

emb[0][1]
array([ 0.30661392,  0.2642709 , -0.38934013, -0.01778625, -0.25613168,
        0.15143536,  0.29685912,  0.35293475, -0.32115036,  0.19982944,
        0.20510991, -0.02760177,  0.25869012, -0.19137299, -0.00512443,
       -0.06650148, -0.0701935 ,  0.13300137, -0.02090699,  0.00691709,
        0.11819453, -0.05190783, -0.08681908, -0.00732615,  0.11060324,
        0.03119296,  0.05248987, -0.09362882, -0.02934983, -0.06471224,
        0.10930371,  0.00685294], dtype=float32)

Both embeddings are for u_196 .

Did you ever find a solution to this problem?

Did you ever find a solution to this problem?


Add public U2Net endpoint to README

As discussed in #44, this adds the public endpoint to the README with a thank you to the donor.
Fixes #44

LGTM, thanks @salanki !


Fix appveyor on master

Port several fixes of appveyor from revision to master.

It seems appveyor does not have pep8 installed anymore:

ModuleNotFoundError: No module named 'pep8'

:+1:


Add link to methods in yaml selector docs

Description & motivation

The docs on yaml selectors mention using method: value syntax, but it doesn't link out to the available methods. This adds that link so it's easier to find when looking through the docs.

@mirnawong1 - thank you for the suggestion! I made the commit and confirmed with the deploy preview that it works as intended. Can you please re-approve when you get a chance?


[adaptor] APIPolicy ref to InterceptorService kind changes

Purpose
$subject and added multiple interceptors entry support in APIPolicy CRD, only the first entry is read in both request and response interceptors paths.
Sample resources with updated configuration
apiVersion: dp.wso2.com/v1alpha1
kind: APIPolicy
metadata:
  name: sample-api-policy
  namespace: interceptor
spec:
  override:
    requestInterceptors:
    - name: interceptor-service-3
      namespace: interceptor
    responseInterceptors:
    - name: interceptor-service-4
      namespace: interceptor
  targetRef:
    group: gateway.networking.k8s.io
    kind: API
    name: interceptor-api
    namespace: interceptor
---
apiVersion: dp.wso2.com/v1alpha1
kind: InterceptorService
metadata:
  name: interceptor-service-3
  namespace: interceptor
spec:
  backendRef:
    name: interceptor-backend-2
  includes:
  - request_body
  - request_headers
  - request_trailers
  - invocation_context
---
apiVersion: dp.wso2.com/v1alpha1
kind: InterceptorService
metadata:
  name: interceptor-service-4
  namespace: interceptor
spec:
  backendRef:
    name: interceptor-backend-2
  includes:
  - response_headers
  - response_body

Tested
Gateway, API, Resource levels with the new changes

Codecov Report

:exclamation: No coverage uploaded for pull request base (feature/interceptor-ref@ce64989). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@                    Coverage Diff                     @@
##             feature/interceptor-ref    #1119   +/-   ##
==========================================================
  Coverage                           ?   79.18%
==========================================================
  Files                              ?       11
  Lines                              ?      591
  Branches                           ?      258
==========================================================
  Hits                               ?      468
  Misses                             ?      123
  Partials                           ?        0

Flag
Coverage Δ

idp-domain-service
79.18% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.4 out of 5 committers have signed the CLA.:white_check_mark: tharindu1st:white_check_mark: Krishanx92:white_check_mark: Amila-Rukshan:white_check_mark: CrowleyRajapakse:x: wso2-jenkins-botwso2-jenkins-bot seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


either: add a split_err method

Thanks! I was wondering, though, should this incorporate Result into the return value as well?

Maybe split_err isn't so interesting a name as Either doesn't exactly deal in errors and results. Maybe split_b (adding a new split_a for the existing method and deprecating it)?
If Result was wanted at the beginning, I'd rather select2 just make one itself rather than having special cases for Either.
It might be interesting to also have an impl<T> From<Either<T, T>> for T to help with the any collapsing.

Hrm, split_b also isn't good. Is there a problem with just calling it split also? Or does that need T != U assertions (is that possible?)?

Yeah unfortunately split can't work here due to how methods work in Rust, but something like split_a and split_b sounds pretty reasonable to me! I think we can't quite have that From impl as well but we could have an inherent method which does the conversion.

I used split_left and split_right since the A and B aren't really the same (it's taking the left side of each tuple possibility). I also added a collapse method for Either<T, T> -> T.

Sorry for the delay! My only hesitation with the left/right naming is that it doesn't scale beyond either-with-two-type-parameters. If we ever add Either3, for example, that may cause inconsistencies in naming?
I'm also not entirely thrilled with the name collapse but I can't think of a better name, so seems fine by me!

The Haskell names for (a, b) -> a and (a, b) -> b are fst and snd. The three-tuple variants are fst3, snd3, and thd3.
I don't think I've ever seen a meaningful wrapper around a 3-way Either, but split_center would work there.

My point though is that split_a and split_b I think have roughly the same connotation, and are also scalable to more variants if we ever add them?

I think it's ok to have the factored-out type on the far-left of the tuple (.0)

Ok I'm going to close this due to inactivity, but feel free to resubmit!

I've updated the source branch. Do you want to reopen this or is a separate PR preferred?

Yeah, it will. We can't add these methods to the external Either type. Maybe they can become free-standing functions instead?

If merged, could the methods be added to the either crate?

I don't know. There may be some more generic code for it. I'll open an issue over there.

See bluss/either#17

Looks like either is now a dependency. Let's see what happens on the either side.


Make a minimum blog archive page

List of dates with links to all articles, optional titles? no pagination?

stub is at /blog/archive/


CocoaLumberjack not available

Add the lumberjack files to your project.
2.Configure the framework.
2.1 Write in the test.pch files
#import "./CocoaLumberjack/Classes/CocoaLumberjack.h"
#import "./CocoaLumberjack/Classes/DDLegacyMacros.h"

#ifdef DEBUG
static const int ddLogLevel =LOG_LEVEL_VERBOSE;
#else
static const int ddLogLevel = LOG_LEVEL_OFF;
#endif
2.2 YGAppDelegate.m

(BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(NSDictionary *)launchOptions
{
[DDLog addLogger:[DDASLLogger sharedInstance]];
[DDLog addLogger:[DDTTYLogger sharedInstance]];
return YES;
}

(void)applicationWillResignActive:(UIApplication *)application
{
DDLogError(@"ok");
}
Compile the project .Report an error

Ld /Users/Jackson/Library/Developer/Xcode/DerivedData/testlog-ahnjaufjbbzpuicykofoftfdpque/Build/Products/Debug-iphonesimulator/testlog.app/testlog normal x86_64
cd /Users/Jackson/Desktop/oc/testlog
export IPHONEOS_DEPLOYMENT_TARGET=7.1
export PATH="/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/usr/bin:/Applications/Xcode.app/Contents/Developer/usr/bin:/usr/bin:/bin:/usr/sbin:/sbin"
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang -arch x86_64 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator8.1.sdk -L/Users/Jackson/Library/Developer/Xcode/DerivedData/testlog-ahnjaufjbbzpuicykofoftfdpque/Build/Products/Debug-iphonesimulator -L/Users/Jackson/Desktop/oc/testlog/testlog/CocoaLumberjack/Framework/Mobile/build/Debug-iphoneos -L/Users/Jackson/Desktop/oc/testlog -L/Users/Jackson/Desktop/oc/testlog/testlog/CocoaLumberjack/Framework/Mobile/Build/Debug-iphoneos -F/Users/Jackson/Library/Developer/Xcode/DerivedData/testlog-ahnjaufjbbzpuicykofoftfdpque/Build/Products/Debug-iphonesimulator -F/Users/Jackson/Desktop/oc/testlog/testlog/CocoaLumberjack/Framework/Desktop/build/Debug -F/Users/Jackson/Library/Developer/Xcode/DerivedData/Lumberjack-hagiutaowmyznjdswctloqoaktgh/Build/Products/Release -F/Users/Jackson/Library/Developer/Xcode/DerivedData/Lumberjack-dknsbwmeyhqxyugzaxspmmklmamb/Build/Products/Release -F/Users/Jackson/Desktop/oc/testlog/testlog/CocoaLumberjack/Framework/Desktop/Build/Debug -filelist /Users/Jackson/Library/Developer/Xcode/DerivedData/testlog-ahnjaufjbbzpuicykofoftfdpque/Build/Intermediates/testlog.build/Debug-iphonesimulator/testlog.build/Objects-normal/x86_64/testlog.LinkFileList -Xlinker -objc_abi_version -Xlinker 2 -fobjc-arc -fobjc-link-runtime -Xlinker -no_implicit_dylibs -mios-simulator-version-min=7.1 -Xlinker -dependency_info -Xlinker /Users/Jackson/Library/Developer/Xcode/DerivedData/testlog-ahnjaufjbbzpuicykofoftfdpque/Build/Intermediates/testlog.build/Debug-iphonesimulator/testlog.build/Objects-normal/x86_64/testlog_dependency_info.dat -o /Users/Jackson/Library/Developer/Xcode/DerivedData/testlog-ahnjaufjbbzpuicykofoftfdpque/Build/Products/Debug-iphonesimulator/testlog.app/testlog
ld: warning: directory not found for option '-L/Users/Jackson/Desktop/oc/testlog/testlog/CocoaLumberjack/Framework/Mobile/build/Debug-iphoneos'
ld: warning: directory not found for option '-L/Users/Jackson/Desktop/oc/testlog/testlog/CocoaLumberjack/Framework/Mobile/Build/Debug-iphoneos'
ld: warning: directory not found for option '-F/Users/Jackson/Library/Developer/Xcode/DerivedData/Lumberjack-hagiutaowmyznjdswctloqoaktgh/Build/Products/Release'
ld: warning: directory not found for option '-F/Users/Jackson/Library/Developer/Xcode/DerivedData/Lumberjack-dknsbwmeyhqxyugzaxspmmklmamb/Build/Products/Release'
Undefined symbols for architecture x86_64:
"OBJC_CLASS$_DDASLLogger", referenced from:
objc-class-ref in YGAppDelegate.o
"OBJC_CLASS$_DDLog", referenced from:
objc-class-ref in YGAppDelegate.o
"OBJC_CLASS$_DDTTYLogger", referenced from:
objc-class-ref in YGAppDelegate.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
help me！！！

my system is Xcode 6.1,help me...

I would first search [StackOverflow] (http://stackoverflow.com/search?q=[ios]+symbol(s)+not+found+for+architecture+x86_64) for the error "ld: symbol(s) not found for architecture x86_64" when building for iPhone / simulator.  GitHub project issues tend to focus on specific project bugs / feature requests.  (I'm not experienced on mobile, but I would expect x86_64 to be for MacOS X builds, so it may be that an Xcode project setting is incorrect).

I guess where settings are not correct, try many times will not work, so I posted to ask?
Embedded dylibs/frameworks are only supported on iOS 8.0 and later for architecture x86_64
I compiled here the old error? Xcode6 how to set up?

Still  errors . why?why?
Embedded dylibs/frameworks are only supported on iOS 8.0 and later for architecture x86_64

So this is when not using CocoaPods right?

CocoaPods Already installed  right.

CocoaPods may be installed but I think you're adding the files manually or using the Lumberjack project.
Can you try using a Podfile with pod 'CocoaLumberjack' in it?

:+1:  I hit this as well.  I've been using CocoaLumberjack for ages w/ Cocoapods and v2.0 rc2 broke my build. I haven't investigated it much though.  I'll add any additional details I can find.

Was it working with the previous rc?
Cleaning the project before building may also help.

Resolved my issue tonight.  I thought it was similar to this issue but it was completely different.  I accidentally opened the xcode project instead of the workspace so it was a very easy fix.

Good to know! Does it solve your problem @goodcyg ?

Closing, it should be fine now, since we also have the Manual install section doc


build: SystemJS and script tags

Hi,
While doing a build, systemjs version replaces all script tags in index.html (gulp_tasks/systemjs.js):
function updateIndexHtml() {
  return gulp.src(conf.path.src('index.html'))
    .pipe(replace(
      /<script[\s\S]*script>/,
      `<script src="index.js"></script>`
    ))
    .pipe(gulp.dest(conf.path.tmp()));
}

The problem is that this also removes all custom script tags, for example I want to use a script with a type text/ng-template. While having this, that simple regex breaks the final build -- the index.js in dist is never created.
As a workaround to this I wrapped the html code and changed the updateIndexHtml().
index.html:
    <!-- systemjs:code -->
    <!-- build:js(.tmp) index.js -->
    <script src="jspm_packages/system.js"></script>
    <script src="jspm.browser.js"></script>
    <script src="jspm.config.js"></script>

    <script>
      System.import('src/index.js');
    </script>
    <!-- endbuild -->
    <!-- systemjs:endcode -->

systemjs.js:
function updateIndexHtml() {
  return gulp.src(conf.path.src('index.html'))
    .pipe(replace(
      /<!-- systemjs:code -->[\s\S]*<!-- systemjs:endcode -->/,
      `<!-- build:js(.tmp) index.js -->
    <script src="index.js"></script>
    <!-- endbuild -->`
    ))
    .pipe(gulp.dest(conf.path.tmp()));
}

Please consider this or some better solution.

Thanks for reporting. I think you're right, our regex is way too generic. I would hope to find a solution without involving comments but it has to be better than it is.

Uhm, @Swiip did you test your change in practice?
Now I get this error:
[11:06:10] Error: Error: File not found with singular glob: [path]/.tmp/jspm_packages/system.js
    at DestroyableTransform.<anonymous> ([path]/node_modules/gulp-useref/lib/streamManager.js:90:36)
    at emitOne (events.js:95:20)
    at DestroyableTransform.emit (events.js:182:7)
    at emitOne (events.js:95:20)
    at Through2.emit (events.js:182:7)
    at OrderedStreams.<anonymous> ([path]/node_modules/glob-stream/index.js:138:20)
    at emitOne (events.js:90:13)
    at OrderedStreams.emit (events.js:182:7)
    at emitOne (events.js:90:13)
    at DestroyableTransform.emit (events.js:182:7)
    at Glob.<anonymous> ([path]/node_modules/glob-stream/index.js:38:16)
    at Glob.g (events.js:273:16)
    at emitOne (events.js:90:13)
    at Glob.emit (events.js:182:7)
    at Glob._finish ([path]/node_modules/glob-stream/node_modules/glob/glob.js:172:8)
    at done ([path]/node_modules/glob-stream/node_modules/glob/glob.js:159:12)
    at Glob._processSimple2 ([path]/node_modules/glob-stream/node_modules/glob/glob.js:652:12)
    at [path]/node_modules/glob-stream/node_modules/glob/glob.js:640:10
    at Glob._stat2 ([path]/node_modules/glob-stream/node_modules/glob/glob.js:736:12)
    at lstatcb_ ([path]/node_modules/glob-stream/node_modules/glob/glob.js:728:12)
    at RES ([path]/node_modules/inflight/inflight.js:23:14)
    at f ([path]/node_modules/once/once.js:17:25)

Which framework/modules/js are you using ? Are you using master branch ?

I'm using v0.4.0 (Angular1, ES6, SystemJS) with your latest change to this issue.

On v0.4.0, gulp serve:dist is not working. Next release will fix it, meanwhile you can check out the changes on master.

I must admit I didn't test much no. But I don't see the link of my change and your log.

@micaelmbagira I am aware of the issues with serve:dist and I already mixed v0.4.0 with some later changes to the master. So basically serve:dist is working for me. The stack trace I reported above has started after the last @Swiip change to this issue. I don't see the strong link either, but when I revert the change, there's no problem. So there is some mystery link ;)
One more thing I noticed after the last change. This is the result now in .tmp/index.html:
    <!-- build:js(.tmp) index.js -->
    <script src="jspm_packages/system.js"></script>
    <script src="jspm.browser.js"></script>
    <script src="jspm.config.js"></script>

    <script src="index.js"></script>
    <!-- endbuild -->

Previously only the index.js remained and now jspm things stay also.


[BUG] - Border doesn't get applied without border-solid

Hey @jrgarciadev 👋
Thanks a lot for this awesome library 🥳
Describe the bug
Unless border is applied as border solid no border gets applied.
import React from "react";

export default function nextUI() {
    return (

                    Thanks for the awesome NextUI 👋

    );
}

Changing the code to this :
import React from "react";

export default function nextUI() {
    return (

                Thanks for the awesome NextUI 👋

    );
}

To get what I want , i.e. indigo border only on top, I conjured a hack : ( removed borders from all other sides )
import React from "react";

export default function nextUI() {
    return (

                Thanks for the awesome NextUI 👋

    );
}

I checked this too - https://github.com/nextui-org/nextui/pull/429
tailwind.config.js
module.exports = {
  important: true,
  // Active dark mode on class basis
  darkMode: "class",
  i18n: {
    locales: ["en-US"],
    defaultLocale: "en-US",
  },
  purge: {
    content: [
      "./pages/**/*.{js,ts,jsx,tsx}",
      "./components/**/*.{js,ts,jsx,tsx}",
    ],
  },
  theme: {
    extend: {},
  },
  variants: {
    extend: {
      border: ['focus'], // https://night-tailwindcss.vercel.app/docs/hover-focus-and-other-states#default-variants-reference
    },
  },
  plugins: [
    require('@tailwindcss/typography'),
    require('@tailwindcss/forms'),
    require('@tailwindcss/line-clamp'),
    require('@tailwindcss/aspect-ratio'),
  ],
};

globals.css
@tailwind components;
@tailwind utilities;

Your Example Website or App
No response
Steps to Reproduce the Bug or Issue
Create a new next JS application and add Next UI into it.
Dependencies :
"next": "13.1.1",
"react": "18.2.0",
"react-dom": "18.2.0",
"@nextui-org/react": "^1.0.0-beta.11",
"@tailwindcss/aspect-ratio": "^0.4.2",
"@tailwindcss/forms": "^0.5.3",
"@tailwindcss/line-clamp": "^0.4.2",
"@tailwindcss/typography": "^0.5.8",

Dev Dependencies :
"devDependencies": {
    "@types/micro-cors": "^0.1.2",
    "@types/node": "^18.11.18",
    "autoprefixer": "^10.4.13",
    "postcss": "^8.4.20",
    "prettier": "^2.8.1",
    "prettier-plugin-tailwindcss": "^0.2.1",
    "prisma": "^4.8.0",
    "tailwindcss": "^3.2.4",
    "ts-node": "^10.9.1",
    "typescript": "^4.9.4"
  }

Expected behavior
Border should be applied only to top .
Screenshots or Videos
No response
Operating System Version
Mac OS
Browser
Chrome

Here's the stackblitz sample project, with all the code files ( though for some reason this doesn't work ) : https://stackblitz.com/edit/nextjs-dw1wjh?file=pages/index.tsx

Hey guys sorry for the delay, please upgrade to V2


One big chunk

Copied all code from to-do list application in one big commit.

Great Job @Botlhale-Setou 👏🏽
For making use of all appropriate JS practices, DRY, KISS, YAGNI and HTML & CSS PRACTICES.! There is nothing else to say other than... it's time to merge it 🍾🚢 :shipit: . Congratulations! 🎉💯🌟

Highlights 👍

Project is set up correctly ✔
No linter errors ✔
Professional documentation ✔
Items are being saved in Local storage as required ✔
Add/remove functionality working as required ✔
Edit functionality working as required ✔


Version problem

Hello @javisantana ,
I am the member of the cdnjs project.
We want to host this library.
But there is a version problem.
The latest version in git tag is v3.15.9
But the latest version in npm is v3.15.1
Maybe should publish the latest version on npm.
Thanks
https://github.com/cdnjs/cdnjs/issues/6746

Done!

Thanks.


How to install Adonis by yarn without ssh.

My company does not allow ssh outbound,  only http & https are allowed.
Then I can not install Adonis.
Is there workaround for this?
adonis new yardstick --yarn
    _       _             _         _
   / \   __| | ___  _ __ (_)___    | |___
  / _ \ / _` |/ _ \| '_ \| / __|_  | / __|
 / ___ \ (_| | (_) | | | | \__ \ |_| \__ \
/_/   \_\__,_|\___/|_| |_|_|___/\___/|___/

✔ Your current Node.js & npm version match the AdonisJs requirements!
⠇ Cloning master branch of adonisjs/adonis-app blueprint
clone: Repository cloned
⠙ Installing dependencies using yarn✖ Installing dependencies failed!
Command failed: yarn
error Command failed.
Exit code: 128
Command: git
Arguments: ls-remote --tags --heads git://github.com/poppinss/keygrip.git
Directory: /Users/username/projects/yardstick
Output:
fatal: unable to connect to github.com:
github.com[0: <IP_ADDRESS>]: errno=Operation timed out
github.com[1: <IP_ADDRESS>]: errno=Operation timed out

You can clone the repo from github and manually run, npm install http://adonisjs.com/docs/3.2/installation#_manual_installation

@thetutlage Thanks for reply.
The same problem occurred.
I think its not problem of Adonis. Its problem of git://github.com/poppinss/keygrip.git?
But I can`t install Adonis now. Is there any help?
$ git clone --dissociate https://github.com/adonisjs/adonis-app yardstick && cd yardstick && npm install
Cloning into 'yardstick'...
remote: Counting objects: 579, done.
remote: Total 579 (delta 0), reused 0 (delta 0), pack-reused 579
Receiving objects: 100% (579/579), 144.10 KiB | 261.00 KiB/s, done.
Resolving deltas: 100% (295/295), done.
Checking connectivity... done.
npm ERR! git clone --template=/Users/shuogawa/.npm/_git-remotes/_templates --mirror git://github.com/poppinss/keygrip.git /Users/shuogawa/.npm/_git-remotes/git-github-com-poppinss-keygrip-git-develop-f5c31536: Cloning into bare repository '/Users/shuogawa/.npm/_git-remotes/git-github-com-poppinss-keygrip-git-develop-f5c31536'...
npm ERR! git clone --template=/Users/shuogawa/.npm/_git-remotes/_templates --mirror git://github.com/poppinss/keygrip.git /Users/shuogawa/.npm/_git-remotes/git-github-com-poppinss-keygrip-git-develop-f5c31536: fatal: unable to connect to github.com:
npm ERR! git clone --template=/Users/shuogawa/.npm/_git-remotes/_templates --mirror git://github.com/poppinss/keygrip.git /Users/shuogawa/.npm/_git-remotes/git-github-com-poppinss-keygrip-git-develop-f5c31536: github.com[0: <IP_ADDRESS>]: errno=Operation timed out
npm ERR! git clone --template=/Users/shuogawa/.npm/_git-remotes/_templates --mirror git://github.com/poppinss/keygrip.git /Users/shuogawa/.npm/_git-remotes/git-github-com-poppinss-keygrip-git-develop-f5c31536: github.com[1: <IP_ADDRESS>]: errno=Operation timed out
npm ERR! Darwin 15.3.0
npm ERR! argv "/Users/shuogawa/.nodebrew/node/v6.2.1/bin/node" "/Users/shuogawa/.nodebrew/current/bin/npm" "install"
npm ERR! node v6.2.1
npm ERR! npm  v4.0.2
npm ERR! code 128

npm ERR! Command failed: git clone --template=/Users/shuogawa/.npm/_git-remotes/_templates --mirror git://github.com/poppinss/keygrip.git /Users/shuogawa/.npm/_git-remotes/git-github-com-poppinss-keygrip-git-develop-f5c31536
npm ERR! Cloning into bare repository '/Users/shuogawa/.npm/_git-remotes/git-github-com-poppinss-keygrip-git-develop-f5c31536'...
npm ERR! fatal: unable to connect to github.com:
npm ERR! github.com[0: <IP_ADDRESS>]: errno=Operation timed out
npm ERR! github.com[1: <IP_ADDRESS>]: errno=Operation timed out
npm ERR!
npm ERR!
npm ERR!
npm ERR! If you need help, you may report this error at:
npm ERR!     <https://github.com/npm/npm/issues>

npm ERR! Please include the following file with any support request:
npm ERR!     /Users/shuogawa/test/yardstick/npm-debug.log

$ git clone --dissociate https://github.com/adonisjs/adonis-app yardstick && cd yardstick && yarn
Cloning into 'yardstick'...
remote: Counting objects: 579, done.
remote: Total 579 (delta 0), reused 0 (delta 0), pack-reused 579
Receiving objects: 100% (579/579), 144.10 KiB | 192.00 KiB/s, done.
Resolving deltas: 100% (295/295), done.
Checking connectivity... done.
yarn install v0.17.10
info No lockfile found.
[1/4] 🔍  Resolving packages...
[2/4] 🚚  Fetching packages...
error Command failed.
Exit code: 128
Command: git
Arguments: ls-remote --tags --heads git://github.com/poppinss/keygrip.git
Directory: /Users/shuogawa/test/yardstick
Output:
fatal: unable to connect to github.com:
github.com[0: <IP_ADDRESS>]: errno=Operation timed out
github.com[1: <IP_ADDRESS>]: errno=Operation timed out
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

I will use ssh. Thank you.

how did you resolve this issue?

Hey @glevinzon! 👋
This isn't an issue with Adonis.
Please search about how to use npm without ssh.

@RomainLanz hi, maybe you have something to advice me with this issue of mine


Sniper sprite when held in suit slot doesn't rotate with player

Description
See title.
Reproduction

Get weapon specialist sniper kit
Put on the ghillie armor and holster your sniper
Rotate
Weep

Screenshots

Fixed


Little confused

The description says laravel 5, whereas, the About section says Laravel 7.2.
Also when I go to Projects Tab on this repo, I see some TO DOs and In progress. Can you please list down the features, currently working, In progress and planned for future, in the read me/description? So that anyone can easily see.

Hi thanks four your interest in the project is WIP, we are working to upgrade to new laravel version too. And the project process is under beta process.

README file was updated in last commit


Open file in editor is not supported

I have managed to get all features working except opening in sublime by click. I guess I need basisjs-tools for that also, but not sure.
BTW, thanks for sharing this!

Did you read this section https://github.com/lahmatiy/component-inspector#opening-file-in-editor?
It's a little bit messy now. But I'm planing to improve it next few days. Feedback is welcome.
Using basisjs-tools is not a single option anymore. You can use express-open-in-editor for example.

Ahh missed this section. Will try that

Running server to open files seems like overkill, but I understand that browser has not got permissions to do such stuff. Did you though about any workaround? At least we can make some cli tool to run this server so it could be more convenient for end user.

Yep, browsers are limited in interaction with your OS by some sort of requests. So any kind of server is required.
As I understand, you propose some build-in server. I'm not sure it's a good idea. But simple server as separate solution with certain functionality sounds good to me. As you can see in #5, besides open-in-editor feature such server could provide extract-source-fragment feature. Is it help solve you problem?
Also you can implement your own simple server, and use express-open-in-editor as request handler or as basis for your implementation.

No I don't what 'buildin' server rather cli tool that would be installed by user globally. Like npm i open-server -g && open-server serve. Because making some folder and putting express server code manually in it is a rutine and I am sure that I will forget where it is. And with cli tool server instalation, uninstalation, start and stop will be controlled from cli.

npm i basisjs-tools -g && basis server

;)

Ahh great that what I needed. Could you add this in component-inspector readme?

I tried
npm i basisjs-tools -g && basis server

Currently when I click on something in component-inspector I have XMLHttpRequest with this url
http://localhost:8000/open-in-editor?file=/components/TodoItem.js%3A60%3A7%3A65%3A12

(I setted window.OPEN_FILE_URL = 'http://localhost:8000' + '/open-in-editor' )
So I suppose basis server should run in same place as hosting server - I did that.
When I try
http://localhost:8000/open-in-editor?file=/components/TodoItem.js%3A60%3A7%3A65%3A12

in browser
I get
File /Users/sergeylapin/redux-devtools-gentest-plugin/examples/todomvc/open-in-editor not found

This
http://localhost:8000/components/TodoItem.js

correctly returns body of TodoItem.js file

When basisjs-tools server used you don't need set OPEN_FILE_URL setting. Actually OPEN_FILE_URL is fallback.
I will update readme soon with those details.

If I don't do window.OPEN_FILE_URL = 'http://localhost:8000' + '/open-in-editor'; I get `Open file in editor` is not supported

Well, if basis server used it should serve all statics or be a proxy. If you want to use some server just for file opening it isn't suitable. But this kind of server will soon be created.
If you developing something you already use dev-server. Isn't it? May you provide some details about using tools?

Sure I use webpack, mostly its configuration close to https://github.com/erikras/react-redux-universal-hot-example

Do you use webpack dev-server to serve statics?

I guess not
I use just composition of https://github.com/webpack/webpack-dev-middleware and https://www.npmjs.com/package/webpack-hot-middleware not https://github.com/webpack/webpack-dev-server

Well, you can use express-open-in-editor as other middlewares you use. No extra server required.

Can I use it like this?
var webpack = require('webpack');
var WebpackDevServer = require('webpack-dev-server');
var config = require('./webpack.config');

var openInEditor = require('express-open-in-editor');

var app = new WebpackDevServer(webpack(config), {
  publicPath: config.output.publicPath,
  hot: true,
  historyApiFallback: true,
  stats: {
    colors: true
  }
});

app.use(openInEditor());

app.listen(3000, 'localhost', function (err) {
  if (err) {
    console.log(err);
  }

  console.log('Listening at localhost:3000');
});

I have tried to go http://localhost:3000/open-in-editor?file=/components/TodoItem.js with no result. Nothing in logs as well.

Oh.. You on the right way. But I suppose webpack's default handlers don't allow to run openInEditor handler :-/

@lapanoid, that should be possible. My guess, some webpack handler stops triggering middleware at some point (does not call next()). You could investigate dev server's source here: https://github.com/webpack/webpack-dev-server/blob/master/lib/Server.js
Another approach would be to check if any middleware is triggered, when we use app.use(). Smth like this:
var webpack = require('webpack');
var WebpackDevServer = require('webpack-dev-server');
var config = require('./webpack.config');

var app = new WebpackDevServer(webpack(config), {
  publicPath: config.output.publicPath,
  hot: true,
  historyApiFallback: true,
  stats: {
    colors: true
  }
});

app.use(function(req, res, next) {
  console.log('Middleware triggered');
  next();
});

app.listen(3000, 'localhost', function (err) {
  if (err) {
    console.log(err);
  }

  console.log('Listening at localhost:3000');
});

@filipovskii Checked that and I don't have Middleware triggered in logs so I guess you are right and WebpackDevServer don't call middleware

@filipovskii this is the right way to add middleware to webpack dev server https://github.com/webpack/webpack-dev-server/issues/285#issuecomment-145781542

However I have these errors when I do that
GET http://localhost:3000/open-in-editor?file=/components/TodoItem.js%3A60%3A7%3A65%3A12 y @ react.js:203La.y.js.F.exports.openFile @ react.js:204La.11.js.n.subclass.action.inspect @ react.js:233La.7.js.b.templateAction @ react.js:277(anonymous function) @ react.js:48u @ react.js:336
react.js:203

Uncaught NetworkError: Failed to execute 'send' on 'XMLHttpRequest': Failed to load 'http://localhost:3000/open-in-editor?file=/components/TodoItem.js%3A60%3A7%3A65%3A12'.

What does the Network tab say? What's the HTTP response?

When I click on something to open editor, ui stay frozen and I have pending request in Network. Can't reproduce these errors for now.

 Not clear to me why ui is frozen even with pending request

Looks like middleware is not calling response.end() is that possible, @lahmatiy ?

Middleware source is here: https://github.com/lahmatiy/express-open-in-editor/blob/master/index.js
I believe it calls res.end() in any case, and one next(). Probably problems:

next handler doesn't call res.end()
openInEditor doesn't resolve promise somehow

And, blame on me, I make synchonous XHR requests to open files by mistake https://github.com/lahmatiy/component-inspector/blob/master/src/inspector/api/file.js#L32 :(

Fix requests to be async 7a120fe90c78f6cbea46aaba49741363bed76ad1

BTW @lahmatiy try https://github.com/semantic-release/semantic-release this is awesome

@lapanoid Thanks to your feedback, instructions for using express-open-in-editor with webpack-dev-server was added: https://github.com/lahmatiy/express-open-in-editor#using-with-webpack-dev-server

It remains to improve feature description in readme (#7)

Description improved https://github.com/lahmatiy/component-inspector#opening-file-in-editor
Could we close issue?

Did not tryied this. Did you published latest to npm?

Not yet. Coming soon. Maybe tomorrow.

Published \o/
Is there any open questions?

No, I can't as still have this issue. Can I build not minified lib somehow with basis to add some logs and test this?

You can run dev version w/o build (https://github.com/lahmatiy/component-inspector#implementation)
<script src="node_modules/component-inspector/node_modules/basisjs/src/basis.js" basis-config="
  devpanel: false,
  modules: {
    react: {
      autoload: true,
      filename: 'node_modules/component-inspector/src/react.js'
    }
  }
"></script>

@lahmatiy I am not passing this check when I try to click on something;
function isOpenFileSupported(){
  if (openFile) {
    return true;
  }

  var basisjsTools = global.basisjsToolsFileSync || basis.devtools;
  if (basisjsTools && typeof basisjsTools.openFile == 'function') {
    openFile = function(filename){
      openFileByBasisjsTools(basisjsTools, filename);
    };
    return true;
  }

  if (typeof OPEN_FILE_URL == 'string') {
    openFile = openFileByUrl;
    return true;
  }
}

global.basisjsToolsFileSync and basis.devtools are undefined.
If we are using the same example but getting different results.. Are you sure that you don't have some global deps?

global.basisjsToolsFileSync and basis.devtools are used when running on basisjs-tools server. Don't care about it.
You should define global OPEN_FILE_URL variable, as explained here: https://github.com/lahmatiy/component-inspector#opening-file-in-editor.
Using webpack you can define it with DefinePlugin plugin:
    plugins: [
        ...
        new webpack.DefinePlugin({
            OPEN_FILE_URL: '"/open-in-editor"'
        })
    ]

@lahmatiy I tried that and I am running into another issue with it.

When I click on something to open editor, ui stay frozen and I have pending request in Network. Can't reproduce these errors for now.

You made XMLHttpRequest async so ui is not frozen now, but the problem remains.
When you go to
http://localhost:3000/open-in-editor?file=/components/MainSection.js%3A49%3A13%3A49%3A64
in browser what so you see? In my case - I don't get any answer and I don't open editor (sublime).

I got what problem is. When you start server you should get:
$ npm start

><EMAIL_ADDRESS>start C:\git\component-inspector\examples\react-todomvc
> node server.js

open-in-editor configure error:  Editor is not specified
Listening at localhost:3000

So problem is, open-in-editor doesn't found what editor to use.
See express-open-in-editor [usage](https://github.com/lahmatiy/express-open-in-editor#usage] section. You can specify it via ENV or run command like this (on mac):
EDITOR=sublime npm start

More details here
Probably we should throw exception on editor configure error.
I'll update docs to highlight possible problems.

I have currently this

node server.js
Listening at localhost:3000

no

open-in-editor configure error:  Editor is not specified

And no any other errors or warnings?

Did you try open http://localhost:3000/open-in-editor?file=/components/MainSection.js%3A49%3A13%3A49%3A64 in your browser? What is response? Should be "OK".

No response at all.
I debuged express-open-in -editor
    console.log('8')
    opener.open(filename).then(
      function() {
        console.log('9')
        res.statusCode = 200;
        res.end('OK');
      },
      function(e) {
        console.log('10')
        fail(500, 'open-in-editor error: ' + e);
      }
    );
    console.log('11')

my output when I click on smth in inspector is
6
8
11

So opener.open(filename) does not fail nor succeed, so I have no feedback in logs and when I open  http://localhost:3000/open-in-editor?file=/components/MainSection.js%3A49%3A13%3A49%3A64 as well.

BTW I am a mac user =)

@lahmatiy
I think we are close to finish this issue)
Should I be able to run this from terminal?
sublime -r -g components/TodoItem.js:60:7

getting
zsh: command not found: sublime

Hm... how do you setup EDITOR?
It should correctly fails on command error. I'll check it. Thank you for the clue.

running with
EDITOR=sublime npm start

don't work I have
"nano" "components/TodoItem.js:60:7"

if I do that.
I ended with
 setup: function (app) {
    app.use(openInEditor({cmd: 'sublime -r -g'}))
  }

In this case I get
GET http://localhost:3000/open-in-editor?file=/components/TodoItem.js%3A60%3A7%3A65%3A12 500 (Internal Server Error)

Basically because I can't run
sublime -r -g components/TodoItem.js:60:7

in terminal at all

sublime command is allowed in cli? usually it's subl
Sublime has no -r and -g options, it's for VS Code only.

zsh: command not found: subl

Just try open sublime by command in terminal. Then use this command for open-in-editor.
subl (or another name) could be setup by youself: http://olivierlacan.com/posts/launch-sublime-text-3-from-the-command-line/

Ok this helped
Bottom line:
I needed to make this
ln -s "/Applications/Sublime Text.app/Contents/SharedSupport/bin/subl" /usr/local/bin/sublime

and this
 setup: function (app) {
    app.use(openInEditor({cmd: 'sublime'}))
  }

to make open-in-editor feature worked

It's better to setup editor by EDITOR or other ENV variables. Because other developers could use another editors.
Also open-in-editor will try to find editor by known locations in feature, if EDITOR or other settings is not set.
Thank you for feedback. I'll improve documentation and will think about how to make it simpler.

I think this should be at the top of readme as any other info about usage also
https://github.com/lahmatiy/component-inspector#opening-file-in-editor
as people will try to use it before join to any development on this or do some not trivial stuff with it.

It's better to setup editor by EDITOR or other ENV variables.


Fixes css

I fixed 2 width issues and a syntax error.
for .brought-to-you

for .event

will review soon! but looks amazing, thank you so much for this (as well as the super awesome PR desc, srsly why can't all PRs be like this <3)

yay! thanks!

Thank you so much for your review! I'm happy to help this nice project :smiley: